Library table lookup + protein names

Protein names are not consistent, even for the same protein, across the library and CsoDIAq output files. This applies only to proteins with synonyms (e.g. 3/sp|Q01813|PFKAP_HUMAN/sp|P17858|PFKAL_HUMAN/sp|P08237|PFKAM_HUMAN); the synonyms will be out of order.
As a result, it is required to look up each permutation of the order until one is found (assuming that the library is self-consistent).
Recommendation: ensure that CsoDIAq protein output is consistent with the library; add option to parse library and fix it (e.g. order the synonyms alphabetically). This seems to be an issue exclusively for the 'leadingProtein' output field.

This is the behavior csodiaq uses to deal with peptides that match to multiple proteins when no additional peptides can narrow down the list to one of the subset protein. I see how this could be complicate the re-matching to the library for quant so thanks for catching it.
A solution may be to add a colum to csodiaq output for "library protein"?

If I'm understanding this correctly, would sorting the leadingProtein proteins be sufficient? Part of the problem with matching the library to zoDIAq output files, specifically in regards to the leadingProtein column, is they are not expected to match. For example, if the protein grouping 3/sp|Q01813|PFKAP_HUMAN/sp|P17858|PFKAL_HUMAN/sp|P08237|PFKAM_HUMAN existed in the library, but the first protein sp|Q01813|PFKAP_HUMAN was removed by the ID Picker algorithm, we would expect the leadingProtein column to contain 2/sp|P17858|PFKAL_HUMAN/sp|P08237|PFKAM_HUMAN instead.


Potential Improvement to MultilineValues

MultilineValue (actually, mostly LineCollection) seems to contain a lot of hidden cost, and I'm curious about what alternatives have been considered or evaluated.
In particular, I'm looking at MultilineValue#to_s (delegated to LineCollection#text), which has to "reconstruct" the text value from the collection of lines. When dealing with relatively small values this isn't particularly problematic, but does become more so as the value grows. Calling this method every frame (for debugging, or data synchronization reasons) can be detrimental.
While joining the lines after every change is obviously problematic as well, I do wonder about a few other options…

Use memoization to avoid recomputing text when the lines haven't changed.

This requires a little more cooperation with the mutation behaviors, but may be reasonable.

Mirror updates to lines against the original input text String.

That is to say, retain a (mutable) copy of the input text, and write every update to both the lines and that copy of the text.
MultilineValue#to_s can then just return that update copy, with no additional work required.

Make soft-wrapped "lines" conceptually less concrete.

The thought I'm trying to express here is that maybe we don't need to treat the value as a collection of Lines. In general, the lines presented onscreen are a projection of a particular String; can we use that String as the value internally?
To make this work, we would probably maintain a list of ranges/lengths/index pairs as our "display lines", which we can then slice out of the original value.
To avoid the cost of repeated slicing, we would probably want to memoize the values as we go.
When updates are made, only those slices within or after the update range would need invalidated (probably less?).
Only lines actually being displayed need sliced.
Reflow should become faster (since it's now only responsible for recording indices).
Display should become slower for small values, but faster overall (since slices aren't cut "eagerly", some work gets pushed to render-time, but less in general).
This is obviously a larger refactoring, but may provide significant net benefit.

I'd love to know if any of these options have been explored or rejected previously, or if there's any interest in seeing work in any of these directions.

Great ideas. I honestly never expected anyone to push this beyond "Alice in Wonderland" (~170k characters) though I have experimented with "War and Peace" (~3.3M characters ... don't do it).  The expectation was that consumers would fetch the complete value occasionally when the user hits "Save".
I like the idea of a less "concrete" model that keeps the original string in tact. This is worth exploring for me and thank you for the suggestions.

Poking at the code a bit to remind myself of the evil I have done, and adding some notes here:
There are 2 passes over the string:

The first finds word breaks and does a few tweaks on the way: it converts all CRLF chars into \n (which is probably a mistake), adds leading whitespace after a new line and trailing whitespace to words (iow,  foo  bar   becomes ['  foo  ', 'bar   ']), and has a TODO on handling [TAB] which hasn't been dealt with.
The second uses that array of words and measures a word at a time to see if it fits on a line for the given w and font_style, with trailing white space ignored in the measurement since that seems to be how Word-like editors work.

@word_chars is not actually used in either of these. It is used in the #current_word and #find_word_break_* methods. I believe it can be eliminated completely, relying only on characters which are "special" in some other way, which would make i18n easier (and cheaper) in future.
These 2 passes could be combined. It would add make the code harder to follow, but nothing a bunch of comments can't fix.
There is, as far as I can tell, no reason it couldn't maintain indices in the original string rather than allocating new strings, except for the parts where it's mutating the original string (see comment about CLRF above). I'm guessing those mutations are bad anyway and that I need to deal with x-platform line-endings in a more sane way anyway.
I see no reason why this work couldn't be handled in a Fiber so the game remains responsive even when reflowing a very large value.
I need to noodle on this some more.

Oh, there's a TODO to change a length search for a very long word (longer than the w) into a binary search ... I've done that already but I suspect tat something much stupider -- find an average character width and search from there -- will work even better.

I had a go at changing the first pass over the string to produce indices instead of an array of words (it still returns an array of words in the end so the rest works), and that works very well and doesn't break anything. It also eliminated some code, so that's good I guess.


treefmt: error: failed to generate change set: failed to open git index: invalid checksum

Hi,
After recent upgrade, I've encontered below error running nix fmt
treefmt: error: failed to generate change set: failed to open git index: invalid checksum

Any idea what might caused this and how to troubleshoot this case?
My nixos is public here, so you may be as well reproduce it by running nix fmt  on it btw.
Thanks!

Seems like I can no longer reproduce the error, so close this issue for now.


Parser allows injection of runtime code via comments

Flow version: 0.100.0
Expected behavior
Type comments should not be treated as runtime code
Actual behavior
Specially crafted comments allow fooling flow into thinking something has a type that differs arbitrarily from its runtime type

Link to Try-Flow or Github repo:

https://flow.org/try/#0MYewdgzgLgBAhjAvDA5ACwKYBsshQbgChRJYAjJGAbwQHoAqALhgEYZ7aBfIsgOjl5QQAMQCWADwwATABQBKfDFq0YENCACuWKTAwAnPSD0xMejIT5CAMiADu+gMJwIGeYuUwwIWKYxA
Corresponding transpiled code (via babel):
https://babeljs.io/repl/#?babili=false&browsers=last 2 Chrome versions&build=&builtIns=false&spec=false&loose=false&code_lz=MYewdgzgLgBAhjAvDA5ACwKYBsshQbgChRJYAjJGAbwQHoAqALhgEYZ7aBfIsgOjl5QQAMQCWADwwATABQBKfDFq0YENCACuWKTAwAnPSD0xMejIT5CAMiADu-gMJwIGeYuUwwIWKYxA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=false&presets=flow&prettier=false&targets=&version=7.4.5&externalPlugins=%40babel%2Fplugin-proposal-optional-chaining%407.2.0

I think this is by design

Link to docs, for completeness:
https://flow.org/en/docs/types/comments/


运行autocut -t 命令报错，提示RuntimeError: It looks like there is no internet connection and the repo could not be found in the cache (/Users/qqq/.cache/torch/hub)

请问各位有遇到过类似问题吗？运行autocut -t 命令报错
部分报错信息如下：
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/torch/hub.py", line 555, in load
repo_or_dir = _get_cache_or_reload(repo_or_dir, force_reload, trust_repo, "load",
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/torch/hub.py", line 199, in _get_cache_or_reload
repo_owner, repo_name, ref = _parse_repo_info(github)
^^^^^^^^^^^^^^^^^^^^^^^^
File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/torch/hub.py", line 156, in _parse_repo_info
raise RuntimeError(
RuntimeError: It looks like there is no internet connection and the repo could not be found in the cache (/Users/qqq/.cache/torch/hub)

看报错是网络链接问题？


⚠ Bofrost.be has degraded performance

In d8129b4, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1152 ms

Resolved: Bofrost.be performance has improved in eac6ab5.


Allow users to choose the number of cards displayed in binary cards interactive via dropdown

Changes

Add dropdown to the binary cards interactive that allows the user to change how many cards are displayed.

Add dropdown URL parameter. Can be set to either 'true' or 'false to show or hide the dropdown respectively. Default is set to 'true'.

Notes

The interactive now loads 8 cards first, before hiding cards if the digits URL parameter is passed. Mostly done to prevent rewriting majority of the code. This allows us to easily hide and show cards dynamically when the user interacts with the dropdown.

If a start parameter is passed that is less than 8 letters long, e.g BBBBB we add padding to the start of the string so that the correct cards are flipped to the correct side. E.g BBBBB would become WWWBBBBB. This is not shown in the URL.

Resolves #1262

Maybe let the user type in a number they want, then limit it to [1, 16]


Avatar Creator

Enter calculator name -
Avatar Creator
Describe calculator functionality -
Take required input from user and create Avatar for them.
This issue wishes to grab the creative mind.
Under which category you wish to place it -

[ ] Computer Science
[ ] Mathematics
[ ] Physics
[ ] Chemistry
[ ] Biology
[ ] Finance
[ ] Scientific
[ ] Health
[ ] Sports
[x] Let project owner decide
[x] Suggest a new category - Art

Kindly assign this to me

Hey @Upadhyay-Harshit,
Assigned.
You may contribute your code under the folder path -
calc_for_everything\calculators\src\art\avatarCreater
Issue completion deadline - 23rd Oct 1:00:00 pm IST
NOTE - In case the issue completion deadline is not met, the issue will be assigned to a new participant


i am geting error on import android.support.v13.app.FragmentCompat;

i am geting error on import android.support.v13.app.FragmentCompat;
lib the support is not suites me i am using sdk 21 -23
please provide alternate which supports support.v4 or v7 app compats

https://stackoverflow.com/questions/33220233/cannot-resolve-symbol-fragmentcompat

This sample has been migrated to a new location where we can accept Pull Requests (check README for more information).
As recommended by GitHub, we are closing all issues and pull requests now that this older repo will be archived.
If you still see this issue in the updated repo, please reopen the issue/PR there. Thank you!


Auth schema changes made by supabase causing prisma drift detection

Describe the bug
I need clarification on auth schema changes. I have been using prisma with a lot of success and enjoying a really good dev experience. I use multischema and pull auth and public to start, update a few lines in the auth schema, and add the helper functions to the initial migration and in order to successfully sync the shadow db with an initial migrate diff.
Beyond that initial step, I'm able to define RLS policies, add triggers and functions as well as the standard schema evolution using prisma migrate, and everything is great.
However, yesterday my auth schema changed in the following way:
Drift detected: Your database schema is not in sync with your migration history.

The following is a summary of the differences between the expected database schema given your migrations files, and the actual schema of the database.

It should be understood as the set of changes to get from the expected schema to the actual schema.

[*] Changed the `flow_state` table
  [+] Added index on columns (created_at)

[*] Changed the `refresh_tokens` table
  [+] Added index on columns (updated_at)

[*] Changed the `saml_relay_states` table
  [+] Added index on columns (created_at)

[*] Changed the `sessions` table
  [+] Added index on columns (not_after)

I didn't add those indexes, supabase did. My question is how often do you plan on changing the auth schema and do you have any plan to work with supabase devs who work with prisma to guard against random drift brought on by supabase making unannounced changes to the auth schema?
Secondarily, I can easily identify the 4 new indexes that my shadow db needs to know about, so if there is a way to inform the shadowdb of the new changes without resetting the db, that would be helpful.

I moved this to auth.   This is where I believe the changes to auth schema get documented.... https://github.com/supabase/gotrue/tree/master/migrations

having the same issue, exact issue using the create-t3-turbo template. https://github.com/supabase-community/create-t3-turbo

maybe this? https://github.com/prisma/prisma/issues/1122#issuecomment-1510359508

maybe this? prisma/prisma#1122 (comment)

This issue/approach is not technically related and far less less mature than my current solution.
With the help of @GaryAustin1 and his link above, I find that manually keeping the shadow db up to date with supabase gotrue auth schema changes is a small sacrifice to make compared to the sheer number of benefits we get from this solution.

Hey @ODreelist, I've got a couple of questions:

Are you able to disable prisma's drift detection on the auth schema?
Can you describe when you get the drift detection error from prisma? Is it usually after running prisma db pull?
We are working on a way to pull the same gotrue image version as the linked project so that your local development will receive those migration changes.

Let me know what you guys think of (3)!

Hello,
Thanks for the response, I'll do my best to answer.

No, I think they discussed that at length on the prisma issue tracker as it's highly requested. But I am able to resolve the drift detection of auth schema changes with a manual migration/migrate resolve. If we were able to inform prisma and the shadow DB that the auth schema exists and could be referenced, but doesn't need to be tracked, that would solve this problem outright.

I'm using a migrate/push strategy so typically when I make public schema changes and try to run a migration with prisma migrate dev is when I get warned about drift detection (see the original post for what the drift detection looks like). At that point I can typically track the auth schema changes that triggered the drift detection to the gotrue migration repo, (See: https://github.com/supabase/gotrue/tree/master/migrations). I then update my schema accordingly and create a manual migration which will apply the detected changes to the shadow db via prisma migrate resolve and I will have solved the drift detection.  At that point I can continue, with my public schema migrations.

I think that would be helpful bit let me make sure I'm understanding you directly. You are saying we'll be able to pull a docker image that's in sync with my live supabase project? If so I'm sure that would help but keep in mind I use a live supabase environment for dev and a separate one for prod so all of the discussion here applies to hosted supabase instances, not local supabase spun up in docker (we have not used supabase local yet).

I think the most important question I have is this: Does my pattern of manually resolving gotrue->supabase auth schema changes using the migration repo (linked above) as a guide/early warning system of what/when changes will be propagated to supabase customer databases sufficient? does it make sense?
It's a simple enough process to essentially resync my shadow db when supabase makes changes to the auth schema. I wish I didn't have to, but assuming the auth schema changes you guys make are relatively infrequent and small like the one I mentioned in the first post, the benefits of prisma being aware of the auth schema for its magic functions (auth.jwt() and auth.uid() etc.) and being able to use them to define/track RLS policies, functions and triggers inside of prisma migrations as well as manage the public schema through prisma, far outweigh this drawback.

@ODreelist I'm facing the same issue after following the same deploy procedure for multi-schema migrations. I've tried running the missing migrations from gotrue repo, but prisma's migration still returns the same drift errors. What are the steps you're following to keep the shadow DB up to date with gotrue changes?

@cfpg would it maybe be possible to share a repo or just the content of the relevant files to see how you did that exactly? Sounds very interesting


Throw InvalidOperationException if the user tries to modify response headers after the body starts

Sometimes users accidentally set response headers after the response starts and it can be very hard to debug why the client did not receive the header.
https://github.com/aspnet/Mvc/issues/4065#issuecomment-181638058
Throw an InvalidOperationException if the user tries to modify response headers after the first write to the body.
WebListener already does this. Helios used to as well.

Readonly or full on disposed?

readonly, you may still want to enumerate and log them

Is in https://github.com/aspnet/KestrelHttpServer/pull/608


Can't build project wit typescript 2.1.4

VERSIONS?
angular-cli: 1.0.0-beta.22-1
node: 7.2.0
os: linux x64
Repro steps.

Create new project, update typescript to 2.1.4

The log given by the failure.
 10% building modules 2/2 modules 0 active(node:6139) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: AppModule is not an NgModule
(node:6139) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Same here, stuck at this place:

** NG Live Development Server is running on http://localhost:4200. **
20% building modules 84/84 modules 0 active

We don't support 2.1 officially, unfortunately.
@Hongbo-Miao that's a problem with webpack dev server, and unrelated to this issue. It blocks because it's reporting an error. Try ng build.

@hansl thanks, I found out that my issue is related with "angular-cli". It starts from after updating from angular-cli 1.0.0-beta.21 to 1.0.0-beta.22, also happens to 1.0.0-beta.22-1

@hansl in the pipeline? Any ETA? Can't wait for some async/await

Once Angular itself support TypeScript 2.1

@hansl thanks!

I'm already using typescript v2.1 with angular-cli but the latest beta-22 is broken for me, beta-21 works fine. Async and await made my code much more readable.

TS 2.0.10 stuck at 20%

To use typescript 2.1

include "awesome-typescript-loader": "^3.0.0-beta.9" in package.json
rollback angular-cli version to "1.0.0-beta.21"
update tsconfig.json with
 "typingOptions": { "enableAutoDiscovery": false, "include": [], "exclude": [] }


Fix to occur an exception when calling evalsha with multi return type

Make sure that:

[x] You have read the contribution guidelines.
[x] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[x] You submit test cases (unit or integration tests) that back your changes.

@Test
public void lettuceLuaUnknownSha1TestWithStatus() throws InterruptedException {
    RedisClient lettuce = RedisClient.create("redis://localhost:6379");
    RedisAsyncCommands<String, String> client = lettuce.connect().async();
    RedisFuture<String> results = client.evalsha("unknown-sha1", ScriptOutputType.STATUS, "test1");
    results.whenComplete((res, ex) -> {
        logger.info("results=" + res);
        logger.info("ex=" + ex);
    });
    Thread.sleep(10000);
}
/*
NORMAL.
2016-08-04 17:44:02 [INFO ](LettuceRedisClientTest.java:268) [lettuce-nioEventLoop-4-1] [-] results=null
2016-08-04 17:44:02 [INFO ](LettuceRedisClientTest.java:269) [lettuce-nioEventLoop-4-1] [-] ex=com.lambdaworks.redis.RedisCommandExecutionException: NOSCRIPT No matching script. Please use EVAL.
*/

@Test
public void lettuceLuaUnknownSha1WithMulti() throws InterruptedException {
    RedisClient lettuce = RedisClient.create("redis://localhost:6379");
    RedisAsyncCommands<String, String> client = lettuce.connect().async();
    RedisFuture<List<Object>> results = client.evalsha("unknown-sha1", ScriptOutputType.MULTI, "test1");
    results.whenComplete((res, ex) -> {
        logger.info("results=" + res);
        logger.info("ex=" + ex);
    });
    Thread.sleep(10000);
}
/*
?!?!?!.
2016-08-04 17:48:02 [INFO ](LettuceRedisClientTest.java:256) [lettuce-nioEventLoop-4-1] [-] results=[com.lambdaworks.redis.RedisCommandExecutionException: NOSCRIPT No matching script. Please use EVAL.]
2016-08-04 17:48:02 [INFO ](LettuceRedisClientTest.java:257) [lettuce-nioEventLoop-4-1] [-] ex=null
*/

Exceptions positions are different when using evalsha() with STATUS or MULTI. Fixed this problem.

Checking order is different between AsyncCommand and Reactive when completing result. This order mismatch makes the new test to failed. So, I fixed it together.
2.1. AsyncCommand: getOutput() is exists -> if hasError() then comleteExceptionally -> complete().
2.2. Reactive: getOutput() is exists -> if output is exists, complete(). -> if hasError() then comleteExceptionally.

Coverage decreased (-0.03%) to 92.74% when pulling 7248c1d6321cf4e3a8b3ad8130b5054c809548ab on jongyeol:feature/fix-evalsha-with-multi into 860e20097284fd2065ef9dc73eb7869fd129d60a on mp911de:master.

@mp911de , Could you review this too?

What's the reason for using the MULTI output? The intention behind MULTI is to collect transaction results and dispatch these to the previously issued commands.

The reason why the reactive test fails is because the proxy/invocation handler is not propagating the exception. I fixed the invocation handler on master with 0cb10c4 so you might want to rebase your PR.

@mp911de , I rebased and updated this PR. 😄

Coverage increased (+0.1%) to 92.938% when pulling 8dc511e6ae25fe198b94c72fb06d78509e25c0cc on jongyeol:feature/fix-evalsha-with-multi into f43d678cc0b2923b543bcd43a4fc8a6bd44617e9 on mp911de:master.

Coverage increased (+0.1%) to 92.938% when pulling 8dc511e6ae25fe198b94c72fb06d78509e25c0cc on jongyeol:feature/fix-evalsha-with-multi into f43d678cc0b2923b543bcd43a4fc8a6bd44617e9 on mp911de:master.

Thanks a lot. That's merged and backported.


Move generating TXs in tests into svm; add & use spawn TX in tests

Motivation

Closes #2829

Changes

Move code for generating transactions into svm package
Add spawn transactions and use them in tests

Test Plan

TODO

[ ] Explain motivation or link existing issue(s)
[ ] Test changes and document test plan
[ ] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

@nkryuchkov is this change about moving code for generating transactions to svm module, any other important changes? can it be reflected in the pr title, in the current state the title is somewhat obscure

@dshulyak @countvonzero thanks, updated

bors merge

Needs approval from @noamnelke

bors merge

@noamnelke
I added spawn TXs everywhere where nonce was 0 in tests. In other cases, TXs were not submitted, so I assumed that nonce was not checked, therefore there was no need for spawn TXs, so I didn't add spawn TXs there.

Do they get processed and increment the account nonce? I couldn't see the code that does that.

Yes, when SubmitTransaction is called, the nonce is then incremented when a transaction is being processed here:
https://github.com/spacemeshos/go-spacemesh/blob/develop/pendingtxs/pending_txs.go#L123
In other words, I followed this rule when adding spawn TXs:

If a test calls SubmitTransaction, then a transaction will be processed and the nonce will be incremented. When SubmitTransaction is called, tests start with account nonce == 0. For this case, I added spawn TXs.

If a test doesn't call SubmitTransaction, a transaction is not processed, so there's no nonce increment. The tests start with nonce != 0 in this case. For this case, I didn't add spawn TXs.

Please let me know if my explanation is not clear.

bors merge


How to catch invalid_client in SpringBoot OAuth

How to catch invalid_client in SpringBoot OAuth

I can use WebResponseExceptionTranslator interface to catch the common exception Event,  But when the client credentials are wrong, I can't find method dispose it.
package org.springframework.security.web.authentication;

public abstract class AbstractAuthenticationProcessingFilter extends GenericFilterBean implements ApplicationEventPublisherAware, MessageSourceAware {
    protected ApplicationEventPublisher eventPublisher;
    protected AuthenticationDetailsSource<HttpServletRequest, ?> authenticationDetailsSource = new WebAuthenticationDetailsSource();
    private AuthenticationManager authenticationManager;
    protected MessageSourceAccessor messages = SpringSecurityMessageSource.getAccessor();
    private RememberMeServices rememberMeServices = new NullRememberMeServices();
    private RequestMatcher requiresAuthenticationRequestMatcher;
    private boolean continueChainBeforeSuccessfulAuthentication = false;
    private SessionAuthenticationStrategy sessionStrategy = new NullAuthenticatedSessionStrategy();
    private boolean allowSessionCreation = true;
    private AuthenticationSuccessHandler successHandler = new SavedRequestAwareAuthenticationSuccessHandler();
    private AuthenticationFailureHandler failureHandler = new SimpleUrlAuthenticationFailureHandler();

    protected AbstractAuthenticationProcessingFilter(String defaultFilterProcessesUrl) {
        this.setFilterProcessesUrl(defaultFilterProcessesUrl);
    }

    protected AbstractAuthenticationProcessingFilter(RequestMatcher requiresAuthenticationRequestMatcher) {
        Assert.notNull(requiresAuthenticationRequestMatcher, "requiresAuthenticationRequestMatcher cannot be null");
        this.requiresAuthenticationRequestMatcher = requiresAuthenticationRequestMatcher;
    }

    public void afterPropertiesSet() {
        Assert.notNull(this.authenticationManager, "authenticationManager must be specified");
    }

    public void doFilter(ServletRequest req, ServletResponse res, FilterChain chain) throws IOException, ServletException {
        HttpServletRequest request = (HttpServletRequest)req;
        HttpServletResponse response = (HttpServletResponse)res;
        if (!this.requiresAuthentication(request, response)) {
            chain.doFilter(request, response);
        } else {
            if (this.logger.isDebugEnabled()) {
                this.logger.debug("Request is to process authentication");
            }

            Authentication authResult;
            try {
                authResult = this.attemptAuthentication(request, response);
                if (authResult == null) {
                    return;
                }

                this.sessionStrategy.onAuthentication(authResult, request, response);
            } catch (InternalAuthenticationServiceException var8) {
                this.logger.error("An internal error occurred while trying to authenticate the user.", var8);
                this.unsuccessfulAuthentication(request, response, var8);
                return;
            } catch (AuthenticationException var9) {
                this.unsuccessfulAuthentication(request, response, var9);
                return;
            }

            if (this.continueChainBeforeSuccessfulAuthentication) {
                chain.doFilter(request, response);
            }

            this.successfulAuthentication(request, response, chain, authResult);
        }
    }

    protected boolean requiresAuthentication(HttpServletRequest request, HttpServletResponse response) {
        return this.requiresAuthenticationRequestMatcher.matches(request);
    }

    public abstract Authentication attemptAuthentication(HttpServletRequest var1, HttpServletResponse var2) throws AuthenticationException, IOException, ServletException;

    protected void successfulAuthentication(HttpServletRequest request, HttpServletResponse response, FilterChain chain, Authentication authResult) throws IOException, ServletException {
        if (this.logger.isDebugEnabled()) {
            this.logger.debug("Authentication success. Updating SecurityContextHolder to contain: " + authResult);
        }

        SecurityContextHolder.getContext().setAuthentication(authResult);
        this.rememberMeServices.loginSuccess(request, response, authResult);
        if (this.eventPublisher != null) {
            this.eventPublisher.publishEvent(new InteractiveAuthenticationSuccessEvent(authResult, this.getClass()));
        }

        this.successHandler.onAuthenticationSuccess(request, response, authResult);
    }

    protected void unsuccessfulAuthentication(HttpServletRequest request, HttpServletResponse response, AuthenticationException failed) throws IOException, ServletException {
        SecurityContextHolder.clearContext();
        if (this.logger.isDebugEnabled()) {
            this.logger.debug("Authentication request failed: " + failed.toString(), failed);
            this.logger.debug("Updated SecurityContextHolder to contain null Authentication");
            this.logger.debug("Delegating to authentication failure handler " + this.failureHandler);
        }

        this.rememberMeServices.loginFail(request, response);
        this.failureHandler.onAuthenticationFailure(request, response, failed);
    }

    protected AuthenticationManager getAuthenticationManager() {
        return this.authenticationManager;
    }

    public void setAuthenticationManager(AuthenticationManager authenticationManager) {
        this.authenticationManager = authenticationManager;
    }

    public void setFilterProcessesUrl(String filterProcessesUrl) {
        this.setRequiresAuthenticationRequestMatcher(new AntPathRequestMatcher(filterProcessesUrl));
    }

    public final void setRequiresAuthenticationRequestMatcher(RequestMatcher requestMatcher) {
        Assert.notNull(requestMatcher, "requestMatcher cannot be null");
        this.requiresAuthenticationRequestMatcher = requestMatcher;
    }

    public RememberMeServices getRememberMeServices() {
        return this.rememberMeServices;
    }

    public void setRememberMeServices(RememberMeServices rememberMeServices) {
        Assert.notNull(rememberMeServices, "rememberMeServices cannot be null");
        this.rememberMeServices = rememberMeServices;
    }

    public void setContinueChainBeforeSuccessfulAuthentication(boolean continueChainBeforeSuccessfulAuthentication) {
        this.continueChainBeforeSuccessfulAuthentication = continueChainBeforeSuccessfulAuthentication;
    }

    public void setApplicationEventPublisher(ApplicationEventPublisher eventPublisher) {
        this.eventPublisher = eventPublisher;
    }

    public void setAuthenticationDetailsSource(AuthenticationDetailsSource<HttpServletRequest, ?> authenticationDetailsSource) {
        Assert.notNull(authenticationDetailsSource, "AuthenticationDetailsSource required");
        this.authenticationDetailsSource = authenticationDetailsSource;
    }

    public void setMessageSource(MessageSource messageSource) {
        this.messages = new MessageSourceAccessor(messageSource);
    }

    protected boolean getAllowSessionCreation() {
        return this.allowSessionCreation;
    }

    public void setAllowSessionCreation(boolean allowSessionCreation) {
        this.allowSessionCreation = allowSessionCreation;
    }

    public void setSessionAuthenticationStrategy(SessionAuthenticationStrategy sessionStrategy) {
        this.sessionStrategy = sessionStrategy;
    }

    public void setAuthenticationSuccessHandler(AuthenticationSuccessHandler successHandler) {
        Assert.notNull(successHandler, "successHandler cannot be null");
        this.successHandler = successHandler;
    }

    public void setAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) {
        Assert.notNull(failureHandler, "failureHandler cannot be null");
        this.failureHandler = failureHandler;
    }

    protected AuthenticationSuccessHandler getSuccessHandler() {
        return this.successHandler;
    }

    protected AuthenticationFailureHandler getFailureHandler() {
        return this.failureHandler;
    }
}

Thanks for getting in touch, but it feels like this is a question that would be better suited to Stack Overflow. As mentioned in the guidelines for contributing, we prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug.

Thanks for getting in touch, but it feels like this is a question that would be better suited to Stack Overflow. As mentioned in the guidelines for contributing, we prefer to use GitHub issues only for bugs and enhancements. Feel free to update this issue with a link to the re-posted question (so that other people can find it) or add some more details if you feel this is a genuine bug.

thank you for replying my message.


[BUG] TF2 never accepts RCON connections

Describe the bug

TF2 never accepts the RCON connection.
To Reproduce
Steps to reproduce the behavior:

Launch TF2BD.
Start TF2 with the special button.
TF2 never accepts the RCON connection.

Expected behavior

TF2BD should start normally.

Logs

Add any relevant logs. Logs are found by going to File → Open Logs Folder
2021-10-10_17-55-48.log

Desktop:

OS: Windows 10
Version of bot detector: <IP_ADDRESS>4

Additional context

After a quick look through the logs, the problem seems to be the following:

[18:00:56] RCONActionManager.cpp(91):operator (): [SRCON] class srcon::srcon_error @ D:\a\tf2_bot_detector\tf2_bot_detector\submodules\SourceRCON\src\async_client.cpp:103 in send_command(): Failed to initiate RCON connection: No connection could be made because the target machine actively refused it.

I've tried the obvious stuff (installer + portable, disabling AV/firewall) and don't have a clue what could be causing this.
It could be related to the fact that I just switched to a new computer (though I did install the required redistributables.)
If you care about parts, the CPU is a Ryzen 5 5600x and the GPU is a RTX 3070 Ti.

can you verify that tf2bd is setting the launch options correctly?

Sorry, could you tell me how to do that?

In powershell
ps hl2 | select commandline

That would be it. Try setting the options manually as a work around.
dummy -game tf -steam -secure -usercon -high +developer 1 +alias developer +contimes 0 +alias contimes +ip <IP_ADDRESS> +alias ip +sv_rcon_whitelist_address <IP_ADDRESS> +alias sv_rcon_whitelist_address +sv_quota_stringcmdspersecond 1000000 +alias sv_quota_stringcmdspersecond +rcon_password hMVVoAtGhNe7YTTN +alias rcon_password +hostport 47632 +alias hostport +alias cl_reload_localization_files +net_start +con_timestamp 1 +alias con_timestamp -condebug -conclearlog

you can/should change the port and password to be something random

The boot options aren't changing anything for some reason. In PS it still says no command line arguments, despite command prompt having no issues:

alright- because I waited long enough it decided to work.
maybe it's something in my config? I don't think I changed anything related to RCON.
In any case, it works! Thanks for your contributions :)


Fix typo in Korean translation

I found a typo in Korean translation.
Fixed it.

Thank you so much @Jinsung-L ! (also apologies for late response, I was away at conference)

No problem at all. There was nothing really urgent.
Thank you for maintaining the repo.
I really do like your projects 👍


Verifying error code instead of message.

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?
✔

Fixed issues
#10023

See https://github.com/yiisoft/yii2/commit/25cf33183902ca18e3b33d5af15af7922dc67147#r34311495

Merged. Thank you!


remove rubygems blob

no longer used, it was removed from appveyor.yml in bbc1d6ebccbd7f22fea72a9c2b76ef19f3b5beb3

Amen :shipit:

appveyor still busted because of ffi


clean up utils section

the util and utils section are the largest sections and have some apps that can be re-sectioned. some ideas for sections:

streaming
runtimes (or libraries?)
terminals
input

What's the current breakdown of packages we can put in those sections already?

What's the current breakdown of packages we can put in those sections already?

runtime:

aspnet-runtime, aspnet-targeting-pack, dotnet-host, dotnet-profile, dotnet-runtime, dotnet-sdk, dotnet-targeting-pack, netstandard-targeting-pack

terminals (or terminal software):

micro
fingerterm

streaming:

vnsee
restream

input:

rmservewacominput
evtest

i think splitting the dotnet stuff out is the biggest bang for buck

runtime:

aspnet-runtime, aspnet-targeting-pack, dotnet-host, dotnet-profile, dotnet-runtime, dotnet-sdk, dotnet-targeting-pack, netstandard-targeting-pack

terminals (or terminal software):

micro
fingerterm

streaming:

vnsee
restream

input:

rmservewacominput
evtest

i think splitting the dotnet stuff out is the biggest bang for buck

So micro is a text editor for the terminal. I'm not convinced that terminals is a good name for the section if that's installed.
As for runtime, I do think that libraries is a better name, but due to our target userbase, they might confuse that with something to do with books. We'll have to workshop that name a bit more. It's a good section to break out though.
I do like the streaming section as well, but I'm not sure if that's the right name for it. Can't think of an alternative though.
I think input makes sense to leave in utils

So micro is a text editor for the terminal. I'm not convinced that terminals is a good name for the section if that's installed.
As for runtime, I do think that libraries is a better name, but due to our target userbase, they might confuse that with something to do with books. We'll have to workshop that name a bit more. It's a good section to break out though.
I do like the streaming section as well, but I'm not sure if that's the right name for it. Can't think of an alternative though.
I think input makes sense to leave in utils

I think we should also take this opportunity to document all sections properly in https://github.com/toltec-dev/toltec/blob/testing/docs/package.md#section.

I think we should also take this opportunity to document all sections properly in https://github.com/toltec-dev/toltec/blob/testing/docs/package.md#section.

What about an admin category for system management tools? (Like Debian.) Could include nao and erode, for example.

What about an admin category for system management tools? (Like Debian.) Could include nao and erode, for example.

As for runtime, I do think that libraries is a better name, but due to our target userbase, they might confuse that with something to do with books. We'll have to workshop that name a bit more. It's a good section to break out though.

We could also make a devel section for packages which only support other apps. So, all .NET/ASP-related packages, plus for example simple & appmarkable.

I do like the streaming section as well, but I'm not sure if that's the right name for it. Can't think of an alternative though.

Maybe screensharing?

As for runtime, I do think that libraries is a better name, but due to our target userbase, they might confuse that with something to do with books. We'll have to workshop that name a bit more. It's a good section to break out though.

We could also make a devel section for packages which only support other apps. So, all .NET/ASP-related packages, plus for example simple & appmarkable.

I do like the streaming section as well, but I'm not sure if that's the right name for it. Can't think of an alternative though.

Maybe screensharing?

Should we also recategorize the util (singular) section? Seeing that makes it silly that we have both util and utils and remove every single package from the utils section but keep util untouched.

Should we also recategorize the util (singular) section? Seeing that makes it silly that we have both util and utils and remove every single package from the utils section but keep util untouched.

if others are up for it, let's add 3 new sections: devel, admin, screensharing and we'll add more over time

if others are up for it, let's add 3 new sections: devel, admin, screensharing and we'll add more over time


FaaS import config update when the faas link is clicked in the word doc.

Resolves: MWPW-123117 , MWPW-123112
Before:

https://main--bacom--adobecom.hlx.page/resources/reports/content-management-report-2020

After:

https://main--bacom--adobecom.hlx.page/resources/reports/content-management-report-2020?milolibs=faas-import

works fine for me
Just a few things I noticed though:

unit tests are failing. They need to be fixed
I don't think it's relevant to your task, but I discovered this weird bug where fields would appear on validation issues. This screen recording shows it happening.

https://user-images.githubusercontent.com/115231412/210796496-771517f3-5f52-45d5-8c67-75bbd25e8300.mov


Selinux flag giving false positive

Selinux flag is indicating device as rooted though it is not.
tested on other device Samsung galaxy j7 prime also gave false positive with selinix flag tag. even though other devices i checked dint gave false positive with this tag.
But i thik this tag should not be used.. giving false result in so many devices don't know why @
`

It's pretty common to have some false positives while checking SELinux enforcing through properties. I did it long time ago and I came up with testing it by using the libselinux in a shared library. It's slightly better 'cause if the mode can't be read it's assumed that the device is in enforcing mode (EACCES), and if it's not the case (the mode can be retrieved), we can check the value returned (either 0 or any value greater than 0) and return the boolean or whatever you want.
Still, it's a good way to check if the device may be rooted. So, I think it just need some adjustments.

Selinux is returning a false positive.

Removed the Selinux method in 0.1.1 given it's not accessible on later versions of Android and is not "truly" an isRooted indicator. Thanks for flaggin this issue.


MACVLAN - unable to communicate (ingress) with physical LAN

The setup in a few words - A container inside dual NIC coreos machine running on KVM host needing to have an 'external' Physical LAN IP inside <IP_ADDRESS>/24.
Steps to reproduce the issue:
on docker host:
docker network create \
       --driver macvlan \
       --subnet <IP_ADDRESS>/24 \
       --gateway <IP_ADDRESS> \
       -o parent=eth1 \
       management

Continue to create and start a container:
docker create -ti \
       --name macvlan-test \
       --cap-add NET_ADMIN \
       --cap-add NET_RAW \
       --cap-add NET_BROADCAST \
       --net default \
       debian /bin/bash -l

docker network connect --ip <IP_ADDRESS> management macvlan-test

docker start macvlan-test

Describe the results you received:
It is my understanding that at this point it should be possible to communicate with LAN directly from inside the container.
In this instance we try reaching a real machine on <IP_ADDRESS> (target), that is accessible from everywhere else:
docker exec -ti macvlan-test ping <IP_ADDRESS>

# PING <IP_ADDRESS> (<IP_ADDRESS>): 56 data bytes
# 92 bytes from 0e2f0da43c8a (<IP_ADDRESS>): Destination Host Unreachable
# 92 bytes from 0e2f0da43c8a (<IP_ADDRESS>): Destination Host Unreachable

Yet, while capturing traffic on <IP_ADDRESS> (target), it is clearly possible to see arp broadcasts and replies, which apparently never reach the container macvlan-test.
tshark -i eth1

# 02:42:0a:63:00:fa -> Broadcast    ARP 42 Who has <IP_ADDRESS>?  Tell <IP_ADDRESS>
# 5a:00:00:5d:ad:c4 -> 02:42:0a:63:00:fa ARP 42 <IP_ADDRESS> is at 5a:00:00:5d:ad:c4

It becomes even weirder - While we have that previous 'exec' session running, let's start another capture inside the container itself:
docker exec -ti macvlan-test tshark -i eth1

# 02:42:0a:63:00:fa -> Broadcast    ARP 42 Who has <IP_ADDRESS>?  Tell <IP_ADDRESS>
# 02:42:0a:63:00:fa -> Broadcast    ARP 42 Who has <IP_ADDRESS>?  Tell <IP_ADDRESS>

So, the packets get out to LAN, but don't get back into container.
Describe the results you expected:
Inside the container I was sincerely hoping to see something like
docker exec -ti macvlan-test ping <IP_ADDRESS>

64 bytes from <IP_ADDRESS>: icmp_seq=0 ttl=64 time=0.217 ms
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=0.094 ms

Output of docker version:
Client:
 Version:      1.12.6
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   d5236f0
 Built:        Tue Mar 14 21:10:49 2017
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.6
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   d5236f0
 Built:        Tue Mar 14 21:10:49 2017
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 5
 Running: 5
 Paused: 0
 Stopped: 0
Images: 9
Server Version: 1.12.6
Storage Driver: overlay
 Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: macvlan overlay null host bridge
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp selinux
Kernel Version: 4.9.9-coreos-r1
Operating System: Container Linux by CoreOS 1298.6.0 (Ladybug)
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 996.8 MiB
Name: matchbox.gsm-port.com
ID: QFZE:3MA3:HREF:OSMW:GHLU:NR3C:5DX6:4P3M:XEQQ:NX2P:VB7D:DCJ6
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
To clarify even further - all of this happens inside KVM, ie. the physical LAN is actually a virt-bridge and the rest of the KVM guests have connectivity among themselves and to docker host, yet the connectivity fails to be extended back into containers.

You should be able to communicate with the LAN via the default bridge device so long as routing is allowed.
The macvlan is for exposing the container directly to the outside world w/o going through a bridge.
What does the routing table look like inside the container?

docker exec -ti macvlan-test ip route

default via <IP_ADDRESS> dev eth0
<IP_ADDRESS>/24 dev eth1  proto kernel  scope link  src <IP_ADDRESS>
<IP_ADDRESS>/16 dev eth0  proto kernel  scope link  src <IP_ADDRESS>

docker exec -ti macvlan-test iptables -L
Chain INPUT (policy ACCEPT)
target     prot opt source               destination

Chain FORWARD (policy ACCEPT)
target     prot opt source               destination

Chain OUTPUT (policy ACCEPT)
target     prot opt source               destination

container has connectivity to outside, containers on same docker network see each other, their arp requests are being answered by LAN hosts, but never seen inside macvlan network.
I triple checked every access control is off, including host iptables/ebtables and everything else i could think of.
I am not even sure how to debug this, where should it be possible to isolate the issue to? There's nothing weird going on with host os, it's about 10 lines coreos cloud-init, with most lines being the public ssh key. A single systemd unit running this macvlan-test container that simply refuses to work as it should.

Can you check ip route get <IP_ADDRESS>?

I did it before submitting this issue, it was my first thought...
ip route get <IP_ADDRESS>
<IP_ADDRESS> dev eth1  src <IP_ADDRESS>

ping @mavenugo

Here is a painless way to reproduce the issue.

Apparently it is an issue with vultr.com and not docker or coreos. I am closing this.
After trying to reproduce it on my local KVM instance, everything worked as it should. there is connectivity among containers on different kvm hosts via a bridged interface, the issue appears only when vultr.com is used.

Thanks for the update @voobscout!


feat: handle initial index

closing #4 , #5

hi @Hirbod , could you test this pr , it should close #4 and #5
yarn add ssh://git@github.com:gorhom/react-native-sticky-item#feature/handle-initial-index

Hi @gorhom,
thanks, I will check that out. I see you have imported TouchableOpacity from RNGH, let me see if this works for me without that (cause I am using TouchableScale).
And I've seen that you implemented getItemLayout (I also did this locally, but even better if the library takes care of that)
I'll report back, gonna test this now

Hi @gorhom, I tried your fixes and they work indeed, but as I thought, only when I import TouchableOpacity from RNGH. Not exactly what I would love to use, since I am using https://github.com/kohver/react-native-touchable-scale, but its ok for me. Using TouchableOpacity on my Item with your fixes works great on that Hitslop.

glad to hear that, and indeed TouchableOpacity from RNGH will always be better suitable with gesture handler interactions.
Thanks for reporting/testing it :)

You're welcome, thanks for your work. I will fork touchable-scale and rework it to use RNGH, it should work afterwards like I need it.


BreathOfTheWild_HighResShadows is blurry

After applying the BreathOfTheWild_HighResShadows, shadows look blurry. Same as my previous report: CEMU bug ?
http://i.imgur.com/TUOPHQ7.png

AMD?

No: Nvidia GPU. BotW 1.2, CEMU 1.8.0b

Odd. No clue. Try raising the resolution

I'll thanks!
Can be closed

I reopen. For me it was a bug in the rules.txt. I explain:

I took the values in the BreathOfTheWild_HighResShadows pack, and x8 (extreme values, just for the test) = Nothing changed
I search many time, and I finally found other values here that perfectly work for me:

Instead of

[TextureRedefine]
width = 360
height = 360
formats = 0x005
overwriteWidth = 2880
overwriteHeight = 2880

I set

[TextureRedefine]
width = 640
height = 360
overwriteWidth = 5120
overwriteHeight = 2880

Now I have perfect sharp shadows: http://i.imgur.com/GwCY6vA.png
Note that the line "formats = 0x005", makes the shadows totally bugged (60% of the screen went black).
After targeting that the value 360x360 is not correct, I lowered the resolution a bit to get back to my 30fps. My final rules.txt:

[Definition]
titleIds =<PHONE_NUMBER>1C9300,00050000101C9400,00050000101C9500
name = "The Legend of Zelda: Breath of the Wild - Higher Quality Shadows"
version = 2
[TextureRedefine]
width = 720
height = 720
overwriteWidth = 2880
overwriteHeight = 2880
[TextureRedefine]
width = 640
height = 360
overwriteWidth = 2560
overwriteHeight = 1440

For me the actual pack doesn,'t work, in any configuration.

of coruse regular packs wont work, you're replacing one of the values (640x360, half resolution of 720p)

Ok, so you mean I applyied this too "widely"? Sorry it's not clear.
I'm trying a pack that has not consequence on my setup and configuration (and all that I tried), and I found a value that fix this issue and finally does the job. I'd like to understand what I did, and what's wrong in spmething that was not working for me and now is. I there a way to write it properly ?

Your shadow graphic pack is being overwritten by the main graphic pack. Plus, resizing the half res resolution will cause graphical issues (heat waves will not work)

No response in a while, guess I'm closing..

i could try finding the right format. from what i've dumped, these are all the formats that I've seen for 640x360
0x001
0x019
0x816
0x820
0x80e


Add support for riscv64

Re-using the options used in<EMAIL_ADDRESS>add support for running vmtest against a riscv64 target.
Tested by running:
cargo run -- \
    -k /tmp/kbuild-riscv64/arch/riscv/boot/Image \
    -r ../libbpf-ci/libbpf-vmtest-rootfs-2024.09.09-noble-riscv64 \
    -a riscv64 \
    'uname -a'

Which generated https://gist.github.com/chantra/c595fa58ef6fdc72f567e21c1c207e15
/tmp/kbuild-riscv64/arch/riscv/boot/Image is a kernel cross-compiled using:
make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- O=/tmp/kbuild-riscv64 -j4 all

libbpf-vmtest-rootfs-2024.09.09-noble-riscv64 is a rootgs generated by
make ARCHS=riscv64

using https://github.com/libbpf/ci/blob/main/rootfs/ into which I chrooted and installed qemu-guest-agent.

side note..... this did not seem to be able to boot off Image.gz
cc @pulehui

side note..... this did not seem to be able to boot off Image.gz
cc @pulehui

libbpf/ci#390 mentions that qemu not support riscv gzipped kernel yet. And this pr is looks good to me.

oh, missed this. but lgtm assuming it works (I didn't try)

yeah, it did work... to the best of my testing as long as an uncompressed image is used.


Update example to move setting window in frame.

Update canny example to move the setting window :

Wow! Thanks for such an awesome pull request! Actually, your idea is so cool and useful to other users of cvui that it deserves its own example (independent of the canny one). And I can't stop watching the gif you provided 😃
I will merge your PR within the next days. Thank you!

Cool that you like it ! Perhaps it would be better to put this class Setting in the lib cvui so that it is directly integrated into it ?
When I have free time I could do a PR of this class in cvui lib

I love the idea of integrating this feature into cvui, but it has to be done without classes. cvui follows a design where one call should produce one thing on the screen.
I was thinking that we could create a new window component whose X and Y params are pointers, so we can make the window move using that. What do you think?

Sorry to interfer, but I have one suggestion.
cvui's public API does not expose any classes; this is a design choice in order to be an immediate mode GUI.  However, it might still use hidden classes inside its private implementation (inside the cvui::internalnamespace).
Thus, a possible implementation would be to store a dictionnary name->WindowOptions inside cvui::internal (something like map<string, WindowOptions> ?)

Ok, I have not read the cvui source code yet, but i have that look at the use with the examples provided. I did not notice that classes were proscribed. So I do not know what would be the best way to integrate this feature. For my part, I must to read more deeply the source of cvui for better understand are internal work.

Ok, I have not read the cvui source code yet, but i have that look at the use with the examples provided. I did not notice that classes were proscribed.

That's totally my fault, I am sorry. A contribution's guide explaining those ideas is long overdue.

Thus, a possible implementation would be to store a dictionnary name->WindowOptions inside cvui::internal (something like map<string, WindowOptions> ?)

That's a possible solution if we want cvui to handle everything internally.


Extension version is clipped when editor is narrow

Version: 1.72.0-insider (user setup)
Commit: bb7692da16e8d4e01aea254d2f28312a673f351c
Date: 2022-10-04T05:43:53.890Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


non-broadcastable output operand error

A model run produces an error when:

the main model point set contains at least 2 data points
the model contains at least 2 variables (variable A and variable B) where variable A depends on the value of variable B
the output columns list in settings is ["variable A"]

An example to reproduce:
# input.py
import pandas as pd
from cashflower import Runplan, ModelPointSet

runplan = Runplan(data=pd.DataFrame({"version": [1]}))

main = ModelPointSet(data=pd.DataFrame({"id": [1, 2]}))

assumption = dict()

# run.py
import os
from cashflower import run
from settings import settings

if __name__ == "__main__":
    output = run(settings=settings, path=os.path.dirname(__file__))

# model.py
from cashflower import variable

@variable()
def projection_year(t):
    if t == 0:
        return 0
    elif t % 12 == 1:
        return projection_year(t - 1) + 1
    else:
        return projection_year(t - 1) + projection_constant()

@variable()
def projection_constant():
    return 1

# settings.py
settings = {
    "AGGREGATE": True,
    "GROUP_BY_COLUMN": None,
    "ID_COLUMN": "id",
    "MULTIPROCESSING": False,
    "NUM_STOCHASTIC_SCENARIOS": None,
    "OUTPUT_COLUMNS": ["projection_year"],
    "SAVE_DIAGNOSTIC": True,
    "SAVE_LOG": True,
    "SAVE_OUTPUT": True,
    "T_MAX_CALCULATION": 720,
    "T_MAX_OUTPUT": 720,
}

Traceback from executing python wol/run.py:
Traceback (most recent call last):
  File "wol/run.py", line 6, in <module>
    output = run(settings=settings, path=os.path.dirname(__file__))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "venv/lib/python3.12/site-packages/cashflower/start.py", line 581, in run
    output, diagnostic = start_single_core(settings, args=args)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "venv/lib/python3.12/site-packages/cashflower/start.py", line 364, in start_single_core
    output, runtime = model.run()
                      ^^^^^^^^^^^
  File "venv/lib/python3.12/site-packages/cashflower/core.py", line 399, in run
    output = self.compute_aggregated_results(range_start, range_end, one_core)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "venv/lib/python3.12/site-packages/cashflower/core.py", line 451, in compute_aggregated_results
    results = self.agg_calculate_without_grouping(calculate_model_point_partial, batch_start, batch_end,
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "venv/lib/python3.12/site-packages/cashflower/core.py", line 507, in agg_calculate_without_grouping
    results += batch_results * multiplier[:, None]
ValueError: non-broadcastable output operand with shape (1,721) doesn't match the broadcast shape (2,721)

Hi @remdesivir6, thanks for raising the issue and providing a reproducible example.
The issue was caused by a bug in the compute_aggregated_results method, where the multiplier array was not correctly handling the output columns specified in the settings. Specifically, it was trying to aggregate variables that weren't included in the output columns, leading to a shape mismatch during aggregation.
This has now been fixed in version 0.7.3. The fix ensures that the multiplier only includes variables specified in the OUTPUT_COLUMNS setting. Please update to the latest version, and the issue should be resolved.


Task map list for individual tasks

This splits the tasks in task map to staged (having relations or manually added), and unstaged (all the rest) tasks.
The unstaged tasks in a list for now, but that should be simple to change.
The unstaged tasks can be staged by dragging to the task map, either individually or into existing group.

All good points that should be considered.
I now added 2., as we talked that this functionality would be good to have.
I did try 1., but didn't continue further when it caused problems with the drag and drop.

and 3. would be good to do, but I'd say better separately from this PR.

I now added 2., as we talked that this functionality would be good to have.

Great, this works well! I made Trello cards about the other tasks.


Full screen is hiding browser's address bar ( output screen )

I think, most users want to test their code in live mode, means they want to look their output as how it looks in browser ( with addressbar ). at least for OUTPUT white screen, it should not hide address bar.

I'm sorry but the fullscreen feature utilizes the fullscreen API of the browser, and that indicates that in the screen the only thing displayed is the result.
You can instead hide the editors by using this button:


Allow fractional funding fee rates for lncli openchannel --sat_per_vbyte

Aim:
When using a manual fee rate in sat/vbyte to open channels with lncli, allow to use fractional rates with up to two decimal places.
Why:
Since the introduction of ordinals the mempool is relatively full. A large part of the ordinals are set with 2sat/vbyte. It has proven beneficial to have the option to set the rate for opening channels to higher value, for example 2.1. On the one hand, the slight increase in the opening fees ensures that the opening costs are kept as low as possible; on the other hand, the slight increase in the transaction fee means that it is processed preferentially before the ordinals.
Problem:
Actually lnd takes sat_per_vbyte as a uint64 which suggests it doesn't support it.
To support fractional number the data type should be changed to float or double as floating-point data type, limited to one or two decimal  places.

Check this out #7454


Node.js version exception

We should generate an exception for Node versions lower than 4.5, with instructions to upgrade to a newer version.
Related:
https://github.com/Anorov/cloudflare-scrape/issues/241
https://github.com/Anorov/cloudflare-scrape/issues/253

I see a few ways of doing this:

Generating the error from python by checking node --version.
Generating the error from node by checking process.version or process.versions.node.
Generating the error from node by performing a feature test.

The feature test option seems to be the easiest and most efficient way of doing this.
if (typeof Buffer.from !== 'function') {
    throw new Error('Old Node.js version detected: ' + process.version);
}


Custom css

Is it possible to add custom css file on css folder and then include it to the main layout?

hey @DiarQoroviqi
have a look here: https://github.com/shopwareLabs/SwagLightweightModule/blob/master/Resources/views/backend/_base/layout.tpl#L6
we load a custom.css here, which is located here: https://github.com/shopwareLabs/SwagLightweightModule/tree/master/Resources/views/backend/_resources/css

I did it in the same way but for some reasons it doesn't work? Do I have to add any extra config or something else?

not that I know of :thinking:
to be honest this is a plugin, we haven't maintained in a while. and I don't know if it is even working anymore :see_no_evil:

@mitelg it is working with Shopware 5.6.10 :-) I used it some weeks ago as a basic for a new Plugin :-)


install.sh not working with Dash

Shebang in install.sh refers to /bin/sh. On Debian 10 and Ubuntu 18.04 (and I guess most Linux distributions, really), this points to Dash:
$ ls -l /bin/sh
lrwxrwxrwx 1 root root 4 Jan 17  2019 /bin/sh -> dash

The problem is that Dash (version <IP_ADDRESS>-5) doesn't support the syntax used in the script and produces multiple errors upon running, such as:
./ins.sh: 4: [: unexpected operator

Running the installation script with Bash works just fine, so the easy solution is to replace sh with bash (both in the code and the curl [...] | sh command in the documentation). The other solution would be to rewrite the script so it actually works with Dash.

Thank you to have point it out (and for the PR). It will be present in the next release!


feat(i18n): Add a functionality for operators translation

Create operators service
Add translation for do operator
Update unit tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7b1a2d2). Click here to learn what that means.
The diff coverage is 97.61%.

@@            Coverage Diff            @@
##             master     #270   +/-   ##
=========================================
  Coverage          ?   82.85%
=========================================
  Files             ?       25
  Lines             ?      245
  Branches          ?        9
=========================================
  Hits              ?      203
  Misses            ?       40
  Partials          ?        2

Impacted Files
Coverage Δ

src/operator-docs/index.ts
100% <100%> (ø)

src/app/app.component.ts
65.38% <100%> (ø)

src/operator-docs/en/utility/do.ts
100% <100%> (ø)

src/app/core/core.module.ts
100% <100%> (ø)

src/operator-docs/en/index.ts
100% <100%> (ø)

src/app/operators/operators.component.ts
88.09% <100%> (ø)

src/operator-docs/ru/utility/index.ts
100% <100%> (ø)

src/operator-docs/en/utility/index.ts
100% <100%> (ø)

src/operator-docs/ru/index.ts
100% <100%> (ø)

src/app/core/services/language.service.ts
96.55% <100%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b1a2d2...d2f3e78. Read the comment docs.

@IraErshova please don't move EN version into en folder
then you will have to move all operator docs
and this will be not cool at all


StorageClient.ListObjects should default to an empty prefix

otherwise I'm typing 'client.ListObjects(bucketName, "")' all the time.

We discussed this before in #17 - back when it was an overload instead of just a parameter with a default. The vague consensus there was that listing objects in a bucket with no prefix was a rare situation. Certainly happy to reconsider - and as the prefix is the last non-optional parameter, we definitely can make it optional.
Possibly talk to the team to see what proportion of ListObjects calls don't specify a prefix?

There’s value in decreasing the number of concepts that need to be considered as people ramp up. By making the prefix non-default, you require everyone calling ListObjects to understand what a prefix is and why they might need one and what to pass when then don’t care just they’re just trying to make something work. The use of a prefix is for optimization.

Hmm. I agree it's an optimization in that you could apply the filtering client-side, but I think it's probably one that it's worth making people aware of right from the start. (While I like to make things simple, I'm also in favour of highlighting things that users really should be thinking about from the start. See Noda Time for plenty of examples of that...) I'm not convinced either way yet. (Once we've agreed the right thing to do, the implementation is obviously trivial.)

Just to chime in and ping the old thread. I am with csells.  I think an optional parameter would be the best of both worlds.  We can have a prefix param but also not require the user to pass in an empty string.

@ivannaranjo and @chrsmith - in issue #17 you both requested this be mandatory (at least, Chris's "yes" may have been about that, or may have been about the delimiter). Any strong feelings against me making this optional?
(I'm assuming it's still worth having as a method parameter rather than putting it in ListObjectsOptions, which is relatively unwieldy.)

Ping @ivannaranjo and @chrsmith for feedback...

I do not have strong opinions, but have a slight preference for requiring you to specify the prefix. But ultimately, if this bug report is a proxy for end-user feedback we should make the fix if doing so is trivial. So I'd push for having an overload without the parameter, even if don't like the idea in principle.
As for why I'd rather have the API force you to specify a prefix, using "" to mean "get everything" and "/images" to just get things in the "/images" pseudo-folder makes sense. Having three different overloads (no-prefix, with-prefix, and with ListOptions object) seems like overkill.
Moreover, IMHO we don't want to make the API too initiative and like a file system -- e.g. like the File and Directory BCL types -- because GCS is not a file system. It is a storage API with a very specialized set of constraints. Like Jon said, getting users to internalize that up front is in their best interest in the long-run.
But nuances aside, in this situation there is no underlying complexity/runtime argument. It is just about removing a parameter in the situation where it is not needed. (When you don't care what the filter is or don't want to provide one.)

@Capstan Do you have any opinion on this from a Storage team perspective? Do we want to always make clients think and be explicit when they're listing objects (because listing all objects is relatively rare) or is listing all objects within the bucket such a common operation that we should avoid clients having to be explicit about it?

IMO, it should default to an empty prefix. I think of it as a filter and filters as being optional.

Righto, will do - thanks for the feedback.


Create a CI for publishing DSS snap

Why it needs to get done
To have an automated way of publishing DSS to the Snap store.
What needs to get done
An automated workflow that can be used for releasing the DSS to the Snap Store on an agreed event (on demand, on merge, etc.) Please NOTE this task depends on #24, if we are able to leverage other solutions (like https://snapcraft.io/build) we may not need to build a workflow for this at all.
When is the task considered done
Please NOTE this task depends on https://github.com/canonical/data-science-stack/issues/23, the description of this task will change accordingly.

With this issue we are still aligning on name for snap in snapstore after that the snapstore should automatically build the snap from default branch to edge track. With regards to this I opened this issue https://github.com/canonical/data-science-stack/issues/56

The snap name data-science-stack is reserved. I have requested

alias dss for the snap https://forum.snapcraft.io/t/alias-request-for-data-science-stack/39515
change the ownership from me to Canonical https://forum.snapcraft.io/t/transfer-request-data-science-stack-to-canonical/39518

Finding: If you want to be part of the forum you need to create an account the Canonical one will not work.


[5.0.0-beta1] Refreshing index or saving entry in section causes Memory allocation error: 1038 Out of sort memory

Issue
Since upgrading to Craft 5 from Craft 4 and to Scout 5.0.0-beta.1 I am encountering an issue where trying to refresh an index, which looks to get all entries from one section that contains 3000 entries, causes a MySQL issue Memory allocation error: 1038 Out of sort memory.
Refreshing another index which gets all users, of which there are 550 works fine.
I don't think that increasing server sort buffer size would be necessary.
The index refresh is working fine on Craft 4.9.1 and Scout 4.0.0.
Resaving a single entry to be indexed also causes the same error for the section.
The entry is only made up of plain text, lightswitch, dropdown and WYSIWYG fields, no matrix fields.
 And if you're able, could you share your index & transformer setup? Thanks!

@janhenckens Thanks for getting back so quickly.
I have tried with and without, the issues happens with either.
I also tried playing around stripping it back to just indexing an ID, that still caused the error.
The only way i've found to stop the error is to limit the criteria query to 500, then it does it with ease.
Here is the scout config I am using. The guard behaviour adds some light params for consistency across the site.
scout.php.zip

Thanks, I'll have a look at your config.
This also got me thinking that Scout could/should be taking advantage of the batched queue jobs that were added in 4.6(?), at least for the larger jobs like a full index refresh.

Thanks. I think the transformer is fairly light, and that generally this shouldn't be difficult for Craft
Nice idea about the batched jobs

Minor question @zizther but I see you have "storyReadTime" as a property in your transformer. What type of field is that?

@janhenckens this is just a plain text field.
The content in the entry is only plain text or CKEditor fields

@janhenckens Thanks for testing that out.
I have tested on my local DDEV, disabling all plugin, apart from Scout, and custom modules.
The queue log didn't really show too much more than what i've already mentioned, however I have emailed this over to you.
This was a Craft 4.9 to 5.1 update, not sure if this could have caused any issues in relation to the data management.

Tested with the site/database in question, here are my findings:

Having only the title in the transformer => same issue ⛔
Doing the same element query - batched per 1000 - in a separate console controller => same error ⛔
Query with all plugins disabled => same error ⛔
Removed a bunch of fields from the section => same error ⛔
Tried pruning revisions and it crashed on 1 specific entry ID (71053) ⛔
Restored a backup and tried to view that same entry => same error ⛔
Deleted that entry from a console controller ✅
Query works ✅
Indexing works ✅

Thus the issue seems related to that specific entry and Craft 5, not to Scout.
I'll close this issue for now - feel free to reference this off course should be raise the issue with P&T!

Thanks for your help looking into this.
Upon further investigation, this is an issues with Craft 5 itself and the queries based on the volume of content in the query.
It just so happened to be the Scout plugin was the first it show there was an issue.


Colours are unreadable when used with a light terminal background.

When running with a light-coloured terminal background, the colours used for syntax highlighting make it impossible to read:

@schinckel Thanks for your reporting 🌈 I am currently planning a mechanism in #23 that allows users to configure the colors for each item. Therefore I will be closing this, since this issue will be encompassed within #23 (Please feel free to reopen it if there's anything else).


Fix minor English grammar issues in README.md

This PR does not affect functionality.
This is just a very minor (and pedantic) fix in README.md; s/Readed/Read/ and s/Writed/Written/ in some example code. I submit this fix without any claim to copyright; the copyright of these changes belongs to Flipper Devices Inc. for any purpose (this is barely worth a PR so if you commit outside of this without credit to me that's completely fine - it was just bothering me a little).

Thx!


GRADLE_OPTS documentation in build environment is misleading

I found the documentation of GRADLE_OPTS to be misleading. For instance here in the current documentation:
GRADLE_OPTS
    Specifies command-line arguments to use when starting the Gradle client. This can be useful for setting the properties to use when running Gradle.

It made me think that I could have used GRADLE_OPTS=-Poption=value or GRADLE_OPTS=--no-daemon as the doc talks about gradle command-line arguments, with a link to cli interface.
Expected Behavior

gradle command-line arguments should be accepted in GRADLE_OPTS, or
the documentation should be changed to state that GRADLE_OPTS can only be provided with JVM arguments, such as -Doption=value for setting a system property (very as same as JAVA_OPTS).

Current Behavior
$ GRADLE_OPTS=--no-daemon ./gradlew clean
Unrecognized option: --no-daemon
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Context
I wanted to give command lines arguments to gradle via GRADLE_OPTS envvar, such as the --no-daemon option in my CI environment.
Your Environment

gradle 4.10.2
openjdk 11+28

Done in https://github.com/gradle/gradle/commit/c0593bfa8a5da9135593ea6325c9356129c17536


Fix issue #734 Only final html test report is generated

@juherr This PR only touches test files, how does it fix the issue?

It add test case described by the issue, and as it is working, it means the issue is "fixed" because not a issue.
But this one is wip as long as I'm not sure to have understand #734

Thanks for the clarification, I got confused by the title of the PR which says it's a "fix".


Remove obsolete argument --no-patch

Argument --no-patch is obsolete in PHPCS 3+
Fixes #11

There is another problem with the tempfile, causing phpcbf to not fix anything. See https://github.com/jcartledge/atom-phpcbf/issues/11#issuecomment-332007649


🐛 Document and update dependency of ks/ks on ks/OSA

Summary
This PR updates the references to ks/OSA to use the latest version, and updates the release procedure document to mention this.
Related issue(s)
Fixes #

/cc @pdettori
/cc @ezrasilvera
/cc @eaepstein
/cc @nirrozenbaum
@KPRoche

I don't think we ever decided that k3d is a platform we should test on each release. As it is not tested, we shouldn't update the release docs to include updating that example.

@francostellari: this PR is also updating dependencies

/lgtm
/approve


problems with loop drive in case of error or abort

If pishrink does not leave properly, the loop device remains open. This takes up memory space until the loop device is deleted.
Remedy could bring a trap handler

sorry double


Add annotation with proper types for entity properties

The most IDEs start showing returned types on getter calls after these changes.

I also wonder about using @var annotation for setters and @return one for getters in Symfony Demo. What do you think about adding it?

If we add the @var for properties, I guess it makes sense it add it to getters/setters too.

When the properties are annotated, you shouldn't have to repeat the type for the returned values of the getter methods as IDEs are able to infer the return types then.

@xabbuh Do you suggest to fully revert commit about annotations for setters / getters?

@bocharsky-bw For setters where we do not have type hints (i.e. scalar type arguments) we should keep them.


Support Klingon Space Frames in the Starship portion of the character generator

The Klingon Core book includes Klingon spaceframes; the generator needs to support these.

This support has been pushed to the server.


More space at top and bottom of data

Resolves #135

Looks good, as long as it definitely works- which I think it does.

I can't reproduce the bug it was removed for in the first place :) Think it was likely something to do with setting y0Value of the area series rather than this


Pull Request to implement Feature #66

Pull Request to implement Feature #66
Let me know if I missed something or if you see something weird :)  I think it will also be a good idea to implement rails counter cache feature to reduce the number of queries when viewing the  forum's index page.

Um is there any chance you can reword your commits to tell us what they did? It's pretty hard to debug later is the reason.

I'm new to git,  can that be done through github ?

found a document,  I'll see what I can do.

okay, I think that did the trick,  please let me know how it looks.

Weird, it seems like now there's two commits for everything...

I think that we can deal with the two commits issue when merging locally using rebase so will evaluate the change and get back to you..

Made the chances as suggested I'm not sure why github is showing the same commit multiple times but they have the same id.

do I need to make a new pull request? or will the changes get pulled  on this one ?

No this one will do just fine :-)

Alright thanks for taking the time to provide feedback, I appreciate it  :)

Almost all the tests fail, I think because Category is now required and the factories have not been updated

I'm not familiar with the factories stuff, but I can give it a crack. How do you run the forem unit tests ?

Good question.
I think it's something like:
bundle exec rake -f spec/dummy/Rakefile db:drop db:create db:migrate RAILS_ENV=test && bundle exec rspec spec
@radar?

Thanks that does run the test.

@parndt  I updated the Factories to support categories  let me know how the changes look.  Thanks :)

Great work!

Awesome! Thanks guys :)


add auto-approve feature configurable per CSP

fixes https://github.com/eclipse-xpanse/xpanse/issues/1652
Huawei auto approve service templates is enable:
Register huawei service template with state  approved:

Update registered huawei service template with state approved:

FlexibleEngine auto approve servie templates is disable:
Register flexibleEngine service template with state  approval pending:

Update registered flexibleEngine service template with state approval pending:

LGTM


Update frontend Dockerfile

Installing the dependencies is required otherwise it would fail to compile and install streamlit.

Thanks for the PR @jpzhangvincent !


Setting the background base map to a any color gives a white background

Describe the bug
Using maplayers widget, switching from Bing maps to any solid color, gives a white background.
To Reproduce
Steps to reproduce the behavior:

Open ui-test-app with any imodel/bim.
Open map-layers widget (might me collapsed on the right side)
In the 'base' combo box, pick 'Solid Fill Color':

Expected behavior
Background color of the map should match the one shown by the color picker.
Screenshots

Desktop (please complete the applicable information):

OS: [e.g. iOS]
chrome
iTwin.js Version master (3/2/2022)

Easier repro steps:

Open any geolocated iModel in display-test-app.
Ensure the background map is enabled.
Key in fdt set map base color 255 0 0

Expect: the background should be red.
Observe: the view's own background color displays instead (not necessarily white).

This regression was introduced by @RBBentley's #2881 for model map layers.
I'll try to figure out what changed, and make sure we have tests to cover this.


add test switch to install.sh

Would be nice to be able to use the same script to just build or to build and also test. One way to do that would be to recognize a --test switch in the script and only run npm test when that's passed.

Fixed w/ #30.

npm run test or gulp test from the root.


Improve headline responsiveness on big tablet

fix horizontal scroll
wrap buttons in the Orbit's Stack
improve responsiveness on big tablet size

Before

After

No layout looks broken on DESKTOP (green color), and I have horizontal scrollbar down(orange color)

No layout looks broken on DESKTOP (green color), and I have horizontal scrollbar down(orange color)

No way 😨Will be looking in it now


Fix justification

Codecov Report

Merging #878 into master will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   63.62%   63.72%   +0.09%
==========================================
  Files          88       88
  Lines       14775    14781       +6
  Branches     3285     3287       +2
==========================================
+ Hits         9401     9419      +18
+ Misses       3216     3203      -13
- Partials     2158     2159       +1

Impacted Files
Coverage Δ

vm/src/obj/objstr.rs
73.9% <100%> (+2.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e867ed...0e9acdc. Read the comment docs.


Can't set the background color when dragged

I think we're talking about a different problem, and I apologize if I'm still confusing you.
Your solution doesn't solve my problem.
Your solution is a way to change the 'font color' of the editor.
But that's not what I need, because the text color changes just fine without the trick.
What I want is a way to change the 'when dragged, the background color' in the editor.
The 'output image' according to your solution also doesn't have the solution I want: the background color of the dragged part (selection text) is still white. If the text is white, the text is not visible because it is similar to the background color.
If this is not resolved, I will continue to work around the issue on my own as before. Until this is resolved, I recommend leaving the issue open to find a good solution.
I think I may have raised the issue confusingly before, so I'll reopen the issue to clarify.

          @jinwon7878 - you didnt follow my solution at all

      #root div .ProseMirror * {
        color: blue;
      }

      * {
        color: red;
      }

      #root div .ProseMirror {
        background-color: black;
        padding: 0 24px;
        font-size: 15px;
      }

output:

please notice the:
      * {
        color: red;
      }

which does the trick here, change the selection color, then:

      #root div .ProseMirror * {
        color: blue;
      }

Will let you override the color to whatever you want to be the color of the actual text
Originally posted by @GuySerfaty in https://github.com/10play/10tap-editor/issues/166#issuecomment-2268879058

you want to change the color of the selected text not the cursor or the background color of the selection,

so in the image above the selected text will have different color, I dont think it's possible.
did you ever saw an example of app that modify only the selected text?

@jinwon7878 - that's the reason it's not possible for now:
https://css-tricks.com/almanac/selectors/s/selection/#aa-browser-support
the solution I suggested solve part of your issue but still you wouldn't get full control of the selection till iOS will support that css tag
Im closing this issue for now, if you need anything else please feel free to send email to<EMAIL_ADDRESS>Thank you

@jinwon7878 - ok I think I see what you mean, we will have a solution for it in a bit

Should be fixed on 0.5.17
@jinwon7878 - can you confirm?


can't edit config

Plugin Config refreshing and back always to default after server restart, also plugin enabling even if set is_enabled to false

#constru


add riemann events sink

Basically a copy and paste of metrics sink. The values I have chosen to send to Riemann are an opinion of what I would find useful based on my current Riemann usage.
fix #1160

This change is

Completed CLA with wrong google account at first so getting commit missing GitHub user however not sure how to fix that now?

@k8s-bot ok to test

Did you try git commit --amend? In the worts case you can try to just create a new PR.
Also I'm not familiarized with Riemann at all, so we need to find someone to review it.
@erimatnor @jfoy @jsoriano @huangyuqi are you able to make the review?

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks broke.

events/sinks/riemann/driver.go, line 1 at r1 (raw file):

// Copyright 2014 Google Inc. All Rights Reserved.

2016?

events/sinks/riemann/driver.go, line 48 at r1 (raw file):

}

type riemannConfig struct {

It'd be nice to create a k8s.io/heapster/common/riemann package to avoid duplicating code between events and metrics sinks.

events/sinks/riemann/driver.go, line 167 at r1 (raw file):

				"component":        event.Source.Component,
			},
			Metric: riemannValue(event.Count),

Does this event count make sense as metric? (Just asking, I don't have a better proposal in any case :))

events/sinks/riemann/driver_test.go, line 60 at r1 (raw file):

}

// Returns a fake kafka sink.

kafka? :)

Comments from Reviewable

@shmish111 please, update sinks documentation too

Sorry for the delay. I've updated the PR by extracting common logic.
WRT the event metric, I think this makes sense when reading http://kubernetes.io/docs/api-reference/v1/definitions/#_v1_event however it is opinionated to some extent, no way round that really.

Build failing dur to someone else's code
FAIL	k8s.io/heapster/metrics/sources/kubelet [build failed]

@piosz I don't get the problem with the git commits, they all seem fine, all assigned to me and my github picture is there.
@jsoriano can you review my changes please.
Thanks!

@k8s-bot test this

@jsoriano the e2e tests failed due to my documentation change, travis failed for another reason, I can't work out why cla thinks my commits are missing Github user, basically the PR looks a mess however unit tests all work on my local machine. Not sure if any of this is a problem in getting this PR merged, if so then I'm not sure what to do.

@k8s-bot test this

Who is reviewing this? Please let me know when this is LGTMed and ready for the review

Reviewed 5 of 5 files at r2.
Review status: 6 of 7 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

events/sinks/riemann/driver.go, line 32 at r3 (raw file):

// Abstracted for testing: this package works against any client that obeys the
// interface contract exposed by the goryman Riemann client

This comment was for the interface you have moved to common, move also the comment please :)

events/sinks/riemann/driver.go, line 125 at r3 (raw file):

}

func (sink *RiemannSink) sendData(dataEvents []riemann_api.Event) {

sendData could be moved to common, it's the same for metrics and events, isn't it?

events/sinks/riemann/driver_test.go, line 61 at r3 (raw file):

}

// Returns a fake kafka sink.

kafka still here :)

metrics/sinks/riemann/driver.go, line 31 at r3 (raw file):

// interface contract exposed by the goryman Riemann client

type RiemannSink struct {

This struct is defined three times, maybe a better abstraction in common is possible.

Comments from Reviewable

I have added some comments to the review. Thanks for your changes @shmish111 !

@shmish111 please sign the CLA

@k8s-bot test this

@jsoriano I've made some changes based on the comments
@piosz I have signed the cla, the problem is that github somehow thinks that some commits aren't mine, I have no idea how to fix this as all the commits seem to be properly associated with my github account.

@shmish111 are you using Riemann sinks? we were thinking about deprecating them if they are not being used, you can see the conversations about that in #1407 and #1419, we are waiting for your opinion.
Thanks!

Reviewed 1 of 1 files at r3, 4 of 4 files at r4.
Review status: all files reviewed at latest revision, 11 unresolved discussions, some commit checks failed.

Comments from Reviewable

@shmish111 about the CLA, I don't know if it's related, but is it possible that you are signing it with a different email than the used in the commit messages?

@jsoriano sorry, I've had github notifications turned off for a while and didn't check your comments.
I'm sorry to admit that I am not using heapster any more as I am working on a new project that doesn't have access to Kube (yet). Also, as a big fan of Riemann I am surprised to find myself drawn in to the new Elastic beats components, despite not being nearly as nice to configure as Riemann and being written in go (puke) ;-) I find the overall new BELK stack very appealing from an operational point of view. I am currently using Riemann but I can see it fading away and I can also see monitoring heapster with beats more likely to be allowed in to my current organization. I feel sad to say it but I think I agree with deprecating some of the sinks, including Riemann. I feel that heapster beats would be popular though, does it exist?

Hi,
I am currently working on the RIemann metric sink (to use https://github.com/riemann/riemann-go-client instead of Goryman). I will probably do the PR today. I will then work on the event sink.
I don't think Riemann is fading away, and the next Riemann release will bring a lot of improvements. Ofc, it will never be as popular as elastic/beat ;)

@mcorbin good to hear Riemann is not dead! Will your work take the place of this PR?
I am currently torn between beats etc and Riemann, give me some ammo to push Riemann, I can't find any docs about new features coming or anything like that!

@shmish111 i changed several things on my PR on the metric sink (#1562), but I will take inspiration from your code ;)
Regarding Riemann, the last release was the 3 month ago (changelog here). Since was added things like microseconds time resolution in the protocol (limited to the second currently), complete refactoring of the influxdb output (should support all influxdb functionalities), new outputs (Kafka, netuitive), various bugfixes... And more to come ;) If you have questions about Riemann (i can give you some use cases when i use Riemann in my company for example), you can also contact me directly ;)

I think this PR can be closed as #1591 was already merged.

closing as per above comment.


Increase Timer resolution

Currently timer can only be made to be as quick as 1 ms a sec
This won't do for high resolution timing apps like games.
Consider making the Timer class accurate to System.TimeSpan.Ticks instead of Milliseconds.

You can use System.Timers.Timer
https://learn.microsoft.com/en-us/dotnet/api/system.timers.timer?view=net-8.0
but it's probably won't be a good idea to update control's properties in such timer event handler.


Handle long click for items?

Hello,
I'm trying to use "long click" function for items...
I didn't find solution.
Thanks

did you manage OnClick function? i couldnt even manage that function :(

Set Adapter for SearchView, OnItemClick will work
mSearchView.setAdapter(new SearchAdapter(this, results));


gfauto: check status as well as signature during reduction

During reduction, we just check that the status is CRASH or TOOL_CRASH, and that the signature matches. This is normally fine; we don't have to worry about differing statuses because the signature should be quite unique and "no_signature" should usually be regarded as a bug. However, during something like a stack corruption or a reboot, "no_signature" might be more likely and it would be useful to reduce based on the status.

Fixed by #747


add setup.py and version

Nice work! I have been playing around with the code and its easy to work with.
For me, it would be easier if the package was installable. I hope this will reduce the barrier to entry for others also.
This PR:

Added setup.py
This setup makes mongo-rdkit locally installable using pip install . (run from the same directory as setup.py)
Up to original authors whether to push to PyPI.

Added a version to mongo-rdkit.__init__.py. Started at version = '0.0.1'. You can now check the version in a pythonic way:

import mongordkit
print(mongordkit.__version__)

Updated the Installation instructuctions for mac/linux, but not windows. If the maintainer has access to windows, please advise as to whether installation works and how the README should be updated? (feel free to push changes directly)

Glad that you found it easy to work with and thanks for putting together the setup! I don't have access to windows, but I will contact Marco Stenta, who does - and see how the installation instructions should be updated.


documentation isn't clear on Loading components

Particularly with the progress bar. I can load the page and it'll appear but I can't dynamically update the progress bar with React. The doc's show how to load it in a page but nothing else after.
I've spent most the day trying to figure it out as well as search for an answer online but no one seems to  have the same issue.
How do I increment the progress.
I'm making a survey and I want the progress bar to increment after an answer is answered.
I appreciate this may not be the best place to ask but it seems the only place to try and get some help specifically with this.

You should use the setprogress method. Like so
document.querySelector('.mdl-js-progress').MaterialProgress.setprogress(45);
That will update the progress placement.
Our current docs don't cover JS usage at all. New components have some form of it. Existing components however are going to be updated primarily with the 2.x update when we normalize the JS setup and configure things so we can auto-generate API docs.

Been trying that too and I get this:
"Cannot read property 'setprogress' of undefined"

Supporting React and integration with other systems is out of scope of what we can handle. Try asking for help on StackOverflow for that kind of assistance.

ah ok, thanks for looking in to it. I'll give it a shot on StackOverflow

I get the same Uncaught TypeError: "Cannot read property 'setprogress' of undefined" just after I embedded google's reCAPTCHA. Just inserted this script at the head:
<script src='https://www.google.com/recaptcha/api.js'></script>


IL tournaments

Concept by @TadCordle

tournament [bo1/bo3/bo5/bo7] [seeded/unseeded]
Users join with join and ready with ready
When at least 4 people have joined and everyone is ready, generate a bracket image
Start a race lobby with the first pairing
Someone chooses a level, both ready again
Entrants race. After the bo# requirements are satisfied, winner advances to next round
Track tournament wins in stats

this repo might be helpful/interesting