main

@milas does this mean you have closed the repository, and it is deleted now? Honestly, I don't know what I am doing yet. I HAVE A LOT TO LEARN!! Was that even my repository to begin with?

@milas does this mean you have closed the file and it is deleted now? Honestly, I don't know what I am doing yet. I HAVE A LOT TO LEARN!! I don't even know if that was my repository or not either.

@CasLee1990 No files deleted!
This Git repo has sample projects and is owned/maintained by Docker.
I think you might have unintentionally approved this pull request (PR) which is why you got notified.
I closed this PR because the actual changes were nonsensical. The author's branch is still there, but I don't think you actually want to use it either.
I hope that helps clarify!


add allauth and enable google social login for admins

@moh-moola
Please see update

@KaitCrawford I have made amendments to the tests


Unshim many expressions [databricks]

This is part of #5005.  Unshims the expression implementations that were common across all supported Spark versions.  GpuTimeSub was removed since it is no longer referenced.

build

build

build

build

Build failed due to missing imports in branch-22.06 code, will be fixed by #5040

build


HBASE-27111 Make Netty channel bytebuf allocator configurable.

Support site configuration of the bytebuf allocator that Netty will use for NettyRpcServer channels. We do not allow the site operator to fine tune this but could. It would be particularly useful to allow preference of heap buffers where direct memory may be limited or utilized for other purposes.
New property name is hbase.netty.rpcserver.allocator. Default is no value, which is equivalent to "pooled", which is our current default. Valid values are:

pooled: use PooledByteBufAllocator
unpooled: use UnpooledByteBufAllocator
heap: use HeapByteBufAllocator, which is a PooledByteBufAllocator that preferentially allocates buffers on heap wherever possible

Update JIRA ID

Unit test TestNettyRpcServer is parameterized to run the test using all of the new available configuration options.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

In general I do not think we need to extends PooledByteBufAllocator, just make a global instance with 'new PooledByteBufAllocator(false)' is enough. And I do not think we should mark HeapByteBufAllocator as IA.LP(CONFIG), we will use 'heap' to reference it so users do not need to use the name in config file directly, we could just mark it IA.Private.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m  7s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 19s
master passed

+1 :green_heart:
compile
2m 46s
master passed

+1 :green_heart:
checkstyle
0m 45s
master passed

+1 :green_heart:
spotless
0m 45s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 44s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
2m 44s
the patch passed

+1 :green_heart:
javac
2m 44s
the patch passed

+1 :green_heart:
checkstyle
0m 44s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 45s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 42s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 19s
The patch does not generate ASF License warnings.

35m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4525

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 8a84e1eb6f02 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9bae50f83c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 21s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 21s
master passed

+1 :green_heart:
compile
1m 17s
master passed

+1 :green_heart:
shadedjars
5m 15s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 49s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 20s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 15s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 52s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 51s
hbase-common in the patch passed.

-1 :x:
unit
12m 59s
hbase-server in the patch failed.

39m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4525

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 71398c531532 5.4.0-1043-aws #45~18.04.1-Ubuntu SMP Fri Apr 9 23:32:25 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9bae50f83c

Default Java
AdoptOpenJDK-1.8.0_282-b08

unit
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/3/testReport/

Max. process+thread count
572 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Unit test failures are related. Back with a fix.

Rebase, test fix.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 49s
master passed

+1 :green_heart:
compile
3m  2s
master passed

+1 :green_heart:
checkstyle
0m 45s
master passed

+1 :green_heart:
spotless
0m 46s
branch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 58s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m  9s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 31s
the patch passed

+1 :green_heart:
compile
2m 57s
the patch passed

+1 :green_heart:
javac
2m 57s
the patch passed

+1 :green_heart:
checkstyle
0m 48s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 38s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotless
0m 39s
patch has no errors when running spotless:check.

+1 :green_heart:
spotbugs
1m 47s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

37m 35s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4525

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile

uname
Linux 99b44f25a3f6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9bae50f83c

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/4/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 23s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 35s
master passed

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
shadedjars
3m 39s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s
the patch passed

+1 :green_heart:
compile
1m  4s
the patch passed

+1 :green_heart:
javac
1m  4s
the patch passed

+1 :green_heart:
shadedjars
3m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 43s
hbase-common in the patch passed.

+1 :green_heart:
unit
203m 10s
hbase-server in the patch passed.

223m 36s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4525

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 44142923d366 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 9bae50f83c

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/4/testReport/

Max. process+thread count
2570 (vs. ulimit of 30000)

modules
C: hbase-common hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4525/4/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


[fastlane_core] build watcher fails when build_beta_detail is nil - fix

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context

Resolves #19330
Description

It seems that build_beta_detail in build that we get from server can be nil, even though it's in build's ESSENTIAL_INCLUDES.
Treat build as not processed if wait_for_build_beta_detail_processing=true and build.build_beta_detail.nil?
Testing Steps

I don't have a mac app that I could use for tests
Update Gemfile and run bundle install
gem "fastlane", :git => "https://github.com/lucgrabowski/fastlane.git", :branch => "lucgrabowski-build-watcher-fails-when-beta-build-detail-is-nil-fix"

@lgralino, would you be able to test the fix (please take a look at testing steps in description, if you can test it)?

@lucgrabowski tested the branch - now everything works correctly!
upload_to_testflight(changelog: changelog, app_platform: "osx") successfully loaded my app to AppStoreConnect

@googlebot I consent.


Floating numbers

Firstly, let me congratulate you on this fine tool :+1:
Secondly, this is not an issue but a question: Is it possible to add Real Numbers to the range (floats)?
Thanks in advance!

I'd love to support floating-point numbers. I'm not sure when I'll get around to implementing it, but if you or someone else would like to do a pr in the meantime I'd be open to it. thanks for the suggestions!

Hey, thanks for the quick reply! If I implement this in my project I will def. contribute with a pull request.


[Revise text def]

Mondo term (ID and Label)
MONDO:0044327 - polycystic liver disease 4 with or without kidney cysts
Suggested revision of textual definition. Please include a source, like a PubMed ID (in the format PMID:#######)
Per request of the ClinGen Cystic & CIliopathy GCEP, please connect MONDO:0044327 with the LRP5 gene eg:
"polycystic liver disease-4 with or without kidney cysts (PCLD4) is caused by heterozygous mutation in the LRP5 gene  (OMIM# 617875)"

Thanks @tsneddon, we'll take care of this.


Update spatie/once dependency

Update because error in a fresh laravel nova installation
optimistdigital/nova-locale-manager[2.0.0, ..., 2.0.3] require spatie/once ^2.2 -> found spatie/once[2.2.0, 2.2.1] but the package is fixed to 3.0.1 (lock file version) by a partial update and that version does not match.

We also have to allow version 2.0. I added support for spatie/once 3.0 in version 2.0.4. Thanks!


Lookup compression

An issue with the use of INLINE for generalCategory was raised in base. The fix is easy and should probably be adapted to unicode-data* packages.
Then I wondered if we could go further and reduce the size of the Addr# literal. It turns out we can reduce its size by 80% with minor perf cost.
This is due to the fact that planes 4 to 13 are currently unused and uselessly bloat the literal; also planes 15 & 16 are reserved to PUA. So the trick is:

To divide the literal in 2 (Planes 0-3, Plane 14)
Check the range of the character to select either one of the previous literal or default values (Co or Cn).

We may apply the same trick to all such literals across the codebase.

I got great results with this MR, but it is too big. I am going to split it into multiple MR.

Benchmark for unicode-data:

All
  Unicode.Char.Case
    isLowerCase
      unicode-data:   OK (0.63s)
        4.51 ms ± 115 μs,   0 B  allocated,   0 B  copied,  64 MB peak memory, 21% more than baseline
    isUpperCase
      unicode-data:   OK (1.01s)
        3.63 ms ±  44 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    toCaseFoldString
      unicode-data:   OK (0.80s)
        11.1 ms ± 176 μs,  24 MB allocated, 5.5 KB copied,  90 MB peak memory,       same as baseline
    toLowerString
      unicode-data:   OK (0.41s)
        10.3 ms ± 387 μs,  24 MB allocated, 5.5 KB copied,  90 MB peak memory, 10% less than baseline
    toTitleString
      unicode-data:   OK (0.43s)
        11.1 ms ± 416 μs,  24 MB allocated, 5.4 KB copied,  90 MB peak memory,       same as baseline
    toUpperString
      unicode-data:   OK (0.91s)
        13.2 ms ± 269 μs,  24 MB allocated, 5.3 KB copied,  90 MB peak memory,  6% less than baseline
  Unicode.Char.Case.Compat
    isLower
      unicode-data:   OK (1.27s)
        4.48 ms ± 118 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory, 17% less than baseline
    isUpper
      unicode-data:   OK (0.66s)
        4.67 ms ±  95 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    toLower
      unicode-data:   OK (0.62s)
        8.25 ms ± 197 μs,  16 MB allocated, 3.4 KB copied,  90 MB peak memory,  5% less than baseline
    toTitle
      unicode-data:   OK (0.67s)
        8.97 ms ± 186 μs,  16 MB allocated, 3.4 KB copied,  90 MB peak memory,       same as baseline
    toUpper
      unicode-data:   OK (0.66s)
        8.80 ms ± 251 μs,  16 MB allocated, 3.3 KB copied,  90 MB peak memory,       same as baseline
  Unicode.Char.General
    generalCategory
      unicode-data:   OK (0.97s)
        6.69 ms ±  90 μs,  16 MB allocated, 3.3 KB copied,  90 MB peak memory,       same as baseline
    isAlphabetic
      unicode-data:   OK (0.74s)
        4.94 ms ± 123 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  4% more than baseline
    isAlphaNum
      unicode-data:   OK (1.34s)
        4.71 ms ±  73 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory, 16% less than baseline
    isControl
      unicode-data:   OK (0.76s)
        5.13 ms ±  98 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    isMark
      unicode-data:   OK (0.75s)
        4.99 ms ± 108 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  6% less than baseline
    isPrint
      unicode-data:   OK (0.71s)
        4.65 ms ± 145 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  7% less than baseline
    isPunctuation
      unicode-data:   OK (0.75s)
        4.96 ms ±  85 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  6% less than baseline
    isSeparator
      unicode-data:   OK (0.70s)
        4.57 ms ±  88 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  4% less than baseline
    isSymbol
      unicode-data:   OK (0.70s)
        4.97 ms ± 142 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  6% less than baseline
    isWhiteSpace
      unicode-data:   OK (0.39s)
        4.60 ms ± 172 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    isHangul
      unicode-data:   OK (0.70s)
        4.59 ms ± 128 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  4% more than baseline
    isHangulLV
      unicode-data:   OK (0.71s)
        4.60 ms ± 120 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    isJamo
      unicode-data:   OK (1.28s)
        4.61 ms ±  90 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  4% more than baseline
    jamoLIndex
      unicode-data:   OK (1.06s)
        3.62 ms ±  81 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    jamoVIndex
      unicode-data:   OK (1.06s)
        3.61 ms ±  96 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    jamoTIndex
      unicode-data:   OK (1.06s)
        3.61 ms ±  61 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
  Unicode.Char.General.Blocks
    block
      unicode-data:   OK (0.88s)
        287  ms ± 7.3 ms, 1.6 GB allocated, 311 KB copied,  90 MB peak memory,       same as baseline
    blockDefinition
      unicode-data:   OK (0.30s)
        8.71 μs ± 334 ns,  18 KB allocated,   3 B  copied,  90 MB peak memory,       same as baseline
  Unicode.Char.General.Compat
    isAlpha
      unicode-data:   OK (0.68s)
        4.65 ms ±  95 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  4% less than baseline
    isLetter
      unicode-data:   OK (0.71s)
        4.69 ms ± 138 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    isSpace
      unicode-data:   OK (0.65s)
        4.64 ms ± 110 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory, 23% less than baseline
  Unicode.Char.Identifiers
    isIDContinue
      unicode-data:   OK (0.75s)
        4.96 ms ± 101 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  6% less than baseline
    isIDStart
      unicode-data:   OK (0.71s)
        4.70 ms ± 102 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    isXIDContinue
      unicode-data:   OK (0.71s)
        4.70 ms ± 141 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    isXIDStart
      unicode-data:   OK (0.39s)
        5.49 ms ± 209 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory, 10% more than baseline
    isPatternSyntax
      unicode-data:   OK (0.71s)
        4.70 ms ± 134 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory, 14% less than baseline
    isPatternWhitespace
      unicode-data:   OK (0.70s)
        4.59 ms ±  86 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
  Unicode.Char.Normalization
    isCombining
      unicode-data:   OK (0.69s)
        4.94 ms ±  86 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  3% more than baseline
    combiningClass
      unicode-data:   OK (0.82s)
        6.08 ms ± 180 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  4% less than baseline
    isCombiningStarter
      unicode-data:   OK (0.33s)
        4.50 ms ± 169 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  5% less than baseline
    isDecomposable
      Canonical
        unicode-data: OK (0.74s)
          4.89 ms ± 118 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory, 10% less than baseline
      Kompat
        unicode-data: OK (2.69s)
          4.96 ms ± 182 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
    decompose
      Canonical
        unicode-data: OK (0.47s)
          26.3 ms ± 986 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,       same as baseline
      Kompat
        unicode-data: OK (0.51s)
          30.9 ms ± 701 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  3% less than baseline
    decomposeHangul
      unicode-data:   OK (0.53s)
        3.62 ms ±  93 μs,   0 B  allocated,   0 B  copied,  90 MB peak memory,  6% less than baseline
  Unicode.Char.Numeric
    isNumeric
      unicode-data:   OK (0.38s)
        10.6 ms ± 379 μs,   0 B  allocated,   0 B  copied,  91 MB peak memory,       same as baseline
    numericValue
      unicode-data:   OK (1.12s)
        8.15 ms ± 139 μs,   0 B  allocated,   0 B  copied,  91 MB peak memory,  3% less than baseline
    integerValue
      unicode-data:   OK (0.78s)
        10.6 ms ± 390 μs, 613 KB allocated, 168 B  copied,  91 MB peak memory,       same as baseline
  Unicode.Char.Numeric.Compat
    isNumber
      unicode-data:   OK (0.76s)
        4.97 ms ± 101 μs,   0 B  allocated,   0 B  copied,  91 MB peak memory,  6% less than baseline

Note that I even reach improvement >30% on an older machine. My guess is that bechause the Addr# literal are shrunken they may fit the CPU cache.

I have not looked at the code yet. It may be worth doing if there are enough improvements that are, say, 7% or more and the added code complexity is manageable.

I think it should be done anyway: inlining huge literals is not a good idea (see issue in GHC).
Then I tried to fix regressions in two ways:

reduce literal size
do not use generalCategory directly.

Closing in favor of #105 and #106.


[Suggestion] - Library chart which contains common logic between Atlassian charts

Suggestion
There is a duplication of logic between charts. An examples of this  is the fullname definition which is duplicated in each of the charts. For example bitbucket and jira examples below:
{{/*
Create a default fully qualified app name.
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
If release name contains chart name it will be used as a full name.
*/}}
{{- define "bitbucket.fullname" -}}
{{- if .Values.fullnameOverride }}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- $name := default .Chart.Name .Values.nameOverride }}
{{- if contains $name .Release.Name }}
{{- .Release.Name | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }}
{{- end }}
{{- end }}
{{- end }}

{{/*
Create a default fully qualified app name.
We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec).
If release name contains chart name it will be used as a full name.
*/}}
{{- define "jira.fullname" -}}
{{- if .Values.fullnameOverride }}
{{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- $name := default .Chart.Name .Values.nameOverride }}
{{- if contains $name .Release.Name }}
{{- .Release.Name | trunc 63 | trimSuffix "-" }}
{{- else }}
{{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }}
{{- end }}
{{- end }}
{{- end }}

These definitions are essentially the same logic which could be defined in one chart, a Helm Library Chart and used between the Atlassian charts.
Some of the benefits of introducing a common or library chart are:

Code re-use and keeping charts DRY
Minimizing errors
Maintenance improvements

Note: The common logic can be extracted from the charts and added to the common chart on a bit by bit basis and avoid "big bang" approach.
Product
Jira, Confluence, Bitbucket, Other
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Pushed PR #303 which creates the library (common) chart and adds some of the common logic definitions. This also provides a PoC of the feature.

Hi @hickeyma, this is an interesting change that we have considered as well. Thank you very much for the PR it is something we can test and see how to work with the current installations and going forward. We haven't introduced an "umbrella" chart as we didn't want to have explicit product dependency on other charts but with more duplication, this should make it easier for maintaining the helm charts and also maintaining installations.
Right now, there is another major work currently in progress that might utilise this but for now, we would like to avoid any impact on the development so I will put the issue on hold and revisit it within a ~month.

@nanux That's great that you have considered it as it is cuts down on code repetition as its core benefit. For clarification, this is not an "umbrella" chart, it is a "common" or "library" chart which can be used by other charts. An "umbrella" chart composes the different parts of a complex application as one top level chart. See Complex Charts with Many Dependencies for more details.

Right now, there is another major work currently in progress that might utilise this but for now, we would like to avoid any impact on the development so I will put the issue on hold and revisit it within a ~month.

Not a bother. Once you have completed this work, let me know and we can see about adding the functionality.

Hey @nanux, any update?

Hi @hickeyma, sorry it took some time, there were other moving pieces that I was working on. I think we are now at the point where we can start introducing the library chart. Do you think you can pick up the PR and update it to make it work with the latest changes?
Thank you

@nanux Sure, will rebase it and push the update.

@nanux I have updated PR #303, its waiting on approval to run the workflow.


Float data type and IntelliSense on qs code

In the medical imaging domain; my input data is an array of complex numbers. The real and imaginary part of the complex number are float data types.
Unfortunately, using Double (what Q# offers) alters my output and that is not ok. A great suggestion would be to have the Float datatype available.
Another functionality that would be really useful is IntelliSense.
Right now, I first write code, build the project and fix issues.
It would be really great if IntelliSense could analyze Q# code in real time. If this functionality already exists, I’d be really curious how to activate it.
Additional context
Issue migrated from User Voice.

I don't know when this was originally filed and by whom. We got IntelliSense with 0.3, so that part for the request is fairly obsolete.

@bromeg I will actually close this issue - the IntelliSense part is done, and at this point I am not ready to introduce a float data type. That seems to be a precision issue in the pre- and post processing that should be addressed there.


Handle cases where a private bug is closed as a duplicate of a public bug

NOTE
CC @dveditz

Private bugs should not be closed as a duplicate of public bugs unless the public bug is already a known security bug (has a sec-foo keyword), then it's fine to make the hidden bug a duplicate.
If the public bug does not contain vulnerability details, the security bug should "depends on" the public bug instead of being closed as a duplicate.

Suggested solution: we could add a BugBot rule to reopen the private bug and mark it as “depends on” the public bug, unless the public bug already has a “sec-*” keyword.

It would be great to reference our security-bug dupe-handling guidelines.  I'll try to get that into some appropriate place in Firefox source docs so you can switch to a publicly accessible link, but the above will do for now.


(surge form review) Edits needed to "Type(s) of Interaction among Participants" values in case forms

Changes needed:
"Acting/drama" to "Acting/Drama"
"Ask And Answer Questions" to "Ask & Answer Questions"
"Express Opinions/preferences Only" to "Express Opinions/Preferences Only"
"Listen/watch As Spectator" to "Listen/Watch as Spectator"
"Story-telling" to "Storytelling"
"Teaching_instructing" to "Teaching/Instructing"

Also, label should be "Type(s) of Interaction Among Participants"


Fall back to Session.sublime_session for Sublime Text 3

rr sometimes fails for Sublime Text, because the Auto Save Session.sublime_session file is deleted when you quit Sublime Text, and it's not recreated until you open Sublime Text and edit and save a file.
It would be nice if the workflow could fall back to Session.sublime_session if Auto Save Session.sublime_session doesn't exist.

You can try the new release https://github.com/mpco/Alfred3-workflow-recent-documents/releases/tag/2.6


Raise awareness for custom ROMs to support older android devices

There might be unofficial ROMs for very old devices (or ROMs that was official but not supported any-more), more info will be in the device category in xda-developers forum.
for example:
https://forum.xda-developers.com/galaxy-s2/ for samsung s2 device, which if not running Custom ROM is probably still on android 4.x version (the latest supported by vendor), which is not supported by magen app #280, but the OS can be upgraded using LineageOS to unofficial Android 10:
https://forum.xda-developers.com/galaxy-s2/development-derivatives/rom-lineageos-17-0-t4022733
The device itself has WIFI/GPS/Bluetooth3.0 and probably the app will work on it.
List of some Custom ROMs OS: (can be used instead of old stock os for newer android version usage)
LineageOS https://lineageos.org/
Replicant https://www.replicant.us/
/e/ EELO OS https://e.foundation/
CalyxOS https://calyxos.org/
as I heard some complaints (in news) that the app won't work on older devices, it's possible to raise awareness such as:
in google-play / magen-website, point minimum requirements for the app, but also that if it's android device it might be possible to upgrade it using custom ROMs, in which case a tech-shop, or tech-person might help, etc...
it's also might be helpful in case the app is supported, but newer android version will be able to make it work better (usage of newer api, more performance, fixes for android bugs, etc...)

Thanks for the offer. We focus our efforts with the popular devices in Israel. Supporting old ROMs isn't the case.
Samsung S2 almost a decade old...

Samsung S2 almost a decade old...

Well, Samsung s5 can also be stuck on < android 5, it was just an example.
I understand this is not priority, just that it's possible solution for people with old devices that use old android versions who currently CAN'T install the app, but they might be able to install it if android version is upgraded via custom ROM, thus it's worthwhile to mention it, as the usefulness of the app also depend on how many people will install it...

See this video (from second "51"): https://www.youtube.com/watch?v=TtUpzpkSOSw
"היישומון אינו נתמך במכשירים ישנים"
I guess they mean a old android devices? not iphone devices who probably got update to at least ios 10, unless it's <= iphone 4.


Cannot find module 'aws-sdk'

Bug Report Template -----------------------------------------------
Squeezer Framework Version information ( squeezer-cli version ) :

Squeezer CLI version: v1.1.21
Node version: v9.2.1
OS platform: linux | arch

Expected Behavior:
Compile
Actual Behavior:
Error: Cannot find module 'aws-sdk/clients/CloudFormation'

Have aws-sdk installed.
Log here: https://linx.li/mv4a66qv.txt

hello @KonradIT  . we fixed the issue on the latest Squeezer release . could you update the CLI version to the latest and reinstall packages in the project ? Thank you !

@nickchisiu now I get:
Error: Cannot find module './logs'

@KonradIT could you make a re-check ? thanks !

@KonradIT did the issue fixed so that we can close the issue ? Thanks !

Yes, solved!


Team update - Jun 01, 2022

This is a @Quansight-Labs/czi-a11y-grant team sync 🎉🎉🎉! This is a way for the Team Members to provide status reports on what they've been up to this week and request help and attention for things they are working on. This issue will be closed at the end of the day.
Copy and paste the template below, and answer questions as you wish!

Response Template
**Thanks I'd like to give 🙌**
- So-and-so helped me out a lot with foo...

**Updates from last week :heavy_check_mark:**
- I worked towards deliverable: <link-to-deliverable>

**Challenges I faced and things I'd like assistance with 🙏**
- I had a hard time figuring out ...

**My availability for next week**
- I'll be off on foo day...

**Important items for discussion 💬**
- I have a question about goal <link-to-goal>
- Can @foo give a comment on issue #NN ?
- I opened #NN for discussion, please chime in
- I need to discuss foo

:mag: Needs Triage
The Needs Triage issues require an initial assessment and labeling.

Fix tab traps in JupyterLab
Curate JupyterLab themes
Test out a new contribution event!
Imagine test reporting options

:dart: Project boards
Please make sure the boards reflect the current status of the project.
Jupyter a11y grant project

Thanks I'd like to give 🙌

Big thanks to @tonyfast for helping me run the JupyterLab accessibility meeting this week. I wouldn't have survived without you.

Updates from last week :heavy_check_mark:
I have almost nothing to report.

quansight-labs/accessibility #3 accessibility statement has been updated.
quansight-labs/accessibility #6 testing script documentation has been opened and updated.
#93 quansight-labs/accessibility #7 accessibility workshop to community docs has been opened.
Started on rendered notebook user testing script. Gathering resources and aligning on what tasks we want to cover with that team.

Challenges I faced and things I'd like assistance with 🙏

I can't think of anything right now.

My availability for next week

I'll be out of office on June 10.

Important items for discussion 💬

I think we need to sort out what we are covering in our intermediate cycle and in the next one.

I am OOO today and tomorrow but for the intermediate cycle I have created this Kale 🌱  - lessons learned milestone
TODO:

[ ] please self-assign items as needed / relevant
[ ] if there are any issues from our repo or you create new issues to propose for the upcoming sprint please add the sprint-candidate tag
[ ] @tonyfast  please finish the changes in the doit PR so we can merge and add issues for improvements/extension etc.
[ ] I believe #92  is closable, can we confirm, please?
[ ] @gabalafou  confirm status of https://github.com/jupyter/accessibility/pull/92 and outstanding items

We can have the sprint planning meeting next Monday when @gabalafou  is back


Pulling all major changes in from v2.0 plus some

These changes include:

removal of the -e option, which no one ever used, in lieu of auto-detection of the oldest version of the OS and fixup when the -f flag is used
a test that scrapes the most recent stable version number from the flatcar site, then checks the current running version of the OS against it
added a reboot message option in big bold color so it doesn't get missed at the end of stdout
better clarity around ACTION items (now they're yellow)
removed some unnecessary intros where tests were descriptive enough.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: roddy-toomim-sp:x: alex-derzhi-spYou have signed the CLA already but the status is still pending? Let us recheck it.


Assume user is importing new data if id fields not included

Fixes #570 and #991.
Problem
Currently, when importing data, errors are raised if any of the fields used to identify existing objects (specified in Resource.Meta.import_id_fields) are not present in the uploaded dataset. Because of this, even if uploading an entirely new dataset, users must always remember to include blank columns for each of the id fields.
Solution
If the fields specified by import_id_fields are not included in the uploaded data, I believe it is safe to assume that all data is new, and attempts to match rows to existing objects should be avoided all together.
Acceptance Criteria
Have you written tests? Yes
Have you included screenshots of your changes if applicable? N/A
Did you document your changes? Please advise if updating the docstring is sufficient

Coverage decreased (-3.3%) to 92.338% when pulling eed10a9af33bae98b3433c6c648b8d266994afd3 on ababic:fix-570 into 141932b751f4900dcc08c1df1b11b4342907db09 on django-import-export:master.

Thanks for taking the time to review @andrewgy8

Nice job yall


crouton won't delete

Please paste the output of the following command here: sudo edit-chroot -all
sudo: edit-chroot: command not found

Please describe your issue:
crouton won't delete i tried most of the delete commands and it just keeps saying: sudo: delete-chroot: command not found
If known, describe the steps to reproduce the issue:
what i was doing before this happed was i was trying to install vmware to boot windows and download on a copy on windows for my pc that i just built and i downloaded vmware but it needed some dependencies  but i need to plug in the computer so i went to go get the charger and the computer turned off while i was gone so when i turned on the computer while i was still booted into linux i put in the password and i was going to do the last command to install the dependencies and i switched back over to chrome because i was watching a youtube video on how to install vmware and when i tried to switch back over linux powered down so i just turned on linux again but reset everything too but when i opened terminal to put in the command i switched back over again and i tried to switch back over and it turned off again so i started it again then i opened terminal put in some on the command switched back over and it turned over again ect i did this for a minute until i wrote it down on a piece of paper and turned on linux again and put in the command and then when i put in the command the command didn't work for some reason and then i just switched over back and forth and it kept turning off and now i just want to reinstall it and now when i try to reinstall it i tried the delete command and it deleted it but it didn't delete all of it and now i can't start linux and i can't reinstall linux because i get this:
/usr/local/chroots/xenial already has stuff in it!
Either delete it, specify a different name (-n), or specify -u to update it.    even though i put in the delete command please help

The delete-chroot command should be under /usr/local/bin/ and in your PATH but if not try:

sudo /usr/local/bin/delete-chroot xenial

If that doesn't work then try the below method:

sudo /usr/local/bin/edit-chroot -d xenial

Also, if 'xorg' is giving you problems when installing apps you can add both xorg & xiwi targets to your chroot and use xiwi to switch out of your chroot easier. You can also add a browser in your chroot and use it for searches & reference.
Hope this helps,
-DennisLfromGA

The delete-chroot command should be under /usr/local/bin/ and in your PATH but if not try:

sudo /usr/local/bin/delete-chroot xenial

If that doesn't work then try the below method:

sudo /usr/local/bin/edit-chroot -d xenial

Also, if 'xorg' is giving you problems when installing apps you can add both xorg & xiwi targets to your chroot and use xiwi to switch out of your chroot easier. You can also add a browser in your chroot and use it for searches & reference.
Hope this helps,
-DennisLfromGA

hello both of those commands did not work and i was not using xfce linux i was using unity linux and this is what i got from both of the commands:
sudo: /usr/local/bin/delete-chroot: command not found
sudo: /usr/local/bin/edit-chroot: command not found

I may be misunderstanding you (or fundamentally wrong since I'm new to linux), but it sounds like you're entering the edit-chroot command on the linux side?  For me I can't use commands like edit-chroot from within my chroot.  I get the same command not found response, but if you open a terminal and enter a shell in the chrome os side the chroot managment commands like edit-chroot work properly.

I may be misunderstanding you (or fundamentally wrong since I'm new to linux), but it sounds like you're entering the edit-chroot command on the linux side? For me I can't use commands like edit-chroot from within my chroot. I get the same command not found response, but if you open a terminal and enter a shell in the chrome os side the chroot managment commands like edit-chroot work properly.

i have been entering the commands through crosh but before i enter the commands i type shell in crosh then enter the commmands

i may just have to wipe my chromebook because this have happened to me multiple times and what i did to fix it was just to wipe it i just want to know if there is a way to fix it without wiping everything

Ah, in that case I don't know what the problem could be, sorry.

@spityou

i just want to know if there is a way to fix it without wiping everything

If you are still getting 'command not found' errors even after entering the full path to the scripts then it appears that the scripts were somehow removed. You can reinstall the needed scripts for the chroot(s) you have installed (in the default location) with the command listed below:

sudo crouton -b

Once they're reinstalled you should be able to delete your chroot with:

sudo delete-chroot xenial

If you still get errors then, assuming you installed your chroot(s) in the PREFIX location (/usr/local/chroots) then this should remove them manually:

sudo rm -rf /usr/local/chroots/*

Note that the above can be dangerous if you type in the wrong location so please be sure to enter it correctly.
If that should fail for any reason then you can always powerwash your device as a last resort.
Hope this helps,
-DennisLfromGA


All writes should be guarded with try/catch

Details:  T22408574
realtime_gateway_task_crashes:trace:rsocket::FramedWriter::onNext:SIGSEGV
Because of asynchrony, there can be cases that the StreamStateMachine wants to write to the output, but the output is already closed, or more.
I have added try/catch to each write operation to catch such errors and close the corresponding stream.
I will add a unit test to verify the update/fix.

The linked task refers to a crash because of a heap-use-after-free.  There are no exceptions involved there as far as I can see.


update(docs): use the correct helm options based on v2.0.0 of the faco chart

Signed-off-by: Aldo Lacuku<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:
Update some outdated helm commands.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alacuku
Once this PR has been reviewed and has the lgtm label, please assign jasondellaluce for approval by writing /assign @jasondellaluce in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vjjmiras @jasondellaluce

@alacuku LGTM, should this wait for Falco 0.33 to be released or can we merge this before?

We can already merge it.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alacuku, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: ab1ccfe37a48b3536298102ce2e8d32320acdfff


[PTX-21401] Add EKS Scheduler Driver

What this PR does / why we need it:
This PR implements EKS scheduler driver to perform cluster upgrade.
Which issue(s) this PR fixes (optional)
Closes #PTX-21401
Special notes for your reviewer:
I will update once the test run is complete.

Thank you for reviewing. I have raised another PR https://github.com/portworx/torpedo/pull/2158 for these changes.


Bug 2006546 - Image service fails every API call if no RHCOS_IMAGES are provided

Description
This is a manual cherypick for https://bugzilla.redhat.com/show_bug.cgi?id=2006546

How was this code tested?

Assignees

/cc @carbonin
/cc @djzager
Links

Checklist

[ ] Title and description added to both, commit and PR
[ ] Relevant issues have been associated
[ ] Reviewers have been listed
[ ] This change does not require a documentation update (docstring, docs, README, etc)
[ ] Does this change include unit tests (note that code changes require unit tests)

/bugzilla refresh


Migrate to ESLint 9

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Bump mytoyota version to 2.1.4

Fixes #286

@DurgNomis-drol Can you review this PR to close #286?

Just letting you know that there is already a PR that takes care of the manifest file https://github.com/DurgNomis-drol/ha_toyota/pull/257/files
Thank you for updating the mytoyota python module and bringing this integration back to life :)

Just letting you know that there is already a PR that takes care of the manifest file https://github.com/DurgNomis-drol/ha_toyota/pull/257/files Thank you for updating the mytoyota python module and bringing this integration back to life :)

Oh, that's right. There's already an MR from me :D I'm therefore closing this one as a duplicate.

Dupliacte


404 - Not found

Describe your problem
Every time i install Bludit on a Virtual Machine with Debian 10 and PHP 7.3, i can run the Installation script and set a admin password. But after this, when i want to enter admin area or use any other hyperlink that points on the server i get a 404 not found.
Bludit version
Bludit 3.9.2
PHP version
7.3

Hello,
is there a .htaccess file in the directory? What does the link to the admin area look like?

Your .htaccess are not processed from the Apache HTTPD.
You need to allow a override configuration like:
/etc/apache2/sites-enabled/000-default.conf
...
<Directory /var/www/html/>
AllowOverride All

...


Object Disposed Exception on OnReceived callback

fail: Microsoft.AspNetCore.Sockets.Client.HttpConnection[19]
      12/11/2017 10:30:05: Connection Id (null): An exception was thrown from the 'OnReceived' callback
System.ObjectDisposedException: Cannot access a disposed object.
   at System.Threading.TimerQueueTimer.Change(UInt32 dueTime, UInt32 period)
   at System.Threading.Timer.Change(TimeSpan dueTime, TimeSpan period)
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.ResetTimeoutTimer() in C:\Github\SignalR\src\Microsoft.AspNetCore.SignalR.Client.Core\HubConnection.cs:line 104
   at Microsoft.AspNetCore.SignalR.Client.HubConnection.<OnDataReceivedAsync>d__40.MoveNext() in C:\Github\SignalR\src\Microsoft.AspNetCore.SignalR.Client.Core\HubConnection.cs:line 332
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Sockets.Client.HttpConnection.<>c__DisplayClass45_0.<<ReceiveAsync>b__0>d.MoveNext() in C:\Github\SignalR\src\Microsoft.AspNetCore.Sockets.Client.Http\HttpConnection.cs:line 377

@anurse

Context for anyone else: It's an easy fix but it doesn't break behavior, it just spams the logs and I want to get #1147 in before messing with that code again, since there are conflicts there and I spent a bunch of time resolving them :). Also want to write a test.


Unused query bindings should be an error

It's possible to pass more query bindings than there are bindvars in a query. This should be an error.

My PR from months ago claims to fix this but I think that's a lie. I think it's still possible to pass in more bind vars than the query contains, and this should be an error (silently swallows application bugs otherwise).


[GithubLastCommitBranchBridge] Add GitHub last commit on branch bridge

Add new bridge to follow on a branch when a commit is pushed to a repo

There is an already existing feed: https://github.com/RSS-Bridge/rss-bridge/commits/master.atom
Do you need something more than what github already provides ?

There is an already existing feed: https://github.com/RSS-Bridge/rss-bridge/commits/master.atom
Do you need something more than what github already provides ?

Hi,
I wasn't aware about it. I will check it

@floviolleau Does the existing feed work for you?

I assume the existing feed works, so this PR can be closed.


Avoid_use - missing config option for test-seam

Here, the wrong thing is checked:
https://github.com/abaplint/abaplint/blob/787db3f82600707d11eceadad6e8e2b54ce283d3/packages/core/src/rules/avoid_use.ts#L80

too much copy pasta 🍝

@FreHu try again, 2.89.15

closing


Friction parameters are missing

This is an enhancement request to add frictional parameters in the equations. The user can control them at startup time in order to provide more realism to the simulation.
I understand this was not your initial intent but this addition would be  useful to folks like me who are tying to understand chaotic systems.

Added friction (a single parameter is enough, I just included dissipative force, proportional to speed). You can even change it during the simulation.


os: Readlink docs should mention behavior for relative paths

The documentation for os.Readlink currently says:

Readlink returns the destination of the named symbolic link. If there is an error, it will be of type *PathError.

While that is true, it also omits an important piece of information about “the destination”: if the symlink target is relative, Readlink will return that raw relative string directly. It will not do any additional work to make the path either absolute or relative to the current working directory. A reader who is not thinking very deeply about relative paths may well treat the result as a path, not a special symlink path blob.¹
That is consistent with the Unix readlink system call, but then again, the Go os package is different from the Unix syscall package for a reason. We should probably call this out more explicitly in the documentation, and perhaps provide an example of how to use Readlink to correctly resolve a symlink to a filesystem path.

¹ Per https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_13,
“[T]he system shall prefix the remaining pathname, if any, with the contents of the symbolic link …. If the resulting pathname does not begin with a , the predecessor of the first filename of the pathname is taken to be the directory containing the symbolic link.”

(Found via #57754.)

Similarly, the documentation for Lstat should probably mention that its behavior (like the Unix lstat system call) depends on whether name ends in a trailing slash. (If it does, the symlink is followed.)
https://go.dev/play/p/ZxOq1dwAUfh


disabled/enabled

Does this directive have some sort of disabled="{{form_disabled}}" attribute that I’m overlooking?

No not yet but you can apply it on directive it self

added disable="true"  confirm and close if this solve your issuue

closing issue no activity


FindReferenceAssembliesForReferences accounts for 7% of a design-time build

See: https://github.com/dotnet/sdk/issues/1496.

This target is consuming the 5th most design-time build time in our new telemetry, with a 95% percentile time of 26 milliseconds.

@AndyAyersMS This would be a good one to pick up for you new guy.

Not sure I follow -- are you saying somebody should look at this from the jit's standpoint...?
Either slow jitting or that the jitted code is slow?

Sorry, @AndyAyersMS meant to tag @AndyGerlicher. Nothing from a JIT'ed standpoint.


[FLINK-35776] Simplify job status handling

What is the purpose of the change
There is a fairly complicated listing / observe logic for jobs currently that is no longer necessary as we have a stable logic to always record the jobID in the status before submission.
Brief change log

Replace complex resource specific job listing/matching logic with JobId based querying
Clean up unnecessary codepaths
Tests

Verifying this change
The change is already covered by existing tests to a large extent.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: yes

Documentation

Does this pull request introduce a new feature? no

@gyfora

as we have a stable logic to always record the jobID in the status before submission.
could you point to the related changes to understand the context a bit better?


If the routerConfig is provided, all the other router delegates must not be provided

@eilhcir
When you open an issue, please try to use new issue template and provide requested details so that we'll have enough info to work with.
Closing for now, as no info is provided.


reading from memory and module resolving

While this part of the API is quite clear
var b = Browserify();
b.add(filename);
b.bundle(function(err, buf){
});

and I also figured out I can pass in a stream to the add.
But is there any way to hook up a resolver so that (dependent) file reads are not made/tried directly from the filesystem? A default implementation could look like this:
resolve = function(absPathFrom, requireArgument, cb) {
  var absPathTo = path.resolve(absPathFrom, requireArgument);
  var content = fs.readFileSync(absPathTo, 'utf-8');
  cb(null, content);
}

I'm not 100% sure what your use case is, but you can pass as an option to Browserify any of the options that module-deps and browser-pack accept. module-deps has two options that you may find interesting:

opts.packageCache - an object mapping filenames to their parent package.json contents for browser fields, main entries, and transforms

opts.fileCache - an object mapping filenames to raw source to avoid reading from disk.

Another alternative might be to utilize exposed internal pipeline for Browserify, documented in the README. You can pop module-deps off the "deps" key and replace it with something that implemented the functionality you want.

Thanks for the pointers, @terinjokes.
Use case: I have multiple files (only) in memory (not on disk) and want to bundle them up with browserify without writing them out to disk first.
The opts.fileCache sounds worth checking out. You lost me one this here though:

Another alternative might be to utilize exposed internal pipeline for Browserify, documented in the README. You can pop module-deps off the "deps" key and replace it with something that implemented the functionality you want.

@tcurdt They are two separate ideas I had, so if you're happy with fileCache, the other way might be much more complicated.

I found the fileCache option https://github.com/substack/module-deps/blob/master/index.js#L183 - unfortunately this means I have to actively populate the cache up front as it's not lookup based. That would probably work - but is a bit of a hack. At least I am not aware on how one could overwrite the [] operator in javascript to make it lookup based.
So maybe I need to understand option two then.

OK when I hook into the internal pipeline of browserify and replace the deps part I see the following
Deps.prototype._transform = function (row, enc, next) {
    console.log('ROW', row, 'ENC', enc);
    return next();
};

ROW { source: 'require("./components/test")',
  entry: true,
  file: '/some/path/_stream_0.js',
  id: '/some/path/_stream_0.js',
  order: 0 } ENC utf8
ROW { transform: [Function: globalTr], global: true, options: {} } ENC utf8

which doesn't help me much further yet - or would I need to parse the source myself?

Or where else should I see a lookup for ./components/test ?


semantic_search_quora_hnswlib get error "wrong dimensionality of the vectors"

python semantic_search_quora_hnswlib.py

error is :
Start creating HNSWLIB index
Traceback (most recent call last):
File "semantic_search_quora_hnswlib.py", line 83, in
index.add_items(corpus_embeddings, list(range(len(corpus_embeddings))))
RuntimeError: wrong dimensionality of the vectors

It seems like that is an external error in the  semantic_search_quora_hnswlib.py which is not a part of hnswlib


Spa Booking App - Final Capstone project

Dear reviewer,

This is a group of 4 and we are going to use this kanban board to achieve our milestone towards the completion of this project.
https://github.com/users/newhoteng/projects/10

Hi @Jeddaa,
Wow, you did it 🎉

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
To highlight

All cards have been assigned, have descriptions and pointings.  The pointings are equal according to the requirement. ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Vagrant Cloud chaos with BoxCutter

In Vagrant Cloud  there are two groups:
boxcutter and box-cutter
https://app.vagrantup.com/boxcutter/
https://app.vagrantup.com/box-xcutter/
This repo refers to boxcutter but the images are in box-cutter?
this has changed recently as boxcutter doesn't seems to work anymore.

@Vad1mo you've got a typo in the link https://app.vagrantup.com/box-xcutter/ => https://app.vagrantup.com/box-cutter/

yes sorry it was a typo. however the questions  stays.

@Vad1mo i know, use the box with my setup: https://github.com/vagrant-php/ubuntu, fixed the name. But it seems its not supported anymore, as you can see within #120


Support for older Browsers

The Plugin does a great job, but in older Browsers like Safari 13 or IE 11 are no images available.
It would be great, if a fallback to the jpg/png media would be included.

The fallback is included 🤔

I have seen something like this in the template, but the convert-command converts all jpg/png to WebP and the original images will be replaced.

The original images stay there. It just created an new file with the same name and changes the extension to webp. All places there webp is used has an picture tag to ensure the image is loaded only when webp is there.
Which page does break?

The problem was, that the images were original uploaded as WEBP. In this case the fallback can´t work. Thanks for the fast support and sorry.
The fallback works fine, if the image is original PNG/JPG.


Fix format script to miss files, fix lint errors, and introduce GH workflow to lint

The npm run format command was only acting on .mjs files two levels deep within the cli directory, thus excluding the .mjs files in other nesting levels in that directory. It was assumed that the ** wildcard would cover any nesting level but apparently it doesn't for that command.
This PR fixes the npm run format script to cover all the .mjs files, and it also fixes related JS lint errors that are currently present.
Last but not least it adds a GitHub workflow to avoid such lint errors from getting into main in the future.

@felixarntz https://github.com/GoogleChromeLabs/wpp-research/pull/44/commits/d2cb5a7a4e509d614b213da1aff59adb7ae7f465 fix empty line notice for GH.


Update sql.md

OPS Build status updates of commit cf2b3f4:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml
:warning:Warning
View (azure-node-latest)
Details

docs-ref-services/sql.md
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml

[Warning] Uid(microsoft-cognitiveservices-speech-sdk) has already been defined in docs-ref-autogen/microsoft-cognitiveservices-speech-sdk/index.yml.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@craigg-msft why am I the owner of this topic and what do I need to know about the warning message?

@PatAltimore can you please assist here?


Replace FxHash with AHash as the default hasher

Fixes #48
cc @tkaitchuck

Benchmark results are somewhat disappointing:
 name                      fx ns/iter  a ns/iter  diff ns/iter   diff %  speedup
 insert_erase_fx_highbits  288,744     16,595         -272,149  -94.25%  x 17.40
 insert_erase_fx_random    14,424      30,487           16,063  111.36%   x 0.47
 insert_erase_fx_serial    13,538      20,360            6,822   50.39%   x 0.66
 insert_fx_highbits        140,010     25,987         -114,023  -81.44%   x 5.39
 insert_fx_random          22,838      26,389            3,551   15.55%   x 0.87
 insert_fx_serial          21,786      19,765           -2,021   -9.28%   x 1.10
 iter_fx_highbits          2,018       2,010                -8   -0.40%   x 1.00
 iter_fx_random            2,035       2,053                18    0.88%   x 0.99
 iter_fx_serial            2,037       2,038                 1    0.05%   x 1.00
 lookup_fail_fx_highbits   130,302     3,904          -126,398  -97.00%  x 33.38
 lookup_fail_fx_random     3,642       4,130               488   13.40%   x 0.88
 lookup_fail_fx_serial     2,707       3,845             1,138   42.04%   x 0.70
 lookup_fx_highbits        69,104      3,861           -65,243  -94.41%  x 17.90
 lookup_fx_random          3,387       4,114               727   21.46%   x 0.82
 lookup_fx_serial          3,197       3,833               636   19.89%   x 0.83

Looking at the disassembly, the only difference is the hash function (as expected):
AHash:
movabs    $0xab5ad457fe0d4dbd,%r13
xor       %rsi,%r13
movabs    $0x5851f42d4c957f2d,%rax
imul      %rax,%r13
rol       $0x9,%r13
imul      %rax,%r13

FxHash:
movabs    $0x517cc1b727220a95,%r13
imul      %rsi,%r13

On my system the AHash instruction sequence has a latency of 9 cycles (imul is 3 cycles, all other instructions 1 cycle) while FxHash only has a latency of 4 cycles.
@tkaitchuck Do you think it might be possible to get away with just a single multiply? Possibly using a trick from Absl Hash which is to perform a long u64 * u64 -> u128 multiply and then xor-ing the two words of the result. link

I could but that would be x86 speffic. There aren't a lot of processors with that instruction that lack the AES instruction. So I can add it as a third path, but I'm not sure it will see much use.

Update: I tried changing the update function in the fallback to
(self.buffer as u128).wrapping_mul(MULTIPLE as u128).convert(); and then two xors.
It actually made it slower in my benchmarks. I don't really understand why.

One thing I could do, is remove the final multiply in the finalize block. It would mean that primitives who's input only differed in the highest bit would have hashes that differ by only one bit. But with the rotation I could still guarantee that the difference would be in the low order byte. It would undermine the quality of the hash, but it may not be a problem in practice because longer inputs such as strings would not be materially affected.

@Amanieu
I tweaked the method you suggested and pushed it to aHash 0.2.2, try it out and let me know how it performs. It now seems to work fairly well for integers. For longer strings I am keeping the previous algorithm.
I may want to put it in a feature gate in the future depending on how fast it is on other platforms.

@bors r+

:pushpin: Commit 31fc802d4d73a40c53a8ca5575942c6c4b0ac6e8 has been approved by Amanieu

:hourglass: Testing commit 31fc802d4d73a40c53a8ca5575942c6c4b0ac6e8 with merge 95c19f43600d9302e8641781ae7bcccbb09e8653...

:sunny: Test successful - checks-travis
Approved by: Amanieu
Pushing 95c19f43600d9302e8641781ae7bcccbb09e8653 to master...


Allow mounting an external directory for local:/// storage.

Reference https://github.com/imgproxy/imgproxy/issues/1126
This change allows imgproxy to be configured to serve image files from a local filesystem mounted on /images.

Hi @rouilj!
You don't need these changes to mount a local directory to a container. You can just use the -v flag of docker run:
docker run -v /path/to/local/dir:/images -it darthsim/imgproxy:latest

docker service run doesn't support the -v flag, but supports the --mount flag:
docker servive run --mount type=bind,src=$(pwd)/www,dst=/www -t darthsim/imgproxy:latest

Interesting. I still think it's a good affordance to have though.
As I mentioned on the ticket, I didn't realize that you could mount into arbitrary or non-existent locations
in a docker container.

The VOLUME instruction will make a volume every time the image is run. I believe this is redundant for most users.


Release 0.5.0

Prepare for release 0.5.0

Update example code and logging notes in the README.
Manually deploy releases (for the time being)

Coverage remained the same at 92.913% when pulling 94fd139026ce966077ce59493c250f36f63cb4ef on rel-0.5.0 into 45c23b2e8331cfc6bce00c5f7aa2a32c2b002eec on master.

Coverage remained the same at 92.913% when pulling 94fd139026ce966077ce59493c250f36f63cb4ef on rel-0.5.0 into 45c23b2e8331cfc6bce00c5f7aa2a32c2b002eec on master.


Write a Python program to convert octal to decimal

Description
Write a Python program to convert octal to decimal
Octal is a base-8 number system. It uses only eight digits: 0, 1, 2, 3, 4, 5, 6, and 7. The digits are called octits. An octit is the smallest unit of information in a computer. An octit can be used to represent a single value, such as 0, 1, 2, 3, 4, 5, 6, or 7, or it can be used to represent a single state, such as on or off.
To convert an octal number to decimal, we can use the following algorithm:

Multiply the first octit by 8^0.
Multiply the second octit by 8^1.
Multiply the third octit by 8^2.
Multiply the fourth octit by 8^3.
Repeat steps 3 and 4 until the last octit.
Add the results of all the multiplications.
The decimal number is the sum of all the multiplications.

Input  : 12
Output : 10

How to contribute

Save the solution in convert-octal-to-decimal.py file
Add convert-octal-to-decimal.py file in convert-octal-to-decimal folder

!assign


Error building after import ngx-datatable

Angular 2
ERROR in<EMAIL_ADDRESS>(19417,15): All declarations of 'WeakMap' must have identical type parameters.)
ERROR in<EMAIL_ADDRESS>(425,16): Type 'KeyValueDiffer' is not generic.)
webpack: Failed to compile.

Typically people will insist you follow the form provided to make sure you capture the necessary information.
Can you provide a screenshot of the import itself, possibly how you are using it? Other valuable information would be the version of Angular you are currently running (Angular 2 really only tells us it wasn't Angular 1; current Swimlane builds target Angular v4)

Sorry,,
the problem was that I'm on Angular 2 and the npm is 7.0 +
I change this to 6.0 and now everything works.]
Sorry man.

All good, just trying to take some of the burden off the Swimlane team so they can give us more cool stuff.


File clean up for public release

this issue is for me to clean up my sketch file so we can release it via github and maybe later on the site

files too big currently for git - the public downloadable files is here!!!
its still in BETA, feedback welcome :)

opinionated templates are in the same folder.

any Updates?


Add support for Docker registry

Add support for the new feature: Docker registry. See http://docs.gitlab.com/ce/administration/container_registry.html#container-registry-domain-configuration

I've created a patch for this, which i'll try to pull-request. I couldn't find the directives on how to do this, so i just tried my best. This'll be my first ever contribution to an open source project, so please be gentle :)

Thanks for the PR, merged. After testing it a new release will be made.


Sneaking Problem

What is the output link of /viaversion dump?

Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
Craftbukkit 1.8.7

PermissionsEx
WorldEdit
Modifyworld
ViaVersion
Essentials
EssentialsSpawn
EssentialsChat

How does this error happen? login? Using an item?
I dont know why, but you can only see a Player sneaking, if the Player is opped.
Other Players can't see an unopped Player sneaking...
I cant explain that...
Is there an error in the console? Use pastebin.com. Is there a kick message?
No

This is not caused by ViaVersion. I recommend you to debug it, remove plugins one by one until it no longer happens to see which one is causing it.

I fixed it...
You have to add the permission: "-modifyworld.sneak"

Great to hear that (:


(FACT-1394) Fix warning for linkdown routes

Currently, Facter fails to process routes that are marked as linkdown, instead generating warnings for them.
This patch will therefore skip such entries entirely, giving the same outcome but without the warnings that the earlier method generates.
$ facter -p networking.interfaces.docker0
2016-10-31 08:54:40.260618 WARN  puppetlabs.facter - Could not process routing table entry: Expected a destination followed by key/value pairs, got '<IP_ADDRESS>/16 dev docker0  proto kernel  scope link  src <IP_ADDRESS> linkdown'
2016-10-31 08:54:40.261368 WARN  puppetlabs.facter - Could not process routing table entry: Expected a destination followed by key/value pairs, got 'fe80::/64 dev docker0  proto kernel  metric 256 linkdown  pref medium'
{
  bindings => [
    {
      address => "<IP_ADDRESS>",
      netmask => "<IP_ADDRESS>",
      network => "<IP_ADDRESS>"
    }
  ],
  bindings6 => [
    {
      address => "fe80::42:d5ff:fe36:1a50",
      netmask => "ffff:ffff:ffff:ffff::",
      network => "fe80::"
    }
  ],
  ip => "<IP_ADDRESS>",
  ip6 => "fe80::42:d5ff:fe36:1a50",
  mac => "02:42:d5:36:1a:50",
  mtu => 1500,
  netmask => "<IP_ADDRESS>",
  netmask6 => "ffff:ffff:ffff:ffff::",
  network => "<IP_ADDRESS>",
  network6 => "fe80::"
}
$ ./facter -p networking.interfaces.docker0
{
  bindings => [
    {
      address => "<IP_ADDRESS>",
      netmask => "<IP_ADDRESS>",
      network => "<IP_ADDRESS>"
    }
  ],
  bindings6 => [
    {
      address => "fe80::42:d5ff:fe36:1a50",
      netmask => "ffff:ffff:ffff:ffff::",
      network => "fe80::"
    }
  ],
  ip => "<IP_ADDRESS>",
  ip6 => "fe80::42:d5ff:fe36:1a50",
  mac => "02:42:d5:36:1a:50",
  mtu => 1500,
  netmask => "<IP_ADDRESS>",
  netmask6 => "ffff:ffff:ffff:ffff::",
  network => "<IP_ADDRESS>",
  network6 => "fe80::"
}

CLA signed by all contributors.

It looks like linkdown is actually being printed as a sort of fake key-value pair with an empty value - the first line in your warning has two spaces after it. We ignore redundant whitespace right now in two different places. Paying attention to that whitespace will avoid the extra iteration you're doing right now.

If linkdown is attempted as a key-value, then they do it really badly.
Here's the route output when wrapped in a string
$ ip r s | xargs -rn1 -d '\n' printf "'%s'\n" | grep docker
'<IP_ADDRESS>/16 dev docker0  proto kernel  scope link  src <IP_ADDRESS> linkdown '
$ ip -6 r s | xargs -rn1 -d '\n' printf "'%s'\n" | grep docker
'fe80::/64 dev docker0  proto kernel  metric 256 linkdown  pref medium'

The linkdown token seems more just plopped down somewhere in the string rather than being a key with empty value, all the true key-value pairs have double whitespace surrounding them after all.
ip route show seems to throw in an extra piece of whitespace at the end for all IPv4 routes as well, which probably doesn't help.

@ace13 ugh, I think you're right. In that case I think this is probably fine. It might be possible to beat it into slightly more idiomatic shape, but I'm not too concerned about that.
Apologies for how long it took to get back to you on this
@puppetlabs/facter-maintainers anybody else have opinions on this?


swaglog.cc: Remove unnecessary string copy

Are we sure there wasn't a reason why this was done? Maybe to solve alignment issues?

I don't know why they are here. I dived into json11's source and pretty sure the memory returned by dump is already aligned. The the possible reason(maybe) is want to be consistent with previous c version in this pr:https://github.com/commaai/openpilot/commit/46f3665279222ce53333a8c001def1b2a8e32926. @adeebshihadeh  did I get that right?

That makes sense. I can imaging how this came into existence. If @adeebshihadeh doesn't remember anything special about this code I'll merge it.

No, don't remember anything special about this.


Display errors in user friendly way

Based on https://github.com/software-mansion/protostar/pull/41

added no-color flag

Codecov Report

Merging #48 (08a6f72) into master (656f0b2) will decrease coverage by 2.35%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   90.62%   88.26%   -2.36%
==========================================
  Files          38       50      +12
  Lines         853     1040     +187
==========================================
+ Hits          773      918     +145
- Misses         80      122      +42

Impacted Files
Coverage Δ

src/commands/update/handle_update_command.py
33.33% <14.28%> (-4.17%)
:arrow_down:

src/cli.py
34.37% <15.00%> (-2.67%)
:arrow_down:

src/utils/standard_log_formatter.py
26.92% <23.52%> (-0.35%)
:arrow_down:

src/utils/retrieve_real_package_name.py
38.88% <38.88%> (ø)

src/commands/remove/handle_remove_command.py
50.00% <50.00%> (ø)

src/utils/retrieve_real_package_name_test.py
50.00% <50.00%> (ø)

src/utils/log_color_provider.py
73.07% <73.07%> (ø)

src/__init__.py
100.00% <100.00%> (ø)

src/commands/__init__.py
100.00% <100.00%> (ø)

src/commands/install/handle_install_command.py
53.84% <100.00%> (-3.30%)
:arrow_down:

... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656f0b2...08a6f72. Read the comment docs.


post: js-ipfs 0.41 release

TODO:

[x] Add contributors list

Ok, lets get this merged. It'll go out on Friday, so lets be sure to release tomorrow.


fix/ui_patch: resolve file upload issue

Fixes #84

Error message overflowing outside the dialog box is handled
Progress bar while uploading files and folders have been updated

This change is

r? @ustulation
(maidsafe_highfive has picked a reviewer for you, use r? to override)


wine + keyboard layout variants on linux

Hello, asweigart!
Okay, so this is a funny and obscure one.
Under Linux I have two US keyboard layout variants, qwerty and colemak.
I'm automating work with an old windows application, it's running under Wine.
When I tell pyautogui to typewrite a word, it's "pressing" the keys as they are located in colemak, but the letters appear from qwerty.
An example.
The first five keys in colemak are qwfpg. So if I say pyautogui.typewrite('qwfpg') it outputs 'qwerty' instead!
I already got a workaround (boot the box up with no colemak for simulation), but this can prove interesting to you )

I found a solution among other issues, and modified it a bit.
Here it goes:
`qwerty  = """qwertyuiop[]asdfghjkl;'zxcvbnm,.?/QWERTYUIOP{}ASDFGHJKL:"ZXCVBNM<>"""
colemak = """qwfpgjluy;[]arstdhneio'zxcvbkm,.?/QWFPGJLUY:{}ARSTDHNEIO"ZXCVBKM<>"""
tr = dict(zip(qwerty, colemak))
def translate(string):
"""Return a colemak key that should be pressed to output desired qwerty key"""
return "".join(map(lambda x: tr.get(x,x), string))
def typewrite(string):
"""Use this instead of pyautogui.typewrite()"""
pyautogui.typewrite(translate(string))`


Adds InstanceNorm

While playing around with fast style transfer I had to use InstanceNorm, the support was not there so I added it =)
For some reason there is a bunch of notebook metadata change on nbs/03_torch_core.ipynb but I did ran nbdev_install_git_hooks I swear lol.

Looks good to me, thanks!

@lgvaz Didn't catch it when reviewing but as a follow-up, your norm2 test for instance norm was making the one for batchnorm useless. Fixed now :)

Wow, that was a very sneaky bug hahaha, thanks for letting me know! =)


WIP [#158913461] Enable Prometheus Boshrelease

What
This PR enables the Prometheus Boshrelease with a 30 day retention
window. This is a rework of the previous firebreak activity due to the
changes that have been made by migrating to cf-deployment during the
past quarter.
How to review
Code review and deploy on top of a current master, check that the prometheus-vars-store.yml is in your state bucket and you can access the new components.
Who can review
Not @LeePorte or @chrisfarms

Superseded by #1504. Closing this.


Integer data type range and overflow checker

Vote on this issue by adding a 👍 reaction.
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Is your feature request related to a problem? Please describe.
As a developer, I am frequently looking up the ranges of signed and unsigned integers of various bit widths to ensure that my required values and value ranges will fit into these data types. A simple tool that would allow me to see this at a glance would be valuable.
Describe the solution you'd like
I would like to either:

Provide an integer value,
Select unsigned or unsigned (and perhaps 1s compliment or 2s compliment signed),
Select a bit width (8, 16, 32, 64),
See at a glance if my value is in range;

Or:

Provide an integer value,
See at a glance which integer data types are suitable (perhaps switching between 1s or 2s compliments)

Describe alternatives you've considered
Frequently googling "signed int 64 range", "integer ranges", etc and squinting at the values until I'm sure.
Additional context
Yes, I realise that I should (and many programmers do) remember these max and min values, but the problem is more about order of magnitude. Visually comparing, for example the max uint32 value 4,294,967,295 with some value in documentation like<PHONE_NUMBER> or<PHONE_NUMBER>0 to be certain that I've counted the zeros correctly is a pain, and is prone to error that can cause bugs that are difficult to identify.

Extending the suggestion:
Have include as a sidenote of the tool a handy lookup table of what the common aliases of variable types correspond to (D/QWORD, W/LPARAM etc), or integrated in some way that this tool mentally becomes the go-to cheat sheet for looking up integer type related info

Second extension of suggestion:
Not directly related to the original suggestion, but potentially if it becomes more appropriate to resolve the usecase raised by the suggestion via a more generally scoped tool pertaining to checking numeric type info, I specify here another tangentially related usecase void:
I often see certain perplexing decimal point numbers that looks like it is obviously the result of binary floating point rounding. I would like to be able to find the closest floating point match, i.e. the fewest power-of-2 digits needed such that the decimal representation rounded/floored/ceiled to the same decimal points of the input number matches itself.

One potential implementation is it being a "Is in the set of ", which lets you check if their decimal representation exactly match a list of binary types, and if not then what the error is when attempting to represent it in that type (e.g. under/overflow, closest matching floating point representation and its nearest bit, etc)


events - Triggering all time

Hi Team
Thanks for the wonderful Angular dropdown-multiselect component.
I am trying to use the events - onItemSelect() &  onItemDeSelect() but the events keeps triggering when I click any where instead of just the drop down.
I have also raised a stackoverflow issue.
http://stackoverflow.com/questions/34139031/dropdown-multiselect-events-triggering-all-time
Thanks

@jjayaraman  You have called both the events at the same time using events="onItemSelect(example1model); onItemDeselect(example1model)" .Therefore both the events are getting triggered.To use these events you should declare $scope variable which will store both the events like shown below.And use this variable in html events attribute.
Javascript
var jayApp = angular.module('jayApp',['angularjs-dropdown-multiselect']);

jayApp.controller('jayController', function($scope) {

	$scope.example1model = [];
	$scope.example1data = [ {id: 1, label: "David"}, {id: 2, label: "Jhon"}, {id: 3, label: "Danny"}];

	// MultiSelect Drop down select - Event
	$scope.selecEvents = {
      onItemSelect: function(property) {
        console.log('select > ' +property);
  	  },

	  onItemDeselect: function(property) {
        console.log('deselect : ' +property);
	  }
	}
})

HTML
<div ng-dropdown-multiselect="" options="example1data" selected-model="example1model" events="selectEvents">


Fetch all livemd files on Github for a single user in a worker

Create an Oban worker that searches all livemd from a single user. That way we'll also have old notebooks.
This is the API URL:
https://api.github.com/search/code?q=user:#{username}+extension:livemd&per_page=#{per_page}&page=#{page}&sort=indexed&order=#{order}
After this ticket, we could create these issues:

Periodically re-fetch all notebooks from each user
Refactor populate.ex as we could enqueue to fetch all notebooks from new users

I'm happy to help!

@BrooklinJazz, his open-source collaboration group and I did this:

GithubAPI.get/1 optionally accepts username https://github.com/notesclub/notesclub/pull/55
Notebooks.create_notebook/1 now also creates repo and user associations if they don't exist. https://github.com/notesclub/notesclub/pull/60
Notebooks.save_notebook/1 creates or updates a notebook depending on some conditions. https://github.com/notesclub/notesclub/pull/60 (same PR)


[TextInput] Does not respect border[TopLeft|BottomLeft|BottomRight|TopRight]Radius style

According to the documentation, TextInput should inherit from View Styles.
https://facebook.github.io/react-native/docs/text.html#style
However, the following borderRadius styles do not get applied and no exception or warnings (that i could see) are thrown.
borderTopLeftRadius
borderTopRightRadius
borderBottomLeftRadius
borderBottomRightRadius

This still happening @jaygarcia ?

@browniefed , negative. This must have been fixed w/out this issue being visited.
Thanks :)


[Backport]Document method to easily update Longhorn settings in scripted fashion/across multiple clusters

https://github.com/longhorn/longhorn/issues/3578

Use #3654 to tacking, deprecated this one.


Binding not working RecommendationsView

This DistanceKilometers variable does not exist, you could atleast show the miles now, but I saw some code for converting the miles to km, so perhaps you were aware.
Line 101

Yes, Tinder only gives miles. I used to multiply it by 1.6 in the model, but then I thought to do it another and then I probably forgot it lol.
Now I'm reworking chat UI. After I do that I'll get to reworking recommendations UI and match UI, they are buggy,don't show all the info and are overall inconsistent.

Ah ok good to know :)


Dynamic port handling bug (server.port=0)

Hello
It seems that spring-boot-admin does not consider dynamic ports. The spring-boot-admin-ui displays the services as "OFFLINE" (and the port in the name is :0 like set in server.port=0).
Regards
Matthias

I've fixed it (defined custom SpringBootAdminRegistrator)....


Flag Evaluation Specification

The flag evaluation API specification defines the application developer facing API.
Scope

[x] #27

Calling this done for as much as we know. #86 should find the rest.


UI responsiveness

[x] Disabling download of a torrent doesn't update UI immediately
[ ] Dropping a large file to seed takes seconds to show up in the UI.

We should show it right away, and not wait for the 'torrent' event which only happens after the whole file has been hashed.

[ ] Mouseover events take up to 1 second to kick in because they're not handled right away but only on update(). The right way to handle them is immediately, but throttled.

I can fix the second one.
For the third one, what do you mean by "Mouseover events take up to 1 second to kick in"?

Re: mousovers being slow, I see what you mean now -- I assume you're talking about the buttons showing up in the torrent list when you mouse over a torrent. I've seen that take >1 second, too.
Unfortunately that's not done in update(), the buttons show up using a CSS :hover. It's lagging on startup when I have lots of torrents and WebTorrent is verifying ~20GB worth of files.

Caching file verification results with the file modtime will make startup a smoother & less laggy
I think the Real Fix is moving WebTorrent to a different process

@dcposch Re: that third point, I'm actually talking about how the player UI currently shows/hides itself. It can take up to one second for a mediaMouseMoved event to cause the UI to show up.
I'll re-open this for now and take a stab at fixing it later.


Hyprland crashes on startup

I have installed Hyprland on Arch Linux with Nvidia on laptop, I tried to install it via arch install and HyprV4

cool, invalid issue


Debug Call Stack UI for multithreaded programs does not show text on hover because inline actions appear

VSCode Version: 1.49.0, 1.50.0-insider
OS Version: macOS catalina 10.15.6

The debugging UI in the call stack for exceptions does not display all of the Stopped Event information when debugging multithreaded code. This was originally discovered and raised when developing the Go debugger in #104475 but is also reproducible in other languages when debugging multithreaded code.
The spec for stopped events while debugging says that the text will be displayed in the UI, but this appears to only be the case in a single threaded program. The 'text' and 'description' fields in the stopped event appear to be ignored with multithreaded programs.
The description in the dap spec indicates these are both displayed in the UI:
    /**
     * The reason for the event.
     * For backward compatibility this string is shown in the UI if the 'description' attribute is missing (but it must not be translated).
     * Values: 'step', 'breakpoint', 'exception', 'pause', 'entry', 'goto', 'function breakpoint', 'data breakpoint', 'instruction breakpoint', etc.
     */
    reason: string;
    /**
     * The full reason for the event, e.g. 'Paused on exception'. This string is shown in the UI as is and must be translated.
     */
    description?: string;
    /**
     * Additional information. E.g. if reason is 'exception', text contains the exception name. This string is shown in the UI.
     */
    text?: string;

Steps to Reproduce:

Debug a multithreaded program and stop on an exception
Inspect call stack

Using the python extension as an example for debugging a single thread and a multithreaded program.
The stopped event for the exception in both programs is as follows:
           {
                 "pydevd_cmd_id": 157,
                 "seq": 30,
                 "type": "event",
                 "event": "stopped",
                 "body": {
                     "reason": "exception",
                     "description": "oops",
                     "threadId": 1,
                     "preserveFocusHint": false,
                     "text": "ValueError",
                     "allThreadsStopped": true
                 }
             }

A raised exception on a single thread appears like this:

Hover:

While the multithreaded exception appears like this:

Hover:

@suzmue Thank you for narrowing down this issue to the multi-threaded scenario. I should have realized that's why the call stacks looked so different for go (always multi-threaded due to runtime implementation) and other languages I checked.

Correct we do not show text because on hover we show the inline actions, so there is no good place to show this. I acklnowledge this bug. And am open for suggestions on how to show it.
However we should always respect the description and render it. I pushed a fix such that we are sure to always respect the description.

Is the description supposed to replace "paused on " message? (On a related note, what documentation do you recommend to figure out how the various fields in each dap message are reflected in the vscode UI?)
It looks to me that the mouse-over appears under the line, not over it, so perhaps you can have both the hover text and the inline actions? There is already some kind of mouse-over  there that says "Thread" in addition to those inline actions.

If showing text for multi-threaded programs, is not in scope for vscode, then is there a better place to file for this improvement.
Re: description. We verified and see that it is working. Thank you.

Re: text. We would love to be able to provide additional details on stopped events. If 'text' is not possible for multi-threaded programs, is there a different hook that would allow us to replace mouse-over with the single world "Thread" (image) with something more useful? Thank you.

If showing text for multi-threaded programs, is not in scope for vscode, then is there a better place to file for this improvement.
Re: description. We verified and see that it is working. Thank you.

Re: text. We would love to be able to provide additional details on stopped events. If 'text' is not possible for multi-threaded programs, is there a different hook that would allow us to replace mouse-over with the single world "Thread" (image) with something more useful? Thank you.


Open the hunk data in utf-8.

Decode the data of the hunk in utf-8, before this the data was encoded in ascii so it was failing to build.

As you can see, the tests are failing.
As far as I remember, the idea is that hunk.data() returns a unicode object, so a decode is not appropriate or necessary there.


Create issue templates

Previously dotnet/core had a single, rudimentary template, and bug quality is sometimes poor and missing key info.

Improve the bug template to match the dotnet/runtime one, but with added encouragement to go ahead and file anyway if unsure about anything.
Add a list of links to other repos' new issue templates, and a link to security issue procedures, to match our other repos.

When this is merged, clicking new issue in this repo will give a page like this: https://github.com/danmosemsft/core/issues/new/choose

Note that some issues come pre-filled from the website.

Note that some issues come pre-filled from the website.

@mairaw ah..I wonder whether there's scope to improve the instructions there too to help get more actionable reports?

@mairaw ah..I wonder whether there's scope to improve the instructions there too to help get more actionable reports?

I can change the template for that too. Usually, folks will be following a tutorial and then click on the "I ran into an issue" button on pages such as https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/run.

I can change the template for that too. Usually, folks will be following a tutorial and then click on the "I ran into an issue" button on pages such as https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/run.

Yes that would be great. Perhaps the template in this PR could be a template .. for the template.

Yes that would be great. Perhaps the template in this PR could be a template .. for the template.

I think the template is not 100% relevant for folks who are new to the technology and I don't want to over complicate things. There is no regression involved, for example.

I think the template is not 100% relevant for folks who are new to the technology and I don't want to over complicate things. There is no regression involved, for example.

I'm a bit confused as clicking the button you mention goes to the template I'm updating. Maybe that's your point 🙂

I'm a bit confused as clicking the button you mention goes to the template I'm updating. Maybe that's your point 🙂

Would you be OK signing off @mairaw ?

Would you be OK signing off @mairaw ?


Memoization (release 2.9.8) is not always good

parser memoization introduced with release 2.9.8 (fix #414) is not always faster as benchcurrent shows (on branch performance/memoization-slows-down) :

BenchmarkDotNet v0.13.12, Windows 10 (10.0.19045.4291/22H2/2022Update)
Intel Core i7-10610U CPU 1.80GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 8.0.104
  [Host]     : .NET 7.0.4 (7.0.423.11508), X64 RyuJIT AVX2
  DefaultJob : .NET 7.0.4 (7.0.423.11508), X64 RyuJIT AVX2

Method
Memoize
Mean
Error
StdDev
Gen0
Gen1
Gen2
Allocated

TestJson
False
88.09 ms
1.714 ms
1.905 ms
9500.0000
3500.0000
1500.0000
54 MB

TestJson
True
122.42 ms
2.438 ms
4.925 ms
10800.0000
3800.0000
1800.0000
66.62 MB

Memoization works well when a grammar leads to heavy backtracking. In the case of JSON backtracing is limited and memoization slow down the parse.
Memoization should be a opt-in.
Add another benchmark that could demonstrate the added value  of memoization in case of heavy backtracking (see #414 )

using #414 parser as a base memoization shows its value :

BenchmarkDotNet v0.13.12, Windows 10 (10.0.19045.4291/22H2/2022Update)
Intel Core i7-10610U CPU 1.80GHz, 1 CPU, 8 logical and 4 physical cores
.NET SDK 8.0.104
  [Host]     : .NET 7.0.4 (7.0.423.11508), X64 RyuJIT AVX2
  DefaultJob : .NET 7.0.4 (7.0.423.11508), X64 RyuJIT AVX2

Method
Memoize
Mean
Error
StdDev
Gen0
Gen1
Gen2
Allocated

TestBackTrack
False
809.85 ms
15.010 ms
34.184 ms
169000.0000
39000.0000
8000.0000
929.6 MB

TestBackTrack
True
33.83 ms
1.289 ms
3.697 ms
1812.5000
1781.2500
1406.2500
23.8 MB

Fixed #436


Branch checkout without a local branch fails!

@Nageswari-droid fix delivered with https://github.com/neel1996/gitconvex-server/commit/618fe699237050e86c3348ec8d4c722a379deae8

@Nageswari-droid Update the status after testing the fix

2020/11/24 13:14:20 ERROR: Command execution for -> {{C:\Program Files\Git\mingw64\bin\git.exe -C D:\flutter log --oneline -1 --pretty=format:%s dev}} failed with error exit status 128