Synthesis failed for python-compute

Hello! Autosynth couldn't regenerate python-compute. :broken_heart:
Here's the output from running synth.py:
e-v1-py.tar.gz: patch does not apply
2021-01-12 05:56:47,849 autosynth [ERROR] > Command '['git', 'apply', '/tmpfs/tmp/tmpsg6j063h/autosynth-googleapis-discovery-0.patch']' returned non-zero exit status 1.
2021-01-12 05:56:48,187 autosynth [DEBUG] > Running: git checkout 31fa79456f8e236befc4a61271405e9bec42c22f
Note: checking out '31fa79456f8e236befc4a61271405e9bec42c22f'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 31fa794 chore: release 0.1.0 (#1)
2021-01-12 05:56:48,202 autosynth [DEBUG] > Running: git checkout ed8fe29ede4a8c5117c955bf0972e6b751800e41
HEAD is now at ed8fe29 fix(samples,php): Integrate latest gapic-generator (#17)
2021-01-12 05:56:48,207 autosynth [DEBUG] > Running: git checkout fb53b6fb373b7c3edf4e55f3e8036bc6d73fa483
HEAD is now at fb53b6f chore(python): skip docfx in main presubmit (#889)
2021-01-12 05:56:48,212 autosynth [DEBUG] > Running: git branch -f autosynth-0
2021-01-12 05:56:48,216 autosynth [DEBUG] > Running: git checkout autosynth-0
Switched to branch 'autosynth-0'
2021-01-12 05:56:48,222 autosynth [DEBUG] > Running: git merge --ff-only autosynth-googleapis-discovery-0
Updating 31fa794..29e7649
Fast-forward
 .kokoro/docs/docs-presubmit.cfg                    |   2 +-
 compute-v1-py.tar.gz                               | Bin 0 -> 360448 bytes
 google/cloud/compute_v1/__init__.py                |   4 +-
 .../services/accelerator_types/transports/rest.py  |  10 +-
 .../services/addresses/transports/rest.py          |  10 +-
 .../services/autoscalers/transports/rest.py        |  10 +-
 .../services/backend_buckets/transports/rest.py    |   4 +-
 .../services/backend_services/transports/rest.py   |  10 +-
 .../services/disk_types/transports/rest.py         |  10 +-
 .../compute_v1/services/disks/transports/rest.py   |  14 +-
 .../external_vpn_gateways/transports/rest.py       |   4 +-
 .../services/firewalls/transports/rest.py          |   4 +-
 .../services/forwarding_rules/transports/rest.py   |  10 +-
 .../services/global_addresses/transports/rest.py   |   4 +-
 .../global_forwarding_rules/transports/rest.py     |   4 +-
 .../transports/rest.py                             |   8 +-
 .../services/global_operations/transports/rest.py  |  10 +-
 .../transports/rest.py                             |   4 +-
 .../services/health_checks/transports/rest.py      |  10 +-
 .../compute_v1/services/images/transports/rest.py  |   6 +-
 .../instance_group_managers/transports/rest.py     |  22 +-
 .../services/instance_groups/transports/rest.py    |  14 +-
 .../services/instance_templates/transports/rest.py |   4 +-
 .../services/instances/transports/rest.py          |  34 +-
 .../interconnect_attachments/transports/rest.py    |  12 +-
 .../interconnect_locations/transports/rest.py      |   4 +-
 .../services/interconnects/transports/rest.py      |   4 +-
 .../services/licenses/transports/rest.py           |   6 +-
 .../services/machine_types/transports/rest.py      |  10 +-
 .../network_endpoint_groups/transports/rest.py     |  14 +-
 .../services/networks/transports/rest.py           |  12 +-
 .../services/node_groups/transports/rest.py        |  16 +-
 .../services/node_templates/transports/rest.py     |  10 +-
 .../services/node_types/transports/rest.py         |  10 +-
 .../services/packet_mirrorings/transports/rest.py  |  10 +-
 .../services/projects/transports/rest.py           |   8 +-
 .../services/region_autoscalers/transports/rest.py |   4 +-
 .../region_backend_services/transports/rest.py     |   4 +-
 .../services/region_commitments/transports/rest.py |  10 +-
 .../services/region_disk_types/transports/rest.py  |   4 +-
 .../services/region_disks/transports/rest.py       |   6 +-
 .../transports/rest.py                             |   4 +-
 .../region_health_checks/transports/rest.py        |   4 +-
 .../transports/rest.py                             |  16 +-
 .../region_instance_groups/transports/rest.py      |   8 +-
 .../transports/rest.py                             |   4 +-
 .../transports/rest.py                             |   4 +-
 .../services/region_operations/transports/rest.py  |   4 +-
 .../region_ssl_certificates/transports/rest.py     |   4 +-
 .../region_target_http_proxies/transports/rest.py  |   4 +-
 .../region_target_https_proxies/transports/rest.py |   4 +-
 .../services/region_url_maps/transports/rest.py    |   4 +-
 .../compute_v1/services/regions/transports/rest.py |   4 +-
 .../services/reservations/transports/rest.py       |  10 +-
 .../services/resource_policies/transports/rest.py  |  10 +-
 .../compute_v1/services/routers/transports/rest.py |  14 +-
 .../compute_v1/services/routes/transports/rest.py  |   4 +-
 .../services/security_policies/transports/rest.py  |   8 +-
 .../services/snapshots/transports/rest.py          |   4 +-
 .../services/ssl_certificates/transports/rest.py   |  10 +-
 .../services/ssl_policies/transports/rest.py       |   8 +-
 .../services/subnetworks/transports/rest.py        |  14 +-
 .../target_grpc_proxies/transports/rest.py         |   4 +-
 .../target_http_proxies/transports/rest.py         |  10 +-
 .../target_https_proxies/transports/rest.py        |  10 +-
 .../services/target_instances/transports/rest.py   |  10 +-
 .../services/target_pools/transports/rest.py       |  12 +-
 .../services/target_ssl_proxies/transports/rest.py |   4 +-
 .../services/target_tcp_proxies/transports/rest.py |   4 +-
 .../target_vpn_gateways/transports/rest.py         |  10 +-
 .../services/url_maps/transports/rest.py           |  10 +-
 .../services/vpn_gateways/transports/rest.py       |  10 +-
 .../services/vpn_tunnels/transports/rest.py        |  10 +-
 .../services/zone_operations/transports/rest.py    |   4 +-
 .../compute_v1/services/zones/transports/rest.py   |   4 +-
 scripts/fixup_compute_v1_keywords.py               |  74 +--
 synth.metadata                                     | 595 ++++++++++++++++++++-
 77 files changed, 932 insertions(+), 341 deletions(-)
 create mode 100644 compute-v1-py.tar.gz
2021-01-12 05:56:48,281 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at 29e7649 chore: release 0.1.0
2021-01-12 05:56:48,312 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2021-01-12 05:56:48,342 autosynth [DEBUG] > Running: git diff HEAD..autosynth-0 -- . :(exclude)synth.metadata
2021-01-12 05:56:48,378 autosynth [DEBUG] > Running: git diff HEAD autosynth-0
2021-01-12 05:56:48,414 autosynth [DEBUG] > Running: git apply /tmpfs/tmp/tmpsg6j063h/autosynth-0.patch
error: cannot apply binary patch to 'compute-v1-py.tar.gz' without full index line
error: compute-v1-py.tar.gz: patch does not apply
2021-01-12 05:56:48,429 autosynth [DEBUG] > Running: git clean -fdx
Removing .nox/
Removing __pycache__/
Traceback (most recent call last):
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 92, in synthesize_loop
    synthesize_inner_loop(fork, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 149, in synthesize_inner_loop
    toolbox.patch_merge_version(0, comment)
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 182, in patch_merge_version
    git.patch_merge(sub_branch, patch_file_path)
  File "/tmpfs/src/github/synthtool/autosynth/git.py", line 151, in patch_merge
    executor.check_call(["git", "apply", patch_file_path], cwd=git_repo_dir)
  File "/tmpfs/src/github/synthtool/autosynth/executor.py", line 29, in check_call
    subprocess.check_call(command, **args)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'apply', '/tmpfs/tmp/tmpsg6j063h/autosynth-googleapis-discovery-0.patch']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 334, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 100, in synthesize_loop
    synthesize_loop_single_pr(toolbox, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 126, in synthesize_loop_single_pr
    synthesize_inner_loop(toolbox, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 149, in synthesize_inner_loop
    toolbox.patch_merge_version(0, comment)
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 182, in patch_merge_version
    git.patch_merge(sub_branch, patch_file_path)
  File "/tmpfs/src/github/synthtool/autosynth/git.py", line 151, in patch_merge
    executor.check_call(["git", "apply", patch_file_path], cwd=git_repo_dir)
  File "/tmpfs/src/github/synthtool/autosynth/executor.py", line 29, in check_call
    subprocess.check_call(command, **args)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'apply', '/tmpfs/tmp/tmpsg6j063h/autosynth-0.patch']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating python-compute. :sob:
Here's the output from running synth.py:
te-v1-py.tar.gz: patch does not apply
2021-01-13 05:53:36,046 autosynth [ERROR] > Command '['git', 'apply', '/tmpfs/tmp/tmp6psuicng/autosynth-googleapis-discovery-0.patch']' returned non-zero exit status 1.
2021-01-13 05:53:36,246 autosynth [DEBUG] > Running: git checkout 31fa79456f8e236befc4a61271405e9bec42c22f
Note: checking out '31fa79456f8e236befc4a61271405e9bec42c22f'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 31fa794 chore: release 0.1.0 (#1)
2021-01-13 05:53:36,263 autosynth [DEBUG] > Running: git checkout ed8fe29ede4a8c5117c955bf0972e6b751800e41
HEAD is now at ed8fe29 fix(samples,php): Integrate latest gapic-generator (#17)
2021-01-13 05:53:36,268 autosynth [DEBUG] > Running: git checkout fb53b6fb373b7c3edf4e55f3e8036bc6d73fa483
HEAD is now at fb53b6f chore(python): skip docfx in main presubmit (#889)
2021-01-13 05:53:36,275 autosynth [DEBUG] > Running: git branch -f autosynth-0
2021-01-13 05:53:36,280 autosynth [DEBUG] > Running: git checkout autosynth-0
Switched to branch 'autosynth-0'
2021-01-13 05:53:36,287 autosynth [DEBUG] > Running: git merge --ff-only autosynth-googleapis-discovery-0
Updating 31fa794..e47f860
Fast-forward
 .kokoro/docs/docs-presubmit.cfg                    |   2 +-
 compute-v1-py.tar.gz                               | Bin 0 -> 360448 bytes
 google/cloud/compute_v1/__init__.py                |   4 +-
 .../services/accelerator_types/transports/rest.py  |  10 +-
 .../services/addresses/transports/rest.py          |  10 +-
 .../services/autoscalers/transports/rest.py        |  10 +-
 .../services/backend_buckets/transports/rest.py    |   6 +-
 .../services/backend_services/transports/rest.py   |  12 +-
 .../services/disk_types/transports/rest.py         |  10 +-
 .../compute_v1/services/disks/transports/rest.py   |  10 +-
 .../external_vpn_gateways/transports/rest.py       |   4 +-
 .../services/firewalls/transports/rest.py          |   4 +-
 .../services/forwarding_rules/transports/rest.py   |  10 +-
 .../services/global_addresses/transports/rest.py   |   4 +-
 .../global_forwarding_rules/transports/rest.py     |   4 +-
 .../transports/rest.py                             |   8 +-
 .../services/global_operations/transports/rest.py  |  10 +-
 .../transports/rest.py                             |   6 +-
 .../services/health_checks/transports/rest.py      |  10 +-
 .../compute_v1/services/images/transports/rest.py  |   4 +-
 .../instance_group_managers/transports/rest.py     |  24 +-
 .../services/instance_groups/transports/rest.py    |  14 +-
 .../services/instance_templates/transports/rest.py |   4 +-
 .../services/instances/transports/rest.py          |  26 +-
 .../interconnect_attachments/transports/rest.py    |  12 +-
 .../interconnect_locations/transports/rest.py      |   4 +-
 .../services/interconnects/transports/rest.py      |   4 +-
 .../services/licenses/transports/rest.py           |   4 +-
 .../services/machine_types/transports/rest.py      |  10 +-
 .../network_endpoint_groups/transports/rest.py     |  14 +-
 .../services/networks/transports/rest.py           |  12 +-
 .../services/node_groups/transports/rest.py        |  14 +-
 .../services/node_templates/transports/rest.py     |  10 +-
 .../services/node_types/transports/rest.py         |  10 +-
 .../services/packet_mirrorings/transports/rest.py  |  10 +-
 .../services/projects/transports/rest.py           |   8 +-
 .../services/region_autoscalers/transports/rest.py |   4 +-
 .../region_backend_services/transports/rest.py     |   4 +-
 .../services/region_commitments/transports/rest.py |  10 +-
 .../services/region_disk_types/transports/rest.py  |   4 +-
 .../services/region_disks/transports/rest.py       |   4 +-
 .../transports/rest.py                             |   4 +-
 .../region_health_checks/transports/rest.py        |   4 +-
 .../transports/rest.py                             |  18 +-
 .../region_instance_groups/transports/rest.py      |   8 +-
 .../transports/rest.py                             |   4 +-
 .../transports/rest.py                             |   4 +-
 .../services/region_operations/transports/rest.py  |   4 +-
 .../region_ssl_certificates/transports/rest.py     |   4 +-
 .../region_target_http_proxies/transports/rest.py  |   4 +-
 .../region_target_https_proxies/transports/rest.py |   4 +-
 .../services/region_url_maps/transports/rest.py    |   4 +-
 .../compute_v1/services/regions/transports/rest.py |   4 +-
 .../services/reservations/transports/rest.py       |  10 +-
 .../services/resource_policies/transports/rest.py  |  10 +-
 .../compute_v1/services/routers/transports/rest.py |  14 +-
 .../compute_v1/services/routes/transports/rest.py  |   4 +-
 .../services/security_policies/transports/rest.py  |   8 +-
 .../services/snapshots/transports/rest.py          |   4 +-
 .../services/ssl_certificates/transports/rest.py   |  10 +-
 .../services/ssl_policies/transports/rest.py       |   8 +-
 .../services/subnetworks/transports/rest.py        |  14 +-
 .../target_grpc_proxies/transports/rest.py         |   4 +-
 .../target_http_proxies/transports/rest.py         |  10 +-
 .../target_https_proxies/transports/rest.py        |  10 +-
 .../services/target_instances/transports/rest.py   |  10 +-
 .../services/target_pools/transports/rest.py       |  12 +-
 .../services/target_ssl_proxies/transports/rest.py |   4 +-
 .../services/target_tcp_proxies/transports/rest.py |   4 +-
 .../target_vpn_gateways/transports/rest.py         |  10 +-
 .../services/url_maps/transports/rest.py           |  10 +-
 .../services/vpn_gateways/transports/rest.py       |  10 +-
 .../services/vpn_tunnels/transports/rest.py        |  10 +-
 .../services/zone_operations/transports/rest.py    |   4 +-
 .../compute_v1/services/zones/transports/rest.py   |   4 +-
 scripts/fixup_compute_v1_keywords.py               |  30 +-
 synth.metadata                                     | 595 ++++++++++++++++++++-
 77 files changed, 905 insertions(+), 314 deletions(-)
 create mode 100644 compute-v1-py.tar.gz
2021-01-13 05:53:36,341 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at e47f860 chore: release 0.1.0
2021-01-13 05:53:36,376 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2021-01-13 05:53:36,407 autosynth [DEBUG] > Running: git diff HEAD..autosynth-0 -- . :(exclude)synth.metadata
2021-01-13 05:53:36,445 autosynth [DEBUG] > Running: git diff HEAD autosynth-0
2021-01-13 05:53:36,483 autosynth [DEBUG] > Running: git apply /tmpfs/tmp/tmp6psuicng/autosynth-0.patch
error: cannot apply binary patch to 'compute-v1-py.tar.gz' without full index line
error: compute-v1-py.tar.gz: patch does not apply
2021-01-13 05:53:36,500 autosynth [DEBUG] > Running: git clean -fdx
Removing .nox/
Removing __pycache__/
Traceback (most recent call last):
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 92, in synthesize_loop
    synthesize_inner_loop(fork, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 149, in synthesize_inner_loop
    toolbox.patch_merge_version(0, comment)
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 182, in patch_merge_version
    git.patch_merge(sub_branch, patch_file_path)
  File "/tmpfs/src/github/synthtool/autosynth/git.py", line 151, in patch_merge
    executor.check_call(["git", "apply", patch_file_path], cwd=git_repo_dir)
  File "/tmpfs/src/github/synthtool/autosynth/executor.py", line 29, in check_call
    subprocess.check_call(command, **args)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'apply', '/tmpfs/tmp/tmp6psuicng/autosynth-googleapis-discovery-0.patch']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 334, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 100, in synthesize_loop
    synthesize_loop_single_pr(toolbox, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 126, in synthesize_loop_single_pr
    synthesize_inner_loop(toolbox, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 149, in synthesize_inner_loop
    toolbox.patch_merge_version(0, comment)
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 182, in patch_merge_version
    git.patch_merge(sub_branch, patch_file_path)
  File "/tmpfs/src/github/synthtool/autosynth/git.py", line 151, in patch_merge
    executor.check_call(["git", "apply", patch_file_path], cwd=git_repo_dir)
  File "/tmpfs/src/github/synthtool/autosynth/executor.py", line 29, in check_call
    subprocess.check_call(command, **args)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'apply', '/tmpfs/tmp/tmp6psuicng/autosynth-0.patch']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth is still having trouble generating python-compute. :sob:
Here's the output from running synth.py:
te-v1-py.tar.gz: patch does not apply
2021-01-13 05:53:36,046 autosynth [ERROR] > Command '['git', 'apply', '/tmpfs/tmp/tmp6psuicng/autosynth-googleapis-discovery-0.patch']' returned non-zero exit status 1.
2021-01-13 05:53:36,246 autosynth [DEBUG] > Running: git checkout 31fa79456f8e236befc4a61271405e9bec42c22f
Note: checking out '31fa79456f8e236befc4a61271405e9bec42c22f'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 31fa794 chore: release 0.1.0 (#1)
2021-01-13 05:53:36,263 autosynth [DEBUG] > Running: git checkout ed8fe29ede4a8c5117c955bf0972e6b751800e41
HEAD is now at ed8fe29 fix(samples,php): Integrate latest gapic-generator (#17)
2021-01-13 05:53:36,268 autosynth [DEBUG] > Running: git checkout fb53b6fb373b7c3edf4e55f3e8036bc6d73fa483
HEAD is now at fb53b6f chore(python): skip docfx in main presubmit (#889)
2021-01-13 05:53:36,275 autosynth [DEBUG] > Running: git branch -f autosynth-0
2021-01-13 05:53:36,280 autosynth [DEBUG] > Running: git checkout autosynth-0
Switched to branch 'autosynth-0'
2021-01-13 05:53:36,287 autosynth [DEBUG] > Running: git merge --ff-only autosynth-googleapis-discovery-0
Updating 31fa794..e47f860
Fast-forward
 .kokoro/docs/docs-presubmit.cfg                    |   2 +-
 compute-v1-py.tar.gz                               | Bin 0 -> 360448 bytes
 google/cloud/compute_v1/__init__.py                |   4 +-
 .../services/accelerator_types/transports/rest.py  |  10 +-
 .../services/addresses/transports/rest.py          |  10 +-
 .../services/autoscalers/transports/rest.py        |  10 +-
 .../services/backend_buckets/transports/rest.py    |   6 +-
 .../services/backend_services/transports/rest.py   |  12 +-
 .../services/disk_types/transports/rest.py         |  10 +-
 .../compute_v1/services/disks/transports/rest.py   |  10 +-
 .../external_vpn_gateways/transports/rest.py       |   4 +-
 .../services/firewalls/transports/rest.py          |   4 +-
 .../services/forwarding_rules/transports/rest.py   |  10 +-
 .../services/global_addresses/transports/rest.py   |   4 +-
 .../global_forwarding_rules/transports/rest.py     |   4 +-
 .../transports/rest.py                             |   8 +-
 .../services/global_operations/transports/rest.py  |  10 +-
 .../transports/rest.py                             |   6 +-
 .../services/health_checks/transports/rest.py      |  10 +-
 .../compute_v1/services/images/transports/rest.py  |   4 +-
 .../instance_group_managers/transports/rest.py     |  24 +-
 .../services/instance_groups/transports/rest.py    |  14 +-
 .../services/instance_templates/transports/rest.py |   4 +-
 .../services/instances/transports/rest.py          |  26 +-
 .../interconnect_attachments/transports/rest.py    |  12 +-
 .../interconnect_locations/transports/rest.py      |   4 +-
 .../services/interconnects/transports/rest.py      |   4 +-
 .../services/licenses/transports/rest.py           |   4 +-
 .../services/machine_types/transports/rest.py      |  10 +-
 .../network_endpoint_groups/transports/rest.py     |  14 +-
 .../services/networks/transports/rest.py           |  12 +-
 .../services/node_groups/transports/rest.py        |  14 +-
 .../services/node_templates/transports/rest.py     |  10 +-
 .../services/node_types/transports/rest.py         |  10 +-
 .../services/packet_mirrorings/transports/rest.py  |  10 +-
 .../services/projects/transports/rest.py           |   8 +-
 .../services/region_autoscalers/transports/rest.py |   4 +-
 .../region_backend_services/transports/rest.py     |   4 +-
 .../services/region_commitments/transports/rest.py |  10 +-
 .../services/region_disk_types/transports/rest.py  |   4 +-
 .../services/region_disks/transports/rest.py       |   4 +-
 .../transports/rest.py                             |   4 +-
 .../region_health_checks/transports/rest.py        |   4 +-
 .../transports/rest.py                             |  18 +-
 .../region_instance_groups/transports/rest.py      |   8 +-
 .../transports/rest.py                             |   4 +-
 .../transports/rest.py                             |   4 +-
 .../services/region_operations/transports/rest.py  |   4 +-
 .../region_ssl_certificates/transports/rest.py     |   4 +-
 .../region_target_http_proxies/transports/rest.py  |   4 +-
 .../region_target_https_proxies/transports/rest.py |   4 +-
 .../services/region_url_maps/transports/rest.py    |   4 +-
 .../compute_v1/services/regions/transports/rest.py |   4 +-
 .../services/reservations/transports/rest.py       |  10 +-
 .../services/resource_policies/transports/rest.py  |  10 +-
 .../compute_v1/services/routers/transports/rest.py |  14 +-
 .../compute_v1/services/routes/transports/rest.py  |   4 +-
 .../services/security_policies/transports/rest.py  |   8 +-
 .../services/snapshots/transports/rest.py          |   4 +-
 .../services/ssl_certificates/transports/rest.py   |  10 +-
 .../services/ssl_policies/transports/rest.py       |   8 +-
 .../services/subnetworks/transports/rest.py        |  14 +-
 .../target_grpc_proxies/transports/rest.py         |   4 +-
 .../target_http_proxies/transports/rest.py         |  10 +-
 .../target_https_proxies/transports/rest.py        |  10 +-
 .../services/target_instances/transports/rest.py   |  10 +-
 .../services/target_pools/transports/rest.py       |  12 +-
 .../services/target_ssl_proxies/transports/rest.py |   4 +-
 .../services/target_tcp_proxies/transports/rest.py |   4 +-
 .../target_vpn_gateways/transports/rest.py         |  10 +-
 .../services/url_maps/transports/rest.py           |  10 +-
 .../services/vpn_gateways/transports/rest.py       |  10 +-
 .../services/vpn_tunnels/transports/rest.py        |  10 +-
 .../services/zone_operations/transports/rest.py    |   4 +-
 .../compute_v1/services/zones/transports/rest.py   |   4 +-
 scripts/fixup_compute_v1_keywords.py               |  30 +-
 synth.metadata                                     | 595 ++++++++++++++++++++-
 77 files changed, 905 insertions(+), 314 deletions(-)
 create mode 100644 compute-v1-py.tar.gz
2021-01-13 05:53:36,341 autosynth [DEBUG] > Running: git reset --hard HEAD
HEAD is now at e47f860 chore: release 0.1.0
2021-01-13 05:53:36,376 autosynth [DEBUG] > Running: git checkout autosynth
Switched to branch 'autosynth'
2021-01-13 05:53:36,407 autosynth [DEBUG] > Running: git diff HEAD..autosynth-0 -- . :(exclude)synth.metadata
2021-01-13 05:53:36,445 autosynth [DEBUG] > Running: git diff HEAD autosynth-0
2021-01-13 05:53:36,483 autosynth [DEBUG] > Running: git apply /tmpfs/tmp/tmp6psuicng/autosynth-0.patch
error: cannot apply binary patch to 'compute-v1-py.tar.gz' without full index line
error: compute-v1-py.tar.gz: patch does not apply
2021-01-13 05:53:36,500 autosynth [DEBUG] > Running: git clean -fdx
Removing .nox/
Removing __pycache__/
Traceback (most recent call last):
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 92, in synthesize_loop
    synthesize_inner_loop(fork, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 149, in synthesize_inner_loop
    toolbox.patch_merge_version(0, comment)
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 182, in patch_merge_version
    git.patch_merge(sub_branch, patch_file_path)
  File "/tmpfs/src/github/synthtool/autosynth/git.py", line 151, in patch_merge
    executor.check_call(["git", "apply", patch_file_path], cwd=git_repo_dir)
  File "/tmpfs/src/github/synthtool/autosynth/executor.py", line 29, in check_call
    subprocess.check_call(command, **args)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'apply', '/tmpfs/tmp/tmp6psuicng/autosynth-googleapis-discovery-0.patch']' returned non-zero exit status 1.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 354, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 189, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 334, in _inner_main
    commit_count = synthesize_loop(x, multiple_prs, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 100, in synthesize_loop
    synthesize_loop_single_pr(toolbox, change_pusher, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 126, in synthesize_loop_single_pr
    synthesize_inner_loop(toolbox, synthesizer)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 149, in synthesize_inner_loop
    toolbox.patch_merge_version(0, comment)
  File "/tmpfs/src/github/synthtool/autosynth/synth_toolbox.py", line 182, in patch_merge_version
    git.patch_merge(sub_branch, patch_file_path)
  File "/tmpfs/src/github/synthtool/autosynth/git.py", line 151, in patch_merge
    executor.check_call(["git", "apply", patch_file_path], cwd=git_repo_dir)
  File "/tmpfs/src/github/synthtool/autosynth/executor.py", line 29, in check_call
    subprocess.check_call(command, **args)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/subprocess.py", line 311, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'apply', '/tmpfs/tmp/tmp6psuicng/autosynth-0.patch']' returned non-zero exit status 1.

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:

Autosynth passed, closing! :green_heart:


Fix to prevent blank domain UUID

Description
This PR aims to fix the "blank domain UUID" situation, in which the user may provide an empty string as the UUID to the createDomain API. This situation can cause misleading actions in the UI (user trying to delete the wrong domain), and it also makes it impossible to remove the domain that has an empty UUID.
The createDomain API is not testing for empty strings or strings filled with whitespaces; therefore, it is allowing users to create a domain with an invalid UUID. Unless the UUID is manually changed in the DB, it is impossible to work with (or to delete) it.
The proposed solution is to generate a random valid UUID when the given one is a blank; thus,  preventing the reported problem.
Besides that, I decided to refactor a little bit the createDomain method, and added unit tests for its whole processing. Then, we are able to guarantee its workings.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[X] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

How Has This Been Tested?

New unit tests were created to test the behavior of the new methods and changed ones.
It was also tested in a local lab, by creating new domains with blank UUIDs (for example with whitespaces and empty strings) and checking if the created domains would have valid generated UUIDs.

btw @JoaoJandre would you want this in 4.16?

btw @JoaoJandre would you want this in 4.16?

If it goes to main its enough to me :)

@blueorangutan package

@GutoVeronezi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2133

@blueorangutan test

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian Build Failed (tid-2832)

@blueorangutan test

@sureshanaparti could we run the tests for this one?

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 2318

@blueorangutan package

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2322

@blueorangutan test

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Merging this one base in the approvals and test results.


Add ip6tables Package

As mentioned in issue #63, the ProtonVPN community client tries to use the ip6tables-save command and fails doing so.
Changes made in this PR add the ip6tables-package which provides said command.
As far as I can tell, this resolves the issue.
Thus, merging this PR will fix #63.

Thanks, btw, for your great work - I appreciate it! 😄


Unify development requirements

removes dev-requirements.txt in favor of extras_require in setup.py
adds testing and coverage extras
adds instruction to install pip-tools in development mode with test dependencies in CONTRIBUTING.md
updates tox.ini to use extras
unpins pytest dependency, since the fix has already released

FTR, pip==8.1.1 can't handle environment markers, that's why tox install pytest>=5 which is incompatible with python2.

Can we stop support python2 and pip==8.1.1? 😎

Should tox be added to the dev requirements?

Hello @georgek,

Should tox be added to the dev requirements?

I don't think so. The idea is to have one place for development requirements which can be used by tox or a user itself for a local development and testing pip install -e .[testing].

When I run tox -e checkqait fails because it can't find isort, flake8 or bandit. Are these missing dependencies that should be somewhere?

When I run tox -e checkqait fails because it can't find isort, flake8 or bandit. Are these missing dependencies that should be somewhere?

We use pre-commit now. All the dependencies are in .pre-commit-config.yaml. Could you run tox -re checkqa and show the output?

(pip-tools) gk@gk-pc ~/code/pip-tools (unify-dev-requirements) $ tox -re checkqa
checkqa recreate: /home/gk/code/pip-tools/.tox/checkqa
checkqa installdeps: pre-commit
checkqa installed: aspy.yaml==1.3.0,cfgv==2.0.1,identify==1.4.7,importlib-metadata==0.23,more-itertools==7.2.0,nodeenv==1.3.3,pip-tools==4.1.1.dev26+g49b7e95,pre-commit==1.18.3,PyYAML==5.1.2,six==1.12.0,toml==0.10.0,virtualenv==16.7.5,zipp==0.6.0
checkqa run-test-pre: PYTHONHASHSEED='1448334167'
checkqa run-test-pre: commands[0] | pip --version
pip 19.2.3 from /home/gk/code/pip-tools/.tox/checkqa/lib/python3.7/site-packages/pip (python 3.7)
checkqa run-test: commands[0] | pre-commit run --all-files --show-diff-on-failure
black....................................................................Passed
isort....................................................................Failed
hookid: isort

Traceback (most recent call last):
  File "/home/gk/.cache/pre-commit/repoz0nmzqaw/py_env-python3.7/bin/isort", line 6, in <module>
    from isort.main import main
ModuleNotFoundError: No module named 'isort'
Traceback (most recent call last):
  File "/home/gk/.cache/pre-commit/repoz0nmzqaw/py_env-python3.7/bin/isort", line 6, in <module>
    from isort.main import main
ModuleNotFoundError: No module named 'isort'

flake8...................................................................Failed
hookid: flake8

Traceback (most recent call last):
  File "/home/gk/.cache/pre-commit/repo9z9ih1f6/py_env-python3.7/bin/flake8", line 6, in <module>
    from flake8.main.cli import main
ModuleNotFoundError: No module named 'flake8'

bandit...................................................................Failed
hookid: bandit

Traceback (most recent call last):
  File "/home/gk/.cache/pre-commit/repow88fv026/py_env-python3.7/bin/bandit", line 6, in <module>
    from bandit.cli.main import main
ModuleNotFoundError: No module named 'bandit'
Traceback (most recent call last):
  File "/home/gk/.cache/pre-commit/repow88fv026/py_env-python3.7/bin/bandit", line 6, in <module>
    from bandit.cli.main import main
ModuleNotFoundError: No module named 'bandit'

ERROR: InvocationError for command /home/gk/code/pip-tools/.tox/checkqa/bin/pre-commit run --all-files --show-diff-on-failure (exited with code 1)
________________________________________________ summary _________________________________________________
ERROR:   checkqa: commands failed

@georgek probably pre-commit clean can help.

@georgek, could you file a separate issue so that we can discuss it there?

small aside, I've been looking at https://github.com/theacodes/nox lately, and am quite impressed with it as a replacement for invoke or stuffing extra non-test commands into tox.ini.

@jayvdb thanks for reviewing this and your approvement! Unfortunately, it's blocked by Python 2 and pip==8.1.1, so I've started the discussion about deprecation policy in #926.

@jayvdb I've added a factor specific setting to avoid installing pytest>5 on python2. A hack, but looks good to me.

That approach is ok.  The alternatives are messier.

Let's do it in 5.0.0, where we drop old pip versions.


[MAAS/LXD] Setting dns.mode=none does not prevent dnsmasq from binding to the associated network

Required information

Distribution: 22.04
Distribution version: 22.04.1
The output of "lxc info" or if that fails:

Kernel version: 5.15.0-48-generic
LXC version: 5.6
LXD version: 5.6
Storage backend in use: default

Issue description
When configuring LXD as a backend for maas configring dns.mode: "none" does not disable dnsmasq from trying to bind to the IP of a bridge network.
I have multiple L2 LXD Bridge networks created using LXC, and I want to disable dnsmasq from binding onto the .1 address of each network, and allow MAAS to manage DNS.
Sep 23 11:30:53 pjds-ubuntu dnsmasq[102633]: failed to create listening socket for <IP_ADDRESS>: Address already in use
Sep 23 11:30:53 pjds-ubuntu dnsmasq[102633]: FAILED to start up

Steps to reproduce

Install MAAS to latest stable
Install LXD to latest canddiate
Setup a bridge network and MAAS using the setup procedure from the MAAS site
Stop lxd
Stop MAAS
Start MAAS
Start LXD

Observe journalctl for the above log where network configuration fails to complete, due to DNS masq being unable to bind to .1
Information to attach

[x] Any relevant kernel output (dmesg) - Not Applicable
[x] Container log (lxc info NAME --show-log) - Not Applicable
[x] Container configuration (lxc config show NAME --expanded) - Not Applicable
[x] Main daemon log (at /var/log/lxd/lxd.log or /var/snap/lxd/common/lxd/logs/lxd.log)

https://paste.ubuntu.com/p/JNd7CD5hYC/

[x] Output of the client with --debug - Not Applicable
[x] Output of the daemon with --debug (alternatively output of lxc monitor while reproducing the issue) - Not Applicable

Workaround
Disable "Managed Allocation" and "Allow DNS resolution" in MAAS

LXD Network configuration:
config:
  dns.mode: none
  ipv4.address: <IP_ADDRESS>/24
  ipv4.dhcp: "false"
  ipv4.nat: "true"
  ipv6.address: fd42:9a92:4793:8c96::1/64
  ipv6.nat: "true"
description: ""
name: lxc-kvm
type: bridge
used_by:
- /1.0/instances/apt-mirror?project=infra
- /1.0/instances/bd-vm-test?project=infra
- /1.0/instances/calico-enterprise-test
- /1.0/instances/k8s-worker-0?project=ws-sandbox
- /1.0/instances/k8s-worker-2?project=ws-sandbox
- /1.0/instances/server-iso-builder
- /1.0/instances/test-6?project=ws-sandbox
- /1.0/instances/test-vm-0?project=ws-sandbox
- /1.0/instances/test?project=ws-sandbox
managed: true
status: Created
locations:
- none

dns.mode as mentioned in documentation controls the DNS registration mode.
none means that no record will be created for the instances in the network's DNS zone, not that the dns server went operate.
Any managed network run by LXD that has configured IPv4 or IPv6 on it will offer recursive DNS resolution.
If you don't want this, you can run the network without any IPv4 or IPv6 subnet, or run your own bridge outside of LXD or not use a bridge at all and instead rely on macvlan, sriov or routed networking.


added PHP version check, fixed #19925

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Fixed issues
#19925

fixes Docker build https://github.com/yiisoft/yii2-docker/pull/168
builds here are also green

@schmunk42 would you please add a line for CHANGELOG? Thanks.

Changelog added, conflicts resolved.
Would be cool if this could get merged since it's blocking Docker builds.

👍🏻


Add QT4CG 4.0 working group to https://github.com/StanimirIglev/awesome-xml?tab=readme-ov-file#drafts-and-community-advances

There is ongoing work on XPath 4, XQuery 4 and XSLT 4, see https://qt4cg.org/ and https://www.w3.org/community/xslt-40/. I think this should be added to https://github.com/StanimirIglev/awesome-xml?tab=readme-ov-file#drafts-and-community-advances.

That is an excellent suggestion. I will make sure to add it as soon as possible.


Support for the built in digital filter

The MPU9150 has a built-in digital filter which reduces the effect of vibration on the accelerometer and gyro readings. I have a patch which enables this to be configured and can submit a PR if this is of interest.

That would be awesome!

PR heading your way ;-)


More bugs with getValues

https://playground.solidjs.com/anonymous/02fc8d25-3447-49b5-b245-8059618a1194
Should show ```{x: "hello"}````

Highlighting more problems
https://playground.solidjs.com/anonymous/6cb3e2a0-7eea-402a-9a7b-baf6d84d4b49
This is smallest reproducible examples I can do, but make no mistake this perpetuates across everything to bigger issues

Thanks for the info.

The problem behind this bug is that a field must first be initialized by using the Field component or some other field specific method like getValue, since getValues can only return the values of initialized fields. Unlike Modular Forms for Qwik, Solid, Preact and React currently initialize fields lazy.


Replace "==" and equals by 'Objects.equals()' expression

We have shared with @arturobernalg in the dev mailing list that we are understaffed to deal with the cosmetic changes he has proposed so far, hence closing the ticket.


https option added to dev-server

I have a angular 16 application and I am using https for local development but after upgrading this application for angular 17 and native-federation 17 the parameters ssl, ssl-cert, and ssl-key stopped to work.
I looked at the source code and saw that native-federation is using browser-sync for dev-server and that it has an option to enable running with https, so I added it as an option for dev-server.

#422


Remove legacy cross compilation stuff

Issue description
A goal of mine for 18.09 is to get rid of some legacy cross compilation stuff. We can now use "crossSystem" to accomplish the same thing.

[x] pkgs/development/compilers/arm-frc-linux-gnueabi-gcc
[ ] pkgs/development/misc/avr/
[ ] pkgs/development/compiler/gcc-arm-embedded/
[ ] pkgs/development/compilers/mentor/

We want to make sure we have easy alternatives for the above. This might include providing aliases if they are needed. Also we might want to have Hydra build toolchains for AVR and ARM embedded.

I added another entry: pkgs/development/compilers/mentor/. (Currently holds two old ARM toolchains.)


The hand thing 👌

That hang thing, 👌, has become symbol of white supremacy. Which makes it a little weird that it's used all over this repo.

Oh... I didn't know about that, I'm sorry! I did not expect it to be insulting, so I apologize if it made you uncomfortable. The original idea was to show that this package is super small:

I'm going to change the emoji in the description to something else, the illustration however might take a while to fix since it wasn't me who drew that. I'll see what we can do!

Oh... I didn't know about that, I'm sorry! I did not expect it to be insulting, so I apologize if it made you uncomfortable. The original idea was to show that this package is super small:

I'm going to change the emoji in the description to something else, the illustration however might take a while to fix since it wasn't me who drew that. I'll see what we can do!

It doesn't offend me. I just thought I'd give you a heads up. The illustration is probably fine. But might be good to drop the emoji.
Im excited to try this library. I hope I didn't worry you too much.

It doesn't offend me. I just thought I'd give you a heads up. The illustration is probably fine. But might be good to drop the emoji.
Im excited to try this library. I hope I didn't worry you too much.

Then why even bother making this ticket? This is called the bigotry of low expectations.
Really... all that palava is just bored narcissistic and toxic people making up stuff to see how much compliance they can extract from people around them.
Lets not create a world of eggshells please.

This issue prompted me to check the various positive and negative connotations (I was mostly familiar with the "okay" sign used in scuba diving):
https://en.m.wikipedia.org/wiki/OK_gesture
Interesting historical background.


[Server] - Allow to remove archived articles in bookmark list

Report is here.

PR https://github.com/thematters/matters-server/pull/2461


Fix typo in doc for GetMousePos

Just fixing a typo in the doc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


musicbot needs fork or 0.4.1 to play youtube again

due to youtube's changes the ios/mobile player version the bot uses no longer works. the WEB style playback works, and lavalink-devs are working on fixing that. i believe the fix is in a new distribution so jmusicbot maintainers need to change to that dependency. there is a post about it here https://github.com/jagrosh/MusicBot/pull/1552
either the fork listed there, or 0.4.1 when it releases will fix the bot playing youtube again. hope that helps!

version updated to 0.4.1 so this should be solved


Fix: Argo CLI should show warning if there is no workflow definition in file #1486

This PR will resolve #1486

@sarabala1979
I had been successfully using the Argo Quickstart manifest and am now trying to install the secure manifest, but am getting
this error when trying to run "argo submit..." (The workflows have worked with the QuickStart manifest.) According to posts by @inc0 this may suggest that I have a resource issue, however, I cannot find the source of the issue. I am testing with the Hello World example workflow. What is Argo looking for as an indicator that there is a workflow?  Is there a test I can run to find the source of the error?
Thank you!


Add a method to create a matrix of vector from a Vec.

For dynamically-sized matrices and vectors, this would be much more efficient than the current solutions (::from_row_slice and ::from_column_slice) which copy the content of a slice. See the suggestion on the 5th point of this post.

Note that the current way of doing this is quite complicated: DMatrix::from_data(MatrixVec::new(Dynamic::new(nrows), Dynamic::new(ncols), vec)) where nrows, ncols, vec are the dimension of the matrix and the Vec.

Oh good to know there is a way to do it! I never looked into MatrixVec internals yet.

Fixed by #464.


chore(electric): Rewrite the splitting algorithm in Proxy.Injector to be more concise

This is a follow-up to https://github.com/electric-sql/electric/pull/587#discussion_r1368945549.

@magnetised The list of commits here is changing due to ongoing rebases. All I wanted you to take a look at is the last commit -- that's the only one that's new.


redact audit log details by key

fix https://github.com/kyma-incubator/reconciler/issues/1056

/retest


Cargo Run workflow no longer usable

Bug Report
What version of TiKV are you using?
master
What operating system and CPU are you using?
Any
What did you do?
As is convention in the Rust ecosystem, as I have for the last year and a half, I ran cargo run --bin tikv-server to start a TiKV development build of the server.
The command reported:
error: no bin target named `tikv-server`

The README.md does not describe how to workaround this problem.
The target machine does not have access to a copy of make that can support the complex Makefile.
What did you expect to see?
TiKV, as a rust project, to build and operate like a Rust project.
TiKV, as a repository of tikv project, should follow the conventions of our other rust projects and support a clean cargo run behavior.
What did you see instead?
error: no bin target named `tikv-server`

What action should be taken?
I suggest reverting https://github.com/tikv/tikv/pull/5242 or adding documentation to all of our README files, as well as our /Cargo.toml documenting this.
I would prefer reverting https://github.com/tikv/tikv/pull/5242. I think this has very poor usability for folks trying out contributing or developing TiKV for their first time.

What do you think, @overvenus ?

@nrc suggested:

we might be able to use default-bin to make just cargo run work

I prefer adding documentation.
The actual workflow of TiKV is based on Makefile. Eg. cargo test does not test crates under components. So we should use make run instead of cargo run.
The point of #5242 is to prevent cyclin-dependent when we add a new crate (depends on the tikv) into tikv-server.

@overvenus I'm not sure breaking this workflow is worth it. :(

I hope we can get the benefits of both sides - it is nice to move out the cmd crate because the dependencies in the TiKV workspace are a bit of a nightmare (for the Prost work I must move out the tests into their own crate too). OTOH, it is really good for new contributors if the Cargo workflows work (even if they are not doing the optimal things). Using Cargo is very standard in the Rust community.

This also impacts cargo tooling like cargo metadata, cargo tree, ...

@overvenus Can I propose I write a new checker for you some other way and we include it as a make task?

This may also impact our Dockerfiles https://github.com/tikv/tikv/blob/6a516eea06906a96efd0223245ac90531faa4dec/scripts/gen-dockerfile.sh#L58

Sorry for breaking gen-dockerfile.sh, will be fixed today.
I really need the cmd crate, because I will soon add new a component, which depends on tikv, into tikv-server.

@overvenus OK. Can we still support cargo run --bin tikv-server somehow.
Do you think we could add a proxy binary there that just invokes cmd::tikv_server? This might also make it possible to move cmd into the components/ directory.

Can we still support cargo run --bin tikv-server somehow?

I don't have a clear plan to support this, could you help me?

This might also make it possible to move cmd into the components/ directory.

Putting cmd out of components is suggested by @siddontang https://github.com/tikv/tikv/pull/5242#issuecomment-519821991

Hm, I hear from @siddontang that tikv-ctl may merge with tikv-server...
Can you please explain to me exactly what is preventing us from having /src/bin/tikv-server.rs instead?
You say you're adding a new crate that depends on TIKV? Maybe we should be separating tikv-server into a separate project/repo?

Hm, I hear from @siddontang that tikv-ctl may merge with tikv-server...

Not now, but in the near future @Hoverbear see #4908

I also agree that cargo run should just work.
If the problem is that tikv-server/ctl is going to depend on a library that itself depends on tikv, then we can make tikv another 'component' and make the top-level manifest just hold the bins.

Also we might use the new (?) default-run key to make tikv-server run without picking an explicit bin

Also the default-members key might help us here. It specifies the "main" package".
Since tikv is so huge now it probably would make sense to turn the main manifest into a pure workspace, and put everything into a sub-component, then use default-members and maybe default-run.

Related to https://github.com/tikv/tikv/pull/5374

@brson's suggestions sound sensible to me.

Let me have a try!


WebSocket server doesn't properly handle protocol mistakes.

Unfortunately, I don't know how exactly to reproduce this error.
The problem is that when I ran a local WebSocket server it was closing all incoming connections and printing the next stack trace:
scala.MatchError: 7 (of class java.lang.Integer)
    at org.http4s.websocket.package$.makeFrame(package.scala:26)
    at org.http4s.websocket.FrameTranscoder.bufferToFrame(FrameTranscoder.scala:165)
    at org.http4s.server.blaze.WebSocketDecoder.bufferToMessage(WebSocketDecoder.scala:30)
    at org.http4s.blaze.pipeline.stages.ByteToObjectStage.$anonfun$readAndDecodeLoop$1(ByteToObjectStage.scala:85)
    at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:60)
    at org.http4s.blaze.util.Execution$ThreadLocalTrampoline.run(Execution.scala:108)
    at org.http4s.blaze.util.Execution$ThreadLocalTrampoline.execute(Execution.scala:94)
    at org.http4s.blaze.util.Execution$$anon$2.execute(Execution.scala:53)
    at scala.concurrent.impl.CallbackRunnable.executeWithValue(Promise.scala:68)
    at scala.concurrent.impl.Promise$DefaultPromise.dispatchOrAddCallback(Promise.scala:312)
    at scala.concurrent.impl.Promise$DefaultPromise.onComplete(Promise.scala:303)
    at org.http4s.blaze.pipeline.stages.ByteToObjectStage.readAndDecodeLoop(ByteToObjectStage.scala:99)
    at org.http4s.blaze.pipeline.stages.ByteToObjectStage.startReadDecode(ByteToObjectStage.scala:72)
    at org.http4s.blaze.pipeline.stages.ByteToObjectStage.readRequest(ByteToObjectStage.scala:68)
    at org.http4s.blaze.pipeline.stages.ByteToObjectStage.readRequest$(ByteToObjectStage.scala:56)
    at org.http4s.server.blaze.WebSocketDecoder.readRequest(WebSocketDecoder.scala:8)
    at org.http4s.blaze.pipeline.Tail.channelRead(Stages.scala:88)
    at org.http4s.blaze.pipeline.Tail.channelRead$(Stages.scala:85)
    at org.http4s.server.blaze.WSFrameAggregator.channelRead(WSFrameAggregator.scala:16)
    at org.http4s.server.blaze.WSFrameAggregator.readRequest(WSFrameAggregator.scala:24)
    at org.http4s.blaze.pipeline.Tail.channelRead(Stages.scala:88)
    at org.http4s.blaze.pipeline.Tail.channelRead$(Stages.scala:85)
    at org.http4s.blazecore.websocket.Http4sWSStage.channelRead(Http4sWSStage.scala:18)
    at org.http4s.blazecore.websocket.Http4sWSStage.$anonfun$readFrameTrampoline$1(Http4sWSStage.scala:54)
    at org.http4s.blazecore.websocket.Http4sWSStage.$anonfun$readFrameTrampoline$1$adapted(Http4sWSStage.scala:53)
    at monix.eval.internal.TaskCreate$.$anonfun$async$1(TaskCreate.scala:124)
    at monix.eval.internal.TaskCreate$.$anonfun$async$1$adapted(TaskCreate.scala:121)
    at monix.eval.internal.TaskRestartCallback.start(TaskRestartCallback.scala:58)
    at monix.eval.internal.TaskRunLoop$.executeAsyncTask(TaskRunLoop.scala:564)
    at monix.eval.internal.TaskRunLoop$.startFull(TaskRunLoop.scala:115)
    at monix.eval.internal.TaskRunLoop$.$anonfun$restartAsync$1(TaskRunLoop.scala:192)
    at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402)
    at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
    at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
    at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
    at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

Seems that it doesn't properly handle deviations from the protocol and throws an error in case if a received opcode doesn't match to the expected valid set of opcodes.
I've checked the WebSockets RFC and it says that a server must close a connection and return 400 in case of an handshake error - https://tools.ietf.org/html/rfc6455#section-4.2.1
Also, it says that opcodes from 3 to 7 are reserved for the future usage and I didn't find information on how they should be handled exactly. However, there is a sentence: If an unknown       opcode is received, the receiving endpoint MUST _Fail the       WebSocket Connection_., though not sure if it's applicable to them - https://tools.ietf.org/html/rfc6455#section-5.2
Probably at least server could handle such opcodes and print something less scary and more understandable for users.

The problem was solved when I chose a different HTTP port, so it might be just something with my local machine; however, this issue is about inconvenient handling of protocol deviations.

I'm not a web socket expert, but I think we should do the following:

When we get one of these frames, send a close with code 1003.
When we get other ProtocolExceptions, send a close with code 1002.
This might be something we can do in a recoverWith in Http4sWSStage#handleRead.

Any volunteers?


Particles story improvement

As there are no links visible on particles story I think adding a new variable of linkColor would make it just fine.
Before:

After:

@matteobruni hey, can you check on this, please?

This is a good improvement, thanks


Capability SYS_ADMIN is published as removed in changelog, but is still in factory method

Describe the bug
Capability SYS_ADMIN is published as removed in changelog, but is still in factory method.  If the privilege is not necessary, remove this from the factory methods that create the daemonsets.
Environment
Daemonsets are using the SYS_ADMIN capability, but according the CHANGELOG, this was removed.

Trident version: v23.07.1

To Reproduce
Daemonsets are produced today with pods that require SYS_ADMIN privileges, which is too broad.
Expected behavior
Pods from the daemonset will not require SYS_ADMIN privileges.
Additional context
Add any other context about the problem here.

Hi @mmerrill3 as part of trident release 23.07 SYS_ADMIN capability was added back. Under changelog -> 23.07 -> Enhancements
Kubernetes: Minimized deployment and daemonset linux permissions (Issue https://github.com/NetApp/trident/issues/817).
As part of the above issue mentioned, SYS_ADMIN capability was added.


Instructions on how to register 3rd party plugin

What problem does this feature solve?
Currently there is a pretty neat doc on how to write plugins (https://github.com/vuejs/vue-cli/blob/dev/docs/plugin-dev.md)  but i can;t see anywhere instructions how and where I should register it after creating. Is there a possibility of adding it to the docs? It is also possible that I missed it somewhere - then please share a link.
Thanks in advance
What does the proposed API look like?
Which file should contain the plugin registration and how to register it.

Install the plugin into the project you wish to use it and call it with vue cli.
cd your/project/dir
npm install --save-dev vue-cli-plugin-someplugin
vue invoke someplugin

Docs are here, btw:
https://github.com/vuejs/vue-cli/blob/dev/docs/cli.md#installing-plugins-in-an-existing-project

@LinusBorg definietely ;) Andmore straightforward instructions on plugin installation process would be great

Was vue add replaced by vue invoke? The installing plugins in an existing project documentation uses vue add, but the commands listing at the top of the CLI documentation only lists vue invoke.

Those are different commands. add installs a plugin and then calls invoke for it.
We appearantly forgot to add it to the list.

So if I'd like to test my own custom plugin, I'd install it with npm from a local path and then only invoke, skipping the npm install part of add, right?

Exactly

I think what the CLI is currently really lacking is the ability to register global plugins that can be used during generation.  I don't see a good reason why that shouldn't be possible

@light24bulbs you already created a separate issue for your request, please don't clutter other issues with it.

I find the docs are lacking this info too, had too google it and find it here. One short section reflecting what has been said here would be awesome.

Closing as this is addressed in the refactored docs.


Why was the lastest update three years ago?

Was this library abandoned?

@cccabot - do you want to answer this one or should I?

Because the code is flawless?

Yes, libem is no longer actively maintained.  The research group that authored it has scattered to the four winds.

wait if i live in the east does that make me the east wind or the west wind?
On Fri, May 1, 2020 at 7:44 PM Mark Raugas<EMAIL_ADDRESS>wrote:

Yes, libem is no longer actively maintained. The research group that
authored it has scattered to the four winds.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CyberPoint/libpgm/issues/30#issuecomment-622612971,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBB4EG4J3LPNSOL6BI2ZE3RPNNGXANCNFSM4I657HGA
.

You are the eye of the storm.
Best,
Mark
On Fri, May 1, 2020 at 4:59 PM JamesLUlrich<EMAIL_ADDRESS>wrote:

wait if i live in the east does that make me the east wind or the west
wind?
On Fri, May 1, 2020 at 7:44 PM Mark Raugas<EMAIL_ADDRESS>wrote:

Yes, libem is no longer actively maintained. The research group that
authored it has scattered to the four winds.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CyberPoint/libpgm/issues/30#issuecomment-622612971,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABBB4EG4J3LPNSOL6BI2ZE3RPNNGXANCNFSM4I657HGA
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CyberPoint/libpgm/issues/30#issuecomment-622615596,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBCYEK2V4KNUS54GJK5IULRPNO6HANCNFSM4I657HGA
.

I don't have privileges otherwise I would update the project description to say that this repository is no longer maintained.

You are the eye of the storm.

Eye of the tiger.


add angular2-meteor tutorial trello link

This trello does not allow people to comment now.
If can give people access to comment, that will be great.

thanks, I would prefer to track those as Github milestones..  I will update the milestones tomorrow


chore(deps): update madsim-aws-s3-sdk

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Close https://github.com/risingwavelabs/risingwave/issues/10494#issuecomment-1617424615

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR contains user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

I currently encounter this error after compiling it:
error[E0507]: cannot move out of `part.body` which is behind a shared reference
   --> /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-aws-sdk-s3-0.2.24+0.28/src/server/service.rs:330:45
    |
330 | ...                   body.extend(part.body);
    |                                   ^^^^^^^^^ move occurs because `part.body` has type `bytes::Bytes`, which does not implement the `Copy` trait

error[E0507]: cannot move out of `part.body` which is behind a shared reference
   --> /Users/noelkwan/.cargo/registry/src/index.crates.io-6f17d22bba15001f/madsim-aws-sdk-s3-0.2.24+0.28/src/server/service.rs:334:41
    |
334 | ...                   body.extend(part.body);
    |                                   ^^^^^^^^^ move occurs because `part.body` has type `bytes::Bytes`, which does not implement the `Copy` trait

This seems weird to me because the madsim repository shows the build completes just fine. Any ideas? @wangrunji0408

Seems like it is outdated code being compiled for some reason.. it should be:
                                body.extend(&part.body);
                                break;
                            }
                        } else {
                            body.extend(&part.body);
                            break;

in the latest version.

Sorry, I published a buggy version. 🥵
You can run cargo update -p madsim-aws-sdk-s3 again and update it to v0.2.25+0.28 to fix this.


Update tree.js

Coverage increased (+0.04%) to 26.338% when pulling 4ddab4343ece3b34d3080943f6340fe098602d15 on lixiufei:master into fba6ab7cd21a3532282f39f5b6d1c08b917097ce on sentsin:master.


split events into spearate package

motivation: the runtime library has a stabel API while the events are still moving target, so in order to provide a 1.0 stable version we should separate them out
changes:

remove Events module
update readme
update Samples

cc @bmoffatt @kneekey23

Looks good to me. However we should have an "integration" test target in AWSLambdaEvents that ensures that the examples in the runtime still compile after a change in events.

@fabianfett you mean in the new repo?

@fabianfett you mean in the new "events" repo, so that changes there dont break the runtime? could they?

The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI.

The changes in there can't break the runtime, but the samples in the runtime repository, which would block CI.

it may ben easier (from a CI point of view) to add Examples there as well. WDYT?

https://github.com/swift-server/swift-aws-lambda-events/pull/1

@tomerd Awesome! Now we should remove the APIGateway example from the code here. And maybe add to the soundness script that we never import AWSLambdaEvents except in markdown files :)

tomerd Awesome! Now we should remove the APIGateway example from the code here. All other examples don't depend on AWSLambdaEvents. Maybe we should add to the soundness script that we never import AWSLambdaEvents except in markdown files :)

done

Failing nightly-main CI because of known issue in SwiftNIO: https://github.com/apple/swift-nio/pull/1943 Not a blocker! Merging!


How to get notes associated with a journal entry?

I'm trying to access the note entries that are associated with journal entries. But I'm having a hard time locating that. The dict returned by api.items() does not seem to contain note entries (tags do exist). I have tried the following code:
myapi.everything(myapi.items(itemType='Note'))

But this returns an empty list while I have multiple notes associated with journalArticle types. My private key has "Allow note access" turned on.
I'm on version 1.4.22, macOS Big Sur, and Python 3.8. Any help is appreciated!

Note is an item type, and in your case it will be a child (or children) of a top-level journalArticle item. One way to do it would be to retrieve all top-level items first, and then call .children(itemType="Note") on each item that has a child count (and any other criteria you want to restrict by).

Gotcha, works now. Thanks!


Data races reported by TSAN

Bug description
Running any of the examples on the nightly compiler with thread-sanitizer enabled reports several data races.
RUSTFLAGS='-Zsanitizer=thread' cargo run -Zbuild-std --target x86_64-unknown-linux-gnu --bin clock

Output
Printed when running the clock example (external link because it's so long)
Additional context
I am using GTK 4.6 on Ubuntu 22.04 in WSL2 on Windows 11.
But I don't expect this to be limited to WSL or virtualization in general.

I suspect you will see similar things if you do the same thing with a gtk C example using clang.
git clone https://gitlab.gnome.org/GNOME/gtk.git
cd gtk
CC=clang meson setup build -Db_sanitize=thread -Db_lundef=false

And then try to run something from the build/examples folder. For me on Linux it looks like a lot of the same errors. The majority look like gdbus so probably these should be reported upstream to glib. One of them appears to be in pango or fontconfig though.

Reported one of them at least: https://gitlab.gnome.org/GNOME/glib/-/issues/2920

Thanks for pointing me in the right direction. https://gitlab.gnome.org/GNOME/glib/-/issues/1672 looks like the tracking ticket for these data races.

Closing for now, let's report against that ticket


bolt.Open with options hangs

Hi,
I'm trying to use the store inside a linux VM (Vagrant with NFS).
The bolt.Open hangs indefinitely even if I supply a timeout.
db, err := bolt.Open("store.db", 0600, &bolt.Options{
    Timeout: 1 * time.Second,
})
if err != nil {
    log.Fatal(err)
    return
}
defer db.Close()

I've looked at the code and the problem seems to be with:
err := syscall.Flock(int(db.file.Fd()), flag|syscall.LOCK_NB)
Inside "boltdb/bolt/bolt_unix.go" in the "flock" function.
Any ideas on how to correct this?
Thanks,
Alex

@alexdeefuse A couple questions:

Do you have another process that is also opening store.db?
Does it work on the local VM file system (aka not across NFS)?
Does it work outside the VM on your local system?

It does seem strange that the timeout is not triggering.

Hi,
Thanks for your reply. Very brief answers:

No other process that I'm aware of
No it doesn't
Didn't try that

A few more details about the scenario where I've noticed this:
I have my host environment (the actual machine) that doesn't have Go installed at all. It's a bare linux machine with Virtual Box and Vagrant and it uses NFS to share the Go folders with the guest machine.
The guest machine has a Go development environment.
The database file (store.db) is created inside the VM environment by a very basic go app. The database file is stored in a path that is under NFS.
I will try to store the db file in a non-NFS path and get back to you.
Best,
Alex

I can confirm that placing the database file outside of NFS has fixed the issue.


Apply the active file language as part of the system context when doing an Ask Anything prompt

Describe the feature
It would be helpful to include the current file language as part of the system context when doing an Ask Anything prompt. I often want to ask a language specific question about the code I'm working on, but not related to the code in the file. Having to highlight some code just to get the language context included is a burden and a waste of tokens.

context would be added automatically if you select the contents of the file


Forum links broken by forum migration, but tool exists

As you'll see at http://forum.kerbalspaceprogram.com/index.php?/topic/126583-welcome-to-the-new-forums/ all existing forum links have broken (sigh) but there is a tool to find the new thread given the old thread's URL. I suggest a bulk conversion of all homepage links in CKAN metadata which are old-forum links into links of the form http://forum.kerbalspaceprogram.com/showthread.php?t=nnnnnn would save a lot of hassle down the line.

Thanks for the tip. WIll come usefull in KSP-CKAN/CKAN/issues/1527

I hadn't seen that. If you want to close this and put the salient fact in #1527, be my guest.

Done


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.9 to before v5.10.101",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=ac3a68d56651c3dad2c12c7afce065fe15267f44",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=8ccebe77df6e0d88c72ba5e69cf1835927e53b6c"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "ac3a68d56651c3dad2c12c7afce065fe15267f44",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "8ccebe77df6e0d88c72ba5e69cf1835927e53b6c",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "net: dsa: mv88e6xxx: don't use devres for mdiobus\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.10.101 by commit 8ccebe77df6e0d88c72ba5e69cf1835927e53b6c, it was introduced in version v5.9 by commit ac3a68d56651c3dad2c12c7afce065fe15267f44. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000368


XataApiClient docs section is outdated

Describe the bug
The XataApiClient doc, specifically the code samples section, is outdated.
For example, the api.database.createDatabase  method accepts an object argument
({ workspace, database, data }: {
    workspace: string;
    database: string;
    data: CreateDatabaseRequestBody;
}

instead of three options as shown in the docs page:
  workspace,
  'database',
  { region: 'eu-west-1' }

The section should be refactored with up-to-date code samples for the relevant methods .

A docs update for the XataApiClient snippets has been pushed.


Unit tests for sw-broadcast-cache-update

R: @addyosmani @gauntface
End to end tests will follow.

PTAL, @gauntface.


Adding rust

This adds support for packaging Rust executables, and examples in Rust.

@brendandburns let us know if there is anything else needed for this PR (it's starting to collect dust)

Sorry, I was hoping for someone with good Rust knowledge to review, but I will just merge as-is and we will go from there...


Android better font size

Adjusted the TextInput height to maintain the same font size on both platforms.

@asessa Published in version 0.1.4
Thanks of helping.


Add my name in contributors.md

Done !

This file has been removed in earlier PRs and you can add your name here https://github.com/HacktoberfestinAba/HacktoberfestinAba.github.io/blob/master/CONTRIBUTING.md
You can pull the repo to sync the updates and send in a new PR


Auto registering relations makes migrations impossible?

Describe the bug
I feel like this is a bug, to run the rake db:migrate rake task, you need to setup a ROM container, but this automatically registers all your relations. An error is thrown telling me that a relation does not exist for a migration I have created, but now cannot run. This can be overcome by migrating the db first, then creating the relation and all related logic, but that seems like extra overheard, in the real world I don't want to deploy a migration to production, then do another deploy with my logic, I should be able to do it all in one go. It feels a bit backwards to me.
To Reproduce

run rake db:create_migration[create_users]
Create relation class and repository class if required. Implement logic for new table.
Attempt to run migration via rake db:migrate
PG::UndefinedTable: ERROR:  relation "users" does not exist error thrown as it attempts to register the :users relation before running the migration.

Expected behavior
After step 3 above, the container should recognise there is a pending migration and run it before attempting to register any relations.
I guess the main issue seems to be that ROM doesn't have any idea of which migrations have run? After deleting the relation classes associated to the new migration it still complained to me about a duplicate table, because it was trying to execute a previous migration that had already run? That doesn't seem right at all.
Your environment

Affects my production application: YES
Ruby version: 2.6.1
OS: Mac OS 10.14 (Mojave)

This is happening in a simple Sinatra application where we are also using dry-system to load everything.

This is not a bug. For scripts/tasks that run migrations, you simply don't finalize container. You only need the db connection. Since you're using dry-system, you can put initial rom setup in an init step, and use that in db:setup task.
We should probably document this in user docs.

Ok we're doing exactly that with dry-system so you led me down the right path. I was booting the entire system in my Rakefile instead of just requiring the init file for db:setup`. Silly mistake I suppose, but agree it would be good to have in the docs. I'll see if I can get a PR up for that on the other repo.


Navigate overlay dropdowns via arrow keys

Is your feature request related to a problem? Please describe.
Any overlay dropdown component is accessible via TAB & SHIFT + TAB to navigate through the options via keyboard.

That might not be intuitive enough, since any kind of dropdowns and select shall be navigatable via arrow keys as well. That's currently not possible.
Describe the solution you'd like
Make navigation via arrow keys possible.
Describe alternatives you've considered
/
Additional context
This is a follow up of https://github.com/camunda/camunda-modeler/pull/2616.

I sketched how this could be possible given the existing option group structures we have in place with this commit.
function Options(props) {
  const { items, onSelect } = props;

  const focusRef = useArrowNavigation();

  return (
    <Section.Body>
      <ul ref={ focusRef }>
        // ...
      </ul>
    </Section.Body>
  );
}

function useArrowNavigation() {
  const ref = React.createRef(0);

  const handleKeydown = (event) => {
    const {
      key,
      keyCode,
      currentTarget
    } = event;

    if (key === 'ArrowDown' && keyCode == 40) {
      focusNext(currentTarget);
    } else if (key === 'ArrowUp' && keyCode == 38) {
      focusPrevious(currentTarget);
    }
  };

  React.useEffect(() => {
    if (!ref.current) {
      return;
    }

    const items = ref.current.querySelectorAll('li');

    items.forEach(i => i.addEventListener('keydown', handleKeydown));

    return () => {
      items.forEach(i => i.removeEventListener('keydown', handleKeydown));
    };

  }, [ ref.current ]);

  return ref;
}

/**
 *
 * @param {Node} focusElement
 */
function focusNext(focusElement) {
  const nextSibling = focusElement.nextSibling;

  // (1) focus immediate neighbor
  if (nextSibling) {
    return nextSibling.querySelector('button').focus();
  }

  // (2) try to find neighbor in other section
  const nextSection = focusElement.closest('section').nextElementSibling;
  return nextSection && nextSection.querySelector('li button').focus();
}

/**
 *
 * @param {Node} focusElement
 */
function focusPrevious(focusElement) {
  const previousSibling = focusElement.previousSibling;

  // (1) focus immediate neighbor
  if (previousSibling) {
    return previousSibling.querySelector('button').focus();
  }

  // (2) try to find neighbor in other section
  const previousSection = focusElement.closest('section').previousElementSibling;
  return previousSection && previousSection.querySelector('li:last-child button').focus();
}

branch: https://github.com/camunda/camunda-modeler/tree/navigate-with-arrow-keys

Regarding the possible keyboard interaction improvements, we could take into consideration the WAI-ARIA recommendations for the menu component: https://www.w3.org/TR/wai-aria-practices/#keyboard-interaction-12

Originally posted: https://github.com/camunda/camunda-modeler/pull/2616#issuecomment-990747710


fix: setAndForwardRef

The function setAndForwardRef has been removed from React-Native .72 (see https://github.com/facebook/react-native/commit/bf6ed07c0f01f788e6554ad63c958feec3d2eb0c). This PR adds the method to the react-native-checkbox repository.
Tested on React-Native-Gallery, should also be tested on IOS/Android

@TatianaKapos Thanks, I will check it ASAP

any updates on this PR ?

@nicholaslee119 Any update on this PR please?
react-native 0.72.0 stable version is now out and this issue is blocking production build step

can u push it?

Thanks, 0.5.16 was released

Thank you


InvalidCastException in WebApiToSwaggerGenerator.GetSupportedHttpMethodsFromAttributes

Using nswag run nswag.json /runtime:NetCore20, I get an InvalidCastException thrown from the WebApiToSwaggerGenerator class:
System.InvalidCastException: Unable to cast object of type
'SelectArrayIterator`2[System.String,System.String]' to type
'System.Collections.ICollection'.
   at CallSite.Target(Closure , CallSite , Object )
   at System.Dynamic.UpdateDelegates.UpdateAndExecute1[T0,TRet](CallSite site, T0 arg0)
   at NSwag.SwaggerGeneration.WebApi.WebApiToSwaggerGenerator.<GetSupportedHttpMethodsFromAttributes>d__24.MoveNext() in C:\projects\nswag\src\NSwag.SwaggerGeneration.WebApi\WebApiToSwaggerGenerator.cs:line 482
   at System.Collections.Generic.LargeArrayBuilder`1.AddRange(IEnumerable`1 items)
   at System.Collections.Generic.EnumerableHelpers.ToArray[T](IEnumerable`1 source)
   at NSwag.SwaggerGeneration.WebApi.WebApiToSwaggerGenerator.<GetSupportedHttpMethods>d__23.MoveNext() in C:\projects\nswag\src\NSwag.SwaggerGeneration.WebApi\WebApiToSwaggerGenerator.cs:line 429
   at System.Collections.Generic.List`1.AddEnumerable(IEnumerable`1 enumerable)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at NSwag.SwaggerGeneration.WebApi.WebApiToSwaggerGenerator.<GenerateForControllerAsync>d__11.MoveNext() in C:\projects\nswag\src\NSwag.SwaggerGeneration.WebApi\WebApiToSwaggerGenerator.cs:line 143
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.SwaggerGeneration.WebApi.WebApiToSwaggerGenerator.<GenerateForControllersAsync>d__9.MoveNext() in C:\projects\nswag\src\NSwag.SwaggerGeneration.WebApi\WebApiToSwaggerGenerator.cs:line 95
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.Commands.SwaggerGeneration.WebApiToSwaggerCommand.<RunIsolatedAsync>d__91.MoveNext() in C:\projects\nswag\src\NSwag.Commands\Commands\SwaggerGeneration\WebApiToSwaggerCommand.cs:line 198
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.Commands.IsolatedCommandBase`1.IsolatedCommandAssemblyLoader`1.Run(String commandType, String commandData, String[] assemblyPaths, String[] referencePaths) in C:\projects\nswag\src\NSwag.Commands\Commands\IsolatedCommandBase.cs:
line 60
   at NSwag.Commands.IsolatedCommandBase`1.<>c__DisplayClass13_0.<RunIsolatedAsync>b__0() in C:\projects\nswag\src\NSwag.Commands\Commands\IsolatedCommandBase.cs:line 50
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.Commands.IsolatedCommandBase`1.<RunIsolatedAsync>d__13.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.Commands.IsolatedSwaggerOutputCommandBase.<RunAsync>d__4.MoveNext() in C:\projects\nswag\src\NSwag.Commands\Commands\IsolatedSwaggerOutputCommandBase.cs:line 24
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.Commands.NSwagDocumentBase.<GenerateSwaggerDocumentAsync>d__40.MoveNext() in C:\projects\nswag\src\NSwag.Commands\NSwagDocumentBase.cs:line 268
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.Commands.NSwagDocument.<ExecuteAsync>d__4.MoveNext() in C:\projects\nswag\src\NSwag.Commands\NSwagDocument.cs:line 76
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.Commands.Document.ExecuteDocumentCommand.<ExecuteDocumentAsync>d__9.MoveNext() in C:\projects\nswag\src\NSwag.Commands\Commands\Document\ExecuteDocumentCommand.cs:line 77
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NSwag.Commands.Document.ExecuteDocumentCommand.<RunAsync>d__8.MoveNext() in C:\projects\nswag\src\NSwag.Commands\Commands\Document\ExecuteDocumentCommand.cs:line 31
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NConsole.CommandLineProcessor.<ProcessSingleAsync>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NConsole.CommandLineProcessor.<ProcessAsync>d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NConsole.CommandLineProcessor.Process(String[] args, Object input)
   at NSwag.Commands.NSwagCommandProcessor.Process(String[] args) in C:\projects\nswag\src\NSwag.Commands\NSwagCommandProcessor.cs:line 54

Looking at the code on master, I think the problem might be here, where the code tries to cast a property of the dynamic object to ICollection:
dynamic acceptVerbsAttribute = method.GetCustomAttributes()
    .SingleOrDefault(a => a.GetType().Name == "AcceptVerbsAttribute");

if (acceptVerbsAttribute != null)
{
    foreach (var verb in ((ICollection)acceptVerbsAttribute.HttpMethods).OfType<object>().Select(v => v.ToString().ToLowerInvariant()))

The AcceptVerbsAttribute.HttpMethods property is of type IEnumerable<string>, so the cast to ICollection is optimistic in this case. Considering the method only enumerates the result, a fix may be to change the cast to IEnumerable instead.

The problem is that this was implemented for the old attribute which was actually a collection of enums:
https://msdn.microsoft.com/en-us/library/system.web.http.acceptverbsattribute.httpmethods(v=vs.118).aspx#P:System.Web.Http.AcceptVerbsAttribute.HttpMethods
We need to support both...

Is this problem being managed in another issue? Is there anything I can contribute to help?

Already fixed :)

Please test with the CI artifacts as soon as it's done: https://ci.appveyor.com/project/rsuter/nswag-25x6o/build/artifacts

I am having trouble testing: I think there's a problem reading my nswag.json file. Would you like me to create an issue for it?

What's the problem?

JsonReaderException: After parsing a value an unexpected character was encountered: D. Path 'swaggerGenerator.webApiToSwagger.assemblyPaths[0]', line 26, position 109.

My assemblyPaths looks like:
25    "assemblyPaths": [
26        "bin/$(Configuration)/netcoreapp2.0/MyApi.dll"
27    ],

Will continue/re-test when linked to new artefacts.

Sorry, already fixed :-)

Seems you have been faster, but did the same Thing + a null check, which I did not..

Both problems seem resolved by this build.


The component does not install the CRDs for System Upgrade Controller

The component has no support for installing the SUC CRDs (plans.upgrade.cattle.io).
Steps to Reproduce the Problem

Enable SUC component on a cluster which previously didn't have SUC installed
Plans cannot be created because CRD is missing

Actual Behavior
Plans cannot be created because CRD is missing.
Expected Behavior
CRD is installed and plans can be created.

CRDs are installed by the SUC operator during startup. To ensure the component can be rolled out we annotate all Plan resources with argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true to allow ArgoCD to skip the dry run before apply for unknown CRDs (cf. https://argoproj.github.io/argo-cd/user-guide/sync-options/#skip-dry-run-for-new-custom-resources-types).

CRDs are installed by the SUC operator during startup. To ensure the component can be rolled out we annotate all Plan resources with argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true to allow ArgoCD to skip the dry run before apply for unknown CRDs (cf. https://argoproj.github.io/argo-cd/user-guide/sync-options/#skip-dry-run-for-new-custom-resources-types).