Split the async fs interface, indexedDB, and sqlite-specific code

Hello !
This is very useful work you have been doing here. If I understand well, this repository contains both the Atomic and Shared Array Buffer logic required to provide an async interface on top of emscripten's synchronous FS, and the code that implements this interface with an IndexedDB backend.

Is there any part of this code that is specific to sql.js, or could this be reused with any emscripten-compiled code that interacts with files ? If there is code that is specific to sql.js, then would it be feasible to split it from the sync-async bridge and the IndexedDB logic ?

Would it be possible to split the IndexedDB backend, in order to let the user provide a different implementation. I'm thinking about an HTTP backend in particular.

@kripken : would you be ready to merge this IndexedDB backend into emscripten itself ?

Hello!
I'm hesitant to merge it into emscription; it's really nice to be able to quickly release outside of emscripten, and there is enough tricky stuff here that it should probably be a separate project. However there might be things Emscripten can do to make it easier to plug in.

Is there any part of this code that is specific to sql.js, or could this be reused with any emscripten-compiled code that interacts with files ? If there is code that is specific to sql.js, then would it be feasible to split it from the sync-async bridge and the IndexedDB logic ?

I had thought about this being a more generic filesystem that would support writing down and file and storing it in a similar way. But I've specialized to to SQLite. It is not specific to sql.js, but it does assume SQLite data specifically.
You really don't want to manage any state like "page size", because it'll be so easy to get out of sync with what SQLite uses internally. We read the bytes from the file directly to get the page size.
You can see here in sqlite-file.js that we read the page size: https://github.com/jlongster/absurd-sql/blob/master/src/sqlite-file.js#L221-L232
It does this if you take a db file, and write the whole thing down. It gets the page size from the bytes, and that's how it knows how to break it up.
It's possible that this project could be split up in some way; let's let the dust settle and see what's possible.

Would it be possible to split the IndexedDB backend, in order to let the user provide a different implementation. I'm thinking about an HTTP backend in particular.

Personally I think it should be as easy as possible for users to get this stuff working with sql.js. Splitting it up more will add another library to add, but I'm open to it. I guess it wouldn't be too hard for the backends to be different packages.
Regarding HTTP, I'm really not sure how it would work. You don't have any transactional semantics to work with. I just published my post, I go into this in the second half about why that's so important: https://jlongster.com/future-sql-web
So anyway, thanks! After the dust settles we can talk about the best path forward!

Interesting stuff here!
In general, I am hoping that we do a large rewrite of the emscripten FS code in the next few months (ASMFS, or related). So any large change might not make sense to add there atm. A small one might make sense though, as if it can be done as a small additional JS FS, then those will get ported to the new rewrite eventually (is the general plan).
I'd be interested to hear if there are things such a rewrite should do to make this easier. One goal is to write it to native code as much as possible to allow for easier sync/async interation, which from the description here sounds relevant. (cc @rstz who I've been talking with about this recently)

Hey @kripken!
I don't think there shouldn't be any large changes. All I need from emscripten is the ability to hook into the filesystem APIs. Right now it nicely provides this with the mount method.
It feels a little weird for my app to be using the filesystem coming from sql.js. Maybe I'm using multiple WASM projects and I want them all to use the same filesystem. I know you can compile it without the filesystem, but I don't think there's any way to "hook" in a filesystem at runtime? I'd compile all them without a filesystem and then hook in mine.
But overall, I don't think any of this should live within emscripten. There's too many tradeoffs. People may just want to store files as blobs in IDB; they don't need to make partial writes to it. The filesystem capabilities should be 3rd party, so that's the only thing I'd keep in mind.
To be honest, I'm a little concerned to hear that it would move to native code. Will I still be able to provide my own JavaScript filesystem implementation?
Oh, there is one thing we need from Emscripten: lock and unlock methods on a file. You'd translate the fcntl syscall into those methods. Right now it just ignores requests to lock a file (F_RDLCK, etc) but it should forward those requests to the file. Because it doesn't do that I have to write some C code to manually hook up lock/unlock events. I can open an issue/PR on emscripten.

Would the native code use WASI?

@kripken Thoughts on above?

Oops, sorry @jlongster , I missed this in my inbox somehow...
I like the idea to make the filesystem separate somehow. The closest thing I am aware of is BrowserFS which has a central "OS" that handles filesystem syscalls, and multiple things can connect to. Definitely that's worth considering in our rewrite.

To be honest, I'm a little concerned to hear that it would move to native code. Will I still be able to provide my own JavaScript filesystem implementation?

I think so. We should be able to provide multiple different backends for that code, using JS. Similar to the current filesystem backends, but really just the core "read to/from IndexedDB" for IDB, for example, instead of right now where there is a lot of boilerplate - that would go into the native code.

Would the native code use WASI?

As much as possible, like Emscripten does. But it is useful to optionally support some extra POSIX capabilities as emscripten does today, I think - we don't want to regress that.
Not sure what you mean by lock/unlock - are those libc methods? Or syscalls? Or do you mean logically?

@kripken Sorry for my delay -- had a lot to catch up on in the last month. Going to be watching this from now on though.
I filed an issue describing the lock/unlock needs on emscripten: https://github.com/emscripten-core/emscripten/issues/15070
Sounds good about the rest of the filesystem changes. As long as there is a way to hook in some JS to those APIs.


Business Analyst

We're adding groups to the Permissions tab when publishing an app. These same groups are added to a RLS role in the Security setting for the database. This is working for one group, but the members of another group can't see the app at all. Both are distribution lists. Can you clarify the requirements for groups to be used to provide access to apps?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72ff3e88-8793-8e2b-bdb2-0e3d09372b93
Version Independent ID: 0e1245cb-d7af-c73c-39c4-39f5665ae51a
Content: Publish an app in Power BI - Power BI
Content Source: powerbi-docs/collaborate-share/service-create-distribute-apps.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Hi, @ColeenB -- a couple of questions:

Is the app from a workspace in a Premium capacity?
If not, do members of both groups have Power BI Pro licenses?
Thanks!

The workspace is in a Premium capacity.
Coleen
On Fri, May 15, 2020 at 12:43 PM Maggie Sparkman<EMAIL_ADDRESS>wrote:

Hi, @ColeenB https://github.com/ColeenB -- a couple of questions:

Is the app from a workspace in a Premium capacity?
If not, do members of both groups have Power BI Pro licenses?
Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/powerbi-docs/issues/2186#issuecomment-629442453,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AO4ATY6JPROIY3SL3RQVMRTRRWLPFANCNFSM4NB4V52Q
.

Hi, @ColeenB -- thanks. It sounds like a bug, I'm afraid. You can try the Power BI community, https://community.powerbi.com/, to see if they have suggestions. If not, contact Power BI support, https://powerbi.microsoft.com/en-us/support/.


Please release scann compiled against Tensorflow 2.12

The latest release (1.2.9) of scann is compiled against Tensorflow 2.11.
I want to use scann with TFX. The latest TFX release (1.13.0) requires Tensorflow >=2.12.0. This makes it impossible to use scann with TFX 1.13.0.
TFX 1.13.0 is also the first one to ship a docker image with python > 3.7. Since python 3.7 security support ends 27 June, I really want to use latest TFX docker image, but my project requires that I also install scann.
This would also address: https://github.com/google-research/google-research/issues/1569
@sammymax I see you most recently edited the release notes. Is there a chance that you could take a look at this please?

Python 3.7 is now past end of life, so we would like to move on to the 3.9 based TFX 1.13 Docker image.
Also, https://github.com/tensorflow/tfx/issues/5777#issuecomment-1640564951 requests that I test a bug fix with TFX 1.13, but this issue is blocking that test.

There seems to have been an oversight in the latest release, stating to support 2.12 but requiring 2.13 in the install. I recon it's a hassle to reverse the requirements of that release, so I updated the releases.md instead in #1719 . Not sure if that helps you at all?

Thanks for the update and correction.
The TFX 1.13.0 (latest) release still targets tensorflow 2.12 explicitly. I guess we can wait for a future TFX release which will which will hopefully target tensorflow 2.13. Based on the last two releases, the TFX project seems good at not skipping minor tensorflow versions.


browser.device.mobile? returns nil

When attempting to implement https://github.com/fnando/browser/issues/136 today we noticed that the mobile function returns a nil instead of a true or false. I would consider this a bug.

module BrowserHelper
  def desktop_browser?
    !(browser.device.mobile? && browser.device.tablet?)
  end
end

This is not a bug. Predicate methods returning nil values were mentioned before (like #245). Ruby doesn't really have an opinion on this. The community does.
Since nil is a falsy value just like false itself, I don't think we should coerce values. Just don't type check on your end and you should be fine. If you do need boolean values, you can always !!value on your side too.

I tend to follow ruby community guidelines which you are correct, methods with ? return true or false.  I will adjust the code on my side.


Version flag does not produce the version number

Expected Behavior
To get the version number when typing in wrench --version
Current Behavior
Output of the command is (devel)
Steps to Reproduce

Download latest release
Unpack wrench
run wrench --version

Context (Environment)

wrench version: 1.11.0

I'm using a script that checks version remotely and locally to see if there is an update available. This can't be done if the version is not produced with the --version flag.

Interesting, looks like the version flag was only being set when go install-ed. I'll update the goreleaser config to match.
https://github.com/earthboundkid/versioninfo/blob/v0.22.5/variables.go#L8


ARLAS API: OR operator on multi-values for q parameter

In gitlab by @sylvaingaudan on Nov 24, 2017, 11:53

In gitlab by @sfalquier on Nov 24, 2017, 16:02
added ~2424198 label

In gitlab by @sfalquier on Nov 27, 2017, 11:07
I propose to change q multi-filters support as follows :

q=alpha;beta => search for matching results on alpha OR beta
q=alpha&q=beta => search for matching results on alpha AND beta

In gitlab by @sfalquier on Nov 30, 2017, 11:01
mentioned in commit 2b746033bd1fa27aed72b6565147ce00e45c8461

In gitlab by @sfalquier on Nov 30, 2017, 11:02
assigned to @sfalquier

In gitlab by @sfalquier on Nov 30, 2017, 11:02
added ~2424199 and removed ~2424198 labels

In gitlab by @sfalquier on Nov 30, 2017, 14:18
mentioned in commit a82621d70d7daff037496dc649840971c7ca22fd

In gitlab by @sfalquier on Nov 30, 2017, 14:44
mentioned in merge request !116

In gitlab by @sfalquier on Nov 30, 2017, 16:00
mentioned in commit cf977a0426efc09994938ea7eb749f620fc9a501

In gitlab by @sfalquier on Nov 30, 2017, 16:07
mentioned in commit 2a2fdafe5868db6c92dd7b722598bef46970c08b

In gitlab by @MohamedHamouGisaia on Nov 30, 2017, 16:41
closed via commit f0ce09a7ca4deceef6898ee8576475374cf6b8aa

In gitlab by @MohamedHamouGisaia on Nov 30, 2017, 16:41
closed via merge request !116

In gitlab by @MohamedHamouGisaia on Nov 30, 2017, 17:13
mentioned in commit f0ce09a7ca4deceef6898ee8576475374cf6b8aa


JOIN relation we always propagate the left PE

We should propagate PE according to the JOIN type

We can use a CASE statement in the select (CASE WHEN t1.peid IS NOT NULL THEN t1.peid ELSE t2.peid END AS peid). it works fine in all JOIN types. It is equivalent of JOIN USING(peid).


Is this project still active?

Is this project still active?
Are bug reports expected here?
Will new versions get released here?

I'd like to know myself. I would like to contribute, but if this repo is dead I will start my own implementation.

Hi.
Sorry for a delay in response, but we're regrouping after the project went open here in GitHub. Please, by all means submit bug reports, pull requests, fork, in other words consider project alive. We'll figure out the best way/place to continue and let you know in good time.
Cheers

"From the 16th of February 2018, it will no longer be possible to use the Folding@Home Android client from Sony." – Håkan Jonsson, Principal Engineer Sony Mobile Communications.
"We are now working on an overhaul of the backend before we relaunch the Android client. At this stage we do not have a date for relaunch." - Anton Thynell, Pande Group Member
https://foldingforum.org/viewtopic.php?f=100&t=30663&sid=601a164cbf60c7433b0083d166d9d13a


Arch and SUSE linux compatibility

It seems that there are some different labelings in the arch and suse linux distributions causing errors apon making.
Please do something to gain more compatibility with those distributions.

I probably should mention Slackware based linux as well that would cover the four main root Linux distributions

It seems the best option might be to make a flatpak


Design panel: Don't show collapse button hover styles on headers if not collapsible

Bug Description
Saved Styles section header shows the hover bubble that is supposed to be behind the chevron when there is no content to show.
Expected Behaviour
The hover style should not be visible unless the panel is collapsible.
Steps to Reproduce

Create a story
Add text to the page
Select the text
Go to the Saved Styles panel
Delete all saved styles (if any)
Hover the Saved Styles header. Should see the bubble hover styles.

Screenshots

Additional Context

Plugin Version:
WordPress Version:
Operating System:
Browser:

@miina - we've got space, care if we fix this?

@BrittanyIRL Thanks for reaching out -- actually, this issue is not valid anymore since the Saved Styles is now a subpanel under the Text panel and can't be expanded/collapsed at all.


Gateway support on Cloud Resource

As mentioned in this document "This article applies only to datasets that have cloud and on-premises data sources merged or appended in a single query. For datasets that include separate queries--one that connects to an on-premises data source and the other to a cloud data source--the gateway doesn't execute the query for the cloud data source."
It's very easliy to mislead people to believe that Gateway doesn't execute the query for the any cloud data source, actually On-Prem data Gateway does support a list of cloud resoruce such as Azure SQL DB, and this list is mentioned in https://docs.microsoft.com/en-us/power-bi/power-bi-data-sources"
Could you please try to improve the expression a bit ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 183a8242-3c94-8a80-6d36-85c608790a25
Version Independent ID: 2d8728c3-3662-27a3-6cd4-2c88b08f7847
Content: Merge or append on-premises and cloud data sources - Power BI
Content Source: powerbi-docs/service-gateway-mashup-on-premises-cloud.md
Service: powerbi
Sub-service: powerbi-gateways
GitHub Login: @arthiriyer
Microsoft Alias: arthii

Thanks for your comment, @KerryWang94.
I've assigned this issue to the doc author for review.

Hi @KerryWang94 ,
I see that this Git issue is a bit old, so I'm going to close it.  I hope that you were able to get your questions answered. If not, please revisit the article since it has been updated since this Git Issue was submitted.  Another option is to submit your question to the Power BI community (community.powerbi.com).
All the best,
the DOCS team


Issue with loops

loop 0x1a5, >0xff does not assemble, try fixing jumps first

The issue seems to be resolved, I will test more tomorrow for positive loops and loops<256


Multiline TextFields show a box around the input in Safari

This is easy to reproduce:

Load Safari (I'm using 10, not sure if that matters)
Navigate to http://www.material-ui.com/#/components/text-field

See below:

Thanks for raising this issue. I'm closing for #5410.


chore!: eliminate dependency on the gaf

The go-application-framework should not be a required dependency of this package. It provides only minimal supporting functionality:

Convenience of access to a logger
Convenience of two configuration options (Organization and IsFedramp)

while pulling in a lot of dependencies that a Snyk Code API client does not really need. It should not be necessary, for example, to have to know about the GAF's workflow engine in order to work with Snyk Code.
This change removes the dependency on the GAF, while leaving room to integrate the code client with the GAF in the CLI and LS. This reduction of coupling makes the open-source Snyk Code client more relevant to a much wider context of reuse.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Implement Barcode Scanner

Application is not building et all. Looks like some mess(/spell) w/ filteredBarcodes & scannedBarcodes.
These two var-s not defined and weirdly used.
Barcode part in List Report Floorplan also not fully implemented nor working.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


FPS drop while using tts to speak out the objects.

Hello.  I tried to add some lines in the script to use tts (epeak) to call out the object names. but when an object is detected, it slows down drastically ( it is very obvious because it needs to finish the process of tts before continuing the loop)
So I tried to write the detected object names in a separate file(txt) and use another script to extract the text and apply tts on that..  But this process is not that efficient.
Do you have idea or suggestion to resolve this issue?

You could consider using threading or asyncio to create a seperate Thread whenever an object is on screen.
Something like:
import espeak
from threading import Thread # The script already imports Threads, for demonstration

es = espeak.ESpeak()

def speak_text(text):
    es.speak(text)

# The initial script...

# Line 199 onwards:
for i in range(len(scores)):
    if ((scores[i] > min_conf_threshold) and (scores[i] <= 1.0)):
         ymin = int(max(1,(boxes[i][0] * imH)))
         xmin = int(max(1,(boxes[i][1] * imW)))
         ymax = int(min(imH,(boxes[i][2] * imH)))
         xmax = int(min(imW,(boxes[i][3] * imW)))

         cv2.rectangle(frame, (xmin,ymin), (xmax,ymax), (10, 255, 0), 2)

         object_name = labels[int(classes[i])]
         # Start a new thread and pass the object's name as an argument
         Thread(target=speak_text, args=(object_name,), daemon=True).start()

But the overall performance always depends on the hardware this is running on.


Adding logo in center of Nav Bar

Im a little new at this. How would i go about adding a logo in the center of a navigation Bar.
Menu | Price | Logo | About | Contact Us

I updated the building block for a centered logo with F6 here:
http://zurb.com/building-blocks/centered-top-bar-with-logo

Thank you very much, however is there a way to do this using php so that i can change the navigation names in wordpress, while at the same time have logo in center?

You would just have to alter the top-bar in header.php to be like the building block.

omg lol thank youvery much,  sorry so new at this


Traktor NML files are not importing with latest Traktor version

When I drag and drop a NML file from Traktor latest version to Tracklist, nothing happens. Tracklist remains empty. I tested it with multiple playlists, names, etc.
I also just tested it with Rekordbox and same playlist, it works!
And it was working fine a few weeks ago. The only different I see that could have happened is the newer Traktor version and/or Tracklist v 1.8.0 (which is really needed as the sort issue was fixed :-) )
Cheers,
Pierre

I actually tested v1.6 Tracklist and it works with latest Traktor version! I wonder if there isn't a bigger issue with v1.8 of Tracklit


update readme to mrsi container

explains the setup steps
unused files are removed

@stebo85 I'll also create a pull request for the apps.json, so we can use the built version on hpc


Several daemon threads getting created

Hi @ChengyuanZhao  @meltsufin
Recently we are observing several GAX- threads are getting created. We didn't have this issue before but have hit this issue with recent changes. Do you happened to know why these threads are getting created ?
Daemon Thread [Gax-138] (Suspended (breakpoint at line 53 in InstantiatingExecutorProvider))
InstantiatingExecutorProvider$1.newThread(Runnable) line: 53
ThreadPoolExecutor$Worker.(ThreadPoolExecutor, Runnable) line: 619
ScheduledThreadPoolExecutor(ThreadPoolExecutor).addWorker(Runnable, boolean) line: 932
ScheduledThreadPoolExecutor(ThreadPoolExecutor).ensurePrestart() line: 1603
ScheduledThreadPoolExecutor.reExecutePeriodic(RunnableScheduledFuture<?>) line: 350
ScheduledThreadPoolExecutor$ScheduledFutureTask.run() line: 296
ScheduledThreadPoolExecutor(ThreadPoolExecutor).runWorker(ThreadPoolExecutor$Worker) line: 1149
ThreadPoolExecutor$Worker.run() line: 624
Thread.run() line: 748

@vineela-gampa Could you provide more detail about what operations you're doing that cause these threads to be created that weren't before? Any idea which update in version caused these? GAX threads come from the underlying grpc layer under the client lib, so they're a few layers removed from Spring Data Spanner.

Do you only use Spanner, or also Pub/Sub, by any chance?
Are you on the snapshot versions of spring-cloud-gcp?
Also, could you qualify "recent" - days/weeks/months?
Thanks!

we use spanner, pubsub (sync/async) pull subscribers.

@ChengyuanZhao we are using latest released milestone of spanner
with session (min : 10 max `10) and channels : 35

@vineela-gampa please share the operations you're using. Please also
isolate the usage from the pubsub usage to confirm it is from Spring Data
Spanner.
On Wednesday, November 6, 2019, vineela-gampa<EMAIL_ADDRESS>wrote:

@ChengyuanZhao https://github.com/ChengyuanZhao we are using latest
released milestone of spanner
with session (min : 10 max `10) and channels : 35
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/spring-cloud/spring-cloud-gcp/issues/2018?email_source=notifications&email_token=AG7OT4P4KCVZIIJFQASGB4LQSL5FJA5CNFSM4JJPYN52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDHK4JA#issuecomment-550415908,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG7OT4IG4UTJU5NJQBMI453QSL5FJANCNFSM4JJPYN5Q
.

Obsolete.


Update to prereq bullet #5

I've split prerequisite bullet #5 into two: First one is about the instance type only. Here I added a sentence stating where the error will be shown. 2nd bullet is the one about the different controls and what they depend on. My motivation for this split comes from customers struggling to notice that instance types (B2C vs B2B) is a major factor for the card add-in.  I considered grouping the 2nd bullet with in the first, but I doubt it makes a difference worth the cost of having such deep bullet points.

@michaelhartmann for review


@Jimbo4350 squashed

bors merge


Updating content on the Blog page

Added more content on the blog page

Can you assign this issue to me @akshitagupta15june  if this issue is still available


Fix fuzz.py

fuzz.py is currently un-importable as it relies on setup_test_run_engine, which no longer exists.
We should either fix it or remove it if it's no longer used. I don't have enough background to decide which one but happy to do the work.

Target destroyed


Jord dg update

Codecov Report

Merging #311 (a2d5711) into v1.4-UG-DG (02e43f3) will increase coverage by 1.78%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             v1.4-UG-DG     #311      +/-   ##
================================================
+ Coverage         70.62%   72.40%   +1.78%
- Complexity          927      946      +19
================================================
  Files               139      139
  Lines              2907     2914       +7
  Branches            305      307       +2
================================================
+ Hits               2053     2110      +57
+ Misses              748      702      -46
+ Partials            106      102       -4

Impacted Files
Coverage Δ

.../java/seedu/rc4hdb/model/resident/fields/Room.java
90.90% <0.00%> (-9.10%)
:arrow_down:

src/main/java/seedu/rc4hdb/model/ModelManager.java
90.90% <0.00%> (+1.13%)
:arrow_up:

...seedu/rc4hdb/model/venues/booking/fields/Hour.java
100.00% <0.00%> (+9.09%)
:arrow_up:

...rc4hdb/model/venues/booking/BookingDescriptor.java
82.14% <0.00%> (+10.71%)
:arrow_up:

...ava/seedu/rc4hdb/model/venues/booking/Booking.java
81.08% <0.00%> (+29.72%)
:arrow_up:

...hdb/logic/commands/venuecommands/VenueCommand.java
100.00% <0.00%> (+33.33%)
:arrow_up:

...gic/commands/venuecommands/VenueDeleteCommand.java
77.77% <0.00%> (+55.55%)
:arrow_up:

...4hdb/logic/commands/venuecommands/BookCommand.java
90.32% <0.00%> (+70.96%)
:arrow_up:

.../logic/commands/venuecommands/VenueAddCommand.java
100.00% <0.00%> (+75.00%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


CODEOWNER update - main branch

Both @mauwii and @keturn have been offline for some time. I am temporarily removing them from CODEOWNERS so that they will not be responsible for code reviews until they wish to/are able to re-engage fully.
Note that I have volunteered @GreggHelt2 to be a codeowner of the generation backend code, replacing @keturn . Let me know if you're uncomfortable with this.

Looks like some non-CODEOWNERS changes have slipped into this PR.

You're right. The diffusers 0.15 changes are there too. I'll withdraw this and try again for a clean version.


patch translations into bootgrid at runtime, based on the work of kekek2

patch it into the library in the template so it will be applied to all templates.
Strings used from the original pull request.
closes #1633

@fabianfrz thanks, looks good


Crash from accessing instance variable in super before it's set in subclass

This happens with 0.24.1, 0.24.2, and master, but for completeness here's the version string of master:
Crystal 0.24.2 (2018-05-26)
LLVM: 5.0.1
Default target: x86_64-unknown-linux-gnu
The OS is NixOS.
class Base
  property last_value : String

  def initialize
    @last_value = data
  end
end

class Sub < Base
  property url : String

  def initialize
    super
    @url = ""
  end

  def data
    url
  end
end

pp Sub.new.last_value

Moving @url = "" before the super fixes the crash, but that should be caught by the compiler.
Backtrace is:
Invalid memory access (signal 11) at address 0x4
[0x446886] *CallStack::print_backtrace:Int32 +118
[0x43afbb] __crystal_sigfault_handler +75
[0x7f07fe4d0dd0] ???
[0x44b070] *String#chomp:String +352
[0x44c8b3] *String#pretty_print<PrettyPrint>:Nil +275
[0x485175] *PrettyPrint::format<String, IO::FileDescriptor, Int32, String, Int32>:IO::FileDescriptor +117
[0x4850f3] *PrettyPrint::format<String, IO::FileDescriptor, Int32>:IO::FileDescriptor +67
[0x43b010] *pp<String>:String +32
[0x42dea2] __crystal_main +1730
[0x483946] *Crystal::main_user_code<Int32, Pointer(Pointer(UInt8))>:Nil +6
[0x483812] *Crystal::main<Int32, Pointer(Pointer(UInt8))>:Int32 +50
[0x438e86] main +6
[0x7f07fd8b6020] __libc_start_main +240
[0x42d72a] _start +42
[0x0] ???

Can this be reduced to
module Hello
  def self.hello
    print @@hello

    "hello"
  end

  @@hello : String = hello()
end

maybe?

No, the original example mentions an instance variable. It's just a different bug. I actually can make the second one compile but it will still crash with a stack overflow.


feat(sbb-navigation): remove navigation section divider

Closes #2465

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@4f8f309). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2473   +/-   ##
=======================================
  Coverage        ?   93.68%
=======================================
  Files           ?      297
  Lines           ?    24399
  Branches        ?     2035
=======================================
  Hits            ?    22857
  Misses          ?     1509
  Partials        ?       33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Prevent default behaviour of backspace/delete key when used on canvas

Fixes #51

@eternalthinker, have added some abstraction to your code. So closing this in favour of #64


Swift error in 10.6

Description
https://stackoverflow.com/questions/75704453/firebasesessions-swift-error-with-xcode-12-5-1/75773723#75773723
After upgrading from 10.3 to 10.6 now I'm getting a casting error in my XCode. I've created this simple update to the function to add the casting and it compiles fine. The minor difference is that I casted it to non-optional type (e.g. missing the "?"), so can update the pull request to have that. I'm not sure why Swift is complaining about this cast, but updating the code as in the pull request let me build my project. Please note that the function seems to be for debugging purposes only, it is not required for actual logic of Firebase.
https://github.com/firebase/firebase-ios-sdk/compare/master...hrkm:firebase-ios-sdk:patch-1#diff-17a6d07d68bd3d24b12ede65f118e609eecec47c8df92c5afb9d22199712707f
Reproducing the issue
No response
Firebase SDK Version
10.6
Xcode Version
13.2.1
Installation Method
CocoaPods
Firebase Product(s)
Analytics, Authentication, Crashlytics, Firestore
Targeted Platforms
iOS
Relevant Log Output
No response
If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

We've tested Firebase 10.6 code successfully on the earliest supported Xcode version - 13.3.1.  Please upgrade to at least that Xcode version.  Also, note that Apple will soon be dropping Xcode 13 support and Firebase will follow and move to require at least 14.1.

Yeah, I kind of realized that probably the error might be related to the old version of Xcode, especially after submitting my app bundle to AppStore which also displayed the warning that Xcode 14 will be required starting April 2023. [which started showing up since yesterday - I had uploaded another package on March 15th and didn't see that warning at all - that's a very small amount of time to upgrade, but that's on Apple :( ]
The patch I made is useful for anyone who still need to upgrade but needs to release their new bundle before getting new equipment (for me it means I need to get a new device). Feel free to close the issue, but hopefully others will be able to find it if they encounter the same error in the next 2-3 weeks before Xcode 13 gets deprecated.


How to get fix shape of features from Roberta large model

Questions and Help
I'm getting a different feature shape. Is there any way to get the fixed shape of the extracted features from Roberta?
I anlysed that axis-0 and axis-2 gets fixed shape 1 and 1024 respectively. But axis-1 is changing based on the statement.
For "Hello world!" Roberta returns (1,5,1024)
For "Hello good morning Hello world!" Roberta returns (1,8,1024)
Is there any way to get the same shape of features from Roberta?
Code
In [1]: import torch
   ...: roberta = torch.hub.load('pytorch/fairseq', 'roberta.large')
   ...: roberta.eval()

In [2]: tokens = roberta.encode('Hello world!')

In [3]: last_layer_features = roberta.extract_features(tokens)

In [4]: last_layer_features.shape
**Out[4]: torch.Size([1, 5, 1024])**

In [5]: tokens = roberta.encode('hello good morning Hello world!')

In [6]: last_layer_features.shape
Out[6]: torch.Size([1, 5, 1024])

In [7]: last_layer_features = roberta.extract_features(tokens)

In [8]: last_layer_features.shape
**Out[8]: torch.Size([1, 8, 1024])**

What's your environment?

fairseq Version (e.g., 1.0 or master):
PyTorch Version (e.g., 1.0) - 1.4.0
OS (e.g., Linux): Ubuntu 18
How you installed fairseq (pip, source): pip
Build command you used (if compiling from source): -
Python version: python3.6 and python3.7
CUDA/cuDNN version: -
GPU models and configuration: -
Any other relevant information: -

We return the features of the entire last layer, which changes based on the input length (more input tokens -> more output features).
For classification tasks people typically use the so-called [CLS] features, which is just the first position of the last layer:
https://github.com/pytorch/fairseq/blob/4923f34790761f41170fd88cd06e4d00ab0c527c/fairseq/models/roberta/model.py#L230-L247
You can try something similar, but it's important to finetune the model in this setting, otherwise the [CLS] feature representation will be pretty bad.


format_with scope discussion

I want to do some refactoring in Grape::Entity that will help me face #56 and #140 issues easily.
Another thing that stops me from doing it is a format_with feature. Don't ask me how it's exactly related to issues mentioned above. For now I just want to discuss some ways to improve the format_with feature.

Current format_with behavior is to store procs in formatters table which is copied when entity A is inherited by entity B. So each entity has its own table of formatters. I'd like to call current implementation  dynamically scoped.
There is a way to improve it! This table of procs and the mechanism of copying is very similar to regular Ruby classes that support inheritance out of the box. We can substitute this Hash table with an anonymous formatters class and simply inherit it when the whole Entity is inherited. It will allow children formatters to refer overriden implementation (using Ruby's super) and even do mixins (with include). Implementing this will be zero cost because all that inheritance stuff will be handled by Ruby. By the way, I also call this variant dynamically scoped.
Make a breaking change implementing formatters lexically scoped. I mean the following behavior:

class E < Grape::Entity
  expose :created_at, format_with: :timestamp # this will raise an error because :timestamp is not yet defined
  format_with(:timestamp) { |dt| dt.iso8601 }
  expose :old_created_at, format_with: :timestamp
  format_with(:timestamp) { |dt| dt.httpdate }
  expose :created_at, format_with: :timestamp
  # Here old_created_at will be formatted with iso8601,
  # but created_at will be formatted with httpdate

It's really breaking but it also adds flexibility as in the second variant and it's very similar to how Grape's DSL works. It will also allow us to define local formatters, for example:
class E < Grape::Entity
  format_with(:timestamp) { |dt| dt.httpdate }
  with_options(format_with: :timestamp) do
    expose :old_timestamps do
      format_with(:timestamp) { |dt| dt.iso8601 }
      expose :created_at
      expose :updated_at
    end
    expose :created_at
    expose :updated_at
    expose :deleted_at
    expose :last_accesed_at
    # ...
  end
end

So no inheritance tricks needed because now formatters are lexically scoped.
Internally it can also be implemented with anonymous class so it offers the same features as the second variant but the implementation will be more tricky.
What do you think? I'm in doubt but personally I like the third variant more.

Another reason to rethink this feature is that in #56 we decided not to just overwrite exposures but think of them as method calls. So maybe we don't need just rewrite formatters too?

The main caveat of the third variant is that formatter should be defined before its name is used in options passed to exposure. But it's easy to catch it when upgrading because such exception will be revealed soon (during the entity class initialization).

On the other hand, second variant makes think of formatters as helper methods and, you know, in Ruby access to methods is done using method table lookup when this method is needed.
And the stackable behavior described above is also can also be implemented with the second approach.

I don't see a problem with creating an anonymous class and inheriting it, although I don't see whether that improves anything. Try to make some code changes, I'd want to see the scope of changes for the user.

I'm temporarily closing it. I tried to come up with an implementation and I don't like it. The main reason is that format_with blocks are executed in the context of an Entity instance. Maybe later I re-open this issue with fresh thoughts.


Added appveyor control file.

Just adding AppVeyor, not yet cleaning up the folder structure.

Looks like I'll need to do a little cleanup in VS to make sure the project file handles the x64 mode.

Hmm, on a closer second look, it seems the project platform was changed from AnyCPU to x64. While we may be expecting x64, this may trigger incompatibilities or warnings when mixing with AnyCPU DLLs, does it not? Was this change intentional or accidental from VS updates?

It was purposeful: no more valid reason than that I'm setting everything in Halcyon to x64 only.

Okay. The thing about AnyCPU is that it allows DLLs to be loaded into any host process environment, i.e. you can load it into an EXE process that was started as a 32-bit app. Setting it to x64 just limits it to 64-bit only, so the DLL can't be loaded in that case.
This isn't likely to be a problem in most builds (and won't be a problem if it's building an EXE), but in general this is a limitation we wouldn't want in an open-source project. For example: the latest (and last) Linux User and Developer magazine has an article on building and loading .NET Core applications on a Raspberry Pi. (Stop laughing, it's serious apps!) 😆 I have several small ODROID boxes (similar to Pi), running Linux, and while they aren't too capable, it might be suitable for central grid services, or AIS.
For libraries, we almost certainly don't want to just arbitrarily limit it to 64-bit executable builds (or anything specific).  One of the nice things about .NET is the platform independence.  For executables, we could.  I just don't really see what the benefit of preventing it from running on some machines would be here, especially given the hobbyist nature of the open-source Halcyon projects.

As said in another project I'll be revisiting the whole AnyCPU thing.  Thank you for the clarity.


Periodic telemetry reporting

Needs discussion on how to achieve this, one option is to have a Kubernetes CronJob that sends periodical metrics.
Possible metrics that are needed:

number of conversations
number of messages
errors and/or pod restarts

This issue is not needed anymore.


[Test] Disabled some tests temporarily.

Until bot configuration is fixed.
rdar://87772056

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge

@swift-ci please test and merge


Using requires option crashes the application

Hello,
I have an application which were running smooth unless I added a new command line argument which requires other. When I added the argument the application started to crush on cli.yml parsing.
Here is the part my cli.yml. Please notice skip_details argument here.
name: application
version: 0.3.0
args:
    - verbose:
        short: v
        multiple: false
        help: Sets the level of verbosity
subcommands:
    - ftp:
        about: Perform operation using FTP Client
        version: 0.2.0
        args:
            - list:
                short: l
                long: list
                help: List files in the given path
            - skip_details:
                long: skip-details
                help: Skip executing additional FTP commands in --list mode.
                requires: list

And here is the backtrace of my application run.
thread '<main>' panicked at 'called `Option::unwrap()` on a `None` value', ../src/libcore/option.rs:325
stack backtrace:
   1:        0x10450dc1b - std::sys::backtrace::tracing::imp::write::h3800f45f421043b8
   2:        0x10450f8f5 - std::panicking::default_hook::_$u7b$$u7b$closure$u7d$$u7d$::h0ef6c8db532f55dc
   3:        0x10450f52e - std::panicking::default_hook::hf3839060ccbb8764
   4:        0x104500d87 - std::panicking::rust_panic_with_hook::h5dd7da6bb3d06020
   5:        0x10450feb6 - std::panicking::begin_panic::h9bf160aee246b9f6
   6:        0x104501808 - std::panicking::begin_panic_fmt::haf08a9a70a097ee1
   7:        0x10450fb0f - rust_begin_unwind
   8:        0x104535d90 - core::panicking::panic_fmt::h93df64e7370b5253
   9:        0x10453608c - core::panicking::panic::h9d5bd65bbb401959
  10:        0x104475fd2 - _<std..option..Option<T>>::unwrap::hd3a293e3137a3702
  11:        0x1043ee3a3 - clap::args::arg::Arg::from_yaml::hc10920fc2443ee2d
  12:        0x10438511d - _<app..App<'a, 'a> as std..convert..From<&'a yaml_rust..Yaml>>::from::h64e34d32683ea4af
  13:        0x104382c9b - clap::app::App::from_yaml::he42602ec75f0a4f0
  14:        0x1043ef23b - clap::args::subcommand::SubCommand::from_yaml::hfea79b6b081c20c8
  15:        0x10438532c - _<app..App<'a, 'a> as std..convert..From<&'a yaml_rust..Yaml>>::from::h64e34d32683ea4af
  16:        0x104382c9b - clap::app::App::from_yaml::he42602ec75f0a4f0
  17:        0x104094144 - download::main::h25fc507b71d1853f
  18:        0x10450f11d - std::panicking::try::call::hbbf4746cba890ca7
  19:        0x1045125db - __rust_try
  20:        0x104512575 - __rust_maybe_catch_panic
  21:        0x10450ef41 - std::rt::lang_start::hbcefdc316c2fbd45
  22:        0x1040a6d39 - main

Thanks for filing this! I'll look into what's causing this and post back with what I find.

This looks like a duplicate of #614 (or rather that is a duplicate of this issue). This will be fixed with #620


pkg/version(ticdc): bump max version for release 7.5

What problem does this PR solve?

Issue Number: ref https://github.com/pingcap/tiflow/issues/10807
What is changed and how it works?
Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

/retest

/retest


ga4gh/quality-control-wgs metrics_definitions.md - Mean autosome coverage

Description: The mean sequencing coverage derived from short paired-end sequencing high quality, non duplicated reads, primary alignments, achieving a mapping quality of 20 or greater, in autosomes non gap regions of GRCh38 assembly. Clipped bases are expluded.

expluded -> excluded
Good to include the comment given below or remove the high quality from the description? The high quality reads also not part of the description in the proposed GHIF WGS QC document!

NPM-sample-qc implementation metric Mean autosome coverage doesn't select high quality reads using mosdepth
It is critcal that the (BAM/CRAM) alignment files generated only from the illumina PF reads.

no we keep the mention of high quality reads ... even if indeed there hasn'nt been any NGS delivered with non PF PASS for 10+ years.
@mhebrard please take note of the typo
also informed of the typo in https://github.com/ga4gh/quality-control-wgs/issues/9#issuecomment-1504602516


protoc-gen-go: Not extracted TrailingComments

https://github.com/golang/protobuf/blob/e51d002c610dbe8c136679a67a6ded5df4d49b5c/protoc-gen-go/generator/generator.go#L991
When the loc.LeadingComments is nil and loc.TrailingComments is not nil, the loc.TrailingComments is not extracted.
Is this intended?

It was intended. Very few people use trailing comments, and even when they are used they are often not suitable for converting into comments in the generated code.

I understood it.
thanks.


Move helm chart to github.com/timescale/timescaledb-kubernetes

To speed up development of the helm chart and simplify testing its compatibility with timescaledb-single, we want to move promscale helm chart to the single repository.

Related to https://github.com/timescale/helm-charts/pull/411


Remove requirement files, strict version pins from examples

In preparation of running a cronjob in GitHub Actions that checks verifies the examples to work.
Side effect: This stops the dependabot alert spam.
I would like to add a job to our CI that runs all examples on a schedule, e.g. every day at midnight.
Updates the Python pins to 3.10+, since nnbench is set up that way now.

What we could do is add lockfiles for a quick install+run workflow with uv, otherwise we just tell people to [uv] pip install . like I think we're doing already at this point.


useQuery when throwing an error not working as per documentation

Describe the bug
The documentation states the following (https://react-query.tanstack.com/guides/query-functions):
"Handling and Throwing Errors
For React Query to determine a query has errored, the query function must throw. Any error that is thrown in the query function will be persisted on the error state of the query."
But useQuery seems to be letting the exception bubble and the component "breaks".
To Reproduce
https://codesandbox.io/s/react-query-throw-not-working-jmmqf
Expected behavior
The component should render: Not WORKING!!!
The 3 console logs should be written to the console. console.log(error, "error"); should white the "Query error" message thrown.
Desktop (please complete the following information):

Windows 10
Browser: Chrome
Version: Latest
React 17.0.2
React Query 3.23.2

I'm interpreting the documentation incorrectly?
If I downgrade to an older version (2.x) of React Query it works as per documentation.

you forgot to mention that you are using suspense: true,. Per default, suspense uses Error Boundaries to catch and handle errors. This is well documented on the suspense docs page, together with how to opt-out of it, which is by setting useErrorBoundary: false.

@TkDodo = lifesaver :)
It makes total sense. I built a Framework that handles a lot of boiler plate concerns and it handles errors without Error Boundaries. I recently made a change to my http service hook to throw the error (which it was already handling), so that optimistic updates and deletes would run onError in case the http service call fails.
I recall reading something about the useErrorBoundary flag weeks back, but since it had no impact until my latest change, I didn't remember all that I had read, I did some research now, but it didn't lead me to that flag.
I will turn the flag off and it should be all good. But a curiosity question comes to mind... Why didn't I experience the same behavior when I use useMutation? I'm throwing the error inside my http service when I use both useQuery and useMutation, but my component doesn't 'break' on an 'errored' mutation...
I updated the sandbox to exemplify:
https://codesandbox.io/s/react-query-throw-not-working-jmmqf

Why didn't I experience the same behavior when I use useMutation?

because useMutation has no support for suspense, so you'd need to explicitly turn useErrorBoundary on to get that behaviour.

Thanks for the quick responses and clarifications.


Add application deploy

Portfolio Microverse Project  🎉

This PR adds a GitHub deploy link to the readme.

Live Preview  🚀
Live Preview Link

@teekaytech, Thanks for approving my project 🎉


add support for parameters references in path specs

currently the parser fails to add parameters if they are not defined in line but are defined in the parameter section of the swagger spec
look for an example here:
https://github.com/hjacobs/connexion-example/blob/master/swagger.yaml
This quick fix resolves the problem by expanding the parameter definition from the specification section using the '$ref' attribute.
Assuming the swagger spec is correct, there is no need for extra error checking.

Thanks for the PR !


CI builds & looser device-name check

This will build several pre-compiled releases in Github CI (#6)
The idea is that it's triggered with a semver git-tag (like v0.0.1) but we can set it up some other way, if this is not convenient. For testing, I used dummy tags like vtest24. If you don't want to use semver, I think any tag could also trigger it, with a small change (so you can just tag your releases and it will generate a release for it.)

Here is an example build
Here is what that looks like, as a release.

Currently, it can build:

linux (x86-64, arm64, arm32)
mac (x86-64)
windows (x86-64)

It will add a new tagged release with assets so users can download the built runtime for their platform (including some config examples and the README.)
This should have pi and handheld Anberinic devices (like this) covered, as well as windows, and older macs. I need to do more testing. I have a Mac M1, and an Intel-mac, and a few different platforms for linux, so I will try to get those all verified (and windows, in a vmachine.)
Linux cross-building is very slow, since it builds in qemu. I think we could improve this using rust's cross-building stuff, but it seems a bit tricky with SDL2/libudev native deps.
Main build-things left to do is mac arm64 (for M1/M2 apple silicone) and I can't seem to get it, but I made an issue over here asking for help. There is also currently an error trying to cross-build on linux spurious network error - Value too large for defined data type; class=Os (2) which I need to look into. It just started doing this, so maybe I need to adjust something in the docker-build.
I think for mac/linux, users will probly also need instructions for installing SDL, since it's dynamically-linked. For windows, I include a SDL2.dll in build.
# mac
brew install sdl2

# ubuntu/debian/etc
sudo apt update
sudo apt install libsdl2 libudev

# fedora/etc
sudo dnf install SDL2

# arch linux
sudo pacman -S sdl2

mac x86-64 runs, but I get No M8 audio device found
steamdeck (linux x86-64) runs, but crashes when I hit "START", with no error message
Anbernic RG353P (linux arm64, running JELOS) runs, but I get No M8 audio device found

No M8 audio device found I think is related to #3, so I will see if I can work that out.
Still needs testing on windows, which will take me a bit (have to setup a virtual-machine) but this gives me new stuff to troubleshoot.

Update: just needed joystick mapping to make RG353P work. Here is what I landed on:
{
"joysticks": {
    "190000004b4800000111000000010000": {
      "buttons": {
        "15": "Left",
        "16": "Right",
        "8": "Escape",
        "14": "Down",
        "0": "Option",
        "1": "Edit",
        "2": "Play",
        "17": "Escape",
        "3": "Shift",
        "13": "Up",
        "9": "Config"
      },
      "axes": {
        "4": {
          "sensibility": 20000
        },
        "5": {
          "sensibility": 20000
        },
        "3": {
          "sensibility": 20000
        },
        "2": {
          "sensibility": 20000
        },
        "0": {
          "negative": "Left",
          "positive": "Right",
          "sensibility": 20000
        },
        "1": {
          "negative": "Up",
          "positive": "Down",
          "sensibility": 20000
        }
      }
    }
  }
}

Runs great, with audio.

Another idea, instead of releases, is using nightly.link to link to build-assets. I could merge the 2 ideas together, so you get bleeding-edge builds, but can also do tagged releases.

I merged the other PR here, so I can keep working on stuff.


Disable of clicking and opening any new windows #9

Tracking Issue: #9
Done!
Only problem is YouTube's terms states "If you use the Embeddable Player on your website, you may not modify, build upon, or block any portion or functionality of the Embeddable Player, including but not limited to links back to the YouTube website." (https://www.youtube.com/static?template=terms)
Instead of completely blocking the ability to link back to YouTube, I created a prompt notifying the user and providing the URL to visit in their favourite browser.

That's cool. Thanks!


Remove Robert Li from tests OWNERS file

Robert has had a change in employment and can no longer contribute to
Istio.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: sdake
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: utka
If they are not already assigned, you can assign the PR to them by writing /assign @utka in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/assign @utka

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: sdake, utka
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [utka]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdake: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ba738104169833e80542a6d00e614911bcdf2186
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Detect deleted tokens function and wrote some basic tests

Description
Created a function to detect when tokens are deleted. It differentiates if the token is simply renamed or if the token is actually deleted.
Related Issue
The current diff script for the tokens project doesn't differentiate between renamed tokens or deleted tokens.
Motivation and Context
The current diff script for the tokens project doesn't differentiate between renamed tokens or deleted tokens, so this function aims to make the diffs more accurate.
How Has This Been Tested?

A basic test checking if a non-renamed token is deleted from a mock schema
2 tests (same result) checking if a renamed token is categorized incorrectly as a deleted token

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@shirlsli thanks for cleaning it up.


tests: stack parametrized tests arguments

This PR introduces stacked parametrized tests arguments where possible, and improves the tests parametrization.

This is definitely a good improvement! I haven't double checked each parameter, but trust that it's correct.
The one thing I "worry" about is that if we make changes to the defaults and/or introduce new parameters, we need to change it here as well. I do think there is a simple way to extract the default values of (data) classes with their attribute name as dictionaries. Maybe that would be an even nice way of doing this?

I tried this, but in this case it's not so easy since we have dataclass fields parameters, that you can't directly access with Task.__dict__ and getattr(Task, attr) that are normally used.


[BUG]-Transition speed is pretty fast

Description
I'm looking for assistance in slowing down the transition between slides on my website, which utilizes the Slick slider plugin.
Actual Behavior
Currently, the transition between slides happens too rapidly, causing a less-than-ideal user experience.
Expected Behavior
I would like to reduce the speed of transitioning between slides to ensure a smoother and more controlled browsing experience for my visitors.
Steps to Reproduce
Visit the website.
Observe the quick transition between slides.
Notice the rapid pace at which the slides change.
Before:
https://github.com/itsmohit097/medi-hub/assets/113296663/84b7309b-9005-4ec3-b33b-f9105f01789c
After:
https://github.com/itsmohit097/medi-hub/assets/113296663/610df3b8-1824-4db3-b8ff-5af606291c43

@itsmohit097 please assign me this task under GSSOC'24

@itsmohit097 ??

hero section is changed now


Make pdfrx support Flutter Web with wasm

I need to use Flutter Web with wasm for the application.
``
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:7:1: Error: JS interop library 'dart:js_util' can't be imported when compiling to Wasm.
Try using 'dart:js_interop' or 'dart:js_interop_unsafe' instead.
import 'dart:js_util';
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:122:14: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
double offsetX = 0,
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:123:14: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
double offsetY = 0,
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:124:12: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
bool dontFlip = false});
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:168:14: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
String intent = 'display',
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:169:11: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
int annotationMode = 1,
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:170:12: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
bool renderInteractiveForms = false,
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:207:10: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
bool includeMarkedContent = false,
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:208:10: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
bool disableNormalization = false,
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdf.js.dart:267:12: Warning: Initializers for parameters are ignored on static interop external functions.
Declare a forwarding non-external function with this initializer, or remove the initializer.
String intent = 'display',
^
../../.pub-cache/hosted/pub.dev/pdfrx-1.0.50/lib/src/web/pdfrx_web.dart:6:1: Error: JS interop library 'dart:js_util' can't be imported when compiling to Wasm.
Try using 'dart:js_interop' or 'dart:js_interop_unsafe' instead.
import 'dart:js_util' as js_util;
^
Command: /Users/daydelight/fvm/versions/master/bin/cache/dart-sdk/bin/dart compile wasm --packages=.dart_tool/package_config.json
--extra-compiler-option=--dart-sdk=/Users/daydelight/fvm/versions/master/bin/cache/dart-sdk
--extra-compiler-option=--platform=/Users/daydelight/fvm/versions/master/bin/cache/flutter_web_sdk/kernel/dart2wasm_platform.dill --extra-compiler-option=--delete-tostring-package-uri=dart:ui
--extra-compiler-option=--delete-tostring-package-uri=package:flutter --extra-compiler-option=--import-shared-memory --extra-compiler-option=--shared-memory-max-pages=32768 -Ddart.vm.product=true
-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/4f6b832c8e333775f2c217a821050543a110826e/ -DFLUTTER_WEB_AUTO_DETECT=false -DFLUTTER_WEB_USE_SKIA=false
-DFLUTTER_WEB_USE_SKWASM=true --extra-compiler-option=--depfile=/Users/daydelight/study/webassembly/.dart_tool/flutter_build/b49f125fa6955c85159dd2d865c4d882/dart2wasm.d -O4 --no-name-section -o
/Users/daydelight/study/webassembly/.dart_tool/flutter_build/b49f125fa6955c85159dd2d865c4d882/main.dart.wasm
/Users/daydelight/study/webassembly/.dart_tool/flutter_build/b49f125fa6955c85159dd2d865c4d882/main.dart
#0      RunResult.throwException (package:flutter_tools/src/base/process.dart:125:5)
#1      _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart:321:19)

#2      Dart2WasmTarget.build (package:flutter_tools/src/build_system/targets/web.dart:297:5)

#3      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:875:9)

#4      Future.wait. (dart:async/future.dart:524:21)

#5      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:813:32)

#6      Future.wait. (dart:async/future.dart:524:21)

#7      _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:813:32)

#8      FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:642:16)

#9      WebBuilder.buildWeb (package:flutter_tools/src/web/compile.dart:92:34)

#10     BuildWebCommand.runCommand (package:flutter_tools/src/commands/build_web.dart:230:5)

#11     FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:1394:27)

#12     AppContext.run. (package:flutter_tools/src/base/context.dart:153:19)

#13     CommandRunner.runCommand (package:args/command_runner.dart:212:13)

#14     FlutterCommandRunner.runCommand. (package:flutter_tools/src/runner/flutter_command_runner.dart:372:9)

#15     AppContext.run. (package:flutter_tools/src/base/context.dart:153:19)

#16     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:308:5)

#17     run.. (package:flutter_tools/runner.dart:119:9)

#18     AppContext.run. (package:flutter_tools/src/base/context.dart:153:19)

#19     main (package:flutter_tools/executable.dart:93:3)

Compiling lib/main.dart for the Web...                             17.2s
Error: Failed to compile application for the Web.
``

Basically, because wasm build is not supported on stable channel, I don't ensure that pdfrx runs on it. But I've just removed dependency on js_util.

@espresso3389
Thank you, i am waiting  pdfrx  support wasm when wasm will be supported on stable channel

What's the likelihood of getting wasm support, now that it is supported on the stable channel?

There are several pieces that can be building block of pdfrx wasm support:

Flutter's support for WebAssembly (Wasm)
wasm_ffi
bblanchon/pdfium-binaries has precompiled wasm module

I didn't check the things deeply, but wasm_ffi lacks struct support and it may be a major blocking issue for the support.

And, wasm_ffi 0.9.4 was released 16 months ago. The maintainer is not actively maintaining it.
Do you guys know any kind of alternative to wasm_ffi or should we (I or someone) fork it to add support of struct??

I'm guessing it'll need to be forked. I'm asking around to see about options.

Yes, dart2wasm doesn't support dart:ffi yet - we intend to look into how we can best support FFI on the web. But for the time being one would need to go via JS.
The package:wasm_ffi seems to do exactly that. Commits seem to be landing in that repository (https://github.com/vm75/wasm_ffi/commits/main/), so if that package has sufficient support for what package:pdfrx needs or any missing support can be added, then it may be a good option to use it and possibly send some PRs to that repository.

And, wasm_ffi 0.9.4 was released 16 months ago. The maintainer is not actively maintaining it. Do you guys know any kind of alternative to wasm_ffi or should we (I or someone) fork it to add support of struct??

Are there still missing features after the recent bursts of commits to this repo? I'm not too familiar with ffi.
pdfrx is the final dependency blocking us from rolling out WASM and we see huge improvements from it, it would be great to get an update on this.

pdfrx-1.0.94/lib/src/pdfium/pdfrx_pdfium.dart:3:1: Error: 'dart:ffi' can't be imported when
compiling to Wasm.
import 'dart:ffi';

We still have many things to support wasm.

but is strange with flutter 3.24 i have the possibility to compile with wasm, and now i have errors

and do you have any schedule to do the library compatible with WASM?

this library could help you?
https://pub.dev/packages/wasm_ffi

At this moment, no ETA/schedule for the issue. And Of course, I'm trying to use wasm_ffi.
The current web implementation is based on pdf.js and WASM version will be based on pdfium WASM version to keep the cosistency with other platforms. And it will be a huge change anyway.
At least, I should check the following things:

Whether single pdfium binding can be used for both web and others

if we could not do that, how we work around the issue

Some way to asynchronously call rendering methods and others ([isolate_manager(https://pub.dev/packages/isolate_manager)?)

if it's impossible, can we go with synchronous calls?

ffi and wasm_ffi syntax compatibility or any other kind of abstraction layer


Support sub-milliseconds timestamps

Brickner[CodePlex] The translation of DateTime to WinPcap's timestamp rounds everything to milliseconds, which makes sub milliseconds precision unsupported.

Brickner[CodePlex] This has been fixed and will be released in the next version.
The latest source code includes this fix.

Brickner[CodePlex] I believe the bug is in PacketTimestamp::DateTimeToPcapTimestamp(), but obviously also the reversed PacketTimestamp::PcapTimestampToDateTime() has the same bug.
I haven't fixed it yet, though it shouldn't too complicated. Unfortunately, I will only get to it in a few weeks.
Basically I first plan to write a test that reproduces the bug, make the fix and make sure the test (and all other tests, that might need some modifications) passes.

DrCornelius[CodePlex] Hi Boaz,
I am interested in getting this fixed, so I looked through the code and wonder if the problem is within PacketTimestamp::DateTimeToPcapTimestamp with a related change needed in PacketTimestamp::PcapTimestampToDateTime. I will get the dev environment on my machine
(need to download ultimate, ouch on the price, will have to demo) and try out some changes. I am not familiar with your code or pcap API, but I will share my results if you like.
Am I duplicating effort here? Is the fix done and ready to be tested, just looking for some guinea pig? :)


Update CHANGELOG and version for 2.1.3

Simply getting the CHANGELOG.md and CMakeLists.txt ready for release

Looks like the version number was not added to the ChangeLog

Sigh. Yup. copy-paste without thinking :)


ScrollGestureRecognizer ends its current fling gesture (touch or pen)…

… if ScrollGestureEventArgs is no longer handled by the Presenter.
What does the pull request do?
A fling ScrollGesture started by touch or pen swiping will stop as soon as the presenter stops scrolling (no change in offset).
What is the current behavior?
See #9955.
What is the updated/expected behavior with this PR?
A fling ScrollGesture will no longer influence scrolling after scrolling reached the end of the scroll area.
How was the solution implemented (if it's not obvious)?
The ScrollContentPresenter has a Scroll Chaining option -- if this is turned off, the ScrollGestureEventArgs.Handled will always be true -- for this scenario I added ScrollGestureEventArgs.ShouldEndScrollGesture.
Breaking changes
none
Fixed issues
Fixes #9955

You can test this PR using the following package version. 11.0.999-cibuild0028575-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Cannot select any of the new Battle Configs I create

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
JP
FGA build number
1664
Describe the bug
Playing on Nox. FGA always worked flawlessly until this event, when I tried creating new setups for farming, but no matter what I do, I can't select them, as shown in the video. Old setups can be selected and run fine, but any new ones, in this case the "Vlad 1-3-1" can't be chosen no matter what I do.
I apologize if this is a Nox issue and not FGA's fault, I just couldn't find anything about it.
Video
https://user-images.githubusercontent.com/104159986/164972598-6de9eda4-1559-4aee-8f26-988170a7bf1a.mp4
Device model
Nox <IP_ADDRESS>
Android version
7
Screen size
1600x900
RAM
3GB

Like this?

{"support_mode":"Preferred","support_pref_servant_list":["Artoria (Caster)"],"autoskill_cmd":"bcdgh1i14,#,ef5,#,x21de1f1a14","autoskill_name":"Vlad 1-3-1","also_check_all":true,"autoskill_support_class":"Caster","battle_config_server":"Jp"}

Yes, but I can't reproduce it with that file either.

Thanks anyway, at this point I'll assume it's somehow Nox's fault. I'm gonna try a fresh install soon to see what happens.

I dont know if there is anything about the names of my files but something I noticed is that I cant access anything other then the top 6 ones and when I made a test file it was still only the top 6 that was accessible.
A fresh install but this time its android9 instead of android7 which have worked for me before on nox.

This is also a problem with Oneplus 7 phone. There's a dead space where an option can't be clicked. I had to create another profile to be able to scroll through options and pick it.


Logged json missing bracket

When logging json messages with objects that contain a collection of objects, a bracket gets dropped, making the json invalid. I have tested with a json object that has an empty collection, and a json object that has a collection of strings, and both of them are logged perfectly. Example:
// this is how the json object should look like
{
    "approvedDateTime": null,
    "approverAlias": null,
    "contentDescription": null,
    "description": null,
    "expectedCommunicationFrequency": null,
    "expirationDateTime": null,
    "id": "db84cbc8-12b0-4149-b670-97561fab68fe",
    "name": "Graham, Donnelly and Leffler",
    "owners": [], // populated collections of values does not affect the printing.
    "sponsors": [],
    "state": 0,
    "topicLocales": [{  // this is my collection of objects. If this were empty, this works.
        "approvedDateTime": null,
        "approverAlias": null,
        "createdBy": null,
        "createdDateTime": "2016-10-18T17:33:12.5752723Z",
        "cultureName": "en-US",
        "footerLanguage": "en",
        "lastModifiedBy": null,
        "lastModifiedDateTime": null,
        "localizedDescription": "leverage magnetic e-markets",
        "localizedName": "Gusikowski-Miller",
        "state": 0
    }],
    "topicNamespaceId": "2fbba100-9f45-41ed-86b7-143e5b14d7c0",
    "topicTags": [],
    "createdBy": null,
    "createdDateTime": "2016-10-18T17:33:12.5752723Z",
    "lastModifiedBy": null,
    "lastModifiedDateTime": null
}

We have a template for the message that resembles this:
@"{{'timestamp': '{Timestamp:yyyy-MM-dd HH:mm:ss.fff zzz}', 'level': '{Level}', 'message': '{Message}', 'exception': '{Exception}'}}{NewLine}"
However the message that prints out is:
{
    'timestamp': '2016-10-18 17:33:12.622 +00:00',
    'level': 'Warning',
    'message': '{"eventId":1101,"eventName":"TopicCreated","message":"A topic has been created","state":{"approvedDateTime":null,"approverAlias":null,"contentDescription":null,"description":null,"expectedCommunicationFrequency":null,"expirationDateTime":null,"id":"db84cbc8-12b0-4149-b670-97561fab68fe","name":"Graham, Donnelly and Leffler","owners":[],"sponsors":[],"state":0,"topicLocales":[{"approvedDateTime":null,"approverAlias":null,"createdBy":null,"createdDateTime":"2016-10-18T17:33:12.5752723Z","cultureName":"en-US","footerLanguage":"en","lastModifiedBy":null,"lastModifiedDateTime":null,"localizedDescription":"leverage magnetic e-markets","localizedName":"Gusikowski-Miller","state":0}],"topicNamespaceId":"2fbba100-9f45-41ed-86b7-143e5b14d7c0","topicTags":[],"createdBy":null,"createdDateTime":"2016-10-18T17:33:12.5752723Z","lastModifiedBy":null,"lastModifiedDateTime":null}', //<-- missing bracket here
    'exception': ''
}

Currently using Microsoft.Extensions.Logging.AzureWebAppDiagnostics v1.1.0-alpha1-22167 alongside Newtonsoft.Json v9.0.1 to serialize the message before logging.

Can you give us a simple repro app, ideally on a github repo?

Hi Murat,
Thanks for the quick response. There would be quite a bit of effort involved to isolate the code we use for logging into a separate repo (we are currently on VSTS), and in doing so we might inadvertently remove the issue – is there any alternative information that you would need?
From: Murat Girgin<EMAIL_ADDRESS>Sent: Tuesday, October 18, 2016 11:15 AM
To: aspnet/Logging<EMAIL_ADDRESS>Cc: Wen Di Lim<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [aspnet/Logging] Logged json missing bracket (#503)
Can you give us a simple repro app, ideally on a github repo?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/aspnet/Logging/issues/503#issuecomment-254592619, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVaxmNE4NNrOiTj41cAKJi1xOcnru0XKks5q1QyNgaJpZM4KaF8y.

@wendilimMS I recommend starting a new app from template, add the dependencies as necessary and do basic logging to repro this.  If there's a bug in the framework somewhere, this shouldn't be hard to repro.
Unfortunately, not knowing your app, it's hard to see what may be going wrong, apart from that it may be a user error as a wild guess.

It would strange for it to be a user error considering that it only does not work for the case where the json contains a collection of objects. We have several other objects that have different properties, and the common failing point is that when we try to log an object that contains a collection of objects, the logged json contains a missing bracket. Would you be able to point me in any other direction of investigation other than "user error"?

From: Murat Girgin<EMAIL_ADDRESS>Sent: Tuesday, October 18, 2016 11:31:24 AM
To: aspnet/Logging
Cc: Wen Di Lim; Mention
Subject: Re: [aspnet/Logging] Logged json missing bracket (#503)
@wendilimMShttps://github.com/wendilimMS I recommend starting a new app from template, add the dependencies as necessary and do basic logging to repro this. If there's a bug in the framework somewhere, this shouldn't be hard to repro.
Unfortunately, not knowing your app, it's hard to see what may be going wrong, apart from that it may be a user error as a wild guess.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/aspnet/Logging/issues/503#issuecomment-254597552, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVaxmPGPNzAqPQHLIgF2cN6oKuXlCgRIks5q1RB8gaJpZM4KaF8y.

Sorry, I am not sure without knowing what your app does or how it uses the libraries.  If you're unable to provide simple repro steps or a repro app, we won't be able to debug it.  If this is the case, the most I can recommend you would be to debug the whole stack yourself (since it's open source, you can use the source code of your dependencies instead of the package even).

You can add other loggers to see if it is just the Azure Logger that has this issue.

Hi, I've set up a dummy project that reproduces the problem successfully: https://github.com/wendilimMS/AzureBugRepro/tree/master/AzureBugRepro.
To reproduce the issue, make a post to /api/values with the following input:
{
	"name" : "Some name",
	"valueCollection": ["7dfdc479-7b76-4a58-8c98-7d1afefa7256"],
	"objectCollection": [{
	    "name" : "Some other name",
	    "lastModified": "2016-10-18T20:53:45.488Z"
	}]
}

Please let me know if my user input is actually  incorrect.

This is most likely a bug in Serilog
The OutputTemplate you set gets passed directly to Serilog and they parse it here https://github.com/serilog/serilog/blob/32e0c9578db720add74720bceb62bd46967694c4/src/Serilog/Parsing/MessageTemplateParser.cs#L41

Ok, thanks. I'll log an issue with them.

Just checking out the sample app, this line is a bit questionable: https://github.com/wendilimMS/AzureBugRepro/blob/master/AzureBugRepro/LoggerExtensions.cs#L35
string message = JsonConvert.SerializeObject(info, JsonSerializerSettings);
logger.LogWarning(message);

If the logging pipeline is going to format the message into a field in a JSON object, won't this always end up escaped anyway?
To get the object through as structured data, if it's Serilog on the back-end, you can do:
logger.LogWarning("Some info {@info}", info);

I think regardless of the Serilog tokenizer's handling of the message, the fact that the payload is structured data will need to be communicated to the logger if the result is intended to be readable as JSON.

The logging pipeline itself does not format the message into a JSON object. I had a quick look at what the output of your suggestion would produce, and it seems to have simply inserted the object.
{'timestamp': '2016-10-20 22:49:07.228 +00:00', 'level': 'Warning', 'message': 'DiagnosticInfo`1 { EventId: 1001, EventName: "MyObjectCreated", Message: "An object has been created", State: MyObject { Name: "Some name", ValueCollection: [7dfdc479-7b76-4a58-8c98-7d1afefa7256], ObjectCollection: [MyObjectDetail { Name: "Some other name", LastModified: 10/18/2016 20:53:45 }], LastModified: null, PropertyA: null, PropertyB: null, PropertyC: null, Option: null } }', 'exception': ''}

As you can see, the message in question will still not be valid json, or in any deserializable format. The idea is to be able to parse the logged message to obtain various property values as well as to be able to deserialize the original object as well, hence why we required json in the first place.

Thanks for the follow-up @wendilimMS; you're quite right, unless Serilog is configured to log JSON the result still won't be JSON, as you pointed out.
You could do this to get the JSON string through untouched:
string message = JsonConvert.SerializeObject(info, JsonSerializerSettings);
logger.LogWarning("{Message:l}", message);

But this is still side-stepping the main issue - Serilog really needs to be configured with a JSON formatter to work nicely in this scenario.
For example, when you format in {Exception}, you'll hit problems if the exception message contains " or \. If the exception message is, for example, Could not open "file.txt", then when it's inserted into the template the " characters will result in malformed JSON.
Perhaps this does come back to the Azure web app diagnostics API?
The configuration currently looks like:
loggerFactory.AddAzureWebAppDiagnostics(new AzureWebAppDiagnosticsSettings
{
     BlobName = "api.txt",
     OutputTemplate = @"{{'timestamp': '{Timestamp:yyyy-MM-dd HH:mm:ss.fff zzz}', 'level': '{Level}', 'message': '{Message}', 'exception': '{Exception}'}}{NewLine}"
});

If the output is wanted in JSON format, how about:
loggerFactory.AddAzureWebAppDiagnostics(new AzureWebAppDiagnosticsSettings
{
     BlobName = "api.json",
     Formatter = Formatters.Json
});

Under the hood, this would configure Serilog with a JSON output formatter (e.g. CompactJsonFormatter), and issues like the exception message encoding would go away.
(I say this without knowing whether JSON logging is aligned with the goals of Azure Web App diagnostics, of course.)
Does this help?
Cheers,
Nick

Thanks Nick, getting the JSON string through untouched seems to be a good enough work around (until some other input breaks it). It would be good if AzureDiagnostics did have an option to specify that the message requires a JSON formatter, but for now this will have to do.

We are closing this issue because no further action is planned for this issue. If you still have any issues or questions, please log a new issue with any additional details that you have.


Estimators could be replaced by zoomed fft?

Hello,
very well written repo and interesting piece of hardware with incredible bandwidth...
One little question so far:
Why did you use this "basic" cubic interpolation to improve the resolution of the fft? There are solutions like zoomed FFT and CZT, did you see any advantages in the cubic interpolation?
Best regards
Sebastian

Hi Sebastian,
Thank you for your positive feedback!
Modified quadratic interpolation in the power-scaled magnitude response (with a tuning parameter optimized to the pulse waveform, i.e., the window function) turned out to be a very efficient method.
Refining the resolution using a single zoom FFT or iteratively refining the resolution using multiple zoom FFTs has a higher computational cost to achieve a sufficient-or at least comparable-resolution.
Regards
Lukas

Hi Lukas,
I think it depends one the hardware. Taking the log10 of a large spectrum is a bottleneck on my microcontroller. On PC (x86 or higher) side there are native processor floating point commands for log10. But the limited instruction set of a CortexM FPU has  the opportunity to do a faster log2 approximation. But if I get it right, the log10 instructions could minimized if the peak is searched in non log and only the desired support points will be calculated.
I have a hard time to understand whats difference it makes to have no IQ receiver (two channel). If I get it right, your spectrum approximation must be two times more precise because you have only information about -90 to 90° and not the full quadrant information from tan2. In your paper in Figure 4. there is "coarse ToF estimate". This estimate is based on the frequency sweep and phase information based on this sweep. In my opinion no ToF, because it is based on FMCW and any air condition cancel out. Or is there a special case for just I receivers?
Best regards
Sebastian

Hi Sebastian
You don't need to peak search in the log radar echo.
You only need to compute y^p (with a fractional p) for the samples nearest the peak, which is somehow computationally intensive (but it's just for three values).
As the radar echo is a causal system, you don't need an IQ receiver provided sufficient bandwidth [otherwise, you have interfering sidelobes of the mirrored components h(t)=h^*(-t)]. With IQ data, the reading is more precise; however, as I and Q data are partially correlated, the increase in SNR should be significantly less than 3 dB).
I didn't get your last question. There is a coarse estimate based on the pulse position (i.e., the intermediate frequency) and a fine estimate based on the pulse phase. The ambiguous phase is unwrapped using the coarse pulse position estimate.
Regards
Lukas

Just for reference, the algorithm behind the work of Lukas will be available in our Radar Sensors soon. They use a 528 MHz Cortex-M7 and achieve a Measurement-Rate of 1kHz, including the fixed-point FFT, interpolations and estimator.
This would probably never have been possible using an iterative FFT approach. But I agree, that it takes some optimization and approximation (of some functions such as atan2 or the y^p mentioned by Lukas) to get it working well on an embedded system.
Best Regards
Simon (https://www.2pi-labs.com)

@l-pio I am still a bit confused. Why do the phase estimator classes use the wording "magn_response" and "phase_response": https://github.com/l-pio/mmwranging/blob/d2770aa3424fc998652239738fb311705e4d923e/mmwranging/estimator.py#L7
What make sense in my point of view. But the input seems to be time domain data:
https://github.com/l-pio/mmwranging/blob/d2770aa3424fc998652239738fb311705e4d923e/mmwranging/processor.py#L340
Maybe I am confused between time domain and frequency domain its used here in a different way as I suspect.
@skuep2 That sounds great! With a maximum size of 4096 or did you mange it with the 10001 samples from your example?
In my project I am dealing with multipath and clutter from multitarget, measurement speed is about 2 kHz to come down to a 30 µm resolution. But because of the clutter the resolution is not my problem.
Best regards
Sebastian from Leipzig

From a system theory viewpoint, it is advantageous to understand the input data as frequency domain data, as every sample refers to a certain RF frequency. Then, you have a common description for pulse radar and FMCW radar, where the FMCW radar is like a pulse radar with pulse compression.
Regards
Lukas


Remove dependency on Google Fonts

Hi folks,
as you perhaps have already seen in the news, a court decision has made the use of hosted Google Fonts a legal issue.
For our own instance of transfer.sh, I've manually modified the frontend to simply remove the reference to fonts.googleapis.com - but this should not be the preferable way.
The folks at Cachet added a config flag ("enable 3rd party dependencies"), which - in the case of this frontend - is probably not so easy to implement (except for having two docker images?).
The best approach should be to simply include the fonts locally during build. I discovered that there is a grunt package to copy the font, but as I'm no developer myself, I'm unable to integrate it properly.
Thanks for considering this request for additional privacy!
Best,
Anton

hi @antondollmaier , thanks for raising this issue
I will try to work on it as soon as possible


Update spanish translation

Thanks Luis :+1:
Unfortunately this didn't make it in time for the release :(
My bad indeed for not informing you earlier


[buttery-node] Reading from parsed body doesn't work when parsed body is a string

This is due to trying to get the body in buttery-node's rpc.ts.
It's time to ditch this method of getting the post body.

Sorta fixed? I decided that if users use non-json body-parser, they can figure out what the deal is.
The easy solution for users is to simply not use body parser for buttery at all. Body parser is only necessary when some middleware requires a body to be defined, e.g. passport.

The above weirdness w/ bodyparser has been documented, so I'm gonna consider this to be good enough for alpha.


Is there common code between BLEServer and BluetoothLE?

Meaning, can I use both packages to find and get characteristics and then pass the characteristics to a common device processing class?  Our application is designed to work with devices that could be in peripheral or master mode depending on the customer's needs.  I'd like to be able to write code using each package to find and discover the devices depending on which mode the app is in and then pass an IDevice and 2 IGattCharacteristic objects to the common class for processing.  Is that possible?

There is no common code between them.  What you need to do isn't complicated though.  You will just have to do it in your logic in your app to translate between the two.

That is what I thought.  Thanks for the quick reply!
On Wed, Mar 15, 2017 at 9:17 AM Allan Ritchie<EMAIL_ADDRESS>wrote:

There is no common code between them. What you need to do isn't
complicated though. You will just have to do it in your logic in your app
to translate between the two.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aritchie/bluetoothle/issues/27#issuecomment-286737805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUYXgO3q9pFFbMQQrwv1TwmKcXo-QY02ks5rl-TXgaJpZM4Md67l
.

--
Mark Curtis
Senior Software Engineer
BlackBox Biometrics, Inc.
Office:<PHONE_NUMBER>
International: +1<PHONE_NUMBER>
http://www.b3inc.com/


feature request

could you eventually add tracking for
gil earned per map potentially per floor as well since the other stuff in this request is per floor
on shifting dungeons what each floor type was(including if it had a zap) and on doors what way the leader went
per floor how many thieves dropped as loot

by per floor i mean like when you hover over the checkmark displaying the results of that map per floor

Yeah, I'll probably try to cover everything including loot and random events at some point but first release with stats will just cover the basics: what floors you got to, types of summons, and gil earned.


Added code for #281

script name - tfHub_sentence_similarity.py
What have you Changed
I have added code to measure semantic sentence similarity using Universal Sentence Encoder from TfHub.
Issue no.(must) - #281
Self Check(Tick After Making pull Request)

[x] This issue was assigned to me.
[x] One Change in one Pull Request
[x] My file is in proper folder
[x] I am following clean code and Documentation and my code is well linted with flake8.
[x] I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.
Join Us on Discord:- https://discord.gg/JfbK3bS
acknowledgement

[x] I have tested the script and distributing it under MIT license.

Please review.


"No serializable introspection present for type. Consider adding Serdeable" after upgrade to Micronaut 4.0.0-M2/M5

Expected Behavior
The framework should deserialize an object annotated with @io.micronaut.core.annotation.Introspected.
Actual Behaviour
Deserialization fails with an error:

Error "i.m.http.server.RouteExecutor - Unexpected error occurred: No deserializable introspection present for type: SomeDto someDto. Consider adding Serdeable.Deserializable annotate to type SomeDto someDto. Alternatively if you are not in control of the project's source code, you can use @SerdeImport(SomeDto.class) to enable deserialization of this type."

Steps To Reproduce
micronaut-problem 3.0.0-M1 (3.0.0-M2 too) pulls in micronaut-serde-api and micronaut-serde-jackson. After excluding these dependencies the error does not occur:
<dependency>
  <groupId>io.micronaut</groupId>
  <artifactId>micronaut-jackson-databind</artifactId>
</dependency>
<dependency>
  <groupId>io.micronaut.problem</groupId>
  <artifactId>micronaut-problem-json</artifactId>
  <exclusions>
    <exclusion>
      <groupId>io.micronaut.serde</groupId>
      <artifactId>micronaut-serde-api</artifactId>
    </exclusion>
    <exclusion>
      <groupId>io.micronaut.serde</groupId>
      <artifactId>micronaut-serde-jackson</artifactId>
    </exclusion>
  </exclusions>
</dependency>

Likely related:
https://github.com/micronaut-projects/micronaut-liquibase/issues/342
Environment Information

JDK 17
micronaut-parent 4.0.0-M2 with property "micronaut.version" set to 4.0.0-M5
micronaut-problem-json 3.0.0-M1
micronaut-jackson-databind

Example Application
No response
Version
4.0.0-M5

@phlppnhllngr thanks for reporting. We will fix this as soon as possible.

@phlppnhllngr Have you tried this with the GA release of Micronaut 4.0.0? If it is still a problem can you please provide an example app with a test that exposes the error?
This seems related to #291. I have an example that works at https://github.com/wetted/problemjson291 assuming I understand the issue. Otherwise I need a breaking example.

Hello @wetted, @StefanSrf just provided an example in #291, please check if you can reproduce the bug with that. If not, i will create a demo project myself and upload it.