Cannot read property 'querySelector' of null

Uncaught TypeError: Cannot read property 'querySelector' of null
at setup (index.js:265)
at Object.../node_modules/xo-buttonjs/public/js/button/index.js (index.js:278)
at webpack_require (bootstrap a2d3747…:19)
at Object.0 (index.js:5)
at webpack_require (bootstrap a2d3747…:19)
at 0 (bootstrap a2d3747…:39)
at bootstrap a2d3747…:39

Did you get past this error?

I'm currently working with a very minimal setup to toy around with the paypal api, checkout, login with paypal, etc and i am getting the same error.
I can't really tell what it stops from working at all, so far the checkout seems to work as expected.
Using the current version of https://www.paypalobjects.com/api/checkout.js


TextEditorComponent.measureDimensions is deprecated.

Assigning editor 393's height explicitly via position: 'absolute' and an assigned top and bottom implicitly assigns the autoHeight property to false on the editor.
This behavior is deprecated and will not be supported in the future. Please explicitly assign autoHeight on this editor.
TextEditorComponent.measureDimensions (<embedded>:6897:26)
TextEditorComponent.becameVisible (<embedded>:6181:18)
TextEditorComponent.checkForVisibilityChange (<embedded>:6879:22)
atom-text-editor.attachedCallback (C:\Users\mushe\AppData\Local\atom\app-1.17.0\resources\app\src\text-editor-element.js:87:22)
<unknown> (<embedded>:1080:39)

Thanks for reaching out!
This looks like a duplicate of https://github.com/atom/atom/issues/13653, please check out that issue for suggestions to get around the error /cc https://github.com/atom/atom/issues/13653#issuecomment-275877727.
Additionally, we require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


Working with another contributer

Is there any special provisions for working in a team pushing the theme from two branches?

There isn't a real way to handle branches. The solution for now is to duplicate the theme and push your changes to that theme instead by using theme_id in your configuration file.


0.26 sensu server start problem

my cookbook first setups and starts the server and after that the client is configured and started. This was working fine in the past but 0.26 seems to need client attributes for the server:
/opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-settings-9.1.0/lib/sensu/settings/loader.rb:177:in `load_client_overrides': undefined method `[]' for nil:NilClass (NoMethodError)
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-settings-9.1.0/lib/sensu/settings/loader.rb:186:in `load_overrides!'
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-settings-9.1.0/lib/sensu/settings.rb:30:in `load'
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-settings-9.1.0/lib/sensu/settings.rb:43:in `get'
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-0.26.0/lib/sensu/daemon.rb:133:in `load_settings'
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-0.26.0/lib/sensu/daemon.rb:53:in `initialize'
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-0.26.0/lib/sensu/server/process.rb:42:in `initialize'
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-0.26.0/lib/sensu/server/process.rb:30:in `new'
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-0.26.0/lib/sensu/server/process.rb:30:in `run'
        from /opt/sensu/embedded/lib/ruby/gems/2.3.0/gems/sensu-0.26.0/exe/sensu-server:10:in `<top (required)>'
        from /opt/sensu/bin/sensu-server:22:in `load'
        from /opt/sensu/bin/sensu-server:22:in `<main>'

@runningman84 thanks for reporting this regression. I've opened sensu/sensu-settings#45 for a fix.

Fix released in Sensu 0.26.1


Updated influx CLI docs with mapped environment variables

Closes #656
Updated influx CLI docs with mapped environment variables. It uses a shortcode that points to a section on the influx landing page that talks about mapped environment variables and how they work.

[x] Tests pass (no build errors)
[x] Rebased/mergeable

Nice!


add MessageTimestampFromCtx

Exposing Kafka internal timestamp of the message through message context

Hello, @eafzali. Thanks for the contribution again ;)


Fixes for CustomLog, AUTHORS entry, extended changlog

I noticed the style and tried to keep it mostly; I missed some places though. Thanks for fixing them.
I have no complaints to the changes.
There is one improbable breaking change: setting lombok.log.fieldName=private used to be valid (and it compiled!); similarly lombok.fieldNameConstants.innerTypeName=42, lombok.copyableAnnotations+=int.float.package.class, and lombok.copyableAnnotations+=a-b-c.
I also found two bugs regarding TypeName.

any idea when this might get merged?

@rzwitserloot Is there anything preventing to merge this?


Disables x frame options

What's this PR do?

Saves clickjacking security settings into a feature
Disables X-Frame-Options header

What are the relevant tickets?

Fixes #5742
A part of #5392

:+1:


add configurable ml pipeline

Part of: https://issues.redhat.com/browse/RHOAIENG-1707
use the following dspa to test the changes:

dspa.yaml
apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: sample
spec:
  dspVersion: v2
  apiServer:
    deploy: true
    image: quay.io/hukhan/ds-pipelines-api-server:dynamic-ml-endpoint-1
    argoLauncherImage: quay.io/hukhan/kfp-launcher:dynamic-ml-endpoint-1
    argoDriverImage: quay.io/hukhan/kfp-driver:dynamic-ml-endpoint-1
  persistenceAgent:
    deploy: true
    image: gcr.io/ml-pipeline/persistenceagent:2.0.2
  scheduledWorkflow:
    deploy: true
    image: gcr.io/ml-pipeline/scheduledworkflow:2.0.2
  mlmd:
    deploy: true
    grpc:
      image: gcr.io/tfx-oss-public/ml_metadata_store_server:1.14.0
    envoy:
      image: gcr.io/ml-pipeline/metadata-envoy:2.0.2
  database:
    disableHealthCheck: true
    mariaDB:
      deploy: true
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'
  mlpipelineUI:
    image: gcr.io/ml-pipeline/frontend:2.0.2
  workflowController:
    deploy: true
    image: gcr.io/ml-pipeline/workflow-controller:v3.3.10-license-compliance

/hold

/hold

I forgot what this is. Can we close it and its corresponding Jira?

we still need to resolve this, but since last I did this, I've found an easier way to implement this without exposing these fields in the IR, so this pr can be closed


TypeScript does not narrow union type with more than 25 possible members

TypeScript Version:  3.5.1

Search Terms:
25 union members, narrow union
Code
export interface T1 { type: "t1" }
export interface T2 { type: "t2" }
export interface T3 { type: "t3" }
export interface T4 { type: "t4" }
export interface T5 { type: "t5" }
export interface T6 { type: "t6" }
export interface T7 { type: "t7" }
export interface T8 { type: "t8" }
export interface T9 { type: "t9" }
export interface T10 { type: "t10" }
export interface T11 { type: "t11" }
export interface T12 { type: "t12" }
export interface T13 { type: "t13" }
export interface T14 { type: "t14" }
export interface T15 { type: "t15" }
export interface T16 { type: "t16" }
export interface T17 { type: "t17" }
export interface T18 { type: "t18" }
export interface T19 { type: "t19" }
export interface T20 { type: "t20" }
export interface T21 { type: "t21" }
export interface T22 { type: "t22" }
export interface T23 { type: "t23" }
export interface T24 { type: "t24" }
export interface T25 { type: "t25" }
export interface T26 { type: "t26" }
export interface T27 { type: "t27"; value: number }

export type T = T1 | T2 | T3 | T4 | T5 | T6 | T7 | T8 | T9 | T10 | T11 | T12 | T13 | T14 | T15 | T16 | T17 | T18 | T19 | T20 | T21 | T22 | T23 | T24 | T25 | T26 | T27;

function make(type: string): T | null {
    switch (type) {
        case "t1":
        case "t2":
        case "t3":
        case "t4":
        case "t5":
        case "t6":
        case "t7":
        case "t8":
        case "t9":
        case "t10":
        case "t11":
        case "t12":
        case "t13":
        case "t14":
        case "t15":
        case "t16":
        case "t17":
        case "t18":
        case "t19":
        case "t20":
        case "t21":
        case "t22":
        case "t23":
        case "t24":
        case "t25":
        case "t26":
            return { type };
    }

    return null;
}

Expected behavior:
I would expect { type } to be narrowed to T1 | T2 | ... | T26 and the code compile.
Actual behavior:
TypeScript instead infers { type } to be T and fails to compile as T27 also requires a value property. However, if any of the cases are removed in order to bring the number of union type members down to 25, TypeScript correctly narrows { type } to T1 | T2 | ... | T25 (assuming T26 was removed) and compiles the code.
Playground Link: https://www.typescriptlang.org/play/index.html#code/KYDwDg9gTgLgBASwHY2FAZgQwMbDgFQEY4BvOGATzGAC44AiGQ+uAXwChRJZEU0tcBAEylyVWgxhCWHLtHjJUGHHnwBmUZWp1GamZ3DzeSgaoAsm8Tphn9cnov4qCAVkvbJLu4Yd9lg-AA2dwlGQO9uBT9TAgB2EOtYiKNHf1UADgTJdOTfE2d8AE4sxkLcqPyAwgAGEqZq8uMnKuIyLVCmZjYDSKa0gkIRNqtJQcbUmKINYY9GQj1u+wrm1UILGY618eiCwjcN6z3tytXgg9HwxZ9l-qJ487mkq96J3cyHphznlJ2q4o-CGVvnkVsJah8hA1gTdJkJWmJZlIurJrn1YUMER0hNJoWiCkJppjrATjqD8EJ1kTJBTSbchPsqYx6bTYWdGVJLiiXr9VEJ7uy+fQANxwABumAANgBXCRIKUAWwARmhuj0jO0CHAALwDOAAH2E+oIGgN+AsprcpuCpvipsypuKppqRqIxCdIidJoG5oGloG1oGtoG9oGjrBLrhEY9wi95J95L95ID5NiQvY7HQUqQ2BgCAgSDg8swAGtgAAKdp0ADOMCgyAA5gBKOj4I1yiUS0jsOA9uBVgDuCBg2AAFnAK+JG13ezO4NhMFW8HN6DRu7Oe-PF9SV2v15ulzA9Kv1xuFwfbMeT-vPDuT3Oz5Jwpe9w-GEln7Pr4wch+Z1+YGUv69v+NS3ler6dGBL5bnM0hAaeMFMEeu6fhBWzwfeiFHBhIFPihf5oe++HAWhP7EQhB6AlBqGIZC1EEbRzA4RB2L0SRtHIXe-40sxtFeLxB5CHhd4zlAwAwFKUAFhsbBpjOHAoWJElSXA7YSmmrBAA
Related Issues:

This is an intentional cutoff to prevent later steps from becoming too combinatorially explosive.

I should add that prior to 3.4, this didn't even work for n = 2 😉

Alright, that seems fair then 😄 It would be nice with some more transparency around cases like this though, similar to how the compiler complains when union types become too complex. It wasn't immediately obvious why the compiler started complaining when the 26th case was added to the actual code 🙈
Thanks for the answer!

I agree it'd be nice. Unfortunately this happens deep inside assignability checking and there might not actually end up being a downstream error when the assignability check fails as in this case, so it'd sometimes issue false positive errors unless we had some more formal causality analysis built in to the typechecking process.


CB-11154: (Android, iOS) Add IANA timezone

Platforms affected
Android, iOS
What does this PR do?
Add IANA timezone
What testing has been done on this change?
Checklist

[X] Reported an issue in the JIRA database
[X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[x] Added automated test coverage as appropriate for this change.

Cordova CI Build has one or more failures.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

Cordova CI Build has completed successfully.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 8.1 Store
Link
Link
Link

Windows 10  Store
Link
Link
Link

Windows 8.1 Phone
Link
Link
Link

iOS
Link
Link
Link

Android
Link
Link
Link

Who can merge it ?

Youhou

Hello @shazron, @stevengill
Can you review this PR?
You can see more documentation for IANA Timezone (naming convention for time zones):

https://en.wikipedia.org/wiki/IANA_time_zone_database
https://www.iana.org/time-zones

You can see more example:

America/Los_Angeles
Europe/Paris
America/New_York

Thanks for this plugin ❤

Reviewing this now.

Cordova CI Build has one or more failures.
Commit     - Link
Dashboard - Link

Builder Name
Console Output
Test Report
Device Logs

Windows 10  Store
Link
Link
Link

iOS
Link
Link
Link

Android 4.4
Link
Link
Link

Android 5.1
Link
Link
Link

thanks @shazron 👍


Is this project still under development?

As title says.  There are already quite some bugs/missing documentation or deprecations (pandas!). There are pull requests which are were opened in January!

Take a look at plotnine, which was originally forked from ggpy (now mostly rewritten):
https://github.com/has2k1/plotnine

plotnine seems to be working well!


update our bazel BUILD file handling logic

We need to update the build rules we're looking for.

add dart_analyzed_library
waiting until a dart file is opened to check to see if there's a BUILD file at the root and the project is not yet considered a dart project (the BUILD file scanning will have false negatives)

fixed


[FEATURE] Make the dimensions of linear spaces distinguishable

When doing structured pruning, sometimes we need to apply the same mask before or after different modules if they have the same input or output space. Say, if we are trying to cut off some dimensions of the model, we would apply masks before all modules that take a vector in $\mathbb{R}^{\mathrm{dim\_model}}$ as input, and after all modules that have a vector in $\mathbb{R}^{\mathrm{dim\_model}}$ as output.
However, we cannot directly use code like if(module.dim_in==dim_model) because there may be other parameters being equal to dim_model accidentally, and some linear layers take one of the parameters as dim_in. So, in the current approach, I can only come up with the solution of specifying all the modules that take dim_model as the dimension of its input or output space for each model, which makes the code long, hard to maintain, and hard to be extended for future models.
So I suggest a solution that, for all modules, their initialization parameters which describe the dimension of "linear spaces used by itself or its submodules" can be either type int, or a newly created type SpaceDim (maybe there's a better name). If one of the init parameters describing a dimension in a module is of type int, the module generates a SpaceDim instance when initializing itself, and passes the instance to its submodules as init parameters if necessary. Thus, the parameter becomes traceable: we can try to write if(module.dim_in==model.dim_model), because now all linear spaces taking a vector in $\mathbb{R}^{\mathrm{dim\_model}}$ as input will have its dim_in being same instance as model.dim_model.
In detail, as far as I can see, the modified code could be like the following:

Newly created class:

class SpaceDim:
    ...

For __init__ of most of the modules:

def __init__(self,
    dim_xx,
    ...
):
    if isinstance(dim_xx, int):
        self.dim_xx = SpaceDim(dim_xx)
    else:
        self.dim_xx = dim_xx
    ...
    self.sub = SubModuleClass(self.dim_xx, ...)
    ...

For modules with tensors as their parameters directly (let's take Linear as an example):

def __init__(self,
    dim_in,
    dim_out,
    ...
):
    if isinstance(dim_in, int):
        self.dim_in = SpaceDim(dim_in)
    else:
        self.dim_in = dim_in
    ...
    self.weight = ...(torch.empty((self.dim_out.num, self.dim_in.num), ...), ...)
    ...

Furthermore, I think this should work well along with the upcoming protocols: actually, almost every number appearing in the protocols matches an instance of SpaceDim precisely.


example results?

@CODEJIN  : can you plz share results from using speaker embedding for tts synthesis

sorry, found it https://codejin.github.io/Glow_TTS_Demo/index.html


feat: bad blocks chain extension

Closes https://github.com/opentensor/subtensor/issues/467

Improves chain spec logic organisation
Adds option to specify bad_blocks in chain specs

Tested:

Node will log attempts to import bad blocks a few times before banning the peer trying to propagate the bad block.

Nice ! @orriin  can you please add instructions to test this ?

Nice ! @orriin can you please add instructions to test this ? It be also be helpful to try using this to sync an archive node on finney

Sync Alice and Bob some blocks
Stop Bob
Add latest block hash to bad blocks
Regen chain spec
Start Alice again

What happens if all the peers have the badblocks? Does this mean it wont be able to sync as it is banning a peers?

Yeah, it can't sync from them anyway because they have bad blocks. Dw though, the ban list is cleared when the node restarts.


chore: fix typos in error messages

Summary
There are seven instances of the typo "commpleted" (rather than "completed") in PowerVCF.psm1
Type

[ ] Bugfix
[ ] Enhancement or Feature
[ ] Code Style or Formatting
[ ] Documentation
[ ] Refactoring
[x] Chore
[ ] Other
Please describe:

Breaking Changes?

[ ] Yes, there are breaking changes.
[x] No, there are no breaking changes.

Test and Documentation

[x] Tests have been completed.
[x] Documentation has been added or updated.

Issue References

Additional Information

I'll review this one Monday. Let is like this needs to be split since there are two commits with different topics. Easy enough to cherry-pick this.
Assigning to myself and marking as draft.


feat: error log formatting in auth login

[x] error log formatting in auth login
[x] version bump
"@contentstack/cli-audit": "~1.6.4",
"@contentstack/cli-auth": "~1.3.21",
"@contentstack/cli-cm-bootstrap": "~1.9.4",
"@contentstack/cli-cm-branches": "~1.1.2",
"@contentstack/cli-cm-bulk-publish": "~1.4.8",
"@contentstack/cli-cm-export": "~1.11.6",
"@contentstack/cli-cm-clone": "~1.10.7",
"@contentstack/cli-cm-export-to-csv": "~1.7.2",
"@contentstack/cli-cm-import": "~1.16.1",
"@contentstack/cli-cm-migrate-rte": "~1.4.18",
"@contentstack/cli-cm-seed": "~1.7.7",
"@contentstack/cli-command": "~1.2.19",
"@contentstack/cli-config": "~1.6.5",
"@contentstack/cli-launch": "~1.0.20",
"@contentstack/cli-migration": "~1.6.1",
"@contentstack/cli-utilities": "~1.7.0",

Please update the patch version of the plugins whose dependencies have minor version updated

@cs-raj done


Metrics and losses computation

Hi,
I having hard time understanding how the different metrics are calculated (iou, f1, precision recall).
For the IoU score, what do A and B correspond to in the documentation? Concerning precision and recall, the values TP, FN, FP, TN correspond to pixels of the predicted output? and for the F1 score it would have been the same to calculate it with the classic formula 2TP/(2TP+FN+FP)?
Thank you for your explanations!

A and B represent the two sets, so in this case, the ground-truth and prediction segmentation maps.
True positive, False Negative, False positive, and True negative come from calculating a confusion matrix. They represent what the model predicts for each class category (the pixels, as you said), and what the actual ground-truth is.
The F1 (or Dice) score is calculated in the same way as you have in your comment, but with smooth to deal with dividing by zeros and beta which "is chosen such that recall is considered beta times as important as precision" - Wiki
# calculate score
    tp = backend.sum(gt * pr, axis=axes)
    fp = backend.sum(pr, axis=axes) - tp
    fn = backend.sum(gt, axis=axes) - tp

    score = ((1 + beta ** 2) * tp + smooth) \
            / ((1 + beta ** 2) * tp + beta ** 2 * fn + fp + smooth)
    score = average(score, per_image, class_weights, **kwargs)

    return score


Fix name of send method (set --> send)

Also remove the get method and instead move the header data inside the previous get method.

omg, thanks for that!


KEB: ClusterState

Description
Every change in the SKR should make a immutable record in the DB which descries such SKR state with the following information:

kyma config
cluster config
type (runtime, shoot)
timestamp
operationID, runtimeID
kymaVersion, k8sVersion

It will be created on:

success provisioner call

@piotrmiskiewicz Please add labels!


Support decorators metadata

See discussion in #64

This would not be supported. See https://github.com/vitejs/vite-plugin-react-swc/pull/64 for more info


manifest.json is not included

I am building a chrome extension and use this plugin to zip the released directory. Currently all the content under release directory is zipped except the manifest.json. And the manifest.json is generated using webpack-version-file-plugin like so:
new VersionFilePlugin({
    packageFile: path.resolve(__dirname, '../package.json'),
    template: path.resolve(__dirname, '../src/manifest.json'),
    outputFile: path.resolve(__dirname, '../build/pro/manifest.json')
}),
new ZipPlugin({
    filename: `${pkg.name}-${pkg.version}.zip`
})

Could you help me to solve this issue? Thank you!

I'm having the same problem, no JSON files are included in the compilation.assets.
I tried adding json-loader to possibly allow json files in webpack builds... but that doesn't do anything.
It seems the plugin doesn't receive the json file in the first place.

+1

+1

+1 also looking to include the manifest in my zip

+1 also public folder is ignored, I think the entire build folder should be zipped

+1  any solution？

Non webpack alternative. Very simple...
https://www.npmjs.com/package/zip-build


Dependency to pandas and matplotlib not mentioned on "Use Python in Power Query Editor" page

On the page "Use Python in Power Query Editor it says that pandas is required at point 6. after the Python example script and it sounds like it is because of the example itself, because pandas is used in the Python script
But even with an empty Python script you still get an error message that the Python wrapper requires import os, pandas, matplotlib. See screenshot.
This dependency on pandas and matplotlib should be mentioned right at the beginning ideally in the section Install Python as this is general requirement to work with Python in Power BI.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: fdd46971-2ea5-9271-3b2a-824efc1821e1
Version Independent ID: 68669cdb-5e4d-bb96-d2d5-bdad4088fb03
Content: Use Python in Power BI Power Query Editor - Power BI
Content Source: powerbi-docs/connect-data/desktop-python-in-query-editor.md
Service: powerbi
Sub-service: powerbi-ai
GitHub Login: @otarb
Microsoft Alias: otarb

Thanks for your comment, @hski-github. This issue has been assigned to the doc author for review.

Hi @hski-github,
Thank you for your comment. I'm looking into this issue and will get back to you once I have an answer.
Kesem

Hi @hski-github,
Thanks you for your suggestion. I amended Use Python in Power Query Editor so that pandas is mentioned as a prerequisite.
The change will be visible shortly.
Thanks again,
Kesem


Implement Node.JS code generator

As the headline says.  cc: @tbetbetbe

Isn't this done now?

Yes, by #135. Forgotten to be marked from the PR.


Errors building with SLEPc

It looks like the following line overwrites some of our makefile variables: https://github.com/mfem/mfem/blob/f97a770dcaa7498c93069ca7f27d25d9655acd86/config/defaults.mk#L393-L394 and that causes problems.
Removing this line will probably cause issues when SLEPc is built with extra dependencies (dependencies other than PETSc) becasue SLEPC_EXTERNAL_LIB is defined indirectly using variables like ${ARPACK_LIB}. To get the right expansion we can parse the file $(SLEPC_VARS) without including it locally but parsing it in a separate make process and printing the required values. This parsing-and-printing can be done easily with a makefile like this:
ifeq ($(FILE),)
  $(error FILE is not set)
endif

include $(FILE)

print-%:
#	$(info $(value $*))
	$(info $($*))
	@true

Another potential issue: since the variable SLEPC_INCLUDE is defined using the variable SLEPC_DIR, it ends up using relative path with the default settings and we get include flags like -I./../slepc/include. This may cause issues when building MFEM out-of-source. We should probably just set SLEPC_DIR to be an absolute path:
SLEPC_DIR := $(abspath $(MFEM_DIR)/../slepc)

Thanks, I am having a look. Do you have an example of a specific makefile variables that is overwritten?

Another potential issue: since the variable SLEPC_INCLUDE is defined using the variable SLEPC_DIR, it ends up using relative path with the default settings and we get include flags like -I./../slepc/include. This may cause issues when building MFEM out-of-source. We should probably just set SLEPC_DIR to be an absolute path:

Good point. It seems like PETSc already uses an absolute path from petscvariables. We can add that for SLEPC_DIR.

Some of the variable that get overwritten are HYPRE_LIB, METIS_LIB, PETSC_LIB -- these are overwritten by the inclusion of (A) ${PETSC_DIR}/${PETSC_ARCH}/lib/petsc/conf/petscvariables from (B) ${SLEPC_DIR}/${PETSC_ARCH}/lib/slepc/conf/slepcvariables. I noticed that some builds of SLEPc do not include A from B (e.g. on macOS) however on a Linux cluster where I was testing, it does.

I was thinking that the following would work on Linux
# Read the variable names in slepc_variables
SLEPC_DEP_TEMP := $(shell sed -n "s/$(SLEPC_LIB_VAR) *= *//p" $(SLEPC_VARS)|sed -n "s/\$${\([^}]*\)}/\1/gp")
# Parse the variables in slepcvariables
SLEPC_DEP := $(foreach dep,$(SLEPC_DEP_TEMP),$(shell sed -n "s/$(dep) *= *//p" $(SLEPC_DIR)/$(PETSC_ARCH)/lib/slepc/conf/slepcvariables))

but if the macOS builds work differently, it might not be very portable. Unfortunately I don't have access to macOS so I cannot test that.

I believe this issue is affecting me. I am installing mfem+petsc+slepc through spack.


[unsafe-assignment-rule] report problematic properties

We should report the property name (and the path down through nested properties to get to it) in the eslint error message to make fixing unsafe assignments easier.

I have implemented https://github.com/danielnixon/eslint-plugin-total-functions/issues/708, so this is now blocked on https://github.com/RebeccaStevens/is-immutable-type/issues/42


Fix size discrepancy between similar 3D controls

https://www.babylonjs-playground.com/#CBPTZ2
TouchHolographicButton is scaled much smaller than HolographicButton by default, which means placing them both in a scene requires non-uniform scaling between them, and requires knowledge of the custom scale size for both to be scaled the same.
I can see the appeal of having a control that is intended for XR be scaled for XR, but I feel there should be a consistent scaling between 3D controls. I know there's also issues with shader sizing if it is scaled, but I feel those can be worked around.
I'm not sure how other developers work, but so far my flow has included designing a scene in the playground with a helper scaling function, so when I want to test it in VR I switch a flag in the helper to resize and reposition everything for VR. Having TouchHolographicButton be pre-scaled means I have to write extra logic around that specific control, and can't iterate through it when I apply the helper function to all objects in the scene.
fyi @RaananW @rgerd
related #10490

HolographicSlate also appears to not need initial scaling, and resizing it beforehand creates a slate with a very small titlebar.

The TouchHolographicButton is fixed with #10547 but the HolographicSlate still needs to be updated.

Final changes made with #11333


configuration PEM file cannot be saved

The configuration PEM file is being saved somewhere next to the python code [1], which may work just in development. In production the code directories are usually write-protected.
[1] https://github.com/efdevcon/pretix-attestation-placeholder-plugin/blob/main/pretix_attestation_plugin/views.py#L10
Also Django file uploads are handled [2] in quite specific way - can be configured via backends, stored in a different locations, etc. And this must be followed.
[2] https://docs.djangoproject.com/en/3.2/topics/http/file-uploads/
Another way of doing this would be saving the content directly to database as a TextField.

This was resolved in #25 - thx.


Invalid Reconciliation Calls

The current (as of this writing) controller implementation is receiving invalid reconciliation requests where the namespace is knative-eventing instead of the user namespace.  These are quickly skipped once it is determined that the Channel does not exist in the knative-eventing namespace.
Sample log message...
{"level":"info","ts":"2020-01-13T20:04:11.608Z","caller":"kafkachannel/reconciler.go:71","msg":"Channel Not Found - Skipping","Controller":"kafka-channel-controller","Request":"knative-eventing/sample-kafka-channel-1"}

It is thought that this is a bug in the controller-runtime and the fact that we're creating/watching things in multiple namespaces.  The eventual refactor to the knative controller infrastructure should eliminate this problem.

The EnqueueControllerOf() knative.dev/pkg/controller/controller.go  gets the "controller" owner reference for the dispatcher deployment/service and takes the object's namespace (knative-eventing) and the name of the owner reference (the KafkaChannel) and enqueue a request for that.
It seems to be another dependency/assumption on the runtime artifacts (dispatcher deployment/service) being in the same namespace as the knative api resources (kafkachannel)
If they WERE co-located then it would FIND the KafkaChannel and we wouldn't see the error (though would have excessive, but expected, reconciliation checks)
The Dispatcher deployment/service have Controller OwnerReferences and the Channel deployment/service does not.  These references should not be "Controller" - especially since we're already violating the k8s cross-namespace ownerreference rule.

Changing ownerreference on dispatcher deployment/service removes extraneous / invalid controller requests.


SB3 files actually just "project.json" files

Abstract
The portion of the "update" section that saves SB3 files does not save SB3 files - it instead saves the "project.json" portion, without any assets included.
Expected Result
SB3 files, or the Scratrch File Format, defined as a zip folder containing the "project.json" file along with the corresponding assets.
Actual Result
"project.json" files
Here's an example of one that you've saved earlier:

https://github.com/scratchbackup/scratchbackup.github.io/blob/main/projects/377735542/project.sb3

https://github.com/scratchbackup/scratchbackup.github.io/blob/main/src/update-project.module.js#L62
What?!
Yeah.

I guess if you're trying to go for something that you can immediately import into Scratch, maybe setting the download attribute in an anchor tag might help so that the project file is not stored twice, but still downloads with the ".sb3" extension.

Something like this
"Yeah it's still a JSON file, but if you download it and rename it as a SB2 it'll work even though SB2's are meant to be ZIPs"


ORC-1482: Adaptation to read ORC files created by CUDF

What changes were proposed in this pull request?

This pr is aimed at adapting to read ORC files created by CUDF, which may have missing statistics in their DOUBLE/FLOAT columns.
Why are the changes needed?

Official ORC readers can't read CUDF-created ORC files properly.
How was this patch tested?

Added UT.

This is already in https://github.com/apache/orc/commit/36886ae19afe1c04541e4c919442eb1f836306a7, isn't it?

Let me close this because this PR looks a little strange.

This is already in 36886ae, isn't it?

@dongjoon-hyun. The original pr I mistakenly thought was only merged into main, thanks for closing the duplicate pr.


uncomment gunicorn

Uncomment gunicorn so that I can run airflow webserver command.

@feng-tao @astahlman @ArgentFalcon

👍


Is it possible to choose the directory of local repository

The extension works well. However, is it possible to choose a different directory to store all local packages? Thank you!

I'm afraid not, because the directory of local packages is set by typst, and this extension can't change it.

I'm afraid not, because the directory of local packages is set by typst, and this extension can't change it.

Thank you so much for your prompt reply and your explanation. I will ask the typst group to see if this can be done in the future.


shape_impl.rs lacks a Capsule impl

Shape seems to be implemented for a lot of primitives, but not for a Capsule. Is there a reason, or is it just an oversight?

Only an oversight. Mostly because I did not take the time to implement all the relevant traits yet.

The implementation of collision detection involving a capsule will be very straightforward once the changes made to the narrow-phase system land with the new support for deformable collision objects. Therefore I will postpone this until the work on deformable collision objects lands (in two or three months I guess).


Various improvements to the DSiWare Injection guide

The added dsiware troubleshooting steps are already referenced in the guide, but missing from the troubleshooting page.

What is the purpose of the added troubleshooting section? Why is it never linked to?

Sorry, maybe I should have made this a bit more clearer:
The troubleshooting steps are intended for users, who can not launch b9sTool after the transfer and are adapted from an older version of this guide.
I did not add any additional links to this section, because it is already linked here and here.
There was another link here, but i removed that one, as it makes no sense before the actual transfer


Avoid duplicate code when unsetting multiple boolean arguments

Description
Avoid duplicate code when unsetting multiple boolean arguments
Issue ticket number
~Closes #xxxx~

Checklist before requesting a review

[x] I have performed a self-review of my code

[x] Conforms to the Contributing guidelines

[x] Proposed changes are described in the CHANGELOG.md

[x] I have tested my code with viash ns test --parallel -q <name or namespace>

Check the correct box. Does this PR contain:

[ ] Breaking changes
[ ] New functionality
[ ] Major changes
[x] Minor changes
[ ] Documentation
[ ] Bug fixes

Not entirely in favour of this since I tend to prefer code that is easier to understand in this specific repo. However I do agree that higher level code results in fewer bugs ☺
* Could you revert changes when the component only has one flag?

* Could you add an entry to the changelog?

* Can you add something to the contrib guidelines ?

CHANGELOG en contributing entries were already added 😃


Graphing Calculator can still be accessed on desktop after disabling it via Group Policy and/or InTune policy

A team member will update this issue with more details soon.

This is your friendly Microsoft Issue Bot. I created this issue automatically as requested by a team member.


Fix security exception when cookies are blocked

👍

We are using an older version, so actual merged changes for Quartz are here:
https://github.com/Quartz/backbone-fetch-cache/tree/6502ce4-patch


Release packaging scripts

Create scripts to automagically package up code for NuGet, binaries for github.

The release packaging process has been documented in build.md

I'm not sure this can be scripted completely. When it comes to automating anything to do with git commits there are two issues:

Merges of branches can fail.
I'd be concerned that it would commit something that shouldn't be committed.

We can script stuff like version bumps and pushing everything to the appropriate spots, but the rest really should be manual.

Agreed. This should be closed. It's leftover from a brainstorming session.
Jeremiah Peschka
Founder, Brent Ozar PLF
On Nov 5, 2011 9:08 PM, "OJ Reeves" <
<EMAIL_ADDRESS>wrote:

I'm not sure this can be scripted completely. When it comes to automating
anything to do with git commits there are two issues:

Merges of branches can fail.
I'd be concerned that it would commit something that shouldn't be
committed.

We can script stuff like version bumps and pushing everything to the
appropriate spots, but the rest really should be manual.

Reply to this email directly or view it on GitHub:
https://github.com/DistributedNonsense/CorrugatedIron/issues/15#issuecomment-2643888


[FIX] Set exit code to 2 if syntax error is found

Resolves https://github.com/LeaYeh/minishell/issues/101

Resolves #54


[Feature] The bridge SHALL generate a unique id on behalf of the bridged device.

Feature description
The UniqueID attribute for a Bridged Device SHALL be updated when the Bridge is factory reset.
If the bridged device does not provide some unique id (e.g. in the case of bridging from non-Matter devices,
or in case of bridging Matter devices which do not provide a UniqueID attribute), the bridge SHALL generate a unique id
on behalf of the bridged device.
Platform
other
Platform Version(s)
No response
Anything else?
No response

https://github.com/project-chip/connectedhomeip/pull/34851


Add a transpose function

Hi, I would like to add a transpose function to a collection
// input
[
    [1,2,3],
    [4,5,6],
    [7,8,9]
]
// output
[
    [1,4,7],
    [2,5,8],
    [3,6,9]
]

switching the row and column indexes. I have this PR, but I think the code could be improved and I need to update the README.md.
Do you think this would be a useful function? Are there any suggestions you would have for testing edge cases?
Thanks

Well, we could include it, but are there any real use cases? The form processing use case seems pretty far fetched to me.
For transpose implementation that works with arrays, you can check this. However, if we decide to include this, we should use this function:
function transpose($collection)
{
    return Collection::from(
        array_map(
            function (...$items) {
                return $items;
            },
            ...toArray(
                map(
                    $collection,
                    'DusanKasan\Knapsack\toArray'
                )
            )
        )
    );
}

Hmm ok, I see you've read the same post as me!
Yeah I don't have another good use for it yet so feel free to ignore it. Just thought it was quite cool and I liked this project, so thought I'd contribute it. That is a much better implementation too IMO.

Well, transpose isn't easily composable from currently provided functions/methods, so we may benefit from including it into Knapsack. You can change the implementation in this pull request to what i proposed (or maybe you'll think of something better) and we can merge it into master.
So what needs to be done:

change implementation

when collection items are of inconsistent length, the missing items are replaced by null (done by my proposed implementation)
when collection items are not collection, exception should be thrown (needs to be implemented)

add readme
add tests

consistent item length
inconsisten item length
some items are not collections

Just reply here if you feel up to it :)

Better late than never :) I merged the PR and added the docs.


Report generation very slow

Describe the bug
We have tests that result in 5k JSON with a total size of 71MB. Many tests use the same steps. Report generation takes about 6 minutes on my high-end PC and 15-20 on our cluster. I profiled the code and a significant amount of the time goes to the calls of com.trivago.cluecumber.engine.json.pojo.Step#returnNameWithArgumentPlaceholders. This is exacerbated by equals() calling that method as well.
To Reproduce
I guess profile a report generation where many tests use the same step.
Expected behavior
Caching should help.
I did a quick-fix here: https://github.com/simonstratmann/cluecumber/commit/02b4b9086a4f79c5209b29056f5608b9658353b7 and reduced the local running time from 6 minutes to 90 seconds.
Attachments
Sorry, can't provide any examples as it's company stuff.
Profiling result:

Thank you for reporting this. We usually have reports that take a few seconds max to complete with our 300 to 500 JSON files so we weren't aware about this. I will try this out and include this in 3.6.3.

Thank you.
If I've learned one thing in my career it's that customers' numbers will always wildly exceed what you'd expect (or perhaps even consider reasonable).

v3.6.3 is released and should show up on Maven Central soon.
Thanks a lot for the contribution!

By the way, @simonstratmann , what did you use for profiling? JProfiler, Yourkit or something else?

I use JProfiler for everything. I have an open source license for a project of mine but I guess for something like this the IntelliJ profiler may be enough.


Stable release date for Bootstrap 4?

Does anyone know when a stable release of Bootstrap 4 will be available?

sorry, currently there's no deadline on beta or stable releases.

Duplicate of #19403.


Support reading single draft by id

Codecov Report

Merging #10 into master will increase coverage by 0.32%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #10      +/-   ##
=========================================
+ Coverage   96.77%   97.1%   +0.32%
=========================================
  Files           6       6
  Lines          62      69       +7
  Branches        5       5
=========================================
+ Hits           60      67       +7
  Misses          2       2

Impacted Files
Coverage Δ

src/main/draft/draftStoreClient.ts
94.44% <100%> (+1.11%)
:arrow_up:

src/main/draft/headersBuilder.ts
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eec64a...e739d25. Read the comment docs.


NFT ImageTraking: image detected, but elements not shown

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Custon NFT detected, but elements are not positioned on the marker.
If the current behavior is a bug, please provide the steps to reproduce.

https://manyworlds.synology.me/manyworlds/development/war/arjs/index9.html
(open the website inspector to see the console)
Use this marker: https://manyworlds.synology.me/manyworlds/development/war/arjs/moon.jpeg; its a bit tough, I have to put it near the camera.
--> This message is logged: [info] Tracked page 15809416 (max 0).
--> My own log is logged: 'markerFound'
--> Opening the A-frame inspector (ctrl+alt+i), you can see the entities in the a-nft component; this one is set as 'visible: true', but it doensn't follow the marker.

Please mention other relevant information such as the browser version, Operating System and Device Name
MacOs 12.1 Monterey
Google Chrome
Chrome is up to date
Version 100.0.4896.88 (Official Build) (x86_64)
What is the expected behavior?
I expected to see a sphere on the marker.
If this is a feature request, what is motivation or use case for changing the behavior?

@ljDevelopment probably your nft marker has low dpi, to check the dpi of your marker you can use the FeatureSET-Display online tool. It is always recommended a dpi of 300 (or around it). If less rebuild your NFT markers with that dpi values.

Hi,
Two points here:

Image is tracked, but its entities are not shown. --> BUG

NFTs are difficult to detect
The image used is completely functional in 8thWall:
https://manyworlds.synology.me/manyworlds/development/war/arjs/moon.jpeg
https://manyworlds.synology.me/manyworlds/development/war/arjs/moon.iset
https://manyworlds.synology.me/manyworlds/development/war/arjs/moon.fset
https://manyworlds.synology.me/manyworlds/development/war/arjs/moon.fset3

Also tried the T-Rex used as an example:
https://manyworlds.synology.me/manyworlds/development/war/arjs/trex.jpeg
https://manyworlds.synology.me/manyworlds/development/war/arjs/trex.iset
https://manyworlds.synology.me/manyworlds/development/war/arjs/trex.fset
https://manyworlds.synology.me/manyworlds/development/war/arjs/trex.fset3

I believe I am experiencing the same issue:

The debug console seems to indicate that the image was detected but the child within the scene is not shown (adapted the public example):


Slider Image

Modified site styles and layout to center the slider in the home page
Closes #641

validated


Prototype codes of supporting leaf span

Coverage decreased (-0.4%) to 70.748% when pulling 9e4026e9b5342aea733f0f33c4438fbcec974fee on feature/198 into c3259afae0e4a267397d91c6117737aa4b7a2e54 on master.

Resolve #198

Coverage increased (+0.6%) to 71.666% when pulling ee0a569eacb822dcab2507279dae18349ffa24ee on feature/198 into c3259afae0e4a267397d91c6117737aa4b7a2e54 on master.

What happens on server side?  I can guess the point, but do you have any real cases?

For example Dubbox provide service by tomcat/jetty. so should we ignore the tomcat component or not?

If we do this, we must provide provider span. But these is a problem, which one should we keep in segment, first or last ? I assume IT is hard to tell.

Each plug-in knows whether or not it is the leaf span. and The span generated by each RPC plug-in is peer to peer, one span generate in client side and it must generate one in server side，So we can know span before generate in server side should be ignore or not.

Leaf concept don't match the server side. The root  span or some child are service provider, but other child are not. How can you ignore the spans?

For example Dubbox provide service by tomcat/jetty. Should we ignore the tomcat component or not?

Let's discuss on this case. How does the tomcat plugin know these is dubbox component? As you known, Tomcat provide service first, then dubbox. If we want to ignore tomcat, we must do this in the dubbox component. Do you agree?
If yes, at that moment, tomcat plugin's beforeInvoke  has already finished, so span and its tags have been generated, and stored in memory. Even we can ignore the tomcat plugin span, the improvement focuses on the cost of network/collector-side, right?
If you agree all of these, we are on the same page. Do you have any proposal about how to ignore the tomcat span, when the dubbox span started? IMO, my only thought is getting the prev span in active-span-stack.

I agree with you. this question you talking about is how to determine the start time of dubbox component. IMO, we can pop the span that generate before dubbo  component when dubbox component finish.
BTW, the same question also happen in RPC client.

The pop operation will trigger bad things. Because after dubbox component finished, Tomcat plugin afterInvoke will invoke, if you pop the stack, this must throw an exception.


Add a panel for viewing spectators comments

As a user I want to be able to view spectators comment for a particular game for the pricier reason of noting what they think about the gameplay

This issue has been fixed
This is the link - https://chess.zuri.chat/game


Cannot parse most sites in php

The html parser will print
"Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /
Unknown HTML symbol /"
On most php based website, example code
    let url = "https://www.ladybirdeducation.co.uk/";
    let client = reqwest::blocking::Client::new();
    let res = client
        .get(url).send()?;
    let body = res.text()?;
    println!("body:{}",(&body).as_str());
    let document = html::parse(body.as_str())?;
    println!("parsed");
    Ok(())

PHP is rendered into HTML server-side so your error must be from something else. Regardless I will investigate based on the URL you gave.

I believe your issue was actually related to a < symbol in a


Add rate limiting for API methods.

Release note:

<PLEASE PUT RELEASE-NOTE HERE, PUT NONE if NO RELEASE-NOTE>

Hi @apicl. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Some explanation would be helpful

Updated the title, priority, and milestone to reflect that this PR is intended for discussion at the moment.
@rshriram, okay to leave this PR open for discussion? I was originally going to close to avoid confusion with on going 0.2 release and consuming test resources. I updated title, etc. and its still marked "needs-ok-to-test" so maybe that's not a problem? Otherwise we can create on a separate branch.

We can leave it open. Also, whats all the X-Google stuff ? Can we keep this vendor neutral?  The Host in Swagger was omitted explicitly because people can run up their bookinfo anywhere, and plug the swagger.yaml in a swagger UI, point to the bookinfo ingress and try the API calls.
cc @ErikWittern any thoughts?

Currently OpenAPI does not support rate limiting features, so we have to
use some kind of extension. The X-Google is Google extensions.
Will follow up about the vendor neutral solution during the design phase.
Thanks
Chengliang
On Tue, Sep 12, 2017 at 6:06 AM, Shriram Rajagopalan <
<EMAIL_ADDRESS>wrote:

We can leave it open. Also, whats all the X-Google stuff ? Can we keep
this vendor neutral?  The Host in Swagger
was omitted explicitly because people can run up their bookinfo anywhere,
and plug the swagger.yaml in a swagger UI, point to the bookinfo ingress
and try the API calls.
cc @ErikWittern https://github.com/erikwittern any thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/738#issuecomment-328846970, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AbvDxuGXQ3vpQlyOL6iCXxxnKIjhUkerks5shoGdgaJpZM4PT2bY
.


Bug in touch ripple

In the end method there is timeout:
//Wait 2 seconds and remove the ripple from DOM
setTimeout(function() {
ripples.shift();
this.setState({
ripples: ripples
});
}.bind(this), 2000);
Sometimes my site fails with error  "Uncaught Error: Invariant Violation: replaceState(...): Can only update a mounted or mounting component.". This occurs because inside timeout there is no checking if component mounted.

Hey @deser, just noticed this bug today - but apparently it's already fixed: https://github.com/callemall/material-ui/blob/master/src/js/ripples/touch-ripple.jsx

Thanks!

Thanks guys - Next release should be coming soon. Just need to finish up a couple more things.


Querying inlink_link nodes doesn't work.

Hi and first of all let me say thank you for your contributions.
This is not a bug or feature request. I just wanted to ask you a question and see if you have an idea how to solve it.
When I open the TreesitterPlayground inside Neovim and query for a node of type indent_link I don't get any results.
Looking at the injected languages I suspect it has something to do with the 2 parsers beeing used.
My ultimate goal is to create a key binding to jump to the next link using nvim-treesittes-textobjects.

I managed to gain some insights on this:
Jumping to text object in the markdown_inline grammar only works when working when the filetype is set to markdown_inline.
Unfortunately, setting the ft to markdown_inline breaks the entire markdown setup.
I close this, as this is clearly not caused by the grammar.

Hey, sry I didn't answer in time. This is indeed not caused by the grammar. If you want to query nodes for the purpose of a plugin, you will have to iterate over all markdown_inline subtrees and query those for e.g. indent_link. Let me know if you need any help.


Polish characters

It's impossible to insert polish characters in insertmode. You or have to replace for example L with Ł or use console version of nvim. I realy would like to insert characters from my language ;P. Typing Ł (right-alt + shift + l) exits insert mode. same with most other polish characters.

I have the same issue with any character that requires holding down AltGr to enter (which includes things like \ on a danish keyboard layout)

This is a repeat of https://github.com/Kethku/neovide/issues/151

This is a repeat of https://github.com/Kethku/neovide/issues/151


Suggest to add notes for use with monorepos and github actions scoped to folder changes

Great to see first-class support for static websites coming to Azure.
I noticed a use case that might deserve some more notes in the documentation. Even if it's only an acknowledgement an links and not a whole section devoted to it since it's more of rare case to optimize.
I think it's more common now for people to develop using monorepos (multiple apps/services in single repo) This means the client or static website that people want to deploy is contained in some sub folder. This works great to have a place to specify the location of the app using app_location.
The issue is that you can have PRs and commits on the master branch that doesn't effect this website and yet it still runs the staging and deployment because of the GitHub action configuration.
I'm sure there is a way in the GitHub action to detect if there no code in the app_location folder that changed, then it should skip the deployment.
I think this could be an option that is enabled on by default or perhaps another option in the workflow configuration that specifies the types of changes that trigger it.  Perhaps: deploy_on: always | changes | commit-contains-words or something like that.
This is minor, but thought it was kind of misleading to have unnecessary deployments. Or perhaps my only staging environment is taking over by PR that doesn't effect the app.
Keep up the good work!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59b3b161-b559-f90b-1566-f18776a5f7da
Version Independent ID: 3e536234-16ad-2ed3-fb58-c128ba2faab2
Content: Quickstart: Building your first static web app with Azure Static Web Apps
Content Source: articles/static-web-apps/getting-started.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@mattmazzola, Thanks for leveraging Azure docs feedback channel to share your valuable feedback. Much appreciate your time and positive feedback, we are very glad about the great feedback.
Your feedback has been shared with the content owner (@craigshoemaker) for further review and update the document as appropriate.

Thanks for the suggestion, @mattmazzola!
This is really more of a product request than something that can be addressed in the docs. You can always provide product feedback at https://github.com/azure/static-web-apps/issues, but mono-repo support is something the Engineering team is evaluating.
#please-close

After re-reading my comment I see it starting going into possible solutions / implementation which would involve product changes which obfuscated the core issue.  I thought there should be a way to detect changes in a certain folder and if none, terminate the current action or prevent processing of future actions.  I thought people more experience with github actions could add note to docs about how this could be done without making actual changes. Put the problem on the user to opt-in to for now until a more formal solution or integration exists.
If it's not a trivial problem then I see the issue can stay closed.


When will be released the new release?

Is there any forecast for the next release?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37314307-when-will-be-released-the-new-release?utm_campaign=plugin&utm_content=tracker%2F1022469&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1022469&utm_medium=issues&utm_source=github).

2.5.0 is publish check it out.


Landlord can get a tenant by id

Description
GET /api/tenants/:id
Fixes #46
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

 Add Endpoint for getting a tenant by their id


🔌  Plugin: Quay

Goal
The goal of this epic is to develop a new Backstage UI plugin in the Janus repo. This UI plugin should provide Backstage user with the ability to view the tags, last update and SHA of an image related to a catalog resource that was deployed by a Quay image.
What problem does this solve? Please describe.
I want to be able to see the details of the deployed image.
Use cases
A clear and concise description of persona and associated use cases that need to be supported.
Acceptance criteria
A clear and concise list of acceptance criteria, noting what will be delivered as part of this epic.  This will help identify associated testing, documentation and support needs.

@serenamarie125 I think this issue was addressed with #68 and #101

@josephca @rnapoles-rh can one of you sign off for QE.
@hmanwani-rh @rkratky can one of you sign off for doc?


Old version of MutabilityDetector used

I get an exception using jadira clone. See https://github.com/MutabilityDetector/MutabilityDetector/issues/82. All info you need is in that thread.
The problem is probably due to you using an old version of MutabilityDetector.
Thanks
Mårten

I was using an old version. Updating tmy ivy config solved it:
<dependency org="org.jadira.reflection.cloning" name="cloning" rev="3.2.0.GA"/>


[BUG] typing-extensions should not be a runtime dependency

Apparently installing rich also brings typing-extensions as a dependency. For testing that is fine as I also use it but it should not be for runtime.

It is used a runtime,


Under what conditions should we trigger the automatic selection for Horizon Europe (HE)?

possible solutions:

remove automated selection, default to dropdown selection
-fastest
-reduction in features
List all the Program IDs for HE, compare against
-opt.1 have value funderID contain this ID instead
-opt.2 add new program ID field to element/database
-is a more comprehensive standalone solution
-requires maintenance work on damaps side to maintain this list of program IDs
-less maintenance on institutions over solution 3, as they will just send the program ID, although they will have to provide this information
Boolean or Enum flag to convey "isHorizon2020Project"
-fast/simple
-also potentially adds limited maintenance work on damap, as we are now maintaining this enum list
-more responsibility on institutions over solution 2, as they will set this flag when transfering project data
add a "Resolution" class or method, to be overridden by institutions to determine on their own accord.
-full maintenance and responsibility on the implementing institution
-relatively simple solution on damaps end
-potentially requires connection to other institutional applications depending on implementation

I do believe they are all valid, and prove similar effort in implementation.
option 2 is probably the largest amount of maintenance of data, both in damap, as well as on the institutions side (e.g. we currently do not carry program IDs for the projects except internal ones at the TU Wien).
So I prefer 3 and 4. Here I would opt instinctively for 3, as it just expands the already existing funder information by one field, while 4 potentially adds a new API call.
Advantage for 4 is the fact, that on creation (when funder API is first called, maybe the project does not have the programm info yet. So it would be beneficial for the project to move that call to a later date.
There is also room for combined solutions, such as: IF no funder Info is provided trigger the API call instead as last instance.
Sounds cool, but now we have more complex code, since we have two distinct decision making code to maintain, so maybe not ideal.


Enable the new model serialization for netapp

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.NetApp


delete appears to invalidate refinements

Flow version: 0.112.0
Expected behavior
delete does not invalidate refinements.
Actual behavior
delete seems to invalidate refinements.
Link to Try-Flow or Github repo

Expected behavior. The current behavior is sound due to potential alias problems.


Downgrades mathjs

The sixth version of "mathjs" was a case of production JS error. The same error was some time ago. So I have downgraded this version to the fifth version. It works locally, should work on Netlify.

Good find. It's unfortunate this is an issue.
Do functions like this work in Dist-builder-1?
"mm(normal(5,1), floor(5 to 20))"


Theme passed down as context

I think this is a great idea, referenced in this thread:
https://github.com/callemall/material-ui/issues/30
We're already building a single theme object, the only difference would be to require the end-user to set it as a context. This would mean some docs explaining how to do that and a new release. So:

[x] Set theme as context in example project
[x] Change Styled to check context rather than using the function
[x] Fix bugs, document, release

Just documented this on http://reapp.io/docs-themes.html


Issue with running LoopringSharp.TestConsole

When trying to run the LoopringSharp.TestConsole project, The nuget build task ( file, NuGet.Build.Tasks.Pack.targets) is throwing an error: "Could not find a part of the path 'C:\Downloads'" . When I create this directory it then throws the error "File not found: 'C:\Downloads\loopringsharp.png'" .

I've put in a dummy png with the same file name as a workaround for now


Module fails with internal server error when redirect/auth is not actioned promptly

We are experiencing a few undesirable behaviors and I am not sure exactly how we can stop these. When the mod_auth_openidc detects that an authentication is required and redirects the user agent to the OP. However if the user does not action the logon promptly but say waits for 30 minutes to logon the auth modules fails on the redirect back to the protected resource. The error is an ugly 500 error but what is worse, this type of behavior is completely normal user behavior and we have not found a way to stop it.
It appears that the module is loosing track of the temporary session state that it holds in memory and then it just does not know what to do with the response that comes back from the OP. Following appears in the log.
[Sun Aug 02 03:07:53 2015] [error] [client <IP_ADDRESS>] oidc_restore_proto_state: no "mod_auth_openidc_state_A4R8h0aSGTQOyfAldbcNbVU4Zrs" state cookie found, referer: https://login.bla.com/realm1/login
[Sun Aug 02 03:07:53 2015] [error] [client <IP_ADDRESS>] oidc_unsolicited_proto_state: could not parse JWT from state: invalid unsolicited response: [src/jose/apr_jwt.c:173: apr_jwt_base64url_decode_object]: JSON parsing (json_loads) failed: '[' or '{' expected near '\x03' (\x03\x84|\x87F\x92\x194\x0e\xc9\xf0%u\xb7\rmU8f\xbb)\n, referer: https://login.bla.com/realm1/login
[Sun Aug 02 03:07:53 2015] [error] [client <IP_ADDRESS>] oidc_authorization_response_match_state: unable to restore state, referer: https://login.bla.com/realm1/login
[Sun Aug 02 03:07:53 2015] [error] [client <IP_ADDRESS>] client denied by server configuration: /data/www/htdocs/favicon.ico, referer: https://secure.bla.com/oidc/redirect_uri?code=eudpap&state=A4R8h0aSGTQOyfAldbcNbVU4Zrs

Any suggestions on how that could be fixed? Is is as simple as setting up REDIS or Memcache?
Many thanks.

So I did a bit of digging through server debug logs and it appears some version of Safari on iOS are not sending the session cookies to the web server when retrieving the favicons (that is if I interpret debug entry in line 3 correctly). I have tried with iOS 8 successfully but Safari on iOS 7 does not seem to include the oidc state cookie. The beautiful web where a single thing is done in 1000 different ways :( ... oh well.
[Sun Aug 02 11:35:12 2015] [info] Initial (No.1) HTTPS request received for child 7 (server secure.bla.com:443)
[Sun Aug 02 11:35:12 2015] [debug] src/mod_auth_openidc.c(2214): [client 102.xx.xx.22] oidc_check_user_id: incoming request: "/oidc/redirect_uri?iss=https%3A%2F%2Flogin.bla.com%2Frealm1%2F&target_link_uri=https%3A%2F%2Fsecure.bla.com%2Fapp%2Ffavicon%2Fapple-touch-icon-152x152.png&oidc_callback=https%3A%2F%2Fsecure.bla.com%2Foidc%2Fredirect_uri", ap_is_initial_req(r)=1
[Sun Aug 02 11:35:12 2015] [debug] src/util.c(739): [client 102.xx.xx.22] oidc_util_get_cookie: returning "mod_auth_openidc_session" = <null>
[Sun Aug 02 11:35:12 2015] [debug] src/session.c(83): [client 102.xx.xx.22] oidc_session_load: <null>
[Sun Aug 02 11:35:12 2015] [debug] src/util.c(778): [client 102.xx.xx.22] oidc_util_request_matches_url: comparing "/oidc/redirect_uri"=="/oidc/redirect_uri"
[Sun Aug 02 11:35:12 2015] [debug] src/mod_auth_openidc.c(1560): [client 102.xx.xx.22] oidc_handle_discovery_response: issuer="https://login.bla.com/realm1/", target_link_uri="https://secure.bla.com/app/favicon/apple-touch-icon-152x152.png", login_hint="(null)"
[Sun Aug 02 11:35:12 2015] [debug] src/util.c(1079): [client 102.xx.xx.22] oidc_util_file_read: file read successfully "/var/cache/mod_auth_openidc/metadata/login.bla.com%2Frealm1.provider"
[Sun Aug 02 11:35:12 2015] [debug] src/metadata.c(309): [client 102.xx.xx.22] oidc_metadata_provider_is_valid: provider (https://login.bla.com/realm1) JSON metadata did not contain a "response_modes_supported" array; assuming that "fragment" and "query" are supported
[Sun Aug 02 11:35:12 2015] [debug] src/util.c(1079): [client 102.xx.xx.22] oidc_util_file_read: file read successfully "/var/cache/mod_auth_openidc/metadata/login.bla.com%2Frealm1.conf"
[Sun Aug 02 11:35:12 2015] [debug] src/util.c(1079): [client 102.xx.xx.22] oidc_util_file_read: file read successfully "/var/cache/mod_auth_openidc/metadata/login.bla.com%2Frealm1.client"
[Sun Aug 02 11:35:12 2015] [debug] src/metadata.c(400): [client 102.xx.xx.22] oidc_metadata_client_is_valid: client (https://login.bla.com/realm1) metadata did not contain a "client_secret_expires_at" setting
[Sun Aug 02 11:35:12 2015] [debug] src/mod_auth_openidc.c(1378): [client 102.xx.xx.22] oidc_authenticate_user: enter
[Sun Aug 02 11:35:12 2015] [debug] src/mod_auth_openidc.c(141): [client 102.xx.xx.22] oidc_get_browser_state_hash: enter
[Sun Aug 02 11:35:12 2015] [debug] src/util.c(699): [client 102.xx.xx.22] oidc_util_set_cookie: adding outgoing header: Set-Cookie:

The other thing that is a bit confusing is the configuration of the OIDCDiscoverURL parameter, the files are actually called something different to the issuer id as well as the discovery URL.
Issuer Id
https://login.bla.com/realm1/
Issuer Provider Conf
login.bla.com%2Frealm1.provider
Issuer Discovery Config
OIDCDiscoverURL https://secure.bla.com/oidc/redirect_uri?iss=https%3A%2F%2Flogin.bla.com%2Frealm1%2F
I found above working for me without errors but not sure exactly if this is correct because if I change the OIDCDiscoverURL to:
OIDCDiscoverURL https://secure.bla.com/oidc/redirect_uri?iss=login.bla.com%2Frealm1
.. it also works but with these oidc_unsolicited_proto_state warnings from my first post ... hmm.

You can control the "state timeout" with the OIDCStateTimeout primitive as documented here: https://github.com/pingidentity/mod_auth_openidc/blob/master/auth_openidc.conf#L534. That setting is independent of the cache backend.

Hmmm is there a way to redirect the user back to the login screen instead of showing the plain 500 as below?
Internal Server Error
The server encountered an internal error or misconfiguration and was unable to complete your request.
Please contact the server administrator, root@localhost and inform them of the time the error occurred, and anything you might have done that may have caused the error.
More information about this error may be available in the server error log.
Apache Server at secure.bla.com Port 443

You are probably right that this event should be handled more elegantly.

In my case it would probably suffice if one could configure a redirect URL to a login page but I am not sure if this is always the case.

see ac9e7f2 which handles this case by sending the user to OIDCDefaultURL if set; please verify

see also #89


Anyone can help with this error i tried to set path for java but still having issue.

Anyone can help with this error i tried to set path still having issue.

@AaravBaba I assume that you verified that the path /home/vinay/java-1.8.0-openjdk-amd64/bin/java does exist and is accessible from the terminal where you are running TackleTest?

@AaravBaba I assume that you verified that the path /home/vinay/java-1.8.0-openjdk-amd64/bin/java does exist and is accessible from the terminal where you are running TackleTest?

Hi rachel,
Thank you for reply, there were problem with my javajdk i resolved that and its working fine now 👍


Update docs on python version

Adds info for new build images.

No, think we can punt on that for the time being. For now it's just the form to build up a small beta access list.

Opened rtfd/readthedocs-build#24 to discuss there.


Fix/update challenge for responsive web design principles chinese

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] All the files I changed are in the same world language (for Chinese)
[X] My changes do not use shortened URLs or affiliate links.

Closes #35785 (for Chinese)

@aditijoshi14 I sent you a DM on Gitter.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


Feature Request - Implement Settings UI

Summary of the new feature/enhancement
Implement a settings UI for the Terminal pulling from the profiles.json file.
Proposed technical implementation details (optional)
Content within these designs is not final and will be modified. They're simply here for demonstration.

Before anyone asks, yes the plan includes having a good live preview of things that could reasonably be expected to be seen in a terminal.

How would you move between different profile's settings?
Perhaps you could implement a ComboBox in the left NavigationPane to choose a Profile, to which the settings would apply?

Your Phone does this

The plan at the moment is to have a profiles item in the menu on the left and a drop down of all your profiles in the main content area, with fields populated according to the JSON properties and a preview window to show your updated settings.
We don't have mocks of this just yet 😊

Per #1750, all iTerm2 color schemes have been ported to Windows Terminal.

To be clear, there is currently (Sunday, July 7, 2019) no Settings functionality at all, correct? Clicking the "Settings" menu item from the triangle drop-down has no effect on my system.

To be clear, there is currently (Sunday, July 7, 2019) no Settings functionality at all, correct? Clicking the "Settings" menu item from the triangle drop-down has no effect on my system.

It should open the profiles.json file, which allows you to change the settings - but eventually there will be a GUI for this file.

To be clear, there is currently (Sunday, July 7, 2019) no Settings functionality at all, correct? Clicking the "Settings" menu item from the triangle drop-down has no effect on my system.

It should open the profiles.json file, which allows you to change the settings - but eventually there will be a GUI for this file.

When I click the settings menu option, it has no effect. I'm using the preview from the windows store. Should I download and build instead?

When I click the settings menu option, it has no effect. I'm using the preview from the windows store. Should I download and build instead?

It should open the profiles.json file inside your default editor for json files. Perhaps you don't have a default set within Windows?

A new preview build is due on the thirtieth so hold on a little while if you want to test something stable

To be clear, there is currently (Sunday, July 7, 2019) no Settings functionality at all, correct? Clicking the "Settings" menu item from the triangle drop-down has no effect on my system.

It should open the profiles.json file, which allows you to change the settings - but eventually there will be a GUI for this file.

When I click the settings menu option, it has no effect. I'm using the preview from the windows store. Should I download and build instead?

Maybe you should check your default JSON file editor first.

My idea for a settings UI.
The settings page should be an overlay.
First Page: A full screen splash screen overlay, like windows settings.
Tab “Profiles”: Each profile has its own submenu tab where you can set name, commandline, starting dir, startup parameter, font face, font size, acrylic, opacity, background color or image, font color and icon. The selections should update the preview in real-time.
Tab “General”: This is the settings page with general settings like cursor size, overall font face and font size. Some other settings that are also global should be selected here.
The second submenu of “General” is layout, where you can tweak the buffer size, windows size and position.
With the X next to settings, you close the settings overlay.
With the arrow next to General or Profiles you go back to the Settings “Splash screen”

https://youtu.be/veqs2WVou9M?t=525 (5 seconds) – Dustin, come on... :stuck_out_tongue: :stuck_out_tongue: :stuck_out_tongue:

My idea for a settings UI.
The settings page should be an overlay.
First Page: A full screen splash screen overlay, like windows settings.
Tab “Profiles”: Each profile has its own submenu tab where you can set name, commandline, starting dir, startup parameter, font face, font size, acrylic, opacity, background color or image, font color and icon. The selections should update the preview in real-time.
Tab “General”: This is the settings page with general settings like cursor size, overall font face and font size. Some other settings that are also global should be selected here.
The second submenu of “General” is layout, where you can tweak the buffer size, windows size and position.
With the X next to settings, you close the settings overlay.
With the arrow next to General or Profiles you go back to the Settings “Splash screen”

The idea of a setting UI would save a lot of time and effort to customize the terminal, I tried adding a new profile along with personalized settings and it took out quite a chunk of time that included checking on Google on how to do it and to save it (profile.json) and re-launch the terminal to see if it works. If not, then repeat.
The mock UI referenced here, though not polished and missing a few things (including adding background image), is far better than manually editing the json file. This feature is extremely crucial and should be available by the next major preview release or final release as this will enable users to focus on how well the terminal reacts to multiple customizations with changes being previewed.

At the same time, this is a developer tool. Some amount of manual configuration file editing is to be expected, possibly even as late as 1.0. And you don’t need to relaunch terminal to see the effects of your editing.

My idea for a settings UI.
The settings page should be an overlay.
First Page: A full screen splash screen overlay, like windows settings.
Tab “Profiles”: Each profile has its own submenu tab where you can set name, commandline, starting dir, startup parameter, font face, font size, acrylic, opacity, background color or image, font color and icon. The selections should update the preview in real-time.
Tab “General”: This is the settings page with general settings like cursor size, overall font face and font size. Some other settings that are also global should be selected here.
The second submenu of “General” is layout, where you can tweak the buffer size, windows size and position.
With the X next to settings, you close the settings overlay.
With the arrow next to General or Profiles you go back to the Settings “Splash screen”

The idea of a setting UI would save a lot of time and effort to customize the terminal, I tried adding a new profile along with personalized settings and it took out quite a chunk of time that included checking on Google on how to do it and to save it (profile.json) and re-launch the terminal to see if it works. If not, then repeat. (Yes I am a noob at manually doing it this way and prefer to have a UI. It's a personal preference shared not by me only but others as well).
The mock UI referenced here, though not polished and missing a few things (including adding background image), is far better than manually editing the json file. This feature is extremely crucial and should be available by the next major preview release or final release as this will enable users to focus on how well the terminal reacts to multiple customizations with changes being previewed.

Glad you like it. Yea a background image selection button is missing. But there is room for that..

The Settings UI wouldn't need to cover EVERY setting you can set.  Anything that affects the visuals of the app, should be there.  A link to open the JSON file should be there.  A link to a complete list of settings you can add should be there.
Previews for things like Cursor Shape, Acrylic, Background Images, Colours - would make a lot of sense, so someone can try out color schemes, before committing.
Also as some settings are per profile, and others are app wide - some kind of drop down to choose the profile to be edited, would probably be a good idea.

The Settings UI wouldn't need to cover EVERY setting you can set. Anything that affects the visuals of the app, should be there. A link to open the JSON file should be there. A link to a complete list of settings you can add should be there.
Previews for things like Cursor Shape, Acrylic, Background Images, Colours - would make a lot of sense, so someone can try out color schemes, before committing.
Also as some settings are per profile, and others are app wide - some kind of drop down to choose the profile to be edited, would probably be a good idea.

2nd image in my concept shows profiles(on the left side) and the settings for it on the main page.

2nd image in my concept shows profiles(on the left side) and the settings for it on the main page.

I did a similar mock up a while back :)

@DHowett-MSFT while this is not within scope for 1.0, would it not be accepted from external developers for 1.0?

@SamuelEnglard external PRs are always welcomes no matter what issue/feature request they're targetting.

Pretty much yea. If you could put something together in the 1.0 timeframe we'd happily accept it, but that might be a tall ask 😝

So, this one requires a little caution. Kayla has a vision about what she wants to accomplish, but I think that that's something we can communicate with the public. We're not going to land something for v1.0 at any rate, but I absolutely don't want to discourage community work on this one :smile:

My thinking was more that you might not want to spend the time reviewing it to focus on 1.0 things.

@mdtauk i like your mockup a lot
one suggestion: remove the  [+] Add new Profile, and instead put a + right next to the profile name (i suppose it is a dropdown menu?)

I think it needs to be four sections:

Global Settings

Shows all common settings, grouped by category.  Use tabs to prevent scrolling.

Keyboard Schemes

Allow sets of keyboard shortcutes to be named, tagged and grouped.  A button to print a Cheat-Sheet would be awesome.

Themes/Visual Schemes

Rich UI for selecting colors for "Themes" with the ability to select background images, name, tag and group themes, and import/export themes with JSON/YAML.  A button to "Variate" would start a new Theme that would be a clone, but two buttons, "Darker"/"Lighter" would darken or lighten the theme incrementally to help create variations for Profiles in a group.

Profiles

Ability to name, tag and group Profiles (groups would be separated in the tab flyout menu to visually organize them).  Selecting a them would use a preview of each theme in a carousel.  Keyboard schemes would be selected from a drop down.  When a Profile is tagged or grouped, it would auto-select a theme and keyboard scheme if matching items exist.  Profiles can be exported to JSON.

All exportable JSON could be packaged as nuget archives with a powershell script to import the item to the current user's settings.

All of those points seem reasonable except for randomly using NuGet 😄
NuGet archives are just zip files with extra metadata that's really only good and useful for binary distributions of things that need to be built into C++/C#/WinJS/etc. projects moreso than as a generic config export format. JSON is already exportable as-is.

All of those points seem reasonable except for randomly using NuGet 😄

It's not random, it's meant to facilitate sharing of settings and profiles using Nuget servers.  I'm currently working on an app and website that will be a gallery of Windows Terminal Profiles that people can share to and download from.  Getting the data to the config file is easy with JSON, but I want to support many different scenarios, one of which is a completely offline scenario where the user doesn't have to edit any JSON files and can be included as part of the setup of a server or container.  To facilitate that, the JSON is encapsulated in Nuget with a PS install and uninstall script that will import/remove the JSON from the config.

To facilitate that, the JSON is encapsulated in Nuget with a PS install and uninstall script that will import/remove the JSON from the config.

So chocolatey? Making a PowerShell cmdlet that creates a chocolatey package of a profile shouldn't be that hard.

To facilitate that, the JSON is encapsulated in Nuget with a PS install and uninstall script that will import/remove the JSON from the config.

So chocolatey? Making a PowerShell cmdlet that creates a chocolatey package of a profile shouldn't be that hard.

The idea is for the nuget generation and import to be baked in so that a 3rd party tool isn't necessary

completely offline scenario where the user doesn't have to edit any JSON files and can be included as part of the setup of a server or container

Odds are they're using some 3rd-party tool to do this already, chocolatey being one of the possible options. Integrating with those tools seems the best bet there to me.

The nuget integration isn't necessary, but would set a good precedent and would also be dogfooding...

This terminal is a UWP app that uses Fluent design and is highly customizable. Maybe take a look at it and kind of shape Windows Terminal similar to it? I mean, even that terminal looks good (although it is in its early stages).

this is the same setting screen as the Windows one, uninspired, waste of space, and hard to read since too much scrolling is required, it's aimed at tablets/mobiles, not powerstations

@russhy we could say the same thing about your comment, so I'm going to delete it. Please come back if you'd like to add value to the conversation.

IMO it would look good if the whole settings app (or page) has a background acrylic just like the Terminal (acrylic that changes according to the acrylic settings set in the settings page)

Keep in mind that settings panels should be consistent across Windows. You may have feedback about how setting panels should look in Windows, but the Terminal GitHub isn't the best place to discuss them. The place to send thoughts about how settings panels should look in Windows is the Feedback app.

All i was saying is it looks like a UI made for tablets?
This is crazy the level of censorship at microsoft

@russhy I deleted your comment because of the specific language it used violating our code of conduct, not because you think our UI would look like a tablet UI. I don't particularly care what you say so long as you express yourself respectfully.

oh i see, i'll try to use proper language in the future, but please let me know instead of just deleting stuff
@DHowett-MSFT

@russhy sure thing, sorry about that. :smile:

A

How about defaulting to json file view for the advanced users? That way users will edit settings their way.

This terminal is a UWP app that uses Fluent design and is highly customizable. Maybe take a look at it and kind of shape Windows Terminal similar to it? I mean, even that terminal looks good (although it is in its early stages).

That project is pretty awesome! Even all kinds of fonts render perfectly. It is, unfortunately, slower than Terminal. Hope Terminal gets inspired by that project while remains super snappy!

🦙 Seems like this could be a good fit for the Form Control Proposal in WinUI.

I'm really looking forward to the Windows Terminal 2.0 roadmap! I am actually developing something quite like the proposed Settings UI. I am currently working on a combined real-time cli and gui editor for Windows Terminal settings Windows Terminal Editor developed in rust. This might be nice for some power users who want to edit their settings in the terminal and see their changes instantly.

I agree with @michael-hawker - but I think Form Control is still in a proposal stage?
For PowerToys, we put in quite some effort to get the XAML right: all fontsizes, margins, paddings and other attributes mimic the W10 Settings dialog. In this way it looks and feels native to Windows and would be great to share the same UX?
I'm happy to contribute the XAML that is required and to polish it all up. @zadjii-msft @DHowett . Is there already an active branch?

I believe there is a variety of WIP branches, but I honestly don't know which ones are active or not. I believe @carlos-zamora and @cinnamon-msft do know though

The latest branch is cinnamon/settings-ui-v2. We implemented the Settings UI as a separate app that can be found under src/TerminalSettings.
We're still working on organizing a plan/spec for the Settings UI as a whole, so feel free to clean up the Globals and Color Schemes page for now, or poke around.
For the record, some of the stuff that we still need to plan out are...

changes to the Profiles page
overall design of the Keybindings page
how to sync the JSON and the Settings UI
We have some ideas, but we'll come out with an actual spec for all of this soon.

How I execute the app(Settings page)?

How I execute the app(Settings page)?

The Settings UI is under active development and is not in Windows Terminal yet.

Yes, I know this, but isn't it possible to test the prototype of the configuration page, to see how it can look? because at the beginning of the topic there are images of a prototype.

I believe those are just UI mockups made in Figma, not an actual prototype that can be played with quite yet.

I downloaded a zip with with this supposed prototype, and now I don’t know how to run it

I believe those are just UI mockups made in Figma, not an actual prototype that can be played with quite yet.

yes, it may be, but the image appears to be so real ...

@Viniacamp You need to compile the application yourself. There's a TerminalSettings.sln file in the src\TerminalSettings directory which you can open in in Visual Studio and then build and run. But if you don't know what you're doing you may struggle to get it working - I know I had to mess with the project files to adjust the package paths for my system. Also note that there isn't that much to see yet - it's just a few mockups of some of the screens, and that doesn't include any of the images posted at top of the issue.

The "unsaved changes" thing obstructs the settings at the bottom of the page, and they can't be scrolled up.

Will there be an autosave feature? like as soon as you check a checkbutton, toggle a toggleswitch,  or just change any setting, will they be saved? (evevnt-based save feature)

@SFM61319 because all open instances of Terminal automatically update when the settings file changes, we decided that it would be too dangerous and disruptive to save on every state change. Configuring a single profile would turn every terminal window into an absolute kaleidoscope of font sizes and colors while you were editing.

@DHowett wait I have an idea what about a setting (in settings) to enable autosave?

And will Ctrl + S save the settings so that one doesn't have to click the save button (if autosave isn't a feature)? (Keybindings make stuff easier to use)

I have been thinking, is there a plan to include an Import and Export button/option for the ColorScheme?
I know there is the JSON settings page, but it would also be useful to support importing existing colour schemes like iTerm, JSON, or even raw TXT files.

@leonmsft you're gonna think I'm crazy, but.. the color schemes page is mixing up all the colors o_O

select campbell

keyboard down to campbell powershell

keyboard back up to campbell


changing release site for adcs-issuer

changing release site for adcs-issuer

see https://github.com/cert-manager/website/pull/1369
/approve
/lgtm


node-gyp is required?

Hi:
I was getting an "error addLocal Could not install..."
Turns out when I npm installed -g node-gyp, the error went away.
Is node-gyp required? If so, maybe point out that dependency somewhere.
(I got the idea to try node-gyp first from iandotkelly's answer on http://stackoverflow.com/questions/10153317/cannot-install-bcrypt-node-js-module-on-centos-server.)

Sorry, but did you intend to open this issue for node.bcrypt.js? That is the module that SO question referrers to and this is the error people commonly encounter with that module.


No Lights found

Hello,
running the example doesn't return any light, as client.getLights() return a collection of size 0. I can easily reach the bulbs with  javascript (https://github.com/magicmonkey/lifxjs) from the same machine. I tried with ubuntu (icedtea java) and on windows (oracle java) but no sucess. Any Idea?

Have you tried LFXClient.open(false) and waiting a while?


Screen Alignment

The cover is not aligned in center. It comes in center in few movies but mostly not. Its uncomfortable to watch like this. Can we make it better?

Thankyou

What release or branch are you using?

0.0.4

That bug is fixed in release 0.0.5. You can either download the build from the releases or checkout release-0.0.5-alpha branch


Xamarin forms iOS certificate invalid on open url

On Android is ok when using WebView custom render with OnReceivedSslError.
On iOS when I open the site, the browser displays this message and I can't proceed.
How to force to accept an invalid certificate in browser or webview?
The site is https
Message certificate invalid:
https://drive.google.com/file/d/1746A43O7d1YaYgoMXp2jGZGNlB6CYMRp/view?usp=sharing

Solved with custom render iOS delegate:
public override void DidReceiveAuthenticationChallenge(WKWebView webView, NSUrlAuthenticationChallenge challenge,  Action<NSUrlSessionAuthChallengeDisposition, NSUrlCredential> completionHandler)
{
if (challenge.ProtectionSpace.AuthenticationMethod == NSUrlProtectionSpace.AuthenticationMethodServerTrust)
{
completionHandler(NSUrlSessionAuthChallengeDisposition.UseCredential, NSUrlCredential.FromTrust(trust: challenge.ProtectionSpace.ServerSecTrust));
}
else
{
completionHandler(NSUrlSessionAuthChallengeDisposition.CancelAuthenticationChallenge, null);
}
}


Cannot declare class App\Kernel

When I tried to run behat on the skeleton plugin, it wouldn't work as there was no webserver running. So I ran symfony serve --port=8080 --no-tls myselfm but this results in an error: PHP Fatal error:  Cannot declare class App\Kernel, because the name is already in use in [Path to skeleton dir]\vendor\sylius\grid-bundle\src\Bundle\test\src\Kernel.php on line 23
Since I'm using PHP 8.0.11, I used composer create-project sylius/plugin-skeleton SyliusPluginSkeleton -s dev to create the plugin.

Issue is fixed, just follow the instructions in the doucmentation closely, and don't adjust the Kernal namespace


centOS cerebro

I might be bad or something but i can't manage to make it run,
I'm running a server under the lastest version of elasticsearch since kopf is no longer updated i have to turn out for the cerebro solution but,
I got two cerebro a master one, and the basic one (0.7.3) with the bin with two cerebro a .bat and the other one
extracted both of thee cerebro file on my desktop what should i do now ? the instruction are really unclear modified the conf file it start but nothing happen i also tried to put the cerebro-master in the eslactisearch plugin directory and configure it but nothing happend aswell
i couldn't figure out where to find or put the -dhttp:port and -dhttp:address
Found out something i put the cerebro in my /opt then i created a cerebro.service in /etc/systemd/system containing this script
[Unit]
Description=Elasticsearch - Cerebro
Wants=network-online.target
After=network-online.target
[Service]
Environment=HOST=192.168.x.x
Environment=PORT=9200
WorkingDirectory=/opt/cerebro/current
User=elasticsearch
Group=elasticsearch
ExecStart=/opt/cerebro/current/bin/cerebro
-Dhttp.port=${9200}
-Dhttp.address=${192.168.x.x}
However i'm getting this error :
cerebro.service - Elasticsearch - Cerebro
Loaded: loaded (/etc/systemd/system/cerebro.service; disabled; vendor preset: disabled)
Active: failed (Result: exit-code) since jeu. 2018-06-07 11:05:22 CEST; 6s ago
Process: 2141 ExecStart=/opt/cerebro/current/bin/cerebro -Dhttp.port=${9200} -Dhttp.address=${192.168.x.x} (code=exited, status=200/CHDIR)
Main PID: 2141 (code=exited, status=200/CHDIR)

You'll find working examples of startup scripts under #87
On that note, you can add the Play Framework settings in the application conf file.
Example:
http = {
    port = "1234"
    address = "192.168..1.1"
}

SSL Example:
http = {
  port = "disabled"
}

https = {
  port = "1234"
}

play.server.https {
  keyStore = {
    path = "keystore.jks",
    password = "SuperSecretKeystorePassword"
  }
}

play.ws.ssl {
  trustManager = {
    stores = [
      { type = "JKS", path = "truststore.jks", password = "SuperSecretTruststorePassword"  }
    ]
  }
}

Thanks
Basically i tried something else, i created a start.bat which contain cerebro -Dhttp.port=9000 -Dhttp.address=192.168.x.x
But this time i'm getting another error :
2018-06-08 09:12:44,054 - [ERROR] - from akka.io.TcpListener in application-akka.actor.default-dispatcher-5
Bind failed for TCP channel on endpoint [/<IP_ADDRESS>:9000]
java.net.BindException: Cannot assign requested address: bind
at sun.nio.ch.Net.bind0(Native Method)
at sun.nio.ch.Net.bind(Unknown Source)
at sun.nio.ch.Net.bind(Unknown Source)
at sun.nio.ch.ServerSocketChannelImpl.bind(Unknown Source)
at sun.nio.ch.ServerSocketAdaptor.bind(Unknown Source)
at akka.io.TcpListener.liftedTree1$1(TcpListener.scala:56)
at akka.io.TcpListener.(TcpListener.scala:53)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
at java.lang.reflect.Constructor.newInstance(Unknown Source)
at akka.util.Reflect$.instantiate(Reflect.scala:65)
at akka.actor.ArgsReflectConstructor.produce(IndirectActorProducer.scala:96)
at akka.actor.Props.newActor(Props.scala:213)
at akka.actor.ActorCell.newActor(ActorCell.scala:563)
at akka.actor.ActorCell.create(ActorCell.scala:589)
at akka.actor.ActorCell.invokeAll$1(ActorCell.scala:462)
at akka.actor.ActorCell.systemInvoke(ActorCell.scala:484)
at akka.dispatch.Mailbox.processAllSystemMessages(Mailbox.scala:282)
at akka.dispatch.Mailbox.run(Mailbox.scala:223)
at akka.dispatch.Mailbox.exec(Mailbox.scala:234)
at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
at akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
at akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
I bet it's because one of the following port i put isn't open but i assure that my firewall disabled and my port is opened after this still getting the same error

I wrote an article for installation as service, for reference. https://www.jianshu.com/p/e61c82af2e19


AutoNAT protocol implementation

AutoNAT protocol helps to define if a node is behind the NAT or not. As of now we are assuming that every node is behind the NAT and so they are connected with relay first and attempt to hole punch for NAT Traversal

Is this the same as your PR for autoNAT? @efrisch

Is this the same as your PR for autoNAT? @efrisch

@betarelease Yes. https://github.com/pyrsia/pyrsia/pull/848

Also is this the same as #584? Can we close one of them?