Execute flows for Substrate wallets

Summary of changes
Provide a detailed description of proposed changes.

Execute flows for Substrate wallets

Nominate
Bond more
Unbond
Rebond
Withdraw
Stop Nomination
Update payee
Update Nomination

Reorder & optimize files

Proposed area of change
Put an x in the boxes that apply.

[ ] apps/bridge-dapp
[ ] apps/hubble-stats
[ ] apps/stats-dapp
[x] apps/tangle-dapp
[ ] apps/testnet-leaderboard
[ ] apps/faucet
[ ] apps/zk-explorer
[ ] libs/webb-ui-components

Reference issue to close (if applicable)
Specify any issues that can be closed from these changes (e.g. Closes #233).

Closes #1970

Screen Recording
If possible provide a screen recording of proposed change.
https://github.com/webb-tools/webb-dapp/assets/69841784/33cfbc36-0562-4d43-b2e9-d5924b66dc7b

Code Checklist
Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Nice work on integrating substrate wallet flows @vutuanlinh2k2  👍🏼 Did you make sure to check EVM wallet flows after integrating substrate flows?
Most of the EVM flows are not working for me. Tested on development preview of tangle-dapp on this branch - https://deploy-preview-1997--tangle-dapp.netlify.app/
Here's the screen recordings.
Substrate Wallet (Stop loading button or close modal when user cancels a txn)
https://github.com/webb-tools/webb-dapp/assets/53374218/ec5750fc-02e3-423f-a7ab-36c31df90146
EVM Wallet (Unbond Stake - takes longer than usual and never completes)
https://github.com/webb-tools/webb-dapp/assets/53374218/00255342-488a-4581-b54a-857c8d026ead
EVM Wallet (Update Nominations - takes longer than usual and never completes)
https://github.com/webb-tools/webb-dapp/assets/53374218/638db00d-6919-4c49-a4e4-e62f34ebc86c
⚠ Same goes for change payment destination and stop nomination flows with an EVM wallet. I suspected the issue might be related to my MetaMask account since it was connected to localhost. To address this, I deleted all previous Tangle testnet networks from MetaMask, cleared the activity and nonce data, and reconnected. However, the problem persists even after these steps.
Please make sure each flow works with both substrate wallet and EVM wallet. Maybe drop those screen recordings here if it works on your end and we can take a look.

@devpavan04
You can check back the deploy link now Pavan.
For Metamask, you might want to do this before testing:

Remove all current Tangle networks
Add Live Tangle Testnet again
Remove all previous activities in Advanced section in Setting

https://github.com/webb-tools/webb-dapp/assets/69841784/aecb4d9d-74cc-4feb-912c-4333ebe889a4

@devpavan04 can you re-review so we can try and merge this?

LGTM!


why is my caffemodel filenme “1_F_solver_iter_50000.caffemodel” but not “_iter_50000.caffemodel”?

Where does the prefix“1_F_solver ”come from?  can you help me?


image White and black

as converting a binary image in color? White and black?

Hello,
Could you please provide more details on the issue? I'm not sure I understand what you mean.

Closing this issue. Feel free to reopen if necessary.

imaging.New(100,100, color.RGBA{224,240,237,1})
Maybe means that It will create a black image (whatever rgb value)!

Hello,
In your example color.RGBA{224,240,237,1} is a bad color representation. Alpha channel = 1, but for alpha-premultiplied color it cannot be less than r g b values. Probably you meant color.RGBA{224,240,237,255}.

Thanks, that's right!

Thanks @disintegration


release-20.2: kv: allow manual GC that does not advance threshold

PR: https://github.com/cockroachdb/cockroach/pull/60745
From release notes:

Manually enqueueing a range in the GC queue now properly respects the SkipShouldQueue option. This can be useful to force the GC of a specific range. [#60745][#60745] {% comment %}doc{% endcomment %}

I do not think this needs documentation. It was primarily added as a mechanism for CRDB engineers to use during support escalations.

Thanks, @nvanbenschoten!


"message.channels" etc. in "Getting Started" guide may be confusing

Description
I've answered this question before: https://github.com/slackapi/bolt-js/issues/601#issuecomment-682264330
While reviewing https://github.com/slackapi/bolt-python/pull/71 , I felt this is confusing (again).

We definitely should have links to the document https://api.slack.com/events/message.channels but we should avoid saying "message.channels" events because actually there is no such event type. My suggestion is to change the label from message.channels to message (in channels) or similar plus to have a link to the event document.
If other maintainers agree with this, we should update Bolt for Python's document as well. As Bolt for Java's one doesn't have this part, we don't have anything to do with it.
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[ ] question
[x] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

https://github.com/slackapi/bolt-js/issues/757 will be a solution for this issue. Let me close this one.


Boobook recognizer etc

Title of PR
Boobook sub-branch code review
What is the purpose of this PR?
Changes
Created new Boobook recognizer and Aust Bittern recognizers.
Also set up yml for Koalav3 recognizer.

Visual Changes
None
Final Checklist

[Anthony ] Assign reviewers if you have permission
[ ???] Assign labels if you have permission
[ ???] Link issues related to PR
[ ???] Link any PRs or issues blocking this PR from being merged
[ ???] Remove/Reduce warnings from edited files
[ One unit test for Flying Fox fixed.] Unit tests have been added for changes
[ Code builds] Ensure CI build is passing

I fixed the conflict in one file.

I believe I have made all the requested changes.


Shuffled constraints and variables causing infeasibilities

Dear linopy team,
I am currently using linopy 0.1.4 with PyPSA 0.22.1
While trying to solve a small optimisation model via PyPSA, I encountered some infeasibilities on a model which shouldn't have any. The issue happens in the specific case where I combine unit commitment, ramp constraints and rolling horizon - the first iteration always goes well, and the second is found infeasible.
I tried to dig into the PyPSA and linopy code and it seems like the constraints are well-written all along the way, except at the very end during the export to the lp file. In the LP file, right and left hand terms are mixed, grouping part of constraints that are not related, hence causing the infeasibilities.
When rolling horizon is disabled, it does not lead to infeasibilities but constraints are still not written properly...
However, the to_file linopy function is a bit beyond my capabilities, and it is likely I missed something upstream, too.
Here is the code used for the tests, the logs, and the dataset. Thanks a lot for your help!
n = pypsa.Network()
    n.import_from_csv_folder("main/test")

    n_periods = 1000
    for i in range(n_periods):
        print("Iteration " + str(i+1) + " over " + str(n_periods))
        begin = i * int(len(n.snapshots) / n_periods)
        end = min((i + 1) * int(len(n.snapshots) / n_periods + 1) + 2, len(n.snapshots))

        m = n.optimize.create_model(snapshots=n.snapshots[begin: end], linearized_unit_commitment=False)

        m.to_file("pypsa.lp")
        n.optimize.solve_model(solver_name='gurobi')

        try:
            se = m.compute_set_of_infeasible_constraints()
            print(se)
        except:
            print("worked")

IIS runtime: 0.00 seconds (0.00 work units)
 c112: x8 <= 0

 c113: x1 <= 10000

 c118: x4 <= 10000

 c294: x0 <= 10000

 c295: x2 <= 5000

 c296: x3 <= 5000

 c297: x5 <= 7500
[test (1).zip](https://github.com/PyPSA/linopy/files/11145974/test.1.zip)

 c299: x6 <= 7500

 c298: x7 <= 7500

 c574: x0 + x1 + x2 + x3 + x4 + x5 + x6 + x7 + x8 = 200000

Hi linopy team, did you have a chance to consider the following issue? It seems like it lies with the lp file writing, maybe because coordinates are missing, creating a shift between lhs and rhs. Your help/guidance on this would be highly appreciated! thanks a lot

Hey @avautrin. Sorry for the late reply, just came back from my vacations. No, I am pretty sure it has nothing to do with a shuffling of the constraints. If you run this
for key in se:
    print(key)
    print(se[key].to_series()[lambda ds: ds != -1])

you see that the infeasible constraints are at one time step and are related to the ramp limit and the generator capacity limits. In case of an infeasibility, you can always introduce a load shedding as a first measure and see where the system suffers from energy shortage.
Please reopen if you still encounter problems :)

Hi @FabianHofmann, thanks for your answer - unfortunately I think the optimisation problem is feasible, and the issue lies in the constraint writing in lp :) My main insight is that switching to ",io_api='direct'" (with gurobi) solves the issue and makes it feasible. But all solvers do not have a direct api connection...
Also, a manual search and replace in the lp file (to have understandable names instead of "x1" etc - please point to a more convenient solution if any..) showed that lhs did not match rhs: e.g., two variables used in ramp of "Gas CCGT" appear in the same constraint as the ramp limit value of "Electricity sink", and the other way...
Thanks a lot for your support!

Could you have a look whether the changes in #113 fixes the issue

It works perfectly @FabianHofmann, thanks a lot!

Great to hear! Thanks to you for being so patient and finding this bug!


Hide login link even during load

At the moment the login link is visible momentarily when loading a page (probably because styles haven't been applied yet). We should fix that (e.g. by adding inline styles or something to prevent flash of unstyled content).

Reported on Discord: https://discord.com/channels/1136054062949863634/1179476053941555321


Add scheduler

The bot should ask for a feedback N times (configurable) per week. Only on weekdays.

Fixed in 3928effe541ca3c2bb6883efde0ad4f6a7d1ff48

Current setup is:
if [ "$(date +%u)" = 3 ] || [ "$(date +%u)" = 5 ]; then FLASK_APP=stanley/app.py flask request_feedback_command; fi


minor optimisations to DataTypeMapper

as per comments in issue #36.

Viewing on mobile but looks plausible. I think going forward, I'd like a unit test demonstrating that caching dictionaries are thread safe in concurrency scenarios. See the bug I fixed 2 days ago for an example test case. Basically create a unit test with .AsParallel call. If the unit test I wrote the other day covers this by invoking that machinery under the hood, that should be ok. (Just let me know that that is the case.)

Apologies if I am mistaken - I  would be lucky to have a tiny fraction of your programming knowledge (and I am not being humble - my day job has very little to do with computers) - I just wanted to make sure you had seen the changes did not introduce the use of dictionaries (which were pre-existing in the code) - the changes were merely:

replacing the parameter-less constructor for a dictionary with a constructor specifying a StringComparer.OrdinalIgnoreCase, in order to prevent every lookup value for the dictionary being converted to uppercase first.
replacing the pattern of if (dictionary.Contains(key)) {return dictionary[key]} with the dictionary.TryGetValue method - avoiding 2 lookups where 1 would do.

Quite right. Much easier to see on a real computer. :)


Not hosted under pytest-dev?

While this plugin looks interesting, I wonder why is not hosted under @pytest-dev
PS. Some sort of CI/CD would also be useful.

Hi @ssbarnea,
To answer your question:

pytest has a process for submitting a plugin to pytest-dev, and I haven't gone through that process.
I think of pytest-dev plugins as those that get a lot of use. However, this is relatively new, and has 13 stars as of today. I'm not sure I would think of it as highly used yet.
I might consider that in the future, however.

Regarding CI/CD, that would be useful. I already use GitHub actions on some projects, and adding it to this project would make sense. Adding a new issue and closing this.


duckdb.duckdb.IOException: IO Error: Connection error for HTTP HEAD to ... error while reading from moto mock s3 bucket

Thanks a lot for all the work with duckdb! I have found it to be extremely useful!
I'm running into an issue with querying files stored in a mock s3 bucket (working with the real s3 bucket), here are the details:
Error:
FAILED error.py::test_duckdb_aws - duckdb.duckdb.IOException: IO Error: Connection error for HTTP HEAD to 'https://some-random-bucket.test/_url/random_output_dir/test.parquet'

Steps to reproduce:
duckdb version: 1.0.0
s3fs: 2023.6.0
aiohttp: 3.9.0
aibotocore: 2.5.2
moto: 4.1.0
I'm using moto for mocking the s3 bucket. Specifically, I use the fixture defined in this comment: https://github.com/aio-libs/aiobotocore/issues/755#issuecomment-1424945194
from collections.abc import Callable
from typing import Any
from unittest.mock import MagicMock

import aiobotocore.awsrequest
import aiobotocore.endpoint
import aiohttp
import aiohttp.client_reqrep
import aiohttp.typedefs
import boto3
import botocore.awsrequest
import botocore.model
import duckdb
import pandas as pd
import pytest
from moto import mock_s3
from upath import UPath

"""
Source: https://github.com/aio-libs/aiobotocore/issues/755#issuecomment-1424945194
"""

class MockAWSResponse(aiobotocore.awsrequest.AioAWSResponse):
    """
    Mocked AWS Response.
    https://github.com/aio-libs/aiobotocore/issues/755
    https://gist.github.com/giles-betteromics/12e68b88e261402fbe31c2e918ea4168
    """

    def __init__(self, response: botocore.awsrequest.AWSResponse):
        self._moto_response = response
        self.status_code = response.status_code
        self.raw = MockHttpClientResponse(response)

    # adapt async methods to use moto's response
    async def _content_prop(self) -> bytes:
        return self._moto_response.content

    async def _text_prop(self) -> str:
        return self._moto_response.text

class MockHttpClientResponse(aiohttp.client_reqrep.ClientResponse):
    """
    Mocked HTP Response.
    See <MockAWSResponse> Notes
    """

    read_count = 0

    _loop = None  # type: ignore

    def __init__(self, response: botocore.awsrequest.AWSResponse):
        """
        Mocked Response Init.
        """

        async def read(bytes_size: int = -1) -> bytes:
            if self.read_count == 0:
                self.read_count += 1
                return response.content
            else:
                return b""

        self.content = MagicMock(aiohttp.StreamReader)
        self.content.read = read
        self.response = response

    @property
    def raw_headers(self) -> Any:
        """
        Return the headers encoded the way that aiobotocore expects them.
        """
        return {
            k.encode("utf-8"): str(v).encode("utf-8") for k, v in self.response.headers.items()
        }.items()

@pytest.fixture(scope="session", autouse=True)
def patch_aiobotocore() -> None:
    """
    Pytest Fixture Supporting S3FS Mocks.
    See <MockAWSResponse> Notes
    """

    def factory(original: Callable[[Any, Any], Any]) -> Callable[[Any, Any], Any]:
        """
        Response Conversion Factory.
        """

        def patched_convert_to_response_dict(
            http_response: botocore.awsrequest.AWSResponse,
            operation_model: botocore.model.OperationModel,
        ) -> Any:
            return original(MockAWSResponse(http_response), operation_model)

        return patched_convert_to_response_dict

    aiobotocore.endpoint.convert_to_response_dict = factory(
        aiobotocore.endpoint.convert_to_response_dict
    )

@pytest.fixture
def s3_fixture() -> boto3.resources.base.ServiceResource:
    with mock_s3():
        conn = boto3.resource("s3", region_name="us-east-1")
        yield conn

def test_duckdb_aws(s3_fixture: boto3.resources.base.ServiceResource):
    # Initialize data to lists.
    data = [{"a": 1, "b": 2, "c": 3}, {"a": 10, "b": 20, "c": 30}]

    # Creates DataFrame.
    df = pd.DataFrame(data)

    TEST_S3_BUCKET_NAME = "some-random-bucket"
    s3_fixture.create_bucket(Bucket=TEST_S3_BUCKET_NAME)

    output_dir = UPath(
        f"s3://{TEST_S3_BUCKET_NAME}/random_output_dir", s3_additional_kwargs={"ACL": "private"}
    )

    output_pth = output_dir / "test.parquet"

    df.to_parquet(output_pth, storage_options={"s3_additional_kwargs": {"ACL": "private"}})

    with duckdb.connect() as con:
        con.sql("INSTALL httpfs")
        con.sql("LOAD https")
        con.sql(f"SET s3_access_key_id='test_access_key'")
        con.sql(f"SET s3_secret_access_key='test_secret_key'")
        con.sql(f"SET s3_endpoint='test_url'")
        con.sql(f"""select * from '{output_pth}'; """)
        result = con.fetchdf()
        print(result)

Any advice for this? Thanks in advance!

hey @mayankanand007 thanks for reporting this! I think this has to do with the fact that DuckDB uses a custom S3 implementation instead of an official SDK.
You could try switching to fsspec instead (https://duckdb.org/docs/guides/python/filesystems.html) but that may kindof defeat the purpose of your tests


is VEthernet.dll opensource?

is VEthernet.dll opensource?

We will not open source the Implementation of the VEthernet framework library for the time being!
You can use VEthernet to integrate or develop other VPN or global proxy applications that work on Windows.NET 4.0 (x86) platforms.
The TapTap2Socket framework provided by VEthernet is different from other similar open source implementations (such as libtun2socks) based on the LwIP (C) TCP/IP stack.
VEthernet uses other, more reliable methods to achieve this, and VEthernet provides network stack multi-core optimization, IPv4 packet fragmentation support, etc.
"Virtual Nic applications" developed with VEthernet + TAP-Windows drivers can provide greater Ethernet IO bandwidth, such as Intel I7-6700HQ + Windows 10 (X64) platform, It can provide a minimum of 70Mbps bandwidth throughput and a maximum of 100mbps, but you need to switch to a 1GE tap-Windows driver.
Yes, Intel i7-6700HQ + Windows 10 (X64) + TAP Windows(100Mbps), watching Youtube video bitstream link speed can reach 7W/Kbps, QUIC (UDP transmission) can reach 10W/Kbps
In addition, VEthernet has relatively good memory and CPU resource performance. Tun2socks applications are generally implemented based on VEthernet framework, such as: Edge/Chrome plays 4K/2K Youtube video streams with no more than 30Mb of ram, generally around 10 to 20MB RAM.

请问up有没有比看openvpn源码更简单的学习如何使用TAP-WINDOWS6的资料？

请问up有没有比看openvpn源码更简单的学习如何使用TAP-WINDOWS6的资料？

你好，是没有的，如果说有相对比较简单的可能就是！
1、badvpn
2、libtun2socks
3、redsocks
本项目提供的：VEthernet 框架类库是弱化版本，是没办法处理二层虚拟以太网络与网络层TCP/IP仿真的...


Primary sidebar shrinks when a new window opened

Every time I reopen a VS Code window, primary sidebar shrinks in width:
Before closing VS Code/its window:

After closing VS Code/its window:

It's quite annoying since, after a couple of iterations, it makes the file explorer tiny.

Settings
"apc.activityBar": {
  "size": 77,
  "itemSize": 48,
  "itemMargin": 0
},
"apc.header": {
  "height": 37
},
"apc.electron": {
  "titleBarStyle": "hiddenInset"
},
"apc.sidebar.titlebar": {
  "height": 37
},
"apc.stylesheet": {
  // Make the host button as wide as the .activitybar
  ".statusbar #status\\.host": "width: calc(var(--activity-bar-action-size) - 1px);",
  ".statusbar #status\\.host .codicon": "margin: 0 auto;",
  // Enforce the same color for tabs background
  ".editor-group-container .inline-no-tabs-placeholder": "background-color: rgba(0,0,0,0) !important;",
}

Original discussion: https://github.com/drcika/apc-extension/issues/52#issuecomment-1658070320.

it annoys me terribly,
I keep reloading vscode while working on the extension,
but unfortunately I haven't found a way to solve that problem,
cause of the problem is they (vscode team) hardcoded values in different places

should be fixed with v0.3.0


Set PlaceHolder Value For When Editor Is Not Focused.

Is this a unique feature?

[X] I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.
I’m making a social media like application with an editor for creating a post.
I want the default placeholder for when editor is not focused to be something like : Start Your Story…
And when editor is focused for it to be type / for the / menu
so the user can see where to start their story and also know about / menu at the same time
Also recommended also adding options for editing placeholder value for each item in the editor.
ex after you do /heading you get a new placeholder :
Type your heading…
thank you
Proposed Solution
Don’t have a solution.
Screenshots
No response
Do you want to work on this issue?
No
If "yes" to the above, please explain how you would technically implement this (issue will not be assigned if this is skipped)
No response

Fixed in v4.4.0.
Added three new API methods:

editor.isFocused()
editor.focus()
editor.blur()

Docs

https://github.com/Darginec05/Yoopta-Editor/tree/master/packages/core/editor#api-from-editor-instance

Examples

https://yoopta-editor.vercel.app/examples/withEditorFocusBlur


Android should always use NV21 image format

On Android, mobile_scanner currently has a bug, where it defaults to using YUV, instead of NV21.
Per the documentation in https://developer.android.com/reference/android/hardware/Camera.Parameters#setPreviewFormat(int)
the NV21 format is always supported. So we should always be using NV21 on Android.
Per the docs in https://developer.android.com/reference/android/graphics/ImageFormat#NV21 it seems that NV21 is the default format when no other format is requested.
The discussion in https://github.com/juliansteenbakker/mobile_scanner/issues/698 also mentions that the affected device only supports NV21.
Supersedes https://github.com/juliansteenbakker/mobile_scanner/issues/698 https://github.com/juliansteenbakker/mobile_scanner/issues/1124 and https://github.com/juliansteenbakker/mobile_scanner/issues/1077

I'm currently a bit stretched on some other work, but I can start implementing this fix at the end of this week.
I don't expect this to take too long to implement, though. We'll have to specify that we use NV21 for the camera preview and drop the conversion to YUV entirely. I don't expect it to be much else, in terms of a fix.

@navaronbracke  Today we encountered this issue on a Galaxy A23 (we are using mobile_scanner 5.2.3). Could you let us know if your proposed fix is already included in the latest version? Thanks!

The reporter issue is for Samsung A23 devices. I do not yet have an update, although I want this fixed for v5.3.0

Also happening on a Samsung A54 5G Android 14.
@navaronbracke thanks for the hard work! Do you have any ETA for the 5.3.0?

@navaronbracke for me it's critical too, if you. have a working version want I can test it in the field, distributing a Beta App to affected users.

I am currently looking into landing a fix for a different issue, but after that, fixing the NV21 formats bug is next on my list.

I had another look at this issue and also had a look at what the camera plugin does.
CameraX always sends back YUV_420_888 image data, which cannot be changed.
However, the Android implementation of camera always converts YUV_420_888 to NV21, for sending back to Dart (in case people want to process frames on the Dart side). Conveniently, MLKit also requires NV21 as the format for the input images.
So we will have to always convert YUV_420_888 image data to NV21 before we pass it to the image analyzer.
I believe that this will require us to do the following:

Write a new converter class that converts image data to the NV21 image format

if the image data is already NV21, return the image dat as-is
if the image data is YUV_420_888, convert it to NV21
See https://github.com/flutter/packages/blob/b9ac917daeb0fbf5bd6ad4a7d2a69ab81749d767/packages/camera/camera_android/android/src/main/java/io/flutter/plugins/camera/media/ImageStreamReaderUtils.java#L16 for prior art, but be wary of copyright, so you're going to have to write this from scratch, using that implementation as guideline

In MobileScanner.kt convert the incoming image data to NV21 and only then call process() for he converted input image (this is probably the bug, as we do not convert anything in the current implementation)
Update the YuvToRgbConverter.kt class to handle the new workflow

depending on whether you keep or discard the original Yuv image data, you can keep the old converter around, or write a new converter that converts NV21 image data to RGB (but I fear that this is extra work that could be avoided? Because you would be adding an extra conversion in this case)
It uses some deprecated API's (see https://github.com/juliansteenbakker/mobile_scanner/issues/1142), so if you can fix that, please do
It also has some other warnings, which you might want to address, to keep the code maintainable

Do bear in mind when starting your work, to start from the ios-vision branch, as that is the current beta for version 7.0.0

@julfabre I would like to implement that fix, I’m waiting because I haven’t an affected phone in my hands. @navaronbracke, can the problem be simulated, forcing the weong camera output?

I don't have a Samsung device at hand either. I'm not sure if you can force the wrong camera output.
The problem isn't that the camera outputs frames in YUV_420_888 (which it always does), but that we pass those directly to MLKit, without converting these to NV21 first.


add isEnableCache option, fix memory lake

add isEnableCache option, fix memory lake on a dynamic line chart #1106

It is a trade-off between memory usage and CPU usage.
At this time we decided to sacrifice memory which leads to memory leaks.
If we put a flag, we sacrifice the CPU (a duplicate calculation happens every time). So nothing fixed.
Actually, I am considering deleting the cache system and dealing with the root issue (recalculation issue). There might be some ways to do that.
For example, we can make all of the minX, maxX, minY, and maxY nullable and calculate them in the chart widgets, so we can have a manageable memory and it removes when widget disposes (no more static variables)
What do you think?

Thank you for your response. I think the priority of avoiding OOM would be higher than CPU usage, and it might be necessary to provide a way to prevent OOM in dynamic lists before the cache system is fully optimized.
Unexpected crashes may bring unknown risks in scenarios where long-term operation is required, and could cause unnecessary trouble in production environments.

I also experience this problem wit flutter_bloc
@override
Widget build(BuildContext context) {
return BlocBuilder<GraphBloc, GraphState>(
builder: (context, state) {
return LineChart(
LineChartData(
lineBarsData: [
LineChartBarData(
spots: state.spots,   // List spots;
......
),
],
.......
),
.......
),
}
}
It causes heavy memory leaks.
version 0.61.0


[cda.pl] Support downloading playlist (folder)

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a site-specific feature
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Poland
Example URLs
https://www.cda.pl/NaukaToLubie/folder/16036449/vfilm
Provide a description that is worded well enough to be understood
In CDA videos may be placed in the folders.
It would be good to implement downloading entire folders just like playlists.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp -vU  https://www.cda.pl/NaukaToLubie/folder/16036449/vfilm
[debug] Command-line config: ['-vU', 'https://www.cda.pl/NaukaToLubie/folder/16036449/vfilm']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [4d9231208] (pip)
[debug] Python 3.10.12 (CPython x86_64 64bit) - Linux-6.5.0-44-generic-x86_64-with-glibc2.35 (OpenSSL 3.0.2 15 Mar 2022, glibc 2.35)
[debug] exe versions: none
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2020.06.20, mutagen-1.47.0, requests-2.32.3, secretstorage-3.3.1, sqlite3-3.37.2, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1830 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[generic] Extracting URL: https://www.cda.pl/NaukaToLubie/folder/16036449/vfilm
[generic] vfilm: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] vfilm: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://www.cda.pl/NaukaToLubie/folder/16036449/vfilm
Traceback (most recent call last):
  File "/home/pawel/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1626, in wrapper
    return func(self, *args, **kwargs)
  File "/home/pawel/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1761, in __extract_info
    ie_result = ie.extract(url)
  File "/home/pawel/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 740, in extract
    ie_result = self._real_extract(url)
  File "/home/pawel/.local/lib/python3.10/site-packages/yt_dlp/extractor/generic.py", line 2526, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.cda.pl/NaukaToLubie/folder/16036449/vfilm

Duplicate of #5429


feat(backend): Add methods for uploading images to User and Organization

Type of change

[ ] 🐛 Bug fix
[x] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ ] @clerk/clerk-expo
[x] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] @clerk/chrome-extension
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore

Description

[x] npm test runs as expected.
[x] npm run build runs as expected.

This PR adds:

updateOrganizationLogo method in OrganizationApi class
updateUserProfileImage method in UserApi class

@gkats @anagstef I believe we did some work in order to support images to be uploaded as DataURLs. This was done on FAPI. Is this something we could support here as well ?

@gkats @anagstef I believe we did some work in order to support images to be uploaded as DataURLs. This was done on FAPI. Is this something we could support here as well ?

@panteliselef It would be a nice-to-have thing, and also to be consistent between FAPI and BAPI. Although, I don't think we actually need it. The Base64 support was implemented mainly to support Expo users. You can create a Blob/FIle from a Base64 string easily.

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


ionic state save not saving version info to package.json

Hi,
I recently install version 1.1.0 of cordova-plugin-whitelist using:
cordova plugin add<EMAIL_ADDRESS>
I did this to tag the specific version of whitelist plugin. after this, I saved the state using
ionic state save

However, I found that tag was not there for plugin in package.json, manually updating the package.json installs the correct version with ** ionic state restore **, but, sate save is not saving version information to package.json
-Ravish

any update on this?

this is unsettling for me, too
Is there any new status on it?

related: #665

I have found a workaround for this, which I am going to try, in Apache Cordova documentations, here : https://cordova.apache.org/docs/en/dev/platform_plugin_versioning_ref/

Hello all! Thanks for opening an issue with us. We are currently in the process of deprecating the ionic state commands in favor of doing it the cordova way. https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/index.html You can keep up with the status of this on #904 . Thanks for using Ionic!


controller/engine: use local cache for client read requests

Description of your changes
Two changes:

The controller engine starts a new cache to run controllers dynamically against changing GVRs/GVKs. The cache holds informers and the informers back clients. In today's design, every new cache will lead to new informers even though the parent manager might already have an informer. This PR changes that by sharing the parent cache for all GVRs/GVKs, and only route the dynamic GVR to the new one.
This is an optimization in general, but it is especially interesting and necessary in https://github.com/crossplane/crossplane/pull/4637 to share MR informers.
This PRs introduces a cache wrapper that can route by GVK. A similar thing exists in controller-runtime, but it is not exposed.

Indexes can only added to an informer before it is started. To allow custom indexes, Start is split into creation and the actual start of the controller (and its backing cache).

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
Through https://github.com/crossplane/crossplane/pull/4637 and through unit tests.

In today's design, every new manager will lead to new informers even though the parent manager might already have an informer.

I haven't had a chance to look closely at this yet, but I wanted to note that there was a reason for this. It's been a while, but I'm pretty sure it had something to do with not being able to stop an individual informer cleanly, at least at the time this code was added.

but I'm pretty sure it had something to do with not being able to stop an individual informer cleanly

I get that. It's still the case in controller-runtime (not so in client-go). My point in this PR is that there is no need to start a new cache for everything else than the GVK you want to dynamically watch. I.e. this PR gives you composition for caches.

@negz addressed all comments.


Terraform apply failing when we are changing eks module from 3.0.0 to 6.0.0 with terraform 12

I have issues
Error updating Autoscaling group: ValidationError: You must use a valid fully-formed launch template. The requested configuration is currently not supported. Please check the documentation for supported configurations.
status code: 400, request id: 4503322f-238f-412c-8c21-7378b87ff9c2
I'm submitting a...

[x] bug report
[ ] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
If this is a bug, how to reproduce? Please include a code sample if relevant.
What's the expected behavior?
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details
eks 1.15

Affected module version:
OS:
Terraform version:
0.12.9

Any other relevant info

please go thru module Release notes
https://github.com/terraform-aws-modules/terraform-aws-eks/releases?after=v8.0.0
as in sure in v6 are documented breaking changes


simple error_log Log Handler

Description
A simple Log Handler for error_log.
We use this Handler to log to stdout for Docker Container.
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[x] User guide updated
[x] Conforms to style guide

@rwillert Are you able to make these revisions?

Whoops, I didn't notice that! Glad you were still able to use the content.


New version: zafaco.Breitbandmessung version 3.6.0

- [X] Have you signed the Contributor License Agreement?

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

(Automated response - build 660.)


Interest in updates and new features?

Hey @mojbro, it's been a few years since this repo saw the last update. It was necessary for me to create a fork in order to use gocoa as a backend for Spot, a small cross-platform GUI toolkit I'm working on. Are you interesting in upstreaming the existing (and future) changes, or should I keep it separate? I'll try to keep an up-to-date list in the README of the fork, currently it lists only these changes:

e85e4be progressindicator: Don't hide by default as this would increase time to create widgets in the first place
724ee73 textview: Add hacky SetFontSize functionality.
57058d9 window: Flip all views by default
c93457a application: Add RunOnMainLoop

Hi @roblillack! Happy to hear this old project is still useful to someone. It was really just something I made for fun but as you see I'm not actively maintaining it by any means, but I'm quite available on GitHub. I'd love for you to upstream the changes. I'll have a look through what you've done during the day.

That's great to hear! Biggest hurdle will be the "flipped view" addition, IMHO. I need to make sure to have a "traditional" coordinate system (y=0 is the top of the window), don't know how to best make this an option and if it should be exposed as a flag or maybe a build tag.


[release-1.6] patch caBundle for webhook config in remote cluster

Manual cherrypick required.
#23758 failed to apply on top of branch "release-1.6":
error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	mixer/adapter/kubernetesenv/kubernetesenv.go
M	pilot/pkg/bootstrap/server.go
M	pilot/pkg/bootstrap/sidecarinjector.go
M	pilot/pkg/serviceregistry/kube/controller/controller.go
M	pilot/pkg/serviceregistry/kube/controller/multicluster.go
M	pkg/kube/secretcontroller/secretcontroller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/kube/secretcontroller/secretcontroller.go
Auto-merging pilot/pkg/serviceregistry/kube/controller/multicluster.go
CONFLICT (content): Merge conflict in pilot/pkg/serviceregistry/kube/controller/multicluster.go
Auto-merging pilot/pkg/serviceregistry/kube/controller/controller.go
Auto-merging pilot/pkg/bootstrap/sidecarinjector.go
CONFLICT (content): Merge conflict in pilot/pkg/bootstrap/sidecarinjector.go
Auto-merging pilot/pkg/bootstrap/server.go
CONFLICT (content): Merge conflict in pilot/pkg/bootstrap/server.go
Auto-merging mixer/adapter/kubernetesenv/kubernetesenv.go
Patch failed at 0001 patch caBundle for webhook config in remote cluster

Manual created PR - https://github.com/istio/istio/pull/23820

@irisdingbj the PR is getting complicated so I closed the manual merged PR.  It is intermingled with #23331 and not sure if it is in 1.6 yet.  please manually generate a PR yourself, thank you!


messagegui: write "remove" messages to flash

Whoops: we didn't handle these at all, but are actually responsible for
saving them, even if the UI won't be launched.
Fixes #2380

Actually, maybe we should do this in the messages library?
i.e. always write remove mesages to flash.

Thanks! But yes, I'd say the messages lib should really handle this - I know we have some optimisations now, but I guess in an ideal world the GUI wouldn't have to worry about message handling from Android/iOS at all - it would just look at the messages list and show what was there, and re-read the list whenever it was notified.

we have some optimisations now, but I guess in an ideal world the GUI wouldn't have to worry about message handling from Android/iOS at all

Yes, and it also bugs me how much duplicate functionality messagegui and messagelist have.
I'm starting to think making the UI decide whether to launch itself might be a mistake, and we should just move that code into the library.

just look at the messages list and show what was there, and re-read the list whenever it was notified.

Maybe we can come up with some smart way for the library to decide to (transparently) keep the list in memory instead of writing to flash immediately?
I wouldn't mind complicating the library a bit more if it means all UI apps can become simpler.

Thank you!
I can confirm that this PR fixes dismissing a notification via Gadgetbridge after it's been received in the background.
(Note to self: Make sure Quiet Mode is set to Off before wondering why it doesn't seem to be working…  I didn't realize I had broken my JavaScript snippet to toggle that with Tasker hooks to the Sleep as Android app.)

I'm starting to think making the UI decide whether to launch itself might be a mistake, and we should just move that code into the library.

Do you think anyone might want to make a GUI that behaves differently? If they do maybe we have to keep it as-is :(

Do you think anyone might want to make a GUI that behaves differently?

Maybe, but it can always set msg.handled=true.

if anyone wants anything different they just set handled=true and do it themselves in whatever case?

Yes, that's the idea.


Hiragana or Kanji

Does this works with all chars available? I tried to run it with 2 Kanjis, it went without any display, it worked with hiragana.
How does one remove generated emojis?

Thanks for your comments @uhlhosting!

Does this works with all chars available? I tried to run it with 2 Kanjis, it went without any display, it worked with hiragana.

For now, only few Kanjis (e.g: 木, 林) can be used for emojis, but I don't understand exactly which kanjis can be used.

I'm sorry that this limitations has been written in only Japanese in README.md.

(For Japanese) 平仮名は絵文字にできますが漢字はほんの一部のみ画像化できるようです（カタカナはダメ）。https://github.com/pbnjay/pixfont で漢字なども画像化できる方法があれば可能になるかもしれません。

And this limitation comes from the limitation of https://github.com/pbnjay/pixfont, so it is needed to know more about pbnjay/pixfont.

How does one remove generated emojis?

You can remove generated emoji in "Custom Emoji" manually.

And this plugin is developed for old Mattermost plugin architecture, so may not work for latest Mattermost release.

@kaakaa any plans to update it for new release architecture. Maybe it works only with main Kanjis, Japanese is a language or wonders.
Domo arigato gozaimasu

Updated emojigen plugin to v0.1.0 for new Mattemrost plugin architecture.
https://github.com/kaakaa/mattermost-emojigen/releases/tag/v0.1.0
I tested this on Mattemrost 5.10, and it works fine for me.

Maybe it works only with main Kanjis, Japanese is a language or wonders.

Could be... Since Japanese (or Kanjis) has some complexity, it may be hard to support all characters. I'll take a look into pbnjay/pixfont.

Domo arigato gozaimasu

どういたしまして! 😄  (You're welcome!)

@uhlhosting
I've released v0.2.0.
It uses M+ Fonts for generating emoji instead of pbnjay/pixfont, and can generate most of Japanese characters including Kanjis. (but it might not generate Chinese and Koreans...)

If you have a time, please try new version of mattermost-emojigen!
I close this issue because I supposed that this issue have been resolve. But feel free to reopen this issue if you encountered any problem related to this issue.
Thanks.


Android not compiling on RN v0.44.0-rc.0+

Problem
The library is not compiling with React Native version 0.44.0-rc.0-0.47.0-rc4
Error
:react-native-svg:incrementalReleaseJavaCompilationSafeguard UP-TO-DATE
:react-native-svg:compileReleaseJavaWithJavac
:react-native-svg:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/Users/tastycode/workspace/mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/SvgView.java:130: error: method obtain in class TouchEvent cannot be applied to given types;
            TouchEvent.obtain(
                      ^
  required: int,TouchEventType,MotionEvent,long,float,float,TouchEventCoalescingKeyHelper
  found: int,TouchEventType,MotionEvent,float,float,TouchEventCoalescingKeyHelper
  reason: actual and formal argument lists differ in length
1 error
:react-native-svg:compileReleaseJavaWithJavac FAILED

Cause
TouchEvent.obtain's signature changed in https://github.com/facebook/react-native/commit/d2939eafbf56f99ea4da7374b9812ae6f54c1d3d
Solution
The fix should be to import SystemClock and add the gestureStartTime argument to SvgView

Turns out this is fixed in https://github.com/react-native-community/react-native-svg/commit/2fd178da2872a169e13100308e0cff524197e26a but no version references that commit, so downstream users are required to reference that commit directly. Duplicate of #322


ImportError: No module named kivy3.cameras

Hey i just installed your library with python 3.5 and i get this error:
[martin@hodeb examples]$ python3 example1.py
[INFO   ] [Logger      ] Record log in /home/martin/.kivy/logs/kivy_16-11-19_8.txt
[INFO   ] [Kivy        ] v1.9.1
[INFO   ] [Python      ] v3.5.2 (default, Nov  7 2016, 11:31:36)
[GCC 6.2.1 20160830]
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2, img_pil (img_ffpyplayer ignored)
 Traceback (most recent call last):
   File "example1.py", line 31, in <module>
     import kivy3
   File "/usr/lib/python3.5/site-packages/Kivy3-0.1-py3.5.egg/kivy3/__init__.py", line 5, in <module>
     from .cameras import PerspectiveCamera, OrthographicCamera
 ImportError: No module named 'kivy3.cameras'

it has something to do with this commit:
https://github.com/nskrypnik/kivy3/commit/166c922d5aab59b509e0b3b50551ddac5a42c95a
However another error occurs when i try an older version.
Then kivy gets a bit further but eventually spits out this:
[martin@hodeb examples]$ python3 example1.py
[INFO   ] [Logger      ] Record log in /home/martin/.kivy/logs/kivy_16-11-19_11.txt
[INFO   ] [Kivy        ] v1.9.1
[INFO   ] [Python      ] v3.5.2 (default, Nov  7 2016, 11:31:36)
[GCC 6.2.1 20160830]
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_gif, img_sdl2, img_pil (img_ffpyplayer ignored)
[INFO   ] [Factory     ] 179 symbols loaded
[INFO   ] [OSC         ] using <multiprocessing> for socket
[INFO   ] [Window      ] Provider: sdl2(['window_egl_rpi'] ignored)
[INFO   ] [GL          ] OpenGL version <b'4.5.0 NVIDIA 375.20'>
[INFO   ] [GL          ] OpenGL vendor <b'NVIDIA Corporation'>
[INFO   ] [GL          ] OpenGL renderer <b'GeForce GTX 660/PCIe/SSE2'>
[INFO   ] [GL          ] OpenGL parsed version: 4, 5
[INFO   ] [GL          ] Shading version <b'4.50 NVIDIA'>
[INFO   ] [GL          ] Texture max size <16384>
[INFO   ] [GL          ] Texture max units <32>
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
[INFO   ] [GL          ] NPOT texture support is available
[INFO   ] [Shader      ] Read </home/martin/python/libraries/kivy3/examples/./simple.glsl>
 Traceback (most recent call last):
   File "example1.py", line 71, in <module>
     MainApp().run()
   File "/usr/lib/python3.5/site-packages/kivy/app.py", line 802, in run
     root = self.build()
   File "example1.py", line 53, in build
     obj = loader.load(obj_path)
   File "/usr/lib/python3.5/site-packages/Kivy3-0.1-py3.5.egg/kivy3/loaders/objloader.py", line 205, in load
     return super(OBJLoader, self).load(source, **kw)
   File "/usr/lib/python3.5/site-packages/Kivy3-0.1-py3.5.egg/kivy3/loaders/loader.py", line 71, in load
     return self.parse()
   File "/usr/lib/python3.5/site-packages/Kivy3-0.1-py3.5.egg/kivy3/loaders/objloader.py", line 212, in parse
     obj.add(wvobj.convert_to_mesh())
   File "/usr/lib/python3.5/site-packages/Kivy3-0.1-py3.5.egg/kivy3/loaders/objloader.py", line 62, in convert_to_mesh
     material = Material()
   File "/usr/lib/python3.5/site-packages/Kivy3-0.1-py3.5.egg/kivy3/materials.py", line 52, in __init__
     for k, v in kw.iteritems():
 AttributeError: 'dict' object has no attribute 'iteritems'

Do you know what could be causing this? Im not that used to kivy yet so i cant really read your code.

I couldn't get the ImportError, but the second one it py3 related:
AttributeError: 'dict' object has no attribute 'iteritems'

This happened. The repo is probably py2, but it should be easy to fix with kw.items() on that line.

As KeyWeeUsr mentioned above the repository is really for python 2, so that's why you get an error with py3. Haven't been working with Python for almost two years so don't really now how to maintain repos for both py2 and py3.
Anyway abt that cameras issue - it has been resolved. Try to pull.


map_cr expands in cases where it shouldn't

Description
test|; ->
test
  |

is different from (test|) ->
(test
|)

I personally feel like the first case is wrong.
Mapping  bug
1.If you report a bug about indent. Please remember that plugin doesn't do anything about indent.
It just trigger the indent of your vim config so if you have wrong indent config then it will do wrong indent.
You can check by select a block of code and press ==
2. provide result of command :verbose imap <cr>.
Steps to reproduce
No response
Minimal config
vim.cmd [[set runtimepath=$VIMRUNTIME]]
vim.cmd [[set packpath=/tmp/nvim/site]]
local package_root = '/tmp/nvim/site/pack'
local install_path = package_root .. '/packer/start/packer.nvim'
local function load_plugins()
  require('packer').startup {
    {
      'wbthomason/packer.nvim',
      {
        'windwp/nvim-autopairs',
      },
      -- ADD PLUGINS THAT ARE _NECESSARY_ FOR REPRODUCING THE ISSUE
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. '/plugin/packer_compiled.lua',
      display = { non_interactive = true },
    },
  }
end
_G.load_config = function()
  require('nvim-autopairs').setup()
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing nvim-autopairs and dependencies.")
  vim.fn.system { 'git', 'clone', '--depth=1', 'https://github.com/wbthomason/packer.nvim', install_path }
end
load_plugins()
require('packer').sync()
vim.cmd [[autocmd User PackerComplete ++once echo "Ready!" | lua load_config()]]

The first case is similar to what VSCode does, and I think it would be better to support the most common use case, similar to other editors. You can't change that rule if you don't want to


Security Event and Windows Event User management

Required items, please complete
Change(s):

Created a new file for Windows Event and added Windows parser in it. In Security Event file removed Windows Event parser and in ASimUserManagement added Windows Event Parser name  and same changes have done for vim as well.

Reason for Change(s):

To Split the Security Event and Windows Event parser separately

Version Updated:

yes

Testing Completed:

yes

Checked that the validations are passing and have addressed any issues that are present:

yes

Hi @Alekhya0824,
Please check above comments and act accordingly. Thanks

Hi @Alekhya0824,
Please work on the open comments of the reviewer. Thanks

Hi @Alekhya0824,
We are waiting for your reply. Thanks

Hi @Alekhya0824,
Could you please address the reviewer’s open comments?

Hi @Alekhya0824,
There are a few open comments from the reviewer; please act on them. Thanks

Hi @Alekhya0824,
Please act on reviewer's open comments. Thanks

Hi @Alekhya0824,
I can see a few open comments from the reviewer. Please act on them.

And also, one suggestion: once you're done with the open comment change, please click on the Resolve Conversation button


definition "carbohydrate metabolic process'

Definition is:
The chemical reactions and pathways involving carbohydrates, any of a group of organic compounds based of the general formula Cx(H2O)y. Includes the formation of carbohydrate derivatives by the addition of a carbohydrate residue to another molecule.
Should " Includes the formation of carbohydrate derivatives by the addition of a carbohydrate residue to another molecule." be removed? It isn't true?
https://www.ebi.ac.uk/QuickGO/term/GO:1901135

Right, I think this is how it was used in the past but we dont do that anymore.


Airlock - Add data copy event and act upon it (prepare for new data copy mechanisms)

Description
As a TRE Developer
I want to add the data copy event and have the airlock processor react to it and initiate the copy of data
So that we can add more data copy mechanisms
Today, the AL processor immediatly starts to copy data when needed. instead, send a data copy event.
The AL processor will also consume this event and start the copy. Adding disable flag to not consume this event will allow other copy mechanisms to listen on this event and do something different
Acceptance criteria

[ ] Add data copy event
[ ] consume this event and use the currently  used data copy mechanism (Azure Rest calls) to copy data
[ ] add a flag to disable the consumption of this event by the AL processor
[ ] ...

We decided the current-internal way to copy data is enough for the scenarios we saw. Closing for now.


Print compartment ID in connect_redirect hook traces

Currently connect_redirect hook traces do not include compartment ID. It will be helpful to include compartment ID in the traces to debug in a multi-tenant environment.

Testing is a blocker - as it requires a 2 VM setup. Current guidance is to create a self hosted runner and run the ci-cd yml tests and capture the traces while connect_redirect_tests.exe are being run


Removing / un-registering hotkeys

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
Hotkeys can be added programatically using HotkeyService.addShortcut, but they can't be un-registered.
Expected behavior
A HotkeyService.removeShortcut allowing to delete shortcuts would be nice.
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
I'm using the library to implement a functionality where the users can assign hotkeys to specific actions. This is done through a custom service that keeps track of keyboard assignments, so I need a way to un-register hotkeys.
Environment

Angular version: X.Y.Z

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

Sure. Do you want to submit a PR?

Sure! I think I can come up with something in a couple of days, I'll keep you posted


Remove gcc pragmas from QUIC code

Remove gcc pragmas from QUIC code now that the underlying issues have been resolved.
Signed-off-by: Ryan Hamilton<EMAIL_ADDRESS>Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

/retest

/assign @jmarantz

@jmarantz hopefully this should be a trivial review!


Update cask_request.md

Comment out a part so that it wouldn't be submitted
This is an updated template so that the comment can be seen when writing the issue, but it will not be previewed because it becomes repetitive to appear in every request.

I hope you like the edit. Let me know what you think. I think it will clean up some stuff.

Alright, now there are too many changes. Making some parts comments is fine, but all the rest was carefully worded and exactly as intended after many iterations. Please revert everything except making the comments.


Create some code to convert .tiff to jpg

Is your feature request related to a problem? Please describe.
This dataset is using .tiff: https://sites.uef.fi/spectral/odsi-db/
Each file is big and apparently embeds spectral image (one image per frequency range) + a RGB image encoded in 24-bit (usually a JPG is 8-bit).
Describe the solution you'd like
A function to convert
Describe alternatives you've considered
Following modules / posts are a good start:

https://github.com/lfsantosgeo/ConvertTiff2Jpg/blob/master/convertTiff2Jpg.py
https://stackoverflow.com/questions/57809780/how-to-convert-tif-image-to-jpg-using-skimage

Additional context
DL201

https://cs.uef.fi/pub/color/spectra/ODSI-DB/

The database is available for download here. The oral and dental spectral image files are multipage TIFF images. The first
page contains a 24-bit RGB preview image, followed by grayscale spectral band images (16-bit grayscale). The files utilize tag system of TIFF files to store the spectral band center wavelengths in tag 65000 as list of 32-bit floating point values, and tag 65111 to store a free-form ASCII metadata string. The metadata string contains information about the imaging setup, image processing and miscellaneous measurement data (blood pressure and oxygen saturation before and after measurement).
Annotation files are likewise multipage TIFF images. Each page of the annotation image file contains a binary black-and-white mask image and has the annotation class stored as an ASCII-string in tag 65001.
Python functions for reading and writing spectral image TIFFs and annotation mask TIFFs are provided in the spectral_tiffs.py file in the database root directory.
Complete spectral image database is 34 GB in size.

There is some code here that allows to read a TIFF file page per page. It uses tifffile package here and github but if we can avoid the dependency, it may be better

Just did a few experiments in a notebook and we can do what we want just with PIL.
For the image themselves, it is super simple to extract the RGB using PIL.Image.
im = PIL.Image.open(path2TIFF) will load the image with only the three RGB channels.
Then we can than save the image again as jpg for instance to create the new dataset.
To extract each of the pages, we can do it with ImageSequence:
im = Image.open(path2masks)
for i, page in enumerate(ImageSequence.Iterator(im)):
    display(page)
will display each of the masks
The only thing that need to be done from here is to extract the name of the class for each of the masks. Will look at this later.


Next Prayer Time (nextPrayer())

How can I set nextPrayer() method in java version of this (blessed) library ?
I tried the same way that the normal sequence of prayer times are set like this 👉  binding.nextPrayerTime.setText(" "+ format.format(nextPray.nextPrayer());
But the app crashes at start up.

may you send the example of code you are using and the exception / crash you're seeing?

closing, please re-open if you still have an issue with this.


File rename modal not visible

Is the bug present when using the default Obsidian theme?
No
Is the bug present when snippets and plugins are disabled?
No
Minimal theme version
0.6.12
Describe the bug
Bug manifests when using two settings:

Style settings plugin with Minimal > Tab title bar > Tab title visibility > Hover only
inline titles disabled in main obsidian appereance settings

In this circumstances when you try to rename current file by pressing F2, the modal rename dialog does not appear. You can still change the title however, because the focus is left on invisible tab title - you just can't see what is happening.
I think that if the title in tab is not visible the theme should fall back to rename modal window.
Debug info
SYSTEM INFO:
Obsidian version: v1.0.0
Installer version: v0.15.9
Operating system: #1 SMP PREEMPT_DYNAMIC Debian 5.19.11-1 (2022-09-24) 5.19.0-2-amd64
Login status: logged in
Catalyst license: supporter
Insider build toggle: on
Live preview: on
Legacy editor: off
Base theme: dark
Community theme: Minimal
Snippets enabled: 0
Restricted mode: off
Plugins installed: 11
Plugins enabled: 9
1: Jump to link v0.4.4
2: Obsidian Git v2.5.1
3: Pane Relief v0.4.0
4: Paste URL into selection v1.7.0
5: Auto Note Mover v1.2.0
6: Dataview v0.5.46
7: Calendar v1.5.10
8: Minimal Theme Settings v6.0.5
9: Style Settings v0.4.12

Closed in 6.0.13
https://github.com/kepano/obsidian-minimal/releases/tag/6.0.13


Expand urlsToWatch diagnostic check

Currently we show an error when the urlsToWatch array is empty, however

urlsToWatch is optional
urlsToWatch can be defined on a plugin instance

We should update the check so that an error is shown if plugins don't have urlsToWatch set and there is no global array set, or the global array is empty.

Rather than continue with this, we should remove the check as urlsToWatch is no longer required in the config file as they can be passed as arguments, instead we should remove this check.


feat: add proxy support

Hello,
This PR introduces the capability to specify a proxy server for callKickApi().
This feature is particularly useful for scenarios where you have an IP not blocked (or whitelisted) on the Kick API, but your code is executed from a different server.
By specifying the proxy, all requests will be routed through it without needing to relocate your server. Here’s how you can use this new feature:
await kick.api.authentication.login(
    {
        email: kick.mail,
        password: kick.password,
        otc: token,
    }, { proxy: 'http://proxyserver:port' }
)

For this I've created an new interface, LoginOptions and moved kickAuthHeader inside. This will make it easier to manage any future additions that may be necessary.
If you don't want to use an interface for this, I'm open to suggestions.

LGTM, this was something I wanted to do at some point but kept getting pushed back as I personally had no need for it.
I think setting the proxy on the login method seems odd to me, as I feel like you could use Kient without authenticating whilst still being on a whitelisted IP but this flow wouldn't allow that. Moving the options interface to the Kient.create method where you first create the Kient instance makes more sense. For example, Kient.create({ proxy: 'http://proxyserver:port' }) which can just be passed down to the ApiClient instance and set in CycleTLS within the constructor, like you have already done. I think we could either access the proxy options via this._client.options.proxy (keeping them within the main Kient class) in the ApiClient class, or by passing the options to the ApiClient via a param in it's constructor.
Happy to open up some feedback on that though on what you think. If the login method makes more sense, I'm happy to merge it in :)

... However, should I restore the functionality of kickAuthHeader as it was previously, or should I also move it into Kient.create ?

Great question. I actually don't know what the x-kick-auth header is specifically as I don't have one, it was added in #6. My best guess is that it's a key, provided by Kick, that bypasses Cloudflare when provided, instead of utilising a whitelisted IP, but I'm not wholly sure. If it's to do with the overall bypassing of Cloudflare, then yeah I would probably see more sense in it being on Kient.create.

Closed in favor of #25


KubeEdge: fix build

This PR makes KubeEdge's build.sh script to support go work. Kubeedge is being reinvented to support go work https://github.com/kubeedge/kubeedge/pull/5774. An error occurred while running CIFuzz, as follows:
'go mod vendor' cannot be run in workspace mode. Run 'go work vendor' to vendor the workspace or set 'GOWORK=off' to exit workspace mode.

@DavidKorczynski Please take a look :-)


Is Chinese-Mistral-7B-Instruct fine-tuned on mistralai/Mistral-7B-Instruct-v0.1 or mistralai/Mistral-7B-v0.1 ?

It is fine-tuned on https://huggingface.co/itpossible/Chinese-Mistral-7B-v0.1.


add methods to timer API

This PR adds the following methods to the timer API:

get_time: returns time for a given phase
get_phases: returns a list of phases whose times equal a given time, adjusted for a given precision
max_time: returns the max time of all phases
min_time: returns the min time of all phases
total_time: returns the total time of all phases
average: returns the average time of all phases

@RoastSea8 what is get_phases useful for?


[Draft] Migrate the CLI to v2 of the golang sdk

Description of changes:

Initial work on migrating the app to version 2 of the SDK (App has largely been migrated to the new SDK's with equivalent functionality). Obviously this would be a new major version of the product.

Current list of items to finish

[ ] Some functionality has been dropped relating to the injection of regions from different sources which needs restoring (cmd/main.go)
[ ] There's still a hard dependency on the v1 sdk endpoints package in odpricing.go which will likely require some work on the smithy side of things to generate a mapping between regions and descriptions (it's in the smithy generated json file but not in the golang sdk).
[x] Tests are still a WIP and some more minor restructuring will likely be required as part of that.
[x] Propagation of contexts through the stack

Why Migrate to v2

~At the end of this the overall binary should be a bit smaller by the modular nature of the new sdk~ i was wrong it's bigger - what can you do 🤷
Some projects that depend on this (e.g. eksctl) are currently having to create two sessions - one in the v2 sdk for all their direct dependencies and one in the v1 sdk for this project
Stronger typehints on the vm wrapper

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hey! Thanks for working on this! Curious what the binary size diff was on the WIP for this PR? Seems valuable to do anyways to support clients using v2 versus v1. I suppose if a client is using v1 though, this change would pull in the additional v2 deps for their binary (I think kOps uses v1). I would guess the binary sizes wouldn't be radically different though since the unused packages would shaken out during compilation.

Interestingly bigger. Looks like the ec2 serializers are pretty hefty https://github.com/aws/aws-sdk-go-v2/blob/main/service/ec2/serializers.go about 60k lines :) about 33MB for now - but 3MB of that is the v1 package endpoints - which like I say can probably be removed in favour of smithy generated stuff.
I've committed fixes for the last 2 tests (at least they pass now locally). Would be good to get a retrigger on the tests here to see if they pass on the git workflows

@wilsonge We've been maintaining the THIRD_PARTY_LICENSES file by hand. You can copy/paste and follow the same formatting for any new libraries.

@snay2 / @bwagner5 sorry to be a pain but could i get you to retrigger the workflow please

OK So tests here look good. What's the next steps. I think this one needs some proper human code review too because there's an awful lot of changes.

@wilsonge Have you finished the tasks you outlined in the PR description? If so, I'd say check those off and remove "draft" from the title, and we'll start reviewing the code.

Hi 👋 - reaching out on eksctl behalf, we're also looking forward to completely migrate to go sdk v2. Is there any chance the work on this PR will be picked up from where it was left in the foreseeable future?

hi @TiberiuGC. I wasn't aware that eksctl had a dependency on EC2 Instance Selector. Can you give us more detail as to how you're utilizing this tool. It would help with our prioritization of this PR because it looks like this may require another developer to pick up where @wilsonge has left off.

@jillmon when creating (clusters with) nodegroups using eksctl, users have the option to specify the properties they want for their nodes e.g.
eksctl create nodegroup --instance-selector-
--instance-selector-cpu-architecture  -- x86_64, or arm64
--instance-selector-gpus              -- an integer value
--instance-selector-memory            -- 4 or 4GiB
--instance-selector-vcpus             -- an integer value (2, 4 etc)

and we let instance selector do it's magic on deciding the instance types.
As to why this PR is relevant for us, I think @wilsonge explained it well in the description

Why Migrate to V2
...
Some projects that depend on this (e.g. eksctl) are currently having to create two sessions - one in the v2 sdk for all their direct dependencies and one in the v1 sdk for this project.

Let me know if I can provide any more info 🙏

I've rebased this onto the latest main branch and applied most the review comments. There's still my todo's listed above (on me but if someone else wants to pick them up as I don't have huge amounts of time just let me know) and the outstanding item about the region lists which I still believe needs an AWS staff member to be resolved.

Pushed up the latest changes requested. I've also pushed a change to better handle the aws context usage for the pricing client that will need a quick review on top of the previous stuff.

Resolved merge conflicts locally then squashed and pushed all changes.


Can't resolve ~db or ~imports

Bug Report
Describe the bug
I have the feeling that after this commit I can't run docz anymore: https://github.com/pedronauck/docz/commit/6d9bb2507b3a23aff825a1a2efd53bcdc8080240#diff-1e7a151ea59cd3f5090a28e374906791
It shows me this error;
These dependencies were not found:

* ~db in ./node_modules/docz/dist/index.m.js
* ~imports in ./node_modules/docz/dist/index.m
.js

To install them, you can run: npm install --sa
ve ~db ~imports

I tried already re-installing all node modules and deleting cache, but that didn't work.
It seems to be broken from version 0.12.10 and up. 0.12.9 is still working.
A clear and concise description of what the bug is.
Docz won't start.
Environment
Mac OSX Mojave.
Node 8.11.3
Npm 6.3.0

can you show me a little bit version of your repo @JeroenReumkens?

Thanks for the quick reply @pedronauck  I'm right now diving a little bit deeper. I just upgrade from 0.12.5 to the latest version, and then it broke. But after a clean install I see 0.12.9 is also broken. So it might be that there is indeed in something wrong in my repo. I'm trying to narrow it down now.

@minheq I didn’t face any issues with jest. I extended the webpack config in the docz config file and added the alias override in there. However I added a complete new object as module.aliases since there weren’t any in docz at that time. Changing if from overriding to extending fixed it.

@JeroenReumkens thanks for the info, i think our use case differed.
My use case was to run snapshot tests of all components rendered in docz. In case anyone was curious about implementation (requires more polish as of 8th December 2018):
https://github.com/WeTrustPlatform/paramount/commit/46f1225d63e599ef38d3184610aa43b6da42bc60

You need to merge your alias with the docz default aliases. Use something like webpack-merge is a good option to prevent errors :)

An additional solution that I've found is to do an Object.assign with the existing docz aliases and my desired custom aliases like so:
const aliases = require('./path-to-custom/aliases');

export default {
  modifyBundlerConfig : (config) => {
    // Combine the default docz aliases with our custom aliases from an external file
    config.resolve.alias = Object.assign({}, config.resolve.alias, aliases);
    return config;
  }
};

For my particular project, logging config.resolve.alias within the modifyBundlerConfig function yields:
{
  '~db': '[PROJECT_ROOT]/.docz/app/db.json',
  '~imports': '[PROJECT_ROOT]/.docz/app/imports.js',
  'react-native$': 'react-native-web'
}

showing that the alias object is setup with these "defaults" and thus custom aliases need to be added on via Object.assign or similar.
While the webpack-merge is probably the better solution for a more robust build, this works for something a bit smaller.


Fix broken initial offset on reset on a non64 bit boundary

Fixes broken initial offset on reset on a non64 bit boundary
Proposed Changes

Take the relativeOffset/wordSize remainder into account when resetting initialOffset

@hadriansecurity

thanks @EndPositive for helping us with this issue.
Some background info. In our production system, after a "random" time we saw that the lag on a single partition was rising and slowly extending to other partitions as well. A reboot of the dispatcher was required to get it up and running again. Starting with the last committed offset. Impact is thus significant.
We decided to dive into it and found at that the offset of that partition is not committed anymore. Each time after a partition receives roughly 1.000.000 new events. This bug (especially with out-of-order processing) can explain this. The offset administration does not correspond anymore with the actual offset.

Flake
/test unit-tests

/test reconciler-tests-namespaced-broker

/cherry-pick release-1.9

/cherry-pick release-1.8


disableFontFace is not working properly as in older Versions

Hi Team,
We develop a 3D flipbook using PDF.js. Recently while integrating a newer version of PDF.js we encountered fontface issues, which would normally happen when using a IOS device. disableFontFace is auto set to true in those IOS devices. Unfortunately, it's working properly as it used to. Are we missing something extra to implement?
Live Scenario:
Attach (recommended) or Link to PDF file here:
The-Angels-Magazine-April-2020.pdf
Configuration:

Web browser and its version: Any browser - recommended: Chrome Version 81.0.4044.122 (Official Build) (64-bit)
Operating system and its version: Windows 10
PDF.js version: 2.3.200
Is a browser extension: no

Steps to reproduce the problem:

Goto Link: https://dearflip.com/pdf-viewer/
Check "Disable FontFace(IOS issues)" checkbox ( see screenshot)
Open the attached PDF (The-Angels-Magazine-April-2020.pdf)

For custom environment: set disabledFontFace =  true and use the attached PDF
What is the expected behavior?
The text should be displayed as it was displayed using older versions. (right side of the screenshot below)
What went wrong? (add screenshot)
The text is not displayed in new versions of PDF.js. (Left side of the below screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
New version of PDF.js with fontface issues:
https://dearflip.com/pdf-viewer/
Old Version of PDF.js that doesn't have the issue:
https://dearflip.com/examples/jquery/demo-open-file.html
Best,
DearFlip Team

Duplicate of #4244


Automator: update common-files@master in istio/istio@master

Generated by Automator - 2020-10-15T21:17:49+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
c8579f77619c9fa767562668dadc0059bc227d8b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio


Roll engine c327cae7ab5e..866b158c4b13 (2 commits)

https://github.com/flutter/engine/compare/c327cae7ab5e...866b158c4b13
git log c327cae7ab5e..866b158c4b13 --first-parent --oneline
2019-12-18<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from WSlsF... to jsuQq... (flutter/engine#14550)
2019-12-18<EMAIL_ADDRESS>Roll src/third_party/skia 37a88b43637e..21df075cab00 (2 commits) (flutter/engine#14549)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Trybots failed. These were the failed builds: https://github.com/flutter/flutter/runs/354920219 , https://github.com/flutter/flutter/runs/354920184 , https://github.com/flutter/flutter/runs/354920170

Commit queue failed; closing this roll.


Update cf-deployer and reactor versions

This PR requires spring-cloud/spring-cloud-dataflow-server-cloudfoundry#323.

	<properties>
		<spring-cloud-dataflow.version>1.2.0.RC1</spring-cloud-dataflow.version>
		<spring-cloud-deployer-cloudfoundry.version>1.2.0.RC1</spring-cloud-deployer-cloudfoundry.version>
		<spring-cloud-deployer-spi.version>1.2.0.RC1</spring-cloud-deployer-spi.version>
		<reactor.version>3.0.6.RELEASE</reactor.version>
	</properties>

Update to data flow 1.2.0.RELEASE, deployer-cf 1.2.0.RELEASE, and deployer-spi 1.2.0.RELEASE and reactor 3.0.7.RELEASE

Updated to current available values via ebf5db6


introduced linter: golangci

Respective Git issue: https://github.com/DiceDB/dice/issues/312

Context
Requirement:
Need to install pre-commit
Steps:

Install pre-commit

$ pip install pre-commit

Verify Installation

$ pre-commit --version
pre-commit 3.8.0

Install the git hook scripts

$ pre-commit install
pre-commit installed at .git/hooks/pre-commit

(optional) Run against all the files

$ pre-commit run --all-files

[Note: Since all the linter issues are already taken care, no need to run against all files]

Results:

Unit Tests After all changes

Awesome, thanks for adding this. We should probably add this to CONTRIBUTING.md as well. Could you add the steps you've mentioned in the PR description into it?

Thanks for reminding me. updated the documentation. Please check @JyotinderSingh


Add project to awesome-runners list

Hi @rakheshster,
I've spent a bit of time to help people find self-hosted GitHub Action solutions, I think its going to be huge and wanted to help people to discover them.
Your project stood out by showing how to use ARM templates to provision GitHub runners, so I added it to the list https://github.com/jonico/awesome-runners 🏃
I have also added a badge (if you are interested):

Keep up the great work 👍

Wow, thanks for that! Glad to see it listed there. :)


Add Create Product

Added functionality for Create Product (POST admin/products.json).

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           8      8
  Lines         242    248    +6
=====================================
+ Hits          242    248    +6

Impacted Files
Coverage Δ

product.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4e778...6592c71. Read the comment docs.


Is it possible to change only specific widgets ?

Hy,
I would like to propose an enhancement theme based on my observations, instead Change Everything,
Change only specific widgets like  Treeview or Scrollbar ! like this
from sv_ttk import SVTreeview

or
from sv_ttk import SVTreeview, SVScrollbar

Thus, it will not be affected the app When using other packages like Customthinker as an example.
By introducing this enhancement  into the theme, users would gain the freedom to arrange and style the app in a manner that best aligns with their unique needs and visual preferences. This level of customization would greatly enhance the overall user experience and provide a more tailored solution for a wider range of projects.
Considering the potential impact and demand for such customization capabilities, I believe that this enhancement would not only benefit me but also a significant number of other users within the python community.
By The Way, Thanks @rdbende for this theme

Hi Youssef!
It's not currently possible to apply the theme to specific widgets only. The theme is defined in a separate namespace and is evaluated in one piece. So importing the styles individually won't work, because all the other styles will be evaluated as well.
It would be possible to split it into individual styles, but that would be tedious, introduce bugs, and generally I don't think it's a good idea.
A theme is a theme after all. It gives a consistent style to all the widgets and makes them feel like they belong together.
I don't see any reason why you would want to mix two different widget styles. Things like "Oh, I kind of like this progressbar from ttkbootstrap, but I also want the scrollbar style from the Sun Valley theme" don't make sense to me. I understand that there are "unique needs and visual preferences", but that's not how UI works. Consistency is always a key to a good user experience._
People usually use this theme because they want their application to have a Windows 11 style, but mixing it with something else makes that imitation pointless. It will just look messy.
However, I understand that a lot of tkinter users don't care about good UX, only modern UI (no offense), so this feature might come in handy for them :D
I have a pretty bad opinion on Customtkinter, but I won't go into that here. sv_ttk is superior to Customtkinter in almost every way, so I don't think you should mix them.
However, if you really want to, I believe you already can. Since Customtkinter implements a whole new widget set that works entirely differently, they won't pick up the sv_ttk styling, so you can safely put in some tkinter.ttk widgets, and only those will get the Sun Valley theme.
I could also be missing some points. There may be other reasons why this feature would still be useful.

Yeah, I Strongly agree with u
the main goal is to provide the best possible user experience
and yeah :D,
I appreciate your insights also and if any further points for this, please let me know. Thanks dude

@rdbende May I ask why you do not like Customtkinter?

First of all, I have to say that I really like the idea, but the implementation is bad IMO.
So let's start with what I like about Customtkinter:

It is customizable (hence the name lol :D).
It has a great number of extension widgets that fit the style well.

But then here are my reasons why I don't like it:

It's a completely new toolkit.
If you already have a tkinter/ttk application, you can't just apply a "Customtkinter theme" to it like you would do with ttk themes. It's a whole new set of widgets, and you have to migrate your app to it if you want to use it.
Not compatible with regular tkinter
This wouldn't be a problem because ttk isn't compatible either. But as far as I can see, it kinda aims to be. Usually the widgets have the same methods/attributes, but sometimes they are buggy or don't work as intended, so it still feels a bit immature.
A canvas for each widget?
I don't think this is really memory efficient, and it also makes the toolkit incredibly slow. Tkinter is really slow in itself, but with Customtkinter it's unbearable.
There is no antialiasing for the canvas in tkinter (except on macOS).
This makes it look very bad (pixelated) on Windows and Linux.
Also the styling is kinda lame or eh?
I just don't like the style. It looks clumsy and unprofessional.

Then what would I like to use instead?
Something like ttkbootstrap, but with more customization options. So a dynamically created ttk theme that is as customizable as Customtkinter, however such a theme would solve all my problems mentioned above (not a separate toolkit, you still use the same ttk widgets, no canvas-bloat and antialiasing).

First of all, I have to say that I really like the idea, but the implementation is bad IMO.
So let's start with what I like about Customtkinter:

It is customizable (hence the name lol :D).
It has a great number of extension widgets that fit the style well.

But then here are my reasons why I don't like it:

It's a completely new toolkit.
If you already have a tkinter/ttk application, you can't just apply a "Customtkinter theme" to it like you would do with ttk themes. It's a whole new set of widgets, and you have to migrate your app to it if you want to use it.
Not compatible with regular tkinter
This wouldn't be a problem because ttk isn't compatible either. But as far as I can see, it kinda aims to be. Usually the widgets have the same methods/attributes, but sometimes they are buggy or don't work as intended, so it still feels a bit immature.
A canvas for each widget?
I don't think this is really memory efficient, and it also makes the toolkit incredibly slow. Tkinter is really slow in itself, but with Customtkinter it's unbearable.
There is no antialiasing for the canvas in tkinter (except on macOS).
This makes it look very bad (pixelated) on Windows and Linux.
Also the styling is kinda lame or eh?
I just don't like the style. It looks clumsy and unprofessional.

Then what would I like to use instead?
Something like ttkbootstrap, but with more customization options. So a dynamically created ttk theme that is as customizable as Customtkinter, however such a theme would solve all my problems mentioned above (not a separate toolkit, you still use the same ttk widgets, no canvas-bloat and antialiasing).

Interesting


[MoveOnlyAddressChecker] Complete block args.

Now that the underlying issue (PrunedLiveness' merging of summaries for branch instructions) has been fixed, reinstate lifetime completion and add a test to verify that it behaves correctly.
This reverts commit c552b90b61fda8da0a2090df4b09b58feb478814 ("Temporarily turn off completing lifetimes of block arguments").
rdar://130427564

@swift-ci please test

@swift-ci please apple silicon benchmark

@swift-ci please test source compatibility

@swift-ci please test windows platform

@swift-ci please test linux platform

@swift-ci please test macos platform


Get a service account for GitHub

We need a "team" IDIR that we can use to create a GitHub service account so that the GitHub token used for security to call the Github actions is not connected to a personal account.

Var is returning on Monday July 19. Until then it's hard to get email stuff.

Var has asked that we get our new PO to do this when he or she starts on the team.

done


Update concept-condition-filters-for-devices.md

@SanDeo-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @SanDeo-MSFT - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this pull request open for author review and then merge, but would you make future content updates in the private repo? Thanks!

#sign-off

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Club House map images (new) are available from Ubi

Just checked at https://rainbow6.ubisoft.com/siege/en-us/game-info/maps/clubhouse.aspx and the 2nd floor blueprints include the new "construction" section between cash and bedroom. I believe these are the files you need to update Club.
Cheers.

Awesome, thank you so much! I'll get this added as soon as I can, hopefully by the end of Sunday.

Thanks for your work on this project! I've been looking for this forever

Update: New Club is now on the fork's github pages


Input Fields not selectable in dnd container in IE11, even when disabled

In IE 11, we experience problems with input fields (input tag, textareas, wysiwyg editors etc.) when it's part of a drag and drop area. As an example, see http://marceljuenemann.github.io/angular-drag-and-drop-lists/demo/#/types and try to highlight the input fields, e.g. "Charlie". Won't work in IE, works very well in other browsers.

I have the same problem. not working in firefox.

This appears to be because of changes in browser handling of the draggable="true" tag. This could really use an update, I'm facing the same issue.

Same here

I posted something that may help with this issue here


Add basic documentation for multi node training

What does this PR do?
Adds some basic documentation for multi-node training with 🤗 Accelerate. I've also added a small comment on running code on CPU, which I think is helpful but is not talked about in the tutorials.
cc @muellerzr

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@muellerzr suggestions merged! I also added a link to the new blog post on multi-node training with FSDP.

Thanks for the PR! 🤗


Use locales in components/settings/sub_pages/audio.rs

The values high/low/etc are hardcoded instead of using locales

https://github.com/Satellite-im/Uplink/blob/dev/ui/src/components/settings/sub_pages/audio.rs

I believe the audio setting page is just a placeholder for @sdwoodbury for now.

We'll fix this when we hook these buttons up to something. Putting on the backlog for now.


Train dataset with MONAI & compare segmentations with IVADOMED

Project MONAI: https://github.com/Project-MONAI
As the future direction of the IVADOMED software is uncertain, it would be helpful to train a dataset on the similar open-source project MONAI to see if the necessary features are there (or which may be missing) and compare the segmentations using that model with the current ones used by ADS through IVADOMED. I would be a good idea to do this with our SEM dataset, which is small but has been used throughout the ADS project.

Closing - no longer using IVADOMED, and we've moved to a different dataset training method


Can we run pg_collector that supports for version 14 in postgres 15 or 16 DB

Technically yes but you may see some errors as sometimes newer version remove or rename some columns , you can edit the script and fix the issue and rerun the the script .
also FYI , I am working on adding pg_collector  for 15 and 16 and it should be released within a week . for future releases  like postgres 17  i will do my best to release it in the same week .

https://github.com/awslabs/pg-collector/tree/pg-collector-for-postgresql-16
https://github.com/awslabs/pg-collector/tree/pg-collector-for-postgresql-15


Heroku addons configuration

I just added the ability to configure heroku's addons.
The configuration is pretty minimal: it helps for the initial set up of an app.

See also #69


How to enable MetricBeat when starting 'alwayson queue' ?

Dear, SOCA Engineer.
I have configured an environment where customers can use optical simulation on SOCA.
I used Alwayson Queue as a usage environment, and analysis work is normally executed.
I ran Always on with the script below, but the "MetricBeat" setting option was not found.
"/apps/soca/$SOCA_CONFIGURATION/cluster_manager/add_nodes.py "

#python3 /apps/soca/$SOCA_CONFIGURATION/cluster_manager/add_nodes.py   --desired_capacity { }  --instance_type { }  --job_name always_on_capacity --instance_ami { }  --job_owner hpcadmin --root_size 10 --spot_price auto --queue alwayson  --keep_forever true
#pbsnodes -a
resources_available.arch = linux
resources_available.asg_spotfleet_id = sfr-fd4be2c0-86bd-4462-9b68-aac34ad31272
resources_available.availability_zone = ap-northeast-2b
resources_available.compute_node = job2e0a6c5f-a75a-4c15-a36d-263b9f4eb230
resources_available.host = ip-172-20-2-173
resources_available.instance_id = i-0c7ad8e920cb89709
resources_available.instance_type = c5.24xlarge
resources_available.mem = 193526880kb
resources_available.ncpus = 48
resources_available.subnet_id = subnet-01c6b2a71bfa812cb
resources_available.vnode = ip-172-20-2-173
resources_assigned.accelerator_memory = 0kb
resources_assigned.hbmem = 0kb
resources_assigned.mem = 0kb
resources_assigned.naccelerators = 0
resources_assigned.ncpus = 0
resources_assigned.vmem = 0kb
And I configed that "PBS -l system_metrics = true" in the script and then I checked that metrics is true when qstat -xf option.
[hpcadmin@ip-172-20-2-14 cluster_manager]$ qstat -xf 1089
Job Id: 1089.ip-172-20-2-14
Job_Name = testa4_Queue_test
Job_Owner =<EMAIL_ADDRESS>resources_used.cpupercent = 3901
resources_used.cput = 06:26:17
resources_used.mem = 15402808kb
resources_used.ncpus = 192
resources_used.vmem = 22877768kb
resources_used.walltime = 00:08:22
job_state = F
queue = alwayson
server = ip-172-20-2-14
Checkpoint = u
ctime = Fri Aug 27 08:46:01 2021
Error_Path = ip-172-20-2-14.ap-northeast-2.compute.internal:/data/home/test
admin/myjob/testadmin_testd/Logs/error_run_testa4_Queue_test.err
exec_host = ip-172-20-2-139/048+ip-172-20-2-152/048+ip-172-20-2-175/048+
ip-172-20-2-173/048
exec_vnode = (ip-172-20-2-139:ncpus=48)+(ip-172-20-2-152:ncpus=48)+(ip-172-
20-2-175:ncpus=48)+(ip-172-20-2-173:ncpus=48)
Hold_Types = n
Join_Path = n
Keep_Files = n
Mail_Points = a
mtime = Fri Aug 27 09:00:08 2021
Output_Path = ip-172-20-2-14.ap-northeast-2.compute.internal:/data/home/tes
tadmin/myjob/testadmin_testd/Logs/output_run_testa4_Queue_test.out
Priority = 0
qtime = Fri Aug 27 08:46:01 2021
Rerunable = True
Resource_List.mpiprocs = 4
Resource_List.ncpus = 192
Resource_List.nodect = 4
Resource_List.place = free
Resource_List.select = 4:ncpus=48:mpiprocs=1
Resource_List.system_metrics = True
Resource_List.walltime = 24:00:00
stime = Fri Aug 27 08:51:46 2021
session_id = 8393
jobdir = /data/home/testadmin
substate = 92
Is there a way to enable metrics when creating an Alwayson Queue?
Can you please check if the method I used the PBS -l option is correct?
Best Regards,
JungIn

Hello @sysdori  -
MetricBeat support for AlwaysOn is not something we are supporting today, however you can edit add_nodes.py and add support for it.
To do that, add a new parser.add_argument()  named system_metrics directly after the list of existing arguments (https://github.com/awslabs/scale-out-computing-on-aws/blob/main/source/soca/cluster_manager/add_nodes.py#L842)
parser.add_argument('--system_metrics', default=True, help='Add/Remove support for MetricBeat')

Then submit a new capacity via add_nodes.py and specify --system_metrics parameter:
python3 /apps/soca/$SOCA_CONFIGURATION/cluster_manager/add_nodes.py --desired_capacity { } \
 --instance_type { } --job_name always_on_capacity --instance_ami { } \
 --job_owner hpcadmin --root_size 10 --spot_price auto --queue alwayson --keep_forever true \
 --system_metrics true # <--- Add this

Alternatively, if you want to force MetricBeat for all compute nodes, you can edit the if statement https://github.com/awslabs/scale-out-computing-on-aws/blob/main/source/soca/cluster_node_bootstrap/ComputeNodeConfigureMetrics.sh#L15 and force this loop to be executed for all jobs if "true" == "true"; then ...

Dear, mcrozes.
Thank you for your support.
I applied the script in the first way, and I think I will be able to test it tomorrow.
Thanks,
Sysdori.

Dear, mcrozes.
I modified the source code by referring to your guide and confirmed that system_metrics are automatically applied in the Always on compute node.
Thanks,
sysdori


Threads and posts voting feature

This PR adds a new ForumVote model that thought a polymorphic association provide ForumThread and ForumPost  voting capabilities, allowing users to upvote forum threads and forum posts unobtrusively (via AJAX )
Forum Threads:

Forum Posts ( I moved the edit pencil button to make space for the added voting button):

Since this is pretty old, I'm going to close this.


Consider sub-domains in hosts wildcards

When I inserted *.subdomain.example.com in the hosts file, every sub-domains under example.com have been converted to IP in hosts.
I patched this problem

Nice work, Thanks.


Error when creating visualizations without specifying options

At the moment if you don't specify at least an empty options object it will error when looking for the title.
We should gracefully handle this.

Fixed by #59


Gem release

pre3 has been released, the bugs are out so this should work feautifully :)

Looks legit. Ready for a merge?

Sure just made a PR as I'm accustomed to this and hoped you'd see it and give it a look. Worked out just fine :star:


Add communication channel to experienceEvent, Add new Metrics.

This PR involves changes to the core schema relating to issue #206
This supplements the PR #209 .

Looks good to me. @saurabhere I'm filing another issue for you: the newly introduced metrics should get a proper schema:
+        },
 +        "https://ns.adobe.com/xdm/data/metrics/direct-marketing/opens": {
 +          "$ref": "https://ns.adobe.com/xdm/data/measure"
 +        },
 +        "https://ns.adobe.com/xdm/data/metrics/direct-marketing/unsubscriptions": {
 +          "$ref": "https://ns.adobe.com/xdm/data/measure"
 +        },
 +        "https://ns.adobe.com/xdm/data/metrics/direct-marketing/not-sent": {
 +          "$ref": "https://ns.adobe.com/xdm/data/measure"
          }		          }


Replace Async::IO::Socket usage with stdlib Socket…

…for async-http adapter to remove implicit dependency on async-io
async-io was removed as a dependency from async-http in version 0.65.0: https://github.com/socketry/async-http/releases/tag/v0.65.0
fixes: https://github.com/bblimke/webmock/issues/1055

@bblimke, could you take a look at this when you get a chance?

@jakeonfire Thank you for the PR and the fix. Is it worth having conditional logic to keep compatibility with version < 0.65?

these changes are backwards-compatible

should i revert the version number change? otherwise you can overwrite it after merging.

these changes are backwards-compatible

The Ruby 3.0 build, which uses async-http 0.64.2 is failing.

@bblimke looks good now 👍

Much simpler indeed. Thank you @jakeonfire 👍

It's now released as version 3.23.1


Theme colors incorrect for md-slide-toggle

Bug, feature request, or proposal:
Bug
What is the expected behavior?
md-slide-toggle obeys the Material Design spec

What is the current behavior?
md-slide-toggle uses background color for .md-slide-toggle-thumb, and possibly incorrect in other areas as well. This is especially noticeable in dark theme, where thumb is very hard to see.

What are the steps to reproduce?
Look at md-slide-toggle in both light/dark themes
What is the use-case or motivation for changing an existing behavior?
Bug
Which versions of Angular, Material, OS, browsers are affected?
"@angular/material": "^2.0.0-alpha.9-3",
Is there anything else we should know?
No

Great, thanks!