Add labels field to AbstractProposal and present in the talk list page

(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)
Types of changes
Please put an x in the box that applies

[ ] Bugfix
[x] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Other (please describe)

Description
Describe what the change is
Add a generic labels field to AbstractProposal, and present the "Community Label" in the Talk List page.
Steps to Test This Pull Request
Steps to reproduce the behavior:

Go to Django Admin and edit any accepted TalkProposal
In the labels field, put in Community Track
Go to the Talk List page, and see the result
Click on the Community Track label

Expected behavior
There should be a Community Track or 社群軌 label next to the title of the Talk. After clicking the label, it will jump to the bottom, and you should see a short description of the Community Track.
Additional context
This is a generic field, but maybe not ideal. I was thinking that maybe in the future, the field could hold multiple labels, achieved by making them a comma separated string.
But currently, the label "Community Track" is hard coded in the Talk List page, and also in the translation.

Codecov Report

Merging #812 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #812   +/-   ##
=======================================
  Coverage   76.13%   76.14%
=======================================
  Files          70       70
  Lines        2686     2687    +1
=======================================
+ Hits         2045     2046    +1
  Misses        641      641

Impacted Files
Coverage Δ

src/proposals/admin.py
100.00% <ø> (ø)

src/proposals/models.py
88.09% <100.00%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0cb58d...e63a9b3. Read the comment docs.


Babel dependency issue

Getting this issue when installing with yarn:
Cannot find module 'babel-runtime/core-js/promise'
Error: Cannot find module 'babel-runtime/core-js/promise'
    at Module._resolveFilename (internal/modules/cjs/loader.js:584:15)
    at Function.Module._resolveFilename (/Users/danni/src/SPT/spt-bridge/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/common/reset-search-paths.js:43:12)
    at Function.Module._load (internal/modules/cjs/loader.js:510:25)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/Users/danni/src/SPT/spt-bridge/node_modules/redux-saga-tester/dist/SagaTester.js:8:16)
    at Object.<anonymous> (/Users/danni/src/SPT/spt-bridge/node_modules/redux-saga-tester/dist/SagaTester.js:326:3

I'm using Babel 7. Adding babel-runtime 6 does seem to solve the issue.

@danni - can't reproduce. Try installing in a new, clean directory, as it might be something with your project configuration.

Hi, I'm installing into a pretty new project that just contains the Babel 7 bootstrap, React, Redux, Saga, etc. Did you install with yarn or npm? I'm guessing the problem is that dev dependencies of the dev dependencies aren't getting installed.

I installed with yarn: yarn add redux-saga-tester. Everything worked fine.

I did yarn add --dev redux-saga-tester. I'm pretty sure it has nothing to do with my project configuration, and is to do with the dependency not being pulled in. Manually installing babel-runtime 6 resolves it.

@danni - added babel-runtime as a dependency. Should resolve this issue.

Confirmed!


Update authentication-tutorial.md

https://dev.azure.com/powerbi/Trident/_workitems/edit/1419678 [p1] MSLearn authentication setup missing automatic
Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.
https://dev.azure.com/powerbi/Trident/_workitems/edit/1419678
[p1] MSLearn authentication setup missing automatic
Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.
@KesemSharabi
@paulinbar
For internal Microsoft contributors, check off these quality control items as you go

[ ] 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

[ ] 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

[ ] 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

[ ] 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

[ ] 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

@paulinbar
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@muliwin - can you please resolve the errors? You need to use relative links instead of absolute links. For more info see https://review.learn.microsoft.com/en-us/help/platform/links-how-to?branch=main.

@muliwin - can you please resolve the errors? You need to use relative links instead of absolute links. For more info see https://review.learn.microsoft.com/en-us/help/platform/links-how-to?branch=main.

@KesemSharabi what errors? I only see warnings?

@muliwin - we treat warnings and errors the same - please fix.

@muliwin - we treat warnings and errors the same - please fix.

th
these ones?

@KesemSharabi @paulinbar
updated without warning, please sign-off

#sign-off

#sign-off


Duplication glitch with villager heads

Unless the villager head is placed on the side of a block, breaking it will drop 2 heads. Tried it with a few different other mob heads, could not reproduce.
Demonstration: https://www.youtube.com/watch?v=K2yhLe5VhC0

Related to #48, fixed in v1.10.1-beta 🙂


Aws#241 Added support for Port Annotation in ServiceExport Object

What type of PR is this? Feature

Which issue does this PR fix: AWS#241
What does this PR do / Why do we need it: This PR enables users to define which port/container to be exported vi ServiceExport object.
If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
Testing done on this change: Yes
make presubmit output:
?       github.com/aws/aws-application-networking-k8s/pkg/aws   [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/deploy        [no test files]
ok      github.com/aws/aws-application-networking-k8s/pkg/aws/services  0.017s  coverage: 2.9% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/config        0.011s  coverage: 77.4% of statements
?       github.com/aws/aws-application-networking-k8s/pkg/k8s   [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/model/lattice [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/runtime       [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/utils [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/utils/retry   [no test files]
?       github.com/aws/aws-application-networking-k8s/pkg/utils/ttime   [no test files]
ok      github.com/aws/aws-application-networking-k8s/pkg/deploy/lattice        0.042s  coverage: 86.1% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/gateway       0.054s  coverage: 77.8% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/latticestore  0.004s  coverage: 73.3% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/model/core    0.004s  coverage: 40.9% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/model/core/graph      0.003s  coverage: 17.2% of statements
ok      github.com/aws/aws-application-networking-k8s/pkg/utils/log     0.002s  coverage: 0.0% of statements [no tests to run]

Automation added to e2e: No

Will this PR introduce any new dependencies?: No

Will this break upgrades or downgrades. Has updating a running cluster been tested?: Yes
Does this PR introduce any user-facing change?: Yes.

Users will be able to define which ports/containers to expose through ServiceExport by adding an annotation to ServiceExport objects.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 20 (90.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 32.692%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/gateway/model_build_targets.go
18
20
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
3382

Relevant Lines:
10345

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 20 (90.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 32.692%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/gateway/model_build_targets.go
18
20
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
3382

Relevant Lines:
10345

💛  - Coveralls

Seems after you change, for example for this connectivity set up:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: inventory
spec:
  parentRefs:
  - name: my-hotel
    sectionName: http
  rules:
  - backendRefs:
    - name: inventory-ver1
      kind: Service
      port: 8090
    matches:
    - path:
        type: PathPrefix
        value: /ver1
  - backendRefs:
    - name: inventory-ver2
      kind: ServiceImport
      port: 9090
    matches:
    - path:
        type: PathPrefix
        value: /ver2

The behaviour would be:
for inventory-ver1, if will regardless of HTTPRoute backendRefs‘s inventory-ver1 's port  as before. And use inventory-ver1  k8sService's (all) port(s) blindly
for inventory-ver2, if will regardless of HTTPRoute backendRefs‘s inventory-ver2 's port as before And use the intersection ports for inventory-ver2's k8sservice's (all) port(s)  and inventory-ver2's serviceExport's annotation (currently support on port only).
That a good workaround to narrow down vpcLattice target's ports to be created for serviceExport. But for the long tern should we regard to use HTTPRoute backendRefs‘ ports to create lattice targets? (whatever backendRef kind service or backendRef kind ServiceImport)

This PR fixes #267

Seems after your change, for example for this connectivity set up:
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: inventory
spec:
  parentRefs:
  - name: my-hotel
    sectionName: http
  rules:
  - backendRefs:
    - name: inventory-ver1
      kind: Service
      port: 8090
    matches:
    - path:
        type: PathPrefix
        value: /ver1
  - backendRefs:
    - name: inventory-ver2
      kind: ServiceImport
      port: 9090
    matches:
    - path:
        type: PathPrefix
        value: /ver2

The behaviour would be: for inventory-ver1, if will regardless of HTTPRoute backendRefs‘s inventory-ver1 's port (as before). And use inventory-ver1 k8sService's (all) port(s) blindly (as before)
for inventory-ver2, if will regardless of HTTPRoute backendRefs‘s inventory-ver2 's port (as before). And use the intersection ports for inventory-ver2's k8sservice's (all) port(s) and inventory-ver2's serviceExport's annotation (currently support one port only).
That a good workaround to narrow down vpcLattice target's ports to be created for serviceExport. But for the long tern should we regard to use HTTPRoute backendRefs‘ ports to create lattice targets? (whatever backendRef kind service or backendRef kind ServiceImport)

IMO, for long team, we should push this port specification into ServiceExport object definition.

This PR fixes #267 . Fixes still needed for #241

Are you sure? Looks more like #241 as I read the bug.


When using version 1.14, an error occurs when calling the getBlock method

org.p2p.solanaj.rpc.RpcException: Transaction version (0) is not supported by the requesting client. Please try the request again with the following configuration parameter: "maxSupportedTransactionVersion": 0
at org.p2p.solanaj.rpc.RpcClient.call(RpcClient.java:88)
at org.p2p.solanaj.rpc.RpcApi.getBlock(RpcApi.java:522)

Fixed here: https://github.com/skynetcap/solanaj/commit/d97fe203e564026d9ddae42a9c209dc9e35a4d74
Will be built into a release shortly.

#34


swift demo...

Thanks for the port.
Any way to get a swift demo?
Thanks again!

There's no point in a Swift demo, as if you are writing in Swift you know Swift and can initialize a class instance.... And the API is the same in ObjC and Swift.
The ObjC demonstrates the charts as well as how to mix Swift and ObjC - that's why it's in ObjC


Fix for Reference Asset By Asset ID on Publisher

This PR is to resolve the issue #287 . Handled the use-case of "Enabling Asset referenced by Asset ID".
/cc : @kaushalmall

Hi @vinaykhurana  can you use the AssetResolver and avoid duplicating that logic?
I think we just have to  update that to
@Reference
AssetResolver assetResolver;
...
return  assetResolver.resolveAsset(request) == null;

https://github.com/Adobe-Marketing-Cloud/asset-share-commons/blob/develop/core/src/main/java/com/adobe/aem/commons/assetshare/content/impl/AssetResolverImpl.java#L42

@kaushalmall  - yup ... and including @vinaykhurana's concern around the exception (which i forgot about)...
if (WCMMode.DISABLED.equals(wcmMode)) {
	try {
		return assetResolver.resolveAsset( request ) == null;
	}  catch(IllegalArguementException e) {
		return true;
	}
}

return false;

Of course its better to not use exceptions as code-flow-control, but in this case the alternative is much less elegant, and it's already in a conceptual "erroring" context.

@kaushalmall My concern was on the exception which AssetResolver.resolveAsset(.) throws if it is not able to resolve suffix path or ID to an asset. I think instead of throwing the IllegalArgumentException in AssetResolver, it should let the caller decide what to do if not able to resolve to an asset. Nevermind, i have updated the code as recommended by @davidjgonzalez . Please review.

@vinaykhurana FWIW generally i agree with you, but since is a published public API, it's hard to change though without accidently affecting others! :T

Thanks @vinaykhurana !


Bump conditional auth functions version to 1.2.25

Purpose
$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5108483115

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5108483115
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5108483115

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5108483115
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5110498756

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5110498756
Status: success


feat(binding-behaviors): add throttle, debounce, oneTime, oneWay and …

…twoWay behaviors

@jdanyow Can you also create a signal binding behavior?

sure

Signal Binding Behavior
@EisenbergEffect I was researching what the signal behavior needed to do based on what we've mentioned in various github issues:
Use Cases

translation:  ability to signal binding to update the target due to the culture/locale changing (https://github.com/aurelia/i18n/issues/6#issuecomment-137452771 and https://github.com/aurelia/framework/issues/144#issuecomment-115430168)

"fuzzy time" eg a binding that results in jdanyow commented an hour ago.  Need the ability to periodically signal the binding to refresh (https://github.com/aurelia/templating-binding/issues/25#issuecomment-87060863).

general purpose "my source expression isn't fully observable but isn't dirty-checked either" (https://github.com/aurelia/framework/issues/32)

Requirements/Scope

The signal binding behavior should give developers the ability to "signal" a binding or collection of bindings by "name".
Signaling a binding should update the target (the view) with the source's (view-model's) current value.
the signal binding behavior is only applicable to Bindings and InterpolationBindings.  It is not applicable to Call/Listener/Name type bindings, for these cases an error will be thrown.
the signal binding behavior is not applicable to one-time bindings.  Currently there is no reason to not support one-time bindings but I'm afraid supporting one-time bindings will prevent us from further optimizing one-time binding scenarios.

I'm implementing this behavior as-described above- let me know if any of this needs to be changed.

https://github.com/aurelia/templating-binding/issues/25

This sounds great!
On Oct 24, 2015 9:54 AM, "Jeremy Danyow"<EMAIL_ADDRESS>wrote:

Signal Binding Behavior
@EisenbergEffect https://github.com/EisenbergEffect I was researching
what the signal behavior needed to do based on what we've mentioned in
various github issues:
Use Cases

translation: ability to signal binding to update the target due to the
culture/locale changing (aurelia/i18n#6 (comment)
https://github.com/aurelia/i18n/issues/6#issuecomment-137452771 and aurelia/framework#144
(comment)
https://github.com/aurelia/framework/issues/144#issuecomment-115430168
)
2.
"fuzzy time" eg a binding that results in jdanyow commented an hour ago.
Need the ability to periodically signal the binding to refresh (aurelia/templating-binding#25
(comment)
https://github.com/aurelia/templating-binding/issues/25#issuecomment-87060863
).
3.
general purpose "my source expression isn't fully observable but isn't
dirty-checked either" (aurelia/framework#32
https://github.com/aurelia/framework/issues/32)
Requirements/Scope

The signal binding behavior should give developers the ability to
"signal" a binding or collection of bindings by "name".
Signaling a binding should update the target (the view) with the
source's (view-model's) current value.
the signal binding behavior is only applicable to Bindings and
InterpolationBindings. It is not applicable to Call/Listener/Name type
bindings, for these cases an error will be thrown.
the signal binding behavior is not applicable to one-time bindings.
Currently there is no reason to not support one-time bindings but I'm
afraid supporting one-time bindings will prevent us from further optimizing
one-time binding scenarios.

I'm implementing this behavior as-described above- let me know if any of
this needs to be changed.
aurelia/templating-binding#25
https://github.com/aurelia/templating-binding/issues/25
—
Reply to this email directly or view it on GitHub
https://github.com/aurelia/templating-resources/pull/126#issuecomment-150813462
.

Binding behavior info:  http://stackoverflow.com/a/33490150/725866


Added possibility to set max length for level name in LineFormatter

Fixes https://github.com/Seldaek/monolog/issues/1785

Thanks, I did tweak the implementation a bit to use a setter instead of constructor as the constructor is already quite loaded and this is not really a major use case.


Why we don't support refresh tokens for the renewal of the digital credentials

The User authentication and consent is required for the issuance of a credential:

In OAuth 2.0 the refresh token is used without any user control
To request a new credential with loa high, eg: the PID, requires the user to be authenticated to the PID/EAA Provider
To store a PID/EAA to the secure storage, the user must be authenticated and give the consent

Security concerns: A stolen refresh token together with a brand new WIA and a PID/EAA "presentation" would be enough to steal a brand new PID

if the design is where access token is sender constrained and the DPoP key is cloud HSM protected, if the user sets up a PIN that needs to be typed to generate DPoP proof, that addresses 1, and if access token is sender constrained, that would mitigate 2. (but honestly if DPoP proof is cloud HSM protected and Wallet backend key for WIA as well and the attacker can steal both, that is a bigger problem and seems to be a no-go...)


Revert "Event hub output"

Reverts microsoft/AzureFunctionforSplunkVS#21

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Mr-iX sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


datasets and readme

Can you provide datasets or data preprocessing? and send them to github ? Or send a detailed  readme.txt to github. thank you!

Hi
Sorry for the late reply. Which dataset do you need ?
Are you able to access google drive ? Then I can upload it to there.
Please Let me know
Devraj


How to add latest font awesome icons?

Today I tried to use the recently released ResearchGate icon, but the link provided at the bottom didn't work:
https://fontawesome.com/icons/researchgate?style=brands
I copied <i class="fab fa-researchgate"></i> in place of my currently existing icon in minimal mistakes. Any guidance is appreciated.

The version of FA linked in the theme is a few versions back. You'll have to wait until #1620 is merged in or apply the patch manually to your site.

Thank you @mmistakes, I will close the issue, the patch should be easy to apply. I will wait for the PR to be merged.


High overhead of power measurements for CPU inference measurements

During the MLPerf Inference v1.0 round, I noticed that the power workflow when used with CPU inference occasionally seemed to incur a rather high overhead (~10%), for example:

Xavier with power measurements:

ArmNN v21.02: 68.5 ms
TFLite v2.4.1: 78.0 ms

Xavier without power measurements (compliance):

ArmNN v21.02: 60.2 ms
TFLite v2.4.1: 78.5 ms

Here, ArmNN is faster than TFLite but takes a big hit under the power workflow. TFLite, however, is not affected.

Raspberry Pi 4 with power measurements:

TFLite v2.4.1: 606.3 ms

Raspberry Pi 4 without power measurements (compliance):

TFLite v2.4.1: 552.3 ms

Hi Anton -  On Jetson AGX, we can check our runs with and without power to see if we see an impact of the power related SW overheads in communicating to the director PC.  I will comment back on this issue.

@s-idgunji When running inference on the GPU, the CPU is typically not fully utilised, so you might not notice any difference. When running inference on the CPU in full-blast, the effect may be more pronounced.

@psyhtest   - Thanks,  we were not able to notice a difference when we had workload going on GPU on the Xavier config that we submitted, but I agree that when you are using CPU only, then the effect may show up.  We can independently try and replicate the behavior you observed.  But we'll need to close on this soon and propose a fix that can go in so that we can validate prior the freeze date.

Anton - RP4 is pretty low-end CPU. I don't see any way around some sort of overhead. Is the overhead consistent or are you saying it's unpredictable?

The overhead seems to be consistent. What's worrying is that it shows up with ArmNN on Xavier which is like 8x more powerful than RPi4.

Anton - Can you try on another system , perhaps Intel Celeron or Core based.  Also , what can we suggest as a fix ?  If we want to repro on our system at NVIDIA what specific config , benchmark/scenario would likely give the highest difference.  We could test it out to see if it repros.

Power WG Thoights:
For v1.1: Try and solve it opportunistically. It is not a gating items.
For further revisions: We could take a look into it.
This is mainly due to the resources available to solve this problem. Main issue is there is no minimum bar for the software flow.

MLPerf Power WG: This will be punted to after v1.1. issue will remain open.

@psyhtest  - perhaps you want to close this if the issue is not valid anymore, or we need to revisit in the WG. Quite an old issue.

Is this issue still happening?


Updated to work with simulator update

Everything is working again except for parts from LocoProviders:

Tractive effort
Adhesion
Power
Boiler pressure

made a quick and dirty build of this PR for anyone else who finds their way here looking for an update (thanks @SyBozzDEV for making this patch! ❤). havent done extensive testing but it seems to work ingame?
dv-hud.zip

I don't know if this is specific to this PR, or if it was an issue with the original, but upon entering a handcar, and until entering a different loco, the mod throws constant NullReferenceExceptions to the console. Player.log shows multiple of the following:
NullReferenceException: Object reference not set to an instance of an object
  at DvMod.HeadsUpDisplay.EventList.DrawUpcomingEvents () [0x00089] in <893813731fba4e3cbbda2ae9a22f3d24>:0
  at DvMod.HeadsUpDisplay.Overlay.DrawDrivingInfoWindow (System.Int32 windowID) [0x00044] in <893813731fba4e3cbbda2ae9a22f3d24>:0
  at UnityEngine.GUILayout+LayoutedWindow.DoWindow (System.Int32 windowID) [0x00070] in <e114731188434396a16e5be1fee43be9>:0
  at UnityEngine.GUI.CallWindowDelegate (UnityEngine.GUI+WindowFunction func, System.Int32 id, System.Int32 instanceID, UnityEngine.GUISkin _skin, System.Int32 forceRect, System.Single width, System.Single height, UnityEngine.GUIStyle style) [0x00078] in <e114731188434396a16e5be1fee43be9>:0

and
NullReferenceException: Object reference not set to an instance of an object
  at DvMod.HeadsUpDisplay.CarList.GetCarColor (TrainCar car) [0x00135] in <893813731fba4e3cbbda2ae9a22f3d24>:0
  at DvMod.HeadsUpDisplay.CarList.DrawCarList (Trainset trainset) [0x001c2] in <893813731fba4e3cbbda2ae9a22f3d24>:0
  at DvMod.HeadsUpDisplay.Overlay.DrawTrainInfo () [0x00149] in <893813731fba4e3cbbda2ae9a22f3d24>:0
  at DvMod.HeadsUpDisplay.Overlay.DrawDrivingInfoWindow (System.Int32 windowID) [0x00063] in <893813731fba4e3cbbda2ae9a22f3d24>:0
  at UnityEngine.GUILayout+LayoutedWindow.DoWindow (System.Int32 windowID) [0x00070] in <e114731188434396a16e5be1fee43be9>:0
  at UnityEngine.GUI.CallWindowDelegate (UnityEngine.GUI+WindowFunction func, System.Int32 id, System.Int32 instanceID, UnityEngine.GUISkin _skin, System.Int32 forceRect, System.Single width, System.Single height, UnityEngine.GUIStyle style) [0x00078] in <e114731188434396a16e5be1fee43be9>:0

There are also a few other errors that I assume are side effects:
GUI Error: You are pushing more GUIClips than you are popping. Make sure they are balanced.
and
ArgumentException: Getting control 275's position in a group with only 275 controls when doing repaint
where the index(275) varies
log attached.
Player-prev.log

this seems to be a broken pr in B99 not working as intended


Fixed #35682 -- Made Docstring updates in BaseDetailView and BaseList…

…View.
Trac ticket number

ticket-35682
Branch description
Majority of the BaseView's like BaseUpdateView, BaseCreateView and other's has specified in their docstring and their docs that
"Using this base class requires subclassing to provide a response mixin." but in BaseListView and BaseDetailView where it is needed to , it is not mentioned inside the docstring but it is mentioned in their docs. So i added the same statement "Using this base class requires subclassing to provide a response mixin." inside the docstring of both BaseListView and BaseDetailView.
Checklist

[x] This PR targets the main branch.
[x] The commit message is written in past tense, mentions the ticket number, and ends with a period.
[ ] I have checked the "Has patch" ticket flag in the Trac system.
[ ] I have added or updated relevant tests.
[ ] I have added or updated relevant docs, including release notes if applicable.
[ ] I have attached screenshots in both light and dark modes for any UI changes.

@felixxm hey there, i am a new contributor here and this is my first PR, i wanted to ask why the two test cases are failing here.

Hello @YashRaj1506!
You will find the details of the failures here:

Hello @YashRaj1506! You will find the details of the failures in your file changes

Thank you i got it now.

For completeness' sake, I suggest you go through the BaseViews in dates.py as well.
By the way, if a docstring already mentions that a BaseView is an abstract base class, it is reduntant to mention that it requires subclassing. In those cases I suggest: Requires a response mixin.

Yeah i missed dates.py, i will commit the changes, and on the second thing you mentioned, i am a bit confused where to add the requires a response mixin? A little more info on this will help.

You left out many other Base Views in dates.py that neglect to mention their subclassing requirements in docstrings.

oh my bad will go work over it, Will read the whole dates.py

The wording should probably be consistent across the three cases.

Just to clarify, You mean to say the three places i made changes at, should have the same "this class is meant to be subclassed" message? As i added the response Mixin message in the third dates.py base class?

You left out many other Base Views in dates.py that neglect to mention their subclassing requirements in docstrings.

For the docstrings which don't mention they are a abstract class like
"BaseMonthArchiveView", ""BaseDayArchiveView" and others, they just specify their functionalities of what it does. Should i add infront of it that "A abstract base class which does action-it-does. Requires a Response Mixin"? it will be enough ig.

For the docstrings which don't mention they are a abstract class like "BaseMonthArchiveView", ""BaseDayArchiveView" and others, they just specify their functionalities of what it does. Should i add infront of it that "A abstract base class which does action-it-does. Requires a Response Mixin"? it will be enough ig.

I think it's better if we use consistent wording for all Base Views with unclear docstrings. Like so:
class BaseMonthArchiveView(YearMixin, MonthMixin, BaseDateListView):
    """
    Base view for displaying a list of objects published in a given month.

    Requires a response mixin.
    """

Let me know what you think.

For the docstrings which don't mention they are a abstract class like "BaseMonthArchiveView", ""BaseDayArchiveView" and others, they just specify their functionalities of what it does. Should i add infront of it that "A abstract base class which does action-it-does. Requires a Response Mixin"? it will be enough ig.

I think it's better if we use consistent wording for all Base Views with unclear docstrings. Like so:
class BaseMonthArchiveView(YearMixin, MonthMixin, BaseDateListView):
    """
    Base view for displaying a list of objects published in a given month.

    Requires a response mixin.
    """

Let me know what you think.

The edit that i made on the docstring (yet to commit) looks like this only, I think this would be good enough to go with. I will make the following changes and will tag you if i find something better.

Hello!
Update the PR title to, say, Fixed #35682 -- Updated docstrings for BaseViews. And squash commits.

@cliff688 Made the changes, quashed the commits. If you want you can verify all the things once and then i think we are done with this.

@adamchainz  I have made the changes you suggested at all the places, Do you think this PR is ready now?


Add a "no dependency" runtime check to tox

I was scratching my head as to how some check didn't catch that "pytest" issue earlier this week. And then I realized, all of the relevant tox targets are unit tests, meaning they all have pytest installed as extras! So this adds a NEW target, which has nothing installed beyond what comes with nltk.
The test passes now but I reverted https://github.com/nltk/nltk/pull/2693 and the test failed

Thanks @dannysepler. I was wondering the same thing.


fix(dao) allow escaped commas in arrays

Support using \, for representing a , character in a comma-separated array, without using it as a separator. This allows one to use commas when entering URIs using the PCRE regex syntax {n,m} for n-to-m repetitions. For example:
$ curl localhost:8001/apis -d name=test -d upstream_url=http://httpbin.org -d uris='/foo/\d{1\,3},/bar'

Fixes #2780.

(Referencing both the fixed issue and the PR in the commit message is encouraged! Makes it easier to trace the PR when writing the Changelog :) )

Will do! Just waiting for Travis.


How to access the variable set in one step to another step?

I am working on a project, for this I need a branch based environment variable. I tried to implement as
- name: Set the variables
  uses<EMAIL_ADDRESS>      with:
         SECRET_KEY: |
            development:${{ secrets.SECRET_KEY }}
          CHECKVAR: |
            development:"hi i am checkvar"

- name : Test by python
  run: |
      echo "start of echo :"
      echo "$SECRET_KEY"
      echo "$CHECKVAR"
      echo "end of echo"

I am not able to see the output of echo in the next step. I think the variable set are not passed to the next step. Am I doing it wrong or is there any step to pass variable to the next step. I tried to implement  run echo "var_name=VALUE" >> $GITHUB_ENV. I am not able to run it inside the with block. Please tell me the proper way of using it.

Are you on the development branch? Those variables are only present on the development branch.

Hello Sam. I wasnot able to access the variable in the development branch.  In the above case output  of echo "$CHECKVAR" is empty in development branch.

Yes, fairly sure this is expected Github Actions behavior, environment variables aren't saved across steps. Which leaves me wondering how anyone uses this plugin at all?

Environment variables are persistent across steps (not across jobs, that is another topic). To retrieve them in through bash script your formatting will not work, you need to explicitly call the environment context through an expression. I got it to work by using the below code. Please note that the secret value will be printed as ***. Hope this helps!
`      - name: Set the variables
uses<EMAIL_ADDRESS>with:
SECRET_KEY: |
development:${{ secrets.SECRET_KEY }}
CHECKVAR: |
development:"hi i am checkvar"
  - name: Test by python
    run: |
      echo "start of echo :"
      echo "${{ env.SECRET_KEY }}"
      echo "${{ env.CHECKVAR }}"
      echo "end of echo"`

Hi @rvdlaarschot, unfortunately that's slightly mistaken. This step uses the GitHub actions core Javascript library to set the env vars:
https://github.com/iamtheyammer/branch-env-vars/blob/master/src/index.js#L172
That function writes variable values to the GITHUB_ENV file which is loaded into the env with each step:
https://github.com/actions/toolkit/blob/dd046652c32b45c0207b37ee0bc0ebf43a28b257/docs/commands.md#set-an-environment-variable
Thus it is readable via the env. context as well as the shell environment, and something like this works:
name: "Test"

on: [ "push" ]

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
    - name: Variables
      uses<EMAIL_ADDRESS>      with:
        SECRET_KEY: |
          main:${{ secrets.SECRET_KEY }}
        CHECKVAR: |
          main:"hi i am checkvar"
    - name: Test
      run: |
        echo "start of echo :"
        echo "$SECRET_KEY"
        echo "$CHECKVAR"
        echo "end of echo"

As can be seen on this GitHub actions run:
https://github.com/hero-david/demo-branch-env-vars/runs/7601243111?check_suite_focus=true
I found this thread because I was looking for answers around unset vars, and realised I was just on the wrong branch (It had been a long day!). @bishal-insight Worth -double- triple checking that, but it might also be worth examining the seemingly incorrect formatting of the with statement in your example
- name: Set the variables
  uses<EMAIL_ADDRESS>      with:
         SECRET_KEY: |

With blocks need to be at the same level as the uses: key per my example above :+1:
It probably also helps to click  Re-run all jobs and then click Enable debug logging and include those logs to get a better understanding of what is going on and include those in issues :-)
There is also very good output included in the drop down by default, allowing you to see if a variable has 'hit' or not, and whether the `with: block has been picked up by the action:

Hope this somewhat helps people in future, thanks for the plugin @iamtheyammer! Has made setting certain values across branches a trivial pursuit :heart:

Huge thanks to @hero-david for your fantastic writeup and @rvdlaarschot for mentioning the ${{ env.XXX }} syntax and for pointing out that variables are persistent on subsequent steps in the same job, however they're not exactly in the shell environment. If you need them to be in the shell environment, you'll need steps like this (as shown in docs here):
     - name: Set the variables
        uses<EMAIL_ADDRESS>        with:
          SECRET_KEY: |
            development:${{ secrets.SECRET_KEY }}
          CHECKVAR: |
            development:"hi i am checkvar"

      - name: Test by python
        env:
          SECRET_KEY: ${{ env.SECRET_KEY }}
          CHECKVAR: ${{ env.CHECKVAR }}
        run: |
          echo "start of echo :"
          echo "$SECRET_KEY"
          echo "$CHEKVAR"
          echo "end of echo"

Note the env section in the Test by python step.
Just a couple of things to mention before I close this issue:

@rvdlaarschot: in your example, you put the value for CHECKVAR on the development branch in quotes-- note that those quotes will be present in the final, exported value-- they aren't stripped out.
@bishal-insight: for anyone reading this in the future trying to use echo "var_name=VALUE" >> $GITHUB_ENV to add environment variables, this is no longer supported. You need to use echo "{environment_variable_name}={value}" >> $GITHUB_ENV, as mentioned here in the GitHub docs.

I'll check it out this afternoon. Thanks for helping me debug!
On Tue, Mar 29, 2022 at 5:00 AM, bishal-insight < @.*** > wrote:

Hello Sam. I wasnot able to access the variable in the development branch.
In the above case output of echo "$CHECKVAR" is empty in development
branch.
—
Reply to this email directly, view it on GitHub (
https://github.com/iamtheyammer/branch-env-vars/issues/9#issuecomment-1081613096
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AHUZB3SZ4SKXGKFYCUNYFYTVCLBCHANCNFSM5R3NVPZA
).
You are receiving this because you commented. Message ID: <iamtheyammer/branch-env-vars/issues/9/1081613096
@ github. com>


password reset

I can see that the users table has a few columns related to password reset but I can't find the  feature in the UI. Is it not implemented?

Duplicate https://github.com/kennygrant/gohackernews/issues/26


some kind of bug

After wrestling with moment for a day, I believe I found a bug, which I reduced to the following simple example:
moment('1/1/15').valueOf() == moment.utc('1/1/15').valueOf()
moment('1/1/15').month(11).valueOf() == moment.utc('1/1/15').month(11).valueOf()
and
moment('11/1/15').valueOf() == moment.utc('11/1/15').valueOf()
BUT...
moment('11/1/15').month(11).valueOf() != moment.utc('11/1/15').month(11).valueOf()
How can the valueOf two moments be equal, but calling month(11) on them makes them diverge?

They all are equal to me. What exactly did you do to get the last example not to be equal?

Probably DST related.  What country and time zone are you in?
Also, you should lot parse locale-specific formats without providing a format specifier.  Doing so reverts the parsing behavior to your browser's, and throws a warning to the console.

the same issue happens independent of format.. if i use unixtime for instance

i am PST in Los Angeles. But like the example shows, the valueOf the moments are the same, so how could DST matter after that point?

Here is another version of the same bug, showing the values:
foo = moment('1/1/15')
foo.valueOf()
1420099200000
foo.month(11).valueOf()
1448956800000
foo = moment.utc('1/1/15')
foo.valueOf()
1420099200000
foo.month(11).valueOf()
1448956800000
foo = moment('11/1/15')
foo.valueOf()
1446361200000
foo.month(11).valueOf()
1448956800000
foo = moment.utc('11/1/15')
foo.valueOf()
1446361200000
foo.month(11).valueOf()
1448953200000

and here it is with just numbers, no formatting:
foo = moment(1446361200000)
foo.valueOf()
1446361200000
foo.month(11).valueOf()
1448956800000
foo = moment.utc(1446361200000)
foo.valueOf()
1446361200000
foo.month(11).valueOf()
1448953200000

Nevermind, not DST related.  It's because months passed to the month function are 0-11, not 1-12 like they are when in a string.  This is expected.

anongnito.. I am literally just pasting the above directly into chrome debugger

I know months are 0-11.. I am passing 11, so why is it expected to be different?

the thing to notice is the last value of each section:
1448956800000
1448953200000
These should be the same

oh and BTW, you can pass 0-N to month, it is not limited to 11. In fact I am using it successfully in this way to iterate months (after working around this bug).

The value you're passing in is in November.  When you call month(11), you're setting it to December.  Of course the resulting values will be different.  Perhaps looking at the fully formatted output will help you understand:

Also consider:

Even without the call to month(11), they're not equal because the source values aren't equal.  The time in UTC is not the same as the same local time.

Also, now that I run your examples from the very top of this post through moment, all four are inequal.  You stated the first three were equal, but they are not.

If I get it right, you are using the American date format MM DD YY.
By using the date 1/1/15, 1 = January, months are read from 0 to 11, so 0 in theory should be January.
First Example
foo = moment('1/1/15')
foo.valueOf()
1420070400000
foo.month(0).valueOf()
1420070400000
Second Example
foo = moment('11/1/15')
foo.valueOf()
1446336000000
foo.month(10).valueOf()
1446336000000
As you can see, it's the same. The correlation between actual real-life month date and the one written in code is -1. January is 0 and December is 11.

@Anongnito - Are you in a +00:00 time zone, like the UK?

@mj1856 Yes, I am in the UK, that would explain why the are equal for me.

Exactly.  UTC can only be equivalent to local time, if the local time is aligned with UTC.  @Anongnito would get false if evaluating a date in the summer while the UK is on BST (+01:00).   @ethanj should get false at any time, being in the US Pacific time zone.
And the month/day vs day/month format order is indeed problematic also, which is why you MUST specify a format string.  moment('1/1/15','M/D/YY'), not moment('1/1/15').

I get this in the debugger:
moment('1/1/15').month(11).valueOf() == moment.utc('1/1/15').month(11).valueOf()
true

so yes there is some format issue with that one...
moment('1/1/15','M/D/YY' ).month(11).valueOf() == moment.utc('1/1/15', 'M/D/YY').month(11).valueOf()
false
I will create examples using just numbers so we avoid that as a factor.. one sec...

so can we agree about the following:
foo = moment(1446361200000)
foo.valueOf()
1446361200000
foo = moment.utc(1446361200000)
foo.valueOf()
1446361200000
if i understand the docs correctly, utc does not affect the internal representation, which is why the above are equal? In other words, valueOf() is timezone and DST independent?

this translates to:
moment(1446361200000).valueOf() == moment.utc(1446361200000).valueOf()
true

Yes, you are correct that valueOf is just the UTC-based raw timestamp, regardless of mode.  The difference comes in when you parse the string in input vs local mode.

but here is what i get:
moment(1446361200000).month(1).valueOf() == moment.utc(1446361200000).month(1).valueOf()
false
moment(1446361200000).month(2).valueOf() == moment.utc(1446361200000).month(2).valueOf()
false
moment(1446361200000).month(3).valueOf() == moment.utc(1446361200000).month(3).valueOf()
true
moment(1446361200000).month(4).valueOf() == moment.utc(1446361200000).month(4).valueOf()
true
moment(1446361200000).month(5).valueOf() == moment.utc(1446361200000).month(5).valueOf()
true
moment(1446361200000).month(6).valueOf() == moment.utc(1446361200000).month(6).valueOf()
true
moment(1446361200000).month(7).valueOf() == moment.utc(1446361200000).month(7).valueOf()
true
moment(1446361200000).month(8).valueOf() == moment.utc(1446361200000).month(8).valueOf()
true
moment(1446361200000).month(9).valueOf() == moment.utc(1446361200000).month(9).valueOf()
true
moment(1446361200000).month(10).valueOf() == moment.utc(1446361200000).month(10).valueOf()
true
moment(1446361200000).month(11).valueOf() == moment.utc(1446361200000).month(11).valueOf()
false
moment(1446361200000).month(12).valueOf() == moment.utc(1446361200000).month(12).valueOf()
false
moment(1446361200000).month(13).valueOf() == moment.utc(1446361200000).month(13).valueOf()
false
moment(1446361200000).month(14).valueOf() == moment.utc(1446361200000).month(14).valueOf()
false
moment(1446361200000).month(15).valueOf() == moment.utc(1446361200000).month(15).valueOf()
true

I don't see how you get true for that first example, unless your time zone is UTC or UK or something.  Is this browser code, or running on the server?  What version of browser/environment/moment?
Here's my output on the latest chrome with latest moment on windows in Pacific time zone:

moment.version
"2.6.0"
navigator.appVersion
"5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36"

I have to board a plane, but feel free to continue the troubleshooting without me.  Try the current version (2.11.1) instead of 2.6.0.  You may be experiencing something we fixed already.

enjoy the ride

@ethanj Did you have the same issue with 2.6.0?

Ok, I was able to reproduce it in older versions.  I tracked it down to #1983, which was fixed with #2001 in moment 2.8.4.

That bug explains the differences with the original question, using the m/d/y format without a format qualifier, which falls back to the date constructor.
The other thing that came up in this discussion was starting with a timestamp, then getting different results on which month was set.  This is actually not a bug at all.  Consider:
for (var i = 0; i <= 11; i++) {
  var t =<PHONE_NUMBER>000;
  var b = moment(t).month(i).valueOf() == moment.utc(t).month(i).valueOf();
  console.log (i + ':  ' + b);
}

When run in the Pacific time zone, it will return true only for months 3 through 10. Why?  Because:
moment(1446361200000).format()  // "2015-11-01T00:00:00-07:00"

Since the offset is -07:00, you can change the month to any other month where the 1st at midnight also uses -07:00 and it will be equivalent to changing to the same month in UTC:
moment(1446361200000).month(3).format()      // "2015-04-01T00:00:00-07:00"
moment.utc(1446361200000).month(3).format()  // "2015-04-01T07:00:00+00:00"

But when summer is over, DST ends and Pacific time returns to -08:00, so the same operation doesn't line up:
moment(1446361200000).month(11).format()      // "2015-12-01T00:00:00-08:00"
moment.utc(1446361200000).month(11).format()  // "2015-12-01T07:00:00+00:00"

Since midnight in -8 doesn't align with 7am in UTC, then you get false for the comparison.

while it may be true that this is not a bug, it seems to me that the library does not implement a common sense version of stuff so that one can easily iterate months... I will post the code that led me to this in a bit...

The library is doing the correct thing, I think perhaps your assumptions may be off.  I'll be happy to look at your code to help.
Keep in mind that DST is a PITA with stuff like this.  Moment is correctly taking DST into account to determine the offset for the target value. Switching months will attempt to keep the same year, day, hour, minute, second, and millisecond as the original value, and will do so within the context of the mode that it's currently operating in.  Since the source value is 7AM in UTC, and UTC doesn't do DST, then all results will also be in 7AM UTC.  But the value is 12AM in Pacific time, then switching months will still end up at 12AM in Pacific, regardless of whether Pacific is at -7 or -8.  It's screwy, but that's just how time works.
I said "attempt" in the last paragraph, because if you switch to a time that doesn't exist (such as during a spring-forward transition), or a day that doesn't exist (because you were near the end of the month and months have different lengths), then the other values might be adjusted.

yes, you are correct... I figured out from whence the confusion stemmed...
curdate = moment.utc('11/1/15', 'MM/D/YY');
curdate = moment.utc(1446361200000);
these are not equal in terms of valueOf()
so the issue likely was a result of not using the format on parse in an earlier version, and assuming the numeric value was correct.
thanks for your help!
Ethan

No problem.  Glad to help!


Help understanding SRAOpcodeTest

In my emulator I am failing on the SRAOpcodeTest and need help understanding why it's wrong (or perhaps the SRA test is wrong?)
Test 'SRAOpcodeTest' failed: a == b expected, but a=0xfffffffffc190a19 b=0xc190a19. Register $4

Running SRAOpcodeTest2...
Test 'SRAOpcodeTest2' failed: a == b expected, but a=0xffffffffffff8321 b=0xffffffff93218321. Register $4

Running SRAOpcodeTestShift0...
Running SRAOpcodeTestIntoItself...
Test 'SRAOpcodeTestIntoItself' failed: a == b expected, but a=0x10c850c b=0xffffffff850c850c. Register $3

As you can see, the tests are failing due to sign-extension.
The code for SRA is very simple. Failing code (Rust):
    fn special_sra(&mut self) {
        // truncate to u32, convert to signed, shift (fills 1s in the upper bits) and sign extend to u64
        self.gpr[self.inst.rd] = (((self.gpr[self.inst.rt] as u32) as i32) >> self.inst.sa) as u64;
    }

Working code:
    fn special_sra(&mut self) {
        self.gpr[self.inst.rd] = ((self.gpr[self.inst.rt] >> self.inst.sa) as i32) as u64;
    }

The first (non-working) implementation truncates rt to 32 bits, treats it as a signed int, shifts it right, and then sign-extends to 64 bits. The second working implementation shifts the full 64 bits and whatever bit ends up in bit 31 is sign extended to 64-bits.  This seems like it's in contradiction to the VR4300 datasheet:

From the psuedocode, at the 64-bit section:

Extend the shift amount by one 0 to make it a positive number (s)
Take bits GPR[rt] bits 31 downto s and place them in the lower bits (temp). Prefix those bits with GPR[rt] bit 31 repeated s times.
Set GPR[rd] to temp bits 31..0 and prefix that with temp bit 31 repeated 32 times to make a 64-bit int.

I don't see how any bits from the upper word end up in the lower word given the psuedocode in the datasheet.  If all 64 bits are shifted, then what makes the DSRA instruction different from SRA, other than the sign extension?
I hope someone is able to help me understand
Cheers

Yes, the datasheet is wrong. I've tested this behavior against real hardware using my tests here: https://github.com/Dillonb/n64-tests/releases/tag/latest - SRA shifts the entire 64 bit value, then truncates and sign extends.

Thanks for the information.  Would it be correct to say that the implementation of SRA in the hardware is incorrect/a bug and that the datsheet was the intended behavior?
It seems to me that SRA should shift only the lower 32 bits (treated as a signed 32-bit number) while DSRA would do the doubleword.

Probably not, my theory is they just took a shortcut when implementing it in hardware. It behaves correctly when used with a 32 bit sign extended value.

OK, thanks for the help understanding this


Fetching installation for view_submission in connected channels

Description
When submitting a form in a connected channel the team supplied to fetchInstallation is the team the form is submitted in, not the team the app is installed in.  This is not the case with message and action events.
For example:

WorkspaceOne has App installed
WorkspaceTwo shares Channel with WorkspaceOne
App is available in Channel
WorkspaceTwo does not have App installed

When a user sends a message to App:

In WorkspaceOne  - team is WorkspaceOne.
In WorkspaceTwo  - team is still WorkspaceOne.

This allows data to be stored against the workspace the app is installed against.
However, when a modal is submitted to App:

In WorkspaceOne - event.team is WorkspaceOne.
In WorkspaceTwo - event.team is WorkspaceTwo.

This results in a failure for users in WorkspaceTwo as App tries to load data against WorkspaceTwo where App has not been installed.
view_submission events do include the workspace for the installed app but it is included under view.app_installed_team_id, not, team.
I've spoken to Slack Support and they suggest this is the correct behaviour and should be handled in bolt-js.
So, is this a bug or expected behaviour?
I haven't dug in to the code yet but is it a case of sending view.app_installed_team_id to fetchInstallation when the event is a view submission?
Might be worth noting: In my usecase the two workspaces have actually been migrated into an Enterprice grid since App was installed.  I don't think it matters but I don't have any other paid workspaces to try this against (connected channels require paid tier).
What type of issue is this? (place an x in one of the [ ])

[x] bug
[x] enhancement (feature request)
[x] question
[ ] documentation related
[ ] example code related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Reproducible in:
package version: "@slack/bolt": "^3.10.0",
node version: 16.somethingOrOther
OS version(s): MacOS and Firebase
Steps to reproduce:

Install App in WorkspaceOne
Add App to Channel
Connect Channel to WorkspaceTwo
Submit a modal in WorkspaceTwo

Expected result:
Installation for WorkspaceOne is fetched.
Actual result:
Installation for WorkspaceTwo is fetched and breaks as it doesn't exist.
Attachments:
Not particularly helpful screenshot of the modal error... becuase why not:

Hi @rockingskier thanks for writing in and for such the quality bug report 🥇
I looked into this briefly and this behavior does seem unintuitive, based on this sample payload it seems like app_installed_team_id is a field specific to view events. This behavior may be intentional to allow developers to access team_id as well as app_installed_team_id.
Locking at the code of bolt python this behavior seems to be present there as well, this may be a Bolt not just a Bolt-js issue.
It may be worth while discussing wether Bolt should somehow be able to detect which team_id to pass to fetchInstallation or if this behavior should be documented in some way.
@filmaj @seratch what do you think about this?

Only had a cursory glance but it looks like buildSource creates the InstallationQuery that gets passed to authorize;
Maybe something along these lines is needed here-ish:
    if (type === IncomingEventType.ViewAction) {
      const bodyAsView = body as SlackViewMiddlewareArgs['body'];

      if (bodyAsView.view.app_installed_team_id) {
        return bodyAsView.view.app_installed_team_id;
      }
    }

This is obviously a breaking change.  In concept, it feels right to me but that's because it's causing me issues 😄.  I expect there are larger concerns to be considered.  Also tests.
I won't make PR yet as I'm AFK for a few days but figured I'd drop this here in case it helps.

I've confirmed that this is a valid bug report (thanks again! @rockingskier)
Here is a fix for bolt-python: https://github.com/slackapi/bolt-python/pull/734 I will make a PR for bolt-java too.
@WilliamBergamin Can you work on the fix for bolt-js if you have a chance?

https://github.com/slackapi/bolt-js/pull/1615 resolves this issue. The next patch version including the fix will be released soon.

@seratch sorry to be that person but... do you know when this might get released? I have a number of users waiting for this fix. Thanks

Hi, @rockingskier! Thanks for following up!
This has been released in v3.12.2, which is available now. You can view the release notes here!

Thanks all involved. I have the fix deployed and working. Happy dev, happy users.


Optimization of HTML generated by cargo timings

Problem
Sometimes I use cargo timings in my projects, and find that the HTML generated by them often slows down the browser (chrome in my case).
I have also measured the cargo timings in the cargo project for reproduce, and it seems to be taking longer to work as well. (As shown in the attached image, it took about 5s to become operational.)
I guess that the browser is slowing down because the JS that is drawing the canvas is occupying the CPU.
There might be room for optimization of the generated JS.

cargo-timing.html.zip
Proposed Solution
No response
Notes

cargo 1.75.0 (1d8b05cdd 2023-11-20)
Host: x86_64-apple-darwin
Chrome Version 120.0.6099.216 (Official Build) (x86_64)

I didn't try this in Firefox because of https://github.com/rust-lang/cargo/issues/8850 .

Some related exploration about improving the timing HTML people might be interested in: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/New.20visualizations.20for.20cargo-timing.2Ehtml. Feel free to experiment on modernizing the HTML/JS/CSS part of it.


(SERVER-1315) Use key pair file when extracting ca-cert

The initial approach for extracting and verifying the CA certificate
used a single public key; unfortunately this doesn't mesh with what
Puppetserver expects. Changes made in SERVER-86 specifically tested that
certificate signing could happen without a ca public key. Since the
private keys we generate contain both the public and private key, we can
extract the public key from that pair and use that comparison. Switching
from a standalone public key to a private key with associated public key
should be more correct as we're doing comparisons with the content we'll
actually be using for signing.

Since the private keys we generate contain both the public and private key

Is that typical? I know we do a bunch of non-standard stuff with our PKI, but is it sane to expect folks who have set up an intermediate CA to have put down a private key that includes the public key?

Here's the ASN.1 definition for an RSA private key:
         RSAPrivateKey ::= SEQUENCE {
             version           Version,
             modulus           INTEGER,  -- n
             publicExponent    INTEGER,  -- e
             privateExponent   INTEGER,  -- d
             prime1            INTEGER,  -- p
             prime2            INTEGER,  -- q
             exponent1         INTEGER,  -- d mod (p-1)
             exponent2         INTEGER,  -- d mod (q-1)
             coefficient       INTEGER,  -- (inverse of q) mod p
             otherPrimeInfos   OtherPrimeInfos OPTIONAL
         }

And that of an RSA public key:
         RSAPublicKey ::= SEQUENCE {
             modulus           INTEGER,  -- n
             publicExponent    INTEGER   -- e
         }

So the RSA public key can always be derived from a private key.
Switching to the private key also means that we're actually checking against the file that we'll be using for signing; using $capub isn't as reliable because it doesn't have to match or be present. I made this switch because Puppetserver explicitly checks that certificates can still be signed when $capub is absent.

I've removed objectToKeyPair and collapsed that functionality into the calling code.


Looking for Suggestions on Fully Supporting Swift 6’s Sendable

I’m exploring ways to fully support Swift 6’s Sendable using a @UseCase attribute.
Currently, property wrapper are mutable and, therefore, can't conform to Sendable.
To overcome this, I’ve started looking into the use of custom macros.
One idea is to create a macro that would expand:
@UseCase private var getHomeUseCase: GetHomeUseCaseProtocol
to
private var getHomeUseCase: GetHomeUseCaseProtocol {
    get {
        UseCaseContainer.shared.getHomeUseCase().resolve()
    }
}

Using a Swift template, I could generate the corresponding macro package.
The template would look something like this:
<%- includeFile("AutoInjectable.swift") -%>

<% let containers = AutoInjectable.getContainers(types: types) -%>

// sourcery:file:Package.swift

<%- include("AutoInjectablePackage.swift") %>

// sourcery:end

// sourcery:file:Sources/Injected/Injected.swift

<%= AutoInjectable.generateExternalMacros(from: containers) -%>

// sourcery:end

// sourcery:file:Sources/InjectedMacros/InjectedMacros.swift

// swiftlint:disable all

<%= AutoInjectable.generateMacros(from: containers) -%>
// swiftlint:enable all

// sourcery:end

The generated macros will look like:
public struct UseCaseMacro: AccessorMacro {
    public static func expansion(
        of node: SwiftSyntax.AttributeSyntax,
        providingAccessorsOf declaration: some SwiftSyntax.DeclSyntaxProtocol,
        in context: some SwiftSyntaxMacros.MacroExpansionContext
    ) throws -> [SwiftSyntax.AccessorDeclSyntax] {
        guard
            let variableDecl = declaration.as(VariableDeclSyntax.self),
            let name = variableDecl.bindings.first?.pattern.description.trimmingCharacters(in: .whitespacesAndNewlines)
        else { return [] }

        return [
            """
            get {
                UseCaseContainer.shared.\(raw: name).resolve()
            }
            """
        ]
    }
}

Downsides:

No Automatic Type Inference: The type of the variable isn't automatically inferred, meaning it must be explicitly annotated.
Variable Naming Convention: The variable name must match the name used in the container, or potentially, the inherited protocol could be used instead.
Importing the Injected Package: The Injected package has to be imported every time the macro is used. Alternatively, @_exported import could be used to simplify this.

Do you have any suggestions or ideas to improve this approach? Thanks!

Are you using the latest version of main? https://github.com/jimmya/sourcery-templates/commit/c053e11888c62781023c5e9e894e777fc7708dc2 I think this should fix the issue.
It's marked as @unchecked Sendable since Factory is thread safe by itself so this should be fine.

Looks like the fix I mentioned above only applies when the property wrapper is used in a struct.
I think we should note this down as a current limitation of swift and not try to work around it within the templates. Or wait until the Factory library has a InjectedSendable property wrapper (if even possible). Or until the property wrapper let proposal is implemented and merged.
Until that time I'd suggest to go with the manual computed property approach.
There is some syntactic sugar to make it a bit easier to work with:
private var getHomeUseCase: GetHomeUseCaseProtocol {
    UseCase.make(\. getHomeUseCase)
}

Otherwise try any of the suggestions in this thread: https://github.com/pointfreeco/swift-dependencies/discussions/204#discussioncomment-9054649
Personally I'd make the thing you're using the property wrapper in a struct if possible. Or mark your class @unchecked Sendable. As mentioned above, Factory internals are threadsafe.

Okay, we will use your example and hope the proposal gets implemented and merged. Thanks! 🙏🏻


Fail to upgrade HexRays.IDA.Free exits WinGet instead of continuing with other upgrades

Brief description of your issue
doing winget upgrade I saw
Name                                     Id                                        Version        Available      Source
...
IDA Freeware and Hex-Rays Decompilers (… HexRays.IDA.Free                          7.6            7.7            winget
...
so I did
winget upgrade --all -h
but when it reached that IDA entry it failed (had been installed sometime in the past manually) it failed (said I should ask manufacturer for an app for my Windows [note I'm on 64-bit, so not sure what was that which failed showing a dialog that is usually shown when you run 64-bit on 32-bit Windows], could it be ARM or 16-bit stuff or some corrupted image?)
the bug though is that WinGet exited at that point (whereas at some installers before where it had low disk space [say for Docker which was big] it just continued when their installers failed after succesful download)
Steps to reproduce
need to have specific software and version of it installed most probably, see description
upgrading multiple items fails upon reaching that (and exits WinGet)
Expected behavior
expected to continue with next item (was just at 9/36 updates)
Actual behavior
see screenshot, it fails to continue

Environment
Windows Package Manager v1.2.10271
Windows: Windows.Desktop v10.0.22000.675
Package: Microsoft.DesktopAppInstaller v1.17.10271.0

Is there any chance you could share the log?

how do I get the log?

note that I did the same action again (in the same admin command prompt window) and it did install this time IDA without taking down winget

it did ask for such (this time that it installed). Don't remember seeing such (before it crashed) the last time. Even if it had timedout though at IDA installer asking of admin privs it shouldn't take down winget.
The 2nd run did the same error (with the unreadable chars [I'm using Greek language on Win11]) with other package (Ubisoft Connect) this time:

I will try running till all install and then share the logs (hope they're appending and not cleared on each run)

does it somehow cancel installed items when it crashes? it seems to reinstall the same version of IDA that succesfully installed, VoiceBot too etc.

btw, it shouldn't be any timeout issue at the UAC prompt, since at the 2nd try to upgrade IDA one that said it install succesfully (even though it seems to reinstall it) I had left the machine and came back to respond Yes at the UAC prompt some hour(s) later and it proceeded

If a UAC isn't acknowledged, there is a timeout period where the client assumes a failure and will continue running the upgrade all process.

probably that timeout is quite long, since it didn't cause issue in my case waiting for an hour so (unless I should suspect a compromised UAC screen)

WinGet-GOG.Galaxy.<IP_ADDRESS>-2022-05-18-21-37-31.084.zip

WinGet-logs-20220518.zip


bounty to email

I want to send the stolen cookies/ passwords directly to my email.

hi @arize99
you can use XSSHUNTER
regards


KAFKA-12332: Error partitions from topics with invalid IDs in LISR requests

Changes how invalid IDs are handled in LeaderAndIsr requests. The ID check now occurs before leader epoch. If the ID exists and is invalid, the partition is ignored and an UNKNOWN_TOPIC_ID error is returned in the response.
This error should be rare, but if it occurs, it signals the need for manual intervention.
Added tests for this behavior.
I also plan to rerun the benchmark from https://github.com/apache/kafka/pull/10071 to ensure there are no regressions with this change.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@hachikuji I was wondering if I should do that. I think I've been having issues with mailer daemon trying to send to DISCUSS so I'll send to VOTE this time.

Ran tests locally with newest code from trunk. Here are the tests that failed:
ConsumerBounceTest. testClose()
ConnectionQuotasTest. testListenerConnectionRateLimitWhenActualRateAboveLimit()
DynamicConnectionQuotaTest. testDynamicListenerConnectionCreationRateQuota()
These are tests I've found to be flaky running locally.


chore(dependencies): Upgrade org.postgresql:postgresql to resolve CVE

CVE-2020-13692

According to recommendation, fix is applied in Kork. So closing this PR.


Dynamically generate job link URL.

For Hadoop/Spark jobs, the job log first stays in resource manager, after some time, it will be moved to job history server. The current web proxy job link in Azkaban user logs doesn't always work properly. When user click the link, it often expires. Users have to search for the application_id and then manually type the RM or JH link to find the actual job log.
I've added a new button on job log page to provide the dynamic job link. See attached images for the UI change. When user click the "Hadoop Job Log" or "Spark Job Log" button, it first logins to RM using authenticated keytab files, then parses the web content to determine whether the job log has expired on RM and been moved to JHS. It constructs the correct job link URL and returns to the user. If the job fails or is killed, the button color will turn red to attract users' attention to click the button and debug their jobs.
To enable this feature, we need configuration changes in azkaban.properties for all clusters. Here is an example:
# Hadoop/Spark Job link url
azkaban.server.external.resource_manager_job_url=http://***rm***:8088/cluster/app/application_${application.id}
azkaban.server.external.history_server_job_url=http://***jh***:19888/jobhistory/job/job_${application.id}
azkaban.server.external.spark_history_server_job_url=http://***sh***:18080/history/application_${application.id}/1/jobs

Note: ${application.id} will be replaced at run time.
I've enabled the configuration and tested on our testing cluster.

To improve this feature, I changed "Hadoop Job Log"/ "Spark Job Log" button color to red if the job fails or is killed. The button will be more noticeable and informative to users so that they are more likely to click the button to debug their jobs.

Edited the job URL examples in the comment in a new PR: https://github.com/azkaban/azkaban/pull/1708

Hadoop core team members pointed out that PIg/HIve jobs can run multiple MR jobs and the AZ logs may contain multiple links.
e.g.
a pig job
Job DAG:
25-03-2018 13:06:54 PDT pymk-profile-views INFO - job_1521836707298_331557	->	job_1521836707298_334891,job_1521836707298_335536,
25-03-2018 13:06:54 PDT pymk-profile-views INFO - job_1521836707298_334891	->	job_1521836707298_335424,
25-03-2018 13:06:54 PDT pymk-profile-views INFO - job_1521836707298_335424	->	job_1521836707298_335536,
25-03-2018 13:06:54 PDT pymk-profile-views INFO - job_1521836707298_335536	->	job_1521836707298_337213,
25-03-2018 13:06:54 PDT pymk-profile-views INFO - job_1521836707298_337213

Have you evaluated the option of just showing the additional job history server URLs after the existing log URLs as I suggested earlier offline?
By doing that the implementation is much simpler and we don't have to worry about the compatibility issues and its associated testing costs.
I am not sure how much additional value users will perceive the buttons/dropdowns compared with the solution above. I don't expect them to look at the log URLs unless they are debugging an issue. In that situation, they would probably want to look at the complete logs for context anyway. At least they may not mind looking through the logs since they don't need to do it that often hopefully.
And users are already familiar with where to look already. As an example, when you tested it with Subu the other day. He was looking at the log and saw the old link and missed the new button until I told him.
Have you got some feedback from users which design works better for them?
Why is it considered an experimental feature?

I agree with you. As I've mentioned in my previous comments:
If needed, I can also add another jobhistory server link under the current web proxy link in the user log.
I think there was some miscommunication about the new feature at the time when I showed to Subu. Anyway we can ask users if they want the additional button feature. One way is to provide the feature for them to try and then collect the feedback. That's part of the reason I want to make it experimental. Also, as we discussed, it is not easy to catch incompatibility issue if there is a Hadoop side change. So I prefer to make it experimental.

Sounds good. Thanks

Looks like most of the logic don't have unit test coverage. We really should enable code coverage reports.


Template BindingContext is internal and can't be used

I am trying to use partials with a RegisteredTemplate but the object being passed can't be converted to a usable object.  I noticed that the object that is passed is a HandlebarsDotNet.Compiler.BindingContext but it is an internal class so I can't cast the object to it.  Below is the method I am using as the handler.
private static void Template(TextWriter arg1, object arg2)
{
var context = arg2 as HandlebarsDotNet.Compiler.BindingContext;
}

Nevermind I was trying to treat it like an event handler.


Add support for polymorphic type parametrization

As per #923 report I was assuming that functions can be parametrized in a way polymorphic classes can be:
export type Dictionary <value> = {[key:string]: value}

const dict = <value>(data:?{[key:string]:value}):Dictionary<value> => {
  const result = Object.create(null)
  if (data != null) {
    for (let key in data) {
      if (data.hasOwnProperty(key)) {
        result[key] = data[key]
      }
    }
  }
  return result
}

dict<number>({x: 1})

It turns out that last line is actually a syntax error (which flow should report as such) & instead it should be parametrized as follows:
(dict:(data: ?{[key:string]:number}) => Dictionary<number>)({x: 1})

I would really like if flow's syntax could be extended to understand dict<number>({x: 1}) instead as typing above thing is really ridiculous.
I know one could type following instead:
const nums:Dictionary<number> = dict({x: 1})

But it kind of feels backwards and also requires library author to export Dictionary type along with a function, which is why I would much rather have parametrization of the function at the invocation site.

Note that you also can't write new C<number>(0), given class C<T>.

I'm really not convinced that this kind of syntax is useful. Why do you want to write dict<number>({x: 1}) instead of the equivalent, and shorter dict({x: 1})?

I'm really not convinced that this kind of syntax is useful. Why do you want to write dict({x: 1}) instead of the equivalent, and shorter dict({x: 1})?

Because in that case following does not error:
ns = dict({x: 1})
ns.y = "two"

Note that you also can't write new C(0), given class C.

You are right, I was referring to class D extends C<number> {...}

@samwgoldman also please note that even if ns in the example below was Dictionary<number> that still may not be what one wants:
ns = dict({x: 1})
ns.y = "two"

What if I actually would want to have both strings and numbers in that case I'd like to do following:
ns = dict<string|number>({x:1})
``

not to mention that in some case I may not even have a seed value:

```js
const nums = dict<number>()

Well, there's a syntax ambiguity (between the relational operations and type parameterization), but I guess I see the value. @gabelevi, is this the kind of type syntax we want to add? We'd also need to build support for Babel to strip, which is made tricker due to the syntax ambiguity.


fix_emoji_crash

Description
fix in iOS paste emoji crash
1 Test code
import 'package:flutter/material.dart';

class MyTextField extends StatelessWidget {
//  MediaQuery
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: TextField(
          maxLines: null,
        ),
      ),
    );
  }
}

void main() async {
  runApp(MaterialApp(
    home: MyTextField(),
  ));
}

environment
device：iOS 12 ，iPhone
keyboard setting ： english & emoji

analyze

main() {
  String a='𐐷';
  print(a.codeUnits.map((v)=> v.toRadixString(16)));
  String b='宋';
  print(b.codeUnits.map((v)=> v.toRadixString(16)));
}

https://en.wikipedia.org/wiki/UTF-16 @dnfield one character may be two code units.
try this code,
Related Issues
Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.
Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[x] Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
[ ] No, this is not a breaking change.

I've tried this locally on an iPhone 8.  I can't seem to get the cursor to land in the middle of an emoji as you're showing here.  What version of Flutter are you using?  I'm on master.

Scratch that - I managed to reproduce it with some dragging around.  With a rainbow flag emoji, there was no crash (but I did end up with a separate rainbow and flag character :D). With a two code point emoji (one of the smiley faces), it crashed.

This actually is hitting on multiple bugs - /cc @justinmc @GaryQian @goderbauer who have all been involved in things related to this.

We shouldn't have the cursor be able to land in the middle of an emoji.
We shouldn't crash if the platform receives a message like this on iOS.

Right now I think a higher priority is to fix the crash on the engine side.

See https://github.com/flutter/flutter/pull/30851#issuecomment-481962028 for the iOS stack trace

Crash is due to iOS not tolerating invalid UTF-8 code sequence when decoding or encoding JSON.
Looking to see if we can make platform side more resilient (Android already handles this better).  We should definitely fix this on the framework side too.

I've tried this locally on an iPhone 8. I can't seem to get the cursor to land in the middle of an emoji as you're showing here. What version of Flutter are you using? I'm on master.

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, v1.4.18, on Mac OS X 10.14.4 18E226, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.2)
[✓] Android Studio (version 3.3)
[!] IntelliJ IDEA Community Edition (version 2018.3.3)
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
[✓] Connected device (2 available)

“make sure the cursor be NOT able to land in the middle of an emoji.”  is better，

I'm going to close this in favor of https://github.com/flutter/engine/pull/8747
Thanks for your help in diagnosing this issue!


Implement Wallet Login Protocol

https://github.com/cryptonomex/graphene/wiki/Wallet Login Protocol

@valzav Curious as to where this sits on the priority list. You thinking a month away or longer?

this is of low priority

OK, putting it in December.

Moving way out to January so we can focus.

Not of high priority, closing for now


Split "go_to" method into two

Currently, the "go_to(destination_state)" method does 2 things:
If no other transition is specified, the go_to method causes an immediate transition into the specified destination state.
Yet, if for one state, another transition is already specified (such as when_intent_match_go_to), the go_to method won't cause an immediate jump to the other state but rather wait for user input and only jump to the specified destination state in case the condition for the first transition does not match.
I would prefer if go_to would always cause an instant transition and if we had a second method for a jump in case no other condition matches or to wait for user input before the jump.

fixed with #13


Add lint workflow

This adds a lint workflow and fixes the jshint errors so the workflow succeeds. Most of the changes were for doublequote/semicolon use and missing "use strict" directives.
(WIP: still need to fix the last four "line too long" errors)

This is good to go now.
I'd still like to confirm that the changes to test_profile.js haven't broken anything, but I'm having trouble with the selenium/ZAP setup. I've left a message on OWASP gitter about it; any help would be much appreciated.

This is good to go now.
I'd still like to confirm that the changes to test_profile.js haven't broken anything, but I'm having trouble with the selenium/ZAP setup. I've left a message on OWASP gitter about it; any help would be much appreciated.

@binarymist can you please have a look at this PR and  confirm that changes to test_profile.js doesn't break  selenium/ZAP tests. Thanks!


ListenEvent, ListenResult doesn't return error when service is not running

Those api doesn't return error if service deployed but not running...

Yes they will not have any event if the service is not running but it will still be valid and when the service is started then they will have event. This is good behavior for me.

I experience this issue when developing an app, but yes it actually a valid behavior.


Write a packager's guide

It seems that people packaging Falcon for various OSes such as Linux distributions (or just hobby projects) have very different ideas how the process should look like, although PEP 517 was supposed to simplify that.
For instance, how do I test the built binary? It seems some packagers opt to invoke pytest directly without parameters and expect it to work, disregarding our tox environments completely (see: #2080, #2006 etc).

Where should this documentation be? A section in readme or a separate file?
@kloczek do you have a suggestions?

Absent better ideas, maybe README could link to a section on RtD.


[MM-32371] Enable desktop app to tell webapp when Back/Forward should be enabled

Summary
This PR allows the history_buttons component to talk to the desktop app directly and determine whether the Back/Forward buttons should be enabled.
Ticket Link
https://mattermost.atlassian.net/browse/MM-32371
Related Pull Requests
Desktop: https://github.com/mattermost/desktop/pull/1941
NONE

Thanks @devinbinnie
Looks good.
Noticed one thing, which may be out of scope as something similar is happening on daily and latest desktop app.
When you go back and reach the last place in history, screen seems to refresh and user loses a way to go forward.
I may not be explaining this properly. Including the video, let me know if that helps.
https://user-images.githubusercontent.com/52937121/149052339-ccaa444d-ff9d-4c0a-8c6b-eca4eae9dd74.mov

I was using the test server created here and the desktop app - Version 5.0.0-develop (5.0.0-develop.16099)

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/104855

I'll re-run the E2Es, current report has a lot of failures, about 66 vs. 25 on master.

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/105184

Thanks @devinbinnie and apologies for delay in checking the E2E report - looks good to merge, no PR related failures

Verified Desktop history buttons are shown enabled/disabled based on the available history (tested on related desktop app build)


Update s3, sdk-core, sqs to 2.17.74

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.38 to 2.17.74.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, early-semver-patch, semver-spec-patch

Superseded by #347.


Installation is optional

Issue #32 cmake option to disable install

@malytomas Is this what you have in mind?

Almost. Please add the three install commands into the conditional branch too.


fix(curriculum): Updated code example for RPG game explanation on variables

Changed the initializing of string to initialize number.
Checklist:

[ x] I have read and followed the contribution guidelines.
[x ] I have read and followed the how to open a pull request guide.
[x ] My pull request targets the main branch of freeCodeCamp.
[x ] I have tested these changes either locally on my machine, or GitPod.

Closes #53424

Hi @patel-bhumit. Congrats on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝


Add instructions for installing test env on Debian

Well, according to Atom's Markdown preview plugin, adding the language used for formatting inside a fenced code block (```shell instead of ```) doesn't highlight the content. Worse: it is grayed out because of the #, parsed as a comment:
Code:
```shell
# apt install ruby-dev vagrant
```

Rendering in Github:
# apt install ruby-dev vagrant

So I just let it like
```
# apt install ruby-dev vagrant
```

to make it render like
# apt install ruby-dev vagrant

It's up to you: # apt ... or $ sudo apt ...

Oh cool, I didn't know the thing about apt.
Well, to be consistent with the main README.md, it might be nice to
```bash
<just write the command execution without a $ or anything>
```

I prefer sudo apt.

There you go @anishathalye  :-)

I don't think shell-session is a supported language in GFM. How about using bash?

Sorry for the long wait. Squashed in 174949d and merged in f8f4696!


Fog Rewrite and Mixin changes

Changed fog removal to also work with sodium
Changed server check so that the server doesn't crash
Changed a lot of @Overwrite calls to @Inject for improved simplicity and code readability

Also do you have a discord?

This a pretty good PR!
I'll probably merge it when I can.

Also do you have a discord?

I don't really use discord to be honest.


Regression on kubernetes headless service backend

Hi,
I see a regression on traefik as ingress controller on 1.7.X to 1.7.4.
I was able to use traefik as ingress controller to point on a headless service on traefik 1.6.5, but in 1.7.X it seems that traefik isn't able to recognise the endpoint behind the service.
Here is the sample of declaration of my endpoint, service, ingress and ingress-controller :
---
apiVersion: v1
kind: Service
metadata:
  name: http
  namespace: test
spec:
  clusterIP: None
  ports:
  - port: 80
    protocol: TCP

---
apiVersion: v1
kind: Endpoints
metadata:
  name: http
  namespace: test
  labels:
    app: http
subsets:
- addresses:
  - ip: <IP_ADDRESS>
  - ip: <IP_ADDRESS>
  ports:
  - name: http
    port: 80
    protocol: TCP

---
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ingress-http
  namespace: test
  annotations:
    kubernetes.io/ingress.class: "traefik"
spec:
  rules:
  - host: test.mydomain.test
    http:
      paths:
      - path: /
        backend:
          serviceName: http
          servicePort: 80

---
kind: Deployment
apiVersion: extensions/v1beta1
metadata:
  name: traefik-ingress-controller
  namespace: traefik
  labels:
    k8s-app: traefik-ingress-controller
spec:
  replicas: 1
  selector:
    matchLabels:
      k8s-app: traefik-ingress-controller
  template:
    metadata:
      labels:
        k8s-app: traefik-ingress-controller
        name: traefik-ingress-controller
    spec:
      serviceAccountName: traefik-ingress-controller
      terminationGracePeriodSeconds: 60
      volumes:
      - name: config
        configMap:
          name: traefik-conf
      containers:
      - image: "traefik:1.7.4"
        name: traefik-ingress-controller
        volumeMounts:
        - mountPath: "/config"
          name: "config"
        ports:
        - containerPort: 80
        args:
        - --api
        - --kubernetes
        - --logLevel=INFO
        - --configfile=/config/traefik.toml
        - --kubernetes.namespaces=test

In versions 1.7.X the backend is shown as red and appears as "Service Unavailable".
With this configuration but image version 1.6.5, there is no problem, traefik correctly route the traffic to my service and reference the two endpoints.
I see a difference in logs that could help.
In 1.6.X :
time="2018-11-13T14:01:38Z" level=info msg="Starting provider *kubernetes.Provider {\"Watch\":true,\"Filename\":\"\",\"Constraints\":[],\"Trace\":false,\"TemplateVersion\":0,\"DebugLogGeneratedTemplate\":false,\"Endpoint\":\"\",\"Token\":\"\",\"CertAuthFilePath\":\"\",\"DisablePassHostHeaders\":false,\"EnablePassTLSCert\":false,\"Namespaces\":[\"test\"],\"LabelSelector\":\"\",\"IngressClass\":\"\"}"

In 1.7.X :
time="2018-11-13T14:28:37Z" level=info msg="Starting provider *kubernetes.Provider {\"Watch\":true,\"Filename\":\"\",\"Constraints\":[],\"Trace\":false,\"TemplateVersion\":0,\"DebugLogGeneratedTemplate\":false,\"Endpoint\":\"\",\"Token\":\"\",\"CertAuthFilePath\":\"\",\"DisablePassHostHeaders\":false,\"EnablePassTLSCert\":false,\"Namespaces\":[\"test\"],\"LabelSelector\":\"\",\"IngressClass\":\"\",\"IngressEndpoint\":null}"

For services managed buy kubernetes i have no issues, only headless service is not working in 1.7.X.
Best regards,
Kévin

Hello @kpichardie .
Many thanks for your interest in the project.
Indeed, there is a regression we are going to fix quickly to implement correctly the K8s endpoint specification.
By waiting the new bugfix version, as a workaround, you can set a service.port.name by using the same name you specified as endpoint.port.name (http in your example):
---
apiVersion: v1
kind: Service
metadata:
  name: http
  namespace: test
spec:
  clusterIP: None
  ports:
  - port: 80
    protocol: TCP
    name: http

Hi @nmengin,
Ok thanks i will check if it's correctly working with port name.
Thanks for quick reply.
Kévin

Hello @kpichardie , after a deeper analyze, I can say that the way to configure the link between the ServicePort and the EndpointPort in Traefik before the version 1.7 was wrong.
By following the Kubernetes specification about Headless services, the workaround I described is definitively the way to configure correctly your service.
Happy to see that it is OK for you know.
I close the issue which is, IMO, solved.

@nmengin are you sure about this? It's working for me on 1.7.4 without needing ServicePort and EndpointPort being the same. For me, the ServicePort is grpc, and EndpointPort is http.
Also on kubectl get endpoints, I get below:
apiVersion: v1
kind: Endpoints
subsets:
- addresses:
  - ip: <IP_ADDRESS>
    nodeName: dev-k8s-node-04
    targetRef:
      kind: Pod
      name: traefik-lb-7fdff4b754-9f2qs
      namespace: kube-system
      resourceVersion: "34662414"
      uid: 8105c261-f7f4-11e8-8cc7-0050569a87bc
  ports:
  - name: http
    port: 80
    protocol: TCP
  - name: https
    port: 443
    protocol: TCP

Here is my service:
apiVersion: v1
kind: Service
spec:
  clusterIP: None
  ports:
  - name: grpc
    port: 3000
    protocol: TCP
    targetPort: grpc
  selector:
    name: my-service
    role: service
  sessionAffinity: None
  type: ClusterIP
status:
  loadBalancer: {}

Lastly, I remember reading months ago that servicePort in ingress definition needs to be grpc for GRPC services? Is that no longer true?
Because I tried renaming it to http, and it still works.


Add 'translate' button to object detail

Is your feature request related to a problem? Please describe.
Currently, the "Translate" button is only available from the Django admin detail view.
Describe the solution you'd like
Object detail view in frontend already have an "Edit" button, we could add the "Translate" button also just below to ease translation (it just avoid a single click but could be worth).
Describe alternatives you've considered
Nothing.

Done in v0.5.1 branch


Incorrect faction colors

Riverwalkers, Shapeshifters, and Ice Maidens are all displaying black text on black bars in the Faction Score Breakdown graphs, while Yetis, Acolytes and Dragonlords are being colored correctly.
Examples:
http://dwitchesden.echternacht.org/analyze/game/hail
http://dwitchesden.echternacht.org/analyze/game/chicago
http://dwitchesden.echternacht.org/analyze/game/Exp11

Fixed Ice Maidens in v1.1.1 (59484bbbe1f64548c156310a7e73c2703af242a0)
Changed Riverwalkers and Shapeshifters to a different color in v1.1.1 (03f8c472c4e35cbcbab6435adbfd28ab9da5a85e)


Batch mode for Postgres fails integration tests

Environment
Liquibase Version:3.10.3
Liquibase Integration & Version: All
Liquibase Extension(s) & Version: NA
Database Vendor & Version:PostgreSQL
Operating System Type & Version:NA
Description
PostgreSQL Integration tests are failing with this changeset
<changeSet id="6" author="molivasdat">
        <loadData file="datafiles/enum-data.csv" relativeToChangelogFile="true" tableName="sample_enum_table">
            <column header="int_col" name="int_col" type="NUMERIC"/>
            <column header="str_col" name="str_col" type="STRING"/>
            <column header="enum_col" name="enum_col" type="OTHER"/>
        </loadData>
    </changeSet>

Steps To Reproduce
Run the PostgreSQLIntegrationTest class on the build and 11 of 28 tests fail
Actual Behavior
Tests fail
Expected/Desired Behavior
All tests pass
Screenshots (if appropriate)
If applicable, add screenshots to help explain your problem.
Additional Context
Add any other context about the problem here.
┆Issue is synchronized with this Jira Bug by Unito

Merged


✨ feat: add fairhub as an app

📝 Changed routes:

/

(view full size)

And 1 other route:

/api/generate

Commit 508772c7a9c367044489e5dcd8d802564c5bd7d3 (https://kalai-b76td1rrq-fairdataihub.vercel.app).