Major revamp of the build process

R: @addyosmani @gauntface
This is a substantial update to the build process, with the following changes:

Moving from gulp wrappers on top of Rollup, babili, and others to directly using Rollup. This fixes #477, sourcemap generation.
No longer including the async-to-generator transpilation, since async/await are natively supported in production Chrome and Firefox. We can turn this back on if we need.
Changing the build process for sw-offline-google-analytics and sw-background-sync-queue to only generate unminimized iife bundles of the individual .js files that they need in order to run their tests, and to generate them all in parallel instead of sequentially.
Adding in an .npmignore file to the directory that hosts the built tests for sw-offline-google-analytics and sw-background-sync-queue to ensure they're not published to npm.

As a result of these changes, we've saved a modest ~364 bytes on the gzip-ed size of swlib.min.js. But the built times should be much quicker across the board—I've seen improvements of around 10 seconds in sw-lib, and up to 40 seconds improvement for sw-background-sync-queue (which was really bad to begin with, due to a long sequential chain of bundled test code).

If the tests pass then go for it. Only one comment on the analytics stuff.
Regarding transpiling, go for it - only concern - older versions of these browsers and edge support.

Adding back async/await, or bundling as umd instead of iife might end up being necessary, but I figured let's start with what will lead to the smallest size to begin with, and see if anyone files issues after launch with use cases that require changes.


Update tutorial example

Correct bracketing in "building the input function" example

Can one of the admins verify this patch?

@tensorflow-jenkins test this please

PR merged. Thanks, @nicholasbutlin


bug: @ionic/react unexpected warning "No IonPage was found to render"

Bug Report
Ionic version:
[x] 4.11.x
Current behavior:
Ionic throws warning "No IonPage was found to render. Make sure you wrap your page with an IonPage component."
Expected behavior:
No warning
Steps to reproduce:

Go to https://codesandbox.io/s/jolly-leaf-lddk1
Navigate in Browser pane to https://lddk1.csb.app/page1
Click button "To Root"
Page 2 opened (https://lddk1.csb.app/page2). In console pane you could see the warning.

Related code:
const App = () => (
  <IonApp>
    <IonReactRouter>
      <IonRouterOutlet>
        <Route exact path="/page1" component={Page1} />
        <Route exact path="/page2" component={Page2} />
        <Redirect exact from="/" to="/page2" />
      </IonRouterOutlet>
    </IonReactRouter>
  </IonApp>
);

const Page1 = ({ history }) => (
  <IonPage>
    <IonContent>

Page 1

      <IonButton onClick={() => history.replace("/")}>To Root</IonButton>
    </IonContent>
  </IonPage>
);

const Page2 = () => (
  <IonPage>
    <IonContent>

Page 2

    </IonContent>
  </IonPage>
);

Same here.
The render function of the page is run, but something prevents Ionic to show it.
├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>

Hi @kodemi,
I believe this would be working now from another fix that got into 4.11.6. Could you try that out and report back here if it didn't help?
Thanks

Hi @elylucas,
Yes, now it works in 4.11.6👍🏼


Add support to add a note when sending an invitation

Add support to add a note when sending an invitation, because improves the success when adding new connections.
Can we support this? Also I can make a pull request if there is a simple way of adding this feature.

Hey Jovan. Is this feature available only to premium accounts?
Anyway, it will need some exploration. Let me know if you you want to take this one

This feature is available on all accounts...


Added logo and Navbar on one page

Added the New Logo on all the pages, the Ar vr page had a navbar missing, added a navbar to that page along with the new logo on the go.

I just tried making it circular but the text in the logo is barely visible if made circular

@akshitagupta15june

Oh ok no issues
I will talk to paulav to make the size big

Thankyou for the great work


Add support for Jupyter notebooks in Ballista

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Jupyter notebooks are a popular tool for interacting with data science and "Big Data" systems and it would be nice if we could add support for this in Ballista.
Describe the solution you'd like
It probably makes sense to support writing Python code in the notebook, so this would depend on having Python bindings available for DataFusion & Ballista (see https://pypi.org/project/datafusion/).
Describe alternatives you've considered
None
Additional context
None

Related to #58


[BUG] Documentation about config_opts accepting an MFA is incorrect?

Describe the bug
Documentation for config_opts says: "This option can either accept an MFA that will return a string of the full path where the YAML configuration file is, or a keyword list with options so that PromEx can generate a config file for you."
Looking at the code though, it seems pretty clear that it only supports a keyword list - not an MFA.
Perhaps I'm overlooking something?
To Reproduce
config :my_app, MyApp.PromEx,
  grafana_agent: [
    config_opts: {SomeModule, :foo, []}
  ]

Result:
** (Mix) Could not start application myapp: MyApp.Application.start(:normal, []) returned an error: shutdown: failed to start child: MyApp.PromEx
    ** (EXIT) an exception was raised:
        ** (FunctionClauseError) no function clause matching in Keyword.get/3
            (elixir 1.13.4) lib/keyword.ex:352: Keyword.get({SomeModule, :foo, []}, :scrape_interval, "15s")

Expected behavior
It starts.
Environment

Elixir version: Elixir 1.13.4
Erlang/OTP version: Erlang/OTP 24

Additional context
fwiw I'm not quite convinced of the usefulness of the MFA option. You end up having to provide a lot of keys that PromEx.Config.extract_opts_for_config/1 sets defaults for.
I think it's probably more useful to specify a custom template when rendering.

That is definitely a miss on my part. It's something I wanted to implement but haven't gotten around to it. Looks like I put the cart before the horse on the docs though. Is this something that you would like to tackle? It shouldn't take very long to implement.

Is this something that you would like to tackle?

I don't think so. We started off by defining our config, assuming the MFA thing would work. The args to MFA essentially duplicate the normal config, but also require adding all the missing keys that PromEx sets by default.
Instead, we found it quite elegant to provide a different template file, as in #159

@patmaddox do you mind either,
A) Fix the documentation
B) Add support for the MFA?

Do I mind if you / someone does it? Not at all :) @akoutmos makes the decisions around here though.

@patmaddox, my apologies if you felt negative emotions from my comment, @akoutmos needs extra hands since he has other priorities and duties, so I am doing my best to support him as much as possible.
Please don't take it personally.


Add support for config files

Adds the support for config file
Changes how the command line arguments are parsed

Closing: #35

Closes: #35


Pressing ctrl+shift+T reopens the algosigner window

If you press ctrl+shift+T on chrome after using the algosigner wallet, it should open the last closed Tab. This instead opens the algosigner wallet extension window, though blank.

I was not able to reproduce this, which browser are you using?
Also, could you please tell me if you were using a Ledger account by any chance.

Steps to replicate:

Go to algosigner-dapp-example
Go to the Tab Asset Create Txn
Perform all the step before Sign
Click on Sign and close the algosigner prompt
Press Ctrl + Shift + T to see the dialog box reappearing but blank.

This out of our control as a browser function, in addition team couldn't reproduce


[Question] Where does yt-dlp get formats from

Checklist

[x ] I'm asking a question
[x ] I've looked through the README and FAQ for similar questions
[x ] I've searched the bugtracker for similar questions including closed ones

Question

I'm curious how the list formats (-F) gets the available resolutions.  Using this show's episode as an example (at this point unlocked to the public):
https://play.history.com/shows/the-secret-of-skinwalker-ranch/season-2/episode-4
When I open it in Chrome developer tools and look at the master.m3u8?xxxx file, the best resolution that's available is 960x540.  Using yt-dlp with -F, it finds a resolution of 1280x720.
Thanks!

It gets it from the API. See AENetworksBaseIE in aenetworks.py

Thanks!  I will check it out


Small refactorings

While writing the report I noticed some bugs and some things that could be improved. This PR contains the modifications that I made following these observations.
Checkers

I noticed that people who define their own checkers could want to report several violations on a single node for the same checker, so I changed the return value of checkNode from Option[Violation] to List[Violation]. To keep it easy to use I defined a method in Violation that converts a Violation to a list containing only this Violation: violation.toSingletonList
In some cases, the fact that BlacklistRules and Features require a PartialFunction to be passed as a constructor argument causes compilation errors (mentioning some premature access). So I modified the PartialFunction into a val that the BlacklistRule or Feature must implement.
I modified the BlacklistChecker so that it reports several violations on the same node if the node violates several rules (IIRC @julienrf asked me to do it but I had forgotten...)

Code transformation

I noticed several bugs that I fixed. One of them was that I had forgotten to consider do-while loops in the transformation (so they were simply left unchanged)...
I added more tests. The code of 5 tests is taken from exercises from the 2020 final exam from EPFL's functional programming class (I cited the source in the tests).
The transformation system now simply rejects programs containing returns

Great work! Then we will need to modify the testing infrastructure to allow multiple violations on the same node.

As discussed with @civp this PR also removes most of the tests in syntactic/src/test, as they are redundant with the ones of the testing infrastructure. I keep only one test that checks the content of PredefFeatures.allDefinedfeatures.


Unable to login after update to v0.12.4

After updating today the app to v0.12.4 (from Google play) I'm unable to login :

I click on the login button in the app
I'm redirected to https://www.openstreetmap.org/oauth/authorize?oauth_callback=http%3A%2F%2Flocalhost%2Fassets%2Fland.html&oauth_token=xxxxxxxxxxxx on my mobile browser (firefox 68.2.1 / android 9.0)
after I grant the authorization I'm redirected to http://localhost/assets/land.html?oauth_token=yyyyyy
I'm not logged in the app

Oups... I released the wrong version...
I fix this blunder.
Thank you !

Updated the app this morning, it works now :-)


PHP Fatal error: Call to a member function getBody()

I've just received the following error in my logs.
The exact error was (no track trace available):
PHP Fatal error: Call to a member function getBody() on a non-object in vendor/guzzle/http/Guzzle/Http/Curl/RequestMediator.php on line 100

The method of interest is:
<?php

    /**
     * Write data to the response body of a request
     *
     * @param resource $curl  Curl handle
     * @param string   $write Data that was received
     *
     * @return int
     */
    public function writeResponseBody($curl, $write)
    {
        if ($this->emitIo) {
            $this->request->dispatch('curl.callback.write', array(
                'request' => $this->request,
                'write'   => $write
            ));
        }

        return $this->request->getResponse()->getBody()->write($write); // line 100
    }

The error does not always happen, so is this a library error or a user error? Note: I'm using the Goutte library (https://github.com/fabpot/goutte/issues) which site on top of Guzzle, so it's possible the error comes from them.
If it helps, here is my Goutte code. I know it's Goutte code, but the fatal error comes from Guzzle.
<?php

    try {
            $proxy = $this->proxyProvider->provideAny(array(
                'disallowed_ports' => 80,
            ));

            if (null !== $proxy) {
                $this->client->getClient()->setConfig(array(
                    'curl.CURLOPT_PROXY'     => $proxy,
                    'curl.CURLOPT_PROXYTYPE' => 'CURLPROXY_HTTP'
                ));
            }

            $userAgentString = $this->userAgentGenerator->generate();
            $referrer = '';

            $this->client->setHeader('User-Agent', $userAgentString);
            $this->client->setHeader('Referer', $referrer);

            $this->client->request('GET', $url);
        } catch (CurlException $e) {
             // ...
        }

        $response = $this->client->getResponse();

        // ...

i goutte has function which the same curl_getinfo in php
Because I want to get all information on website below format
[url] => http://ione.vnexpress.net/sitemap.xml
[content_type] => application/xml; charset=utf-8
[http_code] => 200
[header_size] => 220
[request_size] => 68
[filetime] => -1
[ssl_verify_result] => 0
[redirect_count] => 0
[total_time] => 0.610405
[namelookup_time] => 0.022581
[connect_time] => 0.026514
[pretransfer_time] => 0.026703
[size_upload] => 0
[size_download] => 562190
[speed_download] => 921011
[speed_upload] => 0
[download_content_length] => -1
[upload_content_length] => 0
[starttransfer_time] => 0.516543
[redirect_time] => 0
[redirect_url] =>
[primary_ip] => <IP_ADDRESS>
[certinfo] => Array
(
)

Can you rephrase the question?

I want to get infomation below format
[url] => http://ione.vnexpress.net/sitemap.xml
[content_type] => application/xml; charset=utf-8
[http_code] => 200
[header_size] => 220
[request_size] => 68
[filetime] => -1
[ssl_verify_result] => 0
[redirect_count] => 0
[total_time] => 0.610405
[namelookup_time] => 0.022581
[connect_time] => 0.026514
[pretransfer_time] => 0.026703
[size_upload] => 0
[size_download] => 562190
[speed_download] => 921011
[speed_upload] => 0
[download_content_length] => -1
[upload_content_length] => 0
[starttransfer_time] => 0.516543
[redirect_time] => 0
[redirect_url] =>
[primary_ip] => <IP_ADDRESS>
[certinfo] => Array
(
)
But i don't know how to get it use Goute?
I want to see construct


Is there a way to wait for API response before server will render a page?

Hello!
I found that server isn't waiting for async API response, and sends blank components to front-end.

Hi! I'll have a look at it soon, probably tomorrow.

What do you think about this approach?
bananaoomarang/isomorphic-redux

I'll check it later in the weekend and come back to you. Thanks for the link.

I've checked it. It's a nice solution, I might implement it into this starter kit once I have some time. ;-)

also have the same question

@bodyno I think we could help @janoist1.
Currently I'm working on integration redux-saga in this boilerplate, but I haven't much free time.
Could you implement something like the example that I've posted above?

@kuatro
I'm not so familiar with the universal react.
Please tell me how to call dispatch action at server side.

It looks like I'll have some time in the upcoming weekend, will try to implement an example and do some general updates. ;)

:+1: :+1: :+1:

@janoist1 Please just give me some train of thought
how to call dispatch action at server side

@bodyno I'm not sure what you wanna achieve but guessing you want a point where you can initiate your (async) API request. I chose route onEnter callback as starting point:
import Weather from './containers/WeatherContainer'
import { fetchWeatherData } from './modules/weather'

export default store => ({
  path: 'weather',
  component: Weather,
  onEnter: () => {
    // async get weather data
    store.dispatch(fetchWeatherData())
  }
})`

As you can see I'm working on an async example that runs on server side. I'm not far from getting it done. ;-)

@kuatro if you can show me exactly what needs to be done, I'm personally interested in fixing this and don't mind submitting a PR to make it happen

Hey, @peterpme .
As I understood, when you build an isomorphic React/Redux app, you need to implement your own promise middleware to resolve all API requests on server-side.
I've sent a link above: bananaoomarang/isomorphic-redux

@janoist1 mind closing out this issue and direct folks to #19?


(feat): Distribute describe_objects S3 method

Feature or Bugfix

Feature

Detail

Distribute describe_objects S3 method with executor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
Commit ID: 8f9444a61ecd7e63ffe6fc23b615f8afd218060c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: 8f9444a61ecd7e63ffe6fc23b615f8afd218060c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


No translation when using vertical layout-card

Describe the bug
When using a custom vertical layout-card, weather alerts are not translated.
Default masonry layout:

One of the custom vertical layout:

Steps to reproduce
No response
Screenshots
No response
Card version
v2.4.3
Integration type
Meteoalarm
Installation type
Home Assistant Community Store (HACS)
Card Configuration
type: custom:meteoalarm-card
entities:
  - entity: binary_sensor.meteoalarm_zuid_holland
integration: meteoalarm
hide_when_no_warning: true
scaling_mode: headline_and_scale
override_headline: false

Integration Configuration
[PASTE CONFIGURATION HERE]

Crossreferencing:
https://github.com/thomasloven/lovelace-layout-card/issues/248

This is typically this card, https://github.com/thomasloven/lovelace-layout-card/issues/248 is not relevant. This is intended behaviour that can be controlled by scaling mode

I think you misunderstand. This has nothing to do with scaling but with translating the text into Dutch or English. The translation of the card is used for most layouts but topically not for the custom vertical layout.

I've just checked it on both masonry and vertical layouts and the behaviour is exactly the same. This is for certain intended behaviour caused by card scaling. I won't explain how this work here cause there is extensive documentation in scaling-mode.md.
I can only guess what your configuration is here since you didn't bother to fill up the template but, I can take some educated guesses. Moderate thunderstorm warning is not a headline that is possible to be generated internally by card, it is just not a string. This headline is provided by your meteoalarm integration that doesn't have language selected or, your warnings provider doesn't give Dutch headlines If the first is the case, you can update your configuration.
So indeed that is card scaling.

Provided by integration headline is
Long generated one is

You see different headlines on different widths on the card, again, because scaling-mode.md


Error while importing tensorflow

OS Platform and Distribution : CentOS Linux release 7.5.1804
TensorFlow installed from (source or binary): pip
Python version: 3.7.2
Installed using virtualenv? pip? conda?: pip

I get the following error when I try to import tensorflow:
Traceback (most recent call last):
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "/home/users/pjh/Python-3.7.3/Lib/imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "/home/users/pjh/Python-3.7.3/Lib/imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: /lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by /home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/init.py", line 24, in
from tensorflow.python import pywrap_tensorflow  # pylint: disable=unused-import
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/init.py", line 49, in
from tensorflow.python import pywrap_tensorflow
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow.py", line 74, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "/home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "/home/users/pjh/Python-3.7.3/Lib/imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "/home/users/pjh/Python-3.7.3/Lib/imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: /lib64/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by /home/users/pjh/.local/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so)
Failed to load the native TensorFlow runtime.

I am not the root user in the server.
I installed python in my directory by downloading 'https://www.python.org/ftp/python/3.7.3/Python-3.7.3.tgz'. Next I downloaded tensorflow by 'python3 -m pip install tensorflow --user' (python3 command is linked to the one installed in my directory). Then I executed 'python3' and tried to import tensorflow.
Thank you so much.

This is a duplicate of https://github.com/tensorflow/tensorflow/issues/26826
Either use python 3.6, or you'll need to build TensorFlow from source to use it with python 3.7 and CentOS.

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Error encountered: The directory name is invalid.

Hello,
Below is what I get each time I try to convert my Rocksmith files.  I would really appreciate any help that comes my way.  TIA
[1/8] Opening archive songs.psarc ...
Error encountered:
The directory name is invalid.
[2/8] Opening archive bobmthre_m.psarc ...
Error encountered:
The directory name is invalid.
[3/8] Opening archive elvisusp_m.psarc ...
Error encountered:
The directory name is invalid.
etc

Which paths did you choose in the program for the Rocksmith directory and the output folder? Specifically, have you tried a different save location?

C:\Users\XXXXXXX\Downloads\Rocksmith2014\dlc
C:\Users\ XXXXXXX \Desktop\tabs
I have tried several different save folders and nothing changes.
On Wed, May 27, 2020 at 1:18 PM Holger Frydrych<EMAIL_ADDRESS>wrote:

Which paths did you choose in the program for the Rocksmith directory and
the output folder? Specifically, have you tried a different save location?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fholger/RocksmithToTab/issues/42#issuecomment-634814308,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APWIVUKKQYDW4FQVDQDYJW3RTVDPBANCNFSM4NIT7UBA
.

Here is the actual directory that Rocksmith is in:
C:\Program Files (x86)\Steam\steamapps\common\Rocksmith2014
sorry...any ideas?
On Wed, May 27, 2020 at 10:18 PM Sir Midi<EMAIL_ADDRESS>wrote:

C:\Users\XXXXXXX\Downloads\Rocksmith2014\dlc
C:\Users\ XXXXXXX \Desktop\tabs
I have tried several different save folders and nothing changes.
On Wed, May 27, 2020 at 1:18 PM Holger Frydrych<EMAIL_ADDRESS>wrote:

Which paths did you choose in the program for the Rocksmith directory and
the output folder? Specifically, have you tried a different save location?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fholger/RocksmithToTab/issues/42#issuecomment-634814308,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APWIVUKKQYDW4FQVDQDYJW3RTVDPBANCNFSM4NIT7UBA
.

Not really, I'm afraid. You could try a path outside your user directory, e.g. C:\temp\RocksmithTabs (you might need to create C:\temp first). Other than that, the error doesn't ring a bell, and it's been years since I've touched the code :(

hi ihave the same problem,  i have a file with just the songs i want to convert and i get the same message


Adjust tile rank for stations

Adjust tile rank for stations. This:

Breaks out the different types of routes going through a station.
Calculates a numeric score for the station prioritising stations which have mainline rail, subway and light rail. A bonus is awarded for being an interchange between mainline rail and subway or light rail.
Sorts on this new score instead of the number of routes.
Adds a root_relation_id for linking together features in the same public transport or site relation.

Part of this is now that area is no longer a meaningful metric to be deciding at what zoom stations come in. For now, they're queried from the database starting at zoom 10, and then dropped by the last stages of the post-processor after having been scored. This (hopefully) will mean that only the important stations show for crowded, metropolitan areas but also that single-line mainline stations in rural areas will also be available at low zooms. It remains to be seen what the impact of pulling so many stations at low zooms will be - but stations are fairly rare features...
Connects to #506.
@rmarianski could you review, please?

Refs #590 as well for the root relation ID addition.

:+1:
The relation walk sounds expensive. I take it we actually need to do that to get the best results here though. Should we consider pre-calculating this with a trigger? Or are the actual number of stations relatively low so we won't feel the impact here?

The relation walk sounds expensive. I take it we actually need to do that to get the best results here though. Should we consider pre-calculating this with a trigger? Or are the actual number of stations relatively low so we won't feel the impact here?

I'm hoping for the number of stations is relatively low. But I can do a whole station (King's X) in 28ms, and every station in London (414 of them) in 4632ms... So that makes me hope that it's not as expensive as it might appear - I think there generally aren't that many steps in the recursion.
If we notice a significant slow-down from this, then we should consider storing the result in a column and updating using a trigger. The difficulty there will be that the trigger will also need to fire if any of the relations found during the sweep changes, which probably means having another column for "dependencies" or something like that.

The difficulty there will be that the trigger will also need to fire if any of the relations found during the sweep changes, which probably means having another column for "dependencies" or something like that.

Ah good point, I hadn't considered that. Sounds good the way it is.


Select popover is displayed behind of react-native-community/react-native-modal

💬 Question
I'm using react-native-community/react-native-modal to display modal screens on top of views.
If you use @ui-kitten/components/Select inside a react-native-community/react-native-modal, popover list of SelectItems are rendered behind the modal so it is not selectable but visible if you make the modal transparent. I couldn't figure out how to add styles to popover of the select so I can give it a zIndex: 9999 maybe it would work.
When I use @ui-kitten/components/Modal I have no problem. But I needed animations that's why I'm using react-native-community/react-native-modal
Maybe this is a bug? Help please 🙏
UI Kitten and Eva version

Package
Version

@eva-design/eva
^2.0.0

@ui-kitten/components
~5.0.0

even i have the same bug. But it works fine on uikittens Modal. But again it was not working on Oneplus 7 devices(even with uikitten modal) with OS android 10, it works fine on android 9 and below. stuck with this issue for 3 days. @olckara did you find any solution?

Is there anyone have find proper solution ? I am also on same problem.

@artyorsh, could you link the non-duplicate issue for reference?

@artyorsh, could you link the non-duplicate issue for reference?

For me, the dropdown list is behind the modal screen
<Stack.Screen name="Edit" component={EditScreen} options={{ presentation: 'modal' }} />

In this modal screen, I have a form with a Select component. When I press the Select component, nothing appears. But when I drag the modal screen down, the select dropdown is behind.
It'd been fine before I replaced the @react-navigation/stack with the @react-navigation/native-stack.


Create additional info blocks

You can make your resume less official by adding more entertaining info, like your hobbies and interest, or what do you like, some interactive content or joke, easter egg, etc.

Just a comment


getMetadata() does not work when using npm workspaces

Describe the Bug
Writing component builder to /home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/apps/aceik-demo/src/temp/componentBuilder.ts
Error: ENOENT: no such file or directory, scandir 'node_modules'
    at Object.readdirSync (node:fs:1525:3)
    at getMetadata (/home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/node_modules/@sitecore-jss/sitecore-jss-dev-tools/dist/cjs/templating/metadata.js:15:31)
    at generateMetadata (/home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/apps/aceik-demo/scripts/generate-metadata.ts:13:41)
    at Object.<anonymous> (/home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/apps/aceik-demo/scripts/generate-metadata.ts:10:1)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at Module.m._compile (/home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/node_modules/ts-node/src/index.ts:1618:23)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Object.require.extensions.<computed> [as .ts] (/home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/node_modules/ts-node/src/index.ts:1621:12)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Function.Module._load (node:internal/modules/cjs/loader:1019:12) {
  errno: -2,
  syscall: 'scandir',
  code: 'ENOENT',
  path: 'node_modules'
}
npm error Lifecycle script `bootstrap` failed with error:
npm error Error: command failed
npm error   in workspace<EMAIL_ADDRESS>npm error   at location: /home/runner/work/aceik-sandpit-xmc/aceik-sandpit-xmc/src/rendering/apps/aceik-demo
Error: Process completed with exit code 1.

To Reproduce

npx create-sitecore-jss nextjs,nextjs-sxa,nextjs-multisite,nextjs-xmcloud
Configure the structure into an npm workspace per https://docs.npmjs.com/cli/v10/using-npm/workspaces then run npm install so that the node_modules folder doesn't exist in the same directory as the app, but is instead in a parent folder
npm run build

Expected Behavior
Build success
Possible Fix
Update https://github.com/Sitecore/jss/blob/8c23ac3af2341d0115268349581891fd9d049ebd/packages/sitecore-jss-dev-tools/src/templating/metadata.ts to have better error handling
Provide environment information
Sitecore Version: XM Cloud
JSS Version: 22.0.0
Browser Name and version: Chrome latest
Operating System and version (desktop or mobile): Windows 11
Link to your project (if available): n/a

@mg-aceik Thank you for submitting this ticket! I've added a ticket containing all the details to our internal backlog for thorough review

Hey @mg-aceik! This issue has been fixed and should be part of our next release. thanks again for submitting :)

Hey @mg-aceik! This issue has been fixed and should be part of our next release. thanks again for submitting :)


Game ended for unknown reason

There are still at least two more moves remaining.
There is still lots of time left.
Game ended anyways.
https://user-images.githubusercontent.com/1248159/188393736-00b2d6f7-7b21-4e45-87e4-1774ac459b82.mp4

Thanks for reporting the bug. It should be fixed with this PR:
https://github.com/avcdsld/pepe-crush/pull/20


TypeScript type declaration file

If you want I can write a TypeScript type declaration file for this package so that TS developers can utilise the type-checking feature of the language as they use this package. Let me know if you are interested.

That'd be great, thank you so much!

@geopic feel free to submit a PR when you’re ready

I'll get started on it soon :smile:


Resin-wifi-connect executable

I was able to run this a few days ago, but now I cannot find the resin-wifi-connect executable in the top level directory? The "start" script gives a file does not exist error

I see now that the final executable is downloaded via curl in the Dockerfile. What is the best way to add this project to an existing project, because submodules seem to not work that well with Docker (or I don't know how)


License seems to be missing

Hi @peter-evans ,
thank you for this nice template!
Would you mind adding a LICENSE file?
That would help adoption in certain cases.
In case there is a license mentioned and I've not seen it, I apologize and am happy to take any hint as where to find it.
Thank you,
Ole

Hi @g-io
I've add a LICENSE file. Hope that helps.


Bump gitsign to v0.8.0

Closing in favor of https://github.com/chainguard-dev/actions/pull/353

Be the


possible_bit_flips source_register is not documented in schema

This crash report:
https://crash-stats.mozilla.org/report/index/8ae4e0f4-bdfc-4eaf-a11c-9e9750230630#tab-rawdump
was processed with minidump-stackwalk 0.16.0 (2023-04-27 v0.16.0) and has this in the stackwalker output:
"possible_bit_flips": [
    {
        "address": "0x00007ffdaf60bf90",
        "confidence": 0.625,
        "details": {
            "is_null": false,
            "nearby_registers": 1,
            "poison_registers": false,
            "was_low": false,
            "was_non_canonical": false
        },
        "source_register": null
    },
...

The source_register isn't documented in the schema here:
https://github.com/rust-minidump/rust-minidump/blob/main/minidump-processor/json-schema.md
What does this field hold?

It's the hardware register which contained the pointer. It's either empty (which means it's the crash address) or it's a string like rax, ecx, r12, etc... @afranchuk can you add this information to the schema please?

I hadn't intentionally added that to the output there (I just added it to the struct which is serialized); it's used in human-friendly CLI output. But I guess it doesn't hurt to include it in the JSON output.

Thank you!


[LLAMA] KV Cache Injection

Requires most up-to-date transformers release
Missing code which was used for updating slice nodes relevant to position_ids

This looks great @dsikka . We need to figure out the fix for the positions and then we are good to go!


ota-requestor-app - initial set of changes of development branch

Problem
Submitting a work-in-progress ota-requestor-app so that others may begin to pick up development.
NOTE - this will not build successfully right now. See examples/ota-requestor-app/linux/README.md for the current state of this application.
Change overview
Add new example app ota-requestor-app.
Testing
N/A

NOTE: Approved since OTA development team (@carol-apple , @selissia , @kkasperczyk-no ?) seemed to want this in.
The part in the readme that says 'code does not yet compile' is worrysome and wondering if it would maybe be better to not check in code that does not compile and instead have work proceed on a separate branch. My checkmark is more of a 'I trust OTA team to do the right thing'.

NOTE: Approved since OTA development team (@carol-apple , @selissia , @kkasperczyk-no ?) seemed to want this in.
The part in the readme that says 'code does not yet compile' is worrysome and wondering if it would maybe be better to not check in code that does not compile and instead have work proceed on a separate branch. My checkmark is more of a 'I trust OTA team to do the right thing'.

I was asked by @woody-apple to submit whatever I currently had for the ota-requestor-app so that Carol and Sergei could get started helping out.
In any case, I am preparing a follow-up PR that will get this to build and run some minimal functionality ASAP.


renaming chapman mechanism and adding readme

Closes #368

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.89%. Comparing base (85232c5) to head (df5422f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   92.89%   92.89%
=======================================
  Files          49       49
  Lines        3477     3477
=======================================
  Hits         3230     3230
  Misses        247      247

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Introduce dynamic local PV provisioners to manage diagnosis data

Diagnosis data are currently stored in hostpath and the management is painful. A cloud native solution of dynamic local PV provisioners is required to manage diagnosis data including profilers, heapdumps, coredumps, etc. Cloud storage compatibility and scalability should come into consideration. OpenEBS is one of suggested options.

Some features of Storage that I think are very useful:

Supports uploading of multiple files
Support file md5 verification to avoid repeated uploads


Live/Delegate Event Handler not working with focus/blur

https://jsfiddle.net/nu1zentc/11/
Console output :
focus input FocusEvent
click input MouseEvent
delegate click input MouseEvent
blur input FocusEvent

Expected Console output :
focus input FocusEvent
> delegate focus input FocusEvent
click input MouseEvent
delegate click input MouseEvent
blur input FocusEvent
> delegate blur input FocusEvent

This is due to the nature of these events (focus/blur) and how they bubble. Use capture to assign live events for focus/blur
$(document).on('focus', 'input', handler, true)

Would it be possible to auto capture such events, so the Live/Delegate API would match with jQuery's ?

Thanks for the fast reply answer by the way !


[SMALLFIX]Explicit type argument can be replaced in alluxio.client.file.RetryHandlingFileSystemMasterClient#listStatus #138

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17731/
Test PASSed.


add missing comma in font-face declaration

Oops, my fault. Seems the comma was eaten by my keyboard.

Then close the pr?

@tomscholz This is a pull request against the original repository.
A PR is closed after it is merged against the repository where the PR is filed. Closing the PR makes no sense. This PR fixes another commit of me where I removed the deprecated font files and added the missing local in the font-face and forgot to add one comma, so one of the font-face rules is wrong ;-)
So until now the PR should be open until it is merged into the upstream branch ;-)
The PR comes from my own fork where I have an extra branch for the changes (this is the recommended way, make feature / bugfix / patch branches and merge them with the other branches).
So nothing wrong here on my side, just waiting to get the PR merged. The text is the description of my commit and PR so they know that I missed one comma ;-)

@tomscholz
The official docmentation of git and the GitHub guides and cheatsheets are probably helpful to understand the basics and available workflows (GitLab Flow, GitHub Flow, Gitflow and more)
https://git-scm.com/docs/git-request-pull

Some guides: https://guides.github.com/
https://guides.github.com/activities/forking/#making-a-pull-request

@DanielRuf I know how to use git ;)

I thought the problem had solved it self.

Ah ok. It was just a bittle late and dark when I made the edits yesterday and this little comma wanted to play hide and seek :D https://github.com/Dogfalo/materialize/pull/4432/files


Floating windows are indiscernible

The floating windows from coc.nvim have the same background color as the main window, and no border, which makes them very difficult to read. It looks like #54 was an attempt to change that, but it was discarded. The comment in that PR mentions the "border option", however, when I make the following change, I see no difference. It looks like the floating windows have no border at all.
- hi.FloatBorder = { guifg = M.colors.base05, guibg = M.colors.base00, gui = nil, guisp = nil }
+ hi.FloatBorder = { guifg = M.colors.base05, guibg = M.colors.base01, gui = nil, guisp = nil }

Is there a reason to not change the value of NormalFloat, so that the floating window background is different from the main window? If so, what would be the best way to have the floating window stand out a bit more?

Borders would be what I recommend.

You can override that highlight group in your own config if you want to change it.

@RRethy thank you for the tip. I am not very familiar with Vim UI elements and color scheme stuff. Would you mind giving an example of what I should do to enable those borders in my config?

I found out that you can add a border to coc.nvim floating windows by adding "diagnostic.floatConfig.border": true to coc.nvim config file (more info in coc-config-float section of coc.nvim docs). Look a little better now.


Fix wrong path size for SetProperty

fixes #234

Hi, @mathetake. Thank you for your quick response and helping the project improve.
I have a question, when is the next release of this project planned?

@bzp2010 I just released a new tag v0.16.0: https://github.com/tetratelabs/proxy-wasm-go-sdk/releases/tag/v0.16.0 enjoy!

@mathetake Thanks!! XD


Add image with cruise-control-metrics-reporter jar already downloaded

Should reduce the risk of failed Kafka inits in https://github.com/Yolean/kubernetes-kafka/pull/218

Merged manually


Delete Images Asyncronously

Why?

When deleting an image, 4 HTTP requests are made to AWS to destroy hosted images.
This is slow

What Changed?

Move image deletion into a background worker.

Coverage remained the same at 57.272% when pulling 03bac0070b4b5b5cd9ac8882e2b784a952fdfb6a on RickCarlino:n_plus_one into 2d9f1044bd03129e252aa71a1ab8166c145f98ee on FarmBot:master.


bug:Sort  By not working properly

Describe the bug
Sort Function is not working while it is on all it show all data but when i selecting other like web3 or webdev and other rather than All They are not working
Screenshots or GIFs

Info (please complete the following information):

Browser [Chrome]
Version [131.0.6778.139]

Can you please elaborate the problem? As it is working completely fine on my machine.

Screencast From 2024-12-26 15-44-12.webm
Yo can check this Screen Cast


⚠ Bofrost.lu has degraded performance

In 9b0d8da, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1872 ms

Resolved: Bofrost.lu performance has improved in 2240b6a after 19 minutes.


implemented view for workflow job templates survey

Added a quick bug fix / implementations for the workflow job templates survey view
Added ability to submit workflow job template via api

I'm getting this on survey with text field

also I think we should show default values. In the screenshot, multi select doesn't show any default options, same with text input? @resoluteCoder wdyt

@jerabekjiri  Great catches here. I fixed both issues. The last one was due to a merge conflict gone wrong :sweat_smile:

Old UI has this question icon with tooltip description, should we add this too? wdyt @resoluteCoder


Feature/web3auth

Changes proposed in this PR:

Web3Auth provides seamless login experience for non-native web3 users and provisions a wallet address for them
Integrating Web3Auth involves --essentially-- ducktyping a new interface to match the Web3.tsx interface
Then pointing all references to the useWeb3() function to the new useWeb3Auth() function
Using the default modal setup from Web3Auth

Sorry! This was for an ethdenver event, didn't mean to open a pr here


fix: Optimistically disable the distance rate on removal

Details
This PR disables the distance rate when it's removed offline.
Fixed Issues
$ https://github.com/Expensify/App/issues/44154
PROPOSAL: https://github.com/Expensify/App/issues/44154#issuecomment-2215906769
Tests
Same as QA
Offline tests
Same as QA
QA Steps
Precondition:
Workspace has a few distance rates

Go to workspace settings > Distance rates
Go offline
Delete one of the distance rates
Verify it's marked as disabled, greyed out, and crossed
Go to workspace chat
Start the "submit distance expense" flow with the mentioned workspace
Click the "Rate" field
Verify the newly deleted rate is absent from the list

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/12595293/ca70d5a7-2125-4815-ab59-ac4b0755aad7

Android: mWeb Chrome
https://github.com/Expensify/App/assets/12595293/c98765eb-1e8b-4c27-9a84-c6dc7198d9c0

iOS: Native
https://github.com/Expensify/App/assets/12595293/e083fd10-7114-4b9b-ad4f-43f8a26b3313

iOS: mWeb Safari
https://github.com/Expensify/App/assets/12595293/6aeddf34-0060-404d-a7e4-0d01f5a71ac3

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/12595293/90e22d07-6950-4492-aa4a-aa3e41f9915a

MacOS: Desktop
https://github.com/Expensify/App/assets/12595293/1326e545-413c-4cf1-8529-f6f8a7aa88a0

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.9-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Make it possible to select file from jump list

Hi. I had this idea that I would like to use Command-T's power to open recent files so I hacked this functionality in. I would like to hear from you if this is something that you will consider including into main repo.

Interesting idea. Is this very different from the existing buffer finder? (I am guessing the main difference is that the jump list can contain files whose buffers have been deleted, or even files you opened in a prior vim session if you have ' in your 'vim info' option.)

Exactly - I'm using it to open files from prior vim sessions. My jump list usually contains most of the files I'm currently working on so it's faster for me than searching whole repository when I want to open file.
PS: Right now I'm also using buffer finder, but I'll probably try to use this jump finder instead.

So after 1 day of heavy use I'm probably going to create something like CommandTRecentFiles that will merge CommandTBuffers and CommandTJumps functionality. What do you think about that? :)

Sounds like a reasonable idea.

I've merged this in, so going to close the pull request. I'll be pushing it shortly, I've just spotted some opportunities to eliminate some duplication which I want to do first.
Thanks for the patch!


Several improvements to validation plot

This update includes the following changes to the validation plot:

Text font changed to Helvetica
Font size in the tooltips, axis labels and residue codes is proportional to plot dimensions and resizes with screen. At the moment it is set to fit ~40 bars in the horizontal dimension and ~60 characters in the available vertical space.
Fixed abnormal density correlation values higher than 1
Zoomed out default scale to include ~40 bars instead of 20
If a chain without sequence data (such as ligands) is chosen, gracefully exit
If molecule is deleted, gracefully remove plot

Also some changes to the ramachandran plot:

If the chosen model is deleted, the plot is removed
Fix issue where after last code update the plot was no longer updating upon changes to the molecule

Now this also fixes a bug where if there are multiple models updated, the ramachandran plot would only update based on changes to the first model.


Fix DHxparams handling in dhparams app

dhparams correctly handles X9.42 params in PEM format. However it fails
to correctly processes them when reading/writing DER format.
There also seems to be some missing macros in dh.h - now added.
Fixes #3102. This is for master/1.1.0 - there will be a separate PR for the 1.0.2 version.

Updated commit pushed with requested fix.

Pushed. Thanks.


passing osquery configuration to launcher

Moving from code review in #1582
The current implementation of the launcher is somewhat opinionated about osquery config, so when the configuration endpoint was added in https://github.com/kolide/fleet/pull/1544/files#diff-57894187d53a170dbc47ebddb3139466R54 the following change was made:
	// Launcher manages plugins so remove them from configuration if they exist.
	for _, optionName := range []string{"distributed_plugin", "logger_plugin"} {
		if _, ok := config.Options[optionName]; ok {
			delete(config.Options, optionName)
		}
	}

Is it necessary to remove those options? Especially if the user wants to configure multiple logger_plugins.
// cc @marpaia @zwass

The reason why this is here is because the default configuration options in fleet specify that the tls logger and distributed plugins should be used. This is problematic for the launcher because obviously the launcher should continue to use the kolide_grpc plugins, not tls. This was added as a quick fix, but it is obviously not a sustainable solution to this problem.


Improves performance of the getResolveParamsAsExp method

resubmit of #1046.
Due to the way for loops are implemented in php, the count function will run every iteration of the loop. Therefore, moving the count to a variable, calculated before the start of the loop, improves performance (less function calls).

I'm not quite sure if it makes sense to make micro-optimizations in that area
(improvement of 0,5 ms on 10k iterations), but I'll merge this anyways.


Map Symbol labels

The Map Symbols/Symbol Labels on/off toggle controls the label. The label consists of either the spot ID or the measurement dip. It would be useful to have a finer control for toggling, so one could select spot ID, dip, or maybe even the measured plunge.
A subheading under the symbol labels could control this toggle on/off.
v1.20.1

This could be a good enhancement.  Moderate priority.


Are there any First PR issues?

Hello all, I was recommended to hoodie as a good place to start with contributing to open source projects.  Can someone direct me towards an issue that I can tackle?

Welcome @lucask42 👋
We don’t currently have any open I’m afraid. You can watch the https://github.com/hoodiehq/camp repository to get notified about new issues ready for taking. I plan to prepare a few myself this weekend. I’d be happy to ping you in this issue, too, if you prefer.
Is there anything specific you would like to contribute? We have code, design, documentation and editorial contributors, and also a fundraiser on Open Collective

Thanks for the welcome 👋 I'm most interested in code and design.  I'll gladly help with docs, as well.
I've watched the /camp repository and I'll check in early next week.  Cheers

Also, is there a better way for me to ask questions than creating a new issue?  Please pardon my ignorance

don’t worry, creating an issue is perfectly fine :) Maybe the best way is to ping us in our chat.
I think I can close this issue now? Feel free to keep commenting if you still have questions

I created a small docs issue here if you are interested: https://github.com/hoodiehq/camp/issues/122


importPk button is now primary

importPk button is now primary so selector should be importButton: `${importAccountSelector} .btn-primary`

<EMAIL_ADDRESS>has been released which includes metamask@10+ update solving this issue. Please reopen if not, thanks!
cc @fandrupaw


Show Image pull log

When starting the container, show the log details of pulling image data and starting container.

You mean just print into STDOUT, or have an method on the container to get the log?

By default, I would like print the pulling image and starting container in console, also provide customization with a method to accept custom logger impl.


fixed issue causing cleanup function to fail due to .serverless folde…

…r already exists
from now, move will only move the output of the build instead of the entire folder which is safer

didn't see https://github.com/elastic-coders/serverless-webpack/pull/36 so i closed the PR


feat: upgrade sketches library to 6.1.1

Upgrade DataSketches library to 6.1.1

@Gelerion hey.. Could you help us merge this? Thanks!


Profile page - Add ability to edit and delete notes

Split out as an enhancement to https://github.com/studentinsights/studentinsights/issues/5.
Design should reflect that these are not the primary user interactions, and should require some kind of user confirmation to delete anything.  On the server-side, we could use an append-only log of delete and update actions (in contrast to updating the note records in-place), and merge them at read time since the volume of these changes is expected to be so low.  This is probably most beneficial for deleting, since it keep the audit trail.  As a general user experience and data provenance goal, using an audit trail with recovery can minimize the "confirmation checks" we need to require of users, since users can recover easily and quickly.
For now, we can restrict delete and edit capabilities to admin users, but as part of productionizing this we should test that with school partners.

@kbweaver Thanks for chatting this out in person, and for the great questions!
To capture what we talked about:

The main scenario for editing is that a user records a note in an SST meeting, and then notices a typo mistake and wants to fix it.  Or they are reviewing a student profile and then notice a typo someone else made and they want to fix it.
Users in schools (principals in particular) care about maintaining the integrity of the data, and guarding against any mistakes that someone might make that could lead to losing data.  One approach to handling this is to create authorization rules, that restrict which users are able to edit and delete data.  Another approach is to record more history about each change, so we (or end users) can recover if something gets deleted that shouldn't be deleted.  I think for this project we should default towards recording everything and keeping access rules open for everyone in the school.
For approaches to recording the full history of changes, I'd suggest bias towards a simpler solution over one that's more efficient or generalizable to other cases.  The specifics of what this looks like in the database are a little different for the edit and delete cases, and treating them separately is cool.

To tackle this, you could start with what the database tables and columns would look like to support this, or what the user experience would look like, whatever you prefer.  If it's helpful to write up quick bullet points of what your plan is, I'm happy to review that too.
Thanks for your help! :smile:

Thanks @kevinrobinson !
We considered a few options for tracking edits.

Bring in a third-party library like Paper Trail or Audited. This would be very generalized and powerful at the cost of maintaining another dependency. @kevinrobinson and @alexsoble didn't anticipate a need for this type of auditing beyond event notes and services, so the business case doesn't seem compelling enough to justify the cost.
Maintain a separate event_note_revisions table that points back to event_notes. We could keep the most recent revision in event_notes and only stash old versions in event_note_revisions when edits are made. Could be done without a data migration.
Keep all revisions in the event_notes table, identified by a foreign key back to the original note (something like event_notes.parent_event_note_id). To optimize for reading, we could identify the most recent version with another indexed boolean column. This would likely require a data migration.

I'm leaning towards the second option since it seems the most lightweight and backwards-compatible with existing read and insert operations, and only requires some additional overhead on edit.

@kbweaver This is great summary of the options and tradeoffs involved!  I think going forward with either 2 or 3 sounds great.  One other benefit of 3 is that there is only one source of truth (while 2 has to double-write).
If 2 seems like the better option to you since it better supports making incremental changes then I'd say go for it!  Let me know if there's anything else I can do to help.

And thanks again for your help on this!  👍   This is a great example of how to communicate about the different tradeoffs in various solutions, and might be good to add a link on the readme showing the example when this is shipped.

Attended today's Student Support Team meeting at the Healey school to observe how they used Student Insights. This issue came up as the staff member taking notes made an error and wanted to delete or correct the previous notes.
The staff I spoke with (two principals and the note-taker) said that they would be alright with functionality which only let them delete a note and write a new note in its place, instead of truly revising it. In terms of authorization, one principal said that she would want the ability to delete notes created by staff in case the notes contained language that contained bias or inaccurate information about a student. This would be in addition to staff members being able to delete notes they added themselves.

Spoke with @kevinrobinson , and we're okay making the simplifying assumption that student-level authorization will be good enough for event note-level authorization (i.e., assume that if an educator has permission to view a student, they have permission to modify notes about that student). If this assumption changes in the future it shouldn't be too difficult to add a second layer of authorization.

Before closing this, we should also address some concerns around HTML sanitization that @kevinrobinson brought up. Perhaps it would make more sense to take the resizing (textarea approach).

Closing this because notes are now editable. Building functionality for deleting notes is another conversation but I haven't heard it as a high-priority ask. If we want to talk HTML sanitization (good topic IHMO) we should make a new issue.


Freenect2 Support

Support for Microsoft Kinect v2 IR

Is the Kinect implemented as a V4L camera device? (does it show up in v4l2-ctl --list-devices?)

No,
it responds with
Failed to open /dev/video0: No such file or directory

I have libreenect2 installed and am able to access the various streams when using the premade examples that come with the program.
The kinect's video camera is also not recognised as a video device so I am also unable to use it as a webcam for my pc.

In that case Kinect support will have to be written as a serperate recorder. I'm not going to be actively working on this, but if someone wants to implement it i will merge it.


Migrate unit tests to use testtapper

The current unit tests use tape, which is not ideal - the unit tests should be migrated to use the standard test framework and qxl.testtapper

@cboulanger @oetiker although we talked about this on gitter, please can you clarify - does the current test framework support node?  I vaguely recall that it was "planned" only?
The tape based unit tests in qx currently are not browser based, so im wondering how they would fit in with qxl.testtapper

The qooxdoo unit tests do not support a async tests yet and isn’t very useful for node yet. But Tobi is working on it , I think ....

https://github.com/qooxdoo/qxl.testtapper/pull/7 😄

Done.


chore: Remove link locale

@nschonni : Thanks for your contribution! The author(s) have been notified to review your proposed change. @davib

Link-locale removal verified.


fix: Flaky Dashboard Layout Test on Logout

🍰 Pullrequest
The test if the logout query is called in the dashboard layout is flaky. I will rerun this PR a lot to see if it is still flaky.
Issues

fixes #995 (hopefully)

Runs executed: 1


Modify event

I suggest Maintain Event Class separately

This separation makes code more suitable for object-oriented.
This is more efficient way to maintain and expand code for new webhook event
And modify features in each class efficiently.

With this separation we can clarify what we have to do for a new Event class from the facebook.
Only 3 steps are required

Add new event class.
Add new event handler.
Add new logic in event_parser & handle_webhook
+ test code

Here is an example of adding a new class.

target class: messaging_game_plays
reference: link

step1: Add new event class for messaging_game_plays. --> GamePlayEvent
step2: Add a event handler for the GamePlayEvent. --> handle_game_play
step3: Add elif for the game_play handler. --> in event_parser & in hadle_webhook

Coverage increased (+2.8%) to 92.458% when pulling c4e70902cb5e095d12dad14140012b420bedb951 on HwangWonYo:modify_event into 4209c19d9a9fa073a82c0ff6902d6a939f94b743 on conbus:master.

Coverage increased (+2.8%) to 92.458% when pulling c4e70902cb5e095d12dad14140012b420bedb951 on HwangWonYo:modify_event into 4209c19d9a9fa073a82c0ff6902d6a939f94b743 on conbus:master.


Build errors with Bullet physics engine Static Library

Windows 64bit - Godot version: 3.0 alpha
I've implemented Bullet physics engine, but now that I've registered the BulletPhysicsServer class using the register_Bullet_types class:
void register_Bullet_types() {
    ClassDB::register_class<BulletPhysicsServer>();
}

I get a building error, that is caused (I think) to the bad configuration of SCsub file.
The file system structure is that:
godot
├── modules
│   └── Bullet
│       └── SCsub
│       └── some_file.h
│       └── some_file.cpp
└── thirdparty
    └── Bullet
        ├── include
        │     └── ALL_HEADERS.h
        └── Win64
              └── lib
                   └── ALL_LIBRARIES.lib

The SCsub file is that:
#!/usr/bin/env python

Import('env')

thirdparty_dir = "#thirdparty/Bullet/"
thirdparty_lib = thirdparty_dir + "Win64/"

env_Bullet = env.Clone()

thirdparty_sources = [
        "lib/Bullet2FileLoader.lib",
        "lib/Bullet3Collision.lib",
        "lib/Bullet3Common.lib",
        "lib/Bullet3Dynamics.lib",
        "lib/Bullet3Geometry.lib",
        "lib/Bullet3OpenCL_clew.lib",
        "lib/BulletCollision.lib",
        "lib/BulletDynamics.lib",
        "lib/BulletInverseDynamics.lib",
        "lib/BulletSoftBody.lib",
        "lib/LinearMath.lib"
    ]
thirdparty_sources = [thirdparty_lib + file for file in thirdparty_sources]
env_Bullet.StaticLibrary(target = 'Bullet', source = thirdparty_sources )

env_Bullet.Append(CPPPATH=[thirdparty_dir + "/include/"])

env_Bullet.add_source_files(env.modules_sources, "*.cpp")

Here there is the Building error:
[...]
Generic6DOFJointBullet.cpp
GodotCollisionDispatcher.cpp
D:\WorkSpace\GitHubProjects\godot\thirdparty\Bullet\include\bullet/BulletDynamics/ConstraintSolver/btSolverConstraint.h(20): fatal error C1083: Cannot open include file: 'LinearMath/btVector3.h': No such file or directory
d:\workspace\githubprojects\godot\thirdparty\bullet\include\bullet\bulletcollision\collisiondispatch\btCollisionObject.h(19): fatal error C1083: Cannot open include file: 'LinearMath/btTransform.h': No such file or directory
D:\WorkSpace\GitHubProjects\godot\thirdparty\Bullet\include\bullet/BulletDynamics/ConstraintSolver/btSolverConstraint.h(20): fatal error C1083: Cannot open include file: 'LinearMath/btVector3.h': No such file or directory
scons: *** [modules\Bullet\ConeTwistJointBullet.windows.tools.64.obj] Error 2
scons: *** [modules\Bullet\AreaBullet.windows.tools.64.obj] Error 2
scons: *** [modules\Bullet\Generic6DOFJointBullet.windows.tools.64.obj] Error 2
D:\WorkSpace\GitHubProjects\godot\thirdparty\Bullet\include\bullet/BulletDynamics/ConstraintSolver/btSolverConstraint.h(20): fatal error C1083: Cannot open include file: 'LinearMath/btVector3.h': No such file or directory
scons: *** [modules\Bullet\BodyBullet.windows.tools.64.obj] Error 2
D:\WorkSpace\GitHubProjects\godot\thirdparty\Bullet\include\bullet/BulletDynamics/ConstraintSolver/btSolverConstraint.h(20): fatal error C1083: Cannot open include file: 'LinearMath/btVector3.h': No such file or directory
scons: *** [modules\Bullet\BulletPhysicsServer.windows.tools.64.obj] Error 2
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\exception(359): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\exception(359): warning C4577: 'noexcept' used with no exception handling mode specified; termination on exception is not guaranteed. Specify /EHsc
scons: building terminated because of errors.
19:08:16: The process "C:\Python27\scons.bat" exited with code 2.
Error while building/deploying project godot (kit: Desktop)
The kit Desktop has configuration issues which might be the root cause for this problem.
When executing step "Custom Process Step"
19:08:16: Elapsed time: 00:06.

As you can see I'm including the Bullets generated headers as a normal cpp files: env_Bullet.Append(CPPPATH=[thirdparty_dir + "/include/"]).
The build process fail due to this problem because the path inside the Bullets headers is not correct, since (for godot) the correct is bullet/LinearMath/btVector3.h and not LinearMath/btVector3.h.
So what is the right way of include a static Library using scons?

I've resolved this problem. Now I'm getting this error: https://github.com/godotengine/godot/issues/9650


Add Bolivian PagosNet payment method

Codecov Report

Merging #164 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage    99.6%   99.61%   +<.01%
==========================================
  Files          57       58       +1
  Lines        1012     1030      +18
==========================================
+ Hits         1008     1026      +18
  Misses          4        4

Impacted Files
Coverage Δ

src/Models/Currency.php
100% <100%> (ø)
:arrow_up:

src/Models/Country.php
100% <100%> (ø)
:arrow_up:

src/Facade.php
100% <100%> (ø)
:arrow_up:

src/Services/Gateways/PagosNet.php
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc88d7...b5a0131. Read the comment docs.


ShapeCast3D has massive accuracy issues

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3050 Laptop GPU (NVIDIA; <IP_ADDRESS>17) - 12th Gen Intel(R) Core(TM) i5-12500H (16 Threads)
Issue description
A ShapeCast3D with a sphere shape set is varying its collision distance from another collider wildly when moving a few units parallel to its extend direction. This problem does not show itself with RayCast3D.

How I expect it to work
Cast a shape downwards, onto a collider like a CSGBox, and the shapecast cast will stay at one Y level.
Move the shapecast origin in the X and Z axis, and the Y level of the cast should stay the same.
How it actually performs
Move the shapecast origin in the X and Z axis, and the Y level of the cast changes.
Using debug shapes, the sphere shape visibly bounces, even though the origin's height stays the same.
Variations of >0.0001 aren't great for physics sims, but I can see variations of >0.1, which are unacceptable!
My observations:
StaticBodies from meshes do not show this problem if the shapecast hits the front-side of a tri, but do show if the shapecast hits the back-side of a tri.
CSGBoxes with large sizes show this problem very often, as an user tends to make one single large csgbox instead of one for each cubic meter of space.
This behavior would usually not occur in Godot-JoltPhysics, but if I use a CSGBox with flipped faces there, it does.
My guess is that sphere ShapeCasts don't go well with reversed normals, yet CSGBoxes have double-sided faces with the back-side interfering with the front-side from lack of accuracy?
I think the distance from the sides of a tri increases the effect, so casting to the center of a tri has more visible effects than casting closer to that tri's edge, but I'm not sure.
Why is it a problem
For physics simulations like vehicles, any minor deviations can cause major instability in suspension and wheel systems.
For clipped cameras, camera positions jerking when in contact with walls and ceilings may lead to motion sickness.
This makes CSG objects unusable for prototyping with those systems in mind, requiring a blender-first workflow to ensure no back-face or double-face colliders, which is not ideal.
Steps to reproduce

Make a new ShapeCast3D, set shape to Sphere.
Make a new CSGBox, and set the X and Z size to a large value, like 1000.
Check the CSGBox's use collision bool.
Set some way to move either the shapecast or the box, like a Path or a KinematicBody or simple keyboard controls.
Move the two so that the shapecast collides with the box. Check the height of the cast (with DebugShapes or printing to the console)
Keep moving the objects, while keeping the Y positions of both the same. Check the height of the cast again.

Minimal reproduction project
ShapecastAccuracyBug.zip
There's a test_shapecast scene with a csgbox and a shapecast tied to a path, as seen in the example gif.
There's also a test_shapecast_on_mesh scene with two square planes from Blender set up as static bodies, and one's upside down, as well as the raycast and the path.

Can you please try this with a supported version, like 4.1.3 (only the latest patch version is supported, and it might already be fixed)

can confirm bug on v4.1.3.stable.official [f06b6836a]

That's not the only issue with CSGPrimitives and physics. They are also known to miss body_entered signals for Rigidbodies.
It's unfortunate but they are just not suited to be used in this context. I still consider it a bug, but since it has been a long standing issue and doesn't seem to be fixed soon, these physics- side limitations should be mentioned explicitly in the docs.
And for Jolt: It will hit backfaces by default when casting. Could explain your problem when using flipped faces.

I'm dealing with ConvexPolygonShape3D, those created from Qodot, and the results have been really bad when trying to check if an object was above the player but after changing the margin to 0.15 in my case (I'm using a BoxCollider for the shapecast, which is not very big, less than 1m3), I finally managed to get it working decently. Also I'm calling force_shapecast_update() after move_and_slide(), if that could help.
For my needs it is fine but it is definetely a problem is someone needs more precision/smaller colliders and I wouldn't be surprised if it fails with other geometry.
Godot 4.2.1, Godot Physics.


Example app

An example app is currently missing.

Nope: https://github.com/AndreaVitale/imageview/blob/master/ios/example/app.js

I mean a full example app :-). I'll push it right now.

Why using so much space? just copy the example app.js content to a test app on your system


push down the peer started log

Type of change

Improvement (improvement to code, performance, etc)

Description
Push down the log statement until the peer has actually been started.

Additional details
NA

Related issues
NA

This log statement is part of the integration suites startup verification sequence: https://github.com/hyperledger/fabric/blob/master/integration/nwo/network.go#L1220
While I haven't looked at the implications of your PR, this is something you'll have to account for

@hello2mao what is motivating this change?
Originally it was being removed and now it’s being moved.
The readiness message does have a purpose and is desired so I’m confused about the goal.

@hello2mao what is motivating this change?
Originally it was being removed and now it’s being moved.
The readiness message does have a purpose and is desired so I’m confused about the goal.

@sykesm I just want to put the log to the right place where peer has actually been started.

/close


Need type definition file (d.ts) for react-grid-layout

I am working on project that is using Typescript and want to use  react-grid-layout.
Do we have any existing  type definition file (d.ts) for this  library?
Thanks

One does not exist. You may be able to write one yourself by using the
existing Flow typedefs.

vineetbatta<EMAIL_ADDRESS>October 11, 2016 at 5:17 PM
I am working on project that is using Typescript and want to use
react-grid-layout.
Do we have any existing type definition file (d.ts) for this library?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/STRML/react-grid-layout/issues/365, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABJFPzYyzlOrDFCbR-MqnHgJjx_a0rMZks5qzArmgaJpZM4KUKmd.

For future readers wich may land here : see https://www.npmjs.com/package/@types/react-grid-layout


Hero animation animated the element when the element not visible in ListView

Steps to Reproduce

Create listview with the elements contain hero widget with a random tag
Create a widget hero on another page with the same tag with one of the element tag.
Scroll down the listview to make the element of the same tag with another page not visible.
Change to another page containing the widget with the same hero tag.

Expected results: The hero animation not fired
Actual results: The hero animation fired, making the element that is not visible drags from the top.
Actual result

Logs
No overflow occured.

[✓] Flutter (Channel stable, v1.17.4, on Microsoft Windows [Version 10.0.20150.1000], locale en-GB)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    ✗ Android license status unknown.
      Try re-installing or updating your Android SDK Manager.
      See https://developer.android.com/studio/#downloads or visit visit
      https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.
[!] Android Studio (not installed)
[✓] VS Code (version 1.46.1)
[!] Connected device
    ! No devices available

! Doctor found issues in 3 categories.

Hi @michaelwh09
could you provide a complete minimal reproducible code sample?

Hi this is the minimal reproducible code sampe
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: ListItem(),
    );
  }
}

class ListItem extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: ListView(
        children: <Widget>[
          Item(
            tag: "one",
          ),
          Item(
            tag: "two",
          ),
          Item(
            tag: "three",
          ),
          Item(
            tag: "four",
          ),
          Item(
            tag: "five",
          ),
        ],
      ),
    );
  }
}

class Item extends StatelessWidget {
  const Item({
    Key key,
    this.tag,
  }) : super(key: key);
  final String tag;

  @override
  Widget build(BuildContext context) {
    return Container(
      margin: EdgeInsets.symmetric(vertical: 20),
      child: GestureDetector(
        onTap: () {
          Navigator.of(context)
              .push(MaterialPageRoute(builder: (BuildContext context) {
            return AnotherPage();
          }));
        },
        child: Hero(
            tag: tag,
            child: Image.asset(
              'assets/placeholder.png',
              height: 300,
            )),
      ),
    );
  }
}

class AnotherPage extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Hero(
          tag: "one",
          child: Image.asset('assets/placeholder.png', height: 100),
        ),
      ),
    );
  }
}

And this is the result on my phone android.
Result

Wondering whether this is because the widget is still in the cache extend of the scrollable. Does the problem go away when you set the cacheExtent of the ListView to zero?
https://master-api.flutter.dev/flutter/widgets/ScrollView/cacheExtent.html

Yes, the problem go away if i set the cacheExtent to zero.

Hey, I am facing the same issue and it's bothering me a lot... The whole point of Hero animations is to make apps look more polished and this is making it look glitchy.
Setting cacheExtent to zero mitigates the problem but:

It can still happen if the item is partially visible and the list isn't fullscreen.
Isn't there a good reason for its default value?

@michaelwh09 I check this issue on the latest stable channel and see the result has been changed. For the last items of the listview, the hero animation is not triggered from the top but it seems to be changed to zoom out instead. Can you confirm this issue again?
https://github.com/flutter/flutter/assets/104349824/47058427-d345-47be-8553-d10a1873d0ed

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.16.9, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.16.9 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (14 hours ago), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.85.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 120.0.6099.234

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.19.0-9.0.pre.171, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.19.0-9.0.pre.171 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 236461161a (48 minutes ago), 2024-01-26 02:10:24 -0500
    • Engine revision 8a81e53e60
    • Dart version 3.4.0 (build 3.4.0-75.0.dev)
    • DevTools version 2.31.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Applications/Android Studio Hedgehog.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.85.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.8 19H370
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 120.0.6099.234

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.


[AIRFLOW-2234] Enable insert_rows for PrestoHook

Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2234

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

PrestoHook.insert_rows() raises NotImplementedError for now.
But Presto 0.126+ allows specifying column names in INSERT queries,
so we can leverage DbApiHook.insert_rows() almost as is.
This PR implements this function, and includes some flake8 fixes.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Added some tests to TestDbApiHook and newly added TestPrestoHook.
In addition, I manually called PrestoHook.insert_rows() and confirmed that it worked as expected.
Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3146 into master will increase coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3146      +/-   ##
==========================================
+ Coverage   73.05%   73.13%   +0.07%
==========================================
  Files         180      180
  Lines       12654    12654
==========================================
+ Hits         9245     9254       +9
+ Misses       3409     3400       -9

Impacted Files
Coverage Δ

airflow/hooks/dbapi_hook.py
82.6% <100%> (+6.08%)
:arrow_up:

airflow/hooks/presto_hook.py
39.13% <100%> (+2.17%)
:arrow_up:

airflow/models.py
87.33% <0%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f642242...b5e631f. Read the comment docs.


usb-device: Endpoint Trait

The usb-device repo has the endpoint-trait branch which, according to conversations in the project, may represent the next version of usb-device. This issue tracks the imxrt-usbd update for the next version.

I pushed an endpoint-trait branch that contains the prototype driver. It exists in parallel with the 0.2 usb-device driver. You'll find the new driver under the usbcore module. Note that the endpoint_trait "crate" is actually usb-device on the endpoint-trait branch; see the package manifest for details.
The branch has an updated test_class example for the Teensy 4. The example continues to pass the usb-device test suite:
git clone https://github.com/mvirkkunen/usb-device.git --branch endpoint-trait && cd usb-device
cargo test --tests

Next steps:

[ ] Update remaining examples
[ ] Figure out of UsbCore::set_stalled and UsbCore::is_stalled are methods we need to implement
[ ] Once usb-device is released, delete the full_speed module, and rename the usbcore module to full_speed


Version bumping ARMI to 0.2.8

What is the change?

Version bumping ARMI to 0.2.8
Cleaning up the ruff.toml

Why is the change being made?

ARMI is at a stable API point, after a very active period.
The ruff.toml is new, and while trying to clean it up I found I had added TONS of unnecessary # noqa:  comments in our code. Less is more!

Checklist

[ ] This PR has only one purpose or idea.
[ ] Tests have been added/updated to verify that the new/changed code works.

[X] The code style follows good practices.
[X] The commit message(s) follow good practices.

[X] The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
[X] The documentation is still up-to-date in the doc folder.
[X] The dependencies are still up-to-date in setup.py.

  Not a valid diff.

@opotowsky I assume this is getting pushed off a week?

We should be ready to merge this by tomorrow afternoon 🤞


test to see if the code runs before bumping the deps in order to prevent deprecation

@load1n9 ok, so the reusable workflow would look something like
name: 'bump'

on:
  workflow_call:
    inputs:
      assignees:
        default: ''
        required: false
        type: 'string'
      reviewers:
        required: true
        type: 'string'
      test:
        default: 'WHAT COMMAND AS FALLBACK?'
        required: false
        type: 'string'
    secrets:
      token:
        required: true

jobs:
  bump:
    runs-on: 'ubuntu-latest'

    steps:
      - uses: 'actions/checkout@v3'

      - uses: 'denoland/setup-deno@v1'
        with:
          deno-version: 'v1.x'

      - name: 'bump dependencies'
        run: |
          deno run -A https://raw.githubusercontent.com/azurystudio/bump/v0/mod.ts
          CHANGELOG=$(cat dependencies_changelog.md)
          echo "CHANGELOG<<EOF" >> $GITHUB_ENV
          echo "$CHANGELOG" >> $GITHUB_ENV
          echo "EOF" >> $GITHUB_ENV
          rm dependencies_changelog.md

      - name: 'create pull request'
        uses: 'peter-evans/create-pull-request@v4'
        with:
          reviewers: '${{ inputs.reviewers }}'
          token: '${{ secrets.token }}'
          title: 'bump dependencies'
          author: 'GitHub<EMAIL_ADDRESS>          commit-message: 'bump dependencies'
          body: '${{ env.CHANGELOG }}'
          labels: 'dependencies'
          delete-branch: true
          branch: 'bump'

      - id: 'commit'
        run: |
          echo "::set-output name=sha::$(git rev-parse HEAD)"

      - uses: 'Sibz/github-status-action@v1'
        with:
          authToken: '${{ secrets.token }}'
          context: 'test updates'
          state: 'pending'
          sha: '${{ steps.commit.outputs.sha }}'

      - name: 'test updates'
        id: 'test'
        continue-on-error: true
        run: '${{ inputs.test }}'

      - name: 'set commit status with outcome'
        uses: 'Sibz/github-status-action@v1'
        with:
          authToken: '${{ secrets.token }}'
          context: 'test updates'
          state: '${{ steps.test.outcome }}'
          sha: '${{ steps.commit.outputs.sha }}'

but i have no idea how to make testing completely optional, or a fallback command if no test command is specified?

this feature was removed in v0.2.6 as the action used is outdated and breaks this workflow.


Pods -> SwiftPM, Branding Updates, iOS 15 Testing, General Updates

Removed need for CocoaPods as Firebase now supports Swift Package Manager, which should make setting up more simple
Updated the logo to the Ironclad logo
Formatting tweaks to the project; sorry @mewelling I know it doesn't make reviewing as easy but it really needed linted
Built against iOS 15 to ensure the usage of Apple APIs are up-to-date and that there are no deprecation warnings
Revisions to the README for setting up the project without CocoaPods.
Adjusted minimum build target to iOS 14 but iOS 13 can still be used manually when the user opens the project in their own Xcode

Left comments, but also approving because they are mostly for my benefit haha

Love these questions and want more! Thanks for reviewing, @mewelling!