HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs

FYI @apurtell , @brfrn169

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
2m 22s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 8 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 45s
Maven dependency ordering for branch

:green_heart:
mvninstall
7m 31s
master passed

:green_heart:
compile
3m 39s
master passed

:green_heart:
checkstyle
3m 15s
master passed

:green_heart:
shadedjars
5m 43s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
2m 41s
master passed

:blue_heart:
spotbugs
5m  9s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
12m 10s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 21s
Maven dependency ordering for patch

:green_heart:
mvninstall
6m 39s
the patch passed

:green_heart:
compile
3m 33s
the patch passed

:green_heart:
cc
3m 33s
the patch passed

:green_heart:
javac
3m 33s
the patch passed

:broken_heart:
checkstyle
0m 14s
hbase-hadoop-compat: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

:broken_heart:
checkstyle
0m 13s
hbase-hadoop2-compat: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

:broken_heart:
checkstyle
0m 34s
hbase-client: The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0)

:broken_heart:
checkstyle
1m 32s
hbase-server: The patch generated 16 new + 62 unchanged - 0 fixed = 78 total (was 62)

:broken_heart:
checkstyle
0m 13s
hbase-hbtop: The patch generated 38 new + 0 unchanged - 0 fixed = 38 total (was 0)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
5m  0s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m 23s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
3m 15s
the patch passed

:broken_heart:
javadoc
0m 15s
hbase-hadoop-compat generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

:broken_heart:
javadoc
0m 36s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

:broken_heart:
javadoc
0m 15s
hbase-hbtop generated 8 new + 0 unchanged - 0 fixed = 8 total (was 0)

:broken_heart:
findbugs
0m 39s
hbase-hadoop2-compat generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

:broken_heart:
findbugs
1m 17s
hbase-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

:broken_heart:
findbugs
4m 44s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

:green_heart:
unit
0m 42s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

:green_heart:
unit
0m 37s
hbase-hadoop2-compat in the patch passed.

:green_heart:
unit
0m 25s
hbase-protocol in the patch passed.

:green_heart:
unit
1m 50s
hbase-client in the patch passed.

:broken_heart:
unit
30m 50s
hbase-server in the patch failed.

:green_heart:
unit
0m 47s
hbase-hbtop in the patch passed.

:green_heart:
asflicense
1m 37s
The patch does not generate ASF License warnings.

137m 31s

Reason
Tests

FindBugs
module:hbase-hadoop2-compat

Should org.apache.hadoop.hbase.regionserver.MetricsUserSourceImpl$ClientMetricsImpl be a static inner class?  At MetricsUserSourceImpl.java:inner class?  At MetricsUserSourceImpl.java:[lines 72-96]

FindBugs
module:hbase-client

Unused field:UserMetricsBuilder.java

Unused field:UserMetricsBuilder.java

FindBugs
module:hbase-server

Dead store to metricsCollector in org.apache.hadoop.hbase.regionserver.HRegionServer.buildServerLoad(long, long)  At HRegionServer.java:org.apache.hadoop.hbase.regionserver.HRegionServer.buildServerLoad(long, long)  At HRegionServer.java:[line 1393]

Failed junit tests
hadoop.hbase.regionserver.TestMetricsRegionServer

hadoop.hbase.regionserver.TestMetricsUserAggregate

Subsystem
Report/Notes

Docker
Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/722

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 697e8b390b36 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-722/out/precommit/personality/provided.sh

git revision
master / 6aec958d66

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-hadoop-compat.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-hadoop2-compat.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-client.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-checkstyle-hbase-hbtop.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-javadoc-javadoc-hbase-hadoop-compat.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-javadoc-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/diff-javadoc-javadoc-hbase-hbtop.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/new-findbugs-hbase-hadoop2-compat.html

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/new-findbugs-hbase-client.html

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/new-findbugs-hbase-server.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/testReport/

Max. process+thread count
694 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-hbtop U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 8 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 40s
Maven dependency ordering for branch

:green_heart:
mvninstall
6m 10s
master passed

:green_heart:
compile
3m 19s
master passed

:green_heart:
checkstyle
2m 55s
master passed

:green_heart:
shadedjars
5m 37s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
2m 26s
master passed

:blue_heart:
spotbugs
4m 46s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
12m  0s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 14s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 28s
the patch passed

:green_heart:
compile
3m 15s
the patch passed

:green_heart:
cc
3m 15s
the patch passed

:green_heart:
javac
3m 15s
the patch passed

:broken_heart:
checkstyle
0m 34s
hbase-client: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

:broken_heart:
checkstyle
1m 27s
hbase-server: The patch generated 2 new + 62 unchanged - 0 fixed = 64 total (was 62)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
5m  0s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m 13s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
3m 16s
the patch passed

:green_heart:
javadoc
2m  5s
the patch passed

:green_heart:
findbugs
12m  3s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 42s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
0m 30s
hbase-hadoop-compat in the patch passed.

:green_heart:
unit
0m 37s
hbase-hadoop2-compat in the patch passed.

:green_heart:
unit
0m 26s
hbase-protocol in the patch passed.

:green_heart:
unit
1m 45s
hbase-client in the patch passed.

:broken_heart:
unit
255m  8s
hbase-server in the patch failed.

:green_heart:
unit
1m  2s
hbase-hbtop in the patch passed.

:green_heart:
asflicense
2m 51s
The patch does not generate ASF License warnings.

357m 14s

Subsystem
Report/Notes

Docker
Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/722

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 2c2dc8cad140 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-722/out/precommit/personality/provided.sh

git revision
master / 7924ba39e7

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/2/artifact/out/diff-checkstyle-hbase-client.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/2/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/2/testReport/

Max. process+thread count
4777 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-hbtop U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

And don't we need ClientModeTest?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  1s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 38s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 47s
master passed

:green_heart:
compile
3m 23s
master passed

:green_heart:
checkstyle
2m 54s
master passed

:green_heart:
shadedjars
4m 36s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
2m 18s
master passed

:blue_heart:
spotbugs
4m  9s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
10m 27s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 15s
Maven dependency ordering for patch

:green_heart:
mvninstall
4m 55s
the patch passed

:green_heart:
compile
3m 23s
the patch passed

:green_heart:
cc
3m 23s
the patch passed

:green_heart:
javac
3m 23s
the patch passed

:broken_heart:
checkstyle
0m 33s
hbase-client: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

:broken_heart:
checkstyle
1m 19s
hbase-server: The patch generated 4 new + 63 unchanged - 0 fixed = 67 total (was 63)

:broken_heart:
checkstyle
0m 15s
hbase-hbtop: The patch generated 29 new + 0 unchanged - 0 fixed = 29 total (was 0)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 39s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 38s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
3m 22s
the patch passed

:green_heart:
javadoc
2m 16s
the patch passed

:green_heart:
findbugs
11m 23s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 40s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
0m 34s
hbase-hadoop-compat in the patch passed.

:green_heart:
unit
0m 40s
hbase-hadoop2-compat in the patch passed.

:green_heart:
unit
0m 28s
hbase-protocol in the patch passed.

:green_heart:
unit
1m 49s
hbase-client in the patch passed.

:broken_heart:
unit
158m 43s
hbase-server in the patch failed.

:green_heart:
unit
1m  1s
hbase-hbtop in the patch passed.

:green_heart:
asflicense
3m 20s
The patch does not generate ASF License warnings.

255m 50s

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/722

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 56e7a232a6d1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-722/out/precommit/personality/provided.sh

git revision
master / b14ba58c5a

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/3/artifact/out/diff-checkstyle-hbase-client.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/3/artifact/out/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/3/artifact/out/diff-checkstyle-hbase-hbtop.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/3/testReport/

Max. process+thread count
4555 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-hbtop U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Thanks a lot guys for the review @joshelser @brfrn169 @apurtell , have updated the pull request as per the review comments.

Need to take this down locally and play with it too :)
Probably not a bad idea to also run this through a quick perf test to make sure no regressions come in (same way as the dependent user metrics change)

./bin/ycsb run hbase20 -P workloads/workloada -s -threads 10 -p columnfamily=family
ycsb shows performance similar on single server cluster with and without patch.
without patch
[OVERALL], RunTime(ms), 52493
[OVERALL], Throughput(ops/sec), 19050.159068828223
[TOTAL_GCS_PS_Scavenge], Count, 73
[TOTAL_GC_TIME_PS_Scavenge], Time(ms), 123
[TOTAL_GC_TIME_%PS_Scavenge], Time(%), 0.23431695654658716
[TOTAL_GCS_PS_MarkSweep], Count, 1
[TOTAL_GC_TIME_PS_MarkSweep], Time(ms), 32
[TOTAL_GC_TIME%PS_MarkSweep], Time(%), 0.06096050902025032
[TOTAL_GCs], Count, 74
[TOTAL_GC_TIME], Time(ms), 155
[TOTAL_GC_TIME%], Time(%), 0.2952774655668375
[READ], Operations, 468618
[READ], AverageLatency(us),<PHONE_NUMBER>309156
[READ], MinLatency(us), 144
[READ], MaxLatency(us), 105983
[READ], 95thPercentileLatency(us), 815
[READ], 99thPercentileLatency(us), 1395
[READ], Return=OK, 468618
[READ], Return=NOT_FOUND, 31339
[CLEANUP], Operations, 20
[CLEANUP], AverageLatency(us), 122.7
[CLEANUP], MinLatency(us), 0
[CLEANUP], MaxLatency(us), 2081
[CLEANUP], 95thPercentileLatency(us), 263
[CLEANUP], 99thPercentileLatency(us), 2081
[UPDATE], Operations, 500043
[UPDATE], AverageLatency(us),<PHONE_NUMBER>014385
[UPDATE], MinLatency(us), 171
[UPDATE], MaxLatency(us), 118143
[UPDATE], 95thPercentileLatency(us), 780
[UPDATE], 99thPercentileLatency(us), 1448
[UPDATE], Return=OK, 500043
[READ-FAILED], Operations, 31339
[READ-FAILED], AverageLatency(us),<PHONE_NUMBER>624685
[READ-FAILED], MinLatency(us), 122
[READ-FAILED], MaxLatency(us), 22671
[READ-FAILED], 95thPercentileLatency(us), 633
[READ-FAILED], 99thPercentileLatency(us), 1195
With Patch
[OVERALL], RunTime(ms), 51625
[OVERALL], Throughput(ops/sec), 19370.46004842615
[TOTAL_GCS_PS_Scavenge], Count, 77
[TOTAL_GC_TIME_PS_Scavenge], Time(ms), 133
[TOTAL_GC_TIME_%PS_Scavenge], Time(%), 0.2576271186440678
[TOTAL_GCS_PS_MarkSweep], Count, 1
[TOTAL_GC_TIME_PS_MarkSweep], Time(ms), 25
[TOTAL_GC_TIME%PS_MarkSweep], Time(%), 0.048426150121065374
[TOTAL_GCs], Count, 78
[TOTAL_GC_TIME], Time(ms), 158
[TOTAL_GC_TIME%], Time(%), 0.30605326876513317
[READ], Operations, 383745
[READ], AverageLatency(us),<PHONE_NUMBER>847125
[READ], MinLatency(us), 119
[READ], MaxLatency(us), 124479
[READ], 95thPercentileLatency(us), 752
[READ], 99thPercentileLatency(us), 1380
[READ], Return=OK, 383745
[READ], Return=NOT_FOUND, 116557
[CLEANUP], Operations, 20
[CLEANUP], AverageLatency(us), 122.8
[CLEANUP], MinLatency(us), 0
[CLEANUP], MaxLatency(us), 2019
[CLEANUP], 95thPercentileLatency(us), 309
[CLEANUP], 99thPercentileLatency(us), 2019
[READ-FAILED], Operations, 116557
[READ-FAILED], AverageLatency(us),<PHONE_NUMBER>6631436
[READ-FAILED], MinLatency(us), 122
[READ-FAILED], MaxLatency(us), 89279
[READ-FAILED], 95thPercentileLatency(us), 654
[READ-FAILED], 99thPercentileLatency(us), 1274
[UPDATE], Operations, 499698
[UPDATE], AverageLatency(us),<PHONE_NUMBER>092977
[UPDATE], MinLatency(us), 173
[UPDATE], MaxLatency(us), 135935
[UPDATE], 95thPercentileLatency(us), 801
[UPDATE], 99thPercentileLatency(us), 1561
[UPDATE], Return=OK, 499698

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  0s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 34s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 42s
master passed

:green_heart:
compile
3m 18s
master passed

:green_heart:
checkstyle
2m 57s
master passed

:green_heart:
shadedjars
4m 59s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
2m  5s
master passed

:blue_heart:
spotbugs
4m 29s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
11m  0s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 13s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 24s
the patch passed

:green_heart:
compile
3m 14s
the patch passed

:green_heart:
cc
3m 14s
the patch passed

:green_heart:
javac
3m 14s
the patch passed

:broken_heart:
checkstyle
0m 33s
hbase-client: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

:broken_heart:
checkstyle
1m 32s
hbase-server: The patch generated 2 new + 273 unchanged - 0 fixed = 275 total (was 273)

:broken_heart:
checkstyle
0m 11s
hbase-hbtop: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
5m  2s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m 15s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
3m 15s
the patch passed

:green_heart:
javadoc
2m  7s
the patch passed

:green_heart:
findbugs
11m 57s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 41s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

:green_heart:
unit
0m 38s
hbase-hadoop2-compat in the patch passed.

:green_heart:
unit
0m 26s
hbase-protocol in the patch passed.

:green_heart:
unit
1m 48s
hbase-client in the patch passed.

:broken_heart:
unit
32m 48s
hbase-server in the patch failed.

:green_heart:
unit
0m 51s
hbase-hbtop in the patch passed.

:green_heart:
asflicense
1m 43s
The patch does not generate ASF License warnings.

130m 58s

Reason
Tests

Failed junit tests
hadoop.hbase.TestClientClusterMetrics

hadoop.hbase.filter.TestFilterFromRegionSide

hadoop.hbase.regionserver.TestKeepDeletes

hadoop.hbase.filter.TestInvocationRecordFilter

hadoop.hbase.regionserver.TestResettingCounters

hadoop.hbase.filter.TestFilter

hadoop.hbase.filter.TestDependentColumnFilter

hadoop.hbase.regionserver.TestScanner

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/722

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 329672cece14 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-722/out/precommit/personality/provided.sh

git revision
master / 2a969e1d8b

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/4/artifact/out/diff-checkstyle-hbase-client.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/4/artifact/out/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/4/artifact/out/diff-checkstyle-hbase-hbtop.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/4/testReport/

Max. process+thread count
838 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-hbtop U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:blue_heart:
prototool
0m  1s
prototool was not available.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 33s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 47s
master passed

:green_heart:
compile
3m 17s
master passed

:green_heart:
checkstyle
2m 58s
master passed

:green_heart:
shadedjars
4m 58s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
2m  5s
master passed

:blue_heart:
spotbugs
4m 25s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
10m 57s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 14s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 27s
the patch passed

:green_heart:
compile
3m 16s
the patch passed

:green_heart:
cc
3m 16s
the patch passed

:green_heart:
javac
3m 16s
the patch passed

:broken_heart:
checkstyle
0m 32s
hbase-client: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

:broken_heart:
checkstyle
1m 35s
hbase-server: The patch generated 2 new + 273 unchanged - 0 fixed = 275 total (was 273)

:broken_heart:
checkstyle
0m 12s
hbase-hbtop: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
5m  0s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m 11s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
hbaseprotoc
3m 13s
the patch passed

:green_heart:
javadoc
2m  6s
the patch passed

:green_heart:
findbugs
11m 57s
the patch passed

_ Other Tests _

:green_heart:
unit
0m 42s
hbase-protocol-shaded in the patch passed.

:green_heart:
unit
0m 31s
hbase-hadoop-compat in the patch passed.

:green_heart:
unit
0m 37s
hbase-hadoop2-compat in the patch passed.

:green_heart:
unit
0m 26s
hbase-protocol in the patch passed.

:green_heart:
unit
1m 52s
hbase-client in the patch passed.

:broken_heart:
unit
32m  6s
hbase-server in the patch failed.

:green_heart:
unit
0m 48s
hbase-hbtop in the patch passed.

:green_heart:
asflicense
1m 35s
The patch does not generate ASF License warnings.

130m  9s

Reason
Tests

Failed junit tests
hadoop.hbase.TestClientClusterMetrics

Subsystem
Report/Notes

Docker
Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/722

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux ea948db3f0dd 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-722/out/precommit/personality/provided.sh

git revision
master / 2a969e1d8b

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/5/artifact/out/diff-checkstyle-hbase-client.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/5/artifact/out/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/5/artifact/out/diff-checkstyle-hbase-hbtop.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/5/testReport/

Max. process+thread count
820 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-hbtop U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Thank you @brfrn169  for the review, Let me work on the review comments today.

@brfrn169 , have taken the review comments in the latest push. Let me know how it looks?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 23s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 40s
master passed

+1 :green_heart:
compile
3m 14s
master passed

+1 :green_heart:
checkstyle
3m  1s
master passed

+1 :green_heart:
shadedjars
5m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m  3s
master passed

+0 :ok:
spotbugs
4m 28s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
10m 57s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 27s
the patch passed

+1 :green_heart:
compile
3m 20s
the patch passed

+1 :green_heart:
cc
3m 20s
the patch passed

+1 :green_heart:
javac
3m 20s
the patch passed

-1 :x:
checkstyle
0m 41s
hbase-client: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
checkstyle
1m 41s
hbase-server: The patch generated 4 new + 254 unchanged - 0 fixed = 258 total (was 254)

-1 :x:
checkstyle
0m 14s
hbase-hbtop: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 51s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
3m 15s
the patch passed

+1 :green_heart:
javadoc
2m 15s
the patch passed

+1 :green_heart:
findbugs
12m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 41s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
0m 30s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
0m 37s
hbase-hadoop2-compat in the patch passed.

+1 :green_heart:
unit
0m 26s
hbase-protocol in the patch passed.

+1 :green_heart:
unit
1m 50s
hbase-client in the patch passed.

-1 :x:
unit
33m 32s
hbase-server in the patch failed.

+1 :green_heart:
unit
0m 49s
hbase-hbtop in the patch passed.

+1 :green_heart:
asflicense
1m 33s
The patch does not generate ASF License warnings.

136m 27s

Reason
Tests

Failed junit tests
hadoop.hbase.TestClientClusterMetrics

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/722

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux a0d501a746bb 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-722/out/precommit/personality/provided.sh

git revision
master / a3efa5911d

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/7/artifact/out/diff-checkstyle-hbase-client.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/7/artifact/out/diff-checkstyle-hbase-server.txt

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/7/artifact/out/diff-checkstyle-hbase-hbtop.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/7/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/7/testReport/

Max. process+thread count
811 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-hbtop U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/7/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  1s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 7 new or modified test files.

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 19s
master passed

+1 :green_heart:
compile
3m 23s
master passed

+1 :green_heart:
checkstyle
3m  1s
master passed

+1 :green_heart:
shadedjars
4m 33s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
2m 18s
master passed

+0 :ok:
spotbugs
4m  2s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
10m 25s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 56s
the patch passed

+1 :green_heart:
compile
3m 20s
the patch passed

+1 :green_heart:
cc
3m 20s
the patch passed

+1 :green_heart:
javac
3m 20s
the patch passed

+1 :green_heart:
checkstyle
2m 59s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 34s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
15m 39s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
hbaseprotoc
3m 21s
the patch passed

+1 :green_heart:
javadoc
2m 17s
the patch passed

+1 :green_heart:
findbugs
11m 26s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 42s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
0m 32s
hbase-hadoop-compat in the patch passed.

+1 :green_heart:
unit
0m 41s
hbase-hadoop2-compat in the patch passed.

+1 :green_heart:
unit
0m 27s
hbase-protocol in the patch passed.

+1 :green_heart:
unit
1m 52s
hbase-client in the patch passed.

-1 :x:
unit
163m 15s
hbase-server in the patch failed.

+1 :green_heart:
unit
1m  7s
hbase-hbtop in the patch passed.

+1 :green_heart:
asflicense
3m 41s
The patch does not generate ASF License warnings.

259m 15s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/722

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool

uname
Linux 65e4d40f91f6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-722/out/precommit/personality/provided.sh

git revision
master / a3efa5911d

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/8/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/8/testReport/

Max. process+thread count
4685 (vs. ulimit of 10000)

modules
C: hbase-protocol-shaded hbase-hadoop-compat hbase-hadoop2-compat hbase-protocol hbase-client hbase-server hbase-hbtop U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-722/8/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Can I merge this? @ankitsinghal @joshelser @apurtell

Can I merge this

OK by me. I know Ankit was traveling with intermittent access. I think he might be back soon, but I don't think you need to wait for him if you think this is good.

Merged.


BUG: Footer "Quick Links" ul tag word gap is not good

#851
In this I added gap: 3rem and change the color of hover
#851
In the footer section "Quick Links"  tag I changed word gap to 3rem as well added hover effect with matching color effect.
#Request
Please consider this PR, if you like this change on the footer section. Then please this PR and merge it under gssoc'24 and level this PR.
Description
n the footer section "Quick Links"  tag I changed word gap to 3rem as well added hover effect with matching color effect.
Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Before Change -
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/136844498/ff6cba21-0d46-4607-8ae2-234472f1962b
After Change -
https://github.com/Suchitra-Sahoo/AgriLearnNetwork/assets/136844498/7caefbbf-c9f9-434b-bc78-a684183c961b
Checklist:

[ ] I have performed a self-review of my code
[ ] I have read and followed the Contribution Guidelines.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

don't change the spacing add only hover effect. It is looking like this

current one is much better


[BUG] API documentation at /redoc is broken

Software Versions:

Operating System: Linux (Ubuntu 22.04)
Python version: 3.10.4
BusyLight version: 0.21.0

General Type of Problem

[x] Web API

Describe the Problem
The /redoc route shows a "Loading..." screen and fails to load anything further (the debug output of busyserve shows a crash/stack trace)
Expected Behavior
Loading and showing the API documentation.
Error Output
INFO:     <IP_ADDRESS>:58997 - "GET /redoc HTTP/1.1" 200 OK
2022-07-16 00:24:24.900 | INFO     | busylight.lights.usblight:all_lights:203 - BlinkStick found 0 lights
2022-07-16 00:24:24.910 | ERROR    | busylight.lights.usblight:acquire:629 - open_path failed with open failed
2022-07-16 00:24:24.911 | ERROR    | busylight.lights.usblight:all_lights:202 - Blynclight LightUnavailable: 2c0d:000c path=b'1-4:1.0'
2022-07-16 00:24:24.912 | INFO     | busylight.lights.usblight:all_lights:203 - Blynclight found 0 lights
2022-07-16 00:24:24.920 | INFO     | busylight.lights.usblight:all_lights:203 - Busylight found 0 lights
2022-07-16 00:24:24.928 | INFO     | busylight.lights.usblight:all_lights:203 - Flag found 0 lights
2022-07-16 00:24:24.935 | INFO     | busylight.lights.usblight:all_lights:203 - Mute found 0 lights
2022-07-16 00:24:24.943 | INFO     | busylight.lights.usblight:all_lights:203 - Orb found 0 lights
2022-07-16 00:24:24.953 | INFO     | busylight.lights.usblight:all_lights:203 - MuteMe found 0 lights
2022-07-16 00:24:24.964 | INFO     | busylight.lights.usblight:all_lights:203 - Status_Indicator found 0 lights
2022-07-16 00:24:24.971 | INFO     | busylight.lights.usblight:all_lights:203 - Blink1 found 0 lights
2022-07-16 00:24:24.972 | INFO     | busylight.lights.usblight:all_lights:195 - USBLight found 0 lights total
INFO:     <IP_ADDRESS>:58997 - "GET /openapi.json HTTP/1.1" 500 Internal Server Error
ERROR:    Exception in ASGI application
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/base.py", line 43, in call_next
    message = await recv_stream.receive()
  File "/usr/local/lib/python3.10/dist-packages/anyio/streams/memory.py", line 94, in receive
    return self.receive_nowait()
  File "/usr/local/lib/python3.10/dist-packages/anyio/streams/memory.py", line 87, in receive_nowait
    raise EndOfStream
anyio.EndOfStream

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/uvicorn/protocols/http/h11_impl.py", line 403, in run_asgi
    result = await app(self.scope, self.receive, self.send)
  File "/usr/local/lib/python3.10/dist-packages/uvicorn/middleware/proxy_headers.py", line 78, in __call__
    return await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/fastapi/applications.py", line 269, in __call__
    await super().__call__(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/applications.py", line 124, in __call__
    await self.middleware_stack(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/errors.py", line 184, in __call__
    raise exc
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/errors.py", line 162, in __call__
    await self.app(scope, receive, _send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/base.py", line 68, in __call__
    response = await self.dispatch_func(request, call_next)
  File "/usr/local/lib/python3.10/dist-packages/busylight/api/busylight_api.py", line 205, in light_manager_update
    return await call_next(request)
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/base.py", line 46, in call_next
    raise app_exc
  File "/usr/local/lib/python3.10/dist-packages/starlette/middleware/base.py", line 36, in coro
    await self.app(scope, request.receive, send_stream.send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/exceptions.py", line 93, in __call__
    raise exc
  File "/usr/local/lib/python3.10/dist-packages/starlette/exceptions.py", line 82, in __call__
    await self.app(scope, receive, sender)
  File "/usr/local/lib/python3.10/dist-packages/fastapi/middleware/asyncexitstack.py", line 21, in __call__
    raise e
  File "/usr/local/lib/python3.10/dist-packages/fastapi/middleware/asyncexitstack.py", line 18, in __call__
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 670, in __call__
    await route.handle(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 266, in handle
    await self.app(scope, receive, send)
  File "/usr/local/lib/python3.10/dist-packages/starlette/routing.py", line 65, in app
    response = await func(request)
  File "/usr/local/lib/python3.10/dist-packages/fastapi/applications.py", line 224, in openapi
    return JSONResponse(self.openapi())
  File "/usr/local/lib/python3.10/dist-packages/fastapi/applications.py", line 199, in openapi
    self.openapi_schema = get_openapi(
  File "/usr/local/lib/python3.10/dist-packages/fastapi/openapi/utils.py", line 439, in get_openapi
    return jsonable_encoder(OpenAPI(**output), by_alias=True, exclude_none=True)  # type: ignore
  File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for OpenAPI
info -> version
  str type expected (type=type_error.str)

Well, that is disappointing! I've recreated the error and looking into it. Thanks for reporting this problem.

Good news, found the problem and should have a corrected version published to pypi shortly. Look for version 0.20.6.

Excellent, that was quick! Thank you so much.

That should fix the problem, update here if it doesn't.

Confirmed fixed - thank you so much!


ror file as defined in INSPIRE

Dynamically generate .ror files as specified by INSPIRE group on register federation:

registry ror file
ror descriptor for each register you want to share in the federation.

More details and example files here: https://ies-svn.jrc.ec.europa.eu/projects/inspire-registry/wiki/Registry_federation_requirements
Running examples (hand-made for BRGM registry)

for the registy https://data.geoscience.fr/ncl/registryFederation.ror
for one register :https://data.geoscience.fr/ncl/litho.ror  (example, search for dct:accrualPeriodicity).

Idea would be to have the required 'descriptors' natively included in the description of the registry and the registers -> no more need for static files but need to have a new 'download format' (like RDF/XML.ROR) that triggers the required response/serialization

Adding metadata-only endpoints for registers and a metadata endpoint for the registry itself is feasible and may be a generally useful extension.
Such endpoints could deliver the usual RDF formats, including RDF/XML.
If the ROR specification allows ROR consumers to ignore properties they are not interested in, then once there are metadata-only endpoints you would just need to add the metadata corresponding to ROR on top of the the normal registry metadata.
If the specification (which isn't precise on this point) requires "these properties and only these properties" then that would be a different situation and would require a ROR specification solution that seems less appropriate for the main code line.

Comments and clarification questions ...
So there's several parts to this problem - the need to include the full publisher information and isPartOf links to the registry, the constrained XML serialization and the need for additional terms such as skos:definition.
The publisher and registry link information can't be included in a register definition without modifications to the codebase. You can uploaded embedded information by using blank nodes but the ROR validator doesn't accept those and indeed the ROR spec explicitly asks for URIs as well as inline descriptions of them. It would be possible to have separate registers (e.g. under structure) to hold the publisher descriptions and the overall registry description and then automatically pull those into the register payload when responding to a ROR request.
After some experimentation I think the XML serialization issue itself is solvable. The validators have a very narrow view of RDF/XML but we can configure the Jena RDF/XML writer to pull skos:Concept and skos:ConceptScheme to the top level. With that then a sample register, with manually added publisher metadata and registry metadata, passes the validator.
The ROR specification includes a separate media type for ROR files so the right approach is probably to add a _format=ror option which would both trigger the enrichment of the return payload (to pull in the publisher and registry links) and then set the media type to application/x-ror-rdf+xml. A new marshaller could then handle that media type by setting the right parameters for the RDF/XML writer.
The ROR requirements over use of skos:prefLabel instead of rdfs:label for registers, the need for a skos:definition of a register etc are solvable by simply including those in your register definitions, no change required to support those.
Some questions:

The ROR specification limits cardinality of dct:title, skos:prefLabel etc to 1..1. This means that you can not have multilingual labels on a ROR registry, register or individual concepts. However, the validators do not check this and payloads with multilingual labels do pass validation. Can we rely on this? Can we assume that whatever software consumes this can cope with multilingual labels?

Is your requirement to federate all registers (or at least all under /def) or do you want selective control so that you explicitly enumerate the registers to be included in the federation?  The controlled option would be easier to implement since we would then just need a system register to represent the overall catalog to be federated. That would also be the place to include the top level registry metadata, which would be convenient. However, you would then need to manually add each new register to be federated into the catalog register.

Thank you very much Dave, the solution of a separate registers (e.g. under structure)  seems the most suitable way I think. we agree with your proposition of a selective control using this separate register. I think also it easier for the dev and better for us since we want to have a control on what registers we want to push through ror. It's even better this way since we can have different producers and different periodicities from one register to antother.
Concerning your question about dct:title, skos:prefLabel,  it's seems more logical to us hat the software consuming the ror payload should handle multilingual labels. We'll check with jrc people why the cardinality is limited to 1..1.
we also agree with the _format=ror and application/x-ror-rdf+xml media type solutions.

JRC reply: Currently the RoR is just using the English language as first choice. If this is not found, it tries to read the first occurrence without specifying the language.

@der have there been any advances about this issue.
I see that the dedicated dev branch hasn't moved since December, so I assumed not.  I tried it thought with the content negotiation as explained in the wiki preview , it didn't work.
I think I missed something in our exchanges. Do you have an idea when this will be finished please?
Thanks a lot

@afeliachi I am currently working on this issue now that the internationalisation feature appears to be in a good state. I expect that it will be ready to test by the end of this week.

Thanks Simon. We would really appreciate that.

The branches for this feature on registry-core and registry-config-base are ready to test (5-ror-format).
They are documented here.
I had to differ from some of the plans discussed above in order to make sure that the produced XML would conform to the given templates (the default serialisation tends to produce valid RDF but not in the required structure). In particular, the registry descriptor and the root ConceptScheme of the register descriptor will be rendered with only the properties that are relevant to the INSPIRE format. This is currently a hard coded list, so please let me know if you need this to be configurable or if there are specific properties you would like to include.

Have you made any progress in testing this?

Sorry Simon I thought I responded to this.
Actually there are few issues with the payload returned:

The content doesn't meet the conformance scheme of having rdf:description markups instead of typed markups (skos:ConceptScheme & skos:Concept).

Registry descriptor: when requesting the ror description of the root ( the registry) the response doesn't provide registry descriptor as specified by the conformance class.

When loading data  for the first time inScheme properties are lost (looks like an old bug and not for this version only)

thank you

@afeliachi OK, I will try to look into this in the next week or so.

@afeliachi

I'm not aware of the specification requiring those resources to be written as rdf:descriptions, and the XSL validators succeed even if they are not - could you point me to which part of the spec requires this?
As mentioned in Dave's comment on 7/11/2019, the registry descriptor should be located under /structure and signified by having the dcat:Catalog type. The suggested setup is documented here.
I haven't encountered this bug before, could you provide an example of an RDF payload where this occurs?

Hi Simon
Am currently retesting this. We'll be back to you ASAP
sorry for the delay

Hi Simon

regarding the rdf:description  pattern you can see it in the examples provided in the requirement, but you are right the XSL validator accepts type markups also, so no problem with that, sorry.

I was aware of the configuration recommendation of  where to locate the register with the dcat:Catalog type. But we hoped that the payload would expose the registry (root) URI as the URI of the catalog
so instead of having

<dcat:Catalog rdf:about="http://localhost:8080/ldregistry/structure/catalog">
It is necessary to have
<dcat:Catalog rdf:about="http://localhost:8080/ldregistry/">
So I tried to edit the root directly, by adding the dcat:Catalog type and the necessary conformance class properties, but the problem is that I am not able of editing the root registry description. I encounter the following message
Proposed notation for item is not a legal pchar or starts with '_' -
I get the same response with  (PATCH request)  to update the root description. Do you have any suggestion on that.

Regarding the skos:inScheme loss problem, I think it's a general problem, and worth a separate issue with examples, will do that. We can disregard this in this ticket.

Thanks @afeliachi , I will look into point 2 this week.

Thank you @simonoakesepimorphics

I've updated the branch to satisfy the requirement that the registry descriptor should have the root register as its root element rather than the /structure/catalogue register.
The registry description and dataset catalog resides on the /structure/catalog register as before, and you can access it from either the root register (ROR format) or the catalog register itself. However, the result will always use the root register as the root of the graph  and transpose the registry description from /structure/catalog onto it. This means that you will not need to modify the root register in any way.
Register descriptors should work the same as before.
I've updated the wiki page to reflect this.

Hi @simonoakesepimorphics
Just finished the tests. Everything looks perfect.  Thank you for this last edit.
@sgrellet  I close the ticket


Review Model and Log Outputs

With a view to running interactive session with epidemiology team. Should be consulting with them on the outputs that would be useful to see for this purpose.

[ ] Fix output module to use new dataframe accessors
[ ] Consult with HIV team and determine outputs for pregnancy and ANC testing


bn21

Expected behavior
Actual behavior
Steps to reproduce behavior
Bourbon version
Environment info
Screenshots (if relevant)

Wow github keyboard shortcuts fail sorry!


What am I supposed to do after this?

it says here to do this but I don't get what it means.

User commands are sent through Selenium keyboard actions to simulate a real user typing into the message box.

unrelated but I would just like to ask how you got past the "couldn't parse $tu command" error


Proposal: add support for stopping execution on first resolver error

Currently it appears that with graphql-tools there is no way to have errors thrown within resolver functions that bubble up to the graphql execution call
example here:
node v8.2.0
const { makeExecutableSchema, addErrorLoggingToSchema } = require('graphql-tools')
const {graphql} = require('graphql')

const types = `
  type Query {
    TopLevel: [Foo]
  }
  type Foo {
    prop: Int
  }
`

const resolvers = {
  Query: {
    TopLevel() {
      return  [ 1, 2, 3 ]
    }
  },
  Foo: {
    prop () {
      throw new Error('error inside field resolver')
    }
  }
}

let schema = makeExecutableSchema({
  typeDefs: types,
  resolvers: resolvers
})

const logger = {
  log: (e) => {
    throw e
  }
}
addErrorLoggingToSchema(schema, logger)

let query = `{
  TopLevel {
    prop
  }
}`

graphql(schema, query).then((res) => {
  console.log(res.data)
}).catch((e) => {
  console.log('error at graphql')
  console.log(e)
})

Although it appears to be throwing the logged error here... https://github.com/apollographql/graphql-tools/blob/master/src/schemaGenerator.ts#L459-L480.
Is this an issue with graphql-js? Would it be possible to add a flag to graphql-tools to enable that errors are thrown?

ah just saw this issue https://github.com/apollographql/graphql-tools/issues/291

graphql returns errors along with data in the response


Dynamically swipe left/right or discard

Hi @loringdodge ,
I'm currently implementing your fork and really appreciate it but I was wondering how to programtically swipe or discard a card, from a button for example.

Hey @AdrienDC,
I believe what you're looking for is already part of the included functionality. Check out this Codepen. There's a function attached to scope called onClickTransitionOut(card) where card is the card object supplied from the iterator (ng-repeat). Additionally,  onClickTransitionOut dispatches an event using $emit called 'removeCard' and in your parent controller, you can define what should occur.
Here's how to include it in your template (pulled from the Codepen example):

DISCARD

And here's how you would listen on the event that is emitted. This specific function pushes the removed card to the discards pile. However, you could change that to whichever you like.
$scope.$on('removeCard', function(event, element, card) {
    var discarded = $scope.cards.master.splice($scope.cards.master.indexOf(card), 1);
    $scope.cards.discards.push(discarded);
   // or $scope.cards.liked.push(discarded);
 });

Hope that helps, or if it doesn't, let me know more in depth what you're attempting to achieve.

Thanks Loring, yes in fact I used this event to simulate a left swipe and quickly added the same behavior for the right side. Thanks for your great work anyway :)

@AdrienDC
Awesome. Glad that you got it working!

@AdrienDC @loringdodge
Can you provide a demonstration of how to do this from within the controller?

Hey @andrewoodleyjr
The only place where you'll have access to the onClickTransitionOut within a controller is in the CardCtrl.

                 // ...your custom card template

The above is an example of a template where td-cards is being iterated on by an ng-repeat and invoking a new instance of a CardCtrl. You'll need to define a new CardCtrl instance but on that scope should be the onClickTransitionOut method that will discard that specific card.
.controller('CardCtrl', function($scope, TDCardDelegate) {
    console.log($scope.onClickTransitionOut) // I am a defined function
});

Hope that helps!
Loring

Still can't achive the swipe right with this lib.
What if I want to achieve with a couple of buttons that are not in the card scope?
Like this demo:
http://codepen.io/julienroubieu/pen/mJeJJE?editors=1010

I am having the same issue with trying to programmatically swipe cards from outside the directives entirely. I'd like to have separate buttons that trigger either a swipe to the left or right without using any swipe gestures. I've tried to follow the same methods as the "discard" example but that click event is within the scope of the individual cards.

@klahaeck  I did acomplished that with the shared code snippet

@cortezcristian how did you trigger the clicks from outside of CardsCtrl and CardCtrl?

@cortezcristian nevermind, got it figured out. Thanks!

Can someone please explain how to add buttons outside the ng-repeat loop that are able to call onClickTransitionOut for the top card? I'm new to angular & having a really hard time..
@klahaeck @cortezcristian

I'm not really sure how I've managed it as I'm a newbie in AngularJS but this code works. Change the animateFlyAway function as below:
animateFlyAway: function(e) {

      // is animation triggered by drag or click?
      //var draggable = (e !== undefined);

       var self = this;

            var isGestureSwipe = (typeof e === "object");
            var swipeRight = isGestureSwipe ? this.x > 0 : e === "right";

      self.updateIndex();

      self.onTransitionOut(self.thresholdAmount);

            var angle, targetX, targetY, velocityX, rotateTo;

            if (swipeRight) {
                targetX = (this.parentWidth / 2) + (this.width);
            } else {
                targetX = -(this.parentWidth + this.width);
            }

            if (isGestureSwipe) {
                angle = Math.atan(e.gesture.deltaX / e.gesture.deltaY);
                // Target Y is just the "opposite" side of the triangle of targetX as the adjacent edge (sohcahtoa yo)
                targetY = targetX / Math.tan(angle);
                velocityX = e.gesture.velocityX;
                rotateTo = this.rotationAngle;
            } else {
                angle = -1.5;
                targetY = 100;
                velocityX = 0.5;
                rotateTo = -0.2;
            }
            this.thresholdAmount = this.thresholdAmount || 0;

            var duration = 0.3 - Math.min(Math.max(Math.abs(velocityX) / 10, 0.05), 0.2);

            ionic.requestAnimationFrame(function() {
                self.el.style.transform = self.el.style.webkitTransform = 'translate3d(' + targetX + 'px, ' + targetY + 'px,0) rotate(' + rotateTo + 'rad)';
                self.el.style.transition = self.el.style.webkitTransition = 'all ' + duration + 's ease-in-out';
            });

Change onClickTransitionOut(card) to two different functions
  controller: ['$scope', '$element', function($scope, $element) {
      // Emits event 'dislikeCard' which should have a listener in a parent scope
      $scope.$parent.onClickTransitionLeft = function(card) {
        var element = $scope.$parent.swipeCard;
        element.onClickTransitionLeft();
        $scope.$emit('dislikeCard', element, card);
      },
      $scope.$parent.onClickTransitionRight = function(card) {
        var element = $scope.$parent.swipeCard;
        element.onClickTransitionRight();
        $scope.$emit('likeCard', element, card);
      }
    }],

in app.js I've changed 'removeCard' event functions to 'dislikeCard' and 'likeCard':
  $scope.$on('dislikeCard', function(event, element, card) {
    var disliked = $scope.cards.active.splice($scope.cards.master.indexOf(card), 1);
    $scope.cards.disliked.push(disliked);
  });

  $scope.$on('likeCard', function(event, element, card) {
    var liked = $scope.cards.active.splice($scope.cards.master.indexOf(card), 1);
    $scope.cards.liked.push(liked);
  });

You can call functions in HTML as following:

Left

Right

will try it, thanks

Hi. I'm new to AngularJS and I'am having some trouble trying to swipe the cards from outside the Controller. I've already tried the @kuzdogan example but I think something's missing in my solution. Could you please provide an example in codepen?


Notification.requestPermission from iframe deprecated

The embedded ccp iframe attempts to call Notification.requestPermission directly and as a result we receive the following warning in Chrome console:
Using the Notification API from an iframe is deprecated and will be removed in M61, around September 2017. You should consider requesting permission from the top-level frame or opening a new window instead. See [https://www.chromestatus.com/feature/6451284559265792] for more details.
connect.NotificationManager.requestPermission @ lily_ccp_Prod_899828371c0911102feac318ba0a72696081e3ce.gz.js:sourcemap:23126
Is there a way to force CCP to perform the notification permission request in a separate window, instead of from within the iframe?

I'm also receiving this warning when testing on Linux, and I suspect it is related to a "Refused to display '' in a frame because it set 'X-Frame-Options' to 'sameorigin'" error preventing the site from working on Windows.

Take a look at https://github.com/aws/amazon-connect-streams/issues/25 for details about X-Frame-Options errors; it's likely not related to notifications.

Please feel free to reopen if the issue persists.

We are seeing this. on latest Edge machines...
on latest build
connect-streams-min.64acf415.js:1 [Deprecation] Permission for the Notification API may no longer be requested from a cross-origin iframe. You should consider requesting permission from a top-level frame or opening a new window instead. See https://www.chromestatus.com/feature/6451284559265792 for more details.


Update Region-Changing.txt

Why not? Guide is multilang now

make it "Choose a new language if needed"


Restrict extra parentheses inside argument list of a function call/definition/etc.

Things like console.log( "Hello world" ); are now prohibited.
While I was playing with #977 and the dependency it refers to, I noticed we allow these for now (but thankfully we have none in-repo).

Don't mind me, I'm useless.
#977 allows this indeed, but #975 that was created/merged after added this already :man_facepalming:


Missing ForEachAsync

I must be missing something as I am unable to build with DiscogsClient. I am receiving a compilation error related to ForEachAsync.
        var observable = _DiscogsClient.Search(discogsSearch);
        return observable.ForEachAsync(OnResult);

Exact error is below:
'IObservable' does not contain a definition for 'ForEachAsync' and no accessible extension method 'ForEachAsync' accepting a first argument of type 'IObservable' could be found (are you missing a using directive or an assembly reference?)
Latest version (2.3.0) is installed. Any idea what I might be missing? Any suggestions?

@Coffmans Did you restore the nugget packages?
If not please do it and rebuild.
If so did you update them?

I un-installed, removed the files, and re-installed the DiscogsClient nuget packages. AFAIK, the latest package is installed for the project.
DiscogsClient 2.3.0
RestSharp 106.5.4
RestSharpHelper 1.1.1
System.Reactive 4.1.2
After install of the nuget package, I am prompted with an update for System.Reactive. No difference after the update. Running VS2017.
Still no luck eliminating the compilation error.

I un-installed, removed the files, and re-installed the DiscogsClient nuget packages. AFAIK, the latest package is installed for the project.
DiscogsClient 2.3.0
RestSharp 106.5.4
RestSharpHelper 1.1.1
System.Reactive 4.1.2
After install of the nuget package, I am prompted with an update for System.Reactive. No difference after the update. Running VS2017.
Still no luck eliminating the compilation error.


introduce a handshake.Sealer interface

As suggested in https://github.com/lucas-clemente/quic-go/pull/493#discussion_r107360871

@lucas-clemente: Is this something you still want to do?

It's not something we need to fix before TLS 1.3.


[Aviraj] Added How to fractionalize NFT on Celo blog

https://trello.com/c/r5xSi8zU/91-how-to-fractionalize-an-nft-on-the-celo-platform


Multiple properties with the same name doesn't trigger an error

This seems like a situation that Flow should give an error:
/* @flow */
//jshint ignore:start

class Foo {
  a() {return 1}
  a() {return 2}
}

var o = {
  a: 5,
  a: 6
};

If the multiple properties have different types, Flow does give an error at least:
/* @flow */
//jshint ignore:start

class Foo {
  a(): number {return 1}
  a(): string {return 'b'}
}

$ flow

/private/tmp/foo/index.js:5:23,23: number
This type is incompatible with
/private/tmp/foo/index.js:6:8,13: string

Found 1 error

This is explicitly allowed in the ES6 spec, I believe due to computed properties. I do agree that this is probably unexpected behavior, though.
So far we've mostly been concerned with stronger correctness guarantees (won't blow up at runtime). I think this is a good candidate for some "extra" checks, like sorting an array of numbers without a comparator function, which are not strictly wrong but likely wrong.


argo token/url github token setup page

after inputing argo token and url it does not direct the users to home unless page is refreshed.
also it would be great to have options to change github token argo token after it has been setup since github/argo token could expire.

Resolved


Howto link ("Follow our guides") 404s

Reproduction Steps

Type ?
Click Follow our guides, which points to https://howto.excalidraw.com

Expected Behavior
I see a howto guide
Actual Behavior
404
Screenshots

I think you have an old version of Excalidraw. That link doesn't exist anymore.

Yep. Try hard-refreshing (Ctrl-F5 on Windows, for Mac Safari/Chrome, see https://apple.stackexchange.com/a/325876).


Exported executable crashes via Forward+ renderer

Godot version
v4.1.1.stable
System information
Windows 10 - Vulkan API 1.1.120 - Intel(R) HD Graphics 620
Issue description
When running .exe exported with Godot Editor in another machine, a window appears but nothing is drawn and the window closes automatically after a few seconds.
As far as I tried, I have confirmed that the .exe properly works if the file pipelines.cache exists in the folder %APPDATA%\Godot\app_userdata\${MyProject}\vulkan\.
And then, the following have been detected:

Download the Godot Editor of the same version (v4.1.1.stable) and import the source project of the .exe, then pipelines.cache was generated.
After that the .exe works with no problem in this case.
But when I delete pipelines.cache it becomes to crash again.
At the machine where I exported the .exe originally (Windows 11 - Vulkan API 1.3.250 - AMD Radeon(TM) Graphics), it works even if pipelines.cache is missing. (sometimes it is automatically generated)
It was OK when I switched the renderer of the project from "Forward+" to "Compatibility". (seems to use OpenGL instead of Vulkan)

Is that a matter of the version of Vulkan ?
Steps to reproduce

Export a project for Windows Desktop in Godot. Renderer config is set "Forward+". Export settings are the default.
Transfer the exported .exe (and .pck) to another environment (noted in "System information" above), where Godot development environment is NOT set up.
execute the .exe

Minimal reproduction project
It seems like the issue has nothing to do with the content of projects.
I made a very simple project just containing an empty main scene and export_presets.cfg. It will be enough to reproduce the event.
minimal_for_windows_export.zip

Can you run the exported project with console output enabled in the export preset, then look at the console output?


[question] Re-enabling the metrics-server after an installation

Environmental Info:
K3s Version: v1.23.6+k3s1
Node(s) CPU architecture, OS, and Version:

Linux k3s-1 5.10.0-15-amd64 #1 SMP Debian 5.10.120-1 (2022-06-09) x86_64 GNU/Linux
Linux k3s-2 5.10.0-15-amd64 #1 SMP Debian 5.10.120-1 (2022-06-09) x86_64 GNU/Linux
Linux k3s-3 5.10.0-15-amd64 #1 SMP Debian 5.10.120-1 (2022-06-09) x86_64 GNU/Linux

Cluster Configuration:

3 servers (control-plane,etcd,master)

Problem / Question:
I have a working k3s cluster with 3 nodes and all is fine and working perfectly well. However, when the cluster was first installed, a few options were passed to disable a number of features. Specifically: INSTALL_K3S_EXEC="--disable-cloud-controller --disable traefik --disable metrics-server --disable servicelb --bind-address <IP_ADDRESS> --cluster-init --tls-san <IP_ADDRESS>"
Today, I'm trying to find a way to re-enable the metrics-server as part of this existing cluster. However, I didn't find any relevant documentation. I looked at the K3s Server Configuration Reference and Disable Components Flags pages.
I also found that /etc/systemd/system/k3s.service uses --disable metrics-server but I'm trying to find a way to make the change persistent across upgrades as well, so I don't think this would be the correct way.
My questions are:

what is the recommended way to re-enable a feature that has been disabled during the installation?
how to ensure the change will be persistent across upgrades?

Thank you

I also found that /etc/systemd/system/k3s.service uses --disable metrics-server

Remove that flag from the systemd unit, then run systemctl daemon-reload and systemctl restart k3s .

@brandond I'll perform the change tomorrow and I'll keep you posted. I'm also planning in update to the latest 1.23.8 to make sure the procedure work with the assisted system-upgrade.


"add support for vllm api stop parameter"

What does this PR do?
Fixes #3114
Before submitting

[x] Did you read the contributor guideline?

Some necessary changes have been made and this pr can be merged


ignore malformed csv and surve only the correct tables

Discussed in the issue #31, and this is how I pass the malformed csv files.
It may confuse to user why some tables are not created and should find the reason from the log file.

Hey @daeho-ro , thanks for raising this PR!
I like the idea of making the CSV plugin easier to use, but as you had stated in this PR, I do have concerns that it may result in users not understanding why certain CSV files were not loaded. I think that before adding this behaviour, I would really like the ability to send warning messages in the terminal as per https://github.com/turbot/steampipe/issues/1090.
@kaidaguerre I'm not sure the level of effort required, so would you be able to estimate how long a feature like this would take? I think it would be useful not only in this case, but also in other plugins where being able to send a message in the terminal would be much more preferable to throwing errors/failing like we do today.

I think it is possible to give an option and then user can select the behavior how the plugin set the header. Maybe header option with the values always true or false and auto.

I have added an option to skip those errors,  so user can select it.
Furthermore, I have made another changes that is for the errors. Until now, when you met the error in the tableCSV, it is hard to find which CSV files are bad because the plugin only shows the error for a CSV. So, I collect the errors into a slice, and raise the error later which makes you can find all the errors from the log file.
Of course, the steampipe CLI can only shows an error and still need to be added the feature what you mention, but at least I want to add the logs for all bad CSV files.

@daeho-ro I've merged in https://github.com/turbot/steampipe-plugin-csv/pull/42, so I'm not sure if we need this config argument and feature, as I believe most of the file loading errors people experience today are due to incompatible headers.
Are there other common cases you've encountered where you've had issues loading invalid CSVs?

I have simplified the PR to be more convenient for debugging. There could be other cases such as the file is actually not a csv, or reading error and so on. This will help you to find which file is not suitable by running steampipe query just once.


Update to nextjs 9

HI there i ran the command npm i in order to install latest version of next js
but for now i can't run up the app...
did you tried the new version ?
Thanks
Carlos Vieira
npm run dev

><EMAIL_ADDRESS>dev /home/shintaro/Desktop/projects/github/frontend
> cd app && next

[ wait ]  starting the development server ...
[ info ]  waiting on http://localhost:3000 ...
> Using "webpackDevMiddleware" config function defined in next.config.js.
[ ready ] compiled successfully (ready on http://localhost:3000)
[ wait ]  compiling ...
[ ready ] compiled successfully (ready on http://localhost:3000)
[ event ] build page: /
[ wait ]  compiling ...
				^C
shintaro@shintaro-PC:~/Desktop/projects/github/frontend$ node
node     nodejs   nodemon
shintaro@shintaro-PC:~/Desktop/projects/github/frontend$ node
node     nodejs   nodemon
shintaro@shintaro-PC:~/Desktop/projects/github/frontend$ node app.js
> Using "webpackDevMiddleware" config function defined in next.config.js.
[ ready ] compiled successfully
[ wait ]  compiling ...
[ ready ] compiled successfully
[ event ] build page: /
[ wait ]  compiling ...

Hi @ShintaroNippon! I don't see any errors in the output above, can I get some more clarity on this? What errors are you facing?

Hi there. Thanks for the reply..
The issue os that I cant load the page... On localhost.
Ir status stuck where is the last line.
Thanks
Shintaro

Hmmm. Might need to dive in to check this.

Pleasev try to use the repositorry on my last issue and try to update please

HI there...
If i make npm run build
npm run build
><EMAIL_ADDRESS>build /home/shintaro/Desktop/projects/github/frontend
> cd app && next build

it gives this info and I cannot access to localhost
Creating an optimized production build ...

Compiled successfully.

Warning: You have opted-out of Automatic Prerendering due to `getInitialProps` in `pages/_app`.
Read more: https://err.sh/next.js/opt-out-automatic-prerendering

resources:
{ en: { translation: [Object] }, pt: { translation: [Object] } },
lng: 'en' }
Page                         Size     Files  Packages
┌ σ /                        17.7 kB     37        34
├   /_app                    56.5 kB      0        41
├   /_document
├   /_error                  337 B        0        34

σ  (Server)       page will be server rendered (i.e. getInitialProps)
⚡  (Static File)  page was prerendered as static HTML

can you help ? have an idea ?


Research

Prep charging methods (Kyrill)
Weighing down wires (Erik)
Check safety and efficiency (Jasper + Kalil)

Start the research (All)
Proces results (All)

Coils definitely will not be the choice that we will be going with, because of it's severe inefficiency.
Comparatively to the other options, the coils charges way too slow to be functional.

Research paper has been finished and submitted.

For the week; a presentation has to be made.


Swipe to dismiss image?

Is it possible to use swipe to dismiss an image? Something like twitter...

thank you for your idea
i will add in version 2


Change license to a more open one

@M0r13n, would you be happy for this code to be changed to a more open license such as MIT or GPL?
Kind regards,

Done. :-)


Aliased dependencies are not passed to transform when added to bundle via .require or .add

Repo demonstrating this issue

I noticed this issue when working with the browserify-shim transform, and reported in thlorenz/browserify-shim#152.
If there is a package.json anywhere in the path of an alias defined in the browser field, it will be treated as if it came from node_modules, and thus not passed to the transform.

*tumbleweeds*
*crickets*
Did you come up with a workaround?

In my particular workflow, I copied the aliased file to a temporary directory, ran Browserify, and then deleted the file. It was hacky, but it worked.


Additional properties

One should probably think about the names but:

Largest positive/negative value
Unit of least position (fixed)
Smallest positive/negative value (float)

One should maybe have two version of these in the case for floating-point, one for normal numbers and one for subnormal numbers?
E.g. something like this
x = APyFloat(0, 0, 0, exp_bits=4, man_bits=3)
x.max_pos_normal # 448
x.max_pos_subnormal # 0.875 * 2^-6
x.min_neg_normal # -2^-6
x.min_neg_subnormal # -2^-9

I have slightly changed my mind about these... Especially for floats it is not so obvious. However, for fixed-point a max and min property would make sense, as well as ulp.
But with that said, your suggestion makes sense. It would probably also be interesting to know the smallest normalized value as well. The sign one can probably ignore in the float case? (As it is pretty obvious...) Maybe ulp should be for that particular number and not the representation?

Hard to make it consistent for both float and fixed...

Yes the sign can probably ignored, otherwise the API might feel cluttered rather than consistent. Also, having the ulp for a particular number and not the representation makes sense like you suggest.
Maybe some of these should be available as static functions as well in the floating-point case? That way one wouldn't need to create an object just to find out some properties about a format.
APyFloat.max_normal(exp_bits, man_bits)
APyFloat.max_subnormal(exp_bits, man_bits)


Fixed README.md for Hooks

What:
Fixed README.md for Hooks.
Why:
There was no useState in import.
Checklist:

[x] Documentation added/updated
- [x] Typescript definitions updated (N/A)
- [x] Tests added and passing (N/A)
[x] Ready to be merged

review please.

@mrbinky3000 thank you for review. :)

:tada: This PR is included in version 1.27.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Update README.md

markerstart iso makerstart

Hello Els, well spotted. However I am working on issue #5. I will try to autogenerate the documentation using something like jsonschema2md. So this typo will be fixed anyway. By closing this PR, I am just preventing a merge error.


CiliumNetworkPolicy ToFQDNs behavior of * different from documentation

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I was digging into the API spec for FQDN Egress policies and I saw it mentioned that

As a special case a “*” as the leftmost character, without a following “.” matches all subdomains as well as the name to the right.

-reference
I wasn’t able to get this to work for me in practice. There didn’t seem to be any special behavior, it acted like a standard * expansion.
I wrote a rule which allowed traffic to *google.com. By the above comment, traffic to www.google.com should have been allowed (along with mail.google.com). However, none of those queries worked (you can see that the entries are in the per-EP caches, but they aren't in the policy map). Querying google.com though does work -- as expected.
Poking naively at the code (I think that’s the right place), doesn’t look like anything special is happening.
Most likely this is out-of-date documentation that should be fixed.
Cilium Version
1.11.6
Kernel Version
5.10.123+
Kubernetes Version
1.24.2
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

you are right, the API spec for FQDN Egress policies code comments really wrong.
*google.com will not match www.google.com or blog.google.com.

assign @wenhuwang

assign @wenhuwang


Can I embed WebVR into a gallery with multiple images?

I've got a simple gallery with say 10 images in. Is there a way of me embedding the WebVR HTML/CSS/JS into the existing project?

The short answer is - yes, but probably not easily.
The WebVR demo uses a custom WebVrView class, which in theory can be swapped in for the standardRectilinearView class used by generated tours. Attempting this would require a fair amount with familiarity with JavaScript and web development.
I cannot provide a step-by-step solution, although I'm happy to answer concrete questions that might come along.


How the chart will update with new data on select ng-change

I am writing an application where the charts needs to updated with new data if someone changes the value from the dropdown. How I can do this?

Try adding this attribute to your chart:
objectEquality="true"


Add ARMV8 SVE test using ArmIE

This would need updating to https://developer.arm.com/-/media/Files/downloads/hpc/arm-instruction-emulator/22-0/ARM-Instruction-Emulator_22.0_AArch64_Ubuntu_18.04.tar.gz now.
Closing for now as travis' charging policy remains too intransparent and apparently still far from finalized


Don't validate the launch token

Remove the code that validates a launch token by using it to
authenticate with the Bracket service.  This validation will break once
we decouple API tokens and launch tokens.

In the common case, launch tokens will be generated by Yeti, so they won't need to be validated.  If we need to validate user-generated launch tokens in the future, we'll need to add a separate Yeti endpoint and update the CLI to call it.


Custom global actions support

I would like to suggest to add a layout to support custom global actions. Here's the usecases:

Logout (my usecase at the moment)
Jump to the main site
Report a problem
View docs
Change password
View profile

Or any others defined by the developer. It is possible to add them on the separate div under the
...
. Or to the right-end of it.
Here's what Django has:

Well, I have found this new demo: http://demo2.exadmin.info/admin
It probably partially solves my question with Logout button. But it's still not clear about other possible actions.

Good idea. I'm wondering if this functionality should be added to config? The other option would be to add a separate with an appropriate DSL. At this time, I think config would be the way to go. Something like:
config :ex_admin,
  header_actions: [
    "Logout",
   "Docs"
  ]

Might also be nice to support a template:
config :ex_admin,
  header_actions: [
    template: {MyApp.AdminView, "header-actions.html"}
  ]

If we are doing this, then we should also support pull down menu item too...
Need to think about it a bit more.
@sobolevn Is this what you were thinking of?

Yes, you got my idea right. It don't think, that putting html in config is nice. But I like the DSL-way.

After more thought, I don't think a DSL is the way to go. At this point ExAdmin is not stateful except for the html dsl builder. Adding a new file with DSL would require state management that I don't think would any value over config.
I can see how some might not want to put html in the config file, but its not really an issue for me since I've done this several projects where I want to offer some minor branding configuration.
So, for those that don't like html in the config, we can support the template approach I presented above. If we also support the text option, then we can leave it up to the programmer on which approach they want to use.
The other option is to support issue #77 by allowing the programmer to copy and edit the layout file. This is not a trivial enhancement though...
Steve

Well, I got your point. I can help you with adding config options.
What branch is the latest one?

@sobolevn I've been developing on themes branch. After finished and pushed, I merge it into master. I'm tying to clean up the static files for the new themes. After I finish that, I'm going to move it to 0.7.4 branch and publish on hex.
Short answer themes branch :)


Spike Prime question

I am trying to get spike prime (version 3) to work, but I'm unable to connect. I see that the app isn't supported on Windows, but I can't get prime to work from a MacOS, either.
Are there plans to make the new spike hub available from Windows?

The extension is for SPIKE Prime version 2.x. I deprecate it today.
There is a plan to make a new extension for SPIKE Prime v3, but the development is a little bit hard. Please wait patiently.


Adding protected/private methods should generate a PATCH/MINOR level entry

PATCH for private methods.
MINOR for protected methods.

:+1:


Shorthand verbs don't work with webpack 5/jsbundling

I'm upgrade a Rails 6 application from using webpacker to jsbundling with webpack 5. I'm running into a very strange error where get, patch, post, etc result in a TypeError, while the FetchRequest class does not. The exact error is that <webpack module>.post is not a constructor.
I managed to reproduce the error in a simple test application using Rails 6 and then following the migration instructions from jsbundling. There's a simple form:
<%= form_for @item, method: :patch, html: {data: {controller: "ajax-button"}} do |form| %>
  <div class="form-check form-switch form-control-lg ms-3">
    <%= form.check_box :active, class: "form-check-input", role: "switch", data: {action: "change->ajax-button#submit"} %>
  </div> Active
<% end %>

This doesn't work:
import { Controller } from "@hotwired/stimulus"
import { get, post, put, patch, destroy } from<EMAIL_ADDRESS>
// Connects to data-controller="ajax-button"
export default class extends Controller {
  async submit(event) {
    event.preventDefault()
    event.stopPropagation()

    let payload = new FormData(this.element)
    const request = new post(this.element.action, { body: payload, responseKind: "json" })
    const response = await request.perform();
    if(response.ok) {
      return response
    }
  }
}

but this does:
import { Controller } from "@hotwired/stimulus"
import { FetchRequest } from<EMAIL_ADDRESS>
// Connects to data-controller="ajax-button"
export default class extends Controller {
  async submit(event) {
    event.preventDefault()
    event.stopPropagation()

    let payload = new FormData(this.element)
    const request = new FetchRequest('patch', this.element.action, { body: payload, responseKind: "json" })
    const response = await request.perform();
    if(response.ok) {
      return response
    }
  }
}

My package.json looks like this:
{
  "name": "test-jsbundling",
  "private": true,
  "dependencies": {
    "@hotwired/stimulus": "^3.1.0",
    "@hotwired/turbo-rails": "^7.1.3",
    "@rails/actioncable": "^6.0.0",
    "@rails/activestorage": "^6.0.0",
<EMAIL_ADDRESS>"^0.0.6",
    "@rails/ujs": "^6.0.0",
    "@rails/webpacker": "5.4.3",
    "turbolinks": "^5.2.0",
    "webpack": "^5.74.0",
    "webpack-cli": "^4.10.0"
  },
  "version": "0.1.0",
  "devDependencies": {
    "webpack-dev-server": "^3"
  },
  "scripts": {
    "build": "webpack --config webpack.config.js"
  }
}

And my webpack config looks like:
const path    = require("path")
const webpack = require("webpack")

module.exports = {
  mode: "development",
  optimization: {
    moduleIds: 'hashed',
  },
  devtool: "source-map",
  entry: {
    application: "./app/javascript/application.js"
  },
  output: {
    filename: "[name].js",
    sourceMapFilename: "[file].map",
    path: path.resolve(__dirname, "app/assets/builds"),
  },
  plugins: [
    new webpack.optimize.LimitChunkCountPlugin({
      maxChunks: 1
    })
  ]
}

@rcackerman Take another close look at Shorthand methods. Now compare that to your “This doesn’t work” code snippet, specifically the following bit:
const request = new post(this.element.action, { body: payload, responseKind: "json" })
const response = await request.perform();

The correct invocation looks as follows:
const response = await post(this.element.action, { body: payload, responseKind: "json" });

In the short version form you skip constructing a Request object, so you don’t need new …/request.perform() as the short versions do that for you.

@rcackerman Did you solve your problem based on @ur5us answer? I'll close the issue, but if you still are facing the problem we can reopen it, thank you!


AWS Roles

Hi,
Could you please add a section what rules you need when you use AWS Roles. The findings I have done these rules should work for a CloudWatch Logging in AWS.
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Sid": "AWSCloudTrailCreateLogStream",
      "Effect": "Allow",
      "Action": [
        "logs:DescribeLogGroups",
        "logs:DescribeLogStreams",
        "logs:CreateLogGroup",
        "logs:CreateLogStream",
        "logs:PutLogEvents"
      ],
      "Resource": [
        "arn:aws:logs:*"
      ]
    }
  ]
}

Thanks @egut , I added these to the readme


Avoid unecessary refresh of metadata

What does this PR do?
This make the stale time of the metadata queries to be infinity so they are always fresh this has the side effect that once you open a metadarta file you will not get updates made by others in that metadata file while in your session.
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you successfully ran tests with your changes locally? Including container validation.
[x] Have you lint your code locally prior to submission?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Have you labelled this PR correctly? E.G. major, milestone, breaking, breaking-change, minor, feature, enhancement, patch, fix, chore, refactor etc

What does this PR do?
This make the stale time of the metadata queries to be infinity so they are always fresh this has the side effect that once you open a metadarta file you will not get updates made by others in that metadata file while in your session.
All Submissions:

[x]  Have you followed the guidelines in our Contributing document?
[x]  Have you successfully ran tests with your changes locally? Including container validation.
[x]  Have you lint your code locally prior to submission?
[x]  Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x]  Have you labelled this PR correctly? E.G. major, milestone, breaking, breaking-change, minor, feature, enhancement, patch, fix, chore, refactor etc

will it still fetch latest when you move between pages?

can we hold off on merging - found another bug - testing to see if this PR fixes it.

will it still fetch latest when you move between pages?

Only if we manually invalidate the cache of the metadata once it is in cache will be in cache for until the garbage collector takes it. important to notice though that the version that ill be in cache it si the verrsion that was returned from the api. so if you open the spectrogram again it will be showing the version that is from the api not the version that you were working previously but did not save.

The bugs I found seem to be fixed.


PLT-1539: Remove Plutus Tx functions with Haskell.Monad constraint

I'm fine with removing these to make things look less weird (especially sequence_ and mapM_, which shouldn't be used anyway).
However, I still don't think we need our own Monad class. Rather, I'm in favor of removing our Applicative and Functor classes (and perhaps more) and use the Haskell ones, because.. why not? We don't have any instance of those classes whose definitions differ from the respective Haskell instances.
Some other classes, like PlutusTx.AdditiveSemigroup, exist for a good reason (for now): Integer's PlutusTx.+ differ from its GHC.Num.+, and the latter cannot be used ("for now" because they can be made to work in the future). I don't think this applies to Monad, Applicative and Functor.

We don't have any instance of those classes whose definitions differ from the respective Haskell instances.

We may not have the unfoldings for them, though?

We may not have the unfoldings for those, though?

The common ones to have unfoldings, I think. If there is indeed one that doesn't, newtyping it would be a more lightweight solution IMO.


Edge case usage: file grow from 3,5M to 8,1M

I just tried to figure out why cssnano works slow on my large stylesheet (I'm working with NetCat CMS' “85” template) and found some useful information I think.
~/Р/netcat-css (master) $ du -h output/styles.css
3,5M    output/styles.css
~/Р/netcat-css (master) $ postcss --local-plugins -u postcss-devtools -u cssnano --replace output/styles.css
output/styles.css
postcss-discard-duplicates  31 s
postcss-minify-selectors    747 ms
postcss-merge-rules         287 ms
postcss-colormin            279 ms
autoprefixer                129 ms
postcss-convert-values      81 ms
postcss-discard-comments    56 ms
postcss-merge-longhand      55 ms
postcss-unique-selectors    52 ms
postcss-normalize-url       37 ms
postcss-discard-unused      27 ms
cssnano-function-optimiser  24 ms
postcss-svgo                22 ms
postcss-minify-gradients    19 ms
postcss-zindex              19 ms
postcss-normalize-charset   17 ms
postcss-reduce-idents       17 ms
cssnano-reduce-positions    17 ms
postcss-ordered-values      16 ms
postcss-minify-params       11 ms
postcss-merge-idents        11 ms
postcss-reduce-transforms   9.1 ms
postcss-minify-font-values  8.47 ms
cssnano-core                8.45 ms
postcss-calc                6.28 ms
postcss-discard-empty       5.7 ms
cssnano-filter-optimiser    5.02 ms
postcss-filter-plugins      264 μs
cssnano-reset-stylecache    82 μs
~/Р/netcat-css (master) $ du -h output/styles.css
8,1M    output/styles.css

Stylesheet grow from 3,5M to 8,1M
postcss-discard-duplicates works extremely slow

@Grawl I've revisited this issue - tried concatenating all of the CSS from netcat, it now loses ~1MB, plus we reduced the running time for postcss-discard-duplicates. Please feel free to reopen if you can still reproduce, for now I'm going to mark as resolved.

Yes, it was just one postcss-discard-duplicates plugin. All drama is here: https://github.com/ben-eb/postcss-discard-duplicates/issues/9


[BUG] Can't download via aurora store?

Hey guys I have a pixel 7 pro with graphene installed and I can't seem to download amethyst. Aurora says app not purchased.
And fdroid gives out error 404.
Can someone help me?

No idea what Aurora is, but you can download the apk from the repo:
https://github.com/vitorpamplona/amethyst/releases
Or use Obtainium to download the apks https://github.com/ImranR98/Obtainium
On Sat, Jun 10, 2023 at 7:48 PM aeon3 @.***> wrote:

Hey guys I have a pixel 7 pro with graphene installed and I can't seem to
download amethyst. Aurora says app not purchased.
And fdroid gives out error 404.
Can someone help me?
—
Reply to this email directly, view it on GitHub
https://github.com/vitorpamplona/amethyst/issues/450, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEB4P7QASFZ5QITBXFO45LXKUBWXANCNFSM6AAAAAAZB6ZU7M
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Vitor [Veetor] Pamplona
Founder & CEO | EyeNetra http://eyenetra.com Inc
CTO | PathCheck http://pathcheck.org Foundation
President | SciBr http://scibr.org Foundation
Mobile: +1<PHONE_NUMBER> | @.***
This email message is confidential. Any review, dissemination, distribution
or copying of this message is strictly prohibited.

Aurora is getting blocked by google.
You should use grapheneos play services or Obtainium