Blood Pressure Units Flag calculated incorrectly

OS version: Android 14
Device: Samsung A52
Blessed-android-coroutines: 0.4.2
The Blood Pressure Units Flag is calculated incorrectly in file BloodPressureMeasurement.kt.
Suggested fix:
In file com.welie.blessedexample.BloodPressureManagement.kt line 25:
Change unit calculation
From:
  val unit = if (flags and 0x01 > 0) ObservationUnit.MMHG else ObservationUnit.KPA
To:
  val unit = if (flags and 0x01 > 0) ObservationUnit.KPA else ObservationUnit.MMHG
Reason:
https://bitbucket.org/bluetooth-SIG/public/src/main/gss/org.bluetooth.characteristic.blood_pressure_measurement.yaml
The BloodPressureMeasurement characteristic from the YAML file defines the Blood Pressure Units Flag as follows:

<...>
fields:
- name: Flags
description: |-
These flags define which data fields are present in the characteristic value.
The bits of this field are defined below.
values:
- bit: "0"
description: |-
Blood Pressure Units Flag
0 = Blood pressure for Systolic, Diastolic and MAP in units of mmHg
1 = Blood pressure for Systolic, Diastolic and MAP in units of kPa
<...>

Verified using Omron Model BP5450.
Might this problem exist in other Blessed repositories?

Looks like I fixed this in the other Blessed libraries but not in this one......see for example https://github.com/weliem/blessed-kotlin/blob/main/app/src/main/java/com/example/blessed3/BloodPressureMeasurement.kt#L35
Will fix it

Fixed by 67ceddd


Multi-root: Excluded file opens under wrong root

Issue Type: Bug
I have a multi-root project setup in the following way:

Project folder including all sub folders except subproject1 folder
Subproject1 folder

When I open up a file located under subproject1 folder, the whole subproject1 folder gets collapsed in the explorer view and the opened file is shown under the main project root folder even though it is supposed to be excluded from it.
VS Code version: Code 1.44.0 (2aae1f26c72891c399f860409176fe435a154b13, 2020-04-07T23:31:18.860Z)
OS version: Windows_NT x64 10.0.19041

If I have the main project root folder collapsed and only the subproject1 folder revealed in explorer view, the opened files appear under the subproject1 folder.

Yeah, happens here as well even with all extension disabled.
Basically I have a structure with a project root directory, beneath a client/ and a server/ directory.
Now whenever I open an file under client/ or server/ it shows up in the project root folder too, plus the folder structure of where that file is.
When using Ctrl+P to navigate quickly, the explorer drawer annoyingly jumps around as well.
The entry disappears instantly once I close any of the files erroneously showing up there.

Same issue here
The issue only occurs for folders located in the root project directory, so say you have
"folders": [{ 	"path": "folder/subfolder" }] then the folder will not collapse, however it will still be shown in the wrong root
Until this gets resolved, i recommend just commenting out the files.exclude section that excludes folders located in the root, as it is at least usable in this configures, though the folders will be shown twice.

I think this issue is erroneously categorized, it clearly results in buggy behavior to me which earlier versions of vscode didn't have.
Should be labelled as a bug.

Yes, this is a regression, it worked in earlier builds but not after 1.44.0.

Until this gets resolved, i recommend just commenting out the files.exclude section that excludes folders located in the root, as it is at least usable in this configures, though the folders will be shown twice.

Correction to my earlier statement.
If you require that your project is split into multiple roots, for things like gopls to work in a go module project, then there is nothing to do outside downgrading to a version < 1.44

@isidorn Can you correct the issue filing please? This is a bug, not a feature request.

Yes. Just did that. Thanks

Also bumped into this issue. It definitely is a regression as I used it before to work with Go projects that have multiple modules as it is the only workaround to get it to work. Unfortunate that it no longer works. https://github.com/golang/go/issues/32394
I made a repository that can reproduce this behaviour with a recording of it in action: https://github.com/AndreasBackx/vscode-exclude-bug

Yes. This is really annoying when working with deeply nested projects.

Version: 1.47.0-insider (user setup)
Commit: 6c235c723cb2d8defb840f732eac620f54aa8b9d
Date: 2020-06-26T06:20:06.931Z (1 hr ago)
Electron: 8.3.3
Chrome: 80.0.3987.165
Node.js: 12.13.0
V8: 8.0.426.27-electron.0
OS: Windows_NT x64 10.0.18363
expand_collapse.zip

A "workable" solution is to move all your subproject folders into folder under the root project
So if you have a project looking like this
./project
  ./subproject1
  ./subproject2

Then you can change it to this (remember to update .vscode/settings.json & project.code-workspace if used)
./project
  ./submodules/subproject1
  ./submodules/subproject2

Now when opening a file in one of the subprojects, it will not close the subproject folder on you

Isn't "out-of-scope" the wrong way to close a bug report, according to the 'decision making process' link? That probably should be "Won't fix", to make it clear that a regression bug has been decided to be kept, rather than treating it as a feature request that is not in scope.

Observing the exact same issue.
I looked around in the repo issues, and tried to add files directly as an alternative (https://github.com/microsoft/vscode/issues/45177). I have to say that the number of valid and researched issues marked as "out-of-scope" on the subject of multi-root is worrying.
More transparency and explanations regarding those issues would be more helpful than just rejecting all those issues. There is a clear lack of support on multi-root workspaces, and it's hard to know wether to invest or not in this tool right now.


Variant annotations plus tests

(includes classes that are not supposed to be reviewed and added here only to compile and make tests pass. Those classes are being reviewed in other pull requests. I'll mark them on github)

@ldgauthier Can you help review the annotation classes and tests?

I've reviewed all the things I have a vested interest in, so I'm assigning it back @akiezun


Imrpove docstrings

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (1fb0a0e) to head (2156310).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #619   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           71        71
  Lines         1896      1896
  Branches       225       225
=========================================
  Hits          1896      1896

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New TCP fallback example

This PR adds a new example that shows how to setup a client and server to communicate over QUIC and fallback to TCP if the connection cannot be established.
Once merged, I'll create the Protobuf equivalent of this example.
See also: https://github.com/orgs/icerpc/discussions/12

Sample output:
Server
dbug: IceRpc.Server[11]
      Listener 'icerpc://[::0]?transport=quic' has started accepting connections
dbug: IceRpc.Server[11]
      Listener 'icerpc://[::0]?transport=tcp' has started accepting connections
dbug: IceRpc.Server[0]
      Listener 'icerpc://[::0]?transport=quic' accepted connection from '<IP_ADDRESS>:36147'
dbug: IceRpc.Server[3]
      Server connection from '<IP_ADDRESS>:4062' to '<IP_ADDRESS>:36147' connected
Dispatching greet request { name = 'vscode' }
dbug: IceRpc.Server[6]
      Server connection from '<IP_ADDRESS>:4062' to '<IP_ADDRESS>:36147' shutdown
dbug: IceRpc.Server[5]
      Server connection from '<IP_ADDRESS>:4062' to '<IP_ADDRESS>:36147' disposed
^Cdbug: IceRpc.Server[12]
      Listener 'icerpc://[::0]?transport=quic' has stopped accepting connections
dbug: IceRpc.Server[12]
      Listener 'icerpc://[::0]?transport=tcp' has stopped accepting connections

Client
vscode ➜ .../examples/slice/TcpFallback/Client (tcp-fallback) $ dotnet run
info: IceRpc.Logger.LoggerInterceptor[0]
      Sent request greet to icerpc:/VisitorCenter.Greeter over <IP_ADDRESS>:36147<-><IP_ADDRESS>:4062 and received a response with status code Ok

Client with Secure server
vscode ➜ .../examples/slice/TcpFallback/Client (tcp-fallback) $ dotnet run
info: IceRpc.ClientConnection[0]
      Failed to connect to server using QUIC, falling back to TCP
      IceRpc.IceRpcException: An IceRpc call failed with error 'ServerUnreachable'.
       ---> System.Net.Sockets.SocketException (0x00000071): No route to host
         at System.Net.Quic.QuicConnection.HandleEventShutdownInitiatedByTransport(_SHUTDOWN_INITIATED_BY_TRANSPORT_e__Struct& data)
         at System.Net.Quic.QuicConnection.HandleConnectionEvent(QUIC_CONNECTION_EVENT& connectionEvent)
         at System.Net.Quic.QuicConnection.NativeCallback(QUIC_HANDLE* connection, Void* context, QUIC_CONNECTION_EVENT* connectionEvent)
      --- End of stack trace from previous location ---
         at System.Net.Quic.ValueTaskSource.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
         at System.Net.Quic.QuicConnection.FinishConnectAsync(QuicClientConnectionOptions options, CancellationToken cancellationToken)
         at System.Net.Quic.QuicConnection.<ConnectAsync>g__StartConnectAsync|2_0(QuicClientConnectionOptions options, CancellationToken cancellationToken)
         at System.Net.Quic.QuicConnection.<ConnectAsync>g__StartConnectAsync|2_0(QuicClientConnectionOptions options, CancellationToken cancellationToken)
         at IceRpc.Transports.Quic.Internal.QuicMultiplexedClientConnection.ConnectAsync(CancellationToken cancellationToken) in /workspaces/icerpc-csharp/src/IceRpc.Transports.Quic/Internal/QuicMultiplexedConnection.cs:line 140
         --- End of inner exception stack trace ---
         at IceRpc.Transports.Quic.Internal.QuicMultiplexedClientConnection.ConnectAsync(CancellationToken cancellationToken) in /workspaces/icerpc-csharp/src/IceRpc.Transports.Quic/Internal/QuicMultiplexedConnection.cs:line 150
         at IceRpc.Internal.IceRpcProtocolConnection.<>c__DisplayClass36_0.<<ConnectAsync>g__PerformConnectAsync|0>d.MoveNext() in /workspaces/icerpc-csharp/src/IceRpc/Internal/IceRpcProtocolConnection.cs:line 139
      --- End of stack trace from previous location ---
         at IceRpc.Internal.IceRpcProtocolConnection.<DisposeAsync>g__PerformDisposeAsync|37_0() in /workspaces/icerpc-csharp/src/IceRpc/Internal/IceRpcProtocolConnection.cs:line 280
info: IceRpc.Logger.LoggerInterceptor[0]
      Sent request greet to icerpc:/VisitorCenter.Greeter over [::ffff:<IP_ADDRESS>]:39964<->[::ffff:<IP_ADDRESS>]:4062 and received a response with status code Ok
Hello, vscode!

I think this code would be simpler to do the connection creation all in line with the rest of the code.

I can't find a way to write this in an elegant manner. Give it a try!

For consistency it might also be interesting to connect the tcp connection before giving it to the pipeline.

I don't see the point - it would add lines of code for no clear purpose.

I think another option would be to use a model similar to our connection cache that hands out the connection during dispatch.

There are naturally several options on the client-side. I am trying here to do the simplest/clearest.


DuckDB scalability and stability improvements

In prioritized order:

[x] Support ingesting SQL sources in smaller batches (and make batch size configurable in YAML) (PR)
[x] Detaching attached DBs before we reopen/close handles to prevent a memory leak + do a cherry-picked patch release
[x] Investigate performance discrepancy with DuckDB CLI – write a Go script using go-duckdb with just one open connection to test the performance difference
[x] Cap rill_pool_size at a number around 10, regardless of CPU count
[x] Enable overriding memory and threads and pool size using rill env set (memory_override, threads_override, pool_size_override)
[x] https://github.com/rilldata/rill/issues/3297 (test only in staging)
[x] Try replicating the DuckDB memory leak C snippet on a Kubernetes pod
[x] Prevent any concurrent writes, even "drop table if exists" (which might be called concurrently by other reconcilers)
[x] Do an audit of major projects to check for sub-optimal / problematic configurations – check and compare slots assignments, threads/memory ratios, DB file size, external_table_storage, disable_thread_limit and __materialize_default
[x] Support ingesting string columns as enum values
[ ] Support serving data from local SDD with a persistent backup in GCS (mounted as disk, and configured using driver config variables)
[x] https://github.com/rilldata/rill/issues/3341
[ ] https://github.com/rilldata/rill/issues/3332
[ ] https://github.com/rilldata/rill/issues/3323 (temporarily addressed in this PR)

Investigate performance discrepancy with DuckDB CLI – write a Go script using go-duckdb with just one open connection to test the performance difference

There is no difference in performance when using go-duckdb single connection and rill. Both are ~10% faster than cli.

Try replicating the DuckDB memory leak C snippet on a Kubernetes pod

@begelundmuller didn't see any memory leak on k8s pod as well. Looking at the answer on go-duckdb here specifically this part if you leave a connection, prepared statement or appender open, the connection/prepared statement/appender will keep a reference to the database object and the database will not be destroyed.
What I see is that as soon as I do a RenameTable in my script memory usage goes down (since all DBs get dettached due to tx=true call) however when observing this on production I don't see memory usage going down so I am suspecting we could be leaking something here(may be in some error cases). I am also reviewing driver code again.

however when observing this on production I don't see memory usage going down

Okay this could be just different behaviour(either top command or duckdb) on linux/mac. I reproduced same behaviour on duckdb cli but memory usage never crosses the limit.

Support ingesting string columns as enum values

So I deployed one project with full dataset and converted to enum.
This is definitely faster when doing side by side comparison even when running with 65 slots on new dashboard vs 85 slots on old dashboard.
So there is 100% a case for enum conversion.
But the cause of worry and blocker in rolling this out is that the refresh took 64 minutes out of which last ~45 minutes were just spent doing ALTER with temp file increasing to even 110GB.
Instead of doing ALTER we can directly write to a new db file. It ran much faster as well as reduced the db file size.
Ran in ~14 minutes and db file size reduced from ~180GB to ~110GB.

Performance numbers using k6 load-test:
On db size ~180GB, 130GB memory and 16 threads:

On first load (no memory mapping) enum casted data is 15% faster. It is 22% faster when instead of doing ALTER db we rewrite db file.
When data has been memory mapped dashboard loads in almost similar time(in fact enum casted data is slower possibly bcz of increased db size). However it is 12% faster when checking with rewritten db file(again possibly due to reduced db size).

cc : @nishantmonu51 @begelundmuller

Closing and moving last three subtasks to separate issues.


!!!TEST!!! Make test fail to test CI process !!!DO NOT MERGE THIS PR!!!

Testing the new CI process.

It is only compiling @JesperSchulz  :) not running tests

It is only compiling @JesperSchulz  :) not running tests

Tests are not run yet. Build process succeeded.

Tests are not run yet. Build process succeeded.


Fix jest nuxt setup

What changed

added .babelrc with @babel/preset-env preset for test.
add dev dependency to @babel/preset-env
add testEnvironmentOptions to jest.config.js

Testing instructions
run yarn test and everything should be green.

@ermish sadly, it seems something is still off with the jest setup. Jest does not seems to be able to resolve the other components when testing a full page.

console.warn
      [Vue warn]: Failed to resolve component: Media
      If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.
        at <Anonymous ref="VTU_COMPONENT" >
        at <VTUROOT>

      37 |

      at warn (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:40:17)
      at resolveAsset (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:2847:13)
      at resolveComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:2796:12)
      at Proxy.render (pages/index.vue:39:28)
      at renderComponentRoot (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:885:44)
      at ReactiveEffect.componentUpdateFn [as fn] (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5538:57)
      at ReactiveEffect.run (node_modules/@vue/reactivity/dist/reactivity.cjs.js:189:25)
      at instance.update (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5652:56)
      at setupRenderEffect (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5666:9)
      at mountComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5448:9)
      at processComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5406:17)
      at patch (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5010:21)
      at ReactiveEffect.componentUpdateFn [as fn] (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5545:21)
      at ReactiveEffect.run (node_modules/@vue/reactivity/dist/reactivity.cjs.js:189:25)
      at instance.update (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5652:56)
      at setupRenderEffect (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5666:9)
      at mountComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5448:9)
      at processComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5406:17)
      at patch (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:5010:21)
      at render (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:6166:13)
      at mount (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4404:25)
      at Object.app.mount (node_modules/@vue/runtime-dom/dist/runtime-dom.cjs.js:1539:23)
      at mount (node_modules/@vue/test-utils/dist/vue-test-utils.cjs.js:8333:18)
      at Object.<anonymous> (test/pages/index.spec.js:6:25)

For individual component, jest does not seem to be able to detect/process assets correctly:

/home/olivier/workspace/findadoc-web/assets/images/homepage/findadoc-boostershot-wiki.png:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,jest){�PNG

    SyntaxError: Invalid or unexpected token

      3 |          The open-source project that's helping Japan get vaccinated
      4 |

    > 5 |
      7 |

      8 |

      at Runtime.createScriptFromCode (node_modules/jest-runtime/build/index.js:1678:14)
      at Object.require (components/Welcome.vue:5:39)
      at Object.<anonymous> (test/components/Welcome.spec.js:2:1)

Interesting 🤔 I'll take a look when I get home

hmmm, I’ve spent the last hour working through this...I did some investigation on this and it looks like the babel approach is more common but using ts-jest provide type checking. Details here Ultimately, Using jest + vue3 + typescript  seems really flaky (even if you're not using typescript)
Proposal
I'm proposing that we should just skip jest unit tests for components and stick with cypress e2e tests and unit/integration tests around pinia store files. This is where our actual actions, mutations, and business logic that actually needs testing is and it's technically Vue agnostic, hence removing all of our pain points.
@ann-kilzer @theyokohamalife @RageZBla thoughts?

Created #88 in relation to the proposal above


bgpv2: Fix description of Selector behavior in CiliumBGPAdvertisement CRD

Fixes documentation bug in the CiliumBGPAdvertisement CRD: the actual implementation as well as the intention is to not advertise any prefixes if the Selector in CiliumBGPAdvertisement CRD is not specified.

/test


dialogs fail to implement getitem

This is a tad puzzling and for now just an empirical observation (I haven't drilled into the code to find out why).
But basically I I have a an app, and I can open a dialog box in that app and on that dialog box is a Help button. I want to fetch me that button and observe:
app.top_window()["Help"]
works fine.
but that's rather uncool in a sense as the Help button is on the dialog on on the top window so trying to do it better:
dialog = app.top_window()["DialogTitle"]
is totally fine and returns me the dialog. Then:
dialog["Help"]
bombs with:
AttributeError: The control does not have a __getitem__ method for item access (i.e. ctrl[key]) so maybe you have requested this in error?
but:
dialog.Help
returns the button!
Inconsistent behaviour and traps me a bit. I can't use attributes as in my code I do't know it's called Help at that point, it's in a variable, and I can find the button from the top_window using the dictionary access method but that's not kosher (if there are any ambiguities, other windows open with help buttons, I'm in trouble) but form the dialog I cna't use the dictionary access method.
For now, my work around is to use the top_window().

This is already tracked in #570 targeted for next major release.


feat: inbox optimisations

Currently the inbox is deploying an entirely new contract to hold the tree. This is super wasteful and we should update such that all the trees live in just a single contract similar to the outbox such that the cost of going to a new tree is not as crazy high as it is here.

This was addressed in #8172


Upload Wheel releases to Pypi

Hi
it seems the wheel files are not uploaded to pypi https://pypi.org/project/xmlsec/1.3.3/#files but this would be a great distribution channel, as it would allow pip to pull the binary releases directly from there instead of requiring the user to download them from the provided link.

+1 Please provide updates in channel

A new version 1.3.7 was released today. One of the notable changes includes pushing prebuilt wheels for Windows on PyPI, so the issue with building Windows wheels locally should be resolved. Install as usual:
pip install xmlsec

Should you experience any issues with prebuilt wheels on Windows, please don't hesitate to open a new issue.


check whether -zt (Coord object) yields minus values

Yes, this is the case: (-zt).value equals -zt.value (using np.array_equal). This is now a unit test. Note that there were similar existing unit tests for the dual.


CDD-1823: Removed customs-dit-licences from old build

Can we please unsubscribed me to recieve alll these emails
On Thu, Oct 11, 2018 at 10:54 AM Matthew Clark<EMAIL_ADDRESS>wrote:

You can view, comment on, or merge this pull request online at:
https://github.com/hmrc/jenkins-jobs/pull/889
Commit Summary

CDD-1823: Removed customs-dit-licences from old build

File Changes

M jobs/ci_open_jenkins/build/customs.groovy
https://github.com/hmrc/jenkins-jobs/pull/889/files#diff-0 (3)

Patch Links:

https://github.com/hmrc/jenkins-jobs/pull/889.patch
https://github.com/hmrc/jenkins-jobs/pull/889.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hmrc/jenkins-jobs/pull/889, or mute the thread
https://github.com/notifications/unsubscribe-auth/ANhikq-2UUqoc9g23ctkPc3wqHARIKDGks5ujxVhgaJpZM4XXMB6
.


check the return value of BIO_new()

Check the return value of BIO_new() in t_x509.c:471 & cmp_vfy.c:36 in time to prevent further memory errors.

This pull request is ready to merge

Merged to 3.0 and master, thanks for the contribution.


quality check for input data

Original report by Reimar Bauer (Bitbucket: ReimarBauer, GitHub: ReimarBauer).

We need a check routine which verifies data provided to a server setup that setup matches to data.

There are a lot of checks in the current DataAccess class, which gives pretty good info on what has been identified and what isn't standard-conformant.


Appstudio update test-component-pac-qhep

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: test-component-pac-qhep-on-pull-request-
creating pipelinerun test-component-pac-qhep-on-pull-request- in namespace build-e2e-jqws-tenant has failed.
Tekton Controller has reported this error: the namespace of the provided object does not match the namespace sent on the request

Pipelines as Code CI/test-component-pac-qhep-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
25 seconds
sast-snyk-check

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
35 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
38 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
18 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-qhep-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
25 seconds
sast-snyk-check

✅ Succeeded
1 minute
inspect-image

✅ Succeeded
35 seconds
deprecated-base-image-check

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
38 seconds
clamav-scan

✅ Succeeded
18 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary


Agent for i386 architecture

Is there a way to run the rancher agent on an i386 architecture? Did anyone tried this before?

Thanks for your report!
With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.
If you think we should keep this issue open, please let me know.


Add ConsoleGrid nickname to consoles.txt

ConsoleGrid requires certain nicknames for certain consoles, so allow the user to manually specify the nickname that consolegrid needs (so they can name their folders something else)

Is this still ongoing? Having to name your folders to something specific just for Ice is something of a blocker.

Ping.

Still an issue I presume? as i couldnt fetch images unless I renamed my rom folder to match what consolegrid wanted.


Change Parsing of JSON objects from try/catch to explicit

Refactor all code to use the same approach as parsing JSON in dashboard parsing

Fixed in d26c4d64bb1dfb895a110ecf182ac7340e877d72


Update dynamic-fee pallet

sp-inherents was refactored.
https://github.com/paritytech/substrate/pull/8526

I did update this in our fork https://github.com/webb-tools/frontier and put up a PR: https://github.com/paritytech/frontier/pull/395


[v4] Redirect always rendered, even if from prop provided.

Version
4.0.0-beta.6
Steps to reproduce
1. Minimal required setup
function Place() {
  return
Place

}

function AppRouter() {
  return (
    <Switch>
      <Redirect from='/old-path' to='/new-path'/>
      <Route path='/new-path' component={Place}/>
    </Switch>
  )
}

2. Navigate to /old-path
Expected Behavior
Redirect from /old-path to /new-path, get Place component rendered.
Actual Behavior
Redirected from /old-path to /new-path, nothing gets rendered (or Redirect gets rendered instead)

@Andreyco <Redirect from> was added after the beta 6 release.

Feel free to close, or I will when there is new released published. TY for info ✌


Refactor rank types of celebrations

Improve code readability for rank types of celebrations.
eslint: better es6 and Babel support.

resolve #109
this will help to move forward on #110
@jarosz, I worked on it last night, and when I opened a PR today I discovered your work here. Our contributions was very close (extend an Array instead of using a Map object, to offer syntactic sugar). And I've include some of your code comments and the way you declare new type properties 👍 (with the writable: false).
Thank you very much for your contribution. I've added you as a co-author of this commit 😉

I’ll review this in the evening.
However, I’d suggest that we should always assign an issue to ourselves to eliminate duplicate work, and even probably note this in a comment.

Good point @tukusejssirs, we have to use the assignments feature to avoid these situations again.


Singleton Pattern Dangerous?

I love what you've done here, and I'm trying to use this in a django project, but the singleton pattern really worries me.
Say you have 2 different users that each connect to their own QuickBooks account. Say those 2 users connect to the django website at roughly same time. The first user who hits the page, will connect his quickbooks account, and will be about to do some operation. The second user will then need to connect his quickbooks account, which then changes the tokens on the singleton object to his own tokens. If the first user is just about to do his operation, all of a sudden, that operation will be done on the second user's quickbooks account. VERY BAD.
Am I misunderstanding this? As far as I know, you almost never want to have global variables in a django project because django is a long-running process. Those global variables will stick around between requests, AND between users/sessions.
I am thinking about forking this project, and refactoring it to not use singletons, because I love how everything else in the project is done.

I believe you are correct. The project I designed the library for, uses only one QuickBooks account so I have never encountered this issue. There is a pull request that fixes the problem (https://github.com/sidecars/python-quickbooks/pull/15). I will work on getting it merged in.

Ah, that pull request is exactly what I'm looking for. I will use that fork until it gets merged in

This would be amazing, if it were implemented, my fix is still waiting for implementation though also

I can confirm that this singleton pattern is indeed a big problem. I'm currently using this library in a project, and I'm running into a similar but even more common problem.
If 2 users independently authorize their quickbooks accounts within my application, the first user to authenticate will always have their realm id used in api requests, regardless of which user is trying to make api calls.
@jproffitt is there a reason a singleton pattern is needed here, or will simply removing this new line be sufficient to fix this?

@zimkies I don't believe removing that line will fix it. It will indeed "reset" itself every time you initialize the class, but it will reset it for every user using the application at the same time. So if one user does an action that initializes the class, then another action to do some work. Then at the same time, another user does the action to initialize the class, it will reset the class for the first user as well. Since all users will still be sharing the same class.
Basically, removing that line may help a little bit, if you always re-initialize the class before each quickbooks call, but there is still a major problem if 2 users try to initialize the class at roughly the same time.
I believe in general, singleton patterns should never be used in long-running or multi-thread projects like django.
I think the best way to fix this is exactly what this PR does: https://github.com/sidecars/python-quickbooks/pull/15. Pass around a unique quickbooks instance to every QB call.

@jproffitt thanks a lot for the insight, I had a feeling that was the case. I guess we'll go ahead and use your fork for now, thanks for submitting that fix.

@zimkies you're welcome. But that is not my fork, it is @peterlai fork. I have not used the fork yet, so I am not sure it works, but looking just looking at it, it seems to be the correct solution.

it seems so strange that after a month this is still at large, even though it's a pretty serious issue. Given most of the work is already done, and some failing tests need to be fixed, I would be more than happy if this were to be closed already.

Updated last night. Enjoy!


iOS  No member named 'delayedUnsafe' in 'folly::Futurefolly::Unit'

SonarWebSocketImpl.cpp
line 102&187  .delayedUnsafe(std::chrono::milliseconds(0))
No member named 'delayedUnsafe' in 'folly::Future<folly::Unit>')

The current master branch is broken you can refer to podspecs in Fix-Broken-iOS-OSS branch.
Use the following code snippet in your podfile

target 'Sample' do

  pod 'RSocket', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/third-party-podspecs/RSocket.podspec'
  pod 'DoubleConversion', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/third-party-podspecs/glog.podspec'
  # pod 'CocoaLibEvent', '~> 1.0'
  #:podspec => 'https://raw.githubusercontent.com/facebook/Sonar/master/iOS/third-party-podspecs/glog.podspec?token=ADr9NImskgi8eZGAADCQH2_PXtgB7-b-ks5bIDrowA%3D%3D'
  pod 'Folly', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/third-party-podspecs/Folly.podspec'
  pod 'PeerTalk', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/third-party-podspecs/PeerTalk.podspec'
  pod 'Yoga','~>1.8.1', :modular_headers => true
  pod 'Sonar', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/xplat/Sonar/Sonar.podspec'
  pod 'SonarKit', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/SonarKit.podspec'
  pod 'SonarKit/SonarKitLayoutComponentKitSupport', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/SonarKit.podspec'
  pod 'SonarKit/SKIOSNetworkPlugin', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/SonarKit.podspec'
  pod 'ComponentKit', :podspec => 'https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/third-party-podspecs/ComponentKit.podspec'
  post_install do |installer|
        installer.pods_project.targets.each do |target|
            if ['YogaKit'].include? target.name
                target.build_configurations.each do |config|
                    config.build_settings['SWIFT_VERSION'] = swift_version
                end
            end
        end
    end

end

Closing it for now, as the above change should fix it. If not please reopen the issue

thx

Not working:
[!] Failed to fetch podspec for ComponentKit at https://raw.githubusercontent.com/facebook/Sonar/Fix-Broken-iOS-OSS/iOS/third-party-podspecs/ComponentKit.podspec.  Error: 404 Not Found

Not working
-> Fetching podspec for ComponentKit from https://raw.githubusercontent.com/facebook/Sonar/master/iOS/third-party-podspecs/ComponentKit.podspec
[!] Failed to fetch podspec for ComponentKit at https://raw.githubusercontent.com/facebook/Sonar/master/iOS/third-party-podspecs/ComponentKit.podspec.
Error: 404 Not Found


Allow adding a points layer with data of shape (A, B, ..., N, 2)

🚀 Feature
Accept arrays with shape (A, B, .., N, D) to add_points
Motivation
I have arrays of point locations with shapes like (S, T, N, YX) I'd like to be able to easily turn these into a points layer.
Pitch
If data.ndim>2 automatically convert the data using the leading array indicies to fill in the first columns of the array. I've been using this function:
def points_from_array(locations: np.ndarray):
    """
    Convert multidimensional array of points and convert to napari-point-format

    Parameters
    ----------
    locations : array-like
        With shape (A, B, C,..., N, 2).
        The the last dimension is YX position, and the N dimension
        is N points per frame.

    Returns
    -------
    (N, D) array
        To be passed to viewer.add_points
    """
    unraveled = np.asarray(locations).reshape(-1, 2)
    idxs = np.unravel_index(np.arange(unraveled.shape[0]), loc.shape[:-1])

    # +1 instead of +2 so we also ignore the N dimension
    points_dat = np.zeros(shape=[unraveled.shape[0], len(idxs)+1])
    points_dat[:, :len(idxs)-1] = np.swapaxes(np.vstack(idxs[:-1]), 0, 1)
    points_dat[:, -2:] = unraveled
    return points_dat

Alternatives
Writing this, I'm realizing I'm perhaps storing my points data in a strange way. I may change that now, but this way felt natural coming from analyzing images.
Additional context

Sorry for not noticing this earlier @ianhi! This is something I've been wanting to do for a long time (here's an old branch trying to implement just this); I have a reasonably good idea on how to do it, but this is not the right moment to implement it. We need to wait for the big async work to be pushed a bit further #5353, otherwise we're gonna step on each other's toes :P


Fix: og:.. & twitter:description now displaying the same text as the default description

1. Why is this change necessary?
If you change the Page Meta Description of the Root Kategory, the og:description & twitter:description didnt get it
2. What does this change do, exactly?
Change the Header.tpl and extend the og:description and twitter:discripton tag
3. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-19868.
Please use this issue to track the state of your pull request.

thanks for your contribution @DirkPersky :+1:

Danke, scheint aber noch nicht Vollständig zu sein eurer Code:
wenn ihr neue Blöcke dafür einführt, solltet ihr die aber auch in den anderen Headern entsprechen anpassen:
/themes/Frontend/Bare/frontend/listing/header.tpl
Tauchen z.B. die neue Blöcke: frontend_index_header_meta_description_og und frontend_index_header_meta_description_twitter garnicht auf. etc. etc.

hey @DirkPersky
we did not add the new blocks to the other header files, because these pages are usually quite individual and customized.
If you like to add new blocks to the other template files, we would appreciate a new PR or an issue ticket, so we can have second look at this one :blush: :+1:
best regards from Schöppingen
Telgi


Cache with :get and :set methods only

Some cache clients do not support :[] and :[]= methods, but do support :get and :set methods. What do you say if I make a pull request for fallback functionality? Already have the code, but don't want to waste my time preparing the commit if community does not need it.

Sounds good to me.


Mrksr fix randomize without prior

internal PR

Codecov Report

Merging #395 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   99.74%   99.74%
=======================================
  Files          28       28
  Lines        2337     2337
=======================================
  Hits         2331     2331
  Misses          6        6

Impacted Files
Coverage Δ

GPflow/param.py
99.43% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4905fde...c105611. Read the comment docs.

Thanks for this @mrksr !


Update SchemaGenerator to fix #2514 and #2052

This pull request fixes (reverts) the placement of the discriminator to the polymorphic oneOf element. Fixing #2052.
This pull request also fixes #2514 and the bug where enabling UseOneOfForPolymorphism forces UseAllOfForInheritance=true (when UseAllOfForInheritance=false).

Sure hope this gets merged some day :)

You can port this to my fork https://github.com/Havunen/DotSwashbuckle if you are interested about this feature, however some tests need to be added

Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI. Please also add some tests.


refactor(calibration-storage): Use pydantic models for data validation, add OT-3 pydantic models

Overview
Closes RLIQ-118. The objective of this PR is to add pydantic models to support better validation on calibration data in general. Please check out this confluence doc for more information on the pydantic schemas and this confluence doc for more information on what the file system looks like in general. There are a lot of loose ends  around calibration data that need to be tied up in separate PRs of which I've documented in this epic.
In-memory caching for calibration data will be in a follow-up PR. Mike's comments from here have been addressed in this new branch aside from file access asynchrony which will be addressed in a separate ticket. Apologies for the commit wonky-ness. I couldn't get the branches to rebase properly.
Changelog

Added two modules under calibration_storage to separate OT-2 and OT-3 calibration types
Separated instrument calibration data based on OT-2 and OT-3 (pipette(s) will be handled in a follow-up PR which changes the data schema of pipettes to support OT-3 pipette functionality).
Moved the dataclass objects of the calibration data models (which were only used in the hardware controller) to the hardware controller and converted from the pydantic schemas in the hardware controller once the data was being loaded in.
Switched to using only pydantic models in the robot-server
Added more test coverage on the calibration storage module in general
Modified tests where necessary

Review requests
Please test this on a robot, let me know if you have any changes you want to the actual data shape as well.
Test Plan
Please view this confluence document for a more detailed test plan and check list.

[x] Run through all OT-2 calibration flows
[x] Check that all calibration data endpoints (calibration/pipette_offset and calibation/tip_length) still work as expected
[ ] Check that all robot calibrations are still being properly loaded and applied in the hardware controller
[x] Check that downgrading the software keeps all calibrations that were calibrated with the new software

Risk assessment
High. This touches a lot of flakey code and needs a lot of QA eyes. See test plan above.

I want to get this merged ASAP because it's blocking some other calibration work. Any other clean-ups requested (aside from anything found during testing) will be documented here and addressed after our 'feature freeze'.

I'm ok to move forward with this PR and address additional items in a follow up PR for speed, but in order of importance, I'm still concerned about these issues:

Conditional imports/exports at the top level of the calibration_storage module should be avoided at all costs

Tests for calibration_storage are written with if/else, which seems to suggest that a test suite run will only check OT-2 or OT-3, rather than OT-2 and OT-3

File/directory reading/writing concerns still leak out of file_operators.py

Since file_operators.py has test coverage, tests for other calibration_storage components could mock out file_operators for speed and useful design feedback, but they do not

Tests will be slower because there will be a lot of hitting the filesystem
We have redundant test coverage of file operations

Will hopefully get to all of this next week!


Explode and overline

Starting with the high level ask, we have a function that does the following:
import geopandas as gpd
from shapely.geometry import LineString

sl = gpd.GeoDataFrame(
    {
        "id": ["a", "b"],
        "value": [1, 2]
    },
    geometry = [
        LineString([(0, 0), (1, 1), (2, 2)]),
        LineString([(0, 1), (1, 1), (2, 2)])
    ]
)

# plot with values:
sl.plot(column = "value")
# The output should be along the lines of:
sl_overline = gpd.GeoDataFrame(
    {
        "value": [1, 2, 3]
    },
    geometry = [
        LineString([(0, 0), (1, 1)]),
        LineString([(0, 1), (1, 1)]),
        LineString([(1, 1), (2, 2)])
    ]
)
sl_overline.plot(column = "value")

That may seem simple but there are several steps:

[x] exploding the geometries, as implemented in native QGIS algorithm and in GeoPandas feature request: https://github.com/geopandas/geopandas/issues/2476
[ ] re-ordering linestrings to prevent duplicate lines with different coordinate order
[ ] aggregating the values (I suggest that this done as a separate step, possibly optionally, to give users control over aggregating functions and variables, ideally with the power of polars)
[ ] merging the exploded linestrings into longer linestrings, that are as long as possible without aggregated values changing
[ ] returning joined-up geometries

References

There is a long-standing and well-used R implementation, a breakdown of which can be found here (source of the Python reproducible example above): https://github.com/Robinlovelace/overline-tests
There is a paused attempt at a pure Rust implementation: https://github.com/acteng/overline/tree/master
Here's an example of the outputs, detailed route networks with attribute values (in this case representing cycling potential, zoom in to see): https://dev.cruse.bike/ or https://npt.scot

Update on thinking: I don't think geoarrow-rs needs to do the whole thing: there are many options in the summarise -> aggregation step that are worth exposing to the user. Just getting the exploded+ordered linestrings alongside their attributes would be enough I think.
The merging the linestrings back together step is another bit that would massively benefit from being done here.

I don't think geoarrow-rs needs to do the whole thing

Yeah this was going to be a point of discussion. The goal for now is implementing as general operations as possible. So explode makes sense because it's very general. In terms of "explode segments" I'm not sure what the most general API is. We could have an explode_segments method on LineStringArray and ChunkedLineStringArray which return a LineStringArray of length-2 lines as well as indices to pass into a take operation. So something roughly like
table = GeoTable(...)
geometry = table.geometry
assert isinstance(geometry, ChunkedLineStringArray)
exploded_geometry, indices = geometry.explode_segments()
exploded_table = table.remove_geometry()[indices].add_column(exploded_geometry)

The other note is that the goal with geoarrow is to make sharing geometries across libraries zero-cost because the geometry format is ABI-stable. So a possibility is to implement some core operations in the geoarrow.rust.core Python package, but if there are other operations with a more narrow use case, have another python package like geoarrow.road_networks to do those. And each package can share data totally transparently and at zero-cost

General :+1: to the sentiment here without commenting on details..

Awesome! Let me know if I can help provide pointers or anything


Update README.md

The Approval field indicates that it's a calculated column, but no formula is required. This solution appears to work fine with that column as a single line of text column.

Q
A

Bug fix?
yes

New sample?
no

Related issues?
no

What's in this Pull Request?
The README lists the Approval column as a calculated column. That column type requires a formula to create, and no formula was provided. Because a JSON formatter is used here, the formula is unnecessary anyway, and can be swapped for a single line of text column, correcting the column creation process.

Thanks for the update, Steve!!!
 But it also doesn't look like it needs to be a single line text column. It looks like it could be any type of column.
Presumably, the reason for using a Calculated column in this sample is that there is no need to set a value for the Approval column. With other column types, the form would be displayed even though there is no need to set a value, and it would be possible to be set a value for the column unnecessarily.
As a fix, how about making the Approval column type Any and recommending the use of the Calculated column as a supplement...? (Sample of supplement: generic-file-preview - View requirements).

I think it is perfect! Thanks always!!!🙏


add homebrew and travis support

added homebrew support and basic readme. I also tried to modify the travis configuration, but did not test it yet.

This looks great, thank you! Just a few suggestions, though (see comments inline).

Should this directly committed as PR to the homebrew repo? Fair chances they would accept it.

Quite possibly, @oncletom, but let's get it working here first and then we can do that.

Sure :-) ping me whenever you'd need to test that out on a Mac laptop.

Merged, and seemingly working via Travis CI. Thanks a lot for your contribution, Stefan!


Clair security backend throwing 500 when Layer missing Features key

Example layer:
{"Name"=>"sha256:d68f678e277bd65f0bd0aa498c2864083be4a9b7143b632b4440954ac6641de4", "ParentName"=>"sha256:5884a61ab3a9db3cd3591bf46811639a8497112edaf7d7288f0d8f72ea828a2d", "IndexedByVersion"=>3}

Error message:
Started POST "/v2/webhooks/events" for <IP_ADDRESS> at 2017-07-28 15:08:25 +0000
Processing by Api::V2::EventsController#create as JSON
Completed 202 Accepted in 1ms (ActiveRecord: 0.0ms)
2017-07-28 15:08:25 +0000: SSL error, peer: <IP_ADDRESS>, peer cert: , #<Puma::MiniSSL::SSLError: System error: Success - 0>
Completed 500 Internal Server Error in 483ms (ActiveRecord: 7.2ms)

NoMethodError (undefined method `each' for nil:NilClass):
  lib/portus/security_backends/clair.rb:45:in `layer_vulnerabilities'
  lib/portus/security_backends/clair.rb:30:in `vulnerabilities'
  lib/portus/security.rb:48:in `block in vulnerabilities'
  lib/portus/security.rb:46:in `each'
  lib/portus/security.rb:46:in `vulnerabilities'
  app/models/tag.rb:96:in `vulnerabilities'
  app/models/tag.rb:90:in `block in as_json'
  app/models/tag.rb:89:in `tap'
  app/models/tag.rb:89:in `as_json'
  app/controllers/repositories_controller.rb:19:in `show'

Processing by ErrorsController#show as JSON
  Parameters: {"id"=>"4", "status"=>"500"}
Completed 500 Internal Server Error in 1ms (ActiveRecord: 0.0ms)
Error during failsafe response: Missing template errors/500, application/500 with {:locale=>[:en], :formats=>[:json], :variants=>[], :handlers=>[:erb, :builder, :raw, :ruby, :slim]}. Searched in:
  * "/srv/Portus/app/views"
  * "/usr/local/bundle/gems/kaminari-0.16.3/app/views"
  * "/usr/local/bundle/gems/devise-3.5.1/app/views"
   /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/path_set.rb:46:in `find'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/lookup_context.rb:121:in `find'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/renderer/abstract_renderer.rb:18:in `find_template'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/renderer/template_renderer.rb:40:in `determine_template'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/renderer/template_renderer.rb:8:in `render'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/renderer/renderer.rb:46:in `render_template'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/renderer/renderer.rb:27:in `render'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/rendering.rb:100:in `_render_template'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/streaming.rb:217:in `_render_template'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/rendering.rb:83:in `render_to_body'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/rendering.rb:32:in `render_to_body'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/renderers.rb:37:in `render_to_body'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/abstract_controller/rendering.rb:25:in `render'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/rendering.rb:16:in `render'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/instrumentation.rb:44:in `block (2 levels) in render'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/core_ext/benchmark.rb:12:in `block in ms'
  /usr/local/lib/ruby/2.3.0/benchmark.rb:308:in `realtime'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/core_ext/benchmark.rb:12:in `ms'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/instrumentation.rb:44:in `block in render'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/instrumentation.rb:87:in `cleanup_view_runtime'
  /usr/local/bundle/gems/activerecord-4.2.8/lib/active_record/railties/controller_runtime.rb:25:in `cleanup_view_runtime'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/instrumentation.rb:43:in `render'
  /srv/Portus/app/controllers/errors_controller.rb:15:in `show'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/abstract_controller/base.rb:198:in `process_action'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/rendering.rb:10:in `process_action'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:117:in `call'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:505:in `call'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:778:in `_run_process_action_callbacks'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/callbacks.rb:81:in `run_callbacks'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/abstract_controller/callbacks.rb:19:in `process_action'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/rescue.rb:29:in `process_action'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/notifications.rb:164:in `block in instrument'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/notifications.rb:164:in `instrument'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
  /usr/local/bundle/gems/activerecord-4.2.8/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/abstract_controller/base.rb:137:in `process'
  /usr/local/bundle/gems/actionview-4.2.8/lib/action_view/rendering.rb:30:in `process'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal.rb:196:in `dispatch'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal/rack_delegation.rb:13:in `dispatch'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_controller/metal.rb:237:in `block in action'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/routing/route_set.rb:74:in `dispatch'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/routing/route_set.rb:43:in `serve'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/journey/router.rb:43:in `block in serve'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/journey/router.rb:30:in `each'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/journey/router.rb:30:in `serve'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/routing/route_set.rb:817:in `call'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/middleware/show_exceptions.rb:47:in `render_exception'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/middleware/show_exceptions.rb:35:in `rescue in call'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
  /usr/local/bundle/gems/railties-4.2.8/lib/rails/rack/logger.rb:38:in `call_app'
  /usr/local/bundle/gems/railties-4.2.8/lib/rails/rack/logger.rb:20:in `block in call'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/tagged_logging.rb:68:in `block in tagged'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/tagged_logging.rb:26:in `tagged'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/tagged_logging.rb:68:in `tagged'
  /usr/local/bundle/gems/railties-4.2.8/lib/rails/rack/logger.rb:20:in `call'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/middleware/request_id.rb:21:in `call'
  /usr/local/bundle/gems/rack-1.6.4/lib/rack/methodoverride.rb:22:in `call'
  /usr/local/bundle/gems/rack-1.6.4/lib/rack/runtime.rb:18:in `call'
  /usr/local/bundle/gems/activesupport-4.2.8/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
  /usr/local/bundle/gems/actionpack-4.2.8/lib/action_dispatch/middleware/static.rb:120:in `call'
  /usr/local/bundle/gems/rack-1.6.4/lib/rack/sendfile.rb:113:in `call'
  /usr/local/bundle/gems/railties-4.2.8/lib/rails/engine.rb:518:in `call'
  /usr/local/bundle/gems/railties-4.2.8/lib/rails/application.rb:165:in `call'
  /usr/local/bundle/gems/rack-1.6.4/lib/rack/urlmap.rb:66:in `block in call'
  /usr/local/bundle/gems/rack-1.6.4/lib/rack/urlmap.rb:50:in `each'
  /usr/local/bundle/gems/rack-1.6.4/lib/rack/urlmap.rb:50:in `call'
  /usr/local/bundle/gems/puma-3.7.0/lib/puma/configuration.rb:226:in `call'
  /usr/local/bundle/gems/puma-3.7.0/lib/puma/server.rb:578:in `handle_request'
  /usr/local/bundle/gems/puma-3.7.0/lib/puma/server.rb:415:in `process_client'
  /usr/local/bundle/gems/puma-3.7.0/lib/puma/server.rb:275:in `block in run'
  /usr/local/bundle/gems/puma-3.7.0/lib/puma/thread_pool.rb:120:in `block in spawn_thread'

I'm happy to submit a patch to check the Layer for the Feature key.

PR: https://github.com/SUSE/Portus/pull/1352


Unable to join server(Joining failed. The password is invalid)

After the latest update, I am encountering an error message stating “Joining failed. The password is invalid.”
Possible Cause:
This issue may be linked to recent modifications in the server configuration file, which include the introduction of new roles and difficulty settings.
For more details, please refer to the following articles:

Server Roles Configuration(https://enshrouded.zendesk.com/hc/en-us/articles/19191581489309-Server-Roles-Configuration)
Server Difficulty Settings(https://enshrouded.zendesk.com/hc/en-us/articles/20453241249821-Server-Difficulty-Settings)

Ill take a look at this!


Missing license for code

Hi,
I want to explore the usage of your code and possibly adapt it to a related use case. However, you have not added a license under which conditions it is allowed to use and reuse your data and code. Can you please add a license to your code?
Best wishes,
Markus

Hi Markus,
Sorry for not noticing this earlier. This repo has been somewhat neglected for an extended period.
An MIT license has been added now. There's also several new updates to this repo on the way. Stay tuned :)
Best regards
Christian


Vim Keybindings in File Browsing Pane?

It would be fantastic if we could navigate around the file pane like you can in NERDTree for Vim.  Quick jumps via /search, paging, etc.  Would it be possible to implement something like this in Atom?  Its the one thing holding me back from a full switch away from MacVim.
Great work otherwise!

I'd love to see this, too! I think the current stance is that it won't happen via this package, though (see #131).

@dougblack's comment in that thread seems to be a nice work-around, though having first class support right out of the box would be nice.

If I'm understanding what you're looking for correctly, you want to be able to move around the file tree in the same manner that you do in NERDTree? If so, I have that most of the way working. Once the tree is open and focussed, you can use hjkl and Enter to navigate the pane.
I bound ,t to both toggle and focus the file tree pane, which works to do those two things, but creates another, seemingly unrelated issue ( #572 ). I think that if you used a different keybind, you could use the tree pane pretty much as if it was NERDTree.

Rad!  Will give it a spin tomorrow.

/ searching doesn't work in tree pane, also can't switch focus between the tree and file easily.

Ah, yes, I haven't tried searching in the tree pane, so I didn't think to say that that didn't work. I'm not sure what you consider switching easily, but for me it's just a matter of doing ,t to switch between tree and main window.

Searching via / would be fantastic.

@TheAtomicGoose in vim you can switch focus between different pane, I don't know how to do that in Atom without closing the pane in the first place.

@pencilcheck: you can use Ctrl-0 to focus the tree pane, so if you rebind that to something you like, you should be able to change the focus easily.

@TheAtomicGoose that did it, cool.

Here is a whole thread of bind copy&paste snippets (for does that got this as the first result on google):
https://discuss.atom.io/t/only-allowing-keybind-to-be-triggered-when-in-command-mode-vim-mode/15496
The following snippet toggles focus between project tree and the editor
'atom-text-editor.vim-mode:not(.insert-mode), .tree-view':
  ', n': 'tree-view:toggle-focus'

thanks @pgericson - just what i was looking for


Cannot read property withStyles of undefined

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Getting error:
Uncaught TypeError: Cannot read property 'withStyles' of undefined
at withStyles (withStyles.js:6)
at<EMAIL_ADDRESS>(SvgIcon.js:160)
at webpack_require (bootstrap:18)
at<EMAIL_ADDRESS>(redux-saga-symbols.esm.js:39)
at webpack_require (bootstrap:18)
at Module../src/pages/error/errorPage.tsx (calculator.min.js?v=516:5549)
at webpack_require (bootstrap:18)
at Module../src/pages/error/index.ts (calculator.min.js?v=516:5590)
at webpack_require (bootstrap:18)
at Module../src/components/errorBoundary/errorBoundary.tsx (calculator.min.js?v=516:1903)
Expected Behavior 🤔
No error.
Context 🔦
We built an application which should be distribued as javascript file from our api. Client web downloads and loads this file (starts application as widget). Client web may or may not use material-ui, thus we added @material-ui/core in external dependencies, and client web should handle it yourselve by installing material-ui from npm, or linking it from cdn
in application webpack.config
		externals: {
			'react': {
				commonjs: 'react',
				commonjs2: 'react',
				amd: 'react',
				umd: 'react',
				root: 'React'
			},
			'react-dom': {
				commonjs: 'react-dom',
				commonjs2: 'react-dom',
				amd: 'react-dom',
				umd: 'react-dom',
				root: 'ReactDOM'
			},
			'@material-ui/core': {
				commonjs: '@material-ui/core',
				commonjs2: '@material-ui/core',
				amd: '@material-ui/core',
				umd: '@material-ui/core',
				root: 'MaterialUI'
			}
		}

Client web downloads this bundle and also links this cript
<link src=https://unpkg.com/<EMAIL_ADDRESS>/>
Or if client web has npm, installs material-ui and sets it in global variable like this
import * as MaterialUI from "@material-ui/core";
window.MaterialUI = MaterialUI;

Everything was fine until we run into issue when all material icons colors and sizes were overriden by default pallete (all icons colors of client web was overriden to blue). This was solved by adding also @material-ui/styles module in external dependencies. Please see this issue https://github.com/mui-org/material-ui/issues/19702 for more information.
...
			'@material-ui/styles': {
				commonjs: '@material-ui/styles',
				commonjs2: '@material-ui/styles',
				amd: '@material-ui/styles',
				umd: '@material-ui/styles',
				root: 'MaterialUIStyles'
			}
...

It was working fine again with npm approach.
import * as MaterialUIStyles from "@material-ui/styles";
window.MaterialUIStyles = MaterialUIStyles;

But how should i add material-ui/styles in external dependencies to make it work also with cdn approach ?
I got an error Cannot read property 'withStyles' of undefined. Obviously material-ui/styles module is missing.
Am i specifiing root name wrong ?
Or should i link material-ui/styles cdn from somewhere and from where and how ?
I cannot find any usefull information in documentation about this context.
Your Environment 🌎
System:
OS: Windows 10 10.0.18363
CPU: (2) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz
Memory: 2.58 GB / 12.08 GB
Binaries:
Node: 14.15.3 - C:\Program Files\nodejs\node.EXE
npm: 6.14.9 - C:\Program Files\nodejs\npm.CMD
Managers:
pip3: 20.2.3 - C:\Python39\Scripts\pip3.EXE
Utilities:
Git: 2.27.0. - C:\Program Files\Git\cmd\git.EXE
SDKs:
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
AllowAllTrustedApps: Enabled
Versions: 10.0.17763.0
IDEs:
VSCode: 1.52.1 - C:\Users\Erik Parso\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
Visual Studio: 16.7.30330.147 (Visual Studio Community 2019)
Languages:
Python: 3.9.0 - C:\Python39\python.EXE
Browsers:
Chrome: 87.0.4280.141
Edge: Spartan (44.18362.449.0)
Internet Explorer: 11.0.18362.1
Using chrome

@ErikParso The CDN bundle is meant for prototyping, don't rely on it in production. In any case, we don't have the bandwidth to provide support on bundling related question. You could try StackOverflow.

@ErikParso The CDN bundle is meant for prototyping, don't rely on it in production. In any case, we don't have the bandwidth to provide support on bundling related question. You could try StackOverflow.


Making changes to SFSafariViewController class

With the changes introduced to SFSafariViewController in iOS 10, it makes it possible to customize it a lot more. I'm using SafariURLHandler, but how can I access the SafariVC to make changes?
OS (Please fill the version) :

[x] iOS :
[ ] OSX :
[ ] TVOS :
[ ] WatchOS

Library version:

[ ] head
[ ] v1.0.0
[ ] v0.6
[x] other: v1.1.2

Xcode version:

[ ] 8.0 (Swift 3.0)
[ ] 8.0 (Swift 2.3)
[ ] 7.3.1
[x] other: Xcode 9 and Swift 4

you can set a factory SafariURLHandler#factory
see https://github.com/OAuthSwift/OAuthSwift/blob/master/Sources/OAuthSwiftURLHandlerType.swift
then there is also
open var animated: Bool = true
open var presentCompletion: (() -> Void)?
open var dismissCompletion: (() -> Void)?

@phimage OK, so how does SafariURLHandler#factory work? Do you have a short code example?

.factory = { safari in
}
Simple closure

@phimage 'safari' is of type URL, that's why I was getting confused with SafariURLHandler#factory.

Sorry
, just read the closure type
.factory = { url  in
return SafaryXxxxxx(url :url)
}

@phimage Getting the following error: Value of type '()' does not conform to 'OAuthSwiftURLHandlerType' in assignment

ya but you not post your code, so how I can help? The error message is clear.
please look at demo code
https://github.com/OAuthSwift/OAuthSwift/commit/aceae6aaad5d3d5930f74119fadcdb4cdc2b5f52

@phimage Nevermind Xcode seemed to be acting up. When I looked over the code, mine looked the same, so I tried uncommenting what I wrote, and everything is fine. Thanks!


Implement URL shortening with /linkshorten command

Description
This pull request adds a new /linkshorten command to the project. The command allows users to shorten any URL using the url-link-shortener API.
Fixes #91
Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?

Clone the repo
Remove the .template from .env.template
Add required variables to .env
Run yarn install
Run node . and test the command
Rename .env to .env.template

Checklist:

[x] My code follows the style guidelines of this project
[x] I have restored .env.template
[x] I have performed a self-review of my code
[x] New and existing code pass locally with my changes - Run yarn run format

Thanks!


Fixing issue : Local reference get cleared when specifying Branch key through code

Fixing issue : Local reference get cleared when specifying Branch key through code.
This  issue was causing v1/install to be called each time app killed and restarted if the Branch  key is  not specified in the manifest
@aaustin @Sarkar

oh man. good find. 👍

👍


FancyZones: Fullscreen Window When Using Windows Snap Override

Is it possible to add an option to allow a window to become fullscreen when pressing "win + up" and there are no possible zones above the window (ie. top edge of display) while using the "Override Windows Snap shortcut" option.
"win + up" is one of my most used Windows shortcuts and there is currently no way to have that functionality while using the override.

@cpiscos
add you comments to https://github.com/microsoft/PowerToys/issues/4795


Error handling

Add some basic error handling for the registration form.

insert of adding an extra query in register, try/catch the insert and see if the email is duplicate


Patched elements keep inline styles from old vnodes

Vue.js version
2.0.6+
Reproduction Link
https://jsfiddle.net/gw8g8cos/

Steps to reproduce
$ vue init webpack-simple .
$ npm install<EMAIL_ADDRESS><EMAIL_ADDRESS>
<template>

        Should be centered.

        Should not be centered.

</template>

What is Expected?
Patched elements should not keep inline styles from old vnodes.
What is actually happening?
During the update operation, patched elements will retain styles from vnodes that will no longer exist in the DOM.
Temporarily solution for end-users: changing inline styles to classes, choosing different tag names or adding a key directive will fix the issue. Thanks to @LinusBorg for the latter.
It looks like this PR has introduced this regression https://github.com/vuejs/vue/pull/4138. I've opened a pull request with a failing test that confirms this issue.

Edit: looks like this PR may have introduced a regression https://github.com/vuejs/vue/issues/3997. I'll try to reproduce this in JSFiddle but I can't seem to pinpoint what is causing the problem. It's breaking in random parts of my app.

Figured it out. Here's a quick way to recreate it.
$ vue init webpack-simple .

<template>

        Should be centered.

        Should not be centered.

</template>

I will look for a fix now. Basically, when two elements next to each other alternate state, the Vue compiler thinks it's still the same element.

This might be related to https://github.com/vuejs/vue/issues/4205. But I'm not sure. Can you try adding a key property to section?

@HerringtonDarkholme it's definitely related. Still a little annoying to have to deal with this... Adding the key tag worked... Would be nice to mention something in the docs about diffing.

@Igdexter

Would be nice to mention something in the docs about diffing.

We're on it vuejs/vuejs.org#587

@LinusBorg cool, thanks for the quick response. had quite a shock in production today with 2.0.7

had quite a shock in my staging environment today with 2.0.7

This is not an inteded breaking change, mind you. It's generally expected behaviour in many situations, but as already mentioned, documentation about this is still lacking.
I assume that this worked "accidentally" before, and recent fixes of bugs which, amongst other things, related to handling of style and class bindings, might have changed that.

@LinusBorg I wonder whether this is a correct behavior.
The example above can be diffed solely by v-dom. The style attributes should be considered as a v-dom construct.
By comparison, consider this example. https://jsfiddle.net/gw8g8cos/4/
The inner text and class has been updated, the class is not merged, but style is merged.
Also, this issue is different from #4205 , since lifecycle is not managed by virtual dom.
And it is also different from https://github.com/vuejs/vue/issues/4216, since inline-template, speaking in implementation, has a different slot than render in vnode representation.
cc @defcc

@LinusBorg I'm guessing the "improvement" to inline styles as per #4138 is what made this issue apparent now. I'm just wondering if this is the correct behavior. Here it's comparing the old node with the new node and then applying style changes by merging them. While it's reusing the same node, I don't think it should technically reuse the style from both nodes.

Hm you might be right.

Something wrong with static style and style binding merge. It should be a bug. I am looking into it and trying to fix it.

https://github.com/vuejs/vue/blob/dev/src/platforms/web/runtime/modules/style.js#L48
const style = normalizeStyleBinding(vnode.data.style) || {}
vnode.data.style = style.__ob__ ? extend({}, style) : style
const newStyle = getStyle(vnode, true)

The style now only holds the style binding, which will be removed in the next render. The static style and  style binding should be removed both when reusing the same node.

I'll make a PR to fix it


Try netlify

relates to #44

It works but there is no transparency into the environment. There is no nix support which makes me think it will be fragile.

We won't be using netlify. Closing.


Not working on PhpStorm 2021.1

Describe the bug
Not working on the newer 2021.1 version of PhpStorm
IDE (please complete the following information. See Main Menu -> Help -> About):

OS: Arch Linux
Product: PhpStorm
Version 2021.1
JRE Version: Built in version
Project SDK: -

Plugin (please complete the following information. See Main Menu -> File -> Settings -> Plugins):

Version 2020.2.1-203

Additional context
Not compatible with the current version of the IDE, because it requires build 203.* or older but the current build is PS-211.6693.120

PhpStorm 2021.1 compatible version released. Available for download in two business days

Same with Intellij 2021.1

New version available for download


Clarification required about variants

In the spec today, I think there is this section:
https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/main/html/cp_PackTutorial.html#cp_PackSteps
that explains that a variant is part of the component identification.
Based on this, we can conclude that only one variant of a component can be selected at a time in a project (as this is one component).
But here:
https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/main/html/pdsc_components_pg.html#element_component
Nothing clearly states that variants are exclusive.
They are an optional part of the component identification, so does it mean that when used they create 2 distinct identities so maybe 2 distinct components we may select at the same time ?
I mean : components are unique in a project (they can have instances only), but as they admit several variants, one may think that we can have:

comp A variant A
comp A variant B
at the same time.

This is not the intention of the spec IMO.
Besides, Keil uvision really implements it as exclusive : select comp A with variant A or variant B.
But this is only an implementation...
I think the spec is a bit unclear here.

@slhultgren @lmestm

Grey area mixing specs & tools implementation. We may have couple of time same discussions considering *.yml stuff & devtools implementation ... a schema cannot fully describe a workflow / under the hood logic. By the end only the pair is self contain. Claiming standard definition such is an issue definitively but is solving so easy ?
Back to component variants myself I would be a bit afraid to mix various variant of a same component as part of a common project .... I like so Keil uvision implementation.

It seems csolution currently allows the selection of multiple variants.
But I agree with you, from the nature of "variant" classification I would rather interpret them as mutually exclusive.

raise defect in csolution
raise defect against Open-CMSIS-Pack-Spec

PR created and issue against csolution raised.


create nix flake with default package and dev shell

This adds flake support for Nix

@ivandimitrov8080 closing as we have a nix flake already!


🐛 [firebase_database] Slow serialization of Java objects in UI thread on the Android native side

Bug report
In the native part of the plugin on Android, the UI thread can be blocked for significant time when receiving a large number of objects from Firebase. This is caused by object serialization on the Java side taking a long time and because it happens on the main thread. This could be alleviated either by pre-processing the data (e.g. serializing the objects into a byte array), off the main thread, before handing it over to the EventChannel. Or by using a different, more performant way of serializing the Java objects than the default EventChannel mechanism.
Steps to reproduce
Register an onValue listener to a large (say 10-20k) collection of objects (objects can be fairly simple). UI thread in this case is blocked for 100+ms for each update.

@jbxbergdev
Can you provide flutter doctor -v, plugin version you are using along with a minimal code sample that shows the issue you are reporting ?

@darshankawar Plugin version is the most current one. You can simply reproduce by registering a listener to a large collection of objects (as I wrote, 10-20k should do) in RTDB. Then register an onValue listener to it or request once() on the collection. With every update event, the UI thread will be blocked for considerable time. You can visually check this with e.g. having a scrollable list that will be unresponsive during the update events.

@jbxbergdev
In order to address this issue properly, please provide a minimal code sample that shows the issue you are reporting.
Thanks.

Column(       children: [         StreamBuilder(           stream: FirebaseDatabase.instance.ref().child('collection_with_many_objects').onValue,           builder: (context, snapshot) {             return Container();           },),         ListView(children: List.generate(100, (index) => ElevatedButton(onPressed: () {}, child: Text(index.toString()))),)       ],     );
Try scrolling the list while Firebase receives objects.

Reopening as bot isn't working properly in this repo.

In the native part of the plugin on Android, the UI thread can be blocked for significant time when receiving a large number of objects from Firebase

Flutterfire is a wrapper around native firebase sdks and it just sends some data from Dart, which hits the native Firebase SDKs, and sends the data back once they return some data. So I suggest you to open this issue in native firebase sdk github and check what they say about it. https://github.com/firebase/firebase-android-sdk/issues


Remove app engine standard new project wizard support from CE

Currently, since our plugin is bundled in both editions, users can generate an app-engine standard project in CE. The project that is generated is not a full project though like in UE, just some bare directories with an appengine-web.xml.
We should remove this so that it doesn't show up in CE.

@patflynn @aslo @joaoandremartins - this can be closed now right? via https://github.com/GoogleCloudPlatform/google-cloud-intellij/commit/0716f5ace7db07f5eae5538188220178a670dc58

Yebo, though we should probably think about adding some hardcoded project structure, or even a Maven archetype as new projects in community edition. We can either close this and open a new issue or rename this one.

yea lets create new ones. I'll close this one.


SPXSpeechSynthesizer stopSpeaking() method cannot return immediately on iOS 17

After calling SPXSpeechSynthesizer startSpeakingSsml() to synthesize the speech, while the speech is playing back, and then call stopSpeaking() to stop the speech, stopSpeaking() cannot return immediately on iOS 17. The speech audio can be stopped immediately, but this method will take 10-20 secs to return.
iOS16 and iOS 15 doesn't have this issue.
Below is our sample swift code to illustrate this issue on iOS 17
// below is the code snippet to start text to speech
let speechConfig = try SPXSpeechConfiguration(subscription: key, region: region)
synthesizer = try SPXSpeechSynthesizer(speechConfig)

let ssml = """
<speak version="1.0" xmlns="http://www.w3.org/2001/10/synthesis"  xmlns:mstts="https://www.w3.org/2001/mstts" xml:lang="en-US">
    <voice name="en-US-JennyNeural">
        <mstts:express-as style="friendly">
            <prosody rate="1.0">
                Hello how are you ?
            </prosody>
        </mstts:express-as>
    </voice>
</speak>
"""

try synthesizer?.startSpeakingSsml(ssml)

Below is the code snippet to stop text to speech
try synthesizer?.stopSpeaking() // this method takes 10-20s to return

We're using MicrosoftCognitiveServicesSpeech-iOS ver 1.32.1

@yulin-li -- do you have any insight on this iOS17-specific behavioral difference relative to older versions? @jhakulin rightly recommended asking you early while we track down a repro device.

bump- this is causing a crash in my app as my class deinits

Internal workitem: 5706031

@ssadel Does your app crash due to stop takes too long? Or crash happens inside SDK? Could you please share backtrace?

May I know any ETA for this fix? Our production iOS app suffers from this issue, is there any suggested workaround in the meantime before the fix is available. Many thanks !

@ssadel Does your app crash due to stop takes too long? Or crash happens inside SDK? Could you please share backtrace?

hopefully this can help, it's the trace from an iOS 17.0.2 device. context is the stopPreview func is called right before deallocation of a view model. comes from crashlytics btw might be a bit wonky, i'm unable to test myself as i haven't updated yet
Crashed: com.apple.main-thread
0  libsystem_platform.dylib            0x6290 _os_unfair_lock_corruption_abort + 88
1  libsystem_platform.dylib            0x3358 _os_unfair_lock_lock_slow + 300
2  libsystem_pthread.dylib             0x8030 pthread_mutex_destroy + 64
3  MicrosoftCognitiveServicesSpeech    0x8f3fb8 pal_get_value + 89132
4  MicrosoftCognitiveServicesSpeech    0x34ae28 GetModuleObject + 1701908
5  MicrosoftCognitiveServicesSpeech    0x34ad94 GetModuleObject + 1701760
6  MicrosoftCognitiveServicesSpeech    0x3481d0 GetModuleObject + 1690556
7  MicrosoftCognitiveServicesSpeech    0x347f70 GetModuleObject + 1689948
8  MicrosoftCognitiveServicesSpeech    0x34864c GetModuleObject + 1691704
9  MicrosoftCognitiveServicesSpeech    0x3930c4 GetModuleObject + 1997488
10 MicrosoftCognitiveServicesSpeech    0x393c90 GetModuleObject + 2000508
11 MicrosoftCognitiveServicesSpeech    0xc69b4 property_bag_copy + 5460
12 MicrosoftCognitiveServicesSpeech    0xc66b0 property_bag_copy + 4688
13 MicrosoftCognitiveServicesSpeech    0xc657c property_bag_copy + 4380
14 MicrosoftCognitiveServicesSpeech    0xc4d40 property_bag_release + 20
15 MicrosoftCognitiveServicesSpeech    0x18bdf8 pal_string_to_wstring + 807452
16 MicrosoftCognitiveServicesSpeech    0x18b9f0 pal_string_to_wstring + 806420
17 MicrosoftCognitiveServicesSpeech    0x165f78 pal_string_to_wstring + 652188
18 libobjc.A.dylib                     0x5354 object_cxxDestructFromClass(objc_object*, objc_class*) + 116
19 libobjc.A.dylib                     0x5090 objc_destructInstance + 80
20 libobjc.A.dylib                     0x503c _objc_rootDealloc + 80
21 MicrosoftCognitiveServicesSpeech    0x185f3c pal_string_to_wstring + 783200
22 libobjc.A.dylib                     0x5354 object_cxxDestructFromClass(objc_object*, objc_class*) + 116
23 libobjc.A.dylib                     0x5090 objc_destructInstance + 80
24 libobjc.A.dylib                     0x503c _objc_rootDealloc + 80
25 MicrosoftCognitiveServicesSpeech    0x185c58 pal_string_to_wstring + 782460
26 Span                                0x44748 AddVoiceViewModel.stopPreview() + 145 (AddVoiceViewModel.swift:145)
27 Span                                0x43058 AddVoiceViewModel.previewVoice(_:) + 59 (AddVoiceViewModel.swift:59)
28 Span                                0x67840 specialized AddVoiceView.previewVoice(_:didTapCell:) + 147 (AddVoiceView.swift:147)
29 Span                                0x67f74 partial apply for closure #1 in closure #2 in closure #1 in closure #1 in closure #1 in AddVoiceView.body.getter +<PHONE_NUMBER> (<compiler-generated>:4304928628)
30 Span                                0xcf370 partial apply for closure #1 in VoiceCell.body.getter + 20 (VoiceCell.swift:20)
31 SwiftUI                             0x198c318 OUTLINED_FUNCTION_2 + 900
32 SwiftUI                             0xf75c6c OUTLINED_FUNCTION_4 + 12156
33 SwiftUI                             0xf7be9c objectdestroy.73Tm + 300
34 SwiftUI                             0xf79b5c OUTLINED_FUNCTION_4 + 28268
35 SwiftUI                             0xf79aa8 OUTLINED_FUNCTION_4 + 28088
36 SwiftUI                             0x15f2b48 OUTLINED_FUNCTION_0 + 5048
37 SwiftUI                             0x15f1e3c OUTLINED_FUNCTION_0 + 1708
38 SwiftUI                             0x15f180c OUTLINED_FUNCTION_0 + 124
39 SwiftUI                             0x11474c0 OUTLINED_FUNCTION_11 + 40
40 SwiftUI                             0x11474e8 OUTLINED_FUNCTION_11 + 80
41 SwiftUI                             0x11474c0 OUTLINED_FUNCTION_11 + 40
42 SwiftUI                             0x1977230 OUTLINED_FUNCTION_4 + 2828
43 SwiftUI                             0x1977948 OUTLINED_FUNCTION_4 + 4644
44 SwiftUI                             0x1b3b42c OUTLINED_FUNCTION_3 + 152
45 SwiftUI                             0x18c3414 OUTLINED_FUNCTION_9 + 9908
46 SwiftUI                             0x18c193c OUTLINED_FUNCTION_9 + 3036
47 SwiftUI                             0x18c1acc OUTLINED_FUNCTION_9 + 3436
48 UIKitCore                           0x166494 -[UIGestureRecognizer _componentsEnded:withEvent:] + 172
49 UIKitCore                           0x1f408 -[UITouchesEvent _sendEventToGestureRecognizer:] + 464
50 UIKitCore                           0x1ba84 -[UIGestureEnvironment _deliverEvent:toGestureRecognizers:usingBlock:] + 172
51 UIKitCore                           0x1b9b0 -[UIGestureEnvironment _updateForEvent:window:] + 188
52 UIKitCore                           0x2054b8 -[UIWindow sendEvent:] + 3188
53 UIKitCore                           0x204748 -[UIApplication sendEvent:] + 560
54 UIKitCore                           0x1c6d88 __dispatchPreprocessedEventFromEventQueue + 6492
55 UIKitCore                           0x1c508c __processEventQueue + 5540
56 UIKitCore                           0x1c3a9c updateCycleEntry + 160
57 UIKitCore                           0xaad94 _UIUpdateSequenceRun + 84
58 UIKitCore                           0xaa484 schedulerStepScheduledMainSection + 144
59 UIKitCore                           0xaa540 runloopSourceCallback + 92
60 CoreFoundation                      0x37acc __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
61 CoreFoundation                      0x36d48 __CFRunLoopDoSource0 + 176
62 CoreFoundation                      0x354fc __CFRunLoopDoSources0 + 244
63 CoreFoundation                      0x34238 __CFRunLoopRun + 828
64 CoreFoundation                      0x33e18 CFRunLoopRunSpecific + 608
65 GraphicsServices                    0x35ec GSEventRunModal + 164
66 UIKitCore                           0x22f350 -[UIApplication _run] + 888
67 UIKitCore                           0x22e98c UIApplicationMain + 340
68 SwiftUI                             0x114d354 OUTLINED_FUNCTION_31 + 604
69 SwiftUI                             0x114d198 OUTLINED_FUNCTION_31 + 160
70 SwiftUI                             0xdca434 OUTLINED_FUNCTION_26 + 2196
71 Span                                0x77b8 main + 10 (SpanApp.swift:10)
72 ???                                 0x1be597d44 (Missing)

@ssadel thanks for the backtrace, could you please share the sample code how this could be reproduced?
@solossam we have a fix currently for the stop delay, the ETA would be 1.33.0 release (approx. end of the Oct 2023). The problem seems to be due to behavioral change in https://developer.apple.com/documentation/audiotoolbox/1501970-audioqueuestop?language=objc in iOS17 and which causes the delay with Speech SDK.
If your use case is to do synthesis playback via speaker output, one workaround for the issue before the SDK fix is released is to create SpeechSynthesizer using PullAudioOutputStream or PushAudioOutputStream and get the audio bytes from synthesis to your application and then stream the audio bytes to the device speaker using AVFoundation APIs.
If you want to try that route, for Push/PullAudioOutputStream examples, please take a look following Objective-C sample below (For Swift , it is similar, unfortunately we do not have Swift sample for the stream usage).
https://learn.microsoft.com/en-us/objectivec/cognitive-services/speech/spxspeechsynthesizer#initwithspeechconfigurationaudioconfiguration

hi @jhakulin is the update going out as planned?

Desperately need this fix too!
Not just the stopSpeaking, but also the stopContinuousRecognition() is taking much longer to return.

Desperately need this fix too!

Fix has been released in 1.33.0 Speech SDK release. Let us know if there are any problems.

Fix has been released in 1.33.0 Speech SDK release. Let us know if there are any problems.
stopContinuousRecognition still takes more than 5 seconds, even after I upgraded to 1.33.

Not really fixed(1.36), synthesizer.addSynthesisCompletedEventHandler still needs 10-20s to receive callback.

@jhakulin I am using version 1.37.0, and I have encountered a similar issue.
stopSpeaking does not immediately terminate the playback process; it only stops the speaker from playing.
For example, if I generate a 14-second audio and execute stopSpeaking at 10 seconds, then let speakResult = synthesizer?.speakSsml(ssml) will immediately return with speakResult?.reason=9(SPXResultReason_SynthesizingAudioCompleted) instead of 1(SPXResultReason_Canceled). Moreover, the callback registered with synthesizer?.addSynthesisCompletedEventHandler is triggered after waiting for 4 seconds, rather than the callback registered with synthesizer?.addSynthesisCanceledEventHandler.
let ssml =
          "<speak version='1.0' xml:lang='en-US' xmlns='http://www.w3.org/2001/10/synthesis' xmlns:mstts='http://www.w3.org/2001/mstts'><voice name='\(identifier)'>\(mstts)</voice></speak>"
let speakResult = try self.synthesizer?.speakSsml(ssml)
print(speakResult?.reason ?? "")

try synthesizer?.stopSpeaking()

Here is a demo repositorie: https://github.com/wtto00/flutter_azure_speech/tree/main/example
The swift code is in https://github.com/wtto00/flutter_azure_speech/blob/eb419b89fcc16903cabaa8f9820559d93ed80861/ios/Classes/AzureSpeechPlugin.swift#L294


Broken "explanation page" link in new-visitor blurb

The new visitor blurb links to https://www.ternaryplot.com/%E2%80%9Cexplain.html%E2%80%9D for its explanation page (smart quotes around explain.html), which results in a broken link.

Thanks for the notification, I will fix it right away!

It's fixed.


[vcr-2.0] Fix nullptr

IDK why the metric is missing in vcr.
Its not important however, we have other metrics in vcr. The missing metric is causing null ptr exc.

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 18.16%. Comparing base (2ec5676) to head (8af1cc1).

Files
Patch %
Lines

...m/github/ambry/replication/ReplicationMetrics.java
0.00%
2 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2752       +/-   ##
=============================================
- Coverage     70.66%   18.16%   -52.51%
+ Complexity    11593     2810     -8783
=============================================
  Files           834      834
  Lines         71049    71050        +1
  Branches       8536     8537        +1
=============================================
- Hits          50209    12905    -37304
- Misses        18208    56944    +38736
+ Partials       2632     1201     -1431

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Enhancement of ScrollBar

Is your feature request related to a problem? Please describe.
Well the site UI is attractive one , but a styled Scrollbar will weave a touch of elegance into the scrolling experience.
Describe the solution you'd like
Adding a elegant ScrollBar
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hello it's Levis again, I would like to have a look at this

Hey @LevisNgigi, How are you planning to solve this issue ?

Hello, I would just do a research of unique scrollbars and implement the code to the css file

I have raised the issue and would like to solve this issue under SWOC'24 .

Okay that is well noted

Hello, I am a frontend developer who creates stunning and modern websites .
I have done an internship as a frontend developer.
So I have more experience creating websites, animating them, and ensuring smooth scrolling.
I have very good knowledge of CSS and Tailwind CSS, so I can definitely enhance your scroll bar to match your website design.

Hey @parth3083, what are you planning with scroll bar? Any ideas?

I will first remove the scroll bar, which means that it will be displayed as none, resulting in a transparent scroll bar. After that, I will reduce the size of the scroll bar thumb and make it match the color pattern on your website.
I can also add smooth scrolling if you prefer.

Any idea of something more creative than just color scroll bar? 🤔 Try exploring, find something exciting. Assigning this to you!

@pranshugupta54 okay i will see what other thing i can do to this

How about - https://ui.aceternity.com/components/tracing-beam

is it a vite react app
and also tell me how to run your project

How about - https://ui.aceternity.com/components/tracing-beam

i will try to do it but first will remove the scroll bar and will add the smooth scrolling

is it a vite react app and also tell me how to run your project

Yes, its vite.
Join us on Discord for any help.

Any updates?


Create Camtrap-DP Database

SQL script to create a version of the camtrap-dp database (mysql). This is an adaptation of the camptrap-dp specification to a relational database structure (mysql). Foreign key constraints are intentionally omitted.
create_camptrap_dp_schema_20210617.sql.txt

Thanks @ben-norton, useful stuff!

I think this should be maintained as part of the Camtrap-DP repository. It's another way to describe and deploy Camtrap-DP. The key is to make sure it stays in sync. The script above is the starting place. Once a few more details get worked out, I'd be happy to handle updating the script.

I'm opting to close this issue.


PDF viewer support

Is your feature request related to a problem? Please describe.
I've been working on a form submission with file attachments, which includes images and pdf files. I've tried other libraries to make it possible to view both types using the same lightbox. No luck so far. Tried this library and love it due to ease of use. I was wondering if you can support for pdf files?
Describe the solution you'd like
Would be nice if I could add pdf file to slides along side images.
const slides = [
  { src: "/image1.jpg" },
  { src: "/ file1.pdf" },
  { src: "/file2.pdf" },
  // ...
];

Describe alternatives you've considered
No response
Additional context
No response

Sorry, but I have no plans for adding support for PDF files due to several reasons: a) I don't believe there is a single "gold standard" way of embedding a PDF file into a web page (and supporting all of them would be an over-kill); b) PDF embeds obscure touch / click events leading to poor swipe gesture / click-and-drag UX. I'll be happy to revisit this decision if you can suggest a way to address the above concerns.
However, you can always render your own custom slides with a custom render function.


Changes to the loading scripts

Main changes:

Add a possibility to load data from local fs
Add option to specify hosts of ClickHouse and ElasticSearch servers
Scripts to check the completeness of loaded data by comparing counts of input data (rows) and loaded data (rows and ES documents)
Script to all loads (ot+sumstats) altogether.

This PR includes changes in https://github.com/opentargets/genetics-backend/pull/10
Please note that the loading data directly from Google cloud was not fully tested after the changes.

@mkarmona Could you please have a look whether there are changes worth taking upstream.

@forus this pr is going to be a bit painful. Would you mind please have a look at my open PR as it contains the full changeset for the new release? I saw a few fixes you did I already did too.thanks!


[spirv] Add a better tiled and vectorized convolution path

This commit tiles a 2-D convolution along the output height, width,
and channel dimensions. The tiled convolution is distributed to
workgroup of size 32x8x1, with each group containing 8x2x1
invocations. This is just the initial configuration for Mali to
get started. After tiling, we further vectorize the convolution
for each GPU invocation. For vectorization, the whole filter subview
is vector loaded and shared for computation. Then we vector load
along the input channel and perform vector dot product. This can
give us 100x improvement over the current simple convolution
implementation.

This PR is basically emitting code following https://github.com/google/uVkCompute/blob/main/benchmarks/convolution/conv2d_tiled.glsl, which can serve as a reference for understanding.