compiler warning with Visual Studio 2019 [5111]

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\xstring(2268): warning C4244: 'argument': conversion from 'wchar_t' to 'const _Elem', possible loss of data [C:\J\workspace\ci_windows_vs2019\ws\build\fastrtps\src\cpp\fastrtps.vcxproj]
          with
          [
              _Elem=char
          ] (compiling source file C:\J\workspace\ci_windows_vs2019\ws\src\eProsima\Fast-RTPS\src\cpp\types\DynamicData.cpp)
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\xstring(2279): note: see reference to function template instantiation 'void std::basic_string<char,std::char_traits<char>,std::allocator<char>>::_Construct<wchar_t*>(_Iter,const _Iter,std::input_iterator_tag)' being compiled
          with
          [
              _Iter=wchar_t *
          ] (compiling source file C:\J\workspace\ci_windows_vs2019\ws\src\eProsima\Fast-RTPS\src\cpp\types\DynamicData.cpp)
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\xstring(2279): note: see reference to function template instantiation 'void std::basic_string<char,std::char_traits<char>,std::allocator<char>>::_Construct<wchar_t*>(_Iter,const _Iter,std::input_iterator_tag)' being compiled
          with
          [
              _Iter=wchar_t *
          ] (compiling source file C:\J\workspace\ci_windows_vs2019\ws\src\eProsima\Fast-RTPS\src\cpp\types\DynamicData.cpp)
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\xstring(2259): note: see reference to function template instantiation 'void std::basic_string<char,std::char_traits<char>,std::allocator<char>>::_Construct<wchar_t*>(const _Iter,const _Iter,std::forward_iterator_tag)' being compiled
          with
          [
              _Iter=wchar_t *
          ] (compiling source file C:\J\workspace\ci_windows_vs2019\ws\src\eProsima\Fast-RTPS\src\cpp\types\DynamicData.cpp)
  DynamicTypePtr.cpp
  C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.20.27508\include\xstring(2259): note: see reference to function template instantiation 'void std::basic_string<char,std::char_traits<char>,std::allocator<char>>::_Construct<wchar_t*>(const _Iter,const _Iter,std::forward_iterator_tag)' being compiled
          with
          [
              _Iter=wchar_t *
          ] (compiling source file C:\J\workspace\ci_windows_vs2019\ws\src\eProsima\Fast-RTPS\src\cpp\types\DynamicData.cpp)
  C:\J\workspace\ci_windows_vs2019\ws\src\eProsima\Fast-RTPS\src\cpp\types\DynamicData.cpp(1117): note: see reference to function template instantiation 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>::basic_string<std::_String_iterator<std::_String_val<std::_Simple_types<_Elem>>>,void>(_Iter,_Iter,const _Alloc &)' being compiled
          with
          [
              _Elem=wchar_t,
              _Iter=std::_String_iterator<std::_String_val<std::_Simple_types<wchar_t>>>,
              _Alloc=std::allocator<char>
          ]
  C:\J\workspace\ci_windows_vs2019\ws\src\eProsima\Fast-RTPS\src\cpp\types\DynamicData.cpp(1117): note: see reference to function template instantiation 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>::basic_string<std::_String_iterator<std::_String_val<std::_Simple_types<_Elem>>>,void>(_Iter,_Iter,const _Alloc &)' being compiled
          with
          [
              _Elem=wchar_t,
              _Iter=std::_String_iterator<std::_String_val<std::_Simple_types<wchar_t>>>,
              _Alloc=std::allocator<char>
          ]

@richiprosima Any chance you can address this in the near future in order for us to move forward with the Visual Studio 2019 rollout?

We were talking internally when we will make the change to vs2019. We had
in mind to ask you your plans with vs2019. Knowing your intentions,
tomorrow i will bring up to prioritize it.
El jue., 11 abr. 2019 20:49, Dirk Thomas<EMAIL_ADDRESS>escribió:

@richiprosima https://github.com/richiprosima Any chance you can
address this in the near future in order for us to move forward with the
Visual Studio 2019 rollout?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/eProsima/Fast-RTPS/issues/485#issuecomment-482250356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGEOrQk3DI2Ll839sMQjD7Tr7DRHmsVMks5vf4O0gaJpZM4cl6f5
.

El jue., 11 abr. 2019 20:49, Dirk Thomas<EMAIL_ADDRESS>escribió:

@richiprosima https://github.com/richiprosima Any chance you can
address this in the near future in order for us to move forward with the
Visual Studio 2019 rollout?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/eProsima/Fast-RTPS/issues/485#issuecomment-482250356,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGEOrQk3DI2Ll839sMQjD7Tr7DRHmsVMks5vf4O0gaJpZM4cl6f5
.

We were talking internally when we will make the change to vs2019. We had
in mind to ask you your plans with vs2019. Knowing your intentions,
tomorrow i will bring up to prioritize it.

As soon as everything passes green we will consider to switch. The latest builds look very promising and only show this one specific compiler warning. All tests pass just fine. So if you could address at least this one warning we would probably move forward with the switch.

@richiware Can you provide an update what your time frame for addressing this warning will be?

Changes in #489 fix the warnings. Sure @RaquelAlvarezBanos or @LuisGP can finish the review and merge the changes.

Changes in #489 fix the warnings.

:+1: I can confirm that the referenced PR fixes the warning for our Windows CI too. Thanks.

@richiware @dirk-thomas: this is now merged


same ip for all requests

In some networks the logged ips are same for all users and this cause block all requests for all users.please use below code for getting user ip in your Traits/Helper.php file.
public function ip()
    {
       $client = @$_SERVER['HTTP_CLIENT_IP'];
        $forward = @$_SERVER['HTTP_X_FORWARDED_FOR'];
        $remote = @$_SERVER['REMOTE_ADDR'];
        if (filter_var($client, FILTER_VALIDATE_IP)) {
            $ip = $client;
        } elseif (filter_var($forward, FILTER_VALIDATE_IP)) {
            $ip = $forward;
        } else {
            $ip = $remote;
        }
        return $ip ?: '<IP_ADDRESS>';
    }

+1
I've noticed on some projects, including those that use Cloudflare, that we get the edge IP, not the user IP, and this has caused blocks to other users.


change ARC PowerShell Examples

-vmname is not an accepted parameter of the command New-AzConnectedMachineExtension updated to -MachineName

@scautomation : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@scautomation Thanks for noticing that. It looks like you updated the Azure VM examples though. Can you change the Azure Arc ones, and I'll go ahead and sign off.

Thanks!
#sign-off


Automatically add users to watch a specific book or add all users to shelves to send notifications

Describe the feature you'd like
We are using bookstack also as an information plattform to store news and send them to our bookstack users.
the problem is, the users need to watch the book, to get the information. It would be realy nice if there was an option to automatically add a usergroup to watch the book, or even better the whole shelve.
Describe the benefits this would bring to existing BookStack users
Centralized adding users to watch pages, books and shelves
Can the goal of this request already be achieved via other means?
as a work around I can manually add all users to the watch by searching the book id and adding all users to the watch table  by running sql statements in the database;
INSERT INTO watches  SELECT NULL,u.id, 26, 'book', 2, NOW(),NOW()  FROM users u where u.id not in (SELECT user_id from watches where watchable_id=26);
a even better work around would be to create a trigger which checks if the book is under a specific shelve and then automatically add all users to this book
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundamental request

How long have you been using BookStack?
3 months to 1 year
Additional context
No response

Thanks for the request @Manuel311290 but I feel the fundamental request here is already covered by #4514, so I'm going to therefore close this off.
Instead of database usage, it is likely also possible to achieve this via the logical theme system, if comfortable getting into PHP, which can allow you to hook into certain system events to update the watch status as desired.


Learning rate scheduler is invalid

Bug description
I am following the tutorial to reproduce the result of SimCLR (https://uvadlc-notebooks.readthedocs.io/en/latest/tutorial_notebooks/tutorial17/SimCLR.html) and I get the error notifying that the learning rate schedular is invalid.
Traceback (most recent call last):
  File "/home/ellen/ContrastiveLearning/train.py", line 61, in <module>
    simclr_model = train_simclr(hidden_dim=128, lr=args["learning_rate"],
  File "/home/ellen/ContrastiveLearning/train.py", line 56, in train_simclr
    trainer.fit(model, train_loader, val_loader)
  File "/home/ellen/anaconda3/envs/cl/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 553, in fit
    self._run(model)
  File "/home/ellen/anaconda3/envs/cl/lib/python3.9/site-packages/pytorch_lightning/trainer/trainer.py", line 874, in _run
    self.accelerator.setup(self, model)  # note: this sets up self.lightning_module
  File "/home/ellen/anaconda3/envs/cl/lib/python3.9/site-packages/pytorch_lightning/accelerators/gpu.py", line 42, in setup
    return super().setup(trainer, model)
  File "/home/ellen/anaconda3/envs/cl/lib/python3.9/site-packages/pytorch_lightning/accelerators/accelerator.py", line 88, in setup
    self.setup_optimizers(trainer)
  File "/home/ellen/anaconda3/envs/cl/lib/python3.9/site-packages/pytorch_lightning/accelerators/accelerator.py", line 330, in setup_optimizers
    optimizers, lr_schedulers, optimizer_frequencies = self.training_type_plugin.init_optimizers(
  File "/home/ellen/anaconda3/envs/cl/lib/python3.9/site-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 223, in init_optimizers
    return trainer.init_optimizers(model)
  File "/home/ellen/anaconda3/envs/cl/lib/python3.9/site-packages/pytorch_lightning/trainer/optimizers.py", line 99, in init_optimizers
    lr_schedulers = self.configure_schedulers(lr_schedulers, monitor, is_manual_optimization)
  File "/home/ellen/anaconda3/envs/cl/lib/python3.9/site-packages/pytorch_lightning/trainer/optimizers.py", line 176, in configure_schedulers
    raise ValueError(f'The provided lr scheduler "{scheduler}" is invalid')
ValueError: The provided lr scheduler "<torch.optim.lr_scheduler.ExponentialLR object at 0x7fda400bdee0>" is invalid

What version are you seeing the problem on?
1.9.x
How to reproduce the bug
Here is the code to configure the optimizer and learning rate schedular
def configure_optimizers(self):
        optimizer = optim.AdamW(self.parameters(),
                                lr=self.hparams.lr,
                                weight_decay=self.hparams.weight_decay)
        lr_scheduler = optim.lr_scheduler.CosineAnnealingLR(optimizer,
                                                            T_max=self.hparams.max_epochs)
        return [optimizer], [lr_scheduler]

Error messages and logs
# Error messages and logs here please

Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info
No response
cc @borda

@tungts1101 Could you please share the code that you ran producing this error? The error message you posted does not match the code snippet.

I am facing the same error on torch 2.0.1 for the learning rate scheduler StepLR

Downgrading to torch==1.13.1 torchvision==0.14.1 worked for me

@kvnptl here is a code example that works with torch 2.0 and the StepLR scheduler. Could you please modify it to produce the error you are seeing? I can't reproduce what you are saying.

import torch
from torch.utils.data import DataLoader, Dataset

from lightning.pytorch import LightningModule, Trainer

class RandomDataset(Dataset):
    def __init__(self, size, length):
        self.len = length
        self.data = torch.randn(length, size)

    def __getitem__(self, index):
        return self.data[index]

    def __len__(self):
        return self.len

class BoringModel(LightningModule):
    def __init__(self):
        super().__init__()
        self.layer = torch.nn.Linear(32, 2)

    def forward(self, x):
        return self.layer(x)

    def training_step(self, batch, batch_idx):
        loss = self(batch).sum()
        self.log("train_loss", loss)
        return {"loss": loss}

    def configure_optimizers(self):
        optimizer = torch.optim.SGD(self.layer.parameters(), lr=0.1)
        scheduler = torch.optim.lr_scheduler.StepLR(optimizer, step_size=1)
        return [optimizer], [scheduler]

def run():
    train_data = DataLoader(RandomDataset(32, 64), batch_size=2)
    model = BoringModel()
    trainer = Trainer(max_epochs=2)
    trainer.fit(model, train_dataloaders=train_data)

if __name__ == "__main__":
    run()

@awaelchli Here is an example that causes the same error: https://github.com/THUNLP-MT/PS-VAE/blob/0dfcbd25b91e1127e556cb3c273260a41a1c3f35/src/pl_models/ps_vae_model.py#L126
This is the output after I run collect_env:
Collecting environment information...
.../lib/python3.9/site-packages/torch/cuda/__init__.py:173: UserWarning:
NVIDIA H100 PCIe with CUDA capability sm_90 is not compatible with the current PyTorch installation.
The current PyTorch install supports CUDA capabilities sm_37 sm_50 sm_60 sm_61 sm_70 sm_75 sm_80 sm_86 compute_37.
If you want to use the NVIDIA H100 PCIe GPU with PyTorch, please check the instructions at https://pytorch.org/get-started/locally/

  warnings.warn(incompatible_device_warn.format(device_name, capability, " ".join(arch_list), device_name))
PyTorch version: 2.0.1
Is debug build: False
CUDA used to build PyTorch: 11.7
ROCM used to build PyTorch: N/A

OS: CentOS Linux release 8.1.1911 (Core)  (x86_64)
GCC version: (GCC) 8.3.1 20190507 (Red Hat 8.3.1-4)
Clang version: Could not collect
CMake version: version 3.11.4
Libc version: glibc-2.28

Python version: 3.9.17 (main, Jul  5 2023, 20:41:20)  [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-4.18.0-147.8.1.el8_2.arc.x86_64-x86_64-with-glibc2.28
Is CUDA available: True
CUDA runtime version: 11.7.64
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA H100 PCIe
GPU 1: NVIDIA H100 PCIe
GPU 2: NVIDIA H100 PCIe
GPU 3: NVIDIA H100 PCIe

Nvidia driver version: 525.116.04
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
CPU(s):              48
On-line CPU(s) list: 0-47
Thread(s) per core:  1
Core(s) per socket:  24
Socket(s):           2
NUMA node(s):        2
Vendor ID:           GenuineIntel
CPU family:          6
Model:               106
Model name:          Intel(R) Xeon(R) Gold 6342 CPU @ 2.80GHz
Stepping:            6
CPU MHz:             800.421
BogoMIPS:            5600.00
Virtualization:      VT-x
L1d cache:           48K
L1i cache:           32K
L2 cache:            1280K
L3 cache:            36864K
NUMA node0 CPU(s):   0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46
NUMA node1 CPU(s):   1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47
Flags:               fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 invpcid_single ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local wbnoinvd dtherm ida arat pln pts avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq rdpid md_clear pconfig flush_l1d arch_capabilities

Versions of relevant libraries:
[pip3] numpy==1.24.3
[pip3] pytorch-lightning==1.5.7
[pip3] torch==2.0.1
[pip3] torch-geometric==2.3.1
[pip3] torchaudio==0.8.1
[pip3] torchmetrics==0.9.3
[pip3] torchvision==0.15.2
[conda] blas                      1.0                         mkl
[conda] cudatoolkit               11.3.1              h9edb442_10    conda-forge
[conda] cudatoolkit-dev           11.7.0               h1de0b5d_6    conda-forge
[conda] ffmpeg                    4.3                  hf484d3e_0    pytorch
[conda] mkl                       2021.4.0           h06a4308_640
[conda] mkl-service               2.4.0            py39h7e14d7c_0    conda-forge
[conda] mkl_fft                   1.3.1            py39h0c7bc48_1    conda-forge
[conda] mkl_random                1.2.2            py39hde0f152_0    conda-forge
[conda] numpy                     1.26.0                   pypi_0    pypi
[conda] numpy-base                1.24.3           py39h31eccc5_0
[conda] pyg                       2.3.1           py39_torch_2.0.0_cu117    pyg
[conda] pytorch                   2.0.1           py3.9_cuda11.7_cudnn8.5.0_0    pytorch
[conda] pytorch-cuda              11.7                 h778d358_5    pytorch
[conda] pytorch-lightning         1.5.7                    pypi_0    pypi
[conda] pytorch-mutex             1.0                        cuda    pytorch
[conda] torchaudio                0.8.1                    pypi_0    pypi
[conda] torchmetrics              0.9.3                    pypi_0    pypi
[conda] torchtriton               2.0.0                      py39    pytorch
[conda] torchvision               0.9.1+cu101              pypi_0    pypi

I am facing the same error on torch 2.0.1 for the learning rate scheduler StepLR

Downgrading to torch==1.13.1 torchvision==0.14.1 worked for me

It works for me, thank you very much!

I am facing the same error on torch 2.0.1 for the learning rate scheduler StepLR

Downgrading to torch==1.13.1 torchvision==0.14.1 worked for me

It works for me! Thanks

For the torch > 2.0.1, you should set it to :
lr_scheduler == {'scheduler': ExponentialLR(gen_opt, 0.99), 'interval': 'step'}

For earlier versions of torch and pytorch-lightning, learning rate schedulers inherit from optim.lr_scheduler._LRScheduler. In the latest torch, they inherit from optim.lr_scheduler.LRScheduler. In the older versions of pytorch-lightning, the learning rate scheduler is checked using isinstance(scheduler, optim.lr_scheduler._LRScheduler), which results in the inability to recognize the learning rate schedulers of the newer version of torch.

lr_scheduler == {'scheduler': ExponentialLR(gen_opt, 0.99), 'interval': 'step'}

This worked for me. Thanks a lot!


Create a test to check the validity of the available social media sites

Can use an existing test. All of the sites needs to be in the test case. If one of them isn't valid anymore, the test case will fail.


SSH Proxy with Password Authentication

Summary
After a pentest has been executed an issue with ssh-proxy was found. The service obviously accepts password authentication. Due to the limitations of the test, no automated tools were used to test for valid username/password‐combinations. Two key exchange algorithms, namely diffie-hellman-group14-sha1 and ecdh-sha2-nistp384, are considered weak by the tool sslcan.
Expected Result
According to the penetration testers:

It is assumed that this is for administrative use. In that case the support of password logins poses an additional risk. The “weak” key exchange ciphers currently do not add a noticeable risk here. However, it remains unclear, why an SSH service is exposed to the internet. While an unnecessary service without further findings would usually result in a finding of a low severity, the severity was raised to medium in this case, due to risk that is related to password logins. It should be analysed, if the SSH service needs to be exposed to the internet and if so, if access can be restricted to known source IP addresses. It should also be assessed, if password login can be switched off.

Questions:

Is it possible ssh-proxy feature to be enabled only for specific applications by the app developers?
Is it possible that the key exchange algorithms be enhanced with "stronger" ones?
Is it possible that the access be restricted to known source IP addresses?

Context
Diego version 2.49.0
Infrastructure - Azure
Steps to Reproduce
Run penetration test with sslcan.

Hello Colleagues,
Is there any process around this story?
I have no access to the story and our customers are about to escalate already.
Thanks & Best regards,
Alexander

Apologizes for missing this. Thank you for pinging us on slack.

Is it possible ssh-proxy feature to be enabled only for specific applications by the app developers?

Yes. Please see this doc to see how you can limit who can ssh and what apps can be ssh-ed onto.

Is it possible that the key exchange algorithms be enhanced with "stronger" ones?
Yes, you can supply your own key exchange algorithms using the diego.ssh_proxy.allowed_keyexchanges bosh property seen here.

Is it possible that the access be restricted to known source IP addresses?
This is something you would have to configure outside of Cloud Foundry, such as configuring your ssh LB.


[FR] - cardano-testnet: DevX improvements

External
Area
Other
Describe the feature you'd like
We're considering replacing Plutip with cardano-testnet, and we'd like to see some changes upstream for our convenience.

We'd like to make running the test suite optional, configurable via a CLI option. We really need faster startup times.
We'd like to see more structured output (e.g. JSON) so that we can parse the TMP dir to get the node socket path, etc.

If we implement these changes in a PR, would it be considered for acceptance?

cc @Jimbo4350 @carbolymer

We'd like to make running the test suite optional, configurable via a CLI option. We really need faster startup times.

Actually, there are no tests executed when you're starting cardano-testnet using the  cardano-testnet executable. It may appear so, because we're leveraging hedgehog's PropertyT when setting up the testnet nodes. So we're kind of abusing it to print debugging information by failing the test suite. All it does is starting the nodes and doing the healthcheck, so I think you won't get more speedup than it is right now (speaking about version in master).

We'd like to see more structured output (e.g. JSON) so that we can parse the TMP dir to get the node socket path, etc.

Definitely, if you feel that you can make the output both human readable and machine readable (by some toggle?) we'd be up for it.

If we implement these changes in a PR, would it be considered for acceptance?

Sure, if it won't be disruptive too much. It would be preferable if you could submit your changes in few smaller PRs.

@carbolymer Thank you!
I have one more question: would it be possible for it to start instantly in the latest era, skipping the initial era transitions?

That's supported already. In some of the test cases we're starting in Conway already, for example in here: https://github.com/IntersectMBO/cardano-node/blob/3d5df51000fbbf7492eba48f2bbc2472706abe17/cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/ProposeNewConstitution.hs#L74


Removing a Control breaks Leaflet zooming and panning

Running Leaflet 1.0.0 rc3 and React-Leaflet 1.0.0 beta 3, occurs in both Microsoft Edge and Chrome.
Description
If I add, then remove a Control component from a Map component, the Map no longer responds to zoom or panning, and features on top of the map render extremely weirdly. No errors are logged to console.
Cause:
I narrowed this down to the onRemove function in Control.Dumb.js. I think onRemove doesn't remove events for the Control component properly, so it breaks all events on the Map component.
Workaround:
Removing onRemove entirely fixes the bug (i.e. I can add and remove as many Controls as I want without problems).
Could this be a result of a change in Leaflet 1.0 that isn't changed in onRemove?

Adding a check around the call to map.off also works:
if (this.onOff) {
      map.off(this.options.onOff, this.options.handleOff, this);
    }

Perhaps this can be the "official" fix for this?

I will not be said to fix this until tomorrow night. Your welcome to make a pull request with the changes described

Done - thanks!


dockutil 3.0.0-beta.1 --allhomes as root fails

Thanks for the new dockutil Beta! :-)
I encountered a Bug when executed as root. When i execute it with the normal user it works for the current user. Version 2.0.5 docked it to all homes with this command, the 3.0.0 beta1 fails.
sudo /usr/local/bin/dockutil --add '/Applications/Microsoft Edge.app' --after 'Mission Control' --allhomes
Error: /var/root/Library/Preferences/com.apple.dock.plist does not seem to be a home directory or a dock plist
Usage: dockutil [<options>] [<plist-location-specification> ...]
  See 'dockutil --help' for more information.
[file:///Users/.localized, file:///Users/Shared/, file:///Users/testuser1/, file:///Users/testuser2/]
/Users/.localized/Library/Preferences
/Users/Shared/Library/Preferences
/Users/testuser1/Library/Preferences
/Users/testuser2/Library/Preferences

Thanks for testing and reporting the issue! I will investigate.

We see similar issues as @kiepenflicker . (we run dockutil as postinstall script from WorkspaceONE, it runs as root, so the --allhomes feature is used to manage the current user's dock). If needed, ping me to give more troubleshooting info.

Thanks for your patience.  Please retest in beta 2.  It should be fixed.

Yes, fixed for me! Many thanks for this rewrite of dockutil!

I'll close this specific issue but if you see others please do report them.
Thanks @kiepenflicker and @mjsanders


fix(transport): libp2p compilation in Nim version-2-0

For example:
/Users/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/websock-0.1.0-94f836ae589056b2deb04bdfdcd614fff80adaf5/websock/http/client.nim(173, 5) template/generic instantiation of `async` from here
/Users/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/websock-0.1.0-94f836ae589056b2deb04bdfdcd614fff80adaf5/websock/http/client.nim(165, 1) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/websock-0.1.0-94f836ae589056b2deb04bdfdcd614fff80adaf5/websock/websock.nim(257, 5) template/generic instantiation of `async` from here
/Users/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/websock-0.1.0-94f836ae589056b2deb04bdfdcd614fff80adaf5/websock/websock.nim(251, 1) Warning: The raises pragma doesn't work on async procedures - use `async: (raises: [...]) instead. [User]
/Users/runner/work/nim-libp2p/nim-libp2p/libp2p/transports/wstransport.nim(77, 18) template/generic instantiation of `async` from here
/Users/runner/work/nim-libp2p/nim-libp2p/libp2p/transports/wstransport.nim(83, 10) template/generic instantiation of `setResult` from here
/Users/runner/work/nim-libp2p/nim-libp2p/libp2p/transports/wstransport.nim(78, 26) template/generic instantiation of `mapExceptions` from here
/Users/runner/work/nim-libp2p/nim-libp2p/nimbledeps/pkgs2/chronos-4.0.2-c5e9517b9189713210e2abab8b77a68da71ded12/chronos/internal/asyncmacro.nim(542, 60) Error: expression 'value(cast[type(recv(s.session, pbytes, nbytes))](chronosInternalRetFuture.internalChild))' is of type 'int' and has to be used (or discarded); start of expression here: /Users/runner/work/nim-libp2p/nim-libp2p/libp2p/transports/wstransport.nim(78, 26)
stack trace: (most recent call last)

from https://github.com/vacp2p/nim-libp2p/actions/runs/10655841970/job/29533846606?pr=1145
For minimal example of this:
template g(body: untyped) =
  try:
    body
  except CatchableError:
    raise newException(CatchableError, "")

discard g(0)

Also, even in 2.0.8, a variation doesn't work:
template g(body: untyped) = body
discard g(0)

Thanks for the fix. What is the cause of the issue? Was it implemented in a wrong, but supported way? This code hasn't changed for more than 2 years.

Thanks for the fix. What is the cause of the issue? Was it implemented in a wrong, but supported way? This code hasn't changed for more than 2 years.

Some change from post-Nim 2.0.8 version-2-0 did trigger stricter checking in these instances of the return type of the template. The template, arguably, was always incorrect: it didn't indicate that it returned anything, and see examples, it only works because Nim got confused by the exception construction until recently.
For another, close example of Nim 2.0.8 already disallowing/being confused by this incorrect return type declaration:
template g(body: untyped) =
  try:
    body
  except CatchableError:
    raiseAssert ""

discard g(0)

yields
a.nim(7, 11) Error: expression '0' is of type 'int literal(0)' and has to be used (or discarded)

i.e. it was specifically that raise newException(...) bypassed this check somehow.

The error message seems a bit confusing. In the original error, it gets used, and your example is discarded.

The error message seems a bit confusing. In the original error, it gets used, and your example is discarded.

Not in a relevant way. Same error message:
template g(body: untyped) =
  try:
    body
  except CatchableError:
    raiseAssert ""

let t = g(0)

discard outside of the template is a red herring. The "discarding" it's complaining about it in the template g/mapExceptions itself, not in the code calling/invoking it.

The error message mentions the line where it is used.

The error message mentions the line where it is used.

Yes, it's a template. It doesn't really exist until it's instantiated.


Switch to uber gomock

What changed?

Switch to uber gomock
Will do the same change in server repo as well.

Why?

google gomock is no longer maintained and doesn't support generics
Generated mocks are used in server repo as well. and we are switching server repo to uber gomock.

How did you test it?

Potential risks

Will generate mocks inside server repo.


Allow omission of options

I have an already-well-defined operation, with defaults specified 'pythonically', which I would like to invoke through Click. Unfortunately, because options can't be omitted in the function call, it's impossible to take advantage of the defaults already specified, meaning they would have to be specified in multiple places meaning lots of complexity.
Here is my function (with implementation omitted)...
def run(release=None, port=None, baud=1500000, erase=True, device=None):
    pass

Wrapping this with Click looks like...
@click.command()
@click.option("--release", "-r")
@click.option("--port", "-p")
@click.option("--baud", "-b")
@click.option("--erase", "-e")
@click.option("--device", "-d")
def main(*a, **k):
    run(*a, **k)

However, because click always passes None values rather than omitting values I end up with **k populated like...
{'release': None, 'port': None, 'baud': None, 'erase': None, 'device': None}

Having every option passed as a None value destroys any chance of me pythonically defining defaults.
I propose adding an 'optional' argument to Option so the None values would not be in the **k dict in the first place. Then the new click decorators would look like...
@click.command()
@click.argument("target", type=click.Choice(brains), optional=True)
@click.option("--release", "-r", optional=True)
@click.option("--port", "-p", optional=True)
@click.option("--baud", "-b", optional=True)
@click.option("--erase", "-e", optional=True)
@click.option("--device", "-d", optional=True)
def main(*a, **k):
    run(*a, **k)

And the new **k from a no-arg call to the cli would look like...
{}

For others encountering this limitation, the following workaround, which filters and drops None values before passing on to the underlying call is reasonably elegant, and makes the use of pythonic defaults possible again, although explicit support without this workaround would be very welcome...
@click.command()
@click.option("--release", "-r")
@click.option("--port", "-p")
@click.option("--baud", "-b")
@click.option("--erase", "-e")
@click.option("--device", "-d")
def main(*a, **k):
    k = dict((name,value) for name, value in k.items() if value is not None)
    run(*a, **k)

That won't work in the following case:
@click.option('--whatever', type=(int, int))
because the default value for that option is (None, None) and if you try to set the default to None, eg:
@click.option('--whatever', type=(int, int), default=None)
then click will not accept the default and raises an exception. In general the workaround can be extended to catch these cases something like this::
... if not (value is None or (isinstance(value, tuple) and all(x is None for x in value)))

As I mentioned in the related issue I think this similarly could be solved with callbacks, parsing in the function body or potentially sub classes.
I'm not sure there is much value in adding more flags to option, but I think it is at least in line with the existing API of option.
Check out this example from the docs: https://github.com/pallets/click/blob/master/examples/validation/validation.py


HBASE-25535 Set span kind to CLIENT in AbstractRpcClient

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-22120 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
HBASE-22120 passed

+1 :green_heart:
compile
5m  1s
HBASE-22120 passed

+1 :green_heart:
checkstyle
2m  3s
HBASE-22120 passed

+1 :green_heart:
spotbugs
3m 47s
HBASE-22120 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
compile
4m 57s
the patch passed

+1 :green_heart:
javac
4m 57s
the patch passed

+1 :green_heart:
checkstyle
2m  0s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 59s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
4m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

64m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2907

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 3a2fd294f594 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-22120 / 04621e541b

Default Java
AdoptOpenJDK-1.8.0_232-b09

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ HBASE-22120 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  4s
HBASE-22120 passed

+1 :green_heart:
compile
5m  1s
HBASE-22120 passed

+1 :green_heart:
checkstyle
2m  3s
HBASE-22120 passed

+1 :green_heart:
spotbugs
3m 47s
HBASE-22120 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 49s
the patch passed

+1 :green_heart:
compile
4m 57s
the patch passed

+1 :green_heart:
javac
4m 57s
the patch passed

+1 :green_heart:
checkstyle
2m  0s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 59s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
4m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

64m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2907

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux 3a2fd294f594 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-22120 / 04621e541b

Default Java
AdoptOpenJDK-1.8.0_232-b09

Max. process+thread count
86 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-22120 Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 12s
HBASE-22120 passed

+1 :green_heart:
compile
2m  0s
HBASE-22120 passed

+1 :green_heart:
shadedjars
7m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 30s
HBASE-22120 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
2m  6s
the patch passed

+1 :green_heart:
javac
2m  6s
the patch passed

+1 :green_heart:
shadedjars
7m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 10s
hbase-client in the patch passed.

+1 :green_heart:
unit
137m  2s
hbase-server in the patch passed.

173m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2907

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b3c7aaadd411 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-22120 / 04621e541b

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/testReport/

Max. process+thread count
4438 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-22120 Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m 12s
HBASE-22120 passed

+1 :green_heart:
compile
2m  0s
HBASE-22120 passed

+1 :green_heart:
shadedjars
7m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 30s
HBASE-22120 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s
the patch passed

+1 :green_heart:
compile
2m  6s
the patch passed

+1 :green_heart:
javac
2m  6s
the patch passed

+1 :green_heart:
shadedjars
7m  6s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 36s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m 10s
hbase-client in the patch passed.

+1 :green_heart:
unit
137m  2s
hbase-server in the patch passed.

173m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2907

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux b3c7aaadd411 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-22120 / 04621e541b

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/testReport/

Max. process+thread count
4438 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-22120 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 45s
HBASE-22120 passed

+1 :green_heart:
compile
1m 47s
HBASE-22120 passed

+1 :green_heart:
shadedjars
7m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 24s
HBASE-22120 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

+1 :green_heart:
shadedjars
7m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 37s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m  3s
hbase-client in the patch passed.

+1 :green_heart:
unit
148m  1s
hbase-server in the patch passed.

182m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2907

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 765180060abb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-22120 / 04621e541b

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/testReport/

Max. process+thread count
4260 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 28s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ HBASE-22120 Compile Tests _

+0 :ok:
mvndep
0m 22s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 45s
HBASE-22120 passed

+1 :green_heart:
compile
1m 47s
HBASE-22120 passed

+1 :green_heart:
shadedjars
7m 10s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 24s
HBASE-22120 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
1m 48s
the patch passed

+1 :green_heart:
javac
1m 48s
the patch passed

+1 :green_heart:
shadedjars
7m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
1m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 37s
hbase-common in the patch passed.

+1 :green_heart:
unit
1m  3s
hbase-client in the patch passed.

+1 :green_heart:
unit
148m  1s
hbase-server in the patch passed.

182m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2907

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 765180060abb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
HBASE-22120 / 04621e541b

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/testReport/

Max. process+thread count
4260 (vs. ulimit of 30000)

modules
C: hbase-common hbase-client hbase-server U: .

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2907/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


OAuth1 authentication is broken since version 0.11

Hi,
it seems since version 0.11 the OAuth1 authentication is broken. If I try to authenticate with Twitter or Xing, then I get the following message:
XMLHttpRequest cannot load https://twitter.com/oauth/authenticate?oauth_token=***. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:9000' is therefore not allowed access.

It seems that the most OAuth1 providers doesn't send a access-control-allow-origin:* header.
In the previous versions this wasn't a problem. Maybe this has changed with commit https://github.com/sahat/satellizer/commit/50a31109f969dcca18c7513c99c290f08d6b2bed

Are you sure it not just your setup at twitter that is wrong? localhost has never worked for me. I have to use 127.0.01 on twitter.

With version 0.10.1 it works as expected even on localhost. I've also the same problem with the Xing OAuth1 provider.

+1.
Before, the server was performing the redirect, now the satellizer expects it to just return the redirect parameters in JSON and do the redirect on its own.


Make my own word list

I'm new to this "thing".  I love what has been created here.   I am from Newfoundland, Canada.  We even have our own dictionary.  LOL  I have compiled a 650 word list that is unique to the Newfoundland dictionary.  I'd like to make a Newfoundland Wordle.  What parts of the project do I need to change?   Thanks in advance :-)

Heya!
The instructions for making your own fork with additional language inputs can be found here: https://github.com/cwackerfuss/react-wordle#how-can-i-create-a-version-in-another-language
Hope this helps!

Thanks.  Will take a look :-). My first attempt was unsuccessful.   Will
have another go at it later today.  Thanks for the quick response.
Regards,
Wylie
On Tue, Nov 1, 2022, 9:23 a.m. modem7 @.***> wrote:

Heya!
The instructions for making your own fork with additional language inputs
can be found here:
https://github.com/cwackerfuss/react-wordle#how-can-i-create-a-version-in-another-language
Hope this helps!
—
Reply to this email directly, view it on GitHub
https://github.com/modem7/react-wordle/issues/106#issuecomment-1298405241,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGQWNPCZTQOCUJGE4DLLT3DWGEAEZANCNFSM6AAAAAART64NIQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


${version} folder is generated in release folder

A folder with the variable is generated before the release folder is generated. It only contains the .icon-icns file.
https://github.com/caoxiemeihao/electron-vue-vite/blob/e522cf352d2c2d2fa4cae4c38e361e05997bd01d/configs/electron-builder.config.mjs#L9

This is my generated folder. What operating system do you use?

在上面如何打包win的安装包？

在上面如何打包win的安装包？

You can add win: ['nsis'] options to below code.
https://github.com/caoxiemeihao/electron-vue-vite/blob/e522cf352d2c2d2fa4cae4c38e361e05997bd01d/scripts/build.mjs#L26

@caoxiemeihao macOS Monterey
Looks like it won't affect your build, because you're not packing a custom app icon.
This is what my release folder looks like after build:

This is my electron-builder.config.mjs which is slightly modified.
The buildResources folder only contains that one app icon in png format.
const config = {
  productName: "Daily Note",
  appId: "com.itsnwa.note",
  asar: true,
  directories: {
    output: "release/${version}",
    buildResources: "buildResources"
  },
  files: ["dist"],
  ...
}

I ran into the same problem on Windows, which was solved by using administrator privileges before packaging.

macOS Monterey
Packing a custom app icon with .icns.
Looks like electron-builder convert other icon format to .icns.

This may explain the reason 👉 https://github.com/electron-vite/electron-vite-vue/issues/103#issuecomment-1096940315


Make versioned compressed packages for releases

The current build scripts produce binary files named hwi and hwi.exe which is both unversioned and conflicting for the Linux and MacOS binaries. For the 1.0.0 binaries, I had compressed these and named them myself before uploading. This PR changes the build scripts to compress and name the packages too. Additionally the names will include the version number which I forgot to do for 1.0.0.

Merging as travis indicates the correct files are created.


Linux Kernel version check policy for CVE-2021-0185

NIST recently announced a CVE with Linux Kernel where privilege can be escalated and compromise the node. The Kyverno policy should validate for exposed kernel version and generate audit alerts.

[x] I have verified the policy does not exist in the samples library.
[ Yes, I have verified this policy does not exist]

Is your policy request related to a problem? Please describe.
(https://security-tracker.debian.org/tracker/CVE-2022-0185).
The Kyverno policy should validate for exposed kernel version and generate audit alerts.
A clear and concise description of what you want to happen.
Validate if the following versions are running on the node where the pod is being deployed
parameters:
kernelVersions:
- 5.10.84-1
- 5.15.5-2
targets:

apiGroups:

''
kinds:
Node

Add any other context or screenshots about the feature request here.
kubectl get nodes -o jsonpath='{range .items[*]}{.metadata.name}{"\t"}{.status.nodeInfo.kernelVersion}{"\n"}{end}'

Seeing an issue in trying to implement this policy.
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: check-kernel
spec:
  validationFailureAction: audit
  background: true
  rules:
  - name: kernel-validate
    match:
      resources:
        kinds:
          - Node
    validate:
      message: "Kernel is vulnerable to CVE-2022-0185."
      pattern:
        status:
          nodeInfo:
            # architecture: "!amd644"
            kernelVersion: "!5.10.84-1"

Filed https://github.com/kyverno/kyverno/issues/3053

Even though the above problem needs to be investigated, this policy does work in background mode as tested on Kyverno 1.6.0 (main):
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: check-kernel
spec:
  validationFailureAction: audit
  background: true
  rules:
  - name: kernel-validate
    match:
      resources:
        kinds:
          - Node
    validate:
      message: "Kernel is vulnerable to CVE-2022-0185."
      deny:
        conditions:
          any:
          - key: "{{request.object.status.nodeInfo.kernelVersion}}"
            operator: Equals
            value: "5.10.84-1"
          - key: "{{request.object.status.nodeInfo.kernelVersion}}"
            operator: Equals
            value: "5.15.5-2"


Issue with k8s.io/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/

This is a Bug Report

Problem:
I have done setup in AWS using kubeadm
1-master node and 2 worker nodes..

I tried these commands..
kubectl run nginx --image=nginx --replicas=1;
kubectl expose deploy nginx --name=nginx-cl --port=80;
kubectl expose deploy nginx --name=nginx-np --port=80 --type=NodePort;
kubectl expose deploy nginx --name=nginx-lb --port=80 --type=LoadBalancer;

All these commands are working fine!
I tried with < node-publicIP >:< nodePort > and I can able to access the service..!!
Issue 1:
Everytime I can't access the service using the above method because , we don't know where the pod is placed !! How to resolve this issue?
Any other approach???
Issue 2:
Can't access the services from the console using curl < pod-ipaddress >:< PortNo >
Issue 3:
loadbalancer service  nginx-lb (created above)  is in pending state forever !!!
Do we need to do any additional setup for this in AWS or in kubenetes Cluster ??
Proposed Solution:
Page to Update:
https://kubernetes.io/...

hi, given this is not a bug / feature request, please use the support channels:
https://github.com/kubernetes/kubernetes/blob/master/SUPPORT.md
/triage support
/close


Octo pr reload breaks when going through Octo shorthand

Issue Description
Type: bug report
Describe what happened (or what feature you want)
When trying to reload a PR after opening it through the :Octo prompt I receive an error
E5108: Error executing lua vim/shared.lua:0: s: expected string, got nil
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'gsplit'
        vim/shared.lua: in function 'split'
        ...drew/.local/share/nvim/lazy/octo.nvim/lua/octo/utils.lua:638: in function 'split_repo'
        ...ndrew/.local/share/nvim/lazy/octo.nvim/lua/octo/init.lua:87: in function 'load'
        ...ndrew/.local/share/nvim/lazy/octo.nvim/lua/octo/init.lua:81: in function 'load_buffer'
        ...w/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:1283: in function 'reload'
        ...w/.local/share/nvim/lazy/octo.nvim/lua/octo/commands.lua:129: in function 'fun'
        ...m/lazy/octo.nvim/lua/octo/pickers/telescope/provider.lua:993: in function 'run_replace_or_original'
        ...re/nvim/lazy/telescope.nvim/lua/telescope/actions/mt.lua:65: in function 'select_default'
        /Users/andrew/.config/nvim/after/plugin/telescope.lua:39: in function 'key_func'
        ...hare/nvim/lazy/telescope.nvim/lua/telescope/mappings.lua:352: in function 'execute_keymap'
        [string ":lua"]:1: in main chunk

Describe what you expected to happen
I expect the PR to be reloaded in the buffer without errors
How to reproduce it (as minimally and precisely as possible)

:Octo
select "pr list"
select a PR
:Octo pr reload either from command OR from :Octo and then choosing "pr reload"

Tell us your environment
MacOS
NVIM v0.9.2
Build type: Release
LuaJIT 2.1.0-beta3
"octo.nvim": { "branch": "master", "commit": "22a231fc621346734464c3cbca0be467b292b343" },
Anything else we need to know?
If I use the :Octo pr list command instead of :Octo flow then it works as expected

Hi, I can reproduce this on my side. Is this a public PR I can take a look? Can you try doing :e! instead of Octo pr reload? Do you get the same error when not using the enable_builtin feature (using :Octo pr list instead of Octo and then selecting pr list)?

Unfortunately it's not a public PR but I think I reproduced it with a couple repos. I'll confirm that and try :e!
If I use the :Octo pr list command instead of :Octo flow then it works as expected

I tested today whether :e! resolved the issue and it did not. I tried recreating this today with the latest gh cli and now it merges a PR if I select it from the pr list menu 😨

I tried recreating this today with the latest gh cli and now it merges a PR if I select it from the pr list menu 😨

Sorry about that, it was a bug introduced by a very recent PR. Reported and fixed here

I tested today whether :e! resolved the issue and it did not

I just merged another fix related with the buffer reloading. Not sure if it will fix this problem but worth trying with the latest version

@pwntester  Looks like you linked to the wrong pull request 😄 , it should be https://github.com/pwntester/octo.nvim/pull/435 that fixed this issue.
BTW I saw exactly the same error before #435 merged

Ouch 😓 thanks for the heads up and fix!

I tested with another branch today and everything works as expected with NVIM 0.9.4 and commit e933611.
Thanks again for all the updates!


docs: Container Documentation

Closes #16

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


Fix deprecated methods on Boyer-Moore-Horspool

I fixed some deprecated method and I updated them to swift 4.2, I changed the return type Index for Int. This solves the issue #717

Thanks!


hierarchical_portfolio.HRPOpt

I tried to replace (EfficientFrontier(mu, S))  to (hierarchical_portfolio.HRPOpt(mu,S)) and I got error: TypeError: returns are not a dataframe.
In user guide it's written that return should be pd.series. Also when I change mu to pd.dataframe i got:
ValueError: The number of observations cannot be determined on an empty distance matrix.
How should I use correctly hierarchical_portfolio.HRPOpt.

Hi @RazHadas,
HRPOPt requires the raw asset returns, rather than the expected returns:
df = pd.read_csv("tests/resources/stock_prices.csv", parse_dates=True, index_col="date")
returns = df.pct_change().dropna()

# Hierarchical risk parity
hrp = HRPOpt(returns)
weights = hrp.optimize()
hrp.portfolio_performance(verbose=True)
print(weights)
Plotting.plot_dendrogram(hrp)  # to plot dendrogram

Hope this helps!


Update README with Python Version Requirement

This PR updates the README to include the minimum Python version requirement (>=3.10), addressing confusion and compatibility issues highlighted in issue #422
Changes include:

A new section at the beginning of the Installation instructions, guiding users to ensure they have Python 3.10 or later before proceeding with the installation process.
Instructions for checking the current Python version.
A note encouraging users to update their Python version if it is below 3.10.

As of #426 this shouldn't be necessary. Thank you though!


Performance of Kabylake encoding, how to optimize

I have tested performance of encoding on my Kabylake machine, kernel and cpu info:
3.10.0-693.el7.x86_64
Intel(R) Core(TM) m3-7Y30 CPU @ 1.00GHz

Encoding test details, the raw yuv file is 1920x1080 and 60 fps
$ time ./sample_encode h264 -hw -i TransStream_full60.yuv -w 1920 -h 1080 -nv12 -u veryslow -f 60 -o test.h264
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: User requested driver 'iHD'
libva info: Trying to open /opt/intel/mediasdk/lib64/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_1
libva info: va_openDriver() returns 0
Encoding Sample Version 8.3.26.

Input file format	NV12
Output video		AVC
Source picture:
	Resolution	1920x1088
	Crop X,Y,W,H	0,0,1920,1080
Destination picture:
	Resolution	1920x1088
	Crop X,Y,W,H	0,0,1920,1080
Frame rate	60.00
Bit rate(Kbps)	6271
Gop size	0
Ref dist	0
Ref number	0
Idr Interval	0
Target usage	quality
Memory type	system
Media SDK impl		hw
Media SDK version	1.26

Processing started
Frame number: 2418

Processing finished

real	0m19.053s
user	0m12.184s
sys	0m8.287s

$ time ./sample_encode h265 -hw -i TransStream_full60.yuv -w 1920 -h 1080 -nv12 -u veryslow -f 60 -o test.h265
plugin_loader.h :178 [INFO] Plugin was loaded from GUID: { 0x6f, 0xad, 0xc7, 0x91, 0xa0, 0xc2, 0xeb, 0x47, 0x9a, 0xb6, 0xdc, 0xd5, 0xea, 0x9d, 0xa3, 0x47 } (Intel (R) Media SDK HW plugin for HEVC ENCODE)
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: User requested driver 'iHD'
libva info: Trying to open /opt/intel/mediasdk/lib64/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_1
libva info: va_openDriver() returns 0
Encoding Sample Version 8.3.26.

Input file format	NV12
Output video		HEVC
Source picture:
	Resolution	1920x1088
	Crop X,Y,W,H	0,0,1920,1080
Destination picture:
	Resolution	1920x1088
	Crop X,Y,W,H	0,0,1920,1080
Frame rate	60.00
Bit rate(Kbps)	54464
Gop size	0
Ref dist	0
Ref number	0
Idr Interval	0
Target usage	quality
Memory type	system
Media SDK impl		hw
Media SDK version	1.26

Processing started
Frame number: 2418
plugin_loader.h :204 [INFO] MFXBaseUSER_UnLoad(session=0x0x19f2330), sts=0

Processing finished

real	1m36.095s
user	0m20.358s
sys	0m15.423s

As you can see, fps of avc encoding is about 130 but for hevc only can do 25 fps.
My expectation fps for hevc encoding is above 60 fps.
Do you have any suggestions for me to optimize the encoding performance?

Here is the outout specifying bitrate and usage, it looks that there is not very large change on hevc.
$ time ./sample_encode h264 -hw -i TransStream_full60.yuv -w 1920 -h 1080 -nv12 -u veryslow -f 60 -b 6000 -o test.h264
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: User requested driver 'iHD'
libva info: Trying to open /opt/intel/mediasdk/lib64/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_1
libva info: va_openDriver() returns 0
Encoding Sample Version 8.3.26.

Input file format	NV12
Output video		AVC
Source picture:
	Resolution	1920x1088
	Crop X,Y,W,H	0,0,1920,1080
Destination picture:
	Resolution	1920x1088
	Crop X,Y,W,H	0,0,1920,1080
Frame rate	60.00
Bit rate(Kbps)	6000
Gop size	0
Ref dist	0
Ref number	0
Idr Interval	0
Target usage	quality
Memory type	system
Media SDK impl		hw
Media SDK version	1.26

Processing started
Frame number: 2418

Processing finished

real	0m17.734s
user	0m10.477s
sys	0m7.041s

$ time ./sample_encode h265 -hw -i TransStream_full60.yuv -w 1920 -h 1080 -nv12 -u veryslow -f 60 -b 6000 -o test.h265
plugin_loader.h :178 [INFO] Plugin was loaded from GUID: { 0x6f, 0xad, 0xc7, 0x91, 0xa0, 0xc2, 0xeb, 0x47, 0x9a, 0xb6, 0xdc, 0xd5, 0xea, 0x9d, 0xa3, 0x47 } (Intel (R) Media SDK HW plugin for HEVC ENCODE)
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: User requested driver 'iHD'
libva info: Trying to open /opt/intel/mediasdk/lib64/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_1
libva info: va_openDriver() returns 0
Encoding Sample Version 8.3.26.

Input file format	NV12
Output video		HEVC
Source picture:
	Resolution	1920x1088
	Crop X,Y,W,H	0,0,1920,1080
Destination picture:
	Resolution	1920x1088
	Crop X,Y,W,H	0,0,1920,1080
Frame rate	60.00
Bit rate(Kbps)	6000
Gop size	0
Ref dist	0
Ref number	0
Idr Interval	0
Target usage	quality
Memory type	system
Media SDK impl		hw
Media SDK version	1.26

Processing started
Frame number: 2418
plugin_loader.h :204 [INFO] MFXBaseUSER_UnLoad(session=0x0xbb1330), sts=0

Processing finished

real	1m30.313s
user	0m21.154s
sys	0m15.796s

I am facing a similar situation on a APL based architecture (HD-Graphics 505/E3950):
About 25' to encode 100 frames (4096x2160). - On another architecture it takes less than 7' . -
I notice the huge difference between the user+sys time and the elapsed time.
That means than from the process side, the main part of the job is done off-cpu. The process is waiting most of the time.
I replaced the fread accesses by direct memory accesses using mmap, what makes  sys time decrease (a lot) and user time increase (a bit).
But, the waiting duration remains  at the same level.
What may cause that delay ? encoding computations done by the chipset ?
How to measure it or how to understand the latency issue ?
Does the test results from the installer process may help in any way ?

MediaSDK offloads tasks to GPU, hence you will see CPU waiting for these tasks to be finished. If you don't do much on the CPU, you will see just few % of CPU usage. If you want to monitor what GPU is doing, your best chance is to install 4.16+ linux kernel which has enabled i915 performance counters. Use like:
perf stat -a -e i915/bcs0-busy/,i915/rcs0-busy/,i915/vcs0-busy/,i915/vcs1-busy/,i915/vecs0-busy/ <your_workload>.sh
This command will give you time during which each GPU engine was busy (you may need to drop i915/vcs1-busy/ if your HW does not support 2nd VDBOX). Option -a is a must since i915 supports only global counters. Better to run under root since running under general user will require special privileges. For encoding workloads you should expect to see the load on RCS0 and VCS0. You may always have some load on BCS0 and RCS0 if you run under some GUI (X Windows for example).

Here is the output specifying bitrate and usage, it looks that there is not very large change on hevc.

Changing bitrate may give some impact on the performance, but I think it will be pretty small. That's because of Intel GPU architecture specifics. What should give a real difference is usage. Could you, please, try the following variants: -u 1, -u 4, -u 7? For what I see at the moment you have tried only -u 1 (veryslow).
Also, running encoding, please, make sure to dismiss results from the very first run since it will be significantly impacted by the time loading YUV into the memory. On the 2+ runs you should get benefits from the OS caching...

@tracy626 Can we close this issue if you are satisfied with the answers?

Feel free to reopen it or create new one.


merge package template from Kronos-Tools/npm-package-template

Updated standard to latest version

Current coverage is 98.57% (diff: 100%)

Merging #74 into master will not change coverage

@@             master        #74   diff @@
==========================================
  Files             1          1
  Lines           140        140
  Methods          37         37
  Messages          0          0
  Branches          9          9
==========================================
  Hits            138        138
  Misses            2          2
  Partials          0          0

Powered by Codecov. Last update 49b06ea...2148300


Scaling issue on wofi

Starting with commit b540d28 every time that I try to focus wofi it crashes with this error:
Gdk-Message: Error flushing display: Resource temporarily unavailable
If I just use the keyboard once wofi is launched without touching the mouse at all the program doesn't crash and works as expected.
The issue is only present when using a scaling on the display other than 1, without any scaling the issue doesn't appear at all.

It outputs this almost infinite repeating strings that ends with the wofi error when I move the cursor:
[  22686.710] wl_surface@25.leave(wl_output@35)
[  22686.712] wl_surface@25.leave(wl_output@18)
[  22686.714] wl_surface@25.enter(wl_output@35)
[  22686.715]  -> wl_pointer@20.set_cursor(897, wl_surface@25, 0, 1)
[  22686.717]  -> wl_surface@25.attach(wl_buffer@41, 0, 0)
[  22686.719]  -> wl_surface@25.set_buffer_scale(1)
[  22686.721]  -> wl_surface@25.damage(0, 0, 32, 32)
[  22686.722]  -> wl_surface@25.commit()
[  22686.724] wl_surface@25.enter(wl_output@18)
[  22686.726]  -> wl_pointer@20.set_cursor(897, wl_surface@25, 0, 0)
[  22686.729]  -> wl_surface@25.attach(wl_buffer@44, 0, 0)
[  22686.731]  -> wl_surface@25.set_buffer_scale(2)
[  22686.733]  -> wl_surface@25.damage(0, 0, 24, 24)
[  22686.735]  -> wl_surface@25.commit()

Gdk-Message: 12:16:00.349: Error flushing display: Resource temporarily unavailable

that was fixed with https://github.com/hyprwm/Hyprland/commit/91fbee24da21da058e7a31ddc5900f37a1e91c12

i'm still getting this error

yes this problem seems to be back

it's tracked elsweyr I forgot issue #

I thought it was a me issue :sweat_smile:. Where is this issue being tracked? Otherwise could this please be reopened - I'd like to be notified after the fix as it means I have to use rofi.

#3729

Problem just started for me today.  Any scaling  over 1 and wofi crashes. Could this be reopened?

Problem just started for me today. Any scaling over 1 with focus and wofi crashes. Could this be reopened?

@CountMurphy Using wofi with --normal-mode should do the trick. more info

@CountMurphy The commit https://github.com/hyprwm/Hyprland/commit/9e2b939024448d64df6af1f5d2ea5ceee078a539 fixes the issue. You should get the update soon (if you haven't already by now).


Display more information about failed, skipper and successful test with Gradle

Ideally I would like to print a list of all the tests that have run and a summary of the number of tests passed, failed, and skipped.
References

Gradle - How to display junit5 test results in console

Added to Backlog.


Off-Canvas Triggers Not Firing in Foundation 6

I am trying to create an Off-Canvas Menu for a project and I can not get any of the examples on your website to work locally, using the examples I found in the foundation docs for version 6. I have tried to recreate the examples and I can not get the panel trigger to fire on anything that is using Foundation 6. I even block copied the HTML over and they still do not work. I was able to create my own off canvas menu using Foundation 5 and that worked fine.
An example is below and the link to the example page that I am referring to:
http://foundation.zurb.com/sites/docs/off-canvas.html
<!doctype html>

Multi_side_test

Open Left
Open Right
Open Top
Open Bottom

If this is a support(plz halp) request and not a bug fix request then plz ask here => http://foundation.zurb.com/forum
If its a bug, then please provide Test case (codepen) for any kind of bug fixes!
You can use/fork one of these two for the same

http://codepen.io/IamManchanda/pen/vgemXR - Foundation 6 without Flexbox
http://codepen.io/IamManchanda/pen/xgXdRq - Foundation 6 with Flexbox

@scott-schafer We would need to see your markup in order to help. However can you check that the ID of the off canvas and the data-toggle of the button is the same? eg:

<button type="button" class="button" data-toggle="offCanvasLeft">Open</button>

Failing that I'd need to see your code.

Hi Brettsmason,
Below is the code that you asked for. Thank You for helping out.
<!DOCTYPE html>

	<meta charset="utf-8">
	<meta name="viewport" content="width=device-width, initial-scale=1.0">

	<title>Test_8</title>
	<link rel="stylesheet" href="css/normalize.css">
	<link rel="stylesheet" href="css/foundation.css">

	<button type="button" class="button" data-toggle="offCanvasLeft">Open Menu</button>

Foundation

Dot

ZURB

Com

Slash

Sites

Hey there Dude!

Some sample text here.

Artisanal filler text for your project.

Bushwick tote bag pop-up sartorial. Next level vinyl pug venmo, hashtag craft beer stumptown health goth. Aesthetic austin craft beer, meditation cliche taxidermy portland next level vegan slow-carb. Migas skateboard pork belly green juice, keffiyeh church-key health goth poke unicorn schlitz disrupt cornhole. Semiotics etsy swag, irony ethical offal hella cardigan synth keffiyeh mlkshk meh small batch portland. Cold-pressed vexillologist you probably haven't heard of them, keffiyeh narwhal marfa neutra art party williamsburg try-hard fixie irony butcher tbh umami. Hexagon chia taxidermy umami.

Hi Brett,
Issue resolved, what a dope I am! It turns out that dummy me had the script source code pointing to the wrong place!
It was:

Instead of

Let this be a lesson to all that when in the throws of solving coding issues it is a good idea to take a break to clear and reset your mind. It was such an obvious thing that once checked early on it became a given. A given that at some point got moved and the code was never updated. But in my mind I never gave it a second thought. I only discovered it after I installed the component Javascript version of 6.3.0 from Github and that worked, so I wanted to know why the individual component Javascript worked and the complete foundation Javascript did not. That is when I discovered the problem.
I am Sooooo dumb! ;-)
Anyhow, I am just glad that I can use Foundation 6 on this project. It is my first experience with Foundation and I always like to learn on the latest and the greatest.
Thank You for Your Time Brett !!

 If you get any other problems feel free to open a new issue.


Service Unavailable (503)

Same error as #9

Fixed. A system upgrade on the host prevented the server from being restarted.


Error when building on Linux aarch64

Hello,
When trying to build on Linux aarch64 (Raspberry pi 4) I got the following error:
error: failed to run custom build command for `esp-idf-sys v0.20.0`

Caused by:
  process didn't exit successfully: `/home/ubuntu/rust-esp32-std-hello/target/debug/build/esp-idf-sys-791a8c4daff86dfa/build-script-build` (exit status: 1)
  --- stdout
  Found compatible PlatformIO Core 5.2.0 -> /home/ubuntu/.platformio/penv/bin/platformio
  cargo:rerun-if-changed=./patches/pthread_destructor_fix.diff
  cargo:rerun-if-changed=./patches/missing_xtensa_atomics_fix.diff
  cargo:rerun-if-changed=./patches/ping_setsockopt_fix.diff
  cargo:rerun-if-changed=./patches/master_missing_xtensa_atomics_fix.diff
  cargo:rerun-if-changed=/home/ubuntu/rust-esp32-std-hello/./sdkconfig.defaults
  Warning! Ignore unknown configuration option `patches` in section [env]
  Processing debug (board: esp32cam; platform: espressif32; framework: espidf)
  --------------------------------------------------------------------------------
  Tool Manager: Installing platformio/toolchain-xtensa32 @ ~2.80400.0

  --- stderr
  Error: Could not find the package with 'platformio/toolchain-xtensa32 @ ~2.80400.0' requirements for your system 'linux_aarch64'
  Error: No such file or directory (os error 2)

Then:
$ pio platform install espressif32
Platform Manager: espressif32 @ 3.3.2 is already installed
Tool Manager: toolchain-xtensa32 @ 2.50200.97 is already installed
Tool Manager: tool-esptoolpy @ 1.30100.210531 is already installed
The platform 'espressif32' has been successfully installed!
The rest of the packages will be installed later depending on your build environment.

So I successfully hacked my way by manually modifying platforms/espressif32/platform.py to require toolchain-xtensa32 @ 2.50200.97 instead of toolchain-xtensa32 @ 2.80400.0
But then I got the following error:
error: failed to run custom build command for `esp-idf-sys v0.20.0`

Caused by:
  process didn't exit successfully: `/home/ubuntu/rust-esp32-std-hello/target/debug/build/esp-idf-sys-791a8c4daff86dfa/build-script-build` (exit status: 1)
  --- stdout
  Found compatible PlatformIO Core 5.2.0 -> /home/ubuntu/.platformio/penv/bin/platformio
  cargo:rerun-if-changed=./patches/pthread_destructor_fix.diff
  cargo:rerun-if-changed=./patches/missing_xtensa_atomics_fix.diff
  cargo:rerun-if-changed=./patches/ping_setsockopt_fix.diff
  cargo:rerun-if-changed=./patches/master_missing_xtensa_atomics_fix.diff
  cargo:rerun-if-changed=/home/ubuntu/rust-esp32-std-hello/./sdkconfig.defaults
  Warning! Ignore unknown configuration option `patches` in section [env]
  Processing debug (board: esp32cam; platform: espressif32; framework: espidf)
  --------------------------------------------------------------------------------
  Tool Manager: Installing platformio/toolchain-esp32ulp @ ~1.22851.0

  --- stderr
  Error: Could not find the package with 'platformio/toolchain-esp32ulp @ ~1.22851.0' requirements for your system 'linux_aarch64'
  Error: No such file or directory (os error 2)

$ pio platform install toolchain-esp32ulp
Platform Manager: Installing toolchain-esp32ulp
Error: Could not find the package with 'toolchain-esp32ulp' requirements for your system 'linux_aarch64'

And can't find a solution for this error.
Any idea?

Sure. It makes sense to keep it as open. I'll add it as discussion point for next community meeting: https://github.com/esp-rs/rust/discussions/80

@JurajSadel Steps:

build Python Wheels for aarch64 and publish to dl.espressif.com/pypi
verify status of publishing aarch64 toolchains from ESP-IDF (tools/tools.json)
verify RISC-V and aarch64 for ESP32-C3 - compile https://github.com/espressif/rust-esp32-example
build Rust Toolchain for aarch64 Linux - esp-rs/rust-build
update installation scripts for Xtensa Rust toolchain

I installed the Rust tool-chain last night, as I saw their was an update. It was a fresh install on windows 11 running in a ubuntu docker container, as per the instructions. I understand the test-rust-toolchain.sh is not yet working for the version 4.3 as I am getting an error there. Also I haven't plugged the board in yet, but I noticed that file doesn't have the S3 target in there either. I'm pretty sure the version of IDF I have installed is 4.4 but its calling 4.3 I didn't notice that mentioned in the .sh file. Should I just disregard the test-rust-toolchain.sh? And just try build a project I have for arm64, with the esp32-s3 target? the ulp_gcc is working now, or is it still under development?

Hello @RepRapid!
ESP-IDF4.3 doesn't have needed patches yet. Currently, esp-idf-sys is always downloading new ESP-IDF even if you have installed one on your machine - here is opened PR for this.
The default ESP-IDF version that esp-idf-sys builds is 4.3.2. As a workaround, you can override the default version with the ESP_IDF_VERSION environment variable.
export ESP_IDF_VERSION=release/v4.4 and then clean build should work on aarch64 Linux.
At this moment, ULP coprocessor toolchain is not ready for aarch64 Linux, as mentioned here


Blog: URLs need fixing

Staging URL:
blog2.threefold.io
Production:
blog.threefold.io
both show

resolved https://github.com/threebotserver/publishingtools/blob/development/deployment/Caddyfile


why the result of mouth is not good ?

why the result of mouth is not good ?

Mouth (especially with large expressions) and eyes are not very well for this repo.
One solution is to refine them with another network.

Can you suggest any other network which I could use to refine facial expressions capturing?


Negate Compound Matchers

With compound matchers it's possible to do:
expect { something }
  .to change(Something, :count).by(1)
  .and change(SomethingElse, :count).by(1)

Is it possible to negate an and? E.g.
expect { something }
  .to change(Something, :count).by(1)
  .and_not change(SomethingElse, :count).by(1)

(Without using nested expects and to_nots).

RSpec::Matchers.define_negated_matcher :not_change, :change should be included into RSpec by default IMO!

RSpec::Matchers.define_negated_matcher :not_change, :change should be included into RSpec by default IMO!

As a general rule, we don't include negated matcher aliases in RSpec. It's one line of code for users to add one to a project.  I don't see what's special about the change matcher that warrants us including a negated alias for it but not other matchers...and we definitely don't want to include negated aliases for all matchers since it would greatly increase the API surface area.
Plus, different users have different preferences on phrasing for the negated form; I'm favor avoid_changing over not_change, for example.

@doits one potential solution for what you're asking for is a gem of negated matchers.  It could provide negated aliases of all built-in RSpec matchers.  Would you have any interest in providing the community with such a gem?

@myronmarston the only negated matcher I've missed multiple times over the last years was this .not_change in combination with .and (I always rewrote my specs then but did not investigate further to find this easy solution).
When I think more about it, theand_not-expression is really what is missing for me (like in OP requested), but I understand the reasons why you don't want to include it (also after reading #493).
When I start to define more negated matchers (now knowing RSpec::Matchers.define_negated_matcher) I might create a gem, but creating a gem for one line now (in my case) is overkill.


move to cmake

Attempt to migrate from make to cmake
@sreimers please have a look :)

Looks great, thanks!


[BUG] Problem with playing videos that their ids have a hyphen

Is there an existing issue for this?

[X] I have searched the existing issues

Package
youtube_player_iframe (Default)
What happened?
I am trying to play videos in my app using youtube_player_iframe and have used the package for a while and I think the bug was introduced in a recent update as I have not encountered the issue before even though I have used the package a lot.
Below is what happens when I play videos with hyphens in id (first and second have hyphens in ids)
My app:
Example app of the package(second video has hyphen and don't load):
In the example app, the second video of the video list page doesn't load and it's the only one that have an hyphen in it. When I replace it with another ID it works. The homepage doesn't have that problem even though two of the video IDs have hyphens in it.
SO I think it happens when YoutubePlayerController.fromVideoId is used?
This is a sample of my code:
import 'package:flutter/material.dart';
import 'package:youtube_player_iframe/youtube_player_iframe.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: YoutubeEmbeddedtwo(),
    );
  }
}

class YoutubeEmbeddedtwo extends StatefulWidget {
  const YoutubeEmbeddedtwo({super.key, this.videoId});

  final String? videoId;

  @override
  State<YoutubeEmbeddedtwo> createState() => _YoutubeEmbeddedtwoState();
}

class _YoutubeEmbeddedtwoState extends State<YoutubeEmbeddedtwo> {
  late YoutubePlayerController _controller;

  @override
  void initState() {
    super.initState();
    _controller = YoutubePlayerController.fromVideoId(
      videoId: 'wG8gYDWj-mg', // Video ID with hyphen does not work
      // videoId: 'GfaypJIDolk', // Video ID without hyphen works
      startSeconds: 200,
      autoPlay: true,
      params: const YoutubePlayerParams(
        showFullscreenButton: true,
        enableCaption: true,
        mute: false,
        strictRelatedVideos: false,
      ),
    );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Padding(
        padding: const EdgeInsets.all(8.0),
        child: SingleChildScrollView(
          child: YouTubeContainerDesignNew(controller: _controller),
        ),
      ),
    );
  }
}

class YouTubeContainerDesignNew extends StatelessWidget {
  const YouTubeContainerDesignNew({
    super.key,
    required YoutubePlayerController controller,
  }) : _controller = controller;

  final YoutubePlayerController _controller;

  @override
  Widget build(BuildContext context) {
    return YoutubePlayer(
      controller: _controller,
      aspectRatio: 16 / 9,
    );
  }
}

This is a shorter sample
import 'package:flutter/material.dart';
import 'package:youtube_player_iframe/youtube_player_iframe.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Scaffold(
        body: YoutubePlayer(
          controller: YoutubePlayerController.fromVideoId(
            videoId: 'wG8gYDWj-mg', // // Video ID with hyphen
            // videoId: 'bmgia-h1qNg', // more with hyphe
            // videoId: '7QUtEmBT_-w',
            // videoId: 'K18cpp_-gP8',
            // videoId: 'wG8gYDWj-mg',
            // videoId: 'GfaypJIDolk', // Video ID without hyphen works
            autoPlay: false,
          ),
        ),
      ),
    );
  }
}

What is the expected behaviour?
I expect the videos to load but they show error or black screen
How to reproduce?
You play a video by using YoutubePlayerController. The video ID should have an hyphen in it, such as: wG8gYDWj-mg
Flutter Doctor Output
[√] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.22621.4317], locale en-US)
    • Flutter version 3.24.3 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (8 weeks ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\HAWKAR STORE\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio2\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Build Tools 2022 17.6.2)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools
    • Visual Studio Build Tools 2022 version 17.6.33723.286
    • Windows 10 SDK version 10.0.22000.0

[√] Android Studio (version 2024.1)
    • Android Studio at C:\Program Files\Android\Android Studio2
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314)

[√] VS Code (version 1.95.2)
    • VS Code at C:\Users\HAWKAR STORE\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.100.0

[√] Connected device (4 available)
    • SM A515F (mobile) • RZ8MC0BWWAT • android-arm64  • Android 13 (API 33)
    • Windows (desktop) • windows     • windows-x64    • Microsoft Windows [Version 10.0.22621.4317]
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 130.0.6723.117
    • Edge (web)        • edge        • web-javascript • Microsoft Edge 130.0.2849.80

[√] Network resources
    • All expected network resources are available.

• No issues found!

I'm facing a similar issue, after updating video ids with hyphen is not working.

@Anupdas do you know from which version the bug was introduced? I may decide to downgrade unless it's fixed. Migrating to using URL can't be done in my project. If it's not fixed I may try your solution in the future. My project isn't released now so there is no need for URL migration.


Application Fix

Fixed outdated/broken application, new update implements Selenium to acheive a working solution.

Any clues on how to gain approval from contributors?


Specify start url

How do I specify the start_url in the generated site.webmanifest e.g. used in Chrome?

Just add startUrl to the manifest
manifest: {     name: 'My App,     startUrl: '/',     display: 'standalone',     ... },

Just add startUrl to the manifest
manifest: {     name: 'My App,     startUrl: '/',     display: 'standalone',     ... },

Okay, I guess it just wasn't documented at the time of writing and not generated from here:
https://realfavicongenerator.net/favicon/gulp
Chrome is warning about missing name, short_name, short_url fields, but it seems only name is required:
https://developer.mozilla.org/en-US/docs/Web/Manifest/name

Okay, I guess it just wasn't documented at the time of writing and not generated from here:
https://realfavicongenerator.net/favicon/gulp
Chrome is warning about missing name, short_name, short_url fields, but it seems only name is required:
https://developer.mozilla.org/en-US/docs/Web/Manifest/name


Create an Account on the Gateway Demo System

Tutorial URL: https://developers.sap.com/tutorials/gateway-demo-signup.html
Please specify the step you are referring to password reset
the password reset email doesn't get sent immediately, but other sap.com access gets invalidated, e.g. with this message:
"500
We’re sorry, but something went wrong.
If you are the application owner check the logs for more information."

@akula86 Previous DJ said that you (your team) is responsible for this. Is that so?


Evolution of Foundational color palettes

Reduce number of colors within color palettes / update
Set consistent repeatable ramp between colors, in future these may be provided computationally

@dplsek to update scope

#2750 resolves this issue. Foundational color palette has been refined by @dplsek and included within the Salt 2.0 theme.


mlp activation flag

Codecov Report

Merging #58 (fbde638) into master (d1dd695) will decrease coverage by 0.22%.
The diff coverage is 73.33%.

:exclamation: Current head fbde638 differs from pull request most recent head 259c3b7. Consider uploading reports for the commit 259c3b7 to get more accurate results

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   73.97%   73.74%   -0.23%
==========================================
  Files          21       21
  Lines        1068     1074       +6
==========================================
+ Hits          790      792       +2
- Misses        278      282       +4

Impacted Files
Coverage Δ

rudalle/dalle/model.py
97.14% <ø> (ø)

rudalle/dalle/transformer.py
84.47% <66.66%> (-2.07%)
:arrow_down:

rudalle/__init__.py
100.00% <100.00%> (ø)

rudalle/dalle/__init__.py
69.23% <100.00%> (+1.23%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1dd695...259c3b7. Read the comment docs.


Added tests

Added BLOB tests
Added INTERVAL DAY TO MONTH tests
Added INTERVAL DAY TO SECOND tests

Thanks!


CDN url support?

I want to upload all my statics files to  CND, including statics files and built JavaScript files(files in .next folder after build).
Is there any way to change the urls to my CDN urls in build phase? For example, the __next/commons.js should be http://mycdnurl.com/__next/v0.1.0/commons.js after build, and also the static files in static folder.

It could be a property of the NextScripts element when you override <Document>

eg: <NextScripts prefix="" />

I wonder if we should support JSON files of page components too.

@nkzawa yeah, might have to be a next.config.js setting in that case (which would also make things really easy)

Hi @rauchg , assetPrefix doesn't support files located in the static folder.  If I want to serve my static files from S3/CDN how would I do it?
Thanks!

@aviramga you can use the with-universal-configuration to set a CDN_PREFIX with the CDN only for production and then use things like <img src={CDN_PREFIX + '/static/my-image.png'} />. Or use path aliases (or similar) to configure domain.com/static to be served through a CDN so you don't need to prefix the files.


Speed up lookupAnalysis and implement shadowing detection

This PR fixes #166 and sbt/sbt#2525.
lookupAnalysis speedup
d8c91eb0dae51d8b9f507b0e1d1384898108e33c is a port of https://github.com/gkossakowski/sbt/commit/c45f580b781aaba16e823a8db6f9599f2ca935ae, which should address the performance improvement mentioned in sbt/sbt#2525.
Relations rename
c71f1f6933c1f5bd2ab852b39dcc83e80b95da6d and 488c977ce3eff9f21e113d41922294ed6802a343 are minor refactoring. The term "binary" is used in multiple ways, so to disambiguate binaryDeps are now called libraryDeps, and binaryClassName is now called productClassName.
full tracking of class names coming from libraries
747015f814a2a0fb65dedc9426dc53add860741f adds a new relation called libraryClassName, which tracks JAR -> fully qualified class names that comes up in dependencies. Stamp does track class name, but it only keeps the last one.
shadow detection fix
ae5960180cbfee4ee78d426cc7f4679aff64b9f0 improves the existing shadow detection facility (externalBinaryModified) but using the newly added libraryClassName relation. If we care only about the correctness that should be ok.
perf improvement of the shadow detection
4417092fca56b51cde2559861f85a9cb3878e0ac
improves the shadow detection perf by using the new lookupAnalysis, which scans Analysis objects in the order of the classpath instead of doing the io-based lookup.lookupOnClasspath.
/review @gkossakowski, @romanowski, @dwijnand

I talked to @gkossakowski during the day (Eastern) and we confirmed a few points.

Stamps only tracks one class name so it's inadequate. I've demonstrated its shortcoming in #179.
Shadow detection is already sort of implemented as binaryDepChanges, which calls externalBinaryModified, and that I should extend its behavior.
Perf improvement can be gained by replacing the classpath lookup in externalBinaryModified with Analysis scanning.

The last 3 commits implement those ideas.

Rebased against 1.0.

Did you try to measure performance gains using the sample project from sbt/sbt#2525?

Yes. The speedup I'm seeing around 1.5x to 2x, but that's just for source changes.
If we test for binary change scanning we should see more improvements.
Windows with hdd
Before:
> check
Running compile took 3233ms
> check
Running compile took 2750ms
> check
Running compile took 2650ms
> check
Running compile took 2647ms
> check
Running compile took 2678ms

Median: 2678ms
After:
> check
Running compile took 1792ms
> check
Running compile took 1547ms
> check
Running compile took 1451ms
> check
Running compile took 1461ms
> check
Running compile took 1471ms

Median: 1471ms
Mac with SSD
Before:
> check
running compile took 570.49902 ms
> check
running compile took 927.169266 ms
> check
running compile took 295.587101 ms
> check
running compile took 305.026124 ms
> check
running compile took 306.711616 ms

Median: 306ms
After:
> check
running compile took 988.027559 ms
> check
running compile took 289.089768 ms
> check
running compile took 190.252249 ms
> check
running compile took 214.043261 ms
> check
running compile took 197.949601 ms

Median: 214ms

btw I'm out in Texas this week for Reactive Summit + Lightbend tech meetings, so my response is slower than usual. I'll tackle the suggested changes when I get back.

Sure. Thanks for letting me know.
On 5 October 2016 at 05:22, eugene yokota<EMAIL_ADDRESS>wrote:

btw I'm out in Texas this week for Reactive Summit + Lightbend tech
meetings, so my response is slower than usual. I'll tackle the suggested
changes when I get back.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sbt/zinc/pull/180#issuecomment-251572611, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAQeUXSZDe6s2GdKxUOZbXPZPuDpcZBks5qwxf8gaJpZM4KHdWb
.

--
gkk

Overall, the changes look good. I'm not sure about the renaming of binary to library. I don't see the ambiguity you're trying to resolve. Can you give an example?
That is to say, I'm asking more for documentation purposes than debating the merit of the change itself.

@gkossakowski @romanowski I've addressed the review comments.

Nice! Looking forward to trying this out.


[BEAM-10278] Move pipeline jar tests from job server projects to pyth…

…on/test-suites/portable.
This is part 1 of 2. Part 2 will move the cross language tests and close out the ticket.
Now the JavaJarCreator task is shared between runners, as it always should have been.
I moved test_flink_uber_jar.sh into runners/portability because I eventually intend to share it with Spark.
I created BEAM-11333 as a follow up item, since portable/common.gradle is hard-coded to use Flink 1.10, which is no longer the most recent.
R: @TheNeuralBit

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit

R: @ihji

LGTM, should we run the seed job and verify the postcommits work before merging?

Meh, pretty sure I'm the only one monitoring these tests anyway so I'll take my chances 🙃