Adding images and team members to grantees

@flickz I am unable to build this due to an unrelated GraphQL query, as far as I can tell. Can you help me out? Thank you.

Ok, bizarre. Unable to get this working locally, but it works in preview and prod.
➜  digital-infrastructure-fund git:(feat/add-team-to-malavikas-team) npm run start

><EMAIL_ADDRESS>start
> gatsby develop

success open and validate gatsby-configs, load plugins - 1.495s
success onPreInit - 0.050s
success initialize cache - 0.010s
success copy gatsby files - 0.095s
success Compiling Gatsby Functions - 0.283s
success onPreBootstrap - 0.310s
success createSchemaCustomization - 0.020s
success Checking for changed pages - 0.002s
success source and transform nodes - 0.455s
success building schema - 0.629s

 ERROR #85923  GRAPHQL

There was an error in your GraphQL query:

Cannot query field "allIndexJson" on type "Query".

If you don't expect "allIndexJson" to exist on the type "Query" it is most likely a typo.
However, if you expect "allIndexJson" to exist there are a couple of solutions to common problems:

- If you added a new data source and/or changed something inside gatsby-node.js/gatsby-config.js, please try a restart
of your development server
- The field might be accessible in another subfield, please try your query in GraphiQL and use the GraphiQL explorer to
see which fields you can query and what shape they have
- You want to optionally use your field "allIndexJson" and right now it is not used anywhere. Therefore Gatsby can't
infer the type and add it to the GraphQL schema. A quick fix is to add at least one entry with that field ("dummy
content")

It is recommended to explicitly type your GraphQL schema if you want to use optional fields. This way you don't have to
add the mentioned "dummy content". Visit our docs to learn how you can define the schema for "Query":
https://www.gatsbyjs.com/docs/reference/graphql-data-layer/schema-customization#creating-type-definitions

File: gatsby-node.js:85:34

 ERROR #11321  PLUGIN

"gatsby-node.js" threw an error while running the createPages lifecycle:

Cannot query field "allIndexJson" on type "Query".

  GraphQLError: Cannot query field "allIndexJson" on type "Query".

  - graphql-runner.ts:105 GraphQLRunner.validate
    [digital-infrastructure-fund]/[gatsby]/src/query/graphql-runner.ts:105:16

  - graphql-runner.ts:174 GraphQLRunner.query
    [digital-infrastructure-fund]/[gatsby]/src/query/graphql-runner.ts:174:39

  - create-graphql-runner.ts:57 apply
    [digital-infrastructure-fund]/[gatsby]/src/bootstrap/create-graphql-runner.ts:57:8

  - create-pages.ts:34 wrappedGraphQL
    [digital-infrastructure-fund]/[gatsby]/src/services/create-pages.ts:34:47

  - gatsby-node.js:85 Object.exports.createPages
    /Users/richard/src/digital-infrastructure-fund/gatsby-node.js:85:34

  - api-runner-node.js:434 runAPI
    [digital-infrastructure-fund]/[gatsby]/src/utils/api-runner-node.js:434:22

  - api-runner-node.js:590 Promise.catch.decorateEvent.pluginName
    [digital-infrastructure-fund]/[gatsby]/src/utils/api-runner-node.js:590:13

  - debuggability.js:384 Promise._execute
    [digital-infrastructure-fund]/[bluebird]/js/release/debuggability.js:384:9

  - promise.js:518 Promise._resolveFromExecutor
    [digital-infrastructure-fund]/[bluebird]/js/release/promise.js:518:18

  - promise.js:103 new Promise
    [digital-infrastructure-fund]/[bluebird]/js/release/promise.js:103:10

  - api-runner-node.js:588
    [digital-infrastructure-fund]/[gatsby]/src/utils/api-runner-node.js:588:16

failed createPages - 0.189s
success createPagesStatefully - 0.197s
info Total nodes: 274, SitePage nodes: 63 (use --verbose for breakdown)
success Checking for changed pages - 0.002s
success update schema - 0.090s
success write out redirect data - 0.002s
success Build manifest and related icons - 0.071s
success onPostBootstrap - 0.078s
info bootstrap finished - 5.768s
success onPreExtractQueries - 0.001s

 ERROR #85923  GRAPHQL

There was an error in your GraphQL query:

Cannot query field "allIndexJson" on type "Query".

If you don't expect "allIndexJson" to exist on the type "Query" it is most likely a typo.
However, if you expect "allIndexJson" to exist there are a couple of solutions to common problems:

- If you added a new data source and/or changed something inside gatsby-node.js/gatsby-config.js, please try a restart
of your development server
- The field might be accessible in another subfield, please try your query in GraphiQL and use the GraphiQL explorer to
see which fields you can query and what shape they have
- You want to optionally use your field "allIndexJson" and right now it is not used anywhere. Therefore Gatsby can't
infer the type and add it to the GraphQL schema. A quick fix is to add at least one entry with that field ("dummy
content")

It is recommended to explicitly type your GraphQL schema if you want to use optional fields. This way you don't have to
add the mentioned "dummy content". Visit our docs to learn how you can define the schema for "Query":
https://www.gatsbyjs.com/docs/reference/graphql-data-layer/schema-customization#creating-type-definitions

File: src/pages/index.js:422:5

 ERROR #85923  GRAPHQL

There was an error in your GraphQL query:

Cannot query field "allIndexJson" on type "Query".

If you don't expect "allIndexJson" to exist on the type "Query" it is most likely a typo.
However, if you expect "allIndexJson" to exist there are a couple of solutions to common problems:

- If you added a new data source and/or changed something inside gatsby-node.js/gatsby-config.js, please try a restart
of your development server
- The field might be accessible in another subfield, please try your query in GraphiQL and use the GraphiQL explorer to
see which fields you can query and what shape they have
- You want to optionally use your field "allIndexJson" and right now it is not used anywhere. Therefore Gatsby can't
infer the type and add it to the GraphQL schema. A quick fix is to add at least one entry with that field ("dummy
content")

It is recommended to explicitly type your GraphQL schema if you want to use optional fields. This way you don't have to
add the mentioned "dummy content". Visit our docs to learn how you can define the schema for "Query":
https://www.gatsbyjs.com/docs/reference/graphql-data-layer/schema-customization#creating-type-definitions

File: src/templates/events.js:206:5

failed extract queries from components - 1.548s
warn The GraphQL query in the non-page component
"/Users/richard/src/digital-infrastructure-fund/src/templates/projects.js" will not be run.
warn The GraphQL query in the non-page component
"/Users/richard/src/digital-infrastructure-fund/src/templates/updates.js" will not be run.
Exported queries are only executed for Page components. It's possible you're
trying to create pages in your gatsby-node.js and that's failing for some
reason.

If the failing component(s) is a regular component and not intended to be a page
component, you generally want to use a <StaticQuery> (https://gatsbyjs.org/docs/static-query)
instead of exporting a page query.

If you're more experienced with GraphQL, you can also export GraphQL
fragments from components and compose the fragments in the Page component
query and pass data down into the child component — https://graphql.org/learn/queries/#fragments
success write out requires - 0.006s
success run page queries - 0.020s - 1/1 49.16/s
success Caching HTML renderer compilation - 0.001s

 ERROR #98123  WEBPACK

Generating development JavaScript bundle failed

/Users/richard/src/digital-infrastructure-fund/src/pages/index.js
  422:5  error  Cannot query field "allIndexJson" on type "Query"  graphql/template-strings

✖ 1 problem (1 error, 0 warnings)

failed Building development bundle - 10.858s
ERROR in
/Users/richard/src/digital-infrastructure-fund/src/pages/index.js
  422:5  error  Cannot query field "allIndexJson" on type "Query"  graphql/template-strings

✖ 1 problem (1 error, 0 warnings)

webpack compiled with 1 error
success Writing page-data.json files to public directory - 0.264s - 1/45 170.54/s


Can not drop on monitor screen in IE 11

Describe the bug
I have 1 lap and 1 monitor. I choose 'extend' display mode. Then I open IE browser on monitor screen. I can drag something, but nothing happened after drop.
When I choose 'duplicate' display mode. Now I can drop and drag everything.
My IE browser is 11.192.16299.0. I tried on another version (11.165) and I could drop.
To Reproduce
Steps to reproduce the behavior:

Choose 'extend' display mode on windows 10.
Open IE browser on monitor screen (IE Version 11.192.16299.0)
Go to https://react-dnd.github.io/react-dnd/examples-chessboard-tutorial-app.html
Try to drag and drop anything

Expected behavior
after dropping, something will happend
Desktop (please complete the following information):

Windows 10
IE
Version 11.192.16299.0

Additional context
If it can't be fix. please let know the root cause.

It cannot endDrag in this case.


Invite not signed up user to group

Delete associated datasets on profile deletion
Refactored user/credentials create/update. Users can sign up/log in with both local and google credentials
All data mutation logging

PR is finished


ELI5: Why don't we allow userselected nicknames for e.g. GOGS?

95% of all online service in the world uses some user selectable account handle. Sometimes this handle is also the UID, but not always. We need and use an UID in IYO, this is currently just a random string obeying some logic.
This UID is perfectly fine. Sure, it's not human-readable, and that's not really fun. We don't want to change that, but we do want to support human-readable nicknames in third party services.
When a service want to use IYO, it at minimum needs the UID. At that point, it just knows there is "someone". Most of the services will ask for more, such as email address. Why don't we support human readable nicknames per service?
In case of GOGS, this means when we want to use our IYO to login there, it could ask us for a nickname. They should not use it as a UID, because that gets us into trouble: We won't be able to verify the suitability of such a nickname for the third-party on the IYO side. Rather, the service needs to specify a certain logic, e.g., "don't use spaces", "we are case-insensitive", "the length of your username must be between 5 and 35 characters", "only use alphanumeric characters and underscores (i.e., "you can only use characters from the following list: 0-9, a-z and _") from the ASCII list". Ideally, this is a simple REGEXP that allows us to push the nickname it through it on the IYO side and make sure the input and the output are the same.
Is there an issue with the reasoning above? Is it not worth the effort? Is it bad and should I feel bad? Will it break something somewhere? Is it not generic enough? Shoot!

Giving this some more thought...IYO shouldn't force usernames/UID's on the third party services that use it.For example: GOGS shouldn't count on the UID in IYO to silently use it as it's own UID and handle.
I guess this makes this a GOGs issue, rather than an IYO one?


FE bug preventing strategy

Find systemic ways to prevent future FE bugs

@tihuan was this completed?

Will keep it for this week, so I can research a little more if there are more things we can proactively do to prevent FE bugs
But so far the two big action items are done, which are:

Use PR rdev for e2e tests
Update PR template to require FE changes to include e2e tests

I can't think of anything else we can do proactively as a whole to improve the process. But I'll just keep an eye on this as we go!


document source format is unexpected.

After installing paneron, getting the site loaded, and the aperis plugin, i selected the landing page to edit.
this is what I see
I assume something is amuck as I didn't expect to be editing code.
:
Ouch! This document could not be loaded. Most likely the structure does not conform to the ProseMirror schema expected by this editor instance (such as by using content blocks that the schema does not have provisions for), or source data could be malformed in some other way.
...
Below you can correct the source document so that it uses a structure that conforms to required schema.
"root":{2 items
"type":string"doc"
"content":[2 items
0:{3 items
"type":string"section"
"attrs":{1 item
"id":string"what-is-ap210"
}
"content":[2 items
0:{2 items
"type":string"section_header"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"What is ap210?"
}
]
}
1:{2 items
"type":string"paragraph"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"AP 210 is a standard from ISO/TC 184/SC 4."
}
]
}
]
}
1:{3 items
"type":string"section"
"attrs":{1 item
"id":string"abstract"
}
"content":[8 items
0:{2 items
"type":string"section_header"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"Abstract"
}
]
}
1:{2 items
"type":string"bullet_list"
"content":[1 item
0:{2 items
"type":string"list_item"
"content":[1 item
0:{2 items
"type":string"paragraph"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"Abstract."
}
]
}
]
}
]
}
2:{2 items
"type":string"paragraph"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"Link to concept of operations"
}
]
}
3:{2 items
"type":string"paragraph"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"Link to https://www.ap242.org"
}
]
}
4:{2 items
"type":string"paragraph"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"Link to ISO"
}
]
}
5:{2 items
"type":string"paragraph"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"Training details"
}
]
}
6:{2 items
"type":string"paragraph"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"link to recommended practice docs"
}
]
}
7:{2 items
"type":string"paragraph"
"content":[1 item
0:{2 items
"type":string"text"
"text":string"AP 210 related research"
}
]
}
]
}
]
}
Following errors were encountered while validating the document:
RangeError: Unknown node type: section_header

This has been fixed, apologies.


Some files seem to miss in survey-knockout@0. 11.0

Hi @surveyjs ,
I'm a member of cdnjs. We are going to host this library.
But there is only css file in the v0.11.0 of survey-knockout form npm.
So, is there any files that the 0.11.0 version of the survey-knockout should include?
eg. survey.ko.js,   survey.ko.min.js
If you have any suggestions, please let me know.
Thank you.
cdnjs/cdnjs#10153

@sufuf3 Yes, indeed the npm survey-knockout v0.11.0 is corrupted. There is no way to update the packages in npm since February 2014.
I may share these files to you, if you need them for some reason.
Thank you,
Andrew

I need them to make should that the files of v0.11.0 in cdnjs is work.
So please share these files.
Thank you.

@sufuf3 I've added corresponding packages.zip file to the 0.11.0 release, you can get them from https://github.com/surveyjs/surveyjs/releases/tag/0.11

@tsv2013 Thank you!
I will host this library ASAP.


[BUG] LORA微调训练，训练集loss下降、验证集loss上升

是否已有关于该错误的issue或讨论？ | Is there an existing issue / discussion for this?

[X] 我已经搜索过已有的issues和讨论 | I have searched the existing issues / discussions

该问题是否在FAQ中有解答？ | Is there an existing answer for this in FAQ?

[X] 我已经搜索过FAQ | I have searched FAQ

当前行为 | Current Behavior
No response
期望行为 | Expected Behavior
No response
复现方法 | Steps To Reproduce
No response
运行环境 | Environment
- OS:
- Python:
- Transformers:
- PyTorch:
- CUDA (`python -c 'import torch; print(torch.version.cuda)'`):

备注 | Anything else?
训练集数据约1300条、验证集150条，epoch设置为150，rank为1，alpha=16，lr=0.003，3张GPU训练，训练集loss降低，验证集loss一直上升，过拟合了，请问参数该如何调整比较合理？

Please increase the LoRA r (rank); 1 is too low.


UWP - Main/profile page

Development of the main/profile page for the UWP client displaying the logged in user's profile and recent contributions.

Completed first pass of main/profile page.


Suggestion: contextually type this in class methods

Search Terms

inference class methods contextually this parameter
Suggestion
Potentially related, but not the same (AFAICS): https://github.com/microsoft/TypeScript/issues/1373
Inside of class methods, TypeScript knows what the type of this will be:
class Foo {
  value = 2
  add(number: number) {
    return this.value + number;
  }
}

const foo = new Foo();

const result = foo.add(1);

However, when the class method is passed around, TypeScript does not prescribe the this type:
declare function pipeWith<A, B>(a: A, ab: (this: void, a: A) => B): B;

// Runtime exception
// Uncaught TypeError: Cannot read property 'value' of undefined
// Expected type error but got none ❌
const result = pipeWith(1, foo.add);

For this to error as expected, it is necessary to explicitly define the type of this in the method signature:
-  add(number: number) {
+  add(this: Foo, number: number) {

// Type error ✅
const result = pipeWith(1, foo.add);

Suggestion: TypeScript could contextually annotate the this type of class methods, so users don't need to remember to manually define it.
Use Cases

Examples

Checklist
My suggestion meets these guidelines:

[ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

Annnddd as soon as I filed this, I discovered an existing issue: https://github.com/microsoft/TypeScript/issues/35451


implement HeaderMapKey only for static strings

This is a possible solution for #72. This makes it so you can only use &'static str (besides HeaderName) as a key, and thus any panics are because of static strings with illegal characters. This much more closely matches the idea of panics should be for programmer errors.
DO NOT MERGE YET. I'm going to open another PR showing a very different solution that removes the panics completely, and we can compare.

As mentioned in IRC, the point of implementing HeaderMapKey on more types is to enable the ability to avoid the K -> HeaderName conversion when the key already exists in the map.

@carllerche just to make sure I understand, this means that a lookup which previously is:
let a = String::from("...");
foo.insert(&a, ...);

Previously we won't allocate a HeaderName because it's already in the map, but after this we're forced to look up with a HeaderName or a &HeaderName, where creating one of those from a String forces an allocation?

@alexcrichton for insert, it doesn't really matter. It must make an owned HeaderName to store as a key in the map. However, searching for keys shouldn't really need to parse and allocate a HeaderName.
In this PR, that would be required.
// before
map.get(&some_custom_name)

// after
let name = some_custom_name.parse().unwrap();
map.get(&name)

#86 explores a different solution. Since searching just requires a hash and then a comparison, "evil\r\nname" should never be found in the map, so map.get("evil\r\nname").is_none() should always be true, and not need to panic.

It definetly does matter for insertion as @alexcrichton pointed out. Currently, If the map already contains the key, the example will not allocate. With this change, it would need to as the HeaderName needs to be constructed before passing to insert.

I think this PR has been superseded by #86?

#86 is the better solution, closing.


Fix unable to resize browser viewport

This PR makes the browser's viewport resizeable. Previously the viewport was locked to puppeteer's default 800 x 600px size.

Replaced by #277


typo: new_with_auth

Fixes a typo in new_with_auth that should be "with authentication" instead of "without authentication"

Thanks man!


Add support for opentelemetry version 0.21

Also adds corresponding tracing-opentelemetry version 0.22

Is there a plan to merge this PR and release a new version of the crate?

cc @conradludgate (as he's not watching this repository at the moment) and @tl-rodrigo-gryzinski for completion's sake.
I hope the ping is fine, if that's unwelcome, please let me know!

cc @eopb

Thank you for the ping Luca.
I'm sorry that this PR has taken so long to review. I've been having issues getting notifications for when pull requests are opened. The SSO security on github.com/TrueLayer prevents these notifications from going to my phone or email. I need to improve the setup so I stop missing things.
Today is a little busy so I won't be able to make a release. I will make sure a release gets cut this weekend.
@jtescher thank you for your PR

Thank you and no worries, Ethan! :)


Can't upload non-local files with content:// URIs

Hi,
I've been trying to use this package for uploading files I pick on device using system's document picker.
It provides access to local files and Google Drive content as well. Most of GD data is not on device but picker returns content://com.google.android.apps.docs.storage/document/... URI, i.e. content://  URIs as well.
Unfortunately, using it for upload result in an error on this line that says something like can't invoke method String.toCharArray() on null object reference.
AFAIU, reading content URIs should be done using ContentResolver object (details here). Example there shows bitmap reading but it's also possible to create input stream from URI to read any type of data (details here, section "Get an InputStream").
It would be great to change content URI handling so that ContentResolver is used when needed.

I've managed to make it work for remote GD files, will make a PR if I have time.

Here is my solution. It copies the way bundle-assets:// are handled, but uses ContentResolver.inputStream for stream creation.
Haven't tested all cases (only multipart body case), so didn't make a PR yet.

Even android.getContentIntent gives us a content:// uri :/. Really need this

There's a PR #374 merged for solving this issue. Please try to install the package from branch issue-374 and see if it works.

closing this issue as it's similar to #287


Escrow Start Earning 90. can't finsh Pending over 1day...last time. over 3days couldn't fish

Describe the bug
A clear and concise description of what the bug is.
Transaction ID  0xc1463f66249b79290b56a9052151f65ec5ab66c97b356e7214f3c69a071d3e22
Address SPGJ0GC92ZE15R1HAP255B3CA41Z3WA462Z027AT
Block#
Time stamp
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots or consol.log to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here:

Hi, yesterday,,,,It was canceled...it continued 3 days over.
But it failed.
And then I tried to chose "Escrow Start Earning 90" again
But It's not finished again....about 24 hours over...Pending continue again.
Gas fee lost again....this time too.
Help me, everything...please.
⇩
tx
0xc1463f66249b79290b56a9052151f65ec5ab66c97b356e7214f3c69a071d3e22
adress
SPGJ0GC92ZE15R1HAP255B3CA41Z3WA462Z027AT


Sourcemaps not working correctly with typescript.

Do you want to request a feature or report a bug?
bug
What is the current behavior?
Sourcemaps does not show the source correctly, but show the transformed code.
I am building with --mode development
If the current behavior is a bug, please provide the steps to reproduce.
repo to reproduce
Build and trace the console.error
What is the expected behavior?
Sourcemaps should lead to the source files.
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
Browsers: Chrome & Firefox, others unknown.
Node 8.9.4, Webpack 4.01, Mac OSX High Sierra

--mode developement doesn't enable full source maps. It only uses a very simple (but performant) version, which maps to the generated source. Enable SourceMaps with i. e. --devtool source-map

Enabling sourcemaps with devtool unfortunately makes no difference.

Are SourceMaps enabled in the browser devtools?

Yes, the sourcemaps works fine if I use webpack 3.

I tried your repo and it works great in firefox and chrome

Hmm, that is very odd. I'll make sure to try it again once I have access to a computer and report back of I can get it working.
Did you run it with sourcemaps enabled in the npm script, or in the config file?

All right, so it seems I did not fully cover my problem in the repository. My issue has to do with emitting a library in multiple parts.
I could not get ``devtool: "source-map"` to work, due to an error saying:
options.namespace should be string```
And in my experiments I had set devtool to `source` instead of `source-map`, which let me build without problem. But if course did not produce any actual sourcemaps.

I have updated the repository to reflect this, and would be grateful for another look.

This seems to be the very same issue as #6634.

@Glinkis #6634 has been closed. If you try the commit with the merged fix (ie "webpack": "https://github.com/webpack/webpack.git#4f399322ad19"  in your package.json dependencies, is the issue resolved?

@tmilloff Yep, everything seems to work as expected now. Thank you.


dev: run e2e test in AWS with ts-node

Details

In some recent PRs the migration of the e2e tests to typescript has started. However the infrastructure code for AWS hasn't been updated accordingly.
Example PR breaking e2e tests here with the following error:
(node:3308) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)
/tmp/scratcholkuFS.scratch/test-packageo7zoRO/zip/e2e/testRunner.js:1
import launchApp from './utils/launchApp';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at Object.compileFunction (node:vm:360:18)
    at wrapSafe (node:internal/modules/cjs/loader:1126:15)
    at Module._compile (node:internal/modules/cjs/loader:1162:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    at Module.load (node:internal/modules/cjs/loader:1076:32)
    at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47

To fix this we run the tests on AWS DF with ts-node as well. For that to work correctly the e2e tests we copy over to AWS need a tsconfig.json file, so the code is treated as a commonjs module.
We can't reuse the app's tsconfig here as that one depends on a lot of module that aren't available in the isolated AWS DF environment (e.g. expo, react-native).
(Slack discussion began here )
Fixed Issues

$
PROPOSAL:
Tests

Dev/CI only change, no tests needed.
Offline tests

QA Steps

Dev/CI only change, no tests needed.
PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
Dev/CI only change, no screenshots needed.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@mountiny @AndrewGable

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.43-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Compiler warning when using aggregation API

ReactiveMongo Version
0.13.0
MongoDB version
3.6
Operating System
MacOS 10.13
JDK
Java(TM) SE Runtime Environment (build 1.8.0_152-b16)
Scala
Scala code runner version 2.12.4 -- Copyright 2002-2017, LAMP/EPFL and Lightbend, Inc.
Expected Behavior
Usage of aggregation api on collection (BSONCollection.aggregate(.)) should compile without warning.
Usage of the sbt compiler flag -Xfatal-warnings makes compiler warnings to compiler errors.
No compiler warnings for the library.
Actual Behavior
The usage of the above stated function leads to an compiler warning as the type of the function is the deprecated type AggregationResult.
Usage of the compiler flag -Xfatal-warnings won't let me my project compile as the depreciation warning leads to a compiler error.
sbt compile leads to the following warning:
class AggregationResult in trait AggregationFramework is deprecated (since 0.12.7): Use 'api.collections.Aggregator'

Hi,
The root warning is the usage of .aggregate, deprecated since 0.12.3.
You can have a look at the API documentation.
BTW, rather use either the MailingList, or SO to ask question/for help (this tracker is for confirmed issue or actionable feature request).
Best regards.

Hi @cchantep,
thanks for your quick answer.
But form the docs I can see, that GenericCollection.aggregate(.) is not annotated as deprecated. Only the typed version of it is so.
The official documentation also encourages to use BSONCollection.aggregate(.).

The documentation indicates how to use .aggregatorContext.


OSF can create Github commits with no changes

Please do not create a commit if saving with no change. Empty commits are useless.
Example: https://github.com/ViDA-NYU/reproducibility-news/commit/8add858676e87e4b19b383103b1f1f439fd0920a

FTR, this has been ticketed internally (should be viewable with a Jira account):
https://openscience.atlassian.net/browse/OSF-6715

Apparently only an<EMAIL_ADDRESS>email will do...

D'oh! Okay, thanks for the feedback. :-/

Hey @remram44,
Sorry it's taken so long, but this issue has been fixed by the WaterButler v0.31.0 release this past Friday.  Thanks for the report!
Cheers,
@felliott


Introduce a unified query interface

See the README for an overview of what uqi can do and the example folder for a reference implementation of a uqi interface for a fake-client.
I would not review commit by commit as there was quite a bit of back and forth before landing on the a design that felt right.
Instead review files in this order:

The README
A fake-client implementation and it's tests that was modeled after trino-client (mostly).
After looking at the fake-client check out uqi.
Now look at the example of wrapping the fake-client with the uqi-client and the test showing it in action.

Note: When creating the uqi version of a data source client you set the typeMappings. This way we don't have to maintain a central library of mappings, it is up to the author of the uqi wrapped version of the client to maintain those.
Question: Right now I'm returning results as an array of rows where each row is an array of column values. Should I change this to return an array of rows where each row is an array of objects where each key is a column name and each value is the column value for that row?

change it from:[
  {
    row: ['Sam', 42],
    metadata: {
      columns: [
        { name: 'first_name', type: 'String' },
        { name: 'age', type: 'Number' },
      ],
    },
  },
  {
    row: ['Val', 29],
    metadata: {
      columns: [
        { name: 'first_name', type: 'String' },
        { name: 'age', type: 'Number' },
      ],
    },
  },
]

change it to:[
  {
    row: { first_name: 'Sam', age: 42 },
    metadata: {
      columns: [
        { name: 'first_name', type: 'String' },
        { name: 'age', type: 'Number' },
      ],
    },
  },
  {
    row: { first_name: 'Val', age: 29 },
    metadata: {
      columns: [
        { name: 'first_name', type: 'String' },
        { name: 'age', type: 'Number' },
      ],
    },
  },
]

Next steps:

[ ] Implement JSON type mapping
[ ] Better code docs

Really like how this is coming along 🤘. Do you think this is good to ship as is and we can iterate on it on a follow up PR?

Imma keep working on it in this PR. I'm spiking on the query interface now.

As I look at https://github.com/open-truss/open-truss/blob/6721443318ea6b37bf85532b5adcdbcaaf34ee99/packages/open-truss/src/uqi/example/fake-client-uqi.test.ts#L9-L14 I'm realizing I would prefer to pass the config to the createFooUqiClient function instead of calling client.setup with the config later 🤔
I'll make this API change and then request review again, for now I"m going to remove the review request.


add mfranczy to approvers

What this PR does / why we need it:
Since I am able to merge kubevirt PRs manually (github permissions), I would like to keep my rights to approve PRs.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/lgtm
/approve

/override pull-kubevirt-e2e-k8s-1.11.0
/override pull-kubevirt-e2e-k8s-1.13.3
/override pull-kubevirt-e2e-k8s-genie-1.11.1
/override pull-kubevirt-e2e-k8s-multus-1.13.3
/override pull-kubevirt-e2e-kind-k8s-sriov-1.14.2
/override pull-kubevirt-e2e-os-3.11.0
/override pull-kubevirt-e2e-os-3.11.0-crio
/override pull-kubevirt-e2e-os-3.11.0-multus

/override pull-kubevirt-e2e-windows2016


Too many progress bars when using get_profiles + with_publications=True

Currently, get_profiles function prints a progress bar per profile at
https://github.com/openreview/openreview-py/blob/master/openreview/tools.py#L210
and
https://github.com/openreview/openreview-py/blob/master/openreview/tools.py#L214
, which makes terminals twitch and slow. e.g., tens of thousands IDs to process.
Can you use a progress bar per concurrent_requests
i.e., there will be only two progress bars: processes for notes_v1 and notes_v2
or add an option not to show progress bars when using get_profiles with with_publications=True ?

Thanks for the fix! I recently updated the local package, but didn't notice that there were a few more releases after that
It reduced the number of progress bars significantly though it still shows many progress bars. Is it what it is?

the progress bar is being shown if there is a profile that contains more than 1000 publications.

I see, that's what "there are more objects than the first page" in the comment means. Thank you for the clarification!


[PROPOSAL] Identity Management Overhaul

/area runtime
/area operator
/area placement
This proposal describes a strategy for overhauling the identity story in Dapr. It involves several distinct points of interest, but have been put into the same proposal as they all serve the same goal and together will have a greater sum than their parts.
Motivation
In Kubernetes mode, Dapr is made up from a set of privileged control plane components (sentry, operator, injector, dashboard, placement (also self hosted)), and lower privileged workload daprd sidecars. In order for Dapr to maintain a strong security posture to ensure malicious, or otherwise, actors cannot read/write/get/post data it should not have access to, Dapr must have a strong authentication and authorization story. Today, Dapr uses the sentry control plane component as an identity provider and certificate authority to the rest of the Dapr components and workloads.
I've identified a number of things Dapr can improve which should give us:

Ensure mTLS cannot be compromised,
Locked down and Principle Of Least Privilege (POLP) prevents bad actors accessing data they shouldn’t,
Stronger identity improves reliability of metrics/tracing,
Stronger identity allows for developing richer authorization features in future,
The current identity management is inherently weak so no reliance on workload identity can be made.

Goals

Overhaul identity management in Dapr so workload identities are secure and mTLS between dapr components can be trusted.
Upgrades to this new identity system should be seamless for users, with no manual intervention required.

Non-Goals

Implement a mechanism for an external CA system (though don't write the new system in a way which wouldn't allow this to be added in future).

Current Shortfalls
Dapr currently has a number of shortcomings which prevent it from having a strong identity story, and undermines the mTLS of Dapr components.
1. Issuer Key Sharing
The dapr sidecar injector currently adds the Sentry issuing certificate and private key to Dapr workloads as environment variables. This means that all Dapr sidecars have access to the issuer private key and so can mint any  certificate identity they want, allowing workloads to impersonate anyone (including the control plane). This is perhaps the most critical problem to fix.
2. Broken CA Auth
Sentry is the component that acts as the Certificate Authority, and is responsible for authenticating dapr workloads and minting them appropriate X.509 identities. This flow follows a common pattern whereby workloads send an audience scoped Kubernetes ServiceAccount token which Sentry verifies against the Kubernetes API server.
Reviewing the sentry flow:

Sentry starts and generates the root CA anchor private key and self signed cert.
Sentry signs an issuer cert with new issuer key. Root CA anchor key is thrown away.
Root CA cert, issuer cert and pk stored in Secret
Pod injector injects root CA cert into dapr sidecar env vars
Daprds request identity certs from sentry using the root CA trust anchor for TLS, and a Kubernetes token which comes from a projected volume.
Sentry validates incoming CSRs by doing a token review against the Kube API.

The current implementation does not currently validate that the ServiceAccount associated with the reviewed token matches the identity requested by the client, and will instead validate the App ID which the client can set any value to.
https://github.com/dapr/dapr/blob/9f143d8deeed6c2abb0eecd1b2ec67a82dba3ca4/pkg/sentry/server/server.go#L150
https://github.com/dapr/dapr/blob/9f143d8deeed6c2abb0eecd1b2ec67a82dba3ca4/pkg/sentry/ca/certificate_authority.go#L125
https://github.com/dapr/dapr/blob/9f143d8deeed6c2abb0eecd1b2ec67a82dba3ca4/pkg/sentry/identity/kubernetes/validator.go#L40
https://github.com/dapr/dapr/blob/1c95ad119a4257d1f0f1403eda0aced56c3fe848/pkg/sentry/server/server.go#L158
This means that clients have unbounded impersonation (i.e. Alice and request a cert containing Bob).
3. Control Plane components uses same ServiceAccount
Currently (bar the dashboard), all control plane components use the same ServiceAccount. This means that not only does each component share the  same Kubernetes identity, they all share the same RBAC, violating POLP.
4. Injector uses separate trust anchor for MutatingWebhook
A lesser problem in Dapr is that the sidecar injector currently uses a separate root of trust for serving the MutatingWebhook server, with the certificate being signed and managed through Helm. This is somewhat disjointed as all other certificates are managed and observed through sentry. We basically have 2 systems of identity management.
Solutions
a) Removing Issuer certificate key pair from workloads
Change the injector to no longer set the DAPR_CERT_CHAIN and DAPR_CERT_KEY environment variables.
Deprecate the flags --issuer-key-secret-key and --issuer-certificate-secret-key on daprd and all control plane components except the sentry component. These flags can still be set for backwards compatibility however functionally do nothing. If set in future versions, a warning log output should describe that these flags no longer do anything.
Add the --sentry-trust-domain flag which will be used by sentry clients to validate sentry connections. This flag gets set by the injector for daprd workloads.
Refactor the runtime so that all components request their identity from sentry on boot.
b) UNSOLVED: App ID and ServiceAccount coupling
App ID is a string identifier that is used for service invocation/communicating with other dapr workloads, and scoping access.
In Kubernetes, workloads can set their own App ID (via the dapr.io/app-id annotation), or will it will be defaulted to the Pods name. This App ID has no relation to the Pod's ServiceAccount which results in sentry having no way of validating the authenticity of incoming App identity requests. Some possible solutions to this:

Give sentry the ability to get Pods. Sentry will  validate the incoming App ID request with the annotation which is set on the Pod (and defaulting to the Pods name if it does not exist). Sentry would then issue identities in some variation of spiffe://<trust domain>/ns/<namespace>/sa/<service account name>/appid/<app ID name>. We should consider sentry GETting Pods as an expensive operation and would slow down init time of dapr workloads.
Drop the ability for workloads to self select their APP ID name, in favor of enforcing they be identified by their ServiceAccount. This would eliminate the overhead of GETting pods, however would result in a breaking change to the Dapr API and highly likely disruptive to existing code paths/tooling.

Both solutions here are not great.
c) Separate Service Acounts for control plane components.
Each dapr component should be given their own distinct Service Account. All but the Sentry component should request their identity certificate from Sentry. This is also a good opportunity to review the existing RBAC and ensure POLP.
d) Injector uses identity certificate for Mutating Webhook
The injector identity will be special cased so Sentry will add the injector DNS server name to its identity document. This will allow the injector to serve its Dapr identity document to the Kubernetes API server. Change injector (or Sentry) to update its own Mutating Webhook with the CA trust bundle of the Dapr trust domain. Remove webhook cert management from helm.

misc:

Make use of the upstream go-spiffe Go SDK
PoC
Create a centralized security package which handles TLS middleware/auth for all server/clients in Dapr

Thanks, this all looks good to me and most solutions (a, c, d) are straightforward to implement.
Re: b, as you correctly mentioned, dropping the ability to select an app-id is disruptive and thus wouldn't be possible as it's very core to Dapr and we wouldn't want to drop custom application identities only to mitigate a Kubernetes API operation (referencing the alternative of the injector getting pods).
Another important thing to remember is that workload identities should work outside of Kubernetes, as Dapr runs in self-hosted mode, so any change needs to be compatible with this requirement. For this (main) reason I think relying on Service Accounts for identities is not the best way to go.

Thanks @yaron2, makes sense. I agree that we should stay clear of tying Dapr APP IDs with Service Accounts in favor of getting the ID from the kube API. A new spiffe ID could look something like: spiffe://<trust domain>/ns/<namespace>/appid/<app id>.

Thanks, as discussed - the current SPIFFE ID already contains the app id.

@ItalyPaleAle I don't think the memory consumption is a problem here as we will not be using an informer in sentry,  instead we will be using a single GET request to the API server on incoming requests. If using an informer is a requirement, then we could look at using a metadata only watch since we only need the pod metadata- my fear with that though is that sentry will often have an out of date state of the pod or not observe a new pod before the dapr container requests it's identity, forcing a retries and increasing error rates.
I'm also quite against having secrets be readable through the API (env var / ConfigMap).

Ok, if this doesn't cache data locally in the app/SDK, it would probably be OK.
A self-contained token would still be faster however at verification time. It wouldn't be a "secret" but just a bearer token. Issued by the injector (which has the private key), it attests that the app has the app-id it claims to have. The app presents that to sentry and sentry validates it. The token isn't secret because it contains only public claims (it shouldn't be a concern if the app knows its app-id) and using signatures we can guarantee it won't be tampered with. (In my last message I wrote this could be a JWT; I was wrong there on second thought and it could be a JWS but not JWT, which would require certain claims to be present)

I'd definitely consider the app ID token to be a secret since it is basically a password- even though it def contains public information, having access to the is token allows actors to request for dapr identities for an App ID which is not itself (impersonation).

That makes sense

@JoshVanL I've been thinking about this more and while you're right, I actually don't think it matters in the sense that it doesn't make a difference.
Your proposal is to have certificates issued if:

Sentry is presented with a valid token signed by K8s (in Dapr 1.10 this will be a bound token, but still issue by K8s)
Sentry validates the pod the request comes in by querying the K8s APIs

In this case, the relevant thing is still the bound token which is stored in /var/run/secrets/dapr.io/sentrytoken (legacy path is /var/run/secrets/kubernetes.io/serviceaccount/token"). Using bindings.localstorage an application could read that (related issue) and then using bindings.http could invoke the K8s APIs and request a certificate.
If we use a separate JWS issued by the Dapr Injector, for Sentry to issue a token you will need:

The K8s bound token (just like in the previous case)
The JWS issued by the Injector

We could store the JWS in a path like /var/run/secrets/dapr.io/pod-identity and with https://github.com/dapr/components-contrib/issues/2444 implemented, it should have the same security profile as the other proposal.
The benefits of using a separate, Dapr-issued JWS are:

It's faster as the verification happens locally and doesn't increase the load on the K8s API server
it's a bit more decoupled from K8s and will be easier in the future to support self-hosted scenarios (maybe - it still depends on the injector)

We could store the JWS in a path like /var/run/secrets/dapr.io/pod-identity and with https://github.com/dapr/components-contrib/issues/2444 implemented, it should have the same security profile as the other proposal.

The problem with this is that sentry or injector needs to create that volume. In vanilla Kubernetes, the only real way to do this is by creating ConfigMaps or Secrets. This is problematic because they are accessible through the API and would also mean granting sentry/injector the permissions to access those resources in all namespaces. Not to mention the overhead of ensuring the contents of those volumes is kept up to date and correct- forcing the writer to watch pods.. The creation of these resources is comparable to the GET Pods operation.
The other option is to create a dapr CSI driver which is OTT, even more resource intensive, and comes with its own security model  to manage/maintain.

As an aside, it is quite problematic that we can set the App ID as a Pod annotation since annotations are mutable on Pods, meaning that a dapr sidecar can be using an identity document which does not match the k8s API assumption.

Another thing of note implementing the above- sentry is also going to have to GET Configurations in order to determine the trust domain of the app.

it is quite problematic that we can set the App ID as a Pod annotation since annotations are mutable on Pods,

This seems another point in the case of using pre-signed token :)

The problem with this is that sentry or injector needs to create that volume.

True, then maybe setting an env var may be better. The env var secret store could be changed to disable access to that variable.

sentry is also going to have to GET Configurations in order to determine the trust domain of the app.

Is the trust domain of the app a new value that's being added to the Dapr Configuration CRD (specifically daprsystem)? If so, does it need to be in the Configuration CRD because you expect that to change frequently?
If you think this should not change frequently, I'd recommend passing it to Sentry as a CLI flag that is set via variables in the Helm chart.

Is the trust domain of the app a new value that's being added to the Dapr Configuration CRD (specifically daprsystem)? If so, does it need to be in the Configuration CRD because you expect that to change frequently?

The trust domain already exists in the configuration API.

In v1.11 runtime requires that the certificate, private key, and trust anchor environment variable be available when running in Kubernetes mode and mTLS is enabled. Because of this, it is a requirement that the injector continue to patch a valid daprd certificate chain as environment variables on the Pod spec in order to maintain the n-1 version coexistence guarantee.
This unfortunately means that in v1.12, the injector will continue to inject a valid certificate key pair (including the private key) on the Pod spec. To improve security, rather than the injector patching in the intermediate certificate, it will instead request and inject the identity certificate of the Pod it is patching. In v1.13 we will be able to remove adding certificate environment variables completely, as planned.
To summarize the security posture:
v1.11

Any daprd, dapr enabled app, and any user/entity which is able to get pods is able to impersonate/sign for any dapr identity they want.
All control plane services can impersonate/sign for any dapr identity they want.

v1.12

daprd, dapr enabled apps and control plane services can only communicate with their given dapr identities
The injector service is able to request for any app identity
Any user/entity is able to impersonate any app which it has get pods permissions for

v1.13

Final state of this issue- no private key material is discoverable & no entity can be impersonated.

moving tracking issue to 1.14 for there are still open issues/PRs linked to it.

Done!


UI public tests

@xbabalov In general, it is quite ok, I would like you to take a look at some of the concepts.


How to include the rg path in the search?

First of all, this plugin rocks! I much prefer it over telescope!
I might not understand the separation of tasks between fzf and ripgrep very well. Please help me achieve the following in nvim:
When I run rg --column query | fzf in a terminal, and then enter for example orders.js order_items it will narrow down the results to files that are named orders.js (or something similar) that contain the string order_items. Which means that fzf looks at the entire result string, path prefix AND the match returned by ripgrep.
When I try the same thing using the fzf-lua plugin inside nvim, however, I can't specify parts of the path prefix. Meaning I get no results for orders.js for example.
These are my relevant fzf-lua settings:
	fzf_opts = {
		-- options are sent as `<left>=<right>`
		-- set to `false` to remove a flag
		-- set to '' for a non-value flag
		-- for raw args use `fzf_args` instead
		["--ansi"] = "",
		["--tabstop"] = "4",
		["--prompt"] = "> ",
		["--info"] = "default",
		["--height"] = "100%",
		["--layout"] = "reverse",
		["--keep-right"] = "",
		["--hscroll-off"] = "10",
		["--extended"] = "",
	},

and for grep:
	grep = {
		prompt = " ",
		input_prompt = " ",
		multiprocess = true, -- run command in a separate process
		git_icons = true, -- show git icons?
		file_icons = true, -- show file icons?
		color_icons = true, -- colorize file|git icons
		-- executed command priority is 'cmd' (if exists)
		-- otherwise auto-detect prioritizes `rg` over `grep`
		-- default options are controlled by 'rg|grep_opts'
		cmd = "rg --vimgrep",
		rg_opts = "--column --line-number --no-heading --color=always --smart-case --max-columns=512 --no-hidden --with-filename",
		grep_opts = "--binary-files=without-match --line-number --recursive --color=auto --perl-regexp",
		-- 'live_grep_glob' options:
		glob_flag = "--iglob .meteor,.git", -- for case sensitive globs use '--glob'
		glob_separator = "%s%-%-", -- query separator pattern (lua): ' --'
	},

Thanks!

I’m assuming you’re using grep_project which doesn’t include the file name as the default setting adds fzf_opts["--nth"] = '2..' to the command.
You can use grep({ search = '' }) or grep({  fzf_opts = { ["--nth"] = false } }).
If you wish to have more complex file exclusions I would use live_grep_glob, for example, search for order_items -- *order* would include all files with order in the file name.

I'm using live_grep, actually. I've read up on and added ["--nth"] = "1..", to my fzf_opts but to no avail.
I'd just like to understand how the fzf-lua call differs from the above terminal command so it's not considering the path prefix.

Live grep generates a new command with each key press, read this.
For what you need just use grep with an empty search string as I commented earlier.

Btw, if you wish to see the generated command use live_grep({ debug = true }) and you’ll understand better what’s happening.

I tried the grep({ search = '' }) but that immediately starts loading results into fzf for every empty string in my project.

It shouldn't be only empty strings, it should load all lines of your project into fzf, make sure you don't have a space inside the search term or use grep_project instead, I just tried the below and I can search any file and any text as you wanted in the OP:
-- Both do the same thing, which is load all project lines into
-- fzf **and** include the filename in the search results
:lua require'fzf-lua'.grep({ search = '' })
:lua require'fzf-lua'.grep_project({ fzf_opts = { ["--nth"] = false } })

If you wish to see the underying rg command, add debug=true to the parameters:
:lua require'fzf-lua'.grep({ search = '', debug=true })

I also recommend you try the below so you can understand how the rg command is form with live_grep:
:lua require'fzf-lua'.live_grep({ debug=true })
:lua require'fzf-lua'.live_grep_glob({ debug=true })

For exmaple, this is how live_grep_glob forms it's underying command (debug=true):

If you wish to run the exact command in the OP, this is how I would do it:
:lua require'fzf-lua'.grep({ search = 'query', cmd = 'rg --column', debug=true })

Which would result in:

Hopefully this helps you understand.

I tried the grep({ search = '' }) but that immediately starts loading results into fzf for every empty string in my project, so for every piece of "empty string" after every letter, which floods my CPU in no time. (a file with one five-letter word in it will render 6 results for example)

Just looked into this issue again and the reason you’re getting 6 results is because you configured cmd = "rg --vimgrep". vimgrep flag will show multiple results per line which you do not want.
You also have to understand that cmd overrides rg_opts (it gets ignored and cmd is run instead), delete the cmd line and empty search grep will work as expected for you. You also do not need grep_opts, since you have rg installed it will always be prioritized over grep (unless you override it with cmd =).

Alright, awesome! It does exactly what I want, long fzf-able strings consisting of path, number and code line.
My problem was these two assumptions:

that whatever was shown in the settings example in the readme were defaults, so I just copied over the whole example and started adjusting where needed. Because I wanted to be sure I was using rg so I uncommented the grep.cmd prop because I assumed rg --vimgrep was what was called anyway + the --vimgrep option seemed like something I wanted.
that grep.cmd and grep.rg_opts were actually concatenated and one didn't rule out the other.

Thanks a lot for your time and helping me clear this out! Almost done with my migration from vim to nvim now! Thanks for taking the time to explain all of this, @ibhagwan!
For anyone wanting the same as described in my OP:
:lua require'fzf-lua'.grep_project({ fzf_opts = { ["--nth"] = false } })

and my grep options:
		rg_opts = "--column --line-number --no-heading --color=always --smart-case --max-columns=512 --no-hidden",

Simple when you know how.


getAtOffsetImpl parameters are in the wrong order

Signature:
(Octet -> Maybe Octet) -> Maybe Octet ->

But JavaScript:
function (nothing) {
  return function (just) {

And there are a lot more things wrong too. 😄

Bring on the PRs! 😜

There you go!
Op 10-2-2017 om 15:01 schreef Gary Burgess:

Bring on the PRs! 😜
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/purescript-node/purescript-node-buffer/issues/14#issuecomment-278948330,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE5PXTVrdX_B3h1EQfunmpe482lcmld1ks5rbG2egaJpZM4L2rns.


Issue 125

Produces wrong order of columns for nested rows when user specifies a
schema
Issue #125
Change-Id: Ieee403bfbc6e9ded176ada3b6b235f9be4715b3d
Signed-off-by: Jan Scherbaum<EMAIL_ADDRESS>

[Current coverage][cc-pull] is 90.34%

Merging [#129][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.42%

@@             master       #129   diff @@
==========================================
  Files            14         14
  Lines           661        663     +2
  Methods         615        604    -11
  Messages          0          0
  Branches         46         59    +13
==========================================
- Hits            600        599     -1
- Misses           61         64     +3
  Partials          0          0

Powered by Codecov. Last updated by [aa11614...ddac316][cc-compare]
[cc-base-branch]: https://codecov.io/gh/databricks/spark-xml/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/databricks/spark-xml/compare/aa116148be73d48982d1dfd38877a3307675e257...ddac316fa835a025c42b190b0bc8b5a222520f5d
[cc-pull]: https://codecov.io/gh/databricks/spark-xml/pull/129?src=pr

@HyukjinKwon

Thanks for this PR! However, actually I already submitted this one for this, https://github.com/databricks/spark-xml/pull/126 and I am reviewing my PR by myself multiple times. Actually, do you mind if I ask to review https://github.com/databricks/spark-xml/pull/126 just for sure? I hope I can have reviews as many as possible.

Ha! Should have checked :grinning:


One question!

Great plugin! it works very good!
it's possible that work when app is closed? or i have i create the independent service for each platform?

Hi @angelru, when the app is closed  it will still run in the background, however there were time limits that the OS imposed. e.g. The iOS only allows 3 minutes to run your background service and for Android beginning on Oreo they are now have limit to background execution . So basically this plugin a simple way of isolating an interval method call through background process and improve the user experience.


Add license

Hey,
Love the work you have done. I would like to use the project myself. Would it be possible to add a license?

@JonasStjerne
Thanks for the feedback!
The license file has been added.
https://github.com/takumakume/sbomreport-to-dependencytrack/pull/17


Parallel exec support

Now is possible to execute features in parallel.
Also reorganized tests to be executed in parallel mode.

@vania-pooh @baev Guys, take a look: TeamCity task fails on sonar analytics.

@clicman we're actually migrating to Jenkins which will is available on ci.qatools.ru.

@vania-pooh So what should I do?

retest this please

@vania-pooh So what should I do?

@clicman nothing =) Already fixed

@vania-pooh @baev Guys, you need to pass UTF-8 encoding to java during build execution:
[ERROR] /home/jenkins/workspace/allure-cucumber-jvm-adaptor_pull-request/src/test/java/ru/yandex/qatools/allure/cucumberjvm/Steps.java:[18,16] error: unmappable character for encoding ASCII

@clicman all configuration on Maven project should be described in pom.xml
IMO better to remove russian from this class https://github.com/allure-framework/allure-cucumber-jvm-adaptor/blob/master/src/test/java/ru/yandex/qatools/allure/cucumberjvm/Steps.java
BTW you can fix it by adding encoding to maven-compiler-plugin
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-compiler-plugin</artifactId>
    <version>3.2</version>
    <configuration>
        <encoding>UTF-8</encoding>
    </configuration>
</plugin>

@baev thhanks. Point encoding in compile plugin helps. Also I will not remove russian, because it good point to test and demonstrate i18n feature.

@baev Describe process how to release new versions on jenkins please.

@clicman sorry for delay, version 1.3 was released right now

@baev thanks!


Fixing deprecation warnings for 2025.1

Hi there, trying to fix warnings prior to release of 2025.1
First off, i'm not familiar with Python and all its ecosystem, i've been programming mainly in java for the last 25 years, so if you want me to change anything, just let me know.
These are the warnings i'm getting when booting a recent 2024 build of HASS:
2024-06-23 00:23:08.985 WARNING (ImportExecutor_0) [homeassistant.const] TEMP_CELSIUS was used from schluter, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead, please report it to the author of the 'schluter' custom integration
2024-06-23 00:23:08.990 WARNING (ImportExecutor_0) [homeassistant.const] ENERGY_KILO_WATT_HOUR was used from schluter, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfEnergy.KILO_WATT_HOUR instead, please report it to the author of the 'schluter' custom integration
2024-06-23 00:23:08.991 WARNING (ImportExecutor_0) [homeassistant.const] POWER_WATT was used from schluter, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfPower.WATT instead, please report it to the author of the 'schluter' custom integration
2024-06-23 00:23:08.993 WARNING (ImportExecutor_0) [homeassistant.const] TEMP_CELSIUS was used from schluter, this is a deprecated constant which will be removed in HA Core 2025.1. Use UnitOfTemperature.CELSIUS instead, please report it to the author of the 'schluter' custom integration
2024-06-23 00:23:09.001 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.schluter.climate.SchluterThermostat'>) implements HVACMode(s): heat, auto, off and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/Ingos11/ha-schluter/issues

I've changed the constants as suggested for the first four items.
For the last one, i've found this blog post explaining what needed to be done. Looking at the code for the turn_on and turn_off show indeed that it will work.

Hi @IngoS11,
did you had any time to look at this PR? Anything i can do to get that merged?
Thank you


Build PHP with phpbrew under OSX 10.11.4 & homebrew

I try to use phpbrew 1.21.6 to build PHP-7.0.7 under OSX 10.11.4 & homebrew & PHP-7.0.6. I want to see if newest phpbrew can help me to figure out those libraries dependency.
In my original building process (since very old phpbrew version), I have to link following libraries in homebrew
$ brew unlink icu4c && brew link icu4c --force
$ brew unlink openssl && brew link openssl --force
$ brew unlink libxml2 && brew link libxml2 --force

Then, I can use phpbrew to build php with following command:
$ phpbrew install 5.6.21 +default +mysql +gettext=/usr/local/opt/gettext +iconv +ftp +exif +dba +openssl +soap +apxs2=/usr/local/bin/apxs

In phpbrew 1.21.6, I just unlink all libraries in homebrew, and using trial and error method to see if phpbrew can find all libraries dependency:
I just found phpbrew can find most dependency, but not include openssl,libxml2,readline, therefore I have to assign library dir for them  with the following command
phpbrew install 7.0.7 +default +mysql +gettext +iconv +ftp +exif +dba +openssl=/usr/local/opt/openssl +soap +apxs2 -- --with-libxml-dir=/usr/local/opt/libxml2 --with-readline=/usr/local/opt/readline

or replace readline with libedit
phpbrew install 7.0.7 +default +mysql +gettext +iconv +ftp +exif +dba +openssl=/usr/local/opt/openssl +soap +apxs2 -- --with-libedit --with-libxml-dir=/usr/local/opt/libxml2

I am not sure it is the expected result or not, just want to share my experience

Thanks for your detailed report, that's helpful :)
I remember that gettext variant should automatically lookup your homebrew dependency.
https://github.com/phpbrew/phpbrew/blob/master/src/PhpBrew/VariantBuilder.php#L711
openssl lookup for homebrew
https://github.com/phpbrew/phpbrew/blob/master/src/PhpBrew/VariantBuilder.php#L498
libedit is missing the lookup.
https://github.com/phpbrew/phpbrew/blob/master/src/PhpBrew/VariantBuilder.php#L341
maybe something was wrong and the prefix lookup didn't work.

For --with-libedit you can use +editline variant.

BTW, you can run:
phpbrew --debug install 7.0.7 ....

to see the actual configure command before building it.

I am outside, I will give it a try when I at home.

I tested the following command first (without any including dirs):
php bin/phpbrew --debug install 7.0.6 +default +mysql +gettext +iconv +ftp +exif +dba +openssl +soap +apxs2

It failed when looking readline library. You can see the debug message and  build log.

It seems phpbrew does not recognize readline, but I remember it works before.

I think it uses system's readline instead of brew's readline.

Hi @markwu, could you try this again with 1.22.0 release? Thanks

Ok, I'll test tonight!

I tried  the following commands these morning, both are working as expected.
phpbrew --debug install 7.0.6 +default +mysql +gettext +iconv +ftp +exif +dba +openssl +soap +apxs2 +editline
phpbrew --debug install 7.0.5 +default +mysql +gettext +iconv +ftp +exif +dba +openssl +soap +apxs2 +editline
PHPBrew can find libxml, openssl, readline without further configurations.
Thanks for your hard works.
Mark

I just found another weird bug. I try to install php 7.0.6 without any variants. By default it will install following modules:
Enabled variants: [bcmath, bz2, calendar, cli, ctype, dom, fileinfo, filter, ipc, json, mbregex, mbstring, mhash, pcntl, pcre, pdo, phar, posix, readline, sockets, tokenizer, xml, curl, zip, openssl, opcache]
Disabled variants: []

And, the configure looks lik the following:
./configure '--cache-file='\''/Users/mark/.phpbrew/cache/config.cache'\''' '--prefix=/Users/mark/.phpbrew/php/php-7.0.6' '--with-config-file-path=/Users/mark/.phpbrew/php/php-7.0.6/etc' '--with-config-file-scan-dir=/Users/mark/.phpbrew/php/php-7.0.6/var/db' '--disable-all' '--enable-phar' '--enable-session' '--enable-short-tags' '--enable-tokenizer' '--with-pcre-regex' '--with-zlib=/usr' '--enable-bcmath' '--with-bz2=/usr' '--enable-calendar' '--enable-cli' '--enable-ctype' '--enable-dom' '--enable-fileinfo' '--enable-filter' '--enable-shmop' '--enable-sysvsem' '--enable-sysvshm' '--enable-sysvmsg' '--enable-json' '--enable-mbregex' '--enable-mbstring' '--with-mhash=/usr/local' '--enable-pcntl' '--with-pcre-regex' '--with-pcre-dir=/usr/local' '--enable-pdo' '--enable-phar' '--enable-posix' '--with-readline=/usr/local/opt/readline' '--enable-sockets' '--enable-tokenizer' '--enable-dom' '--enable-libxml' '--enable-simplexml' '--enable-xml' '--enable-xmlreader' '--enable-xmlwriter' '--with-xsl' '--with-libxml-dir=/usr/local/opt/libxml2' '--with-curl=/usr' '--enable-zip' '--with-openssl=yes' '--enable-opcache' '--with-pear=/Users/mark/.phpbrew/php/php-7.0.6/lib/php' >> /Users/mark/.phpbrew/build/php-7.0.6/build.log 2>&1

You can see it didn't set --with-openssl=/usr/local/opt/openssl. So, it failed and come out these error messages:
The last 5 lines in the log file:
/Users/mark/.phpbrew/build/php-7.0.6/ext/openssl/openssl.c:44:10: fatal error: 'openssl/evp.h' file not found

#include <openssl/evp.h>

         ^

1 error generated.

make: *** [ext/openssl/openssl.lo] Error 1

If I change command to
phpbrew --debug install 7.0.6 -- --with-openssl=/usr/local/opt/openssl  or
phpbrew --debug install 7.0.6 +default +openssl,
it works again.

BTW, If I want to add +gd into the building process, I need to add --with-gd=shared in the end, or the build process will failed.
It just looks like
phpbrew --debug install 7.0.6 +default +gd -- --with-gd=shared
If I don't add --with-gd=shared, phpbrew will add it as --with-gd=shared,/usr/local. it will cause build failed: fatal error: 'X11/xpm.h' file not found.

ok, for the gd variant, I think it's because libpng, libjpeg libraries use different prefix instead of just /usr/local, I guess this is only for homebrew...........

yeah I saw that openssl is set to "yes", I think that's enabled for some reasons...
@marcioAlmada  do you remember the reason of enabling openssl by default?

@markwu I reminded that we need https support when using curl or something, so openssl is required as default.

Okay, so maybe you need to add the osx patch to default variant, or mac user have to add  --with-openssl=/usr/local/opt/openssl to avoid compile error.

brew info openssl gives me

For compilers to find openssl you may need to set:
export LDFLAGS="-L/usr/local/opt/openssl/lib"
export CPPFLAGS="-I/usr/local/opt/openssl/include"

and for libxml2

For compilers to find libxml2 you may need to set:
export LDFLAGS="-L/usr/local/opt/libxml2/lib"
export CPPFLAGS="-I/usr/local/opt/libxml2/include"

same for readline

+openssl="$(brew --prefix openssl)" < This for the OpenSSL one (on OSX / Homebrew)

The issue is outdated and resolved in the previous reply. Closed.


linux-cross: add armv7-linux-gnu toolchain

When using rustbuild to build libstd/rustc for the armv7-unknown-linux-gnueabihf target we use this
toolchain instead of the arm-linux-gnueabihf one.
This commit also installs cmake and gives a home directory to the rustbuild user. Both are required
to be able to use rustbuild to cross compile rustc within this image.
r? @alexcrichton

Added the requested comment


Static builds?

Per https://github.com/cisco-ie/pipeline-gnmi#updated-dependencies-and-improved-builds - is there a command or was there a modification to the Makefile which enables this? Nothing jumped out at me.

See the Dockerfile

Easy, thanks.


buffer size: expand response buffer limit to 1Mb

Description: expands the buffer size of the DirectStream from 65kb to 1mb.
Risk Level: low - previously responses reaching the limit size would have resulted in an error.
Testing: tested with the example apps and this Envoy diff
diff --git a/source/common/http/filter_manager.cc b/source/common/http/filter_manager.cc
index 2864da7758..ec102fa515 100644
--- a/source/common/http/filter_manager.cc
+++ b/source/common/http/filter_manager.cc
@@ -1531,6 +1531,7 @@ Buffer::InstancePtr ActiveStreamEncoderFilter::createBuffer() {
       [this]() -> void { this->responseDataDrained(); },
       [this]() -> void { this->responseDataTooLarge(); },
       []() -> void { /* TODO(adisuissa): Handle overflow watermark */ });
+  ENVOY_LOG_MISC(error, "setting buffer limit {}", parent_.buffer_limit_);
   buffer->setWatermarks(parent_.buffer_limit_);
   return buffer;
 }

@alyssawilk you were totally right about https://github.com/envoyproxy/envoy-mobile/pull/1934#discussion_r752259640. The true origin of that buffer limit is the DirectStream in Envoy Mobile. This PR increases the limit to 1mb for now, I have created https://github.com/envoyproxy/envoy-mobile/issues/1988 to make the setting configurable.
I followed the response_payload_too_large message to the filter manager where the local response is sent, and from there to where responseDataTooLarge() is used. And then used the log above to see the value.


Workaround for bundle conflict in AppVeyor

Follow up of https://github.com/appveyor/ci/issues/1944#issuecomment-345496213
This is a workaround patch to AppVeyor config.
This change attempts to resolve the following error.
gem install bundler --no-document
bundler's executable "bundle" conflicts with C:/Ruby23/bin/bundle
Overwrite the executable? [yN]

https://ci.appveyor.com/project/bbatsov/rubocop/build/1540/job/f8gxj2m6b53qe3tg#L23
This causes the job to fail with a timeout of 60 min.

Build execution time has reached the maximum allowed time for your plan (60 minutes).

https://ci.appveyor.com/project/bbatsov/rubocop/build/1540/job/f8gxj2m6b53qe3tg/messages
This change attempt to solve by forcibly updating the bundler by adding --force option.

This attempt has succeeded. This change is expected to fix master build failures as well.
https://ci.appveyor.com/project/bbatsov/rubocop/build/1543

Thanks for looking into this!


envoy: DO NOT MERGE

Testing Envoy from main branch.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

test-me-please

test-me-please

test-me-please


App: configurable hair physics

In avatars.js we can set the hair physics parameters in the VRM spring bone import override: https://github.com/webaverse/app/blob/f1fc9ceffe899daa66f55536813574547680be4e/avatars/avatars.js#L14
We should tweak this to look great for default avatars, or make it a .scn app type which specifies the hair physics parameters of a scene, to allow artists to configure this.

@skaljac


Reverse sublist of linked list[LEETCODE]

Reverse Linked List II
I would like to give the solution in C++.
Please assign this issue to me under LGMSOC'21.

@Ayush7614 I'd like to work on this issue in C language under HCSSoC. Please assign me this issue.

@Ayush7614 @Amit366 please assign this issue to me in c++ language under LGMSOC'21.


[BUG] Template Grid Snapping does not work on placement

The Template Grid Snapping feature does not currently work on the placement of a template. I am assuming that my method of getting the template (see below) is flawed for this case. https://github.com/FolkvangrForgent/pf2e-hex/blob/6d6f678d8cc57ec33121af35ff3fcb05a2df9095/src/module.js#L90

Fixed as of 1.1.0

Fixed as of 1.1.0


named accounts

use named accounts instead of that garbaged "if network is kovan -> do this, if network is rinkeby -> do this"

addressed in https://github.com/smartcontractkit/chainlink-hardhat-box/pull/6.
Decided against named accounts, and used a similar concept to aave. They have a helper config with networking information.


Item could not be created:

Item could not be created:
We couldn't deploy your app because the source code violates the Salesforce Acceptable Use and External-Facing Services Policy

I have never heard of this error before, I don't think it has anything to do with this repo specifically. For now you will have to self-host the bot.

You can also try forking this repo and deploying the fork instead


Legit Aim Settings

I will use those settings, legit???
1.5-2 fov with 12 smooth on rifles and 2-2.5 fov with 8 smooth on pistols and aimlock on on both.
1920x1080 screen. (I will use this on my main acc.) Thanks...

um not for the most part, if you're gonna use aimlock decrease fov to < 1.5 and on pistols use around 1.8 - 2.0 with >12.5 smooth, should look legit enough that you won't get banned on overwatch. the problem is that with these settings on a new account people will call you out for cheating because of how bad they are

I use 1.1 fov rifles, smg with 2.5 smooth and aimlock. and pistols you should be below 1 fov for low or 1 smoothing but high smoothing on pistols with 1.5 is fine.


Gh 721 gaffer export

Codecov Report

Merging #733 into develop will decrease coverage by -1.41%.
The diff coverage is 48.05%.

@@              Coverage Diff              @@
##             develop     #733      +/-   ##
=============================================
- Coverage      59.83%   58.42%   -1.41%
- Complexity      2705     2736      +31
=============================================
  Files            408      419      +11
  Lines          12369    12773     +404
  Branches        1400     1436      +36
=============================================
+ Hits            7401     7463      +62
- Misses          4388     4707     +319
- Partials         580      603      +23

Impacted Files
Coverage Δ
Complexity Δ

...alisation/implementation/SerialisationFactory.java
100% <ø> (ø)
9 <0> (ø)
:x:

...gov/gchq/gaffer/arrayliststore/ArrayListStore.java
90% <ø> (-0.48%)
13 <0> (ø)

...chq/gaffer/rest/application/ApplicationConfig.java
0% <0%> (ø)
0 <0> (ø)
:x:

...uk/gov/gchq/gaffer/rest/service/StatusService.java
0% <0%> (ø)
0 <0> (ø)
:x:

...gov/gchq/gaffer/rest/service/SimpleJobService.java
0% <0%> (ø)
0 <0> (?)

.../java/uk/gov/gchq/gaffer/jobtracker/JobStatus.java
0% <0%> (ø)
0 <0> (?)

...a/uk/gov/gchq/gaffer/function/aggregate/First.java
0% <0%> (ø)
0 <0> (?)

...hq/gaffer/rest/service/SimpleOperationService.java
0% <0%> (ø)
0 <0> (ø)
:x:

...java/uk/gov/gchq/gaffer/store/StoreProperties.java
18.86% <0%> (-0.55%)
7 <0> (ø)

...re/operationdeclaration/OperationDeclarations.java
20.83% <0%> (-5.49%)
4 <0> (ø)

... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be4111...3692fed. Read the comment docs.

Closing pull request until I have added some more tests and a walkthrough to the getting started guide.


About the release of the Interfuser team.

We are also unable to reproduce the results they released.

Thanks for the report.
Maybe worth mentioning here that for TCP and LAV, an independent research group also reported similar results than what we got: https://github.com/Kin-Zhang/carla-expert/discussions
Will close as this report is not really an issue.


relabel "Filter by institution" to "Filter by group" on Search tab

"Filter by institution" is actually using the list of groups, and not all groups are institutions (example: PCC, Other).
Change to "Filter by group" so it makes more sense.

+1


Create greetings.yml

Hi there. Thank you for contribution, but this is a forked repository. You can find the main repository here.
Consider moving this PR there, so other's can take a look at your proposal.
Sorry for the late reply, I don't usually check this repo's PRs.


Migrate audio transform computations into functional.py

T44497670 Refactor transforms.py into functional.py.

Looks good! But the functionals still need tests.

cc @soumith


How to map a c# dictionary<int, string> swagger

I have a web api which returns a object that contains dictionary property
public Dictionary<int, string> Roles { get; set; }
I use swashbuckle to publish it into swagger format and this is what I get:
"Roles":{"type":"object","additionalProperties":{"type":"string"}}
I am not really sure this is correct? As I thought at least it should be something like
"Roles":{"type":"object","additionalProperties":{"type":"int", "type":"string"}}
How can represent my dictionary correctly in swagger format?

This is the correct description. Remember that Swagger is describing JSON structures and not C# types. In JSON, there's no equivalent of Dictionary<int, string>. The closest representation would be the following:
{
  "1": "foo",
  "2": "bar"
}

And sure enough if you return an object of this type from a WebAPI action, it will be serialized exactly like this - try for yourself. Furthermore, the JSON Schema that Swashbuckle is generating describes this structure accurately:
{"type":"object","additionalProperties":{"type":"string"}}


Fix: Handle error when no response is returned by a handler

This PR fixes an issue where using a handler that does not return a response results in an error:
Cannot set headers after they are sent to the client.
This error occurs because the server attempts to send headers and a response body, even though no content is provided. As a result, it becomes impossible to send a response body afterwards. This patch ensures proper handling of such cases to avoid this error.

Thank you!


The opened tab on the split view is selected when opening one file share/blob container/HNS blob container/table even through the split view is not the current selected view

Storage Explorer Version: 1.28.0-dev
Build Number: 20230113.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.1 (Apple M1 Pro)
Architecture: ia32/x64
How Found: Ad hoc testing
Regression From: Previous release (1.24.3)
Steps to Reproduce

Open one tab -> Open one file share.
Split the file share tab -> Go back to the original view.
Close the original file share tab -> Open the file share again.
Check whether a new tab is opened in the original view.

Expected Experience
A new tab is opened in the original view.
Actual Experience
The split file share tab is selected.
Additional Context

This issue doesn't reproduce for queues/resource groups/ADLS Gen1 accounts.
Here is the record:

Queue/Resource Group/Gen1 are using a deprecated API which doesn't support tracking open panels across different views. The current behavior of File Share/Blob/HNS Blob/Table are the expected behavior and will be applied to them in the future.

https://github.com/microsoft/AzureStorageExplorer/issues/6447


Enable the new model serialization for lab services

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.


form and subform in DBeaver 6.1.2

System information:
DBeaver 6.1.2
Connection specification:
Postgresql 11
Describe your question:
Good morning,
Please i have an SGBDR and a lot of data to insert into different tables connected and i need to use forms and subforms in DBeaver 6.1.2 to insert all the data that i have from different tables connected (just like forms and subforms of Access). Do you have any suggestions ?
Thank you.

is it still actual?
could you provide an example?


Understand how to log the YarpLog messages in YarpRobotLogger

The idea is to log, along with the numerical data, the messages provided by YarpLog. This will further help us to analyze the experiments on the robot.
I noticed that all the messages are stored in /log/<node-name>/<module-name>/<PID>. So the idea is to create a periodic thread that checks for the active logs and stores it.
@traversaro or @S-Dafarra do you know if yarprun uses a specific thrift to create the message? or is it just a simple bottle? This is an example of YarpLog collected from the walking
$ yarp read ... /log/my_pc/WalkingModule/18553
[INFO] |yarp.os.Port|/tmp/port/1| Port /tmp/port/1 active at tcp://<IP_ADDRESS>:10096/
[INFO] |yarp.os.impl.PortCoreInputUnit|/tmp/port/1| Receiving input from /log/my_pc/WalkingModule/18553 to /tmp/port/1 using tcp
"[/log/my_pc/WalkingModule/18553]" "\n"
"[/log/my_pc/WalkingModule/18553]" "******************************************************************************\n"
"[/log/my_pc/WalkingModule/18553]" "This program contains Ipopt, a library for large-scale nonlinear optimization.\n"
"[/log/my_pc/WalkingModule/18553]" " Ipopt is released as open source code under the Eclipse Public License (EPL).\n"
"[/log/my_pc/WalkingModule/18553]" "         For more information visit https://github.com/coin-or/Ipopt\n"
"[/log/my_pc/WalkingModule/18553]" "******************************************************************************\n"
"[/log/my_pc/WalkingModule/18553]" "\n"
"[/log/my_pc/WalkingModule/18553]" "q desired IK     8.84133 -0.00886641  0.00217841    -3.60285     25.1932     10.4581      30.866    -3.60087     25.1922     10.4589      30.865     5.15202     1.33298   -0.262539     -32.407    -21.4179    -1.35273     5.17057     1.33034   -0.255178    -32.4197    -21.4119    -1.36044\n"
"[/log/my_pc/WalkingModule/18553]" "(level INFO) (systemtime<PHONE_NUMBER>.20248603821) (message \"[WalkingModule::updateModule] The robot is prepared.\")\n"

Probably the YARP_LOG_PROCESS_LABEL can be useful to filter the log ports you are interested in. See https://github.com/robotology/yarp/blob/master/doc/yarp_logging.md
Regarding the format, I am not sure. I can check.

@traversaro or @S-Dafarra do you know if yarprun uses a specific thrift to create the message? or is it just a simple bottle?

I think it is just a bottle. This is how it is parsed in the yarplogger: https://github.com/robotology/yarp/blob/1986858acb14880bccf9073e3e74c082dc5caa0b/src/libYARP_logger/src/yarp/logger/YarpLogger.cpp#L248-L513

The first working implementation can be found at this commit https://github.com/ami-iit/bipedal-locomotion-framework/commit/9968c04985c3665a912ef54ba89a500febc88525
Al the text logs will be stored in robot_logger_device.log.<node-name>.<process-name>.p<pid-number> in this specific case robot_logger_device.log.test_giulio.WalkingModule.p245198

That's great!

This is super useful also for other teams, like @ami-iit/ironcub
CC
@ami-iit/artificial-mechanical-intelligence

Thanks to https://github.com/ami-iit/bipedal-locomotion-framework/pull/541 and https://github.com/ami-iit/robot-log-visualizer/releases/tag/v0.2.0. it is now possible to load the YarpLog messages. Given the time instant provided by the slider, the latest message is highlighted.
The following colormap is chosen:

🔴 errors
🟠 warnings
🔵 debug
🟢 info

https://user-images.githubusercontent.com/16744101/175880161-20d4277c-a9f1-46da-964c-54e29db8cba7.mp4

This is awesome!!

Super!


Poor font rendering within SciView

I'm using a remote python on my server (Ubuntu 20 LTS, Python 3.8), everything works fine in Jupyter Notebook in web browser.
However if I use Sentific Mode and SciView instead, fonts in SciView seems rendering poorly.
In Jupyter Notebook (Chrome 81)

In PyCharm SciView (PyCharm 2021.1.1, Mac Mini M1)

Here's the code to replicate this plot (copied from plugin homepage)
import numpy as np
from lets_plot import *
LetsPlot.setup_html()
np.random.seed(12)
data = dict(
    cond=np.repeat(['A','B'],200),
    rating=np.concatenate((np.random.normal(0,1,200),np.random.normal(1,1.5,200)))
)
p = ggplot(data,aes(x='rating',fill='cond')) + ggsize(500,250)\
    + geom_density(color='dark_green',alpha=.7)+ scale_fill_brewer(type='seq')\
    + theme(axis_line_y='blank')
p.show()

Rendering quality does not change with the size of the image or window.

You are right, the characters look terrible, I'll have to look at it.
Saving png via the menu on the tab should give you better quality.

@arthurire could you check out the latest Lets-Plot-in SciView v1.1.0 ?
The font rendering quality should be a lot better now.

@arthurire could you check out the latest Lets-Plot-in SciView v1.1.0 ?
The font rendering quality should be a lot better now.

Hi Alshan,
Sorry for the late reply. Font rendering quality is a lot better.
I'll close this issue. Thank you!


Example programs: sum via foldl, foldr

foldl' and foldl'-via-foldr are already there.

Resolved in 785d78209b0445fe5e4e9c591723b7e178bb04db


Add conversion webhook handling to the helm chart template

Purpose
Fixes https://github.com/wso2/apk/issues/2222
Fixes https://github.com/wso2/apk/issues/2203
Incase of a failure due to common controller unavailability, users can upgrade the installation as follows.
helm upgrade apk wso2apk/apk-helm --version 1.1.0-alpha2 --set wso2.apk.webhooks.conversionwebhookconfigurations=false
Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email<EMAIL_ADDRESS>to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to<EMAIL_ADDRESS>and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

Unit tests

Code coverage information

Integration tests

Details about the test cases and coverage

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no
Ran FindSecurityBugs plugin and verified report? yes/no
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.81%. Comparing base (839dd54) to head (c017466).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2223      +/-   ##
==========================================
+ Coverage   28.42%   28.81%   +0.38%
==========================================
  Files         124       56      -68
  Lines       14546    10068    -4478
  Branches     2681      246    -2435
==========================================
- Hits         4135     2901    -1234
+ Misses      10274     7030    -3244
  Partials      137      137

Flag
Coverage Δ

adapter
27.59% <ø> (-0.87%)
:arrow_down:

common-controller
4.07% <ø> (ø)

config-deployer-service
?

idp-domain-service
80.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Adds data- to ensure GA key and django debug values are not null.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.481%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
391

Relevant Lines:
547

💛  - Coveralls


[Relay] Allow converting keras.layers.Sequential

The following simple model fails to convert with the error KeyError: 'dense_1_input' because the Sequential implicitly defines the InputLayer.
from keras.layers import Dense, Dropout
from tvm import relay

model = keras.models.Sequential([
    Dense(512, input_dim=1000, activation='relu'),
    Dropout(0.5),
    Dense(128, activation='relu'),
    Dropout(0.5),
    Dense(1, activation='sigmoid')
])

relay.frontend.from_keras(model)

This PR simply adds any InputLayers it finds during conversion. It's a one-liner because set_expr is idempotent.

@kazum can you help review this PR?

Thanks, @nhynes @Huyuwei.  This is now merged.


Bootstrap-tour  with Requirejs

This isn't playing nicely with requirejs. Below is a taste of my requirejs config. As you can see, I have added "jquery" as a dependency as I am getting "Uncaught ReferenceError: jQuery is not defined".
I am seeing bootstrap-tour.min being pulled it but it is chucking out the error mentioned above and this is due to jQuery being incorrectly injected.
paths: {
.....
"bootstrap-tour": "../bower_components/bootstrap-tour/build/js/bootstrap-tour.min"
}
shim: {
"bootstrap-tour": {
deps: ["jquery"] // Yes, I am requiring jQuery correctly.
}
}
Any help is appreciated.

+1

So this is what my shim looks like in order to get this working.
"bootstrap-tour": {
deps: ["jquery"],
init: function() {
return this.Tour;
}
}
Within the init method 'this' refers to the window object. Isn't the most eloquent fix, but it works for the mean time.
I would appreciate any feeback for a better solution.

The workaround provided by @asharma-r7 worked for me.
That, and writing var Tour = require("bootstrap-tour"); in the Angular controller.

This is my settings and it works:
require.config({
    baseUrl: "./scripts",
    paths: {
        jquery: "jquery-2.1.4.min",
        bootstrap: "../lib/bootstrap/js/bootstrap.min",
        bootstrap_tour: "../lib/bootstrap/js/bootstrap-tour",
    },
    shim: {
        bootstrap: ['jquery'],
        bootstrap_tour: ['bootstrap'],
    },
    waitSeconds: 0
});

define(['jquery', 'bootstrap', 'bootstrap_tour'], function($, bootstrap, bootstrap_tour) {

});

AMD and CommonJS support has been added 57ee74898b17754e1119c0dab75a1d1151e1dd2a.