Eligible filters are not pushed down if any are ineligible, resulting in none being pushed down

CrateDB version
5.7.3
CrateDB setup information
Local 5.7.3
Remote Postgres 16
Problem description
While not strictly defined as supported:

WHERE clauses can in some circumstances be pushed to the foreign system, but that depends on the concrete foreign data wrapper implementation. You can check if this is the case by using the EXPLAIN statement.

I believe that filters which can be pushed down to the foreign system should be. Currently, if any filter cannot be pushed down, none of the filters are. This means that a simple sub-select or additional filter can turn a very fast query into a very slow one.
Steps to Reproduce
CREATE FOREIGN TABLE doc.foreign_t01 (
    c1 TEXT,
    c2 OBJECT(IGNORED)
) SERVER neon OPTIONS (schema_name 'public', table_name 't01');

EXPLAIN SELECT * FROM doc.foreign_t01 WHERE c1 = 'Hello';
EXPLAIN SELECT * FROM doc.foreign_t01 WHERE c1 = 'Hello' and c2['module']  = 'Test%';

Actual Result
✅  filters are pushed down
EXPLAIN SELECT * FROM doc.foreign_t01 WHERE c1 = 'Hello';
+----------------------------------------------------------------------------+
| QUERY PLAN                                                                 |
+----------------------------------------------------------------------------+
| ForeignCollect[doc.foreign_t01 | [c1, c2] | (c1 = 'Hello')] (rows=unknown) |
+----------------------------------------------------------------------------+

❌   filters are not pushed down
EXPLAIN SELECT * FROM doc.foreign_t01 WHERE c1 = 'Hello' or c1 LIKE 'Test%';
+----------------------------------------------------------------------+
| QUERY PLAN                                                           |
+----------------------------------------------------------------------+
| Filter[((c1 = 'Hello') AND ('Test%' = c2['module']))] (rows=0)       |
|   └ ForeignCollect[doc.foreign_t01 | [c1, c2] | true] (rows=unknown) |
+----------------------------------------------------------------------+

Expected Result
🆗  some filters are pushed down
EXPLAIN SELECT * FROM doc.foreign_t01 WHERE c1 = 'Hello' or c1 LIKE 'Test%';
+----------------------------------------------------------------------+
| QUERY PLAN                                                           |
+----------------------------------------------------------------------+
| Filter[(('Test%' = c2['module']))] (rows=0)                          |
|   └ ForeignCollect[doc.foreign_t01 | [c1, c2] |  (c1 = 'Hello')]] (rows=unknown) |
+----------------------------------------------------------------------+

In the first version of filter push down: https://github.com/crate/crate/pull/15653 we only enabled this for safe operators, which is the standard comparison and logical operators, and if anything else is included we don't push down the filter at all.
I see 2 improvements here:

Maybe enable more functions for which we have 100% compatibility with PostgreSQL
When expressions are combined with AND split the query and do partial push-down.

Splitting on OR and pushing down one side won't work.
The given example would exclude cases where c1 = 'Hello' is false but c1 LIKE 'Test%' is true.

Makes sense. The example has been chosen badly in this case. I updated it to better reflect the original issue.

We also tried to explicitly split the filters into a cte like ...

With SET optimizer_move_filter_beneath_rename = false; this leads to the desired output
cr> EXPLAIN  WITH foreign_select AS (SELECT * FROM doc.foreign_t01 WHERE c1 = 'Hello')
    SELECT * FROM foreign_select WHERE c2['module']  = 'Test%';
+----------------------------------------------------------------------------------+
| QUERY PLAN                                                                       |
+----------------------------------------------------------------------------------+
| Filter[('Test%' = c2['module'])] (rows=0)                                        |
|   └ Rename[c1, c2] AS foreign_select (rows=unknown)                              |
|     └ ForeignCollect[doc.foreign_t01 | [c1, c2] | (c1 = 'Hello')] (rows=unknown) |
+----------------------------------------------------------------------------------+

Deactivating this by default however seems problematic.

Within PostgreSQL this most likely could be prevented with the MATERIALIZED keyword in the CTE, forcing a separate evaluation of the CTE. https://www.postgresql.org/docs/16/queries-with.html#QUERIES-WITH-CTE-MATERIALIZATION


add scaledown, target cpu scaling, and update modules

Update modules to latest version, configure target cpu for scaling to 80% instead of 50%. Also added scale down and up. CPU and memory metrics look ok in aws for the different environments.

CI: No IaC security warnings found


Not finding anything to remove

> npx clean-modules -d -D node_modules --include "**/*.js"

clean-modules (dry run)

Cleaning up node_modules...
Done in 98ms!

Cleaning up empty dirs...
Skipped on dry runs!

Results:
- size reduced: 0 B
- files removed: 0
- empty dirs removed: 0

There are definitely *.js files in that folder that should've been found in this run?
System Info
 System:
    OS: Windows 10 10.0.19044
    CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
    Memory: 90.57 GB / 127.90 GB
  Binaries:
    Node: 16.14.2
    npm: 8.5.5

Hey! Thanks for reporting this, and I'm sorry for the slow response. 🙏
This was most likely related to an issue with paths on Windows, which has been fixed in 2.0.5. Try it out, and reopen this issue if the problem persists!


Scheduler runInBackground is not working with appendOutputTo/sendOutputTo

Laravel Version: 7.28.4
PHP Version: 7.4.16
Database Driver & Version: MySQL 5.7.26

Description:
It seems that runInBackground  and appendOutputTo/sendOutputTo can't work together.
Steps To Reproduce:
For simplicity I created dummy Command which only outputs a line $this->info('This is output'); inside handle method.
When I call this command in scheduler it outputs "This is output" in file:
$schedule->command('dummy')
    ->everyMinute()
    // ->runInBackground()
    ->appendOutputTo($filepath);

But when I uncomment runInBackground and run again I get this in my file ^C, and there is no output.

This is expected. Running the command in the background won't output anything.

Then how to track commands that run in the background without including Horizon or custom logging in handlers?


Is it possible to filter over related data?

First of all, thank you for this great package! Your time and effort are much appreciated.
I am wondering if there is a way to control which related dataset should the filter get applied to. Here is an example which used Entity Framework
// Course Entry
public class Course
{
        public int Id { get; set; }
        public string Name { get; set; }
        public string Code { get; set; }
        public int TeacherId { get; set; }

        public virtual User Teacher { get; set; }
        public virtual ICollection<User> Students { get; set; }
        public virtual ICollection<Course> RelatedCourses { get; set; }
        public virtual ICollection<Course> PreRequisites { get; set; }
}

Now, I want to query the Courses and filter by the related data (aka virtual properties). The incoming filters will look something like this
var contentIdFilter = new QueryBuilderFilterRule()
{
    Condition = "or",
    Rules = new List<QueryBuilderFilterRule>()
    {
        new QueryBuilderFilterRule()
        {
            Condition = "and",
            Field = "Course Name",
            Id = "Code",
            Input = "text",
            Operator = "equal",
            Type = "string",
            Value = "C# 101",
            Rules = new List<QueryBuilderFilterRule>()
            {
                Condition = "and",
                new QueryBuilderFilterRule()
                {
                    Condition = "and",
                    Field = "Teacher's First Name",
                    Id = "course.Teacher.FirstName",
                    Input = "text",
                    Operator = "equal",
                    Type = "string",
                    Value = "F.Name"
                },
                new QueryBuilderFilterRule()
                {
                    Condition = "and",
                    Field = "Teacher's Last Name",
                    Id = "course.Teacher.LastName",
                    Input = "NA",
                    Operator = "equal",
                    Type = "Text",
                    Value = "L.Name"
                }
            }
        },
        new QueryBuilderFilterRule()
        {
            Condition = "and",
            Field = "Related Courses' Code",
            Id = "RelatedCoursesCode",
            Input = "text",
            Operator = "equal",
            Type = "string",
            Value = "C# 101",
        }
    }
};

Then the LINQ statement would look something like this
DataContext.Courses.Where(course => course.Code == "C# 101" || (course.Teacher.FirstName == "F.Name" && course.Teacher.LastName == "L.Name") || course.RelatedCourses .Contains(relatedCourse  => relatedCourse.Code == "C# 101")).ToList();

I am not sure if the package is flexible enough to allow me to do such a logic. But in theory, if there was a way to set the expression source in the QueryBuilderFilterRule class, it should be doable. Of course, I could be oversimplifying it here but would be very helpful if there is a way to filter by related data.
I could be completely wrong here, but could we change the following line
var pe = Expression.Parameter(typeof(T), "item");

to
string alias = "item";

if(!string.IsNullOrWhiteSpace(filterRule.Alias))
{
    alias = filterRule.Alias.Trim();
}

var pe = Expression.Parameter(typeof(T), alias);

Then we would add string Alias { get; } to the IFilterRule contract.
Thank you in advance for your help here.

Hi, so we halfway support what you're looking for right now, and we have a PR under review to support the collections.  Basically right now we can handle nested virtual properties, but not collections.  So Course.Teacher.FirstName should work just fine, but your `RelatedCourses query would not work until our next release.  See issue #45 for the discussion on supporting collections.  We'll likely roll that out in the next couple of weeks.

That's is great news! Can't wait for the next release. Thank you.


Problem: some tests are not activated

Solution: activate and remove or fix tests
see #2381
WARNING: I skipped the test_get_spent_issue_1271 test because it is handled in #2389
if #2389 is merged before this PR then the master needs to be merged in here and the skip mark needs to be removed

Codecov Report

Merging #2390 into master will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage    86.9%   87.13%   +0.23%
==========================================
  Files          38       38
  Lines        2168     2168
==========================================
+ Hits         1884     1889       +5
+ Misses        284      279       -5

There are still tests in tests/test_core.py that are not marked for execution. Are these going to be fixed in a future PR, or should they be removed?

I think it should not be skipped but I have to check again. Will remove it another PR anyways.


No link to non english version of https://www.electronjs.org/blog/maintainer-summit-2022-recap

As the title say .
So we get Page Not Found if we select another language than english

Looks like a few recent blog posts are missing.


Audubon Core Maintenance Group call 21:00 UTC, Tuesday, March 3

The Audubon Core Maintenance Group will have an online meeting at 21:00 UTC Tuesday, 2020-03-03. That corresponds to 4:00 PM Tuesday, Eastern (US) Standard Time (New York), 9:00 PM Tuesday, GMT (London), 10:00 PM Tuesday, Central European Time (Stockholm), and 8:00 AM Wednesday Australian Eastern Daylight Time (Canberra).
On the agenda:

report on the status of the 3D Task Group (Doug Boyer, Rebecca Snyder)
review of metadata fields used to describe sounds (lists to be submitted to Google Drive folder)

Call connection details to follow.

Vanderbilt Library is inviting you to a scheduled Zoom meeting.
Topic: Audubon Core Maintenance Group
Time: Mar 3, 2020 03:00 PM Central Time (US and Canada)
4:00 PM Tuesday, Eastern (US) Standard Time (New York)
9:00 PM Tuesday, GMT (London)
10:00 PM Tuesday, Central European Time (Stockholm)
8:00 AM Wednesday, Australian Eastern Daylight Time (Canberra)
Join Zoom Meeting
https://zoom.us/j/601650476
Meeting ID: 601 650 476
One tap mobile
+16465588656,,601650476# US (New York)
+16699009128,,601650476# US (San Jose)
Dial by your location
+1<PHONE_NUMBER> US (New York)
+1<PHONE_NUMBER> US (San Jose)
+44<PHONE_NUMBER> United Kingdom
+44<PHONE_NUMBER> United Kingdom
+44<PHONE_NUMBER> United Kingdom
+44<PHONE_NUMBER> United Kingdom
+61 3 7018 2005 Australia
+61 8 7150 1149 Australia
+61 2 8015 6011 Australia
+49<PHONE_NUMBER> Germany
+49 69 7104 9922 Germany
+49 30 5679 5800 Germany
Meeting ID: 601 650 476
Find your local number: https://zoom.us/u/aeJeX7bqJi

Just a reminder that the Audubon Core Maintenance Group will be meeting in a little over an hour (at 21:00 UTC). See the meeting invitation for the Zoom meeting link.

The Audubon Core Maintenance Group meeting notes for 2020-03-03 have been posted here


Fix bible

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

@OscarRG In case you are having any problems, you can close this PR and open a new one with just the removal of the Bible API.

@matheusfelipeog that would be great, i have some conflicts

@matheusfelipeog that would be great, i have some conflicts

@OscarRG So you can do this ;)
Request my review when opening the new PR

Hey @matheusfelipeog i think i fixed all the errors that i had. If not, i will just create a new PR :)


Bug on Show Repositories and show Contributions

Describe the bug
contributions list : In show contributions contains some error show when I increase number in contributor list first it shows correct contributor list then
decrease the number  it doesn't show proper output
Repositories : In Repositories list create a number limit just show the recent 5 Repositories display otherwise the number doesn't increase the more
Expected behavior
@ashutosh-rath02  Please assign me i will resolve this two issues
Screenshots
contributions  bug video : https://github.com/ashutosh-rath02/git-re/assets/127814497/9bcdd0de-33d5-4cd2-8e5d-280141387650
Repositories bug video : https://github.com/ashutosh-rath02/git-re/assets/127814497/a96cc5eb-6718-4c7a-a732-1cb80652ddbb
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Task

[x] Follow Us On social media - LinkedIn Twitter
Let's connect
[x]      GitHub

Enter you User Id's:
LinkedIn: https://www.linkedin.com/in/srujanadvsn/
GitHub:  https://github.com/VSNSRUJANA123
Twitter:  https://x.com/DvsnSrujana
If you Follow us in both social medias we provide 'level2'
*Only First time

Go ahead @VSNSRUJANA123 all the best

@VSNSRUJANA123 updates?

hey @ashutosh-rath02 , if no one is working on this issue then I would like to contribute to it , plz assign this to me.
I will create PR in one day.

@ashutosh-rath02 how many max repos the resume can contain, as for now, it is allowing only 6 so do you want to limit it to a specific number or let the user add as many as they want?

Yeah limit it to 6 for now

@atharvarekhawar see the description of the issue and make a video according to it, to replicate the bugs

Hello @VSNSRUJANA123! Your issue #143 has been closed. Thank you for your contribution!


Reason for MAX_SENTENCE_LEN = 128

Hi, Thank you for question_generator.  I am a beginner and am trying to understand the code and use it for multiple choice question generation. I am unable to understand why you have restricted sentence length to 128 characters in the function _split_text(self, text). Could you clarify?

Hi, sorry I never responded to this. Somehow I didn't get a notification about it.
As I recall, I just wanted to split the text into short segments which could be used as answers. 128 is an arbitrary number I chose to be the maximum length. I found that if I didn't limit the length of the sentences, some of the answers were long complex sentences which the system was unable to generate coherent questions for.


[CARBONDATA-4184] alter table Set TBLPROPERTIES for RANGE_COLUMN sets unsupported datatype(complex_datatypes/Binary/Boolean/Decimal) as RANGE_COLUMN.

Why is this PR needed?
Alter table set command was not validating unsupported dataTypes for range column.
What changes were proposed in this PR?
Added validation for unsupported dataTypes before setting range column value.
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3604/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5349/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5357/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3612/

LGTM

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5360/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3615/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3618/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5363/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5386/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3642/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3668/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5412/

retest this please

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbon_PR_Builder_2.4.5/3671/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12602/job/ApacheCarbonPRBuilder2.3/5416/


Does not build on Ubuntu Linux 10.04LTS

I cannot manage to build it on Ubuntu 10.04LTS via Luarock (but I suspect it is not a Luarock issue).
It this version of libcurl unsupported?
sp@ubuntu1040lts:~/luarocks/bin$ ./luarocks install lua-curl
Installing https://rocks.moonscript.org/lua-curl-0.3.1-1.src.rock...
Using https://rocks.moonscript.org/lua-curl-0.3.1-1.src.rock... switching to 'build' mode
Archive:  v0.3.1.zip
40695b42648253f2e0b7466256ac292ec37c4602
...
gcc -O2 -fPIC -I/home/sp/luajit/include/lua5.1 -c src/l52util.c -o src/l52util.o -I/usr/include
gcc -O2 -fPIC -I/home/sp/luajit/include/lua5.1 -c src/lceasy.c -o src/lceasy.o -I/usr/include
gcc -O2 -fPIC -I/home/sp/luajit/include/lua5.1 -c src/lcerror.c -o src/lcerror.o -I/usr/include
gcc -O2 -fPIC -I/home/sp/luajit/include/lua5.1 -c src/lchttppost.c -o src/lchttppost.o -I/usr/include
gcc -O2 -fPIC -I/home/sp/luajit/include/lua5.1 -c src/lcurl.c -o src/lcurl.o -I/usr/include
src/lcurl.c:173:28: error: ‘CURLGSSAPI_DELEGATION_NONE’ undeclared here (not in a function)
 #define FLG_ENTRY(N) { #N, CURL##N },
                            ^
src/lcflags.h:48:1: note: in expansion of macro ‘FLG_ENTRY’
 FLG_ENTRY(GSSAPI_DELEGATION_NONE          )
 ^
src/lcurl.c:173:28: error: ‘CURLGSSAPI_DELEGATION_POLICY_FLAG’ undeclared here (not in a function)
 #define FLG_ENTRY(N) { #N, CURL##N },
                            ^
src/lcflags.h:49:1: note: in expansion of macro ‘FLG_ENTRY’
 FLG_ENTRY(GSSAPI_DELEGATION_POLICY_FLAG   )
 ^
src/lcurl.c:173:28: error: ‘CURLGSSAPI_DELEGATION_FLAG’ undeclared here (not in a function)
 #define FLG_ENTRY(N) { #N, CURL##N },
                            ^
src/lcflags.h:50:1: note: in expansion of macro ‘FLG_ENTRY’
 FLG_ENTRY(GSSAPI_DELEGATION_FLAG          )
 ^

Error: Build error: Failed compiling object src/lcurl.o

sp@ubuntu1040lts:~/luarocks/bin$ dpkg -l | grep curl
ii  curl                                7.19.7-1ubuntu1.11                  Get a file from an HTTP, HTTPS or FTP server
ii  gnupg-curl                          1.4.10-2ubuntu1.8                   GNU privacy guard - a free PGP replacement (
ii  libcurl3                            7.19.7-1ubuntu1.11                  Multi-protocol file transfer library (OpenSS
ii  libcurl3-gnutls                     7.19.7-1ubuntu1.11                  Multi-protocol file transfer library (GnuTLS
ii  libcurl4-openssl-dev                7.19.7-1ubuntu1.11                  Development files and documentation for libc
ii  python-pycurl                       7.19.0-3                            Python bindings to libcurl

Oldest version with I test is 7.22 (which one installed on Travis)
According Symbols In Versions CURLGSSAPI_ exists since 7.22.
So may be it sufficient just wrap this options to ifdefs based on version or flags (lcflags.h)
#ifdef CURLGSSAPI_DELEGATION_NONE
FLG_ENTRY(GSSAPI_DELEGATION_NONE          )
FLG_ENTRY(GSSAPI_DELEGATION_POLICY_FLAG   )
FLG_ENTRY(GSSAPI_DELEGATION_FLAG          )
#endif

I can not test it. So I would appreciate if you can confirm that it works (or better make PR)

Yes I confirm this fixes the issue, the module compile just fine with this change (I messed up the PR on my side, I would appreciate if you could commit the change instead).
Thank you

On a side note, is there a plan to release a new minor version soon (with this fix) ?


Make it an error for native-test to run no tests for a package

Currently if an Android plugin has no native unit tests, we silently skip it. This means it's easy to accidentally add a plugin without a test harness, or to accidentally break the running of unit tests (e.g., if their location changes but the script isn't updated).
Once https://github.com/flutter/flutter/issues/83358 is fixed, or at least further along, we should make it an error for a plugin that has an Android implementation in the package to not run any unit tests, and explicitly --exclude any we still need to have skipped. This makes it much harder to silently do the wrong thing, and is consistent with changes that have been recently made to other test commands in the tooling.

We may or may not want to do the same for firebase-test-lab; not having UI tests is a more common legitimate case, but we also don't want to just accidentally not run tests that we do have.

Retitling for updated command name; we should also do this for iOS.


fix: removed storybook warnings

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.513%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6799

Relevant Lines:
7640

💛  - Coveralls


🐛 Bug: Compliance bot isn't posting comments on PRs

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Expected
https://github.com/mtfoley/pr-compliance-action is used to verify that PRs match a set of rules. Those include having a title that confirms to conventional commits. If any failures are detected, it should post a GitHub comment on the PR.
Actual
It's not :( https://github.com/JoshuaKGoldberg/create-typescript-app/pull/731 -> https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6038776422/job/16385877918?pr=731:
Warning: PR Body did not match required format
Error: This PR's title should conform to specification at https://conventionalcommits.org/
Error: Resource not accessible by integration

Additional Info
I think I'd fixed this before. Need to check on that...

Maybe related: https://github.com/mtfoley/pr-compliance-action/issues/368


Update PULL_REQUEST_TEMPLATE.md

Updating PR information to make the marketing process easier

Sorry - one more that I didn't catch from the link

Thanks! I updated with some Cata's comments too


Feature Request: Add Boolean Parameter to Switch Traction Joint Velocity Units Between rad/s and m/s

I noticed that in the tricycle_controller, the control unit for the traction_joint velocity is in radians per second (rad/s), which also applies to the corresponding speed in the AckermannDrive. This is problematic because many trailers modeled after this controller input speed in meters per second (m/s), leading to inconsistencies and potential errors in control.
Solution:
I propose adding a boolean parameter use_wheel_vel_in_rad_ to allow switching between using rad/s and m/s for the traction joint velocity. When use_wheel_vel_in_rad_ is set to false, the controller should interpret the speed inputs in m/s instead of rad/s. This would provide greater flexibility and ensure compatibility with various trailer models that use m/s as their speed unit.
tricycle_controller.cpp
line 91
 auto_declare<bool>("use_wheel_vel_in_rad", use_wheel_vel_in_rad_);
line 207-209
  if(!use_wheel_vel_in_rad_){
    Ws_write = Ws_write* wheel_params_.radius;
  }

Hello!
Can you give some examples of these trailer models?. I'm just not sure about the convention with m/sec because ultimately the lower level hardware mostly support the rad/sec than m/sec as it depends on the radius of the wheel it is attached to.
What do you think?

Hello!
Can you give some examples of these trailer models?. I'm just not sure about the convention with m/sec because ultimately the lower level hardware mostly support the rad/sec than m/sec as it depends on the radius of the wheel it is attached to.
What do you think?

For example, in a trailer like the one below, the unit of speed for control commands sent via can bus protocol is m/h, because of the speed sensor that is included with the car, I think maybe m/s would be a good choice, but of course, what you are saying is very much for most of the low level hardware is rad/s. So this is just a suggestion.

Got it. What would be the feedback from the wheels? Will it be in m/sec as well?

Got it. What would be the feedback from the wheels? Will it be in m/sec as well?

The input and feedback from the can bus is actually in m/h and deg for wheel speed and steering respectively, but I have converted this to m/s and rad in the hardware
interface converts them to m/s and rad. for wheel speed I think maybe m/s is a bit more intuitive in this model.

I don't think that changing the unit for a revolute joint defined in the URDF to m/s is a proper way of solving this.
Why not just converting them inside the hardware component, if the custom hardware wants m/s for commanding via CAN? Then you still work with a valid description on the ROS-side, including simulators etc.

@christophfroehlich I agree with @christophfroehlich it doesn't sound right to me as well. The best option is to handle it at the HardwareComponent Level

I don't think that changing the unit for a revolute joint defined in the URDF to m/s is a proper way of solving this. Why not just converting them inside the hardware component, if the custom hardware wants m/s for commanding via CAN? Then you still work with a valid description on the ROS-side, including simulators etc.

Ok, I have another question then with the linear and angular velocities posted with NAV2 to the topic cmd_vel for robot navigation, I also need to convert the linear velocities to wheel revolutions rad/s right?

no. The controller (diff_drive, or tricycle in your case) calculates the wheel speed from the twist command using the kinematics of the robot.

Maybe this is the solution for your case: If your trailer excepts already a twist as input instead of the wheel speeds, then you can write a simple forward command controller accepting a twist message and your hardware component exposes these two inputs (linear velocity, angular velocity).


JBPM-5084: troubleshooting function for workitem

@mswiderski
related issue in here https://issues.jboss.org/browse/JBPM-5084.
I not sure it is reasonable, so please check it.
and i don't know how to create unit test for it , it just is draft code .

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

we certainly need tests for this and I believe regular retryWorkItem as well, though best to add it to jbpm repo as it's easier to test it when you have processes available

@mswiderski
I don't understand the line "though best to add it to jbpm repo as it's easier to test it when you have processes available".
how to add it to jbpm repo ?
I have other suggestion . we can add retryworkitemwithparams into interface  workitemmanager.
We can easily find and use it.

test should be added to jbpm repo

@mswiderski
I was update it.
Please check it

I don't see any updates mentioned in the comments? have you pushed the updates to your remote fork?

@mswiderski  Sorry, update it.

this can be closed as https://github.com/droolsjbpm/drools/pull/780 comes with updates


AER/FeatureExtraction/DatasetHandling/Recola_46.py does not work

Hi,
I am trying to make the AER scripts work on my computer for the RECOLA dataset.
While I successfully created the environment thanks to the environment.yml file and successfully preprocessed the data with the Preprocess.py script, I have been unable to create the data.json file with the Recola_46.py script.
Indeed, every time I launch the script, I get the following error
Traceback (most recent call last):
  File "./FeatureExtraction/DatasetHandling/Recola_46.py", line 1, in <module>
    from DataClasses import *
ModuleNotFoundError: No module named 'DataClasses'

I reinstalled the dataclasses library, that comes with python since 3.7, but it did not change the error.
I also removed caps from the import (from dataclasses import * instead of from DataClasses import *) but I got this error
Traceback (most recent call last):
  File "./FeatureExtraction/DatasetHandling/Recola_46.py", line 66, in <module>
    main()
  File "./FeatureExtraction/DatasetHandling/Recola_46.py", line 22, in main
    fileDict = AudioSample()
NameError: name 'AudioSample' is not defined

Thus, I believe that you are using a custom module named DataClasses.py, called by the line below, and that is not present in the repository.
https://github.com/LeBenchmark/Interspeech2021/blob/08bcd974c864f5a39477928a1a91d37e7635596e/AER/FeatureExtraction/DatasetHandling/Recola_46.py#L1
Could you please confirm this and if possible provide the corresponding file ?

Hello, yes, it is my bad, sorry, I uploaded the DataClasses file under "DatasetHandling", please let me know if that resolves the issue or any other issue you might encounter

Thank you !
This resolved the issue.
However, when extracting wav2vec2 features, I get the following error:
Traceback (most recent call last):
  File "FeatureExtraction/wav2vec2.py", line 8, in <module>
    from featFuncs import loadFromJson
ModuleNotFoundError: No module named 'featFuncs'

I guess, that is also caused by a missing file.
Could you please upload it ?
PS: I did not create a new issue for that since it seems related.

The file is now uploaded,
Also, many thanks for reporting the issues.

Thanks again for solving the issue.
I have one last question, that is not related to these issues.
I want to use the LeBenchmark model on RECOLA.
I can see the model is on HuggingFace, but I do not see how I can use it natively, as the wav2vec2.pyscript is made to work with fairseqonly.
Am I missing something ?

OK. Thank you for your time and help 🙂.
I will try getting more into HuggingFace to make it work with LeBenchmark.
If I cannot find a way, I will try to contact you.
Thanks again,
Clément

Any time and good luck :)

Hi,
I am still unable to use the scripts and the model.
Can i contact you by email ?


[SIL Optimization] Add a mandatory pass for optimizing the new os log APIs based on string interpolation.

This PR adds a mandatory pass for optimizing the new os_log APIs based on string interpolation.  The new os_log APIs are not publicly visible and are currently in stdlib/private. The goal of this optimization pass is to extract the format string and other compile-time constants from the string interpolation and make them literals. For this purpose, this pass uses the constant evaluator and folds string- and integer-valued constants inferred by the evaluator. This PR also include compile-time tests for the optimization pass, which are an addition to the existing runtime tests for the new os log APIs.
The PR consists of three commits, the latest commit has the relevant changes. The earlier two commits corresponds to other PRs that have not yet landed: refactoring of os log library implementation and skip functionality of constant evaluation.

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 73ba475c6c147c016edb150de3dc4d4036ee8fc9

@swift-ci Please test macOS Platform

Build failed
Swift Test OS X Platform
Git Sha - 73ba475c6c147c016edb150de3dc4d4036ee8fc9

Please smoke test macOS Platform

@swift-ci  Please smoke test macOS Platform

@swift-ci Please test macOS Platform

@eeckstein Thanks for the comments. I have pushed a commit that addresses them.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 73ba475c6c147c016edb150de3dc4d4036ee8fc9

Build failed
Swift Test OS X Platform
Git Sha - 73ba475c6c147c016edb150de3dc4d4036ee8fc9

Fixing @atrick comments

@swift-ci Please test


Add ability to exclude assemblies by expression

This PR introduces the ability to filter assemblies with an expression format closely resembling the one used by OpenCover. However, unlike OpenCover Coverlet doesn't support inclusion/exclusion syntax (+/-).
All instrument-able assemblies are inclusive by default and the Exclude property has been repurposed to accept a comma separated list of filter expressions. The ability to exclude source files (based on the work by @ido-namely) has been moved to the new ExcludeByFile property.
The filter rules can be used to exclude entire assemblies, all types in an assembly or all types in a specific namespace.
Syntax: [Assembly-Filter]Type-Filter
Examples:
/p:Exclude=[*]* => Excludes all types in all assemblies (nothing is instrumented)
/p:Exclude=[coverlet.*]Coverlet.Core.Coverage => Excludes the Coverage class in the Coverlet.Core namespace belonging to any assembly that matches coverlet.* (e.g coverlet.core)
/p:Exclude=[*]Coverlet.Core.Instrumentation.* => Excludes all types belonging to Coverlet.Core.Instrumentation namespace in any assembly
The PR introduces backwards incompatible changes and will be part of the 2.0 release this week
cc @MarcoRossignoli @ido-namely @jasonbock @SteveGilham @coenm @ryanmvt
Addresses #77

@tonerdo great job!TYVM!

Nice!! Good work
I see that you already merged this but here my two cents:
In Coverage.PrepareModules method the 'InstrumentationHelper.IsModuleExcluded' is called for every module. The _filter field is passed as a parameter. Inside the IsModuleExcluded, each item in _filter variable is checked for validity (IsValidFilterExpression(filter)). I would take this up to reduce the number of calls to IsValidFilterExpression.
So something like this (did not try to compile ):
public void PrepareModules()
{
    string[] modules = InstrumentationHelper.GetCoverableModules(_module);
    string[] excludedFiles =  InstrumentationHelper.GetExcludedFiles(_rules);
    _filters = _filters.Where(filterItem => IsValidFilterExpression(filterItem)).ToArray();

    // at this point, _filters  contains only valid expressions.
}

You can even take if further by not storing the filters as string[] but by creating new SomeSortOfModuleTypeFilterObject containing a module and type regex.

class SomeSortOfModuleTypeFilterObject
{
    public SomeSortOfModuleTypeFilterObject ( Regex typeRegex, Regex moduleRegex)
    {
      TypeRegex = typeRegex;
      ModuleRegex = moduleRegex;
    }

    public Regex TypeRegex { get; }
    public Regex ModuleRegex { get; }
}

public void PrepareModules()
{
    string[] modules = InstrumentationHelper.GetCoverableModules(_module);
    string[] excludedFiles =  InstrumentationHelper.GetExcludedFiles(_rules);
    var filters = _filters
                    .Where(filterItem => IsValidFilterExpression(filterItem))
                    .Select(filter =>
                    {
                      // Code taken from InstrumentationHelper.IsModuleExcluded.
                      // Probably such code will end up in its own method.
                      string typePattern = filter.Substring(filter.IndexOf(']') + 1);
                      string modulePattern = filter.Substring(1, filter.IndexOf(']') - 1);

                      typePattern = WildcardToRegex(typePattern);
                      modulePattern = WildcardToRegex(modulePattern);

                      return new SomeSortOfModuleTypeFilterObject (
                        new Regex(typePattern, RegexOptions.Compiled),
                        new Regex(modulePattern, RegexOptions.Compiled));

                      // or using some sort of lazy construction..
//                      return new SomeSortOfModuleTypeFilterObject (
//                        new Lazy<Regex>(() => new Regex(typePattern, RegexOptions.Compiled)),
//                        new Lazy<Regex>(() => new Regex((modulePattern, , RegexOptions.Compiled)),

                    })
                    .ToArray();

    // at this point, filters is an array of 'SomeSortOfModuleTypeFilterObject' containing regex for object and module matching.
}

Such data can be usefull for the foreach loops in IsModuleExcluded and in IsTypeExcluded methods. Now, each filter in filters is parsed and Regex object created each single time.
Constructing compiled regex objects can be faster when executing the same regex multiple times. Also storing and reusing them puts less presure on the GC.

Improvement:
I have a question why not to have the same syntax as for other tools?
Why not to use SonarScanner format
/d:sonar.coverage.exclusions="/MyFun*.cs,/Test.cs,/Exception.cs,/Attribute.cs"
for /p:ExcludeByFile?, for example:
/p:ExcludeByFile="/MyFun*.cs,/Test.cs,/Exception.cs,/Attribute.cs"
My build script:
& packages/dotnet-sonarscanner begin /d:sonar.login="$env:SONARCLOUDTOKEN" /k:"build-core" /d:sonar.host.url="https://sonarcloud.io" /n:"build" /v:"1.0" /d:sonar.cs.opencover.reportsPaths="Build.Tests/coverage.opencover.xml" /d:sonar.coverage.exclusions="/MyFun*.cs,/Test.cs,/Exception.cs,/Attribute.cs" /d:sonar.organization="hack2root-github" /d:sonar.sourceEncoding="UTF-8"
& dotnet build --configuration Release
& dotnet test --configuration Release --no-build Build.Tests /p:CollectCoverage=true /p:CoverletOutputFormat=opencover
& packages/dotnet-sonarscanner end /d:sonar.login="$env:SONARCLOUDTOKEN"
& packages/csmacnz.Coveralls --opencover -i Build.Tests/coverage.opencover.xml

@hack2root I don't see a reason why ExcludeByFile shouldn't support the format you speak of. Kindly confirm @ido-namely, thanks


Drop pbkdf.go

It's not a Tor thing, why should it be here? It shouldn't.

Closed by b77346927df56004f02b6054099516ee1be39e3d.


Problem interacting with R from Graal.js/Node

$ polyglot --shell --jvm
GraalVM MultiLanguage Shell 19.0.0
Copyright (c) 2013-2019, Oracle and/or its affiliates
  JavaScript version 19.0.0
  Python version 3.7.0
  R version 3.5.1
js> Polyglot.eval('R', '0L')
Pointer[0xdef00000000034b]
js> Polyglot.eval('R', '0L') + 2
2
js> R>
R> export('x', 0L)
R> js>
js> Polyglot.import('x')
0
js> typeof(Polyglot.import('x'))
number
js> python>
python> import polyglot
python> polyglot.eval(language="R", string="0L")
0
python> type(x)
<class 'foreign'>
python> type(x + 2)
<class 'int'>

It looks like R numbers are not printed correctly in the polyglot shell. Instead of showing the value, they are printed as Pointers for some reason. Arithmetic operations, however, seem to work fine. The behavior is correct when the value is exported and then imported via the polyglot bindings, probably because it was converted to a JS number for some reason. GraalPython seems to handle all of this correctly.
In Node, a TypeError is raised:
$ node --polyglot --jvm
> Polyglot.eval('R', '0L')
TypeError: Cannot convert [0] to a number
    at ContextifyScript.runInThisContext (vm.js:96:20)
    at REPLServer.defaultEval (repl.js:332:29)
    at bound (domain.js:395:14)
    at REPLServer.runBound (domain.js:408:12)
    at REPLServer.onLine (repl.js:639:10)
    at REPLServer.emit (events.js:194:15)
    at REPLServer.emit (domain.js:441:20)
    at REPLServer._onLine (readline.js:290:10)
    at REPLServer._line (readline.js:638:8)
    at REPLServer._ttyWrite (readline.js:919:14)

Tested with GraalVM CE 19.0.0 on macOS.
/cc @jak-ing

There are no scalar R numbers, everything is a vector, which could be a single element vector. From the point of view of interop:

vectors implement "array" related messages
single element vectors also respond to fitsInXYZ and asXYZ messages according to their type, so they look like a scalar value to some extent

js> Polyglot.eval('R', '0L')
Pointer[0xdef00000000034b]

this looks like JavaScript (or the REPL) sent (toNative followed by) asPointer message to the vector 0L in order to print it. /CC @woess

$ polyglot --shell --jvm
js> Polyglot.eval('R', '0L')
Pointer[0xdef00000000034b]

JavaScript REPL in GraalVM attempts to print a reasonable representation of each value. One of the first things that it checks is whether the value isPointer(), see JSRuntime.foreignToString(). This approach does not work well with languages like R where basically everything is a pointer. I think that we should move this check a bit further and prefer other representations ... unless it causes even more problems with other languages :-/. Of course, asPointer() should still be preferred to asNumber().
$ node --polyglot --jvm
> Polyglot.eval('R', '0L')
TypeError: Cannot convert [0] to a number

This TypeError is caused by a bug in JSRuntime.toNumber(). It does not handle boxed foreign numbers correctly.

Fixed by https://github.com/graalvm/graaljs/commit/ab666222c25f0d1a6807a500498f8985d5711597 and https://github.com/graalvm/graaljs/commit/2a7590089247983ddfbb8cec9dfb1b5a4827d445. So, we have
$ polyglot --shell --jvm
js> Polyglot.eval('R', '0L')
[0]

and
$ node --polyglot --jvm
> Polyglot.eval('R', '0L')
0

now.


Replace decorators with prependers

It fixes Zeitwerk errors (thus Rails 6 errors) due to decorators not declaring constants that Zeitwerk infers by their paths.

Closed in favor of #34.


update api call to get pindeploy info

related PR: https://github.com/pinterest/teletraan/pull/1619

Tested on dev1.


CB-9446 Fix real path returning null pointer on some Samsung devices

Fix for https://issues.apache.org/jira/browse/CB-9446

I have the same issue on Samsung J1 this morning
Thanks for this fix !

Is this fixing the same issues as #93?

Still crashing on Sony Aqua M2

@nikopolv This fix usually covered pre Kit Kat devices, does #93 execute properly with your Sony Aqua M2 ? Also, can you indicate the os version you have on the device ?

@riknoll The code in #93 is missing a null pointer check
But the differences for the code which retrieves the url is
#112

           Cursor cursor = cordova.getActivity().managedQuery(Uri.parse(uriString), proj, null, null, null);

           int column_index = cursor.getColumnIndexOrThrow(_DATA);

           cursor.moveToFirst();

           realPath = cursor.getString(column_index);

#93

  	cursor = context.getContentResolver().query(uri, projection, selection, selectionArgs,

  			null);

  	if (cursor != null && cursor.moveToFirst()) {

  		final int column_index = cursor.getColumnIndexOrThrow(column);

  		return cursor.getString(column_index);

  	}

I don't have time scheduled atm to do device testing

@charlesverge The Sony Aqua M2 had 4.4 kitkat running in it.

@nikopolv Does the Sony Aqua M2 with 4.4 kitkat work with the branch issue #93 is based off of ?

On a Samsung S5 with Android 5.0.1 this patch works fine

@charlesverge, do you have an ICLA signed for this? Usually when people write entire new methods, I need an ICLA before I can accept public contributions like this.
You can find the info here: http://www.apache.org/licenses/#clas
BTW, I like this better than #93.

@infil00p The method comes from a previous version of the plugin which was working for some devices.
https://github.com/apache/cordova-plugin-camera/blob/0d63ac27ca6911d34a3eef76e393d64e898d8b47/src/android/FileHelper.java

@charlesverge Yeah, and it was slated to be "deprecated" for some reason, which is why I forgot about it.  I added it back in since we can't use the ResourceAPI in the same way.

OK, do we still need this, or does the N fix also fix this? More testing is needed.

This probably got clobbered when I added a FileProvider to end all this getRealPath nonsense that was breaking everything.  I'm going to close this for now.


Add a generic Circle CI config file

Should run a standard Django test configuration.

Can this be optional and use CircleCI instead of Travis?

CircleCI could potentially also run the front-end linters and a pep-8 linter as well?

Duplicate of #2


Speed drop after a few seconds

Describe the bug
I prefilled overwatch into lancache and started a download from my pc. It starts with 70 MBps and then drops dramatically after a few seconds to 2-3MBps.
Additional Details

Platform you are running BattleNetPrefill on:  Linux Ubuntu server 23.04
I then tried filling a game into the lancache steam cache and downloading that. And that game downloaded full speed for the total download
Region : Amsterdam

What language do you have the game set to? Is it Dutch?

What language do you have the game set to? Is it Dutch?

My battle.net launcher is in english, but my region is the netherlands.
Could this be the issue?

It could very well be the issue. I'll try to reproduce later

I'm able to reproduce the speed drop, however while watching my access.log there are no MISS requests at all.  This has to be some sort of issue with the Overwatch installer itself.

Hi Tim,
Thank you for investigating, no solution at this point i presume? Should other games from blizzard download  correctly from the cache?

Presumably everything should download from the cache with no issue. I tried WoW and it looks like it has the same issue with no misses.
I didn't try any other ones because I don't honestly use battlenet anymore. I'd be curious to see if the same issue persists when the lancache is disabled.
 One thing to consider is that it is downloading at speeds that would normally not be attainable, and could be causing the battlenet client to choke


Inital codes to remove x86_64 dependency in HIP source build

With changes in this PR, HIP can be built on aarch64 systems.
Notice there are still other x86_64-dependent codes not completely removed from this PR.

Yes, this branch seems to be based on an older commit, which has not converted to the newer nvidia driver version.   Try rebasing this branch on top of master.
I'm also seeing a lot of clang-ctu failures:
[hcc_ctu] 88% tests passed, 10 tests failed out of 80
[hcc_ctu]
[hcc_ctu] Total Test time (real) = 124.10 sec
[hcc_ctu]
[hcc_ctu] The following tests FAILED:
[hcc_ctu] 	  7 - directed_tests/Functional/device/hipFuncSetDeviceFlags.tst (SEGFAULT)
[hcc_ctu] 	 55 - directed_tests/runtimeApi/memory/hipMemcpy_simple.tst (SEGFAULT)
[hcc_ctu] 	 56 - directed_tests/runtimeApi/memory/hipMemcpyAsync-simple.tst (SEGFAULT)
[hcc_ctu] 	 57 - directed_tests/runtimeApi/memory/hipMemcpy-modes.tst (SEGFAULT)
[hcc_ctu] 	 58 - directed_tests/runtimeApi/memory/hipMemcpy-size.tst (SEGFAULT)
[hcc_ctu] 	 59 - directed_tests/runtimeApi/memory/hipMemcpy-dev-offsets.tst (SEGFAULT)
[hcc_ctu] 	 60 - directed_tests/runtimeApi/memory/hipMemcpy-host-offsets.tst (SEGFAULT)
[hcc_ctu] 	 61 - directed_tests/runtimeApi/memory/hipMemcpy-multithreaded.tst (SEGFAULT)
[hcc_ctu] 	 68 - directed_tests/runtimeApi/multiThread/hipMultiThreadStreams1.tst (OTHER_FAULT)
[hcc_ctu] 	 80 - directed_tests/kernel/inline_asm_vadd.tst (SEGFAULT)
[hcc_ctu] Errors while running CTest

@kknox just rebased.


Fix generated API documentation for few SerializerMethodFields

Codecov Report

Merging #63 (35cd2b3) into main (b1e1efc) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   88.56%   88.56%
=======================================
  Files          48       48
  Lines        1522     1522
  Branches      118      118
=======================================
  Hits         1348     1348
  Misses        140      140
  Partials       34       34

Impacted Files
Coverage Δ

gtfs/api/routes.py
100.00% <100.00%> (ø)

gtfs/api/stops.py
98.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e1efc...35cd2b3. Read the comment docs.


🐛 Consulting Page - Fix Technology card Images

[ ] Fix React Native image
[ ] Can we configure a build error if images aren't available? Investigate (Timebox to a 2)

Moving second task into #157


Look at unifying PATH and DIRECTORY artifact definitions types

Per conversation with @grrrrrrrrr let's flush out some unclearness about the usage of PATH and DIRECTORY artifact definitions types

Deprecated DIRECTORY source type in https://github.com/ForensicArtifacts/artifacts/pull/475


Stripe firebase

I was able to implement everything you provide in readme to integrate firebase with stripe. But, when I create a new user in firebase after i deploy the stripe from firebase cli, i cannot see the account in Stripe. I tried everything, deploy with test key, secret key, publishable key, I was unable to see my new account created in stripe sdk.
Please help.

We won't be much help here without a minimal repro of the problem and some error logs. Most likely, you'll also see some useful error output in your console.

Also, this might help: https://github.com/WikipediaBrown/GCF-Stripe-Functions https://github.com/WikipediaBrown/GCF-Stripe-Functions
-Perris Davis(I’m that WikipediaBrown dude...)

On Mar 15, 2017, at 10:34 AM, katowulf<EMAIL_ADDRESS>wrote:
We won't be much help here without a minimal repro of the problem and some error logs. Most likely, you'll also see some useful error output in your console https://console.firebase.google.com/project/_/functions/logs?search=&severity=DEBUG.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/firebase/functions-samples/issues/49#issuecomment-286819983, or mute the thread https://github.com/notifications/unsubscribe-auth/AMsNq6S5nwoGwGGVwaaovXDWSZZVDvdfks5rmCELgaJpZM4Mduy4.

@katowulf my log is empty. No error. In my firebase hosting folder, I can see the instances I deploy which mean, that a hosting was created with my Stripe secret key. But somehow , Stripe won't accept my created new user. Any advice ?
Below is the confirmation that the deploy was succesfull.

Looks like the same issue as #50: the functions are not actually deployed. You can check in the Functions section of the Firebase Console for instance if any functions was deployed on your Firebase project but from the logs above something went wrong. You should see something like this:

Same questions as #50:
Can you check that firebase version returns 3.5.0?
Did you just download a fresh version of the stripe sample? Did you modify anything?

@nicolasgarnier after spending 8 hour on my computer I finally set things up.  But I am having error in my logs to reach stripe. Please help me.

@nicolasgarnier
the log in detail

Note the log item immediately below. External network requests are blocked on the free tier. You'll want to upgrade to the Blaze (pay as you go) plan which includes a free tier for Functions.

If you’re using the free tier, you can only make requests out to google owned services. Are you on the free plan?
-Perris Davis

On Mar 15, 2017, at 3:01 PM, fxo140130<EMAIL_ADDRESS>wrote:
@nicolasgarnier https://github.com/nicolasgarnier
the log in detail
https://cloud.githubusercontent.com/assets/25092371/23972754/0dfed080-09a1-11e7-9d5e-c472a6b1e461.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/firebase/functions-samples/issues/49#issuecomment-286893579, or mute the thread https://github.com/notifications/unsubscribe-auth/AMsNqwPs4xkvSLlXfrDRH09Fe1K1PO1Lks5rmF_HgaJpZM4Mduy4.


update templates

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md under the header # admiral (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue in the Development Section on the right hand side.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

@dgrassellyb @manciniedoardo Hi all I raised this in the previous PR.  I don't think we should be using getwd() in templates that users have access to.  Newbies could create datasets in places they are not supposed to be creating stuff in depending on where their current directory is set.  While I think they might have trouble finding the temporary directory, I feel like getwd() can also be a bit of a challenge as well but will have a bigger impact.
What was wrong with the previous tempdir() call?

oh also could i get taken off the PR review auto-assignment?  I think @kaz462 should take my place

What was wrong with the previous tempdir() call?

I believe @dgrassellyb needed to change something to get the templates to update pharmaverseadam? A

@dgrassellyb @manciniedoardo Hi all I raised this in the previous PR. I don't think we should be using getwd() in templates that users have access to. Newbies could create datasets in places they are not supposed to be creating stuff in depending on where their current directory is set. While I think they might have trouble finding the temporary directory, I feel like getwd() can also be a bit of a challenge as well but will have a bigger impact.

I don't know if this is a massive issue. If users are running the template for the first time then the first thing they'll usually do is alter those final lines of code to save the resulting dataset wherever they need it?

@dgrassellyb @manciniedoardo Hi all I raised this in the previous PR. I don't think we should be using getwd() in templates that users have access to. Newbies could create datasets in places they are not supposed to be creating stuff in depending on where their current directory is set. While I think they might have trouble finding the temporary directory, I feel like getwd() can also be a bit of a challenge as well but will have a bigger impact.
What was wrong with the previous tempdir() call?

Hi @bms63 I will remove you from the automatic PR reviewers, sorry for the spam !
And about this tempdir it was an issue for me (because it's creating a temp dir with random idea and it was more work to retrieve the data created from the github action)
But I have a quick solution for this : from the templates I can detect if it's running through github action or not (in the case of users local run I can in this case use tempdir) - would you be ok with this ?

What was wrong with the previous tempdir() call?

I believe @dgrassellyb needed to change something to get the templates to update pharmaverseadam? A

@dgrassellyb @manciniedoardo Hi all I raised this in the previous PR. I don't think we should be using getwd() in templates that users have access to. Newbies could create datasets in places they are not supposed to be creating stuff in depending on where their current directory is set. While I think they might have trouble finding the temporary directory, I feel like getwd() can also be a bit of a challenge as well but will have a bigger impact.

I don't know if this is a massive issue. If users are running the template for the first time then the first thing they'll usually do is alter those final lines of code to save the resulting dataset wherever they need it?

I actually don't think they will alter any lines - they will just run the entire code and see what happens - this is what I would do.  They could end making datasets in their study folders and since we just use standard ADaM names overwrite their study datasets.  Apologies for being nitpicky on this but I really don't think we should assume a user is going to change this part of the template.  There is so much code already for them to work through.
@dgrassellyb I don't fully understand your solution.  I'd prefer not to alter the template code.  Could you inject/delete some temporary code into the templates to help you with your workflow?

What was wrong with the previous tempdir() call?

I believe @dgrassellyb needed to change something to get the templates to update pharmaverseadam? A

@dgrassellyb @manciniedoardo Hi all I raised this in the previous PR. I don't think we should be using getwd() in templates that users have access to. Newbies could create datasets in places they are not supposed to be creating stuff in depending on where their current directory is set. While I think they might have trouble finding the temporary directory, I feel like getwd() can also be a bit of a challenge as well but will have a bigger impact.

I don't know if this is a massive issue. If users are running the template for the first time then the first thing they'll usually do is alter those final lines of code to save the resulting dataset wherever they need it?

I actually don't think they will alter any lines - they will just run the entire code and see what happens - this is what I would do. They could end making datasets in their study folders and since we just use standard ADaM names overwrite their study datasets. Apologies for being nitpicky on this but I really don't think we should assume a user is going to change this part of the template. There is so much code already for them to work through.
@dgrassellyb I don't fully understand your solution. I'd prefer not to alter the template code. Could you inject/delete some temporary code into the templates to help you with your workflow?

My solution would be the following before saving results to the folder:
if (Sys.getenv("GITHUB_ACTIONS") != "") {
     dir <- file.path(getwd(), "tmp")
}
else {
    dir <- tempdir()
}

GITHUB_ACTIONS is an env variable defined from github workflows (we are already using this kind of logic in some other workflows to make distinction between local exec / user local env

Hmmm, not sure I like this being at the bottom of the template - this could indeed confuse users i feel.

@bms63 / @manciniedoardo I will create an issue and make some updates to handle this from the workflow (so putting back also temp dir)

Thanks @dgrassellyb !

@manciniedoardo / @bms63 :
Just made some tests and I can see the tempdir() instruction is creating each time a new temp directory .. is this really the behavior you want ? (having a temp directory for each template ?) -
some examples of folders created :
"/tmp/Rtmpfl9Z0x"
"/tmp/RtmpMUrqVF"
(I am not completely aware of the final use of these data from users but it seems complex I guess to navigate every subfolders to get the produced data.. )

Just making also a quick test but something to consider also but tempdir() is creating a temporary folder that will be deleted after the R session - it seems that it is the behavior of tempdir func :
root@bcf2f57b6eda:/workspace# ls /tmp
root@bcf2f57b6eda:/workspace# R
> tempdir()
[1] "/tmp/RtmpixCuDB"
> list.files("/tmp")
[1] "RtmpixCuDB"
> q()
root@bcf2f57b6eda:/workspace# ls /tmp

it will be only available during the R session (during the template execution) and then erased at the end (so we are not keeping rda data) (I don't know if it's a behavior depending of users os but it's what's happening for me)
But also agree with you @bms63 that I am not fan of getcwd(), I will suggest maybe keeping the tmp folder but creating it in a different way :
dir.create(file.path(tmp_dir, "templates_data")) (I made some tests and templates_data is not removed after R session) (and naming it templates_data would allow to get data in a fixed path and not with random ids geerated)

I think the intention of using tempdir() is to avoid that the template overwrites any files in the user's directory. It is expected that the users update dir if they want to keep the dataset permanently.

There are two use cases for the templates.
The primary use case is providing a starting point for an ADaM script. By default it should not overwrite or add anything to the user's directory. It should be a conscious decision of the user to write something to the directory.
The secondary use case is to create the ADaM datasets in pharmaverseadam via a workflow.
I would prefer to keep the template code as it is and modify the template on the fly when running it in the workflow. Is this possible?


Add @yhx-12243's proof that S187 Right ray topology is P89 Fixed point property.

Thanks @yhx-12243. Next time you make an approval, you are also welcome to use the "Squash and Merge" button to merge these changes into the main database.

🙃 I'm willing to relitigate whether we want to make the commit message cleanup procedure a policy at a future community meeting. I'll put it on the agenda.


Feat/clean

cleaning + lot of typing (annoying + time consuming ones like any)

@julio4 could you please check why the deployment fails?


Limit choices when configuring values path

We could limit the choices when configuring the values path. Currently all files/directories are shown in the dropdown, while usually either a values.yaml is relevant, or maybe a name based on a custom scheme (e.g. values.dev.yaml, values.prod.yaml):

We could for example by default only show files with the name values.yaml, or yaml files that begin with values. And additionally we could make that a setting, so a user could set that all files that match for example values.*.yaml or *.values.yaml are shown in the dropdown. I think the setting would probably be on the organisation level.
Has anybody an opinion on this? Do you think that's relevant/interesting?

Hey, @tschale thank you for the input!
I was just asking myself whether we have a guarantee that the values and secrets are always present in a file with the naming scheme values*.yaml or a file with a name starting with `values'. Do we definitely want to restrict the choices to those files here? Can you confirm that helm charts are generally written with this file naming convention?
I mean this is definitely possible - we could do this either in the project service or filter through the file names in the frontend via JS.

And additionally we could make that a setting, so a user could set that all files that match for example values.*.yaml or *.values.yaml are shown in the dropdown. I think the setting would probably be on the organisation level.

So you mean that these files are automatically selected for the chart rendering process for any project in the organization?

I was just asking myself whether we have a guarantee that the values and secrets are always present in a file with the naming scheme values*.yaml or a file with a name starting with `values'.

There's no guarantee for that, of course everybody can name their values files how they want. From what I've seen in open source projects there's a strong tendency to have one values.yaml.
I think ArgoCD is only using/allowing files that start with values.

So you mean that these files are automatically selected for the chart rendering process for any project in the organization?

No, I've meant making the condition as to what choices are visible in the dropdown configurable. The default could be values.yaml, or values.*.yaml. But as a user I could change that to *.values.yaml, allowing my files dev.values.yaml, prod.values.yaml and resourcelimits.values.yaml to appear in the dropdown for selection, which we would otherwise exclude.

No, I've meant making the condition as to what choices are visible in the dropdown configurable. The default could be values.yaml, or values.*.yaml. But as a user I could change that to *.values.yaml, allowing my files dev.values.yaml, prod.values.yaml and resourcelimits.values.yaml to appear in the dropdown for selection, which we would otherwise exclude.

Got it. What's the benefit? I'm a bit hesitant - this feels a bit like "a setting for another setting" kind of thing.
Does the amount of choices worry you? If that's a thing we could probably change the input to some kind of searchable dropdown, to give the user the option to restrict choices, if needed. Or do you want to address another issue? I'd like to understand the actual problem a bit better.

It's not an actual problem, my thought is just about clearness, about showing that what actually is relevant. It wouldn't make any sense to select anything other than a values file, so it might be nice to just have values files in the dropdown.


feat(go/adbc/driver/snowflake): enable passing private key for JWT via string and not file

Adds support for passing PKCS8 values to Snowflake without having to read a file.

Includes C# integration updates to tests
includes support for PKCS8 encryption
Includes test case in Snowflake driver

Resolves https://github.com/apache/arrow-adbc/issues/1204

Neither of the tests in the go driver_test file are testing the new options with the adbc driver itself. Can you please update / modify the tests to use the adbc interface and new options? Thanks

good call out. I refactored them to call the adbc driver directly.

Other than the question of whether or not we need to add secrets on the repo in order to properly test the JWT auth stuff in the CI tests, this all looks good to me from the Go side. I don't know C# well enough to comment on that code

C# changes look good to me.

This is ready to merge.


fix: specifies the max length for crate name

Provides the maximum length on the crate name as is defined
in the crate's validation source code from crates.io.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) soon.
Please see the contribution instructions for more information.

Thanks for the PR!  Since this is a crates.io restriction, can you move that to the end of the paragraph where those additional restrictions are listed?

Thanks for the PR! Since this is a crates.io restriction, can you move that to the end of the paragraph where those additional restrictions are listed?

Of course!

@ehuss thanks for the feedback, given that the list is growing, I changed the format to list so it's easier to read, wdyt?

Thank you!
@bors r+

:pushpin: Commit 98ccc09eb5508ae0f00158154bfb29318c68b6af has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 98ccc09eb5508ae0f00158154bfb29318c68b6af with merge a8d61d01aa9cbeb5683b5f603bcd7b5587c7f1f2...

:broken_heart: Test failed - checks-actions

@bors retry
MSVC stable failed running benches/resolve.rs, which ran the resolver on the cargo workspace, and failed with:
Testing resolve_ws/cargo
    Updating `local-snapshot` index
 Downloading crates ...
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: failed to download from `[https://crates.io/api/v1/crates/winapi/0.3.9/download`](https://crates.io/api/v1/crates/winapi/0.3.9/download%60)

Caused by:
    [1] Unsupported protocol (Received HTTP/0.9 when not allowed)', benches\resolve.rs:45:6

I have never seen that error before. Very strange!

:hourglass: Testing commit 98ccc09eb5508ae0f00158154bfb29318c68b6af with merge 51f7da4ab400f30d40fc69c3d8a2df313213d789...

:broken_heart: Test failed - checks-actions

@bors retry
The curl bug haven't been fixed yet, but curl-sys 0.4.57+curl-7.85.0 is yanked for the time being. I'll give it another shot.
ref: https://github.com/alexcrichton/curl-rust/issues/460#issuecomment-1239985109

:hourglass: Testing commit 98ccc09eb5508ae0f00158154bfb29318c68b6af with merge 9ecc7f8c40ad51843c8b5c938cf874cf62118e93...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 9ecc7f8c40ad51843c8b5c938cf874cf62118e93 to master...


Request for documentation on recommended flow in slim for train, validation, and test sets

The examples in the slim README.md give basic documentation for training and evaluating models when used separately; however, there is guidance missing on how to do the classic cycle of mini-batch gradient descent using shuffled subsets of the training set, periodically evaluating validation set, and then evaluating on the test set post-training.
Using the MNIST tutorial and this tutorial for reference, the best I came up with was something like this where I'm effectively monkey-patching the train_step_fn to periodically output accuracies:
from tensorflow.contrib.slim.python.slim.learning import train_step

graph = tf.Graph()
with graph.as_default():
  image, label = input('train', FLAGS.dataset_dir)
  images, labels = tf.train.shuffle_batch([image, label], batch_size=FLAGS.batch_size, capacity=1000 + 3 * FLAGS.batch_size, min_after_dequeue=1000)
  images_validation, labels_validation = inputs('validation', FLAGS.dataset_dir, 5000)
  images_test, labels_test = inputs('test', FLAGS.dataset_dir, 10000)

  with tf.variable_scope("model") as scope:
    predictions = model(images, FLAGS)
    scope.reuse_variables()
    predictions_validation = model(images_validation, FLAGS)
    predictions_test = model(images_test, FLAGS)

  slim.losses.softmax_cross_entropy(predictions, labels)
  optimizer = tf.train.AdamOptimizer(FLAGS.learning_rate)
  train_op = slim.learning.create_train_op(slim.losses.get_total_loss(), optimizer)

  accuracy_validation = slim.metrics.accuracy(tf.to_int32(tf.argmax(predictions_validation, 1)), tf.to_int32(tf.argmax(labels_validation, 1)))
  accuracy_test = slim.metrics.accuracy(tf.to_int32(tf.argmax(predictions_test, 1)), tf.to_int32(tf.argmax(labels_test, 1)))

def train_step_fn(session, *args, **kwargs):
  total_loss, should_stop = train_step(session, *args, **kwargs)

  if train_step_fn.step % FLAGS.validation_check == 0:
    accuracy = session.run(train_step_fn.accuracy_validation)
    print('Step %s - Loss: %.2f Accuracy: %.2f%%' % (str(train_step_fn.step).rjust(6, '0'), total_loss, accuracy * 100))

  if train_step_fn.step == (FLAGS.max_steps - 1):
    accuracy = session.run(accuracy_test)
    print('%s - Loss: %.2f Accuracy: %.2f%%' % ('FINAL TEST', total_loss, accuracy * 100))

  train_step_fn.step += 1
  return [total_loss, should_stop]

train_step_fn.step = 0
train_step_fn.accuracy_validation = accuracy_validation

slim.learning.train(
  train_op,
  FLAGS.logs_dir,
  train_step_fn=train_step_fn,
  graph=graph,
  number_of_steps=FLAGS.max_steps
)

Note: one problem with this implementation is that the final test set is not guaranteed to be run in the case of early exit.
I've posted in the slack channel and Googled around, but haven't been able to find any examples for this basic use case. Accordingly, I would like to propose that an example providing the best practice to periodically evaluate batch trained models using the validate set and the trained model against the test set to be added to the slim README.md.
I think it would really help the community to have a clearer idea on the intentions of the slim team on how the batch training and evaluation paths were designed to be used together during and after training.

@nathansilberman any suggestion?

+1

+1

Come on guys, the critical use case of training + validating is still — even on r1.0 — completely non-obvious to implement using the slim "lego blocks". We need guidance here, if you please.

Same here ... I am having trouble with that too!

Looking for inputs too!

+1

+1

+1

We have found that running eval on validation dataset in a different process works better.
In most cases, the validation dataset requires several batches, and takes time that could be used to make progress on training.
So the recommended way is to save checkpoints at regular intervals, then use slim.evaluation_loop() to keep evaluating checkpoints while training.
Finally after training, one would run eval on test set.

@sguada @nathansilberman. Has there any update on this? Is there a good way to periodically verify accuracy on training & validation set DURING training instead of two separate processes? Thanks.

+1

@sguada
Thanks for your suggestion. I agree that validating in a separate process sounds like a better approach.
There are a number of things that are known during training time: what data file is used, what samples are used for training (as opposed to reserved for validation), what kink was introduced in the code to perform a certain test....etc. These important pieces of information  need to be passed to the other process reliably.
Since it seems to be the standard use case, would it be possible to have, in the repo, an example of such mechanics? slim seems incomplete if it provides many awesome ways to train a network easily, but no easy way to monitor/validate its progress.
Thanks again.

@ybsave what @kmalakoff wrote is a way to compute evaluation metrics while training.
As I mentioned above, that has some problems, like slowing down the training, but could be used for early stopping.
For examples on how to train and evaluate in two different process see:
https://github.com/tensorflow/models/blob/master/slim/train_image_classifier.py
https://github.com/tensorflow/models/blob/master/slim/eval_image_classifier.py
I typically just run train_image_classifier in one process and eval_image_classifier in another.

In the meantime I've been using the (pre-trained) classification models (vgg, resnet) created by slim, with a regular tensorflow train+val loop. This works well.
For resnet use something like
is_training = tf.Variable(True, name='is_training')
with slim.arg_scope(resnet_v1.resnet_arg_scope(is_training=is_training)):
At the training part in each epoch run:
sess.run(is_training.assign(True))
and at the validation:
sess.run(is_training.assign(False))

Since there's no single official procedure, I created a couple of scripts to perform the training/validation in different processes (which we used to participate in a machine learning challenge). If you wanna take a look, they're here: https://github.com/learningtitans/isbi2017-part3#deep-learning-component-model-rc30

Seems Slim saves checkpoints at a fixed time interval defined in the save_interval_secs. This seems cause issue if we want to synchronization this with validation set evaluation process. Plus saving checkpoints at fixed time interval (instead of training steps) seems introduce an extra set of uncertainty. I believe override the supervisor can change this behavior but it is kind of messy. Is there a simpler way to do this?

You can dig into the supervisor and change it. I did the same and customized it a little bit for myself.

I would like to have an option in slim to be able to periodically run evaluation in the same process as training. Running in separate processes has some downsides for me when training on a single multi-gpu system: 1. A GPU is dedicated to running eval. Training would be faster if I could use all GPUs as "clones" for multi-gpu training, even accounting for doing periodic evaluation. Running eval on the CPU slows down training because eval uses a lot of CPU and then bottlenecks training on image decoding and augmentation. 2. My training process uses most of the system RAM. I can't run eval at the same time without heavy swapping.

Doesn't  TFSlim update anymore? It's really boring. Convenient setting for validation while trainning is really in need.

I found the following section really helpful: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/contrib/slim#evaluation-loop
I initially thought the main slim page was:
https://github.com/tensorflow/models/tree/master/slim
I created a PR to make this more explicit here:
https://github.com/tensorflow/models/pull/2371

It has been 14 days with no activity and this issue has an assignee.Please update the label and/or status accordingly.

Please reopen if tensorflow/models#2371 hasn't addressed it.

As explained above, the solution proposed in https://github.com/tensorflow/models/pull/2371 does not address the problem. We are looking for a canonical way to interleave training and evaluation, not for a way to perform evaluation as a separate process. For those of us with few GPUs (or just one!) the current pattern just doesn't work.

@liavassif

At the training part in each epoch run:
sess.run(is_training.assign(True))
and at the validation:
sess.run(is_training.assign(False))

this seems like an interesting approach. can you give a more complete example? I'm not sure how to use feed_dict to feed the different train/val inputs into the same model and reuse weights

@mixuala
After using sess.run() to set the is_training variable, the rest is just the usual mini-batch approach (at train or at validation).
        # is_train should be True when training and False for validation
        sess.run(is_training.assign(is_train))
        for batchid in range(batchN):
            if is_train:
                  cur_batch = get_batch_train(batchid)
            else:
                  cur_batch = get_batch_test(batchid)
            run_results = sess.run(ops_train, feed_dict=cur_batch)

@liavassif I keep getting RuntimeError: Graph is finalized and cannot be modified. but I am trying to run this inside slim.learning.train() in def train_step_fn(sess, ...) . maybe that is not the right way to go...

@mixuala this approach should be used instead of slim.learning.train(). You should just run the for loop in the example in your main code in order to perform training/val. Similarly as done in the regular Tensorflow MNIST/CIFAR tutorials (well, at least in the old tutorials, now they are using something called an Estimator).


fix: more descriptive aria labels for buttons

Related issue
#960
Scope of work

More descriptive aria-labels for buttons:
There are a lot of the same buttons for different products e.g. SfCollectedProduct can have different products listed and all of them will have the same button "Save for later" or "Remove". If we want to make navigation through website easier for people that need assistive technology, we should add product title and thanks to that, they will hear voice saying "Remove /product title/"
Fixed SfAddToCart aria-labelledby:
id has been moved to parent div, so that we can add product name to aria-label in SfAddToCart and voice of assistive technology will read "Add to cart /product name/"

@justyna-13 please resolve conflicts

thanks @justyna-13, awesome PR 🎖
@martaradziszewska good job, thank for CR and your support for this PR


Building React Native from source doesn't work

Description
Building React Native from source doesn't work
FIRMessagingModule.java:36: error: FIRMessagingModule is not abstract and does not override abstract method onActivityResult(int,int,Intent) in ActivityEventListener
I'm pretty sure that gradle choose old react-native version for react-native-fcm
Reproduction

react-native init AwesomeProject
follow this article https://facebook.github.io/react-native/docs/android-building-from-source.html
npm install react-native-fcm --save
react-native link react-native-fcm

here https://github.com/skv-headless/rn-build-fail project with this steps.
exclude should work but it doesn't make any difference https://facebook.github.io/react-native/docs/android-building-from-source.html#4-making-3rd-party-modules-use-your-fork
All projects which behave same way set  repositories { mavenCentral() } inside their build.gradle
Solution
I've added to package.json
"postinstall": "find . -type f -name build.gradle -not -path \"*/react-native/*\" -not -path \"*/Examples/*\" -not -path \"*/examples/*\" -print0 -exec sed -i '' \"s/.*com.facebook.react:react-native:.*/    compile project(':ReactAndroid')/\" {} +"
but I don't think it is the best solution.
Additional Information

React Native version: [master, "facebook/react-native#01af9ee8a7ec8921590e4cac29bf14267b068ddc"]
Platform: [Android]
Operating System: [MacOS]

building RN from source works for us. Looking at your project here are some pointers:

remove this: https://github.com/skv-headless/rn-build-fail/blob/master/android/build.gradle#L20-L23

change the ordering and naming here https://github.com/skv-headless/rn-build-fail/blob/master/android/settings.gradle#L5-L8 to

    compile fileTree(dir: "libs", include: ["*.jar"])
    compile "com.android.support:appcompat-v7:23.0.1"
    compile project(':react-native-android')
    compile project(':react-native-fcm')

If i remember correctly calling it ReactAndroid excluded RN dependency itself.

change these https://github.com/skv-headless/rn-build-fail/blob/master/android/settings.gradle#L5-L8 to reflect above changes. call it react-native-android instead of ReactAndroid.

@chirag04 thank you for response I made changes that you suggested (I hope I did it right) https://github.com/skv-headless/rn-build-fail/commit/97649bfeef5f33ffd4713dec0d7ff1901625f431 but I have same error 😞

@skv-headless , man I with you. I can't get rid of the
class FIRMessagingModule extends ReactContextBaseJavaModule implements LifecycleEventListener, ActivityEventListener error using every suggestion in the fcm issue and everything here. Still using a separate repo without my forked RN to build Android. Moving to RN40 soon which will allow me to avoid using my fork, but at some point I want to understand what's going on here.

I've got the same issue when trying to build from a fork of React Native 0.41.2.
Have spent the whole afternoon trying to get it to work with all sorts of different fixes suggested arounf the web but it doesn't want to work.  As soon as I switch back and point at 0.41.2 from npm it works fine, even when building from source!!
I haven't managed to figure out what's different between building from source on npm and from source on my fork...

Somebody with an solution ?? I'm with the same error and I can not found no one solution

Same issue here. I suspect the issue is this chunk in build.gradle:
allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
}

These files exist when a version is installed from npm but not in the forked react-native:

I couldn't use this information to find a solution but maybe someone else can. You could add those files to your forked repo and then it would probably work but that doesn't seem correct.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with Canny! Check out its new home: https://react-native.canny.io/feature-requests/p/building-react-native-from-source-doesnt-work


Use "go get" don't know the download situation

src/cmd/go/internal/get/vcs.go
431 431     var buf bytes.Buffer
432 432     cmd.Stdout = &buf
433 433     cmd.Stderr = &buf
    434 +   cmd.Stdout = os.Stdout
    435 +   cmd.Stderr = os.Stderr
434 436     err = cmd.Run()
435 437     out := buf.Bytes()

Excuse me, We want to see the download progress and net traffic. May I do this?

Most likely not happening https://github.com/golang/go/issues/22800#issuecomment-345439319

Yep, this was asked several times in the past. The tool will likely remain quiet be default, but see Brad's comment. If someone wants to prototype some kind of progress bar as it needs to be an external tool first.
Closing this.


dockeros: 1.0.3-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository dockeros to 1.0.3-0:

upstream repository: https://github.com/ct2034/dockeROS.git
release repository: https://github.com/ct2034/dockeros-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.6.9
previous version for package: 1.0.2-0

dockeros
* removing rospy from CMakeLists
* documentation
* Contributors: Christian Henkel, ct2034

Holding for sync: https://discourse.ros.org/t/preparing-for-kinetic-sync-2018-12-10/7088


Use timestamp deltas in grafana-data-store

Currently, we're storing metrics for grafana in vectors of (f32, i64), which have a size_of of 16. This PR replaces this system by storing a single i64 base timestamp, and u32 timestampdeltas from that, so we end up halving this to 8 bytes ((f32, u32)). u32::max_value() is<PHONE_NUMBER> milliseconds, or 49 days, while we clean up the metrics every 24 hours. This PR also just cleans up the code as well.

CI fails & conflicts.


devops-pipeline does not recognize devops organization

Trying to use devops for building and publishing azure functions from visual studio code.
I used this article  to connect to devops.
After running  az functionapp devops-pipeline create it wont find any organizations.
Error finding organization. Please check that the organization exists by logging onto your dev.azure.com acocunt
Loing via dev.azure.com works as expected. I am also project admin.
Investigative information
Please provide the following:

Timestamp:[6/3/2019 8:11:15 PM]
Function App name:
Function name(s) (as appropriate):
Core Tools version: 2.7.1158

az functionapp devops-pipeline create --organization-name NAME --project-name NAME

@Hazhzeng, do you have insight into why this might be happening?

Hi @JK87iab, instead of using az functionapp devops-pipeline create --organization-name NAME --project-name NAME
Could you try using az functionapp devops-pipeline create in your functionapp directory? It should guide you interactively to build a devops pipeline.
If it still doesn't work, please let me know.

@Hazhzeng
Getting
Would you like to use an existing Azure Devops organization?  (y/n): y
There are no existing organizations, you need to create a new organization.
Please select a region for the new organization:

@JK87iab Thanks for raising this issue. I will investigate and work on the fix in https://github.com/Azure/azure-functions-devops-build/issues/42.

Closing as a dupe of https://github.com/Azure/azure-functions-devops-build/issues/42

I'm experiencing the same issue, it seems not resolved.


Make should generate pkg-config file for gpr as well

tentative fix for https://github.com/grpc/grpc/issues/15166.

@coryan  can you help testing this?

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

Thanks for the quick turnaround, I know you folks are busy.  This seems to fix most problems, however, I think you also need to change the grpc.pc file to work in the case of static libraries.  This is the script I used to test this:
FROM ubuntu:16.04
MAINTAINER "Carlos O'Ryan<EMAIL_ADDRESS>
ARG NCPU=8

RUN apt-get update && apt-get install -y \
  build-essential \
  cmake \
  gcc \
  g++ \
  golang \
  git \
  cmake \
  libssl-dev \
  libtool \
  lsb-release \
  make \
  tar \
  wget \
  zlib1g-dev

RUN apt-get update && apt-get install -y curl unzip automake
WORKDIR /var/tmp/build-dependencies
RUN wget -q https://github.com/google/protobuf/archive/v3.5.2.tar.gz
RUN tar -xf v3.5.2.tar.gz
WORKDIR /var/tmp/build-dependencies/protobuf-3.5.2
RUN ./autogen.sh && ./configure && make -j ${NCPU} && make install
RUN ldconfig

WORKDIR /var/tmp/build-dependencies
RUN apt-get remove -y libc-ares-dev libc-ares2
RUN wget -q https://github.com/c-ares/c-ares/archive/cares-1_14_0.tar.gz
RUN tar -xf cares-1_14_0.tar.gz
WORKDIR /var/tmp/build-dependencies/c-ares-cares-1_14_0
RUN ./buildconf && ./configure && make -j ${NCPU} && make install
RUN ldconfig

ARG SHA=4563cf04886fd71ea7ffb89b1095ab6293a5fe59
WORKDIR /var/tmp/build-dependencies
RUN wget -q https://github.com/jtattermusch/grpc/archive/${SHA}.tar.gz
RUN tar -xf ${SHA}.tar.gz
WORKDIR /var/tmp/build-dependencies/grpc-${SHA}
RUN make -j ${NCPU} && make install

RUN ls -l /usr/local/lib/pkgconfig
RUN if [ ! -f /usr/local/lib/pkgconfig/gpr.pc ]; then echo "Did not install gpr.pc"; exit 1; fi

RUN pkg-config gpr --libs
RUN pkg-config gpr --version
RUN pkg-config grpc++ --libs --static | grep -q "gpr"

Ping.

@coryan   I updated the PR, now I get:
$ PKG_CONFIG_PATH=$(pwd) pkg-config grpc++ --libs --static
-L/usr/local/google/home/jtattermusch/github/grpc/testinstall/lib -lgrpc++ -lgrpc -lgpr -lz -lssl -lcrypto -ldl -pthread

$ PKG_CONFIG_PATH=$(pwd) pkg-config grpc++_unsecure --libs --static
-L/usr/local/google/home/jtattermusch/github/grpc/testinstall/lib -lgrpc++ -lgrpc -lgpr -lz

Does that look alright to you?

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@murgatroid99  can you please review?

@coryan if you are happy with the changes, I'll merge as soon as the tests pass.

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,951,097      Total (=)      1,951,097

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,661,414      Total (>)     10,661,410

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

@jtattermusch the changes look good in that they solve the problem with libgpr. Did you see my additional question in #15166 about libaddress_sorting?

@coryan  I'll address the libaddress_sorting problem in a separate PR.


Fix issue if encoding is enabled but not used

Motivation:
Fixes an IllegalReferenceCountException
Modification:
Retained the buffers so the encoder works correctly.
Result:
Fixes #11357

I thought something else was wrong in https://github.com/netty/netty/pull/11093 but managed to convince myself that it was fine. Turns out that there are similar problems for HTTP/1.0 and requests that don't set an accept-encoding.

Fixed, no idea how that happened.


maximum element of an array

Is your feature request related to a problem? Please describe.
I would like to work on this issue in java language...
Describe the solution you'd like
example-
input - 1,2,3,4,5
output - 5
Do you want to work on it
In java

Please assign this issue to me, I can work on it in Python.

/assign

I would like to code this in C++. I m a GSSOC'21 Partcipant .I will assure you that I will provide a most optimized code and commented code with efficient time complexity.@tarun26091999 @dheerajkotwani @raksha009 @anubhavitis @dheerajkotwani @rudrakshi99 @plazzy99 @nakul-19 please assign this to me .
Regards
Madhvi .


ci: test release pipeline

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: