Design of Serialization/Deserialization

I would like to have a discussion about how to implement the Serialization/Deserialization of the iceberg metadata. There are currently two different designs each with its pros and cons. The designs are:

Split representation into in_memory/on_disk part (example)
Use custom implementations of Serialize/Deserialize (example)

I would like to get your opinion which design you prefer.

If I'm not mistaken, use the split representation also need to custom implementation for on_disk part. And we should maintain two system: in_memory::type, in_memory::value, on_disk::type, on_disk::value. And we also need to maintain the conversion between in_memory and on_disk. So I think strictly separate two part may cause redundant code. Can we only separate some part🤔?

I also think that a split representation leads to redundancy which makes maintaining the code more difficult.
I personally think that the added complexity of custom implementations of Serialize/Deserialize is worth avoiding the redundancy.

I realized that this discussion is closely related to #3 , because it gives additional motivation for splitting the representation into an in_memory and on_disk part.
I think @ZENOTME made a good point about splitting only a part of the metadata.
We could split the metadata for all structs that have user interaction (i.e. TableMetadata) but use a single representation for the smaller building blocks (i.e. types, values, ..)

Close this as we have finished discussion. Feel free to open if needed.


C# 7.x: accessing fixed fields without pinning

While I think my solution allows the newer behavior, it might be too permissive.
See 'The main “challenge discussion in https://github.com/dotnet/csharplang/blob/main/proposals/csharp-7.3/indexing-movable-fixed-fields.md.

converted to draft: C# 7 feature.

This isn't an area I'm particularly expert in, but it does look like this is too permissive.
In particular, I think it would imply that the second example in the feature doc should be valid - and it's not. The feature only adds the ability for the first example to become valid without a fixed statement.
I honestly don't know how we'd allow the indexing part at the moment. One for discussion, certainly.

For discussion in the meeting. I think this works. (I can't make a suggestion on the PR, because the only change is a deletion):
Instead of deleting the single line, modify it as follows:

Otherwise, if E is a moveable variable (§22.4), the expression E.I must be one of the following, or a compile-time error occurs:

A fixed_pointer_initializer (§22.7)
An element_access (§11.710) expression where I is fixed-size buffer (§22.8).

Update based on above comment:
For discussion in the meeting. I think this works. (I can't make a suggestion on the PR, because the only change is a deletion):
Instead of deleting the single line, modify it as follows:

Otherwise, if E is a moveable variable (§22.4), the expression E.I must be one of the following, or a compile-time error occurs:

A fixed_pointer_initializer (§22.7)
An pointer_element_access (§22.6.4) expression where I is fixed-size buffer (§22.8).

Otherwise, E references a fixed variable and the result of the expression is a pointer to the first element of the fixed-size buffer member I in E. The result is of type S*, where S is the element type of I, and is classified as a value.

Note that the last bullet item is in the spec now. I added it to the comment because I thought its presence addresses @KalleOlaviNiemitalo 's second bullet point above. (Namely, if E isn't a moveable variable, this bullet applies).

@BillWagner: Not quite sure what you mean - it's got the "meeting: discuss" label, so I'd expect us to just find it that way. Anything else you wanted me to do?

@BillWagner: Not quite sure what you mean - it's got the "meeting: discuss" label, so I'd expect us to just find it that way. Anything else you wanted me to do?

Nope. Just hoping we can resolve this one today.

Ping @jskeet @MadsTorgersen
I've updated this to restore the previous language for member access, and add new text for element_access (E[I]), that follows the rules for pointer_element_access. This should be ready for a final review and (hopefully) merging.

Just to be clear, this is two new features:

x.Buffer[index]
&x.Buffer

... neither of which would have been valid before? Assuming that's the case, this is fine.

Only the first is valid without fixed. The second returns a pointer, so requires fixed.  The two features that now don't require pinning are:
var n = x.Buffer[index];
x.Buffer[inces] = n + 2; // Using the element in the buffer as a variable

Just to be clear, this is two new features:

x.Buffer[index]
&x.Buffer

... neither of which would have been valid before? Assuming that's the case, this is fine.

Only the first is valid without fixed. The second returns a pointer, so requires fixed.

Okay - so leaving aside pinning, was the second valid before now? I'm only mentioning it because it looks like it's new text.


No for possible on a label element?

virtualDom.create(virtualDom.h('label', {for:1, title:2}))
<label title="2"></label>

Why does the "for" attribute doesn't work?

The property name for the attribute for is htmlFor [1].  Changing for:1 to htmlFor: 1 should work.

Do you have a list of those properties like class -> className, for -> htmlFor ?
I imagine it is something inherent to the DOM model somehow...

We have an attribute:property mapping on a project that uses virtual-dom because we convert templates to vdom objects and we know everything is getting passed in as an attribute.
You can also pass in attributes directly to virtual-dom by using the attributes property.  So your example could also look like this and work:
virtualDom.create(virtualDom.h('label', {attributes:{for: 1}, title:2}))

virtual-dom doesn't try to have an .needsopinion about this. We just give you a way to set properties and attributes on nodes

To anyone finding this in the future... I just published a package hyperscript-attribute-to-property to solve this issue.
With this package, you can do this:
var vnode = h('div', { class: 'my-class' })

Instead of this:
var vnode = h('div', { className: 'my-class' })

Works with for and the others, too :)


E2E User Journey

Spec for your user journey we want to shoot for via docs.
Deploying a cluster (effectively our current README)

Deploy your first blueprint cluster with just ArgoCD (addon should include the bootstrap job)

Onboarding Teams

Add three sample teams to blueprint and deploy.

Deploying Workloads

Bootstrap Argo with sample App of Apps repo.
View applications in the browser

Workload Operations

View logs for applications
View metrics for applications
View container insights for applications

Network Security

Setup Network policies for applications
Validate network policies for applications

Scaling

Setup auto-scaling policies for an application
Scale the application up
Scale the application down

Continuous Deployment for Infra

Setup pipeline for blueprint deployments.
Setup CI pipeline for application deployments

Multi-region clusters

Deploy multiple blueprints across regions
Setup argo to deploy to multiple clusters.

Multi-account clusters

Integration with Control tower

Per @shapirov103 tickets

Network Policy config in teams
ArgoCD auto bootstrapping
Prototyping with cross account


Eliminate hardcoded values + move them at the beginning of file

Description
The goal of this PR to make visible the hardcoded values in the code.
Type of Change

[x] Refactor

Checklist

[x] I have read the contributing guidelines

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.szykes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Question: is it intentional to remove the comments for the existing const variables? If so, why?

It was intentional. I think the comments were information duplications.
// DefaultKafkaImage is the default Kafka image used when users don't specify it in KafkaClusterSpec.ClusterImage DefaultKafkaImage = "ghcr.io/banzaicloud/kafka:2.13-3.4.1"
vs
// Kafka Cluster Spec ... defaultKafkaImage = "ghcr.io/banzaicloud/kafka:2.13-3.4.1"

I think the comments were information duplications.

I don't necessary agree this is true for all the const vars..., for example:
	// DefaultAnyCastPort kafka anycast port that can be used by clients for metadata queries
	DefaultAnyCastPort = 29092
	// DefaultIngressControllerTargetPort is the default container port for the ingress controller
	DefaultIngressControllerTargetPort = 29092

without the comments, I don't think these two vars are straightforward enough for others to understand what they are used for (assuming without looking into the implementation).

The commenting thing is not an easy topic.
I have kept the first code comment of your comment. In addition, I have added the "chart path" for most of the defaults.


added amazonredshift

Status
Ready/In Progress/In Hold (Reason for hold)
Related Content Pull Request
Related PR: link to the PR at demisto/content
Related Issues
Related: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.

seems like the python package can be used in the original image


Workflows - Refactor Performance Test Custom Slider

Update CSS preferences and Adjust the Performance Test Values according to MUI Component APIs

close by this PR - https://github.com/litmuschaos/litmus/pull/1651


Tests for Madryetal attack, Addressing #276

Thanks Nicolas for the comments. I addressed them above.

Tests are failing on the mnist_tutorial_tf which is untouched by this PR. Looks like the atol_fac for Tensorflow=1.1.0 is too tight. Or maybe the tutorial needs better seeding.

Let's loosen the test then. The tutorials do need better seeding but unfortunately all of our efforts at making the results fully deterministic have been unsuccessful so far.

Thanks, @npapernot. Tests have passed.

Thanks Fartash!


[next-css] broken escaped characters

I'm using next-css to load external stylesheets on a next.js site and some special characters are getting broken after being processed by the plugin.
For example, I have a selector like this .\31 2u\28medium\29 which is getting compiled to .\31 2u28medium29.

These selectors are using special characters, like (->\28 or )->\29. It's not probably the best decission, but this is coming from a third party library.

The weird thing is that not all the escaped characters are broken. The \31 one is properly kept.
I guess the issue is more related with webpack's mini-css-extract-plugin, but I didn't find a workaround so far.

The issue seems to be on webpack's css-loader https://github.com/webpack-contrib/css-loader/issues/578

Apparently, by installing css-loader ^2.0, the issue is resolved.
However, it produces a new error (ValidationError: CSS Loader Invalid Options) because next-css passes the minimize option to css-loader, which has been removed in this version.
Are there any plans to release a new version of next-css which makes use of the newer version?

Hi, thanks for creating an issue. We currently recommend using https://nextjs.org/docs/basic-features/built-in-css-support as the plugins have been deprecated in favor of the built-in support.


mi-vscode detects as compilation errors when 'onCacheHit' and 'implementation' elements are not defined in Cache mediator configurations.

Description:

$title
But adding those elements with no attributes didn't show any compilation level diagnostics. So defining those can be made as optional.

Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

The latest pre-release v1.0.1 has resolved the issue. Please reopen if the problem persists.


Added JetBrains debugger to build tools

Closes https://github.com/metalbear-co/mirrord-intellij/issues/258
Fixes mirrord compatibility with Rider 2024.1

Do we need to test it doesn't break other JetBrains IDE plugins?

Hmm, nice catch. I'd be surprised, but I'll check


Cherry-pick matrix undo/redo fix to v0.27

Changes are ~80% test code and ~19% undo/redo specific.  The remaining 1% is a minor refactor to enable code reuse.

(Thanks, @vladsud!)


Enable Sentry breadcrumbs via Elastica logging

Codecov Report
Patch coverage: 24.39% and project coverage change: -6.22 :warning:

Comparison is base (9eab2c0) 85.45% compared to head (2581d38) 79.23%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #20      +/-   ##
============================================
- Coverage     85.45%   79.23%   -6.22%
- Complexity      123      134      +11
============================================
  Files            18       19       +1
  Lines           385      419      +34
============================================
+ Hits            329      332       +3
- Misses           56       87      +31

Impacted Files
Coverage Δ

src/Logging/SentryBreadcrumbLogger.php
0.00% <0.00%> (ø)

src/Client/ElasticaClient.php
100.00% <100.00%> (ø)

src/Commands/IndexCommand.php
79.41% <100.00%> (ø)

src/Exception/BaseException.php
100.00% <100.00%> (ø)

src/Index/AbstractIndex.php
95.00% <100.00%> (ø)

src/LaravelElasticaBridgeServiceProvider.php
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


set-up aws to handle nlp word embedding model & word classification requests

Using the word embeddings GloVe package and gensim, make it so that users can input custom words and get their relation to masculine vs feminine which will be used to determine score.

S3 Bucket w/ python sdk to upload our model: https://aws.amazon.com/sdk-for-python/

Current issue with reading in s3 data: https://github.com/RaRe-Technologies/gensim/issues/1851


Updated Thoughtram Blogging Articles

Added Depreciated to current Thoughtram Routing Article & Added new thoughtram Article "Routing in Angular 2 Revisited"

@mgechev this is the PR that it was adding the Victor Savkin article to, which is why I closed it for a moment 😬


Resolve an issue with ->load or ->fresh on models with different connections defaulting to parent connection when $connection is not specified

This is a followup to this post. Since i'm dumb, i wanted to avoid creating PR because there's most likely better way of fixing this. In the end though i decided to create one anyway.
Here's description of an issue with examples:
https://github.com/laravel/framework/discussions/39262

Hey there - we can't call the global configuration helper from the Eloquent model. It's also a bit scary to make this change on a patch release.
For now I recommend calling setConnection on your model explicitly if you would like to tell it what connection to use.

Hey there - we can't call the global configuration helper from the Eloquent model. It's also a bit scary to make this change on a patch release.
For now I recommend calling setConnection on your model explicitly if you would like to tell it what connection to use.

Yeah, no problem there, as i told in the message, im pretty dumb, no surprises it getting rolled back.
While i surely can fix that myself just by specifying $connection on my default models, is there any possible out of the box solution to this in the future?


Alternative implementation of nullif kernel by slicing nested buffers

Which issue does this PR close?

Closes #510.
Rationale for this change
This is an alternative implementation to #521 of the nullif kernel that works by slicing the buffers of the array depending on the data type. For most data types this can be done without copying data. The exceptions are boolean arrays (when the offset is not a multiple of 8) and list arrays because there are some assumptions that offsets start at zero.
There are several TODO still left in the code to verify the correct slicing logic for some data types. It also seems a bit strange that this slicing logic is only needed for a single kernel and I also don't like that we still need to copy for some data types.
A better design would require some larger refactorings of the current data model:

Remove the offset from ArrayData so that all slicing has to be pushed down into buffers
Add a offset field to Bitmap so that bitmaps can be sliced without copying
Also use the Bitmap as the data holder for boolean arrays

What changes are included in this PR?
I added the kernel as a separate function to make the diff easier to read, if we decide to merge this it should replace the existing nullif kernel.
The api changes since the nullif kernel now takes an ArrayRef instead of a PrimitiveArray.

@bjchambers  @alamb This is the alternative implementation I mentioned, thanks for reminding me about this topic.

Codecov Report

Merging #1499 (8e3055b) into master (c5442cf) will decrease coverage by 0.02%.
The diff coverage is 75.38%.

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   82.68%   82.66%   -0.03%
==========================================
  Files         188      188
  Lines       54361    54552     +191
==========================================
+ Hits        44951    45098     +147
- Misses       9410     9454      +44

Impacted Files
Coverage Δ

arrow/src/compute/kernels/boolean.rs
91.70% <74.19%> (-5.10%)
:arrow_down:

arrow/src/compute/util.rs
98.90% <100.00%> (ø)

parquet_derive/src/parquet_field.rs
65.75% <0.00%> (-0.46%)
:arrow_down:

arrow/src/datatypes/datatype.rs
66.40% <0.00%> (-0.40%)
:arrow_down:

arrow/src/array/transform/mod.rs
86.46% <0.00%> (-0.12%)
:arrow_down:

arrow/src/compute/kernels/length.rs
100.00% <0.00%> (ø)

parquet/src/encodings/encoding.rs
93.56% <0.00%> (+0.18%)
:arrow_up:

arrow/src/array/ord.rs
69.17% <0.00%> (+2.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5442cf...8e3055b. Read the comment docs.

@bjchambers  do you have the time / inclination to review this PR? There is now ~ 1.5 weeks until I cut the next arrow-rs release candidate -- it would be cool to include this too

@bjchambers do you have the time / inclination to review this PR? There is now ~ 1.5 weeks until I cut the next arrow-rs release candidate -- it would be cool to include this too

I can take a quick look, but my review would likely be looking at the tests / etc. I'm not familiar enough with the more complex types (List, Map, etc.) to review the code in detail.

@alamb I'm also not sure what is the best way forward. It is a lot of code just to support one kernel and it changes quite a bit how we work with Buffers. And it still does not avoid copying completely for boolean types. If these tradeoffs are ok there are also some TODOs still left:

Map types are not yet supported
The previous PR #521 has a few more test cases that could be integrated
The function needs to be renamed, the new name was only choosen to make the diff easier to read

Longer term I'd like to experiment with removing the offset from ArrayData and see if slicing could be implemented in general with a method like this.For the validity, an offset could be introduced in Bitmap so it can be sliced without copying. The open problem is then the BooleanArray, which would ideally need to contain a Bitmap instead of a Buffer for it's data which could be sliced zero-copy. But there is no way to store this data bitmap in ArrayData.

Longer term I'd like to experiment with removing the offset from ArrayData and see if slicing could be implemented in general with a method like this.For the validity, an offset could be introduced in Bitmap so it can be sliced without copying. The open problem is then the BooleanArray, which would ideally need to contain a Bitmap instead of a Buffer for it's data which could be sliced zero-copy. But there is no way to store this data bitmap in ArrayData.

I think removing the explicit offset in the ArrayData would make a significant improvement.
As you mention, however, BooleanArray / Bitmaps would end up being copied without more thought

One potential option to handle BooleanArray might be for Buffer to store the offset in terms of elements, as opposed to bytes. This would make it behave similarly to the current offset in ArrayData. We might even be able to combine this with a move to some sort of typed buffer implementation. The downside would be even more code churn...

I'm converting this to a draft as it appears to have stalled, feel free to unmark if I am mistaken

Another random thought would be to store a bit_offset on Buffer instead of a byte offset :thinking: I think this would allow removing the offset from ArrayData and a max offset of 2^56 bytes is likely sufficient for any sane workload :laughing:

Given the number of bugs associated with offsets in general I really like the idea of switching to Bytes internally (that already handles offsets) and then for bitmasks handling but_offsets specially

Closing as #2940 has been merged


Issue with languages in URL

I am trying to put in a redirect with the pattern of "^old/page1$" so that I can redirect http://www.website.com/en/old/page1 to http://www.website.com/en/new/page2.
When I set my return URL to "http://{HTTP_HOST}/new/page2", I am redirected to http://www.website.com/new/page2 instead of http://www.website.com/en/new/page2.
I am working on a multilingual site (on Sitecore version 7.2), so I am not able to hard-code the return URL to http://www.website.com/en/new/page2.
Is there any way to carry over the language from the original URL? When I put the language into the pattern to match with the URL, it doesn't work.

Sitecore removes the language from the URL ("Languages.AlwaysStripLanguage"). That's probably the reason why there is no match in patterns where language the is included.
This issue is closed without comments. I was wondering how you solved it?

I don't think this was solved.  If there is interest, I can add it as a new feature.  However,  all of my templates are shared and don't worry about language.  How would you envision this implementation?


fix: amend end-to-end tests to work with the new API (cf substra-back…

…end#613)

Please put the link of the companion PRs in the summary, and indicate which one in the "main" where e2e tests are launched with the bot


ModuleNotFoundError: No module named 'androidtv'

Hi,
I have added the Hass.io add-on, it seems to be successfully connecting to my Shield TV and now I'm trying to add the component to HA.
So I added the androidtv.py file in the correct folder and when I start HA this line of code is causing me the error:
https://github.com/hassio-addons/addon-adb/blob/c367b655d37c6c2afdcec0ab077e8bce3a4a4144/custom_components/media_player/androidtv.py#L166

ModuleNotFoundError: No module named 'androidtv'

Do you have a solution for me? Thanks in advance!

If you haven't already, try restarting Home Assistant. I've seen it happen where it takes too long to install the required package for the custom component and tries to setup the component before the package is installed, leading to the error message you got.

Thanks, it worked, although I had already tried before 🤷♂


Doesn't work

Since the big migration happened, seems like the Flatpak action is broken. See for example https://github.com/obsproject/obs-studio/actions/runs/3064364729/jobs/4947401540
GitHub Marketplace seems not to list the v4 version of the action (see here and here).

The container images didn't migrate yet. Could this be the problem?

Yes, we're slowly working on that

I noticed successful "Flatpak Bundle" runs. Is it solved?

@GeorgesStavracas would you mind updating the issue with whatever is broken today? I totally the forgot the context here

I don't fully remember it too. Let's just close this, it's not useful.


Remove allowance from configuration

Closes https://github.com/SiaFoundation/renterd/issues/1594
This PR gets rid of the Allowance and instead allows users to set the amount of funds to put into new contracts. One side effect of this is the change to price scoring that now uses the gouging settings to determine the score of a host.
The closer the price goes towards the gouging settings, the worse the score gets. The score is 0.5 at 50% of the gouging settings and increases towards 1.0 below that. Above 50% it approaches 0. The score is also composed of 3 parts for upload, download and storage pricing. So a host can still have a reasonably good score if only the upload pricing is bad but the other pricing is fine as long as it is not gouging.

Looks good to me, came as a bit of a surprise to me though, figured we wouldn't touch that since it allows the user to somewhat cap its spending.

Indeed but Nate made a good point. The gouging settings already cap the rate at which we are spending and it's better to continue spending at a capped rate to save data rather than lose files because we underestimated the spending for the period.
NOTE: A nice side effect is that the price score is now directly linked to the gouging settings. Possibly helping with host churn since we will avoid hosts too close to the gouging limits.


blast a emoji

thank you for the great package btw, I would like to know is there any way to blast an emoji, it would be great if you have any solution about this.

@cj0x39e I will add the feature in a few days.

@nosuke0926  I will add the feature in a few days.

@cj0x39e Thank you so much for your kind words and for your quick response!

@nosuke0926 I have published 0.3.2, which comes with the emoji demo and the document: How to use emoji


import tkinter as tk error

Maybe I am making some sort of rookie error but I keep getting when I go to run the python autoflashgui.py command
autoflashgui) root@kali:~/Desktop/technicolor/autoflashgui# python autoflashgui.py
Traceback (most recent call last):
File "autoflashgui.py", line 13, in
import tkinter as tk
ImportError: No module named tkinter
thanks in advance.

Install tkinter.

yeah I have tired that is there anything I have over looked ?

Make sure you have run pip install tkinter not pip3

On 14 Mar 2020, at 11:30 am, linuxhackerguy<EMAIL_ADDRESS>wrote:

yeah I have tired that is there anything I have over looked ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

yes I have done this. I cant even find it when I search for it using pip.  Sorry to trouble you

@linuxhackerguy It sounds like your Python isn't compiled or installed with Tk. For Kali, it looks you need to install the python-tk package (otherwise part of https://pkg.kali.org/pkg/python-stdlib-extensions).  If that package is already installed, then check which Python you're using, your library paths and so on.

okay I will have a look at these things. Thanks for the guidance.

okay sorted out the tkinter issue by downloading it from active state. https://www.activestate.com/products/tcl/downloads/


Update vmware-fusion.rb

Add zap for /Library/Logs/VMware USB Arbitrator Service.log and others

Please fill out the template in future.


Improvements to github-backed example from dogfooding in OpenSpending

Related to https://github.com/datopian/portaljs/issues/856
Inbox
Followed instructions at: https://github.com/datopian/portaljs/tree/main/examples/github-backed-catalog

There are warnings on the console after running the project for the first time ("Warning: Each child in a list should have a unique "key" prop.") These only happen when you put something invalid, since i fixed that they no longer appear
If no README is set the rest of the project fails FIXED
No exception handling, after adding an invalid repo I had to figure out why the index was looking weird (empty rows) FIXED It now throws an error if it cant access the repo
After adding the os-data/gb-country-regional-analysis I got the following error:

. To fix this we have to check if readme is defined before using split().  If the README didn't change, the information will be misleading, and if there's no README.md file in the repo then it's not going to be able to calculate last updated. WONTFIX, The reason for that is that we can have multiple datasets in a single repo, the original example was intended to use with the 538 datasets
Can we install prettier on this example? DONE
Had the following error with one of the datasets:{
  owner: 'os-data',
  branch: 'main',
  repo: 'state-of-minas-gerais-brazil-planned-budget',
  files: [ 'data/__os_imported__br-mg-ppagloc.csv' ]
}
RequestError [HttpError]: This endpoint can only return blobs smaller than 100 MB in size. The requested blob is too large to fetch via the API, but you can always clone the repository via Git to obtain it.: {"resource":"Blob","field":"data","code":"too_large"}
``` **WONTFIX  That cant be fixed, only thing that i did was make the error clearer**

_app.tsx is not using NextSeo FIXED
The example does not support repos with datapackage.json out of the box WONTFIX, This is intended to be the simplest of examples

FIXED


iOS: Timeline context menu should have “Mark Above as Read” and “Mark Below as Read”

These should replace “Mark Older as Read.” And they should do what they say on the tin. (They should pay attention to the current sort order. “Above” could be mean older or newer, depending.)

I announced in the Slack room that I would be happy to work on this. Just leaving a comment so I could get the ticket assigned to me, if needed.

@brentsimmons there isn't a keyboard shortcut for "Mark Above as Read".  What key should we assign that command to?

cmd-ctrl-K


Install-Module -Name Az.BootStrapper -Force -AllowPrerelease

When executing this command, the following error message is received:
`PackageManagement\Install-Package : No match was found for the specified search criteria and module name
'Az.BootStrapper'. Try Get-PSRepository to see all available registered module repositories.
At C:\Program Files\WindowsPowerShell\Modules\PowerShellGet\2.2.5\PSModule.psm1:9711 char:34

... talledPackages = PackageManagement\Install-Package @PSBoundParameters

                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : ObjectNotFound: (Microsoft.Power....InstallPackage:InstallPackage) [Install-Pa
ckage], Exception
FullyQualifiedErrorId : NoMatchFoundForCriteria,Microsoft.PowerShell.PackageManagement.Cmdlets.Install
Package`

This is possible due to another issue that I filed:
https://github.com/MicrosoftDocs/azure-stack-docs/issues/1240

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52c7ec8b-634f-6b95-7ce1-c38d55b12c23
Version Independent ID: 8cc3a38e-0bbc-71b4-2c37-fc6231bb540d
Content: Install PowerShell Az module for Azure Stack Hub - Azure Stack Hub
Content Source: azure-stack/operator/powershell-install-az-module.md
Service: azure-stack
Sub-service: azure-stack-hub
GitHub Login: @mattbriggs
Microsoft Alias: mabrigg

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for the feedback! We are currently investigating and will update you shortly.

@aricbernard I am not aware of any current Issues with this installation. Please verify that you meet the prerequisites listed in this doc, and that the computer has access to outbound internet.
If you are still having this issue, your best bet is to work with CSS, or continue with the offline installation instructions.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@aricbernard I am not aware of any current Issues with this installation. Please verify that you meet the prerequisites listed in this doc, and that the computer has access to outbound internet.
If you are still having this issue, your best bet is to work with CSS, or continue with the offline installation instructions.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Identifiers validation failed for dataset NCSM Non-molluscan Invertebrates Collection

Identifier validation failed for the dataset NCSM Non-molluscan Invertebrates Collection:

Crawler attempt: 297
Publishing organization: North Carolina State Museum of Natural Sciences
Publishing country: UNITED_STATES
Installation: IPT - Hosted by VertNet
Number of occurrences indexed for this dataset at the time of the issue: 12497
Cause: GBIF ID problems exceed 50% threshold: 100% duplicates; 31878 total records; 31878 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3721005/step

New IDs sample:

Old IDs sample:

7560E525-0E60-4A01-B2D7-1095AB301706
E844FB5C-8AA8-4F9C-B44C-2FD1A81A6FCD
C3B202C8-8D2F-4EE9-8EF4-B4142F2C78AA
DF437BA0-C7B6-4706-A344-8D24EA4F5FB1
B9E3D645-7661-4FAC-BD5E-5C16DAA7466C
9ED41CED-F1D7-43E8-8DE2-131ADCE64AD5
8A4315BE-AE7F-4533-BA97-9A30217F3B43
07C53B51-B5F5-47FA-8C7E-45DAE2FE2641
0C0774BC-9D4D-4C63-8ABE-9D832C36691A
0D631A71-C037-4F81-AEC4-1961E97D1416

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the NCSM Non-molluscan Invertebrates Collection : https://doi.org/10.36102/dwc.8.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset NCSM Non-molluscan Invertebrates Collection:

Crawler attempt: 298
Publishing organization: North Carolina State Museum of Natural Sciences
Publishing country: UNITED_STATES
Installation: IPT - Hosted by VertNet
Number of occurrences indexed for this dataset at the time of the issue: 12497
Cause: GBIF ID problems exceed 50% threshold: 61% duplicates; 31878 total records; 19383 absent records
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3725297/step

New IDs sample:

cc9d651f-2f05-43bd-b3b6-bdb6dc1db12a
517b8bda-3b5e-4326-8a94-61b48b00a3ac
d07cfe9b-f70a-4b00-8b98-512f83b6ebb2
169119b0-0180-4bf0-ad5c-4216f15e55e9
ea8a83c9-afb2-4dc5-935e-184c5b932ec3
13781514-911e-44e4-ada7-d10d9068a95b
edfd42b9-7bd6-44e4-9963-7dcd5813cb14
5f86a85b-1bcb-4794-b146-8ddfd0865e3b
03eab738-daed-461b-93a4-7d096d0a9791
79011f54-ad74-4135-ac25-de5658d2907b

Old IDs sample:

7560E525-0E60-4A01-B2D7-1095AB301706
E844FB5C-8AA8-4F9C-B44C-2FD1A81A6FCD
C3B202C8-8D2F-4EE9-8EF4-B4142F2C78AA
DF437BA0-C7B6-4706-A344-8D24EA4F5FB1
B9E3D645-7661-4FAC-BD5E-5C16DAA7466C
9ED41CED-F1D7-43E8-8DE2-131ADCE64AD5
8A4315BE-AE7F-4533-BA97-9A30217F3B43
07C53B51-B5F5-47FA-8C7E-45DAE2FE2641
0C0774BC-9D4D-4C63-8ABE-9D832C36691A
0D631A71-C037-4F81-AEC4-1961E97D1416

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the NCSM Non-molluscan Invertebrates Collection : https://doi.org/10.36102/dwc.8.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

The IPT administrator contacted us. The dataset contained the mapping of old to new identifiers in the resourceRelationship extension. I migrated the identifier. The dataset got stopped again but this time because of the huge number of records added. I resumed the dataset ingestion.


VSCode eslint not showing warnings from "plugin:" rules

I'm migrating from TSLint to ESLint in a React CRA project.
Using eslint 6.6.0.
I have the following eslint config
{   "root": true,   "parser": "@typescript-eslint/parser",   "plugins": ["@typescript-eslint"],   "extends": [     "eslint:recommended",     "plugin:@typescript-eslint/recommended",     "plugin:react/recommended",     "react-app",     "prettier"   ],   "rules": {     "no-console": "warn"   } }
As per CRA docs, I set the following variable in the .env file
EXTEND_ESLINT=true
Due to "plugin:@typescript-eslint/recommended" i get the following warning on build
./src/services/usePromise.ts   Line 30:12:  Missing return type on function  @typescript-eslint/explicit-function-return-type
But VSCode does not show the warning in the editor

If I then manually add the rule in .eslintrc such
   ... "rules": {     "no-console": "warn",     "@typescript-eslint/explicit-function-return-type": "warn"   }
Then VSCode picks up and displays the warning in the editor

It looks like, while the rules coming from the typescript-eslint plugin are picked up by eslint when linting from the command line, VSCode eslint ignores the rules coming from the plugin.
If I remove "plugin:@typescript-eslint/recommended" from "extends" array, then the warning does not show up in the command line on build, so I'm quite sure that that is the rule's source.

@razvanmandache can you please provide me with a GitHub repository I can clone that demos what you are experiencing.

Hi @dbaeumer
Thanks for taking an interest in this.
I created a new CRA project in this repo here https://github.com/razvanmandache/vscode-eslint-test
Had some trouble reproducing the issue, but managed to do in the end.
I started by copying the relevant config (e.g. .eslintrc) files and the relevant packages (e.g. eslint, typescript-eslint, etc.) from the project I encountered the issue in to the new CRA project. I installed the packages, ran the dev-server, but I did not experience the same issue again i.e. I did not get the related warning in the console . It seem that what I initially copied (in this 2nd commit 964ee08) was not enough to cause an issue.
I then copied over the entire contents of package.json from the main project, reinstalled all the packages (after deleting package.lock.json and node_modules) and only then the warning started showing up.
I thought that whatever changed in this 3rd commit here de0941c has something to do with it.
I removed some irrelevant packages in a 4th commit 9df93ec, reinstall packages, ran the dev server and again the warning message was there.
Just to double check, I checked out the last commit where the issue was not present (meaning this 2nd commit 964ee08, reinstalled the packages as before, but unfortunately when I ran the dev server, I did get the warning message again.
In neither case, when the warning was present in the console or not, the warning did not show up as a squiggly yellow line in VSCode text editor. I'm now starting to think that's more likely a problem with either my setup or one of the eslint plugin, then with the eslint extension, but you can of course try it out for yourself too if you want.

Actually, I cloned the repository and I don't see any errors when executing eslint in the terminal using ./node_modules/.bin/eslint src/usePromise.ts. In general the extension behaves as eslint executed on the command line. Can you please ensure that executing eslint in the terminal works correctly. If you still don't see an error in VS Code, please ping with steps to reproduce.

Thanks for testing this out.
I have tested myself too and it does work as expected when running eslint from command line.
Seems that it's most likely an issue with how CRA handles the eslint config and not with vscode eslint extension.

@razvanmandache how did you run ESLint in the terminal.

I ran it as you described with "/node_modules/.bin/eslint src/usePromise.ts".
I was confirming that, just like yourself, I did not get any warnings or errors when running from the command line.
Sorry if my phrasing wasn't clear.
The vscode eslint extension seems to be handling the eslint config correctly i.e. produces the same results as when linting from the command line.

OK. That makes sense then. I will close the issue. Please ping if you still think there is something that needs to be done in the extension itself.


Add support for different regions

AWS region is hard coded to us-east-1. Lambda and DynamoDB support other regions, such as us-west-2.
Allow the developer to set the region for deployment, either through ~/.aws/config (get's generates by aws configure) or fluct parameter in top-level package.json
https://github.com/r7kamura/fluct/search?q=us-east-1

Thanks @axelgustav!  I agree with you that we should make it able to specify the region in package.json. I'm going to support that in the future, but I'm currently using only us-east-1 region in my projects. If anyone sends a pull request, I'm willing to merge it :pray:


feat: add dev msg if too long OG/Twitter descriptions

Issue or need
Open Graph and Twitter Cards description property are recommended not to be excessively long. It could be nice to inform developers when the maximum recommended size is exceeded

Proposed changes
Warn about excessive length for Open Graph / Twitter Card too long descriptions when running on development
Refactors to introduce a common utility for formatting dev messages around
Skips coverage in the new functions given the issue with coverage reporting & source maps

Quick reminders

🤝 I will follow Code of Conduct
✅ No existing pull request already does almost same changes
👁 Contributing docs are something I've taken a look at
📝 Commit messages convention has been followed
💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
⚙ API Report has been updated if API surface is altered.

#747  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


Fix hardcoded rpm dependencies for armv7hl and aarch64

Related to RPM part of https://github.com/microsoft/vscode/issues/106473

Oh I see, that's how you encode it for RPM! Thanks @psgreco, will trigger some builds and give it a try.

@psgreco I just realized you're Pablo from https://forums.centos.org/viewtopic.php?f=55&t=73495&sid=efd80c413274e6e262c64bdd2812de74&start=20. Thanks for your work there, I have SD cards with CentOS 7 and 8 for RPi4, all thanks to you!
The RPMs produced now seem much better but still hit some roadblocks when installing. Here's the output on my Pi with CentOS 8:
[joao@localhost Downloads]$ sudo yum localinstall code-insiders-1.52.0-1606210971.el7.aarch64.rpm
Last metadata expiration check: 0:12:56 ago on Tue 24 Nov 2020 03:41:09 PM UTC.
Error:
 Problem: conflicting requests
  - nothing provides libc.so.6(GLIBC_2.11)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.2.5)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.3)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.3.2)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.3.4)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.4)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.6)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.7)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.9)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libm.so.6(GLIBC_2.2.5)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libpthread.so.0(GLIBC_2.2.5)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libpthread.so.0(GLIBC_2.3.2)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libpthread.so.0(GLIBC_2.3.3)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Any thoughts?

@psgreco I just realized you're Pablo from https://forums.centos.org/viewtopic.php?f=55&t=73495&sid=efd80c413274e6e262c64bdd2812de74&start=20. Thanks for your work there, I have SD cards with CentOS 7 and 8 for RPi4, all thanks to you!

Hehe, same one, happy to help ;)

The RPMs produced now seem much better but still hit some roadblocks when installing. Here's the output on my Pi with CentOS 8:
[joao@localhost Downloads]$ sudo yum localinstall code-insiders-1.52.0-1606210971.el7.aarch64.rpm
Last metadata expiration check: 0:12:56 ago on Tue 24 Nov 2020 03:41:09 PM UTC.
Error:
 Problem: conflicting requests
  - nothing provides libc.so.6(GLIBC_2.11)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.2.5)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.3)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.3.2)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.3.4)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.4)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.6)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.7)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libc.so.6(GLIBC_2.9)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libm.so.6(GLIBC_2.2.5)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libpthread.so.0(GLIBC_2.2.5)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libpthread.so.0(GLIBC_2.3.2)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
  - nothing provides libpthread.so.0(GLIBC_2.3.3)(64bit) needed by code-insiders-1.52.0-1606210971.el7.aarch64
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Yeah, that looks much better, TBH, my patch was a complete shot in the dark so we could get to this point, the real failures

Any thoughts?

Is there a simple way for me to build code here So I can get you a final version? or just point me to the version you're testing right now and I can take another look

Absolutely, here's a download link for the build tarball: https://az764295.vo.msecnd.net/insider/5987e4076572afbac347b1ec7946ecc59ecaf682/code-insider-arm64-1606240510.tar.gz
Thanks a lot for your help.

Continues in https://github.com/microsoft/vscode/pull/111253


Publish 1.6.0 release version

I think this plugin updated to 1.6.0. But repository hasn't 1.6.0 release.
Please publishing version 1.6.0.
Thank you for useful plugin!

I created a fork repository as a temporary solution for using v1.6.0 on npm.

looks like 1.6 isn't published anywhere from what I see, but its advertised on the website.

please publish v1.6.0 to npm repository.

@dolce can you please publish 1.6.0 to npm

Any updates about this guys?


Request: adjust volume with wheel or right mouse

A feature that Magic Actions for Youtube has, which is very handy...:

Instant control over volume by scrolling mouse wheel! (or even better right mouse button scrub!! =))
OSD on-screen display  for volume (bar or numbers)

simply right klick and scrubs left or right to adjust volume ...its so handy
i know its a biggie but that would make YTC divine !! ;)

Duplicate of #90


Mailer Module Cleanup and improvement

I have some problems sending e-mails with gitea and had a look at the mailer code.
I noticed following points:

The code should be split up into multiple files to improve readability.
For each send mail request a new connection is established (no keep-alive).
The SMTP mail handling code is an old duplicate from gomail. Use the well-tested gomail implementation instead.
No support for multiple parallel mail routines.
SendAsync starts a new goroutine on every call. We should think about increasing the channel size and drop mail requests if flooded with requests... This requires discussion.
Sendmail code has to be cleaned up (Error handling).

This initial commit is a work in progress to improve the mailer code. Currently done:

SMTP keep-alive
Using gomail for SMTP handling
Multiple parallel mail routines
Initial cleanup and split up into multiple files.
Added several TODOs.
Sendmail code has been adjusted.

Any thoughts or ideas? Thanks!

 The only thing which has to be discussed is if the SendAsync function should create on each call a new goroutine... However this can be postponed into another pull request...

Thanks. I implemented your change requests and removed some TODOs. There is a new vendor package, which is required as a reset timer. It ensures a fixed timer Reset behavior. Any other thoughts?

@r0l1 can you please rebase and resolve conflicts?

For now moving this to 1.4 milestone

@r0l1 would you be able to resolve conflicts? If not please comment here, and a maintainer would be able to take over this PR.

@techknowlogick If you'll help with testing, I'll have a look at it later on and will resolve the issues. Otherwise I am open to give this PR to another maintainer.


Use Xcode legacy build system for iOS builds (#21901)

Xcode 10 introduces a new build system which includes stricter checks on
duplicate build outputs.
When plugins are in use, there are two competing build actions that copy
Flutter.framework into the build application Frameworks directory:

The Embed Frameworks build phase for the Runner project
The [CP] Embed Pods Frameworks build phase that pod install creates
in the project.

Item (1) is there to ensure the framework is copied into the built app
in the case where there are no plugins (and therefore no CocoaPods
integration in the Xcode project). Item (2) is there because Flutter's
podspec declares Flutter.framework as a vended_framework, and CocoaPods
automatically adds a copy step for each such vended_framework in the
transitive closure of CocoaPods dependencies.
As an immediate fix, we opt back into the build system used by Xcode 9
and earlier. Longer term, we need to update our templates and
flutter_tools to correctly handle this situation.
See: https://github.com/flutter/flutter/issues/20685

Note this is a re-land of #21901, but with the addition that the workspace setting is only applied when the project has a workspace. The previous patch broke the devicelab complex scroll benchmark, which does not include a workspace.


Using custom names for identical folder names in workspace confuses search

Type: Bug
I have to maintain several projects both on git and SVN but they are separate copies. I have added both copies to the workspace and then manually edited the "name" field in the workspace file to add the respective location e.g. "project (git)" and "project (SVN)". Now when I try to perform a search (Find in Folder) of one of these projects I will get search results for any and all files from all projects across the workspace. It seems the search can not handle the added parentheses in the name field and instead shows all search results across all projects in the workspace.
If changing the repo "name" manually isn't intended then please consider this a feature request to support this.

VS Code version: Code 1.79.0 (b380da4ef1ee00e224a15c1d4d9793e27c2b6302, 2023-06-07T14:26:35.552Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz (12 x 2712)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.61GB (5.50GB free)

Process Argv
--crash-reporter-id e4090bd3-edd6-49af-8d84-8d1687ea6c20

Screen Reader
no

VM
0%

Extensions (22)

Extension
Author (truncated)
Version

asciidoctor-vscode
asc
2.9.8

xml
Dot
2.5.1

auto-close-tag
for
0.5.14

selected-lines-count
gur
1.4.0

output-colorizer
IBM
0.1.2

code-eol
jef
1.0.12

endwise
kai
1.5.1

vsc-python-indent
Kev
1.18.0

ruby-symbols
mig
0.1.8

pylint
ms-
2023.4.0

python
ms-
2023.10.0

vscode-pylance
ms-
2023.6.10

cpptools
ms-
1.16.0

material-icon-theme
PKi
4.28.0

synthwave-vscode
Rob
0.1.15

multi-command
ryu
1.6.0

code-spell-checker
str
2.20.5

code-spell-checker-german
str
2.2.1

open-in-browser
tec
2.0.0

pdf
tom
1.2.2

gitblame
wad
10.2.0

vscode-ruby
win
0.28.0

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931:30280409
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30610679
2e4cg342:30602488
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
03d35959:30757346
24365598:30736109
pythonfmttext:30731395
pythoncmv:30756943
fixhidewlkth:30730051
showsbindicator:30760979
pythongtdpathcf:30739705
dh2dc718:30763024
pythonnosm12tcf:30757130

Does it behave better if you avoid all types of bracket in the folder name override?

Does it behave better if you avoid all types of bracket in the folder name override?

Yes, if I just use a dash as a separator it shows only results from the selected folder.

#166318 fixed Find in Folder in cases where the folder name contains some special characters, but not the ( and ) brackets.

https://github.com/microsoft/vscode/pull/166318 should have already been released, but I see that this persists in the current latest.

This is actually a duplicate of https://github.com/microsoft/vscode/issues/175063


bgCol should be global

#342

gs <- gsplot() %>%
    bgCol('lightgrey') %>%
    points(1,1)
gs

puts bgCol in gs. Should it be in gs$global?

I think the same applies to title, which is also not in global (yet)


Radiation collector sprite update

About the PR

This PR addressed one of the requested features in #20953. Namely, it updates the radiation collector so that it displays a plasma tank when one is attached. It also includes a colored pressure gauge for the plasma tank as well
As part of these changes, the plasma gas in the tank now simply depletes with use, rather than being converted to tritium
Why / Balance

The changes to the sprites were made so that it is easier to tell the status of the collector at a glance. The conversion of the plasma gas to tritium was removed because otherwise the pressure in the tank would not change. I considered making the gauge sensitive to plasma gas pressure only, rather than all gases, but this would not be consistent with how other atmos devices work. Plus emptying the tanks of tritium so you can fill them with more plasma was a dull chore
Technical details

N/A
Media

Demonstration of how the new sprites look in action

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A
Changelog

:cl:

tweak: The radiation collector has been updated to provide better visual feedback on its status

A good minor change i like it


fix arguments for suiteThreadPoolSize option

Context
In this pull request, we added the ability to change the testng suiteThreadPoolSize option through Gradle. After the release of 8.9-rc1, I noticed that the ability to change this option is present, but it always throws the exception The version of TestNG used does not support setting thread pool size. regardless of which version of TestNG is installed. I noticed that there was another pull request https://github.com/gradle/gradle/pull/29470 for this feature, after which, probably, suiteThreadPoolSize stopped working. I conducted a small investigation and realized that the problem lies in the types passed to the setSuiteThreadPoolSize() method in TestNGTestClassProcessor: it should receive Integer, not int. In the case of int, the exception I mentioned at the beginning is thrown, which is entirely fair in such a case. I didn’t notice this during the development of the first iteration (although at that time it worked correctly with int, which is strange), so I’m coming back with a fix and an additional test to cover the positive usage scenario.
Contributor Checklist

[ ] Review Contribution Guidelines.
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
[ ] Provide unit tests (under <subproject>/src/test) to verify logic.
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes.
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck.
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test and merge

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build


Spotify (Independent Publisher)

When submitting a connector, please check the following conditions for your PR to ensure a smooth certification process.

[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[x] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[x] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[x] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[x] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Woo!! Go Daniel! Thank you for submitting the Spotify connector. Can't wait for us to take a look! :)

[[certify-connector]]


Changes required to compile with new Asio executors model

#refs 1994

Remaining MSVC issues may be because I do not currently enable BOOST_ASIO_HAS_WORKING_EXPRESSION_SFINAE for any version of MSVC. (I just tried enabling it for a Visual Studio 2019 test runner, but it still triggers errors. They are different errors to earlier versions of MSVC though, so there may be workarounds.)
For maximum portability you may need to define the relevant traits, as described in https://github.com/boostorg/beast/pull/1994#issuecomment-651123446.

Remaining MSVC issues may be because I do not currently enable BOOST_ASIO_HAS_WORKING_EXPRESSION_SFINAE for any version of MSVC. (I just tried enabling it for a Visual Studio 2019 test runner, but it still triggers errors. They are different errors to earlier versions of MSVC though, so there may be workarounds.)
For maximum portability you may need to define the relevant traits, as described in #1994 (comment).

@chriskohlhoff Just to be clear, the errors seen in MSVC are when compiling vanilla asio types, not a custom executor type.

Example:
.\b2 variant=release cxxstd=14 toolset=msvc define=BOOST_ASIO_HAS_WORKING_EXPRESSION_SFINAE  -q libs/beast/test

output:
...
    call "bin.v2\standalone\msvc\msvc-14.2\msvc-setup.bat"  >nul
 cl /Zm800 -nologo @"bin.v2\libs\beast\test\beast\core.test\msvc-14.2\release\cxxstd-14-iso\threadapi-win32\threading-multi\core.obj.rsp"

...failed compile-c-c++ bin.v2\libs\beast\test\beast\core.test\msvc-14.2\release\cxxstd-14-iso\threadapi-win32\threading-multi\core.obj...
compile-c-c++ bin.v2\libs\beast\test\beast\http.test\msvc-14.2\release\cxxstd-14-iso\threadapi-win32\threading-multi\http.obj
http.cpp
.\boost/asio/execution/blocking.hpp(364): error C2027: use of undefined type 'boost::asio::execution::detail::blocking::possibly_t<0>'
.\boost/asio/execution/blocking.hpp(209): note: see declaration of 'boost::asio::execution::detail::blocking::possibly_t<0>'
.\boost/asio/execution/blocking.hpp(317): note: see reference to class template instantiation 'boost::asio::execution::detail::blocking_t<0>' being compiled
.\boost/asio/execution/blocking.hpp(374): note: see reference to class template instantiation 'boost::asio::execution::detail::blocking_t<I>' being compiled
.\boost/asio/execution/blocking.hpp(365): error C2027: use of undefined type 'boost::asio::execution::detail::blocking::always_t<0>'
.\boost/asio/execution/blocking.hpp(210): note: see declaration of 'boost::asio::execution::detail::blocking::always_t<0>'
.\boost/asio/execution/blocking.hpp(366): error C2027: use of undefined type 'boost::asio::execution::detail::blocking::never_t<0>'
.\boost/asio/execution/blocking.hpp(211): note: see declaration of 'boost::asio::execution::detail::blocking::never_t<0>'
.\boost/asio/execution/blocking_adaptation.hpp(298): error C2027: use of undefined type 'boost::asio::execution::detail::blocking_adaptation::disallowed_t<0>'
.\boost/asio/execution/blocking_adaptation.hpp(171): note: see declaration of 'boost::asio::execution::detail::blocking_adaptation::disallowed_t<0>'
.\boost/asio/execution/blocking_adaptation.hpp(268): note: see reference to class template instantiation 'boost::asio::execution::detail::blocking_adaptation_t<0>' being compiled
.\boost/asio/execution/blocking_adaptation.hpp(307): note: see reference to class template instantiation 'boost::asio::execution::detail::blocking_adaptation_t<I>' being compiled
.\boost/asio/execution/blocking_adaptation.hpp(299): error C2027: use of undefined type 'boost::asio::execution::detail::blocking_adaptation::allowed_t<0>'
.\boost/asio/execution/blocking_adaptation.hpp(172): note: see declaration of 'boost::asio::execution::detail::blocking_adaptation::allowed_t<0>'
.\boost/asio/execution/bulk_guarantee.hpp(369): error C2027: use of undefined type 'boost::asio::execution::detail::bulk_guarantee::unsequenced_t<0>'
.\boost/asio/execution/bulk_guarantee.hpp(210): note: see declaration of 'boost::asio::execution::detail::bulk_guarantee::unsequenced_t<0>'
.\boost/asio/execution/bulk_guarantee.hpp(320): note: see reference to class template instantiation 'boost::asio::execution::detail::bulk_guarantee_t<0>' being compiled
.\boost/asio/execution/bulk_guarantee.hpp(379): note: see reference to class template instantiation 'boost::asio::execution::detail::bulk_guarantee_t<I>' being compiled
.\boost/asio/execution/bulk_guarantee.hpp(370): error C2027: use of undefined type 'boost::asio::execution::detail::bulk_guarantee::sequenced_t<0>'
.\boost/asio/execution/bulk_guarantee.hpp(211): note: see declaration of 'boost::asio::execution::detail::bulk_guarantee::sequenced_t<0>'
.\boost/asio/execution/bulk_guarantee.hpp(371): error C2027: use of undefined type 'boost::asio::execution::detail::bulk_guarantee::parallel_t<0>'
.\boost/asio/execution/bulk_guarantee.hpp(212): note: see declaration of 'boost::asio::execution::detail::bulk_guarantee

-- More  --
...etc...

This source file does not define any user-defined executors.

@chriskohlhoff here are other command lines that produce failures:
./b2  variant=release address-model=32 toolset=msvc-14.2  libs/beast/example
./b2  cxxstd=11 variant=release address-model=32 toolset=msvc-14.2  libs/beast/example
./b2  cxxstd=14 variant=release address-model=32 toolset=msvc-14.2  libs/beast/example
./b2  cxxstd=17 variant=release address-model=32 toolset=msvc-14.2  libs/beast/example
./b2  cxxstd=latest variant=release address-model=32 toolset=msvc-14.2  libs/beast/example

Can you please post the contents of this file:

bin.v2\libs\beast\test\beast\core.test\msvc-14.2\release\cxxstd-14-iso\threadapi-win32\threading-multi\core.obj.rsp

as it contains the actual command line options for the compiler.

Can you please post the contents of this file:
bin.v2\libs\beast\test\beast\core.test\msvc-14.2\release\cxxstd-14-iso\threadapi-win32\threading-multi\core.obj.rsp
as it contains the actual command line options for the compiler.

"libs\beast\test\lib_test.cpp" -Fo"bin.v2\libs\beast\test\msvc-14.2\release\cxxstd-14-iso\link-static\threading-multi\lib_test.obj"    -TP /O2 /Ob2 /W3 /GR /MD /Zc:forScope /Zc:wchar_t /Zc:inline /Gw /Zc:throwingNew /wd4675 /EHs /std:c++14 -c
-DBOOST_ALL_NO_LIB=1
-DBOOST_BEAST_ALLOW_DEPRECATED
-DBOOST_BEAST_SEPARATE_COMPILATION
-DNDEBUG
"-I."

For some reason that response file above is incomplete. Mine looks like:
"example\http\client\async\http_client_async.cpp" -Fo"..\..\bin.v2\libs\beast\example\http\client\async\msvc-14.2\release\cxxstd-14-iso\threading-multi\http_client_async.obj"    -TP /O2 /Ob2 /W3 /GR /MD /Zc:forScope /Zc:wchar_t /Zc:inline /Gw /Zc:throwingNew /wd4675 /EHs /std:c++14 /Ob2 /Oi /Ot /bigobj /permissive- -c
-DBOOST_ALL_NO_LIB=1
-DBOOST_ASIO_DISABLE_BOOST_ARRAY=1
-DBOOST_ASIO_DISABLE_BOOST_BIND=1
-DBOOST_ASIO_DISABLE_BOOST_DATE_TIME=1
-DBOOST_ASIO_DISABLE_BOOST_REGEX=1
-DBOOST_ASIO_NO_DEPRECATED=1
-DBOOST_ASIO_SEPARATE_COMPILATION
-DBOOST_BEAST_ALLOW_DEPRECATED
-DBOOST_BEAST_SEPARATE_COMPILATION
-DBOOST_COROUTINES_NO_DEPRECATION_WARNING=1
-DNDEBUG
-D_CRT_SECURE_NO_WARNINGS=1
-D_SCL_SECURE_NO_WARNINGS=1
-D_SILENCE_CXX17_ADAPTOR_TYPEDEFS_DEPRECATION_WARNING
-D_SILENCE_CXX17_ALLOCATOR_VOID_DEPRECATION_WARNING
-D_WIN32_WINNT=0x0601
"-I."
"-I..\.."

The problem only occurs with the /permissive- option set. Unfortunately the errors don't really explain why this mode doesn't like the code, but perhaps you can disable this option for now.

EDIT: I can enable a workaround in asio/detail/config.hpp to fix it. This workaround is already used for gcc <= 7.

Oh. Thank goodness. From the documentation at https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=vs-2019:

By default, the /permissive- option is set in new projects created by Visual Studio 2017 version 15.5 and later versions. It's not set by default in earlier versions. When the option is set, the compiler generates diagnostic errors or warnings when non-standard language constructs are detected in your code. These constructs include some common bugs in pre-C++11 code.

Given the vast number of people who use the Visual studio IDEs I don't think requiring the disabling of this option is possible, let alone desirable.
I'll test the latest commits and get back to you.

@chriskohlhoff Good news. It looks like it's building.
FYI: Loads of warnings about very long template names (presumably unavoidable with all the new property code?)
And you may want to look check this:
.\boost/asio/detail/impl/scheduler.ipp(365): warning C4267: '+=': conversion from 'size_t' to 'long', possible loss of data
compile-c-c++ bin.v2\libs\chrono\build\msvc-14.0\release\address-model-64\cxxstd-14-iso\threading-multi\thread_clock.obj
thread_clock.cpp

@chriskohlhoff ok all looking good except for MSVC being unable to find specialisations for our custom executor. I have your instructions on how to fix that. Will report back when done.

@chriskohlhoff error:
C:\Users\hodge\github\boostorg\boost\boost/asio/execution/detail/as_invocable.hpp(80): error C2143: syntax error: missing ';' before '}'

Looks like the second #ifdef is one line too low:
#if !defined(BOOST_ASIO_NO_EXCEPTIONS)
    try
    {
#endif // !defined(BOOST_ASIO_NO_EXCEPTIONS)
      execution::set_value(BOOST_ASIO_MOVE_CAST(Receiver)(*receiver_));
      receiver_ = 0;
    }     //// <<<<==== spurious closing brace here
#if !defined(BOOST_ASIO_NO_EXCEPTIONS)
...

https://github.com/boostorg/asio/pull/360

@chriskohlhoff still getting errors in msvc-14.1 and above
compile-c-c++ bin.v2\libs\beast\msvc-14.1\release\address-model-64\cxxstd-17-iso\link-static\threading-multi\test\lib_asio.obj
lib_asio.cpp
.\boost/asio/execution/blocking.hpp(377): error C2027: use of undefined type 'boost::asio::execution::detail::blocking::possibly_t<0>'
.\boost/asio/execution/blocking.hpp(222): note: see declaration of 'boost::asio::execution::detail::blocking::possibly_t<0>'
.\boost/asio/execution/blocking.hpp(330): note: see reference to class template instantiation 'boost::asio::execution::detail::blocking_t<0>' being compiled
.\boost/asio/execution/blocking.hpp(387): note: see reference to class template instantiation 'boost::asio::execution::detail::blocking_t<I>' being compiled
.\boost/asio/execution/blocking.hpp(378): error C2027: use of undefined type 'boost::asio::execution::detail::blocking::always_t<0>'
.\boost/asio/execution/blocking.hpp(223): note: see declaration of 'boost::asio::execution::detail::blocking::always_t<0>'

N.B. I haven't merged these fixes into the boost source tree yet.

Now on develop.

@chriskohlhoff Tests passed for the "allow net-ts executors" case. Will get this PR tidied up and then work on the NO_TS_EXECUTORS version.
Many thanks for your herculean efforts.

@chriskohlhoff bug in co_spawn:
In file included from /home/rhodges/github/boostorg/boost/libs/beast/example/http/server/fast/http_server_fast.cpp:21:
In file included from /home/rhodges/github/boostorg/boost/boost/asio.hpp:47:
In file included from /home/rhodges/github/boostorg/boost/boost/asio/co_spawn.hpp:469:
/home/rhodges/github/boostorg/boost/boost/asio/impl/co_spawn.hpp:60:16: error: no template named 'executor_work_guard'; did you mean 'beast::detail::execution_work_guard'?
    >::type> : executor_work_guard<Executor>
               ^
/home/rhodges/github/boostorg/boost/libs/beast/include/boost/beast/core/detail/work_guard.hpp:34:8: note: 'beast::detail::execution_work_guard' declared here
struct execution_work_guard
       ^

clang-9++ -std=c++20 -fcoroutines-ts -DBOOST_ASIO_NO_TS_EXECUTORS

The code in boost/beast/websocket/impl/stream_impl.hpp only works with the standard executors. A change like the following fixes it:
--- a/include/boost/beast/websocket/impl/stream_impl.hpp
+++ b/include/boost/beast/websocket/impl/stream_impl.hpp
@@ -128,8 +128,8 @@ struct stream<NextLayer, deflateSupported>::impl_type
             boost::empty_init_t{},
             std::forward<Args>(args)...)
         , detail::service::impl_type(
-            net::query(this->boost::empty_value<NextLayer>::get().get_executor(),
-                net::execution::context))
+            this->get_context(
+                this->boost::empty_value<NextLayer>::get().get_executor()))
         , timer(this->boost::empty_value<NextLayer>::get().get_executor())
     {
         timeout_opt.handshake_timeout = none();
@@ -477,6 +477,22 @@ struct stream<NextLayer, deflateSupported>::impl_type
     }

 private:
+    template<class Executor>
+    static net::execution_context&
+    get_context(Executor const& ex,
+        typename std::enable_if< net::execution::is_executor<Executor>::value >::type* = 0)
+    {
+        return net::query(ex, net::execution::context);
+    }
+
+    template<class Executor>
+    static net::execution_context&
+    get_context(Executor const& ex,
+        typename std::enable_if< !net::execution::is_executor<Executor>::value >::type* = 0)
+    {
+        return ex.context();
+    }
+
     bool
     is_timer_set() const
     {

You might consider adding a build with BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT defined to your test matrix, as it will help catch problems like this. (This define gives users the option of 100% backward compatibility, in case they need it.)

bug in co_spawn:

Now fixed on boostorg/asio develop branch.


fix: null-check warning through a proper solution

Small steps... towards a better codebase.

Looks beautiful to me!

Who? Me? Thank you bro 🙇 !


Disable libguestfs debugging in integration tests

We don't use it most of the time, but it comprises a large part of
Travis CI output currently. I think it's better reenabled from
scripts if/when it's needed.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: 1 of 2 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


[Performance, WIP] Faster SAC

@matteobettini there's a way to make vmap functional calls much much faster!
we'll need to make sure this works across the board but if it does speed up could be 2x for many losses 🤯

Related issue: https://github.com/pytorch/pytorch/issues/120572

Nice! I am not super familiar with the code here, but I am happy to help benchmark this.
Let's keep in mind readability though. Ideally we would like a normal torch user to be able to read and understand the loss classes.


No menu on system info

Issue
The chat log entries from the system when calling commands such as whois, list tags, help, etc. has a menu that only contains the option: "Export". Similar system info entries doesn't require any menu, and the menu should be removed.

Resolved in PR #84


Rename findOne in dmmf.schema.outputObjectTypes.prisma Query

There is one place you need to rename findOne in it.
in dmmf.schema.outputObjectTypes.prisma path Query object type

This is solved not via rename but a dedicated protocol-level deprecation mechanism. Protocol change is included in 2.14.


Automatically restart on package.yaml changes

Becoming quite common in the Stack world, see #204

stack bundles hpack, which generates a .cabal file from a package.yaml, so you'd still only want to restart on changes to the cabal file, no?

stack converts the package.yaml to .cabal when run, so the restart is really about causing stack to flip into action and do the conversion. If stack was watching and triggering on the package.yaml that would be a different matter, but generally it isn't (and having it do so would be of only marginal utility given ghcid can do so very easily).


Optionality is not preserved when mapping a mapped type with generics

Summary:
Normally, mapped types preserve optionality, unless specified otherwise, the Readonly<T> type is an example:
interface A {
    x?: number;
    y: number;
}

type RA = Readonly<A>;

The type RA above is effectively: { readonly x?: number; readonly y: number }, and so optionality is preserved.
Now, I have a type called ValidationErrors, which is a mpped type that transforms a given type to a slightly differnet shape:
type ValidationErrors<T> = {
    [P in keyof T]?: string;
}

Below, I declare a variable of type Readonly<ValidationErrors<T>> where I specify T explicitly, and then I assign an empty object to it, which expectedly yields no errors because ValidationErrors<T> makes all properties of T optional, and Readonly<T> doesn't touch that optionality.
let bar: Readonly<ValidationErrors<{ name: string; }>> = {}; // No errors

The problem is where I use a generic parameter in place of T:
Actual behavior:
If the type is generic, it complains:
function doSomething<T extends {}>() {
    let foo: ValidationErrors<T> = {}; // No errors
    let bar: Readonly<ValidationErrors<T>> = {}; // ERROR
}

The error:
Type '{}' is not assignable to type 'Readonly<ValidationErrors<T>>'.

Expected behavior:
Given the fact that ValidationErrors<T> makes all properties optional, and Readonly<T> doesn't change the optionality of any properties, the result of Readonly<ValidationErrors<T>> must be a type that only contains optional properties, and as such, it must be okay to assign {} to it. Therefore, it makes sense that let foo: ValidationErrors<T> = {} and let foo: Readonly<ValidationErrors<T>> = {} should both work the same way, without yielding any type errors. Am I wrong?
It's also the case even if I do:
function doSomething<T extends { name: string }>() {
    let foo: ValidationErrors<T> = { name: 'Jack' }; // No errors
    let bar: Readonly<ValidationErrors<T>> = { name: 'Jack' }; // ERROR
}

The error:
Type '{ name: string; }' is not assignable to type 'Readonly<ValidationErrors<T>>'.

What is the difference between ValidationErrors<T> and Readonly<ValidationErrors<T>> that makes {} assignable to one, but not to the other?
P.S. Feel free to close this issue if this IS the intended behavior, but please let me know what the reasoning behind it is, because I'm really confused here and this doesn't make sense to me.
Technical Details:

TS Version: 4.1.5
Editor: VS Code v1.54.2

You forgot to fill out the issue template for feature requests / bug reports.

You forgot to fill out the issue template for feature requests / bug reports.

Is it okay now?

Here's a playground link which you didn't include.

I could swear I've seen this issue already, but I can't find it. Probably some way generics are treated, given that they're open types. The TypeScript team will likely share their wisdom.
Just pointing out that ValidationErrors<Readonly<T>> works as well.

Here's a playground link which you didn't include.

Okay, thanks for that.

I could swear I've seen this issue already, but I can't find it.

I tried searching in the repo but I couldn't find anything related, let me know if you could find it though.

Just pointing out that ValidationErrors<Readonly> works as well.

That's right, but unfortunately my actual situation is such that I can't use ValidationError<Readonly<T>> (because I actually want to have a DeepReadonly<ValidationResult<T>>, where ValidationResult<T> is a type that has a property of type ValidationError<T>, anyways, I don't want to make this post more confusing, but thanks for the pointer.

When the target of an assignment is immediately a mapped type that optionalizes its properties, we can tell that it's OK to initialize that with {}.
When there's an intermediate generic type in the way, though, it's not apparent that T<Partial<U>> will necessarily also be all-optional; not all mapped types have this property. When the mapped type does have this property, you can always almost rewrite it to Partial<T<U>> instead. When the mapped type is more complex (as in DeepReadonly), it's beyond our capabilities to conclude that every optional property in will always result in an optional property out, so we err on the side of disallowing this rather than allowing a possibly-unsound substitution to occur.


KAFKA-6098: Fix race between topic deletion and re-creation.

During topic deletion, there exists a window where a broker updates
its metadata cache to remove a deleted topic's partitions, and the
controller removing the topic's znode. Consequently, it was possible
for a broker to believe a topic no longer existed, however it couldn't
be re-created due to outstanding ZK metadata.
The fix is to return a transient error for when this condition is
encountered. Given the window is anticipated to be small, a retry
will eventually resolve the issue.
Additionally, in rare cases, there existed a window where it was
possible to re-create a topic's znode before its deletion process
was fully complete. This is fixed by making topic creation account
for any outstanding topic deletion znode.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hmm.  If the topic can't be created because of lingering metadata, I think we should just return TopicExistsException.  Anything else would require a KIP to change the error code.  We would also have to deal with older clients, which won't know about your potential new error code.

Hmm. If the topic can't be created because of lingering metadata, I think we should just return TopicExistsException. Anything else would require a KIP to change the error code. We would also have to deal with older clients, which won't know about your potential new error code.

So that's what's done today, however the issue is: a client deletes a topic, lists the topics (doesn't see it since the metadata cache has cleared it), and then tries to create the topic, getting the TopicExistsException, only to have it disppear once it's GCed. Aside from fixing the core issue, which is a lot more involved and should go away with the ZK changes, ideally we can detect this scenario and have the client retry until the reclamation is complete. Is there a transient error code that we could return that would cause the client to retry?

I agree that the current behavior isn't ideal.  However, the kind of protocol change you're talking about would need a KIP.


Allow empty host port to unbind from PortBindings

After random host port set, I couldn't remove it from PortBindings via kitematic
even when I don't need port exposed. (with help of nginx-proxy or something)
This diff allow to input blank host port in Ports tab,
and ignore blank one on setting docker HostConfig.

Instead of allowing an empty port to unbind, it would be cleaner to allow the port mapping to be removed completely, thus unbinding it.

EXPOSEd ports from Dockerfile shall not be allowed to remove.
So empty one is necessary.

My fear is that users leave a port blank in order to trigger a 'random port' and are surprised by the result vs expected.


fix NewConnPool checkMinIdleConns data race

NewConnPool is by definition race free - only one goroutine has access to the pool while it is created.

checkMinIdleConns is not safe ,may add lock when called in NewConnPool

NewConnPool is by definition race free - only one goroutine has access to the pool while it is created.

checkMinIdleConns is not safe ,may add lock when called in NewConnPool

+1

See https://github.com/go-redis/redis/pull/1315#issuecomment-621644965 - I think there can not be a race here.


Auto-reload

So happy I found this tool - have been using Marked, but it doesn't give an accurate representation of GFM.  Thanks!
Anyway, as I was working on my README with the browser next to me, was thinking it would be awesome to have it watch the file for changes, then auto-refresh the browser.  Would you accept a PR if I worked on this?

I have made some success with the https://pypi.python.org/pypi/livereload library. I simply had to replace the grip.server.serve method:
def serve(path=None, host=None, port=None, gfm=False, context=None,
          username=None, password=None,
          render_offline=False, render_wide=False, render_inline=False):
    """
    Starts a server to render the specified file
    or directory containing a README.
    """
    app = create_app(path, gfm, context, username, password,
                     render_offline, render_wide, render_inline)

    # Set overridden config values
    if host is not None:
        app.config['HOST'] = host
    if port is not None:
        app.config['PORT'] = port

    # Run local server
    from livereload import Server
    server = Server(app.wsgi_app)
    server.serve(app.config['PORT'])

Maybe there are some pit falls  - I do not not know.

I tried this patch and it works great.

+1 :+1:

Implemented by @markbt in #135 :sparkles: :fireworks: :smile:

FYI, this feature was officially released n 4.0.0 :smile:
Be sure to upgrade with pip install --upgrade grip.

Works great! Thank you @markbt!


Add support for Linked Verifiable Presentations

Description
Add support for Linked Verifiable Presentations
Motivation
n/a
Resources

Linked Verifiable Presentation

To-do List

[ ] Implement Linked Verifiable Presentation

 Add support for Linked Verifiable Presentations


Detecting hand raised

Hello there if I am interested to only detect hand that is raised for more than 2 seconds,is this algorithm possible?If yes which line should I adjust?
I did my research and I have found this pre-trained model :
https://download.01.org/opencv/2019/open_model_zoo/R1/20190404_140900_models_bin/person-detection-raisinghand-recognition-0001/FP16/
By my understanding, I can skip the training steps and use this model but by any chance do you know how to utilize them as I have trouble for a week now.
Hoping for your reply soon.

The pre-trained model in the link above is in Intel IR format.  It could only be used by OpenVINO.  If you plan to use the model on Intel x86 platforms (CPU only), then you could give it a try.
I think this question is not very relevant to the code in this repository, though.


Fix path merge bug, take 2

Description
@jacobcook1995 @dalonsoa @davidorme
I had to unmerge my last PR, because it was causing CI failures, and I didn't clock this till after it was merged.
It's my fault for not checking this properly (sorry!), but it turns out that your branch protection rules weren't set up correctly, for either main or develop. You need to manually select what the required status checks are, otherwise GitHub will happily let you merge things that don't pass tests.
I've sorted it now, but for future reference this is the relevant section on the settings page:

It's worth knowing, because if you add a new runner (e.g. for a new version of Python), you also have to add it to the required status checks.
Let's try this again. I'll fix up the CI failures then request a review.
Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (back-end change that speeds up the code)
[x] Bug fix (non-breaking change which fixes an issue)

Key checklist

[x] Make sure you've run the pre-commit checks: $ pre-commit run -a
[x] All tests pass: $ poetry run pytest

Further checks

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

This is ready for review now and the tests are passing. The only thing I've changed since my last PR is this: 2f587bfcb300c894aecfbabd2af630690ed1d3cc
The issue was that a seemingly unrelated test test_make_hex_grid was failing, due to it sometimes timing out on Windows and macOS runners (it's a hypothesis-based test). As these runners can sometimes be slow, I've just disabled the deadline for this test.
As to why these failures only seemed to occur after my code changes, I have no idea. Perhaps the extra resource usage incurred by my new integration test meant that the runners were still running slower than usual even after this one test had finished (e.g. because some memory had been swapped to disk), which made this problem more likely to rear its head. Who knows. Either way, the fix seems harmless enough.


Stripe feature

updated the components on the client side to create the cart checkout [cart, cartItem, categoryMenu, deleteBtn, productItem, and productList] in the client utils I updated the GlobalState, actions, helpers, and added a checkout to Queries. Added Models Category, Order, and Product. I also updated Schema files.

saw you copied and pasted from the activity, this activity deals w products not events. you gotta tweak the files to work w this project

I understand that.  I saw the user and events in the code and will update.
I also wasn't too sure about the front functionality I cant get my code to
build I’m having a similar issur Kristin had and i figuted it would be
easier to update than to leave out anything we may need. I can update it,
just wanted to make sure I was headed in the right direction.
My questions are:
Update products to events? (Which u confirmed) kinda.
Remove the category components and code that goes along with it?
If I’m tweaking the code which parts specifically need to be tweaks.
Just Event/Products, Cart, Cart Items. I’m not a 100% either but I’m making
an attempt.
Any help would be appreciated.
On Sun, Aug 11, 2024 at 2:37 PM harrismhurley @.***>
wrote:

saw you copied and pasted from the activity, this activity deals w
products not events. you gotta tweak the files to work w this project
—
Reply to this email directly, view it on GitHub
https://github.com/CrystalC19/MeetMaster/pull/19#issuecomment-2282866288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGFMMSPEXNH33QDXVA75FELZQ64N5AVCNFSM6AAAAABMKMQSV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSHA3DMMRYHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

totally i gotchu, and im definitely thankful for you grinding on a sunday to get this proj done. in the main branch, in the components folder, there is a home folder. in the home folder there is a component called activeEvent. activeEvent is the bottom right component on the screen when you render it. the activeEvent has a button right now it says take action. all we have to do is tie a chakraUI model to that button where users can input card info and pay. no need for carts or list we are only purchasing one event at a time. check out this link for more info on the model we are using (https://v2.chakra-ui.com/docs/components/modal). if i can provide any more info please let me know

Q: Update products to events? (Which u confirmed) kinda.
A: Yes in the appropriate scripts change "products" to "events". make sure you follow the structure of the event model and add some comments because the model will change by tuesday.
Q: Remove the category components and code that goes along with it?
A: Yes remove all the components. there should only be one new component for the payment model. this component should go in the client/src/components/home/addEvent directory.
Key points:

Only one new component in the home folder (if possible)
Return the original Queries, with these deletions we cannot use apollo to test.
Go through most of the .js files you changed and return them to the original, we should be good just attaching payment to the events we have

Thank you for taking the time out to help me. Ill get started on this shortly. Sent from my iPhoneOn Aug 11, 2024, at 3:47 PM, harrismhurley @.***> wrote:
Q: Update products to events? (Which u confirmed) kinda.
A: Yes in the appropriate scripts change "products" to "events". make sure you follow the structure of the event model and add some comments because the model will change by tuesday.
Q: Remove the category components and code that goes along with it?
A: Yes remove all the components. there should only be one new component for the payment model. this component should go in the client/src/components/home/addEvent directory.
Key points:
Only one new component in the home folder (if possible)
Return the original Queries, with these deletions we cannot use apollo to test.
Go through most of the .js files you changed and return them to the original, we should be good just attaching payment to the events we have
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


How to switch camera devices❓

Question
How to switch camera devices?
What I tried
The doc says there are multi lens such as wide-angle-camera, telephoto-camera, ultra-wide-angle-camera. I would like to switch camera lens on camera view. I tried to find some solutions on doc, but not found yet to switch camera lens. I can select the initial camera as Doc says const devices = useCameraDevices('wide-angle-camera'), but I couldn't figure out how to switch camera lens once it's mounted.
VisionCamera Version
2.14.1
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar questions in the issues page as well as in the discussions page and found none.

Yeah the docs are quite silent about this. But you can just use some state and change the "useCameraDevices"-hook like so:
const [deviceType, setDeviceType] useState(null); // use default lense at startup
const [deviceDir, setDeviceDir] useState("back");

const devices = useCameraDevices(deviceType);

const device = devices[deviceDir];

...

return (
<View>
  <Camera device={device} isActive={true} ... />

  <button  onPress={() => setDevieType("wide-angle-camera") />
  <button  onPress={() => setDevieType("telephoto-camera") />
  <button  onPress={() => setDevieType("ultra-wide-angle-camera") />
</View>
)

@demsr but is there a way to switch between the devices without stopping recording?

@valn1 are we talking about Back/Front camera or the different kind of lenses on the back? The latter should not be necessary, my camera switches between lenses depending on the zoom level.

@demsr yeah, i was talking about switching between front and back. sorry for the late response

Yeah the docs are quite silent about this. But you can just use some state and change the "useCameraDevices"-hook like so:
const [deviceType, setDeviceType] = useState(null); // use default lense at startup
const [deviceDir, setDeviceDir] = useState("back");

const devices = useCameraDevices(deviceType);

const device = devices[deviceDir];

...

return (
<View>
  <Camera device={device} isActive={true} ... />

  <button  onPress={() => setDeviceType("wide-angle-camera") />
  <button  onPress={() => setDeviceType("telephoto-camera") />
  <button  onPress={() => setDeviceType("ultra-wide-angle-camera") />
</View>
)

//fixed some typos

Apreciate the code, to be correct you should close the "}" and button should be Button

Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue.
If your issue has been fixed, consider sponsoring me on GitHub to say thanks 💖

You can follow this code :
const devices = Camera.getAvailableCameraDevices();
const [device, setDevice] = useState(getCameraDevice(devices, 'back'));
const handleFlipCamera = () => {
const position = device?.position == 'front' ? 'back' : 'front';
setDevice(getCameraDevice(devices, position));

};
//use
<Camera
isActive={isCameraActive}
device={device}
codeScanner={codeScanner}
style={{height: '100%'}}
torch={torchEnabled ? 'on' : 'off'}
/>


Release?

Should we do another release?

No objection from me.  I wouldn't mind seeing the plotting PR go in first
though.
On Thu, Dec 28, 2017 at 1:07 PM, Christopher J. Wright <
<EMAIL_ADDRESS>wrote:

Should we do another release?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mrocklin/streamz/issues/136, or mute the thread
https://github.com/notifications/unsubscribe-auth/AASszBa4eJVsJFxz6jFARM7DwGTNfRZKks5tFAMCgaJpZM4ROpnS
.

I agree, I can wait for the plotting.

I've pushed streamz 0.3.0 to PyPI