callOptions  GRPC_ARG_CLIENT_IDLE_TIMEOUT_MS can not larger than kDefaultChannelDestroyDelay(30s)

What version of gRPC and what language are you using?
v1.26.0 Objective-C
What operating system (Linux, Windows,...) and version?
Mac
What runtime / compiler are you using (e.g. python version or version of gcc)
xcode
What did you do?
i use iOS device as a client , and golang as server, i start a bidirectional streaming call with 【additionalChannelArgs[@GRPC_ARG_CLIENT_IDLE_TIMEOUT_MS] = [NSNumber numberWithInteger:60000];】, then cannel the call. After 30 seconds the connection disconnected.
What did you expect to see?
i expect to see the connection disconnect after 60 seconds
What did you see instead?
i saw the connection disconnect after 33 seconds
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
i debug it , and i found the connection disconnected because of the kDefaultChannelDestroyDelay [in GRPCChannelPool.m file]，the channel will aways destroy after kDefaultChannelDestroyDelay=30 seconds. so if the [GRPC_ARG_CLIENT_IDLE_TIMEOUT_MS] is bigger than  kDefaultChannelDestroyDelay, it will not work!

@bigfacebear @hcaseyal @vjpai @AspirinSJL

@srini100 Can you help?

@danlanxiaohei, feel free to submit a fix PR and tag @muxi. Folks are just trickling back in from holidays so this will take some time to address.

The idea of gRPC ObjC channel pool is that users are only to interact with calls but not channels. gRPC manages the channels, which has a 30s destroy delay after idle which cannot be changed at this moment. The option additionalChannelArgs exists more for the purpose of workaround issues with arguments not directly supported in ObjC layer but is supported in core. It's unfortunate and inevitable that such options from gRPC core allows you to control the channel behavior in some way, but that is not the intention of the ObjC wrapper.

closing this ticket as no-op


NIFI-7657 Suppressed log messages from failed authentication requests when HTTPS is not enabled

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
NiFi UI would make requests for authentication even when HTTPS is disabled and therefore no authentication is enabled. When these (expected) messages appeared in the nifi-user.log, they would often confuse users. This PR removes those messages by default.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[x] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Re-running CI jobs as the Maven failures should be resolved thanks to PR 4419.

Had to rebase on main to include the fix; now CI jobs are running again.

Gave it a try and it LGTM. Merging to main, thanks @alopresto


GPU inference error using db_resne50_rotation

Bug description
Hello, guys I am getting the following error by running the snipped of code. I don't  get the same error if I use db_resnet50 instead of db_resnet50_rotation. Help please! I am using the version 0.5.1
Code snippet to reproduce the bug
from doctr.io import DocumentFile
from doctr.models import ocr_predictor
tic = time.time()
doc = DocumentFile.from_pdf("/content/file.pdf")
print(f"Number of pages: {len(doc)}")
predictor = ocr_predictor('db_resnet50_rotation','crnn_vgg16_bn',pretrained=True,assume_straight_pages=False).cuda()
result = predictor(doc)

Error traceback
RuntimeError: Input type (torch.FloatTensor) and weight type (torch.cuda.FloatTensor) should be the same or input should be a MKLDNN tensor and weight is a dense tensor

Environment
!pip install python-doctr[torch]
!sudo apt-get install fonts-freefont-ttf -y
!pip3 install --no-build-isolation -U pypdfium2==1.0.0

Deep Learning backend
is_tf_available: False
is_torch_available: True

First, could you elaborate on "I don't get the same error if I use db_resnet50 instead of db_resnet50_rotation". What error do you get if you use that one?
Yes, please look below:

Thanks for that! The traceback gave the source of the problem away: the input tensor isn't being moved to the device of the model as it should.
I'll fix this shortly then :)
I'll let you know here when it's merged!

Hi @harindercnvrg should work now (on main) 👋

Hi
I'm getting a similar error using db_resne50_rotation with version 0.7.1a0.
it is working fine with db_resne50.
Error traceback
Traceback (most recent call last):
  File "ocr.py", line 42, in <module>
    result = model(image)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 28, in decorate_context
    return func(*args, **kwargs)
  File "/home/minouei/Documents/models/rvl/gits/doctr/doctr/models/predictor/pytorch.py", line 117, in forward
    crops, loc_preds = self._rectify_crops(crops, loc_preds)
  File "/home/minouei/Documents/models/rvl/gits/doctr/doctr/models/predictor/base.py", line 93, in _rectify_crops
    orientations = [self.crop_orientation_predictor(page_crops) for page_crops in crops]  # type: ignore[misc]
  File "/home/minouei/Documents/models/rvl/gits/doctr/doctr/models/predictor/base.py", line 93, in <listcomp>
    orientations = [self.crop_orientation_predictor(page_crops) for page_crops in crops]  # type: ignore[misc]
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/autograd/grad_mode.py", line 28, in decorate_context
    return func(*args, **kwargs)
  File "/home/minouei/Documents/models/rvl/gits/doctr/doctr/models/classification/predictor/pytorch.py", line 48, in forward
    predicted_batches = [self.model(batch).to(device=_device) for batch in processed_batches]
  File "/home/minouei/Documents/models/rvl/gits/doctr/doctr/models/classification/predictor/pytorch.py", line 48, in <listcomp>
    predicted_batches = [self.model(batch).to(device=_device) for batch in processed_batches]
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torchvision/models/mobilenetv3.py", line 179, in forward
    return self._forward_impl(x)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torchvision/models/mobilenetv3.py", line 169, in _forward_impl
    x = self.features(x)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/container.py", line 141, in forward
    input = module(input)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/container.py", line 141, in forward
    input = module(input)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 446, in forward
    return self._conv_forward(input, self.weight, self.bias)
  File "/home/minouei/miniconda3/envs/mmocr3/lib/python3.8/site-packages/torch/nn/modules/conv.py", line 442, in _conv_forward
    return F.conv2d(input, weight, bias, self.stride,
RuntimeError: Input type (torch.FloatTensor) and weight type (torch.cuda.FloatTensor) should be the same or input should be a MKLDNN tensor and weight is a dense tensor


[Feature]: Use font awesome title: <title> as H1 heading if no H1 heading is added

What problem does this feature solve?
Given following example index.md file:
---
title: Heading 1
---

## Heading 2

Some content

In Docusaurus this would add Heading 1 as the title of the document. But in RSPress:

One can add an additional Heading 1 in the document, but then markdownlint will complain about the document having two top-level headings, MD025.

https://github.com/DavidAnson/markdownlint/blob/main/doc/md025.md

What does the proposed API look like?
I have no idea.

If the overview of frontmatter is true, the page will use Overview component to render. And Overview component will not render the h1 title if title is truth value.
        {!title && (

            Overview

        )}

I think #1493  will fix it.

If the overview of frontmatter is true, the page will use Overview component to render. And Overview component will not render the h1 title if title is truth value.
    {!title && (

        Overview

    )}

I think #1493 will fix it.

but for other types of pages, is it possible to use the title in frontmatter if it is not given?


Add a website documentation

Tl;Dr: you can play with the website here atm: https://jolicode.github.io/castor/
Summary
Here is a brand new website for Castor built with mkdocs
and the material theme.
Featuring:

slightly improved documentation tree
statically built (no js) and deploy from a GitHub Action on GitHub Pages
code coloration
support of GitHub Markdown "alerts" (tips, warning, info, etc)
search bar (and a S keyboard shortcut) + highlight of matches
light and dark themes
links to edit the page on GitHub
anchors for each title
mobile friendly
navigation tree partially generated automatically from the _nav.md file
list of some real world Castor usage

Preview
A preview is available here: https://jolicode.github.io/castor/
Screenshots
Homepage

Getting started - scrolled down

Search + highlight

Examples + dark mode

Todo

[ ] Squash the commits
[x] Setup GitHub Pages
[ ] Setup the custom domain name
[ ] Setup redirection.io hosted instance
[ ] Crawl with redirection.io to ensure there is no 404

awesome work !! Thanks
I'll review it later.
I was playing with the website, and I found a "bug":
👇🏼 https://jolicode.github.io/castor/#usage
👇🏼 There is not coloration :/

actually, same on almost all pages


endpoint update: /validate to /$validate

According to the validate operation definition the URL should be of the form:
URL: [base]/[Resource]/$validate and the operation cannot be run at the system level according to the spec. The most basic solution here could be a wildcard, which would work well enough for us because inferno-core and any other client could call with a valid Resource name and get a result. I'd start with this.
Also, I didn't mention this before, but I think we should add this new route alongside the existing route to ease our upgrade client upgrade path (i.e. we could merge this without needing a complementary inferno-core upgrade). Otherwise if we merge this and push a new dockerhub image and deploy inferno-core would break because it's not using the new route.

Side Note:
If we can get that working then we might be able to do something fancier where we get a list of children (maybe with Resource#listChildren?).

Can you rebase this against main?


Configuring program.cs for asp.net core 6

Hi, am trying to configure SMTP settings in program.cs for FluentEmail.MailKit as detailed below.
Am new to net core so not familiar with the framework to figure it out. Would appreciate any pointers. Thanks in advance.
Here's the code in program.cs
using FluentEmail.MailKitSmtp;
<EMAIL_ADDRESS>.AddMailKitSender(new SmtpClientOptions
{
Server = "smtp.xxxx.com",
Port = 587,
Password = "xxxxx",
UseSsl = true,
User =<EMAIL_ADDRESS>});
And here's what I'm using for the send request:
using FluentEmail.Core;
using FluentEmail.Smtp;
using System.Net;
using System.Net.Mail;
var email = await Email
<EMAIL_ADDRESS><EMAIL_ADDRESS>"Luke")
.Subject("Hi Luke!")
.Body("Fluent email looks great!")
.SendAsync();

This is what I am using in program.cs now.
However not able to invoke as sender for code sending the email in a controller method:
<EMAIL_ADDRESS>.AddSmtpSender(new SmtpClient("smtp.xxxxx.com")
{
UseDefaultCredentials = false,
Port = 587,
Credentials = new<EMAIL_ADDRESS>"xxxxxxx"),
EnableSsl = true
});


Refactor the sign up and login page

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #745
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

hi can you please resolve the merge conflicts

Ok sir

@narayan954 have resolved the conflicts sir

you didn't resolved it correctly, I'm reverting and resolving myself.

There were several syntax errors, please make sure to test these small things out in future.

Ok sir


support iOS 8 and later only

Still getting the message:
ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs . See https://developer.apple.com/documentation/uikit/uiwebview for more information.

Thanks @rodruiz, I've merged the code and published v1.2.0


Rename main.go to gorm.go

My issue:

When i want to open the main.go in a project with gorm in the vendor folder my editor always suggests to open the main.go file in gorm.
Because gorm is the only package in my hole vendor folder that contains at least 200 git projects that all don't have a main.go file this looks a bit wrong.
It would be nice of the main.go file had another name to overcome this like gorm.go.
What version of Go are you using (go version)?
go version go1.12.7 linux/amd64

Which database and its version are you using?
Database: mysql
Gorm: v1.9.10

I don't think it's necessary to rename main.go. Maybe you should config your VScode to fix this problem.

Yes it's not really necessary but this is more of a best practice for go libraries.

I notice there's a phrase("recently opened") in your screenshot. Maybe the editor suggested you open the main.go file in gorm is just because you had opened it?


Transfer eager troubleshooting docs to nf-core website

I've tried to clean it up but consider this a 'draft'.

Sorry @jfy133 I'm being super picky...
Just re-read the whole document.
In the Input files not found section, I would have one example with just a simple path to the file, and one example with a glob pattern (and explaining what it actually is ;-))
I would put Output for only a single sample although I specified multiple with wildcards before Sample sheet input.
I think it's more logical this way.
As Phil said in the comments, I'll add a section about schedulers in the The pipeline crashes almost immediately with an early pipeline step.
I'll also add a section that if neither container engine nor conda is specified, Nextflow will try to find all tools in the current PATH and error would be something like bwa not found.
I think it's quite a common error too.
Apart from these tiny comments, this PR is a great addition to the website, all pipelines will gain from it.
Thanks a lot for doing it

No problem at all! I've got thesis brain now so not really functioning properly (this is break-time work a to atm ;)).
By "I'll" do you mean you will add it, or that you would like me to do it?
I don't mind either way, but if have strong opinions maybe makes more sense for you complete it

No problem at all! I've got thesis brain now so not really functioning properly (this is break-time work a to atm ;)).
By "I'll" do you mean you will add it, or that you would like me to do it?
I don't mind either way, but if have strong opinions maybe makes more sense for you complete it

I don't have opinions that strong about it, I mainly meant it in the that what you should do way ;-)

@MaxUlysse howzat? I hope that's what you were meaning...


Update notification from playlistmanager if user change mediaitem dat…

I bring this small change because testing the project needed to change update notification

Do you have an example of when and why this would be needed?

Sure. I'm writing an application that recognizes the songs that are playing and automatically updates your data (title, name of album, cover, etc.). This song is updated during playback because I use themicrophone to "hear" the playing song. Then when I have a good data the app update my interface and notification

This would be useful, I have an media item with multiple images (Album Images), and every x seconds I switch the image like a gallery for a single media item. I would like to have these changes on master.


service/block: request Commit from core to construct ExtendedHeader

In tendermint/core Block's body only contains LastCommit while technically the Commit of the block is available and has to be propagated along with a ExtendedHeader. Thus, to construct ExtendedHeader we need to request Commit from the core using RPC API Commit.

I forgot what we decided.. are we going to implement this before devnet or can we go the easier route?
Easier route IMO:
just keep Block in memory and wait until we get the next raw block, and take the LastCommit from that block and stick it in the ExtendedHeader of the previous block, pipe it through to Header Service for it to publish to the header topic?

@renaynay, That's not easier IMHO. We can discuss why. But implementing this issue is literally 4 loc which includes if err != nil check.

No problem, if it's super quick to implement, do you mind taking it on then?

You assigned me to the issue, that's why I'm wondering.

Checkout updated comment

In a place where you create an ExtendedHeader


Velocity control mode & new robot_state/system/io interfaces

VAL3

Velocity control implemented with functions for velocity commands -> requires add-on (Velocity or Motion)!
Velocity control possible in joint space (JOINT) or cartesian space (w.r.t. BASE/TOOL frame)
Velocity control mode is started with a VelocityConfig message with various parameters (e.g. vel/accel limits)
Added state machine to switch between motion control modes (JOINT_TRAJECTORY_STREAMING, VELOCITY_CONTROL)
-> the default mode is JOINT_TRAJECTORY_STREAMING and works as before
Increased feedback task frequency (synced with interpolation clock)
SYSTEM socket interface (receiver task, port 11001) to handle system commands (e.g. set drive power)
IO socket interface (receiver task, port 11003) to handle IO commands (e.g. read/write IO)
-> only writing single IO is fully implemented

Other changes/improvements:

Sending JointFeedback message including joint velocities -> requires add-on (Motion)!
Note: The generic industrial_robot_client doesn't support JointFeedback messages
Renamed socket name "Feedback" -> "State" (socket configuration must be adapted on the controller!)
Used VAL3 libraries and custom types for better modularization
Used VAL3 custom types for "enums"
Added debug screen for debug messages (switching to the debug screen activates the "debug mode")

NOTE: Developed and tested on a CS8 Controller only!
ROS-Industrial clients

robot_state node with additional support for JointFeedback messages
IO interface for reading/writing IO (only "write single IO" fully implemented)
system interface for system commands ("set drive power" implemented)
added staubli_msgs package (with IO related messages/services)

@gavanderhoorn
Could you have a look at this? You said that you would consider merging our extensions in #32 (Comment).
I would like to help as much as I can before I leave the university. Now I still have the opportunity to test this on a real robot (at least for CS8 and maybe also for CS9).
Just tell me how I can help:

Would it help if I merge the master branch into our faps-devel branch, resolve the conflicts locally and push it again?
Or should I try to rebase it on top of the master branch?

Hi, thanks for the PR.

Could you have a look at this? You said that you would consider merging our extensions in #32 (Comment).

Yes, I did.
I do have to say we're always going to be looking to maintain backwards compatibility as much as possible. That doesn't mean we can never introduce breaking changes, but it would be great if we could try to avoid introducing them unless necessary.
Especially changing default behaviour should not be weight against the disadvantages of doing that.

Just tell me how I can help:

Would it help if I merge the master branch into our faps-devel branch, resolve the conflicts locally and push it again?

Or should I try to rebase it on top of the master branch?

It doesn't appear as-if there would be an advantage to maintaining the history of parallel development in the repository here and your fork, so to avoid adding (more) merge commits, a rebase would be greatly appreciated, yes.
I expect most conflicts to be caused by the magic nr removal and some of the network parsing code.

And I forgot to mention: it would be great if we could try to avoid introducing additional, required dependencies on the VAL 3 side.
The velocity control infrastructure you added introduces one. If we could somehow make it possible for the code to auto-detect whether that addon is present, or in some other way make it possible to configure its use, that would be something we should do.
We can't make it a hard requirement for the "default" driver, as that would make it unusable for many (current) users.

Just a comment to let you know this PR is not forgotten.
It's a big PR with many changes and therefore difficult to review. It also requires quite some setup to review, which doesn't make it any easier.
It would be great if people who have looked at this code already (such as @IvoD1998 in #41) could comment on what their experiences are.

Due to other tasks and projects, we haven't had the time to review this code yet. We have tried to translate their IO functionality manually which we got to work on the CS9, but haven't looked into this further.
My apologies.

Hi, I just wanted to say a big thanks for everybody working on this project. I'm quite new to ROS and VAL3 and it was not easy to make this PR working. Eventually I can confirm this PR#36 works on a CS8 controller. I might have run into some minor problems though, of which I'm not too sure about at this moment.
One thing I encountered is when you use the Message Publisher in rqt and set a refresh rate of below <4/sec on the topic /jog_interface/vel_cmd, the motion stutters and the actual moving speed seems to depend on the publishing refresh rate. For publishing refresh rates above and including 4/sec, the actual motion speed doesn't seem to change, which is a good thing.
What's the reason for this behavior and what's the recommended publishing rate?

Hi, I just wanted to say a big thanks for everybody working on this project. I'm quite new to ROS and VAL3 and it was not easy to make this PR working. Eventually I can confirm this PR#36 works on a CS8 controller. I might have run into some minor problems though, of which I'm not too sure about at this moment.
One thing I encountered is when you use the Message Publisher in rqt and set a refresh rate of below <4/sec on the topic /jog_interface/vel_cmd, the motion stutters and the actual moving speed seems to depend on the publishing refresh rate. For publishing refresh rates above and including 4/sec, the actual motion speed doesn't seem to change, which is a good thing.
What's the reason for this behavior and what's the recommended publishing rate?

Hi, this is actually a "safety feature" 😁
There is a timeout of 250 ms (in the example configuraton file) for the jog command so it will stop after this timeout if no message was received. Which makes sense with your description when you say it's ok for 4 published messages per second. Otherwise the robot would keep moving even if nothing is published at all after just one message. In an error scenario where someone forgets to publish the stop command this could be dangerous. The stuttering you saw was caused by the timeout and thus the stop commands in between.
There is no timeout / publishing rate I can recommend but I chose 250 ms for the timeout so the required minimum publisher rate is not too high with 4/sec and the robot will stop not too late if anything goes wrong.
Feel free to use your own configuration. You can set the timeout here.


Recipe for Python

Recipe for documentation tool in Python.
This needs to output api output under /api/python under the project folder.

this can be closed


Only build web viewer if any rust or web stuff has changed

What
Checklist

[ ] I have read and agree to Contributor Guide and the Code of Conduct
[ ] I've included a screenshot or gif (if applicable)
[ ] I have tested the web demo (if applicable):

Using newly built examples: rerun.io/viewer
Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[ ] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[ ] If applicable, add a new check to the release checklist!

PR Build Summary
Recent benchmark results
Wasm size tracking

…that re-triggered way too many jobs


Reduce SetInputShapeBinding overhead.

Current shape binding is compared with a new one in TrtShapeOptimizationProfile::SetInputShapeBinding and IExecutionContext::setInputShapeBinding is only called if they differ.

Hi @bixia1 Can you please review this PR ? Thank you!

Hi @bixia1 Can you please review this PR ? Thank you!

Hi @bixia1 Can you please review this PR ? Thank you!

Hi @pjannaty /@DEKHTIARJonathan Can you please review this PR ? Thank you!

Hi @pjannaty /@DEKHTIARJonathan Can you please review this PR ? Thank you!

Hi @drivanov, @pjannaty, @DEKHTIARJonathan  I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen! Thank you for your contribution!


add type alias

Codecov Report

Merging #4 (0860deb) into master (0c13248) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%
==========================================
  Files          22       23       +1
  Lines         790      824      +34
  Branches      153      183      +30
==========================================
+ Hits          787      821      +34
  Misses          3        3

Impacted Files
Coverage Δ

district42/_schema_visitor.py
100.00% <ø> (ø)

district42/_schema_facade.py
100.00% <100.00%> (ø)

district42/representor/_representor.py
100.00% <100.00%> (ø)

district42/types/__init__.py
100.00% <100.00%> (ø)

district42/types/_dict_schema.py
100.00% <100.00%> (ø)

district42/types/_type_alias_schema.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c13248...0860deb. Read the comment docs.


Cakephp php version 5.6

cakephp - why do some changes NOT happen until I change php version using SiteGround?

I close this issue as it is not related to griddb/c_client repository.


Made Possible Ingredients more compact

List items now take up less space
List items are larger on mobile to compensate for finger width and smaller on tablet and laptop
List height is smaller on mobile (50vh) and taller on tablet and laptop displays (75vh).

Will move adding search by text function to different issue.


Y axis should not have duplicated values
What is happening instead?
1 and 4 are duplicated
What error message are you getting?
No error message

Have I misunderstood something?
Thanks for your help!
Update: It seems to be related to the default tickAmount of 6. It would be great if the chart could know itself how to reduce this tickAmount number if there isn't enough data to display 6 points.

Yeah, you're correct. The y-axis should automatically reduce the tickAmount if the range is too small to print non-duplicating round numbers.

this could be a work around here:
yaxis: {         min: 0,         max: _maxYAxisValue_,         tickAmount: _maxYAxisValue_, }

@sheikh303  @junedchhipa  how to avoid duplicate y-axis label values in real-time chart without setting min or max or tickAmount, will the labels automatically set based on the y-axis value?

@sheikh303  @junedchhipa  how to avoid duplicate y-axis label values in real-time chart without setting min or max or tickAmount, will the labels automatically set based on the y-axis value?

Y-axis doesn’t provide showDuplicate: false configuration. Only X-axis has it.
Using "Min, max, tickAmount" is only work around i guess.

@sheikh303 ok thanks for confirming

Any news on this?
We have some pretty complex charts, so the workaround is very difficult to implement.

this still happens in my line chart. my apexcharts version: 3.35.5

this could be a work around here: yaxis: { min: 0, max: _maxYAxisValue_ + _offset_, tickAmount: _maxYAxisValue_+ _offset_, }

Could you please expand on how the maxYAxisValue and offset are set? Are these values statically assigned because I don't think in any of those chart options, we have access to the y values to dynamically determine what those values should be.

I have this problem using the Apexcharts card in Home Assistant. Increasing the yaxis decimals value was one solution as, by observation only, it appears as if the grid/ticks are drawn to values proportionate to their spacing between the max/min values but the labelling of those values is simply rounded to the nearest decimals specification for labelling. I tried varying tickAmount also and observed that, although the grid/ticks were evenly spaced, the labelling was not duplicated but also not proportionate. E.g. in the image, the grid is evenly spaced and clearly the label increments: 0.03, 0.04, 0.03, are not proportional.

Hi ! I using version latest Apexchart 3.46.. This issues still
this my codepen: https://codepen.io/henrytran/pen/rNREogO


Windowing Samples updates for 1.1 GA

Description
Updating sample to reflect AppWindow API changes for Windows App SDK 1.1 GA. All samples (cs-winui, cpp-winui, cs-winforms, cs-wpf) should be given added functionality to reflect the following AppWindow updates:

InsertAfter to show how to set z-order among windows (Emily)
ResizeClient to show how to size an AppWindow to fit its content using client coordinates (Sam)
Tall caption buttons for custom titlebar (Eve)
IsCustomTitlebarSupported API (Eve)

Target Release
1.1 GA
Checklist

[x] Samples build and run using the Visual Studio versions listed in the Windows development docs.
[ ] Samples build and run on all supported platforms (x64, x86, ARM64) and configurations (Debug, Release).
[ ] Samples set the minimum supported OS version to Windows 10 version 1809.
[ ] Samples build clean with no warnings or errors.
[ ] [For new samples]: Samples have completed the sample guidelines checklist and follow standardization/naming guidelines.
[ ] If I am onboarding a new feature, then I must have correctly setup a new CI pipeline for my feature with the correct triggers and path filters laid out in the "Onboarding Samples CI Pipeline for new feature" section in samples-guidelines.md.
[ ] I have commented on my PR /azp run SamplesCI-<FeatureName> to have the CI build run on my branch for each of my FeatureName my PR is modifying. This must be done on the latest commit on the PR before merging to ensure the build is up to date and accurate. Warning: the PR will not block automatically if this is not run due to '/azp run' limitation on triggering more than 10 pipelines.

PR not including complete change, abandoning!


Display total supply, total circulating supply and update Staked IOTX in the dashboard

For Total supply and total circulating supply, use below
http://analytics.iotexscan.io/
query{
	chain {
    totalSupply
    totalCirculatingSupply,
  }
}

For "Staked IOTX", it should be calculated using "totalCirculatingSupply" from the above query, not the fixed 5,400,000,000.

We will need to display "total supply" and "total circulating supply"

let's wait for a design.


Datepicker is not hide in IE11

Datepicker is not hide in IE11 while using mouse to select the date.
But it can be hidden while using keyboard...
How to solve this issue ?

Closing this issue as I can't reproduce it. If the issue still occurs in the latest release or current master please reopen this issue or open a new issue with a link to this and with a jsfiddle example


Bundle version doesn't match installed version

I get a Keybase error when I start the Keybase app - "Bundle version (1.0.1-20160305170047+41e7640) is less than installed version (1.0.1)".  If I ignore the error, even though I'm logged in on the CLI, the app shows me as logged out.  Logging out and back in had no effect.
my log id: 8f97bc8b98e7b5bc6172ca1c

Seeing the same error after the update as well. My Keybase install seems to be borked.

Same:

I'm getting the same error popup as @grempe.  Full error output: https://gist.github.com/crcastle/16ba4ef3bf03db762c7d
I woke up MBP from sleep this afternoon and this was almost immediately displayed.
If the install order might have caused the problem, I installed keybase from homebrew and then more recently installed the OS X installer that enabled kbfs, menu bar icon, GUI functionality.
Should I have uninstalled the hombrew version first?
Did an autoupdate bork one piece of keybase?

Very sorry about this, we pushed out a broken build.  There's a fixed one available now, but you'll have to apply it manually.  Here's the recipe:

keybase update run to get the new build
Click on the Keybase icon in the menubar, and "Quit" in the bottom right
Relaunch Keybase from Applications folder.

Let us know whether it works okay!  And sorry again for the hassle.

Thanks @cjb.  After doing the steps you list above, I get an error saying keybase.service is not running.  There are three buttons: More Details, Ignore, and Quit.
If I click Ignore everything seems to be ok -- I'm able to browse /keybase/public/ and keybase status shows that I'm logged in.
If I click Quit, the Keybase.app starts again in a few seconds and gives me the same keybase.service not running error popup.
So, it seems like everything is working ok, but I do not know why I'm getting this dialog and having to click Ignore.
Thanks!

@crcastle can you run keybase log send and post the id?

@gabriel, sent!
log ID: 7af5f3b49d1c3df4650ceb1c

@crcastle Moving this into separate issue here since I think unrelated to borked version problem above.. I posted a comment there which might help us diagnose (or fix issue)

Thanks @cjb , my issues have been resolved!

I'm ok now too.


Build up the interface for march::gas and refactor

march::gas barely works (not very reliably yet, referring to https://github.com/solvcon/solvcon/commit/e9390772c4b97de6d6ebc9a0842c9fa4214cf8de checked in in Oct 2017).  Its interface needs clean-up.
All march::gas::Solver members are exposed in a flat structure and it should be changed to be hierarchical:

m_block and m_cecnd (mesh)
m_param
m_state
m_sol (solution)
m_sup (supplmental data)
m_qty (derived physical quantities)

When updating the solver interface, the anchor along with the managing hook and case need to update the calling code.  I hope the (Python) change may be limited in solvcon.parcel.gasplus, and gasplus may become very different from other parcels.  I guess much of the anchor code may be changed.
In particular, I'll try to wrap march::gas::Solver to replace solvcon.parcel.gasplus.solver.GasPlusSolver and thus decouple it from solvcon.solver.MeshSolver.  It is very likely its parallelism will be broken.  But it doesn't matter since the parallelism hasn't been tested at all for the new solver.
Todo list:

[x] Split march and its submodule march.gas into two .cpp files
[x] Hierarchical data for march::gas::Solver
[x] Remove flattened accessors to the C++ hierarchical data
[x] make solvcon.parcel.gasplus to directly use the Trim classes in march::gas
[x] Port the Python "anchor" to C++ march::gas
[x] Move all Python logic to C++

The final goal is to replace solvcon.parcel.gasplus.solver.GasPlusSolver with march::gas::Solver.

Fixed by #198

solvcon.parcel.gasplus.solver.GasPlusSolver is still a thin wrapper.  I hope to remove it in the future as commented in #198.


QiscusApi.getInstance().getChatRoom(roomId) returns nothing

I got no return value from running QiscusApi.getInstance().getChatRoom(roomId). Below is the code that I used.
QiscusApi.getInstance()
                .getChatRoom(id)
                .subscribeOn(Schedulers.io())
                .doOnNext(chatRoom -> QiscusCore.getDataStore().addOrUpdate(chatRoom))
                .observeOn(AndroidSchedulers.mainThread())
                .subscribe(onSuccess::call, onError::call);

Hi @anuress thanks for the report, can you try again?

Hmm, it's not sdk problem, I guess? Anyway, thank you, it's working now.

Cool!, the issue was on Server, but we've fixed it, anyway thanks for the report


Consider parsing expression grammars

I not sure if you are aware (you might) about parsing expression grammars to parse the HTML or other type of code, since they offer better performance and less space for errors than using Regex.
One library you can check is pest.
You could also consider html5ever and rust-cssparser. They are part of the servo project and are very mature already.

I've looked into different ways of parsing the html5. I think there are better ways then we have now, so I'm always open for idea's and suggestions.
I've also looked at some other (rust) html5parser projects but my intention is to create as much as possible ourselves. This doesn't mean we will be writing everything, and for a lot of things should use existing libraries, but as an html parser is the basis of a browser engine, I'd rather write it from scratch instead of using an existing one.
If you are willing to write some small example code on how a PEG parser should be incorporated, i'm happy to take a look at it to see if we could incorporate it, but the main focus I currently have is getting the current system running correctly.

Related question (and possible answer) here.

And this is an example of the grammar for a functional HTML parser using pest.
https://docs.rs/crate/html_parser/latest/source/src/grammar/rules.pest

The current parser of both the CSS3 and HTML5 seems to work fine at the moment. No need to change to another system for now.


Folder settings don't work

VSCode Version: 1.46.0
OS Version: Ubuntu 18.04 LTS

Steps to Reproduce:

Create workspace with two folders A and B
Change folder setting A: "python.formatting.provider": "black"
Change folder setting B: "python.formatting.provider": "yapf"

Expected Result
Formatting in folder A will be done by black, and formatting in B by yapf.
Actual Result
Formatting in both folders is done by autopep8, the default.

/extPython
This setting comes is from Python extension and it's support/behavior should be reported there.


fix: replaced missing videos

A couple of the videos on the Writing Code page were replaced, along with a few insignificant linter fixes.

It'll be fixed as part of PR #740


define backend query building insert function

PULL REQUEST
Backend insertion function needed for query building.
Summary
You can visit and see the below changes at {basePath}/queryBuilding on this test branch
https://github.com/user-attachments/assets/6f9890de-8db1-41df-83ce-11da857a1634

Sketches out the backend query building insertion function, including cascading join insertions for the query_to_valuesets
Defines input param type to for the frontend to send to the backend

Will sync this into the work being done for database creation in the event that the two types are similar enough to be merged

Slightly refactor the ValueSet type to include external/OID for future use - discussion of this addition / rework here
Refactor some frontend fetching logic to be a bit more generic from another component for future reuse

Related Issue
Fixes #70 and begins implementation of #72
Acceptance Criteria
Builds out a test page at /queryBuilding that just accepts the query name and then inserts a custom query with a hardcoded group of valuesets to make sure the insertion flow works. Will build off this UI as we iteratively build it out to match the designs.
Will hide this from the UI navigation until it's ready

Looks pretty good to me. I think we can simplify some of our language here. The current plan is that we will only offer "query templates" out of the box and all queries available in the app will be user defined, therefore we don't need a distinction between user defined and non-user defined queries.
Also, how should we approach testing this work? Unless I'm missing something we don't have much by the way of tests written.

Good question! Ideally we'd have an integration test that does a straightforward insert / validates the database state that it indeed inserted the query correctly, especially with the cascading joins. Since we don't have the integration test setup currently though, I elected the manual route with the test branch instead to show the simple case that the happy path works. Once we get the integration tests working again, happy to write a test that validate the query gets created correctly when fed the right frontend input.
In the meantime, once we get enough of the frontend built to warrant an e2e, would also be happy to write one of those to cover a more interesting chunk of the feature.


Any plans or anyone working towards UWP support?

I think the title pretty much sums it up.
I was wondering if anyone is working on adding UWP support?
NControl is a really great addition to a Xamarin.Forms project - Whose three big project platforms are iOS, Android and UWP.  So having this working in UWP would be great!

for that to work NGraphics has to support UWP which it does not at this moment:
https://github.com/praeclarum/NGraphics/tree/master/Platforms
(though i'm no expert in distinguishing between all those ms-platforms, there are just too many)

I've submitted a PR to NGraphics with that support, and just completed a PR for NControl as well @ #71
Please, if you could try it out and give feedback, that would be helpful.

I would love to have this on UWP! @TomSoderling how can I help to test your PR?

@philipogorman Thank you, I'd appreciate it. To do that, clone my forked repo from here: https://github.com/MobileComposer/NControl and check out the UWP_Support branch.
I've updated the readme file with some special instructions for UWP - be sure to look at those.  I believe you'll need Visual Studio 2015. (I'm using the Community version)

Good news! The required NGraphics PR was just merged. Hopefully that will be released soon and this PR can the move forward

thats great @TomSoderling !
I can't get your branch though, i see it in github, but my desktop git doesn't find it:
$ git branch -r
origin/Feature/52-ExposePlatformAsProperty
origin/Feature/UpgradeXamarinForms
origin/Feature/WindowsPhone81
origin/HEAD -> origin/develop
origin/develop
origin/master
origin/screenshots

That's strange. This is what I have:
$ git branch -r
origin/Feature/52-ExposePlatformAsProperty
origin/Feature/UpgradeXamarinForms
origin/Feature/WindowsPhone81
origin/HEAD -> origin/develop
origin/UWP_Support
origin/develop
origin/master
origin/screenshots
Maybe just download the whole repo as a zip?

Any ETA on UWP support?

Wondering the same. Also finding that the UWP Support branch causes a build failure when referenced in my project.

@jasells We're waiting on an official release of NGraphics still - this library depends on that.  I've tried reaching out to praeclarum a few times on twitter, but no response :/
@dapug: Can you elaborate a bit more? I'm using the UWP Support branch in our app right now. You can get it here: https://github.com/MobileComposer/NControl/tree/UWP_Support  Make sure you have the updated NGraphics dlls in a folder named "UWP_NGraphics_Assemblies" at the solution root.

Pull Request #71  is waiting on release from NGraphics.


Decrease wasm size

See https://github.com/integritee-network/parachain/issues/201

Closing with reasoning in https://github.com/integritee-network/parachain/pull/234


[SPARK-5107][Streaming][Log]: A trick log info for the start of Receiver

Receiver will register itself whenever it begins to start. But, it is trick to log the same information. Especially, at the "preStart()", it will also register itself. Just like the receiver has started twice. Just like the following partial info:

We can log the information more clearly. Like the "attempt times to start". Of course, nothing matters performance or use. After improve:

Test build #25105 has started for   PR 3912 at commit 433e638.

This patch merges cleanly.

Test build #25105 has finished for   PR 3912 at commit 433e638.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25105/
Test FAILed.

Test build #25106 has started for   PR 3912 at commit 19827e5.

This patch merges cleanly.

Test build #25106 has finished for   PR 3912 at commit 19827e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25106/
Test PASSed.

Test build #25139 has started for   PR 3912 at commit 505257c.

This patch merges cleanly.

Test build #25144 has started for   PR 3912 at commit 9abb0db.

This patch merges cleanly.

Test build #25139 has finished for   PR 3912 at commit 505257c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25139/
Test PASSed.

Test build #25144 has finished for   PR 3912 at commit 9abb0db.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25144/
Test FAILed.

Test build #25147 has started for   PR 3912 at commit 4489d38.

This patch merges cleanly.

Test build #25147 has finished for   PR 3912 at commit 4489d38.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25147/
Test PASSed.


WIP: Support docker build for s390x

As part of the work to support the Knative pipeline for the s390x architecture, the dependency of the docker image openzipkin/zipkin was identified (https://github.com/knative/eventing/blob/master/test/config/monitoring.yaml#L46).
This PR is to resolve the dependency.
The review can be started after the PR in docker-java (https://github.com/openzipkin/docker-java/pull/46) is merged. It will be on hold until then.

hmm we should probably discuss this first, as especially aarch64 was painful as node.js doesn't support it. What's the underlying motivation here? Which end user is asking zipkin specifically to support this?

hmm we should probably discuss this first, as especially aarch64 was painful as node.js doesn't support it. What's the underlying motivation here? Which end user is asking zipkin specifically to support this?

Thanks for the comment. I will close this and https://github.com/openzipkin/docker-java/pull/46 first and open up an issue for discussion.


Load dataset error

I use the following command to run lm-eval:
accelerate launch --multi-gpu --num_processes 2 \
    -m lm_eval --model hf \
    --model_args pretrained=${local_model_path} \
    --tasks mmlu \
    --batch_size 8 \
    --log_samples \
    --output_path ${output_path} \
    --trust_remote_code

but meet the problem:
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/__main__.py", line 461, in <module>
    cli_evaluate()
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/__main__.py", line 382, in cli_evaluate
    results = evaluator.simple_evaluate(
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/utils.py", line 397, in _wrapper
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/evaluator.py", line 235, in simple_evaluate
    task_dict = get_task_dict(tasks, task_manager)
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/tasks/__init__.py", line 618, in get_task_dict
    task_name_from_string_dict = task_manager.load_task_or_group(
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/tasks/__init__.py", line 414, in load_task_or_group
    collections.ChainMap(*map(self._load_individual_task_or_group, task_list))
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/tasks/__init__.py", line 398, in _load_individual_task_or_group
    group_name: dict(collections.ChainMap(*map(fn, reversed(subtask_list))))
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/tasks/__init__.py", line 398, in _load_individual_task_or_group
    group_name: dict(collections.ChainMap(*map(fn, reversed(subtask_list))))
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/tasks/__init__.py", line 314, in _load_individual_task_or_group
    return _load_task(task_config, task=name_or_config)
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/tasks/__init__.py", line 280, in _load_task
    task_object = ConfigurableTask(config=config)
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/api/task.py", line 818, in __init__
    self.download(self.config.dataset_kwargs)
  File "/usr/local/lib/python3.10/dist-packages/lm_eval/api/task.py", line 925, in download
    self.dataset = datasets.load_dataset(
  File "/usr/local/lib/python3.10/dist-packages/datasets/load.py", line 2132, in load_dataset
    builder_instance = load_dataset_builder(
  File "/usr/local/lib/python3.10/dist-packages/datasets/load.py", line 1890, in load_dataset_builder
    builder_instance: DatasetBuilder = builder_cls(
TypeError: 'NoneType' object is not callable

lm-eval==0.4.5 and datasets==3.1.0.
I also tried installing different versions of lm-eval and datasets, but it didn't work. Do you have any suggestions for solving the problem?

Solved by using

You can download datasets with VPN or replace the .py file from the huggingface repo with the local empty one.

By downgrading the package datasets version from 3.1.0 to 2.16.0, the problem is solved.

It seems downgrade datasets still does not work for me.

It seems downgrade datasets still does not work for me.
+1, it doesn’t work for me either.

Or guys could consider using this repo as an alternative: meta's evaluation repo


dst/leap: be more confident in announcement bits

Currently the threshold for the amount of announcement bits for DST/leap second is half the current minute value of more. This imposes a problem if the program is started after half the hour (at minute m), because in that case the number of announcements can never catch up with the minute value.

regression test is part of #3


raise MissingDataException when an Archive has no data, resolve #246

Resolve #246 by detecting when the data for an archive is empty and throwing a MissingDataException, rather than waiting for a later unexplained exception (in this case, a ValueError when trying to generate a new range for an updated index during activity computation).
This also creates a regression test which confirms this new behavior.

I'm getting the following deprecation warning when running your new automated test:

......./home/sb/projects/bigbang-multi/bigbang/tests/bigbang_tests.py:124: FutureWarning: from_csv is deprecated. Please use read_csv(...) instead. Note that some of the default arguments are different, so please refer to the documentation for from_csv when changing your function calls
df = pd.DataFrame.from_csv(path=test_df_csv_path)

Fixed the deprecation warning too.


fix(manage-merge-queue): improve jump queue handling

:pencil: Description

Fixes an issue where PRs get shuffled if multiple PRs jump the queue simultaneously.

:tada: This PR is included in version 1.61.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Provide error message wording to improve search hits

In the topic
Enabling Strong Authentication for .NET applications
https://docs.microsoft.com/en-us/windows-server/identity/ad-fs/operations/manage-ssl-protocols-in-ad-fs#enabling-strong-authentication-for-net-applications
Please add...
AD FS Management shows the following error message...
Error - AD FS Management
An error occurred during an attempt to read the federation metadata. Verify that the specified URL or host name is a valid
federation metadata endpoint.
Verify your proxy server setting. For more information about how to verify your proxy server setting see the AD FS
Troubleshooting Guide (http://go.microsoft.com/fwlink/?LinkId=182180)
Error message: The request was aborted: Could not create SSL/TLS secure channel
...if you attempt to add a relying party that is using TLS 1.2.  Configure .NET applications to use TLS 1.2 using the registry settings below.
The link in the error message is useless.  By showing the exact error message wording, search hits are likely to get to this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ae56e74-1346-a822-2800-70db6d365376
Version Independent ID: ccf848e1-5276-1f3f-73e8-036dba9c66a7
Content: Managing SSL/TLS Protocols and Cipher Suites for AD FS
Content Source: WindowsServerDocs/identity/ad-fs/operations/Manage-SSL-Protocols-in-AD-FS.md
Product: windows-server-threshold
Technology: identity-adfs
GitHub Login: @billmath
Microsoft Alias: billmath

The following users don't have valid GitHub IDs, or are not collaborators on this repo: ingridatmicrosoft
gh issue comment 2809 -b ingridatmicrosoft


feat(align-deps) allow exact version within range according to semver…

…Satisfies
Description
Add a new option (flag) --allow-exact-version to allow exact versions (don't throw an error) in package.json that are within range according to semverSatisfies.
Resolves #2983
Remaining tasks:

[ ] Add information about what changed (Changeset)
[ ] Add unit tests
[ ] Update documentation

Test plan

CI should pass, including updated unit tests
Declare a dependency to package.json with an exact version that is within the range of what the built-in capabilities define. Run align-deps with the new  --allow-exact-version flag and verify that no error is thrown.
Declare a dependency to package.json with an exact version that is within the range of what the built-in capabilities define. Run align-deps with the new  --allow-exact-version and --write flags and verify that nothing changes in package.json.
Declare a dependency to package.json with an exact version that is outside of the range of what the built-in capabilities define. Run align-deps with the new  --allow-exact-version flag and verify that an error is thrown for not correct version.
Declare a dependency to package.json with an exact version that is within the range of what the built-in capabilities define. Run align-deps without the new  --allow-exact-version flag and verify that an error is thrown for not correct version.
Declare a dependency to package.json with an exact version that is within the range of what the built-in capabilities define. Run align-deps without the new  --allow-exact-version but with --write flags and verify that the versions is overwritten with what is defined in built-in capabilities.
Declare a dependency to package.json with an exact version that is outside of the range of what the built-in capabilities define. Run align-deps without the new  --allow-exact-version flag and verify that an error is thrown for not correct version.

I marked the PR as Draft as I haven't finished with the implementation, e.g. I still need to add unit tests but I wanted to ask the project maintainers' opinion (especially @tido64 especially considering this is my first feature addition to this repo. I appreciate any help and suggestion!

thanks for sending it over!
Super small thing, can you run yarn change locally to generate the changesets ? that will make CI go green

thanks for sending it over! Super small thing, can you run yarn change locally to generate the changesets ? that will make CI go green

Sure, that's definitely on my list. You know what, I'll update the PR description with checkboxes for the remaining tasks and if I forgot something you can call that out!
Getting back to changeset, what kind of version bump you think this change warrants?

Getting back to changeset, what kind of version bump you think this change warrants?

@tido64 any preferences? If we want to be close to the semver definition I'd say we should go with minor:

MINOR version when you add functionality in a backward compatible manner

since it's a new feature

@balazsgerlei: Are you unblocked to continue working on this? If you don't have the time, let me know. I wouldn't mind taking over and pushing it over the finish line. 😄

@balazsgerlei: Are you unblocked to continue working on this? If you don't have the time, let me know. I wouldn't mind taking over and pushing it over the finish line. 😄

I've been indeed very occupied with personal stuff so I had little to no free time after work to attend to this. It would be still a nice challenge to finish this so I'll try to allocate some time for it and if I couldn't do it this week I'll let you know, but thanks for offering to take over!

I've been indeed very occupied with personal stuff so I had little to no free time after work to attend to this. It would be still a nice challenge to finish this so I'll try to allocate some time for it and if I couldn't do it this week I'll let you know, but thanks for offering to take over!

Take the time you need to finish this. No pressure. Just making sure you're not waiting to hear from us 😉

Okay, it took a while, I've finally had some time to update this.
I implemented the two distinct diff mode options, what I'm not sure about is how and where to handle if the option is not set correctly. It should not happen since the only two valid options are delcared in cli.ts though I feel like it should still be handled in e.g. check.ts. I could add a simple isDIffMode function similarly to isKitType in initialize.ts before diff is called in checkPackageManifest but I don't see any ErrorCode (which is what checkPackageManifest returns) that would be a good fit and I was hesitant to add a new ErrorCode for this, though that might be the best choice.
Can I ask for some guidence on this @tido64 @kelset ? Thank you!

Hey @balazsgerlei Tommy is currently on a break; I'll throw in my 2C$ in the meantime.
Because we are setting the options via .choices from yargs directly I don't think we necessarily need to handle the error case you are mentioning directly because it should be handled by yargs itself.
What happens currently if you try to run the command and passing an invalid option?

Hey @balazsgerlei Tommy is currently on a break; I'll throw in my 2C$ in the meantime.
Because we are setting the options via .choices from yargs directly I don't think we necessarily need to handle the error case you are mentioning directly because it should be handled by yargs itself.
What happens currently if you try to run the command and passing an invalid option?

The available options are listed and at the end it also tells you what you did wrong:

Invalid values:
Argument: diff-mode, Given: "xyz", Choices: "strict", "allow-exact-version"

That's what I also meant is that when using the script in Terminal you basically cannot pass the wrong argument to the actual logic, just that it would be more precise to handle that case somewhere e.g. in check.ts. That said, I'm more than happy to move forward like this, I would really like if I/we can get to the finish line. 😄
So I think I will continue with the unit tests like this and in the time being, let me know if you have another solution in mind or if @tido64 comes back and has a different opinion!

Thank you for the PR, we also need that feature in our team. I was about to implement that myself until i saw this PR 😄.
I have one small suggestion that would make this ideal for us, currently the diff-mode allow-exact-version only checks for the exact version, as the name suggests. It would be great if there would be another option, e.g. allow-in-range, which would allow all versions which satisfy the version range of the capability.
The following would be valid then:
capability: ^0.73.0
valid: ^0.73.1 ^0.73.9 0.73.2
invalid: ^0.74.0 0.74.0

It's been some time since this has received any updates so I'll bring it to the finish line. The new PR will also address @timostroehlein's request.

It's been some time since this has received any updates so I'll bring it to the finish line. The new PR will also address @timostroehlein's request.
Thanks for all your efforts!

Hi! Thank you and I'm sorry I could not carve out time to finish my PR. 😢
I'm glad that the feature got added though and I'll use it in the future for sure!


Make turso db destroy work in non-interactive environments

Luiz Benevenuto pointed out that turso db destroy, for example, is unusable in CI/CD environments because it's interactive. Let's add a --force or --yes flag to turso db destroy to make it usable in non-interactive environments.

We already support --yes... closing


v9.1.1 update composer dependencies

Current coverage is 76.37%

Merging #159 into master will not affect coverage as of 6d95660

@@            master    #159   diff @@
======================================
  Files           26      26
  Stmts          381     381
  Branches         0       0
  Methods         83      83
======================================
  Hit            291     291
  Partial          0       0
  Missed          90      90

Review entire Coverage Diff as of 6d95660

Powered by Codecov. Updated on successful CI builds.


Support number conversion for vector of vectors

Need to support std::vector<std::vector<NumericType>> (for example) so that an evaluated expression like [[1, 2, 3], [5, 6, 7]] be be converted into its intermediate object form, and then into the destination C++ type. This can be added to the existing templated conversions for numeric vectors.

https://github.com/pothosware/pothos/commit/27e12ff5fae356748fed68fa561355e761d6d6c7


[FEATURE] Top/recent hashtag flag

Is your feature request related to a problem? Please describe.
No, this tool is amazing. Thank you.
Describe the solution you'd like
Have a flag that allows scraping hashtags from either top posts, or most recent.

This is related to #3
Instamancer is built to gather data from requests by default. This tool is intended to be used as part of larger automated data pipelines, and given the nature of web scraping is more focused on stability than completeness.
However there is a clear interest in scraping the data directly from the webpage, so I will add a flag to enable this, but it won't be the default option.

Version 1.4.0 now scrapes the posts already included on the page when --full mode is enabled.

Version 1.4.0 now scrapes the posts already included on the page when --full mode is enabled.

Thank you! Again, awesome tool. Cheers.


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#314 d9a1871 Thanks @threepointone! - trigger a release

<EMAIL_ADDRESS>Patch Changes

#314 d9a1871 Thanks @threepointone! - trigger a release

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Startup probe type not supported

K8s 1.16 added a third type of probe, the Startup probe. This API only provides for Readiness and Liveness.
At first pass Startup looks just Liveness with different thresholds. However an app might want these to differ. For example an app may want the init probe to fail if a JDBC connection is unavailable (in case of a configuration error), but allow liveness checks to pass after startup (to avoid cascading failures in the event of a database outage).

Thanks for the report. This will be included in 3.1.

Thanks for the report. This will be included in 3.1.


Validate access tokens within server as pre-flight authentication

Is your feature request related to a problem? Please describe.
Missing/invalid OAuth/Jwt tokens required for authentication (not authorization) may allow us to reject requests without forwarding them to API servers. A feature implemented by API  gateways.
JWT spec: https://tools.ietf.org/html/rfc7519
**Supported Algorithms and Key Validation

Algorithm
Key Type
Key Category
Encoding

ES256 ECDSA using P-256 and SHA-256
ECDSA
public
PEM

ES384 ECDSA using P-384 and SHA-384
ECDSA
public
PEM

ES512  ECDSA using P-521 and SHA-512
ECDSA
public
PEM

HS256 HMAC using SHA-256
any string
secret
none

HS384 HMAC using SHA-384
any string
secret
none

HS512 HMAC using SHA-512
any string
secret
none

PS256 RSASSA-PSS using SHA256 and MGF1-SHA256
RSA
public
PEM

PS384 RSASSA-PSS using SHA384 and MGF1-SHA384
RSA
public
PEM

PS512 RSASSA-PSS using SHA512 and MGF1-SHA512
RSA
public
PEM

RS256 RSASSA-PKCS-v1.5 using SHA-256
RSA
public
PEM

RS384 RSASSA-PKCS-v1.5 using SHA-384
RSA
public
PEM

RS512 RSASSA-PKCS-v1.5 using SHA-512
RSA
public
PEM

NoSignature SignatureAlgorithm = "none"
none
none
none

Describe the solution you'd like

[x] configurable list of supported algorithms, inc. RS256
[x] validate the signature of OAuth token with symmetric key, where the secret key is stored within config.
[x] validate the signature of OAuth token with asymmetric key, where the public key is stored within config. support only public keys in PKIX. do not support private keys with PKCS8 passphrase.
[x] store algorithm for verification in config (to check against claims made by JWT tokens and prevent "none", see https://auth0.com/blog/critical-vulnerabilities-in-json-web-token-libraries/) and verify only against configured algorithm.
[ ] check token is not expired.
[x] load keys from disk and verify they are in the correct format upon server start.

Golang verification: https://github.com/lestrrat-go/jwx

bench test results for inline token validation:


Do not toggle directories on right-click

Fix #26

Ignoring the UI test failure. It's playwright being flaky.


Forbid copy constructor use which may ends in an extra decref on objects

The tests against postgresql with python 3 are ok

@mkleehammer what do you think of this patch ?

I should have merged this ages ago as I walked right into the use of the generated copy ctor.  I don't remember what the GCC issue is but it could have been that I didn't provide a body for the private functions.  I don't remember what platform / version it was.
Anyway, I had to manually redo this so I'm closing this.  Thanks.


Add Faker::House

Includes Faker::House.furniture, Faker::House.appliance, Faker::House.room

Ah sorry, yep, never noticed that. Will remove it


[RFE] Provide a mechanism to configure behavior of azure-init at runtime

Currently this is not a major issue as we don't have a lot of configurable options. However, as we start adding more features to make azure-init more useful and robust (such as logging, retries), we might need to provide a way for the users to configure azure-init behavior (such as where to put logging, the level of logging that should go to console, how many minutes to retry, etc...)
We can consider providing a config file in /etc/azure-init/azure-init.conf

Done in https://github.com/Azure/azure-init/pull/137


Add replacements for dependencies .

basically runs the dependency map replacements before variable replacement on task files, requirements.yml and README

LGTM


Update poolRegistry.tsx

approved.
What should I do next?

tx link: https://uncoverexplorer.com/extrinsic/6008517-1


Default colors in simulate's sensordata graph?

In this deom video of simulate.cc, the sensor-data has graphs of different colors, (I guess each signifying a type of sensor).
When I specify only a single jointpos sensor, the color of this sensor in the graph is red. However, when I add another sensor of type framepos, the framepos is now red while the jointpos changes to green. Seems like a priority based coloring scheme.
Is there a default color that we can assign to a type of sensor, so that colors do not change upon addition of new sensor types?

Default line colors are set here, with some default colors for a small number of lines here.
Simulate initialises the sensor figure here and draws the lines here. Since by the time this is called you have the sim object, which contains the model (sim->m_), you can override the line colors to whatever you want, given the sensors.
If you can come up with logic that you think is a strict improvement over the current state of affairs, feel free to send us a PR.


Return None if no rows are found in helper functions

I am attempting to use fetch_one and fetch_all to return a user based on a provided email.
If the email does not exist, it will throw an exception instead of returning None due to:
File "D:\Programming\Git\aikido-suite\.env\Lib\site-packages\quart_db\backends\aiosqlite.py", line 124, in fetch_one
    return {key: row[key] for key in row.keys()}
                                     ^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'keys'

I believe it is beneficial to have a check for row count and return a None instead for my function to handle.

Thanks fixed in 83d069bd73be02bb97fd42134e591db44f9b2751

Released in 0.8.0


Adding Docstrings and Typehints for space_ops

In manim, there are lots of space_ops:
https://docs.manim.community/en/latest/reference/manim.utils.space_ops.html
which neither have docstrings, nor type hints.
This might be a nice take for people who contribute to the repo the first time :)
It is basically e.g. changing
def cross(v1, v2):
    return np.array(
        [
            v1[1] * v2[2] - v1[2] * v2[1],
            v1[2] * v2[0] - v1[0] * v2[2],
            v1[0] * v2[1] - v1[1] * v2[0],
        ]
    )

to
def cross(v1: Union[np.ndarray, List], v2: Union[np.ndarray, List])  -> np.ndarray:
"""Calculate the cross product."""
    return np.array(
        [
            v1[1] * v2[2] - v1[2] * v2[1],
            v1[2] * v2[0] - v1[0] * v2[2],
            v1[0] * v2[1] - v1[1] * v2[0],
        ]
    )

etc.

I’ll do this after the PR #1354 is done

@Nikhil0504 It's merged now

def shoelace(x_y: Union[np.ndarray, List]) -> np.ndarray:
    """2D implementation of the shoelace formula.

    Returns
    -------
    :class:`float`
        Returns signed area.
    """
    x = x_y[:, 0]
    y = x_y[:, 1]
    area = 0.5 * np.array(np.dot(x, np.roll(y, 1)) - np.dot(y, np.roll(x, 1)))
    return area

It is like this only right?


Add a requireEditPermissions method to the currentSession service

This method can be used to automatically redirect users to the route-not-found page if they don't have the needed permissions. It works very similar to ember-simple-auth's requireAuthentication method.
This version has the benefit that the url doesn't change to "/pagina-niet-gevonden" so it works similar to traditional websites.
Usage:
  beforeModel() {
-    if (!this.currentSession.canEdit) {
-      this.router.transitionTo('route-not-found', {
-        wildcard: 'pagina-niet-gevonden',
-      });
-    }
+    this.currentSession.requireEditPermissions(transition);
  }

This can be rolled out to all the pages that need it if we want.

I extracted this from the change events branch since it's a standalone feature.

This looks interesting: https://github.com/simplabs/ember-error-route


Converge target and exclude semantics with Gatekeeper match semantics

https://github.com/forseti-security/config-validator/pull/37#discussion_r287542782

Based on the conversation, we should move them to the top level:
match:
   target: ...
   exclude: ...

The config validator library now accepts both formats. TF validator has been updated. For Forseti, the upcoming 2.17 release should have this change as well.
We can consider removing the support for old format in Forseti 2.18. @joecheuk WDYT?

Does removing supports meaning its gonna fail when consuming the old policies or its just gonna ignore the match field?


Two nested img tag not in row as html default

In html like that

But it isn't working in react-native-render-html, two image always is in new row

I have the same problem, did you fix it ?

I have the same problem, did you fix it ?

This is a limitation of the library: block elements cannot be displayed inline. We are in the process of cleaning the issue tracker to make it manageable. Because your issue did not follow our contribution guidelines, it will be closed. But you can ask this question on stackoverflow. Don't forget to add the react-native-render-html tag. We are notified on this tag, and will be happy to help you here.


don't show trace for --help without FLASK_APP

Fixes #2741.

Thanks for working on this. After looking at how the error messages work right now, I've concluded that this isn't the correct fix. The tracebacks were added in #2208. https://github.com/pallets/flask/pull/2209#issuecomment-338401084 suggests hiding the traceback and showing the message only for NoAppException, and showing the traceback for other exceptions. I independently implemented the same thing before I saw that comment, so I'm going to go with that.


Suggestion: no trailing semicolon

Copying suggestion from https://github.com/palantir/tslint-react/issues/116:

We had a case in our code where a semicolon was accidentally used at the end of a line of a tsx statement. Since this is almost always unintended, it makes sense to have a lint rule to warn against it. The rule would warn against code like the following:
<div>
  <SomeComponent/>;
</div>

/cc @JKillian

This seems like a reallllllly niche rule for something that almost never happens :-/

Happened to me loads of times. The linked issue also has some interest suggesting it's not just me.

This seems like it would be handled by the jsx-no-literals rule in a much more generic way.

That seems quite extreme for what we're trying to achieve here. I'm fine with literals, just not trailing semicolons, which usually get left behind during redactors

+1 for this being useful

👍 I've fixed instances of this bug four or five times in production. I'd love a linter too!

Not the best solution, but it works for me.
    "no-restricted-syntax": [
      "error",
      {
        selector: "JSXElement > JSXText[value=/^;\n/]",
        message: 'Please use proper case for the text node "semi" after JSX elements.',
      },
    ]

It works for a semicolon at the end of the line after a jsx tag.


Can't change R Engine in R Tools for Visual Studio

Hi,
I have a previous installation of base R v3.3.1 with Rstudio. After manual download and installation (with default configuration) of Visual Studio, RTVS, and MS R Client, I discovered that the R Engine was still set up with Base R.
When I checked R Tools > R Tools > Advanced > R Engine , I can only find "Code Page" as an attribute to change. Scrolling up and down, I can find below the header "General", the attributes "CRAN Mirror" and "Survey/News Check" to change. I've looked at https://msdn.microsoft.com/microsoft-r/r-client-get-started#step-2-configure-your-ide but it didnt help.
My question, how can I change the R Engine within RTVS to use Microsoft R Client?
Thanks in advance,

Try R Tools | Windows | Workspaces. It shows all available R engines you can use. The window is not visible in VS general profile but if you switch to Data Science layout in R Tools | Data Schience Settings you'll get it on top.

http://microsoft.github.io/RTVS-docs/remote-execution.html

@MikhailArkhipov
Its worked! Thanks!!


Convoy Daemon is not starting

Hi,
I'm trying to get a Convoy Daemon running following the quickstart instructions mentioned in the readme. However, when I run the following line:
sudo convoy daemon --drivers devicemapper --driver-opts dm.datadev=/dev/loop5 --driver-opts dm.metadatadev=/dev/loop6
It runs up to a certain point, and then freezes. This is the result:
DEBU[0000] Found existing config. Ignoring command line opts, loading config from /var/lib/rancher/convoy  pkg=daemon DEBU[0000]                                               driver=devicemapper driver_opts=map[dm.datadev:/dev/loop5 dm.metadatadev:/dev/loop6] event=init pkg=daemon reason=prepare root=/var/lib/rancher/convoy DEBU[0000] Found created pool, skip pool reinit          pkg=devmapper DEBU[0000]                                               driver=devicemapper event=init pkg=daemon reason=complete DEBU[0000] Registering GET, /snapshots/                  pkg=daemon DEBU[0000] Registering GET, /backups/list                pkg=daemon DEBU[0000] Registering GET, /backups/inspect             pkg=daemon DEBU[0000] Registering GET, /info                        pkg=daemon DEBU[0000] Registering GET, /volumes/list                pkg=daemon DEBU[0000] Registering GET, /volumes/                    pkg=daemon DEBU[0000] Registering POST, /volumes/create             pkg=daemon DEBU[0000] Registering POST, /volumes/mount              pkg=daemon DEBU[0000] Registering POST, /volumes/umount             pkg=daemon DEBU[0000] Registering POST, /snapshots/create           pkg=daemon DEBU[0000] Registering POST, /backups/create             pkg=daemon DEBU[0000] Registering DELETE, /snapshots/               pkg=daemon DEBU[0000] Registering DELETE, /backups                  pkg=daemon DEBU[0000] Registering DELETE, /volumes/                 pkg=daemon DEBU[0000] Registering plugin handler POST, /VolumeDriver.List  pkg=daemon DEBU[0000] Registering plugin handler POST, /Plugin.Activate  pkg=daemon DEBU[0000] Registering plugin handler POST, /VolumeDriver.Create  pkg=daemon DEBU[0000] Registering plugin handler POST, /VolumeDriver.Remove  pkg=daemon DEBU[0000] Registering plugin handler POST, /VolumeDriver.Mount  pkg=daemon DEBU[0000] Registering plugin handler POST, /VolumeDriver.Unmount  pkg=daemon DEBU[0000] Registering plugin handler POST, /VolumeDriver.Path  pkg=daemon DEBU[0000] Registering plugin handler POST, /VolumeDriver.Get  pkg=daemon
When I exit, the following error is shown:
Caught signal interrupt: shutting down. DEBU[0235] Cleaning up environment...                    pkg=daemon ERRO[0235] http server erroraccept unix /var/run/convoy/convoy.sock: use of closed network connection  pkg=daemon
Am I doing something wrong? Is there a bug somewhere? I'm fairly new with docker and rancher, so any help would be really appreciated :)

It's daemon... You need to run convoy or docker cmdline to use the service it provides.


[BitSail-437][Connector] V1 interface supports reading data from MongoDB source

Prepare a Pull Request

Title: [BitSail-437][Connector] V1 interface supports reading data from MongoDB source

Fixes: #437

Please change the PR title and the related issue number refer to the following description.
The above XYZ must be replaced with the actual GitHub Issue number, indicating that the current PR is used to solve the problem described in this Issue.
If you don't find an Issue that matches your changes, please Create Issue first, then commit this PR.
For more info about the contributing guide, see: Contributing Guide

Motivation
V1 interface supports reading data from MongoDB source.
Modifications
Refer the #104, migrate MongoDB legacy connector to adapt the V1 interface.
Verifying this change
Please pick either of the following options.

[x] This change added tests and can be verified as follows:

Added integration tests for MongoDB source: MongoDBSourceITCase

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (not applicable)
If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation (provide later...)

The integration test failed, but I saw that this was caused by the failure to download the jar of Kudu.
And it did not execute the test cases I submitted this time. How to deal with this situation?


jmeter ships with a vulnerable version of log4j2

Ren (Bug 65748):
jmeter 5.4.1 ships with log4j2 in version 2.13.3 which is vulnerable to the Apache Log4j CVE-2021-44228 vulnerability. Older versions also ship with affected versions of log4j2.
The log4j2 library should be updated to 2.15.0 containing a fix.
Votes in Bugzilla: 2
Severity: normal
OS: All
Duplicates:

https://github.com/apache/jmeter/issues/5603
https://github.com/apache/jmeter/issues/5604
https://github.com/apache/jmeter/issues/5605
https://github.com/apache/jmeter/issues/5606
https://github.com/apache/jmeter/issues/5618
https://github.com/apache/jmeter/issues/5645

Fixed in 5.5


Updated API for arbitrary Key types in LettuceBasedProxyManager without Mapper

Hi @vladimir-bukhtoyarov
We recently discussed allowing for arbitrary key types for Redis Proxy Managers here https://github.com/bucket4j/bucket4j/discussions/358
As part of the discussion, you made it clear we wanted to rely on external APIs as much as possible, and with this I agree.
For Lettuce however, an option that just came to me recently was that if Bucket4J were not to be responsible for defining a RedisCodec that would define how the keys would be serialized, an option would be to still allow the user to define their own RedisConnectoon. This would allow people to create their LettuceProxyManager using any connection they may already have defined as long as it allows for byte array value type, instead of having to use Bucket4J Mapper class and creating additional dependency.
Doing this does not add any more dependency to Bucket4J on external APIs, but opening up the generic typing gives a bit more flexibility to users.
And if someone still really needed to map their keys instead of going via a RedisCodec, they can use this change https://github.com/bucket4j/bucket4j/pull/360

Looks good!

It will be released in June, together with #372


BUILD: Update base branch with release/1.0.2

BUILD: Release ARTKIT 1.0.2

[x] Have you followed our PR guidelines document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description
Update default branch's commit history to reflect 1.0.2 changes
Issue number and link:
New Feature Submissions:

[x] Does your submission pass tests?
[x] Have you lint your code locally before submission?

Changes to Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully run tests with your changes locally?

No PR required for this, closing.


[WIP] Clean-up storage specific functions in tests/utils.go

What this PR does
This PR aims to clean-up most of the storage-specific functions in tests/utils.go, so we move the logic to the specific tests instead of branching the setup.
In progress. Want to clean-up the commits a bit.

Fixes #
Release note

NONE

/test all

Opening a new PR to arrange the commits a bit better.


Newsfeed suspend

When the newsfeed is hidden, the stories continue to show, causing all stories shown during that time to never be shown. An implementation of the suspend/resume functions could be added to pause the update timers.

The news items will be repeated until their outdated anyway. So I don't see the real issue here?

This is definitely a minor edge case, but consider the following example:

There are 5 news stories in the feed, each displayed for 10 seconds
Another plugin (such as MMM-Carousel) hides the news feed plugin every 40 seconds for a duration of 10 seconds
In this case, the fifth story would never be displayed

Ah yes. I understand. Feel free to send an PR. Oherwise I'll look into it when I have some spare time.

@MichMich please explain your comment "the news item will be repeated until they are outdated anyway".what makes it outdated? I am finding that news items stay (so far up to 20 days) and the news feeds do not update.  Please explain if I am doing something wrong, I can't get answers in the forum.
Thanks!
Nathan

It will just repeat the items in the RSS feed. So if the RSS feed if updated (with old stories removed), they won't show up anymore.

@MichMich Sorry if I'm being dense, but I'm not following.  Right now my MM news feed does not update.  It is showing news headlines from 20+ days ago.  If I reboot the pi it will update the headlines for a few days and then display old headlines going forward.
Is that expected behavior?  A bug?  Something in the way I've configured it?
Thanks,
Nathan

Maybe this helps for you? https://forum.magicmirror.builders/topic/1429/mmm-newsfeed

@MichMich Cool, I'll give that a try.  BTW, thanks so much for developing and releasing the software.  Everyone who sees my MM goes googly eyed.  Somehow my wife agreed to let me cut a hole in the bathroom wall and install it so it's flush with the wall and it came out great (I have a woodworking shop in my basement so I was set on the woodworking side).  Here's how it came out, if you are interested: http://imgur.com/a/n63NT
Also, I was at the Consumer Electronics show in Las Vegas earlier this month and I saw a company had a version of the magic mirror they were showing.  I can't remember the name of the company, though.
Thanks,
Nathan

@deadherring Could you talk to my wife about cutting a hole in our wall? ;)


Font-family issue

Challenge Set the Font Family of an Element has an issue.
User Agent is: Mozilla/5.0 (Linux; Android 5.0.2; SM-T350 Build/LRX22G) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.98 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 But your code is incorrect.
GitHub Issues are for reporting bugs on the website only.
Please use the Help chat room for getting challenge related help.
Happy Coding!


feat(dictionaries): adds methods and tests

Fixes #1248

I wonder if the tests are failing because we are doing account tasks in parallel, what do you think @chloelbn?


[Annoucement][Draft] IOptionsSnapshot is now a scoped service

From @Tratcher on Tuesday, July 18, 2017 3:35:23 PM
In 1.x IOptionsSnapshot would only reload based on notified changes to its data source (e.g. config). In 2.0 the service is now scoped and reloaded per request instead.
IOptionsMonitor is the replacement.
Copied from original issue: aspnet/Options#217

From @Tratcher on Wednesday, July 19, 2017 9:50:16 AM
Note the docs also need to be updated. https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration


Add ddvk-hacks

Patches Xochitl on install, restores original binary on remove. Tested on rM1, version <IP_ADDRESS>.

awesome! this day has been a long time coming :-D
cc @ddvk

awesome! this day has been a long time coming :-D
cc @ddvk

Works great on my rM 2! Best tag me in discord once the details are fleshed out. I can re-review (and most likely approve) it then.

Works great on my rM 2! Best tag me in discord once the details are fleshed out. I can re-review (and most likely approve) it then.

Just waiting on input from @ddvk before approving.

Just waiting on input from @ddvk before approving.

Just waiting on input from @ddvk before approving.

what happens after the device has been upgraded?
the way i see it, the package has to be foce reinstalled

Just waiting on input from @ddvk before approving.

what happens after the device has been upgraded?
the way i see it, the package has to be foce reinstalled

To loosly repeat some of the discussions in discord relating to this ([starting here])(https://discordapp.com/channels/385916768696139794/756853330382422037/804318381644972033)):
The package doesn't contain any files outside of /opt and /home/root so I won't get automatically reinstalled after an upgrade. This behaviour also may not be fully wished or has to be altered since right after an update, there will most likely not be a patch for the new xochitl.
There was also some discussion on how to treat and where to store the backup of the xochitl binary do we don't accidentally downgrade it.

To loosly repeat some of the discussions in discord relating to this ([starting here])(https://discordapp.com/channels/385916768696139794/756853330382422037/804318381644972033)):
The package doesn't contain any files outside of /opt and /home/root so I won't get automatically reinstalled after an upgrade. This behaviour also may not be fully wished or has to be altered since right after an update, there will most likely not be a patch for the new xochitl.
There was also some discussion on how to treat and where to store the backup of the xochitl binary do we don't accidentally downgrade it.

So what is this waiting on?

I don’t see any remaining issue with the PR. So this is just waiting on someone to review it.


Transition speed issue

Thanks for this tiny great plugin!
My issue is that tweaking the 'transition speed' value does not seems to work.
Here the example I tweak from downloaded pack.
$('#tabs').smartTab({
     autoProgress: false, stopOnFocus:true, transitionEffect:'vSlide',
     transitionSpeed:'5400' // from default 400 to  5400
});

Thanks
Rex

There is a mistake in the example and in default setting.
the transition speed should set as a number not as a string, ie without quotes.
so please set it as following, sorry for the delay
$('#tabs').smartTab({
   autoProgress: false, stopOnFocus:true, transitionEffect:'vSlide',
   transitionSpeed: 5400 // from default 400 to  5400
});


Added two more filters in the filters list

Added a contrast grayscale filter which is quite nice and also a vignette filter. The vignette filter could maybe in the future be used as a switch in the gui to add vignette to any filter.
Use if you want to! :)

Thanks!!!


Use - for naming service and container ports

Takes inspiration from https://github.com/envoyproxy/gateway/pull/2973 to name port, not off the listener but off the port-proto ensuring that patch (during updates) also works
Fixes: https://github.com/envoyproxy/gateway/issues/3111

cc @cnvergence @ardikabs

that was fast!

@arkodg
In my example we have 4+ listeners attached to a merge host gateway using the listeners name "https". Every time the gateway checks to see if the deployment is in-sync the container port name is different as its randomly getting a different listener name, this causes the deployment to get updated as the specs do not match.
This is tested with image envoyproxy/gateway-dev:5a15902 which is the tag which contains the backports.

Here is the EnvoyProxy patchs for people to use if they are having the same problem until this resolved.
    envoyProxy:
      provider:
        kubernetes:
          envoyService:
            patch:
              value:
                spec:
                  ports:
                  - name: https
                    port: 443
                    protocol: TCP
                    targetPort: 10443
          envoyDeployment:
            patch:
              value:
                spec:
                  template:
                    spec:
                      containers:
                      - name: envoy
                        ports:
                        - containerPort: 10443
                          name: https
                          protocol: TCP

/retest

/retest

lint fails
Error: : # github.com/envoyproxy/gateway/test/e2e/tests
Error: test/e2e/tests/gateway_infra_resource.go:25:2: "github.com/envoyproxy/gateway/internal/utils" imported and not used (typecheck)
Error: could not import github.com/envoyproxy/gateway/test/e2e/tests (-: # github.com/envoyproxy/gateway/test/e2e/tests
Error: test/e2e/tests/gateway_infra_resource.go:25:2: "github.com/envoyproxy/gateway/internal/utils" imported and not used) (typecheck)
Error: could not import github.com/envoyproxy/gateway/test/e2e/tests (-: # github.com/envoyproxy/gateway/test/e2e/tests
Error: test/e2e/tests/gateway_infra_resource.go:25:2: "github.com/envoyproxy/gateway/internal/utils" imported and not used) (typecheck)


A little suggestion

This attribute will have better returns ""

middleName

you're suggesting that middleName should return "" if there is no middle name.

in js its more typical to see null over empty string. The fact that thumbnailPath is an empty string is more an artifact of the way the original implementation was written. @zhongjie-chen can you clarify why you prefer empty string?

closing as nonissue.


Fix erroneousFields checking in hasError

Make an extra check if erroneousFields is empty or not (and minor whitespace issues ;-))
Should fix #8

I'd rather solve this by simply initializing erroneousFields in the constructor. I've modified your commit and will merge in #13. Thank you for your contribution :-)


[BUG] CartLineQuantityAdjustButton doesn't trigger analytics ADD_TO_CART / REMOVE_FROM_CART

Describe the bug
When the user opens a cart and wants to adjust the number of products corresponding analytics events should be called.
To Reproduce

Subscribe to ADD_TO_CART / REMOVE_FROM_CART events in the AnalyticsListener
Add product with quantity "2" to the cart
Open the cart
Click "-" to change product quantity from "2" to "1"
Click "+" to change product quantity from "1" to "2"

Expected behaviour
You should see calls to REMOVE_FROM_CART and ADD_TO_CART
Additional context
When you change the number of products from "1" to "0" then REMOVE_FROM_CART triggers
When you change the number of products from "0" to "1" then ADD_TO_CART triggers

Hydrogen version: 1.6.6

@iliapir2 I think this is working as intended. From a SFAPI perspective, adjusting the quantity isn't actually adding or removing items from the cart, rather it is adjusting an existing line item. Instead use the event ClientAnalytics.eventNames.UPDATE_CART for events when the quantity changes.