How to solve this no checkpoints found problem?

Hi,
after some unsuccessful training, when I restart the training again, I keep receivinig error report saying:
ERROR Unexpected exception: no checkpoints found in ...
Even if i reinstall this software, I still cannot train.
I don't understand how exactly the entire program is working, I want to clean everything up and retrain the demo model "en to it", how can I do this? Why I need checkpoint to restart the training?
By the way, I am also curious how Deep Learning (if it is really being used) is working in Java? I only have some knowledge in Tensorflow and PyTorch in Python.
I will appreciate any help or suggestions, thanks in advance.
Best,
Ge Li

Hi,
ModernMT is storing your model in the "engines" subfolder and some temporary data in the "runtime" subfolder. If a previous storing exists, it tries to start from last state, and the one you have seems to be an invalid one (no network state stored).
If you want to restart from scratch, simply delete the contents of these two folders ("engines", and "runtime").
For your Deep Learning question, the MMT team could bring you more precise answers. As far as I know, in MMT it's not directly from Java: for GPU parts, Java codes are calling Python codes.
Etienne

Hi @Fitz13009
Etienne is almost right how to reset an engine.
You have to delete directories engine/ENGINE and runtime/ENGINE, where ENGINE is the name you give to your engine. By default ENGINE is default.
To resume a training of an engine, which was not completed, you have to re-run the mmt create adding the flag --resume.
Regarding the error you reported
ERROR Unexpected exception: no checkpoints found in ...
please report which was the set of commands which generates the error so that we can reproduce it, together with the full content of the log file
runtime/ENGINE/logs/node.log
and the list of the files in the directory
runtime/default/tmp/training/
and its subdirectories.
Finally, ModernMT exploits pytorch and fairseq for the core computation (training and decoding of neural networks).
Java code is mostly used for interfacing the core part with the final user, for normalisation and tokenisation of text, and similar operations.

Hi Etienne and NIcola,
thank you for your replies. I found the problem comes from the train-steps. In the readme, it is mentioned that the demo should be run like:
./mmt create en it examples/data/train/ --train-steps 10000
I wanted to save time, so I set the train-steps to 10 and get the error. When I changed it to 100 or 1000, the bug doesn't show up...
Best,
Ge Li

Hi @Fitz13009
from the training.log it is seems that training worked properly
And so, the system should have stored the model in the directory engines/default
Specifically, in this directory there should be (at least) these files:

models/decoder/en__it/model.pt
models/decoder/en__it/model.vcb
models/decoder/model.conf
engine.xconf

Is this your case?
If so could you please run
mmt start -v 2
and check if the log file exists
/home/lige/Softwares/mmt/runtime/default/logs/node.log
and provide us it for our debugging

Hi,
sorry for the late reply, I have all the four files but when I run the command:
./mmt start -v 2
I receive the same complaints:
failed to start node, check log file for more details: /home/lige/Softwares/mmt/runtime/default/logs/node.log
and I could not find the file "node.log" in the desired directory...
Best,
Ge Li

@Fitz13009

@nicolabertoldi ?

@Fitz13009
Are you sure that you the the installation succeded?
What the output of the command ./mmt status?
Which is the content of models/decoder/model.conf and engine.xconf?
PS: In the future, please open a new ticket if the problem is different.


[webapi][XWALK-3335] Add textarea placeholder test

Impacted tests(approved): new 1, update 0, delete 0
Unit test platform: [Android]
Unit test result summary: pass 1, fail 0, block 0

For new created tests for W3C specs, please submit to W3C firstly and then integrate back after it is accepted.


composeAll and multiple extraneous data fetches and renders

See https://github.com/TobyEalden/komposer-weirdness for example/reproduction.
I may have misunderstood the intention of composeAll, but even if that's the case, it appears to behave differently on the first render compared to when a property changes.
It seems that after the initial render, any property change will re-run ALL composers and the final component before the onData is called.
This means that when a property is updated, the top-level composer will run and so will the
next level composer and so will the render method on the component, all BEFORE the onData of the top-level composer has run. When the top-level composer is ready and calls onData, the next level composer will run again and the component will also render BEFORE the composer calls onData. Finally when the last composer calls onData the component will render again - that's 3 times for one property change.
When first run, the output below is produced as expected.
initial app data: 53
my-component.js:38 composer2 running, data from app is 53
my-component.js:41 composer2 ready, sending 54
my-component.js:29 composer1 running, data from c2 is 54
my-component.js:32 composer1 ready, sending 55
my-component.js:14 MyComponent rendering: 55

After hitting the update button, which triggers a prop change, the output becomes:
new app data: 77
my-component.js:38 composer2 running, data from app is 77
my-component.js:29 composer1 running, data from c2 is 54  <<<< runs before onData, with stale props
my-component.js:14 MyComponent rendering: 55              <<<< spurious render
my-component.js:41 composer2 ready, sending 78
my-component.js:29 composer1 running, data from c2 is 78  <<<< as expected
my-component.js:14 MyComponent rendering: 55              <<<< another spurious render
my-component.js:32 composer1 ready, sending 55
my-component.js:32 composer1 ready, sending 79
my-component.js:14 MyComponent rendering: 79              <<<< third render

It's possible to add shouldComponentUpdate to avoid the extraneous renders, but there's no clean way to prevent the last composer from running multiple times (and potentially duplicating expensive data fetch operations, e.g. http.get instead of setTimeout) without breaking the pattern.
A workaround is to call onData twice from composer2 - initially passing null as the c2Data value, and changing composer1 to check for null before calling setTimeout (fetching data).
e.g.
function composer1({ c2Data },onData) {
  if (c2Data) {
    console.log("composer1 running, data from c2 is %d",c2Data);
    setTimeout(function() {
      c2Data++;
      console.log("composer1 ready, sending %d",c2Data);
      onData(null,{ c1Data: c2Data });
    },2000);
  }
}

function composer2({ appData },onData) {
  console.log("composer2 running, data from app is %d",appData);

  // Call onData immediately here with no data.
  onData(null,{c2Data: null});

  setTimeout(function() {
    appData++;
    console.log("composer2 ready, sending %d",appData);
    onData(null,{c2Data: appData });
  },2000);
}

I'm guessing this is by design given the fundamental nature of it, but am I missing something?

No response at all?
Took some time and effort to put together that example. That's an hour of my life I'll never get back!

For what its worth Toby, I thought your example was wonderful. =P
I'm sure the team is just super busy.
Hope you get an answer soon.

@TobyEalden Sorry for the late answer. We know this will be fixed with 2.x
See: https://github.com/kadirahq/react-komposer/issues/123

This is fixed with v2 and I've released it.
Check the section on Performance.


[Feature] Validate current csv list with DoH PDF

See the pdf here. https://sacoronavirus.co.za/wp-content/uploads/2020/03/Latest-confirmed-cases-21-March-.pdf.pdf.pdf
DoH has now created a sheet inside the PDF that has some patient demographics. Can we validate these with our confirmed list.

Latest-confirmed-cases-21-March-.pdf.pdf.pdf

@vukosim So ,  I took quick look at the files to compare the lists and  try to validate - here are some  differences that are easy to spot

Gender counts = The gov doc has 96 female whereas our confirmed list has 88 females and 5 not specified

2.Provinces  = KZN in the gov doc has 27 confirmed cases but we have 26 confirmed cases and the WC has 74 in the gov doc while we have its cases as 75
Other than these 2 provinces - others seem to be ok.

Age = In the gov doc - case #. 4's age is 37  not 38 as we have it. There is no 51 years old male in KZN from the government doc

There seems to be a lot of minor differences in terms of age and places - what is the best way to outline these differences instead of commenting them out?

I will take a look tonight. We need a few people to validate so might slow down for the next 24 to 48 hours so that we can validate. We are unfortunately not getting data from NICD statements anymore.


Refactor impress internal dependencies loading

Including remove access to worker_threads from application
Refs: https://github.com/metarhia/impress/issues/1626

[x] tests and linter show no problems (npm t)
[x] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)
[x] description of changes is added in CHANGELOG.md

Landed in https://github.com/metarhia/impress/commit/e2f45c9da0e1f37a221e5c617d779c5eee395244


Put the mineflayer bot in a worker

After doing some profiling, I've seen that the main thread spend too much time in the network. This is what is causing the drop of fps and stuttering.
This is best shown when loading chunks but even sending the position packet every tick is affecting the fps.
The only way to fix it is to put the websocket connection in a worker thread and the easiest way to do it is to put the bot in it.
This will require a big refactor and a change of project design because the bot functions would have to be accessed through messages.
This should be done ASAP (because of the project design change).
Alternative design is to do like prismarine-viewer or web-minecraft and have the bot on the server side, but that raise the same design issues (communicating with server instead of the worker) and is less portable, so I think the worker is the best solution.

Makes sense.
Maybe we could do a bot-like api that would actually use messages ?
So from the user point of view, he's using the same API as now.
On Sun, Mar 7, 2021, 02:53 Karang<EMAIL_ADDRESS>wrote:

After doing some profiling, I've seen that the main thread spend too much
time in the network. This is what is causing the drop of fps and stuttering.
This is best shown when loading chunks but even sending the position
packet every tick is affecting the fps.
The only way to fix it is to put the websocket connection in a worker
thread and the easiest way to do it is to put the bot in it.
This will require a big refactor and a change of project design because
the bot functions would have to be accessed through messages.
This should be done ASAP (because of the project design change).
Alternative design is to do like prismarine-viewer or web-minecraft and
have the bot on the server side, but that raise the same design issues
(communicating with server instead of the worker) and is less portable, so
I think the worker is the best solution.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PrismarineJS/prismarine-web-client/issues/64, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR437TFFHKLAIJ4EWRZGZDTCLMA7ANCNFSM4YXKPVAQ
.

Looking at the code, it's mostly about doing that for pworld.
The rest is mostly about passing events per messages, and a few mineflayer functions
Putting most of the remaining state will help on this.

Yes the first steps of the work are in pworld. We also need a modification of pviewer to allow this kind of data transfer:
server => bot worker => pviewer worker(s) => main thread (render thread)
Alternatively we could also do:
server => bot worker => pviewer worker(s) => bot worker => main thread
That would require less modifications put will do 1 extra transfer (shouldn't cost much as arraybuffer can be transfered instead of copied).
Reproducing the mineflayer api with messages would be painful to maintain so we have to find a way to automate this. Do you have some ideas ?

That's probably not needed anymore as we fixed the issue with the network.

yeah it's lower priority at least
let's let it open and we'll see if we think we need it later

seems webmc does that https://github.com/michaljaz/web-minecraft/blob/threejs-javascript/src/scripts/proxy/Proxy.worker.js
maybe we should still do this issue

Do we have evidences that the mineflayer bot is causing some issues ? Having it in a worker would be way less convenient for everything so i don't think we should do it unless we have to.
Btw, webmc doesn't have the fixes we have on the network, so they have to use a worker to not slow the main thread. Also its not faster than what we have, they only have a shorter render distance and less complex rendering.

I do see that fps are lower at the beginning when mineflayer is highly active
I agree about convenience. If we were to do it, it should still be as convenient by using js proxy (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy) and some looping over all methods/attributes , so the fake bot object behaves the same as the normal one.
Until we have a solution that is as convenient as the current thing, or that we are forced to do it due to performance, let's keep things like this


SCM-TFVC: Annotate is performed file by file, even though without violation

When active, the plugin seems to annotate all files one by one, which can be seen in a profusion of requests in Fiddler. It seems to concern every file, not only those where violations were detected.
For a consequent project of more than 1000 files (with only 5 where violations actually occur), it runs for more than 1h of non-stop annotation.
Is it expected to remain that way or is there an optimisation in the works?

Sorry for strong delay for my comment...
I've taken responsibility for the repository when it had not maintainer anymore. So, I'm not sure in all details because I'm not the original developer.
According to my understanding there is no optimization possible on plugin side. It implements an interface of the SonarQube analyzer. The plugin is requested to provide annotation information on request of the analyzer/server.
We are analyzing several large projects with 2000 or 3000 files for many year. We did not face any issue so far.

Hello Lukas,
Thanks for the answer ;)
The configuration in question in my case was a TFS server on another
continent, a code base of more than 40000 files.
The annotation of files one by one, would amount to a total of 3 to 4 hours
(just for annotation)
But hopefully, the code in the plugin is optimized so that files that are
not modified are not annotated again, which mildens the problem for
subsequent analyses.
Not sure anything can be done indeed about TFS, probably a limitation in
their API.
Best regards,
On Tue, 6 Apr 2021 at 11:38, Lukas Grützmacher @.***>
wrote:

Sorry for strong delay for my comment...
I've taken responsibility for the repository when it had not maintainer
anymore. So, I'm not sure in all details because I'm not the original
developer.
According to my understanding there is no optimization possible on plugin
side. It implements an interface of the SonarQube analyzer. The plugin is
requested to provide annotation information on request of the
analyzer/server.
We are analyzing several large projects with 2000 or 3000 files for many
year. We did not face any issue so far.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lg2de/sonar-scm-tfvc/issues/59#issuecomment-813980986,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPEASBYLVEYXZ5JVBQN2O3THLJCFANCNFSM4MVHUU7Q
.

I realized that first time analysis takes very long time. But subsequent analysis sessions are even faster.
I guess the analyzer invoking the plugin API performs any kind of optimization!?
Is it ok to close this issue? At least at the moment I do not have any idea for such optimization within the plugin.
It would also be possible to mark this as "enhancement". Maybe someone else has an idea.

Sure, you can close
Thanks for answering!
On Tue, 6 Apr 2021 at 12:18, Lukas Grützmacher @.***>
wrote:

I realized that first time analysis takes very long time. But subsequent
analysis sessions are even faster.
I guess the analyzer invoking the plugin API performs any kind of
optimization!?
Is it ok to close this issue? At least at the moment I do not have any
idea for such optimization within the plugin.
It would also be possible to mark this as "enhancement". Maybe someone
else has an idea.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/lg2de/sonar-scm-tfvc/issues/59#issuecomment-814005951,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPEASBGOU75GYUJWPXVDLDTHLNYZANCNFSM4MVHUU7Q
.


Exclude TestResourceScope.java

Issue: https://github.com/eclipse-openj9/openj9/issues/13234
Signed-off-by: Eric Yang<EMAIL_ADDRESS>

@llxia Please review these changes


UnboundLocalError: local variable 'msg' referenced before assignment

Describe the bug
After update to 18th version always see this bug:
Task <Task pending name='Task-565' coro=<Queue.get() running at /usr/lib/python3.8/asyncio/queues.py:163> cb=[_release_waiter(<Future pendi...ad41ac1c0>()]>)() at /usr/lib/python3.8/asyncio/tasks.py:429]> got Future <Future pending> attached to a different loop

UnboundLocalError: local variable 'msg' referenced before assignment
Task <Task pending name='Task-554' coro=<Queue.get() running at /usr/lib/python3.8/asyncio/queues.py:163> cb=[_release_waiter(<Future pendi...ad41ac5b0>()]>)() at /usr/lib/python3.8/asyncio/tasks.py:429]> got Future <Future pending> attached to a different loop
ERROR:asyncio:Task exception was never retrieved
future: <Task finished name='Task-66' coro=<ThreadedApiManager.start_listener() done, defined at /usr/local/lib/python3.8/dist-packages/binance/threaded_stream.py:44> exception=UnboundLocalError("local variable 'msg' referenced before assignment")>
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/binance/threaded_stream.py", line 54, in start_listener
    if not msg:
UnboundLocalError: local variable 'msg' referenced before assignment

Same here


Fix cursor going to start while editing GraphNode's title

Fixes #26816.
The change to GraphNode::set_title is just cosmetic, making it look more like Button::set_text.

Thanks!


Add generic get binding

Changes Unknown when pulling 1b168708cedbb000f1b53f255c5041f3ce22c74b on Geertiebear:master into ** on vasild:master**.

I am closing this until somebody manages to make sense of the generic get API call.


Add support for .cbr and .cbz files (comics) in the app viewer

The Issue
We had a comic author in the Discord who is interested in publishing his work on LBRY. Comics are a huge market and a lot of them come in .cbz or .cbr format (rar or zip files with images) or PDF. It would be great if we could have an in-app comic file viewer. There should be many open source viewers available. Here is one: https://github.com/codedread/kthoom

Thanks for opening this @LavRadis !

@LavRadis I'm currently working on one, it's open source and should be easy to integrate using an iframe or a react-component, I'll try to make a demo for next week...
If you have any features in mind just post it here.

Related https://github.com/lbryio/lbry-app/issues/932

@LavRadis here is the demo:
https://btzr-io.github.io/comic_book_reader/#/reader

@btzr-io I've tested it and it works great!

@btzr-io Any plans to add that viewer for comics?

@seanyesmunt  currently is a web app, not sure if an iframe would work :upside_down_face:

If not we need to port it to a react component :stuck_out_tongue:

Ah I didn't realize that. Ok. Well this isn't a high priority, maybe someone will pick it up.

Due to the complexity of this viewer I decided to create a separate modular component:

Small update on this issue:
I created a new react component (WIP) but it should be compatible with preact:
https://github.com/btzr-io/Villain

https://github.com/workhorsy/comic_book_reader/issues/121#issuecomment-491163549


This script will need to remain active to use port forwarding, and will refresh every 15 minutes.

After I ran this script, it ended with the following:
--> The port is XXXXX and it will expire on 2022-06-20T16:05:24.632145116Z. <--

Trying to bind the port... OK!
Forwarded port	XXXXX
Refreshed on	Tue Apr 19 00:37:06 EDT 2022
Expires on	Mon Jun 20 12:05:24 EDT 2022

This script will need to remain active to use port forwarding, and will refresh every 15 minutes.

But I had to close the terminal window.
My question is, how do I let the 'script' continue to run, or is it even necessary?
Thanks!

Run it under gnu screen or tmux, or set a cron job to rerun it periodically, or write a systemd service with a 15 minute timeout on restart.

@triffid I've very familiar with screen. Can I just run the script in screen and then detach the screen? Will that allow the script to run as it's supposed to? Thanks!

How/why wouldn't it work?
That's the whole point of terminal multiplexers like screen and tmux :P

Dear all
I used to run this script in a detach screen, it work perfectly.
The only thing (if you want to be "clean") is to modify the script(s) connect_to_{wireguard,openvpn}_with_token.sh and to add at line ~65 :
check_tool screen
Kind regards,
nbanba

@nbanb Well, the check_tool function simply checks to see if a command is installed. I just don't see how making the script check to see if screen is install, is useful?

@bassamanator
For me, if you add (for your need) an external tool like screen or whatever to the solution, if you launch the PF script in a screen and screen is not installed, it will result in a failure.
I rewrite parts of this project to make it run in parallele on the same machine but in differents linux network namespaces (for use as a multi-head / multi-destination vpn, (if you are interrested, it's availiable on github))  and I was required to add external tools like 'dnsmasq' to relay external DNS request to the container (and internal requests to the internal DNS server), 'microsocks' ...
Trust me, when you use external tools, you need to check on the machine if they are installed otherwise it will result in a failure.
All PR or merged of this project should be usable by someone who 'git clone' this project, so  for me, if the code need to use an external tool, it's required to check if it's installed
Kind regards,
nbanba

@nbanb I get what you're saying. Thanks for the explanation! :)


questions about imgsize and crop

When the ‘modelname’ is set to "logo", should the size of the parameter ‘crop’ be set to a quarter of ‘imgsize’? When I set ‘imgsize’ to 512 and ‘crop’ to 128 like this, the following error occurred:
RuntimeError: einsum() operands do not broadcast with remapped shapes [original->remapped]: [64, 8, 1, 64]->[64, 8, 64, 1, 1] [1, 256, 256]->[1, 1, 256, 256, 1]
looking forward to your reply!

The crop argument is for cropping the input to patches of 128 (as input to global branch). It has nothing to do with the patches for the local branch.


How to create empty array

Hello
I would like to create empty array, could not find working syntax using "Set" API. e,g. to achieve below json
{
"home": {
"kitchen": {
"refrigerator": []
}
}
}
what would be path syntax in Set API or any other to achieve same?
Niren

Hi, try the SetRaw function.
sjson.SetRaw(json, "home.kitchen.refridgerator", "[]")

Thank You
Yes, it works. Other option of "-1" works too
sjson.SetRaw(json, "home.kitchen.refridgerator.-1", "")
Niren


Little changes

This is just for a clearer understanding of the statement.
Also on the link above seems to be a bad link, that is https://docs.lukso.tech/tools/lsp-factoryjs/introduction/getting-started/
Is this trying to say erc725.js?

Super cool thank you @EngrGord!
Good spot on the bad link. Can you change it to https://docs.lukso.tech/tools/lsp-factoryjs/getting-started as part of this PR? Thanks!


Switch microk8s enable/disable wrappers to Python script

Followup to #1467, handles some scenarios better and adds tests for them in CI

This PR is failing because libco was remove from the canonical repo. This problem is addressed in another PR. Merging.


Improve fade-out of device session after device logout

The collapsing of the device session info after you log out of a device is janky. It should be a fairly simple CSS fix.
My example of how it might be styled to get a nicer collapsing effect.
Note: I think using max-height is actually more recommended than using height so perhaps swap that out.
My example for demonstration purposes
Acceptance criteria

[ ] There is a fading transition to vertically re-align active sessions when you remove a session

Seen the demo video and looks good cheers


🍒 Cherry pick PR #18802 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/18802 to staging 🍒

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.3.14-14 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Write analysis summary for plate-viewer

As discussed, we should write summary tables and image representations so that it can be inspected visually (e.g. with the fiji-plateViewer).
So far, we have discussed the following:

Write an image with a mask for the cells classified as infected / not infected
Write images with the mean intensities of serum and marker per cell
Write succinct summary of analysis in ImageInformation / WellInformation hdf5 attributes
Write a table with all relevant things from the analysis pipeline

I have added a skeleton job to do this already, now we only need to scrape the data from the analysis and write it in there:
https://github.com/hci-unihd/batchlib/blob/master/batchlib/analysis/summary.py
cc @tischi

Regarding well-based measurements I would for now add them to the image table. Then all images in the same well would have the same number in such columns, which is redundant, but also supporting a well-based table is out-of-scope for me at the moment.

On the cell-level side this is now mostly implemented, apart from

Write succinct summary of analysis in ImageInformation / WellInformation hdf5 attributes
What did you have in mind for this?

What did you have in mind for this?

I think this should be the most relevant score on a per image / per well level.

...maybe, since we now have the interaction with the table working the WellInformation and ImageInformation fields are less important?

...maybe, since we now have the interaction with the table working the WellInformation and ImageInformation fields are less important?

Yep, that's true. It's more important in cases where there's no table. Wouldn't hurt to add it though.
(And the plateViewer should def. keep the functionality.)

Yes, I'll keep it!

@imagirom

What is the number that Vibor currently looks at when you send him the Excel sheets with the analysis? I guess it is a well-based number? This number should be in the one in the WellInformation
Could you please also add this number to the image table?

What is the number that Vibor currently looks at when you send him the Excel sheets with the analysis? I guess it is a well-based number? This number should be in the one in the WellInformation

Could you please also add this number to the image table?

I think that this number is the cell_based_score we have in the table.
I agree, we should also write the well score in the table, and then maybe write the main Image/Well Scores into the ImageInformation/WellInformation attributes.

The number I report to Vibor currently it is the median over the cell_based_score of the images of the well, for now it is in the table under well_cell_based_score.
The ImageInformation/WellInformation you proposed make sense, but I will not add it right now, as it does not seem to be that urgent. Please tell me if you want to use it in the viewer now, then I will add it.

The ImageInformation/WellInformation you proposed make sense, but I will not add it right now, as it does not seem to be that urgent. Please tell me if you want to use it in the viewer now, then I will add it.

It's fine, no need to rush anything!

This has been superseded.


XCUITest iOS 14 support

Describe the solution you'd like
I saw that there are iOS 14+ devices when creating a new test run for XCUITest. I chose one of them, prepared my binaries properly according to your guidelines and scheduled a test run. However, the test runner wasn't able to start because there is no iOS 14 support yet.
Our app is tightly coupled to iOS 14 features and cannot be run on iOS 13 easily. Please add iOS 14 support. Otherwise, what's the point to have iOS 14 devices in the text matrix. Thanks in advance!

@endless-qa I just had a chat with Patrick from App Center and his solution is to (I quote) "The app can be compiled with the newer versions of Xcode the runner needs to be compiled separately."

@stefanrenne What does " needs to be compiled separately" concretely mean? Build the App with the iOS 14 SDK and the Runner with the iOS 13 SDK?

@stefanrenne What does "needs to be compiled separately" concretely mean? Build the App with the iOS 14 SDK and the Runner with the iOS 13 SDK? Do you have an idea, how this can be done for an iOS 14 app?


fix: make TSI index compact old and too-large log files

Closes #22306
Backports #22334 and a small part of #22322 (not backporting the entirety of #22322 since it introduces new InfluxQL features)

is this also supposed to contain the changes to build_tsi.go from inspect ?

No, we haven't backported all the inspect commands. AFAIK we're saving them for 2.1 since they're new features.


Prevents duplicated logs after a controller restart.

Trusty: https://ocd.appscale.com:8080/job/Daily Build/1032/
Precise: https://ocd.appscale.com:8080/job/Daily Build/1036/

This branch was superseded  by https://github.com/AppScale/appscale/pull/1922, Closing.


Add double_verify_proof to integration-tests

Problem
From attempts at debugging https://github.com/noir-lang/noir/issues/4409, the double_verify_proof test case is working on Nargo but not in JS.
Happy Case
Adding the test case to our integration tests would be a good debugging next step for the Issue linked, confirming if it was a user error or is indeed a JS-specific bug.
It additionally protects us from being plagued by it again.
Project Impact
Blocker
Impact Context
Good debugging next step for https://github.com/noir-lang/noir/issues/4409, which is blocking multiple community projects.
Workaround
None
Workaround Description
No response
Additional Context
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response

Difficult to debug further, could use bb.js stack traces.

On further debugging, double_verify_nested_proof was found to go beyond WASM's 2^19 constraint limit; the linked code results in 543137 constraints to be exact.
Issue is blocked until the barretenberg team finds a way to lower the memory footprint.


ORC-707: FIX tzdata to recover Win32 build in AppVeyor (#590)

What changes were proposed in this pull request?
FIX tzdata to recover Win32 build in AppVeyor in 1.5 backporting #590
Why are the changes needed?
Recover win32 build
How was this patch tested?
AppVeyor

+1, thank you for backporting, @pgaref .

+1, thank you for backporting, @pgaref .

Ur, @pgaref . It seems that you did force push branch-1.5 and removed my patch.

Ur, @pgaref . It seems that you did force push branch-1.5 and removed my patch.

@pgaref . What is the reason why you do force-push on the community branch-1.5?

@pgaref . What is the reason why you do force-push on the community branch-1.5?

@pgaref . What is the reason why you do force-push on the community branch-1.5?

Hey @dongjoon-hyun  -- tried to clear a dummy commit messaged and caused an accidental force push on 2 more branches as described here: https://github.com/apache/orc/pull/599#issuecomment-753599534
Everything should be recovered by now.

@pgaref . What is the reason why you do force-push on the community branch-1.5?

Hey @dongjoon-hyun  -- tried to clear a dummy commit messaged and caused an accidental force push on 2 more branches as described here: https://github.com/apache/orc/pull/599#issuecomment-753599534
Everything should be recovered by now.


Removed 2018 references.

Deploy preview for docsdocker ready!
Built with commit 0bab0cd3a0512c4fefe64558dd4203ae490bfa14
https://deploy-preview-8880--docsdocker.netlify.com

Deploy preview for docsdocker ready!
Built with commit d715367f4c8a00eedd84a2757dfb64c9f61a4401
https://deploy-preview-8880--docsdocker.netlify.com

Hi @gnomestar - do the wording updates look good to you? @paigehargrave thanks for taking care of these Hub changes.


Crash loading any scripts

Crash on loading SP game whatever DLL script is in the Scripts folder
stdout shows:
Unhandled Exception:
System.InvalidCastException: Specified cast is not valid.
  at GTA.ScriptDomain.LoadAssembly (System.String filename, System.Reflection.Assembly assembly) [0x00058] in <05ddb5e530f94b409069938b27151b12>:0
  at GTA.ScriptDomain.LoadAssembly (System.String filename) [0x000ba] in <05ddb5e530f94b409069938b27151b12>:0
  at GTA.ScriptDomain.Load (System.String path) [0x002ac] in <05ddb5e530f94b409069938b27151b12>:0
  at ScriptHookVDotNet.Init () [0x00040] in <05ddb5e530f94b409069938b27151b12>:0
  at <Module>.ManagedInit () [0x00185] in <7b06004b3b37431ea590b299857c72cf>:0
  at (wrapper native-to-managed) <Module>.ManagedInit()
[ERROR] FATAL UNHANDLED EXCEPTION: System.InvalidCastException: Specified cast is not valid.
  at GTA.ScriptDomain.LoadAssembly (System.String filename, System.Reflection.Assembly assembly) [0x00058] in <05ddb5e530f94b409069938b27151b12>:0
  at GTA.ScriptDomain.LoadAssembly (System.String filename) [0x000ba] in <05ddb5e530f94b409069938b27151b12>:0
  at GTA.ScriptDomain.Load (System.String path) [0x002ac] in <05ddb5e530f94b409069938b27151b12>:0
  at ScriptHookVDotNet.Init () [0x00040] in <05ddb5e530f94b409069938b27151b12>:0
  at <Module>.ManagedInit () [0x00185] in <7b06004b3b37431ea590b299857c72cf>:0
  at (wrapper native-to-managed) <Module>.ManagedInit()

The only cast I see in GTA.ScriptDomain.LoadAssembly is in exception handeling:
https://github.com/crosire/scripthookvdotnet/blob/d4acd318cab3b674325c8298d78ce98fe93b8a80/source/core/ScriptDomain.cs#L291

This has been fixed as part of 1f7cf37e9433a070da905846724ad80290dd39a3 IIRC.


Allow configuring runtime cap - 60 seconds might be too long in some cases

I decided to add this package on playground (https://github.com/PMunch/nim-playground/pull/7), but because maximum execution time is capped at 20s it might be possible for the benchmark to be terminated externally without even finishing.
I know that 60s cap is not always reached, but considering playground has relatively low execution power it might happen more often compared to regular use.

at least 10 times but possibly more to figure out the standard deviation. It will keep running it until things look like they stabilized. It will stop after 60s though.

I thought about adding cappedTimeIt(maxSeconds: int, name: string, body: untyped) that would allow configuring maximum running time. Make timeIt an alias for cappedTimeIt(60, ...)
Does the implementation idea sound good, or you would prefer to keep this package as simple as possible, without any configuration complexity?

Sorry I don't understand you want it to be infinite? or 20seconds?
The time cap is there really as a fail safe. Most benches should finish in 1-5s seconds. No one has time to wait a full minute!
You can already pass it max number of iterations:
https://github.com/treeform/benchy/blob/master/tests/test.nim#L52
I can see another param that passes max time too.

Sorry I don't understand you want it to be infinite? or 20seconds?

Just as the title says - I want to be configurable. I didn't know you can pass the maximum number of iterations (it is not mentioned in README, and I didn't look into tests (although I should've done this before opening an issue)). I think that solves an issue, though an option to have "another param that passes max time too." would be exactly what I need in this case.

The time cap is there really as a fail safe. Most benches should finish in 1-5s seconds. No one has time to wait a full minute!

Yes, of course, but in https://github.com/PMunch/nim-playground/pull/7 PMunch was concerned with the possibility of the benchmark executing for longer than twenty seconds.

Oh, to be honest I thought that all the benchmarks ran for a minute. If it only runs for a couple seconds it should be fine to run on the playground.


[AD] Fix config collision

What does this PR do?
Takes into account the AD service (container) entity ID when computing the digest of resolved configs.
Motivation
Fix  config digest collision in the check scheduler triggered by container restart
Additional Notes
When a container targeted by an AD config from the file config provider restarts:

The new container is detected and a new AD service with a new entity ID is generated
The new AD service matches the AD config and is scheduled while the check targeting the old container still runs
The configs resolved for both services (new and old) have the same digest
The collector/scheduler already stores the new check and the old check in the same map with the same key here
The old container is detected dead and AD unschedule its AD service
The collector/scheduler removes the old AND the new config because they're stored in the same map entry here

This happens only when the config comes from the file config provider because its configs are static and always generates the same digest. Configs coming from other config providers (docker, kubelet) will have a new digest because we compute the AD Identifiers in the digest (container IDs). For the file configs it's static (short images).
By including the entity ID when calculating the config digest, when a check config is targeting a new restarted container it will be stored in a different map entry in the collector/scheduler.

@olivielpeau thanks, I created a follow-up ticket to investigate what we can do to improve this and mentioned your suggestion 👍


add With function

This allows to specify contextual information in the scope of logging.

@xh3b4sd this is to solve this https://github.com/giantswarm/tprstorage/pull/1#discussion_r130617065


⚠ ClamAV has degraded performance

In d199ad8, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 74 ms

Resolved: ClamAV performance has improved in c2c76be after 5 minutes.


fix: provide way to do dispatch.include for Ajax ResourceRequest on views

Referenced to spring-webmvc change that do a forward for resource request whereas include was used before.
After spring 3.1.2 we get this issue: https://github.com/spring-projects/spring-framework/issues/15417 which is caused by this commit: https://github.com/spring-projects/spring-framework/commit/b17d53ffae3b464ce1e550e3a4bc1c3073087323 -  DispatcherPortlet uses a forward for rendering a view as resource response Issue: SPR-9876

Skimming the code it LGTM. I'm away from my computer though, and haven't tested this on a running portal instance.

I've some other code update coming, I need to merge it before doing a PR with several commits, so it's like you want ;)


[archive.org] Unable to extract jwplayer playlist

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2020.01.01
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['https://archive.org/details/beyond_bengal', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.01.01
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17763
[debug] exe versions: ffmpeg git-2019-12-04-d5274f8, ffprobe git-2019-12-04-d5274f8
[debug] Proxy map: {}
[archive.org] beyond_bengal: Downloading webpage
ERROR: Unable to extract jwplayer playlist; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpj4acy7ln\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpj4acy7ln\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpj4acy7ln\build\youtube_dl\extractor\archiveorg.py", line 45, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpj4acy7ln\build\youtube_dl\extractor\common.py", line 1005, in _search_regex
youtube_dl.utils.RegexNotFoundError: Unable to extract jwplayer playlist; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

I have tried multiple archive.org video links but to no avail, I even tried passing username & password but no success.
I think "Unable to extract jwplayer playlist" is where the issue is
Thank You

Closed this issue at first because I saw someone already opened this issue https://github.com/ytdl-org/youtube-dl/issues/23586
but then it was not properly made so opened mine again :)


change the wordking from '給它` to '采用' , also the words '不正确格式' &  '描述'

improve the translation wording

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


fix: returns an array instead of an object

Hello,
During our developments using your library, we noticed that when we use the "getFirstResult" function present in the "Database" class, in case of empty result, a PHP exception is raised.
This is due to the fact that you specify a return in object, but in the case of an empty result, it is an array that is returned.
We have modified your class so that it returns an object according to the typing in place.
Have a nice day,
The Solar Screen team

Add @solarscreen pull request


Convert whats_left into a CPython script

so that we can parse command line options to configure what to print and how to print it.

oh, i liked this patch but it was forgotten. @verhovsky could you please open it again?

@fanninpm please review again?

@verhovsky Thank you! and I am really sorry to forgetting this PR for long time


spacebar always toggles video play, can't write comments.

pressing psacebar just starts the video again or pauses it, can'tusespacesincommentsundervideo...
Chrome stable.

Disable Enable shortcuts on page.

But I'd like to use shortucts, can't you just check if input field is focused before firing shortcut functions?

Please read #1546 for more information. Currently, YouTube is doing something to inject the comments and input field directly onto the page and the script is not able to differentiate between the input box and the whitespace on the page. We have not yet figured out a way to fix this.

@Zarggg It might be possible to fix this by detecting if the currently active element is inside the comment section. YouTube completely ditched any input form in the comment section and now comments are instead echoed directly inside a div element, but I suppose that the div or a related parent/child element gets focus as well when it is being used. At least from a quick test I could that case.
@YePpHa Checking if the activeElement is contained inside the #watch-discussion element before sending a global shortcut should fix the issue and should also last for any future changes YouTube makes to the comment posting methods.
Something like this, we don't want to send the shortcut command if the currently active element is inside the comment section:
if (!document.getElementById("watch-discussion").contains(document.activeElement)) {
    spacebarPausesVideo();
}

I can confirm this bug, I can create a brand new comment but replies to existing comments as well as editing a comment will result in spacebar always toggling video playback instead of inserting a space in the message I'm typing.
Thanks for providing a work around to this Zarggg.

So is this fixable? Not fixed in 503 :/

Yes, read Zarggg's post.

Zarggg didn't say if it was fixable to have the shortcuts work again like they used to.

Oh, nevermind. In that case, unsure.


BitcoinToYou: NullPointerException when trying to create order without enough funds

Handle better this error and throw appropriate exception.
Probably this error occurs because in this error situation the result format is different than expected (just a guess).

@felipelalli Can you provide a stack trace please?

@timmolter I'm sorry, I can't right now because my system made in Scheme SISC uses XChange as an external library and all I got was "NullPointerException". I can simulate the error but to do that I have to create a new fresh empty account because my current account is being heavily used by my bot.
This issue is not so critical, set it as low priority or feel free to delete it. This error can be avoided if you check first the funds before create an order.


fix: compiler errors

Fix the compiler errors addressed in https://github.com/lark-parser/Lark.js/issues/28.
Other changes are to remove the extra spaces which are made automatically by IDE.

@erezsh would you please review this PR? Thanks!

@erezsh Is there anything I need to change in this PR?


Update the Delete IPs, Manage Ssh Keys dialogs with Chip-Group component

Which package/s are you suggesting this feature for?
Dashboard
Is your feature request related to a problem? Please describe
Vuetify offers a component called "chip-group," which is useful for including multiple chips in the same card and managing padding/margin. Please refer to the screenshot below.

Describe the solution you'd like
https://vuetifyjs.com/en/components/chip-groups/#usage
Also, we can remove the logic of selecting keys and use the vuetify one
Screencast from 06-10-2024 09:20:25 AM.webm

Work completed:
Use chip group in delete public IP. Not usable in SSH page as multiple SSH keys feature is not active as of now.
Note: chip group doesn't pick up the chip color and this seems to be a problem from Vuetify which has been reported https://github.com/vuetifyjs/vuetify/issues/19678

Used chip group in Manage SSH key section in solutions. I also used a margin for the chips in the delete dialogue.

verified now the selecting of the ssh changed and the behaviour is better now when changing a ssh the other is automatically de activated
https://github.com/user-attachments/assets/f228b865-1b90-4e11-98b6-53bf1f0b61a7

but the deleting ips still have the same behaviour

but i think this is acceptable, shall i verify like this or there is more enhancements ?
@zaelgohary @Mahmoud-Emad

verified now the selecting of the ssh changed and the behaviour is better now when changing a ssh the other is automatically de activated
https://github.com/user-attachments/assets/f228b865-1b90-4e11-98b6-53bf1f0b61a7

but the deleting ips still have the same behaviour

but i think this is acceptable, shall i verify like this or there is more enhancements ?
@zaelgohary @Mahmoud-Emad

For the IP chips, it was fixed by adding a margin. Please, verify as it is.

@khaledyoussef24
Also, you can open an issue to change the style of the delete ips dialog the same of the ssh keys dialog to be consistent

will close this for now another issue is opened for the delete ips
https://github.com/threefoldtech/tfgrid-sdk-ts/issues/3221
and already closed to continue with the current  flow.


new ray-mesh intersection methods

Port ray-mesh/polygon/triangle intersection methods and support classes from native:

BarycentricTriangle.intersectRay3d and BarycentricTriangle.intersectSegment return a TriangleLocationDetail
PolygonOps.intersectRay3d returns a PolygonLocationDetail
PolyfaceQuery.intersectRay3d returns a FacetLocationDetail implemented by one of TriangularFacetLocationDetail, ConvexFacetLocationDetail, or NonConvexFacetLocationDetail

Also:

add support for interpolation of auxiliary mesh data at the vertices of a convex facet
flesh out the functionality of BarycentricTriangle
new non-abstract support methods in abstract classes IndexedXYCollection and IndexedXYZCollection with default implementations where possible, otherwise overridden in delivered subclasses.
fix bug in XYZ.setAt
use recommended type "node" instead of "pwa-node" in launch.json for Geometry tests.

Note: civil team will need this backported to 3.6.x, 3.7.x.

@Mergifyio backport release/3.6.x

@Mergifyio backport release/3.7.x

Note: civil team will need this backported to 3.6.x,

we should not be backporting new features as a patch, 3.7 will be out relatively soon, they cant wait?
cc @a-gagnon @bsy-nicholasw @simnorm

we should not be backporting new features as a patch, 3.7 will be out relatively soon, they cant wait?

I think this request happened before a 3.7 release was planned...

thanks for this work, 3.7 should be ok. We just don't want this to be on 4.0.

Ok, great. Someone please cancel the 3.6.x mergifyio backport.


Estimated time to exit should be hours/minutes only

The minutes and seconds drift a little at the beginning, and it's not very useful to show people the estimate seconds with the hours and minutes.

Updated to display exit in relative human-readable format:


Loader Component Added

A fun loader has been added to keep the user aware of the data fetching in the background

Ok approved


Intellise is slow for numpy, pandas and similar

Issue Type: Bug
I have imported numpy the standard way:
import numpy as np
When I start coding, intellisense is quite slow, and it doesn´t show me all available methods. For example, if I write np.random. and hit ctrl + space, the randn method does not show up. This works in pycharm, just as a sidenote. Additionally, many of the methods shown by intellisense does not display any help (docstrings). I have installed numpy using conda. For the builtin modules, like sys intellisense seem to work much better.
Extension version: 2019.4.12954
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz (8 x 1896)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.84GB (2.55GB free)

Process Argv
\xxx\Users\xxx\Redirect\Desktop\python_courses\automated_testing\section3\blog

Screen Reader
no

VM
0%

I likely found the issue. I first installed the conda environment under a windows UNC path, instead of under a normal drive. When I placed the conda environment directly under C: it seems to work much better. Is this expected?

Please inform if you're using Language server or jedi, i.e check the value of python.jediEnabled in settings.json.

Closing as no further response was provided


My server doesn't start up to 1000 s ec

Expected Behavior

Current Behavior

Context

Steps to Reproduce (for bugs)

Your Environment

Build scan URL:

Hi @Purushottam10
I'm not sure what you mean.  Could you provide some more information and reopen this issue?
Thanks!

package webamber;
public class Services {
private int id ;
private String serviceName ;
private double cost;
private String about;
/**

@return the id
/
public int getId() {
return id;
}
/*
@param id the id to set
/
public void setId(int id) {
this.id = id;
}
/*
@return the serviceName
/
public String getServiceName() {
return serviceName;
}
/*
@param serviceName the serviceName to set
/
public void setServiceName(String serviceName) {
this.serviceName = serviceName;
}
/*
@return the cost
/
public double getCost() {
return cost;
}
/*
@param cost the cost to set
/
public void setCost(double cost) {
this.cost = cost;
}
/*
@return the about
/
public String getAbout() {
return about;
}
/*
@param about the about to set
*/
public void setAbout(String about) {
this.about = about;
}
public static void main(String[] args) {
}

}
this is jsp code
On Fri, Aug 10, 2018 at 3:06 AM Sterling Greene<EMAIL_ADDRESS>wrote:

Closed #6320 https://github.com/gradle/gradle/issues/6320.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gradle/gradle/issues/6320#event-1781248531, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ASvf2Q5XDVe_0fMrYpmGFw-uq4ucJAMWks5uPKtAgaJpZM4V2RVT
.

@Purushottam10 This does not look like it's even using Gradle at all or am I missing something?


fix: replace COUNTRIES with countries.countries

What I'm trying to achieve
I was using your open source project to develop a store website. You have used the "django-countries" as a third party app.
Instead of importing COUNTRIES , we should import countries in the file "saleor/account/i18n.py".
Steps to reproduce the problem

replace from django_countries.data import COUNTRIES by from django_countries import countries
replace for country in COUNTRIES.keys()  by for country in countries.keys()
3.replace COUNTRY_CHOICES = [(code, label) for code, label in COUNTRIES.items()......] by COUNTRY_CHOICES = [(code, label) for code, label in countries.items()

What I expected to happen
While using the saleor in the project, I have to set the countries-limit to India only. For this I read the Django-Countries documentation to solve this issue.
After reading the documentation, when I made the change in settings.py file, but there was no effect on the counties-list. Then I have to made changes in several files.
Then DRY concept came into my mind. After that I read the whole code of Django-Countries to solve this new issue.
I saw that you have imported COUNTRIES which is a bad idea if anyone have to do some modifications for their project.
Screenshots

System information
Operating system: Linux(Bionic)
Browser: Google Crome
IDE: PyCharm

I want to work on this issue. Please give the access rights.

@neeraj1909 Glad that you want to pick it up. Please fork the Saleor, create a branch on your local fork and then open a pull request to mirumee/saleor's master.

So this problem persists only in places where we've imported COUNTRIES instead of countries.
In such case, if one wants to modify the countries list by settings provided by the django-countries package (eg. COUNTRIES_ONLY = ['NZ', 'AU']), the countries' list is invalid.

Yes, this problem persists only in places where we've imported
COUNTRIES instead
of countries.
I am creating the PR.
On Tue, Oct 9, 2018 at 12:33 PM Filip Kucharczyk<EMAIL_ADDRESS>wrote:

So this problem persists only in places where we've imported COUNTRIES
instead of countries.
In such case, if one wants to modify the countries list by settings
provided by the django-countries package (eg. COUNTRIES_ONLY = ['NZ',
'AU']), the countries' list is invalid.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mirumee/saleor/issues/3077#issuecomment-428082986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATzeUHtXgkHugRmcBCWR4yxxmqR2YV-cks5ujEozgaJpZM4XRe63
.

I think this was resolved in #3079


Flashing STM32F0 fails on first flashing instance

[x ] Programmer: Stlink/v2
[ x] Operating system: Ubuntu 16.04
[ x] Stlink tools git commit hash:<PHONE_NUMBER>9afef1a256964afcbb8dcf4b733209
[ x] Stlink commandline tool name: st-flash
[x ] Target chip: STM32F051R8T6TR and STM32F030K6T6

Whenever I flash any of the F0 chips that I have, the flashing fails on the first execution. I have to reset the chip (power off and power back on again) and try to flash the chip again. On the second execution it successfully flashes the chip.
I have included the standard console output below. I am unable to include the debug output, because GitHub won't accept it - it is too long.
This seems to be related to issue #92, but it doesn't look as if simply running st-flash directly works on the first execution.
Initial flashing:
k@k-Desktop:~/FW$  st-flash write FUPS.bin 0x08000000
st-flash 1.4.0-13-g1969148
2018-01-10T11:44:05 INFO common.c: Loading device parameters....
2018-01-10T11:44:05 INFO common.c: Device connected is: F0 device, id 0x20006440
2018-01-10T11:44:05 INFO common.c: SRAM size: 0x2000 bytes (8 KiB), Flash: 0x10000 bytes (64 KiB) in pages of 1024 bytes
2018-01-10T11:44:05 INFO common.c: Attempting to write 35648 (0x8b40) bytes to stm32 address: 134217728 (0x8000000)
Flash page at addr: 0x08008800 erased
2018-01-10T11:44:06 INFO common.c: Finished erasing 35 pages of 1024 (0x400) bytes
2018-01-10T11:44:06 INFO common.c: Starting Flash write for VL/F0/F3/F1_XL core id
2018-01-10T11:44:06 INFO flash_loader.c: Successfully loaded flash loader in sram
 35/35 pages written
2018-01-10T11:44:08 INFO common.c: Starting verification of write complete
2018-01-10T11:44:08 ERROR common.c: Verification of flash failed at offset: 0
stlink_fwrite_flash() == -1

After having reset the chip (power off and power back on):
k@k-Desktop:~/FW$  st-flash write FUPS.bin 0x08000000
st-flash 1.4.0-13-g1969148
2018-01-10T11:44:14 INFO common.c: Loading device parameters....
2018-01-10T11:44:14 INFO common.c: Device connected is: F0 device, id 0x20006440
2018-01-10T11:44:14 INFO common.c: SRAM size: 0x2000 bytes (8 KiB), Flash: 0x10000 bytes (64 KiB) in pages of 1024 bytes
2018-01-10T11:44:14 INFO common.c: Attempting to write 35648 (0x8b40) bytes to stm32 address: 134217728 (0x8000000)
Flash page at addr: 0x08008800 erased
2018-01-10T11:44:15 INFO common.c: Finished erasing 35 pages of 1024 (0x400) bytes
2018-01-10T11:44:15 INFO common.c: Starting Flash write for VL/F0/F3/F1_XL core id
2018-01-10T11:44:15 INFO flash_loader.c: Successfully loaded flash loader in sram
 35/35 pages written
2018-01-10T11:44:16 INFO common.c: Starting verification of write complete
2018-01-10T11:44:17 INFO common.c: Flash written and verified! jolly good!

Please verify if the problem still exists in Release v1.6.0.

@ksschwabe @aric1987: Please verify if the problem still exists in Release v1.5.0.

This problem now seems to have been resolved in v1.6.0.

Thx for the feedback. Have you also tested v1.5.0 and v1.5.1?
That would help to find the related commit in order to correct the changelog.

This should be tested with our v1.5.1-patch branch. Please report if the problem persists.


Only video resolution of 320p on Youtube / Embedded Youtube videos are black/not available

Since the new Firefox update (37.0.1) every video on Youtube (not embedded Youtube videos on other pages) are only available in 320p when using YouTubeCenter (with Developer Build 497 and Version 2.1.7).
Also embedded Youtube videos outside of Youtube are only showing black where the video should be (even the controls are not appear) with version 2.1.7 but working with Developer Build 497.
Using:
Firefox (37.0.1)
Firefox Addon
YouTubeCenter (Developer Build 497 and Version 2.1.7)

Do you have DASH playback disabled? (YTC Settings >> Player >> General)

Interesting... It seems that disabling DASH causes this resolution problem.

Yes, and it seems this issue started recently, as I had no problems until a few days ago. I also can't download videos higher than 360p. I'm guessing it's a problem with how YouTube is now sending their files.
Anyway, I hate using DASH, as I usually watch very lengthy videos and I like to search through different scenes. With DASH, one has to wait until each segment is buffered.

Yeah... I just read your thread. I also hate using DASH.


Is networkx still needed?

https://github.com/clement-pages/gryannote/blob/8c3710cae7b2cb820fa6c4e97b3447d44352622c/pyproject.toml#L29

Indeed. gradio problem is on me. It's already there.
I guess I installed with --no-deps :)


Create an intro

Add an intro about yourself: who are you, what is your strength, why are you here.

Intro created


Adjust file names to use parallelnode

What this PR does / why we need it:
The filenames need to be separate for the test processes that are
started so they don't overwrite each other. This needs to be done for
both the junit result files and the polarion result files.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

@rmohr @lukas-bednar I've simplified the handling of parallel runs now. Instead of modifying qe-tools I just handle multiple filenames in the tests binary itself. This would lead to changing the junit-output and polarion-report-file to only be a filename. I'll update the other pr accordingly.

/retest

/approve
looks great! Can you squash the commits?

/hold
will first test it locally whether it works as expected, then I'll squash.

/unhold

/lgtm

/lgtm
/retest

/release-0.49

/cherrypick release-0.49

/retest


Significant drop in model accuracy with hist method

https://discuss.xgboost.ai/t/xgboost-xgboost-hist-and-lightgbm-benchmark-xgboost-hist-performance-drop/2719

The benchmark is using 1.5.2, will try to reproduce it later.

@hcho3 You fixed it in https://github.com/dmlc/xgboost/pull/7551 .


remove the getFreq method of p5.fft as it is deprecated

should we remove the line of code or we should let it as it is for the systems that are build on our prevoius versions ?

@therewasaguy should i remove them?


[CHORE] iot-benmark uses a lot of cpu cores

Description
After I implemented Iot-benchmark support for CnosDB, I found that the iot-benmark itself had a very high cpu usage during testing.But in fact, the concurrency is not much, CnosDB itself has a relatively low CPU usage, is this my implementation problem?

I also tested Influxdb and found a similar one for iot-benchmark-influxdb

But when I tested iotdb, there was no problem with high cpu usage. Why？

Config
here is my config
BENCHMARK_WORK_MODE=verificationWriteMode

FILE_PATH=/path/to/data
DEVICE_NUMBER=50
SENSOR_NUMBER=10
CLIENT_NUMBER=50
BATCH_SIZE_PER_WRITE=10000
OPERATION_PROPORTION=1:0:0:0:0:0:0:0:0:0:0
BIG_BATCH_SIZE=10
IS_COPY_MODE=true

Perhaps you can use sampling tool (such as jprofile or arthas) to find out what function takes so much cpu when testing cnosdb and influxdb.

You can use the testWithDefaultPath pattern directly, where verificationWriteMode checks the correctness of all data written, which is not needed for normal performance tests and can be CPU-expensive


replace nonfunctional Github Actions badge with cool one in README

Description
Just like in https://github.com/ESMValGroup/ESMValCore/pull/1526 I am adding a functional Github Actions test badge (here it's tracking the test in full development mode - I can change it/add other test badges). Adding a GA test badge is very simple to create: simply go to the Actions tab, click on the test you want to create a badge for on the left side, where all the available (and active) tests are, then three dots on the right side, and select Create Badge, copy the Markdown text and plop it in the README - voila!
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Tests run successfully
[x] 🛠 All checks below this pull request were successful

cheers Manu :green_book:


Committee query error

Traceback (most recent call last):
  File "a.py", line 36, in <module>
    test = Committee("1.5.10", False)
  File "/home/user/python-bitshares/bitshares/blockchainobject.py", line 101, in __init__
    self.refresh()
  File "/home/user/python-bitshares/bitshares/committee.py", line 40, in refresh
    self.account_id = account["id"]
UnboundLocalError: local variable 'account' referenced before assignment

Am I using the committee function incorrectly?
I was just testing it out:
test = Committee("1.5.10", False)

print(test)

for a in test:
  print(a)

Referenced section of python-bitshares code: https://github.com/bitshares/python-bitshares/blob/master/bitshares/committee.py#L40

Nice catch. Here's the fix: #80


Not loading in production; uncaught reference error

Gon works fine in development mode, but in production, it's producing an Uncaught Reference Error: gon is not defined.
I have written <%= include_gon %> in the application layout header before style sheet/ javascript tags.
Any thoughts?

+1 Having this issue as well.

I never solved this issue. Ultimately, I either passed server side data into html data attributes and retrieved it with the Javascript or retrieved it with Ajax calls directly.


Add behaviour OutStream.flush for explicitly flushing streams.

This was missing for stdout and stderr and was mostly causing issues on windows.
Fixes #3095

Indeed, i intend to test it with that new test suite to come.


does not work with Phalcon version 4.0.0

Does not work with Phalcon version 4.0.0.

Sorry, It does not support for 4.x now.

Are there plans to upgrade the debugbar for phalcon 4.x?
I was a big fan of the debugbar and would not gladly give it up. :)

@casparjones the Phalcon v4 api (of the common Di services) is slightly changed from v3, so it would not take a huge amount of time to make the phalcon-debugbar compatible with Phalcon 4; feel free to debug and push some adjustments in a PR :)

I just change this to stop the fatal error, but there is a lot of change to do
ServiceProvider.php - line 184 - $router->handle(); --> $router->handle($_GET['__url'] ?? '/');
How can we debug it ? i have no error...

ok, it's working with phalcon 4 now... but i don't know if all functionnality are ok...
I'm going to commit or do a diff file :)

can you do a branch for it ? one beta v4.0.0 ?

poke @snowair :)
ServiceProvider.php
Line 184

$router->handle();
$deny_routes  = (array)$config->get('deny_routes');
$allow_routes = (array)$config->get('allow_routes');

to

$router->handle($_SERVER["REQUEST_URI"]);
$deny_routes  = $config->get('deny_routes')->toArray();
$allow_routes = $config->get('allow_routes')->toArray();

PhalconDebugbar.php
Line 20 to 23

use Phalcon\Cache\Backend;
use Phalcon\Cache\Multiple;
use Phalcon\Db\Adapter;
use Phalcon\Db\Adapter\Pdo;

to

use Phalcon\Cache;
use Phalcon\Db\Adapter\AbstractAdapter;
use Phalcon\Db\Adapter\Pdo\AbstractPdo;

Line 241

if ($this->shouldCollect('doctrine', false) &&!$this->hasCollector('doctrine') && !$this->hasCollector('pdo') ) {

to

if ($this->shouldCollect('doctrine', false) &&!$this->hasCollector('doctrine') && !$this->hasCollector('AbstractPdo') ) {

Line 276

if ( $backend instanceof Multiple || $backend instanceof Backend ) {

to

if ( $backend instanceof Cache ) {

line 602

if( $this->hasCollector('pdo') ){
/** @var Profiler $profiler */
$profiler = $this->getCollector('pdo')->getProfiler();
$profiler->handleFailed();
}

to

if( $this->hasCollector('AbstractPdo') ){
/** @var Profiler $profiler */
$profiler = $this->getCollector('AbstractPdo')->getProfiler();
$profiler->handleFailed();
}

line 697

$eventsManager->attach('db', function(Event $event, Adapter $db, $params)  use (

to

$eventsManager->attach('db', function(Event $event, AbstractAdapter $db, $params)  use (

PhalconHttpDriver.php
Line 30

function isSessionStarted() {
if ( !$this->session->isStarted() ) {
$this->session->start();
}
return $this->session->isStarted();
}

to

function isSessionStarted() {
if ( !$this->session->exists() ) {
$this->session->start();
}
return $this->session->exists();
}

Storage/Filesystem.php
Line 23

public function __construct($dirname,$di)
{
if ( !$di['session']->isStarted() ) {
$di['session']->start();
}
$sid = $di['session']->getId();

to

public function __construct($dirname,$di)
{
if ( !$di['session']->exists() ) {
$di['session']->start();
}
$sid = $di['session']->getId();

Db/Profiler.php
Line 70

public function startProfile($sqlStatement, $sqlVariables = null, $sqlBindTypes = null)

to

public function startProfile($sqlStatement, $sqlVariables = null, $sqlBindTypes = null): \Phalcon\Db\Profiler

Line 172

public function stopProfile()

to

public function stopProfile(): \Phalcon\Db\Profiler

I think there is all the needed modifications. I don't know if all functionnalities run but the toolbar open.

So, i failed for queries...
in DataCollector\QueryCollector

$succeed = (array)$this->profiler->getProfiles();

return null....
However $this->profiler object contains data, but getProfiles doesn't work...
If someone can find the solution...
Thks

I have found a solution, but it's not clean...
\DataCollector\QueryCollector.php
line 31 to 36 replace with

/** @var Item[] $succeed /
$succeed = (array)$this->profiler->getProfiles();
$succeed = $tab_profiles["_allProfiles"];
/* @var Item[] $failed */
$failed = (array)$this->profiler->getFailedProfiles();

to

$tab_profiles = (array)$this->profiler;
/** @var Item[] $succeed /
//$succeed = (array)$this->profiler->getProfiles();
$succeed = $tab_profiles["_allProfiles"];
/* @var Item[] $failed */
$failed = (array)$this->profiler->getFailedProfiles();

i pushed all my modifications to the project...


Fixed rendering problem with oc get route

Text with double curly-braces get ignored - switching from --template to -ojsonpath works around the problem because only single curly-braces are required

+1
Encountered this twice while giving the workshop.


Adding subreddit recommendation support

#40

Nicely done, thanks!  I can now add this to the list of endpoints we support.

Merged into 1.2.


Empty tensor when running inference on custom dataset

Hi!
We are trying to use the pre-trained dales model to segment our dataset.  Our dataset is similar to dales and is setup in SPT in the same way as dales. When we use the dales model to segment the dales dataset we do not have any issues.

When running inference we get the following error:

It seems like the 'data.pos' tensor is loaded correctly at first. However, when we run the script the tensor 'coords' is empty. As 'coords' is a result of 'data.pos'/'grid_size' we tried to change 'grid_size' as 'data.pos' seem to be read correctly.
Furthermore we tried adding our data to the dales dataset in SPT, as we thought we might have made an error when setting up our own dataset. This did not solve the issue.
It seems as the issue is related to the dataset, but we are having issues locating the error. Do you have any suggestions?
Once again thank you for the great project! 😃
Best regards
Jeppe

Seems like you need to investigate the nature of your data before calling grid_cluster() here:

is coords empty ?
is pos empty ?
is grid_size None ?
what is the shape of pos ? It should have a shape (N, 3)

Have you solve this issue ? May I close it ?

Hi.
We have not yet resolved the issue. As described, our data is read as it should be. Something goes wrong when we need to create 'coords' and 'pos' as they are empty.  I think the problem is with our dataset and not SPT, so you can resolve the issue.
Best regards Jeppe

@drprojects
I report the same issue with custom data. My data is not empty, once passed to the Grid Sampling the pos shape becomes (0, 3) which is not correct


Photon first class citizen on Now

Make photonjs work well with Now to create different microservices etc.

Agreed. Depends on: https://github.com/prisma/prisma2/issues/6

Closing in favor of: prisma/prisma2#6


increase batch size for import job

After some testing, it appears that this doesn't net any performance gains. The new 125 element/batch limit in the 1.1.0 gives enough of a boost from the 25 in 1.0.0


Updates/Edits to OSCon NA 2024 Sessions

Please make the following edits/changes to the OSCon NA sessions here: https://opensearch.org/events/opensearchcon/2024/north-america/sessions/index.html

Speaker: Rohit Nair
Talk Title: A deep dive into OpenSearch Serverless
Details: Continental 1-3 on 9/25 from 4:40pm-5:20pm
Add:

For the headshot – you can use my phonetool photo<EMAIL_ADDRESS>“Rohit Nair is a Software Development Engineer at AWS currently working on OpenSearch Serverless. He has previously worked on areas like UltraWarm storage for Amazon OpenSearch Service and Amazon Kinesis Data Streams. He loves working at the intersection of distributed systems, scale and performance”
I’m not active on Linkedin or Github - no links required

Speaker: Ramesh Kumar Manickam of Transunion
Talk Title: Scaling Operational Intelligence into Business Intelligence using OpenSearch & GenAI for global rollouts
Details: Continental 7-9 on 9/25 from 4-4:40pm
Add:

Co-presenter - Mohanraj Vanjiappan<EMAIL_ADDRESS>Title: Senior Engineering Manager
Company: TransUnion Global Capability Center Bangalore
Bio: Working as a Senior Engineering Manager At TransUnion Global Capability Center Bangalore. Solving problems in the domain of Risk & Fraud by leveraging cutting edge Technologies in digital landscape. Having 16+ years of IT Industry experience with hands on exposure to Java, Microservices, Google Clod Platform, Python, Data Science. Working in OpenSearch APIs, leveraging it to the fullest extend in the past couple of years.

Update Jon Handler’s presentation: https://opensearch.org/events/opensearchcon/sessions/multitenancy-for-all-workloads.html - as he is going to give a different talk.
New title: How AI/ML is changing information retrieval
Abstract: When we work with information systems, we capture information in text and find information with text queries. Advances in AI have made it possible to move from word-to-word matching to something like meaning-to-meaning matching. Learn how search and OpenSearch unlock the meaning in your information. This session is foundational, covering why we search, and how we search to retrieve the best results. I will cover the core search algorithm, BM25 scoring, vectors (dense and sparse), LLMs, embedding generation and the neural and kNN plugins, exact, and approximate scoring.

CC: @kaimmej

On it. Thanks @pajuric.

Co-presenter - Mohanraj Vanjiappan<EMAIL_ADDRESS>
@pajuric Can I get a job title / bio / headshot of this person so I can create their community member profile?


Add presets?

Following a recent discussion with @frostedoyster regarding changing the default PET hypers towards a more lightweight and fast model, we agreed that it would be better to offer different presets rather than a single set of default hyperparameters. Presets might be something like "fast," "medium," and "large." This issue is created to track the implementation of this feature. I guess it is up to me to address the presets themselves, but this feature also requires scaffolding infrastructure.

I think having small, medium, large presets will be unfortunately necessary because people can't be bothered to read the docs and change the parameters themselves

This is a great idea!
I think having at most three preset is good (more than three means you have to read the documentation again), and we could try to name the presets in the same ways for all architectures, following the "good", "better", "best" convention.
Some possibilities would be

small/medium/large
fast/???/accurate
loose/???/tight (close to AIMS basis names)

upd. The main motivation for presets was the impression that PET with default hypers is slow, and thus, a 'light' preset was urgently needed. An investigation with @DavideTisi, though, revealed that the issue is that the LAMMPS MD interface is currently 40 times slower than intrinsic PET (see https://github.com/lab-cosmo/metatrain/issues/274). I guess there are two implications:

It is still a super nice feature, but priority can probably be low (at least from the point of view of PET)
the default PET preset should be the one that will correspond to the current default hypers

and [unrelated] 3) probably it is worth to think about naming to incorporate more than 3 presets if needed.

and [unrelated] 3) probably it is worth to think about naming to incorporate more than 3 presets if needed.

I disagree here. I don't think more than three preset is helpful for users. If they are using presets, it is because they don't know a lot about the architecture, and offering too many choices does not help. The presets are not here for people who want to tune the hypers, but as a way to balance speed vs accuracy easily.

and [unrelated] 3) probably it is worth to think about naming to incorporate more than 3 presets if needed.

I disagree here. I don't think more than three preset is helpful for users. If they are using presets, it is because they don't know a lot about the architecture, and offering too many choices does not help. The presets are not here for people who want to tune the hypers, but as a way to balance speed vs accuracy easily.

yeah, good point actually

and [unrelated] 3) probably it is worth to think about naming to incorporate more than 3 presets if needed.

I disagree here. I don't think more than three preset is helpful for users. If they are using presets, it is because they don't know a lot about the architecture, and offering too many choices does not help. The presets are not here for people who want to tune the hypers, but as a way to balance speed vs accuracy easily.

Thought №2 about this. Probably, users who do not want to tune hypers want some kind of slider that represents a one-dimensional tradeoff between accuracy and computational efficiency (contrary to the multidimensional nature of hypers). And this 1D slider actually opens up a space for a continuum number of presets, not just 3.

No, this is just introducing a new hyper (the 1D "slider"), that they don't want to tune either. I feel like "good", "better", "best" presets is the best way to think about these.

No, this is just introducing a new hyper (the 1D "slider"), that they don't want to tune either. I feel like "good", "better", "best" presets is the best way to think about these.

Can work, do not have strong feelings about this, anyway.

Small, medium, large?
Fast, balanced, accurate?
1, 2, 3?


System font renders incorrectly in Chrome on macOS/OS X

[ ] This is a question about using the theme.
[ ] This is a feature request.
[x] I believe this to be a bug with the theme.

[x] I have updated all gems with bundle update.
[x] I have tested locally with bundle exec jekyll build.

Environment informations

Minimal Mistakes version: 4.6.0
Jekyll version: 3.5.2
GitHub Pages hosted: yes
Operating system: macOS

Expected behavior
San-serif fonts in Chrome on macOS and OS X (El Capitan) should render as San Francisco but are rendering as Helvetica Neue.
Steps to reproduce the behavior
Browse to the following Minimal Mistakes 4.6.0 URL:
https://mmistakes.github.io/minimal-mistakes/docs/installation/
Inspect any body text using Chrome DevTools:

The named fonts .SFNSText-Regular and San Francisco do not resolve and Chrome falls back to Helvetica Neue.
This renders correctly when using the Chrome supported BlinkMacSystemFont instead of the private font names.

Chrome now supports a BlinkMacSystemFont generic font name that behaves like Safari’s -apple-system.

Ref: http://furbo.org/2015/07/09/i-left-my-system-fonts-in-san-francisco/

Happy to look at a PR if you want to take a stab at fixing this.

Nevermind... just saw your PR :smile:


How to make a cutscene after the last song?

Describe your problem here.
I really want to make an ending cutscene but I can't add one. If you know how to do that please tell me how. Or, if that is possible by just using a script.Lua file,
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

maybe do the same thing you do in onStartCountdown() but with onEndSong() instead

oh ok thx


Fix #5533: Prefer light_rewrite_comment if it is not a doccomment

This pull request adapts the plan 2 of @ytmimi's comment, and it won't touch any comment which is not a documentation comment now.
However, it did not fixed the root cause (which is partially indicated in Plan 1): block_comment is true if the length is too long…?. As it seems not related to #5533, it may be fixed in another PR.

cc @ytmimi . Thanks!

Thanks for the follow up!
I still believe is_doc_comment is the only boolean we need to include in our check to force code execution to move to light_rewrite_comment. I could be missing something, and if we need to check both is_doc_comment and style.is_doc_comment could you please explain why. The comment is helpful and I liked that you kept it 👍🏼

I have reverted it. However, why did L384 do such a double check?
https://github.com/rust-lang/rustfmt/blob/8919fd39d13b60a2c2e70e4f768cbd083b318de4/src/comment.rs#L384
Seems like this code has been refactored before, and I don't know why they wrote it.

why did L384 do such a double check?

That decision pre-dates my time with the project. My best guess is that there was a time when both were necessary to be absolutely sure we were rewriting a doc comment. Now that we have rewrite_comment and rewrite_doc_comment as our top level  comment rewriting functions it's easier to differentiate what kind of comment we're rewriting.

Seems like this code had been refactored before, and I don't know why they wrote it. Besides, even when I removed the determination, all the tests were still passed.

It's might be the case that style.is_doc_comment() is no longer needed, but it's not hurting us right now, so we'll keep it for now.

@pan93412 I noticed that this PR also resolves #5568 so I added a test case on your branch to validate that

@pan93412 I noticed that this PR also resolves #5568 so I added a test case on your branch to validate that

Thanks!

Hey folks, I think this PR has the ready to merge label and it resolves several issues with formatting comments. What else needs to be done to get this merged?

Thank you.


Possibly refactor SSZ library

I am nervous about the reliability and maintainability of our SSZ library.

The original SSZ library causing concerns is no more. :)


Access to CI Pipelines

Dear Gardener CI/CD Team,
I'm on of the maintainers for the equinix extension and would like to request access for those pipelines to be able to trigger releases and hotfixes.
Kind regards,
Tim

Approved from management side 👍
@zkdev Please proceed.

Hi @schrodit,
I granted you access to the corresponding pipelines.
Could you please confirm that you have access and everything is working as expected?

I have access but seems like the container registry crendetials are wrong. See https://concourse.ci.gardener.cloud/teams/gardener-public/pipelines/machine-controller-manager-provider-equinix-metal-main/jobs/main-head-update-job/builds/3
Not sure if the actions are connected

I created PR's adjusting pipelines:

https://github.com/gardener/machine-controller-manager-provider-equinix-metal/pull/24
https://github.com/gardener/gardener-extension-provider-equinix-metal/pull/302

head-update got green in the meantime, could you check again please :-) ?

Hi @schrodit ,
is everything working as expected so we can close the issues?

Pipelines are green, I am closing here.
Please get in touch in case of questions :-) .


Find no pois but they can be searched in openstreetmap.com

I try to collect pois through geometries_from_place and get no results for some cities. But I find a large mount of poi in openstreetmap.com. Why does this situation occur?
Usage:
res = ox.geometries.geometries_from_place('Chennai, India', tags={"bridge": "yes"})

Thanks for using OSMnx! Please re-read the contributing guidelines and the new issue template you saw when you opened this issue.
As the template noted, your issue will be automatically closed if you didn't provide all of the information requested in the template, because we need all of this information to address your issue.
Also note: per the contributing guidelines, please don't use the issue tracker to ask "how-to" or usage questions. If asked here, they will be closed automatically. Instead, ask "how-to" and usage questions on StackOverflow.


Uninitialized constant

On OS X Yosemite:
~% sudo gem install memegen
# success
~% memegen --list
/Library/Ruby/Gems/2.0.0/gems/memegen-1.0.9/lib/meme_generator/cli.rb:2:in `images': uninitialized constant MemeGenerator (NameError)
	from /Library/Ruby/Gems/2.0.0/gems/memegen-1.0.9/lib/meme_generator/cli.rb:11:in `list_generators'
	from /Library/Ruby/Gems/2.0.0/gems/memegen-1.0.9/bin/memegen:18:in `<top (required)>'
	from /usr/bin/memegen:23:in `load'
	from /usr/bin/memegen:23:in `<main>'

having the same issue

I had the same issue, and @amitailanciano's fix works for me too.


custom rules are loaded from the rules-dir but no output is generated

Hi,
This is the issue following up on my comments about custom tslint rules not being reported during analysis in #18.
What I found out is that the rules are being loaded from the rules-dir, but they don't seem to be evaluated by the sonar-runner for some reason.
I added some logging to the plugin and had a look at what the sonar-runner output looked like and there was no occurrance of any of my custom rules.
I even manually added the rule to the plugin and built it from source, but there was still no output for the custom rule that I added.
Is there anything special that I should be careful about when using custom rules to make them work with the plugin ?
EDIT:
tsc-version: Version 1.9.0-dev.20160323
tslint-version: 3.7.1
Thanks

Are they listed in your tslint.json to be used? Do they appear in tslint output if run manually?

@Pablissimo I figured out that the output from the custom rules is not shown if I run the tslint command from a command line manually. Usually I run tslint for my projects through npm scripts and if I do that the custom rules are working just fine. But if I use the exact same command on the regular command line the output by the custom-rules is gone.
But if I rename a custom rule to an incorrect name in the tslint.json and try to run the command line I get and error still. So the custom rules are recognized, by they are simply not handled and/or their output is not shown when tslint is run in a global CLI context instead of npm.
I'll continue debugging this ... have you ever heard before of such an issue with tslint ?

No, and I've got custom rules running on several of the projects on the demo site (I had to implement support for --custom-rule-dir exactly because tslint refused to even parse tslint.json files if they contained rules it didn't recognise.
If you run sonar-runner with the -X switch it should give you the trace output from tslint - you will see screeds of JSON output but hopefully you can dig into that to see if tslint's reporting any breaches of your custom rule?
Will try and repro locally, but do you have a sample project you can fire on?

Ok i dug a bit deeper ... my rules actually only work if I run tslint from the node_modules.bin\ working directory of my project. If I try to run the exact same command somewhere else, all the custom rules go away.
To me it really seems like some odd dependency problem is going on between the tslint in my node_modules folder and the tslint that is globally installed on my computer.
:confused:

I updated the typescript dependency in my module from Version 1.9.0-dev.20160315 to Version 1.9.0-dev.20160408 (typescript@next) and the problem seems to be gone.
Not sure what the exact root cause of the problem was, but in the end it seems to have been just another funky npm dependency problem :laughing:


Unhandled rejection 'sendMessage timeout'

Hello, I'm using this great API to connect Homey (home automation hub) to ESPhome devices.
Mostly working out great for the usages I need, but I get the rejection below often.
Seems it doesn't have any consequence, but still pollute my statistics.
I don't understand the concept of rejection, so I hav' no idea how to fix it.
Any idea?
The stack trace doesn't provide any information about the message failing, maybe additionnal logs would be usefull.
Error: sendMessage timeout
    at Timeout.<anonymous> (/app/node_modules/@2colors/esphome-native-api/lib/connection.js:201:20)
    at listOnTimeout (node:internal/timers:569:17)
    at process.processTimers (node:internal/timers:512:7)

I made a class to abstract this API integration into my app, maybe I'm doing something wrong?
https://github.com/Baldhor/Homey-ESPhome-Enhanced/blob/main/drivers/esphome-wizard/client.js

hm i thinks , more beautiful code and try/catch in
https://github.com/DrozmotiX/ioBroker.esphome/blob/main/main.js#L602
you can make reconnect and resend command ... i see you not use reconnet on client  (if service ping will not respons, you lost connect to esp)
I recommend checking the connection status before sending a message and if the status is false, then reconnect

hm i thinks , more beautiful code and try/catch in

thank you for this feedback of my code :)
@Baldhor
this is indeed an async/promis issue which should be threated as try/catch error handling as provide in the example on my repo.
I basically always ensure to only send command to an connected device, if you try to send something the class is not initialised the module throws an exception.
This exception is fine based on how to deal with async/await in javascript but requires error handling when calling the function.
I think, as @twocolors already mentioned, you should be fine by checking on connection before sending the command.
This also allows you to build a kind of queue (which I not dit on purpose) to resend commands if a device comes back online.
but please be careful with that, it may cause unexpected behaviour by just "handling a cached queue of commands"

Thank you for your answer, and sorry for the delay.
I will take a look in the source code you pointed out.
Yes, I'm currently handling reconnection in a strange way and not using the builtin reconnect function, I will try to change it too.

Yes, I'm currently handling reconnection in a strange way and not using the builtin reconnect function, I will try to change it too.

any reason for that ?
I use the reconnect function provided by this module and it works fantastic. In situation the device disconnects and also if you start a connection but the device is not (yet) available.
Error events are also nicely forwarded, build some error handling around it https://github.com/DrozmotiX/ioBroker.esphome/blob/main/main.js#L594-L661

any reason for that ?

Few weeks ago, I had a memory leak in my app, and I thought this lib was the root cause :)
After few days, we understood it's coming from the console.re integration (... I still didn't find the exact root cause). I'm planning to fall back to my old integration of esphome lib, which was using native reconnect feature.

Ah understood, yea memory leaks can be hard to find/solve as far I have seen no memory leak detected with this module so far

Ok so from what I understand, the only thing I was missing is to try/catch the error on connection attempt.
        // Connect (after the listener are added!)
        try {
            await this.nativeApiClient.connect();
        } catch (error) {
            this.error('Error while processing reconnection:', error);
        }

The error I listed in the original post actually doesn't happen when sending a "state" command, but only for connection, hello, bluetooth, ...
I will push the update to my users and see the result :)

ah wait, my bad.... not the issue here is not an missing await etc, but you are trying to make a change (so send message) to an device which is not connected.
In my code I use a memory variable to monitor my connection state and ensure that I only send commands to devices which are indeed connected.
so my advice is to implement something similar on your side, never send a command to an client which is not connected and the exception should be solved

But I go through the function;
    sendCommandMessage(message) {
        if (!this.connected) throw new Error(`Not connected`);
        if (!this.authorized) throw new Error(`Not authorized`);
        this.sendMessage(message);
    }

The connection status check is embeded inside.
And as far as I can tell, the error message "sendMessage timeout" only apply when going through "sendMessageAwaitResponse".
Anyway, I confirm the previous try/catch doesn't solve the issue, but I found it could happen when disconnecting, so I added a try/catch there too ...

Anyway, I confirm the previous try/catch doesn't solve the issue, but I found it could happen when disconnecting, so I added a try/catch there too ...

@twocolors so maybe we have an issue here.
basically I handle that check outside of the module, but it looks like internal the module is not verifying connection state on message handling causing this issue.
For me it works as I don't call that function at all but check already in my code

https://github.com/twocolors/esphome-native-api/blob/ffb417d99db0540a4982dc2bcb115c2927156f93/lib/connection.js#L187
https://github.com/twocolors/esphome-native-api/blob/ffb417d99db0540a4982dc2bcb115c2927156f93/lib/connection.js#L201
if you not use recconect in moduls , chack if client connect ... you send commant not have answer and catch error

To summarize:

I moved back to auto reconnect feature of the api, it's working fine.
I added a try/catch around calls to connect/disconnect => since 3 days, I don't have any "sendMessage timeout" errors

Thanks for your help!

To summarize:

I moved back to auto reconnect feature of the api, it's working fine.

I added a try/catch around calls to connect/disconnect => since 3 days, I don't have any "sendMessage timeout" errors

Thanks for your help!

Happy to hear that, have fun coding 👌