[VSCODE] published v1.6.0 doesn't have paramTypes

Describe the bug
Prettier-SQL.paramTypes is missing from both VSCode's marketplace's details page and settings. Version v1.6.0 (both installed and on Marketplace)
To Reproduce
Steps to reproduce the behavior:
Marketplace:

Go to Extension's Marketplace page
Click on '....'
Scroll down to Configuration
There is no 'Prettier-SQL.paramTypes' option

Settings:

Go to .vscode/settings.json
Add

    "Prettier-SQL.paramTypes": {
        "custom": [{ "regex": "\\{[a-zA-Z0-9_]+\\}" }],
    },

Get a 'Unknown Configuration Setting' message.

Expected behavior

'Prettier-SQL.paramTypes' existing on Marketplace page
"Prettier-SQL.paramTypes" option being recognized in settings.json

Screenshots
settings.json:

Extension's details page on Marketplace:

Usage

What SQL language(s) does this apply to? - Probably all
What VSCode version are you using? - 1.80.0
What are your currently configured VSCode settings for the prettier-sql extension, if relevant to the issue?:

    "Prettier-SQL.expressionWidth": 140,
    "Prettier-SQL.tabulateAlias": true,
    "Prettier-SQL.paramTypes": {
        "custom": [{ "regex": "\\{[a-zA-Z0-9_]+\\}" }],
    },

Additional context
This is sad

It's indeed sad that there hasn't been a release of the VSCode plugin since 15th Februrary 2023.
@inferrinizzard, who owns the plugin in VSCode marketplace, has not been releasing it and he hasn't responded to any pull requests to the plugin repository. I have postponed creating a new plugin in VSCode marketplace to replace it, as I really wouldn't like to do it, but I think there isn't much else I can do.

I'm happy to report that finally there's a new extension is Visual Studio Marketplace: SQL Formatter VSCode
It's a successor of the old "Prettier SQL VSCode" extension.


publish libp2p resource manager metrics

Resource manager dashboard is ALIVE!
https://protocollabs.grafana.net/goto/aPl18i0Vk?orgId=1


HtmlWeb Class Missing When HAP is upgraded.

Xamarin.Forms application with PCL and UWP, iOS and Droid implementations. PCL is configured as TargetFrameworkVersion = v4.5 and TargetFrameworkProfile = Profile111. Have no problems running HAP with version 1.5.1 but when I upgrade to 1.6.1, the HtmlWeb class is not available anymore and is not shown in the Object Browser either. Recommendation ?

Hello @dbolak ,
Do you think you could tell us to which package directory inside HtmlAgilityPack package the version for v1.5.1 and v1.6.1 are pointing?
Perhaps there is a small difference here and that will help us to understand what's happening.
Best Regards,
Jonathan

Currently I have 1.5.1 installed and the reference inside the PCL project points out to:
C:\Users\HDBolak\Source\Repos\OOVxfAtInvstr\packages\HtmlAgilityPack.1.5.1\lib\portable-net45+netcore45+wpa81+wp8+MonoAndroid+MonoTouch\HtmlAgilityPack.dll
I will upgrade to 1.6.1 and report.

With 1.6.2 (sorry about the typo earlier):
C:\Users\HDBolak\Source\Repos\OOVxfAtInvstr\packages\HtmlAgilityPack.1.6.2\lib\portable-net45+netcore45+wpa81+wp8+MonoAndroid+MonoTouch\HtmlAgilityPack.dll

And here is the error:
Severity	Code	Description	Project	File	Line	Suppression State
Error	CS0246	The type or namespace name 'HtmlWeb' could not be found (are you missing a using directive or an assembly reference?)	OOVxfAtInvstr	C:\Users\HDBolak\Source\Repos\OOVxfAtInvstr\OOVxfAtInvstr\OOVxfAtInvstr\Popovers\popOverPageSendSharedExternalContent.cs	221	Active
HtmlDocument class is used in the next line and there is no problem on that line.

Thank you @dbolak ,
The issue has been found. I will try to fix it and make a new release on Tuesday.
Best Regards,
Jonathan

Hello @dbolak  ,
The v1.6.3 has been released,
HtmlWeb should now be available again. I'm really sorry for this mistake, that happened when I moved all file into a shared project.
Let me know if that's fixed.
Best Regards,
Jonathan

@JonathanMagnan Thank you very much for your kind attention. The issue is fixed. Kind Regards. Dogan.


Way to ban user

Hi everyone! Today my bot was under spam attack. I don't know what was the purpose of this attack, but in stats I see many messages with links to porn sites.
Is there any way to ban user by his id? Now I see one way to do it: filter from.id in _processUpdate func. Maybe there's more elegant way to solve this problem?

Hi @rsboarder, your bot is in a group? did you try with https://github.com/yagop/node-telegram-bot-api#telegrambotkickchatmemberchatid-userid--promise method?

Use the TelegramBot#kickChatMember().

What if the user is't on a group? There is a way to unsubscribe that user?

No. Use a federation bot like rosebot.


Crash on iOS / Apple devices when having multiple tabs with ArcGIS Server Map Service as basemap

We have encountered an issue where Map Series crashes with the following error in the browser:
Safari:
"a problem occurred with this webpage so it was reloaded"
This happens a few times and then it will display an error instead of the Map Series app.
Google Chrome
"Aw snap! Something went wrong while displaying this web page".
So far, we have only tested on a few devices, but the only common pattern right now is that the devices where the crash occurs have FullHD (1920x1080) or higher resolution. Like iPad 3 or iPhone 6 plus.
Android seem to work fine, as well as any Desktop browser, including Safari on Mac OS X.
UPDATE:
This has been logged as BUG-000105450:
Using custom basemap causes the storymap series to not load and receive error if opened in Iphone devices with resolution 1920x1080 pixels and above. Workaround: NA

Having the same issue. Following to see if there is a resolution


Fix usage of a class that was deprecated in Symfony 7.1

Fixes this error spotted while updating apps to Symfony 7.1:
The "Symfony\Component\HttpKernel\DependencyInjection\Extension" class is considered
internal since Symfony 7.1, to be deprecated in 8.1;
use Symfony\Component\DependencyInjection\Extension\Extension instead.
It may change without further notice. You should not use it from "SymfonyCorp\Connect\DependencyInjection\SymfonyConnectExtension".

Friendly ping @fabpot in case you have some time to review this one. Thanks!


[utils] Add support for multiple search results for serpapi

This PR proposes updates to the serpapi Python library to add support for multiple search results and currency converter feature.
Problem:
The current implementation of the serpapi Python library fetches only the first search result for a query even if the num parameter is set. This limits the usability of the library to fetch a more comprehensive search result list. Additionally, the library does not support the currency converter feature available in some search engine results pages.
Example:
Before it would scrape:
Bitcoin USD price, real-time (live) charts, news and videos. Learn about BTC value, bitcoin cryptocurrency, crypto trading, and more.
The live price of Bitcoin is $ 24,475.15 per (BTC / USD) today with a current market cap of $ 472.29B USD. 24-hour trading volume is $ 28.68B USD.
February 20, 2023 - The current price of Bitcoin is $24605.78 per (BTC / USD). Bitcoin is 64.23% below the all time high of $68789.63.
The live Bitcoin price today is $24,501.18 USD with a 24-hour trading volume of $29,043,133,446 USD. We update our BTC to USD price in real-time.
Bitcoin's price today is US$24,874.07, with a 24-hour trading volume of $26.63 B. BTC is +1.36% in the last 24 hours. It is currently -1.29% from its 7-day ...
Get Bitcoin/USD Coin Metrics (BTC.CM=:Exchange) real-time stock quotes, news, price and financial information from CNBC.
Bitcoin Price is at a current level of 24642.79, up from 24628.82 yesterday and down from 40073.50 one year ago. This is a change of 0.06% from yesterday ...
Find the latest Bitcoin USD (BTC-USD) price quote, history, news and other vital information to help you with your cryptocurrency trading and investing.
The Bitcoin (BTC) live price today is $24517, changes over 24H (-0.23%). Current market cup is $473.10 B. All given information about Bitcoin (BTC) updated ...

But, it only returned:
Bitcoin USD price, real-time (live) charts, news and videos. Learn about BTC value, bitcoin cryptocurrency, crypto trading, and more.
Solution:
To address the above problem, this PR proposes the following updates to the serpapi library:
Add num parameter to _get_default_params() function: The num parameter is set to a default value of 3 to fetch the top three search results. The returned search results are then concatenated to form a single string.
Update snippet extraction code to handle multiple search results: With the updated num parameter, the library extracts all search results' snippets instead of just the first one. This is done by looping through all the search results and concatenating the snippets.
Add support for currency converter: The library is updated to support currency conversion results available in some search engines. The currency converter result is appended to the end of the snippet string, along with the currency symbol.

Sounds good. Without breaking anything, I can just set default num to 1. Because we are scraping for 10 results by default. Then later, we can add a new method. Agree?

sounds great!

@hwchase17 Found bug. Let me fix it first.


feat(@vtmn/css): add chip component

Pull Request checklist
🚨 Please review the guidelines for contributing to this repository.

[X] Make sure you are requesting to pull a topic/feature/bugfix branch. Don't request your main!
[X] Check the commit's or even all commits' message styles matches our requested structure.
[X] Check your code additions will fail neither code linting checks nor unit test.
[X] Check PR name, it must follow the https://www.conventionalcommits.org pattern
[X] If it's a new component in CSS, ask for design review

Description

Add the chip component with all variants
Improvement on the badge component (fix font-weight, line-height and min-width)
Fix card linear-gradient
Fix hover color for the text-input box-shadow

Does this introduce a breaking change?

No

❤ Thank you!

Hi @GaspardMathon, I let you check my suggestions :)


Connection Problems with the node

Hello, something went wrong.
This is in the error log:
[19/05/2019 09:03:22.119] [LOG]    Failed to fetch neighbors of own node. Request failed with status code 405

Hi, thx for the feedback! Did the application crash? Did it ever work? Does inschpektor run on the same  machine as your node.
Do you know how it happened?
I'm just trying to gather as much unformation as possible to understand how this happened. :)

Hi,
thank you for the fast answer. The application did not crash. The inschpektor showed me some Infos about my node correctly. I installed the inschpektor on the same maschine as my node. Pls have a look at the screenshots. Maybe its an initialising problem....

It looks like the call to your node fails for some reason. Are you sure you've set it up correctly?
Did you set it up with the correct values, otherwise you can click "Reset Inschpektor" and start over again.
Just to exclude some mistakes:

You don't switch the HTTPS to "true", even if your node is reachable over https.
As address/endpoint you just type "localhost"

The rest of the values aren't connected to this issue. Please try that and give feedback if that helps, otherwise we have to look further into it. 👍
Here is a video I once made, it will probably be what you need (timestamp, you don't need to watch the whole one): https://youtu.be/EjXs7kpBqjQ?t=309

He still show me the dashboard. I followed exactly the instructions from the video, but it doesn't work. Instead the ip address, i entered localhost. I see the same parameter like above...

Can you execute the following line in a terminal on the machine where inschpektor runs?
-X POST \
-H 'Content-Type: application/json' \
-H 'X-IOTA-API-Version: 1' \
-d '{"command": "getNodeInfo"}'```

Please tell me the result, because this seems to be where inschpektor fails to gather the info.

This is the result:
paul@paul-Macmini:~$ curl http://localhost:14265 \

-X POST
-H 'Content-Type: application/json'
-H 'X-IOTA-API-Version: 1'
-d '{"command": "getNodeInfo"}'
{"appName":"IRI","appVersion":"1.7.0-RELEASE","jreAvailableProcessors":4,"jreFreeMemory":280429912,"jreVersion":"11.0.2","jreMaxMemory":4135583744,"jreTotalMemory":673185792,"latestMilestone":"IIANIDOXDWXIYMODKTIYLMKPHZUAIINOPDKFHNDACR9FD9SDLKBXYXZGKPGZGJZPYAVXMJNJRBLVZ9999","latestMilestoneIndex":1071802,"latestSolidSubtangleMilestone":"IIANIDOXDWXIYMODKTIYLMKPHZUAIINOPDKFHNDACR9FD9SDLKBXYXZGKPGZGJZPYAVXMJNJRBLVZ9999","latestSolidSubtangleMilestoneIndex":1071802,"milestoneStartIndex":1071192,"lastSnapshottedMilestoneIndex":1071694,"neighbors":6,"packetsQueueSize":0,"time":1558260909293,"tips":5222,"transactionsToRequest":61,"features":["snapshotPruning","dnsRefresher","zeroMessageQueue","tipSolidification","RemotePOW"],"coordinatorAddress":"EQSAUZXULTTYZCLNJNTXQTQHOMOFZERHTCGTXOLTVAHKSA9OGAZDEKECURBRIXIJWNPFCQIOVFVVXJVD9","duration":0}paul@paul-Macmini:~$ ^C
paul@paul-Macmini:~$ ^C
paul@paul-Macmini:~$

Ok, this looks correct. Are you running inschpektor with sudo? I doubt that this solves the problem, but who knows. Because exactly this config "works on my machine". :)

i started inschpektor with the command: sudo inschpektor

Is your inschpektor publicly exposed? Could I access it? I might be able to gain some info from my browser devtools.

it should be, what do you need?

I mean, do you have a DNS setup like https://hans.de that I could use to reach inschpektor?

Good question, i entered my public node address like that, piota-node.net:14265, but it didnt work. It works only via the public ip adress. I knwo this sounds a little bit confusing....

I will run inschpektor with the public ip just a moment

If you are in discord, we could also move there, because everything you write here is publicly viewable. I'm in the iota channel as codepleb.
And also on Telegram, @codepleb

hmm now i can't login, wrong pw?

ok

Info: Turned out that the node had the getNeighbors call blocked. Since this is unrelated to inschpektor, I close the issue here. Thanks for the feedback!


Coverall badge added

Added coveralls.io badge and istanbul coverage report command.

Changes Unknown when pulling 190cb98fd11895fc220bb2df5d45bab6226e9752 on qvantor:coverall_bage into ** on exonum:master**.

Changes Unknown when pulling 4f454a4b6b3db5e660981778a510cc6c89bc9992 on qvantor:coverall_bage into ** on exonum:master**.

Changes Unknown when pulling 4f454a4b6b3db5e660981778a510cc6c89bc9992 on qvantor:coverall_bage into ** on exonum:master**.

Changes Unknown when pulling 4f454a4b6b3db5e660981778a510cc6c89bc9992 on qvantor:coverall_bage into ** on exonum:master**.

Changes Unknown when pulling 4f454a4b6b3db5e660981778a510cc6c89bc9992 on qvantor:coverall_bage into ** on exonum:master**.

Changes Unknown when pulling b25d22ab0adac019f74c7b483adb808b929b2051 on qvantor:coverall_bage into ** on exonum:master**.


Rolling back hasMany associations

Hi there, thanks for this awesome library.
I may have found a bug with tracking changes to hasMany associations. For example, if I have a Foo model with a users hasMany association, and I update the users prop, there is no change logged in changeset.changes(). In my use case, I noticed this while trying to rollback changes on a Foo model.
Ember Twiddle reproducing the issue: https://ember-twiddle.com/3bb755fcdf978eadfaa498acb5e777ca?openFiles=templates.application.hbs%2C
Please let me know if you need more info or if I'm doing something dumb. Thanks!

@poteto looking through past issues (https://github.com/DockYard/ember-changeset/issues/5), it seems like this should be supported?

The problem was that I was mutating the association directly: post.comments.pushObjects() instead of through the "owner" model wrapped by the changeset this.set('post.comments', [comments]) for example.


Swedish message translation!

messages_sv.zip
I created a Swedish message translation for MinecraftMarket!
Enjoy! :)
/Simpis_

messages_sv.zip
I polished little and edited some colors. :)
Enjoy! :)
/Simpis_

Uhmm you are supposed to edit files not upload them.


Actionbar is not moved with the hotbar

Actionbar does not move with the hotbar changes, this results in it clipping into the hotbar
Command: /title @s actionbar "text here"

This is already known and will be tweaked in the next version to be released.


Add alembic

This PR
Alembic manages database migrations
To apply migrations up to the latest run:
poetry run exec alembic upgrade head

When we deploy the app for real we'll be able to use these to manage production DB changes as well
Migrations coming in next PRs
Also
Makes some changes to poetry to:

Fix commit hooks
Add a generalized "exec" command for running alembic migrations and other things

Is the additional requirements file necessary for Alembic? if we can keep all dependencies in pyproject.toml this will allow poetry to manage versioning and builds w/o conflicts.


Add connection to databricks

Duplicate of #481. Trying a different clone to see if the tests pass from here.

Did not work, closing this PR


Accessing map from other script

Can we make variable with google map instance as window.jsStoreLocator to access it from other scripts ?
This partly request/issue as I am not able to use autocomplete for filtering pubs by name I use external script to populated list from json and Im using js-store-locator only to find pubs by postcode in same 'input field'.

This project is in an unmaintained state. I suggest you look at our Google Maps APIs Solutions for currently maintained store locator solutions.


Apache Kafka Consumer - using variables

Hi, is there a problem substituting a variable in the "Maximum duration of consumption" field instead of the actual value?  I am using PDI <IP_ADDRESS> and the latest version of the kafka consumer.  When I use a variable to this field it keeps getting removed and replaced with the value "0".

Fixed in the next version.

Thanks


$injector.invoke calls aren't correctly annotated

The following code which is inside a directive's link function does not get annotated:
// Compile new element
$injector.invoke(function($compile) {
  $compile(myElement)(scope);
});

Previously posted at mzgol/grunt-ng-annotate#15.

Our use case involves running some setup code before bootstrapping angular.  This setup code calls the $injector.invoke() method.  Since it is before angular bootstraps, it is outside of any angular modules.
I see the comment in 460913

// matchInjectorInvoke must happen before matchRegular
// to prevent false positive ($injector.invoke() outside module)

Our code, run on page load in a IIF at the global level, not annotated:
var $injector = angular.injector();

$injector.invoke(function($kinvey, ENV) {
// do stuff, then bootstrap angular
});

Thanks in advance.

@levithomason the annotate-only-when-inside-angular-modules is to reduce the risk of false positives. ngInject to the rescue! Try: $injector.invoke(/*@ngInject*/function($kinvey, ENV) { ... }).

Awesome, still better than manually injecting :)  Thanks


ACG token

contract address： 0x984C134A8809571993Fd1573fB99F06Dc61E216f
symbol： ACG

ERROR! json file name 0x0b6bc42cb9b89259a3aa986363fa37a9cbf03b8e.json parse error, please check first (maybe has some unnecessary space or comma symbol like ",")
npm ERR! Test failed.  See above for more details.

0x0b6bc42cb9b89259a3aa986363fa37a9cbf03b8e.json   这个文件不是我上传的


Does mailin stop working?

My code has been used for 3 month, but it stopped working a couple of days ago. And I tried the demo on the home page, the demo account didn't work as well.

@donle the demo is down due to some dns issues. For your code, I don't see any issue that would stop it working. Did you upgrade your node version or something?

@Flolagale No, I didn't do any changes. If there is no issue regarding the mail server, then my problem could be solved anyway. Thanks!


Update readme, add --help option

So, I was testing the beta branch and it all works on my system, so if it's working on yours as well we can merge it into main.
But also, I have this pull request to add to it
Stuff changed:

added more details to the readme
added --help option with basic usage, also has a message at the bottom saying if you're running in wayland or x11 mode, and then removed the "echo $whatDis" line from eses-beta.
replaced the spaces in the indented areas with tabs, which wasn't necessary but I did it anyway
Also, added -a eses to all of the notify-send lines, because that way if anyone wants to have custom rules for eses notifications they can, and also if we ever have an icon (unlikely, but you never know) it should show up on notifications.
I also removed the -t 1000 lines from the wayland notify-send commands, because it makes the notifications show up for only one second and I only added it for my laptop's sake. (I like these notifications to only show up for a moment)

Please test it out, I've been testing it myself and it all looks good but it'd be nice to have a second opinion

noice, glad to hear its working in the wayland too (well i just copy pasted everything from your code tho)
i will test this, and will merge it if theres no problemo

I'm from Alberta, Canada, so UTC-6 right now. As of writing this it is 21:14 (or 9pm)
You?

everything works beautifuly!
i will merge this to beta branch first, when im done messing with it, im gonna merge this to main branch!
ah damn im started to wanting to create GUI version of this, but man i dont know if this are necessary

Sounds good to me! Are you thinking of a gui version just for having like, dedicated buttons for the different options?

yes, im thinking of gui that have 2 big button with icon for both --whole and --select options. and after screenshotting it will show the preview and there will be button to either put it on clipboard or save it as file, or copy the scanned result if theres qr code
zenity are not enought for this, may be this can be done using C? (i never made any gui application so i think this is a good reason to start learning making GUI)
what do you think?
yeah there so much difference in our time, my day are started when your day is almost end. its so funny
thank you for telling me! now i know when to check the github if theres any pull req from you

Interesting. I don't know any actual programming languages so if we do it I'll have to learn whatever we write it in, but I've been thinking I should learn at least the basics of one of them for a while now so no complaints here

i will try to make something like that
btw how can i merge the beta branch to main branch without merging the README.md file :"

I'm not sure. I'm still learning how to use git

ah damn git is hard

Yep. I've been busy all day but I think our best bet is probably to make a new branch from this beta one, and add a new commit that changes everything to be eses instead of eses-beta, and then merge that with main. And then whenever we have to add more things from beta we could use git rebase (I haven't used it but I think I know how it works, probably) to move the commit changing names to be after the changes again
Don't know if it'll work but it might, I'll mess with it tomorrow probably


Improvements to AESCryptoService

Reduce Cipher.getInstance calls to once per file vs once per block
Move wrap cipher to ThreadLocal thread
Add flush at the end of createCryptoParameters() before returning the byte array
Add logger and init checks

@dlmarion I noticed you ignored this error in the change you made against my branch:

[ERROR] High: The cipher does not provide data integrity [org.apache.accumulo.core.spi.crypto.AESCryptoService] At AESCryptoService.java:[line 95] CIPHER_INTEGRITY

Do you know why this is being flagged for the use in ThreadLocal?

@dlmarion I noticed you ignored this error in the change you made against my branch:
[ERROR] High: The cipher does not provide data integrity [org.apache.accumulo.core.spi.crypto.AESCryptoService] At AESCryptoService.java:[line 95] CIPHER_INTEGRITY
Do you know why this is being flagged for the use in ThreadLocal?

I resolved that here

Tested encryption using Uno and CI.


ProtocolLib error at startup

What version of ViaVersion are you using? Type /ver viaversion
0.7.4
What version of Spigot are you using? Type /ver
1.8.8-R0.1-SNAPSHOT
What plugins are you using? Type /plugins
http://prntscr.com/aohue2
Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
Latest version.
http://prntscr.com/aohuna
How does this error happen? login? Using an item?
When i remove ProtocolLib it's ok but when there is ProtocolLib (same version of other servers) i have the error.
Is there an error in the console? Use pastebin.com. Is there a kick message?
ProtocolLib error at startup : http://pastebin.com/uzYD3sk2
ProtocolLib kick error : http://pastebin.com/PdAvjajF

Are you sure you're running the latest version?
Can you do /viaver and print screen output.

Yes i am
http://prntscr.com/aou2eu

@MisterIdeas Try to remove skinsrestorer from bungeecord and skinsmoudle from spigot server and restart then check if the bug still exist, if it does try to test it on online mode.
Also for better bugs detection change debug=false to debug=true in server.propertise. Finally post the entire server log using pastebin.com

http://pastebin.com/v24Tk6yp

Ensure all your plugins are up to date, this is not a ProtocolLib issue it will be down to a plugin that uses. I'd suggest removing plugins until you can't replicate so you can work out which it is.

Closing, if you have this issue open new ticket.


[BUG] upper expression documentation is out of date

The documentation describing the reasons why upper is not supported on the GPU by default is out of date.  It claims that the plugin cannot handle cases where characters change byte widths during the operation and points to a cudf issue which has been resolved.
We're still missing some corner-case characters, depending upon the Unicode standard the JVM is targeting, but I believe we're now covering most of the cases where the byte width changes.  The docs should be updated to point to either a new cudf/plugin github issue tracking what's left to do or other documentation that describes the cases that are currently not handled.

Once we document this, we may want to consider having upper back on the GPU by default.

Since we've set spark.rapids.sql.incompatibleOps.enabled=true, I'd like to continue to chip away at configs users need to set on their own.   @andygrove are you familiar with the remaining upper, lower and initcap corner cases?  I am wondering if we just need to document those, or if there is additional work pending to enable these operations.
Also, our documentation seems to imply that setting incompatibleOps to true will enable even upper, lower and initcap to be true.  I am not sure if that is the case or not.  If not, we should clarify the docs.
From the docs :

NOTE: Setting spark.rapids.sql.incompatibleOps.enabled=true will enable all the settings in the table below which are not enabled by default due to incompatibilities.


Connection.writer and Connection.reader goroutines are not stopped after Close()

After Connection.Close() is executed Connection.writer and Connection.reader gorutines are not terminated when main goroutine is still running. As Close() closes but  Connection.write channel writer goroutine is receving nil values from it and bombards Kodi with empty requests. Example code and output are [here] (https://gist.github.com/quhar/d8b47444e67b7160362b).
I've created small [fix] (https://github.com/quhar/kodi_jsonrpc/commit/b27e9292f124e48b278078d528ddedbed10436e1), but as I'm very new to Go I'm not sure if this is the way to do it.

This was almost the first Go code I wrote and I've been seriously considering rewriting it, I'll take a look and see what the best way to fix this is.

Please take a look at https://github.com/pdf/kodirpc which is a rewrite that does not use the same pattern, and should be unaffected by this issue.


unsupported system : freebsd

when I try to install with "pip install webrtc-noise-gain" get the following error (Unsupported system: freebsd):
Installing build dependencies ... done
Getting requirements to build wheel ... error
error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [20 lines of output]
Traceback (most recent call last):
File "/usr/local/share/homeassistant/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in
main()
File "/usr/local/share/homeassistant/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
json_out['return_val'] = hook(**hook_input['kwargs'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/share/homeassistant/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
return hook(config_settings)
^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-sdqfvtln/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 355, in get_requires_for_build_wheel
return self._get_build_requires(config_settings, requirements=['wheel'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/tmp/pip-build-env-sdqfvtln/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 325, in _get_build_requires
self.run_setup()
File "/tmp/pip-build-env-sdqfvtln/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 507, in run_setup
super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
File "/tmp/pip-build-env-sdqfvtln/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 341, in run_setup
exec(code, locals())
File "", line 384, in
ValueError: Unsupported system: freebsd
[end of output]

same problem here. Looks like error is thrown here: https://github.com/rhasspy/webrtc-noise-gain/blob/0b3bc23f5f33101df5b8f1970919500d8629b955/setup.py#L384
I'll try to patch it to threat freebsd the same way as linux and see what will happen.

Just treating it as linux is not enough. So far pip doesn't complain, however both clang, gcc12 and gcc13 fail to build something that is required.
gcc13 complains about /usr/local/include/python3.11/pymacro.h:10:25: error: '_Static_assert' was not declared in this scope; did you mean 'static_assert'?
clang complains about
/tmp/pip-req-build-qixxzok2/webrtc-audio-processing/webrtc-audio-processing-1/rtc_base/platform_thread_types.cc:46:10: error: cast from pointer to smaller type 'rtc::PlatformThreadId' (aka 'int') loses information
        return reinterpret_cast<PlatformThreadId>(pthread_self());

I think the problem may be in webrtc-audio-processing library itself but hopefully someone who knows more than me will speak about that.
If someone wants to install it themselves, then I used pip3 install  git+https://github.com/LukaszMoskala/webrtc-noise-gain.git or CC=gcc13 CXX=g++13 pip3 install  git+https://github.com/LukaszMoskala/webrtc-noise-gain.git

https://github.com/rhasspy/webrtc-noise-gain/pull/7

Just in time when I also fixed it (at least it builds, I don't know yet if it actually works).
I'll be trying whatever I did later tonight, but if someone wants to try my code, I just did pip3 install git+https://github.com/LukaszMoskala/webrtc-noise-gain.git and it worked. I don't know if homeassistant with this will actually start

HA starts with my patch. I am actually using the voice stuff, so I will test later and see if everything is in order.

It looks like voice assist isn't working, but I really don't think it is because of any of this. I see data going to whisper in a packet capture, but nothing happens after that.

Looks like removing default_config: from configuration and including whatever it used to include manually, but skipping assist_pipeline should work as a workaround untill your patch is merged.
Also your patch installs correctly, however my homeassistant still does not start, due to unrelated (I belive) problems with numpy so I'm not able to test it now

I believe the esphome plugin depends on the assist_pipeline so this will need to be disabled as well.

I can confirm that

the package is installing with the patch.
HA starts after manually installing that patch and without disabling any module.

I do not use voice stuff, so I cannot confirm it's effectively working on my side.

PR has been merged. Let me know if the issue has been resolved.

I didn't notice this when I read the PR, but the meson patch adds dragonfly/freebsd/netbsd/openbsd (yay) but the setup.py only adds freebsd.  I have a patch to fix setup.py to have all 4, and will submit a PR shortly.

Also, does anyone understand what's going on with https://gitlab.freedesktop.org/pulseaudio/webrtc-audio-processing/ ?  Looking at pull requests for OS support being open for years, It does not immediately appear healthy.   It's really nice to see things getting merged here.

I realize there is still an open question as to whether the BSD support is 100% working, but coming here as a hass user I see the "hass fails to install on BSD" as really serious and "new feature for voice commands doesn't work" as much less so, in terms of urgency to resolve and not being so much of a regression.
Therefore I think it would be good to tag a release and ask HA upstream to merge a bump, so that 2023.11 will install ok.  And yes, I realize that there is a likelihood of needing a new release and bump next month, but I think that' s ok; we won't run out of integers to label them with!

I know, but a release and bump is still fair with 'bug fixes' :-)

Thankfully this is the first result in Google for "webrtc-noise-gain freebsd" which I think is the obvious thing to search.  Thanks for the work done here :)
(I also don't care about the voice stuff :))

I have just verified that this patch and all voice functionality are working in 2023.10.4.

The home assistant maintainers are actively hostile to anyone not using their own Linux distribution, so good luck with that.

I don't know about your specific experience, but I believe it's largely an issue of limited human resources.

The home assistant maintainers are actively hostile to anyone not using their own Linux distribution, so good luck with that.

I don't know about your specific experience, but I believe it's largely an issue of limited human resources.

Thank you for closing. I just wanted to say that they refuse any and all patches that would help. I'm not expecting white glove support; FreeBSD users are very much a self-supporting bunch.

Fair enough. I don't know anyone at Nabu Casa who uses FreeBSD as their daily driver. I have it indirectly via TrueNAS, but I'm also a little unusual within the team for running vanilla Debian 😄

Running Home Assistant in a jail, as opposed to a full fledged BHyve Linux instance, is so much more appealing to me. The fact upgrading to a newer version broke the Home Assistant mobile app for me is highly annoying.

Hello, I am stuck on this issue and (sorry) but can't find out what I am doing wrong:
When starting homeassistant in a jail (running on FreeBSD 13.3 with Python3.11) inside the homeassistant.log file I get:
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [20 lines of output]
      Traceback (most recent call last):
        File "/usr/local/share/homeassistant/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
          main()
        File "/usr/local/share/homeassistant/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/usr/local/share/homeassistant/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-pm0608a2/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 327, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=[])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "/tmp/pip-build-env-pm0608a2/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 297, in _get_build_requires
          self.run_setup()
        File "/tmp/pip-build-env-pm0608a2/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 497, in run_setup
          super().run_setup(setup_script=setup_script)
        File "/tmp/pip-build-env-pm0608a2/overlay/lib/python3.11/site-packages/setuptools/build_meta.py", line 313, in run_setup
          exec(code, locals())
        File "<string>", line 384, in <module>
      ValueError: Unsupported system: freebsd
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

As suggested I have tried to do the following:

Activate the venv with source /usr/local/share/homeassistant/bin/activate
Install webrtc-noise-gain patched version with pip3 install git+https://github.com/rhasspy/webrtc-noise-gain.git and it seems to be instialled fine:

Collecting git+https://github.com/rhasspy/webrtc-noise-gain.git
  Cloning https://github.com/rhasspy/webrtc-noise-gain.git to /tmp/pip-req-build-5so4bgwm
  Running command git clone --filter=blob:none --quiet https://github.com/rhasspy/webrtc-noise-gain.git /tmp/pip-req-build-5so4bgwm
  Resolved https://github.com/rhasspy/webrtc-noise-gain.git to commit 558acbbe6b4e63eac78ee7808c22fe6eb4753fb9
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done

When I do start HomeAssistant, anyhow, I always get the same error log as above.
What am I missing? What can I do to fix it?
Thank you!

You likely installed newer version than homeassistant requires, so homeassistant tries to downgrade it on startup.
You probably need to install older version with something like pip3 install git+https://github.com/rhasspy/webrtc-noise-gain.git#7be98ca4bd7f4218d5a63d40eff8e73882356da3 (be careful, your shell may treat commit number as comment).
I did not verify if this commit is correct and if it will work but that's probably what's happening, as, IIRC, homeassistant still uses version from before #7 was merged.
Also keep in mind that latest homeassistant versions require python 3.12 so that also may or may not be a problem.

Hello @LukaszMoskala you are right, I checked with pip list and I discovered that the patch is v.1.2.5. This leads HomeAssistant to try to install the (broken) 1.2.3 version.
I uninstalled it and I am trying with your suggestion now. I will let you know!

Hello, @LukaszMoskala it seems like your suggested alternative version is still 1.2.5. This leads HomeAssistant to act the same. How can I install a patched 1.2.3 version? HomeAssistant needs webrtc-noise-gain==1.2.3 and any difference in version will lead HA to try a new install...

Hi @pixel8383,
I can recommend the following guide I found on the Internet: https://blog.brendans-bits.com/posts/2024/home-assistant-2024.7-jail/
It has the exact command to install required version plus a lot of other useful information.

Hello @badrpc thanks for your input! I am not running FreeBSD 14 but I was able to use the suggested commit and it seems to be working now!

You need something like --skip-pip-packages aioesphomeapi on the HA command line, to tell it not to insist on its version.


Upgraded pinned down rspec-rails gem to 4.0.0.beta4 along with 41 other gems

Upgraded pinned down rspec-rails gem to 4.0.0.beta4 along with 41 other gems.
I will check the travisCI build after submitting this PR.

Checked the travisCI build/all green.

One last chance to merge this PR before I delete this PR later today.

WOW - ;( - Bye


Fix extensions not working

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #2926
Special notes for your reviewer:
If applicable:

[ ] documentation
[ ] unit tests
[ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@jackfrancis @ritazh @sozercan @trstringer @neurot1cal PTAL

@neurot1cal I think I found why you were running into an error with extensions even after that other PR. This PR should fix it.

/approve
/lgtm

Hi @CecileRobertMichon ..
Thanks for the fix.
It looks like the deployment is still failed.
OPERATION ID7D0BCEDB12F43E24
TRACKING ID5b69691b-120d-4f72-8189-a9220448301e
STATUSConflict
PROVISIONING STATEFailed
TIMESTAMP5/23/2018, 10:53:39 AM
DURATION36 minutes 27 seconds
TYPEMicrosoft.Compute/virtualMachines/extensions
RESOURCE ID/subscriptions/58043194-91b4-4390-be55-dd64251a67bd/resourceGroups/kzha_k8s_rg/providers/Microsoft.Compute/virtualMachines/k8s-agentpool1-35463463-0/extensions/cse-agent-0
STATUSMESSAGE{
"status": "Failed",
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'.",
"details": [
{
"code": "VMExtensionProvisioningError",
"message": "VM has reported a failure when processing extension 'cse-agent-0'. Error message: "Enable failed: failed to execute command: command terminated with exit status=4"."
}
]
}
}
RESOURCEk8s-agentpool1-35463463-0/cse-agent-0
I'm using 0.17.1 acs-engine: https://github.com/Azure/acs-engine/releases/tag/v0.17.1 and also regenerate the arm template, but the deployment still has the same issue.
Notes:  I was performing this on China Azure.

@CecileRobertMichon The deployment went through successfully, no failed extension messages anymore!

But when I look at the cluster, I dont actually see any prometheus/grafana pods. Any ideas?

@neurot1cal did you deploy this on the master or agent node(s)?

@trstringer agent. But I do have two linux pools, and one windows pool. It was playced in linuxpool2.

@trstringer Same thing with a single linuxpool. Trying again with no windows pool;
{
  "apiVersion": "vlabs",
  "properties": {
    "orchestratorProfile": {
      "orchestratorType": "Kubernetes",
      "orchestratorRelease": "1.10"
    },
    "masterProfile": {
      "count": 3,
      "dnsPrefix": "<REDACTED>",
      "vmSize": "Standard_D11_v2"
    },
    "agentPoolProfiles": [
      {
        "name": "linuxpool1",
        "count": 5,
        "vmSize": "Standard_D11_v2",
        "availabilityProfile": "AvailabilitySet",
        "storageProfile": "ManagedDisks",
        "extensions": [
          {
            "name": "prometheus-grafana-k8s"
          }
        ]
      }
    ],
    "linuxProfile": {
      "adminUsername": "<REDACTED>",
      "ssh": {
        "publicKeys": [
          {
            "keyData": "<REDACTED>"
          }
        ]
      }
    },
    "extensionProfiles": [
      {
        "name": "prometheus-grafana-k8s",
        "version": "v1",
        "rootURL": "https://raw.githubusercontent.com/Azure/acs-engine/master/"
      }
    ],
    "servicePrincipalProfile": {
      "clientId": "<REDACTED>",
      "secret": "<REDACTED>"
    }
  }
}

@trstringer @CecileRobertMichon Bingo. As soon as I removed the Windows nodes from the cluster definition, it worked. ;)

We do not currently support clusters with Windows agents with this extension.

/meow

@trstringer Understood - Adding to the list of things broken in with Windows nodes. :)
Should kubernetes-nodes-cadvisor work out of the box? And is there a plan to have kubelets be discoverable as targets in Prometheus?


Account for a sitename that coexist in regular stamp and ministamp

When sending a request to Observer GetWebSite API, Observer fails with 500 because it assumes that site names are unique to only one stamp.

One more case:
https://applensv2.azurewebsites.net/sites/LuiIntegrationv1-Prod/appanalysis
This is the case where the same site belongs to 2 ASEs:

aseprdcc01(waws-prod-sy3-b080b226)
aseprdcc01(waws-prod-ml1-5604b6e4)

As you see, both the mini stamps also have same name but different internal names.


usb: CDC_ACM do not (re)set irq flags internally.

Both tx_irq_ena and rx_irq_ena flags shall not be set or reset
within the CDC_ACM class. Those flags shall be used by actual user
of the CDC_ACM class allowing the CDC to receive/transmit data.
Both rx/tx_irq_ena flags are intended to be used to control USB serial device (CDC_ACM)
from application perspective, the class itself shall not update those under any condition.
Fixes: #27727
If mcumgr uses cdc_acm as serial backend the device will hang in uart_mcumgr_isr()
because the rx_irq_ena was always true.
Signed-off-by: Emil Obalski<EMAIL_ADDRESS>

@pabigot Would You mind having a look if it works for You? I've tested on my side and its okay.

I can not confirm performance issue testing with https://github.com/zephyrproject-rtos/zephyr/pull/22236/commits/91d24fbd805efdf14e3686a4bf793dc10b1cd387, but using mcumgr. The time it takes to respond, e.g. 4.212s is approx 100ms times number of characters, and is caused by k_sem_take timeout in cdc_acm_poll_out. What means that there are no IN tokens from the host during the poll_out calls. The time probably always depends on number of characters, and that is funny.

I wouldn't expect this change to introduce this problem, so the NACK is only until we understand why this is going on. If it's not related to this change, but just revealed by fixing #27727, then this is fine.

@de-nordic this is likely due to the fact that mcumgr uses uart_poll_out according to @emob-nordic and @jfischer-phytec-iot .

I wouldn't expect this change to introduce this problem, so the NACK is only until we understand why this is going on. If it's not related to this change, but just revealed by fixing #27727, then this is fine.

@de-nordic this is likely due to the fact that mcumgr uses uart_poll_out from the system workqueue, just like the cdc acm driver uses the workqueue, according to @anangl and @emob-nordic and @jfischer-phytec-iot .

@emob-nordic and @pabigot does this PR combined with #28408 solve both issues?

I wouldn't expect this change to introduce this problem, so the NACK is only until we understand why this is going on. If it's not related to this change, but just revealed by fixing #27727, then this is fine.

@de-nordic this is likely due to the fact that mcumgr uses uart_poll_out from the system workqueue, just like the cdc acm driver uses the workqueue, according to @anangl and @emob-nordic and @jfischer-phytec-iot .

Yes, the mcumgr will directly try to send out bytes, only the rx is collected to be processed by workqueue,
Shell also directly uses uart_poll_out for tx.

@pabigot Having both #28399 (this) and #28408 fixes the issues with performance. branch
emil@emil~$time sudo ~/go/bin/mcumgr -t 1200 --conntype serial --connstring dev=/dev/ttyACM1,baud=115200 echo hello12345678
hello12345678

real	0m0,051s
user	0m0,010s
sys	0m0,000s
emil@emil~$time sudo ~/go/bin/mcumgr -t 1200 --conntype serial --connstring dev=/dev/ttyACM1,baud=115200 echo hello1234567812312412431234
hello1234567812312412431234

real	0m0,055s
user	0m0,004s
sys	0m0,007s
emil@emil~$time sudo ~/go/bin/mcumgr -t 1200 --conntype serial --connstring dev=/dev/ttyACM1,baud=115200 echo hello12345678123124124312341234123541253
hello12345678123124124312341234123541253

real	0m0,059s
user	0m0,003s
sys	0m0,006s
emil@emil~$

@pabigot Having both #28399 (this) and #28408 fixes the issues with performance. branch

@emob-nordic Thank you.  After reviewing this I had suspected that might be the case, but didn't have time to go back and try it.


Adding react-id-swiper

Don't create a pull request to add a library, instead use devarchy.com/react.
Only create a pull request to change the categorization.
Open an issue if you are not sure how to change the categorization to fit a library you want to add.

Is there a reason why you didn't use devarchy?

@stalniy Should be working again


Branch fix find commands bugs

Codecov Report
Base: 77.21% // Head: 77.54% // Increases project coverage by +0.32% :tada:

Coverage data is based on head (9cc66fe) compared to base (e8330ae).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #191      +/-   ##
============================================
+ Coverage     77.21%   77.54%   +0.32%
- Complexity      759      763       +4
============================================
  Files           117      117
  Lines          2291     2293       +2
  Branches        287      287
============================================
+ Hits           1769     1778       +9
+ Misses          447      443       -4
+ Partials         75       72       -3

Impacted Files
Coverage Δ

...u/address/logic/parser/FindStaffCommandParser.java
100.00% <100.00%> (ø)

.../project/ProjectNameContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

...odel/staff/StaffNameContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

...task/TaskDescriptionContainsKeywordsPredicate.java
100.00% <100.00%> (+12.50%)
:arrow_up:

...in/java/seedu/address/commons/util/StringUtil.java
91.66% <0.00%> (-4.17%)
:arrow_down:

.../seedu/address/logic/parser/AddressBookParser.java
100.00% <0.00%> (+6.45%)
:arrow_up:

...in/java/seedu/address/storage/JsonAdaptedTask.java
100.00% <0.00%> (+17.24%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


add xml2js dep

Without this, it won't compile the app since some trigger in this project needs it.

It does install xml2js after adding the plugin. So you don't need to do it by hand. If you need to - then this is some issue.

Well I needed to. Can you try in your environment and see?
Sent from my iPhone

On Nov 5, 2015, at 12:09 AM, Nikolay Demyankov<EMAIL_ADDRESS>wrote:
It does install xml2js after adding the plugin. So you don't need to do it by hand. If you need to - then this is some issue.
—
Reply to this email directly or view it on GitHub.

Did that and it works. Will do some tweaks in the next version, maybe that will help in your case.

what version of the npm and node you are using?

i'm having the same issue. after ionic platform add ios i get:
Running command: /Users/zwacky/data/mc-webapp/mobile/hooks/after_prepare/020_remove_sass_from_platforms.js /Users/zwacky/data/mc-webapp/mobile
Error: Cannot find module 'xml2js'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at /Users/zwacky/data/mc-webapp/mobile/plugins/cordova-hot-code-push-plugin/scripts/lib/chcpConfigXmlReader.js:8:14
    at Object.<anonymous> (/Users/zwacky/data/mc-webapp/mobile/plugins/cordova-hot-code-push-plugin/scripts/lib/chcpConfigXmlReader.js:71:3)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)

node -v

v0.12.2

npm -v

2.13.2

Thanks, will investigate that.

No need for updating the docs with that. Should be handled by the plugin automatically.


The ".dll" cache loaded by FFI cannot be cleared

// Auto-generated with deno_bindgen
import { CachePolicy, prepare } from<EMAIL_ADDRESS>const opts = {
  name: "teyda_core",
  url: (new URL("../target/release", import.meta.url)).toString(),
  policy: undefined,
}
const _lib = await prepare(opts, {
  core_run: { parameters: [], result: "void", nonblocking: false },
  mh: { parameters: ["pointer", "usize"], result: "void", nonblocking: false },
})

export function test() {
  let rawResult = _lib.symbols.core_run()
  const result = rawResult
  return result
}

Related: https://github.com/denoland/deno_bindgen/issues/57
As a workaround, you can manually clear from the OS cache directory.

Related: #57
As a workaround, you can manually clear from the OS cache directory.

okey, thanks


Rotating a model should also rotate it's normals

Current implementation neglects rotating the model normals upon usage of the method SceneObject::Rotate().
This causes issues whenever lighting is involved.
A better implementation would be to rotate the normals aswell. Do not neglect to afterwards rewrite the normals data on the openGL buffers.

merged


Install Error

I installed via both pip or AUR and they give the same error:
No module named 'url_normalize'
Traceback (most recent call last):
  File "/home/<username>/.local/bin/anime", line 33, in <module>
    sys.exit(load_entry_point('anime-downloader==5.0.14', 'console_scripts', 'anime')())
  File "/home/<username>/.local/bin/anime", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib/python3.9/importlib/metadata.py", line 77, in load
    module = import_module(match.group('module'))
  File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 972, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
  File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 850, in exec_module
  File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
  File "/home/<username>/.local/lib/python3.9/site-packages/anime_downloader/__init__.py", line 1, in <module>
    from anime_downloader.sites import get_anime_class
  File "/home/<username>/.local/lib/python3.9/site-packages/anime_downloader/sites/__init__.py", line 2, in <module>
    from .anime import Anime
  File "/home/<username>/.local/lib/python3.9/site-packages/anime_downloader/sites/anime.py", line 13, in <module>
    from anime_downloader.downloader import get_downloader
  File "/home/<username>/.local/lib/python3.9/site-packages/anime_downloader/downloader/__init__.py", line 1, in <module>
    from anime_downloader.downloader.http_downloader import HTTPDownloader
  File "/home/<username>/.local/lib/python3.9/site-packages/anime_downloader/downloader/http_downloader.py", line 10, in <module>
    session = session.get_session()
  File "/home/<username>/.local/lib/python3.9/site-packages/anime_downloader/session.py", line 37, in get_session
    _session = requests_cache.CachedSession(cachefile, backend='sqlite', expire_after=expire_time)
AttributeError: module 'requests_cache' has no attribute 'CachedSession'

you can run pip3 install --force-reinstall -U requests-cache==0.7.0.dev334 to fix that

you can run pip3 install --force-reinstall -U requests-cache==0.7.0.dev334 to fix that

That was it, thank you!


Swift2objC Public API

Implement a public facing API.
There are mainly two methods for generating the wrapper file, one is Async and the other is Sync (inspired by dart:io)

Implement a public facing API. There are mainly two methods for generating the wrapper file, one is Async and the other is Sync (inspired by dart:io)

It's not a good idea to have 2 copies of the API. It's too much code duplication. Just decide whether it makes sense for the API to be async or not, and build it once. This is actually a bit of a design problem with dart:io, but we're stuck with it.
When it comes to dart:io, for some methods it makes more sense to use the sync version, even when there's an async version available. For example, even if you're in an async situation, it's generally better to use File.existsSync instead of await File.exists, because the existence check takes is fast, and the await itself will take longer than that. Only use async/await when you're doing a longer operation and don't want to block the caller isolate.
In your case, you're doing Process.run, so it definitely makes sense to make your public API async, to avoid blocking users. But a lot of the file IO operations you're doing should probably use the sync APIs. Just consider whether the call might be slow (eg more than a ms).

Looks like you accidentally added the swiftgen prototype to this PR. Can you remove it?

coverage: 90.9% (+0.005%) from 90.895%
when pulling 6a2e5d4ca1ddfddb1ab8a9b2a338fc0de8007ce1 on Mohammad3id:swift2objc-public-api
into 7efefec16509ed38544a8af999b9e85694586bc7 on dart-lang:main.


How to make file public

I need upload and make public the webpack bundle, but i did not see any options in your plugin.

@lnlwd You can do it manually at the moment through Google Cloud Storage by making your bucket public.

However it sounds like something that can be done by webpack-google-cloud-storage-plugin out-of-the-box.

Yep. I think you can create an uploadOption, public (true or false)

Fixed by #3

Also released in npm version 0.7.0.

@syndbg What does the makePublic option do? From what I can tell it is what actually makes things public, not public - which I have tried unsuccessfully.
https://github.com/syndbg/webpack-google-cloud-storage-plugin/blob/master/src/index.js#L142

@youanden The correct option seems to be makePublic. Can you confirm on your end?


Modify People-page lists

Rename th 'ID' to 'Color'.
Add contact information with mailto-links to lists. Modify RoadmapUser-interface to have email and roadmap/:id/users -routes fetch email.
Add 'Unrated tasks' to lists with sorting functions.

Feedback on sorting functions and unratedTasksAmount-function is especially welcome. I am a bit nervous of the amount of arrays iterated through multiple times.

I've refactored code according to your points. Well, except for:

The sorting could use decorate-sort-undecorate pattern, if the sort keys require significant computation. This should even be quite simple to add to the current sorting helpers.

I looked into DSU-pattern and I get the idea. However I am having a bit trouble implementing it here.
Should I make a new sorting utility function similar to sorted in SortUtils? It would then take a list of sets rather than a list and comparison would be done according second member of the set?
I guess I'm not sure what conversion (decorate-part of the pattern) should be done here too

Should I make a new sorting utility function similar to sorted in SortUtils? It would then take a list of sets rather than a list and comparison would be done according second member of the set?

This could work, but it leaves the decorating for the caller, and so the existing sorting function would also work for this (given appropriate comparison function).
Another option would be function that takes the SortKey function (and probably comparison function for the keys), this could be something like:
const DSU = <T, K>(
  list: T[],
  key: SortKey<T, K>,
  compare?: SortComparison<K>,
  order: SortingOrders = SortingOrders.ASCENDING,
) =>
  compare === undefined
    ? list
    : list
        .map((item) => ({ key: key(item), item }))      // decorate
        .sort((a, b) => compare(a.key, b.key) * order)  // sort
        .map(({ item }) => item);                       // undecorate

The DSU function you wrote is really nice. Decoration of roadmapUsers required extra parameters (tasks, customers), so I ended up with the first option.
I think I got the split of taskUtils-functions correct now. I moved filtering logic from taskAwaitsRatings to isUnrated and added isRatedByUser and isRatedByCustomer to clean up repeated code.
One thing was left a bit unclear. Is taskIsUnrated-function unnecessary? Can isUnrated be used on a single task somehow?

One thing was left a bit unclear. Is taskIsUnrated-function unnecessary? Can isUnrated be used on a single task somehow?

isUnrated(user)(task)

The call isUnrated(user) returns the predicate, which can then be used to check the task.


my game crashes when i try to load it

is it something with little tiles? forge? creative core? do i have to use chisels and bits?
i haven't been using optifine. (pretty sure i haven't used it in 1.12.2 ever)
is there anything that can fix it.
it says something about IRarity.
if you think anything on my taskbar looks dumb..... why? it's mostly browsers and online games
anyway

what's that all about?

IRarity crash means that you have an old Forge, if you update it to last it wont crash because of that.
Right now a ton of fixes are already made and I am releasing a much better version in the next couple of days.
And it includes the fix for this IRarity thing, so closing this issue as already fixed.
P.S. Way too many unrelated question marks

the old forge thing explains a whole lot
thanks

" P.S. Way too many unnecessary question marks and/or questions".
sorry about that.
anyway thanks for that, I'm gonna start getting a newer version of forge now

Don't worry so much, omg
Join our discord where you can ask anything and get updates about what's up with the update


Unexpected gap between rectangles in canvas renderer

Hi, when two rectangles placed side by side and they are translated by 0.5 an unexpected gap appears if canvas renderer is used.
WebGL version: http://jsfiddle.net/sten/azpgswgz/1/  (OK)
Canvas version: http://jsfiddle.net/sten/80qk6gz9/1/  (BUG)
Do you have any idea how to work around it?

The gap you see is a "half pixel". Avoid floating points when drawing to the canvas.
graphics.x = 0.5; --> 0
graphics.y = 0.5; --> 0

Yeah, Fill mode works differently on canvas and webgl. I think that canvas is taking line (lineWidth) into the square, while WebGL doesnt.

Think this is just the nature of the beast im afraid! Most people use WebGL now :)


Add ListModuleLessonCommand

resolves #112

Codecov Report

Merging #122 (609ee97) into master (ffe613c) will increase coverage by 0.48%.
The diff coverage is 72.22%.

@@             Coverage Diff              @@
##             master     #122      +/-   ##
============================================
+ Coverage     70.50%   70.98%   +0.48%
- Complexity      543      554      +11
============================================
  Files            98       99       +1
  Lines          1790     1806      +16
  Branches        200      201       +1
============================================
+ Hits           1262     1282      +20
+ Misses          454      452       -2
+ Partials         74       72       -2

Impacted Files
Coverage Δ

...dress/logic/commands/person/ListPersonCommand.java
100.00% <ø> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
78.94% <0.00%> (-4.39%)
:arrow_down:

...rc/main/java/seedu/address/model/ModelManager.java
85.71% <ø> (+6.34%)
:arrow_up:

...ess/model/modulelesson/UniqueModuleLessonList.java
86.66% <50.00%> (+1.30%)
:arrow_up:

...ulelesson/ModuleCodeContainsKeywordsPredicate.java
71.42% <71.42%> (ø)

...commands/modulelesson/ListModuleLessonCommand.java
100.00% <100.00%> (+100.00%)
:arrow_up:

...n/java/seedu/address/logic/parser/CommandWord.java
100.00% <100.00%> (ø)

src/main/java/seedu/address/model/AddressBook.java
80.95% <100.00%> (+0.46%)
:arrow_up:

...in/java/seedu/address/model/person/ModuleCode.java
86.36% <0.00%> (+4.54%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffe613c...609ee97. Read the comment docs.


Snippets/Templates are not getting shown in the context assist

I can see that there a few templates already present in the preferences. However typing those in the SQL editor (.sql extension file) does not show/insert the template in the editor.
Regards,
Nidhin

To trigger SQL templates assistant use CTRL+ALT+SPACE

Excellent. A little unintuitive though. Does not follow the normal eclipse way of appearing in the code assist or  ctrl space bringing it up.
Thanks serge for the quick response.
You can close this, if this is the only way of doing this.
regards,
Nidhin

Maybe templates assistant should be improved (and become a part of regular assistant). But I still not sure (sometimes in a real database you have a huge number of proposals - it is not easy to find template there).
Or this could be configurable.
I'll think about it one more time..


question: suitable sizes, expected processing times?

or put differently, will this run ever complete or is it too big? :) 30k scene objects in Blender.. (from a FBX)
39 000 000 lines parsed - Forced GC took 1.82s

processor #1: Duplicates
  - Using epsilon of 1e-06

Yes, I have some trouble with very large files (aka a lot of vertices/normals/uvs). The scanning time is not very linear when the file size grows :)
I'm working on a lot simpler algorithm that will catch 99% of duplicates from most files. The ones that slip trough it are two vectors that are exactly eplison apart. The technique uses string formatting and comparing the strings, it is a lot faster than doing abs comparisons for 3-4 floats. This string serialization can be done once while the vec comparisons need to be done each time for all vec pairs. I might be able to optimize this later.
But yeah, the faster algo should be better for pretty much all runs. I will probably do a boolean -some-flag to enable the much more time consuming check, default would be the new faster one.
I suppose you found the cmd line flag for disabling duplicate checking. As you can see then the time consuming part is the parsing. If the file is very large and you dont have enough RAM it will start to swap and the perf will be very bad. There might be still some room to reduce the struct size per vertex/normal/uv.
I'll ping you once I get the faster algo in, maybe you can try how long it takes. I dont want to ask you to upload the 1.5gb file if its not already on the web somewhere? :) I do have one 4.5gb file myself for perf testing.

yep i got the merge done by using -no-duplicates, for the later run pasted above.
i did have enough RAM for much of the deduping actually, at least for almost all of the ~10 hours it ran. was first IIRC just 1.2GB or so but then later 12GB and things started to get tight on the 16GB laptop. i think it started swapping then and the system SSD happened to be very full so i had to stop it.
very cool already that got the merge done -- was just able to test publish the scene on the web now (internally only, model not for public access (yet). is however from a c3po pilot where your company is too so I'll ask and most probably get permission to share for you now).
am curious to learn about your optimizations later, also i figure there are clever mechanisms in existing optimization tools.
BTW afterwards i tested the merge with Blender too (that used to get the obj from the FBX -- Autodesk's FBX Converter borked) but it crashed (eventually), took very much mem I think pretty quickly (30k objects is much there)

There is no great magic here. I'm just doing simple duplicate removal as it is a big problem on many obj files. Especially with uv:s and normals.
The grouping to a single draw call per material is very trivial as well. This is the full code https://github.com/jonnenauha/obj-simplify/blob/master/process-merge.go#L25-L105
Essentially its piling all the faces into fewer objects :)
I don't have any geometry recuders/simlifiers and don't plan on having them either. This would be out of scope and better done in Blender etc.

Btw. I also implemented a -gzip option if you want to compress for permanent storage without hassle. Just set the Content-Encoding header in there correctly to gzip.

yep that's what I meant too, that am hoping that doing normal poly reduction in Blender or other tools solves that scene.
but this tool was already helpful to do the simple merge .. because the scene was so big that e.g. Blender was not able to (crashed when I tried)


Translation framework

This is a draft PR to dry-run what it is like to use the mdbook-i18n-helpers translation helpers.
The first commit does all the necessary setup by adding 2 files - it basically spits out a po/messages.pot file with the target strings to translate and the po/es.po file to hold the translated strings.
This process is (briefly, but clearly) detailed in the mdbook-i18n-helpers USAGE.md page.
A small config entry is added to book.toml and the (spanish) book is built via MDBOOK_BOOK__LANGUAGE=es mdbook serve -d book/es and served with MDBOOK_BOOK__LANGUAGE=es mdbook serve -d book/es.
I've left out the fiddling with YAML to serve the translations as this seemed like a good enough PR for now.

Note: I've punted very deliberatley on how this setup plays with mdslides because my upcoming conference has a slide template ready.

Neat! This is exciting stuff.
Is it possible to make the CI:

Build the Spanish version as well as the English version
Check the po/messages.pot file is correct and up-to-date

Build the Spanish version as well as the English version

Yes, as the USAGE.md claims. That's a GitHub Action that kinda pokes us into not deploying via Cloudflare which I think will make Felix sad.

Check the po/messages.pot file is correct and up-to-date

It might need a few more lines with msgmerge --update po/xx.po po/messages.pot (a GNU installable tool) and a diff, but it can probably be hooked up.


Group Verification and Publishing of Activities

Hi AidStream,
A few organisations have been asking if it would be possible to add a check list to the activities on AidStream. So that they could select multiple to verify/complete/publish at the same time.
This is particulary for organisation who are publishing a large number of activities. Do let me know.
Thank you,
Amy

Yes, this is completely possible. I will let you know once this feature has been released.


docs: update script location.

TIL editing through the github browser interface does not allow me to add a reviewer or a do-not-test label. @alekssaul @ElijahCaine

this looks good to me.. Can we confirm this will only effect 1.6, documentation?

@joshix and @ElijahCaine are working on a sync for other changes to the Matchbox doc. They'll be able to answer this.

This conflicts with the source location in the repo. I talked with Redbeard about the next matchbox release placing the script in examples/etc/matchbox to match source.

ah. how far out it the next release? should we hold off on this edit?

We could do a patch release next week.

ok. @alekssaul @dghubble I think, because most users will not use this feature, and because those who do can probably figure out the solution, and because it will be fixed Wednesday, I vote not updating the doc.
what say ye?

That sounds fair, I'd recommend keeping the issue in the tectonic-installer repo open in case a user stumbles upon it.

cool. I'm going to close this PR, and you two will manage the other bits. thanks.


Add tests for privmsg to users

Currently, privmsg tests are limited to tests against channels. However a server may handle privmsg to a user differently than privmsg to a channel in which case it may be useful to have explicit tests for privmsg to users.
Testing
I tested locally against ergo, solanum and inspircd; could not get the GH workflows to run on my fork.

Thanks! Continuing at #184.

JFYI the test flakes can be resolved using this technique:
https://github.com/progval/irctest/pull/184/commits/38d4729f139a22f5a6a662e95dbb32964af04cd0
getMessages(1) works by sending a PING and waiting for the corresponding PONG, to ensure that all previous messages sent by 1 have been processed. Without this, there's a race condition where getMessages(2) may execute before the PRIVMSG sent by 1 is processed.
It seems theoretically possible (especially in a distributed setup) that the PRIVMSG could be processed without having actually reached 2's sendqueue, in which case there would still be a race. But fortunately we've never encountered that in practice.
Thanks for your help! Let us know if we can assist you further with the project, or with IRCv3 development in general.

Thanks a lot, we have plans to continue with development and have been reading through some of your repos to learn more about IRC/server design, will ask for advice if needed!


feat: add convenience methods for (de)serialization

The commit adds a from_reader and to_writer method implementation to
make it easier to work with IO streams.
Additionally, I have deprecated the new and to_xml functions in
favor of functions that match the naming scheme of serde crates more
closely: from_str and to_string.

If you are against the deprecation of those methods, let me know and I can revert them.

There were a few warnings and errors when building and testing, but I've fixed those as e8006bf. Thank you for another PR! :sparkling_heart:


C++ comments cause crash

Godot version:
3.2.2
OS/device including version:
windows10
Issue description:
I am writing code that is completely unrelated to godot in a native script environment. A line of Chinese comment caused a crash:
System.Net.Sockets.SocketException (0x80004005): The remote host forced an existing connection to be closed.
In Mono.Debugger.Soft.TcpConnection.TransportReceive(Byte[] buf, Int32 buf_offset, Int32 len)
In Mono.Debugger.Soft.Connection.Receive(Byte[] buf, Int32 buf_offset, Int32 len)
In Mono.Debugger.Soft.Connection.ReadPacket()
In Mono.Debugger.Soft.Connection.ReceivePacket()
In Mono.Debugger.Soft.Connection.receiver_thread_main()
Godot player terminated with exit code -1073741819
I tried a lot of Chinese examples, and there is no crash in rare cases. Does it support only English comments or a few specific languages by default.
Steps to reproduce:
Minimal reproduction project:

@Jiaming00 Please upload a minimal reproduction project to make this easier to troubleshoot.

Sorry for disturbing you guys.
This should be because the vs compiler mistaken utf-8 for unicode. Because I use vscode.
😅


Fix aria-sort and initial sorting (was reversed) [fixed tests]

Same PR as #136 but with fixed tests.

Fixes #128.

@tristen, I think :+1:

Sorry for the delay on this. LGTM


Bump framework

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5184333110

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5184333110
Status: failure

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/5185385119

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5185385119
Status: failure

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/5186732295
Status: success


Cmake fixes

Fixing some issues found in cmake script

Merged. Thanks!
https://git.xiph.org/?p=ogg.git;a=commitdiff;h=c5a911f050acb7117f9ac9d560a8bee221f0f9b6


Feature/183 stl decomposition

[x] Simple implementation of the STL decomposition
[x] Plots saved in the analysis directory

Looks good, thanks!


SELECT error:  SQLITE.ALL - Prepare Error 1 when migrating from {N} 6.8 to 8.1

I'm migrating a large JavaScript project from NativeScript 6.8 to 8.1 and am receiving the subject error message.  The database is the same and the code is the same (except for newer plugins).  The nativescript-sqlite plugin moved from 2.6.6 to 2.8.6.
The SQL statements are simple enough.  Here are two examples:
SELECT * FROM riders WHERE Bib LIKE '2'
SELECT * FROM riders WHERE [Participant First Name] LIKE 'David'

Here's the code in question:
if (!sqlite.exists(db.name)) {  // if not already in database folder
      sqlite.copyDatabase(db.name);  // copy shipped database from /app folder
    }

    new sqlite(db.name)
      .then((dbObj) => {
        dbObj.resultType(sqlite.RESULTSASOBJECT);
        dbObj.all(stmt)
          .then((result) => {

I can see that the database exists and is copied.  My question now is what does this error mean, and how can I further isolate or debug the issue?

To isolate / debug the issue, I would add a statement that queries and prints the metadata for the database after you copy it, just to verify that the you are shipping the proper database.  Some files moved locations in NS 8, so it is possible that you aren't putting the DB in the correct location and so the copy isn't actually copying it.   So instead of "opening" a db, you are creating a new db, which then has no riders table.

@NathanaelA - thanks.  I added this code:
    if (!sqlite.exists(db.name)) {  // if not already in database folder
      sqlite.copyDatabase(db.name);  // copy shipped database from /apps folder
    }

    if (!sqlite.exists(db.name)) {  // if not already in database folder
      console.log("riders-query-page.onQueryTap:  database does not exist.")
    } else {
      new sqlite(db.name)
      .then((dbObj) => {
        console.log(JSON.stringify(dbObj, null, 4));
        let stmt = "SELECT name FROM sqlite_schema WHERE type ='table';";
        dbObj.execSQL(stmt)
        .then((result) => {
          console.log("riders-query-page.onQueryTap result: " + JSON.stringify(result, null, 4));
        })
        .catch((e) => {
          console.log("riders-query-page.onQueryTap execSQL error: " + e );
        });
      });
      return;
    }

And I get this output:
CONSOLE LOG: {
"_messageHandlers": [],
"_isOpen": true,
"_resultType": 1,
"_valuesType": 4,
"_options": {},
"_dbnamePtr": {},
"_db": {}
}
CONSOLE LOG: riders-query-page.onQueryTap execSQL error: SQLITE.ExecSQL Failed Prepare: 1

Does _db equaling an empty object imply a new database was created?

No, _db is just a pointer.       Could the database be encrypted or corrupt?

I opened the db file with DB Browser and saw what I was expecting.  I edited a cell and saved.  I deleted the app from the iOS emulator so as to clear the documents folder.  When I ran the app I received the same results as posted above.
What does Prepare Error 1 usually indicate?

I've been migrating other sections of the app, but will need to get back to this soon.  @NathanaelA - what does Prepare Error 1 typically indicate?

Prepare error 1 would be the error returned from Sqlite directly.
According to the Sqlite site it is:
https://sqlite.org/rescode.html#error
(1) SQLITE_ERROR
The SQLITE_ERROR result code is a generic error code that is used when no other more specific error code is available.

Which is why I suggested that the Database is corrupt or that you are not using the Correct DB.    I normally see this on a prepare if the table doesn't exist.    However, based on your prior example where it failed on the schema table, I would guess it is a corrupt database (or perhaps a encrypted db, where the password opening it is wrong -- which then is treated as a corrupt db).
One thing you can double check is pull the demo from this repo and run it as-is.    Make sure it works properly for you.

@NathanaelA - thanks for the response.  I returned to this part of the app for further debugging and now the queries are working as expected.  This is perplexing, but then this code had worked before with this same database.  I'll go ahead and close this issue.


Encoded String

Link: https://www.codechef.com/problems/DECODEIT
I would like to do it in Python

I can do this in C++

Open for C and Java.

I can submit for C too

@Nivedita967 Can I add the program in Java?

@96RadhikaJadhav ???

@96RadhikaJadhav ???

@Nivedita967 Sorry for the delay. I have added comments now. Please check.


Bigtable integration tests use same instance

If you could write up a README.md file somewhere suitable (in the root Bigtable directory perhaps, if the same instance can be used for snippets too) for testing requirements, that would be handy - both for me and for @iantalarico who'll need to set up our CI appropriately (and anyone else, of course).


„Add To Reading List“ keyboard Shortcut or Menu Item

When I browse through the unread articles I would really like to have a way to add articles to the Safari reading list buy pressing a shortcut on the keyboard.
Unfortunately adding this shortcut myself using Preferences.app / Keyboard / Shortcuts does not work, because the „Add to Reading List“ function is hidden behind the share button and context menu. Both does not seems to fire if I use an custom defined shortcut.
Please make this function accessible via a shortcut or offer a standard menu item so is possible to define a shortcut.

I second this. I would use it to share easily to GoodLinks.
The best solution to me seems to be to add a File -> Share menu that is equivalent to the popup share menu. If that menu exists it is possible to directly access particular share actions via a user shortcut. This approach works well in Safari which does have a File -> Share menu.
It's possible to add a shortcut to items in the popup share menu right now, but to use the shortcut you have to open the share menu first. If you invoke the shortcut without that menu open, nothing happens.

I second this. I would use it to share easily to GoodLinks.
The best solution to me seems to be to add a File -> Share menu that is equivalent to the popup share menu. If that menu exists it is possible to directly access particular share actions via a user shortcut. This approach works well in Safari which does have a File -> Share menu.
It's possible to add a shortcut to items in the popup share menu right now, but to use the shortcut you have to open the share menu first. If you invoke the shortcut without that menu open, nothing happens.

Duplicate of https://github.com/Ranchero-Software/NetNewsWire/issues/2070


Issues related to Button1.text parsing

typed {{Button1.text}} and then after parsing, it goes to code as Button1.text
Button1.text is not visible on the UI of the action selector

added {{Button1.text}} from the UI as an argument for JSObject1.myFun2 and after adding it, the argument fields disappeared and not showing up anymore, even after reloading the app.

Verified in https://appsmith-bnl4i9ht4-get-appsmith.vercel.app/app/actionrefactor/pag111-63bd4d008c8d557f2f972a3a/edit/widgets/qtj5qx284w

The second scenario where Button.text is added as an argument does not show up
cc: @rimildeyjsr

this is working


The Last Express OG DOS ver.

AFAIK GOG is the only place you can buy the original DOS version of The Last Express, Steam and prob most other stores only sell the "Gold Edition" remake by Dotemu.
https://www.gog.com/game/last_express_the?utm_campaign=adtraction&utm_medium=affiliate&utm_source=adtraction&r=true
https://store.steampowered.com/app/252710/?utm_source=PCGamingWiki&utm_medium=PCGamingWiki&utm_campaign=PCGamingWiki

Thanks for your help!
It would be awesome to post these contributions as pull requests instead of posting issues. This way I can simply review the request and confirm the change ;)


Asding for params and flops

Hello author, I am comparing params and flops of several models in each epoch, but I had a problem when the dataloader was created, I hope you can provide the forecast params and flops in 3 seconds, thank you very much for your help.

MTR model has about 65M parameters, and I can not give an accurate number of flops since there has local attention in MTR model that is related to the number of elements in each scenario.


Pressable Button in Incorrect State after getting enabled [mrtk rc2.1]

Describe the bug
MRTK Pressable Button State is incorrect after getting enabled post disabling it.
To reproduce
Steps to reproduce the behavior:

Keep a PressableRound Button in scene.
Add a script to disable this button when clicked on it.
Enable the button using script after few seconds.
Button is enabled in Focused state.
Button goes in Pressed State or stays in focused state based on whether it's near or far interaction.
Note: Change the color in button profile to contrasting color as there is chance of mistaking state as i did.

Expected behavior
Button should start in default/normal state when enabled.
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Your Setup (please complete the following information)

Unity Version [2018.42f1
MRTK Version [v2.1] aka RC2

Target Platform (please complete the following information)

HoloLens 2

Additional context
Add any other context about the problem here.

Same Problem here.
suggestion :
reset States to default value in Interactable.OnEnable
current workaround:
adding another component with:
void OnEnable()
{
  GetComponent<Interactable>().SetFocus(false);
 // or more globally : parse all states and call SetState(state, false)
}

i tried in 2.0.0 : bug still reproductible.
i tried with Interactable.Enabled and Interactable.SetDisabled()
have to call Interactable.ResetAllStates() or SetFocus(false) when enabling button to workaround the issue.
main problem is (without the resetallstates call) that when focusing in and out after a disable/enable, the interactable still keeps the focus state.
so this is more like a OnFocusExit that should be triggered (and decrement the focus count) when disabling the interactable.

linked to/duplicate #4481

@julenka FYI, sounds like issue with input on Interactable

This was because the lastState within InteractableThemeBase.cs was not defaulted to null after disabling the button. I just worked around it by adding this in the onDisable of interactable.cs
for (int i = 0; i < runningThemesList.Count; i++)
    if (runningThemesList[i].Loaded)
        runningThemesList[i].LastState = -1;

where LastState is public setter for lastState in the InteractableThemeBase.cs

Same Problem here.
suggestion :
reset States to default value in Interactable.OnEnable
current workaround:
adding another component with:
void OnEnable()
{
  GetComponent<Interactable>().SetFocus(false);
 // or more globally : parse all states and call SetState(state, false)
}

But having GetComponent<Interactable>().SetFocus(false); being called from another script within the gameObject doesn't work.

@Troy-Ferrell I wonder if your interactable refactor will fix this, just because you are fixing some of the code in Interactable states

@cdiaz-ms has this been fixed?

@julenka yes it has, but a new test PR for this issue is coming today and then it can be closed.


feat(android): Detect busy background threads

Description
Espresso considers the device not idle if it has, among other things, active asynctasks, however we were not able to see these background tasks and as a result would print messages of "Device seems to be idle", instead of actually indicating the issue. In this PR, the ability to check the status of asynctasks has been added in order to provide more accurate sync debugging.

This pull request is associated with #3617

Thanks @jonathanmos, Detox version 20.1.0 has been released with this change.


chore: jx-k8s-days-go-02 to 0.0.2

chore: Promote jx-k8s-days-go-02 to version 0.0.2

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Serialize parameters

I am using the infinite- scroll to page data that is filtered with parameters passed by .serialize ( ) .
The infinite- scroll adds painação only passed parameters in the URL eg https://app.com/my-route?param1=val1&param2=val2&page=2
$("#search").on("change", function (event) {
  var $this = $(this);
  var frmValues = $this.serialize();
  $.ajax({
    type: 'GET',
    url: '/products',
    data: frmValues
  })
  .done(function (data) {
    $('#items').html(jQuery(data).find('#items').html());
  })
  .fail(function () {
    console.log('Erro no filtro');
  });
  event.preventDefault();
});

This generates a GET https://app.com/my-route?param1=val1&param2=val2 call
And when I trigger the paging it ignores these parameters only running GET https://app.com/my-route?page=2
How can I solve this?
Translated by Google

Infinite Scroll v3 is out!. It's an all new re-write, so take a look at how to upgrade from v2.
I recommend upgrading to v3. v3 has better support for URLs with parameters. Please open a new issue if you run into trouble with Infinite Scroll v3.


Add LinkToMessage in MessageActionsPayload class

Fixes # 4120
Description

Add the LinkToMessage property in the  MessageActionsPayload class.
Add unit tests for all the MessageActionsPayload properties.

Testing
In the image below we can see the TeamsMessagingExtensionsAction sample displaying the new property's value in the action card.

Promoted to MS


Update Installation Process

I am trying to follow the readme, but there is no configure file in directory.  I tried to run ./configure.ac, but that doesn't work.
How can I install this on my machine (GNU/Linux)?

Awesome, this would have saved me a lot of time. Maybe this should be added to the readme file.
I ended up using the C Library straight up. https://gist.github.com/1487597


chore: parallel build for shims

In addition to #126, this PR changes the build workflow to stars one job per shim and architecture. By parallelizing the builds, we get a nearly constant build time even as more shims are added.

This is awesome! It halved the CI runtime.


feat: support generate report json files

feat: support generate report json files

+1

:tada: This PR is included in version 3.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add ComponentBuilder to the prelude

Summary
Adds ComponentBuilder to the prelude.
Checklist

[x] cargo fmt
[x] cargo clippy
[x] cargo test
[x] updated CHANGES.md

Which use-case do you have for ComponentBuilder in the prelude? It should be fine to call MyComponent::builder() to get the ComponentBuilder so you don't need to have it in scope.

Whoops, you're right. Closing.


Update isMethodCallable() logic, re-introduce its usage for getReadMethod()

Follow-up to PR #104.
Small updates to OgnlRuntime, attempting to ensure more consistent behaviour for JDK7-11.

Update OgnlRuntime isMethodCallable().  Removed (now) unnecessary isJDK15 check, added clearer logic and explanatory JavaDoc comments.
Added OgnlRuntime isMethodCallable_BridgeOrNonSynthetic() for specialized usage such as choosing valid Read and Write methods.
Made checks in getReadMethod() and getWiteMethod symmetric again.
Added new unit tests to confirm expected behaviour with respect to bridge methods and synthetic methods.

Hello OGNL Team.
This PR follows some discussion following the introduction of PR#104.  It was discovered that the testSyntheticWriteMethod() introduced with that PR failed under JDK 7, and @harawata had some suggestions for possible improvements to OgnlRuntime.isMethodCallable() as well.
Changing isMethodCallable() to also include bridge methods caused additional unit test failures to occur, and even after several debugging attempts I was unable to isolate the underlying reason (just that it appeared to cause OGNL to choose the wrong method signature in some cases).
So, this PR leaves the behaviour of isMethodCallable() unchanged (rejects all synthetic/bridge methods), and introduced a isMethodCallable_BridgeOrNonSynthetic() that can be used in specific cases (after careful consideration).  Currently the new method is only used so that bridge methods are considered as valid by OGNL for Read or Write methods.
The changes appear to be safe, and the build tests succeed for JDK7, JDK8 and JDK11 locally.  Let me know if you think the changes look OK, or if things could be improved for this PR.

Nice work, @JCgH4164838Gh792C124B5 !
I was wondering if you could find a test case that verifies the effect of isMethodCallable_BridgeOrNonSynthetic check in getReadMethod.
Current tests pass even if the isMethodCallable_BridgeOrNonSynthetic checks were removed from getReadMethod, right?

Hello @harawata .
I was not able to think up a direct way to confirm the effect of isMethodCallable_BridgeOrNonSynthetic() (or isMethodCallable() for that matter), beyond the new unit tests that were introduced with this PR.  I am open to ideas, if anyone has suggestions.  😅
The new unit tests, combined with the previous tests that check getReadMethod() and getWriteMethod() calls, appear to confirm the expected behaviour for the changes.  The updated logic still passes the testSyntheticBridgeReadMethod() testSyntheticBridgeWriteMethod() tests too (the tests you introduced with PR #104, but renamed to clarify that bridge methods are involved).
As you pointed out, the current tests in this PR do pass even if isMethodCallable_BridgeOrNonSynthetic() is removed from getReadMethod().  Before PR #104, getReadMethod() called isMethodCallable(), which prevented any synthetic or bridge methods from being considered.  The changes in this PR should prevent non-bridge synthetic methods from consideration for read/write method lookups, but from what I could determine that seems to be the safer course of action for OGNL.
Other than bridge methods, I could not find any examples of synthetic methods that that have consistent/known names (just compiler-chosen names like access$x, where x is an integer).  There does not seem to be any valid use case for trying to call non-bridge synthetic methods, but let me know if you know otherwise ?
Even if there are use cases, it seems it would still be risky to allow OGNL to call non-bridge synthetic methods (which seem to be purely for the compiler's internal use).
Please let me know if the reasoning above seems sound or not ?

Thanks for the update, @JCgH4164838Gh792C124B5 !
I agree that there is no valid use case for calling non-bridge synthetic methods.
I suspect that Class#getMethods() does not return non-bridge synthetic methods by design, but couldn't find any documentation directly backing the theory.
Anyway, although it would be ideal if we could find a test case, I have no strong objection as better-safe(or redundant)-than-sorry is not a bad strategy and the check logic may be very light weight.

LGTM 👍


build(Scalar.AspNetCore): add ASP.NET Core build and test workflow

Description
This PR adds a basic workflow for building and testing the Scalar.AspNetCore package.

oooo this is AWESOME @xC0dex !!!
okay so next steps:

[ ]  i can add the appropriate api key to publish to https://www.nuget.org/packages/Scalar.AspNetCore
[ ] we need to filter for the package and it being dependent @hanspagel ?
[ ] 👀 anything else

I think this can be tricky to mix NuGet and NPM packages in a changeset 👀

I think this can be tricky to mix NuGet and NPM packages in a changeset 👀

ah this is true! tbh i am quite the novice on release management 😅 but i love hitting the green button
@hanspagel can weigh in on best flow for that ✨

So from my understanding the .changeset/config.json needs to be extended by
"privatePackages": {
    "version": true,
    "tag": true
  }

In addition, inside the scalar.aspnetcore folder, we need a new package.json so changeset can track the package:
{
  "name": "scalar.aspnetcore",
  "private": true,
  "version": "1.2.4"
}

So commands like npx changeset will now list the scalar.aspnetcore package.
However, currently, the publish command inside the changesets/action@v1 action is
pnpm -r publish --access public

TBH, I don't know what this command is doing. But for the NuGet package, the command must be
dotnet pack -c Release --no-restore --output nupkgs /p:Version=$VERSION

to pack the project into a package and
dotnet nuget push nupkgs/*.nupkg -k ${{ secrets.NUGET_TOKEN }} -s https://api.nuget.org/v3/index.json

to publish it to nuget.org.

Great work!! For our Electron app, we’re hooking into the release process without actually publishing to npm, too.

The app has its own package.json:

https://github.com/scalar/scalar/blob/main/packages/api-client-app/package.json

We’re using pnpm changeset to create new changesets, and it’s tagging new version for dependency updates automatically.

It’s not publish to npm because of private: true.

CI requires those three things to actually trigger a release:

The change must be in main
The commit needs to start with RELEASING:'
The package.json has to be modified

Here’s the actual GitHub Actions workflow:
https://github.com/scalar/scalar/blob/main/.github/workflows/ci.yml#L151-L195
We can totally copy that for the AspNet integration, without even changing the changeset config. :) Do you want me to add this, or do you want to do it? Awesome contribution (again)!

@hanspagel got it, thanks for the explanation! This looks like a good solution for the .NET package. I'll try to add a job tomorrow 👍. However, we have to parse the version number out of the package.json to use it during the pack and publish command.

Ah, that makes sense!

Hey @hanspagel,
I've added a publishing job based on your recommended todesktop-release job. I made a dry-run (without the if conditions). Setup .NET, extracting version from package.json and pack works perfectly. Could you please re-review the PR? I don't know how to check if everything works as expected regarding the changeset 👀.

@xC0dex good news, i have sent the token to @hanspagel so hopefully we can get this merged today :)

Added a NUGET_TOKEN as a repository secret ✌

There’s already 1.2.5 it seems, should we bump the version to be 1.2.5 in the package.json?


testing new official source

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Tests are passing! :partying_face:

Warning
This is currently building off of the TestPyPI package, so we need to finalize the release of raven-hydro v0.2.0 on PyPI and update that here before merging.

If there ends up being issues at runtime with this new implementation (because of library linking, for example), we can generate new builds if needed.