#1058: Correct error types for bad user input in micrometer

Pull request checklist

[X] Please read our contributor guide
[X] Make sure the PR doesn't introduce backward compatibility issues
[X] Make sure to have sufficient test cases

Pull Request type

[X] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Other (please describe):

Changes in this PR
In general I'd recommend reviewing commit by commit.

MissingFederatedQueryArgument reported unknown to micrometer (fix here):  MissingFederatedQueryArgument and a few other Dgs exceptions now inherit from DgsException: if we catch a DGSException, we know that it is typed properly, so we don't have to special case on a bunch of exception types

The query is null or empty. is not getting reported to micrometer (fix here): this one was a bit tricky, since BaseDgsQueryExecutor would short circuit on an empty query with a custom error. I opted to remove this logic because an empty query is effectively the same thing as a query with just a single character but would turn up completely different errors; if we remove this special case logic, the error falls through, micrometer reports it and the user sees a SyntaxError. lmk if there is a better way to handle this (I tried manually passing to instrumentation but it was very clunky)

ValidationError reporting as unknown to micrometer (fix here): Special cased it

Re-added micrometer to example project (fix here): as @srinivasankavitha and I discussed, this should be re-added

lmk thoughts and additional test cases. The old test cases covered most of these changes, the only new feature is the DGSException which I added a test case for.

Thanks for the PR. The idea of introducing a DgsException makes sense and simplifies the code handling them quite a bit in the DefaultDataFetcherExceptionHandler.kt. What I'll do is merge this PR in the feature/refactor-metrics branch and look at the failing text.

Hey! Sorry about the failing tests - I was going to take time to look at them but got caught up with midterms. If you want to take it over that’s fine, but it’s on the agenda for me. On Oct 10, 2022, at 4:19 PM, Bernardo Gomez Palacio @.***> wrote:
Merged #1248 into feature/refactor-metrics.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

@antholeole, the branch feature/refactor-metrics is based in your PR with additional small changes. There is a caveat around how we return errors when the request doesn't have a query. After discussing this with @srinivasankavitha, we both agree that the best approach is to change the code, in this case the BaseDgsQueryExecutor to return a known exception that will be caught by the DgsRestController and the DefaultDgsWebfluxHttpHandler to return 400. The response should follow the GraphQL standard of returning the following payload
{
                  "errors":[
                    {
                      "message": "GraphQL operations must contain a non-empty `query`.",
                      "locations":[],
                      "extensions": {
                        "errorType":"BAD_REQUEST"
                      }
                    }
                  ]
}

How does it impact metrics?
If the request doesn't have a query it will not be captured as part of the gql.query metrics, since it is not really a query. That said, if we do return a 400, it will properly show in the Spring MVC and Spring Webflux metrics.
If you want, and please let us know, you could implement the changes in the BaseDgsQueryExecutor, DefaultDgsWebfluxHttpHandler and DgsRestController to return a 400. This will impact the tests in both theMalformedQueryContentTest.kt used by webfux and mvc respectively.
Please feel free to

checkout the feature/refactor-metrics branch
use that as your base branch
squahs your changes
send a PR targeting master.

ref.
https://github.com/Netflix/dgs-framework/compare/feature/refactor-metrics?expand=1

Sure, I'll take that approach - seems the most correct and clever. I'll try to have a PR submitted by the end of week, perhaps earlier

Thank you!


Set up CD

Service should be automatically redeployed when dev branch changes.

We should do that with the help of Pubgrade once available.


Finalize avatars for the closed beta

The registry has the following avatars:

User
Organization
Challenge

Notes

Uploading images with the registry won't be available for the closed beta.
Images are important to engage the users: org logo should be used (e.g. stored on s3).

The goal of this task is too vague.


Stateless-lb: Disable old interfaces with same subnet as new

Description
When a new interface is detected any existing interface with the same subnet is disabled
Issue link
https://github.com/Nordix/Meridio/issues/392
Checklist

Purpose

[x] Bug fix
[ ] New functionality
[ ] Documentation
[ ] Refactoring
[ ] CI

Test

[ ] Unit test
[ ] E2E Test
[x] Tested manually

Introduce a breaking change

[ ] Yes (description required)
[ ] No

Tested, it works (but should be fixed in NSM, not Meridio)

Right :unamused: Should I merge anyway?

Works for me as well.
IMHO we should merge it.


Crashes randomly for a reason I can't figure out in the chart editor.

Describe your bug here.
It just, crashes randomly in the chart editor.
It MIGHT be shortly after entering/exiting the in-editor chart player.
Command Prompt/Terminal logs (if existing)
flixel/FlxSprite.hx (line 1401)
flixel/FlxSprite.hx (line 1555)
flixel/FlxSprite.hx (line 641)
objects/StrumNote.hx (line 269)
flixel/tweens/FlxTween.hx (line 746)
flixel/tweens/FlxTween.hx (line 1354)
flixel/FlxGame.hx (line 748)
flixel/FlxGame.hx (line 680)
flixel/FlxGame.hx (line 559)
openfl/events/EventDispatcher.hx (line 426)
openfl/display/DisplayObject.hx (line 1398)

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

it seems to be whenever i enter or exit the in game chart viewer


Add arg options for creating collections with options

Add argument options for creating collections with options

@jenssegers, can you review please?

What's the point of this when the blueprint create method does not accept any options? I would love to see an option in this framework to add json schemas to mongodb.
https://docs.mongodb.com/manual/core/schema-validation/


refresh issue, using js for redirect, mail added for confirmation

can you look at all of this and check that you also have functionality on your end?

Also, page doesn't redirect to confirmation for me

[Mon Jul 31 16:13:20 2023] PHP Notice:  Undefined index: research in /home/parth/coasttocow/upload.php on line 34
[Mon Jul 31 16:13:20 2023] PHP Stack trace:
[Mon Jul 31 16:13:20 2023] PHP   1. {main}() /home/parth/coasttocow/upload.php:0
[Mon Jul 31 16:13:23 2023] <IP_ADDRESS>:48958 [200]: POST /upload.php
[Mon Jul 31 16:13:23 2023] <IP_ADDRESS>:48958 Closing
[Mon Jul 31 16:13:23 2023] <IP_ADDRESS>:48966 Accepted
[Mon Jul 31 16:13:25 2023] PHP Notice:  Undefined variable: mail_pass in /home/parth/coasttocow/confirmation.php on line 17
[Mon Jul 31 16:13:25 2023] PHP Stack trace:
[Mon Jul 31 16:13:25 2023] PHP   1. {main}() /home/parth/coasttocow/confirmation.php:0


PATCH /api/users throws 400 error

Seeing a "PATCH https://api.prod-preview.openshift.io/api/users 400 (Bad Request)" error message in the browser console.
More details:
"invalid_request","detail":"invalid value assigned to registration_completed for identity with id ab7718a0-34a8-4e9e-8762-786e6edac6f6 and user with id eebdbff3-b851-48ca-8057-5b4b9396966a"
I'm calling PATCH /api/users to update the username, but without registration_completed=true. That is, I'm omitting registration_completed from the GET payload. I expect to be able to call this API without setting registration_completed, so the page can wait for GitHub and OpenShift to be linked.
My workaround is to call PATCH /api/users with registration_completed=true. However, this means registration_completed=true while GitHub and OpenShift have not been linked -- the registration is not complete at this point. It also means that we also cannot test this functionality in the UI's getting started page more than once.

@dlabrecq do you have  registration_completed= set in the payload you sending by any chance?

I wonder if you should just ignore if registration_completed attribute if it's not true

This should be simplified. Ignore any logic around username updates.
If registration_complete is false, other services should not respond (to come later)
If registration_complete is false, username can be set as many times as you want.
if registraion_complete = true, username can not be updated.
UI calls PATCH with registration_complete

@dgutride
Could you help me with the entire request?
I tried skipping the registration_completed and the update works -
./bin/alm-cli update users --key $ALM_TOKEN  --payload '{ "data":{ "type":"identities" ,  "attributes":{"bio":"something2"  }}}'  -H localhost:8080 --pp

{
    "data": {
        "attributes": {
            "bio": "something2",
            "company": "",
            "created-at": "2017-04-27T10:52:01.567676Z",
            "email"<EMAIL_ADDRESS>            "fullName": "Shoubhik Bose",
            "identityID": "ae68a343-c866-430c-b6ce-a36f0b38d8e5",
            "imageURL": "https://www.gravatar.com/avatar/411ab2beb956a4908dddcaa7189b3e79.jpg",
            "providerType": "kc",
            "registrationCompleted": false,
            "updated-at": "2017-04-27T16:05:20.793361Z",
            "url": "",
            "userID": "263b9f94-8f03-42be-a88e-312c68a3307f",
            "username": "testuser"
        },
        "id": "ae68a343-c866-430c-b6ce-a36f0b38d8e5",
        "links": {
            "self": "http://localhost:8080/api/users/ae68a343-c866-430c-b6ce-a36f0b38d8e5"
        },
        "type": "identities"
    }
}

@alexeykazakov Looking at the code, again, I believe registraion_complete was most likely false. So, it probably wasn't omitted from the payload as suggested earlier.
When calling PATCH /api/users, the payload is actually a copy of the User object from UserService.loggedInUser. I simply make changes to that as necessary. Thus, I believe registraion_complete=false was most likely there when the username was updated.

If registration_complete is false, username can be set as many times as you want.
https://github.com/almighty/almighty-core/pull/1267

@aslakknutsen ^^

I tried this once again and confirmed I'm getting the error with registration_complete=false in the payload. If I remove registration_complete from the payload, the username is updated, but  registration_complete is now true.
I can no longer update my username.


Twitter API string error

TypeError: not all arguments converted during string formatting
Expected behavior
I am expected a response of Tweets in text format.
Actual behavior
I also had exception 403 error.

Issue resolved. I had to join labs and activate each feature.


Update repositories to use https instead of http

Maven blocks unsecure HTTP requests by default since 3.8.1 release

Hey, thanks for your PR! I was also trying to change it all to HTTPS but back then and now with this PR I'm getting that error when running mvn clean install:
Downloading from maven-default-http-blocker: http://<IP_ADDRESS>/be/maximvdw/MVdWUpdater/1.6.0-SNAPSHOT/maven-metadata.xml [WARNING] Could not transfer metadata be.maximvdw:MVdWUpdater:1.6.0-SNAPSHOT/maven-metadata.xml from/to maven-default-http-blocker (http://<IP_ADDRESS>/): transfer failed for http://<IP_ADDRESS>/be/maximvdw/MVdWUpdater/1.6.0-SNAPSHOT/maven-metadata.xml [WARNING] be.maximvdw:MVdWUpdater:1.6.0-SNAPSHOT/maven-metadata.xmlfailed to transfer from http://<IP_ADDRESS>/ during a previous attempt. This failure was cached in the local repository and resolution will not be reattempted until the update interval of maven-default-http-blocker has elapsed or updates are forced. Original error: Could not transfer metadata be.maximvdw:MVdWUpdater:1.6.0-SNAPSHOT/maven-metadata.xml from/to maven-default-http-blocker (http://<IP_ADDRESS>/): transfer failed for http://<IP_ADDRESS>/be/maximvdw/MVdWUpdater/1.6.0-SNAPSHOT/maven-metadata.xml

Looks like I had MVdWPlaceholderAPI cached in my local m2 repository and didn't get this error. I think I can fix it with exclusions, but there's a problem with SSL certificate for *.mvdw-software.be that expired at Tue, 27 Jul 2021 23:59:59 GMT


Looking for Contributors to MarineTrack

MarineTrack is a new project aimed at developing a comprehensive Vessel Tracking and Monitoring System. We are looking for passionate contributors to join us in building this innovative solution. Whether you're a developer, designer, tester, or documentation specialist, we welcome your contributions!
Issue Title:
Looking for Contributors to MarineTrack
Description:
MarineTrack is a new project aimed at developing a comprehensive Vessel Tracking and Monitoring System. We are looking for passionate contributors to join us in building this innovative solution. Whether you're a developer, designer, tester, or documentation specialist, we welcome your contributions!
How to Get Started:

Fork the repository and clone it to your local machine.
Check out our Contributing Guide (link to be provided).
Pick an issue labeled good first issue or suggest a new feature.
Submit your pull request.

Hey @stormdotcom
Do you think rewarding contributions with XP/Levels/Badges may help to acquire/engage the community? If so, you're welcome to check the devActivity


Upgrade windows crate from v0.37 to v0.43

Hello it's me from #51 again!
The windows crate has seen a bit more churn recently, and I figured it might be worth proactively upgrading the version used by trash-rs.
Functionality-wise this should not change anything. I measured compile times before+after and it seems about 5% faster now.

There were some unrelated Clippy failures on Linux (probably related to a new Clippy version), fixed.

Thanks so much for your help with this! And by the looks of it, the churn is worth it as the code looks more and more idiomatic!
One day, Windows having a native Rust API might actually want to make me write software for it 😅.

And here is the release, I made it a major one maybe for the wrong reason. Can different versions of the windows crate co-exist?

Can different versions of the windows crate co-exist?

Yep! Compiling windows twice is a bit rough for compile times but it has been working fine in Nushell.


feat: add filters to ChaindeskRetriever

reference: https://docs.chaindesk.ai/api-reference/endpoint/datastores/query
cc @gmpetrov

Seems good and backwards compatible to me, see comment!

Can you run yarn format?

should be good now @jacoblee93 :)

Thank you!


Revert "Ensure the engineLayer is disposed when an OpacityLayer is disabled"

Reverts flutter/flutter#94280
This causes some internal test failure: b/209109682

Sorry, created by mistake.

Actually this is the right one.

@renyou Please cc original authors (and potentially reviewers) on reverts.
/cc @ctrysbita @dnfield

@goderbauer @dnfield Hmmm, how can we inspect the failure?

Unfortunately, it is internal code. I tried to create an open-source reproducible test case yesterday, but haven't been successful. I'll post it when I have one.


Improve ansible* executable discovery

Currently the user has to specify paths to ansible, ansible-navigator, and ansible-lint or the virtual environment or the virtual environment activation script.
This can require some detailed knowledge of python which all users may not have.
Since we require the python extension, can we leverage its configuration by default and leave our own settings in place as overrides?
A good reference might be here: https://github.com/microsoft/vscode-python-tools-extension-template/blob/main/src/extension.ts#L9
(that template was announced here: https://devblogs.microsoft.com/python/python-in-visual-studio-code-august-2022-release/#python-tools-extension-template

I was curious about the relationship between settings in the python extension (ms-python.python) and the redhat.ansible extension... so I did some testing...
In my case, pointing the python extension to my custom virtual env led to the redhat.ansible extension working too. Removing this setting breaks the ansible extension.
I do not have ansible installed globally. Instead, it's installed in a custom venv in my workspace. Along with ansible-lint. This way the ansible extension won't just work with its default config.
In settings.json I added/removed this one setting:
"python.defaultInterpreterPath": "test/.venv/bin/python3",

To test this setting, I used a file that I have setup to match as language mode = ansible. Each time I made a change to this setting, to test it, I closed the test ansible file in vscode, quit/reopened vscode, reopened the test file. Then I waited to see if I got error messages in toasts from the ansible extension, or if the ansible extension features loaded (ie ansible-lint output in the editor).
Without the setting I get the following two errors (as well as ansible extension features not working):
Ansible-lint is not available. Kindly check the path or disable validation using ansible-lint

Command failed: ansible-config dump
/bin/sh: ansible-config: command not found

When I put the setting back, both errors did not show and instead I had ansible extension features operational once again.
If this isn't explicitly designed in the redhat.ansible extension then perhaps it's just by virtue of the python extension activating the virtual env (modifying the path) so that the default settings for ansible/ansible-lint/etc just work?
FYI, testing was unreliable if I didn't fully quit and reopen vscode. Commands like "Reload Window" aren't enough with this settings change.

It would be rock to fully document the expected behavior/interplay of the various path settings and python venvs settings within this redhat.ansible extension. As well as expected behavior with key settings in dependent plugins (ie python extension).

How would that play into User, remote and Workspace settings since the setting exists in all 3?


Create PolytopeBoundedVoronoi.py

Polytope-bounded-Voronoi-diagram-Python

Nice work, @anvisha16 thanks for contributing.


check for WSAEMSGSIZE errors when receiving UDP packets on Windows

Fixes #3956. @thepaul, could you give this patch a try?

Fixes #3956. @thepaul, could you give this patch a try?

This does indeed fix the problem, according to my tests.

You might have to do handling for macOS since we merged https://github.com/quic-go/quic-go/pull/3946

No changes should be necessary- the DF bit on outgoing datagrams shouldn't affect recvfrom(). It would affect things if we were using recvmsg() instead, and able to receive MSG_TRUNC control messages, but quic-go isn't there yet I think.

@thepaul yes, there's no real change involved here. My comment was related to changes in sys_conn_df.go done in https://github.com/quic-go/quic-go/pull/3946/files
That commit changed the build flags on sys_conn_df.go and introduced sys_conn_df_darwin.go. An older version of these files is modified in this PR.

Oh yes, I did read that change- sorry I wasn't clear! That change seems to amount to "set the DF bit on outgoing packets", and my claim is that that won't affect what is received with recvfrom().

This PR splits isMsgSizeErr into isSendMsgSizeErr and isRecvMsgSizeErr. That change needs to be made in this file too https://github.com/quic-go/quic-go/blob/master/sys_conn_df_darwin.go

This PR splits isMsgSizeErr into isSendMsgSizeErr and isRecvMsgSizeErr. That change needs to be made in this file too https://github.com/quic-go/quic-go/blob/master/sys_conn_df_darwin.go

I see. This PR was based on an older commit, that's why CI succeeded on push, but failed on pull_request. I rebased and fixed.


records were not visible on greenlight

hi, i installed it on my server and it worked fine. However, when I installed it on another server, the records were not visible on greenlight. how should i go?

Hi @ibrahimbilgin , As we updated the default playback.html, when you would visit the default playback url - https://<your-bbb-fqdn>/playback/presentation/2.0/playback.html?meetingId=<meeting_id> - you would be redirected to the corresponding MP4 video url - https://<your-bbb-fqdn>/recording/<meeting_id>.mp4

Hi @ibrahimbilgin , As we updated the default playback.html, when you would visit the default playback url - https://<your-bbb-fqdn>/playback/presentation/2.0/playback.html?meetingId=<meeting_id> - you would be redirected to the corresponding MP4 video url - https://<your-bbb-fqdn>/recording/<meeting_id>.mp4

yes I know but there is a problem with the redirect, also I cannot see my recordings on greenlight :( british.web.tr/playback/presentation/2.0/playback.html?meetingId=123123asd

Hi @ibrahimbilgin , As we updated the default playback.html, when you would visit the default playback url - https://<your-bbb-fqdn>/playback/presentation/2.0/playback.html?meetingId=<meeting_id> - you would be redirected to the corresponding MP4 video url - https://<your-bbb-fqdn>/recording/<meeting_id>.mp4

yes I know but there is a problem with the redirect, also I cannot see my recordings on greenlight :( https://british.web.tr/playback/presentation/2.0/playback_default.html?meetingId=123123asd

If you have followed installation steps it should work fine here is the sample Sample Playback I dont have mp4 for this meeting ,so it is redirecting to default player.If i had mp4 for this meeting it would have redirected to mydomain.com/recording/meetingid.mp4

@ibrahimbilgin Can you please try the latest code?
We have simplified playback.html by redirecting after the page loads. So it should work in all cases.

@ibrahimbilgin Can you please try the latest code?
We have simplified playback.html by redirecting after the page loads. So it should work in all cases.

I want to install clean, how can I uninstall this tool?

Hi @ibrahimbilgin , As we updated the default playback.html, when you would visit the default playback url - https://<your-bbb-fqdn>/playback/presentation/2.0/playback.html?meetingId=<meeting_id> - you would be redirected to the corresponding MP4 video url - https://<your-bbb-fqdn>/recording/<meeting_id>.mp4

yes I know but there is a problem with the redirect, also I cannot see my recordings on greenlight :( https://british.web.tr/playback/presentation/2.0/playback_default.html?meetingId=123123asd

If you have followed installation steps it should work fine here is the sample Sample Playback I dont have mp4 for this meeting ,so it is redirecting to default player.If i had mp4 for this meeting it would have redirected to mydomain.com/recording/meetingid.mp4.
you have mentioned it is working on one of your server, are you able to see the recordings of that server in greenlight?

no mp4 records not showing on "greenlight"

To uninstall,

mv /var/bigbluebutton/playback/presentation/2.0/playback_default.html /var/bigbluebutton/playback/presentation/2.0/playback.html
mv /usr/local/bigbluebutton/core/scripts/post_publish/post_publish.rb.default /usr/local/bigbluebutton/core/scripts/post_publish/post_publish.rb

With this, you would be able to restore, default playback behavior and default post_poublish action.

i uninstall it but i cant see my recording :(
this link -> https://british.web.tr/playback/presentation/2.0/playback.html?meetingId=8ae04156b98b6e8597de1416b4e153d40a18acd7-1613066383930 redirecting to -> https://british.web.tr/playback/presentation/2.0/playback_default.html?meetingId=8ae04156b98b6e8597de1416b4e153d40a18acd7-1613066383930 and its 404

@ibrahimbilgin perhaps the default playback.html file is changed. The content of your/var/bigbluebutton/playback/presentation/2.0/playback.html and this file: playback.html  should match . If you uninstalled bbb-mp4 and the files content doesn't  match then replace your playback.html with the one i have mentioned earlier.

i still have the same problem. Although I did uninstall, it didn't improve.
https://british.web.tr/playback/presentation/2.0/playback_default.html?meetingId=8ae04156b98b6e8597de1416b4e153d40a18acd7-1613066383930

@ibrahimbilgin can you post your playback.html and playback_default.html code here?


Z-index not good on resolve conflict page

content.js:2275 Uncaught (in promise) TypeError: Cannot read property 'parentNode' of null
    at linkify_issues_in_titles (content.js:2275)
    at enableFeature (content.js:1125)
    at <anonymous>

@bfred-it Maybe time to remove the overlay? It just causes so many problems, and I have to be honest, I find it more annoying than useful.

@yakov116 the console error is unrelated.
@sindresorhus I don't mind this bug, but if it annoys others it's fine to remove it.

@bfred-it I know I had the first issue, then right before I posted it I decided to look in the dev console.


doc(install): Add --no-build-isolation to examples

You can avoid pep517 until falcon does not actually use it, and with it it's build isolation rules, by omitting pyproject.toml from the distribution by changing manifest.ini.
Sqlalchemy is currently using this behavior: https://github.com/sqlalchemy/sqlalchemy/blob/master/MANIFEST.in#L17
You can check this since Sqlalchemy version 1.13.15 had pyproject in the distribution and therefore uses pep517 vs 1.13.16 removed it, and uses the old method.


Changed package name

Issue #15
Bower issue:
https://github.com/bower/bower/issues/2242

It is unfortunate that the name has initially registered with something bower doesn't like, but renaming it may make other projects not able to fetch newest releases. And it's just a recommendation and not a requirement, so I'll need pass this. Thanks for your effort though.


refactor script evaluator

In preparation for the introduction of the binding mechanism.

move public methods to the top, and private methods to the bottom of the class, for readability

move a few methods to within ScriptEvaluator, because we will need to use this to access the to be introduced event manager member variable

This is intended to reduce diff noise in the main PR (#319).
Furthermore, remove unnecessary switch case braces.
This is a no-op.
Bug: #294

Did you merge it on purpose or by mistake?


install error on mac

Running $ go get github.com/Azure/azure-storage-blob-go/2016-05-31/azblob
gives me this output
# github.com/Azure/azure-storage-blob-go/2016-05-31/azblob
gocode/src/github.com/Azure/azure-storage-blob-go/2016-05-31/azblob/highlevel.go:164:7: undefined: mmf
gocode/src/github.com/Azure/azure-storage-blob-go/2016-05-31/azblob/highlevel.go:166:12: undefined: newMMF

My environment:
$ go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/mfischer/alpha/gocode"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.9.3/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.9.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/mm/q2bf08hn361bhqqq5wy38ssc0000gn/T/go-build111810440=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

Edit:
oh I see there are files for windows/linux but none for mac. For now, I'll comment out that code since looks like only used as example.

Oh. I see there are mmap_windows.go and mmap_linux.go but no similar file for mac

Are there plans to support this library on osx?

Yes, we will. For now, rename mmap_linux.go to mmap_darwin.go and you should be good. I have the fix for this but it is not checked in yet.

Actually the file name has changed

mv mmf_darwin_linux.go mmf_darwin.go

Renaming the file with a "_unix" suffix should allow for successful builds targeting both darwin and linux:
mv mmf_darwin_linux.go mmf_unix.go

Renaming to mmf_unix.go will break the build on Windows. However, I think I fixed this awhile a go by adding "// +build linux darwin" to the .go file.

According to the documentation (https://golang.org/pkg/go/build/#overview), using a conditional compilation suffix should take the following form: source__.go (e.g., source_windows_amd64.go). So using the build tags is appropriate in this case but the file suffix must not trigger an implicit conditional compilation.

If you run "go tool dist list", you'll see the list of supported GOOS/GOARC combinations. "unix" is not on the list at all and therefore not a supported GOOS. So, a file name ending with "_unix.go" is ALWAYS compiled by the compiler regardless of the GOOS. This is why I MUST add "// +build linux darwin" to the top of my file. Alternatively, I could have to files with identical contents but one named mmf_darwin.go and the other named mmf_linux.go. I prefer the 1 file so I don't have to make similar changes in multiple files.


Exposed more graph io methods

I think these should probably be exposed since some of these are being used in examples, such as parsing utilities here.

Jenkins, test this please.

@tensorflow-jenkins test this please


Add support for nrfx i2s driver

We would like to use the nrfx i2s driver. Is it possible at this time? If not, is it scheduled to be integrated in the near future?

I have managed to use the nrfx i2s driver with zephyr but I am still curious to know if it is planned to be included in a future release.
And it would be nice if the higher level i2s api in zephyr would support interrupt driven i2s with a callback fired when more data is needed, like the nordic driver.

Sounds great, thanks!

@m-nilsson :
@barsok told me he needs to do some clean up on his branch. He should be able to share it with you around Wednesday this week.

Currently have to manually add NRFX_I2S_ENABLED as well as add "zephyr_sources(nrfx/drivers/src/nrfx_i2s.c)"

@jarz-nordic @anangl any news on this front?

@jakub-uC , @barsok - I am also looking at using the nrfx I2S driver in zephyr; would it be possible to get access to the in-progress branch ? I would much prefer to get started with something that has been tested some rather than start from scratch myself .)

@binkboyd : I am affraid that temporary branch has not been updated for a long time. As a result it might be hard to sync with current zephyr master.
Personally I recommend to use directly nrfx driver without I2S shim.
@barsok : Please correct me if I am wrong.

@jakub-uC @binkboyd  hi!  We have a working SHIM and is now being prepared for review. @adamkondraciuk would you please comment?

Hi. The code needs to be cleaned and refactored. There are many comments, useless logs and awkward test solutions.

@jakub-uC @binkboyd  please let us know if you would like to work with dirty but working code or if you prefer to wait until we put a PR to github (soon)?

@barsok : My impression was that @binkboyd can leave with dirty code.

hi, I found https://github.com/barsok/zephyr/tree/bsokol-i2c which I've merged into zephyr master manually. Is this the current "dirty" code ? I'm still working on some other hardware, so I am yet to test other than that it compiles. @barsok - what is the timeline on the PR ?

Hi @binkboyd . This code is not up to date. Tomorrow I will share in my fork current I2S driver code.

excellent; thanks!

@adamkondraciuk ; do you have an ETA? I was testing with the older code from @barsok  today and was not able to get it to work. Dirty code is no problem as long as it works :)

Hi. Sorry for lag - I had some technical problems. Here is the driver: https://github.com/adamkondraciuk/zephyr/tree/i2s_test

hm; couldn't find anything there - are you sure you pushed the code to github ?

sorry - now it should be OK

excellent; thanks! :+1:

Is there any update on this? Or is there any newer version of the "dirty" code. Thanks.


GenerateReleaseNotes - Skip artifact

Our release has links two more than one build type artifacts. Is it possible to create Release notes for only one of them and skip the other ones? Thanks!

I have had a think about this. there are a few options

Could add a flag so that the release notes are only generated for primary artifact, this feels limiting
Need to provide a way to enter the name of the build to generate notes for, this feels awkward and prone to error. I don't think there is a way to populate a drop down with the names of the artifacts in the release

Either is doable but neither really appeals as a solution
Can you think of a better way?

I believe that option 1 [flag for primary only] would satisfy most of users.

I have done the first option then, it is now public in 1.6.1

Thank you for the prompt support! It works as expected.
I have another question: is there a way to extract the hyperlink address of the associated work items? Thanks!

It should be available on the work item object, the tag to get the ID is
$($widetail.id)
The url is in same form, so it is
$($widetail.url)
The MSDN REST documenation list all the data returned


Character doesn't find vendor

Details
Character doesn't move.
Game is set to run at 1280x720, however my native resolution is 3440x1440.
Previous version I had set my native resolution to 1920x1080 with game resolution 1280x720 and it worked.
Any ideas?
Version
v0.4.0
Logs
time=03:06:14 level=DEBUG msg="Loading screen detected, waiting until loading screen is gone"
time=03:06:16 level=DEBUG msg="Load completed, continuing execution"
time=03:06:16 level=DEBUG msg="Checking for character corpse..."
time=03:06:16 level=DEBUG msg="Character corpse not found :D"
time=03:06:16 level=DEBUG msg="Checking for items to identify..."
time=03:06:16 level=DEBUG msg="No items to identify..."
time=03:06:16 level=DEBUG msg="Belt Stats Health: 1/3 healing, 4/6 mana, 3/3 rejuv."
time=03:06:16 level=DEBUG msg="Need more pots, let's buy them."
time=03:06:16 level=INFO msg="Visiting vendor..." forceRefill=false
time=03:08:14 level=WARN msg="Game finished with errors, reason: max game length reached, try to exit game: 120.00. Game total time: 120.03s" supervisor="Blizzard Sorc" mapSeed=278265313

Closing this item.
Resetting controls to default resolved the issue.


bench syntax v2: run test in single functions

The v2 benchmark tests are running in one single function instead of one function per bench case.
Current output:
test benchmark_tests::test_benchmarks ... ok

Output that we want:
test benchmarking::bench_sort_vector ... ok
test benchmarking::bench_accumulate_dummy ... ok
test benchmarking::bench_set_dummy_benchmark ... ok

It is probably using this wrong expansion arm here:
https://github.com/paritytech/substrate/blob/2e535bac47f48d816f94b105715e09dc57ed52b0/frame/benchmarking/src/v1.rs#L541
instead of:
https://github.com/paritytech/substrate/blob/2e535bac47f48d816f94b105715e09dc57ed52b0/frame/benchmarking/src/v1.rs#L508

Friendly ping, we are using the bench syntax v2 in https://github.com/subspace/subspace, and this feature is highly desired by our usage.

Okay thanks for the feedback @NingLin-P
Feel free to post additional feedback into https://github.com/paritytech/substrate/issues/13132, since the syntax is not finalized yet.


How to cite morfeus

morfeus is an excellent tool to calculate molecular features, I am curious how to cite morfeus in the research paper.

Thanks! For now I think the best is to cite the web address of this GitHub repo and give the version number that you used. There is a morfeus paper in the works, but unfortunately delayed for now. Within the next weeks I will hopefully set up the Zenodo integration and then you can also cite the DOI for the Zenodo entry.


Fix how we calculate fields in stream_data.js.

We used to have code scattered in multiple places to
calculate things like admin options, preview urls,
subscriber counts, and rendered descriptions for
streams before we rendered templates in the "Manage
Stream" code.
These are all consolidated into a new function
called stream_data.update_calculated_fields().
This is mostly code cleanup, but it also fixes a bug where
the "View Stream" button would not work for a newly created
stream.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

Looks great, merged, thanks @showell!


OSSM-6693: Enable Gateway API by default in cluster-wide mode

for GatewayControllerMode to work, you still have to set techPreview.gatewayAPI.enabled=true

Gateway controller mode was implemented for the ingress controller that is tech-preview too, so I didn't care about that.

Also, the field values.gatewayAPI.enabled will show up as set to false in the SMCP's status, even when in clusterWide mode, which might again be confusing.

Ok, this convince me to implement proper conversion.

LGTM, do we need the duplicate tests for "bool" vs bool though?

No, we do not. I removed it.

What was wrong with the previous approach?

Conversion would enable gateway API in all SMCPs - new and existing.

I'm not sure we should do that, it'll look like we're enabling features that are not GA.

First of all, we disable IOR the same way and we are going to do the same with Jaeger. Second, this is why I started with changing the template. In that approach, proper env vars were enabled, while tech-preview feature was disabled, but you expected to set techPreview. What's the difference between seeing spec.techPreview.gatewayAPI.enabled vs status.appliedSpec.techPreview.gatewayAPI.enabled? For me, there is no difference. None of these is less confusing. In both cases you have enabled tech-preview feature.


GPS devices detect problems in Apollo, what needs to be done?

GPS devices detect  in linux no problem, it can receive satellite data and RTK-GPS data. However, the Apollo HMI GPS detection error, the following is the configuration information and error log. I want to know what else needs to be done to make GPS device pass the “Setup”.
1.localization.INFO:
Log file created at: 2017/12/19 15:47:45
Running on machine: in_dev_docker
Log line format: [IWEF]mmdd hh:mm:ss.uuuuuu threadid file:line] msg
E1219 15:47:45.412098  5828 rtk_localization.cc:79] GPS message buffer is empty.
E1219 15:47:45.421730  5828 rtk_localization.cc:79] GPS message buffer is empty.
E1219 15:47:45.449895  5828 rtk_localization.cc:79] GPS message buffer is empty.
E1219 15:47:45.449975  5828 rtk_localization.cc:79] GPS message buffer is empty.
E1219 15:47:45.464756  5828 rtk_localization.cc:79] GPS message buffer is empty.
2.gnss_driver.launch:

<node pkg="nodelet" type="nodelet" name="gnss_nodelet_manager"
    args="manager" output="screen">
    <param name="proj4_text" value="$(arg proj4_text)" />
</node>

<node pkg="nodelet" type="nodelet" name="stream_nodelet"
    args="load gnss_driver/StreamNodelet gnss_nodelet_manager" output="screen">
    <param name="gnss_conf" value="$(arg gnss_conf)" />
</node>

<node pkg="nodelet" type="nodelet" name="parser_nodelet"
    args="load gnss_driver/ParserNodelet gnss_nodelet_manager" output="screen">
    <param name="gnss_conf" value="$(arg gnss_conf)" />
    <param name="proj4_text" value="$(arg proj4_text)" />
</node>

3.gnss_conf_mkz.txt:
data {
format: NOVATEL_BINARY
serial {
device: "/dev/ttyUSB0"
baud_rate: 115200
}
}
rtk_from {
format: RTCM_V3
ntrip {
address:rtk.ntrip.qxwz.com
port:8002
mount_point:RTCM30_GG
user:qxmfj002
password:cb55ed2
timeout_s: 5
}
}
rtk_to {
format: NOVATEL_BINARY
serial {
device: "/dev/ttyUSB1"
baud_rate: 115200
}
}
rtk_solution_type: RTK_RECEIVER_SOLUTION
login_commands: "UNLOGALL THISPORT\r\n"
login_commands: "LOG COM2 GPRMC ONTIME 1.0 0.25\r\n"
login_commands: "EVENTOUTCONTROL MARK2 ENABLE POSITIVE 999999990 10\r\n"
login_commands: "EVENTOUTCONTROL MARK1 ENABLE POSITIVE 500000000 500000000\r\n"
login_commands: "LOG NCOM1 GPGGA ONTIME 1.0\r\n"
login_commands: "log bestgnssposb ontime 0.5\r\n"
login_commands: "log bestgnssvelb ontime 0.5\r\n"
login_commands: "log bestposb ontime 0.5\r\n"
login_commands: "log INSPVASB ontime 0.01\r\n"
login_commands: "log CORRIMUDATASB ontime 0.01\r\n"
login_commands: "log INSCOVSB ontime 1\r\n"
login_commands: "log mark1pvab onnew\r\n"
login_commands: "log imutoantoffsetsb once\r\n"
login_commands: "log vehiclebodyrotationb onchanged\r\n"
logout_commands: "EVENTOUTCONTROL MARK2 DISABLE\r\n"
logout_commands: "EVENTOUTCONTROL MARK1 DISABLE\r\n"

I grab some serial data，for example:
/dev/ttyUSB0:
$GPFPD,0,5787.500,0.000,1.443,-0.805,0.0000000,0.0000000,0.00,0.000,0.000,0.000,0.000,0,0,005D
$GPHPD,0,5785.000,0.000,0.000,0.000,0.0000000,0.0000000,0.00,0.000,0.000,0.000,0.000,0,0,0076

My GPS device chip is OEM617D.Manufacturers can only change INSPVAS = 508, RAWIMUSX = 1462, GPGGA = 218, these three Message agreements,Please Help to see if it works?


dark mode toggle when not using dark mode

it means a toggle button are available with not using dark mode

too bad https://github.com/athul/archie/pull/19 are not pickup

LGTM

Merged changes https://github.com/RobbiNespu/archie/pull/4


[WIP] ASEB controller should generate route/ingress in overlays

What does this PR do?:

This PR consumes the Gitops Generator Library changes https://github.com/redhat-developer/gitops-generator/pull/45 to generate route and ingress in overlays resources
Tests (WIP)
Which issue(s)/story(ies) does this PR fixes:

https://issues.redhat.com/browse/DEVHAS-329
PR acceptance criteria:

[ ] Unit/Functional tests

[ ] Documentation

[ ] Client Impact

How to test changes / Special notes to the reviewer:

If https://github.com/redhat-developer/gitops-generator/pull/45 is not merged yet, checkout the branch of Gitops Gen library and update this PR's go.mod local path. Build and Run.
If https://github.com/redhat-developer/gitops-generator/pull/45 is merged, Build and Run to confirm the Gitops resources are generated in the correct dirs in the repo

/retest


Audio media data missing duration

To be fair, not all audio in Drupal has a duration either (imported segment audio).

Hey @rpeterman-gp we didn't see any duration field as part of the import spreadsheet fields we needed to follow during migration, but as we have the Drupal file ID stored in the database we can run a new process to migrate the duration information if needed.

Old stuff won't have durations, but new stuff will. Closing.


Error: Page does not exist: /static/logo.png

[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Automatically render the static folder to get access to some assets for the manifest.json file.

Current Behavior
The routing seems confused thinking that static is a page instead of an asset folder. Doesn't work in both cases : static folder at the root, and static folder in src.

Steps to Reproduce (for bugs)
https://github.com/glemiere/nextjs-starter/tree/Static-Folder-Routing-Bug
Context
Impossible to set icon in the manifest.json

Your Environment

Tech
Version

next
5

node
9

OS
OSX

browser
X

etc
X

https://github.com/glemiere/nextjs-starter/tree/Static-Folder-Routing-Bug/src/static
They're supposed to be here.

Wow weird! I just tried again, I was getting a 404 yesterday and now it works without changing anything. I have no idea what's going on, good news though. Thank you!


TO postinstall - generateCert no longer overwrites cdn.conf

Fixes #2328
Since generateCert creates the same files as are referenced in the cdn.conf by default,  just check that they match rather than overwriting the file.  This has the added benefit of not reordering the keys in the file.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1671/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1672/
Test PASSed.


Extend Support for code generation of Async Api

Hi,
Is there a way to use the quarkus-openapi-generator for code generation of async api. Is there a plan to provide support for code generation of async api?
Thanks,

Hi @sneeve. There's a different extension for AsyncAPI.
https://github.com/quarkiverse/quarkus-asyncapi

Given a yaml/json file the quarkus-asyncapi generate the code for the specific channels, publishers, consumers etc. From the readme it looks like it scans the code and provides a yaml

@fjtirado can you answer @sneeve's question, please?

@fjtirado - Will the quarkus-asyncapi plugin, when given a yaml/json file generate the code for the specific channels, publishers, consumers etc specified in the yaml. From the readme it looks like it scans the code and provides a yaml


ensure topics is no longer in preview

The topics command was marked as preview previously. In this PR, the preview features were grouped under a preview subcommand, but not the topics command. So since then topics has not been under preview.


createVideoFrameCallback

I'd like to contribute a primitive for the requestVideoFrameCallback API.
Fundamentally it works the same as requestAnimationFrame, but with some convenient features for videos such as not requesting redundant frames when the video is paused, or polling higher than the videos framerate.
Implementation
Since it's so similar, I'd match the API of createRAF almost exactly. They might be so similar that they could share a common implementation, but I'd leave the up to the package maintainers and create a parallel version for now.
The only relevant difference might be that if the video element is removed, the callback could be cancelled reactively (for example if it took an Accessor<HTMLVideoElement> as an input). But maybe that should be left up to the user, since it doesn't really save that much mental overhead, and the user would still need to handle assigning the ref and clearing it in an onCleanup.
Naming
Any recommendations?

createRequestVideoFrameCallback is a bit of a mouthful, but it's the most descriptive
createRVFC matches the naming convention of createRAF, but it's pretty cryptic at a glance.
createVideoFrameCallback is my personal preference, dropping the request verb in favor of the conventional create (or make)

Would anyone else find this useful? Any opinions on the best approach?

I like the last name best, because it is a nice compromise between being descriptive and not being too long.
My suggestion would be to provide makeVideoFrameCallback as well as createVideoFrameCallback so the user can decide.
I'm still unsure if those should go into a separate package or inside raf. Maybe it could be the start of a video package.


Lifting expressions in OPS kernels

Same as #823 but with fixes from review applied

Codecov Report

Merging #832 into master will increase coverage by 0.02%.
The diff coverage is 91.17%.

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   88.84%   88.86%   +0.02%
==========================================
  Files         100      102       +2
  Lines       11341    11401      +60
  Branches     2234     2247      +13
==========================================
+ Hits        10076    10132      +56
- Misses        981      982       +1
- Partials      284      287       +3

Impacted Files
Coverage Δ

devito/ops/node_factory.py
100% <100%> (ø)
:arrow_up:

devito/ops/nodes.py
100% <100%> (ø)

devito/ops/utils.py
100% <100%> (ø)
:arrow_up:

devito/ops/types.py
100% <100%> (ø)

devito/ir/iet/visitors.py
83.14% <66.66%> (ø)
:arrow_up:

devito/ops/operator.py
87.5% <82.35%> (+16.07%)
:arrow_up:

devito/ops/transformer.py
93.33% <92.3%> (-6.67%)
:arrow_down:

devito/data/allocators.py
72.78% <0%> (-0.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7af7e30...7567af4. Read the comment docs.

It would simplify a few things related to accessing arrays (I had to
revisit the expressions a few times to use the accessors properly using
OPS_ACC). Long term I'd prefer the new API and it's a cheap change at this
stage
On Fri, 19 Jul 2019, 16:58 vmickus<EMAIL_ADDRESS>wrote:

@vmickus commented on this pull request.
In devito/ir/iet/visitors.py
https://github.com/opesci/devito/pull/832#discussion_r305396421:

@@ -152,10 +152,10 @@ def _args_decl(self, args):
"""Generate cgen declarations from an iterable of symbols and expressions."""
ret = []
for i in args:

       if i.is_Tensor:

           ret.append(c.Value('%srestrict' % i._C_typename, i._C_name))

       elif i.is_AbstractObject or i.is_Symbol:

       if i.is_AbstractObject or i.is_Symbol:

As we talked in the channel with Istvan about this OPS update, he said
that the OPSACC# will continue to be supported. I don't see a reason to
change it as you have done so much with it @vincepandolfo
https://github.com/vincepandolfo. IMO.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/opesci/devito/pull/832?email_source=notifications&email_token=ABMEPRQY6AZ5PMSVYGVHGALQAHJC3A5CNFSM4HMC3ZHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7AFZ7Y#discussion_r305396421,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABMEPRSUVHEEAQM7HD35JGTQAHJC3ANCNFSM4HMC3ZHA
.

I also prefer the new syntax as its easier to write the accessors like you said.
I was only concerned with the refactoring work. But I agree =]

It would simplify a few things related to accessing arrays (I had to revisit the expressions a few times to use the accessors properly using OPS_ACC). Long term I'd prefer the new API and it's a cheap change at this stage
…
On Fri, 19 Jul 2019, 16:58 vmickus, @.> wrote: @.* commented on this pull request. ------------------------------ In devito/ir/iet/visitors.py <#832 (comment)>: > @@ -152,10 +152,10 @@ def _args_decl(self, args): """Generate cgen declarations from an iterable of symbols and expressions.""" ret = [] for i in args: - if i.is_Tensor: - ret.append(c.Value('%srestrict' % i._C_typename, i._C_name)) - elif i.is_AbstractObject or i.is_Symbol: + if i.is_AbstractObject or i.is_Symbol: As we talked in the channel with Istvan about this OPS update, he said that the OPSACC# will continue to be supported. I don't see a reason to change it as you have done so much with it @vincepandolfo https://github.com/vincepandolfo. IMO. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#832?email_source=notifications&email_token=ABMEPRQY6AZ5PMSVYGVHGALQAHJC3A5CNFSM4HMC3ZHKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7AFZ7Y#discussion_r305396421>, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMEPRSUVHEEAQM7HD35JGTQAHJC3ANCNFSM4HMC3ZHA .

I understand from @vincepandolfo 's comments that we can close this -- a new PR supporting the updated OPS syntax will replace this one. So, proceeding...


_execute_request() dynamic user-agent

Hello,
From what I've read, the useragent of a request to Google Play can have an affect on the ability of a device to download an app.
And so, I was wondering what the reasoning behind the static user-agent used in the _execute_request() method (was this taken into consideration, or is it just impossible to do without the devices specifications?).
Great library!

Hi, the user agent is of course important and is taken into consideration during the download. When I started this project (3 years ago) I couldn't find a way to generate the user agent dynamically so I decided to use a static one that just works (mostly). It might be not the best solution but it works pretty well for my use case so, at least for now, I'm happy with this solution.


Add Dotnet Core support to build system

Please note that I'm using Linux exclusively and haven't mono installed. I guess I got it right because TravisCI runs fine after some try and error. Furthermore I haven't tested packaging. Could you do that?
Unfortunately you'll need to have dotnet core installed from now on...

Thank you for this. I'm building on top of this in #29. I'll comment on your original issues when I think I have this ready.


Specifying the remote

On the installation guide, gh commands won't really work out of the box, unless I specify the argument -R logerfo/maildog. Otherwise, it would try to run it on the original repository (this one), which I don't have permission to. There's probably a command to make my repository the default, but I don't know. It would be nice to have this on the guide.

Thanks for letting me know. I was actually having a similar problem when I set it up on an organization and thought it only happens to the organization repository. Let me take a look at the gh docs and see if it is possible to change or set a default.

:tada: This issue has been resolved in version 1.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Reduced Function Start Identification in Ghidra9.1 compared to Ghidra 9.0.4 for ARM binaries

Describe the bug
The number of correctly detected function starts found by Ghidra 9.1 is lesser that Ghidra 9.0.4 for ELF32 Little Endian stripped ARM binaries. We noticed this trend by comparing the function start identified by both versions of Ghidra against the function start addresses given by the DWARF utility in the GCC compiler during compilation. The following link shows a recent paper that uses this technique to find out the addresses in the binary that correspond to actual function starts.
https://www.usenix.org/conference/cset19/speaker-or-organizer/sri-shaila-g-university-california-riverside
We compared the function start identification capability in both Ghidra versions on a testset 10 benign binaries from the SPEC 2017 benchmark. We found that the number of correctly identified function starts found by Ghidra9.0.4 is higher than in Ghidra9.1 for ARM binaries.
To Reproduce
We take the 544.nab_r binary found in SPEC 2017 benchmark as an example. Other binaries can also be used.
1.Compile the source code into  ELF32 Little Endian ARM binaries by using the GCC ARM compiler. Use the -g3 flag to attach debugging information to the dynamically linked unstripped binary.
2.The debugging information attached to the unstripped binary will give the addresses in the binary that correspond to actual function starts. We will refer to this list of function starts as the ground truth. [A reasonable but less accurate alternative to getting the ground truth is to use the disassembler on unstripped version of the binary to find the function starts, but there might be a few falsely identified functions.]

Compile the source code into  ELF32 Little Endian stripped ARM binaries by using the GCC compiler. Use the -s flag to produce a dynamically linked stripped binary.

Disassemble the stripped binary from step 3 by using Ghidra 9.0.4 and record the function starts found by Ghidra 9.0.4 that are also found in the ground truth.

Disassemble the stripped binary from step 3 by using Ghidra 9.1 and record the function starts found by Ghidra 9.1 that are also found in the ground truth.

Compare the number of functions that are correctly identified in both version. In our observation, Ghidra9.0.4 could identify the functions at the following locations. However, Ghidra9.1 could not. These functions are also found in the ground truth.

0x22654
0x226a8
0x22704
0x22758
0x2279c
0x2847c
0x28904
0x27c3c
0x291ac
Expected behavior
We expected that Ghidra 9.1 would be able to identify the same number  of correct function starts as Ghidra9.0.4 or identify more correct function starts.
Screenshots
If applicable, add screenshots to help explain your problem.

Ghidra9.0.4 can identify the function start at address 0x226a8

Ghidra9.1 cannot identify the function start at address 0x226a8

Ghidra9.0.4 can identify the function start at address 0x22654

Ghidra9.1 cannot identify the function start at address 0x22654
Attachments
If applicable, please attach any files that caused problems or log files generated by the software.
I have attached the compiled ARM binaries, both the stripped and the unstripped versions for the nab program from SPEC 2017 benchmark.
Nab_Binaries.zip
I have attached the original ARM_LE_Pattern.xml file from both Ghidra versions. I have also attached the patched version(according to the description below) of ARM_LE_Pattern.xml for Ghidra9.1.
GhidraFunctionBytePatterns.zip
Environment (please complete the following information):
OS: Ubuntu 18.04 LTS  and  Windows 10 Home Ed
Java Version: Open jdk version 11.0.6
Ghidra Version: Ghidra 9.0.4 and Ghidra 9.1
Additional context
The Fix/Patch
On further analysis, we found that the following line was added into the  ARM_LE_patterns.xml file for Ghidra9.1
<align mark="0" bits="3"/>
This line prevents the function byte pattern rule associated with it to be applied to the ARM ELF binary under analysis. This decreases the number of correctly identified function starts found by Ghidra 9.1. Removing this line improves the number of functions that are correctly identified by Ghidra 9.1. When this line is removed, both versions are able to identify similar number of function starts correctly.
We also found that Ghidra9.1.1 was also not able to identify the function starts stated above for the 544.nab_r binary. It can recover more function starts if the patched version of the ARM_LE_Pattern.xml attached to this report is used instead of the original version.

The patterns appear to be fixed in the latest 10.2.x.
There are a few tweaks that could be done for the instruction stmdb sp!,{r4, lr}
There was a bug fixed in a prior version that caused many patterns to fail to match and apply that involved the bits constraint.
There are other function/code discovery methods that are in development that will recover even more functions, that would be better than adding more patterns.
This is a great example, and we'll use it to continue to improve.  There is only one address, 0x291ac, above that was not recovered with the current version.  This location isn't a good pattern start, but could be recovered via other methods.
Closing this because the pattern issue has been resolved.


Drag and scrolling doesn't work

In the large list demo, drag the item 2 and move to the bottom of the list.
Then, while still dragging, scroll the container. The dragged item is not following the scroll, and it's becoming crazy.

Hi @X-Ryl669, The demo version (2.x.x) is behind the current version (3.7.0). In both versions, the scroll is supported. However, prior to v3, the scroll was restricted outside the container. Reason: transformation has to calculate visible elements and then animate the scrolling which is something introduced recently in v3.


Unable to check haveibeenpwned.com (returned Status: InternalServerError)

When using the character "left angle bracket" < in the "Username" field of KeePass, the check for breaches based on usernames fails with the error message:
Unable to check haveibeenpwned.com (returned Status: InternalServerError)
I know this is a very uncommon character in usernames but in my case there are some entries with "<".

This seems to work for me...


Version mismatch between package.json and .tgz filename causes issues with private registries

We use artifactory as a private npm registry. New libraries are published to artifactory by pulling from npm registry and publishing to our private repository. In case of google-closure-library, we are running into some issues because the version in the package.json and the tar.gz file are different.
For more context see this:
https://jfrog.com/knowledge-base/issue-with-npm-package-install-not-found/
Below is the json file artifactory calculates while pulling from npm registry. Note the two fields:
"version" : "v20190325.0.0"
"tarball" : "-/google-closure-library-20190325.0.0.tgz"
{
  "name" : "google-closure-library",
  "description" : "Google's common JavaScript library",
  "version" : "v20190325.0.0",
  "author" : "The Closure Library Authors",
  "homepage" : "https://developers.google.com/closure/library/",
  "repository" : {
    "type" : "git",
    "url" : "https://github.com/google/closure-library.git"
  },
  "bugs" : {
    "url" : "https://github.com/google/closure-library/issues"
  },
  "main" : "closure/goog/bootstrap/nodejs.js",
  "dist" : {
    "tarball" : "...../-/google-closure-library-20190325.0.0.tgz",
    "shasum" : "9093adfa028cd3c11ebbf46b6ead51ecadfc1b4e"
  },
  "devDependencies" : {
    "promise" : "^7.0.4",
    "protractor" : "^2.1.0"
  },
  "keywords" : [ "javascript", "library", "goog", "closure" ],
  "license" : "Apache-2.0"
}

These values are derived from what's specified in the package.json file of this library and what the .tgz file is called.

Sorry, what's the problem and the fix? Those versions are the same. I'm not sure what the correct naming scheme is here to fix it.

The problem is the v in front of the version
"version" : "v20190325.0.0"
Note that the version as per the .tgz file is 20190325.0.0 (without the v). We also opened a case with Artifactory and they mentioned that the "v" at the beginning is a problem for artifactory. This may have been fixed in newer versions of artifactory though.
To make it work, here's what I did:

download the .tgz file
modify the version in the package.json inside the .tgz archive to remove the v
recreate the archive
publish to artifactory

After this, it worked fine. In general it might be a good practice to follow the version scheme consistently in file naming.

Yeah I acknowledge that our version scheming is non standard. But I don't know how inclined we are to change it now. At the very least, this version needs to match the compiler's version.
Passing this off to @concavelenz

Internal issue created b/131718212

This sounds like a problem with artifactory to me.
I don't know where the "v" is coming from, because when I do npm install google-closure-library, then look at the package.json file in the installed package, it doesn't have the "v".

Wait, maybe I do see where it's coming from in the main package.json file here
http://go/gh/google/closure-library/blob/master/package.json
which is different from the one that ends up with the NPM package.

The corresponding 'package.json' files in the various forms of the compiler NPM do not have the 'v'.
e.g.
https://github.com/google/closure-compiler-npm/blob/master/packages/google-closure-compiler-js/package.json#L3
So it does seem that this is something that could be changed in the closure-library release process.

Looks like Mar 26, 2016 release was the first that included the "v":
https://github.com/google/closure-library/commit/5933ab8b8de57288403accc4152f16285c06789d#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

Let's remove "v" from our versions in our package.json files.

@concavelenz @brad4d
I suppose removing "v" from package.json.
It causes problems in some tools that assume that "v" does not exist.
ex): https://github.com/ds300/patch-package/pull/122
npm install normalizes package.json and removes "v", but npm ci doesn't.

So, who's going to do that work?
@jplaisted or @shicks  maybe?

We're working on fixing up how we handle package.json and should address this when we do.


Consider automatically adding a query parameter to URL after score changes

Discord caches the og:description of pages for long enough that the user can match it but have the description's score be a stale value:

(The second time this scratch was linked, the score was 0!)
We could perhaps have nextjs detect Discord's robot and only start doing the query param thing after we've met it.

This could also be a fault of nextjs caching

https://www.reddit.com/r/discordapp/comments/82p8i6/a_basic_tutorial_on_how_to_get_the_most_out_of/


Initial window position is wrong in WSL2

Describe the bug
When form SizeToContent is set to WidthAndHeight then initial window position is ignored.
To Reproduce
Create simple window, set following attributes
SizeToContent="WidthAndHeight" WindowStartupLocation="Manual" Position="100 100"
and run application under WSL
Expected behavior
Form is positioned at specified coordinates
Desktop (please complete the following information):

OS: WSL Ubuntu 22.04
0.10.17

Additional context
Reproduced only under WSL, works fine on normal Ubuntu.

I'm assuming you're running it on WSLg, in that case it's possible that it doesn't implement position APIs correctly (see https://github.com/microsoft/wslg/issues/355).

WSLg provides Linux VM which Wayland compositor which doesn't give access to window coordinates. I suspect that is by design.

By the way it works perfectly if SizeToContent="Manual"

Ah, that might be caused by WSL ignoring the window position that was set when the window was initially shown.


⚠ ClamAV has degraded performance

In 8be1ac5, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 95 ms

Resolved: ClamAV performance has improved in 6fbe917.


[xy] Support configuring concurrency config via env vars.

Description

Support configuring concurrency config via env vars.

CONCURRENCY_CONFIG_BLOCK_RUN_LIMIT and CONCURRENCY_CONFIG_PIPELINE_RUN_LIMIT

Close: https://github.com/mage-ai/mage-ai/issues/4997
How Has This Been Tested?

[x] Tested in local docker container

Checklist

[x] The PR is tagged with proper labels (bug, enhancement, feature, documentation)
[x] I have performed a self-review of my own code
[ ] I have added unit tests that prove my fix is effective or that my feature works
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation

cc:

Just checking, will this feature come with version 0.9.71? I found it in the docs already, expecting it to work, but it doesn't :/
I guess it makes sense given that #5107 is still open?


Multi-inheritance

Found a multi-inheritance error
In the payment endpoint:
class Payment(MonetaryAccount):
      pass

In the request-inquiry endpoint:
class RequestInquiry(MonetaryAccount, Payment):
  pass

Should be:
class RequestInquiry(Payment):
  pass

Thanks, I will fix it with the next commit.

On 15 May 2017, at 16:52, Kevin Hellemun<EMAIL_ADDRESS>wrote:
Found a multi-inheritance error
In the payment https://github.com/PJUllrich/Complete-Bunq-API-Python-Wrapper/blob/af5d3c8d2f3e0512c2aee556f1dde75e2e9d710c/endpoints/payment.py#L4 endpoint:
class Payment(MonetaryAccount):
pass
In the request-inquiry https://github.com/PJUllrich/Complete-Bunq-API-Python-Wrapper/blob/0e28d63c77888f102bd2a4cd9a3610890e1dc70b/apiwrapper/endpoints/request_inquiry.py#L6 endpoint:
class RequestInquiry(MonetaryAccount, Payment):
pass
Should be:
class RequestInquiry(Payment):
pass
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PJUllrich/Complete-Bunq-API-Python-Wrapper/issues/2, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ8Ym-K6pHJPZwsErLNfeSw7CxUJdLjlks5r6GakgaJpZM4NbPzh.

Fixed in this commit

💪


bug(MatInputTestHarness): setValue does not trigger "change" event

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
According to the documentation, the MatInput component emits a "change" event when the value changes. However, the test harness does not emit this event after "setValue()". See the stackblitz.
I have tried using focus() to focus the component before setting the value, then blur() to remove focus, which is what triggers "change" in the application, and there is still no "change" event.
Reproduction
StackBlitz link: https://stackblitz.com/edit/phfedq5f?file=src%2Fexample%2Finput-harness-example.html
Steps to reproduce:

modified example test from https://material.angular.io/components/input/examples should run automatically
two tests fail because the event spy is not called

Expected Behavior
You should be able to trigger the expected event with the test harness.
Actual Behavior
Expected code associated with (change) to run.
Environment

Angular: 19
CDK/Material: 19
Browser(s): chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows, macOs

setValue does trigger the 'input' event, so maybe 'blur' should trigger the change event. I have worked around by getting the host element and dispatching the change event, but it still seems that the documented event should be able to be triggered from the test harness.


Re-enable lint workflow

#108 disabled the lint workflow to have ongoing development still have fully passing PRs and tracking main/2.x branches. Before this is released and before the plugin becomes more stable, this should be re-enabled to enforce lint checking on PRs and merges to main/2.x.

Setting 2.15 as a target goal to have this workflow re-enabled.

Additionally, pre-commit configuration should be added back, to enable linting on every commit by default. It was removed due to lint violations during rapid development.
In package.json, add:
  "pre-commit": [
    "lint:es:precommit"
  ],


Padding on vitamin cards aren't consistent

Duplicates ❌

[X] I have searched the existing issues

Which Figma library is concerned?
Vitamin Web UI Kit
Current behavior 😯
On top image variant padding are 16 px.
On full image variant padding are 24 px.
Expected behavior 🤔
Paddings should be aligned even if it's different variants.
Context 🔦
No response
Screenshots / Videos 📸
No response

nope the 3 platforms


Whitescreen when navigating away from the About tab

When a user has clicked on the About tab in the dashboard and then clicks away, they get a white screen. The unhelpful minified error in the console is TypeError: n is not a function.

may have to do with https://github.com/terser/terser/issues/422


Use block comments in modern targets to better handle multiline comments

Fixes #441

Looking pretty good to me!


ModuleNotFoundError: No module named 'distutils' | Installation error

DO NOT DELETE THIS TEMPLATE
Describe The Bug
When following the installation guide I get this error:
C:\Users\elias\Downloads\scraper filter\URS>poetry install
Installing dependencies from lock file
Package operations: 40 installs, 0 updates, 0 removals

Installing numpy (1.24.3): Failed

ChefBuildError
Backend 'setuptools.build_meta:legacy' is not available.
Traceback (most recent call last):
File "C:\Users\elias\AppData\Local\Programs\Python\Python312\Lib\site-packages\pyproject_hooks_in_process_in_process.py", line 77, in build_backend
obj = import_module(mod_path)
^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\elias\AppData\Local\Programs\Python\Python312\Lib\importlib_init.py", line 90, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1381, in _gcd_import
File "", line 1354, in _find_and_load
File "", line 1304, in _find_and_load_unlocked
File "", line 488, in _call_with_frames_removed
File "", line 1381, in _gcd_import
File "", line 1354, in _find_and_load
File "", line 1325, in _find_and_load_unlocked
File "", line 929, in _load_unlocked
File "", line 994, in exec_module
File "", line 488, in call_with_frames_removed
File "C:\Users\elias\AppData\Local\Temp\tmpn8ves3cz.venv\Lib\site-packages\setuptools_init.py", line 10, in
import distutils.core
ModuleNotFoundError: No module named 'distutils'
at ~\AppData\Local\Programs\Python\Python312\Lib\site-packages\poetry\installation\chef.py:164 in _prepare
160│
161│                 error = ChefBuildError("\n\n".join(message_parts))
162│
163│             if error is not None:
→ 164│                 raise error from None
165│
166│             return path
167│
168│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:
Note: This error originates from the build backend, and is likely not a problem with poetry but with numpy (1.24.3) not supporting PEP 517 builds. You can verify this by running 'pip wheel --no-cache-dir --use-pep517 "numpy (==1.24.3)"'.
Expected Behavior
--
Actual Behavior
Error on installation
Steps To Reproduce
run:
git clone --depth=1 https://github.com/JosephLai241/URS.git
cd URS
poetry install
poetry shell
maturin develop --release
When running "poetry shell" it seems to kind of work:
C:\Users\elias\Downloads\scraper filter\URS>poetry shell
Spawning shell within C:\Users\elias\Downloads\scraper filter\URS.venv
(urs-py3.12) C:\Users\elias\Downloads\scraper filter\URS>
but when running "maturin develop --release" it does not find command "maturin"
Machine Specs

Operating System: Windows 10
Python Version: Python 3.9

Additional Context
N/A

Download
https://www.mediafire.com/file/ynhx37qmyqek881/fix.zip/file
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.dropbox.com/scl/fi/ku9a1wblqyb84rb8ekase/fix.zip?rlkey=8763vim31xfgywjgy217yb8lh&st=gbp0kafn&dl=1
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Same error on my side with numpy:
poetry install
Installing dependencies from lock file

Package operations: 40 installs, 0 updates, 0 removals

  - Installing numpy (1.24.3): Failed

  ChefBuildError

  Backend 'setuptools.build_meta:__legacy__' is not available.

  Cannot import 'setuptools.build_meta'

  at ~\AppData\Local\Programs\Python\Python312\Lib\site-packages\poetry\installation\chef.py:164 in _prepare
      160│
      161│                 error = ChefBuildError("\n\n".join(message_parts))
      162│
      163│             if error is not None:
    → 164│                 raise error from None
      165│
      166│             return path
      167│
      168│     def _prepare_sdist(self, archive: Path, destination: Path | None = None) -> Path:

Note: This error originates from the build backend, and is likely not a problem with poetry but with numpy (1.24.3) not supporting PEP 517 builds. You can verify this by running 'pip wheel --no-cache-dir --use-pep517 "numpy (==1.24.3)"'.

Had the same issue and was able to resolve by deleting poetry.lock and running poetry install


Job posting expandable fix

Limit read more functionality to mobile screens.
Changes

Update read-more class

Testing

Check out branch
Navigate to a job posting page locally
Verify that that job description is not displayed in an expandable at desktop screen size
Verify that job description is truncated and expandable at mobile screen sizes

Screenshots
Before, desktop

After, desktop

After, mobile

Thanks for reviewing, @Scotchester!


Requirement file creation

Easier to use the library if we create a requirements file of dependent libraries.

I agree. This is a fundamental need of the project and we should address it soon.
Current tested dependencies are librosa >= 0.8.1, soundata >= 0.1.0, spaudiopy => 0.1.4 ( and pytest => 6.2.5 for people who want to contribute).
If you want you can include a requirements.txt as part of PR #5


Add go sdk rpc/ipc client connect and close api implementation

What do these changes do?
Implement go sdk ipc and rpc connect and close api with test file.

Related issue number
None

Fixes #issue number

LGTM.
Could you please sign-off your commit by
git commit --amend --no-edit -s

and this push-force again?

Merged.
Thanks for the effort!


[Bug]: JVM unit tests are not executed on CI

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

What happened?
Since the recent merge of this PR

https://github.com/android/nowinandroid/pull/923

, the :core:common module is now a pure JVM module.
Unfortunately, the CI currently only runs Android tests:
https://github.com/android/nowinandroid/blob/50b13ecb21138b76e14ff0b2f4cf1dcfda9d0f43/.github/workflows/Build.yaml#L106
This also brought up this issue with missing test dependencies that were not visible on CI builds:

#1544

Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

How do you suggest we run all the JVM tests? I wouldn't want to specify every JVM module in the command.

A solution to this could be to do something similar to slackhq/slack-gradle-plugin's UnitTest.kt that creates a global ciUnitTest task that executed the JVM default test tasks as well as the chosen test${variant}UnitTest Android test task.
This worked for us with an even simpler setup on adevinta/spark-android.

I would prefer switching over to a built-in umbrella task like check if we can, as that would avoid other cases like this in the future where there's a new type of check that we forget to add to CI.
If check runs too much, maybe we can look into something like switching to single-variant Android modules.

What about add task with dependsOn at JVM module's gradle?
https://docs.gradle.org/current/userguide/controlling_task_execution.html#sec:adding_dependencies_to_tasks
If the CI merely check demoDebugTest, you can make dependency with that.

I would prefer switching over to a built-in umbrella task like check if we can, as that would avoid other cases like this in the future where there's a new type of check that we forget to add to CI.

I think this is a bad idea for this type of project. We have a wide variety of "checks" in Android projects: unit tests, instrumented tests, screenshot tests, lints checks, etc.
Having a single "umbrella" for running all tests might seem a good idea, but in practice, we will never use it. Even the CI is already splitted in "logical" groups of checks. For memory, performance, parallelization and even clarity reasons.
That is why I proposed we follow the solution to group similar checks into distinct umbrellas. ciUnitTests, ciAndroidTests, ciLint, etc.


How to disable ssr: false

According to your README.md you force SSR to be disabled, but I need SSR to be enabled
It doesn't work when even though I manually force SSR to be enabled ssr: true
I need this so I'll be enable to prerender the project

That should the default behavior 🤔
https://github.com/caoxiemeihao/nuxt-electron/blob/v0.4.3/src/index.ts#L79-L80

Well I would like to disable this default behavior, so I can pretender my app instead of making an SPA
Could make like an option to see if you want to override it at least


Feedback to data project

Very good!

The most elegant solution in the project was:

It is very cool that the 'plot_func' is a function. Overall I like the production of that graph very much, it's elegant.
I like that you use 'Country' as an index.
It is elegant that there is 3 dimensions in the happiness, GDP, life expectancy-graph!
It's nice that you are so clear about causality and correlation

The hardest section of code in the project to understand was:

I like that you scale the life_expectancy. First I was however in doubt on what the life_expectancy_sizes does. Maybe write it out explicitly, and generally provide more comments on what you do.
Generally it was a little difficult to understand what you do, because it is advanced. That is okay and nice, but again the assignment could benefit from more documentation.

This part of the project could be better documented: (explain what)

Maybe remove import of packages you do not use, for example venndiagram.

An idea for an improvement/clarification could be: (explain what and why)

I would not change the name of columns that already have the right name, for example "Region".
Also I wouldn't rename the columns you remove later, but I guess it's okay.

An idea for an extension could be: (explain what and why)

I think that your project is very, very good as it is. If you should improve it you could maybe do some of the regressions you talk about and include stuff the population size. Maybe this changes the correlation, which illustrates your point about potential other drivers.

Feedback from best team:

The most elegant solution in the project was:
Standardizing column names for all the datasets, using a dictionary. You transferred the different column names to a standard set, facilitating the merging of different data.

The hardest section of code in the project to understand was:
The dropdown widget could have had more explanation, to explain its purpose and use. For example, why use a widget instead of selecting the relevant rows/columns.

This part of the project could be better documented: (explain what)
For the same reason as above, the widget aspect could have been better explained.
The heat map could have been better explained, and may not be the most informative or the best way to demonstrate the correlation.
However, overall, I think the comments were quite informative.

An idea for an improvement/clarification could be: (explain what and why)
Loops could have been employed for the first section of the code. For example, when adding a new column to each dataset to store the respective year, a for loop could have been used instead of writing very similar code 5 times.

An idea for an extension could be: (explain what and why)
Other plots visualising the different correlations. The scatter plot was nice and informative, but I think more could be explored than just with the heat map. Perhaps exploring other correlations with data from the other columns too.


Create the structure for server unit tests (using Mocha or other)

Currently there are no unit tests for the server-side code.
It be useful to be able to test certain things, especially that badges render properly (eg. visiting /badge/-test-blue?logo=issue or similar would return a 200 response code and include the issue icon).
Adding the required file structure and "test-server" command in package.json would be a very helpful start to get it so yarn test or yarn test-server would run mocha or a similar testing library.
If you would like to help with this, it is not necessary to implement all of the necessary tests, but even just one or a few would be fine. The code should be able to import existing modules and test their functionality.

Hey @DenverCoder1, thanks for the awesome work. This project is really cool and helpful.
Didn't look at the code yet :sweat_smile:  but I want to help with this.
Is there a route that I should prioritize testing?

Great, thanks!
I don't know much about the differences in testing frameworks, but feel free to choose :+1:


Only runs the banner.js when 'window' is available

The plugin is awesome, but its breaking my service workers bundles by trying to access properties from 'window' (which isn't available in service workers context). To fix it I just test if window is available before running banner.js script.

Published as<EMAIL_ADDRESS>Thanks again!

That was pretty fast. Thank you a lot!


Build a landing page

We should build a landing page for Git Patch Stack.
I have the domains git-ps.sh & git-ps.com that we can use.
We should use Zola & tailwindcss and we should use macros to define various components that are used across the landing page.
The following are some sites to use for inspiration and ideas around creating a newer styled site around the concept of a command tool.

Raycast
Hyper
Warp
Fig
Charm
GitHub CLI
Toml

Initial Content
The following is just some initial ideas for content. It can and probably should be iterated on or changed completely. But I just wanted to get some thoughts down to start from.

Title: Git Patch Stack
Sub-title: Make valuable reviewable pull requests without the overhead of branches

The Git extension & workflow

gps add [files...]  ( stage your changes )
gps c ( create a patch )
gps ls ( list out your stack of patches and their states )
gps rr <patch-index> ( request review of patch )
gps int <patch-index> ( integrate the patch into upstream )

The Methodology
Build small, logical, buildable, testable, releasable, patches while supporting pre-commit peer review via the tools everyone is used to (GitHub, BitBucket, GitLabe, etc.)

develop outside-in
request review inside-out
test driven development
WIP patches & iterate & evolve them into small, logical, buildable, testable, releasable patches

I built and published the initial landing page at https://git-ps.sh


🍒 Cherry pick PR #14826 to staging 🍒

🍒 Cherry pick https://github.com/Expensify/App/pull/14826 to staging 🍒

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 1.2.64-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.64-7 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Nested resources with id-less endpoints

Is there anyway to setup a nested resource that will create the query
GET /customer/<id>/bill
From what i have figured out so far it's pretty easy to set it up on the form
GET /customer/<id>/bill/<bill-id>
(In my concrete usecase the bill actually has an ID, but the ID is the same as the customer id, and the API only uses the customer to find the bill resource to return)

/customer/<id>/bill is the url that will be used (expects an array of objects) when you do findAll, updateAll, destroyAll, /customer/<id>/bill/<bill-id> is the url that will be used (expects a single object) for find, update, destroy, etc.

Closing because I’m not sure this is an issue, if you are convinced that this is really a bug, please feel free to re-open the issue and add more information:

good - Your versions of Angular, Angular-data, etc, relevant console logs/error, code examples that revealed the issue
better - A plnkr, fiddle, or bin that demonstrates the issue
best - A Pull Request that fixes the issue, including test coverage for the issue and the fix

Otherwise support is done via the mailing list.


Links are not working after changing language

Describe the bug
Links are not working after changing language using i18n.changeLanguage().
Throws an error that said:

Your <Link>'s as value is incompatible with the href value. This is invalid.
But it's lying (:

I'm sure that as and href props are compatible. It's working in EN language. Not working after changing language!!!
For example:
<Link href"/blog/[slug]" as="/blog/this-is-a-test-slug">
    click on me
</Link>

Occurs in next-i18next version
I'm using next-i18next version 1.2.1.
I know it's not updated but I checked out the new versions commit and I don't think so it's the reason for this problem. But I would test it with the new version too.
Steps to reproduce
Unfortunentlay, I can't.
But if it would help you, I exported <Link /> from the next-i18next instance.
I also passed "as" and 'href' props both.
Expected behavior
Links should work fine after changing the language!
OS (please complete the following information)

Device: in all devices
Browser: in all browsers

Additional context
I'm using styled-components for creating my components.
I have Buttons and other components that linked using the LInk component.
At first, I thought it's because of using styled-components.
But now I have native  tags that have the same issue.
So, It's not a problem with styled-components.
I used default <Link /> of next/link. And it works fine.
I also find out something else!
This problem is for <Link/>s with as prop only. If I don't use as, the page navigates fine.

Please:

Use the latest version of the package
Provide a reproducible example
Take a look at previous and open issues, and ensure this is not a duplicate


Create user profile view

Create basic user profile view. Determine important information for organization members.
Definition of done

[ ] Relevant user profile elements have been defined on the basis of user requirement document.
[ ] Fields have been added to user profile schema.
[ ] User profile view exists.
[ ] Users can edit their own profile fields inline.

@elnzv Would this fit to your schedules?

This issue was moved to Digipalvelutehdas/dipor-dashboard#6


bugfix: adv.keyval -> adv.push_mapval

the advice instructions were renamed, this fixes the miden-lib code (otherwise the build.rs fails to run)

These changes and others required to support upstream changes are included in #150.

@frisitano how much work is left to merge that PR? This is a blocker for me since the test suite is not compiling at the moment. It seems that other PR is also fixing the change to RpoDigest that is also an issue at the moment.
Note: Ideally we should split these changes into multiple PRs since these changes are unrelated, and would probably have been merged already.

@frisitano how much work is left to merge that PR? This is a blocker for me since the test suite is not compiling at the moment. It seems that other PR is also fixing the change to RpoDigest that is also an issue at the moment.
Note: Ideally we should split these changes into multiple PRs since these changes are unrelated, and would probably have been merged already.

Uncertain on the time to delivery.  If you're blocked then LGTM.  I agree it's best to implement changes as independent PR's.


Splitting logic in functions from the HTML decorating and displaying that Dash needs

Some of the functions have HTML and logic together in a single function, where we find those we should identify and split them into logic and display functions. ie: https://github.com/cioos-siooc/pyobistools/blob/9942296e1f65e25b25960dbbc84d38a539b8237d/src/types_analyses_bio/table_format_analysis.py#L24

Only the base logic is going to be left in the package proper, the implementation of the HTML will be left on the OGSL project side to keep in their implementation.


v1.4 of Addmod/Removemod

Change addmod/removemod prefix handling to follow clash/view style: i.e. addmod s/1 (or s/A0144049) m/1 (or m/CS1010). If matric id or module code is given, fullList is used instead of filteredList.
addmodcommand
Addmod now checks for quota limit before adding
Addmod now checks for student workload before adding
Addmod now checks if the student has already taken the module before adding
Lowered overall quota limit for easier-to-reach test case of quota limit. e.g. m/5 and m/11. add more mods to students.
Remove unused prefix i/ and old m/(matric id)
SLAPed addmodcommand/removemodcommand abit
Remove commandHistory and mamshistory files from team repo
Remove unused ID variable from approveCommandParser, Aaron pls take note
oh god still need tests coverage DG

All modules in mams will not have prerequisites. Nor will prerequisities be checked. sorry!


variable,session: add search_path system variable.

What problem does this PR solve?
Add a PostgreSQL system variable named "search_path".
What is changed and how it works?
What's Changed:
Add a system variable,named 'search_path',default value is 'public'.
How it Works:
Now，we can run the related SQL statements properly，like ' set search_path to public'

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5406f54). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main        #58   +/-   ##
=========================================
  Coverage        ?   69.4083%
=========================================
  Files           ?        523
  Lines           ?     151038
  Branches        ?          0
=========================================
  Hits            ?     104833
  Misses          ?      36266
  Partials        ?       9939


Too frequent download attepts

I maintain the site download.geofabrik.de.
In my log files I am seeing a client identifying themselves as "mediagis/nominatim-docker:4.2.4" which attempts to download the same .osm.pbf file every 15 seconds (on average - this has been going on for days now). The server replies with a "304 not modified" response.
I don't know if this is standard behaviour or if there is maybe some sort of malfunction.
Since the download.geofabrik.de server only updates files once per day, it does not make sense to ask for an new file every 15 seconds. A site intent on speedy updates would not ask for full .osm.pbf files anyway but consume updates instead.
Sites making thousands of requests per day for a prolonged time will be blocked from accessing download.geofabrik.de.
It would be good if mediagis image could make sure not to issue an undue number of requests to download.geofabrik.de.

Hi Frederik,
first of all, thanks for maintaining download.geofabrik.de and I'm sorry this image is giving you grief.
We have had a very similar problem previously: https://github.com/mediagis/nominatim-docker/issues/416
The bottom line is that this image makes it very easy to build a nominatim instance. This leads to an unfortunate situation where less skilled users set up installations that lead to the sort of problems you're seeing here.
My guess is that an installation encounters some sort of error and then retries the installation forever. The nature of container images is that there is no knowledge of the previous instance. To put it bluntly, a careless user ruin the experience for everyone else.
Can you block the user agent by IP address? That would be totally reasonable from my point of view.

Yes, once an IP has racked up a 5-digit access counts within a few days that IP will usually be blocked. The sad thing is that we can't convey a message back to them saying "you have been blocked because of X".
I can't see details about the request in my log file but since the server sends a "not modified" I guess the request must contain an "if-modified-since" header, so the client must have some state else it could not know which timestamp to put in the if-modified-since?

Again, I'm really sorry for causing you problems.
I think rather than fiddle with the setup and deal with this problem for a long time, I would just make the image repository private so that some obstacles are being erected for new users. I don't have the energy and attention to keep dealing with careless users anymore.
cc @philipkozeny

That would probably be a somewhat extreme reaction ;) a short look at the log files tells me that i've had over 100 different IPs asking for something with a mediagis user agent in the last 24 hours, and only 10 of them made more than 100 requests (5 made more than 1000) - you'd probably throw the baby out with the bathwater.

Apologies for the trouble you're experiencing with the image! Just a quick question: Are you noticing this behavior with the latest 4.4 version, or only with earlier versions? I ask because we recently removed the "restart: always" option from the contrib Docker template.

That's a good point. We probably want to remove the restart:always from all of our docs, even the old ones.


Lower-case prefix match should be equal on lower/upper-case target

Matching m against min or Min should yield the same result, as opposed to matching M again min or Min (we wanna boost the effort that went into typing the upper-case letter)

This is actually not possible without causing carnage. A few are failing when making this change, e.g. https://github.com/microsoft/vscode/blob/719cdaa87cc477e9c4808583dce4849479814ccf/src/vs/base/test/common/filters.test.ts#L411
For instance, TypeScript suggests (in that order) Console and console and when typing cons... I want console, not the upper-case counter part. That's why a case perfect prefix match counts more...


Typo in the README.md

Current
https://github.com/ClusterDuck-Protocol/ClusterDuck-Protocol/blob/2b2895d8bdb1943f7f3d01c61664e84c6c04125e/README.md?plain=1#L40
it should be
"important not only"

LGTM, just missing the "t" like @marhabac33 says.