fix invalid link to StackExchange.Redis docs

the path is case sensitive

@Ne4to : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@MikeWasson: I'm sorry - only the author of this article, @dragon119, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

I'm the content manager for this content. OK to merge.


Add a setting to enable the using the Accent Color for the titlebar

Summary of the new feature/enhancement
My feature request is the following: Currently, there is this huge tab at the left of window Title:
https://i.imgur.com/NkCGn3f.jpg but the problem here is, that I am using an accent color that overwrites the title bar for every application.
So I wanted to ask if it would be possible to give us a feature, that we can change that the color of the title bar on the left to the other color, or at least a feature that it automatically gets the same color as the accent color.
Thanks for reviewing.

I'm changing the title to be slightly more specific.
After #929 we stopped using the accent color, and started drawing the entire titlebar ourselves.
#1934 made the appearance of the titlebar better, but still doesn't use the accent color.
We'll need some way of setting the resources at runtime to override the Background property of the TitlebarControl (introduced in #1948).
This is also related to #1625.

Any way ColorTool can help with this too? At some point, it may be better to merge Terminal and ColorTool together and use ColorTool for the colors and Terminal settings for applying them based on what's configured in the Settings UI (alternatively the json). I don't think too much rework would be needed here as the functionality would remain but the commands used for executing would be altered. While ColorTool can remain useful on it's own, anybody who can will probably use the Windows Terminal, especially once it reaches v1.

Are you able to query the registry to see if that setting is turned on?

Are you able to query the registry to see if that setting is turned on?

This could be done by accessing the registry key HKEY_CURRENT_USER\Software\Microsoft\Windows\DWM\ColorPrevalence
public Color ThemeColor
{
    get
    {
        var regBaseKey = RegistryKey.OpenBaseKey(RegistryHive.CurrentUser, RegistryView.Registry64);
        var regKey = regBaseKey.OpenSubKey(@"Software\Microsoft\Windows\DWM", RegistryKeyPermissionCheck.ReadSubTree);
        if  (regKey != null)
        {
            var value = regKey.GetValue("ColorPrevalence");
            if (value != null && Convert.ToBoolean(value))
            {
                value = regKey.GetValue("ColorizationColor");
                if (value != null) {
                    var color = (uint)(int)value;

                    return Color.FromArgb(
                        (byte)((0xFF000000 & color) >> 24),
                        (byte)((0x00FF0000 & color) >> 16),
                        (byte)((0x0000FF00 & color) >> 8),
                        (byte)((0x000000FF & color) >> 0));
                }
            }
        }

        // This is the default Windows 10 colorization color
        return Color.FromArgb(0xFF, 0x00, 0x78, 0xD7);
    }
}

I'm interested in taking a shot at a fix for this one. Would make sense to incorporate this into the existing requestedTheme setting (for example, adding darkAccent or lightAccent themes), or introduce an independent setting?
By default we'd want to follow the system setting, I'm hoping there's an API to read the setting in a more elegant way than digging through the registry.

As an update to this thread - this is going to be addressed in a future update as a part of #3327. We're working on a spec currently, but that feature should address this issue in a more unified way with other similar feature requests.

should this even be a setting? it should just be on when the windows setting is on

@Poopooracoocoo Yea, I'd still like this to be an independent setting. As a part of #3327, we're going to let people put whatever color they want there (not just their accent color), or match the color to the color in the terminal control, or throw Acrylic up there, or Mica, or whatever. Much more flexible than just the accent color.

@Poopooracoocoo Yea, I'd still like this to be an independent setting. As a part of #3327, we're going to let people put whatever color they want there (not just their accent color), or match the color to the color in the terminal control, or throw Acrylic up there, or Mica, or whatever. Much more flexible than just the accent color.

With the colour picking, it would be neat to allow assigning the Accent Colour to various elements, like the cursor or selected background.  Obviously when it comes to the theming, then that allows all kinds of possibilities.

Is this really fixed?  The color is influenced by the theme (light or dark), but I don't see the accent color being used, or any settings that reference it.

Yep! If you declare a new theme whose tabRow.backgroundColor is "accent", you'll get this:

    "theme": "Cool Things",
    "themes":
    [
        {
            "name": "Cool Things",
            "tab":
            {
                "background": "terminalBackground"
            },
            "tabRow":
            {
                "background": "accent"
            }
        }
    ],

(We should look at offering more inbox themes.)

I was disappointed when I installed Terminal Preview and saw that this wasn't enabled when the Windows setting is enabled. Is there an issue for tracking respecting the system preference?


[0.6.3] Event not raising when deleting a Folder

Node 0.11
node-webkit 0.9.2
gaze 0.6.3
Ubuntu 14.04
After subscribing to the changed, added, deleted and renamed events, No event is fired when I delete a folder.
Here's my code:
var Gaze = require('gaze').Gaze;
var gaze = new Gaze('**/*', { cwd: (process.env.HOME || process.env.HOMEPATH || process.env.USERPROFILE) + '/MyFolder' }, function(err, watcher) {
    if (err) {
        console.log(err);
    } else {
        // On file changed
        this.on('changed', function(filepath) {
            console.log(filepath + ' was changed');
        });

        // On file added
        this.on('added', function(filepath) {
            console.log(filepath + ' was added');
        });

        // On file deleted
        this.on('deleted', function(filepath) {
            console.log(filepath + ' was deleted');
        });

        // On renamed
        this.on('renamed', function(oldPath, newPath) {
            console.log(oldPath + ' was renamed to ' + newPath);
        });
    }
});

I also see this.
In addition, often I get Gaze totally crashing when this happens on Linux:
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: watch ENOENT
  at exports._errnoException (util.js:746:11)
  at FSWatcher.start (fs.js:1172:11)
  at Object.fs.watch (fs.js:1198:11)
  at Gaze._watchDir (/projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:289:30)
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:358:10
  at iterate (/projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/helper.js:52:5)
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/helper.js:61:11
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:420:5
  at iterate (/projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/helper.js:52:5)
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/helper.js:61:11
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:420:5
  at iterate (/projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/helper.js:52:5)
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/helper.js:61:11
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:420:5
  at iterate (/projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/helper.js:52:5)
  at Object.forEachSeries (/projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/helper.js:66:3)
  at Gaze._initWatched (/projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:354:10)
  at Gaze._internalAdd (/projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:193:10)
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:400:16
  at Array.forEach (native)
  at /projects/b89f55a7-1345-453f-a45e-9de87b5213c0/dropbox/node_modules/gaze/lib/gaze.js:396:12
  at FSReqWrap.oncomplete (fs.js:95:15)

I'm on gaze 0.5.1 (the current published version), Ubuntu 15.04, kernel 3.19.0-16-generic.


Alternative to using componentWillReact with setState?

Is there an alternative to using componentWillReact with setState?
We just updated to the latest version of this package and componentWillReact now gets run on setState too, so we end up getting into an infinite loop.
Is there an easy way around this? Or a way to avoid this?

Can you describe your use case / problem?
Op di 5 dec. 2017 om 20:24 schreef Eliezer<EMAIL_ADDRESS>
Is there an alternative to using componentWillReact with setState?
We just updated to the latest version of this package and
componentWillReact now gets run on setState too, so we end up getting into
an infinite loop.
Is there an easy way around this? Or a way to avoid this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mobxjs/mobx-react/issues/371, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhI7uJIuwHmxi5AHSP7HXd2FMHNp8ks5s9Zh4gaJpZM4Q209o
.

We're updating the mobx store with a list of players and then setting it as the state for a container component in order to render the list of these players in the child component.
The code got a little messy trying to hack our way around not using Apollo Client for hundreds of documents since it had performance issues.
This is legacy code I'm not fully familiar with however.

I see Date.now() is being set as a state item, so that's going to lead to an infinite loop very easily

Figured out a solution for now. The code continues to look incredibly hacky. I just avoid setting state when it hasn't changed.

I also ran into this problem.
When I run setState in componentWillReact  , It will get into a infinite loop.


Thread safety issue

Hi there, and thanks for building this gem. It's great to have something in native Ruby that's fully compatible with the JS version!
It seems that the gem isn't currently thread-safe. Specifically, mutating the constant Matching::RANKED_DICTIONARIES in https://github.com/formigarafa/zxcvbn-rb/blob/024828e89f89b2a103f43203e3dd768a0d10ac79/lib/zxcvbn/matching.rb#L198-L202 which is called from https://github.com/formigarafa/zxcvbn-rb/blob/master/lib/zxcvbn.rb#L21 can result in RANKED_DICTIONARIES containing data for a different thread if 2 threads call zxcvbn in parallel.
This is only an issue when the user_inputs argument to Zxcvbn.zxcvbn() is used. When it's always the default value of [], then it won't matter.
I'm guessing this comes from the original JS code, which isn't concerned about multi-thread access while running in a browser.
My first thought would be to rework parts of Matching to no longer be a singleton, so that @user_inputs could be stored separately per caller. Alternatively, the call to Zxcvbn.zxcvbn() itself can be wrapped with a Mutex (which is also a viable workaround for the existing gem version).

Yes, you are correct.
This is a behaviour inherited from the original source code.
On server side this starts to become a concern on the very rare case you have many user registrations to validate in parallel.
I saw some valid reasons to have it also working on login but at this stage the password already exists and in general there is no much more than username to be used. In which case user_inputs just can't add much.
Other people use the tool to score generated passwords, again, no use for user_input.
I thought about tackling this from several angles:
Using a disposable tester instance like zxcvbn-ruby have available.
Or make it more functional style where every execution would have it's own immutable scope.
The mutex option I dismissed, because the lock would need to be held while until the execution of the function has finished and the function can be very slow depending on the password.
I also agree with you that only parts of Maching module is affected but I take this further only RANKED_DICTIONARIES['user_inputs'] is affected.
It should not be very difficult to pass the result of build_ranked_dict(user_inputs) around where it is needed.


Update README.md

I forgot to update a detail in the README in #95. This PR fixes that.

Thanks for your attention to details.


Unable to build on Debian Testing due to libpoco not finding PCRE

Cmake complained that it could not find PCREConfig.cmake or pcre-config.cmake, from the libpoco installed on the system.
Fixed with
 cmake -DENABLE_INTERNAL_POCO=TRUE
Did not find anything referencing this on a couple of searches, so I am posting this here for future reference :)

There is either a libpcre-dev to install or the debian package of libpoco-dev might be missing files.
This isnt a library that Pothos build cares about per say, its just pulling in PocoConfig.cmake and trying to use it. And I guess PocoConfig.cmake is looking for something that isnt there.


Can not debug (or publish) a 4.7.2 Web App after upgrade

I've worked my way through the build problems I had updating our existing .net framework web app to the new SDK style. However, I can't debug it or successfully run it in Azure after a publish. So I created a web project from the built in template and was able to reproduce the same issue. I know that going from 4.7.2 to 8, for instance,  with a project that uses System.Web is perilous and there is a warning message to that effect, but I would have expected an in-place upgrade to work?
Microsoft Visual Studio Enterprise 2022 (64-bit) - Current
Version 17.10.1
.Net Upgrade Assistant version 0.5.617.36348
Create a new Asp.Net Web Application (not Core) targeting .net 4.7.2, selecting "Single Page Application"

Debug the application, using the default IIS Express profile.
Everything works fine.
"Upgrade project features" using .Net Upgrade Assistant
info: C:\Users\TimBertalot\source\repos\WebApplication1\WebApplication1\WebApplication1.csproj contains a reference to System.Web, which is not supported on .NET Core. You may have significant work ahead of you to fully port this project.
info: 'C:\Users<user>\source\repos\WebApplication1\WebApplication1\WebApplication1.csproj' is a legacy web project and/or references System.Web. Legacy Web projects and System.Web are unsupported on .NET Core. You will need to rewrite your application or find a way to not depend on System.Web to convert this project.
Reopen the solution
Attempt to recompile, it fails.
Add assembly reference to System.Web.Routing and System.Web
Add missing nuget packages:
Microsoft.AspNet.Web.Optimization
Microsoft.AspNet.Identity.EntityFramework
Microsoft.AspNet.Identity.Owin
Microsoft.Owin.Host.SystemWeb
Try to compile again, and now it fails because the upgrade has erroneously switched it to an Exe output from Library.
Switch the output back to Library
Project now compiles without any problems.
Try to launch the debugger and get "Unable to run your project" presumably because its trying to run an exe

Attempt to add a IIS Express debug profile, setting an app url like http://localhost:12345
Same error about RunCommand

d


Crash When Disabling TouchPose

I'm working on a demo app where I want the user to be able to enable/disable Touchpose. To enable/disable Touchpose I call
((QTouchposeApplication *)[UIApplication sharedApplication]).alwaysShowTouches = isShowingTaps;
((QTouchposeApplication *)[UIApplication sharedApplication]).showTouches = isShowingTaps;

where isShowingTaps is a BOOL.
When disabling Touchpose I get a crash in QTouchposeFingerView:removeFromSuperview inside the call to super. This is called from setShowTouches:
The only way I could fix this was to move the animation from QTouchposeFingerView:removeFromSuperview to QApplication:UpdateTouches, and remove the QTouchposeFingerView:removeFromSuperview override.
Like this
           if (fingerView != NULL)
            {
                // Remove the touch from the
                CFDictionaryRemoveValue(_touchDictionary, (__bridge const void *)(touch));
// The fingerView override of removeFromSuperview crashes when turning off showTouches
// after it was already on. Moving the animation here fixes the problem.
               [UIView animateWithDuration:_touchEndAnimationDuration animations:^{
                    fingerView.alpha = 0.0f;
                    fingerView.layer.transform = _touchEndTransform;
                } completion:^(BOOL completed){
                    [fingerView removeFromSuperview];
                }];
            }

bump. I'm getting the same issue.

@toddreed Thank you for the library!
I've also experienced this crash: https://stackoverflow.com/questions/67689067/can-we-check-if-an-objc-object-was-deallocated-before-bridging-it-from-void-t
Have you considered changing CFDictionary to NSMapTable (in the develop branch)?

@gatamar: I created a new issue (#22) for this, as I think it’s an unrelated crash. I pushed a commit (525ce7ba2ce42cde2c31a8a66d0e547d11f97c42) to develop that should fix this (that is #22). Please try it out and let me know if that resolves your crash.


eslint-config-airbnb-base: where should we use it?

This repo has dependency on eslint-config-airbnb-base, but it is used only for examples packages:

here
here
and here

I wonder if it's intentional or just leftovers from previous chores that can be cleaned.
I also wonder if we should unify the linting across the repo (both examples and core packages)

[x] This only affects the JavaScript OpenTelemetry library
[ ] This may affect other libraries, but I would like to get opinions here first

I believe they are just leftovers and can be cleaned up.
For unifying linter rules across repos, I'd find adopting a mature linter rule package would be a maintainable way. Or we'd have to sync the rules across the repos every time we changed it. I recall that we previously used gts for a while but moved away from it (https://github.com/open-telemetry/opentelemetry-js/pull/2204, I think prettier is the one to blame for breaking changes in semver minor).


print things

Coverage remained the same at 100.0% when pulling 2cdac515c204de62d87fb54b3dfd86da35015700 on testcallbacks into 799b6daa673276187f99b4735018af664d2fa35c on master.


Zchase/castehaste/seo plos

This PR contains page-level optimizations for sections within Pulumi Docs (i.e. Intro to Pulumi, Tutorials, Support, etc) as part of on-page SEO efforts to improve DX on organic search.
Original: https://github.com/pulumi/pulumi-hugo/pull/2207

im assuming folks already know, but just in case. these changes impact the docs navigation, and im not totally sure if that is what we want.


SQL generation and Export as SQL use wrong notation for hstore type (PostgreSQL).

While I Use SQL generation or Export and the table or result set contains hstore type the dbvear generate the following code {key1=value 1, key2=value 2}. The right code have to look like "key1"=>"value 1", "key2"="value 2".

Already fixed.
Ticket closed.


1.x Fix AWS meta data refresh

AWS meta data updates were ignored, which for Discovery servers themselves resulted in an infinite loop of EIP binding, and registry clear/upload sequences. This in turn caused massive expiries, and large network traffic.

NetflixOSS » eureka » eureka-pull-requests #533 SUCCESS
This pull request looks good


chore(deps): update dependency @types/react to v16.9.52

This PR contains the following updates:

Package
Type
Update
Change

@types/react
devDependencies
patch
16.9.51 -> 16.9.52

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 6.1.3 :tada:
The release is available on:

v6.1.3
GitHub release

Your semantic-release bot :package::rocket:


Opinionated formatting

I really like having automatic formatting done by my editor and enforced by CI. It lets me type a disaster of unformatted code then press a button and have it all look nice in an instant (and also know that my mess is syntactically correct if it can be formatted). prettier is a very common choice for this. Formatting tooling like this can be a touchy subject, though, so if it's your preference not to go that route that's ok.

prettier is a good tool and probably should be used in collaborative/open-source projects for many reasons which I'm sure you know about so we should add it.
Me personally, I never liked prettier in my projects. The combination of how opionated it is and very few configuration options available always annoyed me lol. I always find it can make my code look very strange and unreadble as I see writing code as more of an art we're you write code that people can understand just by looking at it.
I have a config I will install to keep my formatting the same but you're welcome to add an Apollo one for consistency.

Closed with latest commit - Prettier added.


upgrade to the latest cattle

@cjellick @ibuildthecloud
I'm testing this change with my local gms to make sure everything works all right. Please don't merge yet.

gms works well with these changes.

The docker daemon is not running.
The command  docker version returns a non-zero exit status if the docker client cannot reach the docker daemon.
That is stopping the entire ci process.

Shoot. Its because the build didnt have privileged turned on

LGTM


Simple note post

I don't know if this is a bug or feature request, but using the share sheet from a plain text "file" in Drafts (5) I am not offered a simple "note" or "article" post.
And I wish I was.

Definitely this is something I want to add. In the same vein I want to be able to share a Ulysses markdown sheet and have it be the note’s content

A nice fancy feature would be to notice if the first line is a # Heading and extract it as a name. (Making the post an "article".)

Haha that’s actually exactly what I want to do (because I write all my articles in Ulysses and it always starts with that!


AB#5118

Proposed changes

Related issues

Checklist

[x] I consider the submitted work as finished
[x] I tested the code for its functionality
[ ] I wrote test cases for the relevant uses case
[ ] I added/update the relevant documentation (either on github or on notion)
[ ] Where necessary I refactored code to improve the overall quality

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Looks good with the local build, @r-joyce please review and merge.

Merging this at request of @CyberDaedalus00. As well as 5121.


Grandpa validate non-overlapping pending changes

The grandpa runtime is expected to return any new authority set changes while there is a pending one. The grandpa AuthoritySet should validate this when importing changes after #1808. The check should also be done across standard and forced changes #1619.

@andresilva do you plan on closing this in the next 48 hours?

if you do, please move back to 1.1


Tweaks for narrow mode

Narrow mode is now pretty good, but there were a few leftover
cases where the text ran off past the right edge. Fix those cases.
Signed-off-by: David A. Wheeler<EMAIL_ADDRESS>

@nmegill - this is all about formatting - ok to merge?

OK to merge.


Scrape vim-plug managed plugins

Includes @morhetz's commit from #62. Fixes #41.
I've tested this on my own personal dotfiles, which use Plug and it seems to work well.

This will need some additional code in tools/scrape/build_github_index.py.

LGTM! Merge away.

@divad12 Updated the DB schema, added a migration and added the field to the index task.
Tested fully this time:

Note: we should create a new DB dump after we merge this.

Awesome!
Did you forget to add the migration script to this PR? :)

@divad12 Yes. Yes I did. (re)updated.

@jonafato thanks for the fly-by review, awesome catches!
I'm clearly too oblivious about my own code to be reviewing ...

@jonafato Great catches. Thanks for the review. I'll update.

I've updated this PR with a number of fixes and tests to exercise the code I've changed.
Review @jonafato?

:+1: Looks good to me.


Update richmarker.js

Sometimes is necessary to stop the propagation. For example if there are a click listener bind to the map and you dont want to trigger when the marker is clicked.

done! :)

Ok, google, it's time to merge pull request FFS!
(╯°□°）╯︵ ┻━┻

Thank you!)

It looks like the minified source code was never updated to include this change. I was using the minified version and trying to figure out why it wasn't passing the event.
FYI since y'all are not maintaining any releases, which means people are downloaded the src directly, then you should recompile the minified version every time you make a change.


DLPack Conversion API

(do not merge yet)
cc @tqchen

Thanks @eqy ! this is merged

@wkcn Thanks for pointing this out, that line should be changed to
pycapsule = ctypes.cast(pycapsule, ctypes.py_object), can you send a PR?

cc @eqy

https://github.com/dmlc/tvm/pull/1589 should fix the problem

Yes. #1589 has fixed the problem :-)


Fix push() and pop() ignoring some styles

push() and pop() ignores several important style definitions, including noStroke or noFill, now as they are controlled directly in the library instead of by ctx. While the two functions only do ctx.save() and restore().
p5 web editor example - before, after
This PR is not ready to be merged yet, mainly because the result I got here is different from the one shown on the q5 demo page, and I don't know why. Also, I'm not sure if it's just a design choice. There are also several other things to do if there's actually a need for this PR -

[x] test
[ ] minify
[ ] bump version?

Another minor change in the second commit is that I changed $.frameCount++ to ++$.frameCount as the latter is slightly faster.

Hi @peilingjiang,
Thanks a lot for the PR! Sounds good. I'll be happy to merge it when it's ready.
I totally forgot about those additional styles not remembered by ctx.save/restore. Thanks for helping with this!
For minification, I was doing it by manually copy-pasting to https://javascript-minifier.com/, the reason being that it seems libs like uglify etc. either doesn't produce correct result or doesn't compress as much ¯\(ツ)/¯ I'm also ok with doing that myself after the PR, along with version bumping, which I guess would be appropriate too.
Feel free to let me know when the PR is ready, thanks!

Hi @LingDong-, I've minified the file and pushed this new commit. It should be ready to merge now. Could you handle the version bump and release? Thank you!

thanks a lot!
I've bumped the version and published


Add just constructor

I've found myself doing new Observable.fromIterable(<int>[1]) a few times now, and realized I miss the new Observable.just(1) constructor from other Rx implementations. I know it's a simple change, but one that might be nice to have :)
Would you be open to this PR which adds the just constructor from the ReactiveX spec? http://reactivex.io/documentation/operators/just.html
Thanks!

Sure thing! Just pushed a test up. The factory doesn't contain much logic itself as it defers that to other methods, so lemme know if that's enough coverage or if there's more you'd like tested.


Input Validation for Request Parameters

The req.param function lacks strict input validation for parameter names and default values. This makes the application susceptible to various attacks, including SQL injection and XSS. To enhance security, we should implement strict input validation using the validator library.
Changes Proposed:

Use the validator library to validate and sanitize user inputs for parameter names and default values.
Throw a TypeError if an invalid parameter name or default value is detected.

Yes, there are many validator libraries you can use with express to suit your specific validation neeeds.
You may have opened this issue again the wrong repo and this is the express framework, and not an application that would be implementing some validation lib.

If you are looking for help on what lib you want to use in your app, feel free to post over in our discussion board https://github.com/expressjs/express/discussions

req.params should not be sanitized by Express. It should be just properly handled by the developer depending on the planned usage.
How do you know what the developer using Express wants to do with the received values? Different sanitization methods are required for different use cases (paths, data used in HTML, DB queries, etc.) and it would be easy to miss something. What if raw data is necessary (e.g. because it will be used in a safe way)?

Thank you for your valuable feedback. While I appreciate the concern, the proposed modifications to req.param aim to enhance security by incorporating validation for alphanumeric values. However, it's essential to note that Express deliberately avoids sanitizing req.params directly, as this allows developers to exercise greater control over the sanitization process based on their specific use cases. Different contexts may demand distinct sanitization methods (e.g., paths, HTML, or database queries), and enforcing a universal approach could inadvertently limit flexibility. By presenting raw data, Express empowers developers to make informed decisions about validation and modification tailored to their application's unique requirements. It's crucial to strike a balance between security measures and flexibility to accommodate diverse development scenarios effectively.


docker client cant connect to swarm SSL

Hi,
Followed the below link to create docker and swarm in SSL:
http://www.blackfinsecurity.com/docker-swarm-with-tls-authentication/
I started swarm with the following options:
docker run -d -v /opt/swarm/setup/certs/:/opt/swarm/setup/certs/ swarm manage --tlsverify --tlscacert=/opt/swarm/setup/certs/ca_public.pem --tlscert=/opt/swarm/setup/certs/server_cert.pem --tlskey=/opt/swarm/setup/certs/server_private.pem -H tcp://<IP_ADDRESS>:2376 token://11d27820fe3a27f954981f06d3a902fe
the swarm is running fine in TLS:
[root@iwfvm07195 ~]# ps -ef | grep swarm
root     20674 20551  0 00:20 pts/0    00:00:00 grep --color=auto swarm
root     59446 59240  0 Jan13 ?        00:00:22 /swarm join --addr=iwxxxxx88.hpxxwlxb.net:2376 token://ff5a8fc30c0b4e5ebf097ae8cdc5e9b8
root     59524 59240  0 Jan13 ?        00:00:22 /swarm join --addr=iwfxxxx85.hpexxxxab.net:2376 token://ff5a8fc30c0b4e5ebf097ae8cdc5e9b8
root     60326 59240  0 Jan13 ?        00:00:18 /swarm manage --tlsverify --tlscacert=/opt/certs/ca.pem --tlscert=/opt/certs/swarmCRT.pem --tlskey=/opt/certs/swarmKEY.pem -H tcp://<IP_ADDRESS>:2376 token://ff5a8fc30c0b4e5ebf097ae8cdc5e9b8
But when I try to access thro windows docker client I get:
C:\docker\cert>docker --tlsverify --tlscacert=ca.pem --tlscert=localCRT.pem --tl
skey=localKEY.pem -H=iwxxxxx95.hpxxxxxb.net:2376 version
Client:
Version:      1.9.1
API version:  1.21
Go version:   go1.4.3
Git commit:   a34a1d5
Built:        Fri Nov 20 17:56:04 UTC 2015
OS/Arch:      windows/amd64
An error occurred trying to connect: Get https://iwxxxxx95.hpxxxxxb.net:2376/v1
.21/version: dial tcp 16.999.99.999:2376: ConnectEx tcp: No connection could be
made because the target machine actively refused it.
What would be the exact command to connect to SWARM SSL?
The connection to DOCKER SSL with the above command is working perfect.

Any help on the above query?

Hello Team,
Now I am able to run swarm in SSL:
docker run -d -v /opt/certs/:/opt/certs/ -p 2374:2375 swarm manage --tlsverify --tlscacert=/opt/certs/ca.pem --tlscert=/opt/certs/swarmCRT.pem --tlskey=/opt/certs/swarmKEY.pem token://538090ef551832330937303d3d465661
But from the docker client it cant identify any dockers added to it:
C:\docker\cert>docker --tlsverify --tlscacert=ca.pem --tlscert=localCRT.pem --tlskey=localKEY.pem -H=iwfvm07195.hpeswlab.net:2374 info
Containers: 0
Images: 0
Role: primary
Strategy: spread
Filters: health, port, dependency, affinity, constraint
Nodes: 0
CPUs: 0
Total Memory: 0 B
Name: 4d6ddfb56372
The number of nodes is zero. Is there anyway to debug this?

Hi,
I am able to run the swarm in SSL:
docker run -d -v /opt/certs/:/opt/certs/ -p 2374:2375 swarm manage --tlsverify --tlscacert=/opt/certs/ca.pem --tlscert=/opt/certs/swarmCRT.pem --tlskey=/opt/certs/swarmKEY.pem token://538090ef551832330937303d3d465661
but it still cant it identify the docker nodes added to it:
C:\docker\cert>docker --tlsverify --tlscacert=ca.pem --tlscert=localCRT.pem --tlskey=localKEY.pem -H=ixxxxxxx5.hpeswlab.net:2374 info
Containers: 0
Images: 0
Role: primary
Strategy: spread
Filters: health, port, dependency, affinity, constraint
Nodes: 0
CPUs: 0
Total Memory: 0 B
Name: 4d6ddfb56372
The number of nodes is zero. Is there any way to debug this?
Thanks

When you start manage with TLS certs, if mean that you need to use TLS in the docker cli to connect to swarm, you did that.
but it also mean swarm will use TLS to connect to the nodes themselves
Did you setup TLS on you nodes ?

Hello Vieux,
Thank you very much for the response.
Yes the nodes are also configured in TLS.
However when I remove TLS from SWARM, I can get the node info even though the nodes are still running in TLS.
The command I use when swarm is not in TLS is: (from docker client on my laptop)
docker -H=ixxxxxxx5.hpeswlab.net:2374 info
This gives me the node info correctly. To repeat, here the nodes are in TLS but swarm is not in TLS (still port 2374).
Any suggestions appreciated.
Regards

Hello,
I re-created certificates with a common CA cert. Now swarm is able to pull docker info in TLS.
Please consider this thread closed.

@bluishpe thanks for the update.


Combined API attributes

A change to capture the latest attributes available through the API.
I've also fixed some warnings related to existing code and mix.lock was modified (updated) in the process of the development.

Thanks for your contribution! It's merged and will be available on hex soon.


catch focus on tab menu reader when is closed

this PR allow to find back the focus in reader when we closed settings and navigation menu
fixes #336

Hello, does this fix this issue too?
https://github.com/readium/readium-desktop/issues/335

Regarding issue #335, I can now confirm that the bug persists:

However I tried your PR and it seems to work really well (I tested hybrid mouse / keyboard interaction in order to hit potential edge cases, but it all seems solid).

Thank you for also addressing #335. Now I am wondering:
Both the ReaderMenu and ReaderOptions menus (which are composed from ReaderHeader) are built with SideMenu, which is itself built with AccessibleMenu. The same dependency chain exists for Menu -> MenuContent -> AccesibleMenu. The difference is that with the latter, this.props.focusMenuButton is passed along the chain of React components, whereas with the former, it isn't. This PR is creating ad-hoc logic to handle the "re-focusing" on the calling site for the popup / slide-out menus (i.e. buttons), but shouldn't we instead leverage the existing framework feature this.props.focusMenuButton? The only existing concrete implementation of this function is:
https://github.com/readium/readium-desktop/blob/23a0b6438f78e3096f6fb808cf46a64127e771f2/src/renderer/components/utils/menu/Menu.tsx#L124-L128
...would a similar approach work as a replacement for the ad-hoc solution in this PR?
If so, we could avoid duplicating logic, and instead re-use existing building blocks.


[vcpkg baseline][c-ares] Add unsupported uwp platform

Failed on: https://dev.azure.com/vcpkg/public/_build/results?buildId=105429&view=results
 error C4013: 'UnregisterWait' undefined; assuming extern returning int
 error C4013: 'NotifyIpInterfaceChange' undefined; assuming extern returning int

The UnregisterWait and NotifyIpInterfaceChange functions are Win32 system functions and are not defined under UWP. Therefore, adding them does not support the UWP platform.

[X] Changes comply with the maintainer guide.
[ ] SHA512s are updated for each updated download.
[ ] The "supports" clause reflects platforms that may be fixed by this new version.
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Usage test pass with following triplets:
x64-windows
x64-windows-static

@jimwang118 you should also change curl ci test, and move c-ares, to be platform: "!uwp"

I merged this to unblock https://github.com/microsoft/vcpkg/pull/40203 . Thanks for the fix!

I notified upstream: https://github.com/c-ares/c-ares/pull/785#issuecomment-2264041813

Fixed in https://github.com/c-ares/c-ares/commit/3fd5925adf20c258b4d7b21009e81cab4d3326f3
Should be in the c-ares 1.33.0 release due out probably next week.


Smoke Test: Text inside suggestions is not highlighted (Windows)

We always try to compute highlights based on the label first and then fallback to the filterText.
It seems that the JSON mode always replaces the leading quote character meaning the label differs the portion we filter against. Since we only match against the filterText we can't really compute highlight for the other string (label)

@aeschli Insight why JSON replaces the quote? Do you have ideas how else this should work?

The string literal starts with the quote and I just always replace from the start of the token. If it were replaced by a number, boolean, null or what ever, it's what needs to be replaced (not in this example, obviously).
I understand that the replaced string is not a prefix of the the label, but there are substrings matches. Don't we highlight these as well?

related to #11423