Tutorials: Code User Guide

The goal Hedera wants is so someone has access to the Guide
Tomorrow Shawn to go through in Scrum and let the Dev Team we need them for this.
(Daniel) Write up Intro + (Andreas) Write up a Glossary (BOTH EPICS).
(Dev Team Member) Records the Video Without Voiceover Clearly, just the different steps. Andreas then needs to look at that video and Create a script from that
Andreas to provide Daniel Script and What to Say.
Daniel then needs to do the voiceover for the video based on the Script
Daniel needs to create the Markdown File for the Repo
Andreas will put the code into the Markdown File that is used in the Code Video (NOT the UI Video).

Next step is on Andrey to translate from Russian to English.


Removes the flag MODEL_FACTORY_INJECTIONS

Removing this flag due to warning
This flag is needless for project with ember-cli >= 2.13
https://emberjs.com/deprecations/v2.x/#toc_id-ember-metal-model_factory_injections

Thank ylu!


ERROR: Unable to resolve dependency for ':react-native-paypal@debug/compileClasspath'

Hi
I'm getting this issue on trying to install the library on android.

Here is my main build.gradle
`// Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript {
ext {
buildToolsVersion = "28.0.3"
minSdkVersion = 21
compileSdkVersion = 28
targetSdkVersion = 28
supportLibVersion = "28.0.0"
}
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.3.1'
classpath 'com.google.gms:google-services:4.2.0'
// NOTE: Do not place your application dependencies here; they belong
// in the individual moduxle build.gradle files
}
}
allprojects {
repositories {
mavenLocal()
google()
jcenter()
maven {
// All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
url "$rootDir/../node_modules/react-native/android"
}
maven { url 'https://maven.google.com' }
maven { url "https://www.jitpack.io" }
}
}
`
My app dependencies:
"dependencies": {
"react": "16.8.3",
"react-native": "0.59.9",
"react-native-paypal": "^3.1.1"
}
Can you help me out on this ?
Thanks

@mighty-nyaina
You should try and check the example app to see differences from your files
https://github.com/smarkets/react-native-paypal/blob/master/paypalExample/android/build.gradle
https://github.com/smarkets/react-native-paypal/blob/master/paypalExample/package.json
A couple of things to check:

Your react native version is over a year old and it might be worth updating
Your gradle build tools is out of date as well.  you may need to bump it

I would start with the build tools because that will be an easier fix

Try out my suggestions and tag me if you're still seeing issues and I can reopen


When you set Referer in headers, you don't see Referer in the request header in Network Console

          @captainbrosset Now it works, but when you set Referer in headers, you don't see Referer in the request header.

Originally posted by @Victor-Chow in https://github.com/MicrosoftEdge/DevTools/issues/268#issuecomment-2404270160

Windows 11 22631.4037
Edge 129.0.2792.79

The first image is the original request, the second image is request by "Edit and Resend", obviously no referer.

@vidorteg to help take a look

Network Console in Edge DevTools works by issuing a fetch request on behalf of the page being inspected. As a result of this, it is not possible to set the Referer header, because that header is not respected as per the fetch spec.


Major version 3 & 4 not working (Rails / Webpacker 6)

packages.json
{
  "name": "kawab-v3",
  "private": true,
  "dependencies": {
    "@fortawesome/fontawesome-free": "^5.15.2",
    "@popperjs/core": "^2.6.0",
    "@rails/actioncable": "^6.0.0",
    "@rails/activestorage": "^6.0.0",
    "@rails/ujs": "^6.0.0",
    "@rails/webpacker": "6.0.0-beta.7",
    "@stripe/stripe-js": "^1.13.1",
    "axios": "^0.21.1",
    "bootstrap": "^5.0.0",
    "css-loader": "^5.1.1",
    "css-minimizer-webpack-plugin": "^3.0.0",
    "flex-gap-polyfill": "2.0.0",
    "mini-css-extract-plugin": "^1.3.9",
    "postcss": "^8.2.7",
    "postcss-flexbugs-fixes": "^5.0.2",
    "postcss-import": "^14.0.0",
    "postcss-loader": "^5.1.0",
    "postcss-preset-env": "^6.7.0",
    "sass": "^1.32.8",
    "sass-loader": "^11.0.0",
    "webpack": "^5.11.0",
    "webpack-cli": "^4.2.0"
  },
  "version": "0.1.0",
  "devDependencies": {
    "@webpack-cli/serve": "^1.3.0",
    "webpack-dev-server": "^3.11.2"
  },
  "babel": {
    "presets": [
<EMAIL_ADDRESS>    ]
  },
  "browserslist": [
    "defaults"
  ]
}

postcss.config.js
module.exports = {
  plugins: [
    require('postcss-import'),
    require('flex-gap-polyfill'),
    require('postcss-flexbugs-fixes'),
    require('postcss-preset-env')({
      autoprefixer: {
        flexbox: 'no-2009'
      },
      stage: 3
    }),
  ]
}

Upgrading to version 3 or 4 breaks compilation: "flex-gap-polyfill": "^4.0.0"
Error
[Webpacker] Compiling...
[Webpacker] Compilation failed:
assets by chunk 1.62 MiB (id hint: vendors)
  asset js/vendors-node_modules_fortawesome_fontawesome-free_js_all_js-node_modules_rails_activestorage_-a4abd5-4cd3d3c143f71678446e.js 1.55 MiB [emitted] [immutable] (id hint: vendors) 1 related asset
  asset js/vendors-node_modules_babel_runtime_regenerator_index_js-node_modules_stripe_stripe-js_dist_st-990793-411db816232e667b7f04.js 80.7 KiB [emitted] [immutable] (id hint: vendors) 1 related asset
asset js/website-6698940e1ebf8fabc153.js 12.8 KiB [emitted] [immutable] (name: website) 1 related asset
asset js/runtime-6ac31981503f92501d2d.js 6.89 KiB [emitted] [immutable] (name: runtime) 1 related asset
asset js/admin-227c5e031914f0c4eed2.js 5.66 KiB [emitted] [immutable] (name: admin) 1 related asset
asset manifest.json 2.33 KiB [emitted]
Entrypoint admin 1.56 MiB (1.56 MiB) = js/runtime-6ac31981503f92501d2d.js 6.89 KiB js/vendors-node_modules_fortawesome_fontawesome-free_js_all_js-node_modules_rails_activestorage_-a4abd5-4cd3d3c143f71678446e.js 1.55 MiB js/admin-227c5e031914f0c4eed2.js 5.66 KiB 3 auxiliary assets
Entrypoint website 1.64 MiB (1.65 MiB) = js/runtime-6ac31981503f92501d2d.js 6.89 KiB js/vendors-node_modules_fortawesome_fontawesome-free_js_all_js-node_modules_rails_activestorage_-a4abd5-4cd3d3c143f71678446e.js 1.55 MiB js/vendors-node_modules_babel_runtime_regenerator_index_js-node_modules_stripe_stripe-js_dist_st-990793-411db816232e667b7f04.js 80.7 KiB js/website-6698940e1ebf8fabc153.js 12.8 KiB 4 auxiliary assets
runtime modules 3.6 KiB 7 modules
modules by path ./node_modules/ 1.53 MiB
  modules by path ./node_modules/@popperjs/core/lib/ 73.2 KiB 58 modules
  modules by path ./node_modules/axios/ 41.3 KiB 27 modules
  modules by path ./node_modules/@rails/ 60.2 KiB
<EMAIL_ADDRESS>27.6 KiB [built] [code generated]
<EMAIL_ADDRESS>32.6 KiB [built] [code generated]
  5 modules
modules by path ./app/packs/ 7.74 KiB
  modules by path ./app/packs/src/ 7.02 KiB
    modules by path ./app/packs/src/website/javascripts/ 6.45 KiB 5 modules
    modules by path ./app/packs/src/admin/javascripts/ 588 bytes 3 modules
  modules by path ./app/packs/entrypoints/ 736 bytes
    modules by path ./app/packs/entrypoints/*.js 658 bytes 2 modules
    modules with errors 78 bytes [errors] 2 modules

ERROR in ./app/packs/entrypoints/admin.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
TypeError: postcssValuesParser.parse is not a function
    at /Users/james/Projects/KawabV3/app/packs/entrypoints/admin.scss:6731:1
    at /Users/james/Projects/KawabV3/node_modules/flex-gap-polyfill/dist/index.js:326:33
    at Array.forEach (<anonymous>)
    at rewriteMargin (/Users/james/Projects/KawabV3/node_modules/flex-gap-polyfill/dist/index.js:308:16)
    at /Users/james/Projects/KawabV3/node_modules/flex-gap-polyfill/dist/index.js:609:13
    at /Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:115:18
    at /Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:74:18
    at Root.each (/Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:60:16)
    at Root.walk (/Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:71:17)
    at Root.walkRules (/Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:113:19)
    at Object.Once (/Users/james/Projects/KawabV3/node_modules/flex-gap-polyfill/dist/index.js:541:12)
    at processResult (/Users/james/Projects/KawabV3/node_modules/webpack/lib/NormalModule.js:703:19)
    at /Users/james/Projects/KawabV3/node_modules/webpack/lib/NormalModule.js:809:5
    at /Users/james/Projects/KawabV3/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /Users/james/Projects/KawabV3/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/Users/james/Projects/KawabV3/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at Object.loader (/Users/james/Projects/KawabV3/node_modules/postcss-loader/dist/index.js:96:7)

ERROR in ./app/packs/entrypoints/website.scss
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
TypeError: postcssValuesParser.parse is not a function
    at /Users/james/Projects/KawabV3/app/packs/entrypoints/website.scss:6605:1
    at /Users/james/Projects/KawabV3/node_modules/flex-gap-polyfill/dist/index.js:326:33
    at Array.forEach (<anonymous>)
    at rewriteMargin (/Users/james/Projects/KawabV3/node_modules/flex-gap-polyfill/dist/index.js:308:16)
    at /Users/james/Projects/KawabV3/node_modules/flex-gap-polyfill/dist/index.js:609:13
    at /Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:115:18
    at /Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:74:18
    at Root.each (/Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:60:16)
    at Root.walk (/Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:71:17)
    at Root.walkRules (/Users/james/Projects/KawabV3/node_modules/postcss/lib/container.js:113:19)
    at Object.Once (/Users/james/Projects/KawabV3/node_modules/flex-gap-polyfill/dist/index.js:541:12)
    at processResult (/Users/james/Projects/KawabV3/node_modules/webpack/lib/NormalModule.js:703:19)
    at /Users/james/Projects/KawabV3/node_modules/webpack/lib/NormalModule.js:809:5
    at /Users/james/Projects/KawabV3/node_modules/loader-runner/lib/LoaderRunner.js:399:11
    at /Users/james/Projects/KawabV3/node_modules/loader-runner/lib/LoaderRunner.js:251:18
    at context.callback (/Users/james/Projects/KawabV3/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at Object.loader (/Users/james/Projects/KawabV3/node_modules/postcss-loader/dist/index.js:96:7)

2 ERRORS in child compilations (Use 'stats.children: true' resp. '--stats-children' for more details)
webpack 5.38.1 compiled with 4 errors in 4588 ms

Thanks for flagging this.
I think this is an issue with a module dependency.
Could you try manually installing postcss-values-parser:
npm install postcss-values-parser

For some reason, it seems to have moved it to a peer dependency in the later releases.

Closing for now, feel free to comment if you still experience the issue.


Implement enum attributes

This PR closes #383 by by adding a new tagged enum variant, EnumItem, that contains the name of the EnumItem as well as its value, and implementing the attributes reader/writer against the specification at rojo.dom.space.
Additionally, it adds a codec to rbx_dom_lua to handle the new EnumItem variant.
It also updates some docs, since the link that's currently there doesn't work anymore.
I went back and forth on what the fields should be named in the serde representation, and settled on type and value. This more or less mirrors EnumItem.EnumType and EnumItem.Value on Roblox - but maybe type should be enumType instead?

Realized immediately after I hit approve that this needs a changelog entry... 😅

Is just the rbx_dom_weak changelog okay?

...I was more thinking an rbx_types changelog entry.

Oh god, I'm losing the plot!


add ontology/module category

The set of ontologies should be split up into more sections:

Core modules
Supplementary modules
Reused ontologies
Use-case ontologies

Note that this re-organization is not change the namespace of the ontologies.

*Note:  231-add-ontologymodule-category should not be merged into dev as is. Use only build.py, dev-build.py, index.hbs, and docs/style.css. Then reorganize the ontologies into the appropriate structure.


Package cannot find necessary dependencies

The ToDoServer in this package no longer builds, not finding dependencies:
KituraNet and KituraTemplateEngine.
Please see attached end Swift build output.
KituraKit build output.txt
I am dependent on this example in starting a new project and do not know how to resolve this myself.
All help much appreciated.
Kind regards, André Hartman, Belgium

@ahartman What OS and which version of swift are you using?
It looks like this isn't a clean project either. Have you tried deleting your Package.resolved and recompiling?

Dear sandmman,
The project was a clean clone of
KituraKit build output.txt
KituraKit build output.txt
GitHub; I did it again as you can see in attached build output.
I am using OS 10.13.3 and Swift 4.1 (Apple Swift version 4.1-dev (LLVM 1c8b50929b, Clang 420ae40df6, Swift 4ebcde867a)
Kind regards, André Hartman

@ahartman May I suggest switching to Swift 4.0.3 as Swift 4.1 isn't yet out and entirely supported just yet.
If you'd like to do this via Xcode, head over to the menu bar at the top, Xcode > Toolchains > and select a previous Swift version, preferably Swift 4.0.3, which you could download here if you haven't got it. This should help resolve most of the issues regarding deprecations.

Sorry to trouble you on this again.
I followed your advice, went back to 4.0.3, problem persists.
'Kitura' /Users/gebruiker/Desktop/iOSSampleKituraKit-master/ToDoServer/.build/checkouts/Kitura.git-6522211175291160341: error: product dependency 'KituraNet' not found
'Kitura' /Users/gebruiker/Desktop/iOSSampleKituraKit-master/ToDoServer/.build/checkouts/Kitura.git-6522211175291160341: error: product dependency 'KituraTemplateEngine' not found
Could this be a writing error in Package.swift?
I find references on Internet to KituraNet as well as Kitura-Net, the same for KituraTemplateEngine.
Kind regards, André Hartman

@ahartman Could you paste here what your Package.swift file looks like please? There may have been a mismatch or typo in that file where it cannot find KituraNet and KituraTemplateEngine.

Seeing same problem. Simply cloned this repo, followed instructions in readme and get the errors when running swift build from command line under ToDoServer folder

no longer using kitura


Authentication

Description
As a teammate I want to authenticate myself in order to access to the app content
Proposal
Use an existing authentication provider like Google, Apple, Microsoft

Decisions
No GAFAM will be used for authentication
We will implement a home made authentication process
We will use a JWT authorization token in the Authorization header


test/20241115_2121

:no_entry: Snyk checks have failed. 2 issues have been found so far.

Icon
Severity
Issues

Critical
0

High
1

Medium
1

Low
0

:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)
:no_entry: code/snyk check is complete. 2 issues have been found. (View Details)


(Android) enableGPS does not attempt to enable GPS due to incorrect isGPSEnabled check

enableGPS uses the check
if (!this.isGPSEnabled())

to determine whether we need to prompt the user to enable location services on the device. isGPSEnabled however returns a Promise, meaning the non-awaited returned value is always truthy, and therefore enableGPS will never actually actually prompt the user to enable location services, even if the promise returned by isGPSEnabled resolves to false
https://github.com/nativescript-community/ble/blob/9820235506bea2bd27e82bc994cc512f6821b859/src/ble/index.android.ts#L1277-L1300
A simple solution would be to make the promise constructor callback async and adjust the condition to:
if (!(await this.isGPSEnabled()))

The check after receiving the request result from the system on line 1287 also needs to be corrected
https://github.com/nativescript-community/ble/blob/9820235506bea2bd27e82bc994cc512f6821b859/src/ble/index.android.ts#L1287

@delaneyb thanks for this. Tbh i dont use that part of the plugin. I always use the perms plugin and move the logic in the app. The reason is that the logic is constantly changing and getting more complex as new os versions are released
I even think of removing that part and let the user handles it with the perms plugin.
However if you want to make a PR to fix all this I would gladly merge it


add: swagger add token

pass swagger request api

@rmzf9192 Hi, please associate the issue and describe why you want to do that.

Codecov Report

Merging #11569 (1ad7c57) into dev (1c15a7d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev   #11569      +/-   ##
============================================
+ Coverage     39.67%   39.69%   +0.02%
+ Complexity     4696     4695       -1
============================================
  Files           993      993
  Lines         37695    37692       -3
  Branches       4199     4191       -8
============================================
+ Hits          14954    14961       +7
+ Misses        21173    21162      -11
- Partials       1568     1569       +1

Impacted Files
Coverage Δ

...phinscheduler/api/configuration/SwaggerConfig.java
100.00% <100.00%> (ø)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...erver/master/processor/queue/TaskEventService.java
75.00% <0.00%> (-5.36%)
:arrow_down:

...pache/dolphinscheduler/common/utils/DateUtils.java
74.37% <0.00%> (-0.63%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...eduler/api/service/impl/DataSourceServiceImpl.java
27.90% <0.00%> (ø)

...cheduler/server/master/utils/DependentExecute.java
0.00% <0.00%> (ø)

.../dolphinscheduler/plugin/task/datax/DataxTask.java
0.00% <0.00%> (ø)

...phinscheduler/plugin/task/chunjun/ChunJunTask.java
0.00% <0.00%> (ø)

...cheduler/plugin/task/api/ShellCommandExecutor.java
0.00% <0.00%> (ø)

... and 7 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

i want to know why you want to do that

hi, thanks for your first contribution.
Is there an issue to describe the problem that this PR will solve?


Patched UriResolver for PHP 8 compatibility.

We don't have time allotted for the larger rewrite that's needed to support JsonSchema beyond version 2. As such, we need to find a way work with the older JsonSchema code and PHP 8 - this patch is just that.
The 2.x tag/branch is roughly 5 years old and unlikely to change. As well, the LS config tool may see a much larger rewrite in the not too distant future. For these reasons, I believe this is the best solution.

I'm going to merge for now and I'll respond to feedback if needed.

I'm going to merge for now and I'll respond to feedback if needed.


Maestral is idle but won't allow me to set excluded items

Describe the bug
I used Dropbox now I switched back to Maestral.
I set the folder to the previous Dropbox folder and merged.
However I forgot to select some folders and now they are in "selective sync conflict".
Maestral is now idle, when when I try to select the folders I forget, it won't let me:

To Reproduce
As above
Expected behaviour
Maestral should sync the new folders
System:

Maestral version: 1.4.8
Python version: 3.9.6
OS: [e.g. Ubuntu] Fedora 34 Workstation
Desktop environment: [e.g. Gnome 3.32] GNOME 40.4.0
PyQt version (for Linux GUI): 5.15.4

Hm, there could be rare instances where the status appears to idle but the sync lock is still held. I'll need to investigate...


Question about use of GreenGenes database

I see that this package uses the GreenGenes database of 16S rRNA genes. Depending on which version you're using, this database is potentially outdated. Could you let me know which version of GreenGenes this package uses? I would also suggest including this information in the README.
Thanks

Greengenes 13_8 85%


API response returns HTML encoding in description field

API response returns HTML encoding for description field
When users expose the JSON record on the item show page, or when users expose the record via the api/records/ call via the URL, the response injects HTML markup into the response of the "description" element. This should not happen.
Expected behavior
The API should return a JSON plaintext response that does not inject HTML markup into the response, especially when none existed previously
Example
here is an output of a sample record
        }
      }
    ],
    "description": "
This dataset collection contains two multi-band raster data layers, which represent estimates of carbon opportunity cost of animal-sourced food production on land. The data is captured at a resolution of 5 arcminutes over the global domain and is derived from data collected approximately over the past two decades (2000-2020). The pixel values measure estimates in tonnes of potential vegetation per hectare that are suppressed by pasturelands and present-day feed crops. In the carbon opportunity cost layer, the bands represent three estimates of carbon in potential vegetation: median, low (5th percentile), and high (95th percentile). In the animal hectacres layer, the pixel band ranges represent two estimated values: areas sourced from the lowest carbon areas and areas sourced from the highest carbon areas. This data is released with an Attribution 4.0 International (CC BY 4.0) license. Users may cite this collection with https://doi.org/10.17609/q5pe-7r68/. Refer to the external for geospatial data preview and download.
",
    "publication_date": "2021-05-12",

Hi @andrewbattista, I'm just seeing this one now.

Did you use the deposit form for creating the record? If so, it's  the JavaScript WYSIWYG editor that injects the
 tags.

The description field is a rich text field so that users can use bullets, bold etc for the description of their record. The field is sanitised on storage (via whitelisting) to avoid XSS injections. The API delivers the full description so that a frontend API  can also correctly render the description with bolds, italics etc.
It's possible that we can create another JSON format, that on output strips all tags from the description field. We do that e.g. in the application/vnd.inveniordm.v1+json format.

@lnielsen - Yes, I did use the deposit form, and yes, it would be great to create a format that strips all tags. However, I think this is an issue that may have been fixed with the version 4 release (or maybe version 5) because it's not injecting those tags anymore. But if not, better to leave this on the radar


How can I use it in web worker thread?

sorry, miss this issue. I'm working on supporting web worker. I will notify you when I done.

Hi, v0.5.0 should support web worker. please try it.


New feature request：Sort import statements in the SFC

If I can provide an SFC import sorting scheme, I can better standardize my project 。

https://eslint.org/docs/rules/sort-imports maybe this can help you

Yeah I agree that his sounds like something eslint should handle. Adding to gadfly's comment above, if you don't know how to set up ESLint so it can understand .vue SFCs and the TypeScript/JavaScript within the <script> block see https://github.com/sethidden/vue3-eslint-stylelint-demo

Volar supports organize imports, you have 3 ways to trigger it.

Option + Shift + O (on osx)
Right click in script block > Select "Source Actions..." > Select "Organize Imports"
Run Organize Imports in command palette (Seem broken in 0.29.8, will fix in next version)

Would it be possible to add this as an on save action?

You can add "editor.codeActionsOnSave": { "source.organizeImports": true } to .vscode/settings.json


Migrate move_messages_between_streams_policy to group-based setting.

Migrates move_messages_between_streams_policy to group-based permission setting -- can_move_messages_between_channels_group.

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

I just merged #32013, so this will need another migration renumber.

Rebased the migrations and merged, thanks @Vector73!


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter kisshome-research for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.kisshome-research
   -
ERRORS:

[x] :heavy_exclamation_mark: [E402] Types of adapter in latest repository and in io-package.json are different "utility" !== "misc-data"
[x] :heavy_exclamation_mark: [E405] Icon must be in the following path: https://raw.githubusercontent.com/ioBroker/ioBroker.kisshome-research/main/; correct sources-dist.json
[x] :heavy_exclamation_mark: [E407] Meta URL must be equal to https://raw.githubusercontent.com/ioBroker/ioBroker.kisshome-research/main/io-package.json; correct sources-dist.json
[ ] :heavy_exclamation_mark: [E433] Dependency 'admin':'>=7.0.25' not available at stable repository

WARNINGS:

[x] :eyes: [W523] "package-lock.json" not found in repo! Please remove from .gitignore!

SUGGESTIONS:

[x] :pushpin: [S519] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #14
@mcm1957 for evidence

Thanks for processing and closing this issue.
I will recheck for new issues later. So it's no problem if this issue has been closed premature.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.  Let's work together for the best user experience.
your
ioBroker Check and Service Bot

@ioBroker-Bot recheck

Thanks for contacting me.
I received your request to recheck this repository. I will start doing my work soon.
I will close an existing issue and create a new one if still any issues are to be evaluated and potentially to be fixed.
Thanks for spending your time and working at an ioBroker adapter.
your
ioBroker Check and Service Bot


Unify APM instrumentation settings

These settings were previously specified in a separate configuration file that only the injector processes would read. This was done to accelerate development in order to get APM instrumentation released in public beta.
Now that we are looking to make APM instrumentation generally available, it makes sense to unify this configuration with the rest of the Agent configuration in the datadog.yaml.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

We should make sure to report the settings via inventories: https://github.com/DataDog/datadog-agent/blob/main/comp/metadata/inventoryagent/inventoryagentimpl/inventoryagent.go#L243
thanks @avivenzio-dd!


Play sound on mousedown and change file with scene change?

Hi. Is there someway to utilize the mousedown event in order to change the source of an audio tag when the scene changes?
I’ve got about 25 scenes, and for each scene I want a different looping sound to play on mousedown. Is there someway to say “during this scene play this file on mousedown, then during this other scene play this other file on mousedown…etc.…“?

@epignosis567: Well, as I posted in the other issue, you could add a custom field to the scenes of your tour JSONk, e.g. playSound with an URL to each sound file. Then a single JavaScript handler can use that field and play back the sound, if one is set for that scene.

This question is effectively a duplicate of #964. I'm closing this issue as I'd prefer to keep the discussion in one place.

Sorry, I did search the issues first! I have no idea how I missed that.


Add findLastVisibleItemIndex and fix ios findFirstVisibleItemIndex

I have fixed a bug that was on the iOS side for findFirstVisibleItemIndex, the sort was not being done correctly.
I have also added a utility method findLastVisibleItemIndex similar to findFirstVisibleItemIndex

@vallemar thanks looks good


Add to npm?

npm is a great way to package and distribute css now!  You can preprocess with grunt or other build tools, and even better, @import right out of node_moduels using things like browserify
Would you be interested in adding this to npm?

[ ] Do we need to change the main file to /gulpfile.js or /dist/sanitize.css or /sanitize.scss?
[ ] How to handle scss vs css?

Great! https://www.npmjs.com/package/sanitize.css
I'll try to optimize the package.json for some of the standard browserify transforms.

Thanks a ton, @bcomnes!

@bcomnes, @pascalduez submitted a change that addresses the main file. Does this resolve both sub-issues?

There are several modules using a style key in package.json so maybe worst adding it too ?
npm-css
parcelify
[...]

Parcelify is confusing me (It looks like it bundles css based on what you require in your main JS file... what do you do if there is no main.js file!?  Opened an issue here: https://github.com/rotundasoftware/parcelify/issues/28 ).  I'm mainly interested in consuming via npm-css though.  Sending the changes that make this possible right now.


Failing test on non-english culture

I see a failing test when running them on a machine with Norwegian culture (which uses comma instead of dot for decimal separators):
NuGetGallery.Auditing.ObfuscatorJsonConverterTests.WriteHappyJson [FAIL]
  Assert.Equal() Failure
    Expected: 2.5
    Actual:   2,5
  Stack Trace:
    tests\NuGetGallery.Core.Facts\Auditing\ObfuscatorJsonConverterTests.cs(68,0): at NuGetGallery.Auditing.ObfuscatorJsonConverterTests.WriteHappyJson()

I'll see if I can submit a PR with a fix.

@khellang , thanks for the investigation. A PR with a fix would be appreciated!

I've sent #5662 which should fix both this and #5661 😄

Thanks for the fix! Closing the issue.


IObservable binding vs TabControl

Hi!
It appears under some circumstances switching tabs in TabControl may injects null-s into IObservable stream binding. I do not fully understand when it happens (but there's example where it definitely happens below) --- seems like TabControl is doing something with DataContext which causes this.
<Window x:Class="Test.MainWindow"
        xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
        xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"

        xmlns:local="clr-namespace:Test"
        Title="Test">

  <TabControl>
    <TabItem Header="Clock">
      <StackPanel DataContext="{Binding ClockModel}">
        <local:MyControl Time="{Binding Clock^}" />
      </StackPanel>
    </TabItem>

    <TabItem Header="Something else">
    </TabItem>
  </TabControl>
</Window>

// Program.fs
namespace Test

open System
open System.Reactive.Linq
open ReactiveUI
open Avalonia
open Avalonia.Controls
open Avalonia.Controls.ApplicationLifetimes
open Avalonia.Markup.Xaml
open Avalonia.ReactiveUI

type MyControl () as this =
    inherit UserControl ()

    static let TimeProperty =
        AvaloniaProperty.RegisterDirect<MyControl, string>
            ("Time", (fun o -> o.Time), (fun o v -> o.Time <- v))

    let mutable time : string = null
    let tb = TextBlock (Text = "Initial")

    do
        this.Content <- tb

    member __.Time
        with get () = time
        and set value =
            if this.SetAndRaise (TimeProperty, &time, value) then
                tb.Text <- value
                printfn "Time is set: %s" (match value with | null -> "<null>" | _ -> value)

type ClockViewModel () =
    let clock =
        Observable.Interval(TimeSpan.FromSeconds 1.0)
            .Select(fun t -> if t % 2L = 0L then "tick" else "tock")

    member __.Clock = clock

type MainWindowViewModel () =
    let clockModel = ClockViewModel ()

    member __.ClockModel = clockModel

type MainWindow () as this =
    inherit Window ()

    do
        this.InitializeComponent ()
        this.DataContext <- MainWindowViewModel ()

    member private this.InitializeComponent () =
        AvaloniaXamlLoader.Load this

type App () =
    inherit Application()

    override this.Initialize () =
        AvaloniaXamlLoader.Load this

    override __.OnFrameworkInitializationCompleted () =
        base.OnFrameworkInitializationCompleted ()
        match base.ApplicationLifetime with
            | :? IClassicDesktopStyleApplicationLifetime as desktop ->
                desktop.MainWindow <- MainWindow ()
            | _ -> ()

module Test =
    let BuildAvaloniaApp() =
        AppBuilder.Configure<App>()
            .UseReactiveUI()
            .UsePlatformDetect()

    [<EntryPoint>]
    let main (args: string[]) =
        BuildAvaloniaApp().StartWithClassicDesktopLifetime(args)

Why are you binding the DataContext explicitly? Did that not work? What version of Avalonia are you using?

Version 0.9.3. Here's full project: https://github.com/mishun/avalonia-issue3599-example
If that part:
      <StackPanel DataContext="{Binding ClockModel}">
        <local:MyControl Time="{Binding Clock^}" />
      </StackPanel>

is changed to just:
      <local:MyControl Time="{Binding Clock^}" />

and  ClockViewModel is assigned to MainWindow's DataContext directly, null doesn't appear (and stream isn't paused when tab is switched).


Create students-wbs.txt

@Alex-1018 I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host students-wbs.uk not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Toast notification for read docs

This feature utilizes React Toastify to display a brief notification when the "Read Docs" button is clicked, informing users that the documentation is currently under development.
Here is the screenshoot :

Steps to Remove Notification Functionality:

Remove the import statements for ToastContainer and toast and its Css.
Delete the  line.
Remove the div wrapping the ReadDocsButton that contains the onClick handler.

This is the issue - Get Started & Read Docs Button Not responding #6


RFC: Use a capsule-based API with a stable ABI for global, cross-extension functionality.

This does not work (meaning build) due to multiple issues but I wanted to propose something concrete here so we can discuss whether this roundabout way is something we would want to pursue.
As this it is proposed, this should mean that the first extension built using PyO3 that calls ensure_global_api creates the module containing its PanicException type object and the corresponding capsule API. All other PyO3-based extensions would then use this capsule to create panic exceptions based on the same internals as first one.
Downstream code should then be able to import pyo3.PanicException to catch all panic exceptions raised by an PyO3-based extension. (At least if it is new enough to use the capsule API.)

(I had intended to include GILProtected in 0.18.2, unfortunately bungled the rebase. We could push out a 0.18.3 however I'm tempted to just get on with some new features for 0.19 and get that out the door faster instead :) )

(I had intended to include GILProtected in 0.18.2, unfortunately bungled the rebase. We could push out a 0.18.3 however I'm tempted to just get on with some new features for 0.19 and get that out the door faster instead :) )

Currently, the only reason I would see for a 0.18.3 is the PyDateTime type object SNAFU.

Any comments w.r.t. the proposed direction? Do want this solution for cross-extension functionality? Are there alternatives? Are we okay with a static for caching the capsule pointer? Again, are there alternatives?

There are the following questions / alternatives in my mind:

Functionality: I can imagine this API may grow to also contain various infrastructure types beyond the exception:

pyo3.Future type which could be a wrapper of Box<dyn Future>
pyo3.Iterator type which could be a wrapper of Box<dyn Iterator<Item = PyObject>>
This may give us power to build designs which we can't easily ship at the moment.

Discoverability: we could publish a pyo3 package on PyPI. The upside of doing this is that then downstream code can import pyo3 immediately without needing to first import a module which is built in PyO3. I quite strongly believe downstream users will frequently be confused if import pyo3 is path-dependent and they can't install it, so I think publishing is probably necessary.

We can also ship .pyi type annotations for PanicException.
This capsule-based solution would likely still be used to build that pyo3 package?
Downside of shipping on PyPI is that pyo3-built extensions may need to update their Python dependencies to list our PyO3 version, creating more churn.

Versioning: this current draft crashes if there are conflicting PyO3 versions. I wonder if we can namespace them to support multiple versions. We may also want to version per portion of the API individually rather than at the global level.

I think the main goal is to ensure downstream code can be as agnostic as possible about individual PyO3 versions.
It would also be quite helpful if PyO3-built packages using different PyO3 versions can coexist. This might be at odds with pyo3 being installable from PyPI.

Perhaps the install from PyPI defines the top-level API which is importable, and we do as best we can to make it forward and backward-compatible with other PyO3 versions?

Maybe it's even possible to make that work in a way where downstream crates do not need to require or pin to a specific pyo3 package version as a Python dependency?

As an idea, pyo3.PanicException can be itself subclassed by versioned types, e.g. pyo3.v0_20.PanicException, pyo3.PanicExceptionV1, pyo3.PanicExceptionV2. That way we could freely rebuild the actual concrete type per version while users can still just write except PanicException and not care about versioning.

I think the static falls under the same category that at the same time it's a necessary evil, however when we have a way to store this in module data then we should do so and remove the static.

One thing I noticed that if we provide a separate pyo3 package which installs the capsule API, we have to be very very careful to not do something that would call into that capsule API until it is installed when that pyo3 package is initialized. Or we would need to not use PyO3 to implement the pyo3 package?

Making the pyo3 package pure Python and caching a reference to the constructor of a PanicException defined in that Python package and just calling that via the normal Python calling convention would have a certain simplicity going for it, wouldn't it? The performance should also not be such a problem as long as we talk about raising exceptions?

Making the pyo3 package pure Python and caching a reference to the constructor of a PanicException defined in that Python package and just calling that via the normal Python calling convention would have a certain simplicity going for it, wouldn't it? The performance should also not be such a problem as long as we talk about raising exceptions?

Definitely would be simpler. Would that rule out replacing it with a capsule-based version later? Any older PyO3 versions which just do import pyo3 could potentially fall-back to using a private type if the import fails.

One thing I noticed that if we provide a separate pyo3 package which installs the capsule API, we have to be very very careful to not do something that would call into that capsule API until it is installed when that pyo3 package is initialized. Or we would need to not use PyO3 to implement the pyo3 package?

Can you provide an example of how things might go wrong? I haven't thought super hard about this, however it's not readily apparent to me what the kind of failure you're anticipating here looks like.

One thing I noticed that if we provide a separate pyo3 package which installs the capsule API, we have to be very very careful to not do something that would call into that capsule API until it is installed when that pyo3 package is initialized. Or we would need to not use PyO3 to implement the pyo3 package?

Can you provide an example of how things might go wrong? I haven't thought super hard about this, however it's not readily apparent to me what the kind of failure you're anticipating here looks like.

Can you provide an example of how things might go wrong? I haven't thought super hard about this, however it's not readily apparent to me what the kind of failure you're anticipating here looks like.

Well let's say initialization of the pyo3 extension panics and wants to create a PanicException but alas it cannot because it panicked before the capsule API used to instantiate a PanicException was installed. We could silently fall back to an internal type, but as a general approach, this would probably mask a lot of configuration/deployment errors which only come to light when except PanicException: does not work, i.e. at a really bad time on the production system. So we might need to limit that fallback to the pyo3 extension itself, but that brings us back to the self-referential dance showcased here which would be nice to avoid by using a canonical source for the capsule API.

Definitely would be simpler. Would that rule out replacing it with a capsule-based version later? Any older PyO3 versions which just do import pyo3 could potentially fall-back to using a private type if the import fails.

I think we could always upgrade to a capsule API later and hence think that starting with a pure Python pyo3 package (and by extension pure Python PanicException class) would probably be the best next step. We can get this published, integrate it into version 0.20.0 and gain some general experience with the approach without getting bogged down in the technicalities of the capsule API evolution.

Ah right I see, yes. There are options like aborting or falling back silently but they're all quite messy, so something it would be nice to learn about first.
I'm in favour of starting with a pure-Python package and we can learn from there.
So I think just a couple questions to consider:

Do we call the PyPI package pyo3 or something like pyo3_runtime? (pyo3_runtime.PanicException is the current name I gave the type object.) I am happy to consider arguments for both or any other suggestion.

It might be a good idea to go for pyo3 and pyo3.PanicException to make a clean break from the non-importable pyo3_runtime.PanicException which will exist for 0.19 and older.

Versioning: do we version this separately from the Rust? If downstream packages put bounds on, say, pyo3==0.20, they can't be installed with packages depending on pyo3==0.21. Maybe we document to always use lower bounds pyo3>=0.20 and promise to users we will never break compatibility? That's really hard, pyo3>=0.20,<1? Same compatbility problem I guess when we release 1.0 and end users can't have compatible PyO3 runtimes.

Maybe use calendar versioning for this package rather than semver? That way there's no "breaking" releases and it's just about what runtime features the end user needs. pyo3_runtime>=2023.06 ? pyo3>=2023.06 ?

... I think I quite like going for pyo3 with calendar versioning - it's relatively obvious what it means. It has the great property that pyo3>=2023.05.31 is sufficiently far enough from the Rust version of 0.19.0 that users are likely to pay attention to our documentation if we ask them to always put just a lower bound.

I am not really familiar with calendar version. From what you describe, is there a difference between >=0.20 and promise to never break and >=2023.06? Does that somehow allow more breakage?
Personally, I would probably prefer to version this separately from PyO3 (the library), e.g. we just start at 1.0 with a standard bound >=1.0,<2, i.e. we can break if we ever need to but I don't see us doing that without a very very good reason, e.g. not "just" because PyO3 (the library) hits 1.0. Version numbers being independent would also match that I would envision pyo3 (the package) evolving much slower than PyO3 (the library).

The difference between >=0.20 looking like a semantic version and >=2023.06 would be that calendar version bumps don't imply any restrictions or changes on breakage, it just labels the release date of the package.
If we go with this package being 1.0 and followed semantic versioning I think it would be less confusing for users if we called it something different like pyo3_runtime or pyo3_core. Imagine we release the crate PyO3 1.0 a couple years from now and we're on version 1.7 of the pyo3 PyPI package. I suspect many users may trip up and try to install the older PyPI package.
Regardless of which combination we go for, I've observed that one nice thing about documenting lower bounds is that we only need to care about backwards-compatibility of the PyPI package with older PyO3 versions. We don't need to gracefully degrade PyO3 to use older versions of the PyPI package, because we can always document "extensions built with PyO3 0.20 require pyo3_core>=1.0" (or >=2023.06). As long as downstream users have set their bounds appropriately, we'll always have a suitably new package.
... Just trying to write that I realise how confusing it is to write pyo3>=1.0 and PyO3 0.20 in the same sentences, so I'd be quite keen to call the PyPI package something different unless we either:

version and release it alongside the PyO3 crate, so everything is in sync
(maybe) use calendar versioning, if we think the distinction that semver used for Rust crate, calver for Python package can be clear enough for users to follow.

So I think we're converging to the decision that the next step will be to push a pyo3_runtime package with version 1.0? Shall we keep it in this repository for ease of development?

I definitely think that being able to break pyo3_runtime at some point in the future if required is worth the disconnect between versions of the PyPI package and the Rust crate.

My gut feeling is that even if we reserve the capability to do so, we'll never want to break the package in practice, because then ecosystem of packages using PyO3 is forcibly split by the runtime version they need. I can imagine we'd be really popular for putting the whole ecosystem in dependency hell 🙃

I think this less an effect of lower bounds, but rather of Python accepting only one version of a package per dependency tree. Because the downgrade is required here because different versions of PyO3 could be combined to built extensions loaded into a single Python interpreter and each would have to be able to cope with the capsule API installed by the others. With any Python package like pyo3_runtime this is not possible as it will be loaded only in one version. Of course, the price to pay is that users have to manage this themselves in every extension built using PyO3.

Yes, this is essentially what I meant. As long as the bounds are set correctly for pyo3_runtime on downstream extension manifests then the extension with highest runtime requirement will win, and that runtime should support all the extensions needing older versions.

So I think we're converging to the decision that the next step will be to push a pyo3_runtime package with version 1.0? Shall we keep it in this repository for ease of development?

Yes, I think the ease of changing this together with the usage sites would be worth it.
I'll close this issue then because this not how we will proceed. I still a pure-Python class PanicException would be a good first export of pyo3_runtime though.

I still a pure-Python class PanicException would be a good first export of pyo3_runtime though.

Agreed. (I'm up for us including this in 0.20, shall we track it in an issue?)

I just came across https://docs.python.org/3/c-api/init.html#c.PyInterpreterState_GetDict, which looks like it might be useful for storing panic exception which is shared across extensions. I don't think it would offer importable symbols for downstream code though.

Indeed, I still think a pyo3_runtime published on PyPI opens up whole new avenues of integration between extensions and would not avoid doing that just because we have alternative ways of stashing per-interpreter or per-module state somewhere.


Add onConnectionSelect prop to FilePicker

Don't forget to run np to publish after merge. This is not (yet) automated


OpenSSH Client Connection

Dear WSL Team,
I've still problems using ssh-client on ubuntu (WSL). The problem is that I donn't get any connection up and running using ssh, but ping does work.
ssh works on windows via putty and git bash, also I've opened all needed firewall ports with no success.
server ip: <IP_ADDRESS>
client ip: <IP_ADDRESS>
ssh-client on ubuntu-wsl:
ssh -v -p55667<EMAIL_ADDRESS>OpenSSH_7.6p1 Ubuntu-4, OpenSSL 1.0.2n  7 Dec 2017
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 19: Applying options for *
debug1: Connecting to server.com [<IP_ADDRESS>] port 55667.
debug1: Connection established.
debug1: identity file /home/user/.ssh/id_rsa type 0
debug1: key_load_public: No such file or directory
debug1: identity file /home/user/.ssh/id_rsa-cert type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/user/.ssh/id_dsa type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/user/.ssh/id_dsa-cert type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/user/.ssh/id_ecdsa type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/user/.ssh/id_ecdsa-cert type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/user/.ssh/id_ed25519 type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/user/.ssh/id_ed25519-cert type -1
debug1: Local version string SSH-2.0-OpenSSH_7.6p1 Ubuntu-4
debug1: Remote protocol version 2.0, remote software version OpenSSH_7.2p2 Ubuntu-4ubuntu2.4
debug1: match: OpenSSH_7.2p2 Ubuntu-4ubuntu2.4 pat OpenSSH* compat 0x04000000
debug1: Authenticating to server.com:55667 as 'user'
debug1: SSH2_MSG_KEXINIT sent
Connection closed by <IP_ADDRESS> port 55667

On the remote server I get this logs:
Jul  5 13:50:59 repo sshd[49946]: Connection reset by <IP_ADDRESS> port 29939 [preauth]

I've no clue what goes wrong, I've checked other tickets with no success.
My Windows Version is:
Windows 10 Enterprise
Version 1803
OS Build: 17134.112

Commands to create SSH server:
apt-get purge openssh-server
apt-get install openssh-server
sed -i 's/PasswordAuthentication no/PasswordAuthentication yes/g' /etc/ssh/sshd_config
service ssh --full-restart

That sed on PasswordAuthentication is generally good advice for people who want password auth, but isn't the cause of the connection reset. It isn't getting that far; sshd has hung up the phone. The OP didn't say but I am going to venture this is on Ubuntu 18.04 from the Store. On 18.04 in WSL, you need to do:
$ sudo ssh-keygen -A

In general do a ssh -vv on the client side and sshd -d on the server side to see where things are going awry.

[ ] In general do a ssh -vv on the client side and sshd -d on the server side to see where things are going awry.

Sorry I was on holiday:
Client Side:
ssh -vv -p22 server.com
OpenSSH_7.6p1 Ubuntu-4, OpenSSL 1.0.2n  7 Dec 2017
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 19: Applying options for *
debug2: resolving "server.com" port 22
debug2: ssh_connect_direct: needpriv 0
debug1: Connecting to server.com [<IP_ADDRESS>] port 22.
debug1: Connection established.
debug1: identity file /home/vankooch/.ssh/id_rsa type 0
debug1: key_load_public: No such file or directory
debug1: identity file /home/vankooch/.ssh/id_rsa-cert type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/vankooch/.ssh/id_dsa type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/vankooch/.ssh/id_dsa-cert type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/vankooch/.ssh/id_ecdsa type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/vankooch/.ssh/id_ecdsa-cert type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/vankooch/.ssh/id_ed25519 type -1
debug1: key_load_public: No such file or directory
debug1: identity file /home/vankooch/.ssh/id_ed25519-cert type -1
debug1: Local version string SSH-2.0-OpenSSH_7.6p1 Ubuntu-4
debug1: Remote protocol version 2.0, remote software version OpenSSH_7.2p2 Ubuntu-4ubuntu2.4
debug1: match: OpenSSH_7.2p2 Ubuntu-4ubuntu2.4 pat OpenSSH* compat 0x04000000
debug2: fd 3 setting O_NONBLOCK
debug1: Authenticating to server.com:22 as 'vankooch'
debug1: SSH2_MSG_KEXINIT sent
Connection closed by <IP_ADDRESS> port 22

Hi there any update on this issue? I think I've the same issue, Cant connect to any SSH Server from Ubuntu 20 WSL , windows 10,
danz@DESKTOP-HTRGUM3:~$ ssh<EMAIL_ADDRESS>Connection closed by <IP_ADDRESS> port 22
danz@DESKTOP-HTRGUM3:~$ ssh -vv<EMAIL_ADDRESS>OpenSSH_8.2p1 Ubuntu-4, OpenSSL 1.1.1f  31 Mar 2020 debug1: Reading configuration data /etc/ssh/ssh_config debug1: /etc/ssh/ssh_config line 19: include /etc/ssh/ssh_config.d/*.conf matched no files debug1: /etc/ssh/ssh_config line 21: Applying options for * debug2: resolving "sdf.org" port 22 debug2: ssh_connect_direct debug1: Connecting to sdf.org [<IP_ADDRESS>] port 22. debug1: Connection established. debug1: identity file /home/danz/.ssh/id_rsa type -1 debug1: identity file /home/danz/.ssh/id_rsa-cert type -1 debug1: identity file /home/danz/.ssh/id_dsa type -1 debug1: identity file /home/danz/.ssh/id_dsa-cert type -1 debug1: identity file /home/danz/.ssh/id_ecdsa type -1 debug1: identity file /home/danz/.ssh/id_ecdsa-cert type -1 debug1: identity file /home/danz/.ssh/id_ecdsa_sk type -1 debug1: identity file /home/danz/.ssh/id_ecdsa_sk-cert type -1 debug1: identity file /home/danz/.ssh/id_ed25519 type -1 debug1: identity file /home/danz/.ssh/id_ed25519-cert type -1 debug1: identity file /home/danz/.ssh/id_ed25519_sk type -1 debug1: identity file /home/danz/.ssh/id_ed25519_sk-cert type -1 debug1: identity file /home/danz/.ssh/id_xmss type -1 debug1: identity file /home/danz/.ssh/id_xmss-cert type -1 debug1: Local version string SSH-2.0-OpenSSH_8.2p1 Ubuntu-4 debug1: Remote protocol version 2.0, remote software version OpenSSH_8.0 debug1: match: OpenSSH_8.0 pat OpenSSH* compat 0x04000000 debug2: fd 3 setting O_NONBLOCK debug1: Authenticating to sdf.org:22 as 'new' debug1: SSH2_MSG_KEXINIT sent debug1: SSH2_MSG_KEXINIT received debug2: local client KEXINIT proposal debug2: KEX algorithms: curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256,ext-info-c debug2: host key algorithms: ecdsa-sha2-nistp256-cert-v01@openssh.com,ecdsa-sha2-nistp384-cert-v01@openssh.com,ecdsa-sha2-nistp521-cert-v01@openssh.com,sk-ecdsa-sha2-nistp256-cert-v01@openssh.com,ssh-ed25519-cert-v01@openssh.com,sk-ssh-ed25519-cert-v01@openssh.com,rsa-sha2-512-cert-v01@openssh.com,rsa-sha2-256-cert-v01@openssh.com,ssh-rsa-cert-v01@openssh.com,ecdsa-sha2-nistp256,ecdsa-sha2-nistp384,ecdsa-sha2-nistp521,sk-ecdsa-sha2-nistp256@openssh.com,ssh-ed25519,sk-ssh-ed25519@openssh.com,rsa-sha2-512,rsa-sha2-256,ssh-rsa debug2: ciphers ctos: chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm<EMAIL_ADDRESS>debug2: ciphers stoc: chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm<EMAIL_ADDRESS>debug2: MACs ctos: umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1 debug2: MACs stoc: umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1 debug2: compression ctos: none,zlib@openssh.com,zlib debug2: compression stoc: none,zlib@openssh.com,zlib debug2: languages ctos: debug2: languages stoc: debug2: first_kex_follows 0 debug2: reserved 0 debug2: peer server KEXINIT proposal debug2: KEX algorithms: curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256,diffie-hellman-group14-sha1 debug2: host key algorithms: ssh-ed25519,rsa-sha2-512,rsa-sha2-256,ssh-rsa,ssh-ed25519 debug2: ciphers ctos: chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm<EMAIL_ADDRESS>debug2: ciphers stoc: chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm<EMAIL_ADDRESS>debug2: MACs ctos: umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1 debug2: MACs stoc: umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1 debug2: compression ctos<EMAIL_ADDRESS>debug2: compression stoc<EMAIL_ADDRESS>debug2: languages ctos: debug2: languages stoc: debug2: first_kex_follows 0 debug2: reserved 0 debug1: kex: algorithm: curve25519-sha256 debug1: kex: host key algorithm: ssh-ed25519 debug1: kex: server->client cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none debug1: kex: client->server cipher<EMAIL_ADDRESS>MAC: <implicit> compression: none debug1: expecting SSH2_MSG_KEX_ECDH_REPLY Connection closed by <IP_ADDRESS> port 22

Hi
I had the same problem, but I solved it by modifying "etc/ssh/ssh_config" according to the link below.
https://superuser.com/questions/699530/git-pull-does-nothing-git-push-just-hangs-debug1-expecting-ssh2-msg-kex-ecd


Exposed early stopping rounds to MLJ including incorporating to defau…

…lt to optimal ntree_limit during predict(). Added relevant tests.

@wilan-wong-1 Would you mind adding  a codecov.yml file, like here to stop the codecov fussiness?

@ExpandingMan Any chance you could review. I've not really been following this particular issue.

Hi @ExpandingMan, any updates on this? Thanks!

Sorry, clearly I missed the first ping somehow.
It's been quite a while since I've used the MLJ interface, so to be honest I don't feel super capable of contemplating those aspects of it at the moment.  However, it looks good from what I can see, I think you should merge this.


Crashing application when build on iOS 13

Terminating app due to uncaught exception 'NSRangeException', reason: 'Cannot remove an observer <_NSKeyValueObservation 0x600001555230> for the key path "videoRect" from <MMPlayerView.MMPlayerLayer 0x7fc0d3eabe30> because it is not registered as an observer.'
I am facing this issue after i build the application on iOS 13. i tried on iOS 12 and it works fine, what i can do to remove this error. This error occurs when i pop the view in which mmplayer has been implemented.

Which lib version are you use?

I am using 5.0.8

Try to update to 5.1.3


Fixed glb padding issue

When adding padding to a glb to align to 8-byte boundaries, I don't think the glb's length and the json chunk's length were being properly updated. The new uint32_t byte lengths after padding were being static_cast to a char and put in the left-most byte of the byte length slots within the glb buffer.

Thanks for the PR @nithinp7. This is an important fix.
The associated spec for this should be updated too, since it clearly did not do enough to cover all cases: https://github.com/CesiumGS/cdb-to-3dtiles/blob/c7b1c67916db02ce493760664a08b8101611ec17/Tests/GltfTest.cpp#L325

I ran into the same problem. Even though the unit test could be improved I'm going to merge just so we get this fix in.


break block glitch

when do you start breaking the block with a crossbow, the block breaks visually, but it will be like a phantom. you enter to the place of the broken block and start getting damage from suffocation.
https://www.mediafire.com/file/m4j9mrzf5uqbyll/2021-07-15_20-25-57.mkv/file

Upload video on GitHub or YouTube so that I can see it, I don't want to download file.

https://youtu.be/fTu64gpkVvc

Upload video on GitHub or YouTube so that I can see it, I don't want to download file.

https://youtu.be/fTu64gpkVvc

Upload video on GitHub or YouTube so that I can see it, I don't want to download file.

That is not a crossbow bug, I do not have that plugin and the same thing happens with the flashlights when placing them on the ceiling


Add .coveragerc and update setup.cfg

Summary
Fix coverage

Coverage remained the same at 34.463% when pulling 41bc0127b9159d224be30fbd5afd85fed53dc2f4 on add-coveragerc into 0a23d868f435213e6735cac4d28faa846bf2ca5b on master.

Coverage remained the same at 34.463% when pulling e4b4991755e9a339d587dfc4f4ec5afddd6dd9da on add-coveragerc into 0a23d868f435213e6735cac4d28faa846bf2ca5b on master.

Coverage remained the same at 34.463% when pulling e4b4991755e9a339d587dfc4f4ec5afddd6dd9da on add-coveragerc into 0a23d868f435213e6735cac4d28faa846bf2ca5b on master.

Coverage increased (+57.6%) to 92.09% when pulling 6f081c66a70876ee6bd0be6654cacef2a195ab6f on add-coveragerc into 0a23d868f435213e6735cac4d28faa846bf2ca5b on master.


count_all_results() with $this->reset_select()

On line 1358 of file 'system/database/DB_query_builder.php'，function count_all_results() will call reset_select(), and this will reset the condition of select query.
However, in some case, we need to get the results as well as count. For example, in pagination, we need to count all the results, but only results of 0-20 using limit.
If we code as
$count = $this->db->count_all_results();//get total numbers
$this->db->limit(0, 20);//get first 20
$data = $this->db->get()->result();//this will not work

So, I suggest to add a parameter with boolean value to judge whether to call reset_select().

You're also using spaces for indentation, you must use tabs, as per our styleguide.
And a changelog entry + documentation update is also necessary.

@narfbg Sorry, It's my first time to pull request.
And now I added changelog and documentation.

By documentation update, I meant database/query_builder.rst update, which is still missing.
You don't need to apologize or something, don't worry ... everybody needs some directions the first time.

@narfbg Changes have been made, please have a look, many thanks.

Still needs more additions & polishing but I guess I'll do them myself ...


Update RoomFinder mod for compatibility with 2023-05-16 Demeo update.

There were numerous changes to Demeo's game-joining flow that RoomFinder needed to compensate for.  Those are encapsulated in this PR.

Demeo has moved the location at which cached rooms were available (previously cachedRoomList in GameStateMachine, now roomList in LobbyMatchmakingController).
As a consequence of the above, we must also now capture a reference to LobbyMatchmakingController as part of the patching sequence.
Some resources that were once in BowserCore.dll have been moved to BowserLegacyRuntime.dll and BowserCoreDataTypesRuntime.dll, meaning those are now new dependencies.

Warning
This has only been tested on the Non-VR PC edition, hence changes to RoomFinder/UI/RoomFinderUiNonVr.cs and not RoomFinder/UI/RoomFinderUiVr.cs.
The author will attempt to make the VR-equivalent changes within the next day.

Off-topic: Hiya!  Missed you all!  Hope you all don't mind me jumping in and trying to submit a couple of these fixes. Hope to chat soon.

Off-topic: Hiya! Missed you all! Hope you all don't mind me jumping in and trying to submit a couple of these fixes. Hope to chat soon.

Great to have you back on the scene @Mex

Off-topic: Hiya! Missed you all! Hope you all don't mind me jumping in and trying to submit a couple of these fixes. Hope to chat soon.

Welcome back! The fix works for PC but can't tell for VR because none of the buttons work for any of the menus there yet so can't click Refresh.

Alrighty, applied changes for VR as well.  Expectation is that RoomFinder should work for both VR/non-VR again.
A bit of code is still duplicated, but I suppose A little copying is better than a little dependency.


Ability to create parameters in AWS CFT and pass in list of k:v from PCF particle config

AWS CFT enforces that you define all the parameters that all run times might need up front. Ex:
var_x_1: 123
var_x_2: 456
var_x_3: 789
var_y_1: abc
var_y_2: def
var_y_3: ghi
Proposing to allow parametrizing vars to something like this:
var_x: {{x}}
var_y: {{y}}
Then in PCF CFT Particle's config dict/json, define the the k:v like this:
"cft_vars": ["x": "123", "y":"def"]
Similar logic was used in EC2 Instance particle for usedata_template
https://github.com/capitalone/Particle-Cloud-Framework/blob/master/pcf/particle/aws/ec2/ec2_instance.py#L118

Completed!


Question!

Hi, thank you for writing this!
Question for you - is the int option saying I can have a "dynamic" ttl like 30 days, instead of a specific timestamp? What would the units be there?
Thank you!

Hi @SaileshKumar
Thank you for using this library and for your question. Unfortunately, it is not possible to have a dynamic TTL (DynamoDB does not offer it). A timestamp is always required. The Int option just defines the field type but it works exactly the same.
Cheers,
Florian


rename to nps

What: Renames the package to nps.

Why:

Windows issues #54
p-s is hard to type (so there's an nps alias anyway)
It's confusing to have several aliases

How:

Find/replace mostly. Then I did some magic with the scripts to make things work without a locally installed instance of nps (because it doesn't exist yet).

Another snag is the nps package is actually already taken (I think this is actually why I named the package p-s in the first place). So I've requested to get ownership of nps. We'll see what the owner says. If the request is rejected, then I think I'll use npm-package-scripts as the package name. Not as terse, but that's ok.
Remaining Steps:

[ ] Determine package name (nps or npm-package-scripts)
[ ] Rename repo
[ ] Update Travis/DependencyCI/etc.
[ ] Create a new screencast
[ ] Deprecate old package (in a breaking change release because let's face it, who wants to see deprecation warnings every time they install stuff that still works)

I'd really appreciate feedback/review on this. Thoughts? 💭

Current coverage is 100% (diff: 100%)

Merging #55 into master will not change coverage

@@           master   #55   diff @@
===================================
  Files          11    11
  Lines         242   242
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits          242   242
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 6a2e93c...cd047f7

You need to do something similar to what Michael Jackson did with npmcdn, open PRs for all dependent repos on github =)


Godot freezes permanently when saving any file

Godot version
v4.0.alpha.custom_build [f62f36cd9]
System information
Windows 11,  Vulkan Clustered, Geforce 1660 (512.15)
Issue description
When saving any file, scene or script, Godot freezes permanently.
https://user-images.githubusercontent.com/10379487/162800968-489af082-6349-4ec9-af56-987cae4cafde.mp4
If you reopen the same project, Godot immediately freezes.
Steps to reproduce

create empty project;
add script;
change it;
save it.

Minimal reproduction project
No response

I tried the reproduction steps and now I can't open my project at all. There is empty window and everything is unresponsive:

I can't reproduce on Linux.
I assume this would be a recent regression (not present in 4.0 alpha 6)?

Yes, it's from today. I'm bisecting it right now.

Regression from #59440
CC @bruvzg
I did a bit testing. When I create a new script as described in the OP and save it (or sometimes just after creating it), the project becomes basically corrupted. Removing .godot folder doesn't help, the white dialog will always appear at startup and block everything. Only removing the newly created file helps.
But it gets more bizarre though. If the same project is then opened in a build without 9381acb6a42da653cb6dfd9e610dfccead11aa98, the file becomes magically ok and then you can open the project normally in 9381acb6a42da653cb6dfd9e610dfccead11aa98 again. Also if your project is corrupted, it starts normally if you remove the broken file, but the issue returns when you restore the file. Maybe 9381acb6a42da653cb6dfd9e610dfccead11aa98 makes the file saved with some wrong file metadata or something and opening working build fixes it, idk.

I can't reproduce it on macOS, so it's something Windows specific, probably some of the FileAccess that was deleted manually, stay open too long after #59440.

Seems like there was an issue with preview generator, as I suspected files stay open for too long. I'll check the rest of the changes to make sure the scope of Ref<FileAccess> is correct and open PR.

@bruvzg Testing again with the latest master, but this does appear have fully resolved this issue. In this case, I get a white box popping up when loading a project which I can't click past

freezes_on_master.zip
Here's an example. I think the popup window is probably reporting about a broken path in the main scene, but regardless, you still can't click past it. I'm testing this on an MSVC debug build.

Actually, the popup is appearing if the test.tres file is in the project, which is...just a basic StandardMaterial3D. If you take it out of the project, you can bypass the white screen, but it will appear again if you try to create a new StandardMaterial3D resource and save it.

@bruvzg I aplogize, misunderstanding. Somehow I stupidly ended up building the wrong branch. I'll attribute some of that to our projecting having a very convoluted automated merging script

Still happening sometimes in beta4. Linux.
Freezes at random times after saving,
and this time, created a scene from inherited scene, Console log looping an error message.

@theVoidZ Do you maybe have some minimal reproduction project?

@theVoidZ Do you maybe have some minimal reproduction project?

it is not consistent but i ll try to make a new project and try to reproduce it in a separate issue.

@KoBeWi
It is difficult to reproduce. i dont know the exact reasons.
But If i describe the way it happens sometimes.
i am opening both Godot 3.5 and Godot 4 and reporting/reworking an old project, what i do is navigate between both project and recreates scenes/scripts in Godot 4 as normal. and sometimes while going back to Godot 4, i found it froze and unresponsive. ( have to manually kill the process ).
Some times i realize it froze after a save ( Ctrl+S ), sometimes when i switch back to Godot 4 window. Sometimes also, when i created an inheritance instance of scene. ( probably after a save of that scene )

You could try using a debugger, but if you never compiled Godot it would be difficult.
Other than that, there's little we can do without more info.


Add js getTimezoneOffset() method.

Add js getTimezoneOffset() method, so that libraries like time can import this for a stdweb implementations.

Ok this should be a much more thorough pass at the Date() JS object.
Some of the setters seem to return the new internal value, which I left out.
Also some of the setters (setFullDate, etc) have optional parameters, which I didn't provide overloads for since I didn't want to come up with names for them, and they're somewhat redundant.
I didn't provide the toLocaleXXXString() methods, as I didn't know the best way to pass along all the additional options from Rust to JS.
I'm not sure about the Date::new_X() naming.
The documentation for the functions is copy/pasted from developer.mozilla.org. I'm not sure about the license for that, but it seemed to be done in other places, so I followed suit.

Ok I've updated with your suggestions. I had been looking at the WebSocket implementation which led me a little astray (new_with_protocols, and a test module that was feature bound to web_test which wasn't actually running my tests when I copy/pasted the use module lines from it originally before submitting it)

LGTM; thanks!


Convert "cpuIsSixtyFourBit" setting to "pathUsePFxEightySix" for people upgrading.

There's a thing in .NET that allows this.

This might help.
https://docs.microsoft.com/en-us/dotnet/api/system.configuration.applicationsettingsbase.getpreviousversion?view=netframework-4.6.1

Didn't work since you can't rename settings across versions like this.


Add docs for operator : combinational - concat

Add docs for operator concat under group combinational
Below is minimum details needed

[ ] name
[ ] operatorType
[ ] signature
[ ] parameters
[ ] shortDescription
[ ] Visual example  (Marble diagram)
[ ] Real world example (Non-framework)

Looks pretty good. Currently on docs all operators also feature a longer, more technical explanation. I think that should also be ported over along with the related operators block. Thanks for doing this! 👍

:+1:


AWS deployment via make deploy

What's this PR do?
Allows deployment to AWS via make deploy
Are there any relevant screenshots?
Why are we doing this? How does it help us?
How should this be manually tested?
Are there any smells or added technical debt to note?
What are relevant issues or links?
Have you done the following, if applicable:

[ ] Performed a self-review of the code?
[ ] Linted code for good style and standards?
[ ] Added unit tests?
[ ] Tested manually on mobile?
[ ] Checked for performance implications?
[ ] Checked accessibility?
[ ] Checked for vulnerabilities with yarn audit --level=high?
[ ] Updated any documentation

Hmm... I'll test this out but I think I want this to be in sink with @aws-sdk/client-s3

Ok, I have yet to run this because I'm actually not sure what it's going to do. I have my AWS keys set up in ~/.aws/credentials, and I have non-Daily credentials in there as defaults. I feel like the CLI probably has an option to specify which credential profile to use.
Also, it looks like this just deploys to a single bucket, which is a good idea for standalone subdomains. But, for things like https://specials.michigandaily.com or https://magnify.michigandaily.com, we probably also want the ability to deploy to a specific route (or key as AWS calls them).

Also, not everyone has a Mac so we can't use brew for given. Probably another reason to move this into sink through the AWS S3 JavaScript SDK.

Right – this would work for subroutes (as long as a user specifies that route), but agreed that the SDK works best. I still do think that we should use the AWS CLI in the meantime since it streamlines content upload, and we can add it to existing documentation. Closing this request.


ngMessages(ngAnimate 1.4.5?): Flash of content before animation begins.

I just noticed a bug which I thought was in Angular Material, but I now believe is in Angular itself.
When the animation for my ng-messages begins, there is a flash where you can see all messages before the animation begins. Although the issue is appearing with ngMessages, I think it might be a broader $animate issue because I can reproduce this by upgrading only angular.js and angular-animate.js from 1.4.4 to 1.4.5 (leaving everything else including angular-messages.js at 1.4.4).
Oddly, if I leave either file at 1.4.4 (it doesn't matter which one), the issue is not reproducible, so it seems to be an issue when both files are at version 1.4.5.
Version Introduced: 1.4.5?
Versions Tested: 1.4.4 (works here; broken on others), 1.4.5, 1.4.6, 1.5.0-beta.0
Browsers: All (IE Edge, Safari, Chrome/Firefox on both OS X and Windows)
Steps to Reproduce:

Open https://codepen.io/topherfangio/pen/PPbLaR
Click on the input and type a 5 so the new value is 12345

You will see the errors appear for a split second, disappear, and then they will animate into place.
Again, you can edit the Codepen settings to change either file to 1.4.4 and it fixes the issue.
Additional Info:
Might be related to #12825.
I did not see any relevant breaking changes in the changelog between 1.4.4 and 1.4.6 which would account for this. Please let me know if I can provide any additional information.

@robertmesserle - is this related to any changes you may have made ?
@matsko  - what are your thoughts here ?

@ThomasBurleson If this is an AngularJS issue, then no - I have no commits in the angular.js repo.

I see what's going on here. I'll have a look later today.

I reproduced the demo without material just to make sure it wasn't some weird interaction with our CSS/JS. You can view it  below if it's helpful:
https://codepen.io/topherfangio/pen/zvoXjz

It also happens on ngIf in IE and Firefox, but not in Chrome. I've created a JSFiddle that illustrates the difference:
Reproduction
In this fiddle, delete the contents of the input box.
http://jsfiddle.net/kvetis/ssnkqog6/3/
Affected Versions: 1.4.5, 1.4.6, 1.4.7 (1.4.4 is okay, probably introduced in 1.4.5)
Browsers: Chrome 45 (ngMessages), IE11 (ngMessages, ngIf), FF 39 (ngMessages, ngIf) @ Windows 8.1 home
Interesting thing is that if you try the second form on this Angular Material demo page: https://material.angularjs.org/0.11.2/#/demo/material.components.input
The issue does not occur on the Client Name input, but appears on Client Email (I have no theory why.)

@kvetis The Client Name input does indeed seem to work in Chrome, but it looks like it has the same issue on Firefox/Safari.

I looked into it and it's definitely a bug with ngAnimate. I am currently thinking of a solid solution for it.

I was previously animating visibility of adjacent elements using "ngIf" and in some cases "ngShow".  Flipping over to "ngSwitch" resolved the flickering issue in 1.4.5+ (everything worked fine in 1.4.4).  "ngSwitch" executes at priority level 1200 while "ngIf" is 600.  Hope this helps!

I can confirm that the same is happening to me in Chrome (45) on Ubuntu (14.04). I can't remember if I had this flickering issue on Windows (been stuck in Ubuntu for too long) but I know for sure that it didn't flicker in the latest Opera on Windows.

Having the same issue here.
Chrome 43.0.x
Angular 1.4.7

This is the culprit: https://github.com/angular/angular.js/commit/ea8016c So yeah, it's not an easy fix.

@matsko came up with a workaround for this problem. ngAnimate will provide a new class on the element that is added as soon as a enter / leave animation is initialized, and removed before the animation actually starts. That means you can apply styles to the element to make sure it is not visible / there is no flicker. See here: https://codepen.io/anon/pen/NGQXOY
Would that work for you? Or did you find another workaround?

@Narretz I wound up having to rewrite all of the animations in JS. Since I am manually handling them now, the flicker is gone.
I talked with matsko yesterday and told him I would try to test it on something else later this week.
Thanks!

@Narretz @matsko I have been able to work around the issue in a way by making the default starting state of the elements be hidden and making my animations show them. However, this has some issues because there are cases (again with users using ng-if/ng-show/ng-hide) where my animations don't fire, and since the default state is hidden, things aren't appearing when they should.
I think the ng-enter-prepare class will fix the issue for us, but I have not tested it yet. I will try to do that today.
Is this something that will be back-ported to the 1.3.x series? We need to support both.

Quick update, we have a workaround for some of our default inputs because we auto-hide the messages. However, if someone needs more customization (using ng-if or ng-hide, etc) the messages will still flicker, so it looks like this fix will be necessary.
I still haven't had a chance to test it within our code, but I am pretty confident that the proposed fix will work. Just need to know if it will be available in 1.3?
Thanks so much guys!

@topherfangio I didn't even know this was an issue in 1.3, I thought it happened since the refactoring in 1.4. It doesn't seem to happen with 1.3 in this bin: https://github.com/angular/angular.js/issues/12969#issuecomment-144154302

@Narretz Ah, indeed! Apologies for the confusion!

I haven't looked into this issue, but I wonder if this is similar to #12825 (i.e. some structural and non-structural animation getting merged).

I encountered this, too. The exit animation is fine, but before the enter animation runs, all ng-messages momentarily display (tested Chrome, FF). Reading through the comments so far, is it correct that there is no known way around this if you're in 1.4.x, except to animate manually?
ng-message {
    display: block;
    margin: 1rem 0;
    transition: max-height linear $fast;

    &.ng-enter {
        max-height: 0;
        overflow: hidden;

        &.ng-enter-active {
            max-height: 2.5rem;
        }
    }

    &.ng-leave {
        max-height: 2.5rem;
        overflow: hidden;

        &.ng-leave-active {
            max-height: 0;
        }
    }
}

We've decided to backport the ng-[event]-prepare class back to 1.4.x, and it will be available in the upcoming 1.4.10

I'm not sure if we can ever provide a "real" fix, since the animation spacing is so essential to ngAnimate now. Moving to the backlog for now.

This worked for me:
.ng-enter-prepare 	display: none

@Unasbj Indeed; this new class was added in more recent versions and allows you to work around this bug.
@Narretz I think this can be closed now?

This is still an issue for me. I've tried some of the workarounds suggested but none work. Maybe I'm missing something?
https://plnkr.co/edit/XYq1wF7la97dIz9Ec33J?p=preview

@C-E-Rios, you could replace ngShow with ngIf on the [ng-message] elements (and don't need any -prepare styles).

@gkalpak - Awesome that does the trick. Thank you.


Remove deprecated strict option.

The strict option was deprecated after being superceded by the more
granular parsedMethods option in 4.1.0.
Fixes #137.

ping @MarkHerhold

Sorry for the delay here!


Update typing-extension version

Update typing-extension version

Is there a particular reason you want to require a newer version? The current version specifier already allows newer versions, it just doesn't require one.

Is there a particular reason you want to require a newer version? The current version specifier already allows newer versions, it just doesn't require one.

google-api-python-client-stubs 1.7.0 depends on typing-extensions<4.0.0 and >=3.10.0

1.7.0 is ancient. The current release doesn't depend on typing-extensions<4.0.0, as you can see it allows anything above 3.10.0. As such this change seems pointless, it will only decrease compatibility. Please upgrade to a newer version and your issue should be fixed.


Wrong authentication failure message for non-admin users.

Description:
APIM 2.1.0 latest WUM gives below misleading warn message for non-admin user authentication failures.
[2019-01-02 13:43:39,543] WARN - CarbonAuthenticationUtil Failed Administrator login attempt 'manoj[-1234]' at [2019-01-02 13:43:39,543-0600]
https://github.com/wso2/carbon-kernel/blob/4.4.x/core/org.wso2.carbon.core.services/src/main/java/org/wso2/carbon/core/services/util/CarbonAuthenticationUtil.java#L71
Affected Product Version:
2.1.0

https://github.com/wso2/product-is/issues/4259

Fixed


Make the chart timeframe longer and ability to remove lines

Now it provides only short-term view of the node activity. 24h timeframe would be much more useful.
Also would be great to have an ability to turn off some of the lines - e.g. total transactions or sent transactions - the most useful one is "new transactions" and this is one I would like to monitor

The lines can be removed now by clicking on the legend icon. The timeframe can be adjusted from the command line option in iota-pm
iota-pm -r (time interval in seconds)


fix: (unit-7 hands on) executable filepath typo

Executable file should be in ./ml-agents, docs have typo.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Hey there 👋 thanks I'm merging it 🤗


Scrolling Table Update killed Mobile Experience

The latest update adding horizontal scroll bars killed this site on mobile for me.
I used to be able to zoom out and get all column on the screen for quick scanning of all the data, but now it's impossible to do so.  I constantly have to scroll left and right to be able to compare columns on opposite sides of the tables.  This makes me not want to use the site anymore as it's too unwieldy.
Please revert.

Also coming here to make this issue.
https://github.com/alex/nyt-2020-election-scraper/pull/240 seems to have made the site more responsive but scrolling large tables is horrid user experience, especially when I have specific columns I want to look at that are nowhere near the title/state of the table (Georgia, Pennsylvania, etc)

+1 on the above , the mobile US has gone messy.
Great effort overall.

Sorry about that!
We've merged something we think will fix that behavior! Please re-open if you still find yourself trapped in horizontal scrolling hell after a refresh.

It's working perfectly now, thanks for fixing so quickly!


Add option to check hosted domain for google

This implements #326
When using the google provider and supplying a hd via --hosted-domain oauth2_proxy will now check for the presence of a hosted domain and return an error if not present.
Let me know if there is anything you'd like me to address code wise.

@jehiah @mbland Could I get one of you to take a look at this? That would be awesome!


travis: enable push jobs

@roee88 - please merge this fix it build the docker images and helm charts, as its' on the PR branch it still did not do the actual push, that will be done after merging to master


Referential Integrity causes foreign key errors with creation of fixtures

Adding the gem caused my test suite to fail due to foreign key index violations with fixture creations.
Simple fix is just to change referential_integrity.rb to:
# Workaround for https://github.com/citusdata/citus/issues/1080
# "Support DISABLE/ENABLE TRIGGER ALL on distributed tables"

require 'active_record/connection_adapters/postgresql_adapter'

module ActiveRecord
  module ConnectionAdapters
    class PostgreSQLAdapter < AbstractAdapter
      def supports_disable_referential_integrity?
        if Rails.env.test?
          true
        else
          false
        end
      end
    end
  end
end

Not sure if there are any unintended consequences...

@DaveWhitmer Hmm - that issue should be fixed though, so this shouldn't be necessary anymore.
Which Citus version are you testing against?

Should be 7.5, but have not even gotten to that stage.  Simply installed the gem in preparation for the move to Citus and my test suite started failing as described above.  Remove the gem and the test suite passes.  Dug into it and found that it was the fixture creation with the referential integrity as described above.  Forked the gem added that monkey patch to it and everything passed.

Yes.  Commenting out the entirety of the referential_integrity.rb file causes my local test environment to pass as I would expect.


az monitor diagnostic-settings create - Event Hub Namespace Authorization Rule

When enabling diagnostic settings via the portal dashboard, or when using the Powershell method, the end-user has the option of specifying a Namespace Authorization Rule, with event hub name being optional. Breaks them by category and sends to insights-logs-dataplanerequests, as the destination, etc.
>az monitor diagnostic-settings create --name=DBDiagnostics --resource=/subscriptions/<CosmosDBSubscription>/resourceGroups/<CosmosDBRGP>/providers/Microsoft.DocumentDB/databaseAccounts/<CosmosDBName>--event-hub-rule=/subscriptions/<EventhubNamespaceSubscription>/resourceGroups/<RGP>/providers/Microsoft.EventHub/namespaces/<Namespace>/AuthorizationRules/RootManageSharedAccessKey<EMAIL_ADDRESS>--debug
Command arguments: ['monitor', 'diagnostic-settings', 'create', '--name=DBDiagnostics', '--resource=/subscriptions/<CosmosDBSubscription>/resourceGroups/<CosmosDBRGP>/providers/Microsoft.DocumentDB/databaseAccounts/<CosmosDBName>'
, '--event-hub-rule=/subscriptions/<EventhubNamespaceSubscription>/resourceGroups/<RGP>/providers/Micros
oft.EventHub/namespaces/<Namespace>/AuthorizationRules/RootManageSharedAccessKey'<EMAIL_ADDRESS>'--debug']

Event: Cli.PreExecute []
Event: CommandParser.OnGlobalArgumentsCreate [<function CLILogging.on_global_arguments at 0x02847F18>, <function OutputProduc
er.on_global_arguments at 0x028C9030>, <function CLIQuery.on_global_arguments at 0x028E0BB8>]
attempting to read file files/logs.json as utf-8-sig
Event: CommandInvoker.OnPreCommandTableCreate [<function CLILogging.remove_logger_flags at 0x02847F60>]
Installed command modules ['acr', 'acs', 'advisor', 'appservice', 'backup', 'batch', 'batchai', 'billing', 'cdn', 'cloud', 'c
ognitiveservices', 'configure', 'consumption', 'container', 'cosmosdb', 'dla', 'dls', 'eventgrid', 'extension', 'feedback', '
find', 'interactive', 'iot', 'keyvault', 'lab', 'monitor', 'network', 'profile', 'rdbms', 'redis', 'reservations', 'resource'
, 'role', 'servicefabric', 'sql', 'storage', 'vm']
Loaded module 'acr' in 0.013 seconds.
Loaded module 'acs' in 0.013 seconds.
Loaded module 'advisor' in 0.008 seconds.
Loaded module 'appservice' in 0.018 seconds.
Loaded module 'backup' in 0.012 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'batch' in 0.036 seconds.
Loaded module 'batchai' in 0.015 seconds.
Loaded module 'billing' in 0.007 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'cdn' in 0.011 seconds.
Loaded module 'cloud' in 0.009 seconds.
Loaded module 'cognitiveservices' in 0.006 seconds.
Loaded module 'configure' in 0.003 seconds.
Loaded module 'consumption' in 0.018 seconds.
Loaded module 'container' in 0.009 seconds.
Loaded module 'cosmosdb' in 0.015 seconds.
Loaded module 'dla' in 0.011 seconds.
Loaded module 'dls' in 0.008 seconds.
Loaded module 'eventgrid' in 0.014 seconds.
Loaded module 'extension' in 0.005 seconds.
Loaded module 'feedback' in 0.004 seconds.
Loaded module 'find' in 0.006 seconds.
Loaded module 'interactive' in 0.002 seconds.
Loaded module 'iot' in 0.013 seconds.
Loaded module 'keyvault' in 0.025 seconds.
Loaded module 'lab' in 0.016 seconds.
Loaded module 'monitor' in 0.016 seconds.
Loaded module 'network' in 0.055 seconds.
Loaded module 'profile' in 0.026 seconds.
Loaded module 'rdbms' in 0.010 seconds.
Loaded module 'redis' in 0.013 seconds.
Loaded module 'reservations' in 0.008 seconds.
Loaded module 'resource' in 0.016 seconds.
Loaded module 'role' in 0.008 seconds.
Loaded module 'servicefabric' in 0.008 seconds.
Loaded module 'sql' in 0.021 seconds.
Event: CommandLoader.OnLoadCommandTable []
Loaded module 'storage' in 0.053 seconds.
Loaded module 'vm' in 0.060 seconds.
Loaded all modules in 0.593 seconds. (note: there's always an overhead with the first module loaded)
Extensions directory: 'C:\Users\jmeisner\.azure\cliextensions'
Event: CommandInvoker.OnPreCommandTableTruncate []
Event: CommandInvoker.OnPostCommandTableCreate [<function add_id_parameters at 0x02D8EDF8>]
Event: CommandInvoker.OnCommandTableLoaded []
Event: CommandInvoker.OnPreParseArgs [<function _documentdb_deprecate at 0x02DFC5D0>]
Event: CommandInvoker.OnPostParseArgs [<function OutputProducer.handle_output_argument at 0x028C9078>, <function CLIQuery.han
dle_query_parameter at 0x028E0B70>]
usage: az monitor diagnostic-settings create [-h] [--verbose] [--debug]
                                             [--output {json,jsonc,table,tsv}]
                                             [--query JMESPATH] --name NAME
                                             --resource RESOURCE_URI
                                             [--logs LOGS] [--metrics METRICS]
                                             [--event-hub EVENT_HUB]
                                             [--event-hub-rule EVENT_HUB_RULE]
                                             [--storage-account STORAGE_ACCOUNT]
                                             [--workspace WORKSPACE]
                                             [--resource-namespace NAMESPACE]
                                             [--resource-parent PARENT]
                                             [--resource-type RESOURCE_TYPE]
                                             [--resource-group RESOURCE_GROUP_NAME]
az monitor diagnostic-settings create: error: 'Namespace' object has no attribute 'event_hub_name'

If I had to guess, this is an edge case, that seems to fail local validations, before sending any request to Azure.
Somewhere around:
https://github.com/Azure/azure-cli/blob/master/src/command_modules/azure-cli-monitor/azure/cli/command_modules/monitor/validators.py#L74
The Comparable Command for Powershell does not seem to have this issue/limitation:
Set-AzureRmDiagnosticSetting -ResourceId $existingCosmosDB.ResourceId  -EventHubAuthorizationRuleId $EventHubNamespaceAuthorizationRuleId  -Enabled $enableLogging -Categories DataPlaneRequests

Environment summary
Running on Windows
azure-cli (2.0.28)

acr (2.0.21)
acs (2.0.27)
advisor (0.1.2)
appservice (0.1.28)
backup (1.0.6)
batch (3.1.10)
batchai (0.1.5)
billing (0.1.7)
cdn (0.0.13)
cloud (2.0.12)
cognitiveservices (0.1.11)
command-modules-nspkg (2.0.1)
configure (2.0.14)
consumption (0.2.2)
container (0.1.19)
core (2.0.28)
cosmosdb (0.1.19)
dla (0.0.18)
dls (0.0.19)
eventgrid (0.1.10)
extension (0.0.9)
feedback (2.1.0)
find (0.2.8)
interactive (0.3.16)
iot (0.1.17)
keyvault (2.0.19)
lab (0.0.17)
monitor (0.1.2)
network (2.0.24)
nspkg (3.0.1)
profile (2.0.19)
rdbms (0.0.12)
redis (0.2.11)
reservations (0.1.1)
resource (2.0.24)
role (2.0.20)
servicefabric (0.0.10)
sql (2.0.22)
storage (2.0.26)
vm (2.0.27)

Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\jmeisner\.azure\cliextensions'

Python (Windows) 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 17:54:52) [MSC v.1900 32 bit (Intel)]

Legal docs and information: aka.ms/AzureCliLegal

Thanks for the report @jmeisner3


17123, strace hang w/ CPU?

I'm not sure what's up, but suddenly I'm running into an odd issue with WSL under 17123, a lot of processes (but no specific pattern as of yet) simply hang at startup.... including strace.
I can run bash.exe just fine. ifconfig runs fine, but strace ifconfig just "hangs" indefinitely - but I say that quotes because it's eating CPU doing something - just not clear what (eats a single core at 100%). I can't kill them at that point, not via task manager or via kill -9.
I tried to capture a full memory dump but it was transferring at 5.1MB/s over USB 3.0 and needed over 2 hours (32GB machine) so I had to abort. I'll probably let it run overnight. I couldn't find anything helpful in kd but I didn't look too hard (and it's just debugging so slow).
(Restarting the subsystem service ultimately hangs on attempting to stop the service.)

The same happens with - for example - lsof.

@benhillis per your comment on #3039 I'm thinking you don't need the dump?

@mqudsi - We have a local repro so no dump needed. Thanks for the offer.

Cheers.

Marking as a duplicate of #3039.