Bug fix in full numeric pixel likelihood calculation

This fixes a bug in the implementation of the full numeric pixel likelihood from de Naurois 2009 , eq 21, in neg_log_likelihood_numeric. The approximate likelihood in neg_log_likelihood_approx is adjusted for consistency, which is important given they are combined in the neg_log_likelihood function. This was not caught in the tests because these also had a bug, which is now fixed too.
I will also implement the fix in the ImPACT branch where the overall pixel likelihood interface changes.

What exactly is isort complaining about here?

What exactly is isort complaining about here?

Probably you haven't sorted your imports according to the standard scriptures of isort, the easiest fix is just to run isort locally and commit the changes it produces.
Do note that it's not actually isort itself that complains, it just modifies the files as part of the CI, but the files being modified by isort counts as a failure, so you never get to actually hear what it did. Thus the advice to just run it yourself on your own copy.

@gschwefer If you enable the pre-commit hooks, this will automatically run when you commit, see:
https://ctapipe.readthedocs.io/en/latest/getting_started/index.html#developing-a-new-feature-or-code-change

This fixes a bug in the implementation of the full numeric pixel likelihood

What is the actual bug here?
I see that you re-introduce terms that are constant under minimization of the likelihood, which is probably the reason why they were left out.
I guess using factorial is pretty slow, here is the optimized implementation of the poisson related functions in numba-stats:

Ok, so these are a couple of different things: The terms in the neg_log_likelihood_numeric that I reintroduce are actually not simple constants to the log likelihood because they are summed over in the n_signal summation and depend on n. Therefore, when the log is taken, they aren't just separate additive terms and therefore make an actual difference. This was not caught in the unit tests because an absolute value was missing in the tests of the relative differences that allowed large negative values to pass.

The factorial I'm happy to switch out.

Measure before :)

The factorial I'm happy to switch out.

Measure before :)

Good hint...the explicit implementation is indeed faster

For arrays of k or lambda, numba_stats.poisson.logpmf was a lot faster (factor of 2 or more), maybe worth introducing this additional dependency.

Indeed, I only tested arrays for k, I'll open an issue


labels GitHub action

Using the labels Action will standardise the labels

Thanks for opening this issue! The labels action would be great

I wanted to know if you manually added the labels?
& after you close the request will it get added automatically?

No, the github action is mainly a way to refresh your default labels and replace them with conventional lables

Awesome thanks for clearing that up!


add default config settings

Type
Crash or hang
Operating System
None
OS Version
No response
Bug description

hide roofs
disable level up pop up
high alch limit

Screenshots or videos
No response
RuneLite version
ad
Logs
No response

Should this be added to all scripts?

could be a plugin i know there is some logic for this in the tutor script


BUG: Delete trip does not work because of referential integrity violation of recipes

No more referential intergrity violations and eveything seems to be working as expected....for now


FlatMap functionality is not as expected

The flatMap method doesn't work as expected for a collection (an array of objects).
For example, if I have a list of employees and each employee has a list of customers and I want to get a list of all customer I would use flatMap as the below:
Input:
let employees = collect([
  {
    customers :[
      {
        name : "c1"
      },
      {
        name : "c2"
      }
    ]
  },
  {
    customers :[
      {
        name : "c3"
      }
    ]
  }
])

let customers = employees.flatMap(employee => employee.customers)

Expected result:
[
  {
    name : "c1"
  },
  {
    name : "c2"
  },
  {
    name : "c3"
  }
]

Actual result:
Error: Cannot read property '0' of undefined(in the collect.js flatMap source code)
Laravel's flatMap source code
Is there a good reason why flatMap behaves like that? If it is an issue with this can you, please, implement the correct version for flatMap?
Thank you!

Hi @JCWolf
I actually discovered and fixed this here the other day, I just didn't have the time to merge and push it.
I'll push a new version some time today 👍

Nice. Paste a link, please, for the merge here so I get notified.
Thanks!


Is it safe to use the Shopping Cart class?

I read in the docs that the class has been deprecated, but also elsewhere that the reason it was deprecated was due to security problems with insecure session handling from version 2.0 which apparently has been fixed in 3.x.
Is this still the case? Should I avoid using it?

Deprecated means deprecated ... I don't know what "elsewhere" is, but the only authoritative resources (i.e. ones you should trust) are on codeigniter.com.
Also, this is a bug tracker. In the future, please post your questions on our forums instead.

for reference: https://stackoverflow.com/questions/31077476/is-it-safe-to-use-codeigniter-shopping-cart
I'm very aware what 'deprecated' means, that was not my question and in no way even attempts to answer the question. Also, this is an issue tracker, not a bug tracker. The difference being "issues means issues"...
Also, you never know who you're talking to. In the future, please use a less passive-aggressive tone instead.

I'm very aware what 'deprecated' means, that was not my question and in no way do you even attempt to answer the question

It's not a detailed answer, but it does answer the question.
If you don't think it does, then you're certainly not that aware of what "deprecated" means.

or show you have any knowledge of the problem at hand

I've been maintaining CI for the past ~5 years and it was me who deprecated CI_Cart. You will not find a person more knowledgeable on this.

Also, this is an issue tracker, not a bug tracker. The difference being "issues means issues"...

No, this is GitHub putting the label "Issues" on a feature that their service provides. We choose to use the said feature as a bug tracker, and bug tracker alone. Hence why we redirect all support-like questions to our forums. Please respect our rules.

Also, you never know who you're talking to. In the future, please use a less passive-aggressive tone instead.

I am not known for being the friendliest person on Earth, that is true. But while my previous reply wasn't the detailed answer I'm guessing you expected, it was still respectful. You on the other hand are being openly aggressive.

Congratulations on all that you've written above. You are trying to come across as superior yet unable to answer a question on this, and I quote, "Issue tracker". You may even call it a tomato, but it's an issue tracker. You're wrong (though it's going to be easier to move the blame onto me, rather than accept that)
The CI foundation should keep you the furthest away from the public as it possibly can - you have the social skills of... a tomato and are doing a big disservice to CI. You evidently don't understand the concept of 'respectful' if you think your first answer is 'respectful (I actually lol'd out loud).

@ChangePlaces
https://www.codeigniter.com/community says
"The Github repository is where you can file bug reports (Github issues), or where you can submit pull requests for enhancements to or fixes for the framework. Github is not for support or help, use the forum instead.
Github issues are also used for tracking planned and approved enhancements, often tied into specific releases."
If you have an "issue" with using Github issues this way, bring it up on the forum.

No, no ... this may not be worth responding to, but it ain't getting buried.

Congratulations on all that you've written above. You are trying to come across as superior yet unable to answer a question on this, and I quote, "Issue tracker". You may even call it a tomato, but it's an issue tracker. You're wrong (though it's going to be easier to move the blame onto me, rather than accept that)
The CI foundation should keep you the furthest away from the public as it possibly can - you have the social skills of... a tomato and are doing a big disservice to CI. You evidently don't understand the concept of 'respectful' if you think your first answer is 'respectful (I actually lol'd out loud).

So, to point out it was deleted by @jim-parry
So, @jim-parry I assume narf is above you in the chain of ranks by undeleting something you deleted.
All these fuss and words and yet still no answer. This is the real CodeIngiter community, folks.

I shouldn't interfere, but not Jim or Narf used words such as "behaving like an idiot", 'I assume you have... "issues"', "you have the social skills of... a tomato"...
Since this is a public discussion, it would be really nice not to insult others, no matter what are their (or our) opinions. :)

So let me get this straight ...
You try to tell me and the entire CI team how we should be using GitHub, because you can't be bothered to respect any rules.

You're now commenting on some imaginary chain of ranks within CI, just so you have something else to say about us.
And after all of this, you have the nerve to complain about not getting "constructive answers"?! Here's one thing I'll tell you about this community that you can't even spell the name of: people like you are not welcome in it.


If use ES6 import without 'loadEagerly' ,tern will not analyse any module

If I don't write loadEagerly in .tern-project, tern wile not analyse any module at all.
look this:

First with loadEagerly:

and give me correctly result:

without loadEagerly:

and without any tips.

Duplicated at https://github.com/ternjs/tern_for_sublime/issues/162


cilium, docker: switch to {clang,llvm}-10.0 and externalize build deps

~Needs https://github.com/cilium/cilium/pull/11199 to be merged first.~
~Still wip, I'll also merge #10675 into here.~

Coverage increased (+0.008%) to 44.423% when pulling 72cb245463a02bf0fcb4052a9953d4182a15a4ad on pr/docker-rework into 4acd141d6b70319b371ff08c438c6dcc7f903f3e on master.

(still need to wait for quay's llvm build before ci testing)

test-me-please


Exposes the client's timeout behind the CLIENT_TIMEOUT env var

Support for this feature was requested in the Discord server

#35 handles this


Adding Ulster Scots translations for NI Household, Individual and static content

What is the context of this PR?
I have downloaded the latest Ulster Scots .po files for NI from Crowdin and have added them to the repo. I have also updated the translate script so that the NI Ulster Scots schemas are being generated during the build process.
How to review
Build the the new schemas and then check that the NI household and individual census surveys have been translated to Ulster Scots.
Note
Translations for static content are not currently at 100%
I had to remove translations for single letter strings in order for the census household schema to build. The single letter strings are erroneous and need to be removed from crowdin.

 Download Ulster Scots PO files (S)

We have updated the language code for Ulster Scots - we are now using 'eo'. We made this change because there were multiple issues being caused by using 'en_US' - it was overriding the default language code 'en' and as a result was causing issues like Ulster Scots appearing for static content when opening the census survey in English.


Delete Microsoft.AspNetCore.Server.IISIntegration.Tools

There will be no preview3 release of this package. The functionality of this tool will be ported to an MSBuild task. cref #258
cc @muratg @pranavkm

Hi @natemcmaster, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Hi @natemcmaster, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

⌚ on downgrading tests to preview2

Needs to downgrade ServerTests, MusicStore, Entropy, etc..

cc @moozzyk

:ship::it:

Farewell Microsoft.AspNetCore.Server.IISIntegration.Tools
Your amazing life with us will always be remembered. You were always there for us, always working to make our lives easier. The server gods may have recalled you from us, but know that derivatives and extensions of your codebase will live on with us in your clones. Let us not dwell on the pain of your departure for long but instead come to rejoice in the glory of your time with us. publish-iis, I raise a toast to you and wish you a fond farewell. :beer:
On a serious note tho ... Well done @moozzyk! Well done, Sir. publish-iis was a wonderful piece of engineering and a great example for other tools of its ilk. If you ever get to missing your dearly departed, please feel free to try GuardRex.AspNetCore.Server.IISIntegration.Tools ... a not too good clone that hopefully won't fry your motherboard. :smile:

Thanks @GuardRex!


[Feature Request] Default/Easy Rate Limit strategy on all API routes

Describe the problem
rate limiting is a basic security problem that is left up to the developer. but it really shouldn't be, particularly for a backend/fullstack framework.
not handling this by default makes sveltekit apps with any significant api/backend calls extremely prone to Denial of Service/Denial of Wallet attacks out of the box.
Describe the proposed solution
it should be as easy as it is in comparable ecosystems:

Rails
Django

Alternatives considered
do nothing, almost guarantee nobody is doing this well if at all
Importance
nice to have
Additional Information
the next obvious need will be to document/pave the path of how to do the rate limiting on a per user or per team basis while letting other users/teams proceed

i implemented this https://github.com/vercel/next.js/blob/canary/examples/api-routes-rate-limit/utils/rate-limit.ts but it should be default/declarative

This is where the Railses and the Djangos of the world have an advantage, being properly coupled to a backend — the logic part is easy (would be trivial to implement as a handle hook, whether as a third party thing or exported from @sveltejs/kit/hooks), it's the storage that's difficult. In a serverless context we obviously can't just rely on an in-memory store. Any thoughts on how to approach that?

(in case anyone reading this didnt know, in-memory is obviously janky but also works for low concurrency, non-edge serverless https://twitter.com/swyx/status/1230731059903336448?s=20)
yeah so i acknowledge that the infra layer should give us more to work with here. perhaps something that vercel could push the envelope on internally that sveltekit can then use?  (this really is a pervasive flaw in fully serverless systems). also notable that simple storage apis are built into deno and cloudflare workers.
i was toying with some kind of etag based timestamp hashing approach but i dont think itd lead to the right rate limiting experience :/
anyway i do feel strongly that backends calling any kind of api where potentially serious money is on the line (eyes my openai bill) should have default rate limiting so i figured i’d file this issue. it’s understandable if we cant solve this for now but feels like a material thing that someone will have to solve at some point for serverless to be a thing

This would probably be a good use-case for https://vercel.com/dashboard/stores, given the very little I know about them - though - I understand that this happens on the edge, so isn't a whole solution, and of course, it poses the age-old question about how we would emulate/test this locally.
Then there's the even older question about implementing things which work across all platforms equally. We could provide adapter specific config for this, but what would the syntax look like when we're trying not to build something specific to vercel, or the edge.

Here's a rate limiter library that may be useful in the meantime: https://github.com/ciscoheat/sveltekit-rate-limiter

Ok so I have a proposal...
I found this library called Unstorage https://github.com/unjs/unstorage which provides uniform api across different types of KV stores. Can we modify @upstash 's implementation of rate limit to work with this and then put is as a core utility in sveltekit.....
So devs are free to use any type of storage they want. Depending on their platform.

Is it ok to use this example https://vercel.com/guides/rate-limiting-edge-middleware-vercel-kv with hooks.server.js and target the '/api/*' routes?

I had a need for rate-limiting, but also coupled with an API key token system, and came up with this:
https://www.npmjs.com/package/svelte-api-keys
Still working on tidy-up and a proper demo page but the TL;DR is that it works similar to GitHub Fine-Grained Personal Access tokens:

The generated API key is only displayed once / never stored
Keys can be associated with multiple permissions or scopes
Approval of each call is based on the key permissions, any expiry date, plus token-bucket rate-limiting
Rate limits can apply globally for the entire API or per group or individual endpoints (and limits are based on key owner, not the key itself, so people could create and manage their own keys)
Token bucket implementations are in-memory (OK-ish for dev / single server) or Redis Stack
Key storage is a simple interface, with in-memory (suitable for dev / demo use only), Redis and Firestore implementations
LRU cache with TTL saves on database hits for key info lookups
You can layer on tier-based rate limits as well, again, similar to how Github works

@Rich-Harris Maybe you could implement it in-memory by default, with an easy way to plug in storage?

Cloudflare Workers has an official rate limiting API in open beta:
main = "src/index.js"

# The rate limiting API is in open beta.
[[unsafe.bindings]]
name = "MY_RATE_LIMITER"
type = "ratelimit"
# An identifier you define, that is unique to your Cloudflare account.
# Must be an integer.
namespace_id = "1001"

# Limit: the number of tokens allowed within a given period in a single
# Cloudflare location
# Period: the duration of the period, in seconds. Must be either 10 or 60
simple = { limit = 100, period = 60 }

Could this be utilized with the adapter-cloudflare?


add EncryptedMessage class

Pull Request Test Coverage Report for Build 287

12 of 12 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.0%) to 74.113%

Totals

Change from base Build 280:
-1.0%

Covered Lines:
1311

Relevant Lines:
1633

💛  - Coveralls


Using GGIR for data logged via a mobile phone

Hi,
Can we use GGIR for the data logged via a mobile phone?  This vignette does not mention anything about mobile phone data.

Hi, GGIR is designed to be applied to data files. If your phone can produce a data file that matches one of the accepted data formats and contains three acceleration signals for at least half a day in duration day then it should be possible. I am working on facilitating a broad range of csv formats in the branch issue185_readCsvGeneric, which may be relevant if you want to explore this.


failed to open stream: Resource temporarily unavailable

Hi, I'm experiencing a really weird issue while running my behat tests. In a total random fashion behat stops running and throws:
[Symfony\Component\Debug\Exception\ContextErrorException]
  Warning: file_put_contents(/path/to/app/var/cache/api-backoffice/bdd/appBddDebugProjectContainerCompiler.log): failed to open stream: Resource temporarily unavailable

I'm using behat 3.3, I can't figure out what's happening.
Thank you

This seems to have nothing to do with Behat and has much to do with your Symfony environment configuration. Behat doesn't use neither Symfony\Component\Debug nor container cache.

@everzet FYI Symfony console 3.2.8 is wrapping Errors in DebugException (fixed already in master) so this a generic PHP fatal, in case you get similar reports
Definitely seems like the issue is the symfony cache not writeable so not Behat related

OK thank you.
I found no issue outside Symfony environment and I'm experiencing this only running behat tests.
Should I post an issue on Symfony's github?


Resolving gosec errors

Fixes #212
Follow up of #214. Some of the issues have already been fixed.

Looks good.  Thank you very much for re-doing this!


Add initiator type to generated diagram

Description
Color connections based on the value of log.entries[]._initiator.type
Relates to issue #9
Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update
see checklist below

How Has This Been Tested?

[x] Running existing tests
[x] Created new tests

Checklist:

[ ] My code has been linted (make lint)
I tried, but 4 linters are outdated, three of them without replacement. I'm optimistic and hope GoLand did a good job here
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
I've took the liberty to check this box as there was no documentation to add to and considered my change small enough to not require full documentation apart from the legend added to the generated puml code.
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have rebased my branch to include the latest changes from master

I'm participating in Hacktoberfest 2022. If you like this PR, I'd be glad if you could add the hacktoberfest-accepted label to it and help me reach my goal :)

I slightly tweaked the title to prevent closure of the issue because I think there's more can be done. BUT I like this PR!! Merged. :)

Alright, thank you :)
Do you have any pointers on what more could be done? As I wrote on the issue, I could imagine showing additional data about the initiator when run with a command flag (like --verbose-initiator). What do you think?

Alright, thank you :) Do you have any pointers on what more could be done? As I wrote on the issue, I could imagine showing additional data about the initiator when run with a command flag (like --verbose-initiator). What do you think?

Go for it!! I'm unlikely to be able to merge any PRs for the next week though.

As long as you add the hacktoberfest-accepted label some point this week, all is fine :grin:


core: Close channels on context free instead of disconnect

The current implementation sent the TERMINATE event to channels on
disconnect. The result was that all channels of the freerdp instance were
destroyed. If the same instance was now used to connect again none of the
channels would work because they were already destroyed.

@freerdp-bot test


how to add a CSRF Token

Hello,
I would like to know how I can add a CSRF Token on a form?
Many thanks in advance, and looking forward for your advise.

You can use {{ form_token() }}
Check this example: https://github.com/skydiver/october-plugin-forms/blob/master/components/genericform/default.htm


Long time since a new release and important changes has been made

I needed the referenceAngle to be public but Pod was still at tag '0.0.4' which didnt have the change. So I made a fork and updated the podspec.version. You just need to push a new tag '0.0.5' I think.

Done, thanks!


Bot idea: Update/create labels on repository creation

Hi there! Just thinking. I have CLI tool for this thing: github-clone-labels, but it's too much work too :D So i'm thinking, is it possible to handle that with bot?
I believe it can be implemented to listen for (specific) user(s) opening an issue with specific title and/or body. And then it go and read the settings from .github/config.yml.

Definitely possible to handle with a bot.
https://github.com/probot/settings allows you to specify labels in .github/settings.yml. And there's an issue open to discuss copying settings from a default repository (https://github.com/probot/settings/issues/29).

Woohoo! I seen that config file today, but didn't realize that it is for one more Probot App ;d;d
Sweeeet :icecream:


Add call-blocked icon

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Improvement: have an attribute that shows whether the lights are in sync with Lightener

I would really like an attribute, or seperate entity, that shows whether the lights that are in a lightener group are in sync with the configuration or not. This way it is possible to know if a light has been manually turned up or down and this could block any automations after a manual adjustment. This would greatly improve my automations. Would this be possible?

I have been thinking about this a little further and think that a switch entity per lightener is the best, because it is possible to use this in automations, and for the use as a ‘reset’. Let me explain:

lightener is set to 50%, in which case the dining room is also at 50%. I manually dim the dining room to 75%, and the switch ‘Sync’ turns off. This allows me to conditionally block some automations that control the lightener
When I want to reset the lights, but don’t want the lightener to change from 50%, the switch-turn on could be used as a reset button within lightener, setting all the lights in sync with the current lightener brightness.


Superset DB API relies on the DB being online

https://github.com/apache/incubator-superset/blob/980dd2fd419893ec5ed9386ca28fa87115a3753d/superset/views/database/api.py#L138
"function_names"  needs a database connection, e.g.
https://github.com/apache/incubator-superset/blob/980dd2fd419893ec5ed9386ca28fa87115a3753d/superset/db_engine_specs/hive.py#L446
This leads to the problem that 1 db being down makes a superset a bit dysfunctional e.g. sqllab will not return the list of databases and will crash the api request.
Introduced: https://github.com/apache/incubator-superset/pull/9012
cc @etr2460 ,  @dpgaspar,  @villebro

Thks @bkyryliuk for reporting this. @etr2460 what do you think about making a dedicated endpoint to fetch database function names?

@dpgaspar good idea. To avoid having to introduce a new endpoint every time we add some new features, perhaps we could make it a "database extras" endpoint?

Another thing that could be done is to catch requests exceptions in the model functions that require external services & will be exposed in the different APIs.

I like the idea of catching the exceptions and falling back to an empty array as @bkyryliuk did in his PR. That said, i can see the need for a new endpoint for db engine specific attributes that aren't fully populatable by the database model

@bkyryliuk that would make an easy/quick fix. Yet I think function_names inclusion on the GET (list) endpoint should be changed to live on it's own endpoint, taking on the @villebro's idea, and since we already have a table_metadata EP, include this kind of info on a database_metadata for example. Note that this property will increase GET (list) response time (yet this can be avoided by just requesting for the exact columns)

This one is actually resolved.

Hi there! @bkyryliuk , I don't think this is solved. I just tried to list databases in my instance with one hive db backend, which is down right now and the request for database list just timeouts and empty list is returned. I don't think this is expected behaviour.


Why not operator overloading in Typescript?

Hello. Why not operator overloading in Typescript? I can not found discussion about.

Can you provide a specific use case of what you are trying to accomplish?
In most of the use cases I can conceive of operator overloading, it would require some sort of run-time emit, which is very anti-pattern for TypeScript.

For example: vector classes.
  var p0 = new Point(0, 0);
  var p1 = new Point(100, 0);
  var p = p0 + p1; //Operator with overload
  var d = 1 !+ 2; //Strict operator (not overloaded)

See #5407

I want operator overload in typescript!
i write a fuckin game engine in typescript if there is operator overloading in it.

@gdefraiteur check out TurboScript with operator overload and pointers which compile to WebAssembly. Even better for game engine 😎

@nidin why not, but the thing is that i like to code with visual studio, and i'm not sure your language is handled in visual studio node project. :/
the interest of typescript for me is that it is usable in such an ide.

@gdefraiteur IDE support can be achieved by developing a small plugins. Between TurboScript was a prototype. Prototype phase ended, now I am working on a detailed language spec. https://github.com/turboscriptlang/spec

@nidin  well, then i hope your project will go well and that you ll make those required plugins.

@gdefraiteur of course 🙂

To add my 2 cents: I would like to be able to define a composition operator for function composition like const composedFunc = f >> g; or a pipe operator like const result = textBox.value |> trim;

+1

You can use Proxy. Here example of overload operator[] in ES6. As i know it will work in typescript too.

Yea, there is no reason for not doing it. HaXe e.g. compiles to JavaScript aswell and also supports operator overloading. And so does AssemblyScript, which compiles directly from TypeScript to WebAssembly.
Every game developer will thank the implementator of operator overloading.
It probably isn't even that hard, just some simple recursive ast conversions from a + b to node.add(node) etc. There are quite some examples for that in pure JavaScript and acorn JS parser, e.g. PaperScript.

@kungfooman, but it isn't that simple. In fact operator overloading with type inference is hard. And as far as I know, TS doesn't use the Hindley-Milner type system. In effect that means that operator overloading would throw away all of TS's guarantees. For operator overloading to be of any use, the type system needs to be sound and capeable of advanced type inference. TS's type system is neither. Maybe that kind of proposal made more sense for Flow, if it weren't for the fact that they also try not to alter JavaScript in any way. But because Flow tries to be sound instead of pracitcal, it has all the problems TS tries to avoid.
Haxe and Dart (just mentioning) require special JS interop (aka wrappers) and have sound type systems (and Haxe is a very good example how to not do operator overloading).
To wrap it up: It isn't possible. And features like that do hurt compiler performance.
Of course there are other dynamic languages that do support operator overloading, namely Python. But they don't have to worry about type safety. Java doesn't have operator overloading because of all those complications (and some other reasons).

Why is it hard exactly, I assume is due inheritance and generics?

@Ivanca, because the compiler has to evaluate the order of execution and must then determine if the types are compatible. And the receiving type might not actually be the one you are expecting. A + A doesn't have to result in A.
But this is all theory, the TS team has clearly stated that they don't want to implement any kind of dependent emit.
One must also think about compatibility with existing libraries. Many classes do have an add method but they don't intend it to be used as an operator overload. Should we then use some cryptic special function?

if A + A always results in A it would be good enough for most use cases, meaning implementing a subset of overloading where all elements must be the exact same type and the result is that same type as well.
The compatibility is the lesser issues of them all, you can just prefix the methods and be done with it, e.g.  typescript_add, typescript_sub


GPS Strength

It could be better if we do have gps strength level

👋 Thank you for the feature request.
PRs are always welcome.


Fails to start wifi

New install following instructions, cloned esp82XX-basic example, successfully flash firmware with "make burn" and "make burnweb" (no errors), but doesn't start a wifi hotspot. Serial output on reset shows:
esp82XX Web-GUI
Version: v0.1-7-g06742-dev - Build Thu Jan 19 20:05:33 PST 2017 with -DICACHE_FLASH -DWEB_PORT=80 -DCOM_PORT=7777 -DBACKEND_PORT=7878  -DSLOWTICK_MS=5Loading Settings: af / 0 / 69 / 69
Settings Loaded: ESP_930A72 / Default
Opmode: 0
Boot Ok.

I'm not sure how to debug why the Opmode would be 0 (wifi off) for this example project. Any pointers would be really helpful, thank you!
On MacOS 10.12

I am not sure how it got into opmode 0.
Try pressing and holding the PGM (GPIO0) button down for about 5 seconds, then releasing.  It should reboot into SoftAP mode.
Charles

You did it! Thank you a million :)  Had to hold closer to 10 seconds but after I let go PGM button wireless AP showed up and serial output:
ets Jan  8 2013,rst cause:2, boot mode:(3,7)

load 0x40100000, len 28272, room 16
tail 0
chksum 0x85
load 0x3ffe8000, len 884, room 8
tail 12
chksum 0x59
ho 0 tail 12 room 4
load 0x3ffe8380, len 2612, room 12
tail 8
chksum 0xb2
csum 0xb2
don't use rtc mem data
rlN5
    esp82XX Web-GUI
Version: v0.1-7-g06742-dev - Build Thu Jan 19 20:05:33 PST 2017 with -DICACHE_FLASH -DWEB_PORT=80 -DCOM_PORT=7777 -DBACKEND_PORT=7878  -DSLOWTICK_MS=5Loading Settings: af / 0 / 69 / 69
                Settings Loaded: ESP_930A72 / Default
                                                     Opmode: 2
                                                              Default SoftAP mode: "ESP_930A72":""
                                                                                Boot Ok.
                                                                                IGMP Joining: 0104a8c0 fb0000e0

I'm putting together Mac OS setup guide, will make note of this.

That would be really awesome!  Thanks!


Update the page header

This PR updates the page header throughout the entire application.

Awesome work everyone!
@philipnrmn 🙇  🙌


OurDNA: Dashboard Frontend

Link to Figma Mockup
https://docs.google.com/presentation/d/1MkRjXH6mOX5qQIUjKOwocAZk1friEf48tquLA3cFEP0/edit#slide=id.g2dd7580e6f0_0_26

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.60%. Comparing base (4c6a1f7) to head (1eaf70b).

Files
Patch %
Lines

db/python/layers/ourdna/dashboard.py
0.00%
2 Missing :warning:

Additional details and impacted files
@@                     Coverage Diff                      @@
##           ourdna/dashboard-backend     #766      +/-   ##
============================================================
- Coverage                     76.60%   76.60%   -0.01%
============================================================
  Files                           158      158
  Lines                         13162    13163       +1
============================================================
  Hits                          10083    10083
- Misses                         3079     3080       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Refactor WASI-NN to simplify support for multiple frameworks

Reorganize library structure.
Use latest version of wasi-nn wit (Oct 25, 2022): https://github.com/WebAssembly/wasi-nn/blob/0f77c48ec195748990ff67928a4b3eef5f16c2de/wasi-nn.wit.md
Split logic that converts WASM structs to native structs in a separate file.
Simplify addition of new frameworks.

TODO

[ ] Free wasi-nn on app exit.

TODO

[ ]  Free mem of NNs used by an app on exit.

@tonibofarull Have you finished this item and shall I merge the PR?
@yamt Are there any comments from you?

@wenyongh, I still need to check how it's done in wasi fdtable teardown.
We can proceed as you want:

Keep the PR open until I finish this topic.
Merge this and do it in another PR.

Thank you!

@wenyongh, I still need to check how it's done in wasi fdtable teardown. We can proceed as you want:

Keep the PR open until I finish this topic.
Merge this and do it in another PR.

Thank you!

Got it, had better keep the PR open until you finish it. Thanks.

As stated here https://github.com/bytecodealliance/wasm-micro-runtime/issues/1573, the next step will be to add GPU support.
Later on, I'll add the wasi-nn context per WASM app and supporting multiple networks at the same time.

[ ] Ready for review

[x]  Ready for review

@tonibofarull The coding guideline CI check failed for wasi_nn.c, could you use clang-format-12 to format the file?
sudo apt-get install clang-format-12
clang-format-12 -i --style=file path/to/file

Refer to:
https://github.com/bytecodealliance/wasm-micro-runtime/actions/runs/3996791726/jobs/6857274884
Use `clang-format-12` or `git-clang-format-12` to check code format of
    the PR, with a commit range specified. It is required to format the
    code before committing the PR, or it might fail to pass the CI check:

    1. Install clang-format-12.0.0
    Normally we can install it by `sudo apt-get install clang-format-12`,
    or download the `clang+llvm-12.0.0-xxx-tar.xz` package from
      https://github.com/llvm/llvm-project/releases/tag/llvmorg-12.0.0
    and install it

    2. Format the C/C++ source file
    ``` shell
    cd path/to/wamr/root
    clang-format-12 --style file -i path/to/file
    ```

@tonibofarull The coding guideline CI check failed for wasi_nn.c, could you use clang-format-12 to format the file?

I was using the general version (no -12).


Quoted Printable: Prevent that the next line's first character is a dot

At least when used in combination with Exchange, Microsoft Outlook strips dots that appear at the beginning of a new line. We try to workaround this bug by wrapping early and thus preventing lines from starting with a dot.
See http://engineering.como.com/ghost-vs-outlook/

Thanks!

@steffenweber this actually breaks a lot of other things, as you don't make sure you're not breaking any qp-octets in the process. There needs to be a similar check as is done here to ensure we're not breaking within a qp-octet. Copying the block in lines 123-127 down below your code fixes the problem, but I don't know how @weierophinney feels about duplicate code here.

I'm fine with duplication; these are different concerns that just happen to
use the same/similar solutions. Please submit a patch for review.
On Apr 22, 2016 11:41 AM, "Jan-Simon Winkelmann"<EMAIL_ADDRESS>wrote:

@steffenweber https://github.com/steffenweber this actually breaks a
lot of other things, as you don't make sure you're not breaking any
qp-octets in the process. There needs to be a similar check as is done
here
https://github.com/steffenweber/zend-mime/blob/38e07a18b4aa905c0fceca2c53b4f82facc8a871/src/Mime.php#L123
to ensure we're not breaking within a qp-octet. Copying the block in lines
123-127 down below your code fixes the problem, but I don't know how
@weierophinney https://github.com/weierophinney feels about duplicate
code here.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zend-mime/pull/4#issuecomment-213501293

@weierophinney I have a fix for the exact problem, but fixing the problem like it's done here will cause more problems in rare cases. Moving dots to the next line until there is no dot could break lines containing only dots. Don't like contributing solutions with known problems...

@weierophinney I have looked into this issue further, and I can't seem to reproduce outlook 2013 breaking if there is a dot at the start of a line, as long as the underlying protocol implementation does the dot-stuffing as expected. @steffenweber is there any way that you could let me know what your exact test-case was?

We received a user complaint about broken links in our emails. The cause were missing dots in the hostname part of URLs. Those missing dots appeared after a line-wrap in the QP-encoded message. The user said that he was using Outlook 2010 in combination with Exchange Server 2010. I did and do not have access to Outlook and/or Exchange and did not try to reproduce this bug myself but according to http://engineering.como.com/ghost-vs-outlook/ this is a known Outlook/Exchange bug (that maybe only happens with specific configurations).
Perhaps the problem mentioned by @eth8505 can be fixed by moving the outlook workaround a few lines up above the block "Ensure we are not splitting across an encoded character". However, I'd find it helpful to have a concrete example / test-case that we are trying to fix. Could you please provide an example were qp-octets are currently broken, @eth8505?

@steffenweber Do you actually have any other sources on the web describing this bug? I can't seem to find anything on the matter except the one post you provided.
Generating a testcase for the broken octets is rather simple. Just add any non-ascii/multibyte character before a dot you're trying to prevent from being rendered on a new line.  I'm not aware of other sources that mention this issue.
Thank you for the test-cases. The first test-case is fixed by moving the workaround a few lines up as proposed in my previous comment. The second test-case shows that the Outlook workaround is applied unnecessarily even if the situation is hopeless (a whole line full of dots) but the result does not seem to be wrong (only a bit inefficient). The third test-case does not work without the Outlook workaround either (Zend-Mime applies rtrim to remove whitespace) so it seems to be unrelated (if it is a bug at all).
I've created a branch with the proposed fix for you to test. The change does not break any unit-tests but I'm not an expert on quoted-printable encoding: https://github.com/steffenweber/zend-mime/commits/qp-doesnotbreakoctets
Regarding test-case 2: The desired result can be achieved by appending && !preg_match('#^\.+$#', substr($str, 0, $ptr)) to the while condition of the Outlook workaround. I'm not sure whether that's worth it. Maybe there is an easier fix? Or we leave it as is.

I'm sorry I didn't get around to testing it until now. Appears to be working. I think you should leave the preg out. I assume the original implementation explicitly stuck to basic string functions for performance reasons.
What I don't understand about the fix in general, is why it got merged in the first place. I remember lots of things not getting added in the past due to not conforming to RFCs. Any insights @weierophinney ?


Fix rhel7stig_run_audit var

Overall Review of Changes:
rhel7stig_run_audit is mentioned in the README, but all the when conditions say run_audit. Var should be updated to reflect the README.

hi @bordenit
Thats a great catch, thank you for taking the time to raise this issue and provide a fix. In this instance the README is incorrect we are moving to a common variable for the audit portion across all the OS's.
There is a new update to the audit script itself coming also.
I am happy to change it unless you want to in this PR and we can merge this with the README fix?
Many thanks once again
uk-bolly

@uk-bolly Thanks you can go ahead and make the change. Also, looks like the test might be failing due to extra_var not being passed in for: rhel7stig_bootloader_password_hash: 'grub.pbkdf2.sha512.thishasbeenchangedfortesting'
Thanks


Strings are not obfuscated on build time

Hello,
I'm following https://github.com/efraespada/AndroidStringObfuscator/blob/master/README.md#gradle-implementation but the string resources are no longer obfuscated during build time (everything was working fine with these instructions https://github.com/efraespada/AndroidStringObfuscator/blob/3451745f18fdc97ca58b271d238eef60511b348b/README.md).
My root_project/build.gradle looks like:
...

buildscript {
    repositories {
        jcenter()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:2.3.2'
        classpath "com.efraespada:stringobfuscatorplugin:0.4.1"
        ...
    }
}
apply plugin: com.efraespada.stringobfuscatorplugin.StringObfuscatorPlugin

and my root_project/app/build.gradle looks like:
repositories {
    jcenter()
}

dependencies {
    compile "efraespada:androidstringobfuscator:0.4.1"
}

Am I missing something? How are the strings supposed to be obfuscated during build time after removing the AndroidStringObfuscator.jar and the code to use it?

@d-moreira the new plugin replaces the JARfile. It should find in res folder every strings.xml file and encrypt every string value with hidden attribute as true.
What is printing your Gradle console?

Ok, it's working now :) I was trying to obfuscate some strings on a res/values/secrets.xml file, which worked previously.
So the plugin only looks for strings on strings.xml files? Can you consider extending the functionality to look for string resources on any .xml file under res/values at least? And also update the documentation to reflect this limitation.
Thanks!

I was thinking something like this on module's build.gradle:
stringobfuscator {
    srcFolder = ["src/main/res"]
    stringFiles = ["strings.xml", "secrets.xml"]
}

Of course, I'll update the documentation. Thanks for your patient.

That would be even better. Thank you!

@d-moreira hope it helps you! v.0.5.0.

Tested and working!
Thanks for your work :)


question: server-free port-free direct API for use in Function-as-a-Service / tests ?

I don't mean to hammer you with issues today, I'm just darned excited about finding this project. :D
I'm working on a project that will be hosted in a Function-as-a-Service, such as AWS Lambda, Google Cloud Functions, or Azure Functions. Within such an environment, it would be desirable to be able to pass a request to this JSON API framework without involving the network stack.
It is still possible to bind to a port, and then create an internal HTTP request to that port, but I'd rather avoid it. Having that port bound makes testing tricky and adds to the latency of a request.
The Hapi.js server framework provides an inject() method that can be used like this without needing to bind to a port: http://hapijs.com/api#serverinjectoptions-callback
Is there a way to use the existing APIs in this framework to handle a synthetic request without needing to bind to a port or create a real HTTP request? If I get the time, I'll try to see if this is possible with the Express features that this framework exposes.

What I have so far is an approach that starts the server then tries to stop it:
const app = express()

jsonApi.setConfig({
  hostname: 'localhost',
  port: 0,
  protocol: 'http',
  router: app
})

function startInnerService () /* : http.Server */ {
  jsonApi.start()

  return app.listen(0)
}

// https://github.com/holidayextras/jsonapi-server/blob/v2.2.0/lib/jsonApi.js#L121
function stopInnerService (server /* : http.Server */) {
  // jsonApi.metrics.emitter.removeAllListeners('data') // see issue #220
  for (const i in jsonApi._resources) {
    const resourceConfig = jsonApi._resources[i]
    if (resourceConfig.handlers.close) resourceConfig.handlers.close()
  }
  server.close()
}

function getInnerHost (server /* : http.Server */) /* : string */ {
  return `localhost:${server.address().port}`
}

Note that this doesn't yet seem to successfully shut everything down. I feel an HTTP-free network-free way of asking the framework to handle a (synthetic?) request would be ideal. But the one-request server approach I've outlined here is very close to being sufficient.

I've been reviewing discussions over in https://github.com/expressjs/express/issues
Officially-supported network-free request handling in Express might not be possible until 5.x. :S

In lib/rerouter.js you'll find a network-stack bypass that lets you ping requests in without hitting express, I wrote it for a performance boost when doing lots of inclusions and it's used by the GraphQL implementation.
Take a look, it might do what you need although it may need a few small tweaks for non-GET requests :)

Thanks for all your contributions @jokeyrhyme, they're awesome :D I'm rammed for the rest of today into the evening, but I promise I'll get to all this first thing tomorrow morning (~22 hours from now) :cake:

lib/rerouter.js looks promising, thanks :)
My current approach starts the server in a child process, makes the request, and then kills the child process. This covers closing the MongoDB connections, at least until I get around to that PR. :)

Ditto to this, I have an application where the main interface will be JSON:API, but I also need to be able to create one kind of resource anonymously via multipart/form-data POSTs. I retrieved the jsonapi-server's router and added a route for this, but now I need to turn around and format and submit JSON:API requests via HTTP to localhost...which seems...wasteful. I also have to find the related parent resource that the incoming form submission belongs to, so there's a number of operations I would have to do by loopback requests.

Has there been any movement on this?  Is this possible?  This library looks awesome, and I would love to use it for my API gateway+lambda-based API.  Would this approach require APIG to basically shovel all the requests through to one monolithic lambda which serves the entire API? or would it still be possible to run individual lambdas for each resource/method/whatever?

@repl-chris, conceptually you should be able to have individual lambdas. In practice it will probably not work with the current implementation. Have you experimented at all with running the (monolithic) server in a lambda?

No, unfortunately I haven’t had much of a chance yet...I‘m quite new to this ecosystem so I’ve mostly just been playing with express...it is on my todo list tho :)


Update Cytoscape <--> Cytoscape.js Visual Property compatibility list

There is an old list of VP compatibility list, but it's hard to find:
http://wiki.cytoscape.org/Cytoscape_3/UserManual/CytoscapeJs
Need to link to the latest document from the App Store Web site.

Complete list is now available as a Google Doc:
https://docs.google.com/spreadsheets/d/1iTDKGjro1-L7HGz1ftozqDKRxjQVSPF28jQLt7XGrSg/edit?usp=sharing


commit hook was inaccuratly reporting vet errors due to how we ran vet

This would inaccurately report errors like this:

type foo []int

f := foo{1}

With the error like composite literal uses unkeyed fields
This fix will correct that invalid error as when you run go vet instead of vet it has package level knowledge.

@dgnorton

lgtm :shipit:

:heart:

Here is a reference repo that shows the scenario we were getting locally.  No idea why really...
https://github.com/corylanou/vetting


Coverage of specifications cannot reach 100%

With the current implementation of the validator, it is not possible to reach 100% coverage for some specifications.
There are 3 cases that lead to this problem:

A specification imports another specification but does not define a refinement to messages of the imported specification. For example, the arp.rflx specification imports ipv4.rflx but only uses field types of ipv4.rflx, it does not define a refinement ARP -> IPv4 (of cause not). The output of the validation is shown below.
A specification imports another specification and defines a refinement to only one message of the imported specification (if multiple messages are defined in the imported specification).
A specification contains completely separate messages. Cf. #833
(and combinations of the 3 cases)

Discussed suggestions so far:

Compute the coverage per-message not per-specification file. As a downside, this could lead to forgotten messages.
Only compute coverage of the PDU specification, do not include refinements. (i.e. when validating ARP::Packet_IPv4 only get coverage of arp.rflx). This would require some logic to include refinement messages that are an integral part of the PDU, as e.g. IPv4Options to IPv4. This would also make getting test data easier, as one would not need to search for specific combinations of PDU/SDU messages.

--------------------------------------------------------------------------------
                     RecordFlux Validation Coverage Report
Directory: /home/rs/Dev/RecordFlux-specifications
--------------------------------------------------------------------------------
File                                          Links       Used        Coverage
ipv4.rflx                                        27          0           0.00%
ethernet.rflx                                    12          0           0.00%
arp.rflx                                         10         10         100.00%
--------------------------------------------------------------------------------
TOTAL                                            49         10          20.41%
--------------------------------------------------------------------------------

Related to #814


ArrayBuffer error

Hey I'm trying to render an image fetched via node-fetch but it doesn't seem to work.
Node-fetch provide a method to convert the data in arrayBuffer.
But when I'm using it, the library tells me that image data must be an arrayBuffer.
Do you have an idea why ?
import * as fetch from 'node-fetch';

const stamp = await fetch('https://www.emc-imc.org/fileadmin/_processed_/5/7/csm_STAMP_logo_transparent_72ppi_8ff95cb9e4.png');

const imageData = {
            width: 3,
            height: 3,
            extension: '.png',
            data: (await stamp.arrayBuffer())
        };

Thanks for your report. It seems I made a mistake in the function I wrote to check for valid image data.
You can work around this for now by converting your ArrayBuffer to a Buffer using Buffer.from(). I'll push a fix release later today.


Document that this code is not part of framework

As noted in previous comments this section reads like this topic is part of the framework.  Do us a solid and make crystal clear that this content is not part of the framework.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b06aff09-e5dd-9bba-d158-f3b61984d735
Version Independent ID: 72c8ef2a-01f3-aee4-9a84-11995565b2d3
Content: Reusable EventToCommandBehavior - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/behaviors/reusable/event-to-command-behavior.md
Product: xamarin
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @jraldrin
Fixed in a PR that will go out later.


[Git] weird indicator for renamed file

(I am on Mac OS X, Git 2.4.0)

have a checked in README.md with some contents
take the contents of the file and move it to a new file CONTRIBUTING.md
change the text in README.md to something else
stage all

On OS X El Capitan, I just ran through this scenario with:

git 2.4.9 (Apple Git-60)
Code 0.9.2 3fd93bd0833cc6ad311134e254f8ec2b048994a3
hub 2.2.1

and staging looks as I'd expect:

I tried this and seems that the issue is gone. It might have been an isolated event.


A first cut at updating and simplifying the Java FDK Readme.

Removed user tutorial already included in tutorials. Reorganized and simplified. More work to do reviewing each of the docs linked from here.

thanks. Needs a very clear explanation about where to go if a developer wants to use the Java FDK for their function.

Looks good to me. Gonna go ahead and merge.


Unable to Download CNN-Dailymail Dataset

Describe the bug
I am unable to download the CNN-Dailymail dataset. Upon closer investigation, I realised why this was happening:

The dataset sits in Google Drive, and both the CNN and DM datasets are large.
Google is unable to scan the folder for viruses, so the link which would originally download the dataset, now downloads the source code of this web page:

This leads to the following error:

NotADirectoryError: [Errno 20] Not a directory: '/root/.cache/huggingface/datasets/downloads/1bc05d24fa6dda2468e83a73cf6dc207226e01e3c48a507ea716dc0421da583b/cnn/stories'

Steps to reproduce the bug
import datasets
dataset = datasets.load_dataset("cnn_dailymail", "3.0.0", split="train")

Expected results
That the dataset is downloaded and processed just like other datasets.
Actual results
Hit with this error:
NotADirectoryError: [Errno 20] Not a directory: '/root/.cache/huggingface/datasets/downloads/1bc05d24fa6dda2468e83a73cf6dc207226e01e3c48a507ea716dc0421da583b/cnn/stories'

Environment info

datasets version: 1.18.3
Platform: Linux-5.4.144+-x86_64-with-Ubuntu-18.04-bionic
Python version: 3.7.12
PyArrow version: 6.0.1

#self-assign

@AngadSethi thanks for reporting and thanks for your PR!

Glad to help @albertvillanova! Just fine-tuning the PR, will comment once I am able to get it up and running 😀


ARO-3258: propagate errors of ARO PullSecret controller to ARO operator

Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-3258
What this PR does / why we need it:
It is needed to propagate errors of ARO PullSecret controller to ARO operator in order to see those errors at the Operator level and to see all the controller errors in one place.
Test plan for issue:
[x] Unit Test Cases
[x] Local Cluster Creation
[] CI
[] E2E
Are there unit tests
Yes, https://github.com/Azure/ARO-RP/blob/master/pkg/operator/controllers/pullsecret/pullsecret_controller_test.go
How do you know this will function as expected in production?
Running all unit tests locally and verifying tests output
Is there any documentation that needs to be updated for this PR?
N/A

@microsoft-github-policy-service agree company="Red Hat"


Error: local docker client not initilized

When I add a openwhisk action to run in local container, I get "local docker client not initilized" error.  If I restart the node-red container, local container start and openwhisk action executes locally.  What am I doing wrong?

Hi @nagarashish - thanks for checking this out!
We are in the process of deprecating this repo in favor of https://github.com/kpavel/openwhisk-light - which would provide pretty much the same functionality with standard (unmodified) OpenWhisk nodes in Node-RED (you just need to deploy openwhisk-light in another container, and specify the URL of the local openwhisk-light runtime in the action node configuarion -- .e.g, http://<IP_ADDRESS>:3000/api/v1 - with your "normal" auth key to access OpenWhisk). Would you mind switching to that one?

thanks. I will to new repo.


Add *Source variants to HumioAction resource

Currently it is not possible to reference kubernetes Secret resources for secret
fields like ingest tokens and API keys.
This change adds *Source variants to these fields where a secret can be
referenced.
This fixes #351

Hi @Crevil - thank you for this! As you can see, we have a recent change in this project which causes our e2e tests for fail for forks. This needs to be fixed, but I'd rather not wait for that to be fixed before we can merge this, so I pushed a separate PR for you fork just so we can run the tests and then decide if we can go ahead and merge this PR.

Thanks. 🙌 I'm unsure whether I need to do anything here?

@Crevil Yeah, we don't expect you to do more at this stage. We're currently struggling with some flaky tests which we'd like to fix first. It is not something that was introduced by your work, we just want to get it fixed before we run a new round of tests based on your work. Then we just need this change rebased on top of master once the flakiness has been resolved.


TypeError: Cannot convert Type TensorType(float64, matrix) (of Variable Subtensor{int64:int64:}.0) into Type TensorType(float32, matrix). You can try to manually convert Subtensor{int64:int64:}.0 into a TensorType(float32, matrix).

I am running this code in python 3.7.3 getting the following error:-
TypeError: Cannot convert Type TensorType(float64, matrix) (of Variable Subtensor{int64:int64:}.0) into Type TensorType(float32, matrix). You can try to manually convert Subtensor{int64:int64:}.0 into a TensorType(float32, matrix).
I tried setting floatX=float64
The following is my .theano.txt
[global]
device = cpu
floatX = float64
[nvcc]
fastmath = True

I fixed this issue in a forked repository here: https://github.com/amirmohammadkz/personality-detection

Hi,Thanks for your reply.Can you give me some instruction if i want to test my own dataset by using your project.Thanks!


Updating info about golang authors

It's been more than a month since we heard from you, so now we unfortunately must close this to keep our queues clear. There were still a few things to be changed before this could be merged. But if you ever return and wish to keep working on this, it can certainly be reopened.

Thanks for the feedback, I apologize for letting this slip through the cracks


@prisma/photon installation hangs

When I install the fasade package, it hangs for unknown reason on the generate script:
><EMAIL_ADDRESS>postinstall F:\#Projekty\#Github\typegraphql-prisma\experiments\node_modules\@prisma\photon
> node scripts/generate.js

I can abort that but then it fails to generate manually using prisma2 generate:
PS F:\#Projekty\#Github\typegraphql-prisma\experiments> npm run generate

> @ generate F:\#Projekty\#Github\typegraphql-prisma\experiments
> prisma2 generate

> Downloading windows binary for query-engine [] 100%

Generating Photon.js to ./node_modules\@prisma\photon
Error: Error: EBUSY: resource busy or locked, copyfile<EMAIL_ADDRESS>-><EMAIL_ADDRESS>
If I remove all the files it complains about, it stops on<EMAIL_ADDRESS>and I can't remove that because then Error: Cannot find module './runtime' 😕
If I provide a custom output path, it generates without any issue, but then it fails on making a query:
  photon Request: +0ms
  photon query {
  photon   findManyUser {
  photon     id
  photon     email
  photon     name
  photon     age
  photon     balance
  photon     amount
  photon     role
  photon   }
  photon } +0ms
  photon Request: +30ms
  photon query {
  photon   findManyPost {
  photon     uuid
  photon     createdAt
  photon     updatedAt
  photon     published
  photon     title
  photon     content
  photon     kind
  photon   }
  photon } +23ms
  engine { PRISMA_DML_PATH:
  engine    'F:\\#Projekty\\#Github\\typegraphql-prisma\\experiments\\prisma\\generated\\photon\\schema.prisma',
  engine   PORT: '54951',
  engine   RUST_BACKTRACE: '1',
  engine   RUST_LOG: 'info',
  engine   LOG_QUERIES: 'true',
  engine   OVERWRITE_DATASOURCES: '[]' } +0ms
  engine { cwd:
  engine    'F:\\#Projekty\\#Github\\typegraphql-prisma\\experiments\\prisma' } +3ms
  engine:log { timestamp: 2001-11-27T10:29:35.689Z,
  engine:log   level: 'INFO',
  engine:log   target: 'prisma',
  engine:log   fields:
  engine:log    { message: 'Encountered error during initialization:',
  engine:log      'log.target': 'prisma',
  engine:log      'log.module_path': 'prisma',
  engine:log      'log.file': 'query-engine/prisma/src/main.rs',
  engine:log      'log.line': 130 } } +0ms
  engine connect ECONNREFUSED <IP_ADDRESS>:54951 +9s

I can provide more details if needed 😉

Thanks for reporting @MichalLytek!
As confirmed in Slack, this is fixed in the latest alpha.

The query still fails, so I reopened this.

Everything works now, closing 😄

It's definitely getting stuck on 2.0.0-preview017.1

@timsuchanek
Both 2.0.0-preview017.1 and 2.0.0-preview017.2 hangs on the node_modules\@prisma\photon > node scripts/generate.js 😕
It doesn't hang when I install in on root typegraphql-prisma that doesn't have prisma2 dependency installed - it prints the In order to use "@prisma/photon", please install prisma2 error end exit 😉

Thanks, @MichalLytek! Can you please describe a reproduction of how to get to the described problem?

My repository is always the best reproduction 😄
https://github.com/MichalLytek/type-graphql/tree/prisma
Get a Windows machine, clone the repo, go to experiments folder and run npm i - it hangs even on 018.2 preview release 😕

Perfect! I'll have a look 🙂

It turns out, that this neither related to Windows, nor to Photon.js.
The typegraphql generator you have defined in https://github.com/MichalLytek/type-graphql/blob/prisma/experiments/prisma/schema.prisma#L15 simply hangs.
If I removed that generator block, it didn't hang anymore.
I've done a small improvement in the postinstall hook of @prisma/photon:

Renamed scripts/generate.js to scripts/postinstall.js just to make it clearer.
Enabled the logging of the command that is being executed (in this case prisma2 generate simply hangs)

Oh, this makes sense. I think my generator tries to read photon dmmf but it's not already installed/generated yet? I will need to add some logging to file to be able to debug the generator execution.

I am not using typegraphql and it hangs as well after updating to 2.0.0-preview018.2. Works fine on 2.0.0-preview015.

Please create a new issue for this @cypcz if you still encounter this problem. Thanks!


[Backport 2.4.x] fix(ci): use new infra configuration

Release Note
NONE

No need to run checks.


Only notify about successful tagged releases to Acorn Users

Once this merges, we will have to add two new secrets:

USERS_SLACK_BOT_RELEASE_CHANNEL
USERS_SLACK_BOT_TOKEN

In addition we will need to invite the bot to the channel we want it to notify to. I have already created the bot in the Acorn Users slack so this will be easy.

I get that youre removing succes reports to the ci-reports channel, but what is the other thing you're doing in release.yaml? It's a modification, so where is it reporting now that you'd be dropping?

@cjellick I should change the secret names to be clearer in their intent. That being said, the change in release.yaml  will make it so all successfully tagged releases get announced in the public Acorn Users slack. Before this change, successful tagged releases announced in our internal slack.


Bug: handle and report ErrorResponse message type

Bug description
Currently this message type is not properly unwrapped and reported, beyond this:
logical replication error: unexpected message type *pgproto3.ErrorResponse

Steps to reproduce
Not sure
Version
latest

Let's triage this when @lyuboxa is available.


Error: read ECONNRESET

Full nativefier command used to build your app: nativefier --name "Wechat" "https://wx.qq.com/"
Version of Nativefier (run nativefier --version): v7.5.4
Version of node.js (run node --version): v6.3.1-1
OS: deepin

deepin@deepin:~$ nativefier --name "Wechat" "https://wx.qq.com/"
  packaging [==============================                    ] 60%Downloading tmp-111Downloading tmp-11149-0-electron-v1.7.9-linux-x64.zip
[>                                            ] 0.3% of 51.24 MB (412.63 B/s)

Downloading tmp-11149-0-electron-v1.7.9-linux-x64.zip
Error: read ECONNRESET

{ Error: read ECONNRESET
    at exports._errnoException (util.js:1012:11)
Downloading tmp-11149-0-electron-v1.7.9-linux-x64.zip
Error: read ECONNRESET

Hi @jingle0927 and thanks for the feedback. Could this be a problem similar to #497 ? Are you behind a proxy/VPN?

@ronjouch   hi   Thanks
you can see my speed(0.3% of 51.24 MB (412.63 B/s)), so  I'm come from to China
The speed is too slow , So I used the VPN agent

I will try again.

deepin@deepin:~$ nativefier --name "Wechat" "https://wx.qq.com/"
packaging [==============================                    ] 60%Downloading tmp-274Downloading tmp-2744-0-electron-v1.7.9-linux-x64.zip
Error: connect ETIMEDOUT <IP_ADDRESS>:443
{ Error: connect ETIMEDOUT <IP_ADDRESS>:443
at Object.exports._errnoException (util.js:1012:11)
at exports._exceptionWithHostPort (util.js:1035:20)
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1080:14)
code: 'ETIMEDOUT',
errno: 'ETIMEDOUT',
syscall: 'connect',
address: '<IP_ADDRESS>',
port: 443 }

@jingle0927 looks like a duplicate of #479 to me, please follow discussion there. In the meantime, here's a workaround that could work: download your desired electron version, and place it where our packager will look for it. See https://github.com/jiahaog/nativefier/issues/448

Thanks

export ELECTRON_GET_USE_PROXY=1 # 值为1或true
export GLOBAL_AGENT_HTTP_PROXY=http://proxy.example.com:1080
export GLOBAL_AGENT_HTTPS_PROXY=https://proxy.example.com:1080


OrientedImage: Use Canvas API for Better Results

Problem
Correctly orienting images was done in #12797 using css transform styles. However images with orientations that involve a 90º or -90º rotation can cause the final image to be rendered out of bounds of the parent.
This is because transformed DOM elements do not participate in flow and will not cause the parent to expand/contrast after transformation. This occurs when shrinking the window size to the minimum height. The rotated image will not scale down because css width: 100% and height: auto are applied to the un-transformed DOM element.

Solution
Use the canvas api to perform the following operations

Render a <canvas /> element and get a backing 2D context from getContext('2d')
Draw the image into the context
Apply the appropriate transformation to the image using context rotate() scale() and transform(). Note: This approach was adapted from croppie.js.
Encode the entire canvas as a dataURL using canvas.toDataUrl()
Use the canvas dataURL as the final source to the rendered <Image />

Final result works on pre-upload preview images (served from the user's filesystem) as well as the fullscreen attachment view for images.

Notes

The final result from this process is a regular <img /> component whose content has been rotated/flipped according to the EXIF orientation flag.
There is some latency in the process from src → img → canvas → dataURL → img. However it is usually less that 700ms for jpeg images under 5Mb and approximately 1.5 seconds for images larger than 10Mb
When the image is large, the largest source of latency is loading the image data from the service.
Zooming works as expected.

Does this work well with retina-like scaling?


Reducer without switch

As reading from the docs you could avoid using switch with a function that maps action types to handlers. But still I'm not fully convinced with that approach.
In order to avoid those long switch statements, I suggest injecting the dependency of the reducers right into the actions.
The actions now will know how to change the state per each reducer. The reducer will just call them accordingly. This way, the reducer would follow the Open/Closed principle (Motivation by Uncle Bob: https://youtu.be/TMuno5RZNeE?t=3605)
I found this architecture much better. Take the case your system requires a new feature where 3 reducers listen to the same action. Then you would need to modify those reducers -- adding a new case on each switch statement.
Following the style I propose, you would only need to create the action with the reducers all in the same place. Example:
// ACTION
function addTodo() {
  reducers: {
    counterReducer: (state) => ...,
    todosReducer: (state) => ...,
    dummyReducer: (state) => ...
  }
}

// todos REDUCER
function todos(state = initialState, action) {
  if (action.reducers && typeof action.reducers.todosReducer === 'function') {
    return action.reducers.todosReducer(state);
  } else {
    return state;
  }
}

Here you could see a refactor of the todomvc example using this idea.
Thoughts?

redux-actions and handleActions.

The whole point of Flux/Redux is to decouple actions and reducers. There may be many independent reducers handling one action, and there may be many independent actions handled by one reducer. This is what makes Flux/Redux scale because big teams can work on overlapping features without constant merge conflicts, as state mutation logic is kept separate even if it is caused by the same actions.
You also lose the ability to serialize and record/replay actions because they are not plain objects any more in your example. Enabling this was another big constraint of Redux. Please read this:

There are frameworks claiming to be similar to Flux, but without a concept of action objects. In terms of being predictable, this is a step backwards from Flux or Redux. If there are no serializable plain object actions, it is impossible to record and replay user sessions, or to implement hot reloading with time travel. If you’d rather modify data directly, you don’t need Redux.

Think of action as a "message". The action doesn't know how the state changes. It's precisely reducers' job. Otherwise your reducers don't seem to contain code at all. Also don't forget that reducers can be composed further than a single level. What you propose doesn't work with reducer composition because you're effectively hardcoding reducer structure into the action objects.

I see. Thank you for the quick feedback @gaearon :+1:

Well, personally I hate switch so I use plain objects instead:
const actionHandlers = {
  [ADD_TODO] (state, todo) {
    // do stuff
  },
  [REMOVE_TODO] (state, id) {
    // do stuff
  }
}

const reducer =  (state = initialState, action) => {
    const { type, payload } = action
    const actionHandler = actionHandlers[type]
    if (actionHandler) {
      return actionHandler(state, payload)
    }
    return state
  }

@negamaxi What does this syntax mean that you use?
[ADD_TODO] (state, todo) {
    // do stuff
  },


Refactor Awesome Books with ES6 features

Added the following files for the app

books-bg.png
Book-storage.js
luxon.js
nav-menu.js
store.js
index.css
index.html
index.js
README.md

Add changes as instructed

[x] Made changes in index.js as instructed.
[x] Made changes in store.js as instructed.
[x] Made changes in PR title as instructed.


Issue Linking:
https://github.com/scania-digital-design-system/tegel/issues/625
How to test
Provide detailed steps for testing, including any necessary setup.

Run Storybook.
Go the Accordion and select the Docs tab.
Select "No last border".
Go to the Canvas tab to see the result.

Checklist before submission

[x] All existing tests pass

Suggested test steps

[x] Browser testing (Chrome, Safari, Firefox)

Screenshots
Before:

After:

@patrikhultgren  - Please, if you can, add the playwright test that will check the functionality of this prop by setting it to true and taking a screenshot of it.
Great contribution and code looks OK to me. Will be approved after test and confirmation from designers ;)

@patrikhultgren - Please, if you can, add the playwright test that will check the functionality of this prop by setting it to true and taking a screenshot of it. Great contribution and code looks OK to me. Will be approved after test and confirmation from designers ;)

Now there is a e2e-test for the removed border.

@patrikhultgren  - Please do update you branch with latest develop changes by "git rebase develop" or by using GitHub UI before "Squash and merge" :)

Thanks! I have updated the branch. I don’t have permission to merge, which is fine.

Thanks! I have updated the branch. I don’t have permission to merge, which is fine.

Ill merge it! Thanks a lot for the contribution!


[Input] Style update + description

We have updated the design for the <Input />
Task:

Update the design for the Error message
Add a description below the Input
Make sure the bottom fields don't overlap each other and make a bottom gap.

update from design


[gsl-lite] Update to v0.34.0

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: BurningEnlightenment sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


feat: flag to allow destructive schema changes

This PR reinstates https://github.com/aws-amplify/amplify-cli/pull/8144 after it was reverted here due to e2e test failures.
The last commit fixes the e2e failures and it's the only part of this PR that is different from 8144.
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed or added
[x] Relevant documentation is changed or added https://github.com/aws-amplify/docs/pull/3580

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #8273 (f2fa479) into master (cf2a56d) will decrease coverage by 0.01%.
The diff coverage is 42.85%.

:exclamation: Current head f2fa479 differs from pull request most recent head 2084b5d. Consider uploading reports for the commit 2084b5d to get more accurate results

@@            Coverage Diff             @@
##           master    #8273      +/-   ##
==========================================
- Coverage   55.68%   55.66%   -0.02%
==========================================
  Files         691      691
  Lines       38535    38542       +7
  Branches     7807     7811       +4
==========================================
- Hits        21459    21456       -3
- Misses      16287    16296       +9
- Partials      789      790       +1

Impacted Files
Coverage Δ

...es/amplify-category-geo/src/commands/geo/remove.ts
54.54% <ø> (-5.46%)
:arrow_down:

...le-transformer/src/cdk/create-searchable-domain.ts
100.00% <ø> (ø)

packages/amplify-category-geo/src/index.ts
41.81% <23.07%> (-7.12%)
:arrow_down:

...fy-category-geo/src/service-utils/resourceUtils.ts
67.02% <50.00%> (-1.12%)
:arrow_down:

...ble-transformer/src/cdk/create-streaming-lambda.ts
100.00% <100.00%> (ø)

...-transformer/src/graphql-searchable-transformer.ts
96.34% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf2a56d...2084b5d. Read the comment docs.


LSP suggestions not working when typing

I have a strange issue where as I type, for example, a variable name, nvim-cmp will not prompt me with any suggestions from the LSP. However, if I type foo., that does correctly trigger the LSP to provide me suggestions.  This would suggest that the LSP server is working, but not getting fired correctly when the user is typing letters to trigger the autocomplete.
In this instance the language server is TypeScript.
My config is:
local cmp = require'cmp'
cmp.setup({
  snippet = {
    expand = function(args)
      vim.fn["vsnip#anonymous"](args.body) -- For `vsnip` user.
    end,
  },
  mapping = {
    ['<C-d>'] = cmp.mapping.scroll_docs(-4),
    ['<C-f>'] = cmp.mapping.scroll_docs(4),
    ['<C-Space>'] = cmp.mapping.complete(),
    ['<C-e>'] = cmp.mapping.close(),
    ['<CR>'] = cmp.mapping.confirm({ select = true }),
  },
  sources = {
    { name = 'nvim_lsp'},
    -- { name = 'vsnip' },
    -- { name = 'buffer' }
  },
  completion = {
    completeopt = 'menu,menuone,noinsert',
  }
})

(I've disabled vsnip and buffer sources to test this issue).
I believe I have all the relevant plugins installed:
  Plug 'hrsh7th/cmp-nvim-lsp'
  Plug 'hrsh7th/cmp-buffer'
  Plug 'hrsh7th/cmp-vsnip'
  Plug 'hrsh7th/nvim-cmp'

Here you can screenshot that shows when triggered by a certain character (foo.), the LSP suggestions work:

However when typing normally I would expect to see some suggestions to autocomplete men => menu, but it does not, despite menu being a variable in the current scope:

I don't see any errors reported either.
CmpStatus shows:
# ready source names
- nvim_lsp:tsserver

# unused source names
- vsnip
- buffer

My one thought is that this is a large TypeScript codebase, so I'm wondering if there are so many suggestions it overwhelms vim-cmp in some way?
And the LSP server is working, so I'm not really sure what the issue is here. Please let me know if you have any thoughts or if there is further debugging I can do here.
Thanks!

I can't reprodue it.
Please minimal repro steps. If you can't create minimal repro steps, I will close it sorry.

Appreciate the quick reply and sorry I haven't been able to pin it down.
I've noticed something odd though: it works the first time and then doesn't work. So here it works fine:

But if I then type another line and start typing men, I get nothing. Will try to figure out the minimal repro. Thanks!

Hey,
I did some more debugging and found that I think it's an issue in TSServer itself where an error is being thrown (I found it in the LSP logs).
Given that, I'll close this as the problem clearly is upstream of vim-cmp. Thanks for your work on this plugin btw and sorry for the noise :)

Thank you for the detailed investigation!

In case anyone finds this and wants to follow along, I have reported it upstream to the TS repo: https://github.com/microsoft/TypeScript/issues/46024

@hrsh7th
Hi, I'm a beginner making a config for myself.
Sadly, I'm getting an issue where as I type, nvim-cmp will not prompt me with any suggestions. I've attempted with filetypes: python, vue.
With vue, I've checked with :CmpStatus. Most of the sources are unused

My repo: https://github.com/KingNNT/neovim-configuration/tree/develop
My nvim-cmp config: https://github.com/KingNNT/neovim-configuration/blob/develop/lua/plugins/configs/nvim-cmp.lua
Hope you can help me find my mistake if I configure it wrong


WINNF.FT.C.REG.7 failed to run

Hi,
Test WINNF.FT.C.REG.7 failed to run because required a JSON (REG_Success_cbsd1.json) that not exist.
Gustavo

I assume this has been resolved and can be closed?


[⚡ Feature]: Is there any plan to support Plug'n'Play features in yarn berry?

Description
I am currently working on developing an app using yarn pnp. However, I encountered an issue when attempting to deploy my app to Cloudflare Pages. I received an error message stating that @cloudflare/next-on-pages doesn't support Plug'n'Play features from yarn berry.
Is there are any plan to support yarn pnp in the future? Alternatively, is there any way to deploy an app using pnp in the current version, such as by unpluging certain packages?
Additional Information
No response
Would you like to help?

[ ] Would you like to help implement this feature?

Hi @noobnooc I'm very sorry for the late reply 😓 🙇  (I wanted to check this sooner but never got around to it)
It seems that the Cloudflare Pages team is planning on updating the build image to support yarn 3 (https://discord.com/channels/595317990191398933/1104067231991742504) and I believe that should happen fairly soon
As soon as it's updated I think we just need to remove this piece of code: https://github.com/cloudflare/next-on-pages/blob/360d9f07dd38d434bf035d8f784962a00f02fb5d/src/buildApplication/packageManagerUtils.ts#L37-L43
And yarn pnp should just work 🙂
So support for pnp should be coming soon 🙂, I'll keep you updated here on the progress
(PS: until we properly support yarn pnp I doubt that there are workarounds you could try)

I've been able to get Yarn PnP working by just separating out the vercel build and next-on-pages bundle, like so:
mkdir -p .vercel
echo '{"projectId":"_","orgId":"_","settings":{}}' > .vercel/project.json
YARN_NODE_LINKER=pnp vercel build
next-on-pages --skip-build

I also run vercel build with the yarn command no-oped because I couldn't find a way to disable the yarn install that vercel build does.


Grid System inconsistency in Mac Safari

The Grid system is, can I say inconsistent? in Mac Safari. I tested on rMBP and MBA
This is the same case with Bootstrap 2.x as well. I am not sure if there's a Safar-Specific fix for it, as it would appear to be a Safari Problem.
Mac Safari Screenshot:

Mac Opera/Chrome Screenshot:

You can resolve this problem of 12 grid columns in Safari browser by doing this:
.row:before, .row:after{
display:inline-block;
}
and everything will look good

Thank you very much! this should be pinned

@Barelmusenga thanks a lot man... you're a star :D
https://stackoverflow.com/a/52719475/2613838

You can resolve this problem of 12 grid columns in Safari browser by doing this:
.row:before, .row:after{
display:inline-block;
}
and everything will look good

I need a clarification on this, that is why the layouts are collapsing in the safari browser alone. Is there any specific reason on using bootstrap V4*

For anyone else that can come across this one --> the issue happens with Bootstrap 3 grid on Safari 13 but not on Safari 14.
The suggested solution will distort the Safari 14 !
.row:before, .row:after{
display:inline-block;
}
Here's what worked for me for both Safari versions: Please mind that you might need @supports for this so that Chrome, FF and Edge remain unchanged by this:
.row:before, .row:after{
display:flex;
flex-wrap: wrap;
}


Kulfy: Watch catamerica.com

Kulfy requests the watch of the watch_keyword catamerica\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

catamerica\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Approved by Ryan M in Charcoal HQ


Fix glitches

Yo @yeoman/yosay,
This PR fixes two (not so edgy) edge case issues I introcuded with #23.
First of all let me say how sorry and ashamed I am for creating these bugs :confounded:
Bug No. 1
The overflowing of messages that are too long is producing corrupted output of speech bubble when using the maxLength option.

This is fixed with:

4ed86625 Fix overflowing messages when using maxLength

See screenshot:

Bug No. 2
Calling yosay more than once within a script adapting topOffset causes corrupted output of the latter speech bubbles.

This is fixed with:

03a990aa Fix problem with top offset and left padding …

See screenshot:

Conclusion
As said before I am terribly sorry to messed this up with the introduction of the speech bubble tip.
It was caused by not thoroughly hand testing and the auto generating of test fixtures :anguished:
I made sure to hand test the fixes of this PR by with this node file:
const yosay = require('yosay');
const chalk = require('chalk');

console.log(yosay('Hello, and welcome to my fantastic generator full of whimsy and bubble gum!'));

console.log(yosay('Hi'));

console.log(yosay('Welcome to Yeoman, ladies and gentlemen!'));

console.log(yosay('Hi', {maxLength: 8}));

console.log(yosay('Hello, buddy!', {maxLength: 4}));

console.log(yosay(chalk.red.bgWhite('Hi')));

console.log(yosay(chalk.red.bgWhite('Hi') + ' there, sir!'));

console.log(yosay(chalk.red.bgWhite('Hi') + ' there, sir! ' + chalk.bgBlue.white('you are looking') + ' swell today!'));

console.log(yosay('first line\nsecond line\n\nfourth line'));

console.log(yosay('项目可以更新了'));

console.log(yosay('iloveunicornsiloveunicornsiloveunicornsiloveunicornsiloveunicornsiloveunicorns'));

console.log(yosay('Lie on your belly and purr when you are asleep shove bum in owner’s face like camera lens.  Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball.  Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball.  Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball.', {maxLength: 26}));

console.log(yosay(
	'That’s it. Feel free to fire up the server with ' +
	chalk.green('`npm run start:dev`') +
	'or use our subgenerator to create endpoints.'
));

console.log(yosay ('That’s it. Feel free to fire up the server with `npm run start:dev` or use our subgenerator to create endpoints.'));

console.log(yosay(
	'That’s it. Feel free to fire up the server with ' +
	chalk.green('`npm run start:dev`') + '.'
));

console.log(yosay(
	'That’s it. Feel free to fire up the server with ' +
	'`npm run start:dev`.'
));

And this bash file:
yosay 'Hi' &&
yosay 'Welcome to Yeoman, ladies and gentlemen!' &&
yosay 'Hi' --maxLength 8 &&
yosay 'Hello, buddy!' --maxLength 4 &&
yosay '项目可以更新了' &&
yosay 'iloveunicornsiloveunicornsiloveunicornsiloveunicornsiloveunicornsiloveunicorns' &&
yosay 'Lie on your belly and purr when you are asleep shove bum in owner’s face like camera lens. Cough furball.' --maxLength 11 &&
yosay 'Lie on your belly and purr when you are asleep shove bum in owner’s face like camera lens. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball.' &&
yosay 'Lie on your belly and purr when you are asleep shove bum in owner’s face like camera lens. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball. Cough furball.' --maxLength 26 &&
yosay 'That’s it. Feel free to fire up the server with `npm run start:dev`.'

I would be super happy if @sindresorhus could review that as soon as possible (He’s the one who helped me with #23)
Cause I would love to prepare a release as soon as possible to get these bugfixes out on the street.

You want me to squash the 3 commits before that PR lands into master?

No worries at all. The code here is very complex.
Could you add the above Node.js script as manual-test.js to the repo? So we can run the manual tests to verify whenever.

You want me to squash the 3 commits before that PR lands into master?

No need. GitHub has a squash and merge button now.

I’ve just added the manual-test.jsfile.
Let me know if there is anything else I can do.
Otherwise I would:

Squash and merge
Bump version
Tag Release
Add Release notes to the Release tab here on Github
Ping to npm publish that thing.

Awesome. Thanks for fixing :)

opps. youve done that while I was typing.

Published.
@mischah Could you do 4.? I'm out of time.

You were to fast.
Build fails in older node versions because I used const in manual-test.js :dizzy_face:

Already fixed

ah. okay. man you’re fast like a 🚀

Add Release notes to the Release tab here on Github

Done. Thanks for everything. Highly appreciated what you are doing 💖


Extra files in PyPI sdist

Besides missing a few documentation files (this is arguable, though lacking README.md seems unfortunate), the sdist seems to contain a few extra files:

mapclassify/deprecation.py
mapclassify/flycheck_classifiers (serges-MacBook-Pro.local's conflicted copy 2019-07-03).py
mapclassify/test.py

Ensure the release build doesn't reproduce this error.


Jquery/css included twice on volunteer home page page

*Bootstrap min and the not min file are both included on this page
*Jquery 1.9.1 is included twice (one in /Scripts/, one in/scripts/
*Some of this is included in the head, and some in the body - there isn't really a need for this

Create pull request #254.

Fixed in pull request #254


Encoding UTF-8 Python stdout

OS version and name: Windows 10
Hyper.app version: 1.4.8 stable
Issue
'charmap' codec can't encode character '\u015f' in position 311: character maps to <undefined>
Seem to experience this despite having encoding set and environment variable set. Don't experience this on default cmd.

Did you also set env variable for I/O encoding?
export PYTHONIOENCODING=utf-8
I used to get the same error in other terminals, and setting this variable was the fix.

OS version and name: ubuntu 16
Hyper.app version: 2.1
I have a similar problem. export PYTHONIOENCODING=utf-8 or not I have the error:
export PYTHONIOENCODING=utf-8

[x] I am on the latest Hyper.app version

[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Ubuntu 18.04.1 LTS

Hyper.app version: 2.0.0 (stable)

Link of a Gist with the contents of your .hyper.js: Vanilla Hyper

The issue is reproducible in vanilla Hyper.app: Is Vanilla Hyper

My shell: Xonsh

My .xonshrc
xontrib load add_variable

$PROMPT = '{env_name:{} }{BOLD_YELLOW}{cwd_base}{branch_color}{curr_branch: [{}]} {#f43}{NO_COLOR}🔥 '
$BOTTOM_TOOLBAR = '{BOLD_#66CCCC}{user}{NO_COLOR} on {BOLD_#D6A6FF}{cwd}'
$RIGHT_PROMPT = '{BOLD_#A0FF4C}{timeNow}'
$TITLE = '{hostname}'
$MULTILINE_PROMPT = '`*·.·*'

$PATH.append('/opt/blender-2.79b')
$PATH.append('/opt/android-studio/bin')
$PATH.append('/opt/SoundWireServer')
$PATH.append('/opt/node8/bin')
$PATH.append('/home/erick/.config/composer/vendor/bin')
$PATH.append('/opt/Keep')

I solve it. Add this in my environment variables of my .hyper.js
module.exports = {
  config: {
// ....
env: {
      LANG: 'es_PE.UTF-8' // Or en_US.UTF-8 ... etc
    },
// ...
}


Fix CI/release actions for Windows

I guess for any target platform because in Releases I see "No releases published"


Smilies & emojis

A really common use case for regexes I find online is trying to find & replace all of the emojis in a free form text document with images. However, the quality of the regex varies each time, most often running into issues replacing smiley-like text in places it shouldn't be.
For instance, given a series of smiles: :), :(, and :/. One issue is :/ and full URLs. The regex shouldn't match on http://github.com but many do.

done #7

Very cool, thanks!


db.DB/redis.Client: Details in Address for GetAddr

The idea of a more informative connection information string was brought up in #50. Currently, at least Icinga DB and Icinga Notifications are logging their connection target after startup. This information, however, is quite vague and was now extended to contain, e.g., if TLS is used, the username, the
INFO    icingadb        Connecting to database at 'mysql://icingadb@localhost:3306/icingadb'
INFO    icingadb        Connecting to Redis at 'redis://localhost:6380'

Furthermore, the zapcore.ObjectMarshaler interface was implemented, allowing both *db.DB and *redis.Client to be used as a zap logging field, showing the address.

We could also consider technical strings, e.g. [type[+tls]://]usersname@addr/db: mysql+tls://kubernetes@locahost:3306/kubernetes, user@redis/5.

I actually liked this approach even more. Thus, I have re-introduced the GetAddr method, but now containing all information to produce strings like those. Furthermore, the zapcore.ObjectMarshaler was implemented, allowing the types to be used as zap fields.
Building Icinga DB with this branch results a way more informative output:
INFO    icingadb        Connecting to database at 'mysql://icingadb@localhost:3306/icingadb'
INFO    icingadb        Connecting to Redis at 'redis://localhost:6380'


Setup docker-machine not called in start.sh

There is a method in common.sh that setups docker machine ( for Mac OS X and Windows ) users this isn't called in ./start.sh
Is it assumed that the user will have a docker machine running as 'default' ?

Pretty sure docker installation creates that one.

This is for docker toolbox users. Yes it will be different with docker for mac / windows.

Fixed


Remove custom anchors in favor of anchors auto-generated by doctoc

This PR adds intructions to automatically update the Table of Contents on .md files in the /docs folder on push. The PR appears automatically with the name chore(docs): update TOC as the last commit after push
Bug: T332715

This PR has been closed in favor of #730


Feat:Shift Contact Page Setup from EmailJS to Nodemailer and Send Acknowledgment Mail

Describe the feature
We need to transition the current email handling on the Contact page from EmailJS to Nodemailer. This change is motivated by the need for unlimited mail transfers, which Nodemailer supports. Additionally, the new setup should include functionality to send an acknowledgment email to the person who submits the contact form.
Add ScreenShots
N/A
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[ ] I'm a VSoC'24 contributor
[X] I want to work on this issue

@nishant0708 go ahead

Hope you read the CONTRIBUTING Guidelines.
Please try to add comments about where and what type of changes you made.
Please don't add unnecessary code if there is no need! Thanks :)


Add fixed test case for SR-6141 / rdar://problem/35008570.

Test case from already-resolved SR-6141.

@swift-ci please smoke test and merge


Update scalafmt-core to 3.3.2

Updates org.scalameta:scalafmt-core from 3.3.1 to 3.3.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:n:2

Codecov Report

Merging #1052 (294eb01) into develop (a84caa0) will increase coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 294eb01 differs from pull request most recent head 9731ba5. Consider uploading reports for the commit 9731ba5 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1052      +/-   ##
===========================================
+ Coverage    89.57%   89.58%   +0.01%
===========================================
  Files          124      124
  Lines         9957     9957
  Branches       501      501
===========================================
+ Hits          8919     8920       +1
+ Misses        1038     1037       -1

Impacted Files
Coverage Δ

...in/scala/com/twitter/algebird/CountMinSketch.scala
84.66% <ø> (ø)

...c/main/scala/com/twitter/algebird/Eventually.scala
100.00% <ø> (ø)

...ore/src/main/scala/com/twitter/algebird/Fold.scala
67.21% <ø> (ø)

...main/scala/com/twitter/algebird/ResetAlgebra.scala
100.00% <ø> (ø)

...e/src/main/scala/com/twitter/algebird/Window.scala
96.61% <ø> (ø)

...src/main/scala/com/twitter/algebird/Interval.scala
77.39% <0.00%> (-1.74%)
:arrow_down:

.../main/scala/com/twitter/algebird/Approximate.scala
88.70% <0.00%> (-1.62%)
:arrow_down:

.../scala/com/twitter/algebird/immutable/BitSet.scala
96.35% <0.00%> (-0.43%)
:arrow_down:

.../main/scala/com/twitter/algebird/HyperLogLog.scala
90.04% <0.00%> (+0.43%)
:arrow_up:

.../main/scala/com/twitter/algebird/BloomFilter.scala
95.13% <0.00%> (+1.32%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a84caa0...9731ba5. Read the comment docs.

Superseded by #1053.