File nesting doesn't update correctly

have the config below
have index.ts, index.js, and index.js.map
.js and .js.map are children ✅
from the context menu delete the index.js file
:bug: the index.js.map file is gone

https://user-images.githubusercontent.com/1794099/165513829-2e4f4488-15e9-4fbc-a91b-9f2228297168.mov
"explorer.fileNesting.patterns": {
		"*.ts": "$(capture).js, $(capture).js.map, $(capture).d.ts",
		"*.js": "$(capture).js.map, $(capture).min.js, $(capture).d.ts",
		"*.jsx": "$(capture).js",
		"*.tsx": "$(capture).ts",
		"tsconfig.json": "tsconfig.*.json",
		"package.json": "package-lock.json, .npmrc, yarn.lock, .yarnrc"
	},

Maybe a duplicate of #147987

@jrieken thanks, do you have explorer.fileNesting.expand set to false?

Confirmative


mWeb - Copied check mark is placed to the left of "copied"  in share code inconsistent to the usual right side

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to staging new dot
Go to setting and click on share code
Click on copy to url and observe the  :white_check_mark: mark appears to the left of "copied"
Go to reimbursements and observe that the :white_check_mark: mark is placed at the right of the copied document
Go to security>Two factor authentication and observe that the :white_check_mark: mark is placed next to copied when copying codes

Expected Result:
Check mark placement should be consistent
Actual Result:
Check mark placement is not consistent
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @sofoniasN
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688297288377259
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistencies with copied check mark position
What is the root cause of that problem?
This is due to the rendering of a different component by the ShareCodePage which is this
<ContextMenuItem
                            text={this.props.translate('qrCodes.copyUrlToClipboard')}
                            shouldShowRightIcon
                            icon={Expensicons.Copy}
                            successIcon={Expensicons.Checkmark}
                            successText={this.props.translate('qrCodes.copied')}
                            onPress={() => Clipboard.setString(url)}
                        />

But in other examples, like the reimbursement and QRcode page the copy to clipboard component is resultedly rendered by  component
What changes do you think we should make in order to solve the problem?
The  component in the ShareCodePage should be replaced with this
<PressableWithDelayToggle
            text={this.props.translate('qrCodes.copyUrlToClipboard')}
            tooltipText={this.props.translate('qrCodes.copyUrlToClipboard')}
            tooltipTextChecked={this.props.translate('qrCodes.copied')}
            icon={Expensicons.Copy}
            onPress={() => Clipboard.setString(url)}
        />

What alternative solutions did you explore? (Optional)
None

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0138ee1594d38a0775

I think we can close this, we place the icon where it makes sense depending on the situation, we don't have a "always to the right" rule.


Update RpmTest to Junit5

Resolving issue #32

Converting to JUnit 5
Extracting method for common behavior
Rid of PMD warning suppression
Update puzzle for remaining tasks

@g4s8 PLease assign me

@0crat status

This pull request #36 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @g4s8/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

@0crat status (here)

@HDouss This is what I know about this job in CT2E6TK9B, as in §32:

The job #36 is in scope for 3hr
The role is REV
The job is assigned to @paulodamaso/z for 3hr
There is a monetary reward attached
@paulodamaso/z will get 25% of their hourly rate for this job
The job doesn't have any impediments
The budget is 15 minutes/points
These users are banned and won't be assigned:

@hdouss/z: This user reported the ticket

Job footprint (restricted area)

Job #36 is already in scope

@paulodamaso Fixed. About the last point: the method is just copying a file a store it in the storage. The key/file resource being "dynamic" as it is passed as arg. Besides, this is what have been asked by the issue.

@HDouss Just need to merge changes form master now

@paulodamaso Thanks. Done!

@g4s8 Good to merge

@HDouss thanks, merged. Please try to use more sensible PR titles next time.

@HDouss thanks, merged. Please try to use more sensible PR titles next time.

@g4s8 Sure. Thanks!

Job was finished in 18 hours, bonus for fast delivery is possible (see §36)


[WIP] XUnitReporter

hey @ericf
is there ant way you can check if the generated report is valid in jenkins?
i used this example but i remember that xml args can be tricky
<?xml version="1.0" encoding="UTF-8"?>
<testsuites >
  <testsuite  failures="1" name="__tests__/two-test.js" tests="3">
    <testcase  name="passes" time="1"/>
    <testcase  name="fails" time="3">
      <error  message="Error: expect(received).toBe(expected)
Expected value to be (using ===):
  2
Received:
  1
    at Object.test (/Users/dabramov/fb/jest/integration_tests/custom-reporters/__tests__/two-test.js:2:31)
    at Object.anonymous> (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/build/jasmine-async.js:42:32)
    at attemptAsync (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1984:24)
    at QueueRunner.run (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1939:9)
    at /Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1966:16
    at /Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1909:9
    at Object.fn (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/build/jasmine-async.js:68:11)
    at attemptAsync (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1984:24)
    at QueueRunner.run (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1939:9)
    at QueueRunner.execute (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1927:10)" type="error"/>
    </testcase>
    <testcase  name="nested test" time="0"/>
  </testsuite>
  <testsuite  failures="1" name="__tests__/one-test.js" tests="3">
    <testcase  name="passes" time="0"/>
    <testcase  name="fails" time="1">
      <error  message="Error: expect(received).toBe(expected)
Expected value to be (using ===):
  2
Received:
  1
    at Object.test (/Users/dabramov/fb/jest/integration_tests/custom-reporters/__tests__/one-test.js:2:31)
    at Object.anonymous> (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/build/jasmine-async.js:42:32)
    at attemptAsync (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1984:24)
    at QueueRunner.run (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1939:9)
    at /Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1966:16
    at /Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1909:9
    at Object.fn (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/build/jasmine-async.js:68:11)
    at attemptAsync (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1984:24)
    at QueueRunner.run (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1939:9)
    at QueueRunner.execute (/Users/dabramov/fb/jest/packages/jest-cli/node_modules/jest-config/node_modules/jest-jasmine2/vendor/jasmine-2.5.2.js:1927:10)" type="error"/>
    </testcase>
    <testcase  name="nested test" time="0"/>
  </testsuite>
  <testsuite  failures="1" name="__tests__/three-test.js" tests="1">
    <testcase  name="__tests__/three-test.js" time="0">
      <error  message="Error: failure" type="error"/>
    </testcase>
  </testsuite>
</testsuites>

What do we need to do here to merge this, @dmitriiabramov?

@cpojer i'll need to spend some time on this PR this week to clean it up!

This has been open for a really long time with no activity. @dmitriiabramov mind rebasing and coming back with a new iteration of this?

sure! i'll get back to it later!


HHH-9342 HQL "x member of treat(y as Type).collection" fails to parse

See HHH-9342.
I added a new construction "treatAsPath" in the grammar and used it in the "member of" rule. This solves the specific bug I found. However I’m pretty sure this new construction should be used at other places too.

@sebersole, up for reviewing this one?  I need to stop putting off learning Antlr...

There is already a test for TREAT handling, 2 in fact (1 in hibernate-core and 1 in hibernate-entitymanager):
hibernate-core - org.hibernate.test.jpa.ql.TreatKeywordTest
hibernate-entitymanager - org.hibernate.jpa.test.criteria.TreatKeywordTest

I have tried expanding the visibility of TREAT in HQL grammars, but the problem is that it always leads to ambiguities.  This one works because it is very limited in scope/visibility.
I'll look at this some more.

This will not apply cleanly for me to master, so I am going to have to manually apply the grammar change.  I'll also manually apply the test method to the proper existing class

Rather than a validating semantic predicate, I flipped it and used a gated semantic predicate (with look-ahead) instead to distinguish between the 2 paths.

Applied equivalent changes manually upstream as this would not apply cleanly.


Output is even larger

Happened in latest version of chrome/edge, either png or jpg.

Yeah sometimes it happens, especially when processing optimized images.
I'm afraid I may have nothing to do with this issue, since this project doesn't do any bitmap manipulations :(


Generate test data from our integration tests

Currently we generate signed/failure reports under the test/data/{folder}/{aid} directory. We need to generate the request/response/signed-header/intermediate-data needed for each api call, to be used by @TaniyaBhadauria in her UI tests.

@aydarng will present an initial breakout of additional test data and we'll discuss with @TaniyaBhadauria at tomorrow's daily.

Once @TaniyaBhadauria has added this https://github.com/GLEIF-IT/reg-pilot-webapp/issues/92 then @aydarng will confirm that he can pull down reg-pilot-webapp and run npm run ui-tests so that we can begin modifying and enhancing the test data there.

@aydarng has generated the test data but we need to meet with @TaniyaBhadauria to determine if anything else is needed and to make sure @aydarng can run the scenarios as well. Then the final proof of our integration will be automated tests run from reg-pilot-webapp on every PR/change.


Refactoring: make Editor tree-shakeable

The last remaining big chunk to reduce bundle size (#121). This would be fairly feasible now.
Note to self: the basic idea would be to

Move the editor outside of the ImageAnnotator. Instead, the editor would be injected into ImageAnnotator from index.jsx using a render prop pattern.
index.jsx could then additionally export a HeadlessAnnotorious class. They'd both share the same code, just that HeadlessAnnotorious wouldn't inject the editor. This way (I think) using & bundling HeadlessAnnotorious would not bundle the Editor + widget dependencies.

// Imports normal Annotorious with Editor included
import { Annotorious } from '@recogito/annotorious';

// Imports Annotorious without the Editor, forced to headless mode
import { HeadlessAnnotorious } from '@recogito/annotorious';

Note that this setup would still include Preact as a dependency. This could probably resolved with an additional separation layer, but a bit more complex...

Won't address this in v2 anymore. But will be baked into the design of version 3 (see #191).


[DailyMail] Improve title extraction

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

What is the purpose of your pull request?

[x] Bug fix
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Wrap title in unescapeHTML

@dstftw Does this look good?

@dstftw Good?

Cherry-picked in 111de00289d8c019764e79247568248f8a4b11f6, thanks.


Data not matching other sources of ATLAS photometry on same object, off by 2+ magnitudes

For example, photometry of SN 2022ans does not match the same transient's light curve from non-public (e.g., PESSTO) forced phot of the same location/transient, nor the reported public ATLAS photometry from TNS. We double checked the forced phot coordinates and they are an exact match. So we don't understand why the public forced phot is so much worse.
We just checked several TNS classified Ia's and confirmed this in most of them. See a few more examples below. It's not isolated to just a few however. We have seen it in most light curves we have looked at recently. However, as far as we can recall, this did not use to be the case in the past (maybe 1 month ago?)
This issue is being opened by me on behalf of a group of astronomers who noticed the discrepancy when comparing targets. Could you tell us why there is such a difference? And whether it would be possible to fix it?
Many of these seem much brighter in the public phot, sometimes by ~2 mag. In addition, the public phot often seems to show a very different LC (such as flat instead of rising). But even for those that are rising in both public and private, there is an offset. We took notice because many Type Ia's we've been following seemed to be superluminous according to the public ATLAS phot. I think this occured recently, maybe ~2 weeks ago? But we cannot be sure. This seem to also lead to a disrepancy between the reported photometry on TNS and the ones obtained from falling-star.
Some more cases of TNS Ia's that clearly have wrong photometry, which do not match other ATLAS photometry:

SN 2022rv: https://fallingstar-data.com/forcedphot/queue/152674/
SN 2022afh: https://fallingstar-data.com/forcedphot/queue/155283/

Note, the SN 2022afh is likely having issues with the template? Most are not completely wrong like this. However, you can see the inconsistency with the photometry reported on TNS even for SN 2022rv. There is a 2 magnitude difference. Let me know and I can put together more examples if they are helpful. We found dozens.
Just to re-iterate, the biggest concern for us is the large shift in reported magnitude. With ZTF currently down ATLAS is a main source of SN candidates but getting the wrong photometry by 1-2 mag from the forced phot website makes it difficult to trigger follow-up. We know that in the future the lightcurves could be cleaned up.
Please let me know if you would rather follow up via email. Just wanted to report this to bring it to your attention @lukeshingles.

Hi! We're very glad to see you using the ATLAS forced photometry data. We definitely prefer Github to followup questions like this. It means we can track any required work.
In all the examples above, the "reduced" checkbox was set when the forced photometry was requested. This means you're getting the flux from the INPUT image, NOT the DIFFERENCE image.  Apologies if this is not clear on the interface. Leave the box unchecked if you want difference flux. The forced photometry used by PESSTO is from the difference images.  (It's also stacked.)  If you check the "reduced" box your result will be contaminated by host flux, which is why you're seeing data which is much brighter than you expect. (Input image flux is very useful if the template gets changed during the time the transient was active, or the object is far from the host and you want to follow for a long period of time.)
For the above, I assume you mean 2022afg.  I reran the forced phot for 2022afg and 2022rv with the "reduced" box unchecked (the default option). See:
https://fallingstar-data.com/forcedphot/queue/158725/
and
https://fallingstar-data.com/forcedphot/queue/158727/
Feel free to try a few and get back to us to confirm all is OK or not.  Note that you might not see the same number of points on the lightcurve as in PESSTO because the new Southern ATLAS Telescopes (S. Africa and Chile) are not fully integrated into the forced photometry server (though the data is present for PESSTO). This is not deliberate - the data will be public soon. The southern telescopes are still being commissioned.

Thank you for getting back so quickly. Looks like it was our mistake. We though difference images were for variable stars. And we are eagerly awaiting the integration of the southern telescopes. I will reopen if we notice any other major systematic differences, outside of public/private/stacking etc.


Change _log -> _logger.

Avoid conflicts with tornado.RequestHandler._log.
Fixes takluyver/terminado#18

Thanks! The test failure on Python 3.3 is now reproducible on master, it was probably a change somewhere in tornado.


feature(toast): add typescript definition

Hello,
I have add index.d.ts to toast module for allow use this.$toast in typescript.
Note: This PR is in draft because need this PR : https://github.com/shakee93/vue-toasted/pull/119
Thanks.

Can't wait for it @orblazer :heart_eyes:

Would like this feature to be added as well. Waiting to see if the PR gets merged :-)

They is ready for merge ! They just need update vue-toasted to 1.1.27

Thanks @orblazer


Slider Issues

Not sure if this is something you can fix in your mods GUI or if it is from the native UI?
But certain slider bars won't change number by number or in full numbers... Instead it skips numbers and doesn't allow certain numbers to be reached.

This might be a vanilla issue.
Some of the bars are set to include decimal places as the setting they represent needs decimal places.
If there is a large range to choose from (say 0 - 100) it will make the hit spot for each number quite small.
I am going to add an option to type in the value that you want to make it easier to select the settings.


Allow extensions to support contrib modules

The goal here would be to simplify hooking into the Drupal service container. That may mean an "extension-installer" like PHPStan has


[chainerx] add flip fliplr flipud

Reference: #6423

Jenkins, test this please

Jenkins CI test (for commit 04e4b5aa40a7606490b30ad296fcd3be0faf8f07, target branch master) failed with status FAILURE.

Jenkins, test this please

Jenkins CI test (for commit 04e4b5aa40a7606490b30ad296fcd3be0faf8f07, target branch master) succeeded!

I am unable to figure why pfn-public-ci/chainer.py37.cpu is failing. Could you please take a look.

It seems that the cause is parameterization of lambda functions. That does not work with pytest-xdist.
How about using strs ('fliplr' and 'flipud') instead?

Sure. Sorry for delayed response.

Thanks! Jenkins, test this please

Jenkins CI test (for commit a2001162b95936550177ff13c889510be4e603ce, target branch master) failed with status FAILURE.

LGTM


macos10.15 cannot have it installed. It fails installation.

This is a different issue comparing to https://github.com/RogueAmoeba/Soundflower-Original/issues/96
I migrated my macOS 10.15.4 Catalina from Mac Pro 2013 to a new Mac mini 2018. All kexts are auto-disabled. Soundflower kext driver doesn't come to the System Security Preferences to allow me to allow it. I tried re-running the installer, installation fails; tried uninstall it completely and then install it again, the installer still fails during the installation step, saying that I need to ask the software vendor for assistance.

P.S.: I am fully aware that Soundflower is a driver-only installation.

me neither..

I encountered the same problem today -- at the end of installation after "Validating packages" it says "The installation failed".
I also tried running the installer on the command line to see if I could get a more detailer error, and it gave me:
% sudo installer -pkg Soundflower.pkg -target /
Password:
installer: Package name is Soundflower
installer: Installing at base path /
installer: The install failed. (The Installer encountered an error that caused the installation to fail. Contact the software manufacturer for assistance. An error occurred while running scripts from the package “Soundflower.pkg”.)

hitting with the same error

I encountered the same problem today -- at the end of installation after "Validating packages" it says "The installation failed".
I also tried running the installer on the command line to see if I could get a more detailer error, and it gave me:
% sudo installer -pkg Soundflower.pkg -target /
Password:
installer: Package name is Soundflower
installer: Installing at base path /
installer: The install failed. (The Installer encountered an error that caused the installation to fail. Contact the software manufacturer for assistance. An error occurred while running scripts from the package “Soundflower.pkg”.)

My assumption: Is this a compatibility issue between ZSH and "scripts written for bash only"?

I found the issue. Looks like the following script shouldn't be performed on:

macOS Catalina.
macOS El Capitan / Sierra / High Sierra / Mojave (unless SIP is turned off).

Update: What I mentioned right above this post was the installer script written 6 years ago.
By investigating @mattingalls 's repository and I found this commit:
https://github.com/mattingalls/Soundflower/commit/611f2ebe6cd58eb28a39a2551eea941a21d90b04
However, this is still a no-no on macOS Catalina:

ANY FILE SYSTEM OPERATION WITHIN /SYSTEM/ FOLDER SHALL BE FORBIDDEN on macOS Catalina.
I think the solution can be either adding an OS-check to this post-install script or simply rewrite it for Catalina (and release a Catalina-only installer).

Update: I hacked mattin's latest pkg package and found the latest content of the post-installation script as follows:

Let me test whether "not touching /Library/Extensions" will work with this case.

Ladies and Gentlemen, this is the error output during post-installation when executing kextload:
Last login: Sun Jun 14 09:52:40 on ttys000
 shikisuen@macMini-ShikiSuen  /Library/Extensions  sudo kextload /Library/Extensions/Soundflower.kext
Password:
/Library/Extensions/Soundflower.kext failed to load - (libkern/kext) system policy prevents loading; check the system/kernel logs for errors or try kextutil(8).
 ✘ shikisuen@macMini-ShikiSuen  /Library/Extensions 

At this point, the issue is related to how the kext will be written to handle the Service exited with abnormal code: 1 error. This is far from my ability range.
Calling @mattingalls for help.

Temporary workaround (steps):

Logging into macOS Recovery mode (and log in your macOS admin account if prompted).
Open terminal and run spctl kext-consent add 3G47DU9NXM and reboot your machine.
Reboot back to the macOS and run the Installer again.
-- If prompts for kernel extension permission, approve it.
-- If not (or failed), go to System Preferences and manually approve all kexts from MartinGalls, and then run installer again if necessary. // Previously, his kexts are not shown in the approvable list. However, the terminal command executed in the Recovery OS made his kexts approvable now.

This should be good for all mac computers equipped with a T2-chip.

Before going through Recovery Mode, after failed install it's worth trying System Preferences -> Security & Privacy -> tab General, and "Allow software from developer XXXXX"
More: http://kb.mit.edu/confluence/display/istcontrib/Approving+Kernel+Extensions+for+macOS


Feature request: add an option persistentCache

The uglify cache is very convenient but disappears between each installation, we could have a persistentCache: boolean option that corresponds to cache: path.join (os.homedir (), '.cache', 'uglifyjs-webpack-plugin').
Or maybe we can add it to the readme?

@bertho-zero use https://github.com/webpack-contrib/uglifyjs-webpack-plugin#string , you can change cache path


roadmap rough draft

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66b14af6706cec1dae5f35d9--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66b15022fadd3224db571922--harness-developer.netlify.app


Merge master to live

(Not using "squash and merge" when merging this PR, so that all commits get added individually to live.)

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

.openpublishing.redirection.json
:white_check_mark:Succeeded

README.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-nodejs.md
:white_check_mark:Succeeded

docs/develop/implementation-details.md
:white_check_mark:Succeeded

docs/develop/office-js-versioning.md
:white_check_mark:Succeeded

docs/develop/office-versions.md
:white_check_mark:Succeeded

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded

docs/develop/understanding-the-javascript-api-for-office.md
:white_check_mark:Succeeded

docs/excel/co-authoring-in-excel-add-ins.md
:white_check_mark:Succeeded

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

docs/images/excel-tutorial-create-chart.png
:white_check_mark:Succeeded

docs/images/excel-tutorial-create-table.png
:white_check_mark:Succeeded

docs/images/excel-tutorial-filter-and-sort-table.png
:white_check_mark:Succeeded

docs/images/excel-tutorial-freeze-header.png
:white_check_mark:Succeeded

docs/images/excel-tutorial-ribbon-with-protection-on.png
:white_check_mark:Succeeded

docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-chart.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-table.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-filter-and-sort-table.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-freeze-header.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-protect-worksheet.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Anyone know the exact Fauxbar frequency scoring options to get as close to the Firefox awesome bar as possible?

I personally can’t figure out the frequency settings yet.
I want history items to go to the top after only a few revisits.
Also, if you select in Firefox something after typing “res”, I think that it gets a bonus for other shorter searches.
If I then type “re”, it’s more likely to appear because I selected it after typing “res”.
After selecting an item after using “re”, it’s more likely to appear in the list that comes after typing “r”.
I made it so that there are 30 results.
After I press one letter, an item shows up at #28.
I repeatedly press the letter, select the item, close the tab, press the letter, select the item, close the tab, in the history item never rises to the top like in the Firefox awesome bar.

I assume this is you too:
https://www.reddit.com/r/fauxbar/comments/4492ba/anyone_know_the_exact_fauxbar_frequency_scoring/
I've compared the default values in Fauxbar with the ones in Firefox.
'Sampled Visits', 'Bucket Weights' and 'Bucket Cutoffs' are all equal.
The 'Transition Bonuses' that match the ones in Firefox are all equal.
However there's a catch. Chrome do not have the same behavior as Firefox when it comes to the 'Transition Bonuses'. This can cause inconsistencies.
I vaguely remember having issues with this when I rewrote Fauxbar from scratch for fun. Can't check that code. Sadly that code is on a hard drive that may be lost. It is a hybrid drive and the SSD part started to fail. I need a dual drive docking station for SATA laptop and desktop drive to try and recover the data and clone it to a new drive and a new hard drive to clone it to. Anyway...
At the time I found it was nearly impossible to compensate for the difference in behavior. I did file a few bug reports since I found bugs in what transition type was used and such. As usual the bug reports was ignored. Typical of Chrome development team. This was a few months ago to some years. Don't know if they ever did anything about those bugs.
I have not done any tests for if I can write some code for Fauxbar that can compensate for this since your description lacks details and precise steps of how to reproduce your issue from a clean profile and the steps you took in Firefox (assuming clean profile).

Hi guys. Fauxbar dev here.
One thing that might affect the result placement is if Chrome's URL prefetch is getting triggered, which might be affecting what you're expecting? You can disable the setting in Fauxbar to not use it; maybe it would have some effect.
Unless I overlooked something at the time, I think my interpretation of the frecency algorithm was good enough at least; results seemed to be high enough as expected. I did have an idea to perhaps allow the user to right-click on a result and choose "Increase this result's frecency score" just to help make a result always appear at the top for you, but never got around to implementing it.
From memory, I made favorites have a slightly higher value than what the original frecency algorithm; a personal preference I guess.
There's also the case that Fauxbar doesn't automatically degrade saved values over time automatically like Firefox does, since I don't have a service running now and then to do that, nor did I want to force the user sit through the reindexing process without their consent. So sites that you used to visit lots but never visit anymore; their values will always remain higher unless you force Fauxbar to reindex.
I should probably fix the HTML5 notification errors that Fauxbar throws when it first starts.
Admittedly, years ago, I lost interest in maintaining Fauxbar when Google would change their APIs. Got tired of playing whack-a-mole to fix things. The final straw was when Chrome removed the ability to let New Tab Pages focus the Omnibox; I devised the "close the tab then create a new tab that I can actually steal focus from" method, but to this day I'm still not happy with it.
I'm also not happy with Chrome how, if you press F+Space, enter your search query and select a result, how the caret keeps blinking; really annoying.
But yeah, lost so much interest that I let the fauxbar.org domain lapse. Stopped checking the gmail account for bug reports. Looking back, I was suffering from depression which didn't help things. So it just sort of sat there. And then Google announced they were closing Google Code down, so I thought I ought to at least preserve the code and copy it over here to GitHub.
Also at the time, Chrome did not allow developers to monetise extensions, and my Donate button was scarcely used. Being compensated for time and effort is nice, but that wasn't really available at the time... And feature creep seemed to be getting the better of me. Bug reports. Requests.  So throw in all these factors and my attitude toward the project, I just left it alone.
But, I dunno. Times change. I still use Fauxbar. Depression's gone. My motivation is with other things though. Perhaps I'll fix up the couple of notification bugs that get thrown. Apart from checking the URL prefetching, not sure what else to suggest.


[Fix #204] Add Performance/Sum option to ignore potential false positives

Some codebases may contain non-numeric classes which implement a :+ method.
If a, b and c are objects of such a class, then certain corrections
do not apply:
[a, b].reduce(c, :+) # is equivalent to
[a, b].sum(c)

[a, b].map(&:to_i).sum # is equivalent to
[a, b].sum(&:to_i)

[a, b].reduce(:+) # works
[a, b].sum # raises TypeError

For users who wish to only register offenses where auto-correction
is unproblematic, we add the option OnlySumOrWithInitialValue
to the Performance/Sum cop.
The option is disabled by default, so standard behavior is preserved,
and can be activated by setting OnlySumOrWithInitialValue: true.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


Is it A Tree?

Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Check if a graph is a tree using DFS Algorithm.
Checklist

[Yes] I've read the contribution guidelines.
[Yes] I've checked the issue list before deciding what to submit.
[Yes] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#5056

Please make an issue here and raise a PR, for an article as part of our Docs repository: https://github.com/TesseractCoding/NeoAlgo-Docs
It would be much appreciated. Thanks!


apply resolve-dir only to relative path names

The current implementation of the --resolve-dir option prefixes an image path passed on the command line unconditionally:
https://github.com/PRImA-Research-Lab/prima-page-viewer/blob/ad75ac2dc1b81701f529291bcebdd901d716a455/src/org/primaresearch/page/viewer/PageViewer.java#L72-L73
This is not correct IMHO: On the command line, relative paths should resolve to the CWD, and absolute paths should not be prefixed by anything.
In contrast, image paths parsed from the XML are already prefixed correctly:
https://github.com/PRImA-Research-Lab/prima-page-viewer/blob/ad75ac2dc1b81701f529291bcebdd901d716a455/src/org/primaresearch/page/viewer/dla/XmlDocumentLayoutLoader.java#L72-L74

Seems reasonable. Do you have something I can put in? I don't have access to the office at the moment and don't have Eclipse set up at home. Remote desktop is sluggish and I can only do minimal tasks


[3.x][POC] 1305 unsaved changes indicator

Description
This is just splitting the indicator from #1359

The new UX implementation probably will require a bit of rework.
The new design uses a custom UI alert when leaving "unsaved changes"
heres the new UX/UI for the alert:

currently the alert is being triggered via beforeunload but this wont work for a custom alert. I believe their will need a refactor of all links and buttons to watch for change state of state.publication.hasUnsavedChanges


fix: image preview display error when image.alt includes '<' or '>'

Description
Describe the bug
When specifying a preview image in a post,
if you specify a value of < or > for alt, the image will not display properly because it encroaches on the HTML tag range.
To Reproduce

Create a new post.
In the post properties, write image.alt to contain < or >, as follows

example

image:
  path: /commons/devices-mockup.png
  alt: get device image -> show mockup

Expected behavior && Logs/Screenshots

At Home (root path)

At Post

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (refactoring and improving code)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Additional context

How has this been tested

[X] I have run bash ./tools/test (at the root of the project) locally and passed
[X] I have tested this feature in the browser

thanks you for suggestion.


Board config updates

Updates to the board config files + small fixes.
Flatbox Rev 5 RGB - Updated to remove assigned to addon warning on for PLED chain order + removed GPIO11 which was not assigned to anything
Mavercade - Removed EXTRA_BUTTON_MASK and replaced with new pin mapping system
Open_Core0 WASD - Added GPIO08 to assigned to addon section for board LEDs
SGF Bridget - Added HAS_I2C_DISPLAY 0 to address bug with board LEDs
SGF Faust - Added HAS_I2C_DISPLAY 0 to address bug with board LEDs

Looks good, I'll wait until the build finishes and merge in.


perf(project): optimize SVGs

Resolve #1149
How do I optimize those files?
npm i -g svgo
cd flat			# Enter the project root
svgo --multipass -rf ./

Diffs preivew

Click here to expand

Before
After

this is GREAT!!
It might be better if we could use it as an automation. (see: https://github.com/netless-io/flat/blob/main/.husky/pre-commit)

It might be better if we could use it as an automation.

We can lint SVGs with https://github.com/birjolaxew/svglint in another PR.


[IOS]Modify text input Chinese association limited BUG

Keyboard input text limit is no problem, but Chinese input for lenovo
function, so text limit invalid problem.Now I put it in the input
method for Chinese change into the model, more than words could not
enter

@nicklockwood would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

I'm not sure I understand the description of this pull request, sorry. What does the check for _maxLength fix?

It looks like this pull request has been abandoned so I am going to close it. Feel free to reopen if there is still an issue here that you want to fix, though.


autotune service: fix typing

We need to fix some type mismatch in the current implementation:
autotune_system_hyperparameters: Function IntParam.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, val, space_dimension: Tuple[int, int])
  Actually passed: (self, val, space_dimension: List[int])
File "/github/workspace/bagua/autotune/__init__.py", line 173, in autotune_system_hyperparameters: Function IntParam.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, val, space_dimension: Tuple[int, int])
  Actually passed: (self, val, space_dimension: List[int])
File "/github/workspace/bagua/autotune/__init__.py", line 180, in autotune_system_hyperparameters: Function IntParam.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, val, space_dimension: Tuple[int, int])
  Actually passed: (self, val, space_dimension: List[int])
File "/github/workspace/bagua/autotune/__init__.py", line 187, in autotune_system_hyperparameters: Function IntParam.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, val, space_dimension: Tuple[int, int])
  Actually passed: (self, val, space_dimension: List[int])

#67 style: fix pytype warnings


Concurrent builds in the same project fail due to single name for build archive

Found while investigating #22 , If building two different applications in the same folder, they would create a similarly named "___bundle.zip" file used for building. This should be updated to use a unique name for different applications.

fixed in v0.4.0, temporary build archives have timestamped filenames to avoid conflicts when building multiple applications concurrently.


Configure examples to show on build time

Unless I overlook something, there is no way to configure the examples to appear on the noflo-ui home page. They seem to be hardcoded in noflo-main.html, with no way to override them. It would be useful to configure them when noflo-ui is built, so that examples can be customized, e.g. for new runtimes or for personal examples.
What would be the best solution for you? There is an examples.json file in the project root which doesn't seem to be used anywhere... It would be nice to include it in noflo-main.html someway. The easiest way I can think of is to define a $NOFLO_EXAMPLES_JSON variable in the Gruntfile loading examples.json and using it in noflo-main.html, but it seems a bit hackish. What do you think?

Yeah, this could use refactoring. Ideally we'd have a YAML/JSON file per known runtime, and derive runtime settings, docs, and examples list based on it

Some initial work on moving to YAML files  in runtimeinfo branch.

See #619 for start of moving to declared runtime info.
Could then add a key examples to the runtime info YAML, putting the existing examples from noflo-main, and then populate the examples list from this information at runtime.

That's great to know! Is there any way I can contribute?

If you're willing to give it a shot, fork noflo-ui, checkout the runtimeinfo branch and make the changes described. Then push to a new branch and make a pull request of it.

Will do that tomorrow!

@ruippeixotog cool! I've pushed the changes to master now, so no need to checkout a special branch.


Implement multi-type search for apps+websites (bug 1149995)

https://bugzilla.mozilla.org/show_bug.cgi?id=1149995
Sorting results by relevancy works, but most of the rest of the sort options are semi-broken either because the corresponding field does not exist in websites mapping (rating, reviewed, name_sort)
or because it's empty (popularity, trending). A follow-up bug will take care of those.

r+wc. Nicely done.


Callback/EOI never returns

I have a similar problem to #94 where invoke() does not return. The problem is intermittant. In my application I have 4 instances of a Vue component which each instantiate their own Shell and call Get-Service. As you can see below, 3 of the 4 processes return whilst the 4th (PID 15456) does not. Repeat and only 2 return. About one in 10 times all 4 return.
Here's the code: https://github.com/cawoodm/powershell-servicemanager

Could it be that the EOI detection is shaky? How does it work exactly?

I think I see the problem - you create a random string called EOI which looks like this EOI_llKGpOg8x and then you write it out using powershell after all other commands [Console]::Out.Write("${EOI}").
The problem is that this line is not always streamed on it's own but sometimes together with the user's commands so _write get's something like this:
[{"Name":"Fax","Status":1,"DisplayName":"Fax","StartType":3,"CanStop":false},{"Name":"SysMain","Status":4,"DisplayName":"SysMain","StartType":2,"CanStop":true},{"Name":"WSearch","Status":4,"DisplayName":"Windows Search","StartType":2,"CanStop":true}]
EOI_llKGpOg8x

But it expects this separately like this:
[{"Name":"Fax","Status":1,"DisplayName":"Fax","StartType":3,"CanStop":false},{"Name":"SysMain","Status":4,"DisplayName":"SysMain","StartType":2,"CanStop":true},{"Name":"WSearch","Status":4,"DisplayName":"Windows Search","StartType":2,"CanStop":true}]

EOI_llKGpOg8x

Whether the output is streamed together or not is up to child_process and out side our control.
So this line in utils.js fails:
if(chunk.compare(this.EOI) === 0) {
   cb();
   return this.emit('EOI');
}

It's doing a direct, absolute compare where it should be looking for the EOI string on a single line.

OK, I think we have a fix:
_write(chunk, encoding, cb) {
// HERE
    if(chunk.indexOf(this.EOI) >= 0) {
      this.chunksArray.push(chunk);
      cb();
      return this.emit('EOI');
    }
    this.chunksArray.push(chunk);
    return cb();
  }
  isEmpty() {
    return this.chunksArray.length === 0;
  }
  getContents() {
    return Buffer.concat(this.chunksArray);
  }
  getContentsAsString(encoding = 'utf8') {
// AND HERE
    return Buffer.concat(this.chunksArray).toString(encoding).replace(/\0/g, '').replace(this.EOI,'');
  }

@cawoodm I'm not sure if that is a fix, e.g. something trivial like printing $host (in PowerShell) results in same issue with the never returning. Also, with your changes in https://github.com/cawoodm/node-powershell/commit/863ef27896d1893bf4ea844deaff747c42891e86 a lot of the output is truncated (still using $host as an example).

It works for my application, feel free to improve on it.

 Fix invoke() promise never resolves bug


Useful error for transfer functions with non-monotonic scale factors

Closes #823
This is actually documented, but at least now we'll throw a more useful error.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 97.504%

Totals

Change from base Build<PHONE_NUMBER>:
0.002%

Covered Lines:
4843

Relevant Lines:
4967

💛  - Coveralls

LGTM


chaosmeta-platform:support chaos engineering experiments

Add the part of chaos engineering experiment in chaosmeta-platform, which refers to the experimental scene formed by the combination of certain failure nodes, which can be arranged in the experiment

done


CORS Error while loading the context

I've set up pcp-webapi to listen on port 44323 and started pcp at all. When I try to access vector, delivered by httpd on port 80, I see the following error in the javascript console:
[Error] XMLHttpRequest cannot load http://myhost.local:44323/pmapi/context?hostspec=localhost&polltimeout=600. Origin http://myhost.local is not allowed by Access-Control-Allow-Origin. (vector, line 0)

Since pcp-webapi doesn't set any CORS header, the different port causes the issue. If I disable CORS checking in the browser, vector works fine. Now I'm wondering if there isn't anyone having similar problems. As I can see in the wiki, the desired configuration is also to use different ports. How can this work? Or am I am doing something wrong?
Thanks for any advice.

pmwebd since 3.10.0ish (2014-10-31) does supply CORS headers on responses to the /pmapi calls.

hmpf, I use 3.9.4 from Scientific Linux 6 repo. But this means that 3.10 is a minimum version requirement for vector!? Otherwise I would need to proxy pcp requests through my webapp.

It turns out that you can probably use vector even with that old pmwebd, if you serve the static webapp itself via pmwebd (rather than an auxiliary web server) by copying the app/ under some directory, and ensure pmwebd is started with "-R $THAT_DIRECTORY".

Oh, ok, I should definitely have a closer look at the cmwebd configuration options. Thx!


Multiples items are selected by default

Hi, first off most grateful for such an awesome plugin.
However, after installing everything, I realised that when a user clicks on an item to select just one, multiple items are selected at a time. I tried the [multiple]="false" feature on the API and it is still not working.
Secondly, is there a way to tweak the styles, for instance, remove the radio buttons?
Thank you and once again biggups for such a great plugin!

Hey, I have seen where the problem was. It had got to do with the [itemValueField]; once it was the same across the data set, the selection became multiple, irrespective of the [multiple] directive value set. Thanks.

No problem 😆


Fix Vulcanization on Heroku by Adding to the Postdeploy Process in App.json

The vulcanization script won't create the necessary file when run after deploying to heroku so I've made it part of the deployment in app.json. This also adds vulcanization to the dependencies in package.json so that it is already available without having to be installed manually.

Very nice!

:+1:


assets in duplicate paths between root and public will be divided into the same path in the assets tab

description
assets in duplicate paths between root and public will be divided into the same path in the assets tab
I'm not sure if this behavior is expected.

reproduction URL: https://stackblitz.com/edit/vitejs-vite-eonmde

public is a special directory, maybe we can mark it in the UI to tell users this is a public directory.

public is a special directory, maybe we can mark it in the UI to tell users this is a public directory.

Could it be better to distinguish public assets with the prefix public which may be <somepath>/a.svg and public/<somepath>/b.svg?

It's kinda counterintuitive yet designed, that's because we want to follow the behavior of vite. Most people are unlikely to encounter this situation. I think putting a badge on the public resources is a good solution now.

Do you think the grouping mode shown above is a good solution? If so, I will continue to change the list view, otherwise, adding a badge is better. Hope for your advice.

Hmm, it's good I think


PR-Test scan-DO NOT MERGE

Required items, please complete
Change(s):

See guidance below

Reason for Change(s):

See guidance below

Version Updated:

Required only for Detections/Analytic Rule templates
See guidance below

Testing Completed:

See guidance below

Checked that the validations are passing and have addressed any issues that are present:

See guidance below

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

@rushriva,
Can you please confirm - whether to merge the changes part of this PR or not.
Thanks

@rushriva please confirm  can we close this PR ? as you mentioned its for test purpose only.

Closing this as confirmed with @rushriva, thanks.


Consider Adding Topic: PHP Standards

See #265

Where might such a section be added to the Webguide, as I'm not really seeing a place for all of these possibly new topics to be added into the menu structure.
My other concern on creating the content for the section, is that as a php expert -- what scope(s) should be covered in such directions. I imagine directions such as:

Look to your projects platform guidelines, best practices and coding style when developing a PHP based site. Such platforms such as the Drupal CMS, Wordpress and others contain their own guidelines which are considered a best-practice to follow. For custom built applications it's recommended to follow the PHP-FIG guidelines.

... any thoughts on these ideas? -dg

Yeah, I actually don't think this should be added to the web guide at all.
While we do touch on some concerns that are arguably server-side-focused (friendly URLs, e-mail address contact forms, character encoding headers, etc.), I think the focus of the guide is primarily front-end standards and we're going to open a can of worms trying to tackle standards for server-side languages and frameworks.
Having said that, I'm totally open to what the group thinks is best.

I vote we close this topic as outside the current focus of the guide.
(if I could I would label this as "invalid" maybe to easily reference these issues in our next WSG meeting)

I like the directions that @tenken lists above. For the Drupal coding standards, we could link to https://www.drupal.org/docs/develop/standards/coding-standards and to similar documentation for WordPress.
But, @loganfranken is right, we would be opening a can of worms by including PHP standards in the Web Guide. I'll label this as "invalid."


Any plans to support something other then inline styles like PostCSS, CSS Modules and node-sass?

Is there any reason why all Styling examples use inline CSS solutions?
Are there any plans to support popular pre-processors like node-sass, PostCSS or CSS Modules?
Is there a way to preprocess and use those for universal/server rendering?
CSS Modules is a popular solution for modular CSS (obviously...:), Many PostCSS plugins like rucksack for responsive font-size, px-to-rem and autoprefixer among others are indispensable...
Is there a way to use postcss and add its configuration to the underlying webpack config?
Is it possible to get an idea or better yet - an example or a guide that demonstrate how precompile/preprocess those solutions using them with Next 2.0.0-beta.xx ?
Thank you so much!
Ajar

I think you can just compile CSS before starting next and load the generated file using <Head /> or custom Document. Do you like to know something else ?

@Ajar-Ajar check this PR and issues mentioned in that.
See: https://github.com/zeit/next.js/pull/638

I stopped using sass and css files, but when I did use them I was doing what @nkzawa suggested. I made a head component that acted as a wrapper for next/head to handle easily loading defaults/globals such as a main.css stylesheet. It accepted props and children to change the page title and extend it (e.g: adding another stylesheet file to the head etc.)

Closing this based on given answers. Feel free to re-open when needed ❤


Serve all the vendor fonts and font-awesome locally

This way, all the font-awesome related stuff will be served locally, instead of
bootstrap's CDN. This is important if we want Portus to be available in setups
that don't have access to an external network.
Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

lgtm

I've updated the PR so it also includes other missing vendor fonts.

@Salzig you're right. I've updated the patch.

I think this can be merged right now.


provide a --path flag for outdated

Provide a --path flag for outdated so that I can check for outdated gems installed at a different location.

You might have some success with setting BUNDLE_PATH (not that you shouldn't want --path added)...

We're trying to move away from adding all of the flags to every command, so I would recommend setting BUNDLE_PATH for now

ok I will try that.

I'm closing this for now. If you have any more question feel free to open a new issue.


Explain how we use Github at the NLeSC.

Projects in own GitHub organization, etc.

Thanks, looks good.


Double sigmoid

In this line, torch.mul(edges.data[attention_score], torch.sigmoid(edges.data[gate])), you call torch.sigmoid on edges.data[gate], for gate=e_gate. But e_gate is calculated in this line as:
g.edata['e_gate'] = torch.sigmoid(e_gate.view(-1, self.num_heads, self.out_dim))

So you execute torch.sigmoid twice, whereas you intended to call it only once, like you did here.
Isn't this a bug ?

Hi,
Thank you for pointing out this issue. It is a bug. However, so far, we do not have recourse to retrain the model. You still can use this model for inference, all our paper's results and CASP15 results were generated by this model.  But if you want to train your own data with DProQA, you need to modify the code to remove the additional sigmoid function.
Best,


Add jamba classfication

[Model] Add support for embedding model JambaClassfication](https://github.com/vllm-project/vllm/pull/10858)

Thanks for adding this, do you have a HF repo that we can refer to? Don't forget to update the Supported Models page.

We have a test model that can be used to test the functionality of the code:
https://huggingface.co/ai21labs/Jamba-tiny-reward-dev

We have a test model that can be used to test the functionality of the code: https://huggingface.co/ai21labs/Jamba-tiny-reward-dev

Thanks for this! I'll update the PR accordingly so that the model tests can pass.

@DarkLight1337 - DCO is the only failing check. Can this get a force merge?

Actually, I just realized that this model supposed to be a reward model, not a classification model... should we rename the model?


Changed the feed to a masonry layout

#54
The layout is also responsive to the screen size, as seen in the images below.

@Fangston0 Resolve the Conflicts


Issue with the Evaluation Refresh Logic

Issue:
The Evaluation Status of Passed and Error shouldn't be included in the logic for the refresh timer. Currently the 2 statuses are added to the code
Resolution:
Logic should only account for the In Queue (INQ) and WIP statuses when considering the refresh for Evaluation. For any other status, the timer shouldn't be refreshed
Testing:
Use Network traffic and review the refresh statuses where it should only happen when the Evaluation is in Progress or In Queue (Refresh should happen every 5 seconds). Refresh shouldn't happen every 5 seconds for Evaluation Status = Informational Message/Passed/Critical Errors

Bug Fixed


Bump external-attacher to v4.4.0

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


Detecting Moonlight for Mi LED Desk Lamp

Hi，
My Mi LED Desk Lamp (first version) is not support moonlight mode but the log gives me
[4/25/2020, 22:20:51] [Yeelight] Device lamp1-f6db90 supports moonlight mode
[4/25/2020, 22:20:51] [Yeelight] Device lamp1-f6db90 supports brightness
[4/25/2020, 22:20:51] [Yeelight] Device lamp1-f6db90 supports color temperature
the moonlight mode switch is useless for my device and it is kind of  annoying :(
Any way to fix it or disable moonlight mode form config in homebridge?
Thx ;)

Hey @seanzhang98 , sorry to reopen an old thread but I have the same Mi LED Desk Lamp and I'm unable to see it in HomeKit, I've tried this plugin and many others. I'm sure my token is the right one (followed the exact steps).
Is yours still working with this plugin? Anything you've done in particular?
Thanks!

hi @Jafalex , mines is working properly for a while, noting specific steps are required. I personally made some modification of the codes so the moonlight function will not shown in Home app. ￼


Monitoring error: "BT_HCI: hci write adv params error"

Hey all,
I am trying to use nkolban's SampleRead.cpp on esp-idf-template on Ubuntu.
I have done the following:

Cloned esp-idf-template to "ble-test" folder
Created components folder in "ble-test" and copied cpp_utils to components folder
Edited and copied main.cpp & SampleRead.cpp into main folder
deleted main.c
modified set(COMPONENT_SRCS "main.c") to set(COMPONENT_SRCS "main.cpp") in CMakeList.txt in main folder
ran make menuconfig and enabled bluetooth & c++ exceptions

There was an error while compiling. I noticed the extra brackets at line 99 & 100 in BLEUUID.cpp and deleted them. Then I was able to compile successfully.
I used nRF on my android phone and was able to connect to my ESP32 board and see that the time increases every time I read on my phone.
Doing 'make monitor' returns the following error:
Toolchain path: /home/james/esp/xtensa-esp32-elf/bin/xtensa-esp32-elf-gcc
Toolchain version: crosstool-ng-1.22.0-80-g6c4433a
Compiler version: 5.2.0
Python requirements from /home/james/esp/esp-idf/requirements.txt are satisfied.
MONITOR
--- idf_monitor on /dev/ttyUSB0 115200 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:6164
load:0x40078000,len:10168
load:0x40080400,len:6552
entry 0x40080764
I (28) boot: ESP-IDF v3.2-beta1-151-g960c24057 2nd stage bootloader
I (28) boot: compile time 17:11:40
I (28) boot: Enabling RNG early entropy source...
I (34) boot: SPI Speed      : 40MHz
I (38) boot: SPI Mode       : DIO
I (42) boot: SPI Flash Size : 4MB
I (47) boot: Partition Table:
I (50) boot: ## Label            Usage          Type ST Offset   Length
I (57) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (65) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (72) boot:  2 factory          factory app      00 00 00010000 00100000
I (80) boot: End of partition table
I (84) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x3c5f4 (247284) map
I (180) esp_image: segment 1: paddr=0x0004c61c vaddr=0x3ff80000 size=0x00000 (     0) load
I (180) esp_image: segment 2: paddr=0x0004c624 vaddr=0x3ff80000 size=0x00000 (     0) load
I (186) esp_image: segment 3: paddr=0x0004c62c vaddr=0x3ffbdb60 size=0x02dd0 ( 11728) load
I (200) esp_image: segment 4: paddr=0x0004f404 vaddr=0x3ffc0930 size=0x00000 (     0) load
I (204) esp_image: segment 5: paddr=0x0004f40c vaddr=0x40080000 size=0x00400 (  1024) load
0x40080000: _WindowOverflow4 at /home/james/esp/esp-idf/components/freertos/xtensa_vectors.S:1685

I (213) esp_image: segment 6: paddr=0x0004f814 vaddr=0x40080400 size=0x007fc (  2044) load
I (223) esp_image: segment 7: paddr=0x00050018 vaddr=0x400d0018 size=0xa44d0 (672976) map
0x400d0018: _flash_cache_start at ??:?

I (466) esp_image: segment 8: paddr=0x000f44f0 vaddr=0x40080bfc size=0x11060 ( 69728) load
I (496) esp_image: segment 9: paddr=0x00105558 vaddr=0x400c0000 size=0x00000 (     0) load
I (496) esp_image: segment 10: paddr=0x00105560 vaddr=0x50000000 size=0x00000 (     0) load
I (503) esp_image: segment 11: paddr=0x00105568 vaddr=0x50000000 size=0x00000 (     0) load
I (522) boot: Loaded app from partition at offset 0x10000
I (522) boot: Disabling RNG early entropy source...
I (523) cpu_start: Pro cpu up.
I (527) cpu_start: Starting app cpu, entry point is 0x4008103c
0x4008103c: call_start_cpu1 at /home/james/esp/esp-idf/components/esp32/cpu_start.c:245

I (0) cpu_start: App cpu up.
I (537) heap_init: Initializing. RAM available for dynamic allocation:
I (544) heap_init: At 3FFAFF10 len 000000F0 (0 KiB): DRAM
I (550) heap_init: At 3FFB6388 len 00001C78 (7 KiB): DRAM
I (556) heap_init: At 3FFB9A20 len 00004108 (16 KiB): DRAM
I (562) heap_init: At 3FFBDB5C len 00000004 (0 KiB): DRAM
I (569) heap_init: At 3FFCAB08 len 000154F8 (85 KiB): DRAM
I (575) heap_init: At 3FFE0440 len 00003AE0 (14 KiB): D/IRAM
I (581) heap_init: At 3FFE4350 len 0001BCB0 (111 KiB): D/IRAM
I (587) heap_init: At 40091C5C len 0000E3A4 (56 KiB): IRAM
I (594) cpu_start: Pro cpu start user code
I (277) cpu_start: Starting scheduler on PRO CPU.
I (0) cpu_start: Starting scheduler on APP CPU.
I (347) BTDM_INIT: BT controller compile version [ac67b34]
I (357) system_api: Base MAC address is not set, read default base MAC address from BLK0 of EFUSE
I (427) phy: phy_version: 4000, b6198fa, Sep  3 2018, 15:11:06, 0, 0
W (967) BT_BTC: btc_gatts_arg_deep_copy 8, NULL value
I (967) BLEDevice: create advertising
E (977) BT_HCI: hci write adv params error 0x30

Any suggestions on how to fix this error are appreciated.

Already answered in esp-idf. You can change code like this in BLEAdvertising.cpp:
	m_advParams.adv_int_min       = 0x20;
	m_advParams.adv_int_max       = 0x40;
	m_advParams.adv_type          = ADV_TYPE_IND;
	m_advParams.own_addr_type     = BLE_ADDR_TYPE_PUBLIC;
	m_advParams.channel_map       = ADV_CHNL_ALL;
	m_advParams.adv_filter_policy = ADV_FILTER_ALLOW_SCAN_ANY_CON_ANY;
	m_advParams.peer_addr_type    = BLE_ADDR_TYPE_PUBLIC;  // <-- this fix that bug

Already answered in esp-idf. You can change code like this in BLEAdvertising.cpp:
	m_advParams.adv_int_min       = 0x20;
	m_advParams.adv_int_max       = 0x40;
	m_advParams.adv_type          = ADV_TYPE_IND;
	m_advParams.own_addr_type     = BLE_ADDR_TYPE_PUBLIC;
	m_advParams.channel_map       = ADV_CHNL_ALL;
	m_advParams.adv_filter_policy = ADV_FILTER_ALLOW_SCAN_ANY_CON_ANY;
	m_advParams.peer_addr_type    = BLE_ADDR_TYPE_PUBLIC;  // <-- this fix that bug

Thanks alot! Running make monitor does not return error now.
However, the monitor does not get updated when I connect to the ESP32 board on my android phone or when I READ/WRITE value to it.
The last line of the monitor is always I (976) BLEDevice: create advertising

Without more info i have no idea.

Monitoring is not being updated because I had 'Info' for log verbosity. I see now that nkolban had 'Verbose' as his log verbosity. So I changed the log verbosity, but I have the following error keep repeating now:
`
rst:0x3 (SW_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:6164
load:0x40078000,len:10168
load:0x40080400,len:6552
entry 0x40080764
I (56) boot: ESP-IDF v3.2-beta1-151-g960c24057 2nd stage bootloader
I (56) boot: compile time 16:27:37
I (57) boot: Enabling RNG early entropy source...
I (63) boot: SPI Speed      : 40MHz
I (67) boot: SPI Mode       : DIO
I (71) boot: SPI Flash Size : 4MB
I (76) boot: Partition Table:
I (79) boot: ## Label            Usage          Type ST Offset   Length
I (86) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (94) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (101) boot:  2 factory          factory app      00 00 00010000 00100000
I (109) boot: End of partition table
I (113) esp_image: segment 0: paddr=0x00010020 vaddr=0x3f400020 size=0x4ef54 (323412) map
I (235) esp_image: segment 1: paddr=0x0005ef7c vaddr=0x3ff80000 size=0x00000 (     0) load
I (236) esp_image: segment 2: paddr=0x0005ef84 vaddr=0x3ff80000 size=0x00000 (     0) load
I (242) esp_image: segment 3: paddr=0x0005ef8c vaddr=0x3ffbdb60 size=0x01084 (  4228) load
I (253) esp_image: segment 4: paddr=0x00060018 vaddr=0x400d0018 size=0xb57b0 (743344) map
0x400d0018: _flash_cache_start at ??:?
I (520) esp_image: segment 5: paddr=0x001157d0 vaddr=0x3ffbebe4 size=0x01d48 (  7496) load
I (523) esp_image: segment 6: paddr=0x00117520 vaddr=0x3ffc092c size=0x00000 (     0) load
I (527) esp_image: segment 7: paddr=0x00117528 vaddr=0x40080000 size=0x00400 (  1024) load
0x40080000: _WindowOverflow4 at /home/james/esp/esp-idf/components/freertos/xtensa_vectors.S:1685
I (536) esp_image: segment 8: paddr=0x00117930 vaddr=0x40080400 size=0x11878 ( 71800) load
I (575) esp_image: segment 9: paddr=0x001291b0 vaddr=0x400c0000 size=0x00000 (     0) load
I (575) esp_image: segment 10: paddr=0x001291b8 vaddr=0x50000000 size=0x00000 (     0) load
I (581) esp_image: segment 11: paddr=0x001291c0 vaddr=0x50000000 size=0x00000 (     0) load
E (591) esp_image: Image length 1151472 doesn't fit in partition length 1048576
E (598) boot: Factory app partition is not bootable
E (604) boot: No bootable app partitions in the partition table
ets Jun  8 2016 00:22:57
`

You need to change partition in options. Most likely to large (No OTA).

You mean 'Single factory app, no OTA'? My partition table was already set to that.

Sorry, i assumed you are working with arduinom i should look more thorough on logs. In such case you need custom partitions file. But before that check if you have in menuconfig set flash size to 4MB. Its by default 2MB.
If that wont help here is simple partitions.csv:
https://gist.github.com/chegewara/68bf2b24fc12def3fcaa01ca549149fe

Thanks a lot. You partition table worked.


Small game launch related fixes

First one makes sure the save path is for the current game, instead of the previous one in init. Fixes a bug where if you exited a game with saves, the launcher would load that as it's theme...
Second one prevents games launched from flash from getting whatever that least launch path was... or junk...

Haha, who'd have thunk the launcher theme support would find the bugs! Thank you.

Haha, who'd have thunk the launcher theme support would find the bugs! Thank you.


fix: module name is not shown for esm.sh

Example: https://github.com/hasundue/denopendabot/commit/a970cc83343b9082467b66a8a9928e61ad82cf89

Done by #1490


The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method.

Hi,
I'm trying to generate a signed URL that I can use in my UI to display an image <img src=<signed_url> />
I've found quite a few people with this issue, but I don't seem to be able to solve this.  The code below executes fine, and gives me a signed url, but when trying to do a GET request on this by opening it in the browser, I get
The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method.
My code is as follows, and is being ran in a Firebase Cloud Function
const admin = require("firebase-admin");
const functions = require('firebase-functions');
const gcs = require('@google-cloud/storage')({keyFilename: './service-account.json'});
const fb = require('./fb');
const db = fb.firestore()
const spawn = require('child-process-promise').spawn;
const path = require('path');
const os = require('os');
const fs = require('fs');
const mkdirp = require('mkdirp-promise');
const bucket = gcs.bucket('<id-here>.appspot.com')

exports.generateThumbnail = functions.https.onCall((data, context) => {
  const file = bucket.file(`/designs/${context.auth.uid}/${data.design}/${data.image}`)
  const tempFilePath = path.join(os.tmpdir(), `${data.image}`);
  const thumbFileName = `thumb_${data.image}`;
  const thumbFilePath = bucket.file(`/designs/${context.auth.uid}/${data.design}/${thumbFileName}`);

  return bucket.file(file.name).download({
       destination: tempFilePath,
     })
     .then(() => {
       return spawn('convert', [tempFilePath, '-trim','-resize', '190', tempFilePath]);
     })
     .then(() => {
       return bucket.upload(tempFilePath, {
         destination: thumbFilePath,
       })
     })
     .then(() => {
       return thumbFilePath.getSignedUrl({
         action: 'read',
         expires: '01-01-3000'
       })
     })
     .then((thumbnailUrl) => {
       fs.unlinkSync(tempFilePath)
       return db.collection('designs').doc(data.design).update({
         thumbnailUrl: thumbFilePath
       })
     })
})

Thanks for the info! Could you add this report over in https://github.com/googleapis/nodejs-storage/issues/244? There are members of the Storage and Firebase teams trying to help others with the same problem.


Simple usage of x

As title.

LGTM

LGTM

Codecov Report

Merging #3144 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3144      +/-   ##
==========================================
- Coverage   34.76%   34.73%   -0.03%
==========================================
  Files         276      276
  Lines       39948    39945       -3
==========================================
- Hits        13888    13876      -12
- Misses      24062    24074      +12
+ Partials     1998     1995       -3

Impacted Files
Coverage Δ

models/attachment.go
48.31% <0%> (-1.69%)
:arrow_down:

modules/indexer/repo.go
60.86% <0%> (-6.96%)
:arrow_down:

models/repo_indexer.go
50.97% <0%> (-1.95%)
:arrow_down:

models/repo.go
41.47% <0%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ec35e...d240aad. Read the comment docs.


do not show block button on own channels

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number:
What is the current behavior?
users can block their own channels using block button
What is the new behavior?
does not show up block button for channels owned by users
Other information

Nice fix! Thanks for the PR!


[VL] Fix QAT/IAA build

Macro GLUTEN_ENABLE_QAT and GLUTEN_ENABLE IAA were not ported to "cpp/velox" after separating the shuffle writer for backends.

cc @weiting-chen


Update opentelemetry-api, ... to 1.4.1

Updates

io.opentelemetry:opentelemetry-api
io.opentelemetry:opentelemetry-exporter-otlp-trace
io.opentelemetry:opentelemetry-extension-trace-propagators
io.opentelemetry:opentelemetry-sdk
io.opentelemetry:opentelemetry-sdk-testing

from 1.3.0 to 1.4.1.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.opentelemetry" } ]

labels: library-update, semver-minor

Superseded by #34.


[C][Python] Set up Conda packages

Ideally, the Python packages wouldn't have to embed the libraries anymore - they could just find them from Conda.

Ah, we'll have to fix the version specifier again, because Conda builds don't include the Git checkout...

Ready at https://github.com/lidavidm/staged-recipes/tree/adbc when the release is tagged.


Uncaught Error: No QueryClient set, use QueryClientProvider to set one

We are trying to use API calling but still facing the problem. Can you please give me example? how to resolve this?.

The scope on issues for this repo is for the boilerplate only. To use React Query please read the docs.


Issue/2456 increase log level modules update command

Description
Add a logging context manager to util.py and use it to wrap the function call that executes the module update command with the logging level of INFO
closes #2456
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

How can I test that the behavior is correct now ?

@Hugo-Inmanta I think this issue got already resolved in: https://github.com/inmanta/inmanta-core/pull/3249. (See my comment on Sep 13, 2021 about adding -vvv). Currently it logs with -vvv which is DEBUG. But I think that's fine.


No image data was found Tensorflowboard

Good day. Please tell me why the IMAGES tab in tensorboard does not work
No image data was found.
Probable causes:
You haven’t written any image data to your event files.
TensorBoard can’t find your event files.
while I see Scalar, Graphs etc

help plz!!!!


[SPARK-23020][CORE][branch-2.3] Fix another race in the in-process launcher test.

First the bad news: there's an unfixable race in the launcher code.
(By unfixable I mean it would take a lot more effort than this change
to fix it.) The good news is that it should only affect super short
lived applications, such as the one run by the flaky test, so it's
possible to work around it in our test.
The fix also uncovered an issue with the recently added "closeAndWait()"
method; closing the connection would still possibly cause data loss,
so this change waits a while for the connection to finish itself, and
closes the socket if that times out. The existing connection timeout
is reused so that if desired it's possible to control how long to wait.
As part of that I also restored the old behavior that disconnect() would
force a disconnection from the child app; the "wait for data to arrive"
approach is only taken when disposing of the handle.
I tested this by inserting a bunch of sleeps in the test and the socket
handling code in the launcher library; with those I was able to reproduce
the error from the jenkins jobs.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1298/
Test PASSed.

Test build #87985 has started for PR 20743 at commit 06aa292.

Test build #87985 has finished for PR 20743 at commit 06aa292.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87985/
Test PASSed.

@cloud-fan since you looked at the original fix.


make GetUnusedPort concurrency safe

What type of PR is this?
/kind bug
What this PR does / why we need it:
Kwok can be used nicely in go test with parallelism. However when running with -race, GetUnusedPort is flagged as a data race. Ancedotally, during our tests we have seen port contention and this might help resolve that.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/ok-to-test

this function should never be used concurrently.

@wzshiming are you saying that I shouldn't be using kwok with https://pkg.go.dev/testing#T.Parallel? I'd find that surprising considering how easy it is to use kwok in testing and with parallelism it makes the tests run very quickly.

Actually I think there is more than just GetUnusedPorts that potentially is a problem.

Actually I think there is more than just GetUnusedPorts that potentially is a problem.

Yes, I know the kwokctl potentially has this problem, but there's no need for parallelism, right?

The difference with t.Parallel is 3.5 minutes vs 23 minutes test runtime. So I'd say its very nice to have.

Hello
I would like to verify what you said, and I have not found any way to do it in this codebase, how do you do it exactly, I would like to verify it.

I would like to verify what you said

Verify which part exactly?


Restructure CI config

Upgrade bazel to 0.24.0
Restructure .circleci/config.yml to use machine executor. This removes memory limitations (see bazelbuild/bazel#3645) and removes the need to upgrade libstdc++ (Ubuntu's bundled on is up-to-date enough)
Disable building code multiple times on CircleCI

I'll submit another one.


performance patch

I have added benchmarking code and made little fix that boost performance by factor 3!

ok great, can you confirm if the existing tests still pass?

They all pass. I can confirm.

fantastic thx!


Longhorn volume in degraded state - v1.23.10+rke2r1[QUESTION]

Environment

Longhorn version: rancher/mirrored-longhornio-longhorn-engine:v1.3.1
Kubernetes version: v1.23.10+rke2r1
Node config

OS type and version  Ubuntu 18.04 (LTS) x64
CPU per node: 4
Memory per node: 8 GB Memory
Disk type 160 GB Disk

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): It's a VM from digital ocean

Additional context
I can see, PVC got attached to pod and even I've verified by exec into Pod. I can see 8Gb volume being assigned. But in longhorn UI, it is saying degarded.
And longhorn-manager logs:
time="2022-09-08T12:19:51Z" level=debug msg="Found 0 node has at least one schedulable disk" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=k8s-worker-node-02 owner=k8s-worker-node-02 state=attached volume=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8
time="2022-09-08T12:19:51Z" level=error msg="There's no available disk for replica pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8-r-fa92b416, size<PHONE_NUMBER>"
time="2022-09-08T12:19:51Z" level=error msg="unable to schedule replica" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=k8s-worker-node-02 owner=k8s-worker-node-02 replica=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8-r-fa92b416 state=attached volume=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8
time="2022-09-08T12:19:59Z" level=debug msg="Found 0 node has at least one schedulable disk" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=k8s-worker-node-02 owner=k8s-worker-node-02 state=attached volume=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8
time="2022-09-08T12:19:59Z" level=error msg="There's no available disk for replica pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8-r-fa92b416, size<PHONE_NUMBER>"
time="2022-09-08T12:19:59Z" level=error msg="unable to schedule replica" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=k8s-worker-node-02 owner=k8s-worker-node-02 replica=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8-r-fa92b416 state=attached volume=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8
time="2022-09-08T12:19:59Z" level=debug msg="Found 0 node has at least one schedulable disk" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=k8s-worker-node-02 owner=k8s-worker-node-02 state=attached volume=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8
time="2022-09-08T12:19:59Z" level=error msg="There's no available disk for replica pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8-r-fa92b416, size<PHONE_NUMBER>"
time="2022-09-08T12:19:59Z" level=error msg="unable to schedule replica" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=k8s-worker-node-02 owner=k8s-worker-node-02 replica=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8-r-fa92b416 state=attached volume=pvc-eb00391f-f40d-44dd-b753-8bebdbb6d0f8

@mantissahz Thanks for your response.
It's a small 3-node cluster with one master & two worker nodes. As worker nodes are two, it got degraded.
From Longhorn UI, I've update volume replicas to "1" and it's health now.
Thank you.


Boostrap MNIST tutorial

While running MNIST.py (with CPU setup) arises an error : Device index must not be negative since tensor.get_device() returns the index of cpu, it can be solved by changing line 64, rather returning device variable. Since to(device) is costless for default device and name is returned.
With GPU set up There still remains cuda nvcc error.

Objective of issue:

Lava DL version:

[ ] 0.3.0 (feature release)
[ ] 0.2.1 (bug fixes)
[x] 0.2.0 (current version)
[ ] 0.1.2

Lava version:

[ ] 0.4.0 (feature release)
[ ] 0.3.1 (bug fixes)
[x] 0.3.0 (current version)
[ ] 0.2.0
[ ] 0.1.2

I'm submitting a ...

[ ] bug report
[ ] feature request
[ ] documentation request

Current behavior:

return cpu device name

Expected behavior:

returns device index

Steps to reproduce:

Running MNIST.py

Related code:

insert short code snippets here

Other information:

insert the output from lava debug here

Device index must not be negative

@uslumt Thanks for raising the issue.
Can you try changing line 64 in tutorials/lava/lib/dl/bootstrap/mnist/mnist.py to
return x, torch.FloatTensor(count).reshape((1, -1)).to(x.device)
and let us know if that works for you. If it works, we will issue a fix.

Hello,
return x, torch.FloatTensor(count).reshape((1, -1)).to(x.device) and return x, torch.FloatTensor(count).reshape((1, -1)).to(device) works fine but as I mentioned in the issue get_device function returns negative index.
Thanks for your interest, I hope it'll be helpful for other developers.

Exactly. x.device does not return an integer like get_device(), so it should work for both cases.


Beyla failing to capture HTTP calls

We are using Beyla to instrument a Java based application which is receiving calls from outside. The application is acting as a server and it gets called by a client (through ingress-nginx). The results have some discrepancies in them, because only a very small fraction of the calls the client is sending to the application are being captured by Beyla. We have tried running Beyla with BEYLA_PRINT_TRACES=true to log every single call/trace and this does not seem to show the missing calls - nor are they present as Prometheus metrics.
Beyla configuration
routes:
  unmatched: heuristic
discovery:
  services:
    - exe_path: .*(zulu|elasticsearch).*

Service discovery does not seem to be the problem, as some calls are present - therefore the executable is correctly found and instrumented. Other than the Beyla logs missing the relevant traces, there are no abnormalities in the logs.
Here's an example of calls from the application (from the client-side logs) vs. what is captured by Beyla (Beyla application logs).

 Interestingly, on subsequent runs of the same test we also get different results, meaning a call that was not captured before is now suddenly present and vice versa.

Hi @marevers, what's the volume of requests happening in requests/second?
I think maybe we fail to add some of these requests for tracking because of concurrent writes in our BPF maps.
It would also help to know what programming language is the application server written in.
Thanks!

Thanks again, it can't be what I think it is. Is this Zulu that we are not capturing everything for? If it's not, do you know what framework is the Java application built with?
I'm wondering if it's related to the thread pools and how connections are handled that we are unable to connect the events.

It is Zulu based for sure

Sorry I think I confused Azul Zulu with Netflix Zuul :). Are you able to tell me what framework are you using for your Java app? For example, SpringBoot, Quarkus, etc... I'm guessing some internal thread pool mechanics are messing up our connection tracking, so I'd like to see if I can replicate a small example.

@grcevski thanks for clarification. The application is using SpringBoot as framework. I do not have the exact version currently but I can look it up if it helps.

I've been unsuccessful in reproducing so far. We have a SpringBoot example in our test suite, built with version 3.2.1. I ran that with a nginx proxy in front of it and I generated some (10) parallel connection load, I get all events, which means I'm missing some piece of the puzzle.
It would help to know what Spring Boot version you have.
Here's my test config. I'm not running TLS on nginx, it shouldn't matter I'd think. I'm guessing you are terminating TLS at nginx and from then on it's HTTP to the SpringBoot server...
services:
  lb:
    build:
      context: .
      dockerfile: Dockerfile
    ports:
      - "9090:9090"
    depends_on:
      - service

  service:
    build:
      context: service
      dockerfile: Dockerfile # this was our test jar
    ports:
      - "8085:8085"

Nginx config:
upstream servers {
    server service:8085 fail_timeout=15s;
}

server {
    listen 9090;
    location / {
        proxy_pass http://servers;
    }
}

Perhaps a different question, does this happen immediately as soon you start Beyla or after a while we are losing all these events...

One other thing I remembered, which might be causing this. We've known of a long standing issue that affects applications which take some time in IO and have some concurrency. Namely, we capture the received traffic on the return of tcp_recvmsg, since the buffer is fully read then. The Linux kernel allows for only a few return probes at a time by default. This setting can be extended, but we had trouble with some older kernels and we never added this configuration.
To work around the problem, we also install a socket filter which captures the buffers in case tcp_recvmsg didn't. However, the socket filter works only if hostNetwork: true is set in the Kubernetes spec definition for Beyla. This would apply with Docker compose too.
If this helps please let me know. Our helm chart makes this option a default now, but if this is the issue we probably need to attempt increasing the number of active return probes.

@grcevski Here are the answers:

It would help to know what Spring Boot version you have.
So it is not SpringBoot but Spring and specifically version 5.2.9.

Here's my test config. I'm not running TLS on nginx, it shouldn't matter I'd think. I'm guessing you are terminating TLS at nginx and from then on it's HTTP to the SpringBoot server...
Correct. TLS termination is done at the ingress controller and then HTTP to the application.

Perhaps a different question, does this happen immediately as soon you start Beyla or after a while we are losing all these events...
It happens immediately and does not seem to be dependent on Beyla being up for a longer time. Tested was also restarting Beyla and then immediately running the test but this makes no difference.

To work around the problem, we also install a socket filter which captures the buffers in case tcp_recvmsg didn't. However, the socket filter works only if hostNetwork: true is set in the Kubernetes spec definition for Beyla. This would apply with Docker too.
This will be the next thing to test, I will let you know if this makes a difference. At any rate, I will be adding the following to the DaemonSet spec:

spec:
  hostNetwork: true
  dnsPolicy: ClusterFirstWithHostNet

Just ran the test again with hostNetwork, unfortunately this does not change much. We are still only capturing a small fraction of the calls and the majority is not detected by Beyla.

Thanks for testing this @marevers.

So it is not SpringBoot but Spring and specifically version 5.2.9. Additionally, the client is also Java-based and uses Apache CXF. It does not open new connections for each call but rather sends multiple calls over the same handful of persistent connections. Maybe this could also have something to do with it.

I will try this next, it might be the reason. I tested with a Go client which does something similar, but it may not work the same.

So it is not SpringBoot but Spring and specifically version 5.2.9. Additionally, the client is also Java-based and uses Apache CXF. It does not open new connections for each call but rather sends multiple calls over the same handful of persistent connections. Maybe this could also have something to do with it.

Thanks for verifying this, is it maybe then a Tomcat or something else as the HTTP layer. I think they all use the same underlying libraries like Netty, but I just want to make sure.

Yes, the server application (the one Beyla is watching) uses Tomcat.

Hi @marevers,
I ran a small example with CXF based on this project https://github.com/stefan-kolb/jaxws-samples. Java 11, Tomcat and I tried their sample clients in a loop. I see all events to the last one.
I'm available tomorrow morning my time (EST Canada/US), but maybe if you are looking for earlier in the day (CET) my colleagues @mariomac  or @marctc might be able to assist. Are you on our Public Grafana Slack channel, it might be easier to setup the call?
One thing we can try to futher debug is activate BEYLA_BPF_DEBUG=1 as option, which will enable our BPF logs. These logs are pushed to the actual host kernel logs and you can see them by sudo cat /sys/kernel/debug/tracing/trace_pipe.
I know this may not be always possible, depending how you run your cluster, but if you use our main branch we can do:
BEYLA_LOG_LEVEL=debug with BEYLA_BPF_DEBUG=1 and those kernel logs will end up in standard output just like the other debug messages. This is a new feature and only works in main.

Our community slack for direct messaging info can be found here:
To engage with the Beyla community and to chat with us on our community Slack channel, please invite yourself to the Grafana Slack, visit https://slack.grafana.com/ and join the #beyla channel.

@grcevski thanks. I have sent a message to @mariomac in the Slack and we can try to set something up in CET. If not, I have availability in the morning EST from Monday onward.

Here are the bpf logs:
autoinstrument11.log

Thanks again Martijn! I put out a PR to allow us to load the debug BPF on 5.10. I'll also repeat my tests on 5.10 to see if that makes a difference, perhaps the missing events issue is related to lower kernel versions...

@grcevski @mariomac I've tested the new main version and the BPF debugging enablement is no longer crashing the container. We can organize a new session to do further debugging. I will DM @mariomac in the Grafana Slack again.

@marevers what kernel version are you running?

@marevers what kernel version are you running? Comments above imply 5.10 but just double checking it.

Correct, in the system it's being tested in, it's 5.10. Seeing as it is AWS EKS there is no user choice for the kernel version, it is dependent on the Kubernetes version

After testing with the 1.7.1-alpha.2 version, I can confirm the changes in that version have fixed the issue. I can see all calls from the client are now being picked up by the Beyla logs with BEYLA_PRINT_TRACES=1 enabled.


Getting error dataclasses.FrozenInstanceError: cannot assign to field generation_config when executing any of the scripts in the scripts folder with default parameters.

When I am trying to execute the script finetune_llama2_guanaco_7b.sh, I am getting error dataclasses.FrozenInstanceError: cannot assign to field generation_config.
The stack trace is below:
qlora.py", line 841, in
train()
qlora.py", line 694, in train
training_args.generation_config = transformers.GenerationConfig(**vars(generation_args))
File "qlora/.venv/lib/python3.10/site-packages/transformers/training_args.py", line 1714, in setattr
raise FrozenInstanceError(f"cannot assign to field {name}")
dataclasses.FrozenInstanceError: cannot assign to field generatio
How the issue can be resolved?

Hey @vasuems I got the same error message in another library.
The training args are now fully immutable in Transformers 4.32 (see https://github.com/huggingface/transformers/pull/25435).
So a fix for this repo could be:
# Instead of:
#training_args.generation_config = transformers.GenerationConfig(**vars(generation_args))

import dataclasses

training_args = dataclasses.replace(training_args, generation_config = transformers.GenerationConfig(**vars(generation_args)))

But untested!


Merge latest staging with master

Moved monitor pool section to pool page
Some typo and corrections in installation page
Signed-off-by: Ranjith R<EMAIL_ADDRESS>

Signed-off-by: ranjithwingrider<EMAIL_ADDRESS>


set fill after

b kh
Hi
i want set fillafter , but i cant do this . how i can do this?

what?

what?

Normal animations have a fillAfter, which sets the properties of the view to the final state of the animation
https://developer.android.com/reference/android/view/animation/Animation.html#setFillAfter(boolean)


Make Metabase templates to use version

Metabase templates are hardcoded to latest, use version parameter with default value as latest.

completed.


Add public models feature

@rohan-uiuc What's your status here? It worked quite well in my simple testing.

One last step is left to create a new endpoint for calling inference on public models


css and images?

Any plans to support css loading and images?

CSS is not too hard, see #160, not sure how images would work with this mechanism.

What about SVG files?

why not fetch image files and return raw blobs to be used with image elements or canvas

@SaulDoesCode That should work!

@ray007 #160 has been sitting for a long while.. whats the plan for the merge?

@crobinson42 It's not up to me.