Revert label override values

What is missing?
The original behavior was that cassandra.datastax.com/datacenter has a value that's identical to the CassandraDatacenter.ObjectMeta.Name. In PR #475 the behavior was changed to include CassandraDatacenter.DatacenterName() which could be either the .Name or .Spec.DatacenterName.
My proposal is to revert this part of the PR with basically the following fix in cass-operator:
diff --git a/apis/cassandra/v1beta1/cassandradatacenter_types.go b/apis/cassandra/v1beta1/cassandradatacenter_types.go
index ec9aa20..fc4bc2d 100644
--- a/apis/cassandra/v1beta1/cassandradatacenter_types.go
+++ b/apis/cassandra/v1beta1/cassandradatacenter_types.go
@@ -596,7 +596,7 @@ func (dc *CassandraDatacenter) SetCondition(condition DatacenterCondition) {
 // GetDatacenterLabels ...
 func (dc *CassandraDatacenter) GetDatacenterLabels() map[string]string {
        labels := dc.GetClusterLabels()
-       labels[DatacenterLabel] = CleanLabelValue(dc.DatacenterName())
+       labels[DatacenterLabel] = CleanLabelValue(dc.GetName())
        return labels
 }

Why is this needed?
This is because right now we're unable to use the labels for querying the parent objects. If we look at a pod/service/StatefulSet/any object when override name is in use it has a label like: cassandra.datastax.com/datacenter=overrideName yet using the Kubernetes API this label value is entirely useless. We can't fetch the actual CassandraDatacenter with this information at all.
It also does not necessarily match the value in Cassandra itself either as the value stored in the labels is cleaned up removing certain characters. Thus, both the user and the systems are unable to use these values for anything. And we need this feature, we need to be able to link resources from bottom to top so we can fetch the related resources. Right now only the top to bottom is doable since CassandraDatacenter knows what labels we created to sub resources, but sub resources do not know what labels the parts above (or next to) have.
Reverting this change requires some work also when updating since we do not allow StatefulSet updates automatically without user consent. We can however make an exception and update labels, since this doesn't require a rolling restart of the pods as all labels can be changed in Pods/StatefulSets without rolling update.
For k8ssandra-operator, we are in a more complex scenario. There are already some resources that use the .Name (like Prometheus ServiceMonitors) and some that use .DatacenterName(). This will require some manual upgrade process to enforce the correct format we want everywhere. While most of them should be automatically updated in the upgrade process, there are some that require manual work, namely the MedusaBackup objects as they were created with the old values and are not actively maintained.
The k8ssandra-operator also has the k8ssandra.io/cluster-name which is different from cassandra.datastax.com/cluster. The latter is always using the .Spec.ClusterNameand there's no need to change this behavior. However, for k8ssandra-operator we probably want to enforce the .Name instead. That gives us both values to use for cluster seeking operations.
One raised question was that the update has issues knowing which value we have in the datacenter label when updating from previous versions. This is always problematic no matter if we rollback or not, since there are already versions of cass-operator & k8ssandra-operator adding either value, depending on where you're updating from.
It might feel painful, but I think we should do the right thing here and revert the change to simplify our labels usage as we ourselves can't even keep track of what values are stored where. If we always keep the Kubernetes names, it's very clear. It's also what we internally always process, whatever is in Cassandra is not really relevant to our management processes.

namely the MedusaBackup objects as they were created with the old values and are not actively maintained
I don't think that's really a problem, those labels aren't used as selectors I think.

@Miles-Garnsey @olim7t, please chime in here.


Fix xses

Trading days fix:

Add 2018-02-19
Remove 2019-12-15
Add 2020-07-10
Add 2020-11-14

Source:
https://www.tradinghours.com/exchanges/sgx/market-holidays/2018
https://www.tradinghours.com/exchanges/sgx/market-holidays/2019
https://www.tradinghours.com/exchanges/sgx/market-holidays/2020
Also changed closing time to the correct closing time from 15:00 to 17:00. This is consistent with the class' own documentation, as well as with this:
https://www.tradinghours.com/exchanges/sgx/trading-hours

Note: the reason the build fails is that the test CSV is not updated after the changes.
Let me know if you want me to do that as well :)

Thanks for the contribution!
According to the exchange website (https://www.sgx.com/securities/trading) they follow the government calendar at https://www.mom.gov.sg/employment-practices/public-holidays.
Add 2018-02-19 - I can't find mention of this on the government website. See https://www.mom.gov.sg/newsroom/press-releases/2017/0405-singapore-public-holidays-2018. As best as I can tell, stocks had volume that day.
Remove 2019-12-15 - Agreed, not listed, though this is a Sunday and shouldn't matter.
Add 2020-07-10 - Agreed - Polling day via https://www.mom.gov.sg/employment-practices/public-holidays
Add 2020-11-14 - this is a Saturday and I don't believe it needs to be added.
So I think only 2020-07-10 needs to be added.
Agreed on your closing time update as well (via https://www.sgx.com/securities/trading)

Agreed on and made your suggested changes.
Should I make changes to the CSV files as well or is it something the maintainers do?

Yep - if you can update the csv file as well I'll approve this and get it merged/released. Thanks!


useNumberField example code is broken; increment/decrement unresponsive

🐛 Bug Report
useNumberField contains example code, which does not work. Clicking increment/decrement button multiple times may or may not register a single value change.
🤔 Expected Behavior
Each click should result in increment/decrement of value
😯 Current Behavior
Example code in Codesandbox: https://codesandbox.io/s/usenumberfield-bug-mrjwbi
Btw, in production builds (or Storybook) this works perfectly
💁 Possible Solution
Not sure
🔦 Context
Was trying to fill in a form using the component from our own Storybook where component behaves ok. Noticed it was unresponsive. After a bunch of debugging noticed that in Storybook the component works fine, as well as in the app, but only in production build.
💻 Code Sample
https://codesandbox.io/s/usenumberfield-bug-mrjwbi
// Button.js
import { useRef } from "react";
import { useButton } from "react-aria";

export const Button = (props) => {
  let ref = useRef(null);
  let { buttonProps } = useButton(props, ref);
  return (
    <button {...buttonProps} ref={ref}>
      {props.children}
    </button>
  );
};

// NumberField.js
import React from "react";
import { useNumberFieldState } from "react-stately";
import { useLocale, useNumberField } from "react-aria";
import { Button } from "./Button";

export const NumberField = (props) => {
  let { locale } = useLocale();
  let state = useNumberFieldState({ ...props, locale });
  let inputRef = React.useRef(null);
  let {
    labelProps,
    groupProps,
    inputProps,
    incrementButtonProps,
    decrementButtonProps
  } = useNumberField(props, state, inputRef);

  return (

      {props.label}

        <Button {...decrementButtonProps}>-</Button>
        <input {...inputProps} ref={inputRef} />
        <Button {...incrementButtonProps}>+</Button>

  );
};

// App.js
import { NumberField } from "./NumberField";

export default function App() {
  return (
    <NumberField
      label="Price"
      defaultValue={6}
      formatOptions={{
        style: "currency",
        currency: "USD"
      }}
    />
  );
}

🌍 Your Environment

Software
Version(s)

react-stately
3.21.0

react-aria
3.23.1

Browser
Chrome 111.0.5563.146

Operating System
MacOS 13.3

🧢 Your Company/Team
n/a
🕷 Tracking Issue (optional)
n/a

Probably react strict mode. Support for that is still a work in progress


Fix issue 173

Clean up and document filters.  See issue #173 for details.

Codecov Report
Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (d1e7ca3) 83.88% compared to head (b8e1e8f) 83.72%.

Files
Patch %
Lines

mt_metadata/timeseries/filters/filter_base.py
62.50%
9 Missing :warning:

mt_metadata/timeseries/filters/filtered.py
41.66%
7 Missing :warning:

mt_metadata/timeseries/filters/fir_filter.py
22.22%
7 Missing :warning:

mt_metadata/base/metadata.py
0.00%
5 Missing :warning:

mt_metadata/timeseries/channel.py
66.66%
2 Missing :warning:

mt_metadata/timeseries/filters/channel_response.py
90.47%
2 Missing :warning:

mt_metadata/timeseries/stationxml/fdsn_tools.py
0.00%
2 Missing :warning:

tests/timeseries/filters/test_channel_response.py
66.66%
1 Missing :warning:

tests/timeseries/filters/test_electric_unit.py
66.66%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   83.88%   83.72%   -0.16%
==========================================
  Files         272      270       -2
  Lines       20044    20019      -25
==========================================
- Hits        16813    16760      -53
- Misses       3231     3259      +28

Flag
Coverage Δ

tests
83.72% <66.66%> (-0.16%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


push NQ fixes to HF

sjrosenthal created the following on May 17:
Add candidate passage info to NQ dataset and create PR to push to HuggingFace
Original issue: https://github.ibm.com/ai-foundation/PrimeQA/issues/200

On May 19, sjrosenthal commented:
PR is ready on HF and waiting review: https://github.com/huggingface/datasets/pull/4368

NQ fixes have been uploaded in HF


[Feature Request] Opened article should remain open even on changing feed

Presently, if an article of a feed is open and feed changes, article pane becomes empty. Instead of this, same article should get displayed till new article is selected.

We need to keep the user interface in a consistent state.  We always try to keep the timeline in sync with the article view.  For this reason we have to close the article if you change the feed.  This functions as designed.


Check for multiple selections per line

This pull request checks if there is more than one selection on any given line, in the event that there is, the default behavior of a space is inserted. It works by comparing the number of lines selected and the number of selections.

Before multiple selections on a single line caused unexpected behavior, and for unindenting, an Error: Overlapping ranges are not allowed! error occurred.

Hi @usernamehw, would you mind looking at this pull request?

Ok. Hope it works. If someone complains that this broke something - I will revert it.


Added day 28 learnings

Learned Helm, ingress and ingress controller, persistent storage claim

/lgtm @Nawaz027 Keep it up.


1/1 GIFs framerate appears slower than canonical/reference

Closing as this only appears to happen on Etherscan due to it truncating the Data URIs of large images.


Added explaination on using exisiting html string

Code from #291
Closes #300

Thanks for the effort on this issue @Bartvds and @dustyny!
I will accept+merge after the issues from @dustyny are addressed


Streamlit playground support for localLLMs

🚀 The feature
Support local llm by connecting streamlit playground with the local dev container
User can run the llm locally and provide endpoint to connect LLM with Streamlit or we can provide a wrapper function for LLM to connect with Streamlit
Motivation, pitch
Motivation behind this is Colab where we can connect the notebook with local machine what if we can do same for streamlit playground
Alternatives
No response
Additional context
No response

This is an awesome idea by the way! If you implement this we will definitely land it


Create workflow for publishing to npm

The OpenAstronomy Azure Pipelines publish template supports publishing to npm for Jupyter widget packages. A separate workflow should be created here to replicate this behaviour.
However, no public repos on GitHub seem to use this feature.

I thought @astrofrog used it.

Hey, I would like to work on this. How should I proceed further with it?


Stop renderer on Window minimize.

Speaking with @danwalmsley in gitter I realized that we don't currently stop a window's renderer when the window is minimized.
This PR adds a new WindowStateChanged event to IWindowImpl and when a window is minimized, stops the associated renderer. (This is only implemented on win32 currently).
This means that the render timer can be stopped when all windows are minimized, which should help perserve battery life.

This overlaps with #1190 so I think that should be merged first.


[Usage]: How can I use 6 GPU's?

Your current environment
PyTorch version: 2.4.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.3 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.35

Python version: 3.10.15 (main, Oct  3 2024, 07:27:34) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-6.5.0-15-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.3.107
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA RTX A6000
GPU 1: NVIDIA RTX A6000
GPU 2: NVIDIA RTX A6000
GPU 3: NVIDIA RTX A6000
GPU 4: NVIDIA RTX A6000
GPU 5: NVIDIA RTX A6000

Nvidia driver version: 545.23.08
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_adv_infer.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_adv_train.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_infer.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_cnn_train.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_ops_infer.so.8.9.7
/usr/lib/x86_64-linux-gnu/libcudnn_ops_train.so.8.9.7
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             32
On-line CPU(s) list:                0-31
Vendor ID:                          AuthenticAMD
Model name:                         AMD Ryzen Threadripper PRO 5955WX 16-Cores
CPU family:                         25
Model:                              8
Thread(s) per core:                 2
Core(s) per socket:                 16
Socket(s):                          1
Stepping:                           2
Frequency boost:                    disabled
CPU max MHz:                        5097.6558
CPU min MHz:                        1800.0000
BogoMIPS:                           8000.92
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 invpcid_single hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin brs arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm
Virtualization:                     AMD-V
L1d cache:                          512 KiB (16 instances)
L1i cache:                          512 KiB (16 instances)
L2 cache:                           8 MiB (16 instances)
L3 cache:                           64 MiB (2 instances)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-31
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines, IBPB conditional, IBRS_FW, STIBP always-on, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected

Versions of relevant libraries:
[pip3] numpy==1.26.4
[pip3] nvidia-cublas-cu12==<IP_ADDRESS>
[pip3] nvidia-cuda-cupti-cu12==12.1.105
[pip3] nvidia-cuda-nvrtc-cu12==12.1.105
[pip3] nvidia-cuda-runtime-cu12==12.1.105
[pip3] nvidia-cudnn-cu12==<IP_ADDRESS>
[pip3] nvidia-cufft-cu12==<IP_ADDRESS>
[pip3] nvidia-curand-cu12==<IP_ADDRESS>
[pip3] nvidia-cusolver-cu12==<IP_ADDRESS>
[pip3] nvidia-cusparse-cu12==<IP_ADDRESS>
[pip3] nvidia-ml-py==11.450.51
[pip3] nvidia-ml-py3==7.352.0
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] nvidia-nvjitlink-cu12==12.6.77
[pip3] nvidia-nvtx-cu12==12.1.105
[pip3] pynvml==11.5.3
[pip3] pyzmq==22.3.0
[pip3] torch==2.4.0
[pip3] torchaudio==0.11.0+cu113
[pip3] torchvision==0.19.0
[pip3] transformers==4.46.2
[pip3] triton==3.0.0
[conda] numpy                     1.26.4                   pypi_0    pypi
[conda] nvidia-cublas-cu12        <IP_ADDRESS>                 pypi_0    pypi
[conda] nvidia-cuda-cupti-cu12    12.1.105                 pypi_0    pypi
[conda] nvidia-cuda-nvrtc-cu12    12.1.105                 pypi_0    pypi
[conda] nvidia-cuda-runtime-cu12  12.1.105                 pypi_0    pypi
[conda] nvidia-cudnn-cu12         <IP_ADDRESS>                 pypi_0    pypi
[conda] nvidia-cufft-cu12         <IP_ADDRESS>                pypi_0    pypi
[conda] nvidia-curand-cu12        <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-cusolver-cu12      <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-cusparse-cu12      <IP_ADDRESS>               pypi_0    pypi
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] nvidia-nvjitlink-cu12     12.6.77                  pypi_0    pypi
[conda] nvidia-nvtx-cu12          12.1.105                 pypi_0    pypi
[conda] pynvml                    11.5.3                   pypi_0    pypi
[conda] torch                     2.4.0                    pypi_0    pypi
[conda] torchvision               0.19.0                   pypi_0    pypi
[conda] transformers              4.46.2                   pypi_0    pypi
[conda] triton                    3.0.0                    pypi_0    pypi
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.6.3.post1
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0	GPU1	GPU2	GPU3	GPU4	GPU5	CPU Affinity	NUMA Affinity	GPU NUMA ID
GPU0	 X 	PHB	SYS	SYS	SYS	SYS	0-31	0		N/A
GPU1	PHB	 X 	SYS	SYS	SYS	SYS	0-31	0		N/A
GPU2	SYS	SYS	 X 	PHB	PHB	SYS	0-31	0		N/A
GPU3	SYS	SYS	PHB	 X 	PHB	SYS	0-31	0		N/A
GPU4	SYS	SYS	PHB	PHB	 X 	SYS	0-31	0		N/A
GPU5	SYS	SYS	SYS	SYS	SYS	 X 	0-31	0		N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

LD_LIBRARY_PATH=/home/bizon/anaconda3/envs/myenv/lib/python3.10/site-packages/cv2/../../lib64:/usr/local/cuda/lib64:/usr/local/cuda/lib64:
CUDA_MODULE_LOADING=LAZY

How would you like to use vllm
I want to run inference Llama 3.1 70B-Instruct using 6 GPU's. I have the following code so far working for 4 GPU's:
from vllm import LLM, SamplingParams

# Parameters
number_gpus = 4
max_model_len = 8192
sampling_params = SamplingParams(temperature=0.6, top_p=0.9, max_tokens=256)
runs = 20  # Number of runs

# Prepare prompt
prompts = [
    "Hello world!"
]

# Paths to model
model_id = r"/home/bizon/Desktop/models/llama3.1/Llama-3.1-70B-Instruct"

# Initialize model
llm = LLM(model=model_id, tensor_parallel_size=number_gpus, max_model_len=max_model_len)

This runs at ~16-17 tokens per second on 4, RTX A6000 GPU's.
If we try running this with tensor_parallel_size=6, we get the following error:
ValueError: Total number of attention heads (64) must be divisible by tensor parallel size (6).

Is there any way to get around this?
I have tried the suggestion of using pipeline_parallel_size, but the performance is very very poor (~4 tokens per second).
Before submitting a new issue...

[X] Make sure you already searched for relevant issues, and asked the chatbot living at the bottom right corner of the documentation page, which can answer lots of frequently asked questions.

My suggestion is to add two more GPUs.


Add a modules webpage gui in game

A gui to display the modules page would be super useful. Just something that can scan the API and relay the information along with buttons to install the modules. This would have to work in tangent with the re-worked modules gui to show if a module is already installed.
The gui should be able to

Get all or most of the info from the website API and display it similar to the re-worked modules gui
Have clickable buttons to install modules
Be able to tell if a module is already installed (or if a module is in the middle of installing)
Have a button to get back to the re-worked modules page
Have a button on the re-worked modules page to get to this new GUI

With the new website, there is a very powerful API that will make the data portion of this a breeze. Everything is documented here.


it was biger to yolov5s model pruned

it existed error to your pruned code.

i would be appreciated it if u could paste ur code and show me where goes wrong

pruning 14.48M yolov5s.pt, turned to 17. 59M best_fsmvocs.pt, when t=0.8
if t=0.1, size of best_fsmvocs.pt to biger.

pt size does not mean anything about actual model size. u should figure it out the whole pipline and try to debug if there were something wrong. btw, this method is not network-slimming. plz refer the original paper.

really，your means was different with network-slimming.


NETCONF timeout when using asyncio functions

I am using the asyncio functionality of subscriptions (which is a very cool feature). The issue is that I am receiving a timeout for the calls when calling them from the client:
<nc:error-message xml:lang="en">Callback event "change" with ID 1 processing timed out.</nc:error-message>
After digging into the implementation and how you used sr_process_events(): https://netopeer.liberouter.org/doc/sysrepo/master/subs.html , I was wondering maybe something was missed. I am not 100% with sysrepo, but IMO the "Done" event is not being handled.

Hi @chaichairiko
Could you please share the python code of the application that makes the subscription with which you have this problem ?

Hi @rjarry
Ive managed to isolate the problem and it is not related to asyncio whatsoever.
In my callback I am connecting to sysrepo to get_data (I make other connections throughout the call as well but this initial one is the relevant). While the entire callback (which does a lot of work, including set_items, etc) takes 0.02 seconds. This initial connection take 4.98 seconds. This long delay causes the timeout in the "changes" event.
My question is how to deal with this since it happens all the time. Should I create a connection externally and send it to all the callbacks? Can the code be changed so that the callback receives the session (like the callbacks in the original sysrepo)?
I am still learning how sysrepo works, so I apoligize for the initial issue which is not relevant

Hi @chaichairiko
You should only create one connection per process. My advice is to create one and store it in a global variable at startup.
After which you can create sessions when needed (in your callbacks or whatever).

@rjarry What about adding the session as the initial parameter in the callback as being done in sysrepo.c?
The session is available when subscribing, and can we sent in the callback and used there (it worked in a local branch where I've tried it)

Unfortunately, this session is an "implicit session" which is created especially for the callbacks and closed immediately when the callback returns.
This makes it impossible to pass the session to async callbacks due to the way they work internally in sysrepo. See https://github.com/sysrepo/sysrepo/issues/1891 for more details. For API consistency, the session argument is not passed to any python callbacks, async nor regular.
The only option is to make the connection accessible to your callbacks. Either via a global variable or via the private_data argument.

Thanks for the detailed response!
I will implement a global connection


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add nyc from template
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template

Codecov Report

Merging #383 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   83.64%   83.64%
=======================================
  Files           1        1
  Lines         214      214
=======================================
  Hits          179      179
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ff1bf...f7451f0. Read the comment docs.

Coverage remained the same at 84.388% when pulling f7451f0133ae19fedf4c00fff91c39da48905fe8 on template-sync-1 into 23ff1bf3b62731f5ce590ab721ad70f484e1e513 on master.

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Runtime username/password input to connect to middleware.

Adding support to interactively add username and/or password to connect to activemq and/or rabbitmq, if corresponding fields are set to 'ask'. This allows for safer deployment of MCollective when RabbitMQ/ActiveMQ is integrated with LDAP. In absence of this facility, LDAP passwords had to be stored in cleartext in conf file in user's home directory.
sample ~/.mcollective
...
connector = activemq
plugin.activemq.pool.size = 2
plugin.activemq.pool.1.host = stomp1
plugin.activemq.pool.1.port = 6163
plugin.activemq.pool.1.user = mcollective
plugin.activemq.pool.1.password = ask
plugin.activemq.pool.2.host = stomp_fallback
plugin.activemq.pool.2.port = 6163
plugin.activemq.pool.2.user = fallback
plugin.activemq.pool.2.password = secret
...
password.rb has been taken from Barry Allard's gist at https://gist.github.com/steakknife/2040373 and somewhat modified.
First time ever with Ruby.

This is an interesting idea, but it needs a bunch of tests to be added, and a bunch of refactoring to take some of the weirdness out of it.

Apologies as there were other tasks that needed my attention.
All comments are appreciated! will work on them.

I am writing test case for this request and I noticed middleware passwords for 2 pools are different. This change assumes all pools have same password. I am changing the prompt per pool considering that. Caveat of this is that if multiple pools are configured to prompt for password, it would have to be entered number_of_pool times for every command... which would be quite a bad user experience. Alternative would be have a flag like plugin.rabbitmq.all_pools_have_same_password.
Thoughts?

I think it's find that this setting would be connector rather than pool member level, as it's just a fancier way of setting STOMP_USER and STOMP_PASSWORD

Please let me know if everything is OK or there are some changes that you'd like to see to get the pull request merged in.

Is this going to get merged in? Would be pretty useful.

CLA signed by all contributors.

I'd like to see specs around enabling the new options. That might require mocking get_hidden_input, since those are trickier to spec test. https://github.com/puppetlabs/marionette-collective/blob/master/spec/unit/mcollective/discovery/stdin_spec.rb might have some useful patterns.

Was there ever an MCO ticket created for this?

i don't know so. i needed it, so made it and contributed it upstream. we should probably look if there is any associated ticket and close it. can do that once i get back from vacation.
Sent from mobile device. Please excuse my brevity.
On May 9, 2016, 14:59, at 14:59, Michael Smith<EMAIL_ADDRESS>wrote:

Was there ever an MCO ticket created for this?

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/puppetlabs/marionette-collective/pull/337#issuecomment-217987946

The ticket will be reviewed Wednesday morning. We also have a Pull Request Triage for core projects next Tuesday (May 17th, 10am PDT), if it doesn't get merged before then.

Are you able to add spec tests around the enabling the new options? Currently they all run with it disabled.

I should be able to do that, just not able to get to it because of
current workload. Sorry :(
On 05/17/2016 10:53 AM, Michael Smith wrote:

Are you able to add spec tests around the enabling the new options?
Currently they all run with it disabled.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/puppetlabs/marionette-collective/pull/337#issuecomment-219799584

I think I'll merge it. If you have time in the future please add some extra tests.


Separation of IResourceProvider(s) (with same MyFhirResource) will cause a duplicate entry in "Server knows how to handle" list

NOTE: Before filing a ticket, please see the following URL:
https://github.com/hapifhir/hapi-fhir/wiki/Getting-Help
Describe the bug
This is a little bit off the beaten path, as most will create a single IResourceProvider for any MyFhirResource.
Our code base... we separate the @Search and the @Read Resource Providers......to emphasize "Single Responsibility" SOLID principle.
To Reproduce
Steps to reproduce the behavior:
Create 2 different IResourceProvider(s) .. that separate @Read and @Search. (but for the same MyFhirResource). (we'll use "Patient" as seen below.
public class MyPatientReadResourceProvider implements IResourceProvider

    @Override
    public Class<Patient> getResourceType() {
        return Patient.class;
    }

    @Read(version = true)
    public Patient readPatient(@IdParam IdType theId) {
    }

AND
public class MyPatientSearchResourceProvider implements IResourceProvider

    @Override
    public Class<Patient> getResourceType() {
        return Patient.class;
    }

    @Search()
    public List<Patient> findPatientsByName(final @RequiredParam(name = Patient.SP_FAMILY) StringDt theFamilyName) {

Now hit an endpoint that is not about the Patient.
myfhirserver.com/r4/NotAPatient?
Outcome:
"diagnostics": "HAPI-0302: Unknown resource type 'NotAPatient'; - Server knows how to handle: [Patient, Patient]"
Expected behavior
A clear and concise description of what you expected to happen.
"diagnostics": "HAPI-0302: Unknown resource type 'NotAPatient'; - Server knows how to handle: [Patient]"
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
hapiFhirVersion = '6.1.3'
Additional context
Add any other context about the problem here.
I will try to do a fork and PR.  Adding this to provide an issue #.

PR candidate added:
https://github.com/hapifhir/hapi-fhir/pull/4311


Added instructions to install from conda as well.

Updated the docs/installation.rst to add instructions of installing & uninstalling jupyterlab_pioneer from conda as well.

Thank you! @isumitjha


double check all @meiversion in all samples

not before everything else is merged

[ ] v4.0.1 sample-encodings
[ ] v5.0 sample-encodings
[ ] v5.0 music-encoding

the examples in music-encoding have one occurrence of 4.0.0 and the others are 5.0.0-dev both should be changed to 5.0


Double icons with single icon extension installed

I use Brackets Icons by Ivo Gabe de Wolff and after installing this Tabs extension, I have a weird bug of unwanted double icons.
How do I solve this problem? It doesn't look alike as Tabs extension official screenshot.
Screenshot:

Here


Bad name of variable

In this place:
347: var byte = parseInt(string.substr(i * 2, 2), 16)
348: if (isNaN(byte)) throw new Error('Invalid hex string')
349: buf[offset + i] = byte
https://github.com/feross/buffer/blob/3a22a49dad272004455e90c1df3b0ffb5a07f47f/index.js#L347-L349
used variable with name "byte", but such names are only allowed in ecmascript 5. I'm use RhinoScriptEngine in java and Rhino not complete support ecmascript 5 now.
Please change the code for this example:
347: var byte2 = parseInt(string.substr(i * 2, 2), 16)
348: if (isNaN(byte2)) throw new Error('Invalid hex string')
349: buf[offset + i] = byte2
Thank you.

@BogdanovAnton could probably have made a PR along with this.  In any case #57.

This will be released as 3.0.4.


Link to: https://www.proxy-sniffer.com/en/doc/LoadTestKnowHowEN.pdf gets the Chrome scary warning to do with expired SSL cert. Think this company has been acquired?

[Enter feedback here]
See title for broken-ish link

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ea464ce1-0548-e4d4-2160-a3829c959b93
Version Independent ID: 9128607b-d441-cf29-b68b-55936d549690
Content: JMeter implementation reference for load testing pipeline solution - Azure Architecture Center
Content Source: docs/example-scenario/banking/jmeter-load-testing-pipeline-implementation-reference.yml
Service: architecture-center
Sub-service: example-scenario
GitHub Login: @doodlemania2
Microsoft Alias: pnp

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 404156

Thanks for the report @ciarancolgan -- an updated URL has been found and the article will be published with it in the next 48 hours.


add documentation to the object

using docson: https://github.com/lbovet/docson

@ElaineMcA this can be done along with the data pipeline & json refactor

Issue moved to opentargets/platform #34 via ZenHub


Unit tests galore

We need unit tests for many cases of files.

Tests should be added first for YAML parsing, macro expansion and URL parsing.


Enhancement: Add deadline shortcut in Openpype Launcher

Please describe the feature you have in mind and explain what the current shortcomings are?
Add deadline shortcut in Openpype Launcher

PR : https://github.com/ynput/OpenPype/pull/5274

Bug qui apparait à l'ouverture des settings " 'TextEntity' object has no attribute 'items' "

Je n'ai pas de raccourci deadline.

What can I do to help on this on ?
Is it still ongoing ?

What can I do to help on this on ? Is it still ongoing ?

Stand by until we have higher priority tickets


Disconnection isn't permanent after the remote agent goes down

This is with the stable version of the SSH extension that doesn't yet have any of the recent changes.

Connect to an SSH host
Run "Kill VS Code Server on Host", pick the current host
Reconnection starts
On stable, the resolver runs, then vscode realizes that its EH is gone, and shows an error
On insiders, it keeps trying to reconnect forever

Stable

Insiders

Insiders logs

This sounds like something that would be caused by moving to Chromium's WebSocket on Insiders vs the usage of node's TCP/IP on Stable.

This sounds like something that would be caused by moving to Chromium's WebSocket on Insiders vs the usage of node's TCP/IP on Stable.

Yes, it looks like WebSockets tend to never result in an error:

Yes, it looks like WebSockets tend to never result in an error:


Disconnect/Signout Event

there's currently no event for signout.
it seems like this is never:
https://github.com/apptailor/react-native-google-signin/blob/master/RNGoogleSignin/RNGoogleSignin.m#L59-L61

done on v0.4.0

@devfd can you please point me out to the pull request (or any docs?)
It's hard to follow version changes without any tagged releases...

@devfd great work on v0.4.0
cheers


Fix License icon on the README

the license icon is not rendering, feel free to choose other one you like

I can fix this issue Please assign it to me

I think that the issue is not there

I think that the issue is not there

oh :eyes:
ok, but feel free to choose a new one :)

Sure...

🗳🧾🪪📜📄✒📑🔖📝📒
Any one from these emojis?
I think that we should go with any of these :
📝
📜
✒

🗳🧾🪪📜📄✒📑🔖📝📒 Any one from these emojis? I think that we should go with any of these : 📝 📜 ✒

This is OK :)
📜

I can fix this issue

Hey @vczb ,
Please transfer this issue to @YashCommits

I can fix this issue


vendor_ID filter reversed in list_connected_devices

Excludes devices by ID rather than including them

Thank you @kgabel-tu for this fix!


Fix instance pool

Description of the Change
Threads that waited for compilation to finish could try to access the produced instance pool before it had been inserted into the cache.

https://github.com/qdrvm/kagome/compare/fix/instance-pool-2


Watson Vis Rec doesn't work

Hi. I am developing or trying to develop an app with Watson Visual Recognition scripts available on GitHub but that doesn't work on the Blue Mix environment. Follows attached prints. Someone saw something similar. I did all the manual's steps. Thanks in advance.

@hayslan1
Try the Deploy to Bluemix Button on the README:

This works for me, see if it works for you.

Thank you James. This really work.


New package: Xiph.FLAC version 1.4.3

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[ ] Does your manifest conform to the 1.6 schema? No, this particular package requires the 1.9.0 manifest version, see comment below for further information 😄

Note: <path> is the directory's name containing the manifest you're submitting.
Resolves https://github.com/microsoft/winget-pkgs/issues/151382

Microsoft Reviewers: Open in CodeFlow

Hello @fgimian,
One or more of the installer URLs doesn't appear valid.
This may happen for sites with policies prohibiting distribution or use by third parties.
This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.
Template: msftbot/validationError/urls/domain

Hey there, the links used are those which I'm directed to by the official FLAC site.

Browse to https://xiph.org/flac/download.html
Under Windows, click FLAC for Windows
You'll be redirected to https://ftp.osuosl.org/pub/xiph/releases/flac/ with the downloads

@stephengillie Hey there, would you kindly let me know what is required for this PR to be merged please?
Thanks heaps
Fotis

@stephengillie Just following this one up again. Is it currently possible to accept this package with the 1.9.0 manifest version or will it have to wait until that's stabalised further?
Kindly let me know if I can provide any further assistance to push it along.
Cheers
Fotis

Reopen with reason: Automation error;

@fgimian - If you update this to 1.9.0 and set the ArchiveBinariesDependOnPath, it should work

@fgimian - If you update this to 1.9.0 and set the ArchiveBinariesDependOnPath, it should work

Hey there @Trenly, this PR already uses manifest version 1.9.0 and leverages the ArchiveBinariesDependOnPath option.
Kindly give it another look and let me know if it looks good 😄
Cheers
Fotis

@fgimian - If you update this to 1.9.0 and set the ArchiveBinariesDependOnPath, it should work

Hey there @Trenly, this PR already uses manifest version 1.9.0 and leverages the ArchiveBinariesDependOnPath option.
Kindly give it another look and let me know if it looks good 😄
Cheers Fotis

Ah, I didn't see that since the headers still referenced 1.6.0; Will review

@fgimian - If you update this to 1.9.0 and set the ArchiveBinariesDependOnPath, it should work

Hey there @Trenly, this PR already uses manifest version 1.9.0 and leverages the ArchiveBinariesDependOnPath option.
Kindly give it another look and let me know if it looks good 😄
Cheers Fotis

Ah, I didn't see that since the headers still referenced 1.6.0; Will review

Oh let me fix that for you mate, gimme 2 minutes.

@fgimian - If you update this to 1.9.0 and set the ArchiveBinariesDependOnPath, it should work

Hey there @Trenly, this PR already uses manifest version 1.9.0 and leverages the ArchiveBinariesDependOnPath option.
Kindly give it another look and let me know if it looks good 😄
Cheers Fotis

Ah, I didn't see that since the headers still referenced 1.6.0; Will review

Oh let me fix that for you mate, gimme 2 minutes.

No need; they don’t really impact anything other than intellisense

@fgimian - If you update this to 1.9.0 and set the ArchiveBinariesDependOnPath, it should work

Hey there @Trenly, this PR already uses manifest version 1.9.0 and leverages the ArchiveBinariesDependOnPath option.
Kindly give it another look and let me know if it looks good 😄
Cheers Fotis

Ah, I didn't see that since the headers still referenced 1.6.0; Will review

Oh let me fix that for you mate, gimme 2 minutes.

No need; they don’t really impact anything other than intellisense

Oh oops, just forced pushed that fix for completeness.
~\source\winget-pkgs on  Xiph.FLAC-1.4.3-d7a14a5b-ee2b-428b-8731-bb4e85c13e6b [+]
🕙 [ 10:22:23 AM ] ❯ git diffc | cat
diff --git a/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.installer.yaml b/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.installer.yaml
index 1dec2950cad..d5e42434525 100644
--- a/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.installer.yaml
+++ b/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.installer.yaml
@@ -1,5 +1,5 @@
 # Created using wingetcreate <IP_ADDRESS>
-# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.6.0.schema.json
+# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.9.0.schema.json

 PackageIdentifier: Xiph.FLAC
 PackageVersion: 1.4.3
diff --git a/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.locale.en-US.yaml b/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.locale.en-US.yaml
index a3e5cc32a66..3e5ca45f2e7 100644
--- a/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.locale.en-US.yaml
+++ b/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.locale.en-US.yaml
@@ -1,5 +1,5 @@
 # Created using wingetcreate <IP_ADDRESS>
-# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.6.0.schema.json
+# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.9.0.schema.json

 PackageIdentifier: Xiph.FLAC
 PackageVersion: 1.4.3
diff --git a/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.yaml b/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.yaml
index be547684202..30747e94547 100644
--- a/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.yaml
+++ b/manifests/x/Xiph/FLAC/1.4.3/Xiph.FLAC.yaml
@@ -1,5 +1,5 @@
 # Created using wingetcreate <IP_ADDRESS>
-# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.6.0.schema.json
+# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.9.0.schema.json

 PackageIdentifier: Xiph.FLAC
 PackageVersion: 1.4.3
``

Here's the `git diff` since the last commit for your reference.

Thanks heaps
Fotis

@denelon Sorry to tag you in, but this is relatively similar to the PR for the LAME MP3 encoder which you helped me with. The downloads linked to by the official FLAC site technically reside at a different domain. As I mentioned above, the source code and release binaries are also published on GitHub on the official flac repo, so I'm happy to switch to that dowload if it's preferred (they are identical as compared via checksums here), but the website dowlnoad link does direct you to the links I used.

Thank you so much for the merge!
Cheers
Fotis


Add FreeBSD build requirements

Added FreeBSD build requirements info to README, per @dfellis request, #396

Coverage remained the same at 99.187% when pulling dcd41591362e46f71502eb308f9287f24fc40f0c on aircraft-noise:feature/freebsd-readme into c99cad0dec4ce7f53561eea562eb3ee768a0a4bd on uber:master.


forked-to is broken

This is similar to #2759, but with more problems:

Sometimes the link to my own fork is there, but most of time it's not.

Sometimes the relationship is reversed.

Sometimes both source repo and fork repo are displayed.

Reply to this email directly, view it on GitHub
https://github.com/sindresorhus/refined-github/issues/2885, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AOBYL2UGF537GGFK3KKBTHDRHENCLANCNFSM4LGRZM4A
.

and I think it’s the same issue

Sorry, I missed https://github.com/sindresorhus/refined-github/issues/2759#issuecomment-582094588, this is very likely a duplicate issue. But keep it open is fine.
Just in case it would be helpful, I'm a member of @ncuhome which the repository belongs to (though not a collaborator of the repository), in the second and third images.


svtools vcfpaste error

Hi,
I have 50 samples vcffiles from CNVntor tool. So further I am trying per-sample VCFs were combine together using svtools vcfpaste.
While running svtools vcfpaste -f vcf_file_list -t temp-dir, I am getting ERROR: VCF files differ in length.
Kindly help to fix this issues. Thanks in advance.
Regards
Krithika S

Could you help me review this issue?

Have you solved it yet? I had the same problem。Thanks!


How many bottles now?

This is about solving the ramping problem described here.
So, I tried to crawl through the code and get an approximation of a mental map of what is going on in the code. I think I get the FP (elegant) expander but you lost me with the beer. I understand the ramping problem, but how is that actually solved? I can see that beer moved the overlap detection from clojure space to a mongo query (`get-overlapping-candidates', now that query is easy to read; not) and the clones are stored in the database instead of in memory. But is that the actual core of the solution, or where is it?

There are a number of factors that help us out here. First is that only one candidate (and possible expansions) is kept in memory. Second is that we shift processing from clojure to the database, so the database connection does not time out as easily.
But the biggest factor is, I think, that the bundle of joy get-overlapping-candidates is a series of filters (which databases are really good at) where already the first $match quickly reduces the number of elements to continue looking at.
Also, for every successfully expanded clone the set of candidates shrinks, whereas in the "elegant" solution we just get more and more clones to match every new candidate with. If the database can execute the query the first time (and why shouldn't it, it is just a set of filters), life is only going to get easier.


php_self

The php_self function returns http://<>:443 for an https domain which is rejected by apache.
If I change it to the following
I have worked around by forcing https and ignoring port.

Fix applied


[CI] Use Vault repository to re-gain access to devtoolset-4

tests/ci_build/Dockerfile.gpu_build: devtoolset-4 is no longer available from mirror.centos.org. So use vault.centos.org repository instead.
tests/ci_build/Dockerfile.jvm: devtoolset-6 has been removed from centos-sclo-rh-testing repository, not too long after devtoolset-4 had been removed there (#5506). Use vault.centos.org repository instead.

In the long term, we should migrate to CentOS 7. Python community recently adopted PEP 599, which creates manylinux2014 tag to designate wheels built with CentOS 7.


[improve][doc]add more explanation for retention configuration

Motivation
Current retention configuration is not clear for user especially the explanation of default value . So add more explanation for retention configuration
Verifying this change
Make sure that the change passes the CI checks.
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] doc

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@codelipenghui @Anonymitaet Could you help review this again ?

For both defaultRetentionTimeInMinutes < 0 and defaultRetentionSizeInMB < 0 means infinite data retention?
We'd better provide more information about the defaultRetentionTimeInMinutes and defaultRetentionSizeInMB interaction.

Yes it is. defaultRetentionTimeInMinutes and defaultRetentionSizeInMB work separately.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Train problems

For personal needs, I used my own dataset to run the siamfc framework, because my dataset was relatively small, and this warning appeared during the training：
2018-12-11 09:55:17.278447: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:18.115279: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:18.486890: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:18.658596: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:18.737470: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
INFO - root - 2018-12-11 09:55:18.943072: step 332510, total loss = 0.91, batch loss = 0.84 (78.8 examples/sec; 0.102 sec/batch; 3h:45m:00s remains)
2018-12-11 09:55:19.037643: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:19.252102: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:19.566876: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:19.773020: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
INFO - root - 2018-12-11 09:55:19.993944: step 332520, total loss = 0.60, batch loss = 0.54 (79.5 examples/sec; 0.101 sec/batch; 3h:43m:09s remains)
2018-12-11 09:55:20.090338: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:20.318091: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:20.663695: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
2018-12-11 09:55:20.816399: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
INFO - root - 2018-12-11 09:55:21.111168: step 332530, total loss = 0.76, batch loss = 0.69 (58.0 examples/sec; 0.138 sec/batch; 5h:05m:38s remains)
2018-12-11 09:55:21.181763: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
^C2018-12-11 09:55:21.232668: W tensorflow/core/framework/op_kernel.cc:1192] Out of range: exceptions.StopIteration: Iteration finished.
It can be trained, I would like to ask, this will affect the training results?

This warning just means the dataloader has reached the end of one epoch. It won't affect training since it will reiterate from the start. However, with small training set, you may face the overfitting issue.

Thank you very much for your reply


bug: unable to refresh state for dynatrace_http_monitor associated to a management zone

Got
│ Error: json: cannot unmarshal object into Go struct field HTTPSyntheticMonitorUpdate.managementZones of type string

while terraform refreshes state for a dynatrace_http_monitor resource assigned to a management zone since the API returns a list of object instead of a list of string as follow:
  "managementZones": [
    {
      "id": "11111111111111111",
      "name": "Management zone name"
    }
  ],

I guess this patch https://github.com/dtcookie/dynatrace/pull/4 should solve the issue but had no chance to test it for now on.

I also applied the same fix for dynatrace_browser_monitor.
Thanks for contributing!

This issue is still present, I guess this PR fixes it: https://github.com/dtcookie/dynatrace/pull/5

Silly me. I didn't remove the fields from the underlying data structure. Release 1.8.2 is already building.


audit-avt1-gs-design: more than one nav role

Environment

Operating system: Mac
Browser: Chrome
AVT :one:
Page: Get Started - Design
See more info & solution here:

Detailed Description:
Multiple elements with 'nav' role do not have unique labels or remove nav role
What to do:
Add unique labels to each tab
Why is this important?

PR can be found here in gatsby theme: https://github.com/carbon-design-system/gatsby-theme-carbon/pull/1063


Simplify stride interface

This is not a high priority at the moment, but as discussed in #24, it would be good to improve the user friendliness of the stride functionality, through a F or C layout style and shape/size inference.
This should also be documented in (and potentially help clarify) the discussion about when to transpose arrays, in both the ResNet example and (soon) the long-form documentation.

If you look at the ftorch.f90 source there is a function t_t_from_array() (which should probably become torch_tensor_from_array) that assumes 'F' indexing and removes the need for the user to pass in the layout argument (used to set strides).
The idea of this is that is creates a tensor that can be read in with the same indexing in Torch without the user having to worry about it.

This should be the default option to users and we should be VERY EXPLICIT in the docs that using this function you assume the same indexing in Fortran and Torch.
We should look at if we can simplify the examples, making the use of torch_tensor_from_blob with layout an 'advanced' option
This should be clearly set out in the README and API docs (see #53)


Get CI running again

I like where this is going 👍

This isn't green for me locally, based on https://github.com/iftheshoefritz/solargraph-rails/pull/58/commits/5d6fc92c2ed98775c1c5552643842864cbd53162 I assume they are for you? It's the two devise tests that are complaining.


protractor unable to locate element on non angular page

describe('cct homepage',function(){
it('should open the page with title',function()
{
browser.manage().timeouts().setScriptTimeout(60000);
browser.pause(5000);
browser.ignoreSynchronization=true;
browser.get("http://google.com",400000);
browser.sleep(2000);
element(by.id('q')).sendKeys('hi');
});
protractor is unable to identify the element, can you help me and let me know what is the issue with my code

Hi there!
Your question is better suited for StackOverflow or Gitter. Please ask a question there with the 'protractor' tag or post in the Gitter Channel to get help.
From the the getting help section of the README:

Please ask usage and debugging questions on StackOverflow (use the "protractor" tag) or in the Angular discussion group. (Please do not ask support questions here on Github.)


Update Ledger libraries

https://github.com/LedgerHQ/ledgerjs
Also related to #209

CAL migrated to Chainify


Update README.md

The master branch is for Cake 3/4 only. Also it's too late to be promoting plugins for Cake 2 which is already EOL.


Allow option to rename users and rooms collections

Is your feature request related to a problem?
There are users who might already have those collections and we will have data collisions.
What solution would you suggest?
Add an option to provide custom names for those collections.
Related issues/PRs
#12

Released in v1.4.2.


Establish Meshery Release Channels

Enhancement Description
In accordance with the Build & Release Strategy, implement two release channels for all of Meshery's artifacts: meshery, mesheryctl, meshery adapters.

"stable" and "edge" channels

Hi @RaulEsMas, we're spinning up a CI working group. To meet next week (check the #meshery channel for details), it would be good to have you there!

@naturalett we can start by creating one channel (stable) with version control similar to that of what @kanishkarj did in image-hub ci.yml.

Completed.


[BUG] process-agent concurrent map iteration and map write

Agent Environment
Kubernetes, agent image agent:7.46.0
Describe what happened:
Fatal error in process-agent:
gist
Describe what you expected:
Continued successful operation
Steps to reproduce the issue:
Kubernetes container config:
    - name: process-agent
      image: public.ecr.aws/datadog/agent:7.46.0
      command:
        - process-agent
        - '--cfgpath=/etc/datadog-agent/datadog.yaml'
      env:
        - name: GODEBUG
          value: x509ignoreCN=0
        - name: DD_API_KEY
          valueFrom:
            secretKeyRef:
              name: datadog
              key: api-key
        - name: DD_REMOTE_CONFIGURATION_ENABLED
          value: 'false'
        - name: DD_AUTH_TOKEN_FILE_PATH
          value: /etc/datadog-agent/auth/token
        - name: DD_CLUSTER_NAME
          value: REDACTED
        - name: DD_TAGS
          value: EKS:REDACTED
        - name: KUBERNETES
          value: 'yes'
        - name: DD_KUBERNETES_KUBELET_HOST
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: status.hostIP
        - name: DD_HISTOGRAM_PERCENTILES
          value: 0.90 0.95 0.99
        - name: DD_LOG_FORMAT_JSON
          value: 'true'
        - name: DD_OTLP_CONFIG_RECEIVER_PROTOCOLS_GRPC_ENDPOINT
          value: <IP_ADDRESS>:4317
        - name: DD_OTLP_CONFIG_RECEIVER_PROTOCOLS_HTTP_ENDPOINT
          value: <IP_ADDRESS>:4318
        - name: DD_CLUSTER_AGENT_ENABLED
          value: 'true'
        - name: DD_CLUSTER_AGENT_KUBERNETES_SERVICE_NAME
          value: datadog-cluster-agent
        - name: DD_CLUSTER_AGENT_AUTH_TOKEN
          valueFrom:
            secretKeyRef:
              name: datadog-cluster-agent
              key: token
        - name: DD_PROCESS_AGENT_ENABLED
          value: 'true'
        - name: DD_PROCESS_AGENT_DISCOVERY_ENABLED
          value: 'true'
        - name: DD_LOG_LEVEL
          value: INFO
        - name: DD_SYSTEM_PROBE_ENABLED
          value: 'true'
        - name: DD_SYSTEM_PROBE_NETWORK_ENABLED
          value: 'true'
        - name: DD_DOGSTATSD_SOCKET
          value: /var/run/datadog/statsd.sock
        - name: DD_ORCHESTRATOR_EXPLORER_ENABLED
          value: 'true'
      resources:
        limits:
          cpu: 100m
          memory: 512Mi
        requests:
          cpu: 60m
          memory: 200Mi
      volumeMounts:
        - name: config
          readOnly: true
          mountPath: /etc/datadog-agent
        - name: logdatadog
          mountPath: /var/log/datadog
        - name: auth-token
          readOnly: true
          mountPath: /etc/datadog-agent/auth
        - name: dsdsocket
          mountPath: /var/run/datadog
        - name: tmpdir
          mountPath: /tmp
        - name: os-release-file
          readOnly: true
          mountPath: /host/etc/os-release
        - name: runtimesocketdir
          readOnly: true
          mountPath: /host/var/run
          mountPropagation: None
        - name: cgroups
          readOnly: true
          mountPath: /host/sys/fs/cgroup
          mountPropagation: None
        - name: passwd
          readOnly: true
          mountPath: /etc/passwd
        - name: procdir
          readOnly: true
          mountPath: /host/proc
          mountPropagation: None
        - name: sysprobe-socket-dir
          readOnly: true
          mountPath: /var/run/sysprobe
        - name: sysprobe-config
          readOnly: true
          mountPath: /etc/datadog-agent/system-probe.yaml
          subPath: system-probe.yaml
        - name: kubeletlogs
          mountPath: /var/log/journal
        - name: kube-api-access-kwl4z
          readOnly: true
          mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      terminationMessagePath: /dev/termination-log
      terminationMessagePolicy: File
      imagePullPolicy: IfNotPresent

Additional environment details (Operating System, Cloud provider, etc):
AWS EKS 1.26

Hello,
We believe this has been addressed with https://github.com/DataDog/datadog-agent/pull/16803, so upgrading to 7.47 should resolve the issue.

Closing as this should be fixed in 7.47 as mentioned above.


Update howto-vm-sign-in-azure-ad-windows.md

@MicrosoftGuyJFlo
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@MicrosoftGuyJFlo @Court72
Could you review this?

@junhasems this is what the doc originally said but we had multiple complaints that we were not specific enough.


Edited to work with arduino 1.5.x library format.

Produces the configuration files in /extras/docs and link source
codes in /src.

#1


Add all-in-one installation script/docs

fix #181

/hold cancel

look good to me

@MooreZheng PTAL

Updated according to all review coment.
And tested, we can try it online on https://www.katacoda.com/kubeedge-sedna/scenarios/all-in-one
/approve

So let's merge it😄, @MooreZheng @JimmyYang20

/lgtm


cpu:4 tag not properly applied to verilated tests

using --test_tag_filters:cpu:4 doesn't identify verilated tests which seems to indicate the reason it's not working could relate to the application of the tag failing somewhere


earnings not working properly

Just tried to call earnings dataframe for ticker: JAV2.F
The data is clearly on the Yahoo Finance website but the function returns an empty DF with the wrong columns.

Can you please tell me how to fix this?
Anyone else experiencing this problem?

BTW it is not a stand alone problem - there are more tickers where I experience this.

I have had a quick look and it seems that utils.get_json('https://finance.yahoo.com/quote/JAV2.F/financials') queries yahoo finance and gets an html without any earning data in:
_json.loads(json_str)['context']['dispatcher']['stores']['QuoteSummaryStore'] (utils.py line 108)
there might be more information in:
_json.loads(json_str)['context']['dispatcher']['stores']['QuoteTimeSeriesStore']['timeSeries'] (utils.py line 112) but not exactly what you're looking for.
To sum up, the issue comes from the data fetched from yahoo instead of yfinance package.

Yes, it is probably not there... the earnings function is not working but you can find the data in de financials function under "total revenue".
There are many issues reported for this I found


Link pointed to in "See XAML images sample for example code." needs to be updated

https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.media.imagebrush.imagesource#setting-imagesource-in-code gets redirected to https://docs.microsoft.com/en-us/samples/browse/?redirectedfrom=MSDN-samples now where we need to search for the Xaml sample explicitly. Would be nice to update the link here at this point. Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7706f2c9-a534-18f1-dabe-aab8eba3f1bf
Version Independent ID: 0dc8e443-0df8-021a-0b93-6d8dd1fc054b
Content: ImageBrush.ImageSource Property (Windows.UI.Xaml.Media) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.ui.xaml.media.imagebrush.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: wdg-dev-content
Microsoft Alias: wdg-dev-content

This link has been fixed. Thanks.


How to force logout / endSession

When i start sample 2 with Resource Owner Password flow i get the whole flow working except the logout  or endSession working. When i call the "/connect/endsession" i get a not found error. Any help will be appreciated. From the docs i understand the logoutId is optional....

Resource owner flow is OAuth2, and there is no concept of logout.

Which flow is most used when dealing with API in the cloud and Android Apps in and outside the company?

hybrid + pkce


refactor(prettier) move assignment printing into seperate file

Current dependencies on/for this PR:

main

PR #1544   👈

This stack of pull requests is managed by Graphite.


Allow marking Dialogflow slots as being required.

Should solve #59

@matmunn would be great if you also add a sample in the included spreadsheets and a test to verify it's working

I've added tests.
The Google ones will now fail for you if you run locally since I didn't have permission to update the Google Sheet. Weirdly though, I did have permission to update the Office 365 sheet.


Hardcoded Isp in thrusterStateEffector

Describe the bug
The thrusterStateEffector mass depletion is hardcoded to 100% for all time via line 344 in the effector's c++ file. This doesn't affect thrust output unless mass depletion force contributions are turned on, and the only other impact is when a fuel tank is connected.
To reproduce
Steps to reproduce the behavior:

Create a thrusterStateEffector
override the "updateOnly" parameter for that THRSimConfig to be false, enabling mass depletion force contribution calculations
See thrusting force outputting even with zero thrust command message

OR

Create thrusterStateEffector
Create a fuelTank effector
Connect the thruster to the fuel tank with fuelTank.addThruster
Set thruster command to off
Plot fuel mass and/or fuel mass rate
See fuel mass depleting at a constant rate

Expected behavior
No mass depletion while thruster isn't firing.
Desktop (please complete the following information):

OS: macos
Version 14.4.1
Python version 3.10.7

Additional context
Current fix is being worked in the LASP fork of Basilisk, branch bug/thrusterStateEffector-IspFactor. Since the thrusterStateEffector already doesn't scale mass depletion according to ramp up/down (compare updateEffectorMassProps in thrusterStateEffector to computeStateContribution in thrusterDynamicEffector), the proposed solution is to change the conditional statements that check whether mass should be depleting to query against ops->ThrustFactor instead of ops->IspFactor.

Howdy @spiggottCO , this is the issue we were discussing with the hard coded Isp value.  Looks like two groups found this out within days of each other.


ERROR  : Mount point must be a directory: /usr/local/var/singularity/mnt

Hi, I am new to Docker and Singularity, and I came across an issue with exporting the Docker container to Singularity image:
docker build -t sam
sudo docker run sam (name is adoring_minsky)
sudo singularity create /tmp/sam.img
...
vagrant@vagrant-ubuntu-trusty-64:~$ docker export adoring_minsky | sudo singularity import /tmp/sam.img
ERROR  : Mount point must be a directory: /usr/local/var/singularity/mnt
write /dev/stdout: broken pipe

This is my personal repo for playing around with singularity, I suggest if you have issues with singularity you post to https://github.com/gmkurtzer/singularity/issues.

Oh okay, thanks and sorry about that.

no problem! I can definitely chime in and help on the other thread, just wanted to direct you to the right place ;O)


feat: Oracles page hints

Description
resolves #185
Demo
The feature is initiated from develop, hence the tooltips are still red
https://github.com/aeternity/aescan/assets/15363559/04730b3d-9022-4f63-990e-fb75a787c23c
Checklist:

[x] add oracle page hints

in general I'd question the wording of addressing the user directly as "you" or "your oracle" I think we should be generically explaining the technicalities without addressing users

Agree, rephrased.

@marc0olo All fixed. Could you check againhere, please?


A bit of clarification in ModsMenuState

might be useless, granted that the back key can be seen in controls, although just having it say "BACK" instead of "ESCAPE" or "BACKSPACE" might not be clear to some people, so I made it just slightly more clear to some people.
(And also removed old code that wasn't needed, just because you can.)
Also the extra var was needed since it wouldn't compile otherwise.

pp balls


CIV-9786 test

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-9786
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No


[10.x] Column change from json to longText does not remove json_valid() check

Laravel Version: 10.3.3
PHP Version: 8.2.1
Database Driver & Version: MariaDB 10.10.2

Description:
When doctrine/dbal is installed, changing a column from json to longText changes the column type, but does not remove the json_valid() check.
I'm adding a migration to encrypt some previously json columns as below:
Column created as json in earlier migration:
return new class extends Migration
{
    public function up(): void
    {
        Schema::create('test_models', function (Blueprint $table) {
            $table->id();
            $table->json('settings')->nullable();
            $table->timestamps();
        });
    }
}

Then altered to be longText so I can encrypt them in DB:
return new class extends Migration
{
    public function up(): void
    {
        Schema::table('test_models', function (Blueprint $table) {
            $table->longText('settings')->nullable()->change();
        });
    }
}

After this change(), the DB still has the json_valid() checks assigned to the column, meaning encrypted data fails to insert.
Steps To Reproduce:

Clone example repo containing sample migrations: https://github.com/Muffinman/json-valid-example

git clone https://github.com/Muffinman/json-valid-example
cd json-valid-example
composer install

Migrate fresh DB

php artisan migrate:fresh

(DB Correctly altered and json_valid check is removed.)
SHOW CREATE TABLE `test`.`test_models`;
--- Output
CREATE TABLE `test_models` (
  `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
  `settings` longtext DEFAULT NULL,
  `created_at` timestamp NULL DEFAULT NULL,
  `updated_at` timestamp NULL DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

Install doctrine/dbal and try again:

composer require doctrine/dbal
php artisan migrate:fresh

This does not remove json_valid from the schema:
SHOW CREATE TABLE `test`.`test_models`;
--- Output
CREATE TABLE `test_models` (
  `id` bigint(20) unsigned NOT NULL AUTO_INCREMENT,
  `settings` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_bin DEFAULT NULL CHECK (json_valid(`settings`)),
  `created_at` timestamp NULL DEFAULT NULL,
  `updated_at` timestamp NULL DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;

Note, I also reported this issue here, but a fix might be considered directly in Laravel since doctrine/dbal ^3.0 is recommended in the Upgrade Guide.

Typically I found my own solution immediately after posting!
This works great, as in my case I can't remove doctrine/dbal due to a package dependency.
namespace App\Providers;

use Illuminate\Database\Schema\Builder;

class AppServiceProvider extends ServiceProvider
{
    /**
     * Register any application services.
     */
    public function register(): void
    {
        //
    }

    /**
     * Bootstrap any application services.
     */
    public function boot(): void
    {
        // Force native Laravel schema operations rather than relying on DBAL.
        // See https://github.com/laravel/framework/issues/46467
        Builder::$alwaysUsesNativeSchemaOperationsIfPossible = true;
    }
}


gpdvega

@knaaptime just posted this project in the gitter channel. Seems relevant to splot.
gpdvega
:point_up: June 7, 2019 12:33 PM

thanks for mentioning, this looks really cool for future implementations.


[FLINK-32595][Connectors/Kinesis] Fix the deserialization schema version in the datastream conneter doc

Purpose of the change
Fix the deserialization schema version in the datastream connecter doc.
Verifying this change
This change is a version change in the doc with a manual test.
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for convenience.)

[ ] Dependencies have been added or upgraded
[ ] Public API has been changed (Public API is any class annotated with @Public(Evolving))
[ ] Serializers have been changed
[ ] New feature has been introduced

If yes, how is this documented? (not documented)

Thanks @reswqa for helping review the fix.


Missing example tags page

re #115
https://x-govuk.github.io/govuk-eleventy-plugin/tags/example-tag
https://github.com/x-govuk/govuk-eleventy-plugin/pull/115/files#diff-bae99a25c62b34d8da01bf0901142bf312b86508a92efcc4ad1cc044f71250c6R43
refers to https://x-govuk.github.io/govuk-eleventy-plugin/tags/example-tag
which 404s :(
So I'm a bit lost trying to implement (hacky tags)

Fixed in fa33ae65a592795b82851271dee31dbcb3c6c39a


Broken Link

Link to "https://docs.microsoft.com/en-us/powerapps/developer/data-platform/build-tools-overview" is a 404.
In this sentence "Supported by SolutionPackager and **DevOp**s tools enable continuous integration and continuous delivery (CI/CD)."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ba670cf8-5810-79c4-7a2a-101099ffe1d7
Version Independent ID: 69b7e1fb-9f56-8c07-b1d5-8480fe6d8e1a
Content: Use environment variables in solutions - Power Apps
Content Source: powerapps-docs/maker/data-platform/EnvironmentVariables.md
Service: powerapps
Sub-service: dataverse-maker
GitHub Login: @caburk
Microsoft Alias: caburk

@polks71 Thanks for catching that. The updated topic will be published in a few hours.


Add piwik stats

Before considering merging this branch, could you tell me how to update lang files? This branch adds two more sentences in the settings.
Do I have to add the sentences manually in the resources/lang/*/forms.php files or is there a tool that can do it for me?

@ldidry ideally we should be updating all language files, but I'm sometimes too lazy to do so. The translation functions do fallback to en by default, so I don't usually bother.
With that said @GrahamCampbell will be disappointed in me if I start advocating laziness, so if you could copy them across that'd be perfect.
Once you've done that, squash your commits into one and we will merge.

Ok.
Hum, what is that strange language 'en-UD' ?

Please note that I did not put the strings in en-UD.

@ldidry the en-UD strings are used by CrowdIn for translations :)


config editing (especially JSON)

Should we have some sort of config editing functionality? Templating works for a lot of things but JSON is tricky to template (because commas, and other things.)
Should we just wrap JQ? https://github.com/threatgrid/jqpipe-go

This is really vague, and turns out to not be necessary. In situations where we need JQ we can just call it, and in others we can use templates instead.


add option to set whether replace 1px to rem

add option to set whether replace 1px to rem(in production 1px to rem can't show)

Thank you for your pull request. I am considering adding it but there is already a way to ignore values.
https://github.com/cuth/postcss-pxtorem#a-message-about-ignoring-properties
This allows you to ignore border: 1PX but not letter-spacing: 1px.

this 1px option is useful to those project which is already 1px inside not 1PX. At most situation when we write 1px we really mean that retina 1px and hope not to be replaced by REM, so I use this PR in my project.

+1 to merge it

@cuth I use stylus with postcss and "1PX" is change by stylus to "1 PX" (not sure why) so I can't use this method

I think you've convinced me but I'd rather see this option as a minimum pixel value with the default being zero. Then you could set it to 2 if you wanted to avoid converting 1px.
// default
{
  minPixelValue: 0
}

// to avoid 1px
{
  minPixelValue: 2
}

Also, I would like to deprecate all the underscores and change the options to camelCase.
Would this option satisfy you?

Even better :+1:

Cheers, That is more graceful.


DrawString capabilties

Are there any DrawString capabilities? Or some other way to draw text?

OpenGL.Net is a plain wrapper for OpenGL commands.
If you want to draw characters, try vector or texture font implementation in OpenGL.Net.Objects. Anyway too invasive for a single functionality.
Or implement it yourself.


Add support for the new metrics endpoint replacing MCAC

As we're wrapping up the work on replacing MCAC in the management API, we'll need to make the changes in k8ssandra-operator to support it.
Required changes:

[ ] Add a new field named McacTelemetrySpec.Disabled which will allow enabling/disabling MCAC. The default is false for now. Setting it to true translates into adding the MGMT_API_DISABLE_MCAC env variable to the cassandra container, with a value of true as well.
[ ] A new TelemetrySpec.Cassandra struct must be added to configure the new metrics endpoint. The values there will be used to generate a config map using this file format. Filters can reuse Prometheus's RelabelConfig struct, reduced to just the supported fields for our filters.
[ ] Filters will need to be set by default so that we apply the same ones as with MCAC. Metrics names are fairly similar, so it shouldn't be much of a problem. Filters priority is a little different though, so there could be some converting needed.
[ ] Set the port to 9103 by default if MCAC is disabled so that we don't have to change the ports spec in the container.
[ ] We have to remove the relabelling rules from the service monitors when MCAC is disabled, as the metrics will be correctly labeled in the agent.
[ ] Vector's agent config needs the cassandra_metrics source to point at the new URL: http://localhost:<port>/metrics (using the configured/default port in Cassandra's telemetry) if MCAC is disabled, and the old one if it's still enabled
[ ] Add a deprecation notice in the release notes for MCAC in v1.5.0, with the appropriate information

@olim7t @burmanm, could you check the new description and tell me if I'm missing something?
Thanks!

Filters will need to be set by default so that we apply the same ones as with MCAC

These filters were previosly chosen to avoid MCAC issues, do we still want to keep filtering the same amount?

Set the port to 9103 by default if MCAC is disabled so that we don't have to change the ports spec in the container.

I guess this could be done in the cass-operator?
We also need to agree on the ConfigMap mapping where the config is mounted from. Currently that would go to the PodTemplateSpec, but we should change that.

Add a deprecation notice in the release notes for MCAC in v1.5.0, with the appropriate information

Should probably add to changelog in cass-operator also (as it impacts users there)

Add a new field named McacTelemetrySpec.Disabled which will allow enabling/disabling MCAC. The default is false for now.

Or enabled and keep it true for now? Which way do we want to look at it?

These filters were previosly chosen to avoid MCAC issues, do we still want to keep filtering the same amount?

I think we should remove by default anything that we don't use in our dashboards. Cassandra can generate an impressive amount of metrics. That would only apply to k8ssandra-operator clusters though.

I guess this could be done in the cass-operator?
We also need to agree on the ConfigMap mapping where the config is mounted from. Currently that would go to the PodTemplateSpec, but we should change that.

How would you change that? By adding a configmap reference in the cassdc spec to provide the configmap?

Should probably add to changelog in cass-operator also (as it impacts users there)

good point 👍

Or enabled and keep it true for now? Which way do we want to look at it?

That's what I had written initially, but then it creates confusion with the env variable that allows to disable MCAC (you need to set it to true to have it disabled). I figured it would be less confusing to do the same, knowing that we'll remove this eventually anyway.

Add a new field named McacTelemetrySpec.Disabled which will allow enabling/disabling MCAC. The default is false for now. Setting it to true translates into adding the MGMT_API_DISABLE_MCAC env variable to the cassandra container, with a value of true as well.

We should make this field an Enabled and set the value true for now. We don't have Disabled type fields in this system and shouldn't have double negatives for users to think about.
Raising first cut of a PR now.


initial loading screen flashes white theme even when switching to dark theme on startup

we should have the initial loading screen match whichever theme is the users preference.

Thank you for adding this issue. I experienced this as well.

I actually didn't see any loading screen flashes (except for the app's loading screen which is always white). I did find that the theme switch wasn't getting saved to application state because the store was getting committed via v-model and a getter instead of a mutation that included persistent storage updates.

Good catch @okwme !

@okwme check this out too:
https://electronjs.org/docs/api/browser-window#showing-window-gracefully

We need to set the whole color schema. Just the background will not be enough I guess.

i set the color in my PR #865 but there is another option where we can control when the window opens. like how slack handles it - you'll notice - they don't show a blank screen, they wait until the loading graphic is ready and they show that. no flash of blankness.


Speed up hyperparameter tuning by caching quantile sketch

https://discuss.xgboost.ai/t/saving-dmatrix-after-building-quantile-cuts-and-historgram/1937

@ShvetsKS Related to the discussion in https://github.com/dmlc/xgboost/issues/6283 .


Set up CI/CD Pipeline

As a developer
I need to set up a CI/CD pipeline,
So that codes changes are automatically tested and deployed
Details and Assumptions

[document what you know]

Acceptance Criteria
Given [some context]
When [action taken]
Then [outcome observed]

According to the project, we need a yellow "technical debt" label and add appropriate labels to all of stories that don't deliver customer value but are required to develop our service.


ITSM and ITIL

check with ITSM folks on linkages with ITIL
Project to Product has concepts similar to ITIL (end to end vue of service offering, including support) but uses different languages

Awaiting ITSM information materials (where ITIL links and further reading materials on the topic)


[README] Proposal for a more informative README.md

I've tried to put together all the issues that we commented during our last meeting, on how to contribute, when we meet, how we're structured, the usual process to propose changes, etc. I propose this just as a first step, further pull requests could refine everything in this file.
For some file/directory names I'm proposing another pull request, simplifying their names (I'm already using the "new" names here).

I think this reads well and describes the process clearly. There are some minor typos but other wise good. I am not sure how to share those here. I would be happy to edit the document.
I like the issue requirement. Due to the nature of the work, I think it is important to explicitly link pull requests to issues.


CloudFormation pca-ui web LogBucket & CFN Bucket ACL change

Issue #163 :
The stack fails to deploy in either of the supported regions. Info from the failed stack is:
The following resource(s) failed to create: [LogBucket].
Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting (Service: Amazon S3; Status Code: 400; Error Code: InvalidBucketAclWithObjectOwnership;
Description of changes:
Modified the web.template in the pca-ui:
In the LogBucket declaration:

Removed AccessControl: LogDeliveryWrite
Added:
PublicAccessBlockConfiguration:       BlockPublicAcls: false     OwnershipControls:       Rules:         - ObjectOwnership: ObjectWriter

This change fixes the deployment of the stack when published privately.
For public publishing, explicit enabling of bucket's ACLs were included in both publish.sh and publish-nokendra.sh.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks you so much, @aarondiuz !  Really appreciate the PR.. Merged - and will release later today after some quick testing.

Hi @aarondiuz
After merging and rebuilding, I notice now that a stack UPDATE fails..

Also, no closer examination, I see your changes also

removed  AccessControl: LogDeliveryWrite
Added BlockPublicAcls: false
Can you clarify why these two changes are needed?  I'm thinking we (1) continue to need LogDeliverWrite access and that (2) we do NOT want to overwrite BlockPublicAcls for the LogBucket?

Updating release to undo (1) and (2) above..  Let me know if you think these are needed.. Cheers, Bob

Hi @rstrahan
I actually wasn't able to test the stack update since I didn't have the stack deployed when the issues with the buckets started to appear. It was when I tried to deploy a fresh stack when the reported error from #163 occured to me:
Bucket cannot have ACLs set with ObjectOwnership's BucketOwnerEnforced setting (Service: Amazon S3; Status Code: 400; Error Code: InvalidBucketAclWithObjectOwnership;
After I applied the changes from my PR I was able to avoid that error and deploy the stack.
However, now that I'm reading your comments, I performed some tests, and you're right, there's no need to include (1) and (2) from above. The only required change/addition in the web.template file was:
OwnershipControls:     Rules:       - ObjectOwnership: ObjectWriter
I appreaciate your feedback. Thanks!


Do not close void elements

Void elements must not have end tags and they can't have any content.
I have skipped the keygen element as it's deprecated.
This is different to the behaviour of React DOM which will output a closing tag if the element is given children. This implementation outputs no closing tag as this is the way it will be interpreted by the HTML parser.

Wonderful, this is elegant.
Thanks!


Add component type selector dialog

Add component type selector dialog to "add component" button. I suggest "source" (see NXsource documentation) and "detector" options would be good to start with.

Monitors are also important. They are basically single-pixel detectors. Like detectors they can have a pixel ID (but only 1).


Feature/stmux integration

Coverage remained the same at 100.0% when pulling b9924fcbeaa886d1c608e37c8a742aba26f713fd on feature/stmux-integration into 24cae3f724053b4620755bc16ef7952ccef369d2 on master.


reupdate issue at versions

this pull related to https://github.com/cockroachdb/docs/pull/3359
you can find
- there is update at 'cockroach node status' result
the result included 'is_live' which is not exist before
- other update at sql shell 'SHOW EXPERIMENTAL_RANGES FROM TABLE table' result
the result included 'Range ID' which is not exist before

These changes have been made to the current stable (19.1) and dev (19.2) versions of the docs in the meantime, so closing this. Thanks @tarekbadrshalaan.


Fetch PRs into local branches

Fixes #4.

Does the API provide any information about how to get information about the target of the pull request. I've noticed that GitHub either tracks the shared common commit for the pull request and target branch, or the current state of the target branch (I'm not sure which) and only shows differences based on that commit. New changes to the target branch aren't usually displayed. It would be good to understand how we might consume information about pull requests, which includes where they were pointed at the time.

I think that simply comes from git.  Given two commits, it can show you the things that are on the second history that aren't on the first, ignoring anything that is in the first but not the second.  It's essentially the same list that's used for a rebase.  Of course, that means for any given comment, we'll need to capture the commit it's pointing to.  And what about comments on commits that were rebased away?


Update deployment for Azure Functions

Update the Azure Functions pipeline to execute/deploy on commit to main only.

Implemented in https://github.com/jguadagno/jjgnet-broadcast/commit/d9648a049b172cd600dcfb8a5847ff6e852ddbc9


Fix typo in flags

Which problem is this PR solving?

A typo in TLS parameter descriptions

Short description of the changes

Can be seen in the diff

@kvaidas could you please sign off the commit?
Here are some instructions on how to do it https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md#certificate-of-origin---sign-your-work

@pavolloffay maybe the checks are stuck or something?

thanks!