Blue Button client: Verification of FHIR R4 EOB data from Blue Button indicates 2 missing fields

When sending data to LinuxForHealth connect using the Blue Button client, verification of  ExplanationOfBenefit data indicates 2 missing fields in each EOB instance in the Bundle returned from CMS Blue Button.  The result is an HTTP 500 error and the following error is seen in the LFH connect trace log:
2021-11-01 19:12:07,976 - connect.workflows.core - TRACE - FhirWorkflow error: incoming error = 20 validation errors for Bundle
entry -> 0 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 0 -> resource -> provider
  field required (type=value_error.missing)
entry -> 1 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 1 -> resource -> provider
  field required (type=value_error.missing)
entry -> 2 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 2 -> resource -> provider
  field required (type=value_error.missing)
entry -> 3 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 3 -> resource -> provider
  field required (type=value_error.missing)
entry -> 4 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 4 -> resource -> provider
  field required (type=value_error.missing)
entry -> 5 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 5 -> resource -> provider
  field required (type=value_error.missing)
entry -> 6 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 6 -> resource -> provider
  field required (type=value_error.missing)
entry -> 7 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 7 -> resource -> provider
  field required (type=value_error.missing)
entry -> 8 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 8 -> resource -> provider
  field required (type=value_error.missing)
entry -> 9 -> resource -> insurance -> 0 -> __root__ -> focal
  field required (type=value_error.missing)
entry -> 9 -> resource -> provider
  field required (type=value_error.missing)
2021-11-01 19:12:08,043 - connect.clients.kafka - TRACE - Produced record to topic LFH_EXCEPTION partition [0] @ offset 4

A PR was created here: https://github.com/CMSgov/beneficiary-fhir-data/issues/804
and was reported via the Blue Button dev google group: https://groups.google.com/g/Developer-group-for-cms-blue-button-api

Excerpts from http://hl7.org/fhir/us/carin-bb/STU1.1/StructureDefinition-C4BB-ExplanationOfBenefit-Professional-NonClinician.profile.json.html that support the fact that ExplanationOfBenefit.provider and ExplanationOfBenefit.insurance.focal are required:
{
      "id" : "ExplanationOfBenefit.provider",
      "path" : "ExplanationOfBenefit.provider",
      "short" : "Party responsible for the claim",
      "definition" : "The provider which is responsible for the claim, predetermination or preauthorization.",
      "comment" : "The identifier assigned to the Billing Provider. (94)",
      "min" : 1,
      "max" : "1",
      "base" : {
        "path" : "ExplanationOfBenefit.provider",
        "min" : 1,
        "max" : "1"
      },
      "type" : [
        {
          "code" : "Reference",
          "targetProfile" : [
            "http://hl7.org/fhir/us/carin-bb/StructureDefinition/C4BB-Organization",
            "http://hl7.org/fhir/us/carin-bb/StructureDefinition/C4BB-Practitioner"
          ]
        }
      ],
      "constraint" : [
        {
          "key" : "ele-1",
          "severity" : "error",
          "human" : "All FHIR elements must have a @value or children",
          "expression" : "hasValue() or (children().count() > id.count())",
          "xpath" : "@value|f:*|h:div",
          "source" : "http://hl7.org/fhir/StructureDefinition/Element"
        }
      ],
      "mustSupport" : true,
      "isModifier" : false,
      "isSummary" : true,
      "mapping" : [
        {
          "identity" : "w5",
          "map" : "FiveWs.source"
        }
      ]
    },

    {
      "id" : "ExplanationOfBenefit.insurance.focal",
      "path" : "ExplanationOfBenefit.insurance.focal",
      "short" : "Coverage to be used for adjudication",
      "definition" : "A flag to indicate that this Coverage is to be used for adjudication of this claim when set to true.",
      "comment" : "A patient may (will) have multiple insurance policies which provide reimbursement for healthcare services and products. For example, a person may also be covered by their spouse's policy and both appear in the list (and may be from the same insurer). This flag will be set to true for only one of the listed policies and that policy will be used for adjudicating this claim. Other claims would be created to request adjudication against the other listed policies. An invariant is defined to enforce the following rule:  Will have multiple occurrences on secondary / tertiary, etc. claims.  Up to one occurrence, that of the ExplanationOfBenefit.insurer, will have a boolean value = 'True'",
      "requirements" : "To identify which coverage in the list is being used to adjudicate this claim.",
      "min" : 1,
      "max" : "1",
      "base" : {
        "path" : "ExplanationOfBenefit.insurance.focal",
        "min" : 1,
        "max" : "1"
      },
      "type" : [
        {
          "code" : "boolean"
        }
      ],
      "constraint" : [
        {
          "key" : "ele-1",
          "severity" : "error",
          "human" : "All FHIR elements must have a @value or children",
          "expression" : "hasValue() or (children().count() > id.count())",
          "xpath" : "@value|f:*|h:div",
          "source" : "http://hl7.org/fhir/StructureDefinition/Element"
        }
      ],
      "mustSupport" : true,
      "isModifier" : false,
      "isSummary" : true
    },


Topic Validation Incorrect

🐞 Bug Report
Affected Services

 The issue is located in:
Core-Data
Is this a regression?

 Yes, the previous version in which this bug was not present was: ....
Description and Minimal Reproduction
Topic is considered invalid if it doesn't have 5 segments
🔥 Exception or Error

🌍  Your Environment
Deployment Environment:
EdgeX Version:
2.0.x - master
Anything else relevant?

Here is the validation in question: https://github.com/edgexfoundry/edgex-go/blob/master/internal/core/data/application/subscriber.go#L99-L101
I believe this should be removed entirely since the topic base is configurable when publishing.


Blank white screen on launching my flutter app on iOS

Steps to Reproduce

Run the app on the iPhoneX simulator or my iPhone 6s.(The app and the developer are all verified)
The app runs Pod install and installs the application
When the app launches a blank white screen flashes before the app crashes with the logs below.

Note:

The app uses cloud_firestore as a dependancy
The app uses url_launcher as a dependancy

Logs
*** First throw call stack:
(
	0   CoreFoundation                      0x00000001092531e6 __exceptionPreprocess + 294
	1   libobjc.A.dylib                     0x00000001088e8031 objc_exception_throw + 48
	2   CoreFoundation                      0x00000001092c8975 +[NSException raise:format:] + 197
	3   Runner                              0x00000001046dec76 +[FIRApp configure] + 470
	4   Runner                              0x0000000104a385e9 -[FLTCloudFirestorePlugin init] + 185
	5   Runner                              0x0000000104a384a1 +[FLTCloudFirestorePlugin registerWithRegistrar:] + 289
	6   Runner                              0x00000001046882fc +[GeneratedPluginRegistrant registerWithRegistry:] + 124
	7   Runner                        <…>

##xCodeLogs
2018-09-23 16:51:21.716428+0300 Runner[85771:19470478]  - <AppMeasurement>[I-ACS036002] Analytics screen reporting is enabled. Call +[FIRAnalytics setScreenName:setScreenClass:] to set the screen name or override the default screen class name. To disable screen reporting, set the flag FirebaseScreenReportingEnabled to NO (boolean) in the Info.plist
2018-09-23 16:51:22.239910+0300 Runner[85771:19469730] You've implemented -[<UIApplicationDelegate> application:performFetchWithCompletionHandler:], but you still need to add "fetch" to the list of your supported UIBackgroundModes in your Info.plist.
2018-09-23 16:51:22.240079+0300 Runner[85771:19469730] You've implemented -[<UIApplicationDelegate> application:didReceiveRemoteNotification:fetchCompletionHandler:], but you still need to add "remote-notification" to the list of your supported UIBackgroundModes in your Info.plist.
2018-09-23 16:51:22.322985+0300 Runner[85771:19469730] *** Terminating app due to uncaught exception 'com.firebase.core', reason: '`[FIRApp configure];` (`FirebaseApp.configure()` in Swift) could not find a valid GoogleService-Info.plist in your project. Please download one from https://console.firebase.google.com/.'
*** First throw call stack:
(
	0   CoreFoundation                      0x000000010b6941e6 __exceptionPreprocess + 294
	1   libobjc.A.dylib                     0x000000010ad29031 objc_exception_throw + 48
	2   CoreFoundation                      0x000000010b709975 +[NSException raise:format:] + 197
	3   Runner                              0x00000001068d37f6 +[FIRApp configure] + 470
	4   Runner                              0x0000000106c2d309 -[FLTCloudFirestorePlugin init] + 185
	5   Runner                              0x0000000106c2d1c1 +[FLTCloudFirestorePlugin registerWithRegistrar:] + 289
	6   Runner                              0x000000010687ced9 +[GeneratedPluginRegistrant registerWithRegistry:] + 121
	7   Runner                              0x000000010687d15a _T06Runner11AppDelegateC11applicationSbSo13UIApplicationC_s10DictionaryVySC0E16LaunchOptionsKeyVypGSg022didFinishLaunchingWithH0tF + 122
	8   Runner                              0x000000010687d94a _T06Runner11AppDelegateC11applicationSbSo13UIApplicationC_s10DictionaryVySC0E16LaunchOptionsKeyVypGSg022didFinishLaunchingWithH0tFTo + 186
	9   UIKit                               0x000000010c4596fb -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] + 278
	10  UIKit                               0x000000010c45b172 -[UIApplication _callInitializationDelegatesForMainScene:transitionContext:] + 4123
	11  UIKit                               0x000000010c4605cb -[UIApplication _runWithMainScene:transitionContext:completion:] + 1677
	12  UIKit                               0x000000010c822f7e __111-[__UICanvasLifecycleMonitor_Compatability _scheduleFirstCommitForScene:transition:firstActivation:completion:]_block_invoke + 866
	13  UIKit                               0x000000010cbf5a39 +[_UICanvas _enqueuePostSettingUpdateTransactionBlock:] + 153
	14  UIKit                               0x000000010c822bba -[__UICanvasLifecycleMonitor_Compatability _scheduleFirstCommitForScene:transition:firstActivation:completion:] + 236
	15  UIKit                               0x000000010c8233db -[__UICanvasLifecycleMonitor_Compatability activateEventsOnly:withContext:completion:] + 675
	16  UIKit                               0x000000010d194614 __82-[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:]_block_invoke + 299
	17  UIKit                               0x000000010d1944ae -[_UIApplicationCanvas _transitionLifecycleStateWithTransitionContext:completion:] + 433
	18  UIKit                               0x000000010ce7875d __125-[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:]_block_invoke + 221
	19  UIKit                               0x000000010d0734b7 _performActionsWithDelayForTransitionContext + 100
	20  UIKit                               0x000000010ce78627 -[_UICanvasLifecycleSettingsDiffAction performActionsForCanvas:withUpdatedScene:settingsDiff:fromSettings:transitionContext:] + 223
	21  UIKit                               0x000000010cbf50e0 -[_UICanvas scene:didUpdateWithDiff:transitionContext:completion:] + 392
	22  UIKit                               0x000000010c45eeac -[UIApplication workspace:didCreateScene:withTransitionContext:completion:] + 515
	23  UIKit                               0x000000010ca31bcb -[UIApplicationSceneClientAgent scene:didInitializeWithEvent:completion:] + 361
	24  FrontBoardServices                  0x0000000113c1a2f3 -[FBSSceneImpl _didCreateWithTransitionContext:completion:] + 331
	25  FrontBoardServices                  0x0000000113c22cfa __56-[FBSWorkspace client:handleCreateScene:withCompletion:]_block_invoke_2 + 225
	26  libdispatch.dylib                   0x000000010f0f47ec _dispatch_client_callout + 8
	27  libdispatch.dylib                   0x000000010f0f9db8 _dispatch_block_invoke_direct + 592
	28  FrontBoardServices                  0x0000000113c4e470 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 24
	29  FrontBoardServices                  0x0000000113c4e12e -[FBSSerialQueue _performNext] + 439
	30  FrontBoardServices                  0x0000000113c4e68e -[FBSSerialQueue _performNextFromRunLoopSource] + 45
	31  CoreFoundation                      0x000000010b636bb1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
	32  CoreFoundation                      0x000000010b61b4af __CFRunLoopDoSources0 + 271
	33  CoreFoundation                      0x000000010b61aa6f __CFRunLoopRun + 1263
	34  CoreFoundation                      0x000000010b61a30b CFRunLoopRunSpecific + 635
	35  GraphicsServices                    0x000000011229ea73 GSEventRunModal + 62
	36  UIKit                               0x000000010c462057 UIApplicationMain + 159
	37  Runner                              0x000000010687daa7 main + 55
	38  libdyld.dylib                       0x000000010f171955 start + 1
	39  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

##flutter analyze
Analyzing linki...
No issues found! (ran in 5.9s)
##

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.8.2, on Mac OS X 10.13.6 17G65, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[✓] iOS toolchain - develop for iOS devices (Xcode 9.4)
[✓] Android Studio (version 3.1)
[!] IntelliJ IDEA Community Edition (version 2016.2.4)
    ✗ Flutter plugin version 12.1 - the recommended minimum version is 16.0.0
    ✗ This install is older than the minimum recommended version of 2017.1.0.
[✓] VS Code (version 1.27.2)
[✓] Connected devices (2 available)

! Doctor found issues in 1 category.

Same issue.

could not find a valid GoogleService-Info.plist in your project.

Could it be there went something wrong when you added the Firebase plugin?

Actually I must clarify. In my case there are no errors displayed during the build process. However on release mode, the iOS build "randomly" shows only a blank screen. Out of 3 or 4 builds 1 usually works fine.
Sorry for the disturbance, the issue in my case is most likely not related with the current issue.

@polbatllo I'm having the same issue with my iOS builds. Have you figured anything out with regards to this?

Any solutions?

@maxlapides I had the same issue, following a codelabs tutorial. I think the issue is the missing GoogleService-Info.plist, so if you ignore for now and download the plist from Firebase and add it to runner/runner, the app loads.

@maxlapides I had the same issue, following a codelabs tutorial. I think the issue is the missing GoogleService-Info.plist, so if you ignore for now and download the plist from Firebase and add it to runner/runner, the app loads.

this worked. So I tried to add the GoogleService-Info.plist from firebase, and it worked. I don't know why the original one didn't work. Thanks guys.

I'm having issues with this as well.
I've added the GoogleServices-info.plist file multiple times, but when running a release build, it's always a white screen.
Running from xcode does work though, it's only when building using the flutter tool that I get a white screen.
Any ideas?

I'm having issues with this as well.
I've added the GoogleServices-info.plist file multiple times, but when running a release build, it's always a white screen.
Running from xcode does work though, it's only when building using the flutter tool that I get a white screen.
Any ideas?

Did anyone find a solution for this?

If you are building for device try to run flutter clean first & xcode clean - then follow tutorial on how to build for release from flutter site. Also it was important for me before building release from xcode to run flutter build ios from terminal.

If you are building for device try to run flutter clean first & xcode clean - then follow tutorial on how to build for release from flutter site. Also it was important for me before building release from xcode to run flutter build ios from terminal.

On debug / run mode it works fine, but when I archive the app, it shows blank white screen.

I meant archive by "building for device"

@syn-rupendra

On debug / run mode it works fine, but when I archive the app, it shows blank white screen.

for that you need to run flutter build ios --release before you archive the app.
This is a known issue.

@syn-rupendra

On debug / run mode it works fine, but when I archive the app, it shows blank white screen.

for that you need to run flutter build ios --release before you archive the app.
This is a known issue.

Its working now, thanks... you are a lifesaver

Why is there no update on an issue this serious? Every time I try to deploy apps to IOS I get a blank screen and have to go through all these steps again and again to fix it.

same problem it appears and disappears 1 month ago i have the problem then nothing now again....
here i paste the logs of xcode when running the release version:
2019-08-14 17:24:05.665679-0400 Runner[6832:1874400] [DYMTLInitPlatform] platform initialization successful
W0814 17:24:06.374780 1 commandlineflags.cc:1503] Ignoring RegisterValidateFunction() for flag pointer 0x104b674d0: no flag found at that address
2019-08-14 17:24:06.884275-0400 Runner[6832:1874211] [VERBOSE-2:dart_vm_data.cc(19)] VM snapshot invalid and could not be inferred from settings.
2019-08-14 17:24:06.884309-0400 Runner[6832:1874211] [VERBOSE-2:dart_vm.cc(238)] Could not setup VM data to bootstrap the VM from.
2019-08-14 17:24:06.884320-0400 Runner[6832:1874211] [VERBOSE-2:dart_vm_lifecycle.cc(89)] Could not create Dart VM instance.
2019-08-14 17:24:06.884374-0400 Runner[6832:1874211] [VERBOSE-3:shell.cc(218)] Check failed: vm. Must be able to initialize the VM.
also throws a signal SIGABRT on flutterappdelegate

@juanjoserodrigolazaro97 I am having the same issue.

@flyrboy96 I solve this problem by:

add export NO_PROXY=localhost,<IP_ADDRESS> to ~/.bashrc ( or ~/.zshrc if you use zsh )
flutter clean
close all IDE and simulator
re-run debug and then it worked;

@Xbobo5530
This issue has been moved to https://github.com/FirebaseExtended/flutterfire/issues/650. Any further collaboration will be done there.

Running flutter clean fixed things for me.

@syn-rupendra

I am new to flutter and this issue comes may i know flutter build ios --release will this works on specific Devices??

flutter clean worked for me


setCustomSessionId is not a function

Hi,
It seems the version published on npm does not have the setCustomSessionId function added to it. Is there an estimate on when the updated version will be published?
Thanks

An update to the node module (version 1.1.0) is now published that includes the setCustomSessionId function. The updated package can be found here: https://www.npmjs.com/package/@google/chatbase

I'm experiencing the same problem at them moment, would be nice to get an update on this. Maybe it's the combination of a userId and customSessionId?


Chips display Broken on mobile

Chips break on Click on mobile devices
The width gets updated on click
Example after 2 clicks:

Tested on safari and brave on iOS 12.3

Thank you for your report! Will fix over the weekend.

I'm sorry it took me so long. Should be fixed in 0.1.9.


Implement text search

This adds a new button to the top right which turns into a search field when clicked. Search is powered by lunr.js and indices for all languages are created at build time so they are readily available in production.
I've tried to make foreign language search work as well as possible already, but input from our translators would be appreciated. @lianzhao and @botanicaxu, I'd especially like your feedback on the Chinese search!
Changes can be viewed at this preview.
Closes #99

FYI @lianzhao I'll merge the branch for now and we can work on improving the Chinese tokenization as we go, since I expect that to be an ongoing effort.

Hello @PaleoCrafter, I did some research about tokenize Chinese with lunr today, and found a bug in lunr.zh.js which prevent me from tokenizing Chinese correctly with custom dictionary.
I've send a PR to lunr team. With that fix and custom dict, I can make the search work on my local dev env.


(Work in progress) Flush vt100 input after timeout.

This should fix some issues with "playitagainsam" and Cygwin.
It's work in progress.

Has been fixed already by another commit.


[DOCS] Add more info button under each course

Issue Description
Add more info button under each course .By clicking the button, pages will be opened where description and content of the courses will be given.
Additional Context
Please assign me this issue
Screenshots or Examples (if applicable)
No response
Proposed Solution (optional)
No response
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

I think when you click the courses card directly it redirects to the page and there isn't any requirement for more info button under each courses.
So I am closing this issue, please understand.


network error

Describe the bug
network error
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-et4st8
Steps to reproduce
network error
Expected behavior
network error
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36 Edg/<IP_ADDRESS>
performance.memory = {
  "totalJSHeapSize": 88758326,
  "usedJSHeapSize": 84053542,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = FCO0001
Chat ID = e50011246726

Additional context
Error:
network error

Can you please send us a screenshot or additional information so we have the full context of this error? Thanks.


Fixes related to group_keys default change in pandas 2.0

Related: https://github.com/dask/dask/issues/9736.
In pandas 2.0, groupby adds group keys to index.

[x] Tests added / passed
[x] Passes pre-commit run --all-files

Also, I see this is marked as a draft PR. Are there other things you'd still like to include here?

No, not a draft anymore.


Version 0.2.0

This change is

Review status: 0 of 1 files reviewed, all discussions resolved (waiting on @nsthorat)

Comments from Reviewable

Thanks -- 0.2.0 published!


Is there a planned roadmap for performance to catch up with uber-go/zap?

I am looking forward to it

Has this been fixed?
I see 2 solutions here

Writer contention should be the only thing restricting concurrent access
Instead of a JSON marshal happening for every line of log, maybe a string formatting can be done instead? This is easy if the log object is only 1 level deep.

Another question
When calling log.SetOutput(), does logrus rely on the io.Writer to synchronise access or does it synchronise calls to the writer on its own?
In my service I use lumberjack downstream from logrus to provide log rotation. Would this result in the same performance hit(lumberjack synchronises writes to the file. If logrus additionally synchronises calls to the writer, there's a needless performance hit.)

No this has not been fixed because it has not been reported yet as an issue here.
We may create a dedicated performance project to check how to catch up with other logging library.
However, I suspect this is going to be hard without any massive interface change.
Regarding the JSON marshalling, there is another Formatter which just output text based on sprintf formatting.

@dgsb Great ！


chore: add conv3d patch

Signed-off-by: Dheeraj Peri<EMAIL_ADDRESS>Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project (You can use the linters)
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation
[ ] I have added tests to verify my fix or my feature
[ ] New and existing unit tests pass locally with my changes
[ ] I have added the relevant labels to my PR in so that relevant reviewers are notified

Is it pending https://github.com/pytorch/TensorRT/issues/1445 to be fixed?

@yinghai yes, the intention is to show this warning until TensorRT has a fix for this issue.

Closing this as this will be added in https://github.com/pytorch/TensorRT/pull/1477


Build failed

https://github.com/apollographql/apollo-ios/issues/474

The build script has been updated for iOS SDK 0.13.0 with #18. If you're still experiencing issues after this update, please open a new issue. Thank you!


Upgrade to zephyr v2.4.0

This upgrades Zephyr to the current master until the final version of zephyr v2.4.0 is released. I've made a lot of compatibility changes all over the place, including fixing the touch sensor driver. We also move from LVGL version 6 to 7 and so I had to make various changes to the graphics code. I couldn't make the background anything but white so I added a background image instead. Image management appear to work now.

@sdorre, I'm sorry to ask you for reviewing such a massive PR, but I've tried to split the changes into multiple relevant commits at least.

There is an example in lv_theme_mono.c To set Background color and how to init a style.
Something like:
static void basic_init(void)
{
    style_init_reset(&styles->scr);
    lv_style_set_bg_opa(&styles->scr, LV_STATE_DEFAULT, LV_OPA_COVER);
    lv_style_set_bg_color(&styles->scr, LV_STATE_DEFAULT, BG_COLOR);
    lv_style_set_text_color(&styles->scr, LV_STATE_DEFAULT, FG_COLOR);
    lv_style_set_value_color(&styles->scr, LV_STATE_DEFAULT, FG_COLOR);

    style_init_reset(&styles->bg);

There is an example in lv_theme_mono.c To set Background color and how to init a style.
Something like:

static void basic_init(void)

{

    style_init_reset(&styles->scr);

    lv_style_set_bg_opa(&styles->scr, LV_STATE_DEFAULT, LV_OPA_COVER);

    lv_style_set_bg_color(&styles->scr, LV_STATE_DEFAULT, BG_COLOR);

    lv_style_set_text_color(&styles->scr, LV_STATE_DEFAULT, FG_COLOR);

    lv_style_set_value_color(&styles->scr, LV_STATE_DEFAULT, FG_COLOR);

    style_init_reset(&styles->bg);

Yes, I think we also need to enable a theme in prj.conf. I'll give it a try.

I've restored the font size and the simple black background. For the latter I only needed to add CONFIG_LVGL_USE_THEME_MONO=y

It looks good so far

Thanks! I'll just wait for the final v2.4.0 release (which should come very soon) and update west.yml before merging.


Use Webmozart and add tests

Codecov Report

Merging #67 (e2a4b79) into main (0c41f4c) will increase coverage by 0.49%.
 Consider uploading reports for the commit d1bcde3 to get more accurate results

@@             Coverage Diff              @@
##               main      #67      +/-   ##
============================================
+ Coverage     96.38%   96.87%   +0.49%
+ Complexity      446      435      -11
============================================
  Files            30       30
  Lines          1162     1153       -9
============================================
- Hits           1120     1117       -3
+ Misses           42       36       -6

Impacted Files
Coverage Δ

src/Cache/FileCacheManager.php
85.18% <ø> (ø)

src/Cache/FileHandler.php
55.88% <ø> (ø)

src/Runner/Fixer.php
95.87% <ø> (ø)

src/Cache/CacheEncoder.php
87.80% <93.75%> (+3.80%)
:arrow_up:

src/Cache/Cache.php
100.00% <0.00%> (+18.75%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


修改了dist/css/bootstarp.css

Just to learn git, please ignore this modification.

Please test with your own repositories, we have better things to do than closing test issues.


[Razor Pages] String interpolation for @page directive override routes

I had the idea to save all of my routes in a static class of constants like so:
static class Routes
{
    public const string Index = "/index";
    public const string Login = "/account/login";
    public const string Logout = "/account/logout";
    public const string Register = "/account/register";

    // etc.
}

The idea was to have the route defined in one place and then if I even need to change a route, I will only have to change it in one place. For example, if I have multiple handlers that redirect to the login page, changing the login route would require me to change it at the @page directive, and in any IActionResult-returning methods that redirect to the login route (which could exist in many authentication-required pages).
 I'm pretty new to ASP .NET Core.
If not, the feature I am requesting is that string interpolation or some other kind of value passing mechanism would be possible with a page directive. Visual Studio tells me this syntax is correct but when I try to compile it says "the 'page' directive expects a string surrounded by double quotes.".
@page @Routes.Index

I also tried the following and it does not work:
@page $"{Routes.Index}"

Could this be a useful feature for code-maintainability?
EDIT: Typos.

@cbrit thanks for contacting us.
Unfortunately what you are trying to achieve is not possible. Routes are backed by .NET Attributes, which require all parameters to be compile time constants. For that reason, you can't use things like string interpolation in them, as that would require the information for the attribute to be defined at runtime, which is not possible in .NET.


Search within chromes address bar is broken

Whenever I want to use Chrome's search feature in the Adress Bar, I get 0 results, because the url transforms from

to
https://npms.io/search?term=ramda
but npms.io uses
https://npms.io/search?q=ramda
Please 1. either allow term again or tell chrome to use q instead of term.

You should have a cached version of the search. Please remove it from the providers and clear the cache for the npms site.
See: https://github.com/npms-io/npms-www/blob/master/web/opensearch.xml#L8


feat(api): feature API proto definitions

This PR is a proposal for the new Feature flags API.  Questions that need to be answered:

Do we treat "features" as a resource? (current proposal) or do we add them do the resource they apply to (instance, org, user etc)?
Trick question: is System a resource?

Cascading features
Inside zitadel code, features must cascade into a final object used by the runtime to know the state of features. It starts with the defaults and then applies resource specific settings.
Features would be evaluated and applied in the following order. The last one that has a specific feature configuration wins.
defaults -> system -> instance -> user

However, the current proposal documents we will return only the features that where set through the API. This makes sense from a resource API perspective, for example if an organization never had  any custom feature flags set, the get request should return a 404. The feature "object" was never created for the organization object. However,  this might be an hassle for front-end and API consumers. If callers want to know the current state of features, they need to know the defaults and then build the state out of the specific reponses.

Should we always return the current state, regardless if the (instance/org/user) object has custom features set?
How would the caller distinguish if the setting was inherited from a higher level or set on this level?

Related: #6668
Breaking config  changes
In defaults.yaml there are some changes that need modification if those options were set in a local yaml config file by users.

SystemDefaults.Features is added and affects complete system and all instances, for the features that were not set on instance level. (Either by API or DefaultInstance). The defaults are set to false, so this is not a breaking change by itself.
OIDC.Features is removed -> if it was set it will now be ignored in favor of SystemDefaults.Features. This is a breaking change, but the impact is low. Those options where provided as fallback in case the introspection optimization proved to have bugs. We got no reports.
DefaultInstance.Features is changed from a map to a struct type. If - FeatureLoginDefaultOrg was set it needs to be manually adjust to LoginDefaultOrg or else zitadel will fail to start.

Definition of Ready

[ ] I am happy with the code
[ ] Short description of the feature/issue is added in the pr description
[ ] PR is linked to the corresponding user story
[ ] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[ ] No debug or dead code
[ ] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[ ] Functionality of the acceptance criteria is checked manually on the dev system.

CC architects: @livio-a, @adlerhurst
CC resources: @stebenz, @eliobischof
I would like to receive some feedback on above questions.

Do we treat "features" as a resource? (current proposal) or do we add them do the resource they apply to (instance, org, user etc)?

Good question. I think a resource on it's on is consistent with other things like settings, where the level (instance, organisation) is handled in the same service and sometimes even in the same endpoint.

Trick question: is System a resource?

In regards of features i'd say yes, since there's the cascading / hierarchical  functionality of features (as described by you)

Should we always return the current state, regardless if the (instance/org/user) object has custom features set?
How would the caller distinguish if the setting was inherited from a higher level or set on this level?

For 3. and 4. can't we just provide the state no matter on which level it was set and return that it was inherited. We used to do this in the management API for policies with isDefault and i think we do the same now on the settings service where we return the owner type (instance / org).

Do we treat "features" as a resource? (current proposal) or do we add them do the resource they apply to (instance, org, user etc)?

For me there is a direct correlation to how we want to manage new resource changes like the user schema. Do we rather want to manage all features on the user when we change the resource or do we want the features managed without sort of caring what is specifically defined in the user?
As for my answer, I would have it on for example organization level with a link to the user resource, but not on the user resource specificly.

Trick question: is System a resource?
Yes, as you want to cover all levels.

Should we always return the current state, regardless if the (instance/org/user) object has custom features set?
How would the caller distinguish if the setting was inherited from a higher level or set on this level?

IMO a call for the current active resource with some sort of differentiation that you could only get the resource of a defined level should cover what's necessary, the information from which level it comes should be mostly included with the resourceowner right?

Superseeded by https://github.com/zitadel/zitadel/pull/7356


add gzip compression for check_leader requests

What is changed and how it works?

Issue Number: Ref #14553
What's Changed:
The size of check_leader requests is related to the number of leaders. Generally, each region will takes 7 bytes in request and 1 byte in response, when the number of leader is high, the compression saves about 60% traffic in my test.

Add gzip compression for check_leader requests.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Manual test (add detailed scripts or steps below)

CPU utilization (resolved-ts.advance-ts-interval=100ms, 2000 regions per store)

Before

After

Side effects

Performance regression

Consumes more CPU

Release note
Compress traffic of check_leader requests.

/release

/review default

review

@wuhuizuo
The comment from review-bot links this PR to tikv/tikv#1, seems a problem.

Yes, I will try to fix the issue.

/review default

@cfzjywxk, @overvenus this PR is simple and effective, PTAL.

/merge

/cherrypick release-6.5

/cherrypick release-7.1

/release


[Feature Request] Object detection label boxes

Hey @roflcoopter, keep up the great work, v2 is running great :)
I'm using DarkNet for object detection, and I'd like to have a URL/config option that creates a snapshot from the camera containing label boxes around detected objects, kind of like this:

(image taken from https://github.com/WongKinYiu/yolov7#instance-segmentation)
If there already is a way to do this, please let me know :)

When a recording starts, Viseron creates a thumbnail with the objects drawn much like your image.
It is stored next to the recording with the same name but with .jpg extension.
If you want to do it on demand you can check out the MJPEG streams and use the draw_objects option.


Speed up planner plotting

This PR significantly speeds up plotting using the technique described in https://stackoverflow.com/questions/53035858/plot-multiple-values-with-matplotlib-without-loop
To test, you can specifically try some of the multirobot demos / demos with PRMs in them.

There is a small bug from #119 which causes a "referenced before assignment" bug.
Since tgt_loc was replaced with goal_node. this line should also have that change.
I ran the ROS multirobot demo after adding that, there were no errors, but the rendering was spooky, with robots teleporting to different locations, see this video

Actually, this issue is because we're publishing commands before the GUI is started, and that causes things to go out of sync. I'll find a fix to wait til the GUI is running before sending this out.

@ibrahiminfinite Try again? Just made some changes.

@ibrahiminfinite Try again? Just made some changes.

Ran it again, works smooth and the graph plotting is FAST.
Also very nice to see that the GUI is synced up.


[Fix] Revise supported python version

I think python3.5 is also supported.
Description
(Brief description on what this PR is about)
Checklist
Essentials

[ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[ ] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

Job PR-962/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-962/1/index.html


Support SPM

Could you tell me when to expect SPM support? We need to integrate into the project, but we encountered a problem you do not support SPM

If you would like to upvote the priority of this issue, please comment below or react with :+1: so we can see what is popular when we triage.
@Vladlen1 Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

Check the issue tracker - bugs and feature requests for Google Maps Platform APIs and SDKs
Open a support case - Get 1:1 support in Cloud Console.
Discord - chat with other developers
StackOverflow - use the google-maps tag

This is an automated message, feel free to ignore.

Yes but the issue #70 is also closed. Shouldn't we reopen it until the issue is resolved or there is a clear answer that clarifies why it will not be resolved?

I don't understand why it is closed, when SPM is still not supported? Requested in 2021...by the end of 2023...nothing has happened.

Maps, Places, and Navigation SDKs for iOS are now available through Swift Package Manager. See the blog post and install instructions. 🎁


Package the language server for publishing in NPM

Hello :octocat:
I want to publish our language server to NPM in order to make it easy to install and run from the LSP client for Emacs.
This shouldn't change anything about how we publish the VSCode extension, at least for now. I'm also not automating the release process yet. I plan to run a manual release once this PR is approved.

[ ] Tests added for any new code
[ ] Documentation added for any new functionality
[ ] Entries added to the respective CHANGELOG.md for any new functionality
[ ] Feature table on README.md updated for any listed functionality

Looks good! I wonder why the diff size is 12k?

It's only the package.lock file causing that huge diff. Idk why it changed so much, but since I renamed the package itself (from quint-lsp-server to quint-language-server, it might have affected the hashes of every single dependency or something like that.

It's only the package.lock file causing that huge diff. Idk why it changed so much

Looks like indentation changed from 8 to 2 blanks 😄


[Grab 100 MDOT] Earning Page Demo

Describe the task
Implement Earning Page Demo:

[x] Update logic for earning demo pages (Prevent navigate without account like welcome pages
[x] Update earning Page demo

[x] Add some method and view to create / import account
[x] Update logic allow navigate to correct earning after create account / password can be in success pages

Version test: https://ce505527.subwallet-yield.pages.dev/
Please check issues:

[ ] Show the empty earning pool

Version test: https://24333c4e.subwallet-yield.pages.dev/
Validation passed.


Server crashes when receiving a negative number for textDocument/hover

I found this issue while fixing an issue in ALE, where ALE was sometimes sending -1 for the column index. I've fixed the bug in ALE, and it's worth reporting the issue which crashed the server here. A log with the message that triggered the error can be found here: https://github.com/dense-analysis/ale/issues/3294#issuecomment-675161271
A snippet of the output from the logs is as follows.
thread 'main' panicked at 'Invalid request
Method: textDocument/hover
 error: invalid value: integer `-1`, expected u64', /home/rick/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/macros.rs:16:9
stack backtrace:

This is the message that caused that problem.
{"method":"textDocument/hover","jsonrpc":"2.0","id":2,"params":{"textDocument":{"uri":"file:///home/rick/Projects/nushell/crates/nu-cli/src/commands/str_/pad.rs"},"position":{"character":-1,"line":1}}}

The server should either return an error and handle numbers possibly being negative gracefully, or disregard negative numbers and treat them as 0.

In my opinion, there's not much use in guarding against misbehaving clients.

Yup, this is expected behavior -- we intentionally hard-crash for misbehaving clients.

To be clear, in theory this might be the bug where we misinterpret the spec, but I think in this case it's pretty clear that the column number shouldn't be negative.

It's worth returning an error in response. It's the same as returning a 4xx error in an HTTP response, instead of 500.

I disagree, I think in the context of LSP hard-crash is a better behavior. Unlike the web, this is a closed system (the same operator is in control of both the server and the client). Hard crashing forces one to actually fix client and server.


Add gNMI benchmark test

BenchmarkGNMISet/config_replace-12                     2<PHONE_NUMBER> ns/op
BenchmarkGNMISet/state_replace-12                      2<PHONE_NUMBER> ns/op
BenchmarkGNMISet/config_update-12                      1<PHONE_NUMBER> ns/op
BenchmarkGNMISet/state_update-12                      61          20531426 ns/op
BenchmarkGNMISet/config_replace_and_delete-12                  1<PHONE_NUMBER> ns/op
BenchmarkGNMISet/state_replace_and_delete-12                   1<PHONE_NUMBER> ns/op

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
9 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 66.51%

Files with Coverage Reduction
New Missed Lines
%

sysrib/zapi.go
9
65.98%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
4111

Relevant Lines:
6181

💛  - Coveralls


Send Buttons choices

I have searched for similar requests on GitHub and found none.

[X] Yes

Feature type:
Endpoint
What problem does the feature aim to solve?
Is it possible to add a sendButton endpoint similar to the waha service ?
it would be really useful for integrating specific workflows
Provide specific examples of how this feature could be used.
This can include scenarios or use cases where the feature would be particularly beneficial.
No response
Development
No response
n8n
No response
Any other information you believe is relevant to your request.
No response

See Here

it is not accessible from the latest version ( the docker version ) ?


Download and use latest styleguides from thoughtbot

When users build a new project, they should have styleguides encouraging
the latest best practices available for local linting as well as through
Hound.
This change downloads the latest Ruby, JavaScript, and Sass
styleguides that we have in our https://github.com/thoughtbot/guides
repo for immediate use. It uncomments the relevant Hound configuration
to enable their immediate use.
Thanks to @tysongach and @teoljungberg for the idea to incorporate these
stylesheets directly, suggested in #695 and thoughtbot/guides#379.

THIS IS GONNA BE AWESOME

Great way to close out a Friday! :tada:

Sweet!

One issue I haven't yet resolved: the tests for this change are actually pulling the config from the web. My instinct here would be to use VCR, but that's a new development dependency. Any suggestions as to how to best make these tests not reliant on a working network connection?

@geoffharcourt Instead of VCR, how about using Webmock and returning a fixture file?

@gylaz that works. Thanks for the recommendation!

Gah! Here's where I'm at. Using WebMock (or VCR) doesn't seem to work here, I suspect because the feature execution is somehow outside of the hooks WebMock implements in RSpec. (I have WebMock running with disable_net_connect! but outside connections are still made. Any ideas how to get this working?

One approach could be to use cURL instead of Net::HTTP to do the download (and then to fake/stub curl as we have git and heroku), but that seems like changing our implementation simply to make it testable. Is there something I'm missing that we can do?

@geoffharcourt I'll gladly pair with you on this on Friday, timezones apart. What do you think?

@teoljungberg sounds great. I suspect I'm missing something straightforward, if I figure it out before then I'll let you know. Otherwise we'll get a time early on my Friday so our times line up.
Thanks!

I love this! :)

Just an FYI, we are working on supporting an organization-level config on Hound itself.

we are working on supporting an organization-level config on Hound itself.

That would render this changeset unnecessary. @gylaz, does Hound already have this? Do you see it coming in the foreseeable futuer? Thank you!

We've started work on this front, but the progress slowed -- not a lot of investment availability and we are focusing on stability. I would say in the next few months is likely.

@geoffharcourt what is the status of this PR? Thank you!

@tute we need to do some work on the specs to make them not dependent on external web connectivity.

It looks like this is going to be supplanted by (superior) Hound functionality in the future, so I'm closing this out.


struct and union declarations

I'd like to discuss generics separately (#29). I'd like to include unit and tuple structs here.

Single-line tuple structs are already covered in the guide: https://github.com/rust-lang-nursery/fmt-rfcs/blob/master/guide/guide.md#tuples-and-tuple-structs

I prefer:
struct Foo /* <- must be on one line */ { /* <- on the first line if it fits, otherwise pull it down */
  b: B, /* <- indented once, must end with a trailing comma */
  long_name:
    LongName, /* <- if required, pull the type name down to the next line and indent once */
} /* <- on it's own line */

And to clarify - a trailing comma on the last field?

@nrc Yes.  That avoids having to add a comma when adding another field, or deleting a comma when deleting a field.

What about structs with trait bounds?
struct Peekable<I>
    where I: Iterator,
               I::Item: Debug, // This is only to illustrate more bounds
{
    peek: Option<I::Item>,
    iter: I,
}

If the where clause is treated as a list, it too should always have a trailing comma; new additions go on a new line.

I'm not a fan of visual identing, and it seems like the tone in other issues is against it. I'd rather have:
struct Peekable<I> where // 'where' on the same line, following the example of '{'
    I: Iterator,         // one block indent, just like struct fields or any other list item
    I::Item: Debug,      // trailing comma, of course
{ // visually ends the 'where' items and begins the struct items
    peek: Option<I::Item>,
    iter: I,
}

A hanging where works well for functions and methods too (they often have longer initial lines), so taken together I prefer it for all of them for consistency. A where at the end of a line is far removed from the actual where clauses. It's also been the prevailing style inside the rust project itself, what I can see.

I'd like to also discuss where clauses separately, since they equally affect functions, traits etc., I created #38 for that.

I think this is ready for FCP, summarised in https://github.com/rust-lang-nursery/fmt-rfcs/issues/30#issuecomment-254325732.

@nrc I would like to take a crack at this one.

assigning to myself for mentoring and so we can see @johnthagen is working on it

Closed by #53


Adding documentation for FB-1893.

Also a minor correction related to the deprecated sql endpoint flag.

Addressed all review feedback. Please note that in [docs/sql-guide/sql-guide-home.md] I added the suggested text and links to the "before you begin section". I am not familiar with the context on this proposed change, and the links are possibly broken too. My intend for the original change in this file was to remove text that was referring to a deprecated flag, that is done, beyond that I am not sure of the correctness of the new text and links.


[Map] CTF-SpoondogBME

If click on author:
https://unrealarchive.org/authors/cory-spooner-_thespoondog_.html
Then map CTF-SpoondogBME not appear in list.

URL: https://unrealarchive.org/maps/unreal-tournament/capture-the-flag/S/ctf-spoondogbme_6bc6ac3a.html
Hash: 6bc6ac3a09e403338ba6dca63043dd646324e698
Current name: CTF-SpoondogBME

Fixed, his Author page should include more stuff now: https://unrealarchive.org/authors/cory-spooner-thespoondog.html


animating axis ticks looks crazy

getting automatic ticks from a domain / scale results in an inconsistent number of ticks.  See https://github.com/mbostock/d3/wiki/Quantitative-Scales#linear_ticks
this means that the ticks and their grid lines pop in and out of existence during the animation, and look very, very broken

This wold be solved by https://github.com/FormidableLabs/victory-animation/issues/28

closing as a duplicate of https://github.com/FormidableLabs/victory-chart/issues/4


摄像头在挂断视频会议后仍然被调用

安卓环境下：
摄像头在挂断视频会议后仍然会被调用。控制台还能看到输出的本地视频流的信息
I/org.webrtc.Logging(16416): EglRenderer: Duration: 4007 ms. Frames received: 0. Dropped: 0. Rendered: 0. Render fps: .0. Average render time: NA. Average swapBuffer time: NA.

Camera still working after I hangup the call


Add demo1/demo2 to README with description

Issue #741

Hi @derneuere
Could you have a look at this small PR please?

Looks good to me :)


Did the extra planes help?

Hi, have you compared the effect of inputs with and not with the extra planes (average luminance, contrast and saturation)? Did them really help?
Thank you.

Yes, it does. A similar design was adopted in the initial version of Alpha Go.


update setup page

currently MPI instructions from december workshop.
Most material from on https://github.com/ENCCS/cmake-workshop-setup/blob/main/README.md should be moved here.
Plan: (@robertodr FYI)

i'll add a code block with the environment.yml file from https://github.com/ENCCS/cmake-workshop-setup
i'll add a link to https://github.com/ENCCS/cmake-workshop-setup for running mybinder

actually, is there any reason not to move environment.yml and the binder action from https://github.com/ENCCS/cmake-workshop-setup/ to this repo and add a launch binder button here?

No reason at all, actually. We should merge the two repos, less change of things getting out of sync.


Making iTerm window spawning smoother

If I simply replace Kitty with iTerm in the example config, I end up spawning a lot of new iTerm.app processes instead of simply creating new windows using the old process:
hyper - return : open -na /Applications/iTerm.app

I've therefore tried to use osascript to activate iterm and inject the command myself:
hyper - return : osascript -e 'tell application "iTerm" to activate' -e 'tell application "System Events" to tell process "iTerm" to keystroke "n" using command down'

however I don't get any visual feedback. The logs at /usr/local/var/log/skhd/ are also empty.
This is also the case when I put the command in a bash script in ~/bin and I try to run that with
hyper - return: bash ~/bin/my_script

FYI, I'm running High Sierra and I have installed skhd from homebrew.

Uuuh, I realised what the issue is: osascript fails when hyper is still pressed.
I guess this is not quite a skhd bug then. Closing :)

is it possible to replace "iTerm2" with $1 in the above script and pass an app name as an argument?  i can't seem to get it to work.
thanks


17.0.3_7 build not working with gradlew

Version 17.0.2_8 works as expected, but version 17.0.3_7 fails. Gradle version is 7.4.2
In our dockerfile we have:
FROM eclipse-temurin:17.0.2_8-jdk AS build

RUN mkdir /home/uswf

COPY . /home/uswf

WORKDIR home/uswf

RUN chmod +x ./gradlew

RUN ./gradlew clean build

After executing the last line with version 17.0.3_7 gradlew puts out the following error:
"ERROR: JAVA_HOME is set to an invalid directory: /opt/java/openjdk
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation."
All of the directories seem correct, but the only change was the upgrade of the java version.

Shouldn't that first line be FROM eclipse-temurin:17.0.3_7-jdk AS build?
I can't seem to reproduce this error

Shouldn't that first line be FROM eclipse-temurin:17.0.3_7-jdk AS build?
I can't seem to reproduce this error

When  the line is changed to FROM eclipse-temurin:17.0.3_7-jdk AS build the error happens.

Here is the relevant code in gradlew: (I inserted the echo command to confirm the JAVACMD is properly set)
`# Determine the Java command to use to start the JVM.
if [ -n "$JAVA_HOME" ] ; then
if [ -x "$JAVA_HOME/jre/sh/java" ] ; then
# IBM's JDK on AIX uses strange locations for the executables
JAVACMD=$JAVA_HOME/jre/sh/java
else
JAVACMD=$JAVA_HOME/bin/java
fi
echo "JAVACMD: $JAVACMD"
if [ ! -x "$JAVACMD" ] ; then
die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation."
fi
else
JAVACMD=java
which java >/dev/null 2>&1 || die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation."
fi Here is the output from using 17.0.3_7-jdk:
Status: Downloaded newer image for eclipse-temurin:17.0.3_7-jdk
---> 0bc7a4cbe8fe
Step 2/9 : RUN mkdir /home/uswf
---> Running in 062c8af97366
Removing intermediate container 062c8af97366
---> adef6b175d68
Step 3/9 : COPY . /home/uswf
---> 3dbdaa7c7648
Step 4/9 : WORKDIR home/uswf
---> Running in 8032fe152cbb
Removing intermediate container 8032fe152cbb
---> 7393a5f4a16c
Step 5/9 : RUN chmod +x ./gradlew
---> Running in 8b16f82bd5b4
Removing intermediate container 8b16f82bd5b4
---> 4f05c7cbd9aa
Step 6/9 : RUN ./gradlew clean build
---> Running in 0520fbe4b0df

ERROR: JAVA_HOME is set to an invalid directory: /opt/java/openjdk
Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.
JAVACMD: /opt/java/openjdk/bin/java
The command '/bin/sh -c ./gradlew clean build' returned a non-zero code: 1
`
Here is the output from using 17.0.2_8-jdk:
Status: Downloaded newer image for eclipse-temurin:17.0.2_8-jdk  ---> f6e55a6665a7 Step 2/9 : RUN mkdir /home/uswf  ---> Running in 85b5679d94ec Removing intermediate container 85b5679d94ec  ---> 8dca1bf7e6d4 Step 3/9 : COPY . /home/uswf  ---> e51dbd960306 Step 4/9 : WORKDIR home/uswf  ---> Running in efe79fe05010 Removing intermediate container efe79fe05010  ---> dc8da93f721e Step 5/9 : RUN chmod +x ./gradlew  ---> Running in 1be0517ac209 Removing intermediate container 1be0517ac209  ---> 7bc4f882326c Step 6/9 : RUN ./gradlew clean build  ---> Running in 3e43a3b71572 JAVACMD: /opt/java/openjdk/bin/java Downloading https://services.gradle.org/distributions/gradle-7.4.2-bin.zip

This could be the docker version problem? See https://github.com/adoptium/temurin-build/issues/2974#issuecomment-1150881706

@ctwoolsey what is the version of the Docker engine you are using?

Ah yes, please update to the 20.x series of the engine and this should get fixed

Thanks for the suggestion. I'm waiting for the owner to update the docker
version.
On Wed, Jul 6, 2022 at 1:23 PM Martijn Verburg @.***>
wrote:

Ah yes, please update to the 20.x series of the engine and this should get
fixed
—
Reply to this email directly, view it on GitHub
https://github.com/adoptium/containers/issues/230#issuecomment-1176103586,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD6QVRWVYCCUBVJQQCBMEYTVSVUDFANCNFSM52M63SJQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Upgrading to 20.x fixed the issue.


mimic vmware when creating disk location attribute

Vmware disks use different format for location attribute which breaks scanning logic. We need to align with Vmware's #{controller['busNumber']}:#{device['unitNumber']}. This structure was created due to vmware's limitation on number of disks per one disk controller. In ovirt there is no such limitation.
Above problem was reported in: https://github.com/ManageIQ/manageiq/issues/8617

/cc @agrare

Being addressed by PR: https://github.com/ManageIQ/manageiq/pull/8967


buildToolsVersion is not specified.

Versions:
"react": "16.3.0-alpha.1",
"react-native": "0.54.2",
"react-native-shake": "^3.2.1"
Output:
Scanning folders for symlinks in C:\Users\xxxxx\Documents\react\testshake\node_modules (38ms)
Starting JS server...
Building and installing the app on the device (cd android && gradlew.bat installDebug)...
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugApk'.
> A problem occurred configuring project ':react-native-shake'.
> buildToolsVersion is not specified.

Fixed. It should be on npm now, please update your package. Thank you.


Question about Local Nav component

I am evaluating using the Local Nav for a feature to be finished soon. Everything is okay except for one issue.
I want to know if there is a way to hide the Collapse/Expand button of the Local Nav.

There are issues which will prevent us with supporting the pinned + expanded state and therefore we want to not include this button initially.

Hiding the pin button is not possible currently. Can you provide any further details about your use case? It is intended to function like this. On hover, it opens over the page content. On pin, it pushes the page content. Take a look at the UI Shell component examples.

We wanted to gradually adopt the component. Pin feature requires pushing the content, and we have a lot of pages which could get affected with pushing the content.
So it would have been helpful if there is a parameter to hide the pin button.

@hbdevfrk  can you show what it looks like when the nav is open? Not fully understanding what the issue is. If the nav is pinned open, then the content surrounding the nav would already be there. So closing the nave and sliding content over would cause issues? Need more information to see if this is a wider problem for other teams too.

Once component is used and inserted, the nav overlaps part of the content under it - both in hovered (but non-pinned) and pinned. The nav renders above the content.

Right now the local navigation is being updated for this release, we can look into perhaps implementing this request into the component. We'll update you here. Thank you!

We ended up doing the necessary changes to support the pin button. So it is no longer a need for us right now but could be a good option to have for future usages of the component.
Thanks for the follow up.
Best,
Harshay Buradkar
Engineer, Business Services Software Engineering
Cloud Engineering & Kyndryl Bridge, Global CTO Office
+91<PHONE_NUMBER> Mobile
www.kyndryl.comhttp://www.kyndryl.com
[cid:164009b9-75c6-47e0-a80a-ca0cb48acb9d]

From: Marco Sebastian Lopez @.>
Sent: Wednesday, March 6, 2024 4:13 AM
To: kyndryl-design-system/shidoka-applications @.>
Cc: HARSHAY Buradkar @.>; Mention @.>
Subject: [EXTERNAL] Re: [kyndryl-design-system/shidoka-applications] Request for prop to hide/disable the Pin button in Local Nav (Issue #59)
Right now the local navigation is being updated for this release, we can look into perhaps implementing this request into the component. We'll update you here. Thank you! — Reply to this email directly, view it on GitHub, or unsubscribe. You
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
https://us-phishalarm-ewt.proofpoint.com/EWT/v1/Dq81_Y1A2Q!d7OO-YBgb2_kf0_hqylYA2VW6xSbKRnZc_qBRL1yYm6LsNwDx66i1zIOdvx3GQqRJ0apummzP7HR8hdd_Mvmcsh-wgl3FpOCNSa_-PKDje7sYNMGuCaH12IOTOFYQNkgXw-sF919XmWADes$
Report Suspicious
ZjQcmQRYFpfptBannerEnd
Right now the local navigation is being updated for this release, we can look into perhaps implementing this request into the component. We'll update you here. Thank you!
—
Reply to this email directly, view it on GitHubhttps://github.com/kyndryl-design-system/shidoka-applications/issues/59#issuecomment-1979761623, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFBLPXRV74USKAGZ4FHJQJLYWZDAFAVCNFSM6AAAAABBJARZSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZG43DCNRSGM.
You are receiving this because you were mentioned.Message ID: @.***>


tinymce editor settings

It would be helpful if we had more control of the HTML that can go inside the tinymce editor. I was recently attempting to format the posts I imported from BlogEngine, and noticed that by default I cannot add my own SCRIPT or STYLE tags.
I fixed this by adding the following to tinymce.init() in editorController.js:
extended_valid_elements: '+*[*]', valid_children: '+body[style]',

Moved to Markdown.


provide sshd hardening profile/settings

Project description
I migrated a server from ansible to nixos recently. One thing I lost in the transition is the sshd hardening setup by this collection https://github.com/dev-sec/ansible-ssh-hardening .
I wonder if we could generate a profile or option to enable similar settings in nixpkgs ? would that be accepted ?
pinging @das_j as openssh maintainer .
NB: While I dont really care for module maintainers in general, it would be nice to have some for the sshd  nixos/modules/services/networking/ssh/sshd.nix module considering how critical that is.

I'll use this issue to collect my notes on ssh options renaming:

doesnt make sense to rename listenAddress as they follow a nix submodule syntax
[ ] the authorizedKeysCommand could be easily removed https://github.com/NixOS/nixpkgs/pull/215397
banner could be removed as well but it's low maintainance so let's keep it
settings.Port would have table type and this would not sit well with API since in sshd config "Port" can accept only one number (but you can write several lines of "Port X")
[ ] AuthorizedKeysFile should be migrated

Some of the standard hardening recommendations will be a bit hard for nixos-out-of-the-box. One example: we can't default to PermitRootLogin no unless we have some non-root regular user configured. (An assertion could help here, but we can only do that if mutableUsers=false; , I suppose).
That said, maybe we can get some easy wins for cloud images, or on the headless profile? Might it be safe to set services.openssh.settings.KbdInteractiveAuthentication = false; as part of the headless profile? For cloud (at least for EC2, which is the cloud I know best), you have to try hard to get a machine without an SSH key configured; could we set services.openssh.settings.PasswordAuthentication = false; in nixos/modules/virtualisation/amazon-image.nix? (And possibly openstack-config.nix too?)
Changes to how the cloud images work have shown up in NixOS release notes, so we could apply the new defaults only to 24.05 and later.


Style hamburger menu

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] Design change

Description
Hamburger menu did not fully match Figma. Updates include:

Ensuring the menu covers 72% of the screen when opened
Adding a dark blue hover background for improved accessibility
Adjusting the spacing for proper alignment
Updating button styles

Trello ticket link
Figma link 1
Figma link 2
Screenshots
Before

After

 As the screen gets larger, should the hover background color hug the text instead of spreading across the entire screen? It isn't exactly clear in the Figma but it seems like it is a bit too wide as it is. Also, the rest of our buttons use a rounded border and these are square, can we adjust?

@e-papanicolas Yes I agree, I think the hover background color is too wide. I checked the Figma and noticed that the List is set at 226px across all screen sizes, so I applied that change just now. Also, I think we should keep the square corners to align with the Figma (link here). Here is a screenshot of the latest change:


Switch to use LevelPath and bring LevelPathID and HydroSequence through refactor process.

I'm realizing just how important having an upstream-mainstem indicator and a topo-sort that obeys the rules of hydrosequence are to later processing. A number of things need to change and this will generally improve the package.
First big improvement is using levelpath instead of total drainage area to determine upstream-mainstem for collapsing across confluences.

Coverage increased (+0.03%) to 95.325% when pulling 88ceb799dba79456532401554a93ce63fa6f00c5 on level into 6fee3325dd002c3d40126bfbafc149509252cd44 on master.


Change draw page url

Overview
This PR moves the draw page into submissions: /submissions/4/draw. Doing this makes routing simpler and gives access to the boundary Id in the draw page navbar. This allows #205 to be fixed easily.
Also included in this PR is a fix for #206. This works by removing the default welcome page redirect and instead letting the submissions page be the sole determiner or whether or not a redirect to the welcome page should happen.
Closes #205
Closes #206
Notes
The redirect from submissions to welcome does cause some of the components from the submissions page to appear briefly. Addressing this might require more significant changes and could probably be a part of #172 and/or #184.
Testing Instructions

http://localhost:4545
Login as contributor
select "Azavea Test Utility"

[ ] Ensure you are directed to the submissions page

Log out
http://localhost:4545
Login as contributor
select "Other Utility"

[x] Ensure you are directed to the welcome page

Navigate around and make sure no links are broken

Checklist

[ ] fixup! commits have been squashed
[ ] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
[ ] README.md updated if necessary to reflect the changes
[ ] CI passes after rebase

Taking a look now


Small tweaks to run flask in development

Steps:
pip install --editable . # at the root of this repo
python -m app.main # now running at port 8000

NOT INTENDED TO BE MERGED. This is just to show what to do get flask running by itself.

Thanks, I'm just going to refactor this so it is decoupled from Docassemble and makes this all a bit easier


Data transfer objects creation conforming DAB specs

Enhancement Request
Use Case
Connection protocol of backplane with desktop agents must conform to DAB specs, for seamless integration of desktop agents. This requires backplane to send/receive messages per the defined schema.
https://github.com/finos/FDC3/blob/544-Desktop-Agent-Bridging-Proposal/docs/api-bridging/spec.md#connection-protocol
Workflow Description
sequenceDiagram
participant DA as Desktop Agent A
participant DAB as Desktop Agent Bridge
participant DB as Desktop Agent B
participant DC as Desktop Agent C
DA ->>+ DAB: connect (step 1)
DAB ->>+ DA: hello (step 2)
DA ->>+ DAB: handshake (steps 3-5)
DAB ->>+ DA: connectedAgentsUpdate (step 6)
DAB ->>+ DB: connectedAgentsUpdate (step 6)
DAB ->>+ DC: connectedAgentsUpdate (step 6)
Workflow Examples
Following are example message exchanged as part of connection protocol.
hello:
{
type: "hello",
payload: {
desktopAgentBridgeVersion: number,
supportedFDC3Versions: string[],
authRequired: boolean,
/** The DAB JWT authentication token */
authToken?: string
},
meta: {
timestamp: date
}
}
{
type:  "handshake",
/** Request body, containing the arguments to the function called./
payload: {
/** The JWT authentication token /
authToken?: string,
/* DesktopAgent implementationMetadata trying to connect to the bridge /
implementationMetadata: ImplementationMetadata,
/* The requested DA name /
requestedName: string,
/* The current state of the Desktop Agent's channels, excluding any private channels,
*  as a mapping of channel id to an array of Context objects, most recent first./
channelsState: Record<string, Context[]>
},
meta: {
/** Unique GUID for this request /
requestGuid: string,
/* Timestamp at which request was generated */
timestamp:  date
}
}
,
{
type:  "connectedAgentsUpdate",
/** Request body, containing the arguments to the function called.*/
payload: {
/** Should be set when an agent first connects to the bridge and provide its assigned name. /
addAgent?: string,
/* Should be set when an agent disconnects from the bridge and provide the name that no longer is assigned. /
removeAgent?: string,
/* Desktop Agent Bridge implementation metadata of all connected agents.
*  Note that this object is extended to include a desktopAgent field with the name assigned by the DAB. /
allAgents: ImplementationMetadata[],
/* The updated state of channels that should be adopted by the agents. SHOULD only be set when an agent is connecting to the bridge. /
channelsState?: ChannelState[] // see step4
},
meta: {
/* For a new connection, should be the same as the handshake requestGuid.
*  Should be the same as the responseGuid for a disconnection.
/
requestGuid: string,
/* Unique GUID for this message /
responseGuid: string,
/* Timestamp at which response was generated */
timestamp:  date,
}
}
Additional Information

DABAsyncAPI.txt


Quote completion completes escaped quotes

Typing <quote><backslash><quote> should NOT treat the second quote as completing the first quote.  The second quote is an escape.
Also happens with single-quote.
Same space as #281

Fixed in #471


Governance app

Purpose
Make an app that allows signing the chain updates, which was removed from the main app.
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

The menu should also be able to be shared (only the text of the UI is different). The main file is also basically duplicated.


feat: Port Topology.UniformSpace.AbsoluteValue

Co-authored-by: Adam Topaz<EMAIL_ADDRESS>

Thanks :tada:
bors merge


puppeteer-extra not working

Environment

Operating System: Windows_NT
Node Version:     v20.16.0
Nuxt Version:     3.13.2
CLI Version:      3.15.0
Nitro Version:    2.9.7
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
import { resolve } from 'node:path';
import puppeteer from 'puppeteer-extra';
import StealthPlugin from 'puppeteer-extra-plugin-stealth';
import sharp from 'sharp';
const config = useRuntimeConfig();
export async function installChapterWithManga(
mangatrLink: string,
fansubId: string,
slug: string,
chapter: number,
) {
if (!mangatrLink || !fansubId || !slug || !chapter) return;
if (!mangatrLink.includes('***')) return;

puppeteer.use(StealthPlugin());

puppeteer
    .launch({
        headless: false,
    })
    .then(async (browser) => {
        const page = await browser.newPage();

        await page.goto(mangatrLink);
        await page.waitForNavigation();

        await new Promise((resolve) => setTimeout(resolve, 1000));

        const images = await page.$$eval('img', (elements: any) =>
            elements
                .map((el: any) => el.src)
                .filter((x: any) => x)
                .filter((x: any) =>
                    x.startsWith('***'),
                ),
        );
        for await (const [index, image] of images.entries()) {
            const filePath = resolve(
                config.relativeCdnPath,
                slug,
                chapter.toString(),
                index + 1 + '-' + fansubId + '.jpeg',
            );

            const response = await fetch(image);
            const blob = await response.arrayBuffer();

            await sharp(blob).jpeg({ quality: 75 }).toFile(filePath);
        }

        await browser.close();
    });

}
Describe the bug
The project has a scrape function where I use puppeteer-extra and puppeteer-extra-plugin-stealth, but the scrape function throws the following error.
Additional context
No response
Logs
WARN
A plugin listed 'puppeteer-extra-plugin-stealth/evasions/chrome.app' as dependency,
which is currently missing. Please install it:
      yarn add puppeteer-extra-plugin-stealth

      Note: You don't need to require the plugin yourself,
      unless you want to modify it's default settings.

ERROR  [nitro] [unhandledRejection] Could not dynamically require "puppeteer-extra-plugin-stealth/evasions/chrome.app". Please configure the dynamicRequireTargets or/and ignoreDynamicRequires option of @rollup/plugin-commonjs appropriately for this require call to work.
at require (node_modules\nuxt\dist\core\runtime\nitro\error-dev.js:5:2)
at PuppeteerExtra.resolvePluginDependencies (node_modules\puppeteer-extra\dist\index.cjs.js:299:23)
at PuppeteerExtra.launch (node_modules\puppeteer-extra\dist\index.cjs.js:117:14)
at installChapterWithMangatr (server\utils\scraper.ts:22:1)
at async /C:/Users/zukreindev/Desktop/mangitto/node_modules/h3/dist/index.mjs:1978:19
at async Object.callAsync (/C:/Users/zukreindev/Desktop/mangitto/node_modules/unctx/dist/index.mjs:72:16)
at async Server.toNodeHandle (/C:/Users/zukreindev/Desktop/mangitto/node_modules/h3/dist/index.mjs:2270:7)

any update...?


put on sale open for bids

hey.
can i put on sale open for bids without fixed price by sdk?

Hi!
You can't to that.
But anyone can make bid on your items. It this case you get bid order and call acceptBid method of our SDK

Hi! You can't to that. But anyone can make bid on your items. It this case you get bid order and call acceptBid method of our SDK

and what about timed auction?

It's not available yet


Standard library documentation is outdated

See for example: http://www.rust-lang.org/doc/std/files/list-rs.html
The functions "car" and "cdr" were renamed to "head" and "tail" some time ago.
I suggest the following:

add a update time-stamp or a version number to the created files
update the documentation regularily

I've updated the documentation. Haven't done a timestamp. We'll want to take another pass at the docs before 0.1.

Ok, thanks.

graydon:btw. docs on the website now auto-update from source every time linux2 does a successful build on master

Probably fixed, seems to be working.


Added new API call for one tablet's health

@michael-berlin

This change is

Review status: all files reviewed at latest revision, 7 unresolved discussions.

go/vt/vtctld/api.go, line 32 [r1] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> This is a leftover and can be deleted?

 Sorry about that.

go/vt/vtctld/api.go, line 295 [r1] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> Since you've removed "shard" here, please add "metric" :)

Done.

go/vt/vtctld/api.go, line 333 [r1] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> > /
>
> I think we should make our life easier and just use the string presentation of the alias. Let's discuss this with Anthony.
>
> Note: If we do that, you can use the helper function `ParseTabletAlias()` to parse such a string. The function is in go/vt/topo/topoproto/tablet.go.

As discussed with Anthony, I will keep the tablet alias separated for now.

go/vt/vtctld/api.go, line 342 [r1] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> If we want to keep the /cell/uid format: We have this code already as helper function.
>
> See `ParseUID` in go/vt/topo/topoproto/tablet.go.
>
> Please use that function instead.

Done.

go/vt/vtctld/api_test.go, line 159 [r1] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> nit: Missing space between `//` and `Tablet Health`.

Done.

go/vt/vtctld/tablet_stats_cache.go, line 268 [r1] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> This method is very similar to the existing `tabletStatsByAlias(alias)`.
>
> Please merge both.
>
> From the other one, please take over the locking.
>
> re: the parameter. I think it's fine to have the tablet alias instead of cell and uid. You can already generate the tablet alias in api.go.
>
> re: the return value. I think this version is better where we return an explicit error.
>
> re: the name of the method. Maybe just name it `tabletStats` because that's what it returns?

Done.

go/vt/vtctld/tablet_stats_cache.go, line 268 [r1] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> > *discovery.TabletStats
>
> Please return here the object via copy by value instead of the pointer. This way, we avoid any data race :)

Done.

Comments from Reviewable

Review status: all files reviewed at latest revision, 3 unresolved discussions.

go/vt/vtctld/realtime_status_test.go, line 109 [r2] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> > return nil
>
> This feels wrong to me. err could be `!= nil` if the entry does not exist yet, right? In that, you probably don't want to return early?
>
> The easiest thing would be to continue here instead.

Done.

go/vt/vtctld/tablet_stats_cache_test.go, line 196 [r2] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> > want3
>
> Please name this `wantErr` because it refers to a different return value.

Done.

go/vt/vtctld/tablet_stats_cache_test.go, line 197 [r2] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> > emptyStat := discovery.TabletStats{}
>
> You can remove this.
>
> In case of an error we accept that fact that the main result is undefined. In consequence, we shouldn't check for it in the test.

Done.

Comments from Reviewable

Review status: 3 of 5 files reviewed at latest revision, 1 unresolved discussion.

go/vt/vtctld/tablet_stats_cache_test.go, line 195 [r2] (raw file):
Previously, mberlin-bot (Michael Berlin) wrote…
> > got3
> Please name this `gotErr` as well to be consistent.

Done.

Comments from Reviewable


Use Either instead of strict Either for puppetDB

I don't believe the strict version add anything while dealing with the PuppetDBAPI so this might be a first step in trying to simplify the error handling bits.
What do you think ?

Note that I pin on hruby-3.1.4

Do you how to "freeze" a pull request ? I didn't mean to have the second commit as part of this pull request ... It's still a WIP.

Seems to work fine. It can all be merged if it is ok by you.


Principal data serialization

We were looking at replacing some custom authorization policies with OPA policies. The authorizations that are being replaced are based on OAuth 2.0 based authentication and thus the principal is derived from KafkaPrincipal, i.e., a subclass. The OAuth principal carries information on the claims from the OAuth jwt which may be used for authorization in the rego policies.
However, currently the authorizer explicitly converts the principal to a KafkaPrincipal before serializing to json sending the request OPA. This way we loose all extra information from the jwt.
Would it be possible to change the principal serialization to support a more generic serialization supporting KafkaPrincipal subclasses?

Hi Thor! Yeah, that seems like a valid request. I wonder what the best approach would be for achieving that 🤔 I guess we could defer to a different serializer based on the principal type. Did I understand correctly that yours was a custom one? Or is there one for OAuth included in Kafka? I couldn't find one from a cursory search.

Well, there is some default support for OAuth in Kafka, however I do not think that default implementation actually comes with an OAuth principal by default. We are using an authentication plugin that comes with the Strimzi operator so the concrete principal is this: https://github.com/strimzi/strimzi-kafka-oauth/blob/main/oauth-server/src/main/java/io/strimzi/kafka/oauth/server/OAuthKafkaPrincipal.java
But yes, I also wonderful what approach would make the most sense. Could both be a standard serializer picking up the standard Java properties.

Yeah, doing JWT validation in OPA, and policy decisions based on claims makes perfect sense.
@scholzj any idea about how to best go on about allowing this?

Yeah. I agree. I am not even sure what it will look like if Jackson is just
serializing out the Strimzi principal. But for sure there could be other
principal implementations.
I does seem, however, that Kafka comes with a base class for OAuth that
defines a method for getting the token in its base64 encoded form. I am
experimenting a bit with trying to rely on that instead of the specific
Strimzi implementation. I’ll let you know if I find a way that is only
relying on the Kafka standard classes.


added egypt country

Hey @izanaty can you make sag, ico and icns versions of the icon, as mentioned in the documentation?


Refine the admin UI for UserPreferences

Description

This PR makes modifications to the admin view of UserPreferences to restrict actions that can be performed.
This automatically removes the following UI elements.

"Save and add another" button on the change form
"Delete" button on the change form
"Add" button besides "My Preferences" on the admin UI homepage

This PR also removes redundant attributes (like can_delete) and functions (like has_change_permission).
This PR also enables the automatic creation of UserPreferences when requested so that users that do not have one associated with them will get it created when the try to access the preferences page.
This PR targets branch feature/moderator-user-preferences i.e. PR #3914.
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[ ] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Closing, as the change is relatively small and has been requested on the original PR #3914 itself.


Small typo in CONTRIBUTING.md

Version
2.4.2
Reproduction link
Typo
Steps to reproduce
Small typo in CONTRIBUTING.md.
"Commiting" should be actually "Committing" with an extra t.
What is expected?
Typo fix to "Committing"
What is actually happening?
Typo right now

Please submit PRs directly...

Sure. I am on it.


pyiron_base's wrapper doesn't use storage

It serializes the entire node to bytestream directly, so we should be able to run this job type on all supported python versions not just 3.11+.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.07%) to 91.26%

Files with Coverage Reduction
New Missed Lines
%

job.py
4
94.59%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
5691

Relevant Lines:
6236

💛  - Coveralls

OutputSignals ['ran'] (key node__index_0): DataContainer doesn't support saving elements of type "<class 'pyiron_workflow.workflow.Workflow'>" to HDF!

My guess is that under the hood we need h5io's __getstate__ for this to be working, so we're still restricted to >=3.11. IMO it's not worth digging deeper at this instant.


local app

sometimes backend can not access public network, css, js files using CDN might be optional or always using local files?
thanks

The CDN package are font awesome and bootstrap htmlshiv, can consider using local one aswell but you can override loayout if needed

For now i'll stick with remote files from cdn for that packages


Fix error in ARM template

Looks like this part is incorrect. There is no identity under properties.
  **"properties": {**
    "identity": {
      "properties": {
        "type": "SystemAssigned"
      }
    },

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8bd978b4-cd44-2109-8bc3-d1356e54885e
Version Independent ID: 7c91d2b7-9693-fe07-0d01-c0f523d0b79b
Content: Azure Resource Manager template samples for chaos experiments
Content Source: articles/chaos-studio/sample-template-experiment.md
Service: chaos-studio
GitHub Login: @prasha-microsoft
Microsoft Alias: prashabora

@chitturs Thanks for your comment! We will review and provide an update as appropriate.

@chitturs We have verified and updated the document as required. The update will go live in less than 24 hours. Thanks again!


Documentation: Add description for development setup

In the step by step guide a notice on the build process would be helpful (marven). Also some hints for IDE setup would be nice.

Closed with #316


Faster array slicing

A bit embarassing: this PR makes https://nbviewer.jupyter.org/gist/shoyer/425cb3dc9101c235fe86 slower.

I think I've fixed the regression. Also optimized inline_functions by using a recursive solution.

I've now found out a way to make _deps() faster in an iterative way.

Why does creating the new list cause such a performance difference?  What differences are you seeing?

The work list avoids both the recursion and the manual stack handling. The number of outer loop iterations is equal to the maximum task nesting level, which is usually very small.

What difference I'm seeing: on
N = 1000
x = da.ones((N, N), chunks=(10, 10), name='x')
z = [x[i] for i in range(N)]

_deps() used to take 700 ms, it now only takes 500 ms.

Sorry for the churn. I think this PR is now ready for review or merging.

@eriknw some of the performance optimizations to dask.core and dask.optimize might interest you.

Hmm, I'm not sure why https://github.com/dask/dask/pull/1731/commits/831be05344fc2e0a7df8c95f41290450d36f4dd1 produced the following failure on AppVeyor:
https://ci.appveyor.com/project/dask-ci/dask/build/1.0.222#L490
Could it be an unrelated intermittent failure? One possible explanation is that empty() returned some NaNs or Infs and allclose() failed.

Yes, I suspect that this is caused by empty.  We should probably replace with random.random

Thanks for the ping, I'll take a look when convenient.

Two thoughts:

_deps is also used a couple of times within dask/distribued
Thoughts on removing the as_list= keyword parameter and instead having the caller do this expilcitly as in set(get_dependencies(dsk, task))

For distributed, see https://github.com/dask/distributed/pull/616.
as_list feels ok to me right now, but we can revisit it later. Returning a set by default makes more sense because the result is naturally unordered, and in most cases you don't care about duplicates.

OK

This seems fine to me.  I recommend that we wait a bit for https://github.com/dask/distributed/pull/616 to get in and in case @eriknw has some time for review.  Otherwise I plan to merge tomorrow morning (around 18 hours from now)

Merging in 12 hours if no comment


Add SessionSurvey Store test

Kind (Required)

Other

Overview (Required)

You can see other screen tests for your reference.

Links

SessionSurveyStore https://github.com/DroidKaigi/conference-app-2019/blob/master/feature/survey/src/main/java/io/github/droidkaigi/confsched2019/survey/ui/store/SessionSurveyStore.kt#L14
AnnouncementStoreTest https://github.com/DroidKaigi/conference-app-2019/blob/master/feature/announcement/src/test/java/io/github/droidkaigi/confsched2019/announcement/ui/store/AnnouncementStoreTest.kt#L20

🙋

Thanks! Assigned 👍


[WIP] remove OASIS dependency by integrating into package

this PR is a work in progress to integrate OASIS directly into the neuroglia package.
plan:

[ ] make calcium a subpackage with current calcium.py in a "deconvolve.py" module
[ ] move oasis to calcium so current imports can point to relative path to module
[ ] consider moving gen_data functions elsewhere. into a "make_calcium_traces" function in dataset? this would be consistent with the sklearn samples generator api: http://scikit-learn.org/stable/modules/classes.html#samples-generator
[ ] get oasis building & testing working

Sure, just did the PR. #82

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@88843ec). Click here to learn what that means.
The diff coverage is 41.79%.

@@           Coverage Diff            @@
##             master     #79   +/-   ##
========================================
  Coverage          ?   64.6%
========================================
  Files             ?      24
  Lines             ?     952
  Branches          ?       0
========================================
  Hits              ?     615
  Misses            ?     337
  Partials          ?       0

Impacted Files
Coverage Δ

setup.py
0% <0%> (ø)

neuroglia/calcium/calcium.py
26.92% <100%> (ø)

neuroglia/calcium/__init__.py
100% <100%> (ø)

neuroglia/calcium/oasis/__init__.py
100% <100%> (ø)

neuroglia/datasets/__init__.py
100% <100%> (ø)

tests/test_deconvolution.py
100% <100%> (ø)

neuroglia/calcium/oasis/functions.py
33.33% <33.33%> (ø)

neuroglia/datasets/synthetic_calcium.py
56.25% <56.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88843ec...a8c48dc. Read the comment docs.

this appears to address all of the bullets from @neuromusic


initrd-ssh: allow empty hostKeys

This turns an assertion into a warning. The original assertion seems to originate in the switch from dropbear to openssh about 3 years ago and makes it impossible to use sshd in your initrd without providing at build time. This would be useful for people like me who'd like to optionally generate one or provide them via oob mechanisms.
Description of changes

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1309

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/672

@RaitoBezarius Thanks for your input! I agree that's a better design and just changed this PR to implement your recommendation instead.


OpenAI API Response was: Error: Request failed with status code 407. More information about this error: https://www.codegpt.co/docs/tutorial-basics/api_errors

help

It seems you are using proxy.
You can check this article to solve the problem.
https://softwareengineering.stackexchange.com/questions/348449/407-proxy-authentication-required#:~:text=The 407 error was probably,should authenticate with the proxy.


Add support for controlling the indentation of Markdown headers

Prerequisites
Put an x into the box(es) that apply:

[ ] This pull request fixes a bug.
[x] This pull request adds a feature.
[ ] This pull request enhances existing functionality.
[ ] This pull request introduces breaking change.

For more information, see the Contributing Guide.
Description
This PR adds support for controlling indentation of Markdown headers by adding --indent flag to markdown document and markdown table commands. The available values are 1, 2, 3, 4, 5, 6, 7 and the default value is 2. Any value outside of this range will default to 2.
Issues Resolved
Fixes #89
Checklist
Put an x into all boxes that apply:

[x] I have read the Contributing Guidelines.

Tests

[x] I have added tests to cover my changes.
[x] All tests pass when I run make test.

Documentation

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Code Style

[x] My code follows the code style of this project.

@metmajer I marked this as WIP because it depends on #119. Although to be fair it's not a hard dependency, it means we can proceed with either one and I'm gonna rebase the other, but in terms of git log history I prefer to proceed with 119 first.

According to Markdown guide, it seems the maximum depth of header is 6, and considering that we're going one level deeper when rendering markdown document, I think it'll be a good idea to change the maximum --indent level to 5.
This is an example of content being rendered on GitHub:

What do you think @metmajer ?

@khos2ow Hmm. What if we support the markdown standard on alignment levels from 0 to 6 and simply adjust the default value for markdown document as needed? This would decouple the implementation from the layout.

Hmm, I didn't quite get your point. But to be fair going five levels deep would be more than enough and I really don't think it ever happens for that matter. So instead of adjusting indentation value for one specific layout, we can just easily define a maximum depth of 5 which covers everything.

Never mind, @khos2ow. Do you as you wish. Do you want to deliver this one before #115?

It really doesn't matter. We can proceed with this one first since it's smaller in size.

Great job @khos2ow and thanks for adding the final update!