Settings Button - poor alignment; hover behavior

The setting button is not properly aligned in the footer of the sketching window. Also, when the pointer is hovered over the button, a darker background is shown:

I have fixed the alignment of the button:

Positiv getestet für die Demo App am 18.03.2021


Fix .find on undefined error during firebase creation

Happens right after project is created. Might just require a short wait time

Possibly wait and retry a few times if the project isn't found?

Done. my development branch


Get /v1/submission

Lists all submissions by their UUIDs that currently exist in Corpora. If a parameter is specified as a filter, then only submissions that meet the given criteria will be outputted.


Develop 3.0

Make current develop-3.0 contain develop-3.0-lower changes (minus the lower in riak_pb)

Not sure if something's gone pear shaped here, this deletes riak_repl_pb.erl - is that intentional?

The .gitignore has been changed to remove all _pb.erl files in src.  Is this correct?  Is there both generated and non-generated _pb.erl files

@martincox this does look right (to remove riak_repl_pb.erl) as this is an auto-generated file.  The file is not in develop-2.2` either.

I was stupidly looking at develop when I cross referenced - didn't realise it was generated.
:+1:


[Debugger] Required to specify the full package name to evaluate global variables from other packages

Description:
With the newly introduced variable evaluation feature in Ballerina debugger, we required to provide the full package name including org name and version to evaluate a global variable from a different package. This imposes the following problem,

Cannot evaluate a global variable from other packages by specifying the package alias (Need to preserve the alias info at the runtime to overcome this problem)

Affected Versions:
0.981.2-SNAPSHOT
Suggested Labels (optional):
Component/Debugger, Type/Improvement
Suggested Assignees (optional):
Pranavan

Closing since global variable support is already added in the jBallerina debugger implementation


Dynamic solution to formulas

Not sure if this is a poor implementation or if it doesn't fit the intended update goals, but I'm working on a dynamic solution to the issues surrounding formulas mentioned by @mesozoic and others.
I have a WIP that allows the following to be done
Function/Formula Subclass Generation

Take a CSV export from the formula playground
Run the WIP script generate.py passing in the export as args.
The script runs through each row from the export, identifies the type of function as well as the type for each parameter passed into the function, and serializes the current ~80 functions.
The script then generates subclasses from a parent class in formulas.py that contains generic attributes/functions.
This generated content is then spliced back into the actual package.

Issues:

Still requires some manual effort via pulling the CSV.
Generates many lengthy lines, likely won't fit any style guidelines.

Working on composable objects
I've got the composable aspect down conceptually, going about it in a way similar to reverse Polish notation, but I could use some guidance/suggestions regarding @mesozoic's comment:

We should be able to use operators like & and | to build complex logical conditions

I'm familiar with overriding __add__ for example, but could use some clarity on how this is ideally implemented for this project. Ke
Please critique the generation features in the WIP if they are throwing out alarm bells or if it is a noob idea in general.

I had not thought of using the formula playground as a source, but that's a great idea! My approach had been to scrape the text of their formula documentation, which resulted in a lot of mess that needed to be cleaned up by hand.
I realized that I'd never posted a draft PR for my branch, so I've put that up as #329. Patches or suggestions are welcome there, especially if your branch has any capabilities mine doesn't :)


Populate questionnaire using multiple resources

Fixes #644
Description
Implement population with multiple resources
Alternative(s) considered
No
Type
Choose one: Feature
Screenshots (if applicable)
N/A
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[ ] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

Codecov Report

Merging #770 (c830826) into master (844f397) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head c830826 differs from pull request most recent head cdc48a0. Consider uploading reports for the commit cdc48a0 to get more accurate results

@@            Coverage Diff            @@
##             master     #770   +/-   ##
=========================================
  Coverage     53.89%   53.89%
+ Complexity      200      198    -2
=========================================
  Files            48       48
  Lines          1013     1013
  Branches        141      141
=========================================
  Hits            546      546
  Misses          383      383
  Partials         84       84

Impacted Files
Coverage Δ

...va/com/google/android/fhir/db/impl/DatabaseImpl.kt
39.53% <0.00%> (-2.33%)
:arrow_down:

.../google/android/fhir/db/impl/dao/LocalChangeDao.kt
68.75% <0.00%> (+2.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844f397...cdc48a0. Read the comment docs.


Weird editor focus when clicking in dev tools

While verifying #9759 I noticed that I can get vscode into a weird focus state. E.g both editors have focus and I see two cursors, or that the TS context menu actions are never present (due to the lack of focus I believe).
As explained in #9759,  open a TS writeable file, open dev tools (click something there), right click in the ts writeable file. Notice that sometimes the TS context menu actions are missing (and they do not return until a new file is opened) or two cursors can appear in different editors.

I could repo with the dev tools but not with other windows or the part like the explorer/webview... The context menu is very special as it uses a stop the world approach.

Oh yeah I forgot that electron context menu freezes everything...

Yeah - as 'expected'


The APISIX series Resources should be maintained in a separate repository

So far both apisix-ingress-controller and apisix-dashboard maintain their own definitions for each APISIX resource, like Route, Upstream, Consumers and so on.
I propose to keep the definitions for those resources in a separate repository, and versioning them according to the release of data plane.
Protobuf 3 is a good choice to definition them.

Agree
We can ref to https://github.com/kubernetes/code-generator/cmd/go-to-protobuf
the submodule apisix-types  in apisix-ingress-controller also use the code-generator.

No plan to support it yet.

No plan to support it yet.


Updating OSM catalog URL with our local version.

We need to modify version values so they are quoted, to be considered as string instead of dates. For this to be possible, we need to import the catalog so we can edit it.
This PR need to be merged with this one : https://github.com/ideascube/catalog-i-o/pull/12

https://github.com/ideascube/catalog-i-o/pull/12 merged!


Arch arm fault fix nonsecure

Fixes some bugs with Secure/Non-Secure firmware and error handling (Reported in the commit messages)
Only affects builds with TrustZone-M enabled.

Codecov Report

Merging #13427 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13427      +/-   ##
==========================================
+ Coverage   48.56%   48.56%   +<.01%
==========================================
  Files         319      319
  Lines       46567    46567
  Branches    10761    10761
==========================================
+ Hits        22616    22617       +1
  Misses      19360    19360
+ Partials     4591     4590       -1

Impacted Files
Coverage Δ

arch/posix/core/posix_core.c
91.91% <0%> (+1.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e8a58...bc01f01. Read the comment docs.

Thanks @agross-linaro , commit messages fixed.


Add Dynamic partition failing with below error.

We are using Spark-Acid latest master code, which contains commit 736ffa3 that you suggested to include about dynamic partition. However, we came across this error now:
In the driver error log:
NoSuchTxnException: No such transaction txnid:22521
at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result$add_dynamic_partitions_resultStandardScheme.read(ThriftHiveMetastore.java)
at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result$add_dynamic_partitions_resultStandardScheme.read(ThriftHiveMetastore.java)
at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result.read(ThriftHiveMetastore.java)
at com.qubole.shaded.thrift.TServiceClient.receiveBase(TServiceClient.java:86)
at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_add_dynamic_partitions(ThriftHiveMetastore.java:5527)
...
(28 additional frame(s) were not displayed)
StreamingQueryException: Query hiveSink [id = 3267e047-4848-4821-a2f7-04d6b8dd84c9, runId = c94a4e2e-34bc-48cf-8f2f-266057cf4c84] terminated with exception: No such transaction txnid:22521
at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:297)
at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:193)
NoSuchTxnException: No such transaction txnid:22521
at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result$add_dynamic_partitions_resultStandardScheme.read(ThriftHiveMetastore.java)
at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result$add_dynamic_partitions_resultStandardScheme.read(ThriftHiveMetastore.java)
at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result.read(ThriftHiveMetastore.java)
at com.qubole.shaded.thrift.TServiceClient.receiveBase(TServiceClient.java:86)
at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_add_dynamic_partitions(ThriftHiveMetastore.java:5527)
...
(28 additional frame(s) were not displayed)
In the worker error log
ERROR AcidUtils: Failed to create hdfs://.../warehouse/tablespace/managed/hive/events/year=2020/month=6/day=4/delta_0000727_0000727/or
c_acid_version due to: Failed to CREATE_FILE /warehouse/tablespace/managed/hive/events/year=2020/month=6/day=4/delta_0000727_0000727/orc_acid_version for DFSClient_NONMAPREDUCE-528742007_48
on <IP_ADDRESS> because DFSClient_NONMAPREDUCE-528742007_48 is already the current lease holder.
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.recoverLeaseInternal(FSNamesystem.java:2555)
at org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp.startFile(FSDirWriteFileOp.java:378)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInt(FSNamesystem.java:2453)
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFile(FSNamesystem.java:2351)
at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.create(NameNodeRpcServer.java:774)
at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.create(ClientNamenodeProtocolServerSideTranslatorPB.java:462)
at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025)
at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876)
at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:822)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:422)
at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2682)
Any clue regarding this? Can it be related to the latest dynamic partitioning changes?

@sourabh912 this is failing during adding dynamic partitions.

@amoghmargoor Thanks for confirming the issue, looking forward for the fix 👍

@shuwnyuantee we tried reproducing this issue in house but could not. Can you help us with some pointers with which we can reproduce this ?
Along with pointers following information would also help:

Complete Stacktrace of the Driver. there are 28 frames missing.
which version of Hive Metastore are you using ?

@amoghmargoor

Steps to reproduce:

We build Spark-Acid jar based on commit ada7e2c586133a43 (dated Jun 4, 2020). Then we restart our Spark app, it crashes with the below error. We are in a loop now, where any further restart throws similar error.

Complete Stacktrace of Driver log

com.qubole.shaded.hadoop.hive.metastore.api.NoSuchTxnException: No such transaction txnid:22534
    at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result$add_dynamic_partitions_resultStandardScheme.read(ThriftHiveMetastore.java)
    at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result$add_dynamic_partitions_resultStandardScheme.read(ThriftHiveMetastore.java)
    at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$add_dynamic_partitions_result.read(ThriftHiveMetastore.java)
    at com.qubole.shaded.thrift.TServiceClient.receiveBase(TServiceClient.java:86)
    at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_add_dynamic_partitions(ThriftHiveMetastore.java:5527)
    at com.qubole.shaded.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.add_dynamic_partitions(ThriftHiveMetastore.java:5514)
    at com.qubole.shaded.hadoop.hive.metastore.HiveMetaStoreClient.addDynamicPartitions(HiveMetaStoreClient.java:2669)
    at com.qubole.spark.hiveacid.transaction.HiveAcidTxnManager.addDynamicPartitions(HiveAcidTxnManager.scala:350)
    at com.qubole.spark.hiveacid.transaction.HiveAcidTxn.addDynamicPartitions(HiveAcidTxn.scala:108)
    at com.qubole.spark.hiveacid.writer.TableWriter.process(TableWriter.scala:213)
    at com.qubole.spark.hiveacid.HiveAcidTable$$anonfun$addBatch$1.apply$mcV$sp(HiveAcidTable.scala:275)
    at com.qubole.spark.hiveacid.HiveAcidTable.inTxnRetry$1(HiveAcidTable.scala:107)
    at com.qubole.spark.hiveacid.HiveAcidTable.inTxn(HiveAcidTable.scala:131)
    at com.qubole.spark.hiveacid.HiveAcidTable.addBatch(HiveAcidTable.scala:273)
    at com.qubole.spark.hiveacid.streaming.HiveAcidSink.addBatch(HiveAcidSink.scala:87)
    at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$org$apache$spark$sql$execution$streaming$MicroBatchExecution$$runBatch$5$$anonfun$apply$17.apply(MicroBatchExecution.scala:537)
    at org.apache.spark.sql.execution.SQLExecution$$anonfun$withNewExecutionId$1.apply(SQLExecution.scala:78)
    at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:125)
    at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:73)
    at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$org$apache$spark$sql$execution$streaming$MicroBatchExecution$$runBatch$5.apply(MicroBatchExecution.scala:535)
    at org.apache.spark.sql.execution.streaming.ProgressReporter$class.reportTimeTaken(ProgressReporter.scala:351)
    at org.apache.spark.sql.execution.streaming.StreamExecution.reportTimeTaken(StreamExecution.scala:58)
    at org.apache.spark.sql.execution.streaming.MicroBatchExecution.org$apache$spark$sql$execution$streaming$MicroBatchExecution$$runBatch(MicroBatchExecution.scala:534)
    at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$runActivatedStream$1$$anonfun$apply$mcZ$sp$1.apply$mcV$sp(MicroBatchExecution.scala:198)
    at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$runActivatedStream$1$$anonfun$apply$mcZ$sp$1.apply(MicroBatchExecution.scala:166)
    at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$runActivatedStream$1$$anonfun$apply$mcZ$sp$1.apply(MicroBatchExecution.scala:166)
    at org.apache.spark.sql.execution.streaming.ProgressReporter$class.reportTimeTaken(ProgressReporter.scala:351)
    at org.apache.spark.sql.execution.streaming.StreamExecution.reportTimeTaken(StreamExecution.scala:58)
    at org.apache.spark.sql.execution.streaming.MicroBatchExecution$$anonfun$runActivatedStream$1.apply$mcZ$sp(MicroBatchExecution.scala:166)
    at org.apache.spark.sql.execution.streaming.ProcessingTimeExecutor.execute(TriggerExecutor.scala:56)
    at org.apache.spark.sql.execution.streaming.MicroBatchExecution.runActivatedStream(MicroBatchExecution.scala:160)
    at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:281)
    at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:193)
org.apache.spark.sql.streaming.StreamingQueryException: Query hiveSink [id = 3267e047-4848-4821-a2f7-04d6b8dd84c9, runId = 25008e19-fce0-497f-be1c-1020fd1d6942] terminated with exception: No such transaction txnid:22534
    at org.apache.spark.sql.execution.streaming.StreamExecution.org$apache$spark$sql$execution$streaming$StreamExecution$$runStream(StreamExecution.scala:297)
    at org.apache.spark.sql.execution.streaming.StreamExecution$$anon$1.run(StreamExecution.scala:193)

Hive & Metastore version:  3.1.2

@amoghmargoor I see your changes about logInfo. Do I have to change log level to info somewhere, in order to get the log?

@shuwnyuantee you may not need to do any change if your Driver logs already capture INFO logs.
Thanks for the info on HiveConfig.

@amoghmargoor  In what case will the logs being invoked (as in commit 57b6916b2b753c)?
I tried building jar as you suggested, tested changes locally, but didn't see any related logs in both driver & worker log.
Do they start appearing when data are stream into Hive table? Or they only appear in very specific condition that I might not trigger them on local testing.
p/s : I haven't deployed it in production, wanted to make sure I did the right thing before proceed to production deploy.

@shuwnyuantee yes they appear when streaming will start as they are at addBatch() function and at heartbeats. Your Log Level should be INFO or lower i.e., TRACE.

@amoghmargoor  I did something wrong previously, sorry my bad.
Here's the logs you required:
hive-metastore.log
spark-driver.log
spark-worker.log
Thanks for help 👍

Thanks @shuwnyuantee . This helps a great deal.
Let me tell you exactly what happened here first. these are the things which happened in order

New transaction is created. From driver log:
04:26:59.654 [stream execution thread for hiveSink [id = 3267e047-4848-4821-a2f7-04d6b8dd84c9, runId = e989f15a-b4de-4ccf-95f7-605d6fa44aec]] INFO : Transaction created: 22565 04:26:59.654 [stream execution thread for hiveSink [id = 3267e047-4848-4821-a2f7-04d6b8dd84c9, runId = e989f15a-b4de-4ccf-95f7-605d6fa44aec]] INFO : Transaction created: 22565

Hive Metastore treats this transaction as aborted and removes it. This is the responsibility of Initiator in Hive Metastore. From Hive Metastore Logs:

2020-06-12T04:38:04,033 INFO  [Thread-10]: compactor.Initiator (Initiator.java:run(97)) - Checking to see if we should compact default.tmp_clst5.year=2019/month=7/day=20 2020-06-12T04:38:04,064 INFO  [Thread-10]: txn.CompactionTxnHandler (CompactionTxnHandler.java:cleanEmptyAbortedTxns(605)) - Removed 1  empty Aborted transactions from TXNS 2020-06-12T04:38:04,064 INFO  [Thread-10]: txn.CompactionTxnHandler (CompactionTxnHandler.java:cleanEmptyAbortedTxns(607)) - Aborted transactions removed from TXNS: [22565]

Since initiator removed this either commit to this transaction or adding dynamic partitions for this transaction will fail now saying no such transaction exist. From Driver Log:

04:38:53.219 [stream execution thread for hiveSink [id = 3267e047-4848-4821-a2f7-04d6b8dd84c9, runId = e989f15a-b4de-4ccf-95f7-605d6fa44aec]] INFO : Adding dynamic partition txnId: 22565 writeId: 740 dbN ame: default tableName: clickstream_events_sink_v1 partitions: year=2020/month=6/day=4 04:38:53.240 [stream execution thread for hiveSink [id = 3267e047-4848-4821-a2f7-04d6b8dd84c9, runId = e989f15a-b4de-4ccf-95f7-605d6fa44aec]] ERROR: Exception NoSuchTxnException(message:No such transaction txnid:22565)
So @shuwnyuantee as you can see even if you remove the commit to add dynamic partition, it will still fail as issue is somewhere else. it will fail while committing the transaction if you remove that commit.
So coming back to the issue here: Why does Hive Metastore regard an ongoing issue as aborted ?
Most probable reason is:
For keeping transaction alive Spark Application has to keep sending Heart beat to the Hive Metastore. Otherwise HiveMetastore will abort that transaction. You can check File HiveAcidTxnManager.scala. There is class named HearBeatRunnable that takes care of sending those heartbeats. I have added logs to them too.
Do you see any heartbeat logs in Driver code either related to failure or success ?
This is a good progress.

@amoghmargoor
In Spark Driver log, I didn't find any logs related to Spark-acid sending heartbeat. Keywords I have searched for are:
Heartbeat failure for transaction id

Heartbeat sent for txnId

Failure to heartbeat for txnId

@shuwnyuantee Thats concerning ... so the HeartbeatRunner is somehow failed or not running in your setting. Is it possible to send entire Driver log of the Application ? This should be solved else it will have effects in your production.

@amoghmargoor
Here's the complete driver log:
complete_driver.log

@shuwnyuantee I have figured out the issue hopefully and going to make a fix for this ASAP. Hopefully this should be fixed in a day or two.

@shuwnyuantee this is fixed and merged. thanks for reporting.


Publish RFC Lookup Tutorial

Publish RFC Lookup Tutorial

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please be sure you sign the CLA.  I cannot merge this pull request until you do.

Please be sure you sign the CLA. I cannot merge this pull request until you do.


Add UIImageColors

Project URL

https://github.com/jathu/UIImageColors
Description

iTunes style color fetcher for UIImage. :large_orange_diamond:[e]
Checklist

[x] Only one project is in the request
[x] Supports iOS 7 and later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English
[x] CI: ok (issue fixed separately)

Please rebase your changes so we can get this merged, ok?

@jathu please  update pull request

It should be good now

Sorry this is not right, will close it
Can you reopen? Thanks


Major revision: integrate Pangolin lineage definitions

replace clusters with Pangolin lineages - this will require generating lineage classifications for every genome in the database (made feasible with changes in ArtPoon/pangolin fork)
define variants within lineages as genomes with one or more nt differences or an uncalled base (N) at a position where nt differences occur in other genomes of the same lineage.  This means that genomes with Ns at positions other than informative sites are assigned to a defined variant.
consider incorporating indel variation in variant definitions?
use neighbor-joining to generate a tree relating variants within lineage.
adapt beadplot to new information

made some coding contributions to Pangolin to speed up the pipeline - we can now classify nearly 70K genomes in about 1.5 hours.

See also #115
We may need to associate clusters from that workflow to Pangolin lineage definitions...?

GISAID records are now annotated with Pangolin lineages
I recommend that we run the standalone Pangolin scripts on the same data to verify these lineage annotations.

Pangolin lineage assignments seemed to be missing for a substantial number of records (10K+).  Please check on whether updater script is capturing all entries.  (It would also be nice to stream genomes through the Pangolin script rather than having to write a filtered FASTA to the filesystem.  This would require installing Pangolin as a module.)
import pangolin
...
for genome in stuff:
    this_lineage = pangolin.assign_lineage(genome)
    # do things with this_lineage

Can somebody please check the concordance between our local Pangolin assignments and the ones being distributed by GISAID?

See #121 for handling incomplete genomes
See #122 and related minimap2 issues for feature extraction

SQL command to see discrepancy:
SELECT * FROM LINEAGE, SAMPLE WHERE LINEAGE.accession = SAMPLE.accession AND LINEAGe.lineage != SAMPLE.lineage

292 records written to data/discordant_pangolin.csv.
SELECT COUNT(*) FROM (SELECT * FROM LINEAGE, SAMPLE WHERE LINEAGE.accession = SAMPLE.accession AND LINEAGE.lineage != SAMPLE.lineage)
>292

Most discordant records differ by degree of specificity "B.1" vs "B.1.1"   - however it's not always the case that lineage derived from local version of pangolin is more specific than uploaded lineage.
i.e.

accession
local_lineage
[...]
seq_name
[...]
gisaid_lineage
gisaid_clade

EPI_ISL_450290
B.1
[...]
hCoV-19/Russia/StPetersburg-RII8913S/2020
[...]
B.1.1
GR

EPI_ISL_430794
B.1.1.28
[...]
hCoV-19/Argentina/PAIS-A0002/2020
[...]
B.1.1
GR

Thanks, do you have the associated probabilities and can you also output the matching records?

its in the data/discordant_pangolin.csv. file: col headers as follows:

accession
local_lineage
local_probability
local_pangoLEARN_version
local_status
seq_name
sample_col_date
sample_location
gisaid_lineage
gisaid_clade

Ok but in order to interpret the distribution of probabilities, I also need the concordant cases..

Oh oops! Totally had a brain fart there, printed records out to data/pangolin_concordant.csv
This only covers about 56,587 records. Pangolin was queued after the entirety of the Chunkybot.py script.

Ok thanks!

Files have ,  delimiters, need to remove excess whitespace and consolidate concordant and discordant cases:
art@Langley:/home/covid/covizu/data$ sed 's/, /,/g' pangolin_concordant.csv > pang.csv
art@Langley:/home/covid/covizu/data$ sed 's/, /,/g' discordant_pangolin.csv >> pang.csv

> pang <- read.csv('pang.csv', stringsAsFactors = F)
> boxplot(split(pang$local_probability, pang$concordant), xlab='Concordance', ylab='Pangolin probability (local)')

Discordance in lineage typing for 159 records, out of a total of 80,048 records.
80,048 represents the number of records for which we have a GISAID-assigned lineage AND a locally assigned lineage (not thrown out by the filtering.py)
ewong347@Langley:~/covizu$ grep -c 'EPI' data/Lineage*
data/LineageConcordance.csv:79889
data/LineageDiscordance.csv:159


Add minimimal UI to web interface

This PR switches the info page to use a jinja2 template and flask-wtf to automatically generate a form for users to submit a query. It also uses flask-bootstrap to make them render with minimal code necessary.

Thanks @cthoyt! I reformatted and reworded a few things but the basic functionality is preserved. I am primarily looking to support programmatic access but a minimal UI like this is still nice to have!


Add a note to ensure timeout value is correctly set. fix #49622

The default timeout value would throw a 1006 error and is very difficult to trace what's happening.

@jmservera : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#reassign:winthrop28

@winthrop28 Would you review this pull request? Thanks!

@amsriva @mscatyao   Please can you review this PR. Thanks!

@amitsriva @mscatyao for review

@kumudD Could you indicate what action to take with the pull request?

#sign-off
#please-close
#hold-off

Thank you!
-PR review team

@greg-lindsay - Should this old PR be closed or merged?

This looks ok to add. It is just a note that you shouldn't be too aggressive with timeouts #sign-off

@ShannonLeavitt looks like I can't sign off because Vic was the author when the PR was created.  I am the current author, but github isn't smart enough to know that. Can we just push it out?  Alternatively, we can close this one and I can create a new PR to get the note added.


Hero Block changes

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #152
Test URLs:

Before:

https://main--shredit--stericycle.aem.live/en-us/service-locations/boston

After:

https://hero-block-changes--shredit--stericycle.aem.live/en-us/service-locations/boston

Lint error which are present on the main branch are being tracked via https://github.com/aemsites/stericycle-shared/pull/192


How to sync Lex response with gesture to Sumerian Host

We are working on BabylonJS that integrates Sumerian Host. By calling Lex we received audio and message, how to sync Lex respond message with Sumerian host so that Host can play both audio and gesture. This could leave out the Polly and only need Lex. Is this possible?
Thanks.

Hi @KISSMonX. We do not currently have the capability of providing audio to the TextToSpeechFeature. This is because a speechmark stream is required as well and must be generated from the same source as the audio in order for the messages to sync up and allow the lipsync and gestures to happen in time with the audio. Unfortunately Lex is not capable of generating speechmark data so there's really no way around using Polly if you want lipsync and gestures. You could however execute TextToSpeechFeature.play using the response message you receive from Lex. Hope this helps.


[SPARK-37643][SQL] when charVarcharAsString is true, for char datatype predicate query should skip rpadding rule

What changes were proposed in this pull request?
after add ApplyCharTypePadding rule, when predicate query column data type is char, if column value length is less then defined,  will be right-padding, then query will get incorrect result
Why are the changes needed?
fix query incorrect issue when predicate column data type is char, so in this case when charVarcharAsString is true, we should skip the rpadding rule.
Does this PR introduce any user-facing change?
before this fix, if we query with char data type for predicate, then we should be careful to set charVarcharAsString to true.
How was this patch tested?
add new UT.

What happens to https://github.com/apache/spark/pull/34900 ?

@cloud-fan Sorry, the #34900 check flow fails due to a bug in the GitHub action. I mistakenly thought that the problem was caused by my pr. Therefore, I closed the 34900 and raised the pr again. Later, I learned that the problem was caused by the bug in the GitHub action

It's OK, can you post the testing job link this time? We can merge this PR if tests passed.

ok, once testing passed, i'll post here, thank you.

@HyukjinKwon hello, can you help post the build link here? thank you.

https://github.com/fhygh/spark/actions/runs/2182223695
@cloud-fan

https://github.com/fhygh/spark/runs/6059356696
@cloud-fan  @HyukjinKwon

https://github.com/fhygh/spark/actions/runs/2182558948
@cloud-fan  @HyukjinKwon

thanks, merging to master/3.3/3.2/3.1!


ClearScript/V8 dependency

Would it be possible to run React.NET without this? I really dislike the idea of adding 9MB of binaries, which is the size of my entire repo. NuGet allows us to avoid this typically. Plus, any updates will cause this size to expand.
I understand that it may not be possible to access the features you need through the JS engine switcher, which is probably why you link directly to MSIE and V8. Just curious if you see a workaround. Thanks!

V8 is optional, ReactJS.NET falls back to the MSIE JS engine if V8 is not available. You can just remove the reference to the ClearScript assemblies.

Oh I see. So I need to keep JavaScriptEngineSwitcher.V8, due to the dependency, but that component dynamically loads the ClearScript assemblies if it finds them (due to the need to run 32 bit or 64 bit). Thanks for the tip.


Harmonize range of reserved values for HDC internal purposes.

Any change on this kind of ID needs to be carefully reflected also in the HDC-spec and the ProxyBase class!

CommandID value start at 0xF1, instead of 0xF0, for no particular reason.
Predefined ErrorID values are not grouped at all, because it is hard to decide which of them are for general use and which are for HDC internal. Keep in mind that there might still be some pending kinds of error that should be included into the HDC-Spec. The NoError should be kept at 0x00, for tradition, so most likely should group the rest of error codes at the lower end and clearly specify which range or ErrorIDs is available for custom use by the users of the hdc driver.

Also might need to be addressed in the context of this issue:
Should the hdc implementations define IDs for FeatureState values whose meaning is defined/reserved by HDC-spec?


Models: I have to rebuild the project after i've added **.js:FuseJS for it to be picked up

Until i do that, my bindings are not being resolved:
<App Model="App()">
	<Text Value="{foo}" Alignment="Center"/>
</App>

export default class App {
	constructor() {
		this.foo = "bar";
	}
}

The project works, but if you build it up from scratch, you'll at some point have to rebuild for it to pick up the new JS stuff.
App1fddg.zip

This seems to not be the case any more :)


Fix indentation for pipeline-global when documentation

Fixes https://github.com/woodpecker-ci/woodpecker/issues/1386

sorry didn't read the issue witch explains this pull :)

well I did prettify it as global when statement make more sense on workspace beginning ... of course the yaml parser dont care as long as has the right indentation


Bug in insert query with eloquent model

There is a problem with the query Database. I know that it is a rather selective problem, but we must solve it

Laravel Version: 8.82
PHP Version: 8.1
Database Driver & Version: MySql 10.4.22-MariaDB

Description:
When inserting values in the database, I have that the keys are the same when they should be different
Steps To Reproduce:
My test case
<?php

namespace Tests\Feature;

use Tests\TestCase;
use App\Models\Product;
use App\Models\Attribute;
use App\Models\AttributeOption;
use App\Models\ProductAttributeValue;
use Illuminate\Support\Facades\Artisan;

class DataBaseTest extends TestCase
{
    public function test_seed()
    {
        Artisan::call('migrate:fresh');

        $this->assertTrue(true);
    }

    public function test_add_product()
    {
        $product = Product::create([
            'name' => 'test Product'
        ]);

        $this->assertEquals(1, $product->id);
    }

    public function test_add_attribute()
    {
        $attribute = Attribute::create([
            'name' => 'Color'
        ]);

        $this->assertEquals(1, $attribute->id);
    }

    public function test_add_another_attribute()
    {
        $attribute = Attribute::create([
            'name' => 'Ram'
        ]);

        $this->assertEquals(2, $attribute->id);
    }

    public function test_add_attributeOption()
    {
        $attributeOption = AttributeOption::create([
            'name' => 'Red',
            'attribute_id' => 1
        ]);

        $this->assertEquals(1, $attributeOption->id);
    }

    public function test_add_another_attributeOption()
    {
        $attributeOption = AttributeOption::create([
            'name' => 'Black',
            'attribute_id' => 1
        ]);

        $this->assertEquals(2, $attributeOption->id);
    }

    public function test_insert_with_same_columns()
    {
        $result = ProductAttributeValue::insert([
            [
                'attribute_id' => 1,
                'attribute_option_id' => 1,
                'product_id' => 1,
            ],
            [
                'attribute_id' => 1,
                'product_id' => 1,
                'attribute_option_id' => 2
            ]
        ]);

        $this->assertTrue($result);
    }

    public function test_insert_with_different_columns()
    {
        $result = ProductAttributeValue::insert([
            [
                'attribute_id' => 1,
                'attribute_option_id' => 1,
                'product_id' => 1,
            ],
            [
                'attribute_id' => 2,
                'product_id' => 1,
                'text_value' => '15 Gb'
            ]
        ]);

        $this->assertTrue($result);
    }
}

My result test

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.

Thanks, @driesvints. But it is not a question. It is a bug and I have limited the problem to the test until I present it to you until you solve it in the next version. Please do not send the same message and pay attention to the problem. I'd say it's a logical problem, but it has a solution

I'm sorry but all of this seems custom to me. Please try a support channel.

@BrandonSurowiec Can you help me clarify the problem?

@michaelnabil230 This is intended behavior. ProductAttributeValue::insert([...]) is a mass insert, which means that all the attributes being inserted MUST be declared for each array item.
Look at the query and you'll see the columns are declared once, and then all the values that come after reference the same columns.  You would have to format your data to something like this:
$result = ProductAttributeValue::insert([
    [
        'attribute_id' => 1,
        'attribute_option_id' => 1,
        'product_id' => 1,
        'text_value' => ''
    ],
    [
        'attribute_id' => 2,
        'attribute_option_id' => null,
        'product_id' => 1,
        'text_value' => '15 Gb'
    ]
]);

Don't use mass-insert and instead loop over the array to create them one by one:
$attributes = [
    [
        'attribute_id' => 1,
        'attribute_option_id' => 1,
        'product_id' => 1,
    ],
    [
        'attribute_id' => 2,
        'product_id' => 1,
        'text_value' => '15 Gb'
    ]
];

foreach($attributes as $insert) {
    ProductAttributeValue::create($insert);
}

Or you can leverage Eloquent methods. Your ProductAttributeValue model looks like a pivot table. If you want to leverage relationships you would look over these parts of the docs:

https://laravel.com/docs/8.x/eloquent-relationships#defining-custom-intermediate-table-models
https://laravel.com/docs/8.x/eloquent-relationships#updating-many-to-many-relationships
https://laravel.com/docs/8.x/eloquent-relationships#attaching-detaching (look at the array method that allows passing extra data)

$user->roles()->attach([
    1 => ['expires' => $expires],
    2 => ['expires' => $expires],
]);

Looping and inserting one by one is by far the easiest 👍

Thanks @BrandonSurowiec.
@michaelnabil230 can you please first try a support channel next time? Usually, lots of these sorts of questions can be resolved before opening an issue. Thanks

Thank @BrandonSurowiec , for your explanation, but I've posted the issue so you can find a solution so we can develop it on Laravel.
And excuse me for not being able to speak English fluently.


Add node 19 to testmatrix

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure the issue has not already been raised

Issue
We should also test for node19.

I would against to add it at this point.
node@19 active support only 2 months left and security support is 4 months left.

Don't think it's worth it at this point, sorry @Uzlopak. Node 20 is turning up in 2 months,
Will add that when it appears!

Allright. ;)


Redirect error to index

I have deployed a front-end single-page application to S3. Since the SPA needs to manage all routes on the front end, any errors should be redirected to index. However, without enabling the CDN, I couldn't find any configuration option for error_document. Is it possible to add an option for configuring the error document or a place to configure redirect_all_requests_to?

Alternatively, another approach could be that I already have an AWS bucket configured, and this GitHub script only needs to update the new static files without overwriting the manually modified err document configuration every time.

Hi @AaaCabbage ! Thanks for opening an issue.
There are different possible solutions. One would be to be taken care by the code itself (index.html) The other one is with CDN or a lambda function.
This action covers only the CDN option, at least for now. If you could propose any other solution, and can submit a draft PR, we will check it and let you know if we can add it, if you can only propose the idea itself, we'll have to investigate it and check if it's feasible. Either way, we will welcome any suggestion.
Thanks again!
Leo

Hi @Leo,
Thank you so much for your prompt and detailed response!
I’m not very familiar with the Terraform framework, but I’ve opened a new PR where I’ve attempted to add the aws_site_error_document configuration based on the Terraform documentation. I would really appreciate it if you could take a look at the code and provide any feedback or suggestions if there are issues.
Thanks again for your help!
Best regards,
AaaCabbage

Hi @AaaCabbage ! Thanks for your suggestion!
I wasn't aware such option existed.
Your PR looks neat.  Let me know if you need directions on how to test it.
As soon as we have some time, we'll conduct some tests and merge it. Thanks again for your input!

Hi @Leo,
Thank you so much for the kind words and for recognizing my work on the PR!
I’ve already tested the changes on my own project. To do so, I published the modified action to the GitHub Action Marketplace and then applied it in my project. After deploying, I checked the S3 bucket's website configuration and confirmed that the error document was correctly set as expected.
However, I’d appreciate it if you could verify that my testing approach aligns with your project's standards. If there’s anything I missed or if further adjustments are needed, I’m happy to help out.
Thanks again for your support!

Hi @AaaCabbage, we are always happy to receive contributions.
The code looks good, tested it and does what it should. The only thing is that if we don't have an error.html document, then it will map it to that one as default, making it show another message saying that the error.html file is missing.
So, we would need that error doc block to be dynamic and create it only if there's an error file present.
If you manage to make that happen, awesome! If not, I'll try to make some time this week, merge this and add that feature.
Thanks again for your contribution!

Hi @LeoDiazL
Thank you for pointing that out!
I hadn’t noticed the issue with the missing error.html leading to the extra message. One thing that may have contributed to my confusion is the S3 web UI, where the error document field has a placeholder set to error.html, which led me to believe that this was the default behavior if nothing was configured.
I’ve now updated the code to set the error document to an empty string by default. I believe this aligns better with S3’s default behavior and should prevent any unnecessary error messages from appearing.
Thanks again for your feedback, and please let me know if there’s anything else I should adjust!

Hi @AaaCabbage !
Added a comment in the PR, I could test it again once that's merged, and if it works, then we'll :shipit:
Thanks again!

Thanks for your suggestion @AaaCabbage ! it's now live in 0.2.3!


how to extend new layout?

in my module view i have these
Modules/Abc/Resources/views/layouts/pdf.blade.php and in it i have this
<!DOCTYPE html>
get('locale') ?? app()->getLocale() }}">

    <meta charset="utf-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
    <link rel="icon" type="image/x-icon" href="{{ asset('favicon.svg') }}" />
    <title>@yield('title')</title>

    @yield('content')

and in my view
Modules/Abc/Resources/views/pdf/pdf.blade.php i have this
@extends('abc::layouts.pdf')

@section('content')
kkajdakjsdlasjdaljdlasjdlaajdlaj
@endsection

when i go to the page, the page loads but not using the layout. any ideas why?

The issue might stem from how Blade is resolving the view paths and namespaces in Laravel:
Can you please make sure below things:
Register Views in Service Provider:
Ensure your module's service provider correctly registers the views.
// AbcServiceProvider.php
public function boot()
{
    $this->loadViewsFrom(__DIR__ . '/../Resources/views', 'abc');
}

Use Correct Blade Directive:
Ensure you extend the layout correctly in pdf.blade.php.
@extends('abc::layouts.pdf')

Clear View Cache:
Clear the view cache to ensure changes are reflected.
php artisan view:clear

Debug Layout:
Add a test message in your layout to ensure it loads.

Layout is loading

    @yield('content')

Route and Controller:
Ensure your route and controller return the correct view.
// web.php
Route::get('/pdf', 'PdfController@showPdf');

// PdfController.php
public function showPdf()
{
    return view('abc::pdf.pdf');
}


Improve Backup

Two improvements:

Checksums are stored in .txt file (instead of .xml)
ZIP contains a table of contents to quickly identify what's in each file

does it still work restoring old backups? format wise?
I think its okay to break, just something for the changelog

it just changes the extension of the checksum file in the zip. it removes the extension on restore so old backups still work


Use __errno_location on DragonFly BSD

DragonFly BSD 5.8+ has __errno_location.
https://github.com/DragonFlyBSD/DragonFlyBSD/commit/60d311380ff2bf02a87700a0f3e6eb53e6034920

Does Rust support versions of DragonFly before 5.8? I checked here and it doesn't specify a version.

I don't know about specific version requirements.
That said, I don't think older versions that went EoL years ago[^1] are actively supported.

nix crate switched to use __errno_location in 2020-10: https://github.com/nix-rust/nix/pull/1296
On FreeBSD, support for versions that went EoL is planned to be removed: https://github.com/rust-lang/rust/issues/89058

[^1]: According to https://gitlab.com/libosinfo/osinfo-db/-/commit/5ffadcd0cc5db8cc971246340d86ccdf9695c6a5 an old version becomes EoL once a new version was released. DragonFly BSD 5.8.0 released in 2020-03-03.

Thanks, that sounds reasonable.

This is now released in errno 0.3.5.


Slow response (API calls) when operating through VPN

When using a VPN (in my case Mullvad on Fedora 35), Psst is considerably slower in requests and the UI blocks as a result. In my tests, I don't latency could really be a factor here as I only go from ~9ms to ~20ms with VPN off to on. I'm not sure what the hang could be - perhaps it's at Spotify's end? - But definitely something to note?

Are you saying that using psst while connected to your VPN is slower than using the official client while connected to your VPN? Or that using psst while connected to your VPN is closer than using psst while not using your VPN? It's always going to be slower through a VPN, seemingly twice as slow by your measurement?How are you measuring the latency to Spotify's servers?

Are you saying that using psst while connected to your VPN is slower than using the official client while connected to your VPN? Or that using psst while connected to your VPN is closer than using psst while not using your VPN? It's always going to be slower through a VPN, seemingly twice as slow by your measurement - which sounds reasonable. You are, after all, forcibly sending your traffic the wrong way.

Yes, it makes sense that there would be some delay in requests - but it really should only be subtle, I can't imagine it would exceed 100ms right? The tested VPN location is within 50km of my location. However, the response time delay increase is in the factor of 4 or 5 times longer. This, to me, seems like either Spotify isn't happy with the request origin (the VPN IP?) or there's some hang up within Psst.

How are you measuring the latency to Spotify's servers?
Pinging spotify.com

That's, uhh... strange? No idea where to look at the moment :|

@jacksongoode can you provide which access point is being used in both instances. Psst logs a trace message with this info.


Support for <> field in Word

Currently there isn't logic to merge multiple records into a template using Microsoft Word's default fields. Any interest in adding support for NextRecord and filling a template that way? This way a template can be created with Word and used with this gem?

Hi @bdknox I'm not sure I understand your question. The current flow for sablon is to create a template in MS Word using some special syntax in the merge fields depending on what you want to do (see README). Then you process that template against a given context hash either by calling the "sablon" executable with JSON fed into it or via some other ruby code that requires the gem and calls the appropriate methods.
Are you talking about processing the same template multiple times with different values in the context hash (i.e. like you would using mail merge with rows in an excel doc)?

Hi, sorry for the confusion. I'm requesting to allow the typical Word Syntax in addition to the syntax specific to sablon. So there is an option to pass in a template with either Sablon's syntax or Word's.
To answer your question with this added information, yes processing the template multiple times would be part of the flow similar to Excel. In the case where the context hash has more values than there are records per template it would need to fill out one template and then start a new one from where it previously left off in the context hash.

@stadelmanma

@bdknox My apologies for the incredibly late response, this one slipped through.
This is possible for simple insertion by adding a new field handler, or more accurately duplicating the insertion handler to not require the leading ='s sign. However, if you do register an insertion handler without a prefix it's likely that none of Sablon's other constructs will work as expected since it will think every mergefield is an insertion point. See field_handlers.rb in the module, essentially all you'd need to do is subclass Sablon::Processor::Document::InsertionHandler and change the initialize method to your desired prefix or no prefix and just use /./ as the pattern.
If you don't use a prefix then you might try modifying the handles? method in your subclass to make it more specific.

As for the <> portion I don't think we want to add that feature. It would be preferable (and easier) to permute/combine the context hash variations in the application code and then just call the render method in a loop for each variant. Thanks for using sablon!


soroban-rpc: xdr schema changes between preview releases prevented startup

What problem does your feature solve?
after upgrading rpc to a newer version that has different db schema, have observed the restart against prior db fails with schema errors. Have run into this on restart of rpc on kubernetes deployments of the rpc image, since it stores the db on a PersistentVolume, in order to have dedicated/stable access to known storage and limits rather than hoping it will 'fit' on default ephemeral pod storage, which is variant.
What would you like to see?
rpc start-up recognizes older db schemas if present in the db instance provided at runtime and attempts migrations where possible to lift the given db to current schema required, allows rpc to have a successful, autonomous start-up after a sw version upgrade containing a db schema change
What alternatives are there?
before restarting rpc on new sw version with new schema, first delete the prior db it had created and then start rpc server, it will create a new db from scratch.

@2opremio , this bug report from a couple preview releases ago seems similar to  behavior observed today during the reset, upon restart of new rpc version in a new container, assuming new/empty storage established, observed startup error:
could not obtain txmeta cache from the database" error="sql: Scan error on column index 0, name \"meta\": union LedgerCloseMeta has invalid V (int32) switch value '2'

Yeah, the XDR changed but the db wasn’t reset (for some reason it still contained old data)

i think this can be closed as obsolete, it's not occuring or replicatable, and xdr changes are done.


[bug]ask format eat some additional lines

thanks for with great plugin, which makes working with notebooks in nvim so much better.
I happen to notice some lines is eaten when using the ask_format, I'm using otter with pyright and ruff-lsp server. Having tried with a minimal config on the astronvim pack, but it still remains.
original
```python
print("first line")

print("2nd line")
```

## Header1

```python
print("3rd line.")

print("4th line.")
```

```python
print("5th line.")
```

after ask format in the first code cell
It seems the '```' and 'header' is gone
```python
print("first line")

print("2nd line")

```python
print("3rd line.")

print("4th line.")
```

```python
print("5th line.")
```

after ask format in the 2nd code cell
the '```' is gone.
```python
print("first line")

print("2nd line")
```

## Header1

```python
print("3rd line.")

print("4th line.")

```python
print("5th line.")
```

Looks like https://github.com/jmbuhr/otter.nvim/issues/87#issuecomment-1937646958 is back, I'll investigate!

In the process of rewriting how otter.nvim operates I (temporarily) removed the ability to handle formatting to make everything else much cleaner (see https://github.com/jmbuhr/otter.nvim?tab=readme-ov-file#otternvim and https://github.com/jmbuhr/otter.nvim?tab=readme-ov-file#current-limitations). I will revisit this properly in the future, but for now I recommend external plugins for formatting. Specifically conform.nvim works super well for me, here is my config: https://github.com/jmbuhr/quarto-nvim-kickstarter/blob/382b050e13eada7180ad048842386be37e820660/lua/plugins/editing.lua#L29-L81


[python] platform_config for DataFrame.read()

Use to test paginated reading.

Codecov Report
Base: 60.85% // Head: 74.51% // Increases project coverage by +13.66% :tada:

Coverage data is based on head (118ba94) compared to base (53d82ac).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #562       +/-   ##
===========================================
+ Coverage   60.85%   74.51%   +13.66%
===========================================
  Files          63       26       -37
  Lines        3224     1817     -1407
===========================================
- Hits         1962     1354      -608
+ Misses       1262      463      -799

Flag
Coverage Δ

python
74.51% <100.00%> (+0.02%)
:arrow_up:

r
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

apis/python/src/tiledbsoma/dataframe.py
99.34% <100.00%> (+<0.01%)
:arrow_up:

src/include/tiledbsoma/column_buffer.h

inst/tiledb/include/tiledb/vfs.h

src/riterator.cpp

R/utils-tiledb.R

R/SOMADataFrame.R

inst/tiledb/include/tiledb/query_condition.h

inst/tiledb/include/tiledb/utils.h

inst/tiledb/include/tiledb/array_schema.h

src/include/span/span.hpp

... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

re https://github.com/single-cell-data/TileDB-SOMA/pull/562#discussion_r1035216423
@thetorpedodog thanks, I thought we'd have to do more to mesh this with the create config...I didn't completely follow the suggested approach though. Can I ask you to elaborate...where are we putting this new tiledb_config key, just in the dict passed here, or in the higher-level TileDBPlatformConfig?
cc @gspowley

Withdrawing as this particular implementation should be superseded by @atolopko-czi work on #644


Parameterize Conda Channel for khiops-core in Dockerfiles and conda Workflows

Description
Currently, khiops-dev is hard-coded for these, which obliges us to push final khiops-core releases to khiops-dev as well.
Questions/Ideas

The solution is to have this channel as an input to the docker.yml and conda.yml workflows. In the former case (Docker), this channel input would be passed as a build ARG to the Dockerfiles.

Having all versions in khiops-dev was the intent. We do not want to pollute the download count in the main channel.

Having all versions in khiops-dev was the intent. We do not want to pollute the download count in the main channel.
Yes, right, thanks for reminding this! Hence, I will reject the issue.

All CI / test versions should be taken from khiops-dev in order to keep khiops download statistics accurate.


Prefer the last modification time of the cache objects

The cache objects can be newly created or updated.  When the cache
object is updated by a build, it makes more sense to use the last
modification as an 'update time' instead of the creation time.
This patch factors out a getCreateTime function which tries to
retrieve the last modification time and the object creation time, in
this order.

Thank you attempt to contribute, but unfortunately I have to close this PR.
Current behavior is actually intended to work this way and is required for proper cache expiration.  That is the reason why it is called creationTime, rather than lastUpdateTime. I guess I could document it a bit better in the code.
If you look at cache-s3 restore --help you'll see:
  --max-age ARG            Amount of time cache will be valid for from the
                           moment it was initially uploaded to S3, i.e. updating
                           cache doesn't reset the time counter. Accepts common
                           variations of (year|day|hour|min|sec), , eg.
                           --max-age='30 days 1 hour' or --max-age='1h 45m'

This feature is very useful for occasional stack lts updates. --max-age will cause the cache to be occasionally invalidated and rebuilt from scratch, thus preventing infinite accumulation of files that are no longer used. If we would switch to prefer the gorsLastModified it would be possible for cache never to get cleared.

@wagdav I do like the refactoring part of this PR though, so if you switch back to:
  (HM.lookup metaCreateTimeKey (resp ^. gorsMetadata) >>= parseISO8601) <|>
  (resp ^. gorsLastModified)

I'll gladly reopen the PR and merge it in.

Ah, thanks for the explanation!
My initial motivation for this PR was the following message:
[cache-s3][Info ][Tue, 16 Apr 2019 09:34:01 UTC]: <master.cache> - Restoring cache from Tue, 16 Apr 2019 06:17:03 UTC with total size: 309.9 MiB

Here we see the creation time of the object. This is confusing when a previous build already updated the cache, so we actually using a cache that is newer (which is described by the last modification time).
Let's keep this PR for the refactoring!

@wagdav I do like the refactoring part of this PR though, so if you switch back to:
  (HM.lookup metaCreateTimeKey (resp ^. gorsMetadata) >>= parseISO8601) <|>
  (resp ^. gorsLastModified)

I'll gladly reopen the PR and merge it in.

I'll open a new PR with the refactoring, so it's better documented.


Set certain Python package dependencies to fixed versions.

This is mainly to avoid compatibility issues with newer versions of other
packages (e.g. tensorflow-transform 0.25.0) that could be installed
using the '>=' specifier.
Description
Please include the following:

Please include a summary of the change and which issue is fixed.
Context/reason for change and issue # if applicable
Any dependencies that are required for this change.

Fixes #68 (bandaid fix)
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)

Checklist
Please delete options that are not relevant.

[X] I ran make pylint and code is rated 10/10
[X] I ran make test and all tests pass
[X] My changes generate no new warnings
[ ] I have corrected any misspellings in my code
[X] (For hotfix/release) I have updated the package version number in setup.py (i.e. MAJOR.MINOR.PATCH)
[X] (For hotfix/release) I have updated RELEASE.md with notes regarding the changes

@cfezequiel merged


Great software! 3 questions

Any lib example? Trying to use as a package ledis. cant seem to find any useful information on how to use as a package

I'm running golang as "daemon" and doesnt work this way, how do I resolve?
                 var cfg = lediscfg.NewConfigDefault()
                 cfg.DBName := "RAM"

returns
                  syntax error: non-declaration statement outside function body

I don't understand how to properly get the values of the list
           list, _   := fcachedb.HMget([]byte("key"),[]byte("value1"),[]byte("value2"))... etc up to "value8"

how do I get individual items on the list?

when will multi-exec be implemented?

why use boltdb when performance is much terrible than leveldb etc?

can you provide the test code?  HMget is for hash, for for list.
No plan now
One is Go vs C++, the other may B+ Tree vs LSM.

What I would like to achieve:
https://pastebin.com/raw/DZheFgwX

OK.

Alright. Thanks. Appreciate this.

Very good.


Add bg for ProgressBar.item

Merge this once https://github.com/primer/react/pull/5007 is merged

To avoid CI confusion, should eslint-plugin-primer-react before primer/react in dotcom


success payment when user click on the back button

in this repository when i click on the back button it success the payment this is the main issue of this repository..

Already on this issue, will update probably tomorrow

Hi ther, could you pls explain what is the issue about and why is this happening @incrediblezayed  ?

Hi there, could you pls explain what is the issue about and why is this happening @incrediblezayed  ?

There was some issue with the api call flow, it's fixed but I haven't updated yet

Thanks for the info !. Btw when can we expect an update or if its a small change can you tell me where the change is ?

Updates @sagnik-sanyal , Please check v0.0.5

Hi @incrediblezayed  Using v0.0.5 still getting the same issue. Any update on this.

@rameshkec85 Can you screenrecord or something if possible?

Closing the issues, opened for the long time without response


Add description to the 'Benefits for joining' LeetCode

Task
On the LeetCode page, there are bullet points for benefits of joining. It would be good to have some description for it.
Page URL
https://womencodingcommunity.github.io/program-interview-preparation#leetcode
Description to add against the bullet points
Benefits of joining:
Collaborative learning - Practice problems, share solutions and strategies
Accountability and motivation - Set goals, track progress and engage with peers
Gain confidence - Build confidence to approach a problem in a structured manner
Different perspectives- Exchange different problem solving approaches
Acceptance criteria
Screenshot of the page showing the benefits with description listed above

I can take this one


[Feat] Support Qwen-VL-Chat on MMBench.

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

Pipeline Introduction
As shown in the config, the whole pipeline contains three components. Dataloader, model and evalutor.
The dataloader loads data samples, both images and texts. The model takes the multi-modal inputs and generate response. The evalutor evaluates the model by given metric.
In MMBench, each data sample contains: image, question, several options and maybe hint. The model organize these inputs via PromptConstructor. The evalutor for MMBench just dumps the result and the accuracy is computed offline.
Prompt Constructor
Here, we load every piece of the sample and concat them all. To meet Qwen's requirement, we format the prompt as list. The image path here is just a place holder and we do not load the image through this path.
Model
Since MMBench loads the images from base64 strings, we do not have url or local path. Therefore, we load the image and do the transform in dataloader (See val_pipeline for transform details), and builds inputs_embeds before generate.
The above mentioned part is done in _build_embeds method. Following the forward method of Qwen, we tokenize the image with vision transformer, find image positions, tokenize the input text and combine them.
Then, we input inputs_embeds together with input_ids in generate function and the inputs_embeds have higher priority to be used.
Here we meet a bug when inputting inputs_embeds and it is described in this issue (https://github.com/QwenLM/Qwen-VL/issues/30). To address the issue, we copy the forward function, fix the bug and hack the model in __init__.
Finally, we decode the answer following chat method of Qwen and return the response.

Please fix the conflict

Would you please give a detailed instruction to help people follow the evaluation process of QWEN-VL-CHAT on mmbench? Thanks a lot!


[User handles] set current MSA ID max to 2^32

As a user I should not be required to have a handle to create a MSA.
Acceptance Criteria:

can create an MSA without a handle
msa::create still works
createSponsoredAccountWithDelegation should still work

Constraints:

we make the assumption the handle system is contained to the 32 bit space

The current MSA id (MessageSourceId) is a unsigned 64 bit value (u64). In this new scheme, users without handles will have MSA ids from 0 to (2^32) - 1.  Users with handles will have MSA ids in from (2^32) to (2^64) -1.

We need to review the Frequency code base to ensure that there are no assumptions that a MSA id is an incremental sequence.


export settings / embedded audio master file

I think it could be very cool if the exporting application could embed a master audio file into the dawproject. This also raised the idea of including export settings in the Project.xml
Including export settings:

which audio channels should be rendered (especially useful for stems)?
which arrangement time range should be rendered
which audio format(s) should be exported and which to prefer if there is no multi-format export?
which dithering setting should be used?
which target samplerate should be used?

Embedding an audio master:

would be useful for audio preview in

some simple dawproject file browser app
on a website
in Bitwig Studio's sidebar browser

maybe not only one single audio file but even multiple stems?

In general:

the export settings should be in the Project.xml
the audio file reference for the embedded audio master should be in the Metadata.xml
Even if no audio master is embedded, the export information still would be very useful if the export settings would be transferred as good as possible to their DAW so they can reuse them

Btw, embedding a rendered Master would also be helpful for users for checking which audible elements got lost during transfer to another DAW


fix: hybrid storage encode bug in multi record batch

Which issue does this PR close?
Closes #403
Rationale for this change
Fix bugs described in #403 .

What changes are included in this PR?

Are there any user-facing changes?
No.

How does this change test
Modify some tests to cover this bug.

@chunshao90 I think of one critical issue for hybrid format: it will not be compatible with bloom filter.
We built bloom filter for each row group, there will be exact num_rows_per_row_group rows in one row group, since ParquetWriter will flush row group until the accumulated rows reach num_rows_per_row_group, otherwise it will just pending them.
The problem is that hybrid storage will shorten rows in one row group, for example if we set num_rows_per_row_group to 8192, after hybrid conversion, it will less than 8192, then ParquetWriter will not flush this row group since 8192 is not reached.

@chunshao90 I think of one critical issue for hybrid format: it will not be compatible with bloom filter.
We built bloom filter for each row group, there will be exact num_rows_per_row_group rows in one row group, since ParquetWriter will flush row group until the accumulated rows reach num_rows_per_row_group, otherwise it will just pending them.
The problem is that hybrid storage will shorten rows in one row group, for example if we set num_rows_per_row_group to 8192, after hybrid conversion, it will less than 8192, then ParquetWriter will not flush this row group since 8192 is not reached.

I create an issue #435.


Issue #505: iDRAC changes in FAQ.md

Issues Resolved by this Pull Request
Fixes #505
Description of the Solution
iDRAC changes in FAQ.md
Suggested Reviewers
@lwilson @j0hnL

@all-contributors add @abhishek-s-a for documentation


some minor usability improvements

resave now supports two different parameters for locations in the file tree:
source_path: the path where the raw data from the simulation is stored
save_path: the path, where the processed data will be saved. If no save_path is given, it defaults to ./data to ensure upward compatibility.
explore_Parameterspace now returns the figure object of the respective plot

Thank you so much! I have two minor suggestions. See the "Files changed" tab

Hi, I just committed minor changes to comply to your requests. Now the default value for the save_path is  given in the function definition and the documentation for the input parameters of the resave_data function is given in the order of the parameters in the function definition.

Hi, I just committed minor changes to comply to your requests. Now the default value for the save_path is given in the function definition and the documentation for the input parameters of the resave_data function is given in the order of the parameters in the function definition.

Many thanks!


question: Rancher pipeline requires administrator privileges of bitbucket code repository

What kind of request is this (question):
Steps to reproduce (least amount of steps as possible):

I have created two users in bitbucket and a code repository, one account is the administrator of the code repository, the other is only read-write permission
Then use these two accounts to the pipeline to authenticate the code repository

Result:

When I use the administrator account to authenticate，rancher while list the public repository and private repository whice i have premission.
When I use the read-write account to authenticate, rancher only list the public repository.
Why rancher pipeline need administrator rights of code repository? I think the read-write permission should be enough.

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):V2.3.2
Installation option (HA):

I think this is because the rancher pipeline installs a webhook on the repository and therefore it needs admin rights. So this is more a bitbucket specific problem?

I think this is because the rancher pipeline installs a webhook on the repository and therefore it needs admin rights. So this is more a bitbucket specific problem?

Thank you for your reply,
I have studied your suggestion carefully and I found that Rancher does not create a webhook under any repository when list code repository.
The time for rancher to create webhook is when enable the target code repository.
So I don't think that's the reason

To use this automation, webhook management permission is required for the repository. Therefore, when users authenticate and fetch their repositories, only those on which they have webhook management permission will be shown.

It is explained in the docs:

To use this automation, webhook management permission is required for the repository. Therefore, when users authenticate and fetch their repositories, only those on which they have webhook management permission will be shown.


Collapse Scope Nodes on Load

Describe the Bug with repro steps

Have a large logic app with multiple nested scopes
Open run history
Note that all scopes are expanded. Users are reporting that there is a large initial load time, sometimes to a point where the page can become unresponsive
This issue is not apparent in Old Designer

What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
All
Additional context
I had a call with a customer where the new designer has become unusable, as it has a long initial load time. I noticed a lot of it was due to loading of nested actions, and especially when loading inputs/outputs of those nested actions there was a significant delay. Creating this incident to collapse scope nodes as done in old designer for larger workflows or to investigate better ways of addressing this issue

I know @rllyy97  looked into doing this as well as part of hte consumption readiness work. I think there were some problems with delaying the load of the nested components in redux even if they were collapsed. I do agree though that if we could find a way to delay that or reduce that, it would be a big win.

What Travis said is correct.  However, even if we do still do the background initialization, hiding some nodes in the renderer might speed things up a bit, it's worth looking into.

May I know the ETA for resolving this issue? The legacy designer will be retired in September 2024, will this issue be fixed before then?

Hi Team, any update for this. Since the Legacy Designer will retire in 2 weeks, will the issue be resolved before then?

Hi @EnochZZ717, recently I worked on a lot of performance improvements and one of them was that nodes offscreen will not be rendered, which overlaps with the perf benefits we would get from this feature.  That change will be live with our next release, and I don't think we'll be spending resources towards this issue (for perf reasons) now that we have that alternative fix.

Hi @rllyy97 , thanks for the update, could you let me know when the next release is scheduled?

This we would expect to see to all regions by 8/20

@rllyy97 you had said the ETA for this to be 8/20- is that accurate or has that changed?

@kisubedi The performance improvements went like around 8/20, the collapsing of scope nodes on load was not implemented yet, and it's currently not being worked on

@rllyy97 Is it planned ? If so, can you share tentative ETA please ?


Added ability to filter code complete options by type (function, class, const, signal, etc)

Like the Visual Studio implementation.
You can filter completion options by type. Sometimes you only want to see functions, etc but you get a huge list of everything. Now you can filter just for those! Hurrah!

Also fixed a bug where clicking + dragging (even just for 1 pixel) on the code completion box started selecting text. See below... hard to show clicking and dragging though!

While this is pretty cool, keep in mind there's a long-term goal to refactor TextEdit to make it easier to maintain: #31739

This looks nice, but is there a way to access different tabs with a keyboard? Code completion is a poweruser tool, and switching to a mouse to use this functionality is not desirable.

@pycbouh Oh yeah! I thought of that but totally forgot before making the PR.

@Calinou Yeah I saw the PR that was made for that earlier today. I would be interested in 'porting' this feature to that implementation if it is merged first. Especially if it is cleaner to do so. text_edit.cpp is almost 8k lines now!
@pycbouh I added shortcuts like in Visual Studio, e.g. Alt + F = functions, Alt + S = signals, Alt + C = constants, etc. Also Alt PgUp/PgDn to cycle right/left through the tabs.

While the feature looks cool, I don't see much use for it. The autocompletion should just accurately suggest the identifier you are trying to write (see #21726), the amount of options doesn't matter.

@KoBeWi The situation where I use this is where I am looking for a function/property/etc on an object, but don't remember it's exact name. So I can use this to quickly find what I need instead of going to the source script/docs.

This is probably better to be implemented at some point in the future, maybe 4.1, when the api for script/code/text editor is finalised.
Closing for now, and would submit as a separate PR in the future if I were still to implement.


Ability to use varchar/text sql type to map to rust enum?

Is it possible to not have a enum type in the database corresponding to the rust enum as it would be easier to just store the value as a string since it will make migrations easier. That way we wont need to mapping also right? Just serialization and deserialization will suffice.

I think this should work as-is (you would need to keep the mapping the same though). Of course the problem then is that if any text other than the enum is found in the column, it will error when trying to deserialize. Possibly there are ways to make this more lenient, e.g.
#[derive(PgEnumLenient)]
enum MyText {
    Foo,
    Bar,
    Other<String>    // This catches all other text
}

Yes it doesn't work. I did find a way to do it myself but forgot. You need to implement a diesel ToSql/FromSql trait and it will actually solve it.

If you figure out how to do this, I will gladly add it to the crate!

Out of scope


Upgrade to latest version of node-sass

This would allow support for Node 10.x and 11.x versions
I tested this with those versions of node and it works as expected

The Travis build needs to be updated to do the checks for latest versions of node.

npm audit has an outstanding security vulnerabillity on node-sass-middleware, hopefully updating this dependency will fix it:
High            Arbitrary File Overwrite
Package         tar
Patched in      >=4.4.2
Dependency of   node-sass-middleware
Path            node-sass-middleware > node-sass > node-gyp > tar
More info       https://npmjs.com/advisories/803

@apalanki since the ^ is already there, NPM will already install 4.11 on install (and 4.12 once it is released)
@GeeWee that is being tracked by https://github.com/sass/node-sass/issues/2625 and tracing down to the Tar repo, it looks like 2.x tar isn't actually vulnerable like the report indicates, but is buggy


chore: make isstream a top level production development

Our npm-shrinkwrap.json file contains two entries for the isstream
dependency. One of them is in the top level of the file, and marks
isstream as a development dependency.
The request module makes use of isstream, so there is another
instance of isstream nested inside request which is marked as a
production dependency.
Most NPM versions will realise that there are two instances of
isstream, and since one of them is a production development, it will
include it in the final package.
However, there are some NPM version, like 4.6.1, which will only
consider the top level entry, and completely omit isstream on the
final package, causing a "Cannot find module 'isstream'" error.
The solution was to manually update the shrinkwrap file to remove the
nested instance, and make the top level instance a production
development.
I don't think there is a way we can protect ourselves from these edge
cases. NPM should have recognised that the dependencies were compatible,
and not create a nested instance on the first place.
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

However, there are some NPM version, like 4.6.1, which will only
consider the top level entry, and completely omit isstream on the
final package, causing a "Cannot find module 'isstream'" error.

Is that a bug in NPM? Should we try locking down the version of NPM that Etcher can be built with?

make the top level instance a production development.

Huh? Was that supposed to be "production dependency" ?

" jviotti added a commit that referenced this pull request 2 days ago
@jviotti	Revert "chore: make isstream a top level production development (#1373  …"
Hmmm, whassat all about?

Should this PR have included a modified package.json too??

Is that a bug in NPM? Should we try locking down the version of NPM that Etcher can be built with?

We discussed that recently, but we still need to find a good way to do so. Maybe we can add npm as a git submodule?

Huh? Was that supposed to be "production dependency" ?

See what happens when you're not around? :P

" jviotti added a commit that referenced this pull request 2 days ago
@jviotti	Revert "chore: make isstream a top level production development (#1373 …"

Hmmm, whassat all about?

I accidentally clicked the "revert" button on the GitHub UI. I didn't get into master, since I didn't create a PR for it.

Should this PR have included a modified package.json too??

This is a dependency very down the dependency tree, so no package.json change required.

See what happens when you're not around? :P

:rofl:

Should this PR have included a modified package.json too??

This is a dependency very down the dependency tree, so no package.json change required.

Oh? From what little I understand, isn't it supposed to be theoretically possible to regenerate the npm-shrinkwrap.json from the package.json? So shouldn't isstream be listed in the dependencies in package.json, to make sure it stays a production dependency ? Or have I grabbed the wrong end of the stick again?

I didn't get into master

Sorry to hear that... ;)
I was going to ask if a relevant bug exists for this issue against NPM, but then I saw that https://github.com/npm/npm/issues lists nearly 3000 open issues... eek!

Oh? From what little I understand, isn't it supposed to be theoretically possible to regenerate the npm-shrinkwrap.json from the package.json? So shouldn't isstream be listed in the dependencies in package.json, to make sure it stays a production dependency ? Or have I grabbed the wrong end of the stick again?

By production dependency, I mean a dependency that is not a development dependency. We don't depend on isstream directly, which is the reason its not in out package.json (its a dependency of a dependency).

I was going to ask if a relevant bug exists for this issue against NPM, but then I saw that https://github.com/npm/npm/issues lists nearly 3000 open issues... eek!

lol

Right. So basically the whole npm-shrinkwrap.json is quite fragile then?

Yeah, looks like we can't even trust npm to keep it on a sane state.


Suggests raw string even when string contains backtick, which can't be contained in raw strings

The line in question is
https://github.com/revel/revel/blob/master/validators.go#L197

IMO it would be more readable to use raw strings + string concatenation for the backtick, instead of needing to escape \ a dozen times.

I'll close this issue. I stand by my earlier opinion, and there hasn't been any activity on this issue to convince me otherwise.

In general, I agree, but I can imagine a worse case scenario where the string value is:
var worstCase = regexp.MustCompile("```\\n")

Would the suggestion still be valid then?

The first version does look nicer imho. However, we'll cross that bridge when we come to it (i.e. when someone actually has that regular expression in their code.)

However, we'll cross that bridge when we come to it

That's exactly what I was thinking. 👍


jetson-tx2-devkit: add BUP support for FAB D02

Jetson TX2 devkit modules got a version bump, so to make
sure that we can build compatible BUP payloads, add that FAB to the
list of specs is needed.
Signed-off-by: Ilies CHERGUI<EMAIL_ADDRESS>

This update in the machine conf file need to be ported to the branches dunfell-l4t-r32.5.0, dunfell-l4t-r32.4.3, dunfell-l4t-r32.4.2, ...

I've cherry-picked this to the other branches, except dunfell-l4t-32.4.2, which is not actively supported.

I've cherry-picked this to the other branches, except dunfell-l4t-32.4.2, which is not actively supported.

Thanks


fixes a click.Path related unittest on Windows

@costypetrisor
Thanks, man, didn't have time to check windows stuff. :)


[Tizen7.0] PR to support Tizen7.0

This pull request includes the following commits to backport NNTrainer for Tizen 7.0:

Commit related to fp16 enablement is included: 9328d1f898953d08d5e2f48c3c9f500b1ad3fdee
Commit for layer initialization is included : 4d7a8c4b9bfc998a71df94aec2b2a856aba71478
Commit to disable nnstreamer nntrainer is included : 450000572e8a7e993d36f06e0413c2ae4abc2e5a
Commit to support Tizen7.0 is included : 96bb3df9726e3975710817a82c2889f1c26b4484

This PR is tested with AuXFT example on QRB4210 board (w/ Tizen 7.0).

Self evaluation:
Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2720. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @EunjuYang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2720-202408281405160.16658806800842-96bb3df9726e3975710817a82c2889f1c26b4484/.

:octocat: cibot: @EunjuYang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2720-202408281606050.86143207550049-279e32496257c8fdcc320927a928a7be41a15fdb/.


Function keys as standard turned off but they don't work

Before opening the issue, have you...?

[X] Searched for existing issues

Question
I installed this app. It didn't work so i deleted it. After that my setting for the functional keys in mac os doesn't work anymore.
Turn on "Use F1, F2, etc. keys as standard function keys".

I only can access my media keys with "fn" even when the option in the settings of mac os is disabled.
What i can do to disable my functional keys as default?

Honestly, I am not sure why this is happening as the app does not interfere with this setting at all, not while installed or after it is uninstalled. I'll move it to discussions, maybe somebody experienced something similar and might have an insight.


Registerable k8s workflow executor

TL;DR
Provide additional abstraction layer for execution creation to enhance runtime flexibility.
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Tracking Issue
Follow-up issue
NA

updated, PTAL @EngHabu

PTAL @EngHabu @pmahindrakar-oss

verified with a live deployment that

inputs get passed
annotations & labels get passed correctly
execution config params are passed

Recovery Execution
Max Parallelism

permissions (k8s service account and iam role) get resolved
task resources get set
AcceptedAt set
RawOutputDataConfig set
@EngHabu


Changing the cursor

Changing the cursor on import file from pointer to hand grab which is used other buttons such as change sheet, download file

Please assign this to me @Priyanshujha11

Hey @Priyanshujha11 can you please assign this to me for Gssoc21


[legal] What's about repository names for your open-source projects starting with 'docker'?

Description

Yesterday there was a blog posting about Don't use "docker" in Github repo names or as Twitter handles, which got some real attention. I.e. it was linked on one of Germany's most read tech blogs.
I understand there there is a trademark for "Docker" and that this has to be enforced.
But the posting states explicitly

In particular you are not allowed to use repository names for your open-source projects starting with 'docker'

I read through https://www.docker.com/trademark-guidelines but could not find a paragraph explicitly stating that, rather

The Docker mark is used only in a referential context or for naming Docker or to indicate compatibility, and not in a title of a program, domain name, website, product or service

Could you please clarify that.
Steps to reproduce the issue:

Name an open-source repo on GitHub "docker-whatever" (*)

(*) to indicate that this is a build on DockerHub or a docker-compose setup for my "whatever" project.
Describe the results you received:
Hypothetically get sued by Docker Inc.
Describe the results you expected:
Helping the open-source community by sharing my code.
Additional information you deem important (e.g. issue happens only occasionally):
I did not mail this to<EMAIL_ADDRESS>since I think this is important for the community.

They will have some work with more than 100k repositories with the name docker in the title

I wonder if people just fork this repo (don't make any changes) are also affected.
Well, just forked to find out.

According to the Apache license :

Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.

I think "describing the origin of the Work" is exactly what the devs are doing by naming their repositories docker-xxxx

@axzxc1236

I wonder if people just fork this repo (don't make any changes) are also affected. Well, just forked to find out.

That should not be a problem!

@schmunk42 thanks for opening this! I agree that some more information can be useful for people, so I asked the "trademark" / "legal" / "whatever" (I'm not a lawyer, bear with me :smile:) to provide a bit more information about what's "ok" and what not. First of all, in all cases that I'm aware of, Docker Inc. will not directly sue someone, and always open a conversation first ("Hey, we noticed that ..., could you change this or that"), so don't be afraid to find the police banging on your front door in the middle of night :wink:.
All jokes aside; I got an initial reply from Docker, Inc. that should give some more information. They're also working on a more extended description with "good" and "bad" examples, and once that's there, I think it'll be added to the website, and possibly copied (or linked to) from the GitHub repository and documentation.
Here's the "boring stuff":

We want to clarify that Docker has no objection to you using “Docker” in your
repo name. However, because of trademark legal requirements, we ask that it is
not the first part of the name. For example, please do not use “Docker-xyz”,
but Docker has no objection to “xyz-Docker” or “xyz for Docker”. Your repo can
have Docker in the name, but the naming convention needs to be clear to avoid
confusion.

We appreciate the community’s concerns and we believe this policy strikes a
fair balance between the needs of the open-source community and brand
protection for Docker. It gives the community the ability to indicate
compatibility or utility with Docker, while also allowing Docker to meet legal
obligations relating to brand use.

Again, I appreciate you reaching out for more information; I'll close this issue here, because it's not really a bug / issue in this repository, but feel free to reply after I closed.
Also, if you're unsure if one of your projects / websites / repositories is not in compliance with the trademark guidelines, and you don't want to contact "legal" directly, feel free to send me a direct message on IRC (my handle is thaJeztah), or send me an e-mail (sebastiaan@docker.com), then I'll try to get in touch with the team to help out.

@thaJeztah

Hey, we noticed that ..., could you change this or that"

I want to refer to "the kik-case" which occurred a few months ago - which is at least related to this issue.
Long story short, my concern is simply about breaking the infrastructure, if you change the name of a repo it might cause really big trouble and lots of wasted work hours. And I strongly assume the community would not like that at all.
The fact is there are 10.000s repos out there named "docker-blablabla".
It's like not having "legal security" as a developer or user about the resources you use, if this might change anytime in the future. (For sure they can change also for other reasons, but the point is about the trademark). It's the same, when there is no absolutely clear policy about repo-names from Docker.
My opinion is, that it's simply too late for Docker to enforce this - for how long does this policy exist?
A viable solution would be, that you don't ask the developer to change the name, but to add a line stating "This repository is a community contribution for the Docker® ecosystem...." - something that sounds nice.

@schmunk42 I'll pass on your concerns, and will let you know if there's an additional response (sorry if I can't provide more information at this moment, hope you understand)

What's about saying, that only a repo like "docker/compose" is starting starting with "docker" and "mycompany/docker-cooltool" is not 😺

I needed an excuse to finally be one of the cool people and play with GH BigData Query. Thank you. :)
Interestingly, the search that shows any use of Docker from the GH search bar can be narrowed considerably in a few ways; one of which is to be more specific in where the use of "docker" lands in the repo name.  Take this GH Big Data Query:
SELECT repo_name,
              REGEXP_EXTRACT(repo_name, '.*/(.*)$') AS afterslash
FROM [bigquery-public-data:github_repos.languages]
WHERE
              Length(REGEXP_EXTRACT(repo_name, '.*/(.*)$')) > 6 AND Left(REGEXP_EXTRACT(repo_name, '.*/(.*)$'), 6) = 'docker'

I want all repos that start with docker after the "slash", but aren't only "docker" as it appears that 40,000 of the 100k repos are called simply "docker" of language "Shell", which after inspection of a small sample, "docker" is most commonly used as a repository for the Dockerfiles of a project!  There are also 600+ repos simply named "dockerfile" or "dockerfiles" which you can expect you know what's in there. When you remove all those, you are left with about 15k repositories that are prefixed with docker-.
Interestingly a large number of them appear to be clones with changes of base DockerHub images (docker-mysql, docker-wordpress, etc.); as people have taken these and configured them with special settings, versions, etc; and then assuming they are building those and publishing to a private or public registry as their variant of a base image.  In the end, it seems like there is still potentially clarification for some uses, but it does not seem as large as one would suggest from a broad search of the word docker in any repo on GH.

Here is a source for this practice:
https://www.andreas-jung.com/contents/dont-use-docker-in-github-repo-names-or-as-twitter-handle
Could you imagine what happened if the Python Foundation started sending out legal letters to e.g. someone providing a python-irc module for internet relay chat use?
This practice is super silly and should be stopped. If you are really so super-worried about a few 100% open-source projects using "docker" in the name in a purely descriptive manner, write up proper guidelines and stop sending legal letters to everyone as if you had Oracle aspirations.
@thaJeztah also I suggest reopening this issue until this has been properly addressed by docker with an official response about this practice. Given the article above, we at least deserve a proper public statement on whether this has actually been going on, and how this is going to be addressed in the future.


Extract Top 3 Things, PROMs and Feeds to a separate repository under https://github.com/pulsetile-plugins account

eg : Top 3 Things, PROMs and Feeds to a separate repository under https://github.com/pulsetile-plugins account

need to follow the pattern in the Angular repo
Core repo has small number of modules
Silver plugins has many more modules ( stable ones)
Bronze plugins are new/under dev etc