[BUG]  with Material UI doesn't show loading spinner

Describe the bug
<Show isLoading={true}> with Material UI doesn't show loading spinner
Steps To Reproduce

Create  view with isLoading prop set to true
Observe no spinner shown

Expected behavior
Spinner on isLoading=true
Packages
"@refinedev/cli": "2.16.24",
"@refinedev/core": "4.47.1",
"@refinedev/kbar": "1.3.6",
"@refinedev/mui": "5.14.4",
"@refinedev/react-hook-form": "4.8.14",
"@refinedev/react-router-v6": "4.5.5",
"@refinedev/simple-rest": "5.0.2",
Additional Context
No response

Hello, I tried to recreate this bug. It is working as you said, there is no loading spinner. However, I think that is the expected behavior. When loading, the component doesn't show a loading spinner, but disables the refresh button. I found that here in the documentation:
https://refine.dev/docs/ui-integrations/material-ui/components/basic-views/show/#isloading

Thanks for the explanation, @issa012. As mentioned you can use this prop to disable refresh button.

@BatuhanW @issa012
It's not looking pretty with default values displaying first and then jumping to the API data.
Also Mantine and Ant UI integrations have loading spinner for such scenarios, that's why I though it could be the bug.
So there's no plan to add spinner?

I can try, if you assign this to me.

Sure, assigned to you. 🚀

@BatuhanW Was the feature merged?

/attempt #5668

Hey @rners01 @BatuhanW
I would love to try on this issue , can you please assign me ?

@0xJaskeerat assiged issue to you.

I noticed this issue has been stale for a while. I can work on this, could you please assign it to me, @BatuhanW? Thanks!

I'll leave a comment here to help anyone interested to work on this issue about what we want from the implementation. 🙏
This fix needs to be implemented for <Create />, <Edit /> and <Show /> components. isLoading prop should be used to display a spinner overlaying the content.
To avoid any layout shifts, we're recommending using some absolute positioned box inside the <Card /> and positioning the <Card /> as relative.
We can pass sx.position = "relative" but also allow overriding this value like:
    <Card
      {...(wrapperProps ?? {})}
      sx={{
        position: "relative",
        ...wrapperProps?.sx,
      }}
    >

Then we can place a <CircularProgress /> wrapped with <Box /> inside the <Card /> like below:
      {isLoading && (
        <Box
          sx={{
            position: "absolute",
            inset: 0,
            display: "flex",
            justifyContent: "center",
            alignItems: "center",
            zIndex: (theme) => theme.zIndex.drawer + 1,
            // this is needed to support custom themes, dark mode etc.
            bgcolor: (theme) => alpha(theme.palette.background.paper, 0.4),
          }}
        >
          <CircularProgress />
        </Box>
      )}

I'm not sure if this covers all the necessary cases but I guess it will be a good starting point for the implementation.
We'll be happy to help if anyone is interested working on this issue. 🚀

@aliemir is this issue fixed?

Hey @Anonymous961, your screenshot is from Ant Design. This issue is related with our Material UI CRUD components and its still looking for contributors 🙏

Hello
Is this issue still open
I want to contribute to this


actions version update for the TransformMessages workflow

Why are these changes needed?
its using the previous version of the actions.
Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.51%. Comparing base (11d9336) to head (1bb790a).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2759      +/-   ##
==========================================
+ Coverage   33.60%   37.51%   +3.91%
==========================================
  Files          87       87
  Lines        9336     9340       +4
  Branches     1987     2139     +152
==========================================
+ Hits         3137     3504     +367
+ Misses       5933     5558     -375
- Partials      266      278      +12

Flag
Coverage Δ

unittests
37.47% <ø> (+3.87%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Invalid duration specification for ss:30 (ffmpeg)

Hi
I got this error when using Load(30):
Invalid duration specification for ss: 30,00
Resolved by adding CultureInfo:
public void Load(double offsetSeconds)
{
CultureInfo enUS = new CultureInfo("en-US");
// we will be reading video in RGB24 format
DataStream = FFmpegWrapper.OpenOutput(ffmpeg, $"{(offsetSeconds <= 0 ? "" : $"-ss {offsetSeconds.ToString(enUS):0.00}")} -i "{Filename}"" +
$" -pix_fmt rgb24 -f rawvideo -");
OpenedForReading = true;
}

Thanks for noticing. It seems I forgot to make it culture invariant. I have now fixed it and expect a new release soon

I have now released v1.0.9 that should include this fix. Please check it out.


Icon for C++ header files

It seems there are no icons for C++ header files.

Hi @MarconatoB,
What do you mean by 'header files' Because we do have a C++ icon.

Ah oke! I'll add the icon to the .hpp files. Thank you for reporting!


Starter or example

Do you have a starter or example to see how to implement this?

Right now you can check my website for an implementation. As I test this more there and on a closed source app I'm using it I will create a basic starter/Remix stack to initialize a new app.


update vendor paths so that the code navigationd works properly with guru

using Atom and go-plus with guru for navigation is confused with the vendor/src folder and can't find the packages.
Signed-off-by: Krasi Georgiev<EMAIL_ADDRESS>

@krasi-georgiev Make sure that Atoms/go-plus have GOPATH setup correctly. I would actually consider this a bug in the editor over the build system of a particular project. Containerd 0.2 branch isn't a common setup, but you should just be able to prepend the vendor dir to GOPATH for this to work.

thanks for the suggestion
fixed by adding
/src/github.com/docker/containerd/vendor
in the GOPATH in
~/.bash_profile
(needs to be there so that Atom pics up the env)


[popup] Hide "What's new banner" in incognito mode

Is your feature request related to a problem? Please describe.
Since the new button LoginAs incognito has been deployed, many of us will see the banner even if they already checked the new release (localStorage empty in incognito mode)
Describe the solution you'd like
This banner should be hidden in incognito mode

Will be released in 1.25


Plumb vk timeline semaphore and optional/required layers through API.

Verbose, but such is Vulkan.

Approved with the assumption that'll we'll be yanking out the flag once all supported configurations are properly able to use timeline semaphores.

Yep, that's the plan! The other code surrounding the flag will still be useful, but the flag and option in the API will go away.


Refactor generator

WHY
WHAT
REF

Codecov Report

Merging #32 into master will decrease coverage by 0.05%.
The diff coverage is 7.85%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   21.93%   21.88%   -0.06%
==========================================
  Files          33       35       +2
  Lines        1044     1042       -2
==========================================
- Hits          229      228       -1
  Misses        799      799
+ Partials       16       15       -1

Impacted Files
Coverage Δ

pkg/grapicmd/cmd/destroy.go
0% <0%> (ø)
:arrow_up:

pkg/grapicmd/internal/module/generator/project.go
0% <0%> (ø)

...cmd/internal/usecase/initialize_project_usecase.go
0% <0%> (ø)
:arrow_up:

pkg/grapicmd/internal/module/generator/command.go
0% <0%> (ø)

pkg/grapicmd/cmd/generate.go
0% <0%> (ø)
:arrow_up:

pkg/grapicmd/cmd/init.go
0% <0%> (ø)
:arrow_up:

pkg/grapicmd/cmd/cmd.go
0% <0%> (ø)
:arrow_up:

...kg/grapicmd/internal/module/generator/generator.go
0% <0%> (ø)
:arrow_up:

pkg/grapicmd/internal/module/generator/service.go
74.46% <50%> (ø)

pkg/grapicmd/internal/module/generator/base.go
6.25% <6.25%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c2d3dc...170a786. Read the comment docs.


Fix typo sdo:historyNote to skos:historyNote

Rejecting due to most of the changes being incorporated in v4.6. Docco note in combine.py to come in next release


xfreerdp rendering issues with rail plugin

Hey,
I'm facing with rendering issues on xfreerdp (1.2.0-beta1) when using rail plugin. I'm using Fedora 21 and connecting to Windows Server 2008 SP2 if applicable. It seems to be working correctly on Fedora 20 with xfreerdp 1.0.2.
There is also screencast showing what is wrong:
http://webmshare.com/play/1Lyma
There are black "border" when I move/resize window. For example it isn't possible to click on close button where I see it if there are black "borders", but I have to click on right top corder where it should be. Also there are problems with "subwindows". You can see it in the screencast, changes I made in Font dialog are applied, but not visible...
Can I provide some debug output or help somehow with solving this issue?
Regards
Ondrej

Another bugs in the last GIT- version. Awakecoding, please tell us a little information about the work on this problem ...
╚⋗ $ ~/build/FreeRDP/client/X11/xfreerdp -version
This is FreeRDP version 1.2.0-dev (git df79781)

Seems fixed on current master,
reopen if still reproducible.


chore: move authentication before branch creation in cloud-e2e script

Description of changes
Currently when running yarn cloud-e2e it creates a branch in this repo before authenticating. If authentication fails, the branch is left behind. This PR switches the order of these two steps.

Description of how you validated changes
Ran yarn cloud-e2e
Checklist

[x] PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #13045 (0f79d40) into dev (ec9a2ba) will increase coverage by 48.45%.
Report is 283 commits behind head on dev.
The diff coverage is 59.37%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##              dev   #13045       +/-   ##
===========================================
+ Coverage    0.00%   48.45%   +48.45%
===========================================
  Files        1296      842      -454
  Lines      149743    38038   -111705
  Branches     1296     7789     +6493
===========================================
+ Hits            0    18432    +18432
+ Misses     148447    18016   -130431
- Partials     1296     1590      +294

Files Changed
Coverage Δ

...rmation/auth-stack-builder/auth-stack-transform.ts
91.30% <0.00%> (+91.30%)
:arrow_up:

...tack-builder/auth-user-pool-group-stack-builder.ts
51.72% <ø> (+51.72%)
:arrow_up:

...h-stack-builder/user-pool-group-stack-transform.ts
94.59% <0.00%> (+94.59%)
:arrow_up:

.../src/provider-utils/awscloudformation/constants.ts
100.00% <ø> (+100.00%)
:arrow_up:

...e-walkthrough-types/awsCognito-user-input-types.ts
100.00% <ø> (+100.00%)
:arrow_up:

...vice-walkthrough-types/cognito-user-input-types.ts
100.00% <ø> (+100.00%)
:arrow_up:

...y-category-function/src/commands/function/build.ts
0.00% <0.00%> (ø)

...ify-category-function/src/events/prePushHandler.ts
33.33% <0.00%> (+33.33%)
:arrow_up:

...ider-utils/awscloudformation/utils/layerHelpers.ts
21.80% <0.00%> (+21.80%)
:arrow_up:

...er-utils/awscloudformation/utils/storeResources.ts
30.38% <ø> (+30.38%)
:arrow_up:

... and 58 more

... and 1243 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Exec add

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how you did it
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #5 into master will increase coverage by <.01%.
The diff coverage is 44.61%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   39.33%   39.33%   +<.01%
==========================================
  Files         183      183
  Lines       14380    14415      +35
==========================================
+ Hits         5656     5670      +14
- Misses       7848     7862      +14
- Partials      876      883       +7

Impacted Files
Coverage Δ

daemon/daemon.go
56.25% <0%> (ø)
:arrow_up:

daemon/mgr/network.go
67.99% <100%> (-0.34%)
:arrow_down:

apis/server/exec_bridge.go
70% <100%> (+0.76%)
:arrow_up:

apis/server/container_bridge.go
82.89% <14.28%> (-1.79%)
:arrow_down:

daemon/mgr/container.go
50.46% <14.28%> (-0.36%)
:arrow_down:

apis/server/server.go
48.75% <53.57%> (+1.38%)
:arrow_up:

pkg/user/user.go
60% <72.72%> (+1.11%)
:arrow_up:

ctrd/container.go
50% <0%> (+0.7%)
:arrow_up:


finer title

It is better to change "JavaScript sample" title to "TypeScript..." or change the sample code to JavaScript

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6e6cb0ed-c129-901c-10a2-909354aa562f
Version Independent ID: ceb10d41-b306-0d3f-ccb2-124a3ba69332
Content: Add a custom control to the work item form
Content Source: docs/extend/develop/custom-control.md
Product: devops
GitHub Login: @elbatk
Microsoft Alias: elbatk

You are right, fixing this now and it should be live within a day or so. Thank you!


[Event Request] Page 475 VAT Statement Preview Line - OnBeforeOpenPageAccountTotaling

Please add a new publisher event to the function ColumnValue - OnDrillDown as follows:
trigger OnDrillDown()
.
.
                                begin
                                    GLEntry.SetFilter("G/L Account No.", "Account Totaling");
                                    CopyFilter("Date Filter", GLEntry."Posting Date");

                                    //>> Start New Publisher Call
                                    OnBeforeOpenPageAccountTotaling(VATEntry, GLEntry, Rec);
                                    //<< End New Publisher Call

                                    PAGE.Run(PAGE::"General Ledger Entries", GLEntry);
                                end;
                            Type::"VAT Entry Totaling":
.
.

New Publisher Event:
[IntegrationEvent(true, false)]
local procedure OnBeforeOpenPageAccountTotaling(var VATEntry: Record "VAT Entry"; var GLEntry: Record "G/L Entry"; var VATStatementLine: Record "VAT Statement Line")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Timesheet - 25/04/2021 - Vyz

Task 1
Research and document optimal way that we can have tech docs about all of our libraries and SDKs (JavaScript libs, Python packages, Kotlin SDK, etc...). Plan of action. Re: thenewboston-developers/Management#151
Proof of Work
Finished full draft:
https://docs.google.com/document/d/1Y9d6FQb3jvcshPXWwvBD8Y_y1v2_iYnBZRUSR4-Plnw/edit
Time Spent
7.5 hours

Total Time Spent
7.5 hours
Account Number
0d8a4c42ece012b528dda5f469a4706d24459e2eee5a867ff5394cf869466bbe

Approved


Link to build from CLI output

awilkes@MacBook-Pro-2 cli % python3 -m launchable record build --name foo03172
Launchable recorded 2 commits from repository /Users/awilkes/code/launchable/cli
Launchable recorded build foo03172 to workspace launchableinc/awilkes with commits from 1 repository:

| Name   | Path   | HEAD Commit                              |
|--------|--------|------------------------------------------|
| .      | .      | 6ce5dd86412c9c3010803cedeaad21b248143708 |

Visit https://app.launchableinc.com/organizations/launchableinc/workspaces/awilkes/data/builds/1647218 to view this build and its test sessions

I was surprised that this requires another round-trip. It feels like an oversight in the API design that the act of creating a build doesn't return the ID.

Oh, yes, I forgot about that! Good catch.

Thanks @Konboi!


New constant occurrence of 'Invalid username password combination'

Describe the bug
I've been using voyz/ibeam for some time now. Suddenly as of this morning, it reports an invalid username password combination. I can login to IB directly with exactly the credentials provided (copy + paste) but voyz/ibeam will say this at all times now. It had been working flawlessly every day for months.
Although I did notice when I logged in via the web UI @ IB that the URL looked a little different the first time around.
To Reproduce
Steps to reproduce the behavior:

Go to 'command prompt'
Enter 'docker run --env IBEAM_ACCOUNT=user --env IBEAM_PASSWORD=pass -p 5000:5000 voyz/ibeam'
See error

Expected behavior
Typically the authentication is successful and 2FA is triggered.
Environment
IBeam version: 0.4.3
Docker image or standalone: docker
Python version (standalone users only):
OS: Windows 10 Home

Hi, I tried it two days back and it works. I did come across your issue as well but on 16th Sep. (Friday), it was working again. It could be an issue from IBKR's end. I will try again on Monday and update.

Hey @zeeb0tt thanks for outlining your issue in detail 👍
Unfortunately, this is a problem that we're aware of and it seems to be on the side of IBKR - you can see similar problems appearing in other issues in this repository. Hence, I'd encourage you to report it to IBKR support and try to solve it with them. There hasn't been any updates to IBeam around the time you're reporting.
Thanks for chipping in @stanj98 👍

Hi, I have the same problem. Regardless of the configuration, it shows me the same "Invalid username password combination" message. The only difference I see in my authentication is that now it asks me to confirm my login from the IBKR app with a floating notification on my mobile. When I run the gateway directly it works for me without any problem, I put in my credentials, I get the mobile notification, I approve it and I access it correctly. For this reason, I think the problem is the notification that reaches the mobile, I don't know if this is contemplated in ibeam. Greetings.

Also experiencing this problemo -- has anyone resolved this by contacting IBKR? They seemed to be unhelpful, but maybe I'm not "saying the right thing" or "asking the right question?"
Appreciate all the work on this, thank you!

People saying it is at IBKR's end. I am new and uncertain but just want to tell you that the same user/Pwd works well without any issue if I try on the TWS terminal. Also, not all CSS/Javascript files are loading. Image attached.

hey @ckcollab I'm sorry, but this has been an ongoing issue since I've started working on IBeam, and it happens with different severity for some users, while not at all for others. I'd love to help more, but IBeam only serves as a thin layer on top of the Gateway. Unless we can show that the credentials are scrambled somehow when they're input - all we do is copy paste them into two fields -, there's little we can do other than trying to address this with IBKR

@kadnan that same username/password should work again on your IBeam instance on some other attempt. TWS is a separate trading platform altogether, so there it could work when it fails using the Gateway.
Also I've been seeing the issue with the page not loading. IBeam only just loads whatever the Gateway will serve it, if there's some Javascript/HTML/rendering issues then that's again on IBKR side. I'd suggest you highlight this issue with them. I've found this loading issue appear when the connection is particularly slow.

@Voyz it's okay! Ty for all the hard work
Things are working ok now, in my case I believe I was IP banned from too many attempts at one point, changing my IP resolved the issue!

That's very interesting @ckcollab! What makes you think so? This would be very useful for other users to know!

When I would go to the IB docs pages they would say "Access Denied" until I turned on my VPN/changed IP :)

@ckcollab you're right! Using a VPN does help! I changed my VPN to UK.

Glad to help! @Voyz

Hi,
I am using the IBeam for some time now without any issue. But since a few weeks, I am getting the ######## ATTENTION! ######## Maximum number of failed authentication attempts (IBEAM_MAX_FAILED_AUTH=5) reached. error. Then I have updated the docker image to voyz/ibeam:0.4.5. Then it started working as expected. But, after a few days, I got the same error. When I login manually using https://localhost:5000/sso/Login?forwardTo=22&RL=1&ip2loc=on it works. Also, when I restart the IBeam, it works again as expected. But after a few days I am getting the same error again.
Here is the most recent logs that I got:
2023-06-17 03:41:11,980|I| Authentication process succeeded
2023-06-17 03:41:15,804|E| Gateway session active but not authenticated
2023-06-17 03:41:15,804|I| Logging out and restarting the Gateway
2023-06-17 03:41:15,939|I| Gateway logout successful
2023-06-17 03:41:16,076|I| Gateway session found but not authenticated, authenticating...
2023-06-17 03:41:16,076|I| Loading auth webpage at https://localhost:5000/sso/Login?forwardTo=22&RL=1&ip2loc=on
2023-06-17 03:41:23,900|I| Gateway auth webpage loaded
2023-06-17 03:41:23,900|I| Login attempt number 1
2023-06-17 03:41:29,278|I| Submitting the form
2023-06-17 03:41:30,486|I| Webpage displayed "Client login succeeds"
2023-06-17 03:41:32,487|I| Cleaning up the resources. Display: <pyvirtualdisplay.display.Display object at 0x7f469236bed0> | Driver: <selenium.webdriver.chrome.webdriver.WebDriver (session="a6608ce90ac7d05b2ff1cb4a617773c8")>
2023-06-17 03:41:32,556|I| Authentication process succeeded
2023-06-17 03:41:35,693|E| Gateway session active but not authenticated
2023-06-17 03:41:35,693|I| Logging out and restarting the Gateway
2023-06-17 03:41:35,827|I| Gateway logout successful
2023-06-17 03:41:35,961|I| Gateway session found but not authenticated, authenticating...
2023-06-17 03:41:35,962|I| Loading auth webpage at https://localhost:5000/sso/Login?forwardTo=22&RL=1&ip2loc=on
2023-06-17 03:41:43,832|I| Gateway auth webpage loaded
2023-06-17 03:41:43,832|I| Login attempt number 1
2023-06-17 03:41:49,233|I| Submitting the form
2023-06-17 03:41:50,441|E| Error displayed by the login webpage: Invalid username password combination
2023-06-17 03:41:51,485|I| Login attempt number 2
Execution of job "GatewayClient._maintenance (trigger: interval[0:01:00], next run at: 2023-06-17 03:41:52 UTC)" skipped: maximum number of running instances reached (1)
2023-06-17 03:41:56,878|I| Submitting the form
2023-06-17 03:41:57,261|E| Error displayed by the login webpage: Invalid username password combination
2023-06-17 03:41:58,306|I| Login attempt number 3
2023-06-17 03:42:03,717|I| Submitting the form
2023-06-17 03:42:04,093|E| Error displayed by the login webpage: Invalid username password combination
2023-06-17 03:42:05,125|I| Login attempt number 4
2023-06-17 03:42:10,485|I| Submitting the form
2023-06-17 03:42:10,911|E| Error displayed by the login webpage: Invalid username password combination
2023-06-17 03:42:11,973|I| Login attempt number 5
2023-06-17 03:42:17,349|I| Submitting the form
2023-06-17 03:42:17,679|E| Error displayed by the login webpage: Invalid username password combination
2023-06-17 03:42:17,720|C| ######## ATTENTION! ######## Maximum number of failed authentication attempts (IBEAM_MAX_FAILED_AUTH=5) reached. IBeam will shut down to prevent an account lock-out. It is recommended you attempt to authenticate manually in order to reset the counter. Read the execution logs and report issues at https://github.com/Voyz/ibeam/issues
2023-06-17 03:42:17,720|I| Cleaning up the resources. Display: <pyvirtualdisplay.display.Display object at 0x7f469239c5d0> | Driver: <selenium.webdriver.chrome.webdriver.WebDriver (session="c486d9a4f9c532bda08ceebb9e7c3199")>
2023-06-17 03:42:17,797|I| Authentication process failed
2023-06-17 03:42:17,797|W| Shutting IBeam down due to critical error.

I also believe this is an issue with the IBKR side.
But, from what I think, if there is a way to automatically restart the docker container after a pre-defined time (say after a few hours), we can bypass this issue.
Or please let me know if there is another way to fix this.
Thank you.

Hey @Wenuka - thanks for sharing your observations 👍 Honestly though, I really couldn't comment much on this. The errors seem quite sporadic, and there's little to draw conclusions from.
Now as for your points:

Restarting Docker can be done - you need to take care of it in your configuration, that is something outside of IBeam itself.
The increase interval of 1-5-30-60min is not a bad idea, although it is speculative as to whether it will actually help. I currently don't have the resources to implement it, but feel free to submit a PR if you'd give it a shot.

I honestly wish I had some other ideas on how to handle these issues, but there isn't any indication that could help us tackle it. The best thing we can do is to let IBKR know of these problems, so make sure you highlight it with their support.

Hey guys, just wanted to share that I've noticed this error happening if the process of logging in happens too fast. I used a selenium script to auto authenticate with the Gateway (a side project, other than IBeam), and if it just fills the creds out and instantly submits, the 'Invalid username password combination' occurs. Something to think about. We already have a 5-second buffer there, but possibly there's something else we could do here:
            ...
            user_name_el.send_keys(account)

            if key is None:
                password_el.send_keys(password)
            else:
                password_el.send_keys(Fernet(key).decrypt(password.encode('utf-8')).decode("utf-8"))

            password_el.send_keys(Keys.TAB)

            # small buffer to prevent race-condition on client side
            time.sleep(5)
            # submit the form
            _LOGGER.info('Submitting the form')
            submit_form_el = driver.find_element(By.CSS_SELECTOR, elements['SUBMIT_EL'])
            submit_form_el.click()
            ...

I tried seeing if it would run some request upon typing the creds, but it doesn't seem to. I wonder if it runs some JavaScript code when you do that, and maybe it doesn't finish by the time we submit.
I decided to add a functionality where we'd increase that buffer timeout on subsequent occurances of this error. There's two new env vars that define the starting and maximum waiting time: IBEAM_MIN_PRESUBMIT_BUFFER and IBEAM_MAX_PRESUBMIT_BUFFER. I've pushed voyz/ibeam:0.4.6-rc5 with this addition.

Hey @Wenuka - thanks for sharing your observations 👍 Honestly though, I really couldn't comment much on this. The errors seem quite sporadic, and there's little to draw conclusions from.
Now as for your points:

Restarting Docker can be done - you need to take care of it in your configuration, that is something outside of IBeam itself.
The increase interval of 1-5-30-60min is not a bad idea, although it is speculative as to whether it will actually help. I currently don't have the resources to implement it, but feel free to submit a PR if you'd give it a shot.

I honestly wish I had some other ideas on how to handle these issues, but there isn't any indication that could help us tackle it. The best thing we can do is to let IBKR know of these problems, so make sure you highlight it with their support.

Thanks @Voyz for your quick response and I agree.
Just now I managed to add the second suggestion (waiting  increase interval of 1-5-30-60min).
Incase some one else is interested, all what I did was to add the following in the ibeam/src/authenticate.py in the line 407 (just above _FAILED_ATTEMPTS += 1),
                    wait_secs = 15 * 60 * (2**_FAILED_ATTEMPTS)
                    _LOGGER.info(f"waiting {wait_secs/60:.0f} minutes before retrying...")
                    time.sleep(wait_secs)

This waits 15-30-60-120 minutes as for me it is okay. But you can modify it as you want.
I will update you incase this solves the problem in a few weeks.

I'm going to close this issue due to inactivity. Thanks for your contribution and please feel free to request a reopen if you'd like to continue the discussion 👍


Remove the custom filtering

Just noticing here that if you pass the Omnifunc matches directly into asyncomplete#complete, you don't need any filtering. This is beneficial on omnifuncs like vim-javacomplete2 that provide a lot of additional information beyond word and abbr
I'd also be happy to convert this into an option that can be set - perhaps g:asyncomplete_omni_filtering_enabled?
Also, of course, feel free to shut this PR down if you don't want any of this :)

This is beneficial on omnifuncs like vim-javacomplete2 that provide a lot of additional information beyond word and abbr

I think so too.
Thanks !


 not rendered properly.

Expected result
<input type="checkbox">

Actual result
<input type="checkbox" checked="false"></input>

Note that this HTML code generates a checkbox that is checked, because the presence of the checked attribute.

Good catch, I'll get a fix in for this right away. Thanks!

Fixed and release in 2.1.0.
Thanks again!


Support for v2 and stream

https://platform.openai.com/docs/assistants/overview?context=with-streaming

I was going to implement this on my own apps UI I might be able to help here, new to development but let me know if there is anything specific I can help with

Your contributions are welcome.
However, if you are a beginner, the issue may be difficult.

Done


Column Reordering (colReorder) not working when calling the callback function in stateLoadCallback

I'm using colReorder Plugin with DT 1.10.13 and colReorder 1.3.2
When returning the current state like so
stateLoadCallback: function (settings) {
        var o;
        $.ajax( {
            url: 'some_url',
            async: false,
            dataType: 'json',
            success: function (json) {
                o = json;
            }
        } );
        return o;
    }

everything works just fine and the columns are reordered like saved in the state
But when using the new callback function in this way
$.ajax( {
            url: 'some_url',
            dataType: 'json',
            success: function (json) {
                callback( json );
            }
        } );

nearly everything works just fine except column re-ordering.
They are rendered like the initial state and are saved this way again back to the state.
E.g. instead ordering [0,2,1,3] they are ordered and saved [0,1,2,3]

Apologies if the template text for new issues isn't clear enough. Please ask support questions in the DataTables forums with a link to a test case showing the issue. Thanks!


register-sub middleware

You probably get asked for this a lot but would be cool if one could use the same or similar middleware for register-sub too, at least path and trim-v.
Often when dealing with page-specific stuff one writes stuff like
(def path [:page :login])
(def path-m (re-frame.core/path path))

(register-handler
  ::input-changed
  path-m
  (fn [db' [_ value]]
    (assoc db' :value value)))

(register-sub
  ::input
  (fn [db _]
    (reaction (get-in @db (conj path :value)))))

But it would be cool to be able to derive the db in register-sub too
(register-sub
  ::input
  path-m
  (fn [db' _]
    (reaction (:value @db'))))

@whodidthis  Thanks for the feedback.  I am actively working on this stuff for v0.3.0, hopefully in a week.  Design is still not quite settled in my mind.  Slightly different needs to handlers.

Also I was wondering if you had any magic beans for the actual dom elements for when you sadly have to call functions like focus and blur on them.
I thought about doing something like
(defn my-view []
  [:form {:on-submit #(dispatch [::submit])}
    [text-field {:ref ::input ...etc}]])

(defn text-field [{ref :ref}]
  ;save the dom element to state
  (dispatch [::element ref (.getDOMElement reagent.impl.component/*current-component*)])
  [:input ...]))

(register-handler
  ::element
  (fn [db [_ ref element]]
    (assoc db ref element)))

in order to be able to use the element when needed
(register-handler
  ::submit
  ; send to places

(register-handler
  ::response
  (fn [db [_ [success error]]]
    (if success
      (do (.blur (::input db)) ;etc

Is a bit of manual work so was wondering if there's anything better "out there"

Ouch.  There does seem to be some problems here.
First, we only ever want to be dispatching pure data (not DOM Elements)
Second, we want our components to be a function of app-db  ... but that text-field you have is actively dispatching  in order to "get itself" into a particular state.
Can you supply some more context?  I'm sensing that you have an event happen (form submit?) and, in response, you want a particular text field to get focus?

Yes, basically I want a visitor to type on a form field and submit it (request login token to email), and when the server responds OK, reveal and focus an other field (where token can be typed in).
Not that this wouldn't be a problem in any cljs react library heh

I'd suggest something like this:

have some piece of app-db to say what logical state the app is in:  user-entering, user-clicked-submitted, got-answer-is-back-from-server
Put the revealed input into its own component, and include it via this: (when   (= @logical-state  :got-answer-is-back-from-server)
        [extra-input-component]             ;;   it won't initially be there.

Add a life-cycle component-did-mount method to that extra-input-component and, in that lifecycle method, force focus on the input field, brute force.  (.focus (.getElementById js/document  "id-of-input-field") )    ;; very approximately

So, in effect, when the component is first created and put into the DOM, the input field will be given focus.  But then we never worry about it again.
Look here for hints on adding lifecycle methods:

Too bad react doesnt have a "get element x from within this component and its children" thingie so I guess I'll agree with the document.getElementById().
Although I do wonder if I should try to make a text field listen for a props value as a kind of a signal to focus on component-did-mount and component-will-update.
Something around
(defn text-field [{focus :focus}]
  (let [last-focus (atom focus)]
    (reagent/create-class
      {:component-will-update
       (fn [this {focus :focus}]
         (when (and focus (not= @last-focus focus))
           (reset! last-focus focus)
           (.focus (.getDOMElement this))))
       :reagent-render
       (fn [props]
         [:input ;etc

Also any chance of getting the original event as an argument to after middleware?
(register-handler
  :route/set
  (after (fn [{new-route :route} [_ route]
           (when-not (= new-route route)
             (route-set new-route))))
  (fn [db [_ route]]
    (let [roles (:roles db)
          required-roles (get permissions route)]
      (if (clojure.set/subset? required-roles roles)
        (assoc db :route route)
        (assoc db :error "no permissions"))))

Maybe a little bit using after for the sake of using it but anyways heh

Yeah, I see what you mean.  I'll make that change in  v0.3.0.  Will be backwards compatible because the 2nd parameter v will just be ignored by any existing code.
Remember, that middleware is very easy to write yourself.  Only 9 lines of code, 6 of them  boilerplate. You don't have to stick with what is supplied.

Interesting discussion.
Just curious about the comment here:
"Too bad react doesnt have a "get element x from within this component and its children" thingie so I guess I'll agree with the document.getElementById()."
Doesn't reagent/current-component return an object from which reagent/dom-node can produce the React DOM element?

Indeed, reagent does have reagent/dom-node.  But you'd then have to be putting the component-will-update on the input component itself.  The technique described above was for a different approach:  for when you are writing a component which contains the input which is to get focus.

Another way would be to get the current component that contains the input via reagent/dom-node and then invoke querySelector on that element, (.querySelector dom-element "input"), so you don't resort to using id's (which get defined automatically on the window object as global vars) ... Not trying to be clever, just trying to learn if that's a viable option. At any rate, I really don't like the fact that we have to target the DOM... feels so Un-Reactive to me... Does React have a way to set focus on an element in the actual DOM when the state tied to that element gets updated with say {:focus true} or something like that. In other words, can we set focus in reactive manner?

I think about it like this:  the moment you are trying to control something about the DOM and that thing can't be specified by elements and their attributes, then any React-based app will have to get the job done via a bit of imperative code in one of the the lifecycle methods.
So, because you can't control focus via an attribute value like this mythical example:
<input   hasfocus="true"  .... >
you have to get the job done via a bit of imperative intervention.

@mike-thompson-day8
How about the not-so-mythical autoFocus attribute?
React docs says that React supports the html5 autofocus attribute but as with all attributes they are camel cased ... so setting autoFocus to true should work, tho I haven't tried it ... yet.

autoFocus does work... Here is a demo in plain React
http://jsfiddle.net/fx6ug/2/

Good find.  That looks like it would solve @whodidthis' problem.  Just add a
   [:input {:auto-focus true}  ... ]

and that [:input ] will have focus on initially being added to the DOM.
Unfortunately, auto-focus only works when the control is first loaded into the DOM.  It doesn't handle the general focus problem - you can't control which input has focus and move it around. Pity.

The user normally controls which element should have focus with mouse, touch or keyboard (tab, if enabled) I am sure there are cases where you want to set focus, just can't think of any good UX context for that right now.
Could you reactively cause unmount to happen and then restore state from global state on mount to set focus via autoFocus,  or would that be bad?

Yeah dont actually randomly set focus in case it might be super annoying hehe.
Reason I was wondering about not depending on focus on component-did-mount is I have no idea how to do any kind of transition animation without having the element rendered but hidden away somewhere. At least with CSS. Dunno if there's some magical React.js animation thingies somewhere that enables you to do so.
Hit me up in-game if there is.

@whodidthis react-with-addons has some support for CSS Transitions. It allows you to animate mount/unmount although there are a bunch of gotchas around what has to already be mounted and such - it can't animate isolated components being mounted/unmounted, but works great for lists or for transitioning pages etc.
Too bad react doesnt have a "get element x from within this component and its children" thingie so I guess I'll agree with the document.getElementById().

Om has a concept of refs so you could do something like [:input {:ref "foo"} ...] and then (om/get-node owner "foo"). I wrote a simple utility version that gets the React node rather than the DOM node: (get-ref owner "foo"). For anyone not familiar with Om, owner is kinda like reagent/current-component.  Does reagent have something similar? Could something like it be added to re-frame if not?
I agree that, in general, one shouldn't do this and it can usually be avoided, but one place where I've used this in Om code (but haven't yet tried in reagent/re-frame, but probably will soon) is when wrapping javascript React components that provide an OO API (eg (.toggleMenu (get-ref owner "my-menu")))

Om/react's ref thingie only gets element from current component but not children. Reagent doesn't have refs https://github.com/reagent-project/reagent/issues/5. You need to create components like
(defn my-input []
  [:input...])

so you can access the dom element from (.getDOMNode this).
The reason refs from current component wouldn't cut it in any case is because i have a component like
(defn login-view []
  [dialog
   [:input {:ref ???

where dialog is a reusable dialog component refs wouldn't be able to touch anyways. Basically I'll go with my focus on prop plan if i need to do something with dom elements hehe.

https://facebook.github.io/react/docs/animation.html CSSTransitionGroup seems to use css classes which is too much effort for me since inline styles already exist. I guess I should be looking at ReactTransitionGroup and being able to do something like
[ReactTransitionGroup {:component "div"} ;no idea atm heh
  (case @route
    :front [front-page]

and mysteriously receiving more lifecycle kind of methods that im not sure how to use yet. Maybe I'll find out some interesting examples at some point

@whodidthis  Matt Greer shows how to use reagent and CSSTransitionGroup in his game
Would you mind closing this issue if you feel it is resolved.

@mike-thompson-day8  Is there an ETA on v0.3.0? I'm very eagerly awaiting the new subscription stuff and also the change mentioned above to after.

@danielytics  Sorry Dan I've been completely caught up in re-com for what seems like forever.  I stalled a bit on the re-frame subscription tweaks because I could never quite get a design I was happy with.  My approach when I'm stuck is to go do something else for a while, and then to circle back later,  which I'm now doing.
BUT I will  push the more modest 0.3 right now (its been sitting in the develop branch for a while).  And make the subscription tweaks the focus of 0.4.

Okay, I have pushed v0.3.0  but:

it is a very modest release
it won't be in clojars for a few hours yet

Brilliant, thanks! Yeah, I figured you just got busy - happens :)
So... with that in mind, any ideas when you might have 0.4 ;-) guess I'm eager to see what you have cooking for subscriptions.
Great job on re-frame btw, fantastic piece of work.


Feature/swap to googledocstringspt1

Starting swapping docstrings to google style

This can wait until we know it works with your documentation. I don't want to break that

This should be all of them at this point

lgtm


do not call isZshParentShell for every history line

The zsh change in https://github.com/dvorka/hstr/commit/5ab82058592b1875e8b653a621be698087abd85a made startup of hstr significantly slower than it was in v2.2, going from almost instantaneously listing recent history to a 1-2 seconds wait after hitting CTRL+R.  This is particularly noticeable with a large HISTFILESIZE.  The slowdown seems to be from the isZshParentShell call for every history line in parse_history_line.  https://github.com/dvorka/hstr/blob/5ab82058592b1875e8b653a621be698087abd85a/src/hstr_history.c#L102-L106
called from prioritized_history_create:
https://github.com/dvorka/hstr/blob/5ab82058592b1875e8b653a621be698087abd85a/src/hstr_history.c#L171-L182
This PR adds a isZsh bool input argument to parse_history_line to prevent repeated calls to the expensive isZshParentShell function.  It was only checked once in prioritized_history_create prior to https://github.com/dvorka/hstr/commit/5ab82058592b1875e8b653a621be698087abd85a as well (https://github.com/dvorka/hstr/commit/5ab82058592b1875e8b653a621be698087abd85a#diff-258da76bc59b38c71c18642eba6ab2c8d4d8e63636d069002ff59e3d7f7f1b2cL123-L124)

@chappjc thank you for great catch! :clap: @thibaultcha thanks for additional contribution! :+1:

@chappjc thank you for great catch! :clap: @thibaultcha thanks for additional contribution! :+1:


Bad JWS signature with Google (OpenID Connect)

Thread: http://stackoverflow.com/questions/30342783/intermittant-bad-jws-signature-w-t-google-apps-open-id-authentication
The idea is to upgrade the nimbus SDK version when it will be available.

Version 4 is released: http://search.maven.org/#artifactdetails|com.nimbusds|nimbus-jose-jwt|4.0|jar

After a discussion with Vladimir (the developer of the Nimbus libraries), his recommendation is to target the oauth-oidc-sdk v5.0 (alpha right now) and the associated nimbus-jose-jwt (v4.0), which fixes our bug.

PR: https://github.com/pac4j/pac4j/pull/266

@miremond : expected your feedback as our "OpenID Connect" specialist...


Create new File "Ipsum.txt"

#Ipsum text

bullet1
bullet2

Ok, looks good

I am going to merge this one


Issue#333 [Bug] Should select All when select all options

Summary
...
Before
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
After
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
Note
Null

Tips:
You can add close #333 this merge message to close the related issue automatically


EARestrictedScrollView class missing in source

#import <EARestrictedScrollView/EARestrictedScrollView.h>

EARestrictedScrollView moved to separate repository and linked as a dependency. For manual installation get it here: https://github.com/ealeksandrov/EARestrictedScrollView


make.edges.equalTo(parent.snp.edges) regression

New Issue Checklist

[x] I have looked at the Documentation
[x] I have read the F.A.Q.

Issue Info

Info
Value

Platform
osx

Platform Version
10.11.6

SnapKit Version
3.0.0

Integration Method
carthage

Issue Description
Assume we have a view A, and X is the superview.
This works: make.edges.equalTo(X)
This does not, but previously did: make.edges.equalTo(X.snp.edges) and causes the view to shrink. Inspecting the constraints in the debugger, it looks like they're being set erroneously such that A.left, A.top, A.right, A.bottom are all set == X.left.

@davidvartan are you sure you are running the 3.0.0 branch? This was a previous bug that I'm pretty sure I had fixed and there is even a passing test related to it.

Wow, that was quick! Thanks. I do see the testEdgesToEdges in my code, but it looks like it's not for OS X where I am.

@davidvartan oof yea this fix may have gapped macOS

@davidvartan should be fixed now in 3.0.1 release!


adjust tests for warnings

adjust tests for warnings

FutureWarnings for deprecated stuff - #69

see example here

matplotlib warnings

see example here

numpy warnings

see example here

resolved via #83


ValueError: Could not find matching function to call loaded from the SavedModel

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No, it's an example code
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): from binary, using pip install tensorflow-gpu==2.2.0-rc0
TensorFlow version (use command below): 2.2.0
Python version: 3.7
Bazel version (if compiling from source): -
GCC/Compiler version (if compiling from source): -
CUDA/cuDNN version: 9.1
GPU model and memory: Nvidia 1050Ti

(Full tensorflow version: v2.2.0-rc1-34-ge6e5d6df2a 2.2.0-rc2)
Describe the current behavior
Following the example code described here:
@tf.function
def f(x, training):
  return x if training else 2.
f(-1., training=True)
f(-1., training=False)
obj = tf.train.Checkpoint(f=f)  # save() exports objects, so we wrap f
tf.saved_model.save(obj, "/tmp/f")

Describe the expected behavior
After loading the model again, when calling the exported function:
imported = tf.saved_model.load("/tmp/f")
imported.f(10., training=True)  # 10 -> expected value.

10 should be the output
Actual behavior
It yields an error:
ValueError: Could not find matching function to call loaded from the SavedModel. Got:
  Positional arguments (2 total):
    * 10
    * True
  Keyword arguments: {}

Expected these arguments to match one of the following 2 option(s):

Option 1:
  Positional arguments (2 total):
    * -1.0
    * False
  Keyword arguments: {}

Option 2:
  Positional arguments (2 total):
    * -1.0
    * True
  Keyword arguments: {}

Standalone code to reproduce the issue
Example code given.
Other info / logs
It works if I put a value used before in the function, before saving the model:
# Code
imported.f(-1., training=False) # I HAVE called the function with these exact arguments before saving the model

# Result
<tf.Tensor: shape=(), dtype=float32, numpy=-1.0>

This could be the desired behavior of the library (to only work with previously evaluated inputs), however:

I don't see the point of using such tool if it's just a lookup table
Conflicts with the example given

Ok so apparently this is actually a feature, namely tracing.
Each time the function is called with a different type of input variables, it will be re-traced. In the aforementioned example code, in order for it to work properly, the function needs to be called (and effectively, traced) using a tf.Tensor(), instead of an integer:
@tf.function
def f(x, training):
  return x if training else 2.
f(tf.constant(-1), training=tf.constant(True))
obj = tf.train.Checkpoint(f=f)  # save() exports objects, so we wrap f
tf.saved_model.save(obj, "/tmp/f")
# ...
imported = tf.saved_model.load("/tmp/f")
imported.f(10, training=True)  # yields 10, the expected value

That's because tensorflow will create a concrete function for each different type of input called. However, immutable values such as integer's will trigger the tracing for every different input, and so it does act as a look up table on that case.
The doc's is very extensive and this went unnoticed by me. I hope this helps someone facing the same questions.


fix: analysis on event property is not in the expected data format

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
cherry pick #1350
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[ ] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests

[ ] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[ ] deploy ingestion server

[ ] with MSK sink
[ ] with KDS sink
[ ] with S3 sink

[ ] deploy data processing
[ ] deploy data modeling

[ ] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting
[ ] streaming ingestion

[ ] with Redshift Serverless
[ ] with provisioned Redshift

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @llmin on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.50
< 80

Duplicated lines density
:white_check_mark: OK
5.60
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
1
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 5/21/2024, 07:26:12 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication


Add support for resource requests

Example usage
RunEnvironment environment =
    environment(
        "us.gcr.io/foo/bar:5",
        secret("gcp-key", "/etc/gcloud"))
    .withRequest(CPU.of("200m"))
    .withRequest(MEMORY.of("256Mi"));

@rgruener removed the unused enums


kernel dependency satisfaction errors on most packages

kernel dependency satisfaction errors while installing most of the packages packages.

Please expand or map the overlay space

already did that, doesn't related. sources and main packages are not in the same tree I think.


Remember user selection about in-game language

Overview
Please, implement app-wide flag or player's profile setting that will store language that use has currently selected.
When application is started next time, remembered language should be used and entire interface should be in that language.
Narrative

As a player
I want my preference about language to be saved
So that I don't have to change game's language to preferred one each time

Acceptance Criteria
Save language

Given that I have started a game
And that I am in the options screen
When I change current in-game language
Then my preference is remembered

Load language

Given that I have started a game
When I pass the logo screen
Then I can see that the entire game is in language that I have set or used previously

That is already done, closing


Align iOS and Android methods

Ensures that iOS and Android are using the same method names. Also added
some missing methods to both sides and updated any methods using deprecated native methods.

Updated to remove unused methods from example app. Will be added to documentation instead.

Final change: updated to new Android SDK release and fixed some tests.


Ptrace support

It be really helpful if this library had support for sys/ptrace

I agree! I'm pretty swamped at the moment though, so it would have to be a contribution :) If you have a PR I would be happy to take it :heart:

I might have a PR in a day or two.  I have something written up that should work for Linux that I'm in the process of testing.


Bump maven-core to 3.6.3 and warn if affected by MNG-6173 (3.3.1-3.3.9)

Related to #324.
The bump does not prevent GIB from running on <3.6.3. It makes debugging in Maven 3.6.3 (the default these days) much easier.
GIB now logs a warning on Maven 3.3.1-3.3.9 regarding https://issues.apache.org/jira/browse/MNG-6173.

@mickroll In case you have time/motivation to have a look...
I know it's short notice, but I'd like to cut a release tomorrow. But no worries if you don't have time - it's weekend after all. 🙂


feat: zoomable charts

Description

Checklist

[ ] For UI or styling changes, I have added a screenshot or gif showing before & after
[x ] I have added a changeset
[ ] I have added to the docs where applicable
[ ] I have added to the VS Code extension where applicable

Can you add a gif (or an example in example-project) for this?

@AmdyTran / @archiewood what's the status on this?

I haven't been able to get this to work in local testing. This is a good feature idea, but I think we should close this for now and revisit to implement it across the charting library. I think there will be some challenges with spacing and print/PDF behaviour which we will need to decide how to handle.
@AmdyTran thanks for contributing this - we can reopen it in the future when it makes sense. Happy to chat about it as well, just let us know


Bug while commenting the code

Issue Type: Bug
Hey vs code team i am using vs code editor it is very powerful i am proud to use it but here is an issue where if its get fixed i will happy when we have big lines of code in which many are are already commented then it uncomment the previous one what should happen is all should get commented
VS Code version: Code 1.62.3 (ccbaa2d27e38e5afa3e5c21c1c7bef4657064247, 2021-11-17T08:11:14.551Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz (8 x 2419)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.77GB (6.45GB free)

Process Argv
. --crash-reporter-id 0e49e413-8ffc-438b-bad3-1e28baaae2cb

Screen Reader
no

VM
0%

Extensions (21)

Extension
Author (truncated)
Version

vscode-sqlite
ale
0.14.0

bracket-pair-colorizer
Coe
1.0.61

vscode-eslint
dba
2.2.2

javascript-ejs-support
Dig
1.3.1

es7-react-js-snippets
dsz
3.1.1

prettier-vscode
esb
9.0.0

auto-close-tag
for
0.5.13

auto-rename-tag
for
0.1.9

stylelint-plus
hex
0.56.6

unity-code-snippets
kle
1.3.0

csharp
ms-
1.23.17

python
ms-
2021.11.1422169775

vscode-pylance
ms-
2021.12.0

jupyter
ms-
2021.10.1101450599

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.4

vsliveshare
ms-
1.0.5090

vscode-react-native
msj
1.8.1

color-highlight
nau
2.5.0

live-sass
rit
3.0.0

LiveServer
rit
5.6.1

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30391933
pythonvspyt187:30373474
vsaa593:30376534
pythonvs932cf:30408637
vscop804:30404766
vs360cf:30404996
vsrem710cf:30405999
vscexrecpromp3c:30407761

/gifPlease
Please provide recording of a problem or at least language and code before and after.

OK let me write again while editing html code or any kind of code when we had to comment a lot of lines what we do we select that portion and press control forward / this way we comment the thing but what issue occur here if we some code which is already comment by us and lies with in the selected region then after pressing control forward slash will uncomment the comment and comment the code what i am requesting is that while writing code we dont want come code to be executed so what we do simple comment it but isssue occuur while commenting that if there is some line of code which is already commented is uncomment and become executable code..
Can you separate the comment part and make a term so that instead of saying this is comment we say we dont this code to be executed it seems same but it is not same at deeper level comment means why giving information of program so in future i get to know not wanting the code to be executed means i want the code to be here but want not to be executed the code is there for the refrence of copy paste

Not sure I know exactly what you are requesting, but are you asking to toggle existing comments so
aasdasd
// asdasd
asdasd

becomes
// adasd
asdasd
// asdsd

If so, there is an extension https://marketplace.visualstudio.com/items?itemName=ArturoDent.toggle-comments&ssr=false#overview that would do that.
Otherwise could you make a gif that shows what you want?

I think I know what you mean. But to be sure, the best would be if you added a concrete code example
Here is my sample:
<html>
    <head>
        <!-- comment-->
    </head>
</html>

select all inside the <html> body, press ctrl + '/'
the result is

<html>
    <!-- <head>
        <!-- comment-->
    </head> -->
</html>

which is not valid html, as you can't have --> in the comment
This is in fact the expected behavior. The comment command is purely textual and just adds or removes the languages comment tokens. It does not modify the content inside the comment. If it were to modify the content, it would need much more language knowledge, e.g. it could encode > with &gt. Or just remove the <!--  and -->. As there are many ways to do that, it is left to the user.
HTML is a bit special too as it doesn't have a single line comment like //. There things are much simpler.
We currently have no plans to provide a more sophisticated, language ware comment command.

@sarangkkl If this is not what you meant, please add a sample code with steps and I'm happy to reopen if you found a bug.


SentryHttpClient captures errored requests and set the 'request' field accordingly

The SentryHttpClient should add the last request to crash reports. This should work for all supported platform.
I feel like this should be an easy change because requests are already recorded as breadcrumbs.

@ueman do you mean the request field? https://develop.sentry.dev/sdk/event-payloads/request/
request is not part of the Scope, and after reading this:

The Request interface contains information on a HTTP request related to the event

so adding the last request to crash reports would cause false positives IMO and only the breadcrumb would be enough-right approach.
my suggestion would be, capturing events automatically out of the HTTP requests as we do for example with Spring.
for example:
try {
  final response = await _client.send(request);
  // add breadcrumb as we already do
  return response;
} catch (error) {
  // capture event with proper `request` field.
  rethrow;
}

is that what you meant?

Yep, that is what I meant 👍

Yep, that is what I meant 👍

nice, just changed the title a bit so it's easier to understand.

this should be an opt-in feature, some people prefer to capture themselves, maybe a ctor param on SentryHttpClient which tells us either to capture events or not, and if so, maybe we could also define when to capture eg >= error code 400 or >= error code 500 maybe or only if an exception has happened, maybe we check how the other SDKs do it, this really depends on how people do their APIs so it should not be enabled by default and some level of configuration would be nice

This is twofolds:

Requests which are aborted or did not finish. So requests which do not even get a response. For example when the user lost access to the internet while doing a request.
Requests which return a failure status code, like 500 or 400.

Also I think we should probably think about having multiple clients.
One for breadcrumbs, one for requests and one for reading the tracing headers.  For the user it could still be SentryHttpClient which then combines all of the clients.


PGUSER is invalid - postgres

Fresh install of PostgreSQL v9.4.4, all default settings. I get "The PostgreSQL Server instance is Unknown" with error PGUSER is invalid - postgres. The postgres user seems to be setup properly and the server is running fine. Any ideas?

Yes, I've just tested this, having also installed PostgreSQL from http://www.enterprisedb.com
The Postgre Prefs tool runs this command to check if the user exists:
id -u -n postgres

This works fine if I run it at the command line. But if I run this:
sudo id -u -n postgres

Then I get this error message:
"root" execution of the PostgreSQL server is not permitted.
The server must be started under an unprivileged user ID to prevent
possible system security compromise.  See the documentation for
more information on how to properly start the server.

Unfortunately, if you chose the option to install Postgre Prefs for all users, then it runs the above command with the sudo in front of it.
So the fix will require modifying the script so that it doesn't ever use sudo for this command. Easy enough to do in principle, but I'm just now in the middle of working on a new version of this tool, with lots of modified files. So to make the necessary change, I'm going to have to do a git-branch off the previously-released version - not something I've needed to do before, so could be tricky!
In the meantime, can you try uninstalling the tool (right-click on the icon, and click Remove), then reinstalling but choosing "for this user only". Does that fix it?

Thanks for the help. I just uninstalled using your instructions on the README. Then I installed using the "this user only" option. But I still have the same error message.

Yes, I checked the code. It doesn't explicitly put "sudo" in front of the command. But the script is always running as root, regardless of how the preference pane is installed. So I'll need to get it to switch user to a non-root user in order to run that id -u -n postgres command without generating that error message.
I'll try to work out the git branching stuff and do a patch release, once I've checked in the stuff I'm working on at the moment.

Please could you try the latest release, v1.4.1?
Download the latest release at: https://github.com/mckenfra/postgresql-mac-preferences/releases
Let me know if that's working now.

That worked! Thanks, it also works with v2.0. Great work!

Cool, I'll close the issue, thanks for raising it!
FYI - hopefully should have a v2.1 out soon. Main improvement is that it will show already-running PostgreSQL servers that weren't configured using the preferences. You will then be able to start/stop these other servers in the same way as the ones you manually added to the preferences.


Allow plugins access to the state of all MyST documents

I was trying to write a custom plugin that returned a list of blog pages in my site, similar to this issue:

#840

However I couldn't figure out (and think it may not be possible) to define a .mjs plugin that can access the information needed to do this.
It would be helpful to enable / document how MyST plugins can access the list of all parsed documents in a MyST build, along with their metadata and/or content.

The transforms are currently run per document in parallel, we don't have a hook to do transforms at the end, and thus don't have access to the full project.
In the MEP plugin, we are doing this by reading the YAML in the md frontmatter from the filesystem directly, which is something that would likely work today!


How to use segmentation with Pose solution on TFJS?

Please make sure that this is a feature request.
System information (Please provide as much relevant information as possible)

MediaPipe Solution (you are using): Pose
Programming language : typescript(JavaScript)
Are you willing to contribute it (Yes/No): Yes

Currently, the segmentation mask is not available in Pose solution on TFJS runtime.
Are there any plans for this to be available?
The Mediapipe runtime doesn't work on iOS, so I'd like to use it as an alternative now.
Thanks,

Hi @ats05, Could you please confirm the above query is about https://google.github.io/mediapipe/solutions/pose#enable_segmentation in Javascript MediaPipe pose solution. Please check and reach out for more information. Thanks!

Hi @sgowroji ,
Thank you for response.
Yes, I'm just asking to that config.

You can set  enableSegmentation: true,
as below in Javascript solution and can find the same in control options of codepen examples
pose.setOptions({   modelComplexity: 1,   smoothLandmarks: true,   enableSegmentation: true,   smoothSegmentation: true,   minDetectionConfidence: 0.5,   minTrackingConfidence: 0.5 });

@sgowroji ,
Thanks for information.
And sorry, I was asking about "BlazePose with TFJS".
https://github.com/tensorflow/tfjs-models/tree/master/pose-detection/src/blazepose_tfjs
Perhaps I shouldn't have asked in the MediaPipe repository.
Thanks!


Possible incorrect _MSC_VER reference

https://github.com/nlohmann/json/blob/e7b3b40b5a95bc74b9a7f662830a27c49ffc01b4/single_include/nlohmann/json.hpp#L17470
This condition seems to check "Visual Studio 2017 or later", so there should be >= 1914, not <=

This comparison was introduced in https://github.com/nlohmann/json/pull/1028 and last changed in https://github.com/nlohmann/json/pull/1496. In https://github.com/nlohmann/json/pull/1028#issuecomment-393975287, I think the reason is described why it should be <=:

So the bug preventing enabling this feature on msvc has been fixed: https://developercommunity.visualstudio.com/content/problem/243183/stdstring-should-not-have-a-operator-that-takes-a.html
It should be out in 15.8 (msvc 19.15?), so in 19.14 and older it is disabled, as discussed.

Maybe I'm wrong, but std::string_view is only available from C++17. For example, Visual Studio 2015 has _MSC_VER=1900, so this #if becomes true and I got an error on unknown string_view.

Good point. I'm not using MSVC myself, but I may be able to check via AppVeyor.

According to this the N4562 feature set with string_view has been added in VS 2017 15.0
According to this there was _MSC_VER=1910
Maybe the mentioned condition should be ... || (defined(_MSC_VER) and _MSC_VER >= 1910 and _MSC_VER <= 1914))

Doesn't the check for JSON_HAS_CPP_17 already deal with the beginning of the range?

Doesn't the check for JSON_HAS_CPP_17 already deal with the beginning of the range?

As I can see, the check for JSON_HAS_CPP_17  and _MSC_VER  is a parallel relationship(||),
so I agree with @ua-code-dragon  in https://github.com/nlohmann/json/issues/2112#issuecomment-629688889.

Thanks everyone for the discussion!


steampipe: 0.23.5 -> 0.24.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for steampipe is: Dynamically query your cloud, code, logs & more with SQL
meta.homepage for steampipe is: https://steampipe.io/
meta.changelog for steampipe is: https://github.com/turbot/steampipe/blob/v0.24.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.24.0 with grep in /nix/store/jj74qh7b8y9313ll7acmbwcw93k6c8fm-steampipe-0.24.0
found 0.24.0 in filename of file in /nix/store/jj74qh7b8y9313ll7acmbwcw93k6c8fm-steampipe-0.24.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

steampipe

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jj74qh7b8y9313ll7acmbwcw93k6c8fm-steampipe-0.24.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A steampipe https://github.com/r-ryantm/nixpkgs/archive/63b411b4b4a5e2a90c01041c8abf9ddaab94556c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/63b411b4b4a5e2a90c01041c8abf9ddaab94556c#steampipe

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jj74qh7b8y9313ll7acmbwcw93k6c8fm-steampipe-0.24.0
ls -la /nix/store/jj74qh7b8y9313ll7acmbwcw93k6c8fm-steampipe-0.24.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

steampipe

Maintainer pings
cc @hardselius @anthonyroussel for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 339993 run on x86_64-linux 1

1 package built:

steampipe

@NixOS/nixpkgs-merge-bot merge


frida-go Later will support windows system？

That is the goal to have until frida-go is at v1.0.0 but this would require adding the support to Meson for frida-core. I dont have much time to work on right now, but PRs are welcome

Set go env cc as msvc clone.exe

https://github.com/saferwall/winsdk2json/blob/main/cmd/translator.go

I also hope to be able to support windows systems because there is a need for this

Hey there @Ackites, I am a bit short on time but if you have it, frida can now be built using mingw so we could use that to add support for windows.

hope to support windows soon, really need it

@Fripine if you have time to work on it, feel free to do so. I will be more than happy to review it

need +1

After making some simple modifications, frida-go appears to be compilable and runnable on Windows (I have only tested the demo in the README)

@pk5ls20 that is looking great, congrats. Could you work on PR so I can test it out and merge it?

@pk5ls20 that is looking great, congrats. Could you work on PR so I can test it out and merge it?

#53


add 'v' to fix reference footer link

Fixes processing/p5.js#5344

A fix is already filed as #1051

@jiwonMe I merged kenneth's fix, so i'm going to close this. Thank you for your time on this! I've added you as a contributor here: https://github.com/processing/p5.js/pull/5352. 🎊


Feedback: Awsome repo!

Thanks a million. I just wanted to say that this is a very simple and easy way to do this. Thanks for the repo!

Thanks for the note! I'm glad this was helpful. :)


WAFv2 service controller

New ACK Service Controller
Support for WAFv2
List of API resources
List the API resources in order of importance to you:

WAF ACL
WAF ip set
WAF rules group

/lifecycle frozen

+1

PCI DSS v4 has a requirement for WAFs for all public apps, coming into effect in Q1 2025, and we'd love to use this in our environments. https://www.schellman.com/blog/new-requirements-in-pci-dss-v4

+1.

This would be quite useful for our use case of EKS cluster(s) in an AWS account where the stance is to limit creation of resources outside Kubernetes, and the primary mode of interaction is via clusters. Consuming teams can then provision WAF for their applications via kubectl or relevant Kubernetes commands and tooling. WAF is particularly problematic because of the inability to have cross account resources, so while some resources could be created in a separate AWS account via any method, WAF must be in the same account, and limiting creation to only use Kubernetes methods, this becomes problematic.

+1

+1

+1

+1

+1

This would be useful, especially if it integrated somehow with https://docs.aws.amazon.com/eks/latest/userguide/aws-load-balancer-controller.html


Fail to discover NVMe disks

What happened:
Following https://github.com/Azure/kubernetes-volume-drivers/tree/master/local on a cluster with a 1-node Standard_Lv8s_v2 node, it fails to detect the nvme disk:
E0824 14:27:00.945914       1 discovery.go:220] Failed to discover local volumes: 1 error(s) while discovering volumes: [Skipping file "/dev/nvme0": not a directory nor block device]

I'm able to format and mount /dev/nvme0n1 directly on the node
root@aks-nvme-31968050-vmss000000:/# mkfs.ext4 /dev/nvme0n1
mke2fs 1.42.13 (17-May-2015)
Discarding device blocks: done
Creating filesystem with 468843606 4k blocks and 117211136 inodes
Filesystem UUID: 89667bcc-a69e-4574-b8bf-0096b0099fb8
Superblock backups stored on blocks:
        32768, 98304, 163840, 229376, 294912, 819200, 884736, 1605632, 2654208,
        4096000, 7962624, 11239424, 20480000, 23887872, 71663616, 78675968,
        102400000, 214990848

Allocating group tables: done
Writing inode tables: done
Creating journal (32768 blocks): done
Writing superblocks and filesystem accounting information: done

root@aks-nvme-31968050-vmss000000:/# mount /dev/nvme0n1 /mnt/
root@aks-nvme-31968050-vmss000000:/# ls /mnt
lost+found

Also, I had to create the fast-disks StorageClass before applying the manifest for NVMe, so perhaps the doc needs to be fixed too.
What you expected to happen:
NVMe disks at /dev/nvme0 to be discovered and available to local provisioner.
How to reproduce it:
Create an AKS cluster (tried 1.16.3 and 1.18.6), add a nodepool with size Standard_Lv8s_v2 and apply the manifest for NVMe.
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): 1.18.6 and 1.16.3
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

cc @andyzhangx

the error said Skipping file "/dev/nvme0": not a directory nor block device, so have you already formatted /dev/nvme0 before running kubectl apply -f https://raw.githubusercontent.com/Azure/kubernetes-volume-drivers/master/local/local-pv-provisioner-nvmedisk.yaml ?

wait, /dev/nvme0n1 should be discovered successfully, right? Since it's using namePattern: nvme*
https://github.com/Azure/kubernetes-volume-drivers/blob/4f7291abbec1984ec0f346f9d6f85fdfddfa38e8/local/local-pv-provisioner-nvmedisk.yaml#L18

My bad, I thought the local provisioned would take care of the formatting (I read that it can form a RAID with multiple nvme devices). My goal is to avoid using a Daemonset to format the disk or worse accessing the node directly. Do you know if it’s possible, to have the nvme disk formatted? Thanks for the super quick reply!

The solution here(https://github.com/Azure/kubernetes-volume-drivers/tree/master/local) would leverage sig-storage-local-static-provisioner running as a DaemonSet to discover and format nvme disk, it won't configure RAID, would create one PV per disk. That's the way how it works, if we don't use a daemonset to format a disk, how can we do the format, the format should happen on the node, right?

Indeed, you're right, some mechanism must format the disk before being used by the local volume driver. I just thought that perhaps some of the scripts here: https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/tree/78a6f6e547099939019fec41c77d2727cd5e6f5e/deployment/docker/scripts could format the device before using it, or it's a functionality that can be added to mcr.microsoft.com/k8s/local-volume-provisioner (can't find the Dockerfile for that anywhere, by the way)?

I created this issue to have nvme-cli installed on the base images in AKS: https://github.com/Azure/AKS/issues/1818 and made this repo to prepare the disks for use: https://github.com/ams0/aks-nvme-ssd-provisioner

@ams0 mcr.microsoft.com/k8s/local-volume-provisioner:v2.3.5-alpha is actually master branch build of https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner which contains https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/pull/187, once sig-storage-local-static-provisioner published a new release, will use that image. So I would suggest use official sig-storage-local-static-provisioner image since it already have what you want, right? Currently you could just use image mcr.microsoft.com/k8s/local-volume-provisioner:v2.3.5-alpha or build image from sig-storage-local-static-provisioner by yourself?

To fix the above error msg, if you could make sure you have only one NVMe disk, set namePattern: nvme0* in the config file, below is a sample output on Standard_L16s_v2 which has two NVMe disks:
# ls /dev/nvme* -lt
brw-rw---- 1 root disk 259, 1 Aug 25 07:29 /dev/nvme1n1
brw-rw---- 1 root disk 259, 0 Aug 25 07:29 /dev/nvme0n1
crw------- 1 root root 243, 0 Aug 25 07:29 /dev/nvme0
crw------- 1 root root 243, 1 Aug 25 07:29 /dev/nvme1

I made this https://github.com/ams0/aks-nvme-ssd-provisioner/blob/master/manifests/storage-local-static-provisioner.yaml to use an initContainer to initialize the disks, so I'm happy :) thanks for your help, this can be closed.

@ams0  would you be open to having a chat with the PG team to learn more about your use case?

@olsenme absolutely, ping me on Teams or on LinkedIn: https://www.linkedin.com/in/alessandrovozza


About AAC and WebRTC

Why doesn't the WebRTC player support AAC audio? I am using Unifi Protect cameras and as far as I can tell, they have AAC audio and the Unifi Protect Web app uses WebRTC with audio just fine.
As far as I can tell from MDN and caniuse, it looks like it should work. Browsers via WebRTC are required to suppose Opus, PMCA and PMCU, but they can support other codecs as well and all of the major browsers also suppose AAC.

WebRTC have not support AAC. I think Unifi users another technology
https://developer.mozilla.org/ru/docs/Web/Media/Formats/WebRTC_codecs

That is the page I linked. it explicitly states that those are just the codecs that are required to be implemented, not a comprehensive list of all of the ones that can be supported.

This guide reviews the codecs that browsers are required to implement as well as other codecs that some or all browsers support for WebRTC.

I used chrome://webrtc-internals to collect the information about what Unifi uses. However, I don't see anything about audio or AAC in here. @AlexxIT can understand this data and see if WebRTC+AAC is used? I'm having the same issue as @AngellusMortis where I don't get any audio when WebRTC is used, but I do get audio when I set webrtc: false, but then I get really bad video.
Many thanks for your help
webrtc_internals_dump.txt


API Auth integration

Hi I just started to use your super project.
I'd like to go further and make it work with API authentication and request securely some user data from the database.
Do you have any idea on how I can do that ?
Thanks

not understand can you explain in more details


OS X binary links to dynamic libpcre

OS X binary links to dynamic libpcre (using explicit path /usr/local/opt/pcre/lib/libpcre.1.dylib), which causes headache due to lack of the library at this exact path.
It would be useful to have it linked statically.

Thanks for reporting!
I believe getting the static linking to work with libimporter.dylib, the custom Go library we use to resolve Go imports, will be troublesome. I did link to it statically before but it didn't work on Linux and caused a lot of headache with Stack and Cabal. Dynamic linking has worked smoother, until now at least. :)
When I build Oden locally the path to libpcre is /usr/local/lib/libpcre.1.dylib as it should be. The binary that get's the explicit path is built by Travis. I'm not sure why it is explicit though.

This kind of distribution should either use libraries available in the base OS (/usr/lib/libpcre.0.dylib, though note different ABI version), or bundle them. Relying on Brew/MacPorts is asking for trouble (unless the installation itself is performed through Brew/MacPorts).

Oh, yeah you're right, the path I referred to is Brew-specific, forget about that.
OK, but if it's possible to get the Stack build to only statically link pcre then maybe that'll work. I'll bash my head at it for a while. :)

I'll check it out as well.

PCRE is now bundled with the distribution and included using DYLD_LIBRARY_PATH, so closing this. Thanks!


Rollup build pipeline is broken

Which package(s) are affected?
Other/unknown (please mention in description)
Description
I've created a fresh new Lit project with Vite but unable to set environment to build HTML bundle with Rollup.
I repeated exactly as written in Lit documentation.
According to Lit docs Rollup packages should be installed but there are few problems:

Installation of rollup-plugin-minify-html-literals package fails because dependency tree can't be resolved

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/rollup
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^1.0.0 || ^2.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/rollup-plugin-minify-html-literals
npm ERR!   dev rollup-plugin-minify-html-literals@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/mike/.npm/eresolve-report.txt for a full report.

npm ERR!      /Users/mike/.npm/_logs/2023-04-21T16_53_26_092Z-debug-0.log

If I skip HTML minification and drop out rollup-plugin-minify-html-literals package Rollup also fails to build the project

$ npx rollup -c
Result:
[!] SyntaxError: The requested module '@web/rollup-plugin-html' does not provide an export named 'default'

So that for now I can't move forward with my Lit project since there are some flaws with dependency tree and no alternative example provided in the docs.
Any working and comprehensive code sample how to build HTML bundle with Lit will be appreciated!
Reproduction

At first create a new Lit project with Vite npm create vite@latest
Try to install all these dependencies which shown in the official Lit docs
Rollup environment setup fails

Workaround
No workaround found, unfortunately.
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
<EMAIL_ADDRESS>Browser/OS/Node environment
macOS: 10.15.7
Node: v16.14.2
npm: 8.5.0

Hi! The issue you are encountering is due to vite depending on a conflicting version of rollup, that the rollup-plugin-minify-html-literals package doesn't support.
From a cursory look it appears that the lit.dev documentation may be out of date for the imports. For example, the following imports should work:
// Import rollup plugins
import {rollupPluginHTML} from '@web/rollup-plugin-html'; // <- changed
import {copy} from '@web/rollup-plugin-copy';
import resolve from '@rollup/plugin-node-resolve';
import terser from '@rollup/plugin-terser'; // <- changed
import summary from 'rollup-plugin-summary';

Also note that the documentation you are referencing is for a pure rollup configuration. Instead of using rollup.config.js and npx rollup -c, prefer to use vite since you're using that environment. I believe rollup configuration can be put in a vite build option. Then build for production with vite build.

@AndrewJakubowicz thank you for detailed response!
Looks like there was something wrong with the version of Vite which didn't output only index.html while building the project, so I had to take advantage of Rollup build with Vite :)
I've updated Vite and now it generates index.html with npm run build command. Also I noticed that there are no vite.config.ts file in Vite + Lit template anymore. For sure now I can use vite build options if needed.
Thank you also for example and mentioning outdated docs!


Example of using custom endpoint instead of ocAgent binary

The current documentation and examples point out that instead of using OpenCensus Agent, we could alternatively expose a custom endpoint on Frontend web server to collect the traces and export these via OpenCensus library.
However, there is no example of how to parse and forward the data received from OpenCensus WEB (JS).
E.g. docs say the following:
We also suggest that you create an endpoint in the server that receives the HTTP/JSON traces and proxies to the OpenCensus Agent.
However, there is no information about the format of these JSON trances, or maybe I cannot find these easily.

Great question here. This is definitely a gap in our current docs.
At a high level, what you need to do is add a new endpoint to you app and simply forward whatever JSON payload comes in from the OpenCensus Web library and pass it on to the OpenCensus Agent (which accepts HTTP/JSON via grpc-gateway).
I don't have an ETA for it, but I agree this is important and will plan to do it.

Also a PR is welcome if you get to it first and can find an easy way to integrate it into the current user interaction example! What language are you using in your server, is it Node.js?

Dave, thanks for your reply. May I ask you a followup? Is OC Agent binary absolutely necessary for OpenCensus WEB? We were planning to use OC Web with OC library embedded into our application. Is this scenario supported?
We use Asp.Net Core app.
Yes, if I'm able to make this work properly first, I'll certainly send a PR.
Thanks again for your help.

You're right - it is not necessary to use the OC Agent binary. You could export the trace spans in your Asp.Net Core app using the OpenCensus .Net library.
The challenge there is that you would need to write the code to ingest the JSON blob from OpenCensus web and format it as spans for the OpenCensus .Net library, which might take some work. The reason I implemented the suggestion with the OC Agent is that people write servers in different languages, so for us to be able to do this in general without the OC Agent, we would need that same translation code for Go, Python, Java, etc.
But if you're interested in pursuing that route, here is an auto-generated Open API/Swagger description of the JSON format that OpenCensus Web uses to send to the agent. It is ultimately based on a proto files. That translation code would ideally be extractable as a library to gradually move to the place where we could have similar code for every language to not require the OC Agent.
Since your app is in Asp.Net, don't feel like you need to do a PR for the Node example, but if you are motivated to do so, that would be helpful. An Asp.Net example would also be super cool!

I'll take a look at Open API reference you provide. Thank you!


Deleted "Results: " text in the result

This PR proposes an enhancement to improve the readability of Tirith check output.

Hi @refeed , could you please review this enhancement. Please tell me if anything else is needed to be fixed here.
Thanks


Document all options for creating Notifications

The defaults for the 'icon' values come from Notification::getIcon.
dismissable defaults to !!options.dismissable, which equates to false for undefined.

:+1:

Thanks @ssorallen!


input readonly list-attribute

Fails in rendering an input with attribute 'list' user for targeting datalist-element
Removing the attribute renders both input and datalist elements, then unconnected and useless of course.
Console message:
Cannot assign to read only property 'list' of object '#'
at setElementData...
Reproduced in glitch
https://glitch.com/edit/#!/wry-autocomplete
import { h, app } from 'hyperapp' // 0.7.1
// import {h, app} from '../hyperapp/index' // 0.8.0, unreleased

const dataList = () =>
  <datalist id='browsers'>
    <option value='Chrome'></option>
    <option value='Firefox'></option>
    <option value='Internet Explorer'></option>
    <option value='Opera'></option>
    <option value='Safari'></option>
    <option value='Microsoft Edge'></option>
  </datalist>

const view = () =>

    Choose a browser from this list:
    <input list='browsers' />
    {dataList()}

app({view})

@marcusasplund Hi 👋!
I just woke up so I haven't looked at this in good detail, but smells like another use case we fixed with keys https://github.com/hyperapp/hyperapp/pull/172?
@zaceno Do you have any comments?

@jbucaran - Looked at the glitch-example @marcusasplund provided. As far as I can tell, it's got not nothing to do with keys.
Not sure exactly what the problem is. The relevant lines of code are (in setElementData)
     element.setAttribute(name, value)
     if (element.namespaceURI !== "http://www.w3.org/2000/svg") {
         // SVG element's props are read only in strict mode.

        element[name] = value
     }

the line that throws the exception is element[name] = value. Not sure why. Possibly because the list attribute is newish HTML5. Maybe there's some special way browsers treat it differently to other attributes.
The thing I don't get, though, is: We already do element.setAttribute(name, value) higher up. What does element[name] = value give us?
Even though using keys won't fix the issue, the setElementData function has been changed on master since 0.7.1, so it'd be interesting to see how this behaves on master.

@zaceno Yup. I tried to switch from 0.7.1 to src from master in the  glitch provided. Same behaviour. But commenting out line 184 in src/hyperapp/app.js (in the glitch) all elements renders and works as expected.
//  element[name] = value
Haven't thouroghly tested, but at least it does not produce any console errors.
For me it looks like a bug; trying to assign one more time in an unappropriate way.

@marcusasplund This is a bug then, perhaps we need to be careful about some attributes or just turn off "use strict", which I'm almost sure if you can turn it off the problem would go away.

I ran the tests on master with the line element[name] = value commented out ( in fact I took out the whole block: https://github.com/hyperapp/hyperapp/blob/master/src/app.js#L180:L191 ). All passed.
@jbucaran, do you know off hand of any reason why we need the element[name] = value at all?
(Side note: the reason I took out the entire code block surrounding that line, is because it was dealing with selectionStart/End in text inputs. I think now that we have keys, that's all more of a 'nice to have' rather than a 'must have', since a user could just key their textinput and the problem would be solved. Sure it's a little bit of a hassle for the user, but if we need to get rid of bytes, it's an option :) )

Well for once we use element[name] = value to set event handlers.

All passed.

This tells me, that we're lacking on tests then!

@marcusasplund Is there any reason why you use dataList() instead of <DataList/>? That's the usual way to use JSX.

@dodekeract Nope.
Pretty newbie to jsx, i tried to find out now where i first got this syntax, but i cant remember.
I'd better read up on jsx :-) That component-/xml-like syntax feels a lot better. Thx for the heads up.

@marcusasplund I need to seriously rewrite the entire todomvc. When I first wrote it, I used Hyperx, later I tried to rewrite it in JSX, but didn't do a great job at it.

@jbucaran: Ah, that makes sense.
I have some thoughts for a PR to fix this, but I'm going to hold off until 0.8.0. There's enough dust in the air :)
Either way, I agree: clearly more tests are needed if I can comment out an entire code block with no tests failing 😛

@marcusasplund I think this is fixed in >=0.8.1. Can you give it a shot? 🙏

Yup. I can confirm that it works as expected now. Good work!
Updated to 0.8.1 https://glitch.com/edit/#!/wry-autocomplete


Added dependencies and note

Codecov Report

Merging #70 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   22.94%   22.94%
=======================================
  Files          33       33
  Lines         950      950
  Branches       16       16
=======================================
  Hits          218      218
  Misses        732      732

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63e321...ed6ecb3. Read the comment docs.


Contribute to the Style Guide - Spacers

Done, but waiting for colour and typography to be ready so I can implement these in the spacers


Feature - Add meta field as JSON string in int_all_graph_resources

This is a:

[ ] bug fix PR with no breaking changes
[x] new functionality

Link to Issue

Description & motivation

Adds the meta field for all elements (sources, exposures, metrics, nodes) and store it as a JSON string. Each DW could then consume this column and use its own JSON parsing functions.
Checklist

[x] I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)

[ ] BigQuery
[x] Postgres
[ ] Redshift
[ ] Snowflake

[x] I have updated the README.md (if applicable)
[x] I have added tests & descriptions to my models (and macros if applicable)
[ ] I have added an entry to CHANGELOG.md

I am closing this one as the change was done with https://github.com/dbt-labs/dbt-project-evaluator/commit/4e60c9b91be244724b99189262bc6195ad5a7135 instead, due to the refactor fo how we load data, there were merge conflicts that would have required and entire rework if I wanted to continue with this PR


Cluster creation fails with microOS

Trying to create a cluster on microOS nodes fails. Installer logs these lines:
[Control plane] Generating the kubeconfig file to /home/matteo/dev/tests/hetznerk3s/kubeconfig...
error: no context exists with the name: "test-master2"
[Control plane] ...kubeconfig file generated as /home/matteo/dev/tests/hetznerk3s/kubeconfig/kubeconfig.
Unhandled exception in spawn: timeout after 00:00:30 (Tasker::Timeout)
  from /usr/lib/crystal/core/channel.cr:453:10 in 'timeout'
  from /home/runner/work/hetzner-k3s/hetzner-k3s/src/kubernetes/installer.cr:124:7 in 'run'
  from /usr/lib/crystal/core/fiber.cr:143:11 in 'run'
  from ???

After some debugging i think i understand why it is failing.
When the k3s installation script is downloaded and executed on the master node, the script terminates by enabling the k3s systemd service but DOESN'T start it. As a result, the /etc/rancher/k3s/k3s.yaml kubeconfig DOESN'T get created, and the whole installation process fails.
I've taken a look a the k3s installation script, and i could be wrong on this, but i think the reason why the script doesn't start the systemd process is because at some point it sets the INSTALL_K3S_SKIP_START variable to true, and when the it reaches  the following line -> [ "${INSTALL_K3S_SKIP_ENABLE}" = true ] && return, the script exits without starting the systemd service.
I think the point where the script sets INSTALL_K3S_SKIP_ENABLE to true is here ->
case ${3} in
       sle)
           rpm_installer="zypper --gpg-auto-import-keys"
           if [ "${TRANSACTIONAL_UPDATE=false}" != "true" ] && [ -x /usr/sbin/transactional-update ]; then
               transactional_update_run="transactional-update --no-selfupdate -d run"
               rpm_installer="transactional-update --no-selfupdate -d run ${rpm_installer}"
               : "${INSTALL_K3S_SKIP_START:=true}"
           fi

Again, i could be wrong, so take it just as an intuition on what could be the problem here.
To make the installation process work, i had to hardcode INSTALL_K3S_SKIP_START=false into master_install_script.sh  ->
curl -sfL https://get.k3s.io | INSTALL_K3S_VERSION="{{ k3s_version }}" K3S_TOKEN="{{ k3s_token }}" {{ datastore_endpoint }} INSTALL_K3S_SKIP_START=false INSTALL_K3S_EXEC=...
and generate a new binary.
I think having the possibility to customize the k3s installation script by passing extra variables is needed to resolve this particular issue.

Hi, nice that you found the problem. Would you mind making a PR with your change? :)

Done!