Impossible to load a DataModule on CPU when checkpointed with GPU available

Bug description
It seems impossible to properly load a DataModule from a CPU-only machine when it has been checkpointed from a GPU-enabled machine.
What version are you seeing the problem on?
v2.0
How to reproduce the bug
Here is a minimal reproducible example of the bug I am facing (based on the "hello world" examples of pytorch lightning webpage):

In the script below I am training a simple module using a data module. The training is done on a GPU machine (torch.cuda.is_available() returns True):

from torch import nn
import torch
from torch.utils.data import random_split, DataLoader
from torch.nn import functional as F
import pytorch_lightning as pl
from torchvision.datasets import MNIST
from torchvision import transforms

class MNISTDataModule(pl.LightningDataModule):
    def __init__(self, data_dir: str = "./", batch_size: int = 32):
        super().__init__()
        self.data_dir = data_dir
        self.batch_size = batch_size

    def setup(self, stage: str):
        self.mnist_test = MNIST(self.data_dir, train=False, download=True, transform=transforms.ToTensor())
        self.mnist_predict = MNIST(self.data_dir, train=False, download=True, transform=transforms.ToTensor())
        mnist_full = MNIST(self.data_dir, train=True, download=True, transform=transforms.ToTensor())
        self.mnist_train, self.mnist_val = random_split(mnist_full, [55000, 5000])

    def train_dataloader(self):
        return DataLoader(self.mnist_train, batch_size=self.batch_size)

    def val_dataloader(self):
        return DataLoader(self.mnist_val, batch_size=self.batch_size)

    def test_dataloader(self):
        return DataLoader(self.mnist_test, batch_size=self.batch_size)

    def predict_dataloader(self):
        return DataLoader(self.mnist_predict, batch_size=self.batch_size)

class MNISTModel(pl.LightningModule):
    def __init__(self):
        super().__init__()
        self.l1 = torch.nn.Linear(28 * 28, 10)

    def forward(self, x):
        return torch.relu(self.l1(x.view(x.size(0), -1)))

    def training_step(self, batch, batch_nb):
        x, y = batch
        loss = F.cross_entropy(self(x), y)
        return loss

    def configure_optimizers(self):
        return torch.optim.Adam(self.parameters(), lr=0.02)

mnist = MNISTDataModule("./")
model = MNISTModel()

trainer = pl.Trainer(
    default_root_dir="./",
    max_epochs=3,
)
trainer.fit(model, mnist)

Then I am loading the checkpoint from a CPU-only machine (torch.cuda.is_available() returns False):

checkpoint_path = "./lightning_logs/version_0/checkpoints/epoch=2-step=5157.ckpt"

neural_net = MNISTModel.load_from_checkpoint(
    checkpoint_path,
    map_location=torch.device('cpu')
)

data_module = MNISTDataModule.load_from_checkpoint(
    checkpoint_path,
    map_location=torch.device('cpu')
)

When I remove the map_location=torch.device('cpu'), I get the error RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU. which is expected.
When I add map_location=torch.device('cpu'), the module is loaded correctly, but the data module returns the error TypeError: pytorch_lightning.core.saving._load_from_checkpoint() got multiple values for keyword argument 'map_location'.
After checking the source code of method LightningDataModule.load_from_checkpoint (see: https://lightning.ai/docs/pytorch/stable/_modules/lightning/pytorch/core/datamodule.html#LightningDataModule.load_from_checkpoint), I see that the problem is coming from the fact that the map_location argument is already set to None (which causes the error):
loaded = _load_from_checkpoint(
    cls,
    checkpoint_path,
    map_location=None,
    hparams_file=hparams_file,
    strict=None,
    **kwargs,
)

Would it be possible to add map_locationas an argument to LightningDataModule.load_from_checkpoint to solve this bug ?
Error messages and logs
TypeError: pytorch_lightning.core.saving._load_from_checkpoint() got multiple values for keyword argument 'map_location'

Environment

Current environment
-Torch version: 2.0.1
- Pytorch lightning version: 2.0.4

More info
No response

The source code of the DataModule confirms that the map_location argument is indeed set to None in the _load_from_checkpoint function call within the load_from_checkpoint method. This is the root cause of the issue.
The proposed solution would involve modifying the load_from_checkpoint method of the DataModule to accept map_location as an argument and pass it to the _load_from_checkpoint function. This would allow the user to specify the device to which the storage should be mapped when loading the checkpoint.
@classmethod
def load_from_checkpoint(
    cls,
    checkpoint_path: Union[_PATH, IO],
    hparams_file: Optional[_PATH] = None,
    map_location=None,  # Added this line
    **kwargs: Any,
) -> Self:
    r"""
    ...
    """
    loaded = _load_from_checkpoint(
        cls,
        checkpoint_path,
        map_location=map_location,  # Modified this line
        hparams_file=hparams_file,
        strict=None,
        **kwargs,
    )
    return cast(Self, loaded)

That would be awesome!


NRI plugin for passing prefetch list

@imeoer Looks like we have a document on this topic: https://github.com/containerd/nydus-snapshotter/blob/main/docs/optimize_nydus_image.md


CCD-3694 test definitions for FTAs for CCD-3675

JIRA link (if applicable)
CCD-3675 "Global Search - Access Process should take into account mapped access profiles"
CCD-3694 "FTAs for Global Search - Access Process CCD-3675"
Change description
Test definitions for FTAs for CCD-3675. These new case types require the new CCD role in https://github.com/hmcts/befta-fw/pull/191.
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Closing as all changes also included in #57.


added my name to guestbook.md

Hi, in addition to signing the guestbook, I also made an update to regarding a change to the GitHub Pages creation procedure.


Fix #494 Arrumando onPress

Nesse pull Request foi feito:

Issue #494 ;
Tornou o botão todo clicável.

Pull Request Test Coverage Report for Build 1556

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.063%

Totals

Change from base Build 1554:
0.0%

Covered Lines:
341

Relevant Lines:
370

💛  - Coveralls

@BeatrizHanae o coverage caiu


Bot does not respond to commands in threads

The bot has no response to commands in threads while other dice bots respond like any other channel.

Sure it does


Preparation or improvement of the guide for implementation of generators of dynamic systems lists (issue #860 related)

The goal is to prepare or improve a guide or report that is generated by the following code:
from dynpy.utilities.documents.document import DynSysOverviewReport
DynSysOverviewReport();

Meeting was carried out. I'm closing this issue.


Add Thermal Phantoms

Description
Thermal Phantoms are a lot like normal phantoms, but they're thermal. They have a ranged fire attack which creates pillars of fire near their target. They have an aura that also lights nearby flammable things on fire. so that's fun.
Technical Mumbo Jumbo
This could maybe be accomplished with a hediff that can be applied to normal phantoms, which can then draw extra effects on top of the normal phantom sprite.
Spawning
Thermal phantoms should be guaranteed to spawn via the corpse of a pyromaniac, otherwise it should be a rare chance to spawn normally.
Attack
The flame pillar attack will likely require some extra coding, not sure how to accomplish that easily... but there's probably weird workarounds -- like throwing an invisible grenade, and having the detonation create the pillar attack.
Art Needed
Fire aura / Retextured phantom
A fire-like aura should be applied on the normal phantom sprite to show the variant, the body area appears to glow with a flame inside as well.

Fire ability.
The fire attack starts as a glow on the ground and rises up as a pillar of flame

Aura isn't that great, hard to make fire look good in vanilla rimworld style

Thermal Phantoms, both as a new sprite and as an overlay, altering opacity can help the sprites read better from a distance


Separate operator and edge-api codebases

This PR separates existing operator and edge-api code to allow for easier future changes and better Dockerfile-level separation.
No functional code changes, just scattering internal/* among new internal/common, internal/operator and internal/edgeapi.

@gabriel-farache the distinction between the packages is very similar to what you described, with following comments:

edgeapi is called this way, because it holds files used only by flotta-edge-api container/pod/deployment; the API for communicating with edge devices is called Flotta Edge API throughout the docs;
operator in turn holds files used exclusively by the operator;
common - code shared between both binaries.

All three packages can potentially become separate github repos/projects.

common is common for operator binaries (so also /controllers package).
If there is a separate subpackage for edgeapi, separate one for operator seems consistent.

common is common for operator binaries (so also /controllers package). If there is a separate subpackage for edgeapi, separate one for operator seems consistent.
If common is used by packages outside internal should it be in the root folder?
Well, as far as I understand it, edgeapi interaction is part of the responsbilities of the operator, hence a subpackage for this particular responsibiliy. But naming a subpackage operator inside the operator project is a pleonasm, this is what is bugging me.
I know I am quibbling about it and if I am the only one 'annoyed' about it, it is fine and we should move forward with your naming :)

If common is used by packages outside internal should it be in the root folder? Well, as far as I understand it, edgeapi interaction is part of the responsbilities of the operator, hence a subpackage for this particular responsibiliy. But naming a subpackage operator inside the operator project is a pleonasm, this is what is bugging me. I know I am quibbling about it and if I am the only one 'annoyed' about it, it is fine and we should move forward with your naming :)

edgeapi can be provided and run outside of the context of the operator, even on a different cluster as a service that points to the cluster on which the operator is deployed, or even as a different deployment method (e.g. not on top of k8s - not yet supported, but it doable). Therefore next step might be splitting this repository for the operator and for the edgeapi (web-server).
This repository will include flotta's CRDs that should be imported and used by edgeapi. I'm okay with the current split and renaming, looking forward for additional work on top of it.
Once repo is split, there will no longer be a need for the operator/edgeapi folders.

If common is used by packages outside internal should it be in the root folder? Well, as far as I understand it, edgeapi interaction is part of the responsbilities of the operator, hence a subpackage for this particular responsibiliy. But naming a subpackage operator inside the operator project is a pleonasm, this is what is bugging me. I know I am quibbling about it and if I am the only one 'annoyed' about it, it is fine and we should move forward with your naming :)

edgeapi can be provided and run outside of the context of the operator, even on a different cluster as a service that points to the cluster on which the operator is deployed, or even as a different deployment method (e.g. not on top of k8s - not yet supported, but it doable). Therefore next step might be splitting this repository for the operator and for the edgeapi (web-server).
This repository will include flotta's CRDs that should be imported and used by edgeapi. I'm okay with the current split and renaming, looking forward for additional work on top of it.
Once repo is split, there will no longer be a need for the operator/edgeapi folders.

Ok, so this is just a step toward another split

If common is used by packages outside internal should it be in the root folder? Well, as far as I understand it, edgeapi interaction is part of the responsbilities of the operator, hence a subpackage for this particular responsibiliy. But naming a subpackage operator inside the operator project is a pleonasm, this is what is bugging me. I know I am quibbling about it and if I am the only one 'annoyed' about it, it is fine and we should move forward with your naming :)

edgeapi can be provided and run outside of the context of the operator, even on a different cluster as a service that points to the cluster on which the operator is deployed, or even as a different deployment method (e.g. not on top of k8s - not yet supported, but it doable). Therefore next step might be splitting this repository for the operator and for the edgeapi (web-server).
This repository will include flotta's CRDs that should be imported and used by edgeapi. I'm okay with the current split and renaming, looking forward for additional work on top of it.
Once repo is split, there will no longer be a need for the operator/edgeapi folders.

Ok, so this is just a step toward another split

It is step forward more refactoring and maybe a repo split in the future.


Release v0.4.2

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.03%. Comparing base (d9ee425) to head (b41e893).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   85.03%   85.03%
=======================================
  Files          16       16
  Lines        1049     1049
=======================================
  Hits          892      892
  Misses        157      157

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


V1.11.1 rebase

Rebased v1.10.2.g51db2.kitware.jobserver-1 on top of v1.11.1.

Thanks.  I was recently working on this too, and I've now pushed an update to the kitware-staged-features branch and a new tag.


URL structure has changed?

This is link for raw content:
https://gist.githubusercontent.com/vemv-kantox/eabfe191fdcab95183bd/raw/45a30beec4861b128c20dcdb382d607613da6c0c/afdas.html
If I try replacing 'gist.githubusercontent' for 'raw.githack', I'll get a 404.

Works for me:
❯ curl -D- https://gist.githack.com/vemv-kantox/eabfe191fdcab95183bd/raw/45a30beec4861b128c20dcdb382d607613da6c0c/afdas.html
HTTP/1.1 200 OK
Server: nginx/1.9.3
Date: Tue, 21 Jul 2015 17:55:57 GMT
Content-Length: 348
Connection: keep-alive
X-XSS-Protection: 1; mode=block
X-Frame-Options: deny
Strict-Transport-Security: max-age=31536000
ETag: "089b9529d221140698012dc288ba264c235f57b6"
Via: 1.1 varnish
X-Served-By: cache-lhr6323-LHR
X-Cache: MISS
X-Cache-Hits: 0
Vary: Authorization,Accept-Encoding
Expires: Tue, 21 Jul 2015 18:00:52 GMT
Source-Age: 0
X-Robots-Tag: none
X-Cache-Status: HIT
Access-Control-Allow-Origin: *
X-Content-Type-Options: nosniff
Content-Type: text/html; charset=utf-8
Accept-Ranges: bytes

<!--[if lte IE 8]>
<script charset="utf-8" type="text/javascript" src="//js.hsforms.net/forms/v2-legacy.js"></script>
<![endif]-->
<script charset="utf-8" type="text/javascript" src="//js.hsforms.net/forms/v2.js"></script>
<script>
  hbspt.forms.create({
    portalId: '310641',
    formId: 'b05cc959-1349-42e6-a4d7-c1e6575b3b0d'
  });
</script>

Oh yes, for gists you should use gist.githack.com instead of raw.githack.com.

Great! Misread http://raw.githack.com/.
I suggest giving gists the same visual importance as regular gihubt in the docs: use red/green/bold. Else too easy too visually skip.

Thanks, will do!


subtitles in the charts aside are slightly different than before

caused by https://github.com/src-d/sourced-ui/pull/226
new: subtitles in the aside are slightly different than before
e.g.: "Datasource & Chart Type" and "Time

old: the original size of subtitles in the aside
e.g.: "Datasource & Chart Type" and "Time

I tried spotting the difference, but I cannot 😂. Is the font-size different?

I tried spotting the difference, but I cannot 😂. Is the font-size different?

More importantly, do we need to fix this? \cc @ricardobaeta

@se7entyse7en I'll update you on this next Monday.


DeleteWhere fails with multiple critera

session.DeleteWhere<Comment>(x => x.Id == id);
session.DeleteWhere<Comment>(x => x.MemberId == CurrentMember.Id);

Both of these use int and work individually
session.DeleteWhere<Comment>(x => x.Id == id && x.MemberId == CurrentMember.Id);
When combined together for multiple criteria, it fails.

System.NotSupportedException: Specified method is not supported.
at Marten.Linq.ExpressionExtensions.Value(Expression expression)
at Marten.Linq.MartenExpressionParser.buildSimpleWhereClause(IDocumentMapping mapping, BinaryExpression binary)
at Marten.Linq.MartenExpressionParser.WhereClauseVisitor.VisitBinary(BinaryExpression binary)
at System.Linq.Expressions.BinaryExpression.Accept(ExpressionVisitor visitor)
at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
at Marten.Linq.MartenExpressionParser.WhereClauseVisitor.VisitBinary(BinaryExpression binary)
at System.Linq.Expressions.BinaryExpression.Accept(ExpressionVisitor visitor)
at System.Linq.Expressions.ExpressionVisitor.Visit(Expression node)
at Marten.Linq.MartenExpressionParser.ParseWhereFragment(IDocumentMapping mapping, Expression expression)
at Marten.Services.Delete.Configure(MartenExpressionParser parser, IDocumentStorage storage, IDocumentMapping mapping, UpdateBatch batch)
at Marten.Services.UnitOfWork.<>c__DisplayClass23_3.b__9(Delete id)
at Baseline.GenericEnumerableExtensions.Each[T](IEnumerable1 values, Action1 eachAction)
at Marten.Services.UnitOfWork.<>c__DisplayClass23_0.b__8(Type type)
at Baseline.GenericEnumerableExtensions.Each[T](IEnumerable1 values, Action1 eachAction)
at Marten.Services.UnitOfWork.GetChanges(UpdateBatch batch)
at Marten.Services.UnitOfWork.buildChangeSet(UpdateBatch batch)
at Marten.Services.UnitOfWork.d__22.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Marten.DocumentSession.d__19.MoveNext()

Yo, I'll be happy to look into it.

@nieve Go for it. I'm surprised that that's any kind of issue.

@jeremydmiller ha, You should have a peak at gitter. It's an odd one.

@nieve I'm gonna deal with this one this morning, then push a new nuget. I'll do what we discussed on Gitter about using a MartenQueryable underneath the covers

:+1:


Sibling project references and solution-level NuGet.config not supported by Dockerfile and docker build

This isn't really a bug, but it might be a design consideration.
I have a solution with two projects and a custom NuGet.config file. Example:
.
+-- /NuGet.config (contains two package sources)
+-- /src
|   +-- Project1
|   +-- Project2
|   |   +-- project.json (lists "Project1" as a dependency)
|   |   +-- Dockerfile

Running "dnu restore", "dnu build", and "dnx kestrel" from within the Project2 directory all work correctly. However, running "docker build -t project2 ." from within the Project2 directory causes several problems. This is my Dockerfile:
FROM microsoft/aspnet:latest

ADD . /app
WORKDIR /app

RUN ["dnu", "restore"]

EXPOSE 5004
ENTRYPOINT ["dnx", "kestrel"]

The first problem is that my NuGet.config file is not used by "docker build" since it is located outside of my project directory, and docker does not access any files outside of the scope of the directory the Dockerfile is in. This causes "dnu restore" to fail since it does not look for packages in my custom NuGet package source and is unable to resolve the dependencies that don't exist on nuget.org.
The workaround kind of sucks but it is manageable: I can simply modify my Dockerfile to pass in my NuGet sources to "dnu restore". Here's the result:
FROM microsoft/aspnet:latest

ADD . /app
WORKDIR /app

RUN ["dnu", "restore", "-s", "https://my-custom-source", "-s", "https://api.nuget.org/v3/index.json"]

EXPOSE 5004
ENTRYPOINT ["dnx", "kestrel"]

That solves the first problem. But now I have another problem: "dnu restore" cannot resolve the dependency on Project1 since it is also outside of docker's scope.
I don't think there is a clean way to fix this problem without making Project1 its own NuGet package and pushing it to the custom package source. I have good reasons for putting Project1 in the same solution as Project2, so that is a situation I would prefer to avoid.
Unfortunately, I don't really have any suggestions for fixing this issue right now. However, considering that containers seem to be the wave of the future, I doubt I will be the last person to consider this an important issue.

It also appears that I can move my NuGet.config file into the project directory (alongside Dockerfile) and that prevents me from having to include my NuGet sources inside the Dockerfile.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


Link to GitHub failed: Permission Denied!

I'm trying to link Keybase to my Github and posted a public gist keybase.md. The app won't recognize it and the command line keeps saying "Permission Denied! Make sure your gist is public!" but the gist is already public.

I'm having the exact same problem: https://gist.github.com/CoolWind/95e8b13b482184b00d5a65109d2946f0

I'm trying to link Keybase to my Github and posted a public gist keybase.md. The app won't recognize it and the command line keeps saying "Permission Denied! Make sure your gist is public!" but the gist is already public.

Did you resolve the problem?

Yes. It was solved very quickly.
xkessonx<EMAIL_ADDRESS>于2019年9月10日周二 上午6:12写道：

I'm trying to link Keybase to my Github and posted a public gist
keybase.md
https://gist.github.com/ca468oo7/5530f6dc021c45ef5823b90e7e7ca45f. The
app won't recognize it and the command line keeps saying "Permission
Denied! Make sure your gist is public!" but the gist is already public.
Did you resolve the problem?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/19387?email_source=notifications&email_token=AC32L2BP3QHBIY6URTVR7XLQI56INA5CNFSM4IVCRZYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6KXBJA#issuecomment-529887396,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC32L2AENNHRI2VEJ3PQM43QI56INANCNFSM4IVCRZYA
.

How?

Just post your problem and it will be solved I guess.
Nick Martin<EMAIL_ADDRESS>于2019年9月11日周三 上午6:34写道：

How?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/19387?email_source=notifications&email_token=AC32L2GV4SHYVRJG2RQA2BDQJDJVBA5CNFSM4IVCRZYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6OFX3A#issuecomment-530340844,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC32L2GAA5MP43WXVSFS4DTQJDJVBANCNFSM4IVCRZYA
.


Device agent hangs if Node-RED doesn't exit on SIGINT

Current Behavior
When the device agent asks the NR instance to shutdown it does so by sending a SIGINT.
If there is a bad node that blocks shutdown we need to be able to forcefully kill the NR process so we can start a new snapshot
Expected Behavior
After a suitable timeout the NR process should be sent a SIGKILL to the process
Steps To Reproduce
No response
Environment

FlowFuse version: 1.13.3
Node.js version: 18.x
npm version: 9.x
Platform/OS: Linux
Browser: na

@hardillb Should we close this in light of #227 / #236?

Yes


[VS Code] [Audio] Request startOrJoinCall failed unexpectedly without providing any details.

Error:
Request startOrJoinCall failed unexpectedly without providing any details.
Steps to Reproduce:

Join collaboration Session
Start audio call

Version Data

extensionName
VSLS-Audio

extensionVersion
0.1.91

applicationName
VSCode

applicationVersion
1.50.0

platformName
Windows

platformVersion
10.0.19041

Closing this as a duplicate of #3800.


Fix click on headings and TOC issues

Scroll to top on prose headings does not work.
Scrollspy TOC (sometimes) does not work.
Click on TOC items does not work.

Related https://github.com/nuxt-themes/docus/issues/669


Regression tests for 'parallelize-gather' rule

Scope & Purpose
Based on:
https://arangodb.atlassian.net/browse/BTS-1400
https://arangodb.atlassian.net/browse/BTS-1401
https://arangodb.atlassian.net/browse/BTS-1402

[ ] :hankey: Bugfix
[X] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[x] Tests

[ ] Regression tests
[ ] C++ Unit tests
[x] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[ ] Backport for 3.10: (Please link PR)
[ ] Backport for 3.9: (Please link PR)
[ ] Backport for 3.8: (Please link PR)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[X] Enterprise PR: https://github.com/arangodb/enterprise/pull/1270
[ ] GitHub issue / Jira ticket:
[ ] Design document:

This test is moved to this PR: https://github.com/arangodb/arangodb/pull/18994


Markdown starting BOLD embedded in ITALICS renders wrongly with in the editor

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.87
OS Version: Linux x64 6.1.77-2-MANJARO

Problem:

This is not about Markdown rendered on a page.
This is about Markdown rendered inside the editor.

Steps to Reproduce:

Copy-paste the following code block into any markdown file:

- Incorrectly rendered in the editor:

***Chocolate** and **cookies** are separate topics*
***Starting Bold** and **then more bold** in an asterisk italics line, but the entire line should appear as italics*
___Starting Bold__ and __then more bold__ in an underscore italics line, but as plain text when the line is italics_
***Starting bold** without more bold in an asterisk italics line also renders incorrectly: as bold when the line is italics*
___Starting bold__ without more bold in an underscore italics line also renders incorrectly: as plain text when the line is italics_

- Correctly rendered in the editor:

_**Chocolate** and **cookies** are separate topics_
***Chocolate* and *cookies* are separate topics** - as an asterisk bold line
__*Chocolate* and *cookies* are separate topics__ - as an underscore bold line
***Starting italics* with asterisk italics inside an asterisk bold line renders the line correctly in the editor: as a bold line**
**_Starting italics_ with underscore italics inside an asterisk bold line renders the line correctly in the editor: as a bold line**
*One **bold** word deep inside asterisk italics renders the line correctly **and sometimes bold** in the editor*
_One **bold** word deep inside underscore italics renders the line correctly **and sometimes bold** in the editor_
**A bold line *with asterisk italics deep inside* renders the line correctly *with more italics* in the editor**
**A bold line _with underscore italics deep inside_ renders the line correctly _with more italics_ in the editor**

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

It is updated to 1.87.2 and the problem persists.

The editor only renders bold OR italics, not bold AND italics. It might be easier for engineers to fix this bug by including a bold italics rendering inside the editor also.

...Thanks @mjbvz Matt!


type="simple" does not work when axis is x

it renders everything at once instead

hmmm this might be because i was using vw units but i ended up using a different library so not sure

it also doesn't work for me when using type uniform. The div that should be scrolled gets a fixed width and has its overflowX hidden


Update release page

Preview is available here:http://soroban-docs-pr262.previews.kube001.services.stellar-ops.com/


Feature/8032 ogc api features

Adds new component with two stories to add a OGC Api Feature as Geojson to the maplibre map.
In the OGC API Feature Loader story a URL can be passed to a input field to get features from a OGC API Feature Endpoint similar to the MlWmsLoader  story. The Feature can also be styled inside the story component.

The implementation looks solid.
I’m considering adding an option to either request all features upfront or dynamically request features based on the current bounding box (bbox) whenever the view changes. @MartinAlzueta and I previously developed something similar for a WFS integration.
useEffect(() => {
        if (!mapHook.map) return;

        const getDataHandler = () => {
            const southWest = mapHook.map.getBounds().getSouthWest();
            const northEast = mapHook.map.getBounds().getNorthEast();

            fetch(props.url + 'service=WFS&version=2.0.0&request=GetFeature&typeNames=' + props.typeNames + '&outputFormat=application/json'
                + '&bbox='
                + southWest.lat + ','
                + southWest.lng + ','
                + northEast.lat + ','
                + northEast.lng).then(res => {

                    return res.json()
                }).then(data => {
                    setGeojson(data);
                })
        };
        mapHook.map.on('moveend', getDataHandler)

        return () => {
            mapHook.map.off('moveend', getDataHandler)
        }
    }, [mapHook.map])

Additionally, we should introduce a configurable GeoJsonLayer properties option. This would also allow us to limit fetch requests to only trigger when the view is within a specified zoom range (minZoom and maxZoom).

I’m considering adding an option to either request all features upfront or dynamically request features based on the current bounding box (bbox)

I added a reloadFeaturesOnMapMove prop and set it to true in the point example story. When set to true, the features are dynamically requested on map move based on the bounding box. When it is not set or is false, all features are requested.

we should introduce a configurable GeoJsonLayer properties option

any MlGeoJsonLayerProps (with the exception of geojson, we need to set this based on the returning json of the ogc api request) can now be set as props for MlOgcApiFeatures. We already use this in the OgcApiLoader story:
	<MlOgcApiFeatures
		ogcApiUrl={new URL(ogcApiUrl)}
		mapId={props.mapId}
		mlGeoJsonLayerProps={{
			defaultPaintOverrides: {
				fill: { 'fill-color': color, 'fill-opacity': opacity },
				circle: { 'circle-color': color, 'circle-opacity': opacity },
				line: { 'line-color': color, 'line-opacity': opacity, 'line-width': lineWidth },
			},
			type: geomType,
		}}
	></MlOgcApiFeatures>


Removed stylesheets not being used

These stylesheets were causing import errors for consuming applications.

@erin-doyle
Cool, and V2.1.2 published


fix bad anchor links

reference: build report
Fixes 2 issues in #4649

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@spottedmahn You're on a roll! Thank you again.


Initial steps to establish and maintain cloud environment

As a Project Manager also working on dev Issues, I will want to assist in the process if setting up and enabling my team's cloud connection. I will work with the lead engineer to make this effort successful.
Story Points: 6-12

@tinpham5614 you are being moved on to this issue. Thank you!


fixed AStar improper point deletion (leads to crash)

Imagine the situation: we add p1 and p2, connect p2 -> p1 (one-way) and then remove p1. The old implementation scanned only neighbours of p1 (which was empty) and removed p1 itself thus leaving the hanging pointer in p2 neighbours. This leads to a crash during the next path search. The proper way is to scan all the points and remove the outgoing connections from their neighbours.

Please squash the style fix into the main commit, see PR workflow.

Done.

Looks good.
Is there a way to make this more performant? Not sure how often this function might be called, but iterating over thousands of points just to remove a point with no connections doesn't sound optimal.

Sure, we need to split neighbours into incoming and outgoing. This will slightly increase memory consumption but will win the speed. I just fixed the crash that was bugging me.

Well, I don't have time right not to refactor the whole class, I believe a non-crashing version is better than a crashing one?

Yeah, I think it can be merged as-is, perhaps with an issue opened for the performance thing, just so isn't forgotten.

Still needs an amend for the style issue though :)

Amended the commit with fixed style.

Thanks!


Provider doesn't respect integration limits for interfaces

Description
Interface limits set in a charm's metadata.yaml will not be respected when deploying with terraform and can cause a charm to end up with more integrations than is expected.
Urgency
Blocker for our release
Terraform Juju Provider version
0.14.0
Terraform version
1.9.7
Juju version
3.5.4
Terraform Configuration(s)
terraform {
  required_version = ">= 1.6"
  required_providers {
    juju = {
      source  = "juju/juju"
      version = "~> 0.14.0"
    }
  }
}
variable "model_name" {
  description = "Juju model name for deployment"
  type        = string
}

module "postgresql" {
  source          = "git::https://github.com/canonical/postgresql-k8s-operator//terraform?ref=main"
  juju_model_name = var.model_name
  channel         = "14/stable"
  units           = 2
}

resource "juju_application" "certificates" {
  count = 1
  name  = "certificates"
  model = var.model_name

  charm {
    name     = "self-signed-certificates"
    channel  = "latest/stable"
  }
  units  = 1
}

resource "juju_application" "certificates2" {
  count = 1
  name  = "certificates2"
  model = var.model_name

  charm {
    name     = "self-signed-certificates"
    channel  = "latest/stable"
  }
  units  = 1
}

resource "juju_integration" "postgresql_certificates" {
  model = var.model_name

  application {
    name     = module.postgresql.application_name
    endpoint = module.postgresql.requires.certificates
  }
  application {
    name = juju_application.certificates[0].name
  }
}

resource "juju_integration" "postgresql_certificates2" {
  model = var.model_name

  application {
    name     = module.postgresql.application_name
    endpoint = module.postgresql.requires.certificates
  }
  application {
    name = juju_application.certificates2[0].name
  }
}

Reproduce / Test
With a Juju k8s model:

terraform init
terraform plan
terraform apply

Both self-signed-certificates will integrate with the postgresql-k8s charm which will start failing due to the duplicate connection. The postgresql-k8s is limiting the certificates integration to 1.

### Debug/Panic Output

_No response_

### Notes & References

Status of the model after deployment:

juju status --relations
Model   Controller          Cloud/Region        Version  SLA          Timestamp
limits  microk8s-localhost  microk8s/localhost  3.5.4    unsupported  17:34:46+03:00

App             Version  Status  Scale  Charm                     Channel        Rev  Address         Exposed  Message
certificates             active      1  self-signed-certificates  latest/stable  155  <IP_ADDRESS>  no
certificates2            active      1  self-signed-certificates  latest/stable  155  <IP_ADDRESS>  no
postgresql-k8s  14.12    error       2  postgresql-k8s            14/stable      381  <IP_ADDRESS>   no       hook failed: "certificates-relation-changed"
Unit               Workload  Agent  Address       Ports  Message
certificates2/0*   active    idle   <IP_ADDRESS>
certificates/0*    active    idle   <IP_ADDRESS>
postgresql-k8s/0   error     idle   <IP_ADDRESS>          hook failed: "certificates-relation-changed" for certificates2:certificates
postgresql-k8s/1*  error     idle   <IP_ADDRESS>          hook failed: "certificates-relation-joined" for certificates:certificates
Integration provider           Requirer                       Interface         Type     Message
certificates2:certificates     postgresql-k8s:certificates    tls-certificates  regular
certificates:certificates      postgresql-k8s:certificates    tls-certificates  regular
postgresql-k8s:database-peers  postgresql-k8s:database-peers  postgresql_peers  peer
postgresql-k8s:restart         postgresql-k8s:restart         rolling_op        peer
postgresql-k8s:upgrade         postgresql-k8s:upgrade         upgrade           peer

A bundle with similar contents will not create the seconds `certificates` integration.

@dragomirp please add details on how to create the model. Unfortunately the reproducer does not use a juju_model resource as expected. Without the details I'm unable to reproduce.

@dragomirp please add details on how to create the model. Unfortunately the reproducer does not use a juju_model resource as expected. Without the details I'm unable to reproduce.

Hi, @hmlanigan, model should be a k8s model and should be a variable input.
> juju controllers
Use --refresh option with this command to see the latest information.

Controller           Model     User   Access     Cloud/Region        Models  Nodes  HA  Version
microk8s-localhost*  test-app  admin  superuser  microk8s/localhost       2      -   -  3.5.4

You should be able to create a model and apply with:
> juju add-model test-limits
> terraform plan -var model_name=test-limits
> terraform apply -var model_name=test-limits

The postgresql-k8s charm in the applied model should eventually error out due to the double certificates integration:
> juju status --relations
Model        Controller          Cloud/Region        Version  SLA          Timestamp
test-limits  microk8s-localhost  microk8s/localhost  3.5.4    unsupported  17:31:57+03:00

App             Version  Status  Scale  Charm                     Channel        Rev  Address         Exposed  Message
certificates             active      1  self-signed-certificates  latest/stable  155  <IP_ADDRESS>  no
certificates2            active      1  self-signed-certificates  latest/stable  155  <IP_ADDRESS>  no
postgresql-k8s  14.12    error       2  postgresql-k8s            14/stable      381  <IP_ADDRESS>   no       hook failed: "certificates-relation-joined"

Unit               Workload  Agent      Address      Ports  Message
certificates2/0*   active    idle       <IP_ADDRESS>
certificates/0*    active    idle       <IP_ADDRESS>
postgresql-k8s/0   error     idle       <IP_ADDRESS>         hook failed: "certificates-relation-joined" for certificates2:certificates
postgresql-k8s/1*  active    executing  <IP_ADDRESS>         Primary

Integration provider           Requirer                       Interface         Type     Message
certificates2:certificates     postgresql-k8s:certificates    tls-certificates  regular
certificates:certificates      postgresql-k8s:certificates    tls-certificates  regular
postgresql-k8s:database-peers  postgresql-k8s:database-peers  postgresql_peers  peer
postgresql-k8s:restart         postgresql-k8s:restart         rolling_op        peer
postgresql-k8s:upgrade         postgresql-k8s:upgrade         upgrade           peer

The issue should be reproducible with other charms that set requires limit. I don't know if provides limit is affected.

Fix committed in Juju - will be part of the 3.6.1 release.


Please use a heuristic to determine if ".inc" files are php files

There is a large body of code in my organization's repository that uses .inc to represent php code that should not be executed directly by the php yapache module.
Could you add a heuristic that will look through .inc files for <?php and trigger php mode for them? Thanks!

Thanks for reporting this. We're actually working on this issue over in https://github.com/github/linguist/pull/1770


[21121] IPayloadPool refactor

Description
This PR updates the code examples that implement a CustomPayloadPool after the changes in IPayloadPool and derived classes.

It must be merged after: https://github.com/eProsima/Fast-DDS/pull/4892

Contributor Checklist

[X] Commit messages follow the project guidelines.
[X] Code snippets related to the added documentation have been provided.
[X] Documentation tests pass locally.
N/A Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[ ] CI passes without warnings or errors.

@richiprosima Please test_3 docs

@richiprosima Please test_3 docs


MenuItem's objc pointer is private

I recently found that the objc pointer held in cacao::appkit::menu::MenuItem is private when i want to do sth on the objc side.
Does anyone know why it's private?

I'm confused - are you talking about this?
https://github.com/ryanmcgrath/cacao/blob/e3bbb9366c8cf5a5474c5b134ae60e9641da3b7b/src/appkit/menu/item.rs#L93
I feel like you should be able to just match on that enum and handle accordingly.

That's exactly what i want to say. My code works fine now. Thanks!


[Question] 'pdfjs-dist' repo not updated anymore?

I've noticed that the pdfjs-dist repo is currently on v2.0.489, while there's already v2.0.550

For version 2.0 we're no longer updating pdfjs-dist after every commit (refer to #9440). The reason is that in that case it's in a sense a "nightly build" and can be unstable, but anything on NPM without flags like @next should be considered stable. Instead, we're now only going to update pdfjs-dist for every formal release, and that is tracked in #9440 too.


Twitchy Name Change To "TTV Desktop Lite"?

Copyright issues and whatever, name change might be required.
If the change is happening, we need to rename EVERYTHING from the ground up with the new name.
Suggestions are always welcome and can be posted below!

TTV sounds good so far. Best of luck, guys!

My recent commit should include all necessary name changes.  If we find any remaining "Twitchy's", just silently replace them.
Closing.


Connection pooling

I'm going to take a crack at implementing an HTTP connection pool. I may try to get a PR up tonight. I just wanted to put a bookmark here since it's a significant change to the connection architecture. Let me know if you have any concerns!

Success! I put up a PR at #165.


Keep track of class URI from where a given class API was generated

This simplifies checking if everything is as expected and keeps provenance info

We need to add to the generated javadoc @see or @link elements to point to original concept/endpoint/named graph location


Feature/297 remove color gradient

Remove color gradient for casing and replace with solid color

Removed some unused vars. Anything else we talked about during code review that should be changed @ooystein?


Positional Audio? How integrate in Unity Project?

In README you say:
Different audio positions for each Mumble speaker is not yet supported, but is possible
How can integrate this feature in little Social Demo?
My project is Open Source and based on Unity 5.6.1f1.
Thanks for your work and help!

I'm going to remove that line.
If you take a look at MumbleTester, you'll see that when creating the mumble client you pass a method "CreateMumbleAudioPlayerFromPrefab". This method is called whenever a new user is in the Mumble room. It's here that you can make the new mumble audio player be a child object to something, and change its positional.
Let me know if you have any other questions, or if I can close this

Thank you for your answer. So I had to modify this method to create a child object of my user/avatat head using: http://answers.unity3d.com/questions/572176/how-can-i-instantiate-a-gameobject-directly-into-a-1.html ?
 private MumbleAudioPlayer CreateMumbleAudioPlayerFromPrefab()     {         // Depending on your use case, you might want to add the prefab to an existing object (like someone's head)         // If you have users entering and leaving frequently, you might want to implement an object pool         GameObject newObj = GameObject.Instantiate(MyMumbleAudioPlayerPrefab);         MumbleAudioPlayer newPlayer = newObj.GetComponent<MumbleAudioPlayer>();         return newPlayer;     }

Yep, that's the one. I'll make some changes to the README to make that more clear. Feel free to reopen or make a new ticket if anything else is unclear


Feature proposal: Query Fragments

What do you want to change?
I'd like to be able to define part of a query, and then reuse that in other queries. I've called it fragments.
This is handy as it reduces duplication in the query, but also helps reduce mistakes and duplication when passing arguments into queries where fragments are used.
-- name: WorkspaceCheck :fragment
workspace_id = sqlc.arg(workspace_id) AND livemode = sqlc.arg(livemode)

-- name: GetThing :one
SELECT * FROM things WHERE id = sqlc.arg(id) AND sqlc.fragment(WorkspaceCheck)

Ideally, I would like this to produce a params struct with an embedded set of params.
type GetThingParams struct {
  ID             string
  WorkspaceCheck WorkspaceCheckFragmentParams
}

The reason I'm in favour of embedding (rather than inlining) is because it makes it simpler to callers who are most likely abstracting out those params anyway. For example, we can make our auth library produce these params, and pass them into the query on a single line.
I don't really mind how or where fragments are defined, I went with the above as its just a familiar form and easy to explain. I imagine its a probably non-starter as I'm guessing it makes the query file un-parsable.
I've not looked at what it would take to build this, but I would definitely consider it if this was a likely-merge.
Thanks!
What database engines need to be changed?
PostgreSQL
What programming language backends need to be changed?
Go

A colleague of mine has brought up a concern with this approach that I had not considered.
What happens to the generated FragmentParams if you were to use the same fragment across two different tables and the argument types are slightly different?
I guess the solution to this is to have a fragment param for every table, e.g. ThingWorkspaceCheckFragmentParams perhaps falling back to a single type if they are comparable.

I see this too as a way to reuse queries. An example being if you commonly join 2 tables. It is not ideal to have to copy this join across multiple queries if your select statements differ.
Ideally you could define a query as a fragment or something.
The current workaround is to define it as a view, but you cannot use things such as sqlc.embed in a view. :cry:

Instead of adding a new sqlc.xxx function, I've been thinking about adopting the a templating system as a preprocessor step. Jinja2 supports macro definitions, which should solve your issue without us introducing any new special syntax. Your example you look the the following:
{% macro workspace_check %}
    workspace_id = sqlc.arg(workspace_id) AND livemode = sqlc.arg(livemode)
{% endmacro %}

-- name: GetThing :one
SELECT * FROM things WHERE id = sqlc.arg(id) AND {{ workspace_check() }}

Would that solve your issue?

I have done a very similar thing with Go templates before feeding to SQLc while experimenting.
The only downside to the macros is you lose SQL highlighting :cry:. But it does provide a general way to handle this :+1:

Go templating (or something similar) in sqlc would be incredibly useful.
Consider the following:
SELECT * FROM myTable {{- if sqlc.nslice('ids') != nil -}} WHERE id IN (sqlc.nslice('ids')) {{- end -}}
You could imagine in a more complicated query with a larger set of parameters this would be critical to avoid having to create a new query for every possible permutation.

Before SQLC I'd always use go templating with sqlx, it was a pretty good DX, so if anything I'd prefer go's native templating language.

Go templating (or something similar) in sqlc would be incredibly useful.
Consider the following: SELECT * FROM myTable {{- if sqlc.nslice('ids') != nil -}} WHERE id IN (sqlc.nslice('ids')) {{- end -}}
You could imagine in a more complicated query with a larger set of parameters this would be critical to avoid having to create a new query for every possible permutation.

I've done this approach as well, but you'd lose your source code being valid SQL. Right now that is a huge upside to SQLc.

Bumping this for visibility -- we use sqlc heavily and we are concerned about maintaining duplicated queries with slightly different WHERE clauses.

@druvv you can do CASE WHEN statements to not have to duplicate queries for different WHERE cases. You can see an example of how we do it at Coder:
https://github.com/coder/coder/blob/068549b369e2fa5927074c7ff8be14c228f498af/coderd/database/queries/workspaces.sql#L232-L237

Sorry if I'm asking a trivial question, but why not use postgres functions?

Sorry if I'm asking a trivial question, but why not use postgres functions?

Does SQLc know how to inspect functions?
Regardless, a function is still much heavier than what is requested. A function requires a migration, and mutating that function requires a REPLACE the old funcition.
At present, all queries are generated client side, so making changes is trivial and does not require changing the DB schema.

I believe this feature will be useful. I also have a usecase where I have three type of queries, list, count and sum.
SELECT * FROM bookings WHERE criteria_a = 'a' AND criteria_b = 'b';
SELECT COUNT(*) FROM bookings WHERE criteria_a = 'a' AND criteria_b = 'b';
SELECT SUM(amount) FROM bookings WHERE criteria_a = 'a' AND criteria_b = 'b';

I have more than 10 where condition on that queries. Maintaining those three queries sync is a bit cumbersome.


made the register page responsive

i just improved the responsiveness of the register page
before:

Now:

thank you

@aswathcm29  please add level to this pr  else no points will be allocated for this pr

@aswathcm29   i am one of the program managers of gssoc-ext. can you please add relevant level label for this pr.

This PR has been merged by the GSSoC team
here - https://github.com/sanjay-kv/Open-source-Practice/pull/1419
Don't add labels to it now.You'll get the points in the leaderboard update.

This PR has been merged by the GSSoC team here - sanjay-kv/Open-source-Practice#1419
Don't add labels to it now.You'll get the points in the leaderboard update.

you havent add any level

Added there.
No need to add here.


Fix stats (Antall per domene)

Fix stats (Antall per domene) to be per university. Currently, the stats says the whole domain, i.e. ifi.uio.no, but I want it to say only the last part of the domain, i.e. uio.no

Fixed in 7ae9c65c3f :)


Networkrb

This cherry picks from #624.
However, while the unit tests pass, the doctests in https://github.com/pysal/pysal/blob/master/pysal/network/network.py will fail and need to be fixed. They evidently were not tested before the merge?
See https://github.com/pysal/pysal/blob/master/pysal/network/network.py#L253
counts isn't defined in the scope of that doctest. there are other failures as well.
We shouldn't merge this until

we agree that we have the right commits here from #624
the doctests are fixed

Thanks for cherry picking... these are the only two commits I had intended for #624.

Working on doctests now.
On Sun, Jun 14, 2015 at 3:33 PM, David C. Folch<EMAIL_ADDRESS>wrote:

Thanks for cherry picking... these are the only two commits I had intended
for #624 https://github.com/pysal/pysal/pull/624.
—
Reply to this email directly or view it on GitHub
https://github.com/pysal/pysal/pull/627#issuecomment-111880493.

Doc tests are fixed.  I pulled this PR locally to make the changes using:
git checkout -b sjsrey-networkrb master
git pull https://github.com/sjsrey/pysal.git networkrb
Any thoughts on how to update this PR from my side?
On Sun, Jun 14, 2015 at 3:46 PM, Jay L<EMAIL_ADDRESS>wrote:

Working on doctests now.
On Sun, Jun 14, 2015 at 3:33 PM, David C. Folch<EMAIL_ADDRESS>wrote:

Thanks for cherry picking... these are the only two commits I had
intended for #624 https://github.com/pysal/pysal/pull/624.
—
Reply to this email directly or view it on GitHub
https://github.com/pysal/pysal/pull/627#issuecomment-111880493.

@jlaura If it will make life easier, we can reject this PR (and #624).  You can put the network doctest fixes into its own PR (or add them to #628), and then I'll resubmit the topology stuff under a new PR after pulling those fixes.

As a note - until the open PR for doc-tests is merged, it is going to be necessary to pull this PR locally and manually run the doctests to verify.

@jlaura we could keep the doctests separate for now, rather than have multiple prs hanging around waiting for another one to get closed. So once you and @dfolch are ok with the network related commits in this pr, this could be merged. Then we can revisit what to do about doctests in the upstream/travis testing. One option for the latter would be to have devs run doctests locally before a pr (as well as the unit tests) but leave the doctests off in travis.

I think it would be safest to turn the doctests back on in travis (once everything is fixed).  I talked to @pedrovma and he is good with changes to spreg needed to get all the tests to pass. I'll submit a PR now to fix spreg.
@jlaura let me know if you have any questions about the topology stuff.  Here is a zoom-in on major roads in Rhode Island.  "Before" (without rounding and removing duplicate segments) and "after". The red dots are what pysal identifies as intersections, the blue lines are actual roads and the grey lines are graph edges.


Error: roslaunch turtlebot3_dqn turtlebot3_dqn_stage_1.launch

Hi :)
I got an error while executing the command
roslaunch turtlebot3_dqn turtlebot3_dqn_stage_1.launch
Error:
IOError: [Errno 21] Is a directory: '/home/cow/catkin_ws/src/turtlebot3_machine_learning-develop/turtlebot3_dqn/src/turtlebot3_dqn'
[turtlebot3_dqn_stage_1-1] process has died [pid 14409, exit code 1, cmd /home/cow/catkin_ws/src/turtlebot3_machine_learning-develop/turtlebot3_dqn/nodes/turtlebot3_dqn_stage_1 __name:=turtlebot3_dqn_stage_1 __log:=/home/cow/.ros/log/bc24a084-93e0-11e8-b6dd-34e6addf1aec/turtlebot3_dqn_stage_1-1.log].
log file: /home/cow/.ros/log/bc24a084-93e0-11e8-b6dd-34e6addf1aec/turtlebot3_dqn_stage_1-1*.log
all processes on machine have died, roslaunch will exit
shutting down processing monitor...
... shutting down processing monitor complete
done

I have followed the installation in the e-manual.
Also cloned the package into catkin_ws/src ,then executed catkin_make.
Look forward to your reply ;)

Hi @harry21105 :)
Now your package folder name is 'turtlebot3_machine_learning-develop'.
Change the this name you cloned to 'turtlebot3_machine_learning'.
Thanks,
Gilbert.

Sorry does not understand :(
You mean rename the folder 'turtlebot3_machine_learning-develop'
to 'turtlebot3_machine_learning' ?

hi, problem is solved :)
Thank you!


removed commented code in config.ru and added sidekiq config in routes

Summary

Removed unused commented code at config.ru
Added config to make the sidekiq routes private in routes
Fixes #49

Ping here @francoprud @hdf1986 @leoncalermo


compliance report should include query and response messages.

From: Jerome Kelleher
I agree with @calbach that it would be very helpful for the HTML test reports to contain the
actual messages transferred. This was a genuinely useful part of the old compliance tests.

Took a good look at this today. It's feasible and certainly useful. For some of the tests hundreds of megabytes are transferred, so these logs can be quite long! There is a little bit of coaxing the JUnit reporter into displaying the results in a useful way.

I have a first draft of this feature here: https://github.com/david4096/compliance/tree/trafficlogs
It currently uses the approach of naming traffic log files after their respective tests. By customizing the XSLT for generating reports I'm able to link to the traffic logs for each test separately. Sometimes the traffic logs can be quite long!
There are a few edge cases that make this approach problematic: when tests have the same name across namespaces or when there are special characters in the file name.


User see only his Map

in the #maps user see only those maps he is participant of.

what about mediators/admins?
how we can add users to new maps? etc


Feature request: Toggle diagnostic panel

Hi Tom, I have a suggestion.
Right now I have a keyboard shortcut to open the diagnostic panel ctrl+shift+m.
As you can see. When I open the panel with that keybinding, and press the keybinding again the panel is still visible.

Wouldn't it be better if the panel could be toggled like this? :)

If the answer is yes? I have already done that and I could create a pull request if you want :)

Hi, agree this sounds useful! Thanks for the examples as well.
Looking forward to a pull request!


Add clean-results option

@unickq Hello, I can't assign you or add you to reviewer for this PR, so I tagging you in comments)
Could you please give watch PR and give comments?


fix instructions for contributing to lib.d.ts

@mhegazy

Tried running jake lib in the #5461 commit, didn't work then either :wink:

Tried running jake lib in the #5461 commit, didn't work then either :wink:

how is that? what did you see? any errors?

You don't even need jake lib to update the built/local data, just running jake after changing src/lib files updates that fine (as I expect running jake with no arguments to do).
But, when I run jake lib I don't think it's out of scope to assume lib would be updated.
In the instructions: "To build the library files" obviously means the files in lib/ (except it doesn't).  The README in lib/ says these files are not meant to be updated by hand, and changes should be made in src/ but nowhere is it documented that the command is jake LKG.
Can you not see how this is confusing?

i see.  well in my defense, \lib was called \bin and that was less confusing..
Any how, so we can make it jake local or just 'jake`, how about that?

(hmm... musing) perhaps /bootstrap ( or /bs ? ) would be a better name?

looks good. thanks!


Extend backend-agnostic vc functionality

this PR defines a few interactive commands that automatically resolve to magit-provided functionality if magit is enabled, and the current repository is backed by git, or vc-provided functionality otherwise. Existing evil/emacs keybindings have been changed to map to the new backend-agnostic functions. Seems to work, though I yet have to try out +vc/file-delete.
When calling magit-specific functionality, I currently (require 'magit) explicitly at function call time to make sure the desired command is actually available. While this works, it's definitely not elegant. I guess there is some better way to achieve the same result?

This needs some more thought. If :emacs vc is disabled, then nothing on the SPC g prefix will work, regardless of :tools magit's status.
The dispatchers should also be autoloaded and be renamed to follow our naming conventions. X/Y is reserved for interactive commands.
I'm swamped at the moment, so I'll get back to this when I can.

alright, I'll have a look and I understand the workload required to maintain doom must be pretty massive. Thanks for your comments!


Edit commands

Signed-off-by: Gonzalo Garramuño<EMAIL_ADDRESS>This commit is for:
Implements #1649.
Makes PR #1518 obsolete.
It implements edit commands in the otio::algo:: namespace.  The commands implemented are those discussed in #711.
They are further explained more clearly in:
https://github.com/mccartnm/OpenTimelineIO/blob/openedit_design/docs/design/editorial_design.md
Summarize your change.
It implements the needed base commands for editing with otio, building on top of @darbyjohnston's PR.
@darbyjohnston 's PR #1518 was the base for it, but I debugged two subtle precision bugs in his code and moved it all to the algo:: namespace.
Implementation also modifies errorStatus.h/cpp to add NOT_A_GAP enum.
Implementation, as @darbyjohnston's, makes Composition's protected _index_of_child a now public member of the API as index_of_child and updates track.cpp accordingly.
Reference associated tests.
test_editAlgorithm.cpp is added as in @darbyjohnston, but with tests for all commands.

Codecov Report

Merging #1650 (b5667d8) into main (eaf8569) will decrease coverage by 0.01%.
The diff coverage is 23.07%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1650      +/-   ##
==========================================
- Coverage   79.91%   79.90%   -0.01%
==========================================
  Files         197      197
  Lines       21731    21733       +2
  Branches     4339     4340       +1
==========================================
  Hits        17366    17366
- Misses       2213     2215       +2
  Partials     2152     2152

Flag
Coverage Δ

py-unittests
79.90% <23.07%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

src/opentimelineio/composition.h
41.37% <ø> (ø)

src/opentimelineio/errorStatus.cpp
28.33% <0.00%> (-0.98%)
:arrow_down:

src/opentimelineio/errorStatus.h
86.95% <ø> (ø)

src/opentimelineio/track.cpp
52.85% <0.00%> (ø)

src/opentimelineio/composition.cpp
47.58% <30.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf8569...b5667d8. Read the comment docs.

This looks pretty cool! Have incorporated these commands into an app, or have they been exercised through the unit tests, so far?

Have incorporated these commands into an app, or have they been exercised through the unit tests, so far?

For the time being, only the unit tests, which I tried to be thorough.  Darby is working on adding a GUI front end to tlRender and he may be incorporating these commands.


Can I use groups instead of roles?

My company has disabled the ability for anyone to app App Roles to users. This is not something I'm going to be able to change. However they have a process where you can get into groups. The guids for these Groups show up in the auth tokens created when the user authenticates with code flow with the App Registration.
Is there anyway for me to configure this tool to look for a users Groups instead of Roles?

Hi @justinmchase , I'm afraid, at the moment the only way to achieve that would be to clone this repo and then modify the token validation code here accordingly.
Then you can deploy your code version from sources, just like you would deploy any other Azure Functions project.
But I would still recommend to configure AppRoles-to-Groups mapping instead of using groups themselves. A user (especially in large companies) can easily be a member of dozens of groups, so the token might get pretty large. Also it might not be a good idea to even expose the whole list of your groups via a token (remember, tokens are not encrypted). Those were two most important reasons for introducing app roles, but there many other reasons...

I would also like to do that alas or AD admins forbid it...

Would you be open to a Pull Request to enable it in main?

@justinmchase , can you see yourself in the list of owners of this Enterprise App (on the Owners tab) ?
If not, can you check with someone who is an owner whether they can access this Add user/group button?
Or maybe they could add you there as an owner there?..

It was fairly tricky but I managed to figure it out. I thought it was my company intentionally blocking it but actually it was because I created the App Registration from another app registration it didn't automatically assign owners as I would have expected. That other app registration is able to modify the one in question except its unable to assign owners to the Enterprise Application (aka Service Principal). But you can create a secret, then use that to log in as the SP and then assign owners to yourself. From there the standard UI for manually defining and adding roles to users and groups works as expected.
I'm sort of multiple layers separated from the admins in my company and it can be hard to ask questions like this sometimes, but I managed to figure it out, thanks!


error: 12(F)(3)

Chapter 12 part F, question 3, the tree in the answer key is incorrect. It is marked as a completed open tree, but it is not complete, as the b instance of line 1 has not been taken. Indeed, this will turn out to be an infinite tree.

Corrected in 1.2


Black/Empty content when using CubeOutTransformer

I am using a stateless adapter for my viewpager and have applied CubeOutTransformer. When I open and close the viewpager after sometime the screen becomes black/empty with no content.
I have to close the app and reopen for the animation to work again.
I can easily recreate this issue on my app. Can you please help me figure out what is going wrong with my implementation?
Thanks

I managed to resolve this issue, there were other gestures in my viewpageradapter which were messing with the transformer.


Use portable-atomic

That would make it possible to use this crate on bare-metal targets that do not natively support atomics.
atomic-waker already does that, so why not here either?

I would accept a PR adding this.

Perfect - I'll work on that!

Closed in #58


e2e: miscelanious changes for testing on OpenShift

While working on adding NFS-provisioner tests to the e2e suite, I found several
obstacles that prevented executing the tests on OpenShift. A couple of the
improvements to the e2e suite are included in this PR. There should not be any
functional changes to the current e2e tests, as defaults are unmodified.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

/retest ci/centos/k8s-e2e-external-storage

/retest ci/centos/k8s-e2e-external-storage

Failed during Rook deployment.

@mergifyio refresh

@mergifyio rebase

@mergifyio refresh

@Mergifyio rebase

@Madhu-1 @humblec, manually rebased as Mergify had troubles for some reason... Needs re-review.

/retest ci/centos/mini-e2e/k8s-1.21

/retest ci/centos/mini-e2e/k8s-1.21

Failed to deploy Rook and the Ceph cluster

/retest ci/centos/mini-e2e-helm/k8s-1.21

@mergifyio refresh

/retest ci/centos/k8s-e2e-external-storage/1.23

@mergifyio requeue

/retest ci/centos/k8s-e2e-external-storage/1.23

Failed to deploy Rook:
Error from server: error when creating "/tmp/tmp.Op8Xc4vFfx/cluster-test.yaml": etcdserver: request timed out

@Mergifyio requeue

/retest ci/centos/mini-e2e-helm/k8s-1.21

Apr 12 14:01:07.124: backend images not matching kubernetes resource count,image count 23 kubernetes resource count 21

https://jenkins-ceph-csi.apps.ocp.ci.centos.org/blue/organizations/jenkins/mini-e2e-helm_k8s-1.21/detail/mini-e2e-helm_k8s-1.21/3353/pipeline


Undefined array key "file_ext"

Hello,
Since I upgrade piwigo and PHP, I cannot see my pictures.
I try with another theme and it works.
So, I deleted all my pictures.
But when I re upload one file, the issue still exists.
This is my new environment info :
Piwigo 12.3.0
Système d'exploitation: Linux
PHP: 8.0.21
MySQL: 10.3.35-MariaDB
Bibliothèque graphique: ImageMagick 7.1.0-20

Could you have any idea for fix it ?
I am sad because I like your theme.
Thanks you.
Best regards,
Cedric

Hello,
I find a way to fix my issues.
I downgraded my PHP version to 7.4 and it works fine.
Sorry to bother you with this.
I will close the issues.


Leaderboard

Created a separate issue for the trending markets section https://github.com/zeitgeistpm/ui/issues/1767


NLLB inference time model loading fails due to inconsistent vocabulary size

Hi, I downloaded the dictionary and 600M NLLB-200-Distilled checkpoint. I failed to load model weights from the checkpoint due to inconsistent vocabulary size.
The dictionary has 255997 tokens and the model supports 202 languages, thus there is an extra of 202 tokens for language tokens. So the total number of tokens for embedding martix should be 255997+202+4=256203,  where 4 stands for     symbols. However, the embedding matrix from the checkpoint file is of size 256206, making it incompatitble with the model structure built at evaluation time. The number 256206 is not divisible by 8, so the extra 3 symbols are also not dummy makeupwords.
I'm wondering what's the cause of the problem.
Here is the message I got:
RuntimeError: Error(s) in loading state_dict for TransformerModel:
        size mismatch for encoder.embed_tokens.weight: copying a param with shape torch.Size([256206, 1024]) from checkpoint, the shape in current model is torch.Size([256203, 1024]).
        size mismatch for decoder.embed_tokens.weight: copying a param with shape torch.Size([256206, 1024]) from checkpoint, the shape in current model is torch.Size([256203, 1024]).
        size mismatch for decoder.output_projection.weight: copying a param with shape torch.Size([256206, 1024]) from checkpoint, the shape in current model is torch.Size([256203, 1024]).

There are three additional tokens in the vocabulary that we add during training. Here is a response related to this :
https://github.com/huggingface/transformers/issues/18043#issuecomment-1179317930
More specifically here are the additional fine-grained data source tokens we add :
https://github.com/facebookresearch/fairseq/blob/nllb/fairseq/data/multilingual/multilingual_utils.py#L14-L18

There are three additional tokens in the vocabulary that we add during training. Here is a response related to this :
huggingface/transformers#18043 (comment)
More specifically here are the additional fine-grained data source tokens we add :
https://github.com/facebookresearch/fairseq/blob/nllb/fairseq/data/multilingual/multilingual_utils.py#L14-L18

Thank you, that works. But the response you referred to says that there are 4 extra tokens prepended to the vocabulary rather than 3. Is that still a mistake? Besides, the internal Fairseq dictionary link he provided is inaccessible, so I can't check the implementation.

@pluiez  In that post, jhcross means

0 ->
1 ->
2 ->

is wrong. In fairseq dictionary, it is
0 -> <s>
1 -> <pad>
2 -> </s>
3 -> <unk>

So a simply loaded spm in huggingface tokenizer will result in a wrong input ids.

@gmryu Really appreciate your explanation, now it's all clear to me.

Hi, I downloaded the dictionary and 600M NLLB-200-Distilled checkpoint. I failed to load model weights from the checkpoint due to inconsistent vocabulary size.
The dictionary has 255997 tokens and the model supports 202 languages, thus there is an extra of 202 tokens for language tokens. So the total number of tokens for embedding martix should be 255997+202+4=256203, where 4 stands for symbols. However, the embedding matrix from the checkpoint file is of size 256206, making it incompatitble with the model structure built at evaluation time. The number 256206 is not divisible by 8, so the extra 3 symbols are also not dummy makeupwords.
I'm wondering what's the cause of the problem.
Here is the message I got:
RuntimeError: Error(s) in loading state_dict for TransformerModel:
        size mismatch for encoder.embed_tokens.weight: copying a param with shape torch.Size([256206, 1024]) from checkpoint, the shape in current model is torch.Size([256203, 1024]).
        size mismatch for decoder.embed_tokens.weight: copying a param with shape torch.Size([256206, 1024]) from checkpoint, the shape in current model is torch.Size([256203, 1024]).
        size mismatch for decoder.output_projection.weight: copying a param with shape torch.Size([256206, 1024]) from checkpoint, the shape in current model is torch.Size([256203, 1024]).

hello，how did you solve this problem when inferencing?

@wenHK could you make sure you are passing the flag --add-data-source-prefix-tags at inference time?

There is no --add-data-source-prefix-tags in the fairseq latest version. I met the similar problems.

@wenHK could you make sure you are passing the flag --add-data-source-prefix-tags at inference time?

[--add-data-source-prefix-tags ](fairseq-interactive: error: unrecognized arguments: --add-data-source-prefix-tags)

@wenHK could you make sure you are passing the flag --add-data-source-prefix-tags at inference time?

[--add-data-source-prefix-tags ](fairseq-interactive: error: unrecognized arguments: --add-data-source-prefix-tags)

@gdxie1 This option is only available in nllb branch, thus you need to checkout the branch to run inference.


Remove unnecessary notPaused modifiers

It's not necessary to have the notPaused modifier on safeTransferFrom because the notPaused modifier already exists on the transferFrom function.
Removing it saves an SLOAD (100 gas).

excellent catch!


[.NET] Fallback support

Spec: #2019
Fixes: #2418
Parse-Time Changes
This is a big one. Basically, before Fallback could even be created, a few things had to be created and changed:

Adding AdaptiveUnknownElement/AdaptiveUnknownAction:

Now, any elements/actions that aren't recognized are serialized into these types. We fill what we can for AdaptiveTypedElement (i.e.: type, fallback, id, etc.) and the rest gets thrown into AdditionalProperties

Adding Requires:

mostly just copied over from the SharedModel

ParseContext:

This is a static class used at parse-time to keep track of 2 things:

Are we deserializing an element or an action? Handled by ContextType. Used to identify whether we create an AdaptiveUnknownElement or an AdaptiveUnknownAction
ID Collision. This is really different now that there's fallback. It's implemented as close to the SharedModel version as possible. However, one of the tests on ID collision are failing because they are mis-identifying an ID collision and I can't figure out why. More details in "Known Bugs" at the end.

Fallback:

Deserialization handled in AdaptiveFallbackConverter::ParseFallback(). Can't use the regular ReadJson() function because objectID and internalID need to be passed down.
Serialization should be handled in AdaptiveFallbackConverter::WriteJson() but the bug makes that not be the case.

HTML and WPF Rendering
In general, adding a check for AdaptiveUnknownElement/Action in AdaptiveElementRenderers.cs just happened to make life easier. Now we return a null renderer, which means that in AdaptiveRenderContext.cs, we just look out for that and begin conducting fallback.
Rendering fallback content in an AdaptiveUnknownElement works. And it looks nice too.
Rendering fallback content in an AdaptiveUnknownAction hasn't been added. More details in "Known Bugs" below.
Known Bugs

AdditionalProperties still holds a copy of fallback: this is just wasted space. It occurs because we're manually deserializing fallback. I'm sure the change would have to be added into HandleAdditonalProperties() somehow.
Requires XML Serialization: I think we need to create a custom way to serialize the dictionary in XML. From what I saw online, there isn't a built-in attribute that we can use :(
Render fallback content for an AdaptiveUnknownAction: basically, we depend on knowning how many actions we have to be able to split the space evenly between them. Now with fallback, we need to preparse the list of actions and see how many we actually have. Take a look at AdaptiveActionSetRenderer.cs and how actionsToProcess is created. My guess is we'll have to make a few more changes to GetActionsToProcess().

/AzurePipelines run

Can we start to add a "How Verified" section in our descriptions as well? thanks

@paulcam206 whats the status on this one?

Only thing left outstanding is final wiring so that the renderers fallback on requires. Hope to have that done this evening.

Can we start to add a "How Verified" section in our descriptions as well? thanks

Hey Paul, any snips of cards etc that may show how things look visually in the "How Verified" section would be useful for subsequent validation (Eg bug bashes etc)

            if (new AdaptiveSchemaVersion(jObject.Value<string>("version")) > AdaptiveCard.KnownSchemaVersion)

Lots of hard coded literals in the code -- we should consider consolidating the strings in a Constants class or something instead of spewing them all over the code base

Refers to: source/dotnet/Library/AdaptiveCards/AdaptiveCardConverter.cs:48 in a782455. [](commit_id = a78245532f6d28b6c6692032740d250f53f7bc5c, deletion_comment = False)

        var card = (AdaptiveCard)typedElementConverter.ReadJson(jObject.CreateReader(), objectType, existingValue, serializer);

NIt: Consider resorting to the 'as' operator for casting. https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/as

Refers to: source/dotnet/Library/AdaptiveCards/AdaptiveCardConverter.cs:55 in a782455. [](commit_id = a78245532f6d28b6c6692032740d250f53f7bc5c, deletion_comment = False)

Is this still pending?

In reply to: 485039280 [](ancestors = 485039280)

This is now done :)

In reply to: 486436276 [](ancestors = 486436276,485039280)

            if (new AdaptiveSchemaVersion(jObject.Value<string>("version")) > AdaptiveCard.KnownSchemaVersion)

filed #2746 to cover this

In reply to: 486427259 [](ancestors = 486427259)

Refers to: source/dotnet/Library/AdaptiveCards/AdaptiveCardConverter.cs:48 in a782455. [](commit_id = a78245532f6d28b6c6692032740d250f53f7bc5c, deletion_comment = False)

        var card = (AdaptiveCard)typedElementConverter.ReadJson(jObject.CreateReader(), objectType, existingValue, serializer);

Filed #2747

In reply to: 486427423 [](ancestors = 486427423)

Refers to: source/dotnet/Library/AdaptiveCards/AdaptiveCardConverter.cs:55 in a782455. [](commit_id = a78245532f6d28b6c6692032740d250f53f7bc5c, deletion_comment = False)

        if (string.IsNullOrEmpty(fontFamilyValue))

Again this one seems like it should be isNullOrWhiteSpace()

Refers to: source/dotnet/Library/AdaptiveCards/Rendering/AdaptiveHostConfig.cs:170 in a782455. [](commit_id = a78245532f6d28b6c6692032740d250f53f7bc5c, deletion_comment = False)

    // TODO: temporary warning code for fallback card. Remove when common set of error codes created and integrated.

Do we have an issue# tracking this work? If so mind doing me a favor and adding a TODO: Issue#<> reference here? tx

Refers to: source/dotnet/Library/AdaptiveCards/AdaptiveCardConverter.cs:14 in a782455. [](commit_id = a78245532f6d28b6c6692032740d250f53f7bc5c, deletion_comment = False)

            return _dictionary[typeof(AdaptiveAction)];

while you are here mind updating these 3 blocks with {} as well? tx!

Refers to: source/dotnet/Library/AdaptiveCards/Rendering/AdaptiveElementRenderers.cs:42 in a782455. [](commit_id = a78245532f6d28b6c6692032740d250f53f7bc5c, deletion_comment = False)


Added a comment to webhook

@basma-msft : Thanks for your contribution! The author, @v-miclar, has been notified to review your proposed change.

sign-off

#sign-off
Please close this issue.

@basma-msft - just checking that the insertion should be inside the code block as you've placed it. It looks to me as though the code block terminator ``` should come just after the final " } " on line 798. Can you confirm it's okay as is or move the code block terminator?
Otherwise this is ready for merge.
Thanks.

Yes you are right, should be inside code block. Thanks!
On May 14, 2019 12:43, Jak Koke<EMAIL_ADDRESS>wrote:
@basma-msfthttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbasma-msft&data=01|01|bakhan%40microsoft.com|f0330aeecbc54d04cb1008d6d8a47a91|72f988bf86f141af91ab2d7cd011db47|1&sdata=rteTKbi4TeOMG8zxf%2BRzgWl5PuprwYmk3Ox6dpPAdcY%3D&reserved=0 - just checking that the insertion should be inside the code block as you've placed it. It looks to me as though the code block terminator ``` should come just after the final " } " on line 798. Can you confirm it's okay as is or move the code block terminator?
Otherwise this is ready for merge.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fpull%2F31139%3Femail_source%3Dnotifications%26email_token%3DAL5VWDE4NYB2HII5CUQNU2LPVMI7DA5CNFSM4HMTT3HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVMSLOQ%23issuecomment-492381626&data=01|01|bakhan%40microsoft.com|f0330aeecbc54d04cb1008d6d8a47a91|72f988bf86f141af91ab2d7cd011db47|1&sdata=MAGZw08%2BNU%2FxGDLvzcvON4jFSWiyHEqZkGjRhOOgcJI%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAL5VWDDJXVHUHJQV5GZEGJDPVMI7DANCNFSM4HMTT3HA&data=01|01|bakhan%40microsoft.com|f0330aeecbc54d04cb1008d6d8a47a91|72f988bf86f141af91ab2d7cd011db47|1&sdata=8I5djUyp%2BdOEfmGeEy3Dkg6AqREaRHoaCMr4v7N0fy4%3D&reserved=0.


Support for Mobile

Added support for mobile authentication. Tested using the Ionic framework and Facebook, Google, already used in production. It includes an example under the examples folder examples/ionic.
Noticeable changes:

Added a configuration option "platform" that defaults to "browser". If "mobile" is provided, it listens to the loadstart event rather than use the polling method.

Things remain to be done:

Only OAuth2 supported, no work/testing was done for OAuth1.
Update the README.md with instructions for mobile.

If you are interested in integrating this, I can provide steps to test.

@krystalcode - Thank you for these changes. I'll be using your fork until the changes are merged.

Thanks for the PR. I will add more OAuth example to Ionic over the weekend.

I integrated the social authentication to my Ionic app and it works perfectly ,but when i added crosswalk it do not work , how can i fix this , thanks

Hi @bigali , I haven't gotten into crosswalk yet so I haven't tested it. Any debugging information would be helpful, at which step of the process does it fail?
If you provide steps with how to test with crosswalk (incl. what do I need to do to enable crosswalk), or a link to a guide, I will test it when I get some time.

hi @krystalcode ,to add crosswalk use ionic cli, "ionic browser add crosswalk",  you can use chrome dev tools (chrome://inspect)  to debug the app ,  https://www.youtube.com/watch?v=57hsxvCrBdE   a video explaning debug steps.
inappbrowser opens correctly but when it return to my app , isauthentifcated variable is still false , and it do not redirect me to the correct route.
ps: crosswalk increase performances dramaticly on android,and i really need performance my project

@krystalcode What did you use for Facebook's Site URL?

Nevermind, you have to set it to http://localhost/.


[docs] Link for deprecated log is broken

Deprecated.md contains a link named "deprecation log" that redirects to https://www.envoyproxy.io/docs/envoy/latest/intro/deprecated with 404 response code.

I think this will be fixed by https://github.com/envoyproxy/envoy/pull/10754

Hi @mattklein123,  The deprecation log file is removed as per Deprecation Policy. Can we remove DEPRECATED.md ?

Let's track this in https://github.com/envoyproxy/envoy/pull/10754


nyaml supports both dimensions and dim

Conversions from yaml to nxdl and vice-versa.
dim: (4,5)

<dimensions>
    <dim index=1 value=4/>
    <dim index=2 value=5/>
<dimensions/>

Note, the <dimension> does not have any rank which is intended. To keep the consistency (which was also part motivation of nyaml2nxdl tools) a of the nxdl.xml file content, e.g. if a nxdl.xml file dimension element does not have any rank key while reproducing the nxdl.xml the dimensions element will be as it was.

[x] Add test file as Lukas suggested.
[x] Implement markus suggestions.
[x] Add both of the notations

dimensions:
   rank: 3
   dim: (2, 4, 5)
   dim_parameters:
      doc: ["index_1","index_2", ,"index_3"]

dimensions:
   rank: 3
   dim: (2, 4, 5)
   dim_parameters:
      doc: ["index_1","index_2", ,"index_3"]

I have a more general question about the conversion strategy.
Let's say we start in the nxdl with something like this:
<field name="kinetic_energy" type="NX_FLOAT">
    <dimensions>
        <dim index="1" value="n_transmission_function"/>
    </dimensions>
</field>
<field name="relative_intensity" type="NX_FLOAT">
    <dimensions rank="1">
        <dim index="1" value="n_transmission_function"/>
    </dimensions>
</field>

This gets translated to
kinetic_energy(NX_FLOAT):
  dim: (n_transmission_function,)
relative_intensity(NX_FLOAT):
  dimensions:
    rank: 1
    dim: [[1, n_transmission_function]]

I guess here it picks up that the <dimensions> in kinetic_energy don't have the rank specified and therefore the conversion defaults to the numpy-notation. I am curious about the second case (i.e., transmission_function). My idea in the issue (#22) was that we always use the short notation with the dim keyword when translating back to nyaml. But now, it decides based on what is there in the XML element. What is the strategy here?

The main strategy to keep all the version consistent for back and forth conversion which original decision came from the majority of area-b members. There are not only dim element, it also needs to consider dimensions element, its doc and its attributes.

Ok, I must have missed that discussion about keeping old nyamls as they are now and not remake them with the new notation. If that's the majority decision, I am fine with the changes proposed here.
I still say that it would be nice if dimensions and dim would have the same capabilities, i.e., you could also set doc and other attributes with the dim notation but maybe this can be its own issue later.

I will also support having same functionality. It is less confusing. Maybe this can be improved here already.
The only consistency we need to maintain is that we don't change the old NXDLs. We shouldn't have any problems changing our old yamls.
Are we still running nyaml2nxdl over all the files on commits? Or is that being done manually? If it's manual, then we should unify the conversion to what makes more sense.

I will also support having same functionality. It is less confusing. Maybe this can be improved here already. The only consistency we need to maintain is that we don't change the old NXDLs. We shouldn't have any problems changing our old yamls.
Are we still running nyaml2nxdl over all the files on commits? Or is that being done manually? If it's manual, then we should unify the conversion to what makes more sense.

It's done manually, but there is a check  in the CI that the nyamls and nxdls are consistent.
For me, it's also totallly fine to change the nyamls, as of now they are literally just used for our own development and not part of the NeXus standard anyway.

I will also support having same functionality. It is less confusing. Maybe this can be improved here already. The only consistency we need to maintain is that we don't change the old NXDLs. We shouldn't have any problems changing our old yamls.
Are we still running nyaml2nxdl over all the files on commits? Or is that being done manually? If it's manual, then we should unify the conversion to what makes more sense.

It's done manually, but there is a check in the CI that the nyamls and nxdls are consistent.
For me, it's also totallly fine to change the nyamls, as of now they are literally just used for our own development and not part of the NeXus standard anyway.

Ok! We can implement it too.

Aside from the tests, you basically changed that nxdl2nyaml defaults to
dimensions:
 rank: 1
 dim: (n_transmission_function,)

Right? In that case, why don't we just write
dim: (n_transmission_function,)

immediately? That is even more concise.
My idea was to only default to the longer dimensions in the nyaml files if there is anything user than rank and <dim> in the nxdl. Like, if there is an adittional doc, then it should default to dimensions. What was your idea @sherjeelshabih?

Please also merge in the main branch, we fixed some issues in the config lint in #25 and it is probably not correctly checked in this PR as of yet.

Aside from the tests, you basically changed that nxdl2nyaml defaults to
dimensions:
 rank: 1
 dim: (n_transmission_function,)

Right? In that case, why don't we just write
dim: (n_transmission_function,)

immediately? That is even more concise.
My idea was to only default to the longer dimensions in the nyaml files if there is anything user than rank and <dim> in the nxdl. Like, if there is an adittional doc, then it should default to dimensions. What was your idea @sherjeelshabih?

I was just agreeing with your idea. It's to use the shorter version wherever possible. Just as you said. I'm honestly not aware of the exact syntax.

How question

Aside from the tests, you basically changed that nxdl2nyaml defaults to
dimensions:
 rank: 1
 dim: (n_transmission_function,)

Right? In that case, why don't we just write
dim: (n_transmission_function,)

immediately? That is even more concise.
My idea was to only default to the longer dimensions in the nyaml files if there is anything user than rank and <dim> in the nxdl. Like, if there is an adittional doc, then it should default to dimensions. What was your idea @sherjeelshabih?

I was just agreeing with your idea. It's to use the shorter version wherever possible. Just as you said. I'm honestly not aware of the exact syntax.

We all agreed to have the shorter version. I will add the test @sherjeelshabih.

How question

Aside from the tests, you basically changed that nxdl2nyaml defaults to
dimensions:
 rank: 1
 dim: (n_transmission_function,)

Right? In that case, why don't we just write
dim: (n_transmission_function,)

immediately? That is even more concise.
My idea was to only default to the longer dimensions in the nyaml files if there is anything user than rank and <dim> in the nxdl. Like, if there is an adittional doc, then it should default to dimensions. What was your idea @sherjeelshabih?

I was just agreeing with your idea. It's to use the shorter version wherever possible. Just as you said. I'm honestly not aware of the exact syntax.

We all agreed to have the shorter version. This is already implemented, I will add the test @sherjeelshabih.

@sherjeelshabih test for both the new (shorter one) and old elaborated one added.

My idea was to only default to the longer dimensions in the nyaml files if there is anything user than rank and  in the nxdl
This is exactly why I proposed to use the short-hand dim!

My idea was to only default to the longer dimensions in the nyaml files if there is anything user than rank and in the nxdl
This is exactly why I proposed to use the short-hand dim! Dim: should be the default. It is at least as of now also the most frequent case in base classes and appdefs where we are more explicit about dimensions than stating it can be anything

@mkuehbach, We are on the same phase.
# This convention is also valid from yaml2nxdl conversion
dimensions:
   rank: 3
   dim: (2, 4, 5)
   dim_parameters:
      doc: ["index_1","index_2", ,"index_3"]

# default from nxdl2yaml conversion
dimensions:
   rank: 3
   dim: (2, 4, 5)
   dim_parameters:
      doc: ["index_1","index_2", ,"index_3"]

If no further information on the dimensions and dim other than value, then it takes shorter notation
dim: (2,4,5)

Looks good now and works as intended.
I still think it would be nice to also use the shorthand dim notation even with the other attributes, but maybe that can happen later.

If we have smart syntax then why not.


[Announce] Moved to https://github.com/nnsuite/TAOS-CI since Aug-15-2018

 Issue by geunsik-lim
Thursday Aug 16, 2018 at 10:03 GMT
Originally opened as https://github.sec.samsung.net/STAR/TAOS-CI/issues/154

This Repository has mirrored from https://github.com/nnsuite/TAOS-CI since Aug-15-2018.
Please, write your issue at https://github.com/nnsuite/TAOS-CI/issues.

 Comment by git-bot-sec
Thursday Aug 16, 2018 at 10:03 GMT

:octocat: cibot: Thank you for posting issue #154. The person in charge will reply soon.

:octocat: cibot: Thank you for posting issue #178. The person in charge will reply soon.


Your request to provision "Microsoft 365 learning pathways"  template failed!

Your     request to provision     "Microsoft     365 learning pathways"      template     failed!     Please report the     issue here providing the following provisioning action correlation ID:     9017f129-3e94-4e32-abc6-09307dc27179 !                        Please provide use feedback around your used template or the     service in general by using our feedback     form . Thank you for your input advance.

Hi, Thanks for your comprehension. There was an issue that is now fixed.


Add a new maintainer to the Harmonia repository

Hi please can we add Michéle Cullinan to the list of maintainers on the Harmonia list of committers (https://github.com/orgs/hyperledger-labs/teams/harmonia-committers).
Her Github handle is MicheleCullinan
She was on the original list, so it appears to have been an oversight https://github.com/hyperledger-labs/harmonia#initial-committers
Unless I am missing something

Invite sent!

@petermunnings  in the future please use the template, as it adds assignees. That's why I missed this!


State of the project?

Your project is listed here: https://docs.saltstack.com/en/latest/topics/projects/index.html#salt-based-projects
Is this project still alive? There was no change since some years.
What do you recommend for new users who want to test their salt code?

Hey @guettli ... sorry for the slow response, I've been on vacation and just catching up on a backlog of email. The project isn't really "dead", per se, but I haven't really been using it personally in a long time as I haven't been writing any Salt myself (I've been mostly in the realm of Ansible for work-related tasks). That said, there is an open pull request right now that I'm going to sort out the conflicts and get merged, and it would be nice to keep the project alive, as I think its purpose for existing is useful. I'm glad to add contributors to the repository if people are interested in helping improve the current state of affairs.

@elasticdog  thank you for your reply. If you search a new maintainer, it might help to tell this at the top of the README.
I would be a bad maintainer since I still learning salt and have not used vagrant before.