Gradle buils is slow on macOS agents

Description
I have an android project where I am running two test pipeline

Unit test pipeline
UI test pipeline

For the unit test pipeline, I am using an Ubuntu machine which gets complicated in less than 5 minutes including my 400 unit test cases but On UI pipeline where I am using macOS agents to create an android simulator and run the build which takes almost 10 minutes to build the app even I am not running any UI test cases, why is there so much time difference in build with same application in different agents.
Virtual environments affected

[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[X] macOS 10.15
[X] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Agent name: 'Azure Pipelines 2'
Agent machine name: 'Mac-1638971449039'
Current agent version: '2.195.2'

Is it regression?
No response
Expected behavior
Build time should be same on different environment
Actual behavior
No response
Repro steps
Use any android project and create two Pipeline, in the First one use an ubuntu agent, and the second pipeline use a macOS machine, you can see easily see the build time difference between them.

Hello, @tyagirajnish
Could you provide steps to reproduce an issue or share repository?

hello @al-cheb
sorry I can't share the repo but I have shared how you can reproduce this issue all you need a sample application, create two pipelines in the first one use ubuntu image and in second one use mac machine
here is a sample project i found over the GitHub: https://github.com/imShakil/BloodBank
Attached screenshot it's clearly visible the time difference between two pipelines with same code, only difference is agent

Hello @tyagirajnish. Could you please share yaml file with reprosteps in order to be able properly investigate the issue.

hi @dibir-magomedsaygitov ,
i tried to run some test cases on the given project but here I can see vice versa case here ubuntu vm are slow to build

here is my yml code for this project
trigger:
- master

pool:
  vmImage: ubuntu-latest // or macos-latest

steps:
- task: Gradle@2
  inputs:
    workingDirectory: ''
    gradleWrapperFile: 'gradlew'
    gradleOptions: '-Xmx3072m'
    javaHomeOption: 'JDKVersion'
    jdkVersionOption: '1.8'
    jdkArchitectureOption: 'x64'
    publishJUnitResults: true
    testResultsFiles: '**/TEST-*.xml'
    tasks: 'test'

@tyagirajnish I've made some test runs and results for ubuntu-latest and macos-latest are pretty much the same (in some occasions a bit longer). Without the link to the builds, logs or full reprosteps it will be hard for us to investigate the issue in a right way

.

@tyagirajnish thank you for the provided information. I've run a few more tests with the different apps and the pipeline durations are similar for ubuntu-latest and macos-latest. Unfortunately, without links to builds or logs we won't be able to properly investigate the issue and find the root cause.

Hello @tyagirajnish. I'm going to close this issue since we can't investigate it properly without links to the builds or logs. If you will be able to provide us public repo where the issue occurs - feel free to re-open this thread. Thank you.


Fix VirtualBox shared folder detection when using boot2docker

When initializing boot2docker, check_for_shared_folders is being
called before the DOCKER_HOST_SSH_COMMAND variable, which it uses, is
intialized. This has the effect of running commands locally instead of on
the boot2docker instance and, in this case, silently failing to detect
shared folders.
Moving check_for_shared_folders to the end of init_boot2docker fixes
this.
This seems to have been caused by the shift from using VBoxManage for
shared folder detection to boot2docker ssh, and then to the
DOCKER_HOST_SSH_COMMAND variable, without changing when
check_for_shared_folders is run.

Thanks for the PR! I added one comment. Let me know your thoughts, and if you update the PR, let me know, as GitHub doesn't automatically send a notification for that.

Thank you!


os-bind does not start if 'Allow RDNC key update' is set on any primary domain when secondary zones exist

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[x] The title contains the plugin to which this issue belongs

Describe the bug
When setting 'Allow RDNC key update' on any primary domain and secondary domains exist, Bind fails to start.
When trying to start the service manually via SSH, the service errors out with:
/usr/local/etc/namedb/named.conf:63: option 'update-policy' is not allowed in 'secondary' zone 'secondary.domain.name'
/usr/local/etc/rc.d/named: ERROR: named-checkconf for /usr/local/etc/namedb/named.conf failed

The issue seems to be that update-policy is only allowed on primary domains, but the option is written on secondary zones too.
The issue seems to be in the template /usr/local/opnsense/service/templates/OPNsense/Bind/named.conf:
{%      if domain.allowrndcupdate is defined and domain.allowrndcupdate == "1" %}
184         update-policy {
185                 grant rndc-key zonesub ANY;
186         };
187 {%      endif %}

The simple fix is to add domain.type == 'primary':
{%      if domain.allowrndcupdate is defined and domain.allowrndcupdate == "1" and domain.type == 'primary' %}
184         update-policy {
185                 grant rndc-key zonesub ANY;
186         };
187 {%      endif %}

To Reproduce
Steps to reproduce the behavior:

Go to Services -> BIND -> Configuration
Under General tab (Advanced view) have RNDC Key section setup with an Algorithm and Secret
Go to Primary Zones tab, selection edit on any zone and tick the Allow RDNC key update option
If already set: untick -> Save -> Save -> edit zone -> tick -> Save -> Save
Bind service will fail to start
SSH into Opnsense server
service named start
Observe error

Expected behavior
Bind starts after setting Allow RDNC key update on any primary domain
Screenshots
If applicable, add screenshots to help explain your problem.
Relevant log files
When trying to start the service manually via SSH, the service errors out with:
/usr/local/etc/namedb/named.conf:63: option 'update-policy' is not allowed in 'secondary' zone 'secondary.domain.name'
/usr/local/etc/rc.d/named: ERROR: named-checkconf for /usr/local/etc/namedb/named.conf failed

Additional context
Add any other context about the problem here.
Environment
Software version used and hardware type if relevant.
e.g.:
OPNsense 24.1.4 (amd64).
os-bind 1.30_1

AFAICT, this was already fixed in https://github.com/opnsense/plugins/pull/3873.


Add closing paren to andross boilerplate description

Please verify the following:

[X] Everything works on iOS/Android
[X] npm test ava tests pass with new tests, if relevant
[X] ./docs/ has been updated with your changes, if relevant

Describe your PR

Add closing paren to andross boilerplate description (see twitch chat above from byteconf).

MOST EPIC PR!

Thanks @QuinKinser !!

:tada: This PR is included in version 2.1.8 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Port-based IO API?

It might be useful for Video to provide a way to read and write video data to and from arbitrary Racket ports, instead of only to and from files. I think a possible way to support this would be for clip to accept an input port from which it reads video data. Maybe it would have to be a thunk that produces a port though? I'm not sure how lazy video construction is or when exactly the file is read into memory.

This is also possible, although I will have to think about how to fit this into the current architecture.
Thanks for the suggestion.


SPU Sound Issues

For some reason SPU won't play all notes if you stand from specific angle.
Video
http://bit.ly/1yQ833x

I didn't want to reveal my midi parser code so I wrote memory to file and created new e2 code to read the dump.
SPU Code
// Setup
// Code
reset:
    wset 0,trackwave;
    timer #startTime;
    mov #nextTime, 0;

    mov #memPos, 501;
    mov eax, #memPos;
    mov nextTime, [eax];

    mov  ecx, 32;
    mov  eax, 0;

    rloop:
        chstop eax;
        chwave eax, 0;
        chpitch eax,0;
        chvolume eax, 0.5;
        chstart eax;

        inc eax;
    loop rloop;
main:
    // Check if playback is still active
    mov eax, #500;
    cmp eax, 0;
    je reset;
    // Check if it's the end of the song
    mov ebx, #memPos
    cmp ebx, eax;
    jg reset;
    // Check if next note should be played
    timer eax;
    sub eax, #startTime;
    cmp eax, #nextTime;
    jl main;

    mov eax, #memPos;

    mov ebx, eax:#1; // channel
    mov ecx, eax:#2; // pitch

    chpitch ebx,ecx;
    chstart ebx;
    mov #nextTime, eax:#3;
    add #memPos, 3;
jmp main;

// Data
alloc nextTime;
alloc startTime;
alloc memPos;
trackwave: db 'synth/sine_880.wav',0;
//trackwave: db 'synth/white_noise.wav',0;

E2 Code
@name midi_dump_reader
@persist SPU:wirelink State:number FileStr:string MemCount:number MemValues:array MemPos:number
@trigger
if(first()){
    runOnFile(1)
    runOnTick(1)
    setName("")
    SPU = entity():isConstrainedTo():wirelink()
    if(!SPU | SPU:entity():type() != "gmod_wire_spu" ){error("Error: Spawn E2 on SPU! Spawned on "+SPU:entity():type())}
    SPU["Clk",number]=1
    SPU[500]=0
    MemPos = 501
    fileLoad("midi_dump.txt")
}
if(fileClk()){
    FileStr = fileRead()
    MemValues = FileStr:explode(",")
    MemCount = MemValues:count()
    print("Loaded dump file with "+FileStr:length()+" bytes! Total "+MemCount+" memory values.")
    State = 1
}
if(State == 1){
    while(perf()){
        if(MemValues:count()>0){
            SPU[MemPos] = MemValues:shiftString():toNumber()
            MemPos++
        }else{
            SPU[500]=500+MemCount
            print("Dump parsed and loaded!")
            State = 2
            break
        }
    }
}

midi_dump.txt
http://pastebin.com/gKW4cWQV
midi
http://www.angelfire.com/fl/herky/images/teddybear.mid

Quite possibly related to Facepunch/garrysmod-issues#1752.
But it would be a lot more helpful if you could provide a simple test SPU (eg. that just beeps repeatedly) than compiled code plus E2 code plus SPU code.

I couldn't replicate the issue with beeps. And could the reason be how the sound entities are placed in spu?

I'm blaming the source engine

Managed to replicate with beeps, there http://bit.ly/1L7qqaK .
mov  ecx, 32;
mov  eax, 0;

rloop:
    chstop eax;
    chwave eax, 0;
    chpitch eax,0;
    chvolume eax, 0.5;
    chstart eax;

    inc eax;
loop rloop;

main:
    timer eax;
    mov ebx, nextTickTime;

    cmp eax, ebx;
    jl main;

    add eax, 0.3;
    mov nextTickTime, eax;

    mov eax, currentTick;
    mov es, track1;
    chpitch 0,es:#eax;
    chstart 0;

    mov es, track2;
    chpitch 1,es:#eax;
    chstart 1;

    mov es, track3;
    chpitch 2,es:#eax;
    chstart 2;

    mov es, track4;
    chpitch 3,es:#eax;
    chstart 3;

    add currentTick, 1;
    mod currentTick, 4;
jmp main;

float currentTick,nextTickTime;

track1: db 0.5,0.5,0.5,0
track2: db 0.9,0.9,0.9,0
track3: db 1.0,0,1.0,1.0
track4: db 1.4,0,1.4,1.4

Found better combination:
track1: db 0.0,0.0,0.0,0.5
track2: db 0.0,0.0,1.0,0.0
track3: db 0.0,2.0,0.0,0.0
track4: db 3.0,0.0,0.0,0.0

Looks like it would only play random 3 channels, not sure if it's 100% source fault.

Can't you replace  with ? You can't parent it to an entity, but It does 3D feature. Using  hook to set sound position shouldn't effect the performance too much. And would most likely fix this major issue.

FYI CreateSound has a new channel parameter that should be used. http://wiki.garrysmod.com/page/Global/CreateSound

if anyone wants to make pull request that'd be great

@thegrb93

The channel parameter has default parameter, so each sound entity should already have their own channels.

It does work, made quick code to test it.
Here, same midi code played using sound.PlayFile
https://copy.com/HsvwabhdPFsq/2015-07-28_19-28-12.mp4
I wrote a small hack to get rid of the callback using metatables. It's really unstable, if SPU poorly written, it will freeze your game. And I don't really want to mess with the SPU internal code. I would appreciate if someone could implement this correctly.
cl_spuvm.lua

@edgarasf123 What I meant is you should use one targetEnt and use different channels rather than a bunch of targetEnt using one channel.

@thegrb93 They already do use their own channel.

facepalm Please read more closely. Each single channel is using a prop_physics to convey the sound. Instead, solely the spu itself should CreateSound, but use different channels for the sounds.

I understand. But is it going to fix this issue? And messing with the channels could cause other issues. For example SPU entity id is 121 and it creates sound channels [121...129], then someone places an E2(which also plays sounds) and its entity id is assigned to 122, then there will be 2 entities playing on a single channel.

@edgarasf123 when playing midi, you need more than one channel per entity

@TomyLobo SPU does right now create 32 entities for each sound channel. The issue is that the source engine is not able to play multiple channels at once (3 at most). That's why I'm suggesting to switch CreateSound to sound.PlayFile, which uses BASS audio library and it's able to play multiple channels at once just fine.
EID*10+Index doesn't stop you from getting the issue I described above.
The channel parameter is pointless. Because by changing channel id, you're just going to mess with random entity sound channel. The only place is see this parameter could be used is in custom gamemode, where the developer has full control over environment,

Then yes, BASS is the best option. Last time I tried BASS though, it was unable to play wav loops. Don't know if that is fixed yet or not.

You have to add noplay flag.

That fixes the BASS_ERROR_UNKNOWN?

@edgarasf123 Didn't you say you can't parent sound.PlayFile to an entity?
Isn't that bad if your SPU is moving?

That's why I said to use ENT:CalcAbsolutePosition hook, to update the location of sound.

@thegrb93 I didn't get BASS_ERROR_UNKNOWN error at all. The only issue I got initially is that looping sounds such as "synth/sine.wav" would only play for half a second. Adding "noplay" flag fixed the issue.

Ah here, I found the issue https://github.com/wiremod/wire/issues/794

@edgarasf123
So you change the sound position once a frame, via Lua.
Isn't that terribly inefficient?

No

just "No"?

Why would changing the position of a sound be inefficient?

you're doing that every single frame for every SPU for every sound

It's clientside, so it won't slutter back and forth.

Someone just try it instead of arguing then

Isn't Source mostly single threaded?

@oldmud0 If it was expensive then yes, but setting a position is not expensive.

it could bring performance down by pure virtue of being single-threaded

@thegrb93 setting the position of entities is quite expensive in the source engine. That's why I made all projectiles clientside in pewpew, to spam entity position there instead of on the server. This doesn't necessarily mean that setting the position of sounds in the way we're talking about here is also expensive, but you can't say that setting ANY position is inexpensive, because that's not true.

Was it fixed?

@immibis apparently your change doesn't work in all situations.

@edgarasf123 It seemed to work for me, at least back in April when I made that PR. Does it behave differently at all (with the sound sources at the same position)?

anyone know, what must i use for sound output for spu


Another project using this library :)

I've added a wrapper around your library for projects using the Arduino SDK:
https://github.com/embeddedartistry/arduino-printf
Still my favorite printf library!

modm.io is also using this library, albeit with some hacky hacks to disable the native floating point functions on AVR and use the optimized (fixed options) routines from avr-libc.
At least for our use-case it would've been more advantageous to have a more modular internal API, (we use the internal "static" functions _ntoa_long_long, _etoa etc too), to allow for a more custom printf build. However, that may not be a universal requirement 😛.

I just integrated this library to https://github.com/vhelin/wla-dx/issues/273 for the implementation of snprintf() - I hope this is ok. I had to modify the code a little bit to make this library ANSI C90 compatible...


adding kong for travis testing

potentially closes #76

Thanks for the PR, a great starting point for integration tests.
I'm going to add another PR for adding integration tests that I rebase onto this branch.

Merged in with some modifications: https://github.com/mybuilder/kongfig/commit/78dbf30a3543f2fa30789fe6baa623d682b71593


testEnvironment config not working (or documentation is wrong)

In documentation, testEnvironment config can be node or jsdom.
but both won't work.
It works if I set value with the module path for NodeEnvironment/JSDOMEnvironment like C:\somewhere\...\node_modules\jest-cli\src\environments\NodeEnvironment.

You should update to Jest 11.0. This config option wasn't present in previous versions which looks like what you are using.

@cpojer Thanks!


Fix output of functions gathering replset info.

Pull Request (PR) description
Replset info gathering functions now provide unique lists, which prevents replset initialisation from failing.
This Pull Request (PR) fixes the following issues
Fixes #554

Thanks!


Running scripts on each package on a workspace?

I haven't seen this discussed or mentioned anywhere -
It feels natural that when working with workspaces, to have the ability to run a script on each of the packages in the workspace - things like packaging, testing, etc.
Even better if it's in a parallel way that can respect dependencies.

bump.. i am wondering how to do this as well


Avoid unnecessary element conversions in propagation

Also, there is a bit of a mess in the git history, as can be seen in https://github.com/poliastro/poliastro/network

You might want to try to rebase your commits on top of current master, ping me in private in case you need a hand with this (the process can be a bit messy the first time)

Hmmm not so fast, there's one numba failure... Investigating

Documentation failures are unrelated, code and tests look good!

RTD failure is unrelated

Merged! Thanks @andrea-carballo , and congratulations for your first pull request! 🙌🏼


Add Python 3.12 to the tests & Ignore warning + impove import in utils.py

Add Python 3.12 to the test runs
Ignore all warnings in utils.py, yes we are aware of these deprecated methods these are used for fallback behavior.
Improved addopts parameter
Fix initialization of parameters

NVM.. I will use: https://github.com/fake-useragent/fake-useragent/pull/232


Linux support

Part of https://github.com/kiteco/kiteco/pull/8432

Codecov Report

Merging #27 into master will decrease coverage by 1.17%.
The diff coverage is 48.64%.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   77.21%   76.04%   -1.18%
==========================================
  Files          17       17
  Lines         676      693      +17
==========================================
+ Hits          522      527       +5
- Misses        154      166      +12

Impacted Files
Coverage Δ

lib/support/linux.js
66.34% <48.64%> (-7.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a36fa...0a5ab2f. Read the comment docs.


[BUG] Can't run a single component without running everything

In order to initialise the project what I'd like to do is something like
exo workspace init
exo start db
npx prisma migrate dev
exo stop db

In practice this doesn't work because exo apply is never called. But if I call exo apply that then runs every service, some of which misbehave if I haven't yet performed the initialisation.

Related: #324


beforeSave issues with dirtyKeys

I am running my CloudCode on a node.js server, using webhooks as described in a recent blog post on parse.com, and using CloudCode-Express.
Everything seems to run smooth, however in my beforeSave triggers I need to check if certain keys are dirty and they never are?
Parse.Cloud.beforeSave("CLASSNAME", function(request, response) {
    console.log(request.object.dirtyKeys()); // always outputs an empty array to the console
    if(request.object.dirty("key") && request.object.get("key")) { // value is a boolean
        // never executes
    }
});

Is this a bug, or am I doing something wrong? Running the same triggers on CloudCode on Parse.com (non-self-hosted), works as expected.

Currently this is not supported by webhooks.  The dirty keys are not passed to webhooks by the Parse backend according to the current spec (https://www.parse.com/docs/js/guide#cloud-code-advanced-beforesave-webhooks), so the JS SDK can't populate this field in Node.js.
However, we are always looking to improve the platform.  Could you talk more about your use case and why you need this information?

Thanks for the reference, I was looking all over for this.
I am relying on some node.js plugins that I can't implement in CloudCode, so I made a quick decision to move all code to Heroku (without noticing the dirtyKeys limitation). I want to avoid maintaining server side logic in too many places :)
I am often using the change of a key's value as a trigger to another action, e.g. updating a related object. I do not want to trigger these actions on every save, but only if a specific key's value is changed.
I am also validating keys if they are dirty, e.g. to set a default value or verify it is not undefined.
Would it be possible to somehow trigger a warning log message if unsupported functions are used?
Thanks!

On 30. sep. 2015, at 19.11, Stanley Wang<EMAIL_ADDRESS>wrote:
Currently this is not supported by webhooks. The dirty keys are not passed to webhooks by the Parse backend according to the current spec (https://www.parse.com/docs/js/guide#cloud-code-advanced-beforesave-webhooks), so the JS SDK can't populate this field in Node.js.
However, we are always looking to improve the platform. Could you talk more about your use case and why you need this information?
—
Reply to this email directly or view it on GitHub.

To piggyback off of this issues:
In version 1.5.0 of the SDK it was possible to detect if a client changed the ACL of the Parse.User object with the following logic:
Parse.Cloud.beforeSave(Parse.User, function(request, response) {     if(!request.master && request.object.dirty('ACL')) {         //ACL of user object modified     } });
It appears that this is no longer the case. Is this intentional or a bug?

@zicker are you referring to code running in Node.js, or on Parse Cloud Code?
This issue is regarding code running on a privately hosted Node server, using our Webhooks service.
That said, the behavior you mention should still be supported in 1.6.4. We have tests that suggest it works in the current version (1.6.4)

@andrewimm Running it on Parse Cloud Code. I probably should have created a new issue for this... sorry about that!

@Silkjaer please see https://github.com/ParsePlatform/parse-cloud-express/issues/4


Preview/service provider terms

Solves the following subtasks:
BE: Create endpoint to accept Service Provider terms
BE: Create endpoint for getting Organization service provider terms (accept/not accepted)
BE: Create migration for adding ServiceProviderTerms accepted field on Organization entity.

What about the two last subtasks ? :)

What about the two last subtasks ? :)

Hvad med dem?


npy does not exist. Path Issue?

python run_training.py --work-dir ./outdir data:custom --data.seq-name untitled --data.root-dir ./preproc/indir/
Traceback (most recent call last):
File "/home/ubuser/Desktop/shape-of-motion/run_training.py", line 254, in
main(tyro.cli(TrainConfig))
File "/home/aris/Desktop/shape-of-motion/run_training.py", line 80, in main
get_train_val_datasets(cfg.data, load_val=True)
File "/home/aris/Desktop/shape-of-motion/flow3d/data/init.py", line 36, in get_train_val_datasets
train_dataset = CasualDataset(**asdict(data_cfg))
File "/home/aris/Desktop/shape-of-motion/flow3d/data/casual_dataset.py", line 136, in init
w2cs, Ks, tstamps = load_cameras(
File "/home/aris/Desktop/shape-of-motion/flow3d/data/casual_dataset.py", line 456, in load_cameras
assert os.path.exists(path), f"Camera file {path} does not exist."
AssertionError: Camera file ./preproc/indir//droid_recon/untitled.npy does not exist.
I think it is looking for:
/home/ubuser/Desktop/shape-of-motion/preproc/indir/bootstapir/untitled
This directory has:
├── 00001_00001.npy
├── 00001_00002.npy
├── 00001_00003.npy
├── 00001_00004.npy
...
Is it possible the file packaging has changed?

Sorry I'm confused, reading the assertion error, it seems that it's the camera file ./preproc/indir//droid_recon/untitled.npy  which does not exist?


get_tree().change_scene problem

Godot version
3.5.stable
System information
Windows 10
Issue description
every time i input the change_scene signal in my script and i play the game, my game will always crash and fizzle. How do i fix it?
Steps to reproduce
get_tree(). change scene in a godot script
Minimal reproduction project
i dont understand please help

i dont understand please help

Minimal reproduction project is a Godot project with enough files to reproduce the bug. E.g. if a bug in your project is caused by specific script, MRP will contain only this script and some empty project.godot (although attaching only script is ok too).
The issue does not have enough details.

Closing due to lack of response, if you provide the requested information this can be reopened


Force Register Command invalid

as:/fl reg XXX 123aaa
Throw hints :No values matching pattern 'fgbf' present for user!
Unable to complete registration task
This problem started here:
https://github.com/games647/FlexibleLogin/commit/9230e0fb0338034aa5614e5f2d76c627052b7021

To execute this command, the user must try to log in at least 1 time


Stable merge window for week 49 of 2023

New Packages

webinterface-onboot 1.2.2-2 - (#770 #721)

Allows the usb web interface to start without the USB cable being connected.

webinterface-upload-button - 1.0.1-1 (#771)

Adds an upload button to the usb web interface.

signature-rm - 1.0.2-1 (#772)

Removes the Sent from my reMarkable signature from emails sent by the device.

Updated Packages

linux-stracciatella - 5.4.70-3 (#742)

Updated to RM1XX_5.4.70_v1.3.4 tag from upstream kernel.
Added wireguard module.

wireguard - 1.0.20210219-4 (#743 #784)

Removed wireguard-tools and wg-quick from wireguard package. These packages are provided by entware already.

display and rm2fb-client - 1:0.0.32-2 (#758 #721)

Add support for OS <IP_ADDRESS>6

rmfm - 1.5.1-1 (#766)

Fix issue where listing a directory with an invalid symlink would crash the application.

neofetch - 1.1.0-1 (#769)
webinterface-wifi - 2.0.0-2 (#768 #721)
micro - 2.0.13-1 (#738)
koreader - 2023.10-2 (#749 #721)
ddvk-hacks - 39.01-2 (#720 #778)

Fix issue where ddvk-hacks wouldn't be reapplied when using toltecctl reenable.

draft - 0.2.0-22 (#721)
erode, fret, oxide, rot, tarnish, decay, corrupt, anxiety, oxide-utils, inject_evdev, and liboxide - 2.6-3 (#721)
reboot-guard - 1.0.1-8 (#721)
rmfakecloud-proxy - 0.0.3-4 (#721)
genie - 0.1.6-3 (#721)
remux - 0.2.4-2 (#721)
tailscale-systemd - 0.0.0-2 (#721)
toltec-base - 1.2-3 (#721)
xochitl - 0.0.0-17 (#721)

Tooling

New provides=() field added for packages.
Added unit-exists and disable-unit methods to install-lib

Note: This doesn't change what OS version that toltec supports, as full support still requires various packages to be updated, removed, or replaced. Along with proper testing of all packages in the repository, as well as the upgrade process. https://github.com/toltec-dev/toltec/milestone/7 contains the current list of issues and pull requests required for 3.x support.

Todo

[ ] Populate description with release notes
[ ] Test on rM1
[ ] Test on rM2

I can install wireguard and wireguard-tools at the same time, even though wireguard provides wireguard-tools and wireguard-tools conflicts with wireguard. It doesn't matter the order I specify them in. Upon inspecting /opt/lib/opkg/status it appears that wireguard-tools is missing the conflicts line. This will need to be resolved before this can merge to stable.

I've opened https://github.com/toltec-dev/toltec/pull/784 to resolve the issue. It will need to be included before this can merge to stable.

I did some testing on rm2 this evening: rmfm, display/rm2fb, remux, neofetch all behave well.
I expect to test most of the other rm2 packages sometime before the end of the weekend... except for linux-stracciatella probably, in case someone else with an rm2 wants to pick it up.

I did some testing on rm2 this evening: rmfm, display/rm2fb, remux, neofetch all behave well.
I expect to test most of the other rm2 packages sometime before the end of the weekend... except for linux-stracciatella probably, in case someone else with an rm2 wants to pick it up.

Is there a chance that you could review/test #784 in the next day or two so we can get it merged and tested as well? I was hoping to get another merge window started before this weekend, as this merge window was supposed to merge on Sunday.

Did what I could!

Did what I could!

Thanks! It's now merged and ready for further testing.

Testing
I did some testing with an rm2 on <IP_ADDRESS>9.
Approach
Extreme, but works.

Uninstall toltec
Reinstall toltec
Install all packages mentioned in PR
Run some applications (to generate configs, e.g oxide, koreader, etc.)
Download PR-specific build artifact from GH PR "Checks" tab
Set up repo locally
Update and upgrade packages through opkg
Test packages

Using a local-repo with build artifacts
Locally (computer)
Firstly, download the PR-specific build artifacts. Then:
scp repo.zip rm:

Remotely (rM)
mkdir -p ~/packages/local/
cd ~/packages/local/
mv ~/repo.zip ./repo.zip
unzip repo.zip
cat > /opt/etc/opkg.conf.d/16-local.conf << EOF
src/gz local-rmall file:///home/root/packages/local/rmall
src/gz local-rm1 file:///home/root/packages/local/rm1
src/gz local-rm2 file:///home/root/packages/local/rm2
EOF
toltecctl generate-opkg-conf
opkg update
opkg upgrade

Packages to install (mentioned in PR)
opkg install webinterface-onboot webinterface-upload-button signature-rm linux-stracciatella wireguard display rm2fb-client rmfm neofetch webinterface-wifi micro koreader ddvk-hacks draft erode fret oxide rot tarnish decay corrupt anxiety oxide-utils liboxide inject_evdev reboot-guard rmfakecloud-proxy genie remux tailscale-systemd toltec-base xochitl

Results
New Packages

[X] webinterface-onboot

uninstall ddvk-hacks after testing it
enable service
reboot

[X] webinterface-upload-button

uploaded pdf via web interface

[X] signature-rm

uninstalled ddvk-hacks and webinterface-onboot
missing "restart xochitl or the device" note
restarted xochitl
sent page by email

Updated Packages

[X] linux-stracciatella

switch kernel via kernelctl, rebooted

[X] wireguard

got a connection working, without using wg-quick

following official instructions and an existing setup

[X] display and rm2fb-client

used it for everything

[X] rmfm

open, browse, open text file

[X] neofetch
[X] webinterface-wifi
[X] micro

open, edit, save file

[X] koreader

opens a ePUB book and PDF paper

[X] ddvk-hacks

present, works

[X] draft

opened/exited KOReader, opened/exited rmfm

[X] erode, fret, oxide, rot, tarnish, decay, corrupt, anxiety, oxide-utils, liboxide and inject_evdev

anxiety, fret: took a screenshot, viewed it
corrupt, oxide, tarnish: opened/exited rmfm, opened/exited xochitl
erode: open process manager
rot: rot apps get applications
inject_evdev: open a oxide menu, run example usage
oxide-utils: notify-send test

[X] reboot-guard

blocks everything correctly after running rguard -1, works again after rguard -0

[X] rmfakecloud-proxy

ran rmfakecloudctl, rmfakecloudctl status

[X] genie

used iago and lamp, with example config in /opt/etc/genie.conf, systemctl restart genie, default bezier curve

[X] remux

switch to rmfm, switch back to xochitl

[X] tailscale-systemd

connect to network
reboot rm
connect to rm via tailscale

[X] toltec-base, xochitl

not sure how to test those, but nothing bad really happened

Summary

signature-rm is missing "restart xochitl or the device" postinstall note

Summary
* `signature-rm` is missing "restart xochitl or the device" postinstall note

The code for uninstall that runs is as follows:
_restore() {
    echo "Reverting /usr/bin/xochitl"
    if signature-rm has-backup > /dev/null; then
        signature-rm revert --backup -y > /dev/null
    else
        signature-rm revert --reverse -y > /dev/null
    fi
    echo "Success"
    echo
}

Did you at least see the Reverting /usr/bin/xochitl and Success lines? They appear to be masking stdout from signature-rm revert, but that's also what the webinterface-onboot and webinterface-upload-button do.

Summary
* `signature-rm` is missing "restart xochitl or the device" postinstall note

Did you at least see the Reverting /usr/bin/xochitl and Success lines?

Yes, here's the full output of an installation and removal on my device:
root@reMarkable:~# opkg install signature-rm
Package ddvk-hacks version 39.01-2 has no valid architecture, ignoring.
Package ddvk-hacks version 39.01-2 has no valid architecture, ignoring.
Package ddvk-hacks version 39.01-2 has no valid architecture, ignoring.
Package ddvk-hacks version 39.01-2 has no valid architecture, ignoring.
Installing signature-rm (1.0.2-1) to root...
Downloading file:///home/root/packages/local/rmall/signature-rm_1.0.2-1_rmall.ipk
Configuring signature-rm.

Applying signature-rM
Success

root@reMarkable:~# opkg remove signature-rm
Removing package signature-rm from root...
Reverting /usr/bin/xochitl
Success

root@reMarkable:~#

I think the ddvk-hacks printing might be related to some quirk of my device, but I'm not sure and it's not exactly blocking installation, just printing more text than necessary.

I think the ddvk-hacks printing might be related to some quirk of my device, but I'm not sure and it's not exactly blocking installation, just printing more text than necessary.

Hmm, that is kind of odd, what does grep -A 10 ': ddvk-hacks' /opt/lib/opkg/status return?

I think the ddvk-hacks printing might be related to some quirk of my device, but I'm not sure and it's not exactly blocking installation, just printing more text than necessary.

Hmm, that is kind of odd, what does grep -A 10 ': ddvk-hacks' /opt/lib/opkg/status return?

Nothing at all.

What is the output of cat /opt/etc/opkg.conf?

What is the output of cat /opt/etc/opkg.conf?

root@reMarkable:~# cat /opt/etc/opkg.conf
# Opkg configuration
# Generated by toltecctl (do not modify!)

# Define custom configuration in files under the '/opt/etc/opkg.conf.d' directory
# then run `toltecctl generate-opkg-conf` to regenerate this file

dest root /
dest ram /opt/tmp
lists_dir ext /opt/var/opkg-lists
option tmp_dir /opt/tmp

# /opt/etc/opkg.conf.d/10-entware.conf
arch all 100
arch armv7-3.2 160
src/gz entware https://bin.entware.net/armv7sf-k3.2

# /opt/etc/opkg.conf.d/15-toltec.conf
arch rmall 200
src/gz toltec-rmall https://toltec-dev.org/stable/rmall
arch rm2 250
src/gz toltec-rm2 https://toltec-dev.org/stable/rm2

# /opt/etc/opkg.conf.d/16-local.conf
src/gz local-rmall file:///home/root/packages/local/rmall
src/gz local-rm1 file:///home/root/packages/local/rm1
src/gz local-rm2 file:///home/root/packages/local/rm2

Noting that the setup of the last 3 local ones is described in my initial message.

src/gz local-rm1 file:///home/root/packages/local/rm1

This line would be causing issues, as any packages included here have the rm1 architecture, which is not defined in the rest of your config, as you are configured for rm2/rmall only. So if you remove this line from /opt/etc/opkg.conf.d/16-local.conf and then run toltecctl generate-opkg-conf and opkg update, the errors should no longer be happening.

Oh, I just noticed you added rm1 to your conf file, you should remove that line and regenerate your opkg.conf, as rm1 packages are not meant to be installed on a rM2. That is probably why this is happening.

Indeed, it's now a clean output:
root@reMarkable:~# opkg install signature-rm
Installing signature-rm (1.0.2-1) to root...
Downloading file:///home/root/packages/local/rmall/signature-rm_1.0.2-1_rmall.ipk
Configuring signature-rm.

Applying signature-rM
Success

root@reMarkable:~# opkg remove signature-rm
Removing package signature-rm from root...
Reverting /usr/bin/xochitl
Success

I thought I could just add both without thinking much about it 😅. I also fixed my initial message with the code block for future reference.

Alright, I'm happy with the testing as-is now. @beelux you may want to open an issue about rm-signature/webinterface-onboot/webinterface-upload-button not instructing the user to restart xochitl, that way @rM-self-serve can weigh in on it. In my opinion, it does not block this stable merge.

I would be happy to add the 'restart xochitl' line to onboot/signature-rm. I believe my thinking with onboot was that the name implied rebooting and then I likely copied that to signature-rM. @Eeems would you like me to push that out really quick or are you looking to merge asap? Upload-button does not need to restart xochitl.

I would be happy to add the 'restart xochitl' line to onboot/signature-rm. I believe my thinking with onboot was that the name implied rebooting and then I likely copied that to signature-rM. @Eeems would you like me to push that out really quick or are you looking to merge asap? Upload-button does not need to restart xochitl.

It's not needed for this stable merge. I'd actually like to have it be done using the new launcherctl command in #795 to see if xochitl is running and give instructions to the user on how to restart xochitl with it.


NIFI-2801 Edited Kafka processor documentation to explicitly state wh…

…ich Kafka versions supported by each processor.  Corrected misspellings.

Reviewed this, fix a line-length error in PutKafka, and merged to Apache canonical repo 9cbb001. The GitHub repository hasn't synced the change, so the PR remains open.

Hi @andrewmlim this is now synced to GitHub repository for 0.x see 9cbb001. Can you please close this PR?

Thanks @alopresto !  Closed.


added icons

added icons 100% working on windows
macos most icons
kali linux Work in Progress shows default
hope my contribution is welcome :)

added icons 100% working on windows macos most icons kali linux Work in Progress shows default
hope my contribution is welcome :)

Nice job,Thank you!


Implement _check

In src/calculator.js, I have implemented the _check() and used it for checking the typeError of the input values x and y.
Apart from this, in src/calculator.test.js, I have modified the function name describe.skip() to describe() in line 4.

While explaining the issue DRY up the codebase #1, in one of the step it's mentioned to change describe.only to describe to so that all tests run. But in the src/calculator.test.js file, it's 'describe.skip', not 'describe.only'.
Thanks

Thanks for the note out @manp3104.
The instruction you mention comes after* a previous step that says

change describe.skip to describe.only.

If you follow both steps in order, by the time you get to the one you mentioned, your file should have temporarily been changed to describe.only. It's easy to miss though!


Add datastructure and tools for building and printing stack traces / ref trees conveniently

Context
Building stacks will be a very common thing to do in profiler, either stacks by occurrence, stacks by thread group, reference tree, ... It's worth making something generic and convenient to use.
Example usage
Let's say we want to print stacktraces:
We make a sequences field in out profiler
pub sequences: HashMap<Vec<FunctionID>, usize>

Vec<FunctionID> is the stack, usize is the number of times this stack was encountered. This is convenient to use and very performant while the profiler runs since there is no search to do, everything is O(1).
When we're done profiling, we build a tree using
let mut tree = TreeNode::build_from_sequences(sequences)

Then we can sort our tree let's say by descending inclusive calls (this is usually what we want) with
tree.sort_by(&|a, b| b.inclusive.cmp(&a.inclusive));

Then it should be a lot easier to print our stacks into HTML or whatever

After reviewing the TreeNode structure in  this pull request and providing some feedback, I must say that overall it was very well done. Great work!


Let's encrypt certificate for tochangeeverything.com

https://tochangeeverything.com has a self signed ssl certificate which is invalid. It'd be nice to have a valid SSL certificate even if it's a domain that is only use to redirect to cwc.im/tce it's steal pretty clean and used by the social media team. :)

We still have to generate a SSL certificate for the domain and make it point to https://crimethinc.com.

https://crimethinc.com/tce
Works now. 👍🏻


As a team member, I want a particular folder labeled as Sprint 3 to record all the Sprint 3 files.

A separate folder is required to store all the related files.

This task is completed.


Automated Package Upgrade

:tada: This PR is included in version 5.3.29 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Issue with integration with SerialName annotator

I was forced to remove the usage of SerialName annotator from KotlinX Serialization library together with HasOne/HasMany/etc annotators from JsonApiX library, as it didn't recognise the new variable name.
@ToshevIvan If you have something to add to the description of this issue or make it clearer

So as far as I remember,  when we use HasOne/HasMany kind of annotators, the field is serialized by its name, so even though the @SerialName is added it doesn't have an effect., so this leads to use the response property names with snake case or whatever are defined in there.


About/Sponsors/Other Page

This could also be a handy place to throw some "useful resources", i.e. team captain vs team member vs committee member specific links (determined by the logged in user)

Contract with the sponsors says that the one's who have a logo on the website need to have logos on the home page of the app. my proposed solution is to keep the list of names in the about page and throw logos into the home feed randomly (ad style),


count-metapaths-to not returning metapath_count

https://search-api.het.io/v1/nodes/?search=Alitretinoin&limit=100&count-metapaths-to=20115 returns
{
    "count": 1,
    "next": null,
    "previous": null,
    "results": [
        {
            "id": 21150,
            "identifier": "DB00523",
            "identifier_type": "str",
            "name": "Alitretinoin",
            "properties": {
                "url": "http://www.drugbank.ca/drugs/DB00523",
                "inchi": "InChI=1S/C20H28O2/c1-15(8-6-9-16(2)14-19(21)22)11-12-18-17(3)10-7-13-20(18,4)5/h6,8-9,11-12,14H,7,10,13H2,1-5H3,(H,21,22)/b9-6+,12-11+,15-8-,16-14+",
                "source": "DrugBank",
                "license": "CC BY-NC 4.0",
                "inchikey": "InChIKey=SHGAZHPCJJPHSC-ZVCIMWCZSA-N"
            },
            "metanode": "Compound"
        }
    ]
}

Note that metapath_count is missing, but there should be results:

@vincerubinetti it seems to me that count-metapaths-to never works when search is specified.

I amended the last commit to https://github.com/greenelab/hetmech-backend/commit/e73ccb4363f669ba04119a798d2ff579dd7f83b7, this should fix it I hope! I fixed this last week but forgot to push upstream.

Odd. I could've sworn this was working before, that is count-metapaths with search specified.

Amending commit broke backend https://circleci.com/gh/greenelab/hetmech-backend/190 @dongbohu we need to force pull and in future I will protect master branch

I did force pull on backend server. It should be working as it was before the amending.


Fix memory_order invocations to be inline with C++20 changes

Fixes #1401

I think we should be able to merge this as is. While using OpenMP or a standard way of doing atomics would be an improvement, this can be exported to an issue and adressed in another MR.

after #1436 is merged, we should rebase this and run check_pr again

rebase!

format!


Move verify container resources to a separate function

docker set is gonna need it, and it moved OomKillDisable to Resources.
Signed-off-by: Qiang Huang<EMAIL_ADDRESS>

@hqhq what's the use case of oom kill disable to be in Resources and be editable by a future -maybe- docker set? if a container is under oom and I want to fix it I either increase the memory in its cgroup or kill it. Is there anyone disabling the oomkiller in the contianer if the container is under oom? (I had a look at this issue as well #14440)

@runcom It's flexibility user might want, some people just don't want processes in some containers being killed, but they might not consider this until oom really happens (by default, oom-kill-disabled is false), and it can't always be fixed by increasing the memory limit, such as they overcommitted, and memory are consumed unexpected by other containers. In this case, they want some containers disable oom-killer, want processes in these containers hang instead of being killed when ooms happen.

@hqhq make sense, @tiborvass @vdemeester wdyt about oom-kill-disable to be settable?

@runcom good question... i'm not sure. Should we make all cgroups settable or only some? What's the usecase for modifying oom-kill-disable on a running container?

What's the usecase for modifying oom-kill-disable on a running container?

this was my initial question, @hqhq comment above explain it better (even if I'm still not totally sold :)

@hqhq this needs a rebase.
@tiborvass @hqhq I was also thinking if we could move the oom-kill-disable move out from this PR so the verify resources in another func can be good to review and merge instead of holding it further. WDYT?

@runcom I removed oom-kill-disable part in this PR, let's just do one thing and move on, I'll open a new PR when this is merged.
Rebased, thanks.

LGTM

@hqhq sorry needs another rebase!

@tiborvass Rebased, windows failtrue seem not relevant.

LGTM 🐹

ping @tiborvass


License text unknown

Hi, in setup.py, you mark this project as BSD licensed, however, i cannot see the actuall text of the license.
Since OSI Approved :: BSD License can mean multiple licenses, could you please include a LICENSE file with the text?
Thanks.

You're right, I've added the license file :)


Error: open /tmp/portainer.yaml: permission denied

Expected Behaviour

Installing portainer with arkade should complete w/o error.
Current Behaviour

Trying to install portainer fails with this error:
Error: open /tmp/portainer.yaml: permission denied
Steps to Reproduce (for bugs)

curl -sLS https://dl.get-arkade.dev | sudo sh
ark get helm
sudo mv /root/.arkade/bin/helm /usr/local/bin/
sudo chmod 755 /usr/local/bin/helm
ark install portainer

Context

After setup k3s HA on 3 node cluster I want to install some applications.

Check at: https://github.com/sponsors/alexellis

[ ] Yes
[X] No

Not reproducable after fixing issue svclb-traefik- CrashLoopBackOff

@Waterdrips any thoughts?

@cmonty14 if arkade / k3sup are both of use to you, please consider becoming a sponsor using the link above. You're also welcome to join the community on OpenFaaS Slack

I'd guess /tmp/portainer.yaml was created by root on a previous run? Or /tmp/ permissions are not writable on the system

@cmonty14 were you running arkade with sudo or as root?


IntrinsicWidth doesn't honor errorText of TextFormField

Steps to Reproduce

Run flutter create bug.
Change the main page to:

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: IntrinsicWidth(
          child: TextFormField(
            initialValue: 'empty',
            decoration: InputDecoration(
              isDense: true,
              border: UnderlineInputBorder(),
              errorText: 'Some error got trucked',
            ),
          ),
        ),
      ),
    );
  }
}

Expected results:
The error message should not be trucked. Is this a bug or expected behavior? Appears on both mobile and web.

flutter doctor -v
[✓] Flutter (Channel dev, 2.1.0-10.0.pre, on Mac OS X 10.15.7 19H15 darwin-x64, locale en-GB)
    • Flutter version 2.1.0-10.0.pre at /Users/maple/work/flutter
    • Framework revision cc9b78fc5c (10 days ago), 2021-02-25 13:26:03 -0800
    • Engine revision a252ec09b7
    • Dart version 2.13.0 (build 2.13.0-77.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/maple/Library/Android/sdk
    • Platform android-30, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.54.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 88.0.4324.192

• No issues found!

code sample
import 'dart:ui';
import 'package:flutter/material.dart';

void main() => runApp(MaterialApp(home: Test()));

class Test extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: IntrinsicWidth(
          child: TextFormField(
            initialValue: 'empty',
            decoration: InputDecoration(
              isDense: true,
              border: UnderlineInputBorder(),
              errorText: 'Some error got trucked',
            ),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 2.1.0-11.0.pre.145, on macOS 11.2.2 20D80 darwin-x64, locale en-AO)
    • Flutter version 2.1.0-11.0.pre.145 at /Users/pedromassango/Code/flutter_master
    • Framework revision a0ba646408 (2 days ago), 2021-03-05 22:09:03 -0500
    • Engine revision f751d04fa0
    • Dart version 2.13.0 (build 2.13.0-107.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 54.0.3
    • Dart plugin version 203.7759

[✓] VS Code (version 1.54.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.2.2 20D80 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 88.0.4324.192

! Doctor found issues in 1 category.

Anyone knows if there is workaround for this?


Fix rendering when editing workspace description

This change corrects an issue where the toolbar does not appear when editing the workspace description in side by side mode.

It's definitely better having the edit bar. However you enter full screen mode if you click "Toggle Side by Side" or "Toggle Fullscreen", so that the top bar of the workspaces is no longer visible. Is that the desired behavior?

This is definitely better than the current experience. However when you click on the "Toggle Side by Side" or "Toggle Fullscreen", the workspace tab bar is lost when you enter full screen. Is it possible to have both tool bars?

Some background on this change: This issue came up in the user liason channel and is a bug that was introduced.


[Question] How can I fix imports when formatting?

Hi, I'm having a hard time trying to find how can I enable the fix imports feature, e.g removing what's not being used on format.
I saw this dart doc but I'm not sure where to put that on the config. I suppose it goes somewhere in the lsp setup.

I have an auto-command which runs before saving and performs the "Fix all" and format actions. Here is my config: https://github.com/sidlatau/dotfiles/blob/a6eca91c6cbbfb32e907a31a3ce411d2b4a49ad7/nvim/.config/nvim/lua/config/autocommands.lua#L5-L19


AuthService.Authorize not redirecting to auth0 in preview5

Hi, upon upgrading to server side preview 5, when I click login (AuthService.Authorize), I'm being redirected to  /account/authorize and getting:

Sorry, there's nothing at this address.

Insted of the auth0 login page, this same code was working on preview 4, and does work for client side in preview 5 as it is in a shared library. Looks like the routes for /account are not being registered as before for the server side. If I enable     "RequireAuthenticatedUser": true, the login redirect loops infinitely.
I appreciate your help.

I'll take a look and see if it would be resolved today EOD, thanks for reporting this issue.

Sorry, I was unable to reproduce the issue at first hand. Would you please provide more details in how to reproduce it? which settings are you currently using?


[TC] [Bug] [Nondet] Foo.java had misaligned colorings

https://github.com/jamesqo/1_LanguageTesting/blob/master/Foo.java
The bug seems to be non-deterministic because when I opened the file again with the same build of the app, the colorings were aligned again.

Dupe of #97


[3] #268 Enable creating a new committee member via GUI?

Original issue https://github.com/bitshares/bitshares-ui/issues/268

Please make sure to use style guide for new modals, thanks!


using promise-btn with [input] element and ng-change

Hi,
I have an input element for searching data and the promise is fired with ng-change like this:
<input type="text" ng-model="searchItemsInput" ng-change="searchItems(searchItemsInput)" promise-btn>
Is there away that I can make it works with an (input with ng-change)?
Thanks in advance.

You could try changing the click event listener to input:
    CLICK_EVENT: 'input',
    CLICK_ATTR: 'ngChange',

Thank you for your answer.
Actually I couldn't tackle it correctly. Could you please have a look on this
plunkr and advice accordingly

This needs to be changed in the config phase via a config function as it is not possible to change the event handlers at runtime.

http://plnkr.co/edit/i7lHig4NlKtiPAEa7UdN?p=preview

Actually I have tried to change it in the config phase before putting in the attribute not nothing showed up.
I can't see the indicator in the plunkr you sent. Does it work at your side?
(if not, do I need to do an extra CSS stuff?)

Thinking about it. It probably won't work because you can't append html to inputs and you also can't  use pseudo classes with them: http://plnkr.co/edit/i7lHig4NlKtiPAEa7UdN?p=preview
So no promise btns doesn't work with inputs.

I think you are very close to the solution!
Could the input be wrapped in  like this

      <input type="text" ng-model="searchItemsInput" ng-change="myPromise()" promise-btn/>

Here I'm relying on the is-loading class.
You can find this working example:
http://plnkr.co/edit/i7lHig4NlKtiPAEa7UdN?p=preview
For me I'm satisfied with this approach but I'm sharing this in case you see it can be done as a built-in feature.
Thnx

For wrapping support this directive would need a major rewrite. As it's called angular-promise-buttons I don't see this happening any time soon :)
But maybe this is helpful to you: https://github.com/cgross/angular-busy

Maybe it makes more sense to be as a different directive, angular-promise-input :-)
Anyway, thanks a lot for your effort!


Issue while deleting the image using backspace or delete key with react-quill library

Cannot read properties of undefined (reading 'find') at HTMLDocument.checkImage
Getting this error on console.
I am using quill-image-resize-module with react-quill library.

any update on this @rjrahul98 ? did you happen to resolve this issue?


Update VtR to newest revision

vtr-v8.0.0_rc1_1532_g92e57c2d0_127_g7b9b69d0e_428_g1c5263d74_0000_g1c5263d74-20191211_090908

Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>

v2x tests fail due to a failure at the packing stage. I have filed an issue on VtR upstream to get some insightful information on the problem (https://github.com/verilog-to-routing/vtr-verilog-to-routing/issues/1062).
v2x tests are run only in Travis I suppose, hence the failure couldn't be caught in the VtR + symbiflow-arch-defs kokoro build.

v2x tests are run only in Travis I suppose, hence the failure couldn't be caught in the VtR + symbiflow-arch-defs kokoro build.

Opps.  Can you submit a PR to https://github.com/SymbiFlow/vtr-verilog-to-routing-kokoro/blob/master/steps/arch-defs-test.sh to fix that.

@litghost done: https://github.com/SymbiFlow/vtr-verilog-to-routing-kokoro/pull/7


linkedin_oauth not working

The linkedin_oauth is not working as it is just gives the header in response than the callback url so I am not able to link my linkedin account with meetup.com

for issues related to the site, please write in to<EMAIL_ADDRESS>


Update crds with ones from libcalico-go

Description

Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit 6b816fc771583f10c893bf8455b8b03a4bf63b19
https://deploy-preview-3649--calico.netlify.app


Internet Explorer 11 (IE 11) and MS Edge - Text input shows large reset x

Problem description
If there is already an issue concerning this topic, feel free to close.
When inserting text into the text input component, the IE11 and Edge show a (very large) reset X. Other browsers don't show the x. The size of the x is also not appropriate to the rest of the text(input). It just looks weird.
IE 11

Edge

Link to minimally-working code that reproduces the issue
http://www.material-ui.com/#/components/text-field
Versions

Material-UI: 0.17.0
React: 15.4.2
Browser: Internet Explorer 11
OS: Windows 10

It's a duplicate of #5055.


Escape key doesn't start multiline mode

Pressing escape doesn't cause the app to behave any differently than not pressing it. The effect is that multiline mode cannot be entered.
Output from Firefox 35.0.1 on Windows 7
opal> def foo
FOR:

============

Output from Chrome 39.0.2171.95 (64-bit) on Linux Mint 17
opal> def foo
FOR:

============
SyntaxError: unexpected 'false'
    at OpalClass.$new (http://fkchang.github.io/opal-irb/compiled/application.js:3123:15)
    at $Parser.def.$raise (http://fkchang.github.io/opal-irb/compiled/application.js:2800:31)
    at $Parser.def.$_racc_do_parse_rb (http://fkchang.github.io/opal-irb/compiled/application.js:16902:16)
    at $Parser.def.$do_parse (http://fkchang.github.io/opal-irb/compiled/application.js:16796:21)
    at $Parser.def.$parse_to_sexp (http://fkchang.github.io/opal-irb/compiled/application.js:19564:23)
    at $Parser.def.$parse (http://fkchang.github.io/opal-irb/compiled/application.js:19547:23)
    at $Compiler.def.$compile (http://fkchang.github.io/opal-irb/compiled/application.js:25425:56)
    at $OpalIrb.def.$parse (http://fkchang.github.io/opal-irb/compiled/application.js:25928:103)
    at $OpalIRBHomebrewConsole.def.$process_saved (http://fkchang.github.io/opal-irb/compiled/application.js:26054:27)
    at http://fkchang.github.io/opal-irb/compiled/application.js:26102:23

Hi @andrew-carroll
I'm a little confused, was there a typo?  You don't use escape to enter multi line mode, you hit ctrl-M (when you type help it shows you the controls).  The only time escape works is to the dismiss the multi line editor.


Update data, and raw option, add docs  + tests

Address https://github.com/allisonhorst/palmerpenguins/issues/44#issuecomment-652674104.

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #1   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            3         3
=========================================
  Hits             3         3

Impacted Files
Coverage Δ

src/PalmerPenguins.jl
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c991627...8f91499. Read the comment docs.


Add address generation in I²C write

According to the datasheet "6.2.1 I²C write" (and to my user C code), the address of each register has to be specified.

You're welcome


Disallow overriding email template replacement parameters

Rationale
EmailTemplate seems to let subclasses override replacement parameters, but the behavior is inconsistent (e.g., duplicate parameters appear on the customize page). This just seems like a bad idea, so remove existing overrides and add a check to prevent others in the future. Should fix MessagesLongTest, which flagged a related change in behavior.
Related Pull Requests

https://github.com/LabKey/platform/pull/2439

Changes

AnnouncementDigestProvider: remove redundant override of folderName; just use folderPath
ReportAndDatasetChangeDigestEmailTemplate: remove redundant overrides of folderUrl and folderPath
Add assert that disallows adding a parameter that matches an existing parameter name for that template

The two places that enumerate getAllReplacements() resolve names via equalsIgnoreCase(). Would be nice if these were held in a (case-insensitive) map instead of constantly enumerating, but I'm done making changes for now.

MessagesLongTest passed with this change: https://teamcity.labkey.org/viewLog.html?buildId=1474524&buildTypeId=bt20&tab=buildResultsDiv&branch_LabkeyTrunk_DailySuites=foldName_vs_folderPath


feat(retry): implement default retry behavior for Lambda

Current dependencies on/for this PR:

main

PR #2   👈

This comment was auto-generated by Graphite.


refactor(PackageBasedScanStorageReader)!: Align read() to take a Package

A package based reader should indeed take a Package for all its read() functions. This aligns with the existing read() function that takes a ScannerCriteria, and it is a requirement for a proper implementation of ClearlyDefinedStorage which uses coordinates with a "provider" for lookup that can only be correctly constructed when provenance information is available. So far the ClearlyDefinedStorage hard-codes some assumptions in this regard, which will be corrected in upcoming changes.

But I would be fine with looking into it after fixing the ClearlyDefinedStorage.

Thanks. I was considering an API like for PackageConfigurationProvider which has provenance: Provenance in addition to packageId: Identifier:
https://github.com/oss-review-toolkit/ort/blob/89c626ed4cf659d50f2f0d9c9a4e37c49740b1c1/model/src/main/kotlin/utils/PackageConfigurationProvider.kt#L41


Need complete Setup of Jolokia for accessing the api url for EKS cluster

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
Optional. A clear and concise description of any alternative solutions or features you've considered.
Additional context
Optional. Add any other context or screenshots about the feature request here.

@gnaveen33 the broker pods enable the jolokia instance embedded in the console by default. You can use the field deploymentPlan.jolokiaAgentEnabled to enable a full jolokia agent.
apiVersion: broker.amq.io/v1beta1
kind: ActiveMQArtemis
metadata:
  name: ex-aao
  application: ex-aao-app
spec:
  deploymentPlan:
    jolokiaAgentEnabled: true

@brusdev, thanks for the response.
Now, how to access the jolokia api url

in Active mq console,
under JMX tab i could see jolokia config info with attributes an operation info.
But I'm not able to see any other info for accessing API url.
can you please let me know on this.

Thanks for update.
Any sample post call to create queue using this Jolokia api url?

@gnaveen33 I would recommend you to use broker properties, i.e.
apiVersion: broker.amq.io/v1beta1
kind: ActiveMQArtemis
metadata:
  name: artemis-addresses
spec:
  deploymentPlan:
    image: quay.io/dbruscin/amq7-amq-broker-rhel8:7.11
    initImage: quay.io/dbruscin/amq7-amq-broker-init-rhel8:7.11
  brokerProperties:
    - "addressConfigurations.test-address.routingTypes=ANYCAST"
    - "addressConfigurations.test-addressqueueConfigs.q1.address=Test2"
    - "addressConfigurations.test-address.queueConfigs.q1.routingType=ANYCAST"
    - "addressConfigurations.test-address.queueConfigs.q2.address=Test3"
    - "addressConfigurations.test-address.queueConfigs.q2.routingType=ANYCAST"

For specific questions related to Apache ActiveMQ Artemis, you could send an email to<EMAIL_ADDRESS>

@brusdev thanks for update.
Have dropped mail to above mail id, meanwhile can you please suggest which is best API method to use for artemis active MQ using EKS cluster?

@brusdev , need an info like can we push and pull messgaes in bulk using JMX\JOLOKIA API call ?

@gnaveen33 Hi as @brusdev said if you want to create a Queue, you can just use brokerProperties to do that.
Jolokia API is just http calls so you just can use any http client to access it (provided you have the correct user/password). For example if you use curl you can do this to create a queue:
curl -H "Origin: http://localhost" -u user:password http://localhost:8161/console/jolokia/exec/org.apache.activemq.artemis:broker=\"<IP_ADDRESS>\"/createQueue\("java.lang.String","java.lang.String","boolean"\)/testQueue/testAddress/true


Fixes itemExtent being incorrectly assigned to renderObject.minExtent…

Fixes #153694
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Even with this change, when I hot reload only the first item shifts to the left side by a fixed offset.
Check this video.
https://github.com/user-attachments/assets/663ea367-8156-4487-bc1a-fd42c47db1f3

Even with this change, when I hot reload only the first item shifts to the left side by a fixed offset. Check this video.
Screen.Recording.2024-08-21.at.17.05.26.mov

Oh, I see. I'll check.

Few observations:

I have noticed this behaviour only for the item at index 0 and all the other items works as expected.
Using setState does not cause this behaviour. Only with hot reload.
If we remove the early exit statement from either or both the minExtent (LN556) and maxExtent (LN546) setters (basically if we call the markNeedsLayout) then this behaviour does not trigger.

Even though it works, whenever you use a setState it will do this.

@Mairramer Please check for item at index 0.
I know this is very strange, I am also confused as I tried to debug thoroughly but could not find anything. I will try this on a different device/emulator and with clean build and will update here.

@Mairramer can you update the title where it has been cut off? Including an explanation in the PR description would also help provide context to reviewers. Thanks!

@Mairramer Please check for item at index 0. I know this is very strange, I am also confused as I tried to debug thoroughly but could not find anything. I will try this on a different device/emulator and with clean build and will update here.

Could you share a code sample to reproduce this? That would be super helpful!

Has the issue described by @/gaganyadav80 been resolved or is it deemed unreproducible?

Has the issue described by @/gaganyadav80 been resolved or is it deemed unreproducible?

I wasn't able to reproduce the issue but this PR fixes the issue https://github.com/flutter/flutter/issues/153694


Fix illegal chars in app file name

This modification prevents errors due to illegal characters in the app file name that occur when such characters are used in the app name.
Illegal characters are now simply removed from the app file name (which is in line with the behavior of the VSCode AL extension).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: haweg sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Hello @freddydk , I just saw a little mistake I made in the Sort-AppFoldersByDependencies.ps1 (line 96 & 97). Is it best when I open a new pull request for this?

Yes please, this one is closed, thanks for the help btw,


Link forwarding / accessing itwêwina via old NDS link

Feedback #32 (May 17, 2021)
What is the website address (URL) of the page where you found the problem?

https://altlab.ualberta.ca/itwewina/crk/eng/
Tell us what you think was SUPPOSED to happen.
I was expecting to go to the regular home page.
Tell us what ACTUALLY happened instead of what you expected.
The link to the home page given above appears to be broken (leads to a 404 page). Accessing the dictionary through googling now leads to what looks like a much older version of the dictionary (e.g. the option to add long vowels by clicking is gone now). I'm not sure what's happened, but this seems like a reversion, not an update.

In Wordpress, I have added a redirect so that https://altlab.ualberta.ca/itwewina/crk/eng/ now goes to https://altlab.ualberta.ca/itwewina/, the page that describe itwêwina and has a “Yes! Take me to itwewina!” button

This seems to be working now.


user12986714: Blacklist tracklify.com

user12986714 requests the blacklist of the website tracklify\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

tracklify\.com has been seen in 0 true positives, 0 false positives, and 0 NAAs.

It is now 7/0.

Approved by Makyen in Charcoal HQ


netrw hijack current doesn't reset options after opening a file

I am using neo-tree with the hijack_netrw_behavior = "open_current" and when I run nvim . and select a file neo-tree is not appropriately setting the options back to what they should be before it was opened. I would expect it to save the values of the options before the window is opened in the buffer, then set them back appropriately when neo-tree is closed.

I don't do anything to explicitly save options and restore them. It's actually not necessary because all options that neo-tree applies are set with setlocal.
The problem in the linked issue is tied specifically to opening new buffers from a neo-tree window, which seem to take on whatever settings were applied in the prior buffer. So it's not a matter of restoring previous settings so much as it's a matter of applying the default settings for the first time instead of taking the local settings from the prior buffer.
I've never noticed this before because I tend to explicitly set the things I care about in filetype autocamds.
There's probably an option that controls this behavior, I'll look around.

@cseickel this is because of the setlocal options. When netrw hijack uses the current it is using the same window that the buffer will be in if I open a file or simply close neo-tree. setlocal here is controlling buffer and window level options. wrap here being a window level option. So it is changing it for the window which is still there for the file when neo-tree is closed. wrap is specifically not a buffer level options (check with :h wrap)

Also in the linked issue we are setting up the options prior to neo-tree being run. When I go in and manually remove the setlocal options from the source code this works as intended because the options are not being overwritten by neo-tree and then not being set back.

wrap is specifically not a buffer level options (check with :h wrap)

I guess I will need to add a save / restore step then. I'm surprised this hasn't come up before.

A fix has been merged to main. I'm going to use it for a day and make sure it's solid before releasing. If you are able to test it out as well, please do and let me know if you have any issues.

I'll give it a test as well for the next day or so. Thanks for looking into it!

I did find some glitchy behavior today where it restored the wrong settings to certain buffers, namely terminals that got line numbers. I think I fixed that with the latest which was just merged from #693.

I've been testing the master branch of neo-tree today, and it looks like there is no problem until now.

What problem have you found @ZhaoZuohong ? Also what do you mean that there was no problem before?

@mehalter I mean I was testing latest commit of neo-tree with AstroNvim. When I open file from netrw mode of neo-tree, there is a message says: [Neo-tree INFO] Window settings restored and when I check the status of buffer with :set wrap?, it says wrap which is the correct.


issue-150

Description
Follow-up of issue #150
~Changed outdated first steps documentation.~
also  added more information about the contract address for more clarity for first users
The description described in the book does not work upon testing.
I wrote the method used in the video presentation

The addresses of the documentation were outdated, I first thought that the method was deprecated and following the tutorial from the README.md I added the method shown in the video.
exploring more the docs I noticed that the addresses of the contracts were wrong, I retried the first method with the correct contract and worked, so I then re-added the method with the correct contract address and added clarifications


Implement Re-resolution in the C driver

[x] Canonical Form Changes
[x] Add name resolver and interact with netutil sanely
[x] Define extension/abstraction points
[x] Add stubs for testing.
[x] Counters
[x] Re-resolution config
[x] Check for re-resolutions in sender

Implemented by #883.


AllAccessDisabled on S3 bucket

Hey there. Looks like there's an issue with access to the bucket referenced in final.yml. When I try to upload a bosh release I observe the following:
bosh upload-release releases/telegraf/telegraf-4.yml
Using environment '<IP_ADDRESS>' as client 'admin'

-- Started downloading 'telegraf/766dd51db72db6adba3f1f59c227e0c23afd71cb' (sha1=30aab3dd9e16830e39660061969d8a15adc84870)

-- Started downloading 'telegraf/c6b05789cfd02de27b20cb7913d004fc59694b12' (sha1=ef11ad3cf0a68595538999505fdb88dfdd426e22)

-- Failed downloading 'telegraf/766dd51db72db6adba3f1f59c227e0c23afd71cb' (sha1=30aab3dd9e16830e39660061969d8a15adc84870)

-- Failed downloading 'telegraf/c6b05789cfd02de27b20cb7913d004fc59694b12' (sha1=ef11ad3cf0a68595538999505fdb88dfdd426e22)

And indeed this is confirmed by the aws CLI:
❯ aws s3api list-objects --bucket telegraf-release-blobs

An error occurred (AllAccessDisabled) when calling the ListObjects operation: All access to this object has been disabled

Would you please have a look at the bucket / auth for the bucket? Thanks!

FYI @vito we last saw it working on 28th May. We use it in Control Tower, and releases are currently blocked on this.

Sorry yall, I didn't realize other folks were downstream of this release. The AWS account that contained this release's S3 bucket has been closed; it predated our migration to GCP and was just running up a bill for things we no longer use.
I would recommend forking and restoring the package blobs manually, starting over with a new final release. There wasn't anything bespoke about package blobs; it was just the vanilla release tarball from upstream. I would be happy to transfer the repo if you like, otherwise I'll archive it soon to make it clearer that it's not maintained.
Sorry again for the sudden breakage and chore. :(

Understood, thanks @vito! We'll fork this and use our own bucket 🖖🏻


[BUG] ion-range not working inside pane

Describe the bug
 not working inside pane
To Reproduce
Steps to reproduce the behavior:

Go to https://stackblitz.com/edit/ionic-angular-v5-cvaevs?file=src/app/app.component.html
Click on button "open pane"
Try to change (click on circle then try move it on right/left direction) range inside pane

Expected behavior
Range inside a pane can interact with touch events.
Desktop (please complete the following information):

OS: [emulator 10.0 (Q) - API 29]
Browser [Cordova WebView]

Thank you for issue @davayd
Bug reported here

Closed, as it not Cupertino Pane bug and reproducible without Pane.
https://output.jsbin.com/xufazic
@davayd Please write in issue to ping ionic-framework developers here


Recipes not working in latest 1.21 release

Seems some tags were done incorrectly making recipes invalid

af944749cbfee447a798bd578b9976ca6de366eb


Adding an abstraction for log segments

This commit adds the abstraction for representing log segments. Log segments will
form the components of a larger log abstraction. For design and discussion please
refer to https://github.com/linkedin/ambry/issues/469.
Please use the current implementation of Log as a reference.
Built (./gradlew build && ./gradlew test) and formatted.
Primary reviewers: @pnarayanan, @nsivabalan
Expected time to review: 60-90 mins
Unit testing

Class
Class, %
Method, %
Line, %

LogSegment
100% (2/ 2)
100% (17/ 17)
100% (94/ 94)

@nsivabalan @pnarayanan Addressed comments.

@nsivabalan @pnarayanan Removed state change logic out LogSegment as suggested. Please take a look.

Looks good except for some minor comments.

@nsivabalan Addressed those comments.

@pnarayanan Addressed all comments.
@nsivabalan the concept of log segment state has been removed (because it does not make sense anymore). You might want to have quick look at the two most recent commits.

So, we are going to rely on the Log or the caller to ensure we don't write to a sealed segment or start writing to an active segment assuming it was a free segment is it ?

the Log, yes - since it knows which segment is "active"

@vgkholla : I get the over all picture. But then, log segments are not used only by Log alone. We will have compaction threads dealing with log segments, hard deletes directly dealing with compactions. So, how are we going to guard against mishandling from those callers. From what I could think of is that, those log segments will be given out by Log and hence they (compactor) are not allowed to step into any other log segments. But shouldn't the LogSegment themselves have guards against such mis-handling?

@nsivabalan Compaction will also use the Log abstraction (more details in the design document and the gist) and not deal with log segments. Hard Delete uses writeFrom() which does not do state checking anyway - so I think there is no problem.

LGTM


Add documentation for how to update CQL within MyCarePlanner

Include as a md file and link to one main one.
Stand up development environment.

CQL developer docs are now committed in the 'develop' branch and will be merged into 'main' by tomorrow.
https://github.com/chronic-care/mycareplanner/blob/develop/documentation/developer-cql.md


Dropping tables with Foreign Keys

The progress block right now is foreign keys (from linkage) blocking tables from being dropped and created (tables from last execution not being able to be dropped) on new executions. Solutions I've found are:

Finding a way to destroy all FKs at the end of the program (before the system exit)
Using "SET FOREIGN_KEY_CHECKS = 0;", dropping a table, "SET FOREIGN_KEY_CHECKS = 1;" at every instance of a DropTable to drop it.
a. My thought line is, if we do this at every drop table, there will be no FKs left to mess with droppage. But, this leaves tables in the DB if a table is created in one execution, but not in another -- essentially, it gets created, but never dropped on subsequent executions of the program, so it stays there permanently. This creates clutter, right?
Dropping the Database. (Last choice)

@aubertc , what do you suggest? I'm leaning towards 2, but know there might be unintended effects I don't know about that such a method would cause.

This may be a XY problem: why are you trying to block the tables in the first place? Your program should be able to update the tables, rather than dropping everything and starting from scratch.
Now, for debugging purposes, it could be useful indeed to "start fresh", but in that case, all the databeses should be dropped, and not just the foreign key constraint.

Right. I just worry that, by overwriting/updating tables, there will be leftover entries from other executions. Is that a legitimate fear?

Right. I just worry that, by overwriting/updating tables, there will be leftover entries from other executions. Is that a legitimate fear?

This is a more complex discussion that we should maybe have in-person.
What is this software exactly trying to achieve?

One-time process
Is it a "one-time process" that takes one (or multiple) databases, and output one spreadsheet with the all data linked and tidied?
E.g. it takes databases from the NSF and the NIH and output one single spreadsheet containing the combined information?
Spread-sheet calculator
Is it a "spread-sheet calculator" that process data inside its database and output one spreadsheet with some parameters fixed?
E.g., it loads data from the NSF, the NIH, etc. once and for all, asks for user-input, and output the spreadsheet containing the information relevant to the user-input.

I believe that, ideally, it should be a software

that has an internal database of databases (so, one table for the NSF entries, one table for the NIH entries, etc.), that can be expanded and tweaked,
that connects those databases using additional tables to "link them",
that can output, based on current information, spreadsheets containing all the information, or the information filtered along different criterias.

Then, if a new database is added or if a database is updated, the process should be:

look if this database is already in the set,
if it is, observe the differences,
if new information was added, add it to the program's database,
if old information was deleted, remove it <--- I believe this is what you were asking,
if the new information conflict with what we have, then indeed we need to think about that case (I believe I would simply take the new information).

In all of those cases, I don't think that dropping anything is needed, but may be wrong.

if it is, observe the differences,

This is a complicated problem, but we can find ways. One possible process is (here, I am supposing that dataA.csv had an older version loaded in the table DataA in sql):

Create a temporary table, DataATemp,
Compare DataA and DataATemp (probably by PK),
If an entry is in DataATemp but not in DataA, insert it,
If an entry is in DataA but not in DataATemp, delete it,
If an entry is in both DataATemp in DataA, then … more work is needed, and we can cross that bridge when we get there.

Oh, and there are probably tools that can do that for us, I can investigate if you want.

After reading this, I agree that the internal databases should be kept over multiple execution, and that this is very complicated.
For the purposes of building/testing/improving the matching system, I want be able to start over until we are confident that the matching methods/algorithm are solid. Once its at a good spot, making it consistent across executions sounds like a good way of going about it.

For now, I can just drop the database to get around the FK constraint errors, right?

Yes, absolutely, you can always "start fresh" and dump everything at the end of each execution.

Then I will start on this.

Ok, that's probably a good first approximation: make it work without the "updating" capacities. It will be slower, but it will be easier to debug / test.

Added method to drop the db and create it before doing anything else in SQL. Now I can access the matching function.

I guess we can close this issue, now, and potentially open another one to discuss the "let's update instead of dumping everything" issues.

That sounds like a plan.


Reuse schema data among CS on the same node

Schemas consume over 10% of memory allocated by CS. Reusing this data among column shards on the same node will significantly reduce the memory footprint.

Reduced schemas' memory footprint by 5 times, freeing 4.5GB per node on YAEM Exp:


Fix code factor issues

40f99b3  version v1.3.9
304e657 config: fix tests
24b5980 update Makefile
a57f44a (tag: v1.3.8) version v1.3.8
fb21dd3 db/mongo: fix linter warnings
578b866 db: fix linter warning
05977e7 converter: fix linter warning
e8d761c config: fox linter warnings
7daee86 main: fix linter warnings
a397aad update vendor
f8e7ca4 update modules
1ef5b23 fix imports sort and group
1d96740 update README
ec13e2d Merge branch 'fix-code-factor-issues' of github.com:oleg-balunenko/logs-converter into fix-code-factor-issues
f1c7870 main: use date instead build for ldflags
ec44183 scripts: refactor and update scripts
88645ce scripts: update compile script
3532af0 update makefile
8a9eddf rename docker-compose config
242bddf update travis ci config
cebfffa add goreleaser config
9ca1d5a add gloangci config
b7958a3 Merge branch 'master' into fix-code-factor-issues
7b7b0d7 config: fix duplication issue
f8e3e36 config: fix duplication issue (#7)
227d829 config: fix duplication issue
2527416 Update README.md (#6)
ced91ba Update README.md

Pull Request Test Coverage Report for Build 88

2 of 18 (11.11%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.6%) to 43.75%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

config/config.go
2
4
50.0%

db/interface.go
0
2
0.0%

main.go
0
4
0.0%

db/mongo/db.go
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

db/mongo/db.go
1
0.0%

Totals

Change from base Build 83:
-0.6%

Covered Lines:
154

Relevant Lines:
352

💛  - Coveralls


Add a feature flag to control native histogram ingestion

NOTE: sparsehistogram branch
Partially fixes #11168
This PR adds a runtime config to control only the ingestion of native histograms. How to control queries with this is still TBD.
I am introducing a new section in the config file for experimental features. WDYT?

I disagree that this should be controllable at runtime.

See also discussion on #11168 .
I would say let's implement the feature flag as a command-line flag for now. (We can still make it runtime-changeable when using TSDB as a library.) If needed, we can have the discussion about runtime-flippable feature flags separate from the introduction of the native histogram feature flag itself.

I have updated the PR to make it happen via CLI flag now

Fixes https://github.com/prometheus/prometheus/issues/11168

I'm wondering if we should close this issue even if the UI doesn't take it in consideration.
Overall it looks good to me. Thanks @codesome :)

I think it makes sense to turn on/off the autocompletion of the histogram keyword according to the flag. It will be consistent with the server status.

At the moment we can still query already ingested histograms if the feature is turned off, so I think we should not turn off autocompletion of histogram specific functions if the feature is not enabled. As a temporary workaround (before we have decided how histogram flag should work, for example disable querying on ingested histograms), a tooltip as @beorn7 suggested above makes sense. WDYT @Nexucis?
(PS: merging this PR and we can continue discussion in the linked issue)

@codesome we can start with a tooltip of course. I was just following the initial idea that was to remove the histogram functions in case it's not activated.


Remove old monitoring code.

Coverage decreased (-2.1%) to 71.658% when pulling 8bc59f8c3bd4db80df3989c362e08d26eb5c36e2 on refactor/prometheus into 691e3dc6f6a3276fdbbda7832b732416e454766b on master.


Refactor to use o11yphant metrics

Sounds good. This PR is just for back compatible to our old indy-monolith, but I agree that this o11yphant way is too complex and fragile. I'll take a look at the otel way in quarkus to do replacement, so this PR will be closed. Thanks for reminding!


BREAKING CHANGE: Using Start-Process instead of StartWin32Process

The submitted PR #123 changes the way SQL setup is launched. I thought this is such a major design change so it warrants a breaking change label. This is so a discussion around this change can be made.

@gigi81 @Zuldan Are we in agreement that this PR resolves issue #93?

What happens is the process hangs and never completes with Start-Process? Shouldn't Start-Job and Wait-Job be used, or something similar, so it can timeout and throw an error if the process doesn't complete. The timeout value could be a parameter set by the configuration.

@johlju maybe we could ask @kwirkykat to find out internally why StartWin32Process was used instead of using Start-Process. There is a lot of code in StartWin32Process so there would have had to be some good reason unless the helper function was initially created for something else.
With your solution...If a timeout is going to be used the maybe a timeout property should be exposed in the resource. The installation of SQL server varies greatly from server to server.

@Zuldan @johlju I asked the team and got no response. I don't think anyone here wrote this module.
StartWin32Process seems to wait for the process though whereas Start-Process does not.

Hi,
@kwirkykat Start-Process will be used with the -Wait flag, so it  will definitely waits for the process to complete.
@johlju about the timeout, I'm not sure is the correct way to go. If the sql setup is started it rather complete successfully or fails, but it shouldn't just hang. Killing the process while it's running might have more undesired effects then benefits in my opinion.
I also agree with @johlju that if the xPDT module is not used by any other resource it should be removed.
Considering the above, I will update the PR #123.
As a last observation, I don't completely agree on the fact that this should be marked as a breaking change as it's changing the internals of how the dsc resource works, and it's not affecting any end user interaction.

I agree with that killing the process would not be beneficial when debugging what's wrong and as you say, might be hard to recover from.
With this I can agree that we can skip the timeout and if there is an issue later on which a timeout might solve then that can be implemented at that time.
And regarding to the breaking change, good that we discuss this. I saw it first as a breaking change because of this text in the CONTRIBUTION.md; "Fundamentally changing an existing functionality of a resource". And the reason for that I thought of it as a breaking change was because it change (removed) so much code, and the way it started the process is different which needed to be discussed, but it does not changing the functionality of the resource, SQL gets installed. :)
When I read it back now, that line could be interpreted in different ways. So I can go either way.
But I think it wouldn't hurt for the release notes to say something like "BREAKING CHANGE: Reworked how SQL setup process is started". Then the users know something big happened :)
But as I say. I can go either way.

I think this will break compatibility with WMF 4.0 with respect to the SetupCredential parameter. WMF 5 added support for PsDscRunAsCredential, globally allowing resources to be executed under a given credential. The StartWin32Process function was part of the xPDT module to provide this same functionality to older versions of PowerShell. See this article for more information.

Hi @nabrond
I like your theory. The only problem is that, from what I can see, the SetupCredential parameter is actually not used to start the setup process. This would probably require a separate issue by itself. Please double check the code here in case I'm missing something:
https://github.com/PowerShell/xSQLServer/blob/dev/DSCResources/MSFT_xSQLServerSetup/MSFT_xSQLServerSetup.psm1

You are correct @gigi81; will need to log a separate issue. However, once that issue is resolved, it will introduce the compatibility issue I described here. However, once that issue is resolved, I think we'll be back to my point of WMF 4 compatibility.

StartWin32Process should be removed. It add a lot of overhead that is really not needed.

I agree with @Zuldan. I think it should use Start-Process and the documentation around the SetupCredential parameter should be fixed. Nobody never even noticed the setup was not run with the SetupCredentials, so I think it's not really a requirement.
In any case, as @nabrond correctly mentioned, If anyone needs to run the setup with some particular credentials, they can use PsDscRunAsCredential using WMF5.
I'm happy to modify PR #123 accordingly if some maintainer agrees and will be ok to merge the changes.


Sets CUDA_SEPARABLE_COMPILATION flag in blueos9 host-config

Summary
It seems that there was a conflict with setting the CUDA_SEPARABLE_COMPILATION
flag on one of axom's libraries (primal) and compiling axom's libraries as object libraries.
This fixes the weird compiler bug that @bmhan12 reported:
ptxas /var/tmp/han12/tmpxft_00002929_00000000-5_intersect_impl.ptx, line 435; error   : Illegal operand type to instruction 'ld'
ptxas /var/tmp/han12/tmpxft_00002929_00000000-5_intersect_impl.ptx, line 435; error   : Unknown symbol '_param_0'
ptxas /var/tmp/han12/tmpxft_00002929_00000000-5_intersect_impl.ptx, line 531; error   : Illegal operand type to instruction 'ld'
ptxas /var/tmp/han12/tmpxft_00002929_00000000-5_intersect_impl.ptx, line 531; error   : Unknown symbol '_param_0'
ptxas fatal   : Ptx assembly aborted due to errors

Specifically, I was able to compile your branch and pass all tests using the<EMAIL_ADDRESS>host-config.
Note: This PR is into @bmhan12's feature branch, not into develop.
I am adding others to this PR in case they see a better solution and/or object to setting this flag in our main GPU host-config for blueos9.

@bmhan12 --  Regarding the failing CI -- it looks like it is due to not guarding RAJA usage in your naive_intersect_raja  example.
cd /home/axom/azure-linux_gcc6-build/axom/spin/examples && /usr/bin/g++   -I/home/axom/azure-linux_gcc6-build/include -I/home/axom/src -isystem /home/axom/src/thirdparty  -Wall -Wextra  -fPIE   -std=c++11 -o CMakeFiles/naive_intersect_raja_ex.dir/naive_intersect_raja.cpp.o -c /home/axom/src/axom/spin/examples/naive_intersect_raja.cpp
/home/axom/src/axom/spin/examples/naive_intersect_raja.cpp:28:25: fatal error: RAJA/RAJA.hpp: No such file or directory
 #include "RAJA/RAJA.hpp"
                         ^

I realize it is a work-in-progress, but you should be able to get around that by disabling that example when RAJA is not available.
Specifically, this block:
https://github.com/LLNL/axom/blob/42b772a9675c5f9a2640932c7dea01bfe679af61/src/axom/spin/examples/CMakeLists.txt#L28-L38
should be guarded by
if(RAJA_FOUND)
   ...
endif()

@kennyweiss  Got it.  I'll merge this PR now, and add the guard in.