AzureResourceGroupDeployment@2 warring CorrelationIdForARM

Note
Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo
For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks
If you have an issue or request for the Azure Pipelines service, use developer community instead:
https://developercommunity.visualstudio.com/spaces/21/index.html )
Required Information
Entering this information will route you directly to the right team and expedite traction.
Type: Bug
Enter Task Name: AzureResourceGroupDeployment@2

Agent - Hosted: vs2017-win2016

Issue Description
Getting error when using task AzureResourceGroupDeployment@2 from 19th December 2019. It used to deploy resources. I've tested today as well on different pipelines and the result is the same. I've found similar issue but different task here:
https://github.com/microsoft/azure-pipelines-tasks/issues/11996
Task logs
2019-12-19T08:28:50.1909482Z ##[section]Starting: Deploy Shared Resources
2019-12-19T08:28:50.2020565Z ==============================================================================
2019-12-19T08:28:50.2020690Z Task         : Azure resource group deployment
2019-12-19T08:28:50.2020803Z Description  : Deploy an Azure Resource Manager (ARM) template to a resource group and manage virtual machines
2019-12-19T08:28:50.2020892Z Version      : 2.162.2
2019-12-19T08:28:50.2020992Z Author       : Microsoft Corporation
2019-12-19T08:28:50.2021085Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment
2019-12-19T08:28:50.2021205Z ==============================================================================
2019-12-19T08:28:50.5958019Z Checking if the following resource group exists: RGContactRepoTest.
2019-12-19T08:28:50.8817152Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2019-12-19T08:28:50.8825768Z Resource group exists: true.
2019-12-19T08:28:50.8825956Z Creating deployment parameters.
2019-12-19T08:28:50.8852119Z The detected encoding for file 'd:\a\r1\a\_XXX\azuredeploy.json' is 'utf-8'
2019-12-19T08:28:50.8985298Z The detected encoding for file 'd:\a\r1\a\_XXX\TEST.azuredeploy.parameters.json' is 'utf-8'
2019-12-19T08:28:50.8991719Z Starting Deployment.
2019-12-19T08:28:50.9021998Z Deployment name is azuredeploy-20191219-082850-e88f
2019-12-19T08:28:52.7600260Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2019-12-19T08:28:52.8188205Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2019-12-19T08:29:07.8675063Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2019-12-19T08:29:23.2600651Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2019-12-19T08:29:37.9598566Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2019-12-19T08:29:53.0076879Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2019-12-19T08:29:53.0750838Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2019-12-19T08:29:53.0755345Z Successfully deployed the template.
2019-12-19T08:29:53.0833100Z ##[section]Finishing: Deploy Shared Resources

Today logs:
2020-01-02T07:59:35.6470349Z ##[section]Starting: Deploy DataFactory: Logic
2020-01-02T07:59:35.6588607Z ==============================================================================
2020-01-02T07:59:35.6588790Z Task         : Azure resource group deployment
2020-01-02T07:59:35.6588888Z Description  : Deploy an Azure Resource Manager (ARM) template to a resource group and manage virtual machines
2020-01-02T07:59:35.6589071Z Version      : 2.162.2
2020-01-02T07:59:35.6589137Z Author       : Microsoft Corporation
2020-01-02T07:59:35.6589276Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment
2020-01-02T07:59:35.6589379Z ==============================================================================
2020-01-02T07:59:36.0829268Z Checking if the following resource group exists: RGContactRepoWE.
2020-01-02T07:59:36.3757794Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-02T07:59:36.3761972Z Resource group exists: true.
2020-01-02T07:59:36.3764962Z Creating deployment parameters.
2020-01-02T07:59:36.3850882Z The detected encoding for file 'd:\a\r1\a\_XXX\arm_template.json' is 'utf-8'
2020-01-02T07:59:36.4331792Z The detected encoding for file 'd:\a\r1\a\_XXX\arm_template_parameters.json' is 'utf-8'
2020-01-02T07:59:36.4361578Z Starting Deployment.
2020-01-02T07:59:36.4398726Z Deployment name is arm_template-20200102-075936-c197
2020-01-02T07:59:38.7763384Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-02T07:59:38.8563842Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-02T07:59:54.0038868Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-02T07:59:54.1409006Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-02T07:59:54.1414384Z Successfully deployed the template.
2020-01-02T07:59:54.1500574Z ##[section]Finishing: Deploy DataFactory: Logic

@SumiranAgg isn't this already fixed? or is it the case that ARG task version has not been bumped up with this common change?

@jpodoba  Hi, we have already fixed the issue for all the tasks and it should be available in all the accounts by the end of this week.

Is this fixed in v2 as well as v3?
v3 doesn't seem to support parameterised service connections so I suspect I'll need to live with the warnings?

@jpodoba Hi, we have already fixed the issue for all the tasks and it should be available in all the accounts by the end of this week.

Thanks for confirmation @eaarora-ms  I will track that and if issue still will be in task I will let you know

@frackham  It is fixed for both of them yes. You will not see the warnings once the deployment is done in any of the tasks.

Good morning @eaarora-ms I've checked few minutes ago and issue is still there.
Below are logs:
2020-01-09T07:27:22.4833068Z ##[section]Starting: Deploy Shared Resources
2020-01-09T07:27:22.4946934Z ==============================================================================
2020-01-09T07:27:22.4947058Z Task         : Azure resource group deployment
2020-01-09T07:27:22.4947171Z Description  : Deploy an Azure Resource Manager (ARM) template to a resource group and manage virtual machines
2020-01-09T07:27:22.4947275Z Version      : 2.162.2
2020-01-09T07:27:22.4947351Z Author       : Microsoft Corporation
2020-01-09T07:27:22.4947445Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment
2020-01-09T07:27:22.4947564Z ==============================================================================
2020-01-09T07:27:22.9038239Z Checking if the following resource group exists: RGContactRepoTest.
2020-01-09T07:27:23.2164404Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:27:23.2172635Z Resource group exists: true.
2020-01-09T07:27:23.2173095Z Creating deployment parameters.
2020-01-09T07:27:23.2201205Z The detected encoding for file 'd:\a\r1\a\_XXX\azuredeploy.json' is 'utf-8'
2020-01-09T07:27:23.2340783Z The detected encoding for file 'd:\a\r1\a\_XXX\TEST.azuredeploy.parameters.json' is 'utf-8'
2020-01-09T07:27:23.2351451Z Starting Deployment.
2020-01-09T07:27:23.2385850Z Deployment name is azuredeploy-20200109-072723-b4d6
2020-01-09T07:27:25.7478145Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:27:25.7832751Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:27:40.8597424Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:27:55.9259931Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:28:10.9701962Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:28:26.0291655Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:28:41.0749085Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:28:41.1271914Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:28:41.1273479Z Successfully deployed the template.
2020-01-09T07:28:41.1338805Z ##[section]Finishing: Deploy Shared Resources

2020-01-09T07:29:22.2007504Z ##[section]Starting: Deploy DataFactory: Logic
2020-01-09T07:29:22.2119139Z ==============================================================================
2020-01-09T07:29:22.2119344Z Task         : Azure resource group deployment
2020-01-09T07:29:22.2119458Z Description  : Deploy an Azure Resource Manager (ARM) template to a resource group and manage virtual machines
2020-01-09T07:29:22.2119561Z Version      : 2.162.2
2020-01-09T07:29:22.2119625Z Author       : Microsoft Corporation
2020-01-09T07:29:22.2119733Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-resource-group-deployment
2020-01-09T07:29:22.2119839Z ==============================================================================
2020-01-09T07:29:22.6260775Z Checking if the following resource group exists: RGContactRepoTest.
2020-01-09T07:29:22.9977232Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:29:22.9981633Z Resource group exists: true.
2020-01-09T07:29:22.9983861Z Creating deployment parameters.
2020-01-09T07:29:23.0066391Z The detected encoding for file 'd:\a\r1\a\_XXX\arm_template.json' is 'utf-8'
2020-01-09T07:29:23.0536009Z The detected encoding for file 'd:\a\r1\a\_XXX\arm_template_parameters.json' is 'utf-8'
2020-01-09T07:29:23.0567640Z Starting Deployment.
2020-01-09T07:29:23.0591889Z Deployment name is arm_template-20200109-072923-95a8
2020-01-09T07:29:24.6438448Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:29:24.7010959Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:29:39.7494518Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:29:54.7968611Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:30:09.8706775Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:30:09.9368504Z ##[warning]Can\'t find loc string for key: CorrelationIdForARM
2020-01-09T07:30:09.9376216Z Successfully deployed the template.
2020-01-09T07:30:09.9452919Z ##[section]Finishing: Deploy DataFactory: Logic

@jpodoba  Hi, the deployments are still under progress. Please wait until the end of this week. Thank you for the patience.

The fix is rolled out to all accounts. Please let us know if you are still facing the issue.


all: fix build

Update osutil.Exists usage, the signature of which has been
refined to Exists(path string) bool. osutil.Exists panics
in case the os.Stat call fails, a very rare case. Happens
only when there is a harddrive error?
Sometimes being a packrat is good. The ini library at
https://github.com/jteeuwen/ini has disappeared. A clone of
the repo is available at https://github.com/mewbak/ini
Import mewbak/ini for now.

Nice! Thanks for fixing :)
Seems unreal that packages are removed, but hell it was a couple of years ago since we used jteeuwen/ini, maybe hen changed username.

Nice! Thanks for fixing :)

: )

hen changed username.

hen still exists, only the package is gone.


feat: introduce pagination to python

Needs testing but this should be the bulk of it
This consumes the pagination IR
The generated client.Users.List can then be used as a User generator (effectively the "default"):
for user in client.users.list(...):
  print user

a page-by-page generator:
for page in client.users.list(...).iter_pages():
  print(page.items)

or statically calling next_page to perform the pagination manually:
pager = client.users.list(...)
# First page
print(pager.items)
# Second page
pager = pager.next_page()
print(pager.items)

The client api looks great -- can you document it here once we finalize it?


Preliminary support for Python 3.13

account for changes in pathlib implementation
reload glob to account for changed implementation
improve handling of admin user under Windows
add os.isreserved
change os.path.isabs under Windows
add worksaround for recursion with linecache
exclude extra dependencies tests for 3.13 under Windows (pandas not available yet)

Fixes #1017.
Tasks

[x] Unit tests added that reproduce the issue or prove feature is working
[x] Fix or feature added
[x] Entry to release notes added
[x] Pre-commit CI shows no errors
[x] Unit tests passing
[x] For documentation changes: The Read the Docs preview builds and looks as expected

I'm going to merge this. There is some performance degradation, but I couldn't pin it to any change I made - will just wait for the final version before investigating further.


Document BaseActivityEventListener & new onActivityResult API

@facebook-github-bot shipit

By analyzing the blame information on this pull request, we identified @alvinthen and @Nepherhotep to be potential reviewers.

I will not rubber stamp and land your change for you @foghina!  I can import it for you and you can get your change reviewed by someone though :)

@facebook-github-bot you're the worst. @bestander can you rubber stamp and land my change pls?

@facebook-github-bot shipt

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.


Enhancing the Edit Profile and Progress Pages

Description
Enhancing the Edit Profile and Progress Pages: I'm actively improving user experience and functionality on profile management and progress tracking interfaces. Check out a sample of my work attached below!
Screenshots
Edit Profile Page

Progress page

Proposed Solution (optional)
Sample work of Edit Profile Page

Sample work of Progress Page

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)

Please assign me this task under gssoc '24 , as profile page is not allign properly , i had a lot of experience in building frontend of website , i will make it more creative and enhancing @Dev-tanay

i would like to work on this project, please assign this to me


replace log with logrus

This replaces the std lib log with logrus to enable structured logging and levels. I attempted to guess what levels things should live at, as well as moved some things to structured fields, and changed the default output to stderr.
I can't get the tests to run correctly on my machine as they hang forever, but it seems to work.
Fixes https://github.com/daixiang0/gci/issues/46

I think zap would be a better/faster alternative
See https://github.com/sirupsen/logrus/commit/4ecd9a62bd57b6533e0d87ae23a6b10adc32b5ce

While zap is definitely faster, this only has a few calls and the performance difference is negligible. Logrus is in maintenance mode, but is stable and shouldn't need any updates. In this case, I think it makes for a simpler swap, but I opened #55 to show what it would look like with zap.

While zap is definitely faster, this only has a few calls and the performance difference is negligible. Logrus is in maintenance mode, but is stable and shouldn't need any updates. In this case, I think it makes for a simpler swap, but I opened #55 to show what it would look like with zap.

Here's some example output (all to stderr):
$ dist/gci print pkg/gci/format.go --debug >/dev/null
DEBUG[2022-03-10T14:31:49-08:00] Loaded file                                   file=pkg/gci/format.go
DEBUG[2022-03-10T14:31:49-08:00] Parsed imports in file                        imports="[\"bytes\" \"fmt\" \"strings\" \"github.com/daixiang0/gci/pkg/constants\" \"github.com/daixiang0/gci/pkg/gci/imports\" \"github.com/daixiang0/gci/pkg/gci/sections\" \"github.com/daixiang0/gci/pkg/gci/specificity\" \"github.com/sirupsen/logrus\"]"
DEBUG[2022-03-10T14:31:49-08:00] Matched import to section                     import="\"bytes\"" section=Standard
DEBUG[2022-03-10T14:31:49-08:00] Matched import to section                     import="\"fmt\"" section=Standard
DEBUG[2022-03-10T14:31:49-08:00] Matched import to section                     import="\"strings\"" section=Standard
DEBUG[2022-03-10T14:31:49-08:00] Matched import to section                     import="\"github.com/daixiang0/gci/pkg/constants\"" section=Default
DEBUG[2022-03-10T14:31:49-08:00] Matched import to section                     import="\"github.com/daixiang0/gci/pkg/gci/imports\"" section=Default
DEBUG[2022-03-10T14:31:49-08:00] Matched import to section                     import="\"github.com/daixiang0/gci/pkg/gci/sections\"" section=Default
DEBUG[2022-03-10T14:31:49-08:00] Matched import to section                     import="\"github.com/daixiang0/gci/pkg/gci/specificity\"" section=Default
DEBUG[2022-03-10T14:31:49-08:00] Matched import to section                     import="\"github.com/sirupsen/logrus\"" section=Default
DEBUG[2022-03-10T14:31:49-08:00] Formatting section with imports               imports="[\"bytes\" \"fmt\" \"strings\"]" section=Standard
DEBUG[2022-03-10T14:31:49-08:00] Formatting section with imports               imports="[\"github.com/daixiang0/gci/pkg/constants\" \"github.com/daixiang0/gci/pkg/gci/imports\" \"github.com/daixiang0/gci/pkg/gci/sections\" \"github.com/daixiang0/gci/pkg/gci/specificity\" \"github.com/sirupsen/logrus\"]" section=Default

With the pretty print funcs, the output looks like this:
$ dist/gci print pkg/gci/format.go --debug  >/dev/null
DEBUG[2022-03-10T14:49:50-08:00] Loaded file                                   file=pkg/gci/format.go
DEBUG[2022-03-10T14:49:50-08:00] Parsed imports in file                        imports="[bytes fmt strings github.com/daixiang0/gci/pkg/constants github.com/daixiang0/gci/pkg/gci/imports github.com/daixiang0/gci/pkg/gci/sections github.com/daixiang0/gci/pkg/gci/specificity github.com/sirupsen/logrus]"
DEBUG[2022-03-10T14:49:50-08:00] Matched import to section                     import=bytes section=Standard
DEBUG[2022-03-10T14:49:50-08:00] Matched import to section                     import=fmt section=Standard
DEBUG[2022-03-10T14:49:50-08:00] Matched import to section                     import=strings section=Standard
DEBUG[2022-03-10T14:49:50-08:00] Matched import to section                     import=github.com/daixiang0/gci/pkg/constants section=Default
DEBUG[2022-03-10T14:49:50-08:00] Matched import to section                     import=github.com/daixiang0/gci/pkg/gci/imports section=Default
DEBUG[2022-03-10T14:49:50-08:00] Matched import to section                     import=github.com/daixiang0/gci/pkg/gci/sections section=Default
DEBUG[2022-03-10T14:49:50-08:00] Matched import to section                     import=github.com/daixiang0/gci/pkg/gci/specificity section=Default
DEBUG[2022-03-10T14:49:50-08:00] Matched import to section                     import=github.com/sirupsen/logrus section=Default
DEBUG[2022-03-10T14:49:50-08:00] Formatting section with imports               imports="[bytes fmt strings]" section=Standard
DEBUG[2022-03-10T14:49:50-08:00] Formatting section with imports               imports="[github.com/daixiang0/gci/pkg/constants github.com/daixiang0/gci/pkg/gci/imports github.com/daixiang0/gci/pkg/gci/sections github.com/daixiang0/gci/pkg/gci/specificity github.com/sirupsen/logrus]" section=Default

Looks good overall, logrus is enough for now.

@glightfoot thanks for your contribution!

Hello, the problems with logrus are:

a large dependencies graph
when using gci as a library, because the logger is a singleton, it can be complex to setup.

In 99% of cases when you create a library, the init function must be prohibited.
It's better to create an abstraction around the logger with an interface and set up the logger in the main function instead of an init function.


⚡ Reduce production library size

Codecov Report

Merging #21 into 1.0.3 will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             1.0.3       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           14        14
=========================================
  Hits            14        14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e78f7...3c32e3a. Read the comment docs.


BUG - json dump field with unicode -> array of ints (instead of string)

I'm expecting the following code:
json result;
result["name"] = L"אינעל דינק";
std::cout << result.dump(4) << std::endl;

to output:
{
    "name": "\u05D0\u05D9\u05E0\u05E2\u05DC \u05D3\u05D9\u05E0\u05E7"
}

However, it treats the unicode string as json array, outputs instead:
{
    "name": [
        1488,
        1497,
        1504,
        1506,
        1500,
        32,
        1491,
        1497,
        1504,
        1511,
        0
    ]
}

BTW Thanks for this project. cool stuff happen here.

Hm. It works when you remove the wide string literal:
json result;
result["name"] = "אינעל דינק";
std::cout << result.dump(4) << std::endl;

->
{
    "name": "אינעל דינק"
}

Wide strings are not supported by the library. An array is created, because under the hood this constructor is chosen:
template<typename BasicJsonType, typename T, std::size_t N,
         enable_if_t<not std::is_constructible<typename BasicJsonType::string_t, T (&)[N]>::value, int> = 0>
void to_json(BasicJsonType& j, T (&arr)[N])
{
    external_constructor<value_t::array>::construct(j, arr);
}

I am afraid that right now there is not much that we can do. The library uses UTF-8 internally, and to process wide strings, we would need to translate UTF-16 or UTF-32 to UTF-8. While we have some code for this in the input adapters (allowing to parse from wide strings), it is currently not planned to also have a conversion between different string types.
Well... Of course, pull requests would be more than welcome!

thanks @nlohmann for the comments.
I'm using a workaround for now (until this will be supported in this library)
string wstringToString(const wstring& input) {
	stringstream ss;

	for (auto item : input)
	{
		if (item <= 127)
		{
			ss << (char)item;
		}
		else
		{
			ss << "\\u" << std::hex << std::setfill('0') << std::setw(4) << (int)item;
		}
	}

	return ss.str();
}

// ....

json result;
result["name"] = wstringToString(L"אינעל דינק");
std::cout << result.dump(4) << std::endl;

source

->
{
    "name": "\\u05d0\\u05d9\\u05e0\\u05e2\\u05dc \\u05d3\\u05d9\\u05e0\\u05e7"
}

The simple "this library only supports UTF8" is a good policy, and adding support to this library for std::wstring doesn't feel right. It may be better to try to disable the array overload so that it fails to compile if you try to use a std::wstring with this library.

What is wrong with also supporting UTF-16 and UTF-32 (even though we only store UTF-8 internally)?

On the face of it, supporting this would be a good thing.
My biggest worry (but not opposition) is that this will distract this library from focusing on the core idea of doing JSON well by having to deal with bugs/issues that come about from supporting multiple encodings properly. For example:

should json<wstring> work?
or is the goal just allowing json<string> = wstring to work? Would that mean wstring = json<string> should also work?
Converting string<->wstring by itself is not obvious. For example, an official C++11 way of doing it got deprecated in C++17, without replacement, because the "general feeling that [the STL's approach] is not the best way to address unicode transcoding".
What are the portability issues? For example, Linux has a 32-bit wstring, but Windows has a 16-bit wstring (note there is no implicit encoding, just explicit bit-width). The library would have to take a position that wstring must hold UTF-32 (-16 on Windows) just as it says string must hold UTF-8, but will this open up the library to even more issue reports around encoding handling than it already gets with the very simple "just UTF-8" rule?

I'm a very-biased adherent to "UTF-8 Everywhere", so take my advice with that grain of salt. If people ever suggest to me anything but string+utf8, I say don't do that. But I understand others do not share that view. Handling encoding issues sounds like the job of a dedicated library for that specific purpose and I don't think it's worth nlohmann::json's time to tackle it -- but maybe it's far easier than I'm painting it out to be! I'm not opposed, just skeptical.

But supporting unicode sequences from char16_t and char32_t cannot be misinterpreted. wstring is just a wchar_t container with no associated encoding.

The library currently treats std::wstring with 2-byte characters as UTF-16 and those with 4-byte characters as UTF-32.

I added an FAQ entry: https://json.nlohmann.me/home/faq/#wide-string-handling


Add "confirm password" field to /api/signup

The /api/signup route should have an additional required field in the request body with the confirmPassword value to make sure that the user has entered their password exactly the same, twice, before creating a user in the Auth0 database.

I will look into it.

@robinv85 Sorry, I don't understand how this should work. Should this be a flag that frontend sets if a user entered a password twice exactly the same? If this is the case, a frontend can simply make a check and do not send a request if passwords a different.

@mushketyk yeah the validation can happen client-side too, but adding it on the back-end makes it  certain that it works regardless of different clients making a request... i've seen this before, you might think it's overkill, to me it seems good to be more clear about splitting up /signup and /login as well.

@robinv85 Ok, I think there is a benefit in having this. Should be easy to implement


Color areas based on various landuse tag values

I suggest using some of the landuse tag values to color areas. For example, landuse=village_green areas should be colored green. There are probably also some other relevant values for the tag.

Thanks for the issue, I'll take a look.

Tags from AreasTab.
Leisure and recreation

[x] leisure=park
[x] landuse=recreation_ground
[ ] leisure=recreation_ground (should be the same)
[x] leisure=playground
[x] leisure=fitness_station
[x] landuse=grass
[x] landuse=meadow (same as grass)
[x] landuse=village_green (same as grass)
[ ] golf=tee (same as grass)
[ ] golf=fairway (same as grass)
[ ] golf=driving_range (same as grass)
[ ] tourism=camp_site
[ ] tourism=caravan_site
[ ] leisure=dog_park

Agriculture and industry

[x] landuse=farmland
[ ] landuse=greenhouse_horticulture (same as above)
[x] landuse=farmyard
[x] landuse=allotments
[x] landuse=orchard
[ ] landuse=plant_nursery
[x] leisure=garden
[x] landuse=forest
[ ] landuse=forest + leaf_type=broadleaved
[ ] landuse=forest + leaf_type=needleleaved
[ ] landuse=forest + leaf_type=mixed
[ ] landuse=forest + leaf_type=leafless
[ ] landuse=vineyard
[ ] landuse=quarry
[ ] waterway=dam

When I looked at doing this in a past project, I ended up with two distinct layers:

a "ground cover" layer representing the material of the ground (grass, tarmac, concrete, bush, etc.) and,
a "usage" layer, representing meaning that humans invent (landuse like retail or residential, access restrictions, parks, etc.)

I would render the ground cover underneath, and render the usage layer on top, trying to use different techniques to let the groundcover show through. Translucent colours, stripes of colour, patterns of symbols, etc.
The approach worked well, because I could use all sorts of data to determine the groundcover, without worrying about how that data needed to be represented on the map itself. E.g., I would start by painting park areas as grass (guessing that parks imply grass without any further info), then painting gardens, bushland, footways and pedestrian areas over the top, replacing the grass guess where appropriate. Then, the park area is also represented in the "usage" layer on top, showing that the area is "treated like a park".


VaultDynamicSecret does not work with /auth/token/create endpoint

Describe the bug
When using to get a Vault Token from the /auth/token/create via VaultDynamicSecret nothing happens.
To Reproduce
Steps to reproduce the behavior:

manifests:

apiVersion: generators.external-secrets.io/v1alpha1
kind: VaultDynamicSecret
metadata:
  name: "vault-token"
spec:
  path: "/auth/token/create/"
  method: "POST"
  provider:
    server: "https://vault.mycompany.de"
    version: "v1"
    auth:
      kubernetes:
        mountPath: "main-cluster"
        role: "baseproject-project-x"
        serviceAccountRef:
          name: "baseproject"
---
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: "vault-token"
spec:
  refreshInterval: "5m"
  target:
    name: vault-token
  dataFrom:
  - sourceRef:
      generatorRef:
        apiVersion: generators.external-secrets.io/v1alpha1
        kind: VaultDynamicSecret
        name: "vault-token"

versions:

kubernetes: 1.24.10-gke.2300
ESO: v0.8.1

Expected behavior
A Vault Token gets pulled from the endpoint and written to the secret.
Additional context
There are no logs for either the VaultDynamicSecret or the externalSecret in the ESO (loglevel debug) and the kubernetes manifests show Events: <none> for both.

FYI @norman-zon i found the issue and have a fix proposed in the PR :point_up_2:

Thanks for the quick fix.
Unfortunately I still see the same behaviour as before, after adding:
spec:
  path: "/auth/token/create"
  method: "POST"
  resultType: "Auth"

Still no relevant logs nor kubernetes Events

damn, looks like there was a caching issue with the release build :disappointed:
At 10:05:57 the PR that fixed the issue was merged into main and a new image was built (see build job).
The promotion job ran at 10:46 to promote the :main image to the release tag v0.8.2.
Apparently it picked up sha256:f12f6c0058bfbe9c32a2558b4a03427a82f6e511c9b20103d6ab0989052655d8 as main image (which was built 5d ago) and promoted it.
I.e. v0.8.2 doesn't include the fix for this issue :disappointed:. You can use the main though, that fixes the issue.

Thanks for checking.
It works with main!


feat(turbo): add TMP and TEMP variables to pass through

Description
This is required so node scripts and other tools can detect the correct location to create temporary files and folders. In particular it's required for the Node.js os.tmpdir() function.
Testing Instructions
Create an app or package task that access either the TMP or TEMP environment variables and observe that they are passed through correctly.
This should hopefully resolve this issue #8802

Allow CI Workflow Run

[ ] approve CI run for commit: fe28ea59d13488d8ae851bc06f0ac533afe8ab32

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer


Remove deprecated string module functions

This PR addresses issue #1222. All uses of the string module were reviewed and replaced with string functions. Most changes were in the sping module, so tests are not picking these up.
In addition, there were a few type tests for strings that are replace with isinstance.
There is also one additional file in gitignore that is created during a newly added test. /Code/GraphMol/Depictor/test_data/constrainedCoords.out.sdf

This slipped by because there do not appear to be any regression tests.  Is this code actively used anymore?

It is. I wonder if there is an alternative. The code is no longer under
development.
On Tue, Dec 20, 2016 at 2:35 PM Brian Kelley<EMAIL_ADDRESS>wrote:

This slipped by because there do not appear to be any regression tests. Is
this code actively used anymore?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rdkit/rdkit/pull/1223#issuecomment-268336787, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIUQv-LgbfIyhqj_Z9o-xSDs3SGeA9stks5rKC4YgaJpZM4LR4ms
.

Yeah, it hasn't been maintained for quite a while. I'm not aware of anything else quite as flexible.
I would prefer (and am working towards) having the drawing code available and at least mostly complete in c++. If that can produce svg and png then I think we can deprecate the sping code and anything that uses it.
That would be one of those "non-backwards compatible changes" that I have discussed.


Move i22 plans from ophyd_async branch and refactor to conform ot BlueAPI standards

Type annotations and docstrings
Pass devices as arguments to plan
Plans and stubs in different modules

Requires: https://github.com/DiamondLightSource/dodal/pull/193 for Linkam
Requires: https://github.com/bluesky/ophyd-async/pull/24


Automated Package Upgrade

:tada: This PR is included in version 7.2.38 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Esri Open Source Community Code of Conduct

Initial draft for an Esri Open Source Community Code of Conduct

Can we consider naming the file CODE_OF_CONDUCT.md ? That seems to be the npm/OSS standard. Someone even has a CoC generator

Ok, I've made a few changes and edits based on everyone's suggestions:

@jf990 I deleted the COMMUNITY_CODE_OF_CONDUCT.md file and moved the contents to CODE_OF_CONDUCT.md
@mikewilburn  and @jgravois I added a version/data to the doc, moved some the contributing info the the README.md file, clarified consequences for violations, and restructured the file re the suggestions

@ChrisFrenchPDX i have a few more copy editing nitpicks. can i just push them up in a commit of my own?

@jgravois Sure!

Ok, cool. The changes look good to me - I just changed a few punctuation typos.

This is looking real solid to me. Happy with the latest changes!


page type draft with permission

I made this pull request for issue (#8868 ).
This PR is repaired to show page type according to the permission inside the draft list.

We changed as Andrew suggested, and it seems to work as expected.


BC-13824: Add deployment property to connector spec

BC-13824

@nareshkakubal could you please review this PR.


package:flutter/src/widgets/navigator.dart': Failed assertion: line 4016 pos 12: '!_debugLocked': is not true

Hello @yusufz09 ,
Could you please post the outputs of flutter run -v and flutter doctor -v and a complete minimal reproducible code sample?
Thank you!

@yusufz09
Just posting screenshot is of no help. Instead we look for a minimal reproducible use case that shows the issue you are facing along with `flutter doctor -v. Please provide the same.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


Skip bad nuspecs

An expanded file share source can contain incorrectly formatted nuspecs or miss the nuspec entirely. This fix allows the client to skip over this bad data.
In addition to skipping over bad data detailed warnings are written to the Logger that is currently in scope.

Hi @johnataylor, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

//CC @emgarten @yishaigalatzer @feiling

:shipit:

Fixed issue nuget/home#1345


Raw data downloaded does not have year of standard population and base population marked

Raw data downloaded does not have year of standard population and base population marked.
This may confuse people about which year is which.

Enhancement done


Prepare presentation for STAC meeting on our assets work

Plan:
Edit this slide set: https://docs.google.com/presentation/d/13rqPeU9nrRWU79QhS2Ycr4IP7FaNQpX_iltTRELvxJc/edit#slide=id.p1

[x] AS: Talk through Tech Blog

Drivers:

Heterogeneous archive / what is a dataset? / lots of files in scientifically contiguous objects
ESGF Search-by-Dataset or File

[x] RE: Create Google Slides with one query per page (pretty-printed to be easily readable):

[x] Query across all collections (at Asset level)
[ ] Query across all items within a collection (at Asset level):

not (yet?) implemented with collection IDs
but can get same functionality by selecting top-level facet value, e.g. mip_era=cmip6

[x] Query within an Item
[x] Paginate within an item

[x] AS: Talk through the specs/extensions:

[ ] STAC Asset Spec
[ ] STAC Asset Search Spec
[ ] STAC Asset List Spec

Discussion + showdown

Done


Fix genre list issue

Text overlaps the image.

It was overlapping because I was using a button and buttons by default don't wrap text.
Fixed:
whiteSpace={"normal"}
textAlign={"left"}


Invalid ad request parameter(s) for banner ads

Banner ad code:
                           <AdMobBanner
                                adSize = "banner"
                                adUnitID = "ca-app-pub-3940256099942544/2934735716"
                                onAdFailedToLoad={error => console.error(error)}
                                />

Most of the time it works but sometimes following error shows up:
From google console:

ExceptionsManager.js:84 Error: Request Error: Invalid ad request parameter(s). Check the Xcode console for details.
at createErrorFromErrorData (CallScreen.js:73)
at AdMobBanner.handleAdFailedToLoad (CallScreen.js:61)
at AdMobBanner.proxiedMethod (createPrototypeProxy.js:44)
at Object.invokeGuardedCallbackImpl (ReactNativeRenderer-dev.js:93)
at invokeGuardedCallback (ReactNativeRenderer-dev.js:318)
at invokeGuardedCallbackAndCatchFirstError (ReactNativeRenderer-dev.js:342)
at executeDispatch (ReactNativeRenderer-dev.js:715)
at executeDispatchesInOrder (ReactNativeRenderer-dev.js:737)
at executeDispatchesAndRelease (ReactNativeRenderer-dev.js:894)
at executeDispatchesAndReleaseTopLevel (ReactNativeRenderer-dev.js:902)

I have the same problem.

@Juliocbr Try using the latest version of the api. It solved the problem for me.

I have same problem, and I'm using the latest version of admob.

@sajadabasi try the new and better firebase for React Native with has better support and updates frequently


Update cri plugin to v1.0.5.

Update cri to v1.0.5. Here is the release note https://github.com/containerd/cri/releases/tag/v1.0.5.
This is mainly for minikube support. See https://github.com/kubernetes/minikube/pull/3040.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Codecov Report

Merging #2539 into release/1.1 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.1    #2539   +/-   ##
============================================
  Coverage        50.11%   50.11%
============================================
  Files               75       75
  Lines             7297     7297
============================================
  Hits              3657     3657
  Misses            2965     2965
  Partials           675      675

Flag
Coverage Δ

#linux
50.11% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de979a...eee5c07. Read the comment docs.

LGTM


Clear Add Middleware Deployment form when opening

When using the "Add Middleware Deployment" form (doing the deployment or
cancelling), when opening it the next time it will still have previous
values/settings.
This was a regression from PR #10687

@miq-bot add_label providers/hawkular, ui, bug
cc @abonas

LGTM + verified on my env
@miq-bot assign @chessbyte

test failures seem unrelated


Write scalafix migrations for 1.0 release

With PRs like #31 source code will need some migrations when version 1.0 is released. Let's provide scalafix migrations for this to ease people's life.

Love the idea! Such migration should then also be listed for Scala Steward once ready so people get automatic migrations.

This is the spirit.


Make the unit of cost clear

Cost is currently displayed without a unit. There is an API endpoint /model/getConfigs with a field .data.currencyCode that returns the unit of currency. If empty string, it is assumed to be USD.

Done in https://github.com/kubecost/kubectl-cost/pull/73


tech filtering without route stuff

@koddsson How about this?
A problem with modifying the URL is that if you load /examples/puppet and you decide to change "puppet" to "react" you'll end up changing the URL (with pushState) for each keyboard press. A mess.
Once this lands we can consider perhaps using the location.hash instead to make the filtering a permalink.
Also, I change the CSS slightly. The black border and the fixed 460px width was specifically meant for the validation thing on the home page.

LGTM


Running FlexFlow on Legion with native UCX library causes segfault

Steps to reproduce

Install FlexFllow:

git clone https://github.com/flexflow/flexflow
cd flexflow
eval "$(conda shell.bash hook)"
conda env create -f conda/environment.yml
conda activate flexflow
mkdir build
cd build # in flexflow/build folder
sed -i 's/FF_LEGION_NETWORKS=${FF_LEGION_NETWORKS:-}/FF_LEGION_NETWORKS=ucx/' ../config/config.linux
../config/config.linux
cmake ..
make -j16
make -j16
sudo make install

The cmake .. command will install UCX during the process as per CMakeLists.txt: https://github.com/flexflow/FlexFlow/blob/d3ffa431ac21b187b91c219b70f8ab2b6a92f70b/CMakeLists.txt#L52-L146

Run flexflow on a single machine and confirm that it works:

# in flexflow/build
../scripts/mnist_mlp_run.sh

It should train a model and display accuracy until it prints something in this format:
epochs 1, ELAPSED TIME = %f s, THROUGHPUT = %f sample/s

Setup MPI across at least two machines and make sure that both machines have FlexFlow installed. Then create a script as follows and save it to ../scripts/incr_decoding.sh:

#!/bin/bash
eval "$(conda shell.bash hook)"
conda activate flexflow
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$CONDA_PREFIX/lib
export LD_LIBRARY_PATH=$HOME/FlexFlow/build/ucx/install/lib:$LD_LIBRARY_PATH
export LEGION_BACKTRACE=1
export LEGION_FREEZE_ON_ERROR=1
cd ~/FlexFlow/build/
./inference/incr_decoding/incr_decoding -ll:gpu 1 -ll:util 4 -ll:fsize 14000 -ll:zsize 20000 -llm-model llama -llm-weight ../inference/weights/llama_7B_weights_half/ -llm-config ../inference/models/configs/llama_7B.json -tokenizer ../inference/tokenizer/tokenizer.model -prompt ../inference/prompt/chatgpt.json -tensor-parallelism-degree 1 -pipeline-parallelism-degree 2 --fusion

run:
mpirun --hostfile <hostfile> ../scripts/incr_decoding.sh

It works until downloading dataset then it segfaults:
Downloading data from https://s3.amazonaws.com/img-datasets/mnist.npz                                                                                11493376/11490434 [==============================] - 0s 0us/step                                                                                (60000, 28, 28)                                                                                numpy array:<PHONE_NUMBER>34512, False), <cdata 'float *' 0x7f5629fb1010>, 0x7f5629fb1010                                                                                Index load entire dataset: ptr input_head_ 0x7f5629fb1010, idx 0, input_ 0x7f5629fb1010<PHONE_NUMBER>34512 47040000, input 0x7f5767000000<PHONE_NUMBER>35552 47040000                    0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
numpy array:<PHONE_NUMBER>29600, False), <cdata 'float *' 0x7f572979c980>, 0x7f572979c980
Index load entire dataset: ptr input_head_ 0x7f572979c980, idx 0, input_ 0x7f572979c980<PHONE_NUMBER>29600 60000, input 0x7f5772371800<PHONE_NUMBER>95552 60000
5 0 4 1 9 2 1 3 1 4 3 5 3 6 1 7 2 8 6 9 4 0 9 1 1 2 4 3 2 7 3 8
[ip-172-31-40-19:111031:1:111039] Caught signal 11 (Segmentation fault: address not mapped to object at address 0x9)
==== backtrace (tid: 111039) ====
 0  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucs.so.0(ucs_handle_error+0x2dc) [0x7f5bacc6f9dc]
 1  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucs.so.0(+0x30bbf) [0x7f5bacc6fbbf]
 2  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucs.so.0(+0x30ef4) [0x7f5bacc6fef4]
 3  /lib/x86_64-linux-gnu/libc.so.6(+0x43090) [0x7f5baef3a090]
 4  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucp.so.0(ucp_mem_type_pack+0x70) [0x7f5bace8ccb0]
 5  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucp.so.0(ucp_dt_pack+0x69) [0x7f5bace8ce69]
 6  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucp.so.0(+0x80331) [0x7f5baceba331]
 7  /home/ubuntu/FlexFlow/build/ucx/install/lib/libuct.so.0(uct_tcp_ep_am_bcopy+0x7e) [0x7f5bacccd98e]
 8  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucp.so.0(ucp_rndv_progress_am_bcopy+0x1bb) [0x7f5baceba55b]
 9  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucp.so.0(ucp_rndv_rtr_handler+0xc8) [0x7f5bacebd108]
10  /home/ubuntu/FlexFlow/build/ucx/install/lib/libuct.so.0(+0x23427) [0x7f5bacccc427]
11  /home/ubuntu/FlexFlow/build/ucx/install/lib/libuct.so.0(+0x23a08) [0x7f5bacccca08]
12  /home/ubuntu/FlexFlow/build/ucx/install/lib/libuct.so.0(+0x25f2c) [0x7f5bacccef2c]
13  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucs.so.0(ucs_event_set_wait+0xf9) [0x7f5bacc7a2f9]
14  /home/ubuntu/FlexFlow/build/ucx/install/lib/libuct.so.0(uct_tcp_iface_progress+0x7b) [0x7f5bacccefdb]
15  /home/ubuntu/FlexFlow/build/ucx/install/lib/libucp.so.0(ucp_worker_progress+0x6a) [0x7f5bace8928a]
16  /home/ubuntu/FlexFlow/build/deps/legion/lib/librealm.so.1(+0x746187) [0x7f5bafa78187]
17  /home/ubuntu/FlexFlow/build/deps/legion/lib/librealm.so.1(+0x73129c) [0x7f5bafa6329c]
18  /home/ubuntu/FlexFlow/build/deps/legion/lib/librealm.so.1(+0x5de6b3) [0x7f5baf9106b3]
19  /home/ubuntu/FlexFlow/build/deps/legion/lib/librealm.so.1(+0x5def06) [0x7f5baf910f06]
20  /home/ubuntu/FlexFlow/build/deps/legion/lib/librealm.so.1(+0x6e6716) [0x7f5bafa18716]
21  /lib/x86_64-linux-gnu/libpthread.so.0(+0x8609) [0x7f5bacf31609]
22  /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f5baf016133]
=================================
/home/ubuntu/FlexFlow/build/flexflow_python: line 13: 111031 Segmentation fault      (core dumped) $BUILD_FOLDER/deps/legion/bin/legion_python "$@"

I set LEGION_FREEZE_ON_ERROR=1 to have the program freeze at the error and got a more detailed backtrace using gdb: (note that the following backtrace
#0  0x00007fd4adc6e23f in __GI___clock_nanosleep (clock_id=clock_id@entry=0, flags=flags@entry=0, req=req@entry=0x561c4337b1e0, rem=rem@entry=0x561c4337b1e0)
    at ../sysdeps/unix/sysv/linux/clock_nanosleep.c:78
78      ../sysdeps/unix/sysv/linux/clock_nanosleep.c: No such file or directory.
(gdb) where
#0  0x00007fd4adc6e23f in __GI___clock_nanosleep (clock_id=clock_id@entry=0, flags=flags@entry=0, req=req@entry=0x561c4337b1e0, rem=rem@entry=0x561c4337b1e0)
    at ../sysdeps/unix/sysv/linux/clock_nanosleep.c:78
#1  0x00007fd4adc73ec7 in __GI___nanosleep (requested_time=requested_time@entry=0x561c4337b1e0, remaining=remaining@entry=0x561c4337b1e0) at nanosleep.c:27
#2  0x00007fd4adc73dfe in __sleep (seconds=0) at ../sysdeps/posix/sleep.c:55
#3  0x00007fd4ae7ee402 in Realm::realm_freeze(int) () from /usr/local/lib/librealm.so.1
#4  <signal handler called>
#5  0x00007fd48ec3ccb0 in ucp_mem_type_pack (worker=0x561c431b9490, dest=dest@entry=0x7fcb9c26a295, src=0x7fd2ff1c3100, length=8176, mem_type=UCS_MEMORY_TYPE_CUDA) at dt/dt.c:80
#6  0x00007fd48ec3c56b in ucp_dt_contig_pack (worker=<optimized out>, dest=dest@entry=0x7fcb9c26a295, src=<optimized out>, length=length@entry=8176, mem_type=<optimized out>)
    at dt/dt_contig.c:31
#7  0x00007fd48ec3ce69 in ucp_dt_pack (worker=worker@entry=0x561c431b9490, datatype=<optimized out>, mem_type=<optimized out>, dest=dest@entry=0x7fcb9c26a295,
    src=<optimized out>, state=state@entry=0x561c432667e0, length=8176) at dt/dt.c:118
#8  0x00007fd48ec6a331 in ucp_rndv_pack_data (dest=0x7fcb9c26a285, arg=0x561c43266788) at rndv/rndv.c:1877
#9  0x00007fd47ac2b98e in uct_tcp_ep_am_bcopy (uct_ep=0x561c432ea770, am_id=<optimized out>, pack_cb=<optimized out>, arg=<optimized out>, flags=<optimized out>)
    at tcp/tcp_ep.c:1874
#10 0x00007fd48ec6a55b in uct_ep_am_bcopy (flags=0, arg=0x561c43266788, pack_cb=0x7fd48ec6a200 <ucp_rndv_pack_data>, id=12 '\f', ep=0x561c432ea770)
    at /home/ubuntu/FlexFlow/build/ucx/src/uct/api/uct.h:3020
#11 ucp_do_am_bcopy_multi (handle_user_hdr=0, enable_am_bw=1, pack_middle=0x7fd48ec6a200 <ucp_rndv_pack_data>, pack_first=0x7fd48ec6a200 <ucp_rndv_pack_data>,
    am_id_middle=12 '\f', am_id_first=12 '\f', self=0x561c43266860) at /home/ubuntu/FlexFlow/build/ucx/src/ucp/proto/proto_am.inl:120
#12 ucp_rndv_progress_am_bcopy (self=0x561c43266860) at rndv/rndv.c:1897
#13 0x00007fd48ec6d108 in ucp_request_try_send (req=0x561c43266788) at /home/ubuntu/FlexFlow/build/ucx/src/ucp/core/ucp_request.inl:357
#14 ucp_request_send (req=0x561c43266788) at /home/ubuntu/FlexFlow/build/ucx/src/ucp/core/ucp_request.inl:357
#15 ucp_rndv_rtr_handler (arg=<optimized out>, data=<optimized out>, length=<optimized out>, flags=<optimized out>) at rndv/rndv.c:2434
#16 0x00007fd47ac2a427 in uct_iface_invoke_am (flags=0, length=<optimized out>, data=0x7fcbb81e1085, id=<optimized out>, iface=0x561c431ef4c0)
    at /home/ubuntu/FlexFlow/build/ucx/src/uct/base/uct_iface.h:904
#17 uct_tcp_ep_comp_recv_am (ep=<optimized out>, hdr=<optimized out>, iface=0x561c431ef4c0) at tcp/tcp_ep.c:1289
#18 uct_tcp_ep_progress_am_rx (ep=<optimized out>, ep@entry=0x561c432ea770) at tcp/tcp_ep.c:1421
#19 0x00007fd47ac2aa08 in uct_tcp_ep_progress_data_rx (arg=0x561c432ea770) at tcp/tcp_ep.c:1526
#20 0x00007fd47ac2cf2c in uct_tcp_iface_handle_events (callback_data=0x561c432ea770, events=<optimized out>, arg=0x7fd461bd9f00) at tcp/tcp_iface.c:316
#21 0x00007fd47abd82f9 in ucs_event_set_wait (event_set=<optimized out>, num_events=num_events@entry=0x7fd461bd9f04, timeout_ms=timeout_ms@entry=0,
    event_set_handler=event_set_handler@entry=0x7fd47ac2cf00 <uct_tcp_iface_handle_events>, arg=arg@entry=0x7fd461bd9f00) at sys/event_set.c:215
#22 0x00007fd47ac2cfdb in uct_tcp_iface_progress (tl_iface=0x561c431ef4c0) at tcp/tcp_iface.c:333
#23 0x00007fd48ec3928a in ucs_callbackq_dispatch (cbq=<optimized out>) at /home/ubuntu/FlexFlow/build/ucx/src/ucs/datastruct/callbackq.h:211
#24 uct_worker_progress (worker=<optimized out>) at /home/ubuntu/FlexFlow/build/ucx/src/uct/api/uct.h:2768
#25 ucp_worker_progress (worker=0x561c431b9490) at core/ucp_worker.c:2807
#26 0x00007fd4ae884187 in Realm::UCP::UCPContext::progress_without_wakeup() () from /usr/local/lib/librealm.so.1
#27 0x00007fd4ae86f29c in Realm::UCP::UCPPoller::do_work(Realm::TimeLimit) () from /usr/local/lib/librealm.so.1
#28 0x00007fd4ae71c6b3 in Realm::BackgroundWorkManager::Worker::do_work(long long, Realm::atomic<bool>*) () from /usr/local/lib/librealm.so.1
#29 0x00007fd4ae71cf06 in Realm::BackgroundWorkThread::main_loop() () from /usr/local/lib/librealm.so.1
#30 0x00007fd4ae824716 in Realm::KernelThread::pthread_entry(void*) () from /usr/local/lib/librealm.so.1
#31 0x00007fd4ae10a609 in start_thread (arg=<optimized out>) at pthread_create.c:477
#32 0x00007fd4adcb0133 in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

It seems that the backtrace of the offending thread does not involve FlexFlow and only involves Legion and UCX. I'm digging deeper to see what part of FlexFlow triggered the segfault.

Seems like UCX is not built with CUDA support. I don't see --with-cuda in https://github.com/flexflow/FlexFlow/blob/d3ffa431ac21b187b91c219b70f8ab2b6a92f70b/CMakeLists.txt#L117C44-L117C44

One other detail seems to be that UCX doesn't currently support the native EFA networking hardware and will probably fallback to UDP. I'd probably recommend switching to GASNetEX which has support for libfabric which should be able to run on top of the native EFA hardware. @SeyedMir please correct me if I'm wrong about any of that.

Correct, except that the fallback with UCX will be to TCP.


Documentation about query folding with OnSelectedRows

Hi,
we are just developing a custom connector on a REST API. This API allows me to iterate over several products and get values for each of them.
Let's imagine the API has two functions getAssets() and getAssetHistory(product).
getAssets()
-Asset-   |
M1        |
M2        |
M3        |

getAssetHistory(asset)
-Asset-   | -Date-   | -Value- |
M1        | 1.1.2020 | 5       |
M2        | 1.2.2020 | 5       |
M3        | 1.3.2020 | 5       |
M4        | 1.4.2020 | 5       |
M5        | 1.5.2020 | 5       |

We have built a connector that works in Import mode and that does
History = Table.AddColumn("Assets", "History", each getAssetHistory([asset]))

We now have to support query folding on the Asset column and later on the date column.
To my understanding for this we have to implement the onSelectectedRow handler of Table.View. However, today my hope for documentation vanished  https://github.com/MicrosoftDocs/powerquery-docs/issues/49 .
Let's imagine as a user I go to the Transform Data experience and there I filter on two Assets (e.g. M1,M2).
Now within the connector I want to be able to skip the call getAssetHistory(M3) as this result will not be needed at all.
Could you please give some guidance where to look, happy to provide more details and engage in personal conversations.
#318 is actually quite similar...
@cwebbbi , @CurtHagenlocher

I've published a simple and probably buggy project which is able to convert some predicates into T/SQL. You can find it at https://github.com/CurtHagenlocher/CSQL


Measurement engine requirements

Based on my experience with developing PartSeg I would like to share what I found as essential requirements for a measurement engine.
Most of them are satisfied by PartSeg code: https://github.com/4DNucleome/PartSeg/blob/develop/package/PartSegCore/analysis/measurement_calculation.py
But part of the design of this code is from the time when PartSeg was Python 2  compatible. I need to update this.

Scale support. The function should be able to get information about voxel size (image spacing) to properly calculate size depending on measures. Many imaging technics has different scale in z than xy.The need for interpolation data to calculate diameter or main axis is a bad design

Unit support. The function should have the possibility to return units next to values. For some functions, it could be static annotation (like diameter length), for others it may depend on data dimensionality (for example Volume). This may need some stronger assumptions about voxel size units.

Allow selecting if calculation is per label or for all labels (for example, main axis length cannot be aggregated).

possibility to create a set of measurements. Instead of depending on some form of notes, it will be nice to have the possibility to create a set of measurements in the application and then select a set for a given experiment. This introduces additional optional requirements:

preserving state between sessions
migration of preserved state between sessions
possibility to copy such set from one machine to another
simple interface to use such set from code
Such set may allow defining custom names for better reflect project-specific requirements
some idea to one selection of base label, image, etc for the whole set.

Cache dict support. If there is the assumption that the function returns one number (or one number per component), some functions calculate more in one run. For example, mahotas.features.haralick calculate all 13 features in one run. So if the feature is selected as a function argument and the user wants more than one of these features, it could be better to cache it and the second feature return from the cache. Another example is a calculation of main axis length which requires PCA analysis and calculation all in one call. Cache available from function also may allow more complex measurements that use simpler ones without additional computation. For example, sphericity may depend on voulme and diameter.

Simple calculation engine for measures. It will be nice to allow calculation of such things as proportions between two measurements or even some more complex calculation to get a result that could be simpler copied and pasted without the need to perform further analysis in excel, for example.

Thank you @Czaki ! This is really helpful.

Simple calculation engine for measures. It will be nice to allow calculation of such things as proportions between two measurements or even some more complex calculation to get a result that could be simpler copied and pasted without the need to perform further analysis in excel, for example.

I have been thinking about this as well and I think it's a nice idea. Have you considered how the API should look? Maybe something like a tuple of two keys (e.g., (property_1, property_2) would give property_1 /property_2)?

In my implementation, I use Node class  which is equivalent to (property1, op, property2)  Currently op could be only "/"but I prefer to keep API prepared for another operator.
The property1 and property2could be Leaf (measurement function) or another Node.
But for simplification, as proportion is maybe the most popular operation then (property_1, property_2) could be casted to (property_1, "/", property_2)


Fix location of subset of buses

Requested enhancement: Option to fix the position of some buses, and have the others adjust their position around them.

Thanks for the suggested update. I will add this feature and make other pending updates and bug fixes after about 3 weeks (once my end semester exams are over).
Please do post any other update/ bug fix that you feel should be made in STAC.

Updated.
Double clicking on a node (or the label inside the node) will fix/unfix its position.
A node that has been fixed will have a fill color of light blue.

Thanks!


A question about dispatch_sync

In the initializer of ImageCache:
dispatch_sync(ioQueue, { () -> Void in
    self.fileManager = NSFileManager()
})

Why not use self.fileManager = NSFileManager() directly?

While NSFileManager.defaultManager() is thread-safe, the file manager created by NSFileManager() is not. So there is a possibility of creating the file manager in a thread, but using it in another. An ioQueue could ensure all file IOs are in the same thread.

Do you mean that self.fileManager may be used when initializing an instance of ImageCache?

Hi, in fact here there should be no problem to just use fileManager = NSFileManager(), or even use a defaultManager. But if you want to add some delegate later, you will need a new created file manager and consider the thread problem.
Here I prefer a new file manager since Kingfisher is a framework and should be isolated in the io operations from the "host" app, which might be using the shared file manager.


Support reader settings

Summary
Support reader settings
Motivation
Support setting & getting reader settings in the RN SDK.
Testing

[x] I tested this manually
[ ] I added automated tests

Documentation
Select one:

[ ] I have added relevant documentation for my changes.
[x] This PR does not result in any developer-facing changes.

@maxa-stripe Sorry, this is actually my mistake that should not be put, I forgot to do code debugging on the IOS side before create this PR. Let me commit new code modificatione, thanks for your review.


Print DB name in error logs

Started including database name in all errors

Codecov Report

Merging #51 (07c2925) into main (50f093f) will decrease coverage by 0.16%.
The diff coverage is 18.42%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   70.72%   70.56%   -0.16%
==========================================
  Files          12       12
  Lines        1404     1410       +6
==========================================
+ Hits          993      995       +2
- Misses        324      328       +4
  Partials       87       87

Flag
Coverage Δ

unit-tests
70.56% <18.42%> (-0.16%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

pkg/datastore/database.go
55.28% <17.14%> (-0.43%)
:arrow_down:

pkg/datastore/helper.go
55.19% <33.33%> (+0.29%)
:arrow_up:

@jgafarov can you please update the commit message with sample logs from unit-tests or real setup?

@jgafarov can you please update the commit message with sample logs from unit-tests or real setup?

Ok, added

Lgtm


HDDS-4435. Fix can not insert the second entry when hive on ozone

What changes were proposed in this pull request?
What's the problem ?
When use hive-2.3.7 on ozone, I can not insert the second entry to table, and exception thrown from ozone.

What's the reason ?
The following hive code will call ozone's rename(src, dst) method, but if the last file of src and dst is same, ozone will throw exception.

How to fix ?
Then I tried hive on hdfs, I find hdfs's rename in this case will not throw exception, it just return false, then hive will change the dst path at destFilePath =  new Path(destDirPath, name + ("_copy_" + counter) + (!type.isEmpty() ? "." + type : ""));. So we should keep ozone and hdfs's behavior the same, so that hive can run on ozone.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4435
How was this patch tested?
No need to add new ut.

This problem is there in BasicOzoneFileSystem, we can correct it there as well.

@ayushtkn Thanks for review. I have updated the patch.

As there are no objection comment, I will merge this PR tomorrow.
@runzhiwang Thanks for your contribution.
@ayushtkn Thanks for your review.

@adoroszlai Thanks for suggestions. I have updated the patch. Could you help review it again ?

How was this patch tested?
No need to add new ut.

@runzhiwang: This part of the PR template is not specific to unit tests.  If you tested the change with Hive to confirm that the problem is fixed, this is the place to explain it (ideally with steps).  Thanks.

How was this patch tested?
No need to add new ut.

@runzhiwang: This part of the PR template is not specific to unit tests. If you tested the change with Hive to confirm that the problem is fixed, this is the place to explain it (ideally with steps). Thanks.

@adoroszlai Thanks, I have updated it.


i can get wifi name, guid  but can't get ssid when wifi connected,

@jekoie Before you connect to a AP, you should prepare its profile and the ssid should be set at that moment. Thus, for ssid information, you should already know it after you connect to the AP.


Expose side_data of a stream

Hi, thanks a ton for the fork!
I'm not sure what your intention is w.r.t. open issues in the original repo, but the one I'm particularly interested in is https://github.com/PyAV-Org/PyAV/issues/1045 - rotation metadata are not available on video streams.
It looks like there's already a PR to fix this (https://github.com/hyenal/PyAV/pull/1).

Sure. I've merged that PR and it will be available in the 11.2.0 release.


CFE-1110: UPSTREAM: : Bump community.docker to 3.10.3

Description of the change:

Update openshift/release/ansible/requirements.yml file to use community.docker 3.10.3
Run openshift/release/ansible/update-collections.sh script to update the vendored collections

Motivation for the change:

Upstream e2e testdata is using this version
https://github.com/openshift/ansible-operator-plugins/blob/f30dff62ceda41de7bfe69ce82cb6fb08c2feefe/testdata/memcached-molecule-operator/requirements.yml#L9-L10

/assign @arkadeepsen @TrilokGeer

/test images

/hold
for testing with the downstream image

/retitle CFE-1110: UPSTREAM: : Bump community.docker to 3.10.3

/unhold
e2e test passed locally

/hold
putting a hold, until https://github.com/openshift/ansible-operator-plugins/pull/11 is finalized

/remove-approve

/approve cancel

/override e2e-ansible

/override ci/prow/e2e-ansible

/lgtm

/unhold
e2e CI passed using community.docker v3.10.3: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ansible-operator-plugins/9/pull-ci-openshift-ansible-operator-plugins-main-e2e-ansible/1826275189604749312

/cc @KeenonLee
for QE label

/cherrypick release-4.17


Release new versions

Codecov Report

Merging #36 (36c0468) into main (b0cca3b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   92.39%   92.39%
=======================================
  Files          15       15
  Lines        1394     1394
=======================================
  Hits         1288     1288
  Misses        106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cca3b...36c0468. Read the comment docs.


Support VK_EXT_headless_surface

For a project, I want to be able to create a surface so I can copy the contents of the images rendered somewhere else. However, I don't want it to actually display anywhere.

Just don't create a swapchain and render to a regular image.

I'm overriding certain Vulkan commands that will be called by other applications, so I can't control whether they use a surface or not.

This seems to me to be a good candidate for an extension that could be provided by a layer. Then you could add it to any driver, not just MoltenVK. I wonder if there already is such a layer...

Can I just call vkCreateMetalSurfaceEXT with a NULL pLayer?

Can I just call vkCreateMetalSurfaceEXT with a NULL pLayer?

Highly doubtful. It's not expected, and the current swapchain images would expect to pull a MTLTexture from a CAMetalDrawable from a CAMetalLayer.
However, VK_EXT_headless_surface is fairly simple, and should be fairly straightforward to implement, after some refactoring of the contract between swapchain images and surfaces within MoltenVK.

There's this: https://gitlab.freedesktop.org/mesa/vulkan-wsi-layer, which may work (although they say it's for Linux, there's nothing in the headless support that requires Linux-specific features).


error loading package 'tensorflow/core': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//'

Operating System: Scientific Linux release 7.2 (Nitrogen)
CUDA 7.5
I'm trying to install tensorflow from source (with debug options in order to solve another issue), from GItHub branch r0.10 .
Using bazel 0.3.1-2016-08-22
Apparently related to #3437
After configuring tensorflow, I ran bazel build -c dbg --config=cuda //tensorflow/cc:tutorials_example_trainer and got the following errors:
ERROR: /hltsrv0/rocha/deps/tensorflow/tensorflow/cc/BUILD:199:1: error loading package 'tensorflow/core': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//': Error cloning repository: https://github.com/google/protobuf: cannot open git-upload-pack caused by https://github.com/google/protobuf: cannot open git-upload-pack caused by Connection timed out github.com and referenced by '//tensorflow/cc:tutorials_example_trainer'.
ERROR: /hltsrv0/rocha/deps/tensorflow/tensorflow/cc/BUILD:199:1: error loading package 'tensorflow/core': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//': Error cloning repository: https://github.com/google/protobuf: cannot open git-upload-pack caused by https://github.com/google/protobuf: cannot open git-upload-pack caused by Connection timed out github.com and referenced by '//tensorflow/cc:tutorials_example_trainer'.
ERROR: /hltsrv0/rocha/deps/tensorflow/tensorflow/cc/BUILD:199:1: error loading package 'tensorflow/core': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//': Error cloning repository: https://github.com/google/protobuf: cannot open git-upload-pack caused by https://github.com/google/protobuf: cannot open git-upload-pack caused by Connection timed out github.com and referenced by '//tensorflow/cc:tutorials_example_trainer'.
ERROR: /hltsrv0/rocha/deps/tensorflow/tensorflow/cc/BUILD:199:1: error loading package 'tensorflow/core': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//': Error cloning repository: https://github.com/google/protobuf: cannot open git-upload-pack caused by https://github.com/google/protobuf: cannot open git-upload-pack caused by Connection timed out github.com and referenced by '//tensorflow/cc:tutorials_example_trainer'.
ERROR: /hltsrv0/rocha/deps/tensorflow/tensorflow/cc/BUILD:199:1: error loading package 'tensorflow/core': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//': Error cloning repository: https://github.com/google/protobuf: cannot open git-upload-pack caused by https://github.com/google/protobuf: cannot open git-upload-pack caused by Connection timed out github.com and referenced by '//tensorflow/cc:tutorials_example_trainer'.
ERROR: /hltsrv0/rocha/deps/tensorflow/tensorflow/cc/BUILD:199:1: error loading package 'tensorflow/core': Encountered error while reading extension file 'protobuf.bzl': no such package '@protobuf//': Error cloning repository: https://github.com/google/protobuf: cannot open git-upload-pack caused by https://github.com/google/protobuf: cannot open git-upload-pack caused by Connection timed out github.com and referenced by '//tensorflow/cc:tutorials_example_trainer'.
ERROR: Analysis of target '//tensorflow/cc:tutorials_example_trainer' failed; build aborted.

I'm using a server where I have no root privileges and there's no internet access.
I understand the building process is trying to clone a repository, so, would it be possible to clone it and download any other necessary files in another machine and then copy them to the server? If so, what exactly do I need to copy and where?

I'm sorry, but this is not a supported configuration.  You might try posting this question on StackOverflow.

I would like to ask how the final solution to this problem?


Fix chatglm not implement mapping error v1

PR types

Bug fixes
PR changes

Models
Description

实现chatglm get_name_mapping函数，并修复一个attention_mask问题

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


AttributeError: module 'shap.models' has no attribute 'TeacherForcingLogits'

Hello,
I am using Shap 0.41.0, the latest at the time of writing this. I think there needs to be a code update to run_masker so that instead of calling:
wrapped_model = shap.models.TeacherForcingLogits(f, similarity_model=model, similarity_tokenizer=tokenizer)
The team might want to change it to:
wrapped_model = shap.models.TeacherForcing.get_teacher_forced_logits(f, similarity_model=model, similarity_tokenizer=tokenizer)
Here is the error I was getting:
AttributeError                            Traceback (most recent call last)
Cell In[10], line 2
1 # SHAP explanation using masking option "blur(pixel_size, pixel_size)" for blurring
----> 2 shap_values = run_masker(X, mask_value="blur(56,56)")
Cell In[9], line 50, in run_masker(X, mask_value, max_evals, batch_size, fixed_context)
47 masker = shap.maskers.Image(mask_value, X[index].shape)
49 # wrap model with TeacherForcingLogits class
---> 50 wrapped_model = shap.models.TeacherForcingLogits(f, similarity_model=model, similarity_tokenizer=tokenizer)
52 # build a partition explainer with wrapped_model and image masker
53 explainer = shap.Explainer(wrapped_model, masker)
AttributeError: module 'shap.models' has no attribute 'TeacherForcingLogits'

Hey!
Did you find a workaround for this issue.
I am stuck with the same issue now and there are not many resources online to figure this out.
Any help is appreciated!

Has this bug been fixed?

@YuanningEric Not yet. But from what I can see, it's related to #3036 . It's not very clear in the issue report, but I'm assuming the problem here pertains to the Image Captioning notebooks found here: https://shap.readthedocs.io/en/latest/example_notebooks/image_examples/image_captioning/Image Captioning using Open Source.html.
Does @dancbeaulieu 's suggestion apply for you?
If you manage to get the notebook working, we would really appreciate if you can submit a PR in the spirit of #3036.


WIP - Creating a new ResourcePolicyAuditor base class

Creating a new ResourcePolicyAuditor base class that sqs, sns, kms, elasticsearch, lambda, vpcendpoints, glacier, opsworks, s3 can use.
Moved ARN and Policy parsing code into policyuniverse.

[x] TODO: Refactor s3, sns, sqs, elasticsearch auditors to subclass the ResourcePolicyAuditor
[x] TODO: Stop using aws:username.
[x] TODO: Treat CIDRS as CIDRS and not as String matches.
[x] TODO: test elasticsearch auditor
[x] TODO: test kms auditor
[x] TODO: test sns auditor
[x] TODO: test lambda auditor
[x] TODO: test s3 auditor
[x] TODO: test sqs auditor

The new Auditor will be much more intelligent in parsing policies.  For complex conditions, it will be able to check cross account for VPC's, VPC Endpoints, S3 Buckets, and User IDS in addition to parsing regular ARNs.

Coverage increased (+1.0%) to 64.296% when pulling 44d7367182cec819e997e3e064f63abbac05d6eb on add_lambda_auditor into 0f29754fcc300db912a263620fa4ef1f98241ee9 on develop.

Coverage increased (+1.8%) to 65.08% when pulling 2c5bc5c27c508bc9d7073f0902edff93fcf6e163 on add_lambda_auditor into 0f29754fcc300db912a263620fa4ef1f98241ee9 on develop.

Coverage increased (+2.1%) to 65.429% when pulling 741fee427bef121729bd2d33f765b3b614582b6d on add_lambda_auditor into 0f29754fcc300db912a263620fa4ef1f98241ee9 on develop.

Coverage increased (+2.4%) to 65.669% when pulling 8f21e8c26ae6612ebd585f6c41c9775d1d96764b on add_lambda_auditor into 0f29754fcc300db912a263620fa4ef1f98241ee9 on develop.

Deployed and noticed a few things that need to be cleaned up:
This should output JSON, not python sets:

ALL IAM Roles/users/groups in account<PHONE_NUMBER>96 can perform the following actions: set([u'SNS:Subscribe'])

Service Principals should probably be whitelisted:

Access provided to principal:events.amazonaws.com.
Access provided to principal:logs.us-east-1.amazonaws.com.
Access provided to principal:logs.us-west-2.amazonaws.com

Logs principals cannot be parsed by the ARN class:

Auditor could not parse ARN | 3 | logs.us-east-1.amazonaws.com

Consistent Formatting on cross account issues:
ResourcePolicy creates issues in this format:

ElasticSearch Service Access Policy provides cross account access to an unknown account.
Access provided to cidr:<IP_ADDRESS>/24.

SNS Subscriptions are alerted in a different format:

Unknown Cross Account Access
SRC [123456789123] DST [demo_account]. Location: sqs subscription to arn:aws:sqs:us-west-2:123456789123:grouper

These two should be using the same format.
Item.config @hybrid_property
This PR added a @hybrid_property to Item called config.  This is causing problems with watcher.py around line 400:
db_item.config = db_item.revisions.first().config
self.changed_items.append(ChangeItem.from_items(old_item=db_item, new_item=item))

Should likely rename that hybrid to latest_config and update whatever code was relying on that new hybrid field.

Coverage increased (+2.4%) to 65.673% when pulling 83cefb223050fdc9022533fa8951c723071ed074 on add_lambda_auditor into 0f29754fcc300db912a263620fa4ef1f98241ee9 on develop.

Coverage increased (+2.4%) to 65.67% when pulling 05f30cefdbff59a68a7bf77e297fbde63be8985f on add_lambda_auditor into 0f29754fcc300db912a263620fa4ef1f98241ee9 on develop.

Interesting side effect:
Given an Internet Accessible S3 bucket limited by CIDR, the issue raised is actually

Unknown Cross Account Access
"Access provided to cidr:x.x.x.x/x"

Should unknown CIDRs be treated as cross-account or internet accessible?
Meanwhile, an Internet Accessible S3 bucket (by ACL) is:

ACL - AllUsers USED.
READ

I'd assume it is internet accessible.  I'd also consider AuthenticatedUsers to be internet accessible, allowing that AuthenticatedUsers is any AWS user and not limited to your accounts or those you have granted permissions to.  Interested to see what others think.  For me cross account should specifically have an account id that you can be used to identify it.   But there is probably more history behind why it is the way it is than I am aware of.

Coverage increased (+2.4%) to 65.67% when pulling f65fd003033047121cec39329fcfd2e1575a2e2a on add_lambda_auditor into 0f29754fcc300db912a263620fa4ef1f98241ee9 on develop.

[ ] Need to make a DB migration to rename issues from the old text to the new text to ensure no justifications are lost.

Coverage increased (+2.1%) to 68.53% when pulling decb0ef4c361e660862898c666e61f0ed5c876cc on add_lambda_auditor into 5354f5fdb5c4f867ad1e9ff1f14aa64a6eae461e on develop.

Coverage increased (+2.1%) to 68.533% when pulling decb0ef4c361e660862898c666e61f0ed5c876cc on add_lambda_auditor into 5354f5fdb5c4f867ad1e9ff1f14aa64a6eae461e on develop.

Coverage increased (+2.4%) to 68.746% when pulling e9e71184e4a28efc74958632fccdeade0f71f5d3 on add_lambda_auditor into 5354f5fdb5c4f867ad1e9ff1f14aa64a6eae461e on develop.

Coverage increased (+2.3%) to 68.733% when pulling bc8bb46a7480d0aa2991e24a8bf494a56baa8978 on add_lambda_auditor into 5354f5fdb5c4f867ad1e9ff1f14aa64a6eae461e on develop.

Coverage increased (+2.3%) to 68.733% when pulling 6f490cdd15b4f21c6024f579e19aa23ded5431a9 on add_lambda_auditor into 5354f5fdb5c4f867ad1e9ff1f14aa64a6eae461e on develop.


Move to a more privacy friendly analytics tool

Google Analytics uses cookies and has much more detail than I need. Are there any more privacy friendly analytics tools?
Possible options

https://plausible.io/
https://www.goatcounter.com/
https://justcounts.com/
https://www.simpleanalytics.com/

My own implementation

I like plausible a lot but it has a monthly cost. Might not be worth it if my analytics is like single digit users and mostly me.
Goat Counter looks good and I like the motivation behind it. So we'll do that.
This is implemented in PR: https://github.com/acnolan/acnolan.github.io/pull/48


assets tests: disable temporarily until we can fix this

@benvand will be back imminently and can take a look at why this is failing.
Once we bring it back, might actually be nice to bring it back to the smoulder tests instead so we get this checking on production.

Ahno, I removed the missing trailing line break, that's why it's showing there.


Sample Summary and Sample Information are reversed?

Seems too obvious to be a true bug, but the 'Sample Information' button takes you to a page that shows you a summary of the samples, while the' Sample Summary' page takes you to a page that lets you view individual sample information.
Can we reverse the names of these two buttons? I've tagged with group input in case there is something I'm missing.

The main difference I see with sample summary is that it designates which
prep the sample is processed in (when there is more than one prep).  I
don't use it for sample_information checking and so sample summary seems
correct to me - summary also seems applicable because you can look at one
or more problematic fields per sample without looking at all.
I really don't care if you change it though
On Thu, Aug 10, 2017 at 8:23 PM, adswafford<EMAIL_ADDRESS>wrote:

Seems too obvious to be a true bug, but the 'Sample Information' button
takes you to a page that shows you a summary of the samples, while the'
Sample Summary' page takes you to a page that lets you view individual
sample information.
Can we reverse the names of these two buttons? I've tagged with group
input in case there is something I'm missing.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/biocore/qiita/issues/2226, or mute the thread
https://github.com/notifications/unsubscribe-auth/AB69gMUfsYQlmSxJN1eIs-AaPCmohqkGks5sW8lBgaJpZM4O0NcP
.

--
Gail Ackermann
Knight Lab
UCSD
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Hmm, it's a good point that the Sample Summary page shows a summary of which preps the sample is in. However, it also provides the only way to view the metadata inside Qiita without downloading it and opening in some .tsv viewer, and in this view, you're not looking at a summary of the samples' metadata, but rather the metadata for each sample, i.e. sample information.
Stepping back, these are two very different things, and I think we should have more of a discussion on how to display them. But I'll untag this for the CMI workshop and as a bug since I think this needs to be discussed more before changing.

Decision: Merge the 2 buttons in Sample Information and have 2 tabs inside showing the 2 information.

fixed via: https://github.com/biocore/qiita/pull/2330


v4-beta.3 linebreak not respected with \text (and other issues)

Issue Summary
Linebreak issue with text elements.
Steps to Reproduce:

Open web page.
See math sticking out of container and not breaking.
Cry.

Linebreak not working with text. Math is a bit better, but also sticks out a bit.
For example:
$\texttt{The quick brown } \text{fox jumps } \textsf{over the lazy dog}\dots\ \texttt{And } \texttt{over } \texttt{the } \texttt{rainbow } \texttt{dost } \texttt{thy } \texttt{chicken } \texttt{poop } \texttt{fly}\dots$

There are also instances when output errors occur for regular LaTeX and for \breaks.
$$
e^{i\pi} + 1 = 0
\qquad
\begin{align}
x + y + z &= 1 \\\\
2x - y + 3z &= 2 \\\\
4x - 5y + 10z &= 3 \\\\
\end{align}
$$

$\texttt{Maybe (Either (a, a) (Bool, a))} \break \equiv \texttt{(Maybe a, Maybe a)}$
$\texttt{Maybe (Either (a, a) (Bool, a))} \break = \texttt{(Maybe a, Maybe a)}$

All of these are shown in the supporting demo.
Technical details:

MathJax Version: 4.0.0-beta.3
Client OS: MacOS 12.6.8
Browser: Chrome Version 116.0.5845.179 (Official Build) (x86_64)

I am using the following MathJax configuration:
MathJax = {
    tex: {
        inlineMath: [
            [
                '$', '$'
            ],
            [
                '\\(', '\\)'
            ]
        ],
    },
    svg: {
        fontCache: 'global',
        displayOverflow: 'linebreak',
    },
};

and loading MathJax via
<script defer id="MathJax-script"<EMAIL_ADDRESS>type="text/javascript"></script>

Supporting information:

Example Page: https://trebledj.github.io/mathjax/
Source: https://github.com/TrebledJ/trebledj.github.io/blob/abbe08f751793bff666545ebbbcd4b0acd129aab/content/pages/1970-01-01-mathjax.md
Screenshot below. Blue region is the .post-body container.

Console errors:tex-mml-svg.js:1 Uncaught TypeError: Cannot set property FontData of #<Object> which has only a getter
    at $a (tex-mml-svg.js:1:25309)
    at $a (tex-mml-svg.js:1:25316)
    at $a (tex-mml-svg.js:1:25316)
    at $a (tex-mml-svg.js:1:25316)
    at $a (tex-mml-svg.js:1:25316)
    at Ka (tex-mml-svg.js:1:25511)
    at chtml.js:1:164264
    at chtml.js:1:171060
tex-mml-svg.js:1 Uncaught (in promise) Error: Component chtml not loaded
    at tex-mml-svg.js:1:1258697
    at tex-mml-svg.js:1:1260555
tex-mml-svg.js:1 Uncaught (in promise) Error: Component chtml not loaded
    at tex-mml-svg.js:1:1258697
    at tex-mml-svg.js:1:1260555

I believe you need to load the textmacros extension to get \\ to work inside \text.

I believe you need to load the textmacros extension to get \\ to work inside \text.

While true, none of the example use \\ inside \text.

MathJax's rules for breaking in-line math are based on the TeX rules for in-line breaks, which are basically that breaks can occur at characters that have class BIN or REL (binary operators and relations) at the top level of the expression.  Your first example has no binary or relational operator (the \dots produce characters with class INNER), so there is no valid breakpoint in that expression.  In particular, the spaces inside the \text elements are not valid breakpoints in TeX; if you put this expression into actual TeX, it will also not break.  So MathJax is doing what it was intended to do in this case.
Your second example, with the align environment, is not valid LaTeX markup; the error message is correct and similar to the one you get if you put this expression into actual LaTeX.  The align environment is a top-level environment, and can't be placed include other expressions.  For that, you need to use the aligned environment.  If you switch to that, the expression should work for you.
Your third and fourth examples that use \break are more subtle.  MathJax translates your expressions into MathML internally, and there are some side-effects of the MathML that are occurring here.  MathML has a concept called an embellished operator, which is intended to allow things like an equal sign with a question mark over top to be treated (for spacing an line-breaking purposes) as the operator at their core, so that the embellishments don't interfere with the spacing.  An operator is embellished if it is in a container whose only other elements are "spacelike" elements (there are also some other ways to be embellished).  A spacelike element is either an mspace or an mtext element (or some other more complicated things), and a container can be the expression itself.  It is natural to consider mspace to be spacelike, but I've never fully understood why the specification makes mtext be spacelike.  Apparently, it is because some people use mtext with space characters to perform spacing, but that seems a poor reason to make all mtext elements be spacelike.
In your expression \texttt{Maybe (Either (a, a) (Bool, a))} \break \equiv \texttt{(Maybe a, Maybe a)}, the underlying MathML is
<math xmlns="http://www.w3.org/1998/Math/MathML">
  <mtext mathvariant="monospace">Maybe (Either (a, a) (Bool, a))</mtext>
  <mspace linebreak="newline"></mspace>
  <mo>≡</mo>
  <mtext mathvariant="monospace">(Maybe a, Maybe a)</mtext>
</math>

Note that this consists of an operator (the equivalent sign) together with mtext and mspace elements, all contained in the math element container, so the mo is considered an embellished operator.  That means that it, together with its embellishments (the mspace and mtext elements) are all treated as a unit.  That is why the break indicated by the mspace is not being shown.
This is the same issue for your case that involves the equal sign as well.  Ironically, it is also the case for the long text example at the bottom of your supporting demo page.  There is one operator in that expression (the period), and the rest are text elements, so the entire sentence is an embellished operator, and treated as a single (unbreakable) unit, so no line-breaking occurs.  This illustrates why I find the idea that mtext elements are to be "spacelike" to be so inappropriate.
One way around the problem is to add any non-text, non-space element into the expression.  For example, adding {} to the beginning of the expression, as in
{}\texttt{Maybe (Either (a, a) (Bool, a))} \break \equiv \texttt{(Maybe a, Maybe a)}

would make the operator no longer be an embellished one, and so line breaking would occur as expected.  The same goes for the long expression in your demo (or you could put the period inside one of the preceding \text{} macro, so there would be no operator at all).
Alternatively, you could adjust how MathJax interprets "spacelike" to make mtext elements spacelike only if they consist only of actual space characters, and not make mspace spacelike if it is specifying a line break.  To do that, you can incorporate
MathJax = {
  startup: {
    ready() {
      const {MML} = MathJax._.core.MmlTree.MML;
      MML.mspace = class myMmlMspace extends MML.mspace {
        get isSpacelike() {
          return this.attributes.getExplicit('linebreak') === undefined && this.canBreak;
        }
      }
      MML.mtext = class myMmlMtext extends MML.mtext {
        get isSpacelike() {
          const attributes = this.attributes;
          const spaces = !!this.getText().match(/^\s*$/);
          return spaces && (attributes.getExplicit('mathbackground') === undefined &&
                            attributes.getExplicit('background') === undefined &&
                            attributes.getExplicit('style') === undefined);
        }
      }
      MathJax.startup.defaultReady();
    }
  }
};

into your MathJax configuration.  Then the expression you have used should break as you would expect.

I forgot to mention the error messages you received.  That is due to having switched to CHTML output using the contextual menu.  It turns out that the way exports are handled in ESM modules is causing a problem loading the output/chtml and output/svg extensions used to switch renderers.  I will have a fix for that in the next beta release, but for now, you can use the contextual menu to switch back to SVG and the message should go away.

Finally, it would help us if you only include one type of problem in one issue post.  Your line-break issues could all be in one, but the problem with the expression involving the align environment, and the issue with the error messages in the console would be better in separate issues, as they are unrelated to the line breaking.  Having a separate issue tracker for each makes it easier for us to track and resolve them independently.  Thanks!

Thanks for the comprehensive explanation!
After some testing, placing {} at the start didn't seem to work for me, but placing it somewhere in the middle works. E.g.
\texttt{Maybe (Either (a, a) (Bool, a))} {} \break \equiv \texttt{(Maybe a, Maybe a)}

Another thing I forgot to mention was automatic linebreaking (i.e. without \break). I've put that in a different issue: #3099.
P.S. Apologies for not testing my align tex beforehand and conflating this issue. I had assumed the example would work. 🥲

It shouldn't matter where the {} is, but wherever it works for you is fine.
Note that it should only matter when there is only one operator in the expression.  If you have \text{...} \equiv \text{...} \equiv \text{...} it should not be needed.


Load up issues list

Go through the TODOS.md file. Create issues with the desired methods for implementation.

2 - 3 methods is fine.


Issue with twitter authenticator when using multi-steps and post authenticators

Fixed with https://github.com/wso2-extensions/identity-outbound-auth-twitter/pull/12


fix: OPTIC-7: Sum lead time from previous draft on annotation submission

Hi @Travis1282!
This PR was created in response to a PRs in upstream repo:

https://github.com/HumanSignal/dm2/pull/223

/git merge develop

/frontend build lsf master

/frontend build editor master

/frontend build lsf master

/frontend build lsf master

/frontend build lsf master

/frontend build lsf 3f8c90df983b9929c19115279306bac7ec272276

To enable Auto Merge for this PR also merge those PRs:

https://github.com/HumanSignal/label-studio-frontend/pull/1542


fix: changed Image alt to single quotes to ensure proper code style

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Eslint gave message 'Unexpected usage of doublequote.'

I changed it to single quotes:

Tested the solution:

To the next reviewer—I think this one is okay to be merged!


Demo improvements 2

[x] Why do we have so many different border colors for the nodes in the hierarchy? Let's use the same color for the border of the nodes in the hierarchy as their background color (all yellowish).
[x] Let's use a lighter gray for the background of nodes outside the hierarchy so that when they are selected and their background becomes black, they are more distinguishable from the others.
[x] Looks like "Run Layout" actually loads the selected sample and runs layout on it. So let's rename it as "Load and Layout Sample"
[x] "Add Selected to Hierarchy" -> "Add Selected to Hierarch and Re-Layout"
[x] "ReRun" -> "Re-Layout"
[x] Leave some minimal space between the buttons and the canvas.
[x] Adjust the wheel sensitivity so that it zooms in and out more slowly.

Pushed the changes for these.