allow replace set quota when action=replace

show when the project external resource was fetched

这个 PR 实现什么功能/修复什么问题:

设置quota时如果action=replace，则替换整个配额
project详情显示什么时候外部资源计数器被更新

是否需要 backport 到之前的 release 分支:

release/2.10.0
release/2.11.0

/area keystone
/area region

Codecov Report

Merging #1552 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1552      +/-   ##
=========================================
- Coverage    7.69%   7.67%   -0.03%
=========================================
  Files         411     411
  Lines       62907   62916       +9
=========================================
- Hits         4842    4828      -14
- Misses      57657   57678      +21
- Partials      408     410       +2

Flag
Coverage Δ

#aFlag
7.67% <0%> (-0.03%)
:arrow_down:

Impacted Files
Coverage Δ

pkg/keystone/models/projects.go
8.37% <0%> (-0.23%)
:arrow_down:

pkg/keystone/models/project_resources.go
29.03% <0%> (-4.31%)
:arrow_down:

pkg/util/rbacutils/rbac.go
70.4% <0%> (-4.37%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0e6bd...b02214b. Read the comment docs.

/lgtm
/approve


Unable to get user's email

At now Vkontakte allows to get user's email via specifying scope: ['email'] parameter:
app.get('/auth/vkontakte',
  passport.authenticate('vkontakte', scope: ['email']),
  function(req, res){
    // The request will be redirected to vk.com for authentication, so
    // this function will not be called.
});

But unfortunately I don't get this one:
passport.use(new VkontakteStrategy({
    clientID: /* clientID */,
    clientSecret: /* clientSecret */,
    callbackURL:  /* callbackURL*/
},
function(token, refreshToken, profile, done) {
      console.log(profile.email) // undefined;
});

What I'm doing wrong?

look for this lines of codes: https://github.com/jaredhanson/passport-oauth2/blob/master/lib/strategy.js#L192, so you must provide function with 5 arguments, and you can get email in params argument.


add support for ioredis

Deals with https://github.com/Automattic/kue/issues/642

You should be setting createClientFactory in Kue settings when creating Kue, that should be documented after this merged in.

Doesn't this take care of createClientFactory documentation for passing ioredis client ?

Sure, but I'd prefer mentioning support for ioredis for Redis Cluster users and provide a basic sample injecting ioredis in :)

got it, adding the documentation.

How long are you using kue with ioredis? is your PR tested widely for all kue features?

I haven't used ioredis with kue and no it is not widely tested. I could create job, process them and add a complete event callback. But when I pass ioredis cluster client its not working.
I changed the redis client in the specs to use ioredis client and all the tests pass ( they do throw Connection closed error for few of them).

But when I pass ioredis cluster client its not working

then we should not yet merge this in until this is resolved.
We also should make sure if delayed jobs (promotion) and ttl works fine

yeah, need to make sure everything works.
btw, the reason cluster is not working is because it throws
[Error: All keys in the pipeline should belong to the same slot(expect "q:jobs:inactive" belongs to slot 11113).]
```js

One way to fix it is to do this ( using Redis Cluster hash tags)
```js
    client.prefix           = '{' +options.prefix + '}';

Updated Readme.md with ioredis cluster docs.
I have found similar results with default createQueue method and passing the cluster enabled client using https://gist.github.com/anonymous/2a33c28006553bbe7e08

One way to fix it is to do this ( using Redis Cluster hash tags)

Can you elaborate on the problem and tell how is it fixed that way?

From redis cluster specs: Redis Cluster implements a concept called hash tags that can be used in order to force certain keys to be stored in the same node.
so for {q}:jobs and {q}:ids only the part inside the curly braces ( here q) is used to calculate the hash. So all the keys end up in the same slot which is needed for multi key operations.

the critical part should be lua scripting, I migrated node-warlock and it is not only about syntax, it is about the sequence of lua scripting, for old redis, you might just load-then-use, but for redis cluster, you need to either load it to all nodes, which is not possible because new nodes are likely added afterward, or  use the defineCommand pattern of ioredis

@behrad @dg3feiko any suggestions to make sure this is not breaking anything ?

hadn't enough time to test this @az7arul yet, Aren't you testing with ioredis ?

I already test it. Test passed without any error but it's not working... i'll try to dig down the problem maybe in this weekend.

+1 It would be awesome if kue worked with ioredis

From reading this change it can only deployed on an empty queue?

From reading this change it can only deployed on an empty queue?

I didn't get your point.
This patch is changing prefix:jobs -> {prefix}:jobs so that enforcing keys on the same redis instance!!!

this should mean that you can scale via using different Kue namespaces, but not within a single Kue namespace. Right @az7arul ?

My point is:
If there's stuff in prefix:jobs when you deploy this... it's lost.

Why this should happen?

Ahaaa, got you just now... Pordon @leepa
Sure you can't seemlessly upgrade to this unless you write a index migration script for your current data...

In a production environment - this kind of thing really matters. It'd surely be wise to allow for seamless migration in a production environment...?

and ofcourse we should think a work around for single redis deployments where you can stick with prefix:job and only want to use ioredis, first thing as you said, can be introducing an option of isClustered or useClusterPrefix,...
Only be warned that I'm not yet testing/accepting this PR since I've done no tests on it. Testers are welcome :)

I've been testing this PR with ioredis in sentinel mode for a couple of days now, and so far, had no issues at all. I obviously had to do a flushall on Redis beforehand. Will be moving the code out of dev and into our test environment in the next few days, where it should get a good workout.
Also, one small gotcha I found is that because ioredis only emits an error event if it has a listener on it, I couldn't work out why I was getting uncaught exceptions during redis failover, but it turns out that Kue attaches to the ioredis error event by default, so that Kue error event needs to be caught and handled in the case of a redis-server going down and ioredis attempting reconnection to a slave.
I've attached directly to the ioredis events and can now get some good logging out of it, in the case of lost connections, failovers, new connections, ready etc.
I'll keep testing and let you know if I find any issues. Cheers.

@dandanknight great hearing this from you... Can you please give us more feedback and also create a PR for any improvements you are on?

Quick update, I'm successfully using ioredis in our test environment, which consists of two web servers, each running 4 express threads (load balanced by PM2), which pop jobs (via Kue) onto a master/slave Redis store (watched by redis-sentinels), then two worker servers, each with two consumer threads  (also PM2 balanced) consuming the jobs. I've had no issues to report so far. I have been shutting down redis-servers, sentinels, restarting etc, and ioredis does a great job of picking back up the connections when the services become available. It also has an offline queue which allows it to still take in jobs and cache them until a server becomes available again.
I've written an ioredis wrapper that both my producer and consumer apps use, which you require, create an instance of, and it basically just returns a new ioredis object, but along the way also subscribes to all the extra events that ioredis offers.
I can share my code if anyone wants it, which uses ioredis's retry connection strategies etc, but I'm quite new to nodejs, so there are probably much better ways to do it than I have done!

Valuable comment @dandanknight , Are you using this PR for ioredis integration with Kue?
I'd like to see any related code for this, so I strongly prefer replacing node_redis with ioredis

Hi @behrad , yes using this PR. Not had to make any changes to it. Published it to a local private repo (Sinopia) so can be installed across our servers using npm for now, untill you guys merge it. My connection module looks like....
/**
 * Created by dan on 01/10/15.
 */

var Redis = require('ioredis');
var log = require('./log');

var _redisConfig;
var notified = false;

function IoRedis(redisConfig) {
    this._redisConfig = _redisConfig = redisConfig;
    this._lastConnectionAttempt = 0;
    this._lastSentinelConnectionAttempt = 0;
    log.debug("Redis config: ", this._redisConfig);
}

var exports = module.exports = IoRedis;

IoRedis.prototype.createClient = function () {

    var _this = this;

    var redis = new Redis(
        {
            sentinels: _redisConfig.sentinels,
            name     : _redisConfig.name,
            enableOfflineQueue: _redisConfig.enableOfflineQueue,
            retryStrategy : function(times){
                var delay = Math.min(times * 5 * 1000, 60000);

                if(_this._lastConnectionAttempt !== times){
                    log.warn("REDIS: Connection attempt %s, will retry in %s seconds...", times, delay / 1000);
                    _this._lastConnectionAttempt = times;
                }

                return delay;
            },
            sentinelRetryStrategy : function(times){
                var delay = Math.min(times * 5 * 1000, 60000);
                if(_this._lastSentinelConnectionAttempt !== times) {
                    //console.log("Attempt Sentinel reconnection in %s seconds....", delay);
                    _this._lastSentinelConnectionAttempt = times;
                }
                return delay;
            }
        });

    redis.on('ready', function (a, b, c) {
        log.info("REDIS: Connection ready: %s:%s - ID:%s", this.stream.remoteAddress, this.stream.remotePort, this.stream._handle.fd);
    });

    redis.on('reconnecting', function () {
        if (!notified) {
            log.warn("REDIS: Attempting reconnection...");
            notified = true;
        }
    });

    redis.on('close', function () {
        if (!notified) {
            log.warn("REDIS: Connection closed: %s", this.connector.stream._host);
        }
    });

    // Allow Kue to subscibe to this event (as it does anyway) and handle the errors there.

    //redis.on('error', function (err) {
    //        log.error("REDIS: ", err);
    //});

    redis.on('end', function(){
        log.debug("REDIS: No more connections will be made");
        notified = false;
        _this._lastConnectionAttempt = 0;
    });

    redis.on('connect', function () {
        log.info("REDIS: Connected to: %s:%s - ID:", this.stream.remoteAddress, this.stream.remotePort, this.stream._handle.fd);
        notified = false;
        _this._lastConnectionAttempt = 0;
    });

    return redis;
};

Redis.Promise.onPossiblyUnhandledRejection(function (error) {
    log.error("REDIS ERROR:", error);
});

And then simply connect the normal way using....
var IoRedis = require('./ioRedis');

KueUtils.prototype.connect = function () {
    ioRedis = new IoRedis(this._redisConfig);
    this._q = q = kue.createQueue({
        redis: {
            createClientFactory: ioRedis.createClient
        }
    });

    if(this._q.listeners('error').length === 0){
        this._q.on('error', function (err) {
            if (err.code === "ECONNREFUSED" && !notified) {
                log.error("Redis lost connection, attempting reconnect");
                notified = true;
            }
        });
    }
};

Like I said, I'm quiet new to Node, so please don't take any of this code as gospel! Also, I've straight copied and pasted from my IDE, so there may be a few specific bits in there that are only relevant to my project. Cheers.


Maintained forks of this repo?

Are there any maintained forks of this repo?
There are many open PR or issues which get meaningless "this repo is no longer maintained" replies.

Great question... anyone want to start one?

I do. Have added challenge required resolver, two user endpoints and a feed endpoint so far. Now i am starting to look into some issues from here.
I might neither have the quality nor the speed of ping, but I will try my best. I do not know yet if i can get a hold of the python package (or how to manage it), until then manual installation is required

I would happily contribute. Count me in.

It would be great to keep this project alive.

I’d happily help on some things.
Thanks
On Mon, Aug 30, 2021 at 08:14 pidgeon777 @.***> wrote:

It would be great to keep this project alive.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ping/instagram_private_api/issues/325#issuecomment-908292305,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQEAHKPBETK4QBV7Q4ABRDT7NY3NANCNFSM4WQVP6FA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Jason Mellone https://www.linkedin.com/in/jasonmellone/
631.219.5351
@.***


[BOOKTABLES]: Add BOOKTABLE to std.conv

(improving the status quo)

these should go text, wtext, dtext, hexString

Good point! Using alphabetical sorting here doesn't make much sense ;-)


Cleanup and fix some Android issue's

Use generics to find views in layout
Use MvxCachingFragmentStatePagerAdapter to improve ViewModel usage and caching
Use generics for Fragments

Looks great @martijn00 - thanks a bunch!

Happy to help @simonjaeger ! I can fix the other issue's as well if you like. Let me know if you have any questions or problems with @mvvmcross


Is not support dynamic type?

Here is what to include in your request to make sure we implement a solution as quickly as possible.
1. Description
Is not support dynamic type?
2. Exception
Unhandled exception. No property or field 'temp2' exists in type 'TestDynamicObject' (at index 6)

3. Fiddle or Project
DynamicExpressionParser.ParseLambda(typeof(TestDynamicObject), typeof(bool), "np(it.temp2).Weight > 3");

class TestDynamicObject : DynamicObject
{
    private readonly SortedDictionary<string, object?> _dicValues = new();

    public override bool TryGetMember(GetMemberBinder binder, out object? result)
    {
        _dicValues.TryGetValue(binder.Name, out result);

        return true;
    }

    public override bool TrySetMember(SetMemberBinder binder, object? value)
    {
        _dicValues[binder.Name] = value;

        return true;
    }
}

Why would you extend DynamicObject?

Converts json strings to dynamic objects and then filters based on dynamic objects.


[BACKEND] Support Hopper MMA to MMA convert_layout ops

This PR enables mma to mma conversion on the hopper architecture.
We also replace the previous isMmaToMmaShortcut with the more general cvtNeedsSharedMemory in several places.
Note that mma to mma conversion using shared memory still goes through the legacy ConvertLayoutOpConversion function; we will deprecate it soon in the next PR.

This PR enables mma to mma conversion on the hopper architecture.

Could we make the PR description have a verb in it?  Like, "Support Hopper MMA to MMA convert_layout ops", something like that?

Hi @jlebar , feel free to take the second pass now. Thanks for the suggestions. Hope my comments are better now :)

Hi @jlebar , please feel free to take another pass now.


[shared_preferences] Address privacy manifest requirement

This plugin is listed on https://developer.apple.com/support/third-party-SDK-requirements/ as requiring a privacy manifest. We'll need to add a manifest that lists our required reason usage.
See https://github.com/flutter/flutter/issues/131940 and https://github.com/flutter/flutter/issues/131495 for context.

Ideally we would use C56D.1 since that usage corresponds exactly to what we are doing, but since Apple considers the plugin to be its own SDK it doesn't quality for that due to:

This reason may not be declared if your third-party SDK was created primarily to wrap required reason API(s).

Currently the best option available for us is 1C8F.1

Declare this reason to access user defaults to read and write information that is only accessible to the apps, app extensions, and App Clips that are members of the same App Group as the app itself.

That applies right now, but if we add suiteName support we would need to figure out how to restrict it to the app group (maybe via name prefix checks?).
We have reached out to see if there's a way to get to a point where we can use something more like C56D.1.
(Another option is that we could, in theory, fold shared_preferences into the engine so that C56D.1 would be applicable, but that's a major change to make just for this.)


Adds user validation and stash thread context

Description
Adds user validation for all transport layer classes and stashes the thread context for all system index interactions.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

FYI We are finding in ISM, issues with security integ tests are around usage of the right client in integ tests: https://github.com/opensearch-project/index-management/pull/1222


InspectorUtil fall if use OneLine at editor window (not in inspector)

In case of using some global editor window with small child editors, OneLine flag in child objects can fall.
For example:
Some scriptable object
public class GlobalConfigContainer : ScriptableObject
{
    public ConfigPart part;
}

public class ConfigPart
{
    [SerializeField]
    [OneLine.OneLine]
    public SomeDatas[] dataArray;
}

Some editor window
public class GlobalConfigEditor : EditorWindow
{
    private Editor _editor;

// ......

    public override void OnInspectorGUI()
    {
        // here we creating and drawing some editor for our scriptable object
        if (_editor == null)
            _editor = CreateEditor(CreateInstance<GlobalConfigContainer>());

        _editor.DrawDefaultInspector();
    }
// ......
}

In this case we catch error because InspectorUtil can't find inspector window (in this case we using custom editor window)
OneLine can not initialize Inspector Window Utility.
You may experience some performance issues.
Please create an issue on https://github.com/slavniyteo/one-line/ and we will repair it.
System.Reflection.TargetException: Non-static field requires a target
  at System.Reflection.MonoField.GetValue (System.Object obj) [0x0000b] in <d7ac571ca2d04b2f981d0d886fa067cf>:0
  at OneLine.InspectorUtil.get_ScrollPosition () [0x00001] in Assets\ThirdParty\OneLine\OneLine\Editor\Utils\InspectorUtil.cs:63
  at OneLine.InspectorUtil.Initialize () [0x0006c] in Assets\ThirdParty\OneLine\OneLine\Editor\Utils\InspectorUtil.cs:60
  at OneLine.InspectorUtil..ctor () [0x00045] in Assets\ThirdParty\OneLine\OneLine\Editor\Utils\InspectorUtil.cs:41

Thank you for reporting.
What version of Unity do you use?

Oops, forgot to attach to report, sorry.
Unity version 2018.4.0f1

Seems to be similar to #34.
At versions v0.4.0+ you can disable this message at Window/OneLineSettings by turn off the Culling column.
As I said in https://github.com/slavniyteo/one-line/issues/34#issuecomment-478413485, one of my magic optimizations is broken in the latest versions. But you affected by this only if your consist of very large arrays (optimization allow not to draw invisible elements).

Looks like same but not fully. In #34 problem then in 2019 Unity s_CurrentInspectorWindow field deleted but in this case we just not using inspector window - we using custom editor window. In this case s_CurrentInspectorWindow exist but null.
Exception throws at OneLine.InspectorUtil.get_ScrollPosition, in case of reflection didn't found inspector field - exception was thrown by few lines earlier.

Thanks, turning down of content culling helps :)
But it saves to local Prefs (not in Project Settings) and I can't share this solution to all team via git, so just commented exception for next OneLine update.

Sorry, I can't take a screenshot now (because I don't have Unity installed right now), but there is an option to store settings in ScriptableObject.
As said in the description (you can see it in the Inspector when you open Window/OneLineSettings), you can choose where to store your settings: in ScriptableObject or in EditorPrefs. See https://github.com/slavniyteo/one-line/blob/master/Editor/Scripts/Settings/SettingsEditor.cs#L22.
Don't forget to click the Save button =)

Wow, it's work, thanks)

Closed with #v0.5.2

Closed with #v0.5.2


Commit stats

We want to see stats per release, the way this is being done here is by doing log diffs between release tags.  Ex: git log boost-1.78.0..boost-1.79.0.  The output is the parsed and the commits are saved with a foreign key to the LibraryVersion it relates to.

commits are imported by doing "bare" clones (no project files, only git data) of repos into temporary directories, as created by python's bulitin tempfile.TemporaryDirectory
Added Commit model
Added CommitAuthor model
Added CommitAuthorEmail model

One CommitAuthor can have many emails.

Added task for importing commits. (and admin link to trigger it)
Added task for importing CommitAuthor github data (avatar and profile url, with admin link to trigger it)
Added a basic Library stat page which can be viewed by going to the admin -> library -> view stats.  (Not very pretty right now and if this data isn't valuable then we should just remove this page.)
Added a Get Release Report button in the LibraryAdmin which allows a staff member to select a boost version and up to 8 libraries to generate a report for. The report is just a webpage which attempts to convert cleanly to a pdf using the browser's print to pdf functionality.
Updated the Library Detail page to show commits per release instead of per month.
Updated the Library Detail page to show Maintainers & Contributors sorted by maintainers, then the top contributors for the selected release, then the top contributors overall by commits descending.

squash

is there any reason not to squash and merge this to develop?

@vinniefalco I'm adding some final changes and I will take this out of draft.  Someone can do a final review then, or I can just squash merge it after.

Should the summarized CommitData model be removed or just keep it in case we want to use it elsewhere?
If we switch to showing "commits per release" in the library detail page, I don't think that CommitData is being used anywhere else right now.

Just that it's nice to delete code if it's not being used.

looks good, a few suggestions:

For the avatars, I suggest a standard margin or padding, about half of what's currently used, and use items-center rather than space-between
Since we have the user name pop up on the avatar mouseover, do we really need an seperate list of names?
I understand that the commit numbers aren't being used, but it is currently ordered by the number of commits, did we also want to randomize the order? (not a huge deal, but it does make everyone equal)

I updated the spacing between avatars, I'll merge it as is otherwise and we can update things outside of this pr


Notes update

2 conflicts were resolved and now perfectly running in the localhost, ok to merge after review


Fix rsort/ssort tables

This also resolves #246.

Codecov Report

Merging #248 (d05c797) into master (e82744f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #248   +/-   ##
=========================================
  Coverage     65.21%   65.21%
  Complexity      589      589
=========================================
  Files           101      101
  Lines          2084     2084
  Branches        239      239
=========================================
  Hits           1359     1359
  Misses          669      669
  Partials         56       56

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Professional mediators links

Added link to private mediators in docx and also added date in footer in docx.

Also added extra wait time in tests - this last time managed to pass all github tests.


Change to use rainbow instead of colorize

colorize is licensed under GPL-2 which conflicts with the MIT license of
github_changelog_generator.  This changes all usage of colorize to
rainbow which does have a compatible license (MIT)

Hello James!
Good choice of library.
I wonder: we're coloring strings that pass through our log function in the Helper namespace. Idea: Can we ditch all spread-out coloring of these?

@jamesc Hi! I made my comment into a PR-onto-your-PR.

@jamesc Oh, I made a change, again.

Yeah, I backed out that change.  It doesn't fix the travis builds anyway.

@jamesc Cool, thanks for your hard effort!
This change fixes a hard problem, and we got the logging mechanism placed more centrally, by only using its formatter. And we got rid of the String extension, which the colorize gem also had.
To make the PR really stand out in the changelog, do you want to rephrase the title of it? Since we will be making a CHANGELOG.md out of this, something clearer (for understanding at a glance). Examples include:

Use rainbow instead of colorize
Replace GPL'd colorize gem with MIT-licensed rainbow

Again, thanks a lot for doing this, @jamesc! 🎉


problem with fortniteleaderboardData

I am now using php 7 but am getting this error? Any ideas?
PHP Warning:  Division by zero in /var/www/fortnitetest/vendor/tustin/fortnite-php/src/Model/FortniteStats.php on line 72
PHP Fatal error:  Uncaught Error: Call to undefined method Fortnite\Leaderboard::getLeaderboardData() in /var/www/fortnitetest/basic2.php:18
Stack trace:
#0 {main}
thrown in /var/www/fortnitetest/basic2.php on line 18

@Fyris looks like a problem with the code you added. You're trying to calculate the custom properties (kill/death, win/loss, etc) without doing a check to make sure the divisor in each statement isn't zero. This would be an issue for people who haven't played the game but want to use this library for stat lookup or something. I'll add the checks and commit the change.

I was using the example leaderboard code that came in the distribution

oh ok thanks

Oh my bad! I like to use the shorthand names like that because some of the previous ones just seem redundant. Although I am surprised that PHP only throws a warning on a division by zero error.

Thanks Fyris and my bad I probably should have dug a bit deeper.


Fix bottleneck in AbstractFileSystem.find

By changing the list to a set, my test case (writing a zarr array
through s3fs) got 50x higher throughput and went from CPU to IO bound.
This fix is minimal with no semantic changes. It is a question whether the if name in out on line 387 and if path not in out on line 389 should be dropped, but line 387 in particular is a change in behaviour since it's not necessarily name that is added to out.

This is definitely a positive change, thank you. Can you please check if it makes any difference to change the order of checks on L389?

I'm just a tourist in this code, and my use case / test case probably doesn't trigger the test on line 389 at all. Do you mean difference in performance?
If I was more confident with the code, I would assume that path cannot be walked if it is a file, and that name cannot be empty, and reorder it to
        out = set()
        if self.isfile(path):
            # walk works on directories, but find should also return [path]
            # when path happens to be a file
            out.add(path)
        else:
            for path, dirs, files in self.walk(path, maxdepth, **kwargs):
                if withdirs:
                    files += dirs
                for name in files:
                    out.add("/".join([path.rstrip("/"), name]) if path else name)
        return sorted(out)

and at that point it wouldn't matter if out was a list or a set. But then I'd worry that I didn't think of some weird corner case.

Unfortunately, a path might sometimes be both a file and a directory :)
I like your change and will merge it, and may get around to seeing whether my suggestion makes any measurable difference.
Please feel free to be more than a tourist, if it interests you!

I was afraid of something like that :)
Thanks!


SSL Certificate issue

Using Docker.
After run i get such error in log.
Error with cURL: Problem with the SSL CA cert (path? access rights?)
URL: https://api.bitfinex.com/v1/balances
Retry in 2 sec...
Cert is exists and not out of date. Rights seems to be ok.

I get this with bitstamp


Incorrect password, local config.yaml not used

OS/Web Information

Web Browser: Chrome
Local OS: Windows / MacOS
Remote OS: Ubuntu
Remote Architecture: amd64
code-server --version: 3.10.1

Steps to Reproduce

Create a config.yaml and fill in the fields like this

bind-addr: <IP_ADDRESS>:8080
auth: password
hashed-password: xxxx
cert: false

The hashed password was generated with printf "thisismypassword" | sha256sum | cut -d' ' -f1
2. Setup Nginx proxy conf file, and launch with docker compose
 code-server:
    image: codercom/code-server:latest
    container_name: "code-server"
    hostname: "code-server"
    restart: unless-stopped
    user: root
    environment:
      - DOCKER_USER=${USER}
    expose:
      - "8080"
    volumes:
      - ${WORK_DIR}:/home/coder/project
      - ${HOME}/.vscode:/home/coder/.local/share/code-server
      - ${HOME}/.config/code-server:/home/coder/.config/code-server

Go to my browser and type in the password, but always receive a "Incorrect password" error.
I checked the config file ~/.config/code-server/config.yaml inside the container and it was the same as the local one.

Expected
Login page leads to coder workspace upon entering the password specified in local config.yaml
Actual
Login page shows "Incorrect password". Container logs output "Failed login attempt".
Logs
This were the logs from the container
[2021-05-20T14:20:59.093Z] info  Wrote default config file to ~/.config/code-server/config.yaml
[2021-05-20T14:20:59.548Z] info  code-server 3.10.1 421237f499079cf88d68c02163b70e2b476bbb0d
[2021-05-20T14:20:59.549Z] info  Using user-data-dir ~/.local/share/code-server
[2021-05-20T14:20:59.570Z] info  Using config file ~/.config/code-server/config.yaml
[2021-05-20T14:20:59.570Z] info  HTTP server listening on http://<IP_ADDRESS>:8080
[2021-05-20T14:20:59.570Z] info    - Authentication is enabled
[2021-05-20T14:20:59.570Z] info      - Using password from ~/.config/code-server/config.yaml
[2021-05-20T14:20:59.571Z] info    - Not serving HTTPS
Failed login attempt {"xForwardedFor":"x.x.x.x","remoteAddress":"x.x.x.x","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36","timestamp":1621520562}

I could not reproduce this locally. Here are the steps I followed:

printf "thisismypassword" | sha256sum | cut -d' ' -f1 - copy value
paste in ~/.config/code-server/config.yaml after hashed-password:
launch code-server with code-server
see login page
type in "thisismypassword"

Screenshot
https://user-images.githubusercontent.com/3806031/119032311-e54d9d00-b960-11eb-859b-b9267fdd1e05.mov
Do you mind posting your config.yaml? Maybe @code-asher sees something obvious I'm not seeing

Oddly enough I seem to have the same issue if I use Docker.
docker run -p 8081:8080 -v ~/.local/share/code-server:/home/coder/.local/share/code-server codercom/code-server:latest

Then on localhost:8081I have the issue. But I also have code-server running locally on 8080 and it works fine (using the same config file).

Whoops I mounted the wrong directory. Should be ~/.config/code-server.

All right now that I have the right directory it works for me. I generated my password the same way. Nothing looks out of place to me.
Does the login page say that the password is from the config file?

Thanks for the quick reply. Since the environment variable $HASHED_PASSWORD always takes precedence I finally managed to login that way. Not sure if it was caused by some of sort cache by container volumes.

Interesting! Well glad to hear you managed to make it work. Sorry for the trouble. Can we close this?


Better colors

The current colors for canvas background, shape background and stroke don't look super good. I'd love if someone could come up with better color palettes so that just clicking on random colors would make diagrams look good

For discussion, here are D3's schemes:
https://github.com/d3/d3-scale-chromatic#api-reference

@pshihn nice, they look great! Do you want to bring them to excalidraw?

Haha, perhaps.
Should decide whether to have different palettes, or pick one of these. I like schemeTableau10 and schemePaired from the D3 schemes.

I think we should pick only one and make it good :)

Actually, I think we should have one per type of colors. Canvas background, shape background and stroke colors should likely all be different.

@vjeux can I take this one ? Colors are pretty subjective for sure, but pretty confident I can setup something better than what we have and we can further iterate on those palettes 👍

Fixed by #304


e2e framework

First step toward addressing #698, this PR introduces an e2e framework based on the kube implementation.
The util.go in kube has many more helper functions, but I figure we can bring those over on an as-needed basis as that file is huge in kube with lots of dependencies.
make test-e2e will run the e2e tests, which only contain a sample test case that always passes right now as an example.
I broke this PR into three commits

import of the ginkgo and gomega deps
add the e2e framework
add an broker e2e test as an example

@derekwaynecarr @pmorie @MHBauer @arschles

The util.go in kube has many more helper functions, but I figure we can bring those over on an as-needed basis as that file is huge in kube with lots of dependencies.

Yeah, we could also make a new kube/e2e repo and put stuff there and consume it from both this repo and k8s

I think you need to checkin the changes to glide.lock as well.

@sjenning how about an extremely basic E2E along with this that adds a Broker and waits for it to become ready?

@MHBauer I've pushed a new commit that is the result of a glide update -v, since the lock file is only regenerated when a full dependency tree is calculated.
There are some other deps that are getting updated for reasons unknown to me.  Doesn't seem to break anything though.

@pmorie so in order for the broker resource to become ready, there will need to be a broker pod running.
so you are asking for:

create broker pod in kube
wait for it to be running
create broker service in kube
create broker resource in sc with URL pointing to broker pod
wait for it to become ready

That right?

@pmorie broker e2e is now included, PTAL

@sjenning yep, that's exactly what i was looking for, thanks.

How do I run this?

Is any of this copied from upstream? Can we use it directly vs doing the copy?
I guess we can use ginkgo in our unit tests after this. That might be nice.

@MHBauer the upstream framework is much more complicated.  Plus we need to have both a kube client and service catalog client in our case and we don't want upstream e2e changes wrecking our e2e on each rebase IMHO.
If you want to run it
make bin/e2e.test
bin/e2e.test -kubernetes-config=path/to/kube.config -service-catalog-config=path/to/servicecatalog.config

Alternatively, you can set the config files with KUBECONFIG and SERVICECATALOGCONFIG, or if you have them as two contexts in the same config, use -kubernetes-context and -service-catalog-context
make test-e2e assumes that you have KUBECONFIG and SERVICECATALOGCONFIG set for now.

Put that comment into the docs/devguide.md, please. I'll give it a run through and report back.

Does kubernetes have to be running?
Does the service catalog have to be running?

Does kubernetes have to be running?
Does the service catalog have to be running?

Yes and yes

I've seen this error twice now, but perhaps I'm doing something wrong:
bin/e2e.test
I0428 11:09:24.153464    5331 e2e.go:44] Starting e2e run "aa0d1d83-2c24-11e7-9523-54ee7511a25f" on Ginkgo node 1
Running Suite: Service Catalog e2e suite
========================================
Random Seed:<PHONE_NUMBER> - Will randomize all specs
Will run 1 of 1 specs

[service-catalog] Broker
  should become ready
  /home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/broker.go:135
[BeforeEach] [service-catalog] Broker
  /home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/framework/framework.go:53
STEP: Creating a kubernetes client
Apr 28 11:09:24.153: INFO: >>> config: /var/run/kubernetes/admin.kubeconfig

STEP: Creating a service catalog client
Apr 28 11:09:24.161: INFO: >>> config: /tmp/sc-kubeconfig

STEP: Building a namespace api object
Apr 28 11:09:24.162: INFO: namespace: &Namespace{ObjectMeta:k8s_io_apimachinery_pkg_apis_meta_v1.ObjectMeta{Name:,GenerateName:e2e-tests-create-broker-,Namespace:,SelfLink:,UID:,ResourceVersion:,Generation:0,CreationTimestamp:0001-01-01 00:00:00 +0000 UTC,DeletionTimestamp:<nil>,DeletionGracePeriodSeconds:nil,Labels:map[string]string{},Annotations:map[string]string{},OwnerReferences:[],Finalizers:[],ClusterName:,},Spec:NamespaceSpec{Finalizers:[],},Status:NamespaceStatus{Phase:,},}
[BeforeEach] [service-catalog] Broker
  /home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/broker.go:108
STEP: Creating a user broker pod
STEP: Waiting for pod to be running
STEP: Creating a user broker service
[It] should become ready
  /home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/broker.go:135
STEP: Creating a Broker
STEP: Waiting for Broker to be ready
[AfterEach] [service-catalog] Broker
  /home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/framework/framework.go:54
[AfterEach] [service-catalog] Broker
  /home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/broker.go:117
STEP: Deleting the user broker pod
STEP: Deleting the user broker service

• Failure [35.259 seconds]
[service-catalog] Broker
/home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/framework/framework.go:89
  should become ready [It]
  /home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/broker.go:135

  Expected error:
      <*errors.errorString | 0xc420355b20>: {
          s: "timed out waiting for the condition",
      }
      timed out waiting for the condition
  not to have occurred

  /home/jpeeler/src/go/src/github.com/kubernetes-incubator/service-catalog/test/e2e/broker.go:132

Ran 1 of 1 Specs in 5.750 seconds
Turns out there was some docker issue at play in the above error. Looks good!

That is awesome
On Fri, Apr 28, 2017 at 12:14 PM Jeff Peeler<EMAIL_ADDRESS>wrote:

Ran 1 of 1 Specs in 5.750 seconds
Turns out there was some docker issue at play in the above error. Looks
good!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes-incubator/service-catalog/pull/741#issuecomment-298040979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWXmKdlT9rA0xrKdTlK5k5Fob4goOkdks5r0hBvgaJpZM4NGTdE
.


7.0.x TS-5059: Fixes for building with OpenSSL 1.1

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1323/ for details.

Linux build failed! See https://ci.trafficserver.apache.org/job/Github-Linux/1217/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1325/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1219/ for details.

Mr (!) The Oil Rig,   ( :-) )
did you check with @bryancall if he's planning a 7.0.1 release? if not, this is a moot point, 7.1.x will hopefully be released in 4 weeks.

We are plan to not make a 7.0.1 release and focus our energy on 7.1.0.  I am going to close this PR.


Show see emoji on gallery item

Show emojis on Item or hide it on list.

@roiLeo please check this PR.

This is the result:

Oh this is awesome @chris-saburo !

@yangwao: This is not the fix I guess
The problem is that when you are logged in you can see the emotes.

However, when you are logged out you cannot see the emote button and the emotes.
Fix:
In GalleryItem I misplaced the v-if on Appreciation. The fix is to put the v-if into the Appreciation and only show emoteButton only if you are logged in


change walking_hook with flush

Short Description:
change walking_hook process with flush
Fixes:

currently we don't accept pull request on master, all work are based on dev branch.
let me close this.
Walk_hook is not possible in dev branch since we don't track 3rd pgoapi for now, just download when use it.


biber: 2.4 -> 2.5

Motivation for this change
Upgrade biber and its dependencies, and ensure that almost all tests pass.
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Looks like a dup of https://github.com/NixOS/nixpkgs/pull/16597

@joachifm thanks, I will close this PR.

@vrthra, many thanks nonetheless, I had forgotten to include the commit that updates perlPackages.TextBibTeX

@jokogr, if you would, could you please switch on doCheck for biber (see this PR)? it fails just one test case now, and it helps to know if any other test cases fail.

@vrthra, sure thing, just give me some time. Is it OK to add you as a biber maintainer, as you have in your PR?

@jokogr sure! I will be glad.


Aligning with Bash style guide

Changed to align to bash style guide

@sreekzz
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


How to improve training speed?

Hello there,
Thanks for open sourcing DLRM. I tried to train from scratch using the ./bench/dlrm_s_criteo_terabyte.sh. While it was able to train well on all of my GPUs, I wasn't able to use the GPUs fully. I only saw 7-8% utilization on A100-PCIE-40G GPUs.
Why is the utilization low? Is it because pipeline parallelism needs to be implemented? I think I saw a PR under review for this.
Are there any tips to run this workload faster by utilizing GPUs fully?

@rakshithvasudev
have you run the https://github.com/kamalkraj/dlrm-jax ?
What is the speed per iteration? According to Raj, he gets 7.9 ms/it with GPU ON, and about 10 ms/it without GPU.  My current number is around 5 ms/it.
Finished training it 1024/306969 of epoch 0, 7.90 ms/it, loss 0.518843
Finished training it 2048/306969 of epoch 0, 7.90 ms/it, loss 0.504157
Finished training it 3072/306969 of epoch 0, 7.87 ms/it, loss 0.498123
Finished training it 4096/306969 of epoch 0, 7.89 ms/it, loss 0.487220
Finished training it 5120/306969 of epoch 0, 7.89 ms/it, loss 0.486305
Finished training it 6144/306969 of epoch 0, 7.92 ms/it, loss 0.481553
Finished training it 7168/306969 of epoch 0, 7.88 ms/it, loss 0.477103
Finished training it 8192/306969 of epoch 0, 7.86 ms/it, loss 0.476559
Finished training it 9216/306969 of epoch 0, 7.86 ms/it, loss 0.474173
Finished training it 10240/306969 of epoch 0, 7.91 ms/it, loss 0.471978

Unfortunately you can not mix --num-workers and --memory-map flags, see issue https://github.com/facebookresearch/dlrm/issues/159.


Add Validation failure information to Validation Outcome

Added:

Validation Summaries to Validation Outcome which contains information relating to validator failures, successful validations are omitted due to the fact they don't contain information we are interested in, and in the case of streaming will bloat the validation outcomes in each chunk

Example:
ValidationOutcome(
    call_id='5221586160',
    raw_llm_output='OpenAI is great',
    validation_summaries=[
        ValidationSummary(
            validator_name='RegexMatch',
            validator_status='fail',
            property_path='$',
            failure_reason='Result must match \\(?\\d{3}\\)?-? *\\d{3}-? *-?\\d{4}',
            error_spans=None
        )
    ],
    validated_output='OpenAI is great',
    reask=None,
    validation_passed=False,
    error=None
)

Associated PRs:

https://github.com/guardrails-ai/interfaces/pull/11
https://github.com/guardrails-ai/interfaces/pull/12
https://github.com/guardrails-ai/guardrails-api-client/pull/25

Needs to get merged after this is merged:

https://github.com/guardrails-ai/guardrails-api/pull/77

does async_guard or the other places we yield a ValidationOutcome like in async_stream_runner or stream_runner need updates?

so Async Guard should, but ValidationOutcome not yielded yet on streaming (sync/async) that's going to come after (but soon). needs a bit more care to avoid introducing performance issues due to the need to iterate through validation logs in each chunk


feat(gridsome): re-introduce pypi stats shields on plugin pages

Currently we're missing these shields on the new gridsome site

Just noting for reference, we have to use a heuristic of some sort to determine which pip_url strings are likely PyPi libraries. I think we can simply check for the space (' ') and slash (/) characters not in the pip_url.
This means we won't catch those that are part of a multi-part pip_url.


Support for finding implementors of an interface/renaming

First off all, I just stumbled across this gem and can't tell you how pleased I am with it.
I tried https://marketplace.visualstudio.com/items?itemName=felixfbecker.php-intellisense previously and it was slow and just didn't work properly for me, so far intelephense works great.
The things that so far stop me from using it as a full intellij replacement are:
a) finding implementors of an interface/subclasses
b) refactoring as in renaming functions etc
Are those things planned/are there currently any contribution guidelines in case of feeling adventurous?

Thanks for the feedback! The goal is to support all language protocol features where possible. An implementor provider should be possible without too much effort. Rename and find all references will likely be more involved and implementing those wont happen in the short term. I'd welcome any help, in the coming days I'll get together a contribution guideline and organise things somewhat.


Allow PowerToys  Run to start up [Color Picker]

Description of the new feature / enhancement
I want to type color picker in PowerToys Run's Input ,Enter can start up [Color Picker]
Scenario when this would be used?
In fact ,use PowerToys  Run to start up [Color Picker] ,that way reduce the keybinding burden of memory . It 's more humanized and rationalization.
Supporting information
No response

Hi there! I just found out we do have this functionality in PT Run as a plug-in! Go ahead and enable it and should be able to do that!


Implement .allow() to extract nullable schema

Hello, there.
I made the PR that resolves #21 .
Here's my work.

Thank you.

Any change of getting this merged ?

This is solved with the most recent version, thanks!


Async client: server IP to be set at runtime

Currently the ModbusClientTCPasync has a single constructor only that takes the IP address and port of the target Modbus server.
This requires to know the target at compile time already. It would be nice to have a way to create a ModbusClientTCPasync object without a target first and have a call to set it later - potentially from some configuration variables (IP and port). The already existing connect() method would come handy for that. Of course the object then must be protected to be started target-less.

I added a new connect(IPAddress host, uint16_t port) method to ModbusClientTCPasync, that does call disconnect(), sets the new host and port and finally does a connect() again.
There should be another constructor without the need to give a host and port initially, but then the existance of a valid host has to be checked throughout the code, so I left it as is for now.
I will update the docs accordingly.,


Support verify hash via config file

Is there any reason that the --verify-sha256 option is only available via the CLI, and not the repo settings in configuration?
This tool is fantastic and I would love to use it for CI/CD but at the moment I have to call each package from my config individually with the --verify-sha256 added instead of just eget -D.

Should be available now via verify_sha256

This is working great, thanks for the quick turnaround!


ASAN reports free on address not malloc()-ed on destruction

We came across ASAN reports in our unit tests.
We started digging with ASAN because valgrind reported errors and leaks. Not sure if they were related though.
What version of gRPC and what language are you using?
grpc v1.28.1, C++11
We could not reproduce this with grpc v1.26.0
What operating system (Linux, Windows,...) and version?
Linux 5.6.10-arch1-1 #1 SMP PREEMPT Sat, 02 May 2020 19:11:54 +0000 x86_64 GNU/Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc (Arch Linux 9.3.0-1) 9.3.0
What did you do?
Basically, the code that is required to reproduce this for us is just:
        grpc::ServerBuilder builder;
        builder.RegisterService(&_camera_service);
        _server = builder.BuildAndStart();

        _server->Shutdown();

We also tried manually adding the completion queue, however, we wouldn't use it as we're using the sync server.
What did you expect to see?
I would expect it to destruct cleanly.
What did you see instead?
D0512 11:38:33.906357565  871511 ev_posix.cc:174]            Using polling engine: epollex
D0512 11:38:33.906902208  871511 dns_resolver_ares.cc:490]   Using ares dns resolver
I0512 11:38:33.907143809  871511 server_builder.cc:332]      Synchronous server. Num CQs: 1, Min pollers: 1, Max Pollers: 2, CQ timeout (msec): 10000
=================================================================
==871511==ERROR: AddressSanitizer: attempting free on address which was not malloc()-ed: 0x7fff3240fe48 in thread T0
    #0 0x7f65e7301960 in operator delete(void*) /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cc:165
    #1 0x55bbcea5691d in __gnu_cxx::new_allocator<std::_List_node<grpc_impl::Server const*> >::deallocate(std::_List_node<grpc_impl::Server const*>*, unsigned long) /usr/include/c++/9.3.0/ext/new_allocator.h:128
    #2 0x55bbcea3fc85 in std::allocator_traits<std::allocator<std::_List_node<grpc_impl::Server const*> > >::deallocate(std::allocator<std::_List_node<grpc_impl::Server const*> >&, std::_List_node<grpc_impl::Server const*>*, unsigned long) /usr/include/c++/9.3.0/bits/alloc_traits.h:470
    #3 0x55bbcea122c9 in std::__cxx11::_List_base<grpc_impl::Server const*, std::allocator<grpc_impl::Server const*> >::_M_put_node(std::_List_node<grpc_impl::Server const*>*) /usr/include/c++/9.3.0/bits/stl_list.h:442
    #4 0x55bbce9d8fde in std::__cxx11::_List_base<grpc_impl::Server const*, std::allocator<grpc_impl::Server const*> >::_M_clear() /usr/include/c++/9.3.0/bits/list.tcc:81
    #5 0x55bbce993e67 in std::__cxx11::_List_base<grpc_impl::Server const*, std::allocator<grpc_impl::Server const*> >::~_List_base() /usr/include/c++/9.3.0/bits/stl_list.h:495
    #6 0x55bbce93df6d in std::__cxx11::list<grpc_impl::Server const*, std::allocator<grpc_impl::Server const*> >::~list() /usr/include/c++/9.3.0/bits/stl_list.h:823
    #7 0x55bbce93e3bd in grpc_impl::CompletionQueue::~CompletionQueue() /home/julianoes/src/MAVSDK/build/asan/third_party/install/include/grpcpp/impl/codegen/completion_queue_impl.h:118
    #8 0x7f65dfa36cab in grpc_impl::Server::ShutdownInternal(gpr_timespec) /home/julianoes/src/MAVSDK/build/asan/third_party/grpc/grpc/src/grpc/src/cpp/server/server_cc.cc:1303
    #9 0x55bbcec1d21d in grpc::ServerInterface::Shutdown() /home/julianoes/src/MAVSDK/build/asan/third_party/install/include/grpcpp/impl/codegen/server_interface.h:115
    #10 0x7f65dfa34ec3 in grpc_impl::Server::~Server() /home/julianoes/src/MAVSDK/build/asan/third_party/grpc/grpc/src/grpc/src/cpp/server/server_cc.cc:1044
    #11 0x7f65dfa351f3 in grpc_impl::Server::~Server() /home/julianoes/src/MAVSDK/build/asan/third_party/grpc/grpc/src/grpc/src/cpp/server/server_cc.cc:1065
    #12 0x55bbce9e978a in std::default_delete<grpc_impl::Server>::operator()(grpc_impl::Server*) const /usr/include/c++/9.3.0/bits/unique_ptr.h:81
    #13 0x55bbce9a667b in std::unique_ptr<grpc_impl::Server, std::default_delete<grpc_impl::Server> >::~unique_ptr() /usr/include/c++/9.3.0/bits/unique_ptr.h:292
    #14 0x55bbce887f32 in ~CameraServiceImplTest /home/julianoes/src/MAVSDK/src/backend/test/camera_service_impl_test.cpp:48
    #15 0x55bbce913395 in ~CameraServiceImplTest_takesPhotoEvenWhenArgsAreNull_Test /home/julianoes/src/MAVSDK/src/backend/test/camera_service_impl_test.cpp:172
    #16 0x55bbce9133e3 in ~CameraServiceImplTest_takesPhotoEvenWhenArgsAreNull_Test /home/julianoes/src/MAVSDK/src/backend/test/camera_service_impl_test.cpp:172
    #17 0x7f65d855a73d in testing::Test::DeleteSelf_() /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/include/gtest/gtest.h:489
    #18 0x7f65d85ab847 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/src/gtest.cc:2593
    #19 0x7f65d85883db in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/src/gtest.cc:2629
    #20 0x7f65d84dbb9a in testing::TestInfo::Run() /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/src/gtest.cc:2851
    #21 0x7f65d84dee65 in testing::TestSuite::Run() /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/src/gtest.cc:2977
    #22 0x7f65d8519d63 in testing::internal::UnitTestImpl::RunAllTests() /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/src/gtest.cc:5518
    #23 0x7f65d85b1df7 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/src/gtest.cc:2593
    #24 0x7f65d858de8f in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/src/gtest.cc:2629
    #25 0x7f65d850d57b in testing::UnitTest::Run() /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/src/gtest.cc:5105
    #26 0x55bbce8863ed in RUN_ALL_TESTS() /home/julianoes/src/MAVSDK/src/third_party/gtest/googletest/include/gtest/gtest.h:2472
    #27 0x55bbce8861f3 in main /home/julianoes/src/MAVSDK/src/backend/test/backend_main.cpp:6
    #28 0x7f65d741d022 in __libc_start_main (/usr/lib/libc.so.6+0x27022)
    #29 0x55bbce78d78d in _start (/home/julianoes/src/MAVSDK/build/asan/src/backend/test/unit_tests_backend+0x1c8978d)

Address 0x7fff3240fe48 is located in stack of thread T0
SUMMARY: AddressSanitizer: bad-free /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cc:165 in operator delete(void*)
==871511==ABORTING

Valgrind output:
==843827==
==843827== HEAP SUMMARY:
==843827==     in use at exit: 149,764 bytes in 916 blocks
==843827==   total heap usage: 21,005 allocs, 20,089 frees, 1,827,615 bytes allocated
==843827==
==843827== 8 bytes in 1 blocks are possibly lost in loss record 22 of 81
==843827==    at 0x4839DEF: operator new(unsigned long) (vg_replace_malloc.c:344)
==843827==    by 0x60CE213: absl::lts_2020_02_25::memory_internal::MakeUniqueResult<grpc_core::(anonymous namespace)::ClientSecurityHandshakerFactory>::scalar absl::lts_2020_02_25::make_unique<grpc_core::(anonymous namespace)::ClientSecurityHandshakerFactory>() (memory.h:170)
==843827==    by 0x60CDE1F: grpc_core::SecurityRegisterHandshakerFactories() (security_handshaker.cc:562)
==843827==    by 0x60407B0: grpc_security_init() (init_secure.cc:82)
==843827==    by 0x5FE9387: grpc_init (init.cc:149)
==843827==    by 0x59AD13A: grpc::internal::GrpcLibrary::init() (grpc_library.h:34)
==843827==    by 0x5996F94: grpc::GrpcLibraryCodegen::GrpcLibraryCodegen(bool) (grpc_library.h:45)
==843827==    by 0x599734B: grpc_impl::CompletionQueue::CompletionQueue(grpc_completion_queue_attributes const&) (completion_queue_impl.h:247)
==843827==    by 0x5997552: grpc_impl::ServerCompletionQueue::ServerCompletionQueue(grpc_cq_completion_type, grpc_cq_polling_type, grpc_experimental_completion_queue_functor*) (completion_queue_impl.h:445)
==843827==    by 0x5996118: grpc_impl::ServerBuilder::BuildAndStart() (server_builder.cc:323)
==843827==    by 0x6431C8: (anonymous namespace)::CameraServiceImplTest::SetUp() (camera_service_impl_test.cpp:59)
==843827==    by 0x6F8A94C: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2593)
==843827==
==843827== 8 bytes in 1 blocks are possibly lost in loss record 23 of 81
==843827==    at 0x4839DEF: operator new(unsigned long) (vg_replace_malloc.c:344)
==843827==    by 0x60CE337: absl::lts_2020_02_25::memory_internal::MakeUniqueResult<grpc_core::(anonymous namespace)::ServerSecurityHandshakerFactory>::scalar absl::lts_2020_02_25::make_unique<grpc_core::(anonymous namespace)::ServerSecurityHandshakerFactory>() (memory.h:170)
==843827==    by 0x60CDE6C: grpc_core::SecurityRegisterHandshakerFactories() (security_handshaker.cc:565)
==843827==    by 0x60407B0: grpc_security_init() (init_secure.cc:82)
==843827==    by 0x5FE9387: grpc_init (init.cc:149)
==843827==    by 0x59AD13A: grpc::internal::GrpcLibrary::init() (grpc_library.h:34)
==843827==    by 0x5996F94: grpc::GrpcLibraryCodegen::GrpcLibraryCodegen(bool) (grpc_library.h:45)
==843827==    by 0x599734B: grpc_impl::CompletionQueue::CompletionQueue(grpc_completion_queue_attributes const&) (completion_queue_impl.h:247)
==843827==    by 0x5997552: grpc_impl::ServerCompletionQueue::ServerCompletionQueue(grpc_cq_completion_type, grpc_cq_polling_type, grpc_experimental_completion_queue_functor*) (completion_queue_impl.h:445)
==843827==    by 0x5996118: grpc_impl::ServerBuilder::BuildAndStart() (server_builder.cc:323)
==843827==    by 0x6431C8: (anonymous namespace)::CameraServiceImplTest::SetUp() (camera_service_impl_test.cpp:59)
==843827==    by 0x6F8A94C: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2593)
==843827==
==843827== 8 bytes in 1 blocks are possibly lost in loss record 24 of 81
==843827==    at 0x4839DEF: operator new(unsigned long) (vg_replace_malloc.c:344)
==843827==    by 0x60D8F6F: absl::lts_2020_02_25::memory_internal::MakeUniqueResult<grpc_core::(anonymous namespace)::HttpConnectHandshakerFactory>::scalar absl::lts_2020_02_25::make_unique<grpc_core::(anonymous namespace)::HttpConnectHandshakerFactory>() (memory.h:170)
==843827==    by 0x60D8DF1: grpc_http_connect_register_handshaker_factory() (http_connect_handshaker.cc:388)
==843827==    by 0x60D4337: grpc_client_channel_init() (client_channel_plugin.cc:57)
==843827==    by 0x5FE93CE: grpc_init (init.cc:152)
==843827==    by 0x59AD13A: grpc::internal::GrpcLibrary::init() (grpc_library.h:34)
==843827==    by 0x5996F94: grpc::GrpcLibraryCodegen::GrpcLibraryCodegen(bool) (grpc_library.h:45)
==843827==    by 0x599734B: grpc_impl::CompletionQueue::CompletionQueue(grpc_completion_queue_attributes const&) (completion_queue_impl.h:247)
==843827==    by 0x5997552: grpc_impl::ServerCompletionQueue::ServerCompletionQueue(grpc_cq_completion_type, grpc_cq_polling_type, grpc_experimental_completion_queue_functor*) (completion_queue_impl.h:445)
==843827==    by 0x5996118: grpc_impl::ServerBuilder::BuildAndStart() (server_builder.cc:323)
==843827==    by 0x6431C8: (anonymous namespace)::CameraServiceImplTest::SetUp() (camera_service_impl_test.cpp:59)
==843827==    by 0x6F8A94C: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2593)
==843827==
==843827== 71 bytes in 1 blocks are possibly lost in loss record 39 of 81
==843827==    at 0x483977F: malloc (vg_replace_malloc.c:309)
==843827==    by 0x62D66ED: gpr_malloc (alloc.cc:32)
==843827==    by 0x62D6824: gpr_malloc_aligned (alloc.cc:68)
==843827==    by 0x5FF5DD1: grpc_core::HandshakerRegistry::Init() (handshaker_registry.cc:79)
==843827==    by 0x5FE9382: grpc_init (init.cc:148)
==843827==    by 0x59AD13A: grpc::internal::GrpcLibrary::init() (grpc_library.h:34)
==843827==    by 0x5996F94: grpc::GrpcLibraryCodegen::GrpcLibraryCodegen(bool) (grpc_library.h:45)
==843827==    by 0x599734B: grpc_impl::CompletionQueue::CompletionQueue(grpc_completion_queue_attributes const&) (completion_queue_impl.h:247)
==843827==    by 0x5997552: grpc_impl::ServerCompletionQueue::ServerCompletionQueue(grpc_cq_completion_type, grpc_cq_polling_type, grpc_experimental_completion_queue_functor*) (completion_queue_impl.h:445)
==843827==    by 0x5996118: grpc_impl::ServerBuilder::BuildAndStart() (server_builder.cc:323)
==843827==    by 0x6431C8: (anonymous namespace)::CameraServiceImplTest::SetUp() (camera_service_impl_test.cpp:59)
==843827==    by 0x6F8A94C: void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2593)
==843827==
==843827== 320 bytes in 1 blocks are possibly lost in loss record 61 of 81
==843827==    at 0x483BB65: calloc (vg_replace_malloc.c:762)
==843827==    by 0x40133E1: allocate_dtv (in /usr/lib/ld-2.31.so)
==843827==    by 0x4013D51: _dl_allocate_tls (in /usr/lib/ld-2.31.so)
==843827==    by 0x6E5E15E: pthread_create@@GLIBC_2.2.5 (in /usr/lib/libpthread-2.31.so)
==843827==    by 0x62DC0A0: grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&) (thd_posix.cc:109)
==843827==    by 0x62DC2C6: grpc_core::Thread::Thread(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&) (thd_posix.cc:186)
==843827==    by 0x5FFE873: grpc_core::Executor::SetThreading(bool) (executor.cc:165)
==843827==    by 0x5FFE3DA: grpc_core::Executor::Init() (executor.cc:98)
==843827==    by 0x5FFF688: grpc_core::Executor::InitAll() (executor.cc:400)
==843827==    by 0x5FFFFB0: grpc_iomgr_init() (iomgr.cc:60)
==843827==    by 0x5FE9378: grpc_init (init.cc:146)
==843827==    by 0x59AD13A: grpc::internal::GrpcLibrary::init() (grpc_library.h:34)
==843827==
==843827== 320 bytes in 1 blocks are possibly lost in loss record 62 of 81
==843827==    at 0x483BB65: calloc (vg_replace_malloc.c:762)
==843827==    by 0x40133E1: allocate_dtv (in /usr/lib/ld-2.31.so)
==843827==    by 0x4013D51: _dl_allocate_tls (in /usr/lib/ld-2.31.so)
==843827==    by 0x6E5E15E: pthread_create@@GLIBC_2.2.5 (in /usr/lib/libpthread-2.31.so)
==843827==    by 0x62DC0A0: grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&) (thd_posix.cc:109)
==843827==    by 0x62DC2C6: grpc_core::Thread::Thread(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&) (thd_posix.cc:186)
==843827==    by 0x5FFE873: grpc_core::Executor::SetThreading(bool) (executor.cc:165)
==843827==    by 0x5FFE3DA: grpc_core::Executor::Init() (executor.cc:98)
==843827==    by 0x5FFF697: grpc_core::Executor::InitAll() (executor.cc:401)
==843827==    by 0x5FFFFB0: grpc_iomgr_init() (iomgr.cc:60)
==843827==    by 0x5FE9378: grpc_init (init.cc:146)
==843827==    by 0x59AD13A: grpc::internal::GrpcLibrary::init() (grpc_library.h:34)
==843827==
==843827== 320 bytes in 1 blocks are possibly lost in loss record 63 of 81
==843827==    at 0x483BB65: calloc (vg_replace_malloc.c:762)
==843827==    by 0x40133E1: allocate_dtv (in /usr/lib/ld-2.31.so)
==843827==    by 0x4013D51: _dl_allocate_tls (in /usr/lib/ld-2.31.so)
==843827==    by 0x6E5E15E: pthread_create@@GLIBC_2.2.5 (in /usr/lib/libpthread-2.31.so)
==843827==    by 0x62DC0A0: grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&) (thd_posix.cc:109)
==843827==    by 0x62DC2C6: grpc_core::Thread::Thread(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&) (thd_posix.cc:186)
==843827==    by 0x6012CE7: start_timer_thread_and_unlock() (timer_manager.cc:92)
==843827==    by 0x60133C4: start_threads() (timer_manager.cc:293)
==843827==    by 0x6013440: grpc_timer_manager_init() (timer_manager.cc:311)
==843827==    by 0x6000041: grpc_iomgr_start() (iomgr.cc:69)
==843827==    by 0x5FE93ED: grpc_init (init.cc:162)
==843827==    by 0x59AD13A: grpc::internal::GrpcLibrary::init() (grpc_library.h:34)
==843827==
==843827== 320 bytes in 1 blocks are possibly lost in loss record 64 of 81
==843827==    at 0x483BB65: calloc (vg_replace_malloc.c:762)
==843827==    by 0x40133E1: allocate_dtv (in /usr/lib/ld-2.31.so)
==843827==    by 0x4013D51: _dl_allocate_tls (in /usr/lib/ld-2.31.so)
==843827==    by 0x6E5E15E: pthread_create@@GLIBC_2.2.5 (in /usr/lib/libpthread-2.31.so)
==843827==    by 0x62DC0A0: grpc_core::(anonymous namespace)::ThreadInternalsPosix::ThreadInternalsPosix(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&) (thd_posix.cc:109)
==843827==    by 0x62DC2C6: grpc_core::Thread::Thread(char const*, void (*)(void*), void*, bool*, grpc_core::Thread::Options const&) (thd_posix.cc:186)
==843827==    by 0x59C8F64: grpc::ThreadManager::WorkerThread::WorkerThread(grpc::ThreadManager*) (thread_manager.cc:33)
==843827==    by 0x59C97DB: grpc::ThreadManager::Initialize() (thread_manager.cc:143)
==843827==    by 0x59AF0C2: grpc_impl::Server::SyncRequestThreadManager::Start() (server_cc.cc:953)
==843827==    by 0x59A6FE5: grpc_impl::Server::Start(grpc_impl::ServerCompletionQueue**, unsigned long) (server_cc.cc:1273)
==843827==    by 0x5996A63: grpc_impl::ServerBuilder::BuildAndStart() (server_builder.cc:424)
==843827==    by 0x6431C8: (anonymous namespace)::CameraServiceImplTest::SetUp() (camera_service_impl_test.cpp:59)
==843827==
==843827== LEAK SUMMARY:
==843827==    definitely lost: 0 bytes in 0 blocks
==843827==    indirectly lost: 0 bytes in 0 blocks
==843827==      possibly lost: 1,375 bytes in 8 blocks
==843827==    still reachable: 148,389 bytes in 908 blocks
==843827==         suppressed: 0 bytes in 0 blocks
==843827== Reachable blocks (those to which a pointer was found) are not shown.
==843827== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==843827==
==843827== For lists of detected and suppressed errors, rerun with: -s
==843827== ERROR SUMMARY: 8 errors from 8 contexts (suppressed: 0 from 0)

FYI @JonasVautherin

Maybe related to #21813?

@stanley-cheung Why do you think this is related to #21813?  I don't see anything in the stack trace or leak report that would suggest anything about that PR.

Looking at this now - I have no idea why I made that comment. They don't seem to be related at all. This must have been a mistake - sorry about that!

I am also facing same problem. Any solution yet?

I remember that I tried to fix this by #22960. I'm closing this but please feel free to reopen this if it doesn't fix this.

I am getting same issue but with different code. Service executes correctly but this error comes at time of returning the status. Issue described at: https://stackoverflow.com/questions/63789313/grpc-c-addresssanitizer-bad-free

@rhthaakkar Thanks for your report and I left my answer on the post. The error message from ASAN doesn't look right to me because it claimed attempting free on address which was not malloc()-ed but stacktraces for allocation and destruction in the log are using C++ new and delete.


List of Donation Sites on the main donation sites page should be alphabetized

should probably alphabetize other dataset outputs too

Fixed!
dropoff_location, diaper_drive_participant, and partner all sort alphabetically. There's spec coverage for each.


JGRP-2782 - TP: new global config VERSION_CHECK_MICRO should consider Jgroups as incompatible if Micro Version differs

https://issues.redhat.com/browse/JGRP-2782
Some whitespace was changed too, sorry. Didn't know how to stop my IDE form doing this.

Thanks Vygen! Applied and committed; welcome as a new JGroups dev! :-)

Perhaps for next time: the commit message is useless, SCM best practices tell us to keep formatting changes separate from functional changes, the whitespace around e.g. assignment are inconsistent, some if conditions use block some don't :-D

Also, some acronyms :

{{pp}}: pretty print
{{ns}}: nothing special


Update should not force VS Code to restart or it should be configurable

We have written the needed data into your clipboard because it was too large to send. Please paste.
Issue Type: Bug
When the version of VS Code changes/updates, it restarts VS Code.
This can be from annoying to having consquences.
For instance it means that the terminals are closed but the processes (e.g. servers) still run. Meaning they need to be restartet.
What I like to see is either a setting where I can control, when what is updated
OR
a notification, that gives me the choice to update.
But I want to control when my IDE shuts down, restarts or is running.
 When VS Code applies an update it tells you about it and waits for your approval to restart VS Code.
Isn't this what you see?

No. It appears to "randomly" restart and it shows the release notes right after.

I need to guess, but around once or twice every 2 or 3 weeks at least.
I installed it using Ubuntu Software, but that is a while back.

As I mentioned above, Code won't ever shut itself down without your approval, so it might be something in Ubuntu or the Snap store doing that. I suggest following up with them.

I'am afraid it is not that simple. Today, I was performing an interactive rebase:

$ git rebase -i HEAD~2 <-- opens VS Code as it is my default editor.
Did a squash using GitLens interactive editor,
VS Code switches to the classic 'Vim like' interface, I want to edit the commit message,
VS Code Updates, closes the editor without asking for permission. Changes are  'Successfully rebased and updated refs/heads/main'.

No harm done (I just had to correct the message), but it seems like a very dangerous bug (or feature?). I am using Windows 10, so it is definitely not an Ubuntu issue.

VS Code Updates, closes the editor without asking for permission. Changes are  'Successfully rebased and updated refs/heads/main'.

This is very odd. It definitely should not close automatically. I also can't really reproduce. 😕


added parameters to allow override of install location of chocolatey

This will allow a site to control where the module looks for the chocolatey.server install.  It should be used by those sites that install chocolatey packages in different controlled location.

Thanks!

Rob,
My last pull had an error. Sorry about that.  I've corrected it and submitted a new pull.  Thanks for accepting the change.
Sent from my iPhone

On Feb 5, 2016, at 10:12 AM, Rob Reynolds<EMAIL_ADDRESS>wrote:
Thanks!
—
Reply to this email directly or view it on GitHub.


Recommended solution for integrating dark theme with jekyll-gist?

Hello, I've been experimenting with the minima dark theme, and the one pain point that I've hit is that I'm using the jekyll-gist plugin, and the styles look somewhat broken in conjunction with the theme. I raised this with jekyll-gist originally, and it was considered out-of-scope for the project, which seems reasonable:

I'm new to jekyll and just kicking the tires while I choose a blogging platform, so excuse me if there's an obvious solution here. Any thoughts on this?

Hello @eriknelson
The dark skin is part of unreleased changes of this theme. Since you're just starting out with Jekyll, I'd recommend using a released version and acquaint yourselves with the process involved in customizing a Jekyll theme.
Once you get the hang of the workflow and are comfortable with editing Sass partials, you may try and use the unreleased version of Minima and customize it.
Coming back to the issue at hand, the master version of the theme has the provision to easily inject custom style rules for your site. If you were to open your browser's inspect tool, you'll be able to find out what HTML markup and their associated styles are used to render a gist on the page. You can then customize the styles as per your taste by placing the style overrides in _sass/minima/custom-styles.scss.

@ashmaroli Any ideas on an ETA for another release?


Re: Embedding subtitles ends in ERROR: Conversion failed!

Regarding an investigation I did that is related to a previously reported issue (#21929):
Consider these two youtube-dl calls:
A: youtube-dl -v -i -f "22/136+bestaudio[ext=m4a]/bestvideo[height<=720]+bestaudio[ext=m4a]/best[height<=720]" --all-subs --embed-subs --merge-output-format mkv -o A.mkv "https://www.youtube.com/watch?v=oGVhOWqsBWM"
B: youtube-dl -v -i -f "bestvideo+bestaudio" --all-subs --embed-subs --merge-output-format mkv -o B.mkv "https://www.youtube.com/watch?v=oGVhOWqsBWM"
They only differ in their -f parameter and their -o filename (A.mkv vs B.mkv).
A ends up with:
[download] Destination: A.mkv
[download] 100% of 46.87MiB in 00:00
[ffmpeg] Embedding subtitles in 'A.mkv'
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i file:A.mkv -i file:A.ko.vtt -i file:A.tr.vtt -i file:A.hr.vtt -i file:A.sr.vtt -i file:A.pt.vtt -i file:A.en.vtt -i file:A.vi.vtt -i file:A.fr.vtt -i file:A.ar.vtt -i file:A.es.vtt -map 0 -c copy -map -0:s -map -0:d -c:s mov_text -map 1:0 -metadata:s:s:0 language=kor -map 2:0 -metadata:s:s:1 language=tur -map 3:0 -metadata:s:s:2 language=hrv -map 4:0 -metadata:s:s:3 language=srp -map 5:0 -metadata:s:s:4 language=por -map 6:0 -metadata:s:s:5 language=eng -map 7:0 -metadata:s:s:6 language=vie -map 8:0 -metadata:s:s:7 language=fra -map 9:0 -metadata:s:s:8 language=ara -map 10:0 -metadata:s:s:9 language=spa file:A.temp.mkv
ERROR: Conversion failed!

while B completes without errors:
[download] Destination: B.mkv.f251
[download] 100% of 6.92MiB in 00:00
[ffmpeg] Merging formats into "B.mkv"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i file:B.mkv.f137 -i file:B.mkv.f251 -c copy -map 0:v:0 -map 1:a:0 file:B.temp.mkv
Deleting original file B.mkv.f137 (pass -k to keep)
Deleting original file B.mkv.f251 (pass -k to keep)
[ffmpeg] Embedding subtitles in 'B.mkv'
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i file:B.mkv -i file:B.en.vtt -i file:B.fr.vtt -i file:B.tr.vtt -i file:B.hr.vtt -i file:B.ko.vtt -i file:B.sr.vtt -i file:B.vi.vtt -i file:B.pt.vtt -i file:B.ar.vtt -i file:B.es.vtt -map 0 -c copy -map -0:s -map -0:d -map 1:0 -metadata:s:s:0 language=eng -map 2:0 -metadata:s:s:1 language=fra -map 3:0 -metadata:s:s:2 language=tur -map 4:0 -metadata:s:s:3 language=hrv -map 5:0 -metadata:s:s:4 language=kor -map 6:0 -metadata:s:s:5 language=srp -map 7:0 -metadata:s:s:6 language=vie -map 8:0 -metadata:s:s:7 language=por -map 9:0 -metadata:s:s:8 language=ara -map 10:0 -metadata:s:s:9 language=spa file:B.temp.mkv
Deleting original file B.en.vtt (pass -k to keep)
Deleting original file B.fr.vtt (pass -k to keep)
Deleting original file B.tr.vtt (pass -k to keep)
Deleting original file B.hr.vtt (pass -k to keep)
Deleting original file B.ko.vtt (pass -k to keep)
Deleting original file B.sr.vtt (pass -k to keep)
Deleting original file B.vi.vtt (pass -k to keep)
Deleting original file B.pt.vtt (pass -k to keep)
Deleting original file B.ar.vtt (pass -k to keep)
Deleting original file B.es.vtt (pass -k to keep)

Comparing the respective ffmpeg calls from A (first line) and B (second line):
ffmpeg -y -loglevel repeat+info -i file:A.mkv -i file:A.ko.vtt -i file:A.tr.vtt -i file:A.hr.vtt -i file:A.sr.vtt -i file:A.pt.vtt -i file:A.en.vtt -i file:A.vi.vtt -i file:A.fr.vtt -i file:A.ar.vtt -i file:A.es.vtt -map 0 -c copy -map -0:s -map -0:d -c:s mov_text -map 1:0 -metadata:s:s:0 language=kor -map 2:0 -metadata:s:s:1 language=tur -map 3:0 -metadata:s:s:2 language=hrv -map 4:0 -metadata:s:s:3 language=srp -map 5:0 -metadata:s:s:4 language=por -map 6:0 -metadata:s:s:5 language=eng -map 7:0 -metadata:s:s:6 language=vie -map 8:0 -metadata:s:s:7 language=fra -map 9:0 -metadata:s:s:8 language=ara -map 10:0 -metadata:s:s:9 language=spa file:A.temp.mkv
ffmpeg -y -loglevel repeat+info -i file:B.mkv -i file:B.en.vtt -i file:B.fr.vtt -i file:B.tr.vtt -i file:B.hr.vtt -i file:B.ko.vtt -i file:B.sr.vtt -i file:B.vi.vtt -i file:B.pt.vtt -i file:B.ar.vtt -i file:B.es.vtt -map 0 -c copy -map -0:s -map -0:d -map 1:0 -metadata:s:s:0 language=eng -map 2:0 -metadata:s:s:1 language=fra -map 3:0 -metadata:s:s:2 language=tur -map 4:0 -metadata:s:s:3 language=hrv -map 5:0 -metadata:s:s:4 language=kor -map 6:0 -metadata:s:s:5 language=srp -map 7:0 -metadata:s:s:6 language=vie -map 8:0 -metadata:s:s:7 language=por -map 9:0 -metadata:s:s:8 language=ara -map 10:0 -metadata:s:s:9 language=spa file:B.temp.mkv

The only difference between these two merge-calls to ffmpeg is that A adds an extra -c:s mov_text.
Question
Is this a bug or an oversight? If not, what is the explanation for youtube-dl specifying a subtitle format that is incompatible with mkv when --merge-output-format mkv is explicitly specified?
Is the subtitle codec chosen based on -f? Why, wouldn't it make more sense to have it chosen based on what the target file container supports?

Once again: do not hardcode the extension in output template. Output template is the template of the file to be downloaded not the target file. Extension of A is mp4 not mkv therefore -c:s mov_text. Hardcoding custom extension in output template will not involve remuxing or recoding of the actual format to that custom extension.

@dstftw I see, it was unclear to me, that there was this distinction.
The name "merge output format", to me at least, implied that it specifies the format of the merge output (files being merged into mkv -> merge output format = mkv) and not the format of the download container (pre-merge). I assumed it would simply stream-copy the video and audio data from whatever it downloaded into a newly created merge output container as specified by the user instead of it just being a command line option to "override" the automatic detection (which, to me, seems silly in the first place; care to give a quick example where this would be useful?)
Maybe it'd be wise to rename the option to avoid future confusion?

--merge-output-format is only used when there is something to merge, it has no effect for individual files, read FAQ already.

I am sorry, I was mentally blind. I read the FAQ entry multiple times but I seem to have missed the correct meaning of "if a merge is required". It's obvious now in hindsight.


(WIP) Lint code via flake8 GH Actions workflow

Checklist
GitHub

[ ] I've given this PR a concise, self-descriptive, and meaningful title
[ ] I've linked relevant issues in the PR body
[ ] I've applied the relevant labels to this PR
[ ] I've assigned a reviewer

PR contents

[ ] I've consulted SCT's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[ ] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

Linked issues

Fixes #1538.

Hrm. flake8-your-pr uses annotations (rather than PR comments), which is nice, but it ran across the entire file I tested (rather than just the changed lines).

This could be good or bad depending on how we want to scope PRs. i.e. it could coerce us into fixing existing linting errors, but maybe that's not something we want to do.

Because the GH actions bot requested changes, I'm going to open a new PR so I can demo this action as annotations-only.

Because the github actions bot requested changes, and because I want to preserve my experimentation, I'm going to open a fresh PR to cleanly demonstrate this GH Actions workflow.


Uninstall option

Hi Paul,
Thx for your great work. Is there anything like an uninstall option on your "roadmap" :)
Just so we have a clean way back.
Michael

great idea - I will work on that and see what I can do.


Frontend changes for new async execution

Pull Request Description

Frontend counterpart to https://github.com/enso-org/cloud-v2/pull/656

MUST NOT be merged before that PR is merged.

Closes https://github.com/enso-org/cloud-v2/issues/718

Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

fixed merge conflicts, but there will still be quite a number of issues as this hasn't yet been tested against the backend - for example testing how they interact with drag (both projects, and their executed children)

closed, pending review of the design i guess


Updating to work with Cypress v7.x

Hi:
We are currently beholden to Cypress v6.9.1 and cannot upgrade to the latest v7.x because of the following.
When running node v14.15.4, an error message is produced by cypress-real-events stating the following (in Node v12.21, this is a warning, not an error message):
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>|| ^5.x || ^6.x" from<EMAIL_ADDRESS>npm ERR! node_modules/cypress-real-events
npm ERR!   dev<EMAIL_ADDRESS>from the root project

I haven't taken a look at cypress-real-events code to see why this version threshold exists; is there a reason why? Then, based off of that answer, what would it take to become compatible with Cypress v.7.x?
Thanks!

I think this is just outdated dependencies list. I will try to fix this and publish new version today

Sweet! Thanks.

In the mean time for anyone wanting to bypass this issue:
# Install the dependencies without peerDependencies version mismatch errors
npm install -D --force
# Once the package-lock has been generated you should not have the error anymore
npm install -D
# or
npm ci

are there updates regarding this issue?

Released in 1.4.0


Grafana dashboard for this exporter

Create a Grafana dashboard and include it with the exporter.
If anyone has a Grafana dashboard make it available on grafana.org and send it to @stuartnelson3 .

Hello everyone! Check the JSON model below for Grafana dashboard
Passenger Monitoring-1708342986149.json


[CWS] check hash resolver rate limit earlier in the hashing process

What does this PR do?
This PR ensures we check the hash rate limiter before attempting to open the file. This ensure that the overhead of the stat/open operation is under control.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


ExportDOM in Debug Tree View

https://user-images.githubusercontent.com/7893468/231305891-19835d70-b54d-4833-b73b-552a8f1f5326.mp4
I've been meaning to add this for ages - the ability to toggle between node view and an exportDOM view, in order to validate if the a node's exportDOM definition is correct, since the DevTools show the createDOM output, besides manually printing exportDOM inside node methods, there is no intuitive way to check if the exportDOM properties are set correctly during development.
Happy to hear suggestions for improvement.

I've been meaning to add this for ages - the ability to toggle between node view and an exportDOM view, in order to validate if the a node's exportDOM definition is correct, since the DevTools show the createDOM output, besides manually printing exportDOM inside node methods, there is no intuitive way to check if the exportDOM properties are set correctly during development.
Happy to hear suggestions for improvement.

Add me as a friend bro. :) nice informasjon.  I try to se if I  can figuure it out

LGTM. Nit, should the header show when the tree is larger than 1k nodes?
Also, you may want to know that we're rethinking to retake the extension project as the TreeView has grown out of control. Not only it's big now but we've also got some additional debugging features in mind that it will be hard to fit into this UI in a compact manner.

Thanks @zurfyx , Yep, should disappear, will fix it. I've noticed quite a few things I can improve in my PR, in terms of propagating variables.
On the extension part, that's excellent news. I've always thought the debug should be a separate extension, similar to the one React and Redux have and have the TreeView outside of the core package.

Its been aproved
Have a great day everybody
ons. 12. apr. 2023, 14:42 skrev Gerard Rovira @.***>:

@.**** approved this pull request.
LGTM. Nit, should the header show when the tree is larger than 1k nodes?
Also, you may want to know that we're rethinking to retake the extension
project as the TreeView has grown out of control. Not only it's big now but
we've also got some additional debugging features in mind that it will be
hard to fit into this UI in a compact manner.
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/lexical/pull/4307#pullrequestreview-1381231187,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A42IFULUKWS7AOBB2N65H5DXA2PJVANCNFSM6AAAAAAW24EKJ4
.
You are receiving this because you commented.Message ID:
@.***>

@acywatson @zurfyx updated the PR to not render the button if the nodes count > 1k. Also changed the variable propagation a bit, here:
https://github.com/facebook/lexical/pull/4307/files#diff-fbd7c10fc2ea36767e9a70524ac63cdecb54b08c0936782358fc252399a9f33aL381-L385
since I was passing the editor as the last parameter anyway, are you happy with this change - consolidating all the variables to just editor. Happy to change it back, doesn't affect the useEffect variables, so should make no performance difference rerendering-wise, I believe.

@acywatson @zurfyx updated the PR to not render the button if the nodes count > 1k. Also changed the variable propagation a bit, here: https://github.com/facebook/lexical/pull/4307/files#diff-fbd7c10fc2ea36767e9a70524ac63cdecb54b08c0936782358fc252399a9f33aL381-L385 since I was passing the editor as the last parameter anyway, are you happy with this change - consolidating all the variables to just editor. Happy to change it back, doesn't affect the useEffect variables, so should make no performance difference rerendering-wise, I believe.

Thank you, LGTM!


fix: Add logLaraData option [PT-184770212]

This allows the check for the callback to succeed so the log message is sent in the CFM interactiveApiProvider.

Deleting to clean up my old lingering PRs.


Allow stdin to be a closed fd

Before this change, the following invocation would not work
$ http http://neverhttps.com <&-

The "<&-" at the end closes the stdin fd. Specifically, it would fail with
  ...
  File "/home/mgsloan/.local/lib/python3.6/site-packages/httpie/context.py", line 26, in Environment
    stdin_isatty = stdin.isatty()
AttributeError: 'NoneType' object has no attribute 'isatty'

This can occur when httpie is being programmatically invoked, and may
as well be supported.

Thank you!


[Bug] Fix the missing data of the menu and add the sql that removes t…

…he admin role in the upgraded 1.2.4.sql #1794

What problem does this PR solve?
Issue Number: close #1794
Problem Summary: Fix the missing data of the menu
What is changed and how it works?
Proposal: https://github.com/apache/incubator-streampark/issues/1794
Feel free to ping committers for the review!
Contribution Checklist

Make sure that the pull request corresponds to a GITHUB issue.

Name the pull request in the form "[Feature] [component] Title of the pull request", where Feature can be replaced by Hotfix, Bug, etc.

Minor fixes should be named following this pattern: [hotfix] [docs] Fix typo in README.md doc.

Purpose of this pull request
Fix the missing data of the menu. issue-1974

/cc @1996fanrui PTAL


Bug in Algorithm 2

q is a square, so this step does not work:
https://github.com/javad-doliskani/divpoly_pit/blob/98734cc4aff5acd423f0d10277c6f9d0162e0eb5/divpoly_pit.tex#L644-L645

I change q to p. Now p can be a generator and so q will have order (r - 1) / 2.


[release-4.13] OCPBUGS-12616: Bump x/net to v0.7.0

This PR updates x/net/http2 to fix CVE

/jira refresh


Native support for styled.{{tag}}

When trying to use styled.{{tag}} on native, got an error Uninterpreted extension 'raw'
This is because server-reason-react.melange_ppx doesn't recognize the raw extension

That's actually a nice improvement, since it fixes the mel.raw issue but you will face other issues with styled.tag in native (mel.raw, bindings such as createVariadicElement).
I would propose to add a flag on the ppx (styled-ppx.lib --native) and have a different creation of elements given the flag.

I see.. I guess the first step is to add server-reason-react.browser_ppx library to styled-ppx.lib, and set it to add the --js flag when --native flag is not set?

I see.. I guess the first step is to add server-reason-react.browser_ppx library to styled-ppx.lib, and set it to add the --js flag when --native flag is not set?
aah nvm, this should be handled by the user (?) we just need to emit valid native code right?

I felt the build time is quite slow (tried building e2e/melange/native/ui.re and it felt considerably slower than the non native variant with styled.{{tag}}). Can't seem to pin point the slow path.
Is using a lot of ppxlib.metaquot have an impact on build times? It shouldn't affect the build time for the user of the ppx right?

That should have any effect, while building ui (maybe we copy the node_modules by accident?)

That should have any effect, while building ui (maybe we copy the node_modules by accident?)

That doesn't seem to be the case, I tried timing the build command. Just adding the styled.{{tag}} call, cause 2x the build

Maybe the amount of code generated? Can you debug without any prop?

welp, having a dozen of arguments (ReactDOM.domProps) will inevitably effect the build time. nothing we can do about it


[WIP] Azure CI

TBD

closing in favour of https://github.com/neuromation/cookiecutter-neuro-project/pull/350


Fix it -  Arrange paragraph according to need

Put "download" option next to "header" word.

hey @codervivek5 pls assigned me this issue

@codervivek5 assign this to me

@codervivek5 please assign me this issue.

can you please assign me this issue under JWOC?

is this solving the issue?

@codervivek5 , Please assign me this issue , under GSSOC'24.


An initialized binding element should be optional even if its parent is initialized too

function foo({ x, y = {}} = { x: 0, y: {}}) {

}

foo(); // Fine
foo({ x: 0, y: 0 }); // Fine
foo({ x: 0 }); // Error

The last line should not be an error because the y property has a default initializer. The error goes away if I remove the default initializer { x: 0, y: {}} on the parent.
I think the rule would be that even if we get the type of a parameter / variable / binding element from an initializer, we still have to traverse the binding pattern to determine whether binding properties are optional.

Note that you can observe this in another way too. If you remove the y from the parameter initializer, then you get an error on the binding element instead of the call site. But it's really the same issue:
function foo({ x, y = {}} = { x: 0 }) { // Error that { x: number } doesn't have a y property

}

@mhegazy Curious why you removed the bug label?

@JsonFreeman I don't think this is a bug. The order of precedence for determining the type of a variable or parameter is:

Type annotation
Initializer
Type implied by binding pattern (if applicable)

Consider this example:
interface Foo { x: number, y: string }
function f({ x, y = "hello" }: Foo) {
}

It would be odd indeed if the type of f's parameter isn't Foo as specified in the type annotation, but rather { x: number, y?: string } because y is magically made optional. I think the same logic applies to this example:
interface Foo { x: number, y: string }
var foo: Foo = { x: 0, y: "test" };
function f({ x, y = "hello" } = foo) {
}

And, by extension, to this example:
function f({ x, y = "hello" } = { x: 0, y: "test" }) {
}

Furthermore, if a parameter has a type annotation or an initializer it's type shouldn't be impacted by whether the parameter itself is specified as a simple identifier or a binding pattern. The two should be interchangeable with no effect on the type. (Indeed, refactorings and/or the declaration file generator might depend on this invariant.)
That said, we could potentially consider making properties optional in object literals if they are optional in the contextual type (which would apply here). I'm not really sure it's worth it, though.

It's funny. Reading your three examples, I actually think the first one should just be Foo, as you say. But in the second and third, y feels like it should be optional. The way I am thinking of it, a type annotation is a firm indication of the type. But an initializer, while it does specify the types of the binding elements, it doesn't tell you the whole story about optionality. I feel like it's not as strong an indicator of the type. And so when there is an intializer, but no type annotation, I feel like we do want to keep descending into the binding pattern to "optionalize" the elements that have their own initializers.

Furthermore, if a parameter has a type annotation or an initializer, it's type shouldn't be impacted by whether the parameter itself is specified as a simple identifier or a binding pattern.

Again, for a type annotation, I agree. For an initializer, I agree only if you converted the identifier to a binding pattern without adding initializers inside.
As a side note, converting an identifier to a binding pattern may indeed affect the type because of tuples:
(x = [0, 1, 2]) => { } // Array type
([x, y, z] = [0, 1, 2]) => { } // Tuple type

The order of precedence for determining the type of a variable or parameter is:

Type annotation

Initializer
Type implied by binding pattern (if applicable)

@ahejlsberg Is that actually the case? In the following example, param is contextually typed as a string, and the local variable x has the type (s: string) => number.
var { x = (str: string) => +str } = { x: param => param.length };

But if we used the initializer first, wouldn't we acquire the type of x from the type of x from the RHS of the top-level initializer?

I feel like it's not as strong an indicator of the type.

Yes, I see what @JsonFreeman is saying - it would be kind of ideal if the properties "zipped up" with respect to optionality when determining assignability. I can definitely get behind a very simple rule, but I get that there's also something to be said about flexibility here.

@DanielRosenwasser the contextual typing you are talking about is that the RHS gets contextually typed by the type implied by the binding pattern. However, the final type of x is determined by the outer initializer (which got contextually typed using the inner initializer).
@ahejlsberg We could just do the contextual typing rule for optional properties like you mentioned. It would only work when the initializer is a literal though.

@JsonFreeman Fix now available in #4598.