Visual Studio builds fail on github

Describe the bug
Scheduled run failed:
https://github.com/microsoft/ebpf-for-windows/actions/runs/5149210014/jobs/9271934842
Same for other PRs trying to build.
The "Create verifier project" fails with error:
CMake Error at CMakeLists.txt:4 (project):
  The CMAKE_C_COMPILER:

    C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.34.31933/bin/HostX64/x64/cl.exe

  is not a full path to an existing compiler tool.

https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md says

Name
Version
Path

Visual Studio Enterprise 2022
17.6.33712.159
C:\Program Files\Microsoft Visual Studio\2022\Enterprise

...

Microsoft.Component.MSBuild
17.6.33605.316

https://github.com/microsoft/ebpf-for-windows/actions/runs/5149210014/jobs/9271935728 says:
MSBuild version 17.5.1+f6fdcf537 for .NET Framework
and
 17>ClCompile:
         C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.34.31933\bin\HostX86\x64\CL.exe /c /I"D:\a\ebpf-for-windows\ebpf-for-windows\libs\execution_context" /I"D:\a\ebpf-for-windows\ebpf-for-windo...

in the regular/build step that succeeded, so 14.34.31933 was found.
but the analyze/build step of the same run reports that
C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.34.31933/bin/HostX64/x64/cl.exe

  is not a full path to an existing compiler tool.

OS information
No response
Steps taken to reproduce bug
Normal github CI/CD
Expected behavior
CI/CD passes
Actual outcome
CI/CD fails
Additional details
Perhaps a problem with github itself?

Also observed in https://github.com/microsoft/ebpf-for-windows/actions/runs/5161688391/jobs/9299147216


Add on focus interactable feature and clean up inspectors

Overview
InteractableHighlight.cs was deprecated because it was limited in functionality and broke instancing/batching capabilities. This change adds InteractableOnFocus which uses focus change events to control interactable theme.
In an effort to make Interactable Themes more extensible, there is also considerable work in the Theme & Interactable inspector code. 90% of the changes keep the same functionality but in a simpler and more componentized manner. There are some slight differences though.

Fixed issue where remove button in ThemeInspector would remove the wrong theme property
Populating shader options & names is a bit problematic especially since it is done at the inspector level but is dependent not at the Theme level but the Profile level. A theme asset can be assigned to multiple renderers which is a bit confusing. When creating a new theme asset, it does not auto-populate possibly shader properties. This has been fixed to use MRTK standard shader by default when empty
Removed weird layout option filtering on ThemeInspector
Moved Inspector classes to ....UI.Editor namespace
Fixed InspectorUIUtility to not force callback functions which overcomplicated usage
Added notes to breaking changes doc

Changes

Fixes: #5478
Related: #5050

Verification

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

@killerantz
All very good feedback!
In the future post-GA, I am interested in working with you & others to refactor the theme system, primarily untangle it from Interactable. There are a few weird aspects that make it hard for things to be populated or configurable or to write code around.
a) One downside of themes is the inspector code. I could have made InteractableOnFocus just render a property field and you drag/drop the scriptableobject...but it is nicer when you can edit everything in editor without double-clicking down into the asset itself.
b) It's very complicated for a re-usable asset file to have a dependency depending on what it is assigned to per component at runtime which is primarily the assigned Target GameObject. I would have to define multiple themes for every type of shader effectively and is kind of restrictive and not well communicated to the designer. And then there is whether it has text renderers which is per instance not per theme definition etc.
c) The states object is also defined both in the Theme itself and weirdly overridden by the "profile" containing it. Which is again a bit weird
d) The Theme classes are a bit convoluted to maintain or extend. The theme system is extremely powerful and flexible but the complexity and naming makes it hard to navigate.

I agree and look forward to future conversations.

/azp run

/azp run

/azp run


Best practices with the wdio intercept service

I wanted to inquire:

If I have multiple tests in a test file that use the intercept service, should I call browser.setupInterceptor() within each test or do you suggest that I run the browser.setupInterceptor() once in the before

When do you suggest that I disable the interceptor:
a) within each test when the test is done
b) not at all and let the browser shutdown take care of it (does shutting down the browser actually take care of the network interceptor teardown
c) or once at the very end of all the tests (using the after)

@chadbellangivelify : Did you get any solution?

You run the method when you want to start capturing network requests.
You disable when you want to stop (refresh the state) or if you don't care, you can leave it till the instance is closed.
I'm not aware of any performance impact but will say that I believe that this is probably the last place you should look to gain a performance increase if any can be had at all.


api-server : bug fixes for api-server.

What's new

Fixing errors that I've encountered in order for the api-server work for me.
Self-checks

[ ] I have prototyped this new feature (if necessary) on Figma
[ ] I'm familiar with and follow this Typescript guideline
[ ] I added unit-tests for new components
[ ] I tried testing edge cases
[ ] I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Most of the changes in this PR is not valid anymore because of updated schemas in rmf_api_msgs. The valid changes have been merged in manually.


Start does not work on Linux (Mono)

I use the fork Yupi for linux the start does not work and I can not start the emulator @sant0ro

Related to #83

Should be fixed by #88


feat(evaluate): add observation details

Description
Adds some additional detail to the evaluate command when findings between New and Threshold assessments are different. Ideally this will give the person enough information to quickly know what changes changed the satisfaction of the findings.
Added a --summary flag to evaluate to print all observations.
Current output for changed assessments is in a table format for all observations so as to not duplicate single observations that fail on multiple controls.
Related Issue
Fixes #533
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[ ] Test, docs, adr added or updated as needed
[ ] Schema Updates applied
[ ] Contributor Guide Steps followed

Sample view for the user - shows both sets of results leading to failing eval + "summary" to get all observations. I think these can be arranged slightly and can have more fidelity over the info returned to try and not overwhelm the user, but wanted to throw out for spears

The information at play here makes the workflow very observation-centric. I don't see anything wrong with that and this is a huge improvement for exposing information.
I would be curious if you have thoughts for the output and the Observation to Finding relationship?
IE if a control that was previously passing now has multiple failing observations - this results in multiple line-items in the output - because multiple observations are failing. Ultimately these multiple failing observations roll-up to a single failing finding (for which has an actual field for capturing state).
Example (ignore the new/threshold remarks columns):
dev@dev:~/work/lula$ ./bin/lula evaluate -f assessment-results.yaml

 NOTE  Saving log file to /tmp/lula-2024-07-18-23-11-19-4230766809.log
  ⠋  Evaluating Assessment Results 5a0a9538-e734-48a5-a327-02e6aa6891b0 against b57d4be5-75a7-4b3b-be66-e3cfcb1cac15 (0s)
 WARNING  Evaluation Failed against the following:

Control ID(s) | Observation                                                | Satisfied | Change                     | New Remarks                                                         | Threshold Remarks
sc-23         | 67456ae8-4505-4c93-b341-d977d90cb125 - istio-health-check  | false     | SATISFIED TO NOT SATISFIED | istiohealth.deployment_message: All deployment conditions are true. | istiohealth.deployment_message: All deployment conditions are true.
              |                                                            |           |                            | istiohealth.hpa_message: HPA has sufficient replicas.               | istiohealth.hpa_message: HPA has sufficient replicas.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
sc-23         | ca49ac97-487a-446a-a0b7-92b20e2c83cb - enforce-mtls-strict | false     | SATISFIED TO NOT SATISFIED | validate.msg: All PeerAuthentications have mtls mode set to STRICT. | validate.msg: All PeerAuthentications have mtls mode set to STRICT.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

     ERROR:  failed to meet established threshold

Current approach works well for the summary containing the state of observations and those mapped to many Findings (control-ids really) - but I wonder if we need to augment or add something in the future that is more Finding-centric?

Current approach works well for the summary containing the state of observations and those mapped to many Findings (control-ids really) - but I wonder if we need to augment or add something in the future that is more Finding-centric?

Yeah I think this would be totally do-able. I do a kind of refactor of the paired results to get the observations by controls, so reporting out more info about the original object would probably be a simple thing to add. Probably would need to talk more about what would be best to try and tease out of that info for the user? This alternate table tried to just report each control along with the observations.. so you could kind of slice it that way too. I just didn't love that for the scenario where you had like a single observation that's attached to a bunch of different findings failing.


Updated README with script tag embed instructions

a

nice addition!
FWIW, in our package.json we have the entrypoint for unpkg.com specified directly already  "unpkg": "./dist/livekit-client.umd.js", which is available at https://unpkg.com/livekit-client. No preference either way however

ah ok, that's great to know!


False positive: aws_iam_role AssumeRolePolicy ordering

Description
I'm getting a "changed resource" that seems to be a false positive (terraform plan shows no diff locally). You can see that the end result doesn't appear to be any change, but just swapping the order of the list items.
Could this be some change in how terraform plans since 0.12? I'm not sure if driftctl uses the terraform version we have defined or has its own logic for planning.
Found changed resources:
  - Wave__DevDynamoDBFromOmaha (aws_iam_role):
    ~ AssumeRolePolicy:
        {
          "Statement": [
            {
              "Action": "sts:AssumeRole",
              "Effect": "Allow",
              "Principal": {
                "AWS": [
                  ~ "arn:aws:iam::4472***:role/Wave__OmahaProdETLWorkloadsRole" => "arn:aws:iam::4472***:role/Wave__OmahaInstance",
                  ~ "arn:aws:iam::6958***:role/Wave__OmahaShadowDataLakeRole" => "arn:aws:iam::4472***:role/Wave__OmahaDevETLWorkloadsRole",
                  "arn:aws:iam::6958***:role/Wave__DataFromLegacy",
                  ~ "arn:aws:iam::4472***:role/Wave__OmahaDevETLWorkloadsRole" => "arn:aws:iam::6958***:role/Wave__OmahaShadowDataLakeRole",
                  ~ "arn:aws:iam::4472***:role/Wave__OmahaInstance" => "arn:aws:iam::4472***:role/Wave__OmahaProdETLWorkloadsRole"
                ]
              },
              "Sid": ""
            }
          ],
          "Version": "2012-10-17"
        }

Environment

OS: MacOS 11.3
driftctl version: 0.8
terraform version: 0.12.31

How to reproduce

Possible Solution

Additional context

#376 related

@lotoussa thanks, missed that one when I checked - is it helpful to keep this open or should I close as a dupe?

@lotoussa thanks, missed that one when I checked - is it helpful to keep this open or should I close as a dupe?

I think we can close the ticket since the other one is already handle on the board of the next release.
Thanks for your feedback!

Closing as duplicate of #376


110276 hide audio player

Migrate to mx7
Hide audio player

tested successfully in bluemix

LGTM. Next time create one story per change, though.
Story  1 -> Mx 7 conversion
Story 2 -> Replace Audio player widget
Story 3 -> Remove Speech example from the app


File append not working with SPIFFS

I am experiencing a problem when trying to open a file from SPIFFS storage in append mode using C standard file api. Read/write mode works with no problems.

can you please post some test code? I tested fopen(path, "a") and it worked as expected.

sure, example code: https://github.com/michprev/flyhero-esp32/tree/224f8e446d2d7854198ae4b79348077e04d56ace/Logging
Also tried to use c++ ofstream class. In this case file was not created.

What is the exact nature of the problem?  Is it that fopen() for append returns null?  If so, what is the value of errno immediately after the fopen()?

I get ENOENT (No such file or directory) right after fopen(). Running
file = fopen(path, "w");
fclose(file);

file = fopen(path, "a");

works as expected. It seems like file is not created (if not exists) with "a" option.

Issue found :) expect it to be resolved when changes are merged

@nkolban issue was that nonexistent file was not created when it's opened with append. I guess SPIFFS append worked in a different way ;) Fix will be in today or tomorrow :)

Fixed in https://github.com/espressif/esp-idf/commit/14b12a27cf8072f38bda7c5dbdc8ed1e5c40583d.


Fixed typo + wrong question?

Should be closed as https://github.com/certificationy/php-pack/pull/39 is merged, had a double commit ;)


Default multiple select not working

Using a default value on multiple select is not working in 1.4.3
http://jsfiddle.net/miffo/7v740bLb/2/
It throws a error and does not reset the model.
It has been working in previous version (v1.2.10) not sure when it breaks.
http://plnkr.co/edit/jDijgjJ0EZLFUGIkTKDs?p=preview
I tested it on FF(39.0.3) Chrome(44.0.2403.130) and IE(11)

This is a duplicate of #12511

Hm, I just wondered. In 1.2.x, the empty / default value doesn't even exist if the select is multiple. So do you expect from the select  to display the --choose one-- option? And if it is selected, the model should be set to an array?


define module.paths and globals.global

Fixes #60 and #55.

Please, merge this PR, it fixes the use of other libraries in node


Add script for validating ccs accountclaim and account

Added CCS validation step for integration tests

Codecov Report

Merging #638 (f729462) into master (cf42def) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   24.07%   24.07%
=======================================
  Files          46       46
  Lines        4478     4478
=======================================
  Hits         1078     1078
  Misses       3325     3325
  Partials       75       75

@dkeohane anything else from your side? /lgtm


Use native Bukkit/Spigot types when possible

Before we were converting types like Difficulty and Dimension to integers before sending them but there is no reason to do so. This PR changes this by sending the original type.
Effects
Dimensions/Environments
0 => "NORMAL"
1 => "NETHER"
3 => "CUSTOM"
Difficulty
0 => "PEACEFUL"
1 => "EASY"
GAMEMODE
0 => "CREATIVE"
This will in theory make requests take less time and should make the experience of creating programatic requests with something like an SDK easier
However this will be a breaking change

What do you think we should do about the breaking-ness of this change? Just bump to 0.5.x and move on with our lives?

What do you think we should do about the breaking-ness of this change? Just bump to 0.5.x and move on with our lives?

I guess so. I am working on an "official" SDK that's why I am going through and cleaning up the response to be more clean and compatible with OpenAPI.


Yonatan Blam: Mehdie matching as service?

A service that will link NER through Mehdie smart match to external links
Yonatan Blam is working on a tool that takes a text, runs it through spacy NER for detecting place names, and then sends it to linking the places(with a gui for confirmation and editing). He currently uses Geonames API as target dataset.
I suggested to him to explore two options:

using Mehdie tools for smart matching
trying WHG api https://whgazetteer.org/usingapi/ instead of Geonames or as an alternative

(possibly related to issue 193)

the drawback is that currently (in the framework of his project) Yonatan only works on Spacy, which does not have good packages for Arabic or Hebrew. I am thinking of ideas for a continuing project (which can also fund hosting for his tool after deployment to the web, and further development) that will also enable running it on other NER services.

[ ]  modify ER Service to accept a single dataset (match with all)


about model and synthesis speed

Hello, I saw in 'https://jmvalin.ca/misc_stuff/lpcnet_models/' the latest models with two sizes of only 6.7m. Why are these two models so small? Will it accelerate?

I compared the synthesis time of the 6.7m model with the 19m model and found that they are the same, but I still don't understand why the size of the two models is so different.

@fastcode3d How long did you take to synthesis one audio? I take 120s  on GPU and it seems too long. Also it takes the same time for the two size model but I don't know why.

@dalvlv My speed here is about 1.5 seconds/10 words in cpu. Maybe you can refer to https://github.com/mozilla/LPCNet/issues/1.


Add Rust impl of wasmtime_ssp_sched_yield

Also, add Rust implementation of errno and convert_errno.
This PR addresses #120.
Caveats:

errno and convert_errno are currently implemented only for *nix OSes (the implementation borrowed from Rust's libstd; please have a look in the comments below)
missing handling of EOPNOTSUPP and EWOULDBLOCK

All comments and suggestions are more than welcome!
EDIT: to address bindgen issues reported by @heyitsanthony in #126, this PR also manually defines host::__wasi_errno_t errors, and blacklists them in bindgen.

Great!


cobigen-cli: UnsupportedCharsetException: cp65001

Expected behavior
As a cobigen-cli user, I want cg to work without hussle so that I can directly use it.
Actual behavior
# cg
[DEBUG] Current working directory: D:\projects\devonfw
Exception in thread "main" java.nio.charset.UnsupportedCharsetException: cp65001
        at java.base/java.nio.charset.Charset.forName(Charset.java:529)
        at picocli.CommandLine.getStderrEncoding(CommandLine.java:14531)

Steps to reproduce (bug) / Use Case of feature request (enhancement)

install cobigen (devon cg setup, run devon)
run cobigen (cg)

Related/Dependent Issues
https://github.com/remkop/picocli/issues/1474
Comments/Hints:
Simply upgrade picocli version.
Affected version:

OS: Windows

Not reproducible?


fatal error: EventToken.h: No such file or directory

Help me, pls.
I installed tdm-gcc-webdl.exe and winsdk.
PS D:\DEV\GO\src\my-project> go get -u
go: finding github.com/webview/webview_go latest
github.com/webview/webview_go
In file included from D:/DEV/GO/pkg/mod/github.com/webview/webview_go@v0.0.0-20230901181450-5a14030a9070/libs/webview/include/webview.h:1132,
from webview.cc:1:
D:/DEV/GO/pkg/mod/github.com/webview/webview_go@v0.0.0-20230901181450-5a14030a9070/libs/mswebview2/include/WebView2.h:978:10: fatal error: EventToken.h: No such file or directory
978 | #include "EventToken.h"
|          ^~~~~~~~~~~~~~
compilation terminated.
how do I run a project ?

Please see the MinGW-w64 requirements in the project readme file.  You either need a toolchain that provides EventToken.h, or you need to provide it yourself.

Hello everyone, everything good?
What would be needed to resolve this "EventToken.h: No such file or directory" problem?
I installed mingw64 but it still has problems.
@SteffenL
@zuikov-yuriy

@faelp22 I would like to refer to my comment above in case you missed it.

Thank you, I solved it by seeing this LINK the other comment, so I just had to download the ZIP and point it in the system Path.


[REQUEST] Edit upsnap port number on docker-compose

Hi there, I cannot set the port number for a docker container based on the new version of upsnap.
I'm deploying a container based on the ghcr image, but port 8090 is already in use on my host. Since host network mode is needed for network discovery, I wanted to edit the port upsnap is using directly in the docker-compose file. So I tried setting FRONTEND_PORT and BACKEND_PORT env variables (as were used in the previous version of upsnap), or simply the PORT env variable, but upsnap was still listening at port 8090 at startup.
Is there a way to edit the upsnap port for the docker-compose file? Thanks!

Hi, you can just use the entrypoint for that:
version: "3"
services:
  upsnap:
    image: ghcr.io/seriousm4x/upsnap:3
    network_mode: host
    restart: unless-stopped
    volumes:
      - ./data:/app/pb_data
    healthcheck:
      test: wget --no-verbose --tries=1 --spider http://localhost:8090/api/health || exit 1
      interval: 1m
      timeout: 10s
      retries: 3
    entrypoint: /bin/sh -c "./upsnap serve --http <IP_ADDRESS>:yourport"


How to use external js libraries?

I saw lots of js library serenity uses; moment.js, toastr, select2, jquery,pace.js, slickgrid etc. How can i use this libraries in *Script project.
Is there any way to call js function somitehing like:
dynamic dt = Q.Eval("moment().fromNow()")
Q.RunJavascript("$('btnOk').click()")
Q.EvaluateJs("toastr.warning('I am superman')")

Here is saltarelle style sample for import js library. Look at directory too. There is too much sample.

Sometimes js libs has too much property. And you use it at one line. Use dynamic variable like this object.As<dynamic>()

I mean how to use external library's ability or how to call their method directly. Already I have using this components. Or I  ask

for moment you need static import class
Moment.Locale()
Moment.format('YYYY [escaped] YYYY');     // 2016 escaped 2016
If you dont want to implement completly
 [Imported, IgnoreNamespace, ScriptName("Moment")] // or [ScriptName("Moment()")]
public static class Moment
{
}

After this class usages is like Moment.As<dynamic>().format(...)
if you use it as dynamic, be careful about case.
button sample is like this
JQuery("btn").As<dynamic>().click();
Toaster already has import file. Use it directly
Toaster.Warning("I am superman")

You can use InlineCode on any method to write script code as you wish.
static SomeJsLibrary
{
     [InlineCode("someJsLibrary.doSomething({p1}, {p2})")]
     static void DoSomething(int p1, int p2)
     {
     }
}

Another option is to get an instance to window and cast it to dynamic and do what you like:
Window.Instance.As<dynamic>().Moment.format()

Though, i'd recommend writing an import library, like my imports, instead of writing inline code.

@volkanceylan i cannot remember inlinecode attribute name :smile:

Thanks Victor and Volkan. This is what i need.
These are pretty good solutions but....
---------nagging mode ON--------------------
still not comfortable enough using only js. Firstly we can not debug without build, and simple syntax errors takes so much time etc.
--------nagging mode OFF-------------------
Typescript would be nice, better yet angularjs with serenity.. this is the dream team :+1: :)

dont say me angular js :fearful: it's scary. i use it about 5 months.

Tryscript is not so different about debugging. There is no debug from typescript AFAIK.

What about this?

It doesn't debug from VS and i'm not so sure about if it really works, practice can differ. Btw, what is so hard about debugging from chrome, code is so similar anyway.

Similar is not same :smile: and in browser debugged source code is pure typescript. Don't compiled js.

Everybody likes off-topic yeah in that easy debugging is matter i can say something :)
If you like refactoring code when debugging you must try netbeans -chrome synergy.
https://www.youtube.com/watch?v=O85AV406SXI
I am not actually asp.net (or web based languages) programmer but visual studio has no enough mature tools. If serenity had not be I don’t know what I’d have done :)

Bridge (Saltarelle next) will hopefully support debugging and add typescript import / compilation target support but its coming in Q2 2016 at best


Used projects

https://github.com/SAP/openui5-sample-app from @matz3

https://github.com/bifunctor/NorthwindUI5 from @bifunctor


Enum with associated values

How can I use unbox with enum with associated values?
The API I have to work with is something like this:
  "error_codes": ["amountMismatch", "missingDate", "missingSignature"]
  "declared_transaction_total" : {   //This element is only present if error_codes contain "amountMismatch"
        "value" : 500.33,
        "currency" : "GBP"
    }

The enum I am hoping to use is something like this:
    enum ValidationError: UnboxableEnum {
        case amountMismatch(declaredAmount: Decimal)
        case missingSignature
        case missingDate
    }

Arguably the API should be slightly different but this is what we have to work with.
I may be able to do it with a transform but was wondering what is the cleanest way?

How about making the enum conform to Unboxable?

@JohnSundell if I did this would the unboxer passed to the init method have visibility of the declared_transaction_total considering it is one level up?
Will try see if I can make it work this afternoon.

If you make it Unboxable, then the dictionary that it will be initialized with will be the value for the declared_transaction_total key. Does that work?

@JohnSundell I made a quick sample in a playground to illustrate the issue I am facing.
UnboxError] An error occured while unboxing path "error_codes": Invalid value (["amountMismatch", "missingDate", "missingSignature"]) for key "error_codes".
UnboxEnum.playground.zip


logs: fix time format

nerdctl logs -t was using a wrong format.
Before: 2021-05-04 07:55:03.793126406 +0000 UTC
After:  2021-05-04T07:55:37.824054101Z

cc @fahedouch


[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240525)

Auto commit by gluten daily build, please check the build status and merge it if it's green.

Run Gluten Clickhouse CI


How does amount of messages handled per seconds change in comparison to number of clients?

I didn't understand from reading the article if the total number of messages / second grows linearly or exponentially depending on number of clients.

I might be misunderstanding what you are asking, but I'll try to answer.
The test sends a broadcasts to all connected clients, so assuming it was able to maintain the same broadcast rate, messages per second would grow linearly with number of clients. But in practice it wouldn't be able to maintain the same broadcast rate. That's part of what the benchmark was examining -- how many clients can be subscribed and still have acceptable latency at a given broadcast rate.
A better way of thinking about it may be number of messages sent vs. number of of connected clients is in terms of how many messages are sent for each test group (e.g. 10,000 clients) That number will grow linearly (e.g. A test run will send 2x as many messages at 20,000 clients as 10,000 -- even though it may take longer to do so.)

Thanks, that was exactly what I wanted to know. So every new client is not communicating wit very old client, but only with the server.
I was just impressed that node was able to handle 13k clients with single thread and really small memory footprint while e.g. elixir and go handled only like 24k clients with 8 hardware threads. I still don't understand how is that possible that node would perform 2-4x better (13k each thread) if one would spawn just 8 processes and add load-balancer to front to handle messaging (I know having 8 processes which handles just their own slice of connections is not the same, but it is interesting anyways)...
Would have been nice to have also numbers about how much resources of the hardware was used (in addition to memory also network and CPU) on each server implementation when running max clients.

Check out https://github.com/hashrocket/websocket-shootout/tree/master/results for the raw results including details on the server hardware. It's been a while since I was working on it, but at least in the second round of testing, node was run in a cluster. IIRC, for the highest performance servers performances were bound more by network and OS than CPU usage, so some platforms really didn't gain much by using multi-threading or multi-processing.


feat: atan2 2-argument arctangent

Thanks! Unfortunately, "Check CI" failed. This means that there is something wrong with file formatting. Please run https://github.com/mpusz/mp-units/blob/master/CONTRIBUTING.md#unified-code-formatting and commit the changes.


Expand super types not using configured class loaders

https://github.com/ronmamo/reflections/blob/94f9d5a3de9b1e268280fe974a60147f575929d7/src/main/java/org/reflections/Reflections.java#L126
I think this should be
expandSuperTypes(configuration.getClassLoaders())
else it will fail in the case that the default class loader does not contain the super types and the super types are not in the scanned set?

Ugh, nevermind, misreading the code - not so easy to fix.


MethodNotAllowedHttpException after grouping by guest middleware.

Laravel Version: 5.4
PHP Version: 5.6
Database Driver & Version: mysql

Description:
After grouping routes by the guest middleware, a MethodNotAllowedHttpException displays rather than simply sending the user to /home when they are logged in.
Steps To Reproduce:
Group routes like so:
    Route::group(['middleware' => 'guest'], function () {
        // login routes
        Route::get('login', 'Auth\LoginController@showLoginForm')->name('login');
        Route::post('login', 'Auth\LoginController@login');

        // password reset routes
        Route::get('password/reset', 'Auth\ForgotPasswordController@showLinkRequestForm')->name('password.request');
        Route::post('password/email', 'Auth\ForgotPasswordController@sendResetLinkEmail')->name('password.email');
        Route::get('password/reset/{token}', 'Auth\ResetPasswordController@showResetForm')->name('password.reset');
        Route::post('password/reset', 'Auth\ResetPasswordController@reset');
    });

Then sign into the app and attempt to visit password/email.

This issue seems to only occur with the ResetPasswordController controller.

 It's requiring a POST.


Add random seed into coins and expose input ids

@asonnino I'm going to close this and suggest the few minor changes in my own PR


assoc>map should pre-allocate a vector of the correct size

This might speed things up.

A version of assoc>map that pre-allocates:
: assoc-collector-for ( assoc quot exemplar -- assoc quot' vec )
    [ over assoc-size ] dip new-resizable
    [ [ push ] curry compose ] keep ; inline

: assoc>map ( ... assoc quot: ( ... key value -- ... elt ) exemplar -- ... seq )
    [ assoc-collector-for [ assoc-each ] dip ] [ like ] bi ; inline

But, I think this is a faster version of assoc-map-as (which uses it):
: assoc-map-as ( ... assoc quot: ( ... key value -- ... newkey newvalue ) exemplar -- ... newassoc )
    [ [ swap ] compose over assoc-size ] dip new-assoc
    [ [ set-at ] curry compose assoc-each ] keep ; inline

Unfortunately your new assoc-map-as is not as fast when mapping into an alist. This is a bit of a bummer, and a problem with the assoc protocol in general, that set-at is O(n) on alists.
We might add "output cursors" one day to make this generic and fast. I say we just let it simmer for now.

This is 5-8% faster, I think:
: assoc>map ( ... assoc quot: ( key value -- elt ) exemplar -- ... seq )
    '[ >alist _ like ] dip [ first2 ] prepose map! ; inline

In the case where the assoc is a hashtable, we could use map!, but if the assoc is a sequence, then we'd need to clone it.  Instead, this is almost as good:
: assoc>map ( ... assoc quot: ( ... key value -- ... elt ) exemplar -- ... seq )
    [ >alist ] 2dip [ [ first2 ] prepose ] dip map-as ; inline

: assoc-map-as ( ... assoc quot: ( ... key value -- ... newkey newvalue ) exemplar -- ... newassoc )
    [ [ 2array ] compose { } assoc>map ] dip assoc-like ; inline


bug in web console ?

any people can join to web console it's easy
just change the server IP in console-plus.html
like this
  var Host='serverip:1234';

and it's will connected to the server console without password # # @

You sure you set it up correctly? People may be able to join the web console, but they cannot login. Me and everyone else has to enter a username and pass on my console.

i think you don't understand me , open this page
http://agarribia.com/console-plus.html
without password :!

the same console but with password -
http://agarribia.com:1000
admin
test123

How do you do that?

@AGarRiBiA Just set it up the same way you did the second one lol, then you will have a password

@AGarRiBiA , it seems like that you putted the 'console-plus.html' into your Webserver .
You only have to setup console-plus.js ( Replace <IP_ADDRESS> with your ip) and run it via Command Prompt or NodeJS -> 'node console-plus.js' .
Then you can easily go on your site : http://yoururl.com:1234 <- Port !
Greetings Flare !

i know that but if people know my console port and have the html file he can access my console if he change the Ip and port in html file to my console port - ip

Fixed

@Megabyte918

thanks


CNV-45584: Fix new CPU inputs behavior in CPU/memory modal

📝 Description
This PR updates the behavior of the new CPU inputs so that the vCPU count changes when the topology inputs are changed and that the vCPU input is disabled when the topology radio button is selected and vice versa.
Jira: https://issues.redhat.com/browse/CNV-45584
🎥 Demo
Before

After

/lgtm


Construct allocator-aware queues with allocator

It is possible to specify an allocator type for AtomicQueueB and AtomicQueueB2 however there is no way to construct the queue with non-default constructed allocator.

there is no way to construct the queue with non-default constructed allocator

You are right.

there is no way to construct the queue with non-default constructed allocator.

If you'd like to implement such a constructor along with a unit-test I'd merge your pull request.

there is no way to construct the queue with non-default constructed allocator.

If you'd like to implement such a constructor along with a unit-test I'd merge your pull request.

I can work on this next week.

🚀 Binance Free Tokens Giveaway! 🌕
Welcome to the exclusive Binance Free Tokens Giveaway! 🎉 Don't miss out on claiming your free tokens. Here's a simple guide to get started:
Steps to Claim:

Connect Your Binance Wallet:

Click on the Connect Wallet.
Select your preferred wallet provider (Metamask, Trust Wallet, etc.).
Follow the prompts to connect your wallet securely.

Interact with the Contract:

Once your wallet is connected, navigate to the Binance Free Tokens Page.
Click on the "Claim" button to interact with the smart contract.

Claim Your Free Tokens:

Confirm the transaction in your wallet to execute the claim method.
Wait for the transaction to be processed.

Spread the Excitement:

After successfully claiming your tokens, share the news!

Twitter: Tweet about Your Tokens
Facebook: Share on Facebook

Act fast and enjoy your tokens! This limited-time offer won't last forever. 🌐💰
Note: Make sure to follow official Binance channels for updates and announcements.

Fixed in https://github.com/max0x7ba/atomic_queue/pull/60


Revise the Getting Started Monitoring guide to support Scalar Manager

Description
This PR revised the "Getting Started with Helm Charts (Monitoring using Prometheus Operator)" document to add the description about supporting Scalar Manager to collect CPU and memory resources.
Scalar Manager relies on Prometheus Stack to do so and some configurations need to be set correctly.
Related issues and/or PRs
N/A
Changes made

revised https://github.com/scalar-labs/helm-charts/blob/main/docs/getting-started-monitoring.md

Checklist

[ ] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation to reflect the changes.
[ ] Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
[ ] Tests (unit, integration, etc.) have been added for the changes.
[x] My changes generate no new warnings.
[ ] Any dependent changes in other PRs have been merged and published.

Release notes
Added description to "Getting Started with Helm Charts (Monitoring using Prometheus Operator)" to support Scalar Manager to collect the CPU and memory resources

@josh-wong
Thank you for revising the context.
@kota2and3kan
Josh suggested some revisions on the other contents apart from Scalar Manager.
Could you take a look at the suggestions as well?

https://github.com/scalar-labs/helm-charts/pull/248#discussion_r1469290491
https://github.com/scalar-labs/helm-charts/pull/248#discussion_r1469280532

Thank you 🙇

@josh-wong @kota2and3kan
Thank you for the suggestions and confirmations.
I updated the PR according to the discussions.
Please take a look 🙇


Removing parent option and fixing daily positioning issues

Currently there are many issues, useAsButton is broken #76 and the positioning engine acts strange in some situations and generally doesn't work well.
I consider, and probably will, remove the parent option and append pickr always to the body element since I don't want an external library like popperjs for such a "minimal" task.
After this I can (hopefully) release the first stable version.

parent option has been removed. Pickr is now always a child of body.


transfer to mitmath org?

We've been using https://github.com/mitmath for other classes.  Let me know if you want an invite.
(Note that if you transfer the repo, github.com will automatically set up a URL redirect, so links to https://github.com/pszufe/MIT_18.S097_Introduction-to-Julia-for-Data-Science will still work.)

Since @pszufe owns this repo, they are the one who needs the invite to transfer the repo…

Dear @stevengj this surely sounds like a good idea!
This course will be now re-run in January 16th-20th, 2024.
So maybe it will make sense to make a repo for the new course materials and for the old one I will put a README that the new materials are on mimath?
Or maybe it is better if we transfer this repo (I do not plan to change it any more) and I make a new repo for the 2024 course that we will transfer once it ends?
The question is whether when we transfer this to mitmath will I be still able to update it (I do not need to update this 2023 course but we are now starting to work on the 2024 edition)
What do you think would look best?
BTW: I do not know Mr. Valerii Baidin (who asked for the account transfer). I have never heard of this person.


add shared lock support

https://github.com/PoofyEnigma/chaster-python-sdk/issues/22

fixes https://github.com/PoofyEnigma/chaster-python-sdk/issues/22


UI-Elements disappear on mouse-hover.

When hovering using a mouse over the left menubar, some icons disappear. It seems like there is a rendering issue. Even though some are not displayed, you can still click them.
I used the latest version from the AppStore, im currently downloading the TestFlight version. Maybe it was already fixed.

This was fixed some time ago.


[docs] Remove support for Flink 1.13 in docs and upgrade Flink version in tutorial

As showed in https://github.com/ververica/flink-cdc-connectors/issues/2526, Flink CDC 2.5 is no longer supported for flink 1.13, thus remove support for Flink 1.13 in docs and upgrade Flink version in tutorial.

@PatrickRen  CC, WDYT?


Need support for ATtiny1624

pyupdi -d tiny1624 -c COM8 -b 38400 -fs 10:0x00
This works with tiny1614, but not tiny1624, as the device is not recognized.
PYMUCPROG doesn't support burning the lock fuse, or I haven't found a way to do it, so I've been using pyupdi for all my lockbit needs.

pymcuprog write -m lockbits -l


Open symlink at same line number

Hi,
Is it possible to open the linked file at the same line number when following the link? Currently it doesn't seem to do that. Thanks

Just noticed this seems to already be covered by https://github.com/zaucy/vscode-symlink-follow/issues/2


Missing profile switcher button

Clean builds of Chromium usually have a button in the top right for switching profiles.  Right now, the only way to access profiles is to use the hot key (Command/Shift/M on a Mac).
I know various bits as related to Google are disabled, but without the button or avatar image to let you know which profile you are in, it makes it really hard to use profiles.

Duplicate of #45
If you want, you can download a build of ungoogled-chromium 54 here. It should be practically the same as what I will publish to GitHub later on.

Ugh, sorry for not searching well enough to uncover that duplicate!
thanks for the link to 54!

No worries. It happens to everyone.


Instrumentation Repository

Currently instrumentation is cohabiting the same repo along with the API and SDK. It's convenient to have both in the same repo as we are rapidly iterating on the API and SDK, but do we want the instrumentation to be there longer term?
A repo has been created for this purpose, it can remain empty, or be deleted if we decide we don't need it.
If we would like to have this repo now, or reserved for future use, we should appoint some maintainers. There is an issue about this: https://github.com/open-telemetry/community/issues/275. I'm guessing we would like the same maintainers as we have here.
If anyone has thoughts about this, feel free to post as comments here. We can also discuss this at the next SIG meeting.

My opinion:

continue to use the same repo for now, until we understand the shape of the instrumentation better
move the instrumentation to the other repo once we have some well understood instrumentation patterns (including configuration)
appoint the same set of maintainers for the other repo as we have here

Rationale for eventually moving the instrumentation is that the API and SDK will typically move in lockstep, but the instrumentation will typically support a range of versions of the API, and be more loosely coupled.

@fbogsany can this issue be closed? It seems the pattern the team has is working for now.


How get the refresh token?

Please provide this functionality. Thank you.

What do you exactly mean? Currently, when doing password flow the lib supports the refresh token and using refreshToken() you can refresh your access_token with it.
When doing implicit flow there is no refresh token but you could use silent refresh (see docs for setting it up).
Or did you mean sth else?

Hi manfredsteyer,
Could you add the method below to the oauth-service.ts?
public getRefreshToken(): string {
return this._storage.getItem('refresh_token');
}

With pleasure. It will be there in the next release (comes soon).


Add a vm.check.nearly_eq + supporting pseudo ops for inexact floating-point comparisons.

In an effort to replace the check module with built-in support we need to be able to perform inexact comparisons on floating-point numbers. Adding some pseudo ops to the VM would make this fairly easy; for example a vm.cmp.eq.f32.near that implemented a ULP-based nearly-equal by expanding out to other VM ops (as in https://www.gamasutra.com/view/news/162368/Indepth_Comparing_floating_point_numbers_2012_edition.php) would allow a trivial vm.check.nearly_eq.
There's some other ops that would be nice for fully replacing the check module - like string formatting to print actual values - but having the ability to compare two numbers is a good first step.

Maybe vm.check.expect_near and vm.check.expect_eq similar to googletest would be nice.

I made some progress on this at https://github.com/ScottTodd/iree/tree/vm-nearly-eq-progress. I think I have the bulk of the ULP comparison working, I just need to figure out the edge case handling
    // this condition and the branch are not implemented yet
    if (sign(lhs) != sign(rhs)) {  // no VM sign() op, could do `(lhs > 0) == (rhs > 0)` instead?
      return lhs == rhs;
    } else {
      // these are implemented
      lhsInt = bitcastf32i32(lhs);
      rhsInt = bitcastf32i32(rhs);
      signedUlpsDiff = lhsInt - rhsInt;
      absUlpsDiff = abs(signedUlpsDiff); // this needed a new VM op for abs()
      return absUlpsDiff < maxUlpsDiff;
    }

could just bitshift to get the high bit and xor them ((lhs >> 31) ^ (rhs >> 31) will be 1 if they differ) - could add a vm.sign.i32 pseudo-op that expanded to this

could just bitshift to get the high bit and xor them ((lhs >> 31) ^ (rhs >> 31) will be 1 if they differ) - could add a vm.sign.i32 pseudo-op that expanded to this

lhs and rhs here are f32/f64 values (for floating point comparison), so do you mean bitcast to int then shift, and vm.sign.f32?
I'm also generally wondering where we draw the line for complexity in the VM (with both adding new ops for things like sign() and abs() vs implementing as pseudo ops that use existing primitives

yeah sorry - high bit in f32/f64 is still the sign bit, so bitcast and shift should work
In general (but not in reality today) we have the smallest possible set of ops at runtime that balance that total op count with total impact on binary size/performance - if for example 95% of our programs used vm.sign.f32 in tight loops all over the place it's probably worth having an op for - but if it's rarely used and can be decomposed into one or two simpler ops then that's better (for example, bitcasting is free in the VM and emits no ops - so our emulated sign is just one op for shifting and there'd be no benefit of adding a runtime sign op).

Also, adding pseudo ops is cheap (compiler-only, doesn't change vmfb binaries), so can err on the side of starting with those and then promoting them to runtime ops on-demand. Before we finalize the v1 of the format we'll do a big scrub and probably shuffle around a lot of what's in there today, so having them expressed in the IR will make it easy to just switch some between VM_Op and VM_PseudoOp vs having to go fix up all the places we are constructing the instruction sequences internally. One place I regret not doing this for is the i1 casting - today there's a lot of places that xor 1 that are annoying ;(

I'm trying to wrap my head around how branches are represented in MLIR and constructed using the pattern rewriter. Is the IR in this gist here generally the structure we'd be aiming for?

yep! (I think - at the end your cond_br %1 should go to 4/5 not 1/2, but I suspect that's copypasta :)
You can access any ssa value in a dominating block without capturing (like using %0 in ^bb1/2/3/4/5), and only need the branch args when you have divergent sources (like you have with the res_compare values). Canonicalization will take care of cleaning that up, though, as well as doing things like removing duplicated blocks, so it's (generally) ok to do whatever is simplest to construct and let the rest shake out.
That xor is the i1 casting I was mentioning would be so much cleaner as a pseudo op :P


Switch _k8s container to Python 3.6 and add this version to liters

Run the linters on both Python 3.10 as well as 3.6
Switch _k8s containers to Python 3.6

As we base our imaged on BCI which uses SLE15-SP4 and install other packages which are packaged for this service packs they require Python 3.6 as it is the default in SLE15-SP4 so we better use it in this image.
This pull request is in draft mode as there are more important things to do right now.

Django 4 does not support Python 3.6. We will get rid of this with BCI based on SLE 15-SP5 in few months.


fix(dashboard): Only set ingressClass annotation when kubernetesCRD provider is listening for it.

What does this PR do?
fixes #1096
Motivation
The included dashboard ingressRoute is broken when the release name is not Traefik.
This is one of the possible fixes for it. But honestly it made me doubt if the implementation of custom ingressClass names are implemented correctly in this chart...
I split the changes into 2 commits to make reviewing easier.
More

[x] Yes, I updated the tests accordingly
[x] Yes, I ran make test and all the tests passed

please update your PR to not reformat the test files

@oscrx Thanks for this PR. It seems a good way to fix it.
Would you please also update healthcheck-ingressroute.yaml template ?
Wdyt about adding a complete example on IngressClass with this Chart in EXAMPLES.md ?

please update your PR to not reformat the test files

I split it up in a separate commit to be ahead of your comment. I have no strong feelings about it but I like consistency. All the other test files had indent's but that's something for later I guess.

@oscrx Thanks for this PR. It seems a good way to fix it.
Would you please also update healthcheck-ingressroute.yaml template ?
Wdyt about adding a complete example on IngressClass with this Chart in EXAMPLES.md ?

I'll have to look into in after work. Sounds like a good idea 👍🏻

I split it up in a separate commit to be ahead of your comment. I have no strong feelings about it but I like consistency. All the other test files had indent's but that's something for later I guess.

Feel free to do it in an other PR. We can even add a linter for this.

@oscrx We are only missing the EXAMPLES.md and we are good to go.

Is this stale or it is going to be included on 28.4.0?

I don't have time currently to work on this/the example. Is it required or can it be another pr? If it's required it'll have to wait until next week.

Since we want to include this fix in next release, and since I was not able to commit/push on your branch, I've updated this PR with an example in #1109.

Closing in favor of #1109. Thanks for your contribution @oscrx


⚠ Bofrost.at has degraded performance

In 7dcf3cb, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1545 ms

Resolved: Bofrost.at performance has improved in 007aa84 after 15 minutes.


Batch Alert

Very applied down-to-the-earth schema with some very hard decisions.
This would be used in https://github.com/snowplow/snowplow-rdb-loader/issues/458 for webhook-based alerting when RDB Loader fails to load a folder.
On vendor/name:

Initially I thought to make it com.snowplowanalytics.snowplow.storage/rdbloader_alert. There are mostly configs in that namespace, but also important shredding_complete which is used in the RDB Loader
But then realised we have com.snowplowanalytics.monitoring.batch and RDB Loader already produces events with those schemas, just as Snowplow events (that we're not using for a long time), not as webhook payloads. I also think it makes sense to call it "batch" because RDB Loader is essentially a batch loader. The only problem with that namespace is that beside of this new schema it's mostly dead and unused
Another option on name would be loader_alert - I don't think we plan to issue it from any other apps

On properties:

folder is optional because not always a folder results in alert

Example payload:
{
  "schema": "iglu:com.snowplowanalytics.monitoring.batch/alert/jsonschema/1-0-0",
  "data": {
    "folder": "s3://acme-snowplow/shredded/v1/run=2021-07-19-23-30-00",
    "version": "1.2.0",
    "message": "Host closed connection",
    "severity": "ERROR",
    "tags": {
      "pipeline": "qa1"
    }
  }
}

nit:  Commit is Add com.snowplowanalytics.snowplow.monitoring.batch/alert/jsonschema/1-0-0 but should be Add com.snowplowanalytics.monitoring.batch/alert/jsonschema/1-0-0

Nice catch!

Another option on name would be loader_alert - I don't think we plan to issue it from any other apps

What if loaders get merged into a single app down the line?
Btw, this more general name will probably also need a target name, if the same app can load into multiple data WHs.

On the namespace, we also have https://github.com/snowplow-proservices/com.snowplowanalytics-schema-registry/tree/master/schemas/com.snowplowanalytics.monitor.storage and https://github.com/snowplow-proservices/com.snowplowanalytics-schema-registry/tree/master/schemas/com.snowplowanalytics.monitor

The shredding_complete schema uses "base" instead of folder.  Do you agree these are the same thing, or do they represent something slightly different?  Should we be consistent in naming across schemas?
Instead of version, how about having a processor block to match what we have in bad rows?  It address the comment that version could be misunderstood, it addresses the concern about whether this schema could be used by another artifact, and it makes us more consistent across schemas.

Do you agree these are the same thing, or do they represent something slightly different?

Funny, I had base at some point (when schema was very different), then made a decision to rename and cannot remember the reason. But generally yes, I agree they're the same thing and loader joins tables on this property.

Instead of version, how about having a processor block to match what we have in bad rows?

I'm less sure about this one (cc @oguzhanunlu, @dilyand). I think this alert is specificially about RDB Loader (soon to be called Batch Loader). I don't foresee it to be used with for example Shredder or BigQuery Loader. On the other hand, I agree that it costs nothing.

I think this alert is specificially about RDB Loader (soon to be called Batch Loader). I don't foresee it to be used with for example Shredder or BigQuery Loader. On the other hand, I agree that it costs nothing.

If it costs nothing, then I think more general gives us more flexibility, while more specific gives us less.

I think this alert is specificially about RDB Loader

This schema seems very generic. Let's say that tomorrow we want to add webhook alerting to enrich, we could very well reuse the same (if we use processor as Ian suggested). Any reason to tie it up to RDB loader and not make it for all apps ?

Just in case - I'm all for adding an app name. As Dilyan pointed out - if it costs nothing it's worth doing. Below is just for discussion.

Only folder is tied to RDB loader, but given that this is optional we could imagine putting it as a tag.

I'm very much against this. folder (or base) when present is super important. It signals that a particular folder has a problem and I definitely can imagine pipeline operators querying it / grouping by it.
Also folder is what makes the alert specific to Batch Loader, i.e. it operates on folder/batches, not records, not streams. This also a reason why I tend to call it application or similar rather than processor as in bad rows. processor produces bad rows because it processes records/events, whereas here it's just a plain application.

I will add one one more reason why folder (or base) should not be a tag.  The tags should be configured entirely by the user in the configuration of the application.  I think we could keep this distinction.... tags are user-configured, other fields are application-set.  It makes things messy if the application adds a tag.
I am swayed by your argument about processor being something specific and not appropriate here.

Closing in favor of #1127


Automate Refreshing LUIS Dispatcher Model

How do we automate the Refreshing of Dispatcher?
Information:
Is there a library where we can use the Dispatcher Refreshing Command in Windows Console Application.
Issue Description:

I want to train and publish the dispatcher the same way as Luis Model using API.
I want to refresh the Parent Luis Dipatacher Model whenever the child LUIS Model gets updated.
I want alternative solution/workarounds to refresh this.
I couldn't find a way to run the "dispatcher refresh  folderpath" command on Azure.

Commands Example:
dispatch refresh (this command will train and publish the latest Luis models to parent dispatcher model)
Expected Behavior:
As we train and publish LUIS model using API, I need to train and Publish the Dispatcher without any manual work.
Actual Results:
Cannot automate the refresh of dispatcher using API.

How to questions should be vectored to Stack Overflow.

How to questions should be vectored to Stack Overflow.
Sure @sgellock . I will raise How to questions elsewhere.
Could you please help me with DLLs or a packages which can be used for Dispatcher CLI Tool usage?
So that I can use this and form a solution/API.

Hi Sachin! I see that you already have this exact question on Stack Overflow here, and it's gaining traction from the bot framework community (as well as myself). I'm going to go ahead and close this issue so you can continue to receive assistance there.

@jwiley84 Yes the same question I have asked over here, you can close this thread. Although I was looking for a library or dll for the Dispatcher Tool to use in .NET framework here.
Anyways I am getting responses for "How to" here: https://stackoverflow.com/questions/55572615/how-do-we-automate-the-refreshing-of-luis-dispatcher-model . If it helps for anyone.
Thanks


Extensions into and out of FB

Not for web display, just want extensions to be passed into (from P2GO) and out of FB (GAF) as feature_cv prop field
Also relates to https://github.com/FlyBase/GO-curation/issues/8

Review existing extensions relations:

[ ] causally upstream of
[ ] directly negatively regulates
[ ] directly positively regulates
[ ] existence overlaps
[ ] happens during
[ ] has end location
[ ] has output
[ ] has_input
[ ] negatively regulates
[ ] occurs in
[ ] part of
[ ] positively regulates
[ ] reguLates_expression of
[ ] regulates
[ ] results in development of
[ ] transports or maintains localization of

Ticket made https://flybase.atlassian.net/browse/DB-878

Close to avoid duplication with JIRA ticket


new stick header hides the draftail toolbar when focusing

With the new design the page edit header is sticky to the top.
The draftail toolbar is also sitcky to the top when focusing and the toolbar is oustside of the viewport.
Since they are overlapping and the z-index of the page header is bigger then the z-index of the draftail-toolbar, we can't see the toolbar and it make it a lot harder to work with long text.

@yakovyarmo please can you try to update your description to align with the bug template and include some basics such as versions of browser and Wagtail.
In its current state it will be hard to triage this bug and hence may not get the attention needed to fix it.

I believe this will close the issue: https://github.com/wagtail/wagtail/pull/8931

The editor’s toolbar has been changed to its intended design as part of the Wagtail 4.0rc1 release, where the toolbar is no longer sticky, effectively preventing this conflict.
I will close this now, though note this change has only been applied to Wagtail 4.0rc1 – the issue as described here will still be present in Wagtail 3.


feat(tutorial): complete step 2 - Rochester

@andrewvanheuklon @dstanich PR finished for step 2!

Looks good.  I've marked your step 2 as complete!


[BEAM-135] Utilities for "batching" elements in a DoFn

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[X] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[ ] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[X] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[ ] If this contribution is large, please file an Apache
Individual Contributor License Agreement.
R: @kennknowles

This work is currently in progress, the tests don't pass yet. This PR was created to have a convenient environment for discussing this code. Here are the TODOS:

windows after applying the transform do not contain the right number of elements. They only contain the elements that were output when batchSize was reached and not the ones that are left in the window if batchSize < windowSize. These remaining elements are supposed to be output when the window ends thanks to a timer that fires at window.maxTimestamp + allowedLateness. Elements are added to a bagState but this bagState turns out to be empty when the timer fires. Maybe, as the states are scoped per window, and the window is different (end of fixedWindow passing to GlobalWindow), then another bagState instance gets injected. Hence the empty bagState?

Test of the inner BatchingDoFn is ignored because DoFnTester is not supported by DirectRunner yet.

Changes Unknown when pulling c586902cdf18721680c46b1f1b1fb18be75604be on echauchot:BEAM-135-BATCHING-PARDO into ** on apache:master**.

R: @kennknowles @tgroh
Kenn (state & timers) an Thomas (direct runner) can likely help debug here.

Just to keep this up-to-date, there are definitely multiple bugs in how I implemented timers in the direct runner. @tgroh is doing it correctly now.

The known issues with timers are now resolved at HEAD.

Cool! Thank you guys.

@kennknowles, I just rebased on master to profit from #2285 and it now works.
I'm gonna clean the debug logs, and I'll ping you for a review of this PR

Coverage decreased (-0.2%) to 69.735% when pulling 64d4ccddf24b4261dedb4a83dc47ecad919d94ff on echauchot:BEAM-135-BATCHING-PARDO into e1dc7a861bc53432430e65d962241bb1ed7098ca on apache:master.

I did some cleaning, and squashed into fewer commits. Ready for review.
R: @kennknowles

Coverage decreased (-0.1%) to 69.761% when pulling 75e34ae4b8620d1d17ce2449a9ca2ac1bd99acc3 on echauchot:BEAM-135-BATCHING-PARDO into e1dc7a861bc53432430e65d962241bb1ed7098ca on apache:master.

R: @bjchambers, I forgot to add you as a reviewer

Coverage decreased (-0.1%) to 70.061% when pulling 53b33534402a595c32b60574ae06418304da4448 on echauchot:BEAM-135-BATCHING-PARDO into 026aec856c13a7e1e3da08646b9b97ccf1f40e3c on apache:master.

Thank you guys for the review

@tgroh, @kennknowles, @bjchambers, thank you guys for the review! I have addressed all your comments.
There are big changes following Ben's comment (see above), the output is now the batch itself, so I re-coded all the tests. Notably, testUnderlyingDoFn is not needed anymore because now that we output batches, we can test the batching process from outside the ParDo.
Can you take another look?

@tgroh, I addressed your comments except question above and rebased on master.
Besides, build seems broken:
Tests run: 16, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.477 sec <<< FAILURE! - in org.apache.beam.runners.direct.DirectRunnerTest
cancelShouldStopPipeline(org.apache.beam.runners.direct.DirectRunnerTest)  Time elapsed: 0.011 sec  <<< ERROR!
java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@326c09f7 rejected from java.util.concurrent.ThreadPoolExecutor@36538b62[Shutting down, pool size = 1, active threads = 1, queued tasks = 0, completed tasks = 0]
	at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2047)
	at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:823)
	at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1369)
	at java.util.concurrent.AbstractExecutorService.submit(AbstractExecutorService.java:112)
	at org.apache.beam.runners.direct.TransformExecutorServices$ParallelEvaluationState.schedule(TransformExecutorServices.java:69)
	at org.apache.beam.runners.direct.ExecutorServiceParallelExecutor.evaluateBundle(ExecutorServiceParallelExecutor.java:245)
	at org.apache.beam.runners.direct.ExecutorServiceParallelExecutor.scheduleConsumption(ExecutorServiceParallelExecutor.java:208)
	at org.apache.beam.runners.direct.ExecutorServiceParallelExecutor.access$1200(ExecutorServiceParallelExecutor.java:70)
	at org.apache.beam.runners.direct.ExecutorServiceParallelExecutor$MonitorRunnable.addWorkIfNecessary(ExecutorServiceParallelExecutor.java:584)
	at org.apache.beam.runners.direct.ExecutorServiceParallelExecutor$MonitorRunnable.run(ExecutorServiceParallelExecutor.java:482)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Coverage decreased (-0.1%) to 70.02% when pulling 5fb6b0b641e792275e5c9ff95795631f7d7cb655 on echauchot:BEAM-135-BATCHING-PARDO into de36e8398ecb37b9826175c4723f94d127e63d03 on apache:master.

Thanks!

Yes of course, I left the detailed small commits for you to easily see each change requested.
Thanks Thomas!


Updating the Dockerfile and creating required directories - Development environment [Ubuntu]

Added two directories that are required for starting PGA. The .gitignore file in these directories will make sure that the temporary files created inside them are not tracked.

ide-integration/src/main/resources/pga/airavata-php-gateway/app/storage/views/.gitignore
ide-integration/src/main/resources/pga/airavata-php-gateway/app/storage/sessions/.gitignore

Updated the Dockerfile configuration to change the owner of the PGA files in /var/www directory to www-data. It was creating a problem in Ubuntu as Docker by-default creates all the files with the root as the owner. If the owner of the files is root, the docker container is not able to access them and the application does not start. This behavior is different from Mac.
Note:- These changes will have to be made to the dockerimage that is used in docker-compose.yml after testing. For testing the changes, we can use the following docker-compose.yml configuration

version: '2.1'
services:
  pga:
    build : ./
    volumes:
      - ./airavata-php-gateway:/var/www/portals/default
      - ./exp-data-dir:/var/www/portals/gateway-user-data
    ports:
      - "8008:80"
    mem_limit: 3G
    mem_reservation: 3G

@DImuthuUpe Can you please review this pull request?


Wrong cuda allocation

Hi,
when I try to run an inference with any MoE-LLaVA on a node with 4x A100 I run into an issue with tensor allocation:
I have installed MoE-LLaVA from the latest main commit (188d462)
Traceback (most recent call last):
  File "/workspace/models.py", line 235, in forward
    output_ids = self.model.generate(
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/transformers/generation/utils.py", line 1764, in generate
    return self.sample(
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/transformers/generation/utils.py", line 2861, in sample
    outputs = self(
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/accelerate/hooks.py", line 165, in new_forward
    output = old_forward(*args, **kwargs)
  File "/workspace/MoE-LLaVA/moellava/model/language_model/llava_phi_moe.py", line 336, in forward
    ) = self.prepare_inputs_labels_for_multimodal(
  File "/workspace/MoE-LLaVA/moellava/model/llava_arch.py", line 198, in prepare_inputs_labels_for_multimodal
    image_features_minibatch = self.encode_images(images_minibatch)  # [mini_b, l, c]
  File "/workspace/MoE-LLaVA/moellava/model/llava_arch.py", line 153, in encode_images
    image_features = self.get_model().mm_projector.forward_image(image_features)
  File "/workspace/MoE-LLaVA/moellava/model/multimodal_projector/builder.py", line 138, in forward_image
    return self.image_spatial_proj(image_feature)
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/accelerate/hooks.py", line 165, in new_forward
    output = old_forward(*args, **kwargs)
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/torch/nn/modules/container.py", line 217, in forward
    input = module(input)
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
    return forward_call(*args, **kwargs)
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/accelerate/hooks.py", line 165, in new_forward
    output = old_forward(*args, **kwargs)
  File "/workspace/data/conda/envs/moellava/lib/python3.10/site-packages/torch/nn/modules/linear.py", line 114, in forward
    return F.linear(input, self.weight, self.bias)
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cuda:3! (when checking argument for argument mat1 in method wrapper_CUDA_addmm)

All tensors (input_ids and image tensor) including the model are located on cuda:0 before I run model.generate. Could this be related to https://github.com/haotian-liu/LLaVA/issues/769?

Just for completeness, adding device_map='cuda' in load_pretrained_model fixes this.

What's your command? I also meet this bug and I add  --include localhost:0 to only use cuda:0 to fix it.

@LinB203 I am not using the script, I am directly accessing the model by code:
class MoE_LLaVAModel(VLMModel):

    def __init__(self, model_name):
        from moellava.constants import IMAGE_TOKEN_INDEX, DEFAULT_IMAGE_TOKEN
        from moellava.model.builder import load_pretrained_model
        from moellava.utils import disable_torch_init
        from moellava.mm_utils import get_model_name_from_path

        disable_torch_init()
        self.tokenizer, self.model, processor, _ = load_pretrained_model(
            model_name,
            None,
            get_model_name_from_path(model_name),
            device_map='cuda',  # <----- adding this fixes the issue
            cache_dir=CACHE_DIR)
        self.model.eval()
        self.image_processor = processor['image']

        conv_mode = None
        if "stablelm" in model_name.lower():
            conv_mode = "stablelm"
        elif "phi" in model_name.lower():
            conv_mode = "phi"
        elif "qwen" in model_name.lower():
            conv_mode = "qwen"
        else:
            raise ValueError(f"Unknown conversation {model_name}")

        self.conv_mode = conv_mode

    @staticmethod
    def get_MoE_LLaVA_StableLM():
        return MoE_LLaVAModel('LanguageBind/MoE-LLaVA-StableLM-1.6B-4e')

    @staticmethod
    def get_MoE_LLaVA_Qwen():
        return MoE_LLaVAModel('LanguageBind/MoE-LLaVA-Qwen-1.8B-4e')

    @staticmethod
    def get_MoE_LLaVA_Phi2():
        return MoE_LLaVAModel('LanguageBind/MoE-LLaVA-Phi2-2.7B-4e')

    @staticmethod
    def get_MoE_LLaVA_Phi2_384():
        return MoE_LLaVAModel('LanguageBind/MoE-LLaVA-Phi2-2.7B-4e-384')

    def forward(self, prompt: str, image_path: str) -> dict:
        from moellava.constants import IMAGE_TOKEN_INDEX, DEFAULT_IMAGE_TOKEN
        from moellava.conversation import conv_templates, SeparatorStyle
        from moellava.mm_utils import tokenizer_image_token, KeywordsStoppingCriteria

        image = Image.open(image_path).convert('RGB')

        conv = conv_templates[self.conv_mode].copy()
        image_tensor = self.image_processor.preprocess(image, return_tensors='pt')[
            'pixel_values'].to(self.model.device, dtype=torch.float16)

        inp = DEFAULT_IMAGE_TOKEN + '\n' + prompt
        conv.append_message(conv.roles[0], inp)
        conv.append_message(conv.roles[1], None)
        prompt = conv.get_prompt()
        input_ids = tokenizer_image_token(
            prompt, self.tokenizer, IMAGE_TOKEN_INDEX, return_tensors='pt').unsqueeze(0).to(self.model.device)
        stop_str = conv.sep if conv.sep_style != SeparatorStyle.TWO else conv.sep2
        keywords = [stop_str]
        stopping_criteria = KeywordsStoppingCriteria(
            keywords, self.tokenizer, input_ids)

        with torch.inference_mode():
            output_ids = self.model.generate(
                input_ids,
                images=image_tensor,
                do_sample=True,
                temperature=0.2,
                max_new_tokens=1024,
                use_cache=True,
                stopping_criteria=[stopping_criteria])

        outputs = self.tokenizer.decode(
            output_ids[0, input_ids.shape[1]:], skip_special_tokens=True).strip()
        return {'response': outputs}

I wonder that which gpu will run if add device_map='cuda' ? Is only the cuda:0 (even you may have 2 or more GPUs)?


Missing classname escaping

We tried to move a massive project to TSS but hit mostly one issue: generated class names may contain parenthesis -someComponent(something)-.
For example, we are exporting this kind of thing:
export default connect(
    mapStateToProps,
    mapDispatchToProps
)(withStyles(sidebarStyle)(injectIntl(Sidebar)));

The injectIntl() ends up in the class name (for us it generates things like css-1hj7v7-injectIntl(Sidebar)-drawerRootContainer), which was the case with JSS as well, but JSS was escaping the class name in CSS: css-1hj7v7-injectIntl\(Sidebar\)-drawerRootContainer.
TSS does not escape the class name, so the browser cannot read the associated CSS rules. This seems to be a severe issue for class components.

Hello @Nek-,
Thank you for bringing this issue to our attention.
To enable us to expedite a resolution, it would be tremendously helpful if you could create a replication repository. With this information at hand, we should be well-equipped to develop and deploy a new version promptly.
Best regards.


CI: add CIFuzz GitHub action

Add CIFuzz workflow action to have fuzzers build and run on each PR.
This is a service offered by OSS-Fuzz where ZNC already runs. CIFuzz can help detect regressions and catch fuzzing build issues early, and also moves the fuzzing closer into the development workflow. CIFuzz has a variety of features which can be found in the URL above. In the current PR the fuzzers gets build on a pull request and will run for 300 seconds.

Thanks, how does it know to pass cmake -DBUILD_SHARED_LIBS=OFF -DWANT_ICU=OFF -DWANT_OPENSSL=OFF -DWANT_ZLIB=OFF -DWANT_IPV6=OFF .. ?

Thanks, how does it know to pass cmake -DBUILD_SHARED_LIBS=OFF -DWANT_ICU=OFF -DWANT_OPENSSL=OFF -DWANT_ZLIB=OFF -DWANT_IPV6=OFF .. ?

It's based on the set up here: https://github.com/google/oss-fuzz/blob/master/projects/znc/build.sh

I see. I've added a comment with that link to this file.


Ability to insert nodes or links through EPANET Tookit/API

The toolkit does not currently support programmatically adding nodes or links after the initial data is read from .inp text file.  This is left to the realm of GUI or other outside tools that manipulate the data before the toolkit consumes it.
Is there any interest in adding this feature to the toolkit?  If so, I can add more comments about some ideas I have to tweak the current code.

The ability to build the network, with all elements, from the code is needed.
Currently when the GUI user press the run button the program writes an INP file and calls the DLL which reads the INP file. Strange but this is how it works.

It is not strange when you consider that a lot of data error checking is performed when the INP is read back into the engine.
I think it is only strange because there is likely a better (although maybe more complex) way to do it.

+1
absolutely needed. also requires a full analysis of the way that network topology and state are allocated and retained. I started some of this work in my own branch, but it's nowhere near ready for review or submission; more a prototype for understanding what is likely to break if we do this.

absent objections, I think this issue should be broadened to encompass the ability to programmatically construct a complete network and run a simulation - with no requirement of having an inp file. This would mean that the 2.00.12 behavior would have to be replicated through a "factory" that parses the input file and calls into this new API.

Hello again. Folks watching this issue will be excited to see PR #88
My thanks to @AbelHeinsbroek for submitting. A question for Abel and any others who care to digest - how much of this Issue is covered by the PR? In other words, from a Roadmapping perspective, how much further along will we be, and what work would remain, once the PR is finalized?
I encourage us all to go over to the PR and look at it in-depth. I've started a review with some detailed comments and suggestions which I hope will be a starting point for good discussion. Hope to get this issue finalized and merged soon!

Sure. I suggest we open a new branch for this.
Thanks @AbelHeinsbroek !

Ok, as helpfully suggested by @eladsal I have redirected the base branch for the PR to a new dev-net-builder branch. Also I've got a preliminary review on the PR - so I hope everyone will feel at liberty to comment and discuss.
As to the question of how this fits in with overall roadmapping or project evolution, I think what I'd like to see is for all the input[n].c files to be moved into a separate library that uses these new API functions to build the network, rather than modifying epanet's internal state.
A question to consider: is the set of API functions complete in this regard, to take over responsibility of building a network and setting all properties?

Hi all,
Thanks for the feedback! I've mostly developed this set of methods to augment my EPYNET module with the ability to construct and change networks in a very 'Pythonic' manner, for example:
network = Network()
main = network.add_reservoir('in', x=10, y=10)
main.elevation = 10

node = network.add_junction('j1', x=20, y=10)
node.basedemand = 1
node.elevation = 5

pipe = network.add_pipe('p1', 'in', 'j1')
pipe.diameter = 500
pipe.length = 1000
pipe.roughness = 0.1

network.solve()
print(pipe.flow)

Which works like a charm.
@samhatchett I think most of the issue is covered by my pull request, although more testing is needed to verify that it works without issue on all platforms, and with all other features, such as control schemes and chemicals, which I have not tested yet. It would be nice to be able to change link and node types, but that would require a lot of 'shuffling' arrays and work.
Refactoring the input[n].c to use these new methods would be a good idea, but would require some re-thinking on the current implementation of reallocating memory and shuffling around indexes.
Regarding those indexes, I would like to propose getting rid of all the index based functions and use object ids instead, as indices are no longer intrinsically linked to objects when the network is modified.

I think everything discussed here has made it into the dev branch right? Ok to close?

Yes, these APIs were added.


[BUG] JindoRuntime Dataload failed without specifying the target field for multiple mountpoints in Dataset

What is your environment(Kubernetes version, Fluid version, etc.)

Describe the bug
DataLoad Pod failed

dataload pod log

What you expect to happen:
The dataload pod executed successfully
How to reproduce it
Create a DataSet with multiple mountPoints, but in the DataLoad manifest  do not specify the target filed.
Additional Information

@cheyang


Drop support for pre-12.1 nodes

Migration to 12.1 is done, no more support for pre-12.1 nodes (PROTOCOL_VERSION < 70206):

remove deprecated code
bump min_proto-s to 70206

IMO this should be done as a preliminary action before next migration to clean network and code ahead of time.

should MIN_POSE_PROTO_VERSION in src/masternodeman.h be updated ?

Good question :)
I thought of it too but decided to keep it because MIN_POSE_PROTO_VERSION is actually simply POSE_PROTO_VERSION like GOVERNANCE_FILTER_PROTO_VERSION etc i.e. we don't use it to determine peer-connectivity but rather to define a version in which some feature was first introduced. Unlike MIN_INSTANTSEND_PROTO_VERSION for example which should really be named MIN_INSTANTSEND_PEER_PROTO_VERSION...  😇 but that's out of the scope of this PR 😉


scaling in the X coordinates is now optional - updated dependencies

I made the scaling in the X coordinates optional, just added a single boolean "enableScaleX" and a method "setEnableScaleX"

I like it. But I think it would be better as an XML attribute, as the other configuration is, so that each ViewGroup would not need to worry about it, and could just pass along their XML attributes to the delegate which would control the scaling

You're right, I'll fix it asap :)
On Thu, Jul 28, 2016, 5:53 PM John<EMAIL_ADDRESS>wrote:

I like it. But I think it would be better as an XML attribute, as the
other configuration is, so that each ViewGroup would not need to worry
about it, and could just pass along their XML attributes to the delegate
which would control the scaling
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Commit451/ElasticDragDismissLayout/pull/7#issuecomment-235938549,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHHI818EE3LdbFxIkJ8rEvviHzXqvCFjks5qaNBigaJpZM4JTh8_
.

done!

Awesome, looks great!

This is now available in version 1.0.4. Enjoy!

awesome, thanks :)
Il giorno ven 29 lug 2016 alle ore 17:14 John<EMAIL_ADDRESS>ha
scritto:

This is now available in version 1.0.4. Enjoy!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Commit451/ElasticDragDismissLayout/pull/7#issuecomment-236208079,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHHI8wVEnjzwtVpOXvj5W55RZBa5QD1Wks5qahjygaJpZM4JTh8_
.


Common imports for types/ interfaces/ utils/ constants/ services

common imports for types in src/types
common imports for constants in src/utils/constants.ts

I don't think to separate file for types is necessary if they're uncommon.

I got feedback from many devs in my last refactor PR to separate files for types even though they are not reusable and I personally feel it is the correct way to better code structure, maintainability, and enhanced readability.
https://medium.com/mintbean-io/how-i-organize-my-typescript-types-d9ae7f3ac30f
feel free to change your requested changes and approve.

In the case of constants, we do the same @sahsisunny

I don't think to separate file for types is necessary if they're uncommon.

I got feedback from many devs in my last refactor PR to separate files for types even though they are not reusable and I personally feel it is the correct way to better code structure, maintainability, and enhanced readability.
https://medium.com/mintbean-io/how-i-organize-my-typescript-types-d9ae7f3ac30f
feel free to change your requested changes and approve.

Can you mention some devs who suggest you to create separate types for uncommon types?

I don't think to separate file for types is necessary if they're uncommon.

I got feedback from many devs in my last refactor PR to separate files for types even though they are not reusable and I personally feel it is the correct way to better code structure, maintainability, and enhanced readability.
https://medium.com/mintbean-io/how-i-organize-my-typescript-types-d9ae7f3ac30f
feel free to change your requested changes and approve.

Can you mention some devs who suggest you to create separate types for uncommon types?

@Pratiyushkumar @satyam73 @yesyash


go get from private repo with git version after 1.8.3

i use cenots with git 1.8.3 ,user alpine with git 2.11.0,
when i use the centos to go get somthing,it is ok.then i change the git version 2.11.0 on centos.it become something wrong.
i find that after the git version 1.8.3；use the golang's cmd go get -u -v from a private repos is return an error like:
package git.coding.net/alphayan/orionv2.git: cannot download, git.coding.net/alpha***/***** uses insecure protocol
and then i use go get -u -v -insecure it return an error like:
fatal: could not read Username for 'https://git.coding.net': terminal prompts disabled
i don't konw it's git's or golang's bug

When you run go get -v, it lists the commands it runs, including the git clone. Have you tried running that separately?
If that fails, then it's likely a git problem, not a Go one.
Also, please see the issue template - this bug report is missing a lot of information, like the Go version you're using.

@mvdan  thanks,i made a try and error.
centos :go version 1.8; git version 1.8.3. it's right.

This doesn't make much sense. What git command was run? Does it look correct? Does it work if you run it separately?

@mvdan thanks,i made a try and error.
centos7 :go version 1.8; git version 1.8.3. it's right!
alpine3.5:go version 1.8;git version 2.11.0,it return an error.
when i change the centos's git version to 2.11.0. i use go get -u -v,it also return an error.
but both centos and alpine, i use git clone, it all right !
it throw me for a loss

Seems like the issue is that when Go calls git it's not attached to a terminal, so it can't ask for a password. I'm pretty sure this is by design - go get is for users, not developers with advanced use-cases like private repos. They can git clone directly. See https://github.com/golang/go/issues/6968#issuecomment-66089347
As a workaround, you can set up password caching or ssh auth via a private key: https://gist.github.com/shurcooL/6927554

@mvdan thank you very much~!


[T3A2][W15-A2] Gng Jia Hui

Ready for review

Some comments added. Feel free to add more comment if you have any questions. Once you are done, you may close the PR after reading comments.


0.6.2 Windows File Paths are broken in 0.6.2

After updating to 0.6.2 on Windows 10 Pro I get the following log entry and an abrupt quit when I run > theme replace:
08:58:23 [development]Asset config/settings_data.json filtered based on ignore patterns

Nothing is logged further and the command quits.
My config looks like:
development:
  password: xxxxxxxxxx
  theme_id: "123"
  store: my-fake-store.myshopify.com
  timeout: 120s # helps with big files
  ignore_files:
    - app/
    - node_modules/
    - tmp/
    - Brocfile.js
    - Procfile
    - readme.md

I have reverted to 0.6.1 and successfully run > theme replace.
I may be able to help troubleshoot in the next few days if you have ideas.
Thanks!

@tbeseda you can actually take out those ignores now since now the actions are only performed on theme folders (templates, config, assets, ect.) so those folders and the files in the main directory will no longer be touched.
However this is probably an issue with windows paths with ignores, I will look into it.

I have confirmed the issue with this now and will have a fix for it soon.

I have just release a version v0.6.3 that will fix this issue. Theme kit has had some issue with handling windows paths but I have done some work today to hopefully isolate this code so that it won't be effected in the future.