Ignore lombok annotations (for bean classification) @Slf4j, @Getter, @Setter, @EqualsAndHashCode, @ToString

Hi @rbygrave!
First, thanks for your amazing project, a really good one paried with Javalin.
I'm facing an issue which I guess may be related to this. At runtime, I got:
Exception in thread "main" java.lang.NoClassDefFoundError: lombok/Data
...
Caused by: java.lang.ClassNotFoundException: lombok.Data

Lombok: 1.18.12
Javalin: 3.9.1
Dinject: 1.18
@Singleton
@Data
public class RedisConfig {
  private static final Dotenv dotenv = Dotenv.load();
  private final String host;
  private final int port;
  private final String password;
  private final String uri;

  public RedisConfig() {
    this.host = dotenv.get("REDIS_HOST", "localhost");
    this.port = Integer.parseInt(dotenv.get("REDIS_PORT", "6379"));
    this.password = dotenv.get("REDIS_PASSWORD", "");
    this.uri = String.format("redis://%s@%s:%s", password, host, port);
  }
}

When I compiled and looked at generated-sources the result is:
@Generated("io.dinject.generator")
public class RedisConfig$di  {

  public static void build(Builder builder) {
    if (builder.isAddBeanFor(RedisConfig.class)) {
      RedisConfig bean = new RedisConfig();
      builder.register(bean, null, Data.class);
    }
  }

}

The class files are:
import io.github.cdimascio.dotenv.Dotenv;
import javax.inject.Singleton;

@Singleton
public class RedisConfig {
  private static final Dotenv dotenv = Dotenv.load();
  private final String host;
  private final int port;
  private final String password;
  private final String uri;

  public RedisConfig() {
    this.host = dotenv.get("REDIS_HOST", "localhost");
    this.port = Integer.parseInt(dotenv.get("REDIS_PORT", "6379"));
    this.password = dotenv.get("REDIS_PASSWORD", "");
    this.uri = String.format("redis://%s@%s:%s", this.password, this.host, this.port);
  }
 // getter, setter, ...

public class RedisConfig$di {
  public RedisConfig$di() {
  }

  public static void build(Builder builder) {
    if (builder.isAddBeanFor(RedisConfig.class)) {
      RedisConfig bean = new RedisConfig();
      builder.register(bean, (String)null, new Class[]{Data.class});
    }

  }
}

When I de-lombok the class, everything works fine. Any clues?

Can you create a failing test case?  Provide an example application that shows the error?
Thanks.

Also can you include the full stack trace and clarify if that occurs at build time?
If using maven have you done a build using the -X  debug option?
Plus I think this should really be a new issue assuming you can provide a failing test case.
Thanks, Rob.

@aletundo  ... see https://github.com/dinject/dinject/issues/40

@rbygrave I'm so sorry for the late reply but I was really busy at work.
I just saw the changes within the release page of the website and than I landed here!
Thanks for the fix, I'm going to use it now.

All good :)
Note that at this stage I plan to release a 2.1 version of dinject ... with the only change being that the annotations have been moved to io.dinject.annotation package (in a separate module).


Fix staking rewards query

This came from https://github.com/CosmWasm/cosmwasm/issues/513#issuecomment-682436132 and also requires https://github.com/CosmWasm/cosmwasm/issues/515 and https://github.com/CosmWasm/go-cosmwasm/issues/134 to properly implement the return value.

There is a FullDelegation response, which does have an accumulated_rewards field, which is what you are looking for.
If you look into the go query handler, which calls into the Keeper to get the rewards. This is then transformed into the cosmwasm type to pass it into Rust. And should have the reward info.
Digging in, I see this was left as a TODO as I had no idea how to get such info from the staking module.
The implementation to calculate that was not done and needs to be implemented. Looking into this again, the calculation is done in distribution.Keeper.calculateDelegationRewards, which is a private method. Even the query method is private. And many of the functions used inside are private.

I think I completed this one. If you see a better way to get this info, please let me know.


Rules & requirements

Fixes to readme that will reflect current status after landing pull requests #5 and #6. I've also added some minor stylistic improvements and links in readme for issues and pull requests, hope that's OK.

I've added comment to commit, so I add it here too: Why not merge this PR and instead provide contributors section? Would be IMO better in the long run.

I don't think that something this complex is required for this plugin. It's for people already using Sage, so they'll have requirements already met, and coding rules are nice but not really needed.


Admin v3 and subnet configuration

-added possibility to specify subnet for discovery => closes #29
-fix translations
-Logging improved
-materialized index.html for admin v3
-v 0.10.0

ready to merge?

Yes, of course :)

ty


ostree is not a core dependency of buildstream anymore

See original issue on GitLab
In GitLab by [Gitlab user @jjardon] on Jul 23, 2018, 10:45
Background
With the move to the CAS-based cache, we do not depend on ostree anymore (only for the ostree source plugin)
Task description

Update docs

Acceptance Criteria
Documentation is updated

In GitLab by [Gitlab user @jjardon] on Jul 23, 2018, 10:46
assigned to [Gitlab user @jjardon]

In GitLab by [Gitlab user @tlater] on Jul 23, 2018, 10:47
Similarly, we should update the docker images to reflect this.
EDIT: I raised a separate issue buildstream-docker-images#14

In GitLab by [Gitlab user @jjardon] on Jul 23, 2018, 10:58
mentioned in merge request !558

In GitLab by [Gitlab user @phildawson] on Jul 24, 2018, 10:13
mentioned in commit 47d6fa0b6fd9b5ae9f73d7fee01b9d6ad5e09754

In GitLab by [Gitlab user @phildawson] on Jul 24, 2018, 10:16
mentioned in merge request !525

In GitLab by [Gitlab user @jjardon] on Jul 24, 2018, 12:58
closed via merge request !558

In GitLab by [Gitlab user @jjardon] on Jul 24, 2018, 12:58
mentioned in commit de162e43b11a743c346d569ffc8b19820cfaba11


Close cross for Alerts missing

The closing-cross of alert-elements is display at the toolbar preview, but don't exist if dragged onto the page.

I'll have to double check when I'm at my computer, but i think you should be able to right click on the element (once it's on the canvas) and set it to "dismissible" (or something like that)

 Hm also thought so, but there's nothing in the context menu.
.....or I'm blind and miss something :)

hmm, it's definitely there for me. If you haven't already, it might be worth checking if it shows up with a completely new file.

Gnah ^^" reopening solved the problem. Maybe the contextmenu wasn't updated because I imported the stencil and go on to work without restarting.
Anyway thanks for your help, you do an awesome job here! :) If you need a helping hand for some web or Windows stuff feel free to ask me.


Stuck on "workrequest starting - saving image"

Last notification is shown as such, and then nothing...
Pretty sure this is a bug on the sample, right?

Unfortunately I cannot reproduce this issue. Do you mind sending me the logcat for the test run?

What test run?
What exactly to do ?
Can you please show a video?

Thanks for you reply.
Can you please capture the logcat of the device/emulator while running the condelab application on your device/emulator?
You can find the logcat documentation here, and you can Google it, for howto videos.

You can't reproduce it? Just run the sample, choose an image and blur it. The notification appears, reaches this state of "saving image", and stuck on it without anything to do with it and on the app.
See video, and logcat.
result.zip

Thanks for the video.
As explained in the codelab page 9 (step 4: Run Code), Once the processing is completed, a new "SEE FILE" button is shown. Pressing the "SEE FILE" button display the blurred image.
The notification is still visible on the device by design. If you want to remove it from the notification bar, you can add the logic to call "cancel" or "cancelAll" methos from the NotificationManagerCompat class:
https://developer.android.com/reference/android/support/v4/app/NotificationManagerCompat#cancel
Please reopen if you still think this is an issue with the codelab.

Why have a notification for this, if it doesn't do anything when I press it?
I think the guidelines say it's best to always have something to do when pressing a notification.
Also, I've found a different issue, related to the permission.
See attached video.
2018-09-18_16-10-41.zip
Why actually you need the permission?
For file choosing, you can use the normal file-chooser intent, and for the output file, you can write into the app's files...


Update start.sh

Update the start.sh file with some needed verification as example:

If nodejs exists (if node or nodejs)
If vlc exists
If ffmpeg exists
If SQLite exists
check node version

example from here:
gnudate() {
    if hash gdate 2>/dev/null; then
        gdate "$@"
    else
        date "$@"
    fi
}

## Features:
# - can execute it from anywhere ex: ./home/user/wwidd/start.sh
# - possibility to create a symlink on /bin to start.sh
# - check for any dependence missing and shows how to install it (ubuntu and arch)
# - make it shows the "nodejs output" on screen
# - do not to send stderr to error.txt file, so the user can check on screen when it happens
# - accept "--help", "--version", "debug","--nodejs-debug" and "-ignore-dependence-check"
# - "--help" reference documentation to https://github.com/wwidd/wwidd/wiki
# - check for jquery, jorder, flock files
# - check if Node.JS is called by "node" or "nodejs"
# - check if nodejs version is too old

the option --version is not implemented because there is no place where I can get this information.
For this option could work as expected wwidd software should have into some file this version.

Pull Request Merged


Open the dataset

Can you please provide the dataset download link? Thank you.

Thank you for your interest. I think you can download the dataset from google drive link, which I attached into this repo already


[v0.9.0-rc7]-No cluster section in the web GUI

I am a new user of influxdb. I tried to set up a 3 node cluster. I installed http://get.influxdb.org/influxdb-0.9.0_rc7-1.x86_64.rpm to the first node
I set the hostname and I added(/etc/opt/influxdb/influxdb.conf):
[sharding]
replication-factor = 3
after the [cluster] section.
I started the cluster: /etc/init.d/influxdb start
After I setup the 2 and 3 nodes.
I added the configuration file:
[cluster]
# Location for cluster state storage. For storing state persistently across restarts.
dir = "/tmp/influxdb/development/state"

seed-servers = ["xxx.xxx.xxx.xx:8090"] #this is the IP address of the 1th node.

[sharding]
replication-factor = 3

When I open the GUI, I can not see the cluster:

What I am doing wrong? How I can setup a cluster?
Thanks,
Zoltan

I have setup a cluster using InfluxDB v0.8.8 (git: afde71e) (leveldb: 1.15). I can see the cluster section in the WUI:

I do not know why I can not see the cluster section using v.0.9?
I also noticed that the database is very slow. I have 3 nodes 4 CPU and 8GB memory. I only have ~16 million data-points. Which is equivalent two days of monitoring data. It takes ~5 minutes to make the following plot:

The admin interface is changing significantly as part of #2746. You'll be able to pull server and cluster details via the query language, so there won't be a dedicated section for those any longer.


Feature request - Accept raw jsonnet on stdin

The expectation would be that the raw jsonnet includes the "spec" (spec.json) manifest as well as any other Kubernetes manifests that need to be applied.

Not stale

It is possible to accept stdin in jsonnet, which in turn could be jsonnet:
➜ cat a.jsonnet
import "/dev/stdin"

➜ echo "{a:'b'}"| tk eval a.jsonnet
{
  "a": "b"
}

In combination with inline environments, it can include the spec.json data.

Refresh


Add Dustin's bio

Not sure how these usually go, how's this sound?
The abstract looks good so far; the points I raised by email about the odjitter paper are relevant

Many thanks!


fix broken png files: libpng 1.6.2 and newer has stricter iCCP rules

I am running on Arch Linux with libpng 1.6.16, and for a long time I have had the following error being spit out to the shell when running spyder from the command line:
libpng warning: iCCP: known incorrect sRGB profile

I never bothered to look into it, spyder just worked fine, until I wanted to figure it out today. Seems this is related broken *.png files used by spyder. The fix is trivial, and I found the same answer both at stackoverflow and tex.stackexchange:
# fix all png files in the current directory (and sub-dirs) using ImageMagick:
find . -type f -name "*.png" -exec convert {} -strip {} \;

The libpng warning dissapeared after the *.png file conversion for me. I have not tested these new *.png files with libpng versions prior to 1.6.2 (the version that is alleged to have stricter iCCP checkings).

Thanks for your contribution. Before merging, I need to verify that this does not introduce problems with older libpng versions, as you mentioned :-)

I'll can try to test it on my system with different versions of libpng. What I will not be able to test is how this might affect the Windows and Mac environments. I would expect no problems since strictly speaking the png files should be cleaner at this stage compared to before. But I agree, better safe then sorry :-)

Yes, please do. I'll do my part on Mac and Windows

Not an expert here, so not entirely sure, but I can't see how testing with older libpng versions (1.5 for instance) is relevant. The newer versions have stricter checks on testing if a png is compliant with the standard. Version 1.6 has more strict tests, so warns when files are not 100% according to the standard. I assume that this stricter checking would actually benefit older clients rather than the contrary. Again assuming here, but I would but very surprised indeed if png's created with libpng 1.6 would not be backwards compatible with older viewers.
Further, I am not even sure if libpng is actually used when they are rendered/shown in Spyder. I am under the impression it libpng comes into the picture when manipulating png's. See for instance Wikipedia for what libpng is supposed to do.
That being said, I am not sure testing for me is worth the trouble: I would have to recompile Qt using an older libpng version in order to test this. I think it would be sufficient for any other user with a libpng version prior to 1.6 (being 1.5, 1.4, ...) to see if these png images still work:
git clone git@github.com:davidovitch/spyder.git
cd spyder
python bootstrap.py

That sounds like much simpler testing path :-)

While you're modifying the icons, could you try to use optipng on them ? it optimizes them without losing any information, I've used this program successfully many times.
It's not a big change, but reducing many icon size can speed up the startup a little bit maybe (or I'm too much a perfectionnist).

@Nodd, interesting suggestion, and I gave it a spin. For most PNG's, using optipng -o7 resulted in a 30% decrease in size. I have not compared the results visually one on one, but a visual inspection of a running Spyder instance looks fine for me. @Nodd: while you are also at it, just in case you have an libpng version prior to 1.6, can you confirm these png's still all work properly?

These optimized png's consume approximately 1MB less of my disk space. I don't know if this has any effect, but at least there leaner now :-)

I'll try tomorrow, we have some old hardware at work !

@davidovitch , @Nodd any progress on this one?

@goanpeca Not from my part. I think some more images have been added and I still have to add them. I hope to get back to this later this week or next week.

If this is something that we would like to do periodically to keep images in spyder clean, then maybe it would be nice to have such script inside the repo.
@ccordoba12 ?

That would makes sense. I am not sure who generates the images on what platform and with which versions. I have now used ImageMagick for the conversion on Linux. I will have to look into how to avoid this issue in the future (which will depend on what software is used on which platform). Maybe I can think a unit test that all images should be able to pass.

I have problems cloning the repo on the machine I was talking about. I'm in favor of merging it because imagemagick is a well-know and stable program and I don't see any reason why the new png images would cause any problem. They are displayed fine in github for example !
The script should go to https://github.com/spyder-ide/spyder/tree/master/img_src

@davidovitch, please add your script to the location mentioned by @Nodd.
Then I'll merge :-)

@davidovitch, any updates ? Just a small script !
If you don't have the time just say it, I'll make the script myself. The libpng warnings are annoying when trying to spot errors in plugins.

@Nodd, sorry for the delays. I've named it png-convert-opt.sh. Is that an appropriate name for it?

Linux only is fine, thanks.
Could you use something like cd $(dirfile $0)/.. to be sure to run the script from the correct directory ?

You should run from the top level spyder repository directory in order to be sure to catch all png files. Since it will recursively run through all the sub directories, this might cause some unwanted side effects if you run it by accident from, for instance, your home directory. I think it is fair to assume the developer knows what he/she is doing.
I am not sure how to always browse to the top level spyder directory. Could you explain what you mean with dirfile, I am afraid you lost me here...

$0 is the name of the script and dirname returns the directory of the argument, so dirname $0 is the directory img_src and you have to go one birectory up, hence the /.. at the end.

Ah ok, I still have to learn a lot of the regular bash magic :-) Thanks for explaining.

@ccordoba12 I think this is about to be ready for merge. Do you want me to clean up and rebase + squash into fewer commits? Any more comments/suggestions?

Does this conflict with #2260 ? If not, we should merge it.
If I'm not mistaken Anaconda updated the libpng version so lots of people will see the warnings, so maybe it should be backported for 2.3.5.

Yes, it should conflict with the last commit of #2260.

rebased on upstream/master, there was one merge conflict, and I adopted upstream version (deleted image).  Let me know if you want this squashed into 2 commits: one for the re-formatted images, and one for the utility conversion script.

@davidovitch, thanks for the fix. Now that Anaconda has moved to libpng 1.6 we also need this fix in the stable branch.


Adsk Contrib - Change RB-2.1 branch to the version '2.1.1dev'

Signed-off-by: Patrick Hodoul<EMAIL_ADDRESS>

Friendly reminder that the pull request could be merged this week so I will merge it this Friday.


How to use Lua example [Play with your Mouse instead of Arrow Keys]

What is your question?
There is a Lua example named Play with your Mouse instead of Arrow Keys , I download it and then I put it in assets\data\song-name, then I run the game, and move mouse over the fixed arrows  at the top of the window, but it does not work.
What should I do?

The script probably broke over time due to me changing stuff

the script works fine for me. you sure you have the most recent build

i just replaced onUpdatePost() to onUpdate()

can i have the script please?


HP checker and taxes limits are correlated

According to conversation with Sly in the TG, HP checker has nothing to do with tax limits. But when you disable HP checker, you are not able to change tax limits. Also when you enable mempool buy, HP checker is disabled by default and therefore tax limits are disabled in the UI and not changeable, but they are still being checked.

When mempool is enabled HP checker is disabled when buying(cannot check with mempool). Taxes are detected by HP checker.

Ok


install

homebrew support?

Why? What value would that bring that pip does not?
Basically, anyone is welcome to downstream repackage us if they'd like to, but pip is the deployment mechanism we support.

Homebrew is for Python itself, and perhaps some difficult to install modules, not general Python packages.


Remove md array: it is not used any more.

Checklist

[x] tests are added or updated

Description of change

This removes the md array. The changes to signature algorithm handling mean it is no longer used.

Could you comment on red cross from travis? The one with "boring" tests of course...

Checking it. It should be possible to reproduce it with our own signature algorithms tests.

Finally got this one to pass all the tests. It ended up a bit messier than I hoped but a later tidy up/overhaul of tls1_check_chain() should improve things a lot.

+1


feat(UI): make selected answer pop

Summary of changes

This PR sets the selected answer color as goldenrod and set the other button colors to lime. I think at some point we should consider adding a dark mode toggle but there's no rush.
Checklist

[X] I have read and followed the contribution guidelines.
[X] I have read through the Code of Conduct and agree to abide by the rules.
[X] This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
[X] My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
[X] I have provided a summary of my changes.

closes #965

how about making submit button to have a black background and white text & borders?

@shootermv

how about making submit button to have a transparent background and white text & borders?

Yeah, I like that change
@a2937
Please make that update 👍


Better random sending times

Emails send at the same time for all users (is this bad?)
Emails send at basically the same time every times (random.random() is seeded by system time...)

Turns out that the 'countdown' on my send-emails task wasn't random. Instead, the random number generator was called exactly once, when the application initialised, and then fixed in the Celery schedule.


Update text for Developer preview and Clone existing PVC

📝 Description
Update the popovers' text for the Developer preview label and for Clone existing PVC checkbox in Add volume to boot from modal window, according to the design updates.
🎥 Screenshots
Before:
Developer preview label:

Clone existing PVC checkbox:

After:

/lgtm


Add delete functionality to ProfileAPI

The ProfileApi, which implements the ProfileManager interface, currently has the ability to:

Create a Profile
Get a specific Profile
List all Profiles

There currently isn't a way to delete a profile. The various agents (desktop & mobile) will allow users full management over their profiles, including the option to delete them.
This PR adds in this delete functionality, and adds a test around the functionality to make sure it works as expected.

Package and ProfileApi have been removed/refactored.


modules.resolved: Enhance by upstream options

Motivation for this change
Currently it is not possible to set options in resolved.conf.
I added all official options that are supported - hopefully with sane defaults, using current nixos options where possible (I'm not entirely sure about the domains option, should this use search or domain or a mix of both?)
See man resolved.conf
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

CC: @edolstra if you find the time
I intentionally did not break the lines in the descriptions since these are used inside the manual and shown by nixos-option.

The option  services.resolved.dns seems superfluous given that we have networking.nameservers.

Anything I can do to get this merged? I'm pretty sure this is non-breaking and backwards compatible.


Ivy

@travist I debugged the issue with Ivy today.
The auth, manager, grid, and resource modules are packed individually but contain references for each other, eg. manager imports auth. Ivy detects the modules as standalone packages and tries to manage async, but it reaches auth through manager as well, then throws an error since there is a lock file indicates it already processing it.
The solution would be re-structuring the lib to having only 1 entry point for each module for Ivy.

Thanks for this @merobal!  We will add this to our developer backlog.

Do you have any update/plans related to Ivy?

This item has been resourced. We will let you know once this has been resolved.

do you have any update?

@merobal, thanks for reaching out. This item is on one of our developers list. We will let you know once this issue has been resolved.

couple of months later, any update on Ivy support?

Hello @chaixdev, This item is still on our developer's list. We will let you know once this issue has been resolved.

Hello, sorry to bother you guys ... any update on Ivy support yet?
Thanks!

Hello, sorry to bother you guys ... any update on Ivy support yet?
Thanks!

This maybe fixed with our latest upgrade @ @formio/angular repo. Have you tried that version @arjel?

This maybe fixed with our latest upgrade @ @formio/angular repo. Have you tried that version @arjel?

@travist I tried on v4.11.0 and still had problems. I can try to update/reinstall and see if it's ok. Thank you!

@travist I tried on v4.11.0 and still had problems. I can try to update/reinstall and see if it's ok. Thank you!

Hey guys. Just found this issue. Just reporting that it is a major showstopper for us and a decision-maker or breaker when considering this library.
(Just mentioning because if I was maintaining then I'd like to know why people are using/non using my library)

Hey,
Just tried to upgrade to Angular 12, and we're now forced to use Ivy.... How far is the implementation of Ivy support @travist ?
When building our project we receive errors like:
Error: Tried to write C:/**/node_modules/angular-formio/formio.config.d.ts.__ivy_ngcc_bak with an ngcc back up file but it already exists so not writing, nor backing up, C:/**/node_modules/angular-formio/formio.config.d.ts.
This error may be caused by one of the following:
* two or more entry-points overlap and ngcc has been asked to process some files more than once.
  In this case, you should check other entry-points in this package
  and set up a config to ignore any that you are not using.
* a previous run of ngcc was killed in the middle of processing, in a way that cannot be recovered.
  In this case, you should try cleaning the node_modules directory and any dist directories that contain local libraries. Then try again.

Though the application builds and is able to run.
Besides these errors we are experiencing problems with emitting updated data through the FormioBaseComponent.refresh event.

@travist Has support for angular been dropped?

@JonasDev99 No. Are you receiving the above errors or just asking generally?

Ticket for internal tracking: FIO-3190


Fix IE11 compatibility, stop using Array.from

See #69.
Verified that this now works in IE11 / Windows 8 in Virtualbox.
Before/after screenshots:

@okize could I trouble you to get npm publish access so I can create a release for this?

@kevinsqi what's your NPM username?

kevinqi (https://www.npmjs.com/~kevinqi)


Slider not Sync'ing to input box when using nzRange

Reproduction link
https://angular-8phaxs.stackblitz.io
Steps to reproduce
Try updating the input box and see if the slider changes.
What is expected?
Dragging the slider updates the inbox box and updating the input box updates the slider. They should be in sync.
What is actually happening?
Dragging the slider will update the input box, but editing the input box won't update the slider.

Environment
Info

ng-zorro-antd
11.1.0

Browser
Chrome

Still not update on this. Another issue that renders the component unusable for production projects.


Update README.md to point to latest Karma docs

It's "always" bothered me that a Google search for "karma requirejs" brings up a link to the Karma 0.8 docs, and then I went to the Github project page and the README links to the 0.8 docs too.
Fixed the link to point to the current Karma docs :)

Never mind, just noticed this is a dupe :|


core: Remove usage of mutable global state

It may be a warning in the future. So, use the hash value of the input AST instead of PRNG.
See https://github.com/rust-lang/rust/pull/64398#issuecomment-533186558 and https://github.com/rust-lang/rust/pull/63831.

bors r+


Failed to publish bot with LUIS from behind a firewall

Describe the bug

I use the Bot Framework Composer on the Windows PC with a corporate firewall.
I already set up proxy configuration as environmental variables below:
HTTPS_PROXY=http://<IP_ADDRESS>:3128
HTTP_PROXY=http://<IP_ADDRESS>:3128
NO_PROXY=localhost

So most communication has no problem, but publishing the bot with LUIS is always failed with getaddrinfo EAI_AGAIN error. The error message is below:

Sorry, something went wrong with publishing. Try again or exit out of this task.
request to https://westus.api.cognitive.microsoft.com/luis/authoring/v3.0-preview/apps/import?appName=ToDoBotWithLuisSample-0(composer)-additem.en-us.lu failed, reason: getaddrinfo EAI_AGAIN westus.api.cognitive.microsoft.com

I think the cause is not to go through the proxy when communicating with the LUIS API.
I think getaddrinfo should not be called on the environment behind a proxy.
Version

Bot Framework Composer

Version:  1.0.2
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Browser

[x] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[x] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Set up proxy configuration as environmental variables on the PC with a corporate firewall
Run the Bot Framework Composer on the PC
Create bot from "Todo with LUIS" template
Click [Start Bot]
Set valid LUIS Authoring key (or any dummy string) on the [Publish LUIS models] dialog, then click [OK]
See error

Expected behavior

The publish will succeed.
(or failed due to the dummy Authoring key)
Screenshots

Additional context

@v-kydela can you or someone from support engage on this please?

I'll try and see if I can reproduce. Can you please run the following from a shell on the Windows machine and share the results?
netsh winhttp show proxy

I'm sorry for my late reply (due to some trouble with my account).
Here is the result:
>netsh winhttp show proxy

Current WinHTTP proxy settings:

Proxy Server(s) : <IP_ADDRESS>:3128
Bypass List : <local>;xxxxxx;yyyyy

The same proxy server is also set in Internet Options.

Ok, thanks. I'm investigating further.

Hi @soappp Sorry for the delay in response on this.
Can you please see if this reproduces with the stable version 1.1.1.?
When I setup a proxy, then supply a dummy string, I get:

Sorry, something went wrong with publishing. Try again or exit out of this task.
Access denied due to invalid subscription key or wrong API endpoint. Make sure to provide a valid key for an active subscription and use a correct regional API endpoint for your resource.

With a valid LUIS auth endpoint key, I have no failure and can see the traffic in my proxy:

@dmvtech Thank you for your reply.
I updated my Bot Framework Composer to v1.1.1 and tried to publish the sample bot with LUIS.
I got another error message and the publishing task was aborted.

Sorry, something went wrong with publishing. Try again or exit out of this task.
Cannot find module 'https-proxy-agent' Require stack: - C:\Program Files\Bot Framework<EMAIL_ADDRESS>- C:\Program Files\Bot Framework<EMAIL_ADDRESS>- C:\Program Files\Bot Framework<EMAIL_ADDRESS>- C:\Program Files\Bot Framework Composer\resources\app.asar.unpacked\build\plugins\azurePublish\lib\luisAndQnA.js - C:\Program Files\Bot Framework Composer\resources\app.asar.unpacked\build\plugins\azurePublish\lib\deploy.js - C:\Program Files\Bot Framework Composer\resources\app.asar.unpacked\build\plugins\azurePublish\lib\index.js - C:\Program Files\Bot Framework<EMAIL_ADDRESS>- C:\Program Files\Bot Framework<EMAIL_ADDRESS>- C:\Program Files\Bot Framework<EMAIL_ADDRESS>- C:\Program Files\Bot Framework Composer\resources\app.asar\build\main.js -

@soappp Thank you. I realized, that in my test, if something (for some reason) doesn't go through my proxy, it will still work (since I don't have a firewall/etc shutting that request down). I'm going to have to try and figure out how to test/handle for that.
Thank you for trying v1.1.1. I'll keep investigating.

@dmvtech do you have any post-investigation updates? Thanks!

So, I have a bit more info, but no smoking gun.
I thought again about my previous attempt, and while I didn't see any errors, I realized I wasn't seeing any calls in Fiddler to LUIS/cognative endpoints.
I fixed some configuration issues on my end and confirmed that both the wininet and winhttp proxies were set to use Fiddler (more info here):

Current WinHTTP proxy settings:

    Proxy Server(s) :  http=<IP_ADDRESS>:8888;https=<IP_ADDRESS>:8888
    Bypass List     :  <-loopback>

After getting this all set up, what witness is that I do not see (what I would expect or assume to), any calls to the authoring endpoint. Nothing for the publishing to *.api.cognitive.microsoft.com. But I do see them once the bot is published and I am testing in Emulator to make calls to the prediction endpoint:

So, my assumption is that the bit of code that does the publishing is making calls to do so, that is not utilizing either wininet or winhttp proxy. The calls to the prediction endpoints is being done by the webapp runtime and that is using those proxies.
I think this is the reason it works for me and not for @soappp. Ok...it should work for me even if I did see it in Fiddler. But since @soappp has an environment that blocks anything that doesn't go through the proxy, then he's going to see a failure. I tried playing with options to try and give myself a similar failure, but was unable to do so.
@cwhitten Who might be a good resource to know about this area of composer to see if we can narrow this down further?

@luhan2017 let's take an item to investigate network activity to LUIS when publishing the models from Composer when a proxy is configured.

@cwhitten This is a nodejs proxy issue, I was investigating a similar proxy issue with credit-suisse recently, we sent a private electron to them to verify if the solution works, once verified, we will submit a PR in composer to support the nodejs proxy feature.
@soappp , please let me know if you want to try out our private electron, I can send you the exe and the steps to enable proxy for composer. Thanks.

@soappp ， the customer helped verify the proxy setting worked for luis publish, but we still have some issue when retrieve the azure publish status, still working with them, please let me know if you want to try out our private exe, since it will take some time for the PR.

@luhan2017 I'm sorry I didn't notice your previous mention.
Thank you very much for your work and kind suggestion.
I'm not in a hurry about this issue, so I think I can wait until this issue is officially fixed.

@luhan2017,
Is this issue resolved? If so can you close. If not can you drive this to completion?

@feich-ms Let's sync offline on this, after some investigation, we found that we'd better support the proxy settings from the bf cli side. Then composer can leverage the capability.

Looks like there is an ongoing effort to resolve this issue.
@luhan2017 please update this bug when R13 planning is done.

@feich-ms Let's sync offline on this, after some investigation, we found that we'd better support the proxy settings from the bf cli side. Then composer can leverage the capability.

@luhan2017 Could you please help me as well support the proxy settings from the bf cli side. I am facing the exact same failure while publishing LUIS from composer and I am behind corporate network firewall #7543.

Should be fix by the proxy feature.


TokenListValidator

New method in HybridEditorSpec: TokenListValidator getTokenListValidator()
TokenListValidator: void validate(List tokenList). In this method we make sure that the token list stays valid
Removed completer parameter in tokenCompletion.getTokenCompletion()
Removed completer.completeTerminatorToken()
Now there is no need in the built-in TerminatorToken

Dependent pull requests:
JetBrains/jetpad-ot#52
JetBrains/datapad#8

Is it ok to use TokenListValidator to get proper spacing for SimpleHybridEditor? In this case we could  simplify flow in TokenListEditor so it doesn't reprint what it just parsed and relies on TokenListValidator to get spacing right.

The idea was to use it for lexer level validation. The proper spacing could be difficult to obtain without parsing which we use during the reprint.

TokenListValidator which silently modifies the tokens list doesn't seem good. More significant name would be better. TokenListUpdater?.. TokensCompletionTransformer?

We decided to call it TokensCorrector in the next pull request


Is it possible to fetch Id token using this crate?

Java, go, node and Python can fetch id token from GoogleCredentials.
Is it possible to support this feature in gcloud-sdk-rs?
There are some reference implementations available

Java: https://github.com/googleapis/google-auth-library-java/blob/b152e76386c54e5682969f4ba5157f4bc20e7fb5/oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java#L566
golang: https://github.com/googleapis/google-api-go-client/tree/main/idtoken
node: https://github.com/googleapis/google-auth-library-nodejs/tree/3563c16e2376729e399fefc0b1fad7bff78c296e/src/auth

https://cloud.google.com/docs/authentication/get-id-token

Hey, as your links also mentioned, there are different options to get ID token.
The first (which is already available in the released version of this library) is using Generate an ID token by impersonating a service account:
    let client: GoogleApi<IamCredentialsClient<GoogleAuthMiddleware>> = GoogleApi::from_function(
        IamCredentialsClient::new,
        "https://iamcredentials.googleapis.com",
        // cloud resource prefix: used only for some of the APIs (such as Firestore)
        None,
    )
    .await?;

    // Option 1: using service account impersonation
    let resp = client
        .get()
        .generate_id_token(tonic::Request::new(GenerateIdTokenRequest {
            name: format!(
                "projects/-/serviceAccounts/{}",
                std::env::var("SERVICE_ACCOUNT")?
            ),
            audience: "test-aud".to_string(),
            ..Default::default()
        }))
        .await?;

The second option is to use Metadata server but it will work only on GCP.
Unfortunately, this option wasn't available before my latest changes in master (https://github.com/abdolence/gcloud-sdk-rs/pull/82), but you can try it with the master branch.
Hope this helps

The second option is now available starting with https://github.com/abdolence/gcloud-sdk-rs/releases/tag/v0.20.3
Feel free to reopen this if you see something missing or issues.


Go back to using VS Code's tab close icons

We'll use VS Code's tab close icons for this release since we still need to figure out what the right UX is for inactive icons that have changes
Now:

Before:

@MattIrv I'll merge to get the release branch ready for the next build.


[MINOR] Add spark 3.4.x and 3.5.x options in Github issue

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested.


Architecture Support: PPC64

As MQ can be deployed on Power systems, I believe useful functionality for mq-ansible would be
to install MQ on PPC-based systems.
An extension of https://github.com/ibm-messaging/mq-ansible/issues/63.

I do not have permission to assign people to this work, however, I believe @parker57 will be delivering this work.

Yeah I'd like to be assigned, I've made some progress on my fork


Store multiple snapshot data within single tables

Forseti for every run creates new set of tables. Partitioning tables by snapshot time seems to be a bad design.
We wanted to create a dashboard in Data Studio to visualise current violations and their history. We've failed as we're not able to create a single view with violations from last run. It seems that MySQL doesn't support querying dynamic table names in views. It's supported only in Prepared statements and Stored Procedures.
Additionally large number of tables results in UI problems like listing all the tables, etc.

Forseti 2.0 now stores multiple inventory in a single gcp_inventory table.  @marcin-kolda, would be interested to see the type of reports that you generate.


Upgrade to NextJS 12

NextJS 12 drastically improves refresh and build times for faster dev feedback. Also, adds support for React 18.

Fixed in #76


Fails to link cargo (library order error between curl and ssh2)

When running make -f minicargo.mk output/cargo, one of the commands mrustc 0.9 tries to run is:
"x86_64-linux-gnu-gcc" "-ffunction-sections" "-pthread" "-O2" "-g" "-fPIC" "-o" "output/cargo-build/cargo" "output/cargo-build/cargo.c" "output/cargo-build/libvec_map-0_8_1.rlib.o" "output/cargo-build/libutf8_ranges-1_0_0.rlib.o" "output/cargo-build/liburl-1_7_1.rlib.o" "output/libunwind.rlib.o" "output/cargo-build/libunreachable-1_0_0.rlib.o" "output/cargo-build/libunicode_xid-0_1_0.rlib.o" "output/cargo-build/libucd_util-0_1_1.rlib.o" "output/cargo-build/libtoml-0_4_6.rlib.o" "output/cargo-build/libthread_local-0_3_5.rlib.o" "output/cargo-build/libtextwrap-0_10_0.rlib.o" "output/cargo-build/libtermcolor-1_0_1.rlib.o" "output/cargo-build/libsynstructure-0_9_0.rlib.o" "output/cargo-build/libstrsim-0_7_0.rlib.o" "output/cargo-build/libregex_syntax-0_5_6.rlib.o" "output/cargo-build/libunicode_width-0_1_5.rlib.o" "output/cargo-build/librustc_demangle-0_1_8.rlib.o" "output/cargo-build/libwalkdir-2_1_4.rlib.o" "output/cargo-build/libglob-0_2_11.rlib.o" "output/cargo-build/libglobset-0_4_0.rlib.o" "output/cargo-build/libgit2_curl-0_8_1.rlib.o" "output/cargo-build/libcrates_io-0_18_0.rlib.o" "output/cargo-build/libhome-0_3_2.rlib.o" "output/cargo-build/libforeign_types_shared-0_1_1.rlib.o" "output/cargo-build/liblibc-0_2_43.rlib.o" "output/cargo-build/libsame_file-1_0_2.rlib.o" "output/cargo-build/libfiletime-0_2_1.rlib.o" "output/cargo-build/libfailure-0_1_2.rlib.o" "output/cargo-build/libsyn-0_14_4.rlib.o" "output/cargo-build/libjobserver-0_1_11.rlib.o" "output/cargo-build/libflate2-1_0_1.rlib.o" "output/cargo-build/libdtoa-0_4_3.rlib.o" "output/cargo-build/libgit2-0_7_3.rlib.o" "output/libproc_macro.rlib.o" "output/cargo-build/libtermcolor-0_3_6.rlib.o" "output/cargo-build/liblibssh2_sys-0_2_11.rlib.o" "output/libpanic_abort.rlib.o" "output/cargo-build/libatty-0_2_11.rlib.o" "output/cargo-build/libcrypto_hash-0_3_1.rlib.o" "output/cargo-build/libidna-0_1_5.rlib.o" "output/cargo-build/libvoid-1_0_2.rlib.o" "output/cargo-build/libquote-0_6_3.rlib.o" "output/cargo-build/libforeign_types-0_3_2.rlib.o" "output/cargo-build/liblazycell-1_0_0.rlib.o" "output/cargo-build/libenv_logger-0_5_10.rlib.o" "output/cargo-build/libbacktrace-0_3_9.rlib.o" "output/libcore.rlib.o" "output/cargo-build/libhumantime-1_1_1.rlib.o" "output/cargo-build/libansi_term-0_11_0.rlib.o" "output/cargo-build/librustfix-0_4_2.rlib.o" "output/liballoc_system.rlib.o" "output/cargo-build/libtar-0_4_16.rlib.o" "output/cargo-build/libopenssl_probe-0_1_2.rlib.o" "output/cargo-build/libregex-1_0_1.rlib.o" "output/cargo-build/libhex-0_3_2.rlib.o" "output/cargo-build/libcfg_if-0_1_4.rlib.o" "output/cargo-build/libregex-0_2_11.rlib.o" "output/cargo-build/libremove_dir_all-0_5_1.rlib.o" "output/liballoc.rlib.o" "output/cargo-build/libcurl-0_4_13.rlib.o" "output/cargo-build/libquick_error-1_2_2.rlib.o" "output/cargo-build/libbitflags-1_0_3.rlib.o" "output/cargo-build/libfs2-0_4_3.rlib.o" "output/cargo-build/libbacktrace_sys-0_1_24.rlib.o" "output/cargo-build/libtempfile-3_0_2.rlib.o" "output/cargo-build/libcargo-0_30_0.rlib.o" "output/cargo-build/libclap-2_32_0.rlib.o" "output/cargo-build/libcrossbeam-0_3_2.rlib.o" "output/cargo-build/libcurl_sys-0_4_12.rlib.o" "output/cargo-build/liblog-0_4_3.rlib.o" "output/cargo-build/libmatches-0_1_7.rlib.o" "output/cargo-build/libcrossbeam_utils-0_5_0.rlib.o" "output/cargo-build/librand-0_4_2.rlib.o" "output/cargo-build/libignore-0_4_2.rlib.o" "output/cargo-build/libitoa-0_4_2.rlib.o" "output/liblibc.rlib.o" "output/cargo-build/liblibz_sys-1_0_23.rlib.o" "output/cargo-build/libmemchr-2_0_1.rlib.o" "output/cargo-build/libminiz_sys-0_1_10.rlib.o" "output/cargo-build/libopenssl-0_10_11.rlib.o" "output/cargo-build/libaho_corasick-0_6_6.rlib.o" "output/cargo-build/libopenssl_sys-0_9_35.rlib.o" "output/cargo-build/libpercent_encoding-1_0_1.rlib.o" "output/cargo-build/libproc_macro2-0_4_8.rlib.o" "output/cargo-build/libshell_escape-0_1_4.rlib.o" "output/cargo-build/libregex_syntax-0_6_1.rlib.o" "output/cargo-build/libsemver-0_9_0.rlib.o" "output/cargo-build/liblibgit2_sys-0_7_9.rlib.o" "output/cargo-build/libsemver_parser-0_7_0.rlib.o" "output/cargo-build/libnum_cpus-1_8_0.rlib.o" "output/cargo-build/libserde-1_0_70.rlib.o" "output/cargo-build/liblazy_static-1_0_2.rlib.o" "output/cargo-build/libunicode_normalization-0_1_7.rlib.o" "output/cargo-build/libfnv-1_0_6.rlib.o" "output/cargo-build/libserde_ignored-0_0_4.rlib.o" "output/cargo-build/libsocket2-0_3_7.rlib.o" "output/cargo-build/libserde_json-1_0_24.rlib.o" "output/cargo-build/libunicode_bidi-0_3_4.rlib.o" "output/libstd.rlib.o" "-L" "output" "-L" "output/cargo-build" "-L" "/build/mrustc-0.9/output/cargo-build/build_libssh2-sys/build" "-L" "/build/mrustc-0.9/output/cargo-build/build_backtrace-sys" "-L" "/usr/lib/x86_64-linux-gnu" "-L" "/build/mrustc-0.9/output/cargo-build/build_miniz-sys" "-L" "/build/mrustc-0.9/output/cargo-build/build_libgit2-sys/build" "-l" "util" "-l" "util" "-l" "ssh2" "-l" "backtrace" "-l" "curl" "-l" "util" "-l" "util" "-l" "c" "-l" "m" "-l" "rt" "-l" "pthread" "-l" "z" "-l" "miniz" "-l" "ssl" "-l" "crypto" "-l" "git2" "-l" "dl" "-l" "rt" "-l" "pthread" "-Wl,--gc-sections"

On my system this fails with:
/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libcurl.so: undefined reference to symbol 'libssh2_userauth_publickey_fromfile_ex'
/usr/bin/ld: //lib/x86_64-linux-gnu/libssh2.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

It is almost correct though. The -l flags there at the end are:
"-l" "util"
"-l" "util"
"-l" "ssh2"
"-l" "backtrace"
"-l" "curl"
"-l" "util"
"-l" "util"
"-l" "c"
"-l" "m"
"-l" "rt"
"-l" "pthread"
"-l" "z"
"-l" "miniz"
"-l" "ssl"
"-l" "crypto"
"-l" "git2"
"-l" "dl"
"-l" "rt"
"-l" "pthread"

Adding (another) "-l" "curl" immediately before the "-l" "ssh2" fixes the problem and links successfully.
Is this something that would need to be fixed in mrustc, in Cargo or its dependencies, or somewhere else?

Hi, I'm having the same issue as #140 while building in my build environment.
Is there a nice workaround for this issue like a temporary patch so that I could change the library order automatically?
In what file should the library order be changed?

It looks like the problem occurs in the function finalise in src/trans/codegen_c.cpp
The function .push_back functions that created the vector with library names should occur in the right order.
I created a local patch (workaround) that skips the library if the name is ssh2 and when the name is libgit2, it adds ssh2 to the vector as well.

I've meant to look up what linker arguments rustc uses to avoid the same issue.
It's not an explicit error in codegen_c.cpp (I think?) it's just that linker argument ordering matters.

Would --start-group and --end-group be a "good" temporary workaround?

Yes... may not end up being temporary either :)
My only worry is if it increases the already-long link times.

Could using lld help too? They seem to have always handled that sort of stuff (even for static libs) without issue, and it's a faster linker anyways.

Interesting - My test builds have objects in a different order, which implies that there's some non-determininisim involved in the linker order (maybe an unordered_map)

Confirmed: The list used to create the library link section of the final command is an unordered_map, so has a functionally random order.
Working on a version that makes the link order determinisitc (and correct).

Probable fix committed in f89824b5bfb6902dff93f63cc146f3b5b247833a

@dtolnay Can you confirm that the above fix solved the issue for you?

--start-group is not supported by ld on macOS.
ld: unknown option: --start-group
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@arlosi Is there an alternative that has the same effect?

@thepowersgang macOS uses its own linker which doesn't support hints. WebAssembly is using ldd.... which also doesn't support hints :)
The simplest way to bring hints to macOS is switch to ld from binutils. Unfortunately it doesn't support mach-o. Or at least it didn't a couple years ago.

lld doesn't need --start-group and --end-group. It allows back references without. Rustc skips --start-group and --end-group on macOS and wasm. https://github.com/rust-lang/rust/blob/e069a711084b5617aecda7a5c8e88406ca12ed65/compiler/rustc_codegen_ssa/src/back/linker.rs#L258-L266

@bjorn3 I expect that it simple keeps order of provided arguments. To be honest: a few times when I needed it, it works like that. But I never try to answer why.

e2a759a1562d44bf9096252ee47a4f06a070de16 moved --start-group/--end-group to the target-specific options (so shouldn't be used for macos).


Invalid prop type for content StaticElement

Environment
vite 5.1.3
vue 3.4.19
vueform/vueform:1.8.0
theme: vueform
Reproduction
I would like to use a Function for the content prop, but only Object or String are allowed. Using a function works but vue generate some pesky warnings in dev, about prop type check failure.
Could the type Function be added to the allowed types?
Describe the bug
Unecessary warnings in dev consoles
Additional context
No response
Logs
runtime-core.esm-bundler.js:44 [Vue warn]: Invalid prop: type check failed for prop "content". Expected String | Object, got Function
  at <StaticElement type="static" wrap=false  ... >

Yes, indeed no more pesky warnings! Thank you very much for the prompt resolution


blockchain polkadot substrate kusama

https://www.substrate.io/
https://polkadot.network/polkadot-ambassador-program/
https://www.substrate.io/seminar/
https://substrate.dev/recipes/
https://polkadot.network/Polkadot-lightpaper.pdf
https://wiki.polkadot.network/
https://mooc.web3.foundation/
https://polkadot.network/explaining-the-polkadot-launch-process/
https://polkadot.network/kusama-polkadot-comparing-the-cousins/

http://www.polkaproject.com
http://polkadefi.acala.network/
https://forum.web3.foundation/t/teams-building-on-polkadot/67
https://twitter.com/bkchr/status/1271179142122307586?s=20
https://twitter.com/polkadotnetwork/status/1270752671566385157?s=20
https://cointelegraph.com/news/exclusive-gitcoin-and-polkadot-cooperate-to-bring-new-developers-to-blockchain
XCMP https://wiki.polkadot.network/docs/en/learn-crosschain#docsNav
Centrifuge, Chainlink, Chainx, InterlayHQ, Laminar, and Plasm

https://codingnconcepts.com/post/blockchain-explained/

register for the app at https://digitalvaluecapture.com/
Guide link: http://bit.ly/ProblemBusterGuide


401 response increases counter http_requests_total{status="5xx"}

I have a FastApi application with a middleware to have a small level of security:
@app.middleware("http")
async def machine_key_validation(request: Request, call_next):
    valid = False //always false for the sake of this example
    if(not valid):
        raise HTTPException(status_code=401, detail="Not authenticated")
    return await call_next(request)

I just noticed that when it throws the 401 http exception, the http_requests_total{status="5xx"} counter gets increased, instead of http_requests_total{status="4xx"}
To give the full context, I also have changed the exception handlers so that I could return a custom message:
@app.exception_handler(HTTPException)
def http_exception_handler(request: Request, exc: HTTPException):
    return error_handler(request, exc)

@app.exception_handler(Exception)
def internal_server_error_handler(request: Request, exc: Exception):
    return error_handler(request, exc)

def error_handler(request: Request, exc: Exception):
    status_code = getattr(exc, "status_code", 500)
    exception_content = getattr(exc, "detail","Oops! Something went wrong on our side...")
    trace_id = getattr(request.state, "trace_id", None)
    if(trace_id):
        span_context = SpanContext(trace_id=trace_id, span_id=5213367945872657620,is_remote=True, trace_flags=TraceFlags(0x01))
        ctx = trace.set_span_in_context(NonRecordingSpan(span_context))
        trace_id = hex(trace_id)[2:]

    with trace.get_tracer(__name__).start_as_current_span("error_span", context=ctx) as span:
        span.set_attribute("http.status_code",status_code)
        return JSONResponse(
            status_code=status_code,
            content={"detail": exception_content, "trace_id": trace_id},
        )

This sounds like a bug somewhere in the middleware/wherever you increment the metrics. This client does not have any specific HTTP monitoring logic.


option to not auto-add tolerations

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?
looking at a pod (kubectl get pod -o yaml) for a step in a workflow i see it has these tolerations added:
  tolerations:
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 300
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 300

this can cause issues (unschedulable) where a step/pod is being assigned to a new node that is not ready ie https://github.com/aws/amazon-vpc-cni-k8s/issues/2808 where it flicks between ready/notready and back to ready
Version
3.5.6
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
n/a

Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

n/a

Logs from in your workflow's wait container
kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

n/a

I don't think Argo ever sets its own tolerations, only the ones that you specify. There's only one place in the code that they're added too

turns out to be a k8s default https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/#taint-based-evictions "Note:
Kubernetes automatically adds a toleration for node.kubernetes.io/not-ready and node.kubernetes.io/unreachable with tolerationSeconds=300, unless you, or a controller, set those tolerations explicitly.
These automatically-added tolerations mean that Pods remain bound to Nodes for 5 minutes after one of these problems is detected."
perhaps docs should mention overwriting this

perhaps docs should mention overwriting this

Tolerations are only mentioned in the Fields Reference, where they directly inherit from k8s, so have no Argo specific behavior nor Argo specific docs.


[WIP] Implement all the things

This is a work in progress to close issue #1

:+1: for this. I think this will be a viable alternative to xstream, combining the best of most and it.

@eshansingh I'm not really ready to share yet, so please keep this a bit quiet :)

Ok, I understand.

LGTM


Upgrading 1.2.0 to 1.3.0 - logging pods fail with error="'ingest_api_tenant' parameter is required"

What happened:
Installed 1.3.0 the same way I installed 1.2.0 and previous releases:
helm install --name splunk-connect -f ${WELLTOK_ENVIRONMENT}-values.yml https://github.com/splunk/splunk-connect-for-kubernetes/releases/download/1.3.0/splunk-connect-for-kubernetes-1.3.0.tgz
Logging pods fail with error:
fluentd -c /fluentd/etc/fluent.conf
2019-12-18 17:29:11 +0000 [info]: parsing config file is succeeded path="/fluentd/etc/fluent.conf"
/usr/local/bundle/gems/activesupport-<IP_ADDRESS>/lib/active_support/core_ext/object/duplicable.rb:111: warning: BigDecimal.new is deprecated; use BigDecimal() method instead.
2019-12-18 17:29:12 +0000 [error]: config error in:
<match **>
  @type splunk_ingest_api
  host "ip-10-52-46-109.ec2.internal"
  source_key "source"
  sourcetype_key "sourcetype"
  <fields>
    pod
    namespace
    container_name
    container_id
    cluster_name
  </fields>
  <buffer>
    @type memory
    chunk_limit_records 100000
    chunk_limit_size 200m
    flush_interval 5s
    flush_thread_count 1
    overflow_action block
    retry_max_times 3
    total_limit_size 600m
  </buffer>
  <format monitor_agent>
    @type json
  </format>
  <format>
    @type single_value
    message_key log
    add_newline false
  </format>
</match>

2019-12-18 17:29:12 +0000 [error]: config error file="/fluentd/etc/fluent.conf" error_class=Fluent::ConfigError error="'ingest_api_tenant' parameter is required"

What you expected to happen:
Splunk logging
How to reproduce it (as minimally and precisely as possible):
Install above.
Anything else we need to know?:
values file:
# This is an example of using insecure configurations
global:
  splunk:
    hec:
      token: <redacted>
      host: <redacted>
      port: 8088
      indexName: kubernetes-nonprod-logs
      # connection to splunk is insecure
      insecureSSL: true
  kubernetes:
    clusterName: tester1

splunk-kubernetes-logging:
  logs:
    kube-apiserver-audit:
      from:
        file:
          path: /var/log/kube-apiserver-tester1-audit.log
  kubernetes:
    clusterName: tester1

splunk-kubernetes-objects:
  # RBAC is disabled
  rbac:
    create: true
  splunk:
    hec:
      indexName: kubernetes-nonprod-objects
  kubernetes:
    # connection to kubernetes is insecure
    insecureSSL: true
    clusterName: tester1

splunk-kubernetes-metrics:
  # RBAC is disabled
  rbac:
    create: true
  # do not create service account
  serviceAccount:
    create: true
  splunk:
    hec:
      indexName: kubernetes-nonprod-metrics
  kubernetes:
    clusterName: tester1

Environment:

Kubernetes version (use kubectl version):
» kubectl version

Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.7", GitCommit:"6c143d35bb11d74970e7bc0b6c45b6bfdffc0bd4", GitTreeState:"clean", BuildDate:"2019-12-11T12:42:56Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.7", GitCommit:"6c143d35bb11d74970e7bc0b6c45b6bfdffc0bd4", GitTreeState:"clean", BuildDate:"2019-12-11T12:34:17Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Splunk version:

Splunk Enterprise
Version:
7.3.2
Build:
c60db69f8e32
Server:
wtsh1

Others:

Hello, it shouldnt have been interpreted to send log to ingest API. But somehow it is. Could you try with also setting splunk.hec values in logging as well as global?

ok, adding it to splunk logging too worked:
splunk-kubernetes-logging:
  logs:
    kube-apiserver-audit:
      from:
        file:
          path: /var/log/kube-apiserver-tester-audit.log
  kubernetes:
    clusterName: tester
  splunk:
    hec:
      token: <redacted>
      host: <redacted>
      port: 8088
      indexName: kubernetes-nonprod-logs
      # connection to splunk is insecure
      insecureSSL: true

There is still an issue here @chaitanyaphalak - we shouldn't have to define splunk.hec values in global and logging sections of a template.

This is still broken.  Duplicating (BAD!) the hec section for splunk-kubernetes-logging does fix the issue.  This is a workaround though, not a solution.  Please re-open this issue.

its fix has been added to 1.4.0 release. coming soon. Thank you.


Add option to remove duplicate icons

The code is a little messy but it gets the job done. I didn't know any Rust prior to this PR so I'm sure some things can be improved.
Essentially, this PR adds a new Config field called unique and makes it public all the way up the chain of structs, so that main.rs can read the value of config.match_config.unique and determine whether to remove duplicate icons.
In order to deduplicate the vector of icons, it first had to be sorted, so now the icons are not in any meaningful order anymore (when unique is true). In other words, applications open on the left or right side of the screen may have their icon on the wrong side of the workspace's name.
I mostly copied your code for the configuration file checks and it seems to work.

I was actually working on this earlier today, the main difference being that I was using this stackoverflow answer as a reference to avoid the sorting issue. Would've finished it too if I wasn't a rust noob :joy:

will this option be integrated?

Added deduplication already some time ago as cmdline argument: https://github.com/Lyr-7D1h/swayest_workstyle/commit/a52cdf66985f4e7d7586f8fc7cd7d9e9211e5439


Instant 400 Bad Request after ingress-nginx install

Hello!
I'm pretty new to the Kubernetes stuff, so I decided to go with k3s as my first cluster. I was using hetzner-k3s as in the docs here, but I'm not able to get ingress-nginx working properly. This probably is not an issue to be addressed here, but I didn't know where else to go 😩
Long story short:

I deploy cluster on Hetzner with 1 master and 1 worker node
I install ingress-nginx controller with Helm and annotations as in the docs
I curl http://cluster and get 400 Bad Request

I include my whole configuration below:
hetzner-k3s_cluster.yml
hetzner_token: xxx
cluster_name: candao-dev
kubeconfig_path: "./kubeconfig"
k3s_version: v1.28.3+k3s2
public_ssh_key_path: "~/.ssh/id_rsa.pub"
private_ssh_key_path: "~/.ssh/id_rsa"
use_ssh_agent: true
ssh_allowed_networks:
  - <IP_ADDRESS>/0
api_allowed_networks:
  - <IP_ADDRESS>/0
schedule_workloads_on_masters: false
masters_pool:
  instance_type: cx21
  instance_count: 1
  location: nbg1
worker_node_pools:
- name: small
  instance_type: cpx21
  instance_count: 1
  location: nbg1
- name: big
  instance_type: cpx31
  instance_count: 0
  location: nbg1
  autoscaling:
    enabled: true
    min_instances: 0
    max_instances: 1

✅  and I created cluster using: hetzner-k3s create --config candao-hetzner-k3s_cluster.yml - no errors
ingress-nginx-annotations.yaml
controller:
  kind: DaemonSet
  nginxDebug: true
  logLevel: 3
  service:
    annotations:
      load-balancer.hetzner.cloud/location: nbg1
      load-balancer.hetzner.cloud/name: candao-dev
      load-balancer.hetzner.cloud/use-private-ip: true
      load-balancer.hetzner.cloud/uses-proxyprotocol: true
      load-balancer.hetzner.cloud/hostname: domain.com
      load-balancer.hetzner.cloud/http-redirect-https: false

✅ and I installed the ingress-nginx using helm: helm upgrade --install ingress-nginx ingress-nginx/ingress-nginx -f ./ingress-nginx-annotations.yaml --namespace ingress-nginx --create-namespace - no errors - Load Balancer in Hetzner was created, all services are healthy, POD is up and running, everything looks just fine
I also tried to deploy a simple hello application
hello.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: hello-world
  labels:
    app: hello-world
spec:
  replicas: 1
  selector:
    matchLabels:
      app: hello-world
  template:
    metadata:
      labels:
        app: hello-world
    spec:
      containers:
        - name: hello-world
          image: rancher/hello-world
          ports:
          - containerPort: 80
          resources:
            limits:
              memory: "128Mi"
              cpu: "500m"
---
apiVersion: v1
kind: Service
metadata:
  name: hello-world
spec:
  selector:
    app: hello-world
  ports:
    - protocol: TCP
      port: 80
      targetPort: 80
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: hello-world
spec:
  ingressClassName: nginx
  rules:
  - host: hello.domain.com
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: hello-world
            port:
              number: 80

❌ and when I try to reach the cluster I get 400 error 😭
$ curl hello.domain.com

<title>400 Bad Request</title>

400 Bad Request

nginx

$ curl domain.com

<title>400 Bad Request</title>

400 Bad Request

nginx

I've tried to launch the nginx controller in debug mode, but I didn't find anything of use.
I include some logs from nginx controller pod
I1123 09:09:43.919508       8 ssl.go:536] "loading tls certificate" path="/usr/local/certificates/cert" key="/usr/local/certificates/key"
I1123 09:09:43.926391       8 nginx.go:260] "Starting NGINX Ingress controller"
I1123 09:09:43.933139       8 event.go:298] Event(v1.ObjectReference{Kind:"ConfigMap", Namespace:"ingress-nginx", Name:"ingress-nginx-controller", UID:"d675e878-74cc-4c1c-8c4e-df6706b633dc", APIVersion:"v1", ResourceVersion:"2213", FieldPath:""}): type: 'Normal' reason: 'CREATE' ConfigMap ingress-nginx/ingress-nginx-controller
I1123 09:09:45.128037       8 nginx.go:303] "Starting NGINX process"
I1123 09:09:45.128172       8 leaderelection.go:245] attempting to acquire leader lease ingress-nginx/ingress-nginx-leader...

I1123 09:19:45.146571       8 status.go:304] "updating Ingress status" namespace="default" ingress="hello-world" currentValue=null newValue=[{"ip":"<IP_ADDRESS>"},{"ip":"<IP_ADDRESS>"},{"ip":"2a01:4f8:1c1f:602c::1"}]
I1123 09:19:45.151985       8 event.go:298] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"default", Name:"hello-world", UID:"ac41dad6-4b16-4ba6-af9a-5cd3806f5513", APIVersion:"networking.k8s.io/v1", ResourceVersion:"4244", FieldPath:""}): type: 'Normal' reason: 'Sync' Scheduled for sync
<IP_ADDRESS> - - [23/Nov/2023:09:19:47 +0000] "PROXY TCP4 <IP_ADDRESS> <IP_ADDRESS> 38182 32763" 400 0 "-" "-" 0 0.000 [] [] - - - - cff604b28d5bc29a488c6a8114ac564b
<IP_ADDRESS> - - [23/Nov/2023:09:19:51 +0000] "PROXY TCP4 <IP_ADDRESS> <IP_ADDRESS> 24386 32763" 400 0 "-" "-" 0 0.000 [] [] - - - - b42f4ad3109a899d242472a9cdcf5250

Please 🙏🏻 if anyone could at least point me in some direction I would really appreciate.

Hi,
this is not an issue with hetzner-k3s, but a requirement for the ingress controller if you enable the proxy protocol on the load balancer in order to preserve the client IP address. You need to enable the proxy protocol in Nginx as well, otherwise you'll get that error. See https://github.com/vitobotta/hetzner-k3s/blob/main/wiki/Setting up a cluster.md at step 19.

I've reopened it and will convert it to a discussion since it's not a problem with my tool.


icedtea_web: 1.7.1 -> 1.8.3 (fixes CVE-2019-10185, CVE-2019-10181, CVE-2019-10182)

Use the new official repository on GitHub and build the new launcher written in
Rust.
Also fixes the following security vulnerabilities:

CVE-2019-10185: zip-slip attack during auto-extraction of a JAR file.

CVE-2019-10181: executable code could be injected in a JAR file without
compromising the signature verification.

CVE-2019-10182: improper path sanitization from  elements in JNLP
files.

References:
https://github.com/AdoptOpenJDK/IcedTea-Web/issues/327

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Manual testing:

download JNLP examples from https://docs.oracle.com/javase/tutorial/deployment/webstart/examplesIndex.html
run examples with ./result/bin/javaws <path to JNLP file>
verified that ./result/bin/itweb-settings launches with no errors
verified that ./result/bin/policyeditor launches with no errors

Notify maintainers
cc @grahamc (NixOS security team)

Note that this version of IcedTea-Web comes with a launcher written in Rust. I had to add a few patches to make this work and I don't know whether this can be achieved in a better way.

WFM non-nixos linux x86_64

@worldofpeace thanks for the suggestions.

Can we install the desktop items in postInstall ?

I can have a look, but FTR the main reason for the update was to patch the CVEs

Also we should update the homepage.

Well spotted, I will fix that.

I'm noticing there's attributes like adoptopenjdk-jre-bin. Perhaps we shouldn't touch this icedtea_web expression and add an adoptopenjdk-icedtea-web?

I am happy to add the adoptopenjdk-icedtea-web attribute, but I'd alias icedtea_web to it anyway. The existing 1.7 version is affected by serious CVEs and I'd rather get rid of it in master. I am working on backporting the patches for 1.7 on the 19.03 branch only.
Hope that this makes sense.

For reference: https://logs.nix.samueldr.com/nixos-security/2019-08-05

I see. However at the moment the package is defined in development/compilers/icedtea-web, should I rename the folder too?
In this case, I'd rather submit a new PR with the package name change.
So, should I go ahead and rename everything in this PR, or would it be better merge this PR with the CE fixes and have a new PR with the package rename?
My preference goes to the latter option, what do you think?

I'm fine going with your preference then.
The follow up should do the following:

rename the folder and attribute to adoptopenjdk-icedtea-web in all-packages.nix
any references to icedtea_web should be changed to the new attribute (there's only one)
add the alias in aliases.nix

icedtea_web = adoptopenjdk-icedtea-web; # added YYYY-MM-DD

I'm fine going with your preference then.

Cool. I will remove the alias and force-push then.
Thanks!

@GrahamcOfBorg build icedtea_web

I guess we should remove the has: package (new) label too?

I guess we should remove the has: package (new) label too?

ofborg will get that

Built this manually on aarch64-linux since you need allowUnfree and to accept the license.

Thanks for your well constructed PR @stefano-m, it was very easy to review.


(WIP) Initial implementation of a Terraform extension

Description
This is an initial experimental implementation of a Terraform extension for Zarf.  Below is an example package:
kind: ZarfPackageConfig
metadata:
  name: terraform
  description: Example terraform package to demonstrate the Zarf terraform extension

components:
  - name: terraform-loki
    required: true
    extensions:
      terraform:
        source: loki
        version: 1.5.2

Note this only collects terraform and any required modules.  It does not apply any terraform currently. (It is also very WIP and may be deleted).
Related Issue
Fixes #1482
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[ ] Test, docs, adr added or updated as needed
[X] Contributor Guide Steps followed

Closing as stale. However, true extensions and terraform support is still an eventual major feature.


Standalone node on PowerVS

This is a modified code of PR  https://github.com/ocp-power-automation/infra/pull/7

/assign @yussufsh @Prajyot-Parab

/cc @bpradipt @mkumatag

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, mkumatag, sudeeshjohn, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt,mkumatag,sudeeshjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Data not fetched when missing from cache, when revalidateOn* config set to false

There are some requests that I'm happy to fill the cache, and then always return the cached value without revalidating. However, I can't figure out the correct config to achieve this?
My understanding from #@sergiodxa's comment here: https://github.com/vercel/swr/issues/450#issuecomment-642280493
was that setting the revalidate config properties to false would enable data to be fetched when it is not present in the cache, and then not fetched again. However, this doesn't seem to be the case:
https://codesandbox.io/s/still-thunder-wq9df?file=/src/App.js
The following just always shows 'no data'.
import React from "react";
import useSWR from "swr";

export const App = () => {
  const { data, error, isValidating } = useSWR(
    "/api/user",
    async () => {
      console.log("fetching user");
      return { name: "Amy " + Math.random() };
    },
    {
      revalidateOnFocus: false,
      revalidateOnMount: false,
      revalidateOnReconnect: false
    }
  );

  if (error) return
failed to load {error}
;
  if (isValidating) return
validating...
;
  if (!data) return
no data...
;
  return
hello {data.name}!
;
};

Am I missing something? Thanks!

Also experiencing this. I'm just using revalidateOnMount: false and the hook never triggers the initial call.

That’s expected because you have enabled revalidateOnMount. It stops the initial fetch.

Is there no out of the box configuration for a single fetch and no revalidation? Not every fetch needs revalidation. I suppose one could use two different data-fetching hooks, but that seems unnecessary.

You can set revalidateOnMount to true and call mutate in an effect.
import React from "react";
import useSWR from "swr";

export const App = () => {
  const { data, error, isValidating, mutate } = useSWR(
    "/api/user",
    async () => {
      console.log("fetching user");
      return { name: "Amy " + Math.random() };
    },
    {
      revalidateOnFocus: false,
      revalidateOnMount: false,
      revalidateOnReconnect: false
    }
  );

  React.useEffect(() => {
    if (!data) mutate()
  }, [data, mutate]);

  if (error) return
failed to load {error}
;
  if (isValidating) return
validating...
;
  if (!data) return
no data...
;
  return
hello {data.name}!
;
};

That should trigger a fetch and update the cache, the function to be used to fetch is the fetcher you passed to useSWR.

If I understand it correctly, you want to do only 1 fetch then always use the cache, globally?
Although it can be done with some tricks, we don't recommend it because it can't ensure the freshness of the data when transitioning to a page.

SSR
Traditional SPA
SPA + Global Cache*
SWR

fresh data on transition
✅
✅
❌
✅

fast transition w/ cache
❌
❌
✅
✅

skeleton on transition
❌
✅
✅
✅

auto update
❌
❌
❌
✅

However if you still want it (global cache), what @sergiodxa shared can definitely work and you can make it a util too.

@shuding for our use case, we have data that we read where the records are static (think event log type data) - hence we want the caching benefit, but have no need to re-validate.
I'll go with @sergiodxa 's suggestion for now, thanks.

Gotcha! I'll close this issue for now.


hash roots benchmarks railgun

Can we create these as new circuits next to the old ones? Or how did you plan on doing a benchmark comparison for proving / verifying time?

Can we create these as new circuits next to the old ones? Or how did you plan on doing a benchmark comparison for proving / verifying time?

I was just gonna benchmark the original circuits on a different branch.


Type of stdlib types.coroutine is incorrect

Environment data

Language Server version: v2022.11.40
OS and version: Ubuntu 20.04
Python version (& distribution if applicable, e.g. Anaconda): 3.10

Code Snippet

import types

class A: pass
class B:
    b = None

@types.coroutine
def f():
    x: B = yield A()
    return x

async def g():
    b = await f()
    b.b # Cannot access member "b" for type "A"

Looks like the problem comes from types.coroutine having a wrong type. Pylance think it is
coroutine(func: (**_P@coroutine) -> Generator[R@coroutine, Any, Any]) -> ((**_P@coroutine) -> Awaitable[R@coroutine])

but actually it should be
coroutine(func: (**_P) -> Generator[Y, S, R]) -> ((**_P) -> Awaitable[R])

Note that R is the 3rd type parameter of Generator, not the 1st one.
For reference, here is the definition of Generator

The types.coroutine type definition comes from the typeshed project, so if you think that there's a bug in types.pyi, you can report the problem here. Pylance (and other Python static type analysis tools like mypy) consume the stubs from typeshed, so any fix would need to be done there.
Here's the type definition of coroutine in types.pyi currently:
def coroutine(func: Callable[_P, Generator[_R, Any, Any]]) -> Callable[_P, Awaitable[_R]]: ...

I think pylance is correctly applying this type definition.

Thanks for the redirection. Indeed, changing the relevant line in types.pyi fixes the problem.
(types.pyi is located at ~/.vscode-server-insiders/extensions/ms-python.vscode-pylance-2022.11.40/dist/typeshed-fallback/stdlib/types.pyi, In case someone might find it helpful)


Navigation with ui-router inside nested views broken in IE11

Create a view (a) and a nested view (a.1). Create a third location (b).
Create a ui-sref to b in a.1.
When going to a.1 in IE11, clicking on the link to b will lead to a "page not found", ie. a duplicate homepage.
This only blocks when using the html5Mode config enabled (which is the common usecase nowadays).
Blocks both on ui-sref or when in the controller doing a $state.go('b')
I am not sure yet if this is due to bugs in libraries (ui-router) or something goes wrong when using the YAML style magic.
Also my excuses for not showing any code, working on a seperate computer that has windows and IE...
Update:
So it seems things work nice in the end when removing another config item:
$http.defaults.xsrfCookieName = 'csrftoken';
I am a bit lost at what is happening.

So what is happening in the network trace on IE is that the location of the template is wrong. It should be abc.com/templates/template_b.html. Instead it asks for abc.com/a/1/templates/template_b.html.
Still scratching my head on this one...

Is it possible that the $http.get in the this.fromUrl ($TemplateFactory) is misbehaving? Everything seems fine and is identical between Chrome (where it works) and IE (where it breaks) up to that point.
Both have the relative url passed to $http.get, so without the base url.

Allright, so the one thing that seems to do the trick, is to put the  inside the  and NOT the .
Magic... also not sure if there is anything that should be done about this (and upstream or here?). Maybe mention this in the docs?


Update core.py

Fix link in dask.dataframe.read_parquet function docstring

[ ] Closes #xxxx
[ ] Tests added / passed
[ ] Passes pre-commit run --all-files

Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.


Implement the internal models for Concept and QualifiedConcept

A stepping stone to #1682. It’s based on the pattern established for AbstractAgent/Agent/Organisation.

That would be a good thing to do, but it's out-of-scope for this patch (and would need us to change Agent as well). Merging.


Migrate to new Sign In form

Background
This year, as part of our "Contribution Flow", we moved to new "Sign In" components. These one:

https://github.com/opencollective/opencollective-frontend/blob/master/src/components/SignIn.js
https://github.com/opencollective/opencollective-frontend/blob/master/src/components/SignInOrJoinFree.js

Problem
While we migrated the key areas where we're using the "Sign In" form, we still need to migrate a few places which are using the old ones:

https://github.com/opencollective/opencollective-frontend/blob/master/src/components/SignInUp.js
https://github.com/opencollective/opencollective-frontend/blob/master/src/components/SignInForm.js

Solution
Fix all places where the old form is still being used. For implementation, see for example how it is handled in the createOrder page. ie: https://opencollective.com/babel/donate
SignInForm

[ ] CreateExpenseForm ie: https://opencollective.com/babel/expenses/new (check non authenticated)
[ ] CreateCollective ie: https://opencollective.com/create (check non authenticated)
[ ] CreateOrganization ie: https://opencollective.com/organizations/new (check non authenticated)
[ ] EditCollective ie: https://opencollective.com/babel/edit (check authenticated)
[ ] complePledge ie: https://opencollective.com/pledges/38124 (check non authenticated)
[ ] CreateHost ie: https://opencollective.com/:collectiveSlug/connect/stripe (currently checking this one, maybe it should be killed, not fixed)

SignInUp

InterestedForm (this one should be killed, not fixed).

Before opening the PR

[ ] remove SignInForm.js
[ ] remove SignInUp.js
[ ] remove all helpers/components that were used in SignInForm.js/SignInUp.js  that are not used anymore

Final note
In all cases, the new Sign In Form needs to be properly centered and the design needs to look cleaner not worse than before. You're free and welcome to fix small details around it.

A $300 bounty was attached to this issue. Anyone submitting a Pull Request will be rewarded with $300 when the Pull Request is reviewed, accepted and merged. More info.

I forgot about an existing previous issue: https://github.com/opencollective/opencollective/issues/1676

Hey @znarf, I'd like to give this a shot. Can I get this assigned to me?

Ah, I started with this the other day just to see @yellowwoods12 is almost done with this now. Wish GitHub notifies me when an issue is assigned to someone :)

Oops, how did I unassign @yellowwoods12. I don't even have access to do that!

@tsriram Don't worry, maybe a GitHub bug. Fixed.

Thank you @yellowwoods12  ! It's merged.
An expense was already submitted to claim the bounty:
https://opencollective.com/engineering/expenses/8628


Password list: Auto login option

When a password is captured, it would be great if the login sequence (POST to specific addressee) could also be saved. On right click of a password we could add "Attempt auto login". It would then open the default browser with the given POST parameters and try to connect to that specific URL.

No, the feature is only meant for password recovery, nothing else.


Increase  buffer size for fluent bit - lines are too long, skipping file

Error message -
[input:tail:tail.0] file=/server.log requires a larger buffer size, lines are too long. Skipping file."
Root cause, is that the buffer size configured for fluent bit is too small, either this needs to be increased, or made configurable -
[INPUT]
Name        tail
Path        /home/logs/server/*.log
Db          /tmp/ng.db
Db.sync     Full
Tag         nginx-log
Buffer_Chunk_Size 320KB
Buffer_Max_Size   520KB

I'm getting the same error with application running on tomcat:
file=/usr/share/tomcat8/logs/app.log requires a larger buffer size, lines are too long. Skipping file.
Do we have a timeline to add this configuration?

Hi,
do we have any news about this issue ?
we have same problem with nextcloud log.
file=/var/log/nextcloud/nextcloud.log requires a larger buffer size, lines are too long. Skipping file.
Regards,

I'm closing this issue,  if you still observe the issue, please reopen it ;)


Handling non-ascii characters

Describe the bug
When sending a chat message with non-ascii characters, the cody agent binary raises an error.
To Reproduce
$ python main.py
--- Create Server Connection ---
--- Initialize Agent ---
--- Retrieve Chat Models ---
... print of models redacted ...
--- Create new chat ---
--- Set Model ---
--- Set context repo ---
--- Send message (short) ---
Human: tschüss, cody!
jsonrpc.ts: JSON parse error against input '{"jsonrpc":"2.0","id":7,"method":"chat/submitMessage","params":{"id":"a2ffa4d7-1d50-4f2e-83ec-49219c693ee9","message":{"command":"submit","text":"tschüss, cody!","submitType":"user","addEnhancedContext":false,"contextFiles":[{"type":"file","uri":{"fsPath":"/home/prinova/CodeProjects/CodyAgentPy/main.py","path":"/home/prinova/CodeProjects/CodyAgentPy/main.py"}},{"type":"file","uri":{"fsPath":"/home/prinova/CodeProjects/CodyAgentPy/codypy/logger.py","path":"/home/prinova/CodeProjects/CodyAgentPy/codypy/logger.py"}}]}}', contentLengthRemaining=0. Error:
SyntaxError: Unexpected end of JSON input
Traceback (most recent call last):
  File "/home/oriordan/github/codypy/main.py", line 118, in <module>
    asyncio.run(main())
  File "/opt/python/3.12/lib64/python3.12/asyncio/runners.py", line 194, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/opt/python/3.12/lib64/python3.12/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/python/3.12/lib64/python3.12/asyncio/base_events.py", line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/oriordan/github/codypy/main.py", line 89, in main
    response, context_files_response = await cody_agent.chat(
                                       ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/oriordan/github/codypy/codypy/agent.py", line 275, in chat
    result = await request_response(
             ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/oriordan/github/codypy/codypy/messaging.py", line 271, in request_response
    async for response in _handle_server_respones(reader):
  File "/home/oriordan/github/codypy/codypy/messaging.py", line 92, in _handle_server_respones
    response: str = await _receive_jsonrpc_messages(reader)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/oriordan/github/codypy/codypy/messaging.py", line 61, in _receive_jsonrpc_messages
    headers: bytes = await asyncio.wait_for(reader.readuntil(b"\r\n\r\n"), timeout=5.0)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/python/3.12/lib64/python3.12/asyncio/tasks.py", line 520, in wait_for
    return await fut
           ^^^^^^^^^
  File "/opt/python/3.12/lib64/python3.12/asyncio/streams.py", line 657, in readuntil
    raise exceptions.IncompleteReadError(chunk, None)
asyncio.exceptions.IncompleteReadError: 0 bytes read on a total of undefined expected bytes

Expected behavior
Ideally, unicode messages would be accepted by the cody agent binary and carried around appropriately.
Additional context
All messages (sent and received) are unicode, yet there is some encoding problem in Cody agent.
Non-ascii responses are arriving correctly, so that part works well.

Workaround: until this is fixed upstream, we can use unidecode to replace all non-ascii characters we send to the agent binary. This has been tested and works well.

issue fixed #11


fix path for tests

Tests should run correctly now without path errors

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ff5f437). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff            @@
##             master      #4   +/-   ##
========================================
  Coverage          ?   55.8%
========================================
  Files             ?       9
  Lines             ?     396
  Branches          ?       0
========================================
  Hits              ?     221
  Misses            ?     175
  Partials          ?       0


Revertir "Actualizar README.md"

This pull request includes a minor change to the README.md file. The change corrects the formatting by removing an unnecessary comment line.

README.md: Removed an unnecessary comment line to correct the formatting.Reverts naxoootcnjncgjnnxfhjjv/ton-api-v4#1

This pull request includes a minor change to the README.md file. The change removes an unnecessary heading character to clean up the file.
Documentation update:

README.md: Removed an extra heading character to improve the readability of the file.

This pull request includes a minor change to the README.md file. The change removes an unnecessary comment line at the top of the file.
Documentation update:

README.md: Removed an unnecessary comment line at the top of the file.

This pull request includes a small change to the README.md file. The change corrects the formatting by removing an unnecessary comment symbol at the beginning of the file.

README.md: Removed an extraneous comment symbol at the beginning of the file to correct the formatting.

This pull request includes a minor change to the README.md file. The change involves the removal of an unnecessary comment line.
Documentation update:

README.md: Removed an extraneous comment line at the beginning of the file.

This pull request includes a minor change to the README.md file. The change corrects the markdown heading for the TON API v4 section.

README.md: Removed an unnecessary markdown heading character to properly format the TON API v4 section.


Can't seem to find package in Maven

Hi,
I'm trying to use the library but it doesn't seem to be available in neither JCenter or Maven Central afaict. Searching in bintray I find this package which says:
<dependency>
	<groupId>org.unbroken-dome.siren</groupId>
	<artifactId>siren-core</artifactId>
	<version>0.2.0</version>
</dependency>

Note that this is not the same groupId that's specified in the readme.
I've tried added the jcenter repository:
<repositories>
        <repository>
            <id>jcenter</id>
            <url>https://jcenter.bintray.com/</url>
        </repository>
 </repositories>

but it doesn't seem to help.

Thanks!


Fix #41

First version

@herau do you have time to review it?

Bugs

The photos are uploaded but not selected in some cases (probably has to do with languages on preexisiting products) (Quick fix: assign the language of the product)

Small fixes

the background of the Add button should be the same as the page it's on
the Take a picture text is either below or above the icon. Put it always below.
Rename the buttons:

Take a front picture
Take a picture of the ingredients
Take a picture of the nutrition table

Add a Take more photos button in the Summary tab

Expanding the feature for more usecases

Add the option to use the offline upload method either when no network is found or when an option is selected in the settings for people who don't want to upload immediately on Mobile (they have a metered 3G connexion, they are abroad…)
No language of the image support

close & fix #41


Is the .jld extension now mandatory?

I think this is the result of #30, but I now get errors like:
ERROR: LoadError: LoadError: FileIO.File{FileIO.DataFormat{:UNKNOWN}}("/tmp/juliao8DRo1") couldn't be recognized by FileIO.

when I try to read/write to a filename without the .jld extension.
Is this the new status quo?

I can't reproduce:
julia> using JLD

julia> jldopen("/tmp/junk", "w") do file
           write(file, "a", rand(2))
       end

julia>
tim@diva:~$ julia
               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: http://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.4.1-pre+22 (2015-11-01 00:06 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit 669222e* (4 days old release-0.4)
|__/                   |  x86_64-linux-gnu

julia> using FileIO

julia> load("/tmp/junk")
Dict{ByteString,Any} with 1 entry:
  "a" => [0.2054425503298385,0.42643025987841376]

Maybe that file doesn't exist? I noticed that the FileIO error message is misleading when that's the case. (If so, pls file issue, or PR :smile:, with FileIO.)

My apologies for the lazy issue reporting. I should have been more explicit about what I'm doing to get the error.
This is how to reproduce the error I'm seeing:
using JLD
save(tempname(),"foo",1)

Adding .jld to the end of the filename makes the error go away. I'm on my phone right now, but I'll edit with version numbers when I get to my computer.

Oh, you're getting the error only when you write a new file? Yes, now that save is generic, it has to be able to guess the format either from the filename or from magic bytes; if it's a new file, there are no magic bytes, so either you need to supply clues in the extension or use
julia> save(File(format"JLD", fn), "foo", 1)

Not needed for load, since it can rely on the magic bytes:
julia> vars = load(fn)
Dict{ByteString,Any} with 1 entry:
  "foo" => 1

That makes sense. I guess that's an unavoidable drawback of a generic save. This issue was filed mostly because I was surprised to see code stop working and there was no documentation on this change (so I wasn't sure if it was intentional).
I'll open a PR to document this.

Thanks. This is definitely in the category of "unanticipated consequence." Obvious really, except the way I came at it was "too many packages want to define save"->"create FileIO"->"rebase JLD on FileIO".
It occurs to me that with a little tweaking we could probably make JLD.save work. There was some revamping how the whole package dispatch thing works in FileIO, and I think the current standard is that packages shouldn't import FileIO.save---I think FileIO.save will call JLD.save directly. Assuming that's right (it's been a while since I checked), then JLD.save should work, which might be nicer than the format string solution above.


Switch to designated initializers instead of chained setters

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 77 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 99.738%

Files with Coverage Reduction
New Missed Lines
%

barkeep/barkeep.h
1
99.74%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
381

Relevant Lines:
382

💛  - Coveralls


Working on pre-compilation

Start of working on improving pre-compilation and startup times

Hi @camilogarciabotero,
I've started working on this, already time to first X is halved (at least for Julia 3.8) for most things.
Would you mind sharing the benchmarking setup you used in https://github.com/FedeClaudi/Term.jl/issues/172 so that I can replicate?

Sure,
This is my OS specs:
OS: macOS 13.0 22A380 x86_64
CPU: Intel i5-8257U (8) @ 1.40GHz
Memory: 6095MiB / 8192MiB
Julia v1.8.3/v.1.9.0-alpha1
    -Term.jl v1.0.6

I created a startup.jl file with the following functions:
try
    import Term: install_term_stacktrace, install_term_logger, install_term_repr
    install_term_stacktrace()
    install_term_logger()
    install_term_repr()
catch e
    @warn "Error initializing term" exception=(e, catch_backtrace())
end

Then, I used hyperfine as described below (the +release = 1.8.3 & +alpha = 1.9.0-alpha1):
hyperfine --warmup 10 -u second 'time julia +release --startup-file=no -e "" '
                                'time julia +release --startup-file=yes -e "" '
                                'time julia +alpha --startup-file=no -e "" '
                                'time julia +alpha --startup-file=yes -e "" '

That was basically the setup I used. And, I believe the startup time will be much better once the 1.9.0 release land, though. So I was unsure if posting the original issue...Once the 1.9.0 is officially released, I could update the benches!

Got it thanks, it looks like hyperfine is a linux command line tool, so I won't be able to make sue of it.
Using snoop compile and related tools it looks like there's a not of method invalidations at startup that cause a delay for time to first X, so next step is trying to figure out the cause and fix them. Keep ya posted

Codecov Report

Merging #173 (c04e8ee) into master (82f1dbe) will increase coverage by 0.52%.
The diff coverage is 95.58%.

:exclamation: Current head c04e8ee differs from pull request most recent head e423db0. Consider uploading reports for the commit e423db0 to get more accurate results

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   94.94%   95.46%   +0.52%
==========================================
  Files          38       37       -1
  Lines        2473     2382      -91
==========================================
- Hits         2348     2274      -74
+ Misses        125      108      -17

Impacted Files
Coverage Δ

src/Term.jl
90.00% <ø> (ø)

src/prompt.jl
73.58% <0.00%> (ø)

src/__text_utils.jl
92.30% <94.44%> (-4.67%)
:arrow_down:

src/_text_reshape.jl
92.85% <100.00%> (-7.15%)
:arrow_down:

src/annotations.jl
100.00% <100.00%> (ø)

src/boxes.jl
95.00% <100.00%> (-1.67%)
:arrow_down:

src/colors.jl
93.61% <100.00%> (-4.21%)
:arrow_down:

src/highlight.jl
98.21% <100.00%> (-1.79%)
:arrow_down:

src/logs.jl
94.01% <100.00%> (ø)

src/renderables.jl
97.87% <100.00%> (ø)

... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Merge to 1.1

Coverage increased (+0.08%) to 32.735% when pulling 17c0072d442c119eafd5e2735a36c5ea7d305651 on master into 62f65eefdbe2ec4360e9771521c4873193350b6b on 1.1.