TIME STAMP!

Hey guys. So I've discovered Trello, and its amazing. It's literally everything I need. ALMOST.
I need a time stamp on the card for a quick glance, and I also have some rules that I need to go a little bit deeper.
I've done as much research as I can and I can't find any sort of a work around. SO, here we are. I'm using this for day to day management of a multi location business.
Issue 1. Time Stamps- As far as I can see the only answer Trello will give in regards to a time stamp, is to open up the card, scroll all the way to the bottom, and push a button. That just isn't acceptable lol. I need a time stamp to be visible when the card moves with out clicking it. My boss needs this info at a glance. I'm doing my best to compartmentalize the flow.
Archived items.. There is no way to search by date, there is no way to see the date out in the open on the card. I need to be able to choose a date range for the date archived, and have that visible on the card , maybe in the title or something.
Issue 2 Check lists.  My thoughts and action plan was to create a check list , when the item is checked on the checklist, it will transfer that item,  with the item name , to the next list in line. That way those items can be view and checked off by the next level.
Issue 3.
Maybe I'm expecting to much out of the app, or maybe I'm just not as familiar as i though I was. But I can't figure this out , and I am 99% sure that its just not possible with in the app as it stands. It would be incredible if that could change.
Thanks , not sure if this even the proper route at this just taking a stab in the dark.

Hi @SmokekingLV,
Issue 1: I don't exactly how what you mean with timestamps here. We indicate on the board the time spent along with the estimate. Since cards can be worked on across multiple days, weeks or months - then there is little incentive to show any other details.
I'm not sure what you mean about archived items. The powerup does not provide the ability to archive trackings. We do however fetch both open and archived cards in the data exporters. But unless you're getting a premium subscription then filtering here has to be done in excel. Premium includes date from/to filtering options there.
Issue 2: I don't see the connection here to time tracking. Can you please elaborate.
Issue 3: CSV is universal. I'm not personally going to invest in adding other file formats and you can quite easily open CSV in excel and save it in any other format if you require it. But feel free to send a PR to include it yourself 👍

I appreciate the reply . I did a little more digging and figured out I was
not as familiar with this product as I thought I was. This was most
certainly a premature email on my part and I apologize for wasting your
time.
On Sun, Sep 10, 2023 at 10:42 AM Dannie Hansen @.***>
wrote:

Hi @SmokekingLV https://github.com/SmokekingLV,
Issue 1: I don't exactly how what you mean with timestamps here. We
indicate on the board the time spent along with the estimate. Since cards
can be worked on across multiple days, weeks or months - then there is
little incentive to show any other details.
I'm not sure what you mean about archived items. The powerup does not
provide the ability to archive trackings. We do however fetch both open and
archived cards in the data exporters. But unless you're getting a premium
subscription then filtering here has to be done in excel. Premium includes
date from/to filtering options there.
Issue 2: I don't see the connection here to time tracking. Can you please
elaborate.
Issue 3: CSV is universal. I'm not personally going to invest in adding
other file formats and you can quite easily open CSV in excel and save it
in any other format if you require it. But feel free to send a PR to
include it yourself 👍
—
Reply to this email directly, view it on GitHub
https://github.com/danniehansen/activity-timer/issues/120#issuecomment-1712894656,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BCMKI2HMEPA4R7QDNRJOBDDXZX3X5ANCNFSM6AAAAAA4NSMM6Q
.
You are receiving this because you were mentioned.Message ID:
@.***>


Webpack 5 compatibility and crypto dependency when importing @azure/msal-node

Core Library
MSAL Node (@azure/msal-node)
Core Library Version
2.15.0
Wrapper Library
Not Applicable
Wrapper Library Version
0
Public or Confidential Client?
Confidential
Description
Hello,
I'm trying to build the node exemple provided in an existing Webpack5 config running on node 18.
As soon as I import the class "ConfidentialClientApplication" from @azure/msal-node, I get the following error on build :
<EMAIL_ADDRESS>contains a reference to the file "crypto".
This file can not be found, please check it for typos or update it if the file got moved.
Reading this closed issue, I tried to add aliases and polyfill to my webpack config.
For exemple, adding this :
config.resolve.fallback = {
crypto: require.resolve('crypto-browserify'),
But once crypto error is fixed, I get a lot of other libs not found anymore, like http, https, process, path etc...
Error Message
<EMAIL_ADDRESS>contains a reference to the file "crypto".
This file can not be found, please check it for typos or update it if the file got moved.
MSAL Logs
No response
Network Trace (Preferrably Fiddler)

[ ] Sent
[ ] Pending

MSAL Configuration
{
  "authenticationMode": "ServicePrincipal",
  "authorityUrl": "https://login.microsoftonline.com/",
  "scopeBase": "https://analysis.windows.net/powerbi/api/.default",
  "powerBiApiUrl": "https://api.powerbi.com/",
  "clientId": "xxxxx",
  "workspaceId": "xxxxx",
  "reportId": "xxxxx",
  "pbiUsername": "",
  "pbiPassword": "",
  "clientSecret": "xxxxx",
  "tenantId": "xxxxx"
}

Relevant Code Snippets
const Encore = require('@symfony/webpack-encore');
const Dotenv = require('dotenv-webpack');
const BrowserSyncPlugin = require("browser-sync-webpack-plugin");

if (!Encore.isRuntimeEnvironmentConfigured()) {
  Encore.configureRuntimeEnvironment(process.env.NODE_ENV || 'dev');
}

Encore
    // directory where compiled assets will be stored
    .setOutputPath('public/build/')
    // public path used by the web server to access the output path
    .setPublicPath('/en/private/build')
    // only needed for CDN's or sub-directory deploy
    .setManifestKeyPrefix('build')

    .addEntry('main', './assets')
    .addEntry('powerbi', './assets/javascript/powerbi/app.js')
    .enableStimulusBridge('./assets/controllers.json')
    .splitEntryChunks()
    .enableSingleRuntimeChunk()
    .cleanupOutputBeforeBuild()
    .enableBuildNotifications()
    .enableSourceMaps(!Encore.isProduction())
    .enableVersioning(Encore.isProduction())
    .enableSassLoader()
    .autoProvidejQuery()
    .enableReactPreset()

    .addPlugin(new Dotenv({
        systemvars: true

    .addPlugin(new BrowserSyncPlugin(
        {
            host: "localhost",
            port: 8085,
            proxy: 'localhost',
            open: false,
            files: [ // watch on changes
                {
                    match: ['public/build/**/*.js'],
                    fn: function (event, file) {
                        if (event === 'change') {
                            const bs = require('browser-sync').get('bs-webpack-plugin');
                            bs.reload();
                        }
                    }
                }
            ],
            notify: false,
        },
        {
            reload: false,
            name: 'bs-webpack-plugin',
        }
    ))
;

const config = Encore.getWebpackConfig()
config.resolve.fallback = {
    crypto: require.resolve('crypto-browserify'),
};
module.exports = config;

Reproduction Steps

npm install @azure/msal-node
import { PublicClientApplication} from "@azure/msal-node";
error is displayed after npm start

Expected Behavior
should not get an error at build
Identity Provider
Entra ID (formerly Azure AD) / MSA
Browsers Affected (Select all that apply)
Chrome, Firefox
Regression
No response

These are all node globals which should be provided by the node runtime. Either webpack doesn't make these available or you're compiling for an environment other than node, such as a browser, which is not supported by this package (use msal-browser for browser based apps). If you are compiling a node app then this is a webpack problem and I would suggest you reach out to Webpack for guidance on how to resolve.


Camera error

I tried to use the following RPI camera with NX, Aftrer build this repo, when I run camera-viewer, I got the following error. How can I fix it?
aaa@AAA:~/apps/jetson-utils/build/aarch64/bin$ ./camera-viewer
[gstreamer] initialized gstreamer, version <IP_ADDRESS>
[gstreamer] gstCamera – attempting to create device csi://0
[gstreamer] gstCamera pipeline string:
[gstreamer] nvarguscamerasrc sensor-id=0 ! video/x-raw(memory:NVMM), width=(int)1280, height=(int)720, framerate=30/1, format=(string)NV12 ! nvvidconv flip-method=2 ! video/x-raw(memory:NVMM) ! appsink name=mysink
[gstreamer] gstCamera successfully created device csi://0
camera-viewer: successfully initialized camera device (1280x720)
[OpenGL] glDisplay – X screen 0 resolution: 2560x1600
[OpenGL] glDisplay – X window resolution: 2560x1600
[OpenGL] glDisplay – display device initialized (2560x1600)
[gstreamer] opening gstCamera for streaming, transitioning pipeline to GST_STATE_PLAYING
[gstreamer] gstreamer changed state from NULL to READY ==> mysink
[gstreamer] gstreamer changed state from NULL to READY ==> capsfilter1
[gstreamer] gstreamer changed state from NULL to READY ==> nvvconv0
[gstreamer] gstreamer changed state from NULL to READY ==> capsfilter0
[gstreamer] gstreamer changed state from NULL to READY ==> nvarguscamerasrc0
[gstreamer] gstreamer changed state from NULL to READY ==> pipeline0
[gstreamer] gstreamer changed state from READY to PAUSED ==> capsfilter1
[gstreamer] gstreamer changed state from READY to PAUSED ==> nvvconv0
[gstreamer] gstreamer changed state from READY to PAUSED ==> capsfilter0
[gstreamer] gstreamer stream status CREATE ==> src
[gstreamer] gstreamer changed state from READY to PAUSED ==> nvarguscamerasrc0
[gstreamer] gstreamer changed state from READY to PAUSED ==> pipeline0
[gstreamer] gstreamer message new-clock ==> pipeline0
[gstreamer] gstreamer stream status ENTER ==> src
[gstreamer] gstreamer changed state from PAUSED to PLAYING ==> capsfilter1
[gstreamer] gstreamer changed state from PAUSED to PLAYING ==> nvvconv0
[gstreamer] gstreamer changed state from PAUSED to PLAYING ==> capsfilter0
[gstreamer] gstreamer changed state from PAUSED to PLAYING ==> nvarguscamerasrc0
[gstreamer] gstreamer message stream-start ==> pipeline0
camera-viewer: camera open for streaming
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
^Creceived SIGINT
^Creceived SIGINT
^Creceived SIGINT
[gstreamer] gstDecoder – failed to retrieve next image buffer
camera-viewer: failed to capture RGBA image
camera-viewer: shutting down…
[gstreamer] gstCamera – stopping pipeline, transitioning to GST_STATE_NULL
^Creceived SIGINT
(camera-viewer:10328): GStreamer-CRITICAL **: 22:34:06.816: gst_mini_object_set_qdata: assertion ‘object != NULL’ failed
^Creceived SIGINT
(Argus) Error Timeout: (propagating from src/rpc/socket/client/SocketClientDispatch.cpp, function openSocketConnection(), line 215)
(Argus) Error Timeout: Cannot create camera provider (in src/rpc/socket/client/SocketClientDispatch.cpp, function createCameraProvider(), line 102)
Error generated. /dvs/git/dirty/git-master_linux/multimedia/nvgstreamer/gst-nvarguscamera/gstnvarguscamerasrc.cpp, execute:639 Failed to create CameraProvider
[gstreamer] gstCamera – pipeline stopped
camera-viewer: shutdown complete.
aaa@AAA:~/apps/jetson-utils/build/aarch64/bin$ dmesg | grep -i imx219
[ 2.011313] imx219 9-0010: tegracam sensor driver:imx219_v2.0.6
[ 2.036285] imx219 10-0010: tegracam sensor driver:imx219_v2.0.6
[ 2.628153] tegra194-vi5 15c10000.vi: subdev imx219 9-0010 bound
[ 2.629088] tegra194-vi5 15c10000.vi: subdev imx219 10-0010 bound

Can you check that the camera is functioning properly first using the nvgstcapture-1.0 tool?

Here is the output:
nvidia@XavierNx:~/apps/CSI-Camera$ nvgstcapture-1.0
Encoder null, cannot set bitrate!

NvMMLiteOpen : Block : BlockType = 4
===== NVMEDIA: NVENC =====
NvMMLiteBlockCreate : Block : BlockType = 4
GST_ARGUS: Creating output stream
CONSUMER: Waiting until producer is connected...
GST_ARGUS: Available Sensor modes :
GST_ARGUS: 3264 x 2464 FR = 21.000000 fps Duration = 47619048 ; Analog Gain range min 1.000000, max 10.625000; Exposure Range min 13000, max 683709000;
GST_ARGUS: 3264 x 1848 FR = 28.000001 fps Duration = 35714284 ; Analog Gain range min 1.000000, max 10.625000; Exposure Range min 13000, max 683709000;
GST_ARGUS: 1920 x 1080 FR = 29.999999 fps Duration = 33333334 ; Analog Gain range min 1.000000, max 10.625000; Exposure Range min 13000, max 683709000;
GST_ARGUS: 1640 x 1232 FR = 29.999999 fps Duration = 33333334 ; Analog Gain range min 1.000000, max 10.625000; Exposure Range min 13000, max 683709000;
GST_ARGUS: 1280 x 720 FR = 59.999999 fps Duration = 16666667 ; Analog Gain range min 1.000000, max 10.625000; Exposure Range min 13000, max 683709000;
GST_ARGUS: Running with following settings:
Camera index = 0
Camera mode  = 4
Output Stream W = 1280 H = 720
seconds to Run    = 0
Frame Rate = 59.999999
GST_ARGUS: Setup Complete, Starting captures for 0 seconds
GST_ARGUS: Starting repeat capture requests.
CONSUMER: Producer has connected; continuing.
nvbuf_utils: dmabuf_fd -1 mapped entry NOT found
nvbuf_utils: Can not get HW buffer from FD... Exiting...
ERROR on bus: by /GstPipeline:capture_native_pipeline/GstBin:cap_bin/GstNvArgusCameraSrc:nvarguscamerasrc0: CANCELLED
debug info:
Argus Error Status
(nvgstcapture-1.0:12583): GStreamer-CRITICAL **: 15:22:37.052: gst_mini_object_set_qdata: assertion 'object != NULL' failed
GST_ARGUS: Cleaning up
** Message: 15:22:37.801: main:4680 Capture completed
** Message: 15:22:37.801: main:4729 Camera application will now exit

Does it show the camera?   If not, my code won't work either, and there is an issue with your camera or how it's plugged in.

I had the same issue with the log "invalid argument (error 11) (hex 0x0B)" in line 319 gstBufferManager.cpp.
if (CUDA_FAILED(cudaGraphicsEGLRegisterImage(&eglResource, eglImage, cudaGraphicsRegisterFlagsReadOnly)))
  return false;

I changed the flag from cudaGraphicsRegisterFlagsReadOnly to cudaGraphicsRegisterFlagsNone and now it works. It was only a guess and I don't know why this flag is invalid but maybe somebody knows or can use this "fix".
TX2 -- Jetpack 4.2.2 -- L4T 32.2.1


Macroify snapshot tests

What does this PR address?

Fixes # (issue)
Before submitting:

[x] Make sure to follow GitHub's guide on creating PR.
[x] Did you read through contribution guidelines?
[ ] Did your changes require updates to the documentation? Have you updated those accordingly?
[x] Did you write tests to cover your changes? Did it pass locally when running cargo test?
[x] Have you run cargo fmt, cargo check and cargo clippy locally to ensure that CI passes?

After discussing on Discord, it makes more sense for us to use the glob feature in insta.

After discussing on Discord, it makes more sense for us to use the glob feature in insta.

Yes agree, going to close this PR for now


Question/Feature: Display description in status command?

The status command won't output description but history command does. Is there any reason?
I think it's useful when debugging failed releases, and web dashboard using helm SDK like kubeapps can show the failed reason easily.
I would like to create a PR to resolve this if it's OK.

This seems like a reasonable feature. Feel free to push a PR.


[Chore]: [FAIL] CFDomainReconciler Integration Tests Delete CFDomain [It] deletes the domain routes

Build URL
https://github.com/cloudfoundry/korifi/actions/runs/3995771978/jobs/6855026278
Description
I believe that the domain has beed deleted before routes had the chance of bing reconciled (seen from the k8s client manager):
2023-01-24T11:38:27Z	ERROR	Reconciler error	{"controller": "cfroute", "controllerGroup": "korifi.cloudfoundry.org", "controllerKind": "CFRoute", "CFRoute": {"name":"8ee98fe6-aa1e-4cfa-bbc0-c94e1dc5360f","namespace":"a7ee05bb-4b51-4662-8db2-e9d18d2770ac"}, "namespace": "a7ee05bb-4b51-4662-8db2-e9d18d2770ac", "name": "8ee98fe6-aa1e-4cfa-bbc0-c94e1dc5360f", "reconcileID": "8090d51b-dadd-4e3b-8b6f-fca6011b4a19", "error": "CFDomain.korifi.cloudfoundry.org \"ddbac20d-a180-47fa-9bed-dfec007c96bc\" not found"}

That is probably why domain finalization does not delete the routes, therefore tests are failing

Let's reopen it when it occurs again


will need a new 4g guide for rockpi models

the rockpi does not use an SD card, and the emmc can't be easily modified manually.
As such @vpetersson and team are creating a new way to modify the 4g settings over bluetooth or via the diagnostics (TBC).
Once completed we need to create a new guide on how to do this.

@NebraLtd/device-team Not super urgent, since we don't have an outdoor version of the Rockpi yet, but this should probably be best done in the app.


Any plan having StyleCopAnalyzer as Visual Studio extension ?

Is there any plan to have this StyleCopAnalyzer as a Visual Studio extension ?
Like the VS 2015 extension of Dustin Campbell 'C# Essentials'.

At this time, there is no plan to do this. See #1607 for more information.


Issuer - VC List view Dynamic columns

What is the feature request for?
Registry Core
What problem/inconvenience (if any) will this feature solve?
It is inconvenient for me to do .... If we add this feature, it would make it easier to do ....
Describe the feature clearly.
Add a new feature that does ....

Problem Statement : Currently the in record list, the columns that are displayed are hard coded. We need to show the column names dynamically because every issuer will have different requirements for record table. We need to see if we can make it configurable as well.
Current Approach : To add an object, in the json schema while creating a VC. It will contain all the fields which are also included in the property array. Need a little clarity - should the issuer have an option to select columns which should be displayed? Or are we showing all the columns which are added in the object.
@Pratikshakhandagale @varadeth @tejash-jl

Here are 2 different approaches we can take :
Approach 1 :

When the issuer is choosing fields, add field names in a new object which are to be included in the list manually.
Which is similar to credential subject object that we have currently. With proper documentation this approach can be achieved.

Approach 2 :

When a schema is created, we can display all the fields on the editor.
When selecting Advance Editor option from the editor, we see a list of all the fields in the side column
Instead of simply showing the list, we can add checkboxes to each field.
Issuer can select the fields he wants to add to the record table.

@Renuka-S @jayadinni @coolbung

Please also enable unique identifier, that will cover the deduplication service: https://github.com/Sunbird-RC/community/issues/618

We are leveraging this for the reference solution implementation @snehal0904?
cc - @chakshugautam

Finalised Appraoch :  "To add field names in a new object manually which are to be included in the list shown as dynamic columns"
Steps of Implementation :
1. Modify JSON Schema:

Add an "_osConfig" object within the "uiConfig" section of the JSON schema.
Inside the "_osConfig" object, add a "colunmnList" array to store the field definitions for the dynamic table.
Each field definition should be an object with "key" and "title" properties to represent the field name and display title
respectively.
"_osConfig": {                                                                                "uiConfig": {                                                                               "colunmnList": [  ]                                                                                }                                                                                }

2. Dynamic Table Field Logic

Check "colunmnList" Array:
Display fields from the "colunmnList" array as dynamic table columns.
If the "colunmnList" array is empty.
Use "required" Array Fields:
Display fields from the "required" array as dynamic table columns.
Limit to 8 Fields:
Display a maximum of 8 fields from the "required" array.
Fallback to "properties" Fields:
If "required" array has is empty then display first 8 fields from "properties" object as dynamic columns.


Calling ReconnectApp Once after Refresh

Details

We care when the isInternetReachable has a value (true|false), the Lib sends null while is creating the network object. We want to listen when the connection is done and all the information exists. Removing the ?? false we avoid the extra call sending the event that the app is offline.
Fixed Issues

$ https://github.com/Expensify/App/issues/40995
PROPOSAL: https://github.com/Expensify/App/issues/40995#issuecomment-2082530033
Tests

[ ] Verify that no errors appear in the JS console
[ ] Open a Report
[ ] Open the developer tool and click on the Network tab
[ ] Refresh the site
[ ] In the requests list you should see one ReconnectApp

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Unfortunately wasn't able to get to this today, will complete the review on Monday!

@gedu Any testing steps for mobile here?

Damn, I'm temporarily out of the C+ team as I'm about to go OOO so this isn't auto-assigning an engineer. @tgolen Do you mind taking a look since you were tagged on Slack?

@gedu ~Any testing steps for mobile here?~
Looks like on mobile (native) we can look out for this in the logs:
https://github.com/Expensify/App/blob/8383d80013cf61e83fc8bd90eef5f8357f69cf91/src/libs/actions/App.ts#L254-L255

Should I remove it?

@jjcoffee Should I remove it?

@gedu Sorry I'm not sure what you're talking about removing?

@jjcoffee is this PR approved?

@mountiny friendly ping

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


pipe-url-to

I suggest to implement a new command pipe-url-to, similar to pipe-to.
It could be used for external scripts, like:
# second browser, in case I really need pictures
bindkey u pipe-url-to "firefox"
# just give me the text
bindkey r pipe-url-to "readability > ~/Downloads/last-text-I-read.txt"
# open new draft to containing url in body for easier sharing
bindkey m pipe-url-to "thunderbird"
# download new this video
bindkey y pipe-url-to "youtube-dl"

Another, ever stronger approach would be to have a command exec, which can refere to the article text (eg %a), the url (%u), the title (%t) etc. Writing commands like above would be even better:
# download this new video
bindkey y exec "youtube-dl --output %t.flv %u"


fast(er) unit tests

While running into sbi API problems (see #21) I ran some unit tests locally on my laptop (mostly as a sanity check). This revealed very quickly that the unit tests, e.g. under algorithms, are geared towards correctness of results rather than correctness of API usage. I suspect that this is also the reason why this repo doesn't use CI facilities like github-actions.
While I value correctness of results very highly, the correctness of API is a precondition. If the code breaks before a result can be obtained, there will be no result to test for correctness. ;-) It might be worthwhile to introduce faster and slower tests (similar to what sbi does).

Speed of the tests was one reason why I did not set them up on CI, but mostly I just post-poned it to the future, when we have more collaborators/the codebase is growing :)
Since this is the case now, I'm planning to go through the tests, mark some as slow, and set things up on GH actions.


Reduce file size of capturePhotoAsImageProcessedUpToFilter at time of capture

I have an app that takes up to 4 pictures from the user.
However it is sometimes crashing when I take a picture using capturePhotoAsImageProcessedUpToFilter
The issue is specific to taking images with the back facing camera (which give MUCH larger images).
Is there I way I can reduce how much is being cached inside GPUImage before it returns the object? My app is crashing without a memory warning and before it reaches my code.
Can I pre-reduce image size and free that memory before GPUImage works its magic on it?
Here is my full code block
_videoCamera.capturePhotoAsImageProcessedUpToFilter(_view.filterToClear, withCompletionHandler:
            {
            (uiimage:UIImage!, e:NSError!) -> Void in
                var finalRes:UIImage!
                if(self._isiPhone == true)
                {
                    if(uiimage.size.width < uiimage.size.height)
                    {
                        UIGraphicsBeginImageContext(CGSizeMake(480, 640))
                        uiimage.drawInRect(CGRectMake(0, 0,480,640))
                    }else
                    {
                        UIGraphicsBeginImageContext(CGSizeMake(640,480))
                        uiimage.drawInRect(CGRectMake(0, 0,640,480))
                    }

                }else
                {
                    if(uiimage.size.width < uiimage.size.height)
                    {
                        UIGraphicsBeginImageContext(CGSizeMake(720, 960))
                        uiimage.drawInRect(CGRectMake(0, 0,720,960))
                    }else
                    {
                        UIGraphicsBeginImageContext(CGSizeMake(960, 720))
                        uiimage.drawInRect(CGRectMake(0, 0,960,720))
                    }

                }
                finalRes = UIGraphicsGetImageFromCurrentImageContext()
                var newImage:iImage = iImage(uiimage: finalRes)
                self.addImage(newImage, pictureFromCamera: true, position: nil)
                self._takePictureComplete = true
                self._view.clearCameraPreview.transform = CGAffineTransformMakeScale(1,1)
                dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0),
                { () -> Void in
                    //UIImageWriteToSavedPhotosAlbum(uiimage,self,"saveImageComplete:err:context:", nil)
                    println("Image saving is disabled")
                })
                UIGraphicsEndImageContext()
        })

Same issue here, GPUImage generate memory warnings and after 4 photos, the app will crash. iPhone 4s whith iOS 8.2 with full resolution images. You can test this with the sample project SimplePhotoFilter. (choose a crop filter [(GPUImageCropFilter *)_doNothingFilter setCropRegion:CGRectMake(0, 0, 1, 1)];)

I was able to increase consecutive photos being taken by calling videoCamera.removeAllTargets() between shots. I still get a memory leak but I am able to take 15-20 consecutive photos with the back camera instead of 4-6.

Try using -capturePhotoAsJPEGProcessedUpToFilter: as your callback. Uncompressed UIImages at this size are massive in memory, and keeping that along with the framebuffers that lead to it in memory can lead to significant memory spikes. The JPEG callback will release the uncompressed UIImage in favor of a compressed JPEG.
May not solve your problem of needing to resize it after that, though.

Thanks I just gave it a shot. Made no difference sadly.

As a long shot, try adding
        GPUImageContext.sharedFramebufferCache().purgeAllUnassignedFramebuffers()

at the beginning or ending of your image capture callback (without the use of removeAllTargets() as you had described) . There's a possibility that framebuffers aren't being released properly at some point here.
Also, is this with the latest code from the repository, or the older code that CocoaPods feeds you?

I will try this right now. This is the most recent update.
Also note, if I take images from the front facing camera, I can get 50 images before a crash. I did as much instrumenting as I can and it seems there is this dirty virtual memory issue specifically with these IOKit(2342342 pages) kind of items. Also if I leave the camera running for 10-15 minutes I also get a a memory crash error. I think there is an issue with ARC. Somehow UIImage remnants are getting left uncollected?

Adding  GPUImageContext.sharedFramebufferCache().purgeAllUnassignedFramebuffers() still has it crash in the 10-15 photo range.

Interestingly when I run with instruments on I am getting in the 75+ picture range!!! (and it didn't even crash I just stopped) I had a similar issue like this when I was working with a sprite engine for iOS. When we would build the app it would crash after loaded the level 10 times. But if we ran it with the instruments on, it never crashed.  Do you know how/where I might be able to make a forced garbage collection call after each photo capture?
This issue is 100% reproducible, I can take 15 pictures when running from a build but I got past 70 when running with instruments.
Can we force a garbage collection call somehow?

Are you sure you're running a release build when you're testing this on your device? When you build for Instruments, it uses a release build, not a debug one.

I will try that right now and have a look!
Interesting tid bit. I ran a VM only memory trace and I've found a potential source of a leak:

Every time I take a photo, this CoreAnimation object increases in size by 20-25 each time and is never released.
Not matter how many object I release in my code, this ALWAYS goes up. Do you have a project you could confirm this with to see if its strictly linked to GPUImage? If you run a VM only stack trace and you see this CoreAnimation object leaking too then perhaps we're on the culprit?

Confirmed When I run with a release build, I can take pictures well into the 70+ zone (have not yet found upper limit).
Very interesting....

I'm also experiencing this issue.
I must use the method capturePhotoAsImageProcessedUpToFilter:withCompletionHandler: because the output will need to be stored to the camera roll.
What i've done so far is:
-added [[GPUImageContext sharedFramebufferCache] purgeAllUnassignedFramebuffers]; in the first line of the capturePhotoAsImageProcessedUpToFilter:withCompletionHandler: callback.
I then handle storing the image to the camera roll and a few other small things within an asych dispatch group.
Sometimes after 1 capture but often after 4 - 5 simultaneous captures the app receives a memory warning.
Also, yes I am running the app with a release build.
Any suggestion for how I can troubleshoot this problem?


Replace .NET Framework with .NET where applicable

Summary
Following the same thought and changes from pull request #18691 updated the use of .NET Framework to just .NET anywhere that wasn't explicitly referencing the Framework itself or a comparison to .Net Core.  Additionally updated several references to "framework version x.x or newer" to say "framework version x.x or higher" to be consistent with other places this is used.
Contributes To #18697

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: bradriske sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I requested an additional review from @tdykstra
He's been maintaining our glossary, and it would be good to have him give this a close look 🔎

Is there anything pending on this for the pull or just long term planning?

It should be ready to go, after merge conflicts are resolved.


Generated ES modules has .js extension

When using jco transpile it generates es modules with .js extension which causes error when importing from es module in nodejs.
***/index.mjs:1
import { example } from './bindings/example.component.js';
         ^^^^^^^^^
SyntaxError: Named export 'example' not found. The requested module './bindings/example.component.js' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from './bindings/example.component.js';
const { example } = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:132:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:214:5)
    at async ModuleLoader.import (node:internal/modules/esm/loader:323:24)
    at async loadESM (node:internal/process/esm_loader:28:7)
    at async handleMainPromise (node:internal/modules/run_main:120:12)

Node.js v21.6.1

Running Node.js with this flag helps, but looks unconventional...
node --experimental-default-type module index.mjs

This is correct - add "type": "module" to your package.json file.

ooh, didn't think of that since I'm making a SPA, not a library. But it sounds logical, thanks!
If this is the recommended way, it would be cool to document it (including in the example).


Set Proportional Width / Height To Another View

Is there a way to set proportional width / height to another view with KeepLayout?

UIView *view1;
UIView *view2;

[self.view addSubview:view1];
[self.view addSubview:view2];

view1.keepWidthTo(view2).equal = 0.5;
view1.keepHeightTo(view2).equal = 0.8;


HGVSc. annotations

The HGVSc. annotations in the TSV file are all given with respect to the plus strand, but they should be given with respect to the sense strand.  For example, the variant in MTOR at chr1, 11174420 is listed as c.7255C>T, but it should be c.7255G>A (since the coding strand of MTOR is the minus strand).

This is corrected. Should be pushed at next deploy, closing.


Roll Engine from 6fa0fb005910 to dd937c3f9abb (15 revisions)

https://github.com/flutter/engine/compare/6fa0fb005910...dd937c3f9abb
2021-04-23<EMAIL_ADDRESS>Roll CanvasKit to 0.26.0 (flutter/engine#25732)
2021-04-23<EMAIL_ADDRESS>Roll Skia from 7978abafee41 to 600bc360ff01 (5 revisions) (flutter/engine#25730)
2021-04-23<EMAIL_ADDRESS>Fix accessibility of embedded views in Android 9 and below (flutter/engine#25709)
2021-04-23<EMAIL_ADDRESS>Roll Skia from 7b8f14991dae to 7978abafee41 (1 revision) (flutter/engine#25725)
2021-04-23<EMAIL_ADDRESS>Roll Dart SDK from 805527e063af to 4ead30825322 (1 revision) (flutter/engine#25723)
2021-04-23<EMAIL_ADDRESS>Roll Skia from 94d3dd82f350 to 7b8f14991dae (1 revision) (flutter/engine#25722)
2021-04-23<EMAIL_ADDRESS>Roll Dart SDK from 7f16d6f67d91 to 805527e063af (1 revision) (flutter/engine#25721)
2021-04-23<EMAIL_ADDRESS>Roll Skia from 7b60deedbd98 to 94d3dd82f350 (3 revisions) (flutter/engine#25720)
2021-04-23<EMAIL_ADDRESS>Roll Skia from 395274e664cf to 7b60deedbd98 (1 revision) (flutter/engine#25719)
2021-04-23<EMAIL_ADDRESS>Roll Dart SDK from d05e7fc462ba to 7f16d6f67d91 (14 revisions) (flutter/engine#25718)
2021-04-23<EMAIL_ADDRESS>Roll Skia from 82007f568d90 to 395274e664cf (7 revisions) (flutter/engine#25717)
2021-04-23<EMAIL_ADDRESS>Roll Clang Mac from UStSqd7xn... to bf4GDBSQE... (flutter/engine#25715)
2021-04-23<EMAIL_ADDRESS>Roll Clang Linux from GiGTah6EB... to zRvL_ACCG... (flutter/engine#25714)
2021-04-22<EMAIL_ADDRESS>Roll Skia from 071182ed1da5 to 82007f568d90 (4 revisions) (flutter/engine#25712)
2021-04-22<EMAIL_ADDRESS>Refactor Android PlatformView constructors (flutter/engine#25632)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


⚠ Turnos 24x7 has degraded performance

In b54ca0c, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1046 ms

Resolved: Turnos 24x7 performance has improved in 3a81472.


[Logistic Regression] set hasSummary to false to be compatible with spark

A followup PR of https://github.com/NVIDIA/spark-rapids-ml/pull/363

build


added publications

Added (my own) publications and renamed some files.

Changes are good. Small details will be fixed by a following PR.


tests: drivers: dma: loop transfer: Improve debuggability

By printing the content of mismatching buffers, debugging gets simplified.

Max number of bytes is limited to 2**12 = 4096 bytes. The buffers in question might however be bigger.
Dropping this PR because the following options seem bad to me:

Increase max number of bytes to write. Would incur overhead for everyone.
Cut off buffer size at some point. Feels like lying to the user.
Reducing CONFIG_DMA_LOOP_TRANSFER_SIZE to < 4096


Update http4s-circe, http4s-dsl to 0.23.16

Updates

org.http4s:http4s-circe
org.http4s:http4s-dsl

from 0.23.4 to 0.23.16.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-minor, semver-spec-patch, commit-count:1

Superseded by #422.


[FEAT] Category and Product In Memory Backends Should Expose Entities

:bulb: Feature request
Feature Name

Category and Product In Memory Backends Should Expose Entities
The Desired Behavior

I would like to be able to read the categories and products from the in-memory backend classes.
inject(DaffInMemoryBackendProductService).products

Your Use Case

As an app dev, I need to configure the external router in-memory driver to resolve URLs from entities in these backends.
Prior Work

The demo implementation for #1838

closed by #1841 and #1842


Revert a bunch of merge collateral damage

PTAL, Garrett pointed out that I touched these files accidentally during my merge...
I reverted them to the commit before mine.

LGTM assuming Travis passes

This PR accidentally reverted some of my early changes.....

UGHHHH


Installation with Poetry fails with "Package 'baybe[telemetry]' is listed as a dependency of itself."

When trying to install baybe in an env with Poetry, it fails with the error Package 'baybe[telemetry]' is listed as a dependency of itself.
Steps to reproduce on MacOS:
poetry --version
> Poetry (version 1.8.2)
poetry init
# create a dummy package with Poetry, Python version ~3.11.0
cat pyproject.toml
> ...
> [tool.poetry.dependencies]
> python = "~3.11.0"
>
>
> [build-system]
> requires = ["poetry-core"]
> build-backend = "poetry.core.masonry.api"
> ...

poetry add baybe

> Using version ^0.8.1 for baybe
>
> Updating dependencies
> Resolving dependencies... (0.3s)
>
> Package 'baybe[telemetry]' is listed as a dependency of itself.

@Scienfitz: doesn't solve the problem, unfortunately. We have recursive dependencies all over the place in our toml ...

I have created a PR removing the group here: #181 @tobiasploetz it would be great if you could check this out and see whether this fixes the issue.

Resolved


Unable to build local_planner

Build of `local_planner' fails due to the following error
In file included from /home/docker-rajat/catkin_ws/src/avoidance/local_planner/src/nodes/local_planner_node.cpp:1:0:
/home/docker-rajat/catkin_ws/src/avoidance/local_planner/src/nodes/local_planner_node.h:18:48: fatal error: mavros_msgs/CompanionProcessStatus.h: No such file or directory

The entire output is as follows
$ catkin build -w ~/catkin_ws
-----------------------------------------------------------------
Profile:                     default
Extending:             [env] /opt/ros/kinetic
Workspace:                   /home/docker-rajat/catkin_ws
-----------------------------------------------------------------
Source Space:       [exists] /home/docker-rajat/catkin_ws/src
Log Space:         [missing] /home/docker-rajat/catkin_ws/logs
Build Space:        [exists] /home/docker-rajat/catkin_ws/build
Devel Space:        [exists] /home/docker-rajat/catkin_ws/devel
Install Space:      [unused] /home/docker-rajat/catkin_ws/install
DESTDIR:            [unused] None
-----------------------------------------------------------------
Devel Space Layout:          linked
Install Space Layout:        None
-----------------------------------------------------------------
Additional CMake Args:       None
Additional Make Args:        None
Additional catkin Make Args: None
Internal Make Job Server:    True
Cache Job Environments:      False
-----------------------------------------------------------------
Whitelisted Packages:        None
Blacklisted Packages:        None
-----------------------------------------------------------------
Workspace configuration appears valid.

NOTE: Forcing CMake to run for each package.
-----------------------------------------------------------------
[build] Found '2' packages in 0.0 seconds.
[build] Updating package table.
Starting  >>> catkin_tools_prebuild
Finished  <<< catkin_tools_prebuild                [ 7.0 seconds ]
Starting  >>> global_planner
Starting  >>> local_planner
______________________________________________________________________________________________________________________________________________
Warnings   << local_planner:cmake /home/docker-rajat/catkin_ws/logs/local_planner/build.cmake.000.log
** WARNING ** io features related to openni2 will be disabled
** WARNING ** io features related to pcap will be disabled
** WARNING ** io features related to png will be disabled
** WARNING ** visualization features related to openni2 will be disabled
cd /home/docker-rajat/catkin_ws/build/local_planner; catkin build --get-env local_planner | catkin env -si  /usr/bin/cmake /home/docker-rajat/catkin_ws/src/avoidance/local_planner --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/home/docker-rajat/catkin_ws/devel/.private/local_planner -DCMAKE_INSTALL_PREFIX=/home/docker-rajat/catkin_ws/install; cd -
..............................................................................................................................................
______________________________________________________________________________________________________________________________________________
Warnings   << global_planner:cmake /home/docker-rajat/catkin_ws/logs/global_planner/build.cmake.000.log
** WARNING ** io features related to openni2 will be disabled
** WARNING ** io features related to pcap will be disabled
** WARNING ** io features related to png will be disabled
** WARNING ** visualization features related to openni2 will be disabled
cd /home/docker-rajat/catkin_ws/build/global_planner; catkin build --get-env global_planner | catkin env -si  /usr/bin/cmake /home/docker-rajat/catkin_ws/src/avoidance/global_planner --no-warn-unused-cli -DCATKIN_DEVEL_PREFIX=/home/docker-rajat/catkin_ws/devel/.private/global_planner -DCMAKE_INSTALL_PREFIX=/home/docker-rajat/catkin_ws/install; cd -
..............................................................................................................................................
Finished  <<< global_planner                       [ 11 minutes and 14.2 seconds ]
______________________________________________________________________________________________________________________________________________
Errors     << local_planner:make /home/docker-rajat/catkin_ws/logs/local_planner/build.make.000.log
In file included from /home/docker-rajat/catkin_ws/src/avoidance/local_planner/src/nodes/local_planner_node.cpp:1:0:
/home/docker-rajat/catkin_ws/src/avoidance/local_planner/src/nodes/local_planner_node.h:18:48: fatal error: mavros_msgs/CompanionProcessStatus.h: No such file or directory
In file included from /home/docker-rajat/catkin_ws/src/avoidance/local_planner/src/nodes/local_planner_node_main.cpp:1:0:
/home/docker-rajat/catkin_ws/src/avoidance/local_planner/src/nodes/local_planner_node.h:18:48: fatal error: mavros_msgs/CompanionProcessStatus.h: No such file or directory
compilation terminated.
compilation terminated.
make[2]: *** [CMakeFiles/local_planner_node.dir/src/nodes/local_planner_node.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [CMakeFiles/local_planner_node.dir/src/nodes/local_planner_node_main.cpp.o] Error 1
make[1]: *** [CMakeFiles/local_planner_node.dir/all] Error 2
make: *** [all] Error 2
cd /home/docker-rajat/catkin_ws/build/local_planner; catkin build --get-env local_planner | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
..............................................................................................................................................
Failed     << local_planner:make                   [ Exited with code 2 ]
Failed    <<< local_planner                        [ 11 minutes and 49.5 seconds ]
[build] Summary: 2 of 3 packages succeeded.
[build]   Ignored:   None.
[build]   Warnings:  2 packages succeeded with warnings.
[build]   Abandoned: None.
[build]   Failed:    1 packages failed.
[build] Runtime: 11 minutes and 58.2 seconds total.
[build] Note: Workspace packages have changed, please re-source setup files to use them.

Operating System is Ubuntu 16.04 with ROS Kinetic
Mavros version: Version: 0.27.0-0xenial-20181116-184226-0800
Mavlink version: Version: 2018.11.11-0xenial-20181113-004213-0800

@rajat2004 Hi, sorry about that. The recent developments are not yet in the packaged version. Could you please use the installation from sources. You can follow the instructions here https://github.com/mavlink/mavros/blob/master/mavros/README.md#source-installation

Thanks for the quick reply
Do I need to first remove mavros and then install it from source or can I directly go ahead with source installation?
Also, for source installation, should I use the latest released upstream package or the latest one under development

yes, you should remove the mavros package. Actually I realized that it's better if you clone mavros master (https://github.com/mavlink/mavros) into catkin_ws/src/ and build it with catkin build mavros mavros_extras mavros_msgs

The build completed successfully after building mavros like you said.
Thanks for the help :)


Create a Github Action to Add Hacktoberfest Tag to all the Issues

Aim

Creating a Github Action to Add Hacktoberfest Tag to all the Issues

Details

Action which is Invoked on October 1st and Removes all the tags in October 31st

Is this issue up for Hacktoberfest? If so I can create a PR on October 1

Is this issue up for Hacktoberfest? If so I can create a PR on October 1

@mdb571 Ya, Sure...

Should I add source code for my action as folder or just add the action workflow to the repo?

Should I add source code for my action as folder or just add the action workflow to the repo?

Just Add Action to the workflow


fix: Specify content length for gcp copy request

Which issue does this PR close?

N/A
This fixes an issue where copy requests for the GCS object store would error due to a missing content-length header.
Rationale for this change

We hit "Error 411 (Length Required)" on the copyTo endpoint when calling copy_if_not_exists for the GCS object store.
An example error response that we get:
"Generic GCS error: Error performing copy request databases/00000000-0000-0000-0000-000000000000/tmp/299e25c3-a5f5-445c-97ca-28f37f64fb29/lease: response error \"<!DOCTYPE html>\n\n  <meta charset=utf-8>\n  <meta name=viewport content=\"initial-scale=1, minimum-scale=1, width=device-width\">\n  <title>Error 411 (Length Required)!!1</title>\n  \n  \n
411. That’s an error.\n
POST requests require a Content-length header.  That’s all we know.\n\", after 0 retries: HTTP status client error (411 Length Required) for url (https://storage.googleapis.com/storage/v1/b/sean-test-glaredb/o/databases/00000000-0000-0000-0000-000000000000/tmp/299e25c3-a5f5-445c-97ca-28f37f64fb29/lease/copyTo/b/sean-test-glaredb/o/databases/00000000-0000-0000-0000-000000000000/visible/lease?ifGenerationMatch=0)"

Getting a reproducible test case for this has been incredibly tricky. We believe that it comes down to whether or not the object_store crate gets compiled with native-tls or rust-tls. See https://github.com/RustomMS/test-object-store for our best shot at reproducing.
I also believe that this change would fix this issue https://github.com/delta-io/delta-rs/issues/878.
What changes are included in this PR?

Explicitly sets content-length to 0 for GCS copyTo request.
Are there any user-facing changes?
No.

Thank you for debugging this, I can reproduce this locally, wild :sweat_smile:

Thank you for debugging this, I can reproduce this locally, wild 😅

Yeah we were quite confused too. Still don't know why that happens though...

Still don't know why that happens though...

Might be worth raising an issue on reqwest to see if they have any ideas what might be causing it


Document indexing semantics

I'm curious why the API has this indexing syntax and why it's different from standard Julia array indexing.
julia> A = AxisArray(reshape(1:60, 12, 5), (.1:.1:1.2, .1:.1:.5));

julia>  A[Axis{:col}(2)] == A[:,2]
true

julia>  A[Axis{:col}(2)] === A[:,2]
false

I'm not sure if it was intentional. There's a difference in how the indexes into the subarray become stored. With Axis, it's Colon, and with direct indexing, it's a UnitRange.
julia> a = AxisArray(reshape([1:24], 12,2), (.1:.1:1.2, [:a,:b]))

julia> dump(a[Axis{:col}(2)])
AxisArrays.AxisArray{Int64,1,SubArray{Int64,1,Array{Int64,2},(Colon,Int64),2},(:row,),(FloatRange{Float64},)}
  data: SubArray{Int64,1,Array{Int64,2},(Colon,Int64),2}
    parent: Array(Int64,(12,2)) 12x2 Array{Int64,2}:
  1  13
  2  14
  3  15
  4  16
  5  17
  6  18
  7  19
  8  20
  9  21
 10  22
 11  23
 12  24
    indexes: (Colon,Int64) (Colon(),2)
    dims: (Int64,) (12,)
    first_index: Int64 13
    stride1: Int64 1
  axes: (FloatRange{Float64},) (0.1:0.1:1.2,)

julia> dump(a[:,2])
AxisArrays.AxisArray{Int64,1,SubArray{Int64,1,Array{Int64,2},(UnitRange{Int64},Int64),2},(:row,),(FloatRange{Float64},)}
  data: SubArray{Int64,1,Array{Int64,2},(UnitRange{Int64},Int64),2}
    parent: Array(Int64,(12,2)) 12x2 Array{Int64,2}:
  1  13
  2  14
  3  15
  4  16
  5  17
  6  18
  7  19
  8  20
  9  21
 10  22
 11  23
 12  24
    indexes: (UnitRange{Int64},Int64) (1:12,2)
    dims: (Int64,) (12,)
    first_index: Int64 13
    stride1: Int64 1
  axes: (FloatRange{Float64},) (0.1:0.1:1.2,)

Oh interesting. I didn't think about that. This should become consistent once the Julia parser lowers colons as Colon() instead of calculating the range (which I believe is the plan).
We definitely need to document the view/copy behaviors, though.


King q1 - garage door

Please explain your feature request in a one or two sentences.

any predictions for king-q1? today it is misrecognized as a window curtain.

Is your feature request related to a problem? Please describe.

Any particular eWeLink devices that this relates to?

King-Q1 - garage door

Anything else?

Hi @carlosptf
Can you share a webpage link to the device you have? I have never heard of this device.
If it is like the KingArt King-Q4 then this device is a blind/curtain type.
https://www.globalsources.com/Smart-curtain/WiFi-roller-shutter-switch-curtain-blinds-switch-1174334804p.htm#1174334804

Hi, here on EWeLink it is listed as model king-Q1
https://a.aliexpress.com/_mLM6Dar
Em 23 de ago. de 2021 04:27 -0300, Ben @.***> escreveu:

Hi @carlosptf
Can you share a webpage link to the device you have? I have never heard of this device.
If it is like the KingArt King-Q4 then this device is a blind/curtain type.
https://www.globalsources.com/Smart-curtain/WiFi-roller-shutter-switch-curtain-blinds-switch-1174334804p.htm#1174334804
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

And can you set the position anywhere between 0 and 100% or is just OPEN or CLOSED?

both, in EWeLink it lets you choose between 0% and 100%, but I only use the closed and open option. when I put, for example, 10%, every garage door is open
Em 23 de ago. de 2021 11:08 -0300, Ben @.***> escreveu:

And can you set the position anywhere between 0 and 100% or is just OPEN or CLOSED?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

This should be possible. With these garage door devices for security reasons, I consider 0% to be closed and 1-100% to be open, this is how the state would be relayed in homekit.
I will get back to you…

HomeKit does not allow for %-based positioning for garages, it is simply OPEN or CLOSED.

Or, with the latest beta of the plugin you can change the accessory type from a window blind to a door (separate homekit accessory type from garage door), which allows for %-based positioning. I will still work on a garage door implementation and let you know when ready to test

I installed the beta version, but it doesn't work. I believe it should be an open and closed implementation only, (in Ewelink the % does not work). The difference of the KING - Q1 is that it has an open and closed sensor.
Thank you for your support ;)
Em 23 de ago. de 2021 12:32 -0300, Ben @.***>, escreveu:

Or, with the latest beta of the plugin you can change the accessory type from a window blind to a door (separate homekit accessory type from garage door), which allows for %-based positioning. I will still work on a garage door implementation and let you know when ready to test
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

I am unsure how ewelink would report the status of the sensor to the plugin.
I would need you to share the device to my ewelink account... at a time when you're home obviously since it's a garage door... and for you to let me open/close the door a few times so I can see how the sensor state is reported to the plugin.
Would you be happy to do this? Happy to message on discord if it's easier.
https://discord.gg/cMGhNtZ3tW

I installed the beta version, but it doesn't work.

You would need to configure the device to show as a different accessory type...


fix: notification highlight types

https://www.tampermonkey.net/documentation.php?locale=en#api:GM_notification

In fact, the type of highlight property in the GM_notification callback is boolean instead of string

v3.1.4


LibrePhotos window goes blank while scrolling through photos

🐛 Bug Report

[x] 📁 I've Included a ZIP file containing my librephotos log files
[x] ❌ I have looked for similar issues (including closed ones)
[x] 🎬 (If applicable) I've provided pictures or links to videos that clearly demonstrate the issue

📝 Description of issue:
I'm a new user of LibrePhotos having freshly installed via docker and indexed my photo collection this weekend. Everything appears to have worked correctly, just over 42,000 images total.
On any browser on either mac or pc (haven't tried mobile), when scrolling through the main collection of photos, approximately 10 "pages" down the entire window immediately goes white. When this happens the browser developer console reports the following errors (see attached screenshot):

Error: Invalid unit value at util.js 235:11 / Uncaught Error: Invalid Unit Value (util.js 235:11, util.js:245:35) at Function.value (duration.js:244:15)

If I use the browser scroll bar to scroll far down the page before hitting the issue, it appears I can then browse the rest of the collection, so it seems tied to a specific part of the collection near the top.
🔁 How can we reproduce it:
I can provide you access to my install/collection, just dm me if needed.
Please provide additional information:

💻 Operating system:  Reproduces on either Windows 11 or Mac, using Safari, Edge, Chrome or Firefox browsers
⚙ Architecture (x86 or ARM):  x64 (Windows), M1 (Mac)
🔢 Librephotos version: Docker:latest (2022w34)
📸 Librephotos installation method (Docker, Kubernetes, .deb, etc.): Docker

🐋 If Docker or Kubernets, provide docker-compose image tag: latest

📁 How is you picture library mounted (Local file system (Type), NFS, SMB, etc.): SMB
☁ If you are virtualizing librephotos, Virtualization platform (Proxmox, Xen, HyperV, etc.): Ubuntu Docker, no VM

logs.zip

https://user-images.githubusercontent.com/7720102/189540981-1f0c45c2-62c7-4e34-9ed7-1e3f3a907ca9.mp4

I had the same problem in my collection and did a little digging:
I first observed that it was happening consistently at the same position so I hypothesized that it was a particular image that trying to display that caused the problem.  I narrowed it down to a particular month using the search feature.  It would reliable occur searching for that month unless I used a really small screen that fit fewer images, where I would need to scroll down first.  That seemed to confirm it was a problem image.
I then took to developer tools and pulled the item object that was causing the error in Video Overlay (see below).  The item has video type but video_length is "".  This causes it to fail when it tries to generate what appears to be the duration overlay, because "" does not convert to a number of seconds.
{
    "id": "b8658a3150c3d37d6904aaa116a29ed51",
    "dominantColor": "#000000",
    "url": "b8658a3150c3d37d6904aaa116a29ed51",
    "location": "",
    "date": "2022-01-22T01:30:08+00:00",
    "birthTime": "2022-01-22T01:30:08Z",
    "aspectRatio": 1.33,
    "type": "video",
    "video_length": "",
    "rating": 0,
    "owner": {
      [...]
    },
    "style": {
        "width":<PHONE_NUMBER>5714286,
        "height":<PHONE_NUMBER>0612244,
        "translateX": 160,
        "translateY": 2207
    }
}

Investigating the actual images from that month I found that I had a single .wmv video - the only one in my library (the rest being mp4s).  I suspected this may have been the cause so moved it out of the librephotos folder and rescanned to remove the one missing image.  This resolved the problem.  I then converted that video to mp4 with ffmpeg and re-added it and I can now scroll my entire library without a whitescreen.  Would be interested to know if @millercentral also has a WMV file in their library or if there is a different culprit in their case.
Looking at the github copy of VideoOverlay.tsx it looks like this might have already been addressed in 5a6a399?  The added check on item.video_length should prevent it from trying to convert the duration in the empty case.  My only thought then would be whether there is something else up with the initial video processing of WMV where video_length should be getting set but isn't.  But it's also possible that my file was just weird and missing some length metadata it is supposed to have and that was added back as part of the re-encoding process.

Yes, I pushed an update. I think you are using an older docker image, which doesn't include the fix. Thanks for the thorough explanation and the debugging :)

I can confirm this no longer repros, thank you! Is there a better tag to use for my docker config? I don't mind being bleeding edge.

If you use the docker-compose setup, then you can switch to the dev tag. The dev tag is always on the latest commit, which means it updates frequently :)


setAdapter should unregister from current adapter

The current implementation unregisters from the new adapter, which
is incorrect and leads to the old adapter never being unregistered.

Good catch! Thanks!


YSTORM-2725: Generic Resource Scheduling - initial config changes and…

… TopologyBuilder API

@govind-menon
Looks like duplicated PR and #2385 covers this. If I'm right let's close this.


Run tests as part of PR checks

Right now when a PR is created tests are not ran so the PR can be merged even if tests would fail. We want tests to be ran for PR's and not allow merging unless tests pass.

https://github.com/zio/zio-connect/pull/29


Allow callers to provide a resolver for "$ref" schemas

Presently, when validation encounters a $ref it looks it up in a package-scoped DefaultSchemaPool, and not finding it there requests it over HTTP.
The problem with this for my use case, is that I would like to allow users to update schemas (so would need to invalidate the cached copy in DefaultSchemaPool), and I would like to allow them to use private schemas, which would not be accessible over HTTP.
It seems like it might be a generally nice feature to introduce an SchemaResolver interface that the DefaultSchemaPool and HTTP fetching are packaged behind, and allow callers to plug in their own.
If I make such a pull request, would you be open to it?
Thank you,
Rob

The spec seems to agree with me with some SHOULDs
https://json-schema.org/latest/json-schema-core.html#rfc.section.8.3.1
8.3.1. Loading a referenced schema
The use of URIs to identify remote schemas does not necessarily mean anything is downloaded, but instead JSON Schema implementations SHOULD understand ahead of time which schemas they will be using, and the URIs that identify them.
When schemas are downloaded, for example by a generic user-agent that doesn't know until runtime which schemas to download, see Usage for Hypermedia [hypermedia].
Implementations SHOULD be able to associate arbitrary URIs with an arbitrary schema and/or automatically associate a schema's "$id"-given URI, depending on the trust that the validator has in the schema. Such URIs and schemas can be supplied to an implementation prior to processing instances, or may be noted within a schema document as it is processed, producing associations as shown in section 8.2.4.

Sorry for the delay on this @robfig we would absolutely be open to such a thing. We've been meaning to implement such facilities for a while, but are too bogged down atm. We have some commented-out unit tests & TODOs regarding loading referenced schemas if my memory serves correctly. Thanks for filing in advance!
Our only non-standard request when working is to use Qri's commit-message guidelines which helps us automate changelogs.

If there's anything you need from us before filing, like working out the interface, I'd be happy to collaborate on this issue. Otherwise I'll make sure a few of us are around for prompt turnaround on reviews.
Thanks again!

Here's a draft, but I ran into some issue getting the tests working. It seems that the references in the test case are not actually attempted to be resolved, for some reason.
https://github.com/qri-io/jsonschema/commit/a12c30bf6b8adf00bb9c51a5b3cbd44c680a651e

This is looking really good!
Try adding this after line 646 of schema_test.go in that branch 😉
rs.FetchRemoteReferences()

DefaultSchemaPool seems to no longer exist. I guess it's called SchemaRegistry now?
It also seems to force global state on you, which is just weird and wrong...


Deleting test

~When deleting the test it doesn't cascade view deletion correctly and DB error is thrown.~
Actually the cascading error is due to view deletion.

[x] we should have a dialog confirming that where you type the number of runs.

Fixed. The runs from a deleted test are now trashed.


Missing test classes for LWC apex controllers

Certain apex controllers used by LWC doesn't have any test coverage. Is it possible to add proper test coverage for these apex classes? It will also act as a nice reference on how to actually write test classes for ConnectApi methods.
https://github.com/forcedotcom/commerce-on-lightning/tree/develop/examples/b2b/lwc/force-app/main/default/classes

Hello, this should be filed with the domain teams in charge of the apex classes we deploy. We will keep an eye on this.


⚠ SolarOscp has degraded performance

In a4704bd, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 149 ms

Resolved: SolarOscp performance has improved in 92a4f5f after 10 minutes.


f_punchhole for < macos 10.12?

Is there a way to get the punchhole headers needed to compile hyperkit onto a < 10.12 system? I was trying to compile the latest master branch today when I ran into the same error described in #160:
src/lib/block_if.c:275:21: error: variable has incomplete type 'struct fpunchhole'
                struct fpunchhole arg = { .fp_flags = 0, .reserved = 0, .fp_offset = (off_t) fp_offset, .fp_length = (off_t) fp_length };
                                  ^
src/lib/block_if.c:275:10: note: forward declaration of 'struct fpunchhole'
                struct fpunchhole arg = { .fp_flags = 0, .reserved = 0, .fp_offset = (off_t) fp_offset, .fp_length = (off_t) fp_length };
                       ^
src/lib/block_if.c:276:26: error: use of undeclared identifier 'F_PUNCHHOLE'
                ret = fcntl(bc->bc_fd, F_PUNCHHOLE, &arg);
                                       ^
src/lib/block_if.c:713:22: error: variable has incomplete type 'struct fpunchhole'
                        struct fpunchhole arg = { .fp_flags = 0, .reserved = 0, .fp_offset = 0, .fp_length = 0 };
                                          ^
src/lib/block_if.c:713:11: note: forward declaration of 'struct fpunchhole'
                        struct fpunchhole arg = { .fp_flags = 0, .reserved = 0, .fp_offset = 0, .fp_length = 0 };
                               ^
src/lib/block_if.c:714:18: error: use of undeclared identifier 'F_PUNCHHOLE'
                        if (fcntl(fd, F_PUNCHHOLE, &arg) == 0) {
                                      ^
4 errors generated.
make: *** [build/lib/block_if.o] Error 1
cc src/lib/block_if.c

It is not supported on previous versions. You could hack around it I
guess...
On 3 Dec 2017 17:32, "genevera"<EMAIL_ADDRESS>wrote:

Is there a way to get the punchhole headers needed to compile hyperkit
onto a < 10.12 system? I was trying to compile the latest master branch
today when I ran into the same error described in #160
https://github.com/moby/hyperkit/issues/160:
src/lib/block_if.c:275:21: error: variable has incomplete type 'struct fpunchhole'
struct fpunchhole arg = { .fp_flags = 0, .reserved = 0, .fp_offset = (off_t) fp_offset, .fp_length = (off_t) fp_length };
^
src/lib/block_if.c:275:10: note: forward declaration of 'struct fpunchhole'
struct fpunchhole arg = { .fp_flags = 0, .reserved = 0, .fp_offset = (off_t) fp_offset, .fp_length = (off_t) fp_length };
^
src/lib/block_if.c:276:26: error: use of undeclared identifier 'F_PUNCHHOLE'
ret = fcntl(bc->bc_fd, F_PUNCHHOLE, &arg);
^
src/lib/block_if.c:713:22: error: variable has incomplete type 'struct fpunchhole'
struct fpunchhole arg = { .fp_flags = 0, .reserved = 0, .fp_offset = 0, .fp_length = 0 };
^
src/lib/block_if.c:713:11: note: forward declaration of 'struct fpunchhole'
struct fpunchhole arg = { .fp_flags = 0, .reserved = 0, .fp_offset = 0, .fp_length = 0 };
^
src/lib/block_if.c:714:18: error: use of undeclared identifier 'F_PUNCHHOLE'
if (fcntl(fd, F_PUNCHHOLE, &arg) == 0) {
^
4 errors generated.
make: *** [build/lib/block_if.o] Error 1
cc src/lib/block_if.c
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/moby/hyperkit/issues/170, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAdcPKoosVkYdTdIn1vvrud0x06ZTD24ks5s8y-ogaJpZM4Qz8sO
.

That's what I did :).  I checked out the version of block_if.c before the pr was merged and it compiled fine.

AIUI from when this is added the important factor is the version of xcode (for the headers), not the version of the OS. Can you try the latest xcode please.
Closing as a duplicate of #160.

@ijc I did try that initially. Unfortunately the latest Xcode does not install on El Capitan.

macOS just keeps getting worse 😞


Menu items inconsistency

Sometime items from left menu just disappear (tested with Hugo 0.25.1 and 0.29). I said sometime, cause the issue appear few time (about 1 time / 4 "compilation")
By example I have the following left menu:
Book 1
   - Page 1
   - Page 2
   - Page 3
Book 2
   - Chapter 1
         - Page 1
         - Page 2
         - Page 3
   - Chapter 2
         - Page 1
         - Page 2

Sometime, when I visit a page (random, issue is not consistent) the left menu remove some links, by example, the above left menu become
Book 1
   - Page 1
   - Page 2
   - Page 3
Book 2
   - Chapter 1
         - Page 1
         - Page 2  [VISITED PAGE]

With -v (verbose), I see no warnings or errors during generation...

Maybe the problem is in your theme's implementation. Which theme are you using?

Hi @MunifTanjim
I'm using the theme "learn" (https://github.com/matcornic/hugo-theme-learn). Here the layout who render the left menu : https://github.com/matcornic/hugo-theme-learn/blob/master/layouts/partials/menu.html


Refactor razor backing buffer

This uses a modified https://github.com/rynowak/mvc-sandbox/tree/master/workloads/BigViews (modified to use a Layout and fewer items so that SelectListItem doesn't dominate the results)
For 3000 requests, this dropped allocations by about 12 MB (~5%). The comparisons aren't fully equivalent because some types disappeared entirely which is tricky to compare.
Before

After

cc @rynowak

Few comments but looks like a good start.

:up: :date:

Can get we some numbers for BasicViews also? (Both with and without TagHelpers). I want to see how many chunks get created for each request.

TagHelpers continue to use non-buffer pooled StringCollectionTextWriter so we're not going to see much improvement there. I'll send a follow up PR to address that (and combine HtmlTextWriterWrapper and StringCollectionTextWriter).
Before

After

This is still a really nice improvement for the basic scenario :+1: Excelsior!

:up: :date:

:up: :date:

:shipit: !


Upgrade mypy

Gets us using mypy 1.1.1 for type checking while still having tests run against 1.0.1 and earlier, and 1.1.1.
Adds the ability to store expected output files for older mypy versions as necessary.
In response to #5249

please review


Make Go output fmt-compliant

[X] JSON attributes are not horizontally aligned:

 type TopLevel struct {
-	Y []*float64 `json:"y"` // array of optional
-	X []DoubleOrNullOrString `json:"x"`
+	Y []*float64               `json:"y"`
+	X []DoubleOrNullOrString   `json:"x"`
 	Z []DoubleOrDoubleArrayOrZ `json:"z"`
 }

And weirdly it deletes comments.  That must be a bug.

[ ] Align comments (on consecutively commented lines)
[ ] Use tab for indentation

We don't emit comments anymore, and we use tabs, but we pad all columns of a table, including the last one, resulting in trailing whitespace.


JobService panics if directory for SQLite db does not already exist

If the directory for the SQLite database that JobService uses (as specified for the key databasePath in config/jobservice/config.yaml) does not already exist, JobService will immediately panic and exit.  The panic is preceded by a misleading error that SQLite is "out of memory".
The code should check for the existence of the directory, and if not there, it should attempt to create it. If the creation fails, it should log and exit.

Merged with #1389


FlutterStatusbarcolor.setStatusBarWhiteForeground(false) being automatically reverted to true moments after successfully being set false

Main main method:
void main() {
  FlutterStatusbarcolor.setNavigationBarColor(Colors.white);
  FlutterStatusbarcolor.setNavigationBarWhiteForeground(false);
  FlutterStatusbarcolor.setStatusBarColor(Colors.white);
  FlutterStatusbarcolor.setStatusBarWhiteForeground(false); // automatically gets reverted even with empty project
  runApp(Messages());
}

After hot restarting and/or full restarting, the color of the status bar icons goes from dark to light. I will provide any additional informationt that I can just let me know, thanks.

Yeah, the status bar icons get reverted if the app lifecycle changed.
You can try example app. Flutter's WidgetsBindingObserver can fix this.

That worked but I don't understand why :(

I'm seeing this too. I'll try the timer.


Send 0.19.0 version showing vulnerability

We are currently using send latest version 0.19.0, which is reported to have vulnerabilities. We need to know when a fix for these vulnerabilities is expected. Is there an estimated time of arrival (ETA) for a resolution?
Vulnerability: send vulnerable to template injection that can lead to XSS
url:  https://github.com/advisories/GHSA-m6fv-jmcg-4jfg

See: https://github.com/pillarjs/send/issues/239#issuecomment-2399134135
I think this was solved with express 4.21.0


Basic UI for starting a job

r @anoshaminai @sandlerben
Create a basic web form that takes in a URL (to the audio link) and email addresses, starts a job, and goes back to form

Left a small comment, besides that lgtm

Let me know when you make the changes we talked about today. I'll give it a review then.


Email Sharing : % is not visible in email

If email body contains %, it display unknown character in chrome using gmail

Hello @subodhsri, I think this issue is related to #196, I'll try to fix them both if the provided solution works


2966: Migrating to Modern Yarn

Short description
Upgraded to<EMAIL_ADDRESS>Proposed changes

yarnrc.yml will have nodeLinker: node-modules meaning its not depending on pnp more on that at (https://yarnpkg.com/features/pnp)
Note we can do hybrid pnp in the future look at https://yarnpkg.com/getting-started/recipes#hybrid-pnp--node_modules-mono-repo

nohoist is deprecated so I removed it and added nmHoistingLimits: workspaces

This yarn version at some places it complains about --silent so I removed some of them. Still looking for a way to silent these warnings.

Note: not tested on iOS and focused mainly on integrate native and integrate web app.
Side effects

Not sure
Testing

I used this time: Node 22.9.0 you can install by nvm

before yarn install make sure to run corepack enable once to activate Corepack.

I suggest to delete all node modules files from the repo then do yarn install.

Resolved issues

Fixes: #2966

Thank you, I probably won't manage to have time today to take a look at it but maybe also check out this old PR that was never merged to see what went wrong there and if this PR fixes the issues: https://github.com/digitalfabrik/integreat-app/pull/2588

Thank you, I probably won't manage to have time today to take a look at it but maybe also check out this old PR that was never merged to see what went wrong there and if this PR fixes the issues: #2588

I found out it needs to be bit more in the oven.. sorry.. yarn test is not working I'm investigating...I will convert this PR to Draft for now


Probot receive errors with "TypeError: appFn is not a function"

Bug Report
Current Behavior
I'm testing locally with the node_modules/.bin/probot receive -e pull_request ... command.
I get an TypeError: appFn is not a function.
The reason might because I've set up my main function as follows (since this project deploys to serverless):
export function handler(app: Application) {
  app.on(['pull_request.opened'], async context => {...}
};

probot run npm start works just fine. This only happens when I call probot receive. Any tips here would be appreciated. Thank you!
Environment

Probot version(s): "version": "10.9.0"
Node/npm version: ">= 12.18.2"
OS: OS 10.15.6

Ah nvm. I figured it out . thanks!

Can you try to export the function as default?
export default function handler(app: any) {
  app.on(['pull_request.opened'], async context => {}
};

Thanks for the suggestion. I tried it but got the same error
What's usually the cause of this error? Is it possible to just manually suppress this error?
nicolezhu$ node_modules/.bin/probot receive -e pull_request -p test/fixtures/events/pr_opened.json ./build/src/auto-label.js
/Users/nicolezhu/Desktop/repo-automation-bots/packages/auto-label/node_modules/probot/lib/application.js:77
            appFn(this);
            ^

TypeError: appFn is not a function
    at Application.load (/Users/nicolezhu/Desktop/repo-automation-bots/packages/auto-label/node_modules/probot/lib/application.js:77:13)
    at Probot.load (/Users/nicolezhu/Desktop/repo-automation-bots/packages/auto-label/node_modules/probot/lib/index.js:186:13)
    at /Users/nicolezhu/Desktop/repo-automation-bots/packages/auto-label/node_modules/probot/lib/index.js:194:62
    at Array.forEach (<anonymous>)
    at Probot.setup (/Users/nicolezhu/Desktop/repo-automation-bots/packages/auto-label/node_modules/probot/lib/index.js:194:38)
    at Object.<anonymous> (/Users/nicolezhu/Desktop/repo-automation-bots/packages/auto-label/node_modules/probot/bin/probot-receive.js:64:8)
    at Module._compile (internal/modules/cjs/loader.js:1075:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1096:10)
    at Module.load (internal/modules/cjs/loader.js:940:32)
    at Function.Module._load (internal/modules/cjs/loader.js:781:14)

can you share the content of test/fixtures/events/pr_opened.json? I tried to reproduce your problem, but had no luck: https://gist.github.com/gr2m/08a749b9eb98ba73e83184894d78675c. You can check out the gist like this
git clone https://gist.github.com/08a749b9eb98ba73e83184894d78675c.git probot-1371
cd probot-1371
npm install

Then run
node_modules/.bin/probot receive -e push-event.json -p push-event.json ./index.js

closing due to inactivity

Just to provide a possible solution for people who encounter same issue - I was able to solve the problem by simply exporting default anonymous function, e.g.:
export = (app: Probot) => {
};


add explanation for ROS_DISABLE_LOANED_MESSAGES.

document for https://github.com/ros2/rcl/pull/949
Signed-off-by: Tomoya Fujita<EMAIL_ADDRESS>

@wjwwood @clalancette requesting review.

@wjwwood @clalancette requesting review.

I agree this seems like we're hijacking this beginner tutorial in order to turn it into a reference for all the environment variables that can be used to configure ros 2, when we should just have a reference space for that (not a tutorial).
Do we already have such a page?

I could see putting a new page in either "How-To-Guides", something like "how to disable loaned messages", or in "Concepts", something like "loaned messages" which describes generally what they are and as part of that how to use this environment variable to control them.
Or we could have a reference page with all the environment variables you could use with ros 2, where one of them is this env var, but I don't know where that would live.
@clalancette what do you think?

thanks for the comment. I understand this is not really tutorial... :sweat_smile:

a new page in either "How-To-Guides", something like "how to disable loaned messages", or in "Concepts", something like "loaned messages" which describes generally what they are and as part of that how to use this environment variable to control them.

sounds good to me.

I could see putting a new page in either "How-To-Guides", something like "how to disable loaned messages", or in "Concepts", something like "loaned messages" which describes generally what they are and as part of that how to use this environment variable to control them.

Yeah, that works for me too.  I think it would be nice to have a page showing all of the possible environment variables that can be used with ROS 2, but I think that would be a long list, and is out-of-scope for this particular change.

@clalancette @wjwwood could you take a look again?

@wjwwood @clalancette
this is last one related to ROS_DISABLE_LOANED_MESSAGES, either of you can review?


JSON printing code code refactoring, switching test suite to run on JSON mode

Pull Request Test Coverage Report for Build 152

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
1838 unchanged lines in 33 files lost coverage.
Overall coverage increased (+5.9%) to 79.67%

Files with Coverage Reduction
New Missed Lines
%

check_core.rs
2
88.35%

block_preds.rs
4
100.0%

file_writer.rs
5
59.68%

file_reader.rs
8
81.67%

file_error.rs
8
24.24%

integer_utils.rs
9
56.25%

progress_report.rs
10
86.11%

main.rs
13
93.75%

general_error.rs
13
65.0%

sbx_specs.rs
14
88.46%

Totals

Change from base Build 151:
5.9%

Covered Lines:
3092

Relevant Lines:
3881

💛  - Coveralls

Codecov Report

Merging #71 into master will increase coverage by 14.89%.
The diff coverage is 46.37%.

@@             Coverage Diff             @@
##           master      #71       +/-   ##
===========================================
+ Coverage   73.76%   88.65%   +14.89%
===========================================
  Files          42       53       +11
  Lines        3884     6410     +2526
===========================================
+ Hits         2865     5683     +2818
+ Misses       1019      727      -292

Impacted Files
Coverage Δ

src/main.rs
93.75% <ø> (+3.12%)
:arrow_up:

src/check_core.rs
88.34% <0%> (+88.34%)
:arrow_up:

src/show_core.rs
0% <0%> (ø)
:arrow_up:

src/json_printer.rs
83.65% <100%> (+56.2%)
:arrow_up:

src/cli_calc.rs
99% <100%> (-0.01%)
:arrow_down:

src/decode_core.rs
93.75% <40%> (ø)
:arrow_up:

src/repair_core.rs
86.08% <55.55%> (-0.22%)
:arrow_down:

src/crc_ccitt.rs
100% <0%> (ø)
:arrow_up:

src/sbx_specs_tests.rs
100% <0%> (ø)

src/rs_codec/encoder_tests.rs
93.15% <0%> (ø)

... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a5164...7610873. Read the comment docs.


Fix potential data race in the PC/SC-based reader tracker

We have the functionality that tracks the list of currently available smart card readers based on the information exposed by the PC/SC API.
This implementation has a potential data race that it can miss the changes if they happen between the completion of one PC/SC call and the beginning of the next one. In that case, the change would only be recognized after some time (60 seconds at worst with the current implementation). This bug tracks the fix of this data race.
After this data race gets fixed, we could actually make a small performance improvement by avoiding the need to make a periodic PC/SC call (every 60 seconds currently) from that code.

Now this can be solved in a relatively simple way, using the recent improvement landed in PC/SC-Lite: https://blog.apdu.fr/posts/2024/08/improved-scardgetstatuschange-for-pnpnotification-special-reader/


BUG: Some OAuth sign-in attempts fail

Error:
⨯ AuthApiError: invalid request: both auth code and code verifier should be non-empty
  at handleError (webpack-internal:///(rsc)/./node_modules/@supabase/auth-js/dist/module/lib/fetch.js:74:11)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async _handleRequest (webpack-internal:///(rsc)/./node_modules/@supabase/auth-js/dist/module/lib/fetch.js:117:9)
  at async _request (webpack-internal:///(rsc)/./node_modules/@supabase/auth-js/dist/module/lib/fetch.js:99:18)
  at async SupabaseAuthClient._exchangeCodeForSession (webpack-internal:///(rsc)/./node_modules/@supabase/auth-js/dist/module/GoTrueClient.js:420:33)
  at async eval (webpack-internal:///(rsc)/./node_modules/@supabase/auth-js/dist/module/GoTrueClient.js:741:28) {
__isAuthError: true,
status: 400,
code: 'validation_failed'

To reproduce, continuously sign in until you get this error. It should take a few attempts.
Related:

https://github.com/supabase/auth-helpers/issues/545

can look into this

Fixed

https://github.com/trypear/pear-landing-page/pull/42/commits/9027bca4e850fa4ac15e87e9646d36a45570df5b


CM-619: IEnumerable, ICollection, IList and List - Which One to Use?

retest this please

retest this please

retest this please

retest this please


Moving symbols into RuleKind

To partially address issue https://github.com/LambdaHack/LambdaHack/issues/152 - move hardcoded symbols
This is a superset of my other PR which gets the stack build working

So far, so good. Indeed it makes sense to move all symbols to RuleKind, making it the master file for the mapping from visual class to its representation. Then, in the engine, just use the visual class to determine properties of items (so that they are consistent across a visual class and so easy for the player to remember) and keep visual representation out of the engine. If exceptions are needed, these can be based on non-visual item properties --- there are various mechanisms for that and some properties, e.g., tied to weight of item, are based only on those, never on visual class.


feat: add algolia search

Adds algolia search using the recommended docusaurus defaults. See https://docusaurus.io/docs/search#using-algolia-docsearch for more information.

Hold off on merging though. For some reason this hasn't been indexed yet by Algolia.

Alrighty, indexing fixed. We've got search ladies and gentlemen.