⚠ Bofrost.lu has degraded performance

In 816b4d0, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1306 ms

Resolved: Bofrost.lu performance has improved in 352679d after 6 minutes.


noflo.loadFile - How to know that all IIPs have been sent?

I'm currently trying to test some of my noflo graphs, but ran into an issue regarding IIPs. Some of my components take some extra parameters as IIPs, so I specify those as data packets in the JSON graph file. But noflo.loadFile returns before these packets are sent to the components. This is the order of execution that I generated by putting print statements into the noflo methods:
[TEST] Loading graph file
[NETWORK] Starting Network...
[NETWORK] Network.prototype.sendInitials called
[NETWORK] Network.prototype.sendInitials.send called
[NETWORK] Network Started
...
[NETWORK] Network.prototype.sendInitials processing initials
[NETWORK] Network.prototype.addInitial called
[NETWORK] Expecting 1 initializations
[NETWORK] Network.prototype.addInitial called
[NETWORK] Expecting 2 initializations
[TEST] Graph file returned. 2 initializations pending
...
[NETWORK] Network.prototype.sendInitials processing initials
[NETWORK] Network.prototype.sendInitials processing initials
[NETWORK] Expecting 1 initializations
[NETWORK] Expecting 0 initializations
So my question is - how do I know that all the IIPs have been sent to their associated components to ensure the system has completely started?
Right now I'm using a timeout function, but that's not exactly robust.

Ran into the same issue in noflo-runtime-msgflo now, trying to set/override some 'IIPs' after a NoFlo component has been started.
Due to the way Network.sendInitials() do work async, there is no way to know when all IIPs have been sent...


Fix lint issues for readthedocs.projects app

Due to this lint error:
too-many-locals / Too many local variables (16/15) (col 4)

...I have attempted to split UpdateDocsTask.run into two pieces. Please review carefully.

Just confirmed that the split of UpdateDocsTask.run() is covered by tests (and tests are passing, of course).

Yeah, this looks great. Thanks!


read login info from external file

using args passing login password will leak info,
it will be better to provide other way to read credential.

ah, I am not reading man, my fault


ViewComponent => User as ClaimsPrincipal

HomeController inherit ControllerBase gives User with ClaimsPrincipal
Controller : ControllerBase {
    public ClaimsPrincipal User { get; }
}

DemoViewComponent inherit ViewComponent give User with IPrincipal
ViewComponent {
    public IPrincipal User { get; }
}

Is there any reason for such implementation?

The only reason I can think of is that HttpContext.User used to be IPrincipal and is now ClaimsPrincipal. It looks like controller was updated when that changed and view component was not.

This is how I overcome the difficulty right now.
public class OwnerViewComponent : ViewComponent
{
    public IViewComponentResult Invoke()
    {
        var user = User as ClaimsPrincipal;
        if (user == null) return null;
        var owner = new Owner
        {
            NameIdentifier = user.FindFirst(ClaimTypes.NameIdentifier)?.Value,
            Name = user.FindFirst(ClaimTypes.Name)?.Value,
            GivenName = user.FindFirst(ClaimTypes.GivenName)?.Value,
            Surname = user.FindFirst(ClaimTypes.Surname)?.Value
        };
        return View(owner);
    }
}
public class Owner
{
    public string NameIdentifier { get; set; }
    public string Name { get; set; }
    public string GivenName { get; set; }
    public string Surname { get; set; }
}

Would anything break if you guys change User in ViewComponent to inherit from ClaimsPrincipal?

From https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md#behavioral-changes

Returning a value of a more derived type for a property, field, return or out value

Note, again, that the static type cannot change. e.g. it is OK to return a string instance where an object was returned previously, but it is not OK to change the return type from object to string.

This would be a binary breaking change

:fearful: oops!

This would be a binary breaking change

Mark this as a TODO for 2.0 and yes, make the breaking change #semver.

This was always going to be a breaking change. It's been like this since at least RC1 (I know! I should've reported this earlier.. ). I think 2.0 is too far off so why not mark this as todo for like 1.1 or something?

Assuming the right data all exists, let's add a new property to ViewComponent that returns the right data:
ViewComponent {
    public ClaimsPrincipal UserClaimsPrincipal { get; }
}

It's kind of lame to have two properties that return the same instance, but this is a good and easy solution.

Consider marking User property as obsolete? This way people can switch over to the new ClaimsPrincipal user property gracefully, and then the older property can be removed from a future release?

@dazinator we generally don't mark things as obsolete unless we really think they shouldn't be used, but in this case I think it's fine, no?


Post conditions warning text in dark mode not visible

Noticed this yesterday, I use dark mode most of the time and I saw that the text color of the warning text matches the background, so it is not visible.

It appears this has been fixed, so will close the issue...


Linux: Modifications to allow session restoration

The purpose of this modification is to allow session restoration on linux: the way are to :

Create a labeled session "${tmux_server_session_temporary}" on start of tmux daemon

Let plugin script "restore.sh" restore tmux session

Clean restored session by remove the temporary session "${tmux_server_session_temporary}" which having served to load the tmux daemon

After the start of tmux daemon, start simply tmux with the following command in a terminal console :
tmux a / attach / attach-session
or automate the start of tmux in terminal with adding line to the .basrhrc user file:
type tmux &>/dev/null && tmux ls &>/dev/null && [ -z $TMUX ] && [[ ! $TERM =~ screen ]] && tmux attach-session
;o)

So, why is new-session -d not doing the trick?

Let plugin script "restore.sh" restore tmux session

Note that if someone is running tmux plugins in the background via run -b  (eg run -b '~/.tmux/plugins/tpm/tpm') you may end up killing the temporary session immediately after start, before anything is restored.

So, why is new-session -d not doing the trick?
It's doing the trick, it start the daemon with creation of a NEW session.
At each restart of daemon a new session is created, saved and restored.
x retstarts -> x new sessions.
Not so fun ;o)
A new named session allows it to be deleted immediately after starting the daemon, so that user have just the exact same sessions he left

you may end up killing the temporary session immediately after start, before anything is restored.

If you kill the last tmux session, you kill the daemon (on manjaro / ubuntu)

Sorry, there is an error in my proposal
I'm working on strongly solution in regards to my comment https://github.com/tmux-plugins/tmux-continuum/pull/7#issuecomment-732182110 and my difficulties to kill-session inside the starting script ...

So, why is new-session -d not doing the trick?

Let plugin script "restore.sh" restore tmux session

Note that if someone is running tmux plugins in the background via run -b (eg run -b '~/.tmux/plugins/tpm/tpm') you may end up killing the temporary session immediately after start, before anything is restored.

You are right about the '-b' option, I made a mistake by forgetting it; o)


[Security] Workflow docs.yml is using vulnerable action JamesIves/github-pages-deploy-action

The workflow docs.yml is referencing action JamesIves/github-pages-deploy-action using references 3.5.5. However this reference is missing the commit 661e33871bce8107c9af083f7415176608dce40e which may contain fix to the some vulnerability.
The vulnerability fix that is missing by actions version could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider to update the reference to the action.

Thanks

Closed via commit de920bc6513f3dcae03068cd4464bf9f0621f845


Windows support

Hi,
I'm a huge fan of this platform. We now use it in our company for each app that requires push notifications. Thanks a lot for this great platform.
Do you have any plans for support Windows push notifications as well? It would suck if we have to setup a separate environment, just for supporting Windows. I would rather keep everything within your application.
Kind regards,
C. Sysmans

Hi,
There used to be plans for supporting Windows Phone Notifications, but my
company's windows phone application has been delayed... indefinitely.
So far, I don't have any windows app for testing this feature.
If you are willing to test, I might provide a branch (not too soon, though)
for testing windows notification , using libraries like
https://www.npmjs.com/package/mpns.
2015-09-08 11:22 GMT+02:00 csysmans<EMAIL_ADDRESS>
Hi,
I'm a huge fan of this platform. We now use it in our company for each app
that requires push notifications. Thanks a lot for this great platform.
Do you have any plans for support Windows push notifications as well? It
would suck if we have to setup a separate environment, just for supporting
Windows. I would rather keep everything within your application.
Kind regards,
C. Sysmans
—
Reply to this email directly or view it on GitHub
https://github.com/fredericbarrau/pushserver/issues/5.


Formulate chartist / fundamentalists strategies as python function

Formulate both a chartists and fundamentalist valuation function. Ideally the function has as input an asset and returns a valuation.

We wanted to implement chartist with the moving average trading rules. But can't find a way to make it work with a over the counter market. The chartists analyse the trend of the stock market and decide if they want to sell or buy for the market price, but don't calculate a specific value they give the stock. Therefore, deriving the trading price over the counter is difficult. In particular, when 2 chartists wants to trade.

They could use the prices from previous periods right? They do not need to update continuously during the over the counter market interaction.
Why would two chartists trade then? Because they use different time horizons. One chartist might look at three periods back, while the other at two.

I have come up with the following(probably not written correctly but I hope you get the point.
def chartist():
MALonglength = randint[50,200]
MAShortlength = randint[15,50]
MALong = sum(price.history[MALonglength])/MALonglength
MAShort = sum(price.history[MAShortlength])/MAShortlength
if MAShort<MALong:
return(price.history[-1]*rand[0.6,0.8])
elif MALong<MAShort:
return(price.history[-1]*rand[1.1,1.3])
When he buys, he will not buy something he won't  be able to sell later, even when the price is increasing. The increase he is willing to accept is random and dependent on the agent.
When he sells, he will sell for more than 0 because doing so is the same as holding a stock that fails. It can be thought that although the real life chartist perceives downslopes as future decrease, he is also aware that there could be a turning point. That is why he is only willing to loose a certain percentage, else he will hold and hope the stock will grow in the future or he gets a better offer.
The interval is larger in buy due to risk aversion.

For now we will use a simple method of extrapolating the moving average of the stock.
Further implementation is combined in Issue #25


trouble with negative numbers?

I'm not sure I have this right, but I think it this could be choking on negatives (adapted from http://www.logointerpreter.com/view-program.php?user=spaulc90&program=generate_dragon_fractal):
; generates the actual fractal recursively

to dragon_fractal :size :dir
    if :size < 3 [fw :size]
    right 45*:dir
    dragon_fractal :size*(sqrt 2)/2 1
    left 90*:dir
    dragon_fractal :size*(sqrt 2)/2 -1
    right 45*:dir
end

setxy -50 -135

; Initial value 320 gives a nicely centered dragon
; I don't recommend going over 400 or the browser might crash
; (and the dragon will be aout of view)

dragon_fractal 320 1

Ug, I think I solved the negatives issue, but this still won't run due to too much recursion. I'm a little out of my depth, but was reading about tail recursion here; i wonder if there's some optimization such as discussed here that would allow this. Perhaps logointerpreter.com has implemented this.

http://compgroups.net/comp.lang.logo/-logoforum-tail-recursion/325587


Fixes #24249

Improve forbidding field shadowing in model
multi-inheritance more than one generation.

buildbot, test this please.

Looks like get_parent_list() returns an unordered set, so the error message generated by the test is non-deterministic.

what would be the right way then, 1) change get_parent_list() to return a tuple, 2) do it inline, 3) create a new method to get it ordered.

You'll need to do a bit of research. I'd try changing the return type of get_parent_list() to a list and see if anything breaks (seems a bit misleading to return a set when method name has "list" in it). Another option might be django.utils.datastructures import OrderedSet.

buildbot, test this please.

I think using an OrderedSet converted to a list upon return might be required else parents may appear twice when deal with diamond inheritance. e.g.
class A(models.Model): pass

class B(A): pass

class C(A): pass

class D(B, C): pass

>>> D._meta.get_parent_list()
[B, A, C, A]

It might be worth adding a test for get_parent_list() to make sure it's working properly in this case.

The reason I've chosen list over OrderedSet, because OrderedSet doesn't have a way of bulk update.
But @charettes your right.
Does this make sense now, introducing an additional loop?

I opened a ticket about the ordering of get_parent_list.

get_parent_list()

buildbot, test this please.

merged in 4d73303ee974c5f1ea6af984d4578d817825026d, thanks.


Cannot open legal .pcx file

input.zip

OIIO does not currently support PCX files. PCX was the format of ZSoft's "PC Paintbrush" program, which had its last release in 1991. I remember it well, it was big in the 80s on DOS machines!
If somebody wanted to write a PCX reader and make a PR, we would be happy to accept it.


Test/aws backend acls versioning

Just adding some tests to make sure putting/getting acls to objects on AWS backend works properly when versioning is enabled/suspended.
We don't actually modify ACLs on the data in AWS, we rely on our own metadata for ACLs.

PR has been updated. Reviewers, please be cautious.

@ironman-machine try

Hello @electrachong
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/16184' with the following env. args:
{
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "master",
    "SCALITY_S3_BRANCH": "TEST/aws-backend-acls-versioning"
}

end-to-end auto-retried here; http://ci.ironmann.io/gh/scality/Integration/16198#build-parameters

end to end passed here: http://ci.ironmann.io/gh/scality/Integration/16191#build-parameters


cheat crashing when injecting

whenever i inject the cheat it crashes and gives me an error message

same

anyone know whats up?

game update, i had an exam today but ill look at it a bit when im home


Destructor handling and safety

In the current code, there is a big safety hole around destructors:
Wayland Proxies/Resources objects do not have a Drop impl. The rationale behind this is that you don't need to keep them around if the reference provided to you in the handler methods is enough, this stays close to the design of the original C library.
However, there are destructor events. So for now, once you've called a destructor method or received a destructor event, you must not use the object again, or it may completely mess up the internal state of the C library.
This is obviously unsafe, but without any unsafe keyword. But I can't find a way to handle this properly which isn't either very cumbersome for the user of the libs, or adds significant overhead.
My ideas for now:

Stay like this, and document properly that here are hidden unsafeties in the lib
Don't provide handles to proxy/resources to the user in the callback, but only an ID. They are responsible to keep everything alive, and finding in their collections the appropriate object given its ID to use it. This is still unsafe, because the user must destroy the objects when they receive a destructor event, (on the contrary, the current design destroys the C object automatically, but not the rust handle)
Automatically track liveness of the objects with a "destroyed" flag. This means this flag must be checked at each method call, involving at least two pointer indirection and an atomic read, I think.

I think the third solution is the best one, it really depends on how significant this overhead is, and I have no idea how much it is.

Yeah the destroyed flag seems to be the best solution.
Would it be possible to have the "worst of both world" so to speak, by providing raw bindings that would not check this flag, for those who would be willing to deal with it manually / aren't going to be dealing with objects that will be destroying themselves?

Hmm... I don't see any way to do it except by providing two versions of all the libs.
Also, it appears after some quick evaluation that this overhead will not be very large compared to the raw cost of dispatching a message, so it probably would not be too much of a problem.
Or do you have other concerns than performance?

If it's too much effort, then yeah it's not a huge concern especially if it's not actually a huge bottle neck.

Hopefully the fix is en route.
Quick question  @Timidger : what kind of interaction do you hope to make between wlc and wayland-server? Is it just declaring a few globals that will specifically be handled manually and letting the rest to wlc?
If it's just that, it'll be okay. but sharing wl_ressources between wayland-server and wlc will very likely be highly unsupported, as wayland-server relies a lot on the user_data field of wl_resource.
At least, there must be a clear distinction between ressources managed by wlc and ressource managed by wayland-server. (I don't know at all what wlc does tbh)

Hmmm, one of the primary (and most immediate) use cases we had for the wayland ipc was to allow backgrounds to be managed by an external client. That way Way Cooler didn't have to worry about backgrounds, a different program could and we could simply draw the surface they give us.
This surface is picked up by wlc (as any other program's surface would) and is for the most parted treated as normal (i.e: managed by wlc). Of course, this is just a simple example. For more complex things we eventually want to implement (i.e redshift and potentially a graphical program similar to arandr) that story might change.
Pinging @SnirkImmington for his thoughts on this. I don't think it'll be a problem in general though, since we probably won't be messing with the internals of the wl_resources managed by wlc/wayland-server.

@vberger I'm not sure how much interaction we'll have between the two (aside from ipc) - wlc does management of wayland resources. I haven't read through the source but I think they manage lifetimes as well, as @Timidger said, with their wrappers wlc_resource and wlc_handle for example.
Our use cases mostly revolve around reading data off of a wl_resource. wlc provides a method to go from one of their handles to a wl_resource, (also as it happened the userdata field you mentioned, we have a wrapper for) and that's an opaque struct as far as rustwlc is concerned.
If we were to implement server-side borders, for example, we might want to get some information on a view that wlc doesn't provide, so we'll take some view handle and we'll get the underlying wl_resource - it would be nice to be able to use that without worrying about wayland-server's lifetime management - i.e. with the "unsafe/raw" methods @Timidger mentioned (especially because as far as wayland-server is concerned we'd be pulling them out of thin air).
We also wanted to have a crate feature in rustwlc for optional dependency on wayland-server, to allow things like that to work for end users.
We have our own considerations of "rewrite the whole thing to enforce Rust's memory model on it" - and we'd probably have different memory management concerns than wayland-server if we did. We put that rewrite on hold to get started with Way Cooler (so rustwlc has a more "unsafe" API right now) but we'd be willing to build up a "safety" layer that could integrate better with wayland-server). Perhaps if both libraries had an even divide between "raw bindings" and "Rust memory model" we could pass objects between the two more easily. I know that would end up being more work for you - let me know what you think/if what I'm saying makes sense.

Integrating a way to create wayland objects "out of thin air", in order to give them as argument to event/requests is completely possible, but such objects cannot be registered to wayland-server event-loops, nor can their methods be called, or it'll either segfault or mess with the internal state (due to user_data being inconsistent with what the lib expects).
My goal with wayland-client/server is indeed to create an API that would be safe from a rust point of view, while being as close as possible to the original C API, and this with an overhead as small as possible. So I'm expect and hope that more high-level APIs can be build around these libs, and that's mostly their reason for existing.

Perhaps we should clarify what we mean here by "out of thin air". For example, currently we construct our background image by writing to a buffer then attaching it to a surface (see here). Is our use of matching on the events triggered by this surface bad because we made this surface "out of thin air"? It's managed by wlc (because it's treated as a view, just like any other), but we are using wayland_sys's api here to display the correct pointer image.

Hmm, I'm not sure I get what you mean...
The main issue I see, is that, to safely do event dispatching & destructor handling, wayland-server (and similarly wayland-client) relies on data it stores via wl_resource_set_user_data() in the user_data pointer of the wl_resources. I don't know what wlc does with the resources, but it certainly does not do the same thing.
Now, imagine you've setup your compositor with wlc. You have clients connecting to it, and wlc creates wl_resource objects for you.
Now, you might want to have some of these object interact with code using wayland-server, and so create a wayland_server object, for example let's say a WlSurface.
You might want this WlSurface for different reasons:

To register it to the EventLoop in wayland_server. This is only possible if you are sure that wlc will never ever try to do anything with the wl_surface, and especially not read its user_data or destroy it, overwise memory will get corrupted.
To call one of its methods to send an event to the client. If wlc forfeits the object and wayland-server can overwrite its user_data, everything is fine. Otherwise, it can be safe-ish, as long as you don't call any destructor method, in which case wayland_server will try to clain the user_data to deallocate the memory associated.
To give it as argument to a method of an object belonging to wayland_server. This is safe.

Now, there is a last edge-case. Imagine you have your "background setting protocol" (I'm completely speculating here), with a global object "background_setter", that expects a wl_buffer from the client to get the contents of the background.
Server-side, the wl_compositor is handled by wlc, so it's wlc that will be notified of the creation of the wl_buffer. Now, you use ayland-server for you background-setting protocol, so the request for setting the background will be dispatched to wayland-server's EventLoop. Internally, the C library will provide wayland-server with a *mut wl_resource corresponding to the wl_buffer associated with the event.
wayland-server has no way to know this wl_buffer isn't actually managed by it, but rather by wlc. So it'll just assume it's its, ans notably that its user_data has previously been initialized, and use it as such to provide a &WlBuffer to the handler method for the event...
After a quick glance, I can see that wlc also heavily uses the user_data field for its internal machinery... (see for example https://github.com/Cloudef/wlc/blob/master/src/compositor/compositor.c#L138 ).
Basically, I think it is only possible to mix wayland-server and wlc if they operate over completely different and non-intersecting protocols. Meaning, as you use wlc to handle the core protocol, that wayland_server must only handle ressources of a protocol extension that uses none of the core interfaces in any of its events...
I know all this digs into the wayland machinery, but I hope I'm clear?

Thank you, you were very clear. I was not aware of how wlc managed its resource (for up until now we had not needed to know that), but it is clear now that Way Cooler will need to work out a different solution where we either ditch wlc (difficult) or work around this e.g with our own ipc system instead of wayland_sys.

Well, using wayland_sys is perfectly fine for you, at least exactly as much as using directly the C libraries, as it's just raw bindings.
It's using wayland_server which is problematic...

Yes sorry, I misspoke there, meant wayland_server.

Okay.
Sorry it cannot end as well as you'd hope. To be honest, I'm not very happy with the C API exposed by the C wayland libraries, it already caused me much of a headache, because it's not very rust-friendly... I started working on it more than a year ago, and only now do I reach an API design that I feel is rust-friendly and low-overhead for both client and server side...
For now, I'll focus on releasing the version 0.7, and updating wayland-kbd, wayland-window, and the glutin/winit backend to the new design.
However, if you feel motivated enough to create a wlc-like crate on to of wayland_server, you can definitely ping me! I'd love to participate in such a project. :wink:


Support for Python 3.5

Will django-cms get support for Python 3.5 anytime soon?
Right now trying to install throws an AttributeError: module 'html.parser' has no attribute 'HTMLParseError' exception, since that module has been deprecated since Python 3.3, but been dropped completely with Python 3.5 now.

Django 1.8 doesn't currently support Python 3.5. Django 1.9 will however.
https://docs.djangoproject.com/en/dev/releases/1.9/

@cimocimocimo Django 1.8 works on python 3.5 (albeit is not officially supported). any lower version doesn't.
django CMS itself is compatible with 3.5


Do you have some documents about Tatum？I have some trouble when reading code. Thanks~

Thanks for the report. At the moment there is no more documentation than what is available in the code. I hope to get better documentation up in the future, but don't have an ETA.


DX: PR Comment Story

PR Comment Stories

Content of Markdown report
Behaviour of comment in a PR
Multiple user-flow reports in one PR

Content of Markdown report
Questions

What is our target audience?
a. Developer, that a really cares about the performance of his app
b. Tech lead or person how approves pr and maintains code quality
What does this feature help?
a. He can see a quick summery of the results
b. Want to make sure the new code is of the appropriate quality
What should be included in the comment?

Results

Title
Time of run
Report Results
BaselineComparison
Budget assertion

Configs

Budget
View-port Dimensions
Network Throttling
CPU Throttling

Behaviour of comment in a PR

When opening a PR it generates the first comment
When running the next audit it hides the previous comment and adds a new one

Future option: add a flag to decided whether to chose how you want comments to behave

Multiple user-flow reports in one PR

TODO

Question: should we have a configuration in the initial pr description -> Audit: [basic-navigation, login, select-movie]

[UserFlowName] - Report Comparison Visualization
Date/Time:  2022-11-03 15:06

Comparison Summary

Step Name
Gather Mode
Performance
Accessibility
Best Practices
Seo
Pwa

Navigate to coffee cart
navigation
90 (10⏫)
97
100
83
30

Select coffee
timespan
10/11 (1⏬)
-
7/7
-
-

Coffee selected
snapshot
Ø 3/3
16/16 (1⏫)
5/5
7/9
-

Checkout order
timespan
13/13
-
5/7 (2⏬)
-
-

Order checked out
snapshot
Ø 3/3
17/18
5/5
7/9
-

Submit order
timespan
13/13
-
6/7 (1⏬)
-
-

Order submitted
snapshot
Ø 3/3
15/16
5/5
7/9
-

Settings
 table here


Fix custom widget tests

Description
Previous tests test_custom_widget and test_custom_widget2 failed to override the BLEACH_DEFAULT_WIDGET at the correct time to influence the form being used to test thus the tests were not actually testing with the intended widget class.
The reason the old tests were not correct is that testproject.forms.BleachForm is evaluated at compile time (with settings as per testproject.settings) while the mock only changes the settings when the individual test is run and it is too late.
This PR defines a class within the setUp method of the test class while override_settings is in effect.
Checklist

[X] I have ran tox to ensure tests pass
[X] Usage documentation added in case of new features
[X] Tests added / I have not lowered coverage from 100%

Great catch! Thanks @MrkGrgsn.


removed logging from ModifierValidation

Coverage remained the same at 46.943% when pulling 8fc49bb9391da1d1e7f14ce3e7bc0279368d30f0 on remove_validation_logging into 941a63a826fedb4397c1a3d3ea05fca410c2538c on master.


Safe-by-default: underscore-prefixed unused args

Currently if you create a new ember app, add ember-cli-typescript and ember-cli-tslint, followed by something like
ember g route home
and then define a route as shown below, you'll get two warnings from the TypeScript compiler due to ember-cli-typescript using the --noUnusedParameters flag
import Route from "@ember/routing/route";
import { Ember } from "ember";
import Model from "ember-data/model";

export default class Home extends Route.extend({
  // anything which *must* be merged to prototype here
}) {
  // normal class body definition here
  public async afterModel(
    resolvedModel: Model,            // WARNING: 'resolvedModel' is declared but its value is never read.
    transition: Ember.Transition     // WARNING: 'transition' is declared but its value is never read.
   ) {}
}

The TS team has adopted leading underscores as way of treating unused variables without losing developer intent (i.e., naming a parameter _ doesn't leave info for fellow developers who may want to use it in the future -- _model gives them a clue).
Unfortunately, in an ember app, this leads to a tslint error. Apparently Palantir feels that unused parameters of any kind should be treated as errors.
https://github.com/palantir/tslint/blob/9d7db479596c50bbf89fa87d498ab927763a6eec/src/configs/recommended.ts#L187-L192
import Route from "@ember/routing/route";
import { Ember } from "ember";
import Model from "ember-data/model";

export default class Home extends Route.extend({
  // anything which *must* be merged to prototype here
}) {
  // normal class body definition here
  public async afterModel(
    _resolvedModel: Model,            // ERROR: [tslint] variable name must be in lowerCamelCase, PascalCase or UPPER_CASE (variable-name)
    _transition: Ember.Transition     // ERROR: [tslint] variable name must be in lowerCamelCase, PascalCase or UPPER_CASE (variable-name)
   ) {}
}

This leaves developers with guaranteed errors or warnings by default, the first time they run into a situation where they must disregard a function parameter.
Let's adopt Microsoft's convention and allow these leading underscores by default across all ember apps. We'd need to allow this by default for JS and TS.
    "variable-name": {
      "options": ["allow-leading-underscore"]
    }

@t-sauer what are your thoughts on making this change now, and opening a new RFC-style issue for discussing an even better baseline?
In terms of a developer's hierarchy of needs, "It doesn't error under normal circumstances" outranks "this configuration is delightful".
Ideally, I'd love to leverage some of the work my LinkedIn colleagues and others have done with ember-specific TS rules.

I'd be happy to make this change, if you give me the 👍

Sure, I am happy for suggestions 🙂


fixed the typo

LGTM

let's think about this. this update could break a lot of projects.

https://wheelofnames.com/j7b-zjd

okay you win


Pp 1562/release as nodejs package

Make Pay product page a Node.js package
Locations of some resources changed to not conflict with those in projects like pay-frontend

Code review completed. Looks good.


Select2 with tagging support - horisontally resize

Hi! I would like to use tagging support, but I don't have enough space under the input. I would like then the basic input open up to the left, when I click it. Or when there is a lot of tags. Basically open (resize) it to down.
Same like this, just with tagging support: http://jsfiddle.net/acpFh/6/
How do I solve this?
Thanks a lot!

Closing this off because of the lack of activity. If this is not fixed in 4.0, and you are interested in seeing it fixed, add a :+1: to the ticket to bring it to our attention.
If you can add additional details, that would also be useful.


[BUG] spurious pixels and tiny meshes in rat atlas annotation/root mesh

Describe the bug
Rat atlas fails our initial validation script.
To Reproduce
Call validate_mesh_matches_image_extents() on whs_sd_rat_39um_v1.1 -> assertion fails
Expected behaviour
extents of mesh and annotation image (without background) should match and assertion passes.
Additional context
fix: purifying annotation.tiff in ImageJ (getting rid of small, disconnected pixels), regenerating mesh based on the new, purified annotation

e.g. see z-slice 478 at y==0

Purify step on L236 (after loading annotations stack) in whs_sd_rat.py would be cleanest solution.
Worth checking whether newer versions of WHS atlas have fixed this already, in which case we wouldn't need this and can directly fix #84


update istio/api

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5450759ce7632425d11484ced4b2a5e964bc35bf
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5450759ce7632425d11484ced4b2a5e964bc35bf
link
/test istio-presubmit

prow/istio-unit-tests.sh
5450759ce7632425d11484ced4b2a5e964bc35bf
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5450759ce7632425d11484ced4b2a5e964bc35bf
link
/test istio-unit-tests

prow/istio-presubmit.sh
5450759ce7632425d11484ced4b2a5e964bc35bf
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guptasu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
5450759ce7632425d11484ced4b2a5e964bc35bf
link
/test istio-presubmit

prow/istio-unit-tests.sh
5450759ce7632425d11484ced4b2a5e964bc35bf
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve
On Tue, Mar 20, 2018 at 3:46 PM Sunny Gupta<EMAIL_ADDRESS>wrote:

/test all
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/4409#issuecomment-374782935, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxiaAc9WkBd7B8mmcSmqp3p7rE61rks5tgYaxgaJpZM4SyxJR
.

replaced by #4410


Shell extension "Open Windows Terminal here" should start in current window

With #8898 landed wt.exe can now start a terminal tab in an existing window.
I would expect that the new default for the "Open Windows Terminal here" shell extension is starting in the current window, as this is the common default for other sort of applications. For example browsers open a new tab when clicking on a HTML file in the Explorer or VS Code opens a new tab when opening a registered file extension.
However, right now the shell extension doesn't pass a window argument (https://github.com/microsoft/terminal/blob/e207236/src/cascadia/ShellExtension/OpenTerminalHere.cpp#L151) so there will be a new window.
Maybe there should be an option to control this behavior, but new tab in current window should be default.

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to #7071 for more discussion.
/dup #7071


cambiar repo principal de master a main

ver https://www.theserverside.com/feature/Why-GitHub-renamed-its-master-branch-to-main

listo!


Question:  how do you import just what you need?

https://vue3openlayers.netlify.app/#installation

No ways. All of componets export "by design".
You can join to my PR and modificate it.
https://github.com/MelihAltintas/vue3-openlayers/pull/149

You can import like that:
import { Map, MapControls, Layers, Sources } from "vue3-openlayers";

import "vue3-openlayers/dist/vue3-openlayers.css";
const app = createApp(App);

app.component("ol-map", Map.Map);
app.component("ol-view", Map.View);

app.component("ol-tile-layer", Layers.TileLayer);

app.component("ol-source-osm", Sources.SourceOSM);
app.component("ol-fullscreen-control", MapControls.FullScreenControl);

https://codesandbox.io/s/nameless-haze-n9ozfm?file=/src/main.js:63-456


Fix 'info' icon not appearing under Activity of user page

Description
On the new user page, the 'info' icon was not appearing correctly and was appearing as text instead under the activity bar. This was fixed by manually adding material-icon and mat-icon classes to the mat-icon element that should appear for it automatically but does not in this case. Unsure as to why it does not work here and would love to hear ideas/alternative solutions from other devs.
Issue
GitHub issue: #4902
Jira: DOCK-2168
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain

Before:

After:

To clarify, you're saying this PR does not fix the problem, correct?
No this PR does fix the problem, it's just that the root of the problem of 'mat-icon' not working was very random and strange to me and this fix was kind of a 'hard-coded' fix. I do think your solution may solve it though and will give it a shot.


your cuda is 8.0, but my cuda is 9.0, could you tell me how to complie the abn and cc_attention,please?

Please refer to the readme.

thanks

but finally, a new problem exists, I think due to environments , your cuda  is 8, my gpu is 2080ti that requires cuda>=9, so could you give me some suggestions,please?

the problem occurs when training the network


images are not displayed when app is not installed in web root.

Steps to reproduce
step 1: modify   "next.config.js" as below to install app to a different path:
....
module.exports = {
basePath: "/apps/materio",
...
step 2: run "npm run build"
step 3: run "npm run export"
step 4: publish app to web server (mine is powered by "nginx") by copying "out" folder to directory that maps to url path of "/apps/materio"
What is expected?
access materio app with URL: "https://localhost/apps/materio/index.html",  it should work without problem.  Specifically all components with images should display properly.
What is actually happening?
images in components of Materio app do not show up.
Additional data

Hi @skang,
This might be solved by adding the basePath in your images before making a production build.
For example, if you have written /images/my-image.png as your image source, you must update this path as /apps/materio/images/my-image.png. Another method is to set an environment variable in your .env file like BASE_PATH=/apps/materio and update image paths as:
`${process.env.BASE_PATH}/images/my-image.png`

We have not used the second method, but it probably should work.
You may refer to the official Next.js docs on the basePath.
Please let me if you have any further queries.


fix: change bearer token for authentication that is less restrictive

Fix https://github.com/imperatrona/twitter-scraper/issues/27

Many thanks to @thewh1teagle. This patch worked for me and the original code was still failing as I switched between the two.
However with this bearer token there seems to be a lower-than-previously rate limit on the number of scraper.IsLoggedIn() calls in a 15-minute period (seems to be ~75 calls) that did not previously apply. My use case is a simple replacement for the cli twurl call I used to use to get a single tweet, so that now is rate limited by the limit on IsLoggedIn rather than the limit on GetTweet. However with multiple GetTweet calls after a single IsLoggedIn I can hit the 150/15 minutes on GetTweet before I hit the ~75/15 minutes on IsLoggedIn. Short-term fix is just to lower the rate of the cli calls, long term fix of batching the GetTweet calls means more upstream re-engineering (sigh). But credit to @thewh1teagle. @imperatrona, @n0madic, and others for being able to do this at all!

The other Bearer token that worked for me was:
"AAAAAAAAAAAAAAAAAAAAAFQODgEAAAAAVHTp76lzh3rFzcHbmHVvQxYYpTw%3DckAlMINMjmCwxUcaXbAN4XqJVdgMJaHqNOFgPMK0zN1qLqLQCF"
This seems to be more widely-used token so the limits might be higher? I'm unable to test myself.

@thewh1teagle thank you! this fix works for me


kserve-controller in error with hook failed: "ingress-gateway-relation-changed"

Bug Description
Fresh deployment:
kserve-controller                                   waiting      1  kserve-controller        0.11/stable      523  <IP_ADDRESS>   no       installing agent
...
kserve-controller/0*          error     idle   <IP_ADDRESS>                 hook failed: "ingress-gateway-relation-changed"

All the rest of the charms are active/idle:
Model     Controller  Cloud/Region      Version  SLA          Timestamp
kubeflow  manual      k8s-cloud/eastus  3.4.3    unsupported  10:23:04Z

SAAS        Status  Store  URL
grafana     active  local  admin/cos.grafana
prometheus  active  local  admin/cos.prometheus

App                        Version                  Status   Scale  Charm                    Channel          Rev  Address       Exposed  Message
admission-webhook                                   active       1  admission-webhook        1.8/stable       301  <IP_ADDRESS>  no
argo-controller                                     active       1  argo-controller          3.3.10/stable    424  <IP_ADDRESS>  no
dex-auth                                            active       1  dex-auth                 2.36/stable      422  <IP_ADDRESS>   no
envoy                      res:oci-image@cc06b3e    active       1  envoy                    2.0/stable       194  <IP_ADDRESS>   no
grafana-agent-k8s          0.40.4                   active       1  grafana-agent-k8s        latest/edge       80  <IP_ADDRESS>  no       logging-consumer: off
istio-ingressgateway                                active       1  istio-gateway            1.17/stable     1000  <IP_ADDRESS>  no
istio-pilot                                         active       1  istio-pilot              1.17/stable      965  <IP_ADDRESS>   no
jupyter-controller                                  active       1  jupyter-controller       1.8/stable       849  <IP_ADDRESS>  no
jupyter-ui                                          active       1  jupyter-ui               1.8/stable       858  <IP_ADDRESS>   no
katib-controller           res:oci-image@b6a6100    active       1  katib-controller         0.16/stable      446  <IP_ADDRESS>  no
katib-db                   8.0.35-0ubuntu<IP_ADDRESS>  active       1  mysql-k8s                8.0/stable       127  <IP_ADDRESS>  no
katib-db-manager                                    active       1  katib-db-manager         0.16/stable      411  <IP_ADDRESS>   no
katib-ui                                            active       1  katib-ui                 0.16/stable      422  <IP_ADDRESS>  no
kfp-api                                             active       1  kfp-api                  2.0/stable      1283  <IP_ADDRESS>  no
kfp-db                     8.0.35-0ubuntu<IP_ADDRESS>  active       1  mysql-k8s                8.0/stable       127  <IP_ADDRESS>   no
kfp-metadata-writer                                 active       1  kfp-metadata-writer      2.0/stable       334  <IP_ADDRESS>  no
kfp-persistence                                     active       1  kfp-persistence          2.0/stable      1291  <IP_ADDRESS>  no
kfp-profile-controller                              active       1  kfp-profile-controller   2.0/stable      1315  <IP_ADDRESS>    no
kfp-schedwf                                         active       1  kfp-schedwf              2.0/stable      1302  <IP_ADDRESS>   no
kfp-ui                                              active       1  kfp-ui                   2.0/stable      1285  <IP_ADDRESS>  no
kfp-viewer                                          active       1  kfp-viewer               2.0/stable      1317  <IP_ADDRESS>   no
kfp-viz                                             active       1  kfp-viz                  2.0/stable      1235  <IP_ADDRESS>   no
knative-eventing                                    active       1  knative-eventing         1.10/stable      353  <IP_ADDRESS>   no
knative-operator                                    active       1  knative-operator         1.10/stable      328  <IP_ADDRESS>  no
knative-serving                                     active       1  knative-serving          1.10/stable      409  <IP_ADDRESS>  no
kserve-controller                                   waiting      1  kserve-controller        0.11/stable      523  <IP_ADDRESS>   no       installing agent
kubeflow-dashboard                                  active       1  kubeflow-dashboard       1.8/stable       454  <IP_ADDRESS>    no
kubeflow-profiles                                   active       1  kubeflow-profiles        1.8/stable       355  <IP_ADDRESS>  no
kubeflow-roles                                      active       1  kubeflow-roles           1.8/stable       187  <IP_ADDRESS>  no
kubeflow-volumes           res:oci-image@2261827    active       1  kubeflow-volumes         1.8/stable       260  <IP_ADDRESS>   no
metacontroller-operator                             active       1  metacontroller-operator  3.0/stable       252  <IP_ADDRESS>  no
minio                      res:oci-image@1755999    active       1  minio                    ckf-1.8/stable   278  <IP_ADDRESS>  no
mlmd                       res:oci-image@44abc5d    active       1  mlmd                     1.14/stable      127  <IP_ADDRESS>  no
oidc-gatekeeper                                     active       1  oidc-gatekeeper          ckf-1.8/stable   350  <IP_ADDRESS>    no
pvcviewer-operator                                  active       1  pvcviewer-operator       1.8/stable        30  <IP_ADDRESS>  no
seldon-controller-manager                           active       1  seldon-core              1.17/stable      664  <IP_ADDRESS>  no
tensorboard-controller                              active       1  tensorboard-controller   1.8/stable       257  <IP_ADDRESS>   no
tensorboards-web-app                                active       1  tensorboards-web-app     1.8/stable       245  <IP_ADDRESS>   no
training-operator                                   active       1  training-operator        1.7/stable       347  <IP_ADDRESS>   no

Unit                          Workload  Agent  Address      Ports          Message
admission-webhook/0*          active    idle   <IP_ADDRESS>
argo-controller/0*            active    idle   <IP_ADDRESS>
dex-auth/0*                   active    idle   <IP_ADDRESS>
envoy/0*                      active    idle   <IP_ADDRESS>  9090,9901/TCP
grafana-agent-k8s/0*          active    idle   <IP_ADDRESS>                 logging-consumer: off
istio-ingressgateway/0*       active    idle   <IP_ADDRESS>
istio-pilot/0*                active    idle   <IP_ADDRESS>
jupyter-controller/0*         active    idle   <IP_ADDRESS>
jupyter-ui/0*                 active    idle   <IP_ADDRESS>
katib-controller/0*           active    idle   <IP_ADDRESS>  443,8080/TCP
katib-db-manager/0*           active    idle   <IP_ADDRESS>
katib-db/0*                   active    idle   <IP_ADDRESS>                 Primary
katib-ui/0*                   active    idle   <IP_ADDRESS>
kfp-api/0*                    active    idle   <IP_ADDRESS>
kfp-db/0*                     active    idle   <IP_ADDRESS>                 Primary
kfp-metadata-writer/0*        active    idle   <IP_ADDRESS>
kfp-persistence/0*            active    idle   <IP_ADDRESS>
kfp-profile-controller/0*     active    idle   <IP_ADDRESS>
kfp-schedwf/0*                active    idle   <IP_ADDRESS>
kfp-ui/0*                     active    idle   <IP_ADDRESS>
kfp-viewer/0*                 active    idle   <IP_ADDRESS>
kfp-viz/0*                    active    idle   <IP_ADDRESS>
knative-eventing/0*           active    idle   <IP_ADDRESS>
knative-operator/0*           active    idle   <IP_ADDRESS>
knative-serving/0*            active    idle   <IP_ADDRESS>
kserve-controller/0*          error     idle   <IP_ADDRESS>                 hook failed: "ingress-gateway-relation-changed"
kubeflow-dashboard/0*         active    idle   <IP_ADDRESS>
kubeflow-profiles/0*          active    idle   <IP_ADDRESS>
kubeflow-roles/0*             active    idle   <IP_ADDRESS>
kubeflow-volumes/0*           active    idle   <IP_ADDRESS>  5000/TCP
metacontroller-operator/0*    active    idle   <IP_ADDRESS>
minio/0*                      active    idle   <IP_ADDRESS>  9000-9001/TCP
mlmd/0*                       active    idle   <IP_ADDRESS>  8080/TCP
oidc-gatekeeper/0*            active    idle   <IP_ADDRESS>
pvcviewer-operator/0*         active    idle   <IP_ADDRESS>
seldon-controller-manager/0*  active    idle   <IP_ADDRESS>
tensorboard-controller/0*     active    idle   <IP_ADDRESS>
tensorboards-web-app/0*       active    idle   <IP_ADDRESS>
training-operator/0*          active    idle   <IP_ADDRESS>

To Reproduce
juju deploy kubeflow --channel 1.8/stable
Environment
juju 3.4.3
Azure AKS 1.28.9
Relevant Log Output
unit-kserve-controller-0: 10:15:51 ERROR unit.kserve-controller/0.juju-log ingress-gateway:45: Uncaught exception while in charm code:
Traceback (most recent call last):
  File "./src/charm.py", line 702, in <module>
    main(KServeControllerCharm)
  File "/var/lib/juju/agents/unit-kserve-controller-0/charm/venv/ops/main.py", line 441, in main
    _emit_charm_event(charm, dispatcher.event_name)
  File "/var/lib/juju/agents/unit-kserve-controller-0/charm/venv/ops/main.py", line 149, in _emit_charm_event
    event_to_emit.emit(*args, **kwargs)
  File "/var/lib/juju/agents/unit-kserve-controller-0/charm/venv/ops/framework.py", line 342, in emit
    framework._emit(event)
  File "/var/lib/juju/agents/unit-kserve-controller-0/charm/venv/ops/framework.py", line 839, in _emit
    self._reemit(event_path)
  File "/var/lib/juju/agents/unit-kserve-controller-0/charm/venv/ops/framework.py", line 928, in _reemit
    custom_handler(event)
  File "./src/charm.py", line 538, in _on_ingress_gateway_relation_changed
    self._on_install(event)
  File "./src/charm.py", line 495, in _on_install
    self._restart_controller_service()
  File "./src/charm.py", line 694, in _restart_controller_service
    self.controller_container.restart(self._controller_container_name)
  File "/var/lib/juju/agents/unit-kserve-controller-0/charm/venv/ops/model.py", line 2045, in restart
    self._pebble.restart_services(service_names)
  File "/var/lib/juju/agents/unit-kserve-controller-0/charm/venv/ops/pebble.py", line 1746, in restart_services
    return self._services_action('restart', services, timeout, delay)
  File "/var/lib/juju/agents/unit-kserve-controller-0/charm/venv/ops/pebble.py", line 1767, in _services_action
    raise ChangeError(change.err, change)
ops.pebble.ChangeError: cannot perform the following tasks:
- Start service "kserve-controller" (cannot start service: exited quickly with code 1)
----- Logs from task 0 -----
2024-06-13T10:15:51Z INFO Service "kserve-controller" has never been started.
----- Logs from task 1 -----
2024-06-13T10:15:51Z INFO Most recent service output:
    {"level":"info","ts":"2024-06-13T10:15:51Z","logger":"entrypoint","msg":"Setting up client for manager"}
    {"level":"info","ts":"2024-06-13T10:15:51Z","logger":"entrypoint","msg":"Setting up manager"}
    {"level":"info","ts":"2024-06-13T10:15:51Z","logger":"controller-runtime.metrics","msg":"Metrics server is starting to listen","addr":":8080"}
    {"level":"info","ts":"2024-06-13T10:15:51Z","logger":"entrypoint","msg":"Registering Components."}
    {"level":"info","ts":"2024-06-13T10:15:51Z","logger":"entrypoint","msg":"Setting up KServe v1alpha1 scheme"}
    {"level":"info","ts":"2024-06-13T10:15:51Z","logger":"entrypoint","msg":"Setting up KServe v1beta1 scheme"}
    {"level":"error","ts":"2024-06-13T10:15:51Z","logger":"entrypoint","msg":"unable to get deploy config.","error":"configmaps \"inferenceservice-config\" not found","stacktrace":"main.main\n\t/root/parts/controller/build/cmd/manager/main.go:141\nruntime.main\n\t/snap/go/current/src/runtime/proc.go:250"}
2024-06-13T10:15:51Z ERROR cannot start service: exited quickly with code 1

### Additional Context

_No response_

Wrong repo btw. should be in https://github.com/canonical/kserve-operators/


why is frame avged in gen_st_model.py?

the avged frame is the time of somebody in center point? but when the person go through one camera twice or more times, the avged frame will be wrong, i am confused. besides, my english is poor, excuse me.

We make a simple assumption that a person appears in a camera only once. But do not be confused by this point, you can use a clustering algorithm to judge how many times a person appears in a camera. I think it can further improve performance in complex scenarios.

got it, thank you :-)

besides, can we use PCB to initialize st_model? then we can use 'joint metric''result to refeed st_model to improve performance. thus, maybe there is no need to mark my data for st_model.

The proposed method includes two streams, you can replace these streams with your method, and use evaluate_st.py for the joint metric.


fix: Add missing fullnameOverride to helm chart

Signed-off-by: Nick Fisher<EMAIL_ADDRESS>
Reason for Change:

The fullnameOverride is documented in the README.md, but is not implemented as part of the helm chart helpers.

Requirements

[x] squashed commits
[x] included documentation
[ ] added unit tests and e2e tests (if applicable).

Issue Fixed:

Does this change contain code from or inspired by another project?

[ ] Yes
[x] No

If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers:

Codecov Report

Merging #760 (7abfe60) into master (f9f810f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   61.65%   61.65%
=======================================
  Files           7        7
  Lines         785      785
=======================================
  Hits          484      484
  Misses        267      267
  Partials       34       34

/azp run pr-e2e


Pairing Problem

Hello! First of all let me thank you for your repository! It's amazing.
I am trying your code and i have paired the two devices (mobile and wearable) via bluetooth but when the mobile search the wearable I get the message
A wearable device is paired but the wearable app on your watch isn't open. Launch the wearable app and try again.
I have tried to reopen the wearable application but nothing.
Any suggestions?

Hi,
Could you try pairing your Samsung Watch 4 using the "Galaxy Wearable (Samsung Gear)" app and then install this app on your wearable and your mobile device. Make sure bluetooth is switched on and keep the activity of this app open on both the devices. This should fix probably the connectivity issue and then you can transfer messages between the devices. Hope this helps.

It is actually paired with the Galaxy Wearable app

@BharathVishal Any other suggestions ?

Hi,
I couldn't think of any other suggestions for this issue at the moment. Based on the message flow it means that the wearable is actually returned by the wearable data layer but for some reason the message isn't receiving. Could you keep this app's activity open on your wearable device without any sleep enabled like shown in this screenshot.

Actually after a while the wearable part maybe is going to sleep..Am i doing something wrong?

Hi,
The issue seems to be due to the watch going into sleep mode which is trippegering the activity's onPause() method that removes the listener. Increase the screen timeout of your wearble device to fix this issue. Goto Settings -> Display -> Screen Timeout-> Set it to one minute.
Check if this fixes the issue. You need to make sure that the app on the wearable device doesn't goto foreground or ambient mode. This should possibly fix the issue.

Hi,
Could you check the suggestions in the previous message, so I can close this issue?

I did all the above but still the onMessageReceived is never called

All i want is to send from wearable to mobile. Is there any other way to do it?


[Event Request] codeunit 90 "Purch.-Post" - OnCheckAssociatedOrderLinesOnAfterCheckDimensions

New Event desired in function CheckAssociatedOrderLines:
if TempSalesHeader.FindSet() then
    repeat
        SalesHeader.Get(TempSalesHeader."Document Type"::Order, TempSalesHeader."No.");
        TempSalesLine.SetRange("Document No.", SalesHeader."No.");
        CheckDimensions.CheckSalesDim(SalesHeader, TempSalesLine);
        OnCheckAssociatedOrderLinesOnAfterCheckDimensions(PurchHeader, SalesHeader, PurchLine, TempSalesLine);
    until TempSalesHeader.Next() = 0;

[IntegrationEvent(false, false)]
local procedure OnCheckAssociatedOrderLinesOnAfterCheckDimensions(PurchHeader: Record "Purchase Header"; SalesHeader: Record "Sales Header"; var PurchLine: Record "Purchase Line"; TempSalesLine: Record "Sales Line" temporary)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41884.


fix(ObjectParslet): support trailing comma or semicolon

fix(ObjectParslet): support trailing comma or semicolon

Thanks... Due to my adding another commit, it requires another review approval from you.

:tada: This PR is included in version 2.2.5 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Fix remove unix socket listenAddr

Because the absence of the listenAddr is what is expected.
The error will only be then when we can't remove.

LGTM

let L-G-T-M work

LGTM


Switched to a pg-index-health v.0.6.2

Codecov Report
Base: 98.57% // Head: 98.57% // No change to project coverage :thumbsup:

Coverage data is based on head (7652606) compared to base (eb5ad41).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage     98.57%   98.57%
  Complexity       31       31
=========================================
  Files             9        9
  Lines            70       70
  Branches          1        1
=========================================
  Hits             69       69
  Misses            1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


uxn: update to latest commit

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

It's my first contribution to NixOs, please show some understanding :green_heart:

@AndersonTorres can you have a look?

darwin is broken
unpacking source archive /private/tmp/nix-build-source.drv-0/1b2049e238df96f32335edf1c6db35bd09f8b42d.tar.gz
building '/nix/store/sv60hk684hnl0nxsqarj6ssxvfymyhxh-uxn-unstable-2022-10-22.drv'...
unpacking sources
unpacking source archive /nix/store/lg0d6dmgkg0amzagxnj4wx20hpgnlbig-source
source root is source
patching sources
building
Cleaning..
./build.sh: line 84: brew: command not found
Building..
ld: warning: option -s is obsolete and being ignored
clang-11: error: no such file or directory: '/lib/libSDL2.a'
clang-11: error: no such file or directory: '/nix/store/znbmpsnibwsvi39i9mggjg1mrcmxjksr-SDL2-2.24.0/lib/libSDL2.a'
error: builder for '/nix/store/sv60hk684hnl0nxsqarj6ssxvfymyhxh-uxn-unstable-2022-10-22.drv' failed with exit code 1;

we must overwrite UXNEMU_LDFLAGS since we don't use brew.

we must overwrite UXNEMU_LDFLAGS since we don't use brew.

I don't experience with Mac, how should it look like?

darwin is broken

Ok I found a solution, let's see if it works with the CI...


Docs onboarding v2

This PR culminates several iterations of cleanup in the Java Docs repo and handles some strange behavior seen along the way.
Note: There's also a cleanup PR to cleanup older language specific items.
This does not directly support legacy onboarding yet as we'll need to migrate the legacy moniker to archive first and then onboard some deprecated packages into legacy.
Part of this cleanup includes setting skipPublishDocMs for packages that are already excluded from docs onboarding. https://github.com/Azure/azure-sdk-for-java/pull/36385

/check-enforcer override


Guard unavailable row entity IDs

Can you explain this more? We guard against unknown Entity Ids now and show a Yellow Box

Yes, so we can close this one 😄


chore: Upgrade Gradle Version

#60  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Nava2 and the rest of your teammates on  Graphite


useMediaQuery not matching any breakpoint

I'm using the example implementation of useWidth to get the breakpoint width of my page, and since @material-ui/core v4.2.3, the useMediaQuery hook doesn't match any theme breakpoint when navigating between pages: it returns the default value 'xs' on first render.
The example code is linked here: https://github.com/mui-org/material-ui/blob/c8e1e377384533fa6b0b9819e7f34f21bd7574ef/docs/src/pages/components/use-media-query/UseWidth.js#L10
Is this intended behavior? for the width to not match anything on first render?

The issue has been closed because it does not conform to our issue requirements.
Please provide a full reproduction test case. This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!


Naive forecaster pred intervals (Draft PR)

Reference Issues/PRs
Prediction intervals for NaiveForecaster #480

Implement for #480
What does this implement/fix? Explain your changes.

New function under naive.py NaiveForecaster
Edit for _predict under _BaseWindowForecaster in _sktime.py (To return the results)
New unit testing for Naive forecaster pred intervals (Currently failing need to add expected prediction intervals to fix)

Does your contribution introduce a new dependency? If yes, which one?
No

What should a reviewer concentrate their feedback on?

[ ] _predict_intervals in naive.py
[ ] _predict in _BaseWindowForecaster

Any other comments?

Please suggest a package to calculate multiplier(C) in _predict_intervals or in a commit I'll do it with the equation or with another package.
PR checklist

For all contributions

[ ] I've added myself to the list of contributors.
[ ] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.
[X] Added a unit test, currently failing, needs the expected predict intervals for the function.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

The unit test needs valid expected prediction intervals and there is a repetition it will be fixed in the final PR.

Sure I think there are couple of long lines I'll edit it according to the PEP 8

Hi @D3ViL-NK - any update on this PR, some tests still seem to be failing? Let me know if you need help.

Hi @D3ViL-NK - any update on this PR, some tests still seem to be failing? Let me know if you need help.

Hi @mloning,
I already made a comment in the code about any suggestions. And also I asked couple more questions as well in comments inside the code, You can find them in,

function: _predict_intervals, class: NaiveForecaster (naive.py)
function: _predict, class: _BaseWindowForecaste (_sktime.py)
fucnction: test_return_pred_int (test_naive.py)

I would like you to take a look at those comments.
And let me know what you think and your suggestions.

Hi @D3ViL-NK,
Are you still working on this? :) Since you opened this PR quite some changes have been made on forecasters, which are now introducing merge conflicts. The biggest change for you is that the functionality compute_pred_int() moved to the base class and I think (please @mloning confirm) you now need to implement _compute_pred_err(self, alphas) (further details in the comments).
As a disclaimer: I also just started looking into prediction intervals, so lets maybe also wait for @mloning's comments. If you still want to work on this it might also be easier to open a new PR instead of solving all the merge conflicts here (but feel free to do whatever you prefer).
I hope this helps. If you have any questions you're also welcome to join our colab session on Fridays!

Hi @SveaMeyer13,
Thanks for your review and comments I think opening a new PR is the best way to go forward from where I left.  I'll take a look what can I do and I'll make a new draft PR for this.

Closed due to inactivity.


The docker container has insufficient SSL certificates

As of 6.0.1, the SSL certificates available to thumbor inside the container are insufficient to fetch some of the ssl based images (urls below). Bashing into the container and curl complains about not found certificates.
Curl:
root@deb08d83e7dc:~# curl  https://static01.nyt.com/images/2016/05/24/world/24FINLAND-web1/24FINLAND0-web1-superJumbo.jpg > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.

Thumbor( http://<IP_ADDRESS>:8000/unsafe/300x200/smart/https%3A%2F%2Fstatic01.nyt.com%2Fimages%2F2016%2F05%2F24%2Fworld%2F24FINLAND-web1%2F24FINLAND0-web1-superJumbo.jpg):
2016-05-31 12:07:14 tornado.general:WARNING SSL Error on 8 ('<IP_ADDRESS>', 443): [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)
2016-05-31 12:07:14 thumbor:WARNING ERROR retrieving image https://static01.nyt.com/images/2016/05/24/world/24FINLAND-web1/24FINLAND0-web1-superJumbo.jpg : [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)
2016-05-31 12:07:14 tornado.access:ERROR 504 GET /unsafe/300x200/smart/https%3A%2F%2Fstatic01.nyt.com%2Fimages%2F2016%2F05%2F24%2Fworld%2F24FINLAND-web1%2F24FINLAND0-web1-superJumbo.jpg%20 (<IP_ADDRESS>) 58.22ms

If this cert bundle from here is used with --cacert it is able to fetch. (Not sure if adding that explicitly to the docker build file would be good idea.)
Image urls:

https://static01.nyt.com/images/2016/05/24/world/24FINLAND-web1/24FINLAND0-web1-superJumbo.jpg
https://assets.kpmg.com/content/dam/kpmg/images/2016/03/gr-compben-retail-121875.jpg/jcr:content/renditions/cq5dam.web.512.341.jpg

I think is a problem with the remote server that no have the certificate correctly installed.
Maybe is not a good idea include this certificates in the build but I will reconsider it if someone prepare a Pull Request.

I think it's the other way round. The client has an incomplete set of certificates. E.g. the images can be fetched with a mint Ubuntu.

It was the Python image that was outdated. Rebuilding the docker fixed the problem.


How can we flip the mobile camera (front/rear) through chime sdk?

I can't see any api on react native chime demo for flipping device camera to rear or front. Is there any way to do this?

As mentioned by @Beos24vi react native does not expose all the method native sdk supports, so you would have to expose it. Feel free to open any PR to add support. Thanks!