deps:  gogo/protobuf: use v0.2

Motivation is to vendor only tagged dependencies.

@lucab @onlyjob: rkt already depends on an unspecified version of protobuf:
https://anonscm.debian.org/cgit/pkg-go/packages/rkt.git/tree/debian/control#n50
Does it mean it is unnecessary to switch to a tagged version for this specific package?

For the context: this is downgrading the dependency on gogo/protobuf to avoid a dependency on an untagged version. But v0.2 is quite old. A new tag has been requested on https://github.com/gogo/protobuf/issues/182

rkt (package) already depends on an unspecified version of protobuf:

golang-goprotobuf-dev provides github.com/golang/protobuf.
If rkt gained direct dependency on github.com/gogo/protobuf then golang-github-gogo-protobuf-dev package (currently v0.2) should be added to rkt's Build-Depends.
Properly versioning dependencies is very helpful.
If only some of rkt dependency packages use github.com/gogo/protobuf then corresponding packages should be updated with versioned dependency on golang-github-gogo-protobuf-dev (>= 0.2) (or higher, as required).

But v0.2 is quite old.

That's rapid development, isn't it?  ;)
gogo-protobuf 0.2 is just about 2 months (and 17 commits) "old"!  :)

For the context: this is downgrading the dependency on gogo/protobuf to avoid a dependency on an untagged version.

This doesn't look like a downgrade to me. Current revision falls between 0.1 and 0.2. If it is not causing any new regressions, I think this should be ok to be merged. Debian already has golang-github-gogo-protobuf-dev 0.2 anyway.

lgtm


brower resolve

Pass option to rollup-plugin-node-resolve to use browser version when specified. Would be great to support rollup & plugin options customization from pika web config
// some package.json files have a "browser" field which specifies
// alternative files to load for people bundling for the browser. If
// that's you, either use this option or add "browser" to the
// "mainfields" option, otherwise pkg.browser will be ignored
browser: true,  // Default: false

Thanks for the PR! Sorry for the delayed response, we actually merged this is a separate PR when we added support for the new "mainFields". 🎉
Still not sure if we want to shim/polyfill Node-isms, but lets follow up that discussion here: https://github.com/pikapkg/web/pull/6
Thanks again


updating examples that use grid

Note this requires ploomber 0.19.8 to be released
In Ploomber 0.19.8, we introduced placeholders so the grid products and task names can reference the task parameters (via [[placeholders]] in the name and product fields. However, the examples here don't use them. We must update every example that uses grid so it uses placeholders. see the docs to learn more
Here's one. But there are others.

For both task name and products, I was thinking of appending all the placeholder parameters? In the example you linked above, I was thinking something like this:
    name: fit-[[model-type]]-[[n_estimators]]-[[criterion]]     # disabling static_analysis because the notebook does not have     # a fixed set of parameters (depends on random-forest vs ada-boost)     static_analysis: disable     product:       nb: products/report-[[model-type]]-[[n_estimators]]-[[criterion]].html       model: products/model-[[model-type]]-[[n_estimators]]-[[criterion]].pickle
Opinions or does that look alright?

@e1ha here's the order I'd do it:

First I'd map all of the examples that has grid usage.
Then I'd try one sample and test it locally, see it's working fine with the placeholders.
The example you wrote above should do, if it doesn't have an env.yaml we can use curly brackets {{SOME_VAL}}

I think I have an idea of how to do it for now but I was wondering if those names would be descriptive enough. Like is just including parameters enough (block1) or would it be better to include both parameters and their parameter names (block 2):
block1:
name: fit-[[model-type]]-[[n_estimators]]-[[criterion]]

vs.
block2:
name: fit-model-type=[[model-type]]-n_estimators=[[n_estimators]]-criterion=[[criterion]]

Got it! I think in that case, block 1 is clearer.
On Wed, Aug 10, 2022, 17:50 e1ha @.***> wrote:

I think I have an idea of how to do it for now but I was wondering if
those names would be descriptive enough. Like is just including parameters
enough (block1) or would it be better to include both parameters and their
parameter names (block 2):
block1:
name: fit-[[model-type]]-[[n_estimators]]-[[criterion]]
vs.
block2:
name: fit-model-type=[[model-type]]-n_estimators=[[n_estimators]]-criterion=[[criterion]]
—
Reply to this email directly, view it on GitHub
https://github.com/ploomber/projects/issues/49#issuecomment-1211317437,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYPJOJ3ODD3MZMHHLMWZWDVYQP2ZANCNFSM53XOTUPA
.
You are receiving this because you commented.Message ID:
@.***>


Bad idea to hide support inside something that could be the problem.

[Enter feedback here]
If you are having technical issues with Microsoft 365, logging in to the admin console may be part of the problem so putting the support options there is a terrible idea.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1ed50e50-a3c1-1f3b-1ea5-40beec8ab6cd
Version Independent ID: 1ed50e50-a3c1-1f3b-1ea5-40beec8ab6cd
Content: Get support - Microsoft 365 admin
Content Source: microsoft-365/admin/get-help-support.md
Service: microsoft-365-business
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@jsclary Thank you for your feedback. The option to create a support ticket via the need help section is one of the ways to contact  Microsoft support and users can always use the other support option if they have trouble getting into the admin center.
It is not always that a technical issue stops admins from accessing the admin center.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @jsclary Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Native review for simonh1000/file-reader

The package provides minimal-sufficient bindings for the FileReader javascript API to enable reading of local files from an Input element or from a drop action. It uses far less native code than previous attempts at the same functionality - indeed the entire native code is simply:
    function useReader(method, fileObjectToRead) {
        return Task.asyncFunction(function(callback){

            /*
             * http://caniuse.com/#search=filereader
             * main gap is IE10 and 11 which do not support readAsBinaryFile
             * but we do not use this API either as it is deprecated
             */
            var reader = new FileReader();

            reader.onload = function(evt) {
                return callback(Task.succeed(evt.target.result))
            };

            reader.onerror = function() {
                return callback(Task.fail({ctor : 'ReadFail'}));
            };

            // Error if not passed an objectToRead or if it is not a Blob
            if (!fileObjectToRead || !(fileObjectToRead instanceof Blob)) {
                return callback(Task.fail({ctor : 'NoValidBlob'}));
            }

            return reader[method](fileObjectToRead);
        });
    }

    // readAsTextFile : Value -> Task error String
    var readAsTextFile = function(fileObjectToRead){
        return useReader("readAsText", fileObjectToRead);
    };

    // readAsArrayBuffer : Value -> Task error String
    var readAsArrayBuffer = function(fileObjectToRead){
        return useReader("readAsArrayBuffer", fileObjectToRead);
    };

    // readAsDataUrl : Value -> Task error String
    var readAsDataUrl = function(fileObjectToRead){
        return useReader("readAsDataURL", fileObjectToRead);
    };

Everything else, including 3 examples is in Elm. I'm happy to patch the shiney new documentation viewer once native review is complete
cc: @danyx23

The native review pipeline is stalled. That's probably not news to you, but I wanted to leave a note on all the open reviews. I cannot speak for everyone, but as one of the reviewers I just want to speak up and say that I will not be doing more reviews. The warning about publishing native packages has changed, and Evan has mentioned multiple times in different places that one of his priorities for 0.17 is improving this process. So I'm going to wait for that. I'm sorry we cannot move forward with publishing your library, but my experience is that even if we review and approve it, it will become stuck waiting for Evan to whitelist it.

Sorry to keep this in limbo for so long. I am moving towards the plan outlined here and discussed a bit further in the 0.17 announcement. The right thing to for now is use ports or get advice on the mailing list or on slack.


Update main.tf

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

⚠check_generate_modules
The modules need to be regenerated. Please run make_build.

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/main.tf /tmp/tmp.zNJt2d8oAv/workspace/main.tf
113,125d112
<
<
< resource "google_compute_ssl_certificate" "default" {
<   project     = var.project
<   count       = var.ssl && length(var.managed_ssl_certificate_domains) == 0 && !var.use_ssl_certificates ? 1 : 0
<   name_prefix = "${var.name}-certificate-"
<   private_key = var.private_key
<   certificate = var.certificate
<
<   lifecycle {
<     create_before_destroy = true
<   }
< }
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes

⚠check_whitespace
Failed whitespace check. More details below.

Checking for trailing whitespace
./main.tf:113:
Error: Trailing whitespace found in the lines above.
Checking for missing newline at end of file

⚠check_terraform
Failed Terraform check. More details below.

Running terraform fmt
main.tf
--- old/main.tf
+++ new/main.tf
@@ -110,7 +110,7 @@
    create_before_destroy = true
  }
}
-
+

resource "google_compute_ssl_certificate" "default" {
  project     = var.project
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>


Type/method name comparison should support comparing fully qualified names

When the fully qualified name is available, we should compare the fully qualified names in case there are multiple types with the same name in different namespaces.
https://github.com/microsoft/typespec/blob/main/packages/http-client-csharp/generator/Microsoft.Generator.CSharp/src/Providers/TypeProvider.cs#L446

This will become more important as the multi-namespace support is added.

FYI @ArcturusZhang as this impacts the namespace support.


Update Guide with new version of our Chocolatey Install script

Checklist

[X] I have verified this is the correct repository for opening this issue.
[X] I have verified no other issues exist related to my problem.
[X] I have verified this is not an issue for a specific package.
[X] I have verified this issue is not security related.
[X] I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?
We are using a now out of date version of the Chocolatey installation script available on https://chocolatey.org/install
What is Expected?
We should be using the latest version available
How Did You Get This To Happen?
N/A
System Details
N/A
Installed Packages
N/A

Output Log
N/A

Additional Context
N/A

Though we've done this, I gather we should do it again! This time, perhaps we should attempt the full removal.


[Question][Protocol Handler] Does single broker node support multi msg protocols in config?

Is your enhancement request related to a problem? Please describe.
When setting the KoP, MoP, AMQP and RoP, we should use the config of messagingProtocols in broker and it seems that one single broker node only supports one message protocol at same time.
I wanna check that whether the config messagingProtocols could set multi protocol at same time like messagingProtocols=[amqp,kafka,mqtt].
Describe the solution you'd like
If single broker node only supports to set one message protocol, under the scenario that users have multiple message protocols in usage they have to put much more broker nodes.

@ericsyh You can enable multiple protocol handlers for one broker. Can you share your configurations?

@ericsyh You can enable multiple protocol handlers for one broker. Can you share your configurations?

@codelipenghui I didn't make this test so could you share a sample config that how to enable multiple protocol handlers in one broker? I checked on Pulsar docs and KoP/MoP/AMQP/RoP repos and didn't find related sample.

You can just set the messagingProtocols=kafka,mqtt and copy the kop and mop Nar package to the protocolHandlerDirectory

@codelipenghui got it, many thanks. Maybe we can add this sample to broker.conf and standalone.conf so that others can also know the way to enable multiple protocol handlers.


Feature/hee 278 mapping component

Description
Adding mapping component as per https://manifesto.atlassian.net/browse/HEE-278
Checklist

[x ] Tested against our testing policy (Resolution, Browser & Accessibility)

Hi @goodvibes - Thanks for the PR. The AC described in https://manifesto.atlassian.net/browse/HEE-278?focusedCommentId=94382 indicates that the map element of the component should be invisible in mobile view:

Given a user was using a mobile, when the user views the component, then only the headline, then the map element of the component will not be visible.

But, the prototype currently seems to render the map in mobile view as well. Could you fix this ? Thanks!

Hi @goodvibes - Thanks for the latest commit e066169a62789864130b1f9f7fbb07f62b928e99. I could see that the map is now being hidden in mobile view.
I could see lot of top and left padding on the component (in mobile view). Could you check if this can be reduced ? Thanks!

@smanivasag I have gone over the last few details with Will and I think this is ready for deploy if you would like to review

@smanivasag I have gone over the last few details with Will and I think this is ready for deploy if you would like to review

Have you got a chance to look into the top and left padding concern I have raised in https://github.com/Manifesto-Digital/hee-prototypes/pull/20#issuecomment-891042059 ? thanks!

Hi @goodvibes - As discussed during our call, it would good to reduce left padding for the links in mobile view. Thanks!


Configurable secure flag and port

Codecov Report

Merging #140 into master will decrease coverage by 0.46%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   87.84%   87.37%   -0.47%
==========================================
  Files          39       39
  Lines        3522     3534      +12
  Branches      277      278       +1
==========================================
- Hits         3094     3088       -6
- Misses        167      185      +18
  Partials      261      261

Impacted Files
Coverage Δ

src/config.c
63.59% <25%> (-2.39%)
:arrow_down:

src/connection.c
83.54% <33.33%> (-0.64%)
:arrow_down:

tests/test_client_list.c
85.71% <0%> (-5.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99393a2...f214d11. Read the comment docs.


Custom field separator

This allows to specify a custom field separator between sources defined in model's sluggable() method.
The main use case is to generate slugs for nested models, such as folders or categories, but can be used for anything having more than one source field.
Nothing changes compared to before, except when you define multiple sources:
public function sluggable()
{
    return [
        'slug' => [
            'source' => ['parent_slug', 'name'],
            'field_separator' => '/'
        ],
    ];
}

Now, parent_slug and name will be separated by a customisable character (by default, "/"). Generated slug could look like that:
/blog/development/web/php/my_cool_post

The field_separator can be customised in the config/sluggable.php file, or directly in the model as shown above.

I'm not sure what happened here, but it looks like there are some major conflicts.  The ServiceProvider class got all messed up?
Can you rebase from master and submit again, please?

Actually ... the more I look at how you are approaching it, I'm not sure.
Basically, instead of concatenating all the source fields with a space, and then slugging the whole string, you are slugging each field separately, then concatenating them with the new field_separator character, right?
How do you handle uniqueness?  It looks like only on the last source field, correct?  I suppose that's fine, but I can see someone at some point asking for it to be on one of the other fields.
I'm not sure how the maxLength and maxLengthKeepWords configs should work in this scenario.  Ideally, it would apply to the entire slugged string, correct?
I think your use-case, while not unique, can probably be solved in an easier way.  Set your source to a single field: slugSource.  Then add a getSlugSourceAttribute method to your model that does all the concatenation with the separator:
public function getSlugSourceAttribute(): string
{
    return implode('/', [
        $this->someField,
        $this->someOtherField,
        $this->whatever
    ]);

Then, the last thing to do would be make sure the slugging engine doesn't convert that / separator to something else when slugging the string:
    public function customizeSlugEngine(\Cocur\Slugify\Slugify $engine, $attribute): \Cocur\Slugify\Slugify
    {
        return new Slugify(['regexp'=>'|[^A-Za-z0-9/]+|']);
    }

(I agree that the above isn't ideal, but Slugify currently doesn't let you set options except in the constructor.)
The final issue I have is that, unless the default value for field_separator is a space, this will break backwards compatibility for anyone currently using multiple source fields.

Well, about the conflict, Nitpick is... Nitpicking 😄 The first two are on me, but the others are on you 😄
But I have no idea why Travis fails. To be honest, it's the first time I try to contribute on something via GitHub so I'm anything but familiar with all of this. I surely broke something more than compatibility 😄
The solution you propose is far better than the ugly thing I've proposed. I temporarily used the regex option for some time, but I would have preferred a more "robust" solution so I gave it a try.

Basically, instead of concatenating all the source fields with a space, and then slugging the whole string, you are slugging each field separately, then concatenating them with the new field_separator character, right?

Right.

How do you handle uniqueness? It looks like only on the last source field, correct? I suppose that's fine, but I can see someone at some point asking for it to be on one of the other fields.

That would be a strange request. Assuming the nested folders use case, only the last part really needs uniqueness, because logically, each ascendant would already have been slugged and uniqueness checked.
As for other use case, I honestly don't see why one would ask for uniqueness for each part: it just doesn't makes sense, does it ?

I'm not sure how the maxLength and maxLengthKeepWords configs should work in this scenario. Ideally, it would apply to the entire slugged string, correct?

Good point, I didn't check that.

Set your source to a single field: slugSource.

As I said, it's probably the best solution. Although, it's not universal, and requires using Slugify, whereas my "implementation", while poorly proposed, is agnostic.

The final issue I have is that, unless the default value for field_separator is a space, this will break backwards compatibility for anyone currently using multiple source fields.

Correct, space, or hyphen. It doesn't need to be a slash by default.

As this pull request has been refused, is there other recommended way to add a field separator between source items?, one difererent than the 'separator', may be using the general 'method' option?
Thanks!

@Jacq At the moment, the only option is the one I propose above.  If you've got any other suggestions or a PR, I'd be happy to consider them!


Added usage documentation

Hello I added some documentation although I wasn't able to add any for the historical data section. Wasn't sure about the date range format.

Coverage remained the same at 91.429% when pulling 2722175a89a5328a5fdb4b6cc49598e5ac6f4ef4 on lrosskamp:add-documentation into 5f29fbd4d3288b7e470a705774adfa23706e9a06 on ankitsamarthya:master.


SLF4J: Class path contains multiple SLF4J bindings during WSO2 IS 5.6.0 startup

One of my WSO2 IS (Identity Server) went poof due to physical host error, and when I want to bring back up the IS service, it just hangs and won't start up right after these warning message:

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [bundleresource://539.fwk120694604:1/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/usr/lib64/wso2/wso2is/5.6.0/repository/deployment/server/webapps/api%23identity%23entitlement/WEB-INF/lib/slf4j-simple-1.6.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]

Aside of IS process hanging, there is no logs generated as well, so as per the warning messages said, there are conflicting logging classes for WSO2 IS, but I can't find this class whereabout:

bundleresource://539.fwk120694604:1/org/slf4j/impl/StaticLoggerBinder.class

My current WSO2 IS version is 5.6.0 and due to some restriction I can't upgrade the version and I don't think versioning is the issue here.
I had search all over the internet but mostly involve edit pom / maven kinda stuffs but WSO2 IS is supposed to be ready product right? Well, thus until now I still can't find any solution.
Can any kind soul help me with this issue?
Thank you.

Product Version: 5.6.0
OS: CentOS 7
Database: MySQL
Userstore: LDAP

Did it[1] solve the issue?
[1] https://stackoverflow.com/a/71016245/6671627

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


TV status updates are not updated reliably when TV has been off for more than a few minutes

I want to achieve something quite simple: when the TV is turned on, my hue lamps should also be turned on. In general this setup was quite easy to achieve and when I turn off the TV and turn it on a few seconds later, the hue lamps are being turned accordingly.
But when the TV has been off for more than a few minutes and then turned back on, for some reason I don't receive an update in ioBroker about this event. I don't get any connection, lgtv.0.info.connection stays false. When I restart the lgtv.0 instance it works immediately.
I'm running the latest ioBroker version (with node 12 LTS) on a Raspberry Pi 4 Mod. B.

Have you tried states.on or states.power for indicating that the TV is turned on or off?

After I reinstalled the Adapter through github and then added 5000ms polling to the config, it works reliably, I just have to be patient. Sometimes after turning on the TV via the normal TV remote it takes up to 120s for ioBroker to realize it, but it works 100% reliably now.
Thanks for the very quick response, Sebastian. This can be closed.


Add stubs to FASTP process

Description of the bug
Looks like the FASTP process (in the dev branch) does not have a stub. This means that the regular process will be executed when running in the -stub-run mode.
Command used and terminal output
No response
Relevant files
No response
System information
No response

Good catch! This has been bugging me as well

Solved in the module update #488


Release/0.42.0

Codecov Report

Merging #977 (0bfd142) into develop (a0db0df) will increase coverage by 2.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #977      +/-   ##
===========================================
+ Coverage    57.56%   59.68%   +2.12%
===========================================
  Files          346      382      +36
  Lines        12828    14590    +1762
  Branches      2405     2733     +328
===========================================
+ Hits          7384     8708    +1324
- Misses        5200     5618     +418
- Partials       244      264      +20

Impacted Files
Coverage Δ

src/affix/affix.tsx
28.57% <0.00%> (-37.51%)
:arrow_down:

src/swiper/props.ts
68.75% <0.00%> (-31.25%)
:arrow_down:

src/dialog/props.ts
70.00% <0.00%> (-30.00%)
:arrow_down:

src/calendar/props.ts
70.00% <0.00%> (-30.00%)
:arrow_down:

src/popup/props.ts
75.00% <0.00%> (-25.00%)
:arrow_down:

src/select/props.ts
75.00% <0.00%> (-25.00%)
:arrow_down:

src/slider/props.ts
75.00% <0.00%> (-25.00%)
:arrow_down:

src/message/props.ts
75.00% <0.00%> (-25.00%)
:arrow_down:

src/tooltip/props.ts
75.00% <0.00%> (-25.00%)
:arrow_down:

src/pagination/props.ts
75.00% <0.00%> (-25.00%)
:arrow_down:

... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4ed36...0bfd142. Read the comment docs.


bug: Download as PDF feature - non latin characters are not displayed properly in the PDF

Bug Report
Description
Bug Summary:
Download as PDF feature- non latin characters are not displayed properly in the PDF
Steps to Reproduce:
Save a pdf from conversation containing non latin characters i.e cyrilic, japan etc.
Expected Behavior:
pdf containing the conversation in non latin language
Actual Behavior:
pdf containing gibberish
Environment

Operating System: Windows 11
Browser (if applicable): Chrome

Reproduction Details
Confirmation:

[*] I have read and followed all the instructions provided in the README.md.
[*] I am on the latest version of both Open WebUI and Ollama.

Logs and Screenshots
Sample PDF from conversation in Japan:
chat-ヤギの飼育方法.pdf

Should be fixed in dev branch, let me know if the issue persists!


Yurtctl: more comfortable command line

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/assign @zyjhtangtang

/approve


Bubbling should be allowed when target cospan is not self-similar

The following expansion move should be allowed:

Bubbling should be allowed when the forward and backward rewrites of the target cospan are homotopies (not necessarily equal).

Fixed ebb904b9348f9d39dba457b65066e64e1ac5008f


Remove snakeyaml and deployment yaml

Resolves: #wso2/carbon-config/34
Merge this after merging #wso2/carbon-config/37

@daneshk : We would need a git issue in this repo (carbon-kernel) since the PR is here.
Also I am not sure if Resolves is used for an issue in another repo will close it when this PR is merged. If there is a dependency to another issue in another repo, then we can put it as a note so that the reviewer (and others) will know.

Closing this PR. Since These changes are already contains in #1401


correction in the display of images on mobile

removed the media queries unnecessary

Hi! Thank you for your PR.
Is this improving display of images on mobile? I like the transition better currently than the transition in the proposed changes. Also, the pointer-events: none; is already merged in from a previous PR. If the only significant difference is adding flexbox, I think it is okay how it is currently functioning.


unexpected EOF

Debian amd64 10.3.0
Docker version 19.03.8, build afacb8b7f0
我用了命令 "curl -sL https://raw.githubusercontent.com/huan/docker-wechat/master/dochat.sh | sudo bash".如果没sudo的话,报错显示权限不够.

Maybe you need a good VPN to pull the docker image before you can use it.


Running as a service: doesn't seem to evoke my script.

Hey there, nice little tool you got here, I'm hoping to get it working for my use case as I have been looking for something to accomplish this for a while.
I'm running it as a service in the way you describe. I am pointing to a simple bash script to be run on a system theme change. I am piping the output of my script to the same log files I use for the service. When  I change the system appearance, it doesn't seem to run my script.
Any help would be much appreciated.

Ah I had simply failed to compile the swift script to an executable, it now evokes my bash script as expected. I now have the following question, not being very familiar with swift; The bash script I execute on a system theme change contains a conditional that checks the environment variable. It is obviously not globally and so by script is unable to do anything with it. What, in your opinion, is the best way to approach conditional execution of some script based on the current theme, on a system theme change?


Use only southermost ghost wave for cerb plugin

Closes #2252
Signed-off-by: Tomas Slusny<EMAIL_ADDRESS>

I was not able to test this, but here is the output from
		final List<LocalPoint> points = new ArrayList<>();

		points.add(new LocalPoint(0, 1));
		points.add(new LocalPoint(0, 2));
		points.add(new LocalPoint(1, 2));
		points.add(new LocalPoint(0, 3));
		points.add(new LocalPoint(1, 1));
		points.add(new LocalPoint(1, 3));

		points.sort((a, b) -> ComparisonChain.start()
			.compare(a.getX(), b.getX())
			.compare(b.getY(), a.getY())
			.result());

		points.forEach(point ->
		{
			log.info("Point is {}", point);
		});

2018-05-03 00:42:15 [AWT-EventQueue-0] INFO  n.r.c.p.cerberus.CerberusPlugin - Point is LocalPoint(x=0, y=3)
2018-05-03 00:42:15 [AWT-EventQueue-0] INFO  n.r.c.p.cerberus.CerberusPlugin - Point is LocalPoint(x=0, y=2)
2018-05-03 00:42:15 [AWT-EventQueue-0] INFO  n.r.c.p.cerberus.CerberusPlugin - Point is LocalPoint(x=0, y=1)
2018-05-03 00:42:15 [AWT-EventQueue-0] INFO  n.r.c.p.cerberus.CerberusPlugin - Point is LocalPoint(x=1, y=3)
2018-05-03 00:42:15 [AWT-EventQueue-0] INFO  n.r.c.p.cerberus.CerberusPlugin - Point is LocalPoint(x=1, y=2)
2018-05-03 00:42:15 [AWT-EventQueue-0] INFO  n.r.c.p.cerberus.CerberusPlugin - Point is LocalPoint(x=1, y=1)

Thinking about this again, I could've just also made that to unit test hmm


Tests for TracepointInfoManager

Tests for TracepointInfoManager
Removed unused functions in TracepointEventBuffer

Please fix trivial comments - lgtm otherwise!

Done. Thank you a lot for taking the time!


Bug: -p medium/large/xlarge doesn't work

Hello,
I have a server with port 8080 open and the option -p doesn't detect it.
$ echo localhost| fprobe -p http:8080
http://localhost:8080
https://localhost
http://localhost

and
$ echo localhost| fprobe -p xlarge
https://localhost
http://localhost

my go version is :
go version go1.14.4 linux/amd64

and I'm on Ubuntu 18.04.4 LTS
Can you do anything to fix this bug ?
Thank you

Hi, try to install the latest version using this command:
GO111MODULE=on go get -u github.com/theblackturtle/fprobe

Hello,
it still does the same error :
$echo localhost | fprobe -p http:8000
https://localhost
http://localhost
http://localhost:8000

$ echo localhost | fprobe -p xlarge                                                                                https://localhost
http://localhost

Hi @Neolex-Security, you can use the -d flag to check the details. By default, fprobe just print the success results.


Secure GITHUB_TOKEN

Type of change
Note: Fill x in []

[ ] bug
[x] enhancement
[ ] documentation
[ ] dependencies

Description

Secure GITHUB_TOKEN
For security reasons, all pull requests need to be approved first before running any automated CI

closing this already merged a patch.


Condense Read and Validation modules in cardano-cli

Two things occur before constructing a tx. You must first read the parts you need and then validate that they can indeed be used in a particular era. We condense these into two module in the cli, with the eventual aim of moving them to cardano-api.

bors r+

bors r+


Cannot load the checkpoints except the "fast_monusac" one

Dear @simongraham ,
When I tried to load the checkpoints, I can only succssfully loadthe checkpoint "hovernet_fast_monusac_type_tf2pytorch.tar". When I ran the checkpoint "hovernet_original_consep_notype_tf2pytorch.tar" using the following command
python run_infer.py \ --gpu='0,1' \ --nr_types=6 \ --type_info_path=type_info.json \ --batch_size=64 \ --model_mode=orignal \ --model_path=weights/hovernet_original_consep_notype_tf2pytorch.tar \ --nr_inference_workers=8 \ --nr_post_proc_workers=16 \ tile \ --input_dir=infer_images \ --output_dir=inferred_images_pannuke \ --draw_dot \ --save_qupath
I got the following error: I was jsut wondering if the way I did to load the checkpoint was incorrect.
`

@liux0614 You are loading hovernet_original_consep_notype_tf2pytorch.tar which doesnt do nuclei type classification. So you must set --nr_types= to 0 .

@liux0614 You are loading hovernet_original_consep_notype_tf2pytorch.tar which doesnt do nuclei type classification. So you must set --nr_types= to 0 .

I set nr_types to 0 with the following command
python run_infer.py \ --gpu='0,1' \ --nr_types=0 \ --type_info_path=type_info.json \ --batch_size=64 \ --model_mode=orignal \ --model_path=weights/hovernet_original_consep_notype_tf2pytorch.tar \ --nr_inference_workers=8 \ --nr_post_proc_workers=16 \ tile \ --input_dir=infer_images \ --output_dir=inferred_images_pannuke \ --draw_dot \ --save_qupath,
and still got the size mismatch error.

@liux0614 It works normal for me, also Ive just realized that your cmd is slightly off at another place. Also, from your screenshot, the netdesc ksize is wrong which means your cmd input didnt get fed correctly.
Could you put the following into a .sh and run it ?
python run_infer.py \
--gpu='0,1' \
--nr_types=0 \
--type_info_path=type_info.json \
--batch_size=64 \
--model_mode=original \
--model_path=../pretrained/hovernet_original_consep_notype_tf2pytorch.tar \
--nr_inference_workers=8 \
--nr_post_proc_workers=16 \
tile \
--input_dir=exp_output/imgs/ \
--output_dir=exp_output/pred/ \
--draw_dot \
--save_qupath

@liux0614 It works normal for me, also Ive just realized that your cmd is slightly off at another place. Also, from your screenshot, the netdesc ksize is wrong which means your cmd input didnt get fed correctly.
 The command line I ran is from run_tile.sh.

I think I did exactly what you said. The command line I ran is from run_tile.sh.

How did you run the .sh ? Also, which os systems are you running on? I'm using bash run_tile.sh.

How did you run the .sh ? Also, which os systems are you running on? I'm using bash run_tile.sh.

@liux0614 ah ok, I realize now. You have typo in your screenshot orignal not original.

@liux0614 ah ok, I realize now. You have typo in your screenshot orignal not original.

I tried bash run_tile.py. It works. Thanks very much.

I tried bash run_tile.py. It works. Thanks very much.


Enable tests on stable-*

Needed for #116.
cc @nrabinowitz

Pull Request Test Coverage Report for Build #334

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.38%

Totals

Change from base Build #333:
0.0%

Covered Lines:
481

Relevant Lines:
484

💛  - Coveralls


When using multiple element types, queue jobs give an error preventing indexing

Craft: 5.5.5
Scout: 5.0.2
I am using multiple element types and when I save an Entry or Solspace Event Element and the queue job tries to run the reindex I get the below error.
$indices[] = \rias\scout\ScoutIndex::create(getenv('ALGOLIA_ENV') . '_search')
  ->getElements(function () {
    return [
      Entry::find()->section(['pages','team','jobs']),
      Event::find()->setRangeStart('now'),
   ];
})->transformer(function (\craft\base\Element $element) {

Error:
rias\scout\jobs\MakeSearchable::rias\scout\jobs\{closure}():
Argument #1 ($criteria) must be of type rias\scout\jobs\ElementQuery, craft\elements\db\EntryQuery given,
called in /vendor/illuminate/collections/Arr.php on line 203

Thanks for reporting @a-am, will try to reproduce asap

Fixed in 5.0.3 - could you update and give it another try @a-am? Thanks!


Weird behaviour when running with Steam

Issue description
I don't know if this should be should be reported or not, since you mentioned running with Steam might cause some weird behaviour. Nonetheless I noticed these bugs while doing so:

Running Steam and playing in-game (Counter Strike: Global Offensive) causes people I'm playing with on any given server to appear as if they were my friend in Punk's friend list. Although the only available option in the right click menu for those players is "View Steam profile".

Starting Steam causes all friends, confirmed at present to be offline, to appear online in Punk playing the last game they were playing last time I had Punk/Steam running.

Closing Steam and then restarting Punk restores Punk's friend list to how it should accurately appear.
Suggestions
Perhaps if this can't be resolved, or even if it can but won't be till a later date, that a disclaimer in the readme stating that running Steam beside Punk can cause unintended side effects.

Running 2 Steam clients on the same machine is not advised in general, I might look into it but for the time being, I'll probably add just a disclaimer.

My steam account was just deleted by using this.


python311Packages.netapp-ontap: <IP_ADDRESS> -> <IP_ADDRESS>

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.netapp-ontap is: A library for working with ONTAP's REST APIs simply in Python
meta.homepage for python311Packages.netapp-ontap is: https://devnet.netapp.com/restapi.php
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found <IP_ADDRESS> with grep in /nix/store/vwj5n95v6nhvvx01y9azhwbziy7jzjq2-python3.11-netapp-ontap-<IP_ADDRESS>
found <IP_ADDRESS> in filename of file in /nix/store/vwj5n95v6nhvvx01y9azhwbziy7jzjq2-python3.11-netapp-ontap-<IP_ADDRESS>

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.netapp-ontap
python312Packages.netapp-ontap

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vwj5n95v6nhvvx01y9azhwbziy7jzjq2-python3.11-netapp-ontap-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.netapp-ontap https://github.com/r-ryantm/nixpkgs/archive/7ac4852efaa1a156e42b5e4b668958b37545e752.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/7ac4852efaa1a156e42b5e4b668958b37545e752#python311Packages.netapp-ontap

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vwj5n95v6nhvvx01y9azhwbziy7jzjq2-python3.11-netapp-ontap-<IP_ADDRESS>
ls -la /nix/store/vwj5n95v6nhvvx01y9azhwbziy7jzjq2-python3.11-netapp-ontap-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

4 packages built:

python311Packages.netapp-ontap
python311Packages.netapp-ontap.dist
python312Packages.netapp-ontap
python312Packages.netapp-ontap.dist

Maintainer pings
cc @SuperSandro2000 for testing.

Result of nixpkgs-review pr 313035 run on x86_64-linux 1

4 packages built:

python311Packages.netapp-ontap
python311Packages.netapp-ontap.dist
python312Packages.netapp-ontap
python312Packages.netapp-ontap.dist


Typos in Notebooks

Fixed some typos on the intro, csp and games notebooks.

(closed and reopened RP to restart the Travis Build Test)

conflicts


Facts are not set properly

I'm using a module which checks osfamily and fails if it is not Debian.
Now I tried to test it with a scenario for one node, but everytime the module complains that osfamily is empty!.
I checked and tried debugging the code, and can see that my scenarios.yml is read properly and all the facts show up here (https://github.com/invadersmustdie/puppet-catalog-test/blob/master/lib/puppet-catalog-test/test_runner.rb#L77) where it is passed of to the Puppet API. After that I'm not really sure what happens.
Is this a bug, or did I miss some configuration step?
My scenarios.yml:
__default_facts: &default_facts
  architecture: x86_64
  ipaddress: <IP_ADDRESS>
  osfamily: Debian
  operatingsystem: Ubuntu
  operatingsystemrelease: 15.10
  local_run: true
  disable_asserts: true
  interfaces: eth0

foobar:
  <<: *default_facts
  fqdn: foobar.example.com

Specifically I'm trying to use puppetlabs-rabbitmq, and it fails on this check: https://github.com/puppetlabs/puppetlabs-rabbitmq/blob/master/manifests/params.pp#L62
with the following error message:
Evaluation Error: Error while evaluating a Function Call, The rabbitmq module is not supported on an  based system. at <...>/modules-contrib/rabbitmq/manifests/params.pp:62:7 on node foobar

As you can see, the part says: ... on an  based system - clearly the actual osfamily variable is empty.

The problem here is that the facts are only available through the $facts toplevel variable. They also need to be merged into the node's scope, as in the 3.x case. The following change to PuppetCatalogTest::Puppet4xAdapter#create_node fixes the issue:
def create_node(hostname, facts)
  node = Puppet::Node.new(hostname, :facts => Puppet::Node::Facts.new(hostname, facts))
  node.merge(facts)
  node
end

This should be fixed in next release, which is scheduled for this weekend. Thanks @jerith for supplying the fix!

just released 0.4.2


about second_iou

Hi, thank you for your code. I don't really understand the function roi_grid_pool in the roi head of second, especially why you sample the original 2d feature to a 7x7 size. Can you explain it to me?

That just a rotated version of roi_grid_pooling in FasterRCNN.

@jihanyang hi I have similar question and is confused about your ROI-HEAD of "SECONDHead". Can you give more explanation ?


Utility Groups for Desktop first variants

I have define a class like example below:
class="-md:(top-0 right-0)"
Then in browser it renders like below:
class="-lg:top-0 lg:right-0" (notice that right-0 doesn't have the - prefix).
So i had to define it in css instead:
@screen -md {
  @apply top-0 right-0;
}

Am i missing something here?

awesome it works, thanks!


akubra resolver

add to riiif.initializer.rb:
Riiif::Image.file_resolver = Riiif::AkubraSystemFileResolver
Riiif::AkubraSystemFileResolver.pathroot = <fedora /data datastream path>
Riiif::AkubraSystemFileResolver.imagetype = "jp2"
Riiif::AkubraSystemFileResolver.akubraconfig = [[0,2],[2,2],[4,1]]
[[0,2],[2,2],[4,1]] = ##/##/#

@yulgit1 would you mind rebasing this? Then I can merge it.

@jcoyne rebased.

@yulgit1 Okay, now AkubraSystemFileResolver needs to be changed into a class to follow the changes in https://github.com/curationexperts/riiif/commit/7edf149f8ca59c24d859d78024eb1e2b3c0b6c53 It should also have at least one test.

@jcoyne, ok made those changes and added a test


Autocomplete for included modules

plugin version:
0.73
Description
/*module A*/
open Belt.MutableMap;
set  <--- correctly detected

/*module B*/
A.set <--- works

/*module A*/
include Belt.MutableMap;
set  <--- not detected at all

/*module B*/
A.set <--- doesn't work

Fixed in 0.74


markdown highlight

It will be a nice feature!

Some research should be done on a lightweight, JS syntax highlighter / editor for markdown. Things like Codemirror or ACE and completely overkill for something like this.

how about http://prismjs.com/?


"Task not found" with workspace AND "root package"

In crate with workspace AND "root package":

Calling cargo make build/test/etc. ignores "root package"
Calling cargo make 'task_name' (without CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE) results in "Task not found". Adding CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE ignores "root package".

Basic cargo build/test works fine.
See attachment.

@tower120 thanks for reporting.
I think its due to misunderstanding on my part of the spec so i'll fix that.
if i only picked up members from the members attribute and dependencies.
root, i only took if no members were defined, but thats my issue, if package is defined, i need to add the root as well.
i'll fix that.

@tower120  I just pushed a fix in the dev branch 0.35.11 and would love your feedback. can you try it out and tell if it works well?

I unfamiliar with compiler crates. How can I build/apply it?

you can look at this explanation https://doc.rust-lang.org/cargo/commands/cargo-install.html#synopsis
basically its
cargo install --git git@github.com:sagiegurari/cargo-make.git --branch 0.35.11

Looks like the same error with project attached in issues.

meaning its ignoring the 'root' package? can you show me the output please?

PS C:\RustProjects\cargo_make_test> cargo install --git https://github.com/sagiegurari/cargo-make.git --branch 0.35.11
    Updating git repository `https://github.com/sagiegurari/cargo-make.git`
  Installing cargo-make v0.35.10 (https://github.com/sagiegurari/cargo-make.git?branch=0.35.11#ab70a4bb)
    Updating crates.io index
  Downloaded lenient_semver_parser v0.4.2
  Downloaded lenient_semver_version_builder v0.4.2
  Downloaded lenient_semver v0.4.2
  Downloaded 3 crates (351.9 KB) in 1.02s
   Compiling winapi v0.3.9
   Compiling proc-macro2 v1.0.37
   Compiling cfg-if v1.0.0
   Compiling unicode-xid v0.2.2
   Compiling autocfg v1.1.0
   Compiling syn v1.0.91
   Compiling serde_derive v1.0.136
   Compiling serde v1.0.136
   Compiling libc v0.2.124
   Compiling memchr v2.4.1
   Compiling lazy_static v1.4.0
   Compiling ppv-lite86 v0.2.16
   Compiling encoding_index_tests v0.1.4
   Compiling version_check v0.9.4
   Compiling typenum v1.15.0
   Compiling winapi-build v0.1.1
   Compiling semver v1.0.7
   Compiling log v0.4.16
   Compiling regex-syntax v0.6.25
   Compiling dunce v1.0.2
   Compiling tinyvec_macros v0.1.0
   Compiling winapi v0.2.8
   Compiling fnv v1.0.7
   Compiling crc32fast v1.3.2
   Compiling itoa v1.0.1
   Compiling matches v0.1.9
   Compiling adler v1.0.2
   Compiling hashbrown v0.11.2
   Compiling serde_json v1.0.79
   Compiling unicode-bidi v0.3.7
   Compiling native-tls v0.2.10
   Compiling percent-encoding v2.1.0
   Compiling crossbeam-utils v0.8.8
   Compiling ryu v1.0.9
   Compiling utf8-ranges v0.1.3
   Compiling regex-syntax v0.3.9
   Compiling once_cell v1.10.0
   Compiling bytes v1.1.0
   Compiling camino v1.0.7
   Compiling os_str_bytes v6.0.0
   Compiling cpufeatures v0.2.2
   Compiling lazy_static v0.1.16
   Compiling either v1.6.1
   Compiling wildmatch v2.1.0
   Compiling nom v1.2.4
   Compiling whoami v1.2.1
   Compiling strsim v0.10.0
   Compiling num_cpus v1.13.1
   Compiling textwrap v0.15.0
   Compiling heck v0.4.0
   Compiling base64 v0.13.0
   Compiling bitflags v1.3.2
   Compiling fs_extra v1.2.0
   Compiling glob v0.3.0
   Compiling rust_info v0.3.2
   Compiling git_info v0.1.2
   Compiling getrandom v0.2.6
   Compiling encoding-index-tradchinese v1.20141219.5
   Compiling encoding-index-japanese v1.20141219.5
   Compiling encoding-index-korean v1.20141219.5
   Compiling encoding-index-simpchinese v1.20141219.5
   Compiling encoding-index-singlebyte v1.20141219.5
   Compiling num-traits v0.2.14
   Compiling num-integer v0.1.44
   Compiling num-iter v0.1.42
   Compiling indexmap v1.8.1
   Compiling kernel32-sys v0.2.2
   Compiling tinyvec v1.5.1
   Compiling generic-array v0.14.5
   Compiling miniz_oxide v0.5.1
   Compiling form_urlencoded v1.0.1
   Compiling thread_local v1.1.4
   Compiling clap_lex v0.1.1
   Compiling http v0.2.6
   Compiling meval v0.2.0
   Compiling rand_core v0.6.3
   Compiling encoding v0.2.33
   Compiling unicode-normalization v0.1.19
   Compiling rand_chacha v0.3.1
   Compiling quote v1.0.18
   Compiling aho-corasick v0.7.18
   Compiling bstr v0.2.17
   Compiling memchr v0.1.11
   Compiling which v4.2.5
   Compiling fern v0.6.1
   Compiling flate2 v1.0.23
   Compiling rand v0.8.5
   Compiling idna v0.2.3
   Compiling aho-corasick v0.5.3
   Compiling regex v1.5.5
   Compiling winapi-util v0.1.5
   Compiling schannel v0.1.19
   Compiling time v0.1.43
   Compiling atty v0.2.14
   Compiling dirs-sys-next v0.1.2
   Compiling home v0.5.3
   Compiling ansi_term v0.12.1
   Compiling crypto-common v0.1.3
   Compiling block-buffer v0.10.2
   Compiling url v2.2.2
   Compiling fsio v0.3.0
   Compiling same-file v1.0.6
   Compiling termcolor v1.1.3
   Compiling globset v0.4.8
   Compiling java-properties v1.4.1
   Compiling shell2batch v0.4.4
   Compiling colored v2.0.0
   Compiling dirs-next v2.0.0
   Compiling thread-id v2.0.0
   Compiling digest v0.10.3
   Compiling walkdir v2.3.2
   Compiling duckscript v0.7.1
   Compiling run_script v0.9.0
   Compiling num v0.1.42
   Compiling attohttpc v0.18.0
   Compiling thread_local v0.2.7
   Compiling sha2 v0.10.2
   Compiling ignore v0.4.18
   Compiling chrono v0.2.25
   Compiling regex v0.1.80
   Compiling ftp v3.0.1
   Compiling cargo-platform v0.1.2
   Compiling serde_ignored v0.1.2
   Compiling toml v0.5.9
   Compiling lenient_semver_version_builder v0.4.2
   Compiling envmnt v0.9.1
   Compiling clap v3.1.9
   Compiling lenient_semver_parser v0.4.2
   Compiling ci_info v0.14.4
   Compiling cargo_metadata v0.14.2
   Compiling duckscriptsdk v0.8.10
   Compiling lenient_semver v0.4.2
   Compiling cargo-make v0.35.10 (C:\Users\Andy\.cargo\git\checkouts\cargo-make-beee6198da581977\ab70a4b)
warning: unknown lint: `deprecated_cfg_attr_crate_type_name`
  --> src/lib/mod.rs:21:5
   |
21 |     deprecated_cfg_attr_crate_type_name,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unknown_lints)]` on by default

warning: unknown lint: `duplicate_macro_attributes`
  --> src/lib/mod.rs:26:5
   |
26 |     duplicate_macro_attributes,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: `cargo-make` (lib) generated 2 warnings
    Finished release [optimized] target(s) in 2m 57s
   Replacing C:\Users\Andy\.cargo\bin\cargo-make.exe
   Replacing C:\Users\Andy\.cargo\bin\makers.exe
    Replaced package `cargo-make v0.35.10` with `cargo-make v0.35.10 (https://github.com/sagiegurari/cargo-make.git?branch=0.35.11#ab70a4bb)` (executables `cargo-make.exe`, `makers.exe`)
PS C:\RustProjects\cargo_make_test> cargo make build-test-1
[cargo-make] INFO - cargo make 0.35.10
[cargo-make] INFO - Project: cargo_make_test
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: build-test-1
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: legacy-migration
[cargo-make] INFO - Running Task: workspace
C:\RustProjects\cargo_make_test
[cargo-make][1] INFO - Project: crate1
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: build-test-1
[cargo-make][1] INFO - Profile: development
[cargo-make][1] ERROR - Task build-test-1 not found
[cargo-make][1] WARN - Build Failed.
[cargo-make] ERROR - Error while running duckscript: Source: Unknown Line: 4 - Error while executing command, exit code: 1
[cargo-make] WARN - Build Failed.

I only update the version when i publish so thats ok.
is the test you are running the same as you attached initially? did you set the CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE?
if so i'll use it as a test to check

I just download attachment from and tried with it, to double check. It is the same error I just wrote.

CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE is not set in there

ok that should be set since you want in the member to access a task that is defined in the root. right?

I think no - since I don't want member tasks to be build through cargo-make process. Only root one. I want root crate to serve as lib hub.
See https://github.com/bevyengine/bevy project structure, for example.

Or that was not the question? I just looked at doc - it looked like I didn't need CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE.

let me explain a bit.
cargo-make checks the makefile.toml in the directory its invoked.
for workspace its invoked as child process for every member.
so in the member that is on different dir, it doesn't see the makefile in the workspace root.
in order to automatically 'extend' the root makefile, you need that env var defined.
i just took your example, uncommented that env var comment and made it used and it worked well.
however, since cargo-make is invoked also as child it will go to installed version so in order to really test it, you must install the current git version and not just run something locally.

however, since cargo-make is invoked also as child it will go to installed version so in order to really test it, you must install the current git version and not just run something locally.

I did
cargo install --git https://github.com/sagiegurari/cargo-make.git --branch 0.35.11

Doesn't that install compiled git version?
I uncommented CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE - I still have the same error as above.

@tower120 here is what i did. can you please check it and compare with your test?

Created new empty gitpod machine

Run installation and pull example:

cargo install --git https://github.com/sagiegurari/cargo-make.git --branch 0.35.11
mkdir -p ./tasknotfound
cd ./tasknotfound
wget https://github.com/sagiegurari/cargo-make/files/8484155/cargo_make_test.zip
unzip ./cargo_make_test.zip
cd ./cargo_make_test

manually uncomment CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE

run cargo make build-test-1

output:
see that member is invoked with task but fails on rustc setup which is ok, but task is found
cargo make build-test-1
[cargo-make] INFO - cargo make 0.35.10
[cargo-make] INFO - Project: cargo_make_test
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: build-test-1
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: legacy-migration
[cargo-make] INFO - Running Task: workspace
/workspace/misc-test/tasknotfound/cargo_make_test
[cargo-make][1] INFO - Project: crate1
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: build-test-1
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Skipping Task: legacy-migration
[cargo-make][1] INFO - Running Task: build-test-1
   Compiling crate1 v0.1.0 (/workspace/misc-test/tasknotfound/cargo_make_test/crates/crate1)
error[E0463]: can't find crate for `std`
  |
  = note: the `x86_64-pc-windows-msvc` target may not be installed
  = help: consider downloading the target with `rustup target add x86_64-pc-windows-msvc`

For more information about this error, try `rustc --explain E0463`.
error: could not compile `crate1` due to previous error
[cargo-make][1] ERROR - Error while executing command, exit code: 101
[cargo-make][1] WARN - Build Failed.
[cargo-make] ERROR - Error while running duckscript: Source: Unknown Line: 4 - Error while executing command, exit code: 1
[cargo-make] WARN - Build Failed.

create some test task in root makefile toml

[tasks.echo]
command = "echo"
args = ["current member: ${CARGO_MAKE_CRATE_CURRENT_WORKSPACE_MEMBER}"]

The output was:
cargo make echo
[cargo-make] INFO - cargo make 0.35.10
[cargo-make] INFO - Project: cargo_make_test
[cargo-make] INFO - Build File: Makefile.toml
[cargo-make] INFO - Task: echo
[cargo-make] INFO - Profile: development
[cargo-make] INFO - Running Task: legacy-migration
[cargo-make] INFO - Running Task: workspace
/workspace/misc-test/tasknotfound/cargo_make_test
[cargo-make][1] INFO - Project: crate1
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: echo
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Skipping Task: legacy-migration
[cargo-make][1] INFO - Execute Command: "echo" "current member: crate1"
current member: crate1
[cargo-make][1] INFO - Build Done in 0.20 seconds.
[cargo-make][1] INFO - Project: cargo_make_test
[cargo-make][1] INFO - Build File: Makefile.toml
[cargo-make][1] INFO - Task: echo
[cargo-make][1] INFO - Profile: development
[cargo-make][1] INFO - Skipping Task: legacy-migration
[cargo-make][1] INFO - Execute Command: "echo" "current member: ."
current member: .
[cargo-make][1] INFO - Build Done in 0.21 seconds.
[cargo-make] INFO - Build Done in 0.79 seconds.

as you can see both member '.' (root) and crate1 were invoked.

Looks like you repeat my steps, but result is different on my local machine.
I uncommened CARGO_MAKE_EXTEND_WORKSPACE_MAKEFILE. And tried to add tasks.echo - it does not see that task too.
Could you increase crate version number in dev branch? I have filling that somehow crates.io version is still in use.

@tower120 you can fork that branch to you and update it and than install it from your fork.

I tried to increase version and install. Still no luck.
You know - maybe this is indeed something on my side - I just not see it.

try to use 'which' to see which cargo-make executable is used and see where cargo install pushes it. maybe its different places

How? I'm on Windows. For example:
where.exe cargo-make
C:\Users\Andy\.cargo\bin\cargo-make.exe

oh, windows :). so try to delete it, and run it and see if it fails (it should). then install again.

Unistalled then installed. No effect - still ERROR - Task echo not found.

so maybe i got a bug on windows?
hard to say. try to put verbose logs and redirect to file and attach it as a file or something. it will be big.

Just FYI - I already migrated to powershell script.
cargo make --verbose echo

ok, something is strange to me here...
you are running it from C:\tmp\bevy_test right?
in the Cargo.toml there you have dependency:  "../bevy"?
I think at the moment, its not detecting it as a workspace. are these 2 folders defined under a same workspace?

per the spec, in order to bevy_test to be considered workspace root, it must have the [workspace] tag
https://doc.rust-lang.org/cargo/reference/workspaces.html#root-package
so i'm just wondering how the structure is of the project exactly

Damn, sorry. I tried that with a wrong project.
It turns out that it working.

great news. i was worried I got more 'windows' specific issues since i don't have windows to try it on..... so happy its resolved.
i'm hoping to officially release it soon

@tower120 this is now officially released.


fix HMAC_DRBG edge case

The NIST SP 800-90A spec of HMAC_DRBG uses "!= Null" checks, but "Null" is never defined in the document. In the current implementation, it was interpreted as nil. However, the NIST examples document uses "<empty>" values, so []byte{} should be passed in the test cases. If that happens, the nil checks do not work as expected. Therefore, instead of checking equality with nil, it should be checked whether the length of additional_info is zero.
As additional evidence I cite the openssl implementation, which checks for zero length instead of NULL pointer equality.
I do not expect this to have a concrete security impact, but still it would be nice if the implementation was correct.

I duplicated the tests and in one of them use nil and in the other []byte{}. Additionally, I added a changelog fragement and capitalized the commit subject line. Unfortunately, the URLs are wider than 80 characters, and I wasn't sure how to wrap them.
Finally, I'm not 100% sure if any part of Oasis uses an empty slice somewhere in it's code, so I left a TODO in the fragment. I can update it if you have a definite answer for me.

Finally, I'm not 100% sure if any part of Oasis uses an empty slice somewhere in it's code, so I left a TODO in the fragment. I can update it if you have a definite answer for me.

No, we don't, and in fact, there is no way for the edge case to be triggered.  Since the affected routines are package private, it's fairly easy to confirm this via manual review.

Drbg.Read always passes nil as additionalInput
New always passes a non-0 length slice (seedMaterial) as additionalInput

I briefly skimmed the output of git grep drbg but from my experience the package maintainers usually have a much better overview :slightly_smiling_face:
I feel like the URLs are helpful in the commit messages so I'm hesitant to remove them in order to make the linter happy. How do you want to proceed?

I feel like the URLs are helpful in the commit messages so I'm hesitant to remove them in order to make the linter happy. How do you want to proceed?

Good point, I just fixed the linter in #3168, once that's merged, you can rebase and the linter should pass. I'll also trigger the non-lint CI workflow again after your rebase.

@kostko
Sorry this took so long. I think the linter regex doesn't like the hash fragment. On line 10, it says:
 URL_RE_RAW = r'http[s]?://(?:[a-zA-Z]|[0-9]|[$-_@.&+]|[!*\(\),]|(?:%[0-9a-fA-F][0-9a-fA-F]))+'

Note that the third bracket after :// we have<EMAIL_ADDRESS>where $-_ means all characters between $ (0x24) and _ (0x5f). However, the hash sign # is 0x23, so it doesn't match this bracket expression.
Do you want to fix the regex or should we skip the more precise reference and use a link without hash fragment?

Aw sorry, I only tested with the first URL. Feel free to fix the regexp in this PR, just in a separate commit.

Thanks again! I also triggered the other CI workflow to run now.


Support for Payments

Hello, thanks for this library, I know that facebook messenger payments is still in beta i will just like to know if there's any plan to add Buy button implementation. Can i maybe make a pull request?

Hi, thanks for using messenger4j! As you said payment support is still in beta but messenger4j will support it in near future. Currently I do a bigger redesign and reimplementation including full jdk8 support. When this is finished I will implement payment functionality.


refactor the server rag

Hello, I am a PR summary agent on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


importlib_resources is not mentioned in requirements

The package importlib-resources should be added to the appropriate place of your requirements setup, at least for Python < 3.7, as you use it here:
https://github.com/spulec/moto/blob/9bc6bded6e6472f04a45f0bc429acc926c2cdc08/moto/dynamodb2/parsing/reserved_keywords.py#L21-L24

Thanks for raising this @bnavigator!

Thanks for raising this @bnavigator!


chore: update bug template

Description of changes

Update repro steps description
Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM


Fix https://github.com/delta-io/delta/issues/1978

Which Delta project/connector is this regarding?

[ ] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[x] Other (Power BI)

Description
Fix #1978

How was this patch tested?
With local Power BI and sample Dataset

Does this PR introduce any user-facing changes?
No

I tried to change the PowerBI_Delta.pbit file too. However, I don't think I am able to do it as I don't have the credentials for the Azure Storage Account used in the template.
Can we still merge the function? It has been tested and solved the issue.

Hi @dominikpeter,
while the file fn_ReadDeltaTable.pq is the final output for Power BI, I usually also maintain the .pbit file for debugging and development of new features. It should be OK to just save the PQ queries in the template and save it without applying the changes.
regarding your change, the fix seems reasonable as the Extension column seems to contain everything after the first . found in the filename which was not an issue until the compacted files were introduced
However, instead of Text.Mid() I would rather use Text.EndsWith() (docs) which should be safer to use
If its OK for you, I would take over the ticket, do the changes in the PBIT and fn_ReadDeltaTable
regards and thanks for your contribution so far!
-gerhard

@gbrueckl sure, you can take it over. Thanks a lot.

@gbrueckl I am not sure how you want to use Text.EndsWith() as the compacted file also end with .json.

I created a new PR that fixes this issue
https://github.com/delta-io/delta/pull/2101
I also added some documentation for further contributions under /connectors/PowerBI/README.md
Further I changed the sample data to use the Golden Tables provided as part of this repo wherever possible


Post requests not functioning properly

Description of issue
Locust v0.11.0 appears to be using GET requests even though locust file specifies to use a post request
Expected behavior
Post request made to specified URI
Actual behavior
Get request is made instead
Environment settings

OS: Debian devirative
Python version: 3.6.8
Locust version: 0.11.0

Steps to reproduce (for bug reports)
#!/usr/bin/env python3
import json

from locust import HttpLocust, TaskSet, task

headers = {
    "Host": "host.host.net",
    "User-Agent":
    "Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0",
    "Accept": "application/json, text/plain, */*",
    "Accept-Language": "en-US,en;q=0.5",
    "Accept-Encoding": "gzip, deflate, br",
    "Content-Type": "application/json;charset=utf-8",
    "Authorization":
    "REDACTED",
    "refreshTokenId": "REDACTED",
    "Content-Length": "49",
    "Connection": "keep-alive",
}
data = {"UserID": "REDACTED"}

def info(l):
    response = l.client.post("/api/",
                             data=data,
                             headers=headers)
    print(response)
    print(response.text)
    print(response.status_code)

class UserBehavior(TaskSet):
    tasks = {info: 1}

class MyLocust(HttpLocust):
    task_set = UserBehavior
    min_wait = 5000
    max_wait = 15000

Sample of the logs
[2019-06-18 16:09:07,290] Eris/INFO/locust.runners: All locusts hatched: MyLocust: 5
[2019-06-18 16:09:07,303] Eris/INFO/stdout: <Response [405]>
[2019-06-18 16:09:07,304] Eris/INFO/stdout:
[2019-06-18 16:09:07,304] Eris/INFO/stdout: {"message":"The requested resource does not support http method 'GET'."}
[2019-06-18 16:09:07,304] Eris/INFO/stdout:
[2019-06-18 16:09:07,304] Eris/INFO/stdout: 405
[2019-06-18 16:09:07,304] Eris/INFO/stdout:
[2019-06-18 16:09:15,109] Eris/ERROR/stderr: KeyboardInterrupt
[2019-06-18 16:09:15,110] Eris/ERROR/stderr: 2019-06-18T20:09:15Z
[2019-06-18 16:09:15,110] Eris/ERROR/stderr:
[2019-06-18 16:09:15,110] Eris/INFO/locust.main: Shutting down (exit code 0), bye.
[2019-06-18 16:09:15,110] Eris/INFO/locust.main: Cleaning up runner...
[2019-06-18 16:09:15,127] Eris/INFO/locust.main: Running teardowns...

I've tested on version 0.9.0 and the error still occurs
[2019-06-18 16:35:57,174] Eris/INFO/stdout: <Response [405]>
[2019-06-18 16:35:57,175] Eris/INFO/stdout:
[2019-06-18 16:35:57,175] Eris/INFO/stdout: {"message":"The requested resource does not support http method 'GET'."}
[2019-06-18 16:35:57,175] Eris/INFO/stdout:
[2019-06-18 16:35:57,175] Eris/INFO/stdout: 405
[2019-06-18 16:35:57,176] Eris/INFO/stdout:
[2019-06-18 16:36:03,653] Eris/ERROR/stderr: KeyboardInterrupt
[2019-06-18 16:36:03,653] Eris/ERROR/stderr: 2019-06-18T20:36:03Z
[2019-06-18 16:36:03,653] Eris/ERROR/stderr:
[2019-06-18 16:36:03,653] Eris/INFO/locust.main: Shutting down (exit code 0), bye.
[2019-06-18 16:36:03,654] Eris/INFO/locust.main: Cleaning up runner...
[2019-06-18 16:36:03,654] Eris/INFO/locust.main: Running teardowns...
➜  ~ locust --version
[2019-06-18 16:36:54,111] Eris/INFO/stdout: Locust 0.9.0
[2019-06-18 16:36:54,112] Eris/INFO/stdout:

are you hitting a redirect?  that would make requests issue a GET.
see: https://github.com/kennethreitz/requests/issues/1704

To my knowledge there isn't a redirect involved in this, however would Requests and (by extension) Locust handle an application behind a loadbalancer similar to a redirect?

I'm having this issue too. Threw me in a giant loop until I logged out my server I was testing. Locusio is definitely sending GETs for POSTs. In my case I'm using the json= flag.

@lanceofwhichwedream Yes, Locust should have no trouble with a load balancer. A load balancer (or reverse proxy) should be mostly transparent to the clients and does not issue any HTTP redirects by itself.
@ldelossa Could you post a  minimal code example producing this? I'm not able to reproduce this issue with the code in the original post (I ran the exact same code, and only edited the Host header to make a request to a requestbin.com bin: https://requestbin.com/r/enj414fza79v/1SNYGpbh5MMBAbVnCbJdJV6ZUJC).
It does sound like it could be that the server returns a HTTP redirect, which the client by default follows, and thus (correctly) issues a HTTP GET.

I seem to also be getting this issue. Is there any update?

I seem to also be getting this issue. Is there any update?

I seem to also be getting this issue. Is there any update?

This ticket never made any sense, so it is unlikely that you are having the same issue. Please file a new ticket with your full details (locust file and locust version mainly), or ask on stack overfloow.

I seem to also be getting this issue. Is there any update?

This ticket never made any sense, so it is unlikely that you are having the same issue. Please file a new ticket with your full details (locust file and locust version mainly), or ask on stack overfloow.

IIRC, the GET in these errors occur because of a redirect at the server. So you send a POST, but server responds with a redirect and locust io logs a GET. Its not a real issue.

IIRC, the GET in these errors occur because of a redirect at the server. So you send a POST, but server responds with a redirect and locust io logs a GET. Its not a real issue.

IIRC, the GET in these errors occur because of a redirect at the server. So you send a POST, but server responds with a redirect and locust io logs a GET. Its not a real issue.

If that is what happens then it kind of is an issue. It should still log a POST (it might not do that, but in that case I think that behaviour should be changed)

IIRC, the GET in these errors occur because of a redirect at the server. So you send a POST, but server responds with a redirect and locust io logs a GET. Its not a real issue.

If that is what happens then it kind of is an issue. It should still log a POST (it might not do that, but in that case I think that behaviour should be changed)

Just throwing something out there, is locust io telling the "requests" library to follow redirects?
https://gist.github.com/cbare/4333273#file-test_requests_redirect-py-L20

Just throwing something out there, is locust io telling the "requests" library to follow redirects?
https://gist.github.com/cbare/4333273#file-test_requests_redirect-py-L20

I’m guessing we dont, but probably should :)

I’m guessing we dont, but probably should :)

could be it!

could be it!

So the server was issuing a redirect. It was only at the apache level. It was a http vs https issue.
Confusing things further was CURL. It doesn't change the verb to GET but continues to use POST. Postman on the other hand does what locust does and moves to GET if POST gets redirected.
I've read up on it a little and it the different behaviours among different tech is frustrating and there are good points for both. Hopefully this comment is found and helps someone else.
Im unsure on whether locust should log a GET or a POST. It feels like it should do... something.

So the server was issuing a redirect. It was only at the apache level. It was a http vs https issue.
Confusing things further was CURL. It doesn't change the verb to GET but continues to use POST. Postman on the other hand does what locust does and moves to GET if POST gets redirected.
I've read up on it a little and it the different behaviours among different tech is frustrating and there are good points for both. Hopefully this comment is found and helps someone else.
Im unsure on whether locust should log a GET or a POST. It feels like it should do... something.

Right now it logs a POST even if it ends up performing a GET

I think this is the appropriate behaviour (if we can only log one thing)

Right now it logs a POST even if it ends up performing a GET

I think this is the appropriate behaviour (if we can only log one thing)

In case it's not clear from @richkettle's comment, if you are encountering this issue try switching your target url from using http to using https.

Maybe this is something that should be documented somewhere in the Locust docs? Luckily I found this issue, but it wasn't until after much failure(I didn't find this issue until I specifically searched "Locust post sending get".
This may be normal behavior from certain clients like requests, but I think a note somewhere visible in the docs would be helpful. Happy to put a docs PR in this week if others think this would be a welcome addition to the docs.


Fix null pointer to mesh

After compiling with nvfortran, the code would fail during runtime with the following error:
Parallel run with            1 ranks
0: Null pointer for mesh%geo (/home/jjquinn/projects/xcompact/x3d2/src/xcompact.f90: 71)

--------------------------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
--------------------------------------------------------------------------
--------------------------------------------------------------------------
mpirun detected that one or more processes exited with non-zero status, thus causing
the job to be terminated. The first process to do so was:

  Process name: [[8151,1],0]
  Exit code:    127
--------------------------------------------------------------------------

The compilation and run steps on Sylvain's Kolmogorov machine are:
cmake -DCMAKE_BUILD_TYPE=Debug -B build -DCMAKE_Fortran_COMPILER=mpif90
cmake --build build -j18
mpirun -n 1 build/src/xcompact

This PR removes the allocatable attribute on mesh and changes both mesh and its contained geo and par members to type instead of class. I'm don't know this feature of Fortran well enough to explain why this works but it fixes the problem...

Ah yes, it makes some sense. If you have a class, because it could be of any extended type of this class, you need to explicitly allocate it to the right type. Because here we only have a single type for this class, I believe the other compilers make the assumption that's the one we want to allocate.
Changing to type makes it unambiguous.


Initial commit of codebase

Initial commit of codebase

I have read the CLA Document and I hereby sign the CLA


Why can't I move files from Android/data to internal storage? I have authorized the persistent read and write permissions of Android/data through saf. The error code is no read and write permissions.

How can I copy files from the Android/data folder to the internal storage space or from the internal storage space to the subdirectory of data/, please give me some advice

Closed because no response for long time.

如何将文件从Android/data文件夹复制到内部存储空间或从内部存储空间复制到data/的子目录，请给我一些建议

兄弟，这个问题你解决了吗，可以给个例子吗

font{
    line-height: 1.6;
}
ul,ol{
    padding-left: 20px;
    list-style-position: inside;
}

我解决了，使用getContentResolver().openInputStream(documentFile.getUri());

---- Replied Message ----

     From

<EMAIL_ADDRESS>

     Date

    07/26/2022 14:00

     To

<EMAIL_ADDRESS>

     Cc

<EMAIL_ADDRESS>        ,

<EMAIL_ADDRESS>

     Subject

          Re: [anggrayudi/SimpleStorage] Why can't I move files from Android/data to internal storage? I have authorized the persistent read and write permissions of Android/data through saf. The error code is no read and write permissions. (#47)

如何将文件从Android/data文件夹复制到内部存储空间或从内部存储空间复制到data/的子目录，请给我一些建议
兄弟，这个问题你解决了吗，可以给个例子吗
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Recommendation to install beta breaks ecosystem

From the docs:

Installing the library is as easy as:
ember install<EMAIL_ADDRESS>
However this beta is not marked as latest, so any other addons that require ESA won't work - Babel will use random parts of the two libraries.
For example, using ember-simple-auth-token for JWT auth:
yarn why ember-simple-auth
yarn why v1.22.10
[1/4] Why do we have the module "ember-simple-auth"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Has been hoisted to "ember-simple-auth"
info This module exists because it's specified in "devDependencies".
info Disk size without dependencies: "1.8MB"
info Disk size with unique dependencies: "2.8MB"
info Disk size with transitive dependencies: "52.19MB"
info Number of shared dependencies: 236
=> Found<EMAIL_ADDRESS>info This module exists because "ember-simple-auth-token" depends on it.
info Disk size without dependencies: "2.73MB"
info Disk size with unique dependencies: "3.73MB"
info Disk size with transitive dependencies: "53.12MB"
info Number of shared dependencies: 236

In my case this means that
beforeModel(transition: any) {
    this.session.requireAuthentication(transition, 'login');
}

throws - session doesn't have any methods, only the authenticated data block. Uninstalling ember-simple-auth-token makes it work again.
Please can we get a 3.1.0 release, and never recommend installation of a beta - that's guaranteed to cause these types of problems.

See also https://github.com/jpadilla/ember-simple-auth-token/issues/290

See also https://github.com/jpadilla/ember-simple-auth-token/issues/290

However this beta is not marked as latest, so any other addons that require ESA won't work

You can use ember-simple-auth-token with versions of ember-simple-auth that are not marked as latest. In the vast majority of the applications I manage, we use an older version of ember-simple-auth and the latest version of ember-simple-auth-token. You simply ember install the specific version of ember-simple-auth that you want to be used.

and never recommend installation of a beta - that's guaranteed to cause these types of problems.

It should not cause problems. You are implying that you can only use the latest version of a package that another package depends on which is not true. You can use more recent version or older versions. It just has to be in the range of versions that satisfy the dependency.
If package A depends on package B ^2.1.0 then you use any version of package B that is greater or equal to 2.1 and less than 3.0.
ember-simple-auth-token has the following in package.json
"ember-simple-auth": "^1.6.0 || ^2.0.0 || ^3.0.0"

<EMAIL_ADDRESS>satisfies this dependency just like<EMAIL_ADDRESS>does even though neither are marked as latest.

However this beta is not marked as latest, so any other addons that require ESA won't work

You can use ember-simple-auth-token with versions of ember-simple-auth that are not marked as latest. In the vast majority of the applications I manage, we use an older version of ember-simple-auth and the latest version of ember-simple-auth-token. You simply ember install the specific version of ember-simple-auth that you want to be used.

and never recommend installation of a beta - that's guaranteed to cause these types of problems.

It should not cause problems. You are implying that you can only use the latest version of a package that another package depends on which is not true. You can use more recent version or older versions. It just has to be in the range of versions that satisfy the dependency.
If package A depends on package B ^2.1.0 then you use any version of package B that is greater or equal to 2.1 and less than 3.0.
ember-simple-auth-token has the following in package.json
"ember-simple-auth": "^1.6.0 || ^2.0.0 || ^3.0.0"

<EMAIL_ADDRESS>satisfies this dependency just like<EMAIL_ADDRESS>does even though neither are marked as latest.

You are misunderstanding.
<EMAIL_ADDRESS>is not backwards compatible. It implements parts of the documented spec that are not implemented in 3.0.1. e.g. this.session.requireAuthentication
An app written for 3.1.0-beta.1 will break in really weird ways if 3.0.1 is installed instead.
ember-simple-auth-token is calling for the latest 3.x version. Which is 3.0.1, NOT 3.1.0-beta.1. And Babel does not allow two addons of different versions. In this case, 3.0.1 is winning.
There is nothing wrong with ember-simple-auth-token. The problem is here in ember-simple-auth, using a beta version as the recommended release.

You are misunderstanding.
<EMAIL_ADDRESS>is not backwards compatible. It implements parts of the documented spec that are not implemented in 3.0.1. e.g. this.session.requireAuthentication
An app written for 3.1.0-beta.1 will break in really weird ways if 3.0.1 is installed instead.
ember-simple-auth-token is calling for the latest 3.x version. Which is 3.0.1, NOT 3.1.0-beta.1. And Babel does not allow two addons of different versions. In this case, 3.0.1 is winning.
There is nothing wrong with ember-simple-auth-token. The problem is here in ember-simple-auth, using a beta version as the recommended release.

If package A depends on package B ^2.1.0 then you use any version of package B that is greater or equal to 2.1 and less than 3.0

This would only be true if package B correctly uses Semver.

If package A depends on package B ^2.1.0 then you use any version of package B that is greater or equal to 2.1 and less than 3.0

This would only be true if package B correctly uses Semver.

ember-simple-auth-token is calling for the latest 3.x version.

It is not calling for the latest version of 3.x. It is calling for any version of 3.x that matches ^3.0.0.

This would only be true if package B correctly uses Semver, or the version required was in the major.minor.patch chain and was not as in this case a beta.

Yes. I was not aware that 3.1.0-beta.1 did not match ^3.0.0.
const semver = require('semver');
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0'); // => false
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0', { includePrerelease: true }); // => true
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0-alpha'); // => false
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0 || ^3.1.0-alpha'); // => true

ember-simple-auth-token is calling for the latest 3.x version.

It is not calling for the latest version of 3.x. It is calling for any version of 3.x that matches ^3.0.0.

This would only be true if package B correctly uses Semver, or the version required was in the major.minor.patch chain and was not as in this case a beta.

Yes. I was not aware that 3.1.0-beta.1 did not match ^3.0.0.
const semver = require('semver');
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0'); // => false
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0', { includePrerelease: true }); // => true
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0-alpha'); // => false
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0 || ^3.1.0-alpha'); // => true

As the recommendation in readme is to install the beta, this inherently makes the beta a release, no? Can we not just make a 3.1.0 release?

As the recommendation in readme is to install the beta, this inherently makes the beta a release, no? Can we not just make a 3.1.0 release?

An app written for 3.1.0-beta.1 will break in really weird ways if 3.0.1 is installed instead.

Of course it will ;) 3.1.0 introduces new APIs that do not exist in 3.0.1. That does not mean 3.1.0 is not backwards compatible.
We're aiming for a stable 3.1.0 within the next few weeks.

An app written for 3.1.0-beta.1 will break in really weird ways if 3.0.1 is installed instead.

Of course it will ;) 3.1.0 introduces new APIs that do not exist in 3.0.1. That does not mean 3.1.0 is not backwards compatible.
We're aiming for a stable 3.1.0 within the next few weeks.

@BryanCrotaz I would strongly recommend to use https://github.com/salsify/ember-cli-dependency-lint to avoid these kinds of issues in the future, and if you use yarn you can use https://github.com/atlassian/yarn-deduplicate to deduplicate dependencies in your lockfile to solve the version conflicts.

@BryanCrotaz I would strongly recommend to use https://github.com/salsify/ember-cli-dependency-lint to avoid these kinds of issues in the future, and if you use yarn you can use https://github.com/atlassian/yarn-deduplicate to deduplicate dependencies in your lockfile to solve the version conflicts.

:) I already use that - that's how I worked out what the problem was! I've used yarn's resolutions to fix it. The underlying problem is that a beta version is the recommended install in the readme, and so any other addons that extend ESA will break the developer's app.

:) I already use that - that's how I worked out what the problem was! I've used yarn's resolutions to fix it. The underlying problem is that a beta version is the recommended install in the readme, and so any other addons that extend ESA will break the developer's app.

the beta is only recommended in the README of the master branch, which corresponds to the beta release. if you look at the README for the stable version you shouldn't find such a recommendation AFAIK.

so any other addons that extend ESA will break the developer's app.

that's only true if you don't use dependency-lint or are not generally aware of the issue. and I do agree that it is an issue, but it is a more general issue, that is not just limited to ESA. even if there was a v3.1.0 release here your issue would not be resolved because the lockfile would still point to v3.0.x for existing installs.

the beta is only recommended in the README of the master branch, which corresponds to the beta release. if you look at the README for the stable version you shouldn't find such a recommendation AFAIK.

so any other addons that extend ESA will break the developer's app.

that's only true if you don't use dependency-lint or are not generally aware of the issue. and I do agree that it is an issue, but it is a more general issue, that is not just limited to ESA. even if there was a v3.1.0 release here your issue would not be resolved because the lockfile would still point to v3.0.x for existing installs.

When using ember-simple-auth-token, you should not be explicitly installing ember-simple-auth.

When using ember-simple-auth-token, you should not be explicitly installing ember-simple-auth.

When using ember-simple-auth-token, you should not be explicitly installing ember-simple-auth.

this is starting a somewhat different discussion now, but: why not?

When using ember-simple-auth-token, you should not be explicitly installing ember-simple-auth.

this is starting a somewhat different discussion now, but: why not?

ember-simple-auth-token depends on ember-simple-auth. A compatible version of ember-simple-auth is automatically installed when you install ember-simple-auth-token.

ember-simple-auth-token depends on ember-simple-auth. A compatible version of ember-simple-auth is automatically installed when you install ember-simple-auth-token.

sure, but that does not mean that you can't install ESA explicitly too. you only have to be careful that both versions match up. the alternative would be that ember-simple-auth-token would declare ESA as a peer dependency instead.

sure, but that does not mean that you can't install ESA explicitly too. you only have to be careful that both versions match up. the alternative would be that ember-simple-auth-token would declare ESA as a peer dependency instead.

@Turbo87 Yes, you are correct. You can explicitly install ESA if you want but you need to make sure to install a supported version.

@Turbo87 Yes, you are correct. You can explicitly install ESA if you want but you need to make sure to install a supported version.

I have submitted a PR to esa-token that makes ESA a peerDependency.
Please, one of you agree to change your stance. The two addons are at loggerheads, you disagree, and you both say the other is wrong. All I can do as an app developer is watch and feel sad. And fork my own solution, which is not in the ethos of the Ember community.

I have submitted a PR to esa-token that makes ESA a peerDependency.
Please, one of you agree to change your stance. The two addons are at loggerheads, you disagree, and you both say the other is wrong. All I can do as an app developer is watch and feel sad. And fork my own solution, which is not in the ethos of the Ember community.

Please, one of you agree to change your stance. The two addons are at loggerheads, you disagree, and you both say the other is wrong

What exactly do we disagree on? I don't recall saying ESA was doing anything wrong. I said you were doing something wrong by trying to use a version of ESA that ember-simple-auth-token does not support. I don't see a need for any changes on ESA or ember-simple-auth-token.

Please, one of you agree to change your stance. The two addons are at loggerheads, you disagree, and you both say the other is wrong

What exactly do we disagree on? I don't recall saying ESA was doing anything wrong. I said you were doing something wrong by trying to use a version of ESA that ember-simple-auth-token does not support. I don't see a need for any changes on ESA or ember-simple-auth-token.

Yes. I was not aware that 3.1.0-beta.1 did not match ^3.0.0.

FWIW https://jubianchi.github.io/semver-check/#/^3.0.0/3.1.0-beta.1  disagrees with that statement 🤔

Yes. I was not aware that 3.1.0-beta.1 did not match ^3.0.0.

FWIW https://jubianchi.github.io/semver-check/#/^3.0.0/3.1.0-beta.1  disagrees with that statement 🤔

@Turbo87

FWIW https://jubianchi.github.io/semver-check/#/^3.0.0/3.1.0-beta.1  disagrees with that statement

const semver = require('semver');
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0'); // => false
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0', { includePrerelease: true }); // => true
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0-alpha'); // => false
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0 || ^3.1.0-alpha'); // => true

I would assume that means semver-check is setting includePrerelease to true.

@Turbo87

FWIW https://jubianchi.github.io/semver-check/#/^3.0.0/3.1.0-beta.1  disagrees with that statement

const semver = require('semver');
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0'); // => false
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0', { includePrerelease: true }); // => true
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0-alpha'); // => false
semver.satisfies('3.1.0-beta.1', '^1.6.0 || ^2.0.0 || ^3.0.0 || ^3.1.0-alpha'); // => true

I would assume that means semver-check is setting includePrerelease to true.

Yes. I was not aware that 3.1.0-beta.1 did not match ^3.0.0.

FWIW https://jubianchi.github.io/semver-check/#/^3.0.0/3.1.0-beta.1  disagrees with that statement 🤔

And yarn install disagrees with that website.

Yes. I was not aware that 3.1.0-beta.1 did not match ^3.0.0.

FWIW https://jubianchi.github.io/semver-check/#/^3.0.0/3.1.0-beta.1  disagrees with that statement 🤔

And yarn install disagrees with that website.

What exactly do we disagree on? I don't recall saying ESA was doing anything wrong. I said you were doing something wrong by trying to use a version of ESA that ember-simple-auth-token does not support. I don't see a need for any changes on ESA or ember-simple-auth-token.

ESA is saying you should have ESA as a peerDependency, and the user should install both addons
You are saying that it's wrong to have ESA as a peerDependency, and the user should not install both addons

What exactly do we disagree on? I don't recall saying ESA was doing anything wrong. I said you were doing something wrong by trying to use a version of ESA that ember-simple-auth-token does not support. I don't see a need for any changes on ESA or ember-simple-auth-token.

ESA is saying you should have ESA as a peerDependency, and the user should install both addons
You are saying that it's wrong to have ESA as a peerDependency, and the user should not install both addons

ESA is saying you should have ESA as a peerDependency, and the user should install both addons

I never said that, and I am not ESA. What I said was that it is one alternative possibility.

ESA is saying you should have ESA as a peerDependency, and the user should install both addons

I never said that, and I am not ESA. What I said was that it is one alternative possibility.

You are saying that it's wrong to have ESA as a peerDependency, and the user should not install both addons

I didn't say this was wrong. I said that based on the fact that ESA has historically not been a peer dependency of ember-simple-auth-token, I'm not sure it makes sense to change it

You are saying that it's wrong to have ESA as a peerDependency, and the user should not install both addons

I didn't say this was wrong. I said that based on the fact that ESA has historically not been a peer dependency of ember-simple-auth-token, I'm not sure it makes sense to change it

OK, this is getting silly.
The situation is that anyone following the instructions will end up with a broken app and obscure error messages.
Between these two addons you need to sort out what you're going to do. I've submitted a PR to ember-simple-auth-token which fixes the problem. If you don't like it, come up with something else.
But don't sit there denying there's a problem and saying it doesn't make sense to change anything.
I'm off to do some work on my own code. I'll have to reimplement ESA as it's just been too much hassle coping with the upgrades.

OK, this is getting silly.
The situation is that anyone following the instructions will end up with a broken app and obscure error messages.
Between these two addons you need to sort out what you're going to do. I've submitted a PR to ember-simple-auth-token which fixes the problem. If you don't like it, come up with something else.
But don't sit there denying there's a problem and saying it doesn't make sense to change anything.
I'm off to do some work on my own code. I'll have to reimplement ESA as it's just been too much hassle coping with the upgrades.

@BryanCrotaz I will add a note to the ember-simple-auth-token readme that says that you should let ember-simple-auth-token install ESA or ensure that you are using a version of ESA that is compatible with ember-simple-auth-token,

@BryanCrotaz I will add a note to the ember-simple-auth-token readme that says that you should let ember-simple-auth-token install ESA or ensure that you are using a version of ESA that is compatible with ember-simple-auth-token,

@fenichelar it looks like you're right. yarn-deduplicate does indeed not deduplicate the ESA-token dependency and the explicitly installed ESA beta version.
I guess the only way to resolve this then is using resolutions. I'm not sure if moving to a peer dependency would really fix anything because the version constraints would still be the same. I know that yarn only outputs warnings for broken peer dep constraints though, so that might work, but npm has roughly 4 different ways of dealing with peer deps, so no idea how the situation there works 😅

@fenichelar it looks like you're right. yarn-deduplicate does indeed not deduplicate the ESA-token dependency and the explicitly installed ESA beta version.
I guess the only way to resolve this then is using resolutions. I'm not sure if moving to a peer dependency would really fix anything because the version constraints would still be the same. I know that yarn only outputs warnings for broken peer dep constraints though, so that might work, but npm has roughly 4 different ways of dealing with peer deps, so no idea how the situation there works 😅

@Turbo87  What is the recommended version of ESA to use in production at this time?

@Turbo87  What is the recommended version of ESA to use in production at this time?

I would assume the latest stable release, but I'm not the maintainer of this addon, so I can't say for sure 😅

I would assume the latest stable release, but I'm not the maintainer of this addon, so I can't say for sure 😅


DataRaceSafety.md Define 'Critical Section'?

Hello,
For many readers of this guide, this will be their first real dive into properly thinking about Data Race Safety.
In DataRaceSafety.md in the 'Atomicity' section there are references to 'Critical Sections' but no explanation as to what these are.
Perhaps it's worth a cursory explanation?  Or at least a link out to Wikipedia.

You're right, that would be good to clarify.


How can I configure the two buttons on the right?

Is there a way to assign I don't know some action to them?

The buttons should be standard mouse buttons so you should be able to configure them using software like btnx. Maybe this can help → http://askubuntu.com/questions/19569/how-can-i-assign-actions-to-all-my-mouse-buttons