Error while building Karavan Web Application

System Configurations
Maven home: C:\apache-maven-3.9.6
Java version: 17.0.2, vendor: Oracle Corporation, runtime: C:\jdk-17.0.2
Default locale: en_IN, platform encoding: Cp1252
OS name: "Windows 10", version: "10.0", architecture: "amd64", family: "Windows"

Issue Description
When attempting to build the Karavan web application, the first step involves running the following command:
mvn clean compile exec:java -Dexec.mainClass="org.apache.camel.karavan.generator.KaravanGenerator" -f karavan-generator

Encountered errors:

When executed in the root directory:

When executed in the 'karavan-generator' directory:

Additionally, after attempting to execute:

mvn clean compile, which succeeded
Following with the initial command, resulted in:

The objective is to address these issues and successfully build the Karavan web application.

Update
I just changed the Maven version to 3.5.0 and it's working.
New Issue:
When building the Karavan app as step 3 suggested in this README:
mvn clean package -f karavan-app -Dquarkus.profile=public

I'm getting this error:

Suggestion: Please update the README file and also mention the required version of dependencies.

If you are using Powershell, you will have to add quotes around -D parameters

otherwise, you can try with the command prompt.

@indubabu  yes, I have to use CMD, and there was an error in the instructions in the dev README that I fixed yesterday. Now, the README is also updated.

@Praval791 There is recent change to move the karavan-app out to the root and remove the folder karavan-web, If you take latest it should work as is for with the old readme. Kindly check.


When deleting a target, check to see if it exists first

Currently if it doesn't exist, we will return a 500. This should probably be a 404 (or 200/204).

I can work on it.


L2 projection between two spaces

Hello,
this is my situation: I have two meshes Th1 and Th2, where Th2 is obtained as a submesh of Th1 (for example, using trimmer miniapp).
I have some gridfunction in a L2 space of Th2, and I would like to consider the extension, by 0, of this function to the L2 space of Th1. Any hints of how could I do it?

If somehow you know the map between the element numbers of the two meshes, you can just iterate in Th1 and set the DOF values from Th2.
If Th2 is always a submesh of Th1, you can compute the map simply by comparing physical coordinates of the element centers, e.g., with Mesh::GetElementCenter().
If the correspondence is not known, you can interpolate in physical space with miniapps/gslib/field-interp.cpp. You would interpolate all DOF locations from Th1, and get default_interp_value' (see fem/gslib.hpp`) for the ones not found in Th2.

Ok, thanks. So I have to build "at hand". But, what if my meshes are parallel?

If Th1 and Th2 have different parallel partitions, you should probably use gslib. Otherwise you'll have to communicate the maps yourself.
The gslib methods work in parallel, although our interpolation example is serial. You can get an idea what modifications are needed by looking at miniapps/gslib/pfindpts.cpp.


conditional tags for json_schema

Currently, if I want to serialize only some fields from a serializer(for example for authorization purposes) I do it like this:
module SerializerMixin
  def first_field
    []
  end
end

class CompositeSerializer < Surrealist::Serializer
  include SerializerMixin

  json_schema do
    { first_field: Array, second_field: Hash, third_field: String }
  end

  def second_field
    {}
  end

  def third_field
    "awesome issue"
  end
end

class GuestSerializer < Surrealist::Serializer
  include SerializerMixin

  json_schema do
    { first_field: Array }
  end
end

GuestSerializer.new(object).build_schema

I think it would be great, if we can use one serializer with different json schemas
class CompositeSerializer < Surrealist::Serializer
  json_schema do
    { first_field: Array, second_field: Hash, third_field: String }
  end

  json_schema(:guest_user) do
    { first_field: Array }
  end

  def first_field
    []
  end

  def second_field
    {}
  end

  def third_field
    "awesome issue"
  end
end

CompositeSerializer.new(object).build_schema(:guest_user)

Looks good to me. @AlessandroMinali @nulldef what do you think?

I think it is useless feature, 'cause we already have multiple serializers and this case can be solved via inheritance.

Yeah, I guess @nulldef is right about this. Placing different schemas in one class can lead to creating a god-object and introduce difficulties in supporting and changing it later on. Closing this for now, but thanks for proposal, @briu


fix: patch karma to allow loading virtual packages

Fixes #3530

@googlebot I signed it!

:white_check_mark: Build karma 2707 completed (commit https://github.com/karma-runner/karma/commit/f59ad662fb by @snasirca)

:white_check_mark: Build karma 2708 completed (commit https://github.com/karma-runner/karma/commit/693d0326da by @snasirca)

What would be the best way to add regression coverage to this change?

Thanks for fixing this!
A unit test with the problematic path similar to this should be enough.

I just ran into this issue yesterday and would like to get this merged as soon a possible. I can write the unit test if needed.

@acls @devoto13 I've added test coverage. Can you check if this is sufficient?

:white_check_mark: Build karma 2712 completed (commit https://github.com/karma-runner/karma/commit/fa250594dc by @snasirca)

:white_check_mark: Build karma 2713 completed (commit https://github.com/karma-runner/karma/commit/d95e16971b by @snasirca)

@devoto13 can you review this?

@snasirca wondering about the status of this. I'm running into the same issue and found this potential fix.

@snasirca wondering about the status of this. I'm running into the same issue and found this potential fix.

Sorry about the delay. This hasn't dropped off of radar. I'm on vacation and back by September 20. That'll be the earliest I can address the code review feedback.

@snasirca Thank you for the hard work. I can confirm this is working for our project.

This fix was subsequently merged in #3663


Change build task description to use label

In vscode 1.18 taskName was deprecated in favor of label.
This updates the generated description to comply with that update.
https://code.visualstudio.com/updates/v1_18#_schema-improvements

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: natec425 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@dotnet-bot test this please


Enabling access for SharePoint online

Thank you - both MS and Google documentation have changed since this was written but it is a good enough approximation.
I am not able to make this work for SharePoint Online: mydomain.sharepoint.com - the gmail user is returned to the choice between a Microsoft or Organisation account. Can anyone help?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6ed01893-a5cd-28bd-b865-e7ebe5870567
Version Independent ID: b3d96be0-1470-eb2c-ea5b-cea0a5cc44a1
Content: Add Google as an identity provider for B2B - Azure AD
Content Source: articles/active-directory/b2b/google-federation.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

@carolchiz , Thanks for raising the issue. We will investigate and update you.

@carolchiz what do you mean you're not able to get this to work on sharepoint online? It should be redirecting to the login.microsoftonline.com endpoint? Or is this a sharepoint hosted authentication?
Note that sharepoint online and aad b2b are different see : https://docs.microsoft.com/en-us/azure/active-directory/b2b/o365-external-user

Thank you - my problem is with SharePoint Online AND invitations from Azure (B2B). I want to create the users in the Azure AD, possibly in bulk, ie populate before inviting, and use the Azure AD conditional access and other features.
The SPO and OneDrive is great for individual users, but we don't really want that level of freedom especially on SharePoint Online.
I had two issues yesterday - invitations not getting delivered and then getting stuck on the Microsoft authentication screen rather than the Google one.
I noticed Google seemed to have some issues yesterday, I will test again today

It sounds like it's specific only to the aad b2b invitations? @carolchiz It sounds like there's no issues with the SPO and AAD BB part?

hey @carolchiz  i'm following up on this issue, can you please clarify/answer the question asked? In regards to bulk inviting there's a preview feature here : https://docs.microsoft.com/en-us/azure/active-directory/b2b/tutorial-bulk-invite
If there's no response in regards to this issue by end of day today I'll be closing this issue out, please engage via Q&A forums for more technical help as these github isseus are meant for issues with the docs. https://docs.microsoft.com/answers/index.html

It is not a problem with bulk invite. Her we go with screen shots. This is the invite from SPO to Gmail.
First I invite an external user to the site

I get my copy of the invitation

the gmail account does not get an invitation

I forward my copy

which is delivered to gmail

Wen (logged in as the gmail user) I click on the link I go to the standard MS login screen

Of course I cannot connect as this gmail account is only a gmail account not a MS one.

Google is configured in my Azure AD

Same issue using Azure to invite them

AH brilliant - this has decided to work now..

Now I will figure out how to invite this user to SPO:

@carolchiz - sorry to resurrect this issue, but were you able to figure out how to get this to work with SharePoint Online invitations? I am in the same boat and have it working from an Azure AD invitation, but not from a SPO invite. The problem with using the Azure AD invite is that it does not redirect the user to the SPO site, which is what we are trying to give access to.


libcamera: 2022-07-15 -> 2022-09-15

Description of changes
Fixes pipewire 0.3.57 build
Commit log: https://git.libcamera.org/libcamera/libcamera.git/log/
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Unfortunately trying to test rebuilding packages didn't work: I don't have enough disk space.

Closing since this is already in staging.


Support codeload.github.com

For adobe/project-helix#101 I need to get full snapshots of the Git Repository at a certain revision.
I assume that downloading the tarball from GitHub will be faster than cloning the entire repository (especially given that I will discard the download afterwards), which means we need to reverse-engineer the "Download ZIP" functionality.
For instance, clicking "Download ZIP" will open this URL https://github.com/adobe/parcel-plugin-htl/archive/master.zip which then 302s to https://codeload.github.com/adobe/parcel-plugin-htl/zip/master
master can in both cases be replaced with a ref identifier.

will support both (official and unofficial) endpoints that redirect:

https://api.github.com/repos/adobe/parcel-plugin-htl/zipball/master (official, rate limited, redirects)
https://github.com/adobe/parcel-plugin-htl/archive/master.zip (unofficial, not rate limited, redirects)
as well as the target endpoint:
https://codeload.github.com/adobe/parcel-plugin-htl/zip/master (unofficial, not rate limited, doesn't redirect)

related discussions:
https://github.com/composer/composer/pull/4737#issuecomment-167802243
https://github.com/hirak/prestissimo/issues/65#issuecomment-192899060

implemented in 3f6c72b2ba44aba05e41e6a29c7f202d36073e16


NEXT-35968 - Fix OpenApi Schema validation

1. Why is this change necessary?

Currently the github workflow for the OpenApi Schema validation fails because it's not setup correctly
Also the action fails because a few api specs in the core a wrong

2. What does this change do, exactly?

Changed 01-lint-openapi to run correctly & cache composer files
Changed CalculatedPrice API Schema to correctly use oneOf with null
Changed Product API Schema to correctly use oneOf with null
Changed ReferencePrice API Schema to correctly use oneOf with null

3. Describe each step to reproduce the issue or behaviour.

Run the OpenApi Schema validation github action

4. Please link to the relevant issues (if any).

/

5. Checklist

[X] I have rebased my changes to remove merge conflicts
[X] I have written tests and verified that they fail without my change
[X] I have created a changelog file with all necessary information about my changes
[X] I have written or adjusted the documentation according to my changes
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

@philipreinken I fixed the GitHub action to correctly run and changed it to match the structure of the other actions.

@mkucmus, can you please validate the changes made to OpenAPI Schema? Thx.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: akf-bw:x: mkucmusYou have signed the CLA already but the status is still pending? Let us recheck it.

Your merge request has been merged @akf-bw 🎉  , thanks for your contribution.


Genrate Playlist feature

Can you please add feature to genrate JioTV playlist for tivimate or any other IPTV player.

it is not possible as its a addon designed for kodi ... if u r looking for m3u jiotv playlist file i dont think it will available here

Thanks for your comment 👍


Typo in Logix Wizard popup

I noticed a typo in the Logix Wizzard popup "answear" instead of "answer".

I also wanted to use this issue as a chance to recommend you don't push an AI LLM for PLC programming help. Since they are inherently unreliable, I feel it sets a bad precedent for any newcomers using the app.

LLMs for PLCs are unreliable because there is not enough data online to train them properly. This is why I'm working on a fine-tuned GPT model so that we can all use these incredible tools in our PLC world. :)


test(travis): Fix for missing package that is causing Cypress to fail…

… to load

https://github.com/cypress-io/cypress/issues/4069


feat: add api integration for fetching status

Portal PR Checklist
Pre-requisites

[x] I have gone through the Contributing guidelines for Submitting a Pull Request (PR) and ensured that this is not a duplicate PR.
[x] I have performed preliminary testing to ensure that any existing features are not impacted and any new features are working as expected.

PR Details
PR details have been updated as per the given format (see below)

[x] PR title adheres to the format specified in guidelines (e.g., feat: add admin login page)
[x] Description has been added
[x] Related changes have been added (optional)
[x] Screenshots have been added (optional)
[ ] Pending actions have been added (optional)
[x] Any other additional notes have been added (optional)

Additional Information

[x] Appropriate label(s) have been added (ready for review should be added if the PR is ready to be reviewed)
[x] Assignee(s) and reviewer(s) have been added (optional)

Description:
added api integration for fetching status
Related changes:

created graphql module
added file service for calling api
added environments file
did necessary changes in file-processor component
added some dependencies in package.json

Screenshots:

https://github.com/OsmosysSoftware/osm-transcript-summarizer/assets/168435416/6067b9e4-b9d0-4ec7-ab9f-826f8252a580
Pending actions:
N/A
Additional notes:
Currently, the file upload API is not integrated, so I have hardcoded the job ID array for now and checked whether we are receiving a response or not (I uploaded the file using Postman). Will do it via local storage once file upload api is integrated.

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Introduced GraphQL functionality for enhanced file processing capabilities.
Implemented Apollo Client setup for efficient data operations.

Updates

Updated dependencies for better compatibility and performance.
Adjusted resource budget limits for improved application performance.

Bug Fixes

Integrated a new method in the file service to address issues with fetching summaries.

Documentation

Added detailed documentation for handling GraphQL endpoints in various environments.

@Hitesh-Kandpal  Check Code Rabbit comments to and resolve if its needed.

@xixas
https://github.com/OsmosysSoftware/osm-transcript-summarizer/assets/168435416/c114d070-f65d-4f86-8fd1-3df95d590a7a
also for markdown file we are getting NULL in output text, so for now should I create a blob for markdown file?


Messes up Web app when building nextjs for the second time

It works as it should the first time I use
npm run dev
npm run start

to build the Next.js production build. But the second time I run the same commands, it messes up the entire website. Any way to fix this?

Yes, I found this problem too.
Currently my plugin has some issues with server side render frameworks like nextjs, I'm looking for the cause and trying to fix it. A single page application should be fine.

Thanks. Would really appreciate a fix. Its a great plugin and does its work wonderfully.

Hi<EMAIL_ADDRESS>is release, This version has fixed this issue. Have a try! :)

Thanks. Will try it out.

After patching @tailwindcss/mangle to work properly with Next.js v14.2.7 using this patch, it's not emitting the new classes but the HTML got rewritten.


app.quicktype and blog down

I tried accessing it today and they seem to have gone away.

Working on my side for app.quicktype

Seems to be up again!


Emby Server install broken

The problem
When I try to install emby-server I get the following error message:
"Invalid option or feature not implemented yet."
This happen either by using the GUI or command line:

sudo bash setup.sh -i emby-server

Workaround
Edited "emby-server-repository-configurator.sh" and added 'artful' codename next to 'zesty' (Ubuntu 17.04)
My Linux distribution and version is: Ubuntu Desktop 17.10
I'm seeing this behaviour on:  A fresh install
I'm not a dummy, so I've checked these!

I'm using the latest version of AtoMiC-ToolKit.
All my Linux distro packages are up to date and I don't see any errors while updating.
I've checked there are no current open issues relating to my problem!

Hi,
I'll get this fixed over the next few days.
Thanks for your time and investigation work!
Tom
If you want to discuss anything with me please don't hesitate to contact me on Gitter.
Don't forget to vote for new features on Feathub and help drive the focus of AtoMiC-ToolKit!


feat: support other audio format

Goals:
This PR is related to issue #998

[x] refactor load() method in AudioUrl to use PyDub
[x] remove useless code
[x] pass current tests
[x] add tests for other format

I added the function save_to_audio_file. During the development, I found the frame_rate of an audio file is essential, so I added an variable frame_rate for class Audio. So now it is
audio = Audio(
    url='https://github.com/docarray/docarray/blob/feat-rewrite-v2/tests/toydata/hello.wav?raw=true'
)
audio.tensor, audio.frame_rate = audio.url.load()

just like in video we have
vid.audio.tensor, vid.tensor, vid.key_frame_indices = vid.url.load()

It may not be very compact. Maybe I can wrap the return to a class like VideoLoadResult.

* simply have a huge-ass list of all supported file extensions, move it to a different file if needed
* if a path has an extension and it is not in that list, then fail
* if a path does not have an extension, pass

I like this tradeoff.
The goal of validation is mostly to catch if someone put an file.png instead of a file.wav.


SCSS compilation error when consuming enketo-core from Vite project

Describe the bug
When consuming the enketo-core SCSS using Vite, I get an import issue from
https://github.com/enketo/enketo/blob/15e164eabec6d49319eb720e28470ed854f6dfdc/packages/enketo-core/src/widget/date/datepicker-extended.scss#L1

[vite:css] [sass] Can't find stylesheet to import.

The reason for this is that the file assumes it is always in /packages/enketo-core (in the monorepo) but if you obtained the SCSS using npm install enketo-core --save then that path does not exist.
To Reproduce

Create a Vite project using npm create vite@latest
Add enketo-core and sass as dependencies to package.json
Run npm install and npm run dev
Add <link rel="stylesheet" href="/node_modules/enketo-core/src/sass/plain/plain.scss" /> to your index.html

Expected behavior
No SCSS compilation error when consuming enketo-core
Screenshots

Thanks for filing this issue and sorry about that! If you'd like to put in a PR to fix, that would be appreciated, otherwise we'll try to get to it soon.

A fix might cause problems in the monorepo, but it would of course be great if it is possible for this to remain a relative URL instead of referring to monorepo file structure. Presumably this is not feasible.
Fwiw, a workaround that can be used with node-sass is to pass an importer function like this:
 importer: (url) => {
                    const TARGET = '/packages/enketo-core';
                    const REPLACEMENT = './node_modules/enketo-core';
                    if (!url.startsWith(TARGET)) {
                        return null;
                    }

                    const repl = url.replace(TARGET, REPLACEMENT);
                    return {
                        file: path.resolve(__dirname, repl),
                    };
                },

After thinking about it and actually trying to fix it, since that import path is correct, within the monorepo structure, if one wants to consume enketo-core with Vite, you could tell your Vite config to resolve that path to your node_modules directory using alias.
resolve: {
    alias: [
        {
            find: "/packages/enketo-core/node_modules",
            replacement: resolve(__dirname, "node_modules"),
        }
    ]
}

If that works for your needs, I agree we can close. Thanks!

I support that, I don't think there's anything to fix here.

Thanks for digging deeper, @sergioestevess!


Updating existing unique index will create a new unique index

Bug description
If you have a model with an existing unique index, and you update the unique index fields it will generate a new index in the migration without removing the existing one. Resulting in two unique indexes.
I would expect the existing index to be removed before the new one is created.
How to reproduce

Create an example model with a unique index
model SomeModel {
  id                             String    @id(map: "some_table_new_pk") @db.Uuid
  someCol                 String     @db.VarChar(4)
  someOtherCol       String     @db.VarChar(4)

  @@unique([id, someCol])
  @@map("some_table")
}

Generate a migration for the above.

If you then go and add a column into the unique index:
model SomeModel {
  id                             String    @id(map: "some_table_new_pk") @db.Uuid
  someCol                 String     @db.VarChar(4)
  someOtherCol       String     @db.VarChar(4)

  @@unique([id, someCol, someOtherCol])
  @@map("some_table")
}

Generating a another migration will create a new index, without deleting the older index. Resulting in two unique indexes (one with [id, someCol] and another with [id, someCol, someOtherCol])

Expected behavior
The migration would either:

Remove the existing unique index before creating a new one
Update the existing unique index

Prisma information
model SomeModel {
  id                             String    @id(map: "some_table_new_pk") @db.Uuid
  someCol                 String     @db.VarChar(4)
  someOtherCol       String     @db.VarChar(4)

  @@unique([id, someCol])
  @@map("some_table")
}

Environment & setup

OS: macOS
Database: PostgreSQL
Node.js version: 16

Prisma Version
    "@prisma/client": "^4.11.0",
    "@prisma/instrumentation": "~4.10.1",
    "prisma": "^4.11.0",

I can not reproduce this with Prisma 4.110 or the newest 5.0.0. I get a migration that both drops the original index, and then creates a new one:
/*
  Warnings:

  - A unique constraint covering the columns `[id,someCol,someOtherCol]` on the table `some_table` will be added. If there are existing duplicate values, this will fail.

*/
-- DropIndex
DROP INDEX "some_table_id_someCol_key";

-- CreateIndex
CREATE UNIQUE INDEX "some_table_id_someCol_someOtherCol_key" ON "some_table"("id", "someCol", "someOtherCol");

What am I missing?


When mounting Lookbook in another Rails Engine, asset paths and layouts don't always work

Describe the bug
First off, just wanted to say that this project is amazing! Really glad I found it before committing to another Storybook project.
I'm creating a component library as a mountable Rails engine, so that it's completely isolated, and that engine mounts Lookbook:
Main app
  \
  Component Library (mounted)
    \
    Lookbook (mounted)

This makes the component library isolated and portable, so any project that wants to use it can also optionally mount a Lookbook app.
I've run into a couple of issues related to asset paths, where Lookbook is only checking the main app's app/* instead of my_engine/app/*:

Preview paths — This was easy to fix, because lookbook provides config.lookbook.preview_paths, so I'm able to pass it the full path like this: config.lookbook.preview_paths = [MyEngine::Engine.root.join("app/components").to_s]. Maybe a little unintuitive, but that works just fine.
Layouts — When specifying a layout, either individually or via config.lookbook.preview_layout, I'm seeing this:

ActionView::MissingTemplate

The error is helpful in that it shows which directories it searched in. It's showing my main app's app/views as well as lookbook-2.0.0.beta.4/app/views, but not my engine's app/views, where I want the preview layout to live.
To Reproduce
I don't have an easy repro, but if my explanation doesn't make sense I can make one.
Expected behavior
Lookbook should look for assets in the context it was mounted in, not necessarily (or in addition to) the root application. If this isn't possible automatically, maybe we could add a config option to point to the right directory.
Version numbers
Please complete the following information:

Lookbook: 2.0.0.beta.4
ViewComponent: 2.82.0
Rails: <IP_ADDRESS>
Ruby: 3.2.1

Additional context
I monkey patched Lookbook::PreviewActions as a temp fix. Here's what I did:
# lib/preview_actions.rb
module PreviewActions
  def render_in_layout_to_string(template, locals, opts = {})
    append_view_path MyEngine::Engine.root.join("app/views") # <~ This is what I needed to change

    with_optional_action_view_annotations do
      html = render_to_string(template, locals: locals, **determine_layout(opts[:layout]))
      if opts[:append_html].present?
        html += opts[:append_html]
      end
      render html: html
    end
  end
end

# lib/my_engine.rb
require "preview_actions"

# lib/my_engine/engine.rb
config.after_initialize do
  config.view_component.preview_controller.constantize.class_eval { prepend PreviewActions }
end

Not pretty, but it does fix the issue. Maybe there should be a new config option, like config.lookbook.layout_paths? Also possible that I'm missing something obvious and just going about this all wrong 😄 . Thanks in advance!

Hey @ksweetie thanks for this! It may not be possible to figure out the preview paths automatically (the preview_paths config option is for exactly this use case as you have correctly figured out) but once that path is supplied I'm sure that I can get the layouts working without further configuration.
I'll take a look at it when I have a chance and let you know when I've got a fix.
Thanks for bringing to my attention and I'm glad you've been enjoying using it so far :-)

@ksweetie okay so this is proving to be a little trickier than I thought to find a good generic solution to 🙂
Adding another config option for specifying view paths is definitely a possibility, but I'd rather not if I can avoid it as it's another thing to document and test - and this is a bit of an niche use case (although I very much like the idea!).
A cleaner way to work around the layout issue would probably be to specify a custom preview controller:
config.lookbook.preview_controller = "MyPreviewController"

And then in the preview controller prepend your engine's views directory:
class MyPreviewController < Lookbook::PreviewController
  prepend_view_path MyEngine::Engine.root.join("app/views")
end

Can you give that a try and see if it allows you to remove the monkey patch? If so I will probably add this as an example to the documentation rather than adding another config option.
Let me know how you get on!

Yay, that worked! 🎉  That's way cleaner, and I agree, I'd rather not have another config option.
A separate piece of feedback: I tried unsuccessfully last week to set a custom preview controller, but I was looking at the configuration page, which only shows config.lookbook.preview_controller. I see now that the view component page documents that there's a separate view component preview_controller, but I didn't notice it there when looking at the preview controller documentation. Maybe it's worth duplicating on the configuration page where you can use either? Or maybe I need to read the manual more closely.  😄
Thanks for the speedy help, I really appreciate it!

@ksweetie excellent! Glad that fixed it. And yes you are right - the duplication of the ViewComponent config is unfortunately a bit confusing and should definitely be documented better. I'll add a note to improve that. Ideally setting either would work both ways (for Lookbook and ViewComponent) but that is a bit tricky... may be worth revisiting though.
I'll close this issue down now then but if you run into any other issues just let me know 🙂

@ksweetie We have a similar setup but my Rails Engine knowledge is not very broad. Would you be willing to share an example config of how you had this setup functioning so you could load the mounted engine's Lookbook in the "main app"?
I've tried several things but am only able to get things functioning and accessible in the mountable engine/gem's context and not in the main app that loads the engine.
Thanks for your help.

@fredboyle Unfortunately, I de-converted our component library from an engine and put it into a namespaced service inside our main app. There were just issues at every turn and I felt like I was going against the grain. That said, I did have Lookbook working. I'm not sure how to help without more info of what error/issue you're seeing though. I can say that you need to register routes in both places:
# main app routes.rb
mount YourEngine::Engine, at: "/lookbook"

# engine's routes.rb
YourEngine::Engine.routes.draw do
  mount Lookbook::Engine, at: "/"
end

@ksweetie Thanks for the response. Figured the routes thing. My issue is mostly around having Lookbook not cause issues in the main/host app when loading the engine.
Currently I have Lookbook in my engine's gemspec file as a dev dependency, then I require it in the engine.rb file. This functions fine in the engine repo.
However after these changes, adding the engine in the main/host app, doing a bundle install, then trying to start the Rails server, it errors out due to being unable to locate Lookbook.
Any hints or guidance compared to how you had it when it was functioning for you?
Do you have a git commit you could provide me a snapshot of your engine configuration from when it was an engine?

Sorry, I don't have anything open source I can share.
Did you try adding Lookbook as a regular dependency? This was from my original commit:
  spec.add_dependency "lookbook", ">= 2.0.0.beta"
  spec.add_dependency "rails", rails_version
  spec.add_dependency "sprockets-rails", "~> 3.4.0"
  spec.add_dependency "view_component", ">= 2.82.0"

  # Live reloading in Lookbook
  spec.add_development_dependency "actioncable", rails_version
  spec.add_development_dependency "listen", "~> 3.8"

# engines/your_engine/lib/your_engine.rb
require "your_engine/version"

module YourEngine
end

require "lookbook"
require "your_engine/engine"

@ksweetie Thanks for the info. I'll dig into it and see.
Was trying to avoid having a runtime dependency and only have a development dependency since that's the only time it's needed. Experimentation will tell.
Thanks again for the info and being willing to help me figure it out.


fix: Ping event stream for REST client

[SDK] fix restClient.GetEventStream close channel, preventing it to panic if something went wrong during the round process.
[application] do not set lastEvent to nil when the registration starts. It allows the REST client to get the previous RoundFinalized event.

@altafan please review

Closing in favor of #341


chore(deps): upgrade jx-pipeline

for https://github.com/jenkins-x-plugins/jx-pipeline/pull/381
to fix https://github.com/jenkins-x-plugins/jx-build-controller/issues/30
now, the build logs should be working nicely, without duplicated logs or missing logs

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign vbehar
You can assign the PR to them by writing /assign @vbehar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vbehar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [vbehar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Error 500 sending images

Hi
I am trying to send images but I get an error 500.
It worked fine for a while and now I suddenly got this error.
Text-only messages are working well.
I have installed the latest version of WAHA plus.
This is my API call body:
{
  "session": "sessionName",
  "chatId"<EMAIL_ADDRESS>  "file": {
    "mimetype": "image/jpeg",
    "url": "https://www.example.it/Thumbnail.jpg",
    "filename": "Thumbnail.jpg"
  },
  "caption": "This is the caption text..."
}

And this is the answer:
{
  "statusCode": 500,
  "timestamp": "2023-03-20T15:51:12.879Z",
  "exception": {
    "stack": "Error: Evaluation failed: TypeError: window.Store.MediaPrep.prepRawMedia is not a function\n    at window.WWebJS.processMediaData (__puppeteer_evaluation_script__:235:50)\n    at async window.WWebJS.sendMessage (__puppeteer_evaluation_script__:19:19)\n    at async __puppeteer_evaluation_script__:10:25\n    at ExecutionContext._evaluateInternal (/app/node_modules/whatsapp-web.js/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:221:19)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async ExecutionContext.evaluate (/app/node_modules/whatsapp-web.js/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:110:16)\n    at async Client.sendMessage (/app/node_modules/whatsapp-web.js/src/Client.js:686:28)\n    at async /app/node_modules/@nestjs/core/router/router-execution-context.js:46:28\n    at async /app/node_modules/@nestjs/core/router/router-proxy.js:9:17",
    "message": "Evaluation failed: TypeError: window.Store.MediaPrep.prepRawMedia is not a function\n    at window.WWebJS.processMediaData (__puppeteer_evaluation_script__:235:50)\n    at async window.WWebJS.sendMessage (__puppeteer_evaluation_script__:19:19)\n    at async __puppeteer_evaluation_script__:10:25",
    "name": "Error"
  },
  "request": {
    "path": "/api/sendImage",
    "method": "POST",
    "body": {
      "session": "sessionName",
      "chatId"<EMAIL_ADDRESS>      "file": {
        "mimetype": "image/jpeg",
        "url": "https://www.example.it/Thumbnail.jpg",
        "filename": "Thumbnail.jpg"
      },
      "caption": "This is the caption text..."
    },
    "query": {}
  },
  "version": {
    "version": "2023.3.1",
    "tier": "PLUS",
    "browser": "/usr/bin/chromium"
  }
}

Thanks for your help

Hi! Fixed in the latest version today, 2023.3.22, please pull it and try again!


[WIP] Manually 'Rebase with History' and Reapply #5

[x] Have you followed the guidelines in our Contributing document?

[x] Have you checked to ensure there aren't other open Pull Requests for the same change?

[x] Have you added an explanation of what your changes do and why you'd like us to include them?  (Yes, in my commit messages.)

[ ] Have you written new tests for your changes?  Here's an example.

[ ] Have you successfully run 'brew style' with your changes locally?
(I may do this later, but, since it isn't yet possible to run 'brew style' using our copy of 'brew,' this would entail me pushing copies my commits over to my local copy of upstream's repository, running 'brew style,' then applying any recommendations in this temporary local upstream branch and pushing them back over to this branch.)

[ ] Have you successfully run 'brew tests' with your changes locally?
(I may do this later, but, since it isn't yet possible to run 'brew tests' using our copy of 'brew,' this would entail me pushing copies my commits over to my local copy of upstream's repository, running 'brew style,' then applying any recommendations in this temporary local upstream branch and pushing them back over to this branch.)

[x] Have you successfully run 'brew man' locally and committed any changes?

     Adapts #5 to account for upstream changes in argument parsing.  (Don't worry, this PR won't stay nearly as big once I've publicly rebased our other branches on top of upstream.)

@portage-brew/core-collaborators:
     This is now ready to review.

     Rebased on top of upstream release v2.5.10.

     So I realized that my last rebase attempt actually dropped my changes on the floor.  I've recovered them from my reflog now.  Apparently 'git rebase -i --rebase=merges' doesn't like it when you stuck new changes into a merge commit, preferring empty merge commits.  I thus split the relevant changes out into their own commit.

     Rebased against upstream stable release v2.5.11.  (Note that I'm just going to implicitly keep this rebased against upstream's latest stable release from now on.)

     (Never mind, I decided it might well be a better idea to leave behind a more explicit breadcrumb trail with regard to when I've rebased and against what upstream release.)  Rebased against upstream stable release v2.5.12.

     Rebased against upstream stable release v2.6.0.

     Rebased against upstream stable release v2.6.1.

     Rebased against upstream stable release v2.6.2.

     Rebased against upstream stable release v2.7.0.

     Rebased against upstream stable release v2.7.1.

     Rebased against upstream stable release v2.7.2.

     Rebased against upstream stable release v2.7.2.

      Rebased against upstream stable release v2.7.5.

      Rebased against upstream stable release v2.7.5.

     Rebased against upstream release v2.7.7.

     Rebased against upstream release v2.7.7.

     Rebased against upstream release v3.0.0.

     Rebased against upstream release v3.0.1.

     Rebased against upstream release v3.0.1.

     Rebased against upstream release v3.0.2.

     Rebased against upstream release v3.0.4.

     Rebased against upstream release v3.0.4.

     Rebased against upstream release v3.0.5.

     Rebased against upstream release v3.0.11.

     Rebased on upstream release v3.1.3.

     Rebased on upstream release v3.1.5.

     Rebased against upstream release v3.1.7.

     Rebased against upstream release v3.1.8.

     Rebased against upstream release v3.1.9.

     Rebased against upstream release v3.1.12.

     Rebased against upstream release v3.2.0.

     Rebased against upstream release v3.2.2.

     Rebased against upstream release v3.2.6.

     Rebased against upstream release v3.2.8.

     Rebased against upstream release v3.2.12.

     Rebased against upstream release v3.3.6.


⚠ Bofrost.at has degraded performance

In ef2f685, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2696 ms

Resolved: Bofrost.at performance has improved in 95d0996.


Source Maps does not works with Flutter Web

Environment
Flutter SDK version
 "flutterSdkVersion": "3.0.5"
sentry_dart_plugin version:
sentry_dart_plugin: ^1.0.0-beta.1
stdout: > Found 3631 release files
> Analyzing 3631 sources
> Rewriting sources
> Adding source map references
> Bundled 3631 files for upload
> Uploaded release files to Sentry
> File upload complete (processing pending on server)
> Organization: novade
> Project: novade
> Release<EMAIL_ADDRESS>> Dist: 63

Steps to Reproduce

Build the project for web.
Setup pubspec config as following

sentry:
  upload_source_maps: true

Run flutter flutter packages pub run sentry_dart_plugin

Expected Result
We were using sentry-cli to upload source map previously and it also didn't work. We were asked to try this new plugin and seem it also doesn't work.

Actual Result
Source maps should setup correctly.

@chathu-novade The screenshot is about the source maps of the Dart SDK itself and not your App's code.
Do you see your App's code symbolicated? that should work OOTB.

This is what the stack looks like. Can not see the anything related to app code.

The hidden source section of the screenshot looks like the following.
source: https://domain.tld/hostedtoolcache/Flutter/3.0.5/macos/flutter/.pub-cache/hosted/pub.dartlang.org/sentry-6.9.1/lib/src/sentry_client.dart

I don't follow, the screenshot below has the symbolicated stack trace, it's not minified, what's the problem you are having? can you please update the issue description with more details?

@marandaneto I can not see any stack trace related my my dart code in the flutter project. It show only minified:e4b and exception but not the line of dart code.

@chathu-novade can you provide the code snippet of the Sentry SDK init?
Can you provide the full config of the sentry plugin?
Can you provide the command line you are using to build your Flutter app?

Sentry SDK init
 await SentryFlutter.init(
      (options) {
        options
          ..environment = env.toStr()
          ..release = sentryRelease // from String.fromEnvironment('SENTRY_RELEASE')
          ..dsn = dsn;
      },
      // Init your App.
      appRunner: () => runApp(const _App()),
    );

Sentry plugin config
sentry:
  upload_source_maps: true

Flutter build command
flutter build web --dart-define=SENTRY_RELEASE=$(SENTRY_RELEASE) --dart-define=AMPLITUDE_API_KEY=$(AMPLITUDE_API_KEY) -t lib/web/main.staging.dart --web-renderer canvaskit --source-maps --dart-define=BROWSER_IMAGE_DECODING_ENABLED=false

@chathu-novade release and dist should match when initing the SDK and uploading source maps.
I see that you don't set the dist at least, do they match?
Can you provide a link to an Sentry's issue?

@chathu-novade you probably need --release in your build command line as well.

dist is default so it get build in build/web which also the default of this plugin.

@marandaneto
https:
//sentry.io/organizations/novade/issues/
3543519896/
?project=1770595

The flutter mobile builds works well Issue is with the web build

@chathu-novade I don't see any problem with your errors, its symbolicated correctly.
The issue title is minified:e2b because of https://docs.sentry.io/platforms/flutter/troubleshooting/#known-limitations
See runtimeType.
You are likely calling captureException with an object that is not an exception and its stringified, so there's no problem with symbolication.
Can you clarify the problem?

@chathu-novade you probably need --release in your build command line as well.

--release                          Build a release version of your app (default mode).

@chathu-novade that's already answered here https://github.com/getsentry/sentry-dart-plugin/issues/38#issuecomment-1231230647
If you don't see any frame from your own App, the reason is here https://github.com/getsentry/sentry-dart-plugin/issues/38#issuecomment-1231659696
So I guess that's all from my side unless you provide more context around my questions.

About

The issue title is minified:e2b because of https://docs.sentry.io/platforms/flutter/troubleshooting/#known-limitations
See runtimeType.

Does this applicable to the web too?
web
Obfuscation is not supported for web apps, but a web app can be minified, which is similar. When you build a release version of a Flutter web app, it is automatically minified. For more information, see Build and release a web app.
Is there sentry can

Please raise an issue on https://github.com/getsentry/sentry-dart and provide a minimal reproducible example (this is required), it's unclear what's the problem here since the linked event just works, without more context, we can't help.

https
://sentry.io/organizations/novade/issues/
3510915187/events/
bcaba367a7e74e92b0f7258900827d9a/

Check this issue and expand the stackstrace. We can not see which file threw the exception and not usable stack trace.


Abide Required Email & Password Always Invalid

Similar to this issue,  https://github.com/zurb/foundation-sites/issues/7304, required email and password fields are always invalid.
There's also a small syntax error with the Abide Error State example on the site. The is-invalid-input is in the type attribute, not the class

Have the same problem. Always invalid on email.
<input autocomplete="on" id="fields-emailAddress" name="fields[emailAddress]" placeholder="Email" type="email" value="" required>

fix for password input => #7300
example working of email input: <input type="text" pattern="email" placeholder="Email" id="Email" aria-describedby="registerEmail" required="">

Should be fixed with #7590, please comment and submit pr's to the abide branch until 6.1 release.


Add support for form data for put and post requests

i.e. to update channel information like status and game
the twitch api responded with "Bad Request Missing required parameter channel" when trying to use the options object for form data

This looks good, thanks!
Sorry for the delayed response. I saw this first thing in the morning yesterday then promptly forgot about it!

Wow, thanks, i didn't think this would be integrated that quick.
You might need to adjust the docs 'cause this is an api-breaker i guess :)


Read the extension package create scenario from the api specification

Purpose
If the request has the following format {"package" => "@[PACKAGE_PATH]"}, treat it as a file parameter.
Changes

api_specification file with a valid request for the extension_packages.create scenario
update create.md as to use the api specification scenario

Caveats
Additional helpful information

Haven't seen movement on this. Closing for now.


feat: add regex testing tool

Type of Pull Request

[ ] Bug fix
[x] Enhancement

Related Issue #s or links (if any): #9
Description of Changes
This PR adds a Regex testing tool:

Also just FYI @dlford I think you are missing a key here, I'm getting this warning on my console:
Warning: Each child in a list should have a unique "key" prop. See https://reactjs.org/link/warning-keys for more information.
    at a
    at Layout (webpack-internal:///./components/Layout.tsx:124:19)
    at IndexPage
    at InnerThemeProvider (/workspaces/developertools.tech/node_modules/@mui/system/ThemeProvider/ThemeProvider.js:29:39)
    at ThemeProvider (/workspaces/developertools.tech/node_modules/@mui/private-theming/node/ThemeProvider/ThemeProvider.js:55:5)
    at ThemeProvider (/workspaces/developertools.tech/node_modules/@mui/system/ThemeProvider/ThemeProvider.js:49:5)
    at MyApp (webpack-internal:///./pages/_app.tsx:39:13)
    at StyleRegistry (/workspaces/developertools.tech/node_modules/next/dist/styled-jsx/dist/index/index.js:671:34)
    at AppContainer (/workspaces/developertools.tech/node_modules/next/dist/server/render.js:280:29)
    at AppContainerWithIsomorphicFiberStructure (/workspaces/developertools.tech/node_modules/next/dist/server/render.js:309:57)
    at div
    at Body (/workspaces/developertools.tech/node_modules/next/dist/server/render.js:596:21)

Also just FYI @dlford I think you are missing a key here, I'm getting this warning on my console:
Warning: Each child in a list should have a unique "key" prop. See https://reactjs.org/link/warning-keys for more information.
    at a
    at Layout (webpack-internal:///./components/Layout.tsx:124:19)
    at IndexPage
    at InnerThemeProvider (/workspaces/developertools.tech/node_modules/@mui/system/ThemeProvider/ThemeProvider.js:29:39)
    at ThemeProvider (/workspaces/developertools.tech/node_modules/@mui/private-theming/node/ThemeProvider/ThemeProvider.js:55:5)
    at ThemeProvider (/workspaces/developertools.tech/node_modules/@mui/system/ThemeProvider/ThemeProvider.js:49:5)
    at MyApp (webpack-internal:///./pages/_app.tsx:39:13)
    at StyleRegistry (/workspaces/developertools.tech/node_modules/next/dist/styled-jsx/dist/index/index.js:671:34)
    at AppContainer (/workspaces/developertools.tech/node_modules/next/dist/server/render.js:280:29)
    at AppContainerWithIsomorphicFiberStructure (/workspaces/developertools.tech/node_modules/next/dist/server/render.js:309:57)
    at div
    at Body (/workspaces/developertools.tech/node_modules/next/dist/server/render.js:596:21)

Yes I saw that too, not sure how it got in there but I'll track it down, thanks!

Ooooh, gotcha! If you don't mind I think those would be best for a separate PR. I could take a crack at adding the flags, but my solution for showing the match/capture groups would need some refactoring to work with the g flag.

@gaston-flores I don't mind, no need to do a heavy refactor if you don't want to.

@gaston-flores it's better to hash the content of a node than use the array index, an example can be found here - https://github.com/developertools-tech/developertools.tech/blob/main/pages/lorem-ipsum.tsx#L231

Also, thanks for adding the global flag, looks great!

Oh, gotcha! I'll give it a try! I don't know why, but the eslint errors are not showing up in my local console. Thanks!

I recently changed the eslint config because it was missing a line for the airbnb rules, maybe your local copy doesn't have that change yet?
The hashing bit helps keep each node unique in an array, in some cases using the array index can cause weird behavior (e.g. replacing the content of a node may not render correctly because the key didn't change).

Yep, works now that I rebased the branch!
I'm kinda running into strange issues when using hash though:
https://user-images.githubusercontent.com/18354222/194915400-3aeb9730-89bf-40e8-bc34-7577128b4c6a.mov
It seems tying the array key to testCase creates a new input on every keypress, losing focus in the process. Here's the code. Here's what I'm doing:
{testCases.map((testCase, index) => {
  const id = hash(testCase);
  return (
    <RegexTestCase
      key={id}
      index={index}
      testCase={testCase}
      regex={regex}
      onDelete={handleRemoveTestCase}
      onInput={handleTestCaseInput}
      deleteDisabled={testCases.length === 1}
    />
  );
})}

I'll leave it with disable for now.

@gaston-flores Oh yeah, that's not good. Go ahead and disable the eslint rule at the top of the file then and use the array index, please add a note on the next line // TODO: Find a better way to replace array index keys, or something of that nature. I know in the past I've created an ID dynamically and assigned it to each node, not sure how I did it off the top of my head.
In any case, if the array index is working, I'm fine with it for now.
Thanks!


[Request] Adding BO2 as a match type

How hard would it be to go into files and add BO2 as a match time both in the season and match creation pages?

Honestly? I'm not too sure haha. I don't think there's any limitation on the API, so it would be as simple as adding in the option here:
https://github.com/PhlexPlexico/G5V/blob/4df9086c0c7baf7884d8530d4cf0e65bbce0e382/src/components/NewMatchForm.vue#L96-L109
And just add in a best of two. However, I'm not sure how that would effect the rules based on the map pool selection..,.

Okay this is done and now seasons and matches can now be set to BO2. You weren't the first one asking so please update accordingly :)

Just upgraded my prod panel to master from release. Gotta test it later today. Thank you so so so much for this fast feature addon.

Hey @kubo6472 just wanted to touch base after a few days - is the BO2 setup working as it should? I know another org that wants to use it but don't feel confident enough until I get some more testers on it!
Thanks!

From my small testing, everything works alright. Since the league has not started yet it was not battle-tested that hard.

No worries, that's confirmation enough for me! Thanks!


No intellisense or error checking

Hi - Intellisense/auto complete is not working with my power query extension in VS code.
Syntax highlighting is working, but it won't autocomplete for me.  Also, it won't do any error checking.
Steps I have tried:

Uninstalling/reinstalling extension
Rebooting VS code
Trying other PQ files

My system:
Windows 10, 64 bit, VS Code 1.60.1
Any suggestions?
Thanks

Hi - it's actually every PQ file that I create - not just one
particular file that has the problem. If I put deliberate errors in the
code it doesn't detect them - see screenshot below.  It should flag no
comma before an In...
Thanks
[image: image.png]
On Thu, 14 Oct 2021 at 22:23, JordanBoltonMN @.***>
wrote:

Are you able to share your .pq file? Perhaps with anonymized connection
info since the parser doesn't care what you're connecting to.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-powerquery/issues/107#issuecomment-943744630,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALPZL6ZJQFYDAWUDFJ4I45TUG5C3XANCNFSM5EEKSI2Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I did a hard uninstall of VS Code and reinstalled the extension.  It still doesn't work but I got a different error this time which may provide a clue.  Any idea?

Closing as transient and outdated.


[SPARK-7270][SQL] Consider dynamic partition when inserting into hive table

JIRA: https://issues.apache.org/jira/browse/SPARK-7270

Merged build triggered.

Merged build started.

Test build #31665 has started for   PR 5864 at commit 8a4352d.

Test build #31665 has finished for   PR 5864 at commit 8a4352d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31665/
Test PASSed.

ping @yhuai @marmbrus.

Merged build triggered.

Merged build started.

Test build #33319 has started for   PR 5864 at commit b5627df.

Test build #33319 has finished for   PR 5864 at commit b5627df.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33319/
Test PASSed.

Thanks!  Merging to master and 1.4.


Add useFloating hook because of the migration from popper.js to floating ui

Closes #1646
Description
Add useFloating hook because of the migration from popper.js to floating ui.
New behavior
Add the following arguments.

middlewares  ... instead of modifiers
Then, modifiers is removed.

Change the following arguments' types

boundary  ... I'd like to discussion its modifiers.

Other arguments are not modified.
Is this a breaking change (Yes/No):
Yes.

modifiers prop

https://yamada-ui.com/components/overlay/popover/props
https://yamada-ui.com/components/overlay/tooltip/props

Additional Information
I think I'd like to add arrow property for a feature Tour component.

@hirotomoyamada
I'd like to discuss the boundary option.

the change of name from clippingParent to clippingAncestors and how it absorbs the difference.
scrollParent dose not exist in the first place ... ?

export const clippingParents: 'clippingParents' = 'clippingParents';
export type Boundary = Element | Array<Element> | typeof clippingParents;

※ from popper.js' branch( link )


D2GAME_TARGETS_Last_6FC40380 (aka TARGETS_RemoveTarget) Missing Else Branch

https://github.com/ThePhrozenKeep/D2MOO/blob/5f10151c29125c170692151df6daa4129ea56dc3/source/D2Game/src/GAME/Targets.cpp#L167
The if statement for in the path for target nodes >= 8 has an else branch that is missing from the code but present in the assembly; taken from 1.10 D2Game (verified in 1.13c):
6FC403FF     CMP EDX,EDI ; if (pTargetNode == pGame->pTargetNodes[nNodeIndex])
6FC40401     JNZ SHORT D2Game.6FC4041D
6FC40403     MOV EDI,DWORD PTR DS:[EDX+8]
6FC40406     MOV DWORD PTR DS:[ECX+EAX*4+10F8],EDI
6FC4040D     MOV EAX,DWORD PTR DS:[EDX+8]
6FC40410     TEST EAX,EAX
6FC40412     JE SHORT D2Game.6FC40433
6FC40414     MOV DWORD PTR DS:[EAX+C],0
6FC4041B     JMP SHORT D2Game.6FC40433
6FC4041D     MOV EAX,DWORD PTR DS:[EDX+C] ; else
6FC40420     MOV EDI,DWORD PTR DS:[EDX+8]
6FC40423     MOV DWORD PTR DS:[EAX+8],EDI
6FC40426     MOV EAX,DWORD PTR DS:[EDX+8]
6FC40429     TEST EAX,EAX
6FC4042B     JE SHORT D2Game.6FC40433
6FC4042D     MOV EDI,DWORD PTR DS:[EDX+C]
6FC40430     MOV DWORD PTR DS:[EAX+C],EDI

The alternate case for target nodes < 8 is however correct.

I think that would be the code at the end of the whole block
    pTargetNode->unk0x0C->pNext = pTargetNode->pNext;
    if (pTargetNode->pNext)
    {
        pTargetNode->pNext->unk0x0C = pTargetNode->unk0x0C;
    }

    D2_FREE_POOL(pGame->pMemoryPool, pTargetNode);
    pUnit->dwNodeIndex = 11;

It's in common with the end of the loop in the <8 branch (see jump at 6FC403CF).
The code looks correct to me ? (albeit not that easy to follow)


"Why should I use Marshmallow" section in README.md is not clear

The examples compare map[string]any unmarshalling to struct. The stdlib can also do selective unmashalling so it really is NOT clear how marshmallow is different (and is better)?
Eg. the code below is a valid stdlib code (I only changed marshmallow->json package), so putting the stdlib map example and marshmallow struct example is just not fair.
func isAllowedToDrive(data []byte) (bool, error) {
	v := struct {
		Age               int  `json:"age"`
		HasDriversLicense bool `json:"has_drivers_license"`
	}{}
	result, err := json.Unmarshal(data, &v)
	if err != nil {
		return false, err
	}

	if v.Age < 17 || !v.HasDriversLicense {
		return false, nil
	}

	for key := range result {
		if strings.Contains(key, "prior_conviction") {
			return false, nil
		}
	}

	return true, nil
}

Can you please change the map implementation to struct similar to marshmallow and list how marshmallow is different(better?)? Eg. dealing with zero values (eg. bool false vs not present in JSON), which can be done with pointers in stdlib or perhaps dealing with arbitrary types? eg. 1234 vs "1234", etc.

ok, I see it's about result returning a map of everything that is not in the struct? The use case in the example to glob on the JSON key, which in my experience is VERY niche.
But yeah, for that particular use case, indeed stdlib won't do, so I'm closing the issue.


chore(demo): add default tabs for some doc examples (JS + Angular + React)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[X] Documentation content changes

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

In next PR all examples will be changed from

to something like


fixed translation of paths in tables

fixes the "invalid key to 'next'" error when generating vs2005 or vs2008 projects with libdirs
this bug also exists in premake-core

Can you provide a test that fails for the current implementation? This code gets used in so many places it seems surprising that could have a such a fundamental error.

@ryanjmulder can you have a look at #7 please?! Looking at your description, it seems that it's the same issue. However, I can't see how this could fix anything. The negative stack positions just refer to the offset from the top instead of the bottom. So what's the difference?
From what I know about Lua internals, the issue here is that the code attempts to change a table while iterating it. The underlying issue is that the luaL_checkstring function will convert the value to a string if it isn't.

@assarbad I don't think I noticed the luaL_checkstring issue at all, but I do agree that it is an issue, unless the values are always strings - which in path_translate, they might be.
@starkos Sorry that I never replied back in 2015.
It's been awhile, but I think the issue that I was trying to fix really is just a stack index issue. If you look above the diff in the function, you'll see this block:
if (lua_gettop(L) == 1) {  	sep = "\\";  }  else {  	sep = luaL_checkstring(L, 2);  }
That indicates that there might be 2 items on the stack prior to the iteration over the table. If there are, then the value will not be at index 4, it will be at index 5. But, in either case, the value will be at index -1.


Add 1-26 as a supported release branch

Issue #, if available:
Description of changes:
adds 1-26 as a supported branch.
adds 1-26 metrics server
added the target to clean-output to free up space when running presubmits for the diff versions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.14


Ory reconciler does not wait for hydra-maester deployment to start

Description

The ORY component reconciler triggers a hydra-maester deployment rollout in case of the need for synchronization of OAuth2clients is needed (only in evaluation profile).
The rollout himself is triggered but the reconciler does not wait for this rollout to be finished, and returns a success.
If one directly after that runs fast-integration tests, like it is done in this pipeline, the tests can fail as the OAuth2Clients might not be synced:
https://storage.googleapis.com/kyma-prow-logs/logs/periodic-main-kyma-incubator-reconciler-kyma1-kyma2-upgrade/1473609312612913152/build-log.txt

Expected result

ORY component reconciler waits for the hydra-maester deployment to be running, after it triggered a rollout
Actual result

ORY component reconciler returns success after triggering rollout.
Steps to reproduce

install kyma 1.24.8 with kyma cli
run fast-integration-test upgrade-test-prep + test
use reconciler to upgrade the cluster to kyma 2.0
run fast-integration-test upgrade-test-tests again
they will fail with the error that a token can not be fetched for (not yet) synced OAuth2Client

Troubleshooting

PR : https://github.com/kyma-incubator/reconciler/pull/621


Add PerformanceManager and PerformanceMeasurement

First pass for 2.14.1: https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/3965

Codecov Report

Merging #3960 (6affb79) into dev (51e8f1b) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Flag
Coverage Δ

*Carryforward flag

msal-angular
95.85% <ø> (ø)

msal-browser
87.94% <100.00%> (-0.05%)
:arrow_down:
Carriedforward from 314d4c0

msal-common
84.99% <ø> (-0.02%)
:arrow_down:
Carriedforward from 314d4c0

msal-core
76.66% <ø> (ø)

Carriedforward from 314d4c0

msal-node
83.35% <ø> (+1.78%)
:arrow_up:
Carriedforward from 314d4c0

msal-react
94.11% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files
Coverage Δ

lib/msal-browser/src/app/ClientApplication.ts
98.33% <100.00%> (-0.01%)
:arrow_down:

...ib/msal-browser/src/app/PublicClientApplication.ts
100.00% <100.00%> (ø)

lib/msal-common/src/error/AuthError.ts
92.85% <0.00%> (-0.90%)
:arrow_down:

...browser/src/interaction_handler/RedirectHandler.ts
89.83% <0.00%> (-0.17%)
:arrow_down:

lib/msal-browser/src/cache/BrowserCacheManager.ts
94.25% <0.00%> (-0.02%)
:arrow_down:

lib/msal-browser/src/utils/BrowserConstants.ts
100.00% <0.00%> (ø)

...msal-browser/src/interaction_client/PopupClient.ts
100.00% <0.00%> (ø)

...l-browser/src/interaction_client/RedirectClient.ts
100.00% <0.00%> (ø)

...owser/src/interaction_client/SilentIframeClient.ts
97.14% <0.00%> (ø)

... and 8 more

Closing in favor of #4570


Android onBackPressed overrides

I need to put my application in background (and not close it) when users click back.
Currently we use something like:
@Override
public void onBackPressed() {
    moveTaskToBack(true);
}

The problem is by doing so the back event into the flutter app is broken.
FlutterActivity already override this method to manage the back event.
 public void onBackPressed() {
        if (!this.eventDelegate.onBackPressed()) {
            super.onBackPressed();
        }
    }

So I would like to do:
@Override
public void onBackPressed() {
      if (!this.eventDelegate.onBackPressed()) {
            moveTaskToBack(true);
        }
}

but not possible as this.eventDelegate is only private. I have no way of doing this for now except copy/paste the FlutterActivity code.

Please add the output of flutter doctor -v.
Is this about adding Flutter to an existing Android app?

I had a similar requirement in my app and came up with following workaround.
I wrapped root Page of my app with WillPopScope:
Widget build(BuildContext context) {
    return WillPopScope(
        onWillPop: () async {
          NavigationChannel().minimize();
          return false;
        },
        child: Scaffold( /* ... */ ),

Before returning false from onWillPop I call platform method which only does following
    @Override
    public void onMethodCall(MethodCall call, MethodChannel.Result result) {
        if (call.method.equals("minimize")) {
            moveTaskToBack(true);
            result.success("success");
        }
    }

MethodCallHandler implemented by MainActivity and this passed as handler so that moveTaskToBack could be called.
After that my app keeps it's state after being reopened from home screen or Android recent apps screen.

@jaumard
You can also create your own activity to realize what you want.
FlutterActivity is quite simple, you can create your own activity(CustomActivity).
In CustomActivity, you can do your own logic to override what's designed in FlutterActivity, keep the unchanged part in  CustomActivity.

@kangwang1988 I don't follow you, your suggest that I copy/paste flutterActivity code into my own CustomActivity to do what I want ? Sure I can ^^ but if at some point flutter update this class I'll have to think about doing too or deal with the consequences ect....
Why not just allowing us to overriding the onBackPressed like this for example:
@Override public void onBackPressed() {
    if (this.isFlutterStackEmpty()) {
         moveTaskToBack(true);
    } else {
        super.onBackPressed();
    }
}

I rather do @nuc134r solution instead of duplicating the activity code.
If the team consider this will never happen that's probably what I'll do :)

@jaumard
Also sound good, if that(override onBackPressed)'s would resolve your issue..

Yeah for me this kind of overrides would be good, at least if there no stack on the Flutter app I can do what I want, here just move to background. But as I'm aware we currently not know if the flutter stack is empty or not right ?

I need this as well. WillPopScope does not solve my use case. When a user hits the back button, I need to release the focus on a TextFormField. Right now, the back button will minimize the keyboard, but the field will still be focused. Is there any way to subscribe to the back button event in flutter so I can unset the focus?
FocusScope.of(context).requestFocus(FocusNode());

I was trying to set up an EventChannel to subscribe to back button presses, but it looks like in FlutterActivity 'onBackButtonPressed' overrides nothing.

Yeah for me this kind of overrides would be good, at least if there no stack on the Flutter app I can do what I want, here just move to background. But as I'm aware we currently not know if the flutter stack is empty or not right ?

I may be wrong but with Navigator 2.0 by @chunhtai , there is a way to know if the navigation stack is empty.
Wondering if is there any considerations that we should be aware of before making delegate property public. This seems to be an easy fix.

If we want to fix this in engine side, we should make plugin to be able to listen to the back button event.
you can also solve this if you use router api. You can then use popRoute to decide what to do with the back button intent. If you use the Router api, you will be in charge to manage what pages are in the navigator, you should know whether the route stack is empty or not

I'm closing this issue. While it doesn't do a fancy synchronous callback of whether to defer or not to flutter via platform channel, this is generally possible with v2 embedding where a) the FlutterActivity's onBackPressed is public and overridable and b) it doesn't super.onBackPress by default.

Specifically see https://github.com/flutter/engine/blob/master/shell/platform/android/io/flutter/embedding/android/FlutterActivity.java#L632


Cant buy items in the pointshop

Every time I try to buy something it says "your not allowed to do that in the moment" what I do wrong?

Any luck with this? I have the same error.


Add unit tests for cluster manager delete cluster

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


Error in 03-Frogger when testing js-of-ocaml-install

Thank you for this workshop!
I have done all the exercises and now i am starting the games it is not building. It is frustrating ;-)
when 'make'  inside test-js-of-ocaml-install =>
dune build @DEFAULT
Entering directory '/Users/eewans/projets/learn-ocaml-workshop'
File "03-frogger/test-js-of-ocaml-install/dune", line 10, characters 0-53:
10 | (alias
11 |  (name DEFAULT)
12 |  (deps main.bc.js index.html))
Error: No rule found for 03-frogger/test-js-of-ocaml-install/main.bc.js
make: *** [all] Error 1

Ok i resolve my problem. It works after changing dune file :
(executable (name main) (modes js) (preprocess
(pps js_of_ocaml-ppx))
(libraries base js_of_ocaml))


Not usable

I have truecaller install on the phone but when I check if it usable or not it gives me false every time. Using the same code as mention is SDK on flutter website. Also just using SDK with no top.

Hi @mouryaavadhesh
The issue described by you has been fixed in our latest version of the plugin. Request you to please upgrade to v0.0.4
Please feel free to let us know if the issue persists via our support channel https://developer.truecaller.com/support for a faster and dedicated response.
Regards,
Parth


compare two tensors by ==

If I compare two UniTensor by ==, I guess it will compare if all the elements are exactly the same. However in practice, there could be a difference in machine precision. I wonder if we can put a criterion for "zero" as an optional argument and set the default to 0, so that users can decide how to define the "same".

After a second though I think this is a bad suggestion, so I will close it.


Source tarball incomplete?

The 0.8 source tarball is 46KB, and extracts into 220KB uncompressed.  By comparison, the 0.7.2 source tarball was 16MB, and a git clone of this repo is 27MB uncompressed.  Is there something missing from the 0.8 tarball, or does the git clone just include a lot of unnecessary stuff?

There certainly is stuff missing, however - on purpose. Acme-dns was migrated over to Go 1.13 and gomodules in #187 and in the process I nuked the vendor directory where all the dependencies were saved. Closing this as resolved, but feel free to let me know you don't agree and we'll reopen the issue.

I just thought it was sure to be an error when it was that much smaller than it used to be, but so much the better.  I'm having trouble building a RPM from my old .spec file, but I'm green enough that it's probably a different error on my part.


New metadata format

The current metadata format being used is present within a .expect file. For example, for if.expect the metadata is given as:
metadata #{   0:   let x: ubit<32> = 4;   1:   let y: ubit<32> = 5; }#
where each line lists the group name and the line number the group is on respective to the corresponding if.fuse file. While useful and intuitive, it would be better to make the metadata more streamlined and not hardcoded.
With the new format, these mappings would be within a field called ids for the adapter. This field is essentially a HashMap where the keys are the group names within the program, represented as Strings, and the values are what line the group starts on, represented as integers.
Whenever any type of step is made, the interpreter would return the following struct:
pub struct ProgramStatus {

  status: HashSet<Id>, // all groups currently running

  done: bool,          // states whether the program has finished
}

With this, we can easily use one of the groups that are running, look up the line the group is on in ids, and then display that line in the debugger. If done is ever true, then we automatically terminate the debugger.
This raises the question of what group to display should 2 groups of the same name be running or even two groups in general. For simplicity, it might be best to just display the first group in the HashSet given to us. In the future, it could be possible to give certain groups priority over others, or even allow one to choose which group to display.
The harder decision to be made is how the parser for the metadata is going to be made. When intializing the debug adapter, ideally ids should contain all groups and their respective lines for the .futil file being debugged. For this, it would be best to start discussing a high level overview of the parser and how it should work before doing anything else.

so to concretely propose what a new metadata format might look like for calyx to calyx mappings:
metadata #{
     group1: /path/to/file LINE_NUMBER
     group2: /path/to/file LINE_NUMBER
}#

We could consider eliding the path for cases where the file is the one the metadata is attached to, but we could just as easily not for the sake of uniformity. Regardless, this implies a Calyx pass which adds the metadata table to the file for a standard Calyx file. Alternatively, we could consider instead making it a separate tool if we don't want to introduce the metadata format to the compiler directly since as far as the compiler is concerned the existing metadata structure is an opaque and unparsed string.
Curious if @sampsyo has any thoughts on this


I could not find what I was looking for

Hi! I have a documentation issue on InstantSearch.js, I could not find what I was looking for which is:
If we want to display the facet filters like the picture below, how can we get the values of the widgets after each time the results are rendered?

Thank you

You can use the currentRefinedValues widget for that!

Thank you @Haroenv :-)


project settings and import settings missing

everything was normal but almost all of the project settings are gone and a lot of the texture import settings are gone, how would I fix it? I used this to compile it https://docs.godotengine.org/en/latest/development/compiling/compiling_for_windows.html

This is not enough information for anyone to help. Please amend your post to match the template format - it is there for a reason.

This is not enough information for anyone to help. Please amend your post and title to match the template format - it is there for a reason.

I'm sorry but, I don't know how to give any more info, I said what I have used to compile and I have said what is wrong and I have never used git hub before unless to download stuff so I don't know how specific you have to be compared to how much you have to be on reddit.

@DevYoshi Refer to the template on the reporting bug page. Or you could check out the issues submitted by others.

Stating the way you compiled Godot isn't really helping as much as you think it does.
What exactly do you mean by "the project settings and texture import settings are missing"? Did many settings in a project reset?

If you've compiled the master branch, you need to toggle Advanced Settings in the Project Settings to see all the project settings as it was before.

Stating the way you compiled Godot isn't really helping as much as you think it does.
What exactly do you mean by "the project settings and texture import settings are missing"? Did many settings in a project reset?

no, most of the settings on the side are just gone

Can you please post a screenshot

Can you please post a screenshot

i have one but calinou's method worked but for some reason, all the pop-ups when you click on buttons are gone

and the texture import settings are different and dont have filter option or detect 3d

The import dock was changed recently and there may be some bugs. I don't recall who made the changes. I know reduz added a "default import settings" feature in the Project Settings, but that shouldn't affect this.

i have one but calinou's method worked but for some reason, all the pop-ups when you click on buttons are in the wrong place

This is a regression from DisplayServer and it's already been reported.

and the texture import settings are different and dont have filter option or detect 3d

Texture filter/mipmap settings have been removed since these are now defined in the location where you use the texture instead (such as CanvasTexture for 2D and StandardMaterial3D for 3D).


Preview ti map to cloud app

Change(s):

Updated syntax for DomainEntity_CloudAppEvents.yaml and FileHashEntity_CloudAppEvents.yaml

Both to filter out empty TI-Map-Entities before the join.

Reason for Change(s):

Both of these rules were creating gross false positives by joining empty fields together. This leads to completely random alerts and is unusable.

Version Updated:

Yes

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

No, I added one line and verified that it works manually

@Lennart-Pently please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree


TSC Meeting (03 Aug 2021): v3.6 Roadmap Planning, Chatops, Maintenance, Governance

August 2021 @StackStorm/tsc 1 hour meeting will take place on Tuesday, 03 Aug 2021, 09:30 AM US Pacific.
See #33 for more info about how to join.
Meeting Agenda

StackStorm v3.6.0 Roadmap planning (15min)

Target date: ?
Release Manager: @winem (based on release rotation).
Release Assistant: WHO @StackStorm/maintainers?
What was @StackStorm/maintainers and partners impact in v3.5.0?
What are @StackStorm/maintainers and partners plans for v3.6.0?
Roadmap WIP

ChatOps: Node.js -> Python transition (@cognifloyd) (7min)
Faster StackStorm Releases (@punkrokk) (#84) (7min)
StackStorm Infra & Expenses (10min)

Packagecloud vs CloudSmith FOSS plan (#74)
Infra/Maintenance: stackstorm.com website migration to static pages #76
Infra/Maintenance: Forum -> Github Discussions migration #75

Relaxing ST2 Governance for Maintainers (@blag) (15min)
Any other random Questions and Discussions (5min)

Let me preface this by saying I would like to be a partner in some way.  I believe there should be some sort of membership cost to be a partner.  This will help fund the core TSC.

Participants
Host: @armab
Attendees: @blag @amanda11 @winem @m4dcoder @guzzijones @cognifloyd
Meeting Minutes
StackStorm v3.5.0 release outcomes:

@guzzijones noted a big performance improvement impact from running the latest st2 v3.5.0 in prod
@userlocalhost from the #community-japan shared in Slack the v3.5.0 performance graphs based on some test workflows. Slides: https://www.slideshare.net/Hiroyasu-OHYAMA/verification-of-performance-improvement-of-stackstorm-v35 (credit to @Kami for this great achievement! :tada:)
Thanks again @amanda11 and @winem for shipping the massive v3.5.0 as Release managers

Faster StackStorm Releases  https://github.com/StackStorm/discussions/issues/84

Q: How to make releases easier and faster?

how about weekly/on-demand releases when needed?

Improvements to the release process (https://github.com/StackStorm/discussions/wiki/Release-Process):

remove the "manual testing" stage (currently blocks 1 week)
we need to commit to the date, more preparation and planning work
include in the current release what was completed

move to the next roadmap something that wasn't finished to avoid blocking the release date
security patches and version updates (?) blocked 2 releases

The team is good with the 3mo release cadence standard so far:

predictable, stable, widely used by the other projects

StackStorm v3.6.0 Roadmap planning

Release Manager: @winem
NEW release Assistant (confirmed): @guzzijones
Target date: October 2021

Updated https://github.com/StackStorm/discussions/wiki/Release-Management-Rotation with the schedule and release managers

Team to help where they can during the process and release preparation
Maintenance release: just ship what was contributed: improvements, fixes, no major features planned to land from the team in this release

ChatOps: Node.js -> Python transition

@cognifloyd shared the news that MSTeams PR was merged from the OpsDroid side

The ball is on the StackStorm side now

TODO: @cognifloyd to create a Github Discussion (or update old one) with the plans, blockers, and corner cases related to the st2chatops implementation with the https://github.com/opsdroid/opsdroid
@blag @winem @amanda11 looking forward to helping where they can

StackStorm Infra & Expenses
AWS

We're on AWS FOSS plan now (thanks to @punkrokk)
Switched st2 e2e CI from nightly to weekly builds (thanks to @amanda11)

TODO @armab: Check the AWS usage impact (reduced by how much?)

Didn't switch to EC2 spot instances yet (TODO by @punkrokk per previous TSC meeting #83)

Packages Hosting Solution (deb/rpm)

We're on the PackageCloud paid plan now (costs ~$120/mo)
Hidden complexity of moving to other deb/rpm provider: rework st2cicd workflows, create new st2 integration pack, releases, st2cicd, update users with the new URL, etc
Agreed Actionable items:

Switch to the PackageCloud FOSS plan to start saving $ ASAP

TODO @winem to finish the deb/rpm packages cleanup (Screenshot)

Discover the CloudSmith features and run the research with pros/cons

TODO @cognifloyd will start looking at the CloudSmith solution and discovery

TODO @blag will lead the Partnership communication

We now have an official Partners program, yay! (https://stackstorm.com/partners/)

Relaxing ST2 Governance for Maintainers

Problem: The requirements to join the TSC and become a StackStorm Maintainer are too high, being a blocker for the new community members to join as official TSC members
https://github.com/StackStorm/st2/blob/master/GOVERNANCE.md#how-to-become-a-maintainer
Proposed solution:

Remove 1 day/week hard requirement from the Governance for TSC Maintainers, as something that doesn't work anymore

half of the TSC don't comply with the 1 day/week requirement anyway


[BEAM-9705] Add value length validation checking on write to database

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.


[SPARK-30908][CORE][DOC] Add version information to the configuration of Kryo

What changes were proposed in this pull request?
1.Add version information to the configuration of Kryo.
2.Update the docs of Kryo.
I sorted out some information show below.

Item name
Since version
JIRA ID
Commit ID
Note

spark.kryo.registrationRequired
1.1.0
SPARK-2102
efdaeb111917dd0314f1d00ee8524bed1e2e21ca#diff-1f81c62dad0e2dfc387a974bb08c497c

spark.kryo.registrator
0.5.0
None
91c07a33d90ab0357e8713507134ecef5c14e28a#diff-792ed56b3398163fa14e8578549d0d98
This is not a release version, do we need to record it?

spark.kryo.classesToRegister
1.2.0
SPARK-1813
6bb56faea8d238ea22c2de33db93b1b39f492b3a#diff-529fc5c06b9731c1fbda6f3db60b16aa

spark.kryo.unsafe
2.1.0
SPARK-928
bc167a2a53f5a795d089e8a884569b1b3e2cd439#diff-1f81c62dad0e2dfc387a974bb08c497c

spark.kryo.pool
3.0.0
SPARK-26466
38f030725c561979ca98b2a6cc7ca6c02a1f80ed#diff-a3c6b992784f9abeb9f3047d3dcf3ed9

spark.kryo.referenceTracking
0.8.0
None
0a8cc309211c62f8824d76618705c817edcf2424#diff-1f81c62dad0e2dfc387a974bb08c497c

spark.kryoserializer.buffer
1.4.0
SPARK-5932
2d222fb39dd978e5a33cde6ceb59307cbdf7b171#diff-1f81c62dad0e2dfc387a974bb08c497c

spark.kryoserializer.buffer.max
1.4.0
SPARK-5932
2d222fb39dd978e5a33cde6ceb59307cbdf7b171#diff-1f81c62dad0e2dfc387a974bb08c497c

Why are the changes needed?
Supplemental configuration version information.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exists UT

Test build #119084 has started for PR 27734 at commit e6a197d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23828/
Test PASSed.

Test build #119084 has finished for PR 27734 at commit e6a197d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119084/
Test PASSed.

Merged to master.

@HyukjinKwon Thanks for your work.

Merged to branch-3.0 too


Closure inside macro seems to break rustfmt

I've made a macro that essentially wraps a block in an if/else:
macro_rules! section {
        ($title:literal, $body:expr) => {{
            let span_section = trace_span!(target: UI_TRACE_BUILD_INTERFACE, $title).entered();
            let maybe_node = ui
                .tree_node_config($title)
                .opened(true, Condition::FirstUseEver)
                .push(); // Should be open by default
            if let Some(opened_node) = maybe_node {
                trace!(target: UI_TRACE_BUILD_INTERFACE, "node expanded");
                $body;
                opened_node.end();
            } else {
                trace!(target: UI_TRACE_BUILD_INTERFACE, "node closed");
            }

            span_section.exit();
        }};
    }

I use it like so:
section!("My title", {
    // Block
    // More code
    // etc
    // ...
});

I came accross issues with rustfmt not formatting where I used the macro, when I went to add a closure inside the block inside the macro.
Example
    section!("Doesnt work - closure", {
        let x = ||{
                    format!("");
            format!("");
                                    fn why_is_this_not() {}
        }
    });
    // Works
    let x = || {
        format!("");
              format!("");
         fn why_is_this_not() {}
    };
    // Works
    {
        format!("");
              format!("");
         fn why_is_this_not() {}
    };
    section!("Works - no closure", {
        {
             format!("");
            format!("");
                        fn why_is_this_not(){}
        }
    });

When I run rustfmt, the first instance doesn't get formatted, but the rest do. I thought at first this was due to rustfmt not formatting inside macros, but this isn't the case since the last block does get formatted. I originally came across this when calling a function with a closure as the argument, but it also seems to break when the closure is a variable.
How to reproduce

Declare the section!() macro above.
Use the macro like so: section!("title", {/*Block of something*/});
Run rustfmt
The code inside the /* Block of something*/ should be formatted correctly
Declare a closure inside the /* Block of something*/, either as a parameter to a function, or as a variable.
Run rustfmt
Observe the code is not formatted

Video demonstration
https://user-images.githubusercontent.com/48875125/210857042-1fc5d347-be59-4fd6-a58d-7ea54930757c.mp4

I did some digging and it turns out that you're missing a ; in the example with the closure.
In order for the following to be parsed as a block, you need a ; after the closure declaration.
 {
         let x = ||{
                     format!("");
             format!("");
                                     fn why_is_this_not() {}
-        }
+        };
 }

With that change you can run rustfmt on your original input to produce:
fn main() {
    section!("Doesnt work - closure", {
        let x = || {
            format!("");
            format!("");
            fn why_is_this_not() {}
        };
    });
    // Works
    let x = || {
        format!("");
        format!("");
        fn why_is_this_not() {}
    };
    // Works
    {
        format!("");
        format!("");
        fn why_is_this_not() {}
    };
    section!("Works - no closure", {
        {
            format!("");
            format!("");
            fn why_is_this_not() {}
        }
    });
}

@ytmimi Thanks, that fixed that issue. I'm still having issues with closure formatting, but this time it's inside a function call and I can't just add the semicolon like you proposed. Heres the code:
    trace_span!(target: UI_TRACE_BUILD_INTERFACE, "error_modal").in_scope(||{
        // If we have an error, its modal time....
        // Also demonstrate passing a bool, this will create a regular close button which
        // will close the popup. Note that the visibility state of popups is owned by imgui, so the input value
        // of the bool actually doesn't matter here.
        let mut opened_sesame = true;
        let popup_token = match ui.modal_popup_config(MODAL_NAME).opened(&mut opened_sesame).begin_popup(){
            None => {
                trace!(
                    target: UI_TRACE_BUILD_INTERFACE,
                    "errors modal not visible"
                );
                return;
            }
            Some(token) => token,
        };
        let mut errors_vec = match ERRORS.lock() {
            Ok(lock) => lock,
            Err(err) => {
                warn!(target: GENERAL_WARNING_NON_FATAL, "errors Vec mutex was poisoned by some other thread");
                err.into_inner()
            }
        };
        let colours = read_config_value(|config| config.runtime.ui.colours);

        if errors_vec.is_empty(){
            trace!(target: UI_TRACE_BUILD_INTERFACE, "don't have any errors but errors modal is open!?!?");
            warn!(target: GENERAL_WARNING_NON_FATAL, "error modal was opened but we don't have an error to display. this probably shouldn't have happened");
            ui.text_colored(
                colours.severity.warning,
                "This popup shouldn't be visible, sorry about that. Normally it would show you an error that happened with reloading the config, but we don't have any error to display (yay)",
            );
            ui.close_current_popup();
            popup_token.end();
            return;
        }

        if let Some(tab_bar_token) = ui.tab_bar("Error tab bar"){
            trace!(target: UI_TRACE_BUILD_INTERFACE, "error tab bar visible");
            errors_vec.retain(|report|{
                let span_error_tabs = trace_span!(target: UI_TRACE_BUILD_INTERFACE, "error_tabs", report=format_report_display(report), opened = Empty).entered();
                // This bool is passed into [imgui] when creating each tab, so [imgui] will set it to [false] when the user closes the tab
                // Since we're inside [retain_mut()], we can use this to decide which reports to keep, since it'll only be false once the user closes it
                let mut opened = true;
                let title = format!("{}", report.chain().next().expect("Every error should have at least one error in the chain, but `.next()` returned [None]"));
                if let Some(tab) = ui.tab_item_with_opened(&title, &mut opened){
                    trace!(target: UI_TRACE_BUILD_INTERFACE, "error tab {title} selected");
                    display_eyre_report(ui, report);
                    tab.end();
                }
                else{
                    trace!(target: UI_TRACE_BUILD_INTERFACE, "error tab {title} not selected");
                }

                // Print the short version of the error to the log, no need for the full one since we had that earlier
                if !opened{
                    trace!(target: UI_DEBUG_USER_INTERACTION, "User hiding error tab {title}");
                }
                span_error_tabs.record("opened", opened);
                span_error_tabs.exit();
                opened
            });
            tab_bar_token.end();
        }
        else{
            trace!(target: UI_TRACE_BUILD_INTERFACE, "error tab bar hidden");
        }
        popup_token.end();
        })

Since I'm calling the closure inside a function (in_scope(||{...})), I don't see a way of adding the semicolon. I did try capturing the closure as a variable, and then passing the variable into the function, which did work, but it's a bit of a hack and clutters the code (I have several calls to in_scope(), so I'd have to do it for each one. Putting the closure inside a scope (double nesting) and adding a semicolon did nothing: in_scope(|| { {...}; });
Is this another case where I'm doing something wrong? Because it seems to me that it's too easy to 'break' rustfmt in a not-very-obvious way (even if it's intended design).
Either way, thanks for your help :)

rustfmt won't format your code because the code exceeds the max width, and I believe you're now running into https://github.com/rust-lang/rustfmt/issues/3863.
To try and format your code with the default max_width=100 you can try setting format_strings=true and wrap_comments=true (you may need a nightly rustfmt).
If that doesn't work your only other option is to bump the max_width to some sufficiently large number. Otherwise you'll just need to manually format the code. As an additional note, rustfmt can't format the trace! and warn! macros because they don't parse, so even with the format_strings=true and wrap_comments=true configs that I mentioned you'll notice that those macros are left unchanged.

Glad I could help! feel free to open up another issue or reach out on discord / zulip  if something else comes up


Environment variables are all over the place. Make it simple and scalable.

Hi @edardev,
Not entirely sure what you mean? In the admin project, you only need to set one environment variable – GATSBY_MEDUSA_BACKEND_URL that should point the admin towards your server.
Closing the issue, for now. If I misunderstood you, feel free to reopen it and elaborate on your issue. 😄