No entities/devices after logging in

I'm getting the error below, and my MijnTuin hub doesn't get any entities or devices. Any clue what's going on?
Logger: homeassistant.components.sensor
Source: custom_components/mijntuin/utils.py:79
Integration: Sensor (documentation, issues)
First occurred: September 22, 2023 at 16:27:38 (1 occurrences)
Last logged: September 22, 2023 at 16:27:38

Error while setting up mijntuin platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 359, in _async_setup_platform
    await asyncio.shield(task)
  File "/config/custom_components/mijntuin/sensor.py", line 79, in async_setup_entry
    await dry_setup(hass, config, async_add_devices)
  File "/config/custom_components/mijntuin/sensor.py", line 43, in dry_setup
    await componentData._force_update()
  File "/config/custom_components/mijntuin/sensor.py", line 111, in _force_update
    gardenLink = await self._hass.async_add_executor_job(lambda: self._session.login(self._username, self._password))
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/mijntuin/sensor.py", line 111, in <lambda>
    gardenLink = await self._hass.async_add_executor_job(lambda: self._session.login(self._username, self._password))
                                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/mijntuin/utils.py", line 79, in login
    self.gardenlink = self.gardenlink.replace('/calendar','')
                      ^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'replace'

Hi, if you navigate to the website https://www.mijntuin.org/dashboard, don't you see a 'Tuinkalender' link in the left side menu?
Maybe you first need to make sure to have several plants added into your collection?

Hi,
Yeah, tuinkalender is there, and it has tasks. Given the error in HA, I suspect it's some kind of login error. I registered with my Google account, does that make a difference? I still had to create a password, which I used to log in in HA.
 Apparently I used the wrong password to log in. After resetting my password on MijnTuin and signing in again, everything now works fine. It would probably be nice to have a more noticeable error for this, but I don't know how easy that is to implement.

hehe, ok. thx for the feedback. May indeed look into it for a next release to cacht login failures.


ENH Bootstrap analysis

Addresses https://github.com/quantopian/pyfolio/issues/208. Depends on https://github.com/quantopian/pyfolio/pull/262.

@a-campbell Can you help reviewing this?

Looks great! Made a few comments. This is going to be a really interesting feature.


[dv/otp_ctrl] Update UNR file

This PR updates the tool generated UNR file. The main impact is that
design added a VendorTest partition.
Signed-off-by: Cindy Chen<EMAIL_ADDRESS>

Hosted a review with Michael.

TODOs are captured in this issue: https://github.com/lowRISC/opentitan/issues/10313


[BUG]: Keyboard Emulation does not allow for EVA UP (Left Shift)

Keyboard Emulation presses Right Shift, but Left Shift is needed for EVA UP using the jet pack. No other function in Simpit allows for EVA Up.
Mod version: Latest Pre-Release
Game version: 1.11
Operating system: Win10
Microprocessor/s in use: Arduino Nano, Intel 8700K
This is similar to the bug regarding sending Shift as a key modifier, but in this case it does not send as a normal keypress, either. This bug could be remedied by remapping keys in KSP (however, the other bug cannot), but finding a solution to one of these bugs is likely to also fix the other.

Bug probably fixed in 8fbbd47542ff84ab32f39737cbad3b14f990bae5
Here is a code that is working on my side to go up while in EVA during 1 sec
  keyboardEmulatorMessage msg(0xA0, KEY_DOWN_MOD);
  mySimpit.send(KEYBOARD_EMULATOR, msg);

  delay(1000);

  msg.modifier = 16;
  mySimpit.send(KEYBOARD_EMULATOR, msg);

Replace A0 with A2 for doing down (LCONTROL instead of LSHIFT). All those values can be found in KerbalSimpit\Contrib\InputSimulator\WindowsInput\Native\VirtualKeyCode.cs
Can you check on your side ?

Resolution confirmed, and an example was added to show a nominal way of controlling EVA up


💡  Copy Workaround

Describe the feature
Implement a small UI for copying the emoji manually on Wayland if uinput is restricted
An idea of implementation
Instead of silently crashing (making the entire thing kind of useless on Wayland), there could be a small read-only input field UI for Wayland users who don't want to give direct R/W permissions.
Or if users simply prefer the UI, they could use the --copy-ui flag?

Maybe this one works for you it's the webview equivalent of an emoji-mart desktop app.
https://github.com/ttytm/emoji-mart-desktop
The appimage is just 6mb. It copies to the clipboard, should not crash on you and has no window resizing issues.


WebsocketNotConnectedException during send from server

Connecting to websocket server from Firefox using localhost. Firefox shows the connection is open and does not get a connection closed event. My use case is 'push' only, so I am using the connection to send data to the web page. When I send the data I get a WebsocketNotConnectedException.
Digging into this further I found that the Draft_10.java translateSingleFrame() method was reading a Opcode.CLOSING byte from the buffer during the send. Which I don't understand, because I believe decode() in the implementation is only called for messages sent from the client. If I am correct in this, than possibly Firefox is sending a close event?
My server code sends the message to the connection by iterating through the open connections and calling send() on each. In my testing I only have the one connection.
NOTE: I can be available on the IRC channel at any time you name to discuss this.
My client code looks like this:
var ws;
var $ = require('jquery');
var $body = $(document.body);

function onMessage (event) {
    var data = JSON.parse(event.data);
    if (data.type) {
        $body.trigger(data.type, data);
    }
}

module.exports = {
    /**
     * Connects to server via WebSocket connection
     * @return {WebSocket}
     */
    connect: function(port){
        ws = new WebSocket('ws://localhost:' + port);
        ws.onopen = function(){
            console.info('WebSocket connected');
        };

        ws.onmessage = onMessage;

        return ws;
    },

    /**
     * Bind event handler
     * @param  {string}   eventType   'type' property that comes with json (e.g., "screenUpdate")
     * @param  {Function} callback    Called with 2 parameters: 1st - jQuery event object, 2nd - data
     */
    on: function(eventType, callback){
        $body.on(eventType, callback);
    },

    /**
     * @return {WebSocket}
     */
    getWebSocket: function(){
        return ws;
    }
};

Update...
I restarted both my IDE (IDEA) and loaded a completely new copy of the web page. I did not restart FIrefox. I ran my test again and this time it appeared to work.
Is it possible that earlier crashes or incomplete shutdowns left Websocket threads running or left the Websocket server code in an invalid state somehow? If yes, that was my problem; and I would like to know if there is an easy way to reset/shut down properly to avoid this in a production application. I had thought that when I killed the app it also killed all the running threads, but maybe I was wrong.
Thanks;
Jack

Update. I am continuing to get this error. If I reboot my machine and start over from scratch the server will send one message to the client. After that I get the error on every try, even if I kill the server process and start it again. Every time I reload the client code in Firefox it says it is connected to the websocket server, but I still get the error. I will now try the same on some different browsers.

Hello @jackwilliambell
I would recommend to you to use Draft_17 and not Draft_10!
Greetings
marci4


feat: Photo gallery for "Others"

Hi everyone!
Today, the 'Other' view only displays a single photo and does not allow browsing the gallery.
Now, we have:

a swipe gesture to switch between photos
network errors are supported
a details popup shows info about the picture
an indicator if the photo is outdated

Note: the contributor name is not implemented (waiting for https://github.com/openfoodfacts/openfoodfacts-dart/pull/953)
Video:
Gallery.webm

Codecov Report
Attention: Patch coverage is 0% with 139 lines in your changes missing coverage. Please review.

Project coverage is 7.00%. Comparing base (4d9c7fc) to head (1b701c5).
Report is 258 commits behind head on develop.

Files
Patch %
Lines

..._app/lib/pages/image/product_image_other_page.dart
0.00%
133 Missing :warning:

.../pages/image/product_image_gallery_other_view.dart
0.00%
5 Missing :warning:

...ooth_app/lib/pages/image/product_image_widget.dart
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5501      +/-   ##
==========================================
- Coverage     9.54%   7.00%   -2.54%
==========================================
  Files          325     397      +72
  Lines        16411   21001    +4590
==========================================
- Hits          1567    1472      -95
- Misses       14844   19529    +4685

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Metadata management interfaces and schema.

As suggested in design, metadata for images and bundles will be stored in database.
As POC for data flow is being worked on, Opening this issue to discuss more details on this aspect.
like

Interfaces for metadata management.
Schema of database.
Choice of database.

What exactly do you want to discuss? The requirements for metadata management are going to come purely from use cases. I am not sure we can pre-select an interface, schema, or database without a full picture.
Basically, we are going to have to solve the problems at hand, then reanalyze what is touching disk to define our actual requirements.

For things like containers and images we have the metadata APIs complete.  They have CRUD like rpcs for modifying the values.


WiP: MINIFICPP-839 - Fix memleaks

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Closing this because of inactivity. Some of the leaks have been fixed on main, and I'll make sure to check this as reference when similar efforts are underway.


How does this work?

Maybe provide an example, because I have a project sitting in my gopath and I just get "failed to build import graph" each time

so I had to move my project in to the GOPATH, following the structure of the other deps;
gobfuscate github.com/user/project ./something_out
I had problems with a CGO library, so maybe this isn't for me


Configuration Management EPs for AuthFlow in Node SDK

Created by: @bayegan May 20 2022 at 11:33 CET
Last updated: Jul 19 2022 at 14:52 CET
ClickUp ID: IK-3040
As a user of the Node SDK, I need to be able to invoke the Configuration Management APIs in the Node SDK.
Acceptance criteria:
Implement the following gRPC/graphQL endpoints in the Node SDK:
AuthFlow: CRU+list

Commented by: @bayegan Sep 02 2021 at 03:01 CET
@dusan-kovacik-profiq : this might be a task coming up in the next sprint (uranus). FYI.

Commented by: @dusan-kovacik-profiq Jun 22 2022 at 08:59 CET
L

isting auth flows is not possible yet as we don't have an endpoint for that on the back-end side.
There's a limitation for updating auth flows. It's not possible to update an auth flow which was created using the UI tool in the console app.


Unify behavior of toarray() and tosparse() methods

The base classes Vector and Matrix define an abstract interface for methods toarray() and tosparse(), but this is not strictly enforced in the subclasses. Moreover the behavior of such methods is not unique across all subclasses.
For example the tosparse() method of class DirectionalDerivativeOperator does not accept the order argument, and includes ghost regions by default. As a consequence, when tosparse() is called on a BlockMatrix object containing a DirectionalDerivativeOperator block, an exception is raised.
CC: @davschneller

@jowezarek Is this issue still relevant given all the changes that have been made to the linear algebra layer of Psydac? If not, feel free to close it.

I had a look, there are four different toarray() handles: toarray(self), toarray(self, **kwargs), toarray(self, order='C') and toarray(self, order='C', with_pads=False).
The two odd ones, including order, belong to BlockVector and StencilVector respectively.
Although we can't speak of uniform behavior, there are no big differences in the usage. And if these optional arguments are useful, I don't see why we should remove them.
Given a BlockVector consisting of StencilVectors, one could consider whether being able to pass the with_pads argument might be useful.
There are only two tosparse() handles: tosparse(self) and tosparse(self, **kwargs).
I don't think that this will ever cause problems.
Unless you want me to have a closer look, I'd say that we can close this issue.


Steak Survey Data

It looks like the steak-survey data got mixed up with some lottery data.

Sorry, I did some more digging, and just realized that there was a lot more information that I didn't see at first.


Crash Report: Argument rangeInElement (18,36) endOffset must not exceed descriptor text range (4928, 4952) length (24).

Description
At the pycharm startup the error popup appears.
Stacktrace
Argument rangeInElement (18,36) endOffset must not exceed descriptor text range (4928, 4952) length (24).```

Fixed in commit a4caa3c and will be included in release b0.6.1 in the near future.


Don't prioritize the "liquidity required" markets in the default sorting

Updated here: https://github.com/seer-pm/demo/commit/08fc13b06b661b6269ed9c8125bd887f6f2dba8f


No such image: drogon:latest

When initializing a project with samples, I get the following error:
fatal     Failed to fetch boilerplate. Error: (HTTP code 404) no such container - No such image: drogon:latest
See the full command log below
❯ yarn run drogon init
yarn run v1.22.17
$ node -p "'export const LIB_VERSION = ' + JSON.stringify(require('./package.json').version) + ';'" > src/version.ts
$ npx ts-node src/index.ts init
 _ .-') _  _  .-')                                             .-') _ ,---.
( (  OO) )( \( -O )                                           ( OO ) )|   |
 \     .'_ ,------.  .-'),-----.   ,----.     .-'),-----. ,--./ ,--,' |   |
 ,`'--..._)|   /`. '( OO'  .-.  ' '  .-./-') ( OO'  .-.  '|   \ |  |\ |   |
 |  |  \  '|  /  | |/   |  | |  | |  |_( O- )/   |  | |  ||    \|  | )|   |
 |  |   ' ||  |_.' |\_) |  |\|  | |  | .--, \\_) |  |\|  ||  .     |/ |  .'
 |  |   / :|  .  '.'  \ |  | |  |(|  | '. (_/  \ |  | |  ||  |\    |  `--'
 |  '--'  /|  |\  \    `'  '-'  ' |  '--'  |    `'  '-'  '|  | \   |  .--.
 `-------' `--' '--'     `-----'   `------'       `-----' `--'  `--'  '--'
✔ Name of the project … ibc-icon
✔ Do you want to initialize your Drogon project with samples? … no / yes
✔ Do you want to generate a keystore for this project? … no / yes
✔ Current working directory looks like a Drogon project. Do you want to overwrite all files? … no / yes
✔ Pick a boilerplate › Hello World
✨ Scaffolding done 🎉
✖  fatal     Failed to fetch boilerplate. Error: (HTTP code 404) no such container - No such image: drogon:latest
error Command failed with exit code 1.

This should be fixed now. Thank you for raising the issue @CyrusVorwald

I still have this issue with the same reproduction steps

you'll have to first do drogon install before you can do the init. init makes sure the necessary images are available locally.

I was not able to do drogon install. See https://github.com/icon-community/drogon/issues/21 for more on that.

Im having the same issue,
I started running npm install -g @icon-community/drogon as per the instructions in the README.md.
after that I executed drogon init this is the result:
fidel@laptop:~/code/js/projects/icon-projects/drogon/01$ drogon init
 _ .-') _  _  .-')                                             .-') _ ,---.
( (  OO) )( \( -O )                                           ( OO ) )|   |
 \     .'_ ,------.  .-'),-----.   ,----.     .-'),-----. ,--./ ,--,' |   |
 ,`'--..._)|   /`. '( OO'  .-.  ' '  .-./-') ( OO'  .-.  '|   \ |  |\ |   |
 |  |  \  '|  /  | |/   |  | |  | |  |_( O- )/   |  | |  ||    \|  | )|   |
 |  |   ' ||  |_.' |\_) |  |\|  | |  | .--, \\_) |  |\|  ||  .     |/ |  .'
 |  |   / :|  .  '.'  \ |  | |  |(|  | '. (_/  \ |  | |  ||  |\    |  `--'
 |  '--'  /|  |\  \    `'  '-'  ' |  '--'  |    `'  '-'  '|  | \   |  .--.
 `-------' `--' '--'     `-----'   `------'       `-----' `--'  `--'  '--'
✔ Name of the project … test-1
✔ Do you want to initialize your Drogon project with samples? … no / yes
✔ Do you want to generate a keystore for this project? … no / yes
/home/fidel/.nvm/versions/node/v18.13.0/lib/node_modules/@icon-community/drogon/node_modules/docker-modem/lib/modem.js:336
      var msg = new Error(
                ^

Error: (HTTP code 404) no such container - No such image: iconcommunity/drogon:latest
    at /home/fidel/.nvm/versions/node/v18.13.0/lib/node_modules/@icon-community/drogon/node_modules/docker-modem/lib/modem.js:336:17
    at getCause (/home/fidel/.nvm/versions/node/v18.13.0/lib/node_modules/@icon-community/drogon/node_modules/docker-modem/lib/modem.js:366:7)
    at Modem.buildPayload (/home/fidel/.nvm/versions/node/v18.13.0/lib/node_modules/@icon-community/drogon/node_modules/docker-modem/lib/modem.js:335:5)
    at IncomingMessage.<anonymous> (/home/fidel/.nvm/versions/node/v18.13.0/lib/node_modules/@icon-community/drogon/node_modules/docker-modem/lib/modem.js:303:16)
    at IncomingMessage.emit (node:events:525:35)
    at endReadableNT (node:internal/streams/readable:1359:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  reason: 'no such container',
  statusCode: 404,
  json: { message: 'No such image: iconcommunity/drogon:latest' }
}

Node.js v18.13.0

@CyrusVorwald I see. imho it it s a different issue. Since the pre-requisites are not met, (in this case the docker images which needs to be pulled), the init command is failing.
Although this error is expected, the UX can be very much improved. I have added an enhancement ticket for this #23.
@FidelVe , I am assuming that perhaps you did not do drogon install before doing the init. There was a gap in the documentation with regards to this, added a PR to address the documentation issue #22.
Thank both of you for the bug reports. Im currently closing this issue because the documentation is updated now.


Abstract logic for printing mfu_copy_stats

Moved the prints for mfu_copy_stats into a new function,
that allows printing in 3 different versions, for each
of the versions that previously existed.
Most of the logic is the same, where just the output varies slightly.
Also adjusted the allreduce to be in place.
Signed-off-by: Dalton Bohning<EMAIL_ADDRESS>

@adammoody I'm working on adding metrics for "DAOS objects", which will require some conditional compilation and checks to know whether to print "objects" or "files", etc.
This centralizes the logic for printing the stats, which will reduce the code footprint when I add stats for DAOS objects.

Actually, on second thought, I realize now that this won't work the way I need it to...
Closing this PR until it has been reworked.
Sorry about that.


Adding error message and placeholder for dropdown

This PR fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 4 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 41.63%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/api/common/extHostModelView.ts
0
4
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.005%

Covered Lines:
26389

Relevant Lines:
57395

💛  - Coveralls

Please attach images for all UI changes.
And if you can - please give a brief explanation of why this addition is necessary.

@alanrenmsft and @Charles-Gagnon. I have fixed the screen reader issues and added support for multiple validation errors. Currently, it behaves the same way as azure portal dropdown error messages.

Adding border colors for validation errors:

Adding focus offset so that we can see the red border.


Using go-swagger to generate other artifacts using custom templates not working from 0.12.0

Problem statement
Up to go-swagger version 0.11.0, we could use go-swagger's generator to generate other artifacts (not go code) into the path outside of $GOPATH/src using custom templates. The code that rejects such code generation outside of $GOPATH existed before but there was a bug that didn't trigger this check.
But according to the commit logs, this bug seems to have been fixed in August and this change went into 0.12.0. As a result, we can no longer use go-swagger to generate non-go code using custom templates into arbitrary folder.
I am wondering if we could add a parameter to method baseImport (in support.go) so that we could have a configuration option for not triggering this $GOPATH/src check in certain cases.
https://github.com/go-swagger/go-swagger/blob/master/generator/support.go#L253
I would appreciate for your comments.
regards, aki

yeah I think you're right.
We have a concept of language options but this hasn't been added to it yet.
https://github.com/go-swagger/go-swagger/blob/master/generator/shared.go#L90
Perhaps this check should move there?

As a work around, I believe that setting skip_format = true in the generator's yaml config file should allow to bypass this check.

@fredbi I don't think skip_format=true would let you bypass this GOPATH check as the check is done before the result is written.

I am not sure about this specific check.
I have recently modified things so that code not passing format check is written down no matter what, with a warning (intent was to allow template debug).
How about a PR with an additional skip_checks or alike to bypass the unwanted check?

@casualjim Yes. If we could change LanguageOpts, we could add the language specific check method there. Is this change allowed in the next 0.x.x? If not, it would be nice if we could at least modify the current check code so that it is only enabled only if GoLangOpts is used or something like that.
thanks.

@elakito Check out https://github.com/go-swagger/go-swagger/blob/master/generator/shared.go#L553

@elakito you can make the changes in 0.x.x as long as we do it without breaking the go language support we're all good.

@fredbi I know where this skip_format has effect. But I don't know why it relates to this GOPATH check. It's not about the format of the generated code but about in which folder the code is generated.
This GOPATH check happens at the generator client start up (https://github.com/go-swagger/go-swagger/blob/master/generator/client.go#L123) which is much before any writing happens where skip_format can have some effect.
We could add another property like skip_format and call it skip_gopath_check. But I find it ugly and there is some overlap with what we can do with LanguageOpts. So, I think using one of the two approaches that I suggested would be reasonable, no?

OK

the use case for language opts is exactly what you want to do @elakito so I my vote goes to continuing to expand that functionality.


Inconsistent margin compared with the previous version.

Currently there is no margin between the toast and the browser window border. Is this the expected behaviour?

Thanks! Fixed. Looks like something is broke with recent vue-sonner update.


LSP: Cache current loaded file for later queries

Currently each hover request does a reload of the file in GHC, which is slow

Closed in favour of #226


No file eventDispatcher/init.lua when starting any programs downloaded with the init?

I've never used a program downloaded on OC so forgive me if I missed some groundwork. I used the tutorial for install outlined in the thread linked in the README, and then followed it up with the guide submitted recently by another contributor - I have all the files installed (or so I thought) but when I try to run builder it can't find "~/eventDispatcher/init.lua" in any directories (it tries to search usr/lib home/lib and my path where everything is installed c/oclib
Any help would be great, I don't know how to copy the errorlog

I had the same mistake. There seems to be an error in the installation file. I have copied the following files into another folder since then it works:
Oclib main folder:
eventDispatcher.lua -> /lib/
smartmove.lua -> /lib/
util.lua -> /lib/
serializer.lua -> /lib/
inventory.lua -> /lib/
autolevel.lua -> /lib/
cleanup.lua -> /lib/
obejectStore -> /lib/
/oclib/builder/ folder:
model.lua -> /lib/builder/
pathing.lua -> /lib/builder/
shapes.lua -> /lib/builder/
Good luck
Translated with www.DeepL.com/Translator (free version)


Export required modules

Export all the required modules as an array.

This PR should be rebase on master after https://github.com/seanchas116/glob-loader/pull/2 is merged.

Thanks!

Released in 0.2.0.

Awesome, thanks.


JWT::DecodeError (Not enough or too many segments)

Hey @timwaters, we're using this gem in a Wikimedia plugin for Discourse: https://github.com/paviliondev/discourse-wikimedia-auth.
Recently, we've been seeing a number of instances of a JWT::DecodeError (Not enough or too many segments) error in the Discourse server logs. The source is the JWT decoding here: https://github.com/timwaters/omniauth-mediawiki/blob/master/lib/omniauth/strategies/mediawiki.rb#L58
Any insight on what's going on here, i.e. what type of user action or user data produces an invalid JWT?
Relatedly, how would you feel about a PR adding some error catching and logging to this method?

Hi, I don't know what would be causing it. Perhaps something in https://github.com/jwt/ruby-jwt/issues and different versions?
Yes please do feel free to submit PRs. And thanks for using the gem!


unapec.txt

UNAPEC(Universidad Accion Pro Educacion y cultura) adding a one of university of caribean

@MiguelModd What is the email domain which you wish to add? If it is unapec.edu.do (i.e., email addresses of the school students end with @unapec.edu.do), please rename the file path to lib/domains/do/edu/unapec.txt.

@MiguelModd You might miss my previous message. Please reply with regard to the abovementioned issue. Thank you!

@MiguelModd I am sorry, this request remains unanswered for a while, I have to close it. Please reopen and comment if you have an update regarding abovementioned issue. Thank you for your understanding!


Incompatibility Issue

I am currently undertaking a project involving the integration of the SHT40I-AD1B-R2 temperature sensor with an ESP32 C3 Mini, as depicted in the attached image. I am employing the Sensirion Arduino-I2C-SHT4x library to facilitate this integration. Unfortunately, I have encountered a significant issue where the library fails to read the data from the sensor, specifically, it does not detect or recognize the SHT sensor. The system consistently returns an error message.
Given this context, I would greatly appreciate any guidance or recommendations you might have regarding this problem. Could there be specific configurations or aspects of the SHT40I that are not compatible with your library? Any insights or potential solutions to enable successful communication between the sensor and the microcontroller would be immensely helpful.
Thank you for your assistance.

Hi @DiSkyMaster
The library should be compatible with the SHT40I.
Did you draw the schematic with the pins corresponding to their physical location?
 SDA should be opposite from VSS and SCL should be opposite from VDD.
See excerpt from the datasheet:

Can you double check if you have the correct pin assignment?


Coco unknown entities - enhancement request

I have a pulse meter in my installation which is not detected, as well as a PV charging station, which has recently been added through the Niko API integration layer.
In can assist in testing.
Logger: custom_components.nhc2.nhccoco.coco
Source: custom_components/nhc2/nhccoco/coco.py:414
integration: Niko Home Control II (documentation, issues)
First occurred: 11:34:25 (3 occurrences)
Last logged: 11:34:25
Class CocoGenericChargingstation not found: module 'custom_components.nhc2.nhccoco.coco' has no attribute 'CocoGenericChargingstation'
Class CocoElectricityPulseCentralmeter not found: module 'custom_components.nhc2.nhccoco.coco' has no attribute 'CocoElectricityPulseCentralmeter'
Class CocoEaseeChargingstation not found: module 'custom_components.nhc2.nhccoco.coco' has no attribute 'CocoEaseeChargingstation'

@bartsmetdv can you mail me your Device List

@tijsverkoyen : Done.

Class CocoGenericChargingstation not found: module 'custom_components.nhc2.nhccoco.coco' has no attribute 'CocoGenericChargingstation'

I think this is a bogus device as it has no properties. I have added it to the ignore list

Class CocoElectricityPulseCentralmeter not found: module 'custom_components.nhc2.nhccoco.coco' has no attribute 'CocoElectricityPulseCentralmeter'

I suspect you have https://www.niko.eu/en/article/550-00250 in your installation, correct?
I don't see any data in your device list. So I think this is not exposed through the API (yet).

Class CocoEaseeChargingstation not found: module 'custom_components.nhc2.nhccoco.coco' has no attribute 'CocoEaseeChargingstation'

@Bartsmet would you be able to test the changes in https://github.com/joleys/niko-home-control-II/pull/170. This PR adds support for your Easee Charging station.
I don't own one myself, but I think I have implemented all available data.
I also contacted Niko, as there is a new parameter HasStream on the Electrical Power property. I suspect this is a new way that allows to read realtime values, but I am not sure. But as I don't own a charging I can't see this in real life.

Hi tijs, this seems to work fine, thx.
I think the CocoGenericChargingstation will be a base implementation where other chargers will inherit from.  Niko also supports other charger types.  In case you want those later on, it would make sense to refactor the implementation also in this way.
The pulse meter is indeed https://www.niko.eu/en/article/550-00250, I have it in my installation for a long time, and I suppose it's indeed not supported by the API.  As the total counters are not neither :-( .

@Bartsmet The CocoGenericChargingstation does not expose any properties, so it is the CocoEaseeChargingstation that needs to be used. If other people that have other chargers report this I can still refactor the code.
I will create a new release including these changes.

@tijsverkoyen If you are interested, I have an Alfen EV charger and can provide the device list for it. I am not using Home Assistant, but openHAB (I developed and maintain the openHAB Niko Home Control integration). I am just following along here for ideas.
Did you get a reply on:

I also contacted Niko, as there is a new parameter HasStream on the Electrical Power property. I suspect this is a new way that allows to read realtime values, but I am not sure. But as I don't own a charging I can't see this in real life.

@tijsverkoyen If you are interested, I have an Alfen EV charger and can provide the device list for it. I am not using Home Assistant, but openHAB (I developed and maintain the openHAB Niko Home Control integration). I am just following along here for ideas.

That would be very nice! Feel free to send it to niko-ha [at] verkoyen [dot] eu.

Did you get a reply on:

I also contacted Niko, as there is a new parameter HasStream on the Electrical Power property. I suspect this is a new way that allows to read realtime values, but I am not sure. But as I don't own a charging I can't see this in real life.

Yes I have. The HasStream is an internal attribute and is only used in their internal app. So don't rely on it (yet).


Cargo compiled with wasm32-wasi as host

Describe the problem you are trying to solve

Have a version of cargo and rustc compiled to wasm32-wasi (or some other wasm arch) such that they can securely/reproducably be run cross-platform/cross-arch even if compiling malicious code.
Describe the solution you'd like

Maybe this can be done by having an alternate host ABI that includes posix_spawn as one of the provided functions? Maybe cargo could be changed to add a configure option to not require pthread_create or equivalent?
Notes

WASI doesn't currently have create_thread or posix_spawn functions iirc...posix_spawn is much easier to implement.
iirc someone got rustc to work with wasm as the host arch, I wasn't able to find it again when I looked later.

WASI posix_spawn: https://github.com/WebAssembly/WASI/issues/414

Thanks for the report, but Cargo fundamentally, as you've seen, spawns subprocesses which isn't supported with WASI yet. Furthermore Cargo does a lot of network traffic and pipe managment with subprocesses, so WASI has a bit of aways to go I think before it can support Cargo.

What would you consider the minimal additions to WASI to allow cargo to work (perhaps with some modifications to avoid threads)?
My guess:
posix_spawn
pipe
proc_wait (or async equivalent)


Cant pass a WebElement as an argument to script via executeScript

Try to do this:
driver.executeScript('return arguments[0]', this.elems[0])
where this.elems is an array of WebElement's. Result of executeScript is null.

What would be the intended result?

I do see an issue now with the code.  It should .map() all the args to their native java equivalents for node-java to access them appropriately.
@SkReD do you think you can update this?  It may have to wait till tonight before I can.

Better do it by yourself, i can try only tomorrow

@SkReD published v0.15.2 to allow this.  Let me know how it works.  Thanks!


Use Joins in Meshmodel queries

Description
This PR fixes #251

Uses joins to query Meshmodels.
Adds the constraint that each meshmodel(component and relationship) will have unique apiVersion,kind,model.name,model.version as a composite key
Notes for Reviewers

Signed commits

[ ] Yes, I signed my commits.

While policies haven't been created, yet. Their difference from relationship needs to be considered. @Revolyssup @sudo-NithishKarthik


Fix alignment of price text

Hey, only just noticed this. Hopefully I got this to you soon enough. Sometimes the item quantity text would have too many characters, that the price text below it would not appear to be right-aligned in the panel. This fixes that.
Sorry for another PR!

The price for the battlestaff in this pic is what I'm talking about

Thanks again!


Disable git when there is no workspace

Situation:

I'm working on a workspace that is on a remote file system (NFS/samba).
I have multiple displays and I want multiple vscode windows.
I know there is split window option but it simply sucks if you use it across multiple displays.
I want 2 windows opening some files in the same project/workspace

Now since whenever you open separate windows, the processes are isolated.
So to achieve 3., I need to prepare Window 1 with the workspace, and prepare Window 2 with empty workspace, then drag & drop some files from Window 1 into Window 2.
Now the issue is, Window 2 is still trying to enable git on it.  - Window 2 never bothers to run git any more
single-workspace/environment-multiple-window mode. just advanced split window which enables you really split the window out. (#10121)
'temporary settings' or 'process-scope settings' - now we have 'user settings', 'workspace settings', but we do not have 'process-scope settings'. 'process-scope settings' is quite native for classic desktop applications. This would simply allows you disable git in which window you don't want git to be enabled.

since option 2 (#10121) seems a large project, option 3 seems a large project too. Is there just any chance to implement option 1? it can be an option in settings like: git.enabled = whenWorkspaceOpened.

Great description and summary. I like the setting idea, lowest hanging fruit which would help you. Let's do that.


Update razor version in changelog

Closing out as we'll need a new insertion/version to address https://github.com/OmniSharp/omnisharp-vscode/issues/4152

@TanayParikh superceded by https://github.com/OmniSharp/omnisharp-vscode/pull/4166 ?

Yep, closing 😄


bug (modal): Fix modal focus issue

Fixed modal focus issue 1679. Now the focus will be trapped within the modal as it was desired behaviour
closes: 1679

[x] Bug fix Modal
[ ] New feature
[ ] Chore
[ ] Breaking change
[x] There is an open issue which this change addresses
[x] I have read the CONTRIBUTING document.
[x] My commits follow the Git Commit Guidelines
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

give it a try on https://deploy-preview-1718--reactstrap.netlify.com/components/modals/
when tabbing from the url bar, it is able to focus something on the page.
also, shift-tab has an issue, check out the nested example
Other than that, it looks good!

Superseded by #1941


Add documentation for data source integration in MP

We currently on have only a guide https://helidon.io/docs/latest/#/mp/guides/07_datasource, which talks about how to use hikaricp with h2 and a pointer to mysql example.
With various integration that we have, we might want to consider adding a section.

hikaricp
ucp (including using Oracle ATP and how to specify wallet using TNS_ADMIN on jdbcURL or system property or env variable), see https://blogs.oracle.com/javamagazine/fast-flexible-data-access-in-java-using-the-helidon-microservices-platform
micronaut data integration https://medium.com/helidon/helidon-with-micronaut-data-repositories-daf6ddefee0b
mongo db (we have example of mongo db with db client but not for MP. With MP, we have mysql and h2 examples as pointed out in guide)
we can also clarify various ways/properties that can be used to do this e.g. javax.sql.DataSource.* or oracle.ucp.jdbc.PoolDataSource.* and just datasource.default.* etc.

Usage of hikaricp and ucp is mentioned as part of CDI Extensions documentation

https://helidon.io/docs/latest/#/mp/extensions/02_cdi_datasource-hikaricp
https://helidon.io/docs/latest/#/mp/extensions/02_cdi_datasource-ucp

Hi @arjav-desai - These links are no longer working. I've asked @Geetha-Savithriamma to work with you on this.

the issue was filed when v2 was latest buts its v3 now so if you change “latest” in link with “v2", it still works e.g. https://helidon.io/docs/v2/#/mp/guides/07_datasource

It seems with v3 doc updates, we have consolidated following from v2 in

data
https://helidon.io/docs/v2/#/mp/guides/07_datasource
https://helidon.io/docs/latest/#/mp/extensions/02_cdi_datasource-hikaricp
https://helidon.io/docs/latest/#/mp/extensions/02_cdi_datasource-ucp
jpa
https://helidon.io/docs/v2/#/mp/guides/09_jpa
https://helidon.io/docs/v2/#/mp/jpa/01_introduction

in a single doc as https://helidon.io/docs/latest/#/mp/persistence.

However, this doc is still doesn't include

mongo db (we have example of mongo db with db client but not for MP. With MP, we have mysql and h2 examples as pointed out in guide)
we can also clarify various ways/properties that can be used to do this e.g. javax.sql.DataSource.* or oracle.ucp.jdbc.PoolDataSource.* and just datasource.default.* etc.

may be cause its JPA centric.
You can may be take the section about "Named Datasource integration" from new JPA doc and add above items to make it a new "Data" doc.

Most of the integrations have already been added in version 3: https://helidon.io/docs/latest/#/mp/persistence.
No further update is required at this point. Checked with Arjav who advised me to close the issue.


Release TextFormField focus when the user hits the hardware back button

I have a TextFormField in a flutter app and its Focus is important to the functionality of my screen. When the field has focus, I hide some elements on the page so it looks good when the keyboard is open.
When I press the back button to exit the field, the keyboard is minimized, but the field still maintains focus. So the elements I hid on the screen are still hidden. As soon as I tap out of focus, the elements come back, but I know users will get confused at why the back button did not make the elements re-appear. I know I can release the focus by requesting a new focus:
FocusScope.of(context).requestFocus(FocusNode());

But, I don't know where I can invoke this release focus logic. I thought I might be able to create an EventChannel to subscribe to the native activity onBackButtonPressed() and send back button events down the channel, but it looks like an open issue to be able to override this function in a Flutter app.
I know there is a WillPopScope widget that allows you to capture the back button event if it will exit the current ModalRoute, but I'm not sure I can use this to solve my problem because the widget of interest is a TextFormField not a ModalRoute.
Is there a way I can subscribe to the keyboard closing instead?

Asking on stack overflow as well

When I got to the end of typing out my problem, I thought of the idea of subscribing to the keyboard closing event... sure enough there is a package for that! https://pub.dev/packages/keyboard_visibility
So, I can solve my problem by using the keyboard_visibility package
import 'package:keyboard_visibility/keyboard_visibility.dart';
// ...
final FocusNode roomIdInputFocusNode = FocusNode();
final roomIdHasFocus = BehaviorSubject<bool>();
// ...
roomIdHasFocus.sink.add(false);
roomIdInputFocusNode.addListener(() {
    roomIdHasFocus.sink.add(roomIdInputFocusNode.hasFocus);
});
KeyboardVisibilityNotification().addNewListener(
    onChange: (bool visible) {
        if (!visible) roomIdHasFocus.sink.add(false);
    },
);


Release 0.13.0

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: host: nlohmann_json<3.10 must contain a space between the name and the pin, i.e. nlohmann_json <3.10

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


feat: Add password encryption

This PR contains the following changes.

New cryptutils.py that provides encryption and decryption functions
Password encryption feature (RSA using cryptography module)
Adjustment to the front-end to add the password encryption feature
Add new route to serve the public key
Refactor

This PR closes #18.

Tested this myself.


feat: otel tracing

What kind of change does this PR introduce?
Feature
What is the new behavior?
This PR introduces optional OTEL traces

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

35 of 36 (97.22%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 79.719%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/app.ts
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
12413

Relevant Lines:
15429

💛  - Coveralls


Allow API to specify request headers per operation

Some operations may require a request header (e.g. for authorization or session tracking) or take optional headers. Currently there is no way to express which request headers (and response headers likewise) are supported/required/offered by a resource's operation.
Simple way to implement this would be to add an additional parameter_location enum value 'Header' and allow operations to take parameters of this type, which will place the param on the request header.
More involved (but possibly cleaner) solution would be to add optional request_header and response_header fields to operation, which can be used to reference entries in the service's headers, like:
"header_ref": { "fields": [
  { "name": "name", "type": "string", "description": "The name of a header referenced in the service's headers section" },
  { "name": "required", "type": "boolean", "default": "false", "description": "Denotes whether or not this header is required in the request, or whether or not it is always present in the response" }
]}

makes sense. only open question before we can add support is to figure out how authorization headers should be supported as that may impact the format of per operation headers (e.g. can we avoid repeating the exact same headers on every operation)

Not sure what you mean. If every operation takes an authorization header, I think it should be documented as such and every operation should list that header.

Here's what I think this could look like: https://github.com/mbryzek/apidoc/pull/524 (PR #520 was the simple/incomplete solution)

Fixed in #520


ndimage.gaussian_filter shifts results

I just took a small test array ("a" in following code) to see what is the convolution (gaussian_filter) from a gaussian  with a peak.
I'm very surprise to get a shifted result. The maximum of the blurred image should be exactly at the same position as the maximum (single peak) from original matrix.... but it is NOT, and the shift varies with sigma and truncate parameters !
import numpy as np
from scipy import ndimage as nd

a = np.zeros((5,5))  # could be bigger, tested originally with (8,8),
a[2,2]=10

r=np.unravel_index(a.argmax(),a.shape)
print "the max should be located in " + str(r) + " for any gaussian blur"
for i in range(1,10):
    for j in range(1,6):
        r = np.unravel_index(nd.gaussian_filter(a,i,truncate=j).argmax(),a.shape)
        print "sigma=" + str(i) + " ,truncate=" + str(j)+ " max coordinate => "  + str(r)

output :
the max should be located in (2, 2) for any gaussian blur
sigma=1 ,truncate=1 max coordinate => (2, 2)
[...]
sigma=2 ,truncate=2 max coordinate => (1, 1)
sigma=2 ,truncate=3 max coordinate => (2, 2)
sigma=2 ,truncate=4 max coordinate => (2, 2)
sigma=2 ,truncate=5 max coordinate => (2, 2)
sigma=3 ,truncate=1 max coordinate => (0, 0)
sigma=3 ,truncate=2 max coordinate => (2, 2)
sigma=3 ,truncate=3 max coordinate => (1, 1)
[...]
sigma=4 ,truncate=1 max coordinate => (0, 0)
[...]
sigma=6 ,truncate=2 max coordinate => (2, 2)
sigma=6 ,truncate=3 max coordinate => (0, 0)
[...]
sigma=9 ,truncate=2 max coordinate => (0, 0)
sigma=9 ,truncate=3 max coordinate => (2, 2)
[...]
so we see a shift of (-2,-2) or (-1,-1)
with a 8x8 matrix, I also got (1,1) and (2,2)
Here are my version number :
Python : '2.7.10 (default, May 23 2015, 09:44:00) [MSC v.1500 64 bit (AMD64)]'
Numpy.version : 1.9.2
scipy.version = 0.16.0
ndimage.version : 2.0

As I needed a reliable "gaussian blur", so I made "my_gaussian_filter"
and it gives expected results.
def gauss(sig,trunc):
    x=np.arange(-sig*trunc,sig*trunc+1)
    return np.exp(-x**2/(2*sig**2))

def gauss2D(sig,trunc):
    g=gauss(sig,trunc)
    return g*np.vstack(g)

def my_gauss_filter(sig,trunc)    :
    return nd.convolve(a,gauss2D(sig,trunc))

r=np.unravel_index(a.argmax(),a.shape)
print "the max should be located in " + str(r) + " for any gaussian blur"
for i in range(1,10):
    for j in range(1,6):
        r = np.unravel_index(my_gauss_filter(i,j).argmax(),a.shape)
        print "sigma=" + str(i) + " ,truncate=" + str(j)+ " max coordinate => "  + str(r)

I tested the same small script with last (easily) available versions:
Python <IP_ADDRESS>
numpy.version.version = 1.10.4
scipy.version.version = 0.17.0
ndimage.version = 2.0
I still got this strange shift behavior.

I got my solution : use 'mode = "constant"  ' as parameter (or mode = "nearest")
By the way, I could not reproduce my proposed solution ... except by using the mode="constant" in the ndimage.convolve function


Typo in ast_models.py

https://github.com/YuanGongND/ast/blob/d338ce48b4861e419ee62c9ecad499cfd548e54b/src/models/ast_models.py#L42
:param input_fdim -> :param input_tdim

Hi there,
Yes, you are correct. I just fixed the typo. Thanks for pointing this out.
-Yuan


TypeScript TodoMVC sample in Angular2 and Nodejs

Where can I find the new TypeScript TodoMVC sample in Angular2 and Nodejs that Anders presented during Connect() 2015 @ https://www.youtube.com/watch?v=s0ecDXWvLmU

i think this is the one you are looking for: https://github.com/Microsoft/TypeScriptSamples/tree/master/angular2

Thanks Hegazy.
No, this is an old version. The TodoMVC version that @ahejlsberg presented during Connect() 2015 had a server side implementation that demonstrate using async-await with Nodejs + using Angular 2 on the client side. I really appreciate if you can post the latest TodoMVC that uses Typescript 1.7 new async-await constructs.
I am really looking for a good async-await examples with Nodejs. An end-to-end example such as TodoMVC will be perfect.
Thanks for your valuable help.

@ahejlsberg can you share your demo?
as for the async one, have you looked at https://github.com/Microsoft/TypeScriptSamples/tree/master/async


[TACHYON-1060] Add documents for space reserver

https://tachyon.atlassian.net/browse/TACHYON-1060

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5414/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5416/
Test PASSed.

@shimingfei  thanks for improving the documentation! I have left some minor comments.

@apc999 I have modified code according to your comments, Thanks!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5418/
Test PASSed.

+1 LGTM

@calvinjia
I have modified the code according to your comments except  " link space reserver with the documentation", just don't know how to do that.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/Tachyon-Pull-Request-Builder/5462/
Test PASSed.

+1 LGTM

LGTM


debug fails to load llamaindex

llamaindex should be lazily loaded

fixed by https://github.com/microsoft/genaiscript/commit/ce6ef7adbd6e0fe742abba2f0b702418123a9b77


Rowspan and Colspan

The problem with several rowspan and colspan, is fix ?
In my case, I have several rowspan and colspan in the same table, and this is fill using AngularJS, and when export, in xlsx, the table not appear in correct way.
(sorry for my english, not is very good)

I  also came across this issue(table with rowspan and colspan), any feedback on it?

This should have been fixed in v3.2.10. Please let me know as soon as possible if this is not the case.

It seems not fixed yet(rowspan didn't work as expected, and I doesn't test colspan), I used the stable version.

I ran your example in a static browser environment and I do see one major bug related to the rowspan attribute. I will fix it for the next patch release (see attached image). Thank your help with this issue.

现金 and 1980 should be in column G and H, respectively.

The new patch will likely come towards the tail-end of the week. I have a solution in the pipeline that warrants more testing before finalization/release.

I am keeping this ticket open in case the fix @ d6ca877 is not the only issue.

FYI, we are still having this issue as of v3.3.9. We are happy to provide more information, not sure what would be useful. Thanks.

We spent some more time today looking at this issue in hopes of putting together some sort of pull request.
Here's some example DOM structure that we are having issues with:

Title
TitleOne
Totals

Title
Classification

TitleOne
ClassOne
1
1

ClassTwo
1
1

Totals
2
2

It seems there are issues when building the 'rcMap' object. When encountering a rowspan, you account for the next row's column offset in the rcMap object:
if (val.hasAttribute('rowspan')) {
    for (var i = 1; i < val.getAttribute('rowspan'); i++) {
        rcMap[ir + i] = rcMap[ir + i] || {};
        rcMap[ir + i][ic] = 1
    }
}

But when calculating that next row, the first column might have a colspan, which has already been accounted for during the previous row calculations.  We added some checking for this case and added the offset to the next column:
if (val.hasAttribute('colspan')) {
    rcMap[ir] = rcMap[ir] || {};
    if (!rcMap[ir][ic]) {
      rcMap[ir][ic + 1] = val.getAttribute('colspan') - 1
    } else {
      rcMap[ir][ic + 2] = val.getAttribute('colspan') - 1
    }
}

Which fixes our export from looking like this:

To looking more correct:

We are hoping to get a better understanding of how you are using the rcMap object, so we can move to a more generic solution. This patch does not work if we were to add another dimension to our data.

   If you can merge the cell just fine

@basawyer & @nopace – I would really like to get this patched and integrated into v4.
@basawyer – any luck on your end with a patch? I just started on a dual-pointer recursive approach that may do the trick. It's slated on the [v4] channel, but as it's a bug in nature, it will also be applied to v3 as well.

Thanks again

@basawyer & @nopace – these rowspan/colspan edge cases should now be fixed as of v5.0.0-rc.1.
If this is not the case, can you please send me a sample html structure where the algorithm fails?

NOTE: v5.0.0-rc.x will remain a release candidate (rc) until this rowspan/colspan bug is resolved. At which time it will be published as a stable release.

Untitled1.txt
please help me!

@wo00421309 – thanks for the html snippet. Let me take a look and I'll see what the problem is.

can i merge the cell as the question nopace mentioned

@wo00421309 – cell merging is the next feature I'd like to introduce. In this case it looks like the rowspan ordering needs to be tracked correctly so the shift you are experiencing doesn't occur. Once this is fixed, I will have a much, much easier time adding cell merge functionality from SheetJS.

@wo00421309 – v5.0.0-rc.3 applies the appropriate fixes to resolve the aforementioned rowspan/colspan issues such as the one you highlighted. As far as cell merge functionality goes, assuming that there aren't any lingering bugs with either rowspan or colspan, this is a logic next step as far as enhancements. I created an issue specifically for this feature #69.

Multiple consecutive colspan is still broken. Thanks to @dulguun00 for pointing this out. Expect this to be fixed soon.

v5.0.0-rc.6 introduces dramatic improvements to this rowspan / colspan bug, effectively resolving it for most table constructs. There are a few exceptions, due to the complexity of the native html table parsing process, such as when the colspan or rowspan values introduce noncongruence with the row (<tr>) or column (<td> or <th>) length (e.g. nonsymetric tables).

I am using v4.0.11 and I am seeing this issue as well. Is there a workaround or a fix for this bug?

I've tested it with v5.0.0-rc.6 and I'm still facing this problem (as you can see in this pen)

I am using v5.2.0 when there are 2 rowspans consecutively it ignores the 2nd one.  Please help!!
table-rowspan.txt

Also this structure of html does not work for me too . I tested with version 5.2.0


fix(curriculum): Added 9 missing solutions to challenges in the Debugging section

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Added working solutions to the following 9 challenge files in the Debugging section.  Tested all of them locally and passed when running npm run test:curriculum.

curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/catch-arguments-passed-in-the-wrong-order-when-calling-a-function.english.md
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/catch-missing-open-and-closing-parenthesis-after-a-function-call.english.md
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/catch-misspelled-variable-and-function-names.english.md
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/catch-mixed-usage-of-single-and-double-quotes.english.md
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/catch-off-by-one-errors-when-using-indexing.english.md
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/catch-unclosed-parentheses-brackets-braces-and-quotes.english.md
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/catch-use-of-assignment-operator-instead-of-equality-operator.english.md
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/prevent-infinite-loops-with-a-valid-terminal-condition.english.md
curriculum/challenges/english/02-javascript-algorithms-and-data-structures/debugging/use-caution-when-reinitializing-variables-inside-a-loop.english.md

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Unit tests for helper classes

Improving test coverage, starting with helper classes. More to come.

Rebased, @ppitonak , @dgolovin , care to review?


Add Wally manifest file

This PR adds a Wally manifest file to the repository for the latest release of TestEZ.
Wally is a package manager for Roblox developed at Uplift Games. It's part of our initiative to create an open ecosystem of shared, accessible code and high quality tooling for Roblox developers.
With Wally, adding TestEZ to an existing Roblox project is very easy:
[package]
name = "magnalite/lets-use-testez"
version = "0.1.0"
registry = "https://github.com/UpliftGames/wally-index"
realm = "shared"

[dependencies]
TestEZ =<EMAIL_ADDRESS>
$ wally install
[INFO ] Updating package index...
[INFO ] Downloading<EMAIL_ADDRESS>
Our public Wally registry is now accepting packages from anyone who would like to publish, similar to crates.io. We would love to see you publish great open source packages like TestEZ! We've found a large portion of packages already depend on TestEZ so we've made it available on Wally as a convenience due to this demand, however it's our ambition for us to work together on supporting the open source Roblox ecosystem.
Adding this wally.toml manifest file is the first step in this direction, and makes publishing TestEZ to Wally easy!

Hi magnalite! Can you follow the CLA workflow?

I have read the CLA Document and I hereby sign the CLA


Write to log file while running daemon

Hello Team,
First of all let me thank you for your product. Looks nice so far.
However, let me ask you a question. No really an issue, but maybe luck of knowledge.
I have wrapped Workerman into Yii2 framework and I have enabled loging, so to write configured  Yii2 framework logs. Those log files are updated only when I'm stopping worker daemon.
Question - is it possible to write into the log files (no necessarily Yii2 logs) data, when the worker daemon is running, so not having those files updated at worker daemon stop?
Thank you in advance,
Vladimir

Question - is it possible to write into the log files (no necessarily Yii2 logs) data, when the worker daemon is running, so not having those files updated at worker daemon stop?

Yes.

Those log files are updated only when I'm stopping worker daemon.

I'm not familiar with the Yii framework. I guess your yii program did not enter the codes for logging before workerman stops.

Thanx for the update. Just tried myself, simple writting through fwrite on event "onmessage". Yes, it is working. So it looks like I need to dig into my framework documentation.


Slack Invite in Readme is dead

The project slack link in the read me is no longer valid. Is the slack community still active?
https://openlimitsworkspace.slack.com/join/shared_invite/zt-gdtstuma-ea2cIR_tpwavCuY5uLw1VQ#/

Last post I see in that Slack is from September 6th. Looks abandoned from my POV.

I'd also be interested in joining this Slack

Is this link working ?

Yes!


 Also updates .gitignore to ignore generated files.

Thank you this too!


FAB Items and label text not displayed properly

Hi,
Here is a screenshot of how the FAB Items look for me (on Android devices)
react-native: 0.41.2
react-native-action-button: 2.5.0

Here is where and how i used the FAB:
<View style={{ flexGrow: 1 }}>
  <ActionButton buttonColor="rgba(231,76,60,1)" position="right" >
      <ActionButton.Item buttonColor={MAINTHEMECOLOUR} title="Title" onPress={() => console.log("pressed")}>
       <Icon name="md-create" style={styles.actionButtonIcon} />
     </ActionButton.Item>
   <ActionButton.Item buttonColor='#9b59b6' title="Title 2" onPress={() => console.log("Pressed")}>
         <Icon name="md-search" style={styles.actionButtonIcon} />
     </ActionButton.Item>
 </ActionButton>
</View>

+1
Same issue here.
Thank you for taking the time to resolve this.

oh shit, that's bad

You are basically doing this ^^

Good luck

lol exactly

With 2.5.0 I had the same issue as the first screenshot, only on real devices though.
Upgrading to 2.5.1 the situation gets better... the last button is not cut, but during the animation you can see the buttons spawning up from a 10px of transparent background from the main button. And the buttons shadow is cut at the base.

@mastermoo I can confirm that 2.6.0 fixed this issue, but bounding the fix together with ripple effects means that users are forced to use TouchableNativeFeedback on Android.
In my case that is not what I need, since the ripples are on the square border of the button not on the foreground.
I think an optimal solution would allow users to opt out or ripple effects is they need to. That maybe could be achieved by having a property like useNativeFeedback true or false

Great job! Its good now!

Indeed, it's working perfectly now.
Many thanks :)

I think this broke apps for Android 4.4.2 at least think :( :( :(....


Implement replicator forced session refresh

Implement replicator session refresh based on cookie max age
Force couch_replicator_auth_session plugin to refresh the session periodically.
Normally it is not needed as the session would be refreshed when requests start
failing with a 401 (authentication) or 403 (authorization) errors. In some
cases when anonymous writes are allowed to the database and a VDU function is
used to forbid writes based on the authenticated in username, requests with an
expired session cookie will not fail with a 401 and the session will not be
refreshed.
To fix the issue using these two approaches:

Use cookie's max-age expiry time to schedule a refresh. To ensure that time
is provided in the cookie, switch the the option to enable it by default. This
handles the issue for endpoints which are updated with this commit.

For endpoints which do not put a max-age time in the cookie, use a value
that's less than CouchDB's default auth timeout. If users changed their
auth timeout value, and use VDUs in the pattern described above, and don't
update their endpoints to version which sends max-age by default, they could
adjust [replicator] session_refresh_interval_sec to their auth timeout minus
some small delay.

Of course refresh based on auth/authz failures should still works as before.
Fixes #1607
[x] Code is written and works correctly;
[x] Changes are covered by tests;
[x] Documentation reflects the changes (comment in default.ini for now, will make a separate docs repo commit)

I'm +0 on this. It doesn't properly fix the problem we introduced when we taught the replicator to acquire session cookies if the user has changed the session timeout parameter.
A better fix is for expired cookies to return a 401 rather than silently fall back to the next auth handler. Since that is a profoundly backward incompatible change it would need to be opt-in.
The replicator would do POST /_session?hard_expire=true to acquire a session cookie.
The server, when presented with an expired cookie returned by that method will throw an unauthorized error, which in turn forces the replicator to acquire a fresh one.
This should be done in addition to a periodic refresh ahead of the expiration to avoid stalling replication progress during the refresh.
I also note that the session cookie response header tells us exactly when it expires, and this value, not a hardcoded 550 should be used to determine when to pre-emptively refresh.

Good points. Yeah a hard cookie expire would be an ideal solution. And I had also forgotten about the expired header which would still be better than this solution.

@nickva This is blocking 2.3.0's release.
How about we always put the Expires value into the Set-Cookie header, regardless of allow_persistent?

@rnewson what do you think. Put Expires + Max-Age in the cookie by default? Then to deal with the exiting pre-2.3.0 endpoints or if expires not found use the default value with a fudge factor (so say 550 sec). Not as good as the hard_expires but better what what we have now? And of course, expiring auth failure trigger refresh just like they do now.

@nickva did you ever hear back from @rnewson or anyone else who can +1 this other than me?


Demonstrate Circt Intrinsic

Contributor Checklist

[ ] Did you add Scaladoc to every public function/method?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[ ] Did you add appropriate documentation in docs/src?
[ ] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[ ] Did you add text to be included in the Release Notes for this change?

Type of Improvement

backend code generation
new feature/API

API Impact
This a self-contained utility function.  This makes some minimal infrastructure to produce circt intrinsics.  The particular one used as an example is sizeof which allows querying (from the design) of the size of a type after width inference runs.
Backend Code Generation Impact
This targets specific Circt intrinsics allowing new code gen opportunities, but only when explicitly used in a design.
Desired Merge Strategy

Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you do one of the following when ready to merge:

[ ] Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
[ ] Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The specific sizeOf intrinsic however is circt specific and thus should live under the circt package.

And I'm still questioning why it belong anywhere except in the tests of intrinsics 🤷♀

And I'm still questioning why it belong anywhere except in the tests of intrinsics

That would also be fine with me. I just think that if something is going to be part of the firrtl spec, it should be supported by any hypothetical firrtl compiler and thus does not need to be prefixed by circt.

And I'm still questioning why it belong anywhere except in the tests of intrinsics 🤷♀

Because it's already supported in CIRCT. 😉  I believe there was some interest in using this for parameterization experiments and/or to enforce checks on separably compiled units. (I.e., this was intended to be used, not just a toy demonstration.)

However, I still think the packages are backwards. Intrinsics are going to be a standard firrtl feature, thus they should live under the standard chisel3 package. The specific sizeOf intrinsic however is circt specific and thus should live under the circt package.

Your point about putting the annotation under a chisel3 package is reasonable. I'd suggest chisel3.annotations.Intrinsic or firrtl.annotations (as long as there are no conflicts). Using firrtl.annotations is easier once SFC infra is mono-repoed under Chisel.
For the sizeOf intrinsic, the question that has to be answered is: Does this go into the FIRRTL spec?
If this does, then it's fine to put this under some chisel3 area (again, a firrtl area would be better). If it does not, then there is some question of where to put it. Using a circt package seems fine.

For the sizeOf intrinsic, the question that has to be answered is: Does this go into the FIRRTL spec?

We can always move it as soon as a PR to add it to the FIRRTL spec is accepted.

We can always move it as soon as a PR to add it to the FIRRTL spec is accepted.

The question though is: If it is part of the FIRRTL spec, shouldn't it be a Primitive Operation instead of an intrinsic?

We can always move it as soon as a PR to add it to the FIRRTL spec is accepted.

Both of these are living projects and one doesn't have to change before the other. There have been tons of features that went into Chisel first which made there way into the FIRRTL spec later. Considering this is effectively just another annotation, I don't see a big problem with moving Chisel first and considering changes to package names later.

The question though is: If it is part of the FIRRTL spec, shouldn't it be a Primitive Operation instead of an intrinsic?

It depends.
The point of intrinsics is that they serve specialized use cases without having to move the FIRRTL spec to be the set of all possible operations that anybody could want. It is also reasonable to add primitive operations when they clearly make sense within the bounds of digital logic.
Something like sizeOf is complicated as it is outside the bounds of normal digital logic and may not have a well-defined lowering for all backends, e.g. VHDL. (My Google-fu is indicating that VHDL has attributes for encoding size and does have system functions for doing this like Verilog.)
Because of this, it is reasonable for the spec to define certain intrinsics as opposed to leaving them entirely to each compiler to define.
That said, all this can change in the future. The spec and Chisel are flexible and can be updated rapidly. There is not an assumption that we will get this right the first (or second, or third!) time. (This is part of the Chisel 5 push in the roadmap is to enable faster development with the expectation that we may make mistakes.)

We can always move it as soon as a PR to add it to the FIRRTL spec is accepted.

The fixation on the firrtl spec status of sizeof is misplaced.  The point of intrinsics is to provide a type-safe, defined extension mechanism to the language for features which cannot be implemented by libraries.  This requires a standard way to define them.  Right now, this is encoded with extmodule and an annotation.  Intrinsics will come to firrtl as first class things at which point the chisel implementation can switch to using them.  Intrinsics are not yet part of firrtl and it behooves everyone to use a light weight, backwards compatible implementation, like this, to get experience with them before pushing them into the standard.
As for what the set of intrinsics which can be generated are, that is up to the implementations.  Right now this set for Circt is 4, and for SFC is 0.  Regardless, the output of chisel for an intrinsic is well defined, even if the backend doesn't support it.  It is also fine if multiple backends pick up support for the same intrinsic, even if it was originally defined by a different backend.  Clang has extensive support for gcc intrinsics, for example.  sizeof is useful, and probably will be folded into a primitive operation at some point, but let's see how the meta-programming capabilities play out before committing to that as a part of the language.

Intrinsics are going to be a standard firrtl feature, thus they should live under the standard chisel3 package.

And when they do, the support should go there.  For now, they are implemented in a circt-specific annotation which is not supported by SFC.  Long term they should be part of the spec, but while they are target specific, it seems sensible to put the annotation string in that target.
When intrinsics are part of the spec, chisel will port over and generate them directly and not depend on this annotation at all.  At that point, this code will be removed.

I still would like to have Intrinsic.scala moved into a chisel3 (sub)package. Since intrinsics are not a circt specific thing, but something that has been standardized. So I see no reason for it to reside in a special circt package.

Please provide a link to the section of the firrtl spec in which they appear.

Please provide a link to the section of the firrtl spec in which they appear.

Oh, I did not realize that intrinsic hasn't made it in yet. Thanks.


Added Dynamically Created buttons for filters on Map points

Added Dynamically generating buttons that will show more or less filters for source_code depending on the information that it is given

Hey @holdenliu!
So sorry I did not notice this until now. You should create a pull request against the original WeVote server, not CTI-CodeDay's fork.

Hi, @tylermenezes, could you help me and my team to make this happen? @JuanSuria1 @MarianoMirandaHerrera

What help do you need?


Show troubleshoot dialog on sharer's side. Keep error flow within popup dialog.

Fixes: https://github.com/uProxy/uproxy/issues/1203
Toasts now float appropriately relative to getting/status bars, e.g.
No statuses:

One status:

If width is <320px the toast sticks to the sides:

I can take this out if it looks weird.
Updated error flow
If getting fails:

Clicking No or the X will dismiss the dialog. Clicking Yes opens:

Clicking Yes opens feedback, with the logs option pre-checked:

Please let me know how copy/style can be improved!
Right now the question icon, "More info" and "Privacy policy" all link to the FAQ about logs. @gwpenn is writing up new content!

So, I'm not especially thrilled with the structure here, but I think this is the best way to get things out now.  Having a variable in the background page that we make decisions on (and try to clear ourselves with a function call from Polymer that gets fired when it changes) does not seem like the cleanest-possible solution.  I'm going to ignore that for now though since I do not think it is a priority at the moment.

Reviewed files:

bower.json @ r1
src/generic_core/remote-connection.ts @ r1
src/generic_core/remote-instance.ts @ r1
src/generic_ui/polymer/instance.ts @ r1
src/generic_ui/polymer/link.html @ r1
src/generic_ui/polymer/root.html @ r1
src/generic_ui/polymer/root.ts @ r1
src/generic_ui/polymer/troubleshoot.html @ r1
src/generic_ui/polymer/troubleshoot.ts @ r1
src/generic_ui/scripts/ui.ts @ r1
src/uproxy.ts @ r1

src/generic_core/remote-connection.ts, line 70 [r1] (raw file):
Can you either fix the lack of cleanup for a previous sharing state or add a bug to that effect?  Thanks.

src/generic_core/remote-instance.ts, line 179 [r1] (raw file):
I could be mistaken, however, it looks like calling startShare_ twice with the second attempt succeeding will still cause the connection to be killed when the first timeout expires.  Can you check on that and either fix or add a bug?  Thanks.

src/generic_ui/polymer/root.ts, line 128 [r1] (raw file):
I think this would make a bit more sense as stringMatches

src/generic_ui/polymer/troubleshoot.html, line 73 [r1] (raw file):
Can you add this styling to the text you are putting within uproxy-faq-link instead of using /deep/?  I think it will work out a bit cleaner.

src/generic_ui/polymer/troubleshoot.html, line 110 [r1] (raw file):
This should probably be

src/generic_ui/polymer/troubleshoot.html, line 130 [r1] (raw file):
Extra line

src/generic_ui/polymer/troubleshoot.ts, line 19 [r1] (raw file):
can you add natDescription and natType to the object originally, just to make it obvious it is an expected field?
Also, i think natImpact might be a better name?  Something other than description though.  I'd expect description to mean what natType currently is.

Comments from the review on Reviewable.io

src/generic_core/remote-connection.ts, line 70 [r1] (raw file):
Do you mean how rtcToNet should be reset?

src/generic_core/remote-instance.ts, line 179 [r1] (raw file):
Done.

src/generic_ui/polymer/root.ts, line 128 [r1] (raw file):
Done.

src/generic_ui/polymer/troubleshoot.html, line 73 [r1] (raw file):
Done.

src/generic_ui/polymer/troubleshoot.html, line 110 [r1] (raw file):
Done.

src/generic_ui/polymer/troubleshoot.html, line 130 [r1] (raw file):
Done.

src/generic_ui/polymer/troubleshoot.ts, line 19 [r1] (raw file):
Done.

Comments from the review on Reviewable.io

still need to fix tests (broken by new functions in remote-connection.ts), but otherwise good to go. ptal, thank you!!!!

Reviewed files:

src/generic_core/remote-connection.ts @ r4
src/generic_core/remote-instance.spec.ts @ r4
src/generic_core/remote-instance.ts @ r4
src/generic_ui/polymer/instance.ts @ r3
src/generic_ui/polymer/root.html @ r3
src/generic_ui/polymer/root.ts @ r3
src/generic_ui/polymer/troubleshoot.html @ r2
src/generic_ui/polymer/troubleshoot.ts @ r2
src/generic_ui/scripts/ui.ts @ r3
tscommand-5442879f.tmp.txt @ r3

src/generic_core/remote-connection.ts, line 35 [r4] (raw file):
sharingReset

src/generic_core/remote-connection.ts, line 83 [r4] (raw file):
I would prefer to treat this as an error case to try to maintain consistency with the startGet method.

src/generic_core/remote-connection.ts, line 106 [r4] (raw file):
You can leave off the return statement here.

src/generic_core/remote-connection.ts, line 127 [r4] (raw file):
If you are going to have a method like this, I'd prefer that you have a call to it in the class constructor instead of having the initial initialization be through a different method.

src/generic_core/remote-instance.ts, line 171 [r4] (raw file):
This can be left as return;

src/generic_core/remote-instance.ts, line 176 [r4] (raw file):
This feels like it's messing with internal state of the connection.  Idea (pseudocode):
if signalFromRemote.type === WebRtc.SignalType.Offer
  if existingConnection
    stopped = @connection_.stopShare();
  else
    stopped = Promise.resolve();
  stopped.then () =>
    @startShare_()
    @onceConnectionReadyForOffer = @connection.onceReadyForOffer # renamed connection_.rtcToNetCreated to onceReadyForOffer to avoid requiring knowledge of internal state to use the class
    return

  return @onceConnectionReadyForOffer.then () =>
    @connection_.handleSignal ...

Oh, actually, I looked below and saw what startShare_ does.  I think you could move the entire first chunk of the code to that function.  Still completely disagree on being able to call a function that exists solely to twiddle internal state bits from outside the class, calling it right before you create a new RtcToNet object seems like a better idea.

src/generic_core/remote-instance.ts, line 218 [r4] (raw file):
I think it would be a better idea to check whether there is an existing connection before calling this.

src/generic_core/remote-instance.ts, line 228 [r4] (raw file):
I think it would actually make more sense in this case to use .then(fn1, fn2) instead of .then(fn1).then(fn2).  Not that it should produce any actual difference, but I think it conveys the intention a bit better.

src/generic_core/remote-instance.ts, line 238 [r4] (raw file):
Can you log a warning here also?

src/generic_core/remote-instance.ts, line 240 [r4] (raw file):
I think an extra blank line before the if would look better.

src/generic_core/remote-instance.ts, line 245 [r4] (raw file):
This should be moved to a helper function somewhere so that you are sure to get consistent behaviour between when you first initialize the class and when you do reset it.

src/generic_core/remote-instance.ts, line 274 [r4] (raw file):
I think you want to remove this function and just use clearTimeout(timeout) directly

src/generic_ui/polymer/instance.ts, line 31 [r4] (raw file):
This feels a bit wrong, a couple ideas I think might be better.

Signal what has happened: In this case, just rename it getting-state-changed or have both started-trying-to-get and stopped-trying-to-get.  That feels a lot better than having a specific instruction to a higher-level object of what it should do.
Just change a property: I think if you just added: tryingToGet as an attribute of the element, you could just attach a variable to it (I'm not positive on this)

Anyways, I think both of those would feel a bit better than emitting which feels like a command.

Comments from the review on Reviewable.io

Sorry for all the comments - basically everything looks good, just some small things about variable names, etc..  Then should be good to merge!

src/generic_core/remote-connection.ts, line 35 [r4] (raw file):
Done.

src/generic_core/remote-connection.ts, line 83 [r4] (raw file):
Done.

src/generic_core/remote-connection.ts, line 106 [r4] (raw file):
Done.

src/generic_core/remote-connection.ts, line 127 [r4] (raw file):
It's initialized when it's declared and this function is called to reset it. Should I move the initial declaration inside the constructor?

src/generic_core/remote-instance.ts, line 171 [r4] (raw file):
Done.

src/generic_core/remote-instance.ts, line 218 [r4] (raw file):
Done.

src/generic_core/remote-instance.ts, line 228 [r4] (raw file):
Done.

src/generic_core/remote-instance.ts, line 238 [r4] (raw file):
Done.

src/generic_core/remote-instance.ts, line 240 [r4] (raw file):
Done.

src/generic_core/remote-instance.ts, line 245 [r4] (raw file):
Done.

src/generic_core/remote-instance.ts, line 274 [r4] (raw file):
Done.

src/generic_ui/polymer/instance.ts, line 31 [r4] (raw file):
Oh no! I've checked this in here https://github.com/uProxy/uproxy/pull/1248
(This might be reviewable getting confused.) Do you mind opening an issue to refactor this?

Comments from the review on Reviewable.io

ptal, thank you!!!

:+1:

Reviewed files:

src/generic_core/remote-connection.ts @ r6
src/generic_core/remote-instance.ts @ r7
src/generic_ui/polymer/instance.ts @ r5
src/generic_ui/polymer/root.html @ r5
src/generic_ui/polymer/root.ts @ r5

src/generic_core/remote-connection.ts, line 127 [r7] (raw file):
Can you rename this to something that does not mention RtcToNet?  It feels like we're showing you a turtle we don't need to.

Comments from the review on Reviewable.io

src/generic_core/remote-connection.ts, line 127 [r7] (raw file):
Done.

Comments from the review on Reviewable.io


layout error

windows 10 64bit
chrome 64.0.3282.186 64bit

...seems that some static files is still old, problem is fixed after i refresh.


init does not understand --solution

I seem to recall you having a few ideas on how to best do solution stuff? Did you say xbuild had some classes for it?

I haven't used it, but I am aware of https://github.com/mono/mono/blob/master/mcs/tools/xbuild/SolutionParser.cs. It looks complicated, and takes a dependency on MSBuild. Paket rolls its own minimal stuff: https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/SolutionFile.fs. If we just want to add projects maybe we should roll our own simple thing like that. I have to admit I think it isn't that important because the FSAC-using editors don't care about solution files, and if you are using an IDE, then you can easily add the project to the solution using that interface.

Quite a few projects use sln files as the build target so I think it would still be nice to have the option. Not for a first release though. Let's take the argument out of the utility for now.

I agree that we should have it in the end.


Dynamic Slope with 0 values

Apologies if this isn't an issue and I have just misunderstood workings.
If I provide a chart with data that contains a value of 0 and have the dynamicSlope enabled then the chart fails to fully draw and logs many a console error.

This (original) issue was duplicated by #86. It should no longer be a problem. Sorry for the extreme lack of response.


noproc error when call to gen_server2:call(false, {add_route,Topic,<0.685.0>}, infinity)

Hi @erylee, I have strange error, when I try to subscribe to MQTT topic with emqttd 0.14.0 or 0.15.0 on the AWS t2.micro
16:11:36.872 [error] gen_server emqttd_pubsub_1 terminated with reason: no such process or port in call to gen_server2:call(false, {add_route,<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,<0.685.0>}, infinity)
16:11:36.872 [error] CRASH REPORT Process emqttd_pubsub_1 with 0 neighbours exited with reason: no such process or port in call to gen_server2:call(false, {add_route,<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,<0.685.0>}, infinity) in gen_server2:terminate/3 line 1151
16:11:36.873 [error] Supervisor pubsub_pool_sup had child {emqttd_pubsub,1} started with emqttd_pubsub:start_link(pubsub, 1, #Fun<emqttd_pubsub_sup.2.36068814>, []) at <0.196.0> exit with reason no such process or port in call to gen_server2:call(false, {add_route,<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,<0.685.0>}, infinity) in context child_terminated
16:11:36.873 [error] gen_server <0.685.0> terminated with reason: {{noproc,{gen_server2,call,[false,{add_route,<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,<0.685.0>},infinity]}},{gen_server2,call,[<0.196.0>,{subscribe,{<<"aid-0ef8f522-cc23-11e5-9a3d-94de80a3f30e">>,<0.685.0>},[{<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,2}]},infinity]}}
16:11:36.873 [error] CRASH REPORT Process <0.685.0> with 1 neighbours exited with reason: {{noproc,{gen_server2,call,[false,{add_route,<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,<0.685.0>},infinity]}},{gen_server2,call,[<0.196.0>,{subscribe,{<<"aid-0ef8f522-cc23-11e5-9a3d-94de80a3f30e">>,<0.685.0>},[{<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,2}]},infinity]}} in gen_server2:terminate/3 line 1151
16:11:36.874 [error] Supervisor emqttd_session_sup had child session started with {emqttd_session,start_link,undefined} at <0.685.0> exit with reason {{noproc,{gen_server2,call,[false,{add_route,<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,<0.685.0>},infinity]}},{gen_server2,call,[<0.196.0>,{subscribe,{<<"aid-0ef8f522-cc23-11e5-9a3d-94de80a3f30e">>,<0.685.0>},[{<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,2}]},infinity]}} in context child_terminated
16:11:36.874 [error] Supervisor 'esockd_connection_sup - <0.563.0>' had child connection started with emqttd_client:start_link([{packet,[{max_clientid_len,1024},{max_packet_size,65536}]},{client,[{idle_timeout,20}]},{session,...},...]) at <0.680.0> exit with reason {{noproc,{gen_server2,call,[false,{add_route,<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,<0.685.0>},infinity]}},{gen_server2,call,[<0.196.0>,{subscribe,{<<"aid-0ef8f522-cc23-11e5-9a3d-94de80a3f30e">>,<0.685.0>},[{<<"mobile/secure/input/21a4816e-cc23-11e5-b505-06777b4a51b9">>,2}]},infinity]}} in context connection_crashed
16:11:36.874 [debug] Supervisor pubsub_pool_sup started emqttd_pubsub:start_link(pubsub, 1, #Fun<emqttd_pubsub_sup.2.36068814>, []) at pid <0.687.0>

But on my local machine it works fine. Could you please help me, thanks.

Hi @Prots, please 'grep crasher log/*'. It seems some services crashed when the broker started.
BTW, we could discuss the issue by Skype: feng.emqtt.io

Crasher log is empty after start.
The AWS machine is empty, without Erlang. I've just copy release from my workstation and try to run.
With sudo or without - the result is same: start OK, but when try to subscribe - get an error listed below.

Thanks, @erylee
The issue was with
%% PubSub
        {pubsub, [
            %% default should be scheduler numbers
             {pool_size, 2}
        ]},

Just set {pool_size, 2} if you use one core server.


MWPW-129539 : Update file overwrite logic during copy (COPY action)

Link to the ticket: https://jira.corp.adobe.com/browse/MWPW-129539
The PR does the following:
Right now, in copy action, saveFile() is called if the file exists at the destination. saveFile() makes several calls in order to handle locked files. The updated code in this PR calls saveFile() only if the file is locked or the folder is absent at the destination. Otherwise, it directly copies the file. This reduces the number of calls significantly.
Test URLs:
Before: https://main--milo--adobecom.hlx.page/tools/floodgate/index.html?project=milo--adobecom&referrer=https%3A%2F%2Fadobe.sharepoint.com%2F%3Ax%3A%2Fr%2Fsites%2Fadobecom%2F_layouts%2F15%2Fdoc2.aspx%3Fsourcedoc%3D%257BB2136347-CE65-470B-842E-C1E55C7C86A4%257D%26file%3DfileOverwrite.xlsx%26action%3Ddefault%26mobileredirect%3Dtrue%26cid%3D9f332e29-5a13-43a3-b2d7-fe2b630f2c13
After: https://main--milo--nethraasivakumar.hlx.page/tools/floodgate/index.html?project=milo--adobecom&referrer=https%3A%2F%2Fadobe.sharepoint.com%2F%3Ax%3A%2Fr%2Fsites%2Fadobecom%2F_layouts%2F15%2FDoc.aspx%3Fsourcedoc%3D%257BB2136347-CE65-470B-842E-C1E55C7C86A4%257D%26file%3DfileOverwrite.xlsx%26action%3Ddefault%26mobileredirect%3Dtrue%26cid%3D9f332e29-5a13-43a3-b2d7-fe2b630f2c13

The results from tests show that the number of calls required using the new logic are significantly lower than the current milo main logic.


Better name for 'org.gradlex.java-ecosystem-capabilities-base'

Also register an ID for that plugin

...and reconsider if we want/need to different plugins and extensions for the resolution part as the logging plugin does nothing now unless you explicitly configure it anyway.

During the team meeting on Mar 15th, we discussed calling the base plugin org.gradlex.jvm-ecosystem-conflict-detection and the DSL plugin org.gradlex.jvm-eosystem-conflict-resolution


Firebase storage App check error - No App Check token for request.

Hello, I am using Firebase storage. And when I log in from multiple devices, I'm testing the output of the data that the user has saved. The Android emulator and iOS simulator are now logged in as one id to proceed with the test.
The problem occurs here. Firebase firestore loads data without problems, while attempting to import a saved image results in the following error:
W/NetworkRequest(13036): No App Check token for request.
After searching for a long time, I concluded that this happens in App check plugin. But I'm...
https://firebase.flutter.dev/docs/app-check/overview
I've written everything that this official document requires, but the problem hasn't been solved. The biggest problem is that the local debug token is not output. Since then, I have removed the App check plugin and deleted the contents created from all files, but still the same error is still output.
Is there a way to solve this problem? Please help me.

Hi @randomizedlife01
That is just a warning and should not affect the functionality.
Could you please provide your flutter doctor -v and flutter pub deps -- --style=compact?
It would also be helpful if you could provide a minimal complete reproducible code sample.
Thank you

@markusaksli-nc is correct, just a warning log. Nothing to action here I believe.


topic-6830

fixes above topic

@mukoyamak-isao @masuichig Please review. Thanks!

@oshimas
is this fix need merge into master?

@oshimas LGTM about the changes 👍