Webgpu support

Objective

Support WebGPU
alternative to #5027 that doesn't need any async / await
fixes #8315

Solution
For async renderer initialisation

Update the plugin lifecycle:

app builds the plugin

calls plugin.build
registers the plugin

app starts the event loop
event loop waits for ready of all registered plugins in the same order

returns true by default

then call all finish then all cleanup in the same order as registered
then execute the schedule

In the case of the renderer, to avoid anything async:

building the renderer plugin creates a detached task that will send back the initialised renderer through a mutex in a resource
ready will wait for the renderer to be present in the resource
finish will take that renderer and place it in the expected resources by other plugins

other plugins (that expect the renderer to be available) finish are called and they are able to set up their pipelines

cleanup is called, only custom one is still for pipeline rendering

For WebGPU support

update the build-wasm-example script to support passing --api webgpu that will build the example with WebGPU support
there is a bug currently on wgpu side for WebGPU: https://github.com/gfx-rs/wgpu/issues/3430. Using the hack of deleting code in the generated JS for dropObject can be used to test if it works

There are currently a lot of errors in Bevy pipelines, but 2d examples are working:

(build with RUSTFLAGS="--cfg=web_sys_unstable_apis" cargo build --release --target wasm32-unknown-unknown --example sprite  --no-default-features --features bevy_winit,png,bevy_asset,bevy_core_pipeline,bevy_sprite)
most errors seems to be:
Sample type TextureSampleType::Float for multisampled texture bindings was TextureSampleType::Float.
 - While validating entries[17]
 - While validating [BindGroupLayoutDescriptor "mesh_view_layout_multisampled"]
 - While calling [Device].CreateBindGroupLayout([BindGroupLayoutDescriptor "mesh_view_layout_multisampled"]).

stencilLoadOp is (LoadOp::Load) and stencilStoreOp is (StoreOp::Store) when stencilReadOnly (0) or the attachment ([TextureView of Texture "view_depth_texture"]) has no stencil aspect.
 - While validating depthStencilAttachment.
 - While encoding [CommandEncoder].BeginRenderPass([RenderPassDescriptor "main_opaque_pass_3d"]).

stencilLoadOp is (LoadOp::Load) and stencilStoreOp is (StoreOp::Store) when stencilReadOnly (0) or the attachment ([TextureView "directional_light_shadow_map_array_texture_view" of Texture "directional_light_shadow_map_texture"]) has no stencil aspect.
 - While validating depthStencilAttachment.
 - While encoding [CommandEncoder].BeginRenderPass([RenderPassDescriptor "shadow pass directional light 0 cascade 0"]).

and a few others... here is the complete log: localhost-1681050709856.log

Changelog

Plugin::setup has been renamed Plugin::cleanup
Plugin::finish has been added, and plugins adding pipelines should do it in this function instead of Plugin::build

Yeeeeeeeeaaaaahhh! Much excite! :) I’ll take a look at the errors if no one else beats me to it. And you’re welcome to.

Rather than a finish lifecycle, would it make sense to have a renderer specific one to simplify the thinking around "where do I put what code".
impl RenderPlugin for MyPlugin {
  fn render_app(&self, mut render_app: &mut App) {
    // put code modifying render app here.
  }

  fn extract_app(&self mut extract_app: &mut App) {
    // put code modifying extract app here.
  }
}

you could not add the render and extract app until after the renderer is ready, to make it 100% clear to not modify the render app in the build function.

Rather than a finish lifecycle, would it make sense to have a renderer specific one to simplify the thinking around "where do I put what code".

Sounds good to me, to have a RenderPlugin "specialisation" of the general Plugin that would automatically plug the correct methods with the correct app at the correct step.
I'll wait for more feedback on the API which is definitely open to discussion

Yesssssss well done! This definitely seems like the better path. I'm stoked we don't need to async-ify the entire plugin api. I'll give the pipeline / render app init apis some thought, but I'm on board for the general direction.
We might even want to skip blocking on the "ideal render init api design" and do that in a follow up pr. It would be nice to get this in peoples' hands asap so we can iron out the kinks and capitalize on the "WebGPU release hype".

Completely agree on not getting hung up too much on render app init api for this PR. It's a good discussion to have, and this PR is about making WebGPU go. :)

stencilLoadOp errors are now fixed on wgpu trunk
remaining:
Sample type TextureSampleType::Float for multisampled texture bindings was TextureSampleType::Float.
 - While validating entries[17]
 - While validating [BindGroupLayoutDescriptor "mesh_view_layout_multisampled"]
 - While calling [Device].CreateBindGroupLayout([BindGroupLayoutDescriptor "mesh_view_layout_multisampled"]).

[Invalid BindGroupLayout "mesh_view_layout_multisampled"] is invalid.
 - While validating [BindGroupDescriptor "mesh_view_bind_group"] against [Invalid BindGroupLayout "mesh_view_layout_multisampled"]
 - While calling [Device].CreateBindGroup([BindGroupDescriptor "mesh_view_bind_group"]).

[Invalid PipelineLayout] is invalid.
 - While calling [Device].CreateRenderPipeline([RenderPipelineDescriptor "gizmo_3d_pipeline"]).

[Invalid RenderPipeline "gizmo_3d_pipeline"] is invalid.
 - While encoding [RenderPassEncoder "main_opaque_pass_3d"].SetPipeline([Invalid RenderPipeline "gizmo_3d_pipeline"]).

[Invalid PipelineLayout] is invalid.
 - While calling [Device].CreateRenderPipeline([RenderPipelineDescriptor "pbr_opaque_mesh_pipeline"]).

[Invalid PipelineLayout] is invalid.
 - While calling [Device].CreateRenderPipeline([RenderPipelineDescriptor "pbr_alpha_blend_mesh_pipeline"]).

and a lot of unhelpful
[Invalid CommandBuffer] is invalid.
    at ValidateObject (..<URL>)
    at ValidateSubmit (..<URL>)

which I'm hoping will be fixed by fixing other issues

Fixed now, the flight helmet can be displayed 🎉
There is an issue with gamma correction, trying to find it

Incorrect colors should be because of the TODO left in the code here.
See this comment on the wgpu 0.15 update PR: https://github.com/bevyengine/bevy/pull/7356#issuecomment-1404610032.
It should be the same surface format issue as with Nvidia + Wayland.

fixed too!

Awesome! Well done @mockersf ! :)

Nice! I can confirm that fixes Nvidia + Wayland (and probably some other hardware/software combos) as well : )

Nice! I can confirm that fixes Nvidia + Wayland (and probably some other hardware/software combos) as well : )

Ho that's a nice side effect 😄 DO you know if there are issues opened?

#7318 for Nvidia + Wayland
#2374 seems similar but for Intel iGPUs on either X11 or Wayland

thanks! let's wait for this to be merged so someone can check for the two others.
with https://github.com/gfx-rs/wgpu/pull/3689 and a small workaround in Bevy, bloom also works 🎉

every example I tried seems to work now, except compute_shader_game_of_life because it uses a read/write texture of format Rgba8Unorm which is not yet supported (https://github.com/gpuweb/gpuweb/issues/1772 and https://github.com/gpuweb/gpuweb/issues/3838)

With #8446 merged and wgpu updated to 0.16, this is now ready 🎉

Should webgpu be the default? It's the easiest way to do it through rust features, and adding one to target webgl2 instead.
It would probably be possible to keep webgl2 the default, but that would mean needing to disable default features to target webgpu.

Should webgpu be the default? It's the easiest way to do it through rust features, and adding one to target webgl2 instead. It would probably be possible to keep webgl2 the default, but that would mean needing to disable default features to target webgpu.

I think WebGL2 should be the default until WebGPU is more widely supported. Making it harder to target WebGPU (by requiring disabling default features) while it is still rolling out seems very reasonable to me. The alternative (forcing users onto WebGPU by default before it is widely supported) seems worse to me.


Sanitizer + omp backend = undefined reference during linking

Hi,
I just came accros this weirdness, and after some cleaning, this simple main create an undefined symbol during linking
#include <sycl/sycl.hpp>

int main() {

    sycl::queue queue;

    queue.submit([&] (sycl::handler& cgh) {

        cgh.parallel_for(sycl::nd_range<1>(32 , 32),[=] (sycl::nd_item<1> item) {

            size_t local_id = item.get_local_id(0);
            size_t global_id = item.get_global_id(0);

            item.barrier(sycl::access::fence_space::local_space);

        });
    });

    return 0;
}

The following compile command :
./sycl_cpl/hipSYCL/bin/syclcc -std=c++17 -g -fsanitize=address\
    --hipsycl-config-file=./sycl_cpl/hipSYCL/etc/hipSYCL/syclcc.json\
    --hipsycl-targets='omp' --hipsycl-platform=cpu  test.cpp -o out

gives:
/usr/bin/ld: /tmp/test-61dbfd.o: in function `void hipsycl::glue::omp_dispatch::iterate_nd_range_omp<1, main::$_0::operator()(hipsycl::sycl::handler&) const::{lambda(hipsycl::sycl::nd_item<1>)#1}>(main::$_0::operator()(hipsycl::sycl::handler&) const::{lambda(hipsycl::sycl::nd_item<1>)#1}, hipsycl::sycl::id<1> const&&, hipsycl::sycl::range<1>, hipsycl::sycl::range<1>, hipsycl::sycl::id<1>, unsigned long, void*, std::function<void ()>&)':
......./hipSYCL/bin/../include/hipSYCL/glue/omp/omp_kernel_launcher.hpp:235: undefined reference to `__hipsycl_local_id_x'
/usr/bin/ld: ......./hipSYCL/bin/../include/hipSYCL/glue/omp/omp_kernel_launcher.hpp:235: undefined reference to `__hipsycl_local_id_x'

removing the -fsanitize=address solve the issue.
Note : i'm using the default config for hipsycl (commit 56b6c1f4198aced999a4199b272790a6e15adabe) :
{
  "version-major" : "0",
  "version-minor" : "9",
  "version-patch" : "3",
  "plugin-llvm-version-major" : "14",
  "plugin-with-cpu-acceleration" : "true",
  "default-clang"     : "/usr/bin/clang++",
  "default-nvcxx"     : "NVCXX_COMPILER-NOTFOUND",
  "default-platform"  : "cuda",
  "default-cuda-path" : "/opt/cuda",
  "default-gpu-arch"  : "",
  "default-cpu-cxx"   : "/usr/bin/c++",
  "default-rocm-path" : "/opt/rocm",
  "default-use-bootstrap-mode" : "false",
  "default-is-dryrun" : "false",
  "default-use-accelerated-cpu" : "true",
  "default-clang-include-path" : "/usr/lib/clang/14.0.6/include/..",
  "default-sequential-link-line" : "-L/usr/lib -lboost_context -lboost_fiber -Wl,-rpath=/usr/lib",
  "default-sequential-cxx-flags" : "-I/usr/include -D_ENABLE_EXTENDED_ALIGNED_STORAGE",
  "default-omp-link-line" : "-L/usr/lib -lboost_context -lboost_fiber -Wl,-rpath=/usr/lib -fopenmp",
  "default-omp-cxx-flags" : "-I/usr/include -fopenmp -D_ENABLE_EXTENDED_ALIGNED_STORAGE",
  "default-rocm-link-line" : "-Wl,-rpath=$HIPSYCL_ROCM_PATH/lib -Wl,-rpath=$HIPSYCL_ROCM_PATH/hip/lib -L/opt/rocm/lib -L/opt/rocm/hip/lib -lamdhip64",
  "default-rocm-cxx-flags" : "-isystem $HIPSYCL_PATH/include/hipSYCL/std/hiplike -isystem /usr/lib/clang/14.0.6/include/.. -U__FLOAT128__ -U__SIZEOF_FLOAT128__ -I$HIPSYCL_ROCM_PATH/include -I$HIPSYCL_ROCM_PATH/include --rocm-device-lib-path=$HIPSYCL_ROCM_PATH/amdgcn/bitcode --rocm-path=$HIPSYCL_ROCM_PATH -fhip-new-launch-api -mllvm -amdgpu-early-inline-all=true -mllvm -amdgpu-function-calls=false -D__HIP_ROCclr__",
  "default-cuda-link-line" : "-Wl,-rpath=$HIPSYCL_CUDA_LIB_PATH -L$HIPSYCL_CUDA_LIB_PATH -lcudart",
  "default-cuda-cxx-flags" : "-U__FLOAT128__ -U__SIZEOF_FLOAT128__ -isystem $HIPSYCL_PATH/include/hipSYCL/std/hiplike",
  "default-is-explicit-multipass" : "false",
  "default-save-temps" : "false"
}

Hi!

./sycl_cpl/hipSYCL/bin/syclcc -std=c++17 -g -fsanitize=address
--hipsycl-config-file=./sycl_cpl/hipSYCL/etc/hipSYCL/syclcc.json
--hipsycl-targets='omp' --hipsycl-platform=cpu  test.cpp -o out

Please don't use --hipsycl-platform, it's deprecated and superseded by --hipsycl-targets (and will be ignored if --hipsycl-targets is present.
Since your hipSYCL has been compiled with accelerated CPU support, I believe omp is probbably resolved to the omp.accelerated compilation flow, where hipSYCL does additional compiler transformation to accelerate certain SYCL constructs when running on CPU.
To confirm, could you try --hipsycl-targets=omp.library-only, where it will instead function as a library for OpenMP compilers? If the issue is specific to the omp.accelerated flow, it should work in that case.
I'm not sure why this issue would arise when using omp.accelerated, but maybe @fodinabor has an idea?

Hi,
I just tried with both omp.accelerated and omp.library-only.
The issue is present only with omp.accelerated

Please don't use --hipsycl-platform, it's deprecated and superseded by --hipsycl-targets (and will be ignored if --hipsycl-targets is present.

Thanks i didn't noticed it, it was in a old makefile.

Jup, this should definitely only occur with accelerated, as this is an internal symbol that is defined in the accelerated code path only: https://github.com/illuhad/hipSYCL/blob/develop/include/hipSYCL/glue/omp/omp_kernel_launcher.hpp#L223
Since it's explicitly undefined, this has to be cleaned up after the compiler transformations that needed it are through with it. This should happen in: https://github.com/illuhad/hipSYCL/blob/develop/src/compiler/cbs/RemoveBarrierCalls.cpp#L75
But I assume that activating ASAN adds some references to this, so the check whether it's dead is not successful.
Will try to dig into it later..


Make various changes and clean up scripts

Hi! I'm the autofix.ci troubleshooter bot.
It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@Electroid you broke #27
a93230d#diff-0ab5f4d9b6ac7c64ba34246032bebb7d567daffdc4724e50769bd38c6d9c4c66L28
a93230d#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R34
It should be (in src/index.ts)
- version: getInput("bun-version") || readVersionFromPackageJson() || undefined,
+ version: readVersionFromPackageJson() || getInput("bun-version") || undefined,

because getInput("bun-version") always returns the default value (which is latest), so the readVersionFromPackageJson() is never called.
Would be great if we can get a 1.1.1 out quickly (@xHyroM ).

I didn't catch that, thanks! Well I can publish it tomorrow (UTC+1) because I'm not on computer so I can't build the code.

I did not expect the quick reply, please see the edit to fix another bug/inconvenience in one go :)

@Electroid you broke #27
a93230d#diff-0ab5f4d9b6ac7c64ba34246032bebb7d567daffdc4724e50769bd38c6d9c4c66L28
a93230d#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R34
It should be (in src/index.ts)
- version: getInput("bun-version") || readVersionFromPackageJson() || undefined,
+ version: readVersionFromPackageJson() || getInput("bun-version") || undefined,

because getInput("bun-version") always returns the default value (which is latest), so the readVersionFromPackageJson() is never called.
Would be great if we can get a 1.1.1 out quickly (@xHyroM ).

I didn't catch that, thanks! Well I can publish it tomorrow (UTC+1) because I'm not on computer so I can't build the code.

I did not expect the quick reply, please see the edit to fix another bug/inconvenience in one go :)

GitHub actions built it, so I'll release it in few minutes


y-maze window AOI

add AOI for the window in the Y maze and add these timecourses to the visualizations

changed generate_aoi_regions to add an aoi for the y maze window

This is in generate_aoi_regions. Would still be nice to have throughout analysis, to compare Pilot 1a and windowless Pilot 1b.


Change PT to PT-PT (Portugal) in Transifex

As explained in https://www.transifex.com/openstreetmap/teams/75542/discussions/ by another user, coordinator in Portuguese (PT) translation, "request to change PT to PT-PT (Portugal), to avoid brazilians users to translate PT-PT instead of PT-BR".
Because of that, the previous translations are now "reviewed" and can only be changed by reviewers and coordinators. This is not very convenient.
I could request pt-PT language and then copy/paste all translations, but to my knowledge, that doesn't copy the original authors and I would be the only translator (this is a "bug" in Transifex side).
It is possible to "move" those translations or there is another solution?

Sorry, I think we need to leave 'pt' as the default Portuguese language, otherwise there won't be a default code for iD to fallback to.  The locales really need to match strings that are reported by your browser.
I understand that it's not very convenient to review each translation, but I still think that's the best way to make sure your users are getting good translations.  (this for any language, not just 'pt')

Ok. Who should I contact to be a reviewer in Transifex? I've asked a month ago to one coordinator but I didn't had an answer. Unfortunately we have many translators in "pt" but not even 1 reviewer...

Ok. Who should I contact to be a reviewer in Transifex? I've asked a month ago to one coordinator but I didn't had an answer. Unfortunately we have many translators in "pt" but not even 1 reviewer...

Send me a message on Transifex and I will add you as a coordinator for 'pt'


merge pages into google and AWS pages

There are several pages in integrations/providers/more that belongs to Google  and AWS integrations/providers.

moved content of these pages into the Google  and AWS integrations/providers pages
removed these individual pages

Thanks @leo-gan !

I've missed the page redirections for the removed pages. Those redirections are in the #11388


Reloading

Fixes several bugs and provides some enhancements.
Some issues related to #62 are addressed here, though import / pickling is still an issues.
CelebA is enhanced and can now handle splits.
Imagenet now uses the common preprocessing.
STL-10 added and uses the common preprocessing.
kwargs were not propagating properly through submodels.
Default arguments were not passing properly. This has been probably fixed, but testing is necessary (#141 ).
Attribute classification was added (for CelebA)

From issue #141,

Nested arguments (within dicts) are updated corrected. In other words, if a default argument looks like this:
classifier_args = dict(batch_size=False)
Updating this argument with classifier_args=dict(dim_h=100) yields
classifier_args = dict(batch_size=False, dim_h=100)

The test case should aim to test which way of updating the argument?
If it's direct access:
   model.defaults['classifier_args'] = dict(dim_h=100)
Then
  assert  model.defaults['classifier_args'] == {'dropout': 0.2, 'dim_h': 100}
Do not pass.
If it's by passing the arguments to the build() function,
    model.build(classifier_args=dict(dim_h=100))
Is not callable.
If it's by accessing the exp.ARGS variable,
    exp.ARGS['model']['classifier_args'] = dict(dim_h=100),
Then
    assert exp.ARGS['model']['classifier_args'] == {'dropout': 0.2, 'dim_h': 100}
Do not pass.

@joeljpoulin I don't know if either of those ways to edit the defaults or the ARGS that unexpected behavior. Both behave like dicts when edited directly like that, and they need to be updated using:
https://github.com/rdevon/cortex2.0/blob/reloading/cortex/_lib/parsing.py#L330
or
https://github.com/rdevon/cortex2.0/blob/reloading/cortex/_lib/__init__.py#L103-L112
What exactly are you trying to test here?

PR #162 is adding the tests needed and they pass. Travis-Ci build fails because Travis-CI can not access the .cortex.yml configuration file. Problem is being investigated at the moment.


ARTEMIS-4658 Prevent reflections when using dual address federation

When federation is configured in two directions between nodes for an address the message can reflect from one node to another if max hops is not set or not set correctly and in some federation topologies the max hops value can't solve the issue and still result in a working configuration. This reflection should be prevented at the federation consumer level for address consumers.

I've done a few full runs of the tests to check for regressions


firefox: 92.0.1 -> 93.0

We now have to set MOZBUILD_STATE_PATH or the build system will get a
permission error trying to create the default directory.

Mach and the build system store shared state in a common directory
on the filesystem. The following directory will be created:
/homeless-shelter/.mozbuild
If you would like to use a different directory, hit CTRL+c, set the
MOZBUILD_STATE_PATH environment variable to the directory you'd like to
use, and run Mach again.
Press ENTER/RETURN to continue or CTRL+c to abort.

Tested that my menus are still working with firefox-wayland on Sway. :)

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Duplicate of https://github.com/NixOS/nixpkgs/pull/140474.


[KO] Translation of deepdream.ipynb

Supersedes #104

@rickiepark, thank you so much for the detailed feedback. I have applied your comments and made the necessary edits as per your suggestions. I know I complicated things by messing up Git and reopening a new issue, but I hope this is okay... Please let me know if you find any issues!

@rickiepark Fixed the typo! I'll try to be more meticulous with my translations next time. Thank you so much again!

Great!
Thanks for you efforts.
LGTM 👍

Fixed merge conflict and ran nbfmt, so should be good now

Thank you so much to both!


Attribution

Source implementation is Guy Davidson and Arthur O'Dwyer, not solely arthur. The initial implementation was by Guy, and he is prrimary force behind the C++ proposal.
Also, you might want to take a look at plf::colony for correcting compiler feature detection.

Also, you might want to take a look at plf::colony for correcting compiler feature detection.

@mattreecebentley  Anything specific you noticed?

Ah ok cool - I didn't check the link and made the assumption the link was to the SG14 - no harm intended. Probably some credit still due to guy as he wrote the spec, but yeah.
@martinmoene If you take a look at the first section of any of the plf:: library headers, you'll find the compiler feature detection code. There's a bunch of cases where C++11 is specified as available but certain features are not - both for gcc and when other libraries are using libstdc++.
Might be worth just copy-pasting that section then adapting to suit.

ps. Obviously boost config is the best reference for this, but it spralls across 100s of files. I'm only trying to adapt to the most common compilers.


Selinux rules

🗣 Description
This PR installs SELinux authorization.
💭 Motivation and context
This closes #62
🧪 Testing
Following the procedure given in #62 .

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

I spent a lot of time thinking about how to make the SELinux policy changes that you are adding in a clean way that passes ansible-lint.  After that I started to wonder why this change is necessary in the first place.
The problem is that the SELinux policy for freshclam is only allowing the standard HTTP port.  You are trying to connect to a private mirror on port 8000, which is in violation of this policy.
I think the answer here is to either

Make the changes to the SELinux policy that are required for your local environment (i.e., allow freshclam to reach out on port 8000) outside of this Ansible role
Or, have your local ClamAV mirror start listening on port 80

In any event, I don't think these changes belong in this Ansible role.  This Ansible role is intended to install and configure ClamAV, but it cannot support generic tweaking of the SELinux policy for your local environment; such support belongs, perhaps, in a locale-specific Ansible role.
If you feel differently, feel free to fork this repo and create your own version of this Ansible tole.

Having clamav to work with a private mirror listening on its default port sounded like a common-enough use-case to me, so I figured I would share my changes within this role.
Also there is a second part to this PR, where we allow clamav to access the system, which might be required on RedHat variants according to clamavAV documentation.
Until we figure out a better approach, I think we'll keep using our fork for these tweaks. Anyway, thank you for the time you spent on this!

Also there is a second part to this PR, where we allow clamav to access the system, which might be required on RedHat variants according to clamavAV documentation.

If you want to create a new PR that only includes this change that would be something we would include.


fix(Lark): fix wikidoc icons bug

Description

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

You can merge this one with #1389 as one PR, titled "fix(Lark): handle wikidoc" or something else.

You can merge this one with #1389 as one PR, titled "fix(Lark): handle wikidoc" or something else.

OK


feat(ONYX-1458): add information and guidance to the saves, follows and alerts screens

This PR resolves ONYX-1458
Description

Add information and guidance to the saves, follows and alerts screens. Used InfoButton component where possible, refactored InfoButton component extracting the modal into a separate component
https://github.com/user-attachments/assets/45f4563e-1cf5-45d3-babd-394a5fff7569
PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 07cabcf5135d92ae0e343b1f7317b372d4a118f8


Fix single option chart table style

Closes #2499

Fixed that. Also changed the motion detail view layout a bit so the table won't flow out of bounds if the card gets to small.


Sync inspection

Duplicates this: https://github.com/then/promise/pull/59 with a few caveats.
As per https://github.com/then/promise/pull/59#issuecomment-102028323, now only accessible after enabling, by calling Promise.enableSynchronous(), and can be disabled (mostly for completeness sake) by calling Promise.disableSynchronous().
Is this the preferred method of getting this in, or did I misunderstand?

As an additonal option, would you be cool if I set it up so you can require('promise/synchronous') where it's always enabled? We have a use case for that. It's involving a module using promise, and a submodule that uses promise, which means that they get 2 separate instances of promise (since they're different modules at that point), so they're not both enabled.

@ForbesLindesay @nathan7 any chance this could get merged in?


nixos/xautolock: fix default defaults/examples, add assertions

Motivation for this change
see issue #34371
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

/cc @fpletz

Can this be integrated?


Add reference assemblies topic

Summary
Adds conceptual documentation about reference assemblies.
Sources:

Evolution of design-time assemblies
Reference assemblies - Roslyn Docs
BCL - Reference Assembles video

Fixes #14281
Fixes #2638
//cc @rpetrusha @svick @terrajobst @jcouv

@terrajobst, could you take a look at this new article when you get a chance, please?

I've addressed requested changes. Please re-review.

Close/repen to rerun new checks.

Only two more conversations required to be resolved, then we can gets sign-off and then ship!

Awesome job!


have a Software Licence that describes how you will permit others to use your work

Closed with https://github.com/DSCI-310/dsci-310-group-10-GCC-pkg


Pre-compiled module is missing<EMAIL_ADDRESS>

WARN Pre-compiled module is missing<EMAIL_ADDRESS>WARN Please an file issue at https://github.com/tessel/t2-cli/issues/new with this warning.
WARN
WARN This warning might be caused by one of the following:
WARN
WARN 1. A pre-compiled binary has not yet been built for this module.
WARN 2. The binary didn't compile correctly for the platform that you're developing on.
WARN    Binaries that are Linux-only or even OpenWRT-specific may cause this issue.
WARN    Try to npm install --force the affected module, then rerun your deployment command.
WARN 3. The binary may be platform specific and impossible to compile for OpenWRT.
WARN Pre-compiled module is missing<EMAIL_ADDRESS>WARN Please an file issue at https://github.com/tessel/t2-cli/issues/new with this warning.
WARN
WARN This warning might be caused by one of the following:
WARN
WARN 1. A pre-compiled binary has not yet been built for this module.
WARN 2. The binary didn't compile correctly for the platform that you're developing on.
WARN    Binaries that are Linux-only or even OpenWRT-specific may cause this issue.
WARN    Try to npm install --force the affected module, then rerun your deployment command.
WARN 3. The binary may be platform specific and impossible to compile for OpenWRT.
INFO Writing project to Flash on Tessel-02A3B6C734F6 (1675.776 kB)...
INFO Deployed.
INFO Your Tessel may now be untethered.
INFO The application will run whenever Tessel boots up.
INFO      To remove this application, use "t2 erase".
INFO Running tessel.js...```

Alright, here's what it currently is, but I'm pretty sure what I did when I got that error is that I upgraded everything to the latest (t2-cli, firmware, etc) but then walked it all back to avoid the errors I was getting:
node-pre-gyp INFO Connected to Tessel-02A326D91961.
node-pre-gyp INFO Tessel Environment Versions:
node-pre-gyp INFO t2-cli: 0.1.4
node-pre-gyp INFO t2-firmware: 0.0.12
node-pre-gyp INFO Node.js: 4.2.1```

Node.js: 4.2.1

This is what I suspected! Please do: t2 update to update your board

Will do. Thank you!
On Thu, Apr 12, 2018, 10:03 AM Rick Waldron<EMAIL_ADDRESS>wrote:

Node.js: 4.2.1
This is what I suspected! Please do: t2 update to update your board
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tessel/t2-cli/issues/1453#issuecomment-380837533, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWVmqxPVYU47N1utzVzUPUJa4H7lPf6oks5tn2y1gaJpZM4TCjz-
.

@EnshaednHiker can you confirm this resolved your issue?

Sorry, yes this resolved the issue
On Fri, Apr 20, 2018, 2:24 PM Rick Waldron<EMAIL_ADDRESS>wrote:

@EnshaednHiker https://github.com/EnshaednHiker can you confirm this
resolved your issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tessel/t2-cli/issues/1453#issuecomment-383197308, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AWVmq26UCHMMhqGHFnzSWpJICdEw4Ykdks5tqjYDgaJpZM4TCjz-
.

@EnshaednHiker excellent!

Just going to leave this here 😃
$ t2 run led.js
INFO Looking for your Tessel...
INFO Connected to lesset.
INFO Building project.
WARN Pre-compiled module is missing<EMAIL_ADDRESS>WARN Please an file issue at https://github.com/tessel/t2-cli/issues/new with this warning.
WARN
WARN This warning might be caused by one of the following:
WARN
WARN 1. A pre-compiled binary has not yet been built for this module.
WARN 2. The binary didn't compile correctly for the platform that you're developing on.
WARN    Binaries that are Linux-only or even OpenWRT-specific may cause this issue.
WARN    Try to npm install --force the affected module, then rerun your deployment command.
WARN 3. The binary may be platform specific and impossible to compile for OpenWRT.
INFO Writing project to RAM on lesset (489.984 kB)...
INFO Deployed.
INFO Running led.js...

$ t2 version
INFO Looking for your Tessel...
INFO Connected to lesset.
INFO Tessel Environment Versions:
INFO t2-cli: 0.1.20
INFO t2-firmware: 0.2.0
INFO Node.js: 8.11.3

$ node -v
v10.9.0


Axi_CDMA (Central Direct Memory Access) device driver

Hi. I am happy to see you in your github.
I found the device driver of axi_dma in your github.
I ported DMA driver on the ZED board using your code.
It was working very well.
But now, I am trying to port the CDMA driver on my board.
I must add and change some codes for porting the CDMA driver.
But I have no idea for it...
Could you share the CDMA device driver codes if you have....?
Thank you.

Hi. I searched about CDMA driver in Google.
And I found the cdmatest.c code what looks like device driver of CDMA.
Here is the github site: https://github.com/Xilinx/linux-xlnx/blob/master/drivers/dma/xilinx/cdmatest.c
Could you check this is the correct code for axi_cdma device driver?
If right, What should I do using this code...?
Thank you.

Certainly, I don't have the code right now, but I should be able to implement it in a few days. I'm currently away from my FPGA board, so the code won't be heavily tested, but I think it should be straight-forward.

Hi Brandon.
Thank you for consideration about my issue.
I can implement using AxiDMA instead of AxiCDMA eventhough it is inconvenient for me.
If making the cdma device driver is not for your job, I don't want to steal your time...
I hope to really  appreciate for your mind.
Thank you Brandon!
From Jisu.
-----Original Message-----
From: "Brandon<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Sent: 2018-11-21 (수) 01:33:05
Subject: Re: [bperez77/xilinx_axidma] Axi_CDMA (Central Direct Memory Access) device driver (#73)
Certainly, I don't have the code right now, but I should be able to implement it in a few days. I'm currently away from my FPGA board, so the code won't be heavily tested, but I think it should be straight-forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi, Brandon.
I had said that you don't need to effort for my question.
But I need your help...
I get a "testcdma.c" code from:
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/dma/xilinx/cdmatest.c
and tried to compile this file using petalinux.
I failed to compile it with some errors and I am wondering this file is exact device driver file or not.
Could you please help me to create CDMA device driver?
Thank you.
From Jisu


Fallback code for openTypeOS2UnicodeRanges and

I don’t have the exact details, but fonts that don’t set Unicode range and code pages fail on Windows. With this code fonts built with fontmake without setting openTypeOS2UnicodeRanges and openTypeOS2UnicodeRanges work on Windows.

Thanks Khaled! I'll review this tomorrow.
Just one thing. You know that the fonttools' O_S_2f_2 module also some similar code for the unicode ranges (not the codepage ranges)
https://github.com/fonttools/fonttools/blob/master/Lib/fontTools/ttLib/tables/O_S_2f_2.py#L251-L516
might be worth merging with your own work to avoid duplication.

Dropped my Unicode ranges implementation and used fontTools’, they seem to be equivalent.

I think this would also need some accompanying test cases, especially since there're so many if branches.

a translation of the code from FontForge (as mentioned in the commit message)

ok, I missed that.

gonna fix it myself, thanks

Thanks Cosimo!


Publish it as an npm package

It'll be easy to use.

We are talking about a single file component with one dependency (Framer Motion). Maintaining and publishing it on NPM is more of a hassle than just copying the contents of the file.


Error: Mongo.Ecto.all/5

First, thanks for your hard work on this! Second, I ran into a problem getting things set up a in a new Phoenix project. I created a model and navigated in Chrome to the route I set up for the endpoint. I then got this error:
[error] #PID<0.1553.0> running CommonStandardsProject.Endpoint terminated
Server: localhost:4000 (http)
Request: GET /api/jurisdictions
** (exit) an exception was raised:
    ** (UndefinedFunctionError) undefined function: Mongo.Ecto.all/5
        (mongodb_ecto) Mongo.Ecto.all(CommonStandardsProject.Repo, #Ecto.Query<from j in CommonStandardsProject.Jurisdiction, select: j>, [], #Function<0.119612849/2 in Ecto.Repo.Queryable.preprocess/2>, [])
        (ecto) lib/ecto/repo/queryable.ex:21: Ecto.Repo.Queryable.all/4
        web/controllers/jurisdiction_controller.ex:9: CommonStandardsProject.JurisdictionController.index/2
        web/controllers/jurisdiction_controller.ex:1: CommonStandardsProject.JurisdictionController.phoenix_controller_pipeline/2
        (common_standards_project) lib/phoenix/router.ex:281: CommonStandardsProject.Router.dispatch/2
        (common_standards_project) web/router.ex:1: CommonStandardsProject.Router.do_call/2
        (common_standards_project) lib/common_standards_project/endpoint.ex:1: CommonStandardsProject.Endpoint.phoenix_endpoint_pipeline/1
        (common_standards_project) lib/plug/debugger.ex:90: CommonStandardsProject.Endpoint."call (overridable 3)"/2

Is this something I've done or a bug in the library? Here's the repo: https://github.com/scottmessinger/elixir-api-spike

That's a problem with Ecto versions. José introduced yesterday breaking change for the Mongo adapter, and I haven't got time to implement it yet.

Thanks!


Chat on mobile web view doesn't show 'send' button/icon (so can't submit)

CommentForm relies on an enter key stroke to submit. But mobile web view doesn't have that. Do we already have a way to detect this webview? Or should I just use a media-query to hide a submit button?

I think comments should always have a send button. we can use the same one we use in the chat rooms.
@brodeur thoughts?


libnbd: patch CVE-2023-5215

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

libnbd: patch CVE 2023-5215
Change Log

libnbd: patch CVE 2023-5215

Does this affect the toolchain?

NO
Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2023-5215

Test Methodology

Local build

It would be a good idea to run the test pipeline before the merge.

Built RPM successfully in buddy build pipeline: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=439146&view=results. Merging ....


Prepare for next release

Coverage remained the same at 59.145% when pulling 68162b16b724bc7fdd360bed8169dc65b24f3fe4 on feature/prepare-next-release into 273e4bc9e73a4a1b3346d4adc8398329a81d7b09 on master.


Fixed link to Ethereum whitepaper

Removed leading slash which broke the link to the Ethereum whitepaper

Thanks mate :+1


ci: release for push to main branch (#6)

ci: add semantic release

ci: push main release

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


review and write additional copy for Aurora home page

To write copy for the Aurora design system home page. Copy to include:

Tagline
Introduction in top banner
Review copy in principles
Copy on bottom banner / call-to-action

@s-duffey Principles completed.

Intro completed

Call-to-action done, remove "documentation" button. Only tagline remains, suggestions welcome.

Suggestions welcome for tagline.
All other copy finished.

Written and with translation.


feat: add mailpit as module

What does this PR do?
Adds Testcontainers.Mailpit as a module to the project.
Why is it important?
Mailpit is an extremely useful tool for testing email related features and I think having it as a module to use inside the Testcontainers .NET C# ecosystem is worth the effort.
Related issues
Didn't find any.
How to test this PR
I've added simple a test that ensures the SMTP and Web servers are working accordingly by sending the email and querying the REST api for that specific email.
To run this test in your shell:
dotnet test "tests/Testcontainers.Mailpit.Tests/Testcontainers.Mailpit.Tests.csproj"

Follow-ups
If this PR is acceptable, I think there is still some tidying-up of the .sln files to keep consistency as I've seen done in other merged PRs.

Sorry for the late response. I will try to review the PR next week :v:.

Relates to #1153.


Fixed styling bug

On this page
Here it is

I signed it!

@addyosmani  @sgomes does it look good?

Thanks for the PR, @akashnimare! I'm afraid this change would affect much more than just the bit in the screenshot, though, as it would remove the bullet point from every li in all of the text everywhere on the styles and readme pages.
I'll prepare a different PR and link to it here, so you can take a look at a better way of solving this.

Created #1709 with a better solution to this issue.

@sgomes as for as I know it's not affecting  any other styling. You can cross check it. But you know better so I'll just wait for your PR.

@sgomes as for as I know it's not affecting  any other styling. You can cross check it. But you know better so I'll just wait for your PR.

@akashnimare No worries, these things are hard to spot sometimes :)
Here's an example of something that would have been affected. Before:

After:

@sgomes Ahha! It was so small that I did not spot it.
Your solution is better :+1:


Unable to establish one or more of the specified browser connections on Chromium 87

Hi,
Our tests were perfectly working up to Chromium 85.
Starting with Chromium 87, we encounter "Unable to establish one or more of the specified browser connections" 90% of the time.
What is your Test Scenario?
We build Docker images containing:

Base image (centos7 with SElinux enabled)
TestCafe (tested with v1.10.1, 1.9.4, v1.8.8)
Node.js (12.20.1)
Our fixtures to test

We run these images on an Openshift cluster (v3.9.0)

Host VM (centos7 with SElinux enabled)
Requested CPU/RAM (various configurations tested up to 4 cores / 2GB RAM)

testcafe 'chromium:headless --no-sandbox --disable-dev-shm-usage'

What is the Current behavior?
90% of the time, Testcafe is terminating in timeout after 2 minutes trying to connect the browser.
We have no logs except:
ERROR Unable to establish one or more of the specified browser connections. This can be caused by network issues or remote device failure.

(maybe https://github.com/DevExpress/testcafe/issues/5212 will help)
We made several tests by changing the allocated resources to the pod.

If CPU/RAM is really low, Testcafe fails 100% of the time
If CPU/RAM is decent (4cores/1GB RAM), Testcafe fails 90% of the time without concurrency
If CPU/RAM is decent (4cores/1GB RAM), Testcafe fails 100% of the time with concurrency (>=2)

We made the same tests on the same Docker image with a downgraded Chromium ( v85):

All is perfectly working, even with high concurrency (--concurrency=10)

It seems to be close to the issue https://github.com/DevExpress/testcafe/issues/5212  for which I don't see a clear solution.
Any idea? Would you need additional info to investigate?

90% of the time, Testcafe is terminating in timeout after 2 minutes trying to connect the browser.

We added a way to change the default timeout using the "--browser-init-timeout" flag (or "browserInitTimeout" options of the runner.run method and the configuration file). Although these changes are not yet reflected in the documentation, they are already included in the latest alpha version of TestCafe, so you can try them and check if they help with the issue. Install the alpha version of the TestCafe package:
npm i<EMAIL_ADDRESS>
After that, you can increase the default timeout using the flag I mentioned. E.g., change the default timeout value to 180000 ms (3 minutes):
testcafe chromium:headless e2e/**/* --browser-init-timeout 180000

90% of the time, Testcafe is terminating in timeout after 2 minutes trying to connect the browser.

We added a way to change the default timeout using the "--browser-init-timeout" flag (or "browserInitTimeout" options of the runner.run method and the configuration file). Although these changes are not yet reflected in the documentation, they are already included in the latest alpha version of TestCafe, so you can try them and check if they help with the issue. Install the alpha version of the TestCafe package:
npm i<EMAIL_ADDRESS>
After that, you can increase the default timeout using the flag I mentioned. E.g., change the default timeout value to 180000 ms (3 minutes):
testcafe chromium:headless e2e/**/* --browser-init-timeout 180000

Hi @wentwrong - we see similar issues to what @fmartinou describes. The workaround of increasing the browser init timeout seems to work, but I'm still curious why this started to fail with newer chrome/chromium versions. Did you change something in testcafe or did the browsers memory consumption change?

Hi @wentwrong - we see similar issues to what @fmartinou describes. The workaround of increasing the browser init timeout seems to work, but I'm still curious why this started to fail with newer chrome/chromium versions. Did you change something in testcafe or did the browsers memory consumption change?

It is likely caused by some changes in a newer browser version. Both TestCafe and your site can lead to excessive memory and CPU consumption. Since our functional tests are fine, we need an example that we can run to reproduce the issue. Without such an example, we cannot debug and fix it.

It is likely caused by some changes in a newer browser version. Both TestCafe and your site can lead to excessive memory and CPU consumption. Since our functional tests are fine, we need an example that we can run to reproduce the issue. Without such an example, we cannot debug and fix it.


feat(backend): validate httpsig on rs requests using auth implementation

Export verifySig from auth package
use auth's verifySig implementation to validate the signature received after and introspection request

Changes proposed in this pull request

fixes #585

Context

Checklist

[X] Related issues linked using fixes #number
[X] Tests added/updated
[ ] Documentation added
[ ] Make sure that all checks pass

@mkurapov
Since we are still using the magic tokens in postman, it should still work because whenever they are passed, there is no introspection and no signature validation. However, we do have issues for all of your points

https://github.com/interledger/rafiki/issues/664
https://github.com/interledger/rafiki/issues/665
https://github.com/interledger/rafiki/issues/606

Thanks for the explanation @sabineschaller , I was using the access tokens from the auth seeds, using authorization: GNAP dev-access-token for the Postman requests like in the config ended up working for me. I've been taking a look at the linked issues and they make sense, will add some comments if I see anything come up.


Need Clarification about example in Readme.md

In example code where you used snprintf() function, while printing 'sample' value you passed 'updown' variable as argument/reference. shouldn't it be 'sample' variable?
snprintf(scratch, sizeof(scratch), "count: %4d, sample: %3d, average: %3d\n",
average.get_count(),
updown,
(int) average());                   // or call average.get_avg()

Thank you. Btw i'm new to arduino and a fan of your extensive work. Hats off

Think this issue is solved, otherwise feel free to reopen.


selectedMonth and selectedMonth get wrong result

I copied and paste the code in your example got selectedMonth showing year and selectedYear showing month/year. I believe this is not normal unless I did something wrong.
And is it compulsory to enforce monthFormat and monthNames just to change the dateFormat? I just need to my change the dateFormat to YY/MM. Thanks for your time.

@k8martian hello, sorry for the late response. The example in README was a little outdated - I've updated it https://github.com/slavakisel/react-month-picker-input#usage
Also, I've just released version 1.1.6. It allows to provide a partial i18n object in props, e.g.:
<MonthPickerInput i18n={{ dateFormat: { default: 'YYYY/MM' } }} />

Please let me know if this is what you are looking for


Add files for cmdlets: New-CsBatchTeamsDeployment and Get-CsBatchTeamsDeployment

Docs Build status updates of commit 769c6ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded

New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Files added to wrong path.

Docs Build status updates of commit 769c6ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded

New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5829db3:
:warning: Validation status: warnings

File
Status
Preview URL
Details

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md
:warning:Warning
View (teams-ps)
Details

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md
:warning:Warning
View (teams-ps)
Details

Get-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded

New-CsBatchTeamsDeployment.md
:white_check_mark:Succeeded

teams/teams-ps/teams/Get-CsBatchTeamsDeployment.md

Line 0, Column 0: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 0, Column 0: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

teams/teams-ps/teams/New-CsBatchTeamsDeployment.md

Line 0, Column 0: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 0, Column 0: [Warning: ms-author-missing - See documentation] Missing required attribute: 'ms.author'. Add the current author's Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix up sentence splitting

Our TeX sentence detector returns the wrong character offsets for sentences. This impacts the user experience, as we cannot detect the locations of sentences (and therefore make those sentences interactive) if we don't have accurate offsets for them in the TeX.
The cause of the issue is that when we call the pysbd for sentence splitting, the character offsets for the start of sentences are sometimes incorrect. Specifically, the start index is sometimes erroneously set to 0. See this issue for details about when and why this occurs.
Spec. In a single example, here's the desired behavior. When we run the following code:
from entities.sentences.extractor import SentenceExtractor
extractor = SentenceExtractor()
sentences = extractor.parse(
    "filename.tex",
    "This is a sentence. Next we describe two items. 1) The first item. 2) The second item."
    )

for s in sentences:
    print(s)

We don't want this behavior (the current, undesired, output):
Sentence(start=0, end=19, tex_path='filename.tex', id_='0', tex='This is a sentence.', context_tex='This is a sentence.', text='This is a sentence.')
Sentence(start=20, end=47, tex_path='filename.tex', id_='1', tex='', context_tex='', text='Next we describe two items.')
Sentence(start=0, end=18, tex_path='filename.tex', id_='2', tex='', context_tex='', text='1) The first item.')
Sentence(start=0, end=19, tex_path='filename.tex', id_='3', tex='', context_tex='', text='2) The second item.')

The desired output is (note the corrected start and end indices of the 3rd and 4th sentences):
Sentence(start=0, end=19, tex_path='filename.tex', id_='0', tex='This is a sentence.', context_tex='This is a sentence.', text='This is a sentence.')
Sentence(start=20, end=47, tex_path='filename.tex', id_='1', tex='', context_tex='', text='Next we describe two items.')
Sentence(start=48, end=66, tex_path='filename.tex', id_='2', tex='', context_tex='', text='1) The first item.')
Sentence(start=67, end=86, tex_path='filename.tex', id_='3', tex='', context_tex='', text='2) The second item.')

Implementation options. The only requirements for this issue are that:

[ ] We should still use pysbd, as it is a high-quality sentence splitter
[ ] The sentence extractor returns the desired output above

Any technical solution that continues to use pysbd, but which works around this problem, is acceptable. One (probably too time-consuming) option is to submit a patch to pysbd.
I will outline one potential solution here, which I think would be pretty quick to implement. It just adjusts offsets for sentences with a start index of 0 based on a string search, starting after the last correctly-located sentence. Here's the pseudocode:
for sentence in [sentences extracted with pysbd]

  if (sentence is not the first sentence)

    if (sentence.start is 0)
      real-start := (search  full-tex-string, starting at last-sentence.end)
      real-end := (real-start) + (sentence.end - sentence.start)
      update sentence start and end to real-start and real-end

  last-sentence := sentence

Assumptions of this implementation are that:

There's a way to get a ordered list of sentences from pysbd
The distance end-start for all sentences extracted from pysbd is correct. Because start isn't always correct, I don't know if the offset of end relative to start is always correct.

I don't know if these two assumptions hold. Before implementing this solution, the person handling this issue should make sure those assumptions hold, by experimenting with pysbd, and potentially by looking at the pysbd code base.

A few comments before I push this PR up.
It's hard to tell exactly how and when the sentence extractor will break. Following the comments provided by the creator in the linked issue does not fix all cases (although I had to come up with some somewhat arbitrary cases in order to break it).
I can also only prove the first of our two assumptions and instead am relying on anecdotal evidence for the second assumption (although I have yet to come up with a case that does not work).
What bothers me is that I can't figure out why the start and end are calculated the way they are. I'm assuming there must be a very valid reason, but I can't figure out why it's done is such an inconsistent way. I say this bc the sentence extractor appears to be extremely good at finding the sentences themselves. Thus, it's unclear to me why the start and end are not just calculated based on the length of the string and the end position of the previous string?

I say this bc the sentence extractor appears to be extremely good at finding the sentences themselves.

Yeah, exactly! If only it had provided accurate character offsets for the sentences, we'd be golden!

Thus, it's unclear to me why the start and end are not just calculated based on the length of the string and the end position of the previous string?

The reason I'm thinking of using end - start instead of the length of the extracted sentence is that I wasn't sure if pysbd does sanitization on the sentences that it returns (e.g., removing redundant whitespace or strangely-encoded characters). If we have a guarantee that it doesn't sanitize the strings it returns, then we can just use len(sentence) like you mentioned.

I can also only prove the first of our two assumptions and instead am relying on anecdotal evidence for the second assumption (although I have yet to come up with a case that does not work).

Roger. While it would be great if we could come up with a bulletproof solution to this issue, if it's just not possible, we might be able to find something that works 99% of the time, and fix up other errors as our pipeline finds them.


feat: Support ignored Network Interfaces #2796

What is the purpose of the change
see #2796
Brief changelog

support ignored Network Interfaces
add some testcases

Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[x] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #7884 (e4b84a9) into master (d6d8d25) will decrease coverage by 0.33%.
The diff coverage is 60.00%.

@@             Coverage Diff              @@
##             master    #7884      +/-   ##
============================================
- Coverage     59.64%   59.31%   -0.34%
  Complexity      556      556
============================================
  Files          1088     1088
  Lines         43847    43855       +8
  Branches       6400     6404       +4
============================================
- Hits          26153    26011     -142
- Misses        14777    14934     +157
+ Partials       2917     2910       -7

Impacted Files
Coverage Δ

...apache/dubbo/common/constants/CommonConstants.java
100.00% <ø> (ø)

...n/java/org/apache/dubbo/common/utils/NetUtils.java
67.44% <60.00%> (+0.88%)
:arrow_up:

...a/org/apache/dubbo/rpc/filter/AccessLogFilter.java
28.35% <0.00%> (-50.75%)
:arrow_down:

...va/org/apache/dubbo/rpc/support/AccessLogData.java
53.16% <0.00%> (-37.98%)
:arrow_down:

...ntext/event/AwaitingNonWebApplicationListener.java
48.48% <0.00%> (-24.25%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
46.15% <0.00%> (-15.39%)
:arrow_down:

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
76.92% <0.00%> (-15.39%)
:arrow_down:

...ng/transport/dispatcher/WrappedChannelHandler.java
43.47% <0.00%> (-15.22%)
:arrow_down:

...ng/transport/dispatcher/all/AllChannelHandler.java
75.86% <0.00%> (-13.80%)
:arrow_down:

...dubbo/remoting/exchange/support/DefaultFuture.java
78.63% <0.00%> (-12.83%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d8d25...e4b84a9. Read the comment docs.


nixos/vaultwarden: make package configurable

This is my first contribution, so hopefully I didn't miss anything. If I did, please let me know!

Motivation for this change
This allows the user to override the version of Bitwarden RS used by the service, if using an overlay to keep up to date with releases for example.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Looks reasonable. Why hasn't this been merged? @msteen, you're the maintainer, right?

Rebased for the vaultwarden renaming

/marvin opt-in
/status needs_merger

/status needs_reviewer

/status needs_merger


Check header content instead of word count for version info

This must be a typo because $server_wc will probably never match */* :wink:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Merged, thanks again!


CSS modules process class names twice

We need to load CSS files from @design/library globally, i.e. without CSS modules. Unfortunately, PostCSS doesn't support something like this:
:global {
	import<EMAIL_ADDRESS>}

Therefore we need to do it on WebPack level. But there was a problem when @oacore/design was symlinked because regular expression does not match.
Reported by @Joozty in #19

@Joozty would this config solve the problem?

I think we are fine with what we have now.

Please, reopen if this is not fixed.


[CHANGE ME] Re-generated  to pick up changes in the API or client library generator.

This PR was generated using Autosynth. :rainbow:
Here's the log from Synthtool:
synthtool > Cloning googleapis.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:90f9d15e9bad675aeecd586725bce48f5667ffe7d5fc4d1e96d51ff34304815b
Status: Image is up to date for googleapis/artman:latest
synthtool > Running generator for google/cloud/dataproc/artman_dataproc_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/js/dataproc-v1.
.circleci/config.yml
.circleci/npm-install-retry.js
.eslintignore
.eslintrc.yml
.github/CONTRIBUTING.md
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node11/common.cfg
.kokoro/continuous/node11/test.cfg
.kokoro/continuous/node6/common.cfg
.kokoro/continuous/node6/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/docs.cfg
.kokoro/continuous/node8/lint.cfg
.kokoro/continuous/node8/samples-test.cfg
.kokoro/continuous/node8/system-test.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node11/common.cfg
.kokoro/presubmit/node11/test.cfg
.kokoro/presubmit/node6/common.cfg
.kokoro/presubmit/node6/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/docs.cfg
.kokoro/presubmit/node8/lint.cfg
.kokoro/presubmit/node8/samples-test.cfg
.kokoro/presubmit/node8/system-test.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
CODE_OF_CONDUCT.md
codecov.yaml
npm WARN deprecated<EMAIL_ADDRESS>no longer maintained
npm WARN deprecated<EMAIL_ADDRESS>CircularJSON is in maintenance only, flatted is its successor.

><EMAIL_ADDRESS>install /tmpfs/src/git/autosynth/working_repo/node_modules/grpc
> node-pre-gyp install --fallback-to-build --library=static_library

node-pre-gyp WARN Using request for node-pre-gyp https download
[grpc] Success: "/tmpfs/src/git/autosynth/working_repo/node_modules/grpc/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" is installed via remote

><EMAIL_ADDRESS>postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall

npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 1143 packages from 1274 contributors and audited 4409 packages in 21.093s
found 0 vulnerabilities

><EMAIL_ADDRESS>prettier /tmpfs/src/git/autosynth/working_repo
> prettier --write src/*.js src/*/*.js samples/*.js samples/*/*.js test/*.js test/*/*.js system-test/*.js system-test/*/*.js smoke-test/*.js

src/index.js 86ms
src/v1/cluster_controller_client.js 90ms
src/v1/index.js 16ms
src/v1/job_controller_client.js 44ms
samples/quickstart.js 19ms
test/gapic-v1.js 259ms
system-test/dataproc.js 15ms
smoke-test/cluster_controller_smoke_test.js 38ms
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #117   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines           4      4
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625808d...a745b9c. Read the comment docs.


populate: fix tar of a directory

This fixes the logic responsible for making a tar out of a directory.
It also excludes dotnames from files/dirs generation.
The large diff is due to fact that the file was previously not
gofmt'ed.

/cc @ashcrow
This fixes most of issues behind https://github.com/ostreedev/ostree-go/pull/15#issuecomment-398836186.

lgtm


Add boolean and equality partial operators

Create boolean (or, and, xor and sub) and equality operators, that operate
on two distinct bitsets with different starting points, but same length, in place.

My apologies, it's my first time contributing in Github and I've mistakenly added a new commit to this branch (which should be in a different branch), which I have since reverted

So the problem you are trying to solve with this is to allow for operators on subsets of the data; two observations to consider:

Code that can operate on a subset should be able to operate on the entire set, but I believe this change introduces alternate code paths for bounded operations.

Another possible solution to this problem which I believe would be less change to the class would be to consider allowing a bitset to be created from another as a subset (copies data at an offset and length) or view (references data at an offset and a length, with specific guidelines for the caller to manage the lifetime of the original?).  Then the existing operators would give you the behavior you want by working with subsets more naturally.

An example of #2, in pseudocode:
set one(...)
set two(...)
Here is how the pull request proposes to do it:
result = one.iand(two, some_offset_into_one, two, some_offset_into_two, length)
Or perhaps instead, think about:
result = one.view(some_offset_into_one, length) & two.view(some_offset_into_two, length)
where view returns a bitset that references the original data at the given offset and length, and then the operator& can be used naturally for an "and" operation.
That said, comments from others that use bitset more regularly would be appreciated.

Yes, this change introduces alternate paths. I didn't want to compromise the speed (and correctness!) of the already existing solution.
Regarding your second suggestion, I will think how can I implement it, since it seems more usable.

First, I would like to apologise for the time it took me for this change. I've refactored the code, to create the aforementioned "view", which I called span, due to the similarity with C++20 span.
There are some questions I had while doing this work, and I would like to hear your thoughts on them:

when the dynamic_bitset is const, I can't create a const dynamic_bitset_span directly. To solve this, I've created a const_dynamic_bitset_span, which is, of course, trivially converted to const dynamic_bitset_span. However, in some cases I have to explicitly create this new intermediate object.
the intersects function has a behaviour different than the other pairwise functions: it operates on the subset where both dynamic_bitsets exist, while other functions only accept equal length dynamic_bitsets
in the case of non-member binary operators (for instance dynamic_bitset_span(a) + dynamic_bitset_span(b)), what should be return? Right now, it's (a copy of) the complete underlying dynamic_bitset, but return only the subset operated by the dynamic_bitset_span may also make sense.

Thank you for your attention.
(And maybe I should also say, thank you to all contributors for this library!)

First, I would like to apologise for the time it took me for this change. I've refactored the code, to create the aforementioned "view", which I called span, due to the similarity with C++20 span.
There are some questions I had while doing this work, and I would like to hear your thoughts on them:

when the dynamic_bitset is const, I can't create a const dynamic_bitset_span directly. To solve this, I've created a const_dynamic_bitset_span, which is, of course, trivially converted to const dynamic_bitset_span. However, in some cases I have to explicitly create this new intermediate object.
the intersects function has a behaviour different than the other pairwise functions: it operates on the subset where both dynamic_bitsets exist, while other functions only accept equal length dynamic_bitsets
in the case of non-member binary operators (for instance dynamic_bitset_span(a) + dynamic_bitset_span(b)), what should be return? Right now, it's (a copy of) the complete underlying dynamic_bitset, but return only the subset operated by the dynamic_bitset_span may also make sense.

Thank you for your attention.
(And maybe I should also say, thank you to all contributors for this library!)

@joprodrigues please rebase on develop for a more complete CI suite

I'd recommend squashing your changes and then rebasing so we can get CI running on this.


Create some testing utils for working with and asserting against TOML

Describe the Enhancement
Buildpacks have a lot of TOML. Working with it is kind of a pain, especially when trying to do comparisons in tests.
We should take some time to write some helper code for working with and asserting against TOML.
Motivation
I think this will simplify our test cases and make them easier to read.

@dmikusa Why is this labeled v2?


[Runner] Update tray menu to WinUI 2.6 style

Is it possible/necessary to update tray menu style to WinUI 2.6/Win11 layout?
(And maybe adding icons too.)

@niels9001

AFAIK not a super straight forward thing.
Personally, I think we should get rid of the Awake systray menu and integrate it into #6751

AFAIK not a super straight forward thing.
Personally, I think we should get rid of the Awake systray menu and integrate it into #6751

I mean PT's menu for Report, Exit, Settings.

AFAIK not a super straight forward thing.
Personally, I think we should get rid of the Awake systray menu and integrate it into #6751

I mean PT's menu for Report, Exit, Settings.

Ah I see.. I'd move those maybe to the flyout as well?

AFAIK not a super straight forward thing.
Personally, I think we should get rid of the Awake systray menu and integrate it into #6751

I mean PT's menu for Report, Exit, Settings.

Ah I see.. I'd move those maybe to the flyout as well?

Maybe. 🤔🤷

Any reason to use WinUI 2.6 now and not wait for WinUI 3?

Let's talk about the question of how many features WinUI 3 needs, how many features can be updated in the future,

Nice :)! Is that using XAML Islands?

Detected when a screen is being used

Detected when a screen is being used

What do you mean exactly?

在使用屏幕时检测到

你是什么意思？

Because the user will use 1-2 monitors, this design drawing is designed for the default window

Detected when a screen is being used

What do you mean exactly?

Because the user will use 1-2 monitors, this design drawing is designed for the default window，The first design tells the user the shortcut key method for using PowerToys function, the second picture does not tell the user the shortcut key method

so this design drawing is for the interface design of the user when using two monitors @htcfreek

Curious to see the current progress. (also: 2.6 or 3?)

Ah I see.. I'd move those maybe to the flyout as well?

3 out of 4 are there (the 4th is commented out) - is this still a target? Sounds simple to me?

Yes, they are all the same interface, but different interfaces are designed according to different scenarios


Use a unique run directory for each run when testing in run_pyspark_from_build

The problem was raised in issue #6495 , as quoted:
"I sometimes run the integration tests across multiple Spark versions. If I run the tests against something like Spark 3.3.0 and then try to run tests against Spark 3.1.x, it will often fail complaining about the metastore version being incompatible. This occurs because remnants from the first run are leaking into the second run via artifacts in the integration tests run directory."
Our solution: we create a unique run directory for each run using date +%s (seconds since UNIX epoch), and implement a simple clean up logic to delete run directories that are created more than 24 hours ago.
This is WIP. If you have any thoughts for the following, please leave a comment:

Use of timestamp for run dir naming
If the clean up logic should be in this file

Thanks!

build

build

build

This failed most of our nightly CIs, I will file a ticket


Add support for multiple ASGs in rolling deployment command

Currently, kubergrunt requires a single --asg-name when running eks deploy but in many clusters you'll have multiple ASGs for your worker nodes.
It would be great if this supported providing a list of ASGs and running rolling deployments on each of them.

Yes, I ran into this issue too -- problem is running one asg-name does not work in a multi-load balancer scenario because kubergrunt tries to get all the load balancers
INFO[2020-04-01T12:37:39-04:00] Detected cluster deployed in region us-east-2  name=kubergrunt
INFO[2020-04-01T12:37:40-04:00] Successfully retrieved EKS cluster details    name=kubergrunt
INFO[2020-04-01T12:37:40-04:00] Found 15 LoadBalancer services of 162 services in kubernetes.  name=kubergrunt
INFO[2020-04-01T12:37:40-04:00] Successfully extracted loadbalancer names     name=kubergrunt
INFO[2020-04-01T12:37:40-04:00] Verifying new nodes are registered to external load balancers.  name=kubergrunt```
Another issue is if you have a cluster autoscaler, it will kill any extra nodes that kubergrunt creates to bring the system back to nominal


Solver config difference between FPN and C4

❓ Questions and Help
Hi
I notice that the solver configuration files of two versions for mask-rcnn based on resnet50 (C4 and FPN) are quite different.
For the C4 model (e2e_mask_rcnn_R_50_C4_1x.yaml):
SOLVER:   BASE_LR: 0.01   WEIGHT_DECAY: 0.0001   STEPS: (120000, 160000)   MAX_ITER: 180000   IMS_PER_BATCH: 8
For the FPN model (e2e_mask_rcnn_R_50_FPN_1x.yaml):
SOLVER:   BASE_LR: 0.02   WEIGHT_DECAY: 0.0001   STEPS: (60000, 80000)   MAX_ITER: 90000
Why the base learning rate for FPN is twice of the C4 version? And why the MAX_ITER is so different too? Are these the recommanded settings for these two versions respectively?

Yes, those values are expected and follow Detectron config files.
The reason why the values is different is because C4 uses a batch size of 1 per you, while FPN uses 2 imgs per you. This means that you need to apply the lr scaling, as well as the number of iterations, as discussed in the README in the SINGLE GPU training section.
I'm closing this issue, but let me know if you have further questions


Simplify atStartups by removing uncalled or unused code

MiqQueue's @@delete_command_file was used to delete rows at startup based on a YAML dumped hash of find options.  I believe this is completely unused.

start_event_monitor does not go through the queue so don't worry about purging it

Picture.atStartup is never called

More details in each commit message.

LGTM 👍 waiting for Travis GREEN


Panic: Index out of range

I'm writing an SSE library that Hijacks incoming connections and allows the ability to bulk broadcast to many connections at once.
Here is what my naïve test implementation looks like:
package routes

import (
	"unsafe"

	"github.com/hodgesds/iouring-go"
)

type netring struct {
	ring *iouring.Ring
}

func newNetRing() (*netring, error) {
	ring, err := iouring.New(1024)

	if err != nil {
		return nil, err
	}

	return &netring{
		ring,
	}, nil
}

func (n *netring) send(fds []int32, data []byte) error {
	addr := (uint64)(uintptr(unsafe.Pointer(&data[0])))
	length := uint32(len(data))

	for _, fd := range fds {
		e, commit := n.ring.SubmitEntry()

		e.Opcode = iouring.WriteFixed
		e.Fd = fd
		e.Addr = addr
		e.Len = length

		commit()
	}

	return n.ring.Enter(uint(len(fds)), uint(len(fds)), iouring.EnterGetEvents, nil)
}

And upon sending more than 1024 sqe's I get a panic on ring.go:192. I was under the impression that Enter would flush the submission queue and I could continue to submit. Is this the case? Or should I be creating a new ring every time I surpass the limit?

Ah, an interesting bit of info from the man pages https://www.mankier.com/2/io_uring_enter:
When the system call returns that a certain amount of SQEs have been consumed and submitted, it's safe to reuse SQE entries in the ring. This is true even if the actual IO submission had to be punted to async context, which means that the SQE may in fact not have been submitted yet. If the kernel requires later use of a particular SQE entry, it will have made a private copy of it.```

I'm writing an SSE library that Hijacks incoming connections and allows the ability to bulk broadcast to many connections at once.

Ah, that's really interesting. I haven't taken any time to think about network use cases yet as I wanted to get file IO working properly first.

I was under the impression that Enter would flush the submission queue and I could continue to submit. Is this the case?

Yeah, that should be the case. I haven't had time to write tests (or look at the docs) for what happens when you wrap the boundaries of the ring, but I'm guessing the ring mask is not being used properly in setting a value in one of the mmap'd indices.

I'm also planning on using IORING_REGISTER_BUFFERS so I can write the SSE into the kernel before submitting thousands of events all referring to the same address. And I suppose to that end, would it be possible to allow  https://github.com/hodgesds/iouring-go/blob/master/ring.go#L28 to take Params as a parameter instead of defaulting it to empty?

:100:, just pushed up a few changes that should make it a little more flexible.

For the buffers it may need a registry like in register.go.

Another aside, but would it be possible to also support https://www.mankier.com/2/io_uring_setup#IORING_SETUP_SQPOLL such that we never have to call enter? (unless it's asleep)

Should be able to pass the const for it in the params when setting up the ring..

For SQPOLL to function it also needs to check for IORING_SQ_NEED_WAKEUP as well, though I may be missing it if this is already handled.

It should be on the ring Enter method (it's not tested), or you can grab it from NeedWakeup method on the SQ.


NullReferenceException in MobiFlight.InputConfig.AnalogInputConfig.ReadXml

Reported in Discord, opening the attached .mcc file results in:
MobiFlight.InputConfig.AnalogInputConfig.ReadXml(XmlReader reader)
   at MobiFlight.InputConfigItem.ReadXml(XmlReader reader)

Open this with the debugger attached to figure out what's causing the crash and then add some try/catch logic.
dualefis.txt

Fails occurs when add an analog input but don't assign any event, after restart mobiflight the error appears.


⚠ PrivateHD has degraded performance

In f1812a5, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2825 ms

Resolved: PrivateHD performance has improved in 4f816f7.


Request for Bluetooth pairing as alternative to wifi

Not sure if this is in the scope of the project but pairing to the raspi from a phone would provide a much desired ease of connect-ability without a requirement to connect to the network.

Right, I don't think I would allow pairing without input either. I was going to add a touch display to my box, so automatic pairing wouldn't be an issue.
Really, it's just another option it's not like it's really providing an easier interface for streaming the music to the pi. Just thinking about making this much more mobile, i was looking to make mine a box to lug around.

My current solution for mobile use:
I'm working on a mobile jessie based version of pimusicbox at the moment and going to use something like this
Basically it's a bootstrapper that trys to connect to known wifis. If there is no known wifi available it will create an AP to access the rbpi.
I added a GPIO toggle switch to choose the mode and a LED for status indication.
Example:
at boot: search for known wifi ssids, if non is available a AP will be created
wifi AP is active -(toggle switch)> search for kown wifis and connect, if non is available create an AP again
wifi client mode -(toggle switch)> create an AP
At the moment, this would only be usefull, if your going to use pimusicbox in "offline" mode (only lokal files).
Next step would be to add new SSID instead of replacing them. I'm not sure, but i think it is done that way at the moment.
To create a mobile online pimusicbox i think there are two options:

add an 3g usb modem
use your smartphone to create a hotspot and let pimusicbox connect to it

Has anybody made progress on the SD Cars corruption issues?
As said before I'm using raspbian jessie and there weren't any corruption issues till now. But I had no deeped search for what is actually causing the sd corruption so far.

I had another idea about the bluetooth idea. We could use NFC tags for the
pairing. That way it requires local physical access to rasp and a bit
better security. The protocol is SSP (Secure Simple Pairing). It requires
bluetooth 2.1 or higher.
I was playing with NFC tags when I came across it.
Bryan
On Thu, May 25, 2017 at 4:16 PM, mon7gomery<EMAIL_ADDRESS>wrote:

My current solution for mobile use:
I'm working on a mobile jessie based version of pimusicbox at the moment
and going to use something like this
https://gist.github.com/mon7gomery/209244c9f011ee7a6b7ff75159ad2e97
Basically it's a bootstrapper that trys to connect to known wifis. If
there is no known wifi available it will create an AP to access the rbpi.
I added a GPIO toggle switch to choose the mode and a LED for status
indication.
Example:
at boot: search for known wifi ssids, if non is available a AP will be
created
wifi AP is active -(toggle switch)> search for kown wifis and connect, if
non is available create an AP again
wifi client mode -(toggle switch)> create an AP
At the moment, this would only be usefull, if your going to use pimusicbox
in "offline" mode (only lokal files).
Next step would be to add new SSID instead of replacing them. I'm not
sure, but i think it is done that way at the moment.
To create a mobile online pimusicbox i think there are two options:

add an 3g usb modem
use your smartphone to create a hotspot and let pimusicbox connect
to it

Has anybody made progress on the SD Cars corruption issues?
As said before I'm using raspbian jessie and there weren't any corruption
issues till now. But I had no deeped search for what is actually causing
the sd corruption so far.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pimusicbox/pimusicbox/issues/408#issuecomment-304149522,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvvE9TUNcQsGwZOr9V-uCllQxsAjtsnks5r9gvAgaJpZM4MzZ5J
.

--
Bryan Johnson


[BUG] Customize error message for data source connection errors

VISA has created an in house JDBC driver for one of our db system, and trying to throw error message via a SQLException(String reason) (java.sql.SQLException) for few scenarios. The reason argument that they are passing to the SQLException is getting displayed currently below the default error message of “Unable to proceed …”, which is little misleading for a user. So what they are looking for is to replace the whole error dialog with only the message that they are passing and not with any other extra default messages.
One more thing is that the reason argument they are passing is HTML, but it gets rendered as text only currently. We need to render the error message as HTML so that we have flexibility of styling the message. They are looking to replace entire content of the message with our jdbc driver’s message
Name:

Customers: VISA, Mc Donalds
There is also a community post idea request on here

It is currently considered by design that the driver's error message text is displayed at the bottom of the error dialog, with Tableau's common header and general error messages at the top.
Tableau relies in part on accurate SQL States returned from the JDBC driver to provide the best general error messages to the user.  If the SQLException includes SQLState this can potentially change the general error message. See Important SQLStates for some additional documentation in this area.


Add Remote Development Environments support

Hey!  I would like to ask: Does Gittyup support working with dev environments like local Docker containers, GitHub Codespaces, Gitpod etc... ?
I'm looking for a git UI to manage a "local" repo in a remote machine.
Say, a native UI installed in my laptop, working with a repo cloned into a remote machine where all compilation and testing happens.
This would also mean working with a repo cloned into a docker container... just like we can with VSCode with its DevContainers and Remote SSH extensions.
Similar feature requests on alternative projects:

Sublime Merge - Can you manage repository on remote server via ssh?
Sublime Merge -  add repositories "locally" stored on ssh servers #1262
GitKraken - Repository management on remote machine using SSH connection

Hi  @DiegoAlpizar I had this idea as well, that it might from time to time quite useful. Currently it is not supported perhabs

I also would really like this.
We're working on remote development servers with a bunch of software we can't install locally at all, so we don't really have an alternative to remote development.
When I really want to use sublime merge I usually use ssh X forwarding, but that's not really a good solution, especially because most of those remote dev servers have no other reason to have any X software installed anyways.

I am also interested about having a possibility to add another (local) server connection.


Map fragment fixes

buttons from manage event leaking through
make the map full screen, with only a back button to accompany it
ensure the map is focused around the location of the event when its opened (currently shows very zoomed out view upon opening)

fixed announcements button


[.Net] Add support for token custom expiration

Description

Added support to customize the Communication Identity access token’s validity period:

Added method overloads that provide the ability to create a Communication Identity access token with custom expiration:

CreateUserAndToken(IEnumerable<CommunicationTokenScope> scopes, TimeSpan tokenExpiresAfter, CancellationToken cancellationToken = default)
CreateUserAndTokenAsync(IEnumerable<CommunicationTokenScope> scopes, TimeSpan tokenExpiresAfter, CancellationToken cancellationToken = default)
GetToken(CommunicationUserIdentifier communicationUser, IEnumerable<CommunicationTokenScope> scopes, TimeSpan tokenExpiresAfter, CancellationToken cancellationToken = default)
GetTokenAsync(CommunicationUserIdentifier communicationUser, IEnumerable<CommunicationTokenScope> scopes, TimeSpan tokenExpiresAfter, CancellationToken cancellationToken = default)

Added a new API version ServiceVersion.V2022_10_01 that is now the default API version.

Packages impacted by this PR

Azure.Communication.Identity

Implementation TODOs

[x] Update the service client layer:

[x] Update autorest.md file to target the latest API version

https://github.com/Azure/azure-rest-api-specs/pull/19268
https://github.com/Azure/azure-rest-api-specs/pull/20039

[x] Regenerate the service client layer with the AutoRest tool

[x] Update the convenience layer:

[x] Apply required changes to the client classes

[x] Update samples
[x] Update .md files
[x] Update README, CHANGELOG
[x] Unit & integration tests

[x] Add/Update unit & integration tests
[x] Check test coverage
[x] Update test recordings

[x] Add HTTP recordings for the playback mode
[x] Check if environment variables are sanitized for the playback mode

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

/azp run prepare-pipelines

/azp run net - Azure.Communication.Identity - tests

@maximrytych-ms it's fine by me as well if the last comments and pipeline failure will be fixed :)


Remove IEnumerable from Spans, fixes #838

@KrzysztofCwalina I have removed it also from Utf8String since it's based on Span as well

We have to remove all interfaces that put Span<T> in the generic arg.

@davidfowl good point!
I have removed these interfactes + override bool Equals(object obj) implementation that was allowing to box spans.


Add heroku configurations and update ReadMe file.

Description
Configure Heroku deployment
All pull requests should be related to open issues. Indicate the issue(s) below and remove this line:
Fixes #(17)
How Has This Been Tested?
By visiting https://b4sdg-team269.herokuapp.com/
Screenshots

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[] I have added necessary inline code documentation
[] I have added tests that prove my fix is effective and that this feature works
[x] New and existing unit tests pass locally with my changes

Wait to merge the PR, am making tests to ensure that the deployed app works well

I was able to run the migrations and seed the database, I think we are now good to go

All the defined endpoints work well on my side (tested using insomnia). Do check them out to verify before merging

Looks good.

@onabright are we good to merge?


For traffic command, lizzy client should wait until stack becomes UPDATE_COMPLETE state to return

Now lizzy traffic does not wait for the stack to become status UPDATE_COMPLETE, which means next steps in pipeline that assume the traffic is switched will fail or perform actions to the wrong stack. Please make it possible to make lizzy wait for this state before returning (by default would be the best, but an option would be good too).

Should be fixed by https://github.com/zalando-stups/senza/issues/398

It will be fixed after https://github.com/zalando-stups/senza/pull/409 gets merged.


[SYSTEMML-769] [SYSTEMML-1140] Removed -disable-caching and -disable-sparse flags.

@mboehm7 I can merge this PR in if you are OK with it.

thanks @niketanpansare - I do appreciate this and yes it could be merged in. Personally, I would further also remove the constants from DMLScript as they would (without further integration) anyway break several places throughout the system that depend on sparsity estimates.

Thanks @mboehm7 ... For now, I would prefer to have these flags for performance testing and also for data scientists who want to try deep learning algorithms, until we resolve SYSTEMML-1140.
Based on your suggestion, I have added the integration logic (as well as test cases) for DISABLE_SPARSE, rather than remove the constants. Instead of replicating the entire test suite, I have only added tests for our applications so that our PR builder completes in time. Please let me know if I am missing any case or any test case which is critical to these flags.

the change seems to be ok, but remember that any performance experiments with these flags are completely meaningless because our mainstream algorithms would run into OOMs or use too conservative plans with this configuration.

Thanks @mboehm7 , I will merge. I differ with you on the utility of the performance experiments with the flags enabled. I think they highlight two critical performance issues that affects a large class of algorithms (i.e. deep learning). Also, the performance experiments show that it is mainly because of those two issues (and native BLAS vs LibMatrixMult) that we differ with other deep learning frameworks. Sure, these issues don't affect our batched mainstream algorithms to that extent, but nonetheless, we need to address them if SystemML aims to optimize general ML.