In-using PodCIDR overrode by auto generated one in "legacy-scope" type IPAM during k8s apiserver flapping

Phenomenon
With IPAM type IPAMHostScopeLegacy (+ direct routing),
when k8s apiserver is flapping (jumping between reachable & unreachable), cilium-agent will restart.
And during this case, there is a possibility that the PodCIDR the node is using will be overridden by an auto-generated one from cilium-agent, which leads to all pod traffic be interrupted.
Code logic (1.8.4) & trigger conditions
runDaemon                                                // daemon/daemon_main.go
  |-k8s.Init                                             // pkg/k8s/init.go
  |-NewDaemon                                            // daemon/daemon.go
    |-GetNodeSpec
    |  |-node := waitForNodeInformation
    |  |         |-retrieveNodeInformation
    |  |           |-GetNode                             // pkg/k8s/node.go
    |  |           | |-c.CoreV1().Nodes().Get(nodeName)
    |  |           |-ParseNode                           // pkg/k8s/node.go
    |  |             |- cidr.ParseCIDR
    |  |-if node != nil
    |  |   useNodeCIDR                                   // pkg/k8s/init.go
    |  |     |-node.SetIPv4AllocRange(n.IPv4AllocCIDR)
    |  |         |-ipv4AllocRange = cidr                 // pkg/node/address.go
    |  |-else
    |  |    if option.Config.K8sRequireIPv4PodCIDR
    |  |        log.Fatal()
    |  |
    |-bootstrapIPAM                                      // daemon/cmd/ipam.go
    |  |-if option.Config.IPv4Range != AutoCIDR
    |  |   allocCIDR := cidr.ParseCIDR(option.Config.IPv4Range)
    |  |   if !allocCIDR:
    |  |      log.Fatal()
    |  |
    |  |   node.SetIPv4AllocRange(allocCIDR)
    |  |         |-ipv4AllocRange = cidr                 // pkg/node/address.go
    |  |-AutoComplete                                    // pkg/node/address.go
    |  |  |-InitDefaultPrefix(option.Config.DirectRoutingDevice)
    |  |     if ipv4AllocRange == nil
    |  |       ipv4AllocRange = cidr.NewCIDR(ip4net) // Using autogenerated IPv4 allocation range
    |  |-d.ipam = ipam.NewIPAM
    |
    |-k8s.Client().AnnotateNode(cidr ...)       // daemon/daemon.go
    | |-updateNodeAnnotation                    // pkg/k8s/annotate.go
    |   |-c.CoreV1().Nodes().Update(node)

During agent start/restart, the following steps are executed in sequence:

Init k8s module: k8s.Init()
Agent will connect to k8s apiserver, and if failed (with retries), it will exit (then restart again).
The exit will not hurt traffic of existing pods, as BPF is not regenerated.
If this step succeeds, it will go to step 2.

Some other initialization. Not related to this issue, skip them. After this step finishes, go to step 3.

Init PodCIDR by retrieving node info from apiserver.
If apiserver it not reachable with up to 15 retries at this time (in waitForNodeInformation()),
agent will stop retrying.
Then, with default K8sRequireIPv4PodCIDR=false, the agent will fall back to step 4:

First fall back to parse PodCIDR from ipv4-range (default auto, which means empty), then further fall back to auto-generate.

General Information

Cilium version: 1.8.4 (the same for 1.9.x and master)
Orchestration system version: k8s

Considerations
Noticed that K8sRequireIPv4PodCIDR defaults to true for some types of IPAMs.
Not sure if I missed something, but it seems it's also reasonable to make it default to true for hostscope-legacy and kubernetes type IPAMs. This will stop the fallback from step 3 to step 4, in which case cilium-agent will just exit, complaining that "Unable to derive PodCIDR from Kubernetes node resource, giving up". All existing pods on this node will not be affected.
If this behavior sounds reasonable, I'd like to file a PR.
Thanks in advance!

@ArthurChiao It seems this bug report fell through the cracks. Is it not an issue anymore?

This issue got no response during the last one month, so I just closed it :(
And turning back to the problem described: it is still there - but only affects cilium versions < 1.9, as 1.9+ removed hostscope-legacy support.
I think append ipamOption.IPAMHostScopeLegacy to https://github.com/cilium/cilium/blob/v1.8/pkg/option/config.go#L2634 could solve the problem
Should I open a PR against branch 1.8?

@ArthurChiao yes feel free to open a PR against 1.8


fsevents: fix race on simultaneous init+close

When uv_fsevents_t handle is closed immediately after initializing,
there is a possibility that the CFRunLoop's thread will process both
of these events at the same time. uv__is_active(handle) will return
0, and the uv_close() semaphore will be unblocked, leading
to the use after free in node.js.
See: https://github.com/nodejs/node/issues/4091

cc @saghul @bnoordhuis : It looks like we already have a test for this: fs_event_immediate_close. However, it doesn't stress this case that much to trigger a race condition on OS X. I'm not sure if a test case will provide much value, unless we will introduce some sort of pummel tests. What are your thoughts on this guys?

@bnoordhuis all fixed, thanks!

LGTM if tests pass.

CI: https://ci.nodejs.org/job/libuv+any-pr+multi/203/ (hopefully it works)

Failures on OS X seems to be unrelated, other platforms couldn't be affected. Landing.

Landed in 0761bfe, thank you! I think we need to backport it to whatever libuv version is used in node.js v4.2.2

Ok, it is v1.7.5, so it is probably a matter of cutting down a new release, right? cc @saghul

The plan is to have a 1.8.0 release soon: https://github.com/libuv/libuv/milestones/1.8.0

@saghul could this change be backported to v1.7.0 branch, please? We really need to update libuv in node.js v4.2.2 too

We don't do release branches, but since we promise API and ABI
compatibility, dropping 1.8.0 on Node 4.x should not create any issues.
On Dec 3, 2015 02:21, "Fedor Indutny"<EMAIL_ADDRESS>wrote:

@saghul https://github.com/saghul could this change be backported to
v1.7.0 branch, please? We really need to update libuv in node.js v4.2.2 too
—
Reply to this email directly or view it on GitHub
https://github.com/libuv/libuv/pull/637#issuecomment-161485969.

Ah, right! Thanks for the answer anyway.

No worries! And thank you for the fix. I'll make the PR to Node once ready.


[FR] Notebook, Markdown cells: please allow to generate a line break using '\n' and/or '' in the link tooltips

Hello, 👋
While I don't think it's "standard", some Markdown renderers show link tooltips on multiple lines when '\n' or '
' are used in the link tooltip code. In some cases they require that it be preceded by two spaces.
Where support exists, the tooltips in the examples I add below are seen on multiple lines, however that's not the case in VSCode's Markdown cells, and for that matter on GitHub.
Code:
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ 'microsoft/vscode: \nVisual Studio Code')
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ 'microsoft/vscode:  \nVisual Studio Code')
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ 'microsoft/vscode:
Visual Studio Code')
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ 'microsoft/vscode:
Visual Studio Code')

Example:
microsoft/vscode: Visual Studio Code
microsoft/vscode: Visual Studio Code
microsoft/vscode: Visual Studio Code
microsoft/vscode: Visual Studio Code
The only way I've found to achieve what I'm aiming for is to write the tooltip spreading multiple lines but I'd want to avoid having to resort to that method.
Below I show an example of the successful case with the unwanted method:
Code:
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ ' microsoft/vscode:
Visual Studio Code
       GitHub')

Example:
microsoft/vscode: Visual Studio Code
Please add support for '\n' and/or '
' in link tooltips.
Kind regards.
Claudio Salvio
P.S.: 🙏 Thank you for the useful work you are doing in the field of notebook support in VSCode!

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Some Markdown renderers show link tooltips on multiple lines

Can you share which markdown renderers do this?
Also I think this already works if you write a literal new line:
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ 'a
a')

Or if you need multiple new lines you can use html entities:
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ 'a

a')

Hello @mjbvz
Thanks for your post.

Also I think this already works if you write a literal new line:
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ 'a
a')

I know that this works correctly in both VSCode and Github, which is why I put an example of this type in my first post.
I would like to avoid using this syntax when writing markdown files because I find it impractical and complicates the automation of the creation of this type of files.
I consider that the markdown code is cleaner using something like '\n' or '
'  to express a new line. Both elements are widely used for this purpose in different areas.
In fact it works in some parts of the markdown link.
Code:
[microsoft/vscode:
Visual Studio Code](https://github.com/microsoft/vscode/ 'microsoft/vscode:
Visual Studio Code')

Example:
microsoft/vscode: Visual Studio Code

Or if you need multiple new lines you can use html entities:
[microsoft/vscode: Visual Studio Code](https://github.com/microsoft/vscode/ 'a

a')

Thank you for this proposal, it is not so visually clean but it helps avoid literal new lines, which seems positive to me.
Kind regards,
Claudio Salvio

In fact it works in some parts of the markdown link.

That part of the link is rendered as html text/elements. However the title is rendered as an attribute (<a title="...") which can't contain html elements

Thank you for this proposal, it is not so visually clean but it helps avoid literal new lines, which seems positive to me.

Yes using
 is uglier but still better because it standard and should work across almost all markdown engines
Closing this issue so that we keep with the standard approach instead of inventing our own solution


[Gssoc'21] Fixed the accessibility of contact page to all

Description
The Contact page is not accessible for all .
It can be access only after login which is not good.
Fixes #70
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Kindly Refer this video
https://user-images.githubusercontent.com/55352601/113501555-a2b43a80-9543-11eb-95ff-f453894a1aee.mp4

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

I had made a separate and independent file for contact there is no other option for me.
Kindly add label's before merging .


Update redis4cats-effects, ... to 1.7.1

About this PR
📦 Updates

dev.profunktor:redis4cats-effects
dev.profunktor:redis4cats-log4cats

from 1.1.1 to 1.7.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.profunktor" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "dev.profunktor" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #314.


improve 'mage checkNoChanges' error message

What does this PR do?
Improves the 'mage checkNoChanges' error message making it better explain what might be causing the error and the possible solitions.
Why is it important?
The current error message states running mage update will fix the problems, however it isn't always true.
Checklist

[x] My code follows the style guidelines of this project
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added an entry in CHANGELOG.md

Related issues

N/A

:green_heart: Build Succeeded

Buildkite Build
Commit: 827e2b04e6407e7ecc5d2e3fecbae198415552fe

cc @AndersonQ

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-08-21T09:10:13.170+0000

Duration: 11 min 48 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
791

Skipped
25

Total
816

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


sys/time.h is guarded inconsistently

I had a quick look and sys/time.h isn't guarded consistently:

!defined(_WIN32)
!defined(OPENSSL_SYS_VXWORKS) && !defined(OPENSSL_SYS_WIN32)
defined(__unix) || defined(__unix__)
!defined(OPENSSL_SYS_WINDOWS)
defined(OPENSSL_SYS_UNIX)

There are additional cases where the build system is doing the guarding (haiku.h, sparcv9cap.c).
A bit of a mess.

Actually, these ones are plain wrong:

defined(__unix) || defined(__unix__)
defined(OPENSSL_SYS_UNIX)

They should be changed to be similar to the others, i.e. exclude Windows only.
It's actually only pure pure luck that the VMS builds didn't bail out for the lack of definition of struct timeval in those files, and the luck comes like this in VMS' sys/socket.h:
/*
**  <sys/socket.h> is a header defined by XPG4 V2.  That specification
**  puts struct timeval, the FD* macros and select in <sys/time.h>.
**  We define select here for compatibility with DEC C V4, unless
**  the program is in XPG4 V2 mode.
*/
#if !defined __TIMEVAL && !defined _XOPEN_SOURCE_EXTENDED
#   define __TIMEVAL 1
#   if !defined _DECC_V4_SOURCE
        struct timeval {
           __time_t tv_sec;         /* seconds since Jan. 1, 1970 */
           long     tv_usec;        /* microseconds */
    };
#   else
        struct timeval {
           long     tv_sec;         /* seconds since Jan. 1, 1970 */
           long     tv_usec;        /* microseconds */
        };
#   endif
#endif

haiku.h

Just in case for reference. Note that you won't find explicit #include <haiku.h> anywhere. It's included first-most through command line in Configuration/50-haiku.conf. It's a kludge that works around header position sensitivity on Haiku. Basically choice was between #ifdef spaghetti and this -include \$(SRCDIR)/os-dep/haiku.h and latter was found least invasive.

A bit of a mess

Effectively unavoidable since we are supporting that many platforms. As already mentioned elsewhere, we should keep in mind that it would be more than appropriate to switch to own OS-neutral time type. This wouldn't make libcrypto code completely free of mess (because we would still have to convert the said OS-neutral time to OS-specific), but it would make it easier to use from application (and libssl). But it can't be done in minor release. [Well, it can if it's done with parallel interfaces. At least one should be able to do it between libcrypto and libssl. It might be worth considering. Specifically in minor release...]

The bit of mess comment was aimed at the hodgepodge of different guards not what has to be done.
I'd be happy with a consistent guard (perhaps in an internal header) but our own time type might be a better fix.

How do folks feel about an internal/timeval.h header which contains the preprocessor magic done consistently and the timeval source from e_os.h ?  Am I breaking things too fine?

I would think that internal/time.h should suffice

internal/time.h

On related note in https://github.com/openssl/openssl/pull/4246#issuecomment-325015970 I argue that this kind of naming would be acceptable only under certain circumstances. And conditions are not really met here. Indeed, time.h is mentioned in C language standard and is not specified to define timeval.

Thing is, if we create a header file for one structure, we're setting a precedent which is kinda silly...  and which will obviously include something that mimics sys/time.h anyway.
Ah, or are you saying we should make it internal/sys/time.h?  Or perhaps internal/sys-time.h...  I would prefer the latter, actually.

How do folks feel about an internal/timeval.h header

Note that there is kind of irreconcilable conflict. Normally headers are viewed to be position-insensitive, and I bet that this is your intention even here :-) But trouble is that timeval declaration can't be made position-insensitive on Windows, because timeval is defined in winsock[2].h, which in turn position-sensitive [in relation to windows.h]. This means that there ought to be some kind of rule for positioning internal/timeval.h. But in such case wouldn't we better off if there was only one position-sensitive header? And in such case timeval should probably be in this one? (Currently it's e_os.h, and no, I haven't formed my opinion about sockets.h).

Thing is, if we create a header file for one structure, we're setting a precedent which is kinda silly...

I absolutely agree, and it's kind of discussed later. I mean the part that e_os.h is too big, has to be broken to pieces, but it would be a mistake to break it into too many. So that in a sense suggestion is not only to instantiate and follow "internal/standard-looking.h should include corresponding standard header and not go beyond what it entails" rule, but even to use it as deterrent for creating too many internal "portability" headers.

It sounds more and more like the "over-relianse on e_os.h" wasn't such an over-relianse after all...  at least in the Windows case, as we need to include windows.h or winsock[2].h+windows.h more or less everywhere anyway...
I could easily go for keeping the "over-relianse on e_os.h" for the sake of Windows, and move everything away but the inclusion of those Windows headers, having the rest in internal header files that are geared for all other platforms (guarded with anti-Windows checks).  I find this solution disgusting, but it seems more and more that this would be the smoothest way to go.

It sounds more and more like the "over-relianse on e_os.h" wasn't such an over-relianse after all...

Yes, it was. It had to be included for things that are not least OS-specific, blake2 and des being couple of latest examples. Once again, it should be "used in "exceptional" situations to resolve real system dependencies." Nor is it directly appropriate to use it in apps, which should set an example of how to use public headers alone. [Yes, it means that some of the apps/*.c would have to include winsock[2].h and windows.h, but it would be more appropriate if they do it themselves, without relying on e_os.h.]

I could easily go for keeping the "over-relianse on e_os.h" for the sake of Windows, ...

I wouldn't be surprised if I soon find myself arguing that splitting internal/sockets.h was a mistake. As just said, we are better off if we have only one position-sensitive header [and so far it was e_os.h]... Yet, it doesn't mean that there is no over-reliance on e_os.h. Because there really is.

I suggested the new file name based on your earlier comment @dot-asm
It seems like a local type definition might be better than a tiny header file.
At the least I'll clean up the guards so they are consistent.

I suggested the new file name based on your earlier comment @dot-asm

Well, it's like that thing you can't really define, but point it out when you see it. I mean the comment was rather invitation for discussion than call for immediate action. And it shouldn't come as surprise that some responses to immediate actions can feel contradicting initial comment. We seem to agree that it's a mess, but we don't have ready answer how to solve it (and probably can't come up with one using this communication platform), so it will take several tries and possibly errors...

Agreed.  I might just clean the guards.  There isn't a compelling reason to pull them all together header.
Is:
#if !defined(_WIN32) && !defined(OPENSSL_SYS_VXWORKS) && !defined(OPENSSL_SYS_WIN32) && !defined(OPENSSL_SYS_WINDOWS)

The correct guard?  Can I drop any of the Windows checks?  I'm not a Windows person and am fairly clueless as to how things work in the forbidden land :)

OPENSSL_SYS_WINDOWS is defined in e_os2.h for any Windows version, so as long as that header file is included, you can drop all other Windows guards.
OPENSSL_SYS_WIN32 and OPENSSL_SYS_VXWORKS are defined in opensslconf.h, so as long as that header file is included, you can drop all other guards (but then, you won't detect Win64 correctly).
_WIN32 is defined by the compiler...  I think also on 64-bit?  @dot-asm can confirm.
For minimal dependency, I'd make sure to include opensslconf.h and have this guard:
#if !defined(_WIN32) && !defined(OPENSSL_SYS_VXWORKS)

_WIN32 is defined by the compiler... I think also on 64-bit? @dot-asm can confirm.

Yes, _WIN32 is defined by all compilers targeting Windows, 32- or 64-bit, "real" or embedded. Do note that "all compilers" and not "Microsoft compilers", it's not a coincidence. Then in addition to that you get _WIN64 if compiler targets 64-bit Windows.

OPENSSL_SYS_VXWORKS

Actually VxWorks compilers also pre-define a macro, __vxworks. And in case we find a platform that doesn't bother to distinguish itself with pre-define, I'd argue that we would be better off [in long run] defining one of own choice at command line through Configurations/*.cf.

I'd argue that we would be better off [in long run] defining one of own choice at command line through Configurations/*.cf.

So, appropriate sys_id entry that becomes the macro OPENSSL_SYS_$target{sys_id}.  This macro is stored in opensslconf.h, not on the command line, we can surely live with that, right?

PR in #4312

I'd argue that we would be better off [in long run] defining one of own choice at command line through Configurations/*.cf.

First of all, quote is truncated, and full quote has an if clause: "[if] we find a platform that doesn't bother to distinguish itself with pre-define." And it's a big "if", as I haven't seen such platform, so it would be rather rare exception. Now, with this in mind, what is more appropriate/fair/elegant? To treat all curent platforms as if they were that one rare exception? Or let that one exception be an exception?

So, appropriate sys_id entry that becomes the macro OPENSSL_SYS_$target{sys_id}. This macro is stored in opensslconf.h, not on the command line, we can surely live with that, right?

I'd say no. Beside the exception argument above, this particular approach has contradiction. Our API aims to provide OS-neutral interface. This formally means that public headers should not bear any reference to OS. [Ideally they shouldn't even be compiler-specific, but they definitely shouldn't be OS-specific, as all OS specifics should really be private matter of libcrypto/libssl.] And ... opensslconf.h is a public header. In fact, I'd even suggest to take it one step further saying that in long run we should aim for ... removal of opensslconf.h. Or at least purging its portions. Let's consider first entry for example. #ifndef OPENSSL_NO_ARIA. Does application actually have to know this? Wouldn't it be more appropriate if application probed for its availability at run time? Can it do it now? Yes! Instead of linking to EVP_aria_* it could simply EVP_get_cipherby*. ... Does application need to know about NON_EMPTY_TRANSLATION_UNIT? BN_LLONG and stuff?

Ideally there should be no difference at all between the public header files use for any release of OpenSSL on a cross-platform basis - i.e. nothing in the public header files for a release should vary across a platform (outside of 'include' differences) - and that does mean a 32-bit and a 64-bit set of headers on the same platform should be able to be identical. That is what I think the aim should be.


Token missing after initial redirect

It seems that after being redirected from /callback to /, the access and refresh tokens are not present in the request. However, after the initial redirect, every subsequent request appears to include the tokens. I'm not very familiar with Astro, so this might be something specific to the framework. Here are some screenshots.

This results in user getting redirected back to the authorize page.

i got a similar problem and i fixed it by using sameSite: "lax" while setting the cookies. this is my nextjs example
export async function setTokens(access: string, refresh: string) {
  const c = await cookies();

  c.set("access_token", access, {
    httpOnly: true,
    sameSite: "lax", // strict breaks?
    path: "/",
    maxAge: 34560000,
  });

  c.set("refresh_token", refresh, {
    httpOnly: true,
    sameSite: "lax",
    path: "/",
    maxAge: 34560000,
  });
}

related: https://github.com/vercel/next.js/discussions/17612


Item alchemy crashes on boot

Mod Name
Item Alchemy
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/item-alchemy-fabric
Describe the bug
crash on boot
Steps to reproduce

install connector FFAPI and item alchemy
boot
exit code -1
...

Logs
https://gist.github.com/Xplodin/fbb980d39b98192cc6396cd9799b14f4
Additional context
idk what else  to put besides adding this mod borked a pack

Added a bridge to fix this issue in Connector Extras 1.2.0

seems this issue came back:
all updated on all connector related stuffs
https://gist.github.com/Xplodin/23889024ac57ac3b3a051c20777f4f34

This happens to be an issue with item alchemy, and should be reported there. The crash occurs on fabric when using:

itemalchemy 0.7.3
mcpitanlibarch 1.7.9-1.20.1-fabric
architectury 9.1.12


Mongoid Criteria unexpected results when searching a document by id

mongoid (4.0.0.beta1), rails (4.0.1), ruby (2.1.0), mongoDB (2.4.9)
I have a Mongoid Criteria of users and I want to find a user. Given a user that I'm sure doesn't exists in the criteria:
>> users.where(email: user.email).exists?
=> false

>> users.map(&:id).include?(user.id)
=> false

When I search by id I always get the user instead of nil:
>> users.find(user.id)
=> #<User _id: 521a43b37

>> users.where(id: user.id).first
=> #<User _id: 521a43b37

>> users.where(_id: user.id).first
=> #<User _id: 521a43b37

>> users.where(id: user.id).exists?
=> true

Am I doing something wrong?

I think, I should rephrase the problem. It's something like using where clause with :id options.
e.g
user  = User.create! name:'kuldeep', age: 10
user2 = User.create! name:'arthurnn', age: 10

User.where(id: user.id).where(id: user2.id) # Mongoid::Criteria with selector having id = user2.id

so the question arises, what should happen?

Somewhat similar to #4002 .

Closing as we have a more descriptive #4002


New: Dire Slime

A new type of slime that comes from dirt blocks being treated with a
wrong tool.

Where do you register the entity?

EnderZoo line 69:
for (MobInfo mob : MobInfo.values()) { registerEntity(mob); }

Ah right, ok.
On Apr 19, 2015 3:20 PM, "Henry Loenwind"<EMAIL_ADDRESS>wrote:

EnderZoo line 69:
for (MobInfo mob : MobInfo.values()) { registerEntity(mob); }
—
Reply to this email directly or view it on GitHub
https://github.com/SleepyTrousers/EnderZoo/pull/84#issuecomment-94306733
.

Had a quick look and I really like it.
The default damage + hp needs to be adjusted though. As it is, it is pretty hard to take any damage from them, even with no armor , and it is killed in 1 hit with wooden sword.
I think the name will need to be changed too as it certainly isnt too 'dire' atm.
Let me know if you will make these changes, if not I will do a merge and make the changes myself soon.

With damage/health I'm a bit conflicted. Yes, they should be hard, but on the other hand, players can (will) run into them early game. The values I set as default are the Magma Cube's ones:
small: h=3, a=3, chance=90%
medium: h=6, a=4, chance=8%
big: h=18, a=6, chance=2%
What'd be you suggestion for these? And, should I add config values for the size-chance, too?
The internal name actually is "i hate that DIREwulf20 is always breaking dirt with his pick, this SLIME is made to counter that", just a bit shortened ;). Any good suggestion for the localized name? I could only think of "dirt slime" (lame...).

I see the issue with early game, but it will just force people to use a
wooded shovel if it is causing grief.
An option with the damage \health would be to adjust the values
significantly based on 'occupied time' of the chunk. I think I am only
using this when equipping random equipment on the fallen knights ATM.
One final option would be to track how many a player has caused to spawn
and increase the difficultly based on that.
Not sure if any of it is worth doing though. I will play around with
different values when I get a chance. Let me know what you think.
As for adding things to the config, I always add as much as possible, so
yes.
Thanks for the submission BTW. Great to get contributions.
On 22 Apr 2015 14:35, "Henry Loenwind"<EMAIL_ADDRESS>wrote:

With damage/health I'm a bit conflicted. Yes, they should be hard, but on
the other hand, players can (will) run into them early game. The values I
set as default are the Magma Cube's ones:
small: h=3, a=3, chance=90%
medium: h=6, a=4, chance=8%
big: h=18, a=6, chance=2%
What'd be you suggestion for these? And, should I add config values for
the size-chance, too?
The internal name actually is "i hate that DIREwulf20 is always breaking
dirt with his pick, this SLIME is made to counter that", just a bit
shortened ;). Any good suggestion for the localized name? I could only
think of "dirt slime" (lame...).
—
Reply to this email directly or view it on GitHub
https://github.com/SleepyTrousers/EnderZoo/pull/84#issuecomment-95047472
.

I can squish the commits if you want; I left them for now because it'll make it easier for you to see what I changed.

I would prefer a single commit. I find it much easier to review
Thanks
On 22/04/2015 7:48 PM, "Henry Loenwind"<EMAIL_ADDRESS>wrote:

I can squish the commits if you want; I left them for now because it'll
make it easier for you to see what I changed.
—
Reply to this email directly or view it on GitHub
https://github.com/SleepyTrousers/EnderZoo/pull/84#issuecomment-95147242
.

Squished. And added a custom model---like the magma cube but with 8 slices and exactly one block in size. All sizes are the same size, they only differ in their properties. The bigger ones just didn't look good with the oversized block texture on them, and they also tended to suffocate. The bigger (and more dangerous) ones will still sound differently.
Dire Slimes are fire-proof, after all they are made from dirt. (And I originally extended EntityMagmaCube to use its model. Could be changed with new model.)
There is one known bug: The hitbox rotates even though the rendered model does not.

Any news on reviewing this?

Sorry I haven't got to it. Should have some time in the next few days
On 27 Apr 2015 6:03 pm, "Henry Loenwind"<EMAIL_ADDRESS>wrote:

Any news on reviewing this?
—
Reply to this email directly or view it on GitHub
https://github.com/SleepyTrousers/EnderZoo/pull/84#issuecomment-96590269
.


Feature/fix error when pswp container is hidden

Hi @rap2hpoutre ,
I noticed an issue when using the latest version of vue-picture-swipe and create a fix for it. See e66b28b for both the fix and a description of the original issue.
For additional context, find a reduced example of the original setup below which I felt was too large to include in the Git commit message.
Thanks a lot for your work!
Tabs
<div
    v-show="showFirstTab"
    class="tab-content first"
>
    <gallery
        :images="firstImages"
    />
</div>

<div
    v-show="showSecondTab"
    class="tab-content second"
>
    <gallery
        :images="secondImages"
    />
</div>

Gallery component
<template>
    <section class="gallery">
        <vue-picture-swipe
            :items="presentableImages"
            />
    </section>
</template>

<script>
import VuePictureSwipe from 'vue-picture-swipe'

export default {
    components: {
        VuePictureSwipe,
    },
    props: {
        images: Array,
    },
    computed: {
        presentableImages() {
            if (!this.images) {
                return []
            }

            return this.images.map((image) => {
                return {
                    src: image.imagePath,
                    thumbnail: image.thumbnailPath,
                    w: 350,
                    h: 243,
                }
            })
        },
    },
}
</script>

Thank you!


various fixes for getting Nginx auth_request mode working

This supersedes #173 and #247, with the following changes:

adds a new flag --set-xauthrequest which sets response headers for use in auth_request mode (analogous to the X-Forwarded-User and X-Forwarded-Email headers in normal mode).
optionally read the redirect URL from request header X-Auth-Request-Redirect as the request URL doesn't correspond to the URL to redirect to in auth_request mode
documentation updates

Hopefully @jehiah would merge this PR, as there are multiple PRs related to this and hoping that this effort is not taken as an example of XKCD 927.

@jehiah: anything required to merge this?

Pinging @jehiah ...

 Probably it's just about the time to fork the project? :)

@akobyakov: I suspect that no one wants to be the maintainer. Maybe trying pinging @bitly on Twitter?

I think that if someone stepped-up with a fork, which incorporate this PR as well as the websocket support one, and was reasonably well tested and maintained, it could gain traction and then get a link from this repo's README.
I haven't worked at Bitly in a few years, so take that with a grain of salt.
I'm pretty sure the bitly twitter account is the wrong contact for this issue. I'd instead ping @SeanOC and @markrechler

@jehiah you seem to be active again -- is there any interest in merging this?

@jehiah: rebased on top of latest master. Not sure if you noticed the test TestAuthOnlyEndpointSetXAuthRequestHeaders which was added, let me know if what you'd like to see in addition.

@ashkulz I think i'm just musing about getting an end-to-end test running via jenkins that includes actually requesting through nginx. That can happen later though. Thanks for these improvements

Not sure if that can run on Travis CI. BTW, the merge build failed -- maybe a flaky test?

2017/03/29 16:15:53 validator.go:42: failed opening authenticated-emails-file="/tmp/test_auth_emails_964360117", open /tmp/test_auth_emails_964360117: no such file or directory

Also, any ETA for a 2.2 release? :smile:

Also, any ETA for a 2.2 release? 😄

soon. I am working on some more complete validation in this build, but I think it's already got enough fixes/changes to warrant a release, even if there are plenty more queued up to do another release in a month or two.


Custom dataComponents using the Bar primitive are breaking for some users

From @ryancoughlin
Breaking:
export default class CustomBar extends Component {
  render() {
    return <Bar {...this.props} />
  }
}
...
<VictoryBar dataComponent={<CustomBar/>}

Errors with:  "Expected a component class, got [object..."

https://gist.github.com/ryancoughlin/8cd6a9ee976b2e31895075e685a017fe

This was also tested on the victory-native demo running on Expo.

Shoot, so I was about to make a custom dataComponent ...
class CustomBar extends Component {
  render() {
    return <Bar {...this.props} style={{fill: "blue"}} />
  }
}

export default class App extends Component {
  render() {
    return (
      <ScrollView contentContainerStyle={styles.container} scrollEnabled={this.state.scrollEnabled}>
        <VictoryChart>
          <VictoryBar dataComponent={<CustomBar/>} />
        </VictoryChart>
      </ScrollView>
    );
  }
}

this was using the victory-native-demo repo mentioned, with
├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>
I also tested it with<EMAIL_ADDRESS>and it worked as expected.

@ryancoughlin this might be a far-fetched theory, but you could have a small curly bracket typo. For example:
class CustomBar extends Component {
  render() {
    return <Bar {...this.props} style={{fill: "blue"}} />
  }
}

const dataComponent = <CustomBar/>;

...

// works fine
<VictoryBar dataComponent={dataComponent} />

// typo gives a type error
<VictoryBar dataComponent={{dataComponent}} />

That might fit with the error you are seeing

Chris, I can try again - I am pretty sure I had a single set of curly
braces. So that worked fine for you using the demo?
As a side note: I got a new laptop for work. I will try the demo again with
the same samples and let you know how I make out.
On Thu, Jul 13, 2017 at 6:00 AM, Chris Bolin<EMAIL_ADDRESS>wrote:

@ryancoughlin https://github.com/ryancoughlin this might be a
far-fetched theory, but you could have a small curly bracket typo. For
example:
class CustomBar extends Component {
render() {
return <Bar {...this.props} style={{fill: "blue"}} />
}
}
const dataComponent = ;
...
// works fine
// typo gives a type error
That might fit with the error you are seeing
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FormidableLabs/victory-native/issues/118#issuecomment-315032764,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIKhbNObWKjnfxNwfwOTlcvu6MHYLh8ks5sNeq9gaJpZM4OUnxf
.

My package has:
"victory-native": "^0.12.0" and "react-native-svg": "5.2.0" Would it be helpful to explicitly those dependencies and their versions above (the ones you listed) to see if that helps. I know they'll get pulled in, but they may not go directly to that version.
Still seeing that same error. Any other thoughts?

could you run npm list | grep victory?

└─┬<EMAIL_ADDRESS>  ├─┬<EMAIL_ADDRESS>  │ └──<EMAIL_ADDRESS>deduped
  ├─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>deduped

I also tried a different dataset from an online generator just to rule out any other weird possibilities.

and this only happens when you use a custom dataComponent, right?

Yup, all my other charts render fine. I can render a custom component with only:
const SwellBar = props =>
  <G>
    <Rect x={props.x} width={'30'} height={'2'} fill={'blue'} />
  </G>

export default SwellBar

Once I implement <Bar {...this.props} /> it bombs.

alright, so Bar comes from victory-core, which is currently at 16.3.0. if you upgrade to<EMAIL_ADDRESS>you should pick up that new version. I'm not sure that will fix it, but then you'll have the same setup i had the other day when i tested this yesterday

Same results. I am using yarn not sure if that will affect anything (throwing out anything at this point).
Packages
├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>
I see it's not exactly at 16.3.0 after upgrading. Could I explicitly install that as a dependency?
Implementation
import React, { Component } from 'react'
import { Bar } from 'victory-core'

export default class SwellBar extends Component {
  render() {
    return <Bar {...this.props} style={{ fill: 'blue' }} />
  }
}

yarn is totally fine -- in fact, it's really helpful for situations like this!
victory-core didn't upgrade for you, because none of its callers needed it to (oversight on my part, as yarn will only update transitive deps that must be upgraded). you can just run yarn add victory-core and that should upgrade you to the latest victory-core. of course that will add it as a dep in your package.json. if you don't want to do that, you'll have to rm yarn.lock and yarn install to fetch the most recent versions of it.

Gave that a shot and same result
├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>
They are all at 16.3.0 except for │  ├─<EMAIL_ADDRESS>inside of victory-native

damn. sorry for making you jump through those hoops. i'll try again to see if i can get it to happen on my end

No sweat, I don't mind at all. I am pulling down the demo as we speak.

Pulling down the demo (clean install) with a modified render
render() {
    return (
      <ScrollView contentContainerStyle={styles.container} scrollEnabled={this.state.scrollEnabled}>
        <VictoryBar
          dataComponent={<Bar {...this.props} />}
          data={[
            {x: 1, y: 1},
            {x: 2, y: 2},
            {x: 3, y: 3},
            {x: 4, y: 2},
            {x: 5, y: 1}
          ]}
        />
      </ScrollView>
    );
  }

Importing core: import { Bar } from 'victory-core';
I get the same error

well now i feel like i must have made a mistake in my testing :P

From yarn list | grep victory
├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  ├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>

Oh! I just found it! It's just a simple typo / misunderstanding:
import { Bar } from "victory-native";
NOT
import { Bar } from "victory-core";

victory-core uses svg, but victory-native overrides all that with react-native-svg

i'm so sorry @ryancoughlin. should've caught that in your comment a few hours ago

we definitely need to address this in our docs. do you remember which docs you were reading?

AH HA!
This is where I started to get some information on building out custom charts along with some of the source code: https://formidable.com/open-source/victory/guides/custom-charts/

Alright! I'll make sure we put notes in there for that


[Solutions] Product List missing analytics

Analytics are missing.
Wrong Query pipeline is being called.

https://docs.coveo.com/en/18/api-reference/usage-analytics-write-api#tag/Analytics-API-Version-15


feat: add elementKeyAttribute, controls element cache

Relatively sure this would solve my issue over here as well - https://github.com/TanStack/virtual/issues/533. I could declare a different element key and have it recompute the values


Issue while renaming S3 directory in Studio

I'm using Sagemaker Studio, and trying to organise the S3 bucket contents from the sidebar.
I had a directory called test/abc, right-clicked on it and pressed Rename, into test/Abc, (changed first letter from lowercase to uppercase) and while the new directory showed up, the old one is still there, with all its subdirectories, but without any files.

I also have this issue. The S3 browser doesn't support directories with upper case letters correctly. This cases certain operations such as renaming or creating files/directories on them to try and work on a lowercase version of the path, and it (1) shows an error saying the newly created/renamed files aren't there and (2) on the background, it creates the equivalent directory tree in lowercase letters. Example, on s3://bucket/mydirectory/AnotherDirectory/, if you create a new subdirectory, you get a popup error, and a new directory is created in 's3://bucket/mydirectory/anotherdirectory/Untitled Folder'.
Hope this helps.

I think this might be related to the lowercase conversion here: https://github.com/IBM/jupyterlab-s3-browser/blob/master/jupyterlab_s3_browser/handlers.py#L301 .


fix dependency.

As module @tarpit/config does not carry TpConfigSchema and is not a DI token anymore, move it to the dependency of @tarpit/core. And remove it from the peer dependencies of other modules.


Move documentation views and assets from docs folder into app folder

This takes all the existing guidance and examples in docs/ and moves it to app/.
Main effect of this is that everything at /docs/ in the URL path moves to the root (/).
Also simplifies things a bit by not having 2 routes files, assets folders, etc.

@edwardhorsford @anandamaryon1 @vickytnz no hurry but if anyone could help test this by running the branch locally that'd be 🙌!


Decouple random motion generator from link axis

Add generic "motion providers".
Requires "blending" redesign.
Requires priority settings for script vs link/motion provider.

Could fix #25.
It might be easier to just use looping script as motion provider, less UI for pattern configuration, but that kinda duplicates the main script feature.


Feature: Hide parts of the path in the breadcrumb bar under a chevron and menu when it goes offscreen

Is your feature request related to a problem?
A clear description of what the problem is.
users can't scroll it using a mouse. most mice don't have horizontal scroll wheels.
Describe the solution
A clear description of what you want.
Describe alternatives you've considered
A clear description of any alternative solutions or features you've considered.
Scope

Capability
Priority

This proposal will add an option to collapse items in the pathbar when there isn't enough space
Must

System Information

OS Version: Windows 10 21H1
App version: 1.5

Additional comment
Add any other comment or screenshots about the feature request here. What device type/UI layout and app version?

This will be implemented when we switch to the WinUI Breadcrumb control.

Asking @yaichenbaum for approval.

Which items should be collapsed first?

@Poopooracoocoo, thank you for your feedback! We’ll address this issue along with #16029.


Custom Variables for Lua Scripts

What feature do you want to get added on the base engine?
What if there was an array with variables that could be used in other lua scripts?
Use example:
-Get cam position at end of the song
-Set cam position for next song, resulting in a smooth transition
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

global variables are a thing

global variables are a thing

fr how???

don't have "local" before the variable and use getGlobalFromScript
I suggest going into the code part on github and going into FunkinLua.hx to see how getGlobalFromScript works

don't have "local" before the variable and use getGlobalFromScript I suggest going into the code part on github and going into FunkinLua.hx to see how getGlobalFromScript works

thanks ig, gonna delete this now maybe


MODELIX-950: lint for OpenAPI breaking changes

This PR enables linting the OpenAPI specifications for breaking changes. For this purpose, the most recent version of the specs is compared to the specs present at the time the PR branched off. In case of findings, those are presented as inline annotations in the diff:

Currently, most detected findings have no line association and are therefore attached to the top of the openapi spec.
Breaking changes are detected after internally fusing all specs. That way, we would be free to move routes from one file to the other without triggering a breaking change (composed mode of oasdiff).
The added linter is not mandatory and does not fail the build, assuming that sometimes performing breaking changes is fine if no known uses exist.
To be verified by reviewers

[ ] Relevant public API members have been documented
[ ] Documentation related to this PR is complete

[ ] Boundary conditions are documented
[ ] Exceptions are documented
[ ] Nullability is documented if used

[ ] Touched existing code has been extended with documentation if missing
[ ] Code is readable
[ ] New features and fixed bugs are covered by tests

:tada: This PR is included in version 8.13.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[BUG] CI Docker Image push is failing

Describe the bug
Docker image push is failing in CI.
To Reproduce
Steps to reproduce the behavior:

Merge PR into main.
Push fails.

Expected behavior
Push to succeed.
**Environment (please complete the following information) **
CI

@mattwilkinsonn are you interested in taking this or would you like me to take a stab here?

@mattwilkinsonn are you interested in taking this or would you like me to take a stab here?

I was going to take a look at it later tonight, but if you want to take it now then go ahead!

I'll take a look since I'm working here, might just be an issue with copying wash-lib into the container 😄

FWIW I did try and update to include crates in the dockerfile but ended up getting stuck at
#14 552.2    Compiling wasmcloud-control-interface v0.17.0
#14 564.7    Compiling wasmcloud-interface-testing v0.5.1
#14 566.8 The following warnings were emitted during compilation:
#14 566.8
#14 566.8 warning: libssh2/src/bcrypt_pbkdf.c: In function 'bcrypt_pbkdf':
#14 566.8 warning: libssh2/src/bcrypt_pbkdf.c:113:24: error: storage size of 'ctx' isn't known
#14 566.8 warning:   113 |     libssh2_sha512_ctx ctx;
#14 566.8 warning:       |                        ^~~
#14 566.8
#14 566.8 error: failed to run custom build command for `libssh2-sys v0.2.23`
#14 566.8
#14 566.8 Caused by:
#14 566.8   process didn't exit successfully: `/build/target/release/build/libssh2-sys-25080844926b1548/build-script-build` (exit status: 1)
#14 566.8   --- stdout
#14 566.8   cargo:rerun-if-env-changed=LIBSSH2_SYS_USE_PKG_CONFIG
#14 566.8   cargo:include=/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/include
#14 566.8   cargo:root=/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out
#14 566.8   cargo:rerun-if-env-changed=DEP_Z_INCLUDE
#14 566.8   cargo:rerun-if-env-changed=DEP_OPENSSL_INCLUDE
#14 566.8   TARGET = Some("aarch64-unknown-linux-musl")
#14 566.8   OPT_LEVEL = Some("3")
#14 566.8   HOST = Some("aarch64-unknown-linux-musl")
#14 566.8   CC_aarch64-unknown-linux-musl = None
#14 566.8   CC_aarch64_unknown_linux_musl = None
#14 566.8   HOST_CC = None
#14 566.8   CC = None
#14 566.8   CFLAGS_aarch64-unknown-linux-musl = None
#14 566.8   CFLAGS_aarch64_unknown_linux_musl = None
#14 566.8   HOST_CFLAGS = None
#14 566.8   CFLAGS = None
#14 566.8   CRATE_CC_NO_DEFAULTS = None
#14 566.8   DEBUG = Some("false")
#14 566.8   CARGO_CFG_TARGET_FEATURE = Some("neon,pmuv3")
#14 566.8   running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-I" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/include" "-I" "libssh2/src" "-I" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/build" "-I" "/build/target/release/build/libz-sys-bb1688820e9df32b/out/include" "-I" "/usr/include" "-fvisibility=hidden" "-DHAVE_LONGLONG" "-DHAVE_SNPRINTF" "-DHAVE_UNISTD_H" "-DHAVE_INTTYPES_H" "-DHAVE_STDLIB_H" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_SOCKET_H" "-DHAVE_SYS_IOCTL_H" "-DHAVE_SYS_TIME_H" "-DHAVE_SYS_UN_H" "-DHAVE_O_NONBLOCK" "-DLIBSSH2_OPENSSL" "-DHAVE_LIBCRYPT32" "-DHAVE_EVP_AES_128_CTR" "-DHAVE_POLL" "-DHAVE_GETTIMEOFDAY" "-DLIBSSH2_DH_GEX_NEW" "-DLIBSSH2_HAVE_ZLIB" "-o" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/build/libssh2/src/agent.o" "-c" "libssh2/src/agent.c"
#14 566.8   exit status: 0
#14 566.8   running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-I" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/include" "-I" "libssh2/src" "-I" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/build" "-I" "/build/target/release/build/libz-sys-bb1688820e9df32b/out/include" "-I" "/usr/include" "-fvisibility=hidden" "-DHAVE_LONGLONG" "-DHAVE_SNPRINTF" "-DHAVE_UNISTD_H" "-DHAVE_INTTYPES_H" "-DHAVE_STDLIB_H" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_SOCKET_H" "-DHAVE_SYS_IOCTL_H" "-DHAVE_SYS_TIME_H" "-DHAVE_SYS_UN_H" "-DHAVE_O_NONBLOCK" "-DLIBSSH2_OPENSSL" "-DHAVE_LIBCRYPT32" "-DHAVE_EVP_AES_128_CTR" "-DHAVE_POLL" "-DHAVE_GETTIMEOFDAY" "-DLIBSSH2_DH_GEX_NEW" "-DLIBSSH2_HAVE_ZLIB" "-o" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/build/libssh2/src/bcrypt_pbkdf.o" "-c" "libssh2/src/bcrypt_pbkdf.c"
#14 566.8   cargo:warning=libssh2/src/bcrypt_pbkdf.c: In function 'bcrypt_pbkdf':
#14 566.8   cargo:warning=libssh2/src/bcrypt_pbkdf.c:113:24: error: storage size of 'ctx' isn't known
#14 566.8   cargo:warning=  113 |     libssh2_sha512_ctx ctx;
#14 566.8   cargo:warning=      |                        ^~~
#14 566.8   exit status: 1
#14 566.8   running: "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-I" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/include" "-I" "libssh2/src" "-I" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/build" "-I" "/build/target/release/build/libz-sys-bb1688820e9df32b/out/include" "-I" "/usr/include" "-fvisibility=hidden" "-DHAVE_LONGLONG" "-DHAVE_SNPRINTF" "-DHAVE_UNISTD_H" "-DHAVE_INTTYPES_H" "-DHAVE_STDLIB_H" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_SOCKET_H" "-DHAVE_SYS_IOCTL_H" "-DHAVE_SYS_TIME_H" "-DHAVE_SYS_UN_H" "-DHAVE_O_NONBLOCK" "-DLIBSSH2_OPENSSL" "-DHAVE_LIBCRYPT32" "-DHAVE_EVP_AES_128_CTR" "-DHAVE_POLL" "-DHAVE_GETTIMEOFDAY" "-DLIBSSH2_DH_GEX_NEW" "-DLIBSSH2_HAVE_ZLIB" "-o" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/build/libssh2/src/blowfish.o" "-c" "libssh2/src/blowfish.c"
#14 566.8   exit status: 0
#14 566.8
#14 566.8   --- stderr
#14 566.8
#14 566.8
#14 566.8   error occurred: Command "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-I" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/include" "-I" "libssh2/src" "-I" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/build" "-I" "/build/target/release/build/libz-sys-bb1688820e9df32b/out/include" "-I" "/usr/include" "-fvisibility=hidden" "-DHAVE_LONGLONG" "-DHAVE_SNPRINTF" "-DHAVE_UNISTD_H" "-DHAVE_INTTYPES_H" "-DHAVE_STDLIB_H" "-DHAVE_SYS_SELECT_H" "-DHAVE_SYS_SOCKET_H" "-DHAVE_SYS_IOCTL_H" "-DHAVE_SYS_TIME_H" "-DHAVE_SYS_UN_H" "-DHAVE_O_NONBLOCK" "-DLIBSSH2_OPENSSL" "-DHAVE_LIBCRYPT32" "-DHAVE_EVP_AES_128_CTR" "-DHAVE_POLL" "-DHAVE_GETTIMEOFDAY" "-DLIBSSH2_DH_GEX_NEW" "-DLIBSSH2_HAVE_ZLIB" "-o" "/build/target/release/build/libssh2-sys-79a2b053cdd90c42/out/build/libssh2/src/bcrypt_pbkdf.o" "-c" "libssh2/src/bcrypt_pbkdf.c" with args "cc" did not execute successfully (status code exit status: 1).
#14 566.8
#14 566.8
#14 566.8 warning: build failed, waiting for other jobs to finish...
------
executor failed running [/bin/sh -c cargo build --release]: exit code: 101

Any ideas @jordan-rash here?


Schedule Modal Refactor

Resolves #

Description
Proposed Changes

Screenshots

License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Looks like we need to allow the left rail to scroll

Looks like labels are out of sync for new schedules and for some reason the format selector is disabled:


Build fails when using multiple repositories and the 1st repository times out

If I list multiple maven repositories and the 1st one tmeouts, the build fails
Expected Behavior

I  would like the 2nd and 3rd repositories to be tried
Current Behavior

The build fails, but does list the multiple repositores
Context

Unable to build, have to comment out repositories that timeout
Steps to Reproduce (for bugs)

Your Environment

Build scan URL:

This is a design decision to give confidence in build reproducibility. If Gradle was to ignore these timeouts, someone else building the project could end up with different binary artifacts if there was a difference in them between two repositories.
Can't you do something about these timeouts at the source? Did you try with having a mirror repository in your organization that would protect you from these?

thanks, it is the mirrors that are timing out :-)

How does 5.0 place with Lombok?

It should work fine ... given the time since 5.0 was made available 😉
Closing as the reported behavior will not be changed.


Deprecate ReceivedCharacter

Objective

Partially resolves #12639.

Solution

Deprecate ReceivedCharacter.
Replace ReceivedCharacter with KeyboardInput in the relevant examples.

Migration Guide

ReceivedCharacter is now deprecated, use KeyboardInput instead.

What needs to be done before you can take this out of draft?

If we deprecate received character, what's the recommended way to say get a capital character for a text box

If we deprecate received character, what's the recommended way to say get a capital character for a text box

See the updated char_input_events example in this PR. It should record capital letters.

See the updated char_input_events example in this PR. It should record capital characters.

I tried it out and it does seem to provide what is needed, but it's not an exact 1-1 replacement, since it includes both pressed and released events. The equivalent to ReceivedCharacter would be if you filtered out the Released events. Could you something like the following code snippet in the migration guide.
// Before
fn my_system(events: EventReader<ReceivedCharater>) {
  for event in events.read() {
    info!("{}", event.char);
  }
}
// After
fn my_system(events: EventReader<ReceivedCharater>) {
  for event in events.read().filter(|event| event.state == ButtonState::Released) {
    if let Key::Character(character) = &event.logical_key {
      info!("{}", character);
    }
  }
}

I tried it out and it does seem to provide what is needed, but it's not an exact 1-1 replacement, since it includes both pressed and released events. The equivalent to ReceivedCharacter would be if you filtered out the Released events. Could you something like the following code snippet in the migration guide.

Yeah I accounted for this in the text_input example. I'll add it to the migration guide too.

I won't block on figuring out how to localize those deprecated warnings: they'll be cleaned up shortly after the release anyways.

Does clippy warn on unused allows? If it doesn't we might want to leave some TODO's to remove the allow(deprecated)'s once ReceivedCharacter is removed.


new states BaseStateCallback

[problem]
i want to log all states. But missing state: host connection error
[decision]
add new state; host_connect_error

[problem]
some manipulations need to be done before connecting to the host
[decision]
add new state: preparation

I have implemented both of these in https://github.com/Fizzadar/pyinfra/commit/b102d3f031149b307380f419c3b3c96e91eb8343, pending the v1.2 release in the coming days!


Automatic detection on your site whether the files to be compressed to PHAR are in a folder and move them

Hello, I'm going to start referring those who use my plugins to pmt.mcpe.fun so that they can create the PHARS and upload the plugins to their servers, but it happens that when the download button is used in GitHub, a folder called "master" is created and it contains the files of the plugin. Could you add this method somehow? Thank you.

Hello,
There is already a system like this is the Phar builder system.
Is your file converted when you upload it? If so that means the website has found that there were a folder inside and so converts it.

Ok, I think there was an issue while converting files to .zip so it's my fault
I already fixed it.
Thank anyway.

☆∂єvєlσρєя☆
кєνιи αи∂яєωѕ

We do not allow self-hosted instances publicly! Otherwise Good Luck!


[wip] apps/socket/raw.lua:119: Message too long

apps/socket/raw.lua:119: Message too long
stack traceback:
core/main.lua:130: in function <core/main.lua:128>
[C]: in function 'error'
apps/socket/raw.lua:18: in function 'assert'
apps/socket/raw.lua:119: in function 'transmit'
apps/socket/raw.lua:95: in function 'method'
core/app.lua:84: in function 'with_restart'
core/app.lua:332: in function 'thunk'
core/histogram.lua:98: in function 'breathe'
core/app.lua:270: in function 'main'
program/snabbvmx/lwaftr/lwaftr.lua:170: in function 'run'
program/snabbvmx/snabbvmx.lua:17: in function 'run'
core/main.lua:49: in function <core/main.lua:36>
[C]: in function 'xpcall'
core/main.lua:172: in main chunk
[C]: at 0x004535b0
[C]: in function 'pcall'
core/startup.lua:3: in main chunk
[C]: in function 'require'
[string "require "core.startup""]:1: in main chunk
Happens when running http over snabbvmx via lwaftr using linux network interfaces via rawSocket.
Thought I'll document it for now.
Using branch lwaftr with https://github.com/Igalia/snabb/pull/402

Well, turns out this is a result of using large MTU's within snabbvmx while connecting to a linux interface with a default mtu of 1500. Not much can be done to catch this IMHO, other than making sure, the MTU of the linux interface is set accordingly before launching snabbvmx.


The app does not show up in the menu bar - solution

The app does not show up in the menu bar
macOS hides menu bar apps when there is no space left in the menu bar. This is a common problem on MacBooks with a notch. Try quitting some menu bar apps to free up space. If this does not solve it, try quitting Bartender if you have it installed.

You can sort icons in MenuBar using Cmd button + mouse.
No need to use any extra soft like Bartender. Just move app to the right corner of Menubar :)

I don't think you are fully understanding what the text is saying. It's about what to do if you cannot see the menu bar item in the menu bar. It's not a recommendation to use Bartender.


Add Transform loop support.

How do you feel about required calls to base.*? I've started to not like them in general and functionality which serves a "required" purpose should be encapsulated better. Would you have anything against having a separate method to update loops, and calling Apply after? Something like:
foreach (ITransform transform in Transformations) {
    transform.UpdateLoops();
    transform.Apply();

actually i wanted to bring this up with you yesterday. i tend to agree, and think that base calls are clumsy and prone to user error. this is being used in other places, so we should probably create an issue remind us to go through and fix them all up.

So it looks like derived members will use the base member's default parameters, which is the reason the menu transforms aren't working. https://github.com/peppy/osu-framework/blob/loop-support/osu.Framework/Graphics/Transformations/ITransform.cs#L22 Should have loopCount = -1.

Oops, completely missed that!


Broken Configs

None of the configs aside from the skip confirmation are working.

Seems to work fine for me, can you provide any more information? Which configs are you testing? How are you testing them? What isn't happening that you expect to, or vise versa

Closing as no further info has been provided, feel free to reopen with more info


Unable to resolve "xxx.vcxproj"

I tried to build the SDK from source, so I followed the steps here: https://github.com/Microsoft/WinObjC/wiki/Building-From-Source#setup. However, when I run
"..tools\nuget.exe restore .\build\build.sln",  the output from powershell window:
PS C:\Users\User\Desktop\winobjc_git\WinObjC> ..tools\nuget.exe restore .\build\build.sln
MSBuild auto-detection: using msbuild version '15.1.1012.6693' from 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\bin'.
Restoring packages for C:\Users\User\Desktop\winobjc_git\WinObjC\build\WinObjC.Frameworks.Core\WinObjC.Frameworks.Core.nuproj...
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CFNetwork\dll\CFNetwork.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CoreFoundation\dll\CoreFoundation.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Foundation\dll\Foundation.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\MobileCoreServices\dll\MobileCoreServices.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Starboard\dll\Starboard.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CFNetwork\dll\CFNetwork.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CoreFoundation\dll\CoreFoundation.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Foundation\dll\Foundation.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\MobileCoreServices\dll\MobileCoreServices.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Starboard\dll\Starboard.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CFNetwork\dll\CFNetwork.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CoreFoundation\dll\CoreFoundation.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Foundation\dll\Foundation.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\MobileCoreServices\dll\MobileCoreServices.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Starboard\dll\Starboard.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CFNetwork\dll\CFNetwork.vcxproj' for 'UAP,Version=v10.0 (win-x86)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CoreFoundation\dll\CoreFoundation.vcxproj' for 'UAP,Version=v10.0 (win-x86)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Foundation\dll\Foundation.vcxproj' for 'UAP,Version=v10.0 (win-x86)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\MobileCoreServices\dll\MobileCoreServices.vcxproj' for 'UAP,Version=v10.0 (win-x86)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Starboard\dll\Starboard.vcxproj' for 'UAP,Version=v10.0 (win-x86)'.
Committing restore...
Lock file has not changed. Skipping lock file write. Path: C:\Users\User\Desktop\winobjc_git\WinObjC\build\WinObjC.Frameworks.Core\obj\project.assets.json
Restore failed in 339.95 ms for C:\Users\User\Desktop\winobjc_git\WinObjC\build\WinObjC.Frameworks.Core\WinObjC.Frameworks.Core.nuproj.
Restoring packages for C:\Users\User\Desktop\winobjc_git\WinObjC\build\WinObjC.Frameworks.ThirdParty\WinObjC.Frameworks.ThirdParty.nuproj...
Committing restore...
Lock file has not changed. Skipping lock file write. Path: C:\Users\User\Desktop\winobjc_git\WinObjC\build\WinObjC.Frameworks.ThirdParty\obj\project.assets.json
Restore completed in 9.4 ms for C:\Users\User\Desktop\winobjc_git\WinObjC\build\WinObjC.Frameworks.ThirdParty\WinObjC.Frameworks.ThirdParty.nuproj.
Restoring packages for C:\Users\User\Desktop\winobjc_git\WinObjC\build\WinObjC.Frameworks.UWP.Core\WinObjC.Frameworks.UWP.Core.nuproj...
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CFNetwork\dll\CFNetwork.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CoreFoundation\dll\CoreFoundation.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Foundation\dll\Foundation.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\MobileCoreServices\dll\MobileCoreServices.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Starboard\dll\Starboard.vcxproj' for 'UAP,Version=v10.0'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CFNetwork\dll\CFNetwork.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CoreFoundation\dll\CoreFoundation.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Foundation\dll\Foundation.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\MobileCoreServices\dll\MobileCoreServices.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Starboard\dll\Starboard.vcxproj' for 'UAP,Version=v10.0 (win)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CFNetwork\dll\CFNetwork.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CoreFoundation\dll\CoreFoundation.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Foundation\dll\Foundation.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\MobileCoreServices\dll\MobileCoreServices.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Starboard\dll\Starboard.vcxproj' for 'UAP,Version=v10.0 (win-x64)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CFNetwork\dll\CFNetwork.vcxproj' for 'UAP,Version=v10.0 (win-x86)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\CoreFoundation\dll\CoreFoundation.vcxproj' for 'UAP,Version=v10.0 (win-x86)'.
Unable to resolve 'C:\Users\User\Desktop\winobjc_git\WinObjC\build\Foundation\dll\Foundation.vcxproj' for 'UAP,Version=v10.0 (win-x86)'.
can anyone help?

Hi @lafezhang
This usually indicates that nuget can't load the project for some reason. Unfortunately nuget.exe doesn't give the best error messages for this.
From a Developer Command Prompt for VS 2017 (you should be able to search your start menu for this), navigate to the folder where build.sln is and try running:
msbuild .\build.sln /t:Restore /p:Configuration=Debug /p:Platform=x86
This will run the restore target that nuget uses to inspect the projects and should provide a little more information on what is going wrong. A first guess is that git lfs may not have run and some binary used in the build (like .\common\gitversiontask\4.0.0-beta0011\build\GitVersionTask.dll) isn't actually pulled down and it can't load the placeholder file.
Please let me know what the issue ends up being so that I can update https://github.com/Microsoft/WinObjC/wiki/Packaging#known-issues to help other folks in the future.
Thanks!

ok. It seems that the repo can not be cloned using Mac (even with git-lfs installed), it must be cloned using Windows

Closing since this was figured out.


System Font stacks instead of current one

Read this article => https://www.smashingmagazine.com/2015/11/using-system-ui-fonts-practical-guide/
Some more Info => https://css-tricks.com/snippets/css/system-font-stack/
Some already implemented examples

Github's website
Medium's website
Bootstrap framework
Wordpress CMS
and many more

Code i would request to change
$body-font-family: 'Helvetica Neue', Helvetica, Roboto, Arial, sans-serif !default;
New code
$body-font-family: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Helvetica Neue", Helvetica, Arial, sans-serif !default;
If its get decided to not use linux specific ones and firefox specific system fonts then,
$body-font-family: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", "Roboto", "Helvetica Neue", Helvetica, Arial, sans-serif !default;

First, I seen you opened a lot of issues these last days. Thank you a lot for your work, you help to make Foundation even better !
Concerning this issue, I agree we should at least make the font override for "Helvetica" optioned, and maybe disabled by default. But I don't know if updating $body-font-family would be a great idea. We are taking about low-level reset, not "styling option". In any case, we also have to disable the font-family Normalize set on <html>.

So what do you think will be a best option ?

I am not sure. I thought about something like:
$body-font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
$body-font-family-system: true;

...

$-zf-system-fonts: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans";

...

$font: $body-font-family;
@if $body-font-family-systems == true {
  $font: join($-zf-system-fonts, $font);
}

It allows to easily enable/disable the support for system font stacks, or to change the font family without disabled it (but this last case is not common). But maybe it is over-engineering.

Yup a bit of over engineering :smile_cat: but i liked it :+1:

Curious what @andycochran and @brettsmason think

The first thing I usually do is change the font stack to exactly whats suggested and I think it makes perfect sense. I feel like @ncoden suggestion might be a bit complex for this, but that might be just me :smile:

It is a more complex suggestion to fulfill to complex expectations 😄 .
I do not like the idea of defining a list of font families with inside system fonts, default font and compatibility fonts, to use like it is or to fully redefine. We should provide a way to easily enable and disable some behaviors of fonts.

@brettsmason I have to say that I like Nicolas suggestion and frankly brain but yes might be over engineering and might not make sense as there is no need to enable disable,
So my questions are

So are you up for changing on body-font-family ?
Should Firefox and Linux ones be added or not ?

But enable disable might come handy later when people look to change fonts to web fonts like Google and Adobe typekit ?

@ncoden, could we simply do this?
$body-font-family: $-zf-system-fonts;

I don't think we need the @if to determine whether or not to use the system fonts variable. If you don't want to use system fonts, just use your own stack.
(I'm not sure that even needs to be a private -zf var.)

I have to say of all the suggestions including me, i liked the @andycochran one's the best one
so i just tried it out ( _settings & _global )
$-zf-system-fonts: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans" !default;
$-zf-fallback-fonts: 'Helvetica Neue', Helvetica, Arial, sans-serif !default;

$body-font-family: join($-zf-system-fonts, $-zf-fallback-fonts);

Generated CSS
h1, h2, h3, h4, h5, h6 {
  font-family: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Helvetica Neue", Helvetica, Arial, sans-serif; }
body {
  font-family: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Helvetica Neue", Helvetica, Arial, sans-serif; }

But still say a bit confused about these linux and firefox ones ?

$body-font-family: join($-zf-system-fonts, $-zf-fallback-fonts);

So folks have to manually join their font with $-zf-system-fonts if they want to change the font while keeping the support for System fonts.
I agree your propositions are simple because of there is not a lot of code to add, but it is not simple to use.
A list of font families is not a simple list, it is a stack of different groups of fonts, and we should provide settings that reflect this fact.

So what would be your code then ? @ncoden

// scss/_global.scss
$system-font-family: -apple-system, system-ui, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans";
$body-font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;

...

body {
  font-family: font-family($body-font-family);
}

// scss/typography/_base.scss
@function font-family( // or `zf-font-family`
  $font: $body-font-family,
// $compatibility-font: ...,
  $system-font: $system-font-family,
) {
  @if $system-font != null and $system-font != false {
    $font: join($system-font, $font);
  }
  @return $font;
}

// in any component
font-family: font-family(MyFont, $system-font: false);

There is two concept in this example:

Provide partitioned settings to allow to enable/disable/modify it easily.
Modularize settings processing to allow to use custom settings globally and locally.

but we have to change _settings file also as all the h1 to h6 elements has been duplicated (hardcode) there with
$body-font-family: 'Helvetica Neue', Helvetica, Roboto, Arial, sans-serif !default;
Just a reminder

we have to change _settings file

settings/_settings.scss is automatically generated from the global variables inside component files.
@kball A lot of folks did not understand that, and it's normal. We should definitely move this generated file to its rightful place: in dist.

@kball Many folks did not understood that, and it's normal. We should definitely move this generated file to its rightful place: in dist.

👍

I'm not sure I understand why we need the join(). It seems like you either want to use system fonts or not. If I'm defining my own custom font stack, I'm just gonna clobber the framework's defaults.

@andycochran This is why I used at first a private $-zf- variable.

I still don't understand the need for any functions. Why not simply have a public $system-font-family var and use that throughout settings?
$body-font-family: $system-font-family, "Helvetica Neue", Helvetica, Arial, sans-serif;

And if I don't wanna use system fonts I remove it:
$body-font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;

Or if I wanna use a custom stack, I clobber the whole var:
$body-font-family: "Preferred Font", "Backup Font", fantasy;

Well, I could say this is not really the same thing (see http://www.sassmeister.com/gist/b094cc43fe09851c535b70163c96f1fb), but you are right, it is simpler and almost the same thing.
Also, if you want to disable browser fonts, your have to redefine the entirely font list.

@ncoden @kball @andyrochan @brettsmason
So guys are we on any final code ??
For me though, my last comment is the way to go !!

Merged here: #9644
So closing this! Thanks.


Refactor PolicySource from ECP creation

There is no need to return an error from FetchPolicySources, and since FetchPolicySources is not fetching the policy sources, only constructing a slice of PolicySources let's call it PolicySourcesFrom instead.

Pulled out of #2048


Fixes leaks when running editor

With my other two PR's fixes #36597
This leaks was really hard to track, but easy to fix.

Thanks!


Cannot resolve bases - Dj 1.8.7, Dj-CMS 3.2.0

I'm currently building a new django-cms site and so I often reinstalled the venv and so on and migrated the db and so on but suddenly it doesn't work anymore:
When I want to migrate the db (no matter if it's an existing or a new db) (sqlite3) it always fails:
Operations to perform:
  Synchronize unmigrated apps: staticfiles, messages, djangocms_admin_style, sitemaps, sekizai, fablab_website, djangocms_style, treebeard, djangocms_teaser
  Apply all migrations: djangocms_flash, djangocms_file, reversion, djangocms_inherit, sessions, admin, djangocms_column, sites, auth, djangocms_video, menus, contenttypes, djangocms_picture, djangocms_googlemap, djangocms_link, cms, djangocms_text_ckeditor
Synchronizing apps without migrations:
  Creating tables...
    Running deferred SQL...
  Installing custom SQL...
Running migrations:
  Rendering model states...Traceback (most recent call last):
  File "./manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/tmp/website/venv/lib/python2.7/site-packages/django/core/management/__init__.py", line 354, in execute_from_command_line
    utility.execute()
  File "/tmp/website/venv/lib/python2.7/site-packages/django/core/management/__init__.py", line 346, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/tmp/website/venv/lib/python2.7/site-packages/django/core/management/base.py", line 394, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/tmp/website/venv/lib/python2.7/site-packages/django/core/management/base.py", line 445, in execute
    output = self.handle(*args, **options)
  File "/tmp/website/venv/lib/python2.7/site-packages/django/core/management/commands/migrate.py", line 222, in handle
    executor.migrate(targets, plan, fake=fake, fake_initial=fake_initial)
  File "/tmp/website/venv/lib/python2.7/site-packages/django/db/migrations/executor.py", line 100, in migrate
    state.apps  # Render all real_apps -- performance critical
  File "/tmp/website/venv/lib/python2.7/site-packages/django/utils/functional.py", line 59, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/tmp/website/venv/lib/python2.7/site-packages/django/db/migrations/state.py", line 166, in apps
    return StateApps(self.real_apps, self.models)
  File "/tmp/website/venv/lib/python2.7/site-packages/django/db/migrations/state.py", line 232, in __init__
    self.render_multiple(list(models.values()) + self.real_models)
  File "/tmp/website/venv/lib/python2.7/site-packages/django/db/migrations/state.py", line 270, in render_multiple
    "for more" % (new_unrendered_models, get_docs_version())
django.db.migrations.state.InvalidBasesError: Cannot resolve bases for [<ModelState: 'djangocms_style.Style'>, <ModelState: 'djangocms_teaser.Teaser'>]
This can happen if you are inheriting models from an app with migrations (e.g. contrib.auth)
 in an app with no migrations; see https://docs.djangoproject.com/en/1.8/topics/migrations/#dependencies for more

The settings are here: https://github.com/fau-fablab/website/blob/djangocms/djangocms/fablab_website/settings.py
And this are the packages installed in my venv:
Django==1.8.7
django-appconf==1.0.1
django-classy-tags==0.7.0
django-cms==3.2.0
django-compressor==1.6
django-formtools==1.0
django-reversion==1.8.7
django-sass-processor==0.3.0
django-sekizai==0.9.0
Django-Select2==4.3.2
django-treebeard==3.0
djangocms-admin-style==1.0.7
djangocms-column==1.6.0
djangocms-file==0.2.0
djangocms-flash==0.3.0
djangocms-googlemap==0.4.0
djangocms-inherit==0.1.1
djangocms-link==1.7.1
djangocms-picture==0.2.0
djangocms-style==1.6.0
djangocms-teaser==0.2.0
djangocms-text-ckeditor==2.8.0
djangocms-video==0.2.0
html5lib==0.9999999
libsass==0.9.3
Pillow==3.0.0
pytz==2015.7
six==1.10.0

Running everything with python2 didn't change anything.

Do you have  MIGRATION_MODULES  set in settings.py?

Thanks for your reply.
Yes, I added this:
MIGRATION_MODULES = {
    'djangocms_style': 'djangocms_style.migrations_django',
    'djangocms_teaser': 'djangocms_teaser.migrations_django'
}

(You can see my config here: https://github.com/fau-fablab/website/blob/djangocms/djangocms/fablab_website/settings.py#L195)

djangocms-teaser changed migration modules layout in 0.2.0 and djangocms-style in 1.6.0, so you need to remove those lines.
Probably those two new versions have been released after you create the first draft of your project and when you later recreated the virtualenv without pinning the package versions of the draft of the project

Oh, you're great :D have you a good tactic to prevent those issues? Is it a good idea to add a single version of each package to requirements.txt? Or is there a way to get informed about those changes?

Best option is usually is saving the output of pip freeze to the requirements file and use something like requires.io to check for updates


Finish Numpy SMA backend

Details:

Implement logic for sampling argument for SMA operator.
Add support for missing values (represented as NaN) for SMA operator.
Improve coverage of unit tests for SMA operators and API.

Also:

Modify the evaluation logic so that operator implementation classes expect the corresponding operator object as the only constructor argument. Prior to this change, operator implementation classes were expecting the unfolded serialized attributes of the operator class.
The query argument of the evaluate method can be an event, list of events, or dictionary of string-to-events. The returned values of the evaluate method is of the same type as the  query argument. For example, if the query is a dictionary of events, the returns is a dictionary (with the same keys) of event values.
The evaluate method cannot return anymore a dictionary  indexed by event.

Thanks for the thorough review


fix(batch-worker): schema breaking changes

Schema changes due to limiting the size of POV created breaking changes to how schemas are accessed.
Update how schemas are queried to ensure that a schema payload is returned.
#84

Good idea. I'll create a ticket for it.


Bug: forwardslash missing in File Inputs SourceURL

In the File Inputs section, when using the SourceURL, the forwardslash after the system Name is left off.
Example:
tapis://af_test_system/test_directory/test1.txt
is populated as
tapis://af_test_systemtest_directory/test1.txt

FILES MODAL MISSING : or / AFTER “Files”
Should be select system -> select file
AFTER SYSTEM Selected -> select file
/ missing after first file path
EX:
It should be
Files: tapisv3-exec2-demo-final/finaltest/file1.txt
not
Files tapisv3-exec2-demo-finalfinaltest/file1.txt


Apt-get update issue

Hi
when I do sudo apt-get update i get the below error. Because of the error I am unable to do apt update through ansible script.
devops@ip-172-31-45-218:~$ sudo apt update
Hit:1 http://us-west-2.ec2.archive.ubuntu.com/ubuntu focal InRelease
Hit:2 http://us-west-2.ec2.archive.ubuntu.com/ubuntu focal-updates InRelease
Hit:3 http://us-west-2.ec2.archive.ubuntu.com/ubuntu focal-backports InRelease
Hit:4 http://security.ubuntu.com/ubuntu focal-security InRelease
Ign:5 http://ppa.launchpad.net/ansible/ansible/ubuntu focal InRelease
Err:6 http://ppa.launchpad.net/ansible/ansible/ubuntu focal Release
404  Not Found [IP: <IP_ADDRESS> 80]
Reading package lists... Done
E: The repository 'http://ppa.launchpad.net/ansible/ansible/ubuntu focal Release' does not have a Release file.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.

is issue solved or not?

is issue solved or not?

I started using Ubuntu 18 instead of ubuntu 20 and it started working.
On Thu, Jan 21, 2021 at 9:12 AM santhoshd402<EMAIL_ADDRESS>wrote:

is issue solved or not?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/QT-DevOps/DevOpsIssues/issues/982#issuecomment-764668915,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMGGX6GAIN4HDYCIT6KNA33S3AY3ZANCNFSM4VHSXLKQ
.

I started using Ubuntu 18 instead of ubuntu 20 and it started working.
On Thu, Jan 21, 2021 at 9:12 AM santhoshd402<EMAIL_ADDRESS>wrote:

is issue solved or not?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/QT-DevOps/DevOpsIssues/issues/982#issuecomment-764668915,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMGGX6GAIN4HDYCIT6KNA33S3AY3ZANCNFSM4VHSXLKQ
.


[REQ] Deprecate python 3.8

Python 3.8 will reach its end of life in October 2024.
Therefore, we will deprecate it and require at least Python 3.9 in future releases.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 89.021%

Totals

Change from base Build<PHONE_NUMBER>6:
0.07%

Covered Lines:
1346

Relevant Lines:
1512

💛  - Coveralls


fix: docs.rs compilation error

Re #4841
AFAIK this line is not neccessary, and fedimint-core always enables sync on tokio, which this conditional seems to be related to.

Do we know where the discrepancy is? Is it worth filing a bug to add a CI check to prevent regressions?

Do we know where the discrepancy is? Is it worth filing a bug to add a CI check to prevent regressions?

Not really. It's just conditional compilation was hidding a directive that works only on nightly rust, etc. unlikely it will happen again, so I wouldn't overreact.

Flake. Back to the merge queue.

Flake.

Looks like a timeout - would it be worth bumping the threshold again like #3269 did? (But also for CI)

FWIW I ran into a timeout while submitting #4908 earlier today as well: https://github.com/fedimint/fedimint/pull/4908#event-12453913496

Looks like a timeout - would it be worth bumping the threshold again like #3269 did? (But also for CI)

Looks like test going wrong somewhere and getting stuck, I don't think bumping any timeouts will help. We need to diagnose and fix.


Adjust report

Adjust report, added "%" for coverage and dupplication rating

Pull Request Test Coverage Report for Build 333487933

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+4.5%) to 60.193%

Totals

Change from base Build 331354711:
4.5%

Covered Lines:
437

Relevant Lines:
726

💛  - Coveralls


indicators variables not changing the actual indicator colors

the --online-dot, --dnd-dot, --idle-dot variables don't seem to change the colors of the indicators in discord
changing the colors of these variables in the QuickCSS in vencord

results in nothing happening

oops


Ct/institutions local

Adding a base institution list via the ucw_institution_mapping.json file which is a db export of MX production institution data.
Using ElasticSearch to index the json file and make it searchable
Created a basic institution resolver that knows how to use the new institution search

There are a couple more things I'd like to refactor a bit. I will mark it as "ready for review" and post in the slack channel when I'm ready for another review.


Please Update

[Please Update]
Hello
You are referencing the documentation for adding BitLocker keys to ADDS from a 2013 article and the information on that page is incorrect. Can you please update this article locally to include processes for adding BitLocker TPM keys backup for Domain Functionality Level 2016 and up.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bc400fe3-985e-44a5-d88d-27048d432124
Version Independent ID: bc400fe3-985e-44a5-d88d-27048d432124
Content: Back up TPM recovery information to Active Directory - Windows Security
Content Source: windows/security/hardware-security/tpm/backup-tpm-recovery-information-to-ad-ds.md
Product: windows-client
Technology: itpro-security
GitHub Login: @vinaypamnani-msft
Microsoft Alias: vinpa

To make it easier for you to submit feedback on articles on learn.microsoft.com, we're transitioning our feedback system from GitHub Issues to a new experience.
As part of the transition, this GitHub Issue will be moved to a private repository. We're moving Issues to another repository so we can continue working on Issues that were open at the time of the transition. When this Issue is moved, you'll no longer be able to access it.
If you want to provide additional information before this Issue is moved, please update this Issue before December 15th, 2023.
With the new experience, you no longer need to sign in to GitHub to enter and submit your feedback. Instead, you can choose directly on each article's page whether the article was helpful. Then you can then choose one or more reasons for your feedback and optionally provide additional context before you select Submit.
Here's what the new experience looks like.
Note: The new experience is being rolled out across learn.microsoft.com in phases. If you don't see the new experience on an article, please check back later.
First, select whether the article was helpful:

Then, choose at least one reason for your feedback and optionally provide additional details about your feedback:

Article was helpful
Article was unhelpful

Finally, select Submit and you're done!


Refactor PyRFLX

The current implementation needs some refactoring and/or documentation since there are a multitude of methods whose purpose and functionality are not clear from the code.
Some things that are not clear yet (not exhaustive):

Semantic of `_is_valid_opaque_field? (in the sense of in which case is an opaque field valid)
Workings of the Checksum class, especially the meaning of ExpressionTuple

Furthermore checks should be cleanly separated from state changing methods:

_is_checksum_settable changes the internal state of the message, respectively its checksums while the name indicated that it is just a simple state check.
_is_checksum_settable also contains a circular dependency by depending on ValidChecksum (it depends on _next_field finding Final which has ValidChecksum as an incoming condition).

The original idea was to use the ValidChecksum attribute to determine the dependencies of a checksum (cf. https://github.com/Componolit/RecordFlux/issues/222#issuecomment-626812392). The ValidChecksum attribute defines which fields must be set before the checksum calculation can be performed. The reason for this approach was to avoid any heuristics when determining on which fields a checksum depends. It should be investigated, whether this approach simplifies the current code and whether the current approach (which seems to ignore ValidChecksum) works in all cases.


Feature Suggestion - Burrito Runner Integration with Terraform Shared Cache on S3

When managing numerous layers with Burrito, users may encounter high network traffic volume from downloading Terraform plugins.
Terraform offers a solution to reduce the volume of plugin downloads by enabling the sharing of caches between layers on a local machine, as detailed in this blog post: Terraform Plugin Caching.
It would be great if there was an option for Burrito runners to seamlessly download the contents of a Terraform shared cache stored on Amazon S3 and update its content after its plan / apply operation.
What do you think about it ?

I think we can introduce a network_mirror in the upcoming datastore API to reduce this network overhead, however I do not think this should be handled by the runner, this will require a bit of dev if we want to support it with Burrito.
I think it's possible to introduce it without Burrito though using this project : https://github.com/straubt1/terraform-network-mirror .
The implementation we would have on Burrito' side would be more of a cache compared to the mirror project I linked to you


Implement rotating status hook thing

I want modules to be able to modify the Playing status, but I want it to be simple for multiple modules to use it at once. It'd be easy to make a k8000.statuses object, each module having its own array.

A nowPlaying() method for modules would probably be the best way to go


Final issues fixed (main)

any issues with this PR?

I'm guessing you're referring to the exception cases.
I hadn't planned on adjusting those. Replacing the function calls made it easier to control what happens in the exception case.

The only code I see that could be a little better is code dealing with is_group and switch_user.

yeah, just that those blocks are all relatively identical.    future work, if ever.
em if you're happy.

i've consolidated the duplicate exception blocks into different functions.
merging now.