Strange dirty behavior in PersistentCollection

Scenario

Using CTI with a ManyToMany relationship in the abstract class (Not sure if is related...)
All entities involved in this scenario are persisted and flushed previously (fixtures)
In this field I have a valid Collection with some entities (Categories)
I do flush($product) of the main entity (Product)
I do flush($product) again of the main entity.
An exception is thrown.

An exception occurred while executing 'INSERT INTO purchasable_category
(purchasable_id, category_id) VALUES (?, ?)' with params [6, 1]:

SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate
entry '6-1' for key 'PRIMARY'

The mapping code
We have the Purchasable mapping file (abstract one)
Elcodi\Component\Product\Entity\Purchasable:
    type: entity
    repositoryClass: Elcodi\Component\Product\Repository\PurchasableRepository
    table: purchasable
    inheritanceType: joined
    discriminatorColumn:
        name: purchasable_type
        type: string
    id:
        id:
            type: integer
            generator:
                strategy: AUTO

    fields:
        name:
            column: name
            type: string
            length: 255
            nullable: true
        sku:
            column: sku
            type: string
            length: 255
            nullable: true
        slug:
            column: slug
            type: string
            length: 255
            nullable: true
        shortDescription:
            column: short_description
            type: string
            length: 255
            nullable: true
        description:
            column: description
            type: text
            nullable: true
        showInHome:
            column: show_in_home
            type: boolean
            nullable: true
        dimensions:
            column: dimensions
            type: string
            length: 255
            nullable: true
        stock:
            column: stock
            type: integer
            nullable: true
        price:
            column: price
            type: integer
            nullable: true
        reducedPrice:
            column: reduced_price
            type: integer
            nullable: true
        height:
            column: height
            type: integer
            nullable: true
        width:
            column: width
            type: integer
            nullable: true
        depth:
            column: depth
            type: integer
            nullable: true
        weight:
            column: weight
            type: integer
            nullable: true
        imagesSort:
            column: images_sort
            type: string
            length: 2048
            nullable: true
        metaTitle:
            column: meta_title
            type: string
            length: 255
            nullable: true
        metaDescription:
            column: meta_description
            type: string
            length: 255
            nullable: true
        metaKeywords:
            column: meta_keywords
            type: string
            length: 255
            nullable: true
        createdAt:
            column: created_at
            type: datetime
            nullable: false
        updatedAt:
            column: updated_at
            type: datetime
            nullable: false
        enabled:
            column: enabled
            type: boolean
            nullable: false

    manyToOne:
        principalCategory:
            targetEntity: Elcodi\Component\Product\Entity\Interfaces\CategoryInterface
            joinColumn:
                name: principal_category_id
                referencedColumnName: id
                nullable: true
                onDelete: "SET NULL"
        principalImage:
            targetEntity: Elcodi\Component\Media\Entity\Interfaces\ImageInterface
            joinColumn:
                onDelete: SET NULL
                name: principal_image_id
                referencedColumnName: id
                nullable: true
        priceCurrency:
            targetEntity: Elcodi\Component\Currency\Entity\Interfaces\CurrencyInterface
            joinColumn:
                 name: price_currency_iso
                 referencedColumnName: iso
                 nullable: true
        reducedPriceCurrency:
            targetEntity: Elcodi\Component\Currency\Entity\Interfaces\CurrencyInterface
            joinColumn:
                 name: reduced_price_currency_iso
                 referencedColumnName: iso
                 nullable: true
        manufacturer:
            targetEntity: Elcodi\Component\Product\Entity\Interfaces\ManufacturerInterface
            inversedBy: purchasables
            joinColumn:
                name: manufacturer_id
                referencedColumnName: id
                nullable: true
                onDelete: "SET NULL"

    manyToMany:
        images:
            targetEntity: Elcodi\Component\Media\Entity\Interfaces\ImageInterface
            joinTable:
                name: purchasable_image
                joinColumns:
                    product_id:
                        referencedColumnName: id
                        onDelete: "CASCADE"
                inverseJoinColumns:
                    image_id:
                        referencedColumnName: id
                        onDelete: "CASCADE"

        categories:
            targetEntity: Elcodi\Component\Product\Entity\Interfaces\CategoryInterface
            inversedBy: purchasables
            joinTable:
                name: purchasable_category
                joinColumns:
                    purchasable_id:
                        referencedColumnName: id
                        onDelete: "CASCADE"
                inverseJoinColumns:
                    category_id:
                        referencedColumnName: id
                        onDelete: "CASCADE"

    lifecycleCallbacks:
        preUpdate: [loadUpdateAt]
        prePersist: [loadUpdateAt]

And we have the specific Product mapping file (Extends Purchasable)
Elcodi\Component\Product\Entity\Product:
    type: entity
    repositoryClass: Elcodi\Component\Product\Repository\ProductRepository
    table: product

    manyToOne:
        principalVariant:
            targetEntity: Elcodi\Component\Product\Entity\Interfaces\VariantInterface
            joinColumn:
                name: principal_variant_id
                referencedColumnName: id
                nullable: true
                onDelete: "SET NULL"

    oneToMany:
        variants:
            targetEntity: Elcodi\Component\Product\Entity\Interfaces\VariantInterface
            mappedBy: product
            cascade: [ "all" ]
            orphanRemoval: true

    manyToMany:
        attributes:
            targetEntity: Elcodi\Component\Attribute\Entity\Interfaces\AttributeInterface
            joinTable:
                name: product_attribute
                joinColumns:
                    product_id:
                        referencedColumnName: id
                        onDelete: "CASCADE"
                inverseJoinColumns:
                    attribute_id:
                        referencedColumnName: id
                        onDelete: "CASCADE"

The crashing code
This code is part of a service. productObjectManager can be considered as the default entity manager. The exception is produced by the second call.
$this
    ->productObjectManager
    ->flush($purchasable);

$this
    ->productObjectManager
    ->flush($purchasable);

Some tips
When I do flush in the first time, the Collection of Category instances is set to dirty. After some investigation, https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/UnitOfWork.php#L607 this line is the one that set this value.
// Inject PersistentCollection
$value = new PersistentCollection(
    $this->em, $this->em->getClassMetadata($assoc['targetEntity']), $value
);
$value->setOwner($entity, $assoc);
$value->setDirty( ! $value->isEmpty());

$class->reflFields[$name]->setValue($entity, $value);

Commenting this line, everything works as expected (I know that that's not an option), but I would like to understand what implies this line and why is there.
Any help please?
Any idea of what could be the issue?

Can you make a gist containing the entities and persistance code leading to the error?

@zeroedin-bill Updated :)

Hmm. I haven't seen someone use interfaces as targetEntity before, but I really don't know what is going on here. @Ocramius, @guilhermeblanco, any ideas?

@zeroedin-bill the resolve target entity does the work :)
http://symfony.com/doc/current/cookbook/doctrine/resolve_target_entity.html

ping @acasademont

I got it.
Look at this piece of code.
$categories = $product->getCategories();
$newCategories = new ArrayCollection();
foreach ($categories as $category) {
    $newCategories->add($category);
}
$product->setCategories($newCategories);

What happens here?
Even if categories are the same, because the object is no longer a PersistentCollection but an ArrayCollection, the element if marked as dirty and is recomputed again as inserts.
I would love to understand why, so I will continue digging in the project, but if you can give me some light, would be nice :)
@zeroedin-bill @Ocramius

@mmoreram I think we'd really need a failing test case to fully understand what's going on here...

Yes. That's what I working on now :)

:+1:


Content is not read in correct order with Talkback on after Done button

Samsung Galaxy J3 Prime
Android version 7.0
On the on-boarding screen Step 6, after swiping right to each item to "Done" button at the bottom of the screen and if user continues to swipe to the right, Talkback starts reading from "New Brunswick" instead from the top of the screen.
Expected result
Talkback should read from the top of the screen after the "Done" button.
WCAG
https://www.w3.org/WAI/WCAG21/Understanding/focus-order.html
Screenshots

@sarasuri I can't reproduce this. Swiping right for me moves back to the header. Could you retest with the lastest update on Android and let me know if it's still an issue.

@JuliannaR
Initially the focus is on the "Done" button and swiping right takes user to the top. However, if user swipes through to the Done button again and continue swiping right again from the "Done" button at that point it doesn't move back to the header.

@sarasuri similar problem here https://github.com/cds-snc/covid-shield-mobile/issues/548
I've grouped them together.


Adding more trace statements for router operations

Fixing some trace log statements
Adding more trace log statements to track when each request are sent and the response error from every response.

SLA: 10 mins
Reviewers: Priyesh
Built and coding style applied

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@63a5e38). Click here to learn what that means.
The diff coverage is 78.08%.

@@            Coverage Diff            @@
##             master     #657   +/-   ##
=========================================
  Coverage          ?   62.93%
  Complexity        ?     3629
=========================================
  Files             ?      325
  Lines             ?    25327
  Branches          ?     3177
=========================================
  Hits              ?    15939
  Misses            ?     8517
  Partials          ?      871

Impacted Files
Coverage Δ
Complexity Δ

...com.github.ambry/store/ConsistencyCheckerTool.java
0% <0%> (ø)
0 <0> (?)

.../java/com.github.ambry.router/DeleteOperation.java
93.18% <100%> (ø)
44 <0> (?)

...java/com.github.ambry.router/GetBlobOperation.java
88.59% <66.66%> (ø)
31 <0> (?)

.../com.github.ambry.router/GetBlobInfoOperation.java
81.25% <75%> (ø)
31 <0> (?)

...ain/java/com.github.ambry.router/PutOperation.java
90.09% <77.77%> (ø)
70 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a5e38...8847aba. Read the comment docs.

@pnarayanan : appreciate your reviews


llvmPackages*.llvm: Disable checkPhase on powerpc64-linux

Description of changes
Many failures, mostly in MCJIT & Orc(more JIT).
 I can check other versions if desired, but…
Building any LLVM version takes ~10h on my machine, so I haven't done alot of looking into what causes these failures, if any version is unaffected, or if it's potentially caused by using gnuabielfv2.

Clang-based stdenv *mostly works*, though it'll need some help from our cc-wrapper
LLVM/Clang ignores the gnuabielfv{1,2} ABI part of the config triplet and culls it down to just gnu:

Triplet class doesn't have GNUABIELFV1 / GNUABIELFV2 values
/llvm/include/llvm/TargetParser/Triple.h:230-242
Parsing is prefix-based, the final StartsWith("gnu", Triple::GNU) catches the otherwise-unhandled gnuabielfv{1,2} and reduces it to just "gnu"
/llvm/lib/TargetParser/Triple.cpp:622-636
ELF ABI default for ppc64 is determined by examining arch, OS & libc
/llvm/include/llvm/TargetParser/Triple.h:906-912

Which results in the compiler producing ELFv1 objects, even though we're asking for ELFv2 ones. So most linking will fail.
configure:4527: checking whether the C compiler works
configure:4549: clang    conftest.c  >&5
/nix/store/amf0m5dg8iacfy5ni3dk9rpgv8kwrrvg-binutils-2.41/bin/ld: /build/conftest-67e02b.o: ABI version 1 is not compatible with ABI version 2 output
/nix/store/amf0m5dg8iacfy5ni3dk9rpgv8kwrrvg-binutils-2.41/bin/ld: failed to merge target specific data of file /build/conftest-67e02b.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

When running with -v:
clang version 17.0.6
Target: powerpc64-unknown-linux-gnuabielfv2
Thread model: posix
InstalledDir: /nix/store/09cfx6kdrgl622qvv812d1igxhz76xyl-clang-17.0.6/bin
Found candidate GCC installation: /nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0/lib/gcc/powerpc64-unknown-linux-gnuabielfv2/13.2.0
Found candidate GCC installation: /nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0/lib64/gcc/powerpc64-unknown-linux-gnuabielfv2/13.2.0
Selected GCC installation: /nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0/lib64/gcc/powerpc64-unknown-linux-gnuabielfv2/13.2.0
Candidate multilib: .;@m64
Selected multilib: .;@m64
 "/nix/store/09cfx6kdrgl622qvv812d1igxhz76xyl-clang-17.0.6/bin/clang-17" -cc1 -triple powerpc64-unknown-linux-gnuabielfv2 -emit-obj -mrelax-all -dumpdir /dev/shm/conftest- -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name conftest.c -mrelocation-model pic -pic-level 2 -pic-is-pie -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu ppc64 -mfloat-abi hard -target-abi elfv1 -debugger-tuning=gdb -v -fcoverage-compilation-dir=/home/puna/devel/nixpkgs -nostdsysteminc -resource-dir /nix/store/h4li1h7pr918ms4b4bl048kfihcvybaa-clang-wrapper-17.0.6/resource-root -idirafter /nix/store/hcazi292x6d6l782dm6ss20q512a5wrl-glibc-2.38-44-dev/include -internal-isystem /nix/store/h4li1h7pr918ms4b4bl048kfihcvybaa-clang-wrapper-17.0.6/resource-root/include/ppc_wrappers -internal-isystem /nix/store/h4li1h7pr918ms4b4bl048kfihcvybaa-clang-wrapper-17.0.6/resource-root/include -fdebug-compilation-dir=/home/puna/devel/nixpkgs -ferror-limit 19 -fno-signed-char -fgnuc-version=4.2.1 -fcolor-diagnostics -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /tmp/conftest-a4408e.o -x c /dev/shm/conftest.c
clang -cc1 version 17.0.6 based upon LLVM 17.0.6 default target powerpc64-unknown-linux-gnuabielfv2
#include "..." search starts here:
#include <...> search starts here:
 /nix/store/h4li1h7pr918ms4b4bl048kfihcvybaa-clang-wrapper-17.0.6/resource-root/include/ppc_wrappers
 /nix/store/h4li1h7pr918ms4b4bl048kfihcvybaa-clang-wrapper-17.0.6/resource-root/include
 /nix/store/hcazi292x6d6l782dm6ss20q512a5wrl-glibc-2.38-44-dev/include
End of search list.
 "/nix/store/h4li1h7pr918ms4b4bl048kfihcvybaa-clang-wrapper-17.0.6/bin/ld" -pie --hash-style=gnu --eh-frame-hdr -m elf64ppc -o /dev/shm/conftest /nix/store/13mhdf5x574x9wnrjpdk79k8ir52fw5n-glibc-2.38-44/lib/Scrt1.o /nix/store/13mhdf5x574x9wnrjpdk79k8ir52fw5n-glibc-2.38-44/lib/crti.o /nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0/lib/gcc/powerpc64-unknown-linux-gnuabielfv2/13.2.0/crtbeginS.o -L/nix/store/13mhdf5x574x9wnrjpdk79k8ir52fw5n-glibc-2.38-44/lib -L/nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0/lib/gcc/powerpc64-unknown-linux-gnuabielfv2/13.2.0 -L/nix/store/06p31qlrln7nf6bvlgs3kswgfsvnrz6d-gcc-13.2.0-lib/lib -L/nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0//lib -L/nix/store/85l7pnrc4pjdza8j8pa9rcn378hcp26f-gcc-13.2.0-libgcc/lib -L/nix/store/8pgjm8r18w14z042jxcqg2ww08ldw1zq-clang-17.0.6-lib/lib -L/nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0/lib64/gcc/powerpc64-unknown-linux-gnuabielfv2/13.2.0 -L/nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0/lib64/gcc/powerpc64-unknown-linux-gnuabielfv2/13.2.0/../../../../lib64 -L/lib/powerpc64-linux-gnu -L/lib/../lib64 -L/usr/lib/powerpc64-linux-gnu -L/usr/lib/../lib64 -L/lib -L/usr/lib -dynamic-linker=/nix/store/13mhdf5x574x9wnrjpdk79k8ir52fw5n-glibc-2.38-44/lib/ld64.so.2 /tmp/conftest-a4408e.o -lgcc --as-needed -lgcc_s --no-as-needed -lc -lgcc --as-needed -lgcc_s --no-as-needed /nix/store/c7g75hwfhrn2z1b03y5qq62mblx7dycf-gcc-13.2.0/lib/gcc/powerpc64-unknown-linux-gnuabielfv2/13.2.0/crtendS.o /nix/store/13mhdf5x574x9wnrjpdk79k8ir52fw5n-glibc-2.38-44/lib/crtn.o
/nix/store/amf0m5dg8iacfy5ni3dk9rpgv8kwrrvg-binutils-2.41/bin/ld: /tmp/conftest-a4408e.o: ABI version 1 is not compatible with ABI version 2 output
/nix/store/amf0m5dg8iacfy5ni3dk9rpgv8kwrrvg-binutils-2.41/bin/ld: failed to merge target specific data of file /tmp/conftest-a4408e.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Relevant part:
Target: powerpc64-unknown-linux-gnuabielfv2
[...]
"/nix/store/09cfx6kdrgl622qvv812d1igxhz76xyl-clang-17.0.6/bin/clang-17" -cc1 -triple powerpc64-unknown-linux-gnuabielfv2 [...] -target-cpu ppc64 -mfloat-abi hard -target-abi elfv1 [...]

Planning to add something like this to our cc-wrapper to work around this, which gets hello building with llvmPackages_17.stdenv:
diff --git a/pkgs/build-support/cc-wrapper/default.nix b/pkgs/build-support/cc-wrapper/default.nix
index d788076dda51..a78fb5c4d62c 100644
--- a/pkgs/build-support/cc-wrapper/default.nix
+++ b/pkgs/build-support/cc-wrapper/default.nix
@@ -643,6 +643,12 @@ stdenv.mkDerivation {
       echo "-mtune=${tune}" >> $out/nix-support/cc-cflags-before
     '')

+    # Clang doesn't parse gnuabielfv{1,2} triplet parts for powerpc64{,le}, need to manually override abi
+    + optionalString (isClang && targetPlatform.isPower64 && targetPlatform.parsed.abi.name != "gnu") ''
+      echo "-mabi=${targetPlatform.parsed.abi.abi}" >> $out/nix-support/cc-cflags-before
+    ''
+
+
     # TODO: categorize these and figure out a better place for them
     + optionalString targetPlatform.isWindows ''
       hardening_unsupported_flags+=" pic"

But we can figure out the details of that in a separate PR.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] powerpc64-linux [for time reasons, only tested LLVM 9 & 17]
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Rebased - LLVM 9 has since been dropped, and 18 was added.

Doesn't cause rebuilds for our common platforms, so OfBorg doesn't ping most ppl. CC LLVM team: @NixOS/llvm

is staging needed if no tier-1 platforms get changed?

Why is this using pkgs/development/compilers/llvm/*/llvm/default.nix instead of the common LLVM nix file?

It predates the unification via a common LLVM nix file.

is staging needed if no tier-1 platforms get changed?

I'd say usually no, but the LLVM packaging structure has changed abit on staging, so it prolly makes sense to rebase & retarget to that.

It predates the unification via a common LLVM nix file.

Ah, didn't catch that. Saw the pings and review requests.

is staging needed if no tier-1 platforms get changed?

When there's a major change like commonification which impacts the file tree significantly then probably should go to staging.

Failed rebase, mass ping, closing, please resubmit.


Confusion with Central India region

Azure search services are only supported in Central India region amongst all the India regions. According to this document creation of new services has been blocked in central India region for now. Has it been unblocked? It has been reported that creation in Central India is possible. In that case user is subscribed to Microsoft Azure Enterprise subscription.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0ce2308-9cb4-2a5c-8b81-746afcfdf5f0
Version Independent ID: a39f4e6f-10ce-fdf0-610e-5fe56578dcbd
Content: Create an Azure Search service in the portal - Azure Search
Content Source: articles/search/search-create-service-portal.md
Service: search
GitHub Login: @HeidiSteen
Microsoft Alias: heidist

@JayaC19, Thanks for the question! We are taking a look into this and will get back to you soon.

@JayaC19  I don't see Central India as an available region in the portal. Are you sure someone was able to provision a new service there?  Existing services already created in that region are not impacted (full SLA, full scale) but new services can't be created at this time.

We doc the restriction here:  https://docs.microsoft.com/en-us/azure/search/search-create-service-portal#select-a-location

@JayaC19, Out of the 3 regions in India (Central India, South India and West India) location, Azure Search is generally available only in Central India as you can notice from the ‘Products by region” page (screenshot1). However, as Heidi mentioned,” The restriction on Central region is temporary and we will remove this note when it longer applies”. (screenshot2) So, new services can't be created in this region at this time.  Based on your requirement you may consider selecting a nearby region for provisioning the resource.

Where do you see "Central India" ??

Just added the screenshot to support the verbatim that currently Central India is not available for Azure Search deployment.

Ok -- your comment said the opposite -- "Out of the 3 regions in India (Central India, South India and West India) location, Azure Search is generally available only in Central India as you can notice from the ‘Products by region” page (screenshot1).

@JayaC19 -- is there anything more you need to see WRT this issue?? If not, I think we should close it.  Thanks!

@JayaC19, We will now proceed to close this thread. If there are further questions regarding this matter, please tag us in your reply. We will gladly continue the discussion.


Disable forking/cluster completely

Hello!
How to completely disable forking the application?
Should this be enough?
const coworkers = require('coworkers')
const app = coworkers()

process.env.COWORKERS_CLUSTER = false
process.env.COWORKERS_QUEUE = 'foo-queue'
process.env.COWORKERS_QUEUE_WORKER_NUM = 1

// shared middlewares
app.use(function * (next) {
  // all consumers will run this logic...
  yield next
})

app.queue('foo-queue', function * () {
  // consumer specific logic
  this.ack = true // acknowledge message later, see `Context` documentation below
})

app.on('error', function (err) {
  console.error(err.stack)
})

app.connect('amqp://<IP_ADDRESS>:5672', function(error) {
    if (error)
        console.log(error)
})

console.log('hi')

console.log gets triggered five times. Am I doing something wrong?

If you're setting environment w/in the file it needs to be before you invoke coworkers(). The environment variables are used as default options in the coworkers(options) factory method.

Thanks!

I just added a task to document these options, but you can also just options instead of environment variables to disable clustering.
coworkers({
  cluster: false,
  queueName: 'foo-queue',
  // queueWorkerNum is not required.It is useful if you're using centralized logging and have multiple processes for a single consumer.
})


Incorrect resizeMode applied on Android when children are present

The layout of the second Image with the blue square on Android is incorrect and should be as it is on iOS on the right.
Example code to reproduce the issue:
<View style={styles.container}>
  <View style={{width: 100, height: 100, backgroundColor: 'green', marginLeft: 10, marginTop: 10, }}>
    <Image style={{flex: 1, width: undefined, height: undefined, resizeMode: 'contain'}} source={
      {uri:'http://resizing.flixster.com/DeLpPTAwX3O2LszOpeaMHjbzuAw=/53x77/dkpu1ddg7pbsk.cloudfront.net/movie/11/16/47/11164719_ori.jpg'}
    }>
    </Image>
  </View>
  <View style={{width: 100, height: 100, backgroundColor: 'green', marginLeft: 10, marginTop: 10, }}>
    <Image style={{flex: 1, width: undefined, height: undefined, resizeMode: 'contain'}} source={
      {uri:'http://resizing.flixster.com/DeLpPTAwX3O2LszOpeaMHjbzuAw=/53x77/dkpu1ddg7pbsk.cloudfront.net/movie/11/16/47/11164719_ori.jpg'}
    }>
      <View style={{width: 20, height: 20, backgroundColor: 'blue'}} />
    </Image>
  </View>
</View>

https://rnplay.org/apps/QCCuUw
Tested on RNPlay with RN 0.24.1 and locally with RN 0.26.0-rc.
Problem is present on both versions.

@facebook-github-bot label Android

Closing since #8410 has been merged.


Dev wuhf

Support variable length feature training, configure the feature like:
conf = deeptable.ModelConfig(nets=['dnn_nets'],
                                     task=consts.TASK_REGRESSION,
                                     categorical_columns=["movie_id", "user_id", "gender", "occupation", "zip", "title", "age"],
                                     metrics=['mse'],
                                     fixed_embedding_dim=True,
                                     embeddings_output_dim=4,
                                     apply_gbm_features=False,
                                     apply_class_weight=True,
                                     earlystopping_patience=5,
                                     var_len_categorical_columns=[('genres', "|", "max")])

the param  var_len_categorical_columns   is a tuple3(column_name, separator, pool_strategy),  pool_strategy is one of max,avg;  e.g. [('genres', '|', 'avg' )] , DT will add a layer name VarLenColumnEmbedding to make embeddings of var len features like that:

There is an example in:

tests/models/test_var_len_categorical.py

Hi @jackguagua , I have a quick question about Varlen Features. Let's say there is a varlen feature like streams of movie_ids, and a categorical feature that is the movie_id we want to show to user. So we want to have an embedding for movie_id which is used by movie_id as well as streams of movie_ids . How can I specify that the embedding used for streams_of_movie_ids and movie_id is the same
                               task=consts.TASK_REGRESSION,
                               categorical_columns=["movie_id", "user_id", "gender", "occupation", "zip", "title", "age"],
                               metrics=['mse'],
                               fixed_embedding_dim=True,
                               embeddings_output_dim=4,
                               apply_gbm_features=False,
                               apply_class_weight=True,
                               earlystopping_patience=5,
                               var_len_categorical_columns=[('stream_of_movie_ids', "|", "max")]) ```

Hi @jackguagua , I have a quick question about Varlen Features. Let's say there is a varlen feature like streams of movie_ids, and a categorical feature that is the movie_id we want to show to user. So we want to have an embedding for movie_id which is used by movie_id as well as streams of movie_ids . How can I specify that the embedding used for streams_of_movie_ids and movie_id is the same
                               task=consts.TASK_REGRESSION,
                               categorical_columns=["movie_id", "user_id", "gender", "occupation", "zip", "title", "age"],
                               metrics=['mse'],
                               fixed_embedding_dim=True,
                               embeddings_output_dim=4,
                               apply_gbm_features=False,
                               apply_class_weight=True,
                               earlystopping_patience=5,
                               var_len_categorical_columns=[('stream_of_movie_ids', "|", "max")]) ```


test: tests for #703

- What I did
See #703
#703 is a stack on top of #659
This PR exists to ensure that the tests still pass for the changes in #703
- How I did it
- How to verify it
- Description for the changelog
test: tests for #703

Same issue where local vs trunk failed because I rename something in the e2e test suite

nvm #703 is running its own set of tests


The value of a manifest attribute must not be null (Key=Build-SDK).

When configuring prepareSandbox we add some attributes to the jar
manifest, one of which being "Build-SDK" - when using localPath, the value of the attribute
is constructed from the contents of product-info.json (a metadata file located in the target IDE directory).
However, when the target IDE is Android Studio, this file does not exist (in recent versions at least), and the value thereby resolves to null; this causes the following error:

Could not determine the dependencies of task ':prepareSandbox'.
Failed to query the value of task ':prepareSandbox' property 'pluginJar'.
The value of a manifest attribute must not be null (Key=Build-SDK).

@jeppeman do you have a quick fix for this while we wait for the PR to be accepted? I'm currently facing this problem and I'm blocked 😄  thanks!

Ah OK got it. For everyone else in this situation: instead of using localpath, use version: ANDROID_STUDIO_VERSION.

@ishepard I've published a version with the fix to an internal artifactory while waiting for a review, otherwise a temporary fix that works is to create a product-info.json file in the Resources folder of the AS distribution (this could be automated in the build script).
Seems like you found a solution though, which is great, not sure I understand it however :) Is ANDROID_STUDIO_VERSION a gradle property, if so, where does it come from?

I followed this tutorial here: https://plugins.jetbrains.com/docs/intellij/android-studio.html#matching-versions-of-the-intellij-platform-with-the-android-studio-version
My version of Android Studio is 2020.3.1, which correspond to build 203.7717.56. So at the end, my build.gradle is:
intellij {
    updateSinceUntilBuild = false
//    localPath = '/Applications/Android Studio.app'
    version = '203.7717.56'
}

runIde {
    jvmArgs '-Xmx4g', '-Xms1g'
    ideDir = file('/Applications/Android Studio.app/Contents')
}

I don't use localpath anymore, just version.

Gotcha, yeah - that works too. Although I remember having issues when using version previously, it would compile correctly but then certain methods / classes would be missing at runtime when running against an Android Studio distribution. Might have been me just specifying the wrong version though, I'll probably give that another go now.
Thanks!


C#: Move GodotSharp to .NET8

This is to prepare the EOS of .NET6 in November.
Would need to be more thoroughly tested. There are probably a bunch of other spots where we could mark things as scoped.

Supersedes #71241

As we are upgrading the SDK version, should the end of support for Windows 7 and 8.1 on .Net 8 be documented?

Rebased and up to date. There are a few new places I'm not sure whether we should use scoped or not (e.g. new NativeFuncs methods introduced in #98545). But otherwise it should be good to test.

I forgot to squash commits. Is it fine to keep two separate commits here? I don't want to erase the large contribution of the previous PR.

Yeah keeping two separate commits seems fine to me.
Note that there are a number of C# warnings raised by the CI in a non-obvious way: they're visible if you view the last commit and scroll all the way down:
https://github.com/godotengine/godot/pull/92131/commits/1c7ecfb89bc94a4dbd7a4ffd25a8f05d4e7be79a
I don't see those on other PRs so they must be introduced by this change.

Good catch, thank you. Those are warning introduced in waves 6 and up.

Great work @paulloz and @RedworkDE!


GH-132 User's .Exists and .Read only needs d.Id()

In terraform's documentation, it is said that schema.ImportStatePassthrough relies on being able to do a Refresh solely with d.Id(): https://www.terraform.io/docs/extend/resources/import.html#importstateverifyignore

This function requires the Read function to be able to refresh the entire resource with d.Id() ONLY.

Although it's not very clear from the docs, but given we have Exists defined for User here, Refresh actually calls both the User's .Exists and .Read: https://github.com/hashicorp/terraform-plugin-sdk/blob/main/helper/schema/resource.go#L575
Hence, both .Exists and .Read need to only rely on d.Id().
NOTE: I've added toggles for testing User import in one of the acceptance tests, but I have not run the tests myself and verified that the tests pass. I have, however, ran the code fix on our artifactory instance and verified that I have successfully imported the user and the user attributes...

This fixes #132 ?

Yup! as tested on our live artifactory instance - the import fails before the code change and succeeds after the code change (but note that I have not set up or run the provider's acceptance tests).
It should be quite easy to reproduce the issue to verify this, since any user import should trigger it.

Ok, I will test it tomorrow. If it works, we can ship

👍 thanks a lot

When I run the tests, I get:
=== RUN   TestAccUser_basic
    resource_artifactory_user_test.go:26: ResourceName is required for an import state test
--- FAIL: TestAccUser_basic (2.23s)

FAIL

I re-read the terraform documentation and I think I fixed the test. I needed to add it as a new test step (with the resourceName set) instead of just re-using the test step for the terraform apply. @chb0github can you try running the acceptance tests now and see if it passes? Thanks.
I think it's likely to pass, given it now looks comfortingly similar to terraform-provider-aws's tests: https://github.com/hashicorp/terraform-provider-aws/blob/main/aws/resource_aws_appconfig_deployment_test.go#L48
But if it doesn't, I'll try and set up the local acceptance test environment in the weekend and work on it.

I now get this:
/usr/local/Cellar/go/1.15.5/libexec/bin/go tool test2json -t /private/var/folders/zk/5kk70w457cd81n36y0vv8pp00000gp/T/___resource_artifactory_user_test_go.test -test.v -test.run ^\QTestAccUser_basic\E|\QTestAccUser_full\E$
=== RUN   TestAccUser_basic
    resource_artifactory_user_test.go:26: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.

        (map[string]string) {
        }

        (map[string]string) (len=1) {
         (string) (len=8) "password": (string) (len=44) "GVE/3J2k+3KkoF62aRdUjTyQ/5TVQZ4fI2PuqJ3+4d0="
        }
2021/09/23 09:39:48.647532 ERROR RESTY 404 HEAD http://localhost:8081/artifactory/api/security/users/the.dude2249510692394224994
, Attempt 1
--- FAIL: TestAccUser_basic (3.88s)

You can test this locally by running artifactory local:
bin/run-artifactory.sh but you would need a license file. Alternatively, I can set you up with a test instance

Any update? Because, anecdotally it seems to work. I just need a test to prove it

Hey, this weekend I'll try and get the acceptance test set up on my end. I'll let you know if I need help / a test instance.

@chb0github Hey Christian, so I reproduced the test failure and fixed it now.
The previous error message we got was this:
        (map[string]string) {
        }

        (map[string]string) (len=1) {
         (string) (len=8) "password": (string) (len=44) "GVE/3J2k+3KkoF62aRdUjTyQ/5TVQZ4fI2PuqJ3+4d0="
        }

The message is basically saying, that in the test's terraform snippet we have password = "Password1", so after doing a terraform import it expects this Password1 to be imported into the terraform state (or, at least the hashed version of it, hence GVE/3J2k+3KkoF62aRdUjTyQ/5TVQZ4fI2PuqJ3+4d0=). However, Password1 is not imported, hence the test failure.
The reason it is not imported is of course mentioned in the documentation here: https://github.com/jfrog/terraform-provider-artifactory/blob/3c2f2e0fd50c1c4a4a9ebe5e8f29aa1a2aa80f97/docs/resources/artifactory_user.md "User passwords are never returned through the API..."
Therefore, we have a legit reason to add the password field into the ImportStateVerifyIgnore flag, because this terraform provider simply does not support importing the password field for user resources.
I've ran the acceptance tests and they pass now. Can you confirm? thanks.

Good detective work - your actually helped me with solving another issue


Initial Commit, copy files, fix deps

To allow modules like @helia/car to re-use configured dag walkers instead of having to bundle their own, expose configured dag walkers and hashers on the helia interface and have them consume those.
Fixes #375

Will merge to main after https://github.com/ipfs/helia/issues/375 has gone in.


add google recaptcha support

To solve issue #4
I opted to use the simple-recaptcha module because of its, yes, simple
implementation of the the google captcha. Since it's a reasonable
captcha that is accessible I think it will work nicely. Documentation
for the module is here.
@lorenanicole @lrakhman

This module ended up being a pain in the butt for some reason, so I just kept it simple.


chore: Migrate /superset/schemas_access_for_file_upload to v1

SUMMARY
Continuing the effort on deprecating all /superset/ REST API endpoints
Deprecates /superset/schemas_access_for_file_upload for /api/v1/database/{id}/schemas_access_for_file_upload
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

https://github.com/apache/superset/pull/23227


docker image tags

Hi,
So far I've been using the docker tags "jlesage/baseimage-gui:alpine-3.10" without the version number on the end, but with the new alpine-3.11 the available tags all have "v" "number" at the end.  Just asking if that's your new standard going forward? No problem if so, I can update all my dockerfiles to comply with the new tags.
thanks

Hi, this is a mistake, I will add the missing tags.

ok thanks


Update PL to 1.2.1

Check if this PR fulfills these requirements:

[ ] My changes respect the Kodi add-on development rules
[ ] I have read the CONTRIBUTING document.
[ ] I made sure there wasn't another one Pull Requests opened for the same update/change
[ ] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[ ] Feature change (non-breaking change which change behaviour of an existing functionality)
[ ] Improvement (non-breaking change which improve functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

In case of Feature change / Breaking change:
Describe the current behavior

Describe the new behavior

Screenshots (if appropriate):

this need to be updated with latest changes

some id is missing to update, it will be for the next release


(Fix #370)Added Edmonton WordPress Meetup to meetups

What issue is this referencing?
This PR is referencing https://github.com/devedmonton/DES-Website/issues/370 , which adds "Edmonton WordPress Meetup" to the list of meetups.
Do these code changes work locally and have you tested that they fix the issue yourself?
yes!
Does the following command run without warnings or errors?
yes! npm run pr-checks
Have you taken a look at our contributing guidelines?
yes!
My node version matches the one suggested when running nvm use?
yes!

Hey @shrutiijain26 sorry this still isn;t ready to work on as I have to upload a photo still. I will try to do that tonight but in the meantime I will close this pr. So sorry!


Unable to execute a commande before parsing modules from a minion

Describe the bug
On a fresh installation of Alcali, I can't run a test.ping because alcali try to run null.
To Reproduce
Steps to reproduce the behavior:

Having a salt-master with one or more minion
Install a fresh alcali
Go to Run menu
Click in Target field
Input * to target all minions
Click in Function field
Input test.ping
Click on Run button

Expected behavior
The Results should dispaly the list of minion with True as output.
Output of a successful job

Screenshots
Output of running the failed job

Details of the failed job

Desktop (please complete the following information):

OS: Debian Sid
Browser Firefox
Version 88.0.1-1

Additional context
Add any other context about the problem here.

@baby-gnu I found the problem. You have to make the combo-box lose focus before hitting run. That way the selectedFunction variable in javascript gets updated.
Here is a stackoverflow post of someone with a similar issue: https://stackoverflow.com/questions/63896901/problem-with-updating-model-in-vuetify-combobox

fixed by #450


fix: Updated vertx documenation link for data source and quickstart

Summary
fix: Updated vertx documenation links for data source and quickstart

Pre merge checklist

[X ] Did you check you NRQL syntax? - Does it work?
[X ] Did you include a Data source and Documentation reference?
[X ] Are all documentation links publicly accessible?
[ X] Did you check your descriptive content for voice and tone?
[X ] Did you check your descriptive content for spelling and grammar errors?
[X] Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

[ ] Does the PR contain a screenshot for each of your dashboards?
[ ] Do your screenshots show data?
[ ] Has the sanitization script been run on each dashboard?

Alerts

[ ] Did you check that your alerts actually work?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: gsidhwani-nr:x: zstixYou have signed the CLA already but the status is still pending? Let us recheck it.


Middle clicking a file in the spaces sidebar does not open it in a new tab

When middle clicking a file in the sidebar does not open it in a new tab. It does when using Obsidian's own file sidebar. Would be nice if functionality was the same as the other file "sidebar" (?).

Thanks for reporting this, the previous fix seems like it didn’t work, another fix will be implemented in the next version.


Do we need to tweak the pre_parse_line_limit?

The setting's description says for coboleditor.pre_parse_line_limit: "used to determine if source is COBOL or a CopyBook"; but as I've already have the file extensions setup to include "myext" in coboleditor.copybookexts, then why does the extension need an additional setting?
In my case the files with myext include a changelog and documentation in the header, which sometimes has > 100 entries so I've tried to increase the setting to 250, but I still get "no symbols found in document" in the outline for the file...
I'm still not sure that there's a need for that setting (just skip initial empty lines, comment lines and directive lines and look for the first 5 other lines or so), but guess the documentation for it may be confusing.

The file extension only tells you that the file is related to COBOL, it does not help me "guess" how the copybook is used.
The extension need to "guess" if the copybook is part of a storage area or the procedure division.

Then I suggest to change the doc to say so:
"used to determine if source is a program/function or part of DATA DIVISION / PROCEDURE DIVISION"
.. still there's the question why the workplace setting of coboleditor.pre_parse_line_limit: 250 did not helped (I had likely not restarted after adjusting that, if this is necessary the extension doc should give a hint on that).

.. still there's the question why the workplace setting of coboleditor.pre_parse_line_limit: 250 did not helped (I had likely not
restarted after adjusting that, if this is necessary the extension doc should give a hint on that).

I guess you will need to share the first 250 lines, so I see what is happening (understand if you don't want to place on the issue)..
if that is the case, email me stephen @ gennard . net

Retested with current version of this extension:

the documentation entry should definitely be adjusted
whenever changing oboleditor.pre_parse_line_limit (at least via workspace setting) a reload of the complete vscode window is necessary

If I change it from 25 to 250 nothing happens, after reload I see the outline, after changing it back to 25 reopen only that file has consequence. Reloading the window and the outline is gone again. Is it possible to remove the need for the reload in this case? If not then it should be mentioned in its doc entry.
In general: is it possible to change the approach of fixed lines to "always read only 5 lines, but only increase the counter for lines that are not empty or comment lines or directive lines" and dropping that setting - or changing its meaning to "lines that are neither [see above]")?

Just a ping after rechecking: I still suggest to adjust the documentation, would I be sure enough what the good/correct short way to tell it would be I'd do a PR...
Concerning the other part of this issue: is it reasonable to count empty/comment lines or can we drop that (= skip those lines)?
(If we do we may not need this setting any more).


TT3 Binary Math

The pictures above contain the various tasks completed with the TT3 Binary Math mini-hackathon.


Test for non root user capabilities

This depends on #1539 which should be merged first.

LGTM
/test all

Updated.

/test all

LGTM (modulo Dan's comments!)

/test integration

This is green!

LGTM


Implement support for spaces repositories and gates

@luhac I just assigned this issue to you, as you volunteered to work on that ;)

This will have an effect on issue #12.


Update to cli angular

Hello,
I have found that you don't use angular2 cli. Please update to stay on top :).

Although this plugin is more on functions. It doesn't need to update using Angular CLI. But if I have time to update this, I will. So for now I will this as an enhancement.


Terminate worker tasks on SIGINT

Fixes #707.

Description

This pull request: installs a signal handler that terminates worker tasks on Ctrl-C (SIGINT).
If the requested signal isn't supported on the current platform, the operation will be ignored.
Notes:

we cannot use celery control because it's broker-dependent, which wouldn't work with standalone
printing a worker pid and asking users to terminate that wouldn't work because celery beat would respawn
using install_worker_term_hard_handler wouldn't work because not all tasks would be terminated
using a signal handler is the only solution I've found given the above constraints, it's what install_worker_term_hard_handler uses internally as well.

Tested on Windows and Linux. All processes are terminated as expected.
Pull request checklist

[x] Did you test this change locally?
[ ] Did you update the documentation (if required)?
[ ] Did you add/update relevant tests for this change (if required)?

Additional information

@nkaretnikov there is a merge conflict - can you fix this and we can merge right away


Support creator & site tags for Twitter

Twitter has a useful feature called creator and tags, which lets you define which account is associated with the twitter card. Perhaps you'd want to add support for this :)?
For reference, see https://developer.twitter.com/en/docs/tweets/optimize-with-cards/overview/markup

Do you mean this?
<meta name="twitter:card" content="summary">
<meta name="twitter:site" content="@username">

If so, the twitter account probably doesn't change across pages, so you only need to declare it once, in the <head> of your page, and don't need to dynamically update it, which is what the updateMetadata function does

Valid point, closing this :).
Although there's still cases where you would define dynamic tags, for sites that generate different tags because they belong to different authorities, think WordPress, slack, other publicly available SaaS, etc.

If there's some specific tags you're thinking of, please let me know! I am not a metadata expert, so I genuinely don't know any other than the ones we added. I'm not opposed to adding more useful ones at all! :)


renaming inferred parameter of anonymous function

Rename refuses to work on element in this code:
"".map((element) => element.integer);

Thanks, better.


Use nsis from linuxbrew (3.04) instead of from apt-get (ancient)

The Problem/Issue/Bug:
In https://github.com/drud/ddev/pull/1880 @gilbertsoft noted that the Circleci/Linux makensis we're using is really old. It seems we were getting it from apt-get (and those testbots are Ubuntu 16.04, a few years old).
How this PR Solves The Problem:

Use homebrew to build makensis
Unzip the standard 3.04 nsis tarball into /usr/local/share/nsis so that we get Stubs

Manual Testing Instructions:
Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

Nice :)


ESP-Matter only for Wifi commissioning (CON-492)

I want to ask if it's possible to create a Matter device with an "empty" endpoint, so the only purpose of the matter device is to connect the ESP with wifi network trough google/apple home?

I found endpoint::aggregator::create(node, ENDPOINT_FLAG_NONE, NULL); to create a bridge type (which would be a good endpoint, but Apple Home is saying This accessory is not responsing, and when I remove the bridge, the matter device is not going back into commissioning mode, what am I missing?

I didn't quite understand what are you trying to achieve over here? Is it the same requirement about using it only for getting connected to the IP network? Or which bridge are you trying to implement?

Check out the BLE Mesh bridge example. https://github.com/espressif/esp-matter/tree/main/examples/blemesh_bridge
That should do what you want, just don't add any devices to the bridge.

It isn't possible. A matter node requires the endpoint 0 (root node).

Ah yes of course I have still the root node, but no device type endpoint. I tried it and it will commission the device, but Apple will tell the user its not properly set up, thats why asked for another empty endpoint solution.

Is it the same requirement about using it only for getting connected to the IP network?

Yes, I thought it might be better to use the bridge for that requirement if there is no solution via an endpoint? @dhrishi

That should do what you want, just don't add any devices to the bridge.

Thanks, I tried to do it and I got the initial commissioning, but after that the bridge is not responding. I still have the case if I "delete" the bridge from my phone, that I can re-commission it in another home/ wifi.

There are unresolved issues around devices not responding after first commissioning.  If you wait for a while they will resolve, otherwise just reboot the device.

If you delete the last commissioned fabric on the device, the device should revert back to Bluetooth commissioning mode.

My ESP doesn’t react when I delete the bridge in Apple Home, any suggestions? Or could you elaborate further? Maybe there is something I missing!

Watch the logs on the ESP device. When you delete the bridge there should be a bunch of traffic back to the device doing the deletion. At the end of that it should say the last fabric was deleted and then revert to BLE advertising for commissioning.

Watch the logs on the ESP device. When you delete the bridge there should be a bunch of traffic back to the device doing the deletion. At the end of that it should say the last fabric was deleted and then revert to BLE advertising for commissioning.

Negative, I get no traffic when I delete the bridge, but I get traffic when I reconnect the Bridge after deleting it. Any advice?
But thanks for the help so far, commissioning is stable!

The only way there would be no traffic on the Apple side is if Apple thinks the bridge is dead when you delete it. If they think it is dead, they just abandon it and don't really delete it.
What should be going on - You delete bridge in IOS. IOS then removes the commissioning from the device. If that was last commissioning on the device, then the device reverts back to BLE advertising for commissioning.

@jonsmirl Seems like it's on the Apple side, as I can’t get it to work. Is there another way to delete the wifi credentials or de-commission the device another way? maybe when I remove the device from power?

Do a factory reset?
Apple put those credentials there, when you delete the device Apple is supposed to remove them.  File a bug on Apple. I suspect this is not well tested in Apple because I don't think anyone has shipped a Matter bridge product yet.

@aggaddam Device shall use BLE commissioning only if it does not have an IP connection. Depending on the use case you can open enhanced or basic  commissioning window. Enhanced will always advertise on mdns. For basic, there's an option advertisementMode for configuring the advertising mode.

@shubhamdp Is ESP-Matter SDK maintaining the status of the commissioning process or do I need to implement it in the application? Are there APIs"s to know the device is commissioned or not or any other state it is ?

One way to know if device is commissioned or not is to check the fabric count, if its greater than zero then device is commissioned. (ref impl)

Can I open the BLE commission window instead of kDnssdOnly if the fabric count is 0?
CHIP_ERROR err = commissionMgr.OpenBasicCommissioningWindow(kTimeoutSeconds,
chip::CommissioningWindowAdvertisement::kAllSupported);

esp_matter::start() is not just about putting device into commissioning mode, it does a lot of initialization, and one of its part is to put the device into commissioning mode.
Decision to put the in commissioning mode is in connectedhomeip repo's Server.cpp, please see these bits.

@Tim4497 If your question is answered can you please close this issue?


[master] chore(dcos-ui): bump DC/OS UI v2.40.0

High-level description
What features does this change enable? What bugs does this change fix?
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-4245 Owner column alignment is incorrect on the files tab of a task detail
DCOS-45393 Add GPU to Nodes Detail Page
DCOS-44456 Localize sidebar categories and primary navigation
DCOS-44138 i18n Mark is imported twice in VirtualNetworkDetail
DCOS-43620 Multi-container JSON editor deletes properties not supported by the form
DCOS-43041 Integrate lingui I18nProvider on multiple render mounts
DCOS-42394 Fix error message for environment variables
DCOS-41578 Black screen transition flash when opening Catalog config
DCOS-41121 Tooltips in Version cells are misaligned
DCOS-40781 Catalog Search offers no feedback when nothing is found
DCOS-40650 Upload sourcemaps on Release to Sentry
DCOS-40644 Fix tooltip for service configuration
DCOS-40640 Cache cypress installation to speed up the build
DCOS-40635 In Nodes view, whenever there are no nodes, Grid View loads forever
DCOS-38853 Remove react-addons-pure-render-mixin
DCOS-35756 Properly fix Headings levels in Config Screens
DCOS-21986 Missing method on TaskContainer
DCOS-21307 Changing custom VIP port from the form doesn't work
DCOS-20222 Invalid Environment variables have no error and are simply ignored

Related tickets (optional)
Other tickets related to this change:

DCOS_OSS- Foo the Bar so it stops Bazzing.

Checklist for all PRs

[ ] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[ ] Read the DC/OS contributing guidelines
[ ] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label [Ready for Review]


How to calculate the total frame count for gif?

New Issue Checklist

[x] I have read and understood the CONTRIBUTING guide
[ ] I have read the Documentation
[ ] I have searched for a similar issue in the project and found none

Issue Info

Info
Value

Platform Name
e.g. ios / tvos

Platform Version
e.g. 8.0

SDWebImage Version
e.g. 3.7.6

Integration Method
e.g. carthage / cocoapods / manually

Xcode Version
e.g. Xcode 7.3

Repro rate
e.g. all the time (100%) / sometimes x% / only once

Repro with our demo prj
e.g. does it happen with our demo project?

Demo project link
e.g. link to a demo project that highlights the issue

Issue Description and Steps
Please fill in the detailed description of the issue (full output of any stack trace, compiler error, ...) and the steps to reproduce the issue.

@lemarian Well...Seems I'm not catup up with the idea at that time.
If you need to switch to another view after the current gif play finished. First solution, you setup a NSTimer or something to record the time. Then use UIImage.duration to get the total duration the image will play in each loop. So now you can switch to another view after the total duration time passed. The disadvantage of this solution is that the timer must be accurate or there may be some synchonized issue.
The second solution, using a special imageView which support a callback after animated image play finished. For UIImageView with UIAnimatedImage, use KVO to observe the animating property. When that change to false, switch to another view. Attention this assume that the image loop count to be 1(Or the image keep animating until final loop finished)
For FLAnimatedImageView, use loopCompletionBlock.
For SDAnimatedImageView from our 5.x branch, use KVO on animating(Means all loop finished and image stop animating) or currentLoopCount (Means current loop finished and will begin next loop)


Fix typo SV_DomainLsocation

Note: to change the enum name of DomainLsocation means case SystemValueSemanticName::DomainLsocation: (inside source\slang\slang-ir-metal-legalize.cpp) also needs to be changed


feat: quiz question counts exclude explanatory text type

User Story
As a pupil completing a lesson,
I want to view explanatory text whilst taking quizzes,
So that I can gain useful context about the questions I am about to complete
Testing

go to:
https://deploy-preview-2272--oak-web-application.netlify.thenational.academy/pupils/programmes/english-secondary-ks3/units/sonnet-18-shakespeare-8cea/lessons/sonnet-18-the-shakespearean-sonnet-68u62d
The quiz counts should now show 6 instead of 7 questions

Acceptance criteria

[x]  not included in the question counts during quiz
[x]  not included in the question counts for overview and review sections

:tada: This PR is included in version 1.364.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Problem with case sensitive filesystem on osX

TypeScript Version:
`- > tsc -v
Version 1.8.10

`- > node -v
v5.11.0

`- > npm -v
3.8.8

Not shure does this belongs here.
I'm using tsc on simple node.js(angular2 quickstart) project, which uses tsc -w
Problem is, my path to project contains uppercase letters (/opt/Development/node.js/mqtt_fe),
but when I run tsc -w I get following error:
Error: watch /opt/development/node.js/mqtt_fe ENOENT

My temporary fix is to create link from /opt/Development to /opt/development
/opt is case sensitive filesystem. I'm using osX 10.11.4
Thx

Duplicate of #7154


Uncaught TypeError: Return value of Http\Client\Curl\PromiseCore::getException() must implement interface Throwable, instance of Nyholm\Psr7\Response

PHP message: PHP Fatal error:  Uncaught TypeError: Return value of Http\Client\Curl\PromiseCore::getException() must implement interface Throwable, instance of Nyholm\Psr7\Response returned in /var/www/releases/20191015093018/vendor/php-http/curl-client/src/PromiseCore.php:194
Stack trace:
#0 /var/www/releases/20191015093018/vendor/php-http/curl-client/src/CurlPromise.php(103): Http\Client\Curl\PromiseCore->getException()
#1 /var/www/releases/20191015093018/vendor/sentry/sentry/src/Transport/HttpTransport.php(110): Http\Client\Curl\CurlPromise->wait()
#2 /var/www/releases/20191015093018/vendor/sentry/sentry/src/Client.php(117): Sentry\Transport\HttpTransport->send(Object(Sentry\Event))
#3 /var/www/releases/20191015093018/vendor/sentry/sentry/src/Client.php(103): Sentry\Client->captureEvent(Array, Object(Sentry\State\Scope))

probably https://github.com/php-http/curl-client/issues/60

The Curl adapter seems to be buggy, as already reported in #878. We're moving away from it and migrating to use Guzzle, with #890 and https://github.com/getsentry/sentry-php-sdk/pull/4. I would suggest to use Guzzle manually in the meantime.

Closing because this is a bug in the Httplug Curl client and there is nothing we can do on our side


SSL cert error on www.kubernetes.io

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
https://www.kubernetes.io will not load because the certificate is only valid for a long list of domains (including kubernetes.io without the www). This is a problem because some search engines (e.g. duckduckgo) point to www.kubernetes.io.
Proposed Solution:
Add www.kubernetes.io to the certificate's alt-names.
Page to Update:
https://www.kubernetes.io/

This seems to be fixed. We can close @chenopis.

@ahmetalpbalkan Thanks for letting me know.

Issue still exists as far as I can tell.

@ahmetalpbalkan We need to take a closer look at this. Thanks for keeping on this @lheckemann

This might appear fixed if you are testing with Chrome, because Chrome redirects SSL errors caused by name mismatches to the actual site: https://crbug.com/507454
In this case, Chrome checks https://kubernetes.io (because it's in the cert served by https://www.kubernetes.io), determines it's available, automatically redirects to it and prints a console message.
If you launch Chrome with --force-fieldtrials=SSLCommonNameMismatchHandling/Disabled/ flag, you'll see that the problem still exists (note that the flag was changed to --disable-feature=SSLCommonNameMismatchHandling on beta, dev and canary channels).

/cc @patrickkettner on the Edge team who noticed links to https://www.kubernetes.io are broken in Edge but not Chrome.

@lheckemann @ahmetb  @patrickkettner @chenopis I can't reproduce this. For me, https://www.kubernetes works on Chrome, Edge, and Safari. Could you check and see whether this is still a problem? Thanks.
curl -v https://www.kubernetes.io

Rebuilt URL to: https://www.kubernetes.io/
Trying <IP_ADDRESS>...
Connected to www.kubernetes.io (<IP_ADDRESS>) port 443 (#0)
found 148 certificates in /etc/ssl/certs/ca-certificates.crt
found 597 certificates in /etc/ssl/certs
ALPN, offering http/1.1
SSL connection using TLS1.2 / ECDHE_RSA_AES_128_GCM_SHA256
server certificate verification OK
server certificate status verification SKIPPED
common name: kubernetes.io (matched)
server certificate expiration date OK
server certificate activation date OK
certificate public key: RSA
certificate version: #3
subject: CN=kubernetes.io
start date: Tue, 25 Jul 2017 23:11:00 GMT
expire date: Mon, 23 Oct 2017 23:11:00 GMT
issuer: C=US,O=Let's Encrypt,CN=Let's Encrypt Authority X3
compression: NULL
ALPN, server accepted to use http/1.1

GET / HTTP/1.1
Host: www.kubernetes.io
User-Agent: curl/7.47.0
Accept: /

< HTTP/1.1 301 Moved Permanently
< Cache-Control: public, max-age=0, must-revalidate
< Content-Length: 38
< Content-Type: text/plain
< Date: Thu, 05 Oct 2017 06:31:20 GMT
< Location: https://kubernetes.io/
< Strict-Transport-Security: max-age=31536000
< Age: 12
< Connection: keep-alive
< Server: Netlify
<
Redirecting to https://kubernetes.io/

Connection #0 to host www.kubernetes.io left intact

I think this is now fixed, possibly after Netlify migration.

Thanks @ahmetb. Are the rest of you (@lheckemann @patrickkettner @chenopis ) OK with closing this?

I tried Chrome with the  --force-fieldtrials=SSLCommonNameMismatchHandling/Disabled/ flag and didn't see any problems w/ https://www.kubernetes.io -- it redirects properly to https://kubernetes.io. Consequently, I'm fine w/ closing this issue.

Can confirm, seems to work now.

Still it seems not workng in the firefox
kubernetes.io uses an invalid security certificate. The certificate will not be valid until December 27, 2018, 3:38:15 AM GMT+5:30. The current time is December 24, 2018, 11:19 AM. Error code: MOZILLA_PKIX_ERROR_NOT_YET_VALID_CERTIFICATE

@KasunKulathunga this seems like a different problem which is caused by your system clock being wrong.

Sorry.Yeah.Thanks.That was different case and sorted out.


Update Terra single sample pipeline workspace

The Terra single sample workspace has been broken due to being force-switched away from GATK docker image versions that dated prior to the log4j fixes. There also appear to be some issues that have arisen in the single sample workspace template files. The workflow should be updated to v0.26-beta and tested.

I think we can close this as the single-sample workspace has been updated and is currently at v0.26.9-beta


Update getting-started.md

Adding instructions for Let's Encrypt SSL and enabling HTTPS in nginx

This is a great addition, but found some mistakes:
first code block:
sudo apt-get -y bc
Need:
sudo apt-get install -y bc
replace:
sudo services nginx restart
with:
sudo service nginx restart

Also:
Finally, restart the WSGI service to run the new code. If you followed this guide for the initial installation, this is done using supervisorctl:

# sudo supervisorctl restart netbox

There is no reference to supervisorctl before this last paragraph.


Error at Page update

No update is render in frontend

Hey @sagarad931, can you give a bit more context for your issue or what you are trying to do?

Closing due to missing context


Can it geocode partial addresses?

I'm loving geocoder, great work. Just a simple question: when I search a partial address in Google Maps (maybe with incomplete postcode) it guesses the correct address, particularly if it has a business name. However, when using geocoder, I only get coordinates when putting in the full address with postcode. Is that how Google designed their API to work? Or is there a way I can get geocoder to be more fuzzy?

Yeah, as far as I know that's just how Google's API works.
Alex
On Thu, Jan 12, 2012 at 3:14 PM, halfiranian
<EMAIL_ADDRESS>wrote:

I'm loving geocoder, great work. Just a simple question: when I search a partial address in Google Maps (maybe with incomplete postcode) it guesses the correct address, particularly if it has a business name. However, when using geocoder, I only get coordinates when putting in the full address with postcode. Is that how Google designed their API to work? Or is there a way I can get geocoder to be more fuzzy?

Reply to this email directly or view it on GitHub:
https://github.com/alexreisner/geocoder/issues/159

Great thanks mate - just thought I'd check!

Sent from my phone
+447771636390
On 12 Jan 2012, at 20:21, Alex<EMAIL_ADDRESS>wrote:

Yeah, as far as I know that's just how Google's API works.
Alex
On Thu, Jan 12, 2012 at 3:14 PM, halfiranian
<EMAIL_ADDRESS>wrote:

I'm loving geocoder, great work. Just a simple question: when I search a partial address in Google Maps (maybe with incomplete postcode) it guesses the correct address, particularly if it has a business name. However, when using geocoder, I only get coordinates when putting in the full address with postcode. Is that how Google designed their API to work? Or is there a way I can get geocoder to be more fuzzy?

Reply to this email directly or view it on GitHub:
https://github.com/alexreisner/geocoder/issues/159

Reply to this email directly or view it on GitHub:
https://github.com/alexreisner/geocoder/issues/159#issuecomment-3469812


Uses BE flags when building with LE compiler

/home/joel/op-build/output/build/occ-1093bf945e6c22650ca0b83da2347ee7d21cbe41/src/tracepp/tracepp /home/joel/op-build/output/host/usr/bin/powerpc64le-buildroot-linux-gnu-gcc -c -g -Wall -fsigned-char -msoft-float -m32 -mbig-endian -mcpu=405 -mmultiple -mstring -meabi -msdata=eabi -ffreestanding -fno-common -fno-inline-functions-called-once -pipe -Wa,-m405 -Os -I../ssx -I../lib  -I./incl  -I./trac  -I./async -I./errl -I./gpe  -I./thread -I./aplt -I./aplt/incl -I./rtls -I./dcom -I./sensor -I./pss -I./proc -I./cent -I./cmdh -I./amec -I.    The OCC is targeting a ppc405, which is BE. You need to use a cross-compiler and not your native LE compiler.
Patrick
Sent from my iPhone

On Feb 22, 2016, at 10:55 PM, Joel Stanley<EMAIL_ADDRESS>wrote:
/home/joel/op-build/output/build/occ-1093bf945e6c22650ca0b83da2347ee7d21cbe41/src/tracepp/tracepp /home/joel/op-build/output/host/usr/bin/powerpc64le-buildroot-linux-gnu-gcc -c -g -Wall -fsigned-char -msoft-float -m32 -mbig-endian -mcpu=405 -mmultiple -mstring -meabi -msdata=eabi -ffreestanding -fno-common -fno-inline-functions-called-once -pipe -Wa,-m405 -Os -I../ssx -I../lib  -I./incl  -I./trac  -I./async -I./errl -I./gpe  -I./thread -I./aplt -I./aplt/incl -I./rtls -I./dcom -I./sensor -I./pss -I./proc -I./cent -I./cmdh -I./amec -I.

On Tue, Feb 23, 2016 at 10:34 PM, Patrick Williams<EMAIL_ADDRESS>
wrote:

How is this OCCs problem? The OCC is targeting a ppc405, which is BE. You
need to use a cross-compiler and not your native LE compiler.

This is op-build, not my native LE compiler

I still don't understand the problem with regards to OCC. You see -mbig-endian as one of the complained about options. Both Hostboot and OCC need a big endian  compiler.  Something is wrong with your build root update if these gcc options don't work.
Patrick
Sent from my iPhone

On Feb 23, 2016, at 6:05 AM, Joel Stanley<EMAIL_ADDRESS>wrote:
On Tue, Feb 23, 2016 at 10:34 PM, Patrick Williams<EMAIL_ADDRESS>
wrote:

How is this OCCs problem? The OCC is targeting a ppc405, which is BE. You
need to use a cross-compiler and not your native LE compiler.

This is op-build, not my native LE compiler
—
Reply to this email directly or view it on GitHub.

It is -mmultiple and -mstring that is failing and not big endian itself. Even still, these are directives to use a group of instructions that should be available when targeting ppc405 (and are probably required by OCC code for optimization reasons). I still contend something is wrong with gcc.
I suspect there is a bug when compiling a multi-target, little-endian compiler that it disables a set of big-endian only options. This is wrong behavior on the part of gcc as the target machine does indeed support these instructions.

@williamspatrick Right, I think you hit the nail on the head there - it's a bad warning generated by our frankencompiler. I realise it's not an issue with the OCC firmware itself but lets track it here. I'm keen to clean up the op-build so we don't have any "expected failures".
@jk-ozlabs, have you looked into this at all?

Please create op-build issue and assign to @jk-ozlabs.  He isn't a member of the OCC team so I cannot assign him this issue and he seems unresponsive to the previous inquiry.


Multilevel Recursive Multitenant

Has anyone implemented this scenario?
I have an Partner Manager entity and it's an user that can have many Partners, that is a Tenant (can see only its records), but this Partner can enroll Companies, that are also users and Tenants, and this Companies can have Employees, that are users, and also can see only their records....
It's like an hierarchy three and each level must see only its own records and its children records.
Can anyone point me into the right direction?

I've implemented more complex scenarios for some customers. Anyway, multi tenancy tutorial is what you should start at.


Terminal only sets up WSLENV if it exists in Windows in all caps

Windows Terminal version
1.13.11431.0
Windows build number
10.0.19043.0
Other Software
No response
Steps to reproduce

Open a command or PowerShell prompt
setx wslenv whatever
Start Windows Terminal
Open a WSL environment
env | grep WSL

Expected Behavior
WSLENV=WT_SESSION:whatever:WT_PROFILE_ID
Actual Behavior
WSLENV=

Doing some more digging, this seems to be a WSL issue. Closing this accordingly.


Where / how can I download an older openui5 runtime?

I'm searching for OpenUI5 version 1.44.21.
Where can I download the runtime.zip?

Hi, you can download the runtimes from there: https://tools.hana.ondemand.com/#sapui5
There is an button "Show old versions".

Thanks grischan, but that's only for SAPui5. I'm searching for the same with OPENui5... Any other ideas?

Hello @gesslinger, I've forwarded your question to a delivery responsible colleague, but still waiting for reply. At least from what I can see you could get 1.44, but in its latest subversion, which is now Version 1.44.32.
Regards, Mihail.

For sure you could request it directly in your app with https://openui5.hana.ondemand.com/1.44.21/resources/sap-ui-core.js,
but for download we have to wait for the reply.

@myordanov thanks for the info. Yes, currently we use 1.44.21 on demand. But I got now the request to self-host it. Therefore I want to use the 1.44.21 version, to avoid software clearing process etc. Would be great if your colleague can help here temporary.
For long term we will upgrade to the new lts-version and upload the runtime right now... ;-)

Hi @gesslinger, I got the answer, but unfortunately we don't store such older versions online, available for download, but only the latest and greatest one for a corresponding version. The closest you can get, but sapui5 is on https://tools.hana.ondemand.com/#sapui5 which @grischan stated in his comment.
Regards, Mihail.

I'd suggest to try with https://openui5.hana.ondemand.com/downloads/openui5-runtime-1.44.32.zip
Yes, it's a few patches after 1.44.21, but there is special care taken to stay compatible between patches of a released version. And 1.44.21 was already stabilized for a long time, so there really didn't happen a lot from there until 1.44.32:
https://openui5.hana.ondemand.com/1.44.32/#releasenotes.html


Swift 5.x and XCode 11.x support missing

Project source code lacks support for the latest versions of Swift and XCode, which leads to compilation failure.

If anybody needs the latest code with mentioned support, you can use the code from the fork until my pull request gets accepted: https://github.com/niteshborad/twiliochat-swift.


issue with multiple pages

HI, Our styleguide is a custom written piece of software. We have components across multiple pages. So I wrote a script that grabs symbols from each page, and I end up with a bunch of <page>.asketch.json files, but when I try to glob import them with the plugin it seems like only a random one of the selected files are imported. Each individual file seems to import fine on its own.
is there a way I can....
import multiple files that have symbols at a time into sketch, or is there an example like the html-sketchapp-example where symbols are computed from across multiple unique urls.

Hi, @TerribleDev!
I'm facing a similar problem.
Did you manage to find a solution or workaround for this issue?
Thank you for your help!

I did, although I can't exactly remember what I did off the top of my head.

I understand.
If you could find the time to share it, I will be most grateful. 🏅


fix: add missing -DCURLSTATICLIB for system static Curl on Windows

We need to define CURL_STATICLIB when we use static Curl on Windows.
If we don't define CURL_STATICLIB for static Curl on Windows,
google-cloud-cpp refers wrong symbols.
For example, https://github.com/apache/arrow/pull/13404 encountered
this problem:
https://github.com/apache/arrow/runs/7004628336?check_suite_focus=true#step:11:751
C:/rtools40/mingw32/bin/../lib/gcc/i686-w64-mingw32/8.3.0/../../../../i686-w64-mingw32/bin/ld.exe:
../windows/arrow-<IP_ADDRESS>00/lib/i386/libarrow_bundled_dependencies.a(curl_wrappers.cc.obj):(.text+0x2):
undefined reference to `_imp__curl_global_cleanup'

libarrow_bundled_dependencies.a includes libgoogle_cloud_cpp*.a and
curl_wrappers.cc.obj in the above log is a file in google-cloud-cpp.
I confirmed that this change solves this problem in
https://github.com/apache/arrow/pull/13404 .

This change is

/gcbrun


Adding support for building libksi on Mac OS X

Mac OSX doesn't use OpenSSL for it certificate bundles. Typically ports of applications and libraries from other Unix flavors use the OpenSSL library that can be installed with homebrew. I updated the configure.ac to look for the certificate bundle installed by homebrew. Also, I added some .gitignores to make working with git easier.

Note that this patch changes behaviour: if openssl is installed by homebrew then its root certificates will be used instead of the Keychain (OSX bundled openssl is specifically patched). Not a problem, usage of bundled OpenSSL is depreciated.


Full-text quality and text-cleaning protocol: develop set of metaprops

For R entities representing full-texts which are either referenced or included in the database, propose and discuss an authoritative set of metaprops to describe what we have been editing in the corpus progress gdoc - separating this into the full-text description (in R) and data collection campaign (in Territory) - develop metaprops for both.

We decided there is too much to record so that we develop a generalistic system. Any metaprops can be attached to the R representing the full-text already now, we will not implement any central protocol on text cleaning at this stage. Closing.


requests from different types of clients

I have been experimenting with different settings and don't think there's a solution a good solution for the following scenario (other than modifying headers in the view method):
I have a resource on /api that can be accessed from anywhere:
CORS_ORIGIN_ALLOW_ALL = True
CORS_URLS_REGEX = r'^/api/.*$'

All works fine w/ that. Now I want to access a resource on /priv-api. Using these settings it works:
CORS_ORIGIN_WHITELIST = (
    'sub.domain.com'
)
CORS_ALLOW_CREDENTIALS = True

My problem comes when I try to combine them. I don't want to ALLOW_ALL to /priv-api. Perhaps a CORS_URLS_WHITELIST would satisfy my requirement?

There was a PR in #109 that was superceded with the signal handler in #139 . You can now add arbitrary logic to allow CORS for requests matching whatever criteria you like. See the README for documentation.


Help: connecting.

I've finally managed to get past the 2FA requirement and followed the steps to connect to twitch.
At first I had to add a second OAuth Redirect URL to the application for https://twitchapps.com/tokengen to spit me out the token.
But now, if I enter the token I get it says "this token didn't work! - Client ID is missing"
And I can't figure in which format I've to to add the client ID to it, what ever I try, I get "Invalid OAuth token"...
Assuming my id is
12345678
and my token is
abcdef
How would the oauth token need to look like?

The ID is what you get when you create your application on the Twitch developer website, and there is a field in the overlay settings you have to paste it into

thanks for the quick reply
I don't see an ID field anywhere.
What I did:

Go to connections
follow the steps there
paste the token I've gotten

in overlays I've got one overlay with twitch widget, there I can't select a connection yet, as the previous step failed.
what am I overlooking?

Which version are you currently using? The ones under the "release" tab are currently too old, you need to download this repo and run it directly from Godot.
(I'm basically waiting for Godot 4 and OpenXR to be done to make a new release, with some additional new stuff)

oh, I've been running the latest release...
I guess there we've got the issue... I'll see, if I get this to build.

okay, so I've successfully built it and connecting works now but at the bottom I see now an error message which wasn't there with the old release version:

Could not initialize OpenVR -> check console output

console says this:
Godot Engine v3.4.stable.custom_build - https://godotengine.org
OpenGL ES 3.0 Renderer: AMD Radeon Vega Frontier Edition (VEGA10, DRM 3.40.0, 5.10.98, LLVM 13.0.0)
OpenGL ES Batching: ON

Found widget: Twitch chat (twitchchat.gd)
Usage count increased to 2
OpenVR: initialising OpenVR context

Application in overlay mode.
Main OpenVR interface has been initialized
Main render models interface has been initialized.
Exec path: /nix/store/132wmmmsx63nyy530y7y1jf7ndmkqh9b-vroverlay-62148d79066cbecec83c32a252ef8cec5a4b0d14/share/vroverlay
Failed to find action file
Usage count decreased to 1

I've tried the suggested ways 1 and 3 from the readmes Linux notes but without success...

There's the actions folder here: https://github.com/beniwtv/vr-streaming-overlay/tree/master/addons/godot-openvr/actions
The action folder needs to be alongside from where your executing the overlay.

Now it tells me, I can put on the headset but I can't see anything in VR.
the console spams
OpenVR could not set texture for overlay: 24VROverlayError_InvalidTexture

Hmm, that's one I haven't seen so far - what's your GPU/driver?

GPU: AMD Radeon Vega Frontier Edition
Driver amdgpu Version 21.2.6, if I see this correctly:
[nix-shell:~]$ glxinfo -B
name of display: :0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: AMD (0x1002)
    Device: AMD Radeon Vega Frontier Edition (VEGA10, DRM 3.40.0, 5.10.98, LLVM 13.0.0) (0x6863)
    Version: 21.2.6
    Accelerated: yes
    Video memory: 16384MB
    Unified memory: no
    Preferred profile: core (0x1)
    Max core profile version: 4.6
    Max compat profile version: 4.6
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
Memory info (GL_ATI_meminfo):
    VBO free memory - total: 14789 MB, largest block: 14789 MB
    VBO free aux. memory - total: 16238 MB, largest block: 16238 MB
    Texture free memory - total: 14789 MB, largest block: 14789 MB
    Texture free aux. memory - total: 16238 MB, largest block: 16238 MB
    Renderbuffer free memory - total: 14789 MB, largest block: 14789 MB
    Renderbuffer free aux. memory - total: 16238 MB, largest block: 16238 MB
Memory info (GL_NVX_gpu_memory_info):
    Dedicated video memory: 16384 MB
    Total available memory: 32752 MB
    Currently available dedicated video memory: 14789 MB
OpenGL vendor string: AMD
OpenGL renderer string: AMD Radeon Vega Frontier Edition (VEGA10, DRM 3.40.0, 5.10.98, LLVM 13.0.0)
OpenGL core profile version string: 4.6 (Core Profile) Mesa 21.2.6
OpenGL core profile shading language version string: 4.60
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.6 (Compatibility Profile) Mesa 21.2.6
OpenGL shading language version string: 4.60
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 21.2.6
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20

That all looks good, wonder why SteamVR is thinking that the OpenGL texture Godot gives it is not valid :thinking:

Maybe worth a try: could you try replacing the OpenVR .so files with the current ones from here? https://github.com/ValveSoftware/openvr/tree/master/bin/linux64


[CARBONDATA-2549] Bloom remove guava cache and use CarbonCache

Currently, bloom cache is implemented using guava cache, carbon has its own lru cache interfaces and complete sysytem it controls the cache intstead of controlling feature wise. So replace guava cache with carbon lru cache.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6008/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4849/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6049/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5054/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4964/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6126/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5115/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6336/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5174/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6586/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5478/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5421/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/6610/

retest this please

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/5492/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5440/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5445/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/5450/


keycloak redirect

Hello.
I managed to configure keycloak authenication. And it works.
If I use "loginStyle": "popup" it works as expected.
The only problem is that if I use "loginStyle": "redirect" (and I would like to use this method), even in case of a successful authentication, I'm redirected back to the login page. However, if in the browser I change the URL to http://server/studyList, I'm actually able to see the study list, and at the same time, in keycloak, the user has a session and so on.
If in  /opt/ohif/bundle/programs/server/packages/oauth.js, in var config = { I force  the redirectUrl to "/studyList", then I'm able to use redirect login style.
Do you have any suggestion or experience?
Thanks.

Hi there,
Is authRedirectUri set?
https://github.com/OHIF/Viewers/blob/33755f7b8b92e33dd45974315fb6c7fe779df8f8/Packages/ohif-user-keycloak/imports/server/setup.js#L13
There might also be a bug in this setup, though I haven't seen this behaviour myself.

This is my configuration
{
...
  "defaultServiceType": "dimse",
  "dropCollections": true,
  "keycloak": {
    "clientId": "my-client",
    "authRedirectUrl": "/studyList",
    "sslRequired": "external",
    "loginStyle": "redirect",
    "realmPublicKey": "xxx",
    "clientSecret": "yyy"
  },
  "public": {
    "userAuthenticationRoutesEnabled": true,
    "custom": {
      "keycloak": {
          "authServerUrl": "https://keycloak:8443/auth",
          "realmName": "dcm4che",
          "adminUsername": "admin",
          "adminPassword": "xxxxxxxxxx"
        }
    },
...
}

It's an i, not an l in authRedirectUri. Could you change that? I apologize for the confusion.

No problem at all. My fault.
However, it seems that this option is not taken into account. Or I'm writing it in the wrong place.
This is what I can see in the browser address bar:
https://keycloak:8443/auth/realms/dcm4che/protocol/openid-connect/auth?client_id=my-client&redirect_uri=http://ohif:3000/_oauth/keycloak&state=eyJsb2dpblN0e.....

Interesting.. There might be an issue somewhere. I see it pulling the redirectUri here: https://github.com/mxab/meteor-keycloak/blob/fd34f7c29712cef3e8c20c8dcd792193ac39683e/keycloak-oauth/keycloak-client.js#L38
so maybe indeed the option isn't being used properly. I swear I've used it before, though.
In any case, the short term plan is to drop the accounts:keycloak package in favour of a generic OpenID Connect client library. There's a branch here: https://github.com/OHIF/Viewers/tree/oidc where it's in progress.

Should be fixed now, though you have to change your settings to use something like:
"public": {
    "custom": {
        "oidc": [{
            "authServerUrl": "Your OAuth provider URL",
            "clientId": "Your OAuth ClientID",
            "authRedirectUri": "The redirect URI after the user is logged in (e.g. /studylist)",
            "postLogoutRedirectUri": "The redirect URI after the user is logged out (e.g. /)",
            "responseType": "OAuth response type, which defines which flow is used. Default is 'id_token token'. You should probably leave this as is",
            "scope": "Scope for the token request. Default 'email profile openid'. You should generally include 'oidc'"
        }]
    }
}

Should be fixed now, though you have to change your settings to use something like:

Sorry, I'm totally new to keycloak and openid...
I get this error in the URL
http://hostname:3000/#error=unsupported_response_type&error_description=Client+is+not+allowed+to+initiate+browser+login+with+given+response_type.+Implicit+flow+is+disabled+for+the+client.&state=b56e3b0f502b418787b302753fb9cd3f
Maybe keycloak is not configured in the right way. Do you have any hint?
Thanks.

Yep, there is an 'Implicit Flow Enabled' checkbox when you set up a Keycloak client. It's disabled by default, but you need to enable it.

It works! 3Q

Hello, I want to configure Ohif Viewer with dcm4che secure. But I am getting an error
Login with username password.
TypeError: OHIF.user.userLoggedIn is not a function.
Login with Keycloak.
Invalid parameter: redirect_uri

:8843/auth/realms/dcm4che/protocol/openid-connect/auth?client_id=ohif-viewer&redirect_uri=http://<IP_ADDRESS>:3300/_oauth/keycloak&state=eyJsb2dpblN0eWxlIjoicG9wdXAiLCJjcmVkZW50aWFsVG9rZW4iOiIyYVUySlBpeWYzNW5PZWszejJPUGRVR2RGcGxNQ0hOY1lBblhFNHNlV2JNIiwiaXNDb3Jkb3ZhIjpmYWxzZX0=&nonce=rGVP0srYL0LkhZnqLCPNPpJZofJSPKH6uB3hEp8HCWw&response_mode=query&response_type=code&scope=oidc:1 GET https://<IP_ADDRESS>:8843/auth/realms/dcm4che/protocol/openid-connect/auth?client_id=ohif-viewer&redirect_uri=http://<IP_ADDRESS>:3300/_oauth/keycloak&state=eyJsb2dpblN0eWxlIjoicG9wdXAiLCJjcmVkZW50aWFsVG9rZW4iOiIyYVUySlBpeWYzNW5PZWszejJPUGRVR2RGcGxNQ0hOY1lBblhFNHNlV2JNIiwiaXNDb3Jkb3ZhIjpmYWxzZX0=&nonce=rGVP0srYL0LkhZnqLCPNPpJZofJSPKH6uB3hEp8HCWw&response_mode=query&response_type=code&scope=oidc 400

same error i also got . any solution u figure it out

We recently added several recipes for implementing authentication with Keycloak in OHIF. You can find them here:
https://docs.ohif.org/deployment/user-account-control


How to switch off noisy logging?

Seems like the next lines does nothing
logging.getLogger('aiohttp.access').setLevel(logging.WARNING)
logging.getLogger('aiohttp.client').setLevel(logging.WARNING)
logging.getLogger('aiohttp.internal').setLevel(logging.WARNING)
logging.getLogger('aiohttp.server').setLevel(logging.WARNING)
logging.getLogger('aiohttp.web').setLevel(logging.WARNING)
logging.getLogger('aiohttp.websocket').setLevel(logging.WARNING)

I'm still getting such log messages continuously:
[15/06/2015 11:35:57] DEBUG: Using selector: EpollSelector
[15/06/2015 11:35:57] DEBUG: poll 0.000 took 0.000 seconds
[15/06/2015 11:35:57] DEBUG: poll took 0.002 seconds
[15/06/2015 11:35:57] DEBUG: poll 0.000 took 0.000 seconds
[15/06/2015 11:35:57] DEBUG: poll 0.000 took 0.000 seconds

The next line solve the problem:
logging.getLogger('asyncio').setLevel(logging.WARNING)


Installation on Docker image (derived from ubuntu:18.04) does not set NIX_PATH

Issue description
Version is 2.2.1. It's in a docker container derived from ubuntu:18.04.
I can't run a number of the nix-related calls (e.g. nix-env to install Obsidian's obelisk project) because $NIX_PATH is not properly set. I don't know what it's supposed to be set to, and I believe other things are not being properly set up by the installation script.
Steps to reproduce
Installation is from source, because other modes of installation ran in to the same problem. I run bootstrap.sh (even though I believe it's not needed), then ./configure, then make and make install.
Technical details
root@b99e6c4f2829:/nix-2.2.1# nix-shell -p nix-info --run "nix-info -m"
error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH or -I), at (string):1:13

For issues with or questions about Nix, please go to the Nix issue tracker. This tracker is for the Nixpkgs package set.

You need to re-login the shell or source:
. nix-profile

See:
https://github.com/NixOS/nix/blob/master/scripts/nix-profile.sh.in
So much for Docker.
I covered some of Docker issues in https://youtu.be/hhgrCV_r7YE?t=7162.
It is a Nix installer thing, I'd had supported it, covered all these reports, if my PR of new installer was merged https://github.com/NixOS/nix/pull/1565

But you would need to do . nix-profile anyway.
Because I just improved the quality of the installer more and more until it become a rewrite. I not added very much functionality there beyond better it's robustness, for the purpose to be drop-in mergeable.

If you serious - you can patch upstream with my code.
Or look through the code to understand the problems, it is very well structured and documented inside.


Multiple method calls in Api Explorer when only clicking Submit once.

There is some unexpected behavior in the Api Explorer when submitting function calls. It seems to be related to entering in information for multiple methods or just expanding multiple methods. Even though one submit button is pressed, multiple calls are submitted.

Thanks for reporting this. We've already fixed this issue though and it will be included in the next upcoming release.
Here was the original reported issue is here: https://github.com/AmbitEnergyLabs/Nano/issues/67
And the commit that fixed the issue is here which is a one-liner fix: https://github.com/AmbitEnergyLabs/Nano/commit/a35da28243f3ae67e9d1612c5def0ce3550f2e0c