[folding] Only on folding section for large file.

Testing #46588

generated a large JSON file using  https://www.json-generator.com/
open it.

Only one folding section for the top level array. Expected 5000.

Problem is that there are 5000 regions on the second level.
I should at least take the first 4999


feature: allow users to implement custom data converters.

Reason for This PR
ref: https://github.com/temporalio/sdk-php/issues/276
Description of Changes

Allow users to create a plugin data-converter, like HTTP middleware, and build custom RR binary.

License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

[x] All commits in this PR are signed (git commit -s).
[x] The reason for this PR is clearly provided (issue no. or explanation).
[x] The description of changes is clear and encompassing.
[x] Any required documentation changes (code and docs) are included in this PR.
[x] Any user-facing changes are mentioned in CHANGELOG.md.
[x] All added/changed functionality is tested.

Codecov Report

Merging #316 (d357772) into master (001c8fd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #316      +/-   ##
=========================================
- Coverage    3.71%   3.69%   -0.02%
=========================================
  Files          19      19
  Lines        1644    1650       +6
=========================================
  Hits           61      61
- Misses       1581    1587       +6
  Partials        2       2

Impacted Files
Coverage Δ

plugin.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Ongoing thread: Research results & design ideas

Keeping track of some basic research results:
Inferring PV yield for t0 ("now") (not predicting the future):
Getting about 6% normalised MAE where the network input is 128x128 pixels of satellite data (all channels) plus an embedding of the PV system ID.  Simple CNN.
Getting about 8% NMAE where network input is 2x2 pixels of NWP data (all 10 surface parameters in UKV) plus an embedding of the PV system ID.  Just a fully connected net.
Neither net gets datetime features, or clear sky irradiance, or  geo location, or anything like that.  So lots of room for improvement!

Getting down to about 5 % NMAE "predicting" the future using the actual satellite imagery for the next hour.
Similar results so far using a CNN and a simple Perceiver model (which only sees a single timestep at a time).
With the Perceiver, getting very similar results for 64x64 satellite imagery vs 32x32 imagery (except the large image takes longer to train and uses more GPU RAM!)
But we're not yet letting The Perceiver flex its muscles (by combining multiple "modalities").  Some design ideas for how to use The Perceiver more properly here: https://github.com/openclimatefix/perceiver-pytorch/issues/1

See #68 for latest ML architecture idea


Allow subselects to reference columns from the outer table

This changes the semantics of exists, and the various array_comparison
functions/methods to allow the subselect passed to them to reference
columns from the outer table. In other words, this allows subselects
which are not valid queries on their own, but are valid expressions in
this context.
Note that this only allows the where clause to reference the outer
table, as it's much less useful to do so from elsewhere in the query.
There are a few side effects of this change that will need to be
addressed later on. The first is that exists can now take any
expression, not just select statements. We should limit this to
BoxedSelectStatement and SelectStatement. Second is that you can no
longer pass a subselect to the same table. I'm not entirely sure how we
go about fixing this just yet, but that's a much more niche use case
anyway.
There is still additional work to be done to make this useable though,
as it will still be impossible to construct many queries while most of
our DSL methods still have AsQuery bounds. They will need to be
loosened in a similar fashion to #1200.

Second is that you can no
longer pass a subselect to the same table. I'm not entirely sure how we
go about fixing this just yet, but that's a much more niche use case
anyway.

For clarity, does this mean something like SELECT foo FROM tablea IN (SELECT bar FROM table_a) is no longer possible, because they select from the same table?

Well that's not a valid query either way, but yes you are getting the general idea.


Error handling windows (CreateFileMapping)

Hello,
thank you for this library, I found it helpful!
A minor issue, the handle in this line:
https://github.com/mandreyel/mio/blob/8b6b7d878c89e81614d05edca7936de41ccdd2da/single_include/mio/mio.hpp#L928
should be compared with nullptr to detect the error case in my opinion.
https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createfilemappinga#return-value

This bit me when I tried to mmap an empty file. It surprised me that the underlying APIs of the OS usually treat this as an error. Maybe handle this special case internally or leave a comment somewhere in the documentation?


Laravel 5.1.10 fresh install get Invalid hasher [] chosen for Sentry error

When I perform the php artisan authentication:install command I get the following output:
Copied Directory [/vendor/barryvdh/laravel-elfinder/resources/views] To [/resources/views/vendor/elfinder]
Copied File [/vendor/jacopo/authentication-sentry/src/config/config.php] To [/config/cartalyst.sentry.php]
Copied Directory [/vendor/jacopo/authentication-sentry/src/migrations] To [/database/migrations]
Copied File [/vendor/intervention/image/src/config/config.php] To [/config/image.php]
Copied Directory [/vendor/jacopo/laravel-authentication-acl/public/packages/jacopo/laravel-authentication-acl] To [/public/packages/jacopo/laravel-authentication-acl]
Copied File [/vendor/jacopo/laravel-authentication-acl/config/acl_base.php] To [/config/acl_base.php]
Copied File [/vendor/jacopo/laravel-authentication-acl/config/acl_menu.php] To [/config/acl_menu.php]
Copied File [/vendor/jacopo/laravel-authentication-acl/config/acl_permissions.php] To [/config/acl_permissions.php]
Copied File [/vendor/jacopo/laravel-authentication-acl/config/acl_sentry.php] To [/config/acl_sentry.php]
Copied Directory [/vendor/jacopo/laravel-authentication-acl/resources/views] To [/resources/views/vendor/laravel-authentication-acl]
Copied Directory [/vendor/jacopo/laravel-authentication-acl/database/migrations] To [/database/migrations]
Copied Directory [/vendor/lavary/laravel-menu/src/Lavary/Menu/resources/views] To [/resources/views/vendor/laravel-menu]
Publishing complete for tag []!
Migration table created successfully.
Migrated: 2012_12_06_225921_migration_cartalyst_sentry_install_users
Migrated: 2012_12_06_225929_migration_cartalyst_sentry_install_groups
Migrated: 2012_12_06_225945_migration_cartalyst_sentry_install_users_groups_pivot
Migrated: 2012_12_06_225988_migration_cartalyst_sentry_install_throttle
Migrated: 2014_02_19_095545_create_users_table
Migrated: 2014_02_19_095623_create_user_groups_table
Migrated: 2014_02_19_095637_create_groups_table
Migrated: 2014_02_19_160516_create_permission_table
Migrated: 2014_02_26_165011_create_user_profile_table
Migrated: 2014_05_06_122145_create_profile_field_types
Migrated: 2014_05_06_122155_create_profile_field
Migrated: 2014_10_12_100000_create_password_resets_table
[InvalidArgumentException]
Invalid hasher [] chosen for Sentry.
Is there something I need to do in order to avoid the InvalidArgumentException or is it really no big deal? I didn't touch any of the config files and the hasher chosen is native.

I'll take a look

trying to fix that will keep you updated.

php artisan vendor:publish should fix the problem. I'll take e deeper look later

I think something wrong happened during the install process. Did laravel work if you run php artisan serve?

I actually gave up on the whole transition from 4.2 to 5 for now (too many dependencies that don't support 5), but I will test this out a little later and let you know.


Support for TMS format ?

Hello,
Would it be possible to add support for the TMS format ?
It's the same as XYZ, but with a negative Y.
More info here : https://gist.github.com/tmcw/4954720

Hello, @Mysterius , Sounds good. I'll support TMS in future version.

In the meantime, I just edited line 166.
tiletanic.tileschemes.WebMercator(), geometry, zoom
to
tiletanic.tileschemes.WebMercatorBL(), geometry, zoom
(if anyone needs it in the future)


Can assign_winding func define whether the winding's stranded or solid?

We are unable to use assign_winding function to define the winding's "IsSolid" property right? How can we define if the winding is stranded or solid? Thanks

I've added a new input parameter to assign_winding method. is called is_solid and its default value is True.
Anyway, in the future, any boundary you create wit Pyaedt returns you a Boundary object. so you could always do the following:
mybound=aedtapp.assign_winding()
mybound.props["IsSolid"]=False
mybound.update()
this allows the user to modify properties even if they are not mapped by default.


Warn on Unsaved Changes is not being respected

When setting the page item option: Warn on Unsaved Changes to Ignore, the plugin doesn't look at this option.
When compared to a basic text page item, when the value is set to ignore the page item has js-ignoreChange added to the class.
Not sure if there's a supported API for this or need to query the page item attributes to find the option setting then manually add the class.

@martindsouza
I will investigate it. Thanks.

it is supported since 1.2.0.


Possible memory leak after 2.4.4

NEST/Elasticsearch.Net version:
2.4.4
Elasticsearch version:
2.2.2
Description of the problem including expected versus actual behavior:
Guys, while using 2.4.3, I can serve hundreds of simultaneous users without any issues. After upgrading to 2.4.4/2.4.5/2.4.6, my app started leaking memory. It usually runs with just about 80mb, after 2.4.4 in just a few hours it gets to 4gb. I'm sorry but I didn't have time to go deep into profiling NEST but I managed to isolate the problem and found out that it's something to do with NEST or ElasticSearch .NET Client.
Steps to reproduce:

Create one single instance of ElasticClient
Use jMeter or whatever to spawn multiple connections
See the difference on memory consumption from 2.4.3 to the upper versions

Can I help any further?

Hi @RTodorov thanks for opening this issue, diving on it straight away.
Using JMeter to do you hit a Search API endpoint? Can you share that call?

Also if you can share your ConnectionSettings that would be useful as well

Hey @Mpdreamz, I use JMeter to hit an endpoint that builds a dynamic query. I'll get an example query and share here.
I'm using the default ConnectionSettings with just my ES endpoint:
new ConnectionSettings("http://localhost:9200/index-name/type");

I'm not sure how useful this query is without the complete structure of my index but here it goes: http://pastebin.com/QdX8HFT8
This is one of my simplest queries but is enough to cause the leak.

I tried to verify if i see a similar behaviour using
https://gist.github.com/Mpdreamz/ec7f639632acf53448842ea42c3cf2fe
(using NEST 2.4.6 against elasticsearch 2.3.0)
But the memory consumption stays contanst (around 70-80mb) for the past 15 minutes.
Are you able to create a memory dump? I will try to remodel my setup to match you query more closely.

How are you sharing the ElasticClient instance between requests?

I tried several different methods including: static instance, using a factory with Dictionary/ConcurrentDictionary to cache 5 clients and distribute the requests over them... all with the same result.
How can I create a memory dump?

The hardcore way: http://www.diaryofaninja.com/blog/2014/03/20/investigating-aspnet-memory-dumps-for-idiots-like-me
If you have dotMemory (i think a trial is fully functional for 30days) you can easilly attach it to your local development machine's IIS web instance wait for the memory leak to be noticable and then use dotMemory to take the memory dump.
The latter option will be easiest and safest.

Not a Windows user, sorry. I'm hosting my application on Linux via Docker containers, using .NET Core 1.1

Ok no problem, can you share how you instantiate the client and share it? Just so I have a full picture.
Will bisect the changes after 2.4.3 and after to see if I can spot an offender

protected ElasticClient GetClient(string indexType, string country)
{
    var key = String.Format("{0}-{1}", indexType, country);
    if (!ClientsList.ContainsKey(key)) {
        var uri = new Uri(String.Format("{0}/{1}-{2}/{3}", Config.Endpoint, IndexName, country, indexType));

        Logger.LogInformation("Spawning new ElasticSearch client: {0}", uri);

        ClientsList.AddOrUpdate(key, new ElasticClient(new ConnectionSettings(uri)), (a,b) => b);
    }

    return ClientsList[key];
}

Each country has a different Index so I spawn one client per country, or, per index.

How many clients does this total?
The URI you pass to the connectionsettings should be the root of the elasticsearch instance.
All operations will use that as the baseUri.
You are better off calling
.Search(s=>s
    .Index(index)
    .Type(indexType)
)

Explicitly on each search call.
All the caches (both json.net and ours) are per connectionsettings. Still does not explain fully the difference in between versions though

It does only 5 clients but anyway I'll change to what you suggested for the sake of using the correct pattern.

Ok, did the change but the result remains the same. With 2.4.6, memory jumped from 80mb to 400mb in a matter of seconds.

@RTodorov since doing a memory dump is not that useful are you available for a screenshare session this week? We'll continue to bisect the commits after 2.4.3 and try to reproduce in the mean time.

@Mpdreamz yes, sure, will send you my Skype over twitter so we can arrange that!

@RTodorov sorry for not reaching out, was out doing elasticsearch training all of last week.
My colleague @russcam spotted this in the change set between 2.4.3 and 2.4.4
https://github.com/elastic/elasticsearch-net/commit/139ccfebbdbe9778201de5380000c6e4f9f33a8c#diff-4eb6f7a15a069c6324a632b9426e6046L75
This one line change had a huge impact and also surfaced #2417 which is related to this change.
We'll get a fix out tomorrow 👍

I'm pretty sure I'm seeing the same thing using 2.4.7 or any of the 5.0.0 RCs.

@michaellandi sorry to hear, the fix is forthcomming > 2.4.7 and > 5.0.0 rc3

Hey @Mpdreamz, no problem! I'm glad I could help raising the issue.
I'll test the new version as soon as it's out, run jMeter and share the results.
Thanks for the great work!

@RTodorov @michaellandi new releases of 2.x and 5.x out on nuget; would you mind taking them for a spin and checking to see if you still see the same issues?

Hey @russcam @Mpdreamz , everything seems to be fine now with 2.5.0 on my side, my app is back to the 80mb average even after 2 hours under heavy loading from JMeter. Thanks for the fix!

@russcam Thanks so much for getting a fix out soon.  Unfortunately I'm traveling with limited connectivity for the next two weeks.  But I'll definitely be pulling the new version and testing when I get back.

@russcam I am also able to confirm that things are working fine with 2.5.0.  Memory allocation of my app seems stable after several hours of testing (previously I would notice coninuous app memory growth).  Thanks for getting this fix out so quick.

Thanks for getting back @michaellandi, happy to hear that all is now well 😄
I'm going to close this issue, but feel free to open this or a new one if the problem returns.


Pin dependency versions on release

Provide a general summary of the feature here
@adobe/react-spectrum package lists dependencies on the other spectrum packages with ^x.y.z notation. This means installing a specific version of @adobe/react-spectrum does not provide a consistent install every time and there are dozens of dependencies which can change. It also makes it tedious to downgrade if needed.
🤔 Expected Behavior?
npm install<EMAIL_ADDRESS>in a fresh results in the same package-lock and always uses the same versions of all adobe packages.
😯 Current Behavior
The install will end up with the wrapper package downgraded, but all the other spectrum packages at their latest version within the same major version.
💁 Possible Solution
Pin the versions on release so the distributed package.json files do not list ^x.y.z as the versions
🔦 Context
https://github.com/adobe/react-spectrum/issues/6241 fixes an issue with combobox, but has not been released yet. We discovered this after upgrading our package-lock.json. Downgrading @adobe/react-spectrum or installing a specific version does not work around the issue because the @react-aria/overlays package is the offender and a dependency several levels down. We had to add 11 overrides just to get that version pinned properly since package-lock.json had updated all of the previous versions and the newer versions are valid according to the older version's version ranges.
- @adobe/react-spectrum 3.33.1
  - @react-spectrum/combobox ^3.12.1(3.12.3 previously installed and doesn't downgrade)
    - @react-aria/combobox (uses @react-spectrum/combobox 3.12.3 version minimum, not 3.12.1)
      - @react-aria/overlays (the package we need to downgrade. Also need to downgrade everything that consumes it to prevent newer versions since the parent has a higher minimum version listed)

💻 Examples
No response
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

I believe pinning these versions would also reduce gradle-related build errors from npm shifting dependencies.
+1

related RFC https://github.com/adobe/react-spectrum/blob/main/rfcs/2019-v3-versioning.md

The problem with pinning is that it's really easy to get duplicate copies of packages. If an app depends on one version of RSP, and it uses libraries with shared components that depend on another, the shared dependencies will currently be deduplicated, resolving to the highest compatible semver version. If RSP pinned its dependencies, this would no longer happen, and you'd get multiple different versions of the shared dependencies. This can cause problems like context not matching resulting in runtime errors, along with larger bundle sizes. I believe we tried this approach early in the life of v3, and switched to caret ranges due to these issues.


Add new Rails/RedundantReceiverInWithOptions cop

Feature
This cop checks for redundant receiver in with_options.
Receiver is implicit from Rails 4.2 or higher.
Bad case
class Account < ApplicationRecord
  with_options dependent: :destroy do |assoc|
    assoc.has_many :customers
    assoc.has_many :products
    assoc.has_many :invoices
    assoc.has_many :expenses
  end
end

Good case
class Account < ApplicationRecord
  with_options dependent: :destroy do
    has_many :customers
    has_many :products
    has_many :invoices
    has_many :expenses
  end
end

How to use
% cat app/models/account.rb
# frozen_string_literal: true

class Account < ApplicationRecord
  with_options dependent: :destroy do |assoc|
    assoc.has_many :customers
    assoc.has_many :products
    assoc.has_many :invoices
    assoc.has_many :expenses
  end
end

% rubocop /tmp/app/models/account.rb --only Rails/RedundantReceiverInWithOptions
Inspecting 1 file
C

Offenses:

/tmp/app/models/account.rb:5:5: C: Rails/RedundantReceiverInWithOptions: Redundant receiver in with_options.
    assoc.has_many :customers
    ^^^^^
/tmp/app/models/account.rb:6:5: C: Rails/RedundantReceiverInWithOptions: Redundant receiver in with_options.
    assoc.has_many :products
    ^^^^^
/tmp/app/models/account.rb:7:5: C: Rails/RedundantReceiverInWithOptions: Redundant receiver in with_options.
    assoc.has_many :invoices
    ^^^^^
/tmp/app/models/account.rb:8:5: C: Rails/RedundantReceiverInWithOptions: Redundant receiver in with_options.
    assoc.has_many :expenses
    ^^^^^

1 file inspected, 4 offenses detected

Other Information
API documentation
http://api.rubyonrails.org/?q=with_options

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests(rake spec) are passing.
[x] The new code doesn't generate RuboCop offenses that are checked by rake internal_investigation.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Updated cop documentation with rake generate_cops_documentation (required only when you've added a new cop or changed the configuration/documentation of an existing cop).

👍


Rework test suite infrastructure

This PR reworks the test suite infrastructure to use the Aries Static Agent library as a base. The static agent library is not opinionated about protocols as it implements none but rather provides a convenient architecture for working with aries connections. In other words, the Aries Static Agent library provides only cryptographic primitives and convenience methods for working with agents.
This reworking comes with the benefit of being significantly less complex than the previous agent-core implementation while retaining all of the functionality actually used and required by the test suite.
In line with the RFC on the test suite recently proposed, options for transports other than HTTP have been dropped in favor of implementations requiring other transports writing and using their own adapters to communicate with the test suite.

This looks like a good improvement to me. Thank you!


fix regession tests after calibre fix

calibre fix of file locations.
now, the calibre runsets contain the full path .gds/.sp file, pushed trough from run_drc or run_lvs.
regression tests checked and ok, except for ngspice (not available in my setup)

Sorry, we overlapped. This was fixed in  487027a9


V-wave causes vue-test-utils to fail mounting

Problem:
I'm trying to write a test with a component that uses v-wave directive, but when  I try to mount it with shallowMount() or mount() the same error happens:
Test:
describe("Components: TemplateCard", () => {
  beforeEach(() => {
    jest.clearAllMocks();
  });
  it("should get correct icon class when the type is", () => {
    const wrapper = shallowMount(TemplateCard, {
      global: { stubs: ["router-link"], plugins: [VWave] },
      props: {
        template: mockedTemplate
      }
    });

    console.log(wrapper.html());
  });
  it("should get template Models array", () => {
    const wrapper = shallowMount(TemplateCard, {
      global: { stubs: ["router-link"], plugins: [VWave] },
      props: {
        template: mockedTemplate
      }
    });

    const modelsArray = wrapper.vm.content;

    expect(modelsArray).toEqual(mockedTemplate.templateContentResponses);
  });
});

Error:

I tried to add v-wave as a plugin, that makes the first test pass for some reason. Am I doing something wrong?

This is very likely related to #46
I'm actively working on it and will get back to you soon.

Can you tell what object created is supported to be a property of?
Also, are you using Vue 2 or Vue 3?

@justintaddei I'm using vue 3 (^3.0.6) and vue-test-utils (^2.0.0-rc.2).
The property 'created' seams to be from vue core. I did not found it, maybe is something related with the lifecycle 'created'?
Components: TemplateCard › should get template Models array

    TypeError: Cannot read property 'created' of undefined

      94 |
      95 |   it("should get template Models array", () => {
    > 96 |     const wrapper = mount(TemplateCard, {
         |                     ^
      97 |       global: { stubs: ["router-link"], plugins: [VWave] },
      98 |       props: {
      99 |         template: mockedTemplate

      at invokeDirectiveHook (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:2901:33)
      at mountElement (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3788:17)
      at processElement (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3767:13)
      at patch (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3687:21)
      at mountChildren (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3862:13)
      at mountElement (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3785:17)
      at processElement (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3767:13)
      at patch (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3687:21)
      at componentEffect (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4178:21)
      at reactiveEffect (node_modules/@vue/reactivity/dist/reactivity.cjs.js:46:24)
      at Object.effect (node_modules/@vue/reactivity/dist/reactivity.cjs.js:21:9)
      at setupRenderEffect (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4143:38)
      at mountComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4102:9)
      at processComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4062:17)
      at patch (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3690:21)
      at componentEffect (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4178:21)
      at reactiveEffect (node_modules/@vue/reactivity/dist/reactivity.cjs.js:46:24)
      at Object.effect (node_modules/@vue/reactivity/dist/reactivity.cjs.js:21:9)
      at setupRenderEffect (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4143:38)
      at mountComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4102:9)
      at processComponent (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4062:17)
      at patch (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3690:21)
      at render (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:4763:13)
      at mount (node_modules/@vue/runtime-core/dist/runtime-core.cjs.js:3033:25)
      at Object.app.mount (node_modules/@vue/runtime-dom/dist/runtime-dom.cjs.js:1222:23)
      at mount (node_modules/@vue/test-utils/dist/vue-test-utils.cjs.js:2335:18)
      at Object.<anonymous> (src/components/tests/templateCard.spec.ts:96:21)

You're probably right about it being a life cycle hook considering the next function in the stack is invokeDirectiveHook.
I'll likely be reworking a lot of the internals to address the aforementioned issue. I have a feeling that whatever I come up with will resolve this too.

Please try installing v-wave@beta (npm i v-wave@beta) and let me know if it resolves your issue. I've changed how v-wave detects a vue3 environment and it shouldn't cause this problem anymore.


modpkg does not accept items-opaque folder

I can not make it work. I think it's all right but does not work.
http://www.mediafire.com/download/uud0k71t7w7tjen

I managed to use by placing the code inside a function newLevel() or function selectLevelHook() so the code was read only when enter in a world. Sorry for bad English. I used a translator. :P

@zhuowei I told you modpkg is broken

Wow I'm dumb: when a ModPkg is imported, the texture (obviously) doesn't exist, so it just errors out and disables the script. Hopefully fixed in the latest beta by restarting if texture doesn't exist and script is a modPkg.

@Rodrigo294X zhuowei fixed it

Thx :D


Сreate form utils if they don't exist

https://app.clickup.com/t/86c0jyaqm

@kerne1hub I added the code for your suggestion


[MGDSTRM-10599] Enterprise enhancements & update KFM to 7f968f0

For #266
Signed-off-by: Michael Edgar<EMAIL_ADDRESS>

Thanks @machi1990 . I'll merge this one now and tag a release for testers. The de-register script will be a follow-up PR.


Added .NET Core 2.2 EOL

According to https://dotnet.microsoft.com/platform/support/policy/dotnet-core:

Current releases are supported for three months after a subsequent Current or LTS release.

This means that, since .NET Core 3.0 was released on 2019-09-23, 2.2 will be EOL on 2019-12-23 😄

Thanks!


Enable redis filter

This is guarded with a env flag PILOT_ENABLE_REDIS_FILTER, by default it is disabled.

@hzxuzhonghu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

prow/integ-galley-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-galley-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

prow/integ-galley-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-galley-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-pilot-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

prow/integ-galley-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-galley-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-istioctl-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-istioctl-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

prow/integ-galley-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-galley-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-istioctl-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-istioctl-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

prow/integ-galley-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-galley-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-istioctl-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-istioctl-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-security-local-presubmit-tests-master

prow/integ-telemetry-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-telemetry-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

prow/integ-galley-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-galley-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-istioctl-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-istioctl-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-security-local-presubmit-tests-master

prow/integ-telemetry-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-telemetry-local-presubmit-tests-master

prow/istio-presubmit.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-presubmit-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

prow/integ-galley-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-galley-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-istioctl-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-istioctl-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-security-local-presubmit-tests-master

prow/integ-telemetry-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-telemetry-local-presubmit-tests-master

prow/istio-presubmit.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-presubmit-master

prow/integ-framework-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-framework-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-unit-tests-master

prow/integ-galley-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-galley-local-presubmit-tests-master

prow/integ-pilot-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-pilot-local-presubmit-tests-master

prow/integ-istioctl-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-istioctl-local-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-security-local-presubmit-tests-master

prow/integ-telemetry-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-telemetry-local-presubmit-tests-master

prow/istio-presubmit.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test istio-presubmit-master

prow/integ-framework-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-framework-local-presubmit-tests-master

prow/integ-mixer-local-presubmit-tests.sh
79654548710cea1b91ea3e267809294be22d2a72
link
/test integ-mixer-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I 've tested it by hand with examples in  #12139

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
a9095e747e5e2dfe2ca00b00b1e2b875a70d9bea
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
a9095e747e5e2dfe2ca00b00b1e2b875a70d9bea
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
a9095e747e5e2dfe2ca00b00b1e2b875a70d9bea
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
a9095e747e5e2dfe2ca00b00b1e2b875a70d9bea
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-mixer-k8s-presubmit-tests.sh
a9095e747e5e2dfe2ca00b00b1e2b875a70d9bea
link
/test integ-mixer-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
a9095e747e5e2dfe2ca00b00b1e2b875a70d9bea
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: hzxuzhonghu, rshriram
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]
pkg/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
a9095e747e5e2dfe2ca00b00b1e2b875a70d9bea
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
eb41b5440940f1aaa6b5064a078517d45868ef90
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
eb41b5440940f1aaa6b5064a078517d45868ef90
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
eb41b5440940f1aaa6b5064a078517d45868ef90
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Everything LGTM except not sure if it is right to include the tcp filter or not since I am not very familiar with the filters. @rshriram should we have redis+tcp filter?

@howardjohn the Redis filter is a terminating one, so the TCP filter should be excluded.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
eb41b5440940f1aaa6b5064a078517d45868ef90
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
eb41b5440940f1aaa6b5064a078517d45868ef90
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
13ad0af20ead839ca36e8010c817a7fea2cc3e83
link
/test integ-security-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
eb41b5440940f1aaa6b5064a078517d45868ef90
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
eb41b5440940f1aaa6b5064a078517d45868ef90
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-security-local-presubmit-tests.sh
13ad0af20ead839ca36e8010c817a7fea2cc3e83
link
/test integ-security-local-presubmit-tests-master

prow/integ-framework-local-presubmit-tests.sh
1ead55ad649ae0fc19ff7d7876520e35603565b3
link
/test integ-framework-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
eb41b5440940f1aaa6b5064a078517d45868ef90
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-framework-local-presubmit-tests.sh
1ead55ad649ae0fc19ff7d7876520e35603565b3
link
/test integ-framework-local-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
1ead55ad649ae0fc19ff7d7876520e35603565b3
link
/test e2e-bookInfoTests-trustdomain-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-framework-local-presubmit-tests.sh
1ead55ad649ae0fc19ff7d7876520e35603565b3
link
/test integ-framework-local-presubmit-tests-master

prow/e2e-bookInfoTests-trustdomain.sh
1ead55ad649ae0fc19ff7d7876520e35603565b3
link
/test e2e-bookInfoTests-trustdomain-master

prow/integ-security-k8s-presubmit-tests.sh
1ead55ad649ae0fc19ff7d7876520e35603565b3
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
1ead55ad649ae0fc19ff7d7876520e35603565b3
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu I just realized.. My hunch from #12236 is that having the filter on both sides results in some badness, that breaks redis clients.  Why dont we enable this only on the client side for now and leave the server side as TCP? Otherwise, I fear that most people will once again disable this filter and this will become pointless.

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
0e23ff4c6c5d864018198749f401b462a1c6eaf6
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram Thanks for your reminder.
Envoy has some improvement recently on redis proxy https://www.envoyproxy.io/docs/envoy/latest/intro/version_history.  ALso there is a flag PILOT_ENABLE_REDIS_FILTER, only users explicitly enable it , redis proxy will take effect.

/lgtm

@howardjohn @fpesce We want Redis protocol support in 1.2 branch. Could you please add the label so that mergify bot can cherry pick this PR?

@howardjohn @fpesce @rshriram Looks like 1.2 is out - can we consider this for 1.2.1 patch? Can you please add the label for auto merge to 1.2.1?

I am not sure if this can work

you mean the label? Looks like it worked, it created the  BP PR?

Hi @hzxuzhonghu , mergify failed to create the PR to cherrypick this change without conflict, please submit a manually cherrypicked PR to 1.2!
Thanks!

Thanks, will do

Is this being planned for a release with 1.2.1?

Yes, merged in https://github.com/istio/istio/pull/15049 which means it will be in 1.2.1 in the very near future


bolt run is not the same as yarn run

Title
Description

Version
v0.20.7

Type
Issue

node
10.7.0 (but also happened on Node 8)

Operating System
macOS

Short Description
bolt run is not equivalent to yarn run

Detailed description

We have a 'dev' script defined as "dev": "node scripts/dev/index.js", and scripts like "lint:css": "yarn dev lint:css",. Running yarn lint:css --bamboo passes the --bamboo option all the way to the dev script, running bolt lint:css --bamboo loses this option somewhere.
› yarn run lint:css --bamboo
yarn run v1.9.2
$ yarn dev lint:css --bamboo
$ node scripts/dev/index.js lint:css --bamboo
Running stylelint --custom-formatter ./node_modules/stylelint-junit-formatter "./src/**/*.js"  >test-reports/stylelint-css.xml

› bolt run lint:css --bamboo
⚡   bolt v0.20.7 (node v10.7.0)
$ yarn dev lint:css
$ node scripts/dev/index.js lint:css
Running stylelint "./src/**/*.js"

It would be good if both commands were equivalent so that our users would need to know when to use bolt and when to use yarn and could just always use bolt.

Related to issue https://github.com/boltpkg/bolt/issues/90

Thanks @ajaymathur - I saw that issue but didn't make the connection that it was the related.

With #90 closed, maybe this should also be closed? Then maybe open a separate issue about not passing -- onward to yarn, as yarn doesn't want the --


Don't insert semicolons inside of a macro_rules! arm body

Currently, rustfmt inserts semicolons for certain trailing expressions
(return, continue, and break). However, this should not be done in
the body of a macro_rules! arm, since the macro might be used in
expression position (where a trailing semicolon will be invalid).
Currently, this rewriting has no effect due to https://github.com/rust-lang/rust/issues/33953
If this issue is fixed, then this rewriting will prevent some macros
from being used in expression position.
This commit prevents rustfmt from inserting semicolons for trailing
expressions in macro_rules! arms. The user is free to either include
or omit the semicolon - rustfmt will not modify either case.

https://github.com/rust-lang/rustfmt/pull/4496 should be merged first, so that the tests pass

@calebcartwright This PR is now ready for review

@calebcartwright: Are there any changes that you'd like me to make?

@Aaron1011 - sorry i haven't had a chance to look at this one yet. My rustfmt bandwidth is a bit limited this week, and largely focused on addressing the broken nightly toolstate and nested tuple panic on stable issues ATM. Will try to take a look within the next few days

I was initially surprised by the updates to OperationSetting though see now why that was done. I'd forgotten how... fun the macro def formatting code is :smile:
I feel like we should have a less painful way to track/set some visitor context when formatting macros, but that'd almost certainly require some major refactoring that we don't need to attempt to tackle here.
I'm :+1: with the objective given the likely upstream changes as well as the general approach, although I do want to see this tweaked a bit to keep things encapsulated internally within the rustfmt lib vs. exposing the macro def context through the public API (we do actually have some folks using rustfmt as a lib). This should avoid leaking any internals, and also give us flexibility to potentially refactor down the road without introducing breaking changes to the interface.
Perhaps some additional internal functions (format_input_inner and friends) could be updated to accept the new param and then utils::format_snippet could just directly use format_input_inner instead of the public-facing function.

I feel like we should have a less painful way to track/set some visitor context when formatting macros, but that'd almost certainly require some major refactoring that we don't need to attempt to tackle here.

Yeah. that was my conclusion as well.

although I do want to see this tweaked a bit to keep things encapsulated internally within the rustfmt lib vs. exposing the macro def context through the public API

That's in reference to OperationSetting, right?

Perhaps some additional internal functions (format_input_inner and friends) could be updated to accept the new param and then utils::format_snippet could just directly use format_input_inner instead of the public-facing function.

I'll try that

That's in reference to OperationSetting, right?

Correct

@calebcartwright Updated

@calebcartwright: Could you make a new release containing this change? I need this to be able to make progress on some upstream issues.

Sure, will push for doing so in the next day or two


Feature Request : NSView extension

Can you please add below:
@IBDesignable
extension NSView
{
	@IBInspectable var backgroundColor: NSColor? {
		get {
			if let colorRef = self.layer?.backgroundColor {
				return NSColor(CGColor: colorRef)
			} else {
				return nil
			}
		}
		set {
			self.wantsLayer = true
			self.layer?.backgroundColor = newValue?.CGColor
		}
	}
}

You’re welcome to open a pull request yourself and do it 🙂

Created first pull request, hope someone will approve and merge to master.

When I use NSTextField.backgroundColor, this is ambiguous property now

When I use NSTextField.backgroundColor, this is ambiguous property now

When I use NSTextField.backgroundColor, this is ambiguous property now. same problem


Error with finding custom validation function when running validations outside of repository root

This error was reported by Spencer:
> validate_submission(hub_path = '../variant-nowcast-hub',
+                     file_path = 'UGA-multicast/2024-10-23-UGA-multicast.parquet') -> sub_validation
Error in `purrr::map()`:
ℹ In index: 1.
ℹ With name: clade_prop_sum_one.
Caused by error in `file()`:
! cannot open the connection
Run `rlang::last_trace()` to see where the error occurred.
Warning message:
In file(filename, "r", encoding = encoding) :
  cannot open file 'src/validations/R/clade_prop_sum_one.R': No such file or directory

He confirmed that validations run OK if he runs them from within the hub repo root, specifying hub_path = '.'.  It seems like somewhere, we should be targeting the clade_prop_sum_one.R file relative to the hub_path, but we're just using that relative path directly.

Oops. that's my bad.

Tracking this in https://github.com/hubverse-org/hubValidations/issues/141

Closing at it appears 141 was solved.


[ReQuest] Enable Sunny Weather Monitor Brightness in Video Mode

Hello ma1co,
thanks for your great work! I use it on my A7RII and RX100IV and I love it.
I have a request, maybe a simple one. I shoot a lot of video and it pisses me of that I can't choose the sunny weather monitor brightness in Video Mode. I think sony just turned it off to save battery but I think it would be way easier to see what I shoot.
Maybe this is not a big deal for you to bring it to OpenMemories-Tweak, but it will be a big deal for every film maker. :)

Yes please! I just bought the A6500 and it's pretty much useless for outside video. I don't get why Sony disabled the sunny weather mode. Just put up a warning telling the user to flip out the screen, so that it doesn't touch the back of the camera.
It would be amazing if it was possible to enable sunny weather mode :)

Yes please!
My A7R II also suffer from this issue. and the issue is really critical: nearly impossible to shoot 4k video on bright light.
It would be amazing if it was possible to enable sunny weather mode :)

Sony A6500 when shooting video, the lcd screen goes so dark that i can barely see it in outdoor light.  Absolutely killing the video features of this great camera. Please, help!


[tracing] updating to opentelemetry 1.0.0-rc.0

This PR does the final leg of updating our code base to opentelemetry 1.0.0-rc.0, which has been done in pieces with #14094, #14082, #13951, #13949 and #13942.
This PR looks deceptively big but in reality it's just a few similar changes, but applied across a lot of projects. The three areas that you'll care about:

Your rollup.config file now has a new import from dev-tool that will take care of formulating the proper opentelemetry/api rollup configuration. This is setup for everyone at this point, so if future things come up this should be easier (hopefully).
NOBODY references opentelemetry/api directly! The work we did in the previous PRs meant that all packages can just depend on core-tracing and get opentelemetry transitively. This should greatly simplify things currently and in the future!
azure/identity also got updated in all packages devDependencies so we don't have to deal with mixed versions of OTel in every package.
Code changes largely fell into three buckets:

CanonicalCode -> SpanStatusCode changes (mostly squashing CanonicalCode into SpanStatusCode.ERROR)
Test code that wasn't using createSpan and thus needed slight updates to create and pass a context.

(unresolved, future PR) SpanStatusCode.OK no longer lines up with the 'default' value so spans that do not have span.setSpanStatus(SpanStatusCode.OK) set on them will default to UNSET instead. We should be able to fix this centrally but that is not in this PR.

Note to reviewers: build breakage appears to be because of a newly added package while I was crafting up my PR. I'm looking into it, but it shouldn't change the substance of the PR. Please review your packages and see if there's anything you need me to change.

@EmmaZhu, @ljian3377: This is part of (hopefully) the last changes to get to 0.18 of the opentelemetry package. I've detailed what to expect in the PR description. Storage was a bit different than the other stacks - I needed to modify the rollup config to allow opentelemetry to have a circular dependency and I had to make two packages in storage depend on the version of storage-blob, which means they're referencing a preview.

Please hold off on merging until all the releases for this month is done. Tables and Text Analytics should release tomorrow, followed by Event Grid early next week

🚀 LGTM (pending same question as Deya on caret versioning).
Looks like KeyVaults needs to set the status correctly. I'll add it to the issue tracking KeyVault tracing.

Let's handle that universally if we can. I was thinking perhaps we'd just wrap the span.end() method to provide this behavior if we're satisfied that it's what we want as a default (since we control span instantiation now) but I'm open to ideas (of which I know you have many!)

Please hold off on merging until all the releases for this month is done. Tables and Text Analytics should release tomorrow, followed by Event Grid early next week

No worries. I just wanted to make sure I could go end-to-end with this change and there are some areas that I think will warrant discussion.

/check-enforcer evaluate

/check-enforcer reset

/azp run js - app-configuration - tests

/azp run js - storage-blob - tests

/azp run js - storage-file-share - tests

/azp run js - event-hubs - tests

@opentelemetry/api has released a 1.0 rc! I've updated the packages in this PR appropriately.

@opentelemetry/api has released a 1.0 rc! I've updated the packages in this PR appropriately.

Can you update the PR title and description to match that?

/azp run js - eventhubs-client - tests

Looks good, I have filed Azure/autorest.typescript/issues/892 to track the changes required in the generator. Please feel free to comment if you think I'm missing any

Will do, thanks @joheredi!

Note to reviewers: I've just rolled back the "let's get everyone to identity 2.x change" because rollup was causing me to dig a deep hole.
Instead, we're just using the published 1.x version of identity instead. This doesn't materially affect anyone (it's mostly just a different set of rollup hackery).

/azp run js - test-utils - ci

/azp run js - storage-blob - tests

/azp run js - eventgrid - tests

Monitoring the live test failures - so far the failures appear to be infrastructure/external from the code change I'm making:

eventgrid - failed to find it's own package when bootstrapping the samples
schemaregistry - only one platform failed and that one failed when checking out code (timed out)

/azp run js - communication-administration - tests
/azp run js - communication-chat - tests

/azp run js - communication-administration - tests

/azp run js - communication-chat - tests

/azp run js - communication-identity - tests

/azp run js - communication-phone-numbers - tests

/azp run js - communication-sms - tests

/azp run js - storage-file-datalake - tests

/azp run js - storage-file-share - tests

/azp run js - storage-queue - tests

/azp run js - attestation - tests

/azp run js - container-registry - tests

NOTE - the failures that have occurred so far (metricsadvisor and mixedreality) appear to be related to some DNS issues we're having in our agents. The tests have completed, it's the Analyze phase that's failing.

/azp run js - metricsadvisor - ci

/azp run  js - mixedreality - ci

There are issues with the container-registry pipeline that are unrelated to anything in this PR. Ignoring those failures for now (@jeremymeng is working on it independently of this).

Okay, to sum up:

container-registry failures are being worked on @jeremymeng, independently of this PR.
js - storage-file-datalake - tests failed on a single test on Ubuntu+node15, but passed on all others. Unfortunately the test swallows the actual text of the exception but I believe @mikeharder  was investigating boundary conditions like this where node 15 increased a limit that can cause this test to no longer fail in the expected way.
Other failures are transitive and all appear to be affected by DNS/transitive network issues, and not the contents of this PR.

I'm going to bypass checkenforcer (since it's stuck now on the containre-registry failures) and merge this in. CC: @ramya-rao-a

/check-enforcer override


Change git:// to https://

Summary
This PR changes git:// to https:// in the Gemfile, correcting a change made in #983.
Motivation and Context
This change will enable forwarding via HTTP proxies.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] I've added tests for my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

To be consistent, I think we should use "https://" everywhere in the Gemfile, so I fixed that (0f4619f) and merged.

Oh thanks @brasmusson, I had only noticed it in that one place.


Imports are incorrectly sorted after isorting

So I've run an isort -rc -y command and after that I isort -rc --check-only and I get to see that some of the files has Imports are incorrectly sorted.
This is part of the code that is being involved:
from products.factories import (
    ProductFactory,
    ProductImageFactory,
    ProductOptionFactory,
    ProductOptionValueFactory,
    ProductPresentmentPriceFactory,
    ProductVariantFactory,
)
from products.models import Product, ProductImage, ProductOption, ProductOptionValue, ProductPresentmentPrice, ProductVariant

from django.test import TestCase

setup.cfg
[isort]
line_length=140
forced_separate=django
multi_line_output=3
balanced_wrapping=True

This should be fixed for the 5.0.0 release in spirit via this ticket: https://github.com/timothycrosley/isort/issues/1147


RuntimeError: CUDA OOM / Bad Training Performance after reducing crop_size

Hello @Yuxiang1995 ,
I am attempting to train your Network on a single gpu.
But then I get this Error:
RuntimeError: CUDA out of memory. Tried to allocate 1.86 GiB
(GPU 0; 4.00 GiB total capacity; 1.48 GiB already allocated; 319.91 MiB free; 1.88
 GiB reserved in total by PyTorch)

I also tried it with a 10 GiB GPU but still the same error.
... well I am able to train it when I reduce the crop_size in conigs/_base_/datasets/formula_detection.py
But it seem the model doesnt learn anything, since the loss doesnt get smaller.
... and I saw in your presentation that the large crop_size is a feature of your model.
Can you give me hint how to sucessfully train the model on a single gpu, i.e get rid of the CUDA OOM Error ?

Hi, I tried removing the input image size, which will make it run but now I have problems because the loss is not converging (as others said in several issues)

#11


ValueError: invalid literal for int() with base 10: ':1'

sorry to bother you, but I meet the follow error when using gradio interface.
Traceback (most recent call last):
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/httpx/_urlparse.py", line 339, in normalize_port
    port_as_int = int(port)
ValueError: invalid literal for int() with base 10: ':1'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/snowball/Documents/Code/LLMGA/llmga/serve/gradio_web_server.py", line 7, in <module>
    import gradio as gr
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/gradio/__init__.py", line 3, in <module>
    import gradio.components as components
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/gradio/components/__init__.py", line 1, in <module>
    from gradio.components.annotated_image import AnnotatedImage
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/gradio/components/annotated_image.py", line 13, in <module>
    from gradio import utils
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/gradio/utils.py", line 344, in <module>
    class AsyncRequest:
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/gradio/utils.py", line 363, in AsyncRequest
    client = httpx.AsyncClient()
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/httpx/_client.py", line 1408, in __init__
    self._mounts: typing.Dict[URLPattern, typing.Optional[AsyncBaseTransport]] = {
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/httpx/_client.py", line 1409, in <dictcomp>
    URLPattern(key): None
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/httpx/_utils.py", line 397, in __init__
    url = URL(pattern)
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/httpx/_urls.py", line 113, in __init__
    self._uri_reference = urlparse(url, **kwargs)
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/httpx/_urlparse.py", line 246, in urlparse
    parsed_port: typing.Optional[int] = normalize_port(port, scheme)
  File "/home/snowball/anaconda3/envs/llmga/lib/python3.9/site-packages/httpx/_urlparse.py", line 341, in normalize_port
    raise InvalidURL("Invalid port")
httpx.InvalidURL: Invalid port

Thanks

It seems that the import Gradio reported an error. This is not my code issue, it's a problem with Gradio. I suggest Google it

I have solved this problem by manual install gradio (3.50.2), graio_client(0.6.1) and httpx(0.26.0) library before pip install -e . . Thanks!

Could you give me an example or some tips of inference using llmga-llama-2-7b and llmga-sd15-t2i? It seems that the provided code is adapted to sdxl, but not to sd15.

Hi, I update my code for gradio on SD15 T2I. You can run it
python3 llmga.serve.gradio_web_server.py
--model-path ./checkpoints/llmga-llama-2-7b-chat-full-finetune
--sdmodel_id ./checkpoints/llmga-sd15-t2i
--load-4bit
--model-list-mode reload
--port 8334 \

problem solved. Thanks!


fix: add support for exiting cos id

Description
Adds support for existing cos instance ID.
https://github.ibm.com/GoldenEye/issues/issues/8071

Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

LGTM

I don't think adding a count will destroy anything here. maybe if the module name string was renamed (module.cos_instance) but it was not. It just got a count added to it

:tada: This PR is included in version 7.5.2 :tada:
The release is available on:

GitHub release
v7.5.2

Your semantic-release bot :package::rocket:

I was wrong - there was a breaking change in this change. Fix is in https://github.com/terraform-ibm-modules/terraform-ibm-cos/pull/564


convert interactive_demo to .exe

Thank you for your great work!
I want to know if it is possible to convert .py to .exe for this work?

Not an expert but https://stackoverflow.com/questions/5458048/how-can-i-make-a-python-script-standalone-executable-to-run-without-any-dependen


Critical error: ng2-dnd/ng2-dnd.d.ts, found version 4, expected 3, after Angular cli update

I'm submitting a ...
[*] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?

What is the current behavior?

Failes to run / compile after ANGULAR CLI UPDATE
ERROR in Error: Metadata version mismatch for module node_modules/ng2-dnd/ng2-dnd.d.ts, found version 4, expected 3, resolving symbol AppModule in src/app/app.module.ts, resolving symbol AppModule in src/app/app.module.ts, resolving symbol AppModule in /src/app/app.module.ts
at Error (native)
at syntaxError (node_modules/@angular/compiler/bundles/compiler.umd.js:1729:34)
at simplifyInContext (node_modules/@angular/compiler/bundles/compiler.umd.js:24979:23)
at StaticReflector.simplify node_modules/@angular/compiler/bundles/compiler.umd.js:24991:13)
at StaticReflector.annotations (node_modules/@angular/compiler/bundles/compiler.umd.js:24418:41)
at _getNgModuleMetadata (node_modules/@angular/compiler-cli/src/ngtools_impl.js:138:31)
at _extractLazyRoutesFromStaticModule (/node_modules/@angular/compiler-cli/src/ngtools_impl.js:109:26)
at Object.listLazyRoutesOfModule (node_modules/@angular/compiler-cli/src/ngtools_impl.js:53:22)
at Function.NgTools_InternalApi_NG_2.listLazyRoutes (node_modules/@angular/compiler-cli/src/ngtools_api.js:91:39)
at AotPlugin._getLazyRoutesFromNgtools (node_modules/@ngtools/webpack/src/plugin.js:212:44)
at _donePromise.Promise.resolve.then.then.then.then.then (node_modules/@ngtools/webpack/src/plugin.js:448:24)
at process._tickCallback (internal/process/next_tick.js:109:7)

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar.

Project worked, until update Angular cli

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:
ANGULAR CLI
@angular/cli: 1.4.9
node: 6.10.3
os: darwin x64
*angular/common: 4.4.6
*angular/compiler: 4.4.6
*angular/core: 4.4.6
*angular/forms: 4.4.6
*angular/http: 4.4.6
*angular/platform-browser: 4.4.6
*angular/platform-browser-dynamic: 4.4.6
*angular/router: 4.4.6
*angular/cli: 1.4.9
*angular/compiler-cli: 4.4.6
typescript: 2.2.2

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

Thank you for taking your time looking into this issue!
Best regards,
Bart

Updating to Angular 5 solved this issue, might i suggest to leave this issue in closed so people face this issue might find this solution?
Thank you for this plugin and maintaining it
Best regards,
Bart

Hi Bart,
Sure.

Hello when V4.2.0 had some issue with angular 4 (drag-drop not properly works, or data undefined)
I upgraded from V4.2.0 to 5.0.0 for my angular v 5
But still ERROR in Metadata version mismatch for module ng2-dnd.d.ts found version 4, expected 3.
Some idee ?