Test new PR create views

Refs: https://github.com/microsoft/vscode-pull-request-github/issues/4403

[ ] anyOS @connor4312
[x] anyOS @aiday-mar
[ ] anyOS @karthiknadig

Complexity: 5
Authors: @alexr00, @hbons
Create Issue

We have update the Create PR webview and the Files changed views. Please do exploratory testing on the "Create" views.
Setup:

Install the pre-release build of the extension
The new views are enabled by default already in the pre-release version
Open a folder with a GitHub repository that you don't mind create PRs and pushing branches in
To open the "Create" views, use the "Create Pull Request" command or the "Commit & Create Pull Request" button in the SCM view.

Specific features to test:

Setting assignees, reviewers, labels, and a milestone from the create view
After setting assignees/reviewers/labels/milstones, confirm everything in the webview is tabbable
We try to guess your "into" branch better: If the branch you branched off from has an remote, then that will be your into branch. Otherwise, it will be the default branch for the repo
In the branch selector, confirm ‘Change Repository…’ lists the repositories in the network
The "Create" button remembers your last choice
The "Files Changed" view shows changes even when your branch hasn't been pushed yet
The "Files Changed" and "Commits" view update when you change branches or push your "from" branch.
The controls in the webview are disabled when you open the view as we load the data for the view
The controls in the webview are disabled after you click the "Create" button and while the PR is being created

HI @alexr00, I am currently testing the work. While testing, I had the following thoughts:

It seems as though it is currently not possible to create labels (perhaps I have not missed the button to do so). However it is possible to create milestones from the view. Do you think it would be useful to be able to create labels too?
After I set the assignee, the reviewer and the label I notice the following:

There appears to be little space between the reviewer/assignee name and their circular picture. Perhaps a little padding could make it better.
3. Concerning the Change repository... button, I was wondering what repositories exactly I should expect to see?Currently the only repository shown is the one I am currently on. I was expecting to see the other repositories I host on my account.

I like the new interface!

It seems as though it is currently not possible to create labels (perhaps I have not missed the button to do so). However it is possible to create milestones from the view. Do you think it would be useful to be able to create labels too?

Seems like a reasonable feature rerquest!

There appears to be little space between the reviewer/assignee name and their circular picture. Perhaps a little padding could make it better.

@hbons already has a fix ready and is waiting on me: https://github.com/microsoft/vscode-pull-request-github/pull/5101

Concerning the Change repository... button, I was wondering what repositories exactly I should expect to see?Currently the only repository shown is the one I am currently on. I was expecting to see the other repositories I host on my account

You will only see repos that you have as git remotes.

Hey @alexr00, thanks for the response. I have these other git remote repos on my account. They are however not cloned locally on my computer. From what I understand, I should have seen them in the Change repository... view?


Hooks refactor

Table of Contents

Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:

Description

Introduce hooks support
Refactor CoreExperiment to use hooks
Update tests.
Fix slow tests
Motivation and Context

Ready support for react 17.x
Add hooks support for React Functional Components
How Has This Been Tested?

Updated tests related to params changes for core experiment.
Added specific tests for hook, useExperiment
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Hey @tbrannam, looks like an amazing work, I'll have deep look tomorrow.
Having support for hooks is great, I think we'll have to create a major release, since we're no longer supporting<EMAIL_ADDRESS>and react@15, but it should be fine, we can potentially add it to README.
I'm sorry about the late reply (currently drowning in reviews 😅), thank you for submitting this pull request! 🎉

It's all good - I think I did everything I wanted to do - just added tests for hooks.

friendly bump

I had another deep look at source code and I think it looks really good.
One way to solve the last problem that you mentioned would be to extend the useExperiment hook, eg. use an object for advance configuration:
useExperiment('experiment_name', {
  variants: ['A', 'B'],
  defaultVariant: 'A',
  userIdentifier: 'pk_123',
});

I think we could potentially merge this PR as it, release a beta version of v3, test it for a few days and see how it goes, what do you think?

Sounds good

From: Paolo Moretti<EMAIL_ADDRESS>Sent: Tuesday, September 17, 2019 5:32:42 AM
To: marvelapp/react-ab-test<EMAIL_ADDRESS>Cc: Todd Brannam<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [marvelapp/react-ab-test] Hooks refactor (#10)
I had another deep look at source code and I think it looks really good.
One way to solve the last problem that you mentioned would be to extend the useExperiment hook, eg. use an object for advance configuration:
useExperiment('experiment_name', {
variants: ['A', 'B'],
defaultVariant: 'A',
userIdentifier: 'pk_123',
});
I think we could potentially merge this PR as it, release a beta version of v3, test it for a few days and see how it goes, what do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/marvelapp/react-ab-test/pull/10?email_source=notifications&email_token=AAATHXN7ENKIOJ3SKPSMJNLQKCP3VA5CNFSM4IUR4FW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD635R7A#issuecomment-532142332, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAATHXMIRLUYZZ3MUO5EHN3QKCP3VANCNFSM4IUR4FWQ.

Released in 3.0.0-beta.0 🎉


Smart Contract Source Mapping

Hi,
This proposal covers a source code mapping standard, used in debuggers (it maps AVM instructions into higher level programming languages code).

Similar proposal: #48

@lock9, are you going to close this one and merge with PR48?
By the way, congratulations for the proposal. It looks something good for long-term.

Hello! Yes, let's use #48!


transaction.d.ts has TS error

Type 'Builder<Ent<TViewer>, TViewer, any>' does not satisfy the constraint 'Builder<Ent<TViewer>, Viewer<any, any>, any>'.
  Types of property 'ent' are incompatible.
    Type 'EntConstructor<Ent<TViewer>, TViewer>' is not assignable to type 'EntConstructor<Ent<TViewer>, Viewer<any, any>>'.
      Type 'Viewer<any, any>' is not assignable to type 'TViewer'.
        'Viewer<any, any>' is assignable to the constraint of type 'TViewer', but 'TViewer' could be instantiated with a different subtype of constraint 'Viewer<Ent<any> | null, ID | null>'.

There is also a build error in operations.d.ts:
Property 'builder' in type 'RawQueryOperation<TEnt, TViewer>' is not assignable to the same property in base type 'DataOperation<TEnt>'.
  Type 'Builder<TEnt, TViewer, MaybeNull<TEnt>>' is not assignable to type 'Builder<TEnt, Viewer<Ent<any> | null, ID | null>, MaybeNull<TEnt>>'.
    Types of property 'ent' are incompatible.
      Type 'EntConstructor<TEnt, TViewer>' is not assignable to type 'EntConstructor<TEnt, Viewer<Ent<any> | null, ID | null>>'.
        Type 'Viewer<Ent<any> | null, ID | null>' is not assignable to type 'TViewer'.
          'Viewer<Ent<any> | null, ID | null>' is assignable to the constraint of type 'TViewer', but 'TViewer' could be instantiated with a different subtype of constraint 'Viewer<Ent<any> | null, ID | null>'.

This is using node v19.4.0 and TS 5.2.2
This doesn't really matter to me since I can just do "skipLibCheck": true in tsconfig, but it probably would be something work fixing.

which @snowtop/ent version?

nvm. found it on latest


Document for Terraform Registry

https://www.terraform.io/docs/registry/providers/docs.html
https://github.com/bflad/tfproviderdocs

In future, maybe we have to migrate document from https://terraform-provider-graylog.github.io/#/ to Terraform Registry

Yes please register for the new registry, that would improve the provider installation a lot!

#46


Fix with cache, because must be no case sensitive.

For example:
Two dependencies like “https://github.com/PolymerElements/iron-flex-layout.git” must be equal to “https://github.com/polymerelements/iron-flex-layout.git”
But in the cache is treated as differents folders:
~/.cache/bower/packages/444ea84ad1b11545629269bdc8d5330e/
~/.cache/bower/packages/9170ac518f979438268666845fc8f0fb/
$ md5 -s https://github.com/PolymerElements/iron-flex-layout.git
MD5 ("https://github.com/PolymerElements/iron-flex-layout.git") = 444ea84ad1b11545629269bdc8d5330e
$ md5 -s https://github.com/polymerelements/iron-flex-layout.git
MD5 ("https://github.com/polymerelements/iron-flex-layout.git") = 9170ac518f979438268666845fc8f0fb

A test for making sure the hash ends being lower case would be nice.

Unfortunately in general URLs are case-sensitive, the behavior seems correct

@sheerun is right.

According to W3's "HTML and URLs" they should:
There may be URLs, or parts of URLs, where case doesn't matter, but identifying these may not be easy. > Users should always consider that URLs are case-sensitive.

source: http://stackoverflow.com/questions/7996919/should-url-be-case-sensitive

Closing this as the current behavior is expected.


What's the work flow for including js libraries in a block?

I'm new to creating gutenberg blocks and react (so still learning!)
If I needed a js library for example like https://kenwheeler.github.io/slick/ in my block.
Should the initialization etc be included in the block or should it be a separate file?
If it's a separate file, how would I be able to optimize so that the library is only loaded if the block is used on a page?

You'd enqueue the JS and CSS in the init.plugin file.
Then add the markup in the block JS file.
You'd need to make a nested block to add the slides.


Task Parsing Part for Pytorch Implementation

@MihaiSurdeanu @bethard @kwalcock
Here is my current code of the MTL in torch. Thanks to Steve, I already fixed few bugs in the code.
This is just the task manager and file reader part, I will do another pull after I get the NER task implemented.

Looks nice so far!


Modsecurity periodically generate warning in SecAction "initcol"

Describe the bug
We try use modescurity by a little on our servers. We enable it on some servers on some virtualhosts with small load - all OK. Then I enable modsecurity on other server with with a greater load and begin receive warnings in nginx log file:
my.test.ru/error.log:12290:2020/06/22 13:35:30 [info] 6902#0: *11796330 ModSecurity: Warning.  [file "/home/modsecurity/config/main.conf"] [line "6"] [id "5"] [rev ""] [msg ""] [data ""] [severity "0"] [ver ""] [maturity "0"] [accuracy "0"] [hostname "<IP_ADDRESS>"] [uri "/"] [unique_id "159282213087.094353"] [ref ""], client: <IP_ADDRESS>, server: my.test.ru, request: "GET / HTTP/1.1", host: "my.test.ru"

This messages are repeated in log file
grep -rni "ModSecurity: Warning" /home/nginx/*/logs/error.log | wc -l
108480

In my modsecurity config line 6:
SecAction "initcol:ip=%{REMOTE_ADDR},id:5,pass,phase:1"

Modsecurity module is working (blocking bad ip), but periodically generate this  warning messages.
Logs and dumps
server version: Debian GNU/Linux 9.12 (stretch)
Nginx version: nginx -V - https://pastebin.com/ruisbGvR
Modsecurity version (build as debian package):
dpkg -l | grep modsec
ii  modsecurity                      3.0.4-1~stretch                                       amd64        Open Source Web Application Firewall

ldd  /usr/local/modsecurity/lib/libmodsecurity.so  - https://pastebin.com/A19iysq5
Module was build with LMDB support (https://github.com/SpiderLabs/ModSecurity/issues/2262)
Modsecurity logs looks like good (logs when generated warning message in nginx log):
https://pastebin.com/VHzcB7LD
https://pastebin.com/aw9exY9r
What exactly  blocking rules of modsec are doing: if bad ip try send 3 bad attempts (with bad url), then this ip is block.
cat -n /home/modsecurity/config/main.conf  | less
6  SecAction "initcol:ip=%{REMOTE_ADDR},id:5,pass,phase:1"
...
SecRule REQUEST_FILENAME \
    46  "@rx (\.asp|\.aspx|\.cgi|\.cfg|\.jspa|\.jsp|\.ashx|sqlitemanager/main\.php|agsearch/sqlite/main\.php)$" \
    47   "id:80,t:lowercase,phase:1,pass,chain"
    48      SecRule &ip:allowed "@eq 0" \
    49      "id:100,phase:1,setvar:ip.bad_attempts=+1,\
    50      setvar:'ip.attempts_flag_expire_timestamp=%{TIME_EPOCH}',\
    51      setvar:'ip.attempts_flag_expire_timestamp=+86400', \
    52      setvar:ip.real_ip=%{remote_addr}"
...
    56  SecRule ip:bad_attempts "@ge 3" "id:'200',phase:1,pass,nolog,setvar:ip.block_flag=1"
    57  SecRule ip:block_flag "@eq 1" "id:500,phase:1,drop,log,logdata:'Blacklist ip.block_flag - %{ip.block_flag}, real_ip - %{ip.real_ip}'"

as if it looks like this, that sometimes modsecurity cannot initialize ip collection (but these are just my thoughts). I repeat - modsecurity is working (it block bad ip),  but a little confused this warning messages in nginx log file (on other servers with enabled modsec this warnings are absent). What can they mean?
To Reproduce
Steps to reproduce the behavior:
Build modsecurity with LMDB support, send on nginx some load (r/s), write rule which will block ip.

Hi @unix196 ,
I don't believe this had anything to do with initcol specifically; it was more of a general pattern
While what you describe did happen in v3.0.4, it had already been changed around 3 months before you posted this. And of course, it would not occur with v3.0.5 or v3.0.6.


add scalar substition support

This has been manually tested for

concatenation
multiple keys
unbound vars
command line usage errors
port automatic int conversion

Some items are still under discussion, such as the exact syntax of the variables, but this is a good enough start that I'll make it a non-draft.

The scalar substitution approach seems good to me. Still thinking through whether we want to pass in the args this way, v/s an explicit --set x=y,m=n and if there's any functional difference between these.
cc @enisoc

The scalar substitution approach seems good to me. Still thinking through whether we want to pass in the args this way, v/s an explicit --set x=y,m=n and if there's any functional difference between these.
cc @enisoc

I guess a comma-separated approach may be harder to escape with quotes in case some items need shell escaping and some items should not be escaped by the shell.  Perhaps multiple --set x=y would be an alternative.

This PR has been updated as discussed for

The new syntax @{var} instead of ${var}, to avoid overlap with shell expansion and the like.
Uses multiple --set var=val to disambiguate other future possible args and have the simplest/least error prone usage we could think up.
Also, added a conflicting variable def check.


Automatically add operator:wikidata=* when using a preset for a common franchise

For example, if I'm going to use the McDonald's iD preset to tag a restaurant, it would automatically add operator:wikidata=Q38076.
The tag brand:wikidata=* can also be conceivably be used if any iD presets make use of brand.

I thought there was a previous discussion on automatically adding wikidata tags other than wikidata=* which concluded against it, but can't find it.
Note: the common franchise stuff is coming from another repo, so changes would be needed there first.

I'm not against the idea, but if we end up doing this, the name-suggestion-index project is the place to add it.

Thanks. This is the relevant discussion there if anyone is interested: https://github.com/osmlab/name-suggestion-index/issues/38


setup_shclustering recipe searches are not idempotent

Cookbook version
4.0.5
Chef-client version
15.6.10
Platform Details
Redhat 8
Scenario:
Enable SH clustering and run on a node with captain=mode. The search and the execute resource to bootstrap the SHCluster captain is always run by the captain.
Steps to Reproduce:
[If you are filing an issue what are the things we need to do in order to repro your problem? How are you using this cookbook or any resources it includes?]
Expected Result:
Captain bootstrap should only run when a SH Cluster has no captain and should also not perform the search for cluster members
Use splunk show shcluster-status to guard against these actions.
Actual Result:
The chef run on a SH captain runs the chef search for cluster members on every run, and execute resource is only guarded by a hidden state file; the latter will try to bootstrap a captain even if the cluster already has a captain (e.g., in a distributed SH cluster with dynamic captain).

Fixed in v4.1.10 by https://github.com/chef-cookbooks/chef-splunk/pull/142


⚠ Visual-Crew_Builder has degraded performance

In 1f9a621, Visual-Crew_Builder (https://visual-crew-builder.ai) experienced degraded performance:

HTTP code: 200
Response time: 1376 ms

Resolved: Visual-Crew_Builder performance has improved in f9e5b68 after 9 minutes.


Backport 2.9 fix

Description
Backport PRs:

https://github.com/opensearch-project/security-analytics/pull/918
https://github.com/opensearch-project/security-analytics/pull/867
https://github.com/opensearch-project/security-analytics/pull/788
https://github.com/opensearch-project/security-analytics/pull/695

Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Ci is not passing due to known flaky tests in SA which needs to be fixed

Would be good to get at least 1 iteration of the build to succeed in the CIs for confidence

yeah i ran 1 more iteration, some tests seem to be passing now


Dependabot builds fail because they don't have access to the right secrets

The tests run in GitHub Actions use a Flickr API key which has been added to the secrets in this repo.
Those secrets aren't available to runs triggered by Dependabot, so Dependabot updates will always fail CI but pass when merged into main.
It would be better if either:

Dependabot updates could access the secrets, and run the requests, or
Dependabot updates didn't trigger CI, so they didn't give a red X we had to ignore each time

According to Stack Overflow, the correct way to do this is to add this to the step:
if: ${{ github.actor != 'dependabot[bot]' }}

I've tried pushing a commit to do this (87f35a7) and I'll try rebasing #8 to see if I get the expected behaviour.

I'm going to say partial success:

The initial set of tests passed, because it skipped the step where it actually runs tests.
When I tried to re-run the tests, it failed – apparently secrets aren't available in CI runs on PRs from third-party contributors, even if they were triggered by somebody who does have access to the secrets.

I think this is good enough – I just want to avoid being in the position where I'm routinely merging PRs that have a failing check.


refactor: rename public state serialisation interface structs for clarity

Description
I found some naming confusing, so have renamed things.
These structs relate to Noir not yet having traits, so we need to create serialisation / deserialisation (serde) methods for any type which you wish to store as a public state.
Edit: I did a git mv to rename some files, but it doesn't seem to have tracked that correctly, so unfortunately there's a deletion of a file and then a creation of a file. Sorry about that.
Checklist:

[x] I have reviewed my diff in github, line by line.
[x] Every change is related to the PR description.
[x] I have linked this pull request to the issue(s) that it resolves.
[x] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[x] The branch has been merged or rebased against the head of its merge target.
[x] I'm happy for the PR to be merged at the reviewer's next convenience.

Just a note that I strongly associate serde with https://serde.rs/ and not the concept of serialization

Just a note that I strongly associate serde with https://serde.rs/ and not the concept of serialization

I wanted something shorter than 'serialisation'. I can rename though, if you think it's unclear.

Actually, serde appears loads in our codebase already, to mean "serialisation and deserialisation"

It appears loads maybe, but that's because we are now using the serde library

no serde

serde lib integration we recently added
I do think it's confusing

"Edit: I did a git mv to rename some files, but it doesn't seem to have tracked that correctly, so unfortunately there's a deletion of a file and then a creation of a file. Sorry about that."
Probably tricky when renaming and changing contents at the same time. You need to commit a rename first I think but then it'll get squashed anyway so all well

I've updated the naming :)


ng e2e does not use --proxy-config for webdriver-manager update

Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request

Versions.

@angular/cli: 1.0.0
node: 6.10.1
os: win32 x64
@angular/common: 4.1.2
@angular/compiler: 4.1.2
@angular/core: 4.1.2
@angular/forms: 4.1.2
@angular/http: 4.1.2
@angular/platform-browser: 4.1.2
@angular/platform-browser-dynamic: 4.1.2
@angular/router: 4.1.2
@angular/cli: 1.0.0
@angular/compiler-cli: 4.1.2
Repro steps.

Must have an out of date web driver or delete it from node_modules/protractor/node_modules/webdriver-manager/selenium/. For example, if using Chrome webdriver, delete all chrome* files in this selenium folder.
Must be behind a proxy, but without HTTPS_PROXY or https_proxy environment variables set.
Using the proxy guide described in the cli wiki, create a proxy.conf.js file to pass to ng e2e.
Run ng e2e --proxy-config proxy.conf.js.

If you are behind a proxy and https_proxy is not set, the command will fail after compiling the app. This is because by default, ng e2e will run webdriver-manager update to fetch the right browser drivers, but does not use the proxy config to do so.
The log given by the failure.

$ ng e2e --proxy-config proxy.conf.js
** NG Live Development Server is running on http://localhost:49152 **
Hash: 95e0fe13c75ed4802b8b
Time: 17998ms
chunk    {0} 0.chunk.js, 0.chunk.js.map 491 kB {3} [rendered]
chunk    {1} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 237 kB {5} [initial] [rendered]
chunk    {2} styles.bundle.js, styles.bundle.js.map (styles) 226 kB {5} [initial] [rendered]
chunk    {3} main.bundle.js, main.bundle.js.map (main) 8.25 kB {4} [initial] [rendered]
chunk    {4} vendor.bundle.js, vendor.bundle.js.map (vendor) 3.12 MB [initial] [rendered]
chunk    {5} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]
webpack: Compiled successfully.
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: connect ECONNREFUSED <IP_ADDRESS>:443
    at Object.exports._errnoException (util.js:1018:11)
    at exports._exceptionWithHostPort (util.js:1041:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1090:14)

Desired functionality.

ng e2e should pass along proxy configuration to webdriver-manager when the --webdriver-update flag is set to true. For webdriver-manager, the flag to use is --proxy.
Mention any other details that might be useful.

The code that calls webdriver-manager is at Line 65 in e2e.ts.

We don't actually have the functionality you are requesting, so this isn't a bug request as much as a feature request.
--proxy-config is a flag inherited by ng e2e from ng serve and meant to be used by webpack-dev-server (https://github.com/angular/angular-cli/wiki/stories-proxy).

Any updates ?

Hello, any updates with it?

any update?

I have no update on this but would like to mention you can do the update manually with the flags you need to use and then run ng e2e --webdriver-update=false to prevent ng e2e from trying to update webdriver.

still the same :(

Any updates.. facing same issue.. even added below
"pree2e": "webdriver-manager update --proxy 'http://****:8080/'",
"e2e": "ng e2e"

I belive that there are 2 different issues discussed here..
What the issue creator is requesting is to reuse the --proxy-config (eg. all requests to "/api/***" is proxied to localhost:8080)
this has nothing to do with "pree2e":"webdriver-manager update --proxy 'http://********:8080/' --ignore_ssl",
Right?

How are you running your e2e-tests if having a api behind a reverse-proxy if
ng e2e --proxy-config proxy.conf.json
is not working?

Hi, I am trying to run e2e tests with an API behind a reverse-proxy. The API is accessible fine when I run ng serve --proxy-config proxy.conf.json. But ng e2e --proxy-config proxy.conf.json complains as follows:
Unknown option: '--proxyConfig'

any update? Thanks

ng e2e --proxy-config proxy.conf.json worked this ng version 1.7. Not sure what broke in the latest build.

Any updates on this?

I tried a workaround, by proxying my dev server API through ng serve and then setting protractor proxy configuration to that server instance. In other words, I use a custom built server that mimics my API, and I start it on my localhost with:
$ ./server
Sever launched on localhost:9000

Then, I start ng server on port 7000 and proxy my dummy API with --proxy-config switch:
ng serve --proxy-config proxy.conf.json --port 7000

where proxy.conf.json has a standard configuration:
{
  "/api/*": {
    "target": "http://localhost:9000",
    "secure": false
  }
}

And finally, I set the protractor.conf.js capabilities as:
  capabilities: {
    proxy: {
      proxyType: 'manual',
      httpProxy: 'localhost:7000'
    }

Finally, I use ng e2e and all of my tests pass. However, being a proxy through proxy setup, I'm not sure if the successful attempts are just a placebo, or this workaround is really working. Here is the visualization:

It seems like ng e2e takes now the proxy configuration from ng serve. If you add following line in the angular.json file and run ng e2e without any options it will execute with the proxy configurations.
       "serve": {
            "builder": "@angular-devkit/build-angular:dev-server",
            "options": {
                "browserTarget": "lmsbo-bo:build",
                "proxyConfig": "config/proxy/proxy.tst5.json" <== **added this** line
            },
            "configurations": {
                "production": {
                    "browserTarget": "lmsbo-bo:build:production"
                }
            }
        },

But this is a step backwards. If you have multiple environments and therefore multiple proxy configurations you have to change everytime your angular.json file accordingly before running ng e2e.

This might be a duplicate with this Issue:
ng e2e does not use --proxy-config for webdriver-manager update #6358

Also behind a proxy, I used @jainsachin121's solution. Howerver I add the --webdriverUpdate flag otherwise ng will try to update the driver again by default, causing a
// package.json
{
  scripts: {
    "pree2e": "webdriver-manager update --proxy 'http://********:8080/' --ignore_ssl",
    "e2e": "ng e2e --webdriverUpdate false" // <-- added flag
  }
}

Timeout error (~60 second delay)
E/downloader - Connection timeout downloading: https://chromedriver.storage.googleapis.com/2.46/chromedriver_mac64.zip. Default timeout is 4 minutes.
I/update - chromedriver: file exists /Users/some-user/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.46.zip
I/update - chromedriver: unzipping chromedriver_2.46.zip
I/update - chromedriver: setting permissions to 0755 for /Users/some-user/node_modules/protractor/node_modules/webdriver-manager/selenium/chromedriver_2.46
I/update - chromedriver: chromedriver_2.46 up to date
E/downloader - Connection timeout downloading: https://chromedriver.storage.googleapis.com/2.46/chromedriver_mac64.zip. Default timeout is 4 minutes.
I/launcher - Running 1 instances of WebDriver

I'm facing this issue as well. I'm currently behind a corporate network. I was able to run the following commands.
webdriver-manager update --proxy=http://xxx.xxx.xxx:8080
webdriver-manager start --proxy=http://xxx.xxx.xxx:8080
The binaries got downloaded and the selenium server started on 4444.
But now when i'm trying to run the test cases getting TIMEOUT error
C:\Users\xxx\Workspace\Angular\angular-with-cucumber>npm run e2e

<EMAIL_ADDRESS>e2e C:\Users\xxx\Workspace\Angular\angular-with-cucumber
ng e2e

[16:02:15] I/config_source - curl -oC:\Users\xxx\Workspace\Angular\angular-with-cucumber\node_modules\protractor\node_modules\webdriver-manager\selenium\chrome-response.xml https://chromedriver.storage.googleapis.com/
events.js:288
throw er; // Unhandled 'error' event
^
Error: connect ETIMEDOUT <IP_ADDRESS>:443
at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1137:16)
Emitted 'error' event on Request instance at:
at Request.onRequestError (C:\Users\xxx\Workspace\Angular\angular-with-cucumber\node_modules\request\request.js:877:8)
at ClientRequest.emit (events.js:323:22)
at TLSSocket.socketErrorListener (_http_client.js:426:9)
at TLSSocket.emit (events.js:311:20)
at emitErrorNT (internal/streams/destroy.js:92:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
at processTicksAndRejections (internal/process/task_queues.js:84:21) {
errno: 'ETIMEDOUT',
code: 'ETIMEDOUT',
syscall: 'connect',
address: '<IP_ADDRESS>',
port: 443
}

@SidV7 I faced the same issue after the manual webdriver update. You have to run the e2e without updating the webdriver again. This worked for me:

ng e2e --webdriver-update=false

Closing since the protractor builder will be deprecated in 12.1.


Side panel: Prevent slideIn prop in storybook controls

What will this achieve?
Currently you are able to toggle the slideIn prop in storybook for the side panel component. This causes things to break because pageContentSelector is required for the slideIn side panel.
How will success be measured?
When there is no longer a toggle for slideIn prop within storybook, there will simply be a separate story to view the slideIn version of the side panel.

https://github.com/carbon-design-system/ibm-cloud-cognitive/pull/400


[irods/irods#6251,irods/irods#6256] find_package for fmt and spdlog

In service of irods/irods#6251
In service of irods/irods#6256
Once this is merged, a 4-3-stable branch should be created.

#'d

Created 4-3-stable branch based on https://github.com/irods/irods_client_http_api/commit/78ef3880d27ad4dc038897c8a0bd6a9416d8f5a6.
We may need to create a branch for development against 4.3.1's build system (thinking about the open PRs and possible other development work going on). Thoughts?

@alanking I'm assuming that's because the externals are changing?
@SwooshyCueb Do these changes depend on new externals packages? Are those new externals packages incompatible with 4.3.1?

Do these changes depend on new externals packages?

Not these. The changes in #256 and #257 do though.

Are those new externals packages incompatible with 4.3.1?

Yes. All externals explicitly built against libc++ have moved into different subfolders, clang and clang-runtime have updated, and spdlog now has a shared library.

Right, just depends on whether we are okay with releasing while building against unreleased dev and/or runtime packages (if I'm understanding everything correctly). This is pre-1.0, so... maybe okay?

Y'know what, it doesn't really matter. I think I got confused and assumed the fmt find module was something we made. Carry on.

I just confirmed tip of main for this repo no longer compiles with 4.3.1 packages and that's fine.
We can create a new branch for 4.3.1 development when that time comes. The SHA to branch from is 0720f71e66383db52782f3aca1565f9bcfd269d2 (according to @SwooshyCueb).

Thinking about it more, let's go ahead and create a branch for 4.3.1 development.
@MartinFlores751's OIDC work will need to be available for 4.3.1 once it's complete.


Native Installation

As a macOS in an Enterprise, I'm unable to use brew so would like the ability to easily download source or a native package.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d09ed623-c83f-6bae-639e-a5f9a31fe3bb
Version Independent ID: c5d0d722-aacd-47a3-3fcf-982c02c4d0e9
Content: Install the Azure CLI for macOS
Content Source: docs-ref-conceptual/install-azure-cli-macos.md
Product: azure
GitHub Login: @sptramer
Microsoft Alias: sttramer

It's also possible to follow the manual installation instructions on macOS.


Option to allow insecure connection

This gives an ability to skip all the funny games with certificates.
As soon as you don't care much somebody wants to steal your sensors )

@cail, thanks for the PR. I always wanted to have this capability in the lib. The issue is that ESP32 WifiSecureClient has different API and misses setInsecure. But as ESP32 doesn't verify certificates at all, we can have it as it is.

fixed, thanks for comments.


ci: pin python modules used in integration tests

The builds broke when they picked up a new version of the Wekrzeug
module. In particular the changes around DispatcherMiddleware listed
here:
https://werkzeug.palletsprojects.com/en/master/changes/#version-0-15-0
I updated the testbench to use the new version, and then pinned the
builds to use that version, which should keep us from breaking in a
similar way.

This change is

I used the additional tracing that @devbww added in #3376 and was able to fix the build problem. PTAL.


Unlockable Conditions in Singular Form

It needs to provide unlockable conditions in singular form for English. This could be also helpful to French, Spanish, Dutch, German, Russian and other European languages that take grammar important. Therefore Japanese, Chinese and Korean only moved a few as East Asian Languages.
It is very important to provide singular form, even if the users can comprehend before this. My software testing textbook couldn’t ignore emphasizing this in L12N module as well. Some might not tend to be used, like UNLOCK_CONDITION_EARN_SINGULAR, but it does not mean there is no one may use this.
In Russian, singular omits the quantity in default as it does not have articles like a/an and the (or le/la/l’, les, un(e) and des in French). There is no intention to solve casing problems in this PR.
Please @Morphclue provide your text after this PR is merged.

Hello, thank you for your contribution!
Can you version the en.json file and all the lang files that are updated (with the translated strings, excluding those having an english placeholder) to "<IP_ADDRESS>"?

This is not yet optimal because the grammatical number system varies by languages, so for the general case, each translated key can have ~10 entries if not simplified per language. However, this PR need not to be optimal as we can still work on it further in future PRs.
It's not true that European languages (specifically Indo-European language family as those mentioned) take grammar more important than certain east Asian languages (where Japanese, Chinese, and Korean are of 3 completely different language families but interact after born), but the fact that they are inflectional languages so that grammatical marks are embedded within words as reduced forms, instead of being their own words like analytical languages (where word order carries more grammar roles than inflection languages).
https://en.wikipedia.org/wiki/Grammatical_number

This is not yet optimal because the grammatical number system varies by languages, so for the general case, each translated key can have ~10 entries if not simplified per language. However, this PR need not to be optimal as we can still work on it further in future PRs. It's not true that European languages (specifically Indo-European language family as those mentioned) take grammar more important than certain east Asian languages (where Japanese, Chinese, and Korean are of 3 completely different language families but interact after born), but the fact that they are inflectional languages so that grammatical marks are embedded within words as reduced forms, instead of being their own words like analytical languages (where word order carries more grammar roles than inflection languages). https://en.wikipedia.org/wiki/Grammatical_number

Magnificent. I shall take time and calm to make further investigation.

I noticed issues within the code on DBUnlockables.cs:

this.RequiredArgCount is not the required count of a challenge value but the count of required arguments within the Values array as json object validation, which means it will always trigger for coins (for example) and never for regular conditions
There are lots of conditional blocks for each conditions (ex. if (this.Values[0] == 1)) that makes the code not only considerably denser but also harder and more time consuming in terms of modularity, the singular handling should have its own generic function (within CLangManager.LangInstance?) appending "_SINGULAR" to the lang string when a given argument is set to 1

I noticed issues within the code on DBUnlockables.cs:

this.RequiredArgCount is not the required count of a challenge value but the count of required arguments within the Values array as json object validation, which means it will always trigger for coins (for example) and never for regular conditions
There are lots of conditional blocks for each conditions (ex. if (this.Values[0] == 1)) that makes the code not only considerably denser but also harder and more time consuming in terms of modularity, the singular handling should have its own generic function (within CLangManager.LangInstance?) appending "_SINGULAR" to the lang string when a given argument is set to 1

Revising...

I noticed issues within the code on DBUnlockables.cs:

this.RequiredArgCount is not the required count of a challenge value but the count of required arguments within the Values array as json object validation, which means it will always trigger for coins (for example) and never for regular conditions
There are lots of conditional blocks for each conditions (ex. if (this.Values[0] == 1)) that makes the code not only considerably denser but also harder and more time consuming in terms of modularity, the singular handling should have its own generic function (within CLangManager.LangInstance?) appending "_SINGULAR" to the lang string when a given argument is set to 1

Revising...

I will set only the first parameter will be judged either singular or plural, therefore some orders of parameters shall be swapped.

Key UNLOCK_CONDITION_PLAY_TWICE has no intention to move for now and this key must have value. Others end with _SINGULAR are optional.

Close as there hasn’t been any movement for a long time and might make barriers against other people in a short period. Achievements related to this PR will be kept to make convenience for others. I will make limited experiments since then to find out more effective methods and structures that make the program better.


First printing of stack frame differs between mine and example.

Awesome blog posts, BTW. Learning a lot.
the example that I am referring to is this image found towards the bottom of this post
The output that I get is the image below

Notice how mine doesn't new-line?
It looks like the same happens for both serial_println! and println! when i print the stack frame.
I ran the serial_println! to a txt file:
s_frame.txt
Here is a link to a commit that exhibits the behaviour.

The difference is that I'm using pretty-printed debug output with {:#?} instead of normal debug output with {:?}. See the fmt::Debug docs for more info.

Thank you so much.
In such an unfamiliar environment, the simple things escape me. I'm still pretty naive when it comes to this sort of work.


Crash on Mac

2017-11-25 16:46:35.440 Python[12807:678928] -[NSApplication _setup:]: unrecognized selector sent to instance 0x7fd5ee997b00
2017-11-25 16:46:35.441 Python[12807:678928] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSApplication _setup:]: unrecognized selector sent to instance 0x7fd5ee997b00'
*** First throw call stack:
(
0   CoreFoundation                      0x00007fff38e952fb __exceptionPreprocess + 171
1   libobjc.A.dylib                     0x00007fff5f806c76 objc_exception_throw + 48
2   CoreFoundation                      0x00007fff38f2dda4 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132
3   CoreFoundation                      0x00007fff38e0b670 forwarding + 1456
4   CoreFoundation                      0x00007fff38e0b038 _CF_forwarding_prep_0 + 120
5   Tk                                  0x00007fff452bb328 TkpInit + 467
6   Tk                                  0x00007fff4523a262 Tk_Init + 1710
7   _tkinter.cpython-36m-darwin.so      0x0000000102f07de9 Tcl_AppInit + 84
8   _tkinter.cpython-36m-darwin.so      0x0000000102f0344a _tkinter_create + 1047
9   Python                              0x000000010247a5bd _PyCFunction_FastCallDict + 166
10  Python                              0x00000001024e1de0 call_function + 511
11  Python                              0x00000001024da763 _PyEval_EvalFrameDefault + 4950
12  Python                              0x00000001024e2586 _PyEval_EvalCodeWithName + 1786
13  Python                              0x00000001024e2e9c _PyFunction_FastCallDict + 449
14  Python                              0x00000001024410d3 _PyObject_FastCallDict + 214
15  Python                              0x00000001024411f7 _PyObject_Call_Prepend + 156
16  Python                              0x0000000102440f40 PyObject_Call + 102
17  Python                              0x000000010248e153 slot_tp_init + 61
18  Python                              0x000000010248aef9 type_call + 184
19  Python                              0x0000000102441097 _PyObject_FastCallDict + 154
20  Python                              0x00000001024e1da9 call_function + 456
21  Python                              0x00000001024da763 _PyEval_EvalFrameDefault + 4950
22  Python                              0x00000001024e2586 _PyEval_EvalCodeWithName + 1786
23  Python                              0x00000001024d9393 PyEval_EvalCode + 42
24  Python                              0x0000000102502049 run_mod + 54
25  Python                              0x0000000102502353 PyRun_FileExFlags + 160
26  Python                              0x000000010250182f PyRun_SimpleFileExFlags + 285
27  Python                              0x0000000102515dd1 Py_Main + 3505
28  Python                              0x0000000102433e1b Python + 7707
29  libdyld.dylib                       0x00007fff603f5145 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException
fish: ′python3 ./main.py' terminated by signal SIGABRT (Abort)

I am running macOS 10.13.1.
I thought maybe I am missing some module, however I get an error message for the following modules:

threading
subprocess
tkinter

Could not find a version that satisfies the requirement subprocess (from versions: )
No matching distribution found for subprocess

I believe these modules are already pre-installed. Try to run the main.py file. If there's some required module missing, the output will tell you which one you have to install.

These modules should already be pre-installed, so that's probably not the reason. Unfortunately, I have no access to MacOS, so it's rather difficult for me to debug. But I'll try to find a solution

@BSVogler Could you please try it again if it's still crashing?

fixed


[MV-336] Add modal

I thought that the best way to add button to the modal is via child component, since specifying it within the props of the modal requires at least 3 new variables which would make it messy in my opinion.
I'll take care of the other two points, I genuinely thought that the transparent background was working before creating pull request. Will investigate.

Passing button as children is ok, I haven't noticed it 👍

Switched to use the library instead of the default Modal component. AFAIK animations for this component were not specified so I left the default slideIn one, it can be changed easily in the future if needed.

There is no modal exit animation (when modal is dismissed it should slide out).


Does making walls unpassable and not allowing the snake to go 180 really worth it?

If I remove those lines:
https://github.com/donno2048/snake/blob/f5625bbd07cc454c69f4d0d4b2741868a4663b89/snake.asm#L30-L37
The only effect it'll make on the game is that the snake will be able to go 180 degrees and pass through the right and left walls, this will also automatically reduce the size by seventeen bytes, and by making bx redundant may get it even to eighteen less...

Allowing 180° is really problematic as it'd look very weird when the snake get really big and moving through walls is ugly as after you cross a wall you'll move one row down/up

Decided not to do that


Requests for ratcheting demand rates

Demand ratchets: https://sam.nrel.gov/forum/forum-general/1164
Topic on old forum not on Wayback Machine: https://sam.nrel.gov/node/75891
Australia kVA with rolling capacity demand charges: https://sam.nrel.gov/forum/forum-general/1341
From Owen Z 5/11/2021:

Demand Ratchets / Minimum Billing Demands – These are already ubiquitous among commercial and industrial customers, but not currently represented in SAM (although you can sometimes calculate a workaround using the minimum bill function, but not in a super streamlined manner). If I define “Billing Demand” as the amount of kW that are billed (and thus gets multiplied by the demand charge), these are usually not as simple as just the peak 15- or 30-minute demand during the month. Usually, they are specified as something like this:
The Billing Demand shall be the highest of the following:
(a) Actual maximum demand measured during the month
(b) 75% percent of maximum demand over the previous 12 months
(c) 30 kW
This is just an example, but you get the point. Option (b) is referred to as a Demand Ratchet, and it’s a way to make sure that distribution utilities recover their costs! There are some more nuances to this whole area, but this is the general gist.

A discussion of how the lookback_months field was defined:

Currently the URDB provides an array of 12 percentages. See discussion below why this doesn't work.
What we do need is an array of 1/0 values for which months are included in the lookback period, a scaler value for the percent, and a scaler value for the number of lookback months. The 12 month 1/0 array applies for rates that are calculated over the past summer months for example. Other lookback rates are calculated over the past X months. So in most, maybe all cases only the 12 month 1/0 array would apply or the scaler lookback months would apply.
For example, a summer lookback rate from the URDB would look like:
"lookback_months": [0, 0, 0, 0, 0, 1, 1, 1, 0, 0, 0, 0],
"lookback_percent": 50
"lookback_range": 0
And a lookback rate with a constant 9 month lookback range would look like:
"lookback_months": [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
"lookback_percent": 80
"lookback_range": 9
It seems like the current array of 12 percentages will translate to this new framework for the first example, as long as the percentage array contains the same value for each month. For example, this rate has Demand Ratchet Percentages as [0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25, 0.25], which would be:
"lookback_months": [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1],
"lookback_percent": 25
"lookback_range": 0

I can forward the entire thread to folks as desired, since it also has implications for the upgrade to URDB version 8.


make build: zip: not found

I checkout the current develop I start a Docker environment with dev/start_dev_environment.sh and then run make build. Then it fails with:
Saved ./build/vendor/wheels/urllib3-1.25.11-py2.py3-none-any.whl
Successfully downloaded backoff certifi chardet dataclasses httplib2 idna jinja2 markupsafe omegaconf psycopg2-binary pyparsing pyyaml requests typing-extensions urllib3
git rev-parse --short HEAD > build/.commit
# git archive -o source.tar HEAD
git ls-files | tar Tcf - source.tar
tar xf source.tar -C build/ --exclude=.commit
rm source.tar
cd build && rm -rf .github/ .gitignore .pylintrc .travis.yml* Makefile *.in tests/ dev/
cd build && zip -r  -9 ../dist/cf-mendix-buildpack.zip .
/bin/sh: 1: zip: not found
make: *** [Makefile:30: build] Error 127
root@5b6946d9958b:/app#

Hi @basi01 - do you have the zip binary on your path? You can check with which zip.

I didn't have it on my path. What helped me was editing one of the files. Please consider applying this patch:
  --- a/dev/Dockerfile
  +++ b/dev/Dockerfile
  @@ -11,6 +11,6 @@ RUN make install_requirements
   RUN wget -q -O - https://packages.cloudfoundry.org/debian/cli.cloudfoundry.org.key | apt-key add - \
    && echo "deb https://packages.cloudfoundry.org/debian stable main" | tee /etc/apt/sources.list.d/cloudfoundry-cli.list \
    && apt-get update \
  - && apt-get install -y cf-cli docker
  + && apt-get install -y cf-cli docker zip

   RUN cf install-plugin -f cflocal

Thanks, you're welcome to include that commit in your PR.


Change output units to pixels feature

Hi,
Thanks for this awesome plugin!
I prepared an option to output pixel units instead of percentages.
Changes in this PR:

added outputPixelUnits prop to let the user change the units from percentages to pixels,
updated README,
updated and configured eslint,
fixed eslint errors/warnings, this included:
-- reordering some methods inside the React component, the order is proper now, but there is a bug with react/sort-comp plugin, so I had to disable it temporaly. I included a comment in the file,
-- switching from js to jsx extension in entry point file,

My apologies that diff it's not so clear, but I had to make some syntax  changes all over the file to fix linter issues.
How to test:
add outputPixelUnits prop to the component in demo/demo.js file and see the console log output.
Let me know what you think.

This is great thanks! Not sure why you had to switch to a .jsx extension but I don't have a problem with it. One tiny thing that I like to do is call the refs e.g. imageRef and componentRef just so it's a little clearer - other than that looks really good, thanks for the help

Eslint with airbnb config has a separate rule for checking the file extension: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md
I will change the refs in a minute.

Thanks it's merged now, will publish shortly


Accordion: Deep Link: Scroll to open title, offset for sticky headers

What is missing?

When using a Foundation Accordion with data-deep-link, the page should scroll to the top of the data-accordion-item, not the top of the data-tab-content. Further, there should be a means of allowing this to include an offset in order to account for e.g. a sticky header.
What is wrong now?

Currently, when data-deep-link is enabled, the URL fragment points to the id of the data-tab-content. When a user navigates to a URL with that fragment, the browser scrolls to that data-tab-content and opens it. In doing so, however, the title is hidden above the view port. Further, if there's a sticky header, then the content itself will also be hidden under this area.
To help provide context, this is the markup for the Accordion:

    Item 1

      …

Possible Solution

There are currently two attributes—data-deep-link-smudge and data-deep-link-smudge-offset—which provide similar types of control. They scroll to the top of the data-accordion, however, not to the top of the data-tab-content. One could imagine a similar set of attributes for controlling the scroll position of deep links to the top of the data-accordion-item.

Note: It's not entirely clear to me what the utility of data-deep-link-smudge is, as it can result in the open tab not even being visible in cases where the height of the accordion panel is higher than the viewport. Personally, I'd have expected data-deep-link-smudge to operate as I've proposed here, but that doesn't appear to be the design intent.

Your Environment

Foundation version(s) used: 6.6.3
Browser(s) name and version(s): Google Chrome 86.0.4240.198
Device, Operating System and version: Windows 10 Pro 20H2

Checklist

[x] I have read and follow the CONTRIBUTING.md document.
[x] There are no other issues similar to this one*.
[x] The issue title and template are correctly filled.

There was a somewhat similar issue in 2013 related to clicking on the title/label. My request, however, relates to the opening a URL with a data-deep-link fragment.

I'm on 6.4.3 and having this issue as well.


GEODE-6998: Add index test for gii tombstone/values update to tombstone

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@mivanac Here is the dunit test that reproduced the issue and is now fixed thanks to your commit

Thanks

The failing dunit test has since been fixed on develop and was not due to this diff.


Audit for possible Sendable conformances

In future versions of Swift, Sendable conformance will be necessary to allow actors to share around objects that have safely got internal synchronisation. We should audit our types and conform any that need appropriate conformance to Sendable.
Some initial high-level thoughts:

EventLoop and EventLoopGroup should be Sendable, as should our concrete implementations of those types.
Channel should be Sendable, but...
ChannelPipeline is not Sendable.

This is a bit awkward for us: Channel stores a ChannelPipeline in a publicly accessible getter. This getter means that it is possible to use a Sendable type (Channel) in a thread-unsafe way.
In principle it's worthwhile for us to just lie about Channel being Sendable. We should think that over.
Other useful types:

EventLoopPromise and EventLoopFuture are Sendable.
ByteBuffer is Sendable

For reference, good flags to start poking and checking how the compiler complains about things:

A compiler option ( -warn-concurrency ) will be provided to warn about Swift 5 code that will be invalid under the Swift 6 rules. For example, Sendable will be checked but missing Sendable conformances will produce a warning (rather than an error). Developers can use this to prepare for Swift 6, by highlighting the places where fixes will be needed, but without needing to fully adopt Swift 6. The behavior of this flag will evolve as we narrow in on the semantics of Swift 6.
A compiler option ( -enable-actor-data-race-checks ) will be provided to diagnose any runtime data races caused by missed checks in Swift 5. For example, if Swift 5 code executes a non- @Sendable closure concurrently, this flag will detect at runtime that a synchronous actor-isolated function was called on the wrong executor.


add custom exception detail in get_object_or_404

This pull request wants to add optional custom exception detail in get_object_or_404. It can be especially useful when creating API.

Thanks for this patch, however, I don't think that we would like to extend this long standing API. Especially, since you can achieve the same behavior with a small wrapper in your own code, e.g.;
def my_get_object_or_404(klass, *args, **kwargs):
    try:
        get_object_or_404(klass, *args, **kwargs)
    except Http404:
        raise Http404("My fancy custom message .... ")

We don't want to add (and maintain) every possible feature to Django itself.


Instagram icons on features.json not displaying

I'm trying to add social media links with icons on the features.json file. Instagram is not displaying though. I tried other FA5 icons too, but I only see Twitter, FB, and github work. Any ideas?
[   {     "title": "Twitter",     "description": "Follow us on Twitter",     "icon": "icon-twitter",     "link": "https://twitter.com/bikenorthbergen"   },   {     "title": "Instagram",     "description": "Follow us on Instagram",     "icon": "icon-instagram",     "link": "https://www.instagram.com/bikenorthbergen/"   },   {     "title": "Facebook",     "description": "Follow us on Facebook",     "icon": "icon-facebook",     "link": "https://www.facebook.com/Bike-North-Bergen-108227921644201/"   } ]

Sorry, the theme does not include instagram icons by default.
Please consider to use FontAwesome.
To use FontAwesome, change to true fa5 of params.icon.
Now you can use it like "icon": "fab fa-instagram".

Thank you! I must have used the wrong syntax when I tried fa. On the same topic, is there a parameter for using the icons in [menu.footer] or [menu.main]? I tried:
[[menu.footer]]
    icon = "fab fa-twitter"
    url = "https://twitter.com/bikenorthbergen"
    weight = 2

Unfortunately, we have not implemented that feature.
We will add the feature when we have time, so if you want to use it, please wait until then.
You can leave this issue open.

Icons can now be used in the footer as well.
You can display the icon by writing the following (The text will not be displayed when the icon is set.)
[[menu.footer]]
    name = "github"
    pre = "<i class='fab fa-github text-2xl'></i>"
    url = "https://github.com/opera7133/tella"
      weight = 2

This works great. Thank you for the update.
One last comment on footer:
I have a parameter with an email in the name:
  [[menu.footer]]
   name =<EMAIL_ADDRESS>   weight = 1

But it is treated like a link for the current page the user is in, instead of just text.

Maybe there could be an email parameter that treats it like mailto field. Just a thought!

If you need a mailto link, you can specify it in the url parameter.
[[menu.footer]]
    name =<EMAIL_ADDRESS>    url =<EMAIL_ADDRESS>    weight = 1


Events or the LoRaWAN frames tabs empty due to antivirus

When I open the "Events" or the "LoRaWAN frames" tab in the online interface, no data will be shown for the first 4 minutes.
The chrome inspector shows that for the post requests of StreamDeviceEvents and StreamGatewayFrames does not return anything for the first 4 minutes.
According to the console log
DEBUG gRPC{uri=/api.InternalService/StreamGatewayFrames}: chirpstack::api: Started processing request
Sep 26 23:58:12.893  INFO gRPC{uri=/api.InternalService/StreamGatewayFrames}: chirpstack::api: Finished processing request status="200" latency=12.940832ms

these endpoints should have returned something.
I know for sure that data is parsed and received, because I see messages on mqtt. Also the link metrics are updated.
Setup:

latest chirpstack using docker
udp-packet-forwarder as gateway (docker, rakwireless/udp-packet-forwarder:latest)

Thanks for the help

N.B. in the image, "Wachten" means "Wait/Delay"

Are you using a proxy in front of ChirpStack (e.g. NGINX)?

No.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

@brocaar
I'm also facing the same issue. The inspector shows that the post requests of StreamDeviceEvents and StreamGatewayFrames does not return anything and the request shows pending.
Chirpstack running on docker containers on Ubuntu Machine

I think there are two topics:
The StreamDeviceEvents and StreamGatewayFrames do not terminate
This is normal, because these are streaming endpoints. As long as you keep your browser tab open, it keeps the connection to the server open as it needs to receive data :-) You might see in the server logs that the API has returned, I think what you are seeing is that it returned a response on the incoming request, but it doesn't mean the connection was closed.
You expect data, but you do not see any

Your gateway receives data (which you can confirm on the MQTT topics), but you don't see it in the LoRaWAN frames tab of the gateway
You expect an uplink in the LoRaWAN frames tab, but you don't see anything
You  expect an uplink event in the events tab (of the device), but you don't see anything (but you do see events coming in on the MQTT application/...../event/up topic)

Is this the case?

@brocaar
yes, I'm receiving data on the MQTT application/...../event/up topic but don't see anything on the LoRaWAN frames tab or device event tab.

Yes this is the case for me.
As a test I used one of my LoRa devices to send some demo data.
Hereby are the logs of the chirpstack app.
( sudo docker logs chirpstack-docker_chirpstack_1 -f > chirpstack-logs.txt)
chirpstack-logs.txt
Also I give a copy of the communication on mqtt
(sudo docker exec chirpstack-docker_mosquitto_1 mosquitto_sub -t '#' -v > mqtt-logs.txt)
mqtt-logs.txt
During that time no data was received in the web ui. Neither in Firefox nor Chrome.
I noticed that when I restarted chirpstack all the data is flushed to the client.
It sounds like there is some issue with caching.
This is weird as I use the standard installation described in https://www.chirpstack.io/docs/getting-started/docker.html

When I use the chirpstack-docker example, and go to the LoRaWAN frames tab of the gateway, I see the data in realtime without any significant delay....
How does your Docker setup look like and what is your host OS?

I use docker on a Rock Pi 4 (Raspberry Pi clone).
I also tested the issue on a Raspberry Pi B+, using the chirpstack-gateway-os-full image.
In both cases I don't see any data.
As consentrator I use https://uk.pi-supply.com/products/nebra-sx1301-lora-concentrator, which is a similar layout as https://uk.pi-supply.com/products/iot-lora-gateway-hat-for-raspberry-pi.
Do you have a (node-js) script which simulates a gateway so we can test if the issue in this.
I have this issue in chrome, firefox and Safari. (Using a Macbook pro)

Found the source: It doesn't work on Mac, but it works on Android and Windows.

Found the issue. It turns out that grpc streams are not yet capatible with web.
See for example footnote 20 in https://grpc.io/blog/state-of-grpc-web/
This issue is explained in https://github.com/grpc/grpc-web/issues/344:

The problem there is the binary format - currently the XHR API does not return back partial chunked response if the response body is binary. Hence the current default mode for gRPC-Web is grpcwebtext (or basically application/grpc-web-text). This is somewhat covered in this old issue https://github.com/grpc/grpc-web/issues/87.

I suggest in order to mitigate this issue, change from grpc-web to grpc-web-text

Found the real culprit: Sophos antivirus/firewall.
Issue is described in https://github.com/grpc/grpc-web/issues/1245

Found the real culprit: Sophos antivirus/firewall. Issue is described in grpc/grpc-web#1245

Hi @wasalm
can you please let me know what configuration done at sophos/antivirus or firewall
i'm facing same issue with sophos

I went to cloud.sophos.com and disabled web protection

Op 29 mrt 2024, om 12:52 heeft SAGAR PATEL @.***> het volgende geschreven:
Found the real culprit: Sophos antivirus/firewall. Issue is described in grpc/grpc-web#1245 https://github.com/grpc/grpc-web/issues/1245
Hi @wasalm https://github.com/wasalm
can you please let me know what configuration done at sophos/antivirus or firewall
i'm facing same issue with sophos
—
Reply to this email directly, view it on GitHub https://github.com/chirpstack/chirpstack/issues/44#issuecomment-2027147978, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEHSHOETEKVO6G7V2JDRSDY2VIXLAVCNFSM6AAAAAAQWI5Z6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGE2DOOJXHA.
You are receiving this because you were mentioned.


NameErrors when running RMINDO3 for Mac OS pyscf 2.0.1

Steps to reproduce
>>> import pyscf
>>> mol_h2o = pyscf.gto.M(atom = 'O 0 0 0; H 0 1 0; H 0 0 1', basis = 'ccpvdz')
>>> from pyscf.semiempirical import mindo3
>>> solver = mindo3.RMINDO3(mol_h2o)
>>> solver.run()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/jamesbrown/Documents/Coding/environments/pyscftest/lib/python3.9/site-packages/pyscf/lib/misc.py", line 512, in run
    self.kernel(*args)
  File "/Users/jamesbrown/Documents/Coding/environments/pyscftest/lib/python3.9/site-packages/pyscf/lib/misc.py", line 631, in aliased_fn
    return getattr(self, fname)(*args, **kwargs)
  File "/Users/jamesbrown/Documents/Coding/environments/pyscftest/lib/python3.9/site-packages/pyscf/scf/hf.py", line 1642, in scf
    self.dump_flags()
  File "/Users/jamesbrown/Documents/Coding/environments/pyscftest/lib/python3.9/site-packages/pyscf/semiempirical/mindo3.py", line 173, in dump_flags
    log = logger.new_logger(mol, verbose)
NameError: name 'mol' is not defined

If you change mol in line 173 to self.mol or self._mindo_mol. I don't know which is correct, then it fails again at line 181
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/jamesbrown/Documents/Coding/environments/pyscftest/lib/python3.9/site-packages/pyscf/lib/misc.py", line 512, in run
    self.kernel(*args)
  File "/Users/jamesbrown/Documents/Coding/environments/pyscftest/lib/python3.9/site-packages/pyscf/lib/misc.py", line 631, in aliased_fn
    return getattr(self, fname)(*args, **kwargs)
  File "/Users/jamesbrown/Documents/Coding/environments/pyscftest/lib/python3.9/site-packages/pyscf/scf/hf.py", line 1642, in scf
    self.dump_flags()
  File "/Users/jamesbrown/Documents/Coding/environments/pyscftest/lib/python3.9/site-packages/pyscf/semiempirical/mindo3.py", line 181, in dump_flags
    return hf.RHF.dump_flags(self, log)
NameError: name 'hf' is not defined

Changing line 181
return hf.RHF.dump_flags(self, log) to return scf.hf.RHF.dump_flags(self, log) allows the calculation to finish.
converged SCF energy = -12.5424908345999
Heat of formation = -48.8262064549162 kcal/mol, -0.07780798779448 Eh
<pyscf.semiempirical.mindo3.RMINDO3 object at 0x10f6ffc40>

Fixed in 37044a022296d860c4feffb0415789fc8a66b660


Fix/resturant/handle mappers

Could you please separate the gateways into two packages, one for local and one for remote use? Thank you.
client_restaurant/shared/src/commonMain/kotlin/data/gateway/
like:
client_restaurant/shared/src/commonMain/kotlin/data/gateway/local/FakeLocalGateway.kt
client_restaurant/shared/src/commonMain/kotlin/data/gateway/remote/FakeRemoteGateway.kt


Files cannot be opened using the File > Open File dialog unless a start file is specified

The File > Open File dialog gives an (unspecified) error on attempting to open files unless picoview has been called with a start file as a command-line argument, i.e.
picoview startfile.png

this is true also if a directory is given as the argument.

This issue was caused by an error in the calling of open_dir(fs::path, size_t, bool) in open(fs::path), it was being called like
open_dir(path, false);

Clearly an artifact from the old overload of open_dir(fs::path, bool). The fix is simple: pass an index for the second argument:
open_dir(path, 0, false);

and the issue is resolved.


Release Wasmtime 21.0.0 (for real this time)

This commit is a re-landing of the automated PR created in https://github.com/bytecodealliance/wasmtime/pull/8655. I cancelled the CI after that PR merged to halt the release at the time, so Wasmtime 21.0.0 doesn't exist anywhere yet. This PR is a manual intervention now that https://github.com/bytecodealliance/wasmtime/issues/8659 is fixed on both main and the release branch.
This PR needs to have a non-empty change so I added a brief note to the release notes for a backported PR, which I'll forward-port to main as well after this.
The automated release process will be triggered by the string in the commit for this PR, and it'll be as-if the previous release PR never merged and this is the actual auto-release PR.

Works with cg_clif locally on linux (arm64 and x86_64) now. Waiting for it to be published to crates.io before pushing the cg_clif update.


"Container Engine Admin" role renamed in gcloud

README needs update on IAM roles. Container Engine Admin is changed to Kubernetes Engine Admin.
https://cloud.google.com/kubernetes-engine/docs/how-to/iam#predefined
PR : https://github.com/estafette/estafette-gke-node-pool-shifter/pull/9

Fixed by https://github.com/estafette/estafette-gke-node-pool-shifter/pull/9


MySQL supports boolean type

Without this, direct mapping does not work for MySQL boolean fields (before GLORP MySQLPlatform was generating a smallint(6) for boolean)

hmmm ... there's some side effects I need to fix before.

Thanks!
I'm missing having CI jobs however..


ImportError: cannot import name 'PathLike'

I am installed conga in 29. Oct 2022 following conga readme.md.
conda create -n conga_new_env ipython python=3.6
conda activate conga_new_env   # or: "source activate conga_new_env" depending on your conda setup
conda install seaborn scikit-learn statsmodels numba pytables
conda install -c conda-forge python-igraph leidenalg louvain notebook
conda install -c intel tbb # optional
pip install scanpy
pip install fastcluster # optional
conda install pyyaml #optional for using yaml-formatted configuration files for scripts
I activated the conga_new_env, and run code from "Seurat_to_Conga.ipynb". It report an errer :
"Seurat_to_Conga.ipynb"
when i run the first line
"import scanpy as sc"
My python version info is:
Python 3.6.15 | packaged by conda-forge | (default, Dec  3 2021, 18:49:41)
IPython 7.16.1 -- An enhanced Interactive Python.
Mybe the python version is too old?
Thanks.

PathLike was implemented in 3.6 so I'm not sure if that's the issue. https://docs.python.org/3/library/os.html#os.PathLike
Nonetheless, you can certainly try moving up in version and see if that helps. I use 3.8 currently, myself.


Fix buffer length calculation in ServerAdvertisement

The toBuffer method in ServerAdvertisement currently assumes that the byte length of the advertisement string when written to the buffer will be the same as the length of the corresponding JavaScript string.
Since JS internally uses utf-16 strings, characters that are larger than one byte can result in multibyte sequences when converted to utf-8 by the buffer.write method. This can result in the last bytes of the string being cut off as they no longer fit into the allocated buffer.
To resolve this, Buffer.byteLength can be used to determine the utf-8 byte length of the string before allocating the buffer.

Thanks !


Use case: Consensus engine developers

This is a general tracking issue for efforts towards to refactor Comet so as to be more amenable to being used by consensus engine developers.
At present, many such developers have to fork Comet to accomplish their aims.

[ ] Ideal Go API boundaries for consensus engine developers
[ ] #342

Originally tendermint/tendermint#9878

Closing to simplify tracking of major priorities. See instead:

https://github.com/cometbft/cometbft/issues/42 and
https://github.com/cometbft/cometbft/labels/P%3Aconsensus-engine-devs


[BOT PR] to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: istio-testing
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
42df2f719b258862c575034c95d907d120c9ea82
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
42df2f719b258862c575034c95d907d120c9ea82
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
42df2f719b258862c575034c95d907d120c9ea82
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


(fix): buffer log updates

On extremely large APIs the generator was chocking on a ton of unawaited promises. This PR introduces buffering for sending log update events (we buffer updates in an array and batch sending every 2 seconds).

@rmkonnur this should fix the generator for merge


Update different-id.md

🚀 Deployed on https://66351518240d761dd0e97e57--cozy-fox-0defec.netlify.app


Validate status not properly rejecting

According to the documentation if validateStatus returns false then the promise is rejected. Well thats not the case for me, i'm only seeing the promise being resolved.
    let body = new URLSearchParams();

    body.append('grant_type', 'password');
    body.append('username', username);
    body.append('password', password);

    return axios
      .post('backend://oauth/token', body)
      .then((response) => {

        console.dir(response.config.validateStatus(response.response.status));

        this.writeToLocalStorage({
          ownerId: response.data.owner_id,
          accessToken: response.data.access_token,
          refreshToken: response.data.refresh_token,
          expiresIn: response.data.expires_in
        });

        return this
          .getById(this.oauthToken.ownerId)
          .then((user) => {
            this.currentUser = user;
            return user;
          });
      })
      .catch((error) => {
        if (error.response.status === 400) {
          throw new OAuthError(error.response.data);
        }

        throw new UnexpectedApiError(error.response);
      });

The current hack I have to resolve this issue is the following, and it's the first few lines of the resolved fat arrow function.
        // todo: remove this, when the bug is resolved https://github.com/mzabriskie/axios/issues/412
        if (response instanceof Error) {
          return Promise.reject(response);
        }

What version of axios are you using and are you making requests in node or browser?

0.13.1 in the browser

Thanks for the response. I'll take a look at it.

Could the error be here?
console.dir(response.config.validateStatus(response.response.status));

The status code should be in response.status not response.response.status.
Could you please check?

@rubennorte Please read the issue again :p

@macnibblet What I meant is that your way of "debugging" what validateStatus was returning is not correct, as you weren't passing the right value.
What's really weird in this case is that Axios is resolving with an error instance (according to your fix). Could you add more information about that error? Does it contain a response property? What's its status value?

@rubennorte Actually I found the cause of the issue it was related to an edge-case in a interceptor one of my minions added.

@macnibblet Found this issue when having the same problem as you and ended up with the same solution. An interceptor was causing the problem. Thank you.


Login not working after update to v15.8

I recently updated our pageflow from v15.2 to v15.8. After restarting the app via phusion-passenger the URL of the backend-login (domain.tld/admin/login/) returns a 404.
my config/routes.rb:
require 'resque/server'
require 'resque_scheduler/server'

Rails.application.routes.draw do
  ActiveAdmin.routes(self)
  Pageflow.routes(self)
  devise_for :users, ActiveAdmin::Devise.config

  authenticate :user, lambda { |user| user.admin? } do
    mount Resque::Server.new, at: "/background_jobs"
  end
  mount Pageflow::Chart::Engine, at: '/chart'
  mount Pageflow::ExternalLinks::Engine, at: '/external_links'
end

One thing I noticed: when I move the call of devise_for before Pageflow.routes(self) the login-form reappears, but the error ActionController::InvalidAuthenticityToken in ActiveAdmin::Devise::SessionsController#create is shown after sending the form (a stackoverflow-issue with the error).
Any help would be greatly appreceated.

Yes, you are right. This is sort of a breaking change that went unnoticed in 15.8: Since Pageflow now also supports sub directories in entry permalinks (e.g. /en/my-entry), Pageflow.routes now also has a wild card matcher for non root level routes. This means Pageflow.routes needs to be last in routes.rb.
We should probably adapt the install generator to make it last and also include a comment that points this out.
Regarding the authenticity token error, in this Devise issue people report similar problems while updating Devise with different solutions. Maybe something also helps in your case?


Include a --watchos flag to filter watch OS pods

This is similar to the already supported --ios and --osx flags.

Done!

:clap: :clap:
I guess you can continue with the --tvos flag ;)

Yay :sparkles: :tv:


I'm looking for someone to take this on as lead maintainer

Of course with due credit in the readme, etc. Respond here if you're interested.

@HenrikJoreteg, I am interested.  Is there a roadmap or some ideas about what a 1.0 release would look like?

@HenrikJoreteg  @oscar-g https://canjs.com look into can-stache it has all you got and a whole eco system this can be deprecated and linked to

https://github.com/canjs/can-stache
https://canjs.com/doc/can-stache.html


Spacebar stopped working in the editor

Suddenly my spacebar stopped working in the code editor. Instead, I have to use Shift + Space, which is very unusual. It was working yesterday, today, it doesn't. I did not change any settings. And my spacebar works completely fine in the terminal, or the extension browser for example. My current vscode version is 1.58.

Let's first try to find out what command executes on your machine, with your settings and your keybindings when pressing <Space>. Could you please try the following:

Run the command Developer: Toggle Keyboard Shortcuts Troubleshooting
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.
Press exactly the keybinding you desire.
check what VS Code detects and what command is invoked.

If you are having trouble understanding the output, please feel free to paste here and I can try to help.


Adapt country page style to thematic pages

The style doesn't adapt properly.
Beware of https://github.com/landportal/drupal/commit/f629fda97fd2880a3df7106759c1aa5da0a8ea80
Review the general grid implementation - specially the Country pages.
On the thematic pages:

forms style is off
titles don't have the right font / size / color (why isn't this general to .h1/h2/h3 classes ? / extend bootstrap classes properly!)

Make sure the media an related content style is also ok.

@jcr this is ready, please check on Beta site.


Remove unbalanced quotes in MINIO_OPTS var, clarify how it is used

Please click "Ignore Whitespace" when reviewing, my editor stripped out all the trailing whitespace.
Removes an extra " quote
Try to explain how MINIO_OPTS works, does that sound right?
Add missing : in front of port number

Good improvements, thanks!

@djwfyi can you eyeball real quick?


Any plan to add  multiple consumer functionality on queues ?

Hi ,is any feature planned to release multiple consumer functionality where consumers or listeners could be spawned to listen to the queues ?

It appears that this is duplicate of #27  but what i Was looking for was a listener functionality which removed the need of manually polling the queue. Let me know if that is presently available .


I need help,please.

Could you support intel video card ?
LiveCD `s xorg has some problems.

We obviously support that. Your report lacks any info we can use to debug. So I have to close this.


@craigspaeth => [Venice] QA + text links

Adds twilio sms form to desktop view, shows 'open in app' link for mobile
Fixes link color in video guide
Adds animation to scrolling on info icon click
Caches curation, sub-articles and video guide on fetch

LGTM! Thanks! Feel free to merge when 💚


DHCP Config changes

Building subclasses and such for each container separately was to make it easy to compare the config to Maintain's.  Lets stop doing this nonsense.

finally

Keep legacy option, but make new default


Maybe mention use cases on the download page?

To make this extension more discoverable for potential users, especially those who don't even know about containers, maybe you could add some examples with keywords to its description on AMO, like:

Access multiple Gmail, Outlook, and other email accounts without staying logged in
Test sites with different logins
If you're having issues with adblockers on Youtube, but videos still play fine in private windows, you can watch videos without ads in a temporary container instead
Bypass paywalls on some sites that limit the number of articles you can read anonymously. Note: this only works for some sites

I could add some references that explain a bit more about containers, but i wouldn't want to advertise for "site specific features", like adblocking or paywalls.


merging latest

@sankethka,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/Azure/azure-docs-powershell, working directory: W:\w4pv-s, target branch: live, target branch commit: 6007723d08482571ddd073773d97cd25f3a607f5, source branch: master, source branch commit: .

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Custom Mobs Suport ?

Where else have you looked for answers to this question?
-Youtube
Share your question with as much detail as possible?
-I Use another plugin caller "BloodNight" on my server to generate custom mobs at night, Your Quest plugin support add custom mobs to the missions ? like: "Kill 5 EnderCreepers in BloodNight" The BloodNight Mobs have id like ToxicCreeper in the config
If applicable, which class or method is this in reference to?

https://github.com/PikaMug/Quests/wiki/Casual-‐-Modules#need-support-for-other-plugins


Upgrade to<EMAIL_ADDRESS>

https://github.com/huggingface/datasets/releases/tag/2.21.0
When done, we should refresh some datasets, like https://huggingface.co/datasets/ProGamerGov/synthetic-dataset-1m-dalle3-high-quality-captions/discussions/1#66bcd7e2f1685a3ade2e55f5

Note that we're currently using the unmerged branch https://github.com/huggingface/datasets/compare/datasets-2.19.1-hotfix. Not sure what we should do, @albertvillanova ?

I can take care of this.

The hot fix in the dedicated branch

https://github.com/huggingface/datasets/commit/a5a76a410a5b6407f43479357eba2b1c370bb9c1

was releases in datasets-2.20.0:

https://github.com/huggingface/datasets/commit/2ebd8233ad8142da73bc8b4d380e9a32046d7829

After updating to datasets-2.21.0, we should also review the changes introduced by datasets-2.20.0: https://github.com/huggingface/datasets/releases/tag/2.20.0

Yes, sure, we have to see what has changed between the current version and 2.21.0 and how it affects our code.
About the hot fix: one of the last commits was to revert the change from json to ujson. Is it relevant for us?

Link to the hot fix branch: https://github.com/huggingface/datasets/commits/datasets-2.19.1-hotfix/
The reversion of the change you mentioned is explained here: https://github.com/huggingface/dataset-viewer/pull/2870#pullrequestreview-2087846308

OK, so: in main, we still use json, not ujson, right?

No, we use ujson, as this is also used by pandas.
However, we are assuming the introduced bug because it is a very edge case and should not impact many datasets.
The root bug is still open in pandas: https://github.com/pandas-dev/pandas/issues/58866

Maybe I should try to fix it in the near weekends... :sweat_smile:


Add Spring Boot Docker Compose support

This PR restructures a lot of the guide to use Spring Boot Docker Compose support. They key teachings of the guide remain the same, however a lot of the upfront tasks, such as creating the MySQL database and the application.properties file, are no longer at the beginning of the guide. These tasks are no longer required, which should allow the user to get started with the code faster than before.
There are a few specific items in this PR that I would like a further review on:

The current CI build is broken due to a test failure in the initial folder. This test does not exist at all in the complete folder. I added Testcontainers to the project so that the context loads and these tests pass. The test now exists in the complete and initial folders.
I've added text around Spring Boot Docker Compose support that I largely copied from the Spring Boot reference documentation. As this will likely become common text throughout several guides, an in depth review is appreciated. The common file text is located here.
In the new Building the Application section, I am using the Docker feature for container networks so that all of my containers can communicate with one another. Is this the best practice? I also had to add a third container to test the application, as specified in the new Test the Application in Docker section.
I did not render the instructions on native image for this guide, as I received an error from Hibernate at runtime. If native does not work with no custom hints, I think it is best not to add that complexity. Still, I find it interesting native did not work out of the box so it could be something I am doing wrong.

Hoping that @mp911de and @mhalbritter can take a look.
Addresses issue #60

Hey Bob,
thanks for your work! I've added some comments, but they are only minor things.

Regarding the common file:

Search for a compose.yml and other common compose filenames in your working directory

compose.yml should be in backticks, compose.yml.

Call Docker compose up with the discovered compose.yml

I'd add backticks:
Call docker compose up with the discovered compose.yml

Call Docker compose stop when the application is shutdown

I'd add backticks:
Call docker compose stop when the application is shutdown


Convert certificates/keys between different formats

Thank you for your work on this project!
I'd love to see the following new feature in the CLI:
Ability to convert certificates/keys between PEM to PKCS12 (with password support), and the other way around.

@yakuter we also need to convert pfx to cert.pem and cert.key.
Here is the openssl doc to do that:
Conversion to a combined PEM file
To convert a PFX file to a PEM file that contains both the certificate and private key, the following command needs to be used:
openssl pkcs12 -in filename.pfx -out cert.pem -nodes
Conversion to separate PEM files
We can extract the private key form a PFX to a PEM file with this command:
openssl pkcs12 -in filename.pfx -nocerts -out key.pem
Exporting the certificate only:
openssl pkcs12 -in filename.pfx -clcerts -nokeys -out cert.pem
Removing the password from the extracted private key:
openssl rsa -in key.pem -out server.key


Auto update README when publishing to Docker Hub

Updates README on Docker Hub when publishing a release.
Fixes #33

@grc0 your changes have been merged, thanks for your contribution 👍


Prevent indexing by Google via incoming links

Our robots.txt prevents Google from crawling but does not prevent it from indexing our page when a link to it is found on another site.
To prevent that, we need to instead use the robots meta tag with value noindex (https://developers.google.com/search/docs/crawling-indexing/block-indexing?hl=de).
For this to work, we need to allow Google et al to at least access one page that tells it not to index, or remove robots.txt entirely (see warning in link above).

@timbuktutimbuktu do we still not want to be indexed at all..? I would think we're at a point where we want to be indexed, even directly?

As discussed, not necessary anymore.

Indexing has been allowed for production (except for admin) with #630


[r1.9] Expose tf.broadcast_to op

This fix is a follow up on #19753 to expose tf.broadcast_to op to r1.9.
NOTE: Please note this PR is to r1.9, feel free to close the PR if not appropriate.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

/cc @martinwicke @Hoeze Not sure if this PR should be merged to r1.9 or not. Feel free to close the PR if not.

@av8ramit

This is a new feature. As a policy, we do not accept features into release branches.


Interface with smstools

Not a bug or issue per say. Might just be my own ignorance but how do I interface with SMS tools when running playsms from a container?  Do I need to map a tty port to the container and where do I configure smstools?  Or does smstools not run inside playsms do I somehow need to talk to the smstools binary outside of the playsms docker?

Did you get this resolved?

Yes this was sorted. My lack of docker knowledge at the time.  I do not use playsms anymore but for what its worth this is the last working docker compose file I used.  You basically just need to give your container access to the devices. In this example I had 2 modems that mounted on the docker host as ttyUSBx and then you map them to the docker guest.

services:
  playsms:
    image: v0d0r/playsms:latest
    container_name: playsms
    restart: unless-stopped
    devices:
      - /dev/ttyUSB0:/dev/ttyUSB0
      - /dev/ttyUSB1:/dev/ttyUSB1
    ports:
      - "2222:22"
      - "8181:80"
    volumes:
      - /mnt/nfs/swarm/dockervolumes/playsms/smstools/etc/smsd.conf:/etc/smsd.conf
      - /mnt/nfs/swarm/dockervolumes/playsms/smstools/log:/var/log/smstools
      - /mnt/nfs/swarm/dockervolumes/playsms/gammu/gammu.conf:/etc/gammu-smsdrc
    environment:
      - TZ=Africa/Johannesburg```

Thank you so much for sharing.
What do you now use?

At the time I had a use case to use SMS to automate some things remotely based on incoming sms and content it received.  Since then I don't run that project anymore but if I require the use of SMS again playsms is always my goto for small scale setups with local modems. For something at scale then still playsms but integrated with a provider that can send on scale such as Clickatell or Twilio.

Alright, thanks.


Infer mesh format from file extension

Describe the annoyance
rr.log_mesh_file always requires to specify the mesh format, even when logging a file with extension. It would be more convenient if it defaulted to the file extension when not specified.

Fixed in the new API


Minor language improvement

The file test1.yml has "Retrieve results" inside while everywhere is in English. I am Brazilian by the way. :)

Then my guess about you been Brazilian is now confirmed ;-)
Thanks!


Build fails on Windows with gcc 7

The error occurs for all the ...Async Methods (GetAsync, PostAsync, PutAsync, HeadAsync, ...)
/cpr/cpr.h:4:0,                  from \cpr\test\error_tests.cpp:6: /cpr/include/cpr/api.h: In function 'cpr::AsyncResponse cpr::GetAsync(Ts ...)': cpr/include/cpr/api.h:46:32: error: return type 'using AsyncResponse = class std::future<cpr::Response> {aka class std::future<cpr::Response>}' is incomplete  AsyncResponse GetAsync(Ts... ts) {

Considering that GCC 7 is a preview release, this most likely is a bug in the compiler and not in CPR. You could try to boil it down to a minimal reproducible example and file the bug with the GCC people.

Actually it seems to be an issue with MinGW as the build completes when I use a MinGW with posix threading model. But fails if the threading model is win32. It seems that  is unimplemented without poxis threading.
http://stackoverflow.com/questions/10209871/c11-stdasync-doesnt-work-in-mingw


Reorganize installation guide

I also have no idea why all these commits are here, I've tried rebasing and it's not working. May have to nuke local copy from orbit once I get this change in...

Staged at: http://lcarey0-l.dub.corp.google.com:4000/docs/tasks/installing-istio.html

Can you try again "Update branch"?

Lisa, could you provide a staging link that's not on the corp network so
non-Google folks can access it?
The best way is to push your commit to your fork of the main repo. If you
enable GitHub pages in that fork, then the web site will be rendered there
and folks can access it from outside the corp network.
On Fri, May 19, 2017 at 11:08 AM, Isaiah Snell-Feikema <
<EMAIL_ADDRESS>wrote:

@ijsnellf commented on this pull request.
In _docs/tasks/installing-istio.md
https://github.com/istio/istio.github.io/pull/284#discussion_r117540234:

You can access the Grafana dashboard using port-forwarding, the service nodePort, or External IP (if your deployment

environment provides external load balancers).

The simplest way to access the Grafana dashboard is to configure port-forwarding for the grafana service, as follows:

+The Grafana addon provides an Istio dashboard visualization of the metrics (request rates, success/failure rates) in the cluster. Once you've installed Grafana, check that you can access the dashboard. There are three possibly ways to do this:
typo: "possible"
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio.github.io/pull/284#pullrequestreview-39261546,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVucHSH08pbcba121SHNguF3ZYLz7Q7fks5r7dq5gaJpZM4Ngvxk
.

Sure, it's up and running at https://lisafc.github.io/istio.github.io/docs/

This looks nice. But can we please wait for @frankbu ? He has been
streamlining docs all over.
On Fri, May 19, 2017 at 5:13 PM LisaFC<EMAIL_ADDRESS>wrote:

Sure, it's up and running at
https://lisafc.github.io/istio.github.io/docs/
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio.github.io/pull/284#issuecomment-302812518,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH0qd7MTz0-dKS4z0inQqfun94OJSWWCks5r7gXcgaJpZM4Ngvxk
.

--
~shriram

Has something odd happened with the formatting for code blocks in the master version? My local copy still looks fine but my forked repo (synced more recently to master) looks very odd.

Yes, it's broken. A bug fix to prevent code blocks from interfering with
the TOC has totally broken code blocks. We should have a fix on Monday I
presume. If not, I'll undo the fix since the code block and TOC
interference is a lesser bug than this one...
On Sat, May 20, 2017 at 6:31 AM, LisaFC<EMAIL_ADDRESS>wrote:

Has something odd happened with the formatting for code blocks in the
master version? My local copy still looks fine but my forked repo (synced
more recently to master) looks very odd.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio.github.io/pull/284#issuecomment-302873371,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVucHawcLpRpzu3PlWnvxnpP8dfUc1aQks5r7usbgaJpZM4Ngvxk
.

Anyone else have comments on this?

@LisaFC there seem to be invalid links in the PR or somewhere else.
./_site/docs/concepts/what-is-istio/overview.html

internally linking to /docs/concepts/goals.html, which does not exist (line 1)
Design Goals

./_site/docs/tasks/installing-istio.html

internally linking to ./metrics-logs.md, which does not exist (line 13)
Collecting Metrics and Logs
rake aborted!
HTML-Proofer found 2 failures!

./metrics-logs.md should be ./metrics-logs.html

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed

Jenkins job istio.github.io/presubmit passed


Enable local build caching for CI builds

Before #26351, builds had the local build cache enabled for local development builds as well as CI builds. #26351 inadvertenly disabled the local build cache for CI builds. This re-enables it.
You can see in this Gradle Enterprise graph that the local build cache was disabled for CI builds.
Fixes #26776

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java_PVR_Flink_Batch PreCommit

Run Java_Pulsar_IO_Direct PreCommit