Change specification for autoloading classes

Use PSR-4 for autoloading, PSR-0 is deprecated

Thanks for your contribution, however if you make this change you would also have to namespace all classes and rename them correctly. Currently Raven_Client cannot be autoloaded with PSR-4 (because it's not namespaced and following the correct naming convention) as far as I know.
Yes it's currently deprecated but it still works fine everywhere (not seen any composer warnings about it yet). Also there is a lot of work going on in the 2.0 branch that will address this 👍

Yes, 2.0 is already using PSR-4 correctly, see #414 & #440:
https://github.com/getsentry/sentry-php/blob/2.0/composer.json#L46-L53

Oh Yes , I hadn't seen  branch 2.0 , really sorry for the noise  .

@samnela don't worry 👍 happy you took the time to make the PR in the first place.


Make QC survey more widely available

Currently you only complete the QC survey if you make it all the way to the end of the study, which likely biases our measures of technical problems, clear instructions, and willingness to repeat. Ideally, we'd be able to show this to people who bounce, or have technical issues that prevent them from getting to the end of the experiment.

One way to do this is to add a button on the lobby fallback (when it has shown for more than 5 minutes) that takes them to the exit stages...


RSS feed?

The jekyll docs mention a home grown solution https://jekyllrb.com/tutorials/convert-site-to-jekyll/#10-rss-feed, but also link to: https://github.com/jekyll/jekyll-feed

Looks like one already exists at https://duckdb.org/feed.xml, there's just no link element advertising it

Can you PR the addition of the link tag?


Filter, Search and Sort

In progress..
Sorting on columns
Dynamic field search updated after each table query is done -- in progress
Tested on uframe-test.ooi

@FBRTMaka Is this getting on top of your toes??

@DanielJMaher @FBRTMaka ... the only thing on the asset page that changed is the column Object:
https://github.com/ssontag55/ooi-ui/blob/filter/ooiui/static/js/views/asset_management/AssetView.js#L63
Let me know if it's an issue

@DanielJMaher yeah, that asset page changes are still going to conflict terribly.  The entire file is broken up into 5 small view classes.  So it won't merge at all.

That column object should only be in one view.

It what you have it's in 1 of 1, in what I have it would be in 1 of 5.

@ssontag55 Matt has been reworking the asset page to break each asset item in the table into it's own view.  This allows for us to update a single asset without having to reload everything.
No work can be merged into the AM page until after he is done otherwise we face the wrath of the merge conflict!

@FBRTMaka let me know if you need any help merging the column stuff


Increase resources for e2e tests

Issue Ref: None
Description:
Increase Minikube memory and GKE instance size.
TODOs:

[X] Ready to review
[X] Automated Tests
- [ ] Docs

The travis error is related to #519, merging this


Replica set connection

Hi there,
I'm trying to connect to my replica set within Symfony. I have my config settings as follows as per http://symfony.com/doc/current/bundles/DoctrineMongoDBBundle/config.html#connecting-to-a-pool-of-mongodb-servers-on-1-connection
connections:
        default:
            server: 'mongodb://*.*.*.1:27017,*.*.*.2:27017,*.*.*.3:27017'

However I get the error:
Uncaught PHP Exception MongoException: "Cannot run command count(): not master and slaveOk=false"
If I go with just the primary mongo server IP address, instead of a comma'd list of my servers, I can connect fine.
Has anyone any suggestions?
Regards
Paul Pounder

Apologies, wrong repository


split out detectors and templates, invite contributors

(slack mention: https://netlify.slack.com/archives/CGW2Y6XPH/p1553102448110100)
we dont want to re-release the CLI and netliy dev plugin every time we add a new detector (or template).
we should use https://www.npmjs.com/package/live-plugin-manager or https://www.npmjs.com/package/pacote to make this scale.
however we should also have some consideration for offline dev experience.

Closing in favor of https://github.com/netlify/cli/issues/1495


PHAsset.fetchAssetsInAssetCollection is being called twice

In AlbumCellFactory.cellForIndexPath, PHAsset.fetchAssetsInAssetCollection is being called twice which causes a huge hit on performance. The first call appears to be a mistake because it ignores the results.

You're right, nice catch! :+1:

Pushed out 1.4.3 which removes the duplicate asset fetch, thanks for reporting it! :)


Add SHOW instruction

Closes #21
Implementation

Add SHOW to the instruction set.
Add its implementation, since this is similar to RET at this point, I have added it to the same match arm.

All integration tests and yamtests are passing. Merging this.


Signing seems broken. No pop up UI in MetaMask and AlphaWallet to approve signing

Signing seems broken. No pop up UI in MetaMask and AlphaWallet to approve signing
URL: https://xcontract.herokuapp.com/sign
With MetaMask, this appears in logs:

injected provider used: [object Object]
bundle.js:55137 Here is the account: undefined
bundle.js:55139 message to sign: hello
bundle.js:55379 signing error: TypeError: Cannot read property 'length' of undefined

Privacy Mode for MetaMask is off. Doesn't work for both the current version of MetaMask and the older version before Privacy Mode was introduced.

Works here on AlphaWallet: 0b1671ca6a63e5a67ce09d93df2a480c57aebc35
Latest metamask treats the message like ascii hex and fails to sign it


Target port not found   ADS Server not started (6)

Hi All,
I am trying to control some variables on the PLC through pyads. Unfortunately I keep on receiving always the same error message. 'target port not found   ADS Server not started (6)'. Any ideas on how to get around this issue? Thanks a lot in advance.
`import pyads
plc = pyads.Connection('<IP_ADDRESS>.1.1', 851)
plc.open()
plc.read_device_info()`

Are you on Linux ord Windows?

windows 10

Did you install Twincat on your PC and setup the routes to your target properly?

Yes, The route is setup correctly and the twinCAT is running on my machine correctly. I have uninstalled and installed the whole system but whenever i call the pyads.Connection('AMSNetId', 851) I get the same error message. (target port not found   ADS Server not started (6)). I cannot figure why!?

If I run the TcAdsTest I get this error message (see pic).

This clearly looks like you've got an issue with the setup of your TwinCAT system. Unfortunately I can  not help you with this as it is not related to pyads. Maybe it helps to check if your Beckhoff ADS library is installed correctly on your system.

I got the same problem. Have you solved that?

Solution that worked for me:
In TwinCAT, project explorer, right-click your project name under "PLC" branch, and click Change ADS Port. it should be 851 normally. if it is not, update your Connection initialization accordingly.


schedule meeting now working

Description
There was a small bug making the Schedule Interview section of the webpage crash. The page (scheduleMeeting.js) was referencing a file that was completely commented out. I routed it to what seemed to be the incomplete replacement for the commented out file, and commented out my addition. It is ready to take the new file when it is complete.
I wasn't sure if that component was close to completion, or if it was completed. I can remove where I kept it in the file if needed.
Video Link
[Loom Video]https://www.loom.com/share/2edeb614ca864b8f9f238a87eb9a20f2
Trello Link
Fix: Schedule Interview working as intended
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have removed unnecessary comments/console logs from my code
[X] My changes generate no new warnings
[X] I have checked my code and corrected any misspellings
[X] No duplicate code left within changed files
[X] Size of pull request kept to a minimum
[X] Pull request description clearly describes changes made & motivations for said changes

good job, This is very useful function


Create an diagram to illustrate the relationship between Runnable/RunTemplate/Selected Object

Description of problem
TODO

This was an ask form @waciumawanjohi


Depended module incorrect redirect when use deps option

Failing module
react-dom / graphQL
import Loading from 'https://esm.sh/aftership-sdui-library@1.2.27/es2022/AntdExtends/Loading?bundle&deps=react@18,react-dom@18';

import errorLink from 'https://esm.sh/@apollo/client@3.5.10/link/error?bundle&deps=react@18,react-dom@18'

The module will load this module:
<EMAIL_ADDRESS>Since the service upgrade to V100, failed to load some dependencies when setting the deps option for the module.
The correct URL must includes /v100<EMAIL_ADDRESS>Error message
After onload I got this:
throw new Error("[esm.sh] " + "parseCJSModuleExports: Package path ./X-ZC9yZWFjdEAxOC4yLjA/es2022/react-dom is not exported from package /tmp/esm-build-cc60c8eed435100cff08af96cf604ff44c4d6cee-9189bf32/node_modules/react-dom (see exports field in /tmp/esm-build-cc60c8eed435100cff08af96cf604ff44c4d6cee-9189bf32/node_modules/react-dom/package.json)");
export default null;

Additional info

esm.sh version: v100
Browser version: *

The error is present in other packages, even without any options.
e.g<EMAIL_ADDRESS>

<EMAIL_ADDRESS>
this url is not correct (missing /v100 prefix), where you got it?

import Loading from 'https://esm.sh/aftership-sdui-library@1.2.27/es2022/AntdExtends/Loading?bundle&deps=react@18,react-dom@18';

this you need to remove es2022 part

But es2022 is the server adds, I just only do this on my code:
https://esm.sh/aftership-sdui-library/AntdExtends/Loading?bundle&deps=react@18,react-dom@18'

i see, will look into it. thanks!

Wow, what is this tool? could you share it with me?

Wow, what is this tool? looks so cool, could you share it with me?

by deno info command

i found the bug, will deploy to prod after testing

Hello @ije, The react-dom is back to normal, but graphql still failed

it's cached, i need to release v101 to fix this, please wait

Okay, thanks

<EMAIL_ADDRESS>
this url is not correct (missing /v100 prefix), where you got it?

I have a URL like this<EMAIL_ADDRESS>but inside, you can find incorrect relative import import br<EMAIL_ADDRESS>without /v100 prefix.
Unlike v99<EMAIL_ADDRESS>where we can find relative imports with prefix import __events$ from<EMAIL_ADDRESS>

@PeterBLITZ i believe v101 fixed this issue

@PeterBLITZ i believe v101 fixed this issue

Yup. Thank you)


⚠ Spryr has degraded performance

In eea7176, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3341 ms

Resolved: Spryr performance has improved in e71c169 after 7 minutes.


[Feature Request]: Handle DSPA v2 with MLMD disabled

Feature description
If a DSPA is created with PipelineVersion=v2 but MLMD.Deploy=false, the DSPO will throw an error and not process/deploy the DSPA.
This may be the correct action, but this FR/question will be to formally address this behavior and either accept the current flow, or make the DSPO handle this more aggressively (override/force MLMD deployment, etc)
Describe alternatives you've considered
No response
Anything else?
No response

Migrated to Jira: https://issues.redhat.com/browse/RHOAIENG-1723


SWARM-1098: Incremental Build Support for Wildfly Swarm Gradle Plugin

Motivation
The task 'wildfly-swarm-package' should only be executed, if the UberJar is not created yet,
the depending archive (jar,war) has changed or the 'swarm' extension properties for executing the task have changed.
Otherwise the task should be marked as UP-TO-DATE.
Modifications
Defining the inputs and outputs of the 'wildfly-swarm-package', so Gradle will automatically make an update-to-date check.
Result
The plugin will have the same behaviour on using. But running the tasks twice the second time should the task should be marked as UP-TO-DATE.

[X] Have you followed the guidelines in our Contributing document?
[X] Have you created a JIRA and used it in the commit message?
[X] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[X] Have you built the project locally prior to submission with mvn clean install?

ok to test

ok to test

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test


Picker not vertically centered

Hi! First of all, thanks for your work! I really like this date picker dialog :)! But i have a problem: it isn't vertically centered, and idk why. I've followed your example under "Basic usage" section.

I'm using:
"@expo-google-fonts/roboto": "0.2.0",
"react-native-modal": "13.0.0",
"react": "17.0.2",
"react-dom": "17.0.2",
"react-native": "0.66.3",
"expo": "43.0.4"
If you need more info to help me to fix this issue, i will provide them :)

Hi @feduss, it's happy to hear that you like it😄 and thanks for reporting this issue.
This is really weird🤔 I have not figured out any possible reason yet. But I just realize that one of the dependencies, react-native-modal, had a breaking change in its latest version (v13.0.0) and therefore Expo projects may have some bugs. Could you try upgrading this package to v1.1.3 first and see if this issue still exists?

@roto93 maybe did you mean v11.3? 1.1.3 doesn't exist :)! Btw, even with 11.3 it isn't vertically centered :/

My bad, I mean react-native-neat-date-picker v1.1.3
I just updated my package two hours ago.

ok, i've updated your package to 1.1.3 and downgraded modal from 13.0.0 to 12.1.0, and it's the same :(...i will try with a blank project later

Does this issue appear on both real device and simulator?
Because I can't reproduce this issue, I have no idea how to solve it at the moment. Maybe you can provide the output of expo diagnostics and  the steps to reproduce if it's possible.

Yes, both simulator and a physical smartphone...i'm creating a blank project to see if the bug persists (and, in that case, share the project with you)

@roto93 This is the sample project, let me know when you have time, thanks :)
https://github.com/feduss/DatePickerNotVertCenteredIssue6

Thank you. I can work on this these two days.
I notice that this repo is just a blank expo project. I don't see any page but an expo template page in it.
Maybe you forget to push your commits?

I'm just lazy and i've put your tutorial in App.js
https://github.com/feduss/DatePickerNotVertCenteredIssue6/blob/master/App.js
It's a veeery basic "app" with only your tutorial :'D...because yes, i can reproduce the issue even in this basic project :(

Anyway, I started with your repo and did the following steps

npm install
npm install react-native-neat-date-picker
expo start
replace the code in App.js by Basic Usage from my readme

The app looks normal. The modal is centered vertically.

Here is my fork

Uhm, sorry...there should be a problem with the push :/...btw, i've tried your fork and ... i have understood that the problem is only in the web version of the app, not in the expo one! In the expo app the picker is correctly centered, but not in the browser.
expo:

browser:

Yeah you're right. I tended to developing this date picker on ly for phones and didn't think of the usage for web.
But now I know what causing this issue, thanks for your information.
I will let you know when it is fixed. It should be a quick fix

Hi @feduss I've fixed it. Please update date picker to the latest version and try again.

Hi @feduss sorry for late reply as yesterday, but i think we have different time zone :)!
Your fix worked!!! Nice job, thanks for your patience and help :)! Issue closed!


[SPARK-34270][SS] Combine StateStoreMetrics should not override StateStoreCustomMetric

What changes were proposed in this pull request?

This patch proposes to sum up custom metric values instead of taking arbitrary one when combining StateStoreMetrics.
Why are the changes needed?

For stateful join in structured streaming, we need to combine StateStoreMetrics from both left and right side. Currently we simply take arbitrary one from custom metrics with same name from left and right. By doing this we miss half of metric number.
Does this PR introduce any user-facing change?

Yes, this corrects metrics collected for stateful join.
How was this patch tested?

Unit test.

Test build #134569 has started for PR 31369 at commit d019731.

Test build #134569 has started for PR 31369 at commit d019731.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39157/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39157/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39157/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39157/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39157/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39157/

Test build #134569 has finished for PR 31369 at commit d019731.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134569 has finished for PR 31369 at commit d019731.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134569/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134569/

cc. @tdas @zsxwing @jose-torres @gaborgsomogyi @xuanyuanking to see some chance of more eyes to review.

cc. @tdas @zsxwing @jose-torres @gaborgsomogyi @xuanyuanking to see some chance of more eyes to review.

Test build #134624 has started for PR 31369 at commit 9ac7253.

Test build #134624 has started for PR 31369 at commit 9ac7253.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39212/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39212/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134624/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134624/

LGTM

LGTM

Thank you @dongjoon-hyun

Thank you @dongjoon-hyun

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134664/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134664/

Test build #134661 has started for PR 31369 at commit f950772.

Test build #134661 has started for PR 31369 at commit f950772.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39248/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39248/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39251/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39251/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39251/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39251/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39248/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39248/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39248/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39251/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39251/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39248/

Test build #134661 has finished for PR 31369 at commit f950772.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134661 has finished for PR 31369 at commit f950772.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134661/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134661/

Merged to master/3.1/3.0/2.4.

Merged to master/3.1/3.0/2.4.

Sorry for pinging you again on this issue. I touched this code today and have a question:
@viirya Could you provide which metric missed half of the result in your scenario? It seems that the overridden shouldn't happen in the original codebase for the custom metrics framework. Do you use some special way for adding the custom metrics?
Here's some analysis:
The left/rightSideMetrics passed in combine function are objects with adding new descriptions here:
https://github.com/apache/spark/blob/e3058ba17cb4512537953eb4ded884e24ee93ba2/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala#L316-L321
So the result of combine should contain two metrics object with the same name. They will finally get summed in https://github.com/apache/spark/blob/e3058ba17cb4512537953eb4ded884e24ee93ba2/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala#L403-L405

@xuanyuanking Thanks for continuing looking this.

Here's some analysis:
The left/rightSideMetrics passed in combine function are objects with adding new descriptions here:

Oh, yeah, looks like SymmetricHashJoinStateManager.metrics changes metric description to prevent the metrics to be overridden. However I'd say we still should make StateStoreMetrics.combine solid to prevent possible metric overriding as the added test case shows.

Hopefully, callers in the future could be always aware that StateStoreMetrics is combined by StateStoreCustomMetric rather than StateStoreCustomMetric.name. Otherwise, usages like
combinedMetrics.customMetrics.foreach { case (metric, value) =>
   longMetric(metric.name) = value
                           ^ "=" instead of "+="
}

could result in the wrong metrics again.


Feature - Support Maven Central in the packaging check

Is your feature request related to a problem? Please describe.
Java projects which publish to Maven Central are not included in the packaging scorecards check.
Describe the solution you'd like
We could extract the groupId/artifactId from the pom.xml and then search Maven Central via e.g. https://search.maven.org/artifact/org.apache.santuario/xmlsec and check if the latest release has packaged jars.
Alternatively we could check the README for a badge which redirects to Maven Central, e.g. something like https://maven-badges.herokuapp.com/maven-central/org.apache.santuario/xmlsec
If I got some feedback on this proposal I could work on a PR

Thanks for the report. I think the original goal of the Packaging check was to verify whether users have open-source release pipeline, to help consumers know that the build corresponds to the source code. We test if mvn command is used in https://github.com/ossf/scorecard/blob/main/checks/fileparser/github_workflow.go#L462.
For the project you are using, do you use a workflow to build  publish?
NOTE: the packaging check starts to overlap with SLSA / signed releases, though.

We test if mvn command is used in https://github.com/ossf/scorecard/blob/main/checks/fileparser/github_workflow.go#L462.

E.g. for (my) https://github.com/MariaDB4j/MariaDB4j/ where I've added Scorecard in https://github.com/MariaDB4j/MariaDB4j/issues/661 on https://securityscorecards.dev/viewer/?uri=github.com/MariaDB4j/MariaDB4j it says ? for Packaging and Signed-Releases. The problem seems to be that I still run mvn deploy locally when doing a release, not in a GitHub Action. (As in, I do have GitHub Actions which contain ./mvnd for CI, but then don't deploy.) So scanning for a pom.xml and checking if an artifact is available as suggested above would detect this better than (only) scanning for run in GitHub Workflow Actions .


Fix: only trigger gs_diff_navigate on initialization

Refreshing the page should not execute gs_diff_navigate.

I would argue current behavior can be safer. If the list of items in an interface changes, then the selection may change to another item, the user might not notice this and perform an unintended action.
Regardless of where the selection goes, I would love if we could flash the updated caret location after a refresh. Is this something that can maybe be done with style switch? Actually, I just enabled the "highlight_line": true option in sublime and it's pretty clear where the caret is right now 😊 so this is not such a big issue for me.

That line was introduced not long ago in my #516 which tries to fix a cursor initialization issue.

There is an unwanted bug introduced by #516, when we press w or s to toggle various settings in the view, the cursor moves to the next hunk.

If the list of items changes, the cursor always goes to the next hunk, it is not useful at all.

Also, this is a diff view, users can stage or unstage hunks by GsDiffStageOrResetHunkCommand, which aways fetch the information from the view, but not an internal list of items. Therefore, it should be safe to not running gs_diff_navigate when refreshing

Of the above reasons, I believe that it is correct to only running gs_diff_navigate when initialization.

OK, thank you for clarifying! I didn't notice this was only for the diff command, you are absolutely right about what is expected here. LGMT!

Great.


Specify classifiers instead of using os detection in netty-all

Motivation:
The OS used to build netty-all is irrelevant to the system using netty-all.
The build environment's OS should not impact the dependencies of netty-all. The OS used to build netty-all is irrelevant to the system using netty-all at runtime. So instead of using os-maven-plugin via the jni.classifiers property to set dependency classifiers, set the correct classifiers explicitly.
Modification:
Set classifiers of the dependencies in netty-all.
Result:
Fixes #11272
See #8097

@candrews I think this will not work... as for example on linux you will still enable the linux profile when depending on netty-all and so the native dns resolver for macOS will not be included. Which means when you build on linux but deploy to Mac you will run into issues imho... the same is true for building on macOS but deploy to linux

basically netty-all should "pull in" all native dependencies no matter on which system your run and build (that was how it behaved before)

@normanmaurer I don't follow your reasoning, the changes look right to me. If you are building with linux profile it must mean you are targeting linux for deployment, at least that's what I infer from the comments in the pom:
    <!-- The linux profile will only include the native jar for epol to the all jar.
         If you want to also include the native jar for kqueue use -Puber.
    -->

I agree that in general it would be best to just use the uber profile so that the resulting artifacts can be deployed anywhere and work with the appropriate native libs in each case.

@njhill the problem is that the profiles will be included in the pom that is deployed and so automatically activated based on the system you are pulling the dependency in

@normanmaurer ok I see what you mean. The changes in this PR are still "correct" just orthogonal to the problem you're describing.
Again the way the comments are worded in the pom, it sounds like the profiles are intended to be set/specified based on a target deployment environment, not activated based on the detected build environment. If that's not correct, and the profile is set based on the detected OS at build time, then it's wrong to have this profile separation in the netty-all pom at all and we should just get rid of the OS-specific (non-uber) profiles. This would essentially match the old behaviour more closely too, because the profile never came into the picture when consuming the pre-built uber jar.

It seems to me that all the profiles should be removed.

all native dependencies should be just dependencies and not specified inside of a profile
Since there's no code, the coverage and full profiles are no-ops so they can be removed

The problem with this change is that it results in dependencies for platforms other than the one being built cannot be found. For example, when I build on my Linux system, netty-all fails to build with this error:
[ERROR] Failed to execute goal on project netty-all: Could not resolve dependencies for project io.netty:netty-all:jar:4.1.65.Final-SNAPSHOT: The following artifacts could not be resolved: io.netty:netty-transport-native-kqueue:jar:osx-x86_64:4.1.65.Final-SNAPSHOT, io.netty:netty-resolver-dns-native-macos:jar:osx-x86_64:4.1.65.Final-SNAPSHOT: io.netty:netty-transport-native-kqueue:jar:osx-x86_64:4.1.65.Final-SNAPSHOT was not found in https://oss.sonatype.org/content/repositories/snapshots during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of sonatype-nexus-snapshots has elapsed or updates are forced -> [Help 1]

Which of course makes sense. If it could build, the result would be correct - but I'm not sure how to get it to build.
I've updated this PR with this change so hopefully someone else can suggest a way forward.

I'm looking at .github/workflow and expected to see where the osx packages get built, but I'm not seeing anything. How does that work?

@chrisvest reading https://github.com/netty/netty/issues/9689#issuecomment-815851869 it sounds like netty uses something other than GitHub Actions to build the MacOS native libraries. How does that work?
I'm guessing a similar solution is currently in place for Windows, too, based on https://github.com/netty/netty/pull/11284

@candrews I don't know how the MacOS builds work, exactly. Just that they aren't GitHub Actions.

This can be closed now with https://github.com/netty/netty/pull/11732 in


Docs point to nonexistent samples for targets

I'm trying to create a target, but I can't find this sample.
sample target sources
I'm trying to start with the microbit target, but I'll likely end up with just a pure JS implementation, so hopefully I won't need some of the cpp core components in the microbit target.

For microbit you can always clone the pxt-microbit repo. Sample target sources were not maintained and hence removed.

Also we will update the docs

@abchatra Thanks.  I'm trying to create my own target from scratch for some of our robots.  Is there a simpler target to start from other than microbit?

The pxt-sample repo is now public.


Disable Cache by Default

Dear,
I want disable the cache by default and I use it whenever I need it, not the case that all queries be cached by default.
Thanks in advance.

Hello @KiarashS ,
I'm not sure to fully understand this request.

Are you talking about our Query Cache feature which you don't want to always cache?
Are you talking about a whole new features which you will want to control what will be cache or not in the QueryCacheManager from Entity Framework?

Best Regards,
Jonathan

Hello @JonathanMagnan ,
Yes, your first guess is right, I talking about Query Cache feature which i don't always want to cache?
Thanks

Perfect, so the next question is how do you know or how will you want to specify if you want to cache the query or not.
I mean, if you don't want to cache use, why are you using FromCache extension methods? I'm trying to find out the purpose of this request.
Best Regards,
Jonathan

@JonathanMagnan This is my understanding of your answer:
If we use FromCache extension method then result of query will be cached,
and
If we don't use FromCache extension method then result of query will not be cached.
That's true?

Hello @KiarashS ,
Exactly,
We don't cache query by default.  You need to explicitly add the FromCache extension methods to make a query use the cache (get or add the result to the cache).
Let me know if the question has been fully answered.
Best Regards,
Jonathan

@JonathanMagnan Yes, my question now is a document for me and others :)
Thank you very much.

Closing comment: Answer confirmed


Mobile slide

This component does not support sliding on mobile.

Please provide your mobile type and environment.

Sorry for the incomplete issue.
I just tried touch slide (swipe) on several devices.
It works as expected on:

iPhone 4S (Safari)
Lg G2 (Chrome 59)
Samsung Neo (Chrome 59)

It doesn't swipe on:

Microsoft Surface 3 (Chrome)
Lenovo Tab 3 (Chrome 59 and Firefox)
Also doesn't work on Emulated devices (Dev Tools) on Chrome 59 for Windows

I am worried that the error is because the judge of the mobile RegExp is not correct, so you can try to set :event-type="touch".
If still can not work, does the console have an error?

It does work if you set :event-type="touch". The problem is, of course, it stops working on desktop.
The console doesn't have any error.

There is a great possibility because the regular expression of the device is not perfect.
There is also worry that when you switch to the simulation device debugging first refresh page, because the component will determine which type of event to bind when it is initialized.

I have the same problem too. Can you fix this without switching event-type?

I do not know the navigator.userAgent that failed to match the phone, and there are now regular expressions from issue #58 .
So, maybe you can write your own regular expression to fix this problem. like it:
<vue-slider :event-type="isMobile ? 'touch' : 'mouse'"></vue-slider>
// ...
export default {
  data () {
    isMobile: /(RegExp)/i.test((navigator.userAgent)
  }
}

If you can, welcome to submit a pr of the regular expression to me.


[Bug] Do not reload page after resolving a conversation

Gitea version (or commit ref): 1.15.0+dev-344-g5285a3e70
Can you reproduce the bug at https://try.gitea.io:

Yes: Feel free to experiment here yourself

Description
Currently, when resolving a conversation in a PR inside the Conversation tab, the page automatically gets reloaded.
Surprisingly, when resolving a conversation there inside the Files Changed tab, then it does not get reloaded.
This is interesting as I would have expected both to use the same exact code, given that both should do exactly the same.
Would it be possible to not have to endure a reload every time a conversation is resolved in the Conversation tab, simply by replacing the currently present code with the one used in the Files changed tab?

very annoying if you got a long code review, because the page jumps to the top everytime you resolve a conversation


Developer blog link not working

In the beginning of the documentation, a link is mentioned to the developer blog "more background behind this on our developer blog." This is a dead link. So please update to the new location or remove it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e77701e1-868a-3768-b2ab-ce97ba41b408
Version Independent ID: c18e9584-f323-926e-0cc2-7742d1a2736b
Content: Supporting % and # in files and folders with the ResourcePath API
Content Source: docs/solution-guidance/supporting-and-in-file-and-folder-with-the-resourcepath-api.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

This is fixed in master branch https://github.com/SharePoint/sp-dev-docs/commit/e49588c642eac9aff573ba84ffde2ca35ee07546 , yet to merge in live branch
The right URL - https://developer.microsoft.com/office/blogs/upcoming-changes-to-sharepoint-and-onedrive-for-business-apis-to-support-and-in-file-names

The live branch is refreshed on a specific schedule.


Update Tokenizer to use Microsoft.ML.Tokenizers library

The existing tokenizer implementation supports only GPT models. The Microsoft.ML.Tokenizers package provides a BPE tokenizer implementation which can be used with GPT models. In addition though, you can also load your own vocabulary files for use with other models that support BPE tokenization.
Here is a related sample that loads custom vocab files for GPT-2 from HuggingFace.
https://gist.github.com/luisquintanilla/bc91de8668cfa7c3755b20329fadd027
API Documentation

@luisquintanilla , thanks for the suggestion, we will take a look.

thanks for the info, work in progress

#2809 and #2147 made it easier to bring any tokenizer for use. #2840 demonstrates these capabilities specifically with MicrosoftML and DeepDev token counters along existing demonstration with SharpToken.

Thanks for these changes @lemillermicrosoft. They look great. Feel free to close this when the PR merges.

Fantastic Utility, Thank You!
What class supports the BERT Type Tokenizers? Same sort of thing as FastBertTokenizer and BertTokenizer?
Would be fantastic to use one class for all the main models atm.
Thank You!

is there any sort of cross-team effort (between https://github.com/dotnet/machinelearning and https://github.com/microsoft/semantic-kernel) to get the dotnet version of semantic kernel only using ML.NET tokenizers? This seems like it was a first step, so trying to track progress of further work. I see that dotnet semantic kernel uses 4 different tokenizer libraries:

I see that dotnet semantic kernel uses 4 different tokenizer libraries (from microsoft/semantic-kernel/dotnet/Directory.Packages.props)

That's just in the samples. The actual SK libraries don't use any of them.

Ahh, that makes sense. I saw SharpToken was only used in samples but FastBert was used in code, so stopped there. That was my 2nd question though - do the samples need different tokenizers, or should we be pushing them to use the ML.NET tokenizer libraries? Or should we be removing those libraries from the dotnet/Directory.Packages.props and just put them straight in the dotnet/samples/KernelSyntaxExamples/KernelSyntaxExamples.csproj?

Our collective goal is that all relevant tokenizers end up in Microsoft.ML.Tokenizers so that it's a one-stop shop for tokenization needs in .NET. Microsoft.ML.Tokenizers now provides a Tiktoken implementation, so SK wouldn't need DeepDev or SharpToken, but it doesn't yet have a BERT tokenizer. Different models need different tokenizers; tiktoken is what's used by OpenAI's models. We could probably at this point refine the sample that's using DeepDev and SharpToken to not, but really all that sample is showing is that you can use different libraries within the delegate passed to TextChunker.

Love it, that makes a lot of sense. I've been diving into these two repos and roadmaps and plans and docs over the last few days, and I got the sense that was the goal, but was difficult to find a definitive place essentially saying that. I'm assuming the ML.NET Roadmap is out of date, but that the ML.NET Milestones are up to date. Any pointers on the best place to find info similar to that for SK?
Thanks for the time clarifying!


failing on macOS: juliaup add 1.3

$ juliaup add 1.3
Installing Julia 1.3.1+0 (x64).
Error: Failed to download from url `https://julialang-s3.julialang.org/bin/mac/x64/1.3/julia-1.3.1-mac64.tar.gz`.

Caused by:
    https://julialang-s3.julialang.org/bin/mac/x64/1.3/julia-1.3.1-mac64.tar.gz: status code 404

Not sure if this is a known issue or not, but I couldn't find an issue so I figured I'd report it.

Yeah, those tar.gz files just don't exist. I repacked all versions since 0.7 for Windows at some point so that all the tar.gz files for Windows exist in the S3 bucket, if we want to fix this for the other platforms someone will have to do the same thing.

I think one question is whether we want to try to create all these tar.gz files for older versions, or just declare those as not supported? They do work on all other platforms. Presumably it would be fairly straightforward to write some shell script that simply downloads the existing dmg files, and then repackages them as tar.gz files? But I don't have access to a Mac at the moment, so this is difficult for me to do because I can't test anything...

I'd like for these to work since I somewhat often have cause to want to try things in various older versions of Julia, so if no one else gets around to this, I may attempt the dmg => tgz repackaging required.

Agreed. I think if this was automated, we could even add every version starting with 0.1? Completely useless, obviously, but for nostalgic reasons it might be fun :)

Oh man, that would be fun but getting all of the old versions working might be a bit of a struggle...

Bump, I'm wondering whether there is a chance that we can get all the Mac builds >=1.0.0 uploaded before Juliacon? I hope we will get a lot more use/traffic of juliaup after Juliacon, and it would be nice if we had these builds up there before that.

Bump, ran into this issue on MacOS today after trying to test out juliaup.

I think we have to make a decision to either add these missing archives soon, or remove the channels that error in this way at the moment for Mac builds, so that the error message at least just becomes "Unknown channel".

Bump,
I too ran into this issue on MacOS.
For the decision, I wish that the missing archives be added as opposed to just creating an error message.

Since this issue is not specific to Julia 1.3, as long as Julia hosts the build, should we not have a channel for that build?

The problem is that the normal Julia download servers only host the .dmg version of these older Julia versions, not a tar.gz file which we need...

I'm running
function download_extract_tar_and_zip(v::VersionNumber)
    url = "https://julialang-s3.julialang.org/bin/mac/x64/$(v.major).$(v.minor)/julia-$v-mac64.dmg"
    download_file = "julia-$v.dmg"
    extract_file = "julia-$v"
    run(`curl $url -o $download_file`)
    run(`hdiutil attach $download_file`)
    volumes = filter(x->startswith(x, "Julia-$v"), readdir("/Volumes"))
    try
        folder = only(volumes)
        cp("/Volumes/$folder/Julia-$(v.major).$(v.minor).app/Contents/Resources/julia", extract_file)
    finally
        for volume in volumes
            run(`hdiutil detach /Volumes/$volume`)
        end
    end
    run(`tar -czf julia-$v.tar.gz julia-$v`)
end

versions() = [v"1.0.0", v"1.0.1", v"1.0.2", v"1.0.3", v"1.0.4", v"1.0.5", v"1.1.0",
              v"1.1.1", v"1.2.0", v"1.3.0", v"1.3.1", v"1.4.0", v"1.4.1", v"1.4.2"]

foreach(download_extract_tar_and_zip, versions())

I'll upload the results when it's done.

Update: I have the files locally but I don't know how to share the results. I have 14 85MB .tar.gz files that seem reasonable.

Update 2: here they are, courtesy of WeTransfer: https://we.tl/t-xR4fxZDDXf

Note, even 1.5 doesn't work on mac. 1.4 did for me, but 1.3 and earlier did not. On linux, I was able to go all the way back to 0.7.

This works now.


FAB in Appbar bottom onPress not triggered in Android works fine in iOS

Is there any solution for this problem?

@thyagarajarahul  This PR might solve the issue https://github.com/codypearce/material-bread/pull/273

This PR has nothing to do with RN or your Lib. Can you suggest me something else?

@thyagarajarahul The link above is for a PR on this library for RN, that directly addresses the title of this issue.


only copy across the given config file

so, .nbqa.ini will have
addopts = ...
config = ...

closed by #145


UX: implements presence indicator as a circle instead of bubble

The logic for this change is to prevent confusion between presence and new message. New message being presented as a bubble is already a very strong concept across Discourse, this new pattern attempts to prevent the confusion.

Cool.
Just wondering: did you specifically want this to be different from the "last poster" halo effect in core, where we use a border plus a box shadow? I mean the effect in the example below

Yep... I think this is too much noise


Emoji keyboard hides last item

Hello again. This works fine for the regular keyboard but once I click on the emoji keyboard, this happens: http://i.imgur.com/oaRWirD.png

Thanks for you feedback. I'll try to check it this week, but feel free to send me a merge request.
Cheers


Corrupted records in export to CSV

Discussed in https://github.com/MESH-Research/knowledge-commons-repository/discussions/79

Originally posted by monotasker May 11, 2023
@mikethicke: I've identified one record that seems to be involved in several corrupted rows of data: https://hcommons.org/deposits/item/hc:44597/
The record appears fine on its landing page and produces normal mods xml. In the csv the record is normal up to the abstract field. The abstract is cut off after the sentence "It was the breaking away from this idea that was perhaps the most important aspect of the works of both Immanuel Kant (1724-1804) and David Hume (1711-1776)." The rest of the abstract text is then spread over the first few fields of the next several rows. Within each of those rows it looks like the text is divided at commas. But I can't immediately see what in the text is triggering the skip to a new row each time.
The first thing I noticed was the unescaped single quotes, but they don't seem to coincide with the breaks.

https://github.com/MESH-Research/dev-scripts/commit/eb133dc0c524a3559f0e2b4acf97b225ac2f2b96

Replaces \n and \r with the literal characters.
json-encodes arrays
Adds submitter wordpress username and email address

It's generally looking good and easier to parse. I've run into at least one problem in record hc:37643. The "authors" field seems to be spread across the next few fields. The first fullname value includes quotation marks: Larry A. "Tony" Smith
It's somehow coming into the CSV as "Larry A. \Tony\" Smith""

I'm also getting a parsing error trying to parse the string from hc:43403 as a python literal:
[{"fullname":null,"given":"","family":"","uni":null,"role":"","affiliation":false},{"fullname":"Abayomi Kizito FOLORUNSO","given":"Abayomi","family":"Kizito FOLORUNSO","uni":"","role":"author","affiliation":""}]
I think the issue here is the values null and false without quotation marks. Python has to treat those as symbols, but they don't have referents. Can we replace values like that with empty strings?

After a bit more work, it looks like I'm getting around 100 unparseable strings, almost all (maybe all?) in those two patterns: improperly escaped quotation marks and unquoted null/false values.
I'm also still seeing the description spread across multiple fields and records in hc:43939; hc:44243; hc:44291; hc:44685; hc:44699; hc:44849; hc:44899; hc:45615;
I haven't tried to debug those records any further, but I think they're the same ones as before--after (only some?) html escape characters commas start to be interpreted as field breaks and newlines as record breaks.


The batch size is exceeding the limit provided. Unable to train.

Traceback (most recent call last):
File "train.py", line 224, in
main()
File "train.py", line 221, in main
trainModel(model, train_dataset, valid_dataset, optimizer)
File "train.py", line 152, in trainModel
train_loss, train_acc = trainEpoch(epoch)
File "train.py", line 117, in trainEpoch
pred_answers, answer_probs = model(batch_docs, batch_docs_len, doc_mask, batch_querys, batch_querys_len, query_mask,answers=batch_answers, candidates=candidates)
File "-/ulti3/lib/python3.5/site-packages/torch/nn/modules/module.py", line 224, in call
result = self.forward(*input, **kwargs)
File "-/-/a-o-a/AoAReader/aoareader/AoAReader.py", line 91, in forward
alpha = softmax_mask(M, M_mask, axis=1)
File "-/-/a-o-a/AoAReader/aoareader/AoAReader.py", line 22, in softmax_mask
shift = shift.expand_as(input).cuda()
File "-/ulti3/lib/python3.5/site-packages/torch/autograd/variable.py", line 725, in expand_as
return Expand.apply(self, (tensor.size(),))
File "-/ulti3/lib/python3.5/site-packages/torch/autograd/_functions/tensor.py", line 111, in forward
result = i.expand(*new_size)
RuntimeError: The expanded size of the tensor (832) must match the existing size (64) at non-singleton dimension 1. at /pytorch/torch/lib/THC/generic/THCTensor.c:323

Hi revsi, can you tell me under what condition the error occurs? At the beginning of the training or at some middle stage?
seems that the batch dimension and document-words dimension are misplaced.  I tried batch size 64, it works.

I found two bugs in the code.
Line 134 of preprocess.py
train_data, valid_data, test_data = Parallel(n_jobs=2)(delayed(vectorize_stories)(stories, vocab_dict)
for stories in [train_stories, valid_stories, test_stories])
#test_stories is missing
Line 187 of train.py
train_data = torch.load(opt.traindata)
#traindata instead of data
Even After that I get following error
TypeError: torch.index_select received an invalid combination of arguments - got (torch.cuda.FloatTensor, int, torch.LongTensor), but expected (torch.cuda.FloatTensor source, int dim, torch.cuda.LongTensor index).
I tried changing all torch.Longtensor to torch.cude.Longtensor but then encountered that batch size issue.
Can you please update the repository with the local version of your code. Thanks in advance.

Thx for pointing out the bugs, I've fixed them and tried the latest repo, which worked. I didn't encountered the batch size issue.
Which version of pytorch are you using? Mine is 0.1.12_2.😀

Thanks for the quick fix. I am using 0.2.0_3 version of pytorch. I am still facing the same issue. What are the parameters you are using for training.

The default value in code

Check the pull request. fixed the version issue.


Clarify installation steps.

Summary
I think this is a feature request more so than a bug so I selected Feature Requestion Issue option.
The landing page https://flowbite-svelte.com/ shows
npm i flowbite flowbite-svelte

but when you click on get started to get to https://flowbite-svelte.com/docs/pages/quickstart it shows
pnpm i -D flowbite-svelte

excluding that one page uses npm and another shows pnpm, the commands are different where one is using -D (pnpm) or --save-dev (npm) and another is not using any flags.
also one installs flowbite & flowbite-svelte while the pnpm only installs flowbite-svelte as devDep.
Should I be installing both flowbite and flowbite-svelte and as devDep. ?
i.e. PNPM: pnpm add -D flowbite flowbite-svelte NPM: npm i --save-dev flowbite flowbite-svelte.
Motivation
Clarify installation steps.

Thanks. I will update it using pnpm throughout.

Thank you for your contribution.
Please feel free to open a new issue.


Add the ability to add separate text fields spanning a wave break/continuation

When a wave break/continuation is used, the text data for that segment is combined for both sides. Add the ability to have two separate fields on either side.
My current workaround for this is to add large numbers of whitespaces in between the text to spread it over the break.

@yzmotoxer807 could you add couple of pictures for wanted and unwanted behavior?

The desired behavior can be generated with the following:
{signal: [
  {name: 'clk', wave: 'p.....|....'},
  {name: 'bus', wave: '=.=...|..=.', data: ['D0','                D1              DN-1','DN']}
]}

Related to this, I also found that there is no way to have a gap not continue the previous tick, but instead repeat the previous tick's edge, unless you are using a clock.
{signal: [
  {name: 'desired behavior', wave: 'p......|....'},
  {wave: '0101010|0101'},
  {wave: '1010101|1010'}
]}

yes, #48 is the related bug.


Properly handle 404s from the history API on submission history page.

Describe the bug
If you're logged in as an admin and try to access /submissions while switched to an organization that has no senders, you'll get an "An error has occurred" message. This is due to the fact that the history API now returns a 404 if there are no senders. We need to handle that error better on the front end and display a more informative message.
Impact
Only happens for admins (other users don't have access to this part of the UI)
To Reproduce
Steps to reproduce the behavior:

Log in to staging as an admin
Switch to an org that doesn't have senders (al-phd for example)
Navigate to https://staging.reportstream.cdc.gov/submissions
See error

Expected behavior
As a user, I'd expect to see a more informative error message (otherwise it seems like something is broken)
Screenshots

Additional context
Slack conversation here

The underlying issue is that Admins can access anything because we measure their role through Okta auth, so when hopping between senders and receivers, they aren't shown just sender or just receiver features. That said, I'd love to improve our app permissions. We could break out app user permissions into a context that's set using the Okta's auth handler. Then, for admins only, handle permissions from the selected org in app, not their okta token. This would help us fully emulate the experience of a user in that organization without having to alter your okta groups.

There are also a few 404s for settings requests but they don't seem to have an impact on the UI.
https://staging.reportstream.cdc.gov/admin/settings
https://staging.prime.cdc.gov/api/settings/organizations/al-phd/senders/default

@mreifman Are you able to post the payloads of those calls, as well? Curious if that'll help diagnose where it's coming from. We have <SenderModeBanner> that calls out for the sender (that second call labeled default, indicating you might be in a group labeled DHSender_ in OktaPreview and it's not finding the org settings and sender settings.

The request to https://staging.reportstream.cdc.gov/admin/settings doesn't have an organization header.
The request to https://staging.prime.cdc.gov/api/settings/organizations/al-phd/senders/default has request header for organization: al-phd, which matches the selected org.

Doh! I guess I could've derived that from the URI. I think I found it, but I'm unable to replicate locally.
This hook is what's calling it. It's used in <SenderModeBanner> to handle the fetch logic. It looks like my original safety is failing here so it calls regardless.
This is another byproduct of our tricky handling of permissions, as is this (noted above). I think it's worth creating some form of "ProfileContext" that makes this logic cleaner and accessible by providing a user type (sender/receiver), permissions, org, etc.

Bumping this up to a 5 due to coverage and the amount of places we're utilizing these permissions conditionals.


Revert the revert of "Hide the window until we're finished with initialization"

⚠ I'm targeting #13570 with this, because I want to have all my startup HWND hijinks on one continuous branch, rather than 100 things to merge and mess with each other. ⚠
This is a revert of the revert of #12979. We mainly reverted that PR because of an issue where restored windows would grow/shrink slightly on external displays. It was too close to the ship date for that release, so we backed it out wholesale (in #13098). I think I've found the real root of the problem, and fixed it here.
The money diff here from the original PR: 4c08b9a1bc2e90b8284e4d8117d0de400784520f...c34495dcfc19ea67a9f4f9673d422760200683ab. Basically, I had put the part where we actually handle the creation of the window into _AppInitializedHandler, when we should have left the window to be created in _HandleCreateWindow We create it there, hidden, and then should only show it in _AppInitializedHandler.
I'm NOT incorporating the change for #9053. I reverted that bit in 1fac40355. I am too worried about that messing with the phwnd that I wanted to get that reviewed and committed atomically, separately.

fixes  #11561
tested manually
I work here

@msftbot make sure @winobjc-bot signs off

On second thought perhaps we should hold this for 1.17+?

Yea maybe. Going back to 4c08b9a didn't fix it either. Uhg.

Huh, I never added real notes as to why we held this one out. IIRC it was something like the fact that this would consistently work for the first window I'd make but not subsequent ones, which is w e i r d
And now that I'm 6 months removed from that code, that makes me thing it might have something to do with summoning peasant windows after creation, that the monarch wouldn't do. That's at least something that would be obviously different between the N=0 and N>=1 windows.

@Nirgranth if you'd like to help out, I'd start here. Or possibly even further back in the past, to the original version of this PR, #12979.
The original idea was that we shouldn't call ShowWindow in our WM_CREATE handler, we should instead wait until the XAML content is fuly initialized to show the window.
That original PR had some issue about getting the initial sizing just a little wrong, so we reverted that. This PR attempted to fix that sizing issue (and definitely did figure the sizing thing out).
But somewhere between there (#12979) and now, this PR doesn't seem to work at all anymore. Probably an incoming merge from main, but there's months of commits here now. It might just be best to start from the original idea fresh again.
Anyways, that's my notes. I'd doubt I'll have time to loop back on this one soon, so any help would be appreciated. I'm guessing there's a rogue ShowWindow call that's happening, but I don't see anything obvious to blame.

Magically, this works again after 6a99f25. We needed another jiggle the handle to let XAML paint


Feature seller locality 1

Codecov Report

Merging #49 (cba2ac5) into main (61cca05) will increase coverage by 3.97%.
The diff coverage is 87.47%.

:exclamation: Current head cba2ac5 differs from pull request most recent head f91fd35. Consider uploading reports for the commit f91fd35 to get more accurate results

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   84.44%   88.41%   +3.97%
==========================================
  Files          25       33       +8
  Lines        1697     2003     +306
==========================================
+ Hits         1433     1771     +338
+ Misses        239      201      -38
- Partials       25       31       +6

Impacted Files
Coverage Δ

cmd/server/handlers/seller.go
84.68% <42.30%> (-11.20%)
:arrow_down:

...ternal/carry/adapters/locality_mysql_repository.go
60.00% <60.00%> (ø)

internal/seller/service.go
92.68% <68.42%> (-7.32%)
:arrow_down:

internal/carry/usecases/service_locality.go
81.25% <81.25%> (ø)

cmd/server/handlers/carries/locality.go
84.61% <84.61%> (ø)

internal/locality/repository.go
87.17% <87.17%> (ø)

internal/seller/repository.go
91.50% <93.33%> (+8.01%)
:arrow_up:

internal/locality/service.go
94.64% <94.64%> (ø)

cmd/server/handlers/carries/carry.go
100.00% <100.00%> (ø)

cmd/server/handlers/locality.go
100.00% <100.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61cca05...f91fd35. Read the comment docs.


deheader: 1.8 -> 1.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/deheader/versions.
meta.description for deheader is: Tool to find and optionally remove unneeded includes in C or C++ source files
meta.homepage for deheader is: http://catb.org/~esr/deheader
meta.changelog for deheader is: https://gitlab.com/esr/deheader/-/blob/master/NEWS.adoc
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.10 with grep in /nix/store/03v6p2sljm0hxmapvi57n04j8pn2d05p-deheader-1.10
found 1.10 in filename of file in /nix/store/03v6p2sljm0hxmapvi57n04j8pn2d05p-deheader-1.10

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
deheader

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/03v6p2sljm0hxmapvi57n04j8pn2d05p-deheader-1.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A deheader https://github.com/r-ryantm/nixpkgs/archive/4d7fc9c128035b54bb2ae1b1fb9298bf4e886825.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/03v6p2sljm0hxmapvi57n04j8pn2d05p-deheader-1.10
ls -la /nix/store/03v6p2sljm0hxmapvi57n04j8pn2d05p-deheader-1.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

deheader

Maintainer pings
cc @KAction for testing.

Result of nixpkgs-review pr 217736 run on aarch64-linux 1

1 package built:

deheader


add mapbox url scheme support

Description
Fixes #25
Checklist

[x] I have tested this on a device/simulator for each compatible OS
[x] I formatted JS and TS files with running yarn lint:fix in the root folder
[ ] I updated the documentation with running yarn generate in the root folder
[ ] I mentioned this change in CHANGELOG.md
[x] I updated the typings files (index.d.ts)
[ ] I added/updated a sample (/example)

Thank you for this commit. It's great to be independent but It's also great to be back compatible 👍

Vendor-specific parts of the code base should be maintained outside of the MapLibre org since our goal is to be vendor neutral.

Vendor-specific parts of the code base should be maintained outside of the MapLibre org since our goal is to be vendor neutral.

It must be a way to integrate MapLibre with any vendor using some events or handlers to configure your custom URL scheme. I couldn't find one, sorry if there is.


Add adminui subcommand

This change is

Can we call this adminurl for consistency with pgurl?

Done.

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

main.go, line 765 at r1 (raw file):

			ip := c.VMs[node-1]
			port := install.GetAdminUIPort(c.Impl.NodePort(c, node))
			fmt.Printf("http://%s:%d/\n", ip, port)

This should be https if secure is true. Also, the adminurl command will need to take the --secure flag.

Comments from Reviewable

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

main.go, line 765 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
This should be https if secure is true. Also, the adminurl command will need to take the --secure flag.

Looks like the pgurl command also needs the --secure flag.

Comments from Reviewable


command options not work, ie. --title

Please search existing issues before creating a new one.
Ideally, after filing the issue, try to fix the issue with a PR!

Expected Behavior
according to the example in doc:
clasp create --title "My Script" --parentid "1D_Gxyv*****************************NXO7o" --rootDir ./dist
I use command clasp create --title "abc" to create a standalone gas file as shown in README file,
Actual Behavior
I got "error: unknown option '--title", then I find this video tuto from Jordan Rhea, it looks that '--title' '--type' should not used, but '--rootDir' could be used.
Am I wrong in document reading or doc should be updated?
Steps to Reproduce the Problem

clasp create --title "abc"

Specifications

Node version (node -v): v.8.5.0
Version (clasp -v): v1.6.3
OS (Mac/Linux/Windows): Mac

Docs in GitHub repository (ex: readme.md ) is based on version in develop.
If you use v1.6.3(latest),  look the document on npm .
The option --title will probably be available in the next release.

Yes, please see npm for the currently published version of clasp. GitHub currently has the dev build of clasp. There may be some things that are currently in development that will be published mid December.
Thanks!


Consider removing protocol.NewProtocol() API

The protocol.NewSocket() API is clearer, and more widely used.  The NewProtocol() API is baggage left over from before -- it would be better & clearer if we just removed it from the various protocols.

Maybe we should leave either Protocol variables, or perhaps something akin to bus.Bus, rep.Rep, etc. objects?

Well, we can't really have fixed variables, because the protocol implementations are stateful.  So for now just remove the protocol.NewProtocol() and leave behind only the xxx.NewSocket() methods.


dns isn't connecting to wfc

i've done everything up until having to connect my game to the program but, the dns it's giving me doesn't connect to nintendo wfc. i also tried to do the update pid and it keeps saying my wifi connection doesn't exist.

What error code do you get?

What error code do you get?

when i try and game sync i get 20100 "unable to connect to nintendo wifi connection"

Could you post Entralinked’s log here?

Could you post Entralinked’s log here?

like a photo of the program on my computer and do i show the dns or block it out

2023-09-13 12:27:04.021 ERROR : Could not add BouncyCastle to SystemClassLoader search
java.nio.file.NoSuchFileException: libs\bcutil-jdk15on-1.70.jar
at sun.nio.fs.WindowsException.translateToIOException(Unknown Source) ~[?:?]
at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source) ~[?:?]
at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source) ~[?:?]
at sun.nio.fs.WindowsFileSystemProvider.newByteChannel(Unknown Source) ~[?:?]
at java.nio.file.spi.FileSystemProvider.newOutputStream(Unknown Source) ~[?:?]
at java.nio.file.Files.newOutputStream(Unknown Source) ~[?:?]
at java.nio.file.Files.copy(Unknown Source) ~[?:?]
at entralinked.LauncherAgent.agentmain(LauncherAgent.java:35) ~[entralinked.jar:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?]
at sun.instrument.InstrumentationImpl.loadClassAndStartAgent(Unknown Source) ~[?:?]
at sun.instrument.InstrumentationImpl.loadClassAndCallAgentmain(Unknown Source) ~[?:?]
at sun.instrument.InstrumentationImpl.loadAgent0(Native Method) ~[?:?]
at sun.instrument.InstrumentationImpl.loadAgent(Unknown Source) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?]
at sun.launcher.LauncherHelper.lambda$getMainClassFromJar$0(Unknown Source) ~[?:?]
at java.util.Optional.ifPresent(Unknown Source) ~[?:?]
at sun.launcher.LauncherHelper.getMainClassFromJar(Unknown Source) ~[?:?]
at sun.launcher.LauncherHelper.loadMainClass(Unknown Source) ~[?:?]
at sun.launcher.LauncherHelper.checkAndLoadMain(Unknown Source) ~[?:?]
2023-09-13 12:27:04.036  INFO : Loading configuration ...
2023-09-13 12:27:04.036  INFO : No configuration file exists - default configuration will be used
2023-09-13 12:27:04.037 ERROR : Could not load configuration - default configuration will be used
java.io.FileNotFoundException: config.json (Access is denied)
at java.io.FileOutputStream.open0(Native Method) ~[?:?]
at java.io.FileOutputStream.open(Unknown Source) ~[?:?]
at java.io.FileOutputStream.(Unknown Source) ~[?:?]
at java.io.FileOutputStream.(Unknown Source) ~[?:?]
at com.fasterxml.jackson.core.TokenStreamFactory.fileOutputStream(TokenStreamFactory.java:294) ~[entralinked.jar:?]
at com.fasterxml.jackson.core.JsonFactory.createGenerator(JsonFactory.java:1428) ~[entralinked.jar:?]
at com.fasterxml.jackson.databind.ObjectMapper.createGenerator(ObjectMapper.java:1230) ~[entralinked.jar:?]
at com.fasterxml.jackson.databind.ObjectMapper.writeValue(ObjectMapper.java:3906) ~[entralinked.jar:?]
at entralinked.Entralinked.loadConfigFile(Entralinked.java:174) [entralinked.jar:?]
at entralinked.Entralinked.(Entralinked.java:69) [entralinked.jar:?]
at entralinked.Entralinked.main(Entralinked.java:33) [entralinked.jar:?]
2023-09-13 12:27:04.038  INFO : Using configuration Configuration[hostName=local, clearPlayerDreamInfoOnWake=true, allowOverwritingPlayerDreamInfo=false, allowPlayerGameVersionMismatch=false, allowWfcRegistrationThroughLogin=true]
2023-09-13 12:27:04.104  INFO : Loading DLC ...
2023-09-13 12:27:04.104  INFO : Extracting default DLC files ...
2023-09-13 12:27:04.107 ERROR : Could not extract default DLC files
java.nio.file.NoSuchFileException: .\dlc\IRAO\CGEAR\01 - Default.bin
at sun.nio.fs.WindowsException.translateToIOException(Unknown Source) ~[?:?]
at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source) ~[?:?]
at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source) ~[?:?]
at sun.nio.fs.WindowsFileSystemProvider.newByteChannel(Unknown Source) ~[?:?]
at java.nio.file.spi.FileSystemProvider.newOutputStream(Unknown Source) ~[?:?]
at java.nio.file.Files.newOutputStream(Unknown Source) ~[?:?]
at java.nio.file.Files.copy(Unknown Source) ~[?:?]
at entralinked.model.dlc.DlcList.(DlcList.java:48) [entralinked.jar:?]
at entralinked.Entralinked.(Entralinked.java:94) [entralinked.jar:?]
at entralinked.Entralinked.main(Entralinked.java:33) [entralinked.jar:?]
2023-09-13 12:27:04.107  INFO : Loading user and profile data ...
2023-09-13 12:27:04.108  INFO : Loading player data ...
2023-09-13 12:27:04.229  INFO : Mapping GameSpy request types ...
2023-09-13 12:27:04.255  WARN : SSL will be disabled because BouncyCastle could not be loaded
2023-09-13 12:27:04.362  INFO : Loading C-Gear and Pokédex skin previews ...
2023-09-13 12:27:04.363  INFO : Cached 0 skin previews
2023-09-13 12:27:04.367  INFO : Starting servers ...
2023-09-13 12:27:04.368  INFO : Starting HTTP server ...
2023-09-13 12:27:04.369  INFO : Starting Javalin ...
2023-09-13 12:27:04.394  INFO : jetty-11.0.15; built: 2023-04-11T18:37:53.775Z; git: 5bc5e562c8d05c5862505aebe5cf83a61bdbcb96; jvm <IP_ADDRESS>+1
2023-09-13 12:27:04.434  INFO : Session workerName=node0
2023-09-13 12:27:04.444  INFO : Started i.j.j.@3aefae67{/,null,AVAILABLE}
2023-09-13 12:27:04.455  INFO : Started<EMAIL_ADDRESS>(http/1.1)}{<IP_ADDRESS>:80}
2023-09-13 12:27:04.456  INFO : Started Server@33a053d{STARTING}[11.0.15,sto=0] @1285ms
2023-09-13 12:27:04.456  INFO :
__                  ___          ______
/ /__ __   ______ / ()___     / /
__  / / __ / | / / __ / / / __ \   /
/ // / // /| |/ / // / / / / / /  / /
_/_,/ |/_,//// //  /_____/
   https://javalin.io/documentation

2023-09-13 12:27:04.472  INFO : Static file handler added: StaticFileConfig(hostedPath=/dashboard, directory=/dashboard, location=CLASSPATH, precompress=false, aliasCheck=null, headers={Cache-Control=max-age=0}, skipFileFunction=Function1<jakarta.servlet.http.HttpServletRequest, java.lang.Boolean>, mimeTypes=io.javalin.http.staticfiles.MimeTypesConfig@3703bf3c). File system location: 'jar:file:/C:/Users/ryan/Downloads/entralinked/entralinked.jar!/dashboard/'
2023-09-13 12:27:04.473  INFO : Static file handler added: StaticFileConfig(hostedPath=/sprites, directory=/sprites, location=CLASSPATH, precompress=false, aliasCheck=null, headers={Cache-Control=max-age=0}, skipFileFunction=Function1<jakarta.servlet.http.HttpServletRequest, java.lang.Boolean>, mimeTypes=io.javalin.http.staticfiles.MimeTypesConfig@1dab9dd6). File system location: 'jar:file:/C:/Users/ryan/Downloads/entralinked/entralinked.jar!/sprites/'
2023-09-13 12:27:04.475  INFO : Listening on http://localhost:80/
2023-09-13 12:27:04.483  INFO : You are running Javalin 5.5.0 (released May 1, 2023. Your Javalin version is 134 days old. Consider checking for a newer version.).
2023-09-13 12:27:04.484  INFO : Javalin started in 116ms \o/
2023-09-13 12:27:04.486  INFO : Staring GameSpy server ...
2023-09-13 12:27:04.566  INFO : GameSpy server listening @ port 29900
2023-09-13 12:27:04.567  INFO : Staring DNS server ...
2023-09-13 12:27:04.578  INFO : DNS server listening @ port 53
2023-09-13 12:27:04.579  INFO : Startup complete! Took a total of 984 milliseconds

The issue is that SSL is a disabled because critical dependencies could not be extracted because the program has no write permissions. Without SSL, your DS refuses to connect.
Try moving entralinked.jar out of your Downloads folder.

i just took it out of my downloads folder and put it on my desktop and it still says ssl will be disabled because bouncycastle could not be loaded

I guess something is preventing Java from creating files. I don't know what or why, maybe an antivirus of some kind.
Try running a Command Prompt as administrator and execute the command java -jar entralinked.jar

i got this: C:\Users\ryan>java -jar entralinked.jar
Error: Unable to access jarfile entralinked.jar

Yeah you have to navigate to wherever entralinked.jar is first.
If you put entralinked.jar in a folder called entralinked on your desktop, you can do
cd desktop/entralinked
and then
java -jar entralinked.jar

it worked like a charm let me try again now

thank you so much yo it worked


How should I factor my specific problem, and more broadly, how should I handle Result<!, E>?

Hi,
I've been using the tokio join and select macros in some tests of mine. I recently came across this crate, and I like the thought of moving away from macros to proper concurrency primitives. However, when I tried to fit my tests into the existing options in this crate, I can't seem to make it work without adding some additional logic that is ultimately unnecessary. I thought I would post my situation here, in case I'm either missing something or it's a genuine use case that could use its own primitive.
In my case, I have three tasks, call them A, B and C. With a successful test, I expect both A and B to return Ok, but C doesn't actually need to return; it can just be dropped. If there is a problem, any of the three could return an Err.
In this situation, neither Race nor RaceOk is acceptable, because I need to confirm that both A and B returned Ok, but I also can't use Join or TryJoin natively, because it will hang if the test is successful. I could maybe use Merge, since they all return anyhow::Result<()>, and I could verify that I get exactly two Ok, but that feels like a hack.
My current solution, and the solution I would use with futures-concurrency, is to add a way to gracefully shutdown C by giving it a CancellationToken. In my specific case, that's not too much work, because C is actually just a loop with a single await point. But ultimately, the graceful shutdown of C is unnecessary, and the added logic only clutters the code. That clutter would also be worse if C were more complicated.
Now that I think about it more, I suppose I could TryJoin A and B and then Race that future with C. I think that would work, but it wouldn't return all of the errors. It would only return the first. I suppose that's an inherent problem, though, since I can't guarantee all tasks will complete in the event of an error somewhere.
Is this a situation you've seen before? Is what I came up with just now the "correct" implementation in your mind? More broadly, what do you do if you expect some future to never return unless there is an error? Essentially, how do you handle Result<!, E>?

Heya! This is a fun question, thanks for asking!
In this case, can C succeed with anything other than an error? If it can only ever fail, then it's easy: try-join A and B, then race that join with C:
let ab = (a, b).try_join();
let f = (ab, c).race().await?;

If C can also return with a success, then you're indeed right and we need to provide a way to short-circuit execution of C. One way of doing that would be to try-join A and B again, and then on completion of the join drop the sending side of an async-channel channel. This will cause the receiving side to resolve, which will close the channel. If you race task C with the receiver you now have your cancellation token done:
use async_channel::bounded;

let (sender, receiver) = bounded(0); // zero-sized channel
let ab = (a, b).try_join().map(move |res| {
    drop(sender); // both a and b completed, cancel c
    res
});
let c = (c, receiver).race();
let f = (ab, c).try_join().await?;

You'll probably need to align the return types for all of this to work, but I hope one of these approaches will work for what you're trying to do!

If it can only ever fail, then it's easy: try-join A and B, then race that join with C

Yeah, I realized that as I was typing up my first post. There's really no better debugging tool than explaining your problem in detail to someone else.
In my case, C never returns in the successful case. It is indeed Result<!, E>. So TryJoin + Race is what I need. Thanks for taking a look.


nuspec parse exception

Hi!!!
I am trying to run the Dependency scan on our CPP projects via azure pipeline, dependency check analyzer throwing an NuspecParseException. please find the log attached.
Please do the needful.

The underlying cause of your issue is an XML validation in your nuspec:
[Fatal Error] :10:19: Open quote is expected for attribute "src" associated with an  element type  "file".
Exception in thread "main" org.xml.sax.SAXParseException; lineNumber: 10; columnNumber: 19; Open quote is expected for attribute "src" associated with an  element type  "file".
	at java.xml/com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:262)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:342)
	at java.xml/javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:122)
	at Scratch.main(scratch.java:36)

The $location$ needs to be quoted for forming syntax-valid XML.


Add option to exclude package names from deletion

This PR contains the changes proposed in #8 but split into two PRs: one for each proposed feature. This one provides the ignore-package-names option allowing to provide a regular expression to specify package names to exclude from deletion. This should address use cases like those in #6. For instance, with package names
- 4.20
- 4.21
- 4.20.20200329
- 4.21.20200330

And the following configuration:
with:
  ignored-version-names: "docker-base-layer|^\\d+\\.\\d+$"
  num-old-versions-to-delete: "5"

Only 4.20.20200329 and 4.21.20200330 would be deleted. As the current GraphQL API doesn't allow to query packages with a filter pattern, filtering is done after retrieving the last N packages. As a result, less than N packages may be deleted, which admittedly may be contrary to user expectation (though the same happens when requesting N older packages when there are less than N).

@Hsn723 have you been using your branch. Seems like there is nothing happening in this repo.

@Hsn723 have you been using your branch. Seems like there is nothing happening in this repo.
UPDATE using your branch now in an action and it works great. I hope this will get merged.

Thanks for the feedback. We've been using a branch (https://github.com/MatsuriJapon/delete-package-versions/tree/matsuri) that contains this and other proposed changes (#9) in production for a while now and haven't encountered issues so far.

@Hsn723 Somehow it's not working for me.
  uses: myfork/delete-package-versions@matsuri
  name: delete package
  with:
    package-name: 'name'
    num-old-versions-to-delete: 1
    ignored-version-names: docker-base-layer|^[1-9]+\.[0-9]+\.[0-9]+$
    search-range: 50

This is what I am using. The action says the following:
number of versions requested was: 50, but found: 24
version with id: xxx, deleted
When I look at the packages, the version doesn't get deleted.
I am able to delete the version manually by using the version id however.
Do you have any ideas? Thanks in advance.

@cprell You're right!
It looks like there was a bug in our dry-run implementation that made everything a dry-run, which we've addressed.
Also btw, you'll need to escape slashes inside your regular expression as it seems that otherwise the slashes get consumed once by the input parser.
I'd also like to advise against using the "matsuri" branch of our fork. We use it internally and may change it periodically (for instance rebasing with any upstream changes, which was why we cut that branch in the first place). I'm pleasantly surprised to see it being used elsewhere, but cannot assume responsibility for any broken builds 🙏.

@Hsn723 Thanks for the quick reply!

Also btw, you'll need to escape slashes inside your regular expression as it seems that otherwise the slashes get consumed once by the input parser.

In this case I think the regex works correctly for what I want to achieve. It filters out release versions like 1.2.0 but not snapshot versions like 1.2.0-SNAPSHOT.

I'd also like to advise against using the "matsuri" branch of our fork. We use it internally and may change it periodically

Thanks for the heads up, but I forked your fork and use our fork, so that I can use a stable version without any changes. I think using the matsuri branch is fine then. (and I like the branch name!)

I'm pleasantly surprised to see it being used elsewhere, but cannot assume responsibility for any broken builds 🙏.

Of course, you've done great work. Thanks for that!
I tried using the action now and it worked. Big help!

This feature has been released with the latest version actions/delete-package-versions@v2. Closing this PR.


Re-Implement Tabular Training for NextJS Upgrade

Describe the solution you'd like
Re-Implement tabular training for Nextjs Upgrade
Setup Instructions (what branch to work off of)
Run the following commands
git checkout nextjs
git pull origin nextjs
git checkout -b tabular```

FYI: If you are not able to immediately run `git checkout nextjs`, make sure you commit your changes in the current branch or run `git stash` and then execute the above commands

context @dwu359

Basically I'll be re-implementing tabular train with a multi-step design rather than the singular page that we used to have to train models.

ah i see.

@dwu359 seems like we are revamping the training UI, so this task isn't needed (but technically complete)


Added MacOS support

using cefsimple.app instead of gdCefSubProcess
change 'osx' to 'macos' as default

@eliopark-nsuslab Seriously?  Is this my Christmas gift before the date? 😍

@eliopark-nsuslab I removed your ssl line inside the build.py since this can add security issues. I'm trying to add a CI for the MacOS


Call WebMock.enable before all specs in an example group

Calling WebMock.enable! in a before :all block prior to the integration config means example groups can be run in any order without affecting each other's WebMock setting.
Addresses issue mentioned in #16

Thanks! 👍


Aliased str to repr

PR implementing the suggestion in #966. The code change is tiny (aliasing __str__ to __repr__) and most of this PR will be about updating the docs.
Here is the behavior before:

And after:

Of course I'll make sure to put the parens around print in the notebooks for Python 3 support!

I've now updated all the notebooks using print(repr(..)) and I have been careful to make sure the notebook tests kept passing.
Unfortunately, there are two notebooks with fixes that I do expect will result in test failures. These involve use of naked repr(..) which should result in different output  (due to extra quotes compared to print).

As expected the tests failed. I thought only one cell would fail, but as repr returns a string whereas print outputs to standard output, the test data is now shifted. Rebuilding the test data now.

Now the test data has been updated, the pr build passed and the push build failed (as expected). Ready to review/merge.


[Add] TechWithTim

Site URL
https://www.youtube.com/@TechWithTim
Description of the above provided site
Youtuber with 1.55M subs.
Main focus on python, machine learning and AI
Category
Languages
Sub Category
Python
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[x] I am willing to work on this issue (optional)

Do you want to work on this issue? @Jay-Karia

No

Do you want to work on this issue? @Jay-Karia

Yes

@rajneesh-18 You can contribute here: #2431


Question about attack related uuid

Hello, sir. Thanks for your paper and open-source codes which provide great help. Here are still some doubts I want to ask. In the appendix G of your paper, you have introduced a labeling methodology. I am quite curious about how it was implemented, especially the determining of the uuid associated with the attack. I want to label new scenes in DARPA-TC groundtruth pdf. Would you mind sharing the code of this application. Waiting for your reply.

In this paper, we tried the labeling methodology in Appendix G with manual labour (simply manually examine attack-relevant log files, search for attack entity names and examine other entities related to them) and it worked. However this approach is extremely effort-consuming, necessitating the construction of a uuid-to-entity-name mapping before labeling. We have a quite primitive parser capable of doing this and we are happy to send you a copy if you could leave your email.

Thank you sir, my email address is<EMAIL_ADDRESS>I have followed a similar procedure to label attack-related entities, but just in the dataset of cadets I get 5655477 entities related to attack. I think this number is too big and needs some cutting operations.


Update README.md

Updated the section about Axitrader to reflect the rebranding of Axitrader to Axi.

[ x] New link
https://www.axi.com/
Updated the link since the company rebranded and had a new homepage URL

Other improvements?

[ ] Bug fix/Broken link
[ ] Improve this list

By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it twice.
Requirements for your pull request

I have read and understood the contribution guidelines.
This pull request has a descriptive title.For example, Add Name of Link, not Update readme.md or Add Nice Link.
The entry in the Awesome list should:

Include a short description about the project/theme of the link.
Be added at the bottom of the appropriate category.

The link I added is not a duplicate
The link that I add does is not affiliate link, faucet, ICO, Airdrop nor ponzi stuff.

Thank you, appreciate it!
Matthew Smoothy | Search Engine Optimisation Manager
d +61 2 8037 7302 | o +61 2 9053 4920
e<EMAIL_ADDRESS>| w www.axi.comhttps://www.axi.com
[Axi]https://www.axi.com/
[Axi Awards]https://www.axi.com/our-edge/award-winning-service
[Manchester City]https://www.axi.com/company/sponsorship
[Facebook]https://www.facebook.com/axi/
[Twitter]https://twitter.com/axi_official
[LinkedIn]https://www.linkedin.com/company/axitrader
[Youtube]https://www.youtube.com/channel/UChiU8ItCQKnGtr4VQlG4suA
[Telegram]https://telegram.me/axi_official
This email and any attachment is confidential. If you are not the intended recipient, please delete this message.
Click here for Axi's electronic communications disclaimer<www.axi.com/legal-documentation/email-disclaimer>
From: Alvaro Yanes Basanta @.>
Sent: Sunday, 30 May 2021 8:37 PM
To: 0xtokens/awesome-blockchain @.>
Cc: Matthew Smoothy<EMAIL_ADDRESS>Author @.***>
Subject: Re: [0xtokens/awesome-blockchain] Update README.md (#3)
ATTENTION: THIS IS AN EXTERNAL EMAIL - Be Suspicious of Links, Attachments and any requests for login information
Merged #3https://github.com/0xtokens/awesome-blockchain/pull/3 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/0xtokens/awesome-blockchain/pull/3#event-4816979321, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASZQI5NOFSL5YX6DABHUTGDTQIIL7ANCNFSM4XMLCEJA.
Matthew Smoothy | Search Engine Optimisation Manager
d  | o +61 2 9965 5830
e<EMAIL_ADDRESS>| w www.axi.com
This email and any attachment is confidential. If you are not the intended recipient, please delete this message.
Click here for Axi's electronic communications disclaimer


manifest: upmerge to SOF fcd3f18b3

Upmerge to SOF fcd3f18b307125fc7a671638d4612ff9ddbe7cb3.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

Hey, this is now failing intel_adsp_cavs25 sample.audio.sof, looks like https://github.com/thesofproject/sof/commit/9948d439d9a9c8deff1e1fceed696fca03c7bcde enabled something that needs a submodule by default. Not sure how to fix this properly, the submodule definition does not even have a full path so it's not like we can add that module as is even if we wanted to.

new entries in manifest already approved: https://github.com/zephyrproject-rtos/zephyr/issues/58212

looks like new entries in west need to be part of the cache!

@fabiobaltieri I reverted back to old commit + your patch and will address the manifest/module issue later.

@gmarull  this now includes your init.h commits as well.

@gmarull this now includes your init.h commits as well.

thanks


"ansible_checkpoint_domain" variable doesn't work.

According to the existing documentation you can switch domains by making use of the variable "ansible_checkpoint_domain" but that doesn't work, instead what's happening is the API calls are going locally.
Apparently my parameters are be fine because if I try the same from Postman the changes are reflected as expected.
ansible 2.9.7
- name: example_playbook
  hosts: check_point
  connection: httpapi
  tasks:
    - name: set-service-tcp
      cp_mgmt_service_tcp:
      name: %SERVICE%
      ...
      auto_publish_session: yes

    vars:
      ansible_checkpoint_domain: "%DOMAIN%"

Hi @gmoraa
Which version of the collection are you using?

@chkp-orso "api-server-version": "1.5"

@gmoraa Thanks, but this is the version of the API server.
I meant do you use the Ansible core or the collection?
If you use the collection, which version?

Hi,
We have the same issue here with Ansible 2.9.10 and Checkpoint R80.40.
Is there any solution to specify domain in MDS environment ?

@gmoraa Thanks, but this is the version of the API server.
I meant do you use the Ansible core or the collection?
If you use the collection, which version?

@chkp-orso Sorry for the late reply, I missed your message. I am using Ansible Core 2.9.7 and CheckPoint R80.30.
Let me know if more details are required.

Hi,
I am facing the same problem when using the included collection in Ansible 2.9.7.
When Im using the Collection explicitly (version 1.0.5), its working.
I thought that I would also need to include the collection with
collections:
  - check_point.mgmt

and then use
check_point.mgmt.MODULE instead of MODULE
but it looks like only changing
ansible_network_os: checkpoint to ansible_network_os: check_point.mgmt.checkpoint
is enough.

Hi,
That's OK @gmoraa :)
You need to use the latest version of the collection.
@alex-barth I highly recommand that you use also the collections' modules (with your trick you use only the collection plugin)
Thanks,
Or

@alex-barth,

When Im using the Collection explicitly (version 1.0.5), its working.

so, you are saying that you need to install an "extra" collection ?
Because i tried to simply replace ansible_network_os: checkpoint to ansible_network_os: check_point.mgmt.checkpoint not enough...

@alex-barth
I'm not sure I understood your question.
But at the bottom line you just need to use the collection.

But at the bottom line you just need to use the collection.

The collection is not natively installed with ansible 2.9?

No :(

So, the native modules in Ansible 2.9 stands for what purpose ? I have also installed the SDK module check_point_mgmt from your GitHub https://github.com/CheckPointSW/cpAnsible . Have you documentation for the installation ?
Thanks !

you don't need https://github.com/CheckPointSW/cpAnsible
you just need this collection

@chkp-orso

@alex-barth I highly recommand that you use also the collections' modules (with your trick you use only the collection plugin)
Yes, sorry for creating confusion, I just wanted to narrow down the problem. I am actually also using the collection modules.

Thanks
Alex

Thank you for using our Ansible-Check Point integration.


Assert fail (crash) when using basic_parser with unicode encoded characters

Version of Boost
1.80
Steps necessary to reproduce the problem
#define BOOST_JSON_STACK_BUFFER_SIZE 32
#include "boost/json/basic_parser_impl.hpp"
#define BUFFER_SIZE BOOST_JSON_STACK_BUFFER_SIZE

struct TestParser
{
  TestParser() {};
  // basic parser dummy implementation
  bool on_document_begin(error_code& ec) { return true; }
  // [...]
};

void testBasicParser() {
  std::string test = R"({"test":"test1tes2test3test\u2019test7test8test9test1test2test3test4test5test6test7test8})";

  boost::json::parse_options options;
  boost::json::basic_parser<TestParser> parser(options);
  boost::json::error_code ec;
  std::stringstream input(test);
  char buffer[BUFFER_SIZE];
  while (!input.eof()) {
    input.read(buffer, BUFFER_SIZE);
    parser.write_some(true, buffer, BUFFER_SIZE, ec);
  }
}

The assert is hit by the temp.push_back() in basic_parser::
parse_escaped (https://github.com/boostorg/json/blob/develop/include/boost/json/basic_parser_impl.hpp#L1680).
It occurs because the encoded character is split into the two buffer (the first buffer end precisely in the middle of the unicode encoded character). The buffer start with the full unicode character (3 character) but the input still contains 30 characters while the temp buffer only allows 32.
I reproed the issue initially with the default BOOST_JSON_STACK_BUFFER_SIZE on iOS seldomly while processing some large json payloads.
All relevant compiler information
Build with BOOST_ALL_NO_LIB on Windows. Also occurs on iOS with the default BOOST_JSON_STACK_BUFFER_SIZE (256) value.

@guboulan can you check if #877 fixes your problem?

@grisumbras It does fix my issue. Thanks!


Captcha Response Code 200

System giving this error on lastest Windows 10 OS while booking.

This is not an error. You should see another window with captcha popping up.

Great work on the implementation!
The UMANG api, however does not require a captcha for booking vaccine slots.
You can try this project out: Co-WIN-automated-slot-booking.

thanks for that dude! they just removed captcha from cowin but reduced rate limter

any workaround for that in umang?

The rate thing is not an issue. The maximum number of requests is directly linked to the token generated in UMANG - if tokens are generated more frequently, the rate can be increased. Have incorporated this change into the code in the latest commits. :)

@rayarindam2111 thanks for the work dude. Your extension works has been working flawlessly for me.

@rayarindam2111 thanks for the work dude. Your extension has been working flawlessly for me.

Thanks, man!


Brave Otel Encoder implementation (continuation of #4)

Addressed the review comments in #4.

@making I think trying to salvage #4 is a a cure worse than the disease. Can you set the target branch to main and just limit this to the encoder implementation? If you have a tidy (like license header change which is on main), go ahead and raise that and lets merge that quick to reduce the scope of this.

also, let's make this a single commit as basically if this were someone else, they would just make a new PR as that's easier, and that would be 1 commit. Dozens of commits explains #4 maybe, but that isn't the goal of the work. The goal is to make an encoder and imho the prior impl makes that harder to understand than starting fresh.

Ok, I will do that

superceded by #9


fix: toClassObject method to return correct type in case of parameterised type

Fix an issue,  where I was expecting MyEvent as payload type but instead I am getting org.springframework.messaging.Message as payload type which is wrong
below is the signature of my consumer
@Bean
public Consumer<Message> consumeEvent() {
}

Hi @SheheryarAamir, thanks for creating this PR!
Reading the issue description, it seems like your problem is specifically with the Generic payload type when using Spring's Message<T> class.
I believe the use of this class is a special case, and we would probably not want to address every use of generic payload like we would address the use of Message<T>.
I added some comments in the code that may help you improve this PR with the aim of solving your issue.
Thanks and please let us know if you have any other question or need any help.


Create user facing function for getJP2Image

In the end, the user should be able to interact with hvpy by executing the following:
import hvpy
result = hvpy.getJP2Image(date="2014-01-01T23:59:59Z", sourceId=14)

We need to implement this front end to encapsulate constructing parameters and calling the API.

So what we have in the test_get_jp2_image.py
example this:
    date_obj = datetime(2022, 1, 1, 23, 59, 59)
    params = {"date": date_obj, "sourceId": 14, "jpip": True, "json": False}
    params = getJP2ImageInputParameters(**params)
    response = execute_api_call(input_parameters=params)
    assert isinstance(response, str)
    assert response.startswith("jpip://")

The function execute_api_call will work under the hood for the users, right?

Users would not need to call execute_api_call.

For this let's create a facade.py that defines these front end calls for the API functions.
They should just define the API function with all the input parameters as arguments to the function, construct the appropriate input parameters class (I'm wondering if we would be able to just pass **kwargs to the Input classes). And then execute_api_call

We can also decide to enforce that all arguments have to be passed in as keyword arguments.