nixos/locate: clarification in warning message

Description of changes
Just makes it clear that plocate also does not support the localuser option, very minor change, I just got confused about it.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@SuperSandro2000


Library crop does not work when maxNumberOfItems = 1

Describe the bug
Cropping from the Library picker only works when . This does not impact the showsCrop = true UI.
To Reproduce
Steps to reproduce the behavior:

config.library.maxNumberOfItems = 1
Pick an image from the Library
Zoom into part of the image from the Library picker
Original image is returned, crop/zoom is ignored

Installation Type

Manual

Additional context
This can be fixed by removing the check for "strongSelf.multipleSelectionEnabled" in YPLibraryVC.swift:85

@calsmith this is now live in https://github.com/Yummypets/YPImagePicker/releases/tag/3.5.3, thanks a ton for your help on this release 🚀


On Android Clicking on notification bar not opening the app.

Having the same issue, any solution?

Any Updates on this issue? @jeromexiong


Revert "Implement Caddy-Sponsors HTTP response header"

This reverts commit 56453e9664aa2c24115eb52a4e933febb3cac1f7.

1. What does this change do, exactly?
It reverts the implementation of the Caddy-Sponsors HTTP response header.
2. Please link to the relevant issues.
56453e9
3. Which documentation changes (if any) need to be made because of this PR?
None.
4. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I am willing to help maintain this change if there are issues with it later

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Duplicate of https://github.com/mholt/caddy/pull/1866, so I'm closing this one.


Set up randomly spawning power-ups

References #287

Spent an hour trying to get the power ups to just spawn randomly, ran into some issues that I'll work on later.

Spent an hour and a half with, running into issues where the powerups all spawn at once so it's hard to change individual powerups, unless I'm missing something.

Put another hour in this morning. No solutions currently. Going to talk to team about it soon!

Got a working solution! Now on to have it only spawn randomly on hard difficulty.

The random spawning now works only on hard difficulty. This was a rough task due to a lack of documentation by the previous teams and maybe a bit of my own incompetence. Regardless, I'm happy I got this working on time! Putting together all the hours for this task, it was about 4 and a half hours total.


Replace linked file on smart object layer

<psdimage: size=495x425, layer_count=2>
  <smartobject: u'Design', size=183x324, x=15, y=45, mask=<mask: size=371x388, x=107, y=21>, linked=<u'CustomDesign.png', type=data, 30796 bytes>>
  <pixel: u'Mug', size=373x392, x=107, y=19>

Currently write/edit support is not available for smart objects

is there write/edit support yet?

Is this request still not ready? I am also looking for solution to change / replace linked file to an external file with psd-tools Python script.

Hey guys, did you have a chance to try Dynamic Mockups?
They implemented an application and API that recognizes smart objects from PSD mockups and give you possibility to define colors and design assets for each of them. There is a great feature that create output variations across all smart objects and their colors and asset deisgns.

"They". You are part of Dynamic Mockups project based on this: https://www.linkedin.com/posts/dynamic-mockups_jako-smo-ušli-u-ovu-godinu-dynamic-mockups-activity-7162909515003240453-34f8
So this comment is an own ad. It's not a problem, but I don't find pricing on website.

Is this request still not ready? I am also looking for solution to change / replace linked file to an external file with psd-tools Python script (or any other automated script).

Hey did you find any solution?


Monocle Mode

Is there a monocle mode with kwin-autotile?

No, and there most likely won't be one unless Kwin itself supports it.


Medium severity issues flagged by gosec are resolved

AC:

[ ] Scan the project with gosec
[ ] Resolve any medium (or higher) severity issues

optionally, you can add gosec scanning to our pipeline and fail builds with HIGH or CRITICAL severity issues, and save the output of the scan so that it can be reviewed in Jenkins.


Investigate usage of Logging.framework on iOS 13

http://codeworkshop.net/objc-diff/sdkdiffs/macos/10.15/Logging.html
This is for macOS, but it could exist as private API on iOS 13.

Not possible on iOS due to entitlement requirement.


Can't update NPM version (EACCES permission denied)

Version
Microsoft Windows [Version 10.0.19041.1288]
WSL Version

[ ] WSL 2
[X] WSL 1

Kernel Version
Linux version 4.4.0-19041-Microsoft<EMAIL_ADDRESS>(gcc version 5.4.0 (GCC) ) #1237-Microsoft Sat Sep 11 14:32:00 PST 2021
Distro Version
Ubuntu-20.04
Other Software
No response
Repro Steps
In wsl terminal:
nvm install-latest-npm
Expected Behavior
NPM is installed/updated to latest supported version
Actual Behavior
Command exits out with this output:
npm ERR! code EACCES
npm ERR! syscall rename
npm ERR! path /home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/npm-5bc2ba18/node_modules/string-width
npm ERR! dest /home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/string-width-27ab7c66
npm ERR! errno -13
npm ERR! Error: EACCES: permission denied, rename '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/npm-5bc2ba18/node_modules/string-width' -> '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/string-width-27ab7c66'
npm ERR!  [OperationalError: EACCES: permission denied, rename '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/npm-5bc2ba18/node_modules/string-width' -> '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/string-width-27ab7c66'] {
npm ERR!   cause: [Error: EACCES: permission denied, rename '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/npm-5bc2ba18/node_modules/string-width' -> '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/string-width-27ab7c66'] {
npm ERR!     errno: -13,
npm ERR!     code: 'EACCES',
npm ERR!     syscall: 'rename',
npm ERR!     path: '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/npm-5bc2ba18/node_modules/string-width',
npm ERR!     dest: '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/string-width-27ab7c66'
npm ERR!   },
npm ERR!   errno: -13,
npm ERR!   code: 'EACCES',
npm ERR!   syscall: 'rename',
npm ERR!   path: '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/npm-5bc2ba18/node_modules/string-width',
npm ERR!   dest: '/home/alexbu92/.nvm/versions/node/v14.18.1/lib/node_modules/.staging/string-width-27ab7c66'
npm ERR! }
npm ERR!
npm ERR! The operation was rejected by your operating system.
npm ERR! It is likely you do not have the permissions to access this file as the current user
npm ERR!
npm ERR! If you believe this might be a permissions issue, please double-check the
npm ERR! permissions of the file and its containing directories, or try running
npm ERR! the command again as root/Administrator.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/alexbu92/.npm/_logs/2021-10-29T14_04_41_047Z-debug.log
* npm upgraded to: v6.14.15

Update: Don't know if it matters but whereis npm gives me this:
alexbu92@LAPTOP-R8SQE3K7:/mnt/c/Users/alexb$`` whereis npm
npm: /usr/bin/npm /usr/share/npm /home/alexbu92/.nvm/versions/node/v14.18.1/bin/npm /mnt/c/Program Files/nodejs/npm /mnt/c/Program Files/nodejs/npm.cmd /usr/share/man/man1/npm.1.gz

Diagnostic Logs
No response

Thanks for reporting this @alexbu92. It looks like a linux permission issue.
Does running the same command as sudo works ? If so the issue is most likely that some of the files under /home/alexbu92/.nvm are not writable by your user.

Sudo doesn't work, gives nvm: command not found.

Looks like nvm isn't in the $PATH for sudo. You might need to call it with its full path. You can get it with whereis nvm

I also have the same issue:

ERR_PNPM_LINKING_FAILED  Error: EACCES: permission denied, rename

Literally cannot use pnpm in WSL, at all.


Add zsh completion

Hi @majjoha 👋
Thanks for building this neat little utility.
I've added zsh completion to spare few keystrokes and improve command discoverability 🎉

Hi @vladimyr,
You're welcome, and thank you for your pull request. It definitely looks like a useful addition. It might be worth adding completion for Bash in the future too.
My experience with zsh completion is fairly limited but I'd say it looks good. Where would I need to put the script in macOS to test it? Also, would you mind replacing the text in the commands variable so it is consistent with the information in voxctl help? I think it just needs to look like this instead:
'start:Starts VOX'
'quit:Quits VOX'
'play:Begins playback'
'pause:Pauses playback'
'togglePlay:Toggles playback between playing and paused ''
'next:Skips to the next track in the playlist'
'previous:Skips to the previous track in the playlist'
'shuffle:Toggles shuffle on or off'
'playUrl URL:Plays the specified URL'
'addUrl URL:Adds the specified URL to the playlist'
'rewindForward:Rewinds the current track forward'
'rewindForwardFast:Rewinds the current track forward fast'
'rewindBackward:Rewinds the current track backward'
'rewindBackwardFast:Rewinds the current track backward fast'
'increaseVolume:Increases the volume'
'decreaseVolume:Decreases the volume'
'togglePlaylist:Shows/hides the playlist'
'info:Displays information about the current track in JSON'
'isRunning:Prints true if VOX is open, otherwise false'
'help:Prints this information'

Thank you once again!

It might be worth adding completion for Bash in the future too.

I'm learning how to do that. Being primarily zsh user I didn't actually have a need to write one 🙃

Where would I need to put the script in macOS to test it?

The canonical place would be /usr/local/share/zsh/site-functions/ but you can simply source it for testing purposes.

Also, would you mind replacing the text in the commands variable so it is consistent with the information in voxctl help?

Sure, I've changed it to match what I'm seeing elsewhere but keep in mind that help needs to be altered because there is no this information in completion context. A possible alternative would be: help:Prints help, what do you think?

I'm learning how to do that. Being primarily zsh user I didn't actually have a need to write one 🙃

I am also a zsh user so perhaps it might be worth simply adding an issue and see if somebody else would be up for adding it.

The canonical place would be /usr/local/share/zsh/site-functions/ but you can simply source it for testing purposes.

Perfect. It seems to work great on my end. :-)

Sure, I've changed it to match what I'm seeing elsewhere but keep in mind that help needs to be altered because there is no this information in completion context. A possible alternative would be: help:Prints help, what do you think?

Good point! help:Prints help sounds good to me.

Command descriptions updated ✅

Thank you!

@vladimyr: I've updated the Homebrew formula so it now points to the latest version. The zsh completion script seems to be added correctly to /usr/local/share/zsh/site-functions but I am not experiencing any tab completion for voxctl. Does it work on your machine with the new formula? It may simply be an issue with my local zsh configuration.

@majjoha Issue you are experiencing is caused by me not respecting compinit conventions. Long story short I had to put following in the first line:
#compdef voxctl

PR is on the way 🛫

Thank you for your great work!


Puppet Accounts

Context
The puppet account model discussed here is conceptualized in the context of game development on Flow.
Fundamentally, games involve game assets and performing some action with those assets. For an on-chain smart contract-powered game on Flow, game assets - be they decks, armies, dice, vaults, etc. - could naturally be represented by resources. And on-chain actions, or game moves, can be performed via signed transactions.
Before gaming can makes its home on Flow, we need to work out where those game assets live in and out of game play, who makes changes to those assets, who signs move transactions, and how do we make gameplay as seamless as possible while protecting players’ assets from both malicious actors and cheaters.
This document attempts to introduce a model that will address some of these questions, namely where the assets live out of gameplay, making gameplay seamless, and minimizing risk to players’ assets. Other questions are addressed at the layer of gameplay mechanics and on/off chain architecture.
Problem
The puppet account model attempts to ameliorate multiple problems present in the space of mobile blockchain gaming. Broadly, there is a tension between a smooth UX free from the friction of frequent transactions and user security.
Under current account paradigms, we expose the whole of users’ assets to risk of theft while optimizing for seamless gameplay by, for example, allowing game clients to sign transactions on behalf of a player to submit moves. When optimizing for security, users are required to sign a transaction any time they want to do something in the game.
This problem is more pronounced on mobile experiences where users would have to switch between applications to execute transactions.
This friction leads blockchain-focused game developers to commit to the chain as infrequently as possible, minimizing the purpose of the chain to a simple audit log. Reduction to on-chain interaction friction will be necessary if we are to realize the emergent benefits of on-chain gaming, namely composability, interoperability, transparency, and verifiability among others.

Objectives

Expose only those assets relevant to the game in question to custody risk - access resources on a need-to-custody basis
Minimize the number of transactions users must submit within the span of a game match, aiming for at most 1 initial transaction
Ease of onboarding to a new game, seeding accounts with necessary assets to start playing
Introduce a backend-less architecture, minimizing the load on game devs and encouraging an ecosystem of diverse game clients and secure user experiences

Open Questions

How do we represent a puppet vs. a main account?

Needs to be known by

Game client
Wallet

How do we represent a link between a user’s main account and it’s puppet accounts?

Needs to be known by

Game client
Wallet

How do we mediate access to the assets contained in a puppet account that grant user’s ultimate authority?

Possible solutions

Capability
Key management & weighting

In the context of gaming - how do we associate a puppet account with a specific game?

Most important question is who owns what; game assets on puppet account, especially the puppet account as a whole.
What about unlinked puppets?
I think this is very tricky subject, few things has to be considered. What can be the unintended consequences of puppet accounts? We design them for games, but what if let's say some classic dapp ( crypto kitties ) use this pattern? Problem is some game on chain and some nft project has very different needs. Needs involve control power, powerful alternative takes over.
Also there is a big risk of 'inception' with composability, A requires puppet account to function, B also requires same. User D, wants to use A, A would like to use B for some parts. D creates puppet for A, puppet P1, then A goes a create a puppet for P1 on B, P2 ...

Closing as this has become walletless-arcade-example.


test: behaviors-message_on_lock_failure (2024-02-21 22:45:45.094757+00:00)

automatic test cleanup


Loosen gem requirement on I18n

Coverage remained the same at 90.198% when pulling 68a55a3bec08f82e305f12f6f42fc4013fee62b7 on johnnyshields:patch-3 into ecb84cc6d2f05bd75a4125b7494a058ed702279e on middleman:master.

Is this blocking something?

I came across this when I was trying to add rails and middleman in the same ruby project.


Future Development: Add Map Capabilities!

It would be fantastic to add mapping capabilities to track geographic locations of:

Partner Agencies
Donation Drop-off Locations

Why is this significant?
Overall, this helps diaper banks quickly assess impact. Tracking locations of partners within our service area provides us with a quick  snapshot of current clients served, potential demographics, and allows us to plan our growth more strategically. Tracking donation drop-off locations allows us to quickly see locations in the city that potentially need more donation sites; this increases convenience for our donors, therefore increasing overall donations and exposure of the organization/mission.

Closing for #440


Object.freeze doesn't work on doc

I noticed the following issue while trying to take automerge-wasm/automerge-js into use: Object.freeze doesn't work on the proxified doc.
Here's a repro (in Node v16.13.1),
const Automerge = require("automerge-js");
const wasm_api = require("automerge-wasm");

Automerge.use(wasm_api);
const doc = Automerge.init();
Object.freeze(doc);

and the error is:
index.js:6
Object.freeze(doc);
       ^

TypeError: 'ownKeys' on proxy: trap result did not include 'context'
    at Function.freeze (<anonymous>)
    at Object.<anonymous> (index.js:6:8)

Longer story: I'm using Redux Toolkit, which uses Immer, which tries to do a deep Object.freeze() (by default) on the entire Redux state. I have a combination of normal JS objects and Automerge docs in the Redux state, so that's how I ran into this problem.

The version you are using uses a proxy object for the document so it cannot be frozen.  The newer version (in alpha) is being published as the package @automerge/automerge comes with a bunch of differences.  First it does not require manually attaching the wasm backend as it is now integrated.  Second the document is a normal javascript object updated incrementally instead of a proxy and will be able to be used directly in something Redux as === will now work.  The Automerge.init({ freeze: true }) currently only freezes the top level object but I just opened a PR to properly carry it down to all the sub objects.  I expect this to be merged Monday and a new package to be published then.
https://github.com/automerge/automerge-rs/pull/444
If you try this package please let us know how it goes for you. =)


Semicolon ":" Take alias bug in template

Describe the bug
When a semicolon is used in a @template as an alias for Take, it will give an error
"Could not infer an output type and no Default value provided." where it does not recognise the variable that it is taking from
To Reproduce
Expected behavior

With this example, the first take when explicit works fine, but the second take using the semicolon throws the error
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context

Actually didn't you fix those @guusw ? Or not for template?

Also, another issue with : is that it assumes it's a string, so won't work with variables


[SPARK-7778][SQL] Add standard deviation expression over data frame

The aggregate function implementation is based on online variance calculation
http://en.wikipedia.org/wiki/Algorithms_for_calculating_variance
The partial evaluation is a naive variance computation.

Can one of the admins verify this patch?


[Question] Will there be a similar equivalent  androidx.lifecycle:lifecycle-viewmodel  implemented before Compose for iOS to Beta?

There is the roadmap list that Make all Jetpack Compose core APIs and components multiplatform.  I want to know which components are expected to be implemented on compose for iOS.
Especially about Lifecycle and ViewModel.
Since UIKit does not have very good lifecycle distribution capabilities, it is relatively painful to implement on iOS systems. At the same time, MVVM is also a mainstream UI implementation method. I would like to know what Compose-multiplatform's plan is for this piece?

Although the ViewModel, ViewModelStore, etc. are cross-platform, there is no intermediate layer between the iOS View and ViewModel, such as getting iOS association to the iOS lifecycle ViewModel in the Compose world through Mediator

Would like to have a lifecycle-awared view model store rather than current one.
It can get benefit from ARC of object-c to call ViewModelStore.clear() when a controller is nolonger needed.

I would like to know what Compose-multiplatform's plan is for this piece?

The initial version should be already available in the latest dev build

we look forward to Navigation becoming multi-platform as soon as possible.

The initial version should be already available in the latest dev build too

getting iOS association to the iOS lifecycle ViewModel in the Compose world through Mediator

Yes, it's how Compose provides it for its content

Would like to have a lifecycle-awared view model store rather than current one.

Mentioned implementation is just default one, it might be overridden by composition local (navigation library should override lifecycle and VM storage). Since we have nothing that we control above Compose the only alternative for is throwing the error by default and require explicit initialization. We cannot do anything with in in compose itself because we're not going to add viewmodel to dependencies to Compose. Please note that it's subject to change, not having "global"/any storage by default is a good candidate.

It can get benefit from ARC of object-c

Good theory, but it won't work due to captured references in kotlin runtime/GC itself. @elijah-semyonov is an expert here
Closing, as I replied to initial question.

we look forward to Navigation becoming multi-platform as soon as possible.

The initial version should be already available in the latest dev build too

This does not seem right https://issuetracker.google.com/issues/281774647

@Ribesg we're not going to upstream KMP navigation to Google's AOSP repo

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


tf.keras.utils.get_file() produces duplicate file with dot underscore "._"

How do I prevent the untar from the above get_file() call from creating duplicate "._*" files?
I get double the images in the dataset when I run the following, and the duplicated images have a prefix of ._
import pathlib
import matplotlib.pyplot as plt
import numpy as np
import PIL
import tensorflow as tf
from tensorflow import keras
from tensorflow.keras import layers
from tensorflow.keras.models import Sequential
custom data attempt
weeds_dataset_url = "https://storage.googleapis.com/aquarium-public/datasets/deepweeds/full_image_set/weed_images.tgz"
weeds_data_dir = tf.keras.utils.get_file('weed_images', origin=weeds_dataset_url, untar=True)
weeds_data_dir = pathlib.Path(weeds_data_dir)
snake_weeds = list(weeds_data_dir.glob('Snake weed/*'))
print(snake_weeds[0]) # gives me a file starting with ._

Still an issue

@pocathoughts,
I tried to execute the code and was able to save the images without any issues. And also those images are being saved in the expected format. Kindly find the below image for the reference. Please try to clear the cache and try to save the images. Thank you!


Adding CommandOptions to branch requires options to be defined BEFORE subcommands

Information

OS: Windows
Version: Commit: e4dda28
Windows terminal

Describe the bug
Adding CommandOptions to branch requires options to be defined BEFORE subcommands
To Reproduce
Use Demo project and extend AddSettings with this:
        [CommandOption("--quiet")]
        [Description("Quite mode")]
        public bool Quiet { get; set; }

> Demo.exe add wo package pkt --quiet
┌──────────────────┬───────┐
│ Name             │ Value │
├──────────────────┼───────┤
│ PackageName      │ pkt   │
│ Version          │ null  │
│ Framework        │ null  │
│ NoRestore        │ False │
│ Source           │ null  │
│ PackageDirectory │ null  │
│ Interactive      │ False │
│ Project          │ wo    │
│ Quiet            │ False │
└──────────────────┴───────┘

Quit is here FALSE even though I clearly gave it as an option to the command.
Demo.exe add wo --quiet package pkt
┌──────────────────┬───────┐
│ Name             │ Value │
├──────────────────┼───────┤
│ PackageName      │ pkt   │
│ Version          │ null  │
│ Framework        │ null  │
│ NoRestore        │ False │
│ Source           │ null  │
│ PackageDirectory │ null  │
│ Interactive      │ False │
│ Project          │ wo    │
│ Quiet            │ True  │
└──────────────────┴───────┘

Gives Quite = true
Expected behavior
I expected CommandOption:s can be assigned anywhere on the commandline. I´ve never seen CLI:s requiring this strict order.
With CommandArguments it's might be more intuitive to assign arguments to each command in order: "X arg1 arg2 Y arg1 arg2". But this cant be the case with options. Examples of usages would be great on the https://spectreconsole.net/cli/composing page

@Goffen Thanks for reporting this. Will take a look at it closer when I have some spare time.

I looked through the codebase and think the problem exists because the way the parser currently works. It walks the commandtree and consumes the tokensteam on the way. Options are only mapped when they are found on the current command or match the help-option https://github.com/spectreconsole/spectre.console/blob/0bf97cb66699369559de8bbfe02f048504db28d3/src/Spectre.Console/Cli/Internal/Parsing/CommandTreeParser.cs#L246-L290
The solution that i came up with is walking back the commandtree up to the root, when parsing options (Maybe only in RelaxedMode) - would this be a good solution?

I'm also running into this issue at the moment, still very annoying to find out.
This also impacts the --help option, it does not display commandoptions from the branch the command is in.

scratch that!
In my (and maybe other users running into this) use case it's enough to remove the settings from the branch, now the order and help of each command works as expected.

@PsychoNineSix Id suggest that it is also valuable to want to place the settings on the branch, and expect the Argument to show as you had originally expected (per --help options) as the argument applies to all subcommands - so I'd say un-scratch!
I assume it is "not normal" to have branch options separated from their sub command options as today all the options are moved to the end regardless of what part of the setting call hierarchy they are in - this implies that there are multiple sets of options, those as part of the branch and this and part of the selected sub command one is looking at --help for?


GROOVY-8069: Annotation based logging of complex expression in closur…

…e throws GroovyCastException with SC.

+1


[8.x] Honor recipient limit with AWS SES Mail Transport

After upgrading to Laravel 9.x, bcc in our application stopped working
with the SES email transport. After reviewing the migration/upgrade
documentation and the code differences from 8.x -> 9.x, it's clear the
change in mailers likely exposed this; however, I also noticed a couple
fundamental, mechanical issues with the implementation:

Lack of Destinations specified in the array
No adherence to the 50 recipient limit of SES

I've corrected both of those and this is the merge for 8.x
See Also: https://docs.aws.amazon.com/ses/latest/APIReference/API_SendRawEmail.html
See Also: https://docs.aws.amazon.com/aws-sdk-php/v2/api/class-Aws.Ses.SesClient.html#_sendRawEmail
See Also: https://docs.aws.amazon.com/ses/latest/dg/quotas.html

Looks like my naive array_merge attempt wasn't good.

(Hang on here for a day, I'll find the answer and tack on a commit)

Probably the array merge didn't work because of keys. Try jamming it through array_values. When the input is a list, array_merge concats all the things.

I'm honestly not even sure this is a bug. We probably shouldn't artificially try to support this stuff, otherwise people could get cced in emails with no to address. Very confusing. We should maybe leave this up to application code to decide how to chunk up the recipients, instead of the framework taking this decision for them.

Probably the array merge didn't work because of keys. Try jamming each arg through array_values, first. When the input is a list, array_merge concats all the things.

The error in the tests seemed to indicate that $message->cc was 'null'. I'll try to work with it and find the right coordinates or generator to get real addresses.

I'm honestly not even sure this is a bug. We probably shouldn't artificially try to support this stuff, otherwise people could get cced in emails with no to address. Very confusing. We should maybe leave this up to application code to decide how to chunk up the recipients, instead of the framework taking this decision for them.

I doubt this is the MUA experience on the end, the payload is the same in SMTP, it just overrides their relay how to proceed. I'll run some SES tests though to confirm (setting chunk to 1 with a To and a Bcc).

We should maybe leave this up to application code to decide how to chunk up the recipients, instead of the framework taking this decision for them.

I'd be leery of having my application code condition based on transport and know/behave different based on the inner workings of the APIs/implementations (sendmail versus mailgun versus SES).

Does mailgun actually support a large number of ccs, or does it just silently drop them on the floor?

Does mailgun actually support a large number of ccs, or does it just silently drop them on the floor?

It was an example only to illustrate how hairy it could get, I only know SES, sorry.

I'm honestly not even sure this is a bug. We probably shouldn't artificially try to support this stuff, otherwise people could get cced in emails with no to address. Very confusing. We should maybe leave this up to application code to decide how to chunk up the recipients, instead of the framework taking this decision for them.

There's some interesting commentary here to this effect:
https://community.sophos.com/utm-firewall/f/mail-protection-smtp-pop3-antispam-and-antivirus/85124/smtp-proxy---sending-email-to-50-recipients-split-into-several-smtp-envelopes
That, in general, mailers should support up to 100 RCPT and it's just unique that SES sets limit to 50. Without extra testing, I do think we'd see some awkward behavior.
I actually think I'd want to defer this 8.x fix altogether and focus on the BCC breakage in 9.x.

Closing this one as the 9.x equivalent was rejected as well. It's best to solve this one in userland I think.


Laura.hampton/envoy additional metrics

In progress, please don't merge
What does this PR do?
Adds additional metrics to the Envoy integration
Motivation
Customer request
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Hi @lgh2 👋  FYI code freeze is coming this Friday and we will release the integrations right after. Let us know if you want this to be shipped with 7.40 and if you need help with @yzhan289's comments

As discussed with @lgh2, I'm taking care of this one 🙂

See https://github.com/DataDog/integrations-core/pull/14088 and its description.


Add Getting started to README

README.md
Please update the README.md file to add Getting Started content.

I have update the README.md file.


Handle 404

Codecov Report

Merging #171 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           develop    #171      +/-   ##
==========================================
+ Coverage    95.78%   95.8%   +0.02%
==========================================
  Files           37      37
  Lines         1233    1239       +6
  Branches        78      78
==========================================
+ Hits          1181    1187       +6
  Misses          41      41
  Partials        11      11

Impacted Files
Coverage Δ

datahub/v2/exceptions.py
100% <100%> (ø)
:arrow_up:

datahub/v2/repos/service_deliveries.py
100% <100%> (ø)
:arrow_up:

datahub/v2/parsers.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5376de...a45ab95. Read the comment docs.


Errors in the webpack2 System. In the import ()

Using webpack2 System. In the import of routing getComponent = {} encapsulated into a function, then the external responsible for according to the path to return to, this way will appear in the compilation errors
    const getComponentLazily = (url,name = "default")=>{
            return (location, cb)=> {
                System.import(url)
                    .then((module)=>{ cb(null,module[name]) })
                    .catch(errorLoading);
            }
        }

render(){
  ...
        <Route path="people" getComponent=     {getComponentLazily('./components/people/people.jsx')}/>
 ...
}

My mistake is WARNING in. / js/SRC/Unique_main JSX
316-16-34 Critical dependency: the request of a dependency is an expression

Please submit support requests and questions to StackOverflow using the tag [webpack]. StackOverflow is better suited for this kind of support. The issue tracker is for bug reports and feature discussions. See also our CONTRIBUTING guidelines.

它为什么会不支持这种写法呢？难道我要在Route每次都写重复的代码吗


import super_gradients error in jupyter notebook while working fine in commmand line

🐛 Describe the bug
While working on this notebook: https://github.com/Deci-AI/super-gradients/blob/master/notebooks/yolo_nas_custom_dataset_fine_tuning_with_qat.ipynb
simple import super_gradients  gived no moule found.
But when opening the same virtual enviroment and  executing the same import it works.
This sounds similar to this closed case: https://github.com/Deci-AI/super-gradients/issues/1294
Versions
Collecting environment information...
PyTorch version: 2.2.1+cpu
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A
OS: Microsoft Windows 11 Pro
GCC version: Could not collect
Clang version: Could not collect
CMake version: version 3.29.0-rc3
Libc version: N/A
Python version: 3.9.18 (main, Sep 11 2023, 14:09:26) [MSC v.1916 64 bit (AMD64)] (64-bit runtime)
Python platform: Windows-10-10.0.22621-SP0
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture=9
CurrentClockSpeed=3301
DeviceID=CPU0
Family=107
L2CacheSize=8192
L2CacheSpeed=
Manufacturer=AuthenticAMD
MaxClockSpeed=3301
Name=AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics
ProcessorType=3
Revision=29697
Versions of relevant libraries:
[pip3] numpy==1.23.0
[pip3] onnx==1.15.0
[pip3] onnxruntime==1.15.0
[pip3] onnxsim==0.4.36
[pip3] pytorch-quantization==2.1.2
[pip3] torch==2.2.1
[pip3] torchmetrics==0.8.0
[pip3] torchvision==0.17.1
[conda] numpy                     1.23.0                   pypi_0    pypi
[conda] pytorch-quantization      2.1.2                    pypi_0    pypi
[conda] torch                     2.2.1                    pypi_0    pypi
[conda] torchmetrics              0.8.0                    pypi_0    pypi
[conda] torchvision               0.17.1                   pypi_0    pypi

Could be ipykernel mismatch.
Make sense to check that first. Please check documentation of Jupyter how to ensure it uses python from correct environment.


Orleans: AdoNet Setup: Migrations scripts are missing from instructions

Type of issue
Missing information
Description
The docs need to instruct the user to also execute the appropriate SQL Migration script from orleans/src/AdoNet/Orleans.Clustering.AdoNet/Migrations/
As currently written, AdoNet MySql silo persistence will fail on await host.RunAsync() with
System.ArgumentException: Not all required queries found.
  Missing are: CleanupDefunctSiloEntriesKey
  at Orleans.Clustering.AdoNet.Storage.DbStoredQueries..ctor(Dictionary`2 queries) in
  /_/src/AdoNet/Shared/Storage/DbStoredQueries.cs:line 39

because the database does not have the CleanupDefunctSiloEntriesKey function defined in the oddly named MySQL-Clustering-3.7.0.sql file (the name of the file has "Clustering" in it when I suspect the filename should actually have the word "Migrations" in it not "Clustering")
Please note there are pairs of files with the same name in different folders in the project, one set that is oddly not grouped under a sub-folder (they are just in the Orleans.Clustering.AdoNet folder), the other set that is under Orleans.Clustering.AdoNet/Migrations. Both sets are have the same filenames (describing them as Clustering scripts) but they have different contents. This naming error(?) may be why the docs are missing the second set. I suspect that the Migrations folder files should be named as Migrations files, and the ungrouped Clustering files should be moved into a Clustering folder, but the docs issue can be resolved simply by referencing the files in the Migrations folder in the docs page.
Page URL
https://learn.microsoft.com/en-us/dotnet/orleans/host/configuration-guide/adonet-configuration
Content source URL
https://github.com/dotnet/docs/blob/main/docs/orleans/host/configuration-guide/adonet-configuration.md
Document Version Independent Id
043150e5-4a08-659e-be27-4ea604fad303
Article author
@IEvangelist
Metadata

ID: b4d713a5-0534-fb39-8c14-311827b58d77
Product: dotnet-orleans

Hi @yoDon - is this something you would be interested in making a PR to update?

Good nudge - at the time I submitted this I didn't feel like I understood things well enough to do so. At this point I'm much more comfortable updating these docs. Will aim for next couple days.

Seems related to #36292


Native support to validate the whole hub manifest via capact validate

Description
In CLI docs, we have:
# Validate multiple files inside test_manifests directory
capact validate pkg/cli/test_manifests/*.yaml

# Validate all OCH manifests
capact validate ./och-content/**/*.yaml

But this shell expansion depends on a given platform, e.g. on our CI it doesn't work: https://github.com/capactio/hub-manifests/runs/2819063889?check_suite_focus=true
Reason
We should implement a native support for validating the whole Hub manifest directory. In that way our documentation will be consistent across all platforms, and we will improve UX. Currently, it's error-prone.

my initial thoughts/options for solving this issue from user-perspective:
example data:
/pkg/sdk/validation/manifest/testdata $ tree .
.
├── invalid-implementation.yaml
├── invalid-interface_json-schema.yaml
├── invalid-interface.yaml
├── invalid-manifest.yaml
├── invalid-type_json-schema.yaml
├── invalid-type.yaml
├── subdirectory_testdata
│   └── valid-interface.yaml
├── valid-implementation.yaml
└── valid-type.yaml

user can specify multiple arguments, each of them is a path to a file or directory

capact manifests validate ./pkg/sdk/validation/manifest/testdata/valid-type.yaml ./pkg/sdk/validation/manifest/testdata/valid-implementation.yaml

If one of the paths in the list, is a directory then there will be a validation for every file within the catalog
for instance:

capact manifests validate ./pkg/sdk/validation/manifest/testdata/

every file from testdata will be validated but with no recursion (without subdirectory_testdata)

There is additionally, the -r parameter for searching recursively,

capact manifests validate -r ./pkg/sdk/validation/manifest/testdata/

every file from testdata will be validated but with recursion (with subdirectory_testdata)
Additionally:

slash in the end is important, ./pkg/sdk/validation/manifest/testdata/ with work compare to ./pkg/sdk/validation/manifest/testdata (error message)
by default, there is searching only for .yaml files from the catalog (perhaps make it configurable?)

Suggestions or comments are welcome :+1:

I like your idea for solving that issue 👍

Additionally:

slash in the end is important, ./pkg/sdk/validation/manifest/testdata/ with work compare to ./pkg/sdk/validation/manifest/testdata (error message)
by default, there is searching only for .yaml files from the catalog (perhaps make it configurable?)

Could you explain why u want to return an error in case of missing / at the end of the directory? AFAIK I don't remember any tool to return an error in such situation. With the os lib we will know whether it's file or dir, and we can trigger a proper logic as you described in the proposal :)
It's good to narrow-down the search criteria 👍 . It can be configurable via flag as you said or just extend search criteria to include .yaml , .yml as those are the most popular extensions for YAMLs. Of course, they can store it even without extension or with .txt but I don't see a valid reason for that, so we can ignore them by default. If you go with CLI flag, make use slice, so the user can pass two exts at once e.g., --ext/--extensions "yaml,yml", as there may be a situation where Hub uses both extensions. It shouldn't, but we know the reality ;)


feat: Add health check for ProcessManager + Sender.

Codecov Report

Merging #95 (8ede195) into main (2e271aa) will decrease coverage by 8.37%.
 Consider uploading reports for the commit 081b067 to get more accurate results

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   80.64%   72.27%   -8.38%
==========================================
  Files          34       40       +6
  Lines         496      642     +146
  Branches       19       20       +1
==========================================
+ Hits          400      464      +64
- Misses         89      172      +83
+ Partials        7        6       -1

Impacted Files
Coverage Δ

source/dotnet/IntegrationEventListener/Program.cs
0.00% <ø> (ø)

...ationTests.Core/TestCommon/WebApi/WebApiFixture.cs
81.25% <ø> (ø)

source/dotnet/ProcessManager/Program.cs
0.00% <0.00%> (ø)

...ource/dotnet/Sender/Monitor/HealthCheckEndpoint.cs
0.00% <ø> (ø)

...e/Fixtures/FunctionApp/SenderFunctionAppFixture.cs
84.00% <84.00%> (ø)

.../Fixtures/FunctionApp/ProcessFunctionAppFixture.cs
90.69% <90.69%> (ø)

...nApp/IntegrationEventListenerFunctionAppFixture.cs
93.22% <100.00%> (ø)

...sts.Core/Fixtures/WebApi/WholesaleWebApiFixture.cs
100.00% <100.00%> (ø)

... and 3 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Add a basic Makefile

I apologize, I am quite the novice when it comes to using github; this is the first time I've made my own repository, and I'm still figuring things out.
I don't understand how your makefile is supposed to work. Is this an operating system specific file?

Please ignore my previous comment, it was a client-side issue for me.

Cool to see the merge. Are there any questions about the makefile I can answer, something you'd like to change?
And welcome to the world of github :D


Traffic shaping wizard

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
Currently OPNsense lacks any wizard to help with traffic shaping and everything needs to be done using pipes, queues manually, I think a wizard akin to pfsense's would help people new to traffic shaping and also have major convenience benefits.

The short answer: a traffic shaping wizard will have to be implemented after the wizard subsystem has been replaced and there is no ETA nor contributor for this.


[function] Add a built-in function

Description
Add a built-in function.
Fixes # (issue)
Type of change (select or add applied and delete the others)

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] API change with a documentation update
[ ] Additional test coverage
[ ] Code cleanup or just sync with upstream third-party crates

How has this been tested?
Checklist

[x ] Fork the repo and create your branch from master.
[x ] If you've added code that should be tested, add tests.
[x ] If you've changed APIs, update the documentation.
[x ] Ensure the tests pass (see CI results).
[x ] Make sure your code lints/format.

Thanks.
You can add this example in the test by adding it here:
https://github.com/apache/incubator-teaclave/blob/51e7ee830dea022b87a758284d3ffb74cd63dadc/cmake/scripts/test.sh#L160
Then run make run-examples to test all examples.

OK, I added this example and all tests passed.

Please use make format to format all rust code.

Thank you for the feedback. All requested changes are addressed now.

Merged. Thanks.


Rename ol_css to css

Title says it all.
Please review.

Makes sense, will see how and when I can update this.

@ahocevar updated as requested. This is ready for review again.
I was thinking of using const, but we do not use it elsewhere, right? E.g.:
// instead of …
export var CLASS_CONTROL = 'ol-control';
// … we could use const
export const CLASS_CONTROL = 'ol-control';

If you want, I can update accordingly

Thanks for the reviews, @ahocevar & @fredj


Fix mouse intereference when performing keyboard navigation

Navigating with the keyboard through the results/matches menu may cause its scrolling. If the last position of the mouse is on top of the menu, then scrolling the menu will trigger a mousemove, mouseenter, mouseover event that is not caused by the user actually moving the mouse. This in turn will focus the item over which the mouse is positioned instead of the item according to the key navigation logic.
This PR addresses the above issue.
Implementation notes
In order to fix the issue the system memorizes the last mouse position on the screen and if a mouse event fires the last position is compared with the current mouse position and if the position hasn't changed, the system can ignore this event as the event must have been triggered by scrolling i.e. movement of the <li...>...<li> menu elements and not the user moving the mouse (i.e. changing its screen position).
For capturing the mouse position, this fix uses the mousemove event instead of the mouseenter event. This is because the mousemove event allows for the immediate interception of a mouse move in case the user initiated the move. If mouseenter was used, then if the starting mouse position was already over a menu li element then mouseenter wouldn't fire for that element and the element wouldn't highlight which is not what the user expects.

Great job, man.

please solve the conflict. I'm trying to switch to gulp and some kinds of browserify tools.

Merged master into the branch


from_zenodo raises excepction

For packages loaded from Zenodo the from_zenodo function raises an exception Not supported Zenodo source 'None' or control.
Here are the steps to reproduce:
python -m venv .
. bin/activate
pip install frictionless==5.0.0b10
pip install frictionless[zenodo]==5.0.0b10
pip install frictionless[excel]==5.0.0b10

from frictionless import Package
p = Package('https://zenodo.org/record/7078768')
p.from_zenodo()

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/zenodo/lib/python3.10/site-packages/frictionless/package/package.py", line 493, in from_zenodo
    raise FrictionlessException(
frictionless.exception.FrictionlessException: [error] Not supported Zenodo source 'None' or control

Thank you for trying this new feature!.
Can you please try as follows and it should work:
package = Package("https://zenodo.org/record/7078768")
print(package)

OR
This is a class method.
package = Package.from_zenodo("https://zenodo.org/record/7078768")
print(package)

The fact that from_zenodo is a class method explains the problem.


feat: add getlen to retrieve length of the value by key

This PR is related to Issue https://github.com/nutsdb/nutsdb/issues/517

add StrLen()

Please add example in examples/basic/main.go, thanks.


Update Prerequisites, additional intune license is needed

It seems that prerequisites are:

if you add to intune, automatic user cloudpc is create and needs to purchase and assign intune license to it also, so the cloudpc can be enrolled.

Clarify with product group and update docs please.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 948c0bd4-e387-2530-5c20-de54a4964f01
Version Independent ID: c4788787-69e3-ddd9-d708-ec68280fb7b9
Content: Get started with Windows 365 Business and Cloud PCs - Microsoft 365 admin
Content Source: microsoft-365/admin/setup/get-started-windows-365-business.md
Service: o365-administration
GitHub Login: @efrene
Microsoft Alias: efrene

@efrene Please help us in resolving this issue. Thanks

@hkusulja, Thank you so much for providing this feedback. I'll check with our product team on your suggestions.

@yogkumgit This is not suggestion, it is mandatory, please do not close, until this is not updated and fixed

i do not see update on docs yet, it still states "There are no licensing prerequisites to set up Windows 365 Business." , which is not correct, you need to have purchase and assign additional Intune license to CloudPCBPRT user that is used as a service account. I hope honestly, that they will fix the product (Intune) to work better, instead using Azure AD users, as "service accounts" ...


Local deployment with auth0 returned Raw body: Server responded with 500 error

 Issue by greenietea
Thursday Dec 21, 2017 at 23:38 GMT
Originally opened as https://github.com/graphcool/prisma/issues/1443

Current behavior
When using the auth0 template on local deployment, it returns 500 error.
Reproduction
Added the auth0 template.
Login on the frontend to get the id_token.
Use the id_token as the accessToken on the mutation on playground.
mutation {   authenticateUser(accessToken:"id_token") {     id   } }

I am having the same issue while using email-password template. Any updates on how to fix this?

Yes me too I think wit email-password template
logs gives this error
2018-02-26T16:14:01.782Z 749ms FAILURE {
  "error": "Function returned invalid status code: 0. Raw body: Server responded with 500"
}

looking into logs of the container  docker logs local_localfaas_1
I see this line
No content to map due to end-of-input
 at [Source: ; line: 1, column: 0]

Am running into this issue too.

No content to map due to end-of-input

seems to be a JSON parsing error from my quick research.
I wonder why there aren't any more logs? I can't see any console.log() output from within my function either :(


How to achieve displaying the PaymentSheet in a language of choice on iPhone

I am trying to display the PaymentSheet in Slovak language (Slovak is supported by Stripe) on iPhone.
These are my regional options on the iPhone:

This is my setting in Info.plist

These are my localization settings:

I must be missing something because I always get the PaymentSheet in English. On Android I get Slovak as expected. Please help.

@metalllus Did you adapt this plugin for production? If yes, please tell us what app. Please help us to develop this plugin in 2022.
https://github.com/capacitor-community/stripe/issues/145
Thanks.


Use fd-notify for sending notifications

Use http://hackage.haskell.org/package/fdo-notify-0.3.1/docs/DBus-Notify.html to send notifications

https://github.com/bobjflong/notify-send is also an option


Error: Cannot find module 'consola' when using pnpm

项目中存在幽灵依赖consola，使用pnpm报错。
需要在package.json中直接声明依赖。

解决了吗？

解决了吗？

只能先暂时在package.json里面显式声明。希望作者尽快解决

pnpm add consola -D

may be it's better to use vite-plugin-imp
vite-plugin-imp is in awesome-vite

using npm, same problem
and this is just a typo I highly suspect
inspected the dist package.json, saw "console" is a dep, instead of "consola", same as https://github.com/jdf2e/nutui/issues/1755 wrote.

Cannot find package 'consola'
I have the same problem, hopefully this author can add one to dependencies

same issue


"Latest" docs show callback arg to up() but db-migrate create does not

Creating a migration with db-migrate create yields up (db) rather than up (db, callback) -- this is inconsistent with the docs.
I'm running 0.10.0-beta.20 from NPM

@chadfurman This true, but not entirely.
Both versions are equally correct. While up (db, callback) is more considered of an old fashioned way to write migrations, up (db) is the new and preferred one.
The first one is the traditional callback style, the second one is utilizing promises. So instead of calling a callback, you return a valid handled promise instead.
So true is, that this is yet missing from the docs and some examples still only represent the callback style, due to being updated currently. Not entriely true is that it would be inconsistent as both ways are valid ways to write your migrations while I agree that this is currently a bit confusing that there are different results from what is presented in the docs. If you want you can go ahead and create a PR extending this part of the docs already :). PRs are always very much appreciated though.

@wzrdtales I'd create a PR if I understood it.  How does the new promise-style work?  My migration simply returns null.  What are other possible return values?

@chadfurman Well actually promises. return null; would be equal to return Promise.resolve(); though.
Every API of db-migrate on the 0.10.x tree by date does in fact return a promise though. Which you can just straightforward return.
To understand Promises, you can have a read here:
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Promise
DB-Migrate itself uses bluebird, which also extends Promises with some features. You can read about that one here:
bluebirdjs.com/docs/api-reference.html
An example of a valid Promise style migration can be found in the example project over here:
https://github.com/db-migrate/api-examples/blob/master/migrations/20160127220809-my-api-table.js
A valid way to chain commands in Promises, is just the normal way that is valid for Promises in general.
To give an example with the db-migrate api:
exports.down = function(db) {

  return db.dropTable('test')
  .then( () => db.dropTable('test2') );
};

@wzrdtales how'd I do?  <3

Cool thing! Gonna have a look later


Turn enable_record_to_file() on/off

Required Info

Camera Model
D415

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10

Platform
PC

SDK Version
<IP_ADDRESS>7

Language
python

Segment
VR/AR

Issue Description
Here's what I'm trying to achieve: I'd like to save a single (depth) frame in PLY format and a BAG stream a few seconds before and after that frame. I understand that enable_record_to_file() allows for capturing the BAG stream. However, the only way I got this to work is by restarting the pipeline with a different configuration, which is very cumbersome since I need to take a lot of subsequent snapshots.
Is there a way to turn on/off the recording feature? Just like pressing the record/stop buttons in the Intel RealSense Viewer.

Yes. Should look something like this:
profile = pipe.start(config) # Store the recording profile used by the pipeline
auto recorder = profile.get_device().as_recorder() # Obtain the streaming device and cast it to recorder type
recorder.pause() # Pause recording while continuing to stream
recorder.resume() # Resume recording of running stream

Thank you, @lramati!
In the meantime, I have found the save_single_frameset() method, which suits my needs perfectly as it allows for saving single frames with different file names. (Restarting the pipeline with a new config, on the contrary, takes quite some time.)
However, there are quite a few unanswered posts in regards to the depth frame not being recorded correctly: #4020, #2588 , #3671, and #3704.
Can you please provide an example showing how to correctly use the method?

The save_single_frameset processing block neglected to save the value of depth_units associated with the frame. When querying this value from the bag, it would see that it didn't have one and default to 0, which resulted in functions like depth_frame.get_distance reporting a distance of 0, even though the depth data was correctly recorded.
A pull request to fix this is incoming, but since a Pre-release version just came out, it might be a while before this change makes it into the official releases and PuPi packages. However, you can compile the branch from source if you want a fix sooner

@bernland With the suggestion of lramati, did you get it through now? Looking forward to your update. Thanks!

Yes, @RealSenseCustomerSupport, since compiling the branch from source, the method save_single_frameset() has been working as expected. Thank you!

@bernland Glad to know this resolved. Close it accordingly. Thanks!


feat(opendataset): add dataloader for SegTrack2 dataset

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.362%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6130

Relevant Lines:
7098

💛  - Coveralls


Rework Ghost Ship dungeon entrance

The mechanics around the spawning of the ghost ship dungeon need to be reworked.

When all three spirits are obtained, the ghost ship must spawn in the NW sea
When the ghost ship boss is defeated, it must not disappear like in the vanilla game
Somehow we need to handle the distinction between the final boss entrance and the regular ghost ship entrance.

iirc, the final boss ghost ship is actually in the SW sea so that shouldn't (hopefully) be too much of an issue.


[Travis CI] Azure PR Bot CI job must fail on the JSON.parse error from linter output

As of today we catch the JSON.parse error on the linter output for the Azure Bot to report status. With this we are having trouble that Azure Bot reports there were no errors but that is not true.
Example PR: https://github.com/Azure/azure-rest-api-specs/pull/1788#issuecomment-333996892
CI Bot Error: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/282957467#L607
By not catching this error, we'll fail the CI job and make Azure Bot not report the invalid report.

Hey Guys are we planning on blocking merge on linter errors?
Adding @kirthik as FYI for this

@salameer this is not tracking making linter a blocker, this is about the bot job and how it reports when there are linter errors. The problem was that if the bot was not able to parse the output given to it by the linter, it would report green, which would be misleading.

@sarangan12 this is yours for what we talked about the other day

adding @bsiegel

Can one of the admins verify this patch?

The tool has been modified a lot and this no longer applies. Closing this

Automation for azure-sdk-for-go

Automation for azure-sdk-for-java

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-node


Avoid stack-allocation of large memory buffers

Using a stack-buffer with a size > 2K could easily produce a stack
overflow for an embedded device which has a limited stack size.
This commit dynamically allocates the large CSR buffer.

@doru91 Thank you for your contribution!
I agree this stack usage can cause usage, and this tmp buffer should be addressed.
Also, having the limit of 2K also limits the size of the csr to generate, so we may consider a different approach for the temporary buffer size.
In addition, unfortunately our policy is to not accept contributions, without a Contributor’s Licence Agreement (CLA) signed or authorised by yourself or your employer.
If this is a personal contribution, the easiest way to do this is if you create an mbed account and accept this click through agreement. Alternatively, you can find a slightly different agreement to sign here, which can be signed and returned to us, and is applicable if you don't want to create an mbed account or alternatively if this is a corporate contribution.
Since I believe you already have an Mbed account here (please confirm this is in fact your account), you can just accept the online agreement.
Thanks for your understanding and again, thanks for the contribution!

Hi Ron
I accepted the CLA.
Thanks,
Doru

Note to gatekeeper: IOTSSL-2218 discusses this task

Sure, I will give it a try this week.

Hi @doru91,
The CI is failing because it has found a tab in your PR:
0.74s$ tests/scripts/check-files.py
Tabs present:
./library/x509write_csr.c: 134
The command "tests/scripts/check-files.py" exited with 1.

Unfortunately, as defined by our coding standards, we don't accept tabs in source code.

I fixed the formatting in the latest commit.

Thanks for the review, @hanno-arm. I addressed your comments in the latest commit.

It's a little bit unclear to me where are the sections that needs changes. Should I create a new pull-request with all the previous fixes?

@doru91 Could you add the following to the ChangeLog please, at the end of the Changes section?
   * Reduce the stack consumption of mbedtls_x509write_csr_der() which previously
     could lead to stack overflow on constrained devices. Contributed by YOUR_NAME.

Thanks for the clarification, @hanno-arm. I updated the change log.

Let me know if there are any remaining issues. Thanks!

Hi @doru91, apologies for the late response. The PR itself looks good to me! However, we do try to avoid merge commits in small PRs, so could you please rebase your work on top of the current development and eliminate the merge commits?
@RonEld Could you please give this PR a second review so that we can hopefully integrate it soon?

II don't have any additional comments. I would consider zeroizing the output buffer in case of failure, but this requires changes in MBEDTLS_ASN1_CHK_ADD which I think are out of scope of this PR

I rebased. Thanks!

Hi @doru91,
the latest commits are no longer associated with the account you're writing from. Is that intentional?
Regards,
Hanno

Hi, @hanno-arm
We had an internal discussion and decided that this commits should be associated with my NXP email address. I also have a CLA also for this address.
Thanks,
Doru

Hi @doru91 I believe that this PR is not a personal contribution, but a contribution from your company.
Company contributions require different CLA acceptance.  However since your company are Mbed partners,  the CLA for this PR remains valid.

That's right. this is a contribution from my company.

Hi,
I solved all the problems reported in the latest review.
I had to force-push due to the rebase issue.
Thanks!

Superseded by https://github.com/ARMmbed/mbedtls/pull/3464


numfmt

with custom numfmt "[$¥-8004]" "#" "####""", the value "80145.899999999994" format to "80145.899999999994", but excel format as "¥ 8 0146"。
after the following change, the result is correct:
in numfmt.go:
supportedLanguageCodeInfo={
"8004":xxx,
xxx
}
in printNumberLiteral func:
...
if token.TType == nfp.TokenTypeHashPlaceHolder || token.TType == nfp.TokenTypeZeroPlaceHolder {
if useLiteral && usePlaceHolder {
//change here
//return nf.value
return result
}
...

another problem:
custom numFmt:"General"
value:0.0140760821860323
formatted to 0.01407608219
excel format to 0.014076082

Thanks for your issue. As the documentation of GetCellValue says: "If the cell format can be applied to the value of a cell, the applied value will be returned, otherwise the original value will be returned", this library doesn't support apply all kinds of number format, if the number format doesn't support will be fallback to original value. Contribution are welcome.


Update khronos api submodules to latest commit

Hello,
This pull request is only update of khronos apis using "git submodule update --remote --merge". These brings new extensions such as SPIR-V support(#425).
Could you publish new version with these apis updated?

It looks like the ARB_spirv extension was already in the repository, but not published on crates.io.
I'll publish a new version after this PR is merged.

You are awesome. But now It seems that build fails. Looks like a new type was added: EGLint and needs conversion. I will try to add it :).

So 2 things were added in order for this to compile with new apis:

" const EGLint *" => "*const types::EGLint" with comment that is it hacky workaround. I am completely new into this crate, so if you could give any hints how I could fix it properly, I will be glad to do it.
"EGLnsecsANDROID *" => "*mut type::EGLnsecsANDROID". EGLnsecsANDROID was there but without pointer type

The whole to_rust_ty is more or less a hack because of Khronos' bad XML format.
However when it comes to the EGLint, maybe instead you could replace match ty.as_ref() with match ty.as_ref().trim() at the top of the function, so that white spaces are removed.

Trim seems like a good workaround for now. I will also try to place merge request on EGL registry. There are exactly 2 instance of  const EGLint (with space) against 24 without space. One could say it is small mistake on their side.

The fix with trim works but I had to remove few spaces on the left side of match as well.


Is this considered production ready?

From the README

Reactive Extensions Library for JavaScript. This is a rewrite of Reactive-Extensions/RxJS and is intended to supersede it once this is ready

I can't seem to find any direct statement about if this library should be chosen over v4 (https://github.com/Reactive-Extensions/RxJS), can someone fill me in?

@walshie4 We're working towards feature-parity (and/or migration assistance) with Rx 4 before we remove that line. RxJS5 is in Angular 2 core and many popular libs have already switched from 4-5. Also this:

Yes, it's production ready. We just need to update the README.


Create "Developer Guide" out of existing content

We would like to introduce a developer guide that would help those who create extensions and integration services for Keptn.
Scope
The developer guide would include:
Part 1. Developing integrations

[ ] Introduction to Keptn development. "What if I need a new Keptn integration? How do I select a way to do it (service, webhook, JES)?"
[ ] Developer environment setup guide
[ ] Guides for creating integration services using standard service templates (Golang, Python). These guides can reside run in the repositories of the templates
[ ] Guide for creating Job Executor Service images
[ ] Guide for developing and testing new Webhook integrations
[ ] Creating documentation for your integration. Best practices and how to get it published?
[ ] Publishing your integration on ArtifactHub
[ ] Creating a Killercoda tutorial for your integrations
[ ] Maintaining your integration. Best practices, tips&tricks

Part 2. Developing Keptn Core

[ ] How to? Sourced right from the Keptn Core repository, including CONTRIBUTING.md
[ ] How to contribute changes?

TODOs

[ ] KEP for the developer guide documentation structure, targeting the new docs engine
[ ] Create new documentation structure
[ ] Rework existing content
[ ] Create new content

Depends on

#994

Related issues

https://github.com/keptn/keptn.github.io/issues/981

outdated


Could not find module 'KeychainSwift' for target 'x86_64-apple-ios-simulator'; found: arm64-apple-ios-simulator

CocoaPods
Version 20.0.0
Xcode version 14.0
iOS version 16.0

When I add pod 'KeychainSwift' and import KeychainSwift I get the following build-time error:

Could not find module 'KeychainSwift' for target 'x86_64-apple-ios-simulator'; found: arm64-apple-ios-simulator, at: /Users/Jordan/Library/Developer/Xcode/DerivedData/AppName-auabmrkvbmhhcuarlsdwrsooabxs/Index.noindex/Build/Products/Debug-iphonesimulator/KeychainSwift/KeychainSwift.framework/Modules/KeychainSwift.swiftmodule

Seems KeychainSwift doesn't support Apple silicon Macs yet?

I'm having this issue as well, has anyone found a solution? I just updated to 21.0.0


weather-forecast: Test don't test for recommended commenting style in instructions

The following comment style recommendations aren't tested for:

The introduction mentions that comments should end in a period
package-level variable should start with their name
package doc comments should have the package name as the second word (after Package which is already tested for)

I'm happy to submit a PR for this, but not sure if it's supposed to be tested

@SaschaMann also made the following point about this (#1759):

I suspect this falls under "asssume the student won't cheat", but this passes the tests but clearly not the spirit of the exercise. When following TDD-principles (which many Exercism tracks tend to do), this would be a sufficient solution:
// Package
package weather

// CurrentCondition
var CurrentCondition string

// CurrentLocation
var CurrentLocation string

// Forecast
func Forecast(city, condition string) string {
	CurrentLocation, CurrentCondition = city, condition
	return CurrentLocation + " - current weather condition: " + CurrentCondition
}

Since Go comments follow a certain format, checking their content or at least that their content is non-zero might prevent this.
I'm not sure this is worth fixing but figured I'd bring it up anyway.


gen_update_targets use for updateAndExecute leads to unbounded loop for typo at command prompt

The code structure below, from inside generate_dynsites.py, sets up an unbounded loop when no match is found when the generated code is executed: The same failed BindCore call can be attempted over and over, with no way to return and no own-activity-generated exception as a way out.
//
// Miss on Level 0, 1 and 2 caches. Create new rule
//

rule = null;
var args = new object[] { %(argelems)s };

for (; ; ) {
    @this.Target = originalRule;
    rule = @this.Target = @this.Binder.BindCore(@this, args);

    //
    // Execute the rule on the matchmaker site
    //

    try {
        %(setResult)s rule(site%(args)s);
        if (CallSiteOps.GetMatch(site)) {
            %(returnResult)s;
        }
    } finally {
        if (CallSiteOps.GetMatch(site)) {
            //
            // The rule worked. Add it to level 1 cache.
            //
            CallSiteOps.AddRule(@this, rule);
        }
    }

    // Rule we got back didn't work, try another one
    CallSiteOps.ClearMatch(site);
}

This has been observed to loop indefinitely, using up a CPU
core, for an interactively-made typo of the likes of:
> > > interfaceInstance.MisTypedMethodName()
where the interfaceInstance was from a use of (suggestive
summary of the .NET C# code that produced the instance):
ChannelFactory<Interface>(binding,endpoint).CreateChannel()
[.net (WCF)]. A correctly typed Interface method name
works fine. The repeated use of BindCore has been observed
from the debugger and the routine with the loop does not
return to its caller.
Looking around suggests that IronPython3's materials have
the same structure and issue.

The generate_dynsites.py generated code was actually part of Microsoft.Scripting.Core which was integrated to the .NET framework. The generator script is basically dead code.
Here's some repro code for the issue:
import clr
clr.AddReference("System.ServiceModel")
from System.ServiceModel import *

binding = BasicHttpBinding()
address = EndpointAddress("http://localhost:8000/ChannelApp")
factory = ChannelFactory[Channels.IRequestChannel](binding, address)
channel = factory.CreateChannel()
channel.MisTypedMethodName()


Feature Request: Add Missing Is/Is Not Modifiers to String Searches

Is your feature request related to a problem? Please describe.
Trying to modify a smart collection to use title.is:, and is/is not is only supported by Tag Searches
This functionality exists in the Plex Web UI for all the string attributes listed in the wiki
Describe the solution you'd like
I'd like to be able to use title.is: in one of my smart collections. If you added this though, something to keep in mind is that Tag Searches is not modifier uses .not, which is the same as the does not contain modifier. So if you wanted consistent naming you'd run into a duplicate modifiers there. Maybe changing the Tag Searches modifier to be .isnot instead of .not would solve that?

added .is and .isnot to string searches and filters


AWS X-Ray support

Starting with trace ID propagation:

extracting trace identifiers costs more because we have to parse within a string.

I did get a 12% performance improvement by avoiding use of String.split

injecting trace identifiers costs less because we only write one string.

Next step is span reporting. I'll change the brave demo to intermingle with X-Ray as a grand finale.
Benchmark                          Mode  Cnt   Score   Error   Units
PropagationBenchmarks.extract_aws  thrpt   15   4.307 ± 0.122  ops/us
PropagationBenchmarks.extract_b3   thrpt   15  10.617 ± 0.924  ops/us
PropagationBenchmarks.inject_aws   thrpt   15  13.092 ± 0.794  ops/us
PropagationBenchmarks.inject_b3    thrpt   15  11.132 ± 0.944  ops/us

End to end (overhead) benchmarks (currently propagation only, not conversion)
Benchmark                                            Mode  Cnt    Score   Error  Units
EndToEndBenchmarks.server_get                        avgt   15  149.558 ± 4.030  us/op
EndToEndBenchmarks.traced128Server_get               avgt   15  171.492 ± 8.606  us/op
EndToEndBenchmarks.traced128Server_get_resumeTrace   avgt   15  179.316 ± 5.602  us/op
EndToEndBenchmarks.tracedServer_get                  avgt   15  171.560 ± 4.287  us/op
EndToEndBenchmarks.tracedServer_get_resumeTrace      avgt   15  178.494 ± 7.080  us/op
EndToEndBenchmarks.tracedxrayServer_get              avgt   15  172.102 ± 6.651  us/op
EndToEndBenchmarks.tracedxrayServer_get_resumeTrace  avgt   15  178.151 ± 3.580  us/op
EndToEndBenchmarks.unsampledServer_get               avgt   15  158.549 ± 2.813  us/op

Added extract impl, tests and benchmarks. Parsing within a header value is more expensive than separate headers. I got it as quick as I could within a reasonable amount of time.

Note: there's a behavior difference in X-Ray vs B3, which is that you can send only a trace ID (not a span ID). This implied a separate commit, which I can pull out separately later. This commit makes it possible to get just the trace ID (which is specified by ELB for log correlation purposes, and has no span ID as ELB doesn't write to X-Ray).

@adriancole this is the best thing, I have ever seen for a while. do you have any idea about when this support will be ready for testing?

Awesome work @adriancole

added end-to-end overhead benchmarks, which show the overhead related to this isn't statistically significant in the big picture.
@cemo glad you like! trying to get a converting reporter working today. After that, will need to step back and make sure tech debt isn't added, but won't be long. watch this thread

so far so good. Propagation works (creating single-host spans)

Here's a diff for the https://github.com/openzipkin/brave-webmvc-example changed to use this so far
index 3e0967a..0ccec3b 100755
--- a/servlet3/pom.xml
+++ b/servlet3/pom.xml
@@ -13,7 +13,7 @@

   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <brave.version>4.8.1</brave.version>
+    <brave.version>4.8.2-SNAPSHOT</brave.version>
     <zipkin-reporter2.version>2.0.2</zipkin-reporter2.version>
     <spring.version>4.3.8.RELEASE</spring.version>
     <log4j.version>2.8.2</log4j.version>
diff --git a/servlet3/src/main/java/brave/webmvc/TracingConfiguration.java b/servlet3/src/main/java/brave/webmvc/TracingConfiguration.java
index dd1f7e4..465501b 100644
--- a/servlet3/src/main/java/brave/webmvc/TracingConfiguration.java
+++ b/servlet3/src/main/java/brave/webmvc/TracingConfiguration.java
@@ -3,6 +3,7 @@ package brave.webmvc;
 import brave.Tracing;
 import brave.context.log4j2.ThreadContextCurrentTraceContext;
 import brave.http.HttpTracing;
+import brave.propagation.XRayPropagation;
 import brave.spring.web.TracingClientHttpRequestInterceptor;
 import brave.spring.webmvc.TracingHandlerInterceptor;
 import java.util.ArrayList;
@@ -44,6 +45,8 @@ public class TracingConfiguration extends WebMvcConfigurerAdapter {
   @Bean Tracing tracing() {
     return Tracing.newBuilder()
         .localServiceName("brave-webmvc-example")
+        .traceId128Bit(true)
+        .propagationFactory(new XRayPropagation.Factory())
         .currentTraceContext(ThreadContextCurrentTraceContext.create()) // puts trace IDs into logs
         .spanReporter(spanReporter()).build();
   }
``

next step was a custom UDP reporter which converts zipkin spans. This should probably live in zipkin-aws when finished. Here's an example from the demo app:

🕺

last experiments before moving this code to zipkin-aws repo:

incoming B3 -> outgoing AWS ID
incoming AWS -> outgoing B3
reporting within lambda (to understand things)

in zipkin-aws repo, I think we'll end up with a converter, collector and a reporter component similar to what we have for stackdriver. the zipkin-aws repo contains stock zipkin components which will work on anything like brave, sleuth, wingtips etc.
Trace ID propagation is beyond X-Ray (ex multiple AWS services use the same format), and the implementation is brave-specific (brave's propagation api is currently only for brave), so I think the AWSPropagation class might stay here even if in a different module

Below is reporting within a brave tracer in lambda, with a custom zipkin reporter:

Next step is cleaning up stuff, including readable demo code, and code move to zipkin-aws repo.

Thats awesome. Great work Adrian!! Hopefully this can be a fallback for us
when people decide we shouldn't be hosting zipkin ourselves... SaaS all the
things..
On Fri, Oct 6, 2017 at 6:47 AM, Adrian Cole<EMAIL_ADDRESS>wrote:

Below is reporting within a brave tracer in lambda, with a custom zipkin
reporter:
[image: screen shot 2017-10-06 at 6 42 22 pm]
https://user-images.githubusercontent.com/64215/31274713-bd32d706-aac6-11e7-898f-256db3e64c8c.png
Next step is cleaning up stuff, including readable demo code, and code
move to zipkin-aws repo.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openzipkin/brave/pull/510#issuecomment-334722029, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIiosyo_k5_HL7zQWqEStvSerrHlvuyks5spgVUgaJpZM4PtGGt
.

Renamed to Amazon and made a utility to extract env. Checking, but I think amazon is the right name as the header format is also used by non-xray products.

This code is ready to go. The other part will be in zipkin-aws repo (the XRayUDPSender). Once that's released you will be able to make a brave app. I'm not releasing this as there's currently various problems across travis and maven central. Will try tomorrow.

here's a place the reporter will go https://github.com/openzipkin/zipkin-aws/pull/56

release won't happen until https://github.com/openzipkin/brave/pull/514 is in, as that supports the extra fields needed in AWS (plus removes a yet-unreleased api for a better one)

OK the implementation no longer drops "extra" fields (besides the Self references which should be dropped). Later implementations can expose means to access these, but in the mean time we can release.
Will merge and release tomorrow morning unless I hear screams.

Lgtm


Support EF Core 2.2 query tagging from inside expressions

I have a couple of (complicated) expressions that get reused allot
so I would like to have the tagging support from inside the expression so I don't have to specify it everywhere manually
https://docs.microsoft.com/en-us/ef/core/querying/tags/

Do you just want to use the
.TagWith("...")

functionality?
And why is this not supported now ?

If it's defined on IQueryable, you can just use it ? So why this issue ?

I use a bunch of expressions like the one above all over the place and would like to not have to both specify the expression and adding the tag to the query
only add the tag from inside the expression once

it would make tracking expression usage allot more easier
we use the querystore to diagnose sql query perf issues and the like
https://docs.microsoft.com/en-us/sql/relational-databases/performance/query-store-usage-scenarios?view=sql-server-2017
and you can also see the actual sql query being executed so it would be nice if we can easily add the tags from inside the expressions


[Core] Revamp windows system to add more flexibility

Tome : describe some more

I open this again in order to add better separation between different manialink times, to name them widgets & windows


Reduce twig priority

This PR

[x] Reduces the priority of the twig global listener

Due to this having a priority of 512, the same as the DatabaseSetupListener ,it would fire before the db connection was set up and would throw a fatal error.

Thank you, @BackEndTea and @derrabus!


MathJax doesn't like \scalebox, use \large instead

MathJax doesn't know how to handle the \scalebox{1.07} used for independent variable notation, see the third paragraph of this section.
I've replaced it with \large, which I think is a little bit bigger, but does work in MathJax. I couldn't find an easy compatible way to do exactly 7% scaling.
I've also changed the TeX version of this macro, just to keep things consistent.

Thanks!


[Web] - Crashes when running local development during hot restart

Steps to reproduce
I don't have a consistent set of reproduction steps. As I'm working on a web app, making code changes, and automatically running Hot Restart through Android Studio, the whole test browser crashes and forces me to rebuild and relaunch.
I've included a random example of error output when the crash happens.
Expected results
Hot Restart gracefully handles changes to code, including momentary invalid code.
Actual results
While working on live code in debug mode in the test browser, the whole browser crashes and disappears.
Code sample
I don't have a code sample for this. It happens regardless which file I'm working in.
Screenshots or Video
No response
Logs
Logs
Performing hot restart...
Waiting for connection from debug service on Chrome...
../../../../../DevLibs/flutter/packages/flutter/lib/src/rendering/layer.dart:1068:13: Error: The method 'setRasterizerTracingThreshold' isn't defined for the class 'SceneBuilder'.
 - 'SceneBuilder' is from 'dart:ui'.
Try correcting the name to the name of an existing method, or defining a method named 'setRasterizerTracingThreshold'.
    builder.setRasterizerTracingThreshold(rasterizerThreshold);
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../../../DevLibs/flutter/packages/flutter/lib/src/rendering/layer.dart:1069:13: Error: The method 'setCheckerboardRasterCacheImages' isn't defined for the class 'SceneBuilder'.
 - 'SceneBuilder' is from 'dart:ui'.
Try correcting the name to the name of an existing method, or defining a method named 'setCheckerboardRasterCacheImages'.
    builder.setCheckerboardRasterCacheImages(checkerboardRasterCacheImages);
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../../../DevLibs/flutter/packages/flutter/lib/src/rendering/layer.dart:1070:13: Error: The method 'setCheckerboardOffscreenLayers' isn't defined for the class 'SceneBuilder'.
 - 'SceneBuilder' is from 'dart:ui'.
Try correcting the name to the name of an existing method, or defining a method named 'setCheckerboardOffscreenLayers'.
    builder.setCheckerboardOffscreenLayers(checkerboardOffscreenLayers);
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unhandled exception:
file:///Users/matt/Projects/super_editor/super_editor/clones/quill/lib/editor/editor.dart: No class info for FeatherEditor
#0      ClosedWorldClassHierarchy.infoFor (package:kernel/class_hierarchy.dart:714)
#1      ClosedWorldClassHierarchy.getClassAsInstanceOf (package:kernel/class_hierarchy.dart:1045)
#2      ProgramCompiler._emitIterable (package:dev_compiler/src/kernel/compiler.dart:2397)
#3      ProgramCompiler._emitClassMethods (package:dev_compiler/src/kernel/compiler.dart:2075)
#4      ProgramCompiler._emitClassDeclaration (package:dev_compiler/src/kernel/compiler.dart:905)
#5      ProgramCompiler._emitClass (package:dev_compiler/src/kernel/compiler.dart:819)
#6      List.forEach (dart:core-patch/growable_array.dart:417)
#7      ProgramCompiler._emitLibrary (package:dev_compiler/src/kernel/compiler.dart:757)
#8      List.forEach (dart:core-patch/growable_array.dart:417)
#9      ProgramCompiler.emitModule (package:dev_compiler/src/kernel/compiler.dart:486)
#10     IncrementalJavaScriptBundler.compile (package:frontend_server/src/javascript_bundle.dart:221)
#11     FrontendCompiler.writeJavaScriptBundle (package:frontend_server/frontend_server.dart:869)
<asynchronous suspension>
#12     FrontendCompiler.recompileDelta (package:frontend_server/frontend_server.dart:1038)
<asynchronous suspension>
#13     listenAndCompile.<anonymous closure> (package:frontend_server/frontend_server.dart:1464)
<asynchronous suspension>
Finished with error: the Dart compiler exited unexpectedly.

Flutter Doctor output
Doctor output
Flutter 3.22.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 761747bfc5 (3 weeks ago) • 2024-06-05 22:15:13 +0200
Engine • revision edd8546116
Tools • Dart 3.4.3 • DevTools 2.34.3

CC @kevmoo @yjbanov

cc @nshahan

I also can't reproduce this issue (only tried with a new Flutter project). Labeling this for team's tracking.

@matthew-carroll
The stack trace you posted shows a crash in the web development compiler (DDC) while trying to calculate how a class is representable as an Iterable supertype. In that process it failed to find information for the class FeatherEditor. If possible I'd like to look at the class hierarchy to understand more about what could be a possible reproduction. Does the file uri printed translate to some open source repo I can see? file:///Users/matt/Projects/super_editor/super_editor/clones/quill/lib/editor/editor.dart
@elliette @bkonyi
I'm not familiar with the android studio integration. Is there a separate codebase for this or would you expect similar problems to appear in vscode?

I'm not familiar with the android studio integration. Is there a separate codebase for this or would you expect similar problems to appear in vscode?

Android Studio vs VS Code shouldn't make a difference here, this should be reproducible from VS Code as well.

@nshahan it is open source, but not merged yet. Just a private branch. But FeatherEditor is a StatefulWidget. No other inheritance or mixins applied to it other than extends StatefulWidget.

Here's another stack trace:
lib/deltas/deltas_display.dart:6:9: Error: Type 'Editor' not found.
  final Editor editor;
        ^^^^^^
lib/deltas/deltas_display.dart:6:9: Error: 'Editor' isn't a type.
  final Editor editor;
        ^^^^^^
Unhandled exception:
Unsupported operation: Unsupported invalid type InvalidType(<invalid>) (InvalidType). Encountered while compiling file:///Users/matt/Projects/super_editor/super_editor/clones/quill/lib/deltas/deltas_display.dart, which contains the type: InvalidType(<invalid>).
#0      ProgramCompiler._typeCompilationError (package:dev_compiler/src/kernel/compiler.dart:3227)
#1      ProgramCompiler._emitType (package:dev_compiler/src/kernel/compiler.dart:3188)
#2      ProgramCompiler._emitClassFieldSignature (package:dev_compiler/src/kernel/compiler.dart:1641)
#3      ProgramCompiler._emitClassSignature (package:dev_compiler/src/kernel/compiler.dart:1617)
#4      ProgramCompiler._emitClassDeclaration (package:dev_compiler/src/kernel/compiler.dart:962)
#5      ProgramCompiler._emitClass (package:dev_compiler/src/kernel/compiler.dart:819)
#6      List.forEach (dart:core-patch/growable_array.dart:417)
#7      ProgramCompiler._emitLibrary (package:dev_compiler/src/kernel/compiler.dart:757)
#8      List.forEach (dart:core-patch/growable_array.dart:417)
#9      ProgramCompiler.emitModule (package:dev_compiler/src/kernel/compiler.dart:486)
#10     IncrementalJavaScriptBundler.compile (package:frontend_server/src/javascript_bundle.dart:221)
#11     FrontendCompiler.writeJavaScriptBundle (package:frontend_server/frontend_server.dart:869)
<asynchronous suspension>
#12     FrontendCompiler.recompileDelta (package:frontend_server/frontend_server.dart:1038)
<asynchronous suspension>
#13     listenAndCompile.<anonymous closure> (package:frontend_server/frontend_server.dart:1464)
<asynchronous suspension>
Finished with error: the Dart compiler exited unexpectedly.

This crash seems to happen when I'm in the middle of editing and there are references in my code that aren't connected yet. Of course, these things happen when developers move from file to file and write code. These intermediate broken states don't cause problems when running on desktop and mobile, and I don't think this used to happen on web, but it does now.

Oh, and a reproduction:
flutter create a new project, then put in
main.dart:
import 'package:flutter/material.dart';
import 'foo.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;
  Foo foo = new Foo();

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              foo.pressedText(),
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

foo.dart:
class Foo {
  String pressedText() => 'You have pushed the button this many times:';
}

flutter run in chrome, once it's ready change foo.dart to for instance
class FooX {
  String pressedText() => 'You have pushed the button this many times:';
}

and reload and I get:
Performing hot restart...
lib/main.dart:35:3: Error: Type 'Foo' not found.
  Foo foo = new Foo();
  ^^^
lib/main.dart:35:3: Error: 'Foo' isn't a type.
  Foo foo = new Foo();
  ^^^
lib/main.dart:35:17: Error: Couldn't find constructor 'Foo'.
  Foo foo = new Foo();
                ^^^
Unhandled exception:
Unsupported operation: Unsupported invalid type InvalidType(<invalid>) (InvalidType). Encountered while compiling
file:///usr/local/google/home/jensj/code/nobackup/flutter/tmp/issue_150760/lib/main.dart, which contains the type: InvalidType(<invalid>).
#0      ProgramCompiler._typeCompilationError (package:dev_compiler/src/kernel/compiler.dart:3236)
#1      ProgramCompiler._emitType (package:dev_compiler/src/kernel/compiler.dart:3197)
#2      ProgramCompiler._emitClassFieldSignature (package:dev_compiler/src/kernel/compiler.dart:1651)
#3      ProgramCompiler._emitClassSignature (package:dev_compiler/src/kernel/compiler.dart:1627)
#4      ProgramCompiler._emitClassDeclaration (package:dev_compiler/src/kernel/compiler.dart:962)
#5      ProgramCompiler._emitClass (package:dev_compiler/src/kernel/compiler.dart:819)
#6      List.forEach (dart:core-patch/growable_array.dart:416)
#7      ProgramCompiler._emitLibrary (package:dev_compiler/src/kernel/compiler.dart:757)
#8      List.forEach (dart:core-patch/growable_array.dart:416)
#9      ProgramCompiler.emitModule (package:dev_compiler/src/kernel/compiler.dart:486)
#10     IncrementalJavaScriptBundler.compile (package:frontend_server/src/javascript_bundle.dart:223)
#11     FrontendCompiler.writeJavaScriptBundle (package:frontend_server/frontend_server.dart:801)
<asynchronous suspension>
#12     FrontendCompiler.recompileDelta (package:frontend_server/frontend_server.dart:966)
<asynchronous suspension>
#13     listenAndCompile.<anonymous closure> (package:frontend_server/frontend_server.dart:1389)
<asynchronous suspension>
the Dart compiler exited unexpectedly.
Performing hot restart...                                          160ms

cc @Markzipan
This is the issue we were discussing. Maybe you could take a look to see if the flutter infra is correctly recognizing errors from the frontend server responses before attempting to compile with DDC.

@nshahan Hello, should this be tracked in dart-lang repo ? as most likely it seems to be related to web-dev-compiler and area-web

It doesn't exactly sound like a web-dev-compiler issue to me because something in the tooling is sending invalid code to the compiler and it is crashing because it assumes the nodes to be well formed at that point. It could be that the code doing this is in the Dart SDK somewhere so I'm fine with you moving the issue if you want.
I would be nice to have a repro that doesn't involve flutter though.


Switch away from passing funs between nodes when uploading attachments

Passing closures around is fragile and prevents smooth upgrading. Instead pass
a tuple with a data from the receiver closure explicitly and convert to back to
a local fun locally on each node.
Config options [fabric] attachment_receiver_tuple controls how receivers are
encoded. To upgrade a cluster to use the new format, first upgrade all nodes to
the new code, then flip the value to true. In the future, the option and the
old closure handling code will be removed.

I can't review the code here, but I insist you add something to the documentation about this new flag, even if it's just in rel/overlay/etc/default.ini.
Speaking of which, I don't see any changes in this PR to that file :disappointed:  ALL new config:get entries should be paired with a change to default.ini.
When we change the default value and remove the config option, we will need a big screaming warning in the upgrade docs that says rolling upgrades from older CouchDBs that have the value set to false will fail. (It might be worth describing exactly how those upgrades will fail, too.)

@wohali sorry, this is still a WIP, forgot to mark it as such


incus: fix lxd-to-incus, add static client, support multi-version

Description of changes
Given the number of changes I was making, I formatted these files to make my life easier. Hopefully that doesn't distract from the improvements here.

incus: move unwrapped to incus dir
incus: reformat with nixfmt-rfc-style
incus: add support for multiple releases
incus: add statically compiled client
incus: lxd-to-incus is now part of main package

TODO:

[x] Multi-release update script

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'm using this branch and successfully used the fixed lxd-to-incus to migrate a host.