Used eff_large_wordlist.txt.

Formatted with "cat eff_large_wordlist.txt | awk '{print $2}' > wordlist.txt".

Sorry, I was a bit quicker :wink: https://github.com/dbrgn/xkcdpass-rs/commit/98582f41e07152b09146051db3bb1c7c86fbb348 Thanks anyways!


Display Modules Attached to a DAO

For security purposes, we should have a screen or section of the app that lists all of the Safe modules currently attached to the DAO, with links to them on Etherscan.
A potential simple fix is listing them in the DAO homepage:

Alternatively, have them on a separate page, with UI similar to DAO Hierarchy:

We have this now implemented by @sethhrbek, and will likely follow up with adding it to a future settings screen


Improve limited permissions (cherry-picked from #220)

Cherry-pick of improvement for limited permissions without refactoring from #219

@rohank07 Could you please confirm if this branch works for you?

Yes, this works for me


Authentication isnt working

Hi all, Ive created a simple ruby file with the code from the example for web authentication, but it isnt working as expected. It does redirects to google but when it comes back, it redirects me again to Google auth page, since authorizer.get_credentials(user_id, request) is always nil.
Any clue?
This is the ruby file.
UPDATE: Redis is working, and creating a token manually too. Im using ruby 2.3.4p301 and the last version of the gem.

@mustela are sessions enabled?
enable: sessions

Closing for now. Feel free to re-open if the previous commend was unable to solve your problem.


Change generate_password_hash to use stronger default than SHA-1

I'm still not entirely clear if pbkdf2:sha1 is vulnerable to the sha1 collision issue, but we should look into this. Changing the default to pbkdf2:sha256 is probably fine regardless.

After some discussion, concluding that SHA-1 as used in PBKDF2 is not vulnerable now, nor is it likely to be any time soon. http://chat.stackoverflow.com/transcript/message/35836840#35836840

I'm not convinced that one couldn't fabricate real data (given that, if you
found a collision with two input strings, you can append arbitrary data and
still have a collision) using this. I propose keeping this open either way,
even if no action is required for the next few years.
On Sat, Feb 25, 2017 at 09:02:17AM -0800, David Lord wrote:

After some discussion, concluding that SHA-1 as used in PBKDF2 is not vulnerable now, nor is it likely to be any time soon. http://chat.stackoverflow.com/transcript/message/35836840#35836840
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/pallets/werkzeug/issues/1075#issuecomment-282496869


Link of Windows YARA install is not working.

Describe the bug
https://yara.readthedocs.io/en/v3.5.0/gettingstarted.html
Download Windows binaries Link redirects to wrong google drive.
Expected behavior
Links to release page

The old link is only present in older versions of the documentation, starting with version 4.0.0 the link points to GitHub releases. Unfortunately I can't update the old versions of the documentation.


Nuxt 3 PWA - manifest.json replaced on build

Hi, I'm trying to deploy a SPA to SWA. I'm using Nuxt 3 with the Nitro preset Azure.
The issue is that my manifest.json file, which is correctly loaded in dev, seems to be replaced by oryx when building and deploying.
The file is found in the .output/public dir after running pnpm buld.

And here you can see it gets replaced (I think, not 100% sure):

And I end up with this manifest:

which seems to have some routes and imports inside, but nothing about my PWA

Expected behavior
Keep my manifest.json file for the PWA

Hi @AscaL, sorry for the inconvenience caused. If you have already built your app before, can you try using skip_app_build so that oryx won't build your app and replace your manifest file.

Hi @rupareddy5-21 , thanks for the tip. I've tried but unsuccessfully.
Upon further investigation I've discovered that the manifest deployed seems to be the one in .output/server/functions/chunks/ instead of the one (that i expect) in .output/public/
I really do not know why

Don't know how or why but it's working at the moment. Closing


UI updates to the Confirmation Page

Based on internal testing feedback:

[ ] Add links to download the annual report and the receipt.
[ ] Allow users to enter an email address if there is none associated with their account.

The email address change, is this only to receive the receipt and filing copy? The next change will send the receipt/filing to the email associated with the invitation, instead of the user, business or account.

Yes, for receiving the receipt and filing copy. Just curious, where is the email associated with the invitation pulled from?

My mistake, the files will be sent to the email on the current account. If there is no email for the account then it will be sent to the invitation email.

Could we please prioritize this change? @deetz99

@trishreimer
Including 'Allow users to enter an email address if there is none associated with their account.'?
The report and receipt will be sent to the email from the invitation if there is no email associated with their account.

@trishreimer
So I have this in PR/DEV now, though only the receipt download is available at this time.
Currently, the report is not available until it is submitted to COLIN and reaches COMPLETED status. If the report fails in COLIN, there could be a difference between the filing and what we send to the user.
We could update it to return the filing before it has reached COMPLETED status but that might be a business question?

no further changes requested, closing


[HOLD for payment 2023-10-27] [$500]  IOU Category - Search message shows 'Invalid email' when typing email address in search field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/27459
Action Performed:

Go to staging.new.expensify.com
Go to any workspace chat
Go to + > Request money > Manual
Enter an amount
Click Show more > Category.
Enter a few letters, followed by @

Expected Result:
The message below the search field will display 'No results found'..
Actual Result:
The message below the search field displays 'invalid email' when Category search does not involve email
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.73-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/f780b607-ab40-48ee-9fd4-a91cd525d5b6
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0131655c00ab293751
Upwork Job ID:<PHONE_NUMBER>418142208
Last Price Increase: 2023-10-13
Automatic offers:

DylanDylann | Contributor | 27217343

Proposal
Please re-state the problem that we are trying to solve in this issue.
IOU Category - Search message shows 'Invalid email' when typing email address in search field
What is the root cause of that problem?
https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/libs/OptionsListUtils.js#L1476-L1485
Let's see the logic to get header message, we are checking if the search value includes "@" we will display errorMessageInvalidEmail instead of noResultsFound
What changes do you think we should make in order to solve the problem?
In this case, we don't search email and phone number
https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/libs/OptionsListUtils.js#L1477-L1485
So this logic to redandunt. We need to pass one more params called includeEmailAndPhoneNumber to getHeaderMessage function
and only apply logic to check email and phone if this param is true
What alternative solutions did you explore? (Optional)

Not sure how to make a Category, asking QA - https://expensify.slack.com/archives/C9YU7BX5M/p1695681312874909

still trying to get Categories to work on my<EMAIL_ADDRESS>account.

I still can't get Category and reached out to the team and they can't get it either so maybe we disabled them. I'm going to close this.

@Christinadobrzyn I still can reproduce this bug on the latest main. You can ping C+ team or internal engineer to help verify the bug

This is an example about category issue: https://github.com/Expensify/App/issues/28079

@s77rt It seems @Christinadobrzyn can't access the category feature. Because you are C+ Contributor of another issue that relates to category https://github.com/Expensify/App/issues/28517. Could you help to verify this is a bug?
Sorry, If I bothers you

I can reproduce the bug

@ZhenjaHorbach, I'm also interested in the project.
 But, it won't match the whole email if it has punctuation in it:
<EMAIL_ADDRESS>
It's better to use:
<EMAIL_ADDRESS>
This will return the whole email on a match. And not partial using the \w expression if the email has punctuation.
This is more for sanity sake in the future to verify full email matching.

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01ed9060ff74912e35

@ZhenjaHorbach no it's not.
Please review TLDs with punctuation in them:

Proposal
Please re-state the problem that we are trying to solve in this issue
In the "IOU Category". When you search for a message. It shows "invalid email". When instead, it needs to show "no results found".
What is the root cause of that problem?
There is an issue with the regex. As per discussion in this thread. We need to add regex to verify that the search input value is an email.
We would use the following regex pattern to properly identify all emails including emails with punctuation in their TLDs (as discussed earlier in this thread).
What changes do you think we should make in order to solve the problem?
As per the snippet seen here:
https://github.com/Expensify/App/blob/5aa7f6da94ddb1c8ca55a6cce714555f819c1dd0/src/libs/OptionsListUtils.js#L1476-L1490
We will need to update this script to use a regex that properly captures email values:
     if (searchValue && !hasSelectableOptions && !hasUserToInvite) {
         if (/^\d+$/.test(searchValue) && !isValidPhone) {
             return Localize.translate(preferredLocale, 'messages.errorMessageInvalidPhone');
         }
         if (/\S+@\S+\.\S+/.test(searchValue) && !isValidEmail) {
             return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
         }
         if (hasMatchedParticipant && (isValidEmail || isValidPhone)) {
             return '';
         }
         return Localize.translate(preferredLocale, 'common.noResultsFound');
     }

We will also  want to add additional unit tests for this function:
function getHeaderMessage()

To verify that the desired outputs.
In the following file https://github.com/Expensify/App/blob/main/tests/unit/OptionsListUtilsTest.js
We do not have unit tests for getHeaderMessage(). We should add them and check for numbers, emails and other queries.
However, should that be a separate issue?

@ChrisCates asked me for my thoughts on their proposal.
After giving your proposal a quick look, I can't see the benefit of it over other proposals. The form is more or less alright, although the root cause analysis is quite shallow; "There is an issue with the regex." is not very precise.
The assigned C+ (@rushatgabhane) can give you more feedback. Once you have Slack access, you can also ask for high-level feedback there, but please be sure that you double-read the contributing guidelines before you do that.

@cubuspl42,
If an email is inputted with a TLD that has a - in it.
It will not register as an email.
For example, if you input:
<EMAIL_ADDRESS>
It will register an email. However, if you input:
<EMAIL_ADDRESS>
It will not register an email. This is why you need to use \S as opposed to \w.
I can add that to the proposal for clarity.
Also, unit testing on the function:
function getHeaderMessage()

May be helpful for future sanity sake.

hi @rushatgabhane could you review the proposals when you have a moment? Thanks!

nudge @rushatgabhane when you have a moment to review the proposals! Thanks!

@rushatgabhane this PR is ready for review

I believe we just need the BZ checklist here so we can proceed with the payments

Payouts due:
Issue Reporter: NA - reporter is Applause
Contributor: $500 + $250 speed bonus @DylanDylann (Paid through Upwork)
Contributor+: $500 + $250 speed bonus @rushatgabhane (paid manually in NewExpensify)
Eligible for 50% #urgency bonus? Y - https://github.com/Expensify/App/issues/28078#issuecomment-1767805933
Upwork job is here.
@rushatgabhane could you let us know about a regression test?

nudge @rushatgabhane about a regression test, thanks!

Dming @rushatgabhane to see if we need a regression test

WIP ⚠

The PR that introduced the bug has been identified. Link to the PR:

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Determine if we should create a regression test for this bug.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again

Created a manual request https://staging.new.expensify.com/r/8819237970145454

awesome! I think this can be closed.

$750 payment approved for @rushatgabhane based on this comment.


starter-bots error - Cannot run program "py"

I am having a bit of trouble running the starter-pack out of the box. I want to write a bot in Python 2.7.10.
Current PC:

Windows 10, version 1709
Python 2.7.10, installed with Python (x,y).
Java 1.8.0_171"

./config.json
{
"round-state-output-location": "./tower-defence-matches",
"game-config-file-location": "./game-config.properties",
"verbose-mode": true,
"max-runtime-ms": 20000,
"player-a": "./starter-bots/python3",
"player-b": "./reference-bot/java"
}
./starter-bots/python3/bot.json
{
"author": "John Doe",
"email"<EMAIL_ADDRESS>"nickName": "Guido",
"botLocation": "/",
"botFileName": "StarterBot.py",
"botLanguage": "python2"
}
Tried the botLanguage as python3 with the same error.
The error I get is:
=======================================
Starting game
=======================================
=======================================
Starting round 0
=======================================
Bot execution failed: Cannot run program "py" (in directory "C:\Entelect\2018\111_1\starter-bots\python3"): CreateProcess error=2, The system cannot find the file specified
BotRunner Started.
File C:\Entelect\2018\111_1\starter-bots\python3/command.txt not found
BotRunner Started.
Error List: []

Player A Health=100, Energy=25, Score=5
Player B Health=100, Energy=5, Score=6
[0 0][1 0][2 0][3 0][3 0][2 0][1 0][0e0]
[0 1][1 1][2 1][3 1][3 1][2 1][1 1][0 1]
[0 2][1 2][2 2][3 2][3 2][2 2][1 2][0 2]
[0 3][1 3][2 3][3 3][3 3][2 3][1 3][0 3]

=======================================
Starting round 1
=======================================
Bot execution failed: Cannot run program "py" (in directory "C:\Entelect\2018\111_1\starter-bots\python3"): CreateProcess error=2, The system cannot find the file specified
BotRunner Started.
File C:\Entelect\2018\111_1\starter-bots\python3/command.txt not found
BotRunner Started.
Error List: []

bla
bla
bla...

Any suggestions?

Problem solved once I installed python 3.6. As I stated, I only had python 2.7 installed.
Working smoothly now.☺


[Bug]: Feeback form is not responsive to smaller screen

Give a brief about the bug ✍

What is the expected behavior? 🤔
It should not overflow in 480px
Provide step by step information reproduce the bug 📄
index.html > feedback
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

@ayush-t02 please check this


Option to silence error messages inside form

Hi,
would it be possible to add an option to order Parsley not to report error messages? My use case is this: I use my own form builder to create forms, that displays errors in designated place inside form. Hooking Parsley inside my code was easy but I had to silence its reports by:
parsley-error-list {
  display:        none !important;
}

All I'm interested is "tell me if all values are valid or not", or better "tell me what fields contain invalid values" - I'll report this to user my own way. Parsley does it's validation job perfectly (for my needs, at least :) but talks too much :) Using CSS to silence Parsley works, no doubt about that, but I just thought it'd be nice to have an option for this behavior - it'd be more straightforward, readable and understandable.

@oprichnik Thank you sir, you saved me a lot of time!

Hey.  No problem.  Glad it helped.
--Will

                         Will McKinley
                    McKinley Media Inc
           Adding vision to corporate design

www.mckinleymedia.com http://www.mckinleymedia.com/<EMAIL_ADDRESS><EMAIL_ADDRESS>   (415) 924-1975

On Jan 14, 2015, at 9:37 AM, Emanuele Ingrosso<EMAIL_ADDRESS>wrote:
@oprichnik https://github.com/oprichnik Thank you sir, you saved me a lot of time!
—
Reply to this email directly or view it on GitHub https://github.com/guillaumepotier/Parsley.js/issues/214#issuecomment-69956724.

Is there a way to show / hide error messages when calling validate on a field group? I don't want to use data-parsley-errors-messages-disabled because it isn't flexible enough for this use case.

@holoiii not sure what you mean. Calling isValid() will not trigger events (and thus not update the error messages), while validate() will.

Is there a way to prevent errors display while still adding the error classes from the js (not with the attribute)?

@oprichnik Can this be set on the form? I have tried the following approach but it doesn't:
$('#steps').parsley({
    "errors-messages-disabled": true
});

It only works when I add it to the input field.

As of the current date, the following worked for me:
data-parsley-errors-messages-disabled
I added this value as an attribute to the form element as follows:
<form data-parsley-validate data-parsley-errors-messages-disabled id="form-id" >
According to the API documentation:

Add parsley-success and parsley-error classes on field, but no error message.


[Backport 2.x] Fix - Breaking Change Main OpenSearch project - action move to core #1200

Description
Corrects imports for new location with regards to https://github.com/opensearch-project/OpenSearch/pull/9082.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thanks for fixing the breaking changes. Will approve once the Github CI pass

@ylwu-amzn Seems like BWC has been failing for 3 weeks on the 2.x branch. That can probably be addressed after this PR without impact.

@ylwu-amzn Seems like BWC has been failing for 3 weeks on the 2.x branch. That can probably be addressed after this PR without impact. https://github.com/opensearch-project/ml-commons/actions/workflows/test_bwc.yml?query=branch%3A2.x

Yes, the BWC seems not related with this PR. It failed weeks ago. I guess the reason is 2.10 OpenSearch not ready yet, so we can't start 2.10 cluster to do BWC test.

Thanks for merge!


unexpected response: '220 smtp.gmail.com ESMTP i7sm2984410igt.18 - gsmtp'

I'm trying to test the IMAP FDW following the example:
http://multicorn.org/foreign-data-wrappers/#idimap-foreign-data-wrapper
I'm getting this error in pgAdmin and pqsl:
ERROR:  Error in python: abort
DETAIL:  unexpected response: '220 smtp.gmail.com ESMTP p82sm3981275ioi.14 - gsmtp'

I have tried disabling 2FA and some other settings in Gmail, but it doesn't seem to help.
I tried the same with a non-Gmail IMAP server and the FDW is working fine.

It appears you are connecting to an SMTP server. Could you try to set the "port" option to 993 (IMAPS) ?
By the way, testing your use case made me realize that there may be a bug with imap fdw and python 3, I'll look into it.
Thank you for your interest in Multicorn !

@rdunklau You're right, I was following the example directly here:
http://multicorn.org/#idusage
It has port 465, which is SMTP:
create foreign table gmail (
    "Message-ID" character varying,
    "From" character varying,
    "Subject" character varying,
    "payload" character varying,
    "flags" character varying[],
    "To" character varying) server multicorn_imap options (
        host 'imap.gmail.com',
        port '465',
        payload_column 'payload',
        flags_column 'flags',
        ssl 'True',
        login 'mylogin',
        password 'mypassword'
);

I fixed that and now I'm getting:
ERROR:  Error in python: error
DETAIL:  [ALERT] Please log in via your web browser: https://support.google.com/mail/accounts/answer/78754 (Failure)

I tried a different Gmail account and was able to get it working correctly. I think the above error is because the multicorn.imapfdw.ImapFdw isn't handling passwords with special characters correctly.

I tested it with an account with "special characters" in the password, and did not have any trouble. Gmail can be a pain to work with using standard protocols. Did you try what is advised here: https://support.google.com/accounts/answer/6010255 ?
Thank you for the report on the website, it is obviously an error on it, although I swear gmail was listening for IMAP connection on the SMTP port at the time this was written :). It is now fixed.


add container testenv

This adds the ability to run a test using a container as a managed
host.  This depends on having podman installed on your local
system.  It also requires jq.
The interface was chosen to be as similar to runqemu as possible.
You run it like this:
tox -e container-ansible-core-2.12 -- --image-name centos-8 tests/tests_default.yml
This depends on https://github.com/linux-system-roles/linux-system-roles.github.io/pull/76
which adds containers for the image names, so that e.g. --image-name centos-8
is mapped to quay.io/centos/centos:stream8.
The script will build a local test image using the specified container as
a base image.  The test image will have a dnf/yum update, additional
repos configured, and any other setup steps performed.  This is useful if
you plan to run multiple tests and do not want to go through the setup
every time.  The test image will be automatically recreated if it is
too old.  You can force it to be recreated by using the
--erase-old-snapshot flag which works similar to runqemu.

This is based on the work done at https://github.com/linux-system-roles/network/tree/main/.github

lgtm
Sorry, this is "out of scope" of the pr review, but interestingly, comparing the test duration of container with the qemu-vm's, the latter runs faster for me. Need more research, but it looks to me the playbook execution itself is faster on the vm. (note that both are running on my laptop...) Could there be any way to tune up the container???
time tox -e container-ansible-core-2.12 -- --image-name centos-8 tests/tests_default.yml tests/tests_enabled.yml tests/tests_version.yml real 3m55.811s user 1m20.613s sys 0m32.507s
real 3m39.149s user 1m16.663s sys 0m31.872s
time tox -e qemu-ansible-core-2.12 -- --image-name centos-8 tests/tests_default.yml tests/tests_enabled.yml tests/tests_version.yml real 1m47.936s user 0m26.334s sys 0m6.113s
real 1m50.093s user 0m27.564s sys 0m6.234s

One thing to note is that the container test does the equivalent of using --use-snapshot the first time you use it.  That is, if podman images does not have a lsr-test-centos-8:latest image (or if it is too old), then tox -e container-ansible-core-2.12 will create it, which takes a while to do the yum update and etc.  Also, I'm assuming that you had already pulled the both the container and the VM image for centos-8 locally.

hmm - even after using a snapshot for qemu and the container - here are the results for a rhel-9 image with logging tests_ovirt_elasticsearch.yml running on F35 controller:
qemu
PLAY RECAP *********************************************************************
/home/rmeggins/.cache/linux-system-roles/centos-9.qcow2.snap : ok=265  changed=52   unreachable=0    failed=0    skipped=177  rescued=0    ignored=0

Friday 08 April 2022  13:44:40 -0600 (0:00:00.879)       0:02:04.838 **********
===============================================================================
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Purge - remove files not generated by current state --- 4.75s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/main.yml:269 ----
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 2.82s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 2.82s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 2.66s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 2.58s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 2.55s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 2.52s

container
PLAY RECAP *********************************************************************
620b18550edaf768196e8e5334dd7c50538fa768fe43c825a34588cdc7ec4366 : ok=258  changed=44   unreachable=0    failed=0    skipped=184  rescued=0    ignored=0

Friday 08 April 2022  13:51:43 -0600 (0:00:02.270)       0:06:18.972 **********
===============================================================================
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Purge - remove files not generated by current state -- 21.50s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/main.yml:269 ----
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d -- 12.96s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d -- 12.95s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d -- 10.94s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d -- 10.44s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d -- 10.24s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d -- 10.20s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d -- 10.16s
/home/rmeggins/linux-system-roles/logging/roles/rsyslog/tasks/deploy.yml:13 ---
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 9.80s

It seems that with containers, the I/O intensive operations are much, much slower.  Not sure what's going on there.
Another reason for using containers is that we can use github actions to run integration tests.  This is what network does e.g. https://github.com/linux-system-roles/network/runs/5873286772?check_suite_focus=true.  It would be nice to leverage the resources we get by using github - perhaps move some of the centos/fedora testing to github actions from our current CI.

why is my container storage so slow, and what can I do about it?  https://www.redhat.com/sysadmin/podman-rootless-overlay

One thing to note is that the container test does the equivalent of using --use-snapshot the first time you use it. That is, if podman images does not have a lsr-test-centos-8:latest image (or if it is too old), then tox -e container-ansible-core-2.12 will create it, which takes a while to do the yum update and etc. Also, I'm assuming that you had already pulled the both the container and the VM image for centos-8 locally.

Yes, I skipped the first result from both containers' and VMs'. For container, it's using the local image; for VM, it's getting qcow2 from my .cache dir.
And thank you for sharing the advantages of using container. Indeed, it's useful for many cases.
Once again, I already gave my approval to this pr. If there's no objection from the other reviewers, please go ahead and merge it. Thanks!

why is my container storage so slow, and what can I do about it? https://www.redhat.com/sysadmin/podman-rootless-overlay

hmm - well that didn't seem to make any difference . . .

As usual, some storage tests require large disk space... How can we support it with container?
TASK [Exit playbook when there's not enough unused disks in the system] ***************
task path: /home/nhosoi/linux-system-roles/storage/tests/get_unused_disk.yml:14
Friday 08 April 2022  14:33:11 -0700 (0:00:00.027)       0:04:54.580 **********
fatal: [c7c58d2f7cee61ac707a38508aca21da11fcb72c4e3a3576d5ac7a27dce3067b]: FAILED! => {
    "changed": false
}
MSG:
Unable to find enough unused disks. Exiting playbook.

As usual, some storage tests require large disk space... How can we support it with container?
TASK [Exit playbook when there's not enough unused disks in the system] ***************
task path: /home/nhosoi/linux-system-roles/storage/tests/get_unused_disk.yml:14
Friday 08 April 2022  14:33:11 -0700 (0:00:00.027)       0:04:54.580 **********
fatal: [c7c58d2f7cee61ac707a38508aca21da11fcb72c4e3a3576d5ac7a27dce3067b]: FAILED! => {
    "changed": false
}
MSG:
Unable to find enough unused disks. Exiting playbook.

good question - not sure - maybe the same way we support storage with qemu serialization

why is my container storage so slow, and what can I do about it? https://www.redhat.com/sysadmin/podman-rootless-overlay

hmm - well that didn't seem to make any difference . . .

@vrothberg - any idea what I can do to improve the I/O performance?

why is my container storage so slow, and what can I do about it? https://www.redhat.com/sysadmin/podman-rootless-overlay

hmm - well that didn't seem to make any difference . . .

@vrothberg - any idea what I can do to improve the I/O performance?

Hard to say without a knowing the version of Podman or the distribution it runs on. Rootless containers with fuse-overlayfs can have noticeably slower I/O than rootless ones due to the FUSE overhead. However, Podman supports native overlay since last year (see https://www.redhat.com/sysadmin/podman-rootless-overlay). I assume that your machine is probably too old?

I'm running on the latest Fedora 35 - podman-3.4.4-1.fc35.x86_64
Is there some way I can tell if the running container is using fuse-overlayfs vs. kernel overlayfs?

Is there some way I can tell if the running container is using fuse-overlayfs vs. kernel overlayfs?

Does podman info|grep fuse show fuse-overlayfs?  You probably need to run podman system reset in that case. Note that'll remove all local images, containers, etc.

Is there some way I can tell if the running container is using fuse-overlayfs vs. kernel overlayfs?

Does podman info|grep fuse show fuse-overlayfs?

>podman info|grep -i fuse
nothing
>podman info|grep -i overlay
  graphDriverName: overlay
    Native Overlay Diff: "true"

You probably need to run podman system reset in that case. Note that'll remove all local images, containers, etc.

I did a podman system reset - does not help

Thanks for checking!  Could you retry using containers but as root?  Just to figure out if it relates to rootless containers.

Thanks, @richm!  One last idea before pulling in more folks: could you try with --privileged? That will disable a number of security mechanisms which may impact performance, depending on the workload.

Thanks, @richm! One last idea before pulling in more folks: could you try with --privileged? That will disable a number of security mechanisms which may impact performance, depending on the workload.

All of runs used this: https://github.com/linux-system-roles/tox-lsr/pull/74/files#diff-2c417477ae781b7dded9b6f7e559e5acee8dd7861b3f80b952a39676d12e0818R209-R210
so
podman run --privileged --systemd=true -v /sys/fs/cgroup:/sys/fs/cgroup quay.io/centos/centos:stream8 /usr/sbin/init

then used ansible-playbook -c podman -i $container_id ... to run ansible against the container
so perhaps the performance hit is in ansible or the podman connector - but it is very telling that the most I/O intensive tasks are much, much slower using podman

then used ansible-playbook -c podman -i $container_id ... to run ansible against the container so perhaps the performance hit is in ansible or the podman connector - but it is very telling that the most I/O intensive tasks are much, much slower using podman

That would make sense.  Is data copied into the container when running ansible-playbook?

then used ansible-playbook -c podman -i $container_id ... to run ansible against the container so perhaps the performance hit is in ansible or the podman connector - but it is very telling that the most I/O intensive tasks are much, much slower using podman

That would make sense. Is data copied into the container when running ansible-playbook?

Well, I'm not exactly sure how the -c podman connector works.  If it works like the ssh connector, then each task copies a tarball containing the source code for the task and supporting files.  These are usually pretty small and can be cached in the container.  But perhaps -c podman uses something else like a volume mount for these temp files instead of some sort of file transfer mechanism.  Not sure.  But for example, the task "Purge - remove files" - that is almost entirely file lookup and deletion operations run inside the container.
/var/tmp/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Purge - remove files not generated by current state -- 17.12s
/var/tmp/logging/roles/rsyslog/tasks/main.yml:269 -----------------------------
/var/tmp/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 9.37s
/var/tmp/logging/roles/rsyslog/tasks/deploy.yml:13 ----------------------------
/var/tmp/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 8.91s
/var/tmp/logging/roles/rsyslog/tasks/deploy.yml:13 ----------------------------
/var/tmp/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Generate role configuration files in rsyslog.d --- 8.73s

Compare that run time to the run time of the same task running in a qemu VM:
/home/rmeggins/linux-system-roles/logging/tests/roles/linux-system-roles.logging/roles/rsyslog : Purge - remove files not generated by current state --- 4.75s

Not sure why the container task takes over 3 times as long.

@richm, @vrothberg, good news!
To try to test even with the newer version of podman, I've setup fedora 36, on which podman-4.1.0-1.fc36.x86_64 is installed. I compared the same two command lines in https://github.com/linux-system-roles/tox-lsr/pull/74#pullrequestreview-936824926
Then, I got this better result for the container. (this pair is an average of 3 runs on each case)
container: 54.49 (sec)
qemu-vm: 64.19 (sec)

I'd think we could say the ansible tests run faster on the newer versions (>= 4.1.0) of podman?

@richm, @vrothberg, good news!
To try to test even with the newer version of podman, I've setup fedora 36, on which podman-4.1.0-1.fc36.x86_64 is installed. I compared the same two command lines in #74 (review) Then, I got this better result for the container. (this pair is an average of 3 runs on each case)
container: 54.49 (sec)
qemu-vm: 64.19 (sec)

I'd think we could say the ansible tests run faster on the newer versions (>= 4.1.0) of podman?

Yes, sounds good.  Valentin - any plans to make this version of podman available in rhel9 or rhel8?

Yes, sounds good. Valentin - any plans to make this version of podman available in rhel9 or rhel8?

At least, we have podman-4.1.0-2 or -3 builds for el8 and el9 on brew...

lgtm
Good to merge, isn't it?

Yes - I just did a rebase to the latest main branch - if tests pass I will merge


Any way to connect new devices to the bridge?

Awesome program, I'm using it to avoid using Lutron's app.
Keeping with that, is there any way to connect new Caseta devices to the smart bridge using this? Thanks.

It should be possible, but it is not currently supported.

What would be involved in adding it? Would I need to sniff traffic between the Lutron app and the smart bridge? What method do you guys use for that?

The easy way will be to patch the APK such that the TCP client logs the messages it sends and receives, similar to this https://blog.securityevaluators.com/how-to-view-tls-traffic-in-androids-logs-6a42ca7a6e55.
To enable and disable pairing you want
{"Body":{"SystemStatus":{"InAssociationMode":true}},"CommuniqueType":"UpdateRequest","Header":{"Url":"/system/status"}}
{"Body":{"SystemStatus":{"InAssociationMode":false}},"CommuniqueType":"UpdateRequest","Header":{"Url":"/system/status"}}

To which the bridge will respond with something like this
{"CommuniqueType":"UpdateResponse","Header":{"MessageBodyType":"OneSystemStatus","StatusCode":"200 OK","Url":"/system/status"},"Body":{"SystemStatus":{"InAssociationMode":true,"OperatingMode":"Association","System":{"href":"/system"},"UserAccessControlProperties":{"Status":"Active"}}}}

Then you need to subscribe to device notifications like this
{"CommuniqueType":"SubscribeRequest","Header":{"Url":"/device/status/deviceheard"}}

I don't know what a deviceheard notification will look like. Once you get one I assume you need to do something to accept it into your system.
If you're going to add this functionality you'll probably also want to do something when devices are detected. I think right now pylutron_caseta requires a restart after a new device is added.

Okay, I was able to get the device heard notification with this code:
res = await bridge._request(
    'UpdateRequest',
    '/system/status',
    {
        'SystemStatus': {
            'InAssociationMode': True
        }
    }
)

print('update response:', res)

def print_heard(x):
    print('device heard:', x)

res = await bridge._subscribe(
    '/device/status/deviceheard',
    print_heard
)

print('subscribe response:', res)

while True:
    await asyncio.sleep(1)

Here it is:
Response(Header=ResponseHeader(StatusCode=ResponseStatus(200, 'OK'), Url='/device/status/deviceheard', MessageBodyType='OneDeviceStatus'), CommuniqueType='UpdateResponse', Body={'DeviceStatus': {'DeviceHeard': {'DiscoveryMechanism': 'UserInteraction', 'ModelNumber': 'PD-6WCL-XX', 'DeviceType': 'WallDimmer', 'SerialNumber': 57843518, 'PairedDevices': {'Count': 1}}}})

Do you happen to have a patched Lutron APK that I could use to get the traffic?
Or an educated guess as to what the "add device" command would be?

Alright, I was able to patch the .apk and got these outgoing messages:
{"Body":{"SystemStatus":{"InAssociationMode":true}},"CommuniqueType":"UpdateRequest","Header":{"ClientTag":"78f01ec8-b07d-4f09-8385-724907a721ed$26$","Url":"/system/status"}}
{"CommuniqueType":"ReadRequest","Header":{"ClientTag":"78f01ec8-b07d-4f09-8385-724907a721ed$27$","Url":"/project/devicerule/1"}}
{"CommuniqueType":"SubscribeRequest","Header":{"ClientTag":"78f01ec8-b07d-4f09-8385-724907a721ed$","Url":"/device/status/deviceheard"}}
{"Body":{"Area":{"href":"/area/3","Category":{"Type":"Kitchen"},"Name":"Kitchen","Parent":{"href":"/area/1"}}},"CommuniqueType":"UpdateRequest","Header":{"ClientTag":"78f01ec8-b07d-4f09-8385-724907a721ed$28$","Url":"/area/3"}}
{"Body":{"Device":{"Name":"Main Lights","SerialNumber":57843518,"AssociatedArea":{"href":"/area/3"}}},"CommuniqueType":"CreateRequest","Header":{"ClientTag":"78f01ec8-b07d-4f09-8385-724907a721ed$29$","Url":"/device"}}
{"Body":{"Zone":{"Category":{"Type":"CeilingMain"}}},"CommuniqueType":"UpdateRequest","Header":{"ClientTag":"78f01ec8-b07d-4f09-8385-724907a721ed$30$","Url":"/zone/3"}}
{"CommuniqueType":"SubscribeRequest","Header":{"ClientTag":"78f01ec8-b07d-4f09-8385-724907a721ed$","Url":"/service/autoprog/event/status"}}
{"Body":{"SystemStatus":{"InAssociationMode":false}},"CommuniqueType":"UpdateRequest","Header":{"ClientTag":"78f01ec8-b07d-4f09-8385-724907a721ed$31$","Url":"/system/status"}}

Okay I was able to create a little script to add a new light switch to the bridge:
└─► python add_device.py
connecting to bridge...
entering association mode...
association mode response: OK
subscribe deviceheard response: OK
==== Please hold the bottom button for 10 seconds...
device heard: Response(Header=ResponseHeader(StatusCode=ResponseStatus(200, 'OK'), Url='/device/status/deviceheard', MessageBodyType='OneDeviceStatus'), CommuniqueType='UpdateResponse', Body={'DeviceStatus': {'DeviceHeard': {'DiscoveryMechanism': 'UserInteraction', 'ModelNumber': 'PD-6WCL-XX', 'DeviceType': 'WallDimmer', 'SerialNumber': 64158463}}})
Saw device: 64158463
==== What do you want to name it? Qot.
adding device...
add device response: OK, zone: /zone/9
updating devices...
done updating
exiting association mode...
association mode response: OK
finished.

Source code is here: https://gist.github.com/tannercollin/4d408bcad87c90f925b2fbc682ed925d


KeyError in Sample.py

I used the program all the day and it worked great but with my last experiment I got the following error message:
Traceback (most recent call last):
File "sample.py", line 46, in
main()
File "sample.py", line 27, in main
sample(args)
File "sample.py", line 43, in sample
args.sample).encode('utf-8'))
File "C:\Daten\Programmierung\Python\JokeGenerator\char-rnn-tensorflow-master\char-rnn-tensorflow-master\model.py", line 106, in sample
x[0, 0] = vocab[char]
KeyError: ' '
Seems like anything is wrong with the arguments, but I haven't changed anything.
BTW, really nice program & fun to use. Thank you.

python --prime (your input )
dont use double quotes for input word


encoding/csv: document that Writer is buffered

csv.Writer is implemented as a bufio.Writer, but this isn't clearly documented.  The only place buffering is mentioned is in the Writer example and in the Flush() method.  This makes it easy for a user to neglect to flush the underlying buffer and check for an error when writing a CSV, which can result in data loss.  I believe the documentation on csv.Writer should clearly state that the implementation is buffered and thus must be flushed.  Here is the current documentation:
// A Writer writes records to a CSV encoded file.
//
// As returned by NewWriter, a Writer writes records terminated by a
// newline and uses ',' as the field delimiter. The exported fields can be
// changed to customize the details before the first call to Write or WriteAll.
//
// Comma is the field delimiter.
//
// If UseCRLF is true, the Writer ends each output line with \r\n instead of \n.
type Writer struct {
	Comma   rune // Field delimiter (set to ',' by NewWriter)
	UseCRLF bool // True to use \r\n as the line terminator
	w       *bufio.Writer
}

Why is the encoder buffered in the first place? It seems a completely unrelated concern...

Using a buffer is a simple way to pick up convenience methods like WriteString, WriteByte, WriteRune.  Of course it then requires flushing.


CSHARP-664 Implement SKIP_METADATA for protocols v5+ and fix CSHARP-896

[x] add tests
[x] test both paging_state and new_metadata_id flags at the same time (I think they're being parsed in the wrong order) - CSHARP-896
[x] performance tests (use DSE 6.7 to compare this branch vs master)

Note: this PR also includes some improvements to the ISerializer references but I tried to split them into a separate commit for an easier review (it's not a perfect split though, so the first commit will probably not compile)

Benchmarks show an improvement in throughput and cpu usage for read workloads when using protocol v5+ (Apache Cassandra 4.0+) or DseV2 (DSE 6.0+)


StackNavigator - missing back button arrow

Environment
React Native Environment Info:
System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Memory: 320.19 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.12.0 - ~/.nvm/versions/node/v8.12.0/bin/node
npm: 6.4.1 - ~/.nvm/versions/node/v8.12.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 23.0.1, 25.0.0, 26.0.3, 27.0.3, 28.0.3
API Levels: 22, 23, 25, 26, 27, 28
IDEs:
Android Studio: 3.2 AI-181.55<IP_ADDRESS>14246
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.1 => 0.57.1
npmGlobalPackages:
react-native-cli: 2.0.1
The question:
Hi all,
I've noticed a strange behavior of RN while building it on Travis.
It is connected to the issue: #2918
So while building it in Release mode on Travis CI, app is missing back arrow while navigating into detail screen (using StackNavigator). While using development scheme it does not happen.
Also, I've re-created Travis environment (same Xcode, same node, using same fastlane script to build in Release, same commit). While building the app using CLI tools in Release mode on my Mac, the app acts normal. Also, building with Xcode in Release mode it is ok.
The flow:
react-native bundle --entry-file='index.js' --bundle-output='./ios/main.jsbundle' --dev=false --platform='ios'

and then:
fastlane ios beta

which is:
platform :ios do
  lane :build do |options|
    scheme = options.fetch(:scheme, "myApp")
    gym(scheme: scheme, include_bitcode: false, export_method: "enterprise")
end

What it looks like:

What it should look like:

The environment:
Xcode 9.4.1
Node: 8.12.0 NPM: 6.4.1
React-native-cli: 2.0.1
dependencies:
"react": "16.5.0",
"react-native": "0.57.1",
"react-native-fabric": "^0.5.2",
"react-navigation": "^2.17.0"
The StackNavigator is embedded inside TabNavigator as one of the tabs.
Anyone have an idea why it happens?

@react-native-bot done.

Looks like it was an issue with assets generating and linking.
I've added:
--assets-dest ./ios
flag to:
react-native bundle
command, then added ios/assets directory as folder reference in Xcode.
It started working. But still- why it did work while bundling the app in Release locally with static bundle?


Default value is not populating on latest RN 0.68.2, using react-native-mask-text version 0.7.0

Steps to reproduce

Add a default value, or try to reset form with default value
Default value will never populate if there is a mask

Expected behaviour
The default value should populate, and it did on previous versions
Actual behaviour
The default value never populates, not sure why
Environment

React Native version:  0.68.2
React Native platform + platform version: iOS 9.0, Android 5.0, etc: latest ios/ android
Typescript version (if using typescript): 3.8+ required, what version is in your environment? : "typescript": "^4.3.4"

react-native-mask-text: 0.7.0
EDIT: defaultValue works on "react-native-mask-text": "^0.2.2", ... also worth noting that autoCapitalize does not work either

Having the same problem


Add orWhereFuzzy search option

Hi,
Was looking for a replacement for Searchy and came across your implementation.
In my use case, I need an orWhereFuzzy, so that the query returns results having at least one relevance index > 0  as opposed to having all of them > 0.
Tried contributing but need access.
I have attached the needed changes here if you are kind enough to include them.
orWhereFuzzy.zip
Thank you,
Catalin Nita.

Hi Catalin,
That all sounds very intriguing. I'd be interested in seeing what you come up with, so feel free to show me something when you feel it's ready :)
Best,
Matt

Hi Matt,
Sorry for being off, but had some health issues I needed to attend.
The issues you listed above are valid and I will have a look soon to address them.
Thank you,
Catalin.

No problem. Hope all is okay with you.

Hi Matt,
I'm ok now, thank you.
Looked over the issues:

I have now updated the order by fuzzy class so that we can still use it (there might be a time when we have the same score on the total columns, but want to differentiate, to give priority to one)
Updated to use query builder
Actually removed ->getQuery() after query builder class update
Added new test cases for the updates

Can you grant me access to create a pull request as it comes much easier for me than zip archives
Thank you,
Catalin Nita.

Hi Catalin,
You should be able to create a PR. Can you fork the project, then make changes and submit a PR back to the main repo?

Hi,
Done! Let me know if anything else pops out. You can also make whatever changes you feel like.
Thanks,
Catalin.

All merged in. Thanks!

Released as version 2

Cool, thank you!


cmd/compile/internal/gc: esc.go duplicated sink paths for re-assignments

Given this code:
/* 1*/ package example
/* 2*/
/* 3*/ var sink interface{}
/* 4*/
/* 5*/ func fn() {
/* 6*/ 	var x *int
/* 7*/ 	x = new(int)
/* 8*/ 	sink = x // Sink 1 at the line 8; first new(int) flows here
/* 9*/ 	x = new(int)
/*10*/ 	sink = x // Sink 2 at the line 10; second new(int) flows here
/*11*/ }

(Code annotated with line number for convenience, minimal example outlined after the issue description.)
Execute the command $ go tool compile -m=2 example.go.
The output on tip is (important bits are in bold):

example.go:5:6: can inline fn as: func() { var x *int; x = ; x = new(int); sink = x; x = new(int); sink = x }
example.go:8:7: x escapes to heap
example.go:8:7: 	from sink (assigned to top level variable) at example.go:8:7
example.go:7:9: new(int) escapes to heap
example.go:7:9: 	from x (assigned) at example.go:7:4
example.go:7:9: 	from x (interface-converted) at example.go:8:7
example.go:7:9: 	from sink (assigned to top level variable) at example.go:8:7
example.go:9:9: new(int) escapes to heap
example.go:9:9: 	from x (assigned) at example.go:9:4
example.go:9:9: 	from x (interface-converted) at example.go:8:7
example.go:9:9: 	from sink (assigned to top level variable) at example.go:8:7
example.go:10:7: x escapes to heap
example.go:10:7: 	from sink (assigned to top level variable) at example.go:10:7

Expected output would not report second sink to the same location.
This is a consequence of how graph is constructed and printed.
Simplified example:
package example

var sink *int

func fn() {
	var x *int
	x = new(int)
	sink = x
	x = new(int)
	sink = x
}

And the output:

example.go:5:6: can inline fn as: func() { var x *int; x = ; x = new(int); sink = x; x = new(int); sink = x }
example.go:7:9: new(int) escapes to heap
example.go:7:9: 	from x (assigned) at example.go:7:4
example.go:7:9: 	from sink (assigned to top level variable) at example.go:8:7
example.go:9:9: new(int) escapes to heap
example.go:9:9: 	from x (assigned) at example.go:9:4
example.go:9:9: 	from sink (assigned to top level variable) at example.go:8:7

Expected output:

example.go:5:6: can inline fn as: func() { var x *int; x = ; x = new(int); sink = x; x = new(int); sink = x }
example.go:7:9: new(int) escapes to heap
example.go:7:9: 	from x (assigned) at example.go:7:4
example.go:7:9: 	from sink (assigned to top level variable) at example.go:8:7
example.go:9:9: new(int) escapes to heap
example.go:9:9: 	from x (assigned) at example.go:9:4
example.go:9:9: 	from sink (assigned to top level variable) at example.go:10:7

For that example, we have something like this:

sink pseudo node has 2 source edges, both comes from x node.
x node has 2 source edges, they come from the two different new(int)

sink.Flowsrc == { {dst=sink, src=x, where=line8}, {dst=sink, src=x, where=line10} }
x.Flowsrc == { {dst=x, src=new(int), where=line7 }, {dst=x, src=new(int), where=line9} }

During traversal in escwalkBody, both new(int) paths are printed using first sink destination as a parent, so we get two same paths. For the second destination nothing is printed due to osrcesc variable check that is used to avoid duplicated messages.
If osrcesc is removed, both paths are printed twice (so, 4 messages instead of 2, but 2 of them are correct). Currently, osrcesc leads to 2 messages, 1 of which is incorrect.
It's not enough to just check whether destination node located before the actual starting flow point because of recursive functions:
func f8(x int, y *int) *int {
	if x <= 0 {
		return y
	}
	x--
	return f8(*y, &x)
}

Here the return y is a destination endpoint, and it comes before the tracked &x.
I have no good ideas on how to fix this one.
Hopefully, insights above can help someone to roll the solution to this.

Don't know who to CC. Maybe @josharian?

@dr2chase is primary for escape analysis (AFAIK); he wrote the escape analysis explainer. The other person that comes to mind is @cherrymui.

It seems to me a deeper issue is that the analysis of data flow is on the node level, where all occurrences of x are represented with the same node. For example, if I remove the second sink=x assignment, i.e.
package example

var sink *int

func fn() {
	var x *int
	x = new(int)
	sink = x
	x = new(int)
	_ = x
}

The second new(int) does not necessarily escape. With the current analysis, it does escape, because the new(int) flows to x, and x, at some point, flows to heap. In the original program, it doesn't really matter when/where x flows to heap; it just picks one.
For this, I think that the analysis would need to work on a level that tracks the order of data flow (probably some form of SSA). And more accurate location report would follow naturally.

The second new(int) does not necessarily escape. With the current analysis, it does escape, because the new(int) flows to x, and x, at some point, flows to heap. In the original program, it doesn't really matter when/where x flows to heap; it just picks one.

I actually tried to make exactly this, to teach escape analysis to recognize that second new(int) is unnecessary, but encountered unexpected debug output that made me wonder.


Image Upload Dialog

This PR includes dialog components for uploading the user's profile picture, an institution profile picture and the institution background image.
It updates the already previously used package material-file-dropzone to the still somewhat maintained package mui-file-dropzone, which is also compatible with MUI 5.
In addition, it introduces a dependency on react-image-crop for image cropping.
The components can be found in components/general/upload. They behave like normal dialogs with an open and an onClose property. The ProfileImageUploadDialog is already integrated, so for example usage see components/ProfileImage.
This is how it looks like (colors are a bit broken by the screen recorder):

The upload itself does not currently work because https://github.com/jst-seminar-rostlab-tum/genomics.ai/pull/21 is not merged & not online, but it should in theory.

Because I love demo videos, here's another one:
https://user-images.githubusercontent.com/9006596/165954176-cc09de27-3fb5-4aa4-9a91-a49ba6556c64.mp4

Because I love demo videos, here's another one:
https://user-images.githubusercontent.com/9006596/165954176-cc09de27-3fb5-4aa4-9a91-a49ba6556c64.mp4

The upload itself does not currently work because #21 is not merged & not online, but it should in theory.

It's now actually battletested against a development server instance (which is also the new BACKEND_ADDRESS used in this PR). Thanks to @FabianNowak for providing that to me!


Possible bugs in sample_weight in model.fit() for RNN

Hi there,
From Keras's documentation it says that:

For time-distributed data, there is one weight per sample per timestep, i.e. if your output data is shaped (nb_samples, timesteps, output_dim), your mask should be of shape (nb_samples, timesteps). This allows you to mask out or reweight individual output timesteps, which is useful in sequence to sequence learning.

However, I happened to find that the sample_weight should have shape (nb_samples, timesteps, 1), otherwise there will be some shape mismatch errors.
If we do prefer (nb_samples, timesteps), then there is a bug in:
https://github.com/fchollet/keras/blob/master/keras/models.py#L83-85
Because we need to expand the shape of sample_weight

The shape of sample_weight is in fact expanded to match the expected size mentioned in the documentation:
https://github.com/fchollet/keras/blob/master/keras/models.py#L98
https://github.com/fchollet/keras/blob/master/keras/models.py#L100
Can you clarify what you mean?

Hi @fchollet , so sorry I just saw your reply...
I mean if I do provide a sample_weight in fit(), then it should be call first:
https://github.com/fchollet/keras/blob/master/keras/models.py#L85
then:
https://github.com/fchollet/keras/blob/master/keras/models.py#L20-25
but in the later function it doesn't expand sample_weight if len(y.shape) > 1
So a quick fix would be changing keras's documentation for sample_weight in model.fit() to:

For time-distributed data, there is one weight per sample per timestep, i.e. if your output data is shaped (nb_samples, timesteps, output_dim), your mask should be of shape (nb_samples, timesteps, 1). This allows you to mask out or reweight individual output timesteps, which is useful in sequence to sequence learning.

If using sample_weight of shape (nb_samples, timesteps) there would be an error

It seems you're right. Would you like to submit a PR to update the documentation?

Sure :)
Sorry for the late response again

Hi @fchollet , the documentation on keras.io seems different from that on github, there is no sample_weight parameter in:
https://github.com/fchollet/keras/blob/master/docs/sources/models.md
I am afraid of potential conflict if I make a PR to update doc

You can just update the Github version, the keras.io version will be synced later.

Hi @fchollet , I closed the previous PR (my fork is far behind keras/master) and make a new PR


Add codes to jsonrpc api internal errors

Not on my side:
[gw4] [ 84%] PASSED tests/test_misc.py::test_not_announceable_spend
...
33 passed in 931.04s (0:15:31)

Re-testing with bitcoind 0.21.1


Many functions not chainable because of f(i,k) 1st arg

In lodash/underscore, most functions are chainable because function callbacks are passed a value. That allows constructs such as this in JavaScript:
local positives = _.map({1,-2,3,-4}, math.abs)

Such constructs don't work in Moses because some (but not all) functions are passed in index argument before a key argument. This is essential for efficient Lua, but undesirable when function chaining is desired. Here's what you currently have to do in Moses:
positives = moses.map({1,-2,3,-4}, function(i,v) return math.abs(v) end)

And because of this, Moses has great function chaining functions like pipe() and compose() that it seems like I never have a chance to use.
Off the top of my head, one idea is to create a new method with an "i" suffix when a callback function will be passed an index before a key. Eg:
positives = moses.mapi({1,-2,3,-4}, function(i,v) return math.abs(v) end)
-- or
positives = moses.map({1,-2,3,-4}, math.abs)

This is something I was aware of, and I am planning working on this.
I was not considering adding new methods with "i" suffixes, as it would clunk too much the actual code, with too much duplicates, in my opinion. Instead I was considering reworking the whole library itself, so that constructs will accept/look for values first, indices next.
This sounds like a viable option, but will need a lot of work, and will introduce breaking changes.

Breaking changes are OK, and thanks to SemVer, we have an easy way to communicate them automatically to users and dependent modules.

Seems like a lot of refactoring so someone doesn't have to do this:
local function f(inner)
	return function (i,v) return inner(v) end
end
positives = m.map({1,-2,3,-4}, f(math.abs))
positives = m.map({1,-2,3,-4}, f(math.deg))
positives = m.map({1,-2,3,-4}, f(math.ceil))

This have been fixed with commit 9bf8520.


feat: add code for alizer npm package

it resolves #20
cc @evidolob

See comments and

nice to have a few unit tests
language.yml file duplicated, at least open an issue to share it between implementations
add or edit workflows

I just copied everything as it is here so yevhen can start working with it. I'll open new issues for the second/third point

See comments and

nice to have a few unit tests
language.yml file duplicated, at least open an issue to share it between implementations
add or edit workflows

I just copied everything as it is here so yevhen can start working with it. I'll open new issues for the second/third point

Point 3 is required for us to validate changes

All yours @jeffmaury


Merge bsnbranch into bluetooth5

DO NOT MERGE YET! Need to commit more changes.

OK, I think it is ready for merging now.

Hi, Will
I tried to test to test bsncent + bsnprph, but encountered some issues:
When bsnprph starts:
000000 [ts=0ssb, mod=4 level=1] GAP procedure initiated: advertise; disc_mode=2 direct_addr_type=0 direct_addr=00:09:09:09:0b:0a adv_channel_map=0 own_addr_type=0 adv_filter_policy=0 adv_itvl_min=0 adv_itvl_max=0
000169 [ts=1320292ssb, mod=64 level=1] adv complete
000170 [ts=1328104ssb, mod=64 level=3] error setting advertisement data; rc=530

bsncent starts ok, but when I power on a peripheral, bsncent crashes on an assert:
005126 --
005126        0 connections
005126        0 packets received
005127        0 bytes received
005852 Assert @ 0xc3cb
005852 Unhandled interrupt (2), exception sp 0x200012f0
005852  r0:0x00000000  r1:0x00000000  r2:0x80000000  r3:0xe000ed00
005852  r4:0x0000c3cb  r5:0x2000138c  r6:0x0000c401  r7:0x00000000
005852  r8:0x00000000  r9:0x00000000 r10:0x00000000 r11:0x00000000
005852 r12:0x00000004  lr:0x0000cca9  pc:0x0000ccb8 psr:0x61000000
005852 ICSR:0x00421802 HFSR:0x00000000 CFSR:0x00000000
005852 BFAR:0xe000ed38 MMFAR:0xe000ed34

I made no changes to syscfgs.
BR,
Michał Narajowski

Thanks for testing this. I will take a look and see what is going on.

The problem seems to be corruption of the peer_chr_pool mempool.  The corruption occurs in ble_ll_scan_sm_start() here:
    if (scansm->next_phy != scansm->cur_phy) {
        scansm->phy_data[scansm->next_phy].scan_chan = BLE_PHY_ADV_CHAN_START;
    }

(gdb) p scansm->next_phy
$5 = 255 '\377'

I don't know this code at all, so my apologies if I have gotten something wrong.  It appears phy_data is a 1- or 2-element array, so this is an out of bounds write.  It seems next_phy is set to PHY_NOT_CONFIGURED; maybe this bit of code needs to check for this special value?

Thanks Chris. I took a look at the code and it seems to me that this is an expected case so next_phy should be checked for NOT_CONFIGURED as you suggest. I also looked at other calls to ble_ll_scan_sm_start() and I think that a check of cur_phy should be made as well, although this one should maybe be an assert().

I'll fix this next_phy thing in separate PR since this is a general issue, not something broken by this PR.

test this please


Article Length

This article is exceptionally long, please break it up into many articles that will be easier to read

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 632c11fa-8975-afd4-a050-7ff42ca3eb33
Version Independent ID: 2b736015-0f61-4159-e102-77a056f8abec
Content: Office 365 Data Service Requests Under the GDPR
Content Source: microsoft-365/compliance/gdpr-dsr-Office365.md
Product: microsoft-365-enterprise
GitHub Login: @BrendaCarter
Microsoft Alias: bcarter

This is by design; this is a user guide for all Office 365 applications.

most of the pages in Docs are less than 10 minutes to read, this one is more 2 hours which is entirely too long for reading online and keep track of where we are on the page


#3925 Enable Sending AdaptiveCards to Webex for Enhanced Alert Notifi…

Issue: #3925
I've implemented the feature to enable sending AdaptiveCards to Webex from Alertmanager. This enhancement aims to improve the clarity and interactivity of alert notifications.
I have conducted some tests, and you can find the attached results directly on the test Webex channel. If you have any questions or need further clarification, please feel free to reach out. I'm available for any discussions or additional testing as needed.
Thank you for considering this improvement!
@SimonPasquier

Add I rename the type of the struc Webex and not Webhook

We have the problem with other integrations like supporting AdaptiveCards in Microsoft Teams. However, I'm not a fan of giving users a big JSON blob to template as I have had to template JSON and YAML in Jinja2 templates in the past and it was a terrible experience. @gotjosh and @simonpasquier might have different opinions from mine, so I'll wait for them to give their thoughts on this.

We have the same problem in other integrations. For example, supporting AdaptiveCards in Microsoft Teams. However, I'm not a fan of giving users a big JSON blob to template. I have past experience of templating JSON and YAML in Jinja2 and it was awful. I don't want to push that onto users. @gotjosh and @simonpasquier might have different opinions from mine, so I'll wait for them to give their thoughts on this.

I understand your point. However, at the moment, we have tools that allow us to generate that large JSON blob, and this also helps us customize AdaptiveCards according to the alerts, which is what I’m doing in my case.
Is there a Slack channel, Discord server, or another place where we can discuss this further? Right now, the markdown alerts are not very appealing.

@gotjosh and @simonpasquier, do you have any thoughts on this topic?

I understand your point. However, at the moment, we have tools that allow us to generate that large JSON blob, and this also helps us customize AdaptiveCards according to the alerts, which is what I’m doing in my case.

That's great, but what about other Alertmanager users? That is the main problem I'm getting at here. You need tools to make generating JSON templates usable, and most users won't have such tools. Is the expectation on them to build their own?

I understand, and I think we can try to find a compromise between our two ideas. Why not offer a default template where we could simply fill in the title, body, buttons, etc., as you suggest in your PR? At the same time, we could also allow the integration of a JSON blob for those who want to customize their AdaptiveCard. There are tools like Adaptive Cards Designer or Webex Cards Designer that make generating these blobs easier.

I don't think either of those suggestions address the fundamental issue I'm afraid. Here is an example of what I'm getting at here. Here is an example of a template that it outputs invalid JSON if there are more than two alerts in the notification. This is just a simple example, what about debugging a template that's 10x the size? It's these kind of issues that make me hesitant to allow templating of JSON blobs.
{
    "type": "AdaptiveCard",
    "body": [
        {{ range .Alerts.Firing -}}
        {
            "type": "TextBlock",
            "text": "{{ .Labels }}",
            "wrap": true
        },
        {
            "type": "ActionSet",
            "actions": [{
                "type": "Action.OpenUrl",
                "title": "Silence",
                "url": "{{ .SilenceURL }}"
            }]
        }
        {{ end -}}
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.6"
}

I don't think either of those suggestions address the fundamental issue I'm afraid. Here is an example of a template that outputs invalid JSON if there are more than two alerts in the notification. This is quite a basic example, but what about debugging a template that is 10x the size with nested loops and if statements? It's these kind of issues that make me hesitant to allow templating of JSON blobs.
{
    "type": "AdaptiveCard",
    "body": [
        {{ range .Alerts.Firing -}}
        {
            "type": "TextBlock",
            "text": "{{ .Labels }}",
            "wrap": true
        },
        {
            "type": "ActionSet",
            "actions": [{
                "type": "Action.OpenUrl",
                "title": "Silence",
                "url": "{{ .SilenceURL }}"
            }]
        }
        {{ end -}}
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.6"
}

I understand your concern, and you're probably right that we need to find a solution to facilitate the integration of Adaptive Cards. I noticed your PR regarding Adaptive Cards; have you received any feedback on it?
I've also seen open PRs for integrating this feature into Slack, Teams, and Webex. I think it would be beneficial for us to discuss and come up with a common solution, especially since this feature is being requested across multiple platforms. What do you think?


Do you have a similar problem ? Report an error and the action recognition ends .

The output video is mirrored left and right .

ungrade opencv  solved the error 1

看起来你解决了问题了...

Hi, I just refactored the code to make it more readable, as well as making the API easier to use. Just for your information. Thanks for the support!


Error freezing saved model if it contains a tf.keras.layer.BatchNormalisation layer

System information

Have I written custom code: Yes
OS Platform and Distribution: Windows 1903
TensorFlow installed from: pip
TensorFlow version: 1.14.0
Python version: 3.7.3
GPU model and memory: RTX 2080 Ti

Problem
To make a frozen graph, I first create a saved model using tf.saved_model.simple_save and then freeze it using tensorflow.python.tools.freeze_graph.freeze_graph.
If a model contains some tf.keras.layers.BatchNormalisation layers, freezing will fail in TF 1.14.0 with:
ValueError: Tensor name 'batch_normalization/cond/ReadVariableOp/Switch:1' is invalid.
TF 1.13.1 does not give an error
Code to reproduce the issue
import tensorflow as tf
import tensorflow.keras.backend as K
import os
import datetime
from tensorflow.python.tools import freeze_graph
from tensorflow.keras.layers import Dense, Flatten, Conv2D, Input, Activation, BatchNormalization
from tensorflow.keras.models import Model

inputs = Input(shape=(128, 128, 1))
x = Conv2D(4, (3, 3))(inputs)
x = BatchNormalization()(x)
x = Activation('relu')(x)
x = Flatten()(x)
x = Dense(5, activation='softmax')(x)
model = Model(inputs, x, name='test')
model.compile(optimizer='adam', loss='categorical_crossentropy', metrics=['accuracy'])

K.set_learning_phase(0)
save_dir = "./tmp_{:%Y-%m-%d_%H%M%S}".format(datetime.datetime.now())
tf.saved_model.simple_save(K.get_session(),
                           save_dir,
                           inputs={"input": model.inputs[0]},
                           outputs={"output": model.outputs[0]})

freeze_graph.freeze_graph(None,
                          None,
                          None,
                          None,
                          model.outputs[0].op.name,
                          None,
                          None,
                          os.path.join(save_dir, "frozen_model.pb"),
                          False,
                          "",
                          input_saved_model_dir=save_dir)

Update:
Seems to be a problem in graph_util_impl.py, in particular https://github.com/tensorflow/tensorflow/commit/0f486fc67070ba888204741c404a55a5f1a41fbc#diff-2d2827fd48cee6884e3587c901ad6952
@gargn
If I change this file back to its 1.13 version there is no more error.
Update 2:
I put K.set_learning_phase(0) before creating the model, then it works. I don't know what effect this has though? Does it just turn off batch normalisation altogether?
Update 3
Final remarks:

Putting K.set_learning_phase(0) before creating the model will let it save, however the Batch Normalisation layer doesn't seem to do anything (updating turned off?) so it is not a solution.
Changing graph_util_impl.py to its 1.13.1 version will let it save without error, however there will be an error ValueError: Input 0 of node batch_normalization/cond/ReadVariableOp/Switch was passed float from batch_normalization/gamma:0 incompatible with expected resource. when loading the frozen graph from the protobuf.
The workaround is to save the model weights, clear the session (so that tensor names are not different because of having two graphs), set learning phase to 0, recreate the model, load the weights, and then freeze (example code in my comment below)

Same problem here with tensorflow-gpu 1.14.0, Ubuntu 16.04, Python 3.5.2.

@wenshuangwang I found if I put K.set_learning_phase(0) before constructing the model, then it works. But I don't know how this affects training?!

@geometrikal Thank you very much, it works for me as well. I think it's ok if training and freezing separately.
I know the second way, but I must use tf.keras to use tensorflow_model_optimization.sparsity.

@wenshuangwang Actually, I think putting K.set_learning_phase(0) before loading the model stops the batch normalisation layer from updating. I can tell a difference - I get worse accuracy (same as when not using batch normalisation) and the accuracy vs epochs graph looks different.

@wenshuangwang I finally found a workaround:

Create the model using a function (do not use K.set_learning_phase(0)):

def create_model():
    inputs = Input(...)
    ...
    return model

model = create_model()

Train model
Save weights:
model.save_weights("weights.h5")
Clear session and set learning phase to 0:

K.clear_session()
K.set_learning_phase(0)

Recreate model and load weights:

model = create_model()
model.load_weights("weights.h5")

Freeze as before

I have confirmed this works with no errors for creating the frozen model protobuf. Also there are no errors when loading the model either (using tf.import_graph_def), and it is working in my production code (using tensorflow java 1.14)
Here is full working example:
import tensorflow as tf
import tensorflow.keras.backend as K
import os
import datetime
from tensorflow.python.tools import freeze_graph
from tensorflow.keras.layers import Dense, Flatten, Conv2D, Input, Activation, BatchNormalization, Lambda
from tensorflow.keras.models import Model

def create_model():
    inputs = Input(shape=(128, 128, 1))
    x = Conv2D(4, (3, 3))(inputs)
    x = BatchNormalization()(x)
    # x = Lambda((lambda x: tf.layers.batch_normalization(x)))(x)
    x = Activation('relu')(x)
    x = Flatten()(x)
    x = Dense(5, activation='softmax')(x)
    model = Model(inputs, x, name='test')
    model.compile(optimizer='adam', loss='categorical_crossentropy', metrics=['accuracy'])
    return model

model = create_model()

# Training goes here...

model.save_weights("weights.h5")

K.clear_session()
K.set_learning_phase(0)

model = create_model()
model.load_weights("weights.h5")

save_dir = "./tmp_{:%Y-%m-%d_%H%M%S}".format(datetime.datetime.now())
tf.saved_model.simple_save(K.get_session(),
                           save_dir,
                           inputs={"input": model.inputs[0]},
                           outputs={"output": model.outputs[0]})

freeze_graph.freeze_graph(None,
                          None,
                          None,
                          None,
                          model.outputs[0].op.name,
                          None,
                          None,
                          os.path.join(save_dir, "frozen_model.pb"),
                          False,
                          "",
                          input_saved_model_dir=save_dir)

@geometrikal Yes, this is what I said to train and freeze the network separately. Thank you for explaining patiently.

@geometrikal Is this resolved by the suggestion of @wenshuangwang . Can we close the issue? Thanks!

@jvishnuvardhan I think this is a bug and should be left open.
The bug does not occur in normal keras, and it is clunky to have to create a copy of the graph and transfer the weights across just because you have a batch normalisation layer in there.
In TF 1.13.1 the models would be frozen without error, but this leads to an error when loading the frozen model: #3628

I tested the code in the latest tf-nightly (1.15.0.dev20190807) and the model froze without issue.

@gargn I tested as well to confirm. It does save without issue, but when loading the frozen graph there is a new error: ValueError: Node 'batch_normalization/cond/ReadVariableOp/Switch' has an _output_shapes attribute inconsistent with the GraphDef for output #0: Shapes must be equal rank, but are 1 and 0
Test code:
import tensorflow as tf
from tensorflow.python.platform import gfile
import tensorflow.keras.backend as K

source = "./freeze_test/frozen_model.pb"

session = K.get_session()
with gfile.Open(source, 'rb') as f:
    graph_def = tf.GraphDef()
    graph_def.ParseFromString(f.read())
    session.graph.as_default()
    tf.import_graph_def(graph_def, name='')

@geometrikal As @gargn mentioned the original issue was resolved in !pip install tf-nightly-gpu. Please close the issue and open a new issue for the loading graph if it was not already resolved. I think loading graph was also resolved as I could not reproduce the issue. Please check the gist here. Thanks!

@jvishnuvardhan loading_graph is not resolved - the code you are using in your gist is my workaround for the problem.
I have opened a new issue #31668 with a bigger scope to cover the general issue of freezing and loading models with batch normalization.

This should work on the latest nightly.

import backend from tf.keras not simply keras, shown below:
from tensorflow.keras import backend as K

import backend from tf.keras not simply keras, shown below:
from tensorflow.keras import backend as K

awesome!
it works


STORM-2779 NPE on shutting down WindowedBoltExecutor

waterMarkEventGenerator could be null when timestamp field is not specified

+1

+1

+1


BSMS Encryption and Disabling BSMS

Task Description

[x] BSMS needs to be stored in an encrypted form on the backend. [Integration done, enc issue addressed by #3922]
[x] Multiple BSMS backup: Currently the backend can only store one BSMS config per IKS instance, which needs to change to support backup of multiple BSMS, handled by #3802
[x] For now, we'll disable the feature to back up BSMS for IKS(at the level of the UI).

Dependency

#3802

Closing this issue as discussed with dev.


print_icon errors

Just installed a really basic arch linux (basically nothing except zsh and base)
I am receiving a whole lot of errors when trying to use p9k:
zsh: command not found: print_icon
left_prompt_segment:24: command not found: print_icon
left_prompt_segment:44: command not found: print_icon
left_prompt_end:2: command not found: print_icon
left_prompt_end:6: command not found: print_icon
right_prompt_segment:33: command not found: print_icon
right_prompt_segment:36: command not found: print_icon

I already checked my zshrc and I don't have any print_icon calls in it.
Other issues were mentioning locale issues, I've checked mine and they all show the right locale
(en_US-UTF8)
I'm using the next branch

Nevermind, seems like I forgot to actually generate the locale. Everything's working now


exploitdb: 2024-03-04 -> 2024-03-06

Diff: https://gitlab.com/exploit-database/exploitdb/-/compare/refs/tags/2024-03-04...2024-03-06
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Chrome startup page distortion

Bug or Regression?
Bug
System Info and Version
 System/Version info
<Paste the output of the command here>

Description
This commit 38132ffaf53c843a3ed03be5b305702fde8f5a49 distorts the chrome startup page. I'm not sure if this issue is a bug, if not I'll close this issue.
How to reproduce

Need to add a chrome profile, no need to sign in to Google account
Start chrome with this command google-chrome-stable --ozone-platform=wayland

Crash reports, logs, images, videos
https://github.com/hyprwm/Hyprland/assets/39702328/c20e9eed-f011-4ce6-901a-cf88eb583c7f
https://github.com/hyprwm/Hyprland/assets/39702328/d0f332cd-ba33-473f-97b6-afce3906b6a4

same as #1462


X-learner

The module, tests, notebook files were added with an init update.
See Kunzel et al. [1]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Yoav Kan-Tor seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Monitoring and access control for egress traffic

Any comments are welcome

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: vadimeisenbergibm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Deploy preview for preliminary-istio failed.
Built with commit 8382acd6a9b0726554664ad59e23576431859d7d
https://app.netlify.com/sites/preliminary-istio/deploys/5b2bfaf71f12b75bc8978585

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: frankbu, vadimeisenbergibm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Ah, the reason this page isn't getting an auto-generated See Also section is that it's in the release-0.8 branch. I hadn't noticed before. See Also functionality only exists in master.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: frankbu, geeknoid, vadimeisenbergibm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid I have applied your comments, thank you very much!

Ah, the reason this page isn't getting an auto-generated See Also section is that it's in the release-0.8 branch. I hadn't noticed before. See Also functionality only exists in master.

I switched to master locally and verified that See also section is generated. This is what I get:

New changes are detected. LGTM label has been removed.

@geeknoid I made the following change so the lgtm label was removed:

Finally, we compared HTTP-with-TLS-origination egress traffic with HTTPS egress traffic, in terms of control possibilities by Istio.

I added HTTP-with-TLS-origination to .spelling file. Could you please LGTM again?

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: frankbu, geeknoid, vadimeisenbergibm
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[BUG] wash link del command returns success for invalid arguments

Affected project(s)

[ ] documentation
[ ] examples
[ ] wasmCloud host
[X] wasmCloud CLI (wash)
[ ] wasmCloud dashboard UI (washboard)
[ ] capability providers
[ ] provider bindgen
[ ] control interface client
[ ] other / not sure

Describe the bug
When incorrect arguments are passed to the wash link del command, it still outputs a success message ("Deleted link for ... successfully") even though no link deletion occurs
Steps to reproduce

List the links with wash get links
Try to delete a link using an invalid argument such as source ID or WIT namespace/package
Check the links again with wash get links to confirm no changes have occurred

Example:
$ wash get links
⡀
Source ID     Target   Interface(s)        Name
http-server   http2    wasi:http/incomin   default
g-handler
$ wash link del --link-name default wrong_source_id wasi http
Deleted link for wrong_source_id on wasi:http (default) successfully
$ wash link del --link-name default http-server wasi:http wrong_wit
Deleted link for http-server on wasi:http:wrong_wit (default) successfully
$ wash get links
⡀
Source ID     Target   Interface(s)        Name
http-server   http2    wasi:http/incomin   default
g-handler
Expected behavior
The wash link del command should return a meaningful message for invalid arguments instead of printing a success
Environment

OS: Linux
Shell: bash
wash Version: v0.37.0
wasmcloud Version: v1.4.2

Screenshots / Logs / Additional context
No response

Analysis
When changing the parsing of the CtlResponse in link_cmd.rs as follows:
            let failure = delete_link(wco, &source_id, &link_name, &namespace, &package)
                .await
                //.map_or_else(|e| Some(format!("{e}")), |_| None);
                .map_or_else(|e| Some(format!("{e}")), |s| Some(format!("{s:?}")));

The response changes as follows:
>>> ⢀

  Source ID                                            Target                    Interface(s)                 Name
  dev_1hr5as_http_hello_world-1hr5as_dep_http_server   1HR5As-http-hello-world   wasi:http/incoming-handler   default
  dev_ekgdmd_http_hello_world-ekgdmd_dep_http_server   eKgDmd-http-hello-world   wasi:http/incoming-handler   default
  dev_exbk4g_http_hello_world-exbk4g_dep_http_server   EXBK4G-http-hello-world   wasi:http/incoming-handler   default
  dev_i0plvd_http_hello_world-i0plvd_dep_http_server   i0PLvd-http-hello-world   wasi:http/incoming-handler   default

mmooij@gandalf:~$ ~/dev/wasmcloud/target/debug/wash links del dev_1hr5as_http_hello_world-1hr5as_dep_http_server wasi http

Error deleting link: CtlResponse { success: true, message: "successfully deleted link", response: None }
mmooij@gandalf:~$ ~/dev/wasmcloud/target/debug/wash links del dev_1hr3as_http_hello_world-1hr5as_dep_http_server wasi http

Error deleting link: CtlResponse { success: true, message: "successfully deleted link (spec doesn't exist)", response: None }

As can be observed CtlResponse in both cases returns success; only the content of the message differs.
Both of these messages are returned from wasmbus/mod.rs::handle_link_del()
So basically it returns OK when it cannot find a component associated with the link.


Check for duplicate sequences in coyote dataset

There are no exact duplicates in the dataset. Next, I will check the aligned files.

There are no exact duplicates in the aligned file, either.


Global filters threw error after upgrading to 0.7.5

Description
I have a set of global vue filters on plugins/filters.js that I call in gridsome.config.js. This works fine up to 0.6.9. Once upgraded to 0.7.5 it won't compile anymore and threw an error
Steps to reproduce
Expected result
It should compile
Actual result
Error message
Gridsome v0.7.5

Initializing plugins...
/Users/rudy/Sites/###REDACTED####/src/plugins/filters.js:1
import Vue from 'vue'
       ^^^

SyntaxError: Unexpected identifier
    at Module._compile (internal/modules/cjs/loader.js:723:23)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Plugins.initialize (/Users/rudy/Sites/###REDACTED####/node_modules/gridsome/lib/app/Plugins.js:45:11)

Environment

Libs:
- gridsome version: 0.7.5
- @gridsome/cli version: 0.2.0

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: 10.16.3
- Platform:  Mac

Others:

Are you using src/plugins/filters.js as a plugin in gridsome.config.js? Then that file will be executed in a Node.js context. You can add global Vue filters in the src/main.js file instead.

@hjvedvik yes I am. It was working fine with 0.6.9. Any particular changes in 0.7.x that break it?


Support GitHub's merge queue

Similar to mergify, GitHub now has a built-in merge queue.
According to Managing a merge queue, in GitHub Actions, CI should target the merge_group event. While third-party CI providers, apparently need to be configured to run only on branches that are prefixed with gh-readonly-queue/{base_branch}.
This will almost certainly require some level of per-repo config support.
Using github's merge queue in this way could lead to reduced load on buildbot, because a) we are only building on branches ready to be merged and b) the branch is already updated on top of the base-branch (and other queued branches), so assuming everything goes well there's no need to rebuild again when merging onto a more up-to-date base-branch revision.
If we're going to need a per-repo config file for this anyway maybe it'd be good to have the ability to configure some builds to happen on unqueued PRs, while the full flake checks are only built on queued PRs? I.e. a "two-stage CI", as described here.

Afaik this already is supported: https://github.com/nix-community/buildbot-nix/blob/ade5f42d7e56c8298d729aa0e804c8062e7a77ac/buildbot_nix/init.py#L697

Afaik this already is supported.

Interesting, good to know, thanks. Apologies for the noise!
Can I ask how it knows whether the repo has merge queue enabled? Is that exposed through a branch protection API or something?
Also, how does it behave in practice; does buildbot build on?:

(unqueued) PR branches
queued PR branches (gh-readonly-queue/.*)
non-PR branches (e.g. main)

My interpretation of having multiple schedulers, is that a repo using the merge queue will trigger builds both on unqueud PR pushes and also staged/queued PRs.
https://github.com/nix-community/buildbot-nix/blob/ade5f42d7e56c8298d729aa0e804c8062e7a77ac/buildbot_nix/__init__.py#L683-L709
I guess that works but it feels a little wasteful. I'd love a way to tell buildbot to either not run[^1] on non-queued PRs or to run a subset of tests (in the spirit of two-stage CI).
[^1]: On yet-to-be-queued PRs, a subset of faster/lighter tests could be run using another CI framework, such as github actions.


Updating Plugin sets Entity to none

Whenever you update the Plugin the Primary and Secondary Entity are set to none Every time you update. Is there a way to prevent these from being set to none?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d80f7d76-dcd9-afc2-1d4e-f7a874f1492b
Version Independent ID: 52213ef9-50dd-15ab-d6c4-8694617fd9cb
Content: Sample: Custom plug-in to use Google Maps API as geospatial data provider
Content Source: ce/common-scheduler/developer/sample-custom-plugin-google-geospatial-data-provider.md
Service: dynamics-365-customerservice
Technology: field-service
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

This is by design as the msdyn_GeocodeAddress action is not bound to an entity, it is therefore set to none


[Flink-1686] Streaming Iterations Slot Sharing Fix

Iteration head instances were using the same identifier for slot sharing which resulted into incorrect execution for streaming iterations.  I had to add a unique identifier for each iteration node to fix the issue. They are now working properly judging from the parallel iterations test.

bad style habits ^^
thanks for reminding me. I also made a minor fix to the test too.

Looks good to me, lets merge this :+1:


#5 Added Social Media Share Preview

Added the Twitter preview Share. We can copy the link and also can share on Social media (eg, Twitter)
https://github.com/user-attachments/assets/e052e5a5-305b-418a-8cb0-dd67e35f53dd

Summary by CodeRabbit

New Features

Introduced modal functionality for enhanced user interactions.
Added buttons for copying the URL and sharing content on Twitter.
Implemented a preview card for Twitter sharing.

Updates

Enhanced the layout and structure of the sharing section.
Improved integration of existing components like SubstackCustom and CookieConsent.

solved #5

no, this should work when you share rustcrab.com
also please check, there are some conflicts

It will get the link of the window and share on Twitter. So that was my localhost so it copied the localhost address. And I had also solved the conflicts if I am wrong please correct me [The address is not manually given, the window.location get the url in this case


AssertionError: Status.ACTIVE (<enum 'Status'>) is not supported

ViUR-core3.4.0b2
[2023-04-04 19:18:34,017] /.../core/modules/user.py:978 [ERROR] Status.ACTIVE (<enum 'Status'>) is not supported
Traceback (most recent call last):
  File "project/lib/python3.10/site-packages/viur/core/modules/user.py", line 975, in createNewUserIfNotExists
    addSkel.toDB()
  File "project/lib/python3.10/site-packages/viur/core/skeleton.py", line 1021, in toDB
    key, dbObj, skel, changeList = db.RunInTransaction(txnUpdate, key, skelValues)
  File "src/viur/datastore/transport.pyx", line 782, in viur.datastore.transport.RunInTransaction
  File "src/viur/datastore/transport.pyx", line 779, in viur.datastore.transport.RunInTransaction
  File "project/lib/python3.10/site-packages/viur/core/skeleton.py", line 975, in txnUpdate
    db.Put(dbObj)
  File "src/viur/datastore/transport.pyx", line 700, in viur.datastore.transport.Put
  File "src/viur/datastore/transport.pyx", line 209, in viur.datastore.transport.pythonPropToJson
  File "src/viur/datastore/transport.pyx", line 239, in viur.datastore.transport.pythonPropToJson
AssertionError: Status.ACTIVE (<enum 'Status'>) is not supported

Hello, after a detailed exploration, I've found out that this problem has to deal with a project-specific problem. It's not a bug with viur-core.

Hello, after a detailed exploration, I've found out that this problem has to deal with a project-specific problem. It's not a bug with viur-core.

Okay, that's what I assumed.
I was not able to reproduce the error. Neither within a StartupTask, nor in a normal request. No problem both in the cloud and locally.
Thanks for the clarification


❔Rebranding: Smart Maps Meetup(s); Atlantic / Pacific / Japan

Maybe we can rebrand our meetups to make things simpler to understand. What do you think?

Smart Maps Meetup Japan - Weekly: every Tuesday 13:00
Smart Maps Meetup Pacific - Monthly: was Smart Maps International Meetup - once a month
Smart Maps Meetup Atlantic - Quarterly: rebrand Smart Maps Bazaar Walking Tour - probably in every 3 months (4 times a year)

We can decide on this soon so that this naming issue is not a blocker. :-)
I would like to announce the 3rd International Meetup on 2023-06-16 as Smart Maps Meetup Pacific, preferably tomorrow.

Added SMM for Smart Maps Meetup in smart-maps-denkmal by the way :-)
https://github.com/UNopenGIS/smart-maps-denkmal/blob/main/README.md

I am reflecting these names on #169. So, let's say we move on with this.

Created some figures to explain why we have both Pacific and Atlantic time arrangements.