chore(deps): bump ratatui to 0.26.2 and crossterm to 0.27.0

Bumps MSRV to 1.74.0
This necessitated 3 changes to the codebase:

Spans was renamed to the more ergonomic Line type.
Frame no longer requires a backend type parameter.
Table::new requires a widths parameter, so we use
Table::default().rows(rows) instead of Table::new(rows).

Crossterm on Windows triggers events for key press as well as release
and repeat, which causes duplicate key presses. This change filters out
those events.

It looks like this change requires a MSRV bump, as the new ratatui seems not to support Rust 1.64.0: https://github.com/tokio-rs/console/actions/runs/7763271246/job/21175134601#step:8:1

It looks like this change requires a MSRV bump, as the new ratatui seems not to support Rust 1.64.0: https://github.com/tokio-rs/console/actions/runs/7763271246/job/21175134601#step:8:1

Thanks - bumped this to 1.70

@joshka mind rebasing this branch onto the latest master and resolving the lockfile conflicts? Once that's done, this should be good to merge!

1:31 PM]joshka: I notice that some tests are failing now - digging to check what's happening
[1:31 PM]Hayden (he/him): if it's the self wakes test then it's known flaky.
[1:31 PM]Hayden (he/him): (I need to remove it)
[1:37 PM]joshka: Ah got it - yep it was that. I did't a quick cargo update on main and saw the tests fail there too (it didn't fail before then)

Squashed and rebased

There are some proto changes:
/// Each `ResourceUpdate` contains any resource data that has changed since the last
diff --git a/console-api/src/generated/rs.tokio.console.tasks.rs b/console-api/src/generated/rs.tokio.console.tasks.rs
index 41b8396..e8ee5fa 100644
--- a/console-api/src/generated/rs.tokio.console.tasks.rs
+++ b/console-api/src/generated/rs.tokio.console.tasks.rs
@@ -1,3 +1,4 @@
+// This file is @generated by prost-build.
 /// A task state update.
 ///
 /// Each `TaskUpdate` contains any task data that has changed since the last
diff --git a/console-api/src/generated/rs.tokio.console.trace.rs b/console-api/src/generated/rs.tokio.console.trace.rs
index [220](https://github.com/tokio-rs/console/actions/runs/8603263859/job/23574759021?pr=515#step:6:221)b55a..be3516e 100644
--- a/console-api/src/generated/rs.tokio.console.trace.rs
+++ b/console-api/src/generated/rs.tokio.console.trace.rs
@@ -1,3 +1,4 @@
+// This file is @generated by prost-build.
 /// Start watching trace events with the provided filter.
 #[allow(clippy::derive_partial_eq_without_eq)]
 #[derive(Clone, PartialEq, ::prost::Message)]
test bootstrap ... FAILED

Because there are some other issues in this PR, I would recommend:

This PR only focuses on bumping the rataui version.
If the rataui requires a higher MSRV, we bump the MSRV but do not change other dependencies' versions.

Perhaps we could address the issue of the failed test that was caused by changes in other dependencies.
Also, this would help us make sure the scope of this PR is not extended. We can only focus on bumping the rataui version.
Thank you for your patch again!

Lint CI fixed in https://github.com/tokio-rs/console/pull/548

@joshka There are some unused imports after your change. Could you please help to remove them? Thanks!

@joshka There are some unused imports after your change. Could you please help to remove them? Thanks!

Done

@hawkw Could you please rereview and approve (if you're happy with it) this PR? Your request for changes is blocking at the moment. Thanks!


Suggestion to add downloads badge

Now we can easily check the download stats via "downloads" badge provided by PePy.

How does it look ?

FYI: there are more several options we also could choose. (Now we're using the top one)


Actions must be plain objects. Use custom middleware for async actions.

From what I read, this should work
dispatch(createAction('INCREMENT'))

But it returns
Actions must be plain objects. Use custom middleware for async actions.

When I do
console.log(createAction('INCREMENT'))

It returns
INCREMENT

on the console. I expect it to be a FSA (like { type:'INCREMENT', payload: ...) but seems like it is just a string so it is not a plain object. What could be the problem here? (I have not use any middleware yet) And I have no idea how this simple operation could pass the isFSA in the test..

createAction creates an action creator. Check the README and #47.


Fixes #2123 - enable S3 bucket versioning by default

Coverage: 94.281%. Remained the same when pulling 1e773d704d63c6467b9819631e307a5320622dcb on cody-s3-bucket-versioning into 74fc8e9e39a8811246ce8b92d7d4525d1ecbdc29 on main.


Add error when the quantity is negative in restock api

Add error when the quantity is negative in restock api
Checks before requesting a review

[x] I have performed a self-review of my code.
[x] If it is a core fix, I have added tests.
[ ] If it is a front-end feature, I have manually tested it.
[x] I have added detailed documentation to my code.

Summary
Fixed restock api: if the quantity passed in the body is less or equal to 0, the api returns ERROR_WRONG_PARAMETERS.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Attribute autoplay on video tag

I would like to see the range of supported mobile browsers for autoplay addtribute of video HTML5 tag. I've found this table, but I's not up to date and and not all browsers:
OS/Browser	Supports autoplay
iOS 9 Safari 601	no
iOS 10 Safari 602	yes (with muted + playsinline attributes)
iOS 9 Chrome 54	no
iOS 10 Chrome 54	yes (with muted + playsinline attributes)
iOS 9 Opera Mini 14	no
iOS 10 Opera Mini 14	yes (plays fullscreen)
iOS 9 Firefox 5.3	no
iOS 10 Firefox 5.3	no
Android Chrome 43	no
Android Chrome 54	yes (with muted attribute)
Android Opera Mini 20	no
Android Firefox 49	yes
Android Samsung Internet 4.0	no
Windows Phone 8 IEMobile 10	no
Windows Phone 8.1 IEMobile 11	yes
Windows 10 Mobile Edge 14.1	no
Windows 10 Mobile Opera Mini 9.1	no
source http://walterebert.com/blog/html5-video-autoplay-mobile-revisited/

Duplicate of #2599? The source/link seems relevant, though.


Crash in Debug Mode, IOS Simulator

Hi
I have the TypeError: global.getStringMMKV is not a function when i want to dubug my App.
Are they some special configuration for make Debug?
MY CONFIG:
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-native": "^0.63.4",
"react-native-mmkv-storage": "^0.5.3",

Debug mode is not available after 0.5.3 due to use of JSI. use Flipper etc for debugging.


Timeout responses after long processing

NEST 5.2.0
Elasticsearch 5.2.1
I have an application that analyzes a big ammount of data and usually takes a long time to complete. All the data is stored in ElasticSearch accross different indexes, all in the same server (which I run locally at the moment, on the same pc as my tool).
The application consists of 5 threads reading data from the db and each producing more data that is sent at the end of each job with Bulk, each posting a different index. One of the jobs takes much longer than the others. After a long time processing (more than one hour) all the NEST searches return with a timeout and a few exceptions, and it never recovers. The response gives me this:
Exception thrown: 'System.Net.Sockets.SocketException' in System.dll
Exception thrown: 'System.IO.IOException' in System.dll
Exception thrown: 'System.Net.WebException' in System.dll
Exception thrown: 'System.Net.WebException' in System.dll

Invalid NEST response built from a unsuccessful low level call on POST: /methods_codedeptools/methodstype/_search
# Audit trail of this API call:
 - [1] BadResponse: Node: http://mtl-be100:9200/ Took: 00:01:00.0390033
 - [2] MaxTimeoutReached: Took: -736387.20:17:39.6497672
# OriginalException: System.Net.WebException: The operation has timed out
   at System.Net.HttpWebRequest.GetResponse()
   at Elasticsearch.Net.HttpConnection.Request[TReturn](RequestData requestData) in C:\code\elasticsearch-net\src\Elasticsearch.Net\Connection\HttpConnection.cs:line 145
# Request:
{"size":1,"query":{"match":{"name":{"query":"inline class CParticlesData &CParticlesData::operator=(class CParticlesData &&)"}}}}
# Response:
<Response stream not captured or already read to completion by serializer. Set DisableDirectStreaming() on ConnectionSettings to force it to be set on the response.>

I've tried using different configurations:

Use one single ElasticClient through every thread
Create multiple clients (one per thread, or a new one on each query)
Try different connection settings configurations (no pool, singlenodeconnectionpool, disable/enable direct streaming...)

But sooner or later I reach the point where I can't talk with the DB anymore. When this happens, I try to communicate with it through Kibana and everything works fine, from Kibana itself or the debug console.
My connection settings are created like this:
m_url = new Uri("http://" + url);
var pool = new SingleNodeConnectionPool(m_url);
ConnectionSettings esConnectionSettings = new ConnectionSettings(pool);
m_client = new ElasticClient(esConnectionSettings);

I checked my connections with cports before running into the issue, and I see 5 connections to elasticsearch from my application, always the same ones and they stay there. When the problem starts happening, those connections are gone, and I don't see any new ones. However, the 3 from Kibana are always fine.
What could be the issue? Is there anything I can do to understand better what could be the problem?
Thank you
Edit: I must add, that if I relaunch the same application while the other one is still running and I debug it, it has no issue talking with ElasticSearch, but the other one keeps getting all the exceptions and timeouts forever.

What platform are you running on e.g. Windows, Linux, etc? And what framework version of NEST 5.2.0 are you using e.g. .NET 4.6, .NET Standard 1.3, etc?
Are you able to put together a small reproducible example that replicates the issue? This would be super helpful and allow us to investigate it more quickly.

Sorry for the delay.
I'm running Windows .Net 4.5.2.
As for the example, I don't know how I could give you something useful :( Really the code is just performing a bunch of searches on a process that runs for a long time. For me to give you a standalone repro case I would also need to send you the contents of the database (the ammount of data is what makes the process very long). Still if you think the code would be useful I can send you the whole solution (it's quite small). Do you think that will help you?
By the way, I managed to work around the issue for the moment. For this task that takes so long, I just split the process in multiple jobs and it manages to finish before the timeouts start. Still, it would be great to know why this happens.
Thank you. Let me know.
David

The application consists of 5 threads reading data from the db a

db in this context is it Elasticsearch ? Because your search has size: 1 i think you are overloading the search thread pool. By cutting them up in smaller tasks you might not be sending that many concurrent requests to Elasticsearch anymore and not hitting the timeouts.
Hard to say without knowing more about your usecase. Feel free to send your solution to ml > @ < elastic.co, closing this for now but will reopen if I spot anything in the solution.


Appstudio update test-component-pac-osyz

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-osyz-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
40 seconds
build-container

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
44 seconds
clamav-scan

✅ Succeeded
2 minutes
deprecated-base-image-check

✅ Succeeded
15 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
4 seconds
show-summary

Pipelines as Code CI/test-component-pac-osyz-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
9 seconds
init

✅ Succeeded
20 seconds
clone-repository

✅ Succeeded
40 seconds
build-container

✅ Succeeded
2 minutes
deprecated-base-image-check

✅ Succeeded
15 seconds
sanity-inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
44 seconds
clamav-scan

✅ Succeeded
15 seconds
sbom-json-check

✅ Succeeded
8 seconds
sanity-optional-label-check

✅ Succeeded
8 seconds
sanity-label-check

✅ Succeeded
4 seconds
show-summary

Pipelines as Code CI/test-component-pac-osyz-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
10 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
13 seconds
sanity-inspect-image

✅ Succeeded
12 seconds
deprecated-base-image-check

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
6 seconds
sanity-label-check

✅ Succeeded
6 seconds
sanity-optional-label-check

✅ Succeeded
7 seconds
show-summary


Request: Active Charcoal Block

I'd like to use active charcoal to form the portal frame to another dimension in my modpack.  Would you be interested in adding an active charcoal block?  I created a texture for you to make it easy.  It's based on the vanilla coal texture, but darker and with a subtle red tint.

Side by side with charcoal block texture

The texture itself

Looks good, will add it in the next update.


integrate testing with CDASH server

buildtest should present its test cases in CDASH (a testing framework dashboard) see https://www.cdash.org/
This would be helpful to present users with a visual overview of all the tests.

Will not proceed with this task.


DH: Make padding always on when X9.42 KDF is used

Fixes #17834
Checklist

[x] documentation is added or updated
[ ] tests are added or updated

Still working on a test.

@slontis Still OK?

ping for second review

This pull request is ready to merge

Merged to master and 3.0 branches. Thank you for the reviews!


Minor fixes over README.md

Hey! 👋
I fixed some small Markdown mistypes, it was rendering poorly over VS Code, as well as a bad version mentioned in there.
Thank you for taking the time to write and share the lib! I'll put it into use soon.

Thanks for the contribution!


maybeAddImport is not working properly

As far as I understand maybeAddImport adds imports only if it's really needed unlike simple addImport. But in this example: https://docs.openrewrite.org/java/refactoring-java-source-code/addfield maybeAddImport actually does not add import org.slf4j.LoggerFactory, although it's need to be added since it's missing in the original code.

@Guseyn there's a bug in the sample for AddField. I've fixed the docs accordingly in this commit.
There are two reasons maybeAddImport() wasn't adding an import in that sample:

At the time it ran the new field hadn't been added yet. AbstractRefactorVisitor.andThen() schedules the provided visitor to be executed immediately after the current visitor. So the maybeAddImport() actually runs before the AddField() visitor creates the field.
Even if the ordering issue is fixed, maybeAddImport() wouldn't add the import because the LoggerFactory in the field initialization expression isn't type-attributed. It doesn't know that symbol is referring to org.slf4j.LoggerFactory so it still thinks there are no occurrences of org.slf4j.LoggerFactory to add an import for.

#2 is a consequence of AddField accepting the initialization expression as a String, rather than a type-attributed AST. This is for convenience, but can have subtle consequences like it did in this case.
Take a look at the updated docs for AddField and let me know if that makes sense.

@Guseyn heads up I've filed issue https://github.com/openrewrite/rewrite/issues/49 to update AddField's API to make it easier to use without making the mistake that sample made. Thanks again for pointing this out.


Follow DART SE(2) convention

Addresses #455

Before creating a pull request

[x] Document new methods and classes
[x] Format code with make format

Before merging a pull request

[x] Set version target by selecting a milestone on the right side
[ ] Summarize this change in CHANGELOG.md
[x] Add unit test(s) for this change

CI fails due to style inconsistency.

CI tests all seemed to have passed?

Oh, sorry. I was confused with #457 :sweat_smile:

Subtle hint from @jslee02 that I should complete #457 soon? yessir!


Add mvlassis as Member of Kubeflow org

Membership Request
Please read the guidelines for joining the Kubeflow GitHub org before opening an issue
Please provide links to PRs or other contributions (2-3):

Part of the release team for 1.10
Kubeflow 1.10 Liaison for the Notebooks WG

Please list 2 existing members who are sponsoring your membership:

@kimwnasptd
@rimolive

Please test your PR
Run
cd github_orgs
pytest test_org_yaml.py

Include the output in the PR
Additional Instructions
After your PR is merged please wait at least 1 hour for changes to propogate.
If after an hour you haven't recieved an invite to join the GitHub org please open an issue.

+1

/lgtm
Woo Hoo!


On-Demand Backups

#97 brought up the issue of On Demand backups.
Some requirements to bring this about:

Need a way to signal the service that a backup is requested.
Need the service to act on that signal.

The work for #93 would provide the means to do the signaling.
There would be some thinking required related to security here, as there are some denial-of-service attacks that would be possible if this was available over the HTTP endpoint. Perhaps triggering this should require a token that is only stored inside the container and not accessible via the usual volume mount points. So while someone could do something like docker exec -it minecraft_backup /start-backup.sh, where the script can read the token and provide it to the service, an attacker would already need access to the container filesystem in which case they could attack the backup folder directly anyways.

This will be in the test tag shortly.


EDA of Udemy data

💥 Proposal
I have seen that there is not EDA done on the Udemy data. I would like to do it. Please assign me this task.

@karthikbhandary2 - please provide the dataset.

It is the data set that is in the data analytics folder: https://github.com/The-Data-Alchemists-Manipal/MindWave/tree/main/Data Analytics/Udemy courses_analysis

ok


[plot] StackView is missing methods to get/set the perspective

It would be convenient to get/set the axis from which data is browsed from the API.

closed by #2049


Support for voting configuration exclusions API

I'm using go-elasticsearch 7.x branch.
I need to perform both POST and DELETE requests using /_cluster/voting_config_exclusions API endpoint.
POST /_cluster/voting_config_exclusions/nodeId1

DELETE /_cluster/voting_config_exclusions

But I didn't find any implementation of voting_configuration_exclusions API in Cluster APIs:
type Cluster struct {
	AllocationExplain       ClusterAllocationExplain
	DeleteComponentTemplate ClusterDeleteComponentTemplate
	ExistsComponentTemplate ClusterExistsComponentTemplate
	GetComponentTemplate    ClusterGetComponentTemplate
	GetSettings             ClusterGetSettings
	Health                  ClusterHealth
	PendingTasks            ClusterPendingTasks
	PutComponentTemplate    ClusterPutComponentTemplate
	PutSettings             ClusterPutSettings
	RemoteInfo              ClusterRemoteInfo
	Reroute                 ClusterReroute
	State                   ClusterState
	Stats                   ClusterStats
}

Can you guide a way out by telling how can I perform these requests using go-elasticsearch?

It seems like the API is missing from the specification. I'll have a look into that.
In the meantime, if you want to unblock your situation quickly, you can use the guidelines for extending the client:
https://github.com/elastic/go-elasticsearch/blob/6f36a473b19f05f20933da8f59347b308ab46594/_examples/extension/main.go#L29-L51

So, there's an ongoing work on revisiting the API, and adding the specification when it's completed. No timeline for that yet, so if you need it badly now, the extension approach should work well.

Thanks, @karmi!

Hello, the support for the API has been added to the master branch in https://github.com/elastic/go-elasticsearch/commit/76a7f0b6ec401c8c61f0646c69958eb5fe85b924, and to the 7.x branch in https://github.com/elastic/go-elasticsearch/commit/9a4447ee944f9c59e49d698116a8043ea5ec8b77. Can you try it out?


Require onnxruntime-gpu instead of onnxruntime

It seems installing onnxruntime on top of onnxruntime-gpu will strip the ability of ONNX runtime to use CUDA.

I'm not sure if it's related.
Is the error message something like the following?
EP Error D:\a\_work\1\s\onnxruntime\python\onnxruntime_pybind_state.cc:456 onnxruntime::python::RegisterTensorRTPluginsAsCustomOps Please install TensorRT libraries as mentioned in the GPU requirements page, make sure they're in the PATH or LD_LIBRARY_PATH, and that your GPU is supported.
 when using ['TensorrtExecutionProvider', 'CUDAExecutionProvider', 'CPUExecutionProvider']
Falling back to ['CUDAExecutionProvider', 'CPUExecutionProvider'] and retrying.

The current version of onnxruntime is 1.17.0, but it seems that an error is occurring.
Please try downgrading to version 1.16.3 with the following commands:
python -m pip install onnxruntime==1.16.3
python -m pip install onnxruntime-gpu==1.16.3

No.
If you install onnxruntime-gpu first and then onnxruntime, you will notice that only CPUExecutionProvider is available.

您好，请问您解决了吗

Not clear how solve this problem. Lot of teoretical minds instad step-by-step how-to-do higher. I am especially gifted - I don't undersdtand it.
4090+7950X

> D:\Ai\SD\ComfyUI_windows_portable>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build
> ** ComfyUI start up time: 2024-05-20 13:03:17.800563
>
> Prestartup times for custom nodes:
>    0.0 seconds: D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\custom_nodes\rgthree-comfy
>    0.0 seconds: D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-Manager
>
> Total VRAM 23028 MB, total RAM 97432 MB
> Set vram state to: NORMAL_VRAM
> Device: cuda:0 NVIDIA GeForce RTX 4090 : cudaMallocAsync
> VAE dtype: torch.bfloat16
> Using pytorch cross attention
> Using pytorch cross attention
> Traceback (most recent call last):
>   File "D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1879, in load_custom_node
>     module_spec.loader.exec_module(module)
>   File "<frozen importlib._bootstrap_external>", line 883, in exec_module
>   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
>   File "D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\__init__.py", line 2, in <module>
>     from .animatediff.nodes import NODE_CLASS_MAPPINGS, NODE_DISPLAY_NAME_MAPPINGS
>   File "D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\nodes.py", line 22, in <module>
>     from .sampling import animatediff_sample_factory
>   File "D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved\animatediff\sampling.py", line 9, in <module>
>     from comfy.samplers import lcm
> ImportError: cannot import name 'lcm' from 'comfy.samplers' (D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\comfy\samplers.py)
>
> Cannot import D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-AnimateDiff-Evolved module for custom nodes: cannot import name 'lcm' from 'comfy.samplers' (D:\Ai\SD\ComfyUI_windows_portable\ComfyUI\comfy\samplers.py)
> [Crystools INFO] Crystools version: 1.12.0
> [Crystools INFO] CPU: AMD Ryzen 9 7950X 16-Core Processor - Arch: AMD64 - OS: Windows 10
> [Crystools INFO] GPU/s:
> [Crystools INFO] 0) NVIDIA GeForce RTX 4090
> [Crystools INFO] NVIDIA Driver: 551.76
> ### Loading: ComfyUI-Impact-Pack (V4.27.4)
> e: module 'sys' has no attribute '__comfyui_manager_register_message_collapse'
> ### Loading: ComfyUI-Impact-Pack (Subpack: V0.3)
> ### Loading: ComfyUI-Inspire-Pack (V0.32.4)
> ### Loading: ComfyUI-Manager (V0.34)
> ### ComfyUI Revision: 2194 [11a2ad51] | Released on '2024-05-19'
> ------------------------------------------
> ### N-Suite Revision: dbeb9ae9
> Current version of packaging: 23.2
> Version of cpuinfo: Not found
> Current version of git: 3.1.37
> Current version of moviepy: 1.0.3
> Current version of cv2: 4.8.1
> Current version of skbuild: 0.17.6
> Version of typing: Not found
> Current version of diskcache: 5.6.3
> Current version of llama_cpp: 0.2.26+cu118
> Current version of timm: 0.9.12
> [ReActor] - STATUS - Running v0.5.0-b3 in ComfyUI
> Torch version: 2.1.0+cu118
> Comfyroll Custom Nodes: Loaded
> Registered sys.path: ['D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\comfyui_controlnet_aux\\src\\__init__.py', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\comfyui_controlnet_aux\\src\\custom_pycocotools', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\comfyui_controlnet_aux\\src\\custom_oneformer', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\comfyui_controlnet_aux\\src\\custom_mmpkg', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\comfyui_controlnet_aux\\src\\custom_midas_repo', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\comfyui_controlnet_aux\\src\\custom_detectron2', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\comfyui_controlnet_aux\\src\\controlnet_aux', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\comfyui_controlnet_aux\\src', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI_Comfyroll_CustomNodes\\comfy', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI_Comfyroll_CustomNodes\\comfy', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI-Crystools\\nodes\\comfy', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\python_embeded\\lib\\site-packages\\git\\ext\\gitdb', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\comfy', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\python_embeded\\python310.zip', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\python_embeded', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\python_embeded\\lib\\site-packages', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\python_embeded\\lib\\site-packages\\win32', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\python_embeded\\lib\\site-packages\\win32\\lib', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\python_embeded\\lib\\site-packages\\Pythonwin', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI-Impact-Pack\\modules', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI-Impact-Pack\\impact_subpack', '../..', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI-N-Nodes\\libs\\rifle', 'D:\\Ai\\SD\\ComfyUI_windows_portable\\ComfyUI\\custom_nodes\\ComfyUI-N-Nodes\\libs']
> DWPose: Onnxruntime with acceleration providers detected. Caching sessions (might take around half a minute)...
> 2024-05-20 13:03:24.8707291 [E:onnxruntime:Default, provider_bridge_ort.cc:1534 onnxruntime::TryGetProviderInfo_TensorRT] D:\a\_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1209 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\Ai\SD\ComfyUI_windows_portable\python_embeded\lib\site-packages\onnxruntime\capi\onnxruntime_providers_tensorrt.dll"
>
> *************** EP Error ***************
> EP Error D:\a\_work\1\s\onnxruntime\python\onnxruntime_pybind_state.cc:456 onnxruntime::python::RegisterTensorRTPluginsAsCustomOps Please install TensorRT libraries as mentioned in the GPU requirements page, make sure they're in the PATH or LD_LIBRARY_PATH, and that your GPU is supported.
>  when using ['TensorrtExecutionProvider', 'CUDAExecutionProvider', 'CPUExecutionProvider']
> Falling back to ['CUDAExecutionProvider', 'CPUExecutionProvider'] and retrying.
> ****************************************
> 2024-05-20 13:03:25.0982619 [E:onnxruntime:Default, provider_bridge_ort.cc:1534 onnxruntime::TryGetProviderInfo_TensorRT] D:\a\_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1209 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\Ai\SD\ComfyUI_windows_portable\python_embeded\lib\site-packages\onnxruntime\capi\onnxruntime_providers_tensorrt.dll"
>
> *************** EP Error ***************
> EP Error D:\a\_work\1\s\onnxruntime\python\onnxruntime_pybind_state.cc:456 onnxruntime::python::RegisterTensorRTPluginsAsCustomOps Please install TensorRT libraries as mentioned in the GPU requirements page, make sure they're in the PATH or LD_LIBRARY_PATH, and that your GPU is supported.
>  when using ['TensorrtExecutionProvider', 'CUDAExecutionProvider', 'CPUExecutionProvider']
> Falling back to ['CUDAExecutionProvider', 'CPUExecutionProvider'] and retrying.
> ****************************************

Hi! Same problem. The generation goes on, the caption appears and I don't understand how much this error affects. Apparently the computation doesn't run on the GPU.
4090 + CUDA 12.4, cuDNN 9.0.0 (CUDA 11.8 is also installed on the system and there is CUDA_PATH_V11_8)
2024-03-11 13:40:06.5955372 [E:onnxruntime:Default, provider_bridge_ort.cc:1534 onnxruntime::TryGetProviderInfo_TensorRT] D:\a\_work\1\s\onnxruntime\core\session\provider_bridge_ort.cc:1209 onnxruntime::ProviderLibrary::Get [ONNXRuntimeError] : 1 : FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\ComfyUI\python_embeded\Lib\site-packages\onnxruntime\capi\onnxruntime_providers_tensorrt.dll"

*************** EP Error ***************
EP Error D:\a\_work\1\s\onnxruntime\python\onnxruntime_pybind_state.cc:456 onnxruntime::python::RegisterTensorRTPluginsAsCustomOps Please install TensorRT libraries as mentioned in the GPU requirements page, make sure they're in the PATH or LD_LIBRARY_PATH, and that your GPU is supported.
 when using ['TensorrtExecutionProvider', 'CUDAExecutionProvider', 'CPUExecutionProvider']
Falling back to ['CUDAExecutionProvider', 'CPUExecutionProvider'] and retrying.
****************************************

So... How do I solve this?
If the generation goes on, it does not affect the quality of the caption? (I have a powerful CPU, generation time is ok even with an error)
Does the WD14-Tagger support working with CUDA 12?
Hmmm where is "D:\a_work\1\s\onnxruntime..." coming from? My ComfyUI is on D: but OS on the disk C:
I don't know why it says FAIL : LoadLibrary failed with error 126 "" when trying to load "D:\ComfyUI\python_embeded\Lib\site-packages\onnxruntime\capi\onnxruntime_providers_tensorrt.dll" I checked and this library is really there.

onnxruntime_providers_tensorrt.dll，Where can I download this file

me too
onnxruntime::python::RegisterTensorRTPluginsAsCustomOps Please install TensorRT libraries as mentioned in the GPU requirements page

You can fix this error simply by installing tensorrt:
The below image is the compatibility matrix for the cuda version.

This is my environment:
OS: Windows 10
CUDA: 11.8 (Since tensorflow isn't be upgraded from the 2.10 on windows I'm using 11.8)
On Windows OS, tensorrt==8.6 is not supported so you have to install tensorrt-cu11 binary.

pip install onnxruntime-gpu==1.16.0
pip install tensorrt-cu11

commented

ok


Share service not working when internet is not available on startup

The QrShareService in the photobooth application does not function correctly when the application is started without an internet connection. The service should periodically check for an available internet connection and enable the share service once a connection is detected.
Steps to Reproduce:

Ensure that there is no internet connection.
Start the photobooth application.
Attempt to use the share service.

Code Snippet:
Error happens in this section. It is checked on startup if the endpoint returns code 200. But if no internet connection is avaliable to beginn with, its not possible and non 200 is returned, and therefore the whole service stops, despite propably connecting to the Internet later on.
https://github.com/photobooth-app/photobooth-app/blob/b24bf5673c70f14900d66314d244447ae66ba9dd/photobooth/services/qrshareservice.py#L28-L47
Expected Behavior:
The application should periodically check for an internet connection and enable the share service once a connection is available.

I just removed the initial checks for a valid endpoint. It's probing now every 5 seconds - should be acceptable compromise between checks and not overly often repeat.

Perfect, thanks for this fix :)


Compiling wxWidgets-3.1.4 on Windows with MinGW

If anyone is having trouble compiling here is solution that worked for me for minimal sample. Added compiler flags are marked with "//"
"-lwxmsw31u_core", //just change 30 to 31
"-lwxbase31u", //same as above
"-lwxpng",
"-lwxregexu", //
"-lwxzlib", //
"-lcomdlg32",
"-lgdi32",
"-lcomctl32",
"-lole32",
"-loleaut32",
"-ldmoguids",
"-luuid",
"-lwinspool",
"-luxtheme", //
"-loleacc", //
"-lshlwapi", //
"-lversion",//
"-lz"

-lshlwapi and -lversion is needed because of a change they made. Doublemax from forum.wxwidgets.org helped and gave answer:

From /docs/changes.txt:
Changes in behaviour which may result in build errors

wxMSW now requires linking with shlwapi.lib and version.lib. This is done
automatically in most cases, but if you use a static build of the library
with a non-MSVC compiler such as MinGW and do not use wx-config, then you
will need to add these libraries to your make or project files yourself.

Also huge, huge thanks to @huckor for this repo!

Thanks.
I forgot the shlwapi and version libs and wasted some time. Your issue helped.
Also, indeed, huge thanks to @huckor! This tutorial is awesome!

@QGAI thanks for support. I created separate branch for wx 3.0.5 and wx 3.1.4


Feat: Scrapping data from AllTrails

Describe the feature
As a part of GSSOC 24, I'd like to add a All trails module with the following functionalities:
https://www.alltrails.com/trail/india/delhi/lodhi-garden-trail
Users will be providing the name of the trail and we will be able to return them.

The length of a trail
Elevation gain
Route type

Please assign under the appropriate gssoc and level label.
Thanks!
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'24 contributor
[X] I want to work on this issue

Go ahead @Anshika14528
Note

Please create a separate module for this, as in the folder and project structure (if it is already created, just add your features as functions in the same module).
Do not use the `selenium web driver as it is incompatible with all devices and cloud platforms.
Before making any changes, please check whether the module you want to add exists. If yes, then you can add your functionality as a method only make a separate module and class for it.

All the best 👨💻

Thankyou sir
On Sun, 12 May, 2024, 1:55 pm Nikhil Raj, @.***> wrote:

Assigned #904 https://github.com/Clueless-Community/scrape-up/issues/904
to @Anshika14528 https://github.com/Anshika14528.
—
Reply to this email directly, view it on GitHub
https://github.com/Clueless-Community/scrape-up/issues/904#event-12778019759,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIFCFR64LRZ6NDRGSJFPEQ3ZB4RRFAVCNFSM6AAAAABHSQUP5GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG43TQMBRHE3TKOI
.
You are receiving this because you were assigned.Message ID:
@.***
com>

@nikhil25803  sir, I tried scraping data from All trails but i am getting blocked, the website doesn't allow scraping and I am having a hard time doing that. I am fairly new to this, so didn't have much clue about how to proceed.
So i looked for an Indian trekking website and was able to get all the info i need, please allow me to scrape that website instead.
https://www.indiantrekking.com/chopta-chandrashila-trek.html


Don't show the test result of pictures

The result of running eval.py only displays the AP value, and there is no picture showing the test result. How can I display the result of pictures？

You can do it by plotting the image correspond to the index image in your detection result, then the predicted bboxes also in your detection result.


Update to astropy.visualization.wcsaxes

This PR implements #116, i.e. updates from standalone wcsaxes to astropy.visualization.wcsaxes in the pyregion package.
@astrofrog - Is this update OK or can it be done somehow in a better way?
All- The statement in the install docs is that pyregion still runs on Astropy >=1 although I'm not sure if it's true. So I don't know if backward compat is an issue here or how far back support for old Astropy versions is desired here. Maybe it would be OK to bump the required version to Astropy >= 1.3?

Coverage remained the same at 63.295% when pulling 1d1409acb4e0be2854e4c43d1e514f9cadd4f898 on cdeil:wcsaxes-update into 12fc5d8d192ae3027bd705ccc434ba0d80730e25 on astropy:master.

@bsipocz - Do you know how to fix this Sphinx warning?
/home/travis/build/astropy/pyregion/docs/api/pyregion.ShapeList.rst:7: WARNING: py:class reference target not found: list
/home/travis/build/astropy/pyregion/docs/getting_started.rst:34: WARNING: py:obj reference target not found: list

https://travis-ci.org/astropy/pyregion/jobs/251688184#L673

Hmm, it seems that they for some reason removed list() for the intersphinx inventory for python2. There isn't even an anchor on it https://docs.python.org/2.7/library/functions.html#len
So there are 3 options. Easiest it to use double backticks and try not to link; or build the docs only on python3; or add list to the local instersphinx file that is shipped with astropy-helpers (though given that there doesn't seem to be a python2 linkable one, that link should always point to python3).

Hmm, it seems that they for some reason removed list() for the intersphinx inventory for python2. There isn't even an anchor on it https://docs.python.org/2.7/library/functions.html#len

That seems very weird that they'd remove it now after 10+ years.
I'll see if I can find the right issue tracker to report something like this with Python core.

For now, to get green light on CI, I wanted to use double backticks and had a look. But the first warning is due to the list when sub-classing, i.e. I can't add backticks there:
class ShapeList(list)

So maybe try the intersphinx suggestion you pointed out?
Is it this file?
astropy_helpers/astropy_helpers/sphinx/local/python2_local_links.txt

@bsipocz What line exactly do we have to add? Do we have to run a command to update the .inv file? Could you please add a commit to this PR doing it?

I've complained about the missing list in the Python 2.7 docs here: http://bugs.python.org/issue30882
Possibly we'll just have to wait a bit until they add it back and take no action here.
@astrofrog - Apart from this unrelated issue, what do you think about this PR (see original description at the top)?

@cdeil - Thanks for reporting it upstream. Hopefully they'll move to GH soon, so I'll start reporting these issues, currently their UI makes me prefer living with the issues rather than opening a ticket for them.

Hopefully they'll move to GH soon, so I'll start reporting these issues,

I vaguely remember some talk or blog post where they described their move to Github for development, and the reasons they won't move the issue tracker to Github any time soon.

currently their UI makes me prefer living with the issues rather than opening a ticket for them.

Agreed, the web interface  is ugly. But it works, took me 2 min to file the issue.

I go ahead and merge this as only the upstream list related issue remained.
I can also update the travis matrix once there is an agreement on which astropy version should we support. I think 1.0.x is an overkill, but probably still doable, so I'm quite neutral on the question.


User Story 1977015

Code update as part of User Story 1977015

#sign-off

#sign-off

@lonegunmanb Edits made. Possible to merge this morning (PST) as I have work depending on this work.


No multiple instance possible

Dear @mampfes,
after installing one instance from your integration, it is not possible to install a second instance.
If i click on (Integration hinzufügen) and search to "DWD Pollenflug" i get no result

You can see the first instance in the screenshot.

Sorry, I can't reenact your issue. I can add multiple integrations and DWD Pollenflug still shows up in the "Integration suchen" window. Please check your Home Assistant configuration because this has probably nothing to do with the DWD Pollenflug integration.

After a few restarts from HA and clearing the Browser Cache it works!
Thank you for your Support!


[Table] Dynamic TableRow do not show checkbox

I have created a component which generates Table and another one which generates TableRows. The problem is that the checkbox on the rows are not showing.
Any ideas?
Thanks

+1

@suhail-ansari-apconic Any chance TableRows aren't directly nested inside TableHead? Table needs to pass down some props in order for it to function properly.

Same problem for me. Rows rendering looks like this:
<TableBody>
    {this.rows.map(row => <MyTableRow key={row.id} data={row} />)}
</TableBody>

and MyTableRow render() looks like:
let {data, ...others} = this.props
return (
    <TableRow {...others}>
    <TableRowColumn>{data.id}</TableRowColumn>
    <TableRowColumn>{data.name}</TableRowColumn>
    </TableRow>
)

So yes, rows are not direct children of body.
But the spread notation should pass all parent properties, no?

I think I have the same issue, although the row has all the right properties (selectable=true, displayRowCheckBox=true)
My rows are nested inside the TableBody element, but the children containing the checkBox is missing.

Actually I have resolved the issue. The thing is that when you are wrapping the TableRow inside another component than all the props are not passed to it. The best thing to do is to pass all the props from your wrapping component to TableRow.
class WrappingRow extends React.Component {   render() {    const { yourProps, ...other } = this.props;    return (     <TableRow {...other}>     ......     </TableRow>     );   } }

@suhail-ansari-apconic how is that different from what @marc-rutkowski wrote above?

@Kosta-Github ...other rather than ...others

<lol />

This solution didn't work for me....I was able to get the check boxes to display, but now when I click on a single Row's check box, it selects all Rows. Need to have individual selection, as well as the option to select all from the header check box. Anybody able to fully resolve this issue??

@kcgunn

This solution didn't work for me....I was able to get the check boxes to display

how you get checkboxes to display?

Why this issue is closed?
Checkboxes are not working if TableRow is moved to separate component, even if do this trick with passing ...props down to component

@oliviertassinari bump

@NeXTs I don't have much thought on this <Table /> component. I have never really looked at it. Btw, it was rewritten by @nathanmarks on the next branch.
Still, passing the props down the tree sounds like  a good solution. Why is this not working?
I can only think about two other approaches:

remove the need of passing props to the child <TableRow />. I'm not sure that it can be done.
using the context instead of the props. But that sounds overkill.

I was having the same problem and I fixed it according to this piece of code: http://stackoverflow.com/questions/37479568/material-ui-tablerow-wrapped-in-component-wont-show-checkbox
render() {
    const { order, ...otherProps } = this.props;
    return(
        <TableRow { ...otherProps }>
            {otherProps.children[0] /* checkbox passed down from Table-Body*/}
            <TableRowColumn>{ order.reference }</TableRowColumn>
                ... All others columns ...
            <TableRowColumn>
                <RaisedButton label="View" primary={true} linkButton={true} href={ '/order/' + order._id }/>
            </TableRowColumn>
        </TableRow>
    );
}

Quote from the answer: "You need to both spread otherProps into the TableRow and explicitly render the checkbox."
Is this the desired pattern to use?

Could you please re-open this issue? There are some tricks but isn't solved yet.

I just got bit by this as well.

+1

Thanks @marijnhurkens for the answer.
But I still have an problem that: now the checkboxes in the tablebody appear but I their style is enable but I
can't check them neither select all. Only the 'check all' checkbox in the tableheader works but it can't make other checkboxs checked.


Service naming rules support would be awesome

Service naming rules support would be awesome

Thanks, I'll put it on the list of configs to add in upcoming releases.


build(deps): bump @nestjs/swagger from 5.2.1 to 7.1.7

Bumps @nestjs/swagger from 5.2.1 to 7.1.7.

Release notes
Changelog
Commits

Also switches to nestjs 9
updated-dependencies:

dependency-name: "@nestjs/swagger" dependency-type: direct:production update-type: version-update:semver-major ...

As this is  bumping core deps, I leave merging to @nitrosx.


Display Time of action

Right now the bot logs the remaining time for the next pixel imput, but it doesn't state when it made that last check, it would be a nice addition so we can know if the bot got stuck or something.
So:
HH:MM 'username' ###s

Good idea, I just improved the logging of the queues, now it says:
Next account in XXX seconds, at HH:MM
And it doesn't log anything else until then.


static_key_parse_error on Android

Hello,
I have the same issue than here : https://github.com/angristan/openvpn-install/issues/500

The openvpn-install script ran successfully, on a Debian 10 server.
However when I tried to import it into an Android 7.0 device, running the official OpenVPN client, I got a "Failed to parse profile: static_key_parse_error".
After inspecting the .ovpn client file, I noticed that the tls-crypt section in it is empty:

<tls-crypt>
</tls-crypt>

Since this is the first time I've ran the openvpn-install script (with no other options passed to it), I have no idea if this is something that the script should have taken care of it, or I should do something

Thanks for any suggestions

Any Solution ? I can't use it on Android 10.

 empty .
Thanks ;)

Don't work on windows too
"Insufficient key material or header text not found in file '[[INLINE]]'"
I have an Debian 10 server

After do that :

Add /usr/sbin to Debian $PATH

and that :

openvpn --genkey --secret /etc/openvpn/tls-auth.key

It's OK !

You have the same issue as #523 and #593. To fix use su - or sudo -i to get root, run the script to Remove OpenVPN and run again to reinstall.
EDIT:

After do that :
Add /usr/sbin to Debian $PATH
and that :
openvpn --genkey --secret /etc/openvpn/tls-auth.key
It's OK !

I would strongly recommend to use the proper way to get root permission instead.


Move cmake files from datadir to libdir

Current location is preventing me to detect it correctly.

It might be specific to my build setup: I use RPM to build a package and it detects the cmake folder automatically in lib64/cmake and thus adds an automatic Provides: cmake(nameofthelibrary) to be called from other packages depending on it. But it does not work in /usr/share. This is pretty distribution specific so I can keep my patch downstream and close this PR if it's ok.

Thanks for the background. It looks like there isn't a canonical location for these though the cmake docs use lib/ in their current examples [1]. Out of curiosity do any of the other forms work like changing sjpeg/cmake to cmake/sjpeg under /usr/share?
[1] https://cmake.org/cmake/help/v3.20/manual/cmake-packages.7.html?highlight=configpackagelocation#creating-packages

I've tested cmake/sjpeg under /usr/share and it works. I don't know the list or all working pattern, nor how they are detected by RPM.

Thanks for trying it out. I'll let Pascal comment, but staying with /usr/share is fine to me.

thanks for trying both solutions. If they are both working and allowed, let's just keep it as is, to minimize disruption!


Add --no-restore to add package

:sparkles: Adds the -n switch to the add package command to fix #1100
:boom: Does this PR introduce a breaking change?
:bug: Recommendations for testing
:memo: Links to relevant issues/docs
:thinking: Checklist before submitting

[ ] All projects build
[ ] Relevant documentation was updated

Sorry, I committed to the wrong PR.


phi group dimensions appear in output Dataset

Output dataset should not contain phi_grp dimensions:
<xarray.Dataset>
Dimensions:                     (age_group: 5, compartment: 16, phi_grp1: 30, phi_grp2: 30, risk_group: 2, step: 121, vertex: 3)
Coordinates:
  * age_group                   (age_group) <U5 '0-4' '5-17' ... '50-64' '65+'
  * compartment                 (compartment) <U5 'S' 'E' 'Pa' ... 'Iy2Ih' 'H2D'
  * phi_grp1                    (phi_grp1) int64 1 0 5 4 3 2 ... 22 27 26 29 28
  * phi_grp2                    (phi_grp2) int64 1 0 5 4 3 2 ... 22 27 26 29 28
  * risk_group                  (risk_group) <U4 'low' 'high'
  * step                        (step) datetime64[ns] 2020-02-01 ... 2020-04-01
  * vertex                      (vertex) int64 0 1 2
Data variables:
    apply_counts_delta__counts  (step, vertex, age_group, risk_group, compartment) float64 ...
    foi__beta                   float64 0.035
    read_config__config_fp      <U83 '/Users/TASethanho/tacc/projects/meyers/...

Likely due to use of global_name in InitPhiGrpMapping: https://github.com/eho-tacc/episimlab/blob/a78732e95593e474fce596ab421c6bef6d5fb317/episimlab/setup/phi.py#L20 (introduced in https://github.com/xarray-contrib/xarray-simlab/pull/160).

Looks like it's actually intended behavior for xsimlab, and my misusage of xs.index, which will always put a dim in the ouput Dataset. Other global refs like phi_grp_mapping do not appear in output DS: https://github.com/eho-tacc/episimlab/blob/a78732e95593e474fce596ab421c6bef6d5fb317/episimlab/setup/phi.py#L22


Doc example drag

Description
This example showcases the use of sharp immersed boundary conditions for the evaluation of the flow around a non-spherical particle. We show the validity of the method at evaluating the drag on the particle with values from litterature. For now the example targets a Reynolds range of 0.1 to 1with low aspect ratio particles (2) in cross flow.
Still missing some figures, will add them in the short term.
Miscellaneous (will be removed when merged)
Further improvement could open the example to higher Reynolds values and interesting results with orientation variation.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:

[ ] Lethe documentation is up to date
[ ] The branch is rebased onto master
[ ] Code is indented with indent-all and .prm files (examples and tests) with prm-indent
[ ] Links are added to parent .rst files
[ ] The example is following the standard format

Pull request related list:

[ ] Labels are applied
[ ] There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
[ ] If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
[ ] If any future works is planed, an issue is opened
[ ] The PR description is cleaned and ready for merge

@Julamipolymtl please suggest two reviewers. You can ask in the slack lethe channel

@Julamipolymtl can you re-open this pull request?


version 1.2.3 of ace throws warning

index.js:3543 Automatically scrolling cursor into view after selection change this will be disabled in the next version set editor.$blockScrolling = Infinity to disable this message

In fact, ace had always thrown this warning. Not a lot I can do about it. You're able to turn it off though.


Check widget is mounted

When switching to another widget; the video continued to play on the back and wants to report transactions, but the widget failed because it was not mounted.
For this reason, it is provided to check whether the widget is mounted or not.

I encountered the same error. I'll check this with the latest version and let you know. Thanks @wolcy97 !

Erro still exists and the check in cupertino_controls and material_progress_bar was missing. Thanks for this PR!


ref(probes): move k8s probe from liveness into readiness

Summary of Changes
move the k8s api check to readiness probe
Issue(s) that this PR Closes
Associated End To End Test PR(s)
Associated Documentation PR(s)
Associated Design Document(s)
Testing Instructions
Please provide a detailed list for how to test the changes in this PR.

Create a Deis Cluster
Deploy an app successfully

Pull Request Hygiene TODOs
Please make sure the below checklist is complete.

[x] Your pull request is concise and to the point (make another PR for refactoring nearby code)
[x] Your commits are squashed into logical units of work
[x] Your commits follow the commit style guidelines

@kmala code LGTM. is there a change to deis/charts to go along with this change?

yes https://github.com/deis/charts/pull/263


SynthAndRecog - Recog Status 006

I use SynthAndRecog with long text in Synth does not have time to work out Recog. How can this be corrected?

If I understand your problem correctly, one of the options would be to disable barge-in by setting b=0 in SynthAndRecog. However, the server logs would be required to understand what actually caused recognition to complete with 006.


Implement plugin hooks, so we can hook onto current functions

The basic functionality of plugins is as follows:

Plugins register their own command
Plugins need to be manually activated by the user, downloading is not enough
Plugins can be deactivated by the user by removing the plugin from the configuration file
Plugins can send realtime messages to the CLI by sending messages to the Broadcast singleton class

I think this does suffice for now. Closing.


Print out Python versions in compare output

It would be nice to print out more version details in the compare output to act as a double-check that the results are using data from interpreters that are expected.

You can manually inspect JSON files using the perf module directly. Example:
python3 -m perf show --metadata test.json
Common metadata:
- aslr: Full randomization
- cpu_affinity: 3,7 (isolated)
- cpu_config: 3,7=driver:intel_pstate, intel_pstate:no turbo, governor:powersave
- cpu_count: 8
- cpu_model_name: Intel(R) Core(TM) i7-2600 CPU @ 3.40GHz
- hostname: smithers
- loops: 1
- perf_version: 0.7.8
- performance_version: 0.2.2
- platform: Linux-4.5.7-300.fc24.x86_64-x86_64-with-fedora-24-Twenty_Four
- python_cflags: -Wno-unused-result -Wsign-compare -Wunreachable-code -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DNDEBUG -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv
- python_executable: /home/haypo/prog/python/performance/venv/cpython3.5-19471deca1cb/bin/python
- python_implementation: cpython
- python_version: 3.5.1 (64-bit)
- timer: clock_gettime(CLOCK_MONOTONIC), resolution: 1.00 ns

2to3
----

Metadata:
- cpu_freq: 3=3400 MHz, 7=1942 MHz
- cpu_temp: coretemp:Physical id 0=54 C, coretemp:Core 0=49 C, coretemp:Core 1=50 C, coretemp:Core 2=47 C, coretemp:Core 3=54 C
- date: 2016-09-13T11:28:01
- description: Performance of the Python 2to3 program
- duration: 2.4 sec
- load_avg_1min: 1.46
- mem_max_rss: 13.0 MB
- runnable_threads: 2

Median: 2.38 sec

(...)

Sadly, I removed the --metadata parameter from the "perf compare" command. I should reimplement it.
But there are many metadata, the output can be seen as too verbose.
Yeah, we can at least write a short summary of the most important metadata. For example, display python_executable + python_version?

I think that would be enough.

Fixed by the commit 4c566f1595ae8c5d627740aa2ab5c79053cb1839. Python version is now displayed.
By the way, I added a new "show" command. Since the old Python benchmark suite (benchmarks) didn't support writing results into a file, there was no need for such command before.
The display_suite_metadata() function of performance/compare.py is written to be extensible (display more metadata).
I chose to not display the python_executable metadata because we currently get a file like ".../venv/cpython3.5-8d80a6da3c25/bin/python" which is not the original path. Maybe performance should override this metadata somehow? At least for the first run which just created the virtual environment? But I suggest to open a new issue for that, if you consider that it's worth it.


Adding Wesley Liang to contributors list

@wesliang, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?


Fixed missing instance in instance method call

The missing url instance object was dealing ReferenceError:
.../node_modules/activecampaign/lib/Connector.js:25
		url = replace(regex, "");
		      ^
ReferenceError: replace is not defined

Thanks!

Hey! My first pull request ;-)


Rhymestone VIA/VIAL definitions do not work

Just as the Title says the VIA/VIAL definitons are outdated, and do not work with the current version of VIA.
the JSON file gives errors, when trying to load/sideload it.
I also have the issue that with the default layout the bottom row does not work

Update: The bottom row issue seems to be caused by the arduino I used, it had a defective trace/bad connection.

Is there been any update on adding VIA/VIAL support for the Rhymestone?

Found the VIA version on the QMK github page.
for some reason with MSYS it did not download so i had to add the files to the keymap/firmware directory, myself.
The VIA firmware seems to be working fine. though the only Issue I encounter for now is when I try to sideload it into VIAL.
File "main_window.py", line 284, in on_device_selected
File "main_window.py", line 304, in rebuild
File "editor\keymap_editor.py", line 125, in rebuild
File "keycodes.py", line 870, in recreate_keyboard_keycodes
AttributeError: 'Keyboard' object has no attribute 'tap_dance_count'
Since I now have the VIA_keymap.JSON, I can more easily see if I can make my own VIAL compatible version, that does not have the sideloading issue.

there are a few issues with vial. it shows the RGB menu even with RGB disabled. not sure what causes this issue, gonna test a few things later to see if I can fix this,
havent found any other issues yet

Sorry I didn't notice.
Please use the file here.
We have confirmed that it works with REMAP.
https://github.com/marksard/qmk_firmware_hex/releases
https://remap-keys.app/
Sorry about the vial support, we cannot respond.


541-add-linuxbrew-option

[x] Add option to install linuxbrew

Customize docker-compose.yml as follows:
...
- INSTALL_LARAVEL_ENVOY=false
- INSTALL_LINUXBREW=false
- PUID=1000
...

@mikeerickson Works great! Just add some documentation for it in the README and I'll happily merge this.

@philtrep sounds good, I will get it updated this evening.

@philtrep OK, all done (I have updated the README.md file)  Please let me know if you need anything else.

@mikeerickson Thanks for your contribution!


refactor: add implementation

When clicking on a function declaration it should offer add implementation and add implementation in corresponding .cpp file.

Yep. We have the "define-outline" code action which is very closely related, so a workaround is:

replace ; with {}
trigger "define outline"

But we should support this directly. @kadircet there's no reason this would be harder, right?

Oh, there is a catch: it's kind of bad to offer this if a definition exists.
This is mostly relevant in a header file, where the existing definition (if it exists) isn't visible through the AST.
"define-outline" triggers on definitions, so we can just assume there's no other definition and offer the refactoring.
However "add implementation" triggers on declarations, and we need to find out if the definition already exists.
We can't necessarily afford to query the index to see if a definition already exists. Or rather, currently refactorings are independent, and having them all query the index to check whether to offer the refactoring doesn't scale. Maybe we need to add some mechanism for refactorings to coordinate index requests, or maybe we should just have the "framework" look up the decl under the cursor in all cases.

Yes there were 2 concerns; first is the one you mentioned, cost of querying the index in all of the tweaks during prepare. we were thinking about coming up with a "short-lived cached-index" that could be shared among all prepares (for a single code-action invocation) as in theory most of the checks should be querying the same symbols, but this was a bold claim at the time (and I think still is).
the second one is, even if we query index we might still be missing the definition, e.g. bg-index is off or stale. and then code action will result in broken code (hopefully a compile error, but it might even introduce ODR violations).

Does VSCode/LSP support a two-stage approach? First some generic entry like 'Add/Move Implementation...' and only then it queries and shows the options in a new selection menu?

clangd currently offers all of its refactoring actions through a mechanism called "code-actions" which is indicated by a lightbulb icon in vscode whenever available. So as @sam-mccall suggested you can try something like:
in a.h:
struct A {
  void foo() { return; }
};

and also have a file called a.cpp (action is normally more clever than that) and put your cursor over foo in the header. Then you should see a lightbulb with subselections containing "move function definition out-of-line".

Didn't get any define outline code action with clangd 10, neither in the .h nor when putting the class in the .cpp.
Anyway, I also just had the need for the opposite refactoring, move out-of-line implementation into the class body.

Didn't get any define outline code action with clangd 10, neither in the .h nor when putting the class in the .cpp.

yeah looks like we forgot to flip the flag of define out-of-line in clangd-10 release :( sorry for the confusion.
you would need a top of the tree build, or use one of our weekly builds at https://github.com/clangd/clangd/releases
or you could try passing --hidden-features to clangd, note that this will result in having some actions always available (for debugging purposes hence the lightbulb will be always with you).

Anyway, I also just had the need for the opposite refactoring, move out-of-line implementation into the class body.

we also have that one, but it is quite conservative. it will refuse to move any function if a symbol within the body "might" not be visible at the declaration location.

Will test it sooner or later. Hopefully it also works with template classes.

yeah looks like we forgot to flip the flag of define out-of-line in clangd-10 release :( sorry for the confusion.
you would need a top of the tree build, or use one of our weekly builds at https://github.com/clangd/clangd/releases
or you could try passing --hidden-features to clangd, note that this will result in having some actions always available (for debugging purposes hence the lightbulb will be always with you).

Hi, currently running the latest pre-release build (clangd_snapshot_20201018), and I am not seeing this code action with coc-nvim. Is there any other flag I need to set for newer clangd versions?

nope, can you provide logs? preferably on a separate bug and while passing --log=verbose to clangd.

nope, can you provide logs? preferably on a separate bug and while passing --log=verbose to clangd.

Alright, I opened https://github.com/clangd/clangd/issues/568 with my testcase.

Would it maybe be an option to add a protocol extension for this? Something like textDocument/implementMethod you'd trigger with the cursor on a function definition. We'd only need to query the index once the client sends the request and possibly return an error if there's already a definition somewhere.

@kadircet After two years, are the concerns still valid? I.e. is querying the index in prepare() still expensive, or it got cheaper during the progression of clangd? Was some kind of the aforementioned "short-lived cached-index" introduced? What I want to ask really: can we progress with this feature?
Regarding the ODR violations, maybe we could rely in that case on the compiler/linker to properly resolve them, so that the risk that we generate another copy of the function definition could be mitigated? With the DefineOutline tweak, we assume that no definition exists without query, thus there are certain assumptions we can make and "live with them"?
I have implemented a feature like this as a standalone command line tool on top of libclang, and later introduced a VIM plugin which utilizes it. Yet, I feel that it could easily be a CodeAction that could be used by and LSP client working with clangd.

I'd like to revive this discussion, as I believe this is valuable functionality that users rightfully expect to exist.
As to the two concerns mentioned:
a) The performance argument seems to be of the "slippery slope" kind. Of course you don't want every tweak to query
the index, but as of now, there would be exactly one of them, and it would have a very good reason to do so.
I'd argue that it suffices to keep an eye on this for new tweaks, and if a second or third one comes along that
can claim in good conscience that it needs to query the index, we can still look for a general solution. (And because
we will have several uses cases by then, we will have a better idea about the requirements, i.e. there's less danger
of introducing an infrastructure that misses the mark).
b) I'm not convinced by the argument that we might break the code if the index is out of date. That can happen with any
action that changes code across translation units, most prominently symbol renaming.

One note from my side regarding broken code resulting from this:
(Sam)

This is mostly relevant in a header file, where the existing definition (if it exists) isn't visible through the AST.
"define-outline" triggers on definitions, so we can just assume there's no other definition and offer the refactoring.
However "add implementation" triggers on declarations, and we need to find out if the definition already exists.

(kadircet)

the second one is, even if we query index we might still be missing the definition, e.g. bg-index is off or stale. and then code action will result in broken code (hopefully a compile error, but it might even introduce ODR violations).

At least in my experience, 99% percent of the time when I want to apply this tweak, I know that no definitions exists yet, since I just added the declaration to the header file, and now want to generate the definition in the .cpp.  Are there any other workflows I'm missing here? Will people really try to trigger this on function declarations which already have a definition?

At least in my experience, 99% percent of the time when I want to apply this tweak, I know that no definitions exists yet, since I just added the declaration to the header file, and now want to generate the definition in the .cpp. Are there any other workflows I'm missing here? Will people really try to trigger this on function declarations which already have a definition?

At the very least, it would spam the list of available tweaks and potentially add bogus light bulbs, which would certainly be annoying. However, with the index querying it should be a rare occurrence.

At least in my experience, 99% percent of the time when I want to apply this tweak, I know that no definitions exists yet, since I just added the declaration to the header file, and now want to generate the definition in the .cpp. Are there any other workflows I'm missing here? Will people really try to trigger this on function declarations which already have a definition?

At the very least, it would spam the list of available tweaks and potentially add bogus light bulbs, which would certainly be annoying. However, with the index querying it should be a rare occurrence.

Oh right I forgot about the light bulb, I do not have that configured in my editor.

In vscode, There was a extention call c-mantic has implemented the feature.
In nvim, Has a plugin nvim-treesitter-cpp-tools
In vim, I used the treesitter + coc.nvim wrote a plugin that implements the simplest feature of adding a definition, where the user can decide whether to copy the definition to the clipboard or to a file, the plug-in is still in the development stage there should be a lot of cases that have not been taken into account, just to provide an idea of implementation  coc-mantic

Could this feature also do the reverse? Add a function declaration (in the right place) when clicking on a function definition.

Could this feature also do the reverse? Add a function declaration (in the right place) when clicking on a function definition.

Are you thinking of a member or non-member function here?
The member function case is trickier since the starting point would be invalid code if a declaration does not yet exist.

The member function case is trickier since the starting point would be invalid code if a declaration does not yet exist.

Is it really as simple as that, why can't it be solved by a fixit quick action on the error itself?
For example if I use a function from an unimported header, clangd can still produce a quickfix action to add that include, despite it clearly being invalid code.


Similar to the previous issue

Hi team,
thanks for correcting the previous issue with Exchange Location. I believe there is another fix required for the One Drive location parameters (OneDriveSharedBy) as we need to specify (All) as an input which is not an accepted input for (OneDriveSharedBy):

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 64d46b9d-594b-e24e-4964-71dab360cd28
Version Independent ID: a6b0658b-cbda-6d29-59f1-d1189208c72a
Content: New-DlpCompliancePolicy (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/New-DlpCompliancePolicy.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@chrisda Understood, but we need a parameter to accept "All" as a value, according to my testing, "OneDriveSharedBy" does not.

@walidelmorsy, you should open a support ticket. All is definitely available in OneDriveLocation (site-based) but not in OneDriveSharedBy/OneDriveSharedByMemberOf (user-based).

@chrisda that is what I said. In the article it says “don’t use OneDriveLocation parameter”, which I think it should be corrected.

@chrisda Please comment. Thanks

OK. I figured it out and updated the topics accordingly:

OneDriveLocation does act like ExchangeLocation, except it isn't locked down as tight. It accepts the value All or site URLs that it can verify (the way the parameter behaves in most other cmdlets). When you create a new DLP policy in PowerShell, the default value of OneDriveLocation is All, which means: Include all OneDrive for Business sites in this policy.
[ExceptIf]OneDriveSharedBy and [ExceptIf]OneDriveSharedByMemberOf restrict the policy to specific sites based on associated users (individuals or group members) and prevent the policy from applying to sites of specific users or group members.
In Set-DlpCompliancePolicy, you can use -RemoveOneDriveLocation All to remove ODfB sites from the policy, or -AddOneDriveLocation -All to add ODfB sites to the policy if you created the policy with -OneDriveLocation $null.

OK?

@walidelmorsy Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


RenderingDevice cannot release texture resource when window is minimized

Tested versions
4.3.stable.mono
System information
Godot v4.3.stable.mono - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 (NVIDIA; <IP_ADDRESS>61) - AMD Ryzen 9 7900X 12-Core Processor (24 Threads)
Issue description
When the game window is minimized, the texture created by RenderingDevice.create_texture() won't be freed by calling RenderingDevice.free_rid().

when the game window is not minimized

when the game window is minimized after a while
BTW, the Memory inspected by Editor Debugger grows much slower than inspected by Windows Task Manager, when this bug is triggered.

not minimized

minimized after a while
Steps to reproduce
extends Node2D

var rd : RenderingDevice;
var texture : RID;

func _ready() -> void:
	rd = RenderingServer.get_rendering_device()

func _process(delta: float) -> void:
	#RenderingServer.call_on_render_thread(create_texture);
	create_texture()

func create_texture() -> void:
	if texture.is_valid():
		rd.free_rid(texture)

	var format = RDTextureFormat.new()
	format.width = 1024
	format.height = 1024
	format.depth = 1
	format.format = RenderingDevice.DATA_FORMAT_R8G8B8A8_UNORM
	format.array_layers = 1
	format.mipmaps = 1
	format.usage_bits = RenderingDevice.TEXTURE_USAGE_SAMPLING_BIT | RenderingDevice.TEXTURE_USAGE_CAN_UPDATE_BIT | RenderingDevice.TEXTURE_USAGE_STORAGE_BIT

	texture = rd.texture_create(format, RDTextureView.new(), [])

This script will create a texture pre frame and release the texture created last frame.
Attach it to a node and run the scene.
Minimize the game window (not editor). (just hide this window below other windows won't trigger this bug)

Minimal reproduction project (MRP)
See 'Steps to reproduce'

Maybe related with #90030 and #90017.
Similar situation is also found when a NoiseTexture Resource is modified every frame by a script (I know it is not recommended).
In my understanding, the NoiseTexture will create a new texture when the parameter is modified. So this bug might be triggered when the window is minimized.

A workaround should be checking if the game window is minimized before creating resources from RenderingDevice.
Such as:
if Engine.get_main_loop().root.mode == Window.MODE_MINIMIZED:
   return
# ... original code

Do the resources get freed once the window is no longer minimized?

When the free_rid() method is called the resources are not released immediately, but are queued to be freed in the next frame, but when the window is minimized the gpu cycle is paused which means it doesn't process frames anymore, this causes resources to be queued but never released. And when the window is opened up again it starts to process the frames and clears out the queue.
As a test, I added this inside add_frame_delay method in os.cpp,
if (!p_can_draw) {
	RD::get_singleton()->_flush_and_stall_for_all_frames();
}

It solved this problem, #90030 and also #90017, but I'm not sure what would be the proper implementation because _flush_and_stall_for_all_frames is a private method (I changed it to public for testing) and calling it every frame might be problematic.

@Uumutunal Great work! That seems like an acceptable workaround. We could probably store a variable to ensure that we only call _flush_and_stall_for_all_frames() once when the window is first minimized.
However, the way I understand things is that resources should get cleaned up on the next frame, which should happen once the window is opened back up. However Hippogyz' comment Seems to indicate that, even after the GPU starts processing frames again, it doesn't clean up the resources. Which makes me think that maybe there is still a problem somewhere else and the resources are somehow getting orphaned before they are actually cleaned up.
@DarioSamo what do you think?

We could probably store a variable to ensure that we only call _flush_and_stall_for_all_frames() once when the window is first minimized.

I'm guessing calling it once won't work because new resources keep getting created while the window is minimized. We would have to call it at regular intervals at least, something like once a second.

even after the GPU starts processing frames again, it doesn't clean up the resources.

After testing it more, yes you are right, it seems that only part of the resources are freed unless it is very small amount like 1-2 mb. I have no idea why this happens though.

Resources are not freed until there's a guarantee the GPU is no longer executing the frame. It only knows that if it has to wait for the fence, which happens when it wants to begin drawing on that frame in the queue. Therefore destruction of resources is delayed until that frame begins recording.
void RenderingDevice::_begin_frame() {
	if (frames[frame].fence_signaled) {
		driver->fence_wait(frames[frame].fence);
		frames[frame].fence_signaled = false;
	}

        ...

	_free_pending_resources(frame);

       ...
}

Calling _flush_and_stall_for_all_frames() does indeed fix most of the issue as the trick the method does is wait on the current frame to finish executing and begins the next one.
We're indeed lacking a way to force this. There's other methods such as buffer_get_data() that will also trigger it, but we don't have a method publicly exposed for it. sync() is the closest we have, but the use of submit() and sync() is reserved for Local Devices only.
It'd seem the only way to go about it is making the sync() method accepted or to add a different method altogether.

Asking just to learn because I'm pretty much new to this, but why can't we simply add a public method and call _flush_and_stall_for_all_frames() or even _free_pending_resources()?

Adding public methods to certain classes is usually done with extreme care because these classes are exposed to users either via GDScript or Extensions and require documentation. It also presents a commitment to support this new method in future versions and ensure we break compatibility as little as possible.
If we come to situations like this where there's no other solution, we can discuss it and add the method, but it's not usually something that we should think of as the first solution if possible.

Alright, that makes sense. Thanks for the explanation.

@DarioSamo What do you think about the fact that not all resources are getting freed once the window is opened again? It looks like in hippogyz' case a lot of the memory is never freed, even once the window is opened again

This might be the same issue as https://github.com/godotengine/godot/issues/84212

@DarioSamo What do you think about the fact that not all resources are getting freed once the window is opened again? It looks like in hippogyz' case a lot of the memory is never freed, even once the window is opened again

Stale references perhaps? Could be a problem caused by either RenderingDevice or something else. I think that'd warrant investigation separate from the issue that was suspected.

I'm a bit confused about the possible implications on how to solve this properly. There's something that rings wrong to me about the fact that we allow GDScript to call code on instances where the frame queue is not active because it's no longer presenting to the screen.
While the OP has shown a fairly simple script that demonstrates the issue, it falls to reason there'll be many other errors like for example attempting to draw something using RD while the window is minimized. Even that kind of situation will lead to an endless amount of commands being queued and never generated, eventually leading to an overflow of the maximum command list size allowed by the GPU.
The only solution I see to that is running the frame queue on the background regardless of that, but if present is skipped, that means the resources will be saturated while the window is minimized and the GPU will keep doing a ton of work.
We'd need some sort of mixed solution where we allow running frames only if the user has requested something from RenderingDevice while the window is minimized, and of course we don't present to the swap chain. Do we want to go for a solution like that?

After looking into it further, I see we got some logic that already handles the fact viewports are not drawn while the window is minimized. We might be able to find some path from that to make RD execute the command queue if it's not empty (e.g. RS has a 'has_changes' method that might come in handy).

Adding something here that has a method for RenderingServer to check whether it has any queued commands to process is probably our best bet here.
bool buffers_swapped = false; // New
if ((DisplayServer::get_singleton()->can_any_window_draw() || DisplayServer::get_singleton()->has_additional_outputs()) &&
		RenderingServer::get_singleton()->is_render_loop_enabled()) {
	if ((!force_redraw_requested) && OS::get_singleton()->is_in_low_processor_usage_mode()) {
		if (RenderingServer::get_singleton()->has_changed()) {
			RenderingServer::get_singleton()->draw(true, scaled_step); // flush visual commands
			Engine::get_singleton()->increment_frames_drawn();
			buffers_swapped = true; // New
		}
	} else {
		RenderingServer::get_singleton()->draw(true, scaled_step); // flush visual commands
		Engine::get_singleton()->increment_frames_drawn();
		force_redraw_requested = false;
		buffers_swapped = true; // New
	}
}

if (!buffers_swapped) {
	// New
	RenderingServer::get_singleton()->command_that_flushes_rd();
}

The script posted by the OP has no interaction with RenderingServer whatsoever to find out if there's anything queued up, so we'd basically need some way for RenderingServer to redirect and perform a check on RD if there's anything that needs to be processed or freed.
Like I said, this issue is not entirely about the fact that resources are not freed, but a script that constantly fills and submits drawing lists will also run into the same issue and eventually run out of command buffer memory.


Get coordinates of drawn layer as it is being drawn

Hello, I am looking for a way to highlight features in a geojson layer as I draw a rectangle over them (using the bounds of the draw layer as it is updated). Is there a way to do this?
I thought this discussion might be close to what I need, but I couldn't find a way to pass an existing empty layer to .enableDraw() so that the pm:snapdrag function would be activated.
Do you have any suggestions? Thanks.

I think you need to listen on the pm:create event:
map.on('pm:create', (e) => {
  if(e.layer instanceof L.Marker){
     console.log(e.layer.getLatLngs();
  }
});

or for while drawing the pm:drawstart event and then the workingLayer
map.on('pm:drawstart', (e) => {
  console.log(e);
});

Thanks for the response.
I tried using the code that you posted in the discussion I referenced:
      map.on('pm:drawstart', ({ workingLayer }) => {
        console.log('workingLayer: ', workingLayer)
        workingLayer.on('pm:snapdrag', e => {
          console.log(e)
        })

workingLayer shows up in the console. But I never see anything from the snapdrag event. Is that because I am trying to draw a rectangle? If so, do you have an event for listening to a layer while drawing?

snapdrag is not fired because there are no other layers on the map, on which it can snapped. But go away from this event, it is not the correct one for your usage.
You want to draw a rectangle and get the layers below.
If you want to get the layers AFTER drawing, use this:
map.on('pm:create', (e) => {
  if(e.layer instanceof L.Rectangle){
     var bounds = e.layer.getBounds();
     YOUR_FUNCTION_TO_GET_THE_LAYERS_IN_BOUNDS(bounds);
  }
})

if you want to get the layers below the rectangle WHILE drawing, use this:
function getBoundsOfLayer (e){
  console.log(this.getBounds()); // this == layer, because while adding the move-event-listener with on, we pass the layer as context
   YOUR_FUNCTION_TO_GET_THE_LAYERS_IN_BOUNDS(this.getBounds());
};

map.on('pm:drawstart', (e) => {
  var layer = e.workingLayer;
  if(layer instanceof L.Rectangle){
    map.pm.Draw.Rectangle._hintMarker.on('move', getBoundsOfLayer, layer);
  }
});

Thank you. This was helpful and allowed me to achieve what I wanted.
I needed to have a way to check if the first point of the rectangle had been placed so I did something like this:
          if (
            window.L.DomUtil.hasClass(
              this.themap.pm.Draw.Rectangle._startMarker._icon,
              'visible'
            )
          ) {
            ....continue with code
            }

I'm not sure if there is a better way to do so, but this worked for me.
Thank you again for your help, and for this awesome library.

I'm glad this was resolved, but I think this thread raised more questions than it answered.
Currently, my way of detecting events while drawing is to do:
map.on('pm:drawstart', (e) => {
var workingLayer = e.workingLayer

workingLayer.on('pm:snapdrag', (e) => {
   // do something while drawing, and only while drawing

} // end snapdrag

} // end drawstart

As @Falke-Design correctly pointed out, there pm:snapdrag only gets fired when there's a layer to get snapped to already on the map. This poses errors when you want something to happen while drawing when there's nothing on the map currently. I suspect an ugly workaround would be to create a shape on the map at the beginning of drawing, out-of-view from the user (north or south pole?) so that pm:snapdrag would be called. Regardless of this workaround, I believe there should be an event that is fired while drawing a Circle, Polygon, or Rectangle.


No "Run" button when *.cs file opened

I've created a separate .cs file with a class and static Main() method.
If I opening it it in VisualStudio - no "Run" button available. There is only "Attach" button.

@fx-practic -- thank you for your feedback.  Are you following a particular docs.microsoft.com article?  Meanwhile, please consider these resources:

Visual Studio on Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit


Packaging improvements

I noticed that Smelte is one of the more popular packages that doesn't work with SvelteKit yet (https://github.com/matyunya/smelte/issues/230). Here's a couple things I noticed that should probably be changed to make the package work better with SvelteKit
These changes may not be sufficient, but would be good to make nonetheless to bring support closer

@matyunya any chance you'd be able to take a look at this PR?


SEARCH & FILTER

[x]  search and filter functionality to help users find books based on criteria like genre

done


Remove Chinese localisation from Rancher

Internal reference: SURE-8729
We've lost a lot of the contributors we've had in the past to help with translating the Rancher UI to Chinese.
As we figure out how to introduce new locales that are well-maintained through delivery as UI extensions, we should remove the current Chinese locale from Rancher. We have translations existing as files throughout our codebase and a toggle in the UI as a preference.
However, to ensure some level of continuity, we could create a new repo with the existing Chinese locale as a language pack, just clearly marked as not Rancher official or supported. This way, people could use it as is or help maintain it since a lot of work went into this that the community would find helpful to preserve.

We should ensure that we handle the UX when there's only a single localisation, and also the case where uses have selected a localisation that is then removed (i.e. support upgrade scenario when users have selected chinese)


Tests/health

Cleaned up controller code – there were some bad queries in there. Created tests.

Codecov Report

Merging #425 into master will decrease coverage by 58.93%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master     #425       +/-   ##
===========================================
- Coverage   79.33%   20.39%   -58.94%
===========================================
  Files          77       77
  Lines        1684     1721       +37
===========================================
- Hits         1336      351      -985
- Misses        348     1370     +1022

Impacted Files
Coverage Δ

api/src/controllers/health.js
62.5% <100%> (+41.66%)
:arrow_up:

api/src/parsers/article.js
0% <0%> (-100%)
:arrow_down:

api/src/utils/random.js
0% <0%> (-100%)
:arrow_down:

api/src/parsers/discovery.js
0% <0%> (-100%)
:arrow_down:

api/src/parsers/detect-type.js
0% <0%> (-100%)
:arrow_down:

api/src/parsers/detect-language.js
0% <0%> (-94.74%)
:arrow_down:

api/src/controllers/featured.js
6.66% <0%> (-93.34%)
:arrow_down:

api/src/utils/personalization/index.js
0% <0%> (-92%)
:arrow_down:

api/src/controllers/auth.js
7.01% <0%> (-91.23%)
:arrow_down:

api/src/controllers/feed.js
3.44% <0%> (-89.66%)
:arrow_down:

... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155ddec...318ef00. Read the comment docs.


[Feature Request] options for texture upscaling, Gouraud/Phong shading, and Tessellation.

I was wondering about the possibility to include options for:

Texture upscaling filters (JINC2 and xBRZ+deposterization).

Gouraud or Phong shading (to make those low-poly elements look a little less point).

Tessellation (same as above, but probably much more challenging).

Personally I don't care for scale filters.  It might work okay on UI textures or fonts, but beyond that I'd rather allow loading external HD textures and let people upscale them however they want.
Per-pixel shading is theoretically possible, there's already a request for it.
If you just subdivide existing models without thinking, the game will end up looking like GTA Definitive Edition. This is a problem that would be best solved by allowing models to be loaded externally, which already kind of is a thing. Then maybe someone could port the XBLA models or something.

Regardless, advanced visual enhancements are something to consider after the base game port is completely finished.

Since this is covered by other feature requests, I'll close it.


SINGA-61 Support user defined classes

To make SINGA extensible, polymorphism is used for many classes, e.g., Layer, Updater. Users configure a type field to decide which subclass to use at run time.
E.g., the LayerProto has a type field. But this type field can only be set to built-in layer types.
This commit adds a user_type field for configuring user defined layers. E.g.,
LayerProto {
  optional string user_type = 10;
}

A helper function Layer::Create(const LayerProto&) is added to create a Layer object based on user configuration.
Similar updates are applied for other classes, namely, Param, Worker, Updater.
Driver class in declared in driver.h.
singa.h now has only include directions.

Please re-create data shards for mnist and cifar10 examples, as the protocol buffer message for Record has been changed.


Threelang  manual is not hooked in to the mdbook summary

So you can not reach it from the navigation

7264187567864389fc863109b45351d5c7a11e70


UDP buffer memory leak?

I've been experiencing some choppy audio with this otherwise excellent bot. After installing netdata I noticed what can be seen in this screenshot. The green bar shows memory used, which was capped at 4.07MB when the errors (blue graph) started showing up. The choppyness appears at the same time as the errrors. After increasing the UDP max write buffer size and restarting the bot, the memory usage resets, but starts increasing steadily. I haven't encountered any errors yet (no blue graph) and the audio seems less distorted. Is this level of buffer usage normal/intentional?
I am running version 0.0.9 of the bot on Debian 9 with OpenJDK 64-bit version 1.8.0_141.
Screenshot:

Update: The memory usage dropped to zero, only to start growing again, upon reaching about 50 MB. Testing reveals that skipping a song does not necessarily trigger this reset, though.

Please do not use OpenJDK with this bot

Switching to Oracle JDK seems to have fixed most of the stuttering, but I still see abnormally high UDP buffer memory usage. What's interesting is that it seems to only go up when someone is speaking in the same channel as the bot. It might be worth noting that I use the same machine hosting the bot as my network router, though when I tried connecting to the channel using mobile broadband on my phone I saw the same results. (memory usage goes up when someone speaks) If I mute myself, the memory usage stays on its current level, without declining. Memory usage resets to about zero when the bot leaves the channel.

Setting the buffer size limit back to 4 MB reintroduces the receive buffer errors, though all stuttering remains absent.

Further testing reveals that the stuttering is still present despite the memory not being capped off. I would like to point out again that only clients on the LAN experience stuttering, not those on the internet. This is probably related to an issue with my networking setup, rather than the bot.

I sometimes experience stuttering as well. Moving the discord server location has always fixed it.

Closing this as there have been no new developments for almost a year and it seems network/discord related (as per the latest two comments). As an aside, the JVM garbage collecting could also occasionally cause a brief stutter, but for the average user this happens extremely infrequently and is barely noticeable, so solutions to this are low priority.


update submodule automatically

Closing.  Whatever approach is ultimately taken, it won't be this one.


Tensorflow lite

Hi,
I use tensorflow lite for my camera detction but after the 8.2.0 update it doesn't work anymore because there is a native library missing which has the function nativeDoNothing for example. It looks like the ftc sdk refuses to add these libraries is there a way I can add them anyway to my build process?
Regards
flemmi

In 8.2.0 and subsequently in 9.0 we updated the TensorFlow dependencies in order to support newer models. When you say you "use TensorFlow Lite for camera detection" are you using the FTC SDK functions, or are you using additional libraries? When you create your models, are you using the FTC Machine Learning Toolchain or are you creating them using an external tool?

I am using google teachable machine and https://github.com/OutoftheBoxFTC/EasyTensorflowAPI to use it.

I'm sorry, we do not provide support for those platforms or tools. You need to file an issue with the EasyTensorflowAPI project, we cannot help you with that.


Autoload doesn't work

It seems that the on_load hook doesn't run.
I tried
mp.register_event("file-loaded", load_chapters)
which runs the function but doesn't load the chapters.

run mpv in a terminal with --msg-level=chapters=debug and post the output here

this is how I load subtitles...so maybe try mp.commandv perhaps
local sub13 = io.open(movie_path.."_tempm"..sub_ext, "r")

      for line in sub13:lines() do
        local replace_line = string.gsub(line, "XZSAWQ", ",")
            demofont_file:write(replace_line .. "\n")
                  end

  local demofont_new = (movie_path..".demofont"..sub_ext)

  mp.osd_message("Sub converted to DemoFont")
  print("Sub converted to DemoFont")
  mp.commandv('sub-add', demofont_new)
  os.remove(demofont_new)

[chapters] Loading lua script C:\Users\User\AppData\Roaming/mpv/scripts/chapters.lua...
[chapters] loading mp.defaults
[chapters] loading file C:\Users\User\AppData\Roaming/mpv/scripts/chapters.lua
[chapters] reading options for chapters
[chapters] Opened config file script-opts/chapters.conf.
[chapters] options: {"pause_on_input" = false, "autoload" = true, "autosave" = false, "global_chapters" = false, "chapters_dir" = "C:\Users\User\AppData\Roaming/mpv/chapters", "ask_for_title" = false, "placeholder_title" = "", "hash" = false}
● Video  --vid=1  (h264 1280x720 30 fps) [default]
● Audio  --aid=1  (aac 2ch 44100 Hz 128 kbps) [default]
AO: [wasapi] 48000Hz stereo 2ch float
VO: [gpu] 1280x720 yuv420p
AV: 00:00:16 / 01:03:09 (0%) A-V:  0.000
Exiting... (Quit)
[chapters] Exiting..

I rolled back from mpv v0.39.0-325-gd66ed2d8 to mpv v0.39.0-221-gc5561b8e and it's working again
[chapters] Loading lua script C:\Users\User\AppData\Roaming/mpv/scripts/chapters.lua...
[chapters] loading mp.defaults
[chapters] loading file C:\Users\User\AppData\Roaming/mpv/scripts/chapters.lua
[chapters] reading options for chapters
[chapters] Opened config file script-opts/chapters.conf.
[chapters] options: {"pause_on_input" = false, "autoload" = true, "autosave" = false, "global_chapters" = false, "chapters_dir" = "C:\Users\User\AppData\Roaming/mpv/chapters", "ask_for_title" = false, "placeholder_title" = "", "hash" = false}
[chapters] looking for: ./vid.mp4.ffmetadata
[chapters] found in the local directory, loading..
● Video  --vid=1  (h264 1280x720 30 fps) [default]
● Audio  --aid=1  (aac 2ch 44100 Hz 128 kbps) [default]
AO: [wasapi] 48000Hz stereo 2ch float
VO: [gpu] 1280x720 yuv420p
AV: 00:00:14 / 01:03:09 (0%) A-V:  0.000
Exiting... (Quit)

I can confirm that it's not working in that build, at least on Windows. For now I'll assume that it's a bug in mpv, but maybe they changed some API and the script will need adjustments - we'll see.

should be fixed, let me know if it's still not working


chore(package.json): build script supports cross-platform

Description:
This PR updates npm build script to use shx, provides portable cross-platform shell commands.
There are still some remaining issues (i.e, glob) though, this will unblock most frequent daily-scripts for windows users.
Related issue (if exists):
closes #1601

I'll check this in around late today if there's other suggestions around.

Merged with ace2c28.