TmuxNavigateLeft is not working on my computer

Since I installed the tmux navigator plugin, the movement to the left is not working, all the others work correctly and I already verified that it is not collapsing with another mapping, so I have not found a solution.
I use NeoVim on Kali linux
┌──(user32㉿kali)-[~/.config/nvim]
└─$ nvim -v
NVIM v0.8.0-1210-gd367ed9b2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by runner@fv-az505-656

Features: +acl +iconv +tui
See ":help feature-compile"

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/share/nvim"

Run :checkhealth for more info

┌──(user32㉿kali)-[~/.config/nvim]
└─$ tmux -V
tmux 3.3a

This is my repo of configs

Sorry but I'm not expert enough to see an obvious solution, I would appreciate some help 😉

Hmm, hard to say based on the information provided, but since it's just moving to the left that doesn't work, my guess is it is a conflict in the key bindings. I know you mentioned that "I already verified that it is not collapsing with another mapping", but just to confirm, there are mappings at both the tmux and Vim level, and the conflict can occur at both levels.
Did you run through the steps in the troubleshooting guide by any chance? Specifically the note in this section. Likewise, can you check the output of tmux list-keys -T root | grep 'C-h' to confirm the tmux mapping is set as expected?

I just helped a coworker get over this and the same solution might work for you.
She had set up a new machine and realized that she hadn't cloned TPM and set up
the tmux plugins on the new machine. This led to having the vim plugin installed
which would send the right commands to move but in the tmux side of things the
bingings weren't set up because the tpm plugin was missing.

Hmm, hard to say based on the information provided, but since it's just moving to the left that doesn't work, my guess is it is a conflict in the key bindings. I know you mentioned that "I already verified that it is not collapsing with another mapping", but just to confirm, there are mappings at both the tmux and Vim level, and the conflict can occur at both levels.
Did you run through the steps in the troubleshooting guide by any chance? Specifically the note in this section. Likewise, can you check the output of tmux list-keys -T root | grep 'C-h' to confirm the tmux mapping is set as expected?

I also can't get vim-tmux-navigator's keymaps to work...
The output of tmux list-keys -T root | grep 'C-h' on my computer (Alacritty, Ubuntu installed via vmware on Windows 11) is the following:
bind-key    -T copy-mode-vi C-h                  select-pane -L
bind-key    -T root         C-h                  if-shell "ps -o state= -o comm= -t '#{pane_tty}'     | grep -iqE '^[^TXZ ]+ +(\\S+\\/)?g?(view|l?n?vim?x?)(diff)?$'" "send-keys C-h" "select-pane -L"

May ask if this is correct?


readme: fix az instructions for latest release

Hi @colemickens, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Cole Mickens). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;


Clusterpedia robot for clusterpedia repository

What would you like to be added?
Add clusterpedia robot to help to review code and pull request
Why is this needed?
Maintainer will merge the pull request after the pipeline succeed manually although maintainers and reviewers review and approve some small pull request at very early time.
I think we can introduce robot for improving efficiency in code review and merge request

@Iceber

Yes, it is necessary. My plan is to use https://github.com/wzshiming/gh-ci-bot to implement a simple robot, what do you think?
This is a example repo: https://github.com/wzshiming/gh-ci-bot-playground

But I'm a little worried about security, because we'll be handing over a very privileged token to the action to do something.

https://github.com/wzshiming/gh-ci-bot

It seems lack of lgtm command.

But I'm a little worried about security, because we'll be handing over a very privileged token to the action to do something.

In other words . The maintainers and reviewers invited in the future can not write the repository directly. Maybe it is more safe .

@wzshiming https://github.com/wzshiming/gh-ci-bot is missing a common command lgtm —— add an lgtm lable.
Although /label-lgtm can also be used, it seems that /lgtm is more commonly used.

The maintainers and reviewers invited in the future can not write the repository directly. Maybe it is more safe .

Yes, we can consider doing this.
There is a security issue, the gh-ci-botscripts need to be pulled from the  https://github.com/wzshiming/gh-ci-bot  to be executed (detail), and this can cause more serious problems if scripts in the repository are replaced with malicious scripts due to some problems.
Can we fork to clusterpedia-io, which is a repository that only the maintainer has write access to?

clusterpedia

Sounds good.
Actually, In our personal gitlab repo, we also have a project named gitlab-bot in our private group to do this.

Your gitlab-ci seems to work fine, would you like to migrate/contribute to clusterpedia-io? We can simply compare the two tools and choose the easiest and most convenient one.

Your gitlab-bot seems to work fine, would you like to migrate/contribute to clusterpedia-io? We can simply compare the two tools and choose the easiest and most convenient one.

I'd like to
But the gitlab open api is different with github
and
our bot is looks too simply to satisfy clusterpedia's needs
I will try to find some way in my spare time.

I will try to find some way in my spare time.

This issue is not particularly pressing and we can have more discussions :smile:

@wzshiming https://github.com/wzshiming/gh-ci-bot#gh-ci-bot looks like it needs to be updated:joy:.

Updated 😃

ping @Iceber @wzshiming  when to apply the bot to clusterpedia

@wuyingjun-lucky Thank you for the follow up, We will soon add robot.
@wzshiming  will use https://github.com/wzshiming/gh-ci-bot to support the robot, thanks to the help of @wzshiming 🌹

There is a security issue, the gh-ci-botscripts need to be pulled from the https://github.com/wzshiming/gh-ci-bot to be executed (detail), and this can cause more serious problems if scripts in the repository are replaced with malicious scripts due to some problems.
Can we fork to clusterpedia-io, which is a repository that only the maintainer has write access to?

@wzshiming gh-ci-bot has been forked to https://github.com/clusterpedia-io/gh-ci-bot.

https://github.com/clusterpedia-io/clusterpedia/pull/294 adds commands for lable and cc, assign,etc...
We currently do not use automatic merging due to the small number of approvers.

#294 adds commands for lable and cc, assign,etc...
We currently do not use automatic merging due to the small number of approvers.

Why not ?
If I just modify an error words.  I think you do not need to merge it until the pipeline succeed.  It can save your time.

Why not ?
If I just modify an error words. I think you do not need to merge it until the pipeline succeed. It can save your time.

Auto-merge is good for multiple reviewers and approvers to work together, but right now I'm the only approver, and the gh-ci-bot doesn't support auto-merge yet :joy:

Why not ?
If I just modify an error words. I think you do not need to merge it until the pipeline succeed. It can save your time.

Auto-merge is good for multiple reviewers and approvers to work together, but right now I'm the only approver, and the gh-ci-bot doesn't support auto-merge yet 😂

All right. Label  merge can not auto-merge.  I think auto-merge can save your time.

https://github.com/wzshiming/gh-ci-bot/issues/14
I create an issue for this auto-merge, and I will take the time to do it later

Currently I am the only reviewer, so I will review a pr several times before merging it, currently it feels better for me to merge it manually.
In the future, when there are more approvers, we can switch to automatic merging


Codecov

Current coverage is 37.94%

Branch #1666 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.


Purge CSS Doc Suggestion (IE9 Limitation)

I just listened to the Full Stack Radio episode where you guys mentioned how many classes can be generated in Tailwind and how Purge CSS would be a good idea.
While recommending Purge CSS in the docs would be good, I figured you could use a compelling reason for why it should be done other than file size.
In Internet Explorer 9, it will stop loading CSS after 4095 selectors, this results in a half styled page. This would be an issue that could easily happen in Tailwind due to the dynamic amount of CSS classes that could be generated.
https://blogs.msdn.microsoft.com/ieinternals/2011/05/14/stylesheet-limits-in-internet-explorer/
Great work guys, this project has been great to watch and it is really good to use, looking forward to see where this project goes. 👌🏻

Added a little bit of documentation about this yesterday 👍
http://tailwind.dev/docs/controlling-file-size#removing-unused-css-with-purgecss
Hoping to expand on it further eventually because there's quite a few gotchas to be aware of that affect how you author your templates, but I think it's a good start at least.


fix typo

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:
fix typo
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm


Update icon URLs to not use relative paths

This PR updates icon URLs to not use relative paths. Maybe could use regression tests, but probably not a huge deal.

Nice, just learned some new things by reviewing! 👍


ci: Publish lerna packages on push to master

This PR adds a Github Action for publishing Lerna packages to NPM. With the proposed Lerna configuration the publishing pipeline will determine version bumps and generate CHANGELOG.md files per package using the conventionalcommits specification.
Note that this pipeline only supports publishing packages to a single account. With the intention to split near-api-js in to multiple scoped packages, which will need to published to a different account, we'll need to update this pipeline to support publishing to multiple accounts.
Closes: #753

Superseded by https://github.com/near/near-api-js/pull/973

Superseded by https://github.com/near/near-api-js/pull/973


Find ROCm on Fedora

ROCm is packaged natively on Fedora. It's install location do not match the AMD release.
So add some Fedora specific logic to find the ROCm version and use rocminfo when attempts to use the AMD release fail.

@trixirt - can you please complete the CLA?

@microsoft-github-policy-service agree

Sorry for delay.
I took all the s2s formatting from the precommit checker as-is.

I have dropped the tests.

I have dropped the tests.

Understood, I'm still trying to confirm more about the copyright issue, but haven't made much progress yet.  I appreciate the changes you've contributed though, and I'll work on getting this merged this week.


Drag Drop files and folders to get the path does not work on Windows 10

I want to drag files or folders from the explorer into hyper to get the path, but that does not work. My cursor turns into a forbidden cursor and nothing happens.
I expect it to work like on the Mac, when you drag sth into the terminal, the path is copied into the terminal.

I think this is a regression or it has never worked on windows, see #110 and the fix in #559

@albinekb this would be a great feature. Any idea how one could add it?

This also does not work on macOS Mojave 😢

@misolori
Me too. is it difficult to fix?

This is fixed in v3.1.0-canary.4.


[style] Ripple strange behaviour

Problem description
After click ripple block goes transparent but in the end of animation it become fully visible.

Versions

Material-UI: next
React: 15.4.2
Browser: Chrome 56.0.2924.87 (64-bit)

This seems to happen with all Icon Buttons on the next branch. On Chrome at least, this doesn't happen on Firefox 51.0.1 (64-bit)

Problem lies with centerRipple somehow IconButton.
When center is set, TouchRipple will (correctly) compute rippleSize (https://github.com/callemall/material-ui/blob/next/src/Ripple/TouchRipple.js#L132) to be width of element (48px) and this causes that glitch. Settings it to 49, 47, 50, 46 will fix things. Even if IconButton size is 49 instead of 48, it is fixed.
I have absolutely no idea what is happening, but seems to me that ensuring that ripple has always odd size is the quickest fix. Is anybody on Earth abtle to notice 1px misplaced ripple? :D

Weird, on my other machine (also Ubuntu with Chrome Version 56.0.2924.87 (64-bit) and React 15.4.2) it doesn't happen anymore.

Any updates? Couldn't figure this out myself...

I have spent quite some time digging into the issue. The even hack pointed out by @ArcanisCz works amazingly well.
@kybarg I have seen your PR, I have made another to go a bit deeper into the issue.


docs: 📝 Update README.md to include mfa_token information

Added to the README.md file information about how to use the mfa_method='soft-token' method

Fixes #258
While having a similar issue to #258, I noticed that the README.md doesn't include information about how you need to specify the mfa_token when using mfa_method='soft-token'. This PR resolves that.
While I'm not sure if this resolves the original post at the top of #258, it resolves the subsequent discussion. Because the original author hasn't responded, I would move to count this PR to close #258.

Thanks, I like it! Would you be willing to add a little paragraph that explains how to set it up and recommended best practices / arguments? Perhaps this could be done by updating the command-line instructions, or adding a paragraph above them. I think that while this is a great improvement, a little plain english explanation will be even easier to find and point people to :)

@mrooney I added a section and then reference it in the python api description. Let me know what you think.


Contribute

NOT A BUG: will be deleted
Hello,
I would like to contribute to this project. I would like to know if it was possible, and if there was
a GUIDELINE in force or a way to discuss it.

Thank you for your interest! Contributions are of course possible, although I do not have much experience in working on team project — but that should not be much of a problem. I added a basic contribution guideline file. What kind of contributions do you have in mind?

Sorry for the late response. I would like to learn C#/OpenGL with a project that would motivate me but I think I am more of a weight for you given your skills.
Despite everything, I would like to know if it was possible to discuss the project. A discord would be great.

I created a discord server here: https://discord.gg/eMhfbju


Build for OSX

Now that https://github.com/conda-forge/allennlp-feedstock/pull/19 is in.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Novalidate can't be overridden (SolidJS)

Form component sets novalidate="true" by default and can't be overridden. I want to create progressively enhanced forms with native HTML validation, but it can't be done this way.

Modular forms currently only support progressively enhanced forms in Qwik. For SolidJS we are waiting for changes in SolidStart so that we can implement it with a good DX.
What advantage do you have with Modulars Forms if you use HTML validation? If it makes sense, I can modify the Form component to allow the attribute to be overridden.

I understand. That makes sense. I will try to improve that tomorrow.

Apart from that, do you have any other ideas for improving the API? Will be working on Modular Forms next week to get to v1 in the next few months.

Apart from that, do you have any other ideas for improving the API? Will be working on Modular Forms next week to get to v1 in the next few months.

I think the API is very well written. it's intuitive and robust. I had only a few issues that you quickly fixed or helped me with.
One thing that I quite often came across was "duplicating" of validation and validation attributes. Let's see example below.
<Field
	name="Name"
	validate={[
		required("Please enter your name"),
		minLength(2, "Name should be at least 2 characters long"),
		maxLength(50, "Name should be at most 50 characters long"),
	]}
	>
	{(field, props) => (
		<input
			{...props}
			required
			minLength={2}
			maxLength={50}
		/>
	)}
</Field>

It might be useful to automatically populate props with minLength, maxLength and required attributes if matching counterpart in validate prop are passed. However, it might be up to discussion because even with novalidate="true" the maxLength constraints the maximum number of characters input can have so it might break some very exotic usage of inputs. On the other hand, the developer can split the props and don't pass it to the input if it breaks their usage.
There would be two benefits:

You don't "duplicate" the validation logic.
It improves the accessibility of most forms without the need for some developer intervention.

Another thing that caught my eye is that the Form component is rendered with of attribute with value [object Object] which doesn't seem correct or even useful, so maybe it's accidentally passed?

Lastly, it's very common to create ids for inputs and error elements to associate them with correct labels and error texts. It might be helpful to add some string identification of the form that can be used to distinguish the same inputs between different forms (on the same page) so you can reduce the change of id collision.

Thanks a lot for your feedback! I fixed the noValidate problem. I'll look at the other things on Monday.

I tried the fix and realized I misunderstood how novalidate works. The novalidate is a boolean attribute. Based on the HTML spec, to represent a "true" value, the attribute must be present (as it is by default) and if the value should be false then the attribute must be omitted altogether.
The attribute is present by default, so we need to pass null to the form to remove it.
<Form onSubmit={onSubmit} noValidate={null}>
...
</Form>

However, TypeScript accepts boolean so it throws a type error.
Type null is not assignable to type boolean.

Won't the attribute be removed if you set the value to false?

Not quite, there are attributes that needs false to be on the element (aria-expanded for example). Maybe it's browser specific or even framework SSR specific.

Okay, I think I finally understand what's going on. A similar issue is with autoFocus in the field props.
There is a difference between novalidate and noValidate, autofocus and autoFocus.
novalidate, autofocus (lowercase) are valid HTML attributes, but noValidate and autoFocus aren't, they are just "convenient" wrappers for developers that should map to native HTML attributes. However, for some reason Solid (at least with conjunction with Astro) doesn't map it and renders it as is, hence in the HTML is autoFocus="false" which translates for HTML as autofocus=""
Solution is to rename noValidate to novalidate and autoFocus to autofocus.
EDIT: Maybe the camelCase props aren't even valid at all, in Solid playground it throws a type error.

@fabian-hiller I created a PR to fix this (changed it only for the SolidJS package as I don't know if other libraries suffer by this). It's just a rename, and it seems to be fixing all the issues above.

The issue should be fixed in the new version.

I think the API is very well written. it's intuitive and robust. I had only a few issues that you quickly fixed or helped me with.

@susickypavel thank you for your feedback! Can you create an issue for each suggestion? Especially the of property I would like to fix in a timely manner. Thank you very much for the hint.

Lastly, it's very common to create ids...

Can you also create a issue for this improvement. I find this interesting and an implementation also seems quite simple.


[Android] Q1 2024 - Misc Bugs / Cleanup Tasks

Quarterly ticket (for Q1 2024) to group Android tickets as an epic label.
This is a way to organize misc bugs and cleanup tasks that have otherwise no epic / home to associate them with and thus aren't represented on the roadmap.
### Tasks
- [ ] https://github.com/openedx/openedx-app-android/issues/175
- [ ] https://github.com/openedx/openedx-app-android/issues/173
- [ ] https://github.com/openedx/openedx-app-android/issues/186
- [ ] https://github.com/openedx/openedx-app-android/issues/185
- [ ] https://github.com/openedx/openedx-app-android/issues/198
- [ ] https://github.com/openedx/openedx-app-android/issues/199
- [ ] https://github.com/openedx/openedx-app-android/issues/200

Could someone add #138  and #139  to this, if planned for Q1? Removed these from Q4 epic

I also would like to link #153 , #161 , #165  since they were unlinked from the Q4 epic, but I still don't understand why the Add Item to the tasklists object isn't open / available to everyone with write access :/

@marcotuts, I added all tasks(bugs) from the Q4 epic to Q1 epic.

Can someone with edit access to this remove the open tickets linked from this? I have added them all into the Q2 epic.


Make bin-* packages open-source and unify them in one package like GNU's Binutils

Is your feature request related to a problem? Please describe.
Right now we can`t contribute to the making of this programs and having every program in a different package is useless.
Describe the solution you'd like
Have a repository in the NodeOS organizations like binutils with all the programs in the bin-* packages with a unified package named nodeos-binutils
Describe alternatives you've considered
Having a repository for every bin-* package, but this would be very tedious.

NodeOS follows KISS principle and a minimal approach, so one package for each bin/library is the way to go. If you want, you can make a package having all of the other binary packages as dependencies. Can you describe in more detail what are you trying to achieve?


DOC: doc shim for eig normalization

this is a documentation shim to at least temporarily avoid the confusion in gh-11550, as discussed in the comments at gh-15340

perhaps the clearer wording will motivate folks to come to a consensus about whether a behavior change is justified at some point in the future, but that almost certainly won't be decided before branching in early December

[skip cirrus] [skip actions]

Alright, it is a two line doc change and CI is passing, so release manager discretion on this one I think, so I can bump the milestone on the matching PR for now.


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/89386

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/89765

Triggering TagBot for merged registry pull request
This extra notification is being sent because I expected a tag to exist by now, but it doesn't.
You may want to check your TagBot configuration to ensure that it's running, and if it is, check the logs to make sure that there are no errors.


Add home nominal and clip plans to avoid numerical precision error when converting float to double

Added an option to compute home nominal plans without moving the arms.

Such function used to exist in the past.

Added clipping of ik poses and ik trajecotries to joint limits that take into account 32bit floating point rounding errors.

The plan gets sent via LCM as float (32bit) which reduces the accuracy. This causes problems when the joints limits are checked in the controller against a joint limit at 64bit double accuracy. The difference is small (1e-6) but it causes the joint limit checks to fail. This fix reduces the joint limits by 1e-6 and clips the plans to this joint limit. This fix could exist in the translator or the controller as well. I put it into the ik planner so that the plan can be visualized.

hey if it's not too much trouble you might want to open a separate PR for the clipping than for the home plan.  I think we can accept the change for the home plan right away, but for clipping i think we should discuss it a bit.
questions:

perhaps clipping should not be enabled by default, it is a slight layer of complexity/surprise that might not be desired by all users

i can see arguments for handling the clipping at a different level, but also see good reasons to handle it here in the application layer.  just want to make sure we are handling it in the application layer because that is best, and not because that is easiest/quickest.

do you mind if i nitpick on your python style? I'd like to have that cleaned up before merging.  Particularly, in some places you are missing spaces after commas, spaces around equal signs, and used 2 instead of 4 spaces for indents.

Splitting this into separate pull requests


add a new row in aggrid on click of button outside the grid

I have a requirement wherein I have to add a new row with some prefilled data in few columns and few columns will be editable, in a already existing grid. The button will not inside grid, it will be out of the grid (streamlit button). Any pointer for the requirement?

For anyone still serching the issue, try this , just adapt the new_row to your actual DataFrame
def add_new_row(selected_row_index=None):
    new_row = pd.DataFrame(columns =st.session_state.df.columns, index = [0], data =[[None, None,None,None,None, pd.NaT,pd.NaT ]])

    # If a row is selected, insert new row below the selected one
    if selected_row_index is not None:
        top = st.session_state.df.iloc[:selected_row_index+1]
        bottom = st.session_state.df.iloc[selected_row_index+1:]
        st.session_state.df = pd.concat([top, new_row, bottom], ignore_index=True)
    else:
        # Add the new row to the bottom if no row is selected
        st.session_state.df = pd.concat([st.session_state.df, new_row], ignore_index=True)

def delete_rows(selected_row_index):
    # If a row is selected, insert new row below the selected one
    st.session_state.df.drop(index = st.session_state.df.index[selected_row_index], axis = 0, inplace=True, errors = 'ignore')


Output error

Hi David,
I encounter some problems while running DNNV with Neurify.
My model:

Initial property (property 1)
from dnnv.properties import *
import numpy as np
N = Network("N")

Forall(x, Implies(And((x[0, 0] - x[0, 1] > 0), (x[0, 0] +x[0, 1] <= 0)), N(x)[0, 0] > N(x)[0, 1]))

Property 2
from dnnv.properties import *
import numpy as np
N = Network("N")

Forall(x, Implies(And((x[0, 0] - x[0, 1] > 0), (x[0, 0] +x[0, 1] <= 0)), N(x)[0, 0] <= N(x)[0, 1]))

As you can see, the only difference is in the second half of the implication(N(x)[0, 0] > N(x)[0, 1] vs  (x)[0, 0] <= N(x)[0, 1]); they are opposite to each other. However, with both properties files, I still receive unsat for both of them. If I am not mistaken, unsat means that the property is proven. The only property that is true is the first one (property 1). Could you take a look at it?
Thank you very much. Have a great day.
Best regards,
Max Nguyen

I believe the result is correct. In both cases, the antecedent of the implication is false, which means the property evaluates to true for both properties. For property 1 the antecedent is (x0 > x1 and x0 <= x1) which cannot be true for any values of x0 and x1; x0 cannot be both less than x1 and greater than or equal to x1. Similarly, for property 2, the antecedent is (x0 <= x1 and x0 > x1), which also cannot be satisfied for the same reason.

I believe the result is correct. In both cases, the antecedent of the implication is false, which means the property evaluates to true for both properties. For property 1 the antecedent is (x0 > x1 and x0 <= x1) which cannot be true for any values of x0 and x1; x0 cannot be both less than x1 and greater than or equal to x1. Similarly, for property 2, the antecedent is (x0 <= x1 and x0 > x1), which also cannot be satisfied for the same reason.

@dlshriver, I think there is a misunderstandings. My antecedent is (x0 > x1 and x0 <= -x1), not (x0 > x1 and x0 <= x1). One example is (x0 = 5, x1 = -6). Then 5 > -6 and 5 <= -(-6) = 6.

@dlshriver, I think there is a misunderstandings. My antecedent is (x0 > x1 and x0 <= -x1), not (x0 > x1 and x0 <= x1). One example is (x0 = 5, x1 = -6). Then 5 > -6 and 5 <= -(-6) = 6.

I'm sorry, you are correct. I must have misread the antecedents. I still believe the results may be correct, since it looks like the two antecedents are different. The first is (x0 > x1 and x0 <= -x1), but the second is (x0 <= x1 and x0 > -x1), so it is possible for both properties to hold since they cover different regions of the input space.

I am sorry. I had a typo on my second property, so that was why the antecedent was different. I have corrected them. Could you take a look again?

I think I've figured this one out. The verifiers don't seem to like unbounded input domains. x0 does not have an upper or lower bound, and x1 only has an upper bound. This also causes issues with verifiers other than neurify (I encountered similar issues with planet and nnenum). I'm not sure of an ideal solution for this problem, as it seems to be a requirement of the underlying verifiers, but I will try to detect this in DNNV and output a warning or exception. One way to deal with this right now is to add lower and upper bounds to the input variables in your precondition. For example, you can add (-1e6 < x < 1e6) to the And expression and it should fix the issue for now. The bounds can be arbitrarily large, but must be finite.

Hello,
I am interested in your tool to check neural networks. last year I used ERAN and now I find that your tool combines several methods and it is interesting. unfortunately, now the installation is a bit complicated because we will have to install the tools independently. I have a problem of use. often I will get an error message as the following picture shows. only reluplex which works without error. could you help me ?

Thank you Best regards.

Hi @khedher1984,
Thank you for your interest in DNNV. Is the issue that your having related to this current issue or is it separate?
For your problem, I will need some more information before I can make any suggestions. How are you running DNNV? What network and property are you trying to check? Also, what platform are you running on and what is the full output of trying to run DNNV?

I will try to detect this in DNNV and output a warning or exception.

Finally closing this issue. With commit 179941edbaa18e2fa14c58f310f47feec8bd3b02 we now detect unbounded inputs and report an error.


Add james proxy

Hey!
Thank you for maintaining this awesome list of applications and tools.
Cheers

@davidspinat thx!


Revert "Revert "Fix nczarr-experimental: improve build support, disengage hdf5 vs netcdf4 flags, and find AWS libraries""

Reverting this reversion in a branch to observe something about github behavior.

Ok, the issue appears to be in ncgen; when running
$ ncgen  -b -4 -N ref_tst_nans -o file://test.nzf#mode=nczarr,nzf ../../ncdump/cdl/ref_tst_nans.cdl

on OSX, the variable attributes created are fvar:att = Infinity, NaNf, Infinityf ; and dvar:att = Infinity, NaN, Infinity ;.
On Linux, we see the expected values of fvar:att = -Infinity, Nanf, Infinityf ; and dvar:att = -Infinity, Nan, Infinity ; are generated.
Invoking ncdump on the file in OSX returns the proper output if the file was generated on linux, which leads me to believe that the attribute values are being encoded incorrectly on OSX.  Note that the data values are properly -Infinity even when generated on OSX.

Testing with ncgenb -b -4 -N ref_tst_nans -o tst_nc4.nc ../../ncdump/cdl/ref_tst_nans.cdl generates the expected attribute values.  Any ideas off the top of your head as I continue to diagnose this, @DennisHeimbigner ?

Examining the test.nzf directory structure, the .zattrs file associated with the variables does contain the json [Infinity,NaN,Infinity] instead of the expected [-Infinity,NaN,Infinity].  Sorting through to see if I can find where this file is being written.

Do not hold be to it, but, I ran into this error a while back.
The file is created by ncgen in tst_nan,sh(?)
The problem as I recall was the ncgen lexer was not properly recognizing
the value of infinity.
The thing to do is to run h5dump (I think its an NC4 file) and see what
value is actually in  the generated file. If it is netcdf-3, then maybe
ncvalidator can show it, or use an old version of ncdump.

It is probable that the problem is the handling of infinity in the zjson file.

The conversions occur in libnczarr/zcvt.c:
One possibility is near line 299

case NC_DOUBLE: {
snprintf(s,sizeof(s),"%lg",zcvt.float64v); /* handles NAN? */
} break;
Note the comment; perhaps this snprintf does not handle -Infinity on OSX?

Nope, that's not it:
#include <math.h>
#include <stdio.h>

int main(int argc, const char* argv[])
{
    char buf[256];
    double val = -INFINITY;

    snprintf(buf, sizeof(buf), "%lg", val);
    printf("%s\n", buf);

    return 0;
}

❯ ./a.out
-inf

(It felt good for just a couple minutes to write some C.)

I think I've found the issue.  On OSX (and according to man isinf on linux, any system using glibc 2.01 and earlier), isinf() returns 1 if the argument is Inf or -Inf.  So my guess is that the check for isinf(d) < 0 at zcvt.c:359 needs to be modified somewhat to use the fpclassify() macro.  I'll make that change and see what happens.

On closer reading of fpclassify(), it doesn't offer a macro for positive or negative infinity.  But, I still think this is where the issue is, so taking a closer look here.

Checking for isinf(d) and whether d is < or > than 0 has done the trick on OSX.  Let me test that this didn't break things on linux.

Ok, I've pushed in a fix with this, everything appears to be working on OSX and Linux and Windows.  Thanks @DennisHeimbigner I'll clear this out and then go through the backlog.  Thanks for bearing with me!

So because I was curious and had to know, apparently by the C99 spec isinf(x) only has to return non-zero if x is pos or neg  infinity. It's not required to indicate which:

Interesting; the original of this code in dap2/dap4 is pretty old at this point.
That is probably why it was the way it was. I will have to look at libdap2
and libdap4 to make sure they do not fail in the same way.


Interaction with ClickDetectors

What happened to the interaction with ClickDetectors when the Trigger is pressed? Did it get moved to a new key, has it been scrapped?
Edit: Version 2.1.0

ClickDetectors requires 2 things:

The events need to be abled through Nexus VR Core, which is automatically set up as part of Nexus VR Character Model: https://thenexusavenger.github.io/Nexus-VR-Core/usage/clickdetectors/
The events need to be connected on the client, not server.

If both of those conditions are met, you aim at the parts and use the trigger of the pointing hand to activate it. The reason this doesn't happen automatically is Roblox does not support ClickDetectors in VR natively and I can't manually call the events from inside Lua code.


Add initial Trace API plugin documentation to nodeos

Change Description

Resolves #8808
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[x] Documentation Additions

Docs for #8802


werift library has high severity issue due to 3rd party package

The source uses the ip library which has known high severity issues with no current fix in place by the package maintainers.  see https://github.com/indutny/node-ip/issues/150
This needs to be addressed here, but finding alternate replacement library or code around the requirement

that is a nonsense issue and can be ignored. there's been a lot of discussion about this elsewhere.

The project is maintained. It's also complete. ip parsing is a solved problem.
https://socket.dev/blog/node-ip-maintainer-restores-github-repo-after-archiving-due-to-overblown-cve-rating

https://github.com/github/advisory-database/pull/4619
Veery much unmaintained by the various comments and threads around. The current high-serv has been raised due to ip v2.0.1 NOT resolving the issue


mediaman document list is not showing draft-ietf-mediaman-haptics

Describe the issue
The -haptics draft is not showing in the document list - despite the document management page showing that the patterns should detect 3 drafts and having tried to manually add it, it's not showing - only -toplevel and -suffixes show.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

FWIW, it shows up in my local dev instance, which is running the current tip of main. So maybe this is fixed already?

The page with the bug says "Version 9.1.0 (main - 9579f61)"

The draft is not showing because it has been marked IESG state Dead in the production database. The History shows this happened likely as a side-effect of it being in AD is watching and then expiring. I'll contact the AD to have the IESG state adjusted.

I restored the AD is Watching state -  Murray can adjust it if needed when he's available next.


Add EnumType by default for PHP >= 8.1

Closes #281

Fixed there https://github.com/temporalio/sdk-php/pull/284
@zlodes hi! What about testing for enums without attributes in your project? :)

@roxblnfk hi! Thanks!
Now it works great w/o #Marshal attributes! 🚀
Marshaller class seems to be a service (singleton).
I'll think about an ability to extend available types with custom ones (like DecimalType from my example`).

Thanks.
Let me know if there is a legal way to add custom type.
If it is impossible then we will improve that.


lib.es6.d.ts error in ArrayConstructor interface

This interface contains:
isArray(arg: any): arg is Array;
but I think it should be:
isArray(arg: any): boolean;
It doesn't compile as it is.

It sounds like you're pulling down lib.es6.d.ts from source while trying to compile with a released compiler version.
The checked-in copy of that file can only be built by a sufficiently up-to-date compiler from master. The new feature (functions that return arg is type) is called "type predicates".

You are correct that I pulled down TypeScript from source. I built that and am using bin/tsc to compile. I see lib.es6.d.ts in both the bin and build/local directories. They are identical and use type predicates as you pointed out. I'm not sure why I can't compile it with this version of tsc.

tsc -v should verify whether you're actually running the version you think you're running and not getting bitten by unexpected PATH things or something.

tsc -v gives me "Version 1.5.0-beta"

The errors I get are:
lib.es6.d.ts(1168,28): error TS1005: ';' expected.
lib.es6.d.ts(1168,31): error TS1005: ';' expected.
lib.es6.d.ts(1168,41): error TS1005: '(' expected.
lib.es6.d.ts(1170,26): error TS1005: '(' expected.
lib.es6.d.ts(1171,1): error TS1128: Declaration or statement expected.

That is not the correct version for tsc built from master. You should be seeing "Version 1.5.3".
As of right now on commit 32a040b48765d3:

C:\github\TypeScript-master>git hash-object built\local\tsc.js

3901b042ed4b4684de3e21f8b1f1f5ab6271aa54

So sorry for the noise. Ryan, you were correct. I had previously installed TypeScript with npm and was using that version of tsc instead of the one from my git clone. I uninstalled the npm version and all is good now. Thanks!


The time table about skywalking 8.4.0 release

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question
I noticed that 8.4.0 milestone has been closed.
Do you have a time table about skywalking 8.4.0 release ?
We look forward to release of this version.
Thank.

Bug

Which version of SkyWalking, OS, and JRE?

Which company or project?

What happened?

Requirement or improvement

All official things happen in the mail list, Mail list<EMAIL_ADDRESS>Mail to<EMAIL_ADDRESS>follow the reply to subscribe the mail list.


Problem with ipsec on 1.9.2 (was working on 1.8.3)

Describe the bug
panos_ike_gateway is generating error in version 1.9.2
probably related to ike-crypto-profile
Expected behavior
it should not generate error
Current behavior
terraform apply
~
panos_ike_gateway.ike-gateway: Creating...
╷
│ Error: ipsec-prod_tf -> protocol -> ikev2 -> ike-crypto-profile '::ipsec-prod_tf' is invalid | ipsec-prod_tf -> protocol -> ikev2 -> ike-crypto-profile is invalid
│
│   with panos_ike_gateway.ike-gateway,
│   on ipsec.tf line 20, in resource "panos_ike_gateway" "ike-gateway":
│   20: resource "panos_ike_gateway" "ike-gateway" {

Possible solution
This was working in version 1.8.3
Steps to reproduce
Config used for ike crypto and ike gateway:
resource "panos_ike_crypto_profile" "ike-crypto-profile" {
    name = "ipsec-prod_tf"
    dh_groups = ["group14"]
    authentications = ["sha256"]
    encryptions = ["aes-256-cbc"]
    lifetime_value = 28800
    lifetime_type = "seconds"
    authentication_multiple = 3
}

resource "panos_ike_gateway" "ike-gateway" {
    name = "ipsec-prod_tf"
    version = "ikev2"
    peer_ip_type = "ip"
    peer_ip_value = "<IP_ADDRESS>"
    local_ip_address_type = "ip"
    local_ip_address_value = "<IP_ADDRESS>/32"
    interface = "loopback.1"
    pre_shared_key = "ThisIsNotMyPSK"
    ikev2_crypto_profile = panos_ike_crypto_profile.ike-crypto-profile.id
    enable_liveness_check = true
    liveness_check_interval = 5
}

Context
I'm using terraform to create IPsec VPN tunnel on the Palo Alto firewall.
Your Environment
PA-5250 - v.9.1.12-h3

Version used: Terraform v1.1.4, panos provider v1.9.2
Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3): GNU bash, version 5.0.17(1)-release
Operating System and version (desktop or mobile): Ubuntu 20.04.3 LTS (desktop)
Link to your project: Not public

Ah.  You're using id field instead of the name field, that's why.  The id field is never really used for anything external to the panos provider itself, you almost always want the name of another resource.
So change this line:
        ikev2_crypto_profile = panos_ike_crypto_profile.ike-crypto-profile.id

To this:
        ikev2_crypto_profile = panos_ike_crypto_profile.ike-crypto-profile.name

...and it should work again.

You are so very correct! Thanks!


Add reqresp_middleware decorator

Solves issue #335

Coverage decreased (-0.9%) to 99.065% when pulling ebf0da802b3a978f608b44cd409102933705613f on leiserfg:middleware into 167e07d2c39c6c18fc8992b838d53ccbe1a0d73c on timothycrosley:develop.

Closing this one, as the other one is opened, sorry I didn't respond earlier, unfortunately tests aren't passing on either of them which will need to be resolved.
Thanks!
~Timothy


Add Rust SDK example for batch get & batch write API

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thanks man! It is really appreciated!!


Achievements over time and Skill events charts on the skill page do not have zoom controls

Achievements over time and Skill events charts on the skill page do not have zoom controls; you can use select tool to zoom in but there is no way to zoom out without refreshing the page

note: when testing, we should make sure the controls adjust properly when changing the screen to a smaller size - I know some of the other charts with controls had issues with this that need to be addressed in this release.

:+1:


Need a way to pass messages back to the native app code

This is meant to be a discussion thread, we are already implementing a solution for this. We wanted to document the problem and potential solutions before we finalize it.
Leafy is writing a Flutter plugin to do logging specific to Google infrastructure. This plugin, unfortunately, needs authentication to work on iOS. The problem is that authentication token/object comes from a different plugin.
Normally, in native apps, this is solved by having the app code manage the flow between these two services (auth and log) once authentication is done. This can be done in Flutter too if it is managed entirely in native code. However, the proper way to do authentication is via plugins. Dart app code orchestrates the auth flow. That means I need to be able to somehow signal the native app code that the auth is done. So far, we thought of several solutions; none of which is perfect:

Create a dependency between the log and the auth plugin. Once auth is done, auth notifies the log plugin. This does not work because log plugin is Google specific while auth can be OSS.

Make auth plugin publish an event such as "authComplete" and have main app code subscribe to it. This would work but does not reflect the reality where authentication is actually orchestrated on Dart side; not native. It also feels like a one-off. What about errors? Do we also publish "authError"?

Pass a message from Dart to native app code directly. This mechanism does not exist currently and could be tricky to implement (e.g. we need this to work on any Android activity, which is the direction Flutter wants to go). This solution is interesting because we do have communication of lifecycle events from native -> dart at the moment. So it would be good to have a symmetry where dart can define its own lifecycle messages and deliver to native side.

Implement a callback plugin that can be configured by the native app code to run a function when a signal is received from Dart side. However, Flutter is moving towards a easy-to-use plugin model where main app code does not even get an instance of the plugin. Registration is done automatically.

We are currently leaning toward implementing the last solution. The idea is to do something like this:
Native app code:
onCreate() {
  AuthPlugin auth = new AuthPlugin();
  LogPlugin log = new LogPlugin();
  CallbackPlugin.setupCallback("authComplete", () -> {
     log.configureLog(auth);
  });
}

Dart code:
// When auth is complete
callbackPlugin.runCallback('authComplete');

Please comment on whether this is a workable solution. Also, please let me know if it is possible to get a hold of automatically registered plugin instances in native app code. If not, callback plugin approach would not work.

FYI @mravn-google @collinjackson

Also @tvolkert

FlutterActivity implements the PluginRegistry interface and FlutterAppDelegate implements the FlutterPluginRegistry protocol. When plugins auto-register with this registry concept, they may publish arbitrary values into the registry -- including, but not limited to, an instance of the plugin's main class.
Native app code thus easily access auto-registered plugins as needed for your third solution above, by lookup of published value by plugin ID.
However, I did not take into account the desire for plugins to lookup values published by other plugins, because we currently do not control the order of plugin registration. In your case, presumably the lookup can wait until all registration is done and an auth complete message is sent from Dart. At that point your LogPlugin should ideally look up the AuthPlugin from the registry.
But plugins are never directly given a reference to the PluginRegistry during registration. On Android, they have access to the FlutterActivity as an Activity-typed reference which can be cast to PluginRegistry. On iOS, you should be able to do cast [[UIApplication sharedApplication] delegate] to UIApplicationDelegate<FlutterPluginRegistry>*.

Just checking: the log.configureLog method really needs the full AuthPlugin, including behavior? It is not just extracting passive data from it that it could instead receive via a platform message sent by Dart to a channel known to LogPlugin upon auth completion?

Just checking: the log.configureLog method really needs the full AuthPlugin, including behavior? It is not just extracting passive data from it that it could instead receive via a platform message sent by Dart to a channel known to LogPlugin upon auth completion?

Correct. It is actually more complicated than that. Auth plugins are glue code that hide the underlying complexity of authentication objects (such as GIDSignIn). These objects are what the log plugin needs (not the auth plugin itself) and they cannot be passed back and forth via a platform message. I tried to write an adapter by using a serialized form of auth token but it proved to be too complex (have to deal with token expiration issues for instance).

In your case, presumably the lookup can wait until all registration is done and an auth complete message is sent from Dart. At that point your LogPlugin would want to look up the AuthPlugin from the registry, right?

Nearly correct. As I mentioned above, LogPlugin does not actually need the AuthPlugin itself. So I would not want the plugin to deal with the registry directly but rather expect the auth object. So the callback on the app side is likely this:
CallbackPlugin.setupCallback("authComplete", () -> {
  LogPlugin logPlugin = lookupLogPlugin();
  AuthPlugin authPlugin = lookupAuthPlugin();
  logPlugin.configureLog(authPlugin.someObject());
});

@mravn-google I got this to work for Android. A couple of questions though:
This is what I had to do to grab the plugin:
CallbackPlugin plugin = valuePublishedByPlugin("io.flutter.plugins.callback.CallbackPlugin");

I had to lookup the id used here in the generated registrar. That's not ideal since generated code might change, which in turn will break app code. Could we add a lookup by type rather than id? That's much less likely to break. What do you think?
I also had to publish the plugin explicit in register with:
public static void registerWith(Registrar registrar) {
    CallbackPlugin plugin = new CallbackPlugin();
    final MethodChannel channel = new MethodChannel(registrar.messenger(), "callback");
    channel.setMethodCallHandler(plugin);
    registrar.publish(plugin);
  }

Is this expected? I figured the generated code would publish plugins automatically. I am not sure what the publish methodology is for. Could you please clarify?

Lookup by type requires caller to be compiled against that type, giving a build dependency that can be problematic. Some plugins may wish to register only a callback like a java.util.Callable, with low coupling between plugin and client code. The string key is defined by concatenating IDs from the plugin's pubspec and they change only when/if the plugin changes. It defaults to the name of the plugin class.
Plugins are not required to publish an instance of themselves. In fact, many plugins may not even require an instance to be created at all. So the plugin registry does not insist on receiving such an instance during registration.

That's fair. I had all kinds of concerns running through my head but at the end of the day, this use case is highly specific and I would imagine relatively rare. So I am OK modifying the log and auth plugins to publish themselves.

@mravn-google proposed a better alternative to a Callback plugin. Using MethodChannel directly within the app:
const MethodChannel('callback').invokeMethod('hello_world');

new MethodChannel("callback", getFlutterView()).setMethodCallHandler(new MethodCallHandler() {
  @Override
  public void onMethodCall(MethodCall call, Result result) {
    Log.w("CallbackSampleApp", "Hello World!");
  }
});

FlutterMethodChannel* callbackChannel =
  [FlutterMethodChannel
    methodChannelWithName:@"callback"
          binaryMessenger:(FlutterViewController*) window.rootViewController];

[callbackChannel setMethodCallHandler:^(FlutterMethodCall* call, FlutterResult result) {
  NSLog(@"Hello world!");
  result(nil);
}];

@mehmetf - Regarding your last post with the better alternative solution using the MethodChannel. How is that method received on the native Android side?

@AdamSHurwitz see: https://flutter.io/platform-channels/

Thanks for sharing the documentation Mehmet!
This is a great sample for passing information from native Android/iOS to
Flutter with the battery status in the *onMethodCall() *that is called from
the Handler.
However, if you wanted to receive information from Flutter to the native
side, would you pass that info through the *MethodCall *object in
onMethodCall()? A use case would be if you make a service request in
Flutter and need to share the response on the native side to do something
custom.
On Wed, Mar 7, 2018 at 2:47 PM Mehmet Fidanboylu<EMAIL_ADDRESS>wrote:

@AdamSHurwitz https://github.com/adamshurwitz see:
https://flutter.io/platform-channels/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/10384#issuecomment-371312885,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADwXHKzKkNmShxFzkzMYpQYJyAjBKaHqks5tcGN0gaJpZM4NpxVV
.

--
ASH

@AdamSHurwitz Yes, information sent from Flutter to the native side using a MethodChannel will appear as a MethodCall object (FlutterMethodCall on iOS). See https://groups.google.com/forum/#!topic/flutter-dev/4ocpB5Do0Mk.


load voc dataset fail in windows

can't find file or directory.
i think it is caused by path join:
offical:
os.path.join('D:\datasets','VOCdevkit/VOC2012')
will get 'D:\datasets\VOCdevkit/VOC2012'
this one below will be ok:
os.path.join('D:\datasets','VOCdevkit','VOC2012')

Oh, good catch!
This should be fixed by #1641


Add dropdown component

Add dropdown component

You can find a good working solution on the official website. Just take a look at the source code.
But you're right, we also need a out-of-the-box solution for this in the main css file.

Build one and add it here - bones

Any news on this?


Made some "demos" with AIDA64.

Hue Wheel AIDA64.lua has every example-script inbuilt + the "alarm-system" I mentioned in #7.
You have to change the modes in "Hue Wheel AIDA64.lua", I didn't want to fiddle with automatic changing.
I had to replace the old HsvToRgb-function, since it didn't delivered the colors I expected.
I'm open for other ideas.

Also, another thing: I don't want to be pedantic, but before I merge, could you rename the scripts to use upper camel case? :>

Also, another thing: I don't want to be pedantic, but before I merge, could you rename the scripts to use upper camel case? :>

Not a Linux-user, eh? :D

Also, what was the problem with the HSVtoRGB function? What difference was there in then vs now?

I looked up the HSV chart on Wikipedia and the function returned other colors than on the chart. But this function returns the colors according to the chart.
Since I don't know how to convert from HSV to RGB I didn't try to fix it.

Am running Ubuntu right now! (although pure coincidence; I'm a heavy Windows user).
I'd just like to be consistent.

Alarm works independent on mode.
I made the code reusable by every different mode. So separate functions or loops aren't needed.
Also renamed the rest :D
Did you check your HsvToRgb-function?

Hi. Thanks! Sorry I haven't said anything. Working on something else but I promise I'll look into this asap.

Are you sure the reason that HSVtoRGB wasn't giving you the correct colours wasn't because you were passing hue values in the range [0, 360] rather than [0, 1]?

Not that it doesn't wrap the values, I just tested. I can see no difference between your version and the one I had, honestly.

Are you sure the reason that HSVtoRGB wasn't giving you the correct colours wasn't because you were passing hue values in the range [0, 360] rather than [0, 1]?

This might be it. So it would be like 0.200?

So, it looks OK now. I'm only having some doubts about the colour switches when in CPU/GPU/FAN mode. It seems to fluctuate very randomly - red, blue, green.
Also, are all four scripts needed? Doesn't Hue Wheel AIDA64 do the job of them all? Other than having the alarm, which could have a toggle.

Even better would be to leave the Hue Wheel script as is and move the rest to a "Sensor Monitor" script.

Are you sure the reason that HSVtoRGB wasn't giving you the correct colours wasn't because you were passing hue values in the range [0, 360] rather than [0, 1]?

This might be it. So it would be like 0.200?

Yes. Both hue, saturation, and value are in the range [0, 1].

Once you're done testing, you may remove your HsvToRgb functions and use Lighting.ColourUtils.HSVtoRGB that I just added for v2.1.0.

So, it looks OK now. I'm only having some doubts about the colour switches when in CPU/GPU/FAN mode. It seems to fluctuate very randomly - red, blue, green.

Looks fine to me. Did you adjust the minimum and maximum variable to your hardware and compare the colors to the actual temperature/fan speed?

Also, are all four scripts needed? Doesn't Hue Wheel AIDA64 do the job of them all? Other than having the alarm, which could have a toggle.

Just separated them, so people can easily use them in their own scripts or edit only the things they need. These are demos :)

Even better would be to leave the Hue Wheel script as is and move the rest to a "Sensor Monitor" script.

That's why I didn't "replace" the original script. We can name the new script whatever we want.

Yes. Both hue, saturation, and value are in the range [0, 1].

That way, its hard to get a fixed range. HSV goes from 0 to 360 and every number is a fixed color. I use 200-0 for the temperatures, cause red - blue. But well, I can define like 0.60-0.0, would be alike enough I guess.

Once you're done testing, you may remove your HsvToRgb functions and use Lighting.ColourUtils.HSVtoRGB that I just added for v2.1.0.

Done. I tested the calculations, they fit in the range of 0-1 now, instead of 0-360.

Yes, I did. But I will test it again.
But then if you're going to separate them for clarity, "Hue Wheel AIDA64" seems unnecessary.
You did in that it has a hue mode. It wouldn't make sense to have a "Hue Wheel" script and then have another script that does exactly the same thing, even if it has other additions.
It's still a fixed colour. But if that is a problem, you can continue using the same values and then just divide the result by 360 before passing it to the function.

Also, it seems you added commits that shouldn't be in the PR :P

2. But then if you're going to separate them for clarity, "Hue Wheel AIDA64" seems unnecessary.

3. You did in that it has a hue mode. It wouldn't make sense to have a "Hue Wheel" script and then have another script that does exactly the same thing, even if it has other additions.

Yeah well, I have no idea. Easiest would be to remove the original Hue Wheel.lua. Otherwise most of the AIDA64-script wouldn't make any sense anymore.

4. It's still a fixed colour. But if that is a problem, you can continue using the same values and then just divide the result by 360 before passing it to the function.

Yeah I know, anyway, I already adopted to 0-1 :)

Also, it seems you added commits that shouldn't be in the PR :P

I noticed, wasn't really on purpose :D

Of course it would still make sense. Your script would be a sort of "Sensor Monitor". Everything would be the same way, except it doesn't have a hue mode.

You seem to have moved the variables 'min' and 'max' to inside the if statement, which is not going to work. Also, I think it's best if you copy your scripts somewhere else and hard reset your pull request fork. You're including a ton of changes to MSIRGB that aren't part of your pull request.


test_crypt: Use the built xxd instead of requiring one to be installed

let s:xxd_cmd = $XXDPROG

It looks like s:xxd_cmd is never used in that test. I think you want to make use of s:xxd_cmd in Uncrypt_stable_xxd, no?

It looks like s:xxd_cmd is never used in that test. I think you want to make use of s:xxd_cmd in Uncrypt_stable_xxd, no?

Yes, thanks. :)


Mass assignment update bug

If you use mass assignment (i. e. $userModel->update(['someVar' => 'someValue'];), you will get the following error:
Integrity constraint violation: 1052 Column 'id' in field list is ambiguous

This is because we have an id column in the main and the version table.
Even if we solve this bug, mass assignment updates will not work, because the update logic is implemented in the model and not in the query builder. Extending the query builder might be a solution, but this way other packages, who extend the query builder for better reasons will break.

I decided to extend the query builder and document how to implement a custom query builder. So mass assignment should work now.


Plug in is blank when opened

Version
0.3.1
Sketch version
47.1
What is exptected?
To load some plugin shortcuts I guess. I haven't manage to make this work so far.
I would totally appreciate some help!!
What is actually happening?

How to repreduce this problem?
Sorry if I messed up with the reporting. I would really like to try this plugin, haven't managed to, since 44 version I think. Its not working for me :/ Since moved to sketch shortcuts are a nightmare.
The error log from Console.app when the problem occurred
https://pastebin.com/S76kN3ZU
Do not know how to get the error log? Steps: https://github.com/PeachScript/sketch-plugin-monster/blob/master/doc/FAQ.md#how-to-get-the-error-log
-->

I swear i pasted the Pastebin link but can see it on the op.
Here it is. thanks
https://pastebin.com/S76kN3ZU

Maybe you can first try to uninstall Plugin Monster, then update Sketch to 48.1 and reinstall the plugin. Because your log actually have no problems and we tried several times to achieve the issue but with no result. ( in High Sierra OS & V0.31 &  both Sketch 47.1 and 48.1 )

Hello, thanks for the reply, Is it that am in El Capitan?! I just updated to  48.1 / uninstall / reinstall monster, yet the same behavior :/  Thanks for your time.


[Feat]: Auto Commenting when an issue is closed by maintainer

Is your feature request related to a problem? Please describe.
Yes, the feature request is related to the problem of lack of communication and acknowledgment when issues are closed in the repository. Contributors may feel neglected or uncertain about the status of their issues if they are closed without any feedback or acknowledgment. This can lead to frustration and a decrease in motivation to contribute further.
Describe the solution you'd like
The solution is to automatically post a comment on the issue whenever it gets closed. This comment should thank the issue creator for their contribution and inform them that their issue has been closed. The message can include the issue number and a friendly greeting to make it more personal. This automation ensures that every closed issue receives a consistent and timely response, improving communication and contributor experience.

@thestarsahil please assign me this issue under gssoc'24

This season we are looking for major problem and solution containing level 3
Please look onto some other major problem
Thanks !


Rnning c# application in a machine that don't have R installed in

Hi,
I have an R script that i want to use from C#, so i must have R installed in my developpement machine, but the question is, will it work if i use this application in an other machine that haven't R installed in it.

No, it won't work. RDotNet just allows you to connect to R if it is installed on the machine running the application. If the machine does not have R installed, then RDotNet cannot run an R script.

Okay, thanks for your answer


TN-650 Another exception needed to properly catch bad data in FHIR_da…

…tetime.parse()
This resolves a 500 raised by MUSIC when sending in another bad date format.

Looks good to me. Not sure what kind of data they're sending to hit this, but it's definitely a situation we should be properly handling.


Group similar updates in action logs

Description
The "doc.save" action will inevitably have a bunch of logs especially while a site is in active development. The UI should be smart enough to batch these edits within a given view and allow users to expand a drawer to see more fine-tuned details.

fixed in https://github.com/blinkk/rootjs/commit/defb389de0f8b0f11f00ecbd271bdeb99b150300


Script crashes when screen is locked

The script should not attempt to do the window activation procedures if the system is locked but should remain running so when the user unlocks the desktop, it can resume normal functionality. Currently, it makes an attempt to execute the anti-idle command then exits due to the Bash set -e after the command exits with a non-zero exit code.

Resolved by https://github.com/Phenix66/Discord-Anti-Idle-Script/commit/b0a4a14eb3a5e35bf2dbc9a2d08450c0950dbda1


Fix function sinks

This PR fixes some bugs in the current function sink implementation. Some examples of currently broken behaviour can be found in the added. Additionally unnamed sinks are added.

I just noticed: Since something similar to consume will be required to fix #201 I will probably refactor this.


Configuration 1.0 to 2.0 migration instructions

I think the migration instructions for moving from V1.0 to V2.0 should include the need for the "versionId": "V2.0" entry in the configuration.
It's also not clear whether "additionalProperties" is the only change to be made or whether "recognizedAdditionalProperties" also need changing.

Could you explain more?

recognizedAdditionalProperties is a list of property names - it has not changed.
I thought the verdionId was added automatically?

Ah - I see what I did - I added the error message (and test for the version number) after I tested the migration.  I'll look at fixing the message so that we can add the version number automatically.

That would be great - or just document that if someone is doing a manual upgrade then they will need to manually add the versionId property.

I think this is done ?


Added tags in tiff

Hey @deep-gabani-google -- sorry about the CLA issue. I think the simplest way around it is to follow the CLA process, then re-create the CL. Would that be alright?

Closing this PR because of CLA permissions. Created a new PR for this one.


JerryScript issue on Nuttx

Hi Guys,
I'm want to use JerryScript on Nuttx. I've created a RAMDISK using mkrd, then I used echo in order to create a file with a .js extension, but when I run jerry /mnt/fs/test.js, I got a message saying :
Error: cannot open file: test.js
Source file load error
the test.js file is just a console.log .

cc: @rtakacs

Could you try the following?

change to the /mnt/fs/ directory
run: jerry test.js

Other questions:

Does the  cat /mnt/fs/test.js  prints out the file contents correctly?
Did you registered a  'console.log' method into the JerryScript nuttx ap? If not that then your script will throw a reference error. You should use the 'print' method instead as it is in included in the target.
Was the the CCM memory enabled during Nuttx build?

@galpeter Thank you so much, it works perfectly with the print. but how can I register the 'console.log' ?
I want to ask you another question, because I just start using Nuttx and jerryScript, I want to implement Wamp protocol using Autobahn : https://github.com/crossbario/autobahn-js. I'm using a Nucleo32F4 board, what do you think about the choice of Nuttx with Jerryscript ?

but how can I register the 'console.log' ?

Some examples of other projects and how they implement console:
https://github.com/01org/zephyr.js/blob/62fd1b952450c788920ea45d76f068f06ebad983/src/zjs_console.c#L246
https://github.com/Samsung/iotjs/blob/932980a22abf19261ad8f4a9299a06093b268984/src/modules/iotjs_module_console.c#L50
I guess you could also implement it in JS by wrapping print, i.e.:
console = {
  log: print,
  error: print,
  warn: print,
};

Many thanks @martijnthe

Why do not you support built-in console in jerryscript?

@Txiaozhe JerryScript is a JavaScript engine that is implementing built-ins that are described in the JavaScript (i.e., EcmaScript) standard. AFAIK console is not such a built-in. So, implementing it is the task of the embedder of the engine, e.g., IoT.js.

Yeah! Thanks:)


Fixes #323: Enable use of service accounts

Can one of the admins verify this patch?

Fixes #320 too, or at least makes it easier to run on OpenShift.

@cadvisorJenkinsBot: ok to test

@jimmidyson: Can you add some documentation to go along with this PR? This will help support new users on OpenShift.

LGTM. Thanks @jimmidyson


Grammar improvements to the "How to show attribution" article.

#sign-off

@stevemunk - because we don't have staging, you'll need to follow-up to make sure the live page is displaying images correctly and that links all work. thanks


Deprecate the old config API.

This means Payment should only configure the allowed_gateways.
Gateway configuration should go into GatewayInfo.
Added deprecation warnings. Updated docs and tests.

This looks brilliant to me. I think I'll leave it here for a day or in case @wilr or @jedateach or anyone else wants to comment.

Sure thing.


Feature request - Pie chart

Currently, there's only a donut chart which is very close to the pie chart, however, it would be nice to have the ability to add either of those depending on the situation in which it will be used.

+1.


Broken link to KB2549369

Link to KB2549369 is currently:
https://support.microsoft.com/default.aspx?scid=kb;en-US;2549369
This is "ignored" and redirects to the welcome page.
It's suggested to use the following instead:
https://support.microsoft.com/help/2549369

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: daa2f587-3079-f561-de2e-6663a6dcbab1
Version Independent ID: f9946d5c-e1fe-316a-f12c-78a061f5a029
Content: Troubleshoot Cache and Memory Manager Performance Issues
Content Source: WindowsServerDocs/administration/performance-tuning/subsystem/cache-memory-management/troubleshoot.md
Product: windows-server
Technology: performance-tuning-guide
GitHub Login: @phstee
Microsoft Alias: Pavel; ATales

If possible, it was a lot more useful to rework this issue to a global scope and fix all occurrences at once:

Run a regular expression over the whole repository with:
https://support.microsoft.com/default.aspx?scid=kb;en-US;(\d+)

Replace with:
https://support.microsoft.com/help/\1

This issue was closed but presently still exists as noted when attempting to click the link found under System file cache contains memory mapped files in the 2nd paragraph stating "This issue is described in detail in KB article 2549369."
Below is the updated Document Details when accessed 07/18/2023:

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6fe81add-b285-ff8e-f383-2df80332e722
Version Independent ID: 4e96ec10-8088-0d77-bc8b-d2197aebf9d9
Content: Troubleshoot Cache and Memory Manager Performance Issues
Content Source: WindowsServerDocs/administration/performance-tuning/subsystem/cache-memory-management/troubleshoot.md
Product: windows-server
Technology: administration
GitHub Login: @phstee
Microsoft Alias: pavel

This issue was closed but presently still exists as noted when attempting to click the link found under System file cache contains memory mapped files in the 2nd paragraph stating "This issue is described in detail in KB article 2549369."
Below is the updated Document Details when accessed 07/18/2023:
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6fe81add-b285-ff8e-f383-2df80332e722
Version Independent ID: 4e96ec10-8088-0d77-bc8b-d2197aebf9d9
Content: Troubleshoot Cache and Memory Manager Performance Issues
Content Source: WindowsServerDocs/administration/performance-tuning/subsystem/cache-memory-management/troubleshoot.md
Product: windows-server
Technology: administration
GitHub Login: @phstee
Microsoft Alias: pavel

I've opened a merge request to fix the specific page originally mentioned in this reported issue as Update troubleshoot.md #7393


WIP: Improve attachment upload methods

Close #20130
And add a method to drag and drop files to the text area
Can anyone help with testing and review?

Will take a look later (resolve the conflicts and do some improvements)

Still WIP, will fill some code back later.

->  Refactor dropzone #31482
I think we need to refactor the legacy code first, have a clear codebas and then continue. Otherwise there are too many unclear behaviors

It works again now (while there are still some TODO/FIXME problems)

Almost done and ready for review.

All done IMO


Numbers of more than 1 digit marked as typos

1 2 3 4 5 6 7 8 9 are fine
10+ are marked as a typo

I submitted a pr to fix this (along with other things)
https://github.com/pirtleshell/codemirror-typo/pull/5


Build failure: nixosTests.gitlab

nixosTests.gitlab is blocking the nixos-unstable channel since the last staging-next merge https://github.com/NixOS/nixpkgs/pull/348827
Log e.g.: https://hydra.nixos.org/build/276947171
At a glance, maybe changes in pkgs/development/interpreters/ruby pkgs/development/ruby-modules
Notify maintainers
@globin @yayayayaka (though already notified in chat)

Add a :+1: reaction to issues you find important.

I've started bisecting for the commit that broke the test, but the large rebuilds make it quite slow
git bisect start
# status: waiting for both good and bad commits
# bad: [f00f17fe6a4d5d94ac704e922426e476c3b6c29e] signal-desktop: 7.29.0 -> 7.31.0; signal-desktop-beta: 7.30.0-beta.2-> 7.32.0-beta.1 (#352218)
git bisect bad f00f17fe6a4d5d94ac704e922426e476c3b6c29e
# status: waiting for good commit(s), bad commit known
# skip: [807e9154dcb16384b1b765ebe9cd2bba2ac287fd] icu76: 76.1rc -> 76.1 (#351275)
git bisect skip 807e9154dcb16384b1b765ebe9cd2bba2ac287fd
# status: waiting for good commit(s), bad commit known
# good: [807e9154dcb16384b1b765ebe9cd2bba2ac287fd] icu76: 76.1rc -> 76.1 (#351275)
git bisect good 807e9154dcb16384b1b765ebe9cd2bba2ac287fd
# bad: [0c016abe52679d4adabf4bd4779e20fb5bfb90c1] python3Packages.python-dbusmock: 0.32.1 -> 0.32.2
git bisect bad 0c016abe52679d4adabf4bd4779e20fb5bfb90c1
# bad: [1fbde8aa6d02bbbb5a91e477e731fc1349a33938] python3Packages.empy: 4.1 -> 4.2
git bisect bad 1fbde8aa6d02bbbb5a91e477e731fc1349a33938

We did it again by merging with @anthonyroussel's 0855ae2c46c


Add asciiart support

Hello,
I made a small script to print ascii art with term color. You can see it here.
It could be a nice add to fetch. What do you think?
Cheers,

Sounds like a neat idea.
I've started working on implementing ascii support, here's what I've got so far:

We can also easily implement screenfetch ascii logos.

I was thinking ascii art for the color palette (like I do in ascolorii), but implement ascii art as main pitcure level is a great idea too! :)

It would be nice for both of our project to be able to scale the ascii art file. A work around would to use a tool to convert ascii art to svg format since svg support vectorization.

I've just pushed the base ascii support to master, you can use it like this:
fetch --ascii "path/to/ascii.txt" --ascii_color "4"

Please test it out!

I was thinking ascii art for the color palette (like I do in ascolorii), but implement ascii art as main pitcure level is a great idea too! :)

Ah, I see.
This should be easy to implement too!

Please test it out!

Sure I will!

I'm not going to ship any ascii with fetch, I think it should be up to the user.

Sure you are right. You should not cluter the project with this,

I've run into an issue while adding support for printing ascii art similar to the terminal color blocks. We need to insert padding to each line of ascii art so that it's inline with the text but I can't seem to do it without a really slow while read line statement.
Any ideas?

I've decided on shipping distro logos with fetch. The distro logos will work with the distro detection and will be displayed according to detected distro exactly like screenfetch.
Here's what the file structure will probably look like:

fetch.sh
ascii

distros

arch.txt
ubuntu.txt
etc

Displaying the current distro's ascii art is finished in my local branch, I'm just doing some cleanup before I push it to master. Here are some scrots:

Neat ! You nailed it.

I just pushed it to master, see this faq question to enable it.
https://github.com/dylanaraps/fetch#how-do-i-enable-screenfetch-mode
It needs testing very badly. :)

I'm testing Windows, BSD and a few Linux distros. It's confirmed working in:

[X] Windows
[X] FreeBSD
[ ] OpenBSD
[ ] NetBSD
[X] Arch
[ ] Elementary OS

@mclado, are you able to test ascii support on your OS X system?
Here's how you can test it out:
https://github.com/dylanaraps/fetch#how-do-i-enable-screenfetch-mode
This is the issue page for it, so if you've got any issues or ideas post them below. :)

Hmm, I am getting this error.
readlink: illegal option -- f
usage: readlink [-n] [file ...]
Just checking out why but I don't get it.

It seems out that readline on OS X is missing the -f flag(?). I'll have a look at alternatives to readlink or a workaround for OS X.

I also just realised that we need a standard location to store the distro ascii art.

Hmm, this looks like the easiest solution instead of other things in just googled.
http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac

Thanks for the link, a modified version of that is in master and the ascii art should work for you now.

Awesome!

I don't think it's possible to add ascii blocks similar to your script to fetch. I ran into multiple issues when implementing it myself and I couldn't get it to a point where I was happy with it.
You can use your script with fetch very easily. Just add this line to the printinfo function at the top like so:
printinfo () {
    info title
    info underline

    info "CPU" cpu
    info "GPU" gpu
    info "Memory" memory

    /path/to/ascolorii ~/skull.txt
    # etc ...
}

I'm closing this issue as the distro ascii stuff is complete now and I don't have any plans to add ascii block support any time soon.

It will do the job. Thank you for your work.


Prefix indicator is too small, how to make it bigger?

Iterm2 on OSX 10.14

Hello @Akemi-Homura 👋
You can try playing with iTerm2 Unicode settings:

And also change font to see if that helps.

@gpakosz It works！Thank you !

What worked?

@gpakosz After changing font to Source Code Pro, prefix indicator gets bigger.


Implement more math filters

This PR implements more math filters to improve jq compatibility. This is not still complete, but covers most of the math filters achieved without extra dependencies.

Awesome, thank you!


Profit and Loss Calculator

Calculator Functions
Profit and Loss Calculator is basically used to calculate the amount or percentage received after selling a particular price or goods. If the amount(Selling Price) received is greater after selling than the actual amount(Cost Price), it is considered profit otherwise loss.
Contribution Event
GSSOC22
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

@vasu-1 only one issue at a time?

yes


Using shortcut on Button generates mouse_exited signal on the selected collider

Godot version
b9375ea7fc135f5468dcfb8c80b51a945ac14155
System information
Windows 11
Issue description
If the user previously select a collider by using mouse (with emitted mouse_entered signal), and then pressed a shortcut connected to the button, it would generate mouse_exited signal which is incorrect:

Steps to reproduce
It is better to be tested with a provided project - run it and press B key to see that mouse_exited signal generates incorrectly.
Minimal reproduction project
test.zip

Bisected to https://github.com/godotengine/godot/commit/9d7d20a978fccf7b2871dc388f16b87b4b686144. The test project remade to work near that old version of Godot is attached: test_mouse_exited.zip
cc @EricEzaM

Is it because focus is being taken by the button? Adding accept event for the button was correct I think (that pr linked above). but if the button triggering causes some signals to fire which in turn make the mouse exit event trigger, then that should be investigated if it is the desired behaviour.

The mouse exit being triggered is undesired behavior IMHO.
Picking is happening in scene/main/viewport.cpp based on input events. Could you take a look?
Maybe it's something to do with is_input_handled().

I might have time to look on the weekend. If anyone else is interested in investigating further - please go ahead.

This is happening because of this:
https://github.com/godotengine/godot/blob/6991e9b43d0954018e1a82fa4cb28af42632ae92/scene/main/viewport.cpp#L3039-L3040
As soon as input is set as accepted, mouse exit is called:
https://github.com/godotengine/godot/blob/6991e9b43d0954018e1a82fa4cb28af42632ae92/scene/main/viewport.cpp#L2279
This was added here #29579 (cc @mrcdk (if you are still around) or @RandomShaper (who approved the logic behind the addition)), to fix #29575. Any thoughts about what we should do about this?

In trying to fix this as well as keep the fix from #29575, here is what I have.
https://user-images.githubusercontent.com/41730826/193043339-e762cf6c-8f41-49a4-a851-32ecdb5afbd3.mp4

@EricEzaM Do you have progress with that? If you doubt - you can create two PRs for each case and decision will be chosen on the PR meeting


jrl-cmakemodules as a submodule?

Currently, the contents of https://github.com/jrl-umi3218/jrl-cmakemodules/ are directly vendored into this repo, instead of as a submodule, as we usually do in our projects (aligator, proxsuite, pinocchio...)

is this intended?
can/should we switch to a submodule?

cc @edantec

It is not intended, we should definitely switch to a submodule.

Okay, I'll add this to #4


[PROPOSAL] Document Review Process in Readme

What are you proposing?
As we add more full time writers to the OpenSearch project, we need to take the time to codify and clarify the PR review process. This documentation is even more important with the addition of our new editor, who gives the final sign off before a OpenSearch docs contribution is merged.
After we've finalized the review process, let's publish the entire process in the documentation-website readme.
What will it take to execute?

[ ] Create any labels needed to help aid in the review process
[ ] Document the review process in the documentation website readme

Here is an internal document that outlines the review process for PRs. https://quip-amazon.com/lSyeAj55sfSt/Add-review-comments-to-a-PR-in-GitHub.
But, @Naarcha-AWS, I think you are more concerned with how we review external contributors' input?

https://quip-amazon.com/24daAPTLn6xt/Readmemd-DRAFT

Merged the second part of this issue: Removed Partners from the footer.