General suggestion

The advantage of using classes is that, data and methods for manipulation data is all in one place. It saves you the trouble of creating functions on the global scope.
Now that you have an idea of what the app is going to do, maybe you can sketch on a piece of paper which classes you want to create, and each methods and properties they would have. Check UML Class Diagram.

I see what you mean. I changed it now, so that all the game play happens inside the game object. I would be happy about more feedback-

Looks much better now. More organized. :+1:

You’ve done a great job organizing the code into logical blocks which really helps in understanding the flow of the game.
I have a little observation that you might like to take into consideration. In the class Board, I noticed that you manually typed out each row to display the game board, instead, you can use a loop or some iteration method like forEach to achieve that (Assuming 'rows' is an array of arrays, where each sub-array represents a row of Tiles). This not only makes your code cleaner and easier to read but also allows for easier modifications to the board size in the future.
Keep up the great work! With a few tweaks and a bit more polishing, your game could be even more engaging.

Thank you for your feedback, Zakaria! I actually updated the showBoard function so that it uses a loop now :) but then forgot to reply to your comment here.

No worries! Most important that it worked :)


Support multi-column groupby with sort=True and split_out>1

Uses the multi-column sort_values support added in https://github.com/dask/dask/pull/8263 to support multi-column groupby aggregations with sort=True and split_out > 1.

Thanks for reviewing @hendrikmakait  and @phofl !


Load in JSON

I'm trying to load a wide serie of  .sav files using your Nuget, but my attempts ended in this error.
expected zero arguments for construction of ClassDict (for numpy.dtype). This happens when an unsupported/unregistered class is being unpickled that requires construction arguments. Fix it by registering a custom IObjectConstructor for this class
Is it possible to set a default translation in a KeyValuePair<string, string> for the unregistered/unsupported classes, or add a specific constructor for numpy.dtype class?

Yes. try  Unpickler.registerConstructor(...)

However you may find that you need to add a constructor for all numpy types that might be pickled into your ".sav" file. It could be easier to not store the numpy data in your pickles, but convert it to normal python datatypes before writing the pickle file.

It might be difficult to edit all our .sav files (not all of them are created by us).
We've defined a JSONConstructor():
public class JSONConstructor : IObjectConstructor
{
    public object construct(object[] args)
    {
        try
        {
            string json = JsonConvert.SerializeObject(args);

            return json;
        }
        catch (Exception x)
        {
            throw new PickleException("problem constructing object", x);
        }
    }
}

But we encounter the following exception:

| Nome | Valore | Tipo
-- | -- | -- | --
▶ | e | {"failed to setstate()"} | System.Exception {Razorvine.Pickle.PickleException}

We think the Exception is caused by the missing setstate() method for a primitive object (string).
We even tried to use the Unpickler.registerConstructor with the ClassDictConstructor() method but we encounter the following exception:

| Nome | Valore | Tipo
-- | -- | -- | --
▶ | e | {"expected zero arguments for construction of ClassDict (for numpy.dtype). This happens when an unsupported/unregistered class is being unpickled that requires construction arguments. Fix it by registering a custom IObjectConstructor for this class."} | System.Exception {Razorvine.Pickle.PickleException}
▶ | e | {"expected zero arguments for construction of ClassDict (for numpy.core.multiarray._reconstruct). This happens when an unsupported/unregistered class is being unpickled that requires construction arguments. Fix it by registering a custom IObjectConstructor for this class."} | System.Exception {Razorvine.Pickle.PickleException}

Can you please give us some instructions to resolve the Exceptions?
Thank you!

Try to use the source code to figure out why you still get these errors. For example, here are a couple of unit tests that utilize the custom class constructor registry
https://github.com/irmen/pickle/blob/master/java/src/test/java/net/razorvine/pickle/test/UnpicklerComplexTest.java


Append CoAP Token and Message ID field for ED/PANID query/report/conflict message.

Test case 9.2.14 Harness initiates MGMT_PANID_QUERY.qry unicast to DUT and multicast to All Thread Node Multicast Address respectively. It will search the corresponding MGMT_PANID_CONFLICT.ans from pcap and compare the CoAP Token field between the two MGMT_PANID_CONFLICT.ans to decide which packet responses for unicast and which packet for multicast. Currently the CoAP Token field is zero-length, hence, harness doesn't find the second MGMT_PANID_CONFLICT correctly. pcap as below:
Router_9_2_14(fail).zip
Spec states that a zero-length Token may be allowed for qry/ans_con/ans_non. Maybe here we can append this filed to distinguish different packets. 9.2.14 two scenarios(DUT as Router and Commissioner) pass with this PR.
Router_9_2_14(pass).zip
Commissioner_9_2_14(pass).zip
Also remove the unused Timer and relevant callback functions in ED/PANID query client side. Please have a review.

Current coverage is 68.48% (diff: 100%)

Merging #712 into master will decrease coverage by 1.07%

@@             master       #712   diff @@
==========================================
  Files           101        100     -1
  Lines         15231      15226     -5
  Methods        2074       2066     -8
  Messages          0          0
  Branches       1799       1802     +3
==========================================
- Hits          10594      10427   -167
- Misses         4062       4219   +157
- Partials        575        580     +5

Powered by Codecov. Last update dfd5fbd...736bb37


Issue with running different AIY models at the same time

I'm trying to run the image classification model and the face detection model one after the other repeatedly over a span of time.  So I create 2 functions each run the inference of a different model.  The first call of the face_detection_inference and the image_calssification_inference works fine, but when the face_detection_inference is called again the camera stops and the Monitor goes off.
#!/usr/bin/env python3

import argparse
import time

from picamera import PiCamera
from aiy.vision.inference import CameraInference
from aiy.vision.models import face_detection
from aiy.vision.annotator import Annotator
from aiy.vision.models import image_classification
from aiy.board import Board, Led

ticks = time.time()

def durationOver():
    pomodoro = 25*60 #25 mins (used for attention span) - initially using 20 seconds for testing
    cur_ticks = time.time()
    if (cur_ticks-ticks)<pomodoro:
        return True
    return False

#Image classification main
def classes_info(classes):
    return ', '.join('%s (%.2f)' % pair for pair in classes)

def face_detection_inference(camera,args):
    """Face detection camera inference example."""

    # Annotator renders in software so use a smaller size and scale results
    # for increased performace.
    annotator = Annotator(camera, dimensions=(320, 240))
    scale_x = 320 / 1640
    scale_y = 240 / 1232

    # Incoming boxes are of the form (x, y, width, height). Scale and
    # transform to the form (x1, y1, x2, y2).
    def transform(bounding_box):
        x, y, width, height = bounding_box
        return (scale_x * x, scale_y * y, scale_x * (x + width), scale_y * (y + height))

    with CameraInference(face_detection.model()) as inference:
        cam_tick = time.time()
        for result in inference.run(args.num_frames):
            time_passed = time.time() - cam_tick
            if time_passed>5:
                print("No face detected and the checker timed out")
                return False
            faces = face_detection.get_faces(result)
            annotator.clear()
            for face in faces:
                annotator.bounding_box(transform(face.bounding_box), fill=0)
            annotator.update()
            print('#%05d (%5.2f fps): num_faces=%d' %(inference.count, inference.rate, len(faces)))
            if len(faces) > 0:
                return True
        return False

def image_calssification_inference(camera,args):
    with CameraInference(image_classification.model()) as inference:
        cam_tick = time.time()
        for result in inference.run(args.num_frames):
            time_passed = time.time() - cam_tick
            if time_passed>5:
                break
            classes = image_classification.get_classes(result, top_k=args.num_objects)

            print(classes_info(classes))
            if classes:
                camera.annotate_text = '%s (%.2f)' % classes[0]
                #if classes.String[0] == "cellular telephone/cellular phone/cellphone/cell/mobile phone":
                    #print("phone detected")
                    #break

#Face detection main
def main():

    print('LED is ON while button is pressed (Ctrl-C for exit).')
    with Board() as board:
        board.button.wait_for_press()
        print('ON')
        board.led.state = Led.ON
        board.button.wait_for_release()
        print('OFF')
        board.led.state = Led.OFF

    parserf = argparse.ArgumentParser()
    parserf.add_argument('--num_frames', '-n', type=int, dest='num_frames', default=None,
        help='Sets the number of frames to run for, otherwise runs forever.')
    argsf = parserf.parse_args()

    parser = argparse.ArgumentParser('Image classification camera inference example.')
    parser.add_argument('--num_frames', '-n', type=int, default=None,
        help='Sets the number of frames to run for, otherwise runs forever.')
    parser.add_argument('--num_objects', '-c', type=int, default=3,
        help='Sets the number of object interences to print.')
    parser.add_argument('--nopreview', dest='preview', action='store_false', default=True,
        help='Enable camera preview')
    args = parser.parse_args()

    # Forced sensor mode, 1640x1232, full FoV. See:
    # https://picamera.readthedocs.io/en/release-1.13/fov.html#sensor-modes
    # This is the resolution inference run on.
    with PiCamera(sensor_mode=4, resolution=(1640, 1232), framerate=30) as camera:
        camera.start_preview()
        no_face = 0
        if (face_detection_inference(camera,argsf)):
        while durationOver():
            image_calssification_inference(camera,args)
            time.sleep(30)
            if(not face_detection_inference(camera,argsf)):
                print("You are not focusing, please focus")
                no_face+=1
                if no_face > 4:
                    print("You haven't been focusing for 5 itrs (face not detected), Take a break and return later")
                    break
            time.sleep(30)
        else:
            print("No face detected to start the timer for studying")
        camera.stop_preview()

if __name__ == '__main__':
    main()

@nadeentarek Did you try to run these models manually one after the other ?


Error loading examples 10x Genomics filtered contig annotations data

Hello
I am trying to load 10x Genomics filtered_contig_annotations.csv into Immunarch using the repLoad function. I kept getting an error trying to load my own data. I thought this was because the 10x data was analyzed and processed outside of cellranger vdj and then reformatted to look like a filtered_contig_annotations.csv file. However, this does not appear to the be problem because I get the same error when trying to load the conitg annotations file from the Loading 10x Genomics Data tutorial.
Below is a screenshot the the repLoad command and the error that is produced.
Thanks
Evan

Hi, @ewalsh3 !
Thank you for using our package!
I am sorry you had to deal with this inconvenience.
We know that our support of 10x genomics is not ideal. And now we are focused on improving our package in this area.
I will get back to you with any updates.
Thank you so much for drawing our attention to this. Please contact us with any questions further along.
Best regards,
@Maria Samokhina


SLSA v0.2 provenance implementation for materials.digest (if using git) doesn't line up with spec

materials.digest as implemented has a key for materials.revision but not for materials.digest which is in the spec.

materials[*].digest object (DigestSet), optional
Collection of cryptographic digests for the contents of this artifact.

One thing to not is there is currently some ambiguity in SLSA as to whether or not "commit id" counts as digest. https://github.com/slsa-framework/slsa/issues/214 -- However looking at a https git reference can be confusing without adding git+ to the URI. Do other folks have any thoughts?
Similar to #306 and #307
See: https://github.com/slsa-framework/slsa/blob/main/docs/provenance/v0.2.md

Looks like there are two bugs here:

Instead of using the "revision" key we should be using "sha1" to indicate a commit, which is what the provenance in the the github actions example does

  "configSource": {
    "entryPoint": "build.yaml:build",
    // The git repo that contains the build.yaml referenced in the entrypoint.
    "uri": "git+https://github.com/foo/bar.git",
    // The resolved git commit hash reflecting the version of the repo used
    // for this build.
    "digest": {"sha1": "abc..."}
  },

we need to add the git+ prefix and .git suffix to the URI

There is also: https://github.com/in-toto/attestation/issues/28 here. There is some discussion if some of this at the attestation spec level as well.


Update README.md

At the time of this commit, geckodriver v0.17.0 worked for me

Thanks for the pull request!
This is the version that we use in the Travis tests. I'll note that in the installation instructions as well.


why use the matrix calculate the convolution the multiplication is less ?

Gg  using multiplication
an Btd using multiplication
Gg @ Btd using multiplication
At * (Gg @ Btd) using multiplication too.
it confused me .
who can explain it for me ?
@andravin

The savings come when you use this algorithm in a convolutional neural network layer.
A 3x3 convolutional layer has C input channels and K output channels, and spatial dimensions HxW. The direct algorithm use HWCK9 multiply accumulates. F(4x4, 3x3) uses (H/4)(W/4)CK(36) = HWCK(2.25) multiply accumulates, in addition to (H/4)(W/4)C(144) arithmetic instructions for the data transform, CK(72) for the filter transform, and (H/4)(W/4)K(100) for the inverse transform.
So the reason the number of arithmetic instructions in the transforms do not matter is that the multiplication stage is O(HWCK) while the transforms are O(HWC), O(CK), and O(HWK). So each of the transforms is less by a factor of K, HW, or C. If all of theses quantities are large, then the amount of arithmetic in the transforms is dominated by the multiplication stage.

@andravin  thank you .
but another question ,how about stride 2 using winograd ?
is this only support the stride 1 ?

Yes, you can use fast algorithms with strided convolutions.

For the strided (aka "decimated") convolution example in the FAQ, I was showing how you first decompose the input into 2 different inputs by separating the even and odd elements, which are labeled with the symbols x and o, respectively.
Also you do the same for the filter.
So if you had input signal xoxoxox and 3x1 filter xox, and you want a stride 2 convolution, the thing to notice is that, because of the stride, we only multiply xs in the input times xs in the filter, and likewise for os. So we can separate this into 2 separate (unstrided) convolutions:
xxxx * xx + ooo * o
One of the convolutions has a 2 element filter, the other a 1 element filter. You can use a fast convolution algorithm for the 2 element filter (eg: F(2, 2), F(4, 2)).
For 2D convolutions, you can use the same decomposition to yield 4 unstrided convolutions. A stride 2 convolution with a 3x3 filter will become a sum of unstrided convolutions with 2x1, 1x2, 2x2, and 1x1 filters. You can use fast algorithms for the 2x1, 1x2, and 2x2 filters.
The paper cited in the FAQ has more detail, and again, this is covered under the "decimated convolutions" section of you favorite DSP book.


Strip led L900

I have an L900 RGB led strip, it turns on and off but does not change color. is it possible to integrate it?

Questo errore ha avuto origine da un'integrazione personalizzata.
Logger: custom_components.tapo.common_setup
Source: helpers/update_coordinator.py:219
Integration: Tapo Controller (documentation, issues)
First occurred: 16:04:43 (1 occurrences)
Last logged: 16:04:43
Error fetching tapo data:

Colors for L900 are already supported by the integration, so you can try to re-add your strip or/and restart home assistant

Hello, I'm having the same issue. I'm able to turn on/off, decrease/increase brightness and use effects, but cannot change the colour. I have re-added the strip and restarted home assistant. Using an L900-5. Happy to provide screenshot or video if needed.
Also, sorry if I'm not using the issues sections right, I'm a noob.


Opt for more safety on whether to regenerate vendor

What does this do / why do we need it?
We were guessing that, if the Gopkg.lock hadn't changed, that vendor
also didn't need to change. However, that missed cases where manual
modifications had been made to vendor. It's not terribly common, but it
still violates the sync model to get this wrong.
/cc @ibrasho this is ensure, so i'll leave this for you to decide on and merge
What should your reviewer look out for in this PR?
Do you need help or clarification on anything?
Which issue(s) does this PR fix?
fixes #1276

...i'm actually kinda on the fence about this. is it just enough to ask people to run dep ensure -vendor-only in this case? seems like maybe it should be, and we can reject this PR.
🤔

yeah, i think we can safely get away with not doing this for now.


Not translate "Months" title in months view

Can you give some more context (and/or example) on what you try to achieve?

Sorry,
Configuration:
$('#sandbox-container div').datepicker({
maxViewMode: 1,
todayBtn: true,
language: "pt-BR"
});

Ah yes! So the issue is not that the key should be translated but that it's not translated but it should be translated?

Sorry about my English...
The correct is that word be translated like the Today button

Ok, issue is clear now! I will fix this for the coming releases

I've fixed the issue in #1708, can you provide the translation for "months" in pt-BR? Then I will add it to the PR

Fixed in #1727


(JS-0050) Avoid use of == and !=

Description
It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.
Occurrences
There are 35 occurrences of this issue in the repository.
See all occurrences on DeepSource → app.deepsource.com/gh/llTheBlankll/attendance-management-angular/issue/JS-0050/occurrences/

Closes with PR #5


[Adding Tool]: Add tinyurl as a url shortener

What tool are you adding and to what category?
We need to add tinyurl under the category of useful tools. Tinyurl is a famous tool used for shortening urls. It also provides option to add custom alias in the shortened url.
Add Tool Link
Add tool link: https://tinyurl.com/app
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] The tool is free for use

Kindly assign me this issue under GSSOC'23


Task/create database model

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@61f0ab5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   84.66%
=======================================
  Files           ?       11
  Lines           ?      313
  Branches        ?        0
=======================================
  Hits            ?      265
  Misses          ?       48
  Partials        ?        0

Flag
Coverage Δ

unittests
84.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f0ab5...b56ac33. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@61f0ab5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   84.66%
=======================================
  Files           ?       11
  Lines           ?      313
  Branches        ?        0
=======================================
  Hits            ?      265
  Misses          ?       48
  Partials        ?        0

Flag
Coverage Δ

unittests
84.66% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f0ab5...b56ac33. Read the comment docs.


DMX functionality

Potential applications
Cloud that flashes lightning when device is scanned.
Smoke released at beginning of scene in the Troll location.


Use non-persistent buffers

🚀 The feature
Suggest using register_buffer() with persistent=False, so the buffer (e.g. window of spectrogram) will not be included in module's state dict.
Motivation, pitch
When I add new transforms to my model and load a pre-existing checkpoint, a missing key error will be raised, e.g. missing resample kernel in transforms.Resample. It can be solved by specifying strict=False at load time, however, I don't see any reason to save the buffers. They can be recomputed on construction time and that won't affect model's behavior.
Alternatives
No response
Additional context
Same motivation as https://github.com/pytorch/pytorch/issues/18056.

This sounds reasonable to me. @pytorch/team-audio-core any objection?

The team thinks this is a good change, and we look for contributor to make the change. Feel free to open a PR.

Hello,
Is anyone working on this? I'm planning to give it a shot and possibly submit a PR.

HIi @ashikshafi08
Thanks for the interest. No one is working on it, so feel free to do so.

@mthrok I don’t see recent updates on this issue. I  can take a look at this issue if there are no conflicts with others?

@mthrok I don’t see recent updates on this issue. I can take a look at this issue if there are no conflicts with others?

@francislata Thanks for the suggestion. I don't think anyone is working on it, so feel free to send a PR.


Add notes to installing with PowerShell

Users are often blocked because of missing some vital steps (#2727):

The user may forget to run PowerShell as administrator, then the Start-Process msiexec.exe command will silently fail.
The user may forget to reopen PowerShell after installation, leading to failure:> az --version
az : The term 'az' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the
spelling of the name, or if a path was included, verify that the path is correct and try again.

Docs Build status updates of commit d845601:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/install-azure-cli-windows.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Change color of close button

As a user
I would like to see a close button that matches the rest of the color scheme
So that the site does not look like garbage.

Look as James Gebler's code for an example.


Update to minimist v1.2.3+

🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
Please read https://angular.io/guide/security#report-issues on how to disclose security related issues.
🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑🛑
npm audit command is reporting a new vulnerability in an angular/cli dev dependency. This does not appear critical but it does affect my company's internal tooling that requires passing npm audits.
https://www.npmjs.com/advisories/1179 - moderate vulnerability in minimist pre v1.2.3

+1 same here

github reports both acorn and minimist
here's my yarn why
[kushal@ideapadflex-kushal ondotnetangularfrontend]$ yarn why acorn
yarn why v1.22.4
[1/4] Why do we have the module "acorn"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "@angular-devkit#build-angular#webpack" depends on it
   - Hoisted from "@angular-devkit#build-angular#webpack#acorn"
info Disk size without dependencies: "1.08MB"
info Disk size with unique dependencies: "1.08MB"
info Disk size with transitive dependencies: "1.08MB"
info Number of shared dependencies: 0
=> Found<EMAIL_ADDRESS>info This module exists because "@angular-devkit#build-angular#rollup" depends on it.
info Disk size without dependencies: "1.08MB"
info Disk size with unique dependencies: "1.08MB"
info Disk size with transitive dependencies: "1.08MB"
info Number of shared dependencies: 0
Done in 0.66s.
[kushal@ideapadflex-kushal ondotnetangularfrontend]$ yarn why minimist
yarn why v1.22.4
[1/4] Why do we have the module "minimist"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Has been hoisted to "minimist"
info Reasons this module exists
   - Hoisted from "json5#minimist"
   - Hoisted from "@angular#compiler-cli#minimist"
   - Hoisted from "protractor#blocking-proxy#minimist"
   - Hoisted from "protractor#webdriver-manager#minimist"
   - Hoisted from "@angular-devkit#build-angular#loader-utils#json5#minimist"
info Disk size without dependencies: "96KB"
info Disk size with unique dependencies: "96KB"
info Disk size with transitive dependencies: "96KB"
info Number of shared dependencies: 0
=> Found<EMAIL_ADDRESS>info This module exists because "cacache#mkdirp" depends on it.
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
=> Found<EMAIL_ADDRESS>info This module exists because "karma#optimist" depends on it.
info Disk size without dependencies: "80KB"
info Disk size with unique dependencies: "80KB"
info Disk size with transitive dependencies: "80KB"
info Number of shared dependencies: 0
Done in 0.65s.

Blocking as this needs to be fixed upstream by several direct and transitive dependencies.
npm audit

                       === npm audit security report ===

                                 Manual Review
             Some vulnerabilities require your attention to resolve

          Visit https://go.npm.me/audit-guide for additional guidance

  Moderate        Prototype Pollution

  Package         minimist

  Patched in      >=1.2.3

  Dependency of   @angular-devkit/build-angular [dev]

  Path            @angular-devkit/build-angular > webpack > watchpack >
                  chokidar > fsevents > node-pre-gyp > mkdirp > minimist

  More info       https://npmjs.com/advisories/1179

  Moderate        Prototype Pollution

  Package         minimist

  Patched in      >=1.2.3

  Dependency of   @angular-devkit/build-angular [dev]

  Path            @angular-devkit/build-angular > webpack > watchpack >
                  chokidar > fsevents > node-pre-gyp > tar > mkdirp > minimist

  More info       https://npmjs.com/advisories/1179

  Moderate        Prototype Pollution

  Package         minimist

  Patched in      >=1.2.3

  Dependency of   @angular-devkit/build-angular [dev]

  Path            @angular-devkit/build-angular > webpack > watchpack >
                  chokidar > fsevents > node-pre-gyp > rc > minimist

  More info       https://npmjs.com/advisories/1179

  Moderate        Prototype Pollution

  Package         minimist

  Patched in      >=1.2.3

  Dependency of   @angular-devkit/build-angular [dev]

  Path            @angular-devkit/build-angular > webpack-dev-server >
                  chokidar > fsevents > node-pre-gyp > mkdirp > minimist

  More info       https://npmjs.com/advisories/1179

  Moderate        Prototype Pollution

  Package         minimist

  Patched in      >=1.2.3

  Dependency of   @angular-devkit/build-angular [dev]

  Path            @angular-devkit/build-angular > webpack-dev-server >
                  chokidar > fsevents > node-pre-gyp > tar > mkdirp > minimist

  More info       https://npmjs.com/advisories/1179

  Moderate        Prototype Pollution

  Package         minimist

  Patched in      >=1.2.3

  Dependency of   @angular-devkit/build-angular [dev]

  Path            @angular-devkit/build-angular > webpack-dev-server >
                  chokidar > fsevents > node-pre-gyp > rc > minimist

  More info       https://npmjs.com/advisories/1179

  Moderate        Prototype Pollution

  Package         minimist

  Patched in      >=1.2.3

  Dependency of   karma [dev]

  Path            karma > optimist > minimist

  More info       https://npmjs.com/advisories/1179

  Moderate        Prototype Pollution

  Package         minimist

  Patched in      >=1.2.3

  Dependency of   protractor [dev]

  Path            protractor > optimist > minimist

  More info       https://npmjs.com/advisories/1179

found 8 moderate severity vulnerabilities in 15582 scanned packages
  8 vulnerabilities require manual review. See the full report for details.

Hi guys, im having the same error, and really, i don't know how i can resolve it. The NPM documentacion about this situation, si soo short
https://www.npmjs.com/advisories/1179

I am working around this at the moment by choosing to up the audit level from low to moderate which then passes because the minimalist issue is at the low level, while I wait for the upstream fix.
so
$ npm audit --audit-level=moderate

instead of
$ npm audit

I am working around this at the moment by choosing to up the audit level from low to moderate which then passes because the minimalist issue is at the low level, while I wait for the upstream fix.
so
$ npm audit --audit-level=moderate

instead of
$ npm audit

Thanks for that @alastairtree i will try this, and then, i will let you know

if you add the following below browserlist in package.json:
  "resolutions": {     "minimist": "^1.2.3"   }
then delete node_modules and run
npx npm-force-resolutions && npm install
it will resolve the issue for current builds

@DomTripodi93 what if we don't have browserlist installed? browserlist is required for this fix?

@DomTripodi93 what if we don't have browserlist installed? browserlist is required for this fix?

No, browserlist isn't relevant, it's just the default last item in React(which is experiencing the same problem)
I should have said below "devDependencies", but it doesn't technically matter where it is located, it's just best practice to make it the last value, as you will likely remove it after the package is updated in the affected packages. I will update above

if you add the following below devDependencies in package.json:
"resolutions": { "minimist": "^1.2.3" }
then delete node_modules and run
npx npm-force-resolutions && npm install
it will resolve the issue for current builds

I'm getting a npm ERR! extraneous<EMAIL_ADDRESS>after doing your solution steps and running npm ls minimist

Karma version 5.0.0 and Protractor version 5.4.4 have been released and both of them contain the update.
@kyliau is liaising with the Karma team to see if it is possible to backport the fix in Karma version 4.

I am currently using Angular core 8.3.0 and I see two versions of minimist 0.0.8 and 1.2.0.  How do I include different versions of minimist for each dependency.  Say for example for<EMAIL_ADDRESS>I want to use<EMAIL_ADDRESS>and for<EMAIL_ADDRESS>I want to use<EMAIL_ADDRESS>Below is my current npm list minimist before any updates:
├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ └─┬<EMAIL_ADDRESS>│ │   └─┬<EMAIL_ADDRESS>│ │     ├─┬<EMAIL_ADDRESS>│ │     │ └──<EMAIL_ADDRESS>│ │     └─┬<EMAIL_ADDRESS>│ │       └──<EMAIL_ADDRESS>

@tomvmac, can you update karma to version 5.0.0

Closed via https://github.com/angular/angular-cli/pull/17525


.NET core 2.1

Hello,
I had a few questions about this project.

Does this server support .NET core 2.1 nuget packages?
Can I use it with basic authentication?
How has the server worked for you so far?

Thanks!

From what I can tell, I think this project is in a very early state. It doesn't look like any of the functionality is implemented.


SPARK-10614 SystemClock uses non-monotonic time in its wait logic. Th…

This patch adds a new subclass, MonotonicClock, and switches ExecutorAllocationManager to using it (it used to use System.nanoTime()).
A lot of the code which uses SystemClock would appear to benefit from moving to a monotonic clock —but that would a more significant piece of work, needing understanding of what's happening. Furthermore, some of the uses are of fields which may also be converted to human-formatted time; the nanotime clock shouldn't be used that way.

Merged build triggered.

Merged build started.

Test build #42485 has started for   PR 8766 at commit a71af05.

Test build #42485 has finished for   PR 8766 at commit a71af05.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42485/
Test PASSed.

Mostly style nits, but there seems to be a real bug in there. Otherwise, looks good.

Merged build triggered.

Merged build started.

Test build #42535 has started for   PR 8766 at commit 10ea2f3.

Test build #42535 has finished for   PR 8766 at commit 10ea2f3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42535/
Test FAILed.

test failure is org.apache.spark.streaming.CheckpointSuite.recovery with invertible reduceByKeyAndWindow operation; appears unrelated.

retest this please

Merged build triggered.

Merged build started.

Test build #42610 has started for   PR 8766 at commit 10ea2f3.

Marcelo, I'm not sure I trust nanoTime any more: I did some reading on the topic and don't think code can be confident it works (i.e. is monotonic and consistent) on multi-socket systems or VMs:
http://steveloughran.blogspot.co.uk/2015/09/time-on-multi-core-multi-socket-servers.html
if you agree, there's no regression in the code, and we could close this as a WONTFIX.

This is what my clock_gettime(3) man page says:
Historical note for SMP systems
   Before Linux added kernel support for CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID, glibc implemented these clocks  on  many  plat‐
   forms  using  timer registers from the CPUs (TSC on i386, AR.ITC on Itanium).  These registers may differ between CPUs and as a consequence
   these clocks may return bogus results if a process is migrated to another CPU.

   If the CPUs in an SMP system have different clock sources, then there is no way to maintain a correlation between the timer registers since
   each  CPU  will run at a slightly different frequency.  If that is the case, then clock_getcpuclockid(0) will return ENOENT to signify this
   condition.  The two clocks will then be useful only if it can be ensured that a process stays on a certain CPU.

   The processors in an SMP system do not start all at exactly the same time and therefore the timer registers are  typically  running  at  an
   offset.   Some architectures include code that attempts to limit these offsets on bootup.  However, the code cannot guarantee to accurately
   tune the offsets.  Glibc contains no provisions to deal with these offsets (unlike the Linux Kernel).  Typically these  offsets  are  small
   and therefore the effects may be negligible in most cases.

   Since  glibc 2.4, the wrapper functions for the system calls described in this page avoid the abovementioned problems by employing the ker‐
   nel implementation of CLOCK_PROCESS_CPUTIME_ID and CLOCK_THREAD_CPUTIME_ID, on systems that provide such  an  implementation  (i.e.,  Linux
   2.6.12 and later).

That, and some comments on the links that you posted, lead me to believe that System.nanoTime is, in the worst case, no worse than System.currentTimeMillis. But, caveat emptor, since the above man page only applies to Linux. java.util.concurrent seems to use nanoTime, so we already rely on it more than we might expect.
I haven't read the code in ExecutorAllocationManager in detail to see how it would behave when System.currentTimeMillis goes backwards. It seems to me that at least that case would not happen with nanoTime, assuming the conditions listed in the man page exist.

Test build #42610 has finished for   PR 8766 at commit 10ea2f3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42610/
Test FAILed.

Actually, why introduce another clock here, why not just change SystemClock to use System.nanoTime?

If people are happy with that, I'll do that

Yes let's just do that. There's no point in introducing another system clock and call it something else. Let's just fix the existing one.


upgrade deprecated botocore calls in ELB watcher

For issue #249
Updates botocore calls and uses better rate limiting code from generic Watcher class

  File ".../security_monkey/watcher.py", line 127, in wrap_aws_rate_limited_call
    raise e
botocore.exceptions.ClientError: An error occurred (Throttling) when calling the DescribeLoadBalancerPolicies operation: Rate exceeded

Just tested and a rate-limiting error was able to sneak through.
I have done this same thing in a decorator for another project and I believe the e.message is different for boto/boto3:
            try:
                retval = func(*args, **kwargs)
                if metadata['delay'] > 0:
                    app.logger.warn("No longer being rate-limited {} -> {}".format(metadata['delay'], metadata['delay']/2))
                    metadata['delay'] /= 2
                return retval
            except botocore.exceptions.ClientError as e:
                if 'Throttling' in e.message:
                    if metadata['delay'] == 0:
                        metadata['delay'] = 1
                        app.logger.warn('Being rate-limited by AWS. Increasing delay from 0 to 1 second. Attempt {}'.format(metadata['count']))
                    elif metadata['delay']< 16:
                        metadata['delay'] *= 2
                        app.logger.warn('Still being rate-limited by AWS. Increasing delay to {} seconds. Attempt {}'.format(metadata['delay'], metadata['count']))
                    else:
                        raise e
                else:
                    raise e
            except boto.exception.BotoServerError as e:
                if  u'Rate exceeded' in e.message:
                    if metadata['delay'] == 0:
                        metadata['delay'] = 1
                        app.logger.warn('Being rate-limited by AWS. Increasing delay from 0 to 1 second. Attempt {}'.format(metadata['count']))
                    elif metadata['delay']< 16:
                        metadata['delay'] *= 2
                        app.logger.warn('Still being rate-limited by AWS. Increasing delay to {} seconds. Attempt {}'.format(metadata['delay'], metadata['count']))
                    else:
                        raise e
                else:
                    raise e

Looks like your code is a bit different:
            except BotoServerError as e:  # Boto
                if e.error_code == 'Throttling':

and
            except ClientError as e:  # Botocore
                if e.response["Error"] == "Throttling":

Could you update this and I can check on it on Monday?

I've had a look at the Boto and Botocore implementations:
Boto stores all sorts of information in a BotoServerError (like self.error_code, self.message etc.)
Botocore only stores the whole response as self.response
Turns out Botocore follows the structure of the AWS API it queries; response["error"] contains a dict of "Code" and "Message" so it should be used the same as in the implementation itself:
e.response['Error']['Code'] == "Throttling"
Your implementation with u'Rate exceeded' in e.message would also work because message includes the error code.
I will push a commit with amended code.


The browser session gets reset to login screen in few seconds frequently.

The browser session gets reset to login screen in few seconds frequently. We need to relogin frequently to view dashboard.

@karthikmsc05 what is the value set for auth.expirationTime= in your api.properties

@rvema Right now in api.properties i dont see auth.expirationTime= property is set. Please let me know if i need to set with what value ?


xz builds but doesn't work

A step I had a hard time with in making the Standalone was that xz builds but only does this:
xz: Error creating a pipe: Function not implemented

I was able to continue the process by using my system's xz. I couldn't see a way to blacklist the broken formula so I kind of had to manually delete it to keep other builders from using it.

Regarding #290 I also see that the executable permission is not set
[cavtools@vm lib]$ ls -l
total 436
-r--r--r-- 1 cavtools cavtools 280220 Apr 13 20:11 liblzma.a
lrwxrwxrwx 1 cavtools cavtools     16 Apr 13 20:11 liblzma.so -> liblzma.so.5.2.1
lrwxrwxrwx 1 cavtools cavtools     16 Apr 13 20:11 liblzma.so.5 -> liblzma.so.5.2.1
-r--r--r-- 1 cavtools cavtools 151544 Apr 13 20:11 liblzma.so.5.2.1
drwxr-xr-x 2 cavtools cavtools   4096 Apr 13 20:11 pkgconfig

Setting it does not solve my problem though.

Here's some strace
open("/home/cavtools/.linuxbrew/lib/libc.so.6", O_RDONLY|0x80000 /* O_??? */) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\266\2\2\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0555, st_size=1856344, ...}) = 0
mmap(NULL, 3655392, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x2b1644554000
mprotect(0x2b16446c8000, 2093056, PROT_NONE) = 0
mmap(0x2b16448c7000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x173000) = 0x2b16448c7000
mmap(0x2b16448cd000, 14048, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x2b16448cd000
close(3)                                = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2b16448d1000
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x2b16448d2000
arch_prctl(ARCH_SET_FS, 0x2b16448d22c0) = 0
mprotect(0x2b16448c7000, 16384, PROT_READ) = 0
mprotect(0x2b164454e000, 4096, PROT_READ) = 0
mprotect(0x2b1644114000, 4096, PROT_READ) = 0
set_tid_address(0x2b16448d2590)         = 16698
set_robust_list(0x2b16448d25a0, 0x18)   = 0
futex(0x7fff319a23cc, FUTEX_WAKE_PRIVATE, 1) = 0
futex(0x7fff319a23cc, 0x189 /* FUTEX_??? */, 1, NULL, 2b16448d22c0) = -1 ENOSYS (Function not implemented)
rt_sigaction(SIGRTMIN, {0x2b164433cf24, [], SA_RESTORER|SA_SIGINFO, 0x2b1644345a40}, NULL, 8) = 0
rt_sigaction(SIGRT_1, {0x2b164433cf9e, [], SA_RESTORER|SA_RESTART|SA_SIGINFO, 0x2b1644345a40}, NULL, 8) = 0
rt_sigprocmask(SIG_UNBLOCK, [RTMIN RT_1], NULL, 8) = 0
getrlimit(RLIMIT_STACK, {rlim_cur=10240*1024, rlim_max=RLIM_INFINITY}) = 0
fcntl(0, F_GETFD)                       = 0
fcntl(1, F_GETFD)                       = 0
fcntl(2, F_GETFD)                       = 0
geteuid()                               = 1002
syscall_293(0x6133c8, 0x800, 0, 0x2b16441164b0, 0x4095d8, 0x2b1643f04cd4, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0) = -1 (errno 38)
write(2, "xz: ", 4xz: )                     = 4
write(2, "Error creating a pipe: Function "..., 47Error creating a pipe: Function not implemented) = 47
write(2, "\n", 1
)                       = 1
exit_group(1)                           = ?

You can see my system strace can't really trace the Standalone libc very well. Maybe tools like strace could be included in the Standalone too? Probably trying to do something my kernel doesn't support but hard to tell. xz's config tests should be able to figure out the system capabilities but a linuxbrew/centos5 frankenstein may be past the limits of what it expects.

All I can say is that it's a call to pipe2 which was a very new feature when kernel 2.6.18 was released in September 2006 and has seen a lot of patches since.
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/fs/pipe.c?ofs=50

What version of the Linux kernel are you running? You can try brew edit glibc and adding a --enable-kernel=x.y.z to the configure options.
http://www.gnu.org/software/libc/manual/html_node/Configuring-and-compiling.html

I see. It doesn't actually do the check in configure. Needs some more things installed and probably to call one of the autotools I know so little about.

Thanks for enable-kernel. I will try it. I'm surprised the glibc build isn't smart enough to detect the running kernel.

enable-kernel seems like a great idea and should go in the wiki. However, in this case it did not help.

Another idea is to install autoconf, automake and gettext so you can run ./autogen.sh. This also failed to help.

My next idea is to savagely expunge the pipe2 check from the configure file. I don't think this kind of patch can integrate with a build system like homebrew.
It works!
The offending code in configure is:
# These are nice to have but not mandatory.
for ac_func in posix_fadvise pipe2
do :
  as_ac_var=`$as_echo "ac_cv_func_$ac_func" | $as_tr_sh`
ac_fn_c_check_func "$LINENO" "$ac_func" "$as_ac_var"
if eval test \"x\$"$as_ac_var"\" = x"yes"; then :
  cat >>confdefs.h <<_ACEOF
#define `$as_echo "HAVE_$ac_func" | $as_tr_cpp` 1
_ACEOF

fi
done

The bug is upstream. Either in xz or autotools or both.

Cool! That's really good to know. Red Hat / CentOS / Fedora have been known to occasionally introduce non-binary compatible patches into the kernel. That may be a possibility here. You can try replacing the Linuxbrew version of linux-headers with your particular version.

Replacing linux-headers turns out to not be what you want:
What version of the Linux kernel headers should be used?
The headers from the most recent Linux kernel should be used. The headers used while compiling the GNU C library and the kernel binary used when using the library do not need to match. The GNU C library runs without problems on kernels that are older than the kernel headers used. The other way round (compiling the GNU C library with old kernel headers and running on a recent kernel) does not necessarily work as expected. For example you can't use new kernel features if you used old kernel headers to compile the GNU C library.
Even if you are using an older kernel on your machine, we recommend you compile GNU libc with the most current kernel headers. That way you won't have to recompile libc if you ever upgrade to a newer kernel. To tell libc which headers to use, give configure the --with-headers switch (e.g. --with-headers=/usr/src/linux-3.3/include).
To install Linux kernel headers, run make header_install in the kernel source tree. This is described in the kernel documentation.
https://sourceware.org/glibc/wiki/FAQ#What_version_of_the_Linux_kernel_headers_should_be_used.3F

Are you sure this is closed? Yes, the bug is upstream, but it needs to be reported (I'm not sure to whom) and meanwhile patched in homebrew.

Which version of the Linux kernel are you using? Please report uname -a
This issue is closed in that I don't really have the time myself to troubleshoot it, but I'm glad that you found a workaround. If you find a solution, please open a pull request.

Linux vm 2.6.18-404.el5 #1 SMP Tue Apr 7 12:42:54 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
I can patch the formula to fix it if you could suggest how I can ask homebrew to detect a specific kernel version. (I don't know ruby, but was able to muddle through the instructions on how to add a patch.)

2.6.18 should work (though it seems not to). The servers I use at work are running CentOS 5.10
$ echo hello >hi
$ tar cf hi.tar hi
$ xz hi.tar
$ tar xfO hi.tar.xz
hello
$ uname -a
Linux xhost11 2.6.18-371.1.2.el5 #1 SMP Tue Oct 22 12:51:53 EDT 2013 x86_64 GNU/Linux
$ tar --version
tar (GNU tar) 1.28
$ xz --version
xz (XZ Utils) 5.2.0
liblzma 5.2.0
```

Maybe it's a very recently introduced bug? I brewed xz 5.2.1.
We are really in the same boat having to live with old Linux until Redhat says it can die. Thanks for taking charge and doing something about it.

Yes!  Sorry that I didn't catch this issue earlier. It looks like an upstream xz bug then?
$ /gsc/btl/linuxbrew/Cellar/xz/5.2.1/bin/xz --version
/gsc/btl/linuxbrew/Cellar/xz/5.2.1/bin/xz: Error creating a pipe: Function not implemented

Here's the workaround to install xz 5.2.0:
https://raw.githubusercontent.com/Homebrew/linuxbrew/a51741bc83fa5af3644ce3413b0cfcef76f91952/Library/Formula/xz.rb

@gitfoxi Would you be able to open an issue with the upstream xz authors?

I e-mailed the author and he says it will be fixed in subsequent xz.
Lasse Collin
Apr 20 (7 days ago)
to me
On 2015-04-16 Michael Fox wrote:

Recent releases of xz build under kernel 2.6.18 but fail to
run because the kernel has not implemented pipe2 (even though the
call exists it doesn't work).

Thanks for the bug report.
Since pipe2() isn't important to xz, I reverted the commit that added
it so the next release won't try to use it.

Great! Thanks.


Verify Account bug

Hi,
problem after i am verified i can then edit my identity, (https://domainname.com/id_document/edit)

https://domainname.com/id_document/edit

What is exactly the problem/bug?

I want to know that your trade floor can run?

wyj1226 yes can run
maffeprog problem is a security bug (missing code)
after i am verified i can then edit my identity

yes problem after i am verified i can then edit my identity

Okay, what will be the solution of it. Should we allow user to edit information or just not allow them, if the status is verified? What will be the best solution of this issue. I have checked and confirm that this bug actually exist in the system.

A solution should be to disable to edit information for name and age because this can't change. And the others should be possible to change if you change from address. But I think when it added it should be verified again.

If the change is made now, it will not be noticed by the admin.

@muhammednagy

class IdDocument < ActiveRecord::Base
extend Enumerize
include AASM
include AASM::Locking
has_one :id_document_file, class_name: 'Asset::IdDocumentFile', as: :attachable
accepts_nested_attributes_for :id_document_file
has_one :id_bill_file, class_name: 'Asset::IdBillFile', as: :attachable
accepts_nested_attributes_for :id_bill_file
belongs_to :member
validates_presence_of :name, :id_document_type, :id_document_number, :id_bill_type, allow_nil: true
validates_uniqueness_of :member
enumerize :id_document_type, in: {id_card: 0, passport: 1, driver_license: 2}
enumerize :id_bill_type,     in: {bank_statement: 0, tax_bill: 1}
alias_attribute :full_name, :name
aasm do
state :unverified, initial: true
state :verifying
state :verified
event :submit do
  transitions from: :unverified, to: :verifying
end

event :approve do
  transitions from: [:unverified, :verifying],  to: :verified
end

event :reject do
  transitions from: [:verifying, :verified],  to: :unverified
end

end
end

if the status is verified? He should not make a change.

help me