Where are the build instructions?

Where are the instructions on how to build hermes?  Tried the following on MacOS Monterey 12.6
👍
% cabal --version
cabal-install version <IP_ADDRESS>
% cabal update
Downloading the latest package list from hackage.haskell.org
Package list of hackage.haskell.org has been updated.
The index-state is set to 2022-10-10T16:14:10Z.
To revert to previous state run:
cabal v2-update 'hackage.haskell.org,2022-01-03T18:47:46Z'
gregory@our-imac hermes % cabal build
Resolving dependencies...
Error: cabal: Could not resolve dependencies:
[__0] trying: hermes-json-<IP_ADDRESS> (user goal)
[__1] next goal: base (dependency of hermes-json)
[__1] rejecting: base-<IP_ADDRESS>/installed-<IP_ADDRESS> (conflict: hermes-json =>
base>=4.13 && <4.17)
[__1] skipping: base-<IP_ADDRESS> (has the same characteristics that caused the
previous version to fail: excluded by constraint '>=4.13 && <4.17' from
'hermes-json')
[__1] rejecting: base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>,
base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>, base-<IP_ADDRESS>
(constraint from non-upgradeable package requires installed instance)
[__1] fail (backjumping, conflict set: base, hermes-json)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: base, hermes-json

What version of GHC are you using?

Thanks for the quick response !
% ghc --version
The Glorious Glasgow Haskell Compilation System, version 9.4.1

On Oct 10, 2022, at 12:33 PM, Josh Miller @.***> wrote:
What version of GHC are you using?
—
Reply to this email directly, view it on GitHub https://github.com/velveteer/hermes/issues/15#issuecomment-1273626971, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFB7CS6LQC5JBTBWRSI7UILWCRHOFANCNFSM6AAAAAARBQXTC4.
You are receiving this because you authored the thread.

I haven't yet updated and released hermes-json to support 9.4.1 (base-<IP_ADDRESS>). If you can use GHC 9.2.4 that should still work on Monterey 12.6. In the meantime I will look into getting 9.4.1 support into the next release.

Thanks.  I changed the hermes-json.cabal at line 62. It appears to build.
from 	base               >= 4.13 && < 4.17
to:	base               >= 4.13,
output:
@.*** hermes % cabal build
Resolving dependencies...
Build profile: -w ghc-9.4.1 -O1
In order, the following will be built (use -v for more details):

base-compat-0.12.2 (lib) (requires download & build)
base-orphans-0.8.7 (lib) (requires download & build)
dlist-1.0 (lib) (requires build)
hashable-<IP_ADDRESS> (lib) (requires download & build)
unliftio-core-<IP_ADDRESS> (lib) (requires download & build)
integer-logarithms-<IP_ADDRESS> (lib) (requires build)
primitive-<IP_ADDRESS> (lib) (requires download & build)
attoparsec-0.14.4 (lib:attoparsec-internal) (requires download & build)
base-compat-batteries-0.12.2 (lib) (requires download & build)
time-compat-<IP_ADDRESS> (lib) (requires build)
async-2.2.4 (lib) (requires download & build)
scientific-<IP_ADDRESS> (lib) (requires build)
unliftio-<IP_ADDRESS> (lib) (requires download & build)
attoparsec-0.14.4 (lib) (requires download & build)
attoparsec-iso8601-<IP_ADDRESS> (lib) (requires download & build)
hermes-json-<IP_ADDRESS> (lib) (first run)
Downloading  base-orphans-0.8.7
Starting     dlist-1.0 (lib)
Downloaded   base-orphans-0.8.7
Downloading  unliftio-core-<IP_ADDRESS>
Starting     base-orphans-0.8.7 (lib)
Downloaded   unliftio-core-<IP_ADDRESS>
Downloading  primitive-<IP_ADDRESS>
Downloaded   primitive-<IP_ADDRESS>
Downloading  base-compat-0.12.2
Downloaded   base-compat-0.12.2
Downloading  base-compat-batteries-0.12.2
Starting     base-compat-0.12.2 (lib)
Downloaded   base-compat-batteries-0.12.2
Downloading  hashable-<IP_ADDRESS>
Downloaded   hashable-<IP_ADDRESS>
Downloading  async-2.2.4
Starting     hashable-<IP_ADDRESS> (lib)
Downloaded   async-2.2.4
Downloading  unliftio-<IP_ADDRESS>
Downloaded   unliftio-<IP_ADDRESS>
Downloading  attoparsec-0.14.4
Downloaded   attoparsec-0.14.4
Downloading  attoparsec-iso8601-<IP_ADDRESS>
Downloaded   attoparsec-iso8601-<IP_ADDRESS>
Building     hashable-<IP_ADDRESS> (lib)
Building     base-orphans-0.8.7 (lib)
Building     base-compat-0.12.2 (lib)
Building     dlist-1.0 (lib)
Installing   hashable-<IP_ADDRESS> (lib)
Installing   dlist-1.0 (lib)
Installing   base-orphans-0.8.7 (lib)
Completed    hashable-<IP_ADDRESS> (lib)
Starting     unliftio-core-<IP_ADDRESS> (lib)
Completed    dlist-1.0 (lib)
Starting     integer-logarithms-<IP_ADDRESS> (lib)
Completed    base-orphans-0.8.7 (lib)
Starting     primitive-<IP_ADDRESS> (lib)
Building     integer-logarithms-<IP_ADDRESS> (lib)
Building     unliftio-core-<IP_ADDRESS> (lib)
Building     primitive-<IP_ADDRESS> (lib)
Installing   unliftio-core-<IP_ADDRESS> (lib)
Completed    unliftio-core-<IP_ADDRESS> (lib)
Starting     attoparsec-0.14.4 (lib:attoparsec-internal)
Building     attoparsec-0.14.4 (lib:attoparsec-internal)
Installing   integer-logarithms-<IP_ADDRESS> (lib)
Completed    integer-logarithms-<IP_ADDRESS> (lib)
Starting     async-2.2.4 (lib)
Building     async-2.2.4 (lib)
Installing   attoparsec-0.14.4 (lib:attoparsec-internal)
Completed    attoparsec-0.14.4 (lib:attoparsec-internal)
Starting     time-compat-<IP_ADDRESS> (lib)
Building     time-compat-<IP_ADDRESS> (lib)
Installing   async-2.2.4 (lib)
Installing   base-compat-0.12.2 (lib)
Completed    async-2.2.4 (lib)
Starting     unliftio-<IP_ADDRESS> (lib)
Completed    base-compat-0.12.2 (lib)
Starting     base-compat-batteries-0.12.2 (lib)
Building     unliftio-<IP_ADDRESS> (lib)
Building     base-compat-batteries-0.12.2 (lib)
Installing   time-compat-<IP_ADDRESS> (lib)
Completed    time-compat-<IP_ADDRESS> (lib)
Installing   primitive-<IP_ADDRESS> (lib)
Completed    primitive-<IP_ADDRESS> (lib)
Starting     scientific-<IP_ADDRESS> (lib)
Building     scientific-<IP_ADDRESS> (lib)
Installing   unliftio-<IP_ADDRESS> (lib)
Completed    unliftio-<IP_ADDRESS> (lib)
Installing   scientific-<IP_ADDRESS> (lib)
Completed    scientific-<IP_ADDRESS> (lib)
Starting     attoparsec-0.14.4 (lib)
Building     attoparsec-0.14.4 (lib)
Installing   base-compat-batteries-0.12.2 (lib)
Completed    base-compat-batteries-0.12.2 (lib)
Installing   attoparsec-0.14.4 (lib)
Completed    attoparsec-0.14.4 (lib)
Starting     attoparsec-iso8601-<IP_ADDRESS> (lib)
Building     attoparsec-iso8601-<IP_ADDRESS> (lib)
Installing   attoparsec-iso8601-<IP_ADDRESS> (lib)
Completed    attoparsec-iso8601-<IP_ADDRESS> (lib)
Configuring library for hermes-json-<IP_ADDRESS>..
Preprocessing library for hermes-json-<IP_ADDRESS>..
Building library for hermes-json-<IP_ADDRESS>..
[ 1 of 10] Compiling Data.Hermes.SIMDJSON.Types ( src/Data/Hermes/SIMDJSON/Types.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/SIMDJSON/Types.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/SIMDJSON/Types.dyn_o )
[ 2 of 10] Compiling Data.Hermes.SIMDJSON.Bindings ( src/Data/Hermes/SIMDJSON/Bindings.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/SIMDJSON/Bindings.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/SIMDJSON/Bindings.dyn_o )
[ 3 of 10] Compiling Data.Hermes.SIMDJSON.Wrapper ( src/Data/Hermes/SIMDJSON/Wrapper.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/SIMDJSON/Wrapper.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/SIMDJSON/Wrapper.dyn_o )
[ 4 of 10] Compiling Data.Hermes.SIMDJSON ( src/Data/Hermes/SIMDJSON.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/SIMDJSON.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/SIMDJSON.dyn_o )
[ 5 of 10] Compiling Data.Hermes.Decoder.Types ( src/Data/Hermes/Decoder/Types.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder/Types.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder/Types.dyn_o )
[ 6 of 10] Compiling Data.Hermes.Decoder.Path ( src/Data/Hermes/Decoder/Path.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder/Path.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder/Path.dyn_o )
[ 7 of 10] Compiling Data.Hermes.Decoder.Value ( src/Data/Hermes/Decoder/Value.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder/Value.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder/Value.dyn_o )
[ 8 of 10] Compiling Data.Hermes.Decoder.Time ( src/Data/Hermes/Decoder/Time.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder/Time.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder/Time.dyn_o )
[ 9 of 10] Compiling Data.Hermes.Decoder ( src/Data/Hermes/Decoder.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes/Decoder.dyn_o )
[10 of 10] Compiling Data.Hermes      ( src/Data/Hermes.hs, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes.o, /Users/gregory/Haskell/hermes/dist-newstyle/build/x86_64-osx/ghc-9.4.1/hermes-json-<IP_ADDRESS>/build/Data/Hermes.dyn_o )
ld: warning: -undefined dynamic_lookup may not work with chained fixups

On Oct 10, 2022, at 12:44 PM, Josh Miller @.***> wrote:
I haven't yet updated and released hermes-json to support 9.4.1 (base-<IP_ADDRESS>). If you can use GHC 9.2.4 that should still work on Monterey 12.6. In the meantime I will look into getting 9.4.1 support into the next release.
—
Reply to this email directly, view it on GitHub https://github.com/velveteer/hermes/issues/15#issuecomment-1273637678, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFB7CS4XIIM4IICN2RZ7EMLWCRIZPANCNFSM6AAAAAARBQXTC4.
You are receiving this because you authored the thread.

I've released https://hackage.haskell.org/package/hermes-json-<IP_ADDRESS>, which includes support for GHC 9.4.1. Thanks for reporting this!

Wonderful!Sent from my Verizon, Samsung Galaxy smartphone
-------- Original message --------From: Josh Miller @.> Date: 10/10/22  2:05 PM  (GMT-06:00) To: velveteer/hermes @.> Cc: Greg @.>, Author @.> Subject: Re: [velveteer/hermes] Where are the build instructions? (Issue #15)
I've released https://hackage.haskell.org/package/hermes-json-<IP_ADDRESS>, which includes support for GHC 9.4.1. Thanks for reporting this!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


update recipe

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I rerendered the feedstock and it seems to be already up-to-date.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Do not merge this one yet. I want to get a new 2.8.1 out first.

Do not merge this one yet. I want to get a new 2.8.1 out first.

I'll do that in a branch in case we need to tweak it.


WIP: go_1_11: Remove GOARM

Motivation for this change
According to https://github.com/golang/go/wiki/GoArm GOARM is allowed to be just one of 5,6 or 7.
It is recommended to aways set it in order to support cross compilation.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

Failure on x86_64-darwin (full log)
Attempted: go_1_11
Partial log (click to expand)
ok      cmd/vendor/golang.org/x/arch/arm64/arm64asm     0.161s
ok      cmd/vendor/golang.org/x/arch/ppc64/ppc64asm     0.007s
ok      cmd/vendor/golang.org/x/arch/x86/x86asm 0.064s
ok      cmd/vendor/golang.org/x/crypto/ssh/terminal     0.017s
ok      cmd/vendor/golang.org/x/sys/unix        0.377s
ok      cmd/vet 3.627s
ok      cmd/vet/internal/cfg    0.006s
2018/09/04 12:06:48 Failed: exit status 1
builder for '/nix/store/3mw5gby3yh54dfb6agx3d22m1f5zlyn9-go-1.11.drv' failed with exit code 1
error: build of '/nix/store/3mw5gby3yh54dfb6agx3d22m1f5zlyn9-go-1.11.drv' failed

Success on aarch64-linux (full log)
Attempted: go_1_11
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/z9mzx3049zakmc172ir75h3r1bwp6lf4-go-1.11

Success on aarch64-linux (full log)
Attempted: go_1_11
Partial log (click to expand)
these derivations will be built:
  /nix/store/c580lws68rjz9pfqc7lxzx4g3calw9sa-go-1.11.drv
waiting for locks or build slots...
/nix/store/z9mzx3049zakmc172ir75h3r1bwp6lf4-go-1.11

@GrahamcOfBorg build go_1_11

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: go_1_11
Partial log (click to expand)
Cannot nix-instantiate `go_1_11' because:
error: while evaluating the attribute 'GOARM' of the derivation 'go-1.11' at /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/pkgs/stdenv/generic/make-derivation.nix:179:11:
while evaluating the attribute 'lib.intersectList' at /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/pkgs/stdenv/generic/default.nix:139:14:
attribute 'intersectList' missing, at /var/lib/gc-of-borg/nix-test-rs-19/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-19/pkgs/development/compilers/go/1.11.nix:142:21

Success on x86_64-linux (full log)
Attempted: go_1_11
Partial log (click to expand)
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/p3ab4gfq0ml7v6mb8gw3hjnpjbnxgbqq-go-1.11

@GrahamcOfBorg build go_1_11

Success on x86_64-linux (full log)
Attempted: go_1_11
Partial log (click to expand)
/nix/store/jv4v9wq201dpiydisbvwdvam8c40sjb3-go-1.11

Success on x86_64-linux (full log)
Attempted: go_1_11
Partial log (click to expand)
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/p3ab4gfq0ml7v6mb8gw3hjnpjbnxgbqq-go-1.11

Success on x86_64-darwin (full log)
Attempted: go_1_11
Partial log (click to expand)

ALL TESTS PASSED
---
Installed Go for darwin/amd64 in /nix/store/jj7c5kwmlkrhfvkfckbgh7j3aidrdy5z-go-1.11/share/go
Installed commands in /nix/store/jj7c5kwmlkrhfvkfckbgh7j3aidrdy5z-go-1.11/share/go/bin
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jj7c5kwmlkrhfvkfckbgh7j3aidrdy5z-go-1.11/bin
patching script interpreter paths in /nix/store/jj7c5kwmlkrhfvkfckbgh7j3aidrdy5z-go-1.11
/nix/store/jj7c5kwmlkrhfvkfckbgh7j3aidrdy5z-go-1.11

Success on aarch64-linux (full log)
Attempted: go_1_11
Partial log (click to expand)
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/li64kcqs4j0smv9y6a08zhax28gvizd3-go-1.11

/cc ZHF #45962
This should fix the massive go breakage on aarch.

Success on x86_64-darwin (full log)
Attempted: go_1_11
Partial log (click to expand)
these paths will be fetched (188.49 MiB download, 907.74 MiB unpacked):
  /nix/store/hl6lszwxw0irdcmlmgqrrg89q1zir8a7-go-1.11
copying path '/nix/store/hl6lszwxw0irdcmlmgqrrg89q1zir8a7-go-1.11' from 'https://cache.nixos.org'...
/nix/store/hl6lszwxw0irdcmlmgqrrg89q1zir8a7-go-1.11


Different pathname in runtime and static build

#450 Ok, I replicated this issue in my fork of react-static https://github.com/Balvajs/react-static/tree/leading-slash-bug
So if you run npm start and you go to /about, you can see console log of pathname /about, which is alright.  It’s the same console log, but it returns two different values.
Node: v9.7.1

The pathname you are referring to is coming from React Router's history object. Though I've never run into a problem with this, this is precisely why everywhere react-static consumes a path, it uses a normalizingcleanPath(pathname) function. If you are specifically and consistently needing to rely on it, then I would suggest you do the same. You could write your own, or you could use { cleanPath } from 'react-static'. Even so, I would like to know your use case too :). Either way, RS is unable to control that pathname value.

@tannerlinsley Please reopen this issue. The problem is, that if the pathname is different in static environment, even { Link } from 'react-static' is not se to active in generated HTML unless you provide custom isActive function.
As I said, the problem occurred when you introduced config.basePath, so I think it might be connected. And maybe, as you implied, the problem is caused by your cleanPath function. But it definitely is issue.
The last version I used without this issue was 5.2.0

You're right. Didn't notice the actual effects of this. How should we solve this?

I didn't go through RS code. I hoped that you could have better idea what is causing it 😃

I guess that change of trimSlashes in react-static/src/utils/shared.js to:
export function trimSlashes (str) {
  return str.replace(/^\/{1,}/g, '/').replace(/\/{1,}$/g, '')
}

can fix this issue, but I am not sure if it will not break something else

Yeah, we could do that, but technically this wouldn't change the internal pathname that components like Link are using, etc.

Yes it does change the internal pathname. You can try it yourself as I did.
Just change trimSlashes function as I posted above, and then change for example react-static/test/stress-test-routes/src/About.js to:
import React from 'react'
import { withRouter, Link } from 'react-static'

export default withRouter(({ location: { pathname } }) => {
  console.log(pathname)
  return (
    <Link
      to={'/'}
      isActive={(match, location) => {
        console.log(location.pathname)
        return true
      }}
    >
      hello
    </Link>
  )
})

run npm run test-large-build and watch all these pathnames and also the location object from isActive function on <Link> with leading slash

I'm okay with that as long as we can confirm it doesn't break anything.
On Tue, Mar 13, 2018 at 2:35 PM Balvajs<EMAIL_ADDRESS>wrote:

Yes it does change the internal pathname. You can try it yourself as I did.
Just change trimSlashes function as I posted above, and then change for
example react-static/test/stress-test-routes/src/About.js to:
import React from 'react'import { withRouter, Link } from 'react-static'
export default withRouter(({ location: { pathname } }) => {
console.log(pathname)
return (
<Link
to={'/'}
isActive={(match, location) => {
console.log(location.pathname)
return true
}}
>
hello

)
})
run npm run test-large-build and watch all these pathnames and also the
location object from isActive function on  with leading slash
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/nozzle/react-static/issues/469#issuecomment-372809179,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCe1TlvCvAqx96Ex0yxuqfqv1HL59ks5teC13gaJpZM4SoYTR
.

Is there any progress with this issue? If you think about it, the only correct format of pathname is with leading slash. Using pathname the right way shouldn't break anything.

I would like to raise the severity of this issue. React 16 hydration does not fix the element attributes. When server-side renders the page, even though the local React starts working, the links and other custom <Route>-driven content do not show up correctly. This results in visual bugs that can only be caught in production, and only if one performs a full reload on every page, since the JS navigation does not expose this problem.

@denis-sokolov Are you still experiencing this problem?

⚠  Problem is still there for me with 5.7.5.
import { Route, Switch } from "react-static";

// When opened through the dev-server or by js navigation, renders good:
// When loaded from SSR, this renders bad:
<Switch>
  <Route exact path="/about" render={good} />
  <Route render={bad} />
</Switch>

// When loaded from SSR, this renders good:
<Switch>
  <Route exact path="about" render={good} />
  <Route render={bad} />
</Switch>

// My current workaround:
<Switch>
  <Route exact path="/about" render={good} />
  <Route exact path="about" render={good} />
  <Route render={bad} />
</Switch>

@denis-sokolov I found another workaround, you can set your own location object on <Switch>. It’s easier than creating 2 routes for every valid pathname.
<Switch location={{ ...location, pathname: location.pathname.replace(/^\/*/, '/') }}>
...
</Switch>

@tannerlinsley  I would like to say, that this issue is still there. Latest version without it was 5.2.0.


iOS8 UIActivityViewController problem on iPhone

iOS8 UIActivityViewController on iPhone is being shown behind AGWindowView

Among others. Won't fix.


Webjob published to a deployment slot fails to create/update schedule

For more details see this issue [http://stackoverflow.com/questions/31680673/azure-webjobs-publishing-error] , this has been around and not fixed since version 1.0.4 of WebJobs.Publish package for Visual Studio 2013 and for all versions of the package for VisualStudio 2015 as it refuses to work with package 1.0.3 which worked properly on Visual Studio 2013.

That logic is actually not part of Kudu (it relates to VS configuring the Azure Scheduler, which is a separate piece).
But note that for scheduling WebJobs, the recommended approach is to use the Kudu CRON scheduler instead of the Azure Scheduler. This solves all these issues. See doc for details.


Updated code to call the 'empty' function instead of doing direct comparison

Found three cases where the exact logic for the 'empty' function was being used directly in the code instead of a call to the 'empty' function and updated them.

Great catch! I don't know how I missed those, thanks. Will merge tonight.


Valid api_id must be provided.

The #35 is happening in version 1.8.21 again
[ 3][t 4][1700971024.492456197][Td.cpp:4112][#1][!Td][&td_requests]     Sending update: updateOption {
  name = "version"
  value = optionValueString {
    value = "1.8.21"
  }
}

setTdlibParameters {
  use_test_dc = false
  database_directory = ""
  files_directory = ""
  database_encryption_key = bytes [0] { }
  use_file_database = false
  use_chat_info_database = false
  use_message_database = false
  use_secret_chats = false
  api_id = 0
  api_hash = ""
  system_language_code = ""
  device_model = ""
  system_version = ""
  application_version = ""
  enable_storage_optimizer = false
  ignore_file_names = false
}

they are "" and 0 even when i set them manually.
is there any fix for this?

As I said here library currently supports only 1.8.0. You have two options:

use tdlib of version 1.8.0
wait for #38 to be merged (several days) or use a version from this branch directly. Take into account that tdlib a bit broke backward compatibility, look in the PR's examples. What also is broken - I don't know yet.

i just tried with the 1.8 and I got this :
DEBUG tdlib parameters set
DEBUG state changes handled properly
DEBUG received new auth state: UpdateAuthorizationState { extra: None, client_id: Some(1), authorization_state: WaitEncryptionKey(AuthorizationStateWaitEncryptionKey { extra: None, client_id: None, is_encrypted: false }) }
DEBUG handling new auth state: WaitEncryptionKey(AuthorizationStateWaitEncryptionKey { extra: None, client_id: None, is_encrypted: false })
INFO wait for client's encryption key
waiting for encryption key
[ 3][t 0][1700992099.440389156][Client.cpp:291][&td_requests]   End to wait for updates, returning object 0 (nil)
[ 3][t 0][1700992099.440802097][Client.cpp:278][&td_requests]   Begin to wait for updates with timeout 1.000000

and then nothing happens, just endless loop of Begin/End messages... weird

It tells you "waiting for encryption key" (BTW removed in 1.8.21)
Push "enter" here.
On Sun, Nov 26, 2023, at 10:50, Ali wrote:

i just tried with the 1.8 and I got this :
`DEBUG tdlib parameters set
DEBUG state changes handled properly
DEBUG received new auth state: UpdateAuthorizationState { extra: None, client_id: Some(1), authorization_state: WaitEncryptionKey(AuthorizationStateWaitEncryptionKey { extra: None, client_id: None, is_encrypted: false }) }
DEBUG handling new auth state: WaitEncryptionKey(AuthorizationStateWaitEncryptionKey { extra: None, client_id: None, is_encrypted: false })
INFO wait for client's encryption key
waiting for encryption key
[ 3][t 0][1700992099.440389156][Client.cpp:291][&td_requests]   End to wait for updates, returning object 0 (nil)
[ 3][t 0][1700992099.440802097][Client.cpp:278][&td_requests]   Begin to wait for updates with timeout 1.000000

`

and then nothing happens, just endless loop of Begin/End messages... weird
—
Reply to this email directly, view it on GitHub https://github.com/antonio-antuan/rust-tdlib/issues/37#issuecomment-1826737955, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRBAYCGRJLQO6HT3SQD3RDYGMGFNAVCNFSM6AAAAAA72RZZN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWG4ZTOOJVGU.
You are receiving this because you commented.Message ID: @.***>

Push "enter" here.

then it crashes  without asking for verification code. shouldn't it print something ? like enter the thing or whatever...

yes, this is how tdlib (c library) is implemented.
1.8.21 doesn't have this requirement - you don't need to enter encryption key at all. if I'm not mistaken it become a parameter of setTdlibParameters structure.

about "it crashes" - is there any output?

it dumped an error when unwraping the result of GetMe saying you are unauthorized, which was solved when i copy pasted this example.

So everything is fine? :)
On Sun, Nov 26, 2023, at 13:01, Ali wrote:

it dumped an error when unwraping the result of GetMe saying you are unauthorized, which was solved when i copy pasted this example https://github.com/antonio-antuan/rust-tdlib/blob/master/examples/auth_bot.rs.
—
Reply to this email directly, view it on GitHub https://github.com/antonio-antuan/rust-tdlib/issues/37#issuecomment-1826764669, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRBAYHW3LDN4OGF4S6SKUTYGMVQTAVCNFSM6AAAAAA72RZZN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWG43DINRWHE.
You are receiving this because you commented.Message ID: @.***>

one more thing, its not related to this issue tho but im not sure if i should open another one.
when I tried to Ping a proxy, after half a second it returned "time out on send operation", without aborting or anything, it just kept saying it, and the proxy was fine tho, is this behaviour from tdlib or this crate?

So everything is fine? :)

kinda yes, however im not sure what solved the issue or how it happend, but its gone for now, LoL

one more thing, its not related to this issue tho but im not sure if i should open another one.
when I tried to Ping a proxy, after half a second it returned "time out on send operation", without aborting or anything, it just kept saying it, and the proxy was fine tho, is this behaviour from tdlib or this crate?

This is a part of api.rs. Everything in that file is generated from td_api.tl (of particular version). Therefore - this is a part of tdlib implementation.

its weird, is it possible to somehow cancel the operation? its blocks the process unfortunately and doesnt return anything

Could you provide your code?
On Sun, Nov 26, 2023, at 13:29, Ali wrote:

its weird, is it possible to somehow cancel the operation? its blocks the process unfortunately and doesnt return anything
—
Reply to this email directly, view it on GitHub https://github.com/antonio-antuan/rust-tdlib/issues/37#issuecomment-1826771251, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRBAYCQJR36NZZIHYEOYODYGMY3TAVCNFSM6AAAAAA72RZZN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWG43TCMRVGE.
You are receiving this because you commented.Message ID: @.***>

tdjson::set_log_verbosity_level(2);
let tdlib_parameters = TdlibParameters::builder()
    .database_directory("tddb")
    .use_test_dc(false)
    .api_id(api_id)
    .api_hash(api_hash)
    .system_language_code("en")
    .device_model("Desktop")
    .system_version("Unknown")
    .application_version(env!("CARGO_PKG_VERSION"))
    .enable_storage_optimizer(true)
    .build();

let (sender, mut receiver) = tokio::sync::mpsc::channel::<Box<Update>>(100);

let client = Client::builder()
    .with_tdlib_parameters(tdlib_parameters)
    .with_updates_sender(sender)
    .with_client_auth_state_handler(ConsoleClientStateHandlerIdentified::new(ClientIdentifier::PhoneNumber(phone) ))
    .build()
    .unwrap();

let mut worker = Worker::builder()
    .with_auth_state_handler(AuthStateHandlerProxy::default())
    .build()
    .unwrap();
worker.start();

let client = worker.bind_client(client).await.unwrap();

let me1 = client.get_me(GetMe::builder().build()).await.unwrap();
log::info!("me: {:?}", me1);

// id :3
/*    let proxy = client.add_proxy(AddProxy::builder()
    .server("<IP_ADDRESS>")
    .port(8085)
    .type_(ProxyType::Mtproto(ProxyTypeMtproto::builder().secret("3QAAAAAAAAAAAAAAAAAAAAA=").build()))
    .enable(true)
    .build())
    .await;
*/

let seconds = client.ping_proxy(PingProxy::builder().proxy_id(3).build()).await; //blocks

println!("seconds: {:?}",seconds);

try to set_log_verbosity_level(3) and check what's happening there. probably tdlib provides significant logs for it.
you can run any async request with a timeout like I do here

with level 3 its generates a massive amount of irrelevant logs, take a look at this:
[ 3][t 4][1701064615.421191930][Td.cpp:4062][#1][!Td][&td_requests]     Sending update: updateUserFullInfo {
  user_id =<PHONE_NUMBER>
  user_full_info = userFullInfo {
    photo = null
    is_blocked = false
    can_be_called = false
    supports_video_calls = false
    has_private_calls = false
    has_private_forwards = false
    need_phone_number_privacy_exception = true
    bio = ""
    share_text = ""
    description = ""
    group_in_common_count = 0
    commands = vector[0] {
    }
  }
}
[ 3][t 4][1701064615.641546010][MessagesManager.cpp:28987][&notifications]      Pending notifications timeout in chat -1001260949088 has expired
[ 3][t 4][1701064615.641577005][MessagesManager.cpp:29075][#1][!MessagesManager][&notifications]        Have no pending notifications in chat -1001260949088 to flush
ERROR can't send update: timed out waiting on send operation
[ 3][t 0][1701064615.951704263][Client.cpp:278][&td_requests]   Begin to wait for updates with timeout 1.000000
[ 3][t 0][1701064615.951758146][Client.cpp:291][&td_requests]   End to wait for updates, returning object 0 0x7f2ff01594c0
[ 3][t 4][1701064616.091123104][QueryCombiner.cpp:49][#1][!GetChatFullCombiner] Send query -1001287519485

notice the timeout in between is happening for no reason.
here is the log_level(2) after logging-in and trying to GetMe:
DEBUG checking password
[ 2][t 4][1701064535.575283050][AuthDataShared.cpp:107][#1][!Session:4:main]    DcId{4} [auth_key_id:5718717466472171885][state:OK][created_at:1701064527.000000]
DEBUG password checked
DEBUG state changes handled properly
DEBUG received new auth state: UpdateAuthorizationState { extra: None, client_id: Some(1), authorization_state: Ready(AuthorizationStateReady { extra: None, client_id: None }) }
DEBUG handling new auth state: Ready(AuthorizationStateReady { extra: None, client_id: None })
DEBUG ready state received, send signal
DEBUG state changes handled properly
[ 2][t 4][1701064536.225793123][Session.cpp:169][#1][!SessionProxy:1:main]      Generate new session_id<PHONE_NUMBER>9560917073 for auth key<PHONE_NUMBER>9086141928 for DC1
[ 2][t 4][1701064537.167244195][AuthDataShared.cpp:107][#1][!Session:1:main]    DcId{1} [auth_key_id:10685133649086141928][state:OK][created_at:1701064524.000000]
ERROR can't send update: timed out waiting on send operation
ERROR can't send update: timed out waiting on send operation
ERROR can't send update: timed out waiting on send operation
ERROR can't send update: timed out waiting on send operation

i dont know maybe its because the version 1.8 is too old or something, I think the library is broken, it would be nice if someone could try out the code and see the results are the same...

I think I might be able to help if you could specify what needs to be done in #38

try that:
let mut worker = Worker::builder()
    .with_auth_state_handler(AuthStateHandlerProxy::default())
    .with_read_updates_timeout(10)
    .build()
    .unwrap();

probably it fixes the problem

probably it fixes the problem

i did not, same thing happened again

ok I have to dive deeply into it

I Noticed that when i removed the update handler .with_updates_sender(sender) the error never happened again

Yes, that's the reason of this error. So if you don't want to listen for updates - you can remove it. But if you do want - I have to fix it. Well, I anyway have to fix it...)
On Mon, Nov 27, 2023, at 11:03, Ali wrote:

I Noticed that when i removed the update handler .with_updates_sender(sender) the error never happened again
—
Reply to this email directly, view it on GitHub https://github.com/antonio-antuan/rust-tdlib/issues/37#issuecomment-1827519410, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRBAYGCBSK4QKGUB3LXJ7TYGRQONAVCNFSM6AAAAAA72RZZN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRXGUYTSNBRGA.
You are receiving this because you commented.Message ID: @.***>

let me know If I could help!

@MrAliSalehi sorry, was way too busy...
do you have a proxy to let me test it?

yes
https://t.me/proxy?server=<IP_ADDRESS>&port=7443&secret=AAAAAAAAAAAAAAAAAAAAACQ%3D

https://t.me/proxy?server=tootfarangii.com.who_bounty.ir.tvsam.ir.dikon.ir.mirashonar.ir.za_frantee.com.digicasebook.ir.1397.ir.tinos.ir.r_occotehran.com.sepano.org.ir.ne_wsan_jesh.com.pezhart.ir.napars.ir.offweb.ir.m_id_sabac.ir.daewoomarket.com.nikalyaf.com.parskhazarstore.sbs&port=443&secret=3dpBFlW2hP6Hq_WOwiNeKBY%3D

https://t.me/proxy?server=Cloudflare.com.Nokia.com.co.uk.do_yo.want_to.clash_wbth.this.www.microsoft.com.there_is_no.place_like.localhost.www.bing.com.count_with_me.cyou.net.now_sudo.rm.again_to_fight.everyone.i_am.the_internet.xnbk-n2kl.sbs.&port=7443&secret=AAAAAAAAAAAAAAAAAAAAABQ%3D

https://t.me/proxy?server=Cloudflare.com.Nokia.com.co.uk.do_yo.want_to.clash_with.this.www.microsoft.com.there_is_no.place_like.localhost.www.bing.com.count_with_me.cyou.net.now_sudo.rm.again_to_fight.everyone.i_am.the_internet.gluid-gowm.sbs.&port=3443&secret=AAAAAAAAAAAAAAAAAAAAAGQ%3D

I don't experience the same problem (but used proxies from here)
[2023-12-23T20:17:47Z WARN  read_updates] bind client
[2023-12-23T20:17:48Z WARN  read_updates] wait authorized
[2023-12-23T20:17:48Z WARN  read_updates] client authorized; can start interaction
[2023-12-23T20:17:49Z WARN  read_updates] proxy
[2023-12-23T20:17:49Z WARN  read_updates] proxy added, start ping
[2023-12-23T20:17:49Z WARN  read_updates] ping proxy: Ok(Seconds { extra: Some("197f7a86-05e1-489f-8f96-97c3c501bd0b"), client_id: Some(1), seconds: 0.101716 })

try the following code and please say if it helps. probably the reason is "wait_authorized" function call. also I used that rust-tdlib version (didn't have a chance to release it yet).
also note, the process stucls
PHONE=+999999999 RUST_LOG=warn VERBOSITY=1 API_ID=999999 API_HASH=hash cargo run
#[tokio::main]
async fn main() {
    tdjson::set_log_verbosity_level(
        std::env::var("VERBOSITY")
            .unwrap_or("1".to_string())
            .parse::<i32>()
            .unwrap(),
    );
    env_logger::init();
    let tdlib_parameters = SetTdlibParameters::builder()
        .database_directory("tddb")
        .use_test_dc(false)
        .api_id(std::env::var("API_ID").unwrap().parse::<i32>().unwrap())
        .api_hash(std::env::var("API_HASH").unwrap())
        .system_language_code("en")
        .device_model("Desktop")
        .system_version("Unknown")
        .application_version(env!("CARGO_PKG_VERSION"))
        .enable_storage_optimizer(true)
        .build();

    let (sender, mut receiver) = tokio::sync::mpsc::channel::<Box<Update>>(100);

    let client = Client::builder()
        .with_tdlib_parameters(tdlib_parameters)
        .with_updates_sender(sender)
        .with_auth_state_channel(10)
        .with_client_auth_state_handler(ConsoleClientStateHandlerIdentified::new(
            ClientIdentifier::PhoneNumber(std::env::var("PHONE").unwrap()),
        ))
        .build()
        .unwrap();

    tokio::spawn(async move {
        while let Some(message) = receiver.recv().await {
            log::info!("updates handler received {:?}", message);
        }
    });

    let mut worker = Worker::builder()
        .with_auth_state_handler(AuthStateHandlerProxy::default())
        .build()
        .unwrap();
    let waiter = worker.start();

    log::warn!("bind client");
    let client = match worker.bind_client(client).await {
        Ok(cl) => cl,
        Err(err) => {
            panic!("cannot bind client: {}", err)
        }
    };

    log::warn!("wait authorized");
    wait_authorized(&client, &worker).await;
    let me1 = client.get_me(GetMe::builder().build()).await.unwrap();
    log::info!("me: {:?}", me1);
    log::warn!("proxy");
    let proxy = client
        .add_proxy(
            AddProxy::builder()
                .server("<IP_ADDRESS>")
                .port(4443)
                .type_(ProxyType::Mtproto(
                    ProxyTypeMtproto::builder()
                        .secret("FgMBAgABAAH8AwOG4kw63Q==")
                        .build(),
                ))
                .enable(true)
                .build(),
        )
        .await
        .unwrap();
    log::warn!("proxy added, start ping");
    let seconds = client
        .ping_proxy(PingProxy::builder().proxy_id(proxy.id()).build())
        .await;
    log::warn!("ping proxy: {:?}", seconds);
    worker.stop();
    log::warn!("worker stopped");
    waiter.await.unwrap();
    log::warn!("exit");
}

async fn wait_authorized(client: &Client<TdJson>, worker: &Worker<AuthStateHandlerProxy, TdJson>) {
    loop {
        match worker.wait_auth_state_change(&client).await {
            Ok(res) => match res {
                Ok(state) => match state {
                    ClientState::Opened => {
                        log::warn!("client authorized; can start interaction");
                        break;
                    }
                    _ => {
                        panic!("client not authorized: {:?}", state);
                    }
                },
                Err((err, auth_state)) => {
                    panic!("cannot handle auth state: {} {:?}", err, auth_state);
                }
            },
            Err(err) => {
                panic!("cannot wait for auth state changes: {}", err);
            }
        }
    }
}

hi there
i got a question
would u please tell me in steps how i should install a mtproto proxy for telegram in ubuntu like this one below?
https://t.me/proxy?server=<IP_ADDRESS>&port=250&secret=FgMBAgABAAH8AwOG4kw63Q==
I read the comments above and install tdlib but know i don't understand what to do );

How do you want to use it? In your desktop client?)

yeah in desktop

This is not the right place to ask such a question)
Try to follow that link: https://github.com/telegramdesktop/tdesktop

No, I mean that I want to build proxies like that one I showed you above
I tried most of the scripts in github like this  https://github.com/seriyps/mtproto_proxy/tree/master  or this  https://github.com/TelegramMessenger/MTProxy  but niether one gives me a proxy with this secret: FgMBAgABAAH8AwOG4kw63Q==

I don't know, my library is not for that


fix(DropdownMenu/ContextMenu): improve generic types

🔗 Linked issue

❓ Type of change
Implements same type inference as #2482

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

I just tried it but it doesn't seem the types are well resolved 🤔

I think this is linked to what I had suggested for the CommandPalette here https://github.com/nuxt/ui/issues/2260#issuecomment-2441276593
If your items don't all have the icon property then it is expected for TS to warn you as you'd be trying to access a potentially non-existing property. It's possible to go around that in two different ways:

wrap it inside a v-if="'icon' in item" and then it'd work and infer types correctly;
turn the union into an intersection and then it'd work even without v-if

Should I go for the latter?

Yes I think that would be the most convenient 😊

So I decided to go for this "optional intersection" instead of just "intersection" for 2 reasons:

i thought it kind of defeats the purpose of type-safety to say that items all have the same properties when we know they don't;
there's also a scenario where two items have conflicting types for the same property such as [{ foo: 'foo' }, { foo: 2 }] which would, in the previous implementation result into having { foo: never };

So I think this new way of inferring the types is safer and handles conflicting types properly.

Do types work for you in this PR? I no longer have autocomplete on slots nor slot props 🤔


fix: Resolve merge conflicts

Hit this trying to read one of the affected articles. If I got the merge wrong, feel free to fix internally

There are a lot of deletions here - with no obvious contribution

@BenjaminArmstrong these are Git conflicts where this repo has run into trouble when you've merged branches or between your public and private repo.
EX: on https://docs.microsoft.com/en-ca/virtualization/windowscontainers/about/index
If you don't want to land this, please talk to your repo admin that handles your git syncing about fixes this as the content on these pages is broken because of it

@nschonni  @BenjaminArmstrong  Just to follow up on this, scooley overwrote the newly-released containers content, causing these merge conflicts. We believe it's that she didn't pull down from live to her branch before making changes and merging. I've now fixed all of the merge conflict-related issues. Please let me know if you see any additional ones. Thanks!

Thanks @eross-msft!
Looks like these files still have the merge conflicts

hyperv-samples/benarm-powershell/GuestNameCheck.ps1
hyperv-samples/benarm-powershell/README.md
virtualization/windowscontainers/quick-start/quick-start-windows-10-linux.md


Tileset Creation Testing #155

Last line of needs_tileset requires an additional test: should be:
return total_coords > pointcount_threshold or total_geometries > geometrycount_threshold or total_places > places_threshold, total_coords, total_geometries, total_places
I'll add it myself if you haven't started on reviewing this yet.

go ahead and add - I will work on previous first


BayesSearchCV returns a TypeError when starting a search on the 9th (0 indexed) subspace

TypeError: ufunc 'true_divide' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
search = {
'model': [RGFClassifier(loss = 'Log' ,n_jobs = 1,verbose = False, max_leaf = 2,n_estimators= 5)],
'model__learning_rate': Real(0.0001, 1, prior = 'uniform'),
'model__l2': Real( 1e-30, 10,prior = 'uniform'),
'model__algorithm': Categorical(["RGF","RGF_Opt"], transform = 'identity'),
'model__min_samples_leaf' : Integer(2, 20,transform = 'identity'),
'model__opt_interval' : Integer(50, 500, transform = 'identity')
}

opt = BayesSearchCV(
pipe,
search_spaces = search,
n_iter = 250,
verbose = 1,
cv = list(ps.split())
# (parameter space, # of evaluations)
)
Z = opt.fit(Input_Full_X,y)
Some debugging shows the error comes from this line "dists = pdist(X / length_scale, metric='euclidean') in /usr/local/lib/python3.6/site-packages/sklearn/gaussian_process/kernels.py
And its caused by this row  'model__algorithm': Categorical(["RGF","RGF_Opt"], transform = 'identity') in the search space having the transform = 'identity' , 'OneHot' does work.
This may not be a bug but better documentation around this error might be nice

@DNeems thanks for reporting this!

Is fixed in version 0.7


Add a detailed description of the "idleReplicaCount" field, along with an example.

Related to https://github.com/kedacore/keda/issues/2314, some people discussed there.
So, I gather the keypoint infomation and write it into the docs.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)

Fixes https://github.com/kedacore/keda/issues/2314

Is there somebody help me to review it ?

@zroubalik I have updated the code. Now it covers the version 2.9, 2.10, 2.11, 2.12, 2.13. Please review.


RDPConf is right. But turn off after 1 second of loading

Everything is normal in the settings. But I can't connect. It suddenly turns off after 1 second of loading.

Try:

Download RDP Wrapper 1.6.2 and extract this to any directory.
Place rdpwrap.ini in the same directory.
Open CMD as administrator
Execute this commands

cd C:\path\to\directory\
rdpwinst -u -k
rdpwinst -i

Enjoy!

Original message: https://t.me/rdpwrap/49131

Duplicate of https://github.com/stascorp/rdpwrap/issues/2529

One termsrv.dll version = ONE opened issue for one architecture.


Test DAJIN2 using the Build mappy on macOS ARM

📋 Description
Recently, Bioconda supports macOS ARM (osx-arm64).
https://github.com/bioconda/bioconda-recipes/pull/49275
Until v0.5.2, translations were done using Rosetta 2, but now we need to check if DAJIN2 runs natively on osx-arm64.
🔍 Environment
- DAJIN2 version: 0.5.2
- Python version: 3.10

📎 Anything else?
No response

ToDo

[ ] Upgrade to v0.5.3 on BioConda
[ ] Test installation and execution using M1 Mac Mini
[ ] (If it works) Update Installation of README.md

Test passed: https://github.com/akikuno/DAJIN2/actions/runs/10053078448


Referencing uaa.clients.login.secret in uaa.yml doesn't work since it isn't in spec

See: https://github.com/cloudfoundry/uaa-release/blob/develop/jobs/uaa/templates/uaa.yml.erb#L20
Referencing uaa.clients.login.secret using p() doesn't work if using job level properties because it isn't explicitly in the spec.  uaa.login.client_secret does work.

@youngm This seems more like a feature request for Bosh.

@sreetummidi No, it was a bug in UAA.  But not anymore now that uaa config has been refactored. :)


Rename DefaultPageSize => PagerSize

This was recently introduced. so no breaking change.
The thing is:

We do not commonly use the prefix Default* even if it can be overridden in the templates.
PagerSize makes more sense and is also the term used in the code.

Small detail, but the template pager method is PageSize, not PagerSize. Maybe we should change the method name as to match...it's a better name.

Good catch, fixed in c0ddcc5f27bb0d651b9806beac5926f30d3642ae


Simplify translation for looping traces

Assume that traces are always infinite through looping, simplify all translations accordingly.

Done in d65eca11c357b82f999ef2b01db11b4109085f2a.


[Typescript] setupTests.ts not being respecting

Is this a bug report?
Yes
Did you try recovering your dependencies?
No
Which terms did you search for in User Guide?
typescript, jest, setupTests
Environment
Environment:
OS:  Windows 10
Node:  9.11.2
Yarn:  1.12.1
npm:  6.4.1
Watchman:  Not Found
Xcode:  N/A
Android Studio:  Not Found
Packages: (wanted => installed)
react: ^16.6.0 => 16.6.0
react-dom: ^16.6.0 => 16.6.0
react-scripts: 2.1.1 => 2.1.1
Steps to Reproduce

npx create-react-app cra
cd cra
yarn add typescript @types/node @types/react @types/react-dom @types/jest enzyme enzyme-adapter-react-16 enzyme-to-json
Rename App.js, App.test.js, index.js, serviceWorker.js -> App.tsx, App.test.tsx, index.tsx, serviceWorker.ts
create setupTests.ts with:

import { configure } from 'enzyme';
import Adapter from 'enzyme-adapter-react-16';

configure({ adapter: new Adapter() });

export default undefined;

Add the following lines to App.test.tsx

import { shallow } from 'enzyme';

it('matches snapshot', () => {
  expect(shallow(<App />)).toMatchSnapshot();
});

Add the following to package.json

  "jest": {
    "snapshotSerializers": [
      "enzyme-to-json/serializer"
    ]
  }

yarn test

Expected Behavior
For Jest to create write __snapshots__/App.test.tsx.snap with a snapshot of <App />
Actual Behavior

● Validation Error:
Module /src/setupTests.js in the setupTestFrameworkScriptFile option was not found.
 is: (...dir...)
Configuration Documentation:
https://jestjs.io/docs/configuration.html
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Notes
Renaming setupTests.ts -> setupTests.js does work

This works for me, but we import a shared config (which is JS).
So, our setupTests.ts looks like:
import 'path-to-our-config/jest'; // a JavaScript file

We're facing the same issue, and it seems to happen on Windows only... works on my machine 😂

@fbarbare Looks like it's due to the pattern not accepting the Windows path separator. I submitted a pull request that fixes it.


Add cache_hits table to Clickhouse and update recordCacheHit function

Created a new table named cache_hits in Clickhouse, structured as follows:

request_id of type UUID,
organization_id of type Nullable UUID,
created_at of type DateTime64, with a default value set to the current time (DEFAULT now()).

Modified the recordCacheHit function to enable data insertion into Clickhouse as well.
Added organizationId for forwarder.ts
recordCacheHit gets its organizationId from forwarder.ts
If shouldSaveToCache, response.status === 200 and orgId not null save to KV cache.

additionally, instead of creating a DbWrapper, we should move the getAuthParams to the requestWrapper within this PR.

Good work on this PR @umuthopeyildirim, it is not an easy one

Removed bad anti-patterns and refactored cache_hits for clickhouse optimization.

LGTM!


Enclose with double quotation.

motion-appstore is asking my password every time.
Because my apple id is not an email and it's included a space; then it's divided two pieces.

Thanks :)

This would be shipped with motion-appstore v1.0.9.

Thanks


Build Portal (Wormhole) Subgraph

@dhruv-chauhan

PR: https://github.com/messari/subgraphs/pull/1718

QA here: https://github.com/messari/subgraphs/issues/1779


fix about me bug

Description
#85
Redirection to About section from navbar while on other pages does not work.
How i solved the problem and dependencies
npm install --save react-router-hash-link
import { HashLink } from 'react-router-hash-link';
About was added into the <Nav.Link>
Fixed #85
Type of change
Please check options that are relevant to your PR.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have pulled the latest changes in the repository
[x] I have squashed my commits
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@deeola Can you show a small video showing issue being fixed

@abhijeet007rocks8 the code or the solution?

working demo on localhost

https://user-images.githubusercontent.com/71495600/125572820-e192ef9f-cfc2-4b5a-98d1-782b7b249886.mp4
Hello, that is the link to the video


adding urban change

Proposed changes
A new Real_world_examples notebook that examines urban area through time to generate a map or urban-growth-hotspots
Checklist (replace [ ] with [x] to check off)

[X] Notebook created using the DEA-notebooks template
[X] Remove any unused Python packages from Load packages
[X] Remove any unused/empty code cells
[X] Remove any guidance cells (e.g. General advice)
[X] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
[X] Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
[X] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
[X] Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
[X] If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

This is such a cool notebook - can't believe how nicely the new areas of development pop out


Make Odb Send and Sync

As of libgit2 1.2.0, git_odb uses locking internally, and should be thread-safe. Mark it Send and Sync to allow access from multiple threads.

One day I will get the marker-trait impl syntax right on the first try. But it is not this day.

Also see https://github.com/libgit2/libgit2/pull/6109

@alexcrichton It has now been merged.


Save button not persisting the changes

To reproduce: with an existing blog post being written if a change is made to the template then click "Save" then click "Publish" the new update doesn't publish and it seems the save doesn't take. But if you click "Save" then go backbutton to view the list and then edit your page again it does appear to work. Smells like some timing or race condition issue


Rebuild Chart Object have NullReferenceException

check  "Rebuild Chart Object" button ,Console show :NullReferenceException: Object reference not set to an instance of an object,what happened ?

check your tmp font asset setting


Letters of credit network has no license checking

The letters of credit network has no license checking

closing as resolved.


[X] WSL 2
[ ] WSL 1

Kernel Version
No response
Distro Version
5.15.90
Other Software
No response
Repro Steps
Start ubuntu from terminal dropdown
Expected Behavior
To start wsl2 normally
Actual Behavior
https://github.com/microsoft/WSL/assets/63336944/ef99347d-a2cf-4e3d-9f52-213109b3a373
This happens only when I start wsl. After wsl is started cursor starts flickering and remaining space in C drive starts to decrease
Diagnostic Logs
No response

It went below 1G


Asus Z170-A Bios Help

System

Motherboard: Asus Z170 - A
BIOS Version: 3802
GPU: Intel A750
[ *] CSM is turned off. Make sure to confirm this in the BIOS and not with GPU-Z or similar since it can be inaccurate
[ *] 4G decoding is enabled. Make sure to confirm this in the BIOS and not with GPU-Z or similar since it can be inaccurate
[* ] UEFIPatch is applied (see Using UEFIPatch for more information). On some motherboards DSDT Patching is also needed
[* ] I have read Common issues (and fixes)

Description
I'm having a slight issue and I believe it's my own fault for not reading properly/ being an idiot. I've patched the bios after adding ReBarDxe.ffs. I'm unsure how to get the bios back into the .CAP format the bios requires as well I need some guidance flashing the bios after. System is: i5 6500, Asus Z170-A mobo, 32gb ram, intel A750 gpu. I appreciate any help.

Just rename the extension to cap...

I'm wrong. Manual calls CrashFree  Bios 3. I do apologise about that.

Manual says it's meant to. But there is no such switch on the back io panel

No need to apologize, I was just trying to point you to Flashback feature on your MB.
But...
After taking another look, it does have flashback feature, but only through internal connector on MB.
"Flash card" for that is sold separately it seems...

I can't seem to find said card either. Which is very odd.


Do you support row format other than Avro?

We are using Thrift and Json based sequence file here, is that easy to add support for that format as row format?

It should be, although have not tried it.. Merge on read, in general is under active development, so we can definitely make this work as needed..

Please re-open if you have any follow ups/ Thanks.


Harden runner log showing warnings instead of normal logs

I noticed here that normal logs are being shown as warnings:
https://github.com/miguelnietoa/stellar_sdk/runs/7881603461?check_suite_focus=true#step:20:4
This does not happen typically and I cannot find it for other runs. Here is a typical run: https://github.com/harden-runner-canary/dassana/runs/7880455490?check_suite_focus=true#step:12:4
@miguelnietoa thanks for using harden-runner! Do you have a configuration in your workflow that treats some kind of logs as warnings? I am trying to investigate why normal harden-runner logs are showing as warnings for your workflow run. If not, I will investigate further. Thanks!

@h0x0er can you please investigate this?

Hi @varunsh-coder  👋
I was investigating why this happens but have not yet found out why. I just have to say that this happens with this repository for the CI(test)/CD(publish) workflows, but not for the scorecards' workflow.
Scorecards' workflow URL: https://github.com/miguelnietoa/stellar_sdk/runs/7892093970?check_suite_focus=true ✅

I was trying it out in another repo and the logs are shown as normal, not as warnings.
https://github.com/miguelnietoa/editorjs-toggle-block/actions/runs/2878646179

Thanks for the info!

@varunsh-coder I continued my investigation and found that the warnings are occurring because of elixir. I am still unable to figure the root cause..
Checkout:
https://github.com/h0x0er/stellar_sdk/actions
https://github.com/h0x0er/elixir-warning-investigation/actions/runs/2901181399

I think it has to do with problem_matchers. Try to find out more about them.
https://github.com/erlef/setup-beam/blob/69fb25ba7e2c546dfc085871ecf2fc5382c9843d/src/setup-beam.js#L79
If you set disable_problem_matchers  to true, see if the issue goes away?

@varunsh-coder It worked !!

So we need to understand how to disable problem_matchers when post harden-runner step starts. Or may be there is a bug in the way they have enabled it, so the action owners need to fix it on their side?

Hi @miguelnietoa, I noticed that you added a wildcard to the allowed endpoint for Azure storage.
https://github.com/kommitters/editorjs-toggle-block/commit/d69e475439f02ac85eb47ac1311e6e66cb74daf9
harden-runner does not support wildcards in domain names. As a result, harden-runner is not working for these two workflows.
You can see this in the log here:
https://github.com/kommitters/editorjs-toggle-block/runs/8138266022?check_suite_focus=true#step:14:21
Can you please tell me why you wanted to use wildcard domain? The fixed domain you had earlier seemed to be working fine.   That endpoint is needed for cache and should be specific to your repo's workflows. Would be great if you can use the earlier fixed endpoint. Thanks!

Hi @varunsh-coder, thanks a lot!! ✨
I used wildcard domain to make it work for forks as well. But I will change it to the earlier fixed endpoint understanding this is repo specific. Thanks again. 💯

Thanks @miguelnietoa! We are working on a change where in the future harden-runner will automatically detect the cache endpoint. So then it will work fine on forks as well and will not need to be explicitly added to the allowed list. But until then whoever forks the repo will need to update the endpoint.

Hi @miguelnietoa,
I forgot to update you on the original issue. The reason the harden-runner logs were showing as warnings is because erlef/setup-beam (erlef/setup-elixir has been renamed I believe to erlef/setup-beam) GitHub Action adds problem_matchers. These are regular expressions and they were matching the timestamp added to harden-runner logs.
@h0x0er had also created an issue to discuss it.
There is nothing much we can do about this. If you do not need the warnings from erlef/setup-beam Action, you can set disable_problem_matchers to true. That will solve the problem.
Please let me know if you have any follow up questions...

Hi @miguelnietoa,
I forgot to update you on the original issue. The reason the harden-runner logs were showing as warnings is because erlef/setup-beam (erlef/setup-elixir has been renamed I believe to erlef/setup-beam) GitHub Action adds problem_matchers. These are regular expressions and they were matching the timestamp added to harden-runner logs.
@h0x0er had also created an issue to discuss it.
There is nothing much we can do about this. If you do not need the warnings from erlef/setup-beam Action, you can set disable_problem_matchers to true. That will solve the problem.
Please let me know if you have any follow up questions...

I have no further questions and leave it to your consideration whether this issue should be closed as it is outside the scope of harden-runner action.
Thanks for the research on this and bringing me up to speed!  @varunsh-coder @h0x0er 😄 💯

Thanks @miguelnietoa! I will go ahead and close the issue.


mocap_pose plugin changed to work with mocap4ros2

Basic Info

Info
Please fill out this column

Issue(s) this addresses
#270

ROS2 version tested on
Humble

Aerial platform tested on
Crazyflie

Description of contribution in a few bullet points

mocap_pose plugin changed to work with mocap4ros2
Added orientation smoother, needed to stable flights with Vicon

EDIT: Added parameters for smooth filter constants (speed and orientation). Default values in launcher are speed_alpha=0.1 and orientation_alpha=1.0 (filter disabled). If launcher is not used and node is executed standalone both filters will be disabled by default (aplha=1.0).

Description of documentation updates required from your changes

Since aerostack2/mocap_optitrack will be replaced with mocap4ros2, documentation should link how to launch a mocap4ros2 node

Future work that may be required in bullet points

Tested on a Vicon system only. Testing this with an Optitrack system before merging might be required
New parameter for orientation smoother -> alpha. If alpha=1.0, smoother will be disable.

PR frozen, waiting for https://github.com/MOCAP4ROS2-Project/mocap_msgs/issues/11 and https://github.com/MOCAP4ROS2-Project/mocap4ros2_vicon/pull/17

I think that we should wait for #MOCAP4ROS2/mocap_msgs/Issue11 to answer us before merging.

I think that we should wait for #MOCAP4ROS2/mocap_msgs/Issue11 to answer us before merging.

Yes, I completely agree. CI is not working due to missing mocap_msgs dependency

@fmrico @jmguerreroh could it be possible to release mocap_msgs package into rosdistro? If the project is not maintained anymore please let us know in order to search for alternative solutions. Thanks in advance.

@fmrico @jmguerreroh could it be possible to release mocap_msgs package into rosdistro? If the project is not maintained anymore please let us know in order to search for alternative solutions. Thanks in advance.

Hi @miferco97 @pariaspe,
We're sorry for the delay and assure you that mocap4ros2's inclusion in rosdistro is actively being worked on. We will let you know of any updates.
Thank you for your patience and support :)

@pariaspe @javilinos @RPS98 I think we should merge this and update our projects accordingly and test it. What do you think?

@pariaspe @javilinos @RPS98 I think we should merge this and update our projects accordingly and test it. What do you think?

Sure! Javi and I already did some updates in project_crazyflie and gates. I'll open a PR later on those repos

@pariaspe @javilinos @RPS98 I think we should merge this and update our projects accordingly and test it. What do you think?

Sure! I think we should merge the PRs for aerostack2, the projects mentioned in the documentation, and the documentation itself synchronously.
On the other hand, is it worth maintaining support for the old one? We could use templates to make it easier to change the message type.

Hi @javilinos,
Why are you merging this branch if the project's and documentation PRs aren't open?

Hi @javilinos,
Why are you merging this branch if the project's and documentation PRs aren't open?

Hi @RPS98 why is this branch not in draft if it cannot be merged?

Hi @javilinos,
Why are you merging this branch if the project's and documentation PRs aren't open?

Hi @RPS98 why is this branch not in draft if it cannot be merged?
@RPS98
I should have read deeper, I'm sorry, we have two public CF projects, we will make PRs asap :)

(for next time if we want to discuss on a branch that is not ready to be merged we should draft it)


Add version constraint (ddtrace < 1.0) to avoid incompatibility

This PR adds a temporal version constraint (ddtrace < 1.0) to avoid incompatibility of ddtrace 1.0 until this gem supports ddtrace 1.0.
Datadog has recently released ddtrace 1.0.
ddtrace 1.0 has some incompatibility with 0.x (Ref: https://github.com/DataDog/dd-trace-rb/releases/tag/v1.0.0), so some fixes to this gem are needed to support 1.0.

@munisystem please review this PR 🙏

@tomoasleep Looks good, thanks!

I released v0.1.2 that contains this change.


Fixes for Django 1.10 Warnings.

Fix deprecated use of url patterns and clean up code style.
Set a default for form_class parameter in get_form method.
Change required Django version to be less than 1.10.

Coverage decreased (-0.3%) to 78.31% when pulling 8658b26eee65e2074e98de1c955661aa8d02e678 on Tyndie:master into b5799f14f0ff0b8d914820f99302a8f8aae717fd on tarak:master.

Coverage decreased (-0.4%) to 78.184% when pulling 4ad75a1ec3a54f8b0cf20f299e0794d2f86df179 on Tyndie:master into b5799f14f0ff0b8d914820f99302a8f8aae717fd on tarak:master.


Shift flakey issue updates/notifications to Wednesday

I own a lot of tests, and would have more time to triage the notifications on Wednesday morning.

@zanderso does Tue. work for you? The metrics/slo review meeting is on Tue. afternoon, it would be helpful to know the flake status before the meeting.

Can you explain that in some more detail? My understanding is that infra flake metrics and the day that the bot files issues should be orthogonal. Even if there is a dependence, the infra metrics will be out of sync for only one week.
For context, I have meetings all day Monday, and other triage work and meetings on Tuesday, so I'm proposing Wednesday because that's the most realistic time for me to go over the issues.

Thanks for the context! I am moving it to Wed, as mentioned, the async is not a big thing.

Thanks!


Support some country that not supported youtube music

Some countries do not currently support youtube music. I tried using YTM_DOMAIN which is https://www.youtube.com, it works fine

Can you elaborate on this? The function you adjusted is just for grabbing the timestamps to retrieve valid stream urls. Information about Artist, Albums, Playlists, Tracks etc would still come from https://music.youtube.com, so I doubt that will work if YT Music is not supported in your country.

I checked that the youtube music api and youtube api seem to be the same, you can change the domain music.youtube.com to www.youtube.com and the results will be the same.
For example:

https://www.youtube.com/youtubei/v1/browse
https://music.youtube.com/youtubei/v1/browse

I can imagine they would be similar for 'music videos' that are coming from youtube, but what about actual music coming from https://music.youtube.com? Did you test this with for example with albums coming from YT Music (not youtube)?

But here I just use youtube domain instead of youtube music to get base.js file. All other functions use youtube music domain. I tested it and it works fine


feat(transformer): implement some of jsx decode entities

Current dependencies on/for this PR:

main

PR #1086   👈

This comment was auto-generated by Graphite.

Merge activity

Oct 29, 2:57 AM: @Boshen merged this pull request with Graphite.


generate HttpExchangeMetadata for generated files like .tgz for npm header check, and prevent NPE when nfc clearing

found some errors of this reporting when handle the npm stuff.

the commit in this PR: https://github.com/Commonjava/indy/pull/764/commits/2a95623cb6b47459583a885b49a700867bd6586c relys on galley PR: https://github.com/Commonjava/galley/pull/201

@jdcasey @ligangty I should make these two commits as seperated PR although the last npm stuff relys on the first fix, since we are on the edge of pnc release, so if any npm commit on the master is not reasonable, pls let me know, I'll change them accordingly.

retest this please

sorry I couldn't push the commits as seperated PRs, they have dependencies among them. for the last commit: https://github.com/Commonjava/indy/pull/764/commits/a4348e93557b5a6df2159985d0d01acb3519e337 , It's some bugs found for group path merging which I've mentioned before, it has no much relationship with the files and metadata generation for publish.
I haven't push the part of merging when publish, will push that later on.

@ligangty I just merged the conflicts for last commit, and just fixed the ftests failure, will push the fix later, after that I will push the commit according to the comments, I've not finalized them yet.

Sorry for the confusion guys. I guess I should have been more clear about the current status

@jdcasey wait for a while pls, I'm runing the build in local to ensure the success, updated code will be commited soon, which should cover most of the comments, I'll reply some concerns too, that's the final stuff.

@jdcasey @ligangty  I've pushed the final commit based on comments, and reply some of the concerns, I need to do a whole manual tests for per change to ensure the functions, so it's a bit slow. AFAIK it should have no points need to be fixed. Thanks.

I've pushed all the codes based on comments, thanks.

@ligangty I'm going to merge this, since your pending review above seems to be mostly related to static code safety stuff. If you still see things that need to be fixed, please bring it up and we can file another PR. It might need to go in a new issue too, just to keep our task list up to date.


Display of list of notifications in my account

Questions
Answers

Description?
This improves the display of the list of notifications in the customer account: fixes alignment and margin issues.

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/Prestashop#28217.

How to test?
Using this branch, go on the list of notifications page in FO see if everything looks fine

@szavadskiy

The text is not vertical aligned on center

Are you sure you tested the latest version? Since this commit, the text and the trash can are vertically centered.

The background of product block is not white
I changed section background to black.

I don't understand why you are doing this! The background of product block IS white because the <section id="main" IS white.

@szavadskiy @hibatallahAouadni
I got it. Both for the vertical alignment and the bg-color. I fixed it.

@szavadskiy Sorry for the delay. I hope this time everything will be OK.

Thanks @lmeyer1 & @szavadskiy & @hibatallahAouadni


Reintegrate dev/v0.8.2

Major changes:
T2Worker:

Added retry with backoff to handle processing t2s with dependencies in parallel
Improved performance with replicated Mongo clusters

AbsCoreCommand

Override config values with environment variables (e.g. for setting the Mongo URI)

JobCommand:

Use BaseModel instances to parse job file
Download input artifacts before executing tasks
Allow go-template-style expressions in tasks (powered by ExpressionParser)
Replace multiplier with expand_with to allow parallel task instances to be parameterised e.g. over a set of input files. Legacy job definitions with multiplier are still supported.
Added ProcessCommand, for executing only a single task from a job definition, e.g. for parallel execution across nodes

AmpelDB:

Read from secondaries of replica sets by default. This makes no difference for a standalone mongo, but improves find() and aggregate() performance (at the potential expense of consistency) in replicated clusters.

T3SimpleDataLoader:

pymongo 4.1 compatibility

T2Command:

use one_db for compatibility with ampel job

ConfigValidator:

remove special case for process_name (runtime-supplied fields are marked Traceless)

CompilerOptions:

reimplement as AuxAliasableModel to allow (validated) initialization from a name

T3DefaultBufferSupplier:

gracefully handle empty result set

T2Worker: ✔
AmpelDB: ✔
T3SimpleDataLoader: ✔
T3DefaultBufferSupplier: ✔
ConfigValidator: ✔
CompilerOptions: ✔
AbsCoreCommand: ✔ [Note: we should restrict this (and CLI overrides) in the future]

T2Command: use one_db for compatibility with ampel job
This should be an option, similar to Ampel-plot/ampel-plot-cli/ampel/cli/PlotCommand.py:62 (with a better description). I can add that later.

JobCommand:
Use BaseModel instances to parse job file.
Good, had this on my task list (Two side-remarks, I would prefer having the myriad of sub-models defined in their own file and  @validators be less used for future-proof reasons as the same effects can be obtained via classical/non-pydantic-specific ctors but that's just me being annoying)
Download input artifacts before executing tasks
Don't know what that means, but I trust it's the right thing to do
Allow go-template-style expressions in tasks (powered by ExpressionParser)
Still unsure about that, but it can be refined later
Replace multiplier with expand_with to allow parallel task instances to be parameterised e.g. over a set of input files
Great addition, thx
Added ProcessCommand, for executing only a single task from a job definition, e.g. for parallel execution across nodes
How does this differ from the -task # from JobCommand ?
Something else
A worry I have with the proposed JobCommand update is that the schema saved into the DB is the one pre-morphing with unresolved expressions:
https://github.com/AmpelProject/Ampel-core/blob/215f437b6aa8fff9eb41295b44631cd3bad68d1b/ampel/cli/JobCommand.py#L294-L299
whereas in the current master, the schema saved into the DB is the "final" one, after transformations.
https://github.com/AmpelProject/Ampel-core/blob/71a5cbbb4ca30beff36abcb1dcdb9d350fabb638/ampel/cli/JobCommand.py#L267-L272

T2Command: use one_db for compatibility with ampel job
This should be an option, similar to Ampel-plot/ampel-plot-cli/ampel/cli/PlotCommand.py:62 (with a better description). I can add that later.

Added in 15242791c4b0fa14043027a19ad73bfc8a29d5ba


[UI] UI hangs when attempting to clone a cluster role as Standard User

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

make a new Standard User
login as Standard User
go to Security > Roles > Cluster
go to menu for a role and select Clone

Result:
UI hangs. Console shows this error:

Other details that may be helpful:
Doesn't happen in Rancher v2.3.6
Doesn't appear to happen to Admin users

The bug is reproduced with Rancher server rancher\rancher:v2.4.2
Steps:
make a new Standard User
login as Standard User
go to Security > Roles > Cluster
go to menu for a role and select Clone
Result:
UI hangs with:

The bug fix is verified with Rancher server rancher\rancher:master-head version 03947c351 and rancher\rancher:v2.4-head version 03947c351
Result:
Add Cluster Role page can be accessed:


Tesseract

I use tesseract.
Can I use PRLib's Thinning algorithm by preprocessing of Tesseract ocr Lib ?
Can I use the Thinning algorithm with Tesseract preprocessing?

Yes, you can. That's exactly the original purpose of the library. WIth PRLIB you can write any preprocessing you want, and when run Tesseract over preprocessed image.

Yes, you can. That's exactly the original purpose of the library. WIth PRLIB you can write any preprocessing you want, and when run Tesseract over preprocessed image.

can you tell me how to do this please?? @ZaMaZaN4iK

You run any preprocessing algorithm from PRLib on an image. Then preprocessed image you pass to Tesseract library.

sorry but there is not enough explanation for this. I did the download, created a directory called build, ran the make command. how will I use it in my project later on. please tell me about it. @ZaMaZaN4iK

You should add PRLib to your new project (via copy-pasting sources and built files OR via CMake OR via any dependency manager - whatever you want). Then you need to manually read your image file into the memory, apply any of PRLib's algorithms according to your needs. Then resulting image you should pass to Tesseract. I don't remember exactly, which format shall be used with Tesseract, so you need to read Tesseract documentation first.


Update CONTRIBUTING.md to mention adding a subspec for new modules

Checklist

[x] I checked the Contributing Guidelines before creating this request.
[ ] New extensions are written in Swift 4.
[ ] New extensions support iOS 8.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+.
[ ] I have added tests for new extensions, and they passed.
[ ] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[ ] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

Closes #487

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 534 tests, with 0 failures (0 unexpected) in 12.037 (14.988) seconds

:book:
tvOS: Executed 503 tests, with 0 failures (0 unexpected) in 2.837 (3.439) seconds

:book:
macOS: Executed 368 tests, with 0 failures (0 unexpected) in 1.135 (1.518) seconds

  Generated by :no_entry_sign: Danger

Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃


misc: Add Omnitrace and Omniperf to Dockerfile.amd

@mloubout I've pushed some edits, but I still have to test this: https://github.com/AMDResearch/omnitrace/issues/217#issuecomment-1323574921

That's weird for /opt that's where nvhpc is installed and it works fine.
Did you look at the log? May be just that need to create the directory first

log was fine AFAICT
Also, this env var
ENV OMNIPERF_DIR=/app/omniperf

Doesn't persist in the container. LIterally, it's not there. Any idea @mloubout ?

I pushed several edits. Could you take another look @mloubout ?

This should be gtg right

I'm waiting for this https://github.com/AMDResearch/omniperf/issues/45#issuecomment-1344741068
I'll tag u in that issue so that you can track progress

Status on this? Still wanted?

@mloubout yes, but some story as Dockerfile.amd -- I want to be able to pull in from something they maintain , especially since the project is young
But we definitely want the AMD profilers in

Just checked -- They have added something recently, but ...
https://github.com/AMDResearch/omniperf/blob/main/docker/ubuntu20.04/Dockerfile
an amdgpu package? unsure..

So what's the plan for this?

HOnestly don't know yet, I have to look at their latest installation instructions to see if it got any simpler
the way it is at the moment is too painful and I wouldn't want to maintain it
That said, having the AMD profiler around in our Docker image would be quite useful...

wget https://github.com/AMDResearch/omnitrace/releases/latest/download/omnitrace-install.py
python3 ./omnitrace-install.py --prefix /opt/omnitrace/rocm-5.4 --rocm 5.4

Omnitrace installation is quite straightforward


Unexpected response during deploy

During the deploy steps, I ran:

I expected:

However, I received:

Recommendations?

It looks like you should run

Instead of


Added VLM bindings and a Python sample.

Added VLM bindings.
Added Python VLM chat sample.
Added initialization of performance metrics with zeros.
Tickets: CVS-153174, CVS-153173, CVS-153626

PR to miniCPM-V-2_6 branch: https://github.com/Wovchena/openvino.genai-public/pull/62

There are going to be merge conflicts

build_jenkins

Please resolve the conflicts

build_jenkins


Optional celebrity identity

Summary
This PR fixes the optional Identity of a Celebrity in the AlchemyVision API #334.

Hahaha, I love that you added a picture of yourself to the tests. That's fantastic! You'll be a celebrity soon enough. ;)
This is a great fix. Thanks for the PR!

@glennrfisher haha... I'm honest: I wanted to get some fame. So perhaps we have to change the test soon 😋


Add robot-simulator exercise

Other than me being a pedant, it looks good.

There was a mix of tabs and spaces, but I'm not convinced that my editor knows how to erlang. I'll give it a try, and if it doesn't work I'll find a syntax file tomorrow to fix it. Thanks :)

Ok, I've given it a shot. Let me know if that looks right to you!

Much better, thanks :rocket:


[SPARK-35236][SQL] Support archive files as resources for CREATE FUNCTION USING syntax

What changes were proposed in this pull request?

This PR proposes to make CREATE FUNCTION USING syntax can take archives as resources.
Why are the changes needed?

It would be useful.
CREATE FUNCTION USING syntax doesn't support archives as resources because archives were not supported in Spark SQL.
Now Spark SQL supports archives so I think we can support them for the syntax.
Does this PR introduce any user-facing change?

Yes. Users can specify archives for CREATE FUNCTION USING syntax.
How was this patch tested?

New test.

Test build #137984 has started for PR 32359 at commit a6b9f1a.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42504/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42504/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42504/

Test build #137984 has finished for PR 32359 at commit a6b9f1a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137984/

Merged to master.


Add validation for OTP

Is there any way to add validation for OTP, to prevent user input space and special character.
Thank you.

@gandarain  yes, have you tried to set type prop from Props?

Thank you @anday013


Trim unused languages

Summary
By default, we include code to highlight all languages that highlight.js supports, but we really only support a much smaller, static list. By removing those we don't support, we can shave about 200KB gzipped off the production bundle size (measured by userin webpack-bundle-analyzer on assets created with npm run build, before and after my changes).
I also added support for some languages file extension names where it seemed missing, and added back in zsh support (there's no zsh language in highlight.js, so the closest thing is the bash language, which their supported language page recommends).
I also posted a gist to my own github with snippets for all languages we currently support: https://gist.github.com/neallred/a81c30202c0a689207504fb46dfd63f9
I noticed latex doesn't seem like its working in master or in this branch. I'm very ok not trying to fix it as part of this effort.
Ticket Link
https://mattermost.atlassian.net/browse/MM-46227
Screenshots
Release Note
Code blocks have better support for language filetype extensions
Smaller bundle size

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/e2e-test

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/227335

I noticed latex doesn't seem like its working in master or in this branch. I'm very ok not trying to fix it as part of this effort.

Do you mean you're trying to use it with latex or latexcode as the language? The former is intentionally not supported since we highjacked that way back to do latex rendering, but using latexcode as the language in the web app is supposed to get around that.
This works for me on community at least
```latexcode
\documentclass{article}

\begin{document}

Hello World!

\end{document}
```

Ahh, didn't realize it needed to be latexcode. That works for me in community and on this branch.


id property is ignored

I'm trying to style a specific instance of the walkthrough directive by using an id like this:
<walkthrough id="walkthrough-step-one"...
However the id is ignored and seems to be stripped from the HTML once the App runs. This used to work in a previous version. How can I target a specific instance of the walkthrough?

Hi @AppwareDev , your absolutely right, a new property was added, wid (see readme)  which sets the id of the walkthrough. Take note that the walkthrough element is removed from DOM once closed, so this id will only be relevant when the walkthrough is open.
Update me on how it works out for you.
thanks

Aha, thanks.
I still don't seem to be able to use that id in my css though.  All I'm trying to do is adjust the CSS styling depending on the active walkthrough.


Error import OmnivoreQL

Python 3.8.10 (default, Nov 22 2023, 10:22:35)
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

from omnivoreql import OmnivoreQL
Traceback (most recent call last):
File "", line 1, in
File "/home/mrta/.local/lib/python3.8/site-packages/omnivoreql/init.py", line 1, in
from .omnivoreql import OmnivoreQL
File "/home/mrta/.local/lib/python3.8/site-packages/omnivoreql/omnivoreql.py", line 4, in
from models import CreateLabelInput
ModuleNotFoundError: No module named 'models'

Hey @mrta Thanks for the report.
Can you now check if things are working with version 0.3.1?
Remove your current version (pip uninstall omnivoreql) and then install omnivoreql==0.3.1
And please let me know if its still broken!

v0.3.3 is also out with setlabel feature

Hey @mrta Thanks for the report. Can you now check if things are working with version 0.3.1? Remove your current version (pip uninstall omnivoreql) and then install omnivoreql==0.3.1 And please let me know if its still broken!

Fixed.


topbar responsiveness

the dropdown does not work on mobile.

the search bar looks strange

@uu-z


Track Packages in Migration Process

What would you like to be added:

[!CAUTION]
The failure of these packages may be due to a bug in the workflow.
Failed on arm #59

[ ] #48
Missing build-deps.
Failed on arm: https://github.com/gardenlinux/package-aws-kms-pkcs11/actions/runs/7084215581/job/19278071792
[x] package-ena-dkms - don't need anymore
[x] package-glibc - we builds supported version in gitlab-ci, so this repo can be skip for now.
Failed on arm https://github.com/gardenlinux/package-glibc/actions/runs/7084218037/job/19280380863
[x] package-libyang - can be drop as duplicated with package-libyang2 that we currently using.
[x] package-podman-toolbox - don't need anymore
[x] package-python3.10 - obsoleted by python3.11

[!Warning]
These packages are available in Debian but they contain a debian/ directory in their repo. The changes should be converted into patches/ instead:

[x] package-ferm
[x] package-kpatch
[x] package-libyang2 - synced from package-libyang, may drop package-libyang now.
[x] package-microsoft-authentication-library-for-python
[x] #42 - builds with nocheck
[x] package-openssl

[!NOTE]
Packages builds both locally and workflow:

[x] package-aws-sdk-cpp
[x] package-cloud-init
[x] package-containerd
[x] package-containerd-1.7
[x] package-curl
[x] package-cyrus-sasl2
[x] package-docker-machine
[x] package-docker.io
[x] package-frr
[x] package-gardenlinux-repo-manager
[x] package-gardenlinux-selinux-module
[x] package-htop
[x] package-ignition
[x] package-iproute2
[x] package-libpam-ssh
[x] package-neofetch
[x] package-onmetal-image
[x] #50 - builds with nocheck
[x] package-oras
[x] package-pam
[x] #45 - builds with nocheck
[x] package-python3-defaults
[x] package-python3.11
[x] #46
[x] package-runc
[x] package-selinux-basics
[x] package-selinux-policy-targeted-fedora
[x] #49
[x] package-sudosh2
[x] #44
[x] package-systemd
[x] package-tar

Why is this needed:
As part of the ongoing migration process, we need to track all the packages being migrated to ensure a smooth transition.

Please check that these are all actually migrated to the new build system and we are not accidentally missing modifications.
21 package repos still have a debian folder instead of just patches for package migration to be considered done we need to ensure that the debian folder used by the old build system does not include any significant differences to the debian folder upstream, or if it does these changes need to be made into patches.
List of package repos still containing a debian folder:
package-aws-kms-pkcs11
package-aws-sdk-cpp
package-containerd-1
package-docker-machine
package-ena-dkms
package-ferm
package-gardenlinux-repo-manager
package-gardenlinux-selinux-module
package-glibc
package-kpatch
package-libstoragemgmt
package-libyang
package-microsoft-authentication-library-for-python
package-onmetal-image
package-openssh
package-openssl
package-oras
package-selinux-policy-targeted-fedora
package-sops
package-sudosh2

Just checked the README.md from libyang that we need to build the latest version libyang for frr version 0.9. And the the latest upstream release is version 2.1.128. So we better switch to use package-libyang2 repo instead.

All packages have been migrated. There are problems with aws-kms-pkcs11 but they are tracked in #48
Therefore, I'm closing this issue here.


exception causes script to fail

Silently return script if source or target isn't found in array

fixed in https://github.com/markoshust/drop-target-rank/releases/tag/1.0.1


OOP school library: add Person, Student and Teacher classes

The following feature have been implemented:
Created class Person with the following:

Instance vars: @id, @name, and @age.
Constructor with name, age, and parent_permission as parameter. name and parent_permission are optional and have default values of "Unknown" and true.
Getters for @id, @name, and @age.
Setters for @name and @age.
Private method is_of_age? that returns true if @age is greater or equal to 18 and false otherwise.
Public method can_use_services? that returns true if person is of age or if they have permission from parents.

Created class Student with the following:

Inherits from Person.
Constructor extends parent's constructor by adding @classroom and a parameter for it.
Method play_hooky that returns "¯(ツ)/¯".

Created class Teacher with the following:

Inherits from Person.
Constructor extends parent's constructor by adding @specialization and a parameter for it.
Override can_use_services? so it always returns true.

Each class was saved in a separate file.

@mukhammadrizooff Rahmat katta. Eshitib hursand boldim. Career switch qilishga qaror qilgandim. Microverseni topib oldim. Juda yaxshi orgatyapti. Bundan hursandman. Sizga ham omad tilayman.


Please provide a "Delete Record" button when the path of recent project does not exist.

please provide a "Delete Record" button when the "Path does not exist" dialog box pops up in the "Recent" tab of the initial welcome screen

@Anti-Li Currently when the path does not exists for the recent folder uri, it gets deleted from vscode state. It will not be shown again.
What is actually expected?

It doesn't like what you said.

VS Code version: Code - Insiders 1.29.0-insider (45d5d153bbebed743b77e426615aade34971eb46, 2018-10-19T06:58:45.940Z)
OS version: Windows_NT x64 10.0.17134

The open recent list should now be better linked to the getting started screen. So feel free to delete and clear issues there

To verify ensure deleting something from the open recent menu also deletes it from the walkthrough


Backend ASP .NET (OWIN): No prepopulated credentials in sample project

After downloading the sample project, the app Setings key are not properly populated.

You are correct, at the moment I have just deleted browser caché/cookies and my credentials has been lost.
All good.


Better bech32 error messages

Issue Number

#1603
Overview

[x] Addded custom error messages for bech32 errors
[x] Mark invalid characters red and underline them with ^

Comments

Not sure if/how we should test
Not sure if the (non-IO) ANSI red works on windows
Not sure if the ^ underlining is a great idea considering line wrapping is likely removed

Alternatively, to avoid the issue with the line wrapping, it is perhaps possible to only show part of the encoded string? Like the 5 characters that precede the error, and the 5 after and at the exact position in the error message:
Bech32 error: Invalid character(s) in string at position 78/127:
xprv1[...]90aa66mvaux[...]
               ^

:thinking: ?

It gets a bit non-trivial implementation-wise. Need to cluster neighbouring indices, pad,  etc.
Might consider just printing the full key with coloured characters (and not ^).

I think we should go with the simple option of printing the full key and marking the invalid characters red.
Unless that's somehow a security concern.

bors try

I would be fine with just printing the faulty address and character offset at which the error occurred.
This is enough information to identify the error.

This variant outputs the sequence of control characters as a String, which can be added to any other bit of text before being output. The use of these codes is generally discouraged because they will not work on legacy versions of Windows where the terminal in use is not ANSI-enabled (see further above). On Windows, where emulation has been necessary, these variants will always output the empty string. That is done so that it is possible to use them portably; for example, coloring console output on the understanding that you will see colors only if you are running on a Unix-like operating system or a version of Windows where emulation has not been necessary. If the control characters are always required, see module System.Console.ANSI.Codes.

src
this is why I'm not sure to what extent it will work on windows, but should be a minor problem even if there is one
bors r+

🤦♂


Added auto-close stream result on end of stream

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Other information

Codecov Report

Merging #70 (de1f53c) into master (5a93e85) will decrease coverage by 16.79%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master      #70       +/-   ##
===========================================
- Coverage   50.61%   33.82%   -16.80%
===========================================
  Files          77       45       -32
  Lines        9299     6794     -2505
===========================================
- Hits         4707     2298     -2409
- Misses       4299     4359       +60
+ Partials      293      137      -156

Flag
Coverage Δ

1.16.x
33.82% <0.00%> (-0.02%)
:arrow_down:

1.17.x
33.82% <0.00%> (-16.80%)
:arrow_down:

integration
?

ubuntu-latest
33.82% <0.00%> (-16.80%)
:arrow_down:

unit
33.82% <0.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/table/scanner/result.go
31.86% <0.00%> (-35.91%)
:arrow_down:

internal/table/session.go
41.01% <0.00%> (-29.84%)
:arrow_down:

internal/driver/driver_as_cluster.go
0.00% <0.00%> (-90.00%)
:arrow_down:

scheme.go
0.00% <0.00%> (-80.65%)
:arrow_down:

internal/driver/driver.go
0.00% <0.00%> (-78.58%)
:arrow_down:

table.go
0.00% <0.00%> (-64.62%)
:arrow_down:

internal/scheme/scheme.go
0.00% <0.00%> (-55.72%)
:arrow_down:

options.go
0.00% <0.00%> (-52.60%)
:arrow_down:

internal/driver/cluster/balancer/balancer.go
0.00% <0.00%> (-51.73%)
:arrow_down:

connection.go
0.00% <0.00%> (-44.31%)
:arrow_down:

... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a93e85...de1f53c. Read the comment docs.