AAC Decoder

Description
Adds base foundation elements for AAC Decoder.
Heavily inspired by: https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/libfdk-aacdec.c
Changes

Added basic native interface for AAC operations that uses https://github.com/mstorsjo/fdk-aac library
Implemented placeholder Elixir methods that call Native interface

Test plan

Create a test pipeline that uses .aac file as input source
Connect AAC.Decoder inside that pipeline
Ensure all frames are correctly decoded

TODO
Note: The implementation is still a work in progress. ~I'm currently facing 0x2007 error from FDK-AAC library (AAC_DEC_UNSUPPORTED_CHANNELCONFIG?) or a segfault.~ However, the interface definitions should not change that much.

[x] Fix native interface errors and ensure the frames are parsed correctly
[ ] Handle more configuration options
[x] Return explicit errors
[x] ~Implement buffers queue~ (No need, FDK-AAC has its own buffer)
[x] ~Handle EndOfStream event and cleanup native decoder state accordingly~ (No need, we're reading all frames in handle_process)
[x] ~Add 2112 samples delay? (according to https://developer.apple.com/library/archive/technotes/tn2258/_index.html)~ (Handled internally by FDK-AAC)
[x] Use Membrane's logging methods
[x] Add docstrings
[x] Handle valid != 0 by throwing an explicit error? (Will handle that in a separate PR as it is not obvious what to do in this case)
[ ] Add unit tests

@Hajto @bblaszkow06 I've checked Credo locally and it does not report any issues:

Do you guys think it could be a good idea to add Credo checks to the CI build?

Do you guys think it could be a good idea to add Credo checks to the CI build?

IMHO no, we're having some false-positives, especially when using ~> and ~>> macros from Bunch. I rather consider credo warnings as suggestions, but dunno what's others opinion on the matter @Hajto @mat-hek
Anyway, I'll merge this PR and eventual Credo support can be added later.


"FastImageView" was not found in the UIManager

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior if possible, or a link to a reproduction repo:

Install react-native-fast-image
Use it in a react native component
Try to load that component on iOS

I don't see a pod for FastImageView in my pod folder and I've already run pod install.
What I've tried:

Delete the pods folder
Delete node_modules
Clean the Xcode build
Restart Xcode
Delete the app from my device

Has anyone else run into this issue?
Expected behavior
No error
Screenshots

Dependency versions

React Native version: 0.71.14
React version: 18.2.0
React Native Fast Image version: 8.6.3
iOS Version: 17.3.1

Note: if these are not the latest versions of each I recommend updating as extra effort will not be taken to be backwards compatible, and updating might resolving your issue.

I have the same problem

hmm

Any solution for this yet? i'm having the same issue

I have the same issue, it has something to do with Expo 51 I guess. It worked fine with Expo 50. Works fine in simulator, issue is active using Expo Go on physical device.

Same issue with expo 51 using Expo Go.


Changing the asdict and dumps methods for the workflows classes and adding experiment tags and uuis

When an RQAOA object is compiled, currenty we save all the QAOA objects that have been used in the rqaoa.results dictionary.
However, there is no need to save the whole QAOA object, all the information needed is in QAOA.resuts. This PR implements this change.
TO DO

[ ] Write tests

If you run Notebook 2 and try: q_noisy_shot.dumps() it doesn't work because there are some tuples as dictionary keys

If you run Notebook 2 and try: q_noisy_shot.dumps() it doesn't work because there are some tuples as dictionary keys

rqaoa.results.plot_corr_matrix(step=..) should be improved. I guess it would be better to do so in another PR.

q.set_identification(parent_uuid='72d1f10f-8f38-4411-998d-76c2ceb95688') shall we change this to set_experiment_id(exp_id=....)? This should make the usage of the field more clear


chore: Upgrade to Ruby 3.1

Pursuant to our pattern of upgrading Ruby and then Rails this PR does the Ruby 3.1 upgrade in preparation for Rails 7.0. I had to upgrade Standard Ruby and also add a gem called "matrix" to the Gemfile which wasn't something I had bumped into before. 🤷
/cc @artsy/amber-devs

Hi!!! I think we might need to bump selenium-webdrivers version here too
This is a very helpful PR! https://github.com/artsy/volt/pull/7459/files


updates to avoid shell injection vulnerability #22

P.S there are some formatting changes(single quote to double quotes) due to Black Formatter, Hope that is okay

I have read the CLA Document and I hereby sign the CLA.


Execute thread manager when multithreading is enabled

ThreadManager is being used even if multithread is not enabled.

The thread manager can also be used single threaded. It will just work though the tasks in serial. This PR is invalid.


errors in getting SP secret and id

Seems like the $sp has AppId and not ApplicationId.
also the snippit for getting the secret doesn't work for me seems like sp.Secret is empty.
$secret = [System.Runtime.InteropServices.Marshal]::PtrToStringAuto([System.Runtime.InteropServices.Marshal]::SecureStringToBSTR($sp.Secret))
Exception calling "SecureStringToBSTR" with "1" argument(s): "Value cannot be null.
Parameter name: s"
At line:1 char:1

$secret = [System.Runtime.InteropServices.Marshal]::PtrToStringAuto([ ...

  + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
  + FullyQualifiedErrorId : ArgumentNullException

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 425ddc25-2a4b-c529-9d8c-b9e6975cfd1c
Version Independent ID: 818658d6-3f73-7a88-93af-81018f971676
Content: Azure Kubernetes Service on Azure Stack HCI and Windows Server requirements - AKS hybrid
Content Source: AKS-Hybrid/system-requirements.md
Service: azure-stack
Sub-service: aks-hci
GitHub Login: @sethmanheim
Microsoft Alias: sethm

@jeffbearer
Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate.

@sethmanheim
Can you please check and add your comments on this doc update request as applicable.

@jeffbearer  - We state in the documentation that "Retrieve the password for the service principal by running the following command. Note that the below command only works for Az.Accounts 2.6.0 or lesser. We automatically download Az.Accounts 2.6.0 module when you install the AksHci PowerShell module." Can you please retry by deleting all versions of Az.Accounts > 2.6.0, installing 2.6.0 and see if it works for you?

Closing for now, please send any follow-up questions. #please-close


Allow PlainTextAuthProvider to change its credentials at runtime (JAVA-719)

:+1: lgtm

:+1: lgtm


Correct sentence structure on line 7

Line 7 did not have the proper grammatical structure.

Thank you for this fix, @Rfosu2k2! 🎉


Lock controls during image loading

Whilst the spinner is active, the controls panel should be locked to prevent some edge cases of changing values, that are not well defined yet or will flip once media loading is complete.

Fixed via https://github.com/FrostKiwi/frostorama/commit/eb509d4f6aa68504573a2c8002a652c65e49f0dc


Color highlight tool

Thanks for contributing!
Code was used in highlight color tool, but with restyled UI


Show flash message after successful operation

I'm rewriting my REST API to twirp. So far so good.
In my old design I made a HTTP delete request, removed some item in the database, added a flash message to the user's session and redirected on the server. After the redirect the user was able to see the flash message. Try to delete some repository here at GitHub. You'll be redirected to the main page and see a message Your repository "zemirco/test" was successfully deleted..
session, err := c.SessionStore.Get(r, config.CookieName)
session.AddFlash("hello world.")
if err := c.SessionStore.Save(r, w, session); err != nil {
  ...
}
http.Redirect(w, r, r.URL.String(), http.StatusSeeOther)
return nil

Now I'm using React in my frontend and twirp for communication. I post a request, item is removed in the database, client gets the response and redirects on the frontend.
onDelete = async event => {
  event.preventDefault()
  await DeletePlayer('abc')
  window.location.href = `/${username}?tab=players`
}

I'd like to show the same flash message Your repository "zemirco/test" was successfully deleted. after the redirect.  How do you add something to the user's current session? I'm using https://github.com/gorilla/sessions.

If you want to communicate a message back to the client, the proper way to do it would be to have it in the response field. Instead of responding with Empty, have a DeleteItemResponse message which has a string field for the message to pass.
Then, the client unpacks the response from the server and can show the flash message however it likes.
Does that make sense? I'm not sure I totally understand the question.

I'm going to close this as resolved. Let me know if you still have questions.


Upgrade to latest API schemas

@xvrh Any chance to see it as a prerelease version? Thanks!

@tsinis what are you looking for especially in this version?
I got stuck in this upgrade. Mainly because the schemas contains a lot of oneOf and allOf operators which are not well supported by the generator.

@tsinis what are you looking for especially in this version?
I got stuck in this upgrade. Mainly because the schemas contains a lot of oneOf and allOf operators which are not well supported by the generator.

Because of update APIs :D And speaking of sealed/union responses - this was a pretty much stable solution for anyOf/oneOfs (although you might need to compile a generator from Java on your own 😬).

I'll see if I can merge this PR. Maybe it is useful on its own without support for xOf operators.
I'll look later to find a long term solution to generate better structures for union types.

After looking at this, I'm not able to merge this PR on the short term.
There are some new usages of allOf. Without support for it, a lot of return types from method are turned into dynamic.
It makes the package unsafe and almost unusable.


zsh-prezto not building on x86_64-darwin nix-pkgs unstable

Describe the bug
It looks like builds of zsh-prezto still expect files to be in the root of $out instead of their new location (at least for builds on macOS 10.16).
To Reproduce
Steps to reproduce the behavior:

Update nix-channel to latest unstable on macOS 10.16
list zsh-prezto as a required package
try to build (I noticed this failure when using home-manager), and notice that it expects files to be in the root of $out instead of the new location.
I saw:

error: opening file '/nix/store/5asnfm639ywhnycam5m4pcvhrgnkqmjd-zsh-prezto-unstable-2021-01-19/runcoms/zlogin': No such file or directory

Expected behavior
Install should complete as expected, and not fail on missing expected files.
Additional context
This appears to be related to this change here: https://github.com/NixOS/nixpkgs/pull/111264
Notify maintainers
@holymonson
Metadata

system: "x86_64-darwin"
host os: Darwin 20.2.0, macOS 10.16
multi-user?: no
sandbox: no
version: nix-env (Nix) 2.3.9
channels(nagromlobo): "home-manager, nixpkgs-21.03pre268255.e5b478271ea"
nixpkgs: /Users/nagromlobo/.nix-defexpr/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
- zsh-prezto
# a list of nixos modules affected by the problem
module:

You know what, on further poking/thinking, I think that this is an issue in home-manager, and is captured here:https://github.com/nix-community/home-manager/issues/1773, not going to close immediately because it is probably worth the bump, but I'm thinking that this isn't an issue with nixpkgs themselves.

This is a home-manager issue, as you identified, which has just been fixed. Closing this now.


Unsupported url -- https://accounts.coursera.org/signin?course_id=...

I tried to download videos of a coursera course I'm enrolled in, first using:
youtube-dl -s --get-filename -u <REDACTED> -p <REDACTED>  --verbose https://class.coursera.org/ml-006/lecture
to check what would be downloaded. However, this produced an ERROR: Unsupported URL... and please report this issue on https://yt-dl.org/bug, so I'm doing so.
Here's the complete output youtube-dl output:

[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-s', '--get-filename', '-u', '', '-p', '', '--verbose', 'https://class.coursera.org/ml-006/lecture']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2014.08.10
[debug] Python version 3.4.1 - Darwin-11.4.0-x86_64-i386-64bit
[debug] Proxy map: {}
WARNING: Falling back on generic information extractor.
ERROR: Unsupported URL: https://accounts.coursera.org/signin?course_id=972303&r=https%3A%2F%2Fclass.coursera.org%2Fml-006%2Flecture&user_action=class&topic_name=Machine Learning; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 516, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 170, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 752, in _real_extract
raise ExtractorError('Unsupported URL: %s' % url)
youtube_dl.utils.ExtractorError: Unsupported URL: https://accounts.coursera.org/signin?course_id=972303&r=https%3A%2F%2Fclass.coursera.org%2Fml-006%2Flecture&user_action=class&topic_name=Machine Learning; please report this issue on https://yt-dl.org/bug . Be sure to call youtube-dl with the --verbose flag and include its complete output. Make sure you are using the latest version; type  youtube-dl -U  to update.

It has passed 6 years. Has anyone looked into it since then?

I didn't try it, but I saw https://github.com/coursera-dl/coursera-dl that would do it!


ND4J: Log classifier (x86, avx2, avx512)

We should list what classifier the user has loaded (x86, avx2, avx512)
o.n.l.f.Nd4jBackend - Loaded [CpuBackend] backend
o.n.n.NativeOpsHolder - Number of threads used for linear algebra: 6
o.n.n.Nd4jBlas - Number of threads used for OpenMP BLAS: 6
o.n.l.a.o.e.DefaultOpExecutioner - Backend used: [CPU]; OS: [Linux]
o.n.l.a.o.e.DefaultOpExecutioner - Cores: [12]; Memory: [7.0GB];
o.n.l.a.o.e.DefaultOpExecutioner - Blas vendor: [OPENBLAS]

Yes, we have the warning when configured incorrectly, it would be nice to actually report what is currently configured, rather than simply relying on "no warning == configured correctly" as the only way to tell what is used.

As I explained before in issue https://github.com/eclipse/deeplearning4j/issues/7834#issuecomment-498170278, that's not how it should be done...


Add CI GitHub Actions workflow

Build

Build on Linux, macOS, Windows.
Test on Linux, macOS, Windows.
Build and test with no default features on Linux, macOS, Windows.
Build and test with all features on Linux, macOS, Windows.

Lint Rust

rustfmt
cargo clippy -- --all-targets --all-features

Lint text

npx prettier --check '**/*'

The jobs added in this PR are now required to pass before merging.
No direct pushes to trunk are allowed.


Exception error PlatformException(illegalargument, Expected arg['playerId'] to be a valid player id., null, null)

Hey, trying to get this working on a RP4 using your omxplayer_video_player code and the sample app. I first made sure I followed the instructions here: https://github.com/ardera/flutter-pi and got that fully working. I then modified the flutter_gallery project to load a video player so I can test performance. I first used the normal video_player package and tested that, nothing played but also no errors. I then installed your package and now I get errors in the output. GUI wisd everything loads, white area where player should be, I hit play and nothing. I exit the app and check console and see the errors.
I'm on a RP 4b using bullseye.
video_player 2.2.16 and I also tried 2.0.0
I included a photo below of the output, I also tried to OCR the image for you to get the output in text form.
U: PortSettingsChanged: 1280x720029,97 Interlace:0 deinterlace:0 anaglyph:© par:nan display:© layer:-128 alpha:255 aspecthode:0
[compositor] GPU does not supported the desired Hi plane order.
Sone UI layers may be invisible.
(flutter-pI1 Error handing platform message. plugin_registry_on_platform nessage: Invalid argument
(flutter-pli Error handling platform nessave. plugin registry on _platforn nessage: Invalld argument
[BRRO:Plutter/11b/u1/u1_dart_state.cc(209)]Unhandled Exception? PletfornException (illegalargunent, Expected 'argl'playerld'J° to be a valid player id., null, null?
80
StandardMethodCodee.decodeknuelope(package:flutter/src/services/message_codecs.dart.:607:7)
81
MethodChannel._InvokeMethod (package: flutter/src/serulces/platform_channel.dart:167:18)
asynchronous suspension>
$2
VldeoPlayerController._applyLooping(package:video_player/uldeo_player.dart:465:5)
asynchronous suspension›
null.
null)
MethodChannel.-_Invoketlethod(packagetflutter/sre/serulces/platforn_channel.dart:167:18)
asynchronous suspension›
182
VideoPlayerController._applyVolume(package:uldeo_player/uldeo_player.dart:505:5)
asynchronous suspension›
asynchronous suspension›
3 82
VldeoPlayerController._applyPlayPause(package:vldeo_player/uldeo_player.dart:497:7)
asynchronous suspension>
1 [flutter-pi1 Error handling platform message. pluginregistry_on_platfornnessage: Invalid argunent
MethodChanne1 ._invokeMethod (package: flutter/src/services/platform_channel .dart: 167:16)
asynchronous suspension>
$2
_OmxPlayerVleuController._initialize (package:onxplayer_uldeo_player/src/onxplayer_view.dart:51:5)
‹asynchronous suspension›
R Seek to: 00:00:00
[flutter-pil Error handling platform nessage, plugin registry on platforn_message: Invalld argument
(ERROR: flutter/11b/ul/ul_dart_state.cc(209)] Unhandled Exception: PlatfornException(Illegalargument. Expected 'argi'playerid°J° to be a valid player 1d.. mull.
80
StandardMethodCodec.decodeEnvelope(package:flutter/src/seruices/message_codecs.dart:607:7)
$1
MethodChannel._InvokeMethod(package:flutter/src/serulces/platform_channel.dart:167:18)
(asynchronous suspension>
82
VldeoPlayerController._opplyPlayPause(package:video_player/video_player.dart:473:7)
asynchronous suspension›
$3
VideoPlayerController.play(package:uldeo_player/uldeo_player.dart:445:5)
(asynchronous suspension>

Here is the modified main.dart file from the flutter_gallery project (same commit as your readme)
// Copyright 2019 The Flutter team. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/scheduler.dart' show timeDilation;
import 'package:flutter_gen/gen_l10n/gallery_localizations.dart';
import 'package:flutter_localized_locales/flutter_localized_locales.dart';
import 'package:gallery/constants.dart';
import 'package:gallery/data/gallery_options.dart';
import 'package:gallery/pages/backdrop.dart';
import 'package:gallery/pages/splash.dart';
import 'package:gallery/routes.dart';
import 'package:gallery/themes/gallery_theme_data.dart';
import 'package:google_fonts/google_fonts.dart';
import 'package:omxplayer_video_player/omxplayer_video_player.dart';
import 'package:video_player/video_player.dart';
export 'package:gallery/data/demos.dart' show pumpDeferredLibraries;

void main() {
  GoogleFonts.config.allowRuntimeFetching = false;
  if (OmxplayerVideoPlayer.isPlatformSidePresent()) {
    OmxplayerVideoPlayer.useAsImplementation();
  }
  runApp(const VideoApp());
}

class VideoApp extends StatefulWidget {
  @override
  _VideoAppState createState() => _VideoAppState();
  const VideoApp({Key key}) : super(key: key);
}

class _VideoAppState extends State<VideoApp> {
  VideoPlayerController _controller;
  Future<void> _initializeVideoPlayerFuture;

  @override
  void initState() {
    super.initState();
    // _controller = VideoPlayerController.network('https://flutter.github.io/assets-for-api-docs/assets/videos/butterfly.mp4');
    _controller = VideoPlayerController.asset('assets/test.mp4');

    // _controller.addListener(() {
    //   setState(() {});
    // });
    // _controller.setLooping(true);
    _initializeVideoPlayerFuture = _controller.initialize();
    // _controller.play();

    // super.initState();
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Video Demo',
      home: Scaffold(
        // body: Center(
        //   // child: _controller.value.isInitialized
        //   //     ? AspectRatio(
        //   //         aspectRatio: _controller.value.aspectRatio,
        //   //         child: VideoPlayer(_controller),
        //   //       )
        //   //     : Container(),
        //   child: AspectRatio(
        //     aspectRatio: _controller.value.aspectRatio,
        //     child: Stack(
        //       alignment: Alignment.bottomCenter,
        //       children: <Widget>[
        //         VideoPlayer(_controller),
        //         VideoProgressIndicator(_controller, allowScrubbing: true),
        //       ],
        //     ),
        //   ),
        // ),
        // Use a FutureBuilder to display a loading spinner while waiting for the
        // VideoPlayerController to finish initializing.
        body: FutureBuilder(
          future: _initializeVideoPlayerFuture,
          builder: (context, snapshot) {
            if (snapshot.connectionState == ConnectionState.done) {
              // If the VideoPlayerController has finished initialization, use
              // the data it provides to limit the aspect ratio of the video.
              return AspectRatio(
                aspectRatio: _controller.value.aspectRatio,
                // Use the VideoPlayer widget to display the video.
                child: VideoPlayer(_controller),
                // child: Stack(
                //   alignment: Alignment.bottomCenter,
                //   children: <Widget>[
                //     VideoPlayer(_controller),
                //     VideoProgressIndicator(_controller, allowScrubbing: true),
                //   ],
                // ),
              );
            } else {
              // If the VideoPlayerController is still initializing, show a
              // loading spinner.
              return const Center(child: CircularProgressIndicator());
            }
          },
        ),
        floatingActionButton: FloatingActionButton(
          onPressed: () {
            setState(() {
              _controller.value.isPlaying
                  ? _controller.pause()
                  : _controller.play();
            });
          },
          child: Icon(
            _controller.value.isPlaying ? Icons.pause : Icons.play_arrow,
          ),
        ),
      ),
    );
  }

  @override
  void dispose() {
    super.dispose();
    _controller.dispose();
  }
}

/*class GalleryApp extends StatelessWidget {
  const GalleryApp({
    Key key,
    this.initialRoute,
    this.isTestMode = false,
  }) : super(key: key);

  final bool isTestMode;
  final String initialRoute;

  @override
  Widget build(BuildContext context) {
    return ModelBinding(
      initialModel: GalleryOptions(
        themeMode: ThemeMode.system,
        textScaleFactor: systemTextScaleFactorOption,
        customTextDirection: CustomTextDirection.localeBased,
        locale: null,
        timeDilation: timeDilation,
        platform: defaultTargetPlatform,
        isTestMode: isTestMode,
      ),
      child: Builder(
        builder: (context) {
          return MaterialApp(
            // By default on desktop, scrollbars are applied by the
            // ScrollBehavior. This overrides that. All vertical scrollables in
            // the gallery need to be audited before enabling this feature,
            // see https://github.com/flutter/gallery/issues/523
            scrollBehavior:
                const MaterialScrollBehavior().copyWith(scrollbars: false),
            restorationScopeId: 'rootGallery',
            title: 'Flutter Gallery',
            debugShowCheckedModeBanner: false,
            themeMode: GalleryOptions.of(context).themeMode,
            theme: GalleryThemeData.lightThemeData.copyWith(
              platform: GalleryOptions.of(context).platform,
            ),
            darkTheme: GalleryThemeData.darkThemeData.copyWith(
              platform: GalleryOptions.of(context).platform,
            ),
            localizationsDelegates: const [
              ...GalleryLocalizations.localizationsDelegates,
              LocaleNamesLocalizationsDelegate()
            ],
            initialRoute: initialRoute,
            supportedLocales: GalleryLocalizations.supportedLocales,
            locale: GalleryOptions.of(context).locale,
            localeListResolutionCallback: (locales, supportedLocales) {
              deviceLocale = locales.first;
              return basicLocaleListResolution(locales, supportedLocales);
            },
            onGenerateRoute: RouteConfiguration.onGenerateRoute,
          );
        },
      ),
    );
  }
}

class RootPage extends StatelessWidget {
  const RootPage({
    Key key,
  }) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return const ApplyTextOptions(
      child: SplashPage(
        child: Backdrop(),
      ),
    );
  }
}*/

Are you using 64-bit? I'm a bit surprised how you got omxplayer running on bullseye, thought that was unsupported there.
If you're using bullseye, you might have more luck by using the in development gstreamer video player in the feature/gstreamer-video-player branch.
For that, you don't need to install any pub packages. Just specify -DBUILD_GSTREAMER_VIDEO_PLAYER_PLUGIN=On -DBUILD_OMXPLAYER_VIDEO_PLAYER_PLUGIN=Off when configuring flutter-pi and install some gstreamer packages:
$ sudo apt install libgstreamer1.0-dev gstreamer1.0-plugins-base gstreamer1.0-plugins-g
ood gstreamer1.0-plugins-ugly gstreamer1.0-plugins-bad gstreamer1.0-plugins-base-apps


FLUX.1-dev runs very slow on 3090

black-forest-labs/FLUX.1-dev runs very slow. it takes about 15min to generate 1344x768 (wxh) image. Has anyone experienced the same or is it just me.
    pipe = FluxPipeline.from_pretrained(args.model, torch_dtype=torch.bfloat16)
    #pipe.enable_model_cpu_offload() #save some VRAM by offloading the model to CPU. Remove this if you have enough GPU power
    pipe.enable_sequential_cpu_offload()
    pipe.vae.enable_slicing()
    pipe.vae.enable_tiling()
    pipe.to(torch.float16) # casting here instead of in the pipeline constructor because doing so in the constructor loads all models into CPU memory at once

    prompt = args.prompt
    image = pipe(
        prompt,
        height=args.height,
        width=args.width,
        guidance_scale=0.0,
        num_inference_steps=args.num_inference_steps,
        max_sequence_length=512,
        generator=torch.Generator("cpu").manual_seed(0)
    ).images[0]
    Path(args.output).parent.mkdir(parents=True, exist_ok=True)
    image.save(args.output)

args.num_inference_steps=50

if having enough vram gpu, try to comment this line pipe.enable_sequential_cpu_offload()

@jerrymatjila, I'm having the same issue with my 3090 card. Were you able to fix it?
Thx

The 24GB VRAM should just be enough to keep the transformer model fully in VRAM, that means you can use pipe.enable_model_cpu_offload() instead of pipe.enable_sequential_cpu_offload(). Maybe you don't even need the vae slicing/tiling.
I.e.:
pipe = FluxPipeline.from_pretrained(args.model, torch_dtype=torch.bfloat16)
pipe.enable_model_cpu_offload()  # save some VRAM by offloading the model to CPU. Remove this if you have enough GPU power

prompt = args.prompt
image = pipe(
    prompt,
    height=args.height,
    width=args.width,
    guidance_scale=0.0,
    num_inference_steps=args.num_inference_steps,
    max_sequence_length=512,
    generator=torch.Generator("cpu").manual_seed(0)
).images[0]
Path(args.output).parent.mkdir(parents=True, exist_ok=True)
image.save(args.output)

If that still uses too more VRAM than available (see task manager), you can look into quantizing the model.


Get content-item basepath from url, not a form field

Save some users from having to enter a basepath via the form submission, and allow them to enter the basepath in the URL, eg content-tagger.gov.uk/lookup/some/basepath

:+1:


Nail Data List alignment

Update Data List so that the Value part is allowed to be a couple pixels higher than the label. This way small buttons and badges used in the Data List won't affect the layout and keep the visual gap between the items consistent.
Allow text trunctation in out of the box

Comparison:

Before
After

OK, damn, started to respond how it works and realized the margin situation doesn't cooperate with align-items. Will need another good pass here.


Content card

Created Content Card-5 using HTML and Tailwind CSS.
Below is the Screenshot for the component

You must use Tailwind CSS, change it please or this PR will be marked as invalid. @MadhurKharche

You must use Tailwind CSS, change it please or this PR will be marked as invalid. @MadhurKharche
I have used Tailwind CSS in the designing of the card. If invalid, please inform me what exactly is wrong.

You must use Tailwind CSS, change it please or this PR will be marked as invalid. @MadhurKharche
I have used Tailwind CSS in the designing of the card. If invalid, please inform me what exactly is wrong.

Sorry, please read the updated comment. @MadhurKharche

Now it looks good to merge. @MadhurKharche
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐
SignIn / SignUp in [ClueLess Website](https://www.clueless.tech/) .
Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.

https://www.clueless.tech/profile/admin/78757405 @Rajdip019


Revised out parameter modifier for C# 7

#Revised out parameter modifier for C# 7
Summary
Updated the topic to cover C# 7, and also did some cleanup (described in the Details section).
Fixes #1378
Details
In addition to documenting the declaration of the out variable in the method call, I've done the following:

Moved code from the codesnippets subdirectory to a subdirectory of samples/snippets.
Deleted code in the codesnippets subdirectory.
Removed most of the text for out.md, so that the topic only links to the two contextual out keywords. The out-parameter-modifier.md topic completely duplicated the out.md topic, which poses a maintenance nightmare and makes it certain that the identical topics (which also had examples in independent code files) will eventually get out of sync.
Modified the toc (toc.md) so that out.md is not in the TOC. It serves to disambiguate out, but does not otherwise appear in the TOC.

Suggested Reviewers
@BillWagner

Thanks, @BillWagner. I've incorporated both of your suggestions. I'll merge as soon as the topic builds.


[Enhancement] Simple Navigation Service

Summary
Default navigation in Xamarin Forms is heavily page-based, this is usually not what you expect when working with View Models. If you don't use any framework or shell, with new project you end up writing another INavigationService. Again.
API Changes
API similar to Prism or MvvmCross:
var navigation = DependencyService.Resolve<INavigationService>();
navigation.Navigate<TViewModel>();
navigation.Navigate<TViewModel, TParameter>(TParameter param);

Extra:
TResult result = await navigation.Navigate<TViewModel, TParameter, TResult>(TParameter param);

Interfaces for view models
interface INavigationAware
{
    void OnNavigated(object parameter);
}

interface INavigationAware<TParam>
{
    void OnNavigated(TParam parameter);
}

Map pages to view models
[ViewModel(typeof(MyPageViewModel))]
public class MyPage : ContentPage
{
{

Intended Use Case
Easily navigate between view models without referencing Xamarin Forms UI components and without any frameworks.

Are you currently working on this or can I?

@michaldivis Nope, I've just thrown an idea, go ahead :)

@jfversluis I think that this request is smaller to my request #194, please reconsider this :), at all am not alone in this 😅😅

and without any frameworks.

Well, technically this is another framework, right? :)
I mean, I see what you're trying to accomplish, but it's a slippery slope. Then we can start adding all the libraries into one just so we don't have to install any others anymore.
The thing with this is: if we start out with this navigation service, then the next thing will be: I want {another feature x of MVVM framework y} because then I don't need another framework. And before we know it, we are again building (another) MVVM framework.
What would be the use-case here? Will this single feature eliminate the need for installing an MVVM framework into your application? Is this the only, single value all of those MVVM frameworks are providing?
Please don't read any of this in a bad way, I am honestly trying to figure out what we should do with this. Because you are right: these requests will keep coming and I'm trying to figure out where to draw the line. I definitely see your standpoint, I hope you can also see mine :D

@jfversluis why I will read this in a bad way, talks always generate good ideas my friend
May I am afraid another MVVM framework support and configuration but anyway Thanks ☺

@jfversluis @AbuMandour  The idea here is to have some sort of navigation that we can use in view models out of the box so we don't have to reinvent the wheel each time we start a new project. Default navigation is very page-based and tightly coupled which doesn't play well with non-coupled VMs. Let's look at Shell - we start new project and only thing we need to do to navigate is to map routes to Pages. It would be great if something similar was available for classic Forms app.

I agree with @jfversluis I think is out of the scope of this project. This proposal fits better in this repo/project.

@jfversluis , @pictos confirmed that this is out of scope or still some discussion needed ?

@jfversluis , @pictos confirmed that this is out of scope or still some discussion needed ?

I still think this is out of scope. Also have a look at the Windows Community Toolkit. They might have something to better fit these needs.

I still think this is out of scope. Also have a look at the Windows Community Toolkit. They might have something to better fit these needs.


replaced Alert's Icon

Closes #4153
Description

Current behavior (updates)

New behavior

Is this a breaking change (Yes/No):

Additional Information

It worked fine in Storybook.


Intermittent failure - WebSubContentTypeSupportTestCase

Description:
[2019-02-22 07:11:45,285] INFO {WebSubContentTypeSupportTestCase} - testAuthenticatedTextContentReceiptForInternalHub: RUNNING
[2019-02-22 07:11:45,723] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriber: <websub><request>Notification</request><type>Internal</type></websub>
[2019-02-22 07:11:45,723] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriber: <websub><request>Notification</request><type>Remote</type></websub>
[2019-02-22 07:11:45,724] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriberTwo: <websub><request>Notification</request><type>Remote</type></websub>
[2019-02-22 07:11:45,725] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriberTwo: <websub><request>Notification</request><type>Internal</type></websub>
[2019-02-22 07:12:00,163] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2019-02-22 07:12:00,162 ERROR [ballerina/websub] - Error delivering content to callback[http://localhost:8181/websubTwo] for topic[http://one.websub.topic.com]: Connection refused: localhost/<IP_ADDRESS>:8181
[2019-02-22 07:12:00,181] INFO {org.ballerinalang.test.context.ServerLogReader} - JSON WebSub Notification Received by websubSubscriberTwo: {"action":"publish", "mode":"internal-hub"}
[2019-02-22 07:12:00,189] INFO {org.ballerinalang.test.context.ServerLogReader} - JSON WebSub Notification Received by websubSubscriber: {"action":"publish", "mode":"internal-hub"}
[2019-02-22 07:12:30,289] SEVERE {org.ballerinalang.test.service.websub.basic.WebSubContentTypeSupportTestCase} - testAuthenticatedTextContentReceiptForInternalHub: FAILED -> Timeout expired waiting for matching log: Text WebSub Notification Received by websubSubscriber: Text update for internal Hub

https://api.travis-ci.org/v3/job/496833194/log.txt

Looking at the logs mentioned in #13924, #13925 and #13926, they all seem to have failed in the same build as this.
Reconstructed log -
[2019-02-22 07:11:45,285] INFO {WebSubContentTypeSupportTestCase} - �[1mtestAuthenticatedTextContentReceiptForInternalHub: �[34m�[1mRUNNING�[0m
[2019-02-22 07:11:45,723] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriber: <websub><request>Notification</request><type>Internal</type></websub>
[2019-02-22 07:11:45,723] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriber: <websub><request>Notification</request><type>Remote</type></websub>
[2019-02-22 07:11:45,724] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriberTwo: <websub><request>Notification</request><type>Remote</type></websub>
[2019-02-22 07:11:45,725] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriberTwo: <websub><request>Notification</request><type>Internal</type></websub>
[2019-02-22 07:12:00,163] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2019-02-22 07:12:00,162 ERROR [ballerina/websub] - Error delivering content to callback[http://localhost:8181/websubTwo] for topic[http://one.websub.topic.com]: Connection refused: localhost/<IP_ADDRESS>:8181
[2019-02-22 07:12:00,181] INFO {org.ballerinalang.test.context.ServerLogReader} - JSON WebSub Notification Received by websubSubscriberTwo: {"action":"publish", "mode":"internal-hub"}
[2019-02-22 07:12:00,189] INFO {org.ballerinalang.test.context.ServerLogReader} - JSON WebSub Notification Received by websubSubscriber: {"action":"publish", "mode":"internal-hub"}
[2019-02-22 07:12:30,289] SEVERE {org.ballerinalang.test.service.websub.basic.WebSubContentTypeSupportTestCase} - �[1mtestAuthenticatedTextContentReceiptForInternalHub: �[31m�[1mFAILED -> Timeout expired waiting for matching log: Text WebSub Notification Received by websubSubscriber: Text update for internal Hub�[0m
[2019-02-22 07:12:30,308] INFO {WebSubContentTypeSupportTestCase} - �[1mtestAuthenticatedTextContentReceiptForRemoteHub: �[34m�[1mRUNNING�[0m
[2019-02-22 07:13:15,310] SEVERE {org.ballerinalang.test.service.websub.basic.WebSubContentTypeSupportTestCase} - �[1mtestAuthenticatedTextContentReceiptForRemoteHub: �[31m�[1mFAILED -> Timeout expired waiting for matching log: Text WebSub Notification Received by websubSubscriber: Text update for remote Hub�[0m
[2019-02-22 07:13:15,316] INFO {WebSubContentTypeSupportTestCase} - �[1mtestUnauthenticatedTextContentReceiptForInternalHub: �[34m�[1mRUNNING�[0m
[2019-02-22 07:14:00,318] SEVERE {org.ballerinalang.test.service.websub.basic.WebSubContentTypeSupportTestCase} - �[1mtestUnauthenticatedTextContentReceiptForInternalHub: �[31m�[1mFAILED -> Timeout expired waiting for matching log: Text WebSub Notification Received by websubSubscriberTwo: Text update for internal Hub�[0m
[2019-02-22 07:14:00,319] INFO {WebSubContentTypeSupportTestCase} - �[1mtestUnauthenticatedTextContentReceiptForRemoteHub: �[34m�[1mRUNNING�[0m
[2019-02-22 07:14:45,321] SEVERE {org.ballerinalang.test.service.websub.basic.WebSubContentTypeSupportTestCase} - �[1mtestUnauthenticatedTextContentReceiptForRemoteHub: �[31m�[1mFAILED -> Timeout expired waiting for matching log: Text WebSub Notification Received by websubSubscriberTwo: Text update for remote Hub�[0m

Closing the other issues and renaming this issue to check on the entire WebSubContentTypeSupportTestCase test itself.

Closing this issue since we've not observed the failure recently.
Please re-open if the failure is observed again, with the complete log if possible.

It seems the issue is still there and I encountered this issue a couple of times in the past few days. Following is an excerpt of the log file.
[2020-05-31 04:50:38,582] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,580 INFO  [ballerina/websub] - Intent verification successful for mode: [subscribe], for callback URL: [http://localhost:23282/websub]   [2020-05-31 04:50:38,589] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,587 INFO  [ballerina/websub] - Intent verification successful for mode: [subscribe], for callback URL: [http://localhost:23282/websubTwo]   [2020-05-31 04:50:38,597] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,595 INFO  [ballerina/websub] - Update notification done for Topic [http://one.websub.topic.com]   [2020-05-31 04:50:38,599] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,597 ERROR [ballerina/websub] - Error delivering content to callback[http://localhost:23181/subscriberWithNoPathInAnnot] for topic[http://one.websub.topic.com]: Something wrong with the connection   [2020-05-31 04:50:38,612] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,611 ERROR [ballerina/websub] - Error delivering content to callback[http://localhost:23181/subscriberWithNoPathInAnnot] for topic[http://one.websub.topic.com]: Something wrong with the connection   [2020-05-31 04:50:38,620] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,620 ERROR [ballerina/websub] - Error delivering content to callback[http://localhost:23181/subscriberWithNoPathInAnnot] for topic[http://one.websub.topic.com]: Something wrong with the connection   [2020-05-31 04:50:38,704] INFO {org.ballerinalang.test.context.ServerLogReader} - JSON WebSub Notification Received by websubSubscriberTwo: {"action":"publish", "mode":"remote-hub"}  [2020-05-31 04:50:38,786] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,785 INFO  [ballerina/websub] - Update notification done for Topic [http://one.websub.topic.com]   [2020-05-31 04:50:38,796] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,794 ERROR [ballerina/websub] - Error delivering content to callback[http://localhost:23181/subscriberWithNoPathInAnnot] for topic[http://one.websub.topic.com]: Something wrong with the connection   [2020-05-31 04:50:38,800] INFO {org.ballerinalang.test.context.ServerLogReader} - JSON WebSub Notification Received by websubSubscriber: {"action":"publish", "mode":"remote-hub"}  [2020-05-31 04:50:38,801] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:38,800 ERROR [ballerina/websub] - Error delivering content to callback[http://localhost:23181/subscriberWithNoPathInAnnot] for topic[http://one.websub.topic.com]: Something wrong with the connection   [2020-05-31 04:50:39,071] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriber: <websub><request>Notification</request><type>Remote</type></websub>  [2020-05-31 04:50:39,071] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriber: <websub><request>Notification</request><type>Internal</type></websub>  [2020-05-31 04:50:39,072] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriberTwo: <websub><request>Notification</request><type>Remote</type></websub>  [2020-05-31 04:50:39,072] INFO {org.ballerinalang.test.context.ServerLogReader} - XML WebSub Notification Received by websubSubscriberTwo: <websub><request>Notification</request><type>Internal</type></websub>  [2020-05-31 04:50:39,541] INFO {org.ballerinalang.test.context.ServerLogReader} - Text WebSub Notification Received by websubSubscriber: Text update for internal Hub  [2020-05-31 04:50:39,543] INFO {org.ballerinalang.test.context.ServerLogReader} - Text WebSub Notification Received by websubSubscriberTwo: Text update for internal Hub  [2020-05-31 04:50:39,556] SEVERE {org.ballerinalang.test.context.ServerLogReader} - 2020-05-31 04:50:39,554 ERROR [ballerina/websub] - Error delivering content to callback[http://localhost:23181/subscriberWithNoPathInAnnot] for topic[http://one.websub.topic.com]: Something wrong with the connection   [2020-05-31 04:51:23,572] SEVERE {org.ballerinalang.test.service.websub.basic.WebSubContentTypeSupportTestCase} - testAuthenticatedJsonContentReceiptForInternalHub: FAILED -> Timeout expired waiting for matching log: JSON WebSub Notification Received by websubSubscriber: {"action":"publish", "mode":"internal-hub"}
Below is the complete log and the link has the gradle build scan summery.
log-websub.txt

Closing the issue as these are enabled now


[WIP] Custom Frameless Menubar (Windows)

Summary:
On MacOS, Guppy has a very nice window decoration integration:

The window controls are cleanly integrated with the sidebar, and all menu controls (File, Edit, etc.) are hidden away in the system bar, as with all Mac applications. On Windows, however, this isn't the case. Windows menus in Electron are very barebones and not very visually appealing. Visual Studio Insiders just recently added the ability to use a more seamless UI by removing the native menubar and adding a themes one in place. I took a page from their book and did the same for Guppy:
Current appearance:

New appearance:

Clearly, this is a stark deviation from the MacOS design, and as such I'm more than willing to find a suitable compromise. The biggest issue we immediately encounter is that Windows UI design dictates that window controls (minimize, maximize, and close) be in square buttons at the top right of the window, so we'll have to do something different from the Mac solution. In addition to this, Windows does not have a system menu bar like Mac, so all menus have to physically live within the application window.
In addition to stylistic changes, there are a few things that need to be improved before this PR is ready for review:

[ ] implement accelerators
[ ] switch active submenus when hovering over a different menu from an active submenu
[ ] find a better way to include menu-item-roles.js from Electron's source
[ ] split FramelessMenu into smaller components
[ ] move FramelessMenu into its own component (?)
[ ] don't break MacOS form or function

Feedback/suggestions are welcomed! Post your ideas, no matter  how rough, here or in the Gitter channel!

Ah interesting! Hm, so I worry about this a bit. My gut reaction is that it may not be worth the added maintenance cost, at least right now.
First, I should say your version looks way nicer :) the default experience on Windows is very lacklustre and I quite like the direction this is going in.
My concern is that it's often a lot of work to perfectly recreate native controls. From the GIF, things look pretty great, but as you point out, there's still a lot to do. Some other things off the top of my head:

Nested menus. I plan on adding a "Switch to:" menu item to Project soon, and it would spawn its own submenu with all the user's projects
Scrolling menus on smaller screens (with the "Switch to", they could conceivably be very long if the user has a lot of projects)
Compliance with screen readers and assistive devices (granted we've thoroughly neglected a11y so far, but I do want to make it work well eventually, and I worry this will make it harder)
Using keyboard shortcuts should flash the menu item it lives within (if this is actually a thing on Windows?)

The native menu is ugly, but it's battle-tested, and we won't get any bug reports about it. I like the idea of not worrying about menu support when I add something new, at least not while our app is still changing rapidly.
I think my instinct is that we do want to do this eventually, but this feels like a late-game thing that we put a lot of effort into to make sure we get it right. Hopefully by then, someone else will have come up with an abstraction that takes care of all of these concerns for us? haha.
Do correct me if I'm wrong in thinking that these concerns would be "our problem" now; it's not entirely clear to me if this theming still uses a native menu under-the-hood (I'm guessing not since we have to reimplement so much, but maybe I'm wrong?)

I totally agree, honestly I was just hacking around and figured I would share. Let's table this until we're at a much more stable spot.
Hey Guppy team in 2019 😁

I totally agree, honestly I was just hacking around and figured I would share. Let's table this until we're at a much more stable spot.

Right, glad to hear it. FWIW I think it looks great and look forward to revisiting =)

When we pick this back up, how about flipping the sidebar to the right side on Windows so we can have the same window control integration as on macOS?

When we pick this back up, how about flipping the sidebar to the right side on Windows so we can have the same window control integration as on macOS?

Hm, I think it's idiomatic to have sidebar navigation on the left-hand side of applications.
Specifically, I stole that layout idea from Slack, so we should check what the Slack windows desktop app does. If other Windows apps have sidebars on the right, I think that's the way to go, but ultimately I'm not too concerned about aligning the window controls with the sidebar.


Added a option "NoGlow" in metrics.ini.

Added a option in metrics.ini to disable flash (or glow in other words) when playing with hidden or sudden mod. Added a under-construction country ranking.

Why is this changing DownloadManager? Seems good otherwise :+1: . I think you might have accidentally commited extra stuff on dlman.
Are you on discord? :P

removed changes in DLMAN as well
now it should be good to go

If you know how to, could you try to squash/combine the last 5 (The ones which are yours) commits into one? You can contact me on discord if you want help with it.

Sure. I squashed the latest commits into one. Please tell me if i did it wrong.


[tlgen] Cleanup power of 2 check function

There are 2 functions defined in tlgen.lib that have the identical function. Remove the duplicated one and use bitmanipulation for more efficient implementation.

@timothytrippel Could you please help reviewing this?


[speech-to-text] enable recognize options

This enables developer able to specify options for STT service such as language model, interim result, and so on.
Test code for all options except one and some audio files are included.
https://www.ibm.com/smarterplanet/us/en/ibmwatson/developercloud/doc/speech-to-text/using.shtml#summary
discussions

WatsonSocket.format is duplicated as SpeechToText.audioFormat
should experimental options included? it is included as comment (not tested)
model names are not included
x-watson-learning-opt-out is not tested

This is awesome!! Thanks for all of your hard work, @dsato80. We're going to go ahead and merge these changes into the code base.
Just so you know, we've been asked to redesign the API for SpeechToText and will be looking at it next week. We will probably write the service from scratch, but will draw from existing code and tests in the process.


Implements new constraint API

Based on https://github.com/apache/brooklyn-server/pull/358 (needs to be merged first)

Failure expected, needs https://github.com/apache/brooklyn-server/pull/354 and https://github.com/apache/brooklyn-server/pull/358

Not valid anymore as https://github.com/apache/brooklyn-server/pull/358 does not change the internal API anymore


Vue package - Incorrect types for emblaApi

Bug is related to

[x] embla-carousel-vue

Embla Carousel version

v7.0.2

Describe the bug
The typings are wrong for emblaApi that are exposed from embla-carousel-vue package. The current type is:

'EmblaCarouselType | HTMLElement'

Expected behavior
The type should be:

'EmblaCarouselType | null'

Additional context
Thanks @rojadesign for reporting this.

@rojadesign I think the types here should be something along these lines:
export type EmblaCarouselVueType = [
  Ref<HTMLElement | undefined>,
  Ref<EmblaCarouselType | undefined>
]

@davidjerleke exactly, I'm on it and will make a PR!

Hi @rojadesign,
I just released v7.0.3 that includes the fix for this type bug. Please update to the latest version and give it a go. Let me know how it goes.
Thanks for reporting this.
Best,
David

@davidjerleke works like a charm, thank you for everything! 🤘🏼

Thanks again for reporting this problem 👍🏻.


mirroring of android 10 screen with audio in Linux (Ubuntu 19.10)

Hi, I'm a noob so sorry if this is a repetitive question and is asked by anyone else because I didnt find my solution.
So, here it is, I want to mirror my Android 10 screen with audio to my linux pc, so that i can use obs studio to stream the screen with audio to youtube.
Currently screen mirroring is working perfectly but the audio is played only on phone. So is there any solution to get audio to linux desktop?

See #14
TL;DR: for now, 2 "solutions":

plug a jack cable between your device and the computer;
use USBaudio if you are lucky and your device still supports AOA audio (without bugs).

See #14
TL;DR: for now, 2 "solutions":

plug a jack cable between your device and the computer;
use USBaudio if you are lucky and your device still supports AOA audio (without bugs).
Thanks, audio jack one is working USBaudio is not working unfortunately. Can i uninstall USBaudio now? Should i jest delete the file or is there any command to remove it.


Revert "Remove a dynamic that is no longer necessary (and the TODO for it)"

Reverts flutter/flutter#80294
I believe this caused a post-submit error:
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr: [   +2 ms] Target dart2js failed: Exception: lib/studies/rally/login.dart:304:24:
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:            Error: A value of type 'bool' can't be assigned to a variable of type 'KeyEventResult'.
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:             - 'KeyEventResult' is from 'package:flutter/src/widgets/focus_manager.dart' ('../../../w/recipe_cleanup/tmpRM1Yor/flutter%20sdk/packages/flutter/lib/src/widgets/focus_manager.dart').
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:                            return true;
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:                                   ^
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:            lib/studies/rally/login.dart:307:20:
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:            Error: A value of type 'bool' can't be assigned to a variable of type 'KeyEventResult'.
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:             - 'KeyEventResult' is from 'package:flutter/src/widgets/focus_manager.dart' ('../../../w/recipe_cleanup/tmpRM1Yor/flutter%20sdk/packages/flutter/lib/src/widgets/focus_manager.dart').
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:                        return false;
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:                               ^
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:            lib/layout/highlight_focus.dart:85:18:
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:            Error: A value of type 'bool' can't be assigned to a variable of type 'KeyEventResult'.
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:             - 'KeyEventResult' is from 'package:flutter/src/widgets/focus_manager.dart' ('../../../w/recipe_cleanup/tmpRM1Yor/flutter%20sdk/packages/flutter/lib/src/widgets/focus_manager.dart').
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:                      return true;
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:                             ^
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:            lib/layout/highlight_focus.dart:87:18:
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:            Error: A value of type 'bool' can't be assigned to a variable of type 'KeyEventResult'.
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:             - 'KeyEventResult' is from 'package:flutter/src/widgets/focus_manager.dart' ('../../../w/recipe_cleanup/tmpRM1Yor/flutter%20sdk/packages/flutter/lib/src/widgets/focus_manager.dart').
[flutter_gallery_v2_web_compile_test] [STDOUT] stderr:                      return false;

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8850109423505652208/+/u/run_flutter_gallery_v2_web_compile_test/stdout

Merging to green the build.

Thanks, @jmagman. Apparently there is more than one place where the gallery gets built? I had updated the customer testing instances, and they passed, but I guess there's another hash I have to update.

Thanks, @jmagman. Apparently there is more than one place where the gallery gets built? I had updated the customer testing instances, and they passed, but I guess there's another hash I have to update.

https://github.com/flutter/flutter/blob/4d54b8966a0f2244a2d4416c0d728f903fc82f40/dev/devicelab/lib/versions/gallery.dart


Adapt P02 to DR P2905R2

P2905R2 make std::make_format_args accepts only lvalues, but P02 assumes that it receives all category of values.

A proposed solution is:
   template<class... Args>
-  auto operator()(Args... args) {
-      return std::vformat(m_s, std::make_format_args(std::forward<Args>(args)...));
+  auto operator()(Args&&... args) {
+      return std::vformat(m_s, std::make_format_args(args...));
   }

It's necessary to remove use of perfect forwarding in all calls to std::make_format_args.
The changes are a bit too large to fit into "good first issue" IMO. I'm taking this.

The changes are a bit too large to fit into "good first issue" IMO.

I just think people in Loser Kingdom are all elite, but yours does make sense. @frederick-vs-ja


Better rest api usage

Use Accept arg in the header of the requests call to get a list of changed files. If a token is supplied, then it is included in the header's Authorization arg. This idea might be applicable to all REST API calls, but for security reasons (and I haven't verified with the REST API docs), it is only applied to the get_list_of_changed_files().
I'm not confident, but I think this should address #38

I have recently started using a VSCode extension that checks spelling. So, I also fixed some spelling errors in the python source code.

Seems my fork's master branch has a messed up history. And, I can't seem to rebase on upstream's master branch (instead of my fork's master branch).

closing this and re-opened it on a different branch (with clean git history) - see #40 instead.


[Content Fragment] Extend ContentFragment Model

Fixes https://github.com/dust-tt/dust/issues/4239
Description
Limited to the model update
Deploy Plan

init_db from prodbox
deploy front

Exciting!


General Issue: convert to testthat3e

Background Information
Slack conversation and link: https://testthat.r-lib.org/articles/third-edition.html

Definition of Done
No response

Closing this. All done in Issue #1754


Split Install of Operator and CR into 2 steps

This PR is to split the installation make targets into 2 optional targets.

First to install the operator
Second to apply the CR

We aim to include the registration operator in our installer, and would prefer if we could separate this logic into the above steps to better fit our install processes.

/assign pmorie

@pmorie not quite sure why lgtm label is added, but i think we can use this pr to trigger postsubmit when build-harness is ready.

not quite sure why lgtm label is added

Nathan approved the PR in the github UX, which is translated into lgtm tag if someone is in the org or a collaborator afaik.

/approve


ENH: BQ Job Id in verbose output

Hi,
After few years of BQ usage I've reached point where I need to report support case to Google BQ Team.
I've attached my iPython notebook with pandas gbq output, but they needed query Job IDs.
This is simple change to add them in read_gbq.
I'm not using to_gbq at all so I've not added verbose output for it when I implemented read_gbq some time ago. Today it is still not much verbose so I leaving things as they are.

Codecov Report

Merging #70 into master will decrease coverage by 45.16%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master      #70       +/-   ##
===========================================
- Coverage   73.37%   28.21%   -45.17%
===========================================
  Files           4        4
  Lines        1540     1542        +2
===========================================
- Hits         1130      435      -695
- Misses        410     1107      +697

Impacted Files
Coverage Δ

pandas_gbq/gbq.py
19.28% <0%> (-55.87%)
:arrow_down:

pandas_gbq/tests/test_gbq.py
27.94% <0%> (-54.94%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd53b5c...f8c6a24. Read the comment docs.

can you add a note in the whatsnew? otherwise lgtm.

ok, here goes changelog entry


Content switcher

closes https://github.com/IBM/carbon-ui-builder/issues/139

Not sure why the deploy preview link isn't showing up, had to go through netlify requests to get the preview link. I believe it is the latest: https://deploy-preview-142--carbon-components-builder.netlify.app/

@MoizMasud DCO fails, can you run this command in this branch:

In your local branch, run: git rebase HEAD~11 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin content-switcher


Data Overlapping between single_tool_data/map_7k.json and single_tool_test_data/map.json

I find that there exists data overlapping between single_tool_data/map_7k.json and single_tool_test_data/map.json.
For example:
single_tool_data/map_7k.json:

single_tool_test_data/map.json:

Can you explain why?  Is that a tag leakage？Thank you！

Hi! Thanks for pointing it out. I believe this is probably a data leakage because we randomly split all the data without checking the overlap in the data. BTW, we will release our toolbench-v2 in 1~2 weeks, there will be a huge update for all the designs.


Added more footer components

Added More Footers

Closes #824
Description👨💻

I have added

Parallax Footer
Split Footer
Interactive Footer
Sticky Footer
and i have Added these footers to footers page in asset

Type of Change📄

[ ] Bug fix (non-breaking change which fixes a bug)
[X] New feature (non-breaking change which adds functionality)
[ ] Style (non-breaking change which improves website style or formatting)
[ ] Documentation (non-breaking change which updates or adds documentation)
[ ] Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

[X] I am an Open Source contributor
[X] I have performed a self-review of my code
[X] My code follows the style guidelines of this project
[X] I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

@Rakesh9100 Please label this PR under level3 in GSSoc

Pls separate CSS files in style.css file and JS to script.js wherever required and make the new commits in this same PR @SuhainaFathimaM

@Rakesh9100 added separate css files and js files

@Rakesh9100 Please merge this PR under GSSoC.. Its been long time since I created this PR

@Rakesh9100  I have made corrections long time ago


Model deadline

Is the model deadline still 14th April, despite the delay in the challenge starting and the starter repo being available? Thanks!

hi @finlayiainmaclean, thank you very much! No extensions to the deadline are planned.
We unfortunately do not have flexibility to adjust the timeline because the challenge is linked to the MLDD workshop at ICLR where we plan to announce the winners. Many thanks for your understanding and best of luck! 🥇


Missing space character

Version
Microsoft Windows [Version 10.0.22000.527]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
20.04
Other Software
No response
Repro Steps
wsl --update
Expected Behavior
After a successful update you will be asked to shutdown the WSL with ```wsl--shutdown``. There is just one space missing.
Actual Behavior
nothing ^^
Diagnostic Logs
No response

What locale of Windows are you using? Looks like a translation issue because the en-US is fine.

Hi. I use the German language pack. Unfortunately I can't attest to it with a picture until another update comes. I used the German language pack. You are right. In the English one this does not occur. But this is not really a problem, because you can see that something is missing. I just wanted to say it :)
The one picture shows that my WSL is up to date and therefore I can't show that and the other picture shows where the spacebar is missing. The second picture is from the Internet.

What locale of Windows are you using? Looks like a translation issue because the en-US is fine.

I'm afraid I don't quite know what you mean. I use Windows in German language. I think what you want to know is .
de_DE

I uninstalled and reinstalled my WSL once. Now I can show you this properly.

Hi @benhillis
I don't think anything else will happen here.  Therefore I close the issue. Furthermore, it is not really a problem, because everyone understands where the spacebar is missing.
With kind regards
@Riffecx


More of this type of doc

I would love to see more architectural recommendations like this across the codebase.  This particular problem is one that we have been solving for years and its good to hear an official stance on it. Keep up the good work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c250b3d-fba0-02fb-5339-795bc0bfabb6
Version Independent ID: e65c6e5f-95db-0d6f-ab01-5b3d76dbff6e
Content: Proven Practices for SharePoint Online Portals - Navigation Solutions
Content Source: docs/solution-guidance/portal-navigation.md
Service: unspecified
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

@VesaJuvonen

Feedback received... will take note of it. Closing this issue as it doesn't have a specific action to take.


Add trim commands along with low level PB API

Follows #11 . This pull request includes:

Low level PB protocol definitions and their implementations at FLU server
Introduces a change at
Actual trim command that leaves a trim mark checksum file

A read_chunk() will return {error, trimmed} if that chunk is trimmed. If a arbitrary read request that does not match trim-table, the flu server returns raw data in the file without checking whether it's trimmed or not. But that will be done in the next-next-(^10) pull request.

@mrallen1 and @shino, would you mind also reviewing this PR?

@slfritchie , thanks for bringing up race conditions! My pull request was terrible. I should have thought more carefully. I'll open a new pull request after weekend, with

rebased to latest master
cool race condition matrix of read, write, trim / unwritten, written, trimmed, mix-of-three-states
code update

Plus,

updated PB low/high level protocols
some refactoring around CR client (maybe, current code has some non-DRY parts)


Changed isAlive to is_alive

Hi there!
Fantastic work on this package! It's such an amazingly simple way of avoiding to overload APIs with unnecessary requests!
I noticed however that there was a deprecation warning popping up sometimes, namely:
 "cachier\pickle_core.py:204: DeprecationWarning: isAlive() is deprecated, use is_alive() instead   if observer.isAlive():"
As far as my quick searches seem to tell me, the isAlive is still a remainder from the Python 2 support, which has been dropped in cachier from version 1.2.8, so I assume this can be updated :)

This looks great! I'm merging this right away!


Add a CLI tool

Even though October is a GUI tool, it'd be neat to expose a CLI entrypoint on the side for users who don't want to spin up a GUI or automate uploading. No idea if that's possible though.

A pre-release version that includes a CLI tool is available here: https://github.com/marcus-crane/october/releases/tag/v1.9.0-beta1

Closed by the release of v1.9.0


catppuccin-kde: unstable-2022-11-26 -> 0.2.2

Description of changes
Updated the theme to the newest tagged revision. The main change is an installation script with accent options. Unfortunately, this script takes user input, so I had to modify it to work with a declarative install. The package allows for any combination of theme flavours and accents to be installed.
https://github.com/catppuccin/kde/releases/tag/v0.2.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

User inputs can be emulated with expect, I think that is more maintainable than recreating the installation logic ourselves.

The script doesn't entirely recreate the installation logic, it mostly justs replaces the user input with environment variables. A problem with using expect is that the script takes numbers, not flavour and accent names. I'm not sure how I'd convert from the set flavours and accents to the numbers for the input.


[BUG] belongs_to association is blank in form

Versions Used
Kaffy: 0.8.1
Phoenix: 1.5.3
Elixir: 1.10.3
What's actually happening?
In my Ex338 project, fantasy_team belongs_to association is blank in the form for owners.
EDIT: After further investigation, it looks like it uses commish_notes which is the first string alphabetically, but is blank for all of my seed fantasy teams.
  schema "owners" do
    belongs_to(:fantasy_team, Ex338.FantasyTeams.FantasyTeam)
    belongs_to(:user, Ex338.Accounts.User)
    field(:rules, OwnerRulesEnum, default: "unaccepted")

    timestamps()
  end

  schema "fantasy_teams" do
    field(:team_name, :string)
    field(:waiver_position, :integer)
    field(:winnings_adj, :float, default: 0.0)
    field(:dues_paid, :float, default: 0.0)
    field(:winnings_received, :float, default: 0.0)
    field(:max_flex_adj, :integer, default: 0)
    field(:commish_notes, :string)
    field(:autodraft_setting, FantasyTeamAutodraftSettingEnum, default: "on")
    field(:slot_results, {:array, :map}, virtual: true, default: [])
    field(:total_seconds_on_the_clock, :integer, virtual: true, default: 0)
    field(:avg_seconds_on_the_clock, :integer, virtual: true, default: 0)
    field(:total_draft_mins_adj, :integer, default: 0)
    field(:picks_selected, :integer, virtual: true, default: 0)
    field(:over_draft_time_limit?, :boolean, virtual: true, default: false)
  end

What should happen instead?
sports_league belongs_to association displays abbrev in the form for fantasy_players.
  schema "fantasy_players" do
    field(:player_name, :string)
    belongs_to(:sports_league, Ex338.FantasyPlayers.SportsLeague)
  end

  schema "sports_leagues" do
    field(:league_name, :string)
    field(:abbrev, :string)
    field(:hide_waivers, :boolean)
  end

Screenshots

Select options are blank, but the options are generated

After further investigation, I don't think this is a bug.  It is using the commish_notes field which is blank for all of my fantasy teams.  When I add a note, it shows up in the select.  However, I'd like to propose the same convention discussed in #97.

My #99 pull request would close this issue as well since the form uses the same function.

Perfect 👍🏼


Add Spinner Page

圆圈问题已解决，使用了原型内的样式，showcase文件一并上传以便后续修改

I think you don't need to upload the show case page. Instead, please add the showcase source code link to the spinner widget. You can refer to the link whenever you want to find it.


feat: add azure pipelines

This PR adds Azure Pipelines to the project
Notes: I'm not sure if we can test this before adding it to the master branch. I have tried going through the UI to see if it recognizes the addition of the azure-pipelines.yml file, but it only seems to check the master branch. 😕

@all-contributors please add @brian-dlee for review

@all-contributors please add @ajtorres9 for ideas

@all-contributors please add @brian-dlee for ideas

@all-contributors please add @brian-dlee for question


InvaildCastException occurs when the argument is passed in as a collection expression

Describe the bug

InvaildCastException occurs when the argument is passed in as a collection expression
传入参数为集合表达式时会发生 InvaildCastException
To Reproduce

Compositor. CreateEffectFactory() have multiple overloaded method, one of the second parameter for IEnumerable, at this time if in the second parameter to set expression directly, causing InvaildCastException
Compositor.CreateEffectFactory() 方法有多个重载，其中一个第二个参数为 IEnumerable，这时如果在第二个参数中直接传入集合表达式，引发 InvaildCastException

Expected behavior

Provide warning or support collection expression in parameter
Version Info

CsWinRT 2.1.1
Windows SDK 10.0.26100.0
.NET SDK 9.0.0-preview7
Additional context

Found in the process of debugging, set the type of the expression is <>z_ReadOnlySingleElementList
调试的过程中，发现集合表达式生成的类型是<>z_ReadOnlySingleElementList

@manodasanW I think we should not use source generator at the first place, instead we should generate an assembly just like what WPF does, so that things like this can get covered.

Sergio did bring up a related idea with separate assembly for the generic instantiations and vtable lookup table that is being considered.  But I don't think that would solve this problem where these are internal .NET types that CsWinRT won't directly be aware of unless you were thinking of something there?
The plan to address that is to make use of the statically known interface on the projection and provide a vtable for that when the one for the class isn't available.  This is tracked by #1661.  The tricky part will be minimizing size impact.


Implement general circuit

Implement steps shown in this article with circom. Use folding schemes algorithm to make it foldeable.

[ ] Add signature verification part to the circuit


[Bug]: missconfigured Text file output makes HOP-Gui freeze

Apache Hop version?
2.9.0
Java version?
jdk-11.0.24+8
Operating system
Windows
What happened?
I removed a field (named "File Content") in the transform right before my "Test file output"-transform.
When running it, hop GUI freezes. This is written to stdOut:

Issue Priority
Priority: 3
Issue Component
Component: Hop Gui

Tried to reproduce in MacOS, Linux and Windows, but couldn't. the error is there, but Hop Gui keeps responding.
Is your pipeline reading from a relational database or some other source? Do you have a pipeline that you can share as a reproduction path?

it seems that also the javascript transform is failing.
So it might be that one and not text file output

tried with both a text file output and the javascript + text file output combination, but we'll need a more detailed reproduction path.

Thanks for your testing. I could reproduce it now. But first time it worked, then I removed some more fields and then it froze again.

tryToRproducee.zip

I can't reproduce this in 2.10.0-SNAPSHOT so let's place this ticket on hold until the next release and come back to it if the problem still persists.


Multi-hot additional features in NER

I am trying to use additional features in NER (ner_rus model), but I have problems with modifiyng your code for this task. Could you help me with some advice? In my case each token has from 1 to 11 different features from one list, so it would be nice represent this by multi-hot vector, however, as I know, deeppavlov doesn't have multi-hot vectorizer. I was trying to use 11 one-hot vectorizers and sum up resulting vectors, but they should have one aggregate vocabulary to have the same dimentionality. From your config jsons (example below) I assumed that if I write config like below, I would create "sem" vocabulary and automaticaly create "sem_ind" feature to each token and transform it to "sem_one_hot" - one-hot vector for each token. But I need to have the first two steps separately - create one vocabulary (from all of my "feat1", "feat2" etc. altogether) and then use it to crate indices and one-hot vectors for each of "feat1", "feat2" etc. What is the easiest way to do that? Or maybe there is a simplier approach to add multi-hot features?
{
"in": ["sem_all"],
"id": "sem_vocab",
"class_name": "simple_vocab",
"pad_with_zeros": true,
"fit_on": ["sem_all"],
"save_path": "{MODELS_PATH}/ner_rus/sem.dict",
"load_path": "{MODELS_PATH}/ner_rus/sem.dict",
"out": ["sem_ind"]
},
{
"in": ["sem_ind"],
"class_name": "one_hotter",
"depth": "#sem_vocab.len",
"pad_zeros": true,
"out": ["sem_one_hot"]
},

Hello!
This is very simple to perform such operation.
Preprocessor one_hotter actually supports multi-label one-hot vectorization. If you initialize one-hotter with the following params, you will obtain one-hot multi-label vectorization.
{
"in": ["sem_ind"],
"class_name": "one_hotter",
"depth": "#sem_vocab.len",
"pad_zeros": false,
"single_vector": true
"out": ["sem_one_hot"]
},


Update Puppet packages (puppet-lint, puppet-bolt, r10k)

Description of changes

Upgrade puppet-lint: https://github.com/puppetlabs/puppet-lint/compare/2.5.2...v4.2.4
Upgrade puppet-bolt: https://github.com/puppetlabs/bolt/compare/3.24.0...3.28.0
Upgrade r10k: https://github.com/puppetlabs/r10k/compare/3.4.1...4.0.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 298650 run on x86_64-linux 1

4 packages built:

pdk
puppet-bolt
puppet-lint
r10k

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1579


how can i know what't version of my database schema

after installing application on device how can i know find schemaVersion in database file? my mean is sqlite file in device

You could use the beforeOpen callback for migrations. That callback is run every time the database opens and contains all the necessary information. details.versionBefore contains the version of the database file before opening, details.versionNow contains the current version after migrations ran.


[0.9.0b4] New Ribbon Bar: first impressions

My first impression of the new Ribbon Bar is that I hate it, but I immediately realised that it was not the functionality that I hated but the superficial things like colour and font and so forth which are relatively easily fixed.
Please note: these comments represent a subjective view of personal design likes/dislikes and as such should only be acted upon if there is some general consensus amongst the devs.
Font
This currently uses a Serif font whereas the whole of the rest of MK uses a Sans Serif font. This really clashes IMO.
Colour
A. The lack of colour background fill was the other thing that jars in a major way. I am not particularly wedded to the blue background in previous versions, but I feel that using a different background colour to the other panes helps to highlight that this is a more important pane.
B,. Highlight colours are IMO too dark - they are overpowering and make it less easy to read the text. I am not wedded to the old colour scheme particularly, but the way the colours changed for active tab or as you moused over the sub-groups and buttons was much better in previous versions.
Group boxes
The curved corners are different to all other panes, and this also jars. I would suggest losing these curved corners.
Additionally, it is difficult to know what it will look like without curved corners, but it might look as good/better using a single box with vertical bars separating the sub-groups.
Truncated text
"Naviga..." vs. "Navigation", "Control..." vs. "Controller". This may be fixed by a change of font as SS fonts are often slightly narrower than S fonts. Alternatively, shrink the font slightly for all button names until they all fit.
There is already autoshrink functionality - I think all you need to do is uncouple the icon and text autoshrink functionality, and autoshrink the text variably to fit.
Bottom Margin
We have lost the sub-group titles at the bottom (which is not an issue for me) however that means we now have a bottom margin which is bigger than it needs to be. Can we reduce the minimum height of this pane?
Tabs
A. Can we centre the tab titles in the tabs?
B.  We have lost the design tab - because it has been replaced with a Tools pane. I think the Design tab (or a Tools tab) should still be there, with the Tools pane as an option.
C. Gap between tabs perhaps should be narrower - or alternatively mirror the functionality of previous versions where the tab outline only appears when active (which makes it feel more like a hybrid tabs/menu than pure tabs).
Tools pane
I like this concept, but there are several issues with this new pane.
A. Minimum pane width is too narrow with the vertical layout it needs to be set so that the icons are always shown.
B. Vertical-only layout is way too inflexible - the layout needs to be adaptive to the width of the panel it is in so that you can have it in a horizontal panel or together with other panes in a wide vertical panel. This is the only thing stopping me from moving to 0.9 for permanent production use.
C. Tooltips do not appear when you mouseover a disabled tool (e.g. if you have nothing selected)- this is less important (so if it is difficult to achieve forget it), but I think it would be helpful to still have a tooltip over disabled items (perhaps with additional text explaining that you need to select items to enable it).
Functionality
Wordlist button has lost its dropdown submenu.
Modify tab
Icons are fuzzy/illegible. Slightly large or thicker-lined icons would be beneficial.
P.S. I did a first burn in this beta and it worked fine. I look forward to experimenting with the improvements once the Tools pane layout is improved.

My first impression of the new Ribbon Bar is that I hate it, but I immediately realised that it was not the functionality that I hated but the superficial things like colour and font and so forth which are relatively easily fixed.

And the stuff that it fixes were really hard to deal with and not superficially fixed. They were, in fact, pretty much terrible solutions.

Please note: these comments represent a subjective view of personal design likes/dislikes and as such should only be acted upon if there is some general consensus amongst the devs.

Nah, frankly all the devs, including myself aren't that great at design stuff. And this was more whipped up to fix the issues where the older ribbonbar was kind of stuck into the given methods laid out in the ribbonbar class.

A. The lack of colour background fill was the other thing that jars in a major way. I am not particularly wedded to the blue background in previous versions, but I feel that using a different background colour to the other panes helps to highlight that this is a more important pane.

This was sort of due to the colorlessness of dark mode ribbonbar. Since it was the color of the background stuff, and this sort of copied that.

B,. Highlight colours are IMO too dark - they are overpowering and make it less easy to read the text. I am not wedded to the old colour scheme particularly, but the way the colours changed for active tab or as you moused over the sub-groups and buttons was much better in previous versions.

Yeah, this is unknown why this color change happens it could be that I failed to understand the art or it was doing a much more pronounced gradient and thus was much dimmer.

The curved corners are different to all other panes, and this also jars. I would suggest losing these curved corners.

It was copied, moreorless, from the original ribbonbar.

We have lost the sub-group titles at the bottom (which is not an issue for me) however that means we now have a bottom margin which is bigger than it needs to be. Can we reduce the minimum height of this pane?

B. We have lost the design tab - because it has been replaced with a Tools pane. I think the Design tab (or a Tools tab) should still be there, with the Tools pane as an option.

Tools sort of got moved mostly to the tools bar at the edge. The hope was to reduce the total number of icons there to something much more reasonable.

B. Vertical-only layout is way too inflexible - the layout needs to be adaptive to the width of the panel it is in so that you can have it in a horizontal panel or together with other panes in a wide vertical panel. This is the only thing stopping me from moving to 0.9 for permanent production use.

Not sure if it needs a Pane Reset or the latest version of the code, but it works in either orientation.

C. Tooltips do not appear when you mouseover a disabled tool (e.g. if you have nothing selected)- this is less important (so if it is difficult to achieve forget it)

This was actually done by default and we added code to suppress them in that case since they were disabled and the original ribbonbar didn't show such things.

Wordlist button has lost its dropdown submenu.

There might be 2 of them.

Icons are fuzzy/illegible. Slightly large or thicker-lined icons would be beneficial.

I think the icon size is determined by the space available.

Bit of an older list of differences I noted between the old and new bars.
As far as the older version goes. We also had:

Names of panels on the panels at the bottom that did sort of annoying highlighting when moused over.
The mouse over color was a tint of yellow gradient, not like total blue.
The tab mouse over was only the top in lightish blue and bottom remained the same (might have been supposed to be a gradient)
If the width was not wide enough to support all the icons the panel with the most item would double up the last 2 items, until no two items could do this. When all items were done, the next longest was applied in the same manner.
If the width was still not wide enough, the panel would be minimized into a single dropdown of minimized mode.
Position of the button were equally spaced along the height for the excess height that was available.
Pair stacked buttons had their labels on the right.
When the height was not-sufficient, all the panels would minimize making the whole thing sort of look horrible.
The  path around the page and tab didn't have a boundary, it went around the table and then around all the panels all the way to the edge. It was not two distinct rectangles.
Text label had real type-setting rather than each space. It would break text in a greedy fashion with regard to width.

Thanks for considering my opinions.
@jpirnay:
I have not tried resizing the ribbon bar except for trying to see what happens if I reduce the width when on minimum height - and that is what my comments about icon/font sizing are based on. The icon autoscaling looks very good to me based on this very limited testing - my comments on ribbon bar sizing were focused only on text autosizing.
However the screenshots above of Tools pane resizing was not the experience I had. I turned on the Tools pane for the first time, and it appeared in its own vertical panel. I was able to reduce the width of that panel to much much less than the width of  a single icon. I then docked it (by accident) on another vertical panel which was significantly wider and it didn't look like the pictures you posted - from memory the frames were the correct width but the icons were not laid out as shown in your screenshots.
And yes - the purpose of a beta program is to get feedback!! Hence my feedback. (Though I also give feedback on full releases.)

@tatarize:

And the stuff that it fixes were really hard to deal with and not superficially fixed. They were, in fact, pretty much terrible solutions.

You need to do what you need to do for functional purposes and then make the look as good as fit as you can as a secondary priority.

The curved corners are different to all other panes, and this also jars. I would suggest losing these curved corners.

It was copied, moreorless, from the original ribbonbar.

This may of course be a Windows vs. Mac vs. Linux thing. On Windows the frames have square corners (or possibly a tiny radius curve) but definitely not like this.
But IMO home grown widgets need (if possible) to match the style of the standard widgets on each operating system - which may mean o/s specific code on the home grown widgets to make it match for each o/s.

Nah, frankly all the devs, including myself aren't that great at design stuff. And this was more whipped up to fix the issues where the older ribbonbar was kind of stuck into the given methods laid out in the ribbonbar class.

As I have said previous UI stuff is hard in an absolute sense, even for UI specialists, and it is as much of an art as a science too. And my experience in IT for 40 years suggests that most (if not all) developers have difficulties creating good UI/UX. So don't feel bad about this!!!!

Tools sort of got moved mostly to the tools bar at the edge. The hope was to reduce the total number of icons there to something much more reasonable.

As I say, I like the idea of the Tools pane very much. I would suggest that the default for the Tools pane is ON rather than OFF. The reason I missed the Design tab is because the Tools pane was not showing by default - but if screen real-estate is an issue, then the user might still prefer a tools ribbon bar. (As an aside, I think that having screen layout profiles might be a nice idea - we can populate the default list with a few examples, and users can then save and load (and export/import) their own.

C. Tooltips do not appear when you mouseover a disabled tool (e.g. if you have nothing selected)- this is less important (so if it is difficult to achieve forget it)

This was actually done by default and we added code to suppress them in that case since they were disabled and the original ribbonbar didn't show such things.

Well - having found the Design tab missing and made the Tools panel appear, I mouseovered each icon to see what it was and got no tooltip for those that were disabled, and without knowing what they did I had no idea how to enable them to get a tooltip in order to find out what they did. (I guessed because I am an experienced user - but others just starting with MK and trying to work out how the UI operates may just find it confusing.)

Icons are fuzzy/illegible. Slightly large or thicker-lined icons would be beneficial.

I think the icon size is determined by the space available.

Yes - I already commented that I like the autosize - but at all the various icon sizes, the icons need to be clear rather than fuzzy. You may need to use a paint program like GIMP to tweak the icons so that they look good at each size.

Names of panels on the panels at the bottom that did sort of annoying highlighting when moused over.

Actually, (on Windows at least) it was highlighting on mouseover of the panels themselves. And I find it a good UX because it helps you to understand what is happening in a very low key way. As I already said, I do not miss these sub-group names.

The mouse over color was a tint of yellow gradient, not like total blue.

Not yellow for me - on Windows (or Windows with the colour scheme I use). Part of standard widgets is that they adapt to O/S and to the O/S colour scheme chosen by the user, and home grown widgets really ought to do the same (though it is a PitA to have to program this).

If the width was not wide enough to support all the icons the panel with the most item would double up the last 2 items, until no two items could do this. When all items were done, the next longest was applied in the same manner.

This old behaviour was OK, but I actually prefer the new autosizing behaviour anyway - so a good UI decision AFAIAC.

Text label had real type-setting rather than each space. It would break text in a greedy fashion with regard to width.

Yes - wrapping text onto two lines is OK but IMO truncating using elipses is not.

Tools pane is ON rather than OFF.

It should have been on. Really I think the issue is that the saved perspective is still there and valid and it didn't have a tools pane. I would think it would show up but it's entirely possible that it doesn't. The same is true for the ribbonbar not able to dock for the side panes, where that's actually just that the settings were saved in the .perspective in the settings and thus is sort of stuck that way. Does it for min and max for the ribbonpane too which is sometimes a problem.

I mouseovered each icon to see what it was and got no tooltip for those that were disabled, and without knowing what they did I had no idea how to enable them to get a tooltip in order to find out what they did.

Could do mouse over on disable since disabled is just art. But, I'm not sure. (DISABLED) Blah Blah maybe. Dunno.

Part of standard widgets is that they adapt to O/S and to the O/S colour scheme chosen by the user,

Yeah, I used the previous art that @frogmaster set up for the routine and some of it was taken from the background of the users OS.
There's a bunch of subtle stuff in the UI there, but the fact that we can have dynamic vertical tools matters a lot. Also, for very small screens it doesn't keep taking up most of the screen and is apparently usable.
There's also an issue with the individual node-editor tool. The older version before I broke it and lost most of the features, would make it's own toolbar, and I sort of wanted the ability to swap out the side toolbar there. Though I didn't yet, code that switch in, fix the node-editor to restore the features, or use it for that, it was (before this) impossible to do that.

@Sophist-UK I understand you are using released versions for your tests only (and I get that), still the latest source does contain some adjustments to take the current feedback into consideration. (Some of it already in the latest beta, but not all). Maybe worth a look or two.

I downloaded the new beta earlier but haven't had a chance to look at it yet. Whilst I intensely dislike the look of the new ribbon bar I can live with that for real use. But I need to see if the Tools pane is useable or not - I only had a quick initial impression last time and it didn't reconfigure itself well based on the panel size when I tried it, but it really needs more testing to see if it is liveable.
As for my existing ribbon bar critique, A) I don't expect you to change based only on the opinions of a single user, and B) such changes take time. So don't worry - I am not expecting perfection, not yet at least 😄 .

What is the point of people like me giving early feedback on the usability, look and feel of BETA versions if you take no notice / take no action on the comments made in all the subsequent betas and release candidates.
I appreciate that functional issues need to take priority over form issues, but still there appears to be a complete lack of interest in whether MK has a good look and feel or not.

Summarising the status of the different issues might help:

[x] This currently uses a Serif font whereas the whole of the rest of MK uses a Sans Serif font.
[ ] Colour background fill too dark
[ ] Highlight colors too dark
[x] Round corners of group boxes were reduced in size but have been there in  previous versions too
[x] Truncated text
[x] Bottom Margin
[x] Centre the tab titles in the tabs
[x] We have lost the design tab. We have added a toolbar designer in settings where you can add that again if you like
[x] Gap between tabs perhaps should be narrower
[x] Minimum pane width is too narrow
[x] Vertical-only layout is way too inflexible
[x] Tooltips do not appear when you mouseover a disabled tool
[x] Wordlist button has lost its dropdown submenu see comment above
[ ] Icons are fuzzy/illegible. Slightly large or thicker-lined icons would be beneficial This would require a major overhaul of the icon scheme (and the terms of use of relying on icons8)

[ ] No colour background.

I have opened a new issue helping us to focus on the remaining tasks - if there are no objections I would close this one tomorrow (the new issue is linking to this discussion for reference)

Closing in favour of #2154