pprof panic on recent toolchains

This simple program panics on recent toolchains
use pyroscope::PyroscopeAgent;
use pyroscope_pprofrs::{pprof_backend, PprofConfig};

fn main() {
    let pprof_config = PprofConfig::new().sample_rate(100);
    let pprof_backend = pprof_backend(pprof_config);

    let pprof_agent =
        PyroscopeAgent::builder("https://asd.net", "qwe")
            .basic_auth("xxx", "xxxx")
            .backend(pprof_backend)
            .build().unwrap();

    let running_agent = pprof_agent.start().unwrap();

    let (add_tag, _) = running_agent.tag_wrapper();

    let _ = add_tag("connections".to_string(), 10.to_string());
    let _ = add_tag("watchers".to_string(), 10.to_string());

    running_agent.stop().unwrap().shutdown();
}

panic:
/home/korniltsev/.cargo/bin/cargo run --color=always --package pg --bin pg
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s
     Running `target/debug/pg`
thread 'main' panicked at library/core/src/panicking.rs:221:5:
unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`
stack backtrace:
   0: rust_begin_unwind
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/std/src/panicking.rs:661:5
   1: core::panicking::panic_nounwind_fmt::runtime
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/panicking.rs:112:18
   2: core::panicking::panic_nounwind_fmt
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/panicking.rs:122:5
   3: core::panicking::panic_nounwind
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/panicking.rs:221:5
   4: core::slice::raw::from_raw_parts::precondition_check
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/ub_checks.rs:68:21
   5: core::slice::raw::from_raw_parts
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/ub_checks.rs:75:17
   6: <pprof::collector::TempFdArrayIterator<T> as core::iter::traits::iterator::Iterator>::next
             at /home/korniltsev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pprof-0.12.1/src/collector.rs:225:26
   7: core::iter::traits::iterator::Iterator::fold
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/iter/traits/iterator.rs:2587:29
   8: <core::iter::adapters::chain::Chain<A,B> as core::iter::traits::iterator::Iterator>::fold
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/iter/adapters/chain.rs:126:19
   9: core::iter::traits::iterator::Iterator::for_each
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/iter/traits/iterator.rs:818:9
  10: pprof::report::ReportBuilder::build
             at /home/korniltsev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pprof-0.12.1/src/report.rs:110:17
  11: pyroscope_pprofrs::Pprof::dump_report
             at /home/korniltsev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyroscope_pprofrs-0.2.7/src/lib.rs:202:22
  12: <pyroscope_pprofrs::Pprof as pyroscope::backend::backend::Backend>::add_rule
             at /home/korniltsev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyroscope_pprofrs-0.2.7/src/lib.rs:180:13
  13: pyroscope::pyroscope::PyroscopeAgent<pyroscope::pyroscope::PyroscopeAgentRunning>::tag_wrapper::{{closure}}
             at /home/korniltsev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyroscope-0.5.7/src/pyroscope.rs:776:17
  14: pg::main
             at ./src/main.rs:18:13
  15: core::ops::function::FnOnce::call_once
             at /rustc/6292b2af620dbd771ebb687c3a93c69ba8f97268/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
thread caused non-unwinding panic. aborting.

Process finished with exit code 134 (interrupted by signal 6:SIGABRT)

Looks like it's problem in pprof-rs crate, which won't be fixed any soon as it looks abandoned (last update was almost a year ago). As I understood from googling, the problem has always been there, but started panicking only recently (at rust 1.78.0). So, downgrading may be a workaround, maybe?

https://github.com/tikv/pprof-rs/issues/232

I receive the same error on M1 with pyroscope for Rust on Macos M1
thread '' panicked at library/core/src/panicking.rs:219:5: unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceedisize::MAXstack backtrace: 0: rust_begin_unwind at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/std/src/panicking.rs:652:5 1: core::panicking::panic_nounwind_fmt::runtime at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/panicking.rs:110:18 2: core::panicking::panic_nounwind_fmt at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/panicking.rs:120:5 3: core::panicking::panic_nounwind at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/panicking.rs:219:5 4: core::slice::raw::from_raw_parts::precondition_check at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/ub_checks.rs:68:21 5: core::slice::raw::from_raw_parts at /rustc/3f5fd8dd41153bc5fdca9427e9e05be2c767ba23/library/core/src/ub_checks.rs:75:17 6: pprof::addr_validate::validate at /Users/deanhunter/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pprof-0.12.1/src/addr_validate.rs:93:28 7: <pprof::backtrace::frame_pointer::Trace as pprof::backtrace::Trace>::trace at /Users/deanhunter/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pprof-0.12.1/src/backtrace/frame_pointer.rs:114:17 8: perf_signal_handler at /Users/deanhunter/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pprof-0.12.1/src/profiler.rs:354:13 9: ___simple_bprintf note: Some details are omitted, run withRUST_BACKTRACE=fullfor a verbose backtrace. thread caused non-unwinding panic. aborting.


custom ignore_for_file in generated dart file

Is your feature request related to a problem? Please describe.
Show too much lint messages in VSCode problem panel, if I had defined some strict lint rules in analysis_options.yaml.
Even if I add a exclude config in analysis_options.yaml, As soon as I open the generated code file in VSCode, the exclude option does not work and the lint error is displayed again.
Describe the solution you'd like
Add a config in flutter_rust_bridge.yaml, something like to the preamble config in ffigen

Key
Explaination
Example

preamble
Raw header of the file, pasted as-it-is.

preamble: |
  // ignore_for_file: camel_case_types, non_constant_identifier_names

Looks reasonable, and feel free to PR for this!

Looks reasonable, and feel free to PR for this!看起来很合理，请随意为此进行公关！

Seems easy, I'll give it a try.

Feel free to ping me if needing any hints!

Just done，but I don't know if there's anything missing.


chore: increase version

@homu r+

:pushpin: Commit e1ad987 has been approved by kbknapp

:hourglass: Testing commit e1ad987 with merge 408d2ee...

:sunny: Test successful - status


Update content from the old cookbook

In very old versions of the guides, there are cookbook articles. Which of these can we update and reused? Comment with the topic you are researching/updating.
You can see the list here: https://guides.emberjs.com/v1.12.0/cookbook/
Articles should follow the template for our cookbook: https://github.com/ember-learn/cookbook/blob/main/guides/forms/template.md

Looking at the old cook books all of the 'Contributing' section articles can be reused.
The rest I am not sure are even issues that need cook books? I think this is where going through the forum discussions and Stack overflow might be a good idea.
If we do decide to add the 'Contributing' section to this cook book shall we add it in this issue or create a separate one?

The rest I am not sure are even issues that need cook books? I think this is where going through the forum discussions and Stack overflow might be a good idea.

I tend to agree. I did a quick review of the recipes with my opinion on whether they're useful to keep.
Legend:

👍 Keep
👎 Don't keep
❓ Not sure whether to keep or not. Could be useful.

User Interface & Interaction
👎 "Adding CSS Classes to Your Components" with Glimmer components the instruction here is to use the template.
👎 "Adding CSS Classes to Your Components Based on Properties" same as the above. Also covered in the Conditional Content section of the Guides.
❓ "Focusing a Textfield after It's Been Inserted" could be a recipe as there's some confusion around render lifecycle modifiers and modifiers in general. Would need an accessibility review to make sure we're not suggesting and anti-pattern.
👎 "Displaying Formatted Dates With Moment.js" moment is no longer the date manipulation library du jour, and this should be handled by an addon/library documentation.
👎 "Specifying Data-Driven Areas of Templates That Do Not Need To Update" On top of the engine optimizations that lessen this problem, you can make use of untracked/static data for this. unbound is not something we want to recommend.
❓ "Using Modal Dialogs" there are community addons to address this. It is a thorny issue and this recipe could be updated to make use of in-element and RouteService#routeDidChange, but I'm not sure it is worth it other recommending one of the addons.
❓ "Resetting scroll on route changes" there are once again some addon solutions for this. I'm not sure we want to advocate for this solution? There's also accessibility concerns around routing and this sort of functionality.
Event Handling & Data Binding
👎 "Binding Properties of an Object to Its Own Properties" We cover getter properties in the Guides already.
Helpers & Components
👎 "Creating Reusable Social Share Buttons" I think we share the necessary knowledge in the Components section of the guide. Furthermore, I think the solution proposed might have accessibility issues.
👎 "A Spinning Button for Asynchronous Actions" I think this sort of asynchrony should be solved with ember-concurrency. At most we would point to its documentation.
👎 "Adding Google Analytics Tracking" we have addons and many ways to do this. Furthermore, I don't think we're eager to feed the GA machine :P
Working with Objects
👎 "Incrementing Or Decrementing A Property" doesn't really apply anymore, as we moved away from EmberObject APIs.
👎 "Setting Multiple Properties At Once" also does not apply for the same reason.
❓ "https://guides.emberjs.com/v1.12.0/cookbook/working_with_objects/continuous_redrawing_of_views/" is something that could still trip people up. That said, it might be as simple as pointing them to ember-concurrency and its documentation?
Doing this review raised a question for me: do we want to have recipes where we mostly recommend community addons and maybe have a small example and then link to the addon's documentation?

@locks looks great, I agree with the overview and will look into the 'could be useful' articles
@jenweber I can't assign this ticket to myself, can you assign it to me? I'll get started on the 'contributing' section


Add cache support

Pull Request Test Coverage Report for Build 358722548

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-100.0%) to 0.0%

Totals

Change from base Build 357313437:
-100.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls

Pull Request Test Coverage Report for Build 358722548
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

70 of 70 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 357313437:
0.0%

Covered Lines:
387

Relevant Lines:
387

💛  - Coveralls


consensus documentation

initial version of the consensus (in public chain eco-system).
Review by: @EanCuznaivy

:white_check_mark: Build AElf <IP_ADDRESS>6 completed (commit https://github.com/AElfProject/AElf/commit/56c1acf580 by @rosona)


Allow executing multipe DAO methods in one transaction?

I don't think so, as if the user wants to group logic in one transaction, then he will write it in a single Stored Procedure, but let keep it open for a while so If it came to my mind any other scenario then I can start work on it.

Will not support, you can code transactions in DB-Level in stored proc code


Too long to convert mp4 -> hls

Hello
I m using your library for building video streaming service but too long to converting mp4 -> hls
How to improve and make it faster ?
Please help me. Thanks

@MobileheadSherman  Facing the same issue, did you find any solution?

It depends on your hardware resources and how much resource are dedicated to the transcoding process.

I used VPS (good performance AWS EC2 Medium)


[Audio] Fix 2D audio with SubViewports.

World2D was no longer keeping track of viewports which caused AudioStreamPlayer2Ds to ignore AudioListener2Ds inside SubViewports sharing the same world.
Viewports now registers and removes themselves from World2Ds as they used to do, so AudioStreamPlayer2D can access AudioListener2Ds in any viewport which share the same world.
(this behavior was accidentally removed in #49632).
See audio2d.zip for a reproduction project (no audio without the patch).

Closing as superseded by https://github.com/godotengine/godot/pull/76713

Tested locally, it works. However, I can also hear sound when using 4.1.dev 33957aee6 in unmodified form.


Add primary source scraper for China

Location name
China
Source URL
http://2019ncov.chinacdc.cn/2019-nCoV/ has a dashboard, not sure how to scrape yet.
Notes/comments
We have regional data from JHU but would be good to replace with a primary source.

中国 🇨🇳 : http://2019ncov.chinacdc.cn/2019-nCoV/config.js
📐 GeoJSON: http://<IP_ADDRESS>/JKZX/yq_20200416.json
Data Source: National Health Commission, Provincial Health Committee
全球 🌐: http://2019ncov.chinacdc.cn/2019-nCoV/globalConfig.js
📐 GeoJSON: http://<IP_ADDRESS>/JKZX/gb_yq_20200416.json
Data Source: National Health Commission, "World Health Organization"

For such a busy interface, the data is quite compact! :mag:
I've added the short, full and translated province names which can be used for lookup. THe majority of the remaining characters for translation are things like "Confirmed Cases", "Deaths"...
var provinceNames = {
    "shortName": {
        "北京市": "北京",
        "天津市": "天津",
        "上海市": "上海",
        "重庆市": "重庆",
        "河北省": "河北",
        "河南省": "河南",
        "湖北省": "湖北",
        "湖南省": "湖南",
        "江苏省": "江苏",
        "江西省": "江西",
        "辽宁省": "辽宁",
        "吉林省": "吉林",
        "黑龙江省": "黑龙江",
        "陕西省": "陕西",
        "山西省": "山西",
        "山东省": "山东",
        "四川省": "四川",
        "青海省": "青海",
        "安徽省": "安徽",
        "海南省": "海南",
        "广东省": "广东",
        "贵州省": "贵州",
        "浙江省": "浙江",
        "福建省": "福建",
        "台湾省": "台湾",
        "甘肃省": "甘肃",
        "云南省": "云南",
        "西藏自治区": "西藏",
        "宁夏回族自治区": "宁夏",
        "广西壮族自治区": "广西",
        "新疆维吾尔自治区": "新疆",
        "内蒙古自治区": "内蒙古",
        "香港特别行政区": "香港",
        "澳门特别行政区": "澳门"
    },
    "englishName": {
        "北京": "Beijing",
        "天津": "Tianjin",
        "上海": "Shanghai",
        "重庆": "Chongqing",
        "河北": "Chongqing",
        "河南": "Henan",
        "湖北": "Hubei",
        "湖南": "Hunan",
        "江苏": "Jiangsu",
        "江西": "Jiangxi",
        "辽宁": "Liaoning",
        "吉林": "Jilin",
        "黑龙江": "Heilongjiang",
        "陕西": "Shaanxi",
        "山西": "Shanxi",
        "山东": "Shandong",
        "四川": "Sichuan",
        "青海": "Qinghai",
        "安徽": "Anhui",
        "海南": "Hainan",
        "广东": "Guangdong",
        "贵州": "Guizhou",
        "浙江": "Zhejiang",
        "福建": "Fujian",
        "台湾": "Taiwan",
        "甘肃": "Gansu",
        "云南": "Yunnan",
        "西藏": "Tibet",
        "宁夏": "Ningxia",
        "广西": "Guangxi",
        "新疆": "Xinjiang",
        "内蒙古": "Inner Mongolia",
        "香港": "Hong Kong",
        "澳门": "Macao"
    }
};

There was a double Chongqing that I resolved, but the rest LGTM.
Made a PR to scrape the whole timeseries at https://github.com/covidatlas/coronadatascraper/pull/944

There was a double Chongqing that I resolved, but the rest LGTM.

Oops...well-spotted with the Chongqing/Hebei mix-up. Sorry. :zipper_mouth_face:

Done in LI, open PR here but probably no point finishing it.


Can you explain how to do X with Deptrac? (Deptrac is starting a blog)

Deptrac is starting a blog on its official documentation site. As a part of it, I am collecting ideas for topic people would like to hear about. Feel free to add your ideas as comments in this issue. I will kick off the process by writing some that I have observed:

How to analyze dependencies on vendor packages (based on #1182)
how to handle complex architectures like DDD which require handling different "levels" of layers (different ways of slicing the classes and defining the dependency rules). Since classes cannot belong to multiple layers, the only solution I found was to use separate configuration files but it might be a better solution (From Slack)
Writing extensions (custom rules, formatters, and collectors) - example: "Is it possible to set a rule that allows referencing a foreign class but not instantiating it?"
Using custom layer attributes for custom rules (based on #837)
Dealing with domain and integration events in DDD architecture
Multiple "views" of the architecture/ creating multiple slices by using multiple Deptrac config files

How to prohibit an instantiation of a class (from Slack):

Hi folks, I want to restrict the usage of a given class: allow referencing (eg. usage in "use" statements or arguments) but not its instantiation (calling constructor). So I tried to create a custom rule but the official documentation (https://github.com/qossmic/deptrac/blob/main/docs/extending_deptrac.md) is very succinct and doesn't provide useful examples.
Do you have some additional documentation or code examples?

Explain how to create layers where token cannon reference other tokens from the same layer: https://github.com/qossmic/deptrac/issues/1278

how to handle complex architectures like DDD which require handling different "levels" of layers (different ways of slicing the classes and defining the dependency rules). Since classes cannot belong to multiple layers, the only solution I found was to use separate configuration files but it might be a better solution (From Slack)

I'm awaiting this topic. It's not straightforward how to define modules with interfaces/contracts without marking all the files with a @internal comment.

Is there a way to check location and file name of the files in a layer?
For example, I want all my DTO classes to be in a folder that matches /src/Domain/*/DataTransferObjects/ and I want the class name to have the *Data suffix. That could also be written as one regex like this: /src/Domain/*/DataTransferObjects/*Data.php. Is that possible to do? Or is this outside the scope of this package?


fix: busybox xargs unlinked on new k3s releases

What
Fixes server start for recent k3s releases.

Why
There was a change in k3s-root, included in k3s 1.30.3-k3s1, which switched to xargs from findutils.

Implications
The change should be compatible with previous versions of k3s.
Testing
K3D_HELPER_VERSION=5.7.2 make build
./bin/k3d cluster create old --image rancher/k3s:v1.30.2-k3s1
./bin/k3d cluster stop old
./bin/k3d cluster delete old
./bin/k3d cluster create new --image rancher/k3s:v1.30.3-k3s1
./bin/k3d cluster stop new
./bin/k3d cluster delete new

Fixes #1478

Perfect, thanks for the fix @thejan2009 ! :pray:


fix issue

ref: https://github.com/alibaba/spring-cloud-alibaba/issues/1288
spring-cloud-alibaba-sidecar-nacos-example
missed:

org.springframework.boot
spring-boot-starter-web

com.alibaba.cloud
spring-cloud-starter-alibaba-nacos-discovery

io.projectreactor
reactor-core

spring-cloud-alibaba-sidecar-consul-example
missed:

org.springframework.boot
spring-boot-starter-web

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Is it possible to load shaders from text file?

Just like script files.
For example, I have working shader:
https://i.imgur.com/b06eEy5.png
But, I have to put this shader directly to node.
But what if I want three nodes that use same shader? I can CTRL+C, CTRL+V shader to each of them. But what if I decided to change shader? I have to edit code on all those three nodes that uses that shader?
Can I just put code to separate file (lets say someshader.shader) and specify file like this:
https://i.imgur.com/i2eMcHK.png
Or there is specific workflow?

they are designed for this now, but as far as I know the loader was never
done. It should be rather easy, just keep this open as issue reminder
On Fri, Dec 8, 2017 at 7:14 PM, Dmitry Koteroff<EMAIL_ADDRESS>wrote:

Just like script files.
For example, I have working shader:
https://i.imgur.com/b06eEy5.png
But, I have to put this shader directory to node.
But what if I want three nodes that use same shader? I can CTRL+C, CTRL+V
shader to each of them. But what if I decided to change shader? I have to
edit code on all those three nodes that uses that shader?
Can I just put code to separate file (lets say someshader.shader) and
specify file like this:
https://i.imgur.com/i2eMcHK.png
Or there is specific workflow?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/14431, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z22f5BaQM2LiIM7z5cUeraycqvauiks5s-bTEgaJpZM4Q7twm
.

@reduz Please find some time to finish loader before 3.0 final :)

@reduz Small suggestion: would be nice if public shader parameters that accessible from editor will be independent for all nodes that uses that shader (so I assume one shader will be just compiled N times with different input params and saved as like shadername1.shd, shadername2.shd, ...).
Simple use case: I have outline shader, it has outline width as public shader param, and I have few objects that will use this outline shader, but for all of them an outline width should be different which will be set just via Inspector.

you can use different materials with different parameters but the same shader, and the shader will not be recompiled. It's not a problem if the outline parameter changes on each material.

@reduz
https://i.imgur.com/MCcz9RI.gifv
What I do wrong? :-
Have two different materials, both use same shader. But change params on node2 lead to change also and for node1 (though, changing on node1 doesn't make any effect at all, seems like a possible issue may be)

@Krakean you need to make the ShaderMaterial resource unique, they will share the shader. there is an option in the tools button 'make unique'

@Krakean if you meant the ability to re-use a shader without copy/paste, you can save it as a .tres resource (which is editable but doesn't only contains shader code though).

@djrm
@Zylann
Thanks guys, "unique" solved a problem with this one!


Completing and Improving Abouts page.

i can contribute to these improvements:

I will fully improve UI of about page
make it evenly themed like slugterra main website
Give links to your other website in it.
add footer too

i can contribute to these improvements:

I will fully improve UI of about page
make it evenly themed like slugterra main website
Give links to your other website in it.
add footer too

hey @vikhyatsingh123 can i work on this issue if @Harsh2504 is not working? i asked permission from him to take his issue, now only if @vikhyatsingh123 you agree, ill be happy to work on this issue.

@Harsh2504 are you working on this issue? if yes, when will you create pr? any expected time

@Harsh2504 are you working on this issue? if yes, when will you create pr? any expected time

No . I’m working on your other projects right now . Let him work on this issue 👍

@Harsh2504 are you working on this issue? if yes, when will you create pr? any expected time

No . I’m working on your other projects right now . Let him work on this issue 👍

UwU harsh-kun, arigatto Oni-chan✨

@Sami3160 you can work on this


timetracking: account for leagues farmtick being 1 minute rather than 5

This should fix #18579

Marking this as a draft as I'm not able to test this myself and wouldn't mind a second set of eyes on it.


New package: Samsung.SWUpdate version <IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111898&drop=dogfoodAlpha

[Policy] Needs-Author-Feedback

Close with reason: Stale pull request;


BACK ON TRACK 2.0 (FOR NONG)

Song Name
BACK ON TRACK 2.0
Artist Name
DJVI
Source
Youtube
Youtube Link
S2MNGxvq3Us
Direct File Link
No response
Song ID
69420
Start Offset [ms]
0
Extra
Created from Auto Nong.
Not created for a level.
Downloaded: NUH UH

accept


Git does not detect changes

Version
Microsoft Windows [Version 10.0.22000.795]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ubuntu 20.04
Other Software
git version 2.25.1
Repro Steps
cd /tmp
mkdir test-repo
cd test-repo
git init
echo "a" >> README.md
git add .
git commit -m "initialize repo"
echo "a" >> README.md
git status

Expected Behavior
git should detect the change done in README.md
Actual Behavior
Git does not detect the change. the git status command gives the following output:
On branch master
nothing to commit, working tree clean

To make git see the change I have to manually update index:
git update-index --no-assume-unchanged README.md

Diagnostic Logs
No response

I have overcome the issue by installing Ubuntu 22.04 LTS, where I can't reproduce it. However, i have left my 20.04 instance unchanged where the issue still exists in case you need more information.

Does this happen outside of /tmp?

Yes, I originally had this issue in my home directory and can still reproduce it there.

Interesting. I can't reproduce this using <IP_ADDRESS> on Debian, Ubuntu 20.04, Ubuntu 18.04, or Void, using git versions 2.36.1, 2.25.1, 2.17.1, and 2.37.1, respectively.

I expected this answer... Can I do anything to help you reproducing or to exclude WSL as a factor?

Not sure. Can you confirm you do not have any git configurations anywhere? E.g. ~/.gitconfig, etc.? I can't recall all the potential locations for configs (if there are more at all), but man git-config I believe should be enlightening.

You got me. It seems to be the core.fsmonitor option which was set to true. Disabling it solves the issue for me.

THANK YOU!!!!!!
For weeks I've been running into git randomly stopping tracking changes (but new files did show up as a change). I finally googled the right thing to get me here and core.fsmonitor seems to have done the trick for me as well.

After months of this not being an issue, the issue began again within the last week. I double checked the core.fsmonitor is still false, so seems like theres a new issue causing this.


Add Code of Conduct

Hey 🥳! I see that repository is missing code of conduct. I would like to add a code of conduct developed from scratch for your project. Please let me know if it is okay to proceed. Please assign to me and add GSSoC24 Ext & level1 Labels.

@KiranBaliga  I am mentor of this repo try to raise issues , after get response from the PA , I will assign it

@KiranBaliga Already done raise issue by reading the Readme file to setup locally

Closing


Diagnostics test.

Closed by GitHub build #52

see the readme issues report

Closed by GitHub build #53

see the readme issues report

Closed by GitHub build #55

see the readme issues report

Closed by GitHub build #56

see the code style issues report

Closed by GitHub build #57

see the documentation issues report

Closed by GitHub build #58

see the unit test issues report

Closed by GitHub build #59

see the coverage verification issues report


Support Flux<...> as QueryHandler return type

When using Spring Data with reactive repositories, the methods return types are Mono<...> or Flux<...>. The QueryGateway doesn't seem to support these types as QueryHandlers return types.
I'm mostly interested in using the subscriptionQuery method with a Flux as the initial response type.

Thanks for your feature request @raphael-jungers.
I've marked this ticket as under discussion for now.
Any suggestions from the team's side will be shared in this thread, so stay tuned. :-)

I finally managed to use spring-data-cassandra-reactive with cassandra as the query database without any change to the framework.
Here's a code example for those interested :
The Controller :
    fun getTransactions(payload: Mono<String>): Flux<Payload> {
        return payload.map {
            ObjectMapper().readValue(it, SearchTransactionsQuery::class.java)
        }.map { query ->
            val result = queryGateway.subscriptionQuery(query, ResponseTypes.multipleInstancesOf(Transaction::class.java), ResponseTypes.instanceOf(Transaction::class.java))
            Flux.concat(result.initialResult(), result.updates())
                    .map {
                        DefaultPayload.create(ObjectMapper().writeValueAsString(it))
                    }
        }.flatMapMany { flux -> flux }
    }

The QueryHandler :
    @QueryHandler
    fun handle(query: SearchTransactionsQuery): Iterable<Transaction> {
        return transactionRepository.findAll().toIterable()
    }

The EventHandler (emitting updates)
@EventHandler
    fun on(event: TransactionExecutedEvent) {

        val transaction = Transaction(event.id, event.exampleData)

        transactionRepository.save(transaction).doOnNext { t ->
            queryUpdateEmitter.emit(SearchTransactionsQuery::class.java,
                    { query -> true },
                    t)
        }.subscribe()
    }

Great you got that working! :)
Iterable is indeed one of the types the ResponseType class, specifically the MultipleInstancesResponseType implementation, can cope with.
FYI: the multiple instance of ResponseType should also be able to cope with Streams and arrays, either of those three with or without generics and wildcards.

+1, and maybe kotlin coroutine should also be supported

@UkonnRa please maintain Kotlin specific requests to the Kotlin Extension Repository. We know you've dropped an issue request there, but simply reiterating the fact here does not increase prioritization on the matter. We first need to figure out an implementation tactic for the matter (hence the "Under Discussion" tag) prior to initiation work on it.
Of course, implementation suggestion or a pull request are very much valued from any users of Axon. Thus if you are up for the task, I'd be looking forward to reviewing your PR!

Just stumbled upon this use case and ended up doing what looks like a dirty workaround:
Flux<Foo> orderedProducts = Mono.fromFuture(queryGateway.query(new FindFoos(), ResponseTypes.multipleInstancesOf(Foo.class)))
                                      .flatMapMany(Flux::fromIterable);

I think we've missed adding this issue to milestone 4.6.0, when we started our efforts on the Streaming Query support we introduced in #2001.
With that in place you can use QueryGateway#streamingQuery(Q query,  Class<R> responseType) to retrieve a Publisher as a response.
Furthermore, it allows your query handlers to be written in this format:
@QueryHandler
public Flux<Order> handle(FindAllOrdersQuery query) {
    return Flux.of(...
}

Given the nature of this issue, we feel the aforementioned support is thus present as of 4.6.0 of Axon Framework.
Please give it a try and let us know what you think!

Please also note that using the reactor extension, we do offer a subscription query with a flux return type.


SGE Security

Right it looks like the default and only option is to make all compute nodes submit hosts and administrative hosts.
Ideally there would be some way to lock down privileges on the computer nodes, for example to prevent malicious programs that have been submitted from gaining admin access to the entire cluster.
docs are provided here: http://arc.liv.ac.uk/SGE/howto/sge-security.html for securing a cluster and I would suggest at least linking to them if not also making of these settings default

Because we have announced that we will be deprecating support for SGE in the near-future (see: https://github.com/aws/aws-parallelcluster/wiki/Deprecation-of-SGE-and-Torque-in-ParallelCluster), we will not be performing additional enhancements specific to SGE.
I am going to close this issue. If you would like to request a similar enhancement for one of our other supported schedulers (Slurm or AWS Batch), please feel free to create a new issue.


Update CSS token per new design system theming capability

Alaska Airlines Pull Request
Fixes: #269
Summary:

Update the design tokens to reflect the new theming conventions regarding tokens from the AuroDesignTokens and JetstreamDesignTokens repo.

Type of change:
Please delete options that are not relevant.

[x] Revision of an existing capability

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.15.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove unused CHIP_IM_MAX_NUM_COMMAND_SENDER define.

Problem
Define is unused.
Change overview
Remove it.
Testing
Tree compiles.

fast track: trivial change by a domain owner.


Right Trigger not working.

Hi,
I'm using DS4Windows and on Profile the controller is 100% functional even Right Trigger, but when I test it over Windows as XBOX controller the Right Trigger Axis is missing, how can I fix that?
edit: somehow its working now?!!

Did you ever figure out what the problem was? I am having the same issue as well.


Add ci-cd Pipeline

add a complete ci-cd workflow for SharedKernel with: build, test, automatic versioning, upload artifacts, publish GH release and publish .nupkg packages to NuGet.

Also I would suggest to rename the pipeline to ci-cd-sharedkernel to keep the owner's naming scheme.

Forgot to mention, add the option for manual execution of the pipeline.


Strip the header

Our wave file is two section, the first section is the wave header (44 bytes) and second section is the original file data. And the decoding process taking long than encoding (x2 benchmarks). I think is better to strip it and rewrite the data to the output file. @Amjad50 what do you think?
My prototype of strip way with 2.7 GB

Executed in    4.79 secs    fish           external
usr time    3.17 secs  550.00 micros    3.17 secs
sys time    1.54 secs  353.00 micros    1.54 secs

Current way with 2.7 GB

Executed in   12.62 secs    fish           external
usr time   11.04 secs  472.00 micros   11.04 secs
sys time    1.54 secs  279.00 micros    1.54 secs

Nice performance boost


Try to make CI automatically add new tag commit

:tada: This PR is included in version 0.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Adding member/Owner to a Teamsprivate channel[FEATURE]

Is your feature request related to a problem? Please describe.
The request is to be able to add a member/Owner to Private Channel in teams.
Describe the solution you'd like
Add-PnPTeamsUser -Team MyTeam -User<EMAIL_ADDRESS>-Role Owner -Channel "MyChannel"
Describe alternatives you've considered
Something similar to Add-TeamChannelUser in TeamsPoswershell
Add-TeamChannelUser -GroupId 31f1ff6c-d48c-4f8a-b2e1-abca7fd399df -DisplayName "Engineering" -User<EMAIL_ADDRESS>Add user<EMAIL_ADDRESS>to private channel with name "Engineering" under the given group.
Additional context
As a global or Teams admin in my organization, i require the ability to change Owners and Members of private channel of a team:

I need this too. Any ideas?

Every contribution is welcomed @milanholemans. Just submit a PR and @KoenZomers or @gautamdsheth will review it. Thanks!


Solve: Iss 7 & 8

Solved issues mentioned in #7 & #8.

Before proceeding, try and add Spanish language support (mentioned in #10).


General review

Tasks:

Perform general code review.
Write down improvement suggestions in comment.

First of all, good work! I will give you some advices or feedback about the repository

Fix a "typo" in the readme file, says expressed and should say express. The docker-compose.yaml file is written in a gist, I think it would be better that it exist in the repository, what do you think about it?
A good security practice is to use helmet
Add postman with the existing endpoints and headers, will be helpful as documentation
I think the use of arrow functions make the code structure more compact and keep the lexical context of the root function. Maybe we can update some parts of the code.
This is not a MUST, Update the folder name model to models. Another suggestion is to rename the folder util to helpers or utils.

For the future:

Separate Express app and server. Avoid defining the entire Express app in a single file, separate your Express definition . For even better structure, locate your API declaration within components.
Small example:

...
const app = require('./config/express')
const mongoose = require('./config/mongoose')
...

To prevent an API from being overwhelmed, just in case of too many requests, we can add some kind of rate limit.

:+1:  @mariano-aguero . Will create issues and group the tasks accordingly later.
Closing this task-issue you have assigned so you don't have anything in progress here.
Thank you!


Extract single file from RPM

Is there a way to extract a single named file from the RPM?
Thanks for the help!

CPIO is a streaming file format, you can't jump to a particular file, however you can use PayloadReaderExtended() to get a PayloadReader which works the same way as the tar archive reader. Call Next() until you get to the file that you are interested in and then use Read() to extract the file.


[Event Request] Table 5741 "Transfer Line" - OnValidateTransferFromCodeOnBeforeCheckItemAvailable

We are migrating our code from NAV 2018 to BC16.4. In the Table 5741 "Transfer Line", in the field 36 "Transfer-from Code", in trigger OnValidate, we would like to add our own code at a specific moment. To do so, we need an event publisher, like this :

With this integration event :

Do you think it could be possible ?
Thank you for your work.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Coding version1

This is the first version of the game. The map is loaded, the player can run around, enemies are spawned and do damage. Dying is not possible yet, neither is doing damage.

Your documentations explain every step very well!
My only comment is that they are all structured a little differently, so an improvement would be to have each documentation be written in the same style and structure. Otherwise great job!!

What exactly do you mean with "the documentations are all structured a little differently?" Do you have an example :)


Improve string literals

String literals currently cannot contain any escape characters. They should probably be able to contain at least \\ \" \n \t \r and \u{XXXX}.

Full list from ES6 grammar:
' " \ b f n r t v
there's also \xHH and \uHHHH, but I think it might be better to not include thoses since the \u{HHHHHHHHH} form is easier and more powerful. I think the language would be better off without these for now, so I'll only add them later if there's demand.


Moto (DynamoDB) doesn't match that of AWS

Moto 5.0.1
boto3 1.34.37
Reproduce:
Basic Usage, Dynamo Create table
   @mock_aws
    def test_dynamo(self):
        """Must satisfy all of the required fields
                TableName,AttributeDefinitions,KeySchema,ProvisionedThroughput,Tags,StreamSpecification,BillingMode,GlobalSecondaryIndexes,LocalSecondaryIndexes
        """
        timestamp = dt.now()
        epoch = int(time.time())
        TableName = "my_test_" + str(epoch)

        LocalSecondaryIndexes = [
            {
            "IndexName" : "local_index"
            },
            {
            "KeySchema": [ {
            "AttributeName": "Creator",
            "KeyType": "RANGE"
                    }
                ]
            },
            {
                "Projection":"ALL"
            },
            {
                "ProvisionedThroughput" : {
                    'ReadCapacityUnits': 5,
                    'WriteCapacityUnits': 5,
                }
            }
        ]

        GlobalSecondaryIndexes = [
            {
            "IndexName" : "global_index"
            },
            {
            "KeySchema": [ {
            "AttributeName": "ComicBook",
            "KeyType": "RANGE"
                    }
                ]
            },
            {
                "Projection":"ALL"
            },
            {
                "ProvisionedThroughput" : {
                    'ReadCapacityUnits': 5,
                    'WriteCapacityUnits': 5,
                }
            }
        ]

        BillingMode = "PAY_PER_REQUEST"

        StreamSpecification = {"StreamEnabled": False}

        Tags = [
            {"Creator": "cmiracle"},
            {"Created_Epoch": timestamp},
            {"Environment": "Development"}
        ]
        AttributeDefinitions=[
        {
            'AttributeName': 'UUID',
            'AttributeType': 'S',
        },
        {
            'AttributeName': 'ComicBook',
            'AttributeType': 'S',
        },
        # {
        #     'AttributeName': 'Creator',
        #     'AttributeType': 'S',
        # },
        # {
        #     'AttributeName': 'Year',
        #     'AttributeType': 'N',
        # }
        ]

        KeySchema = [
            {
                'AttributeName': 'UUID',
                'KeyType': 'HASH'
            },
            {
                'AttributeName': 'ComicBook',
                'KeyType': 'RANGE'
            }
            # },
            # {
            #     'AttributeName': 'Creator',
            #     'KeyType': 'RANGE'
            # },
            # {
            #     'AttributeName': 'Year',
            #     'KeyType': 'RANGE'
            # }
        ]

        ProvisionedThroughput={
            'ReadCapacityUnits': 5,
            'WriteCapacityUnits': 5,
        }

        try:
            # We're passing back the result of the actual table Creation function which contains the AWS return values
            # From here, we can parse the return to make sure expected values are as such
            test_result = ds.dynamo_createtable(TableName,AttributeDefinitions,KeySchema,ProvisionedThroughput,Tags,StreamSpecification,BillingMode,GlobalSecondaryIndexes,LocalSecondaryIndexes)
            # print(test_result['TableDescription'])
        except Exception as e:
            raise(f"An error executing Create Table: {e}")

With this, it runs, and returns a Response.  But the Local and Global Secondary Indexes are empty.  BillingMode is wrong.
If you uncomment out the Attribute Names in Key Schema and run it again, Moto doesn't throw an error.  If you run this without @mock_aws, AWS will throw an error because you can't have more Attributes than keys.
Should I downgrade Boto or Moto?  We're looking to use Moto to fully test our AWS code before running them in AWS itself.

Hi @chadmiracle, are you able to create a stand-alone reproducible testcase? The ds.dynamo_createtable presumably does some parsing/mangling of the arguments, because passing them to boto3 directly results in a whole lot of validation errors.

I run exactly what I posted directly against AWS using Boto3; there are no validation errors.

What does the dynamo_createtable-method do, that you're using in your example? As that is not a boto3-method as far as I know.

It's in different libraries, so that ends up calling
`
def dynamo_createtable(self,TableName,AttributeDefinitions,KeySchema,ProvisionedThroughput,Tags,StreamSpecification,BillingMode,GlobalSecondaryIndexes,LocalSecondaryIndexes   ):
print("Initiating Creation of Dynamo Table")
dclient = self.session.client('dynamodb')
    response = dclient.create_table(TableName=TableName,AttributeDefinitions=AttributeDefinitions,KeySchema=KeySchema,ProvisionedThroughput=ProvisionedThroughput)

`

The dynamo_createtable never uses the the Indexes or BillingMode:
response = dclient.create_table(
    TableName=TableName,
    AttributeDefinitions=AttributeDefinitions,
    KeySchema=KeySchema,
    ProvisionedThroughput=ProvisionedThroughput
)

So I'm not surprised that these attributes are also missing from the response.

Fair enough but Moto still fails to validate the AttributeDefinitions and KeySchema.  If I uncomment out those items in the KeySchema, I should get an error from Moto and I do not.

There are at least four scenarios here, as far as I can see:

An attribute is defined by KeySchema, but not in AttributeDefinitions --> coveredy by Moto
An attribute is defined in AttributeDefinitions, but not in KeySchema -->  covered by Moto
An attribute is present in both, but mistyped --> covered by Moto

The test case above is a fourth scenario:

There are too many elements in the KeySchema. Whether or not the additional element is covered by AttributeDefinitions is irrelevant, as AWS will always complain about the KeySchema-length first.

I've raised a PR to cover this error case, so Moto will throw the correct exception after that's merged.


Date formats

Bug description
Grabber currently uses multiple formats for dates, neither of which respects by LC_TIME locale setting.
The following screenshot shows the date as seen in the favorites edit dialog on the left and in the "more details" popup of an image on the right.

I would like to see the RFC-3339 (or ISO-8601) format, as is used in the en_DK locale:
/tmp λ date +%x
2020-05-21

/tmp Ξ echo $LC_TIME
en_DK.UTF-8

System information

OS: Arch Linux
Grabber version: 7.2.1

Indeed, the date formats are a little bit inconsistent.
This is due to multiple reasons, so I'll push a few fixes for that.
In your screenshots however, you're showing the "Last view" field of what I believe if a favorite's window. Date and time editors use Qt's default format, which is similar to the ISO one ("2017/06/17 18:32:09"), and I'm not sure it's useful to change it.
All other places where dates are displayed, however, should use the locale's setting (such as your right's screenshot).

Can't Qt's control be configured?

They can. What I was saying is that it might not be necessary/useful to follow an user's locale for a date editor, when the default format is ISO.
For display, it will use the user's settings as long as you choose the correct language in Grabber's options.

Unfortunately, language does not directly correlate to the preferred date format. Choosing English, which is a natual choice for anyone able to understand that language, causes DD/MM/YYYY HH.mm to be used, which is workable, if you remember that, but will always have me second guessing whether it might be MM/DD/YYYY, because that is just as likely. I'm okay with the Qt control because I don't think YYYY/DD/MM is a thing.

Not sure what you mean. If your system is in english and you choose the english language, it'll use your system's locale to display dates. XX/XX/YYYY will always be ambiguous but the only other option is to use ISO but that's not user-friendly.

Is there no way to have Qt respect my LC_TIME setting?

AFAIK Qt already uses LC_TIME:
https://github.com/openwebos/qt/blob/master/src/corelib/tools/qlocale_unix.cpp
Are you using the latest version from the develop branch?
Maybe your Qt version is too old? The en_DK locale you mention seem to be absent on earlier versions (apparently you'd need Qt 5.7):
https://bugreports.qt.io/browse/QTBUG-35692?focusedCommentId=327974&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel

Are you using the latest version from the develop branch?

Yes, I built fresh from the develop branch.

Maybe your Qt version is too old? The en_DK locale you mention seem to be absent on earlier versions (apparently you'd need Qt 5.7):

"About Qt" shows 5.14.2.

See also my locale output, if that helps:
~/tmp/pkg ∀ locale
LANG=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME=en_DK.UTF-8
LC_COLLATE="en_US.UTF-8"
LC_MONETARY=de_DE.UTF-8
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT=de_DE.UTF-8
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=

Actually, I don't see why would the en_DK use the yyyy-MM-dd format.
In the CLDR, there are no overrides for the date format itself:
https://github.com/unicode-org/cldr/blob/master/common/main/en_DK.xml
As such, it will fallback to the en format:
https://github.com/unicode-org/cldr/blob/master/common/main/en.xml
See here for pattern format:
http://cldr.unicode.org/translation/date-time-1/date-time
It would seem that the date tool on its end uses some different en_DK locale, which is not the same as the one used by Qt, which is based on the CLDR.
From what I can guess, it must be based on glibc whose locales are terribly out-of-date:
https://github.com/lattera/glibc/blob/master/localedata/locales/en_DK

Actually, you'll find more answers about this if you google the same issue for KDE, as they are also using Qt for everything, and as such also use the CLDR. People seem to suggest the en_SE locale, which is ISO-compliant.
However, it doesn't seem to exist in glibc, so I don't really know how that would work. Maybe just start Grabber with something like:
LC_TIME="en_SE.UTF-8" ./Grabber

Oh, Qt is using CLDR? Then I understand why that is a problem because I've recently had that issue with Thunderbird as well. Apparently, no locale setting for ISO date (or RFC3339, as that allows a space instead of T to separate date and time) exists for that. I've started using lt_LT for Thunderbird, which works well as long as no long format (with words) is being used. I've spent an unreasonable amount of time in trying to find the best workaround and ended up with that.
I can confirm that launching with env LC_TIME=lt_LT.UTF-8 Grabber works. I'll patch/override my local Grabber.desktop, then.


Contoso.Events Application in ASP.NET Core

We should take the demo application and do a full implementation in ASP.NET Core.

This shouldn't take too long to implement. Once it's ready, I am looking for a MCT volunteer who wants to review the ASP.NET Core prototype. You can see if the application will work for your Linux/OSX students.

I am willing to test on linux if you still need to find someone to do that.

Cancelled


Raw image size is much bigger than the original size when toBase64() is used

Hi,
I'm trying to save the image which has some filters applied on. So I use "toBase64" method to get the raw data to send via Ajax. But the raw image size is 4-5 times larger than the original size. So if my image is 500 KBs, the raw data that I'm trying to save is 2,5 - 3 MBs. Am I doing something wrong or is there a way to reduce this size?
Thanks.

try canvas.toDataURL("image/jpeg",0.9) instead of just toDataURL()


add method apply_baseline to Epochs and Evoked

follows up #2337 and addresses second half of #2315.

closing for #2337

wrong issue to close

closed for #2337


Update workflow.ga

taking from link updated by Mo to https://github.com/galaxyproject/training-material/commit/f6b3f22a12dcd96ac62f1f84e9347182ec9fa75a

@daltis20012009 can you please give this file a proper name and maybe a nice short description of what it is doing, like here: https://github.com/galaxyproject/training-material/tree/master/Proteomics/workflows/ntails

Hi @bgruening  I was just populate the workflow file for docker container as @MoHeydarian is working on the description of worfklow. My understating after discussion with @bebatut  is that this file should have name workflow.ga  but I might get it wrong.


Add shebang support (MacOS)

Ignore the first line of the file if it starts with a "#!".

Fixed in fc039d1.


[Connection] Reconnection

try to do things like connecting hubs without a timeout etc -- should all be handled but something seems to go fishy still

do you have an example?

fixed!


login invalid captcha provider:

Continuously entering the wrong account and password for multiple times, unable to load the verification code correctly

@keac how to reproduce it in settings?

@keac you need to use latest version Casdoor. I tried and it works:


RMS calculation when resampling mf_repeatability

What is your issue?
When get_obs_surface is called with an averaging period specified, mf_repeatability is calculated as follows:
ds_resampled[var] = (
    np.sqrt((data[var] ** 2).resample(time=average).sum())
    / data[var].resample(time=average).count()
)

This doesn't seem right to me - if your averaging period contains two identical values of mf_repeatability=a, the resampled mf_repeatabilty=a/sqrt(2). I guess the intention in the code above is to take the rms value, in which case the denominator should be within the sqrt().

I've been thinking again about this issue this morning - I guess what is being calculated here is actually the std error on the mean, in which case the current code is correct. In some cases this leads to pretty small errors being assigned, but this is fine as long as the measurement error is dominated by white noise rather than drift. I guess that will be instrument-dependent, but perhaps overall it is better to leave this as it is.

From @brendan-m-murphy ...
"I think the repeatability calculation is the standard deviation of an average of independent random quantities. So assuming the measurements being averaged are independent and the repeatabilities are the standard deviations of each measurement. This gives an extra square root of the number of measurements in the denominator"

That makes sense to me. In reality successive measurements are not really independent random quantities, but we don't really know the correlation between these errors, so I don't see an obvious alternative to the current calculation. I'm going to close this issue before I forget about it, but feel free to reopen if anyone has further thoughts on it.


How to import or include the markdownlint module ?

I am just simply trying to use the demo code, in a simple node js app.
So, I have a pad.ejs, which is like a notepad where you can post markdown raw code and it follows the same idea as the demo here.
I have the scripts included in my ejs file.
<script src="https://cdnjs.cloudflare.com/ajax/libs/markdown-it/8.4.1/markdown-it.min.js"></script>
<script src="http://requirejs.org/docs/release/2.2.0/minified/require.js"></script>
<script src="markdownlint-browser.js"></script>
<script src="markdownlint-browser.min.js"></script>
<script src="default.js"></script>

And the default.js is same as default.js from demo. I have not modified anything and yet , the console throws this error
Uncaught TypeError: Cannot read property 'sync' of undefined
    at onMarkdownInput (default.js:53)
    at main (default.js:170)
    at default.js:171
onMarkdownInput @ default.js:53
main @ default.js:170
(anonymous) @ default.js:171

So, this just seems like the module is not getting loaded somehow from the script.
This is the package structure that I have

I have not done a lot of nodejs development, it could be just something really silly or small that I am not doing right, can someone please help.
Thanks

You need to include markdown-it and you don’t need two copies of markdownlint. Have a look at https://github.com/DavidAnson/markdownlint/blob/master/demo/default.htm and the containing directory for a working example.

Thanks, that solved my problem.
We can close this.

Yay!


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit 936ea25:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: RepositoryUnauthorizedWithSourceCommit] Git data access to 'https://github.com/opstest2/docs-archive-test-target' (branch: Release_Archive_main_2022-02-18-11-53-40) is not authorized.. It looks like this might be the first time user: v-alji submitted a pull request to this repo. Before user can run builds in a pull request, he/she can enable 'v-alji' GitHub account in Docs by visiting Docs Portal (https://ops.microsoft.com). After enabling his/her account (v-alji), close and then reopen this pull request to start another build.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[Bug]: Playground Examples CI / check (java) / pre-check (pull_request)

What happened?
The Playground Examples CI / check (java) / pre-check (pull_request) fails when changing the names of files.
For example, https://github.com/apache/beam/actions/runs/3797038264/jobs/6457649054 shows the error message:
FileNotFoundError: [Errno 2] No such file or directory: '../../sdks/java/io/fileschematransform/src/main/java/org/apache/beam/sdk/io/fileschematransform/FileWriteSchemaTransformFormatProviders.java'

In the context of the PR check, the directory fileschematransform was changed to file-schema-transform.
Issue Priority
Priority: 3 (minor)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[X] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

Thank you @damondouglas ! Working on it.


Enable print-defmt feature for panic prob in examples

The examples Cargo.toml could have panic-probe enabled with the print-defmt feature:
panic-probe = {version = "0.1.0", features = ["print-defmt"]}

The issue with print-defmt is that it wastes flash space because the panic message strings are not replaced with IDs like normal defmt prints, they're stored entirely in the flash. It also pulls in core::fmt to format the panic message, which is a bit heavy.
Instead, both the examples and the nrf-softdevice lib use a depanic! macro that prints with defmt and then panics. Together with utilities like dewrap, dexpect, deassert!. This way we get panic messages without the flash space hit.

I see, this makes sense.


fixes https://github.com/astanin/py-markdown-ditaa/issues/1

Handy extension! I've added a setup.py to make a buildable extension.


Simplify RWSet

Just adding Carlos explanation on Slack here, to explain why we changed the behavior of reset:

The current implementation allows the reset to affect operations that are concurrent to it. I think the resets on riak datatypes used on maps and all the resets we did in delta state CRDTs follow the following convention.
Reset is observed reset, so one only affect the operations that have been seen locally.
I am not saying that the other reset flavor is not useful. But for sanity I would propose to follow this principle for all datatypes and then maybe have som variants of justified by specific needs.


Components not getting attributes  problem with this.attrs

Hello,
My component attributes was ignored in new versions of ember-flatpicker (v2)
If i log ths this.attrs value in setupComponent show: {value: undefined, onChange: ƒ}
I think may be related to this: https://locks.svbtle.com/to-attrs-or-not-to-attrs
DEBUG: -------------------------------
Ember              : 2.6.2
Ember Data         : 2.17.0
jQuery             : 2.2.4
Ember Bootstrap    : 1.0.0-rc.4
Ember Models Table : 2.2.3
Ember Simple Auth  : 1.4.0
DEBUG: -------------------------------

@albertosouza we don't use value anymore. Please see the changelog. https://github.com/shipshapecode/ember-flatpickr/blob/master/CHANGELOG.md#200

@rwwagner90 i found the problem ...
I have many forms with datetime picker and for economize code i build one component extending the ember-flatpickr:
import Ember from 'ember';
import EmberFlatpickr from 'ember-flatpickr/components/ember-flatpickr';

export default EmberFlatpickr.extend({
  session: Ember.inject.service('session'),
  altFormat: 'j/n/Y H:i',
  enableSeconds: false,
  enableTime: true,
  allowInput: false,
  altInput: true,
  clickOpens: true,
  altInputClass: 'form-control',
  locale: 'pt',
  mode: 'single',
  nextArrow: '>',
  parseDate: false,
  placeholder: '',
  prevArrow: '<',
  static: false,
  dateFormat: 'Z',
  timeFormat: 'H:i',
  utc: false,
  wrap: false
});

This component above only works with old version of ember-flatpickr
I changed my component to change the this.attrs before ember-flatpickr init and now is working.
Working version:
import Ember from 'ember';
import EmberFlatpickr from 'ember-flatpickr/components/ember-flatpickr';

export default EmberFlatpickr.extend({
  init: function() {
    const defaults = {
      altFormat: 'j/n/Y H:i',
      enableSeconds: false,
      enableTime: true,
      allowInput: false,
      altInput: true,
      clickOpens: true,
      altInputClass: 'form-control',
      locale: 'pt',
      mode: 'single',
      nextArrow: '>',
      parseDate: false,
      placeholder: '',
      prevArrow: '<',
      static: false,
      // dateFormat: 'Z',
      // timeFormat: 'H:i',
      utc: false,
      wrap: false
    };

    Ember.setProperties(this.attrs, defaults);
    Ember.setProperties(this, defaults);

    this._super(...arguments);
  }
});

Thank you for your attention.

@albertosouza instead of directly extending the component, you could use a wrapper component, and everything should work fine, I think.

@rwwagner90 yes, wrapper component shold work too but now my extension is working ...
thanks


Add relative linking to menu item template and remove base url from header template

This PR fixes a relative URL issue that causes the following behavior:

When deploying to a test location, the base URL of the test location is overwritten by the baseURL that is loaded into the <base> tag. This is solved by removing the line of HTML that generates that tag in the header.html template.
When deploying in any environment, footnotes do not work. The generated footnote links are relative and so are appended to the base URL and the user is redirected to e.g. https://mybaseurl.com/#fn:1. Removing the base URL fixes this issue as well.
When deploying to a test location, after clicking a menu item on the main page you are brought to a list of posts. Clicking on a post redirects the user to e.g. https://www.mybaseurl.com/menuitem/post instead of test-location/menuitem/post. This is fixed by changing the line in li.html to have .RelPermalink instead of .Permalink.

Thanks!


[Android] Keypad is open for exchange fee tutorial screen  when user open “Exchange Fee” tutorial from “Exchange” screen.

App version: zero-sync build: Staging build v1.5.0 (101548577)
Repro on: Sony Xperia C4 (5.0), Samsung J7 Prime (6.0.1), Samsung Galaxy A9 Pro (8.0)
Testing Account:<PHONE_NUMBER>/Backup Kay
Repro Steps:

Launch the app.
Tap on the Gold tab.
Tap on any gold activity.
Tap on “!” beside Exchange free text.
Observe
Investigation: Issue does not reproduce when user taps on “!” beside Exchange fee from the “Review Exchange” screen
Current Behavior: Keypad is open for exchange tutorial screen
Expected Behavior: Keypad should not open for any tutorial screen.
Attachment: Android_ExchangeTutorialIssue.mp4 (Bug observe at 03 sec)

Fixed in new exchange trade screen https://github.com/celo-org/celo-monorepo/pull/2167


Remove method.async of provider url.

Remove method.async of provider url to avoid that consumer use async value from provider.
Fix issue:
https://github.com/apache/incubator-dubbo/issues/2321
Related pr:
https://github.com/apache/incubator-dubbo/pull/2322

Codecov Report

Merging #2434 into master will decrease coverage by 0.04%.
The diff coverage is 37.5%.

@@             Coverage Diff              @@
##             master    #2434      +/-   ##
============================================
- Coverage     55.06%   55.02%   -0.05%
+ Complexity     5269     5267       -2
============================================
  Files           573      573
  Lines         25445    25453       +8
  Branches       4518     4521       +3
============================================
- Hits          14012    14006       -6
- Misses         9340     9348       +8
- Partials       2093     2099       +6

Impacted Files
Coverage Δ
Complexity Δ

...apache/dubbo/rpc/cluster/support/ClusterUtils.java
63.15% <37.5%> (-4.19%)
2 <0> (+1)

...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java
77.77% <0%> (-11.12%)
5% <0%> (-2%)

...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
58.06% <0%> (-6.46%)
3% <0%> (ø)

...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java
41.66% <0%> (-4.17%)
3% <0%> (ø)

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
54.21% <0%> (-3.62%)
13% <0%> (-2%)

...bo/remoting/transport/netty/NettyCodecAdapter.java
53.12% <0%> (-1.57%)
3% <0%> (ø)

...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java
77.2% <0%> (-1.48%)
29% <0%> (ø)

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
58.33% <0%> (-0.84%)
30% <0%> (-1%)

.../dubbo/remoting/transport/netty4/NettyChannel.java
66.25% <0%> (+1.25%)
23% <0%> (+1%)
:arrow_up:

...he/dubbo/remoting/transport/netty/NettyClient.java
83.05% <0%> (+10.16%)
13% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f926d9...5b32bb2. Read the comment docs.


Apache RAM/fds usage metrics

Would it be possible to add apache RAM and fds usage? So far I see process RAM/fds metrics, but I think process means metrics of the exporters and not apache server.

Indeed, they're exporter process metrics.
We only export CPU metrics since they're provided by the status page itself,
but even that seems to go against the best practices.
I don't think we'll add RAM and fds metrics for that reason.
Please see below:
https://prometheus.io/docs/instrumenting/writing_exporters/#machine-and-process-metrics

Machine and process metrics
Many systems, for example Elasticsearch, expose machine metrics such as CPU, memory and filesystem information. As the node exporter provides these in the Prometheus ecosystem, such metrics should be dropped.


Agency Interests Percent Encoding

It appears the Agency Interest CSV string is not getting percent encoded

This is actually a valid character in the query string of a url


Caliptra integrator requirements out-of-date

https://github.com/chipsalliance/caliptra-rtl/blob/main/docs/CaliptraIntegrationSpecification.md#soc-integration-requirements
Has outdated items like CSR signing key.
Scrub against main spec to ensure all requirements are captured (IDevID certificate requirements is one example gap)

There is an ongoing PR to add couple of rows for to that table and we will also remove the CSR signing key rows...what else HW integ requirements exist for IDevID?

The high-level problem is that the main spec doesn't explicitly call out requirements to integrators. Scrubbing through it, here's what I think we need to add here:

Explicitly note what fuses need to be backed by physical fuses. For example, owner_pk_hash can come from flash instead, but field entropy threat model assumes fuse.
Must program the IDevID certificate with fields defined per https://github.com/chipsalliance/Caliptra/blob/main/doc/Caliptra.md#idevid-certificate
Must use internal TRNG for production
Add https://github.com/chipsalliance/Caliptra/blob/main/doc/Caliptra.md#fuse-requirements
Clarify the powergood reset intention with regard to firmware recovery flows

@varuns-nvidia - I think number#3 point above is a change in POR from what we have been stating. Not everyone has been conveying to us exactly how they intend to implement TRNG. I would rather say "suggest" than "must".

Fair, can interpret the change here as non-mandatory https://github.com/chipsalliance/Caliptra/commit/52c7100186f64784052df9e6626d9363be3fc200

Is this bug resolved now?


How to support Chinese characters in new WebSocketClient()

when I add parameters at the end of url  as follow:
wss://xxx.com/online_test?system=-1&80010086=-1&80010087=-1&userName=我是.
WebSocketClient() translate the Chinese words to ??:3
I try to change the headers , but failed.
Map<String, String> headers = new HashMap<String, String>();
headers.put("Content-Type", "application/json; charset=utf-8");
Still wrong :
write(293): {GET /online_test?system=-1&80010086=-1&80010087=-1&self=3&userName=??:3&token=a45dac5adfa4w HTTP/1.1

Hello @9992800,
you have to html encode all the chinese characters to valid html.
Greetings
marci4


Use native ES2015 features supported by node 4 LTS

In https://github.com/tngan/express-saml2/issues/51 it was decided to only support latest node and node LTS.
That makes the current oldest supported version node 4, which has native support (http://node.green/) for some of the functions that were used from lodash. This PR replaces those functions with their native version.

Coverage decreased (-0.03%) to 71.544% when pulling 641613615d010e2ee588b70b1f86d84508c7a78a on style/object-assign into 79196482d61a994d612adefd5c681d5e43babebb on 2.0.0-beta.


Define internal data format for photometry

We have settled on pynapple.

[x] a TsdFrame or TsdSeries contains the signal.
[x] if there is one or several reference channel(s) it is in a different Frame/Series
[x] if there are several signal bands, the TsdFrame can be an array
[x] the reference TsdFrame has the same dimensions as the signal frame
[x] if only one of the signal bands has a meaningful reference, the empty reference is filled with NaNs
[x] column names should be rois or regions names
[ ] We need to look into the possibility of attaching a "trace header" metadata dictionary to the Pynapple object.
[x] Create an integration test passing the synthetic dataset through common pipeline

metadata for pynapple is coming soon (merged PR)

@oliche would close this now, documentation of the data format is now part of #28

#32 proposal to drop pynapple again and revert to pd.DataFrames


Update teams and permissions

Fixes #52

Hello @philerooski! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file kirallymanager/manager.py:

Line 357:14: E261 at least two spaces before inline comment
Line 524:80: E501 line too long (81 > 79 characters)
Line 527:39: E261 at least two spaces before inline comment
Line 530:39: E261 at least two spaces before inline comment
Line 532:29: E251 unexpected spaces around keyword / parameter equals
Line 533:40: E261 at least two spaces before inline comment
Line 542:36: E261 at least two spaces before inline comment


Email validation?

Firstly, thanks for this plugin - super simple and perfect for what I need.
I was just wondering what the status is with email validation? If I submit the form with some malformed text, I get the error in the console:
Uncaught gatsy-plugin-mailchimp: email must be of type string and a valid email address. See README for more information.
Which suggests something is validating the email address somewhere - is there a built in way to report that out to the user? I'm happy adding in my own validation to my form, but it seems like it already exists in some form.
Thanks!

good eye!
https://github.com/benjaminhoffman/gatsby-plugin-mailchimp/blob/master/src/index.js#L62
but now i realize I need to update this.  i shouldnt be throwing an error.  instead, i should match the mailchimp API and return an object like this:
{
  status: 'error'
  msg: 'email must be of type string ...'
}

this way, front end eng's like you can simply key off the status key and bubble up the error to the client.
@martynhoyer interested in opening a pull request that turns this throw into a return {...}?


Initial setup

Builds and pipelines setup for deployment.

@WadeBarnes rather than adding a webhook for each pipeline in the source repository, there is one pipeline (build) that acts as proxy and triggers the others when a webhook is received.


Bugfix: Do not use params.ip to filter Websocket peers

I have introduced a bug in 7.4.0 because params.ip is used to filter peers in Swarm._getPeers. To fix this, I propose the addition of params.type in the peer data to filter against this.
What do you think?

I am merging this since this bug can be painful for users

Thanks for the PR! My hand was injured, so I was taking it easy for a few days. Thanks for figuring this out!

Released as 7.4.1.


DatasetIamMember does not preserve view permission

Describe what happened
If you have created a view using a dataset from a different project, and then try to apply permissions using the pulumi DatasetIamMember method on that same dataset, it will remove all the view permissions from the dataset, causing the earlier created view to fail.
The role however does not remove any regular iam permissions, as described. Only the views permissions are affected
Sample program
            bigquery.DatasetIamMember(
                f"dataset-{dataset}-{role}-{member_args['name']}",
                args=bigquery.DatasetIamMemberArgs(
                    dataset_id=dataset,
                    member=member,
                    role=role,
                    condition=condition
                ),
                opts=options
            )

Log output
No response
Affected Resource(s)
Bigquery dataset iam permissions
Output of pulumi about
Any version, verified with latest as well.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

I just found the following documentation.

So it appears to work as intended.
However, what can you recommend if we need to manage members and viewes access at the same time?


WIP ✨ Add cron expression parser

This pull requests adds astrolabe::CronSchedule which implements a cron expression parser and iterator to generate corresponding DateTime structs.

Codecov Report

Merging #1 (271fbc9) into main (431bc55) will decrease coverage by 11.34%.
The diff coverage is 3.57%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##              main       #1       +/-   ##
============================================
- Coverage   100.00%   88.66%   -11.34%
============================================
  Files           13       14        +1
  Lines         2322     2621      +299
============================================
+ Hits          2322     2324        +2
- Misses           0      297      +297

Impacted Files
Coverage Δ

src/cron.rs
0.00% <0.00%> (ø)

src/datetime.rs
89.37% <0.00%> (-10.63%)
:arrow_down:

src/errors/mod.rs
66.66% <0.00%> (-33.34%)
:arrow_down:

src/lib.rs
100.00% <ø> (ø)

src/shared.rs
100.00% <ø> (ø)

src/util/parse.rs
100.00% <ø> (ø)

src/time.rs
92.49% <21.42%> (-7.51%)
:arrow_down:

src/date.rs
91.07% <25.00%> (-8.93%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CronSchedule will be added by #2


Adding licensing for code

This is a very useful plugin. I would suggest to add usage license like other plugins so that there is no confusion.
Example: https://github.com/bernielomax/zabbix-rabbitmq-plugin

Thank you for updating the license terms.


Scroll to Section

Hi, thanks for the great library.
I would like to know how can I scroll to a section on a click event, say a button click. It would be really helpful if you could provide me some insight into implementing this.

Hi @jazeelmohd, thank you for using the library!
To scroll within the RecyclerView you can use one of RecyclerView#scrollToPosition or RecyclerView#smoothScrollToPosition. These methods take as a parameter the global RecyclerView position. To determine it for a specific section, you can use SectionDataManager which implements PositionManager interface.
For example, to scroll to the header of the section #3, you can write the following code:
int sectionIndex = 2;
int firstItemPos = sectionDataManager.calcAdapterPos(sectionIndex, 0);
int headerPos = firstItemPos - 1;
recyclewView.smoothScrollToPosition(headerPos);

If your section is headerless, you can simply use firstItemPos.
If you need to scroll to the state in which selected section is at the very top and you are using LinearLayoutManager, you can use scrollToPositionWithOffset:
linearLayoutManager.scrollToPositionWithOffset(determinedPos, 0);

The general idea is that you can calculate the global RecyclerView position and then write the same logic as if you were using default RecyclerView adapter.
Let me know if my answer was helpful.

Hi @jazeelmohd, thank you for using the library!
To scroll within the RecyclerView you can use one of RecyclerView#scrollToPosition or RecyclerView#smoothScrollToPosition. These methods take as a parameter the global RecyclerView position. To determine it for a specific section, you can use SectionDataManager which implements PositionManager interface.
For example, to scroll to the header of the section #3, you can write the following code:
int sectionIndex = 2;
int firstItemPos = sectionDataManager.calcAdapterPos(sectionIndex, 0);
int headerPos = firstItemPos - 1;
recyclewView.smoothScrollToPosition(headerPos);

If your section is headerless, you can simply use firstItemPos.
If you need to scroll to the state in which selected section is at the very top and you are using LinearLayoutManager, you can use scrollToPositionWithOffset:
linearLayoutManager.scrollToPositionWithOffset(determinedPos, 0);

The general idea is that you can calculate the global RecyclerView position and then write the same logic as if you were using default RecyclerView adapter.
Let me know if my answer was helpful.

Thanks for the quick reply. It worked


Theme - App returns to main chat instead of previous page when returning from changing theme

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: .1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Click Settings from the bottom
Click Profile from the top
Click back button
Note that app returns to Settings
While in Workspaces page, click Profile > Preferences > Theme
Select a different theme
Click Back button

Expected Result:
App returns to Workspaces page
Actual Result:
App returns to main chat
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/a0854c6f-df4b-44cb-bb54-fbb755576bec
View all open jobs on GitHub

We think that this bug might be related to #vip-vsp
CC @quinthar

I think this is actually related to Wave8: Ideal Nav

I'm on the fence of this being a blocker, it doesn't really break any functionality, it's just slightly unexpected. I'll leave the decision to @tylerkaraszewski though

I don't think it needs to be a blocker. It seems it can probably be external as well, does any one object to that?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Back button does not go to the previous Stack from the theme modal.
What is the root cause of that problem?
Deep linking is required to go back to the /settings/preferences previous stack
What changes do you think we should make in order to solve the problem?
This is achieved by updating the back handler here:
https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/pages/settings/Preferences/ThemePage.js#L43
And specifying the deep link instead:
https://github.com/Expensify/App/blob/3ab4e6e12d9ff38e69493321f0d31f032481b373/src/pages/settings/Preferences/ThemePage.js#L43
What alternative solutions did you explore?
I observed that the follow screens also all will require a deep link from settings/preferences stack: Priority Mode, Language, and finally Theme.

this issue needs to be handled here: https://github.com/orgs/Expensify/projects/94/views/2?pane=issue&itemId=51976513

Thank you for pointing that out. I'll close this one in favor of that one 🙇


User page

Prerequisite for the leaderboard.
Implements a table user_game_history that stores the history of each game played.
User pages now exist at: /user/<username> or /user/id/<user_id>

Merging this branch. This will create a conflict with the other pull request #29 due to both having database schema changes.


Boosting items don't activate if the holder is at +6

My understanding is that this applies even when the user has the ability Contrary, although quite what they're doing with a boosting item in this case is beyond me...

I wonder if there's a better way to script this.

I'll have to check the general interaction again since the only thing I remember from 5 years ago is how Starf interacts with Contrary when some of your stats are already +6.

Okay so yes, in general, Berries will activate while the stat is +6 if you have Contrary.
The Contrary Starf interaction I mentioned before is that if it randomly chooses a stat already at +6, it will not check again until the next Berry check happens for you, exactly like that self-hit in confusion Berry stuff.

Sorry, I meant -6 for the Contrary Starf part; corrected it above. It randomly chooses first, finds that it can't actually lower that stat anymore, and fails silently. Acupressure behaves the same way except you get the failure message. It's funny that they didn't account for it since Shuckle gets both Acupressure and Contrary.

Let me see if I've got this clear:

Berry eating check is invoked (out of scope of this PR)
Pokémon's HP is checked depending on Gluttony
Boost is applied accounting for Contrary (and Simple)
If boost succeeds, ate berry and boosted animations play in that order

We may want to introduce a canBoost function?

That sounds right, @urkerab.


Bring pretty printer up to date

The pretty printer converts a Regex defined in syntax into a RegexBuilder-style one, but it isn't up to date with the latest changes. This needs to be brought up to date, ideally with a validator that can take a regex and some input/output data, convert the regex to builder style, and then validate that both regexes have the same behavior.
For example, #"(?P)\w+ \d{2,} -"# converts to
Group(/* TODO: changeMatchingOptions */) {
  Concatenation {
    /* TODO: assertions */
    OneOrMore(.eager) {
      .wordCharacter
    }
    "-"
  }
}

instead of
Regex {
  Anchor.startOfInput
  OneOrMore(.eager) {
    CharacterClass.wordCharacter
  }
  "-"
}.asciiOnlyCharacterClasses()

@Azoy what's the status of this?

The updates I had for PrettyPrinter were merged into main a little bit ago. For Nate's example specifically, we print
Regex {
  OneOrMore {
    .word
  }
  " "
  Repeat(2...) {
    .digit
  }
  " -"
}

which isn't quite right. IIRC it still needs to support changing matching options.


Decode HEVC streams adds garbage lines

When decoding an HEVC stream with resolution 1920x1080 MediaSDK says frames are 1920x1088 and the last few lines seem to contain zeros (green).
The NAL-unit of the stream says it's 1920x1080 and various media players also reports 1920x1080.
I don't know if this is a problem for other codecs as well. I'm using Media SDK 20.1.0 on an Apollo Lake. Video memory is used through vaapi.
Found a report of the same issue here:
https://community.intel.com/t5/Media-Intel-oneAPI-Video/1080p-hevc-video-decoded-to-render-with-a-green-edge-at-the/td-p/1131080

Hi Herman,
It's due to memory alignment requirements from HW. HW wants surfaces to be 16 aligned for progressive and 32 for interlace.
Does it cause some issue in your pipelines?
Regards,
Dmitry

Hi @dmitryermilov
Yes, It's an issue for me. When letterboxing the video a green line is visible at the bottom of the active video. I also need to present the correct input resolution for the user.
I think there should be a difference between the actual input resolution and the allocated frame resolution. If this info is available (maybe it is?) it would be easy to just crop the padding lines.
BR
Herman

@HermanMolinder
I tried by the following command line on my Linux/KBL platform but I cannot see the green line:
./sample_decode h265 -i msdk_2196/Lifting_HEVC_1080p.hevc -vaapi -r
The input clips comes from your referred https://community.intel.com/t5/Media-Intel-oneAPI-Video/1080p-hevc-video-decoded-to-render-with-a-green-edge-at-the/td-p/1131080.
And I also checked the XWindow size:
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/samples/sample_common/src/vaapi_device.cpp#L187
pSurface->Info.CropH == 1080
Backtrace:
#0  CVAAPIDeviceX11::RenderFrame (this=0x55555580b480, pSurface=0x5555558ebc50) at /home/yanwang/open_media_workspace/MediaSDK/samples/sample_common/src/vaapi_device.cpp:187
#1  0x00005555555687ec in CDecodingPipeline::DeliverOutput (this=0x7fffffffbae0, frame=0x5555558ebc50) at /home/yanwang/open_media_workspace/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:1568
#2  0x0000555555568a26 in CDecodingPipeline::DeliverLoop (this=0x7fffffffbae0) at /home/yanwang/open_media_workspace/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:1607
#3  0x0000555555570a52 in std::__invoke_impl<void, void (CDecodingPipeline::)(), CDecodingPipeline> (__f=@0x5555558f1c60: &virtual CDecodingPipeline::DeliverLoop(), __t=@0x5555558f1c58: 0x7fffffffbae0)
at /usr/include/c++/8/bits/invoke.h:73
#4  0x000055555556ec90 in std::__invoke<void (CDecodingPipeline::)(), CDecodingPipeline> (__fn=@0x5555558f1c60: &virtual CDecodingPipeline::DeliverLoop(), __args#0=@0x5555558f1c58: 0x7fffffffbae0)
at /usr/include/c++/8/bits/invoke.h:95
#5  0x00005555555744bd in std::thread::_Invoker<std::tuple<void (CDecodingPipeline::)(), CDecodingPipeline> >::_M_invoke<0ul, 1ul> (this=0x5555558f1c58) at /usr/include/c++/8/thread:234
#6  0x0000555555574478 in std::thread::_Invoker<std::tuple<void (CDecodingPipeline::)(), CDecodingPipeline> >::operator() (this=0x5555558f1c58) at /usr/include/c++/8/thread:243
#7  0x000055555557445c in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (CDecodingPipeline::)(), CDecodingPipeline> > >::_M_run (this=0x5555558f1c50) at /usr/include/c++/8/thread:186
#8  0x00007ffff74ce523 in execute_native_thread_routine () from /lib64/libstdc++.so.6
#9  0x00007ffff77a8594 in start_thread () from /lib64/libpthread.so.0
#10 0x00007ffff6b9de6f in clone () from /lib64/libc.so.6
My MediaSDk commit: 5322c4a28b96f64425720e0416d2cb8285c7672a
Could you please use the latest release 20.2 to double check it?
If the issue is still existed, please provide your command line and clips.
Thanks.

Hi @wangyan42164,
I tried with 20.2 release, but I have the same problem.
Here's a photo of how it looks when letterboxing:

Here's a transport stream recording of the test stream (containing 2 programs with same problem):
https://a2b-my.sharepoint.com/:v:/g/personal/herman_molinder_wisi_se/Eb18ocQV_t5Ojj3lUC8CD7gBDqUwzZCUI6solIZxb8UEkg?e=ipc9Ta
I'm not using msdk samples code, but we have our own application implemented.

@HermanMolinder So could you pleease try sample_decode on your side? I am not sure how to process output surface in your application. sample_decode may make us at the same page. Thanks.

I think I found the issue now.
MFXVideoDECODE_QueryIOSurf returns following frame info:
{reserved = {0, 0, 0, 0}, reserved4 = 0, BitDepthLuma = 8, BitDepthChroma = 8, Shift = 0, FrameId = {TemporalId = 0, PriorityId = 0, {{DependencyId = 0, QualityId = 0}, {ViewId = 0}}}, FourCC = 842094158, {{Width = 1920,       Height = 1088, CropX = 0, CropY = 0, CropW = 0, CropH = 0}, {BufferSize = 71305088, reserved5 = 0}}, FrameRateExtN = 50, FrameRateExtD = 1, reserved3 = 0, AspectRatioW = 1, AspectRatioH = 1, PicStruct = 1, ChromaFormat = 1,   reserved2 = 0}
The decoded surface contains following frame info:
{reserved = {0, 0, 0, 0}, reserved4 = 0, BitDepthLuma = 8, BitDepthChroma = 8, Shift = 0, FrameId = {TemporalId = 0, PriorityId = 0, {{DependencyId = 0, QualityId = 0}, {ViewId = 0}}}, FourCC = 842094158, {{Width = 1920,       Height = 1088, CropX = 0, CropY = 0, CropW = 1920, CropH = 1080}, {BufferSize = 71305088, reserved5 = 70780800}}, FrameRateExtN = 50, FrameRateExtD = 1, reserved3 = 0, AspectRatioW = 1, AspectRatioH = 1, PicStruct = 1,   ChromaFormat = 1, reserved2 = 0}
Thus the query function returns 0 for CropW and CropH, but the decoded surface contains the correct values. I think this is somewhat problematic because usually you want to set up your cropping/resizing at init and I would expect these values to be known.
Is there a reason for CropW and CropH being 0 when querying or is this a bug? Shouldn't those be static, as for Width and Height?

IMHO, it is dependent on your application. For HW, CropW/H is unnecessary.
For sample_decode, it will use the CropW/H of decoded surface to render.

IMHO, it should be dependent on your application.  CropW/H is unecessay for decoding HW.
For sample_decode, it will use CropW/H of decoded surface to render and resize X window on Linux.

We do need this info for our application.
Is there a reason for CropW and CropH being 0 when querying or is this a bug?

IMHO, it is not bug. MFXVideoDECODE_QueryIOSurf  should be only for surface creation.

Hi Herman,
Generally it's by design.
DecodeHeader returns mfxVideoParams which can be passed to QueryIOSurf  so that the function fills "the right" mfxFrameAllocRequest. Under 'the right' I mean a request with Width/Height which satisfy HW requirements.
Later, during decode, DecodeFrameAsync function updates Crops in output mfxFrameSurface's and set them to actual values. So the expectation is that a downstream component will take crops into account.
On the other hand I understand that it causes problem to you. BTW, there was a similar discussion in https://github.com/Intel-Media-SDK/MediaSDK/issues/916 .
Let's focus on letterboxing issue. Do you mean msdk VPP letterboxing ? If so, could you send VPP init params and mfxFrameSurfaces passed to RunVPPFrameAsync ?

Hi @wangyan42164 and @dmitryermilov
You're right. It's not up MFXVideoDECODE_QueryIOSurf to determine this. I mixed things up and have investigated further.
MFXVideoDECODE_DecodeHeader returns correct cropping parameters (1920x1080). Subsequently I call MFXVideoDECODE_Query which sets cropping parameters to 0. This was my problem.
When checking the code it looks like h265 memsets the mfxVideoParam *out to 0 and never sets crop values. Looking at the same function for h264 it looks like it does actually set crop values in the function void CheckCrops(const mfxFrameInfo &in, mfxFrameInfo &out, mfxStatus & sts).

My point being I think h265 also should have a CheckCrops function within MFXVideoDECODE_Query.

@dmitryermilov
To answer your question. Yes, I use VPP for letterboxing.
Now when I know the problem I've made a workaround to manually set cropping params if query zeros them. It seems to work fine now :)
Thanks for the help!

@HermanMolinder can we close this issue?

@daleksan
For me it's ok to close issue. My workaround works. However I still claim this is a bug in msdk, as MFXVideoDECODE_Query sets crop values to 0 for HEVC (but not for MPEG2/H264). It's up to you how you want to proceed with this issue.

Hi @HermanMolinder , seems this one https://github.com/Intel-Media-SDK/MediaSDK/pull/2187 fixes the issue. Can you please confirm?

Hi @dmitryermilov,
Yes, that looks correct! You can close this issue.

Great :) !


Add note to shadow_mesh docs to warn about improper usage

Fixes: https://github.com/godotengine/godot/issues/72071
Using a different mesh for shadow_mesh breaks rendering right now because the shadow mesh is used for the depth prepass.
If we don't use it for the depth prepass, we will hurt performance. Further, the rendering will still appear broken as we will get all kinds of self-shadowing artifacts. Therefore, we just shouldn't support using a different shaped mesh for shadows. Users should use the old workflow which is to have a child MeshInstance3D with SHADOW_CASTING_SETTING_SHADOWS_ONLY and have the source mesh use SHADOW_CASTING_SETTING_OFF. Doing so has no additional cost over using shadow_mesh, but gives the user full control over how the shadow is drawn.

I guess this also invalidates https://github.com/godotengine/godot-proposals/issues/2600 as a proposal? It seemed to work from my quick testing, but I didn't test on more complex meshes.

I guess this also invalidates godotengine/godot-proposals#2600 as a proposal? It seemed to work from my quick testing, but I didn't test on more complex meshes.
That is, unless the proposal would allow performing this automatically:

Users should use the old workflow which is to have a child MeshInstance3D with SHADOW_CASTING_SETTING_SHADOWS_ONLY and have the source mesh use SHADOW_CASTING_SETTING_OFF. Doing so has no additional cost over using shadow_mesh, but gives the user full control over how the shadow is drawn.

Performance gains can be significant with 4-split PSSM (or in scenes with lots of point lights with shadows enabled) if you have lots of complex meshes.

Using nearby LODs won't be as bad as a completely different mesh for shadows (like in the OP issue). I think https://github.com/godotengine/godot-proposals/issues/2600 would be better off with an LOD bias for shadows specifically. Remember, when used in the depth prepass, using a different mesh (even a different LOD of the same mesh) will totally break rendering. However, using a lower LOD for shadows only maybe be feasible.

Thanks!


Dependencies: Add Husky githook

What?
Husky is a dependency that makes githooks easy. It allows you to hook into commits, pushes & etc.
Why?
Prevent bad commits. Make pull request look more clear by preventing commits like 'Fix Travis'. This makes it easier to focus on the problem a PR is trying to solve.

Looks interesting, but I don't see a commit message check?

I also don't understand what the Husky dependency adds? Aren't commit hooks built into Git?

@Zarel
Essentially what Husky does is that when it gets installed, it installs its git hook. git clone doesn't install any git hooks for security reasons, so something like that is needed for this to work.

@Zarel Do you mean linting of the commit message itself?

@xfix Oh, that makes sense. I think that's a good idea.
@supersoniko Yes.

I guess there's not that much we can do, because every rule has exceptions. I'd say nevermind on linting commit message formatting.

We don't lint commit message formatting for the same reason at my work. Husky really helps us keep code reviews & the commit history clean.

I suppose I have no objection.


Tag 0.1.18 missing

It seems the tag 0.1.18 is missing on the GitHub repository, while 0.1.18 is already on Maven Central.
Just a info.

I see the tag has been added. I close.


Fix issue #69, overriding of nested schema by parent

includes test and test data
Replaces Pull 128

Looks good, thanks for contributing to Yamale!