Create a Contributor object to use throughout the schema

The following point was moved here from #530:

[ ] Acknowledgement? Is it time to create a Person object to use throughout the schema? Link to JSON-LD?

Currently we have multiple data structures in the schema that refer to people contributing to a study (ex. study subjects):

Acknowledgement object (has properties: ID, name, institution, ORCID; all [string])
Study.study_contact property [string]
Study.collected_by property [string]

Study.lab_address holds the institutional information for the person in collected_by.

Study.submitted_by property [string]

We could use the following taxonomy to describe a persons role in a project:
https://casrai.org/credit/

So each of the above are replaced with Contributor

study.study_contact : Contributor {}
study.collected_by : Contributor {}
study.submitted_by : Contributor {}

We could use the following taxonomy to describe a persons role in a project:
https://casrai.org/credit/

How would you see this working?
Contributor : {
    name:string, (e.g. "Brian Corrie")
    institution: string (e.g. "Simon Fraser University")
    institution_uri: string, (e.g. "ROR:0213rcc28")
    orcid_uri: string, (e.g. "ORCID:0000-0003-3888-6495")
    credit: Ontology {
        label: string (e.g. "Data curation")
        id: string (e.g. "CRT:f93e0f44-f2a4-4ea1-824a-4e0853b05c9d")
    }

Example is from: https://credit.niso.org/contributor-roles/data-curation/

This would be minimal, and complete, but would require lookup every time one wanted to actually use anything.
Contributor : {
    orcid_uri: string, (e.g. "ORCID:0000-0003-3888-6495")
    credit: Ontology {
        label: string (e.g. "Data curation")
        id: string (e.g. "CRT:f93e0f44-f2a4-4ea1-824a-4e0853b05c9d")
    }

Not a fan of this...

I kinda feel if we're going to go this far in adding a Contributor object, we should go all the way and allow for any number of contributors to be attached to a study. Thus, not restrict ourselves to only those 3 categories (study contact, collected, submitted).
Plus, there's a little bit of disconnect between the contributor roles in CREDIT. Those roles indicate what contribution that people made, but none of the roles exactly match the roles we want, i.e. a study contact, the person who collected the data and is legally response for the data, and the person who submitted the data. The "Data Curation" role in CREDIT is roughly similar to the data submitter, but nothing really matches for the other two.

Yes, the credit and contact purposes are somewhat different. The MiAIRR fields are contact fields more than credit fields. If you want to ask someone about sample prep, ask the collected_by person, curation ask submitted_by, and about the study in general the study_contact.
These aren't really providing credit - and maybe MiAIRR doesn't need to?

These aren't really providing credit - and maybe MiAIRR doesn't need to?

I think not. The Contributor object is to standardize person information, that makes sense but I don't think CREDIT roles are really necessary.
However, one limitation with the current design is only one person can be assigned. There are sometimes multiple study contacts, and there are often multiple data submitters. For example, when Kira did metadata curation, and I did the data processing, I'd like to list both of us as the data submitters so we both get credit...

@bcorrie The "long" version of the Contributor record looks good to me. I also agree that we should have an array of Contributor objects in a study, so that proper credit can be provided.
Regarding the "contact" roles defined in MiAIRR: I also would consider them to be only weakly correlated with the credit information. I could think of two ways to combine them:

A Contritbutor record contains study_contact, collected_by and submitted_by as boolean fields, so you can flag the respective person.
We keep study_contact, collected_by and submitted_by as properties of Study, but they contain an index to the respective record in the Contributors array.

This ontology has a more complete set of roles, though I'm not sure if anything actually matches as contact (supervisor role?). Though maybe we can request a term...

@bcorrie The "long" version of the Contributor record looks good to me. I also agree that we should have an array of Contributor objects in a study, so that proper credit can be provided.

Agreed, also credit should be an array so that multiple roles can be assigned.

A Contritbutor record contains study_contact, collected_by and submitted_by as boolean fields, so you can flag the respective person.
We keep study_contact, collected_by and submitted_by as properties of Study, but they contain an index to the respective record in the Contributors array.

or 3. We designate/document 3 terms from this ontology for those roles, for example:

study_contact == supervision role ?
collected_by == collection role ?
submitted_by == submitter role ?

@schristley Now looked at this in more detail: CRO is a complete superset of the CRediT taxonomy, the terms even have the same names and definitions. So we get the additional term we need for free when using it and it is simpler to integrate as it is an OBO Foundry ontology as well.

Where should the array containing the Contributor records be located in the schema? Is it rather

an independent top-level object, or
a property of the Study object?

@williamdlees Would either of these work for the Germline Acknowledgements? Or would the Contributor records need internal IDs for referencing?

(1) should work. At the moment there is a top level Acknowledgement object which is used by AlleleDescription and GermlineSet. It has an acknowledgement_id but it's not used.

a property of the Study object?

I'd probably prefer this to keep it simple, without needing to create identifiers, worrying about uniqueness and so forth. This also allows the contributor role to be different for study versus germline.

Potential structure...
Contributor : {
    contributor_pid: string, (e.g. "ORCID:0000-0003-3888-6495")
    name: string,
    email: string,
    affiliation_pid: string,
    affiliation_name: string,
    affiliation_address: string,
    roles: array
}

do we need to allow multiple affiliations?

do we need to allow multiple affiliations?

ORCID handles those complexities, maybe we can state that this is the primary affiliation that one has with this study and defer to ORCID for complex relationships and affiliations.

Regarding affiliation_address: Are we ok with ,[state,] ? This information is already in ROR, so we could just pull it from there. Or is anyone still receiving physical mail these days? :-)

Does it make sense to use PID id/label pairs as I did in: https://github.com/airr-community/airr-standards/issues/552#issuecomment-1016809146
This provides more consistent use with other URI based PID objects in the standard. We might do this for the person and institution (e.g. affiliation.id, affiliation.label) rather than have custom fields (affiliation_pid, affiliation_name) or those objects.

Does it make sense to use PID id/label pairs as I did in: #552 (comment)
This provides more consistent use with other URI based PID objects in the standard. We might do this for the person and institution (e.g. affiliation.id, affiliation.label) rather than have custom fields (affiliation_pid, affiliation_name) for those objects.

Are we requiring that all contributors have an ORCID? And if they don't, then how should their information be recorded?

Regarding affiliation_address: Are we ok with <city>,[state,]<country> ? This information is already in ROR, so we could just pull it from there. Or is anyone still receiving physical mail these days? :-)

Yes, that is probably okay. What about department name(s)?
I think it's reasonable that we don't expect this to be complete and thorough contact information, but enough information that somebody could find the person with some extra googling? On the other hand, if it's a legal contact then it likely needs to be as specific as possible.

What about department name(s)?

This is currently beyond the scope of ROR. They are working on this, but I don't expect this to happen any time soon. So either we have a free text field for this or skip the information altogether.

Are we requiring that all contributors have an ORCID?

If we are using these fields as ID/label pairs this would be a consequence of it (as the IDs must resolve to the label or a synonym for it).

Are we requiring that all contributors have an ORCID?

If we are using these fields as ID/label pairs this would be a consequence of it (as the IDs must resolve to the label or a synonym for it).

Right. That's why I avoided the Ontology ID/label with my suggested structure. That is, the ORCID (or other PID) can be provided if it's available but it isn't required.

Some further points, based on a couple of RDA-DE talks today and yesterday:

ORCID has started to support RORs (actually they want to make it their primary institutional identifier in the near future).
ORCID is also supporting CRediT, which apparently has seen quite a good uptake especially with publishers
CRediT is deliberately designed to contributor roles, not administrative roles (i.e. contact person).
There is a third vocabulary for contributor roles in the DataCite metadata schema (see page 20, which also contains a "ContactPerson" role.


Hot fix estimating EVM transaction fee

Version test: http://<IP_ADDRESS>:8900/s/CHmzzoGcoRi4Qom

[ ] Handle case transfer Max on some chain (example: AVAX)

Version test: http://<IP_ADDRESS>:8900/s/qgCAJYTq6ey4iww
Still, I reproduce this issue https://github.com/Koniverse/SubWallet-Extension/issues/2412#issuecomment-1870243939

Version test: http://<IP_ADDRESS>:8900/s/qgCAJYTq6ey4iww Still, I reproduce this issue #2412 (comment)

Resolve later in https://github.com/Koniverse/SubWallet-Extension/issues/1549


added explicit setter in tag model, removed callback

Removed before_validation callback
Added explicit setter for name

Thanks Tomasz, appreciate the patch, but I'm curious as to why? What's prompted these changes?

One benefit may be that this will work even when callbacks are skipped.

I would say using setter makes the intent clear and the less callbacks the better.

Yeah, I would stay away from callbacks as much as possible. Also, as @apneadiving commented, setters express intention more clearly.

Fair enough. I agree that callbacks should be avoided where possible - though I'm less concerned when they're used to address internal model behaviour (as opposed to involving other models, or worse still external APIs, etc).
The trade-off here is that the normalisation will only occur when the name is set via the setter. Thankfully ActiveRecord uses setters via .new, .create, #update_attributes and #update_attribute, so the trade-off is worth it.
As for callbacks being skipped - sadly ActiveRecord does not use the setter for #update_column or #update_columns, so it'll only be more reliable in the case of using #save with :validate => false.

Thanks Tomasz for the PR, and everyone for their thoughts on the change 👍

Sure thing. Cool project btw.

As for callbacks being skipped - sadly ActiveRecord does not use the setter for #update_column or #update_columns, so it'll only be more reliable in the case of using #save with :validate => false.

In the case of update_column[s] the callbacks have always been skipped, so the name normalizer has never worked there to begin with, and this change continues that pattern, so no gain, no loss.


can not generate package.json in the target folder, always added in /Users/administrator folder

when after run npx create-wdio@latest ./e2e in target folder with terminal, there has not package.json generated in target folder, instead of always generate the package.json file in /Users/administrator folder, although input the target folder path

Can you please provide more information? From which directory do you call this command and how does the folder structure look like after the setup is done?

I work on Mac OS 12.6.2, node -v 16.15.0, npm  8.5.5
I run this command in the folder ./Users/administartor/Documents/WebdriverioTest, after executed the command, only three items generated in the folder of ./Users/administartor/Documents/WebdriverioTest, there created one folder named test, and two file named tsconfig.json, wdio.conf.ts, nothing else

Can you provide which answers you picked for the questions?

Can you provide which answers you picked for the questions?

Can you provide which answers you picked for the questions?

Can you provide which answers you picked for the questions?

Can you provide which answers you picked for the questions?

how to make the package.json generated in the same folder with the project instead of automatically added in the folder of /Users/administrators  although i input the exact path

@7999 well this doesn't really answer my question, it would be useful to be able to reproduce your case to understand what is going on. Note that WebdriverIO creates in some cases an addition package.json to allow running tests in an ESM context.

package-lock.json & package.json are created in /Users/Steven/ for me too.
If I run npx create-wdio@latest ./test in /Users/Steven/Documents/Projects/ the first question is:
A project was detected at "/Users/Steven", correct?, I choose no
What is the project root of your test project?, I enter /Users/Steven/Documents/Projects/test,
and select the following options:

local
On my local machine
Mocha
No
y
Enter
y
Enter
spec
Enter
chromedriver
https://example.com
y

The package-lock.json & package.json are created in /Users/Steven/.

This is the expected behavior. If you have a package.json in one of the parent directories, it uses that to install the dependencies to. Your tests are created in /Users/Steven/Documents/Projects/test. We could extend the configuration wizard to ask the question whether an additional package.json should be created or if the one found should be re-used. Any contributions for that would be welcome!

I believe this should be resolved when we release https://github.com/webdriverio/create-wdio/pull/585

https://github.com/webdriverio/create-wdio/pull/585 was released.
@7999 @sdoigmm please verify and let us know if you still experience any issues. Happy to reopen. Thanks for reporting!


Marriage abroad: Support 6 outcomes/three question flow for Poland

This PR needs to be merged after #3083
Trello card
Description
The goal of this PR is to convert the flow for Poland to use the outcome per path strategy and also add support for three questions flow.
Factcheck
Preview link
GOVUK
Expected changes

Enabling  three questions flow for Poland
Number of outcomes have been reduces to 6

Before

After

@cbaines the test/data/marriage-abroad-responses-and-expected-results.yml setup up the flow for the regression tests to run through and generate artefacts. The integration tests are tests that validate the user journey and calculator/policy logic


Add invoke & pluck functions for lazy collections

IMHO, this doesn't make sense because an element of the collection is not limited to an array or ArrayAccess, even or any object exposing public property.
A feature for the specific case like this is not appropriate to be in core.

As @issei-m said, these are too narrow (work only for objects and/or arrays) and this library tries to be as generic as possible. The two proposed operators are just a shorthand for map and as such you can have a function defined somewhere and just pass that to the map (or call it in a map callback). I know it's not as clean because PHP doesn't think of function name as a symbol so you have to pass it as a string but what can you do.
Closing the PR now.

Ok, I can't argue this is rather specific (although rather often) case. Especially pluck(), as nowadays most use rather objects than plain arrays. Although, from my experience you often need to call one method on each item in collection - like extract value of a getter or modify it. So, instead of above, what about helper function like:
function invoke(string $method, ...$args): callable {
  return function ($item) use ($method, $args) {
    return $item->{$method}(...$args);
  };
}

this could be then used like:
$collection->map(invoke('getId'));

Still shorter than plain closure, IMO bit more readable and gives option to easier pass arguments to called method.  Downside: it's likely that this could break refactor->rename IDE functionality :(
Again, this helper is rather specific, but it's meant rather as a syntactic sugar, similarily to e.g. existing increment/decrement functions


Plan PANDEMOS visualization framework architecture.

Please provide more descriptions and avoid project accronyms which do not mean anything if project description is not available ;-)


Updating IHaskell-widgets

This pull request aims to solve the issue #870, updating the new widget protocol and implementing any new widgets
Things to do:

[ ] Update sample notebooks
[x] Implement the Link widgets
[x] Implement jslink and jsdlink as helper functions
[ ] Implement the Controller widget
[ ] Revise and improve documentation
[x] Fix the OutputWidget

There is a problem with capturing the output using the output widget. The output widget is able to capture the output if you set the MsgID attribute to the parent message id of messages to capture. This is thanks to the frontend, so you don't have problems with capturing stdout/stderr. So we could do function like:
captureOutput :: OutputWidget -> IO a -> IO ()
captureOutput o f = do
  setField o MsgID (getSomehowTheMsgID)
  f
  setField o MsgID ""
  return ()

The problem is, how could we get the id of the execution_request?


Definition for rule 'import/consistent-type-specifier-style' was not found in 2.26.0

Hello! I had this error when using the latest version (2.26.0) of your package:
Definition for rule 'import/consistent-type-specifier-style' was not found.

After checking node_modules, the rule was indeed not even mentioned anywhere inside the package. What gives?

@h0adp0re I was wondering the same but it is marked as Unreleased currently in the changelog - https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md#unreleased

Good catch. The latest release according to their GH releases is 2.25.2. Yet, I'm able to access 2.26.0 via npm. That is confusing if 2.26.0 shouldn't be available yet.

Everywhere on Github, you need to look at the docs for the tagged version you're using, and not those on master/main.
There's no explicit schedule for releases, nor any blockers. It will be released when I have the time both to do the release, and also to field any bug reports that come in after it's published.

Understood. That's a good point about only looking at the tagged version I'm using, I have not paid any mind to that in the past!
Thanks for replying and explaining.


Improve readme

Codecov Report

Merging #10 (e49ab84) into main (e5af511) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           55        55
=========================================
  Hits            55        55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5af511...e49ab84. Read the comment docs.


change default name

Laravel Mix Version: 4.0.7 (npm list --depth=0)
Node Version (10.15.3):
NPM Version (6.4.1):
OS: MacOS

Description:
When pass different name to mix js and scss, it also compile by default an app.css and app.js file beside to files that I specify to compile
Steps To Reproduce:

Pass different name instead of app.js and app.scss in webpack.mix.js
mix.js('resources/js/main.js', 'public/js')
    .sass('resources/sass/main.scss', 'public/css');

All it's done, I forgot to delete previous build :no_mouth:


建议服务详情可以看到服务占用资源情况

In GitLab by @cuiaq123 on Dec 17, 2019, 06:01

In GitLab by @cuiaq123 on Dec 17, 2019, 06:01
assigned to @luotian-github

In GitLab by @luotian-github on Dec 17, 2019, 07:56
assigned to @sokril and unassigned @luotian-github


[BUILD] Share jars to reduce binary release tarball size

Why are the changes needed?

The 1.6.0 binary tarball is nearly 300MB, we can reduce the size by sharing jars between engine and server, as beeline does.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[x] Add screenshots for manual tests if appropriate

-rw-r--r--   1 chengpan  staff   155M Sep  9 14:21 apache-kyuubi-1.7.0-SNAPSHOT-bin.tgz

[ ] Run test locally before make a pull request

Codecov Report

Merging #3459 (b86d1a0) into master (812ea2b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3459   +/-   ##
=========================================
  Coverage     51.42%   51.42%
  Complexity       13       13
=========================================
  Files           481      481
  Lines         26734    26734
  Branches       3750     3750
=========================================
  Hits          13747    13747
  Misses        11638    11638
  Partials       1349     1349

Impacted Files
Coverage Δ

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
78.00% <0.00%> (-2.00%)
:arrow_down:

...in/scala/org/apache/kyuubi/config/KyuubiConf.scala
97.44% <0.00%> (-0.08%)
:arrow_down:

...apache/kyuubi/engine/JpsApplicationOperation.scala
77.41% <0.00%> (ø)

...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala
89.96% <0.00%> (+0.69%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

LGTM, add trino engine works well.

Thanks, merging to master/1.6

Thanks for verification


Error building source-build-reference-packages commit 6e2aee6

I am trying to build source-build-reference-packages in Fedora
+ ./build.sh --with-sdk /usr/lib64/dotnet --with-packages /usr/lib64/dotnet/source-built-artifacts/Private.SourceBuilt.Artifacts.0.1.0-.tar.gz
 Found SDK version 3.1.103 in /usr/lib64/dotnet
 Microsoft (R) Build Engine version 16.4.0+e901037fe for .NET Core
 Copyright (C) Microsoft Corporation. All rights reserved.
...
"/home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/src/referencePackages/buildReferencePackages.proj" (default target) (1) ->
(Build target) ->
  /home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/src/referencePackages/src/nuget.common/5.1.0/NuGet.Common.csproj : error NU1101: Unable to find package runtime.native.System. No packages exist with this id in source(s): Local artifacts/bin dir, Source-built packages [/home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/src/referencePackages/buildReferencePackages.proj]
  /home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/src/referencePackages/buildReferencePackages.proj(55,5): error MSB3073: The command "$__DOTNET_CMD pack --output /home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/artifacts/reference-packages/ /home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/src/referencePackages/src/nuget.common/5.1.0/NuGet.Common.csproj /bl:/home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/artifacts/log/nuget.common/5.1.0/NuGet.Common.binlog /p:ArtifactsBinDir=/home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/artifacts/bin/ /p:ArtifactsObjDir=/home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/artifacts/obj/ /p:RepoRoot=/home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/ /nowarn:NU1603,NU1605,NU5125,CS0109,CS0169,CS0618,CS0649,CS3001,CS3002,CS3003,CS3009" exited with code 1.

    3313 Warning(s)
    2 Error(s)

Time Elapsed 00:10:18.85
error: Bad exit status from /var/tmp/rpm-tmp.KE9v3i (%build)

NuGet.Common.binlog.tar.gz

It would be useful to get /home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/src/referencePackages/src/nuget.common/5.1.0/obj/project.assets.json file to see why the package is being referenced, from this binlog line (I wonder if we can force/trick MSBuild to embed it in the binlog somehow, considering how useful it is?):
Writing assets file to disk. Path: /home/omajid/fedora-git/dotnet-build-reference-packages/source-build-reference-packages-6e2aee66b0e7a01664bde0f6b495bdbb4099f84c/src/referencePackages/src/nuget.common/5.1.0/obj/project.assets.json

Looking into what might be special about this package in source-build...
(Link to the copy on the gallery: https://www.nuget.org/packages/runtime.native.System/)

projects.assets.json.tar.gz

I have data for this package in a 3.1.104 tarball at ./packages/reference/staging/runtime.native.system, but I'm not sure how that translates to a source-build-reference-packages build... taking a look, thanks.

The dependency is fairly direct:

NuGet.Common.csproj (netstandard2.0) ->

System.Diagnostics.Process 4.3.0 ->

runtime.native.System 4.3.0

So I think the question is why runtime.native.System was available before and isn't anymore.
@dseefeld @crummel what do we expect to have available to the build at this point?

@dseefeld noted offline that his build doesn't have the System.Diagnostics.Process runtimeTargets section in the project.assets.json, and I think that indicates System.Diagnostics.Process is the "real" package rather than a ref package. I see in the assets file it's using a home directory packages dir, is it possible it's dirty?
  "packageFolders": {
    "/home/omajid/.nuget/packages/": {}
  },

(Possible fix: make source-build-reference-packages use a local package cache by default.)

I see in the assets file it's using a home directory packages dir, is it possible it's dirty?

Ugh. I think you are right. I am working on multiple things at a time, so it's very likely something else is polluting the cache. I am retrying with a clean cache and no other dotnet programs running.

I can confirm that cleaning my local nuget caches did the trick. Thanks for root-causing it so quickly!
I am going to close this issue since #1605 handles the remaining pain points.

Phew, glad that was it. 😄
I think ref-ness validation (https://github.com/dotnet/source-build/issues/1599) could be feasible with pretty good value in SBRP... there's fairly global knowledge that every dependency should be ref-only (so getting the right knowledge isn't likely to be a new source of bugs), and having the system point this out rather than kind of guessing based on project.assets.json would fast-track resolution.


discord

what code do i have to add to get his to connect to my discord to send the message

Nothing. Run the script, open Discord, press F3


Get selected values

How can I get the selected values?

Hello @davidandreuroqueta  you can get the selected values from your default select element just like vanila HTML select element. Because this package only changes the UI of the select element to multiple tags.


Can't find ackend URL config tab

Hello. I followed the "https://github.com/Interpause/auto-sd-paint-ext/wiki/Install-Guide", however in the bottom of the season it says:

Change "Backend URL" under the Config tab to the ip address of your remote server.

If the remote is Windows try ipconfig. On Linux, try ip a or ifconfig.

I cant find the BackendURL config.
Where should I change it?

Have you already setup Krita and the Krita plugin? The default tab when first opening the Krita plugin should be the config tab.


make it work on xcode

I found a way to avoid fetch crashing the debug build
Fix BohemianCoding/Sketch#22400
Once merged, don't forget to run npm install to get the new dependencies. In particular, npm ls sketch-polyfill-fetch should return 0.4.5

QAed successfully (https://github.com/BohemianCoding/Sketch/issues/22400#issuecomment-489639437)


to_netcdf() should not implicitly load dask arrays of strings into memory

As discussed in https://github.com/pydata/xarray/pull/2058#discussion_r181606513, we should have an explicit interface of some sort, either via encoding or some new keyword argument to to_netcdf().

Trying to keep us below 1K issues — is this still current?

Yes, this issue refers to the "TODO" note on these lines of code, which is triggered when reading a fixed length string data into a netCDF files:
https://github.com/pydata/xarray/blob/56209bd9a3192e4f1e82c21e5ffcf4c3bacaaae3/xarray/coding/strings.py#L73-L74
encode_string_array() still eagerly loads data into memory.
That said -- this is only the default for netCDF3 files. Most people writing large files and concerned about streaming writes are probably using Zarr these days. So in practice, I'm not sure anyone cares enough to fix this issue.


runtime error for attached RIS file

This RIS file causes a runtime error. The error needs to looked into carefully and understood what is breaking down in our generic implementation to parse the RIS formatted files.
S0010465506001299.txt

A pull request has been created to address this issue. The file actually has an error. The tittle field TI is incorrectly typed as T1. This file was downloaded directly from a journal, so the error is not on our end. However, the tool should handle errors better.


Don't assume memory layout of std::net::SocketAddr

Fixes #1386
This is so far only implemented in the unix implementation. A very similar thing has to be done for the Windows module. But I felt I could get this posted before that to get some feedback.

I was thinking about simply recreating SocketAddr/libc::sockaddr_storage, dropping the use of references to it. This would be especially useful if https://github.com/rust-lang/rust/pull/78802 is merged. I'll take a look at this this weekend.

You mean mio would not use the standard library SocketAddr type? Or you mean this PR should use libc::sockaddr_storage instead of the custom SocketAddrCRepr? The former does not sound good IMO. The intention with https://github.com/rust-lang/rust/pull/78802 was not to split the ecosystem, but rather unify it by allowing it into core etc.

You mean mio would not use the standard library SocketAddr type? Or you mean this PR should use libc::sockaddr_storage instead of the custom SocketAddrCRepr? The former does not sound good IMO. The intention with rust-lang/rust#78802 was not to split the ecosystem, but rather unify it by allowing it into core etc.

No, Mio will continue to use SocketAddr from std lib. Instead I would create libc::sockaddr_in(6) manually from SocketAddr and for accept create SocketAddr from libc::sockaddr_storage (something we already for UDS).

I see. Makes sense :+1:. I will also look more into this in the weekend. I want to submit a PR to socket2 as well since that's a bit blocking for my main PR on the standard library.

I see. Makes sense 👍. I will also look more into this in the weekend. I want to submit a PR to socket2 as well since that's a bit blocking for my main PR on the standard library.

For socket2 make a pr against the v0.3.x branch, master is for v0.4 which is quite a bit away from a release.

Now I have implemented the same for Windows. I might have missed some spot since any place that still just does the casting will just work with the current versions of Rust... That's the danger of that casting, the type system won't catch it.
I will need to get my custom toolchain built on top of https://github.com/rust-lang/rust/pull/78802 on Windows and try out this branch there...

@Thomasdezeeuw Oh... socket2 is a dependency to mio on Windows... So it sounds smoother if we fix it the other way around really. I currently can't build and run mio under my toolchain on Windows. Well I can hack around it with the Cargo [patch] section of course, but anyway, seems a bit backwards.

@Thomasdezeeuw Would you like me to squash the git history a bit, or do you prefer it this way? Either way is fine with me.

I'll squash on merging.

Thanks @faern!

Thank you! I hope we can get this fix published in all relevant versions of mio and socket2 soon :)
I realized I did not add it to the changelog. Will you do that or should I submit a follow up PR?

Thank you! I hope we can get this fix published in all relevant versions of mio and socket2 soon :)

I'll likely release new versions for both next week or so.

I realized I did not add it to the changelog. Will you do that or should I submit a follow up PR?

No I usually update the changelog while preparing for a release.


Fix Publish Workflow

Update publish_release.yml - remove Gradle wrapper validation, as it is not checked in. Add Gradle package caching.

Yes, Success! Check out the packages! Use them as dependencies.


pydantic v2 memory allocation

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Hello all!
First I want to thank you for your contribution to Python by publishing this library!
We currently migrated to Pydantic V2 and experiencing memory issues. I'm not really familiar with memory profiling in Python so excuse me if I have some ignorant questions.
I tried to pinpoint exactly what causes the memory issues and I think it might coming from Pydantic. I created a very simple example where I just create a BaseModel and I get these results using memray.
pydantic 1.10.11:
🥇 Top 5 largest allocating locations (by size):
- _call_with_frames_removed::241 -> 2.008MB
- namedtuple:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/collections/init.py:485 -> 1.001MB
- init:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/typing.py:827 -> 451.841KB
- get_data::1131 -> 245.574KB
- _compile_bytecode::729 -> 103.437KB
pydantic 2.5.3
🥇 Top 5 largest allocating locations (by size):
- validate_core_schema:/Users/antonis.agapiou/Library/Caches/pypoetry/virtualenvs/argos-FVnhZ34m-py3.11/lib/python3.11/site-packages/pydantic/_internal/_core_utils.py:585 -> 17.156MB
- init:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/typing.py:827 -> 8.077MB
- _create_fn:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/dataclasses.py:433 -> 7.064MB
- get_data::1131 -> 3.072MB
- _compile_bytecode::729 -> 2.551MB
Is there a reason why the newer versions allocate 17.156MB ?
Example Code
from pydantic import BaseModel

class Model(BaseModel):
    name: str
    surname: str
    age: int

m = Model(
    name="Antonis",
    surname="Agapiou",
    age=27
)

Python, Pydantic & OS Version
pydantic-core version: 2.14.6
          pydantic-core build: profile=release pgo=true
                 install path: /Users/antonis.agapiou/Library/Caches/pypoetry/virtualenvs/argos-FVnhZ34m-py3.11/lib/python3.11/site-packages/pydantic
               python version: 3.11.1 (main, Jan  9 2023, 18:35:12) [Clang 14.0.0 (clang-14<IP_ADDRESS>)]
                     platform: macOS-14.2.1-arm64-arm-64bit
             related packages: typing_extensions-4.9.0 pyright-1.1.348 mypy-0.991 fastapi-0.109.0 pydantic-settings-2.1.0

Memory usage will probably be significantly reduced by https://github.com/pydantic/pydantic-core/pull/1085.
More detail to come.

@samuelcolvin thanks for the info! Please, is there any ETA for release? We notice the same issue while upgrading our codebase 🙏

@matejkloska the problem is that we need a beta release of PyO3 to build from so that pydantic-core can be packaged by linux distros that build it from source/cargo. @davidhewitt is working hard to get that over the line but since PyO3 is maintained by volunteers, it's hard to but a hard deadline on it. We had originally hoped it would be released in December, then Jan, but I think we're pretty confident of a release in February.
We think the 17MB of memory allocated in _core_utils.py is probably related to the first invocation of Rust code (where Rust has it's own heap), rather than any significant usage in that location.
Is the 17MB of memory usage a problem for you, or are you just looking at the relative usage? Either way, maybe you could provide some more details of your application and we might be able to suggest another fix. That said, I think it's fair to say that Pydantic V2 does have a bigger memory footprint that V1, hopefully we can change that in future.

Hey @samuelcolvin, thanks for your answering so quick. Memory issues are no longer that much big of a deal as we made some refactors to the code  (like decreasing the calls to the .model_json_schema()). It still seems that Pydantic V2 has a higher memory footprint as you said from V1. I did some experimenting using a small subset of our code just to ensure that it does. This is the code I was experimenting with:
import asyncio
import typing

import pydantic

class GenericDataItem(pydantic.BaseModel):
    @classmethod
    def numeric_fields(cls) -> frozenset[str]:
        return cls._build_numeric_fields()

    @classmethod
    def _build_numeric_fields(cls) -> frozenset[str]:
        schema = cls.model_json_schema()["properties"]
        numeric_fields = set()
        for field, attributes in schema.items():
            if "type" in attributes and attributes["type"] in ("number", "integer"):
                numeric_fields.add(field)
            elif "anyOf" in attributes:
                for subfield in attributes["anyOf"]:
                    if "type" in subfield and subfield["type"] in ("number", "integer"):
                        numeric_fields.add(field)
        return frozenset(numeric_fields)

class TestModel1(GenericDataItem):
    numeric_field_1: int | None = None

    @pydantic.field_validator("numeric_field_1", mode="before")
    @classmethod
    def numeric_field_1_to_str(cls, numeric_field_1: str) -> int | None:
        if isinstance(numeric_field_1, str):
            return int(numeric_field_1)

class TestModel2(TestModel1):
    str_field_1: str | None = None

async def _load_test_model_1s() -> typing.AsyncGenerator[TestModel1, None]:
    for i in range(1000):
        yield TestModel1(numeric_field_1=str(i))

async def _load_test_model_2(
    test_model_1s: typing.AsyncGenerator[TestModel1, None],
) -> typing.AsyncGenerator[TestModel2, None]:
    async for test_model_1 in test_model_1s:
        yield TestModel2(str_field_1="string", **test_model_1.model_dump())

async def main() -> None:
    test_model_1s = _load_test_model_1s()
    test_model_2s = _load_test_model_2(test_model_1s)
    async for test_model_2 in test_model_2s:
        _ = test_model_2.numeric_fields()

if __name__ == "__main__":
    asyncio.run(main())

The two versions I compared are 2.5.3 and 1.10.11 with the following changes to the code to be compatible with each version:

.model_json_schema() -> schema()
.model_dump() -> dict()
pydantic.field_validator(mode='before') -> pydantic.validator(pre='True')

These are my results using memray:
memray stats
V1
📏 **Total allocations:**

1673

📦 **Total memory allocated:**

3.361MB

📊 **Histogram of allocation size:**

min: 1.000B

-------------------------------------------

< 4.000B   :  101 ▇▇▇

< 15.000B  :    0

< 63.000B  :    7 ▇

< 255.000B :   91 ▇▇▇

< 1.000KB  : 1088 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇

< 3.999KB  :  272 ▇▇▇▇▇▇▇

< 15.999KB :  108 ▇▇▇

< 63.999KB :    3 ▇

< 255.999KB:    2 ▇

<=1.000MB  :    1 ▇

-------------------------------------------

max: 1.000MB

📂 **Allocator type distribution:**

MALLOC: 955

CALLOC: 551

REALLOC: 166

MMAP: 1

🥇 **Top** **5** **largest allocating locations (by size):**

- _compile_bytecode:<frozen importlib._bootstrap_external>:729 -> 1.101MB

- _call_with_frames_removed:<frozen importlib._bootstrap>:241 -> 1.007MB

- __init__:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/typing.py:827 -> 451.841KB

- get_data:<frozen importlib._bootstrap_external>:1131 -> 245.574KB

- _get_code_from_file:<frozen runpy>:259 -> 214.746KB

🥇 **Top** **5** **largest allocating locations (by number of allocations):**

- _call_with_frames_removed:<frozen importlib._bootstrap>:241 -> 835

- __init__:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/typing.py:827 -> 185

- _get_code_from_file:<frozen runpy>:259 -> 119

- _compile_bytecode:<frozen importlib._bootstrap_external>:729 -> 103

- _parse_sub:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/re/_parser.py:455 -> 63

V2
📏 **Total allocations:**

50094

📦 **Total memory allocated:**

798.913MB

📊 **Histogram of allocation size:**

min: 1.000B

--------------------------------------------

< 4.000B   :  6168 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇

< 15.000B  :  9015 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇

< 63.000B  :  3728 ▇▇▇▇▇▇▇▇▇

< 255.000B :  9175 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇

< 1.000KB  : 10504 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇

< 3.999KB  :  6127 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇

< 15.999KB :  2261 ▇▇▇▇▇▇

< 63.999KB :    59 ▇

< 255.999KB:    38 ▇

<=1.000MB  :  3019 ▇▇▇▇▇▇▇▇

--------------------------------------------

max: 1.000MB

📂 **Allocator type distribution:**

MALLOC: 43856

REALLOC: 3172

CALLOC: 3061

MMAP: 5

🥇 **Top** **5** **largest allocating locations (by size):**

- __init__:/Users/antonis.agapiou/Library/Caches/pypoetry/virtualenvs/argos-FVnhZ34m-py3.11/lib/python3.11/site-packages/pydantic/main.py:164 -> 500.435MB

- model_dump:/Users/antonis.agapiou/Library/Caches/pypoetry/virtualenvs/argos-FVnhZ34m-py3.11/lib/python3.11/site-packages/pydantic/main.py:308 -> 250.000MB

- validate_core_schema:/Users/antonis.agapiou/Library/Caches/pypoetry/virtualenvs/argos-FVnhZ34m-py3.11/lib/python3.11/site-packages/pydantic/_internal/_core_utils.py:585 -> 18.683MB

- __init__:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/typing.py:827 -> 7.077MB

- _create_fn:/Users/antonis.agapiou/.pyenv/versions/3.11.1/lib/python3.11/dataclasses.py:433 -> 6.920MB

memray flamegraph
(they're uploaded as .txt files, you can convert them to .html to see them)
V1
memray-flamegraph-profile_test.py.86248.txt
V2
memray-flamegraph-profile_test.py.86621.txt
As you can see from flamegraphs the memory footprint is a lot higher in V2:
V1

V2

V1  Peak memory usage: 1.5 MiB
V2 Peak memory usage: 14.4 MiB
V1 Total number of allocations: 2853
V2 Total number of allocations: 121961
Again thanks for your quick response and for all the hard work creating this library. Hopefully with the release of PyO3 most of these issues will be solved :D !

Thanks @AntonisAgap for the nice repro.
So already it looks like 2.6.0 might be slightly improved, this is what I see running with pydantic-core main branch:
📏 Total allocations:
        50663

📦 Total memory allocated:
        447.702MB

📊 Histogram of allocation size:
        min: 1.000B
        -------------------------------------------
        < 4.000B   : 7154 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 15.000B  : 7977 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 63.000B  : 3906 ▇▇▇▇▇▇▇▇▇▇▇
        < 255.000B : 7754 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 1.000KB  : 9561 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 3.999KB  : 8146 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 15.999KB : 2176 ▇▇▇▇▇▇
        < 63.999KB :  925 ▇▇▇
        < 255.999KB: 3049 ▇▇▇▇▇▇▇▇
        <=1.000MB  :   15 ▇
        -------------------------------------------
        max: 1.000MB

📂 Allocator type distribution:
         MALLOC: 41741
         CALLOC: 5753
         REALLOC: 3163
         MMAP: 6

🥇 Top 5 largest allocating locations (by size):
        - __init__:/home/david/dev/pydantic/pydantic/pydantic/main.py:171 -> 250.435MB
        - model_dump:/home/david/dev/pydantic/pydantic/pydantic/main.py:314 -> 125.000MB
        - __init__:/home/david/.pyenv/versions/3.12.0/lib/python3.12/typing.py:873 -> 19.140MB
        - validate_core_schema:/home/david/dev/pydantic/pydantic/pydantic/_internal/_core_utils.py:575 -> 18.231MB
        - _create_fn:/home/david/.pyenv/versions/3.12.0/lib/python3.12/dataclasses.py:473 -> 14.865MB

🥇 Top 5 largest allocating locations (by number of allocations):
        - validate_core_schema:/home/david/dev/pydantic/pydantic/pydantic/_internal/_core_utils.py:575 -> 18739
        - sub:/home/david/.pyenv/versions/3.12.0/lib/python3.12/re/__init__.py:186 -> 6333
        - _create_fn:/home/david/.pyenv/versions/3.12.0/lib/python3.12/dataclasses.py:473 -> 6244
        - __init__:/home/david/dev/pydantic/pydantic/pydantic/main.py:171 -> 6000
        - __init__:/home/david/.pyenv/versions/3.12.0/lib/python3.12/typing.py:873 -> 4730

and with the new PyO3, i.e. running the branch in https://github.com/pydantic/pydantic-core/pull/1085
📏 Total allocations:
        57628

📦 Total memory allocated:
        107.216MB

📊 Histogram of allocation size:
        min: 1.000B
        --------------------------------------------
        < 4.000B   :  7816 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 15.000B  :  7997 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 63.000B  :  3932 ▇▇▇▇▇▇▇
        < 255.000B :  7765 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 1.000KB  : 14656 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 3.999KB  : 10202 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 15.999KB :  4002 ▇▇▇▇▇▇▇
        < 63.999KB :  1144 ▇▇
        < 255.999KB:    98 ▇
        <=1.000MB  :    16 ▇
        --------------------------------------------
        max: 1.000MB

📂 Allocator type distribution:
         MALLOC: 41910
         CALLOC: 11090
         REALLOC: 4621
         MMAP: 7

🥇 Top 5 largest allocating locations (by size):
        - _call_with_frames_removed:<frozen importlib._bootstrap>:488 -> 35.697MB
        - __init__:/home/david/.pyenv/versions/3.12.0/lib/python3.12/typing.py:873 -> 19.140MB
        - validate_core_schema:/home/david/dev/pydantic/pydantic/pydantic/_internal/_core_utils.py:575 -> 18.608MB
        - _create_fn:/home/david/.pyenv/versions/3.12.0/lib/python3.12/dataclasses.py:473 -> 13.865MB
        - get_data:<frozen importlib._bootstrap_external>:1186 -> 5.113MB

🥇 Top 5 largest allocating locations (by number of allocations):
        - validate_core_schema:/home/david/dev/pydantic/pydantic/pydantic/_internal/_core_utils.py:575 -> 18749
        - _call_with_frames_removed:<frozen importlib._bootstrap>:488 -> 10456
        - sub:/home/david/.pyenv/versions/3.12.0/lib/python3.12/re/__init__.py:186 -> 6333
        - _create_fn:/home/david/.pyenv/versions/3.12.0/lib/python3.12/dataclasses.py:473 -> 6243
        - __init__:/home/david/.pyenv/versions/3.12.0/lib/python3.12/typing.py:873 -> 4730

The number of allocations hasn't gone down significantly, which might be interesting to investigate sometime, but the big win to come is in MBs allocated; 448 -> 107, so that's cutting the memory usage by something like a factor of 4.
The even better news is that once we've cut that big chunk away then I'm sure it'll be easier for us to start working through to identify and eliminate other sources of allocations.
So in summary, it looks like Pydantic 2.7 might be significantly better here and who knows where we can get to for 2.8 and beyond 🚀

This is amazing 🤩, I'm really looking forward to 2.7.

That's awesome! Looking forward to 2.7 as well! Thanks for the info and the hard work 😄!

we're definitely looking forward to this as well !

Now that the PyO3 work is done, retesting on pydantic main I get the following:
📏 Total allocations:
        52488

📦 Total memory allocated:
        61.289MB

📊 Histogram of allocation size:
        min: 1.000B
        --------------------------------------------
        < 4.000B   :  6174 ▇▇▇▇▇▇▇▇▇▇▇▇
        < 15.000B  :  8024 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 63.000B  :  3559 ▇▇▇▇▇▇▇
        < 255.000B : 10153 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 1.000KB  : 13524 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 3.999KB  :  8595 ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇
        < 15.999KB :  2300 ▇▇▇▇▇
        < 63.999KB :   108 ▇
        < 255.999KB:    37 ▇
        <=1.000MB  :    14 ▇
        --------------------------------------------
        max: 1.000MB

📂 Allocator type distribution:
         MALLOC: 45734
         CALLOC: 3447
         REALLOC: 3300
         MMAP: 7

🥇 Top 5 largest allocating locations (by size):
        - validate_core_schema:/Users/david/Dev/pydantic/pydantic/pydantic/_internal/_core_utils.py:568 -> 18.260MB
        - __init__:/opt/homebrew/Cellar/python@3.11/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/typing.py:864 -> 8.184MB
        - _create_fn:/opt/homebrew/Cellar/python@3.11/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/dataclasses.py:433 -> 6.737MB
        - _get_schema:/Users/david/Dev/pydantic/pydantic/pydantic/type_adapter.py:78 -> 6.226MB
        - get_data:<frozen importlib._bootstrap_external>:1131 -> 4.836MB

🥇 Top 5 largest allocating locations (by number of allocations):
        - validate_core_schema:/Users/david/Dev/pydantic/pydantic/pydantic/_internal/_core_utils.py:568 -> 22812
        - sub:/opt/homebrew/Cellar/python@3.11/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/re/__init__.py:185 -> 6326
        - _create_fn:/opt/homebrew/Cellar/python@3.11/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/dataclasses.py:433 -> 4124
        - __init__:/Users/david/Dev/pydantic/pydantic/pydantic/main.py:175 -> 4000
        - __init__:/opt/homebrew/Cellar/python@3.11/3.11.8/Frameworks/Python.framework/Versions/3.11/lib/python3.11/typing.py:864 -> 3016

Testing on macOS instead of linux, so the comparison may not be directly applicable. But it does look like we've made significant progress at reducing allocations and it'll be interesting to see if we can get further on this 🚀

That is great news, awesome work!

Maybe a good example for optimization:
# generate V1 models:
datamodel-codegen --url https://github.com/kubernetes/kubernetes/raw/master/api/openapi-spec/swagger.json  > k8s_v1.py

# generate V2 models:
datamodel-codegen --url https://github.com/kubernetes/kubernetes/raw/master/api/openapi-spec/swagger.json  --output-model-type=pydantic_v2.BaseModel > k8s_v2.py

I did the following in 2 separate processes:
> import k8s_v1
> import k8s_v2

Are there any more big wins here? The memory usage and CPU usage is still preventing us from upgrading our app from Pydantic v1 -> v2.

I just want to chip inn and confirm memory usage increased when i upgraded from Pydantic 1.x to 2.7.x. I forgot to note down my test numbers. But my google app engine instance went from something like 350mb -> 420mb memory used on first page load. I still decided to go for the upgrade, but it is a bit worrying.
Especially worrying since reloading the page several times jumps memory usage up as well. Did for both 1.x to 2.7.x so i cant confirm it is a memory leech in pydantic 2.7, or that its not gc eventually. I might have a memory leech in other parts of my code.

I did some basic profiling over huge RAM allocation by pydantic 2 here: https://github.com/pylakey/aiotdlib/issues/135

I did some basic profiling over huge RAM allocation by pydantic 2 here: pylakey/aiotdlib#135

I don't think they are looking at this issue anymore (no new replies to any of our feedback since March) , maybe it worth creating a new ticket.

datamodel-codegen --url https://github.com/kubernetes/kubernetes/raw/master/api/openapi-spec/swagger.json  --output-model-type=pydantic_v2.BaseModel > k8s_v2.py

This is a significant issue I've noticed. I have seen services with fairly large API schema documents (20-30k line OpenAPI files) running on AWS Lambda that use generated pydantic models, generated from from  datamodel-codegen. The upgrade from Pydantic v1 to v2 increased the lambda cold-start time from 2-3 seconds to 20-30 seconds, just like your CPU time shows when benchmarking the kubernetes API models. The memory leak improvements have been great, but this is still a major problem that really affects ephemeral compute models like Lambda, where new execution environments are spun up on the fly and things aren't cached, so imports have to be reloaded.
I profiled the kubernetes import k8s_v2  statement below

These functions seem to be the major bottlenecks in terms of time
https://github.com/pydantic/pydantic/blob/d654a0766c2f3c6fe0a12718f32aa3bf4d3ecc86/pydantic/_internal/_model_construction.py#L661
https://github.com/pydantic/pydantic/blob/d654a0766c2f3c6fe0a12718f32aa3bf4d3ecc86/pydantic/_internal/_model_construction.py#L681

Working on this now, hoping to roll out a fix in v2.9 at the end of the month!

Hey folks - I've addressed this via https://github.com/pydantic/pydantic/pull/10113 as well. Let me know what sort of improvements you get with local testing!

Amazing work @sydney-runkle, thank you so much.

Not seeing any improvement upgrading from v2.8.2 to v2.9.0. The benchmark linked to in https://github.com/pydantic/pydantic/issues/9982 concurs with my testing, though my code only uses dozens of models with average complexity.

Same here, seeing the exact same memory usage with 2.8.2 and 2.9.0.

@9ao9ai9ar @Andrioden, interesting. Could you please provide some references to your code, or a MRO so that we can do some more profiling + work on some improvements?
Thanks for following up!


Azure bicep examples

It would be helpful to have some examples with Azure bicep.
Specifically, I'm interested in the assignment of a managed certificate.
Thank you

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d02a5991-da24-06a2-0c24-d012d2e07399
Version Independent ID: 64acd893-43bb-81af-d14d-0b7553e93daf
Content: Configure custom domain name for Azure API Management instance - Azure API Management
Content Source: articles/api-management/configure-custom-domain.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@fleed
Thanks for your feedback! We will investigate and update as appropriate.

cc: @mumurug-MSFT @dlepow

@fleed - Thanks for reaching out. To use the managed certificate, add the Builtin type of certificateSource in the service HostnameConfiguration.
I don't know of a complete published example, but you could adapt the published bicep example. Let us know if that helps?

@fleed - Since we haven't heard back, I'll proceed to close the issue. If you want to continue the conversation, feel free to open another issue, or you can ask questions at Microsoft Q&A.
#please-close


Add contributing docs

:tada: This PR is included in version 3.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Include original clock and feeds in history() elements etc

Writer._decode converts results taken from the database before being passed to the user.  The vector clock entries are rearranged to match the local feed list.  (It looks like the trie is altered as well although I'm not familiar with the trie yet)
It would be nice for the original, remote vector clock to be available in the result, in case the clock was used for anything (I'm using it to hash the feed tips together).  For this to be useful, the remote feeds could be returned too (which I guess means passing them via _encodeMap).
Something like this perhaps:
diff --git a/index.js b/index.js
index bfd9c46..f84e084 100644
--- a/index.js
+++ b/index.js
@@ -748,6 +748,10 @@ Writer.prototype._decode = function (seq, buf, cb) {
   val.path = hash(val.key, true)
   val.value = val.value && this._db._valueEncoding.decode(val.value)

+  val.rawClock = val.clock
+  val.rawTrie = val.trie
+  val.rawFeeds = this._mapList(this._db.feeds, this._encodeMap, null)
+
   if (this._feedsMessage && this._feedsLoaded === val.inflate) {
     this._maybeUpdateFeeds()
     val.feed = this._id

Either that or we expose a method do denormalize. I'm fine either way :)


fix(test): webhook entrypoint integration test is requesting a wiremock which is never responding

Description
We have a flaky test in Webhook entrypoint integration test
https://app.circleci.com/pipelines/github/gravitee-io/gravitee-api-management/12283/workflows/1fc79d25-9c3a-4b16-831e-b2cb5270f152/jobs/171183/parallel-runs/0/steps/0-106
This PR aims to confirm the theory in which the cause is the fact we never configure wiremock with a valid stub for valid request. meaning the request never ends properly.

🚀 CI was able to deploy the build of this PR, so you can now try it directly here
Notes: The deployed app is linked to the management API of APIM master. (Same login and password as APIM master)

📚  View the storybook of this branch here

@ytvnr Could we merge this one?

@guillaumelamirand no, because it did not solve the problem
only few commits are relevant but that will not fix the flaky


[IC3 ACS Email] API Review

New API Review meeting has been requested.
Service Name: IC3 ACS Email
Review Created By: Jorge Garcia Hirota
Review Date: 3/30/2023 4:00 PM PT
PR: https://github.com/Azure/azure-rest-api-specs/pull/22979
Hero Scenarios Link: here
Core Concepts Doc Link: Not Provided
Description: GA of Email service
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here

Cancelled by: Jorge Garcia Hirota


Remove an unused typedef

Can one of the admins verify this patch?

I signed it!

Jenkins, test this please.


Component: Mega Menu - Clicking on menu options, links seem to vibrate(shift there position).

Detailed description
On Windows - Firefox & chrome
Issue:

On Mega menu, clicking on menu options, links seem to vibrate(shift there position).
On few menu options, grey scroll is displayed. here scroll is not needed. Ex - "Explore more & COVID-19"

Note: On Mac - safari, chrome & Firefox above issue does not exist.
Additional information

@RobertaJHahn @Praveen-sr This has been fixed in https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/4417
See http://ibmdotcom-react-canary.mybluemix.net/?path=/story/components-masthead--default


[cluster-test] break down cluster test runner timeframe

Add time breakdown into suite test report and changelog
Motivation
(Write your motivation for proposed changes here.)
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
./scripts/cti --pr 7735 --suite perf
Before:
all up : 926 TPS, 4902 ms latency, 5600 ms p99 latency, no expired txns
10% down : 894 TPS, 4563 ms latency, 7650 ms p99 latency, no expired txns
3 Region Simulation : 733 TPS, 6209 ms latency, 7850 ms p99 latency, no expired txns
fixed tps 10 : 10 TPS, 924 ms latency, 1200 ms p99 latency, no expired txns

After:
Test runner setup time spent 298 secs
all up : 910 TPS, 4994 ms latency, 5700 ms p99 latency, no expired txns
Time spent 274 secs
10% down : 887 TPS, 4610 ms latency, 6500 ms p99 latency, no expired txns
Time spent 419 secs
3 Region Simulation : 724 TPS, 6305 ms latency, 7800 ms p99 latency, no expired txns
Time spent 267 secs
fixed tps 10 : 10 TPS, 913 ms latency, 1000 ms p99 latency, no expired txns
Time spent 248 secs

(Share your test plan here. If you changed code, please provide us with clear instructions for verifying that your changes work.)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/diem/diem/tree/master/developers.diem.com, and link to your PR here.)

/land


Fix implicit fallthrough warning on GCC

More info: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
The comment is inspired by C++17's [[fallthrough]] attribute (https://en.cppreference.com/w/cpp/language/attributes/fallthrough).

https://github.com/Azure/azure-sdk-for-c/pull/75 approach is better


health and metrics endpoint for vLLM api server

Does vLLM api server expose health and metrics endpoints like TGI does?

Both of these endpoints have been added.


Missing stats for a game

I know the game I'm going to say could be laughable, but I got it for very cheap and it annoys me that has missing hltb stats, even if there are on the site. It's Disney Epic Mickey 2.
Maybe, stats are missing because on HLTB is called "Epic Mickey 2: The Power of Two". I don't know.

I know the game I'm going to say could be laughable, but I got it for very cheap and it annoys me that has missing hltb stats, even if there are on the site. It's Disney Epic Mickey 2. Maybe, stats are missing because on HLTB is called "Epic Mickey 2: The Power of Two". I don't know.

Same thing happens with the game Spiritfarer Farewell Edition. Don't really know if there is a way to fix this though.


The link to the code example is dead

@joh397 commented on Mon Jul 22 2019
The link to the example code (https://go.microsoft.com/fwlink/?LinkID=159996) is dead.
The link can be found in the last sentence of the first paragraph.

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: a377bf0b-fc73-2df8-e2b8-a8d1e0f688fb
Version Independent ID: 7fc5b667-3df0-8d10-93fe-294218fc5135
Content: Exemplarische Vorgehensweise: Hosten eines zusammengesetzten WPF-Steuerelements in Windows Forms
Content Source: docs/framework/wpf/advanced/walkthrough-hosting-a-wpf-composite-control-in-windows-forms.md
Product: dotnet-framework
Technology: dotnet-wpf
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

@srvbpigh commented on Mon Jul 22 2019
Hello, @joh397
Thank you for your feedback.
We are actively reviewing your comments and will get back to you soon.
Kind regards,
Microsoft DOCS International Team

Hi team,
I moved this here because the reported link doesn't work in the en-us page either

kind regards

Thank you for opening this issue. I'll get this fixed up.
The sample you're looking for is here: https://github.com/microsoft/WPF-Samples/blob/master/Migration and Interoperability/WpfHostingWindowsFormsControl/FormsControlLibrary/MyControl.cs
Thanks again!

I've fixed the FwLink to go to the right sample and also created a PR to fix the title of that sample at https://github.com/microsoft/WPF-Samples/pull/97


docs: clarify directory defaults and environment variables

There are a few questions (#777, #644 , and no doubt a few others) that stem from the confusion of default directories (particularly on mac) and how to set custom destinations.
This documentation addition hopefully clears that up sufficiently.

@denisidoro ?
This pr could well mitigate a lot of recurrent user issues.


Fix duplication of RetrieveRequest reference in entity-operations-ret…

@mmanou
Thanks for catching and fixing this.


control module

Not sure what this will include.
First will be a service status method, send out a control message for all services to respond, keep track of what services respond when.
Plan to write a ping request that will track what has responded and formulate a reply based on that.
Can also use as a testing controller, send test messages to services to make sure they respond as expected

another feature, along with testing, a watchdog that alerts when messages are malformed (ie, missing a transaction id or service)

along with a ping, report version

this is built into the api server
also have a watchdog service that can track messages that the clients send to report uptime or disappearance - watchdog is started, but not fully implemented yet


Location of custom visual source code in GitHub

Hi - Can you let me know if the source code is also available for PowerBI's standard visuals? This would be useful to use as a template when I am developing custom visuals. Can you please also provide a link to the custom visual source code referenced in this article located within GitHub?
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5c4bae6e-72e1-e41c-4419-48a56423e81e
Version Independent ID: 6d864495-b578-2d28-169d-edb5409de943
Content: Developing a Power BI Custom Visual - Power BI
Content Source: powerbi-docs/developer/custom-visual-develop-tutorial.md
Service: powerbi
GitHub Login: @markingmyname
Microsoft Alias: maghan

@markingmyname , when I tried to run the project in the github link you provided, it throws error.

I manually installed the required peer dependencies and did npm start again. It throws

Kindly help me to get rid of this.


Match CRD files in istio/istio

ref: https://github.com/istio/istio/pull/18340

@jasonwzm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_installer
9c0e8bb60f939e8489b7f3ed0d89dfb993673ee1
link
/test gencheck_installer

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


tailwind responsivity not working as expected

tailwind breakpoints not functioning as expected with text sizes
appears to be over-ridden by largest size class present in element

appears to affect breakpoints across the board

not quite. width sizing is responsive. text no. border properties no. grid properties no.

justifying content also works responsively

Can you give me some screenshots of this as I can't work out what you mean

Will see if this is a consequence of my layout, or if I can fix it regardless with a different layout.

fixed in b317006


Longhorn system backup runs weekly

apiVersion: longhorn.io/v1beta2
kind: SystemBackup
metadata:
name: demo-backup
namespace: longhorn-system
spec:
volumeBackupPolicy: if-not-present
hello guys, can you help me to  run this SystemBackup job weekly.

Please follow up https://github.com/longhorn/longhorn/issues/6534


Add support for Geo-spatial queries

This PR is adding support for Geo-spatial queries. Core doesn't have a specific geo-type (yet), so this is just the first version which relies on duck-typing.
This means that geo queries can be used on any embedded objects that has a type and coordinates property.
This also has the implication that it is slightly awkward to to pass in geo-parameters. The current implementation overrides the toString() method which will format the data structures so they can be used from within a query.
TODO

[x] Documentation
[x] Figure out how many tests we need?
[x] There is a chance that Core allow String arguments to be converted to geo-spatial arguments. Check with them about this.

I reworked the API based on our discussions. It should be ready for another round of review.


Normalize ids before looking up in named export map

This fixes an issue frequently hit when using the typescript rollup plugin. Because TypeScript always returns posix paths, but node resolve will normalize on a per-platform basis, comparisons must be carried out on normalized forms. This PR fixes some missing normalization and obviates rollup-plugin-typescript2's rollupCommonJSResolveHack option (/cc @ezolenko), and fixes #177 and probably a few others as well.

Ok, I need a better way to test this on Linux. I guess paths on linux must always be posix paths else things break.

I'd recommend stealing the CI config from rollup/rollup. We made some pretty solid containers that it uses.

Ok, I need a better way to test this on Linux. I guess paths on linux must always be posix paths else things break

Definitely, see my comment.

@lukastaegert the latter approach seemed best actually. I've also updated the comments to be more clear, see if you like them now 😀

Would this be a breaking change or a bug fix?

Thanks, then I'll make it a minor.


Fix theme for Mesh menu

Fix #14583

Does this mean non-Control nodes breaks Theme inheritance? Is this intended?

@Noshyaar I'm not sure but I guess so.

<Noshyaar> Is it intended that non-Control nodes break Theme inheritance?
<reduz> Noshyaar: oh very possibly
<reduz> Noshyaar: should probably be fixed

I think it'd be better to make it inherits Theme properly so that the issue won't happen again.

@Noshyaar as you know, it needs to dig deeper.
what about creating another issue for it?

ok, I tested it with Node2D instead of Control.
and it works as expected also.
so, theme is inherited with CanvasItem (Node2D, Control) but not Node


mWeb - Connect bank - Error page loaded after select any field on the Company Information page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com and sign in with new applause.expensifail account
Select to Create a New Workspace at Global Create Menu
Enable staging Web secure server in Account Preferences
Navigate to Workspace editor page and select Connect bank account
Select Connect online option
Select Wells Fargo and enter test credentials (user_good/pass_good)
Choose the savings account "Plaid Saving11122XXXXXX111" and select Continue
Select any text field on the Company Information page

Expected Result:
Able to proceed with VBA flow after select any text field on the Company Information page
Actual Result:
Unknown
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:

Where is this issue occurring?

Mobile Web

Version Number: 1.1.39-1
Reproducible in staging?: Yes
Reproducible in production?: Can not check the VBA flow in Production
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/154294990-faed6424-5532-42c9-b4bb-bee171e2d4de.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

It is a possible regression from my PR https://github.com/Expensify/App/pull/7318. I am trying to fix it https://github.com/Expensify/App/issues/7769. I will share update in an hour.


No access to context from remote

Say I define a function
function Foo(arg1, arg2)
  let b = a:arg1.' '.a:arg2
  let c = 5
endfunction

you source it
gg"zyG
:exec @z

and define a breakpoint on it
breaka func Foo

after run it
call Foo('Hello', 'World')

when you are debugging line 2 (next) let c=
you can ask about b value
echo b
Hello World
but if you run vim with --servername myserver
calling from another vim instance
call remote_expr('MYSERVER', 'echo b')

returns
E449 Invalid expression

this is because when calling remote_expr local context is not loaded
https://github.com/vim/vim/blob/2a6a6c3014e728cd01c750b0f60484d4eaf22a8c/src/eval.c#L7429
meanwhile from local debug session it is loaded
Is this on purpose? can local var mapping be populated for remote execution.
I feel this is changing from vim 7.4. My plan is to compile vim 7.4 and check if that works then (I guess because I have a plugin for remote debug that use to work)

Confirmed: Using vim 7.4 I can ask from remote about every variable:
call remote_expr('MYSERVER', 'echo a:arg1')
call remote_expr('MYSERVER', 'echo a:arg2')
call remote_expr('MYSERVER', 'echo b')
@chrisbra (sorry to ping) is this unexpected? is on purpose?

I would say this is unexpected. Can you find which commit broke it or even better propose a patch?

Alberto Fanjul wrote:

Say I define a function
function Foo(arg1, arg2)
  let b = a:arg1.' '.a:arg2
  let c = 5
endfunction

you source it
gg"zyG
:exec @z

and define a breakpoint on it
breaka func Foo

after run it
call Foo('Hello', 'World')

when you are debugging line 2 (next) let c=
you can ask about b value
echo b
Hello World
but if you run vim with --servername myserver
calling from another vim instance
call remote_expr('MYSERVER', 'echo b')

returns
E449 Invalid expression

this is because when calling remote_expr local context is not loaded
https://github.com/vim/vim/blob/2a6a6c3014e728cd01c750b0f60484d4eaf22a8c/src/eval.c#L7429
meanwhile from local debug session it is loaded
Is this on purpose? can local var mapping be populated for remote execution.
I feel this is changing from vim 7.4. My plan is to compile vim 7.4
and check if that works then (I guess because I have a plugin for
remote debug that use to work)

It has been like this for a while.  Evaluating function-local variables
was considered a bug. eval_client_expr_to_string() calls
clear_current_funccal().
Debugging is a special case that was not considered.  Perhaps in debug
state clear_current_funccal() could be skipped.
--
BLACK KNIGHT:  I move for no man.

BLACK KNIGHT:  'Tis but a scratch.
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

comparing last v7.4 tag (v7.4.2367) with master I found that function free_all_functions() adds a loop
https://github.com/vim/vim/blob/master/src/userfunc.c#L1166
@@ -1120,10 +1156,47 @@ free_all_functions(void)
     hashitem_T *hi;
     ufunc_T    *fp;
     long_u     skipped = 0;
-    long_u     todo;
+    long_u     todo = 1;
+    long_u     used;
+
+    /* Clean up the call stack. */
+    while (current_funccal != NULL)
+    {
+       clear_tv(current_funccal->rettv);
+       cleanup_function_call(current_funccal);
+    }

that ends with current_funccal as NULL
I guess that's the change that modifies the behaviour. Should I provide a PR with check around it if there's an ongoing debug session? Don't know if it is that simple

Should I provide a PR with check around it if there's an ongoing debug session? Don't know if it is that simple

Sure, patches are appreciated, especially if they contain a test case.

I think I can add something to https://github.com/vim/vim/blob/master/src/testdir/test_clientserver.vim
Is the only use case I now about this

Is there any recommended way to compile for debug? I don't have debug symbols and don't know if it is from package manager or from compilation itself
I use this instructions
configure https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/vim#n68
make https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/vim#n86
make install https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/vim#n192
I added options=(debug !strip) to avoid stripping and keep debug symbols (specific for arch linux distro)
I know I can add CFLAGS='-ggdb -O0' but if is there any configure option or recommended make option please let me know

I am using those switches:
https://github.com/chrisbra/vim/commit/78740807655cece3b0ee62495d9b23d6fc8fdb56

Ok, I have an initial patch.
Working on test case, maybe today later

I was editing comments, because some commands were wrong
I have reworked the use case
function! Bar(argBar1, argBar2)
  let c = 6
  return a:argBar1.' '.a:argBar2
endfunction

function! Foo(argFoo1, argFoo2)
  let c = 5
  let b = Bar(a:argFoo1, a:argFoo2)
  echo b.' '.c
endfunction

and it works correctly with up and down backtrace commands. So I will add that to test case and submit a PR


update docs

Codecov Report

Merging #30 (5f0fcfd) into main (23be385) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   42.46%   42.46%
=======================================
  Files          13       13
  Lines         617      617
=======================================
  Hits          262      262
  Misses        355      355

Impacted Files
Coverage Δ

src/spatialdata_io/readers/cosmx.py
19.08% <ø> (ø)

src/spatialdata_io/readers/visium.py
33.33% <ø> (ø)

src/spatialdata_io/_constants/_enum.py
68.29% <100.00%> (ø)


Could not initialize the instance variable in the block in '#initialize' method.

Environment:
$ uname -a
Darwin ***** 17.0.0 Darwin Kernel Version 17.0.0: Thu Aug 24 21:48:19 PDT 2017; root:xnu-4570.1.46~2/RELEASE_X86_64 x86_64
$ crystal -v
Crystal 0.23.1 (2017-09-18) LLVM 4.0.1

Reproducible code:
class A
  @b : String

  def initialize
    1.times { @b = "c" }
  end
end

A.new

Results:
$ crystal run sample.cr
Error in sample.cr:9: instantiating 'A:Class#new()'

A.new
  ^~~

instance variable '@b' of A must be String, not Nil

Error: instance variable '@b' was used before it was initialized in one of the 'initialize' methods, rendering it nilable

Even when the instance variable is initialized outside of the #initialize, same error will occur.
Ex:
class A
  @b = ""

  def initialize
    1.times { @b = "c" }
  end
end

A.new

Is this the normal behavior?

Looks similar to #4147, related to #1687


Forecast rebase

Description
rebase commit https://github.com/opensearch-project/anomaly-detection/pull/871 and https://github.com/opensearch-project/anomaly-detection/pull/886 from main on top of forecast feature branch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

bwc tests and security tests failed due to same reason mentioned in https://github.com/opensearch-project/anomaly-detection/pull/886


Added first-pass declaration file for Typescript.

This PR partially addresses #192. I have scanned the Slack and core pieces of botkit for necessary declaration matter and I wanted to get a discussion going around including this. Bundling the declaration file makes use with TypeScript much easier than going through DefinitelyTyped, so hopefully I can get some feedback on this from people and maybe make some progress on the not-Slack parts of the codebase.

This looks great, one of the only things that was putting me off from using BotKit was the lack of TypeScript declarations - I still use it but I ended up writing something similar but a lot more lightweight than this. I really hope this gets officially included soon! 👍

is there any reason why this is not included?

News about this? How can we help

I'm definitely very interested in this being included.

@aaronsky can you update the PR with the changes mentioned by @indierojo ? Or shall I clone your repo and make another PR?

This PR was superseded by #953, please close it.


[TE7-K32W0] Fix BLE commissioning failure

Problem

DUT refused the send the PBKDF param response due to insufficient
memory on the BLE Host side.

Change overview
The fix is to increase the memory pool.
Testing
How was this tested? (at least one bullet point required)

tested using chip-device-ctrl

The PR needs to be cherry-picked also to the master branch once approved and merged.

Closing this and opening https://github.com/project-chip/connectedhomeip/pull/11910 which is targeted for the correct branch: TE7 LTS.

Closing this and opening https://github.com/project-chip/connectedhomeip/pull/11910 which is targeted for the correct branch: TE7 LTS.


feat(cli): add version variable so that tools such as goreleaser can leverage it

Add this to the generated companion cli code:
var version = "unstable"

This will allow consumers of operator-builder to use their own tooling to substitute the version when building the CLI.
DISCLAIMER: deferring to @JefeDavis for the implementation of this.  The goal would be to have the CLI that the user creates be able to spit out its own specific version.  Details above may be incorrect.

A good example of this has already been written, using the operator-builder pattern and is at https://github.com/vmware-tanzu-labs/namespace-operator/blob/master/cmd/tanzu-ns-ctl/commands/version.go


Missing branches

1 7 7 9
Unable to find solutions for 2 and 3. Here are example solutions for them:
2 = (7 + 9) / (7 + 1)
3 = (7 - 1) / (9 - 7)

Fixed via 0604b6ede6fe058de98b9dace2f83bbe623d9ead


Implemented map.panInside() to bring a target latlng into view

Brings a target latlng into view, moving the map the minimum amount to make it visible. Implements feature request #6029 .
An optional padding parameter (suggested by @jbccollins) is provided to control the desired distance away from the display edge.
If the target is already in the (optionally padded) display bounds, the map will not be panned.

I also considered an optional bounds parameter, instead of the padding one. This would allow for the pan to be constrained differently on each border, e.g. more padding at the top for marker display or to avoid UI overlays. I'm happy to implement that instead if it's preferable to the padding parameter which applies a consistent border to each edge.

Thanks for the review, @IvanSanchez. I'll update the function to accept options including paddingTopLeft and paddingBottomRight, or just padding for equal padding on all edges.
I'm still getting used to the code, so sorry about the use of the global L. I'll get that updated, too.

@daverayment sorry for taking a loooong time to merge this, I guess this slipped under the radar of maintainers other than @IvanSanchez.
I looked throught it, it looks good and I guess Ivan has already checked the details in his review :slightly_smiling_face:
Anyway, good work, thank! :+1:

This only pans in the x direction...
version: 1.7.1, browser: Firefox, OS: Ubuntu
This is the code I used:

	<link rel="stylesheet"<EMAIL_ADDRESS>

Steps to reproduce: move the view over and down to somewhere like India or Saudi Arabia. Click on the map. It only pans in the x direction.

@t3539 Please open a new bug report with this info. It's generally considered bad practice to comment to an old and closed issue.


Generating addrFromPrivateKey lemmas for missing ecdsaPubKey hook

Because of ECDSAPubKey not being implemented on concrete inputs for the Haskell backend, we cannot rely on it being present when writing Foundry property tests (see: https://github.com/runtimeverification/haskell-backend/issues/3573).
But it's not uncommon to supply a random private key in a property test, then use vm.addr(...) cheatcode to turn said private key into an ethereum address that can be used. This pattern is especially used with contracts where signatures are checked onchain.
To get around this https://github.com/runtimeverification/evm-semantics/pull/1766 allows us to write lemmas directly for the addresses needed in the tests. Given a private key KEY (encoded in hex, for example: 0x2b8ba85ff7f2c7fa62cddb20ae40ef2553b9fdbff086f60d1647ecaab15af867), and the associated Etherem address ADDR (encoded as a decimal integer, for example:<PHONE_NUMBER>628904891128108629487072145087352593841), you can add the following K lemma to your lemmas.k for a project to help the Haskell backend reason about that case:
rule #addrFromPrivateKey(KEY) => ADDR [priority(40)]

So, given KEY, how do you figure out the correct ADDR?
First, install ganache-cli:
npm install -g ganache-cli

Then run, in one terminal, ganache-cli:
ganache-cli

Wait for it to start up, then in a file called ganache.in, put the following contents:
{
  "jsonrpc": "2.0",
  "id": 1,
  "method": "personal_importRawKey",
  "params": ["KEY", "0x"]
}

Then, in another terminal, run the following command to send this request to ganache-cli:
curl -s -X POST 'http://<IP_ADDRESS>:8545' --data @ganache.in -H "Content-Type: application/json"

It will output a response that looks like this:
{"id":1,"jsonrpc":"2.0","result":"HEX_ADDR"}

Take the HEX_ADDR, and put it in this website to convert it to decimal: https://www.rapidtables.com/convert/number/hex-to-decimal.html, which gives you ADDR, so that you can make your lemma!

Merged this issue with the one that describes the missing ECDSA hook problem https://github.com/runtimeverification/haskell-backend/issues/3573.

Merged this issue with the one that describes the missing ECDSA hook problem https://github.com/runtimeverification/haskell-backend/issues/3573.


Tests failing with 401 for Google credentials

Google credentials need to be updated for Travis. Hopefully this will fix failing tests.
┆Issue is synchronized with this JIRA Story
┆Project Name: CGP-Data Loader
┆Issue Number: LOAD-43

Increasing permissions for travis credentials fixed this, but a better solution is to set up special test buckets with varying levels of permissions to make sure access rejection / acceptance works as expected.

➤ Jesse Brennan commented:
This works as configured, and upon review, no changes seem necessary at this point.


ionic 4 app.module.ts import MobileOCR not working Solution found

Hello Community,
Issue:
Recently I used mobile ocr plugin in ionic 4
There is mistake in documentation:
import { MobileOCR } from '@ionic-native/ocr/ngx';
This MobileOCR should not be imported
Solution:
change
From: import { MobileOCR } from '@ionic-native/ocr/ngx';
To: import { OCR } from '@ionic-native/ocr/ngx';
This will work perfectly
hope so documentation will update and dev will use from MobileOCR to OCR

Hey @badalpatel6534
Thanks a lot for bringing this to the community's attention. I will pin this issue to the top and close it.
Cheers and have a nice day :)
Chris
Neutrinos


Add Minetweaker Compatibility:

Currently, the cooking book and related GUIs allow you to view (and even craft using) recipes that no longer exist after having been altered with MineTweaker.
To reproduce:
Use this minetweaker script:
recipes.remove(minecraft:bread);
recipes.addShapeless(minecraft:bread, [minecraft:dirt]);
You can verify it works by turning dirt into bread using the crafting grid in your inventory.
Open a cooking for blockheads book. Give yourself a dirt. It will not tell you that you can craft bread. Give yourself three wheat. It will tell you that you can make bread. With volume 2 open, you can even craft bread with the non-existent ingredients.
It would be awesome for modpack makers if this were fixed.

In order to fix this correctly I will need the above mentioned PostReloadEvent from MineTweaker's side, but for now I've made the mod reload its food recipe cache on world load (so after MineTweaker changes are applied) if MineTweaker is installed.
Note that changes applied using the MineTweaker /mt reload command won't be available to the cooking book/table until the world was re-loaded.

Do you still want the event in MT?

@jaredlll08 Yes.

You guys are terrific for doing this. Thanks again.
On Tue, Sep 1, 2015 at 7:45 AM, Christopher Baker<EMAIL_ADDRESS>wrote:

@jaredlll08 https://github.com/jaredlll08 Yes.
—
Reply to this email directly or view it on GitHub
https://github.com/blay09/CookingForBlockheads/issues/48#issuecomment-136727375
.


Edge detection node (for studio)

Node PR: https://github.com/flojoy-io/nodes/pull/75
Docs PR: TODO

Use this URL to access Flojo-studio
http://<IP_ADDRESS>:3000
http://514.flojoy-test.com:3000 (comming soon)
The instance will shutdown after one hour.
If you want to start the instance after that use this API :
https://kgpsoscpc4q52d4mtwuu7jhvie0qdiso.lambda-url.us-east-1.on.aws/start_instance?instance_id=i-0eb94b402f6bbcfa0


Maven/Gradle wrapper modules

Currently, even the MAVEN_JAVA module install the maven wrapper, which IMHO incorrect, as it is impossible to create a project, without those wrapper. The Maven/Gradle wrapper doesn't make sense, without Maven/Gradle, so some sort of relations makes sense.
Having totally independent MAVEN_WRAPPER and MAVEN_JAVA module only makes sense, if someone would want to use on a project, which not initialized with JHipster-Lite previously. This is I think, currently more of a lucky bug, that it is works, and not a feature - One could say that they want to use SPRING_BOOT_PULSAR without running the SPRING_BOOT module.
I think, adding some sort of an auto-detection feature, could make sense - so for example, MAVEN_JAVA module could say, that whenever there is a 'pom.xml' file in the root of the project, consider MAVEN_JAVA is installed. That would enable a couple of scenarios to work - even though, not every one.
I can see, two possible way to improve the MAVEN_JAVA/MAVEN_WRAPPER setup:

Either there should be only one MAVEN module, with a flag, to install the wrapper or not
Those should be two separate modules, fixing the logic, to only install the wrapper, if MAVEN_WRAPPER is explicitly requested.

This is probably one of the hardest part of JHipster Lite, to know the limit of what to generate and not to generate :)
About your comment

Having totally independent MAVEN_WRAPPER and MAVEN_JAVA module only makes sense, if someone would want to use on a project, which not initialized with JHipster-Lite previously

It's ok as the maven-wrapper is still usable directly using the Patches page:

So if I understand well your suggestions, I would say:

let's keep 2 distinct modules, it's easier to maintain than using a flag in config
maven-java should only generate pom.xml, and not the maven-wrapper any more --> need another PR
maven-wrapper depends on maven-java, as you did in your other pull request

Is it fine for you @gzsombor ?

Thanks, that was my suggestion too!


Feature add tcc branch report unit test

What this PR does:
1: add tcc branchReport unit test
Which issue(s) this PR fixes:
1: uniform name

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Hi， @wang1309 please fix ci

done

Hi， @wang1309 please fix ci

done


Azure VM lab - Ex01_Step23-24: Resource Groups button no longer present

What lab has the bug?
https://github.com/CrimsonPinnacle/cloud-labs/blob/main/compute-labs/azure/azure-vm-with-ubuntu-and-nginx-web-server.md
Describe the bug
Step23 of this lab states: "Once the deployment is complete, click on the Resource groups button button in the left-hand menu list under the Microsoft Azure logo."  However, that option no longer exists in the left-hand menu.

Instead, the user should click the Blue button labelled "Go to resource", located at the bottom central section, under the "Next Steps section.

Step24 should be updated, as well:

Under the "Essentials" section, find "Resource Group (change)".
click the link to the right of that, azwmnginxlab-[initials]-rg.

To Reproduce
Steps to reproduce the behavior:

Go to http://portal.azure.com, and proceed through the lab steps for the Exercise 1 of the lab linked above "Provision a Linux VM in Microsoft Azure"
Once you complete your vm creation, and deployment is complete (Step22), look to the left-hand menu for "Resource Options".
In the search bar above the left-hand menu, enter "Resource Options", and note the search result is empty.

Expected behavior
Expected "Resource Options" to be present, per lab instructions for Step23.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Browser: Chrome
Version: 92

Additional context
Add any other context about the problem here.

**NOTE: **This also affects Ex1(Create an Azure Function App Resource), Steps 17 & 18 from the "azure function with http trigger" Lab:
https://github.com/CrimsonPinnacle/cloud-labs/blob/main/compute-labs/azure/azure-function-with-http-trigger.md


Fix current logs symlink to point to host's manager spool

Fixes #31 where PR #30 created a regression which broke the symlink for the current logs on the docker host.

Turns out I just didn't wait long enough during my tests. The relative symlink does work on both the container and the host. Sorry for the mixup!


SIGSEGV Crash -> -[AVCaptureFigVideoDevice setVideoZoomFactor:]

Hello
I would like to continue with this thread, since it has not been paid attention.
It is possible that with this new information you can have a better idea of the cause of crash.
Issue Description
This happens to 0.1% of users in my application. I obtained these statistics using AppSee.

Steps to Reproduce
Just Rendering CameraKitCamera.
My Code:
<CameraKitCamera
  ref={(cam: any) => this.camera = cam}
  style={styles.imageCamStyle}
  cameraOptions={{
    flashMode: this.state.flashMode,
    focusMode: 'on',
    zoomMode: 'on'
  }}
/>

The Crash is:
Crashed Thread 17 :

0 | Foundation | 0x1c168d480 | NSKeyValueWillChangeWithPerThreadPendingNotifications.llvm.6024598272766318604 + 580
1 | AVFoundation | 0x1c6cbdd44 | -[AVCaptureFigVideoDevice setVideoZoomFactor:] + 384
2 | AVFoundation | 0x1c6cdcdbc | -[AVCaptureSession _updateDeviceActiveFormatsAndActiveConnections] + 2716
3 | AVFoundation | 0x1c6cdbb8c | -[AVCaptureSession _buildAndRunGraph] + 104
4 | AVFoundation | 0x1c6cd5b50 | -[AVCaptureSession _commitConfiguration] + 120
5 | AVFoundation | 0x1c6cd68b4 | -[AVCaptureSession addInput:] + 724
6 | Finery | 0x102feb91c | _ZN14RNWebGLContext27jsTypedArrayFreeDeallocatorEPvS0_ + 1170036
7 | libdispatch.dylib | 0x1c06536c8 | _dispatch_call_block_and_release + 24
8 | libdispatch.dylib | 0x1c0654484 | _dispatch_client_callout + 16
9 | libdispatch.dylib | 0x1c062efb0 | _dispatch_lane_serial_drain$VARIANT$armv81 + 548
10 | libdispatch.dylib | 0x1c062faf4 | _dispatch_lane_invoke$VARIANT$armv81 + 412
11 | libdispatch.dylib | 0x1c0637f14 | _dispatch_workloop_worker_thread + 584
12 | libsystem_pthread.dylib | 0x1c08360f0 | _pthread_wqthread + 312
13 | libsystem_pthread.dylib | 0x1c0838d00 | start_wqthread + 4

Environment
"react-native-camera-kit": "6.2.4",
Environment:
  OS: macOS Sierra 10.12.6
  Node: 8.9.1
  Yarn: 1.3.2
  npm: 5.5.1
  Watchman: 4.7.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: 3.1 AI-173.4819257

Packages: (wanted => installed)
  react: 16.0.0 => 16.0.0
  react-native: 0.51.0 => 0.51.0

no, it's still happening. At this point I am considering fork and trying to fix it on my own. The problem is that now I do not have time for this and the percentage of users who have this problem in my application is too low to be worth it. If you solve it before me, I would appreciate it if you would comment

It's happening fairly often for me in testing. It's certainly more often than the 0.1% you're seeing. I assume, though, that number includes android where the issue doesn't happen. I'm going to be looking into this over the weekend and I'll post back here if I find a good solution.

+1


Debug configuration test FAILED

Hi - I've updated lib to version 2.3.0(Windows Phone Silverlight 8.1) and got a certification error in dev center:
Debug configuration test
FAILED
Debug configuration
•Error Found: The debug configuration test detected the following errors:◦The binary ForecastPCL.dll is built in debug mode.
•Impact if not fixed: Windows Phone Store doesn’t allow a debug version of an app.
•How to fix: Please make sure the app isn't linking to any debug versions of a framework and it is built with the release configuration with optimization enabled.
Best regards
Dmitry Belov
BK Labs

Oops, thanks for this! Nuget was packaging the Debug version - I've just repackaged the Release .dll and uploaded it to the site as version 2.3.1. Let me know if that works!

It works! Thank you.

No problem -  glad to help :)


Update states to reflect unconditional offers

Context
Unconditional offers are currently not taken into account in the successful_application_states.feature file
Changes proposed in this pull request
Update successful_application_states.feature to reflect the states for unconditional offers
Guidance to review
Would like some feedback on if the states proposed make any sense from a business rules point of view.
Link to Trello card
897 - Unconditional offers states

@RobertM905 I fixed an issue in the cucumber step that was obscuring a failure. I also split the 'offer made' status everywhere.

Awesome stuff. Looks good.
As long as we are all happy with the way unconditional offers are represented here then I'll merge it in.


UniqueIdentifier Encoding

The UniqueIdentifier type provided by the package works great, however I've encountered some undesirable results when encoding structs to JSON. The result is an array rather than a readable ID that can be easily understood by a REST client. Below is an example of an encoded struct.
{"id":[241,42,149,0,128,213,67,144,191,140,180,28,81,147,169,191],"name":"Admin","description":"","modules":null,"databases":null}

In order to get the behavior I am looking for, I made my own struct to extend the provided UniqueIdentifier. The only difference is that it conforms to the TextMarshaler interface contained in the encoding standard library.
type GUID struct {
	mssql.UniqueIdentifier
}

func (u GUID) MarshalText() (text []byte, err error) {
	text = []byte(u.String())
	return
}

After making this change the encoded struct becomes:
{"id":"F12A9500-80D5-4390-BF8C-B41C5193A9BF","name":"Admin","description":"","modules":null,"databases":null}

Is it possible to implement the interface in the UniqueIdentifier?
Thanks!

@eamon-bell I encountered similar problems when trying to understand the UniqueIdentifier code. I've created a PR for supporting MarshalText. Let's see if it'll be merged.

@eamon-bell PR #520 has been merged. Can you try it out? Following is an example of how to use the new MarshalText() function:
uid := UniqueIdentifier{0x01, 0x23, 0x45, 0x67, 0x89, 0xAB, 0xCD, 0xEF, 0x01, 0x23, 0x45, 0x67, 0x89, 0xAB, 0xCD, 0xEF}
muid := uid.MarshalText()

I know that this issue is quite old, but I stumbled across this and have to tell that the fix only kind of works. If you call it directly it will work, but libraries like encoding/json will only accept MarshalText with the signature MarshalText() (text []byte, err error) as eamonbell proposed and as defined in TextMarshaler.
I don't know if you want to change the signature as it will break backward compatibility.

Sorry for bumping old issue but running into this issue myself and because of the incompatible signature exposed by the driver, I've had to extend the type like OP originally did. I personally think that its worthwhile updating the signature to play nicer with the standard lib

Development has moved to Microsoft's fork of this repository: https://github.com/microsoft/go-mssqldb.  You should open this issue there.

Closing the loop on this:
My PR relating to this issue was merged recently in the Microsoft fork, so people can use v1.4 onward if they do not want to keep adding the custom interface code
https://github.com/microsoft/go-mssqldb/pull/126