gh-1497 - configurable contact added

Codecov Report

Merging #1509 into develop will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1509   +/-   ##
==========================================
  Coverage      66.18%   66.18%
  Complexity      1768     1768
==========================================
  Files            731      731
  Lines          24231    24231
  Branches        3129     3129
==========================================
  Hits           16038    16038
  Misses          6924     6924
  Partials        1269     1269

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b96a7...2b81184. Read the comment docs.


Demo with syntax error

The Basic playground demo has a syntax error in it.
SyntaxError
/src/Hello.tsx: Expected corresponding JSX closing tag for
 (8:104)

   6 |
   7 | export default ({ name }: Props) => (
>  8 |
Welcome to WASM-ImageMagick basic demo. </>
     |                                                                                ^
   9 |
  10 | );
  11 |

   6 |
   7 | export default ({ name }: Props) => (
>  8 |
Welcome to WASM-ImageMagick basic demo. </>
     |                                                                                ^
   9 |
  10 | );
  11 |

@cancerberoSgx I forked yours and fixed the closing tag. If you are actively changing these you can always fix yours and change it back.
@Axure thanks for reporting this fixed in commit https://github.com/KnicKnic/WASM-ImageMagick/commit/d00877f04a4869ac974816b867efff5a6c0373bc


Register ghalib_craft.is-a-fullstack.dev

Added ghalib_craft.is-a-fullstack.dev using the CLI.

I fixed my website


users: Refactor get_profile_backend to be based on format_user_row.

This PR changes get_profile_backend to be based on format_user_row
such that it's a superset of the fields for our other endpoints for
getting data on a user.
This change adds some fields to the User object returned by the
endpoint. API docs are updated accordingly for the added fields.

Testing Plan:
GIFs or Screenshots:

Merged as 7de23b8b5c31db59a2fd3aa44662d368fff8ec15, after (1) bumping the feature level to 10 in version.py and (2) expanding the commit messages to give a bit more historical context you were unaware of :).
Thanks @sahil839!

I will make another PR for the left over part to change this endpoint accept same parameters as other endpoints, which are client_gravatar and include_custom_profile_data.
@timabbott I think we should keep default value of include_custom_profile_data as True for this, because in current behavior we return it in all cases and I assume this endpoint is for returning the complete profile to the user. Is it correct or we should keep it to false?

Yeah, I think matching the behavior of the other user fetching endpoints
makes sense.
On Mon, Jun 8, 2020 at 5:21 PM Sahil Batra<EMAIL_ADDRESS>wrote:

I will make another PR for the left over part to change this endpoint
accept same parameters as other endpoints, which are client_gravatar and
include_custom_profile_data.
@timabbott https://github.com/timabbott I think we should keep default
value of include_custom_profile_data as True for this, because in current
behavior we return it in all cases and I assume this endpoint is for
returning the complete profile to the user. Is it correct or we should keep
it to false?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip/pull/15253#issuecomment-640955223, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAU6NWQEKTV3QNSNWL3RHB3RVV6B7ANCNFSM4NXW42JA
.


Class cast exception while mocking MutableList

Hello,
I'm having problems to mock a mutable list.
My use case is that I simple want a mock for a mutableList and specify what list to return in the mutableList.toList()  call. But when I try to assert the result, I get a class cast exception:
java.lang.ClassCastException: java.util.Collections$SingletonList cannot be cast to java.lang.Integer

Here a simple code that shows the problem:
class Test () {

    val mutableList = mockk<MutableList<String>>()

    @Test
    fun test() {

        val expectedList = listOf("1")
        every { mutableList.toList() } returns expectedList

        val list = mutableList.toList()
        Assert.assertEquals(expectedList, list)

    }
}

This is happening because toList is an extension function, which should be mocked other way than regular function.
public fun <T> Iterable<T>.toList(): List<T> {
    if (this is Collection) {
        return when (size) {
            0 -> emptyList()
            1 -> listOf(if (this is List) get(0) else iterator().next())
            else -> this.toMutableList()
        }
    }
    return this.toMutableList().optimizeReadOnlyList()
}

Although the error message is misleading. I'll keep the ticket to fix the error message.
You can workaround this test using following code:
    val mutableList = mockk<MutableList<String>>()

    @Test
    fun test() {
        every { mutableList.size } returns 1
        every { mutableList.get(0) } returns "1"

        val list = mutableList.toList()
        assertEquals(listOf("1"), list)
    }

staticMockk which is usually helps to mock extensions, didn't work for me. Probably because collections are used in mockk itself

Thanks. I've checked the workaround and it's working.


Spellchecker fail on Apple notarization due to no suitable image found error on new Catalina OS

On the new Apple's Catalina OS, spellchecker would fail in electron due to "no suitable image found" error.
If not running through the distribution build, spellcheck works as expected. It's only having issue if runs as distribution build.

electron 5.0.11
electron-builder ^21.2.0
electron-rebuild ^1.8.5
spellchecker 3.7.0

+1

If you are running into this and need a permanent solution, consider using spellchecker-wasm which runs lookups in under a millisecond and does not require platform dependent builds.


no content generated

https://github.com/itfanr/awesome-stars
The repo is generated automatically, but the content section of readme is empty.
Can you help me ?

It is my fault. I've made it.
Thanks.


Testing notifications: toMail function is not reachable during testing

Laravel Version: 5.4
PHP Version: 7.1
Database Driver & Version: MariaDB

Description:
Raised exceptions within a notification class are not logged into laravel.log  and not reported to PHPUnit, any raised exception inside the method toMail($notifiable) is not tracked during mocking
Steps To Reproduce:

Create a simple route as follows, it just fire the notification

Route::get('/bug', function(Request $request){
  $managers = \App\User::where('user_class', 'tester')->first();
  Notification::send($managers, new \App\Notifications\NotifyTesterWithTest());
});

Create a test for this route.

    public function testCustomerDashboard()
    {
      Notification::fake();
      $response = $this->actingAs($this->tester)->get("bug");
      Notification::assertSentTo([$this->tester], NotifyTesterWithTest::class);
    }

Stop the execution of toMail function or make a syntax error

    public function toMail($notifiable)
    {
      dd('ss');
        return (new MailMessage)
                    ->line('You have been selected for a test')
                    ->action('Please visit your dashboard to take the test', route('tester_dashboard'))
                    ->line('Thanks for working with Users Proof');
    }

4- Run the test.
phpunit --group=BugController
PHPUnit 5.7.16 by Sebastian Bergmann and contributors.

.                                                                   1 / 1 (100%)

Time: 409 ms, Memory: 10.00MB

OK (1 test, 1 assertion)

The test passes despite there is a die inside the code. I added dd to the constructor and the via function it works well. but I can not trace it inside toMail function. I also could not find the errors (when I made a syntax error) inside laravel.log
Full code
NotifyTesterWithTest.php https://paste.laravel.io/0MV7z
web.php https://paste.laravel.io/p4OYO
Test https://paste.laravel.io/Ro1QK

did you add mail to notifiable function in notification controlle
public function via($notifiable)
{
return ['broadcast','database','mail'];
}

Yes, it is configured with mail only
On Mon, Apr 24, 2017, 12:25 AM Mohamed Benhida<EMAIL_ADDRESS>wrote:

did you add mail to notifiable function in notification controlle
public function via($notifiable)
{
return ['broadcast','database','mail'];
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/18910#issuecomment-296489770,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMCuyk5-YU0NL-BoFfubd4prX1_mJaYlks5ry8GsgaJpZM4NFUwH
.

Yes because we don't test the actual sending, we only check that a notification is sent. That's why the method is never called.

How can you test the actual sending? I tried to fake a mail to verify the
message but I failed to do so.
We had an exception in the mail template of the notification and testing
did not catch that
We had to test the notification through a web route to detect the issue.
Any suggestions to test this better?
On Mon, Apr 24, 2017, 4:38 PM Mohamed Said<EMAIL_ADDRESS>wrote:

Yes because we don't test the actual sending, we only check that a
notification is sent. That's why the method is never called.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/issues/18910#issuecomment-296671030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMCuyinnVPe5HjkY0dgInszOr339ylbxks5rzKXogaJpZM4NFUwH
.

How can you test the actual sending? I tried to fake a mail to verify the
message but I failed to do so.

Did you try to not fake the notification but fake the mail only?

@stemis I did this test before, but it did not work.
I think we need to figure out how to fire the function toMail first to detect if the message is being sent, What are your thoughts?
      Mail::fake();
          Mail::assertSent(MailMessage::class, function ($mail) use ($tester) {
            dd($tester);
        });

This is the result of the test

PHPUnit 5.7.19 by Sebastian Bergmann and contributors.

F                                                                   1 / 1 (100%)

Time: 2.15 seconds, Memory: 12.00MB

There was 1 failure:

1) Tests\Feature\BatchesControllerTest::testpublishBatch
The expected [Illuminate\Notifications\Messages\MailMessage] mailable was not sent.
Failed asserting that false is true.

/home/user/usersproof/htdocs/vendor/laravel/framework/src/Illuminate/Support/Testing/Fakes/MailFake.php:29
/home/user/usersproof/htdocs/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:221
/home/user/usersproof/htdocs/tests/Feature/Controllers/BatchesControllerTest.php:362
/home/user/usersproof/htdocs/vendor/laravel/framework/src/Illuminate/Support/Testing/Fakes/EventFake.php:65
/home/user/usersproof/htdocs/vendor/laravel/framework/src/Illuminate/Support/Arr.php:517
/home/user/usersproof/htdocs/vendor/laravel/framework/src/Illuminate/Support/Collection.php:321
/home/user/usersproof/htdocs/vendor/laravel/framework/src/Illuminate/Support/Testing/Fakes/EventFake.php:66
/home/user/usersproof/htdocs/vendor/laravel/framework/src/Illuminate/Support/Testing/Fakes/EventFake.php:27
/home/user/usersproof/htdocs/vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:221
/home/user/usersproof/htdocs/tests/Feature/Controllers/BatchesControllerTest.php:364

Just wanted to mention that it is possible to test the toMail ( or any other method for that matter on a notification ) but you just have to trigger it manually:
        Notification::assertSentTo(
            $user,
            EmailVerification::class,
            function ($notification) use ($user) {
                $mailData = $notification->toMail($user)->toArray();

                $this->assertContains('Some expected line in the intro', $mailData['introLines']);
                $this->assertEquals('Click Me!', $mailData['actionText']);
                $this->assertEquals(route('email.verify', $notification->token), $mailData['actionUrl']);
                $this->assertContains('Some expected line in the outro', $mailData['outroLines'][0]);
                // ...
                return true;
            }
        );

Thanks @jhoff
This is a very smart approach, I think it is valuable to be inside the documentation as well

This would be useful as in some case the mail is optionally sent within the Notification per the documentation:
public function via($notifiable)
{
return $notifiable->prefers_sms ? ['nexmo'] : ['mail', 'database'];
}

I wanted my test to inspect the actual \Swift_Message sent via a notification.
To do this, I get the sent messages via the array transport (the default for tests):
app('mailer')->getSwiftMailer()->getTransport()->messages()

And wrote some custom assertions around this.
Ensure your tests do not have Mail::fake() or Notification::fake() enabled.
I couldn't get this to work with queued notifications but I didn't look to deep into why. Maybe this can help someone else.


Change import pattern in TM

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Fixes https://github.com/PyTorchLightning/metrics/issues/459
Changes the import pattern for metrics requiring third-party packages from
from torchmetrics import FID

to
from torchmetrics.image.fid import FID

the recommended import path will be stated in the example belonging to each metric.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@SkafteNicki so the conclusion here is just to remove import Metrics that have a dependency on 3rd party integration and include only PyTorch native (our own) implementations...

@SkafteNicki that is an interesting failer, that shall happen with the original PR not here...
the case is that MAP is asking for some TorchVision version which is not minimal for TM :rabbit:


Menu Entry Swapper no longer has "swap bank op"

Title kinda says it all, the plugin Menu Entry Swapper recently had an option called "swap bank op" to wield equipment while bank was open. Now it is no longer present in the options, and we are missing it :(

it has been moved to Bank Deposit Shift-Click. Choose Eat/Wield/Etc. in the dropdown


Move thrift version to 0.9.3.

If merged, could you also cut a release?
thanks!

Thank you!
Released as 0.3.1.


Split the virtualenv with the dependencies from the app

This is an enhancement proposal: right now, every time the application is changed, the whole virtualenv with the dependencies must be uploaded again, even if the dependencies are exactly the same. If you have a slow connection like mine, this is a pain.
Once #542 lands, it could be possible to put the dependencies in their own zip, similar to what the slim_handler does. If the application alone is too big, maybe we could have two tarballs plus the handler.
As long as the dependencies are 'static', e.g. all wheels of a specific version, this should work well.
I am not very familiar yet with Lambda: do you foresee any problem with such an approach? If you think it is feasible, I could give it a shot. I could start from #542 or from scratch.

This is kind of in the intersection of two different problems we've talked about, one is that we could have a delta-based package that would then deploy from another Lambda, so that package upload times are very negligible after the issue, and the other is decoupling the package from the venv.
What is it your trying to solve with this idea?


fix: 🐛 issue#276 fix. Added eip712 domain validations

✅ Closes: #276

The issue of missing domain validation turned out to also be present in attestation.jar. I handled this in this PR

I also implemented the JS fix in this commit . So I am happy with merging if you are @oleggrib


Label CSS Class

The label class for is of the same dimension as the class for . This makes for a more clean appearance. Also, the labels where overlapping when positioned in adjacent lines of text.
Renamed de label classes to reflect on the topics addressed.

@absynthmind not sure what you mean with this, can you please elaborate?

The padding for the  "label" has been set to equal that of the .


[test_rclcpp] #101 test_services_cpp (test_rclcpp.TestTwoExecutables.test_services_cpp)

Failure
[test_services_client_cpp-2] [==========] Running 5 tests from 1 test suite.
[test_services_client_cpp-2] [----------] Global test environment set-up.
[test_services_client_cpp-2] [----------] 5 tests from test_services_client
[test_services_client_cpp-2] [INFO] [1712303353.082268953] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id 3e37a66397bacb45b5938f4ad4063a8.
[test_services_server_cpp-1] [INFO] [1712303353.086031453] [rmw_zenoh_cpp]: Successfully connected to a Zenoh router with id 3e37a66397bacb45b5938f4ad4063a8.
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_add_noreqid
[test_services_client_cpp-2] [       OK ] test_services_client.test_add_noreqid (109 ms)
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_add_reqid
[test_services_client_cpp-2] [       OK ] test_services_client.test_add_reqid (2 ms)
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_return_request
[test_services_client_cpp-2] [       OK ] test_services_client.test_return_request (5 ms)
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_add_two_ints_defered_cb
[test_services_client_cpp-2] [       OK ] test_services_client.test_add_two_ints_defered_cb (2 ms)
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_add_two_ints_defcb_with_handle
[test_services_server_cpp-1]   what():  failed to send response: Unable to find taken request. Report this bug., at /home/yadunund/ros2_rolling/src/rmw_alternative/rmw_zenoh_cpp/src/rmw_zenoh.cpp:2890, at /home/yadunund/ros2_rolling/src/ros2/rcl/rcl/src/rcl/service.c:400

With some debug statements it looks like the the sequence_number generated for each client is always 1 (See lines "Generated sequence_id 1 for client ..." below). Therefore the service cannot find the same sequence_number after it returns a response for the first client.
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_add_noreqid
[test_services_client_cpp-2] Generated sequence_id 1 for client over /add_two_ints_noreqid
[test_services_client_cpp-2] [       OK ] test_services_client.test_add_noreqid (109 ms)
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_add_reqid
[test_services_client_cpp-2] Generated sequence_id 1 for client over /add_two_ints_reqid
[test_services_client_cpp-2] [       OK ] test_services_client.test_add_reqid (2 ms)
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_return_request
[test_services_client_cpp-2] Generated sequence_id 1 for client over /add_two_ints_reqid_return_request
[test_services_client_cpp-2] [       OK ] test_services_client.test_return_request (2 ms)
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_add_two_ints_defered_cb
[test_services_client_cpp-2] Generated sequence_id 1 for client over /add_two_ints_defered_cb
[test_services_client_cpp-2] [       OK ] test_services_client.test_add_two_ints_defered_cb (3 ms)
[test_services_client_cpp-2] [ RUN      ] test_services_client.test_add_two_ints_defcb_with_handle
[test_services_server_cpp-1] terminate called after throwing an instance of 'rclcpp::exceptions::RCLError'
[test_services_server_cpp-1]   what():  failed to send response: Unable to find taken request for sequence_number 1. Report this bug., at /home/yadunund/ros2_rolling/src/rmw_alternative/rmw_zenoh_cpp/src/rmw_zenoh.cpp:2897, at /home/yadunund/ros2_rolling/src/ros2/rcl/rcl/src/rcl/service.c:400

Okay so this is caused by the  sequence_to_query_map_ data structure used to map sequence_number of client request and the ZenohQuery, ie this map.
We're not distinguishing between which client the query came from.
Two solutions come to mind:

Make sequence_number generated by the client globally unique.
Update sequence_to_query_map_ such that it maps std::unordered_map<gid, std::unordered_map<sequence_number, ZenohQuery>>

@clalancette what do you think? Personally I think we 2 is easier.

We're not distinguishing between which client the query came from.

Ah, of course.

2. Update sequence_to_query_map_ such that it maps std::unordered_map<gid, std::unordered_map<sequence_number, ZenohQuery>>

Just to be clear; the gid as the kye here would be the gid that the client attaches, correct?  If so, then yes, I think this is the way to go; it uses information we already have.

Yupp the gid the client already attaches.


Missing test coverage

A great first PR is to pick something on this list and write tests for it!

[x] Symbols.js
[ ] solveEquation/EquationOperations.js
[ ] in CombineChecks.test.js separately test the functions CombineChecks.canMultiplyLikeTermPolynomialNodes, CombineChecks.canAddLikeTermPolynomialNodes, and CombineChecks.canRearrangeCoefficient

feel free to point out more missing tests below!

Can I be assigned this?

Ok.

FYI @nkprince007, @arbylee wrote tests for Symbols.js in #88 :)

Thanks a lot, guys, but I'm a little caught up ATM, definitely like to contribute, soon as I find time.

Sounds good @nkprince007! If you don't think you can get to this issue for a few weeks and don't have strong feeling towards it, we can un-assign you and when you have more time you take on whatever's free.  If you're exciting about this issue though, we can keep it until you have the time :) let me know!


UpdateResource: Check version and create new resource for new version

Adds a verifyPayload method to update in order to do any required checks against the update payload and the existing resource.
Note: Fixes #394

Check:

deposit an object, retrieve the object, check tacoIdentifier & externalIdentifier, update object with those identifiers added to path & update json payload being the same with a new version specified should be all good & able to retrieve both versions
deposit an object, retrieve the object, check tacoIdentifier & externalIdentifier, update object wrong / different externalIdentifier in the path but correct / same identfiers in update json payload with a new version specified should be 404 error
deposit an object, retrieve the object, check tacoIdentifier & externalIdentifier, update object correct / same
externalIdentifier in the path, same / correct tacoIdentifier in json payload, but different / wrong externalIdentifier in update json payload with a new version specified. Should be validation error.
deposit an object, retrieve the object, check tacoIdentifier & externalIdentifier, update object correct / same externalIdentifier in the path, same / correct externalIdentifier in json payload, but different / wrong tacoIdentifier in update json payload with a new version specified. Should be validation error.

Notes:

doesn't set any defaults for previous version editing permissions
example for update version has incorrect identifiers
doesn't limit increment jumps for versions to 1
is there a test for update with a version change?


Make $spork more accessible

Now it's impossible to hook on Spork batch finish to do some other necessary stuff after assetic:dump is completed.

I'm rather -1 on this. It would force us to maintain BC on it.
And it is not even always used, making it a weird way to provide a hook.
Can you describe your use case, to let us determine what the right extension point would be ?

Okay, problem started with this issue: https://github.com/kriswallsmith/assetic/issues/764 - assetic cache busting doesn't work with asset variables at all (or vice versa). That's why we implemented custom cache busting. Problem is that we have ~ 200-300 various asset files and we need cache busting for only those, which are changed.
So generally we extended DumpCommand, and on deployment, after assetic assets are dumped, we traverse each of them to calculate crc32b checksum of it's contents and store result in Symfony cache. Later some other, legacy assets are dumped and so on...
Short pseudo code looks like that:
use Symfony\Bundle\AsseticBundle\Command\DumpCommand as BaseDumpCommand;
class CustomDumpCommand extends BaseDumpCommand
{
...
    protected function execute(...)
    {
        parent::execute(...);
        $this->hashCalculator->calculateHashes();
        $this->legacyAssetDumper->dumpLegacyAssets();
    }
}

Whole command runs about 4-5 minutes, and most of the time (about 80%) it's dumping assetic assets (not legacy). Problem is, that $this->hashCalculator->calculateHashes(); depends on parent::execute(...); and we cannot use Spork here.
I would love to have an access to private $spork to hook-up on batch finished callbacks to further process asset dumping.

Please note that here are 2 systems involved: Symfony and some legacy one. Cache busting already implemented in legacy system about decate ago.

Hello,
could You please decide on this issue?

@stof - I think I explained use-case of this, could You please give some opinion on this?


diff-quality fails with ValueError: invalid literal for int() with base 10: '470]'

When running diff-quality tool I have the following exception:
Traceback (most recent call last):
  File "/usr/local/bin/diff-quality", line 8, in <module>
    sys.exit(main())
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/diff_quality_tool.py", line 348, in main
    percent_passing = generate_quality_report(
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/diff_quality_tool.py", line 261, in generate_quality_report
    reporter.generate_report(output_file)
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/report_generator.py", line 265, in generate_report
    report = template.render(self._context())
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/report_generator.py", line 314, in _context
    context = super().report_dict()
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/report_generator.py", line 187, in report_dict
    src_stats = {src: self._src_path_stats(src) for src in self.src_paths()}
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/report_generator.py", line 84, in src_paths
    for src, summary in self._diff_violations().items()
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/report_generator.py", line 176, in _diff_violations
    self._diff_violations_dict = {
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/report_generator.py", line 178, in <dictcomp>
    self._violations.violations(src_path),
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/violationsreporters/base.py", line 159, in violations
    self.violations_dict.update(self.driver.parse_reports([output]))
  File "/home/jenkins/.local/lib/python3.8/site-packages/diff_cover/violationsreporters/violations_reporter.py", line 469, in parse_reports
    violation = Violation(int(line_number), error_str)
ValueError: invalid literal for int() with base 10: '470]'

The reason for this is the following: violations_reporter expects, that the output for duplicating lines looks like:
file1.py:162: [R0801] Similar lines in 2 files
==file1:162
==student.views:4

but it can look like:
file1.py:162: [R0801] Similar lines in 2 files
==file1:[162:165]
==student.views:[4:7]

And the multi_line_violation_regex regular expression ==(\w|.+):(.*) cannot parse it correctly.
The correct regular expression is ==((?:\w|\.)+?):\[?(\d+).

Thanks @kozlovsky check out https://pypi.org/project/diff-cover/6.5.0/

Thanks, it works!


Remove palindrome example solution from the shell

Remove the given example solution in the palindrome exercise from the elixir shell.

Good catch!


Create ugto.txt

adding UG

@Physicworld I am sorry, the domain ugto.mx is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Bug: docker - error: exec: "bash": executable file not found in $PATH

Describe the bug
Docker compose when started reports
docker compose logs -f
archivebox  | error: exec: "bash": executable file not found in $PATH
archivebox  | error: exec: "bash": executable file not found in $PATH
archivebox  | error: exec: "bash": executable file not found in $PATH
archivebox  | error: exec: "bash": executable file not found in $PATH
archivebox  | error: exec: "bash": executable file not found in $PATH
archivebox exited with code 1

it seems that bash sits in /bin/bash
but docker_entrypoint.sh expects #!/usr/bin/env bash
Steps to reproduce

create docker-compose.yml

version: '3.7'

services:
    archivebox:
        image: ${DOCKER_IMAGE:-archivebox/archivebox:latest}
        container_name: archivebox
        stdin_open: true
        tty: true
        ports:
            - 8000:8000
        environment:
            - USE_COLOR=True
            - SHOW_PROGRESS=False
        volumes:
            - ./data:/data

docker compose up -d
docker compose logs -f

ArchiveBox version
archivebox/archivebox:latest

strange that this hasnt popped up before, fixed: https://github.com/ArchiveBox/ArchiveBox/commit/0b6064b7dd09a8355437364bc6627919d26c1fa5
try archivebox/archivebox:dev instead of :latest

@pirate
it did not help

try archivebox/archivebox:0.7.1, just released recently

Closing as stale, comment if you're still having problems.

Leaving this in case anyone else might find it useful:
I had the same error now. It turns out that it was an outdated docker version in my case. 0.19.X seems to be too old. It works now after updating docker.


Authorization Code Flow for Single Page Applications: Token Caching and Cleanup

This PR add token caching and cache cleanup after requests to the authorization code flow for single page applications.
Please review PRs #1181 and #1183 before this PR.

Good work! Over all simplifying tokenProcessing the same way you did for loginRequest() helps in readability IMO.


Replacement vmname.rb (Automate)

I'm no Ruby expert, but I'm sensing the "RundantReturn" warning is being falsely generated.  Parenthesis or no, the return statement shouldn't be being interpreted as returning multiple objects (and isn't by the appliance).  Also, sorry for generating two PRs, I thought they would merge since I was doing editing in-line via Github itself.

@mkanoor @tinaafitz Please review

"Redundant return" means that you stated a literal return in the code when it isn't necessary.  The style we've chosen is to not put a literal return when it is not needed.

Got it. Alright, when I get a sec I'll refactor and commit again. Thanks!

@kbrock helped me get a local dev env set up so... third time's a charm. :+1:

@gmcculloug @mkanoor Please review

The idea of having the .compact.join was so that there wouldn't be odd cases like "cfme__001" when no tag is specified.  Would you prefer it that way? Seems incorrect to me.  I'd prefer to see "cfme_001" if that's the case.
To the other points, I'm fine with those and will probably have time in a few days to create another commit.

@01000101 Overall this looks good, a few comments.  This PR will need tests.  You can check out the automate method tests in spec/automation/unit/method_validation.  I recommend looking at scvmm_microsoft_best_fit_least_utilized_spec.rb as an example.

@01000101 My comment on the join command was that there is no underscore being used when combining the segments today and I would prefer to keep that style.
I think the line should read: evm.object['vmname'] = derived_name.join

Oh, OK. Fair enough

Closed in favor of PR #10126


chore: bdd-gh-1583873189 to 0.0.1

chore: Promote bdd-gh-1583873189 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Spec fixed to reflect new examples property

There was a change in our API version 2021-01-01-preview that was not documented, this PR addresses the issue. To be clear, there is no behavior change on our side, remoted property "sample" is ignored under 2021-01-01-preview API version, instead new property was added - "examples". Changes are already deployed (quite some time ago).
PR is to fix documentation and SDKs.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@leni-msft, could you help me understand what needs to be done to move this forward? We've got approval for breaking change. Two errors that I see are:

LintDiff: "The schema 'ParameterExamplesContract' is considered an object but without a 'type:object', please add the missing 'type:object'" that is not true. When schema has no type defined it is effectively may be anything - we accept any valid JSON value in our API. What is the way to handle that?
Breaking change tracking - we already have approval

@VitaliyKurokhtin To fix it, add "type": "object" to ParameterExamplesContract

@leni-msft, but that is not the same. {"type":"object"} will only allow objects, but not values like 5, or "string". Where as {} does allow everything. You can easily repo this here: https://www.jsonschemavalidator.net

@VitaliyKurokhtin Absolutely. If it's your intention to make ParameterExamplesContract to accept number or any other primitive types, you can suppress the LintRule in readme(see https://aka.ms/SwaggerSuppressionRequest). Otherwise, define it as object.

@leni-msft, I got approval and added suppression. Any way to merge it now?


Update README.md with Netcat as a requirement

The script that is generated by the example uses Netcat , this will cause failures.
The rstudio docs have contain nc as a prerequisite.

Would it be preferable for us to modify the code to not use netcat, or try netstat if netcat is not available i.e. your suggestion:
port_used () {
  local port="{1#*:}" sleep 2 netstat -nap 2>/dev/null | grep -q "<IP_ADDRESS>:{port} "
}

Well that would preferable for us, our teams don't promote applications that may make our systems more vulnerable.
It's really your call, I just figured it would be easier for you to update the README than to update the script. It took a few hours to debug this because no error is output when the nc call fails.

I agree that if there are problems with asking sites to install netcat then we should do something else.
But, as for the correct fix for this issue, netcat is listed as a dependency in the setting up interactive apps section of the OnDemand documentation for version 1.5 / master. Example interactive apps need to link to that documentation.


An IPC immediately starts OS (Ubuntu 16.04) w/o giving a room for configuring BIOS

On Advantech 3400 that I haven't even turned the power on for 2 years, I'm seeing turns the power on, BIOS shows its top page then immediately switches to a screen where Ubuntu is asking options to start with. Then that page also doesn't wait for user's input and Ubuntu from the disk starts.
So right now there's no thing I can do from the computer's k/b.

I ran out of ideas. I decided I'd rather not spend more time on debugging.
What I've done but didn't work:

Tried all USB ports to connect the bootable USB.
Tried all USB ports to connect USB k/b. Neither BIOS nor Ubuntu didn't take inputs before Ubuntu finishes init process.
On Ubuntu, tried to ssh in.

Both NICs didn't get IP via DHCP. (Router's admin page showed it detected MAC, but didn't assign IP). It's very possible both are configured for static IP.


Rest API: Merge Files API with Folders API tokens

We should have general tokens for media.
Instead of Files API tokens and Folders API tokens we should have Media API tokens.
Epic: #546

not actual for new Media API


$translateChangeSuccess not fired after pageload

Problem:
After reloading the page the $translateChangeSuccess is not fired on the $rootScope (well it actually is but too early)
Environment:
angular: 1.4.9
angular-transltate: 2.10.0
Google Chrome: 48.0.2564 (seems to be browser independent, also occurred in FF)
Steps to reproduce
In this plnkr open the console and start the code. Then switch languages using the buttons.
Expected behaviour
$translateChangeSuccess should fire after every translation.
Actual behaviour
$translateChangeSuccess does fire after changing language using the buttons but not after page load.
I've added console.log() statements on listener registration, listener fire and event emit in the angular-translate code. When monitoring the console you can clearly see that the first $translateChangeSuccess after pageload is fired before the listener in app.run() is registered, hence missing the fired event.

Hm.. well, that is an interesting thing. I've seen the missing event already, but I had not get into it.
Given your example, I've added the following module:
+ angular.module('x', [])
+ .run(function($rootScope){
+ 	$rootScope.$on('$translateChangeSuccess', function() {
+   	console.log('Translation completed (before)');
+   });
+ });
+ angular.module('app', ['x', 'pascalprecht.translate'])
- angular.module('app', ['pascalprecht.translate'])

If you run this, you will the line Translation completed (before). Just as you already pointed out: It is fired, but too early for (your) application run block. And neither any other controller/directive.
What can we do?

The service should perform the loading as soon as possible, so we actually do not want to delay it.
You can use $translate.onReady().
Even if we define a new emit on our module's run block (with a new internal event name), it will probably be still too early for the other applications. We should play with it, but I'm in doubt it will solve this.

Further ideas anyone? @angular-translate/core

Heyho, ey looked through the source code of angular translate and if i recognize it correctly i found some events are triggered like this:
$rootScope.$emit shouldn't it $rootScope.$broadcast
Cheers!

That should not change the game for this point.
As per definition of both according the official documentation, $emit() will fire for each scope upwards starting  the given one (scope.$parent), and $broadcast() will fire on each child scope downwards starting the given one (~ child in $scope.$children). Due serious performance issues of the latter one, we have chosen $emit().

Okay thanks for clearification. Does not know that it triggers for both! :+1:

angular: 1.4.8
angular-transltate: 2.10.0
Google Chrome: 50.0.2661.75
I get the same issue as @Aides359 also.
In my case, I register the $translateChangeSuccess event inside a controller (upon instantiating controller).
So 90% of the time the event does fire after during / after controller instantiated. But roughly 10% of the time I strongly believe the event is emitting before the controller is instantiating (i.e. to register event). So using $translateChangeSuccess event is unreliable. I tested this scenario by constantly refreshing the page several times.
Could there be a way to improve the events' reliability?

The reason I register this event inside a controller is because I get untranslated translation key names back from the $translate() constructor call inside the promise success handler when only the fallback language is adopted after failing to get primary locale via a network request. Hence the decision to use and wait for translateChangeSuccess to fire before attempting to get translations using $translate().

What is about local $translate.ready() + local event listener translateChangeSuccess?
Perhaps we can create another shortcut handler, however, it would be called for anyone later.

Could you link me the docs of $translate.ready()? I can't seem to find it.
While skimming through the docs I found $translate.onReady(fn). Would that help to resolve this problem? If yes, would it be an option to let $translate.onReady(fn) fire $translateChangeSuccess natively to avoid having to write duplicated code?

I believe the performance issue with $broadcast was resolved quite a while ago.   It doesn't actually "broadcast" in like DOM events.  It's a publish subscriber model so only the actual subscribers are going to be called.

@knalli While doing refactoring I came across this part again. I did try $translate.onReady() and it seems to work.
What do you think of the idea to let $translate.onReady() fire $translateChangeSuccess?
Having to define the same behaviour twice in .onReady() and $translateChangeSuccess is not really nice for maintainability and kind of violates the concept of least surprise.

Well, there is also $translateReady which is actually firing onReady(). The latter is newer and being an easier way of handling the "ready" state.

Maybe describing my current situation will help clarifying my point:
I am using $translateChangeSuccess to synchronize language with $locale as proposed in #276 by @DWand
$rootScope.$on('$translateChangeSuccess', function ()
{
    $tmhDynamicLocale.set($translate.use());
});

Since on page load the $translateChangeSuccess event is missed I'd have to go for something like this
{
    $tmhDynamicLocale.set($translate.use());
}
$rootScope.$on('$translateChangeSuccess', syncLanguage);
$rootScope.$on('$translateReady', syncLanguage);```

which would be kind of redundant and counter-intuitive.

As I see it `$translateChangeSuccess` should be fired (as it does) and recognizable (it is missed) after page load so triggering `$translateChangeSuccess` in `$translateReady` seems like a fitting solution.

Ready is an one time event, just like jQuery's $(document).onReady(fn). The events can be fired multiple times, depending on their meaning.
If you are looking for a simple once-event "when the translations are ready", you should use $translate.onReady(fn). If this is not working, it could be a bug.
Note: onReady is only some months old.

Not sure if I get my point across...
What I need is an event that notifies me on any language change (as $translateChangeSuccess does), including the very first set language for instance set by preferredLanguage(), determinePreferredLanguage(), useLocalStorage(), ... (which does fire $translateChangeSuccess but before $rootScope.$on('$translateChangeSuccess', ...) is registered, so the event is missed there.
As far as I can tell it would be a sufficient fix to trigger $translateChangeSuccess when onReady is called (since onReady fires a bit later and the event would be caught correctly).

Sorry for the delay.. I don't get it right, still.
Please again, just as simple as possible: Which event in which situation is missing or not "right"? Why is translateChangeSuccess wrong?

No worries.
It's been some time so I can't find the apropriate docs right now but I would expect translateChangeSuccess to fire on every language change, even the first one from nothing -> preferred language after page load/reload.
This first event is missing however.
After further analysis/debugging it became clear, that the missing event is fired by angular translate, however the event is fired before any event listeners (i.e. set up in angular.module('app', []).run(..) are registered, thus the event is never caught and appears to be missing.

Wanted to add a couple cents to this.  I have the same need:  I need to know when a translation run has completed regardless of whether that is the first one or when the language has been changed later on.
In my testing I find that:

$translateChangeStart is either not fired or is fired before my handler is registered.
$translateChangeEnd and $translateChangeSuccess are fired properly however...
when I use useMissingTranslationHandler() to set a handler, that handler is fired after $translateChangeEnd and $translateChangeSuccess have already fired.

In my application I am trying to summarise the missing translations.  To do this I use a missingTranslationHandler to collect all the translations but need to know when the process is finished.
A simplified plunker is here: http://plnkr.co/edit/GIPS7W3sNgm006kAW5wm?p=preview
Note: a slightly different issue appears to be that $translateChangeStart only fires (or only fires late enough) when I use $translate.use() within app.run().  Different issue but it displays similar timing problems.

Please give 2.14 a try.

Hello,
in part of a "Spring Cleaning 2017", we are closing this issue as part of several others. The meta discussion is available here for full transparency.
 Said this, we must keep the focus and scope on the project.
We are grateful and appreciate to everyone for each made contribution (regardless being code, idea, documentation, and support).
We are deprecating/closing all issues which fulfills a specific set of criteria: mainly outdated, nice-to-have, or just out-of-scope.

Although the list has been curated to the best of our's knowledge, there will be some lack of understanding.
Okay, there a different stories behind all open issues, but we do not have the time for everything:

Support: Because we have only limited resources, we cannot handle support questions any more. Please use appropriate boards like Stackoverflow.
Feature requests or ehancements: Altough it is probalbly a great idea (otherwise it would be closed already), we can not giving more resources to things out of scope or which are useful for too specific scenarios only.
Bugs: Filed a long time ago, this bug either has a reasonable workaround, no effective solution without harming all others, or is lacking additional information/use-case.
Docs: All documentation efforts not matching English will be abonded.

Thank you.
angular-translate team

FAQ
"But this is really important!"
Well, we are all humans. Maybe we have overseen an important issue. If we missed something, we hope you are reaching as again filing a new issue with the reference to the old one. But please be aware: A bug without further details and a demo included will be rejected again.
"But this would a great feature!"
Reconsider: Are we really required to add something in order to make this feature happen? Or could you also create a project on your own utilizing this project?

In case anyone finds this thread and still doesn't know what to do - the solution on this SO question worked for me http://stackoverflow.com/questions/41998073/how-to-do-error-handling-for-the-event-translatechangesuccess


Can not create client without custom login page

Hey,
with the recent changes in the underlying Auth0 provider, this module now causes errors when trying to create clients without custom login page.
Steps

Adding a client without custom_login_page setting
Running a plan
Running an apply

Expected
All is fine, all gets applied
Actual
The apply fails with this error message:

Error: 400 Bad Request: Payload validation error: 'String is too short (0 chars), minimum 1' on property custom_login_page (The content (HTML, CSS, JS) of the custom login page).

Background
There have been bugfixes in the Auth0 provider lately described here. Your auth0 module defaults the custom_login_page setting to an empty string. This causes errors in the underlying provider when applying. I would propose to set the default value to null instead of an empty string as also mentioned in the linked Github issue.
I can also create a PR, if you want.

Fixs v1.2.7


⚠ ClamAV has degraded performance

In c6c64e8, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 65 ms

Resolved: ClamAV performance has improved in 7c9a611.


[UpdatePlugin]  toolCHAINZ DUMB v1.0.2

Please update my plugin:
Author: Me
Repo name: DUMB
Release: v1.0.2

Updated, thanks!


Add functionality to run subscript from the command line

Re. what we discussed earlier today. Instead of making settings.yaml for many combinations of the scenariosmethodsscore, perhaps we can have one main settings.yaml and run a subset of the combinations through command line.
(sim[1]*est[1], sim[2], est[2]) * mse

I'm not sure if it is good idea to allow for only this feature, or to allow for passing any DSC parameters from the commandline, for example,
dsc execute config.yml -c "DSC::run::sim[1]* est[1] * mse" "simulate::exec::rnorm.R"

And whether or not this is a good interface for it. My main concern is that this might harm reproducibility because you'll end up having the same DSC end database for your result with different parameter settings. Implementation is easy but we may want to figure out how to prevent this design from causing chaos.

In order to force reproducibilty I decide not to allow for input of any parameters. But because input sequences do not change any parameters or files defined by DSC script, I have allowed for the possibility to override default DSC sequence via -s option. Here is an example on the Quick Start tutorial:
[GW] dsc execute settings.yaml -s 'simulate[1] * estimate[1]'
INFO: Constructing DSC from settings.yaml ...
INFO: Load command line DSC sequence: simulate[1] * estimate[1]
INFO: Running DSC jobs ...
simulate_1+estimate_1: 100% [============================] 2 0.3/s in 00:00:06
DSC: 100% [==========================================] 1 0.2/s in 00:00:06
INFO: Building summary database dsc_result.csv.gz & dsc_result.db ...
INFO: DSC complete!
INFO: Elapsed time 6.696 seconds.


Value expressed with alphabetic characters

For example "twenty kilos" - currently the recognition is very bad and there is no normalization into numerical values.
We should:

add a matching feature for this very limited vocabulary in the quantity model (it will generalize the examples in the training data),
add a dedicated normalization.

Add a number word matching feature in the quantity model with commit 5e0b1b72be33e0a25bdff769ec1d5f1f182e6cdc -> the detection works much better now

FYI http://stackoverflow.com/questions/3911966/how-to-convert-number-to-words-in-java

We're doing the opposite from this stackoverflow, we convert words to numbers ;)
But anyway, it's almost finished, just need to cover a couple of unregular expressions (like "oh", "dozen", "half",...) as CRF feature and normalization.

oh joy... true...
sorry


fix bug in tree.rs

this bug was introduced in fcdf89d7d60b37f6d5fc69f7ad458df42aac8579 and is causing libafl based fuzzers using nautilus to crash.

Probably a manual fail

This was addressed in PR #26 which is still open


Get Jason-3_2_UNCOUPLED into git

This one first depends on #29 first getting in and merged into master. We can then branch off master and commit the code from the Jason-2_2 versions of:
LANL_Shared
GEOSsaltwater_GridComp
GEOSogcm_GridComp

We also need to remove GEOSdataatm_GridComp and get the Jason-3_2_Modified_for_UNCOUPLED variant of GEOSgcm_GridComp.F90.
Note that CMakeLists.txt files might/will probably need to adjusted because of the loss of GEOSdataatm_GridComp and perhaps added/removed files in LANL_Shared (not sure).

Closing for now as we may not want the uncoupled version on git until testing is done.


Fixed example in -LocaleSettings

Was missing several double quotes around Value

Docs Build status updates of commit 2c48d8c:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 2c48d8c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/policy-and-compliance/New-Label.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Delete tables

fixes uwescience/myria-web#261

Coverage increased (+0.01%) to 59.42% when pulling 84b5d68c5444c3aa8de8ba0601e59ff01558e926 on deleteTables into 54d54b9c39eca115db4986c126f4e43f5edde11f on master.

Probably a silly question, but is there a way I can re-run these tests? (there was a timeout issue with the test that failed with the latest commit) When I run the systemtests from my side, everything passes.
Thanks!

Yes, I restarted the Travis build. There is a "replay" button at the upper
right corner of the Travis page, right below "Settings". (I couldn't find
it either until Dominik pointed it out to me.)
On Fri, May 15, 2015 at 10:17 AM, jortiz16<EMAIL_ADDRESS>wrote:

Probably a silly question, but is there a way I can re-run these tests?
(there was a timeout issue with the test that failed with the latest
commit) When I run the systemtests from my side, everything passes.
Thanks!
—
Reply to this email directly or view it on GitHub
https://github.com/uwescience/myria/pull/743#issuecomment-102461616.

Cool! Thanks!

Coverage decreased (-0.1%) to 59.31% when pulling 876fbf3ab1e7420df9e8bf26d3fea50125d31757 on deleteTables into 54d54b9c39eca115db4986c126f4e43f5edde11f on master.

Sorry for the delay. I made the change with the exception (I hope that is what you meant) and I also added some tests.
I talked to Magda about your suggestions with potentially adding a 2PC protocol in order to make sure that relations get deleted correctly. She mentioned that for now, we should only make sure that the call is idempotent. So now, as long as the relation exists in the catalog, we should be able to call this method even if not all the workers have the underlying relation we are trying to delete. I tried to add such an example in the tests. What do you think?

tests are failing because I am using an old version of SystemTestBase it seems. I'll fix this once I get to campus.

Coverage increased (+0.21%) to 59.57% when pulling 5ceb820be51061c8d855a02c0e181b0e2f350627 on deleteTables into 0f813fd68028e8a56bcc3add79e84f3f8fc44cba on master.

I had to run a rebase to get the new tests to work. I didn't know it would show all my commits again on here. Relevant commits start from 7da559d17425dbcab799bae7cbf628b0033de60d onwards.

I added the tombstone column along with the queries from the MasterCatalog that were called from the DatasetResource class. Once a relation is tombstoned, the goal is to not have it show up through the API calls from DatasetResource (i.e. getDatasets, getDatasetsForUsers, etc).

Coverage increased (+0.32%) to 59.67% when pulling a80943ec79314e7b3aa335c7d11d005062ae0d3b on deleteTables into 0f813fd68028e8a56bcc3add79e84f3f8fc44cba on master.

Hey Tobin, I added back cascade delete, but I wasn't sure what you meant by adding a "best effort" parameter?

Just meant a boolean parameter to simply log a warning if cascade isn't supported rather than throw an exception.

@senderista Awesome. Can you ping myria@ when this is deployed so that we can all start deleting tables?


Zero asset issuance

This adds fix for issuing zero value asset issuance.
Both blinded and unblinded zero value assets are supported.
Changes includes removing asset output if asset amount is zero and logic for calculating minValue for rangeProof which is decided based on scriptPubKey, check in here
This closes #190
@tiero @altafan please review.

@sekulicd watch out! AddIssuanceArgs.validate() still expects the asset address to be mandatory, while now it should be like that only in case the asset amount is > 0 (just like we do for the token the lines below).
Then in TestBroadcastUnblindedZeroAssetValueIssuanceTx we can avoid to pass an AssetAddress.

@sekulicd watch out! AddIssuanceArgs.validate() still expects the asset address to be mandatory, while now it should be like that only in case the asset amount is > 0 (just like we do for the token the lines below). Then in TestBroadcastUnblindedZeroAssetValueIssuanceTx we can avoid to pass an AssetAddress.

Done


ux-redesign: VM Details > Disks Card (view only)

View only part of #775

move files to VmDetails/cards/DisksCard/

view only mode of the Disk Card

move src/utils.js to src/utils/index.js

export all of the src/utils/*.js functions from the folder's index.js

can you post a verification screenshot?

code lgtm

move src/utils.js to src/utils/index.js

nothing else was using that yet?

move src/utils.js to src/utils/index.js

nothing else was using that yet?

Well....yes things were using it.  But, moving a file utils.js to utils/index.js does not require changing the import statement.  In other PRs (Details Card in specific), I ended up using more then 1 of the files in src/utils and it was annoying to have to import each one on a different line.  So packing it all in the index.js allows for separate files for different bits and allows a single import.  Patterfly uses that approach all over.

@gregsheremeta - Added screenshots to the main description


Add documentation

@LKirst amazing! I see you're still adding commits, let me know when this is ready to be merged.

@alxwrd, you could merge the PR now. I haven't documented all functions yet, but I'll create a new PR when I continue.

The tests are failing because of a change I made to textstat.rix() after I had read up on the RIX formula:
Anderson (1983) specifies that punctuation should be removed and that hyphenated sequences and abbreviations count as single words. So I added remove_punctuation to the function.
Should I change the test?

@alxwrd, I've merged the type annotations into this branch, so it should be ready again for you to merge it into the base branch. 👍


Formal equiv diff simple_func_width_scope.v

This test is a trimmed down/modified version of yosys/tests/simple/func_width_scope.v
The UHDM tree seems all correct, yet there is a formal verification diff in the gate output. It looks like the plugin is setting func1[0] == ~inp and func1[1-4] == 1, where the correct answer would be func1[0-4] == ~inp
module func_width_scope_top(inp,xn);
	localparam WIDTH_A = 5;
	input wire signed inp;
   	output reg [WIDTH_A-1:0] xn;

	function automatic [WIDTH_A-1:0] func1;
		input reg [WIDTH_A-1:0] inp;
		func1 = ~inp;
	endfunction

	assign xn = func1(inp);

endmodule

Needed issue https://github.com/chipsalliance/Surelog/issues/3346 to be solved too.

The originally spotted issue with simple_func_width_scope.v presented in the trimmed down version of the test could be solved by the fix from https://github.com/chipsalliance/Surelog/issues/3339. However, the full simple_func_width_scope.v failed the formal verification again, and it was caused by a wrong return value from the func call inside the range. It should be fixed by now in Surelog, https://github.com/chipsalliance/Surelog/issues/3346, but fixing it in the plugin is still work in progress.
In the meantime, an issue with the return values from the func call were spotted for another test: https://github.com/YosysHQ/yosys/blob/master/tests/simple/const_func_shadow.v


Diverging implicit with 1-class-recursive-discriminated-union

This causes uPickle to fail with a diverging implicit expansion error:
sealed trait SingleTree
case class SingleNode(value: Int, children: List[SingleTree]) extends SingleTree

write(
  SingleNode(123, List(SingleNode(456, Nil), SingleNode(789, Nil)))
)(Writer.macroW)

It really shouldn't, but I haven't managed to figure out why. Oddly enough, adding a : SingleTree type annotation or removing the children: List[SingleTree] from SingleNode is sufficient to make the problem go away.

scalac also fails to evaluate the SeqishR implicit for the following code:
sealed trait Inline
case class Emph(content: Seq[Inline]) extends Inline

sealed trait Block
case class Plain(content: Seq[Inline]) extends Block

upickle.read[Block]("")

I used -Xlog-implicits and received:
SeqishR is not a valid implicit value for upickle.Reader[Block] because:
hasMatchingSymbol reported error: polymorphic expression cannot be instantiated to expected type;
 found   : [T, V[_]]upickle.Aliases.R[V[T]]
    (which expands to)  [T, V[_]]upickle.Reader[V[T]]
 required: upickle.Reader[Block]
    println(read[Block](""))
                       ^

diverging implicit expansion for type upickle.Reader[Seq[Inline]]
starting with method SeqishR in trait Implicits
    println(read[Block](""))
                       ^

It is probably related to this bug. Note that replacing Seq[Inline] with Seq[String] in Plain makes the error vanish.
I am confused by the type the expression requires. Shouldn't it be upickle.Reader[Seq[Inline]] instead of upickle.Reader[Block]?

Reported by @MasseGuillaume
case class Bucket(name: String, objects: Seq[S3Node])
sealed trait S3Node
case class S3Folder(path: String, nodes: Seq[S3Node]) extends S3Node
case class S3File(path: String) extends S3Node
import upickle._
write(Bucket("a", Seq(S3Folder("b", Seq(S3File("c"))))))
java.lang.AssertionError: assertion failed
        at scala.Predef$.assert(Predef.scala:151)
        at upickle.Macros$.macroWImpl(Macros.scala:49)
              write(Bucket("a", Seq(S3Folder("b", Seq(S3File("c"))))))

default parameters are also not working
sealed trait Node
case class Branch(value: String, nodes: Seq[Node] = Seq()) extends Node
case class Leaf(value: String) extends Node

The original case is fixed in master, @tindzk's case is still borked. Trying to figure out why

Here's a minimal repro of AFAIK what everyone is facing. These fails:
// Doesn't work :(
case class A_(objects: Option[C_]); case class C_(nodes: Option[C_])
case class A_(objects: Seq[C_]); case class C_(nodes: Seq[C_])
case class A_(objects: List[C_]); case class C_(nodes: List[C_])
implicitly[Reader[A_]]

While these work
case class A_(objects: Option[C_]); case class C_(nodes: Seq[C_])
case class A_(objects: List[C_]); case class C_(nodes: Seq[C_])
case class A_(objects: List[C_]); case class C_(nodes: Option[C_])
implicitly[Reader[A_]]

I haven't figured out why, but my $$$ is a bug in scalac's diverging implicit expansion checker which kicks in and kills the implicit search when it tries to cross two different implicits with the same type. This is normally a problem but should be OK in this case because the types in scope for the two implicits are different, so they should give different results.
If anyone wants to help dive into this I'd be grateful

Here's a more minimum repro
case class C(nodes: Option[C])
object Main{
  implicitly[upickle.default.Writer[Option[C]]]
}

Another example:
import upickle.default._

object ImplicitJSONTest extends App {
  case class A(x: Seq[(Int, Int)])
  case class B(y: Seq[A])

  write[B](???)
}

Moot with 0.5.1


Rocket/nightly?

Current Hecate relies on the Rocket web framework, which requires the use of the unstable/nightly Rust compiler. Nightly contains language features that are subject to change, and also breaks occasionally, and at least per the current instructions (which recommend installing the latest nightly), each developer contributing to the project might end up with a different compiler with different features, behavior, and bugs depending on when they happen to set up their dev environment.
Rocket itself doesn't seem particularly close to running on stable (it seems like a project mostly interesting in pushing the language envelope rather than running on stable), and independent of stable vs unstable, the lead dev anticipates a major API overhaul to move towards async as the Rust async story matures.
The ergonomics do seem nice, but in the interests of building on a solid foundation and making it easy for everyone to work on it, I wonder if we shouldn't consider moving to a framework with a stable API that runs on the stable compiler? Nickel seems like a possibility, or if we wanted to get a head-start on async, maybe Gotham ?

Per voice, the server was originally written with Iron as the backend.
Due to problems with the underlying Iron codebase itself - around it handles threads and integrated with Hyper, I moved to Nickel and then settled on Rocket. This was a good move in hindsight as Iron is no longer maintained as of 3 days ago: https://github.com/iron/iron/pull/576#issue-167880860
Talking to the rocket user group on IRC leads me to believe they are being fairly careful about major breaking changes where possible to the external API but as you mentioned above do plan to break once Hyper/Tokio threads stabilize.
I only looked briefly at Gotham but shied away from it as it is still a 0.1 release and had very poor DB connection pooling at the time.
I would propose we stay with rocket with a hard version lock unless we run into a concrete problem.

I'd suggest to check actix, it is fast and runs on stable

Per above going to stick with Rocket unless we run into a significant blocker with the current framework.


style: should not display same error for mutiple times

Now pgwire will display error in https://github.com/singularity-data/risingwave-dev/blob/6161ccb2828b2d5727c74bee31cf708ecb273b38/src/utils/pgwire/src/pg_protocol.rs.
So now sometimes same error message will be displayed mutiple times.  (Some error is traced in kernel, and forward the msg up to pgwire, then pgwire trace it again).
if we do not trace in pgwire, some error may not be printed to log.... Not sure how to do it correctly.

What about ONLY tracing in pgwire?

I think we do not need to display error in pgwire.
Have removed some in #5942  so close this


Composer should attempt retries if it receives rate limiting response from LUIS

With large LUIS models, Composer may receive 429 errors from the LUIS API if too many calls are made too quickly.
We should implement a retry / backoff feature so that Composer can gracefully handle these and still make sure the publish completes.

 The Free Tier is rate limited to 5 request/second so you can easily hit this with even small models.
Related issue #3024

Closing this as a dupe of #3024


[PINOT-3435] Adding segment completion protocol endpoints in the controller Added a utility in the server to find the controller leader

Added unit tests

@mayankshriv I have explained the TODOs

Current coverage is 46.09% (diff: 15.30%)

Merging #359 into master will decrease coverage by 0.12%

@@             master       #359   diff @@
==========================================
  Files           704        707     +3
  Lines         33102      33187    +85
  Methods           0          0
  Messages          0          0
  Branches       4964       4972     +8
==========================================
- Hits          15302      15299     -3
- Misses        16585      16667    +82
- Partials       1215       1221     +6

Powered by Codecov. Last update 082495c...8c4bdc6

LGTM

lgtm otherwise


Configure your ABAP System to Activate OData Services of Fiori Reference Apps

Tutorial URL: https://developers.sap.com/tutorials/cp-connectivity-configure-fiori-reference-apps.html
The photos do not load.

Server it is up again. #


Turn off address space layout randomization on Windows 1809

For some time now the Windows 1809 builds have been failing with this error:
Step 21/56 : RUN C:\cygwin64\bin\bash.exe --login -c "git config --global user.email<EMAIL_ADDRESS>&& git config --global user.name 'Docker' && git config --system core.longpaths true && git config --global --add safe.directory /tmp/opam-sources"
 ---> Running in b77478d60023
     23 [main] bash 2046 child_copy: dll data read copy failed, 0x7FFE79989000..0x7FFE79995FD0, done 0, windows pid 5496, Win32 error 299
     17 [main] bash 2045 dofork: child -1 - forked process 5496 died unexpectedly, retry 0, exit code 0xC0000005, errno 11
/etc/profile: fork: retry: Resource temporarily unavailable
      0 [main] bash 2047 child_copy: dll data read copy failed, 0x7FFE79349000..0x7FFE79355FD0, done 0, windows pid 8624, Win32 error 299
1149520 [main] bash 2045 dofork: child -1 - forked process 8624 died unexpectedly, retry 0, exit code 0xC0000005, errno 11
/etc/profile: fork: retry: Resource temporarily unavailable
      1 [main] bash 2048 child_copy: dll data read copy failed, 0x7FFE79019000..0x7FFE79025FD0, done 0, windows pid 8916, Win32 error 299
3296367 [main] bash 2045 dofork: child -1 - forked process 8916 died unexpectedly, retry 0, exit code 0xC0000005, errno 11
/etc/profile: fork: retry: Resource temporarily unavailable
      9 [main] bash 2049 child_copy: dll data read copy failed, 0x7FFE79019000..0x7FFE79025FD0, done 0, windows pid 5792, Win32 error 299
7452505 [main] bash 2045 dofork: child -1 - forked process 5792 died unexpectedly, retry 0, exit code 0xC0000005, errno 11
/etc/profile: fork: retry: Resource temporarily unavailable
     12 [main] bash 2050 child_copy: dll data read copy failed, 0x7FFE79019000..0x7FFE79025FD0, done 0, windows pid 1496, Win32 error 299
15571150 [main] bash 2045 dofork: child -1 - forked process 1496 died unexpectedly, retry 0, exit code 0xC0000005, errno 11
/etc/profile: fork: Resource temporarily unavailable
docker-build failed with exit-code 254

This can be resolved by turning off address space layout randomization (ASLR) on the cygwin1.dll by adding this line to the Dockerfile after the Cygwin installation.
RUN C:\cygwin64\bin\peflags -d0 C:\cygwin64\bin\cygwin1.dll

https://hub.docker.com/r/ocaml/opam/tags?page=1&name=ltsc2019

Wow!!


Error: 'claude-3.5-sonnet' is not a known model

Hey Simon,
thank you for this amazing tool!
I have installed the latest version of the plugin and llm but it doesn't show the new Claude model. I use brew. Any ideas you could help me out?
I tried
brew upgrade llm
llm install -U llm
llm uninstall llm-claude
llm install llm-claude

I can see in the logs that version is 0.4.0 and llm 0.14.

I found this :D

You're close, llm install needs -U/--upgrade argument to actually upgrade an installed plugin.
https://github.com/simonw/llm/issues/452#issuecomment-2041496452

Perhaps it could be mentioned in https://llm.datasette.io/en/stable/plugins/installing-plugins.html or in the Setup part. :)


Feat: Enhance the navbar styling

Describe the feature
I can make the text highlighted on hover and do the shadowing effect in a more better way.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Please assign this issue to me

please assign this issue to me under gssoc

hii! @arghadipmanna101  ,
I'm GSSoC'24 contributor , I have experienced on HTML, CSS, JS, and react.js , so I want to work on this issue,
so, kindly requested to you to assign me the task.

@arghadipmanna101 can you please tell me on which file is this content located?

Check it you.

@arghadipmanna101 I have done the styling. Please check.

@arghadipmanna101 I've applied styling to the navbar items to enhance its appearance and readability.

@arghadipmanna101 Please check my PR #298


Gradle sync failed: Already disposed: Module: 'android-react-native-maps'  ANDROID

Bug

"react": "16.8.6",
"react-native": "0.60.0",
> "react-native-maps": "0.26.1",

Linking the dependency is failing on ANDROID.
I've done every step in the manual linking for the android and when i sync the project i get the following error :

Gradle sync failed: Already disposed: Module: 'android-react-native-maps'

settings.gradle

build.gradle(app)
implementation project(':react-native-maps')
PackageList.java
import com.airbnb.android.react.maps.MapsPackage;

 new MapsPackage(),

NOTE:
The 'airbnb' in the PackageList.java :
import com.airbnb.android.react.maps.MapsPackage;

is giving  cannot solve symbol airbnb

So my problem was solved by uninstalling react-native-maps, npm uninstall react-native-maps then syncing the project in android studio, after its successfully synced , I reinstalled react-native-maps.
Weird behavior, but this solution seemed to solve my problem !


add a container with a collection of dicomtools

dcm2niix
dcmtk (sudo apt install dcmtk)
dicomviewer (e.g. xmedcon: https://xmedcon.sourceforge.io/Main/Download)

@thomshaw92 - would it make sense to have such a container?

add pigz as well, see #333

I think we already have this container, no?

no, it doesn't exist yet - do you want to build it?

I can do it next week :)
On Fri, 19 May 2023, 3:18 pm Steffen Bollmann, @.***>
wrote:

no, it doesn't exist yet - do you want to build it?
—
Reply to this email directly, view it on GitHub
https://github.com/NeuroDesk/neurocontainers/issues/266#issuecomment-1554006938,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHSAPRQJ3PFSU2L6U7UDGQLXG37DVANCNFSM6AAAAAAV3J375U
.
You are receiving this because you were mentioned.Message ID:
@.***>

this container exists as https://github.com/NeuroDesk/neurocontainers/blob/master/recipes/bidstools/build.sh


Python 3.11 TypeError: can only concatenate str (not "NoneType") to str

always like this when try creating a new project
runs using python 3.11
Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64
Traceback (most recent call last):
File "/usr/local/bin/ryven", line 8, in
sys.exit(run_ryven())
^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/ryven/main/Ryven.py", line 75, in run
editor = MainWindow(editor_init_config, window_title, window_theme, flow_theme, parent=gui_parent)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/ryven/gui/main_window.py", line 70, in init
self.import_nodes(path=abs_path_from_package_dir('main/nodes/built_in/'))
File "/usr/local/lib/python3.11/site-packages/ryven/gui/main_window.py", line 340, in import_nodes
self.session.register_nodes(nodes)
File "/usr/local/lib/python3.11/site-packages/ryvencore/Session.py", line 39, in register_nodes
self.register_node(n)
File "/usr/local/lib/python3.11/site-packages/ryvencore/Session.py", line 46, in register_node
node_class.build_identifier()
File "/usr/local/lib/python3.11/site-packages/ryvencore/Node.py", line 66, in build_identifier
cls.identifier = prefix + cls.identifier
~^~~~~~~~~~
TypeError: can only concatenate str (not "NoneType") to str

PySide2 is not yet compatible with Python 3.11. Indeed Ryven's version requirements currently do not account for PySide2 restrictions. It should do so in future releases.

closed in https://github.com/leon-thomm/Ryven/releases/tag/v3.5.0
you can now use Python 3.11 with PySide6<6.7 pip install 'pyside6<6.7'


When both HTTP and HTTPS ports are specified, monitoring pages may not load

Versions of gnatsd:
0.9.6
OS/Container environment:
Mac OS/X
Steps or code to reproduce the issue:
Start the server with both -ms and -m ports:
$gnatsd -tls -tlscert test/configs/certs/server-cert.pem -tlskey test/configs/certs/server-key.pem -ms 8223 -m 8222
[79215] 2017/05/18 12:42:21.806338 [INF] Starting nats-server version 0.9.6
[79215] 2017/05/18 12:42:21.806437 [INF] Starting http monitor on <IP_ADDRESS>:8222
[79215] 2017/05/18 12:42:21.806513 [INF] Starting https monitor on <IP_ADDRESS>:8223
[79215] 2017/05/18 12:42:21.807302 [INF] Listening for client connections on <IP_ADDRESS>:4222
[79215] 2017/05/18 12:42:21.807335 [INF] TLS required for client connections
[79215] 2017/05/18 12:42:21.807338 [INF] Server is ready

Try to access http://locahost:8222, it may or may not work.
Expected result:
Valid results would be:

Report misconfiguration error
Favor security and start only TLS port
Service both ports properly

Actual result:
Sometimes, one of the port (usually HTTP port) is not serviced properly: page never loads.
It looks like server is checking if HTTP port is specified and if so start monitoring on that (create a listener and starts a http.Serve() on that listener).
It then does the same for the HTTPS port. The problem, I believe, is that it stores the result of net.Listen or tls.Listen in the same server's variable (s.http) and pass this value to srv.Serve(s.http) in a go routine. So race conditions may cause problems.
If the intent was to support both, then I believe that the server should use 2 different variables. If not, I propose that the server starts only HTTPs if both are provided.

@derekcollison Just would want confirmation on the intended behavior and based on that I will submit a PR. Thanks!

Should be a config error IMO if both are set, we should error out.

Problem with that approach is that it is easy to check in main.go and report the error and not start the server, but for people running NATS Server programmatically, with New() and Start() it is more problematic since none of these APIs return an error.
That being said, there are several places in the Start() process where things can fail and we issue a "Fatal", which will cause the process to stop but only if running from main.go, not if running manually with New() and Start(), except if user is setting a logger that exit on Fatal prior to Start(). Is this a reasonable assumption?

We should make the behavior consistent whether starting the executable or programmatically creating a server.

Except that when running from an app, it is a bit like a library, and you would not want the module to cause the whole application to exit just because the module has a problem. But since there is not really a way to surface some of the errors that may occur asynchronously, I understand the point.
Maybe we could have New() set a logger if none is previously set (atm, we do that in main.go) and option NoLog is not set. A quick experiment shows that there would be quite a few tests to fix so that no logging is used.

We should return an error on New().

and Start(), and have all functions called by Start() return an error, etc... that's a big change and will break users that run gnatsd from their app. I did that for Streaming because it was early on in the project, but are you sure for gnatsd?
(PS: See previous comment, an easy fix would be to set the logger in New() as opposed to set it in main. We could set it only if not already set to allow one to set a custom logger prior to calling New()).

ok I see your point. Call FatalF if we try to start HTTPS monitoring knowing that HTTP was already started. But we need to have that FatalF do something. By default I think it prints to stderr, correct? Not sure we need to change around the log placement, although be a nice to have.

As I said, if we move the setting of the logger at the top of New() with the rule: if opts.NoLog is set then clear the (global) logger, else, if a (global) logger is already set, fine, otherwise invoke configureLogger(). Any of the logger we provide will call os.Exit() on a Fatalf call. I still call return after a Fatalf call in case we would have a situation where a custom logger is set and would not exit on Fatal. It is then the user responsibility. If this is not all too clear, I can submit PR or we can discuss next week.

Let's discuss next week.


Update to try_trait_v2 and stable ControlFlow

While std::ops::Try is still unstable, we can privately mirror recent changes to our own copy. Rust 1.55 is stabilizing enum ControlFlow though, which also implements Try for the stable ?-operator and Iterator::try_*, so we can support that as well. Finally, std::task::Poll was stabilized in 1.36, with Try implementations for Poll<Result<T, E>> and Poll<Option<Result<T, E>>>, so again we can mimic that.

bors r+


'Get Customer Profile' doesn't return payment profiles

When following the portion of the sample code from get-customer-profile.php related to retrieving a customer profile, the payment profiles are not returned.  In the sample code
$paymentProfilesSelected = $profileSelected->getPaymentProfiles();
returns an array with a number of empty elements equal to the number of payment profiles present, but none of the payment profile is there.
var_dump($paymentProfilesSelected);
outputs

array(1) { [0]=> array(0) { } }

for a profile with one payment profile.  So the next line of sample code
echo "Profile Has " . count($paymentProfilesSelected). " Payment Profiles" . "\n";
technically works, but is pretty useless.
I am trying to retrieve all payment profile information for a user with more than one payment profile, but can't find a way to do that via this code package.  I do understand that you can retrieve individual payment profiles via AnetAPI\GetCustomerPaymentProfileRequest() but that requires storing the payment profile ids on my side, which just seems silly to have to do, especially when I can see that the API is returning the info I need via the "Try It" function on the documentation page for Get Customer Profile.  https://developer.authorize.net/api/reference/index.html#customer-profiles-get-customer-profile

Hi @RobotPorcupine , I tried the same use case you described, with a profile having 1 payment profile and with another having multiple payment profiles. In both cases, I cannot reproduce the issue you mention.
I also tried both print_r as well as var_dump, and in both cases, I can see all the payment profile information.
Is it possible to share the code you are using to make this request and to parse the response? You can hide all sensitive information.

code
`public static function GetCustomerProfile(\Logger &$log, $id) {
$log->add("Fetch a customer profile from Authorize.net for user $id.");
	$merchantAuthentication = new AnetAPI\MerchantAuthenticationType();
	$merchantAuthentication->setName(static::$LoginId);
	$merchantAuthentication->setTransactionKey(static::$TransactionKey);

	// Retrieve an existing customer profile along with all the associated payment profiles and shipping addresses
	$request = new AnetAPI\GetCustomerProfileRequest();
	$request->setMerchantAuthentication($merchantAuthentication);
	$request->setMerchantCustomerId($id);
	$request->setUnmaskExpirationDate(true);
	$controller = new AnetController\GetCustomerProfileController($request);
	$response = $controller->executeWithApiResponse( \net\authorize\api\constants\ANetEnvironment::SANDBOX);
	if (($response != null) && ($response->getMessages()->getResultCode() == "Ok") ) {
		$profile = array();
		$profileSelected = $response->getProfile();
		$profile['id'] = $id;
		$profile['cust_id'] = $profileSelected->getCustomerProfileId();
		$profile['email_address'] = $profileSelected->getEmail();
		$profile['description'] = $profileSelected->getDescription();
		$profile['payment_profiles'] = $profileSelected->getPaymentProfiles();
		return $profile;
	}
	else {
		$errorMessages = $response->getMessages()->getMessage();
		$log->add($errorMessages[0]->getText(), 2);
		return false;
	}
}`

composer.json
{   "require": {     "php": ">=5.6",     "ext-curl": "*",     "authorizenet/authorizenet": ">=1.9.3"   } }
In the code above $profile['payment_profiles'] is what returns the empty array I described, but I also ran it without alteration to the sample code and got the same result.

So I made a few changes here in order to be able to test your code, but I was able to see the correct response coming in.
Can you add this line at the beginning of your code, after the namespace?
require 'vendor/autoload.php';

Please check again and get back to us, if the issue is not resolved.

It was already loaded outside that file, but I did as you requested with the same result.  I'm stumped.  Obviously the SDK is installed because it's returning other data, and composer should ensure that all files are present.  I did an update which updated the Authorize package from 1.9.6 to 1.9.7, and that also had no effect.  Running PHP v7.2.8.

I found the source of my issue.  All of the data is there, however, all of the members returned by getProfile are private with their own accessor method, which means that I have to individually drill down into all 30 members of the returned object in order to get the all the data for this object.
Sorry for wasting your time.  I just expected a get function to return usable data; this is a very inefficient method for accessing customer data in my opinion, though I do understand the rationale behind the design decision.


Bugs when trying to set definitions for command words – should it be possible?

Command words are set, delete, help, stats and shh and variations...any number of s's followed by any number of h's.
Right now you can successfully set the definition for help with /gloss help = testing but there's no way to retrieve it. Same thing with set and /gloss set set = testing; delete and /gloss set delete = testing; stats and /gloss set stats = testing; shh and /gloss set shh = testing.
It'd be easy enough to throw an error when trying to set the definition of a command word, but it feels weird to just have no way to set & get definitions for these words. But it'd also be weird to have some elaborate way of escaping command words when setting & getting definitions.
Proposed solution – formalize the behavior above: /gloss set <command> = <definition> will set a definition for a command word. The bot will tell the user how to do that if they seem to be trying to define a command word.
To get definitions, it will either understand from context (i.e. a command like /gloss set, /gloss delete or /gloss shh which don't make sense as commands) or require an explicit get, like /gloss get stats or /gloss get help.

I'm handling this as of ee29a075419f3104460fab9a859d1c17396d42a1.
I did a few things:

set is no longer a keyword
single-word command words (help and ?, stats, and learnings) can't have definitions set for them
command words that take arguments (shh and variations, delete) can have definitions set for them in the usual way: /gloss SHH = Sonic Hedge Hog, /gloss Delete = Obliterate


Add doc for snapshot GA

This PR adds doc for bringing volume snapshot feature to GA.

/assign @msau42

/milestone 1.20
/sig storage
/hold pending merge https://github.com/kubernetes/kubernetes/pull/95282
/cc @eagleusb

/assign @eagleusb

/cc @thockin

/hold cancel
k/k pr merged

hi @msau42 @kubernetes/sig-storage-pr-reviews can you provide a tech review / lgtm?

Agree with @kbhawkey's feedback, once addressed LGTM - thanks!

Comments are addressed.  Thanks.

/label tide/merge-method-squash


Fallback to form class fields within CRUDView.get_fields

If I go to the trouble of defining a custom Form for a CRUDView, shouldn't the view just use the fields from that form? As it stands right now, you have to duplicate the fields across the form and view, as CRUDView.get_fields expects either the fields attribute to be defined or for get_fields to be overridden.
Example
Let's say I have a model with a status field that I want rendered as radio buttons in the form.
# models.py
from django.db import models

class Book(models.Model):
    author = models.CharField(max_length=255)

    class Status(models.TextChoices):
        DRAFT = "D", "Draft"
        PUBLISHED = "P", "Published"

    status = models.CharField(max_length=1, choices=Status.choices, default=Status.DRAFT)

    created_at = models.DateTimeField(auto_now_add=True)
    updated_at = models.DateTimeField(auto_now=True)

# forms.py
from django import forms

from .models import Book

class BookModelForm(forms.ModelForm):
    class Meta:
        model = Book
        fields = ["author", "status"]
        widgets = {
            "status": forms.RadioSelect(),
        }

This is what neapolitan expects at the moment:
# views.py
from neapolitan.views import CRUDView

from .forms import BookModelForm
from .models import Book

class BookCRUDView(CRUDView):
    model = Book
    form_class = BookModelForm
    fields = ["author", "status"]

To me, if I've gone to the trouble to define a custom form_class on the view but no fields, it should fallback to the form class.

This is todo with which fields are displayed... — I'm not 100% happy with the API there.
Like it's OK to bootstrap, but you soon end up overriding the list and detail templates for you model, at which point fields drops from use.
Current status: not sure


Alarm fix

Refer to AlarmsHelper.js for adding or changing conditions for the alarm

looks good to me! should get rid of default values at some point


Feature: ios.previewDocument/openDocument custom action button

We are downloading an opening a PDF via this code in our RN application:
RNFetchBlob.config({
    path: dirs.DocumentDir + '/test.pdf'
})
    .fetch('GET', `https://www.ets.org/Media/Tests/TOEFL/pdf/SampleQuestions.pdf`)
    .then((res) => {
                RNFetchBlob.ios.openDocument(res.path());
    })

This works beautifully:

However, in our scenario, we need to prevent the user from sharing the PDF or doing anything else with it besides viewing it. We do however want to offer them the option to save it locally to their phone which we can also use your plugin for. Is there a way to pass some options to the openDocument method which would allow us to put a 'Save' button (instead of that action icon
)
and give us a callback that we can fire when they click on it? Something like:
RNFetchBlob.config({
    path: dirs.DocumentDir + '/test.pdf'
})
    .fetch('GET', `https://www.ets.org/Media/Tests/TOEFL/pdf/SampleQuestions.pdf`)
    .then((res) => {
                RNFetchBlob.ios.openDocument(res.path(), {
                    actionButtonText: 'Save',
                    actionButtonCallback: () => {

                    }
                });
    })

Oh, by the way, on your documentation, I think you need to switch the openDocument and previewDocument methods. It shows the openDocument method as the method that brings up the options menu:

when in fact it's the previewDocument method that does that.

@blackburnian , thanks for the advice, but I'm not sure if this is possible because looks like a platform limitation, it there's any information we can try to do this 😄

@wkh237 I noticed in your documentation, that the UIDocumentInteractionController is used. I did some quick googling about that and found this. If we can set the button to nil, could we also have it provide a value?

I'm subscribed to it. Just left a comment FYI.
On Mon, Nov 28, 2016 at 7:29 PM wkh237<EMAIL_ADDRESS>wrote:

@blackburnian https://github.com/blackburnian , thanks for the advice,
but I'm not sure if this is possible because looks like a platform
limitation, it there's any information we can try to do this 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/wkh237/react-native-fetch-blob/issues/198#issuecomment-263466593,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBCQ54Z-Dr-7BrKRBzu8yQwQVMca609ks5rC5v7gaJpZM4K8vGK
.

@dwilt , I've tried the approach mentioned in the SO thread but it does not work for me, on the other hand, it needs to change AppDelegate.m so I think we are not be able to add this feature to this package.