Get good depth maps without running triton

Hi everyone,
I would like to thank you for your efforts on this open-source model. I am new to computer vision and i want to use your model to measure objects in the real life from any phone camera. I am using the normal maps and depth maps to project point into planes in the 3d space provided by the depth maps. But i can't seem to get the right measurements. I have two questions: 1) when i visualize depth maps directly as they come out of the model without post processing or normalization i get a lot of tearing and artefacts, but when i visualize them after normalization, the depth map looks okay but it lacks details. Is this a normal behaviour or is it because i can't run triton on my windows remote machine (i can't do virtualization or install wsl)?
2) how do i calculate correctly the focal_length_px (in pixels) of my phone camera, should i use the normal focal length in mm that you can find in EXIF data (f_mm * sensor_ppi) or the focal length of the equivalent full frame sensor of 35mm?
Thank you for answering my questions in advance.

Hi everyone, I would like to thank you for your efforts on this open-source model. I am new to computer vision and i want to use your model to measure objects in the real life from any phone camera. I am using the normal maps and depth maps to project point into planes in the 3d space provided by the depth maps. But i can't seem to get the right measurements. I have two questions: 1) when i visualize depth maps directly as they come out of the model without post processing or normalization i get a lot of tearing and artefacts, but when i visualize them after normalization, the depth map looks okay but it lacks details. Is this a normal behaviour or is it because i can't run triton on my windows remote machine (i can't do virtualization or install wsl)? 2) how do i calculate correctly the focal_length_px (in pixels) of my phone camera, should i use the normal focal length in mm that you can find in EXIF data (f_mm * sensor_ppi) or the focal length of the equivalent full frame sensor of 35mm? Thank you for answering my questions in advance.

What do you mean by "normalization"? Could you please post your visualization here?
Both are OK but the calculation procedures are different.
(a) For EXIF data we need to know the CCD width of the sensor and
(b) For 35mm-equivalent data we need to use 36mm as the width.
Focal (by pixel) =  Image Width * focal (by mm) / CCDwidth (by mm)

Personally, I recommend a tutorial provided by Washington University for reference.


Cadastre Redesign - Fair Launch Claim

View For: Any user that starts a claim (single-click on an unpopulated coordinate on the map) during the fair launch period
Current Reference: https://github.com/Geo-Web-Project/cadastre/blob/main/components/cards/ClaimInfo.js & https://github.com/Geo-Web-Project/cadastre/blob/main/components/cards/ClaimAction.js

Display the Auction Details plus existing claim instructions, wireframe 7.1 in the left panel upon the first click of the map when in the fair launch period.
Auction Details (as defined inthe FairLaunchClaimer contract, live updated)

Current Required Bid = startingBid - priceDecrease
Auction End = auctionEnd
Time Remaining = auctionEnd - Current datetime

Upon a second click on the map (parcel shape locked), display the panel as shown in wireframe 7.2

Max Claim Payment (to Treasury) = Current Required Bid
Stream & Stream Buffer calculated/displayed as in other windows

The Wrap to ETHx opens the Wrap ETH modal shown in wireframe 11.1
The Claim button submits the entered data to the appropriate Ceramic stream fields+pinning and smart contract transactions (which require wallet signing)
Display the "Streaming Info Box" defined in https://github.com/Geo-Web-Project/cadastre/issues/94 below the transaction submission buttons.
Conform styling to existing Cadastre styling (wireframes below show functionality and spacing).

Bounty Overview
Size = M
Payment = 500 DAI (for the two issues)
To Be Completed With: https://github.com/Geo-Web-Project/cadastre/issues/95
Assignee =
Bounty Submission
When work is complete, please create PR with your work and request review from both @codynhat & @gravenp. @gravenp will handle logistics of payment with you privately.

@zhyd1997 The main difference here from the simple claim view is checking if the FairLaunchClaimer is currently in an auction. https://github.com/Geo-Web-Project/core-contracts/blob/main/contracts/FairLaunchClaimer.sol#L21-L24

@codynhat
The 2 variables here are BigNumber type, if I convert them to JS Date type, is it correct?

Yea, they should be timestamps in seconds.

Great work @zhyd1997! We'll pay out this bounty this weekend when we do the SourceCred runs.

Bounty paid out here: https://etherscan.io/tx/0x4ff7ff2f9ddce00d21619fb01c2a0e6bf6c93ea96a9cd24c5e0d7dacbaa69104
Thanks again, @zhyd1997 !


text pgtype to oid

Update .travis.yml, added pg.9.6 and pg10
fix#55

Casue PG10 is supported ,is it time to release a new version?


Support for CSS variables

This is nice:
colorCollections: [
  '#FF1300',
  '#EC7878'
]

But it would be great if CSS variables were supported too:
colorCollections: [
  '#FF1300',
  'var(--colorPrimary)'
]

Great suggestion!
CSS variable support will be added soon


chore: add team-deck to CODEOWNERS

In the course of https://github.com/Kong/go-kong/pull/339 I found that while there are team-deck members around during Americas hours, they're not actually allowed to approve go-kong PRs. They probably should be since the library is shared between teams.
Needs a main merge after https://github.com/Kong/go-kong/pull/339 to silence the linter.

Codecov Report
Patch coverage has no change and project coverage change: +0.01 :tada:

Comparison is base (46c44eb) 52.75% compared to head (12658c9) 52.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
+ Coverage   52.75%   52.77%   +0.01%
==========================================
  Files          69       69
  Lines        5093     5095       +2
==========================================
+ Hits         2687     2689       +2
  Misses       1832     1832
  Partials      574      574

Flag
Coverage Δ

2.1.4
36.29% <ø> (+0.12%)
:arrow_up:

<IP_ADDRESS>
46.77% <ø> (+0.11%)
:arrow_up:

2.2.2
36.29% <ø> (+0.12%)
:arrow_up:

2.3.3
36.34% <ø> (+0.02%)
:arrow_up:

<IP_ADDRESS>
47.43% <ø> (+0.11%)
:arrow_up:

2.4.1
36.42% <ø> (+0.02%)
:arrow_up:

<IP_ADDRESS>
47.51% <ø> (+0.11%)
:arrow_up:

<IP_ADDRESS>
47.51% <ø> (+0.11%)
:arrow_up:

2.5.2
36.42% <ø> (+0.02%)
:arrow_up:

2.6.1
36.42% <ø> (+0.02%)
:arrow_up:

<IP_ADDRESS>
47.51% <ø> (+0.11%)
:arrow_up:

2.7.2
36.42% <ø> (+0.02%)
:arrow_up:

<IP_ADDRESS>
49.04% <ø> (+0.11%)
:arrow_up:

2.8.3
36.42% <ø> (+0.02%)
:arrow_up:

<IP_ADDRESS>
49.04% <ø> (+0.11%)
:arrow_up:

3.0.2
35.87% <ø> (+0.02%)
:arrow_up:

<IP_ADDRESS>
49.49% <ø> (+0.11%)
:arrow_up:

3.1.1
37.36% <ø> (+0.02%)
:arrow_up:

<IP_ADDRESS>
50.99% <ø> (+0.01%)
:arrow_up:

3.2.2
37.42% <ø> (+0.02%)
:arrow_up:

<IP_ADDRESS>
50.99% <ø> (+0.01%)
:arrow_up:

community
37.97% <ø> (+0.02%)
:arrow_up:

enterprise
51.54% <ø> (+0.01%)
:arrow_up:

enterprise-nightly
50.99% <ø> (?)

integration
52.77% <ø> (+0.01%)
:arrow_up:

nightly
37.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


EHOSTUNREACH <IP_ADDRESS>:443

I keep gettin this error trying to connect
#```

system: ** Starting Connection from "/opt/companion/bundled-modules/audinate-dante-ddm/main.js" **
system: ** Connection started **
Starting up module class: m
Sentry disabled
Module-host accepted registration
Creating ApolloClient
Getting list of available Domains
system: Status: connection_failure - Network error
[Network error]: {
"message": "request to https://api.director.dante.cloud/graphql failed, reason: connect EHOSTUNREACH <IP_ADDRESS>:443",
"type": "system",
"errno": "EHOSTUNREACH",
"code": "EHOSTUNREACH"
}
system: Status: disconnected - ApolloError: request to https://api.director.dante.cloud/graphql failed, reason: connect EHOSTUNREACH <IP_ADDRESS>:443

This is a network error indicating that you can't reach the host api.director.dante.cloud.


Set Transaction Channels

This is not an issue, more like an enhancement.
Please can you add the channels option where one can dynamically set channels as bank or card.
Or can you add some some directions as to contributing to your library.
Thanks in advance

https://medium.com/consonance/building-an-angular-library-with-the-angular-cli-version-6-384ee85933ad
That's a link to a post I wrote about creating an angular library.
Are you going to make a PR or should I?


define a new Profile entity

new Profile class
create, update and add references using Profile class
replace str with repr, it is easier to debug the objects, use object vars instead of serializing to json.

@pmandler , how to add a new reference to a profile:
client.update_profile(openreview.Profile(referent='~Melisa_TestBok1',
                                         invitation = '~/-/profiles',
                                         content= { 'dblp': 'https://dblp.org/mbok'},
                                         signatures = ['~Melisa_TestBok1']))

this example add the url for dblp site.

It depends on https://github.com/iesl/openreview/pull/1021

This can be merged too

I'm going to add a few tests before merging


added color overlay on the main page video

Implements issue #50
The whole .top-section in the main page has a background color which was set to the blue one, I changed it to the red color from the colors (primary-color) from our code.
And added the opacity attribute to the video, so that the red is visible 30%.

With my second commit, I added color overlay to all the header images.
Changed the class to the top-section, because we are only using one solid color and not a gradient.
Value of the color rgba(237, 93, 93, 0.3); - is the read #ed5d5d converted in rgb.


Lua errors crash Lovr instead of showing error information when t.modules.headset = false in conf.lua

Specs if they help out:
Windows 10
8GB ram
Intel "HD" Graphics Card

Thanks!  This is fixed now.


Property and rest parameter?

(Sorry if this has been reported before. Darn hard to search.)
class A {
    constructor(public ...x: any[]) {}
}

Doesn't work

Doesn't work because it's not a legal production. A parameter can be a parameter property, or rest, but not both. Just a complexity trade-off since this is pretty rare.

I stumbled over the same limitation and don't understand it. I want to do this:
class BoundFunction {
    constructor(private func: Function, private context: Object = null, private ...args: any[]) {}
}

But because the compiler doesn't like this I had to do this:
class BoundFunction {
    private args: any[];

    constructor(private func: Function, private context: Object = null, ...args: any[]) {
        this.args = args;
    }
}

in my opinion this is an inconsistent behavior of the compiler. The args Parameter is a parameter like any other parameter. It's simply an array parameter. So it would be nice if the compiler could treat it as any other parameter and allow visibility keywords in front of it to declare it as a property so I don't have to convert this single parameter into a property manually.


Add epoch to rpm spec

A bad test package with a much higher version number was released downstream. We need to add an epoch to take precedence over it.

/approve

Coverage remained the same at 40.97% when pulling e802752da91af0a111796afdf68430fcfc157087 on jmontleon:add-epoch-master into 4044eab08d4a2078979197eacadabf3fa4b50966 on openshift:master.


Fix beacon lower Y limit

I would have to review the beacon code to check it doesn't do anything stupid but it should be ok for now.


Adding support for SQL Server 2017, 2019

Assuming that SQL Server 2017 and 2019 are supported, they should be added to this doc page.

@twright-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @twright-msft
We can process this PR here in the public repo, but please create future PRs in azure-docs-pr.
Thanks!

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Resolved merge conflict

Hi @bwren - Could you take a look at the PR and let us know if it can be merged? Thanks.

The issue that's addressed in the PR appears to be addressed in master. We'll close the PR. If there are outstanding issues or questions, the PR can be reopened.


adding the docker utility to dcos checks

According to the DC/OS documentation, docker must be installed on all nodes including the bootstrap nodes. This check is will ensure that docker still is running and still is installed. https://docs.mesosphere.com/1.11/installing/oss/custom/system-requirements/#docker
High-level description
What features does this change enable? What bugs does this change fix?
This change is to add docker as a utility that will be checked by dcos-checks.
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-3845 Uninstalled Docker from DC/OS Agents and they still appear as "healthy"

Checklist for all PRs

[X] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[X] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:

I manually tested this PR of DC/OS. I uninstalled docker manually on the machine and confirmed the post start checks failed, then I reinstalled docker manually and confirmed that the test started to pass.
dcos-checks-poststart.service state is not one of the possible states [active inactive activating]. Current state is [ failed ]. Please check `systemctl show all dcos-checks-poststart.service` to check current Unit state.
2018-07-23 17:40:01: "checks": {
2018-07-23 17:40:01: "clock_sync": {
2018-07-23 17:40:01: "output": "Clock is synced\n",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "components_master": {
2018-07-23 17:40:01: "output": "",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "curl": {
2018-07-23 17:40:01: "output": "",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "docker": {
2018-07-23 17:40:01: "output": "Error executing check availability of executable: docker not available\n",
2018-07-23 17:40:01: "status": 2
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "ifconfig": {
2018-07-23 17:40:01: "output": "",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "ip_detect_script": {
2018-07-23 17:40:01: "output": "<IP_ADDRESS> is a valid IPV4 address\n",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "journald_dir_permissions": {
2018-07-23 17:40:01: "output": "directory /run/log/journal has the group owner `systemd-journal` and group permissons r-x\n",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "mesos_master_replog_synchronized": {
2018-07-23 17:40:01: "output": "",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "tar": {
2018-07-23 17:40:01: "output": "",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "unzip": {
2018-07-23 17:40:01: "output": "",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: },
2018-07-23 17:40:01: "xz": {
2018-07-23 17:40:01: "output": "",
2018-07-23 17:40:01: "status": 0
2018-07-23 17:40:01: }
2018-07-23 17:40:01: }
2018-07-23 17:40:01: }
2018-07-23 17:40:01: dcos-checks-poststart.service: main process exited, code=exited, status=2/INVALIDARGUMENT
2018-07-23 17:40:01: Unit dcos-checks-poststart.service entered failed state.
2018-07-23 17:40:01: dcos-checks-poststart.service failed.

[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label ready for review

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label ship-it

Applying the ship-it label as the previous changes were approved and changes.md conflict was resolved with latest change.


fix: update default view engine from jade to pug

fixes #327

@UlisesGascon @IamLizu The checks are failing. I require some assistance on how to fix this...

From what I can see:

It seems like<EMAIL_ADDRESS>has dropped compatibility with the old versions of Node.js that we support (starting from 0.8):
https://github.com/expressjs/generator/actions/runs/12314415858/job/34729590041?pr=328
pug now only supports Node.js@9 and above (see release notes). Ideally, we can include this change in the next major release or upgrade to a version of pug that remains compatible with the Node.js versions we currently support.

So what is the next step? Do I need to make any changes?


The first step of build cube job will fail and throw "Column 'xx' in …

…where clause is ambiguous" in jdbc datasource.

Can one of the admins verify this patch?


npm run dev error

<EMAIL_ADDRESS>dev /home/eco/Downloads/vuetable-2-master
node build/dev-server.js

events.js:160
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE :::8080
at Object.exports._errnoException (util.js:1022:11)
at exports._exceptionWithHostPort (util.js:1045:20)
at Server._listen2 (net.js:1262:14)
at listen (net.js:1298:10)
at Server.listen (net.js:1376:9)
at Function.listen (/home/eco/Downloads/vuetable-2-master/node_modules/express/lib/application.js:617:24)
at Object. (/home/eco/Downloads/vuetable-2-master/build/dev-server.js:59:22)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Module.runMain (module.js:605:10)
at run (bootstrap_node.js:420:7)
at startup (bootstrap_node.js:139:9)
at bootstrap_node.js:535:3
npm ERR! Linux 4.4.0-57-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "dev"
npm ERR! node v7.4.0
npm ERR! npm  v4.0.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>dev: node build/dev-server.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script 'node build/dev-server.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the vuetable-2 package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node build/dev-server.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs vuetable-2
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls vuetable-2
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/eco/Downloads/vuetable-2-master/npm-debug.log

@jericopulvera You probably run something that uses port 8080. Exit that other app and try again
Error: listen EADDRINUSE :::8080


Bazel 3.2 and 3.3 compatibility

The build's passing, but the merge check isn't updating for some reason :thinking:

Because the travis CI integration is broken https://github.com/higherkindness/rules_scala/issues/288 and the build is passing, I'm overriding the merge check.


Allow schema_triggers to participate in a hook chain

Review, @rochoa ? @javisantana ?

As far as I understand this I'm OK with the changes.

Should point out that this is in response to #4


Update next-unbuilt-package.sh to new release schema

Signed-off-by: Jiahao XU<EMAIL_ADDRESS>

@alsuren I will merge this PR since it is quite simple and I've tested it on branch actions


Feature: Tooltip for GBR

Details

This PR implements customized tooltip alignments and adds it to GBR from Concierge DM when a user first signs in.
Fixed Issues

$ https://github.com/Expensify/App/issues/42218
PROPOSAL:
Tests

[Native & mWeb only]

Login with a completely new account
Complete the onboarding flow
Verify a tooltip shows over Concierge chat saying Get started here!

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Same as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@tienifr can you provide an update, please?

@trjExpensify I'm actively working on this, the Slack discussion with team did give a hint about stacking mechanism but I still found no working solution. Odd thing is this only happens with FlashList but not other lists (FlatList, SelectionList...). I'm researching @shopify/flash-list source code to investigate. Expect to find root cause today.

Thanks for the update. Did you get to the root cause?

@dukenv0307 can you weigh in here and help move this along? Thanks!

@tienifr you have conflicts now. Please address them today, thanks!

Yeah it is, @dukenv0307. But I was wondering if you could offer some guidance or collaborate to overcome whatever is preventing us from putting this into review.

I don't really understand the bug we're facing, can you elaborate more @tienifr?

This is a great question. Please share where you're now stuck, @tienifr. 👍

@tienifr once again, requesting an update here please. What's your ETA to have the PR in review?

How did it go?

@tienifr can you prioritising the above today?

I would ideally like for it to point to the avatar vs the pin icon. Is that doable? cc @Expensify/design

With #45390 merged, can we fix up these conflicts and get Duke reviewing?

@tienifr can you put this in review today?

The Web PR is on prod as of like 10mins ago.

Yeah we want this to be a one-time thing. If a user dismissed it, then it should never re-appear

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Implement reflection based en/decoding for map[string]interface{}

Especially the decoder could benefit from an internal map[string]interface{} decoder, so we don't have to parse the json, then hand it to json.Unmarhal (which of course re-does the parsing).

This seems related to https://github.com/pquerna/ffjson/pull/115, though fixing the issue there would require an internal interface{} decoder if I understand correctly.


<IP_ADDRESS>

Published to pypi.

Publishing to PyPI seemed to work fine.
I think nox -s publish_docs published to MY github account pages https://itsayellow.github.io/pipx/
carvel:pipx /Users/mclapp/Library/Python/3.7/bin/nox -s publish_docs
nox > Running session publish_docs
nox > Creating virtual environment (virtualenv) using python3.7 in .nox/publish_docs
nox > pip install . jinja2 mkdocs mkdocs-material
nox > python generate_docs.py
nox > mkdocs gh-deploy
INFO    -  Cleaning site directory
INFO    -  Building documentation to directory: /Users/mclapp/git/pipx/site
WARNING -  Version check skipped: No version specificed in previous deployment.
INFO    -  Copying '/Users/mclapp/git/pipx/site' to 'gh-pages' branch and pushing to GitHub.
INFO    -  Your documentation should shortly be available at: https://itsayellow.github.io/pipx/
nox > Session publish_docs was successful.

Also it looks like previous edits to the Contributing page haven't showed up on https://pipxproject.github.io/pipx/contributing/

So to publish everything from pipxproject/pipx from master, I assume that requires special permissions that I don't have?  Or is there someway I have access to pipxproject/pipx ?

The docs are served from the gh-pages branch, which you may have access to commit to directly.

Can you add a release?  I don't think I'm able to do that.

Sure, what was the commit you uploaded to PyPI?

I think I just fixed the docs on https://pipxproject.github.io/pipx/ .
What I did was make my gh-pages branch track upstream/gh-pages and then ran
nox -s docs
nox -s publish_docs

I think the docs are updated properly now on https://pipxproject.github.io/pipx/
Let me know if that is improper or wrong.

I think I just fixed the docs on https://pipxproject.github.io/pipx/ .

Actually it appears that I'm not allowed to push to pipxproject/pipx.git, so I did not update the docs.


[GHSA-w6x2-jg8h-p6mp] Path Traversal in TYPO3 File Abstraction Layer Storages

Updates

Affected products
References

Comments
Adjusted Git commit references...
(each of those commits references back to the CVE Security-References: CVE-2023-30451)

Hi there @ohader! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

Hi there @ohader! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

Sure, I approve the suggested improvements by community member @ohader! 😄


E2E utils (correcting test regression)

Hi again @roberthbailey .
I've recasted the PR into 3 commits to make it easy for you to evaluate.

Reverts the reversion.
Fixes the issue (specifically, it solves and disambigauates the jpg fields, so that this test is clear as to what exactly is being validated, while retaining modularity of the original refactor).
Modified kubectl to be a constant.

I've tested this on a local machine, but I don't have a cloud provider account, thus only 3/4 tests pass.  here are the results :) After this, we can follow up w/ #6028 , so that all the tests pass locally and the cloudProvider testing is done in another place.

Thanks alot for helping me with this PR.  I think I really understand the idiosynracies of the e2e tests, and golang itself, much better now.

Once you respond to comments, feel free to squash commits into 2 (one for the rollback and one for all your fixes) and ping this issue. I'll patch locally and verify that the e2e tests work on GCE before merging this time. :)

I just played some with helper function.   it was a good idea, but In the end, I didn't keep it because , it doesnt simplify the code as much as i thought it might - and also created more indirection...  and things like "defer" couldnt be handled inside of it... open to adding it if you really feel its necessary.  maybe a follow on i can think of a really good way to do it.
other comments addressed and updating the pr now !

okay, repushed (build was down).  looks like build is back on track.  I ran tests locally best i could, and 3/4 passed.  Just let me know if anything else to look into.

hi @roberthbailey ,   in case any other stuff i should  do ....  if you are busy today  im open to maybe trying on a free instance gce cluster or something.

Sorry, I've been distracted all day. I'm patching this in locally now to run e2e tests.

I've run the e2e tests 10 times:

Run #
Result

1
failed

2
failed

3
passed

4
passed

5
passed

6
passed

7
passed

8
passed

9
passed

10
passed

The first two failures were due to #5821 which @quinton-hoole is actively working on and also affects the existing code.


Docker Dev Env?

Title
Expected Behavior
Description
Observed Behavior
Description
Steps to Reproduce

Step 1
Step 2
Step 3

Look it's a resource Some dude who likes this

where are we??????


Feature Suggestion: CLC shell?

Is it interesting to have a centurylink cloud shell?
Now that the node.js sdk is in place, customers can build apps to manipulate their accounts/assets. Is a shell built on top of this sdk interesting. I am thinking of something similar to the mongo-shell where you have command line access to all functionality. I use this a lot as a playground and to prove functionality before coding it in an app or just because it is easier: you can redirect a shell script to the shell and it executes the commands.

Hi,
We can add following improvements for clc-node-sdk:

Repl based cloud shell with command line access to all functionality. This CLC CLI will login to clc-node-sdk by username/password, do some pre-initialization action and activate Nodejs REPL based shall

Additional clc-node-sdk cloud shall module, that will have web based cloud shall like
http://www.web-console.org/
This module will be installed on the remote server and allow user used Repl based cloud shell remotely


Best way to determine if user is still logged in?

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.16.1
Wrapper Library
Not Applicable
Wrapper Library Version
None
Description
Hi Team,
What is the best way to determine if the user has a valid session?
I read on a few stackoverflow threads that we can use getAllAccounts nut that returns cached accounts as per my knowledge.
Is there a better way?
Thanks!
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

@ktikku Correct, the MSAL account APIs will read cached accounts, which may be out of sync with the server. To check if the user still has an active session, you will need to invoke a network request to the server, either via loginPopup, loginRedirect, ssoSilent, or acquireTokenSilent (with forceRefresh set to true). Which one you use depends on your scenario and your desired user experience. Can you provide more details on your desired outcome in this context?

And generally speaking, we tend to recommend that applications invoke network requests reactively (as a result of an error, e.g. acquireTokenSilent returning an interaction required error), as opposed to proactively.

@jasonnutter
We wanted to have a method which checks for the active session and returns false if the user's session has expired.
Currently we're invoking acquireTokenSilent to check if we're able to renew the token, and if not we're catching the error and returning false.
But this method renews the token, and is just promoting keeping tokens alive forever without the user’s knowledge :/
Thoughts? 😄

We wanted to have a method which checks for the active session and returns false if the user's session has expired.

@ktikku Out of curiosity, why do you want to do this? What are doing based on the result of this operation?

@jasonnutter we have a middleware which is invoked on client side routing, we want to logout the user of SPA if they don't have a valid token.


Use python3

Switch to Python 3 as Python 2 has ended its support on 2020-01-01.
(https://www.python.org/doc/sunset-python-2/)

Duplicate of #441.
The problem is that I still want to run the tests against python 2 also. Currently this works quite well by just changing /usr/bin/python between python 2 and python 3 in the docker file. I guess I could symlink python3 to python2 in the docker, but that seems a bit silly. And anyway, completely dropping python 2 support would be a breaking change and as such post-poned until next major release.
But.. shouldn't distributions just switch /usr/bin/python to be Python 3?

I'm using nanopb on OS X and home brew removed their support for python2, so I'm kinda forced to use python3. Of course I can point /usr/bin/python to python3, but this would break other incompatible scripts. As those scripts work with python3 I think changing the shebang is the correct approach.
When are you aiming for the next major release?

When I run out of numbers for 0.4.x ;)  Probably still a few years away.
If you don't have Python 2 on the system, I don't see how the symlink would break anything worse than they are already broken. Or is the issue that you don't have the protobuf libs for Python 2? That's a bit annoying indeed. pip3 install nanopb would be one way to go about it, or python3 nanopb_generator.py. I didn't really think about the the python-protobuf dependency when writing the comment above, but that makes it even more difficult to switch the shebang - if someone has the protobuf library installed for Python 2, switching it now would suddenly break their builds without any easy to way to fix it.
PEP 394 is quite a mess these days.

OS X provides only python2.7 by default and sets python to this. However there is no pip provided by OS X, so installing python-protbuf is a pain. Almost everybody on OS X uses https://brew.sh to install tools like python and there only python3 with pip3 is provided.
At some point in time this will break for users and if the next major release is years in the future I suggest to do it rather now than later as currently the dying of python2 is in people's mind anyhow. But this is just my 2 cents.

Yeah, I don't know either what is best - all I know is that the change would break my test systems, and that is a quite good indication that it would break things for many users also. So far I've prioritized backwards compatibility quite strongly, but it is a good point that it is difficult to work around the problem on Mac OS X.
One way would be to have some kind of automatic fallback to Python 3 if python-protobuf cannot be imported, but I'm not sure if there is any sane way to accomplish that.

After consideration, I've made this change to newest git master and it will be part of 0.4.2 release.


Documentation

This pull request adds initial documentation using Sphinx and reStructuredText. I think that the README will be leaner.
My suggest is host the documentation in https://readthedocs.org/

Rael had already suggested this. We'll keep using README for now, but I'll keep this PR open so we can do it later on.


fix(docker): optimise start/stop docker-compose

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Refactoring (no functional changes, no api changes)
[ ] Other... Please describe:

What is the current behavior?
unnecessary copy/paste .env file into docker-composefolder every time on start/stop tasks
What is the new behavior?

remove unnecessary copying .env file into docker-compose folder and remove this file every time if user start or stop container.

FIX: you can specify your dc-file by using -f flag to define your custom path!

additionally you can specify your .env file by using --env-file flag:

Example: --env-file=.env
Does this PR introduce a breaking change?

[ ] Yes
[x] No

close


hysteria: 1.1.0 -> 1.2.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build hysteria

How do you use this package if there is no attribute hysteria to build?

How do you use this package if there is no attribute hysteria to build?

sry I missed this, now added.


gitignore bug (debug.log)

VSCode Version:Version: 1.49.0-insider (system setup)
OS Version: Windows_NT x64 10.0.19041

Steps to Reproduce:
Not sure what I did/do to get this debug.log file but I keep getting it. Tried searching for the error code which is:   [0821/234950.089:ERROR:registration_protocol_win.cc(103)] CreateFile: The system cannot find the file specified. (0x2)
`
But couldn't find what it meant online. Anyhow, so I included this debug.log file to my gitignore (.log [the gitignore file is in the parent folder.) and it worked the first time but when I close VSCode and reopen and work on the project I see the debug.log file in the source control tab. So, this time I edited the gitignore to a more specific targeting (Directory/.log) but nope.
I guess whenever I get more error logs and debug.log file gets updated, gitignore is somehow losing it's target?
One other thing I noticed is that gitignore is ignoring other debug.log files in other folders except this Theme folder.
The file structure is like this ~/folder/theme/themes
The debug.log files from "folder", "themes" and other debug.log file is getting ignored but not from the THEME folder which is weird since the "theme" folder is in between the main folder and the sub-folder of theme... Not sure if this is happening because other folders are not getting the debug errors and only the debug.log file from the Theme folder is? that' I'm not sure since I don't know what the error message means so I can't reproduce the error to check this... Sorry... If you know what the code means please let me know and I'll try to diagnose this further. Thank you.
Also, is there a way to disable it somewhere? So that this debug.log file doesn't get created?

Does this issue occur when all extensions are disabled?: Yes

Hey, this started occurring for me on 1.49.0-insider too. Seems to be adding [0827/160710.691:ERROR:registration_protocol_win.cc(103)] CreateFile: The system cannot find the file specified. (0x2) to the debug.log file whenever any system-level functionality is being used, such as language server API usage (JSON, dockerfile, ...), even using the integrated terminal, any commands entered to the terminal write to console the above-mentioned error.
Out of curiosity @hiredtocode, does it occur when you have a vscode instance open in windows whilst having a vscode window opened with WSL?

Hey @JBrLloyd to my memory this happened in normal and WSL mode. I've created a new bug report about this issue as requested  and here's the link: 105191.

I solved this problem by uninstalling and installing vs code

@Joandysson reinstalling vscode also resolved the issue for me!

i reinstalled vscode but still have this problem

Having the problem to. For me it began right after the recent windows update.. If there is a connection.. IDK.

Unfortunately, recently started to get the same issue. I am afraid I don't have the exact steps to reproduce the issue.

Also experiencing this issue.
The log file appears in whatever folder I'm currently working in. Multiple log files appearing when working across the project. More appear as I try and delete the existing. Very annoying when trying to push changes back up to Git.

Facing the same problem.
any solution??

I git clone my repo and this file appears when i open the project in VS Code.
VS Code is unable to Discard changes.
I added it to .gitgnore
then was able to delete it
Very bizarre.

Had the same issue, uninstalling and installing the latest version seems to have fixed the issue.

same iss

This has been fixed in latest stable 1.49.2, please update to it. Thanks!
Ref https://github.com/microsoft/vscode/issues/105191 for details.

thanks


Russian localization Update

Details of Changes
Add details of changes here.

Added untranslated Russian string

@farag2 thank you for the pull request, we recently started using Crowdin to manage translations, can you make this change through Crowdin?


TryInstall functionality

Background
I use NVM to manage my node versions. It comes with a handy little script (https://github.com/nvm-sh/nvm#zsh) for ZSH, and one for bash, that will automatically run nvm for you when you change directories.
This behaviour would be useful in this tool too.
Challenges
1. Automatically run the tool whenever you change directory
I've knocked up a zsh script to do this.
autoload -U add-zsh-hook
load-dotnet-install-sdk() {
  dotnet install-sdk
}
add-zsh-hook chpwd load-dotnet-install-sdk
load-nvmrc

2. Only install if we can find a global.json
Currently the tool crashes if there is not a global.json in the current working directory.
Proposal

Modify GlobalJsonLocator.cs to look up the directory hierarchy until it find a global.json. This means that the tool will find the file even if you are in a sub-directory of your project.
Improve error handling when the file is not found to allow tool to NOOP, rather than throwing the error out to the user. This behaviour could be enabled by a flag so that silent failure is not a default behaviour.

Good suggestions here. My only thought is that we don't need to do as much as nvm here in this tool, as the dotnet cli host process does the "auto switching" for us for free.
This tool only comes into play for acquisition of installers, and it doesn't do it unintended (although I'm working on changing this).


CSS based line numbers don't match actual line numbers

There's 1 - 5 line margin of error on the line numbers on the student facing code review site. This is important for students looking at code review because the comment can be line sensitive.
This links to issue #381 - I think it's worth moving off a css dependent approach to line numbers and adopt the codereview/diff view of the admin. All we have to do is tweak some CSS - but this will become much easier when we transition over to using a CSS framework for the frontend.

@alvinwan - Any updates on this? This will be important to have fixed before the next set of code-review is published

taking a look at it now


No.

During the clarification of creating a chatbot like ChatGPT, I get to: "No."

+1, I have the same issue (using 3.5)

+1

Me too :hand:

lmao, i like how its so matter of fact about it. "No."
But yeah, same issue..

I have the same issue

What exactly is it having a problem with when it just spits out No? lol I get this often as well. Anyone able to explain what causes it?

Probably having a bad day :)

It seems like here on line 46 is where the model is being asked to respond with "No.":
https://github.com/AntonOsika/gpt-engineer/blob/25a6c31d4f7b550b2efccce8a260dbe43778ea4a/gpt_engineer/steps.py#L41-L47
If you just enter 'q', it should continue. The AI is just telling you that the task is now sufficiently clear.

I have seen this or something very similar in a lot of other issues, I have also seen it myself when running the app.
It might need a bit of digging imo.
Maybe correction of the prompts and/or better handling of the outcome.

Fixed in commit 6a3f7eb


⚠ Bofrost.com has degraded performance

In ec2b91d, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 424 ms

Resolved: Bofrost.com performance has improved in 0e23d55 after 7 minutes.


tvOS compatibility

Due to time limits I didn't handled tvOS as a second target but I simply adapted the project removing or changing the conflicting parts of the code.
The best thing would be to create a new target and manage code blocks using #if TARGET_OS_IOS or #if TARGET_OS_TV as you made in your tvOS branch of SRGMediaPlayer

Thank you for your PR. It was an help to push this feature at the top of our backlog.
We just delivered the 4.0.0 release, with an official tvOS support.
We recommend to use this new release, and give us any feedback.


Fix cf pushapp for cf cli v8

Description
Since the update to the CF CLI Version 8, the Client tried to use the CC v3 API.
A backport vor v7action was done, together with a better detection of LogCache-Endpoints.
Motivation and Context

Being able to Push Apps directly through Stratos again
Resolves (issue 49)[https://github.com/cloudfoundry-community/stratos/issues/49]

How Has This Been Tested?

start stratos locally or use an existing deployment
use (cf-example-staticfile)[https://github.com/govau/cf-example-staticfile] for start a deployment

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Docs update
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

This Fix is not 100% complete.
What still doesn’t work, is the Update of the  FrontEnd after the Deployment is finished.

The Summary Buttons are still deactivated even where the Notification recognizes the deployment.
So there must be a Problem here i guess:  If anyone is able to look at this, we would greatly appreciate some input from the community


BUG: fixes in norm and axes handling

Hi Peter,
With these two small fixes the tests pass locally for me aside from when using NumPy 1.17 which has different error types due to cupy/cupy#2361(numpy ZeroDivisionError issue).
The second commit here makes _fftn behavior consistent with NumPy (I verified for both 1.16.4 and 1.17.0). However, this does make the behavior inconsistent with scipy.fft. I opened scipy/scipy#10588 to suggest changing scipy.fft's behavior to match NumPy.
Note: The shape/axis handling as proposed here was already being done this way in the 1D cupy.fft._fft function, the problem was only in _fftn.

Thanks a lot @grlee77

@grlee77 I'm still seeing test failures for rfft and hfft as well as the NumPy ones. Do you get these as well?

I'm still seeing test failures for rfft and hfft as well as the NumPy ones. Do you get these as well?

I'm not sure, I might have missed them among all the ZeroDivisonErrors. I can take a look later tonight.

For me there are many more of these than the NumPy errors so it sounds like you might not be getting them.  I'll try to get to the bottom of it in the mean time.

I just checked again and I only see the numpy 1.17-related failures. I will open a separate PR with a small fix for that.
Which CUDA version are you running? I have been testing with 10.0.

I'm using cuda version 10.1


UM-338: Handle connection timeouts

Restler emits a timeout event that's not being handled, so the promise is neither resolved nor rejected. I suspect this is the root cause of the marketo integration getting into a state where the SQS queue is not being checked.
cc @mirceal @peaches

LGTM :shipit:


Updated to lastest API 0.61.0

Updated to lastest API 0.61.0

POGOProtos needs an update before I'll release a new NuGet, but this is good so far thanks 👍


--report-assign flag for check command

Summary
This flag should tell autopep695 to report type parameter assignments as an error.
Why is this needed?
As of right now, type parameters are only brought up if used in a TypeAlias context or if they are specificed in a function or class definition. It might be desired to also report all type parameter assignments. This should not be the default because it unneccesarily increases the command output for big codebases.
Ideal implementation
To be decided.
Checklist

[X] I have searched the issue tracker and have made sure it's not a duplicate. If it is a follow up of another issue, I have specified it.

Call it report-assignments for consistency with `format|


Healthcheck v2 failed

fix #13520
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[x] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

@liudezhi2098  The test is already covered by org.apache.pulsar.broker.admin.AdminApiHealthCheckTest#testHealthCheckupV2Error
The previous unit test testHealthCheckupV2   created a heartbeat namespace Manually before running health check.
But, In fact, the heartbeat namespace would not be created  in cluster.

This PR looks like adding some tweaks specific for this special topic.

@eolivelli  The direct reason  is  that heartbeat namespace was not created. just registered by registerBootstrapNamespaces during startup. The optional fix maybe, we can create this heartbeat namespace during startup.

/pulsarbot run-failure-checks

There may also be namespaces under the pulsar tenant that are not for healthcheck. For example, it is possible for a user to create a namespace named pulsar/test. For such namespaces, we should not skip these checks.

There may also be namespaces under the pulsar tenant that are not for healthcheck. For example, it is possible for a user to create a namespace named pulsar/test. For such namespaces, we should not skip these checks.

Fixed in the last commit.

I think NonPersistentTopic.java should be modified as well as PersistentTopic.java.
https://github.com/apache/pulsar/blob/ef42af2803e0d8b8141331807a0549c4d3277361/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java#L521-L525

/pulsarbot run-failure-checks

The https://github.com/apache/pulsar/pull/14658 cherry-pick this PR to branch-2.9.


Should solr_ead specify Rails as a dependency?

solr_ead seems to use both ActiveSupport and Rails which probably should be specified in the gemspec.

Agreed, you shouldn't need Rails.


Blogpost 18

Issue description
Describe your issue in detail here
Blogpost 18

[x] #71
[ ] #155 - won't be in this Blogpost
[x] VisualGameData/VIGAD-API#13
[x] #116
[x] #180
[x] #184

Definition Of Ready (DoR)
This issue can be worked on if

[x] a developer is assigned
[x] the issue is labeled
[x] the issue is assigned to the current sprint
[x] the issue is estimated
[x] a meaningful title has been set
[x] the issue is described in detail

Work in progress blog: https://wordpress.com/post/vigad.wordpress.com/570

Live Blog:  https://vigad.wordpress.com/2023/06/01/18-metrics-data-uploading-and-so-much-more/


Grab setuptools from pex >= 1.6.0.

Fixes #6

@jsirois @benjyw this can be merged now, right?

Presumably? I'll let @jsirois have the final say

I'll feel better when CI is setup (coming shortly), but this still passes the relevant tox environments so I'll merge and move forward to get things ready for a release.


Dev/kduran/us vbs22 41 deshabilitación y eliminación de usuario

Added the functionality to delete (logical delete) of users and list users. Also made the unit test for both of these tasks

@mur-tz @DieS06 @ichivancrCenfotec  please could  you check this branch, if it's ok to merge it to the development


Bug: config-reloader fails when posting to the /-/reload endpoint

While debugging some issues we discovered the following errors  in the config-reloader containers from the collector daemonset.
level=error
ts=2022-02-24T14:09:50.588593579Z
caller=runutil.go:99
msg="function failed. Retrying in next tick"
err="trigger reload: reload request failed: Post \"http://localhost:19090/-/reload\": dial tcp [::1]:19090: connect: connection refused"

The problem is located in the daemonset:
# k edit daemonset collector -n gmp-system

...
      - args:
        - --config-file=/prometheus/config/config.yaml
        - --config-file-output=/prometheus/config_out/config.yaml
        - --reload-url=http://localhost:19090/-/reload      <--- THIS SHOULD BE PORT 19091
        - --listen-address=:19091

It briefly works when correcting the port, but then I think the operator overrides my edit and goes back to the broken config.

The port should be correct with 19090. The reloader triggers a reload in the prometheus container when it observes a configuration change. The 19091 is just the port the config reloader reports metrics about itself on.
How often and when do you see the initial error? It could certainly happen when the config reloader container starts before the Prometheus container. Then attempting to trigger a reload would log the error.
That would not matter however as Prometheus would read the most recent config file on startup anyway.
If you observe the error after both containers have started successfully, that could indeed be a problem.

Ah, I didn't see any errors after modifying the port, so I wrongly assumed that my edit did something useful.
It's now clear that the error tends to occur right after a pod has started: it's probably just a race-condition thing.


Add logic to run swift dispersion populate if not run

Adding some comments
Fixing comments and pep8

tested this on Rainier .... changes worked fine.
On first check it ran swift-dispersion-populate and check report ok

Closing in favor of adding this check as part of ursula


fix(html/minifier): fix bugs with smart mode

Description:
Better logic and avoid bugs
BREAKING CHANGE:
No
Related issue (if exists):
No

@kdy1 FInished and ready to review
I rewrite logic, previosly has design problems with found whitespaces


vibe.d test hangs for several seconds before running event loop

Reproducible on the CI server with v0.8.0-118-gbe6862a and  v0.8.0 in with tests/vibe.core.net.1726.
Apparently responsible for the failing tests https://ci.dlang.io/blue/organizations/jenkins/dlang-org%2Fdmd/detail/PR-6993/3/pipeline#step-700-log-2012.
I've attached --vvvv and strace logs and marked the lines where it hangs.
hang_strace.log.txt
hang_vibe_d.log.txt
Hope that helps to locate the cause.
libevent version is 2.0.21-stable-2ubuntu<IP_ADDRESS>

I'm seeing some huge GC heap usage and lots of time in newArray and in evbuffer_add.
What's the point of sending 512MB over the wire?
https://github.com/rejectedsoftware/vibe.d/blob/ddae95929bea78aab84aca12aede653129beef2f/tests/vibe.core.net.1726/source/app.d#L8
Apparently this is supposed to fail for some reason but keeps running for quite a while until it does.
BTW, those 2 listenTCP calls collide cause the socket is still bound by the first listener.

I accidentally broke the test when I tried to improve it (fooled by it seemingly passing). The listen issue, as well as the event loop interaction have been fixed now.
The intention is to not send any data at all, but to just fill the output buffer and have the write call block. The question is why the mmap call is invoked with 1 GiB instead of with 512 MiB. I'm not sure where the hang comes from, though. It seems to hang in epoll_wait before write was even called.

Looks like simply lots of memory was hogged in the page cache (and btrfs caches), and it took the kernel ages to migrate and compact pages. So nothing specific about vibe.d. Using an uninitialized array might work around such problems.


Not support VoiceOver

Describe the bug
It doesn't support VoiceOver, VoiceOver can't read card number/cvc/exp for blind user, and as a developer, I have not found a way to make it support VoiceOver, because card number/cvc/exp is not accessibility.

Hi @iLabsJason.
Thank you for reporting the issue.
We will check is it possible to add accessibility attributes for the underlying labels.
I suppose you are interested in accessibilityLabel and accessibilityHint.
Could you please list more attributes you need or describe your use case.

@EugeneIOs Thanks for your replying.
I have a blind user who want to get the full debit card number, cvc, and exp. But we can't get full debit card number, cvc, and exp in code and set them to accessibilityLabel, so I think the only way is to ask the SDK support it.

@iLabsJason
Please check release 1.1.4 and vgsAccessibilityLabel attribute.

@EugeneIOs Thanks for your updates.
But I think you have missed to set isAccessibilityElement to true for the label.

@iLabsJason
As I checked setting vgsAccessibilityLabel implicitly enables isAccessibilityElement automatically under the hood for UILabel.
So no need to set it explicitly to enable accessibility.

Thanks!


Update ingest/change_compactor with extended Change struct

Related to https://github.com/stellar/go/issues/5535
The change_compactor should be updated to use the new fields in the Change struct
New fields:

Reason
OperationIndex
Transaction
Ledger
LedgerUpgrade

None of the existing Type, Pre, Post field logic needs to be changed.
The compacted changes from AddChange(change Change) should take the most recent fields from above if there is already an existing change for c.cache[ledgerKeyString]
For example in https://github.com/stellar/go/blob/master/ingest/change_compactor.go#L152-L166
	switch existingChange.LedgerEntryChangeType() {
	case xdr.LedgerEntryChangeTypeLedgerEntryCreated:
		// If existing type is created it means that this entry does not
		// exist in a DB so we update entry change.
		c.cache[ledgerKeyString] = Change{
			Type: key.Type,
			Pre:  existingChange.Pre, // = nil
			Post: change.Post,
			Reason: change.Reason,
			OperationIndex: change.OperationIndex,
			Transaction: change.Transaction,
			Ledger: change.Ledger,
			LedgerUpgrade: change.LedgerUpgrade,
		}

Alternatively instead of propagating the latest Change.Reason/OperationIndex/etc... to c.cache[ledgerKeyString] = Change{} it is possible to keep the existingChange.Reason/OperationIndex/etc... instead of change.Reason/OperationIndex/etc.... This would be the less preferred option from stellar-etl

@chowbao It would be helpful for my understanding if you could explain how these new fields can be used (with an example?). Thanks!

@chowbao It would be helpful for my understanding if you could explain how these new fields can be used (with an example?). Thanks!

Of course
So in stellar-etl we would use the changes to add new columns to some of our tables. For example, our contract_data state table that records the compacted ledger entry changes for contract_data. New columns that would be helpful for us to add would be like the transaction_hash or ledger_sequence that the compacted change occurred. This is nice because now we wouldn't have to manually pass the LedgerCloseMeta as we process changes (Ledger already in the change).
stellar-etl currently has this flow in the code if that helps clear things up as well

Change compact the changes
Transform/process relevant contract data changes
Pull information from the LCM header passed in the function instead of being in the function itself
Output and upload to data lake to ingest into BigQuery (Hubble)

By also passing new fields like OperationIndex and Transaction we can also reasonable add new columns to the contract_data table like transaction_hash or operation_id that is tied to the change

We will copy and modify the changeCompactor for stellar-etl only within go/stellar-etl
The changeCompactor within the stellar/go/ingest will not be changed


ModuleNotFoundError: No module named 'shap'

I get this error when I import evalml in my notebook.

Hi @esitharth thank you for filing an issue! Are you running on windows? I think something must have gone wrong during the shap installation that happens when pip install evalml is run.

Yes I am running on windows. pip install shap throws an error message as well during setup.py install for shap. Error is ' ERROR Command errored out with exit status 1:

Hi @esitharth, yea shap has poor support for windows. Can you try installing evalml with conda, conda install -c conda-forge evalml ?

I tried conda install -c conda-forge evalml.
evalml got installed.
But when I tried
X_train, X_test, y_train, y_test = evalml.preprocessing.split_data(features, target, problem_type='regression',  test_size=.25)
It throws an error
TypeError: split_data() got an unexpected keyword argument 'problem_type'

Code is as follows:
import evalml
df = pd.read_csv('TrainingData-PymtDate-Pred.csv')
features = df.drop(['Unique Invoice & Date', 'Transaction Type Description', 'Follow Up Date', 'Service Date' ], axis=1)
target = df['delta']
X_train, X_test, y_train, y_test = evalml.preprocessing.split_data(features, target, problem_type='regression',  test_size=.25)

@freddyaboulton @dsherry putting this in this sprint.  If no action is required, we can close.

@freddyaboulton @chukarsten I tried running this on windows with python 3.8.10 and a fresh virtualenv, and I wasn't able to reproduce the shap issue that @esitharth ran into. Additionally, I was able to split the data without problem.

Thank you @bchen1116 ! Closing.


Doesn’t work locally

The index page reports this message: "Recording not found"
I think there is a problem with "CORS policy: Cross origin requests"

For viewing the downloaded presentations, they need to be served via a HTTP server. The playback components will not be able to access all needed resources via normal local file access. This is due to default CORS security policy behavior browsers employ.


feat(supabase): adds real-time post views with supabase

The increment_post_views function is not working. I cannot get it to work in the query builder in my SupaBase.io dashboard and the POST resolves with a 504 from the app. The views count does get incremented on every page reload though????
Still gonna need to do a lot of work on this PR, moving back to WIP.


Mutations support

Supporting mutations for inserting / updating data is a very useful next step.

It would be good to be able to detect if a table has an auto-incrementing primary key - if it does, an insert can be supported by providing the non-primary-key columns. If not, then inserts will also need to include the desired primary key.

Graphene docs: https://docs.graphene-python.org/en/latest/types/mutations/
import graphene

class CreatePerson(graphene.Mutation):
    class Arguments:
        name = graphene.String()

    ok = graphene.Boolean()
    person = graphene.Field(lambda: Person)

    def mutate(root, info, name):
        person = Person(name=name)
        ok = True
        return CreatePerson(person=person, ok=ok)

class Person(graphene.ObjectType):
    name = graphene.String()
    age = graphene.Int()

class MyMutations(graphene.ObjectType):
    create_person = CreatePerson.Field()

# We must define a query for our schema
class Query(graphene.ObjectType):
    person = graphene.Field(Person)

schema = graphene.Schema(query=Query, mutation=MyMutations)

Then:
mutation m {
    createPerson(name:"Peter") {
        person {
            name
        }
        ok
    }
}

Maybe the configuration that defines these should use YAML (or JSON) strings containing the GraphQL type language.
https://graphql.org/learn/schema/
input ReviewInput {
  stars: Int!
  commentary: String
}

The graphql-core library (which graphene already depends on) has a parser for the GraphQL language: https://github.com/graphql-python/graphql-core/blob/master/src/graphql/language/parser.py

Datasette 1.0 alpha has JSON write APIs now, which could help inform the design and implementation of this:
https://docs.datasette.io/en/1.0a2/


Add highlight image to PopupImage

PopupImage can now display an alternative image as a highlight method.
Fixes #173

Something wrong. Icon is not changed + other issue.
Cf video +config.
https://user-images.githubusercontent.com/27446196/201486120-31a68090-670c-4e7b-ba67-a1a2125ceede.mp4
def show_power_menu(qtile):
    controls = [
        PopupImage(
            filename="~/.config/qtile/assets/lock.svg",
            pos_x=0.6,
            pos_y=0,
            width=0.4,
            height=0.2,
            highlight_method='image',
            highlight_filename="~/.config/qtile/assets/lock_blur.svg",
            #highlight=colors[6],
            mouse_callbacks={
                "Button1": lazy.spawn('betterlockscreen -l dim -- --time-str="%H:%M"')
            }
        PopupImage(
            filename="~/.config/qtile/assets/logout.svg",
            pos_x=0.6,
            pos_y=0.27,
            width=0.4,
            height=0.2,
            highlight=colors[6],
            mouse_callbacks={
                "Button1": lazy.shutdown()
            }
        ),

qtile.log
2022-11-12 20:13:11,331 WARNING libqtile toolkit.py:_load_image():L1098 Image does not exist: /home/crystal/.config/qtile/assets/lock_blur.svg
2022-11-12 20:13:11,841 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    pattern = self.img.pattern if not self._highlight else self.highlight_img.pattern
AttributeError: 'NoneType' object has no attribute 'pattern'
2022-11-12 20:13:11,973 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    pattern = self.img.pattern if not self._highlight else self.highlight_img.pattern
AttributeError: 'NoneType' object has no attribute 'pattern'
2022-11-12 20:13:12,397 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    pattern = self.img.pattern if not self._highlight else self.highlight_img.pattern
AttributeError: 'NoneType' object has no attribute 'pattern'
2022-11-12 20:13:12,760 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    pattern = self.img.pattern if not self._highlight else self.highlight_img.pattern
AttributeError: 'NoneType' object has no attribute 'pattern'

It says near the top that your highlight image doesn't exist

I double checked that and indeed there was an issue.
The qtile.log above is actually updated and doesn't mention anymore that "highlight image doesn't exist"
But the same issues remains

Well, it's definitely failing to load the image. Does that image load if you set it as the main filename parameter?

Sorry actually the highlight_method='image' works fine.
It's just that my blurred version of the lock icon is not different enough (i should get more blur on that).
Here's the final result:
https://user-images.githubusercontent.com/27446196/201488643-498c047e-769d-4664-b25f-93028405ccac.mp4
There is still a new bug with highlight method='block'.
I need to check border method also in case something happened there too.
qtile.log
2022-11-12 21:09:05,563 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    pattern = self.img.pattern if not self._highlight else self.highlight_img.pattern
AttributeError: 'NoneType' object has no attribute 'pattern'
2022-11-12 21:09:08,135 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    pattern = self.img.pattern if not self._highlight else self.highlight_img.pattern
AttributeError: 'NoneType' object has no attribute 'pattern'

Ah, yes. There's a bug in the code.

Same bug / new qtile.log
2022-11-12 21:24:36,394 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:36,571 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:37,011 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:37,291 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:37,693 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:38,523 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:38,797 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:38,858 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:44,911 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:45,435 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:45,572 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:45,597 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:45,776 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method
2022-11-12 21:24:45,992 ERROR libqtile core.py:_xpoll():L340 Got an exception in poll loop
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/core.py", line 308, in _xpoll
    ret = target(event)
  File "/usr/lib/python3.10/site-packages/libqtile/backend/x11/window.py", line 1149, in handle_MotionNotify
    self.process_pointer_motion(e.event_x, e.event_y)
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 378, in process_pointer_motion
    control.mouse_enter(
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 806, in mouse_enter
    self.container.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 171, in draw
    c.draw()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 735, in draw
    self.paint()
  File "/usr/lib/python3.10/site-packages/qtile_extras/popup/toolkit.py", line 1118, in paint
    if self._highlight and self._highlight_method == "image":
  File "/usr/lib/python3.10/site-packages/libqtile/configurable.py", line 48, in __getattr__
    raise AttributeError("%s has no attribute: %s" % (cname, name))
AttributeError: PopupImage has no attribute: _highlight_method

Hahaha, it's fine now. Border works too.
Great ! Thanks a lot.


Long delay on Android device

Hi,
When running the demo and connecting to the demo server I get a really long delay (about 1.5 sec) in the video stream.
If I connect to the same room from a web browser on the same device I see the same stream with minimal delay.
Any idea how I can begin to understand this issue?
Thanks!

Do you mean:

connection establishment time delay
or
stream has a latency around 1.5 seconds compares to reality?

Thanks for the reply.
The latency of the stream is 1.5 seconds compared to reality.
Both peers are connected to the same wifi network.

Hmm... I don't have any clues now. it needs tons of experiments and has tons of factors.
Does it occurs on some popular high-end devices as well?

I'm also seeing this issue in the android demo app of this project: the remote video seems to display delayed and slower than expected (when using (internal or external)stun- and (internal)turnserver).
The iOS version of the demo app displays both streams real time, no matter if connected by stun results or via turn server...
I've played with native WebRTC videocall apps between the same devices and there was no noticeable delay there. So I don't think mid-range devices are the problem.

@elad-softimize Take a look at https://github.com/oney/react-native-webrtc/issues/267 to resolve this issue.
I've modified the max constraints and both the delay and slow speed are good now!


Added the passwordReset page

Related Issue

Closes: #261
Description of Changes

I have added a new Password reset page and checked its functionality, it's working fine.
Updated the login.jsx and added a new reset.jsx file.

Checklist:

[x] My code adheres to the established style guidelines of this project.
[x] I have conducted a self-review of my code.
[x] I have included comments in areas that may be difficult to understand.
[x] I have made corresponding updates to the project documentation.
[x] My changes have not introduced any new warnings.

Screenshots

Updated

Please provide any necessary screenshots to illustrate the changes made.

Hey @sourabhsikarwar, I apologize for my absence from work recently as I had exams to attend to. I assure you that I will make up for it by submitting the PR within the next two days. Thank you for your understanding :)


Unable to decode xdr result from recently submitted transaction

I tried to view the result xdr and it didn't work.
{
  "_links": {
    "transaction": {
      "href": "https://horizon-testnet.stellar.org/transactions/df7d819fdcbc3f56c25eabb9c5e3f6932e59cbabfedaaef81578e8e98f10287a"
    }
  },
  "hash": "df7d819fdcbc3f56c25eabb9c5e3f6932e59cbabfedaaef81578e8e98f10287a",
  "ledger": 88400,
  "envelope_xdr": "AAAAAJA/Lb1w8HtaB8wQwNlRKz+V+canjnCWIscR8fi33XYOAAAAZAABWOkAAAABAAAAAAAAAAEAAAAAAAAAAQAAAAAAAAAJAAAAAAAAAAG33XYOAAAAQF2+f2GHtntmipPQbge0Z9ytc5OmMH9YigYuJDvgaEiu1d6PNGi3FTZRdfNwPUyU+k0SqhRT1ADTdvj6yrJx+gE=",
  "result_xdr": "332Bn9y8P1bCXqu5xeP2ky5Zy6v+2q74FXjo6Y8QKHoAAAAAAAAAZAAAAAAAAAABAAAAAAAAAAkAAAAAAAAAAAAAAAA=",
  "result_meta_xdr": "AAAAAAAAAAEAAAAA"
}

https://www.stellar.org/laboratory/#xdr-viewer?input=332Bn9y8P1bCXqu5xeP2ky5Zy6v%2B2q74FXjo6Y8QKHoAAAAAAAAAZAAAAAAAAAABAAAAAAAAAAkAAAAAAAAAAAAAAAA%3D&type=TransactionResult&network=test

Internally it throws:
XDR Read Error: Unknown TransactionResultCode member for value -1033983047

Wondering if it's not an issue with Horizon. I don't think there were any changes in XDR files recently.

@bartekn good eye... I'll fix it momentarily

The specific issue here is the importer.

Fixed in https://github.com/stellar/horizon/pull/262
Rolling it out to testnet now

It's working now. Closing.