[FEATURE] Allow optimizing build in watch mode.

I am developing a svelte application. It uses node as a resource server.
So I have to use snowpack build --watch for development.
But if I pass the --watch parameter, the optimize phase is missing from the build.
Is there a way to re-enable optimize build?

This would be really handy.
We're using private methods, which are not yet available in stable versions of Safari and Firefox — in particular, not in any iOS browser.
This is not an issue for production, but it prevents testing in those browsers during development. Once in a while it's very valuable to do that (especially for platform-specific bugs), and I can't seem to find a way to do it other than doing a full compilation.


fixup flaky unit test: TestManifestCollector_Success

Description
flaky test because of random sorting issue.
Example is: https://github.com/Dynatrace/dynatrace-operator/actions/runs/7464291026/job/20310950049?pr=2547
How can this be tested?
unit-tests
Checklist

[x] Unit tests have been updated/added
[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (54e8159) 64.79% compared to head (f709ef2) 64.79%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2549   +/-   ##
=======================================
  Coverage   64.79%   64.79%
=======================================
  Files         249      249
  Lines       16352    16352
=======================================
  Hits        10596    10596
  Misses       4948     4948
  Partials      808      808

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Compiler warnings in Classic Driver

These just popped up recently on the develop branch:
$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer//usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.3.0 (clang-703.0.29)
Target: x86_64-apple-darwin15.4.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

./src/read_soilparam.c:84:9: warning: variable 'temp' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
    if (!(*MODEL_DONE) && (*RUN_MODEL)) {
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./src/read_soilparam.c:934:12: note: uninitialized use occurs here
    return temp;
           ^~~~
./src/read_soilparam.c:84:5: note: remove the 'if' if its condition is always true
    if (!(*MODEL_DONE) && (*RUN_MODEL)) {
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./src/read_soilparam.c:84:9: warning: variable 'temp' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
    if (!(*MODEL_DONE) && (*RUN_MODEL)) {
        ^~~~~~~~~~~~~~
./src/read_soilparam.c:934:12: note: uninitialized use occurs here
    return temp;
           ^~~~
./src/read_soilparam.c:84:9: note: remove the '&&' if its condition is always true
    if (!(*MODEL_DONE) && (*RUN_MODEL)) {
        ^~~~~~~~~~~~~~~~~
./src/read_soilparam.c:64:5: note: variable 'temp' is declared here
    soil_con_struct          temp;
    ^
2 warnings generated.

@jhamman: Are these still there? If not, just close out.

yes, I fixed these in #552.


Add Linting Annotations

add linting annotations to Camunda 8 BPMN Editor

Artifacts:

https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/linting-annotations/camunda-modeler-linting-annotations-linux-x64.tar.gz
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/linting-annotations/camunda-modeler-linting-annotations-mac.dmg
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/linting-annotations/camunda-modeler-linting-annotations-mac.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/linting-annotations/camunda-modeler-linting-annotations-win-ia32.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/linting-annotations/camunda-modeler-linting-annotations-win-x64.zip

Follow-up issue: https://github.com/camunda/camunda-modeler/issues/3119

I've found two buggy interactions:

when element is dragged without selecting first, the preview shows the annotation even though the panel is closed
clicking canvas multiple times sometimes makes the annotation appear though the panel is closed

https://user-images.githubusercontent.com/28307541/189058759-6a6a3935-923f-4ee3-a3f4-ab8fd3131502.mov

Let's fix the bugs I found and then we can merge it.

Addressed with https://github.com/camunda/linting/pull/16.


FileStorage: add simplified API for bindings

at least it is possible to read/ write calibration files. Fixes #4282.
Also add CPP method for writing comments.
API
>>> fs = cv2.FileStorage("calib.yml", 0)
>>> fs.getNode("camera_matrix").mat()
np.array([...])
>>> fs.getNode("camera_matrix").getNode("data").at(0).real()
1070.97
>>> fs.write("blah", np.eye(3)) # also works

:+1:

:+1:


VNF pods CrashLoopBackOff

Hello,
After deploying contiv vpp with vagrant an deploying the SFC controller following the demo example. The deployed VNFs (1 to 4) from the example always result in a CrashLoopBackOff.
Is this related to the VNFs YAML files or what please?

SFC controller demo is now superseded by SFC functionality built into Contiv-VPP CNI itself. Still work in progress, but already does something. Take a look at https://github.com/contiv/vpp/tree/master/k8s/examples/sfc


[BUG] Training job cannot resume if LR scheduler is Plateau.

File "Trainer.py", line 233, in main
lr_scheduler.step(start_epoch)
File "/multimedia-nfs/wuye/libs/miniconda3/envs/py38/lib/python3.8/site-packages/timm/scheduler/plateau_lr.py", line 83, in step
self.lr_scheduler.step(metric, epoch)  # step the base scheduler
File "/multimedia-nfs/wuye/libs/miniconda3/envs/py38/lib/python3.8/site-packages/torch/optim/lr_scheduler.py", line 624, in step
current = float(metrics)
TypeError: float() argument must be a string or a number, not 'NoneType'
Trainer.py is just renamed from official training script.

@wuye9036 that is a known issue, I don't run into it frequently because I rarely run LR plateau schedules of lengths long enough to care too much about resume (usually short fine-tune tasks), but somethign that I intend to fix eventually. The overall state of that scheduler doesn't save or restore (I tried to keep them state free but that doesn't work so well for plateau). You can make it resume (without resuming the tracking of last) if you hack the metric to a fixed value that's definitely worse (below or above depending on metric direction) than any likely value...

By the hack I mean edit line 233 in main to lr_scheduler.step(start_epoch, metric=-100) or opposite if your metric scale is reverse.


Fix issue 14544 - isForwardRange failed to recognise valid forward range

https://issues.dlang.org/show_bug.cgi?id=14544
Historically, we have not checked for @property on range mechanisms, even if they were technically properties. For instance, this compiles:
import std.range.primitives;
struct R
{
   int front() { return 0;}
   bool empty() { return false;}
   void popFront() {}
}

static assert(isInputRange!R);

However, a quirk in typeof(someInstance.someMethod) returns the type of the member function instead of the type of the result of calling the function. So for instance:
// define R as above
R r;
assert(!is(typeof(r.front) == int)); // typeof(r.front) is int(), not int.

Therefore, I'm removing several questionable tests from std.range.primitives, as it is erroneous to allow users to call no-arg functions as properties, but deny they are properties in our range tests. I don't think the "benefit" of ensuring they were @property functions was intended (the code that tests this was from a long time ago, circa 2010). In addition, the attitude towards @property has changed drastically.
Finally, we should do this simply for consistency. Only 2 functions are "checked" to see if they are @property: r.save and r.length. There was also an obvious inconsistency for isRandomAccessRange, which checks for @property-ness of r.front, but is based on isBidrectionalRange that specifically does not check r.front.

ping anyone interested in this?

This looks reasonable to me.

I could have sworn that it was discussed at some point and that the current test for save being a property was very much on purpose, but I don't know. It's ridiculous that it be a property, and given the fact that  we've never gotten proper property enforcement and Andrei''s attitude on it, it really doesn't make sense to require that any of these be properties (though really, code is going to need to call them as if they were, since it's valid to use enums and variables and whatnot instead).
My best guess at the moment is that the test for save is the way it is to ensure that the return type is the original range type and not just a type that implicitly converts to it, but this PR does take that into account.

I have a feeling that someone assumed that it was supposed to be this way when adding tests for it.
Some background I found in bugzilla: https://issues.dlang.org/show_bug.cgi?id=11761, https://issues.dlang.org/show_bug.cgi?id=13293
I doubt this is the way we should leave it, it doesn't make sense, even if the history says it was intentional, given the current stance towards properties.
A question to answer: what is the possibility that someone wants a range that is an input range, but not a forward range, but has a save method? And even if they want that, should we support it?

A question to answer: what is the possibility that someone wants a range that is an input range, but not a forward range, but has a save method? And even if they want that, should we support it?

I'd say tough luck. Forward ranges have required a save method since the beginning, and you can't expect to be able to declare a range that uses a range-based function's name but does something different and have it work. and since you can't overload @property methods with non-@property methods, it's not like there are currently ranges floating around that declare save as both a property and a normal function and which run into problems with this change. There's only so much flexibility that we can reasonably have, so whoever wants a save method that isn't a forward range function will just need to pick a different name.

Auto-merge toggled on


Missing config file is displayed w/o .yml extension in error message

If the config file is missing, one gets the following error message:
panic: fatal error config file: Config File "conffile" Not Found in
As the name of the missing file is conffile.yml, it might be clearer to use the name with extension in the error message.

It is not that nice, since the part Config File "conffile" Not Found in comes from viper.
Error message is now:
panic: Config File "conffile" Not Found in "[...]": should be conffile.yml


Command for deleting sessions

Hi,
thanks for this amazing plugin!
Sometimes, there are broken stuffs that make into the session file and I wish there was a command for deleting the session for the current directory.
I know that I can delete them manually, but it feels non-trivial.
Maybe it should allow deleting only if the current vim instance hasn't loaded the session.

Hey, the DeleteSession function already existed, just hadn't been exposed yet. I put a PR up to expose it, I'll add some docs to the readme on how to use it too.
Thanks for the submission!


Publish on change

Since the Deye inverter I'm using is only updating the measurements every 5 minutes, any faster reading interval doesn't seem to make much sense. On the other hand, reading only every 5 minutes would impose the risk to miss one reading due to some intermediate connectivity issue.
My idea to solve this "issue" is to read more frequently, but only publish a new MQTT message if any of the values changed. This is based on the assumption that it's extremely unlikely that all logger values are unchanged between 2 updates.
I have already implemented a solution for testing this idea in my branch palto42/deye-inverter-mqtt/publish_on_change.
It implements storing the last published reading in a class variable and functions to compare a new reading with the last published. Only in case of a diff it will publish the reading and update the internal variable.
It might look a bit over-engineering a simple issue, but it avoids storing duplicate reading and also improved the data visualization (Grafana) and aggregation in my InfluxDB.
With 1 min reading interval  Grafana was showing a curve with steps every 5 min, now I get a smooth graph:

If there is any interest, I can raise a PR.

Hi @palto42
This is an interesting proposal. I took a look at your code and I have to say it is quite hacky :slightly_smiling_face: and thus hard to understand. Especially this part
        if not events[0]:  # offline
            self.__log.debug("No events received (offline)")
            return True
        if events[1:] == self.__last_observations and self.__event_updated + self.__event_expiry > time.time():
            self.__log.debug("Event data is unchanged and hasn't expired")
            return False

If I get it correctly, you rely on the fact that the events are always provided in the same order, don't you?
We could add it behind a feature flag. And imho, it would also require to start publishing the metrics messages as retained (another feature flag?), so the mqtt clients will always get the full set of metrics on subscription.

Hi @kbialek
your understanding is correct that I rely on the event order, as it seems to be the case for my model and it would make the comparison more complicated otherwise. If you think that the order may change for subsequent messages, the comparison function would need to change.
My current implementation always publishes the full set if any value has changed.

hi @palto42

If you think that the order may change for subsequent messages, the comparison function would need to change.

At the moment the event order is consistent for subsequent calls, but this is absolutely not guaranteed to be kept working this way in the future. If I get it right, you discard the first event, which I guess represents inverter online status. This is unfortunately very fragile approach. Please consider filtering the events using isinstance() function.

My current implementation always publishes the full set if any value has changed.

Perfect :+1:

Hi @kbialek, thanks for your feedback!
I have implemented a new compare using sets so that the order may change. The state event is not removed by type and not hard coded as the first event in the list.
The new function is enabled by the env variable DEYE_PUBLISH_ON_CHANGE=true which defaults to false.
I rebased the code on your version 2023.07.3.

@palto42 Could you open a PR, so I can add my comments?


Add all imported utility libraries to the global scope (like c,g,p and vscode) when running Leo Scripts.

Like the global node librairies, such as os, path, process, child_process, etc. the other few imported libraries should be made available on the global scope, without requiring to use 'g' to access them.
ALSO TUNE THE SCRIPTING DEMO REPOSITORY TO USE THEM DIRECTLY !
Those are :

SQL
pako
showdown
JSZip
dayjs
md5
csvtojson
difflib
elementtree
ksuid
lodash
stream

Question : Would this be considered 'polluting' the global namespace? Should they remain on 'g' ?

...Either way, some are missing in 'g'!


Lucene Dependency

Dexter depends on Lucene Version 4.1.0.
But I am using 5.3.0 in my project and APIs are not compatible.
It is possible to upgrade to Lucene 5.3.0 or higher?

Hello @rschwab68,
we are writing a new version of Dexter at the moment, using the latest stable version of lucene (5.4.0), we'll publish it in a few weeks.

Hello @diegoceccarelli ,
ok, fine. Do you also change LuceneHelper? As you know I want to use german language and I need the german Umlaute. LuceneHelper uses the Unicode cleaner to map to US-ASCII encoding. Umlaute get lost.

@rschwab68
Hi guys, I'm currently also trying to train it on the german model and I came across the same problem, how did you fix the problem with Umlauten? Do you just map the ü and so on to u and then when you get a response back reverse the mapping?
@diegoceccarelli First of all, thank you for your work, trained my first model kind of successfully.
Are there any new information about the new version of Dexter?

@arminmsg and @rschwab68 I've a new version that supports utf8, it has tagme implemented and I've testing it in an English model. But i still have to write the documentation and evaluate the quality. Happy to share the code if you want to play with it.

@diegoceccarelli
Would be great

@diegoceccarelli yes, I would like to play with it. you dont want to upload to github as a new branch?

@rschwab68  i shared it with you, it is a private fork of Dexter on my account. There is branch with the new project ( in the folder dexter-core3) it is private because it is still instable and not documented ;) I'll publish it when I'm done :)

@diegoceccarelli thank you for sharing the fork. I am looking forward that it will be published.


fix nbdev_new when path including space

Bug happened when I try to use nbdev_new in the directory including space like "/gdrive/My Drive/xxx".
Fix it by not using split() at target path.

Thanks!


Please add "count" and "interval" option

Describe the solution you'd like
A clear and concise description of what you want to happen.
-c : ping count
-i : interval between ping requests

The -c or count option has been added and will be available in version 2.0 which is planned to be released soon (hopefully less than two weeks).
The -i or interval option is somewhat nonsensical to me since if a TCP connection takes more than a second, which on its own is a lifelong then it means there are bigger problems somewhere else.
@hackevin  Could you please give me an example on how you would like to use the -i flag? Or your use case for it. I need to get some context to see if it is worthwhile to invest time there or address other open issues.

Sometimes, if the network is unstable, I'd like to test and sniffer for the failure reason, shorten the interval can reproduce the problem easily.
Thanks a lot.

The -c flag is now implemented and available in version2 which will be release in a few hours.
For the -i option, there was already an open issue at https://github.com/pouriyajamshidi/tcping/issues/7
It can be tracked there.


use error channel for Watch/WatchTree

This addresses #28 by swapping out error for <-chan error and adds a helper to create a preloaded channel for immediate error'd returns.

Just wanted to bump in case this hasn't gotten eyes because of the build failure: looks like the build failed because of the DNS DDoS that was going on at the time and killed GH intermittently.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "28-watch-error-chan" git@github.com:danielkrainas/libkv.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354365168
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


sync from figma style change

Currently, if you apply a color token from the plugin, it reflects in the native Figma color style, which is great. But if you manually change the color using the native Figma UI, the change isn't reflected in the plugin. It still shows the old value as selected. Is it possible to have that change reflect in the plugin?
The use case being having designers on board that aren't using the plugin wanting to make a color change. At the very least, users that are using the plugin shouldnt see the old style selected.
I'm assuming this isn't possible though because the data flows down from the plugin and not up?

actually, this doesnt look like its really an issue. you can apply styles just fine using the native ui, they dont show as selected in the plugin but Im not sure that matters.

sorry, after playing around some more I do think this is still an issue.
Steps to reproduce:
Create two color tokens, setup a second theme.
Apply color token to element using plugin.
Change the color using the Figma UI. (The plugin UI does not change the selected token)
Switch to your other theme.
The Figma color style is reverted back to the original, which I think is intended because the plugin is the source of truth and its state never changes.
Is this even possible to fix? is there an event that gets fired when a style is changed?


DOC: use :doi: and :arxiv: directives for references

This PR uses the :doi: and :arxiv: directives for references in the documentation. This allows more consistent navigation to primary references.

Thanks @mwtoews looks good


Better register sorting

closes #303
merge #301 after this one

Good idea. However, we have to find a way to merge register generation from CLI script and GitHub PR script in the long term in order to avoid inconsistency issues.


feat(odk): custom endpoint for ODK Collect urls

This could be useful with the kong option, instead of indicating all the "non-protected" ODK Collect urls, include the ODK_COLLECT_ENDPOINT="odk-collect/" environment variable and just indicate this endpoint in the non-protected list. Take in mind that if ODK Collect renames the endpoints (unlikely) or adds a new one (unexpected) we don't need to redefine the kong configuration.

@shawnsarwar could you review it again? :grimacing:


blog fixes

added blog thumb for newest blog post
corrected view on landing page for blog posts thumbnails

@szarnyasg found some issues and fixed them.


TR1 vs C++11

We need to isolate the usage of tr1 and C++11 in the entire project.  We need a common interface that can be used that transparently uses either C++11 or TR1 APIs depending on compilation mode (i.e. ANDRIOD vs. everything else).  Currently, this is partially done in VideoCommonDefs.h and Functional.h.  However, there  are still a lot of files that include tr1 headers instead of the aforementioned headers.
Also, the #define Bind ... definition conflicts with gtest's definition of Bind... so this will need resolved.  We should try to avoid the #define  pattern, too.
@scott-d-phillips suggested that we might put std::tr1::bind, etc.. into the std namespace, for example:
namespace std {
  using std::tr1::bind;
};

... then we  could use std::bind, etc. throughout the code.

also consider changing #ifdef ANDROID to #if __cplusplus > 199711L in cases where the conditional is really about language version and not about the platform itself.

I've started work on this... please assign to me.

@uartie your name is not on the list yet.

Hi @uartie ,
I have add you to collaboration list https://github.com/01org/libyami/settings/collaboration. But final solution is add you to 01org/media team at https://github.com/orgs/01org/teams/01-org-media . I do not know who have this right. Maybe @sean can help you.

Hi @xuguangxin ,
The 01org/media team link does not work for me.  I talked to @seanvk today and he's looking into getting me added.  Thanks.


[Bug]:  selected and placed missiles are not visible .

Give a brief about the bug ✍
Description:
What user is selected is only highlighted in control menu , but when it is placed its not visible except last one.
lets handle image properly.
What is the expected behavior? 🤔
Description :
images should be seen
Provide step by step information reproduce the bug 📄
Description:
please assign this issue to me so that i can contribute to enhance game.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

If you have any doubt you can directly send message on our discord (https://discord.gg/rZb46cCMmK), we have created seprate chennals for all projects...
Thank you :)


Cannot pause music in Broadcast Receiver mode.

I use Broadcast Receiver mode to hide original notification, but when I touch pause on notification nothing happend.
(next/previous button works)
Player: Phonograph

Interesting. I could've sworn I got phonograph working properly before. Oh well, I'll try to fix it the next time I'm working on this. Thanks for letting me know :+1:
Aqua is better than Megumin


external (OpenAI) setting does not persist after restart

Bug Report
Description
Bug Summary:
Open WebUI usually stores user settings such as Theme and Title Auto-Generation, but the same isn't true for OpenAI key & endpoint setting.
Steps to Reproduce:
Set OpenAI API key and custom base URL, shutdown and restart OpenWebUI.
Expected Behavior:
All settings should persist across restarts.
Actual Behavior:
The 2 OpenAI settings are gone after restart.
Environment

Operating System: macOS & Ubuntu
Browser (if applicable): Chrome and Safari

Reproduction Details
Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I have reviewed the troubleshooting.md document.
[x] I have included the browser console logs.
[] I have included the Docker container logs.

Logs and Screenshots
Browser Console Logs:

Docker Container Logs:
[Include relevant Docker container logs, if applicable]
Screenshots (if applicable):

Installation Method
docker run command
Additional Information
[Include any additional details that may help in understanding and reproducing the issue. This could include specific configurations, error messages, or anything else relevant to the bug.]
Note
If the bug report is incomplete or does not follow the provided instructions, it may not be addressed. Please ensure that you have followed the steps outlined in the README.md and troubleshooting.md documents, and provide all necessary information for us to reproduce and address the issue. Thank you!

Hi, OpenAI key and the endpoint should be specified as env vars in the docker command OPENAI_API_KEY, OPENAI_API_BASE_URL respectively, Thanks!


Loss of integrity between objects such as ServiceEndPoint and NodeEdgePoint

Hello!
We find loss of integrity between objects such as ServiceEndPoint and NodeEdgePoint.
Problem description:
In previous versions:
ServiceEndPoint using in "servicePort" for ConnectivityService creation. And ServiceEndPoint contained "_mappedNodeEdgePoint" with link to NodeEdgePoint in previous versions of TAPI.
But in last version:
Only NodeEdgePoint contain "_mappedServiceEndPoint" with link to ServiceEndPoint. And ServiceEndPoint not contain any information about NodeEdgePoint.
For ConnectivityService creation we using ServiceEndPoint, but ServiceEndPoint not contain information about NodeEdgePoint. We lost the direct link between objects. It seems that now we should iterate through the whole array of NodeEdgePoint's to find the one with correct "_mappedServiceEndPoint".
Is our understanding correct? Or it is bag ?
Thanks a lot!

Initially when TAPI was one monolith module, we could afford to have many inter-dependency relationships. But after modularizing TAPI,  it became necessary to revisit the navigability of some of these relationships.
In this case, the ServiceEndPoints are used by all TAPI modules - Connectivity, Path, VirtualNetwork, etc. A TAPI Context (a container for TAPI provider-client interaction) is in fact defined by the set of ServiceEndPoints. Therefore the ServiceEndPoint appears in the base/common Tapi module.
But to avoid an dependency of the common Tapi module on TapiTopology module (which contains NodeEdgePoint), it became necessary to reverse the navigability of the SEP-NEP relationship.
Conceptually too, it is required that simple TAPI clients can operate on the interface in a intent-like manner, just dealing with SEPs and not requiring knowledge of Topology (e.g. request Connectivity between SEPs)

We see sequence of operations in the system:
1)NEP contain link to SEP in "_mappedServiceEndPoint".
2)In request to create ConnectivityService SEP is used.
3)For handling it request controller needs to iterate through the whole array of NEP's to find the one with correct "_mappedServiceEndPoint".
4)Only after that controller can compute path for ConnectivityService request.
For example: if controller topology contain large number of NEP, so controller spend a lot of time for operation of find concrete NEP with correct SEP. It is bottle neck situation, we loss of performance.

@NikolayKolyada

3)For handling it request controller needs to iterate through the whole array of NEP's to find the one with correct "_mappedServiceEndPoint".

The mapping between SEP and NEP is specified/maintained by the TAPI provider. Therefore it is expected that the provider maintains this mapping in a more suitable form for processing - e.g. an hashmap indexed by SEP and/or NEP ids.
Please note that TAPI schema is just an interface schema, i.e. represents what gets sent over the wire, not necessarily the provider or client's internal implementation schema. For e.g., a TAPI provider may use an graph database schema which is more conducive to traversing relationships.


Fix stdout messes in on_epoch_end with verbose=1

This PR will try to fix such issue in Projects-Improvements:

When callbacks print something to stdout in on_epoch_end, this messes with the output of the progress bar in verbosity mode 1. Could we fix it?

Test script I'm using:
import numpy as np
from keras.models import Sequential
from keras.layers import Dense
from keras.callbacks import Callback

class TestCallback(Callback):
    def on_epoch_end(self, epoch, logs={}):
        print('on_epoch_end triggered')

train_x = np.random.rand(10000, 10)
train_y = np.random.rand(10000)

model = Sequential([
    Dense(128, input_dim=10),
    Dense(1),
])
model.compile('sgd', 'mse')
model.fit(
    train_x, train_y, batch_size=16, epochs=2,
    callbacks=[TestCallback()], verbose=1
)

Result before this patch
Epoch 1/2
10000/10000 [==============================] - 4s 436us/step - loss: 0.0922ch_end triggered
Epoch 2/2
10000/10000 [==============================] - 2s 170us/step - loss: 0.0824ch_end triggered

In which stdout of TestCallback is messed. (0.0824ch_end_triggered stuff)
Result after this patch
Epoch 1/2
10000/10000 [==============================] - 4s 418us/step - loss: 0.0910
on_epoch_end triggered
Epoch 2/2
10000/10000 [==============================] - 2s 157us/step - loss: 0.0836
on_epoch_end triggered

The stdout of TestCallback works well.
BTW, should I add my test script into keras' test cases? Is there any other cases I haven't noticed yet?

the fix should be applied in all methods that have callbacks (fit and fit_generator)
the progbar should not be the first callback, because BaseLogger should be the first callback. Basically the progbar should be the 2nd callback

@fchollet fit calls _fit_loop which has been already patched. The new commit patches fit_generator.

Does it make this PR unnecessary now?
https://github.com/keras-team/keras/pull/8879/
Several other callbacks also print `\n' for this reason. Are those unnecessary (and even harmful) now?
What about this one (in on_epoch_begin)?
https://github.com/ozabluda/keras/blob/54fbb869ff8c4223c4d326bb35660093ea64acfa/keras/callbacks.py#L579


A few questions on the function respond_to_batch()

I see the repo README uses the respond_to_batch function to obtain model responses, but this function does not have stop criteria, is this because we need to support batched inputs? And no stop criteria will be the easiest to implement?
Another question is, the respond_to_batch function does not use KV cache, is this because we want to generate complete gradients for KV during learning?
Both issues limit the speed of the function, and when model is far larger than the GPT2 used in the README example, it is hard to get RL working due to low efficiency.

The respond_to_batch function is deprecated and you should now use PPOTrainer.generate which uses the generate function of transformers under the hood.

I see. thanks for this information!


Restart when loop is on 64 steps

when i turn "last step" in stochastic mode to 64, the device stucks and restarts (it happened three time in a row)

I was able to recreate this issue using the update released on Feb 29th at 7:26 AM using the following steps:

Set track mode to stochastic
Add some notes and note probabilities
Press Play
Seq>Set last step to 64

After a few seconds the module crashes and restarts

Tested on feature branch 0.21, this appears to be fixed


Signature verification when signature is present

Is there a way to set the Decryptor to verifiy signatures only if the signature exists.
I am trying to have parity with the way GnuPG operates.
GnuPG only verifies a signature if it is present but however with JPGPJ you need to control that with setVerificationRequired and in the event when a signature is not present it throws an error saying
Verification failed :
org.c02e.jpgpj.VerificationException: content not signed with a required key

This is actually the case we have since we are migrating away from gnupg command line, we are trying to keep parity with the command line which does just that:

If encrypted + unsigned then just decrypt
If encrypted + signed with unknown key throw exception
if encrypted + signed with known key then decrypt and verify

Well in that case, I'm still in favor of modifying the Decryptor to have the three verification-processing states I suggested previously:

Same as today with verificationRequired == true (raise exception if not signed by known key)
Same as today with verificationRequired == false (ignore signatures)
New: check signatures, record results in metadata, but don't raise any exceptions

In cases like yours, where neither 1 nor 2 do what you need, you would at least be able to use state 3, and raise exceptions in your application logic as appropriate based on the metadata results from the Decryptor.

But to satisfy your use case, we'd also have to record some additional information in the FileMetadata object about signatures that were not verified. I'm thinking something along the lines of adding an inner class like the following to the FileMetadata object:
public class Signature {
  boolean verified;
  long keyId;
  org.c02e.jpgpj.Key key;
}

(Plus with friendly accessors as appropriate like isVerified(), setVerified() etc.)
And then adding a signatures property to the FileMetadata object (again with appropriate accessors) that would hold a list of Signature objects, similar to the FileMetadata object's verified property:
final List<Signature> signatures = new ArrayList<Signatures>();

And then the Decryptor class would need to be modified to:

(in the logic around the Decryptor.buildVerifiers() method) add an entry to the signatures list of the FileMetadata object for each of the message's signatures (recording the PGP key ID of each signature)
(in the logic of the Decryptor.verify() method) update the signature entry in the FileMetadata object corresponding to each signature that was verified, to set the entry's verified property to true and key property to the signed-by key

That way, your application can run the Decryptor in state 3, and check the signatures list on the resulting FileMetadata object to determine whether to accept or reject the results:

if the signatures list is empty, accept the results
otherwise, if the signatures list contains a signature entry with verified == false, raise an exception (or if the signatures list doesn't contain an entry with verified == true, raise an exception, if that's how your existing application's logic works)
otherwise, accept the results (as the signatures list contains a signature with verified == true)

This would also allow for different uses cases with other signature-verification requirements, like say a requirement that all messages be signed by at least 2 known keys; or a requirement that if the decrypted message turned out to contain a purchase order for more than $1000, the message must be signed by a specific key; etc.

I think that would work perfectly with our application logic.
Just one follow up on this
How do we capture the verification exception.
So let's say we send a payload which is signed by a key that is not in the Ring
The List<Signature> would contain one entry where verified=false but would it be possible to capture an error/stacktrace so that we can debug why it failed ?

As long as the Decryptor records the PGP key ID of each signature it encounters (including those it can't verify), the Signature entry for an unverified key would look like [verified:false, keyId:1234, key:null], where 1234 would be the (full 64-bit) key ID of the unknown key it couldn't verify. So you'd have that information for your application's own logging and error messages.
And currently if you turn on JPGPJ's logging, it will log the following message at an INFO level if it encounters a signature with an unknown key:
not found verification key 0x72A423A0013826C3

And the following message if it encounters a signature for a known key that isn't configured for verification:
not using verification key pub    013826C3 Test Key 1<EMAIL_ADDRESS>for ID=0x72A423A0013826C3

Today (in state 1) if it encounters a bad signature with a known key, it will raise a JPGPJ VerificationException with the following message:
bad signature for key pub v  013826C3 Test Key 1<EMAIL_ADDRESS>
So if for state 3 we log a similar message (instead of raising an exception), that would give you the 3 reasons via logging why JPGPJ wouldn't verify a signature: 1) unknown key, 2) known key but not configured for verification, 3) known key but bad signature. (And if a signature packet itself was malformed, you'd still get a PGPException from the underlying Bouncy Castle code during the message-unpacking process.)

I implemented what I was envisioning for this issue via PR #41 -- please take a look at it when you get a chance and let me know what you think.
Instead of adding a new verificationOptional boolean property to the decryptor, I ended up adding a verificationType enum property instead, where you would set it to VerificationType.Optional to put the decryptor into this new 3rd verification state. You might use it like this:
FileMetadata meta =
    new Decryptor(
        new Key(new File("path/to/my/keys/alice-pub.gpg")),
        new Key(new File("path/to/my/keys/bob-sec.gpg"), "b0bru1z!")
    )
    .withVerificationType(Decryptor.VerificationType.Optional)
    .decrypt(
        new File("path/to/ciphertext.txt.gpg"),
        new File("path/back-to/plaintext.txt")
    );

// raise an exception if ciphertext.txt.gpg had any unverified signatures
for (FileMetadata.Signature signature : meta.getSignatures())
    if (!signature.isVerified())
        throw new VerificationException("unverified signature for key "
            + signature.getKeyId());

I merged PR #41, and released as version 1.3.


hard-coding of plugin_desc

In Controller.cpp platfrom for plugin_desc is hard coded to rapl, but for Power we need to use different plugin, namely occ so the only way to fix this now is to hardcoded using ifdefs. Also this is hard coded in GlobalPolicy.cpp as well when setting m_platform.
Should this be replaced at one point with IOGroup?

Yes, IOGroups will fix this problem.


Backport the static allocation feature from FreeRTOS V9.0.0

This feature allows to use static buffers (or from a pool of memory which is not
controlled by FreeRTOS).
In order to reduce the impact of the changes, the static feature has only been added
to the queus (and in consequence to the semaphores and the mutexes) and the tasks.
The Timer task is always dynamically allocated and also the idle task(s), which in the
case of the ESP-IDF is ok, since we always need to have dynamic allocation enabled.

This change is the last requirement needed in order to enable MicroPython threading on the ESP32. MicroPython threads (and locks) are created using native FreeRTOS objects that must live in the pool of memory owned by MicroPython's garbage collector.

I fixed the bug of not saving the CoreID during task initialization and pushed again.

Just wondering what are the considerations for backporting these features vs moving completely to freertos 9?

FreeRTOS V9.x.x is a drop-in compatible replacement for FreeRTOS V8.x.x

Latest FreeRTOS version for which an Xtensa port is available is 8.2.0. It has been extensively modified to support dual core setup. So while version 9.0.0 may be a drop in replacement from the application perspective, it is not drop-in from the port perspective.

@igrr @Spritetm is there any update on this? Have you had a chance to look at it? Thanks :-)

Hi @danicompara,
Sorry for the slow update. This commit is in our internal review/test queue for merging. This week will be quiet because all of China is on holidays (Golden Week), but we should get back to you shortly after.
Angus

@projectgus thanks for the feedback!

Turned out that test failures we saw were unrelated to FreeRTOS changes. This is now merged in master. Daniel, sorry that it took so long.

No probs @igrr , I'm happy that it's merged now :-)


Problem with retrieving getAccountBalances or getBalances for Kraken

Hey Sathya,
Both functions getAccountBalances and getBalances are failing at the guard statement:
print("Error: Cast Failed in \(#function)")
It seems like that response.json is actually not of the type [[String: String]] but actually gives back an answer. I adjusted the function now to this one here which seems works since I am creating a new Balance object and assign the values, though the rest of the krakenService.store.balances object later is then messed up e.g. ...xxx.currency.code etc.  My function:
        public func getAccountBalances(completion: @escaping (ResponseType) -> Void) {
            let apiType = Kraken.API.getAccountBalance
            if apiType.checkInterval(response: store.balanceResponse) {
                completion(.cached)
            } else {
                krakenDataTaskFor(api: apiType) { (response) in

                    guard let json = response.json as? Dictionary<String, Any> else {
                        print("Error: Cast Failed in \(#function)")
                        return
                    }
                    let arrayOfCryptoBalances = json["result"] as! Dictionary<String,String>
                    var balances: [Balance] = []

                    for cryptoBalance in arrayOfCryptoBalances {
                        let newBalance = ["type": cryptoBalance.key,
                                       "amount": cryptoBalance.value,
                                       "available": cryptoBalance.value]

                        balances.append(Balance(json: newBalance, currencyStore: self))
                    }

                    self.store.balances = balances
                    self.store.balanceResponse = response.httpResponse
                    completion(.fetched)
                    }.resume()
            }
        }

Do you want me to create a pull request with my solution or are you taking care of it yourself? Maybe Kraken has updated the API since you wrote it. Also I found it annoying by Kraken that they decided to call most of the crypto currencies with own symbols. e.g. XBT instead of BTC for Bitcoin... is this what your overwrite function is for?
Best,
Matt

PR. Yes. Please. Thanks. Highly appreciated.
Yes. Currency overrides are for exchanges using their own code vs ISO 4217 code. Ironically XBT is the ISO 4217 compliant code for Bitcoin. lol.


Random crashes after latest upgrade to Windows 10 version 2004

(Apologies in advance if this is not the place to talk about this)
Environment
Windows build number: 10.0.19041.0
Your Distribution version: 20.04
Whether the issue is on WSL 2 and/or WSL 1: WSL 2

Steps to reproduce
Ever since I had upgraded to windows version 2004 to use WSL2 (which is phenomenal btw), I've been experiencing random crashes in that there would be no BSOD but the laptop (x1 carbon) would abruptly shutdown. Looking at the event viewer I came across a Hypervisor warning event that appears to show up every time this shutdown occurs. This is the following message:
The hypervisor did not enable mitigations for CVE-2018-3646 for virtual machines because HyperThreading is enabled and the hypervisor core scheduler is not enabled. To enable mitigations for CVE-2018-3646 for virtual machines, enable the core scheduler by running "bcdedit /set hypervisorschedulertype core" from an elevated command prompt and reboot.

So I ran the command but I still got a random shutdown and this time the event preceeding the shutdown was the following informational level event:
Hypervisor configured mitigations for CVE-2019-11091, CVE-2018-12126, CVE-2018-12127, CVE-2018-12130 for virtual machines.

Processor not affected: true
Processor family not affected: false
Processor supports microarchitectural buffer flush: false
Buffer flush needed: false

I'm not entirely sure if these mitigations are what's causing the problems or if it's just a red herring. I tried looking for this online but only came to this post https://answers.microsoft.com/en-us/windows/forum/all/random-shutdowns/1e10ef74-3247-444b-ab64-c0ad18543f80 with no clear resolution.
Any guidance around this would be great!
Expected behavior
Don't randomly cause crashes.
Actual behavior
Randomly causing crashes

167
0
3
0
0
0x8000400000000000

4550

System
LAPTOP-FF8A4JF0

same crash

Should fix the problem.
Activate the Windows security feature "Core Isolation/Memory Integrity" (in system settings / Windows security / Device security) and run the command:
bcdedit /set hypervisorschedulertype core

Should fix the problem
Activate the Windows security feature "Core Isolation/Memory Integrity" (in System settings / Windows security / Device security) and run the command:
bcdedit /set hypervisorschedulertype core

that is ok,  import the linux file by lxrunoffline , and no crash any more

My system still crashes randomly after running bcdedit /set hypervisorschedulertype core

I'm seeing this as well.. seemed to start after windows 2004/WSL2

I'm seeing this as well.. seemed to start after windows 2004/WSL2

I know that for some this fix (bcdedit /set hypervisorschedulertype core) hadn't worked - but in my case it has and I had no further full freezing of my system afterwards.

Hello,
I have the same behavior on my desktop.
Nom du journal :System
Source :       Microsoft-Windows-Kernel-Power
Date :         02/06/2021 18:08:03
ID de l’événement :41
Catégorie de la tâche :(63)
Niveau :       Critique
Mots clés :<PHONE_NUMBER>7664),(2)
Utilisateur :  Système
Ordinateur :   mydesktop
Description :
Le système a redémarré sans s’arrêter correctement au préalable. Cette erreur peut survenir si le système ne répond plus, s’est bloqué ou n’est plus alimenté de façon inattendue.
XML de l’événement :
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Microsoft-Windows-Kernel-Power" Guid="{331c3b3a-2005-44c2-ac5e-77220c37d6b4}" />
    <EventID>41</EventID>
    <Version>8</Version>
    <Level>1</Level>
    <Task>63</Task>
    <Opcode>0</Opcode>
    <Keywords>0x8000400000000002</Keywords>
    <TimeCreated SystemTime="2021-06-02T16:08:03.8118615Z" />
    <EventRecordID>12896</EventRecordID>
    <Correlation />
    <Execution ProcessID="4" ThreadID="8" />
    <Channel>System</Channel>
    <Computer>mydesktop</Computer>
    <Security UserID="S-1-5-18" />
  </System>
  <EventData>
    <Data Name="BugcheckCode">0</Data>
    <Data Name="BugcheckParameter1">0x0</Data>
    <Data Name="BugcheckParameter2">0x0</Data>
    <Data Name="BugcheckParameter3">0x0</Data>
    <Data Name="BugcheckParameter4">0x0</Data>
    <Data Name="SleepInProgress">0</Data>
    <Data Name="PowerButtonTimestamp">0</Data>
    <Data Name="BootAppStatus">0</Data>
    <Data Name="Checkpoint">0</Data>
    <Data Name="ConnectedStandbyInProgress">false</Data>
    <Data Name="SystemSleepTransitionsToOn">1</Data>
    <Data Name="CsEntryScenarioInstanceId">0</Data>
    <Data Name="BugcheckInfoFromEFI">false</Data>
    <Data Name="CheckpointStatus">0</Data>
    <Data Name="CsEntryScenarioInstanceIdV2">0</Data>
    <Data Name="LongPowerButtonPressDetected">false</Data>
  </EventData>
</Event>

Nom du journal :System
Source :       Microsoft-Windows-Hyper-V-Hypervisor
Date :         02/06/2021 18:08:01
ID de l’événement :157
Catégorie de la tâche :Aucun
Niveau :       Avertissement
Mots clés :<PHONE_NUMBER>7664)
Utilisateur :  Système
Ordinateur :   mydesktop
Description :
The hypervisor did not enable mitigations for CVE-2018-3646 for virtual machines because HyperThreading is enabled and the hypervisor core scheduler is not enabled. To enable mitigations for CVE-2018-3646 for virtual machines, enable the core scheduler by running "bcdedit /set hypervisorschedulertype core" from an elevated command prompt and reboot.
XML de l’événement :
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />
    <EventID>157</EventID>
    <Version>0</Version>
    <Level>3</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x8000400000000000</Keywords>
    <TimeCreated SystemTime="2021-06-02T16:08:01.8807600Z" />
    <EventRecordID>12882</EventRecordID>
    <Correlation />
    <Execution ProcessID="4" ThreadID="8" />
    <Channel>System</Channel>
    <Computer>mydesktop</Computer>
    <Security UserID="S-1-5-18" />
  </System>
  <EventData>
  </EventData>
</Event>

Same here, any update?

Yes, the same here ..... so far I haven't touched a suggestion .... still waiting.

bump

Suffering this for a year :) bump.

Same issue here. I am using Docker with WSL 2, but not running any containers at the time of the crash. Today it happened two times within a single hour.

Same here, bump

Same here. It pops up 3s before system crashes.
For some reason I do not see any EventData in my log,
- <Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
- <System>
  <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />
  <EventID>157</EventID>
  <Version>0</Version>
  <Level>3</Level>
  <Task>0</Task>
  <Opcode>0</Opcode>
  <Keywords>0x8000400000000000</Keywords>
  <TimeCreated SystemTime="2021-09-19T05:20:43.1994554Z" />
  <EventRecordID>188175</EventRecordID>
  <Correlation />
  <Execution ProcessID="4" ThreadID="8" />
  <Channel>System</Channel>
  <Computer>computer</Computer>
  <Security UserID="S-1-5-18" />
  </System>
  <EventData />
  </Event>

same, bump

same for me

same with me
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
- <System>
  <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />
  <EventID>157</EventID>
  <Version>0</Version>
  <Level>3</Level>
  <Task>0</Task>
  <Opcode>0</Opcode>
  <Keywords>0x8000400000000000</Keywords>
  <TimeCreated SystemTime="2021-09-25T15:33:42.9597178Z" />
  <EventRecordID>160999</EventRecordID>
  <Correlation />
  <Execution ProcessID="4" ThreadID="8" />
  <Channel>System</Channel>
  <Computer>BT1000115269</Computer>
  <Security UserID="S-1-5-18" />
  </System>
  <EventData />
  </Event>

and computer restarted
- <Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
- <System>
  <Provider Name="Microsoft-Windows-Kernel-Power" Guid="{331c3b3a-2005-44c2-ac5e-77220c37d6b4}" />
  <EventID>41</EventID>
  <Version>8</Version>
  <Level>1</Level>
  <Task>63</Task>
  <Opcode>0</Opcode>
  <Keywords>0x8000400000000002</Keywords>
  <TimeCreated SystemTime="2021-09-25T15:33:44.9823232Z" />
  <EventRecordID>161015</EventRecordID>
  <Correlation />
  <Execution ProcessID="4" ThreadID="8" />
  <Channel>System</Channel>
  <Computer>BT1000115269</Computer>
  <Security UserID="S-1-5-18" />
  </System>
- <EventData>
  <Data Name="BugcheckCode">0</Data>
  <Data Name="BugcheckParameter1">0x0</Data>
  <Data Name="BugcheckParameter2">0x0</Data>
  <Data Name="BugcheckParameter3">0x0</Data>
  <Data Name="BugcheckParameter4">0x0</Data>
  <Data Name="SleepInProgress">0</Data>
  <Data Name="PowerButtonTimestamp">0</Data>
  <Data Name="BootAppStatus">0</Data>
  <Data Name="Checkpoint">0</Data>
  <Data Name="ConnectedStandbyInProgress">false</Data>
  <Data Name="SystemSleepTransitionsToOn">1</Data>
  <Data Name="CsEntryScenarioInstanceId">0</Data>
  <Data Name="BugcheckInfoFromEFI">false</Data>
  <Data Name="CheckpointStatus">0</Data>
  <Data Name="CsEntryScenarioInstanceIdV2">0</Data>
  <Data Name="LongPowerButtonPressDetected">false</Data>
  </EventData>
  </Event>

I had the same problem and managed to track it down to Windows built-in SSH server running alongside Docker Desktop with WSL2 backend.
Check if you have OpenSSH server enabled:
Get-WindowsCapability -Online | Where-Object Name -like 'OpenSSH*'

and try disabling it:
Remove-WindowsCapability -Online -Name OpenSSH.Server~~~~<IP_ADDRESS>

Of course, I could be wrong and this may be completely unrelated.

if something that doesn't require wsl
STOP wsl
wsl --shutdown

should we execute the command
bcdedit /set hypervisorschedulertype core

as ig it might cause the VMWare/Virtual box to stop working.

I have the same problem on windows 10 20H2 with wsl2 installed. I'm using a Intel AX210 and get BSOD quite often when watching videos in Chrome.

Follow up to my previous reply: https://github.com/microsoft/WSL/issues/5523#issuecomment-939311351
I updated to Windows 11 and so far no crashes at all. WSL is also much faster. Hope it stays this way.

I have been getting random crashes after some long ago automatic update and never knew why. Today I googled a random message from from 15 seconds before windows rebooted from a crash. Tbh I thought it was a message I got during boot but now Im not so sure. Was it the cause of the crash?
I cannot update to windows 11, too old. If this is crashing my pc I would like a fix. for now I shutdown wsl, just in case. but I will probably forget next time I have to reboot

Same issue here. I am using Docker with WSL 2, but not running any containers at the time of the crash. Today it happened two times within a single hour.

same for me.
I cannot update to windows 11 because my CPU doesnt' supported.
Any solution?

This issue for me popped up on 12/08/21. I don't know if there was an auto update or something that went out that day, but I had been using WSL 2 on windows 10 pro build 19042.1348 (I did update at some point) for months on my Dell precision T3610 without issue. I have been getting most of the same issues you have all mentioned above. What I have noticed is in the event viewer I get an event id 157 (The hypervisor did not enable mitigations for CVE-2018-3646 for virtual mac...) exactly 2 seconds before every event id 41 (The system has rebooted without cleanly shutting down first. This error could be caused if the system stopped responding, crashed, or lost power unexpectedly). I have also noticed taht it does not seem to matter if I am running WSL or not. I have not done much to try to fix this issue yet then run diagnostics and take it to the geek squad (they suggested it could be a power issue). Given the fact that I have gotten a 157 error right before every freeze I am going to run that command and tell you guys how it worked out.

It looks like it works as I have not been able to get the computer to go an hour without freezing, prior to running the command.

Same issue, brand new laptop freezes randomly. I have to do a manual button shutdown. Strangely it seems freezes only occur when the laptop is on battery power (i.e. not plugged in). Each freeze is preceded by the following warning:
- <Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
- <System>
  <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />
  <EventID>157</EventID>
  <Version>0</Version>
  <Level>3</Level>
  <Task>0</Task>
  <Opcode>0</Opcode>
  <Keywords>0x8000400000000000</Keywords>
  <TimeCreated SystemTime="2021-12-11T10:47:02.4260960Z" />
  <EventRecordID>12941</EventRecordID>
  <Correlation />
  <Execution ProcessID="4" ThreadID="8" />
  <Channel>System</Channel>
  <Computer>DESKTOP-4HEK48A</Computer>
  <Security UserID="S-1-5-18" />
  </System>
  <EventData />
  </Event>

Since freezes are sporadic, the solutions proposed here are rather difficult to test. Be back with more information.

Same here, on Windows 10 (latest updates) and Surface Laptop 4 (latest model). bcdedit /set hypervisorschedulertype core - didn't work.

It actually turns out it had nothing to do with the command that I ran, I had a corrupted ram stick. Took it out now things are fine.

Doesn't look like Windows 11 fixed the issue either. I'm having this issue ever since I started using WSL on windows 11 22000.438
- <Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
- <System>
  <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />
  <EventID>167</EventID>
  <Version>0</Version>
  <Level>3</Level>
  <Task>0</Task>
  <Opcode>0</Opcode>
  <Keywords>0x8000400000000000</Keywords>
  <TimeCreated SystemTime="2022-01-25T07:33:02.2732617Z" />
  <EventRecordID>11185</EventRecordID>
  <Correlation />
  <Execution ProcessID="4" ThreadID="8" />
  <Channel>System</Channel>
  <Computer>CityOfGlass</Computer>
  <Security UserID="S-1-5-18" />
  </System>
  <EventData />
  </Event>

yes, not yet fixed

It appears that this is due to memory corruption, which will result in a BSOD. Increasing the max memory allocated (.wslconfig), and the amount increased depending in how many containers are running and their requirements, seems to have fixed the issue.

It appears that this is due to memory corruption, which will result in a BSOD. Increasing the max memory allocated (.wslconfig), and the amount increased depending in how many containers are running and their requirements, seems to have fixed the issue.

I doubt it's a max memory issue. grep MemTotal /proc/meminfo is showing 8GB which is an ungodly amount for a linux shell. Also you mentioned BSOD, but I (as well as the OP) aren't even receiving a BSOD. The whole system just freezes.

Around a month ago I found this thread, and began to suspect WSL had a
problem. I somehow disabled it and now the system seems much more stable.
I think at the time I had also discovered some attempt by me to manually
install WSL on my "D:" drive to save space on C .. Probably following some
random internet instructions. Wonder if that had anything to do with it?
Right now I can type "wsl" commands and see that I have ubuntu 18 installed
but it is not running so I guess I disabled it on startup or smth
On Tue, Jan 25, 2022 at 5:16 AM Nathan Telles @.***>
wrote:

It appears that this is due to memory corruption, which will result in a
BSOD. Increasing the max memory allocated (.wslconfig), and the amount
increased depending in how many containers are running and their
requirements, seems to have fixed the issue.
I doubt it's a max memory issue. grep MemTotal /proc/meminfo is showing
8GB which is an ungodly amount for a linux shell. Also you mentioned BSOD,
but I (as well as the OP) aren't even receiving a BSOD. The whole system
just freezes.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/WSL/issues/5523#issuecomment-1021025490,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHTCBFRA73VWXF5PBZMP64LUXZ2ADANCNFSM4OO6RRAQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

same question.
here is the error
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event"> [-](https://github.com/microsoft/WSL/issues/5523#) <System>   <Provider Name="EventLog" />    <EventID Qualifiers="32768">6008</EventID>    <Version>0</Version>    <Level>2</Level>    <Task>0</Task>    <Opcode>0</Opcode>    <Keywords>0x80000000000000</Keywords>    <TimeCreated SystemTime="2022-04-27T11:21:04.8788362Z" />    <EventRecordID>550242</EventRecordID>    <Correlation />    <Execution ProcessID="0" ThreadID="0" />    <Channel>System</Channel>    <Computer>DESKTOP-GJFSKC7</Computer>    <Security />    </System> [-](https://github.com/microsoft/WSL/issues/5523#) <EventData>   <Data>19:17:56</Data>    <Data>2022/4/27</Data>    <Data />    <Data />    <Data>78555</Data>    <Data />    <Data />    <Binary>E607040003001B00130011003800C800E607040003001B000B0011003800C800600900003C000000010000006009000001000000B00400000100000001000000</Binary>    </EventData>   </Event>
here is the warning:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event"> [-](https://github.com/microsoft/WSL/issues/5523#) <System>   <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />    <EventID>157</EventID>    <Version>0</Version>    <Level>3</Level>    <Task>0</Task>    <Opcode>0</Opcode>    <Keywords>0x8000400000000000</Keywords>    <TimeCreated SystemTime="2022-04-27T11:20:53.4425269Z" />    <EventRecordID>550241</EventRecordID>    <Correlation />    <Execution ProcessID="4" ThreadID="8" />    <Channel>System</Channel>    <Computer>DESKTOP-GJFSKC7</Computer>    <Security UserID="S-1-5-18" />    </System>   <EventData />    </Event>

im also use the wsl2 with docker in windows

I guess it's all operating system in virtualization that to always running, so it can sometimes crash as many virtual tools stop responding, so does wsl.
So my advice is to
wsl --shutdown

whenever we are not using ubuntu, by the fact to learn more in-depth features of Linux we should use Virtual box or VMWare workstation as some internal features are stopped
Overall
it is a Pretty good part of windows to get Linux on windows.

I began experiencing issues about 4 weeks ago (4/4/22). My laptop BSOD and when it rebooted, it had changed the drive it booted to. I thought I had lost everything for a minute. Eventually fixed the boot order and things went back to normal. Same thing happened on 4/18/22 except this time it wasn't detecting the hard drive I use. I opened my laptop and reseated the SSD. After that, things worked fine until 4/29/22 which is when my laptop started freezing like everyone else is saying in this thread.
Since then, it has frozen almost everyday and sometimes multiple times in a day. Sometimes the freeze happens when my computer locks the screen after inactivity and sometimes it happens while I'm using it. It requires a power button reboot. I checked the Event Viewer tonight and it seems that the Hyper-V-Hypervisor warning happens about 3 seconds before each of the power downs. I do have WSL2 enabled. I also have VirtualBox and Docker Desktop. However, I wasn't actively using any of those when any of the BSOD or freezes happened though (not sure if they had any background processes running or not).

My environment:
Edition	Windows 10 Home
Version	21H2
Installed on	1/4/2021
OS build	19044.1682
Experience	Windows Feature Experience Pack 120.2212.4170.0

I've had this laptop for about a year and a half and have never had any issues. This is really frustrating. Has anyone found any fixes? I'm not sure what the suggested bcdedit /set hypervisorschedulertype core command does and I'm not sure if I should run it or not.

I'm facing this exact issue:

The hypervisor did not enable mitigations for CVE-2018-3646 for virtual machines because HyperThreading is enabled and the hypervisor core scheduler is not enabled. To enable mitigations for CVE-2018-3646 for virtual machines, enable the core scheduler by running "bcdedit /set hypervisorschedulertype core" from an elevated command prompt, disable HyperThreading and reboot.

Without reading the threads online (and admittedly thats a mistake), I changed the scheduler type to core. But it has also changed the error. I got:

The hypervisor did not enable mitigations for CVE-2018-3646, CVE-2019-11091, CVE-2018-12126, CVE-2018-12127, and CVE-2018-12130 for virtual machines because HyperThreading is enabled. To enable mitigations for virtual machines, disable HyperThreading.

Then I disabled HyperThreading too. Yet, my Windows system is crashing randomly. Is there a chance that we've picked the wrong log as a suspect?

I'm getting this error after the latest windows update and I don't even have WSL. >:(

Similar issue
Windows 10 version 21H2
WSL 2 installed
AMD CPU, Virtualization enabled

Sometimes the system is getting crashed and I can see the following in the system events log:
the previous system shutdown at 1:11:29 was unexpected
-----------------------------
Hypervisor initialized I/O remapping.

Hardware present: true
Hardware enabled: true
Policy: 0x0
Enabled features: 0x4A
Internal information: 0x0
Problems: 0x0
Additional information: 0x0
-----------------------------
Hypervisor scheduler type is 0x4.
-----------------------------
Hypervisor successfully started.

Similar issue on a recently formatted computer
Windows 10 version 21H2 22000.918
WSL 2 is installed and was running by docker during shutdown
AMD CPU, Virtualization enabled

<System>
    <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />
    <EventID>129</EventID>
    <Version>0</Version>
    <Level>4</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x8000400000000000</Keywords>
    <TimeCreated SystemTime="2022-09-09T20:22:21.0024774Z" />
    <EventRecordID>2187</EventRecordID>
    <Correlation />
    <Execution ProcessID="4" ThreadID="8" />
    <Channel>System</Channel>
    <Computer>DESKTOP-6OSFNBB</Computer>
    <Security UserID="S-1-5-18" />
</System>
<EventData>
    <Data Name="HardwarePresent">true</Data>
    <Data Name="HardwareEnabled">true</Data>
    <Data Name="Policy">0x0</Data>
    <Data Name="EnabledFeatures">0x4a</Data>
    <Data Name="InternalInfo">0x0</Data>
    <Data Name="Problems">0x0</Data>
    <Data Name="AdditionalInfo">0x0</Data>
</EventData>
</Event>

What helped me with frequent WSL 2 related crashes was installing the NVIDIA Studio drivers instead of the Game Ready drivers (that workstation has a NVIDIA GPU that supports Studio drivers. The Studio drivers were installed via GeForce Experience program). With the Studio drivers a crash, flicker, system hanging or related issue, when WSL 2 is running, had yet to be encountered.

Seems to very consistently have this INFO system event right before BSOD
Hypervisor configured mitigations for CVE-2019-11091, CVE-2018-12126, CVE-2018-12127, CVE-2018-12130 for virtual machines.

Processor not affected: false
Processor family not affected: false
Processor supports microarchitectural buffer flush: false
Buffer flush needed: false

Did we have any conclusion here? I am running into same problem now and it is not clear what to do. My computer freeze
Log Name:      System
Source:        Microsoft-Windows-Hyper-V-Hypervisor
Date:          2/8/2024 10:01:05 AM
Event ID:      167
Task Category: None
Level:         Warning
Keywords:<PHONE_NUMBER>7664)
User:          SYSTEM
Computer:      Tarek-Family
Description:
The hypervisor did not enable mitigations for side channel vulnerabilities for virtual machines because HyperThreading is enabled. To enable mitigations for virtual machines, disable HyperThreading.
Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />
    <EventID>167</EventID>
    <Version>0</Version>
    <Level>3</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x8000400000000000</Keywords>
    <TimeCreated SystemTime="2024-02-08T18:01:05.0735074Z" />
    <EventRecordID>719599</EventRecordID>
    <Correlation />
    <Execution ProcessID="4" ThreadID="8" />
    <Channel>System</Channel>
    <Computer>Tarek-Family</Computer>
    <Security UserID="S-1-5-18" />
  </System>
  <EventData>
  </EventData>
</Event>

Log Name:      System
Source:        Microsoft-Windows-Hyper-V-Hypervisor
Date:          2/9/2024 2:14:54 PM
Event ID:      165
Task Category: None
Level:         Information
Keywords:<PHONE_NUMBER>7664)
User:          SYSTEM
Description:
Hypervisor configured mitigations for CVE-2019-11091, CVE-2018-12126, CVE-2018-12127, CVE-2018-12130 for virtual machines.

Processor not affected: false
Processor family not affected: false
Processor supports microarchitectural buffer flush: false
Buffer flush needed: false

Event Xml:
<Event xmlns="http://schemas.microsoft.com/win/2004/08/events/event">
  <System>
    <Provider Name="Microsoft-Windows-Hyper-V-Hypervisor" Guid="{52fc89f8-995e-434c-a91e-199986449890}" />
    <EventID>165</EventID>
    <Version>0</Version>
    <Level>4</Level>
    <Task>0</Task>
    <Opcode>0</Opcode>
    <Keywords>0x8000400000000000</Keywords>
    <TimeCreated SystemTime="2024-02-09T22:14:54.7662014Z" />
    <EventRecordID>5534</EventRecordID>
    <Correlation />
    <Execution ProcessID="4" ThreadID="8" />
    <Channel>System</Channel>
    <Computer>DOCK-PC</Computer>
    <Security UserID="S-1-5-18" />
  </System>
  <EventData>
    <Data Name="NotAffectedMdsNo">false</Data>
    <Data Name="NotAffectedAtom">false</Data>
    <Data Name="MdClearSupported">false</Data>
    <Data Name="BufferFlushNeeded">false</Data>
  </EventData>
</Event>

Same struggle, anyone has a lead?

@Nucs I used the command bcdedit /set hypervisorschedulertype core from elevated command prompt. I don't know if it is permanently fixed the problem but I at least since I ran it I am not experience the problem.

I can point out that a few of my crashes where when Docker was starting up which probably calls wsl commandline


Add custom WordPress hooks to all the things

Deprecating this project and will no longer be making updates. Closing this issue accordingly.


With high ping vessel jumps on water like on slime

DV version: <IP_ADDRESS>
Minecraft 1.12.2 (Forge <IP_ADDRESS>47)
This issue not creating messages in logs.

As the title says, high ping creates a situation where the ship is not sailing, but jumping on the water.
After the creation of the ship, it visually begins to sink and pushes it out of the water with greater force, which creates the effect of falling and even greater pushing force.
After a few seconds, the ship is in the air, about 6-7 blocks above the water level.
Moreover, from the server side, this effect is valid and allows you to disassemble the ship right in the air.
Tested on different players. With a ping below 150, everything is fine.

Could you please put the mod for 1.14.4. The Mod is beautiful and i could really need a lot.


Use Rubygems 2.7.8 (avoid Rubygems 3)

Rubygems 3 drops support for older rubies so this is needed to keep the Travis matrix working.

LGTM

Whelp, we'll need this conditionally on all our repos then...


New Service for CP4BA. Add to prod

https://github.ibm.com/Developer-Playground/work-items/issues/993


Vector offset isn't incremented. Making the loop to override the same value over and over again.

https://github.com/brookiestein/libvector/blob/deeefc88be5d8ad563805ca2a5a86ac0822df530/src/vector.c#L90

Fixed on commit https://github.com/brookiestein/libvector/commit/5f500413e01c525070a3dd5f534a163ede61b328


Add Colors for Git & Fuzzy Search

Git diff

Telescope match diff (should be same for CtrlP match)

enabling this by setting up in .vimrc
let g:colors_off_a_little=1

if colors_off_a_little not defined, the result will be as default for git and for fuzzy search it will be like

Do you think we should move what minimal coloring there was already under this conditional as well, making this truly "off" when this flag isn't enabled?

Make sense though. I will just follow your decision. My thought to not agree with it only if just in case some people actually really want it to have color instead even when minimal coloring is off.

Will you merge this btw?

Do you think we should move what minimal coloring there was already under this conditional as well

about this I'll probably will it later since I have to focus on other things for now


refactor: improve plugin-git , support changelog of the page

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[ ] Bug fix
[x] New feature
[ ] Other

Description

The current plugin executes three commands separately to obtain createdTime, updatedTime, and contributors for a single page. This results in even more command executions when filepaths contains multiple files, which is the main reason for the slow collection of git information.
Additionally, the contributors information often leads to duplicate statistics because the username in the local git configuration may not be the same as the username on the git hosting service, resulting in the same user having multiple usernames.
This PR makes the following updates and modifications:

A single command is executed per file to collect all git information.

Adds a contributorConfig preset for contributors' information, supporting alias mapping.

Adds avatar and url information for contributors.

Adds a changelogs field to collect the change logs for the current page.

Adds an filter field to control whether information is collected for pages globally.

Adds contributors and changelogs in frontmatter to control whether relevant information is collected for the current page.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.438%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
1207

Relevant Lines:
1853

💛  - Coveralls

Title should be something like
feat(plugin-git): support changelog and improve performance

my bad, infer not refer 😂


Explore removing unused zookeeper watchers

For per table config, Accumulo creates zookeeper watches per table per tablet servers.  When a table is deleted these watches may be left behind consuming memory on the ZK servers.  Accumulo may be able to use the following to remove these watchers.
https://issues.apache.org/jira/browse/ZOOKEEPER-1829

If this can be done with low-risk and a small amount of code, it could be backported to 2.0.x or even 1.9.x; but without trying, it's hard to know for sure.
I think the basic design would be something like:

Have ZooCache keep references to any Watchers,
ZooCache implements a method to match any watchers against some predicate and delete them,
In the Master, when a table is deleted, it triggers deletion of any watchers matching paths to that table's location in ZK, and
In the TServers, trigger deletion of any watchers for tables that don't match any loaded tablets, whenever a tablet is unloaded or periodically.

I am working on this.

@keith-turner  and @ctubbsii ,  from the basic design above I will try to implement number 2:
ZooCache implements a method to match any watchers against some predicate and delete them.
That is the least risky and fastest path in my opinion.   I will implement the other steps afterword.

@jzgithub1 The above design will only work if we upgrade to the latest ZK 3.5. There may be other implications of that, so that should be done first, as its own task, before implementing the above.
An alternative might be to simply use fewer watchers in the first place, by changing the design for table config updates to use a single global watcher on a single field, named something like "/configChanged".

Thanks @ctubbsii .  Glad I didn't go down that road too far.

To be clear, I don't know for sure, which methods are our best bets in terms of simplifying the code or reducing the number of watchers. It may require some investigation, and prototyping of the various options. I just wanted to make sure whoever worked on this was aware that there are other possible solutions.

This is superseded by #1454


Move /authorlist to hep

Move /editor/authorlist/text to hep.
Tech Notes:

https://github.com/inspirehep/inspire-next/blob/master/inspirehep/modules/editor/api.py#L74-L82
Change routing on k8s

What about this view:
https://github.com/inspirehep/inspire-next/blob/2fe0a80ba872dd91ffdfec9134b8be7a7a0cc78c/inspirehep/modules/tools/views.py#L51-L71
Should we leave it on next?

What about this view:
https://github.com/inspirehep/inspire-next/blob/2fe0a80ba872dd91ffdfec9134b8be7a7a0cc78c/inspirehep/modules/tools/views.py#L51-L71
Should we leave it on next?

yes, this will go away once we switch off legacy.

yes, this will go away once we switch off legacy.


Fix release workflows by adding /dashboard/release to .gitignore

This should address an issue with current release*.yml workflows which fail on error=git is in a dirty state
I was able reproduce this issue on my fork and adding /dashboard/release dir to .gitignore resolved the issue.

already covered by different PR


The message This condition will always return true since the function is always defined is not shown

TypeScript Version:  3.8.3
Code
const foo = {
    test() {
        return true;
    }
}

if (foo.test) {
    console.log(true);
}

Expected behavior:
The message This condition will always return true since the function is always defined should be shown for the code if (foo.test)
Actual behavior:
no message
Playground Link: Example
It seems that happens when childSymbol.id and testedFunctionSymbol.id equal to undefined.
if (childSymbol && childSymbol.id === testedFunctionSymbol.id)

Using the playground link, after any change (for example add a space at start) the error appears.

Probably you already knows, but its a duplicate of #33792.

Yep, thanks @j-oliveras!

@sandersn I think it is similar to this issue https://github.com/microsoft/TypeScript/issues/35557, however, it is not related to QF.

Maybe, but this issue is fixed in master, whereas #35557 is not. I assumed incorrectly that it was a result of #33792, but I guess not.


User volume mounts broken

Following https://istio.io/latest/docs/ops/integrations/prometheus/#tls-settings, we get an unknown volume

nvm, user error


->getHeaderValue() is normalizing whitespaces

If I have this in the email (notice the two spaces):
Subject: foo  bar

...then $message->getHeader('subject')->getValue() and $message->getHeaderValue('subject') both give me this (notice the single space):
foo bar

I didn't look at your code yet, I wanted to ask you in advance: Are you doing this on purpose?
RFC 5322 says:

These are referred to as unstructured field bodies. Semantically, unstructured field bodies are simply to be treated as a single line of characters with no further processing (except for "folding" and "unfolding" as described in section 2.2.3).

Without investigating I couldn't say either, haha :) let me know if you manage to have a look before I do here.

I didn't read RFC 5322 from start to end. But as it says (see above): "with no further processing", I'm 99% sure that it's perfectly legal to have several whitespaces in the subject. After all, you certainly can have several whitespaces in the message's body ;-)
The problem comes from the fact that you split the subject on whitespaces into MimeLiteralParts. What's the purpose of that? Why don't you just keep it as a single string?

It's because 'Subject' can actually contain RFC 2047 mime-encoded parts... that may be simply considered an 'extension' to 5322, and you may still be right regardless though (haven't looked for clues why I'm not preserving more than one whitespace, or if it's intentional).

The reason this happens is this line here:
https://github.com/zbateson/mail-mime-parser/blob/1198b031303f9fdb521e5bad6ff2758d358dde47/src/Header/Consumer/AbstractConsumer.php#L228
Which as you've observed doesn't preserve multiple whitespaces in subjects (because the separator token is '\s+' as well).  This works well for RFC 2047 encoding when they're next to text or next to each other, and how that's supposed to work.

gmail always shows without the extra spaces
outlook web same
Thunderbird shows the extra spaces in the 'list' of messages, but doesn't in the message preview and view windows

I'm feeling torn on this one...
On the one hand, you're right -- the RFC doesn't specifically say they should be replaced by a single space as far as I can tell, but on the other hand I'm not sure most users would specifically write code to handle having the extra spaces either, and it may be more of an expectation that a subject wouldn't.
Open to hearing arguments on this one :).

Also I'm not sure in this case that my usual Thunderbird test is valid... in this case I'm looking at their "display" which is different from their parsing also.  Probably the Thunderbird 'positive' is more just that it wasn't handled specifically in that case, or that everywhere else it's being displayed as html anyway and supporting multiple spaces would be more work.

php-mime-mail-parser's $parser->getHeader('subject') does keep the whitespaces.
Thunderbird's Composer removes them upon composing of the message. But it does keep them on received (i.e. written elsewhere) messages in the source code, and in the messages' list in the main window. It removes them in the message's window itself.
But my main argument is the RFC :-)

Yeah, I already agreed with all of those -- my remaining question is about the value in changing what's there and user expectation.

Well, if you're asking me: You cannot be proud for following every RFC, and in this case ask for "user expectation"...

Hahaha... well you got me there I guess :+1:

Released in 1.3.0


Combo splash lags on spammy songs

What feature do you want to get added on the base engine?
Make a feature to disable combo splash not just visually, but completely disable counting.
It lags very much and i traced the issue to combo counting.
To test your sight, and reliability, please select the option of what should NOT be requested.
6k charts, stage editor blah blah

Try checking options again, there is Hide UI

Try checking options again, there is Hide UI

Thats sounds like visual, but ok ill try

@frantastic24 Nope, dosent work

not just visually, but completely disable counting.

It makes the UI not get rendered, if it's lagging then consider investing on a better PC

This sounds kinda false cuz it deletes the objects after their alpha tween is completed and my PC runs it fine


Labeling - ITU Racing

Hey, @ddavid , @Isydmr ! The wrong labeling on  ITU racings dataset caught my attention.
Here are some examples.
cju0a8eeb18k80835ygl5yk09.txt

cjtnj9pptrmjk0835v7gul4gp.txt

cjtyu71zs92zj0801lkgtnkaa.txt

I found a lot of this, could you please check this dataset?
Best regards,
Ivan

Hi Ivan,
will have a look at it together with some further changes to the GET dataset tomorrow.
Thank you for pointing this out.

Will have to postpone to tomorrow unfortunately.

Can confirm your findings, a few images are lacking labels and a lot of them have the wrong class - always one class for the whole image.
Tests were still being done by sampling back when the PR was done, that's probably why it went unnoticed.
Thank you for pointing this out here.
I'll prepend a prefix to the directory name and labels so others notice it. The data set should definitely not be used until the labeling is fixed.
@Isydmr Could you please look into the mislabeled files?

I'll contact my team about this, will inform you when we fix labels.
Thank you for your understanding.

PR opened with revised labels #64

Thank you for reporting our mistakes guys, we improved our labeling a lot.
It is very nice to see the continuous growth of this dataset.
This issue can be closed. #64 merged by @ddavid.


Add Fairing release team

Add Fairing release team

/assign @jlewi
Thanks!

@jlewi Updated as your comments. Thanks.

/lgtm
/approve