did the package support cassandra 2.1.9  and spark 1.5.0  .....

thanks a lot!

@frensjan @jeanpaul

not support yet

@ZhenxingWu what's is not supported? cassandra 2.1.9 or spark 1.5?

@tmbo
not supported in spark 1.5, while I suggest you direct use datastax's spark cassandra connector.
it didn't fully support pyspark, but do support read/write on DataFrame
https://github.com/datastax/spark-cassandra-connector/blob/master/doc/15_python.md

The DataFrame option is most certainly one not to ignore. It probably has better performance in comparison to pulling the data into pyspark. But sometimes you want to ... :)
Spark Cassandra Connector 1.4 is supported in the 0.2 branch. While the datastax crew indicates that this would not be compatible with Spark 1.5, I have been able to use this combination.
Cassandra 2.1 and 2.2 should be supported, see https://github.com/datastax/spark-cassandra-connector#version-compatibility


Develop - moving latest to main branch

@PaulLinYao - Can you review the conflicts in this pull request and resolve? This is in marketplace merging develop into master.
.github/workflows/tests-in-browser.yml
.github/workflows/tests.yml


Ensure Rack::MethodOverride

Similar to https://github.com/Shopify/maintenance_tasks/issues/926, Rails API mode doesn't include the middleware that converts POST to PUT calls leading to Routing Errors.
Possible solutions:

Create a custom controller and set the parent to that.
Generator checks for all required middleware and adds them to the application.

References https://github.com/Shopify/sidekick-server/issues/728

Would you be interested in contributing these changes?

We should stop using PUTs and switch to POSTs.


The Flutter is embedded in a native FlutterFragment, but the system return key cannot be listened to using WillPopScope

The Flutter is embedded in a native FlutterFragment, but the system return key cannot be listened to using WillPopScope
Here's the code for the Android native side

Here is how the return key is handled in the native

Listening in Flutter

@lv823063712
Please provide flutter doctor -v and a complete minimal reproducible code sample in text format that we can use to replicate the issue. Also provide what should be  the expected behavior / result as compared to actual behavior when we run the code.
Thanks.

`
[√] Flutter (Channel stable, 1.22.2, on Microsoft Windows [Version
10.0.18363.1139], locale zh-CN)
• Flutter version 1.22.2 at E:\job\flutter\flutter
• Framework revision 84f3d28555 (3 weeks ago), 2020-10-15 16:26:19 -0700
• Engine revision b8752bbfff
• Dart version 2.10.2
• Pub download mirror https://pub.flutter-io.cn
• Flutter download mirror https://storage.flutter-io.cn
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2
)
• Android SDK at E:\job\androidSDK
• Platform android-30, build-tools 30.0.2
• ANDROID_HOME = E:\job\androidSDK
• Java binary at: E:\job\androidStudio\jre\bin\java
`
Specific question me a more detailed description, is me in my android native project, to replace the home page, patients, the three fragments of my module, and then in my module jump to other page weight, return key when I click on my system, is expected to happen should return to the 'I' the weight, but the Activity of my native project prompted again, click the back button will exit the APP.
That's a lot of code and I think the screenshot that I gave you clearly illustrates my presentation logic.

I want to click the system's back key when I'm on another Weight page to return to my previous weight, rather than responding to my native Activity action

@lv823063712
We will need a minimal reproducible code sample that will help to analyse the issue better. You provided code in screenshots that we can't use.

I already wrote the Demo .The address of the native Android project is https://github.com/lv823063712/FlutterDemo ,The address of the mashup project Flutter is https://github.com/lv823063712/Flutter_lab,I think you can see what I'm trying to say from these two demos

Can confirm, no issues on the latest master on API 23

flutter doctor -v
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: TextField(),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

logs
[✓] Flutter (Channel master, 1.24.0-8.0.pre.268, on Microsoft Windows [Version 10.0.19042.630], locale en-US)
    • Flutter version 1.24.0-8.0.pre.268 at C:\Code\flutter_master
    • Framework revision e803b13f01 (7 hours ago), 2020-11-16 22:55:59 -0800
    • Engine revision f0e80100f7
    • Dart version 2.12.0 (build 2.12.0-49.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Code\sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = C:\Code\sdk
    • Java binary at: C:\Code\android-studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.1)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.8.30711.63
    • Windows 10 SDK version 10.0.18362.0

[✓] Android Studio (version 4.1.0)
    • Android Studio at C:\Code\android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] VS Code (version 1.51.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.16.0

[✓] Connected device (5 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 6.0 (API 23) (emulator)
    • Windows (desktop)                  • windows       • windows-x64    • Microsoft Windows [Version 10.0.19042.630]
    • Web Server (web)                   • web-server    • web-javascript • Flutter Tools
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 86.0.4240.198
    • Edge (web)                         • edge          • web-javascript • Microsoft Edge 86.0.622.69

• No issues found!

Hi @lv823063712
I see that you're flutter_boost  in your app, can you provide a code sample without using a third-party package
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


nginx: detect duplicate modules

Nginx breaks at runtime when duplicate modules are added. To detect this, add a name key to all modules.

@ncfavier It may not be necessary to change name of modsecurity-nginx module?

I changed it for uniformity with the other modules. There's no need to include nginx or module in the name of something that's exposed under nginxModules.

Also here pkgs/top-level/all-packages.nix:
  tengine = callPackage ../servers/http/tengine {
    openssl = openssl_1_1;
    modules = with nginxModules; [ rtmp dav moreheaders modsecurity-nginx ];
  };

Yeah, I just changed it treewide, forgot to do that earlier.

And nixos/tests/nginx-modsecurity.nix.

I guess we can't use lib.warn because of NIX_ABORT_ON_WARN

I guess even builtins.trace isn't allowed. Oh well.

@ofborg test nginx-modsecurity


Add validators for model constraints

astropy serializes the following properties:
fixed
bounds

but these are not documented in the schemas.

Fixed by PR #34


Can not delete comment

comment not deleting, when I use
let result = await client.deleteComment({ mediaId: media.graphql.shortcode_media.id, commentId: "17910681670083819" })
console.log(result)

response is { status: 'ok' }, but comment is on it's place
When I try to delete not my comment response is {"message":"You cannot delete this comment","status":"fail"}, as expected

I wasn't able to reproduce this problem on my end. But i think it's caused by the Instagram API itself, and can't be fixed by this module.
Closing this issue for now.


Add Code of Conduct

We recommend that every repo has a code of conduct. If you don’t feel comfortable creating your own Code of Conduct from scratch we highly recommend using one of the templates provided by GitHub. If you do use a template, please read through the template and ensure that you can and will abide by the Code of Conduct.
Please follow these instructions on how to add a Code of Conduct.
Sample: https://github.com/Recode-Hive/Stackoverflow-Analysis/blob/main/CODE_OF_CONDUCT.md

Hey @Princegupta101 , kindly assign me the issue.

I would like to work on this issue. Please assign me this task.

We already have Code of Conduct file


Creating xml folder for image/flowchart sources

Due to crickets, merging as is. If you'd like to improve the images - please grab the xml files and edit and upload replacement xml and image files :)


Webpack skips changes to files when compilation is suspended

Bug report
What is the current behavior?
This is an issue with suspend and resume flow of Watching. The second and subsequent aggregated changes that occur after suspend are dismissed by webpack.
If the current behavior is a bug, please provide the steps to reproduce.

Call suspend.
Edit file1
Wait when aggregation timeout passes (and aggregated watchpack event fires)
Edit file2
Call resume.

What is the expected behavior?
The compilation contains changes from both file1 and file2
Actual result: only changes from file1 are applied. Changes to file2 are skipped by webpack.
I've opened a PR with a failing test that demonstrates the problem (and suggested fix): #12897
Other relevant information:
webpack version:  latest (but also exists in v4 latest)
Node.js version: 12
Operating System: Windows
Additional tools: no

Please prefer to use the one issue to track all problems with suspend and resume, looks it is side effects of the one problem

No, those are actually different bugs (they hit different codepaths). Fixing one won't fix the other. That's why I've opened two issues.

Fixed by https://github.com/webpack/webpack/pull/13399


Firefox 51.0.1  activates rejectStyle even on accepted file types.

In Firefox 51.0.1, the dropzone initiates the rejectStyle even though a file is of the accepted type. The drop and upload still works fine but the UI indicates otherwise.

Looks like Firefox broke it. I believe it should be fixed in Firefox since it looks like they broke the HTML5 API. Fancy to submit a bug to them?

Hopefully this gets some traction. Please feel free to add some clarity around the issue if you can.
https://bugzilla.mozilla.org/show_bug.cgi?id=1342057

None of the workarounds proposed in the Firefox bugtracker are any good, since they happen on a drop() event, and not on dragEnter events. Until they fix it upstream, we should at least make it look like all attachments are accepted while dragging, which brings us to parity with Safari (which doesn't support file types on drag items at all). A false positive is better than a false negative here. PR #382 implements this.


Present modal with custom transition

Changed to make view controller presentable as modal VC using custom transition.
Only made a custom transition for the presentation, not the dismissal, where it's not necessary (uses the existing animation).

I was testing this on a real device, and there is a point when you dismiss the ImageViewer, and the entire UI stops receiving touches.

Ok, so with the Close Button action to dismiss, it works. When you flip to dismiss, the rest of the UI stops responding.

Ok sorry, forgot to adjust the swipe to dismiss code to handle VC being presented. Now fixed.

It's working now. Do you think it would take a lot of work to use transitions for the dismiss? This way we would close the circle.

@mluisbrown  Btw, do you still need this code?
        guard let rootController = self.applicationWindow?.rootViewController else { return }

        self.view.frame = UIScreen.mainScreen().bounds
        self.applicationWindow!.addSubview(self.view)
        rootController.addChildViewController(self)
        self.didMoveToParentViewController(rootController)

Shouldn't be too much work to use transitions for the dismiss too. Regarding that code block, it depends if you want to be maintain the ability to use show() instead of presentViewController. If not, then we can remove the show method altogether (and a few other ifs where we check if the VC was presented or not)

I was thinking about adding an extension to a UIViewController:
extension UIViewController {

   func presentImageViewer(imageViewer: ImageViewer, completion: Void -> Void = {}) {
      self.presentModalViewControlle(imageViewer, completion: completion)
  }
}

The thing is, if you don't remove the show, then you can't remove this as well:
-                    self.view.removeFromSuperview()
-                    self.removeFromParentViewController()

By removing the show, it makes the inner logic simpler.

@mluisbrown what's your feeling about the extension on an UIViewController?

I think it's a great idea.

A small bug with the status bar:

Made changes as per your suggestions. Status bar jump is fixed, but in-call status bar behaviour remains awful. I couldn't find a solution. Using windowLevel doesn't work either and is actually worse (ImageView window shifts down with no visible status bar)


inlay hints cannot be shown just after openning project, edit is necessary to trigger the generation

Inlay hints isn't shown directly, I always need to do some modifications to make it works, the first fetchHints is always empty array as you can see from the following screenshot:
https://user-images.githubusercontent.com/33961674/87353897-f5853680-c55d-11ea-9fa4-cc8edc5eb664.png
I tested coc-rust-analyzer & vscode, they both have this issue
I believe it's because the analysis hasn't finished? Because after adding a sleep(30) in fetchHints, it can be correctly rendered.
So the first fetchHints has been called too early and RA just returned empty hints:
https://user-images.githubusercontent.com/33961674/87353897-f5853680-c55d-11ea-9fa4-cc8edc5eb664.png

See also: https://github.com/fannheyward/coc-rust-analyzer/issues/317

If it's hard to detect when the analysis really finishes, maybe we can just return back an error? So that client can retry...

We can wait until workspace loaded progress end notification on the frontend, but in fact this indeed looks like a race condition in current impl such that it returns empty arrays from time to time.
@matklad do you think we can alleviate this race condition on the server side?

Yup, this is the same problem as with semantic tokens, pure pull model does not work here. I think I still believe that Dart's subscriptions are fundamentally better here than what LSP is trying to do:
https://htmlpreview.github.io/?https://github.com/dart-lang/sdk/blob/master/pkg/analysis_server/doc/api.html#request_analysis.setSubscriptions


Build & upload mypyc wheels

GitHub workflow from black as they have done a lot of work with mypyc.
Signed-off-by: nstarman<EMAIL_ADDRESS>PR Checklist

[x] Check out the contributing guidelines and code of conduct
[x] Check out the contributing workflow ( for a practical example click here )
[x] Give a detailed description of the PR above.
[x] Document changes in the CHANGES.rst file. See existing changelog for examples.
[x] Add tests, if applicable, to ensure code coverage never decreases.
[x] Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
[x] Ensure linear history by rebasing, when requested by the maintainer.

There doesn't appear be a good way to test this without merging. Here goes nothing...


[dv,usbdev] Update USBDEV DV documentation

This PR updates the DV documentation for USBDEV to reflect the changes to the DV environment:

Inclusion of the additional support modules and interfaces within the testbench.
Addition of covergroups for the collection of functional coverage.
Modifications to the usbdev_scoreboard class to perform the checking of register traffic and USB packet responses against expectations produced by a functional model of USBDEV.
Inclusion of the functional model that predicts the desired response of the DUT to any USB stimulus such as packet transfers and bus-level events including suspend-resume signaling, bus resets and connections/disconnections.

Thanks to Elliot Baptist<EMAIL_ADDRESS>for creating the block diagram.

Thanks for the feedback. I was unaware of the description of dotted blocks, but thought perhaps we wanted the legend to be the same across IP blocks; it's now gone. I was unware of the expectations on markdown files, since they are loosely formatted.


geerlinguy ansible role versions

Describe the bug
setup fails on ./tads ansible-playbook localhost provision
reports that pip is not found - apperas to be an error with the gerrlingguy.pip role. Solved this issue by updating the
requirements.yaml to the following:
###
# ansible-galaxy requirements
##
# Automatically installed before each T.A.D.S. Ansible command
##

- src: geerlingguy.pip
  version: 2.1.0

- src: geerlingguy.docker
  version: 3.1.2

To Reproduce
Follow the exact steps in the README.
Expected behavior
Expected deployment to work as shown in demo video.
Environment (please complete the following information):

OS/distro: Ubuntu 20.04 desktop
Ansible version: 2.9.6
Terraform version: v0.15.5
Cloud provider: n/a
Vagrant version: 2.2.6

Additional context
note the default version of terraform installed by the script is now outdated.

also seeing some other issues that may be related... for example the example-app will service will not deploy properly, and gives the following error:
invalid mount {Destination:example_app_config Type:bind Source:/var/lib/docker/containers/17c307cf5e86612af32f22bec02f49d53a9d2750d2f2b055399bac7246a0daf7/mounts/secrets/yswm4jimsbpwfcdggawjst6j0 Options:[rbind ro]}: mount destination example_app_config not absolute: unknown"

and could be related to this:
https://github.com/moby/moby/issues/42480

The following happened on Ubuntu 20.04.
For the provided versions:
`- src: geerlingguy.pip
version: 1.3.0

src: geerlingguy.docker
version: 2.5.3`

i had to install python3-pip on cloud machine, provision-00-common.yml:
    - name: Install Pip
      become: True
      apt:
        name: python3-pip

and tell geerlingguy.pip where the bin is, provision-01-docker.yml:
    - role: geerlingguy.pip
      pip_package: python3-pip


[DO NOT MERGE] Make run script optional

This makes the run script optional. In case the run script is not provided, the CMD used in the builder image will be reused.
Fixes #114.
Warning
This is work in progress. Currently it always uses the CMD set in the builder image and ignores the provided run script.

Hey @soltysh - since I do not know the STI codebase - any idea how to make STI check if there is the run script provided or not? I was looking for some simple mechanism that is already built into STI, but it seems there is nothing like this. Can you confirm this? Feel free to add notes to the code and/or extend it to make it work like it should :)

@goldmann have a look at build.go#determineIncremental where we check for save-artifacts existence. The tricky part here is that when scripts are embedded into the image (eg. STI_SCRIPTS_LOCATION=image:///opt/sti/bin) then there's no way of checking its existence other than actually running the image. In our case (save-artifacts) we just assume its existence, and we'll warn the user if it's not there. In all other cases (meaning when you downloaded scripts) the situation is easier, you just do h.fs.Exists. That means there's no such method for checking that, since we've done it only once so far (for save-artifacts), so you're welcome to create one :smile:

Thanks a lot for the comments, I'll look at it in a bit!

@goldmann talking to @bparees we've come up with solution for checking for the run script while using the embedded scripts. You need to extend the build process in such a way that it should check for the run script existence.

Have a look here where we invoke untarring and assemble in one step, I'm guessing you'd have to come up with some smart idea to check for run existence in this step :wink:

@soltysh @goldmann what is the status of this? is this resolved already?

@mfojtik it's not, I've trelloed that to cover that https://trello.com/c/oDj441HE/571-make-run-script-for-sti-optional

I had no time to work on this PR more, I'm pretty sure it's badly outdated right now.

I'm hoping to work on that after GA.

@soltysh I wish we can have labels on issues ;-) @danmcp is this something you can enable for us?

:+1: on that idea

@soltysh @mfojtik There isn't a way to separate push access and the label capability.  So we only have a couple of options.  Either:

Give everyone push access.  Or more people at least.
or
Write a bot that can label and unlabel on request.

I am fine with doing 2).  I am not sure 1) is feasible.

I'm for 2 if it's the simplest solution.

@goldmann @soltysh I think we can close this now?

:+1: pretty outdated as of now.

Although the PR is outdated, the request is still valid. I guess I'll not be able to finish this PR myself :(

There's an issue (#114) that tracks that request.

Right, I forgot about it, closing this PR in that case.


Add coverage reports

via travis and codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@06c6cc1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #17   +/-   ##
=========================================
  Coverage          ?   55.77%
  Complexity        ?      406
=========================================
  Files             ?       59
  Lines             ?     2010
  Branches          ?      130
=========================================
  Hits              ?     1121
  Misses            ?      831
  Partials          ?       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c6cc1...b88d7a9. Read the comment docs.


Test tree sitter based syntax highlighting for typescript

Refs: https://github.com/microsoft/vscode/issues/210475

[x] macOS @lramos15
[x] linux @justschen
[x] windows @Tyriar

Complexity: 3
Create Issue

We're exploring using tree-sitter for syntax highlighting. We don't yet have all the same features as we do with textmate, but there's enough now to try it out.
Known issues:

Regular expressions aren't highlighted
string, number, and boolean are all highlighted incorrectly due to a change being reverted last night.

Steps

Set this hidden setting:

  "editor.experimental.preferTreeSitter": [
    "typescript"
  ],

Open some typescript files. Look for issues where the color of editor tokens isn't what you expect. Please share snippets, screenshots, and theme info for issues you find.
Try editing typescript files and make sure that the colorization stays correct.
If you can, please leave the setting from step 1 set and selfhost tree-sitter.

Thank you for all the good issues!


Thank you!

Just leaving this here: this is exactly what I was looking for! Thank you for your work and that you published it here!

Thanks and you're welcome :-)


Webpack configuration specifically because of empty rule tests

Category

[x] Question
[ ] Typo
[ ] Bug
[ ] Additional article idea

Expected or Desired Behavior
Documentation on default webpack configuration. More specifically the generatedConfiguration.
Observed Behavior
I case additional loader or configuration changes should be added the webpack configuration the following script can be used:
build.configureWebpack.mergeConfig({
  additionalConfiguration: (generatedConfiguration) => {
    /** Do something **/
    return generatedConfiguration;
  })
}

There is just one big question mark in case of the generatedConfiguration this object passed to the function contain the folliowing content.
{
  "module": {
    "rules": [
      {
        "use": [
          {
            "loader"<EMAIL_ADDRESS>            "options": {
              "async": true
            }
          },
          {
            "loader": "/Volumes/Code/research/webpack-performance/node_modules/css-loader/index.js",
            "options": {
              "minimize": true
            }
          }
        ],
        "test": {}
      },
      {
        "use": [
          {
            "loader"<EMAIL_ADDRESS>            "options": {
              "name": "[name:lower]_[hash].[ext]"
            }
          }
        ],
        "test": {}
      },
      {
        "use": [
          {
            "loader": "/Volumes/Code/research/webpack-performance/node_modules/html-loader/index.js"
          }
        ],
        "test": {}
      },
      {
        "test": {},
        "enforce": "pre",
        "use": "/Volumes/Code/research/webpack-performance/node_modules/source-map-loader/index.js"
      }
    ],
    "noParse": [
      {}
    ]
  },
  "resolve": {
    "alias": {},
    "modules": [
      "node_modules",
      "lib"
    ]
  },
  "context": "/Volumes/Code/research/webpack-performance",
  "devtool": "source-map",
  "mode": "development",
  "entry": {
    "high-performance-web-part": "/Volumes/Code/research/webpack-performance/lib/webparts/highPerformance/HighPerformanceWebPart.js"
  },
  "externals": [
    "@microsoft/sp-lodash-subset",
    "@microsoft/sp-core-library",
    "@microsoft/sp-office-ui-fabric-core",
    "@microsoft/decorators",
    "@microsoft/sp-diagnostics",
    "@microsoft/sp-dynamic-data",
    "@microsoft/sp-polyfills",
    "@microsoft/sp-http",
    "@microsoft/office-ui-fabric-react-bundle",
    "@microsoft/sp-page-context",
    "@microsoft/sp-loader",
    "@microsoft/sp-component-base",
    "@microsoft/sp-property-pane",
    "@microsoft/sp-webpart-base",
    "@microsoft/sp-extension-base",
    "@microsoft/sp-application-base",
    "@microsoft/sp-client-preview",
    "@microsoft/sp-webpart-workbench",
    "webpack-performance",
    "react",
    "react-dom",
    "HighPerformanceWebPartStrings"
  ],
  "output": {
    "chunkFilename": "[id].[name]_[chunkhash].js",
    "filename": "[name].js",
    "library": "8d5e0295-b233-4295-9930-9c048ba0438c_0.0.1",
    "libraryTarget": "amd",
    "path": "/Volumes/Code/research/webpack-performance/dist",
    "devtoolModuleFilenameTemplate": "webpack:///../[resource-path]",
    "devtoolFallbackModuleFilenameTemplate": "webpack:///../[resource-path]?[hash]"
  },
  "plugins": [
    {
      "options": {
        "scriptName": {
          "name": "\\/[name](_[a-z0-9-]+)*\\\\.js",
          "isTokenized": true
        }
      }
    },
    {
      "definitions": {
        "process.env.NODE_ENV": "\"dev\"",
        "DEBUG": true,
        "DEPRECATED_UNIT_TEST": false,
        "NPM_BUILD": false,
        "DATACENTER": true
      }
    }
  ]
}

More specificly the rules all contains empty tests to check which file which loader should use. So the question is how does it work and is this supposed to work? Why multiple rules when basically are all for any project.
I guess there must be some black magic happing with the webpack configuration behind the scenes because it basically works somehow.

My understanding is that when there's no test: {} specified, everything is passed into the loader. The loaders may have their own filter logic in them. In other projects, I've seen where test:{} is the default value so since the config is built in memory & you're just writing it out, you might just be seeing the default.

Well not really. The "In Memory" webpack configuration is invalid where it will be applied and still has the same empty tests in there for one. (Could be that I look at the wrong place)
Second, it doesn't make sense to apply all the rules on files in the lib folder when there are different files in there. CSS/JS mostly.

@StfBauer said:

Well not really. The "In Memory" webpack configuration is invalid where it will be applied and still has the same empty tests in there for one. (Could be that I look at the wrong place)

Then how does it work if it's invalid? If you don't do anything, that's what it uses & it builds... so... what's invalid about it?
@StfBauer said:

it doesn't make sense

Agreed, but that's more a matter of opinion than a fact ;)

Well, that is the big mystery. Well like I send I saved the configuration that goes right in the Webpack process. I might need to have a third look into that. 😀

Agreed, but that's more a matter of opinion than a fact ;)

In case of Webpack more a fact than opinion. For example in the case of "loader-load-themed-styles" and CSS loader only CSS should be affected and not really a JavaScript.


Allow both the summary and description from OpenAPI to be added as summary and remarks in c# generated code

The following changes will add the description property from an OpenAPI operation under the <remarks> xml comment in c# client code. Unit tests were updated to check for the annotations. My OpenAPI specs are typically quite detailed in the summary and description and and I wanted to add that documentation to the generated controllers and clients.

Thanks for the PR.


Wasm Reactor Module Initialization

Instead of calling _start, _initialize should be used per https://nodejs.org/api/wasi.html#wasiinitializeinstance.
An example is to support Haskell Wasm Reactor Module:
    // initialize Haskell Wasm Reactor Module
    wasi.inst = inst;
    inst.exports._initialize();
    inst.exports.hs_init(0, 0);

Full example: https://github.com/hellwolf/haskell-examples/blob/master/2023-02-24-wasm-comm/client.js
What is your recommendation?

Yep!


Releases compiled with older Elixir

Release v0.3.3 was compiled with Elixir 1.6.1 even though the minimum requirement is ElixirLS is 1.7
❯ ~/.elixir_ls/language_server.sh
Content-Length: 111

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Started ElixirLS Fork v0.3.3","type":4}}

Content-Length: 131

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Elixir version: \"1.6.1 (compiled with OTP 19)\"","type":4}}

Content-Length: 105

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Erlang version: \"20\"","type":4}}

What that log is showing is the version of elixir that the language server is currently running under, not the version that it was compiled with (which currently isn't shown although it could be added in #229). So it appears that ElixirLS is picking up 1.6.1 either from your global elixir version or from asdf. How did you install Elixir and Erlang?
Although, it would probably be good for ElixirLS to return an error or refuse to start on an unsupported version of Elixir.

Just to add to this: my dotfiles automatically compile elixirls when installed with vim plug and just came across this issue. I use a global .tool-versions with Elixir 1.10 and the compilation failed with:
asdf: No version set for command mix
you might want to add one of the following in your .tool-versions file:
# installed elixir versions

due to the local .tool-versions being the one that gets picked up when compile.

@frm If you run asdf install from the repository then asdf will install the versions used for compiling releases. It is important to use a lower version for compatibility since you won't be able to run any code on an earlier version.

@mwoods79 did you find out what .tool-versions was being used?

@axelson yes, and thank you for your help. I had a brew installed elixir and an asdf installed elixir on this machine.


StackBlitz does not print correct error message? Unexpected identifier '𝐬𝐛_𝐞𝐱𝐩𝐨𝐬𝐞'

Description of Bug
Trying to build a docusaurus site with errors leads the error message being printed badly.
Note: we use TC39 Error cause, this might be the reason?
Steps to Reproduce
Go to https://stackblitz.com/edit/github-ikeyac?file=docs%2Ftutorial-basics%2Fmarkdown-features.mdx
Run yarn build
See weird error message displayed in StackBlitz:

Expected Behavior
The correct error message when running outside StackBlitz:
[INFO] [en] Creating an optimized production build...

✔ Client

✔ Server
  Compiled successfully in 7.72s

● Client █████████████████████████ cache (99%) shutdown IdleFileCachePlugin
 stored

● Server █████████████████████████ cache (99%) shutdown IdleFileCachePlugin
 serialize pack

Error: Unable to build website for locale en.
    at tryToBuildLocale (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/core/lib/commands/build.js:55:19)
    at async mapAsyncSequential (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/utils/lib/jsUtils.js:44:24)
    at async Command.build (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/core/lib/commands/build.js:82:21) {
  [cause]: Error: Docusaurus found broken links!

  Please check the pages of your site in the list below, and make sure you don't reference any path that does not exist.
  Note: it's possible to ignore broken links with the 'onBrokenLinks' Docusaurus configuration, and let the build pass.

  Exhaustive list of all broken links found:
  - Broken link on source page path = /docs/CustomPickSectionItem:
     -> linking to EndpointIPAMConfig.md (resolved as: /docs/EndpointIPAMConfig.md)
  - Broken link on source page path = /docs/EndpointSettings:
     -> linking to EndpointIPAMConfig.md (resolved as: /docs/EndpointIPAMConfig.md)

      at throwError (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/logger/lib/index.js:79:11)
      at reportBrokenLinks (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/core/lib/server/brokenLinks.js:242:47)
      at handleBrokenLinks (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/core/lib/server/brokenLinks.js:274:5)
      at buildLocale (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/core/lib/commands/build.js:192:47)
      at async tryToBuildLocale (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/core/lib/commands/build.js:46:20)
      at async mapAsyncSequential (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/utils/lib/jsUtils.js:44:24)
      at async Command.build (/Users/sebastienlorber/Desktop/docusaurus-reproductible-broken-link/node_modules/@docusaurus/core/lib/commands/build.js:82:21)
}

[INFO] Docusaurus version: 3.1.1
Node version: v20.11.0
error Command failed with exit code 1.

The error cause is appropriately printed, and display useful information to troubleshot the problem.
Additional Context/Questions
StackBlitz is useful for Docusaurus users to provide reproduction cases, and also for me as a maintainer to not have to run repro code locally for security.
Seeing obfuscated errors unfortunately forces me to run the code outside StackBlitz to be able to see the good expected error message.
Otherwise, Docusaurus keeps building fine in StackBlitz 👍

Is this still an issue? I opened the project and it seems to be building fine. I know we had issues in the past with the encoding, but we fixed that. Maybe we did miss something though.

I'll look into it tomorrow.
Not sure why but yarn install became much slower recently on https://docusaurus.new/stackblitz-ts
It hangs forever on this step:

Running yarn build on the provided repro still gives me this error:

Oh I see. Thanks for the additional information. It could be that it's because of the vm.Script. We don't support all features as it's very trick to get right and to get everything working as it should.
yarn install does feel pretty slow indeed. This might be related to a change we made not too long ago. I'll see if I can investigate this but can't promise anything in regards to timing.

@slorber Just wanted to let you know that we prioritized the slow yarn install issue and I'm actively working on resolving that. Will keep you posted.

Thanks @SamVerschueren !
Regarding the other sb_expose error, it might be vm.Script as well be due to using webpack stats. I've always thought it a bit hard to reason about, and sometimes it's difficult to figure out how to print full stack traces from Webpack errors.


Cannot delete original objects from server

Hello,
I cannot figure out how to delete the original example objects from the server.

Bianco Royal
Device Set
Server*
Tanks

I assume Server is needed for OPC UA to work.

Yes, Device Set and Server are part of the OPC UA server and not to delete.
delete the Bianco Royal and Tanks folder via Command :

It seems like I cannot get this to work.
Here are screenshots of my setup:

Please, send the flow or an example.
Sent with GitHawk


Add a Rust implementation of the Supply Chain Transaction Processor

In anticipation of being able to deploy WASM smart contracts, it is desirable to have the Supply Chain transaction processor implemented in Rust.
This is contributed by Cargill.

I would approve this but can't as PR submitter; I do approve it.


JDK isn't correctly detected

Result from CocInfo

Description
A clear and concise description of the bug and how to reproduce it.
I have openjdk-8-jdk installed and JAVA_HOME set, but coc-kotlin cannot detect it and keep giving warnings:
JAVA_HOME: /usr/lib/jvm/java-8-openjdk-amd64/jre
Extension version
Which version of the extension you are running.
Additional context
More information or screenshots.

I use:
export JAVA_HOME="$(java -XshowSettings:properties -version 2>&1 > /dev/null | grep 'java.home' | awk -F= '{print $2}' | tr -d '[:space:]')"

in my .zshrc to set JAVA_HOME.

I use:
export JAVA_HOME="$(java -XshowSettings:properties -version 2>&1 > /dev/null | grep 'java.home' | awk -F= '{print $2}' | tr -d '[:space:]')"

in my .zshrc to set JAVA_HOME.

Please provide warnings log

Please provide warnings log

hi @weirongxu are you able to reproduce it?

Can't reproduce it yet, I have some doubts that variable does not point to a JDK, it's not from this extension, maybe from LSP, so I'm not sure what the problem is.


Feature Request: 'Open in VSCode' option in Windows context menu

I would like a feature where you can right click an empty space in a folder and select 'Open in Visual Studio Code' to open the folder in VSCode. Visual Studio already has this feature, would be nice to have it implemented in VSCode as well!

Assuming request is for Stable on Windows 11. related issues include:

https://github.com/microsoft/vscode/issues/204696
https://github.com/microsoft/vscode/issues/183297

I think this is already available in Insiders.

@gjsjohnmurray thank you. 2 questions -

is Insiders a completely separate branch or does it eventually get merged into the regular VSCode?
Would the feature work on Windows 10 as well, or only Windows 11?

https://github.com/microsoft/vscode/issues/127365
It's seem completed in Insiders Version before 1.5 years, Insiders Version work fine in my computer. Why not bring to Stable Version.


Copy link feature

Fixes Issue
closes #51
Changes proposed

Check List (Check all the applicable boxes)

[ x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[x ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

hmm still looks like you have 3 commits. And also please close previous PR. Try to update your main branch with mine. Then create a branch, do your changes and push.
Or you can reset back your changes on your current branch and rebase it to main. Then make your changes and push.

@furkanmutlu  I did exactly that, updated my main with yours, however the ahead commits didn't get removed, the only way I removed them is by creating a new branch from updated main  -> deleted the old one ->rename the new one to main however doing that require a new commit, I'm not sure but I guess my main will always be ahead a couple of commits even after rebase (because that's will require a new commit)  unless I refork and reclone the whole repo. correct me if I'm wrong

I did exactly that, updated my main with yours, however the ahead commits didn't get removed, the only way I removed them is by creating a new branch from updated main -> deleted the old one ->rename the new one to main however doing that require a new commit, I'm not sure but I guess my main will always be ahead a couple of commits even after rebase (because that's will require a new commit) unless I refork and reclone the whole repo. correct me if I'm wrong

hmm.. First of all click Sync fork in your fork. Then go to your local main branch and do a git pull. Then go to your branch(copy-link-feature) try to do git reset [commit id of the head]. To see commit id for HEAD, do git log and copy id of the HEAd. Basically it will reset your commits to have a branch same with main. Then your commits will be converted to changes. Do git stash to stash your changes. Then just in case do git rebase main. Then bring your changes back with git stash apply. Then make your 1 commit. and force push git push --force-lease.

This worked! but only when I didn't rebase to main, I just did git reset to latest head commit, commited my changes and push.
I will try to do the same think to my main to fix it, Thank you!


scatter is both a function and a method

What does this PR do?
Allows scatter and scatter_ to be methods in addition to raw functions.
This is needed for NeVA: https://github.com/NVIDIA/NeMo/blob/ca94e032cf9f2c1920f7d5e55dcaa0de9c2abd70/nemo/collections/multimodal/models/multimodal_llm/neva/neva_model.py#L256.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Tests that are failing do not fail locally and don't seem related; marking ready for review.


Update README.md

[[package]]
name = "derive_builder"
version = "0.10.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "d13202debe11181040ae9063d739fa32cfcaaebe2275fe387703460ae2365b30"
dependencies = [
 "derive_builder_macro",
]

the latest toml pulls version 0.10.2
where build() returns Result<>

Thank you! Let me know if you have any idea or question with this library.


Use a separate instance of Application Insights for Debug/Development

Use a different instance of Application Insights in Development. jjgnet-test should already be available.

Functions are logging to the correct instance based on environment


Dedupe response header filter

Filter that de-duplicates response filter values. Comes handy when e.g. both the gateway CORS logic and a downstream add Access-Control-Allow-Credentials and Access-Control-Allow-Origin headers. See https://github.com/spring-cloud/spring-cloud-gateway/issues/728 for additional context.

Codecov Report

Merging #866 into 2.0.x will increase coverage by 0.14%.
The diff coverage is 87.87%.

@@             Coverage Diff              @@
##              2.0.x     #866      +/-   ##
============================================
+ Coverage     70.98%   71.13%   +0.14%
- Complexity      969      980      +11
============================================
  Files           131      132       +1
  Lines          3788     3821      +33
  Branches        274      277       +3
============================================
+ Hits           2689     2718      +29
- Misses          955      957       +2
- Partials        144      146       +2

Impacted Files
Coverage Δ
Complexity Δ

...cloud/gateway/route/builder/GatewayFilterSpec.java
60.78% <0%> (-1.22%)
37 <0> (ø)

...cloud/gateway/config/GatewayAutoConfiguration.java
98.34% <100%> (+0.01%)
61 <1> (+1)
:arrow_up:

...tory/DedupeResponseHeaderGatewayFilterFactory.java
93.33% <93.33%> (ø)
10 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2acad9...a4bb1f2. Read the comment docs.

Codecov Report

Merging #866 into 2.0.x will increase coverage by 0.14%.
The diff coverage is 87.87%.

@@             Coverage Diff              @@
##              2.0.x     #866      +/-   ##
============================================
+ Coverage     70.98%   71.13%   +0.14%
- Complexity      969      980      +11
============================================
  Files           131      132       +1
  Lines          3788     3821      +33
  Branches        274      277       +3
============================================
+ Hits           2689     2718      +29
- Misses          955      957       +2
- Partials        144      146       +2

Impacted Files
Coverage Δ
Complexity Δ

...cloud/gateway/route/builder/GatewayFilterSpec.java
60.78% <0%> (-1.22%)
37 <0> (ø)

...cloud/gateway/config/GatewayAutoConfiguration.java
98.34% <100%> (+0.01%)
61 <1> (+1)
:arrow_up:

...tory/DedupeResponseHeaderGatewayFilterFactory.java
93.33% <93.33%> (ø)
10 <10> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2acad9...a4bb1f2. Read the comment docs.

Should this be implemented as a Global filter? Wondering if there is ever a scenario where duplicate headers makes sense?

It could be configured as a default filter.

Should this be implemented as a Global filter? Wondering if there is ever a scenario where duplicate headers makes sense?

One can use it as a global filter (I do), or route specific.
I suspect duplicate headers with the same value never make sense; with different values, Vary comes to mind, there may be more.

Is correction will be reported in 2.1.X ?

yes, 2.0.x, 2.1.x and 2.2.x

Still facing the issue with duplicate origins in Access-Control-Allow-Origin , even though the last comment says it has been fixed with 2.1.6.RELEASE. Can anybody tell me the workaround or the proper version to be used?

There is not 2.1.6.RELEASE of the gateway

I have the same issues. But it is fixed in gateway 2.1.2.RELEASE.
If for some reason you are not able to upgrade your version.
I applied a workaround.

 So, your consumer ends up with
          Access-Control-Allow-Credentials: true, true
          Access-Control-Allow-Origin: https://musk.mars, https://musk.mars
(The one from the gateway will be the first of the two.) To fix, add
          DedupeResponseHeader=Access-Control-Allow-Credentials Access-Control-Allow-Origin

Configuration parameters:
- name
    String representing response header names, space separated. Required.
- strategy
	RETAIN_FIRST - Default. Retain the first value only.
	RETAIN_LAST - Retain the last value only.
	RETAIN_UNIQUE - Retain all unique values in the order of their first encounter.

Example 1
      default-filters:
      - DedupeResponseHeader=Access-Control-Allow-Credentials

Response header Access-Control-Allow-Credentials: true, false
Modified response header Access-Control-Allow-Credentials: true

Example 2
      default-filters:
      - DedupeResponseHeader=Access-Control-Allow-Credentials, RETAIN_LAST

Response header Access-Control-Allow-Credentials: true, false
Modified response header Access-Control-Allow-Credentials: false

Example 3
      default-filters:
      - DedupeResponseHeader=Access-Control-Allow-Credentials, RETAIN_UNIQUE

Response header Access-Control-Allow-Credentials: true, true
Modified response header Access-Control-Allow-Credentials: true
 */

/**
 * Add following Filter Factory in order to remove duplicate value for a Http Header
 * Due to Sprng Cloud  Gateway Service Bug
 * @see Fix Pull Request
 * Waiting the fix backport into 2.1.X version (with Greenwhich.SR2 version).
 * TODO : Remove this class when the upgrade of spring-cloud Greenwhich.SR1 will be applied
 */
public class DedupeResponseHeaderGatewayFilterFactory
        extends AbstractGatewayFilterFactory<DedupeResponseHeaderGatewayFilterFactory.Config> {

    private static final String STRATEGY_KEY = "strategy";

    public DedupeResponseHeaderGatewayFilterFactory() {
        super(Config.class);
    }

    @Override
    public List<String> shortcutFieldOrder() {
        return Arrays.asList(NAME_KEY, STRATEGY_KEY);
    }

    @Override
    public GatewayFilter apply(Config config) {
        return (exchange, chain) -> chain.filter(exchange).then(Mono.fromRunnable(() -> {
            dedupe(exchange.getResponse().getHeaders(), config);
        }));
    }

    public enum Strategy {
        /*
        Default: Retain the first value only.
         */
        RETAIN_FIRST,

        /*
        Retain the last value only.
         */
        RETAIN_LAST,

        /*
        Retain all unique values in the order of their first encounter.
         */
        RETAIN_UNIQUE
    }

    void dedupe(HttpHeaders headers, Config config) {
        String names = config.getName();
        Strategy strategy = config.getStrategy();
        if (headers == null || names == null || strategy == null) {
            return;
        }
        for (String name : names.split(" ")) {
			dedupe(headers, name.trim(), strategy);
		}
	}

	private void dedupe(HttpHeaders headers, String name, Strategy strategy) {
		List<String> values = headers.get(name);
		if (values == null || values.size() <= 1) {
			return;
		}
		switch (strategy) {
			case RETAIN_FIRST:
				headers.set(name, values.get(0));
				break;
			case RETAIN_LAST:
				headers.set(name, values.get(values.size() - 1));
				break;
			case RETAIN_UNIQUE:
				headers.put(name, values.stream().distinct().collect(Collectors.toList()));
				break;
			default:
				break;
		}
	}

	public static class Config extends AbstractGatewayFilterFactory.NameConfig {
        private Strategy strategy = Strategy.RETAIN_FIRST;

        public Strategy getStrategy() {
            return strategy;
        }

        public Config setStrategy(Strategy strategy) {
            this.strategy = strategy;
            return this;
        }
    }
}

Add this in your GatewayServiceApplication.java

package com.company.gateway.service.application;

import com.company.gateway.service.application.filter.DedupeResponseHeaderGatewayFilterFactory;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.client.discovery.EnableDiscoveryClient;
import org.springframework.cloud.gateway.handler.RoutePredicateHandlerMapping;

@SpringBootApplication(scanBasePackages = "com.company.gateway.service")
@EnableDiscoveryClient
public class GatewayServiceApplication {

    public static void main(String[] args) {
        SpringApplication.run(GatewayServiceApplication.class, args);
    }

    @Bean
    public DedupeResponseHeaderGatewayFilterFactory dedupeResponseHeaderGatewayFilterFactory() {
        return new DedupeResponseHeaderGatewayFilterFactory();
    }
}

Configuration your route :

      routes:
        - id: service-id
          uri: lb://service-id
          predicates:
            - Path=/service-id/**
          filters:
            # Add following Filter Response header in order to remove duplicates CORS value for a Http Header
            - DedupeResponseHeader=Access-Control-Allow-Credentials Access-Control-Allow-Origin Access-Control-Allow-Headers

I realized the upstream process to spring gateway had CORS turned on , which was causing the duplicate headers problem. I removed the CORS configuration in the upstream application and the problem was solved.
Sent from my iPhone

On Aug 14, 2019, at 12:50 PM, laugues<EMAIL_ADDRESS>wrote:
I have the same issues. But it is fixed in gateway 2.1.2.RELEASE.
If for some reason you are not able to upgrade your version.
I applied a workaround.
 So, your consumer ends up with
Access-Control-Allow-Credentials: true, true
Access-Control-Allow-Origin: https://musk.mars, https://musk.mars
(The one from the gateway will be the first of the two.) To fix, add
DedupeResponseHeader=Access-Control-Allow-Credentials Access-Control-Allow-Origin
Configuration parameters:

name
String representing response header names, space separated. Required.
strategy
RETAIN_FIRST - Default. Retain the first value only.
RETAIN_LAST - Retain the last value only.
RETAIN_UNIQUE - Retain all unique values in the order of their first encounter.

Example 1
default-filters:
- DedupeResponseHeader=Access-Control-Allow-Credentials
Response header Access-Control-Allow-Credentials: true, false
Modified response header Access-Control-Allow-Credentials: true
Example 2
default-filters:
- DedupeResponseHeader=Access-Control-Allow-Credentials, RETAIN_LAST
Response header Access-Control-Allow-Credentials: true, false
Modified response header Access-Control-Allow-Credentials: false
Example 3
default-filters:
- DedupeResponseHeader=Access-Control-Allow-Credentials, RETAIN_UNIQUE
Response header Access-Control-Allow-Credentials: true, true
Modified response header Access-Control-Allow-Credentials: true
*/
/**

Add following Filter Factory in order to remove duplicate value for a Http Header

Due to Sprng Cloud  Gateway Service Bug

@see Fix Pull Request

Waiting the fix backport into 2.1.X version (with Greenwhich.SR2 version).

TODO : Remove this class when the upgrade of spring-cloud Greenwhich.SR1 will be applied
*/
public class DedupeResponseHeaderGatewayFilterFactory
extends AbstractGatewayFilterFactory<DedupeResponseHeaderGatewayFilterFactory.Config> {
private static final String STRATEGY_KEY = "strategy";
public DedupeResponseHeaderGatewayFilterFactory() {
super(Config.class);
}
@Override
public List shortcutFieldOrder() {
return Arrays.asList(NAME_KEY, STRATEGY_KEY);
}
@Override
public GatewayFilter apply(Config config) {
return (exchange, chain) -> chain.filter(exchange).then(Mono.fromRunnable(() -> {
dedupe(exchange.getResponse().getHeaders(), config);
}));
}
public enum Strategy {
/*
Default: Retain the first value only.
*/
RETAIN_FIRST,
 /*
 Retain the last value only.
  */
 RETAIN_LAST,

 /*
 Retain all unique values in the order of their first encounter.
  */
 RETAIN_UNIQUE

}
void dedupe(HttpHeaders headers, Config config) {
String names = config.getName();
Strategy strategy = config.getStrategy();
if (headers == null || names == null || strategy == null) {
return;
}
for (String name : names.split(" ")) {
dedupe(headers, name.trim(), strategy);
}
}

private void dedupe(HttpHeaders headers, String name, Strategy strategy) {
List values = headers.get(name);
if (values == null || values.size() <= 1) {
return;
}
switch (strategy) {
case RETAIN_FIRST:
headers.set(name, values.get(0));
break;
case RETAIN_LAST:
headers.set(name, values.get(values.size() - 1));
break;
case RETAIN_UNIQUE:
headers.put(name, values.stream().distinct().collect(Collectors.toList()));
break;
default:
break;
}
}
public static class Config extends AbstractGatewayFilterFactory.NameConfig {
private Strategy strategy = Strategy.RETAIN_FIRST;
    public Strategy getStrategy() {
        return strategy;
    }

    public Config setStrategy(Strategy strategy) {
        this.strategy = strategy;
        return this;
    }
}

}
Add this in your GatewayServiceApplication.java
package com.company.gateway.service.application;
import com.company.gateway.service.application.filter.DedupeResponseHeaderGatewayFilterFactory;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.client.discovery.EnableDiscoveryClient;
import org.springframework.cloud.gateway.handler.RoutePredicateHandlerMapping;
@SpringBootApplication(scanBasePackages = "com.company.gateway.service")
@EnableDiscoveryClient
public class GatewayServiceApplication {
public static void main(String[] args) {
    SpringApplication.run(GatewayServiceApplication.class, args);
}

@Bean
public DedupeResponseHeaderGatewayFilterFactory dedupeResponseHeaderGatewayFilterFactory() {
    return new DedupeResponseHeaderGatewayFilterFactory();
}

}
Configuration your route :
routes:
- id: service-id
uri: lb://service-id
predicates:
- Path=/service-id/**
filters:
# Add following Filter Response header in order to remove duplicates CORS value for a Http Header
- DedupeResponseHeader=Access-Control-Allow-Credentials Access-Control-Allow-Origin Access-Control-Allow-Headers
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Is correction will be reported in 2.1.X ?

i haven't solve this problem since i upgrade to  2.1.2.RELEASE, my dependency blow:
        <dependency>             <groupId>org.springframework.cloud</groupId>             <artifactId>spring-cloud-gateway-core</artifactId>             <version>2.1.2.RELEASE</version>         </dependency>

anybody

have you solved this problem?

Still facing the issue with duplicate origins in Access-Control-Allow-Origin , even though the last comment says it has been fixed with 2.1.6.RELEASE. Can anybody tell me the workaround or the proper version to be used?

have you solved this problem?

i have solved this problem, add config :
default-filters:
- DedupeResponseHeader=Access-Control-Allow-Origin, RETAIN_UNIQUE


Add is_position_in_frustum to Camera3D

This is a simple helper method that checks if a Vector3 is inside of the Camera3D frustum.
For a Godot project this could technically be worked around in GDScript, but this kind of thing makes sense to be in core. Also, I need this for future editor functionality I'm currently working on (will likely post that PR in the next day or so).

How does this compare to is_position_behind()? The documentation should compare it to that method.

@Calinou I think the best explanation is with a diagram. Do we have a way to include images in the class reference?

Do we have a way to include images in the class reference?

Kind of. The current way of doing so is to PR the image to godot-docs' top-level img/ folder in the master branch and link to it using [url=<raw image URL>]Diagram[/url] in BBCode.

Thanks!


Documentation issue

The instructions on the Refresh Token via restutil are not working. Only the command gives error: Failed to process the request: Option value is missing for -config. Also step c. is not clear

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 250b790c-3309-2651-cefd-e94d3dd5bc11
Version Independent ID: 54000705-40ce-d014-7bda-4296c1de2e29
Content: Configure HP ArcSight to pull Windows Defender ATP alerts
Content Source: windows/security/threat-protection/windows-defender-atp/configure-arcsight-windows-defender-advanced-threat-protection.md
Product: w10
GitHub Login: @mjcaparas
Microsoft Alias: macapara

@fumantsu To retrieve a refresh token, invoke the tool with the token command:
arcsight restutil yourtoken <-proxy >
For example: arcsight restutil boxtoken -proxy proxy.location.hp.com:8080
For your concern regarding point c, when you will enter the command it will launch the web browser for you to login to the portal using your admin account.

@mjcaparas Please review the fix is available for this issue via PR #2824 Thanks.

Is there any update on this PR?
Regards
Muhammad Imran Habib
On Mon, Mar 4, 2019 at 8:55 PM Onur<EMAIL_ADDRESS>wrote:

@mjcaparas https://github.com/mjcaparas Please review the fix is
available for this issue via PR #2824
https://github.com/MicrosoftDocs/windows-itpro-docs/pull/2824 Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/windows-itpro-docs/issues/2708#issuecomment-469304602,
or mute the thread
https://github.com/notifications/unsubscribe-auth/As724k5OEPxWK9w2UhOWY5uxOy9NuIcqks5vTUHngaJpZM4bAgSM
.

Approved and merged.


Heartbeat response has only id

Found in https://github.com/vladfaust/unity-wakatime
Expectation:
{
  "data": {
    "id": "xxx",
    "entity": "yyy",
    "type": "zzz",
    "time": 123.456,
  }
}

Reality:
{"data":{"id":"xxx"}}

Fixed!


fix: underline was hidden by background in next line

close https://github.com/dream-num/univer-pro/issues/2634

Pull Request Checklist

[ ] Related tickets or issues have been linked in the PR description (or missing issue).
[ ] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[ ] Unit tests have been added for the changes (if applicable).
[ ] Breaking changes have been documented (or no breaking changes introduced in this PR).


[Feature] implement and verify rate_item_route

Fixes #13
While squashing commits previously made unnecessary commits, I introduced some conflicts idky.
The feature has been tested locally and works.

Fixes #13
While squashing commits previously made unnecessary commits, I introduced some conflicts idky.

The only changes made by me were in categories/controller.py.
The feature has been tested locally and works.

Conflict resolved, was a small conflict of imports

This is not going to be merged:

[ ] Have only one commit.
[X] Make sure the commit has the changes you've actually made, not the changes from other commits as well.

@gsc2001 Please help @kjain1810 ensure there is only one commit with the relevant changes.

@Pk13055 Ok. I am asking him if he is facing any problems


eval! triggers a panic

Hey,
I'm not sure if it's the right way to evaluate sexps, but it seemed reasonable to report a panic occurred
λ > (eval! "(+ 1 2)")
thread 'main' panicked at crates/steel-core/src/steel_vm/engine.rs:957:50:
called `Result::unwrap()` on an `Err` value: SteelErr { repr: Repr { kind: FreeIdentifier, message: "#%function-ptr-table", span: Some(0..0), stack_trace: None } }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Thanks for opening the issue - I've looked into it and should have a fix shortly. The panic is mostly the result of some bit rot on this function in particular, needs some extra tests around it
Also - to answer your question, you can use run! to evaluate sexprs. They won't be evaluated in the same environment as the host though


chore(package): update @angular-devkit/build-ng-packagr to version 0.7.1

Closes #11

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #12   +/-   ##
=======================================
  Coverage   89.24%   89.24%
=======================================
  Files          27       27
  Lines         465      465
  Branches       47       47
=======================================
  Hits          415      415
  Misses         50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c031c...7319c70. Read the comment docs.


The RequestAborted token should be passed to async APIs like Task.Delay

The current sample code looks like this:
app.MapGet("/", async (HttpContext context) => {
    await Task.Delay(TimeSpan.FromSeconds(2));

    if (context.RequestAborted.IsCancellationRequested) {
        return Results.Content("Timeout!", "text/plain");
    }

    return Results.Content("No timeout!", "text/plain");
}).WithRequestTimeout(TimeSpan.FromSeconds(1));

However this continues to wait past the timeout period. The Request aborted token should be passed to Task.Delay so it can be ended without waiting the full time. Generating a timeout response can be done by catching the exception locally, or using WriteTimeoutResponse when a policy is defined.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 449a4031-c1d1-5fbe-8e8f-b0e931a5b7ab
Version Independent ID: 449a4031-c1d1-5fbe-8e8f-b0e931a5b7ab
Content: Request timeouts middleware in ASP.NET Core
Content Source: aspnetcore/performance/timeouts.md
Product: aspnet-core
Technology: aspnetcore-performance
GitHub Login: @tdykstra
Microsoft Alias: riande

The article's intro says

When a timeout limit is hit, a CancellationToken in HttpContext.RequestAborted has IsCancellationRequested set to true. The request is not aborted automatically. It's up to the app to check RequestAborted and decide how to handle the timeout.

It looks likes "The request is not aborted automatically." is no longer true when we pass the cancellation token in to the async API.  I'm seeing a 504 get returned automatically. Is it still true in some scenarios, and if so when does it still apply?

"The request is not aborted automatically." can be clarified to "Abort() is not automatically called on the request, the application may still produce a success or failure response." The 504 is default behavior if the app doesn't handle the exception and produce a response.


fix: off-by-one error in spinner example

Sorry for the noise in go.mod and go.sum. I had to go get github.com/charmbracelet/bubbles/spinner in order to run the example.

I've rebased and cleaned up the noise in go.mod/go.sum. We have a separate set of module definitions in examples/go.mod, so you can avoid this issue by running the examples from within the directory.

Thank you, @smlx!


Climate data processing with dask extremly slow

This script https://github.com/FAIRiCUBE/uc1-urban-climate/blob/master/notebooks/f02_cube/subcubes_utci_stats.py processes 1 year of hourly climate data (around 14GB) to produce daily statistics for selected EU cities. I use dask to (hopefully) speedup data loading and processing. However, the script runtime is considerably slower when executed on FAIRiCube Hub than when executed locally.
The basic steps are (in parentheses the running times on local machine vs. on FAIRiCube Hub):

Download data from climate data store (same running time)
Unzip data (4 mins vs 15 mins)
Lazy-load data as xarray (2 mins vs. 15 mins)
start dask local cluster
compute statistics (8 mins vs 35 mins)
save statistics as shapefile (same running time)
delete original data from s3 to save space

My question is why is the processing so slow? Is there a problem in the code?

When starting the Hub I have the following settings:
CPU: 0.2
Memory: 213.55 MB
Host CPU
0.6% used on 8 CPUs
Host Virtual Memory
Active: 820.46 MB
Available: 29.19 GB
Free: 27.51 GB
Inactive: 1.74 GB
Percent used: 4.8%
Total: 30.67 GB
Used: 1.03 GB
Wired: 0.00 B
Does it help?

Hello, I have performed some other benchmarks. I have tested the new UC1 large profile (with doubled resources). I think that the problem is not related to the memory size/number of CPUs. The script takes the same amount of time regardless of the resources (on FAIRiCube Hub).
Here again some info about the machines (recorded with the Measurer developed by @cozzolinoac11).
The "large" profile on FAIRiCube has double the resources of my local machine.

Fairicube Hub large (365 days)
Local machine (365 days)

Data size (MB)

90.7421875

Main memory available (GB)
61.68314362
23.94339371

Main memory consumed (GB)
0.333139
0.339320951

CPU/GPU Machine type
x86_64
AMD64

CPU/GPU Processor type
x86_64
Intel64 Family 6 Model 60 Stepping 3 GenuineIntel

CPU/GPU Number of physical cores
8
4

CPU/GPU Number of logical cores
16
8

Network traffic
119131.431390762
14.760983467102

Wall time in seconds
8504.97295928001
682.038042545318

Can you @eox-cs1 see why is there such a difference in performance by looking at this data? The only thing I see is the difference in network traffic. Could it be that the process is slowed down by having to access the data on S3 bucket?

Hi Christian,
the root cause of the problem seems to be the combo NetCDF and cloud storage, cf. this forum. Reading NetCDF from S3 is slow because NetCDF is not a cloud optimized, and this is also causing the high network traffic (lots of requests to get the metadata). Zarr seems to be the cloud-optimized alternative to NetCDF.
Which means that we have to rethink how we handle climate data, since it usually comes in NetCDF format.
Btw, it is 119 GB, not TB, I had forgotten to had the unit (fixed).
@KathiSchleidt this is probably information relevant for you as well.

Hi Maria,
Yes, you seem to be right. Although netCDF was developed for net-access it doesn't seem to work well on Object Storages.
Network traffic:  119GB is much better but still ~8,5 times of the 14GBs.
The issue of netCDF with S3 seems to be already known and a search provided some possible solutions you could try to speed things up. The listing is not in any order.
https://pypi.org/project/s3fs/
https://github.com/fsspec/s3fs/issues/168+
https://github.com/meracan/s3-netcdf
https://pypi.org/project/S3netCDF4/
https://stackoverflow.com/questions/43197223/using-aws-s3-and-apache-spark-with-hdf5-netcdf-4-data/60885374#60885374
https://nasa-openscapes.github.io/2021-Cloud-Workshop-AGU/how-tos/Multi-File_Direct_S3_Access_NetCDF_Example.html
https://medium.com/pangeo/cloud-performant-reading-of-netcdf4-hdf5-data-using-the-zarr-library-1a95c5c92314
https://medium.com/pangeo/fake-it-until-you-make-it-reading-goes-netcdf4-data-on-aws-s3-as-zarr-for-rapid-data-access-61e33f8fe68

@mari-s4e @eox-cs1 I don't have the time to read the various pages, but based on the links, seems the general recommendation is to first convert the NetCDF to Zarr.
Regardless - please tell me what solution you come up with!!!

one might do that with its own datasets but for external data stores this will not likely  be an option.
the links above provide 2-3 alternative S3 access options which could be benchmarked

Hi @eox-cs1,
I have reviewed your suggestions:

with rioxarray it is a bit better, but still reading nc files from s3 is 2x slower compared to reading from local disk. Nevertheless 👍  because it solves other errors I had loading the files.
S3netCDF4 looked promising but I cannot install the library (pip install throwing errors), and the project seems stale
I am not sure how s3fs can help here, since the s3 bucket is mounted to the EOX workspace, I can navigate it as part of the file system. Or am I missing something?

Issue resolved: traditional file formats (e.g. tiff, netCDF) cause a lot of network traffic and slow down the computation when the file resides on the cloud. Cloud-optimized format like COG, zarr are designed to overcome this prolem.


Write shortest possible code: python how to get year from date (python)

Please write shortest code example for this question:
python how to get year from date in python
How to do it:

Go to python codes
Create new file (named in underscore case, should contain key words from title) with md extension (markdown file).
Propose new file with following content (please use all three blocks if possible - title, code itself and explanations list):

# python how to get year from date

```python
code part1 part2 part3 ...
```

- part1 - explain code part 1
- part2 - explain code part 2
- ...

More advanced template for examples and linked solutions. More docs here.

How to get year from date


Embed with application team to understand users

Describe the issue
We have a general idea who our users are
Who is using the product (SEA: BC Gov AWS Landing Zone, GitHub, Terraform)?
How is the interaction with the product?
Until now we have been quite detached from the users and we don't know what their professional interactions with our product are like. In order to define our users, it would be good to have experience alongside the team as they use the CP project. This is about user research with their experience of the CP product.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context

Co-ordination required with scrum masters of each team, volunteers
Option to have the team record and review 2 deliverables with them if they are time-pressed.
Suggested contactees are from 2 groups, the ones we think are comfortable (Paul Dittaro, Jonathan Funk, Will Sonnex), and the ones that are addressing learning debt (Michelle Douville, Bruce Bell, Matthew Bystedt, Pete Tollestrup, Matthew Loisel, Louis Kraak)

Definition of done

aim for 2 or 3 of the list of users above, suggested: Jonathan Funk, Michelle Douville.
We want to spend enough time with the team that they are comfortable working normally in front of us
Focus on likes, painpoints (high-level granularity: t-shirt-size estimate)
Time-boxed to 5 days
Deliverable 1: List of activities that the team performs relating to our product
Deliverable 2: Draw.io diagram explaining what the user's day looks specifically % of time they spent using Command Line Interface (CLI), Terraform, AWS Console website and which Integrated Developer Environment (IDE) are they using, where they are getting documentation information from)

We did the workshop end of Sprint. will study and create a one pager narrative this coming sprint and share with everyone.


Draft 17 recovery logic

Pretty much just went through and transcribed the new pseudocode, with minor adjustments along the same lines as the ones made previously. The logic is a little simpler and makes a little more sense this time around (e.g. no always-false bools).

Rebased.

Rebased. Thanks for all the review work!


Fix missing checkout steps on CI

Hello @kislyuk,
Thank you for your work on this great project! 🙇🏻♂
Currently, black and isort do nothing on CI due to lack of the source code to analyze. To fix that, corresponding checkout steps need to be added.
These changes also apply black/isort to the code.
Best regards!

Thanks!


Remove welcome screens

Summary
Closes #155
Since the person that pulles this onto nextcord did not created the code but used an old pull from the old repository without the authors approval this would revert it
Checklist

[ ] If code changes were made then they have been tested.

[x] I have updated the documentation to reflect the changes.

[x] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[x] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Even thou i am not sure with the legal parts if under the MIT License we actually have to remove it i would propose so for good manner

@NCPlayz would that be okay for you?


Can't resume from checkpoint

I'm getting:
  File "/home/guest/ai/finetune/qlora/venv/lib/python3.10/site-packages/transformers/trainer.py", line 2159, in _load_from_checkpoint
  ValueError: Can't find a valid checkpoint at ./output/checkpoint-1000

Apparently there are several missing files from the checkpoint dir, like config.json.

Maybe the last checkpoint may not be correct. I had an issue related to the checkpoint, and it seems to stem from the last checkpoint. When I represented the checkpoint before the last one as the final checkpoint, the problem was resolved. You can try it that way too.

same

Ok found the problem. This PR fixes it https://github.com/artidoro/qlora/pull/44
But it is not yet merged (even if a comment says it is)

Ok found the problem. This PR fixes it #44
But it is not yet merged (even if a comment says it is)

Still got issue

Same problem here and I looked into it a bit.

The full weight file is not kept to save space, so we need to skip the whole _load_from_checkpoint part in transformers trainer.  qlora does add a setting of training_args.skip_loading_checkpoint_weights=True which I presume they use a custom branch of transformers to support this.
When loading LORA weight with PeftModel.from_pretrained, we need to set is_trainable=True


Restore original root name if renaming instance to empty

Extends #66236 to support restoring instance names.
https://github.com/user-attachments/assets/b1c79ec3-9a69-47b9-8119-42345b1809d3

Thanks!


Put some examples more

For example like this:
1- Add to lang_en.ini
stringswithvar = "Test1: %1$s"
stringswithvars = "Test_number: %1$s Test_string: %2$s"
2.- Add to lang_en.json
"stringswithvar": "Test1: %1$s"
"stringswithvars": "Test_number: %1$s Test_string:%2$s"
3.- Add to lang_en.yml
stringswithvar: 'Test1: %1$s'
stringswithvars: 'Test_number: %1$s Test_string:%2$s'
4. And add to example.php

String with var(string):
String with var(integer):
String with vars(string):
String with vars(integer):
String with vars(combined):

Pull requests are welcome.

Hey @Philipp15b can I some suggestions about how to approach this issue?

@shawe can you send a PR?


hi is this tagui solution can be used not on browser , but on application directly .

hi is this tagui solution can be used not on browser , but on application directly ex open calculator ...
I try the :
Click (screen of the application)
or
Click (coordinate of application
or
click nameofapplication using ocr
But nothing happen.
Im on windows 10
Thanks for reply

Sorry @fguerouali I was away the past few months - https://github.com/tebelorg/RPA-Python/issues/144
Yes it can be used on desktop apps by using visual automation method and using keyboard step, for eg -
https://github.com/aimakerspace/TagUI-Bricks/tree/master/MS-Word-Letter
Have you completed the installation instructions here - https://tagui.readthedocs.io/en/latest/setup.html
Including installing OpenJDK, which is required for visual automation.
Is there any error message after each step or the program hangs? Can you check in the folder tagui\src\tagui.sikuli, there is a file tagui_windows.log, can you paste the contents of the file here after doing the click abc.png step?
I'm closing the issue for now, you most likely have found the solution after many months. But please lemme know if you have any input or question so we can look more into the issue.


fix and improve markdown rendering

In the collaborative flow readme, we have this nested list at the beginning:
- [Dependencies](#dependencies)
- [Breakdown](#breakdown)
  - [Setting up yjs](#setting-up-yjs)
  - [The `useNodesStateSynced` hook](#the-usenodesstatesynced-hook)
  - [The `useCursorStateSynced` hook](#the-usecursorstatesynced-hook)
  - [Rendering multiple cursors](#rendering-multiple-cursors)
- [Related docs](#related-docs)
- [See also](#see-also)

But it seems to be rendering as a flat list:

also, the links are not working in this case. we need to add ids to the heading elements, too.

table support would be a good improvement.


Question: How does this code work?

Hi,
I found a piece of code shown below. I know how to use it i.e. selecting a conduit in the map displays an arrow at one the ends of the conduit. It turns out the arrow shows the direction of flow i.e. from the upstream end to downstream end of conduit. I wanted to know how DS is able to recognize the flow direction in the conduit or does the arrow stand for something else?
`var mys = mapDisplay.GetAllLayers();
        for (int i = 0; i < mys.Count; i++)
        {
            if(mys[i].GetType().Name== "MapLineLayer")
            {
                MapLineLayer ml = (DotSpatial.Controls.MapLineLayer)mys[i];

                var stroke = new CartographicStroke(Color.Cyan) { Width = 2 };

                var dec = new LineDecoration
                {
                    Symbol = new PointSymbolizer(Color.DarkCyan,  DotSpatial.Symbology.PointShape.Triangle, 12),
                    NumSymbols = 1,
                    RotateWithLine = true,
                    PercentualPosition = 100,
                    FlipAll = true
                };
                stroke.Decorations.Add(dec);
                ml.SelectionSymbolizer.Strokes.Clear();
                ml.SelectionSymbolizer.Strokes.Add(stroke);
            }
        }
        mapDisplay.FunctionMode = FunctionMode.Select;

`

Find the arrow indicated on the selected conduits in a map
Thanks for any help,
Karthik

Your line is defined with a start and an end poind. DS draws the line from this start to end point also rotating the arrow based on this line.


Pillow animated gifs

This PR adds support for animated GIFs in the Pillow backend

What's the status of this PR?

@danihodovic it's awaiting review

Code looks good to me. One thing I'm not clear on, though: given that PillowAnimatedImage can presumably do everything PillowImage can do and more, is there any reason for the "choose the best backend" logic in registry.py to ever prefer PillowImage - and if not, do we really need both classes to exist?

Code looks good to me. One thing I'm not clear on, though: given that PillowAnimatedImage can presumably do everything PillowImage can do and more, is there any reason for the "choose the best backend" logic in registry.py to ever prefer PillowImage - and if not, do we really need both classes to exist?

Good point! I've merged the two classes together now

My plan for this is to implement both animated GIF and animated WEBP support in Willow, then add logic into Wagtail so that it always transcodes animated GIFs into animated WEBP files. This fixes issues with having to save a GIF that contains more than 256 colours (which will be inevitable if we've resized the image). See discussion in https://github.com/wagtail/Willow/pull/76#discussion_r331426263

@zerolab possibly a duplicate of #80 , is there any traction on this?

@zerolab possibly a duplicate of #80 , is there any traction on this?

We're still very interested in Wagtail properly supporting animated whatevers (GIF, webp, mp4, etc.).

We're still very interested in Wagtail properly supporting animated whatevers (GIF, webp, mp4, etc.).

Incidentally @thenewguy makes the case for animated GIFs to be treated as "media" (i.e. no resizing and other Willlow filters) - https://github.com/torchbox/wagtailmedia/issues/127
Might that be the way to go?

Incidentally @thenewguy makes the case for animated GIFs to be treated as "media" (i.e. no resizing and other Willlow filters) - https://github.com/torchbox/wagtailmedia/issues/127
Might that be the way to go?

I like that idea! In many cases, GIFs would be both smaller and better quality if we don't try to process them

I like that idea! In many cases, GIFs would be both smaller and better quality if we don't try to process them


fix: do not subscribe to process signal handlers unless necessary

Fixes https://github.com/moxystudio/node-proper-lockfile/issues/111

@satazor @hugomrdias any chance we can land this?


Make the chatbot functional  and added more responses

Title and Issue number

Title :BUG : CHATBOT
Issue No. : #174
Code Stack :  html ,css, js

Close : #174
Video/Screenshots (mandatory)

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have gone through the  contributing.md file before contributing

Additional context (Mandatory )
Are you contributing under any Open-source programme?

jwoc

@Anushkabh Really great Contribution


Buffer initializes a Stream with fixed log.labels and then all the messages within a buffer have the same labels

Seems that if you send multiple messages in the same buffer with different levels, here:
https://github.com/xente/loki-logger-handler/blob/main/loki_logger_handler/loki_logger_handler.py#L112
All messages sent within a buffer will have the same label extracted, e.g. "level" extracted via:
label_keys={ "level", },

so, messages with level "DEBUG" and "INFO" will all have the label level set to "INFO", even if there is {level:"DEBUG"} in the raw message itself.
which can be fixed by changing this line:
https://github.com/xente/loki-logger-handler/blob/main/loki_logger_handler/loki_logger_handler.py#L180
should be:
key_list = sorted(labels.values())
instead of
key_list = sorted(labels.keys())

It will be fixed on 1.0.2 version

@dnezic v 1.0.2 has been released.


RHEL7 (CentOS7) rpm build

# rpm -q dderl
dderl-2.3.0-1.el7.centos.x86_64
# rpm -V dderl
#

# service dderl status
● dderl.service - SYSV: Web based tool for exploring databases
   Loaded: loaded (/etc/rc.d/init.d/dderl; bad; vendor preset: disabled)
   Active: inactive (dead)
     Docs: man:systemd-sysv-generator(8)

# chkconfig --list dderl

Note: This output shows SysV services only and does not include native
      systemd services. SysV configuration data might be overridden by native
      systemd configuration.

      If you want to list systemd services use 'systemctl list-unit-files'.
      To see services enabled on particular target use
      'systemctl list-dependencies [target]'.

dderl          	0:off	1:off	2:off	3:on	4:on	5:on	6:off

Coverage remained the same at 4.92% when pulling 3d110d93c378a04e90bfe72f48bc6ed1ad028894 on rpm into b27d380c7243a95c3d3b3c3b2a8d6692ebeb4656 on master.

Coverage remained the same at 4.92% when pulling 3d110d93c378a04e90bfe72f48bc6ed1ad028894 on rpm into b27d380c7243a95c3d3b3c3b2a8d6692ebeb4656 on master.

Verified using jenkins on CentOS to build rpms.


[Bug Fix] Add the last observation to the evaluation video

Motivation and Context
Currently, when generating evaluation video with --run-type eval, the last frame and last info dict is not in the video.
Having those is useful since it can for example indicate what was the last action the robot tried to perform before the end of the episode.

How Has This Been Tested

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@vincentpierre The current code doesn't insert the last frame because it doesn't exist. What you are adding is the first frame of the next episode, not the last frame of the one that just finished. You could insert a black frame instead and just write infos on that.


JetBrains IDEA support

Any plans of development a plugin for JetBrains IDEA?

Yes, I will get back to plugins and integration once I release the next version. Currently gradle can be setup within IDEA to compile with JUnion, but checking if I can develop the plugin for IDEA is on the todo list.

I'll add to the request for the Idea support.
I just broke my entire project trying to compile it manually

I'm sorry to hear that. I hope you do have backups of your projects.
Once I'll find some time to work a bit on this project, I might check if I can implement IDEA integration.


Bump shell-image to v0.1.22-rc1

I am not seeing a release v0.1.22-rc1 in the shell repo. Maybe Drone isn't releasing the new tag automatically. In that case, please release it as a pre-release.
Also, I might not be familiar with the context, but what's the reason for the bump when code freeze is in effect? Could we just unRC v0.1.21?

Forgot to make a pre-release for the tag. I'll also change it to a v0.1.21-rc2.
The reason for the change is this change rancher/shell#200 is required to resolve this bug #43197

There is already a 1.21 release, so keeping it as v0.1.22-rc1


Clear Statement Of Applicability Is Required.

Hi my name is klawrawkz. I am fine. How are you?
Without a clear statement of use, this is a potential waste of time. To ameliorate this concern, an explicit statement of use is required indicating this article describes concepts pertinent to, pertaining to, about, concerning, regarding, appertaining to etc. ONLY "consumption" logic apps, not "standard" ones. Preferably this should be presented in <imagine red coloration>BOLD RED lettering </imagine red coloration> at the absolute very top of this doc. I fantasize the statement should read, <imagine red coloration>"WARNING APPLICABLE ONLY TO CONSUMPTION LOGIC APPS".</imagine red coloration>
Perhaps this banner will flash on and off in various shades of red just to make it annoying enough that we users will get the message....
Thanks. I hope you are doing well.
klawrawkz

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72c96620-a604-8e8e-0f28-c587ac595d8b
Version Independent ID: 0b7d74fb-9ec7-fcb9-87fd-e08ae2b6f284
Content: Create logic app templates for deployment - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-create-azure-resource-manager-templates.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@klawrawkz: Thanks for your feedback! We'll update this doc to clarify.
#assign @ecfan

@MayankBargali-MSFT: Could you please add the necessary labels for this item? I've already resolved. Thanks!


[CI] Failed static checks

Current Situation
The build process for this adapter has failing static golang checks - https://github.com/meshery/meshery-osm/runs/4352711502?check_suite_focus=true
Desired Situation
No checks should be failing.
Contributor Resources
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

@Shreyas220 is this an item that you can tackle?


No others users visible inside ATAK

Trying to create a meshnetwork with ATAK Forwarder.
I've read every single documentation and followed the YouTube tutorial made by S2 Underground. But I can't get any meshtastic network off the ground or devices that see each other.
I used the 1.2.64 firmware and app version of Meshtastic
I tried a variety of ATAK apps and their corresponding ATAK Forwarder plugin versions.
I CAN;

I can get the link between Meshtastic devices and the phone (cloud has a checkmark in meshtastic)
ATAK device name is seen as well in Meshtastic
ATAK Forwarder channel name is seen as well in Meshtastic (both devices are in Meshtastic connected to the same channel / group)

I CAN'T;

ATAK (Forwarder) devices can't see each other inside ATAK
I can't send a message through meshtastic in the channel to each other (will pop up and the cloud icon will have a diagonal line through it immediately)

Currently using a OnePlus 7T & a Samsung Galaxy Note 9 as test devices.

Trying to create a meshnetwork with ATAK Forwarder.
I've read every single documentation and followed the YouTube tutorial made by S2 Underground. But I can't get any meshtastic network off the ground or devices that see each other.
I used the 1.2.64 firmware and app version of Meshtastic
I tried a variety of ATAK apps and their corresponding ATAK Forwarder plugin versions.
I CAN;

I can get the link between Meshtastic devices and the phone (cloud has a checkmark in meshtastic)
ATAK device name is seen as well in Meshtastic
ATAK Forwarder channel name is seen as well in Meshtastic (both devices are in Meshtastic connected to the same channel / group)

I CAN'T;

ATAK (Forwarder) devices can't see each other inside ATAK
I can't send a message through meshtastic in the channel to each other (will pop up and the cloud icon will have a diagonal line through it immediately)

Currently using a OnePlus 7T & a Samsung Galaxy Note 9 as test devices.

update: ATAK Forwarder won't install on my OnePlus 7T with ATAK v4.702 (6ebfe6b4)[playstore] version.

update: ATAK Forwarder won't install on my OnePlus 7T with ATAK v4.702 (6ebfe6b4)[playstore] version.

Yes, I'm having the same problem. Any ideas @paulmandal?
Thanks!

Try this release: https://github.com/paulmandal/atak-forwarder/releases/tag/2.0.1


LLVM Backend crashes

I'm not sure if this is because I broke my machine or something, but when I try to kompile and krun sum.imp from the k tutorial, I get
[Error] Critical: LLVM Backend crashed during rewriting.
I'm running on a mac, I'm not sure what other variables there are that would cause this.

I'm aware of this issue; it seems to only be affecting macs on recent versions of k. I would suggest installing the latest Homebrew bottle in the meantime.

Having investigated further, I believe this issue may be fixed with kframework/llvm-backend#303 once the submodule in kframework/k is updated. I'm not 100% sure this is the same issue since I have not independently confirmed it, but it seems to manifest the same way as the bug I discovered, which was a bug caused by the recent release of GMP 6.2, which is also recently released on Mac OS.
As such, if this is the cause of a bug, older versions of K will not fix the problem (unlike my previous suggestion), because it is not so much a regression as a latent bug. You can try to roll back to GMP 6.1.2 and see if that solves it, or you can try building from source and pinning the llvm backend submodule to the branch in the PR I mentioned above, or you can wait and one way or another I will have this fixed soon.

I believe this should now be fixed. Please let me know if it is still occurring for you.

I'm suffering from similar bug, using latest release of K-Tools (v5.0.0-51b354c).
After short investigation, I've found that it crashes on NULL ptr deref in getTagForSymbolName.
(gdb) bt
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1  0x00007ffffd730801 in __GI_abort () at abort.c:79
#2  0x00000000002127a1 in getTagForSymbolName ()
#3  0x000000000021ba72 in allocatePatternAsConfiguration (Pattern=) at /home/jenkins-slave/workspace/k_master/llvm-backend/src/main/native/llvm-backend/runtime/configurationparser/ConfigurationParser.cpp:34

I need more data about how to reproduce the issue you describe if there's any hope of resolving it. Your stack trace tells me that this definitely isn't the same issue that the original person who created this issue ran into, which is good. It also tells me that it's not an issue on mac OS. But it doesn't tell me anything that would allow me to determine the cause of the error or how to reproduce it, so without that information I can't really take any further action.

Sorry for the late response, but it is now working for me!


gerritstatusupdater: fail any completed job that did not succeed

(see commit message)

Note that this might include manually cancelled jobs.

Indeed. But I still think we need to consider these as failed, because by definition they did not succeed. It's precisely the case of manually cancelled jobs that currently leaves Gerrit CLs in a limbo state. I think the best we can do is mark them as failed; we definitely can't mark them as having passed.


pipelines: upgrade to Dagger 0.12

Needs https://github.com/dagger/dagger/pull/7904 for anything to pass :eyes:

TestEngine/TestExitsZeroOnSignal seems to be weirdly flaking - I can't repro this locally, and there's no reason this change should have caused it, merging now.

Noice! Thanks for the updates 🙂


option to enable remote source in jsdom [was: Interference with existing js]

Maybe I completely misunderstood the purpose of this project. I came here from re-organizing the examples in /bin discussion, hoping to replace my use of the deprecated page2svg. As explained in the linked page, I can't get any conversion. But also I noticed interference with my javascript which has nothing to do with mathjax. Consider the following test.html:
<head>
<meta charset="utf-8">
<title>Test mjpage</title>
</head>
<body>
Hello $x=1$.

<script src="http://code.jquery.com/jquery.min.js" type="text/javascript"></script>
<script type="text/javascript">
$('body').css('background','red');
</script>
</body>
</html>

If I run cat test.html | node_modules/mathjax-node-page/bin/mjpage.js --format=TeX> out.html I get the error Error: Uncaught [ReferenceError: $ is not defined]. It seems mjpage tries to run my inline js without downloading jQuery. The same happens if my inline js is replaced by including a local js file like <script type="text/javascript" src="myjs.js"></script>.
I had no such trouble with page2svg which happily ignored my javascript and took care of my mathematics (as expected).

This is expected right now -- jsdom is configured to not fetch remote resources.
It seems reasonable to make this optional.

=> Renamed.

But I don't want mjpage to fetch this remote resources, I want it to convert my mathematics input. Here I would like it to completely ignore all my script tags. Maybe there are use cases where I would want it to do otherwise but right now I don't see them. Why didn't this issue occurred with page2svg?
Maybe an example use is better than abstract discussion. You could have a look at this page for instance, generated by plasTeX+page2svg. It's full of maths (especially if you click on all +'s to open up proofs) and page2svg allow instant rendering (compared to client side mathjax which needs several seconds of page flickering due to reflow). But I don't want mathjax to care about my jquery animating the + and x which show or hide part of the page.

But I don't want mjpage to fetch this remote resources,

But others might. It would be off by default anyway.

Here I would like it to completely ignore all my script tags.

That's not possible due to the way MathJax works.

Why didn't this issue occurred with page2svg?

It was not logging out javascript errors from the window to stdout (just MathJax errors and warnings).

It was not logging out javascript errors from the window to stdout (just MathJax errors and warnings).

Is there anyway to get this behavior from mjpage? The output is really ugly whereas, from my point of view, this is not an error at all.

Is there anyway to get this behavior from mjpage?

Not at this time; it's a good feature request though.

Renamed slightly.
I'm not sure if the CLI tool should have options for controlling jsdom so I'd rather leave those out for now. But because there aren't CLI options, I'll disconnect the window's console from stdout in the CLI tool (to avoid JS errors from appearing in the output).

Thanks!