Watched state from library

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] support request

General information
Addon version used
14.0b20
Description
When using the Kodi library, episodes of the series are not marked as viewed
Is it possible to implement this solution:
https://github.com/asciidisco/plugin.video.netflix/pull/293 ?
Steps to Reproduce
Expected behavior: [What you expected to happen]
Mark as watched when using library
Actual behavior: [What actually happened]
Not marked as watched when using library
Context (Environment)
Installation

[ ] I'm using this Netflix Repo
[ ] I'm using other Netflix Repo (Please specify which)
[x] I'm using a different source (Please tell which)
14.0b20

Operating System

[x] Linux (x86/x64)
[ ] OSX (x86/x64)
[x] Windows (x86/x64)
[x] Linux (ARM)
[ ] Android

Additional informatin on the environment
Debug log
Other information
Screenshots

if one day I have time i will try to take a look, but now there are more important things to fix
If someone else has time to try a porting, they're welcome

Well, maybe I could try it. Let me fork the project and try to reproduce caphm's PR.

Well, this fork was made after asciidisco#293, so this commit already exists here in this fork. Including a new file resource/lib/KodiMonitor.py was removed in some newer commit.
The problem would be somewhere else. If that commit has solved the problem, somehow, it became a problem again. I will still try to find out what changed.

For me the state works, but resume does not. When I stop the playback, it is possible to resume. Once I leave the current menu and come back, the state is still "in progress" but the resume point is gone.

On a single client, after this issue (https://github.com/CastagnaIT/plugin.video.netflix/issues/36) was fixed, it's working on my side. Can someone try with the last master ?
Remains a problem with multiple clients sharing a MySQL database: if I stop a video on client 1, I can see a resume point icon on client 2, but it won't resume and just restart the video at the beginning.

Still not working for me.

Still not working for me.

Yeay, just saw that :(
It's "funny" cause it works if you stop the video that restart it just right after.
Looks like it's the same delay as the cache TTL again, but I can't confirm yet.

For the record, from infolabels.py:
Resuming for strm files in library is currently broken in Leia Beta
keeping this for reference / in hopes this will get fixed
I tried to uncomment the code following that comment, but with no success.
The resume point is correctly set for the strm file in the database, but it seems the player can't respect it, even by forcing the StartPercent property on the listItem. I may miss something, but for now I'm stucked and don't know what else to try.
Cheers.

I saw something about a workarround in one of those "generic" stream
plugins. Not sure which. It seems they managed to skip to the correct time
after the media is already playing. That way, sometimes you see the first
frames but then jump to the correct place. It seems to be exactly the same
bug of Leia.
I'll try to look for it again.
Helvio
Em ter, 2 de abr de 2019 14:18, Smeulf<EMAIL_ADDRESS>escreveu:

For the record, from infolabels.py:
Resuming for strm files in library is currently broken in Leia Beta keeping
this for reference / in hopes this will get fixed
I tried to uncomment the code following that comment, but with no success.
The resume point is correctly set for the strm file in the database, but
it seems the player can't respect it, even by forcing the StartPercent
property on the listItem. I may miss something, but for now I'm stucked and
don't know what else to try.
Cheers.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/CastagnaIT/plugin.video.netflix/issues/7#issuecomment-479103286,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdLvUKj93iIN2VUaUfi3x8yFo1rO0xIqks5vc5DXgaJpZM4a451y
.

That's a possible workaround I've think about also, but it's ugly.
If it's a Leia bug, that should be submitted to Kodi team IMHO for a fix, as it's a regression...

Well, after some searches in the Kodi code and forums, I can say that for now, resume points can't e handeled by Kodi for STRM files.
The reason is that STRM files are considered as playlists, and playlists are excluded from resuming functions in the library.
So there's 2 options : either handle the resume function in the addon as some did with a seek to the right position, or encourage Kodi team to evolve Kodi to handle this situation properly.
I submitted an idea in the Kodi forum for this, your opinion is welcome : https://forum.kodi.tv/showthread.php?tid=342730
Cheers.

I forgot that I had already found that it was a kodi bug ... now I remembered.
https://forum.kodi.tv/showthread.php?tid=229951
https://trac.kodi.tv/ticket/12763#no2
So... the situation has been known for years :) In version 13 of the netflix plugin, it somehow worked from what I remember, but there again, UpNext does not work properly ... closed circle.

The light in the tunnel appears: https://github.com/xbmc/xbmc/pull/16076

Thanks! Let's hope Kodi team will commit the PR!

notify when it will be implemented

(I'm sorry, I had to ...)
Order accepted

@notoco Is your PR still exists? I can't find it anymore...
In the meantime, we worked on a workaround https://github.com/CastagnaIT/plugin.video.netflix/tree/4a3de522da692be42ffa946ac5b805ce605c9c81
Feedback is welcome.

It was not my PR - I only found it - and actually it disappeared some time ago.

Back to the topic. In the last daily, everything works great (I did not check the resume point, but the view state works). The episode watched is beautifully viewed as being viewed. However, if you use integration with NextUp, it does not work anymore. The last episode watched is not marked correctly. With the integration of NextUp disabled in Netflix, but in the background acting NextUp - it works - but then there is no convenience in the form of pop-ups at the same time as the final credits.
The solution would probably be to see if the watch was triggered from the library or directly from the plug-in - and therefore the corresponding serving of responses to the NextUp plugin

@notoco: if I understand correctly, when playing an episode from the library, at credits it will show NextUp correctly, then start the following episode.
On the second (and so on) episode, NextUp will continue working but none of the episodes will be marked as watched in the library.
But they are marked as watched in the Netflix addon are they?
If I didn't understand correctly, please add steps to reproduce and a capture of you NextUp settings, so I can take some time to find the problem and maybe fix it, I think I know why it behave that way...

You understood me exactly. It is not marked in the library, but in the Netflix plugin itself it is marked. For testing, I always use the default settings of the Nextup and Netflix plugins

I think this is because NextUp integration plays some "plugin://" path rather than the "library://" path.
So I have to check if the next episode is in the library, and if it is, replace the path in the NextUp data in order to play the right item...
Will keep you in touch!

Cool. I'm sorry but I have to:

Hehe ^^
But it might take a little longer than expected, I've just test to call the right path, and it's not solving the issue. I have to dig in the code more to understand the 'why'...
Damn I thought it would be very easy to fix!

@notoco can you try this branch? https://github.com/Smeulf/plugin.video.netflix/tree/Export_New_Episodes
There's a lot of new things with the library:

Auto export new episodes finally working
Tv show can be excluded/re-included from auto update (usefull for an ended tv show)
UpNext fix (hopefully)

Feedback is very welcome!
Warning: once upgraded, you won't be able to revert unless you delete the library.ndb2 in addon_data/plugin.video.netflix. So maybe it's better to try this on a specific system, or save your data before ;)

It works.
It just works. Marks both in the plug-in and in the library
I have not tried the other news yet. All in all, I still have to check the export of NFO files - many serials are not in my language on TMDB..

Heh - I know - the plugin does not generate an NFO file for the entire series, only for single episodes. And kodi requires NFO for the whole series (as a title)
https://kodi.wiki/view/NFO_files/TV_shows

TV Shows require the following nfo files
One nfo file for the TV Show. This file holds the overall show information
One nfo file for each Episode. This file holds information specific to that episode
For one TV Show with 10 episodes, you will require 11 nfo files.

Ok - my fault - the skin I use, does not show me one option, I had to scroll down:

Include all information in NFO files (use only with 'Local Information' scraper)

Thanks for you feedback. I'm glad you like it!

For me, finally, the integration of Netflix, UpNext and the benefits of using the kodi library makes sense.
A great job. Subject definitely closed.
@CastagnaIT - you just have to turn it into the main branch.
As we say in Poland:
Kawał dobrej roboty odwaliliście....

I wait some more time before giving @CastagnaIT a green to merge it in the master branch. I'm still running a custom version to ensure auto update is running fine. Hopefully at the end of the week it will be ok, if no showstopper is found!


Deleted cluster stays in Removing state

In EmberUI:

create DO infrastructure provider cluster (I tried different node configs, all of them fail)
remove DO cluster

VMs are removed from DO but cluster stays visible in rancher in Removing - Waiting on cluster-scoped-gc state.

Server logs
2021/05/31 13:16:10 [INFO] kontainerdriver rancherkubernetesengine listening on address <IP_ADDRESS>:33815
2021/05/31 13:16:10 [INFO] kontainerdriver rancherkubernetesengine stopped
2021/05/31 13:16:10 [WARNING] secrets "cattle-system/c-c-qbhdj" not found
2021/05/31 13:16:10 [ERROR] [etcd-backup] giving up on deleting backup [c-qbhdj-rl-rhrgd]: timed out waiting for the condition
2021/05/31 13:16:16 [ERROR] error syncing 'c-qbhdj/m-vdj87': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:16 [ERROR] error syncing 'c-qbhdj/m-t8zd9': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:23 [INFO] Stopping cluster agent for c-jzxr9
2021/05/31 13:16:23 [INFO] Shutting down cluster.cattle.io/v3, Kind=ClusterUserAttribute workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=Pod workers
2021/05/31 13:16:23 [INFO] Shutting down rbac.authorization.k8s.io/v1, Kind=ClusterRole workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=Service workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=Endpoints workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=Secret workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=Node workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=LimitRange workers
2021/05/31 13:16:23 [INFO] Shutting down cluster.cattle.io/v3, Kind=ClusterAuthToken workers
2021/05/31 13:16:23 [INFO] Shutting down apiregistration.k8s.io/v1, Kind=APIService workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=ResourceQuota workers
2021/05/31 13:16:23 [INFO] Shutting down batch/v1, Kind=Job workers
2021/05/31 13:16:23 [INFO] Shutting down apps/v1, Kind=StatefulSet workers
2021/05/31 13:16:23 [INFO] Shutting down apps/v1, Kind=Deployment workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=ServiceAccount workers
2021/05/31 13:16:23 [INFO] Shutting down rbac.authorization.k8s.io/v1, Kind=Role workers
2021/05/31 13:16:23 [INFO] Shutting down apps/v1, Kind=DaemonSet workers
2021/05/31 13:16:23 [INFO] Shutting down apps/v1, Kind=ReplicaSet workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=ConfigMap workers
2021/05/31 13:16:23 [INFO] Shutting down policy/v1beta1, Kind=PodSecurityPolicy workers
2021/05/31 13:16:23 [INFO] Shutting down rbac.authorization.k8s.io/v1, Kind=RoleBinding workers
2021/05/31 13:16:23 [INFO] Shutting down extensions/v1beta1, Kind=Ingress workers
2021/05/31 13:16:23 [INFO] Shutting down batch/v1beta1, Kind=CronJob workers
2021/05/31 13:16:23 [INFO] Shutting down networking.k8s.io/v1, Kind=NetworkPolicy workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=ReplicationController workers
2021/05/31 13:16:23 [INFO] Shutting down rbac.authorization.k8s.io/v1, Kind=ClusterRoleBinding workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=Namespace workers
2021/05/31 13:16:23 [INFO] Shutting down /v1, Kind=Event workers
2021/05/31 13:16:23 [INFO] Deleting cluster [c-jzxr9]
2021/05/31 13:16:23 [INFO] [mgmt-auth-users-controller] Deleting clusterRoleTemplateBinding u-6loni3qv4q-admin for user u-6loni3qv4q
2021/05/31 13:16:23 [INFO] [mgmt-auth-users-controller] Deleting globalRoleBinding grb-pt7mb for user u-6loni3qv4q
2021/05/31 13:16:23 [INFO] [mgmt-auth-crtb-controller] Deleting roleBinding crb-5ebxtxevdj
2021/05/31 13:16:23 [INFO] [mgmt-auth-crtb-controller] Deleting rolebinding u-6loni3qv4q-admin-cluster-owner in namespace p-sgvv6 for crtb u-6loni3qv4q-admin
2021/05/31 13:16:23 [INFO] [mgmt-auth-crtb-controller] Deleting roleBinding crb-cpnpfoom7h
2021/05/31 13:16:23 [INFO] [mgmt-auth-crtb-controller] Deleting rolebinding u-6loni3qv4q-admin-cluster-owner in namespace p-6dx64 for crtb u-6loni3qv4q-admin
2021/05/31 13:16:23 [INFO] [mgmt-auth-crtb-controller] Deleting rolebinding c-jzxr9-owner-cluster-owner in namespace p-sgvv6 for crtb c-jzxr9-owner
2021/05/31 13:16:23 [INFO] [mgmt-auth-crtb-controller] Deleting rolebinding c-jzxr9-owner-cluster-owner in namespace p-6dx64 for crtb c-jzxr9-owner
2021/05/31 13:16:24 [ERROR] error syncing 'c-bj6rq/m-k9k5b': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:24 [ERROR] error syncing 'c-bj6rq/m-hpb4w': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:25 [ERROR] error syncing 'c-6w448/m-66wtm': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:26 [INFO] error in remotedialer server [400]: websocket: close 1006 (abnormal closure): unexpected EOF
2021/05/31 13:16:28 [INFO] kontainerdriver rancherkubernetesengine listening on address <IP_ADDRESS>:41261
2021/05/31 13:16:28 [INFO] cluster [c-jzxr9] provisioning: Tearing down Kubernetes cluster
2021/05/31 13:16:28 [INFO] cluster [c-jzxr9] provisioning: [dialer] Setup tunnel for host [<IP_ADDRESS>]
2021/05/31 13:16:28 [INFO] cluster [c-jzxr9] provisioning: [worker] Tearing down Worker Plane..
2021/05/31 13:16:28 [INFO] cluster [c-jzxr9] provisioning: [worker] Successfully tore down Worker Plane..
2021/05/31 13:16:28 [INFO] cluster [c-jzxr9] provisioning: [controlplane] Tearing down the Controller Plane..
2021/05/31 13:16:28 [INFO] Removing container [kube-apiserver] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:28 [INFO] cluster [c-jzxr9] provisioning: [remove/kube-apiserver] Successfully removed container on host [<IP_ADDRESS>]
2021/05/31 13:16:28 [INFO] Removing container [kube-controller-manager] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:29 [INFO] cluster [c-jzxr9] provisioning: [remove/kube-controller-manager] Successfully removed container on host [<IP_ADDRESS>]
2021/05/31 13:16:29 [INFO] Removing container [kube-scheduler] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:29 [INFO] cluster [c-jzxr9] provisioning: [remove/kube-scheduler] Successfully removed container on host [<IP_ADDRESS>]
2021/05/31 13:16:29 [INFO] Removing container [kubelet] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:29 [INFO] cluster [c-jzxr9] provisioning: [remove/kubelet] Successfully removed container on host [<IP_ADDRESS>]
2021/05/31 13:16:30 [INFO] Removing container [kube-proxy] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:30 [INFO] cluster [c-jzxr9] provisioning: [remove/kube-proxy] Successfully removed container on host [<IP_ADDRESS>]
2021/05/31 13:16:30 [INFO] Removing container [service-sidekick] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:30 [INFO] cluster [c-jzxr9] provisioning: [remove/service-sidekick] Successfully removed container on host [<IP_ADDRESS>]
2021/05/31 13:16:30 [INFO] cluster [c-jzxr9] provisioning: [controlplane] Successfully tore down Controller Plane..
2021/05/31 13:16:30 [INFO] cluster [c-jzxr9] provisioning: [etcd] Tearing down etcd plane..
2021/05/31 13:16:30 [INFO] Removing container [etcd] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:31 [INFO] cluster [c-jzxr9] provisioning: [remove/etcd] Successfully removed container on host [<IP_ADDRESS>]
2021/05/31 13:16:31 [INFO] cluster [c-jzxr9] provisioning: [etcd] Successfully tore down etcd plane..
2021/05/31 13:16:31 [INFO] cluster [c-jzxr9] provisioning: [hosts] Cleaning up host [<IP_ADDRESS>]
2021/05/31 13:16:31 [INFO] cluster [c-jzxr9] provisioning: [hosts] Cleaning up host [<IP_ADDRESS>]
2021/05/31 13:16:31 [INFO] cluster [c-jzxr9] provisioning: [hosts] Running cleaner container on host [<IP_ADDRESS>]
2021/05/31 13:16:31 [INFO] Image [rancher/rke-tools:v0.1.74] exists on host [<IP_ADDRESS>]
2021/05/31 13:16:31 [INFO] Starting container [kube-cleaner] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:32 [INFO] cluster [c-jzxr9] provisioning: [kube-cleaner] Successfully started [kube-cleaner] container on host [<IP_ADDRESS>]
2021/05/31 13:16:32 [INFO] cluster [c-jzxr9] provisioning: Waiting for [kube-cleaner] container to exit on host [<IP_ADDRESS>]
2021/05/31 13:16:32 [INFO] cluster [c-jzxr9] provisioning: Container [kube-cleaner] is still running on host [<IP_ADDRESS>]: stderr: [find: /opt/rke/etc/kubernetes/.tmp: Resource busy
], stdout: []
2021/05/31 13:16:33 [INFO] cluster [c-jzxr9] provisioning: Waiting for [kube-cleaner] container to exit on host [<IP_ADDRESS>]
2021/05/31 13:16:34 [INFO] Removing container [kube-cleaner] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:34 [INFO] cluster [c-jzxr9] provisioning: [hosts] Removing cleaner container on host [<IP_ADDRESS>]
2021/05/31 13:16:34 [INFO] cluster [c-jzxr9] provisioning: [hosts] Removing dead container logs on host [<IP_ADDRESS>]
2021/05/31 13:16:34 [INFO] Image [rancher/rke-tools:v0.1.74] exists on host [<IP_ADDRESS>]
2021/05/31 13:16:34 [INFO] Starting container [rke-log-cleaner] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:35 [INFO] error in remotedialer server [400]: read tcp <IP_ADDRESS>:443-><IP_ADDRESS>:26459: i/o timeout
2021/05/31 13:16:35 [INFO] cluster [c-jzxr9] provisioning: [cleanup] Successfully started [rke-log-cleaner] container on host [<IP_ADDRESS>]
2021/05/31 13:16:35 [INFO] Removing container [rke-log-cleaner] on host [<IP_ADDRESS>], try           #1
2021/05/31 13:16:35 [INFO] cluster [c-jzxr9] provisioning: [remove/rke-log-cleaner] Successfully removed container on host [<IP_ADDRESS>]
2021/05/31 13:16:35 [INFO] kontainerdriver rancherkubernetesengine stopped
2021/05/31 13:16:35 [INFO] cluster [c-jzxr9] provisioning: [hosts] Successfully cleaned up host [<IP_ADDRESS>]
2021/05/31 13:16:35 [INFO] cluster [c-jzxr9] provisioning: Removing local admin Kubeconfig: management-state/rke/rke-870658123/kube_config_cluster.yml
2021/05/31 13:16:35 [INFO] cluster [c-jzxr9] provisioning: Local admin Kubeconfig removed successfully
2021/05/31 13:16:35 [INFO] cluster [c-jzxr9] provisioning: Removing state file: management-state/rke/rke-870658123/cluster.rkestate
2021/05/31 13:16:35 [INFO] cluster [c-jzxr9] provisioning: State file removed successfully
2021/05/31 13:16:35 [INFO] cluster [c-jzxr9] provisioning: Cluster removed successfully
2021/05/31 13:16:35 [INFO] Deleted cluster [c-jzxr9]
2021/05/31 13:16:36 [INFO] [mgmt-cluster-rbac-remove] Deleting namespace c-jzxr9
2021/05/31 13:16:36 [INFO] error in remotedialer server [400]: read tcp <IP_ADDRESS>:443-><IP_ADDRESS>:33118: i/o timeout
2021/05/31 13:16:38 [INFO] error in remotedialer server [400]: read tcp <IP_ADDRESS>:443-><IP_ADDRESS>:51712: i/o timeout
2021/05/31 13:16:41 [INFO] [mgmt-auth-crtb-controller] Deleting roleBinding crb-2xwu4qbuip
2021/05/31 13:16:41 [INFO] [mgmt-auth-crtb-controller] Deleting rolebinding creator-cluster-owner-cluster-owner in namespace p-sgvv6 for crtb creator-cluster-owner
2021/05/31 13:16:41 [INFO] [mgmt-auth-crtb-controller] Deleting rolebinding creator-cluster-owner-cluster-owner in namespace p-6dx64 for crtb creator-cluster-owner
2021/05/31 13:16:41 [ERROR] [nodepool] reconcile erorr, create or check nodes: nodes.management.cattle.io "m-" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated
2021/05/31 13:16:41 [ERROR] [nodepool] reconcile erorr, create or check nodes: nodes.management.cattle.io "m-" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated
2021/05/31 13:16:41 [INFO] Removing node mkravecm1
2021/05/31 13:16:41 [INFO] Removing node mkravecw1
2021/05/31 13:16:41 [INFO] [node-controller-rancher-machine] About to remove mkravecm1
2021/05/31 13:16:41 [INFO] [node-controller-rancher-machine] WARNING: This action will delete both local reference and remote instance.
2021/05/31 13:16:41 [ERROR] [nodepool] reconcile erorr, create or check nodes: nodes.management.cattle.io "m-" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated
2021/05/31 13:16:41 [INFO] [node-controller-rancher-machine] About to remove mkravecw1
2021/05/31 13:16:41 [INFO] [node-controller-rancher-machine] WARNING: This action will delete both local reference and remote instance.
2021/05/31 13:16:41 [ERROR] [nodepool] reconcile erorr, create or check nodes: nodes.management.cattle.io "m-" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated
2021/05/31 13:16:41 [ERROR] [nodepool] reconcile erorr, create or check nodes: nodes.management.cattle.io "m-" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated
2021/05/31 13:16:41 [ERROR] [nodepool] reconcile erorr, create or check nodes: nodes.management.cattle.io "m-" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated
2021/05/31 13:16:41 [ERROR] [nodepool] reconcile erorr, create or check nodes: nodes.management.cattle.io "m-" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated
2021/05/31 13:16:41 [ERROR] [nodepool] reconcile erorr, create or check nodes: nodes.management.cattle.io "m-" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated
2021/05/31 13:16:41 [INFO] [nodepool] deleting np-4zm6h
2021/05/31 13:16:41 [INFO] [nodepool] deleting np-lxkzl
2021/05/31 13:16:42 [INFO] [mgmt-auth-users-controller] Deleting projectRoleTemplateBinding u-7rlazmgz6b-member for user u-7rlazmgz6b
2021/05/31 13:16:42 [INFO] [mgmt-auth-users-controller] Deleting projectRoleTemplateBinding u-xv5cqvkprz-member for user u-xv5cqvkprz
2021/05/31 13:16:42 [INFO] [mgmt-project-rbac-remove] Deleting namespace p-6dx64
2021/05/31 13:16:42 [INFO] [mgmt-project-rbac-remove] Deleting namespace p-sgvv6
2021/05/31 13:16:42 [INFO] [mgmt-auth-users-controller] Deleting globalRoleBinding grb-8c5xg for user u-7rlazmgz6b
2021/05/31 13:16:42 [INFO] [mgmt-auth-users-controller] Deleting globalRoleBinding grb-pvfcz for user u-xv5cqvkprz
2021/05/31 13:16:42 [INFO] [mgmt-auth-prtb-controller] Deleting roleBinding rb-veppks6evk
2021/05/31 13:16:42 [INFO] [mgmt-auth-prtb-controller] Deleting roleBinding rb-hhdetjb73f
2021/05/31 13:16:42 [INFO] [mgmt-auth-prtb-controller] Deleting roleBinding crb-6hb6xkpbej
2021/05/31 13:16:42 [INFO] [mgmt-auth-prtb-controller] Deleting roleBinding crb-bhzoimjlxw
2021/05/31 13:16:42 [INFO] [mgmt-auth-prtb-controller] Deleting rolebinding p-6dx64-u-7rlazmgz6b-member-project-member in namespace c-jzxr9 for prtb u-7rlazmgz6b-member
2021/05/31 13:16:42 [INFO] [mgmt-auth-prtb-controller] Deleting rolebinding p-sgvv6-u-xv5cqvkprz-member-project-member in namespace c-jzxr9 for prtb u-xv5cqvkprz-member
2021/05/31 13:16:44 [ERROR] [nodepool] error updating reconcile annotation to updated: [nodepool] Failed to update nodePool annotation [np-4zm6h]: timed out waiting for the condition
2021/05/31 13:16:44 [ERROR] [nodepool] error updating reconcile annotation to updated: [nodepool] Failed to update nodePool annotation [np-lxkzl]: timed out waiting for the condition
2021/05/31 13:16:44 [INFO] [node-controller-rancher-machine] Successfully removed mkravecm1
2021/05/31 13:16:44 [INFO] [node-controller-rancher-machine] (mkravecm1) Closing plugin on server side
2021/05/31 13:16:44 [INFO] Removing node mkravecm1 done
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9': handler cluster-watch: clusterregistrationtokens.management.cattle.io "default-token" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9': handler cluster-watch: clusterregistrationtokens.management.cattle.io "default-token" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9': handler cluster-watch: clusterregistrationtokens.management.cattle.io "default-token" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9': handler cluster-watch: clusterregistrationtokens.management.cattle.io "default-token" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated, requeuing
2021/05/31 13:16:44 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:45 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:45 [INFO] [node-controller-rancher-machine] Successfully removed mkravecw1
2021/05/31 13:16:45 [INFO] [node-controller-rancher-machine] (mkravecw1) Closing plugin on server side
2021/05/31 13:16:45 [INFO] Removing node mkravecw1 done
2021/05/31 13:16:45 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:45 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:45 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:45 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:45 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:45 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:45 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:46 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:46 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:46 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:46 [ERROR] error syncing 'c-qbhdj/m-vdj87': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:46 [ERROR] error syncing 'c-6w448': handler cluster-watch: clusterregistrationtokens.management.cattle.io "default-token" is forbidden: unable to create new content in namespace c-6w448 because it is being terminated, requeuing
2021/05/31 13:16:46 [ERROR] error syncing 'c-qbhdj/m-t8zd9': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:47 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:47 [INFO] kontainerdriver rancherkubernetesengine listening on address <IP_ADDRESS>:40657
2021/05/31 13:16:47 [INFO] kontainerdriver rancherkubernetesengine stopped
2021/05/31 13:16:47 [WARNING] secrets "cattle-system/c-c-jzxr9" not found
2021/05/31 13:16:47 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:47 [INFO] [mgmt-auth-prtb-controller] Updating owner label for roleBinding crb-xxduqasa5k
2021/05/31 13:16:47 [INFO] [mgmt-auth-prtb-controller] Deleting roleBinding crb-xxduqasa5k
2021/05/31 13:16:48 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:49 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:50 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:53 [INFO] kontainerdriver rancherkubernetesengine listening on address <IP_ADDRESS>:36361
2021/05/31 13:16:53 [INFO] kontainerdriver rancherkubernetesengine stopped
2021/05/31 13:16:53 [WARNING] secrets "cattle-system/c-c-jzxr9" not found
2021/05/31 13:16:54 [ERROR] error syncing 'c-bj6rq/m-k9k5b': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:54 [ERROR] error syncing 'c-bj6rq/m-hpb4w': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:55 [ERROR] error syncing 'c-jzxr9/m-8hpnv': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:55 [ERROR] error syncing 'c-jzxr9': handler cluster-watch: clusterregistrationtokens.management.cattle.io "default-token" is forbidden: unable to create new content in namespace c-jzxr9 because it is being terminated, requeuing
2021/05/31 13:16:55 [ERROR] error syncing 'c-6w448/m-66wtm': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing
2021/05/31 13:16:56 [ERROR] error syncing 'c-jzxr9/m-gnlrj': handler node-controller: ClusterUnavailable 503: ClusterUnavailable 503: cluster not found, requeuing

Tested on master-head (5d49b92)
Works fine on rancher 2.5.7 and 2.5-head (74a37df)

Similar issue - https://github.com/rancher/rancher/issues/32689

Not sure if this is still reproducible, so verify if it is.

Unable to reproduce. Moving it to test.

Tested on Rancher master-head version 0972c3a with the following steps:
Provision a few DO clusters. (RKEv1 and RKEv2)
After clusters become active, remove clusters.
Result:
Before delete:

After delete:

Was not able to bring up RKEv2 clusters. This is a known issue. Clusters are cleaned up without being stuck in removing state. Verified on Ember UI and Dashboard. I am unable to reproduce this issue.


SAK-30996 Reorder screen - display issues with column headers

This also solves SAK-31016 Reorder screen (Announcements)- display issues with column headers, due date text

LGTM


Update semantic release to handle 22/23/Next

We will want to:

Publish versions 22.x.x to npm from a new 22 branch
Publish versions 23.x.x to npm from a new 23 branch
Publish prerelease versions from a new next branch

We should review/land these changes synchronously during a WG meeting

@brian-smith-tcril to get PR out with changes, retarget to new branches once they exist, land sync.


[UI] Strange shape at enum's values popup

Hi! This is just a little ui defect:
when i pick ProjectTree→Add→NewEnum, i see a strange shape at second popup (values)

FD <IP_ADDRESS>0  x64
ty!

upd:
this can be reproduced on custom windows themes.. I use a tweaked theme from g.m.a. windows repack.
But if i change theme to default, that shape will gone.


Extra frames show up when using split-video with ffmpeg

As the title: i don't get good cuts. But often the scenes start or end with the previous or next scene.
I'm using a standard: detect-content split-video.
It's happening with different sources.
python source: https://www.python.org/ftp/python/3.8.2/python-3.8.2.exe
pyscenedetect source: pip install scenedetect[opencv,progress_bar]
ffmpeg source: https://ffmpeg.zeranoe.com/builds/win64/static/ffmpeg-20200415-51db0a4-win64-static.zip
Here the debug command output:
debug.txt

Here a sample: https://gofile.io/?c=pf6fAV
The output: https://gofile.io/?c=DuSWBq

Using mkvmerge is fine. I only added "-c".

I was hoping this would go away after closing out #93, but it appears that it's still cropping up.  I can try shifting the start time ahead by 1 frame, but then you might miss a frame or two on other scenes.  Still not sure what the root cause is of this.
I may close this as a duplicate of #93 and reopen it.  To investigate the fix, I was going to try and use frame numbers with ffmpeg instead of timecodes - still unsure as of why the issue is occuring, however, as outputting actual images of the frames it's using as timecodes seems to line up with what is expected.
Thoughts?

@amvscenes Does the issue show up in the actual video frames, or just the thumbnail?  I took a quick glance at the output you sent and didn't immediately see anything wrong.  How should I be validating what you're seeing?  (Extracting all frames to images?)

I can see that when playing it and if i analyze it into a movie editor.
If you export all frames you see that the split contain two scenes instead of one.
scene 03

scene 04

I removed frames in between to show the issue.

Thanks for the response.  Last thing for now then, if you use the save-images command, are the first/last frames that PySceneDetect extracts correct?
I'm still not entirely sure what the underlying issue is here, because the timecodes passed to both mkvmerge and ffmpeg are the same in both cases...  I'll try to see if I can get to the bottom of this though, hoping there's a way I can get ffmpeg to produce frame-perfect cuts without too much trouble.  Thanks for the data.

Yes. The save-images output is perfect.

Hey @amvscenes;
So I did some further digging here, and noticed something interesting - when re-encoding the file with ffmpeg, the framerate seems to double for some reason?  Also the framerate of the original video is a rather odd number, can you confirm that it is correct?
I'm able to replicate this issue on my end, but not sure exactly how to proceed.  I was able to get frame-accurate cuts by manually specifying -frames to ffmpeg, but ffmpeg thinks the framerate is actually 47.9fps (twice the input), whereas both OpenCV and vlc indicate that the original framerate is 23.9-something FPS.  Thus, the frame length I would calculate would be completely wrong (since the output seems to have twice the number of frames).  I'll investigate if forcing the output framerate would be an acceptable workaround, since it seems like there is indeed duplicate frames in the output in this particular case, although why that is I'll need your help to solve.
You mentioned this happens with different sources, do they all share the same framerate/codec?  Have you noticed the doubling in framerate in the output?  Generally issues like that can be caused by corrupted video files, although since you mentioned this happens with several sources, I'd like to dig a little further into that and see if there is any commonalities between those sources (specifically how they were encoded).

Hey again @amvscenes;
Would you be able to provide a longer clip?  It seems like the actual timestamps get skewed over time in this particular case, and specifying a framerate override doesn't seem to help.  I did fix an issue where the end timestamp could select an extra frame (pushed to master), but here it seems like over time, the actual timestamps need to be shifted backwards.
I'm not entirely sure why this is happening here, but given ffmpeg's misinterpretation of the framerate, something suspicious is definitely going on here.  Additional samples and any other information you can provide would be most helpful.

Sorry for the comment spam, this issue has been driving me crazy.  It seems like the original video you provided either has a variable framerate, or something is wrong with the way ffmpeg is decoding the codec.  Supplying -vsync 0 to ffmpeg changes the framerate to 24.something FPS from the original value.
That being said, I was able to yield acceptable output by supplying -r {VIDEO_FPS} -vsync 0, although ffmpeg does give a warning for that.  Would you be able to see if adding that resolves the issue you're seeing?  The command you can use to verify this on your end is:
scenedetect -i sample.m4v detect-content split-video -a "-r 23.927353 -vsync 0"

Where 23.927353 is the framerate of the sample.m4v file you provided.  If the above command resolves this issue, I'll look into adding an option to automatically add those settings (e.g. --framerate-override), or determine if I can detect a discrepency in the framerate that ffmpeg detects versus the original video, and somehow apply the option automatically.
If you do get positive results with the above command, can you also try it on a few other videos to make sure it indeed resolves the issue you're seeing?  Thank you!

So that command works fine on the sample. The cuts seem right.
As sources I tested other japan television series that probably have the same enconding.
Thank you for noticing that the sample is weird. I discovered that it's fault of the extractor that I used which was handbrake.
Here a sample extracted with mkvmerge: https://gofile.io/?c=prFFXF
It does give out different output with this sample, but it kinda have the same issue.
Your command fix even the new sample.

So, I tested with an american live action series and I have the same issue.
It seems that in front or end of each split there is a next or previous scene frame, freezed for sometime.
Since it's still 23.976 fps I tried your command and it fixed even on that source.
They are coming from different places with different encoding settings. So I don't think it's a source issue but a general one.
Also, it doesn't only fix the cut, it also let mpc show a correct lenght while playing. With the wrong cut versions, it's like mpc doesn't know how long they are and when they will finish.

Gotcha, I'll have to keep experimenting with the command line options then to make sure this doesn't break anything else.  Would you be able to provide me another sample I can use for testing?  (you can leave a comment here if you'd prefer to not post it publicly)
Ideally I'd like to have a small collection of videos I can use for automatic testing to make sure the cuts from ffmpeg line up with the ones from save-images, to make sure any changes I make really do solve the issue.  Thanks again for your help.

Here 2 minutes extracted at half episode of one anime and one live action: https://gofile.io/?c=hPbOy3

I realized the last comment is only 2 days old, but wanted to jump in that I am having the same issue with FFmpeg, haven't tested mkv yet (was hoping for mp4 outputs).
Running on MacOS, FFmpeg 4.2.1.
The clip is 29.97 FPS, would I just add a similar line to what is suggested above "-r 23.927353 -vsync 0" but with the correct frame rate? ie "-r 29.97 -vsync 0"

Hi, thought I might be able to add another data point here, running PySceneDetect on a linux system. I've split up a video into scenes and stats, with images and video. It's all zipped up here:
https://mega.nz/file/vPgRkQgA
Using this video:
https://www.youtube.com/watch?v=oKiF45RBfHg

In windows default video player, "Films & TV", the sound doesn't start for a few seconds after the clip starting when first opening, it actually skips forward a couple seconds, to start playing video when the sound starts. Then there are 5 seconds of sound with the frozen final frame of the scene at the end of the video.
Playing in VLC, it seems to work fine.
In windows photo viewer, no sound for 3/4 seconds at the start, and at the end there are 2-3 seconds of sound with the first frame of the next scene, frozen.
Playing in telegram desktop's media player, the final frame shows as the next scene.
Playing in telegram mobile's media player, the final 2 seconds are the first frame of the next scene frozen.

This might or not be related, but in video_splitter.py, lines 235 to 238:
https://github.com/Breakthrough/PySceneDetect/blob/e1ee8e3d95fc025c12973ce985eb73ff8c488c81/scenedetect/video_splitter.py#L235-L238
What are the -strict and -2 arguments? I don't see them anywhere in the ffmpeg docs: https://ffmpeg.org/ffmpeg.html
Also, why are you using -t and calculating duration yourself, rather than using -to and specifying the end timecode?
Looks like the rest makes sense:

-y overwrite without asking
-ss start time
-i input file
-sn skip copying subtitles

But those 3 confused me a bit, I'm not sure whether swapping -t for -to might fix your problem, but it's gotten a bit later than I expected here so I can't investigate it myself today.

@jelias Can you share any of the media you're using to add to the test suite?
@joshcoales Sorry I'm also a bit tied up at the moment, but this is definitely the highest prirority issue for PySceneDetect currently - will be looking to schedule some time in the coming months to address this, so thank you for your addional test cases.  Any additional information you can glean/investigate in the meantime will be much appreciated.
Thank you all, and sorry I've been so busy with IRL stuff lately!

No worries at all! Life is a bit crazy right now for a lot of us, it's very understandable! I hope to be able to investigate some more tomorrow, but thank you loads for creating this library

I've filed a PR now which should fix this, by moving start timecode after input specification, and moving end timecode a frame earlier.
https://github.com/Breakthrough/PySceneDetect/pull/166

@Breakthrough Sorry I didn't get back to you sooner. Yes! You can download the clips here.
@joshcoales Hopefully the PR goes through! Do you know if there would be a workaround for the current version? Trying to split a few files tomorrow and worried about hitting this blocker again.. Would there be a way to add a flag in the terminal line?
Or would the solution be build from your src?

I don't think there's a workaround without going in and editing the video splitter file in the installed package. The arguments passed to ffmpeg are in an order ffmpeg doesn't like.
A temporary workaround, until the PR is merged, is to uninstall the package and install the version from my branch, like so:
pip uninstall scenedetect
pip install git+https://github.com/joshcoales/PySceneDetect.git@cut-video-without-final-frame

But you'll want to uninstall and reinstall from master once it's merged

Will be working on adding integration/unit tests for this issue next week so that once a fix has been implemented, regressions can be prevented.  This is still happening on master unfortunately, but will be spending some time to hopefully correct all remaining instances of this issue this upcoming week.
Many thanks to @joshcoales for his help on this (esp #166), looking forward to finally stomping this one out for good.

@jelias Do you recall which of these files gave you the most problems?  Would like to pick a good example to add as an integration test - am having trouble replicating the issue locally again, so want to know exactly which produced incorrect results on your end; thanks!

@jelias Sorry for sounding like a broken record, I was thinking I found it but it seems like I'm still unable to replicate this on my end.  Which tool are you using to verify the output of PySceneDetect with?
If I copy the audio stream, the resulting length reported by VLC is incorrect, but manually decoding frame-by-frame using OpenCV still shows the last frame as lining up with what was expected.  Re-encoding the audio results in VLC reporting the correct length.  I'm unable to extract any frames that are outside of the expected scene, however.

@amvscenes Could you provide me a live action example again?  Sorry I wasn't able to follow up on this until now.
I did some more experimenting on the source you provided, and for some reason, if I re-encode it before providing it to PySceneDetect, the correct output appears.  Something weird is happening with that particular source file, where the framerate ffmpeg detects is different than what it actually plays back at.

hey @Breakthrough! No, not sounding like a broken record, sorry I've been AFK for a bit but just caught these. I will try to go through my files in the next few days to find a good example (happy to provide original and split). In terms of verification, I've been either viewing the clips in VLC or dropping them directly into Premiere Pro—I think that's what you mean?
 Here are those files finally..
https://drive.google.com/file/d/1AVO1OTPqCoVraepnpfVDGvYUvBO1F5jY/view?usp=sharing
Note, this link will be broken after December 2020

Haha thank you!!  When I saw the title of the issue in my inbox my initial reaction was "oh no, not again..." lol, thank you for this being a good comment.  This is incredibly valuable for any further regressions, much appreciated.  This is exactly what I needed to develop an integration test for this sort of thing.
Have you tested the latest release on your machine out of curiosity?

Hahaha oh no, I know that exact feeling. The Github Issues emails 😰. I have not no, I'll try to play around it this week if I can. Probably time to run some updates anyway...

I get this issue again, using the latest version

@donghoonlee20 does it happen even if you re-do the file container with ffmpeg using -c:v copy?


Customize server v3

@wenlock, the manageI3SConnections block is a lot smarter about how to do the connection piece. Let me know what you think and what needs to change.

LGTM


Refactored code to use flow router, add classes and permissions, general code refactoring.

Giant commit, sorry. Refactored code to use flow router, cleaned up code in places, functioning classes and permissions.
This branch is still WIP but feel free to jump in with feedback.
Currently working on tests and documentation.

Does this need a rebase? I see lots of files that i don't think have actually been changed (configuration files, stylesheets, assets, etc). It's kinda hard to see what actually changed.

@sneakysneaky Yeah it does. Will do.


Match IL intrinsic expansion logic with CoreCLR

See #6378. This will be needed to compile CoreLib.

Fixed in #7700.


Fixes some code safety issues, modernized a few things

This should also fix issue #1.

LGTM. Thanks!


Abyss watcher no longer shows on top of waystones on 2.2.0

They only show on top of active (claimed) waystones.
If this waystone has been claimed before the update and there is no abyss watcher, for the time being, unclaim then claim again.

Yes I've claimed it before. Have exactly do I unclaim it so I can claim it again?

In the waystones config gui there's a trash can icon for revoking ownership. Closing then opening the wayatone again will re-claim it.
As of 2.2.1, I made it so that it refreshes the Active state on right click even without unclaiming it.


Add missing KKUeM to SelectRecoMC KalSeedMCAssns

While looking at the new EventNtuples, I noticed that sometimes there were different numbers of elements in the trk branch than in the trkmc branch:
root [2] ntuple->Scan("trk.nhits:trkmc.nhits")
***********************************************
*    Row   * Instance * trk.nhits * trkmc.nhi *
***********************************************
*       15 *        0 *        51 *        48 *
*       15 *        1 *        28 *        28 *
*       15 *        2 *        51 *        48 *
*       15 *        3 *        51 *        27 *
*       15 *        4 *        27 *        31 *
*       15 *        5 *        31 *        47 *
*       15 *        6 *        50 *           *
***********************************************

After some debugging, I tracked this down to the fact that KKUeP tracks are missing from the Assns that associates KalSeeds to KalSeedMCs. It looks like a simple typo in the SelectRecoMC configuration: we are missing KKUeP and have KKUmuP twice.
I've tested this change locally and now get the expected result:
root [2] ntuple->Scan("trk.nhits:trkmc.nhits")
***********************************************
*    Row   * Instance * trk.nhits * trkmc.nhi *
***********************************************
*       15 *        0 *        51 *        48 *
*       15 *        1 *        28 *        28 *
*       15 *        2 *        51 *        48 *
*       15 *        3 *        51 *        48 *
*       15 *        4 *        27 *        27 *
*       15 *        5 *        31 *        31 *
*       15 *        6 *        50 *        47 *
***********************************************

Hi @AndrewEdmonds11,
You have proposed changes to files in these packages:

JobConfig

which require these tests: build.
@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.
:hourglass: The following tests have been triggered for 3a82d1ef0521baab102509c48e076ffe4b888374: build  (Build queue is empty)
About FNALbuild. Code review on Mu2e/Offline.

:sunny: The build tests passed at 3a82d1ef0521baab102509c48e076ffe4b888374.

Test
Result
Details

test with
:white_check_mark:
Command did not list any other PRs to include

merge
:white_check_mark:
Merged 3a82d1ef0521baab102509c48e076ffe4b888374 at 8057b7e59b181c35f3f1b76961cac8ea11957b14

build (prof)
:white_check_mark:
Log file. Build time: 08 min 30 sec

ceSimReco
:white_check_mark:
Log file.

g4test_03MT
:white_check_mark:
Log file.

transportOnly
:white_check_mark:
Log file.

POT
:white_check_mark:
Log file.

g4study
:white_check_mark:
Log file.

cosmicSimReco
:white_check_mark:
Log file.

cosmicOffSpill
:white_check_mark:
Log file.

ceSteps
:white_check_mark:
Log file.

ceDigi
:white_check_mark:
Log file.

muDauSteps
:white_check_mark:
Log file.

ceMix
:white_check_mark:
Log file.

rootOverlaps
:white_check_mark:
Log file.

g4surfaceCheck
:white_check_mark:
Log file.

FIXME, TODO
:white_check_mark:
TODO (0) FIXME (0) in 0 files

clang-tidy
:white_check_mark:
0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 3a82d1ef0521baab102509c48e076ffe4b888374 after being merged into the base branch at 8057b7e59b181c35f3f1b76961cac8ea11957b14.
For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.


Fix broken link to finished solution

This PR fixes the broken link to the finished solution referenced in the "Migrating from ASP.NET Web API 2 to MVC 6" document.

Thanks<PHONE_NUMBER>572861ab4e65c1a975a4006b2ef6d1


chime soundboard is down

I've literally just tried it out and it's working for me: https://streamable.com/0ekhtf. Weird!
Maybe a browser issue? If so I assume it's an issue that's coming from Streamlit.

Yeah it seems to be working now.
One question; why not host these as static files on something like netlify? The load times are bound to be much faster.

Well I didn't really think about it. I thought that using a Python runtime is cool because it acts as a unit test by actually running chime and not just the sounds themselves.
But you're right, it would be faster. I might consider it in the future if the project's user base grows :)

Actually the soundboard is still not working on Safari so I'll keep this open while it isn't.

This will be fixed with the release of streamlit 0.68.2; I've tested the nightly build and it worked. I've update the streamlit requirement in poetry.


doc metadata

Allegedly fixes failure of doc build on crates.io
https://docs.rs/crate/antilysis/0.2.0/builds/1475391

$ rustdoc src/lib.rs --target x86_64-pc-windows-gnu
lead to: Some errors have detailed explanations: E0432, E0433.


Properties "colId" and "field" are used inconsistently when getting / setting the filter model.

Hi there,
after upgrading to the latest version, I noticed that, when calling the getFilterModel() function, I receive information based on the columns "field" property.
However, calling the setFilterModel will only work, when the filter information is using the "colId" property of the column. I think this is to a recent change to the getColumn function of the ColumnController - before it was matching columns by "field" - not its using "colId".
As I am working with grids using two dimensional arrays as data, "colId" and "field" are not the same for my columns.
It would be nice if you could take a look at this. Thanks!

the colId is calculated as follows:
            if (colDef.colId) {
                this.colId = colDef.colId;
            } else if (colDef.field) {
                this.colId = colDef.field;
            } else {
                this.colId = '' + Column.colIdSequence++;
            }

in other words, if you don't provide a colId in your colDef, it will then use the field. if the field is also missing, an id will be generated.
knowing this, is it still a problem??

Thanks for the quick response - let me try to clarify my problem.
I'm setting both the field and the colId in the column configuration, for example
field: '0' and colId': 'code'
As I mentioned I'm working with two dimensional arrays as data - therefore I use the colId to specifiy a meaningful name for the column.
Now when calling getFilterModel, I get:
{
  "0" : {
   //filterModel
  }
}

Calling setFilterModel with the same object won't work, I have to use the following object:
{
  "code" : {
   //filterModel
  }
}

As far as I can tell getFilterModel uses the columns field property. However setFilterModel needs the columns colId to work properly.

they should both be using the colIds - in case field is not unique. let me check . . .

i checked in a fix. now col-id is used consistently everywhere.
using field was legacy, before i introduced col-id. col-id is unique, field may not be.

Nice, thanks for your help!


Change order of emojis on create page

We need to add possibility to change order of emojis on create page using drag and drop.
The whole process should be smooth, and work similar like changing orders of questions.
Note Please remember on mobile screen case, where we have emojis in more than one row.

Hello @Ryczko I would appreciate it if you could assign the implementation of this feature to me.


Fix link to CONTRIBUTING from README

I stumbled upon this broken link today 😅
Is this going to be merged?

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Latest releases missing from maven repository

Hello there 👋
Thanks a lot for avro4k! I noticed that the latest two releases are missing from https://mvnrepository.com/artifact/com.sksamuel.avro4k/avro4k -- can I request that they be also published there?
Thanks, and rock on!

0.21.0 has just been released, and should be on maven central.


updated to newest version

not sure why this is the only editor extension that hasn't been updated :/
If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[ ] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses.
[ ] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] If the sha256 changed but the version didn’t,
provide public confirmation by the developer: {{link}}

Additionally, if adding a new cask:

[ ] Named the cask according to the token reference.
[ ] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[ ] Checked there are no open pull requests for the same cask.
[ ] Checked the cask was not already refused in closed issues.
[ ] Checked the cask is submitted to the correct repo.

Thank you for your contribution!
Please fill out the pull request template next time. You may wish to use cask-repair. It takes care this for you.


chore(docs): document console plugin

Looks good.

Merged in way back https://github.com/angular/protractor/commit/19b4bf21525a683c8cc3ba21018c194cac9b6426


Github release is 1 patch older than the npm package release

Github release is on 1.1.1, but npm shows 1.1.2.
I know it sounds unnecessary , but I love consistency :sweat_smile:

Thanks


Open Source Replacement for discovery.dotmesh.io

Hello,
I was reading through the documentation and architecture of dot mesh and I'm trying to run it on my own VM. Everything seems to work well so far but I noticed that when I init a cluster I get the message:
If you want more than one node in your cluster, run this on other nodes:
dm cluster join https://discovery.dotmesh.io/<some_key>:<some_key>

What is https://discovery.dotmesh.io/ doing?
What are the keys that appear?
and I guess more importantly, how can I replicate discovery.dotmesh.io on my own?
Thanks a lot!

Oh and how can I replace the hub? can I just point to another server running dotmesh-server and just pull from it?

The discovery server is just https://github.com/etcd-io/discoveryserver, you should be able to use that as a drop-in replacement I think (please let me know any issues)

Oh and how can I replace the hub? can I just point to another server running dotmesh-server and just pull from it?

Yes! The hub is just another dotmesh cluster :)


x/crypto/ssh: CertChecker.CheckCert ability to check against multiple principals

What version of Go are you using (go version)?
$ go version
go version go1.13.4 linux/amd64

Does this issue reproduce with the latest release?
N/A (x/crypto is separate dependency)
What operating system and processor architecture are you using (go env)?
N/A for this issue (Linux x86_64)
What did you do?
I was testing pam-ussh, which uses x/crypto to validate SSH certificates via ssh-agent before deciding to authorize sudo.
The issue as it relates to pam-ussh is described here: https://github.com/uber/pam-ussh/issues/15
pam-ussh has its own logic for checking principals in certificates. However the certificate was being rejected by CheckCert() before it even got to that point.
What's happening is this: pam-ussh calls CheckCert() to see if the certificate is valid.  However it has a fixed policy, which is: if the certificate has any principals, then the supplied "principal" string value must appear in that list.  Code: https://github.com/golang/crypto/blob/master/ssh/certs.go#L384
In the case of pam-ussh: because you must pass in a principal, it passes in the current username, and this enforces a policy that the bare username must appear as a principal in the certificate.
This is equivalent to the default login policy with OpenSSH if you don't provide an AuthorizedPrincipalsFile or AuthorizedPrincipalsCommand option.  However if you do, the given file or script defines a list of possible principals which are permitted to appear in the certificate.
CheckCert() doesn't appear to be able to handle this case: if the certificate has any principals, then only one item can be provided to match against it.  If you pass an empty string then it will require the certificate to contain the empty principal (it's unclear if that's even a thing).
What did you expect to see?
The solution I prefer is to have a variant of CheckCert() which takes a slice of principals, instead of a single principal.  If the certificate contains any principals, then at least one of them must be in this list.  This replicates the checking policy of OpenSSH.
(Aside: this implies that an empty list will never authorize a certificate which contains principals; that is I believe consistent with OpenSSH)
The existing CheckCert() can then become a wrapper around this new function, passing its "principal" argument as a 1-element slice.
Other options I considered:

Pass a callback function to CheckCert for checking principals

Add another callback function to the CertChecker struct.  It would still receive the "principal" argument from CheckCert, but your callback function could treat it differently, e.g. parse it as a comma-separated list.  If the function is nil, it would use the current logic.

Have a way to disable principal checking altogether in CheckCert, so that the caller can do their own check.  Passing empty string for principal might be a way to do that, which would avoid any change to call signatures, although it depends whether certificates with empty principals are a useful "thing" or not.  If not, it would simply be:
        if len(principal) > 0 and len(cert.ValidPrincipals) > 0 {

/cc @FiloSottile @katiehockman

Have a way to disable principal checking altogether in CheckCert, so that the caller can do their own check.

There was a suggestion in https://github.com/uber/pam-ussh/issues/15#issuecomment-626049436 that you can bypass the principal check by passing in the first principal of the certificate itself:
if err := c.CheckCert(cert.ValidPrincipals[0], cert); err != nil {

(or empty string, if the cert has no principals).  Then you perform a custom principal check afterwards.  If that's considered an acceptable workaround then this can be closed.


editor:delete-to-beginning-of-word at start of line should just remove up to the linebreak

When pressing ctrl+backspace to delete a word, it shouldn't delete any characters on the previous line.

Hello guys, this issue is still around. Using Debian 8 and Atom 0.198.0. If the file uses DOS line endings everything works as it should. But with UNIX line endings the problem is visible. I could beta test if anyone comes up with a fix.

Hello everyone, as of version 0.211.0 the behavior described in the OP's original post (Ctrl+Backspace at the beginning of the line deletes words on the previous line) still exists on Ubuntu 14.04.2 but does not exist on Windows 7. Any ideas on workaround?

Further confirming my previous comment, if I use the line-ending-selector package to switch to CRLF then using Ctrl-Backspace at the beginning of a line works as expected and does not delete words on the previous line. Any ideas on a fix? It's driving me crazy.

Thanks zyklus! I use Ubuntu 14.04 with unity, this is how I changed the keybindings:
'.workspace .editor':
  'ctrl-delete'     : 'editor:delete-to-next-word-boundary'
  'ctrl-backspace'  : 'editor:delete-to-previous-word-boundary'
  'ctrl-left'       : 'editor:move-to-previous-word-boundary'
  'ctrl-right'      : 'editor:move-to-next-word-boundary'
  'ctrl-shift-left' : 'editor:select-to-previous-word-boundary'
  'ctrl-shift-right': 'editor:select-to-next-word-boundary'

Apparently still not fixed?
System: Ubuntu 16.04.1 LTS
Line ending: LF
Atom: 1.11.2
Community Packages (11):
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>As cswartzvi already said, it is really frustrating!

I just tried to switch to atom about the 10th time and ran into that issue.
I'm using OSX 10.12.5 and Atom 1.19.5.


feat: Only count languages that should be counted for jw.org

Thanks, this was a great start. I modified it further in 65a853432ebc85fd5b9eaa85bdd2e27dd18e894f to include formatter changes and more detailed info on counted and uncounted languages.


Test target fix

Previously (in #12) when running make test the verify-unchanged command was not found.
The following change will resolve it

/lgtm


net: lib: dhcpv6: add prefix delegation

This PR adds two commits:

Autoconfiguration of IPv6 addresses is moved to a separate unit so it can be used also by DHCPv6 module
Add option to distribute multiple IPv6 subnets based on a prefix received from DHCPv6 server

I need to apply a few final touches to tests and I will add them in an additional commit

@konradderda do you plan to come back to this PR?

@konradderda any news on this?

@konradderda ping


[BUG] Animations don't start after rewarded ad is closed

Describe the bug
When a rewarded ad is closed, it switches back to the game but it doesn't seem to continuing the game. All the animations stop playing and it won't take input. It is like the game is not getting updated.
After switching apps everything resumes like normal.
To Reproduce
Steps to reproduce the behavior:

Wait for MobileAds to initialize.
Load a rewarded ad.
Show the rewarded ad.
After closing it, nothing gets updated.

Expected behavior
After the ad is closed the game should resume.
Screenshots
N.a.
Smartphone (please complete the following information):

Device: iPhone SE 2016
OS: iOS 14.6
Version: 3.3.2

Additional context
A stack trace:
******** stop animation!
2021-07-03 15:57:43.228692+0200 bouncybox[9735:347477] Calling load_rewarded
2021-07-03 15:57:43.228845+0200 bouncybox[9735:347477] rewarded will load with the id
2021-07-03 15:57:43.228919+0200 bouncybox[9735:347477] ca-app-pub-xxxxxxxxxxxxxxxxx/xxxxxx
2021-07-03 15:57:44.403777+0200 bouncybox[9735:347477] WF: _userSettingsForUser mobile: {
    filterBlacklist =     (
    );
    filterWhitelist =     (
    );
    restrictWeb = 1;
    useContentFilter = 0;
    useContentFilterOverrides = 0;
    whitelistEnabled = 0;
}
2021-07-03 15:57:44.403845+0200 bouncybox[9735:347477] WF: _WebFilterIsActive returning: NO
2021-07-03 15:57:45.671336+0200 bouncybox[9735:347477] reward successfully loaded
2021-07-03 15:57:49.997390+0200 bouncybox[9735:347477] [assertion] Error acquiring assertion: <Error Domain=RBSAssertionErrorDomain Code=3 "Target is not running or required target entitlement is missing" UserInfo={RBSAssertionAttribute=<RBSDomainAttribute| domain:"com.apple.webkit" name:"Suspended" sourceEnvironment:"(null)">, NSLocalizedFailureReason=Target is not running or required target entitlement is missing}>
2021-07-03 15:57:49.997542+0200 bouncybox[9735:347477] [ProcessSuspension] 0x114bc8cc0 - ProcessAssertion: Failed to acquire RBS Suspended assertion 'WebProcess Suspended Assertion' for process with PID 9854, error: Error Domain=RBSAssertionErrorDomain Code=3 "Target is not running or required target entitlement is missing" UserInfo={RBSAssertionAttribute=<RBSDomainAttribute| domain:"com.apple.webkit" name:"Suspended" sourceEnvironment:"(null)">, NSLocalizedFailureReason=Target is not running or required target entitlement is missing}

After switching apps an going back to my game I see this:
2021-07-03 15:58:08.748383+0200 bouncybox[9735:347477] Could not signal service com.apple.WebKit.WebContent: 113: Could not find specified service
2021-07-03 15:58:19.983539+0200 bouncybox[9735:347477] Could not signal service com.apple.WebKit.WebContent: 113: Could not find specified service
2021-07-03 15:58:22.830438+0200 bouncybox[9735:350475] [connection] nw_endpoint_handler_set_adaptive_read_handler [C7.1.1 2a00:1450:400e:808::200e.443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] unregister notification for read_timeout failed
2021-07-03 15:58:22.830686+0200 bouncybox[9735:350475] [connection] nw_endpoint_handler_set_adaptive_write_handler [C7.1.1 2a00:1450:400e:808::200e.443 ready channel-flow (satisfied (Path is satisfied), viable, interface: en0, ipv4, ipv6, dns)] unregister notification for write_timeout failed
start animation!

I think it has something to do with the
******** stop animation!

and
start animation!

lines.

Hi @SanderVanhove thanks for reporting it, we will check it

https://user-images.githubusercontent.com/20030153/124389081-f9085500-dcbb-11eb-992a-654893735f1f.mov
@SanderVanhove hi, we tested here and it's working normally, can you send to us more detail about what are you doing?
If possible try to record a video for us.
Also try to download again the updated version of Editor Plugin and iOS Plugin

Hey Gustavo, thanks for getting back to me!
Here is a video of what I mean:
https://user-images.githubusercontent.com/18272282/124393803-8c617a80-dcfc-11eb-9111-5cfa0170ae10.mov
As you can see, after closing the ad, the animations stop. After I switch back to the app they resume.
I also tried the newest build of the plugin without any advance. The admob_api folder is gone from the master branch in this repository by the way.

Aha I have found the problem!
Everytime I showed an ad I did this:
MobileAds.show_rewarded()
MobileAds.load_rewarded()

As soon as I showed an ad I started loading a new one, in another library this was possible. But with this library it gives the behaviour I showed you. Now I only start loading the new ad when the old one is closed and that does the trick! 😁
I don't know if this should be considered a bug?

Yes, I guess this is a bug, we will check why is this happening

@SanderVanhove we are migrating the iOS Plugin to a dedicated repository, you can check here: https://github.com/Poing-Studios/godot-admob-ios
Pros:

You can change the version of your Plugin whenever you want to
Separe the iOS code of Android code


Update migrate-onenote-spmt.md

Removed surplus HTML line breaks.
Corrected markdown for Important.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@JoanneHendrickson PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


(PUP-7834) Replace all calls to YAML.load with YAML.safe_load

This commit replaces all calls to the unsafe YAML.load method with
calls to YAML.safe_load to gain control over exactly what classes that
are permitted to create instances during the load.

CLA signed by all contributors.

@joshcooper, The Puppet::Util::Yaml.load_file removes all !ruby tags from all elements. AFAIK, this is something we cannot to if we want to retain backward compatibility. The YAML that we provide must be allowed to contain a limited set of tags.
What would you think of a solution where all #safe_load calls in this PR are transformed into calls into Puppet::Util::Yaml#load_files and in addition, that method would also be made aware of allowed classes (i.e. it would accept an extra parameter with an array of known classes and not remove tags appointing them)?

The last commit uses a slightly different approach than what I first suggested. It leaves the Puppet::Util::Yaml#load_files method untouched since it has very different semantics (it loads a file and actually retains values with tags stripped) and adds a Puppet::Util::Yaml#safe_load that acts on yaml content, a set of allowed classes, and a file name. For rubies >= 2.1.0, simply dispatches to YAML.safe_load. For earlier versions, it emulates the behavior.

ping @joshcooper

I had done something similar to what you are doing in mcollective (where I think we are semi officially supporting ruby 1.9.3 - on your own type).

@joshcooper, I know you're busy and this isn't top prio but I'd appreciate if you could take a look at my last commit on this one.

Hi @joshcooper
Could you pl review per @thallgren 's last response/rationale. I think the approach looks reasonable - even if we were to leave out YAML.load's for ruby < 2.1.0 (no worse than current state). thanks,

Hi @thallgren, with the 5.5.x branch being cut, please retarget that branch, if appropriate.  Thanks!

@kris-bosland I'm afraid that I don't understand. Can you please elaborate? What branch should be retargetet and whereto?

Hi @thallgren, if this PR is something that should go into Puppet release 5.5.x, please Retarget to that branch.  Hope this helps!

Given we're whitelisting what is allowed to be deserialized from YAML, and the potential to "break someone's workflow" I would prefer to target puppet#master for 6.0.

@thallgren Might want to rebase onto the latest master. When I merged this manually into the latest master and ran the tests, I got a test failure with Ruby 2.3.6 that I don't see in either your branch or on master itself.
  1) The lookup API when hiera YAML data is empty logs a warning when --strict is 'error'
     Failure/Error: raise Puppet::DataBinding::LookupError, msg if Puppet[:strict] == :error && data != false
     Puppet::DataBinding::LookupError:
       /var/folders/j1/m3_gp89x2tl9hrmvx0981rx00000gp/T/rspecrun20180320-59408-1qogtm0/environments20180320-59408-1u6xo28/spec/modules/mod/data/common.yaml: file does not contain a valid yaml hash
     # ./lib/puppet/functions/yaml_data.rb:29:in `block in yaml_data'
     # ./lib/puppet/pops/lookup/context.rb:52:in `cached_file_data'
     # ./lib/puppet/pops/lookup/context.rb:110:in `cached_file_data'
     # ./lib/puppet/functions/yaml_data.rb:22:in `yaml_data'

...

Finished in 6 minutes 13 seconds
24603 examples, 1 failure, 47 pending

Failed examples:
rspec './spec/unit/pops/lookup/lookup_spec.rb[1:3:3]' # The lookup API when hiera YAML data is empty logs a warning when --strict is 'error'

Ping @thallgren whenever you get a chance could you pl check? I would like to get the PR for enabling rubocop scans in. thanks

Superseded by https://github.com/puppetlabs/puppet/pull/6972


Defaults for interval/retry or bulk edit

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
Other
🔖 Feature description
It would be awesome if:

defaults could be set somewhere so new monitors default to 60-3-20 (for example)
we could select multiple monitors (of same type) and change the parameters en masse

✔ Solution
After setting up 40 or so ICMP monitors, I started getting false alarms with 1 dropped ping packet. I realized the defaults of 60-0-60 are not ideal for me. I prefer 60-3-20. But now I have to manually edit each monitor and re-save it.
❓ Alternatives
I think I could execute some SQL directly on the db to do the bulk update of these parameters, but I am not sure if that is safe.
📝 Additional Context
No response

For now, I poked around the SQLite db and figured out how to do it manually.
List all monitors with some detail
# sqlite3 -header /app/data/kuma.db 'select id,type,name,hostname,interval,maxretries,retry_interval from monitor'

Update all ICMP monitors that don't have retries==3 and interval==20:
# sqlite3 /app/data/kuma.db 'UPDATE monitor SET maxretries = 3, retry_interval = 20 WHERE type = "ping" AND (maxretries != 3 OR retry_interval != 20)'

@luckman212
I think this is a partial duplicate of https://github.com/louislam/uptime-kuma/issues/455
Duplicates only create immortal zombies and are really hard to issue-manage.
Could you edit your issue (description + title) to make this unique? ^^

@CommanderStorm You are correct, this appears to be a duplicate of #455. I will close this one, thank you.


Add Create Schema functionality in SQL

Which issue does this PR close?

Task 1 for #1877
Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

I'm working on this and im wondering why register_schema isnt a trait method for CatalogProvider.  For example register_table is part of SchemaProvider trait and i consider a schema to be the equivalent for a catalog.

This has surprisingly been a bit of a pain.  Currently having issues with getting the schema registration to work.  At the moment its not clear to me what the issue is.

Got this working.  Just need to resolve conflicts.
@alamb do you have preference on whether to leave this PR as is or if i can also add CREATE CATALOG on here?  I see sql-parser has a CreateDatabase statement already that i was thinking i could use.  Or do you think that would get confusing? i.e. CREATE DATABASE would call ctx.register_catalog and then be visible as a catalog.

Ah need to do ballista update still

@alamb do you have preference on whether to leave this PR as is or if i can also add CREATE CATALOG on here?

I suggest we do it in a follow on PR to keep this one smaller.

I see sql-parser has a CreateDatabase statement already that i was thinking i could use. Or do you think that would get confusing? i.e. CREATE DATABASE would call ctx.register_catalog and then be visible as a catalog

seems reasonable
(sorry for the delayed replies -- I am only inline intermittently this week)

@alamb i believe this is ready now


Rlgaddy webpages

Update to the user interface and the friendlist search function

Looks great to me! Awesome job.


Remove 'Entering DMUMPS driver' messages

Remove the message
Entering DMUMPS driver with JOB, N, NZ =  -2           0              0

that SDPA prints at each solve (hence carrying 0 bit of information).

We get an error macOS SDK not installable :/

I don't get it, there is the same error on master and for the latest release but the binaries were still uploaded.
@juan-pablo-vielma Any idea what's going on ?

I think changing BINARYBUILDER_AUTOMATIC_APPLE=false to BINARYBUILDER_AUTOMATIC_APPLE=true in .travis.yml should fix it. No idea how the binaries were generated before without that :-)

It worked :)


chore: add build file to mempool_node to allow usage of starknet_sierra_compile crate

This change is

#1126  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on  Graphite


Task ${relativeFile} slash style

VSCode Version: 1.19
OS Version: Windows 10

Steps to Reproduce:
VSCode 1.18
${relativeFile} is Linux Style like a/b/c
VSCode 1.19
${relativeFile} is Windows Style like a\b\c
So when I run some task in WSL，Windows style slash will wrong。

Reproduces without extensions: Yes

This is a more general issue since WSL needs to be treated as a Linux environment but VS Code thinks is is running under Windows and correctly uses \

@dbaeumer Variable support replace sub string ${relativeFile/a/b/} replace a to b in Sublime Text，I want this feature in VSCode.

Nice idea. Can you please open a separate issue for this.

@bpasero changed the behaviour of ${relativeFile} with this commit:
https://github.com/Microsoft/vscode/commit/4a8327aa4b2e4173e43f9231be94a0278fd352de
The change was good because it fixed the problem that ${relativeFile} was using forward slashes on Windows.
However this broke the WSL use case (which only worked by accident before).
In general, VS Code variables are resolved on the Windows side. So they all should use backward slashes.

fixed via https://github.com/Microsoft/vscode/commit/313a21df3af062a1726e33da78f65145b3876b13
@dbaeumer or @weinand please verify 👍

@bpasero @weinand what will be the path forward. Using slash under Windows can cause problems when used in tasks. So IMI we should use \ and break this. But we should announce this.

@dbaeumer yes, I fully agree: environment variables should always use the correct OS path separators. So for VS Code 1.20 we should announce that ${relativeFile} will be consistent with all the other path variables.

Would be cool to get https://github.com/Microsoft/vscode/issues/40288 for 1.20. Then a user has a nice way of controlling this. @isidorn any concerns ?

My intent was to restore the previous (broken) way it was, not to fix the underlying issue.

Yes, we understand this. @dbaeumer was asking for "the path forward". And I think we have a story for that now.
In general I like #40288. But we'll have to coordinate this with some other requests for variables: #38381, #38327, #38977

Sounds good 👍

verified on all platforms: ${relativeFile} uses forward slashes on all OSes


DSERV-85 QTL Adapter

Adding an adapter for GTex eQTL dataset
Adding a dry run mode for the dev_setup script and adding a parameter to import a custom list of adapters

Usage:
python3 dev_setup --dry-run -a qlt gencode
default: no dry run and importing all adapters

@mingjiecn should review as well


[Discussion] Are we ready for a release?

Hi everyone,
Tomorrow, a documentary will be broadcasted on the French TV and OFF will be mentioned.
In the stable app, there's an annoying bug with Nutritional facts being inaccessible the first time we click on it (fixed by #4902).
How confident are we to release an app with the current dev branch?
(cc @teolemon @monsieurtanuki @M123-dev)
⚠ If so, please stop approving any PR meanwhile ⚠
Here is the changelog:
Features

4068 - autocomplete for brands (#4871) (2554848)
4836 - clickable link to "open new issue" when relevant (#4875) (542c4c2)
4947 - added "download language" to product table (#4951) (e0b3111)
Support for '-' in nutritional values (#4909) (2e22987)
Use the Slivers mechanism with the Gallery view (#4913) (f81ba98)

Bug Fixes

4228 - max lines 2 and tooltip for edit image buttons (#4939) (46271ca)
4627 - no more nutrients wiped out (#4902) (e5757e7)
4663 - use the latest password for background tasks + refactoring (#4869) (28262ca)
4697 - no more redundant "complete category" button (#4937) (bcf9356)
4820 - ChangeNotifierProvider already disposes (#4933) (56eba91)
4900 - backup_scheme.xml type fix (#4901) (3020a4d)
4923 - added a padding for banner (#4927) (b6f97cd)
4925 - consistency for "edit product" app bars (#4931) (c76715d)
4940 - also try the URL in the /dist/ subfolder for SVG (#4942) (de9e6f2)
changing the language of countries when changing the Food App language. (#4920) (ecaba8e)
Don't rely on removeDiacritics to highlight text (#4636) (e904b05)
labeler v5 compat (#4906) (02a9942)
properly refresh food preferences language (#4956) (64481bb)

I'm rather confident in what I coded (3 features, 9 fixes), and the rest looks ok too.
I would single out 4947 - added "download language" to product table (https://github.com/openfoodfacts/smooth-app/issues/4951) (e0b3111) which impacts never used methods about a deprecated hive table. Last time completely removing the related code caused app crashes in some cases. In this case, and @M123-dev was careful too when reviewing, I tested with an app upgrade and a new app from scratch, and it worked OK in both cases.
That said, even if we were 100% sure about the code I cannot see how we could create a new version that would be downloadable tonight.
 And have it tested one week as alpha/beta.
Like:

day 1 of month: start of the frozen zone - no more PR mergers
day 2: create a new version and upload it to the stores
up to day 9: have our alpha/beta testers ... erm... test the app
day 10: if no new bugs, send it to production and end of the frozen zone
that means from day 1 to day 10 no more PR mergers except for new bug fixes

We should beware of the kiss of death. That said, france 5 is not "Plus belle la vie".

Completely agree with @monsieurtanuki , besides that:

We should test #4940

#4820 maybe, has the potential for breaking a whole page, but should be save.

I'm optimistic about both #4940 and #4820.
But that's precisely what we should do during the frozen zone/test phase: focus on fishy PRs - and on all PRs anyway, specifically testing them.

@monsieurtanuki @g123k I'm going to perform an internal release with the latest commit, in case we're not up to date. Ok with you ?

Thanks for your all feedbacks and I totally agree with you @monsieurtanuki about recurring releases.
My question was just if we could have a quick fix for the annoying Nutritional facts error.
The answer is NO, so no release tomorrow.

@teolemon ok for a new release.
@g123k our release process cannot go faster than the time taken by release processes by stores. If stores react fast, so can we.


Feedback request: Founding Documentation: New Committee or Working Group

Hi everyone - in a recent meeting that I attended I shared that I was working with @marthacryan to write some documentation for best practices surrounding the process of starting a new committee or working group. Happy to share we've created a template for a few things. Note that all of these should be considered in a draft state and it still needs to be approved by the Executive Council. Sharing because it felt like a great opportunity to get this group involved early. Note that I'm not a software engineer and I find Google Docs easier to collaborate in (compared to GH). I do envision these documents would be added to the Jupyter Governance documentation. Documents are set with permissions that are open for anyone to comment.
Charter Draft
Voting
General Overview Draft
Goal of Documentation

Logistical: Have guidance written down so that people don’t feel like they’re starting from scratch every time they’re starting a committee
Strategic: A way to encourage people to start new committees and working groups - so that they can focus on the other parts of making a committee.

Audience

Contributors in the Jupyter community: people interested in starting new committees and working groups.

These are great, and should help make starting new bodies much easier in the future. I've read through them and made some notes about a few items we can add to the Docs Working Group, thanks for sharing this :)

Many thanks! I've added the checklist to GH but I still need to figure out a place for the charter draft and the other items. Part of this is talking with the other folks on the Executive Council to figure out the right place for these documents. I am not sure if changes to the Governance model docs require a joint vote of the EC and SSC. That seems like a high bar for requesting changes. Anyway, various things in the works and I wanted to share them all while they're in progress because the timing


Error with conversation.external crash the bot

When calling waitFor or conversation.form after conversation.external the bot simply crash with no errors.
This code will reproduce this error:
require('dotenv').config();
import { Conversation, ConversationFlavor, conversations, createConversation } from "@grammyjs/conversations";
import { Bot, Context, session } from "grammy";

const BOT_TOKEN = process.env.BOT_TOKEN;

export type MyContext = Context & ConversationFlavor;

async function greeting(conversation: Conversation<MyContext>, ctx: MyContext) {
  const response = await conversation.external(() => Promise.resolve('ok'));
  conversation.log(response);
  const codigo = await conversation.form.text();
  conversation.log(codigo);
}

const bot = new Bot<MyContext>(BOT_TOKEN!);

bot.use(session({
  initial: () => ({}),
}));

// Install the conversations plugin.
bot.use(conversations());
bot.use(createConversation(greeting));

// Handle the /start command.
bot.command("start", async (ctx) => await ctx.conversation.enter("greeting"));
bot.catch((err) => {
  console.error(err);
});
// Start the bot.
bot.start();

console.log("Bot running...")

I cannot reproduce this. The above code works correctly for me. However, a different bug was fixed in #40 so now conversation.external crashes less often. Could you try out the new release and see if this is fixed? In that case, please consider closing this issue.

Closing due to inactivity. Feel free to comment or reopen if this is still an issue.

Sorry for the delay.
It's fixed now, I was able to test it and it works now.

Great to hear! Thanks for confirming!


Use chrono::DateTime for secrets

I am not sure if adding another dependency is desired.
Its somewhat weird to return the number of seconds since the unix epoch in anything but as a date.

I am not a fan of depending on chrono for this very small bit; using Duration is fine and people can convert it to a date using whatever library they are using

Ok then ill add the methods as duration

Done.


Only validate ConfigMaps the webhook knows about.

Without moving this block into the if block, any of our webhooks will validate all of the ConfigMaps' _example blocks, which may lead to weird rollout issues if different components ship slightly differing versions (for example net-istio's webhook vs. serving's webhook).

/assign @mattmoor

/lgtm

/retest


chore: Make Muxer stream stats event emit happen in the separate event loop

copilot:all

Current dependencies on/for this PR:

main

PR #3698   👈

This comment was auto-generated by Graphite.


How to begin with this in ubuntu?

Hey There,
Can anyone out there, kindly tell me step by step procedure to begin with ubuntu (18.04). I've followed all the steps, after installing python 2.7. But always it stopped at
waiting for QR......
Then some error.
I've cleared all the docker, by $ sudo docker ps -aq then sudo docker rm -f <>
Then tried again and again... but neither it open Mozilla (I've installed geckodrive) nor chrome (I've installed chromodrive).
I've tried to open Mozilla Testing module using self made python code, it opened, but using this repo, neither it opens, nor it follows the web whatsapp after manual opening. I'm trying from last few days, but at last nothing works. Kindly do help me, for a clean install and full step by step product.
I'll be grateful to you always =D
Thanks in advance.

Did you actually read the QR code with your phone/emulator?
If it says waiting for QR, the browser is open somewhere, probably hidden. Try taking a screenshot with python or just downloading the QR

Dear @Ifdelphino,
Can you kindly guide me what should I do, after this. I've attached the snapshot of the terminal. It doesn't even open firefox. I've tested the geckodrive, it is opening the browser via a test file, so it's working fine.
But with this library, I'm not able to neither open firefox, nor getting any qr code via driver.get_qr() etc.
Kindly guide me, what shall I do further to get the work done.
Regards

Stuck here. Were you able to get past this?


Flaky Test In URLTest.java

com.networknt.registry.URLTest.testURL
This is a flaky test, it can pass mvn test while but when run using the tool NonDex, it fails. NonDex is a tool that will introduce non-determinism in certain java collections.The test shows below:
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.336 sec <<< FAILURE! - in com.networknt.registry.URLTest
testURL(com.networknt.registry.URLTest)  Time elapsed: 0.334 sec  <<< FAILURE!
org.junit.ComparisonFailure: expected:<...value1&key2=true&key[5=10L&key3=10&key4=3.14]&nodeType=service&ve...> but was:<...value1&key2=true&key[3=10&key4=3.14&key5=10L]&nodeType=service&ve...>
        at com.networknt.registry.URLTest.testURL(URLTest.java:102)

com.networknt.registry.URLTest.txt
Steps to reproduce the failure:
Run the following command in light-4j:

First, build the module:
mvn install -pl registry -am -DskipTests
Then run the test using NonDex
mvn -pl registry edu.illinois:nondex-maven-plugin:2.1:nondex -Dtest=com.networknt.registry.URLTest#testURL
The result will be saved under the module folder in .nondex

merged and closed.


Firewall: Cannot add rules with negative CIDR

fw3 supports dynamic prefix forwarding: https://openwrt.org/docs/guide-user/firewall/fw3_configurations/fw3_ipv6_examples#dynamic_prefix_forwarding
However, LuCI doesn't allow one to input the /-64 syntax.

A negative CIDR looks invalid, most probably a typo or a range designation in the wiki.

It was in one of the release notes at some point. It's definitely not invalid.

The number following the slash is the prefix length ... what describes a negative number in this case? Do you have any implementation references?

It's the suffix length.

this clearly explicitly supports negative values: https://github.com/gigibox/fw3/blob/a4d98aea373e04f3fdc3c492c1688ba52ce490a9/utils.c#L771
altho ugh, the lack of comments makes it impossible to follow. >.<

Interesting/confusing short-hand notation ... I've found the relevant commit here: https://git.openwrt.org/?p=project/firewall3.git;a=commit;h=bba31cce0521e014109fc805671d4cff7ee9dbf6

It's iptables that does not support this format.
ip6tables v1.8.7 (legacy): invalid mask `-64' specified

But you can just use ::ffff:ffff:ffff:ffff

but luci is a frontend to fw3, which handles this format.
not only that but editing the raw HTML's hidden fields to force it to send the -64 works fine.


CSIStorageCapacity keptn scheduler log spam

Obviously something is wrong / missing from with my kind cluster but I don't need this many warnings in the keptn-scheduler pods. 😄
W1028 01:40:35.098642       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:40:35.098680       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:41:12.353213       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:41:12.353263       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:42:10.604908       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:42:10.604947       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:42:42.039713       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:42:42.039759       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:43:31.970687       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:43:31.970769       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:44:27.665550       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:44:27.665656       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:45:17.936707       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:45:17.936873       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:46:06.942937       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:46:06.943018       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:47:00.414308       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:47:00.414395       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:47:36.025732       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:47:36.025769       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:48:23.921500       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:48:23.921572       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:49:22.563123       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:49:22.563172       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
W1028 01:50:12.320223       1 reflector.go:324] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource
E1028 01:50:12.320258       1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.24.3/tools/cache/reflector.go:167: Failed to watch *v1.CSIStorageCapacity: failed to list *v1.CSIStorageCapacity: the server could not find the requested resource

PEBCAK. Was on kubernetes < 1.24