Add Presto key_sampling_percent scalar function

Add key_sampling_percent Scalar function.
This function is an SQL function in Presto. Setting inline-sql-functions=true seems to
work in certain cases but not all.
For example, this is required when KEY_BASED_SAMPLING_ENABLED=true in Presto.
Resolves: https://github.com/prestodb/presto/issues/20592
Reference: https://github.com/prestodb/presto/blob/d1ede7cf62fc9f4fdae4cfd459b39f45777954a8/presto-main/src/main/java/com/facebook/presto/operator/scalar/sql/SimpleSamplingPercent.java#L21

@majetideepak @aditi-pandit Please review.

@pdabre12 : Please can you run ExpressionFuzzer for this function and paste results here. https://facebookincubator.github.io/velox/develop/testing/fuzzer.html#how-to-run

Fuzzer output:
I20240131 22:21:44.925518 20087581 FuzzerToolkit.cpp:137] Two vectors match.
I20240131 22:21:44.925530 20087581 ExpressionFuzzerVerifier.cpp:363] ==============================> Done with iteration 18586
I20240131 22:21:44.925557 20087581 ExpressionFuzzerVerifier.cpp:160] ==============================> Top 1 by number of rows processed
I20240131 22:21:44.925563 20087581 ExpressionFuzzerVerifier.cpp:162] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20240131 22:21:44.925570 20087581 ExpressionFuzzerVerifier.cpp:166] key_sampling_percent 18587 100.00% 300770
I20240131 22:21:44.925580 20087581 ExpressionFuzzerVerifier.cpp:172] ==============================> Bottom 1 by number of rows processed
I20240131 22:21:44.925585 20087581 ExpressionFuzzerVerifier.cpp:174] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20240131 22:21:44.925590 20087581 ExpressionFuzzerVerifier.cpp:179] key_sampling_percent 18587 100.00% 300770
I20240131 22:21:44.925597 20087581 ExpressionFuzzerVerifier.cpp:192] ==============================> All stats sorted by number of times the function was chosen
I20240131 22:21:44.925602 20087581 ExpressionFuzzerVerifier.cpp:194] Format: functionName numTimesSelected proportionOfTimesSelected numProcessedRows
I20240131 22:21:44.925607 20087581 ExpressionFuzzerVerifier.cpp:198] key_sampling_percent 18587 100.00% 300770
E20240131 22:21:44.925613 20087581 ExpressionFuzzerVerifier.cpp:369] Total iterations: 18587
E20240131 22:21:44.925618 20087581 ExpressionFuzzerVerifier.cpp:370] Total failed: 0
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

@aditi-pandit  Thanks for the review.
Addressed the comments, PTAL.

@Yuhta, @kagamiori : Please could either of you take a look. Thanks.

@aditi-pandit, good catch on the SQL function. I verified that key_sampling_function works on Prestissimo. We should not need another function.

key_sampling_percent function does not seem to work without adding the extra key_sampling_percent function on the velox side.
Without function added:
presto:tpch> select key_sampling_percent(comment) from orders limit 5;
Query 20240205_033404_00017_tfhbi failed:  Scalar function name not registered: presto.default.key_sampling_percent, called with arguments: (VARCHAR).

With function added:
presto:tpch> select key_sampling_percent(comment) from orders limit 5;
          _col0
-------------------------
  6.182252096053023E-138
   9.325169862508376E291
 3.6936313139242443E-292
   -8.57933126404383E257
 3.3387410329289704E-174
(5 rows)

Also adding the key_sampling_percent function on the Velox side, fixes https://github.com/prestodb/presto/issues/20514

I tested with a constant earlier. This plan was likely optimized. But with a table column, I get the following error
select key_sampling_percent(o_comment) from tpch.sf1.orders limit 5;

Query 20240205_233919_00004_rcbzm, FAILED, 1 node
Splits: 5 total, 0 done (0.00%)
[Latency: client-side: 389ms, server-side: 294ms] [0 rows, 0B] [0 rows/s, 0B/s]

Query 20240205_233919_00004_rcbzm failed:  Scalar function name not registered: presto.default.from_ieee754_64, called with arguments: (VARBINARY).

There seems to be another problem with the registration of from_ieee754_64. I see that we do not have E2E tests as well.
@pdabre12 can you share your Presto core config?
Having another person verify the output will help resolve this. @aditi-pandit, @czentgr, can on of you please share the output from using the key_sampling_percent function in Prestissimo today?

I get the same as Pratik with a slightly different query:
presto:sf1> select key_sampling_percent(c) from (values ('foobar')) t(c);
Query 20240205_040232_00008_nhcb8 failed:  Scalar function name not registered: presto.default.key_sampling_percent, called with arguments: (VARCHAR).

The coordinator has:
VeloxUserError:  Scalar function name not registered: presto.default.key_sampling_percent, called with arguments: (VARCHAR).

So it goes to Prestissimo.
The plan shows the key_sampling_percent:
presto:sf1> explain (type distributed) select key_sampling_percent(c) from (values ('foobar')) t(c);
                                                       Query Plan
------------------------------------------------------------------------------------------------------------------------
 Fragment 0 [SINGLE]
     Output layout: [key_sampling_percent]
     Output partitioning: SINGLE []
     Stage Execution Strategy: UNGROUPED_EXECUTION
     - Output[PlanNodeId 8][_col0] => [key_sampling_percent:double]
             Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 64.00, memory: 0.00, network: 0.00}
             _col0 := key_sampling_percent (1:35)
         - Project[PlanNodeId 4][projectLocality = LOCAL] => [key_sampling_percent:double]
                 Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 64.00, memory: 0.00, network: 0.00}
                 key_sampling_percent := key_sampling_percent(CAST(field AS varchar)) (1:66)
             - LocalExchange[PlanNodeId 178][ROUND_ROBIN] () => [field:varchar(6)]
                     Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 55.00, memory: 0.00, network: 0.00}
                 - Values[PlanNodeId 0] => [field:varchar(6)]
                         Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 0.00, memory: 0.00, network: 0.00}
                         (VARCHAR'foobar')

(1 row)

I have some problems with the TPCH connector - while I can run queries it tells me no node available for TPCH.
presto:sf1> select key_sampling_percent(comment) from orders limit 5;
Query 20240205_040543_00012_nhcb8 failed: No nodes available to run query

Some local setup issue I suppose.

If you set inline-sql-functions=false, we will see Scalar function name not registered: presto.default.key_sampling_percent

I see comment for this flag in getNativeWorkerSystemProperties
"// By default, Presto will expand some functions into its SQL equivalent (e.g. array_duplicates()).
// With Velox, we do not want Presto to replace the function with its SQL equivalent.
// To achieve that, we set inline-sql-functions to false."
Will need to investigate into it.

Yes, was about to make the same comment as Aditi.
When I execute the query it works for me with Prestissimo now.
presto:sf1> set session inline_sql_functions=true;
SET SESSION
presto:sf1> select key_sampling_percent(c) from (values ('foobar')) t(c);
          _col0
-------------------------
 1.0670186722451606E-143
(1 row)
presto:sf1> explain (type distributed) select key_sampling_percent(c) from (values ('foobar')) t(c);
                                                                            Query Plan                  >
-------------------------------------------------------------------------------------------------------->
 Fragment 0 [SINGLE]                                                                                >
     Output layout: [key_sampling_percent]                                                              >
     Output partitioning: SINGLE []                                                                     >
     Stage Execution Strategy: UNGROUPED_EXECUTION                                                      >
     - Output[PlanNodeId 8][_col0] => [key_sampling_percent:double]                                     >
             Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 64.00, memory: 0.00, network: 0>
             _col0 := key_sampling_percent (1:35)                                                       >
         - Project[PlanNodeId 4][projectLocality = LOCAL] => [key_sampling_percent:double]              >
                 Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 64.00, memory: 0.00, networ>
                 key_sampling_percent := ((abs(from_ieee754_64(xxhash64(CAST(CAST(field AS varchar) AS v>
             - LocalExchange[PlanNodeId 180][ROUND_ROBIN] () => [field:varchar(6)]                      >
                     Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 55.00, memory: 0.00, ne>
                 - Values[PlanNodeId 0] => [field:varchar(6)]                                           >
                         Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 0.00, memory: 0.00,>
                         (VARCHAR'foobar')                                                              >
                                                                                >
                                                                                >
(1 row)

The query works for me too on the Prestissimo side, with  inline_sql_functions=true.
However, still getting the Scalar function name not registered: presto.default.key_sampling_percent while trying to run the query in https://github.com/prestodb/presto/issues/20514.
presto:tpch> set session inline_sql_functions=true;
SET SESSION
presto:tpch> set session KEY_BASED_SAMPLING_ENABLED=true;
SET SESSION
presto:tpch> select count(1) from orders join lineitem using(orderkey);

Query 20240206_202015_00021_rxg96, FAILED, 1 node, 11 splits

WARNING: Sampled the following columns/derived columns at 10.0 percent:
	orderkey from HiveTableHandle{schemaName=tpch, tableName=orders, analyzePartitionValues=Optional.empty}
	orderkey_0 from HiveTableHandle{schemaName=tpch, tableName=lineitem, analyzePartitionValues=Optional.empty}

Query 20240206_202015_00021_rxg96, FAILED, 1 node
Splits: 11 total, 0 done (0.00%)
[Latency: client-side: 0:01, server-side: 0:01] [0 rows, 0B] [0 rows/s, 0B/s]

Query 20240206_202015_00021_rxg96 failed:  Scalar function name not registered: presto.default.key_sampling_percent, called with arguments: (VARCHAR).

Query Plan:
- Output[PlanNodeId 13][_col0] => [count:bigint]                                                                                >
         _col0 := count (1:16)                                                                                >
     - Aggregate(FINAL)[PlanNodeId 8] => [count:bigint]                                                                                >
             count := "presto.default.count"((count_12)) (1:16)                                                                                >
         - LocalExchange[PlanNodeId 500][SINGLE] () => [count_12:bigint]                                                                                >
             - RemoteStreamingExchange[PlanNodeId 506][GATHER] => [count_12:bigint]                                                                                >
                 - Aggregate(PARTIAL)[PlanNodeId 504] => [count_12:bigint]                                                                                >
                         count_12 := "presto.default.count"(*) (1:16)                                                                                >
                     - InnerJoin[PlanNodeId 418][("orderkey_0" = "orderkey")] => []                                                                                >
                             Estimates: {source: CostBasedSourceInfo, rows: 47,377 (416.40kB), cpu: 1,948,252.50, memory: 121,500.00, network: 608,917.50}                                                                                >
                             Distribution: PARTITIONED                                                                                >
                         - RemoteStreamingExchange[PlanNodeId 445][REPARTITION] => [orderkey_0:bigint]                                                                                >
                                 Estimates: {source: CostBasedSourceInfo, rows: 54,158 (475.99kB), cpu: 974,835.00, memory: 0.00, network: 487,417.50}                                                                                >
                             - TableScan[PlanNodeId 1][TableHandle {connectorId='hive', connectorHandle='HiveTableHandle{schemaName=tpch, tableName=lineitem, analyzePartitionValues=Optional.empty}', layout='Optional[tpch.lineitem{filter=(key>
                                     Estimates: {source: CostBasedSourceInfo, rows: 54,158 (475.99kB), cpu: 487,417.50, memory: 0.00, network: 0.00}                                                                                >
                                     LAYOUT: tpch.lineitem{filter=(key_sampling_percent(CAST(orderkey AS varchar))) <= (DOUBLE'0.1')}                                                                                >
                                     orderkey_0 := orderkey:bigint:0:REGULAR (1:42)                                                                                >
                         - LocalExchange[PlanNodeId 483][HASH] (orderkey) => [orderkey:bigint]                                                                                >
                                 Estimates: {source: CostBasedSourceInfo, rows: 13,500 (118.65kB), cpu: 364,500.00, memory: 0.00, network: 121,500.00}                                                                                >
                             - RemoteStreamingExchange[PlanNodeId 446][REPARTITION] => [orderkey:bigint]                                                                                >
                                     Estimates: {source: CostBasedSourceInfo, rows: 13,500 (118.65kB), cpu: 243,000.00, memory: 0.00, network: 121,500.00}                                                                                >
                                 - TableScan[PlanNodeId 0][TableHandle {connectorId='hive', connectorHandle='HiveTableHandle{schemaName=tpch, tableName=orders, analyzePartitionValues=Optional.empty}', layout='Optional[tpch.orders{filter=(key>
                                         Estimates: {source: CostBasedSourceInfo, rows: 13,500 (118.65kB), cpu: 121,500.00, memory: 0.00, network: 0.00}                                                                                >
                                         LAYOUT: tpch.orders{filter=(key_sampling_percent(CAST(orderkey AS varchar))) <= (DOUBLE'0.1')}                                                                                >
                                         orderkey := orderkey:bigint:0:REGULAR (1:30)

select count(1) from orders join lineitem using(orderkey);

@pdabre12 can you try setting inline_sql_functions=true in the config.properties instead of the session?
I think we need to land this function irrespective since its a small one and we will not have inconsistencies with and without inline_sql_functions

The point is that Presto Java can execute this function with both inline-sql-functions=true and inline-sql-functions=false

select count(1) from orders join lineitem using(orderkey);

@pdabre12 can you try setting inline-sql-functions=true in the config.properties instead of the session?
I think we need to land this function irrespective since its a small one and we will not have inconsistencies with and without inline_sql_functions

I tried setting inline-sql-functions=true in the config.properties , still facing the same error.

I tried setting inline-sql-functions=true in the config.properties , still facing the same error.

Thanks for verifying!

@pdabre12 can you rebase with the latest main? The branch is 2 weeks old. Thanks!

@majetideepak Thanks for the review, rebased with the latest main.

@pdabre12 I asked a question in the Presto Slack about this to confirm we did not miss anything
https://prestodb.slack.com/archives/CLYMEEJ6S/p1709257204162099

@pdabre12 I asked a question in the Presto Slack about this to confirm we did not miss anything https://prestodb.slack.com/archives/CLYMEEJ6S/p1709257204162099

Thank you.

Closing this as it's no longer needed.

@pdabre12 @majetideepak I am curious why this was closed - would be great if you can add that reasoning here.

@kgpai Since key_sampling_percent is a SQL function it should not need an implementation in the worker eval (in this case Prestissimo) when inline_sql_functions=true, as a result adding the key_sampling_percent scalar function was not needed.
However, running key_sampling_percent in Prestissimo exposed a bug which is described here : https://github.com/prestodb/presto/issues/22085.

@pdabre12  Thanks !

@pdabre12 The worker implementation is required to make the query performant. If the function is missing and inline is set to true in a C++ cluster, the fallback to coordinator implementation makes the query significantly slow. We should add the implemenation natively so that worker can run it instead of relying on coordinator fallback.

@amitkdutta Is it the case that the inline function executes on the coordinator? I am not an expert here but I thought the coordinator would expand this function to (abs(from_ieee754_64(xxhash64(cast(input as varbinary)))) % 100) / 100. which then executes on the C++ worker. If this is not the case, then we should add this function in C++.
https://github.com/prestodb/presto/blob/master/presto-main/src/main/java/com/facebook/presto/operator/scalar/sql/SimpleSamplingPercent.java

@amitkdutta : Even if we have a native execution it would mean we inline the same logic into a single scalar function.
So evaluating (abs(from_ieee754_64(xxhash64(cast(input as varbinary)))) % 100) / 100 vs key_sampling_percent(input) in the Expression framework. Understand that evaluating the tree is slower than just the single function. But are you suggesting it is so much slower ? Do you have a microbenchmark showing the difference ?


feat: punycode support

Try out this version of the Hiro Wallet - download extension builds.

Users who register a punycode BNS address will now see its Unicode equivalent in the address's label,

Closes https://github.com/hirosystems/stacks-wallet-web/issues/2724

Reading the segmenter docs, noticed that it says it doesn't support FF

Good catch @kyranjamie, I've refactored the use of Segmenter to better support FF. While I was there, I cleaned up nearby code a bit, let me know what you think

Good catch @kyranjamie, I've refactored the use of Segmenter to better support FF. While I was there, I cleaned up nearby code a bit, let me know what you think

What's the rationale for removing the suspense in AccountAvatar? Was it not used, and is the behaviour the same as before?
Re the changes to AccountAvatarProps, where you've replaced the two props for a single AccountWithAddress object.  Only the two props are used, yet now we expect the whole object. What if we want to use it somewhere where we only have those two props? We'd need to import this object, just to satisfy the types, even though it's not all used. Imo, it's better to be explicit and state only the props that are needed. We never know what might change later where—in some instances—we won't have all those account details.
This is similar to this comment here (a bit of a rant by yours truly)
https://github.com/hirosystems/stacks-wallet-web/blob/5f5083b7656976d0b06d23cc02c97cdf25650211/src/app/store/wallet/wallet.ts#L20-L39
There are functions in wallet-sdk that require the whole Account object (that includes the private key). We added ledger, and can't use many functions (even if they don't use the private key), because they're typed to require a whole object even when only a few keys are used.
I made a PR back in February to be specific with these props, https://github.com/hirosystems/stacks-wallet-web/pull/2229, this these changes undo.
You could use Pick<AccountWithAddress, 'name' | 'stxPublicKey> to select only a few props, though this isn't much of an improvement over having two props.

I tested it, and it worked. It was great!

What's the rationale for removing the suspense in AccountAvatar? Was it not used, and is the behaviour the same as before?

It wasn't really adding anything useful as far as I could see, and now users can click on the avatar without having to wait for data to load if they want to switch accounts.
Regarding the props, makes sense to pass less data when it's not used. I'll refactor the props so as to not pass the entire account object.


Add date of book issued

Please check the changes
Here is the link:
https://ankitapal12.github.io/Aec-Library-Website/

Cool, Merged!
Do Connect :
LinkedIn: https://www.linkedin.com/in/sauravmukherjee44
GitHub: https://github.com/SauravMukherjee44


Handle nicely undefined JS type

Describe the problem you discovered
when converting Dart objects to JS ones, Dart null properties are mapped to JS null.
This is problematic because Wagmi JS always expects undefined values instead of null.
To counter that behavior, we have to write gross Dart code.
Describe the solution you'd like
Setup a small Typescript conversion on every incoming Parameter object.
That conversion would replace null values by undefined.
Epic
No response

@Chralu I think lets use the https://www.npmjs.com/package/reflect-metadata lib if it solves our purpose.  For now we are at a stage where an additional 100-200KB's of added build size is negligible - In any case we will have to re-circle back to the build size issue once our lib is more matured

I implemented the solution for the call function for now :  https://github.com/archethic-foundation/wagmi_flutter_web/pull/38
@kaumudpa any thoughts ?

@Chralu LGTM to me.


Add a way to theme UX

Allow admin to change colors of the UX.

As an admin I have a location to set theme options
As an admin I can set the site colors
As an admin I can set the brand logo

As an admin I have a location to manage image assets
As an admin I can upload new images
As an admin I can remove images not being used in the application

TODO:

formly.config, reconfigure complex field type multipleColorsField to handle nested schema
color-picker directive, apply field__input class without borking styling, maybe need to roll custom directive
api, shove schema from theme.factory.js into table, be able to get and set default/new schema
api, plus the rest of the work described in #1079
api, support rendering of sass mixins


refactor(sink): refine log reader trait epoch and use static dispatch for SinkImpl

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In this PR, we modify the log store reader trait. Before this PR, we return the initial epoch in the init method, and include the next epoch when we emit the barrier. However, this means that we will have to prefetch the next epoch in the kv log store reader, which is unnecessary and introduce extra implementation logic. Therefore, in this PR, we change to include the current epoch along with the stream chunk and barrier we emit.
Besides, we change to use static dispatch for SinkImpl and avoid implementing Sink for the SinkImpl.
Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[x] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[x] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

Do we need to add additional interface for LogReader to enable log replaying for recovery?

The log reader will start reading from the previously truncated point, which at the beginning is replaying the log. So I think we don't need extra method to enable log replaying. But we do need to redesign what the log reader should do in case of recovery.


Host build artifacts in new repository

Is your feature request related to a problem? Please describe.
Artifacts of build are hosted in the Rancher Registry. We do not have access to it so we would need to move Docker images and other artifacts to a different registry.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
@alborotogarcia proposed a solution

I guess that we could start with an org container registry for free on Github Packages at ghcr.io

Hosting artifacts under my Docker Hub mazzy


Update 'pipeline components' topic in the 'user guide'

This PR updates the https://elyra.readthedocs.io/en/latest/user_guide/pipeline-components.html topic based on the changes delivered by https://github.com/elyra-ai/elyra/pull/2241

introduce component catalogs and component catalog connectors
link to the component catalog marketplace
link to the BYO component catalog tutorial in the examples repository
update the custom component management reference
add reference for built-in component connectors

What changes were proposed in this pull request?
See above.
Some of the HREFs to the examples repository will be broken until https://github.com/elyra-ai/examples/pull/78 was merged.

How was this pull request tested?
Reviewed the output of make docs

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

The documentation updates will be delivered in https://github.com/elyra-ai/elyra/pull/2286


Set branches and tags to main/latest

Set nephio docker images to use "latest"
Set pkg revs to "main"
Remove "creationTimestamp: null" from KRM

/approve
/lgtm


feat: adding home page button on Singup and Signin pages

🛠 Fixes Issue

Closes #261
➕ Changes Introduced

adding defaang home page button in singup page
adding defaang home page button in singin page

📄 Note To Reviewers

📷 Screenshots
Beofre:

After:

I don't think it looks quite right. Maybe it's the position of that logo. The other thing is, people should know how to use the back button. So I'm not sure if we need this button in the first place. If it looks good, it might make sense to add it but if not, it's probably not necessary.

Yes YK, I was waiting for to finilizing logo, we can try that out, else we will close this pull request.


Add benchmarking of test suite

See #680.
Currently uses iai-callgrind on the integration test cases, though we could add criterion-based benchmarks or dedicated benchmarks as well.
Due to limitations in iai-callgrind, running the benchmarks requires running cargo run --bin prepare-benches first to generate the fixture file – see iai-callgrind/iai-callgrind#207 for more details. Otherwise, the benchmarking code Works™, though it takes a good part of an hour to run through the whole test suite.

Thanks for your work on this!
To get a better idea of where this is going, it would be great if you could write down your thoughts on the larger benchmarking strategy you envision:

How do we detect regressions? Should benchmarks run automatically regularly somehow?
How should local benchmarks work? If it takes one hour, that's gonna slow down local iteration to the point that I personally wouldn't ever run it on the full suite. Maybe that's ok and one should just run on a subset. Though that raises the question which subset.
Do we also want to benchmark watch compile down the road? Wouldn't be a blocker, but just wondering whether that's future compatible with the current approach.

Also, I feel like many of the tests aren't really great as benchmarks, so it's perhaps a bit wasteful to run them through it all the time. On the other hand, larger documents which are not part of the test suite at all would be interesting benchmarks targets.

* How do we detect regressions? Should benchmarks run automatically regularly somehow?

We could run the benchmark suite in CI or through something like Bencher. The problem is that the IDs for the benchmarks are something like my_id_####, so adding another case to the test suite would throw off all of the IDs for the cases after the new one.

* How should local benchmarks work? If it takes one hour, that's gonna slow down local iteration to the point that I personally wouldn't ever run it on the full suite. Maybe that's ok and one should just run on a subset. Though that raises the question which subset.

It is possible to run prepare-benches with command-line arguments to filter cases (using the same syntax as the test harness), but the benchmark IDs won’t be stable.

* Do we also want to benchmark watch compile down the road? Wouldn't be a blocker, but just wondering whether that's future compatible with the current approach.

If we wanted to, then we could cover that in a separate file under benches/.

Also, I feel like many of the tests aren't really great as benchmarks, so it's perhaps a bit wasteful to run them through it all the time. On the other hand, larger documents which are not part of the test suite at all would be interesting benchmarks targets.

I agree. Maybe we should decouple the test suite from the benchmark suite, especially given the aforementioned problems. This would make most of this PR obsolete, but it could still be useful to libbify typst-tests (or perhaps move some of its functionality into typst-kit).


Entering Diagnostic Mode

Maybe you know why. Somehow I cannot enter diagnostic mode:
More in this issue:
https://github.com/seemoo-lab/internalblue/issues/27#issuecomment-635279148
Thanks,

Hi bro,
I think I have the almost same issue as yours.
In addition, I even cannot 'up' my CYW920819EVB-02....
When I run hciconfig, is shown on the list. But the status is 'DOWN'.
Then I run 'hciconfig hci1 up' (hci1 is my dev board). It shows timeout.
Do you have any idea?
Many thanks

@marcinguy
I've pushed to the master branch the modification to the linux-4.14.111 kernel that we developed to parse the H4 diagnostic commands. You can try to build such kernel and test the attack.


username

Sorry to ask but i cant find the right answer.
I would like to know if its the e-mail or username or the username in spotify's account (like this 6vnmkn6r8i2ulo4wpy3bmgvhm).
Do we have to uncomment line or not?
Thanks a lot

Username it is. Uncomment line.

@D3laz Can confirm that. You could close this issue if that resolved your question.


myApp.onPageInit after MainView.router.back()

Hello Framework team,
We call a form page from page1 and fill the form from Json.
After we have submitted the form we go back with "MainView.router.back();
When we do another call to the form page the form data is showing the old form data not the new json data.
var weightEditItemCallback = myApp.onPageInit('7weightEdit', function (page) {
	myApp.formFromJSON('#my-form', formData);
});

then we do a:
MainView.router.back();

And right after this recall the form page with the same function:
var weightEditItemCallback = myApp.onPageInit('7weightEdit', function (page) {
	myApp.formFromJSON('#my-form', formData);
});

But the old (pre submitted)  data is showen in the form.
Please advise how to fill the form with new data.
Kind regards,
Mario

Sorry. My mistake in code order ;-(


Fix BlockChildrenEndpoint not exposed via Client interface

Block children endpoint was not accessible via client interface so unusable despite seemingly being implemented otherwise

It's already available under notion.blocks.children, just like the JS SDK. I would likely merge a PR that improves the docs for this.


remove browser-based fetching code, should be done by front-end projects

maybe also remove Node.js based remote fetching code?? This is really what a wrapper library should do..!?

Removed Browser-based fetching code, left in Node.js-based remote fetching - wrote test cases to secure behavior.


Model for CAPTCHAs in ONNX format

Hi,
I have exported your model to solve the CAPTCHAs to the ONNX format. This has the advantage that you get rid of TensorFlow as a dependency (~500 MB) and can use onnxruntime (~5 MB) for inference instead – would make the whole project way more lightweight. There are also significantly fewer problems updating onnxruntime than TensorFlow without breaking the model.
And I could also fix https://github.com/bundesAPI/deutschland/issues/8, if you're interested.

So, if this project is still actively maintained and you're interested in adapting my suggestions, I will prepare a PR for this :blush:

Awesome, please create a PR!

@LilithWittmann See https://github.com/bundesAPI/deutschland/pull/56 :)


i18n(ko-KR): update cli-reference.mdx

Description (required)

update cli-reference.mdx
#9237

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
reference/cli-reference.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Avoid use of JRE HTTPURLConnection

We lose all client information and metrics.
Specific example right now UniversePackageCache downloading the zip.

Obsolete, and right now leveraged for it's ability to easily connect through http(s) proxies.


Uncaught AttributeError in sendchat.py line 30

Aider version: 0.56.0
Python version: 3.10.10
Platform: Linux-5.15.0-1070-aws-x86_64-with-glibc2.31
Python implementation: CPython
Virtual environment: No
OS: Linux 5.15.0-1070-aws (64bit)
Git version: git version 2.42.0
An uncaught exception occurred:
Traceback (most recent call last):
  File "base_coder.py", line 1124, in send_message
    continue
  File "base_coder.py", line 1408, in send
    self.keyboard_interrupt()
  File "base_coder.py", line 1490, in show_send_output_stream
    pass
aider.coders.base_coder.FinishReasonLength

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "aider", line 8, in <module>
    sys.exit(main())
  File "main.py", line 698, in main
    return 1
  File "base_coder.py", line 735, in run
    return self.io.get_input(
  File "base_coder.py", line 778, in run_one
    def check_for_urls(self, inp):
  File "base_coder.py", line 1126, in send_message
    interrupted = True
  File "sendchat.py", line 30, in retry_exceptions
    litellm.llms.anthropic.chat.AnthropicError,
AttributeError: module 'litellm.llms.anthropic' has no attribute 'AnthropicError'

Thank you for filing this issue.
The fix is in the latest version (0.57.1), please update aider with
aider --upgrade

Thanks for trying aider and filing this issue.
This looks like a duplicate of #1278. Please see the comments there for more information, and feel free to continue the discussion within that issue.
I'm going to close this issue for now. But please let me know if you think this is actually a distinct issue and I will reopen this issue.


Golang: Somethings todo in the near future

Currently the golang sdk has submitted the first beta version(#160 ), there are still some things todo
#166 GenMessageId
#167 onVerifyMessageCommand
#168 Supports the ability to upload span to the user's server
#169 PushConsumer mode
#170 PrintThreadStackTrace
#171 Grpc connection failed

https://github.com/apache/rocketmq-clients/issues/179 Make each 'Client' have an independent 'ClientManager'
https://github.com/apache/rocketmq-clients/issues/180 Make sure 'syncsettings()' succeeds before the client startup
https://github.com/apache/rocketmq-clients/issues/181 Print requestId to log
https://github.com/apache/rocketmq-clients/issues/182 Try to recover the When the observer is release

@guyinyou which one of these issues is most important to work on in your opinion?

Is PushConsumer implemented? @guyinyou


Tag resources with their type

For example, image, movie, text, etc.

Perhaps simply adding the mime type would be sufficient here?


docs(cli): new command debug

Description
The new cli command kong debug will be released since <IP_ADDRESS>.

Testing instructions
Preview link:  https://github.com/Kong/docs.konghq.com/blob/cli-kong-debug/app/_src/gateway/reference/cli.md#kong-debug
Checklist

[x] Review label added
[ ] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

cloded, will re-pull this request to 3.5


In latest version (2.2.1), TKState doesn't have the userInfo property

v2.2.1 was released here https://github.com/blakewatters/TransitionKit/commit/8a07aec66bdfd60341276d075ab2880ff96e17c7
and the PR containing the change on TKState merged here https://github.com/blakewatters/TransitionKit/commit/4c4b69ff60c71b3bbbd0c7ac9b4ae9fee6ede096
Are you planning on releasing v2.2.2 with the latest changes added?
Thanks.

PR created here -> https://github.com/blakewatters/TransitionKit/pull/33


How to properly PHYSICALLY connect a RaSCSI Reloaded board to a Pi to a Macintosh II?

Hi, first time poster and PiSCSI user here!

Which version of Pi are you using: Pi Zero W v1.1
Which github revision of software: PiSCSI 22.12.1
Which board version: RaSCSI Reloaded Zero v1.0 FULLSPEC
Which computer is the PiSCSI connected to: Macintosh II (but not yet)

I bought 2 new, pre-assembled RaSCSI Reloaded boards from a seller on eBay and he did not include ANY documentation or install instructions.  I found this GitHub and followed the compile instructions and successfully installed PiSCSI on the Pi Zero W and everything SEEMINGLY works.  I can connect to the PiSCSI Control Page in my web browser and upload, expand and attach devices to the virtual SCSI chain.  All the software side of it, I got it working without any issue.
What bothers me is I don't understand how to properly attach the RaSCSI Reloaded to the Pi, and then the assembly to the Macintosh II to actually make it work.  I had a couple basic questions:
A) Do I have to connect an USB power lead to the RaSCSI Reloaded board? (see Ref-1)
B) Do I have to connect an USB power lead to the Pi Zero W? (see Ref-2)
C) Does the SCSI port on the RaSCSI need to be plugged in the Mac for the Pi to turn on? (see Ref-3)
D) What is the proper orientation of the GPIO hat? (see Ref-4 and Ref-5) Note: According to the GND silk on the RaSCSI, it should be as shown on Ref-4, please correct me if I'm mistaken)
E) Are both jumper pads supposed to be soldered on the back of the RaSCSI? (see Ref-6)

When I power on the Pi WITHOUT the RaSCSI plugged in at all, everything works, the Pi boots up and the PiSCSI Control Page shows up in my web browser after a minute.
When I power on only the Pi WITH the RaSCSI plugged in the Pi, then the Pi does not turn on, no LED at all on any of the two boards.
When I power on only the RaSCSI  WITH Pi plugged in, then the 5V LED is solid on the RaSCSI but the Pi does not turn on.
When I power both boards, the 5V LED is solid on the RaSCSI but the Pi does not turn on and it makes a high pitch buzzing sound.

Thank you so much to anyone who can help me figure out how to properly connect this device.  I don't understand how there seemingly is no connection diagram anywhere for this device.  I think this would really help beginners like me at least connect the PiSCSI device properly and get started.

A) Do I have to connect an USB power lead to the RaSCSI Reloaded board? (see Ref-1)

You can connect the power to EITHER the PiSCSI (RaSCSI Reloaded)  OR the Raspberry Pi Zero. The port on the PiSCSI is intended to just be for convenience. When you assemble the PiSCSI Zero with the Pi on top, the SCSI connector will block the power connector.

B) Do I have to connect an USB power lead to the Pi Zero W? (see Ref-2)

Either port works. But NOT BOTH

C) Does the SCSI port on the RaSCSI need to be plugged in the Mac for the Pi to turn on? (see Ref-3)

No. The PiSCSI should function stand-alone when power is applied

D) What is the proper orientation of the GPIO hat? (see Ref-4 and Ref-5) Note: According to the GND silk on the RaSCSI, it should be as shown on Ref-4, please correct me if I'm mistaken)

The PiSCSI/RaSCSI you received is in the "Alternate" configuration on this page: https://github.com/PiSCSI/piscsi/wiki/PiSCSI-Zero-Assembly

E) Are both jumper pads supposed to be soldered on the back of the RaSCSI? (see Ref-6)

It depends on how you're using your PiSCSI. If you're using the PiSCSI Zero, 99.9% of the time you want the term enb pads to be bridged (enabling termination).  Your picture # 6 matches having termination enabled.
The general goal is that the last device on each end of the scsi bus should be terminated. With the PiSCSI Zero, there is only one connector, so it has to be at the end of the chain.
Page 49 of this doc has a little more information: https://vintageapple.org/macmanuals/pdf/Power_Macintosh_Users_Guide_1995.pdf

With the jumper bridged, its enables termination. With the jumpers cut (disconnected), termination is disabled
I hope this helps!!

I literally just discovered one very, very important detail that I could not find anywhere except by taking a much more attentive look to the seller's pictures: It turns out that the GPIO header has to be soldered TO THE BACK of the Pi, not to the front (standard).  This sounds like a very basic thing to consider, but I did not pay attention to the pictures enough and just assumed that the GPIO header was standard when it's in fact backwards.

You are correct!

Since this issue seems to be incorrectly assembled hardware, let us close it for now.


in background mode not receiving messages how to solve it using swift 3

in background mode not receiving messages how to solve it using swift 5？


Ensure the robot state is up-to-date before Servoing

Description
Previously we didn't wait to get a current robot state before servoing began. That caused the initial joint angles to be all-zero, which caused a small jump at the beginning of motion. This is a fix.
Test with:
ros2 launch moveit_servo demo_ros_api.launch.py
ros2 run moveit_servo servo_keyboard_input

One thing to watch out for, from my own experience, is what happens if you pause/stop servo, move the robot through some other free-space motion planner, and then resume servo. (Maybe @pac48 and @sjahr can test with MoveIt Pro and double check?)

I had to add one line to fix this. Good catch. Here's a video of several cycles of Servo -> pause -> joint command -> unpause -> Servo again
servo_pausing.webm


Using metamorph in the head

Is it possible to use metamorph for head elements? I'm trying to use this for the <title> tag.

@mcculloughsean I'm not sure. Personally, it seems like it might just be better to set the page title with JS.

That was a basic use case. It would be nice to also swap out large chunks of meta data, like Facebook OG stuff and SEO related meta tags.

I guess I can see how that would be useful. Handlebars wasn't designed for that case but it seems like it would be nice if that works. I don't think that's a high priority though.

The whole thing fails when you call createContextualFragment for elements in the head. The browser errors and returns  NOT_SUPPORTED_ERR: DOM Exception 9. I'd be happy to work on a solution, but would need some guidance about some strategies to get around this error.


license = none in cache when ruby gem doesn't include License files but has license in gemspec

steps to reproduce

create all below files under dir x

Gemfile:
# frozen_string_literal:true
source "https://rubygems.org"
gem 'aws-sdk-core', '3.39.0'
gem 'licensed', :group => 'development'

Gemfile.lock:
GEM
  remote: https://rubygems.org/
  specs:
    addressable (2.5.2)
      public_suffix (>= 2.0.2, < 4.0)
    aws-eventstream (1.0.1)
    aws-partitions (1.142.0)
    aws-sdk-core (3.39.0)
      aws-eventstream (~> 1.0)
      aws-partitions (~> 1.0)
      aws-sigv4 (~> 1.0)
      jmespath (~> 1.0)
    aws-sigv4 (1.0.3)
    dotenv (2.7.1)
    faraday (0.15.4)
      multipart-post (>= 1.2, < 3)
    jmespath (1.4.0)
    licensed (2.0.1)
      bundler (>= 1.10)
      licensee (~> 9.10)
      pathname-common_prefix (~> 0.0.1)
      thor (~> 0.19)
      tomlrb (~> 1.2)
    licensee (9.11.0)
      dotenv (~> 2.0)
      octokit (~> 4.8.0)
      rugged (~> 0.24)
      thor (~> 0.19)
    multipart-post (2.0.0)
    octokit (4.8.0)
      sawyer (~> 0.8.0, >= 0.5.3)
    pathname-common_prefix (0.0.1)
    public_suffix (3.0.3)
    rugged (0.28.0)
    sawyer (0.8.1)
      addressable (>= 2.3.5, < 2.6)
      faraday (~> 0.8, < 1.0)
    thor (0.20.3)
    tomlrb (1.2.8)

PLATFORMS
  ruby

DEPENDENCIES
  aws-sdk-core (= 3.39.0)
  licensed

BUNDLED WITH
   2.0.1

licensed.yaml:
sources:
  bundler: true

navigate to directory x and run licensed cache -c licensed.yaml

Issue:
.licenses/bundler/aws-sdk-*.dep.yml are created with license set to none. ex:
---
name: aws-sdk-core
version: 3.46.1
type: bundler
summary: AWS SDK for Ruby - Core
homepage: http://github.com/aws/aws-sdk-ruby
license: none
licenses: []
notices: []

if one does gem specification aws-sdk-core you'd get yml containing licenses (since it is part of gemspec).  i.e.
...
licenses:
- Apache-2.0
...

would it be advisable to change licensed to fallback to using gemspec to:

retrieve the license from the gemspec metadata
try to find the license text using the gem homepage . ex: http://github.com/aws/aws-sdk-ruby

or is this something that needs to be reported to licensee project to properly handle this case ?

/cc @benbalter @mlinksva do you have an opinion here?
IIRC licensee handles pulling data from project files like *.gemspec, however I'm not sure how to tell licensee to look at both the gem's expanded location on disk as well as the gemspec file when they are in two different locations.  💭 ?

It seems the aws-* gems get installed (e.g., in ~/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems) with neither a LICENSE file nor a .gemspec file. I haven't looked into why this is the case, but the result is that licesne[ed] have nothing to work with locally. Compare with jmespath, which is also installed given the example files above, and licensed records the license found in its LICENSE.txt.

My understanding of RubyGems is obviously tenuous and I don't read closely...noting gem specification aws-sdk-core does find what ought to be in the gemspec file, I see that gemspec files for every installed gem are in (for my local case) ~/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/specifications. I guess that's what you were getting at @jonabc. I'm not sure either. I guess that it could make sense to look there as a fallback in licensed rather than licensee.

Ok, so to build on that.  If this is being handled by licensed, I think the best method to do so would be a Bundler::Dependency subclass that overrides Project#package_manager_file and returns data for the gemspec file if the base implementation doesn't find a file and the spec file exists in the gem specifications directory.


Investigate if you should get rid of streaming the text content

Now we get the text content only on page creation, I'm not sure that it sill makes sense to keep this stuff.
Likely it'll reduce the code complexity and I wonder (I've no idea/opinion for the moment) if it could improve performance.

But why, since it will in all likelihood reduce overall performance and responsiveness!
Please keep in mind that streaming allows the textLayer to be parsed (on the worker-thread) and laid-out/rendered (on the main-thread) in chunks, rather than all at once[1]. That means that we're still able to parse/render other things, e.g. the next page, in "parallel" with any textLayer parsing/rendering.

[1] This was exactly why streaming was introduced in the first place.

To summarize what this proposal would do:

It would layout/render the entire textLayer all at once, which could easily end up causing jank and/or noticeable delays if there's a very large number of textLayer-elements on the page.
It would lose the ability to abort the worker-thread parsing, which ReadableStreams gives us essentially "for free" here.

Sorry if I'm sounding a bit grumpy here, but I really cannot see any way that I'd approve a patch that removes streaming of textContent.

I've no patch and I've no plan to write one, I'm just wondering.
And a good argument (like the one about aborting a page rendering)  could lead me to "Don't think about that it's stupid".


[py2py3] Python3 Rucio client fails with NameError: 'imp'

Impact of the bug
Python3 env and anything depending on Rucio client
Describe the bug
This issue is a follow up of this one: https://github.com/dmwm/WMCore/issues/10513. Once we have fixed the lack of exceptions module in python3 we have faced another issue related to the python3 version of the Rucio Client [1]
[1]
[dmwm@19ed0d6b7f55 WMCore]$ nosetests test/python/WMCore_t/WMSpec_t/Steps_t/Executors_t/LogArch_t.py
EEEEEEEE
======================================================================
ERROR: testExecutorDoesntDetonate (WMCore_t.WMSpec_t.Steps_t.Executors_t.LogArch_t.LogArchiveTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/dmwm/wmcore_unittest/WMCore/test/python/WMCore_t/WMSpec_t/Steps_t/Executors_t/LogArch_t.py", line 119, in setUp
    taskMaker.processWorkload()
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/WMSpec/Makers/TaskMaker.py", line 127, in processWorkload
    sandboxCreator.makeSandbox(self.workdir, self.workload)
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/WMRuntime/SandboxCreator.py", line 108, in makeSandbox
    fetcherInstances = list(map(getFetcher, fetcherNames))
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/WMSpec/Steps/StepFactory.py", line 196, in getFetcher
    return _FetcherFactory.loadObject(fetcherName)
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/WMFactory.py", line 58, in loadObject
    module = __import__(module, globals(), locals(), [classname])
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/WMSpec/Steps/Fetchers/PileupFetcher.py", line 18, in <module>
    from WMCore.Services.Rucio.Rucio import Rucio
  File "/home/dmwm/wmcore_unittest/WMCore/src/python/WMCore/Services/Rucio/Rucio.py", line 17, in <module>
    from rucio.client import Client
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/client/__init__.py", line 20, in <module>
    from .client import Client  # noqa: F401
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/client/client.py", line 30, in <module>
    from rucio.client.accountclient import AccountClient
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/client/accountclient.py", line 39, in <module>
    from rucio.client.baseclient import BaseClient
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/client/baseclient.py", line 66, in <module>
    from rucio.common.utils import build_url, get_tmp_dir, my_key_generator, parse_response, ssh_sign, setup_logger
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/common/utils.py", line 107, in <module>
    imp.find_module(extra_module)
NameError: name 'imp' is not defined

How to reproduce it
Run the unit test in question unther the python3 environment inside the python3 unit tests docker container for WMCore.
Expected behavior
To have that unit test running with no Errors.
Additional context and error message
Add any other context about the problem here, like error message and/or traceback. You might want to use triple back ticks to properly format it.

It seems this time the error is not buried inside the WMCore code [1], but more related to either the environment or the Rucio py3 client itself.
FYI @amaltaro
[1]
[dmwm@15167945c033 WMCore]$ rucio
Traceback (most recent call last):
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/bin/rucio", line 65, in <module>
    from rucio.client import Client
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/client/__init__.py", line 20, in <module>
    from .client import Client  # noqa: F401
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/client/client.py", line 30, in <module>
    from rucio.client.accountclient import AccountClient
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/client/accountclient.py", line 39, in <module>
    from rucio.client.baseclient import BaseClient
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/client/baseclient.py", line 66, in <module>
    from rucio.common.utils import build_url, get_tmp_dir, my_key_generator, parse_response, ssh_sign, setup_logger
  File "/home/dmwm/unittestdeploy/wmagent/1.4.9.pre3/sw/slc7_amd64_gcc630/external/py3-rucio-clients/1.24.2.post1-comp/lib/python3.8/site-packages/rucio/common/utils.py", line 107, in <module>
    imp.find_module(extra_module)
NameError: name 'imp' is not defined

What's strange is that according to Google, imp is a standard Python library. It's been deprecated since 3.4, but isn't supposed to be removed until 3.12 as I understand it.

TL;DR
rucio version v1.25.5 seems to fix our problem
extended version
In order to close #9974, I had to have a look at imp and importlib. In WMCore/Configuration.py we are successfully using imp in both py2 and py3 env.
So this feels like a problem with rucio/common/utils.py itself. I had a peek at their code, at the beginning of the client.py they select the importing library with
try:
    import importlib
    importlib.util.find_spec('')
except AttributeError:
    import imp

Since in python3 we have a fully working importlib, it does import imp. Then later, they do
for extra_module in EXTRA_MODULES:
    if 'imp' in sys.modules:
        try:
            imp.find_module(extra_module)
            EXTRA_MODULES[extra_module] = True
        except ImportError:
            EXTRA_MODULES[extra_module] = False

since we provide imp with our py3 env, they try to use imp without having it imported before.
So, if we apply this change
- try:
-    import importlib
-    importlib.util.find_spec('')
-except AttributeError:
-    import imp
+import imp

to both rucio/common/utils.py and rucio/client/baseclient.py, then we can successfully import the rucio client
[dmwm@b36d67c2cbbc ~]$ python3
Python 3.8.2 (default, Jan 22 2021, 17:57:37)
[GCC 6.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from rucio.client import Client
>>>

We are lucky: it feels like that this PR already solved our problem https://github.com/rucio/rucio/pull/4373/files

Hi @amaltaro
Here is the cmsdist PR that is supposed to solve the issue:
https://github.com/cms-sw/cmsdist/pull/6959
How about the docker image for the unit tests? Should we wait until it is rebuild and tested before we close this issue?

Thanks for providing this PR, Todor. I think it's best to test it first though, it isn't clear to me whether that actually fixes the problem (and that catch on AttributeError doesn't look right to me). I will get it tested today and update this PR.

Thank @amaltaro ! Totally agree with you.

It turns out I cannot reproduce this error with a wmagentpy3 deployment, only in the docker image (which also contains wmcorepy3-devtools). I suggest we test it in the docker image once that rucio-clients spec has been updated, otherwise it would be way too much work now.
Nonetheless, I tried to update that package in the docker image and - unless I made some mistake - the rucio-clients==1.25.5 indeed seems to resolve that problem. I created this basic documentation for pip installation within the python3 container:
https://github.com/dmwm/WMCore/wiki/Docker-and-WMCore#install-python3-packages-via-pip
@todor-ivanov I'm going to merge your cmsdist PR, then later today we create new RPMs and docker image and we can run a final test to make sure things are working properly. So I suggest we keep it opened for a little longer.
Meanwhile, can you please create another PR updating our list of required python3 packages
https://github.com/dmwm/WMCore/blob/master/requirements_py3.txt#L15
?

And the rucio-clients update fixed this issue. The LogArch_t above still fails, but with a different error now. However, things work fine when testing the Rucio_t module itself:
[dmwm@c208bd73a58f WMCore]$ nosetests test/python/WMCore_t/Services_t/Rucio_t/Rucio_t.py:RucioTest.testWhoAmI
.
----------------------------------------------------------------------
Ran 1 test in 1.678s

OK

This issue can now be closed via:
https://github.com/dmwm/WMCore/pull/10567
and
cms-sw/cmsdist#6959
Thank you very much, Todor.


Fixes #106 Vuln deps fixed and confirm able to send emails

As referred to in Issue #106 , this package has a number of vulnerable dependencies. The PR fixes these by updating the deps in the package.json file.
I patched them using Snyk & included it as a dev dependency. The "npm test" command (previously just said no test specified) now runs snyk test on the repo to check for vulnerable dependencies. This makes detection & patching much easier.

This has been resolved in 3.4.2.


Decide on how to display the content

There are several ideas for this:

A wheel divided into sections that when clicked on pop out with the content related to that section.
A clockface that represents a year (with months instead of hours) which has important business dates marked out on it.
A linear graph that shows a year and spikes in activity from google searches for certain search terms that are related to content.

We need to draw up wireframes for how we decide to display this information and share it with the client as soon as possible.

Doughnut chart that fills as user answers survey questions

Yep and using http://www.chartjs.org/


RopeToPen not working, errors

IMPORTANT:
Please first search existing bugs to ensure you are not creating a duplicate bug report!
Make sure you have the latest version of Rimworld!
Describe the bug
Colonists cant lead animals to pens, it errors out
Steps to reproduce the behavior (VERY IMPORTANT)

have a colonist try to lead a group of animals to a pen
it will error and the ropes will disappear
the colonist will try again forever

Error Logs
Player.log
!!! Link to contents of Player.log or Error.log (MUST BE LINK) !!!
HugsLib log
https://gist.github.com/cf68fc57a61259b087c19f6260cc14e6
Save file
Kotiin Independent Federation (Permadeath).zip
Screenshots

Mod list (For vanilla report, it has to be same as below list.)

Harmony
Core
Royalty (Optional)
Ideology (Optional)
HugsLib
RimThreaded

For provided save File:
[Mod list length: 32]
Harmony [https://steamcommunity.com/sharedfiles/filedetails/?id=2009463077]
Core [https:// no link (local mod)]
Royalty [Official DLC] [https:// no link (local mod)]
Ideology [Official DLC] [https:// no link (local mod)]
HugsLib [https://steamcommunity.com/sharedfiles/filedetails/?id=818773962]
Allow Tool [https://steamcommunity.com/sharedfiles/filedetails/?id=761421485]
Better Map Sizes [https://steamcommunity.com/sharedfiles/filedetails/?id=2099101052]
Bradson's Main Button Icons for Vanilla Textures Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=2361775777]
CM Color Coded Mood Bar [1.1+] [https://steamcommunity.com/sharedfiles/filedetails/?id=2006605356]
Camera+ [https://steamcommunity.com/sharedfiles/filedetails/?id=867467808]
Compact Hediffs [https://steamcommunity.com/sharedfiles/filedetails/?id=2031734067]
EdB Prepare Carefully [https://steamcommunity.com/sharedfiles/filedetails/?id=735106432]
Heat Map [https://steamcommunity.com/sharedfiles/filedetails/?id=947972722]
Pick Up And Haul [https://steamcommunity.com/sharedfiles/filedetails/?id=1279012058]
While You're Up / PUAH+ [https://steamcommunity.com/sharedfiles/filedetails/?id=2034960453]
Map Reroll [https://steamcommunity.com/sharedfiles/filedetails/?id=761315214]
ModDiff [https://steamcommunity.com/sharedfiles/filedetails/?id=2200054867]
No Debris 1.1/1.2 [https://steamcommunity.com/sharedfiles/filedetails/?id=2010756536]
OgreStack [https://steamcommunity.com/sharedfiles/filedetails/?id=1447140290]
Architect Icons [https://steamcommunity.com/sharedfiles/filedetails/?id=1195427067]
Optional Icons for Architect Icons [https://steamcommunity.com/sharedfiles/filedetails/?id=1966995052]
Quality Of Building [https://steamcommunity.com/sharedfiles/filedetails/?id=2101676323]
QualityBuilder [https://steamcommunity.com/sharedfiles/filedetails/?id=754637870]
Replace Stuff [https://steamcommunity.com/sharedfiles/filedetails/?id=1372003680]
ResearchPal - Forked [https://steamcommunity.com/sharedfiles/filedetails/?id=2351393394]
Show Draftees Weapon [https://steamcommunity.com/sharedfiles/filedetails/?id=1690978457]
Simple sidearms [https://steamcommunity.com/sharedfiles/filedetails/?id=927155256]
Vanilla Textures Expanded [https://steamcommunity.com/sharedfiles/filedetails/?id=2016436324]
World Map Beautification Project [https://steamcommunity.com/sharedfiles/filedetails/?id=2314407956]
[KV] Save Storage, Outfit, Crafting, Drug, & Operation Settings [https://steamcommunity.com/sharedfiles/filedetails/?id=1180718516]
[XND] Tiny Tweaks (Continued) [https://steamcommunity.com/sharedfiles/filedetails/?id=2270049772]
RimThreaded [https://steamcommunity.com/sharedfiles/filedetails/?id=2222907981]

I've also seen this after a caravan came back. 2/5 animals had this issue.


Missing license sku

I can't seem to find one of our Skus listed on this page. We are an educational institution and we have the following SKU in our tenant:
SKUID : e578b273-6db4-4691-bba0-8d691f4da603
SkuPartNumber : ENTERPRISEPACKPLUS_FACULTY
I can find the ID listed on this other MS page, https://docs.microsoft.com/en-us/MicrosoftTeams/sku-reference-edu but the SkuPartNumber doesn't match what our tenant lists (ENTERPRISEPACKPLUS_FACULTY). I put in a new issue for that as well (7724).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7c245452-161d-89a1-c026-99a0721cf071
Version Independent ID: 16dec59a-eb83-1837-4efd-4645e7aeaed2
Content: Product names and service plan identifiers for licensing - Azure AD
Content Source: articles/active-directory/enterprise-users/licensing-service-plan-reference.md
Service: active-directory
Sub-service: enterprise-users
GitHub Login: @Nicholak-MS
Microsoft Alias: nicholak

@marcgoff Thank you for your feedback . We will investigate and update the thread.

Linked to MicrosoftDocs/OfficeDocs-SkypeForBusiness#7724

Hi @Marcgoff I added the ENTERPRISEPACKPLUS_FACULTY to the doc. It will publish later today.
#Please-Close


Integrate GraphiQL

Implemented in the way similar to how it was done in flask-graphql and graphene-django. Which is to say, copying the GraphiQL template into the project and exposing it on all GraphQL endpoints by default.
Not sure if we need any kind of authentication for this. Or at least a way to limit only to local/dev environments.
Let me know if this makes sense or if something could be done better.

Fixes #28

can you rebase?


feat(app-probe-proxy): add document for application probe proxy

fixes https://github.com/kumahq/kuma-website/issues/1887
Did you sign your commit? Instructions
Yes
Have you read Contributing guidelines?
Yes

Preview location:

Application probe proxy: https://deploy-preview-1888--kuma.netlify.app/docs/dev/policies/service-health-probes/#application-probe-proxy
Pod annotation: https://deploy-preview-1888--kuma.netlify.app/docs/dev/reference/kubernetes-annotations/#kumaioapplication-probe-proxy-port


State parameter in history.push or  component does not get passed to the store in alpha.8

Between alpha .6 et .8 of react router the state parameter of location.history or of the to prop of the redirect component is ignored.
Parameters passed on route redirection are then lost.
Worked on alpha.6, broken in .8

Nothing about that has changed in between the alphas. Something else is going on in your app.

Sorry but i tested the problem this very morning, worked great on my local env with alpha .6 and did not work in my colleagues env or on our production env with latest version. Forcing alpha .6 in our package.json solved the problem.


Infer type of slots from $slots

The current system analyzes the available slots in different ways and does a good job at that. However, this is not possible for external components(e.g. UI component libraries).
From https://github.com/vuejs/rfcs/pull/192#issuecomment-705793592:

johnsoncodehk (Johnson Chu) on 8 Oct 2020:
But for a third party library like vue-router, I can't read the typescript source code to calculate v-slot types, for this case I need to define additional options for my tool like this: johnsoncodehk/volar#v-slot-type-checking

https://github.com/vuejs/vue-next/pull/4465 allows typing the slots, along with lots of other changes. So, after that gets merged, $slots will basically contain the typed slots.
https://github.com/pikax/vue-next/blob/e201d2f046c46dc1fa26551ce28ac1a322ed1ad9/packages/runtime-core/src/componentPublicInstance.ts#L422
Volar is already inferring the props types from $props:
https://github.com/johnsoncodehk/volar/blob/aa66f9fdc0b1752e58c56d680c942b9d2a3787ec/packages/vscode-vue-languageservice/src/utils/globalDoc.ts#L83-L90
So, in a similar way, $slots can be inferred too, then the current slot discovering system can do its job to enrich the types.
Currently, the UI library/framework authors can ship the constructor types themselves, without depending on current Vue types. An example:
https://github.com/quasarframework/quasar/blob/76c0c841554751a5be743b0302523b63f956ba25/ui/types/ts-helpers.d.ts#L33-L37
(thanks for some imagination from https://github.com/johnsoncodehk/volar/issues/418#issuecomment-918437110 btw)
So, since this feature is not blocked by https://github.com/vuejs/vue-next/pull/4465 because there are currently ways to provide that type, I think this can be implemented right away! 🚀

Could you try does latest master branch support $slots in expected? You can check https://github.com/johnsoncodehk/volar/discussions/413 for how to run in debug mode.

@johnsoncodehk
This is the summary of the types I used for testing:
import { VNodeProps, AllowedComponentProps, ComponentCustomProps, Slots as VueSlots } from 'vue';

type PublicProps = VNodeProps & AllowedComponentProps & ComponentCustomProps;

type GlobalComponentConstructor<Props = {}, Slots = VueSlots> = {
  new (): {
    $props: PublicProps & Props
    $slots: Slots
  }
}

interface QTreeSlots {
  'default-header': (scope: { expanded: boolean, ticked: boolean, color: string }) => VNode[]
}

declare module "@vue/runtime-core" {
  interface GlobalComponents {
    QTree: GlobalComponentConstructor<QTreeProps, >
  }
}

this is the result I got:

Slots type from Vue:
export declare type Slot = (...args: any[]) => VNode[];

declare type InternalSlots = {
  [name: string]: Slot | undefined;
};

export declare type Slots = Readonly<InternalSlots>;

So, a Slot is basically a function that accepts the scope as the parameter, then returns VNode[]. I believe the returning type is irrelevant in the template context, so it can be ignored. But, it's currently behaving as if the slot function is the slot scope, but actually, it should use the type of the function's parameter.
// Example usage in underlying code that renders the slot
const scope = {
  expanded: true,
  ticked: false,
  color: 'green'
}

this.$slots['default-header'](scope)
// This shows the type of `$slots` and `Slots` is correct.

So, the expected type of slot is:
type SlotScope = { expanded: boolean, ticked: boolean, color: string }

but it's currently like this:
type SlotScope = (scope: { expanded: boolean, ticked: boolean, color: string }) => VNode[]

This is the current code for inferring the type:
function __VLS_getScriptSlots<T>(t: T): T extends new (...args: any) => { $slots?: infer S } ? (S extends object ? S : {}) : {};

If I am not mistaken, something like this should work:
// `Slot` is from 'vue'
function __VLS_getScriptSlots<T>(t: T): T extends new (...args: any) => { $slots?: infer S } ? (S extends Slot ? Parameters<S>[0] : {}) : {};

@yusufkandemir fixed, thank you. :)

@johnsoncodehk well, thank you for the fix :)


NextJS Edge runtime fs module error implementing ChatBedrock

I ran into an issue implementing the latest Bedrock chat model running with NextJS edge runtime.
Error: The edge runtime does not support Node.js 'fs' module.
Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime
    at (node_modules/next/dist/esm/server/web/globals.js:29:18)
    at (node_modules/@smithy/shared-ini-file-loader/dist-es/getSSOTokenFromFile.js:3:16)

My implementation is as follows with the new ChatBedrock api. This setup works fine if it's replaced with any other chat model.

const llm = new ChatBedrock({
                model: "anthropic.claude-v2",
                region: "us-west-2",
                maxTokens:streamSettings.max_tokens,
                temperature: streamSettings.temperature,
                stopSequences: ["\n\nHuman:"],
                credentials:{
                    accessKeyId: process.env.APP_ACCESS_KEY_ID,
                    secretAccessKey: process.env.APP_SECRET_ACCESS_KEY
                },
                // modelKwargs: {},
              });

              llm.call((streamSettings.messages)
                  .filter(m => m.role !== 'system')
                  .map(m =>
                    m.role == 'user'
                      ? new HumanMessage(m.content)
                      : new AIMessage(m.content)
                  ),
                {},
                [handlers],
              )
              .catch(console.error);

            return newStreamingTextResponse(stream);

#2746

Yeah this probably won't work on Edge at the moment - we can look into what it would take to add it

Oh, we added a separate web entrypoint - apologies for not following up!
https://js.langchain.com/docs/integrations/chat/bedrock#setup


Checkbox icon not showing with 2.8.1

I have gone through these following points

[x]   Check latest documentation: https://docs.nativebase.io/
[x]   Check for existing open/closed issues for a possible duplicate before creating a new issue: https://github.com/GeekyAnts/NativeBase/issues
[x]   Use the latest NativeBase release: https://github.com/GeekyAnts/NativeBase/releases
[x]   Check examples from NativeBase KitchenSink https://github.com/GeekyAnts/NativeBase-KitchenSink
[x]   For discussion purpose make use of NativeBase Slack: http://slack.nativebase.io/
[x]   For queries related to theme, check Theme Variables from Docs and live NativeBase Theme Editor http://nativebase.io/customizer/

Issue Description
Hi. I'm working with Expo SDK 30 and NativeBase 2.8.1
When I include a simple checkbox component it gives me a icon warning. My code is:
<ListItem button onPress={this.handleLegalAge}>
              <CheckBox
                checked={this.state.legalAge}
                onPress={this.handleLegalAge}
              />
</ListItem>

The error is the classic icon name issue: it says "Warning: Failer prop type: Invalid prop name of value ios-checkmark-outline supplied to Icon, expected one of [...]"
Even more, if I use an icon like
<Icon name="person"/>

It also gives a similar issue as it looks for "ios-person-outline". If I add active prop to that icon the component renders fine.
Anyway, my issue report is about the impossibility to use the checkbox component as I don't have access to the icon declaration.
Hope anyone can help.
Thanks in advance.

Fixed with commit https://github.com/GeekyAnts/NativeBase/commit/86da1649e7dd541d405aa5c64cce7d0eb61751a2
Also available on master

Upgrading NativeBase fixed the issue for me.


$all modifier does not work with non-domain-like URL part

AdGuard 7.17.0 nightly 2 (4585) (CL 1.13.118, DL 2.4.38 )
Chrome 121
Steps to reproduce

Disable all filters, DNS filtering, safebrowsing
Add &pbsubid=$all rule to user rules
Open http://iyfbodn.com/?dn=maphuahin.com&pid=9POT3387I&pbsubid=f3de3781-7342-44ad-8fd6-4839cebfd6d7&noads=http

Expected behavior
URL is blocked with a dummy, like with ||iyfbodn.com^$all

Details

Actual behavior
The page is loaded.
Also http$all only blocks resources of pages.

Details

@Alex-302 Domain does not exist, and with https://example.org/?dn=maphuahin.com&pid=9POT3387I&pbsubid=f3de3781-7342-44ad-8fd6-4839cebfd6d7&noads=http it works as expected.

Ok, I see. works with https:// but http:// does not match.


Add setter for GeoJsonDataSource.name

Fixes #5653

@mramato do you have any idea why CI is failing?  It's doing that on a couple of my branches


Print Pod ID in podman inspect output

Somehow this managed to slip through the cracks, but this is definitely something inspect should print.

LGTM

LGTM and happy tests

/lgtm


Unable to connect to database on render. Also I want to ask some silly questions

Hi Sir/Ma'am,
I created my DB on render in Singapore region. But while connecting it showed this following  error.

Also where should my .env file be located according to file architecture ? Under server or under root directory?
I also ran frontend and it shows loading.... Is it because backend has not been executed yet?

Hey,

The error suggests there might be issue with the credentials. Just ensure that all the credentials are correct and you haven't modified any other code. Also make sure you follow the steps in ./README properly.
The .env file should be in server directory.
Yes, you will see the frontend load up categories once the backend starts.

Please share the exact steps followed if the issue continue to persist.

Hi sir,
Thanks for the reply .I didn't change the code and the credentials I have verified. I have a confusion while giving the name of the DB , there are 2 names , 1 which I had to give and 1 which the render website generated. I put the latter in .env file.

I will again retry cloning locally and update you later.

After retrying cloning locally , The issue still persists.
Here's the timeline.
Yesterday , I followed the exact steps in Readme File and created the DB and it was created successfully. But when I ran backend , I ran into some issues.
Today morning , I tried following same steps but the error which was not there yesterday, started appearing today. And it has been the case for the whole day now .

Could you provide a description for the error?

I figured it out and the code ran successfully, turns out the DB was already created I suppose. But I deleted my old DB and created a new one and this time the code ran successfully.. I am not much experienced with web development so had silly doubts 😅.
Sorry for the mess @PritK99.


Duplicate symbol OBJC_CLASS$_ReactNativeConfig in RN 0.60.3

Steps I followed.

yarn add react-native-config
Moved ReactNativeConfig.xcodeproj to Libraries
Added libReactNativeConfig.a to build phases.
Added echo ".env" > /tmp/envfile; in Scheme's build pre actions.
Added .env file with API_HOST=http://localhost:8080
Stated the project react-native run-ios --simulator='iPad Pro (11-inch) (12.2)' --configuration Debug

First I get GeneratedDotEnv.m not found error. After following the suggestions mentioned in other posts, when I rebuild the project, it started throwing duplicate symbol _OBJC_CLASS_$_ReactNativeConfig error in two place,
here
..Build/Products/Debug-iphonesimulator/react-native-config/libreact-native-config.a(ReactNativeConfig.o)
and here
../Build/Products/Debug-iphonesimulator/libReactNativeConfig.a(ReactNativeConfig.o)

Not sure why it happened, but running react-native unlink react-native-config made everything work again.

I'm getting this same error. Unlink is not working for me to fix it.

Unlinking react-native-config worked for me, thanks!!


this could be nice on Retronas

https://github.com/RandomNinjaAtk/docker-raromprocessor

Converting to discussion


feat: sort account management list of connected chains by user currency balance and chain name

Description
Sorts the list of connected chains in the account management modal by usr currency balance and chain name.
Replace selectPortfolioChainIdsSortedUserCurrency with a corrected version selectWalletConnectedChainIdsSorted which sorts the list of connected chainIds based on the sum of all account balances for a given chainId, rather than the most recently seen using a javascript Set.
Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6926
Risk

High Risk PRs Require 2 approvals

Moderate risk as this replaces replace selectPortfolioChainIdsSortedUserCurrency with a corrected version selectWalletConnectedChainIdsSorted which attempts to do that same thing but handling multiple account balances for a given chain correctly.

What protocols, transaction types or contract interactions might be affected by this PR?

Testing

Engineering

Operations

Screenshots (if applicable)

Logic looks sane.
Confirmed my EVM chains are now listed in the correct order, vs prod where they are not.
I do, however, notice that my Bitcoin Cash is now incorrectly before my Litecoin - see screenshot below.

Fixed, though I did manage to recreate this issue in develop after a cache clear:


CompareExchangeHashes.ps1 [\version] in Baselines

It seems that anything with a filepath \version\ in the baseline files are not getting correctly compared. I have done some manual compares and they match, however when using the baselines through the powershell script NoHashMatch.
I suspect this is because the filepath is \version\ whereas the actual includes a version number, I would have thought that the baselines would already have the version numbers in the Path, wondering if this is a miss?
Anything that has a Path that doesnt have a version number in it, ie root directories and such all process correctly and output no error.

This issue is fixed.


feat: expose otp to user

A getter was created in the event the the user wants to use the otp for another purpose.

@danagbemava ,thanks for submitting a PR.What is the motivation for this and i don't see any value in adding this feature.

I'm currently working on an app with a middleware layer that doesn't have a database so I'm using the package to create the otp and the otp has to be sent to an sms provider so that the user can receive the otp on their device because I don't want the otp to be sent from sms package. In this scenario, when I create the otp, I need a way to access it so I can send it to the middleware which will forward it to the sms provider so the user can receive the otp.


Run in Application's EventLoopGroup for Vapor 3

It is cool if there is way to customize event loop group for version 0.2.7. Like in new version to reuse application's event loops group
Under hobby account in heroku there is a limit 20 postgres connections for all workers. And JobCommand creates MultiThreadedEventLoopGroup(numberOfThreads: System.coreCount) and every thread creates own connections as I understand correctly. So this limit is easy to reach currently

That's a good point. We should make it customizable.

FYI - this will be fixed for v1

v1 is shipped with Vapor 4?
Cool if for Vapor 3 it will also work

Right now V1 is targeting Vapor 4, so no, it won't work in Vapor 3. If I get some time later this week or next week though I can make a patch for Vapor 3.


Problem at calculating tax statistics/Vat Amount BC CU07:ES

Hi
When we view the statistics from a posted invoice or credit memo it does not calculate correctly the "VAT Amount".
If we have 2 or more invoice lines with TAX 0% where the TAX 0% configuration with "VAT Calculation Type" is at "Full VAT", we generate only the "VAT Amount" for the first line.
I’ve checked the code, and have found the problem, in the table 290, function "InsertLine", if the "VAT % + EC%" is different to 0, it calculates again the "VAT Amount" but, if the "VAT % + EC%" is 0, is does not increase the Field "VAT Amount".
Thanks
Original code:
........
 "VAT Difference" += VATAmountLine."VAT Difference";
 "EC Difference" += VATAmountLine."EC Difference";
  IF "VAT %" + "EC %" <> 0 THEN BEGIN
    "VAT Amount" :=       ROUND(         ("Amount Including VAT" - "VAT Base" - "VAT Difference" - "EC Difference") / ("VAT %" + "EC %") * "VAT %",RoundingPrec) +       "VAT Difference";
    "EC Amount" :=       ROUND(         ("Amount Including VAT" - "VAT Base" - "VAT Difference" - "EC Difference") / ("VAT %" + "EC %") * "EC %",RoundingPrec) +       "EC Difference";
  END;
.........
Suggested fix:
.........
  "VAT Difference" += VATAmountLine."VAT Difference";
  "EC Difference" += VATAmountLine."EC Difference";
  "VAT Amount" += VATAmountLine."VAT Amount"; //FIX ME
  IF "VAT %" + "EC %" <> 0 THEN BEGIN
   "VAT Amount" :=       ROUND(         ("Amount Including VAT" - "VAT Base" - "VAT Difference" - "EC Difference") / ("VAT %" + "EC %") * "VAT %",RoundingPrec) +       "VAT Difference";
   "EC Amount" :=       ROUND(         ("Amount Including VAT" - "VAT Base" - "VAT Difference" - "EC Difference") / ("VAT %" + "EC %") * "EC %",RoundingPrec) +       "EC Difference";
  END;
...........

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the AL compiler and developer tools of the latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


Fix changelog in Github release

The changelog is currently empty, because since_tag is the newest tag.
The workflow should use git describe --abbrev=0 --tags $(git rev-list --tags --skip=1 --max-count=1) as since_tag

While the changelog in the release now isn't empty anymore, it contains the changes of all previous releases as well.


Error on deploy

I am using Google Cloud run when deploying my site. The plugin works 100 in development but getting the following build error.
TypeError: debug_1.Debug.extend is not a function
at Object. (/usr/src/app/.output/server/node_modules/http-proxy-middleware/dist/plugins/default/debug-proxy-errors-plugin.js:5:29)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Module.require (node:internal/modules/cjs/loader:1005:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object. (/usr/src/app/.output/server/node_modules/http-proxy-middleware/dist/plugins/default/index.js:17:14)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
In my docker file I expose port 8080, not sure if the could be the reason?
ERROR: (gcloud.run.services.update) Cloud Run error: The user-provided container failed to start and listen on the port defined provided by the PORT=8080 environment variable. Logs for this revision might contain more information.

Can you try the latest version and reopen it if the issue still persists? Thanks!

@wobsoriano, what have you changed to remove this issue? I am currently facing it with the latest Nuxt edge and I can't find any workaround :/

Manually changing the highlighted import to 'debug' in the production bundle solves the problem. No idea why this happens though.

issue persist

same issue

Same here. Don't understand why I run into this error now since it seams to exist since 2023. Can this be addressed?

Why don't you switch to https://www.jsdocs.io/package/h3#proxyRequest? Are there any blockers?

@DamianGlowala, thanks for the recommendation. I didn't want to switch lib since I'm using this package in a nuxt project. But I guess I have to....


Cursed Sword Disabled?

Hey, when I was grinding for the cursed sword and finally got all the stuff for it and hit craft. it just made a sound effect and gave me nothing. so i thought it was a glitch so i was like what ever and grinded again because the sword looked op. but then it gave me nothing again. like a whole 2 hours waisted. Is this a common glitch or is it just me?
Also It said it was disabled when I /gave it to me in a creative test world?
How do i enable it?
Thank you,

Responded on CurseForge already, but I'll send the response here too!

Hey! You're playing Prominence II, right? The Cursed Sword is disabled there because it caused a few issues.
It's disabled through the Item Obliterator mod - but unfortunately due to a little oopsie in my code naming, the recipe didn't get disabled but the item itself did - which is why you could craft it but not actually get it. This should be taken care of with ~the next~ a future update of Item Obliterator, though!
If you are aware that it might cause issues and want to re-enable the sword anyway, you can do it in the Item Obliterator item_obliterator.json5 config file. Sorry for the problem😅


Suggest a version of the run scripts that work for me

@thoniTUB See 9c5b39d for the scripts change, the rest is just merging in develop again, fixing yarn.lock conflicts.
Feel free to merge!


failed to execute script due to unhandled exception : 'utf-8' codec can't decode byte 0xc2

The same problem. Any possible solution or the latest edition fixed it ?

Hi, yes, this seems to be happening because the names of your audio devices are not in UTF-8. I'm not sure what the correct fix should be, but a workaround is to turn on "Beta: Use Unicode UTF-8" in your Region settings. See:

https://github.com/chidiwilliams/buzz/issues/230
https://github.com/jaakkopasanen/Impulcifer/issues/53

Hi, yes, this seems to be happening because the names of your audio devices are not in UTF-8. I'm not sure what the correct fix should be, but a workaround is to turn on "Beta: Use Unicode UTF-8" in your Region settings. See:

Bug: Can't open buzz.exe on my windows 10 #230
The error occurred while running recorder jaakkopasanen/Impulcifer#53

Hi, enabling Unicode UTF-8 does run Buzz properly, but it causes some Chinese characters in some software to be garbled or even run incorrectly, I have to turn off Unicode UTF-8 again, is there another way to fix it? I see you say it's because of the audi

o device name? How do I change it?My change to English in the red √ does not seem to do anything.


Eagerly reconnect in PgListener::try_recv

When PgListener's underlying connection is closed, try_recv() will return Ok(None) and reconnect on the next call. In this case, user code is supposed to reload its state from the database (or otherwise handle potentially missing messages). However, if the user code uses another database connection to do so then there is a period between when the state is reloaded and PgListener's connection is re-established where notifications are lost without any indication that this has happened.
This commit changes PgListener to eagerly reconnect by default. At the suggestion of @abonander on discord, I have also included an option to switch back to the old behaviour in the case where someone was depending on it.
Now, if the connection is closed then, by default, user code can do whatever it needs to do in order to recover and any notifications emitted in the meantime will be waiting for it when it is done.
I have defaulted eager_connect to true since I think the current behaviour is a bit of a footgun but if you think that is too big of a change then I can change it to false.

Formatting should be fixed now. That was the only CI job that failed.


feat: show ghost_text (experimental)

Add a new option to enable ghost text when selecting a luasnip item.
Disabled by default.
This change fixes also the user config not taken into account and add
annotation types for the available options.

Demo

Annotation


deps: relax dependencies

Thanks for the pull request, and welcome! The MaidSafe team is excited to review your changes, and you should hear from @Fraser999 (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTOR.md for more information.

Hi @ignatenkobrain , Thanks for your PR. Sorry for the late answer. This one seems to have slipped through the system for a while. Using the tilde for dependencies is our company wide preference at Maidsafe.
Is there any reason in particular that you would want to be more relaxed here?
If there isn't a strong reason, I will reject your PR if that's OK with you.

~0.3.0 means that only 0.3.0 and 0.3.1 is acceptable. Which is totally wrong because everything between 0.3 and 0.4 is compatible.

@ignatenkobrain , isn't this a measure of your faith in how your dependencies use Denver, though? (Where our stance is caution)

the thing is that if you don't trust your deps, you should not use them. my problem is that I have to patch this manually in fedora because we are constantly updating crates to get fixes.

Actually, I think ~0.3.0 implies any patch level of 0.3, not just 0.3.1.  I don't think there's any difference between using the tilde and not for versions with major version of 0.  This only matters when the major version is > 0, and then e.g. ~1.2.0 would use 1.2.3, but not 1.3.0, whereas ^1.2.0 would use 1.3.0.

Given @Fraser999 's explanation that it actually doesn't make a difference for versions < 1.0.0, and since it's consistent with the policy we follow for maidsafe crates, I am now closing this issue.
Hope it's no bother, @ignatenkobrain.


Test content schema

This PR changes Finder Frontend to test against the example Content Item added to govuk-content-schemas in https://github.com/alphagov/govuk-content-schemas/pull/15. The commits are as follows

removing the content item fixture for the Finder
add a support file for govuk-content-schemas
test specs using schema
test features using schema and move away from talking about cases to the more generic documents
update the jenkins.sh to use the schemas
add a new jenkins-schema.sh to test Finder Frontend when a change is made to govuk-content-schemas

:+1: looks good to me


chore: change codeowner to ide

Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist

[ ] Tests added and all succeed
[ ] Linted
[ ] CHANGELOG.md updated
[ ] README.md updated, if user-facing

Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

Other references that maybe we need to update too


[coc.nvim] Connection to server got closed. Server will not be restarted.

Hi. I'm struggling to get this extension working. When opening a vue file in nvim, I get the above error.
coc-tsserver seems to be working fine. coc-volar is v0.35.12
:CocInfo shows that the client keeps trying to restart:
## versions

vim version: NVIM v0.10.1
node version: v20.16.0
coc.nvim version: 0.0.82-98fa66a 2024-08-13 09:48:22 +0800
coc.nvim directory: /home/username/.vim/bundle/coc.nvim
term: tmux
platform: linux

## Log of coc.nvim

2024-08-30T11:28:46.676 INFO (pid:13920) [extension:coc-git] - Looking for git in: git
2024-08-30T11:28:46.775 INFO (pid:13920) [plugin] - coc.nvim initialized with node: v20.16.0 after 1383
2024-08-30T11:28:46.776 INFO (pid:13920) [services] - LanguageClient ESLint state change: stopped => starting
2024-08-30T11:28:46.795 INFO (pid:13920) [services] - service tsserver started
2024-08-30T11:28:46.802 INFO (pid:13920) [language-client-index] - Language server "eslint" started with 13947
2024-08-30T11:28:46.829 INFO (pid:13920) [services] - LanguageClient Vue state change: stopped => starting
2024-08-30T11:28:46.832 INFO (pid:13920) [language-client-index] - Language server "vue" started with 13957
2024-08-30T11:28:46.866 INFO (pid:13920) [services] - LanguageClient ESLint state change: starting => running
2024-08-30T11:28:46.869 INFO (pid:13920) [services] - service eslint started
2024-08-30T11:28:47.118 INFO (pid:13920) [services] - LanguageClient Vue state change: starting => running
2024-08-30T11:28:47.121 INFO (pid:13920) [services] - service vue started
2024-08-30T11:28:47.136 INFO (pid:13920) [services] - LanguageClient Vue state change: running => stopped
2024-08-30T11:28:47.136 INFO (pid:13920) [services] - LanguageClient Vue state change: stopped => starting
2024-08-30T11:28:47.139 INFO (pid:13920) [language-client-index] - Language server "vue" started with 14006
2024-08-30T11:28:47.427 INFO (pid:13920) [services] - LanguageClient Vue state change: starting => running
2024-08-30T11:28:47.440 INFO (pid:13920) [services] - LanguageClient Vue state change: running => stopped
2024-08-30T11:28:47.440 INFO (pid:13920) [services] - LanguageClient Vue state change: stopped => starting
2024-08-30T11:28:47.443 INFO (pid:13920) [language-client-index] - Language server "vue" started with 14018
2024-08-30T11:28:47.636 INFO (pid:13920) [attach] - receive notification: highlight []
2024-08-30T11:28:47.761 INFO (pid:13920) [services] - LanguageClient Vue state change: starting => running
2024-08-30T11:28:47.773 INFO (pid:13920) [services] - LanguageClient Vue state change: running => stopped
2024-08-30T11:28:47.773 INFO (pid:13920) [services] - LanguageClient Vue state change: stopped => starting
2024-08-30T11:28:47.776 INFO (pid:13920) [language-client-index] - Language server "vue" started with 14025
2024-08-30T11:28:48.079 INFO (pid:13920) [services] - LanguageClient Vue state change: starting => running
2024-08-30T11:28:48.096 INFO (pid:13920) [services] - LanguageClient Vue state change: running => stopped

Any advice?

it is fixed with v0.36.0


Update Pages “FiveThingsToConsiderSelectingACompanyPage”

Automatically generated by Netlify CMS

👷 Deploy Preview for chic-shortbread-66a66b processing.

Name
Link

🔨 Latest commit
b2abf768d67249ffcc30e0a9cc30872dee89d93e

🔍 Latest deploy log
https://app.netlify.com/sites/chic-shortbread-66a66b/deploys/655d700cff512a000805f4a4


Git diff only diffs when open folder has .git folder

I opened a folder in Atom that has git-diff installed. This folder has several repos. Git diff appears to not be working, as if it was an untracked file.

@eranimo Sounds related to https://github.com/atom/atom/issues/2203. Currently, Git-related features work if the root folder is the VCS root.

This also prevents the gutter from working when using git worktrees - in this case there is a .git file that points to master repo metadata, not a folder.

:+1: doesn't work in worktree

Indeed, worktree support needs to be added to libgit2 before we can support it: https://github.com/libgit2/libgit2/issues/3159

+1

+1

+1

I know this issue is ancient, but this really needs to be done. +1

I'm not sure when we'll fix this, but you can subscribe to https://github.com/atom/atom/issues/2203 for updates on when we do. Sorry for the poor experience around this.


(Ignore) Disable buffer_outgoing_test until we can fix. Nondeterministic on Travis.

Maybe we can add a flag or travis profile somewhere