Fragment order with named fields returns invalid response

Query:
query Queries {
  viewer {
    me {
      profilePhotoAlbum {
        ...albumInfo
      }
      ...userInfo // <== POSITION OF THIS IS IMPORTANT
    }
  }
}
fragment userInfo on User {
  profilePhotoAlbum {
    p1: id
  }
}
fragment albumInfo on PhotoAlbum {
  p2: id
}

Result:
{
  "data": {
    "viewer": {
      "me": {
        "profilePhotoAlbum": {
          "p1": "UGhvdG9BbGJ1bToxMDAwMjUwNg==" // <== MISSING p2
        }
      }
    }
  }
}

Second query with moved userInfo fragment up
query Queries {
  viewer {
    me {
      ...userInfo // <== POSITION OF THIS IS IMPORTANT
      profilePhotoAlbum {
        ...albumInfo
      }
    }
  }
}
fragment userInfo on User {
  profilePhotoAlbum {
    p1: id
  }
}
fragment albumInfo on PhotoAlbum {
  p2: id
}

Result:
{
  "data": {
    "viewer": {
      "me": {
        "profilePhotoAlbum": {
          "p2": "UGhvdG9BbGJ1bToxMDAwMjUwNg==" // <== MISSING p1
        }
      }
    }
  }
}

Conclusion: Order of ragments contained named fields can cause invalid response. At both queries expected result was containing p1 and p2 but received only one. This problem is simplified as much as I can but can cause really big problems when used with relay

I think the issue was caused by naively thinking that array_merge, used in collectResult, was merging the arrays recursively. It does not behave that way, but array_replace_recursive does.
I used the array_replace_recursive function instead of array_merge_recursive, because it better mimics ES2015's object spread behavior. On top of that array_merge_recursive, without further processing, would break the result when requesting the same scalar field twice:
query {
   Foo { id, name }
   Foo { id, price }
}

Result with array_merge_recursive:
{ "data": { "Foo": { "id": [13, 13], "name":"Fizz", "price": 123}}}

Result with array_replace_recursive:
{ "data": { "Foo": { "id": 13, "name":"Fizz", "price": 123}}}

A potential issue with my current approach is what happens with lists. Consider the following query:
query {
    TrainList(line: "R9") { name, line, company }
    TrainList(company: "North Rail") { name, line, company }
}

On their own, the lines generate these results:
{
    "data":  [
        {"name": "Northern Express", "line": "R9", "company": "North Rail"},
        {"name": "Thomas", "line": "R9", "company": "Tank Engines Ltd."},
        {"name": "James", "line": "R9", "company": "Tank Engines Ltd."}
    ]
}

and
{
    "data":  [
        {"name": "Northern Express", "line": "R9", "company": "North Rail"},
        {"name": "Ivan", "line": "Transsib", "company": "North Rail"}
    ]
}

The issue is: What merging strategy do we use now?

    ]
}

Neither of these solutions are ideal.  I'm not sure how other libraries and frameworks deal with this. We should probably investigate this first.

Simply merging the result is the wrong approach for this problem. The specification is actually clear on how this scenario must be handled. They can only be merged if:

fieldA and fieldB must have identical field names.
fieldA and fieldB must have identical sets of arguments.

Also, this is a real merge of the two result sets, so objects returned from both fields would show up twice. Note that this does not apply for aliased fields / fields including fragments (they'd have a different name).
I think the query would need to be flattened out before actually executing it. In the query, Inline fragments then would need to be merged into the query.
Flattening the initial query, it would read as:
query Queries {
  viewer {
    me {
      profilePhotoAlbum {
           p2: id
      }
      profilePhotoAlbum {
            p1: id
      }
    }
  }
}

So the expected result really would be
viewer {
    me: {
        profilePhotoAlbum: [
            {p2: 'some-value'}
            {p2: 'some-value2'}
            {p2: 'some-value3'}
            {p1: 'some-value'}
            {p2: 'some-value2'}
            {p3: 'some-value3'}
        ]
    }
}

Just for an example - this would result in the field being accessed twice, and the results being merged as by the rules above.
Note the restriction that this may only be merged if the arguments for that field are the same! If they are not we'd have to use aliases.

Are you sure that's what the docs imply? That wouldn't be very useful. Besides, at least one other framework doesn't do it this way.
Try this Apollo Launchpad with the following query:
query Posts {
    posts {
      title
      author {
        firstName
      }
    }
    posts {
      votes
      author {
        lastName
      }
    }
}

**Spoiler alert!** the result is not what you think. Click to view
{
  "data": {
    "posts": [
      {
        "title": "Introduction to GraphQL",
        "author": {
          "firstName": "Tom",
          "lastName": "Coleman"
        },
        "votes": 2
      },
      {
        "title": "Welcome to Meteor",
        "author": {
          "firstName": "Sashko",
          "lastName": "Stubailo"
        },
        "votes": 3
      },
      {
        "title": "Advanced GraphQL",
        "author": {
          "firstName": "Sashko",
          "lastName": "Stubailo"
        },
        "votes": 1
      },
      {
        "title": "Launchpad is Cool",
        "author": {
          "firstName": "Mikhail",
          "lastName": "Novikov"
        },
        "votes": 7
      }
    ]
  }
}

I think you misunderstood what

fieldA and fieldB must have identical field names

means. I'd wager it means that this wouldn't merge (i. e. not produce a single list in the result), because the lists have two different field names:
query Posts {
    otherPosts: posts {
      title
      author {
        firstName
      }
    }
    posts {
      votes
      author {
        lastName
      }
    }
}

For the second comment: it is actually the other way around:
fragment conflictingBecauseAlias on Dog {
  name: nickname
  name
}

This is not possible. Your query is executable and valid.

Just because Apollo behaves that way does't make it right. But you're right that the spec seems a bit unclear on that exact issue. Looking at the explanatory text below the algorithm the intention is still pretty clear - they may only be merged if they are semantically equivalent. But then I'm no authority either, so we could bring this to the GraphQL Team right away too :)
The behavior you described does make sense in it own too though. Just saying the spec might already cover this :)

Your query is executable and valid.
Executable and valid and, most of all, the two fields in the set will not merge. I'll raise this issue in graphql github.

It will not merge because it doesn't cause any conflict due to the different names (that's what aliases are for).
For your query the result would be
posts {
    otherPosts: [{ ... }]
    posts: [{ ... }]
}

... Which was exactly my intention. I meant this to serve as an example of what I thought the spec was really saying. I do not have an issue with this behavior.

No, the spec & this ticket is only about the behavior where fields have the same name in the result :) As soon as you alias the result of one field you can query the same field as often as you want with different parameters.
E.g. no problem:
query Posts {
    byFirstName: posts {
      title
      author {
        firstName
      }
    }
    byLastName: posts {
      votes
      author {
        lastName
      }
    }
}

I don't know if it's the heatwave over here causing me not to express myself clearly, but I agree with you. We've been in agreement for the past couple of comments.

The spec only talks about whether two or more fields can merge. It doesn't seem to say anything about how to merge two or more fields if the correct conditions are met.
I think this is an oversight. I'm raising this issue over at https://github.com/graphql/graphql.github.io


Model getter in NoResultsError

https://github.com/vladfaust/core.cr/blob/6a4a9b4f15bcb97655fc316946cdf717e8f26c23/src/core/repository/query.cr#L80-L81
Waiting for https://github.com/crystal-lang/crystal/issues/5692 to be fixed.

Closed by 226b92c3ff82403e52a719369569e68a88a6b814


CUDA error: an illegal memory access was encountered

Seeing this error in the console:
{
  "detail": "CUDA error: an illegal memory access was encountered\\nCUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.\\nFor debugging consider passing CUDA_LAUNCH_BLOCKING=1.\\nCompile with `TORCH_USE_CUDA_DSA` to enable device-side assertions."
}

Seems to always happen on the second message. First chat interaction works, then the second fails.

@zeke Is this still happening for you?


Better handling of standard situations

Proposed changes
Improves handling of standard situations and listening to game controller
Necessary checks

[ ] Update package version
[ ] Run catkin build
[ ] Write documentation
[ ] Create issues for future work
[ ] Test on your machine
[ ] Test on the robot
[x] Put the PR on our Project board

currently the behavior on this branch crashes immediately with the following error:
INFO] [/body_behavior] [1623941128.452364, 6.432000]: Debugging is active. Publishing on debug/dsd/body_behavior Traceback (most recent call last):   File "/home/jonas/catkin_ws/src/bitbots_meta/bitbots_behavior/bitbots_body_behavior/src/bitbots_body_behavior/body_behavior.py", line 45, in <module>     D.load_behavior(os.path.join(dirname, "main.dsd"))   File "/home/jonas/catkin_ws/src/bitbots_meta/dynamic_stack_decider/dynamic_stack_decider/src/dynamic_stack_decider/dsd.py", line 137, in load_behavior     self.tree = parse_dsd(path)   File "/home/jonas/catkin_ws/src/bitbots_meta/dynamic_stack_decider/dynamic_stack_decider/src/dynamic_stack_decider/parser.py", line 102, in parse     raise ParseError('Error parsing line {}: {} not defined'.format(lnr, name)) dynamic_stack_decider.parser.ParseError: Error parsing line 31: SearchBall not defined


Feature Request For Gobuster

hey,
Gobuster is just what the doctor ordered but it would be nice if we could be able to port scan the found subdomains when in dns mode.I think it would be nice to have an option to port scan and print only hostnames that have open ports on them.That way feeding the results to tools like Eyewitness or SubOver would be a breeze.

Or maybe a suggested nmap command instead?
nmap is very prevalent for port scanning, my opinion is building port scanning functionality is basically reinventing the wheel :P

sorry but I don't think we will ever implement this - Gobuster is an enumeration tool. If you want to invoke other steps you need to write a bash script or smth. to run nmap against the found hosts.

+1 to @FireFart's comment. This really has no relation to what the tool was designed to do. There are other tools that already do this, and do it better than we ever will.


Change radius of points in scatter chart

Using angular-chart is it possible to change the radius of the points (in relation to the data value) in the scatter chart in order to create a scatter bubble chart? Looking at the C3 docs it should be possible using the point.r property.
http://c3js.org/reference.html#point-r

Hey @lmayren, with the upcoming 0.3.0 release #55 of  angular-chart all c3 options will be included - please wait until the documentation is ready.

With the new version (0.3.0) of angular-chart, the point radius can now be configured.
Check out this grafiddle.


Fit and finish

Signed-off-by: Joshua Packer<EMAIL_ADDRESS>Made the following changes:

Dockerfile, dropped entrypoint
go-mod refresh
Makefile support for controller deployment
PROJECT - stolostron update
kustomization - default namespace
Hypershift controller renamed from curator
Updated to make sure configure: false still applied hostedCluster and NodePool

This is pretty much a press the merge button till PROW gets hooked up later this week.

/lgtm


Lab 8 case 6_8

Summary
Does anyone know why this bug exists?
Was able to pass all the test case before this so Im not to sure why there is this new error :(

There's definitely a bug in your code give that there is a total of 10 customers but your stats shown that you have served 10 and 2 left. Moreover, customer 6 and 8 comes back twice in your code.
Probably the addition of the self-check counter class messed with some of  your original coding logic. The cases with the self-check counter only starts from case 9 onwards. From 1 to 8, the numOfSelfChecks = 0.

Not sure how you implemented your self-check counters, but you could be double enqueuing customers in non-self-check counters by sharing enqueuing logic between self-check counters and non-self-check counters.

The test case doesn't appear to use the self-check counter, so you might want to try debugging from a scenario where there is a self-check counter but it is not used? It's possible your assignment of customers to the servers went wrong cos of this

Solved. Instead of updating my server's customer queue after done, I updated it after the serve event

hi @BlabbyDuck do u mind if u share how do u implement the self counters. Im currently stuck in how to implement the portion where all self checkout have 1 same queue

@glendon29 Hello sorry for the late reply! What I did was that I only assign queue number to the self counter K+1. Any counter behind it will have 0 queue limit.


[hotfix] make ParquetProtoWriters.ParquetProtoWriterBuilder public

What is the purpose of the change
This makes ParquetProtoWriterBuilder's constructor public so that people who would like to configure the writer further can.  For example, I needed this to pass in a hadoop configuration to control some parquet behaviors:
        ParquetBuilder<T> builder = (out) -> {
            Configuration conf = new Configuration();
            conf.setBoolean("parquet.proto.writeSpecsCompliant", true);
            conf.setInt("parquet.proto.maxRecursion", 1);
            return new ParquetProtoWriters.ParquetProtoWriterBuilder<>(out, clazz)
                .withConf(conf)
                .build();
        };

Brief change log

made the ParquetProtoWriterBuilder class and constructor public.

Verifying this change
[x] Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? n/a

ping


Fix duplicate ids on index import

This solves https://github.com/toptal/chewy/issues/214 (at toptal/chewy)

Seems like it supposed to be working. Thanks!


Update 5kplayer to 4.2

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

No appcast and no versioned url. It has to remain as is.


One container - multiple domains

I have a Wordpress container working with this companion, at the moment LETSENCRYPT_HOST & VIRTUAL_HOST are set like this: "example-domain-a.co.uk,www.example-domain-a.co.uk". I'd like to add another domain which my client owns, but I suspect that I can't set these variables to "example-domain-a.co.uk,www.example-domain-a.co.uk,example-domain-b.co.uk,www.example-domain-b.co.uk". I'll try this on a test environment in the near future, but does anyone know what the form is on this?
Thanks,
Andrew.

See the PR #140 it was created for this purpose.

Many thanks, Mickael. I'll try it out in the coming days and look forward to your change going mainstream.


feat: setInterval and clearInterval support

Description

setInterval
Execute a trigger callback on given interval.

setInterval(callbackFunction: Function, interval: number, id?: string)

// setInterval(() => { Query1.run() }, 10000, "myTimer");

when id is provided, it can be cancelled with clearInterval

clearInterval
Stop executing the trigger callback started with setInterval

clearInterval(id: string)

// clearInterval("myTimer");

Implements #3312
Fixes #8339
Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feature/set-interval

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
54.94 (-0.03)
36.63 (-0.05)
33.91 (-0.02)
55.49 (-0.04)

:red_circle:
app/client/src/components/editorComponents/ActionCreator/Fields.tsx
26.33 (-1.29)
21.3 (-1.34)
6.76 (-0.59)
25.51 (-1.28)

:red_circle:
app/client/src/components/editorComponents/ActionCreator/index.tsx
40.74 (-0.88)
7.32 (-0.24)
40 (0)
40.64 (-0.89)

:green_circle:
app/client/src/constants/messages.ts
74.56 (0.11)
100 (0)
24.78 (0.32)
79.81 (0.06)

:red_circle:
app/client/src/sagas/EvaluationsSaga.ts
23.79 (-0.11)
5.62 (0)
12.5 (0)
26.7 (-0.16)

:red_circle:
app/client/src/sagas/ActionExecution/ActionExecutionSagas.ts
25.29 (-0.96)
2.27 (-0.23)
20 (0)
25.88 (-1.04)

:sparkles: :new:
app/client/src/sagas/ActionExecution/SetIntervalSaga.ts
38.89
0
0
38.89

:green_circle:
app/client/src/utils/DynamicBindingUtils.ts
89.86 (0.06)
83.54 (0)
78.26 (0)
88.46 (0.09)

:red_circle:
app/client/src/workers/Actions.ts
75.61 (-1.25)
55 (0)
80.65 (-5.56)
74.77 (-1.42)

:green_circle:
app/client/src/workers/evaluate.ts
88.16 (0.16)
75 (0)
75 (1.67)
87.84 (0.17)

@hetunandu there is just one small bug for setInterval.
If I delete the button which has setInterval triggered on onClick. The onClick event on the edit more does not deregister automatically. Not a big issue as its for current session only, the moment you reload its fine.

When you set the clearInterval widget and add the ID it takes the form of {{clearInterval(,,'1234')}} you have to manually edit the JS and remove the 2 ,, to make the clearinterval work.


improver threshold: ensure output is float32 not double

As an IMPROVER developer I want my thresholding step to avoid escalating floating point precision to 64 bits for 32 bit input data. This will help ensure that my calculations are faster and my files are more appropriate.
Acceptance criteria:

Make sure threshold output is float32 when the input data is float32
Update acceptance test KGO data
Add a unit test to check for this

Ben, is this closable?


How to get T265 working with unity in os x?

| Camera Model                       | T265 |
| Firmware Version                   | <IP_ADDRESS>15 |
| Operating System & Version |   MacOS  |
| SDK Version                            |  2.24  |
| Language                            |  unity    |
| Segment			|  AR    |
I was able to successfully run the sample scenes for the D435i in unity on the mac after installing the realsense sdk2.0 (2.24 using brew install) and the wrapper for unity from here: https://github.com/IntelRealSense/librealsense/tree/master/wrappers/unity .
The realsense-viewer shows both the D435i and T265 data when opened, however only the T265 slam demo does not work in Unity. It gives me the error:
ExternalException: rs2_pipeline_wait_for_frames(pipe:0x600000163d10)
Rethrow as Exception: Frame didn't arrived within 5000
Is the T265 supported in unity for Mac?

@ArvindSanjeev could you provide the steps to compile the wrapper on Mac?

I installed librealsense through brew: brew install librealsense
And then downloaded the wrapper from here: https://github.com/IntelRealSense/librealsense/releases/download/v2.24.0/Intel.RealSense.unitypackage
And added it to unity.

MacOS support for T265 is not supported at this time.

It's taken a while, but if you've had problems with T265 on a Mac previously, then #5213 will likely address them.


RESTClient: paginators follow-up

Feature description
Documentation:

[ ] Document SinglePagePaginator
[ ] Write why it is helpful to declare different types during type checking compared to code execution time. To me, this decision is not obvious.

Tests:

[ ] test_paginators.py: assert that the initial state of the paginator is as intended before we call update_state(). Otherwise, tests could be green if update_state() has no effect.
[ ] Consider adding a test case that the first request is without the pagination parameter and only starting from the second page do we find a page=2 in the request params

Paginator implementation

[ ] change signature of update_request(self, request: Request) -> None to 1update_request(self, request: Request) -> Request`

Related issues
https://github.com/dlt-hub/dlt/issues/1325
Follow-up to https://github.com/dlt-hub/dlt/pull/1509

please also convert class-based tests into our regular test module. this is how we structure our tests


v3.0.0-rc.2 decodeUriComponent is called before route match, breaking links with urlencoded slash (%2F)

<Route path="/:foo"><Foo></Route>
<Link href={'/' + encodeUriComponent('foo/bar')}>Go to Foo</Link>

decodeUriComponent is called before route match, so the url matcher thinks slashes (%2F) in params are path separators

Yep, that's related to #400, the fix is under review.

Fixed in v3.0.0-rc.3


etcd: Remove oldMaster variable from elector logic

This variable, and the if block that uses it, have no effect.

Merged


Add color harmonies

Resolves #157

Pretty much all the harmonies are evaluated in cylindrical color spaces as the harmonies are found by rotating the hue. The one exception is monochromatic harmonies. They can be performed in rectangular spaces as we just tint or shade the color.
I guess we'll let the individual harmonies throw an error if the space is not sufficient. I'm not entirely sure yet how many colors to return for monochromatic and exactly how far apart to force them, but we have the basics for them done.

@gir-bot lgtm


Add support for multiple windows with individual properties

Can you add a description with some details on what this means?

Closing due to inactivity, please reopen when you add more details!


[Feature Request]: Discuss if ditching the feature to allow autogenerated unique names for resources

Description
Some modules e.g. vm, evhns, storage account, allow resource names to be autogenerated if no name value is provided.
To allow deployment idempotency, the unique name uses the resourcegroup id as input of a uniqueString function.
The problem of this approach is that two resources of the same type cannot be deployed to the same resource group due to the collision of the autogenerated name.
Discuss if this feature provides actual value and if not remove the functionality from the modules using it, cleaning up the code and converting the corresponding name parameter as Required.

Upvote for removing. The name generation can be implemented in the consuming deployment/template.

Team decides to remove this feature from a module level


Binding GameWindow directly to control

Could you make a class that implements GameWindow to be bindable/assignable to the wpf control?

Why did you close this issue? If you decide to reopen this issue it would be great if you could elaborate more on how this would work. :)


BLM, SMN, PLD Auto rotations fail to load on job change

SAM, RPR, DRG, MNK, WAR and GNB all seem to load ok.
Show in game UI toggle shows loaded module but BLM, SMN, PLD fail to do so. Target dummy rotation check fails too.

BLM SMN and PLD are only supported up to like level 30.
They will not load past that level.

Outdated.


TOP/BOT alignment of text within Text Button when frame is selected

Describe the bug
When creating gslc_ElemCreateBtnTxt(), with gslc_ElemSetTxtAlign() and GSLC_ALIGN_BOT_MID or GSLC_ALIGN_TOP_MID, with gslc_ElemSetFrameEn() the text overwrites the frame.
Versions
GUIslice: Version: 16.0
Platform: tft_espi
Touch Driver: esp-tftespi-default-xpt2046.h
TFT Driver: ILI9488
Expected behavior
I am not sure whether this is intended behavior or not but it would be nice to offset the text so as not to erase the border.  This could be done by either a permanent offset when the border is selected or a parameter for the offset.   My preference to keep it simple is a permanent offset.

Thank you for noticing this! (it is easy to miss on the small displays)
I have now pushed a fix that will inset the text region when a frame is enabled.
Please let me know if this corrects the overlap that you observed.
Note that you also have the option of manually specifying a margin for the text within an element.
For example, the following will add a 2 pixel margin horizontally and 5 pixel vertically:
gslc_ElemSetTxtMarginXY(&m_gui,pElemRef,2,5);

Thanks for the super quick response again!!  I tested and the change looks just perfect.
Thanks for pointing out the gslc_ElemSetTxtMarginXY() function.  However since I am anticipating 10+ pages in my project I am trying to stay within the bounds of the builder generated code.  To this end I did put a request into Paul to add the capability of selecting the TOP/BOT text alignment.  Its not so important that it works on the builder text field, just that the alignment fields get entered into the xxx_GSLC.h file to minimize my editing on each pass.

Thanks @farfarfromhome for the followup.... good to hear that it is working.
I understand from Paul’s post in the Builder repo that he may have addressed your second request in the v0.16 release.

Hi Cal
Yes, I downloaded this evening and everything is working on the builder.
I am making great progress and am very enthusiastic with GUIslice and the Builder.  I made sure I starred Paul today, he sounds a bit down!
From: Calvin Hass<EMAIL_ADDRESS>Sent: Wednesday, November 11, 2020 7:09 PM
To: ImpulseAdventure/GUIslice
Cc: farfarfromhome; Mention
Subject: Re: [ImpulseAdventure/GUIslice] TOP/BOT alignment of text within Text Button when frame is selected (#289)
Thanks @farfarfromhome https://github.com/farfarfromhome  for the followup.... good to hear that it is working.
I understand from Paul’s post in the Builder repo that he may have addressed your second request in the v0.16 release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/ImpulseAdventure/GUIslice/issues/289#issuecomment-725734634 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AKZZKJCUCFGUZ7TXT6VP2H3SPMRRLANCNFSM4TPZC32A .  https://github.com/notifications/beacon/AKZZKJAGHVOW4TJ6VKAARBDSPMRRLA5CNFSM4TPZC32KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFNA5J2Q.gif


Docs/paper response

This is for two issues during paper review:

Deletes overstating language.
Adds an extended example.

Codecov Report

Merging #35 (54d3b4e) into main (767726f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #35   +/-   ##
=======================================
  Coverage   90.46%   90.46%
=======================================
  Files           9        9
  Lines         860      860
=======================================
  Hits          778      778
  Misses         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 767726f...54d3b4e. Read the comment docs.


ValueError: signal only works in main thread of the main interpreter | not working with streamlit

ValueError: signal only works in main thread of the main interpreter
Traceback:
File "/home/ram/.cache/pypoetry/virtualenvs/xyz-project-py3.11/lib/python3.11/site-packages/clocklock/decorator.py", line 45, in wrapper
    signal.signal(signal.SIGALRM, _timeout_handler)
File "/home/ram/miniconda3/lib/python3.11/signal.py", line 56, in signal
    handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

will work on that on next release


[MaybeInplace] Move into Organization

@avik-pal you should give the #pkg-registration channel on slack a ping to get this merged.


[SPARK-46530][PYTHON][SQL] Check Python executable when looking up available Data Sources

What changes were proposed in this pull request?
This PR is a sort of followup of https://github.com/apache/spark/pull/44504 but addresses a separate issue. This PR proposes to check:

if Python executable exists when looking up available Python Data Sources.
if PySpark source and Py4J files exist - for the case users don't have them in their machine (and don't use PySpark).

Why are the changes needed?
For some OSes such as Windows, or minimized Docker containers, there is no Python installed, and it will just fail even when users want to use Scala only. We should check the Python executable, and skip if that does not exist.
Does this PR introduce any user-facing change?
No because the main change has not been released out yet.
How was this patch tested?
Manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @ueshin 🙏

I have reversed https://github.com/apache/spark/pull/44504 (CommitID: 229a4eaf547e5c263c749bd53f7f9a89f4a9bea9). Based on the current running results, the Run Spark on Kubernetes Integration test failure of GA is related to this.

Thanks. Let me fix up here.

@LuciferYang @dongjoon-hyun @zhengruifeng if anyone is online can you merge this one please ?  I won't be away from keyboard today.. and this technically fixes the build.

merged to master

Thx thx

late LGTM, thanks @HyukjinKwon for fixing this


NilClass error on attributes

I know this can be a common error in chef if attributes aren't found but I can't seem to get it resolved. This is the output at the end of the chef run.
==> default: [2015-08-05T17:58:17+00:00] INFO: Starting Chef Run for noah-berkshelf
==> default: [2015-08-05T17:58:17+00:00] INFO: Running start handlers
==> default: [2015-08-05T17:58:17+00:00] INFO: Start handlers complete.
==> default: /tmp/vagrant-chef/ce43313c9572ad145ac7ec26866e5732/cookbooks/homebrew/libraries/homebrew_package.rb:26: warning: toplevel constant Homebrew referenced by Chef::Provider::Package::Homebrew
==> default:
==> default: ================================================================================
==> default: Recipe Compile Error in /tmp/vagrant-chef/ce43313c9572ad145ac7ec26866e5732/cookbooks/varnish/attributes/default.rb
==> default: ================================================================================
==> default:
==> default:
==> default: NoMethodError
==> default: -------------
==> default: undefined method `[]=' for nil:NilClass
==> default:
==> default:
==> default: Cookbook Trace:
==> default: ---------------
==> default:
==> default:   /tmp/vagrant-chef/ce43313c9572ad145ac7ec26866e5732/cookbooks/varnish/attributes/default.rb:2:in `from_file'
==> default:
==> default:
==> default: Relevant File Content:
==> default: ----------------------
==> default: /tmp/vagrant-chef/ce43313c9572ad145ac7ec26866e5732/cookbooks/varnish/attributes/default.rb:
==> default:
==> default:   1:  if platform_family?('debian')
==> default:   2>>   default['varnish']['default'] = '/etc/default/varnish'
==> default:   3:  else
==> default:   4:    default['varnish']['default'] = '/etc/sysconfig/varnish'
==> default:   5:  end
==> default:   6:
==> default:   7:  default['varnish']['version'] = '4.0'
==> default:   8:
==> default:   9:  default['varnish']['dir'] = '/etc/varnish'
==> default:  10:  default['varnish']['start'] = 'yes'
==> default:  11:  default['varnish']['nfiles'] = 131_072
==> default:
==> default:
==> default:
==> default: [2015-08-05T17:58:18+00:00] ERROR: Running exception handlers
==> default: [2015-08-05T17:58:18+00:00] ERROR: Exception handlers complete
==> default: [2015-08-05T17:58:18+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
==> default: [2015-08-05T17:58:18+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
Chef never successfully completed! Any errors should be visible in the
output above. Please fix your recipes so that they properly complete.

I've tried everything, copying the cookbook locally to make sure it was included correctly. I even copied the attributes into a brand new cookbook skeleton and made the default recipe just puts one of the attributes. Whats even stranger is that if I change the root name of the attribute, [varnish] to something else; it works.
I've using the ChefDK, Vagrant and Berkshelf, but dropping the chef version to 11.6 which matches the version Rightscale is using.
I'm requiring this cookbook (at the 1.0.2 version) in the metadata and including it in a separate recipe. Its the same way I'm installing/configuring apache, php and nodejs and i don't have any issues with those cookbooks.

Hi there -- I just checked out v1.0.2, created test kitchen suites with chef 11.18.12 and 11.16.4 and varnish (v3 and v4), and I was able to successfully converge successfully. Is it possible you're using chefspec or testing with chef-solo or something else? I can't reproduce this.
We're going to need a self-contained, reproducible example to really be able to help you further.

Locally I'm using chef-solo. However, I did try converging in Rightscale and it was successful so I'm thinking its an issue with chef-solo. It's confusing because, I have other cookbooks that I'm loading and don't have the same issues. Still investigating. Thanks!

Just searching around on Google, the most common cause of this in chef-solo is a missing depends 'varnish' in your cookbook's metadata.rb file. Can you confirm that's in place?

I have included the depends in the metadata but still no change.

We're going to need a self-contained, reproducible example to really be able to help you further.

Sorry @delianides, I'm just not sure what else to do to help you reproduce this. We may need a workable example that causes the problem.

Going to close this, as I haven't heard anything back. I'm not sure we can do much to help since we can't reproduce and it appears to be specific to chef-solo and very strange that the Chef Mash would complain about a missing key.


[OTBN] Reset requirements

Following a comment from @moidx here, I think it's worth discussing a bit the finer grain reset control for OTBN.
The current reset definition does not have an OTBN specific reset that can be manipulated by software, we can certainly add one here, or OTBN can provide one locally.
The original reason for not allowing a peripheral specific reset is because there were worries this could be used as an attack (for example a reset releases any access restriction and the dmem is made readeable).
We might want to discuss a bit then what sort of reset control makes sense.  Blocks like OTBN are a bit more transactional by nature, so I think there are periods where it is safe to issue a reset, and periods where it is not.  So as long as we are clear about the reset expectation and when it can be used / accessed, there's no harm in adding it.
@moidx
you mentioned in the other comment there could be a reset before OTBN operation, and a clean-up step afterwards.  Do you envision both being done by the host processor? Or would the clean-up step potentially be done by code downloaded into OTBN? I imagine the clean-up would involve wiping away keys and any sensitive material left over in dmem.

Just to move the context to this thread, the OTBN reset discussed here is mainly to enable handling of some error conditions without requiring a system reset, for example, unexpected timeouts. This reset could be reduced to reseting the OTBN control logic to be able to bring it back to ready state.
Is the concern that the code running on the host may not be trusted?
It is worth noting that the OTBN execution model relies on a trusted host, for loading initial parameters and polling for completion, so I think in various cases the host could emulate OTBN if it wanted to. Based on this, I think exposing the DMEM state between OTBN reset and clean-up is probably ok.  Please let me know if this claim is too relaxed :)
@tjaychen, yes as you mentioned, clean-up would involve wiping away keys and sensitive material [with random data]. To summarize the clean-up cases mentioned above:

After successful execution, host reads results before secrets are cleared from DMEM. Alternatively, OTBN could also clear
secrets before setting the done status.
After a failure is detected. This could be implemented as OTBN reset+clear.
Before starting execution of a new operation. This could also be implemented as OTB reset+clear.

And to summarize the clean-up functions being discussed:
DMEM secure clear:

direct host-side
triggered by host and handled in OTBN:

OTBN-code via secure clear function call with obfuscation quality RND source instruction.
OTBN-hw via hw control logic

WDRs secure clear:

triggered by host and handled in OTBN:

OTBN-code handled by runtime, with obfuscation quality RND source instruction.
OTBN-hw via hw control logic

We'll have the host-side option available, but I would also like to also discuss the OTBN-code OTBN-hw options. Thoughts?

@moidx
yes what you say makes sense.
From my perspective, I do agree the host system is in the same trusted boundary, otherwise, the host would never be able to supply keys or see the results of a bignum operation.
Your points on secure clearing make sense also, although that sounds more like a managed sequence than it does a big reset button.  Maybe @imphil and @GregAC can comment a bit more on how they envision this being implemented.  I tend to think that this is better handled with HW, with host software it may take quite a bit of time and I don't think is completely necessary.
Finally, regarding reset.  I think my main point is that we should not allow OTBN to be reset when it is ongoing a transaction.  This is related to the other issue where @GregAC is discussing accessibility of OTBN during a transaction.   If OTBN does feel like it needs a clean-slate reset, I would recommend following the same approach of only allowing software to provide a hint, and such a reset can only happen when OTBN is "not" busy or a timeout has happened (OTBN has hung - this is kind of a localized watchdog).   This way we prevent any glitch attacks (at least in certain areas of the reset manager) and also prevent software from accidentally shooting itself in the foot.
Finally, regarding where to implement such a reset.  Remember that resets will all need some kind of DFT bypass, so I would also recommend pulling that into reset manager instead of implementing a local software reset inside OTBN.
@cdgori , do you see any red flags about what I said?

My 2c:
-It seems like we are in a bit of a catch-22 because we don't want to allow this reset during an ongoing transaction, but one of the proposed uses of this reset is to clear a hung/stuck OTBN?  (At which time, OTBN is almost certainly going to think it's in the middle of a transaction).  I guess @tjaychen is proposing a watchdog that will accept the reset-vote when it times out?
-I was trying to think of a case where you might not want to clear all the DMEM, like you are chaining crypto operations, or had to do some precomputation steps on the key (or curve?) that you would use across multiple signing/key-exchange operations, and therefore you wouldn't want to throw away that intermediate.  I couldn't come up with one, but if others could think about that, it might be helpful.  I can also make a good argument that it's safer to always start from scratch, regardless of performance targets.  :)
-The point about DFT bypassing means I strongly agree with @tjaychen about putting the reset into reset manager rather than generating it locally.
What's the use-case for the OTBN-code reset option?  I'd like to get down to a standard formulation and reduce the number of paths we have to consider, so if that one can be removed I think it's a win.  (If there's a reason for it, that's fine too, I just don't know what it is.)

@GregAC @imphil
what do you guys think on this issue? If you've already implemented something, feel free to close this

@GregAC @imphil
just wanted to check in with you guys with what's planned today.
This issue might be completely outdated and we can just close it.

i think this issue is stale now and the resolution is all clear across multiple other issues.
I will close this.


Minor changes to dev instructions

State that Python 3.7+ is required for dev, because of some of the unit tests.
Remove external tool dependency.
Add quotes to prevent accidental shell expansion.
Each of these changes is in its own commit, so I or you can easily revert one of the changes.

Thanks!


Bug fix in conn, pr

Simple bug fix in conn.
For pagerank, this fix avoids the use of atomic operations and instead scans the vertices once every iteration and updates zero in-degree vertices and dangling sum. This requires keeping track of the in-degrees as well as out-degrees.

Thanks for you contribution!


Directory for windows.

The directory for windows must be changed or you can set a conditional if the script runs on windows:
history_chrome_files = glob.glob(os.path.expanduser("~")+"\\AppData\\Local\\Google\\Chrome\\User Data\\Default\\History")
history_firefox_files = glob.glob(os.path.expanduser("~")+"\\AppData\\Roaming\\Mozilla\\Firefox\\Profiles\\*\\places.sqlite")

Made a PR.

Closed because of #3


First Angular2 Prototype

First prototype for an Angular2 version of the directive.
I've only manually tested the most basic case.
Problems and head-scratchers:

not sure how to handle "THROTTLE_MILLISECONDS", need to read more docs on ng2 as they become available
not sure how to handle "infiniteScrollListenForEvent" in a clean manner. I need to read more about how ng2 handles events and scoping
why do you need scope.$eval on infiniteScrollImmediateCheck?
the rationale behind the $watch-ers is that the bound value could change? (e.g. infiniteScrollDistance={someVarInControllerScope} ?)
there was a variable "context" in func throttle which wasn't used anywhere, hopefully I didn't miss anything
ng2 doesn't have an $interval service. My implementation of $interval(callback, delay, count) is a bit naive. I'd like to check the actual ng1 code
I'm not sure why you needed "angular.element"
Should the first PR take care of protractor \ tests \ build or can we think about it later once the codebase stabilizes?

Thank you for the effort you put on it @sphaso. Here are my answers:

You can do without it at the moment.
TBH, I don't remember
Yes, this is the idea
Yes, you can remove it.
This is to remove the dependency to jQuery
Definitely in my point of view. You can even remove the tests that are related to features you are not porting at the moment, but we need passing tests for all the claimed features :)

@sroze sorry this is taking a bit long. My main dev machine was in bad shape and had to borrow another pc to run the tests. I have 33 on 33 green specs. I hope they're not false positives :)

@sroze feel free to let me know if there's anything else you'd like me to do regarding this PR


feat: querying from view works

I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3729
What's changed and what's your intention?
Make querying view works.
Main changes:

Adds ViewInfoCache for caching ViewValueInfo. @WenyXu
Destroy view metadata in DropDatabaseCursor .
Extract and rewrite all table names in view logical plan. Saves the table names into view info.
Add SubstraitPlanDecoder trait and implement it in the query crate, which decodes the logical plan from bytes, takes care of the session state, etc.
Resolve view in DfTableSourceProvider. It queries the view info and tries to decode it, then wraps the logical plan into ViewTable.
Some refactoring:  move the PromQL planner to the query crate, and remove some unused errors, etc.

Todo:

Supports column names(alias) for view.
Save the optimized logical plan for view.  There are some serialization issues when saving the optimized plan. @waynexia

Checklist

[x] I have written the necessary rustdoc comments.
[x] I have added the necessary unit tests and integration tests.
[ ] This PR requires documentation updates.

@WenyXu Please take a look at the cache section

@WenyXu Could please take a look at the cache section?

The cache part, LGTM

@waynexia Please take a look.

we should not depend on test-integration. where is it used?

Sorry, i don't get the point. This patch doesn't change the dependencies in test-integration or make other crates depend on it.


(maint) Update JSON schema paths

Previously the paths for validating JSON schema templates only worked when running from Rspec tests as they were relative to the root directory of Bolt. This commit handles the paths accordingly.

I built pe-bolt-server from this PR and have run a winrm and ssh task using the following VMs
Bolt server vm (ubuntu 1604): j4v2varc0vcgmcr.delivery.puppetlabs.net
Winrm target(win-2016-x86_64): rpqfrxu9mbnk2q7.delivery.puppetlabs.net
I will extend the life of these VMs if reviewer wants to inspect.
winrm_req.json and ssh_req.json are at /root
WinRm test invocation
curl -X POST -H "Content-Type: application/json" -d @winrm_req.json --cert /etc/puppetlabs/bolt-server/ssl/cert.pem --key /etc/puppetlabs/bolt-server/ssl/key.pem -k https://j4v2varc0vcgmcr.delivery.puppetlabs.net:62658/winrm/run_task

output
{
  "node": "rpqfrxu9mbnk2q7.delivery.puppetlabs.net",
  "status": "success",
  "result": {
    "_output": "Hello world\r\n"
  }
}

ssh invocation
root@j4v2varc0vcgmcr:~# curl -X POST -H "Content-Type: application/json" -d @ssh_req.json --cert /etc/puppetlabs/bolt-server/ssl/cert.pem --key /etc/puppetlabs/bolt-server/ssl/key.pem -k https://j4v2varc0vcgmcr.delivery.puppetlabs.net:62658/ssh/run_task

output
{
  "node": "j4v2varc0vcgmcr.delivery.puppetlabs.net",
  "status": "success",
  "result": {
    "_output": "Hello world\n"
  }
}

CLA signed by all contributors.


attempt to init the db on every request

@gabemontero ptal

igtm (never programmed in nodejs, but you are checking db prior to any refs to count)

if all is well, this will finally pass:
https://ci.openshift.redhat.com/jenkins/view/Origin Test Jobs/job/origin_extended_image_tests/283/

Are you in the process of updating the origin/example/quickstarts version
as well ?
On Wed, Jun 29, 2016 at 2:19 PM, Ben Parees<EMAIL_ADDRESS>wrote:

if all is well, this will finally pass:
https://ci.openshift.redhat.com/jenkins/view/Origin Test Jobs/job/origin_extended_image_tests/283/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/nodejs-ex/pull/52#issuecomment-229443064,
or mute the thread
https://github.com/notifications/unsubscribe/ADbadHsRta_yyZEKr7cRJcymByhlcMbjks5qQrchgaJpZM4JBaBc
.

Are you in the process of updating the origin/example/quickstarts version as well ?

?
the quickstart should be referencing this repo.

duh, you are changing the app, not the template - my bad
On Wed, Jun 29, 2016 at 2:23 PM, Ben Parees<EMAIL_ADDRESS>wrote:

Are you in the process of updating the origin/example/quickstarts version
as well ?
?
the quickstart should be referencing this repo.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/nodejs-ex/pull/52#issuecomment-229444490,
or mute the thread
https://github.com/notifications/unsubscribe/ADbadIi5zqLAwCn5Qa9x5YHCnFrr3lGfks5qQrg8gaJpZM4JBaBc
.

i wanted to do this with promises, the problem is that we have:
 "engine": {
    "node": "*",
    "npm": "*"
},

which pretty much takes the possibility away from us: http://stackoverflow.com/questions/21564993/native-support-for-promises-in-node-js since earlier versions of nodejs aren't compatible and it would mean introducing another dependency (bluebird, other promises lib) just for a simple example, making it complicated for not much added value.
so this is the best solution at this point. (this whole example makes us look like we dislike coding in nodejs though) :))
btw, this fixes: https://github.com/openshift/nodejs-ex/issues/17

this whole example makes us look like we dislike coding in nodejs though

sssssshhhhhhhhh!


npm-shrinkwrap for fsevents (1.0.16) references lunabuild.akamai.com instead of registry.npmjs.org

Hi there, we're seeing the same issue as https://github.com/strongloop/fsevents/issues/141, except I'm updating from 1.0.15 -> 1.0.16. It's referencing lunabuild.akamai.com in my shrinkwrap instead of registry.npmjs.org
An example:
"ansi-regex": {
          "version": "2.0.0",
          "from"<EMAIL_ADDRESS><3.0.0",
          "resolved": "https://lunabuild.akamai.com/nexus/content/groups/npm-all/ansi-regex/-/ansi-regex-2.0.0.tgz"
        }

Sorry if you're not the right person to cc here, @es128. It looks like the last time you were able to resolve this and the update to 1.0.16 might be from you as well. Just putting it on your radar. Thanks!

Ugh! My bad, fixing now

Should be resolved. I need to figure out where to inject an automatic npm cache clean into the process to prevent this from happening again.

Thanks for the quick fix! Cheers.

inject an automatic npm cache clean into the process

Including this and a fresh npm install in the prepublish script results in an infinite loop. Would appreciate if someone has any suggestions.


[Bug][Jira] Data too long for column 'component' error while collecting/processing data

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Data too long for column 'component' error while collecting/processing data. I have seen some similar issues, but in this case, the data type doesn't seem to be a
I checked the db and in the _tool_jira_issues table found a components field where the data type is text (doesn't appear to be a character limited field). Not exactly sure how I might track down the offending jira issue for further troubleshooting.
Interestingly, my first collection ran fine. Only subsequent ones have had this error.
Attempted to upgrade to latest version, also deleted and recreated the project and connection without change.
attached stack trace -- stack trace: | github.com/apache/incubator-devlake/server/services.runPipeline | /app/server/services/pipeline_runner.go:79 | [...repeated from below...] Wraps: (2) Error running pipeline 18. Wraps: (3) attached stack trace -- stack trace: | github.com/apache/incubator-devlake/server/services.RunTasksStandalone | /app/server/services/task.go:217 | github.com/apache/incubator-devlake/server/services.(*pipelineRunner).runPipelineStandalone.func1 | /app/server/services/pipeline_runner.go:42 | github.com/apache/incubator-devlake/core/runner.runPipelineTasks | /app/core/runner/run_pipeline.go:90 | github.com/apache/incubator-devlake/core/runner.RunPipeline | /app/core/runner/run_pipeline.go:54 | github.com/apache/incubator-devlake/server/services.(*pipelineRunner).runPipelineStandalone | /app/server/services/pipeline_runner.go:38 | github.com/apache/incubator-devlake/server/services.runPipeline | /app/server/services/pipeline_runner.go:76 | github.com/apache/incubator-devlake/server/services.RunPipelineInQueue.func1 | /app/server/services/pipeline.go:349 | runtime.goexit | /usr/local/go/src/runtime/asm_arm64.s:1172 Wraps: (4) attached stack trace | -- stack trace: | | github.com/apache/incubator-devlake/server/services.RunTasksStandalone.func1 | | /app/server/services/task.go:189 | Wraps: (2) Error running task 223. | Wraps: (3) attached stack trace | -- stack trace: | | github.com/apache/incubator-devlake/core/runner.RunPluginSubTasks | | /app/core/runner/run_task.go:333 | | github.com/apache/incubator-devlake/core/runner.RunPluginTask | | /app/core/runner/run_task.go:165 | | github.com/apache/incubator-devlake/core/runner.RunTask | | /app/core/runner/run_task.go:139 | | github.com/apache/incubator-devlake/server/services.runTaskStandalone | | /app/server/services/task_runner.go:114 | | github.com/apache/incubator-devlake/server/services.RunTasksStandalone.func1 | | /app/server/services/task.go:187 | Wraps: (4) subtask convertIssues ended unexpectedly | Wraps: (5) attached stack trace | -- stack trace: | | github.com/apache/incubator-devlake/helpers/pluginhelper/api.(*StatefulDataConverter[...]).Execute | | /app/helpers/pluginhelper/api/data_convertor_stateful.go:184 | | [...repeated from below...] | Wraps: (6) error adding result to batch (500) | Wraps: (7) attached stack trace | -- stack trace: | | github.com/apache/incubator-devlake/impls/dalgorm.(*Dalgorm).convertGormError | | /app/impls/dalgorm/dalgorm.go:547 | | github.com/apache/incubator-devlake/impls/dalgorm.(*Dalgorm).CreateOrUpdate | | /app/impls/dalgorm/dalgorm.go:265 | | github.com/apache/incubator-devlake/helpers/pluginhelper/api.(*BatchSave).flushWithoutLocking | | /app/helpers/pluginhelper/api/batch_save.go:131 | | github.com/apache/incubator-devlake/helpers/pluginhelper/api.(*BatchSave).Add | | /app/helpers/pluginhelper/api/batch_save.go:109 | | github.com/apache/incubator-devlake/helpers/pluginhelper/api.(*StatefulDataConverter[...]).Execute | | /app/helpers/pluginhelper/api/data_convertor_stateful.go:182 | | github.com/apache/incubator-devlake/plugins/jira/tasks.ConvertIssues | | /app/plugins/jira/tasks/issue_convertor.go:164 | | github.com/apache/incubator-devlake/core/runner.runSubtask | | /app/core/runner/run_task.go:425 | | github.com/apache/incubator-devlake/core/runner.RunPluginSubTasks | | /app/core/runner/run_task.go:330 | | github.com/apache/incubator-devlake/core/runner.RunPluginTask | | /app/core/runner/run_task.go:165 | | github.com/apache/incubator-devlake/core/runner.RunTask | | /app/core/runner/run_task.go:139 | | github.com/apache/incubator-devlake/server/services.runTaskStandalone | | /app/server/services/task_runner.go:114 | | github.com/apache/incubator-devlake/server/services.RunTasksStandalone.func1 | | /app/server/services/task.go:187 | | runtime.goexit | | /usr/local/go/src/runtime/asm_arm64.s:1172 | Wraps: (8) Error 1406 (22001): Data too long for column 'component' at row 174 (500) | Wraps: (9) Error 1406 (22001): Data too long for column 'component' at row 174 | Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *withstack.withStack (4) *errutil.withPrefix (5) *withstack.withStack (6) *errutil.withPrefix (7) *withstack.withStack (8) *errutil.withPrefix (9) *mysql.MySQLError Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *withstack.withStack (4) *errutil.leafError

What do you expect to happen
For the collection to run appropriately without error.
How to reproduce
Create a Jira connection with, I assume, very long component names associated with some issues.
Anything else
No response
Version
v1.0.2-beta5
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@dosu thanks bot :D it does look like it's already the text type

I've deleted everything and started the project fresh. Since I just got everything setup this isn't too much of an issue and it is working for now. If I hit the problem again I'll resurface. Once things are setup more, this process might be more onerous but for now I think I'm OK.

Re-opening. The issue has re-emerged when trying to collect 6mo of data (rather than I think 1mo). Is there a good way to identify the specific Jira issues that might cause the error?

What was the name of the failing subtask?


Improvements to api_report.py

Add Stability level 1 screening criteria;
Modifies the code to storage the cross-coupling range for each rotor stage (or impeller). This is useful to distinguish the cross-coupling evaluation for different rotor_types (between bearings, overhung...);
Add .summary() method;
Add summary for stability level 1

Codecov Report

Merging #366 into master will increase coverage by 1.21%.
The diff coverage is 64.07%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   73.93%   75.15%   +1.21%
==========================================
  Files          14       14
  Lines        3741     3803      +62
==========================================
+ Hits         2766     2858      +92
+ Misses        975      945      -30

Impacted Files
Coverage Δ

ross/api_report.py
69.18% <64.07%> (+17.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e6909...3106c01. Read the comment docs.

I have facing a strange behavior from the CI's in this PR.
First of all, Travis was returning an error testing on Python 3.7 when running a numpy.linspace() command. Well, I just changed what I was doing and fixed the problem. However, now. the Appveyor is point an error while running test_fluid_flow.py, which does not make any sense because it has not been changed at all.


Deprecate color_dict_to_colormap

🧰 Task
in napari/utils/colormaps/colormap_utils.py, color_dict_to_colormap seem to not be used anywhere. I believe the last usage was rencently removed as part of #3308. It should likely get a cycle of deprecation (with a DeprecationWarning or FutureWarning and a notice of future removal).
Once deprecated, open an issue for removal.

May I take on this issue?

May I take on this issue?

You do not need to ask for permission to work on issues. You can just say that you've started to work on this, and send a PR with relevant changes.
Looking forward to your contribution.


Duplicate elements of type 'PBXFileElement' were found in a Set

We are seeing this error regularly:
⚙  Generating plists...
⚙  Generating project...
Fatal error: Duplicate elements of type 'PBXFileElement' were found in a Set.
This usually means either that the type violates Hashable's requirements, or

Our project is quite large, but we have no insight into what is going on here. Re-running xcodegen solves this, so it's likely a race condition somewhere. I've got a PR which adds some debug logging to hopefully help try and track it down: https://github.com/yonaskolb/XcodeGen/pull/1128

Any updates on this?

Gave a look at this yesterday, as we were having the same issue breaking our CI randomly.
Basically, XcodeProj's PBXObject and inherited classes are not respecting Hashable requirements. Two different instances (not equal) can have the same hash, which leads randomly to this issue.
Tried to fix that naively, to realise it was more complex, so closed my Fix above.

Does someone find a fix for this yet?

Thankfully my new project reproduced the issue much more frequently and I was able to create a fix: https://github.com/yonaskolb/XcodeGen/pull/1341

Note: There may be multiple reasons for this error, but my fix corrects the one I'm seeing now at least. Try it and see if it fixes your own.

Yes, it should work, this is how I fixed the issues on our side, avoiding the collision, by removing some trailing /.


[ui] File menu open only allow to open the text version of a diagram file.

Selecting File -> Open --> open a dialog, then the user can select a file then open: ==> no choice to open the Diagram editor for that file (Can be fixed with the default editor for a file extension)

This looks more like an issue for Theia, how to handle multiple openers for a file.


Update installation instructions

It appears libstb and zxing-cpp are required (for the QR module, at least on master; looks like they're actually not required for the current release), but were not included in the dependencies.

yeah, tbh I might just make a separate file for installation instructions since the list is getting pretty long
merging


Scoped slot

Is it possible to get indication if slot is scoped?
Is it possible to add property to the slot for scope (like description)

I tried with vue-styleguidist v3.0.9 but it's not working:   the slot definition is simply ignored.
example that failed (tested using Modal.vue source component):
<template slot-scope="{item}">

    <slot name="footer"></slot>

</template>

Thanks @stephsavoie, I will add this test to the e2e. I hope to look at it this week.

Hello @stephsavoie , I believe that the template you gave is the usage of a scoped slot, not the slot itself. I added a scoped flag to slots so that you can know if it has bindings or not.
If a slot has bindings, it is automatically scoping its content. This would give access insidde of your template to the content of the item.
See documentation here https://vuejs.org/v2/guide/components-slots.html#Scoped-Slots
this is a scoped slot:

  <slot v-bind:user="user">
    {{ user.lastName }}
  </slot>

and here is how one uses it:
<current-user>
  <template v-slot:default="slotProps">
    {{ slotProps.user.firstName }}
  </template>
</current-user>

and a quick code sandbox to understand it better
https://codesandbox.io/embed/40mjwn311x?fontsize=14


Make Network Creation in Testing Less "Magic"

The network creation code in our testing has a lot of routing/policies/ips hardcoded directly for the test node we have. This should be changed to be more independent.

https://github.com/microsoft/windows-container-networking/pull/47
Does make complete the spirit of what was intended.


Add a OpenAPI endpoint plugin

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:
/kind bug

/kind feature
What happened:
What you expected to happen:
A plugin which is easy to register an endpoint to serve OpenAPI documents
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

/priority P1

This issue is expired.


Duplicated enumerations in swagger definitions

Version 2.6.1
Enums are currently being listed inline in the swagger output, causing enums to be generated as inner class. They should be referenced via "$ref" like classes are. Attached are two swagger json definitions, one provided by springfox and the other fixed by hand.
This is problematic for clients that attempt to use the model files, as they cannot be reused across api endpoints, as each generated model will contain a copy of the enum. This is especially problematic in apis that define enums with large sets of values, such as an enum set of the 249 ISO 3166 alpha 2 or 3 letter country codes.
Example enum:
public enum Crest {     ONE,     TWO,     THREE, }
Example class:
public class Obj {
    private Crest crest;

    public Crest getCrest() {
        return crest;
    }

    public void setCrest(Crest crest) {
        this.crest = crest;
    }
}

Incorrect swagger:
"definitions": {
  "Obj": {
    "type": "object",
    "properties": {
      "crest": {
        "type": "string",
        "enum": [
          "ONE",
          "TWO",
          "THREE"
        ]
      }
    }
  },
}

Resulting codegen:
// ... snip ...
public class Obj {
  /**
   * Gets or Sets crest
   */
  public enum CrestEnum {
    ONE("ONE"),

    TWO("TWO"),

    THREE("THREE");

    private String value;

    CrestEnum(String value) {
      this.value = value;
    }
  }
  // ... snip ...
}

Correct swagger:
"definitions": {
  "Obj": {
    "type": "object",
    "properties": {
      "crest": {
        "$ref": "#/definitions/Crest"
      }
    }
  },
  "Crest": {
    "type": "string",
    "enum": [
      "ONE",
      "TWO",
      "THREE"
    ]
  },
}

Resulting codegen:
// ... snip ...
public enum Crest {

  ONE("ONE"),

  TWO("TWO"),

  THREE("THREE");

  private String value;

  Crest(String value) {
    this.value = value;
  }
  // ... snip ...
}

// ... snip ...
public class Obj {
  @JsonProperty("crest")
  private Crest crest = null;

  // ... snip ...
  public Crest getCrest() {
    return crest;
  }

  public void setCrest(Crest crest) {
    this.crest = crest;
  }
  // ... snip ...
 The swagger-codegen is incorrect in its rendering of the enum.

It is perfectly valid, but it's a pain to use. Every time an enum is referenced it gets duplicated, that's why we put all of our objects in the "definitions" block in the first place. We wouldn't want re-definitions of the same model, and that's the same reason why we don't want duplicated enums.
Is there any option that we can use to not have duplicated enums?
After all, springfox generates
"Obj": {
  "type": "object",
  "properties": {
    "crest": {
      "type": "string",
      "enum": [
        "ONE",
        "TWO",
        "THREE"
      ]
    }
  }
},
"Obj3": {
  "type": "object",
  "properties": {
    "crest": {
      "type": "string",
      "enum": [
        "ONE",
        "TWO",
        "THREE"
      ]
    },
    "obj": {
      "$ref": "#/definitions/Obj"
    },
    "value": {
      "type": "integer",
      "format": "int32"
    }
  }
}

instead of
"Obj": {
  "type": "object",
  "properties": {
    "crest": {
      "type": "string",
      "enum": [
        "ONE",
        "TWO",
        "THREE"
      ]
    }
  }
},
"Obj3": {
  "type": "object",
  "properties": {
    "crest": {
      "type": "string",
      "enum": [
        "ONE",
        "TWO",
        "THREE"
      ]
    },
    "obj": {
      "Obj": {
        "type": "object",
        "properties": {
          "crest": {
            "type": "string",
            "enum": [
              "ONE",
              "TWO",
              "THREE"
            ]
          }
        }
        }
    },
    "value": {
      "type": "integer",
      "format": "int32"
    }
  }
}

because it's redundant.

@dilipkrish How is the codegen supposed to de-duplicate enums? Having spring fox regenerate the same enum multiple times is incorrect. If you have three objects that reference the same enum then spring fox generates three enums.

@toddbyrne I see where you are coming from. However I contend that it is not in scope of this library.

Firstly and most importantly, the following definition is just not valid json schema. Enums are not first class objects that can be defined in the definitions section.

"Crest": {
    "type": "string",
    "enum": [
      "ONE",
      "TWO",
      "THREE"
    ]
  }

Secondly, even if it were valid, it is just weird when you take out the fact that the type of crest is an enum. Let me illustrate with an example.

"Obj1": {
  "type": "object",
  "properties": {
    "crest": {
      "type": "string",
      "enum": [
        "ONE",
        "TWO",
        "THREE"
      ]
    }
  }
},
"Obj2": {
  "type": "object",
  "properties": {
    "crest": {
      "type": "string"
    }
  }
}

In the above example Obj1 and Obj2 are pretty much equivalent. Just that one has crest which is any string that you provide (Obj2) and the other is a string  with a fixed set of values ONE, TWO and THREE (Obj1). Semantically, no different that one having maxlength and one not having any size limit.

It is not an easy problem to decide when to make a model a reference and when to inline it especially for scalar values like string.
Lastly, swagger is a language agnostic representation of models. So only code-gen tools will know how to interpret and deal with it best. What is the guarantee that the representation suggested above will work great for a ruby or a clojure client code generation.

It is valid schema. You can verify it on http://editor.swagger.io/#!/ using my attached swagger json files, which can be used to generate clients using swagger-codegen. Verify it against what springfox currently generates.
The name Crest isn't special, it's just a named enum. I could have just as easily named it Numbers.
If the enum is not an internal class, it should always be a ref.
The ruby client has no problems being generated from the corrected swagger definition files. Ruby definition of the enum below

module SwaggerClient
  class Crest
    ONE = "ONE".freeze
    TWO = "TWO".freeze
    THREE = "THREE".freeze
  end
end

Also clojure appears to be a moot point because no model files are generated regardless.

It is valid schema.

That is correct. Last time I looked at it (#1250) it wasn't valid.
However, I'd be careful not to drive this library based on language implementations of swagger-codegen.

That's fine, we'd rather like to see springfox match the reference implementation anyways.
Jax-RS for example also separates out enums. I have an example forked here https://github.com/Sineaggi/swagger-jersey2-jetty/commit/011c4401108af920520d2d4d8e1c799f6067812c which generates {"swagger":"2.0","info":{"version":"1.0.0"},"basePath":"/","tags":[{"name":"entities"}],"paths":{"/entities/all":{"get":{"tags":["entities"],"summary":"Return all entities","description":"Returns all entities in the collection","operationId":"getResult","produces":["application/json"],"parameters":[],"responses":{"200":{"description":"successful operation","schema":{"type":"array","items":{"$ref":"#/definitions/Entity"}}}}}},"/entities/any":{"get":{"tags":["entities"],"summary":"Return one entity","description":"Returns one entity at random","operationId":"getEntity","produces":["application/json"],"parameters":[],"responses":{"200":{"description":"successful operation","schema":{"$ref":"#/definitions/Entity"}}}}},"/entities/one":{"post":{"tags":["entities"],"summary":"Submit one entity","description":"Returns self","operationId":"postEntity","produces":["application/json"],"parameters":[{"in":"body","name":"body","required":false,"schema":{"$ref":"#/definitions/Entity"}}],"responses":{"200":{"description":"successful operation","schema":{"$ref":"#/definitions/Entity"}}}}}},"definitions":{"Entity":{"type":"object","properties":{"name":{"type":"string"},"meh":{"type":"string","enum":["ONE","TWO","THREE"]}}}}}

@dilipkrish, i've implemented what @Sineaggi proposed - instead of inline enum declarations, referencing them using ref. For now i patched some classes locally (for now, to make them extendable, so i could replace some beans that make it possible to create enum refs - to avoid delays in my work related to the PR i'd like to make). I'd like to contribute it back, but i have a question. I think i shouldn't just change the schema generation, but allow the developer to decide if it should be generated using enum references. For that purpose i could add if statements to the code to check if enum references are desired. I guess i could introduce new spring configuration property (smth like springfox.schema.enumrefs=true) to allow generating enum references. But first of all i suspect You could come up with better name and secondly, i'm not sure if i should inject it to all classes that should use it, or should i create a configuration properties class (didn't find one so far) and inject that instead.
@dilipkrish, I'd appreciate if You could add Your thoughts before i start working on the PR. PS. The classes involved with this change are DefaultModelDependencyProvider, DefaultModelProvider, TypeNameExtractor and ModelMapper.

Hi, @dilipkrish.
Haven't heard Your reply - I hope You are still live and kicking ;)
As a first step forward to allow implementing enum references (as proposed by this issue), i created a PR that makes 4 classes extendable - this was enough for me to implement enum references in my own project. It contains really trivial and unharmful changes with tests - it would be fantastic, if that PR could be accepted. Then i wouldn't have to use custom build of this library with the patches included in the PR.
As a next step I'd like to contribute enum references implementation back to this project - but i guess creating/accepting that PR could take much more time. I'd appreciate Your thoughts on it.

@atsu85

I hope You are still live and kicking ;)

Very much... been busy, life happens. I'll take a look and respond in a bit.

@dilipkrish, is this project dead?
If not, please take couple of minutes to review the tiny PR related to this issue, that would at least allow me(or anybody else) to implement this feature without needing to patch springfox classes

@atsu85 this project is not dead. Just that, Id like to make sure we open extensibility only with careful consideration. I'd rather not support an extensibility if I don't have to. Let me look over the PR again and see how I can merge it in (atleast in spirit).
Also @MaksimOrlov is working on a much needed refactoring in #2056 and I'd like to make sure the #1991 is in like with it.
Sorry its been taking so long.

Just to clarify for future posters. The reason this is difficult
  '/test/{id}':
    get:
      tags:
        - api-controller
      summary: two
      operationId: two_1
      consumes:
        - application/json
      produces:
        - '*/*'
      parameters:
        - name: id
          in: path
          description: id
          required: true
          type: string
          enum:
            - ONE
            - TWO
            - THREE
        - name: test
          in: query
          description: id
          required: true
          schema:
            $ref: '#/definitions/Crest'
      responses:
        '200':
          description: OK
          schema:
            type: string
definitions:
  Crest:
    type: string
    enum:
      - ONE
      - TWO
      - THREE

That definitions of enums as a reference is not valid. It will be inlined.

@dilipkrish,

That definitions of enums as a reference is not valid

You have claimed it before, but as @Sineaggi said:

It is valid schema. You can verify it on http://editor.swagger.io/#!/ using my attached swagger json files, which can be used to generate clients using swagger-codegen. Verify it against what springfox currently generates.

it also seemed to me, that You are wrong (can't verify it again, but i'm pretty sure that my api-docs.json with enum references passed validation successfully). Could you reference part of the schema that makes you think it isn't valid?

@dilipkrish,
oh, now i remember one restriction that i found out much later after implementing enum references - enum references are valid in types (for example http request or response body has enum field), but not in method parameters - so You are right that Your example api-doc (that references enums from http GET method parameter) isn't passing validation, but that doesn't mean that springfox shouldn't support enum references in all other cases where enum references are allowed.

but that doesn't mean that springfox shouldn't support enum references in all other cases where enum references are allowed.

@atsu85 not saying that :) Im just saying that the way enums are handled today its hard to support. Since, I don't have the bandwidth at the moment, I'd need some help supporting it. Hence the "help wanted" label.

enum references are valid in types (for example http request or response body has enum field), but not in method parameters

I found that @levequej has opened an issue for OpenApi Specification exactly to address this limitation :)

@dilipkrish I have currently ran into this problem with enum duplication/inlining on my project and it is proving a blocker.  I'd like to assist with this where i can, if there's somewhere you can point me to start looking at?
Manually altering the json isn't really an option due to frequent regenerations etc.  So I am currently looking at using @atsu85's PR which would allow some of this to be developed through extension and injection.

@robertjamesmccullough let me revisit and see what needs to happen. Are u using it for generating clients?

@dilipkrish yes that would be the primary usage for me.

@robertjamesmccullough i am using it to generate client as well, during build. By "manually" i just meant that i am doing the patching myself in a custom code. Also i am actually having a custom endpoint where i provide modified version of the automatically generated JSON, that is without duplications. So it is a viable solutions until it gets implemented in the library itselt, at least in my case.

@robertjamesmccullough i am using it to generate client as well, during build. By "manually" i just meant that i am doing the patching myself in a custom code. Also i am actually having a custom endpoint where i provide modified version of the automatically generated JSON, that is without duplications. So it is a viable solutions until it gets implemented in the library itselt, at least in my case.

@Knut-Fjellheim understandable. I should perhaps be easier to fix once we support oas 3.x

Hi, has there been any progress on this? This effects us generating TypeScript code where we can't use namespaces (React Native), meaning that in order to prevent name clashes in the reexport we need to prepend the class name to each enum declaration.
If you think this is now doable then I'm happy to have a look, but there is quite a lot to learn, so I want to make sure that it's achievable before I commit the time.

Similar use case for us: we now have a number of places where we need to cast generated TS enums, to a different instance of that same Java enum, because they've been generated using this class-specific naming. Would love to hear if this change is thought to be manageable

Any updates on this now that 3.0.0 is out?

This one is a toughie 😳 Its not easy to isolate enumerations easily the way things have been structured. I'll take a look at how I can tease out this feature incrementally so that its possible

Is there any updates after 3.0 released half a year?

4 years...

 It is really dissapointing that it hasn't been fixed since 4 years.
@atsu85 can I find somewhere springfox lib patched by you? It doesn't have to be available via maven repository. Simple jar file will be more than fine and probably will make happy lots of other users.

I've just dropped io.springfox in favour of org.springdoc. Lack of enum refs is unacceptable in my case.
I've just replaced
	implementation "io.springfox:springfox-boot-starter:3.0.0"

with
	implementation 'io.swagger:swagger-annotations:1.6.3'
	implementation 'io.swagger.core.v3:swagger-annotations:2.1.11'
	implementation 'org.springdoc:springdoc-openapi-ui:1.5.10'

additionally i've tweaked some settings in my application.yml, added bean to describe my API and I finally got enums as refs!!!

@amb-jarek good to know that there is a maintained one under the spring umbrella. If you take a look at the commits, this one is pretty much dead.
Thanks for linking it

@dilipkrish can you please help us here?


Unable to post events to HTTP Event Collector using spark logging library

Followed steps as mentioned in blog: https://dev.splunk.com/enterprise/docs/java/logging-java/howtouseloggingjava/enableloghttpjava
But while running code on server unable to push data to HTTP Event Collector.
I tried using log4j2 and java.util.logging and code executes without any error.
Also, I am able to run below command successfully from server:
curl -k "http://host:8088//services/collector/event/1.0" -H "Authorization: Splunk token" -d '{"event": "Hello, world!", "sourcetype": "manual"}'
Below is the code:
public static void main(String[] args) {
Logger logger = java.util.logging.Logger.getLogger("splunkLogger");
     String conf = "handlers=com.splunk.logging.HttpEventCollectorLoggingHandler\n" +
        "com.splunk.logging.HttpEventCollectorLoggingHandler.url=http://host:8088\n" +
        "com.splunk.logging.HttpEventCollectorLoggingHandler.token=token\n" +
        "com.splunk.logging.HttpEventCollectorLoggingHandler.batch_size_count=0\n" +
        "com.splunk.logging.HttpEventCollectorLoggingHandler.level=INFO\n" +
        "com.splunk.logging.HttpEventCollectorLoggingHandler.batch_size_bytes=1\n" +
        "com.splunk.logging.HttpEventCollectorLoggingHandler.batch_interval=0\n" +
        "com.splunk.logging.HttpEventCollectorLoggingHandler.disableCertificateValidation=true\n" +
       // "com.splunk.logging.HttpEventCollectorLoggingHandler.middleware=HttpEventCollectorUnitTestMiddleware\n" +
        "com.splunk.logging.HttpEventCollectorLoggingHandler.sourcetype=syslog\n" +
             "com.splunk.logging.HttpEventCollectorLoggingHandler.include_logger_name=false\n" +
             "com.splunk.logging.HttpEventCollectorLoggingHandler.include_thread_name=false\n" +
             "com.splunk.logging.HttpEventCollectorLoggingHandler.include_exception=false\n" ;
     try {
        LogManager.getLogManager().readConfiguration(new ByteArrayInputStream(conf.getBytes()));
    } catch (IOException e) {
        System.out.println(e);
    }
    System.out.println(LogManager.getLogManager().getLogger("splunkLogger"));
     logger.setLevel(Level.INFO);
     String jsonMsg = String.format("{EventDate:%s, EventMsg:'this is a test event for java logging1}", new Date().toString());
     logger.info(jsonMsg);

     // logger.error("This is a test error for Logback test");

 }

Hi @pooja-murarka,
Thank you for reaching out !
As per your above code, there are few things identified which might be the reason for failure to send logs to Splunk server:

URL should be proper (based on the Global Settings of Splunk HEC - Either http/https) and host should be replaced with your actual host.
Token should be an alphanumeric UUID containing 36 characters. [This HEC token has to be created from Splunk UI. Refer docs]
Batch size count should be greater than 0. (Check Info note on docs)
While setting up HEC token, you should select default index, if not then do specify it as an attribute such as:
"com.splunk.logging.HttpEventCollectorLoggingHandler.index=main"

Please modify your code based on above changes and re-evaluate your test.
Please let us know if you still face any issues.
Thank you.

Hi @pooja-murarka,
We assume that the issue you are facing will be closed based on above comment.
We are closing this ticket for now.
Please let us know in case of further queries.
Thank you !


Add Authentication

Add basic email/password authentication to the site. Hopefully we can use some sort of school login in the future but this should let us continue with development of the rest of the site for now.
Closes #24

When inputting a password for either register or login, the user should be able to see the most recently typed character

That would be something that would automatically happen on a phone. For security reasons I would probably say it's best to avoid that and usually on a physical keyboard you are usually accurate. For registering we have a confirm password box to increase the likelihood that the user didn't mistype their password.


ArcGIS

I followed the instructions and it doesn't work in ArcMap 10.8. I'm getting a red X over the toolkit icon.
In QGIS and ArcGIS Pro it works!


add keys=persistent behavior

Persisting the mainnet directory entirely seems like a desirable configuration, allowing the keychain db, config file, logs, etc to be preserved across container and host restarts.  Additionally, logs are easily visible outside the container.  Adding keys=persistent behavior to support this configuration.

I think this is a good change.  I'm persisting my keys outside the container as well, and as a workaround for not having a "persistent" option I mount the volume as read-only.  This works, but obviously will cause errors on startup:
OSError: [Errno 30] Read-only file system
This pull request would be a much more elegant solution.

any feedback on this, or anyone able to approve it?


Fix path message orientation error

Closes #680
This PR fixes the orientation of the arrow and axes markers for path messages.

CI build: --packages-up-to rviz_default_plugins

Linux
Linux-aarch64
macOS
Windows

This pull request has been mentioned on ROS Discourse. There might be relevant details there:
https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2021-9-16/22372/1


Addon helps but doesn't completely solve jitter. Unsure if issue or user error.

I am using a customized version of Godot 4.1 and I had really bad jitter in a simple test project. I've found that this addon helps but it doesn't completely solve the jitter. Based on this screenshot of my player scene tree, am I actually using the addon correctly? Are there any tips for better results?

Usually you wouldn't need to place a smoothing node under another smoothing node in the scene tree.
For cameras, it can often be a good idea to take them off the object (with no inherited transform) and set the target. You may also be able to use set_as_topleve() to get the same effect.
This may require an MRP (minimum reproduction project) to figure out what might be going wrong for you.


I  think  we  need  a vxlan  config for  kernel with  networking  ,so  we can  connect in   with  vpc  at  openstack

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@summer-father
Please submit more information in the form.  I need to better understand your use case before Product will review and consider.
Thanks!

Closed due to lack of detail in the submission.


feat : invert sentence in RuleEmptyQuery

Description
invert sentence
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (change restructuring the codebase without changing functionality)
[ ] Improvement (change adding some improvement to an existing functionality)
[ ] Documentation update

How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

[x] TextClassification

Checklist

[x] I have merged the original branch into my forked branch
[x] I added relevant documentation
[x] follows the style guidelines of this project
[x] I did a self-review of my code
[x] I made corresponding changes to the documentation
[x ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

This branch is deprecated since these modifications are included in #2607


Establish unit testing pattern

The project currently has a few unit tests written for pure functions but none with mocks, spys or other testing code.
A few options should be considered and then one decided upon and implemented for a few services.
Current candidates:

jest: I'm the most familiar with this and so could hit the ground running but it always feels like it introduces a lot of overhead
mocha, chai and sinon: These are nice and fast and simple and I appreciate the single responsibility of each. But I find the sinon documentation more geared towards old-school javascript with very few typescript & modern module examples.
node test runner node itself now has a built in test runner, I have no idea how this compares with the others and what scope it has but it's worth a look

Spent a bunch of time testing out the node test runner. It performs very well but I found compared to jest:

The mocking interfaces are not very ergonomic
The assertion results for arrays and deeply nested objects are not readable


Not working

Its not working, im getting an error. Same error when building myself or downloading ready bot.

same here

The bot is working, but I don't understand why you're getting errors. It could be related to a setting on your computer.

It ain't working for me either... I get a 403 when trying to get vioshield

It ain't working for me either... I get a 403 when trying to get vioshield

PS: I triple checked and session is OK

This error is related to Cloudflare. Can you try again in incognito tab?

It ain't working for me either... I get a 403 when trying to get vioshield

PS: I triple checked and session is OK

I don't know why some people get this error. Can you try again in incognito tab?

nope, sessid changed but same error

ilker#1828

done! I'm DaEMoN#5710


issue with color thumbnails when using reference + alpha?

Hi there,
So apparently I found a bug where colors are not being rendered nicely in the thumbnail.
This only happens with colors that follow this type of reference: "rgba($black, 0.87)" etc.
It still works as should when I apply a token to a shape, it's only that the thumbnail does not correspond.
Any idea what this can be?
tokens.json.zip

Bump? :)


kubernetes layers are embedded in the full kubernetes repository

Hi,
Is there a reason the kuebernetes-master, kubernetes-worker and kubeapi-loadbalancer charms (or, to be precise, layers) are embedded in the full kubernetes repository ? Couldn't they be in a separate, standalone repository ?
Cloning 315MB just to hack on a few files that are <1MB isn't a great experience. And I don't see any dependency from one to the other (perhaps resources ? Not sure resources mandate this kind of layout though).
Thanks

The reasoning for this is so that anybody who has the kubernetes repo can deploy on-the-spot with the charms right from the local branch.
@chuckbutler don't we have the source code branches available in the juju-solutions namespace so he could grab the code quicker without pulling down all of k8s?

Negative, in the juju-solutions namespace, the principal kubernetes charm layers live in that behemoth of a repository. its an unfortunate side effect of working on the most popular project on Github. it comes with a HUGE repository meta archive (somewhere near 300mb of meta on initial pull).

@chuckbutler @castrojo Is using git submodules an option here? If not, this is probably as good as we can do and can close this issue.

It's likely that we'll move out of kubernetes/kubernetes at some point, at which point this will no longer be relevant. No reason to keep this open in the meantime.


Creating Gzip files while build

With the current config of CRA when you build the project, the files aren't gzipped so if you want to serve gzipped files, you have to either gzipped dynamically or to eject.
What could be awesome is when a build is run, two folders are created in the build folder: one regular and one with the gzipped files. Or having the possibility to set a env var GZIP and build only one folder, gzipped or not

I'd also vote for this feature because GZip files have already been creating for the size difference.
Just save them as well as regular files.
Also Nginx supports .gz files via gzip_static on; directive.

I thought about the api:

You set an env variable gzip to true
Produces regular files plus the .gz ones

I don't feel like this is in the scope of CRA - isn't the web server's job to gzip assets before sending them to the browser ?

@bogdan-calapod take a glance at https://github.com/facebookincubator/create-react-app/blob/v1.0.13/packages/react-dev-utils/FileSizeReporter.js#L128
This function is invoked during the build. It's using zlib.gzipSync method: https://nodejs.org/dist/latest/docs/api/zlib.html#zlib_zlib_gzipsync_buffer_options
It's already happening. All they need is to dump this files to the disk.

And if it is the web server that gzip the assets, it is done dynamically, so you have to regzip your assets every time (Nginx has a cache but that's not the point)

Gzipping files is usually done by the CI / manually.
By default static web servers do not handle statically gzipped files (need extra configuration). I'm guessing that people needing to statically gzip thebuild already do that in their deployment process.
It's a cool feature to have, but it doesn't feel in CRA's scope.

I'm pretty sure this is most often handled by the web server, e.g. express has a gzip option, and I'm sure nginx has an option for this too.
I'm not sure I see the value in us providing these by default.
Let me know if I'm wrong.
Also, I feel like this is easily accomplished with a postbuild script that gzips your assets.

Since you think it is out of scope of CRA, can you suggest an npm package that runs as "post-build" or a "deploy" script and gzip all my "build/" files?
I'm on Windows, Linux, Mac machines (everytime changes).

Hey @johnunclesam ! If you're searching for a cli gzip utility in Node, any wrapper cli using zlib will do the job. For example : https://www.npmjs.com/package/gzip-all

in case anyone is looking how to do it in nginx
i know this is not the correct place but this is the first link on googling
can add or change stuff accordingly. so no need to do anything in CRA just dump your build in the nginx public folder with these configurations
for configurations can go to nginx docs can read this link further
https://www.digitalocean.com/community/tutorials/how-to-add-the-gzip-module-to-nginx-on-ubuntu-14-04
    gzip on;
    gzip_disable "msie6";

    gzip_vary on;
    gzip_proxied any;
    gzip_comp_level 6;
    gzip_buffers 16 8k;
    gzip_http_version 1.1;
    gzip_types text/plain image/svg+xml image/gif image/jpeg image/png application/font-woff text/css application/javascript application/json application/x-javascript text/xml application/xml application/xml+rss text/javascript;


replaced amp graph with line graph

I replaced the grid visualization with a line graph representation. Still to do: add hover tool with amp location and metric value.

Thanks.  Requested changes, based upon testing 20190306/00001076

Always scale horizontal axes to include all 10 spectrographs, even when only one or two spectrographs have data.

maybe: connect points within a spectrograph with a line, but don't draw a line between spectrographs.  That may help group which points go together, and make it look better when e.g. spectrographs 0 and 2 have data but not 1 (which would otherwise have an unusally long line crossing the missing spectrograph).

Label the plots for which are READNOISE, BIAS, COSMICS_RATE
Flag outliers in red (and maybe a different shape or size), but otherwise use a single dark color for the points.  I originally thought that I was missing some points but it turns out they are there but just nearly the same color as the background given this color palette.
Order the cameras B (top), R (middle), Z (bottom)
Move toolbars to the right side and/or squish aspect ratio to try to get more data vertically on a single screen without scrolling

Tested on a couple flavors, looks ready to merge


For Kubecon: make update faster

We can merge this any time. It should be reverted after Kubecon Paris
This PR makes the update-kubecon.md cron job run every 5 minutes, instead of every 6 hours which it is currently set at. It should make working with the Google Sites integration a lot more convenient
If you want, we can edit the Pull Request so it sends you email - then you can click through the email and merge the PR to deploy to the website. The delay should be less than 5 minutes. Netlify job takes about 1 minute 30s to build the docs site.
I wanted to test this workflow very thoroughly before I set the job to run that frequently. I still think this may be too fast. But someone else from the community repo will have to weigh in anyway, I cannot merge this by myself.
cc: @mewzherder

Honestly my preference would be to leave it at 6 hours, so you just run:

https://github.com/fluxcd/community/actions/workflows/update-kubecon.yaml

after publishing Google Sites, and we're not spamming GitHub Actions. We should all be able to handle this, it's just one workflow. But in the interest of making stress low during high-pressure times like Kubecon, I submitted this since it's up to consensus, not up to me! I will merge this if everyone else agrees it can be shortened to 5m, (or I will amend it if we think there's a more sensible value like every 30m.)

Let's run this manually, is just one click.

Ref:

https://github.com/fluxcd/community/pull/365

I'm gonna leave it open for debate until Kubecon arrives, but the consensus right now is we should not increase the interval below every 6 hours. It's working fine at the every 6 hours rate, it's just one workflow, we can run it manually.
Thanks!

We've been able to test the workflow with another user, and it works 🎉
I'm going to close this, since I don't think we need it now


Use stdout only for literal text of trusted content

Per POSIX conventions, stdout is for "conventional output", whereas stderr is for "diagnostic output". Diagnostic output is conventionally interpreted to include logs, status messages, prompts, or other content of interest to human operators, such that stdout can be directed through pipelines or redirections for programmatic consumption while stderr is routed directly to the human operator.

When we are asked to verify a document and write that document to stdout, write only the document (not verification messages, not the trusted comment text) to stdout.
When we are asked to verify a document and write only the trusted comment, that comment is our "conventional output" -- the thing we were invoked to generate -- and should be written to stdout without any prelude, header, explanatory content, etc.
In modes where we aren't being invoked with the intention of generating some kind of well-defined output on stdout, keep all interaction on stderr to avoid potential for confusion.

-Q is modified from "pretty quiet" to instead be a directive to write the literal text of the trusted comment to stdout; this provides a programmatic way to retrieve that comment that doesn't require filtering/modifying output to separate the literal text from the explanatory prose.

On further investigation, that trailing-newline delta is present on main without this PR merged; it's thus not a new bug. Reopening.