Open/close modal with class change

From the docs, it seems the only way to open/close a modal is using a clickable button. I don't see any (simple) way to control the modal using JS. If there was a class that could be applied to open/close the modal, that would be all that's needed for this.

Hello @chrispytoes
u can play with the class modal-open to open/close your modal.

@oben01 Woops, can't believe I missed that. Thanks!


Support reference images

This supports having reference images as benchmarks for the future. It also fixes a couple minor things as well.

Cool! This will be pretty great once some older reference image runs are generated. I think I tried a version in June and maybe a version in march. They looked pretty different from now.


KAFKA-15853: Move KafkaConfig log properties and docs out of core

part 1 for #15501
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@nizhikov can you have a look please?

Now that https://github.com/apache/kafka/pull/15075 got merged, this needs rebasing.

rebased the pr

Since Mickael is already reviewing it, I'll focus on other PRs. Thanks @mimaison !

@OmniaGM I think this is almost ready, but there are a couple of minor comments to address and some conflicts to fix.

Will be addressing this soon after another pr

@fvaleri, @nizhikov @mimaison just rebased the pr and addressed the feedback will wait for this one to be merged before rebasing the other pr for KafkaConfig

@OmniaGM Is this the next PR in line for moving broker configs?

@OmniaGM Is this the next PR in line for moving broker configs?

Yes, I rebased the PR and also pushed a refactor to follow the same pattern we adopted in https://github.com/apache/kafka/pull/15656#discussion_r1554518847, https://github.com/apache/kafka/pull/15684, https://github.com/apache/kafka/pull/15670

The last commit renamed the class to KafkaLogConfigs instead similar to KafkaSecurityConfigs and ZKConfigs. I tried to move some to LogConfig.ServerLogConfig similar to LogConfig.RemoteLogConfig specially that some default configs are defined in LogConfig. However I'm bit concern that LogConfig seems already huge. What others prefer? Keep it in  KafkaLogConfigs  or move them to LogConfig.ServerLogConfig`
cc: @mimaison, @chia7712

Keep it in KafkaLogConfigs

I prefer this way since LogConfig includes too many stuff now ... maybe we should move the constants out of LogConfig

maybe we should move the constants out of LogConfig

We can try to do this in a follow up after we merge all PRs for KafkaConfig as am worried about potential circular dependency. And it would better to see the full pic before do improvement for LogConfig.

There are build error. please fix it :)

hopefully for the last time :)

I feel #15684 will cause many conflicts to this PR, and vice versa :_

Let's just let Omnia decides which PR she prefers doing first. Then we can all review that PR, and once merged move onto the next one. This would avoid unnecessary churn as I expect she's getting tired of rebasing all of these PRs every day!

Thanks @mimaison this is really thoughtful! breaking KafkaConfig out of core is one of the hardest cleanup specially if we want to move with smaller/medium PRs. So I don't see any other way than going through it. I think it might be better to take them in order so we can get them merged and the rebases can be easier.
Let's merge https://github.com/apache/kafka/pull/15684 as

it is smaller
more contained than the log config
and group configs are more likely to change as part of KIP-848 and any of its followups which make the conflicts much harder and risker to get messed up.

However I'm bit concern that LogConfig seems already huge. What others prefer? Keep it in KafkaLogConfigs or move them to LogConfig.ServerLogConfig

the most default values of KafkaLogConfigs are in LogConfig, and they are in different module. That pattern is no similar to ReplicationConfigs, KafkaSecurityConfigs. Is server-common module more suitable to collect those server side configs since bothstorage and server depend on server-common. Also, server-common has org.apache.kafka.server.config package too.

However I'm bit concern that LogConfig seems already huge. What others prefer? Keep it in KafkaLogConfigs or move them to LogConfig.ServerLogConfig

the most default values of KafkaLogConfigs are in LogConfig, and they are in different module. That pattern is no similar to ReplicationConfigs, KafkaSecurityConfigs. Is server-common module more suitable to collect those server side configs since bothstorage and server depend on server-common. Also, server-common has org.apache.kafka.server.config package too.

I think it might be better and simpler to move KafkaLogConfigs into server-common and make LogConfig use them. I'll push an update with this soon

[2024-04-18T17:26:16.149Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-15569/server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:22:1: Disallowed import - org.apache.kafka.server.common.MetadataVersion.IBP_3_0_IV1. [ImportControl]

[2024-04-18T17:26:16.149Z] [ant:checkstyle] [ERROR] /home/jenkins/workspace/Kafka_kafka-pr_PR-15569/server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java:23:1: Disallowed import - org.apache.kafka.server.config.ServerTopicConfigSynonyms.LOG_PREFIX. [ImportControl]

there are imports error :_

The failed test testParseAndValidateAddressesWithReverseLookup will get fixed by #15758. I will merge this PR


Bump imgui to 1.84.2

Closes #76

Hm.. Everything works, but GLFW backend has no callbacks at all right now :thinking:
I will merge this as it is, then add all the callbacks separately.


(3.0.46) cannot tell at glance which hierarchy classes have extension methods for the selected package

I don't know if this has been discussed already, but I would like to be able to tell at a glance which classes have extension methods from the currently selected package ... Number and Integer are the only ones:

I do indeed like seeing the full hierarchy for the classes, but I would like to be able to tell which classes have extension methods for the given package in the hierarchy ...

I believe this is the same as the problem reported as bug 497.  Closing this in favor of the more recent bug.


key_share crate and module conflict under rustc 1.80.1

Hello team,
I ran cargo build under the cggmp21 crate and I am getting an ambiguous name error:
   Compiling key-share v0.4.2 (/home/manuelsantos/GitHub/cggmp21/key-share)
   Compiling paillier-zk v0.4.1
   Compiling cggmp21-keygen v0.3.1 (/home/manuelsantos/GitHub/cggmp21/cggmp21-keygen)
   Compiling cggmp21 v0.4.1 (/home/manuelsantos/GitHub/cggmp21/cggmp21)
error[E0659]: `key_share` is ambiguous
   --> cggmp21/src/lib.rs:306:5
    |
306 | use key_share::AnyKeyShare;
    |     ^^^^^^^^^ ambiguous name
    |
    = note: ambiguous because of multiple potential import sources
    = note: `key_share` could refer to a crate passed with `--extern`
    = help: use `::key_share` to refer to this crate unambiguously
note: `key_share` could also refer to the module defined here
   --> cggmp21/src/lib.rs:313:1
    |
313 | pub mod key_share;
    | ^^^^^^^^^^^^^^^^^^
    = help: use `crate::key_share` to refer to this module unambiguously

For more information about this error, try `rustc --explain E0659`.
error: could not compile `cggmp21` (lib) due to previous error

It compiles the key-share v0.4.2 crate first, so it enters in conflict with the key_share module from above.

This works under a rust nightly version actually. Suggestion: maybe it is useful to have that written in the README file.

This works in non-nightly too, it runs fine for me with rustc 1.80.0, and has been for multiple versions now.

Thanks for your answer,
Nightly: rustc 1.83.0-nightly (bd53aa3bf 2024-09-02)
Stable: rustc 1.80.1 (3f5fd8dd4 2024-08-06)
Just tested with rustc 1.80.0 and it works as well! It is failing for rustc 1.80.1 for some reason.

Still can't reproduce, builds fine for me with latest rustc in rustup which is rustc 1.80.1 (3f5fd8dd4 2024-08-06)

It's weird if it only appears on 1.80.1, and not on any older or later versions. Looks like a compiler bug, or something wrong with your test setup.

Tried rustc 1.81.0 (eeb90cda1 2024-09-04), still can't reproduce

Thank you for taking the time to look into it.
I ran cargo clean and cargo test with 1.80.1 and everything is building fine. It's weird, I cannot reproduce the error anymore. I guess we can close this issue. Thanks!


Game Initiator - Arena - Select & Start Game

Background
Game initiators that create an arena should be the only user that can select which game to play and when to start the game once the minimum number of players for the game are in the arena. The purpose of this ticket is to only allow the game initiator to view all games, select a game, and start a game once they have created an arena.
Scenario: Game Initiator Selects & Starts Game

[ ] Given I am a game initiator
[ ] And I have created a new arena
[ ] When I select a game
[ ] And the minimum number of players have joined my arena
[ ] Then I can start the game

#34 merged, moving to QA

works as expected, will need to create a ticket to address errors discussed during kickoff when there are more players in the arena than a selected game allows. moving to UAT


[uss_qualifier] new scenario to check for forbidden OIR state transitions

This adds a test case to OpIntentReferenceAccessControl to cover specifically SCD0100 (disallow transitions to Nonconforming and Contingent states).
This still misses test cases that would check that the correct scope would be allowed to do such a transition: these will be added on an upcoming PR (the focus of https://github.com/interuss/dss/issues/1022 is on fixing the fact that missing the scope still lets a client do a forbidden transition)

Keeping as draft until:

a fixed DSS version is published
I adapted the used credentials to not include a CMSA scope
I expand the scenario to fail if the provided credentials have the CMSA scope

Updated and rebased on latest master: should be ready to merge.


Prune the root directory of unnecessary files

.gitmodules is now empty, and has been for a while
We haven't used myget for a long time
Directory.Build.targets is now obsolete as the issue has been
fixed in the .NET Core SDK

Will just wait until the current non-PR AppVeyor build has completed before merging this.


📝 Update includes for docs/zh/docs/advanced/response-directly.md

Thanks for the effort! :cake:
This was handled in another PR, so I'll close this one now. :coffee:


pylint

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:05:38.342Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

html-snippets
abu
0.1.0

python
don
0.7.0

vscode-html-css
ecm
0.1.8

view-in-default-application
see
3.3.0

lorem-ipsum
Tyr
1.0.0

Steps to Reproduce:

Reproduces without extensions: Yes/No

@Inhee-LEE What is this issue about? Perhaps you meant to open an issue in the DonJayamanne/pythonVSCode repository?

Sorry i made a mistake.
I did'nt try to open any issue.
I am a newbie about VS code.

오전 9:17에 "Remy Suen"<EMAIL_ADDRESS>작성:

@Inhee-LEE https://github.com/inhee-lee What is this issue about? Perhaps
you meant to open an issue in the DonJayamanne/pythonVSCode repository
https://github.com/DonJayamanne/pythonVSCode?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/33624#issuecomment-326453507,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKjrsT_XgvxPaGtReHJ1D22nc36ytRgjks5sd00WgaJpZM4PJjOl
.

Ok, closing


Remove timestamp element from paths

This kills incremental builds and testing and should be part of deployment process, not build process.   Especially with the Docker context, the containers provide that isolation anyway.   We don't need that on the file system within the container too

DONE - CC @anthony-cros

sounds good, I was thinking of simply making a softlink such that ~/eth/latest -> ~/eth/151130092319 (if<PHONE_NUMBER>19 was the latest)

This kills incremental builds

the scripts allowed specifying the timestamp to reuse for that purpose though

Right - but I don't think there is any need for this pattern within the build process itself.    Parallel builds can be achieved by cloning into different source directories in the first place if you want complete "parallel tree" workflow.
Within Docker, none of this is a problem at all, and I think that it is better to handle it outside of the build process for the repo if you need to have multiple instances.
Is the issue just that we are generating intermediate and working directories and outputs to a fixed global location?   I think it is, right?
Like this uniqifying is something which needs to be in a wrapper AROUND these scripts, not within them.
I'll keep iterating on this stuff.    Sorry if I stamp on your toes a bit ... :-)

I'll keep iterating on this stuff. Sorry if I stamp on your toes a bit ... :-)

no worries, i would have eventually gotten rid of it as the scripts matured anyway!


Fix support for tags in ViewItem

Now tags are properly being red to ViewItem.

CLA received.

Looks good!


Add support for SwedishCoOrdinationNumber

In Sweden, if you don't are a registered Swede and have a Personal Identity Number, you can still have a lightweight version of that called co-ordination number.

A co-ordination number is an identification for people who are not or have not been registered in Sweden. The purpose of co-ordination numbers is so that public agencies and other functions in society are able to identify people even if they are not registered in Sweden.
The Swedish Tax Agency allocates co-ordination numbers  upon request. All Government authorities and certain private higher education institutions have the right to request co-ordination numbers.

Info and definitions:

http://www.mira.se/knowledge-base/vad-heter-personnummer-och-samordningsnummer-pa-engelska/
https://sv.wikipedia.org/wiki/Samordningsnummer
https://www.skatteverket.se/privat/skatter/internationellt/bosattutomlands/samordningsnummer.4.53a97fe91163dfce2da80001279.html

I can see in mira's link that they use the hyphened spelling of co-ordination but I think coordination without a hyphen is the more common spelling.
https://en.oxforddictionaries.com/definition/coordination
And in my opinion SwedishCoordinationNumber looks much better than SwedishCoOrdinationNumber.

And in my opinion SwedishCoordinationNumber looks much better than SwedishCoOrdinationNumber.

I totally agree, thanks for he input! I've updated the issue to reflect this.


[Tutorial proposal] Your tutorial title here

What is the objective of the proposed tutorial?
A clear and concise description of what users can expect to learn from your
tutorial.
What is the scope of the proposed tutorial?
The thematic (forestry, water resources, land cover classification, Earth Engine
core libraries, etc) and specific geographic area, if relevant.
Please provide an outline of the structure of the proposed tutorial?

Section 1
a. Subsection 1a
b. Subsection 1b
Section 2
.. et cetera. ..

In what format will you be submitting the tutorial?
Select one: Markdown
or Colab
This request will be reviewed by the Earth Engine community maintainers, who
will reply on this issue tracker with any questions or suggestions. Once
approved, this issue will be assigned to you and you can begin work on the
tutorial following instructions in
Writing a tutorial.
When creating your Pull Request, enter "Closes #issueno" in the description of
your Pull Request to link the tutorial to this issue.

This tutorial request does not contain a valid tutorial description. Please resubmit your request filling in all template fields. Thanks!


Build Document - Internal Error - undefined method 'redirects_to'

My test-environment is:

Ubuntu 16.04 alpha
RVM with ruby 2.2.1
Apache 2.4 with passenger 5.0.25
Redmine 3.2.0
doc_pu 2.0.1

The Plugin can be configured and I can compose a document definition. But as soon as I press on the 'Build' link I see an 'Internal error' and inside the production log I found:
Completed 500 Internal Server Error in 46ms (ActiveRecord: 17.5ms)
NoMethodError (undefined method redirects_to' for #<ActiveRecord::Relation []>):   lib/redmine/sudo_mode.rb:63:in sudo_mode'

I've the same problem with RVM/ruby 2.0.0-p643

After adding the RedCloth GEM to the Gemfile (instead of using 'bundle exec gem install RedCloth') and executing 'bundle install --without development test' I can create a PDF from a single Wiki page. But as soon I add a link to a second page via [[PageName]] I see a server error with the following in the logfile: NoMethodError (undefined method 'latex_label' for #<DocPuWikiPage:0x00..

Now with ruby 2.2.4 and Redmine 3.2.1 still the same problem while building a PDF with a wiki page with a internal page reference ([[PageName]]):
Started GET "/doc_pu/build_remote?id=4&project_id=demo" for <IP_ADDRESS> at 2016-04-05 16:42:40 +0200
Processing by DocPuController#build_remote as JS
Parameters: {"id"=>"4", "project_id"=>"demo"}
Current user: tuser (id=5)
Completed 500 Internal Server Error in 38ms (ActiveRecord: 16.9ms)
NoMethodError (undefined method redirect_to' for #<ActiveRecord::Relation []>):   plugins/redmine_doc_pu/lib/latex_wiki_page.rb:36:in block in to_latex'
plugins/redmine_doc_pu/lib/latex_wiki_page.rb:31:in gsub!'   plugins/redmine_doc_pu/lib/latex_wiki_page.rb:31:in to_latex'
plugins/redmine_doc_pu/app/models/doc_pu_wiki_page.rb:24:in to_latex'   plugins/redmine_doc_pu/lib/latex_doc.rb:65:in block in to_latex'
plugins/redmine_doc_pu/lib/latex_doc.rb:64:in to_latex'   plugins/redmine_doc_pu/lib/latex_doc.rb:115:in build'
plugins/redmine_doc_pu/app/models/doc_pu_document.rb:27:in build'   plugins/redmine_doc_pu/app/controllers/doc_pu_controller.rb:101:in build_remote'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'

Sorry for this late reply. I'am not at this project mainly. I think, the cross page refs are not working at all at this moment. Sorry. Not a feature we need. Are you interested to fix this by yourself?

I can inform you by now: Your issue was fixed with the last commit.


Update to librespot v0.2.0

Librespot was updated to v0.2.0 a few days ago. Along with the usual bug fixes and whatnot the most user noticeable changes are higher bit depth formats are available reducing quantization noise and providing for higher quality software volume and volume normalization now also uses a real limiter to better adhere to the ReplayGain standard and how official Spotify clients actually work.
AFAIK no args have changed and everything is backward compatible with the previous release so it should be just a matter of rebuilding the binary.
https://github.com/librespot-org/librespot/releases/tag/v0.2.0

Ogg passthrough sounds interesting. Which format uses librespot as default?

Ogg passthrough sounds interesting. Which format uses librespot as default?
I’m looking for a 1:1 playback with no quality loss.

Spotify streams Ogg vorbis which is lossy. Eventually when the folks behind librespot figure out the new API and Spotify opens up their "HiFi" tier it will be lossless 16 bit 44.1 audio, FLAC I would imagine?

That sounds great.
But I wonder what Ogg passthrough exactly means. At the moment I use the 320 kbits option in the config.

But I wonder what Ogg passthrough exactly means. At the moment I use the 320 kbits option in the config.

It works like pipe except instead of pipping PCM It pippes the Ogg Vorbis stream without decoding it.

Pipping is one of those things that if you don't know what it's good for you probably don't need it. It's like a catch all option. You can basically put anything at the other end of the pipe that either understands PCM or Vorbis and do whatever you wanted with it. For the basic use case of running Spotify Connect on the same Pi you plan on outputting sound from pipping to another program is overkill IMHO. Unless your Pi is connected to a nice USB DAC your Pi is most definitely the bottleneck as far as sound quality not whatever program is playing the audio.

Unless your Pi is connected to a nice USB DAC your Pi is most definitely the bottleneck as far as sound quality not whatever program is playing the audio.

My Pi is connected to the high end DAC RME ADI-2 DAC.
If I understand correctly, there is currently an unnecessary conversion from ogg to pcm?

If I understand correctly, there is currently an unnecessary conversion from ogg to pcm?

No. Unless your DAC can decode an Ogg Vorbis stream naively.

Ogg Vorbis is a lossy audio format and container like an MP3.

@dtcooper Maybe hold off, 0.3.0 it should be released shortly. The only breaking change is --mixer-linear-volume has been removed but raspotify doesn't use that in it's default args anyway.
From 0.1.6 to 0.3.0 (once it's released) is a no-brainer update.

Okay thanks for the info. Will track the 0.3.0 release.

Maybe hold off, 0.3.0 it should be released shortly. The only breaking change is --mixer-linear-volume has been removed but raspotify doesn't use that in it's default args anyway.
From 0.1.6 to 0.3.0 (once it's released) is a no-brainer update.

@JasonLG1979
What will be the syntax changes for me to keep using the linear volume?
I've been having to do somewhat of a hack to get it to work without crashing, using the following in specific order..
OPTIONS="--mixer=alsa --mixer-linear-volume --mixer-name=Digital"
VOLUME_ARGS="--volume-ctrl=linear --initial-volume=65"
Also, is it possible to get some sort of delay when starting playback?
I have a system that needs 1s to start an amplifier before processing the audio.
The sequence would be - open audio device - then after 1s - process audio.
Thx

What will be the syntax changes for me to keep using the linear volume?

Actual linear or linear to the volume controls in alsamixer? Because the controls in alsamixer are logarithmic if I remember correctly? Logarithmic is perceptually linear, a true linear volume control doesn't sound linear to the human ear. We don't perceive sound linearly, that's why dB's are log.
There's been a lot of work done by @roderickvd on the volume controls among other things. He's the mastermind behind basically all of the audio quality and volume improvements. I don't generally use volume controls in librespot (I just use the volume knob on my receiver) so I set it to fixed and 100 so I am far from an authority. But I'm Pretty sure if you want your volume controls to be linear to alsamixer  all you should need is --mixer=alsa since logarithmic is the default mode in librespot you should be able to skip --volume-ctrl=linear unless you want a true linear volume control (that won't match the volume controls in alsamixer.
If I have misunderstood or misstated anything please correct me @roderickvd.

Also, is it possible to get some sort of delay when starting playback?
I have a system that needs 1s to start an amplifier before processing the audio.
The sequence would be - open audio device - then after 1s - process audio.

You may be able to use --onevent (which allows you to run a program or script when events happen) along with emit-sink-events to run a script when librespot opens and closes the sink (basically audio device) I'm not sure if that event is blocking or if the script is fired before or after the sink is opened. Again sorry I am not the authority on that. My set up is pretty basic, I've never had the need for anything that complicated.

Here is the ARMv6 binary that will run on a 32bit Raspberry Pi:
wget --no-check-certificate 'https://docs.google.com/uc?export=download&id=1mqXKACTrIQZ-2C6enDYniE7m2vowcBDT' -O librespot
Same as before,  run chmod +x librespot to make it executable and report any bugs to librespot.
./librespot -h will print out the help menu in the terminal giving you a list of possible options and flags to choose from.

@dtcooper Maybe hold off, 0.3.0 it should be released shortly. The only breaking change is --mixer-linear-volume has been removed but raspotify doesn't use that in it's default args anyway.

I don't know about your release cycles but a 0.3.0 release date has not been settled yet. I'd like to release one early summer but it's not just up to me. In the meantime 0.2.0 is a pretty solid release that I think is worth your while.

What will be the syntax changes for me to keep using the linear volume?

Actual linear or matching the volume controls in alsamixer? Because the controls in alsamixer are logarithmic if I remember correctly? Logarithmic is perceptually linear, a true linear volume control doesn't sound linear to the human ear. We don't perceive sound linearly, that's why dB's are log.
There's been a lot of work done by @roderickvd on the volume controls among other things. He's the mastermind behind basically all of the audio quality and volume improvements. I don't generally use volume controls in librespot (I just use the volume knob on my receiver) so I set it to fixed and 100 so I am far from an authority. But I'm pretty sure if you want your volume controls to match alsamixer all you should need is --mixer=alsa since logarithmic is the default mode in librespot you should be able to skip --volume-ctrl=linear unless you want a true linear volume control (that won't match the volume controls in alsamixer).

Thanks for the appreciation.
Up to and including 0.2.0 you can't have true linear volume control using the alsamixer. Because Alsa's mixer maps everything logarithmically internally, when launching librespot --volume-ctrl linear you will be getting a logarithmic control which is generally what you want (or cubic, depending on whether your DAC has hardware volume control).
If you launch with --volume-ctrl log then you will get a nonsensical log-on-log mapping, this is probably what you were referring to.
This has been worked around in dev for release in 0.3.0. Doing --volume-ctrl {linear|log} will then actually do what you think it'll do.
Unless you have some special requirements, for best sound quality I recommend using softvol instead of alsamixer, it does volume control in 64-bit floating point which is better than doing it in DAC hardware or Alsa Softvol. In which case --volume-ctrl {linear|log} is already working fine.

Also, is it possible to get some sort of delay when starting playback?
I have a system that needs 1s to start an amplifier before processing the audio.
The sequence would be - open audio device - then after 1s - process audio.

You may be able to use --onevent (which allows you to run a program or script when events happen) along with emit-sink-events to run a script when librespot opens and closes the sink (basically audio device) I'm not sure if that event is blocking or if the script is fired before or after the sink is opened. Again sorry I am not the authority on that. My setup is pretty basic, I've never had the need for anything that complicated.

Not natively in librespot but maybe you can do something with the GStreamer backend. I don't know.

@JasonLG1979
What will be the syntax changes for me to keep using the linear volume?

Unsure until I test the release, post v0.3.0, however I will make sure your config @ /etc/default/raspotify is properly sed'd to reflect any changed arguments.

Extremely busy week on my end. Will get a chance to delve into this weekend. Thanks for your patience, all. (As always, patches welcome!)


Widget / System >> dead link

click on link in system widget ends up in "page not found"

I can't stress the point made in https://github.com/opnsense/core/blob/master/CONTRIBUTING.md#issue-reports which would make this a lot faster to fix given the necessary reference and context:

The current OPNsense version where the bug first appeared
The last OPNsense version where the bug did not exist
The exact URL of the GUI page involved (if any)
A list of steps to replicate the bug

I can't stress the point made in https://github.com/opnsense/core/blob/master/CONTRIBUTING.md#issue-reports enough which would make this a lot faster to fix given the necessary reference and context:

The current OPNsense version where the bug first appeared
The last OPNsense version where the bug did not exist
The exact URL of the GUI page involved (if any)
A list of steps to replicate the bug


DB2 Error to export on csv

Hi, i have problem to export data to csv.
The export generate strange values:
60.66
----->   27.455.4<IP_ADDRESS>
6.852.384
13.68

Please provide more details.
This looks just like some very big number, generally it is not a bug.
Can you post some SQL to reproduce this problem?

I have installed version 6.2.4 and it works perfectly I send the same capture

Does this happen after CSV export only or you see the same issue in results grid?

It only happens in csv export

Thanks. Could you say data type of numeric columns?
Is there anything related in error or debug logs? (https://github.com/dbeaver/dbeaver/wiki/Log-files)

I really do not indicate the type of data, when exporting it only generates the document and when I open it it is when I see it
This is my configuration tu export csv file

You can see data types in metadata panel of results viewer:

What DB2 server version do you use? LUW, z/OS, iSeries?

there is no update on ticket more than a month.
Ticket closed.
If issue still actual for you - feel free to reopen the ticket


DNS and network configuration in production

What is the recommended way to structure the docker network and IP addresses to use FreeIPA with DNS enabled?
When all relevant ports are forwarded from the host, the container answers DNS queries with its internal docker-assigned address (<IP_ADDRESS>, for instance). The SRV records for Kerberos and LDAP point clients to an address they cannot reach instead of the host's address where the services are exposed. FreeIPA is unaware that docker exposes its services to a different network as a different address.
When the container is instead run with --net=host to take on the hosts' network stack and address, the container's installation script has a conflict with host's systemctl d-bus:

CalledProcessError: Command '/bin/systemctl start messagebus.service' returned non-zero exit status 10

Is there a better way to approach this that better supports a containerized FreeIPA with DNS? Thanks!

Run the container with -e IPA_SERVER_IP=<the-host-ip>. That will cause the IP address that IPA server stores about itself in the DNS to be updated to that value.
From within the container, we don't have a way to reliably figure out the IP address of the host or values used with the -p options. That's why we went with being explicit.
Let me know if this helps.
I will look at the --net=host use case.

Thank you, that works here. I had tried setting IPA_SERVER_IP earlier but was misled by the messages on the first run of the container which said,

Using reverse zone 0.17.172.in-addr.arpa.
The IPA Master Server will be configured with:
Hostname:      ipa1.example.net
IP address:    <IP_ADDRESS>
Domain name:   example.net
Realm name:    EXAMPLE.NET

This time I pressed forward despite the messages and now see that service discovery works as expected on the IPA_SERVER_IP. The initial reverse zone is configured for the private docker network 0.17.172.in-addr.arpa, but it's possible to add a reverse zone for the host's address space alongside that.
The --net=host may be a beneficial use case for someone else, but I was only considering it as a possible alternative to coerce the container to use the host's IP address. Thanks again for the quick response, and for this helpful project.

Thanks for reporting the success.
The problem with the initial IP address and reverse zone will hopefully be addressed by https://fedorahosted.org/freeipa/ticket/2715. Since ipa-server-install is way to eager to test the IP address and whether it is one of its local addresses instead of testing that the IP address is routed toward IPA server but not necessarily its local address.
You should be able to pass parameter to avoid setting up the 0.17.172.in-addr.arpa. zone to avoid polluting your DNS.

The --net=host may be a beneficial use case for someone else, but I was only considering it as a possible alternative to coerce the container to use the host's IP address. Thanks again for the quick response, and for this helpful project.

For the record, I've now tried the centos-7-upstream branch and ``--net=host``` on RHEL 7 host and I did not see any D-Bus related errors.


Make android solutions(Image segmentation) buildable with 'minifyEnabled true' build option.

OS Platform and Distribution
Android 13
Compiler version
No response
Programming Language and version
java 17
Installed using virtualenv? pip? Conda?(if python)
No response
MediaPipe version
:0.20230731
Bazel version
No response
XCode and Tulsi versions (if iOS)
No response
Android SDK and NDK versions (if android)
No response
Android AAR (if android)
None
OpenCV version (if running on desktop)
No response
Describe the problem
A bug happened!
Complete Logs
I use MediaPipe Image Segmenter followed the guide . It worked perfectly. However, when I changed minifyEnabled configuration to true in build.gradle file, it can initial valuabe
val imageSegmenter = ImageSegmenter.createFromOptions(context, options)
I use the last mediapipe gradle version :com.google.mediapipe:tasks-vision:0.20230731
I tried to use the proguard rule in my app suggested
" -keep class com.google.mediapipe.solutioncore.** {*;}
-keep class com.google.protobuf.** {*;}
-keepclassmembers class * extends com.google.protobuf.GeneratedMessageLite {
*;
}"
but not works.

Hi @Quangninh-io,
Could you share all the details about the issue? This includes the full code, any documentation you're following, the versions of Android Studio and Android SDK you're using, and if possible, the complete error logs. Having this information would greatly help us in reproducing and addressing the issue on our end.
Thank you


[Replace Option with Enum] page 42 "Sales Order" - BillToOptions

Could you please replace the Option BillToOptions with an enum

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 43150.


Image Input for GridLSTM

I would like to use GridLSTM for a handwriting recognition task. Unfortunately, the documentation is lacking info on how to input images into GridLSTMs.

@selcouthlyBlue I found this https://www.tensorflow.org/api_docs/python/tf/contrib/rnn/GridLSTMCell.

@yap770813901 I saw that one already. One thing I'm confused about that is the parameter num_frequency_blocks.
Also, there is another GridLSTMCell implementation (Grid2LSTMCell to be exact) in tf.contrib.grid_rnn.

Until I know what num_frequency_blocks is for in contrib.rnn.GridLSTMCell, I'm going to use tf.contrib.grid_rnn. I'm doing a learning test on tf.contrib.grid_rnn 's grid_rnn_cell that involves what the core rnn's accept using these cells. Here's what I got so far:
import tensorflow as tf
from tensorflow.contrib.grid_rnn.python.ops import grid_rnn_cell

def reshape_to_rnn_dims(tensor, shape):
    reshaped_tensor = tf.reshape(tensor, shape)
    split_tensor = tf.split(reshaped_tensor, shape[1], 1)
    return split_tensor

class GridLSTMCellTest(tf.test.TestCase):
    def setUp(self):
        self.num_features = 1
        self.time_steps = 1
        self.batch_size = 1
        tf.reset_default_graph()
        self.input_layer = tf.placeholder(tf.float32, [self.batch_size, self.time_steps, self.num_features])
        self.cell = grid_rnn_cell.Grid1LSTMCell(num_units=8)

    def test_simple_grid_rnn(self):
        self.input_layer = reshape_to_rnn_dims(self.input_layer, [-1, self.num_features * self.time_steps])
        tf.nn.static_rnn(self.cell, self.input_layer, dtype=tf.float32)

    def test_dynamic_grid_rnn(self):
        tf.nn.dynamic_rnn(self.cell, self.input_layer, dtype=tf.float32)

class BidirectionalGridRNNCellTest(tf.test.TestCase):
    def setUp(self):
        self.num_features = 1
        self.time_steps = 1
        self.batch_size = 1
        tf.reset_default_graph()
        self.input_layer = tf.placeholder(tf.float32, [self.batch_size, self.time_steps, self.num_features])
        self.cell_fw = grid_rnn_cell.Grid1LSTMCell(num_units=8)
        self.cell_bw = grid_rnn_cell.Grid1LSTMCell(num_units=8)

    def test_simple_bidirectional_grid_rnn(self):
        self.input_layer = reshape_to_rnn_dims(self.input_layer, [-1, self.num_features * self.time_steps])
        tf.nn.static_bidirectional_rnn(self.cell_fw, self.cell_fw, self.input_layer, dtype=tf.float32)

    def test_bidirectional_dynamic_grid_rnn(self):
        tf.nn.bidirectional_dynamic_rnn(self.cell_fw, self.cell_bw, self.input_layer, dtype=tf.float32)

if __name__ == '__main__':
    tf.test.main()

And here's one using contrib rnn:
import tensorflow as tf
from tensorflow.contrib.grid_rnn.python.ops import grid_rnn_cell
from tensorflow.contrib import rnn

class GridRNNTest(tf.test.TestCase):
    def setUp(self):
        self.num_features = 1
        self.time_steps = 1
        self.batch_size = 1
        tf.reset_default_graph()
        self.input_layer = tf.placeholder(tf.float32, [self.batch_size, self.time_steps, self.num_features])
        self.cell = grid_rnn_cell.Grid1LSTMCell(num_units=8)

    def test_simple_grid_rnn(self):
        self.input_layer = tf.unstack(self.input_layer, self.time_steps, 1)
        rnn.static_rnn(self.cell, self.input_layer, dtype=tf.float32)

class BidirectionalGridRNNTest(tf.test.TestCase):
    def setUp(self):
        self.num_features = 1
        self.time_steps = 1
        self.batch_size = 1
        tf.reset_default_graph()
        self.input_layer = tf.placeholder(tf.float32, [self.batch_size, self.time_steps, self.num_features])
        self.cell_fw = grid_rnn_cell.Grid1LSTMCell(num_units=8)
        self.cell_bw = grid_rnn_cell.Grid1LSTMCell(num_units=8)

    def test_simple_bidirectional_grid_rnn(self):
        self.input_layer = tf.unstack(self.input_layer, self.time_steps, 1)
        rnn.static_bidirectional_rnn(self.cell_fw, self.cell_bw, self.input_layer, dtype=tf.float32)

class StackBidirectionalGridRNNTest(tf.test.TestCase):
    def setUp(self):
        self.num_features = 1
        self.time_steps = 1
        self.batch_size = 1
        tf.reset_default_graph()
        self.input_layer = tf.placeholder(tf.float32, [self.batch_size, self.time_steps, self.num_features])
        self.cells_fw = [grid_rnn_cell.Grid1LSTMCell(num_units=8) for _ in range(2)]
        self.cells_bw = [grid_rnn_cell.Grid1LSTMCell(num_units=8) for _ in range(2)]

    '''
    def test_stack_bidirectional_grid_rnn(self):
        self.input_layer = tf.unstack(self.input_layer, self.time_steps, 1)
        rnn.stack_bidirectional_rnn(self.cells_fw, self.cells_fw, self.input_layer, dtype=tf.float32)
    '''

if __name__ == '__main__':
    tf.test.main()

This question is better asked on  StackOverflow since it is not a  bug or feature request. There is also a larger community that reads questions there. Thanks!


Ability to disable/remove right click context menu items.

I want to disable/remove the "Go To Type Definition" option in the editor's context menu. It could be either globally or whenever I activate my own extension.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


size_average in cross_entropy2d

In the code of cross_entropy2d, if size_average == True, then loss /= mask.data.sum(). The weight, however, is ignored. I think it should be changed to loss /= self.weight[target.data].sum() if there is a weight provided. Thanks!

hi, i also have problem in loss function, For 'Expected object of type torch.cuda.FloatTensor but found type torch.cuda.LongTensor for argument #3 'other''
so i use 'loss /= mask.data.sum().float()'  ,but i want to know how do u use 'loss /= self.weight[target.data].sum()'     for the full code of your loss funciton. can u give me ? and how about the result?


make tentez apply idempotent

make tentez apply idempotent.
This PR makes you able to skip been used steps.
If a current listener rule weight is old:new = 50:50 and you switch its weight old:new = 0:100, it will be ok.
Although if a current listener rule weight is old:new = 50:50 and you switch its weight old:new = 100:0, it will be skipped.

I'll rebase commits to understand easily after reviewed.

Thank you for your reviewing!


Fix how enum constants are initialized in codegen

Closes https://github.com/FuelLabs/sway/issues/1872
Basically some padding has to be added in situations where the variant that's being initialized is smaller than the total size of the enum. The rest of this change is working around this idea and cleaning up the reliance on the constant value type (the constant variant) instead of the type of the stack variable itself (the whole enum).
The padding is added between the tag of the enum and the variant. E.g.
enum E {
    X: b256,
    Y: u64,
}

Storing E::Y(42) into looks like:
word n:<PHONE_NUMBER>000001  // This is the tag
word n+1:<PHONE_NUMBER>000000  // First word of padding
word n+2:<PHONE_NUMBER>000000  // Second word of padding
word n+3:<PHONE_NUMBER>000000  // Third word of padding
word n+4:<PHONE_NUMBER>00002a  // The actual data

Also fixes parsing of const in IR. Previously, some consts were mistyped because there was no reliance on the actual type provided, so a union type was occasionally being missed (ConstantValue itself doesn't known union types).

So there was a subtle bug in parsing constants into the correct type?

Tiny issue but basically it is possible for the initializer to be, say, u64 but the real type is (u64 | b256) and that information was being occasionally dropped.


The email template variables don't work

The email templates variables in NotifyUsersWorkflowAction: {$Context.AbsoluteEditLink}, {$Context.LinkToPendingItems} don't do anything.
To reproduce just create a NotifyUsersWorkflowAction and enter those variables into the email template.
When the email is sent they will be blank.

I'm seeing this too.
		"silverstripe/cms": "3.3.1",
		"silverstripe/framework": "3.3.1",
		"silverstripe/blog": "2.4.0"

It looks like a previous change to how keywords were put together meant the handoff to methods was removed; these are now explicitly referenced (will PR that branch for one of the other guys to check shortly)

Thanks @nyeholt.
In the mean time @christopherbolt you can kludge around this if your workflows are simple and page-related with something like:
Edit Page
View Page

I pulled it directly from
http://www.sspaste.com/paste/show/5660b353b4bc7

Hi all,
Also having trouble with {$CommentHistory} - is there a quick workaround for that?
I get through the header (Comment history on this request:) but no comments below.
Thanks,
Andrew

Check CommentHistory.ss, but if the action didn't have any explicit Comment text, nothing will show up. You should be able to create your own templates/CommentHistory.ss in your project directory to output something different instead of only when there's comment text.

I realise this is an old issue, but I just came across it. I have a bunch of different Objects that go through Workflow, all of which are managed in different areas of the CMS.
My solution was to use the following for the email template:
{$Context.BaseHref}{$Context.CMSLink}

In NotifyUsersWorkflowAction::getContextFields() you can see that CMSLink is set by calling $target->CMSEditLink(), so I just made sure that all of my Objects had the CMSEditLink method, and that it returned the desired URL.

This is still an issue in 4.0.x-dev on SS3.6.2 big-ups to @chrispenny for the workaround.


Install fails on microk8s fresh install

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What version of the Traefik's Helm Chart are you using?
32.1.0
What version of Traefik are you using?
2.10.1
What did you do?
Attempting to install traefik on a microk8s cluster:
helm install -n traefik traefik traefik/traefik --debug

What did you see instead?
Yields the following error:
install.go:200: [debug] Original chart version: ""
install.go:217: [debug] CHART PATH: C:\Users\Daniel\AppData\Local\Temp\helm\repository\traefik-23.1.0.tgz

client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD ingressroutes.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD ingressroutetcps.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD ingressrouteudps.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD middlewares.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD middlewaretcps.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD serverstransports.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD tlsoptions.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD tlsstores.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD traefikservices.traefik.containo.us is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD ingressroutes.traefik.io is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD ingressroutetcps.traefik.io is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD ingressrouteudps.traefik.io is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD middlewares.traefik.io is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD middlewaretcps.traefik.io is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD serverstransports.traefik.io is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD tlsoptions.traefik.io is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD tlsstores.traefik.io is already present. Skipping.
client.go:134: [debug] creating 1 resource(s)
install.go:160: [debug] CRD traefikservices.traefik.io is already present. Skipping.
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: invalid character '<' looking for beginning of value
helm.go:84: [debug] error validating "": error validating data: invalid character '<' looking for beginning of value
helm.sh/helm/v3/pkg/kube.scrubValidationError
        helm.sh/helm/v3/pkg/kube/client.go:809
helm.sh/helm/v3/pkg/kube.(*Client).Build
        helm.sh/helm/v3/pkg/kube/client.go:350
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
        helm.sh/helm/v3/pkg/action/install.go:300
main.runInstall
        helm.sh/helm/v3/cmd/helm/install.go:286
main.newInstallCmd.func2
        helm.sh/helm/v3/cmd/helm/install.go:145
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/cobra@v1.6.1/command.go:916
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/cobra@v1.6.1/command.go:1044
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/cobra@v1.6.1/command.go:968
main.main
        helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
        runtime/proc.go:250
runtime.goexit
        runtime/asm_amd64.s:1598
unable to build kubernetes objects from release manifest
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
        helm.sh/helm/v3/pkg/action/install.go:302
main.runInstall
        helm.sh/helm/v3/cmd/helm/install.go:286
main.newInstallCmd.func2
        helm.sh/helm/v3/cmd/helm/install.go:145
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/cobra@v1.6.1/command.go:916
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/cobra@v1.6.1/command.go:1044
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/cobra@v1.6.1/command.go:968
main.main
        helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
        runtime/proc.go:250
runtime.goexit
        runtime/asm_amd64.s:1598
INSTALLATION FAILED
main.newInstallCmd.func2
        helm.sh/helm/v3/cmd/helm/install.go:147
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/cobra@v1.6.1/command.go:916
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/cobra@v1.6.1/command.go:1044
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/cobra@v1.6.1/command.go:968
main.main
        helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
        runtime/proc.go:250
runtime.goexit
        runtime/asm_amd64.s:1598

Multiple resets of the cluster, still same error every time.
What is your environment & configuration?
Kubernetes Version:
Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.2", GitCommit:"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647", GitTreeState:"clean", BuildDate:"2023-05-17T14:20:07Z", GoVersi
on:"go1.20.4", Compiler:"gc", Platform:"windows/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.2", GitCommit:"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647", GitTreeState:"clean", BuildDate:"2023-05-28T05:42:25Z", GoVersi
on:"go1.20.4", Compiler:"gc", Platform:"linux/amd64"}

Helm Version:
version.BuildInfo{Version:"v3.12.0", GitCommit:"c9f554d75773799f72ceef38c51210f1842a1dea", GitTreeState:"clean", GoVersion:"go1.20.3"}

Additional Information
I'm not exactly sure where to even start debugging error validating "": error validating data: invalid character '<' looking for beginning of value. There's no filename, nor anywhere obvious to look at. Am I missing something major here?
I can provide additional information if requested.

Just a heads up: I'm still trying to debug what went wrong, but after downgrading helm cli client to 3.9.2, the install worked smoothly.


Change set_logger to panic on error

Almost all invocations of this want to panic (they're at the beginning of main) and this may also be able to remove the closure argument (according to @sfackler).
We should rename the current API to try_set_logger for suitable use during tests.

I am working on this.

The same thing needs to happen for env_logger::init. There would be a try_init suitable for tests.

Can you guide me a bit how should I go about resolving this?

@alisha17 sure yeah! So right now the set_logger API is a global registration point for all loggers. As a result you can't really call it twice because the first logger is already registered. For that reason it currently returns a Result indicating "your logger was installed" or "no, some other logger was installed first and you lost the race".
This issue, however, is that 100% of the time if you're initializing logging as part of fn main you want unwrap the result! In that sense we should just bake in the unwrap-related panic to the function itself. So we'll want to change the signature of set_logger to return nothing. Now at the same time, however, fn main isn't the only place that we initialize loggers. Tests frequently start all test cases with my_logger::init() as we're not sure which test runs first. In that case we don't care who wins the race for registration (everyone's registering the same logger) so you'll typically see drop(my_logger::init()) to ignore the results. In that sense we need to preserve today's functionality with a function like try_set_logger alongside set_logger that has the same semantics as today.
So overall I think we'll be changing the log crate to look like:

pub fn set_logger(logger: Box<Log>, filter: LogLevelFilter);

pub fn try_set_logger<M>(make_logger: M) -> Result<(), SetLoggerError>
    where M: FnOnce(MaxLogLevelFilter) -> Box<Log>;

Does that sound right to you @sfackler?
Also what @dtolnay was mentioning is that most users rarely actually call the set_logger or try_set_logger functions but rather a baked in initialization function in the logger they're using (e.g. env_logger::init). That just means we should, as part of this change, change the env_logger crate to have:
pub fn init(); // note the lack of Result
pub fn try_init() -> Result<(), SetLoggerError>; // same as `init` today

Lemme know if you've still got any more questions though!

I guess the function set_logger already panics on error. It might have been fixed as a result of some other bug?
Although the renaming still remains to be done.

This set_logger function returns a SetLoggerError if there is an error. It does not panic.

If I remove the closure argument in the current set_logger function, won't it change the aesthetics of the function?

But how can I remove the closure argument in the set_logger function without changing the aesthetics of the function?

@alisha17 it'd probably look liek:
pub fn set_logger(logger: Box<Log>, filter: LogLevelFilter) {
    match try_set_logger(|max| { max.set(filter); logger) {
        Ok(()) => {}
        Err(_) => panic!("global logger is already initialized"),
    }
}

Fixed.


Python driver

Are there any estimations on making python driver for ClickHouse?
Or.. what is the best way of running queries from Python?

There is 3rd party python driver: https://github.com/Infinidat/infi.clickhouse_orm

Or.. what is the best way of running queries from Python?

Try this driver.
Otherwise, simply send requests with urllib2.

will give it a try, thanks!
was not very obvious where to look for the driver though ))

Added to documentation: https://clickhouse.yandex/reference_en.html#Third-party client libraries


Rotation bugfix.

As this is a reversal of https://github.com/atsar/hammer.js/commit/287720a6e5067e7f28be8b8b3b266d22905361c4 I'd like more info on what the perceived bug is.

The getRotation function returns the change of the angle since the rotation start. When you land two fingers on the screen, it gives start[0] and start[1] points that determine the orientation relative to the screen. Then, when you move them, it gives end[0] and end[1] - new current finger locations. So, the rotation is the difference (minus) between the end orientation and the start orientation. If you put plus there, it simply gives incorrect number.
Imagine that you just start the rotation. Then end=start, and the rotation should be zero. Having plus in the formula gives you the doubled angle between the line connecting your fingers and the screen horizontal, which is meaningless.

@atsar the current logic is correct let me explain.
the formula to get the angle relative to the screen for 2 points is
angle = atan( y2 - y1, x2 - x1 ) * 180 / Math.PI
No lets take the very simple case of our starting points being at 1,1 and 3,1 using the formula above this gives us a starting angle of 0
No we move the second point to 3,3  this is a 45 degree rotation and this is confirmed using the formula above. Since we started at 0 and end at 45 the total rotation is 45 which is the result of the current formula if we made your change we would get -45 which would be incorrect since we rotated in the positive ( clockwise ) direction.
This can also be confirmed in the negative or counterclockwise direction. Again starting at 1,1 and 3,1 this time we move the first point to 1,3 and leave the second one in place. The above formula gives us an angle of -45 then adding the 2 angles we get 0 + -45 = -45 which is correct since we rotated in the negative direction this time.

looking back at 287720a this is not a regression of #791 which it claims to fix but rather #791 was never fixed and this commit was just not correct.

I would like to get this merged @arschmitz I think it resolves the 90deg jump issue.

@runspired sounds good to me based on my comment above i think this is completely correct

whats the status on this merge ?

@arschmitz hey there! Almost a year has passed. Can it be merged? Need it resolved.

@arschmitz is this project dead?

I had big problems with the pinch and rotate example on the webiste. No solution really worked.
But this bugfix totally solved it.
So for everyone who is looking for a bugfix for the pinch and rotate problem (jumping the moment you touch aso...) use this bugfix - just change the + to a minus and it works

This has been applied in proposed 2.1.0: https://github.com/squadette/hammer.js/issues/1
@arschmitz, thank you for the detailed explanation.

Any chance to merge this fix if we open a pr with conflict solved?


Release/1.6.0

add function to search for different files found in datasets
implement the listing of datasets given sample codes
change build system to github actions
add datastore server API
use new changelog style

@wow-such-code is this still up to date? You did not request a review here

@wow-such-code is this still up to date? You did not request a review here

I think I talked to @sven1103 about this, but we forgot. It is still up to date and needed sooner or later, but conflicts need to be solved.

included in #49


Add the Cyberpunk Red Tabbed character sheet.

Changes / Comments
This pull request adds a character sheet for Cyberpunk Red based on the final published rules of the game.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Yes, "Cyberpunk Red Tabbed" is the name of the new sheet.
[x] Is this a bug fix? No.
[x] Does this add functional enhancements (new features or extending existing features)? Yes(?), it adds a new character sheet.
[x] Does this add or change functional aesthetics (such as layout or color scheme)? Only within the sheet and roll templates.
[x] If changing or removing attributes, what steps have you taken, if any, to preserve player data? This is a new sheet, not applicable.
[x] If this is a new sheet, did you follow Building Character Sheets standards? Yes

@Anduh Good point about the preview image, I've cropped it down to "just the sheet" and updated the file.
As far as multiple sheets being submitted: It's a new game that a lot of folks have been waiting for, I'm not sure what would be a clear path to address that scenario.


revision in xmlns support

With netopeer2 in Version 2.2.13, on top of embedded module ietf-crypto-types in revision 2023-12-28, we are loaded same module but in revision 2019-04-29.
Seems to be properly supported by the NC Server, as both modules are displayed via sysrepoctl --list cmd, each one with its own revision.
Now, at NC Client side, in a the xml payload of a rpc, we want to refer module in revision 2019-04-29 without really knowing if possible....
we have try several syntax :
<algorithm xmlns="urn:ietf:params:xml:ns:yang:ietf-crypto-types?revision=2019-04-29">secp256r1</algorithm>
<algorithm xmlns="urn:ietf:params:xml:ns:yang:ietf-crypto-types?revision=2019-04-29&module=ietf-crypto-types">secp256r1</algorithm>

But, none is working.
Error returned by CLI is are the following :

user-rpc --content=/opt/dev/xml/file-download-vnr-ok.xml
ly ERROR: No module with namespace "urn:yang:ietf-crypto-types?revision=2019-04-29" in the context. (Data location "/file-management:file-download/server/keys", line number 10.)
nc ERROR: Failed to create RPC, perhaps a required feature is disabled.
cli_send_recv: Failed to send the RPC.
user-rpc --content=/opt/dev/xml/file-download-vnr-ok.xml
ly ERROR: No module with namespace "urn:ietf-crypto-types?revision=2019-04-29" in the context. (Data location "/file-management:file-download/server/keys", line number 10.)
nc ERROR: Failed to create RPC, perhaps a required feature is disabled.
cli_send_recv: Failed to send the RPC.
user-rpc --content=/opt/dev/xml/file-download-vnr-ok.xml
ly ERROR: No module with namespace "urn:ietf:params:xml:ns:yang:ietf-crypto-types:2019-04-29" in the context. (Data location "/file-management:file-download/server/keys", line number 10.)
nc ERROR: Failed to create RPC, perhaps a required feature is disabled.
cli_send_recv: Failed to send the RPC.

Does specification of a module revision is supported in an xml payload via usage of xmlns ?
It yes what is the syntax ?

It must be noted that whatever the revision of ietf-crypto-types, namespace remain the same :
namespace "urn:ietf:params:xml:ns:yang:ietf-crypto-types";
So without model number at the end, like it could be :
namespace "urn:ietf:params:xml:ns:yang:ietf-crypto-types:1.0";
So only remaining solution to map the NC Client to the targeted ietf-crypto-module of the NC Server is to use the revision

Does specification of a module revision is supported in an xml payload via usage of xmlns ?

No, it is not possible at all. There can be several revisions of a single module loaded into a YANG context but only one is implemented. This revision is then used for parsing all the data of the module. The 2023 revision must be implemented because there are features and identities. So, if you also require the 2019 revision to be implemented, you have a problem because such a context cannot be created.

Ok, understood for IETF modules embedded into Netopeer2 NC Server.
But what about pure application modules, if an application has set two module with same name, same prefix, but with different iteration of the namescape : "urn:application:1.0" and "urn:application:1.1"
Does Netopeer2 is able to map xml NETCONF payload from NC Client to each module loaded in NC Server ?
<color> xmlnx:app="urn:application:1.0">app::bleu</color>
<color> xmlnx:app="urn:application:1.1">app::bleu</color>

You should fail to load such modules, a YANG module cannot change its namespace (meaning a single module name used for 2 namespaces).

As said, in the scenario described above, there are two modules loaded in NC Server :

application.yang in revision x having namescape "urn:application:1.0", prefix app
application.yang in revision y having namespace "urn:application:1.1", prefix app
Expectation is that NC Client can select the module to be used into the NC Server ( revision x or y )  just by declaring the proper namescape in the xml payload

Like I said, this is not supported or in any way possible in YANG/NETCONF.


Respawn at some location before transferring to other shard

Does what https://github.com/Civcraft/BetterShards/pull/108 does, but a lot cleaner

No, because if we add them to transit before the connect method is called 1 tick later, it wont send the player. I'll add something to bypass that check.

I assumed you'd do that as well since you mentioned it in the prior comment :)

Is this still needed?

The underlying issue still exists, but this is the wrong approach


Where is the URL lists of download-images.py

I can't run the download-images.py to get the images, and it does not exist: b'image-graph_urls/URLS_google.txt'
Can you provide this url.txt file, thank your very much.

I can't run the download-images.py to get the images, and it does not exist: b'image-graph_urls/URLS_google.txt' Can you provide this url.txt file, thank your very much.

Did you solve the problem?I have the same problem and don't know how to solve it.


Error when //inertial/pose/@relative_to is non-default

Closes https://github.com/osrf/sdformat/issues/380

Codecov Report

Merging #480 (78bd773) into master (b9fc657) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   88.14%   88.15%
=======================================
  Files          66       66
  Lines        9969     9975    +6
=======================================
+ Hits         8787     8793    +6
  Misses       1182     1182

Impacted Files
Coverage Δ

src/Link.cc
97.76% <100.00%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fc657...c3cfff6. Read the comment docs.

Codecov Report

Merging #480 (78bd773) into master (b9fc657) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #480   +/-   ##
=======================================
  Coverage   88.14%   88.15%
=======================================
  Files          66       66
  Lines        9969     9975    +6
=======================================
+ Hits         8787     8793    +6
  Misses       1182     1182

Impacted Files
Coverage Δ

src/Link.cc
97.76% <100.00%> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9fc657...c3cfff6. Read the comment docs.


Ability to output a combined config file from set of declarative state files

When using Kong DB-Less it can be very useful to store configuration in separate files
eg.
service1.yaml
service2.yaml
consumers.yaml
and then combine these to provide as a declarative config file to a DB-Less setup.
Currently there appears to be no standard way to combine the files without sync'ing to a Kong database backed setup.
The DeCK code already contains the logic required to combine the files as it uses this for sync etc as I understand it (I've not developed in Go before, so my reading of the code is approximate).
If the logic to combine the files can be used to simply write out a combined config file this would be extremely useful for those people using DB-Less mode.
For example:
deck dump --state /some/directory/  --output  combined-kong-config.yaml

Any YAML/JSON merge tool should be able to help you. Every state file is a valid JSON object (and by extension, YAML too). Merge all arrays by concatenating them. That's pretty much what decK does internally.

Closing this for now. Feel free to reopen if you have more questions!


Codec enters a low-power state on idle (High Sierra)

I'm using the latest versions of Lilu and AppleALC on an ASUS Z170I motherboard, which has the ALC1150 audio codec, with iMac17,1 as the system definition and 1 as the layout ID. AppleALC worked fine for me on Sierra, but after I upgraded to High Sierra, I noticed that sound would often disappear after a period of inactivity. I checked the logs in Console.app, and from the looks of it, this is because of macOS putting the codec in a low-power state (I should also add that my motherboard has an EAPD). From what I've read on the applelife.ru forums, this only occurs when iMac is used as a system definition, and AppleALC is supposed to have a workaround for this (this must be what the AFGLowPowerState key is for in Info.plist), but for some reason, the workaround no longer works for me. Setting AFGLowPowerState to false in Clover does not do anything, either. Nor does the CodecCommander kext do anything to fix the problem, because it only reinitialises the EAPD after the system wakes up from sleep.
Is there anything that can be done to fix this? If there's any other information that you need, I'll be happy to provide it.

Add CodecCommander.kext. ResetHDA and AFGLowPowerState is not enough for ALC1150
This CodecCommander.kext with special fixes for ALC1150
CodecCommander.kext.zip
Report back.

No, that doesn't seem to have done anything - the codec still enters a low-power state, and I still get no sound when it comes back from it.

By the way, putting the system into sleep and then waking it up does trigger CodecCommander and temporarily bring sound back, but then it just disappears once again after a period of inactivity.


Make the theme available for t9n

In a way to promote i18n and in addition of a languages.yaml file (other PR), this PR is a strating point to turn the theme translatable.
If you agree by merging this one then I will continue this process on other strings.
Thanks

Hi,
thank you. Feel free to continue this work. I'll merge the rest next week when I come back from holidays

Have fun then :smile:


Pod Try stats are always "null" in the db

could be from the plugin
could be from stats.cp.org

doesn't look like there's a test specifically around pod try on stats.cp.org

I added a quick test for it on stats, looks like it's working fine, must be not coming from the client

Yeah, come to the same conclusion, but I'm not sure why

Fixed in the client


feat: aggregated from defective #92

sorry about making a new PR
i made so many mistakes on #92 so i have made a new branch upstream with aggregated list from patch-1 repo

@mpsq can you please review and merge?

I am just waiting for you to fix the 2 comments I added in the last review

wait lmao i thought you changed it when you posted the recommendations

btw it seems that you did change Stacking Compositor to Stacking compositor
idk what happened im new to git itself


Perform either helm push or skopeo copy

Dumb
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Using object.size() in init.R could be expensive

Describe the bug
87f9bb6f8b450d897fb191780b086de07805fd4e in #544  uses object.size(obj) in inspect_env in init.R to support showing object size in the workspace viewer. However, the performance of this function could be extremely poor if the object contains character vectors in it.
library(data.table)
dt <- data.table(id = 1:5000000)
for (i in 1:20) {
  dt[, paste0("x", i) := rep("hello", .N)]
}
system.time(object.size(dt))

   user  system elapsed
  1.068   0.687   1.741

This means, with session watcher enabled, whenever this data table is present in the global environment, then user has to wait for 1.7s after evaluating each top-level expression.
Therefore, I don't think we should call object.size() so eagerly in this way.

@ ElianHugh Do you think we should remove this call or at least be more conservative using this?

@Ikuyadeu This issue is quite blocking for users who work with large data with a few character vectors as the R session will become too laggy to use. I suggest that we make a quick release when #581 is merged.

Apologies, that's definitely not intended! I agree, we should remove the call.

I'm not sure of a way around this in base-R given this stackoverflow post.
Comparing alternatives in RStudio:
system.time(object.size(dt))
user  system elapsed
2.06    0.75    3.14
system.time(lobstr::obj_size(dt))
user  system elapsed
6.89    0.02    7.69
Or we could estimate it by getting the size of a subset of a given object?

Or we could estimate it by getting the size of a subset of a given object?

It might add too much complexity if we take into account nested list, environment, object attributes, etc. where character vector could appear anywhere.

Agreed. I was looking through RStudio and it looks like they use object.size for their environment pane. I suppose using object.size would require a more substantial rewrite than is worth at the moment

Maybe one can record the timings on first invocation, and turn off the auto-object.size-calculation if the timing result is above a given threshold. Most people do not work with huge character vectors in interactive sessions.

I implement a method in the middle ground, i.e. we only call object.size() when the either a symbol is not present in the cache or its memory address has changed. This will work with most cases but ignores those with in-place updates on an object.

I implement a method in the middle ground, i.e. we only call object.size() when either a symbol is not present in the cache or its memory address has changed. This will work with most cases but ignores those with in-place updates on an object.

This is awesome and a great middle ground, thank you!

With #581 merged, wow the object.size() is called less frequently: it is called only when a new symbol appears or its memory address or length has changed.
And we have an option vsc.show_object_size to opt-in. It is disabled by default to minimize possible delay.


add/update instance type for sgp/windows

Issue #, if available: #87 and #91
Description of changes:

Update the Branch ENI and Windows IPv4 Address Limits.

Testing Performed
The changes can be categorized into multiple buckets. Spot checked a couple of instance types and verified the maximum number of Branch ENIs that can be created.

New Instance Types - Tested one instance from different families - c6a.12xlarge, c6i.12xlarge, m6a.16xlarge, r6i.12xlarge, x2iezn.12xlarge
Branch ENI Limit Increase - Tested with - d3.4xlarge, r5.metal
Previously Unsupported, Now Supported - Tested with g4ad.16xlarge, i3.metal, m5zn.12xlarge
Reduced Number of Branch ENIs - Looks like previously were provided with wrong values and the current value seem accurate - Tested with i3en.12xlarge, d3en.xlarge

Callouts
vt1.24xlarge - Seems to not work due to IMDS issues. No issues with allocation of Branch ENI from vpc-resource-controller.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

lgtm, maybe we can add a workflow in cni repo to update this repo when new instance is added?

Unfortunately this is a manual step as of now because we don't have the Branch ENI limits publicly available.

lgtm, maybe we can add a workflow in cni repo to update this repo when new instance is added?

Unfortunately this is a manual step as of now because we don't have the Branch ENI limits publicly available.

Ahh ok.

This is strange the integration tests have been failing continuously, I suspect it has to do with the recent changes we made with #94


MM-36696: global threads list now virtualized

Summary
Global threads list is virtualized to avoid rendering all thread
items at once.
This reduces the time needed to enter the threads route.
Ticket Link
https://mattermost.atlassian.net/browse/MM-36696
Release Note
NONE

@koox00 this seems great to me, but I'm not sure the test server is the best place to test on since it doesn't have a lot of data yet.
Is there anything specific from a UX perspective that I should pay close attention to in the review? I'm not seeing anything glaring

@matthewbirtch @koox00 do we want to add a loading indicator at the bottom of the list if you scroll down and threads are still fetching? I throttled my connection to "slow 3G" then scrolled down really fast and there was no indication that more threads were loading in until they were returned. In the center channel we have the three dots pulsing animation

This is important for slow or unstable connections ^

@matthewbirtch @koox00 do we want to add a loading indicator at the bottom of the list if you scroll down and threads are still fetching? I throttled my connection to "slow 3G" then scrolled down really fast and there was no indication that more threads were loading in until they were returned. In the center channel we have the three dots pulsing animation

@esethna the infinite loading will be added later on, this PR is just to improve rendering performance of the list so that the time to enter threads view is reduced.

Ah got it, thanks @koox00

@hmhealey, @calebroseland I've added some changes to improve performance, can you take a look?

/update-branch

@koox00 I didn't merge this due to conflicts, can you please take a look? Thanks.

/cherry-pick cloud

Cherry pick is scheduled.


Verbose Macro Diagnostic Messages

The existing macro diagnostic messages are being emitted as capitalized enum case names.
It would be ideal to have their human-readable verbose error descriptions be shown instead.

It appears that adding CustomStringConvertible conformance to the Error type may be all that's needed (assuming this in fact produces the diagnostic message).
https://github.com/swiftlang/swift-syntax/blob/0530f3ec64d83879d223675afd8e577b752b0d5f/Examples/Sources/MacroExamples/Implementation/Diagnostics.swift#L26-L35

Done. Will be in next release.


Issue in TextValidator children rendering

I have used InputMask component in side of TextValidator and its worked fine in react.15x after updating its not working. Please check below code. How i can make it happen please help us
             <TextValidator
                validatorListener={this.validatorListener}
                hintText="Home Phone"
                value={this.state._phone1}
                className="drawer-form-input-text"
                label="Home Phone"
                name="bill_phone1"
                key="bill_phone1"
                onChange={this.handleSecondryContact}
              >
                <InputMask
                  hintText="Home Phone"
                  value={this.state.secondryContact.bill_phone1}
                  mask="(999) 999-9999"
                  onChange={this.handleSecondryContact}
                  className="drawer-form-input-text"
                  name="bill_phone1"
                />
              </TextValidator>

Hi,
please provide versions of packages

"react-material-ui-form-validator": "^2.0.0-beta.10",
"react-input-mask": "^1.2.2",

So if your problem is related to react-material-ui-form-validator please create issue here


Generalized search interfaces

To make it possible to share code and don’t have to do our work for every CMS again and again, I think it would best If we could agree on a set of interfaces for the search.
The frontends for every CMS could then be based on those interfaces which would make it possible to share search backends across different projects.
For Contao we would create a MySQL backend for the search as this is our main use case.
A first draft of interfaces I have in mind (these are just a starting point to get the discussion going):
interface SearchInterface
{
    public function query(string $query, SearchOptionsInterface $options): SearchResultCollectionInterface;

    public function index(string $identifier, array $texts, ?MetaDataInterface $metadata = null): void;

    public function getFromIndex(string $identifier): SearchResultInterface;

    public function removeFromIndex(string $identifier): void;
}

interface SearchResultCollectionInterface extends \Iterator, \Countable
{
    public function current(): SearchResultInterface;

    public function getQuery(): string;
}

interface SearchResultInterface
{
    public function getIdentifier(): string;

    public function getMetaData(): ?MetaDataInterface;

    /**
     * @return array<string>
     */
    public function getMatches(): array;

    /**
     * @return array<string>
     */
    public function getTexts(): array;

    public function getContext(int $length): string;

    /**
     * @return array<array<string>>
     */
    public function getTextsWithMatches(): array;

    /**
     * @return array<string>
     */
    public function getContextWithMatches(int $length): array;
}

interface MetaDataInterface
{
    public function serialize(): string;

    public static function fromSerialized(string $serialized): self;
}

interface SearchOptionsInterface
{
    // ...
}

Instead of array $texts we should probably create a DocumentInterface and for string $query a SearchQueryInterface?

+1 for DocumentInterface. Not sure about the SearchQueryInterface though; isn't the query always a string?

What is the difference between getTextsWithMatches() and getContextWithMatches()?

What is the difference between getTextsWithMatches() and getContextWithMatches()?

getTextsWithMatches() would return the whole document text(s) where all matching words are marked. getContextWithMatches() would only return a substring of speficied length relevant to the query.
But If we use a DocumentInterface getTexts() and getTextsWithMatches() would probably be combined to a single method getDocument().


Allow empty path when HTTP method is CONNECT

Fix for issue #269
Retrieves :method before :path to allow request without path if HTTP method is CONNECT.

Overall LGTM, thanks for the PR, and sorry for the delay!
We have to investigate a bit more on https://github.com/corazawaf/coraza-proxy-wasm/actions/runs/8798212059/job/24370940809?pr=270#step:10:4165, Looks like 920100-6 CRS test is failing consistently and it is indeed about CONNECT requests.
Test: https://github.com/coreruleset/coreruleset/blob/67a4d5e5b93d9b4067970d2dc712b6eac83214af/tests/regression/tests/REQUEST-920-PROTOCOL-ENFORCEMENT/920100.yaml#L91
Rule: https://github.com/coreruleset/coreruleset/blob/v4.0.0/rules/REQUEST-920-PROTOCOL-ENFORCEMENT.conf#L33-L69

I see this in the ftw-envoy-logs, CONNECT method not allowed in policy file:

Method is not allowed by policy [file<EMAIL_ADDRESS>
In our usage of Coraza Proxy Wasm we have overridden a rule to allow CONNECT requests:

  SecAction "id:8901160,phase:1,pass,nolog,ver:'OWASP_CRS/4.0.0',setvar:'tx.allowed_methods=GET HEAD CONNECT PUT DELETE POST OPTIONS'"

Hey,

I see this in the ftw-envoy-logs, CONNECT method not allowed in policy file:

This should be fine, the tests are meant to test the CRS default behavior, therefore it is expected that a CONNECT request triggers this log.

In our usage of Coraza Proxy Wasm we have overridden a rule to allow CONNECT requests:

That being said, It is totally reasonable to extend tx.allowed_methods for a customized behavior that supports CONNECT requests.

The failing test we have is about 920100 rule, that leads us to this log line:
[2024-04-29 11:03:46.270932][22][warning][wasm] [source/extensions/common/wasm/context.cc:1174] wasm log coraza-filter my_vm_id: [client "<IP_ADDRESS>"] Coraza: Warning. Invalid HTTP Request Line [file<EMAIL_ADDRESS>[line "1769"] [id "920100"] [rev ""] [msg "Invalid HTTP Request Line"] [data "CONNECT  HTTP/1.1"] [severity "warning"] [ver "OWASP_CRS/4.0.0"] [maturity "0"] [accuracy "0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-protocol"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "capec/1000/210/272"] [hostname "<IP_ADDRESS>"] [uri ""] [unique_id "TPqJsohpAhmWEFmtPGW"]

920100 is ensuring the following pattern for a CONNECT request:
##! Cover the CONNECT method
##! Meth |----- IPv4 Address ------|- Port -| Protocol |
^connect (?:\d{1,3}\.){3}\d{1,3}\.?(?::\d+)?\s+[\w\./]+$

But the REQUEST_LINE checked is CONNECT  HTTP/1.1 when it should be CONNECT www.coreruleset.org:80 HTTP/1.1 (see the URI provided by the test here).
The request line is populated in Coraza as follows (see here):
tx.variables.requestLine.Set(fmt.Sprintf("%s %s %s", method, uri, httpVersion))

So, the key point is that in the context of a CONNECT request, even if the path is empty, we should still manage to populate the uri and call ProcessURI with www.coreruleset.org:80 and not just an empty string that comes from an empty :path (Note also to myself, I did not try to fix it yet, but just figured out what is going on)


refactor: add correct superset types of express.Request

Delete unused express.d.ts file

maybe say "please"?


New to using Instaloader and unable to download stories

Hi everyone,
INTRODUCTION
I'm a first-time user of Instaloader (I used to use 4KStogram and Raider), and I'm trying to learn how to use this program. I'm a complete beginner when it comes to coding, so please bear with me.
THE ISSUE/WHAT I'M TRYING TO DO
I'm trying to download the stories of a user, but not their posts. IG has been going crazy with banning accounts and/or flagging users as bots lately, so I figured I would download stories while logged in, but only download posts while logged out to reduce API calls.
WHAT I TRIED
Anyway, here's what I typed.
(I replaced username with my real username, and password with my real password, and the target is @foodnetwork)
instaloader --login=username -p=password  --abort-on=302,400,401,429,403 --no-posts --stories foodnetwork
ERROR MESSAGE
And here's the response I got. No stories were downloaded.
Loaded session from /Users/myname/.config/instaloader/session-username.
Error when checking if logged in: Query to https://www.instagram.com/graphql/query responded with "401 Unauthorized": {"message":"Please wait a few minutes before you try again.","require_login":true,"igweb_rollout":true,"status":"fail"}
Logged in as username.
Stored ID 25742083 for profile foodnetwork.
[1/1] Downloading profile foodnetwork
Unable to fetch high quality profile pic: 'hd_profile_pic_url_info'
foodnetwork/2022-10-05_03-51-16_UTC_profile_pic.jpg
Downloading stories
Saved session to /Users/myname/.config/instaloader/session-username.

Errors or warnings occurred:
Error when checking if logged in: Query to https://www.instagram.com/graphql/query responded with "401 Unauthorized": {"message":"Please wait a few minutes before you try again.","require_login":true,"igweb_rollout":true,"status":"fail"}
Unable to fetch high quality profile pic: 'hd_profile_pic_url_info'

QUESTION
How do I fix this? What am I doing wrong?
Once I figure this out, I plan to come up with a list of usernames I want to download (using the args.txt command, I suppose?).
(If anyone has copy-pastable codes for what they do, I'd love to see it! Thank you)

Ok, I tried doing an args.txt file but it's still not working. I've typed
instaloader +args.txt
And in the args.txt file, I've written
–login=username –password=password --abort-on=302,400,401,429,403 --no-posts --stories foodnetwork
I get the following response:
instaloader: error: unrecognized arguments: foodnetwork
Please help.

Ok, I've read this guide and tried doing an args.txt file but it's still not working. I've typed
instaloader +args.txt
And in the args.txt file, I've written
--login=username
--password=password
--abort-on=302,400,401,429,403
--no-posts
--stories
foodnetwork

I get the following response:
[1/1] Downloading profile foodnetwork
Unable to fetch high quality profile pic: 'hd_profile_pic_url_info'
foodnetwork/2023-02-20_07-42-02_UTC_profile_pic.jpg already exists
Downloading stories
Saved session to /Users/myname/.config/instaloader/session-username.

Errors or warnings occurred:
Unable to fetch high quality profile pic: 'hd_profile_pic_url_info'

Please help.
Edited: Figured out the login issue and edited above. Still unable to download story.

Tried it again with no changes and got a different response this time:
Loaded session from /Users/myname/.config/instaloader/session-username.
Error when checking if logged in: Query to https://www.instagram.com/graphql/query responded with "401 Unauthorized": {"message":"Please wait a few minutes before you try again.","require_login":true,"igweb_rollout":true,"status":"fail"}
Logged in as username.
[1/1] Downloading profile foodnetwork
Unable to fetch high quality profile pic: 'hd_profile_pic_url_info'
foodnetwork/2023-02-20_07-42-02_UTC_profile_pic.jpg already exists
Downloading stories
Saved session to /Users/myname/.config/instaloader/session-username.

Errors or warnings occurred:
Error when checking if logged in: Query to https://www.instagram.com/graphql/query responded with "401 Unauthorized": {"message":"Please wait a few minutes before you try again.","require_login":true,"igweb_rollout":true,"status":"fail"}
Unable to fetch high quality profile pic: 'hd_profile_pic_url_info'

My account is fine when I login on the web, though. No warning messages from IG.

If you can't login / download through password I would recommend you to use your cookies from your browser. That's what at least worked for me. I mean it's not a solution for the problem, but a workaround.
Example: instaloader -b <your_browser>
You need to have the browser cookie library installed. You can do so with: pip install browser_cookies3


Current behavior is like that on purpose and there's a test for it in ViewTest.php:

Current behavior is like that on purpose and there's a test for it in ViewTest.php:
// The timestamp setting won't be redefined because global AssetManager is used
$view = new View();
$view->registerJsFile('/assetSources/js/jquery.js', [
    'appendTimestamp' => true,
    'depends' => 'yii\web\AssetBundle',
]); // <script src="/assetSources/js/jquery.js"></script>
$html =<EMAIL_ADDRESS>['content' => 'content']);
$this->assertNotRegExp($pattern, $html);

Similar for CSS.
The reasoning was that while script itself changes, dependencies are likely static and to be cached. That's why options of individual script / CSS aren't propagated and instead use either config of the asset bundle itself or asset manager config.
Thank you for contributing but won't merge the pull request:

The behavior is correct one for some valid cases.
It is configurable.
It's covered by tests so changing it is a backwards compatibility break for the functionality developers may rely on.

Originally posted by @samdark in https://github.com/yiisoft/yii2/pull/18068#issuecomment-653251537

Thanks for replying, my english is not very good. I didn't understand the reason you said. When registerJsFile or registerCssFile have depends, the options will not work.The dependent AssetBundle option of individual script / CSS also does not work. What is the meaning of this depends.

The options will work but will not be passed to dependencies. That was made on purpose and is exptected.

The options will work but will not be passed to dependencies. That was made on purpose and is exptected.

I know it not be passed to dependencies. But the options not work. I posted an example. Details as follows：
// This is AssetBundle
class ModuleAsset extends AssetBundle
{
    public $basePath = '@webroot';
    public $baseUrl = '@web';
    public $css = [
        ['/css/style.css']
    ];
    public $js = [
        ['/js/jquery.min.js'],
        ['/js/swiper.min.js']
    ];
    public $depends = [
    ];
    public $cssOptions = ['appendTimestamp' => true];
    public $jsOptions = [
        'position' => View::POS_END,
        'appendTimestamp' => true
    ];
}
// When i use it like this,  The '/js/zui.min.js' position and timestamp are not effective.
$view->registerJsFile('/js/zui.min.js',
['depends' => [ModuleAsset::class],'position' => View::POS_HEAD,'appendTimestamp' => true]
);

Do you mean that zui.min.js itself won't get appendTimestamp in URL?

Do you mean that zui.min.js itself won't get appendTimestamp in URL?

Yes. zui.min.js appendTimestamp and position are not work.

position is actually expected since taking it into account will likely cause conflict with dependencies positions.

position is actually expected since taking it into account will likely cause conflict with dependencies positions. But appendTimestamp not adding timestamp to primary asset isn't correct.

Thank you for your answer.


allow callback as second param on optional parameters.

The method getBlock and others have an optional second parameter. Allow it be a callback function if caller does not want to pass any parameters.
//current
bcapi.getBlock(300000, {}, printResponse); //works
bcapi.getBlock(300000, printResponse); //fails with cb is not a function error

//proposed
bcapi.getBlock(300000, {}, printResponse); //works
bcapi.getBlock(300000, printResponse); //works

I'm still having problems with this...


added shop context to generateProductFeedCommand

Description

Questions
Answers

Why?
Without the shop context you only get "http://localhost" images when you trigger the CLI command. Now you can pass the shop id to the command or leave it by default and it will get the default shop.

BC breaks?
yes/no

Tests exists & pass?
yes

Related tickets?
no

How to test?
php bin/console sw:product:feeds:refresh --shop=1

Is this still an issue? We've changed the behaviour of export urls in the latest version.
Can you please verify the need of your PR?

This PR was closed due to inactivity. If this change is still important to you, feel free to create a new pull request.
For more information about our contribution guidelines, see https://developers.shopware.com/contributing/contribution-guideline/.