Feature request: XML Solution (SLNX) workflow

Visual Studio Preview has a new workflow feature with the .slnx solution as an alternative to the traditional .sln that uses GUID, which is pretty much useless. XML Solution seems to make the project structure simpler and the code may also be easier to understand.
I hope the dev team and fellow contributors will agree with this, because this feature will be very helpful.

And in addition to support it in VS Code it would of bourse be very nice to have it in the dotnet CLI tooling as well and in the templates.

slnx will surely be the de facto standard for sln files going forward. Commenting to register my interest in this feature being available to use in vsCode

I don't have a lot of information here, but I expect once core MSBuild supports and can parse the new format the C# extension will also be able to support it.

MSBuild tracking issue for SLNX support https://github.com/dotnet/msbuild/issues/10266

Any update on this?


Search vector search

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-search-documents


Extension - Don't display network on Mission pool details

Describe the task
Link design : https://www.figma.com/file/2nYhrm0rlJtfJoMwrT51Ep/SubWallet-Apps?type=design&node-id=12103-201786&mode=dev

[x] Don't display network on Mission pool details when network > 1

Expect :

[x] Update logo Twiter

Version test : http://file.cdmteck.com/s/sBTaMZigGj2B7n2

[ ] Re-check logo Twitter

Version test : http://file.cdmteck.com/s/KrADDJ2dfr7qyE2
Validation passed in case :

Update logo

Filter and search mission pools


feat: add item props validation

What: Add validation for getItemProps

Why: Because forgetting the item and index is easy to do.

How: Awesome default params trick :wink:

Checklist:

[ ] Documentation N/A
[x] Tests
[x] Ready to be merged
[ ] Added myself to contributors table N/A

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #141   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           3      3
  Lines         261    262    +1
  Branches       63     63
=====================================
+ Hits          261    262    +1

Impacted Files
Coverage Δ

src/downshift.js
100% <ø> (ø)
:arrow_up:

src/utils.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1009a1b...20184c2. Read the comment docs.


Some aliases in context.json are western-centric

Looking through the aliases for predicates in context.json, it was pointed out to me that some of them are specific to western audiences. For example, foaf:givenName being aliased as "firstName" is not very internationalization-friendly.

True. Problem is that we'd be breaking backward compatibility if we change this now.
I probably want to wait until we have consensus about what fields to use by default.
For now, I would suggest to indeed stick to givenName etc.

Maybe we could provide multiple aliases for the same predicate, to preserve backwards compatibiility


S0 Energy Meter connected to SolarWatt EnergyManager

Hi,
the SolarWatt Energy Manager has 2 Ports for a S0 Energy Meter.
I have connected a S0 Energy Meter to the first Port to get the consumption of a heatpump.
Can you add the Values for this device ?
Needed DataFields should be:
PowerIn
WorkIn
And for Users Measure in both directions:
PowerOut
WorkOut
(ioBroker fetches the complete data from the energymanager and all connected devices like inverter or ev-station.)
Thank You
Andreas

Can you send me a sample of the JSON data?

Attached the json export from /rest/kiwigrid/wizard/devices.
You find the s0counter and also other devices like ev-station or a plug.
devices.zip

Do you have any idea what units the power and work values are? W and Wh?

I have created a beta release 0.6.0. Can you please try it out and let me know if you're getting the data you need?

The units are alway W and Wh on the energy manager.
With the beta release I get the values vor the ev stations and the s0 counter, but it is not possible to differentiate between the devices, same names of the entities are counted up.

Is it possible to change the names to sensor.energymanager_devicename_... ?

I updated release 0.6.1 so that the device name is contained in the entity ID. Can you tell me what the entity ID of your S0 Counter shows? I would like to know how it handles Umlauts.

That looks great !
wärmepumpe is used as warmepumpe in the entity name. The Friendly Name has the Umlaut.

Just one thing for the EV ans S0 Counter, the units for the work entities are kWh but the value is in Wh.

The values for the work of the Photovoltaik are correctly shown in kWh.

Good to see that Home Assistant handles the Umlauts correctly.
I forgot the conversion. I updated the 0.6.1 version again. Can you please update again?

Values and units match now !
Great Job ! Thanks !


0.6.1 changelog - [merged]

Merges changelog -> master

In GitLab by @codecov on Nov 1, 2021, 14:41
Codecov Report

Merging #130 (52c7e50) into master (2242d16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   97.45%   97.45%
=======================================
  Files          16       16
  Lines         551      551
=======================================
  Hits          537      537
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2242d16...52c7e50. Read the comment docs.

approved this merge request

enabled an automatic merge when the pipeline for 52c7e50f8d90273b2a5a823f423fef385ae67ea8 succeeds

mentioned in commit fdfb68130d6b5cae3146290fbd9cd43303f9dd7e

mentioned in commit 8fa293238779f8aa4c88ff2ccd611905c9bb45e5

mentioned in commit fcf6903fe8b12726c52599f7880f0bf6563fe1c5

picked the changes into the branch cherry-pick-fdfb6813 with commit 8fa293238779f8aa4c88ff2ccd611905c9bb45e5


Find Alternative Solution for Ping Spawn

Spawning ping to trigger DELETE_ON_CLOSE on the binary is a bit odd and people have pointed out this hack a few times now. I think spawning any executable there is absurd and ideally there is a better way to accomplish this. Rustup spawns net but I think this is an even bigger hack because it hopes that the executable spawn and shutdown is just slow enough to outlast the call to exit.

It would appear that in times long gone, FILE_FLAG_DELETE_ON_CLOSE on the clone was indeed all that was necessary. This for instance is how dreamweaver used to uninstall itself: https://www.winehq.org/pipermail/wine-patches/2004-September/012758.html

Closing this as we're not using ping any more.


When we remove a nested property it always removes the first last one only.

If we have to remove the nested property field like below:

It always only removes the last one no mater which one we will delete:

On clicking the delete of Camera it deleted the last one Keyboard not the Camera.

which versions of admin-bro and @admin-bro/mongoose do you use?

"latest"

it doesn't give me any information - because the version depends on when you installed. Please write the output of:

npm ls admin-bro
npm ls @admin-bro/mongoose

<EMAIL_ADDRESS>and
<EMAIL_ADDRESS>

we are working on the update in 3.3 regarding the nested arrays.

Posting the "show" Referenced property bug here for the record:
If there is a nested property in a Resource:

It's reference JUST from show ( not from list ) gives this error in console:

My main User schema:
`const mongoose = require('mongoose')
const UserSchema = new mongoose.Schema({
adminName: {
type: String,
},
distributorName: {
type: String,
},
dealerName: {
type: String,
},
adminCreatedBy: {
type: mongoose.SchemaTypes.ObjectId,
ref: 'Admins',
},
distributorCreatedBy: {
type: mongoose.SchemaTypes.ObjectId,
ref: 'Admins',
},
dealerCreatedBy: {
type: mongoose.SchemaTypes.ObjectId,
ref: 'Distributors',
},
email: {
type: String,
required: true,
unique: true,
},
phoneNumber: {
type: Number,
validate : {
validator : Number.isInteger,
message   : '{VALUE} is not an integer value'
}
},
SPOC: {
type: String,
},
address: {
type: String,
// required: true,
},
bufferStock: {
type: Number,
},
website: {
type: String,
},
profilePhotoLocation: {
type: String,
},
productType: [{
type: mongoose.SchemaTypes.ObjectId,
ref: 'ProductType',
}],
isAdmin: {
type: Boolean,
default: false,
},
isDistributor: {
type: Boolean,
default: false,
},
isDealer: {
type: Boolean,
default: false,
},
createdOn: {
type: Date,
default: Date.now(),
},
// companySize: {
//   type: String,
//   enum: ['b', 's', 't'],
// },
encryptedPassword: {
type: String,
required: true,
},
// disabledAt: {
//   type: Date,
// },
// isAdmin: {
//   type: Boolean,
// },
// isBig: {
//   type: Boolean,
// },
// tags: [String],
})
const User = mongoose.model('User', UserSchema)
module.exports = { UserSchema, User }
`
Admin and Distributors are just renamed ( by ID ) resources of the same User Schema

With the Schema specified above, the items in the payload is a string, but when we refresh or paste the URL in new tab, the iteams variable in the payload is an array.


Can I pass a passphrase to the action ?

Can I pass a passphrase to the action ?

See #36 – I don't see why this would make sense?


Update dependencies

Failing check in the pipeline is caused by a new warning in the latest rustc version. #59 should fix it.


[QUESTION] geography not valid

Question
I believe I am doing something wrong, but when I use the Geography class to create WKB I get an invalid geography.
byte[] wkb = Geography.point(10, 20, 104001).serialize()
assert wkb[5] == 0x0c

This returns false, because that value is 0x08, meaning that the geometry is not valid, if I am not mistaken. But according to the CLR Types specification the valid bit should always be set for version 1.

I have a similar problem with a polygon:
String wkt = "POLYGON((142.448916 -51.037471,142.41632 -52.52176,144.406309 -52.52273,144.37449 -51.038436,142.448916 -51.037471))"
byte[] wkb = Geometry.STGeomFromText(wkt, srid).serialize();
assert wkb[5] == 0x04;

Also, in this case wkb is
41 96 01 00 01 00 05 00 00 00 d6 54 16 85 5d ce 61 40 32 c6 87 d9 cb 84 49 c0 77 15 52 7e 52 cd 61 40 34 2e 1c 8 c9 42 4a c0 41 62 bb 7b 0 d 62 40 ad 51 f d1 e8 42 4a c0 bb d5 73 d2 fb b 62 40 99 7e 89 78 eb 84 49 c0 d6 54 16 85 5d ce 61 40 32 c6 87 d9 cb 84 49 c0 01 00 00 00 02 00 00 00 00 01 00 00 00 ff ff ff ff 00 00 00 00 03

but I got the WKT from an existing geography in the DB, that has this representation:
41 96 01 00 01 04 05 00 00 00 32 c6 87 d9 cb 84 49 c0 d6 54 16 85 5d ce 61 40 34 2e 1c 08 c9 42 4a c0 77 15 52 7e 52 cd 61 40 ad 51 0f d1 e8 42 4a c0 41 62 bb 7b 00 0d 62 40 99 7e 89 78 eb 84 49 c0 bb d5 73 d2 fb 0b 62 40 32 c6 87 d9 cb 84 49 c0 d6 54 16 85 5d ce 61 40 01 00 00 00 02 00 00 00 00 01 00 00 00 ff ff ff ff 00 00 00 00 03

The length is in both cases 112, the difference is in the valid bit and in the data representation.

Hi @vforchi, thanks for contacting us. The driver doesn't set the valid bit when the spatial datatype object is created from the user's input, because the driver doesn't verify the validity of  the actual object (however, when we send the object to the server and we retrieve it, the server would've set the valid bit if it is valid). Basically we let the server decide if the object is actually valid or not.
As for the polygon, could you show me how you're inserting the data, and how you're retrieving/viewing it?

But the server is not setting the valid bit, should I do something special to enable it?
The original data was inserted with STGeomFromText, if I remember correctly. Now I am trying to insert the same data in another table from java using WKB.
A possible problem is that I am using a library that is supposed to work with many differed databases, so it does not use SQLServerPreparedStatement#setGeography, but setObject. I tried do pass the WKT string to setObject, but it complains that the data would be truncated.
I know this is a bit vague, let me know how I can provide more info. I have the feeling that the problem with the valid flag should be solved first.

The default value for the valid flag is being set to false right now, but it can easily be changed if users need it to be true by default. Could you let me know why the valid flag needs to be true? Also, if you could post your Java code, I could help you better with the polygon problem as well.

For the point I use this code:
byte[] wkb = Geography.point(lat, lon, 104001).serialize();
wkb[5] = (byte) 12;

And I write that into a PreparedStatement with setObject
If I do not set the valid flag, the geography goes in and I can query the table, but if I join with another table on a geography column, using for example STIntersects(), the query succeeds but when I try to retrieve the ResultSet I get the following error:
Caused by: com.microsoft.sqlserver.jdbc.SQLServerException: A .NET Framework error occurred during execution of user-defined routine or aggregate "geography":
System.ArgumentException: 24144: This operation cannot be completed because the instance is not valid. Use MakeValid to convert the instance to a valid instance. Note that MakeValid may cause the points of a geometry instance to shift slightly.
System.ArgumentException:
.
	at com.microsoft.sqlserver.jdbc.SQLServerException.makeFromDatabaseError(SQLServerException.java:256)
	at com.microsoft.sqlserver.jdbc.SQLServerResultSet$FetchBuffer.nextRow(SQLServerResultSet.java:5427)
	at com.microsoft.sqlserver.jdbc.SQLServerResultSet.fetchBufferNext(SQLServerResultSet.java:1758)
	at com.microsoft.sqlserver.jdbc.SQLServerResultSet.next(SQLServerResultSet.java:1016)

For the polygon, I use the code from my second post, and I get the following error when I try to insert the data:
Caused by: java.sql.BatchUpdateException: A .NET Framework error occurred during execution of user-defined routine or aggregate "geography":
System.FormatException: One of the identified items was in an invalid format.
System.FormatException:
.
	at com.microsoft.sqlserver.jdbc.SQLServerPreparedStatement.executeBatch(SQLServerPreparedStatement.java:2083)

Hi @vforchi, I agree that it would be best for the driver to set the valid bit to true (even if the driver isn't sure if it's valid), so that users can use these objects better. I'll be making a PR soon that addresses this issue, and let you test with it as well.

I've made a PR (https://github.com/Microsoft/mssql-jdbc/pull/1035) and attached the driver in the comments. Could you test the jar and let me know if anything else needs fixing?

Thanks, this fixed the problem with the points, but I still have the issue with the polygon.
When I try to insert this:
POLYGON((142.448916 -51.037471,142.41632 -52.52176,144.406309 -52.52273,144.37449 -51.038436,142.448916 -51.037471))

Which gets translated to
41 96 1 0 1 4 5 0 0 0 d6 54 16 85 5d ce 61 40 32 c6 87 d9 cb 84 49 c0 77 15 52 7e 52 cd 61 40 34 2e 1c 8 c9 42 4a c0 41 62 bb 7b 0 d 62 40 ad 51 f d1 e8 42 4a c0 bb d5 73 d2 fb b 62 40 99 7e 89 78 eb 84 49 c0 d6 54 16 85 5d ce 61 40 32 c6 87 d9 cb 84 49 c0 1 0 0 0 2 0 0 0 0 1 0 0 0 ff ff ff ff 0 0 0 0 3

I get the following error:
Caused by: java.sql.BatchUpdateException: A .NET Framework error occurred during execution of user-defined routine or aggregate "geography":
System.FormatException: One of the identified items was in an invalid format.
System.FormatException:

Hi @vforchi, thanks for confirming. From your above code, I see:
String wkt = "POLYGON((142.448916 -51.037471,142.41632 -52.52176,144.406309 -52.52273,144.37449 -51.038436,142.448916 -51.037471))"
byte[] wkb = Geometry.STGeomFromText(wkt, srid).serialize();

And I assume you're putting this into a Geography column? If that's the case, you should use Geography.STGeomFromText instead. I haven't done any complex operations with it, but I was able to insert this Geography data into a Geography column. Let me know if this solves your problem.

Thanks, that was it. I completely overlooked it.

Thanks for confirming. I'll keep this issue open for now, until PR #1035 is merged. I agree that it's better for the driver to send the valid bit set to true by default 👍

Fixed in PR #1035. Closing issue.


[HOTFIX] - Fixing ingress class on external and internal dual nginx

Hi team, following the issue #69 i did some changes on the arguments and the ingressClass.
This change makes the old annotation not working anymore and moves the support to ingressClass.
For more informations: https://kubernetes.github.io/ingress-nginx/user-guide/multiple-ingress/

lgtm!
The IngressClass is available since K8s 1.18, so this should be retro-compatible and it shouldn't be a breaking change.

Testing in a cluster with dual nginx, the annotation cannot work together with ingressClass in this use case:

ingressClass: internal
kubernetes.io/ingress.class: "internal"

If the controller is listening for the ingressClass internal is not able to listen to the annotation internal because the configuration flag is --ingress-class=k8s.io/internal. To make the annotation work, the flag must be --ingress-class=internal
You need to choose one way or the other, not both ( i did not test with kubernetes.io/ingress.class: "k8s.io/internal" tho


Add support/integration for SQL Nexus to analyze the logs collected by Logscout

We cannot analyze all the required parameter or logs collected by this tool using SQL Nexus. for an example, Polybase errors. Can you please add integration to SQLNexus or provide a tool for analyzing the Logscout output.

@sandykools the ingestion of data sets into SQLNexus is managed in that project and not here. Please look at filing items at https://github.com/microsoft/SqlNexus for specific scenarios and what data you are looking to consume.
I'd like to set expectations that we generally try to implement reports/collectors for the most impactful scenarios so depending on the scope of the work and expected impact, it may be better to build a local solution that looks at the specific logscout data you are looking to review.


field shape of null

big fan---first time opening an issue :wave:
Bluesky Documentation [1] claims that None is a valid argument for field shape, but your schema does not accept None [2]. This is easy to fix, but I need direction: is this a bug in docs or a bug in the schema?
[1] http://nsls-ii.github.io/bluesky/hardware.html#ReadableDevice.describe
[2] https://github.com/bluesky/event-model/blob/f33e54ac88ca7fa8588acd41a1f7e41b7610c269/event_model/schemas/event_descriptor.json#L23-L28

Hi @untzag! Thanks for catching this.
I seem to remember that in the very earliest days of the bluesky prototype (maybe predating schema validation?) we accepted None, and if you had asked me up to now I would have said that we still do—hence the erroneous docs.
Looking forward, seems to me we should correct the docs and let the schema remain strict about this. It saves all document consumers from needing to perform a None check before going on to deal with the shape as a tuple or list.


Consumer scheduling scaling KafkaChannel tests

Signed-off-by: aavarghese<EMAIL_ADDRESS>Part of #1537
Dependent on #1618's implementation

Proposed Changes

Adding new KafkaChannel reconciler tests

Release Note

Docs

/cc @pierDipi

/retest

ping @pierDipi :)

Rebased and updated as per review comment changes in Channel reconciler (#1618)

/test pull-knative-sandbox-eventing-kafka-broker-unit-tests

/test pull-knative-sandbox-eventing-kafka-broker-reconciler-tests

/test pull-knative-sandbox-eventing-kafka-broker-unit-tests

ping @pierDipi :)

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

/retest


Fix/works on windows too

This pr addresses issues causing Mookme to fail on Windows.
It mainly removes Linux only commands.
It will close https://github.com/Escape-Technologies/mookme/issues/83, https://github.com/Escape-Technologies/mookme/issues/84

Thanks ! I'll merge it asap and release on the beta channel

Thanks for your contribution ! It is published in the beta channel and can be retrieved using npm i --save-dev<EMAIL_ADDRESS>:)

I have tested this out but have run into a few more issues specifically with the beta 2 branch. It all works on Linux (I tested it by running it in WSL with Ubuntu). On Windows the hooks just don't run. This repo uses a beta 1 version in the root package.json so I didn't see these issues when I was implementing these changes. I created a new repo to test the 2.2.0-beta.3 version and npx mookme init works correctly and sets the file mode but when doing a commit with that version the hooks don't run. If I switch to a beta 1 version in the package.json file then try to commit the hooks will run. Although I am still having some issues with certain commands. I am running everything in Powershell Core which is cross-platform and aliases commands like cat. I am getting errors about npx not being found for my commit-msg hook even though I can do an npx --help from the same directory and all of the hooks in the .git directory also use npx.
I have also noticed that the prompts when running npx mookme init are missing with the beta 2 version. It doesn't set the packagesPath or packages array in the mookme.json file on Windows or Linux. I had to add them manually.
I think that something changed between beta 1 and beta 2 to cause this. I will continue looking into this but it may take a bit of time. I will file another issue when I have more info.

I have also noticed that the prompts when running npx mookme init are missing with the beta 2 version. It doesn't set the packagesPath or packages array in the mookme.json file on Windows or Linux. I had to add them manually.

That's because you don't need to set this in Mookme 2, I drastically simplified the setup. The tool automatically resolves folder with a .hooks/{hook-type}.json file in it !

 The npx run command is either failing silently or is not resolving the .hooks folders. I am continuing to investigate.

After some more investigation is seems that the issue with the execSync calls in the GitToolkit class. Calling execSync('echo $(git diff --cached --name-only)').toString() in getStagedFiles() literally returns '$(git', 'diff', '--cached', '--name-only)\r' on Windows. If I just execute echo $(git diff --cached --name-only) in Powershell I get a list of the filenames that are staged and if I call it with toString() I get an object returned.

Okay, so I have found the issue and I have it working on Linux and Windows. The issue exists in the GitToolkit class with all of the execSync calls that echo the git command output. I changed the getStagedFiles() method to
  getStagedFiles(): string[] {
    debug(`getStagedFiles called`);
    const stagedFiles = execSync('git diff --cached --name-only').toString().split('\n');
    debug(`Retrieved the following files staged: ${stagedFiles}`);
    return stagedFiles;
  }

This works on both Linux and WIndows. Previously on Windows the echo just echoed the actual command and not the output of the command. In looking through the code for this class some of the methods call the git commands in a cross-platform way and some don't. They all need to be changed to not echo the git command and to split the output on the \n character.
I am still having issues with the commit-msg hook on Windows. The command "cat {args} |<EMAIL_ADDRESS>is throws

'.' is not recognized as an internal or external command,
operable program or batch file.

stdout :

and the command "npx commitlint --edit" throws
Hook of package global failed at step commit lint

'"node"' is not recognized as an internal or external command,
operable program or batch file.

stdout :

I am still looking into this.
Also, another thing that needs to be addressed is that the tests only run on Linux. They need to be cross-platform in order to confirm the code works on Windows and Linux.

I figured out the issues with the commit-msg hooks. I updated commitlint to the latest version (v 17) and now everything works on Linux and Windows. Also, can't use "cat {args} |<EMAIL_ADDRESS>on Windows. It definitely won't work in cmd.exe because the cat command doesn't exist. On Powershell the cat command is mapped to a Powershell command but it doesn't like piping the output to the node_modules folder.  Have to use npx commitlint --edit to get the commit message to be linted.
I have to do a little more testing tomorrow and then I will create an issue and submit a pr. There is still a small issue with the git commands. When splitting the string to an array the last entry is an empty string and if I filter it out in some cases it stops working again. This isn't a major issue but it annoys me.


[incubator-kie-issues-1131] test migration from V7 to code generation-23

Issue's with testEventBasedSplit3 and testEventBaedSplit5 tests within IntermediateEventTest.java
The test can be identified by referring to IntermediateEventTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/IntermediateEventTest.java
Closes https://github.com/apache/incubator-kie-issues/issues/1131.
Issue 1:
testEventBasedSplit3
Error: java.lang.NullPointerException: Cannot invoke "org.drools.core.common.InternalAgenda.isRuleActiveInRuleFlowGroup(String, String, String)" because the return value of "org.drools.core.common.InternalKnowledgeRuntime.getAgenda()" is null
at org.jbpm.bpmn2.IntermediateEventTest.testEventBasedSplit3(IntermediateEventTest.java:479)
org.opentest4j.AssertionFailedError:
expected: 1
but was: 5
In the v7, we use:
kruntime.getKieSession().insert(jack);
But there appears to be an issue because the jack variable  doesn't exist in our data model. Could you please guide on how we should handle this.
Issue 2:
testEventBasedSplit5
The receive task handler needs a kruntime object. Need guidance on how to create this handler in v9 as we don't have the kruntime object.
 ReceiveTaskHandler receiveTaskHandler = new ReceiveTaskHandler(null);         ProcessTestHelper.registerHandler(app, "Receive Task", receiveTaskHandler);

we are not supporting this sort of scenario with drools. set this as standby. I need to fix this in the engine

Okay


WIP: envcorr for free ori source spaces

Related to #6109 (cc @jhouck), this shows one way to use envelope correlations with a free-ori source space using lcmv beamforming. FWIW you can do the same thing with a surface source space if you want. In that case you get to use labels, which is nice. We don't currently have a good way of label-combining our volumetric source spaces, which is unfortunate.
I am working on a correlation measure that is rotation + scale invariant to deal with correlating two arrays, each of shape (3, n_times) so that you could in prinicple use VectorSourceEstimates, but so far it does not give as nice parietal network results when I actually use it in envelope_correlation.
While working on this I found a few more things that should be done:

[x] Add parallelization to envelope_correlation
[x] Figure out why parallelization of envelope_correlation does not speed anything up (profile): the overhead of sharing data (serialization) is roughly the same as the computation time; computations are not nogil so we can't use prefer='threads' in joblib.Parallel to get around this
[x] Add apply_hilbert for epochs and evoked
[x] Test n_jobs in apply_hilbert benefits from prefer arg?: no faster
[ ] Add tests for apply_hilbert for epochs and evoked
[ ] Unify apply_hilbert for raw, epochs, and evoked
[ ] Add tests for mean + VectorSourceEstimate for extract_label_time_course
[ ] Allow mean_flip for VectorSourceEstimate in extract_label_time_course
[ ] Add tests to extract_label_time_course that a VolSourceEstimate is not provided
[ ] Test on longer segments of time

In the meantime @jhouck feel free to try this approach with your data.
Sometime we should also unify resample and filter (maybe) for raw/epochs/evoked. But that's for another PR.

Thanks @larsoner!  Would it be OK to modify this a bit to use empty room data for the noise cov?  i.e.
noise_fname = op.join(data_path, 'MEG', 'bst_resting','subj002_noise_20111104_02.ds')
raw = mne.io.read_raw_ctf(raw_fname, clean_names=True, verbose='error')
empty = mne.io.read_raw_ctf(noise_fname, clean_names=True, verbose='error')
empty.crop(0, 60).load_data().pick_types(meg=True, eeg=False).resample(80)
empty.apply_gradient_compensation(3)
#cov_subj = mne.compute_raw_covariance(raw)
empty.filter(14, 30, n_jobs='cuda')
cov = mne.compute_raw_covariance(empty)

I'd meant to see about this for the surface version but hadn't gotten there yet.

This pull request introduces 1 alert when merging 249d0c4db0fe6e3c0c51b5a77b2595dacdc27046 into 0bb4e479e385fd9c67b469f8ea0ae00bb3c54bd9 - view on LGTM.com
new alerts:

1 for Variable defined multiple times

Comment posted by LGTM.com

https://12065-1301584-gh.circle-artifacts.com/0/dev/auto_examples/connectivity/plot_mne_inverse_envelope_correlation_volume.html#compute-the-degree-and-plot-it

Would it be OK to modify this a bit to use empty room data for the noise cov?

We didn't do this for a reason. It was either to reduce memory footprint so that CircleCI (and feeble laptops) could handle it, or it was because it made the output look worse. I'll wait to hear from you which it was :)

This pull request introduces 1 alert when merging 9b305720be66430300fbaedfa047b1f7efbf301a into 0bb4e479e385fd9c67b469f8ea0ae00bb3c54bd9 - view on LGTM.com
new alerts:

1 for Variable defined multiple times

Comment posted by LGTM.com

On my 8-year-old linux box they all ran fine, so it must have been the results.  I did not look at the labels so don't know whether there should be any pattern visible in the correlation matrix, but using either empty room or an ad hoc noise cov  produces a nifty plaid.

The reproducible source space pattern is shown in: https://github.com/mne-tools/mne-python/pull/5389#issuecomment-409987932
Our example is a bit less clean because we crop a lot to save memory and computation time, but if you crop less agressively it should pop out more. Then you can try the empty room cov to see if it still looks good.

On my 8-year-old linux box they all ran fine,

Even an 8-year-old box probably has more memory than CircleCI, which is 4GB

This pull request introduces 1 alert when merging 95a82f273d0a41c3615645b2a08f618ac08fb645 into 9b5ae5104ecdeaea13a88273c712382bf131162c - view on LGTM.com
new alerts:

1 for Variable defined multiple times

Comment posted by LGTM.com

This pull request introduces 1 alert when merging eb49c13fbbfe6fc2a69ed647e40aca524cdd9b7c into 56909cdbf35511d9837a5999ce1ffe2f47eee7bb - view on LGTM.com
new alerts:

1 for Variable defined multiple times

Comment posted by LGTM.com

This pull request introduces 1 alert when merging 906451bd0dfcc8531f4be4e518826447112a5cb1 into 32e1452b324f3542e7efcef9023b2222774f0785 - view on LGTM.com
new alerts:

1 for Variable defined multiple times

Comment posted by LGTM.com

Ready for review/merge from my end. Updated examples:

Surface + MNE, not really changed
Volume + LCMV, new

maybe @dengemann can do the first review?

Ready for review/merge from my end. Updated examples:

Surface + MNE, not really changed
Volume + LCMV, new

I tried to execute the example: Volume + LCMV
I landed up with an error:
AttributeError: 'Epochs' object has no attribute 'apply_hilbert'
If i skip this line and compute the stcs by
stcs = apply_lcmv_epochs(epochs, filters, return_generator=True)
then compute  envelope correlation by
corr = envelope_correlation(stcs, verbose=True)
i landed up with an error:
AttributeError: 'VolSourceEstimate' object has no attribute 'ndim'
May i know why am i encountering this problem?
P.S: i am using exact copy of the example and using MNE v0.18dev0

You need to be on the branch from this PR

i am using the latest version of mne, isn't it enough?
(pip install -U https://api.github.com/repos/mne-tools/mne-python/zipball/master)

No, not until this PR is merged

@poojaprabhu9 you need to do an editable install and fetch this PR. If you're up for the challenge, I recommend you read the contributing guide and the section on fetching a PR

Looks clean to me! Please don’t wait unnecessarily. We will catch bugs as we start using it ;-)

@larsoner please update what's new and good to go from my end. You should mention that Hilbert can now be computed on Epochs... thx !


feat: add some info about connected wifi

Adds some stats similar to waybar on wifi

Totally opt in

There are scenarios where the AGS network service returns:

Name as an empty string ""
Strength as -1 indicating the lack of a valid strength (think null)
Frequency as -1 indicating the lack of a valid frequency

We should handle all these scenarios where if these values are captured, we display -- instead. So if no wifi is connected:
Network: None
Signal Strength: --
Frequency: --

Or something similar. Essentially we should handle invalid values.

We still need to handle the above scenarios. In case that you're not connected to a Wifi, it will show a negative value for the signal and frequency. We can instead format it like this when invalid values are present:
Network: None
Signal Strength: --
Frequency: --

sure thing , will update that asap

@Jas-SinghFSU added fallback

Awesome stuff :heart:


React Hooks Support

Really Surprised that this package doesn't have anything that starts with use.
Are you gonna add that anytime soon?
Thanks for the package though

I considered it in the past, but there were some architectural challenges with it. I will take another look at it over the weekend and let you know :)

Really looking forward to it.


sensu_check_dict to support ucarp primary only

with ucarp_node_only=True, the check will be executed only on ucarp primary node.
default is False, so existing sensu_check_dict function will not be affected.

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

ok to test

ok to test

add to whitelist

ok to test

add to whitelist

ok to test

ok to test

ok to test


[INTEGRATION][airflow] refactor extractors contract

Refactor extractor contract.
StepMetadata, renamed to TaskMetadata dropped unused fields.
Moved to provide concrete job/run facets in extractors, instead of substitutes.
Removed possibility to return list of TaskMetadata from extractors.
https://github.com/OpenLineage/OpenLineage/issues/289
Signed-off-by: Maciej Obuchowski<EMAIL_ADDRESS>

That makes sense. The one downside is that this is not backward compatible and will break any custom extractor that users might have written.

The one downside is that this is not backward compatible and will break any custom extractor that users might have written.

We already discarded any output beyond first element for all extractors that returned list of elements. This PR changes silently dropping data to an error.

@wslulciuc a lot of PR getting merged today :wink:


Cannot paste in connection string to nostr wallet connect field.

This issue exists both at Nostrudel as well as on the bitcoin-connect page. So it must be a bitcoin connect issue.

Hi @mattius459
Sorry about the issue you experienced!
The modal overlay didn't have a specific z-index set and it seems it's treated differently in some browser versions (it started happening on Chrome for me). The fix has already released but Zappy Bird and Nostrudel were not updated.
I've updated Zappy Bird and made a PR for Nostrudel here.

Please let me know if you need any help integrating Bitcoin Connect. I am a big fan of https://payper-q-chatbot.vercel.app/ !

Hi Roland, I see that you can now paste in a string, but it still doesn't work when I try to get Mutiny to work on Zappybird on the Bitcoin Connect page. It just says "loading" and then when I try to start the game it gives me error telling me to connect a wallet. Unsure if this is Mutiny problem or Bitcoin Connect problem.

@mattius459 unfortunately Mutiny does not support all the Nostr Wallet Connect extension methods yet (such as get_info) so it's not functional here.

So you are saying that Mutiny doesn't support budgeted streaming payments currently?
I just need for Mutiny to be able to do auto-authorized (budgeted) payments to my chatGPT bot just like it does with Alby currently. @reneaaron said Mutiny should be able to do that currently and it seems like they should because on their side there is clearly some budgeting configurations they allow right now.
https://payper-q-chatbot.vercel.app/

@mattius459 someone on our team made a similar app you can try: https://chatbot-ui-bitcoin-connect.vercel.app/
I connected it to Mutiny running on my phone and made payments from my PC. With Mutiny, the payments are a bit slow (about 20-30 seconds for me).

Yes, you can! The payment dialog is optional.
On Fri, 12 Jan 2024 at 11:39 PM, mattius459 @.***>
wrote:

Hi, thanks Roland. Yes I'm able to make payments from Mutiny but I keep
getting the payment prompt for each query. I wish to avoid this and have
the queries be seamless. Is this on the Bitcoin-Connect side and can I turn
it off so that way the payments run silently?
FYI the payments take about 5 seconds from my Mutiny from my web browser.
Screen.Shot.2024-01-12.at.11.35.40.AM.png (view on web)
https://github.com/getAlby/bitcoin-connect/assets/39392504/09902fc1-70be-4b7c-afa5-c51ff527f81c
—
Reply to this email directly, view it on GitHub
https://github.com/getAlby/bitcoin-connect/issues/190#issuecomment-1889620123,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIDLD3YEEWHT4E7YCWQFQVTYOFRLDAVCNFSM6AAAAABBXKU7RCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBZGYZDAMJSGM
.
You are receiving this because you were assigned.Message ID:
@.***>

I will close this issue for now. Thanks again for raising it @mattius459 and let me know if you need any help. I'd love to use your app on my phone as a PWA which Bitcoin Connect should make it possible.

Hey Roland, one more thing. Can I get the github link to this?
https://chatbot-ui-bitcoin-connect.vercel.app/

@mattius459 here you go https://github.com/Alan-AC7/chatbot-ui-bitcoin-connect.git

Thank you Alan!


Improve rendering

@michael as u suggested I started adding to CHANGELOG.md
Let's make this best-practice, finishing a PR with an CHANGELOG update


REMOVE ALL DOCKER_ references from man page and default config

This is part of the effort to convert docker-storage-setup to
container-storage-setup
First we want to remove all references to DOCKER in environment variables.

I think I have all of your comments.

Moved this back into the original patch set.
https://github.com/projectatomic/docker-storage-setup/pull/180


There're two different colors when using terminal with customize terminal background color

Issue Type: Bug

put these settings on settings.json

"terminal.background": "#300a24",

From VSCode 1.57+, I noticed that there're two different colors on terminal with I customize terminal's background color:

Before VSCode 1.57, the terminal rendered nice.
VS Code version: Code 1.58.0 (2d23c42a936db1c7b3b06f918cde29561cc47cd6, 2021-07-08T06:54:17.694Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No
Remote OS version: Linux x64 4.15.0-143-generic
Remote OS version: Linux x64 4.15.0-143-generic
Remote OS version: Linux x64 4.15.0-143-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.57GB free)

Process Argv
--crash-reporter-id 88a9357c-8b8e-416b-85a3-40dbafa24bb6

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: dev

OS
Linux x64 4.15.0-143-generic

CPUs
Intel Core Processor (Skylake, IBRS) (2 x 2099)

Memory (System)
3.85GB (0.30GB free)

VM
0%

Item
Value

Remote
SSH: dev

OS
Linux x64 4.15.0-143-generic

CPUs
Intel Core Processor (Skylake, IBRS) (2 x 2099)

Memory (System)
3.85GB (0.30GB free)

VM
0%

Item
Value

Remote
SSH: dev

OS
Linux x64 4.15.0-143-generic

CPUs
Intel Core Processor (Skylake, IBRS) (2 x 2099)

Memory (System)
3.85GB (0.30GB free)

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

remote-ssh
ms-
0.65.7

remote-ssh-edit
ms-
0.65.7

gitlens
eam
11.6.0

python
ms-
2021.6.944021595

vscode-pylance
ms-
2021.7.3

jupyter
ms-
2021.8.1013163132

I believe this issue isn't same as #123362.

/duplicate #123362.


Merge changes from @fmateoc

Commits

[ ] fix an initialization issue with the scheduled thread executor - it was final and it could not be replaced after a shutdown (https://github.com/fmateoc/graalsqueak/commit/9e5e73568e313caf9cc3aa365d690ca10a2a7912)
[x] the context object info was looking at the method for its stack slots, instead of at the code object corresponding to the frame (potentially a block object) (https://github.com/fmateoc/graalsqueak/commit/945e645493d933daef04ce54237592aa6332eaa2)
[ ] fix some traversal issues (only look at the active stack, not at the potential garbage behind the stack pointer) (https://github.com/fmateoc/graalsqueak/commit/da9f36f4abaedf01883bde4e47c98cd68203005a)
[ ] add some more useful default breakpoints (https://github.com/fmateoc/graalsqueak/commit/9b883d97b57744f1c5ece679c0d0dbd5988be886)
[ ] tighten up the stack discipline by moving the NilObject.nullToNil earlier, only where it is needed, and adding an assert (https://github.com/fmateoc/graalsqueak/commit/8e424142fec40da7367cf351f14f2c8421ae537e)
[ ] fix some initial stack pointer and context-process association issues Also fix the pc change bug (https://github.com/fmateoc/graalsqueak/commit/5b34f7f53ff746736be5d38b55a7362fc521e399)
[x] fix nasty block closure bug, where a public constructor taking a supposedly hash second argument was invoked with a second argument meaning the number of copied values (https://github.com/fmateoc/graalsqueak/commit/f146b6bf0dccd3a86702cbaba3aa76ce3e4f95bd)
[ ] optimize stack slot creation when the value is known (only one user for now, as the other users are combined with other fixes) (https://github.com/fmateoc/graalsqueak/commit/777a204ee8810e63ed65d250a569a50dd283ac35)
[x] Use explicit UTF-8 decoding from Squeak, since the native format is known and fixed, it should not be Java-settings dependent also make a nice readable string in toString, including surrounding it with simple quotes, otherwise the string "true" reads the same as the boolean true, and the number 3 reads the same as the string "3" Also fix a bug in testSourceAllBytecodes (https://github.com/fmateoc/graalsqueak/commit/b8d9fd0aa4bb2200a3416f875a434b26857d58e3)
[x] MiscUtils.getVMPath() returns a file name, not a folder name, which is wrong for primitive 142 (https://github.com/fmateoc/graalsqueak/commit/2b05051af9dba77ffbab41e8f07cd2dd15b55283)
[ ] optimize access to well-known objects by adding some specialized read nodes to the image context - this also enables some simplifications. also further logging improvements (https://github.com/fmateoc/graalsqueak/commit/f81618c6f7cfcf6148c9fda6a068526b5c8f0b75)
[ ] minor logging improvements (https://github.com/fmateoc/graalsqueak/commit/dc072971b40b70003f2bd0b2b41249689df0c2b8)
[ ] add low-overhead logging infrastructure (https://github.com/fmateoc/graalsqueak/commit/6a6930a90cdfb01e465678411edb6941edb1f956)
[ ] fix a bug in the breakpoint support code (https://github.com/fmateoc/graalsqueak/commit/6b4e53355d05afada903589a16c0e608f4c7c39f)
[x] fix an incorrect name (https://github.com/fmateoc/graalsqueak/commit/9ecd504fe7eb8fb3f96429b49aaea22ffa8fd281)
[ ] unify stack iteration (https://github.com/fmateoc/graalsqueak/commit/6c53e46da52aa677c5c19fb8cbb8719787c1f9a4)
[ ] make test list closer to squeak (https://github.com/fmateoc/graalsqueak/commit/4e2d8c4e334a50d9ec262a38f7e9130742e4521a)
[x] fixes for the initial value of the stack pointer (https://github.com/fmateoc/graalsqueak/commit/44e9ce377a503c3af29e61305090a0fe816e81ad)
[ ] further tweaks to the Delay cleanup code (https://github.com/fmateoc/graalsqueak/commit/2ee777f2b30acc736281459e0be59e0d7583371f)
[ ] minor logging cleanups (https://github.com/fmateoc/graalsqueak/commit/6ff8e4be629762a066efccac7cd2e770ba6b8093)
[ ] some more default breakpoints for unhandled errors (https://github.com/fmateoc/graalsqueak/commit/feff1769dce1a93e20f6ff134c88b9d87c18b8d5)
[ ] further fixes to tests with image (https://github.com/fmateoc/graalsqueak/commit/c11728bc6dd19f3cecd156e5b6c4498122d3f91f)
[ ] tracing execution (https://github.com/fmateoc/graalsqueak/commit/227cde7997caeac750ce996fb6a27413d573070a)
[ ] refactored and improved the breakpoints support (https://github.com/fmateoc/graalsqueak/commit/0ec1dfc0d82f064b952fd74b9dc699ac16c0c171)
[x] aboutToReturnSelector is filledIn too late, initialize the ByteSymbol class early instead (https://github.com/fmateoc/graalsqueak/commit/867f82e708d2697db641e4fc9841456928943024)
[ ] finally the cleanup/reload between tests works properly (https://github.com/fmateoc/graalsqueak/commit/76b3e7db32fc15d8795f98cf5828ba41e5eaff9f)
[ ] fix an annoying compilation failure in the abstract superclass, and fix the message interceptor for selectors with arguments (https://github.com/fmateoc/graalsqueak/commit/42013c383f3cf7a8962bda85c8c07be58c7eeb1a)
[ ] minor cleanups (https://github.com/fmateoc/graalsqueak/commit/578ecc37192054802f8432edbb15b95723146438)
[ ] fix a couple of faulty bytecode tests (https://github.com/fmateoc/graalsqueak/commit/6ac1a212dac58928eb53538261cabe864417aa6f)
[ ] make selector a field in lookup nodes when known in advance add support for a poor man's squeak breakpoint (https://github.com/fmateoc/graalsqueak/commit/5dee79cf7ecd9aa2789fe2bc5ba21ab8ceae0179)
[ ] optimize pushing literal nodes (https://github.com/fmateoc/graalsqueak/commit/00fd6b8a109854a3a9e635634a94b5585e87d4b8)
[ ] move misplaced comments (https://github.com/fmateoc/graalsqueak/commit/7fa8cd858708e297e98e761546b59e971f35beef)
[ ] normalize and improve toString methods and logging of objects (https://github.com/fmateoc/graalsqueak/commit/7b5d7d02d5ddd3e6c9da73bcff8fdb80b61e95f8)
[ ] clean up after test execution (https://github.com/fmateoc/graalsqueak/commit/2be3d3c0076fe7bbef4173027b9cc1a900a4e711)
[ ] Primitive or nil slots optimization (https://github.com/fmateoc/graalsqueak/commit/80c7e9f122d3c86ad7b261177d8ccb4ca46d1152)
[ ] bug-specific logging removed (https://github.com/fmateoc/graalsqueak/commit/56aed84def0bd2125cad9b737b415436dd22a5d6)
[ ] bug-specific logging commented out (https://github.com/fmateoc/graalsqueak/commit/c466444303d49c9b8c28c303e4630e484a577756)
[x] tighter UnsafeUtils (https://github.com/fmateoc/graalsqueak/commit/7f3c778573237ef1e8998f85b3df62271c903ef4)
[ ] third fix for nil retrieved as long - the real deal (https://github.com/fmateoc/graalsqueak/commit/e11ba8eea8e11beeada95a6121a9b5818b52f445)
[ ] more specialized logging (https://github.com/fmateoc/graalsqueak/commit/6e86ef4ca81166084833850e0693a69ee8af6a6b)
[ ] minor cleanup (https://github.com/fmateoc/graalsqueak/commit/8c3fc659dd5fcaebf36b4c582989c2f4a912603d)
[ ] minor cleanup 1 (https://github.com/fmateoc/graalsqueak/commit/66fbe542ed3933c21dd5b9377576c619d7b6bab9)
[ ] reproducer (https://github.com/fmateoc/graalsqueak/commit/46bc78128450e05c89b2de6afeb46616ced99b75)
[ ] add mechanism to enable logging during testing (https://github.com/fmateoc/graalsqueak/commit/46992ab9aeec4f84f1977e7767c699ed7a03e9a2)
[ ] tests marked as failing are actually passing (https://github.com/fmateoc/graalsqueak/commit/3b1351e48856aaddeb30893b01778cdd2c2259b8)
[x] avoid exceptions for unavailable source (https://github.com/fmateoc/graalsqueak/commit/69e8f7c1e2ac7857048596b8d68f25eb3748fa37)

/cc @fmateoc

I've done a full pass over all commits and cherry-picked the ones that were easy to integrate (see merge branch). Some of these commits, I've cherry-picked onto separate branches, so I can run the benchmarks on them. The rest is too big to be reviewed/integrated now. I will have another look later this week.

Closed in favor of #96.


LightUpdateQueue in ClientLevel is a memory leak

Due to the LevelRenderer never beeing called the LightUpdateQueue is never cleared!

Closed in https://github.com/3arthqu4ke/hmc-optimizations/commit/c1d2d9c99189d32bac2006aacfb1e8fa9262ad7c


PdCombobox console.error

We are getting a lot of console.errors from pd-combobox on load

I think there needs to be some checking if that this.state.items is not undefined

We moved the initialization of the PdCombobox store into the constructor to prevent errors when new items are passed while the component is rendering. Please try it out and let me know if the issue is still there.


{INSIDERSASTOKEN}

I am getting Please update your artifact setting and remove {INSIDERSASTOKEN} from the setting. This is no longer needed.
In Next Minor Test
However I don't have this in our setting
this is for PTE
Any advice please.

Thank you for highlighting that I removed the {INSIDERSASTOKEN}
appreciate your advise


Add store_json property to keep json response from Reddit

Fixes #830
Add store_json property to keep json response from Reddit
This adds a new configuration option, store_json to store the Reddit response on a class after it's downloaded, accessible by the .json_dict property.  It's disabled by default, because of aforementioned memory and serialization problems (see #830).

I'd definitely consider it, though I'd ask for some input as to how you think that would work.
For something like comment walking, if I get a submission, and walk through the comments:
submission.comments.replace_more(limit=0)
for comment in submission.comments.list():
   // save comment (or whatever)

I think you're suggesting the Reddit instance to store the most recent http response, but in this case what would that be?  reddit.submission() gets the submission and some comments, so I could store that, but then replace_more makes at least one more request (I think probably multiple?), so how would I access those?  Are you suggesting to store the most recent, or something more like a dictionary keyed by id?
Also I do not claim to know this codebase well at all, lol, I didn't spend much time poking around, so if I'm missing something fundamental here let me know.

You bring up a good point. If you're interested in the raw json for an individual comment things are definitely more complicated.
In your approach some comments will have replies, and some will not, depending on how they were accessed. How are you handling that?

Uhhhhh, I thought it was handling it, but now I'm questioning it.   The RedditBase constructor takes _data and store it in an instance variable, _json_dict if the config is turned on.  In the case of a _fetch, the code there already copies over self.__dict__, so that should work as well.
My assumption was that replies or a CommentForest called the Comment constructor for each, which should just work, but if they're doing something different I can look / create a test for that.  The two tests I created were for Submission, I haven't yet tried out comments (I assumed it would work the same).

I'm going to close this PR since it doesn't quite fit what I'd like to see in PRAW. However, please feel free to add this feature to https://github.com/praw-dev/prawdditions.


Critical capabilities changes were detected without any change made to the project

git clone https://github.com/dotnet/docfx.git
open the All.sln
error: The project system has encountered an error.

Internal error: Critical capabilities changes were detected without any change made to the project 'Microsoft.DocAsCode.Metadata.ManagedReference.FSharp.Tests.fsproj', and forces the project to be reloaded.  Potential capabilities involved: 'FSharp'.
I meet this error after upgrading to vs 15.7.3. I found several issues with similar error message that have been fixed in 15.3, but I think it's not the same issue for me.
Details:

LimitedFunctionality
System.AggregateException: One or more errors occurred. ---> System.InvalidOperationException: Internal error: Critical capabilities changes were detected without any change made to the project 'Microsoft.DocAsCode.Metadata.ManagedReference.FSharp.fsproj', and forces the project to be reloaded.  Potential capabilities involved: 'FSharp'.
   at Microsoft.VisualStudio.ProjectSystem.ProjectCapabilitiesRequirementsService.<RequestReloadForIncompatibleCapabilitiesAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.VisualStudio.ProjectSystem.CommonProjectSystemTools.Rethrow(Exception ex)
   at Microsoft.VisualStudio.ProjectSystem.ProjectErrorReporting.<>c__DisplayClass6_0.<SubmitErrorReport>b__0()
   at Microsoft.VisualStudio.ProjectSystem.ExceptionFilter.<>c__DisplayClass2_0.<Guard>b__0()
   at GuardMethodClass.GuardMethod(Func`1 , Func`2 , Func`2 )
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.InvalidOperationException: Internal error: Critical capabilities changes were detected without any change made to the project 'Microsoft.DocAsCode.Metadata.ManagedReference.FSharp.fsproj', and forces the project to be reloaded.  Potential capabilities involved: 'FSharp'.
   at Microsoft.VisualStudio.ProjectSystem.ProjectCapabilitiesRequirementsService.<RequestReloadForIncompatibleCapabilitiesAsync>d__20.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.VisualStudio.ProjectSystem.CommonProjectSystemTools.Rethrow(Exception ex)
   at Microsoft.VisualStudio.ProjectSystem.ProjectErrorReporting.<>c__DisplayClass6_0.<SubmitErrorReport>b__0()
   at Microsoft.VisualStudio.ProjectSystem.ExceptionFilter.<>c__DisplayClass2_0.<Guard>b__0()
   at GuardMethodClass.GuardMethod(Func`1 , Func`2 , Func`2 )
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.VisualStudio.Telemetry.WindowsErrorReporting.WatsonReport.GetClrWatsonExceptionInfo(Exception exceptionObject)<---

This issue has been moved from https://developercommunity.visualstudio.com/content/problem/267201/critical-capabilities-changes-were-detected-withou-1.html
VSTS ticketId: 626735
These are the original issue comments:
(no comments)
These are the original issue solutions:
(no solutions)

This might need to go under dotnet/project-system

@TIHan FYI

This issue was moved to dotnet/project-system#3673

Thanks @davkean


fix(resource-mgt): Fixing a few cases for resource limits and hibernation

Issue #, if available:
Description of changes:

Change error message for pause/resume requests for non generic components.
Reconfigure system resource limits on startup/run script execution in case limits got cleaned up during last shutdown
Add another case in resource limit update test
Include a fix from mainline in handling names for pooled threads

Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Checklist:

[ ] Updated the README if applicable
[ ] Updated or added new unit tests
[ ] Updated or added new integration tests
[ ] Updated or added new end-to-end tests
[ ] If your code makes a remote network call, it was tested with a proxy
[ ] You confirm that the change is backwards compatible

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Your changes need to go into main right? This is merging directly to release

Your changes need to go into main right? This is merging directly to release

Yeah need to merge this asap, will add the new commit to main in separate PR


📄 Documentation - add wiki page with steps to create/edit content for designers

Documentation can be found here: https://github.com/SSWConsulting/SSW.Website-v3/wiki/Creating---Editing-Content


Nic/docs spelling styling

Typo and grammatical fixes
Some improvements to writing style (ex. remove passive voice, simplify sentences, etc)

Generated with Floe

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you @NicHaley, just read all the changes and they are great!


Glow border is missing the corners

It's a little bit subtle, but you can see in this screenshot that there's no glow border at the corner (and the same is true for the other 3 corners). Is that as-designed, or a bug? It looks pretty odd, and isn't what the "standard" Windows glow looks like.

@tgjones it's now as-designed, maybe changed in 2.x.x

@punker76 Okay, thanks. I'm guessing there were good technical reasons for the change (in 1.0.0 it used the standard Windows glow / shadow, right?) Looking through the issues list here, I notice a number related to this area, but I couldn't find one detailing why the change was made.


Update hibinit-agent

Confirm /dev/snapshot exists before updating the swap resume parameters again
Description of changes:
Needed for Ubuntu ARM Hibernation, where the /dev/snapshot does not exist. The agent already manually updates the resume parameters in line 190 by updating the GRUB file.
Tested on Ubuntu x86, where /dev/snapshot exists, and confirmed there is no behavior change. Tested on Ubuntu ARM, where /dev/snapshot does not exist, and the agent runs successfully and allows for successful hibernation.
Batch tested on with the agent change Ubuntu Jammy using internal Amazon tools (with %50 of memory allocated) and achieved a >99% success rate on hibernate/resumes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Have a better commit message

Please add some testing details. I think its is worthwhile to test with memwaster at a higher percent.

+1 to a more descriptive commit message, otherwise LGTM


Support for certificate partial wildcard in middle of identifier

RFC6125 give some example of wildcard in section 6.4.3 (https://tools.ietf.org/html/rfc6125#section-6.4.3):

baz*.example.net should match baz1.example.net
*baz.example.net should match foobaz.example.net
b*z.example.net should match buzz.example.net

Using OpenSSL X509_check_host(), the first two are OK but the last does not work.
By looking into the code, It seems to be explicitly disabled as per a comment in valid_start in v3_utl.c

/* No 'foo*bar' wildcards */

Should it be corrected? Or is there a reason it is not supported?

It's really dangerous -- did you see the errata for that RFC? -- and nobody does it.  We have no plans to support this.

I only see one errata (#3090) and it seems to find problem with wildcards in generals and have nothing specific about the bz.example.net case. Also, I have problem seeing how bz.example.net would be worse than b*.example.net.
Also, whatever the reason, I think it would be good to at least modify the comment to indicate why foo*bar are not valid.

Do you have a suggestion for wording that would be more helpful?

As I don't see how the errata indicating why b*z.example.net is more problematic than a simple wildcard, I do not have any idea. Is there another errata that I'm not seeing?

Wildcards are risky as the errata shows.  However they are widely used, with "*.foo.bar" as the only form that is in public use, so supporting that is reasonable.  Embedded wildcards are more risky and there is no demand for them.

I agree that wildcards carry some risk, but partial wildcard seems to me less risky than the others. For example, *.foo.bar match many string more than b*z.foo.bar
Also, I find strange that b*.foo.bar and *z.foo.bar are supported but not b*z.foo.bar
Finally, there is a flag in OpenSSL to disable partial wildcard that can be used to only accept *.foo.bar

Not sure what else I can say.  We disagree.

@richsalz Failing to give any explanation at all is a lot different from giving some explanation, however tenuous.

Agreed, that "explanation" was pretty useless. A careful reading of the only Errata and section 7.2 (plus linked presentations) shows that any issue with 3 above works on case 1 and 2. Sounds like just fear/paranoia + it not being that important compared to other development that's keeping it unimplemented. I agree that use-cases for it are few

https://www.rfc-editor.org/errata_search.php?rfc=6125 writes

However, the client SHOULD NOT
attempt to match a presented identifier where the wildcard
character is embedded within an A-label or U-label [IDNA-DEFS] of
an internationalized domain name [IDNA-PROTO].

That is indeed an additional complication of matching b*z.example.com over *.example.com


[docs] Dedicated docs on how to skip building an image on pipeline run

Describe changes
I added documentation detailing how to skip building an image every time a pipeline is run.
It includes:

how to do it
what the image should contain and how to build it
where users can use this feature

Pre-requisites
Please ensure you have done the following:

[ ] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
[ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Good catch @htahir1, i updated the toc and added other changes. open to chatting whenever you have time

@wjayesh what about my suggestion to split into more pages ?

@htahir1 i agree with it and will be adding it before i request your review again


Unable to send file as an attachment in skype

SDK Platform

.NET
URL of Code Sample

Problem Description

Im unable to send file as an attachment in skype from bot to user.
Im specifying the contenturl of the file,it is working fine in emulator but not in skype.
private static Attachment GetInternetAttachment()
{
return new Attachment
{
Name = "SampleDOCFile_100kb.doc",
ContentType = "application/msword",
ContentUrl = "https://drive.google.com/uc?id=0B129OIZ80bZfSVdoLVN2clByNXc&export=download",
};
}

Hi @niharikabhavaraju
I am new to the Bot Framework but it looks like there is some sample information available to you at https://docs.microsoft.com/en-us/bot-framework/dotnet/bot-builder-dotnet-add-media-attachments
Specifically, the definition of the content is different than your code above.
replyMessage.Attachments.Add(new Attachment() {     ContentUrl = "https://upload.wikimedia.org/wikipedia/en/a/a6/Bender_Rodriguez.png",     ContentType = "image/png",     Name = "Bender_Rodriguez.png"       });
The sample code indicates  to add the attachment to the message rather than the instantiation you are using.
Sincerely,
IoTGirl

Closing, received no response


KeyError

Hi, I used Weightipy to cpmpute my data's weight，the code in below:
`age_targets = {'agecat':{1: 0.067468889, 2: 0.080224503, 3: 0.081368672, 4: 0.084373472, 5: 0.102660891
,6:0.094806186,7:0.090030135,8:0.090639452,9:0.088830485,10:0.077339418,11:0.136466392,98:0.005791506}}
gender_targets = {'gender':{1: 0.488588237, 2: 0.511411763}}
county_targets = {"county":{2:0.019395905,4:0.023782735,5:0.02292341,7:0.02292341,8:0.02088535,9:0.028729086,10:0.021700082
,13:0.034964756,14:0.009158398,15:0.013730506,16:0.004724007,17:0.015997925,18:0.018345312,20:0.011139324
,63:0.107256094,64:0.11836086,65:0.173914542,66:0.118862683,67:0.080211099,68:0.095929136,72:0.006447622}}
scheme = wp.Rim('gender_and_age_and_county')
scheme.set_targets(targets=[age_targets, gender_targets,county_targets])
pres_df["identity"] = range(len(pres_df))
engine = wp.WeightEngine(data=pres_df)
engine.add_scheme(scheme=scheme, key="identity", verbose=False)
engine.run()
df_weighted = engine.dataframe()
col_weights = f"weights_{scheme.name}"
efficiency = wp.weighting_efficiency(df_weighted[col_weights])
`
when run this code，show  KeyError: "['gender', 'agecat', 'county'] not in index"，how do I to fix it? Thanks!

Hi,
This normally suggests that those columns do not exist in your data.
The first place to check is that "gender", "agecat" and "county" are columns in your pres_df.


[BUG] Multiple Images missing/filtered out after publishing to repository

I added multiple images into a not published note and published it. After publishing only one image path got recognized and changed, every other path is still the ![[image.png]] and the images are missing in the src/site/img folder. I manually added the images there and changed the file in the repository, but the plugin wants to change them back:

It also wants to delete every image I uploaded "since they are not part of a note"

I had this issue before and worked around it, by adding pictures one by one and publishing in between, but this time I bulk-added these pictures, and they are too much to do this approach again.

Okay I need to update my BUG report, the images aren't recognized, if they are inside a table and have a |<size> since the pipe will be escaped \|<size> and the plugin can't find the file anymore:


Implement custom constructor for entity

@rmannibucau I have implemented the custom constructor with 100% generated source code.
Please have a look/check out and test it and if it is OK I can merge it

@doanduyhai looks good to a first round, let's start with it! Thanks a lot!

https://github.com/doanduyhai/Achilles/wiki/Achilles-Annotations#entitycreator
Released in Achilles 5.3.0


No condition: handler not called

This works
        this.steady = new Steady({
            conditions: { "max-bottom" : 1000},
            scrollElement: this.getDOMNode(),
            throttle: 500,
            handler: function(values,done) {
                console.debug("scroll",values);
                done();
            }.bind(this)
        });

This does not:
        this.steady = new Steady({
            conditions: {},
            scrollElement: this.getDOMNode(),
            throttle: 500,
            handler: function(values,done) {
                console.debug("scroll",values);
                done();
            }.bind(this)
        });

I think the handler should be fired

Because there's no conditions to satisfy
Look at line #163
if ( !self._wantedTrackers.length || self.processing ) return;

if there's no trackers (a.k.a conditions) Steady.js won't do anything because otherwise it'll be triggered with every scroll event that isn't throttled by Steady.js, which is a bad practice that led me to create Steady.js in the first place.

Actually I would have expected the handler to be called with every scroll event, but the handler being throttled.

I'm sorry, but i see that as an anti-pattern.

why?

Because it's most likely that this handler will be executing different logic based on the location of the user in the page.
Which means breaking down the code to each scenario is a lot better than tangling it together.

Actually I don't use Steady on the body node but smaller divs so generally the behaviors is well encapsulated


Editing observation field by updater_id generates "[user_id] added a value" notification

brought to my attention here https://www.inaturalist.org/observations/8739685
and replicated here:
https://www.inaturalist.org/observations/570463
yarnallj edited the Host observation field value from 'Coyote Brush' created by kueda to 'Asteraceae' and generated a notification that appeared to come from kueda rather than yarnallj

This is kind of a giant pain since almost all activity updates assume content was created, not updated, and it just adds a bunch of strings for translators to translate that we'll probably just throw away if/when we overhaul notifications. Can we just punt on this? Or not generate notifications when OFVs are updated?


Wire up minRange/maxRange to plotly

Fixes deephaven/deephaven-core#1112
For quick validation of my work please read the plotly documentation here:
https://plotly.com/python/reference/layout/xaxis/#layout-xaxis-range

Also, can you help me understand what exactly the github action is complaining about and how I can go about making it happy?

@nbauernfeind as mentioned in Slack:

Okay so the tests are complaining because you're adding a range, which has it fall into the if block at ChartUtils:811 if (getRangeParser && range && !autorange) {, which ends up calling TableUtils.isDateType, which isn't a function in our mock in<EMAIL_ADDRESS>. So should just add that function to the mock.
As for plotly not updating the zoom, you can listen for onSelected or onSelecting... my guess is that by explicitly setting the range, we need to explicitly update it as well. Though not seeing that in the docs, haven't dug in the source yet. So adding an event handler in Chart and updating the axes with the new ranges (I think)

@nbauernfeind let me know if you can still work on this or if you want us to take over or close it

This seems to be low-priority and we don't have the resources to attack it in the short-term. The issue will remain open but I'll close this PR for now.


Alt attribute not working

Hi !
When I fill in the "alt" attribute in an image while it's processed through lazysizes and RIaS plugin, the only visible image is the smallest version.
Here is my code :
<img class="lazyload" data-src="path/to/my/img-{width}.jpg" data-format="full" data-sizes="auto" alt="foobar">

If I leave it empty, it works like a charm.
Oddly, it works well if I write less than 5 letters in the attribute, and it seems to be used in order to make some kind of calculations : the image's width is calculated on the basis of the size of the "alt" text as it's displayed on the web page.
Regards.

I suspect, that you don't specify the width of your image in your CSS.
From the documentation:
Important: How sizes is calculated: The automatic sizes calculation uses the width of the image. If it is below 40 (can be configured through the minSize option), lazysizes traverses up the DOM tree until it finds a parent which is over 40 and uses this number. Often the following general CSS rule might help: img[data-sizes="auto"] { display: block; width: 100%; } (see also specifying image/iframe dimensions).
This means, if you have no alt your image is smaller than 40 and lazySizes tries to get the width from a parent element otherwise it uses the width of the element itself.
I suggest that you always specify the width of your image.

Thank you, you were right.
It works pretty well right now.


SEC-1883: Upgrade Netty version to fix CVEs.

This will fix the following three CVEs brought by io.netty:netty-codec-http2 and io.netty:netty-codec-http.
https://confluentinc.atlassian.net/browse/SEC-1883
https://confluentinc.atlassian.net/browse/SEC-2016
https://confluentinc.atlassian.net/browse/SEC-2022
Committer Checklist (excluded from commit message)

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation (including upgrade notes)

nit: We use JIRA ID or "CONFLUENT:" in the PR title.

nit: We use JIRA ID or "CONFLUENT:" in the PR title.

SEC-1883 is a Jira ID. Do you mean put the text "Jira ID" in the title?

nit: We use JIRA ID or "CONFLUENT:" in the PR title.

SEC-1883 is a Jira ID. Do you mean put the text "Jira ID" in the title?
No. I have updated the PR title (ex: "SEC-1883: Upgrade Netty version to 4.1.61.Final"). We can follow similar pattern

Cherry-pick results seems to carry multiple lines. Here is a simpler way: https://github.com/confluentinc/kafka/pull/539

Forgot 2.6 merge: https://github.com/confluentinc/kafka/pull/540


Plugin doesn't work with sequelize and postgres

Hi there,
I'm trying to use this plugin with sequelize and postgres.
But after installing this plugin I get this error:
Please install pg package manually
What can I do with this?
Best regards

npm i pg

You can pass in a dialectModule when constructing sequelize which you can set to be pg.


Remove season collection from client.go

Collecting the seasons is no longer needed. The year can be gotten from the episode itself.

Completed in d10dbd4c47643d1cf595d20bbfb074c43b80171d


Keyboard doesn't work Tuxedo Polaris Gen 5

Describe the bug
Keyboard doesn't work on Tuxedo Polaris Gen 5 laptop.
Steps To Reproduce
Try installing nixos 23.05 on Tuxedo Polaris Gen 5 laptop -> Keyboard doesn't work in the installer.
Expected behavior
Keyboard should work out of the box.
Additional context
I don't quite now, how I can force my keyboard to work. I've used screen keyboard to install the os, but it still doesn't work. I've tried to edit configuration.nix , but it's quite difficult to do it without terminal (screen keyboard doesn't work there). And text editor can't edit files that require sudo (or I just didn't find a way to do it)
I ask for your help to figure out, how this problem may be solved.

I've found a solutions to this problem. You have to apply this patch to the kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0da9eccde3270b832c059ad618bf66e510c75d33


Official Docker images

Credit
This request was originally raised by @eyalkoren and credit for the suggestion goes to him. :)
Overview
There are cases in which it makes sense to have an official Docker image for the APM Java agent. This is a proposal for the creation of such an image and for its deployment as a part of the build and release process for the APM Java Agent.
Use cases
One use case which has been well-outlined by @eyalkoren in a separate document is for a standalone agent container as a part of a K8S cluster. As a pod starts, an agent container can be configured as an init container for the pod. In doing so, the APM agent would start up prior to the application(s) in the pod and be available for instrumentation by application containers through the use of the JAVA_TOOL_OPTIONS environment variable.
I'm sure there are likely other use cases for this or the above case can be expanded upon, but I'll let @eyalkoren extend what I've written above as he sees fit. :)
Current Build Process
Currently, the build process for the Java APM agent is outlined here.
As one can see, there is currently no mention of an official container being built, nor does the repo currently contain a Dockerfile with which to build one.
Proposed Changes
This request is a collection of a few concrete changes:
1. Official Dockerfile
Obviously, the build process will need a Dockerfile in the repository. @eyalkoren has kindly provided a basic sample which could get us started by checking it directly into the root of the repository.
Alternatives
The above is simple enough that I assume we can just check it in directly instead of making it a part of the build process to create it dynamically. However, I'll mention that as an alternative here just in case the team thinks this might be a worthwhile area of exploration.
2. Official Docker image
Right now, there is no observability namespace in our Docker repository, which we would likely want in order to host these images. If we agree that creating Docker images for the APM Java Agent is a worthwhile endeavor, I will reach out to the appropriate folks to make this happen.
3. Build process
Right now, we use an internal CI server as a part of the release process. We propose modifying that pipeline to create an image as an artifact which can be automatically pushed up to Docker Hub once the requirements in step 2 are in place.
Questions
Snapshots?
We could, in theory, create nightly image snapshots as Docker images and make them available as well. My guess is that with a simple Docker file, anybody who wants an image could just clone the repository and build one themselves but if this is something people are interested in, it's worth discussing.

We now have official Docker images displayed on the registry web page, thanks to https://github.com/elastic/infra/issues/17508


Simplify ships

Closes #49. This changes the possible statuses to just Available, Busy, and InUse. Only InUse supports progress. This also fixes / changes a few small details, like airships also displaying information missed in 46ad4a5.

I really wanted to merge migrations 4, 5, and 6, but it threw an error with each thing I tried. My best attempt is squishing it into 2 instead. See edgedb/edgedb#6296.


Oracle resource detector

Added OracleResourceDetector for:

Ruby (scheduler)
JS (backend, discordgateway2http)
Python (voice)

please also increment versions for scheduler and voice

actually, bump version everywhere


American Express broken

I've been using ofxclient to download my American Express card transactions daily since 2017-03-07 at the same time every day (approximately 02:41 Eastern / 06:41 GMT). I'd only had 2 problems previously. On 2019-05-25 this stopped working for me, with the AmEx server returning a HTTP 403 Forbidden, and I haven't been able to get it to work since. I've tried various combinations of Accept header, APPVER and OFX VERSION, to no avail.
Is anyone else using this for AmEx, and can either confirm or refute this issue?

I just got off the phone with AmEx technical support and managed to speak with a supervisor. I was told that while they only officially support Quicken and Quickbooks, they can confirm that they've had quite a few customers reporting 403 errors lately via OFX Direct Connect in those products, and they have people working on it. Their current recommendation is to disconnect and reconnect your finance app and try again, and if that doesn't work, try again in a few days...

I ran into this as well. It might be a coincidence but it started working for me again after setting the accept header to text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8. Yeah, odd.

Hmm, interesting. I hadn't tried that.
After battling with this for a few days, I signed up for a free development account with Plaid ( see https://plaid.com/products/transactions and https://plaid.com/docs/quickstart/ ) and wrote a simple client using their API. Given how well it's working, I may end up abandoning all of my OFX scripts in favor of it...

@q3aiml Nice tip! My AMEX OFX downloads have been broken for weeks, that fixed it for me. For anyone else who wants to do this, just add the following to your ofxclient.ini file for your AMEX account:
institution.client_args.accept = text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8

As of 7/4/2020 this fix worked to make my amex calls function.  I pasted exactly what @shawkinaw provided.


The default value for the Default Pod Security Admission field changes to "(None)" on older K8s versions

Setup

Rancher version: v2.7-head (Commit ID: 7c60dc0)
Browser type & version: Brave: Version 1.48.167 (Chromium: 110.0.5481.104)

Describe the bug
When provisioning an RKE2 or K3s downstream cluster, the default value for the Default Pod Security Admission field changes to "(None)" if the K8s version is set to v1.24 or older
To Reproduce

Spin up a Rancher cluster
Begin the process for provisioning an RKE2 cluster
Change the Kubernetes Version to v1.24.1+rke2r1

Result
The default value for the Default Pod Security Admission field changes to "(None)"
Expected Result
The default value for the Default Pod Security Admission field should remain as the correct default value (i.e. "Default - RKE2 Embedded")
Screenshots

This issue is related to 8247

@jameson-mcghee this is working as expected. Kubernetes 1.24 did not have a default PSA based on that version so we won't apply that. 1.24 would have a default PSP instead.

Like I mentioned on 8247, it is my understanding that we recently changed the label on the default value for fields like (for example) Cloud Provider to state "Default - RKE2 Embedded" instead of "(None)". On v2.6-head (Commit ID: ddecd1b), this remains as "(None)" for the Cloud Provider field (see screenshots below).
So are you saying that on v2.7-head that  Cloud Provider of value "Default - RKE2 Embedded" is actually setting a Cloud Provider value, or is it None? If it means None, then is that not confusing in relation to this field? When on K8s v1.25, is the default value for PSA, actually setting a PSA? Having inconsistency in the labels is confusing to me, so I would imagine it would be for users as well.

Removed the milestone as there was no fix and this "functions as designed".


Short solution needed: "ffmpeg itsoffset" (ffmpeg)

Please help us write most modern and shortest code solution for this issue:
ffmpeg itsoffset (technology: ffmpeg)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

How to delay video using itsoffset option


allow booting Linode into rescue mode with more than 2 disks

Previously the call to zip would only zip to /dev/sda and
/dev/sdb, so if a Linode has more than 2 disks, only the first 2
specified would be mounted when booting into rescue mode. This expands
the call to zip to include each mountable device slot for rescue mode.
Seems to work as expected:
>>> l1.disks
PaginatedList (2 items)
>>> disks1
[17444995, 17444996]
>>> l1.rescue(*disks1)
{}
>>> l2.disks
PaginatedList (7 items)
>>> disks2
[17445035, 17445036, 17445039, 17445040, 17445045, 17445048, 17445211]
>>> l2.rescue(*disks2)
{}

# Finnix console on l1
root@ttyS0:~# lsblk
NAME   MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
sda      8:0    0 19.5G  0 disk
sdb      8:16   0  512M  0 disk
sdh      8:112  0  160M  1 disk
`-sdh1   8:113  0  160M  1 part
loop0    7:0    0  146M  1 loop /media/compressed_root

# Finnix console on l2
root@ttyS0:~# lsblk
NAME   MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
sda      8:0    0    1G  0 disk
sdb      8:16   0    1G  0 disk
sdc      8:32   0    1G  0 disk
sdd      8:48   0    2G  0 disk
sde      8:64   0    2G  0 disk
sdf      8:80   0    2G  0 disk
sdg      8:96   0   11G  0 disk
sdh      8:112  0  160M  1 disk
`-sdh1   8:113  0  160M  1 part
loop0    7:0    0  146M  1 loop /media/compressed_root

I think when I first implemented this, the API only allowed two disks. Thanks for the fix :+1:

No worries! Happy to help. <3


How to change streaming resolution of parrot mambo fpv?

The default streaming resolution of mambo is 360p.
I want to change this to 720p.
I tried it by this code but this did not work. :(
I define this function in Mambo class in Mambo.py
def SetResolution(self)
(command_tuple, enum_tuple) = self.command_parser.get_command_tuple_with_enum("minidrone", +"VideoSettings", "VideoResolution", "hd")
return self.drone_connection.send_enum_command_packet_ack(command_tuple, enum_tuple)
I used SetResolution function in demoMamboVision.py
after the function called 'success = mambo.connect(num_retries=3)'
How should I modify the code to change resolution?
Thank you

I haven't tried to change that.  I can look into it shortly.

did you success to change the resolution?
I read the arsdk3 and I think that there are only 2 option 720p or 360p for bebop2.

The above-mentioned command tuple was able to successfully change the video resolution. I verified this by executing the above command while VLC was playing the video stream

You mean SetResolution function works well?

That's right. The command tuple you are using is the one I used. But I was sending the tuple after the initialization, not immediately after the connect.

Excellent!  I'll get it added.  I just hadn't had a chance to test it yet.


disable Date fields

Hi,
How can I disable a 'Date' field? So adding disabled="disabled" to all 3 select fields?

It looks like this is a bug - the hidden input in a Date editor is disabled with the disabled call, but the 3 select boxes are not.
As a workaround, you can "manually" set the disabled property on the 3 select inputs - see this JSFiddle

All right, that works. thx!


Allow string manipulation in commitUrl

Hello,
First of all, your extension is very handy !
I've got a request about the way the extension generates links (commitUrl).
I need to upper case the project name to fit with a Phabricator instance.
The URL would be of this format : https://my-phabricator-instance/rMYPROJECT4823fec0348bf0606bee42244425913eb2b00254.
But setting commitUrl value as https://my-phabricator-instance/r${project.name}${hash} does not work (because project is named in lowercase : myproject.git.
Is it possible to allow string manipulation on tokens ?

Hello PapsOu!
Thank you for the feature request.
I will see if I can figure something out.

This will be released with Version 3.
There are two tokens that can be used by appending |u or |l to the end of a token.
|u will uppercase the value and |l will lowercase it.

Perfect it works great !
Thank you very much


Blog Post: Nostr LTS Grant for @hzrd149

Approved by @hzrd149
To be sanity checked by @OpenSats/volunteers

Build preview: /blog/hzrd149-receives-lts-grant

Yep - what @Arvin21M said :-)

Checked and merged


Standardise GA events

What it solves
Resolves #2969
How this PR fixes it
All events are now centralised in the analytics file.
How to test it
Navigate the Safe and expect all events to be standardised in GA.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

11 of 20 (55.0%)  changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 31.595%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/SafeListSidebar/index.tsx
0
1
0.0%

src/routes/CreateSafePage/components/SafeCreationProcess.tsx
0
1
0.0%

src/routes/safe/components/AddressBook/index.tsx
0
1
0.0%

src/routes/safe/components/Apps/components/AppFrame.tsx
0
1
0.0%

src/routes/safe/components/Balances/Coins/index.tsx
0
1
0.0%

src/routes/safe/components/Balances/Collectibles/index.tsx
0
1
0.0%

src/routes/safe/components/Settings/ManageOwners/index.tsx
0
1
0.0%

src/routes/safe/components/Settings/SafeDetails/index.tsx
0
1
0.0%

src/routes/safe/components/Settings/ThresholdSettings/index.tsx
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
2978

Relevant Lines:
8405

💛  - Coveralls

@katspaugh @iamacook Sorry. I didn't see that this was here and merged already.
The "Connect a wallet" event should have "Wallet" with uppercase "W" and is still with lowerCase in the unified stg app.
Pin and Unpin are fine.


Failed to find control with error "Error: waitAsync is already running and cannot be called again at this moment"

Hi Experts,
There's a strange error in my test. My test is very simple, after opening the page, there are two assertions: asserting control A is visible and asserting control B is visible.
If I only write any one of the assertions, the test will pass. But if both assertion exists (no matter what the sequence is), the first one will be success but the second will fail with error: "Error: waitAsync is already running and cannot be called again at this moment". Any idea on this? Thank you!
UI5 version: 1.97.1
Thank you and best regards,
Cong

Some more information:

my .conf.js file:
const { TimelineService } = require("wdio-timeline-reporter/timeline-service");

exports.config = {
    runner: "local",
    specs: [
        "./tests/wdi5/specs/dpp/*.spec.js"
    ],
    exclude: [],
    maxInstances: 1,
    capabilities: [{
        maxInstances: 1,
        browserName: "chrome",
        acceptInsecureCerts: true
    }],
    wdi5: {
        screenshotsDisabled: true,
        logLevel: "error",
        platform: "browser",
        url: "",
        deviceType: "web",
        waitForUI5Timeout: 120000,
        skipInjectUI5OnStart: true
    },
    logLevel: "error",
    logLevels: {
        webdriver: "error",
    },
    bail: 0,
    baseUrl: process.env.CUSTOM_URL,
    waitforTimeout: 120000,
    connectionRetryTimeout: 120000,
    connectionRetryCount: 3,
    services: ["chromedriver", "ui5", [TimelineService]],
    framework: "mocha",
    reporters: ["spec", ["timeline", {
        outputDir: "./reports",
        fileName: "report.html",
        screenshotStrategy: "on:error"
    }]],
    mochaOpts: {
        ui: "bdd",
        timeout: 120000
    }
};

My test:
const Ui5Service = require("wdio-ui5-service").default;
const ui5Service = new Ui5Service();

describe("I check DPP.", function () {
    it("I check customers in DPP.", () => {
        browser.goTo("<my ui5 page>");
        ui5Service.injectUI5();

        expect(browser.asControl({
            selector: {
                id: "idSearchMaster",
                viewName: "deleteDataSubjects.view.Master"
            }
        }).getVisible()).toBeTruthy();
        expect(browser.asControl({
            selector: {
                id: "idMasterApplGroupFilter",
                viewName: "deleteDataSubjects.view.Master"
            }
        }).getVisible()).toBeTruthy();
    });
});

Hi @cwang1221 ,
I wasn't able to reproduce this in our rather small test environment. (https://github.com/js-soft/wdi5/blob/develop/wdio-ui5-service/test/ui5-late.test.js)
I placed this snippet
`it.only('I check the header visibility in Master Page', () => {
// open ui5 page
browser.url('https://openui5.netweaver.ondemand.com/index.html');
// do the late injection
ui5Service.injectUI5();
    expect(
        browser
            .asControl({
                selector: {
                    id: 'sdk---app--controlsMasterTab',
                    viewName: 'sap.ui.documentation.sdk.view.App'
                }
            })
            .getVisible()
    ).toBeTruthy();

    expect(
        browser
            .asControl({
                selector: {
                    id: 'sdk---app--apiMasterTab',
                    viewName: 'sap.ui.documentation.sdk.view.App'
                }
            })
            .getVisible()
    ).toBeTruthy();
});`

in ui5-late.test.js and ran npm run test:ui5_late .

Your conf file looks fine, I also played around with different settings -> same result.

Hi @dominikfeininger, thank you for your quick reply! I think so because I could successfully test other apps with the same UI5 version. It seems to be some problems with the app (not sure). I just want to know if you have any hint on the error "Error: waitAsync is already running and cannot be called again at this moment"? If you know any possible reason/solution of it? Thank you!

I never experienced this behavior.

Hi @dominikfeininger, I think I find the reason, the page I was testing is trying to get <...>/resources/sap/dfa/help/utils/adapters/fiori/Component-preload.js. But the request keep pending there, which cause the autoWait to keep waiting. After I blocked the request, the test passed.
Thank you and will close this issue.

Hi @dominikfeininger,
try to get an aggregation (e.g. getItems()) as the 2nd call - then it will wail each time (at least in my test project, see attached zip file). Do you have a solution for this? I assume this is not really solved.
Cheers Bas
sample_wdi5.zip
.

 Dann sehe ich "world" im Eingabefeld
[chrome 97.0.4692.99 mac os x #0-0] Error: expect(received).toBe(expected) // Object.is equality
[chrome 97.0.4692.99 mac os x #0-0] Error: expect(received).toBe(expected) // Object.is equality
[chrome 97.0.4692.99 mac os x #0-0]
[chrome 97.0.4692.99 mac os x #0-0] Expected: "world"
[chrome 97.0.4692.99 mac os x #0-0] Received: "hello"
[chrome 97.0.4692.99 mac os x #0-0]     at World.<anonymous> (/Users/vbuzek/Downloads/sample_wdi5/webapp/test/steps/steps.js:40:5)
[chrome 97.0.4692.99 mac os x #0-0]     at processTicksAndRejections (node:internal/process/task_queues:96:5)

Spec Files:      0 passed, 1 failed, 1 total (100% completed) in 00:00:59

but i had to make changes in the setup to get things running:

wdio.conf.js → fixed up some config issues
index.html → changed to most current ui5 version from cdn for bootstrapping → there seems to be an issue w/ UI5 1.71.x that you were using 😢

here are the changed files, w/ modified extensions due to gh upload restrictions:

wdio.conf.js.txt
index.html.txt

if your issues persist, please open up a new issue in here - the report template will guide through all the information that we need to make debugging and support easier. thanks!

@vobu thanks for your support and the changed files.
... for future references: the line in wdio.conf.js was the problem (probably because I didn't include it in my package.json):
automationProtocol: "devtools"


How to force exit?

I'm using kopf for a Kubernetes controller project and one of the things I'm expecting it to do is exit with a non-zero exit code if certain conditions are met. This will cause the pod to get restarted and another process will resolve the condition.
Normally I'd do this with sys.exit(1) or raise SystemExit, but those don't seem to work. I'm not sure what state it gets in, but it doesn't exit. I've got a few ways I can work around this, but since you already have the concept of different error types that lead to different behaviors by kopf, it'd be cool to have another error type to signal to kopf that I want the whole process to exit with a certain error code.

@moduspwnens Can you please clarify which version of Kopf do you use? And how do you check that it does not exit? I.e., does it freeze on exit with no activities happening, or it says they was a SystemExit exception, and silences it silently?

Sorry--I saw this as more of a feature request than a bug report, so I didn't include bug report details.
I was using version 0.22, but as part of verifying steps to recreate the issue for this comment, I tried version 0.23 instead and it's working as expected there. When I do sys.exit(1), it exits immediately with the exit code I specify. So it seems to be working for me now. Thanks!

I see. Such exiting was never a tested or specially designed behaviour. Therefore, I didn't know how it will behave with SystemExit raised in a threaded handler — will it escalate, or will it be suppressed.
But since it works now, it could also be caused by #142 — an improper process termination. I.e., it actually exited the operator previously on SystemExit, but was freezing at the after-exit cleanups (children threads waiting).


Iteration4

Pull Request
Please include a summary of the change:
If it is a new feature, describe the feature and the iteration of the project spec it addresses. Note any questions or struggles as well.

Manager can search for any user by name and view the total amount they've spent and a list of all their bookings
Manager can add and delete room bookings for that user
Bookings are posting and deleting from endpoint but is not yet reflected on the DOM unless user logs out and back in
Filed issues for other enhancements and bugs

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[X] My code follows the Turing style guidelines
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas

Files Modified:
modified:   src/Hotel.js
modified:   src/Manager.js
modified:   src/index.js
modified:   test/Booking-test.js
modified:   test/Guest-test.js
modified:   test/Room-test.js
modified:   src/Hotel.js
modified:   css/base.scss

@Karlfunhouse @hannahhch @thatpamiam


Issue on Safari

When using in Safari, I get this error:
Import error: e.stream is not a function. (In 'e.stream()', 'e.stream' is undefined)
Also tested in Chrome and Firefox, which appear to work.

Fix released in v0.5.1. Thanks for reporting, and please let me know if this happens again!