Pmd clean up

This is a CLEAN PR which containts only Annotations to switch off some of the Codazy/PMD rules regarding the Deparsers and Visitors.
Also added some Java Code Formatter Configuration.
No code changes.

Coverage remained the same at 88.531% when pulling aa50a910350240437168a577262be271e8923019 on manticore-projects:PMDCleanUP into 9184cda558e60a59aa3bf31eb599b6d7c78b73dc on JSQLParser:master.

Summary of that PR in one chart:

On Wed, 2021-06-02 at 05:14 -0700, Tobias wrote:

Damned. You are right. However, I will remove it from Codacy.

Have a look at the project's PMD config. I marked the rules in palce
fro Codazy only and would like to suggest to remove these from Codazy.
It is not a bad thing at all, but some of the rules really create more
headache then helping.


149 - Don't silence HTTP errors in SVGCacheService

Instead of using the finalize operator which will make the observable always succeed, use tap and catchError to delete the in progress request, while ensuring that HTTP errors will be logged on the onSVGFailed output.
Fixes #149

Fixes #149

Thanks!


MOH Vendor Registration and Approval process

Hi there,
Thank you for open sourcing this project and demystifying the API connection process with the MOH APIs.
It looks like before accessing these APIs, one would need to apply to be a vendor. Can you talk about your process of going through that? and is vendor approval with conformance testing required to access the APIs?
My use case is for personal use only. My wife is a healthcare provider, and I wanted to use the APIs to see if I could provide some additional analysis and reporting on the data available, that her EMR does not already provide. Is such a use case allowed? (I don't intend on making a real EMR).
Would very much appreciate your insights, and if you prefer discussing this over email, please let me know.
Thank you

Not possible to interact with MOH API unless you go through conformance testing and obtain a production API.
I have obtained a production key for my own API to interface with MOH server, but not ready to make it public yet. 1) I would need to figure out where to host my API publicly and whether I can take on the cost of the traffic 2) even if I do provide a free public API access, user would need to provide their GO Secure login (given only to Doctors in Ontario) to use the MOH web service. This input is required for the API. I would not be comfortable transmitting login to a third party and I would not expect users to do this as well. So I haven't thought of a solution to this yet.

Thank you for your reply.
I think you might have misunderstood my question. I was not asking the use of your API.
I wanted to hear about the process of getting a vendor application and getting a production key.
Where do we apply for a vendor application and get a sandbox key?
How long did it take to get approved?
What was the process of getting a production key and going through conformance testing? How long did that take?
I'm hoping to go through this process for my own personal use case.
Regarding your comments about how to host it. If you are planning to host your application, I can help you with that when you are ready. This is within my professional expertise.
Also regarding third party access - a doctor would not need to provide their login. I have helped setup access for applications that use MCEDT. She adds an email as a designee. See this doc for more info: https://www.intelagent.ca/docs/getting-started/designation
I think you would be able to offer a similar process as a vendor.

This is the ministry's official page with details
https://www.ontario.ca/page/ohip-publications-medical-claims-and-health-card-validation

This is the ministry's official page with details
https://www.ontario.ca/page/ohip-publications-medical-claims-and-health-card-validation

I've had a look at the page, but I don't see any doc or page for vendor registration. Is it an online process or is calling them required for initial registration?

Here is the application form: https://forms.mgcs.gov.on.ca/dataset/014-4860-84


Create compatibility layer in preparation for new goal states

This PR enables the scheduler to parse ONCE and FINISHED goal states from the config store, enabling it to be downgraded to from a later version making use of those new states.

LGTM.  Ok to merge once tests pass.


feat: implement example

We need to implement examples for usage.

https://codesandbox.io/s/redux-action-listener-hook-counter-example-0dti5?file=/src/reducer.ts

https://codesandbox.io/s/redux-action-listener-hook-counter-example-0dti5?file=/src/reducer.ts


Fix key and value parameters in AddOrUpdate method

In AddOrUpdate method currently mime type is used as a key in a dictionary which is indexed by extension string. This PR is fixing this.

Thx!


How to selectively clean a room?

Hi there,
unfortunately the readme does not shed light on this..
How can i make my S50 clean lets say "the kitchen" ?
I´ve added the robot in config.json like this:
"accessories": [
{
"accessory": "XiaomiRoborockVacuum",
"name": "Roborock S50 Upper Floor",
"ip": "<IP_ADDRESS>",
"token": "sdfsdfdsfsdfsdfdsfsfsdfasdadas",
"pause": false,
"dock": true,
"waterBox": false,
"cleanword": "clean",
"rooms": [
{
"id": 1,
"name": "the living room"
},
{
"id": 2,
"name": "the bedroom"
},
{
"id": 3,
"name": "the bathroom"
},
{
"id": 4,
"name": "the kitchen"
},
{
"id": 5,
"name": "the working room"
},
{
"id": 6,
"name": "the guest room"
}
]
So how can i actually MAP the name of the room / the ID ? to the correct room in my homekit ?
I see 6 switches and saying "hey siri - clean the kitchen" works.. the robot starts going somewhere and its overwriting my map in the MII Home App totally.
I would say, i have to tell in the MII Home App, that a particular Room is ID 4 and so on.. but i cant seem to be able to add that..In my Mii Home App i have Zones that are color coded but they do not have numbers (like i would need for the room id feature)
Also what i dont understand is: Where is the difference between rooms and zones ? Zones are containing multiple rooms i guess ? So working with rooms will be the right thing for me.
Any help how to map my rooms to the Room IDs would be appreciated.

If you set the room detection to "auto" you will see in the homebridge log the ID of rooms.
you should see something like:
INF createRoom | undefined | Room Küche (16)
[4/28/2020, 10:47:32 AM] [Bobo] INF createRoom | undefined | Room Wohnzimmer (17)
[4/28/2020, 10:47:32 AM] [Bobo] INF createRoom | undefined | Room Flur (18)
[4/28/2020, 10:47:32 AM] [Bobo] INF createRoom | undefined | Room Badezimmer (19)
The IDs are defined by the vacuum. Once you've got them, just add them statically to your config,json with a desired room name.
 Actually cleaning zones is not so easy via homebridge as it requires manual adjustments of the coordinates of your zones. See: https://github.com/nicoh88/homebridge-xiaomi-roborock-vacuum/issues/148
Hope this helps

This part of the readme explains how to find the IDs and automatically match it to names: https://github.com/nicoh88/homebridge-xiaomi-roborock-vacuum#semi-automatic
I'm closing the issue for now. Feel free to reopen it if you feel like it didn't solve your issue

This part of the readme explains how to find the IDs and automatically match it to names: https://github.com/nicoh88/homebridge-xiaomi-roborock-vacuum#semi-automatic
I'm closing the issue for now. Feel free to reopen it if you feel like it didn't solve your issue

Thank you afharo and AlexG-78 for helping me out on this.
Could you please provide some code sample for the config.json ?
Since i have the S50 i cant use the autoroom generation and will have to use the semi-automatic procedure.
How would the "array of room names" be defined in config.json ?
autoroom = room1,room2,room3;
?
Thus meaninig, i´d have to create all rooms in homebridge first, since i only have the room names in my apple home IOS app defined. Homebridge only knows the "Default room" yet.
Thanks

{
  ...
  "autoroom": ["room1", "room2", "room3"],
  ...
}

I would recommend you to copy the entire file in a JSON validator like https://jsoncompare.com/#!/simple/ to make sure there are no errors in your config.json file.

Thanks, everything worked. But one thing is strange: When adding the "autoroom" strings to my config.json together with the rooms string, the name of the "rooms" string is not obeyed/transmitted to the apple home app. It always shows the name i have in the autoroom array.
This is not really dramatic because i can change the name of the autoroom values. But it occurs, that i want to have an article (german = der/die/das) in front of the name so i can speak to siri in a correct sentence.
 So i need to put a "die" in front of (the) kitchen as a room name:
Example:
"accessories": [
{
"accessory": "XiaomiRoborockVacuum",
"name": "Roborock S50 OBEN",
"ip": "xx.xx.xx.xx",
"token": "XXXXXXXXXXXXX",
"pause": false,
"dock": true,
"waterBox": false,
"cleanword": "reinige",
"autoroom": [
"das Wohnzimmer OBEN",
"das Schlafzimmer OBEN",
"das Badezimmer OBEN",
"den Computerraum OBEN",
"den Kühlschrankraum OBEN",
"das Gästezimmer OBEN",
"den Flur OBEN",
"den Flur Treppe OBEN",
"den Kleiderschrankraum OBEN"
],
"rooms": [
{
"id": 17,
"name": "das Wohnzimmer OBEN"
},
{
"id": 18,
"name": "das Schlafzimmer OBEN"
},
{
"id": 19,
"name": "das Badezimmer OBEN"
},
{
"id": 16,
"name": "den Computerraum OBEN"
},
{
"id": 20,
"name": "den Kühlschrankraum OBEN"
},
{
"id": 21,
"name": "das Gästezimmer OBEN"
},
{
"id": 22,
"name": "den FLUR OBEN"
},
{
"id": 23,
"name": "den Flur Treppe OBEN"
},
{
"id": 24,
"name": "den Kleiderschrankraum OBEN"
}
]
},
I´m a little confused why it does not match the name of the "rooms" string anymore. So just to be sure that it works with logical grammar spoken with siri, i added the article to all room names.
Seems to work fine. However i thought the names shown in the apple home app should come from the "rooms" string and not from the autoroom string.
Maybe its a bug. Maybe autoroom names overwrite the room names. I dont know. If its a bug let me know and i can open a new issue for it if you want.
Thanks alot for your help :)

Ha! It totally makes sense! Siri is just matching the name of the Switch. We all wish Siri was a bit smarter some times 😅
Thanks for confirming it works! I'm actually thinking about updating the README file to suggest the semi-automatic over the automatic mode (or, at least, make it clearer which one is recommended in each case) :)

thanks alot :) keep up your great work mate!


Clicking on a feature in the form list should select the feature on the map

Fixed with #191a9164e6759084cf1c787adeb715a2e2ece826


panic in handler for Rename

What is your rclone version (eg output from rclone -V)
1.36-251-g0b2b4243-tps-limitβ
Which OS you are using and how many bits (eg Windows 7, 64 bit)
Ubuntu 16.04
Which cloud storage system are you using? (eg Google Drive)
Google Drive
The command you were trying to run (eg rclone copy /tmp remote:tmp)
mount
A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)
panic.txt

2017/07/16 10:05:08 fuse: panic in handler for Rename [ID=0xba9 Node=0x19 Uid=1000 Gid=1000 Pid=20284] from "Brain.on.Fire.2016.1080p.WEB-DL.DD5.1.H264-FGT.mkv" to dirnode 0x3a "Brain.on.Fire.2016.1080p.WEB-DL.DD5.1.H264-FGT.mkv": assignment to entry in nil map
goroutine 4587 [running]:
github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).serve.func2(0x130b760, 0xc4202f40c0, 0xc420a81ef8, 0xc420a81e57)
/home/ncw/go/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:857 +0x1b1
panic(0xd19740, 0xc4203bffa0)
/opt/go/go1.8/src/runtime/panic.go:489 +0x2cf
github.com/ncw/rclone/cmd/mountlib.(*Dir).addObject(0xc420492100, 0x7f90d5974790, 0xc420a1dc80, 0x1307260, 0xc4201b9ea0, 0x2)
/home/ncw/go/src/github.com/ncw/rclone/cmd/mountlib/dir.go:132 +0x103
github.com/ncw/rclone/cmd/mountlib.(*Dir).Rename(0xc42184da80, 0xc420e6e2c0, 0x32, 0xc420e6e300, 0x32, 0xc420492100, 0x1, 0xc4214cf290)
/home/ncw/go/src/github.com/ncw/rclone/cmd/mountlib/dir.go:471 +0x9c6
github.com/ncw/rclone/cmd/mount.(*Dir).Rename(0xc420538140, 0x7f90d5a0b7d0, 0xc420e704c0, 0xc4202f40c0, 0x1301660, 0xc420538070, 0x0, 0x0)
/home/ncw/go/src/github.com/ncw/rclone/cmd/mount/dir.go:185 +0x36c
github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).handleRequest(0xc4200cae40, 0x7f90d5a0b7d0, 0xc420e704c0, 0x1301660, 0xc420538140, 0xc420a74e00, 0x130b760, 0xc4202f40c0, 0xc420a81ef8, 0x101000000000060, ...)
/home/ncw/go/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:1335 +0x2779
github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).serve(0xc4200cae40, 0x130b760, 0xc4202f40c0)
/home/ncw/go/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:878 +0x495
github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).Serve.func1(0xc4200cae40, 0x130b760, 0xc4202f40c0)
/home/ncw/go/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:425 +0x6e
created by github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).Serve
/home/ncw/go/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:426 +0x3c4

Another
panic3.txt

I've fixed this in https://beta.rclone.org/v1.36-264-gc223464c/ (uploaded in 15-30 mins)
Let me know if there are any problems with it ASAP please because I want to cut the 1.37 release this weekend!

Okay, will test it very soon. Just need to sync some files first. Should have a reply in an hour or two.

@ncw Sync finished starting testing now...

@ncw Its looking good, not been able to reproduce the error so far..

@ncw damn it happened again: panic4.txt
2017/07/22 15:17:54 fuse: panic in handler for Flush [ID=0x1a8838 Node=0x7bd Uid=1000 Gid=1000 Pid=9099] 0x1 fl=0x0 lk=0xb25bb827c732b0d4: assignment to entry in nil map
goroutine 1739480 [running]:
github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).serve.func2(0x13112a0, 0xc42e266370, 0xc4294fdef8, 0xc4294fde57)
/home/travis/gopath/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:857 +0x1b1
panic(0xd1a680, 0xc42d2c7870)
/home/travis/.gimme/versions/go1.8.3.linux.amd64/src/runtime/panic.go:489 +0x2cf
github.com/ncw/rclone/cmd/mountlib.(*Dir).addObject(0xc4205dc800, 0x7fd7bcfc0b50, 0xc42068d000, 0x130d260, 0xc4206b50a0, 0xc4294fd880)
/home/travis/gopath/src/github.com/ncw/rclone/cmd/mountlib/dir.go:132 +0x103
github.com/ncw/rclone/cmd/mountlib.(*File).setObject(0xc4206b50a0, 0x1317440, 0xc42068d000)
/home/travis/gopath/src/github.com/ncw/rclone/cmd/mountlib/file.go:149 +0x107
github.com/ncw/rclone/cmd/mountlib.(*WriteFileHandle).close(0xc42a793c80, 0xe79f10, 0xc42a793c80)
/home/travis/gopath/src/github.com/ncw/rclone/cmd/mountlib/write.go:129 +0x452
github.com/ncw/rclone/cmd/mountlib.(*WriteFileHandle).Flush(0xc42a793c80, 0x0, 0x0)
/home/travis/gopath/src/github.com/ncw/rclone/cmd/mountlib/write.go:172 +0x89
github.com/ncw/rclone/cmd/mount.(*WriteFileHandle).Flush(0xc42a61c120, 0x7fd7bcfc09d0, 0xc42e970b40, 0xc42e266370, 0x0, 0x0)
/home/travis/gopath/src/github.com/ncw/rclone/cmd/mount/write.go:56 +0x156
github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).handleRequest(0xc420308e40, 0x7fd7bcfc09d0, 0xc42e970b40, 0x13076e0, 0xc42a61c118, 0xc42a7aff00, 0x13112a0, 0xc42e266370, 0xc4294fdef8, 0x0, ...)
/home/travis/gopath/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:1282 +0x32fa
github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).serve(0xc420308e40, 0x13112a0, 0xc42e266370)
/home/travis/gopath/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:878 +0x495
github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).Serve.func1(0xc420308e40, 0x13112a0, 0xc42e266370)
/home/travis/gopath/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:425 +0x6e
created by github.com/ncw/rclone/vendor/bazil.org/fuse/fs.(*Server).Serve
/home/travis/gopath/src/github.com/ncw/rclone/vendor/bazil.org/fuse/fs/serve.go:426 +0x3c4

@ncw I'm confident this issue is resolved, not able to reproduce it. Great!

Excellent - thank you very much for testing :-)
Good to get this fix in to 1.37


Review lethal phenotype patterns

We should review the lethal phenotype patterns and add them to uPheno if we believe the way they are are the way to go!

looks like this will need 8 patterns:
some die -> mortality rate = 5-100% (relative to control rate)
partially lethal - majority live -> 5-50%
majority die -> 50-100%
all die -> 98-100%
each of these needs a 'before stage' version and a 'during stage' version

Example 'during stage' definition:
'has part' some
(('inheres in' some
('population of Drosophila' and ('has member' some
('multicellular organism' and (has_age some (substage_of some 'prepupal stage')))) and ('has member' only
('multicellular organism' and (has_age some (substage_of some 'prepupal stage')))))) and ('has increased age-specific mortality rate' some xsd:short[>= "50"^^xsd:short]))
We can probably change 'population of Drosophila' to 'population of organisms' (PCO:0000001) to allow use in upheno.
And change 'multicellular organism' to 'organism' for wider use.
has_age is an FBcv relationship, and substage_of is from FBdv, so would be nice to replace these with the has_stage relationship once this is added to RO:
'has part' some
('inheres in' some
('population of organisms' and ('has member' some
('organism' and has_stage some 'prepupal stage')) and ('has member' only
('organism' and has_stage some 'prepupal stage')) and ('has increased age-specific mortality rate' some xsd:short[>= "50"^^xsd:short]))
and ('has_modifier' some 'abnormal'))
'before stage' version could use
('organism' and has_stage ('life cycle stage' and precedes some 'prepupal stage'))
with 'life cycle stage' from UBERON

alternatively we could overhaul the whole thing to make it more upheno-like:
'has part' some
('increased mortality rate'
and ('characteristic of' some 'population of organisms')
and ('has percentage' some xsd:short[>= "50"^^xsd:short])
and ('existence starts and ends during' some 'prepupal stage')
and ('has_modifier' some 'abnormal'))
'increased mortality rate' would be a new class (probably in PATO)
'has percentage' would be a new data property (feels like this should exist already, but I couldn't find it)
'before stage' phenotypes would use 'existence ends during'
with this general pattern, we wouldn't need to specify a percentage for the 'some die' pattern


Using the ThemeProvider

SUMMARY

I happened to notice a few files were directly using the supersetTheme from superset-ui directly. It's better to use the theme inherited via the ThemeProvider at the top of the React apps, so that we can mutate/override/append that base supersetTheme at the provider level, and have all the react components inherit that theme properly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

(should be no visible change at this point)
TEST PLAN

@junlincc and I will poke around to make sure nothing looks out of place. And CI should pass, of course.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #11926 (6faad44) into master (41d4fb9) will decrease coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11926      +/-   ##
==========================================
- Coverage   63.83%   63.30%   -0.54%
==========================================
  Files         930      462     -468
  Lines       45124    28433   -16691
  Branches     4331        0    -4331
==========================================
- Hits        28805    17999   -10806
+ Misses      16142    10434    -5708
+ Partials      177        0     -177

Flag
Coverage Δ

javascript
?

python
63.30% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
69.95% <0.00%> (-12.45%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/databases/api.py
83.67% <0.00%> (-5.31%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 484 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41d4fb9...6faad44. Read the comment docs.


Markdown Extension: Scroll preview with editor or the reverse has been broken since lastest update.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.82.0 arm64
OS Version: macOS 13.2 22D49 arm64

Steps to Reproduce:

Ensure you have enabled "Scroll Editor With Preview"/"Scroll Preview With Editor" options in markdown extension section of settings.
Open a markdown file.
Run command 'Markdown: Open Preview to the Side'.
Scroll left/right side.

@mjbvz I downloaded the insiders and tried, it seems to be fixed in the insiders, thanks.

No bother, close it.


Add Tools to a subdomain

Tutorial on how to add tools to a subdomain and build a customize tool panel. This Pr is folowing the creation of subdomain here https://github.com/galaxyproject/training-material/pull/5552
One link will not work in this tuto as it's linked to the tuto in PR above not publish yet
Thank you all ! Looking forward to your reviews !

Hi all ! Following the recent tuto on creating a subdomain I wrote this one but I don't understand the error... Anyone ?


Updated readme to use #tool & #addin

Updated the readme to use the now avail #tool & #addin preprocessors which I think lowers the bar for testing the addin.

Thanks!


Mfs On-view-change and Microflow with context object (Retrieve events for each view) do not trigger in calendar widget

See also: https://mxforum.mendix.com/questions/9034/Mfs-Onviewchange-and-Microflow-with-context-object-Retrieve-events-for-each-view-do-not-trigger-in-calendar-widget

Adding the content of the issue:

In order to upgrade to the new version of the Calendar widget, I have downloaded the latest version in my project. After fixing the errors I got (since it is not backwards compatible), I tried to run the app. Nothing was retrieved.

However, by setting breakpoint in my On-view-change MF, I found out that this MF does not get fired at all anymore. Neither does the "Microflow with context object (Retrieve events for each view)" option. Setting a breakpoint in this microflow shows it does not get fired either. If I use this same microflow for the "Microflow with context object" option however, it does get triggered, but then the Renderview object is empty, which is also logical, given that the on-view-change does not seem to get fired.

I have created a Renderview object with the data view context object as a parent to it. I have tried both a persistent and non-persistent version of this Renderview object. Still the on-change-view microflow does not trigger.

I have also tried to fill the Reference to ViewRender entity. However, It is only possible to fill this field correctly when a the Dataview context object is the child of the RenderView object in a *-1 or a 1-1. This is not what I expected at all, I would have expected that one Dataview object can be related to multiple RenderView objects in one session. What type should the relation be?

What am I doing wrong?

What Modeler version are you using? We tried to reproduce your issue in 5.16.1, but it works here (As in, the "Microflow with context object (Retreieve events for each view)" does trigger the MF)

5.16.1
Met vriendelijke groet / Kind regards,
Drs. Yvonne Kleefkens
Directeur HERA
<EMAIL_ADDRESS><EMAIL_ADDRESS>Voorzitter & Dutch Language Advocate
ANBI Stichting Khan Academy NL http://www.khanacademy.nl/
<EMAIL_ADDRESS><EMAIL_ADDRESS>LinkedIn http://nl.linkedin.com/pub/yvonne-kleefkens/0/b47/16a
herapro.nl http://herapro.nl/
lereniseenmakkie.nl http://lereniseenmakkie.nl/
rekeneniseenmakkie.nl http://rekeneniseenmakkie.nl/ 	HERA
Hugo de Vriespark 11
6741 CM Lunteren
T +31 (0) 318 487135
M +31 (0) 650 677619
Op 29-10-2015 om 17:43 schreef Jelte Lagendijk:

What Modeler version are you using? We tried to reproduce your issue
in 5.16.1, but it works here (As in, the "Microflow with context
object (Retreieve events for each view)" does trigger the MF)
—
Reply to this email directly or view it on GitHub
https://github.com/mendix/Calendar/issues/25#issuecomment-152243704.
Geen virus gevonden in dit bericht.
Gecontroleerd door AVG - www.avg.com http://www.avg.com
Versie: 2016.0.7163 / Virusdatabase: 4457/10909 - datum van uitgifte:
10/29/15

Can you attach a small test project?
Or maybe some steps on how to reproduce this using the test project of this widget's repo?

I'll do my best, probably I am doing something wrong .... Maybe tomorrow
or Monday ...
Met vriendelijke groet / Kind regards,
Drs. Yvonne Kleefkens
Directeur HERA
<EMAIL_ADDRESS><EMAIL_ADDRESS>Voorzitter & Dutch Language Advocate
ANBI Stichting Khan Academy NL http://www.khanacademy.nl/
<EMAIL_ADDRESS><EMAIL_ADDRESS>LinkedIn http://nl.linkedin.com/pub/yvonne-kleefkens/0/b47/16a
herapro.nl http://herapro.nl/
lereniseenmakkie.nl http://lereniseenmakkie.nl/
rekeneniseenmakkie.nl http://rekeneniseenmakkie.nl/ 	HERA
Hugo de Vriespark 11
6741 CM Lunteren
T +31 (0) 318 487135
M +31 (0) 650 677619
Op 29-10-2015 om 17:47 schreef Rvthof:

Can you attach a small test project?
Or maybe some steps on how to reproduce this using the test project of
this widget's repo?
—
Reply to this email directly or view it on GitHub
https://github.com/mendix/Calendar/issues/25#issuecomment-152245168.
Geen virus gevonden in dit bericht.
Gecontroleerd door AVG - www.avg.com http://www.avg.com
Versie: 2016.0.7163 / Virusdatabase: 4457/10909 - datum van uitgifte:
10/29/15

How about you sending me your (piece of the) project that works and I
incorporate it in my app?
Met vriendelijke groet / Kind regards,
Drs. Yvonne Kleefkens
Directeur HERA
<EMAIL_ADDRESS><EMAIL_ADDRESS>Voorzitter & Dutch Language Advocate
ANBI Stichting Khan Academy NL http://www.khanacademy.nl/
<EMAIL_ADDRESS><EMAIL_ADDRESS>LinkedIn http://nl.linkedin.com/pub/yvonne-kleefkens/0/b47/16a
herapro.nl http://herapro.nl/
lereniseenmakkie.nl http://lereniseenmakkie.nl/
rekeneniseenmakkie.nl http://rekeneniseenmakkie.nl/ 	HERA
Hugo de Vriespark 11
6741 CM Lunteren
T +31 (0) 318 487135
M +31 (0) 650 677619
Op 29-10-2015 om 17:43 schreef Jelte Lagendijk:

What Modeler version are you using? We tried to reproduce your issue
in 5.16.1, but it works here (As in, the "Microflow with context
object (Retreieve events for each view)" does trigger the MF)
—
Reply to this email directly or view it on GitHub
https://github.com/mendix/Calendar/issues/25#issuecomment-152243704.
Geen virus gevonden in dit bericht.
Gecontroleerd door AVG - www.avg.com http://www.avg.com
Versie: 2016.0.7163 / Virusdatabase: 4457/10909 - datum van uitgifte:
10/29/15

We simply used the test project that is in this repo. You can download this test project by downloading the zip for the repo.

I have downloaded the testproject.
We are NOT running the same versions. The one in the appstore and this one are different, see screenshots for an example. Which I cannot add here, since I do not have write permissons and I wanted to attach a Word file. I will send them through email.

Hi Robert,
I have downloaded the testproject.
We are NOT running the same versions. The one in the appstore and this
one are different, see screenshots for an example. Which I cannot add
here, since I do not have write permissons and I wanted to attach a Word
file. I will send them through email.
See enclosed the screenshots.
I presume I should now start using this one, instead of the on in the
appstore, dated 10/7/2015?
Met vriendelijke groet / Kind regards,
Drs. Yvonne Kleefkens
Directeur HERA
<EMAIL_ADDRESS><EMAIL_ADDRESS>Voorzitter & Dutch Language Advocate
ANBI Stichting Khan Academy NL http://www.khanacademy.nl/
<EMAIL_ADDRESS><EMAIL_ADDRESS>LinkedIn http://nl.linkedin.com/pub/yvonne-kleefkens/0/b47/16a
herapro.nl http://herapro.nl/
lereniseenmakkie.nl http://lereniseenmakkie.nl/
rekeneniseenmakkie.nl http://rekeneniseenmakkie.nl/ 	HERA
Hugo de Vriespark 11
6741 CM Lunteren
T +31 (0) 318 487135
M +31 (0) 650 677619
Op 30-10-2015 om 12:38 schreef Rvthof:

We simply used the test project that is in this repo. You can download
this test project by downloading the zip for the repo.
—
Reply to this email directly or view it on GitHub
https://github.com/mendix/Calendar/issues/25#issuecomment-152501707.
Geen virus gevonden in dit bericht.
Gecontroleerd door AVG - www.avg.com http://www.avg.com
Versie: 2016.0.7163 / Virusdatabase: 4457/10915 - datum van uitgifte:
10/30/15

Screenshots

The screenshots are functionally the same. It's just that when you update an existing older Calendar widget with a new version, the attributes that were changed or added (in this case the data source type was changed) are moved to the bottom. In the case of a new widget, these are put in the order set in the xml.
You can check this in your own project by adding a new Calendar of your version to a form. It should have the same order as the one in our test project.
There is a slight difference between the two when it comes to the actual code though. This one has a time/date formatting fix that isn't on the App Store yet, as this is just a patch and we still want to fix the issue properly.

Thx, I have created a new page, but the order still remains as in my
screenshot, with the Data source tab first.
I am now using the widget from Github though. I have created a page
almost quite similar like your PaginatedDatasourceCalendar.
The RenderView does NOT get triggered... moved my page with newly
created calendar widget to the test project and there it failed also
(the only file that got moved also was the calender.mpk).
I will debug this issue further this afternoon...
Met vriendelijke groet / Kind regards,
Drs. Yvonne Kleefkens
Directeur HERA
<EMAIL_ADDRESS><EMAIL_ADDRESS>Voorzitter & Dutch Language Advocate
ANBI Stichting Khan Academy NL http://www.khanacademy.nl/
<EMAIL_ADDRESS><EMAIL_ADDRESS>LinkedIn http://nl.linkedin.com/pub/yvonne-kleefkens/0/b47/16a
herapro.nl http://herapro.nl/
lereniseenmakkie.nl http://lereniseenmakkie.nl/
rekeneniseenmakkie.nl http://rekeneniseenmakkie.nl/ 	HERA
Hugo de Vriespark 11
6741 CM Lunteren
T +31 (0) 318 487135
M +31 (0) 650 677619
Op 2-11-2015 om 11:23 schreef Rvthof:

The screenshots are functionally the same. It's just that when you
update an existing older Calendar widget with a new version, the
attributes that were changed or added (in this case the data source
type was changed) are moved to the bottom. In the case of a new
widget, these are put in the order set in the xml.
You can check this in your own project by adding a new Calendar of
your version to a form. It should have the same order as the one in
our test project.
There is a slight difference between the two when it comes to the
actual code though. This one has a time/date formatting fix that isn't
on the App Store yet, as this is just a patch and we still want to fix
the issue properly.
—
Reply to this email directly or view it on GitHub
https://github.com/mendix/Calendar/issues/25#issuecomment-152980345.
Geen virus gevonden in dit bericht.
Gecontroleerd door AVG - www.avg.com http://www.avg.com
Versie: 2016.0.7163 / Virusdatabase: 4457/10932 - datum van uitgifte:
11/01/15

Sidenote: Replying to these messages through e-mail will include you e-mail footer in the messages on Github as well... We deleted the personal info in the replies here

Thx and sorry, I will try to comment instead of reply.
Source of the problem discovered? In the previous version, the OnViewChange was triggered the very moment the user opened the page with the CalendarWidget on it. Although that was a bit annoying, we managed to both work around it and take advantage of it. Now, OnViewChange seems to trigger only when the view has actually changed.

Sadley, the test project does not contain an example with Microflow with context object (Retrieve events for each view. When I create one myself following the documentation, it does not get fired. Can you please supply me with a working example?

Could you check the updated test-project? We fixed the issue and created a new widget. Also, in the test-project we added the example


Release version 0.10.0 and 0.11.0

I noticed that thrift_client within this repository is up to version 10. Are there any plans to release the updated thrift_client?
I was also able to fork the repository and build/run tests on thrift version 0.11.0, are there any plans to move up to 11 too?

Hi there. Yes, we will be happy to release version 10 and move up to 11. Will get to it in the next week or so. Thanks for the patch :D

Great! thanks Ben. Let me know if I can help with anything, also if you need anyone to test version 11, I would be happy to do that.

Should be all set now, published to ruby gems as well. Thanks for the help!


Block Netlify CMS using robots.txt

We need to add robots.txt such that netlify CMS or the admin page doesn't get indexed by crawlers.
Where can I define robots.txt to do that?

You can refer to the Hugo Docs on robots.txt

But shouldn't we add robots.txt to block admin in this kickstarter too?


use the external qp setting for screen content

context ok, but could the commit with CI failure be removed? Thx


ENH: add data.geometry for option to link to geometry

Replaces older un-merged PR #528 (but see discussion there).
This is particularly useful for a GridProperty, so we can refer to the grid object. But it can also be used for e.g. surfaces when wanting to link e.g. a property to a depth surface, for "draping" in WebViz.
Example stubs
gridfile = edata.export(grid_object)

porofile = edata.export(poro_object, geometry=gridfile)

It will then create in the metadata:
data:
   geometry:
      name: "mygrid"
      relative_path: "some/path/to/grid.roff"

Readability of the datamodel: For someone without prior knowledge, data.geometry could potentially be understood as "the geometry of these data". Aka similar to data.spec. Perhaps it should be data.relations.geometry or similar?

Readability of the datamodel: For someone without prior knowledge, data.geometry could potentially be understood as "the geometry of these data". Aka similar to data.spec. Perhaps it should be data.relations.geometry or similar? (or possibly just relations.geometry on root level, next to data?)

Yes adding a "relations" on top level could be an option; this can possibly expand in the future, cf previous discussion. It might be that the current parent could also be added there. Let's get some input from others...

Ref relative_path - the other relative_path (file.relative_path) is relative to the case, while the geometry.relative_path is relative to the runpath. Will this cause problems? Can we imagine grid data being exported outside the realization context, e.g. as a pre- or post-process?
Do we assume that clients will implement logic that looks for both fmu.realization.uuid AND geometry.relative_path?
An option could be to abstract this into a uuid instead, e.g. geometry.uuid. Then create that uuid as a hash of file.relative_path (when running outside FMU context) and fmu.case.uuid + file.relative_path (when inside FMU context). That way, clients will establish a pattern where they relate only to the uuid and we are free to refine how that uuid is made without breaking contract with clients.

How does this geometry argument work together with the parent argument btw?
https://github.com/equinor/fmu-dataio/blob/6545af56b77b7dfed38cb1f4a5604d81e7db7c7f/src/fmu/dataio/dataio.py#L247-L248
The parent argument is only used to create the filename, but  we could use the grid metadata data.name to set the parent string to be used in the filename if the geometry argument is present 🙂 then the users don't have to specify both!
Also if possible we should deprecate this parent argument, or at least reprase the doc wording required for datatype GridProperty and make it more clear what this parent argument is used for.

I like the look of this PR, the geometry term is more familiar to users than parent (and in line with xtgeo wording 👍).  We should make sure to documnet well how to use it with an example, maybe inside the documentation for the geometry argument.
Another thought, to me this geometry only relates to gridproperties, I don't think we would like to lock an attribute surface to a surface geometry. In e.g. Webviz as a user I would like to be able to drape my attribute surfaces onto any surface with time/depth units, not just one single.

(...) the geometry term is more familiar to users than parent (and in line with xtgeo wording 👍).

In my mind, parent is different than geometry. While parent is a relationship (leaning towards data lineage, etc), geometry is more like "another piece of the same data" (-ish).

Redone in #677. Closing this


Add svelte import test

A test that checks if you can import a svelte component from another svelte file.
I hope I did the right thing that you asked for here

Awesome, this is very helpful @timmyjan46! I just commented inline.

Hey @JanGordon, just updated your PR in another PR: https://github.com/livebud/bud/pull/283.
The test contains the expected relative path behavior, so you'll find a working example in that PR. Thanks for kicking off this PR!


Fix raw device test on Mac

This disables raw device checking on non-Linux systems, so tests can pass w/o the build container.

This change is

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

pkg/libvirttools/storage_utils.go, line 75 at r1 (raw file):
Previously, jellonek (Piotr Skamruk) wrote…
... or you can use only file suffixes, so _linux.go and _darwin.go (afair then is no need to set // +build GOOS
So please forget about that _mac.go :P

I'm not 100% sure that's the best solution. See, it's necessary to extract stuff to ..._linux.go / ..._unsupported.go when it can only be built on Linux but not other systems. In this case, the code can be built just fine and it only fails on Mac because there's no proper files under /dev/.... And the performance hit is negligible...

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

pkg/libvirttools/storage_utils.go, line 75 at r1 (raw file):
Previously, ivan4th (Ivan Shvedunov) wrote…
I'm not 100% sure that's the best solution. See, it's necessary to extract stuff to ..._linux.go / ..._unsupported.go when it can only be built on Linux but not other systems. In this case, the code can be built just fine and it only fails on Mac because there's no proper files under /dev/.... And the performance hit is negligible...

Still I think that such thing should not be verified on runtime, but in compile time.
But ok, it's not so important and there is no any impact on performance (in fact, such construction could be easily handled on compile time as it's comparison of two const strings, but idk if compiler handles that).

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


Fix test results location for CI build.

Trx logger does not output test results to the same location that windows builds do.

@mmitche Hey Matt, I was wondering if you could help me with what I am missing? I am trying to get some Linux builds for CI.. and I added them here, it appears as though only the windows builds are running.
https://github.com/Microsoft/dotnet-apiport/blob/master/netci.groovy

@conniey These changes will need to be committed before they will take effect.  We can check that the CI file is okay with @dotnet-bot test ci please

@mmitche Thanks for the response! I had committed those changes in a previous merged PR #433 and wanted to use this improvement to the committed code to see if it worked.

@dotnet-bot test this please

@conniey Appears the generator hadn't rerun and so the new runs hadn't propagated from your previous change.  Fixed.

@dotnet-bot test ci please

@dotnet-bot test this please


Assertions

https://trello.com/c/P3z1xFBW/968-investigate-methods-to-prevent-access-to-document-based-on-access-limit-and-state
This replaces and supplements our previous ad-hoc 'raise' assertions with a new EditionAssertions module and a new redirect behaviour for when they happen. Please see the commits for more details.

@kevindew as discussed, we can see these logs are popping out in app.err.log without any surrounding context. We investigated this and found its due to the somewhat dubious way we setup our Rails logger accept that further work is needed to improve our app config to make these logs practical for debugging purposes.

@kevindew as discussed, we can see these logs are popping out in app.err.log without any surrounding context. We investigated this and found its due to the somewhat dubious way we setup our Rails logger accept that further work is needed to improve our app config to make these logs practical for debugging purposes.

By the way, from everything I can tell so far about logstasher won't show request info in the warn method. This is what I've seen so far: {"level":"warn","message":"a","source":"unknown","tags":["log"],"@timestamp":"2019-07-15T11:06:11.529Z","@version":"1"} so we may need to sprinkle that in, but can be a later PR


[READY]#186 add initial action generator for AEMHeadlessClient SDK

Description
Added action generator for AEM Headless Client

Related Issue

https://github.com/adobe/aem-headless-client-nodejs/issues/2
https://github.com/adobe/generator-aio-app/issues/186
Motivation and Context

How Has This Been Tested?

Unit tests
Tested with demo project for aio action using remote AEMaaCS with basic auth
Screenshots (if appropriate):

Types of changes
Added action generator for AEM Headless Client https://github.com/adobe/aem-headless-client-nodejs/issues/2

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Hi Dragan,
We are in the middle of doing extraction of some of the generators as templates, starting with extensions. This is to facilitate dynamic usage of templates/generators:

https://github.com/adobe/generator-app-excshell
https://github.com/adobe/generator-app-asset-compute

They currently reside here: https://github.com/adobe/generator-aio-app/tree/master/generators/extensions
First step we are taking on are extensions, and generator-aio-app will add the templates as dependencies for backwards compatibility. In the future, they will be pulled directly from their template source, and not from generator-aio-app.
Any future generators, including action generators, should be in a separate module because of this. You can use https://github.com/adobe/generator-app-common-lib to use the ActionGenerator base class.

Thanks, I'll check.
It makes sense, already started to be crowded for one module.


cmd/link: debug_line can contain multiple entries for the same PC address in Go 1.15.4

This is caused by https://go-review.googlesource.com/c/go/+/258422, commit 8f14c1840d15233b7f3d08f0acf0b0559d465a56.
If the body of a function immediately follows the body of another function then the PC address of the second function will have two entries in debug_line, one with the file:line of the first line of the first function and the second with the first line of the second function.
For example, compiling https://raw.githubusercontent.com/go-delve/delve/master/_fixtures/decllinetest.go on linux/arm64 (this is important) with -gcflags='-N -l' will produce the following code for main.main
decllinetest.go:7     0x9cda0                 f9400b81                MOVD 16(R28), R1
decllinetest.go:7     0x9cda4                 910003e2                MOVD RSP, R2
decllinetest.go:7     0x9cda8                 eb01005f                CMP R1, R2
decllinetest.go:7     0x9cdac                 540001e9                BLS 15(PC)
decllinetest.go:7     0x9cdb0                 f81d0ffe                MOVD.W R30, -48(RSP)
decllinetest.go:7     0x9cdb4                 f81f83fd                MOVD R29, -8(RSP)
decllinetest.go:7     0x9cdb8                 d10023fd                SUB $8, RSP, R29
decllinetest.go:8     0x9cdbc                 f90013ff                MOVD ZR, 32(RSP)
decllinetest.go:9     0x9cdc0                 b24003e0                ORR $1, ZR, R0
decllinetest.go:9     0x9cdc4                 f90013e0                MOVD R0, 32(RSP)
decllinetest.go:10    0x9cdc8                 f9000fff                MOVD ZR, 24(RSP)
decllinetest.go:11    0x9cdcc                 f94013e0                MOVD 32(RSP), R0
decllinetest.go:11    0x9cdd0                 f90007e0                MOVD R0, 8(RSP)
decllinetest.go:11    0x9cdd4                 f9000bff                MOVD ZR, 16(RSP)
decllinetest.go:11    0x9cdd8                 9400000a                CALL main.f1(SB)
decllinetest.go:12    0x9cddc                 f85f83fd                LDUR -8(RSP), R29
decllinetest.go:12    0x9cde0                 f84307fe                MOVD.P 48(RSP), R30
decllinetest.go:12    0x9cde4                 d65f03c0                RET
decllinetest.go:7     0x9cde8                 aa1e03e3                MOVD R30, R3
decllinetest.go:7     0x9cdec                 97ff321d                CALL runtime.morestack_noctxt(SB)
decllinetest.go:7     0x9cdf0                 17ffffec                JMP main.main(SB)
decllinetest.go:7     0x9cdf4                 00000000                ?
decllinetest.go:7     0x9cdf8                 00000000                ?
decllinetest.go:7     0x9cdfc                 00000000                ?

With main.f1 following immediately after at 0x9ce00. Debug_line contains the following for address 0x9ce00:
[0x00026ce9]  Special opcode 120: advance Address by 12 to 0x9cde8 and Line by -4 to 7
[0x00026cea]  Special opcode 244: advance Address by 24 to 0x9ce00 and Line by 0 to 7
[0x00026ceb]  Extended opcode 1: End of Sequence

[0x00026cee]  Extended opcode 2: set Address to 0x9ce00
[0x00026cf9]  Set File Name to entry 2 in the File Name Table
[0x00026cfb]  Advance Line by 8 to 9
[0x00026cfd]  Special opcode 9: advance Address by 0 to 0x9ce00 and Line by 5 to 14

Address 0x9cee is marked both as decllinetest.go:7 (first line of main.main) at 0x00026cea and then as decllinetest.go:14 (first line of main.f1) by 0x00026cfd.
This is a problem for Delve because it will pick the first entry in debug_line which in this case sytematically leads to a mistake. I tried changing it to always select the last entry for a given PC address but that causes problems with Go 1.14 which emitted multiple entries for each address but with the first one being the right one. I could change it to first look for the start of a sequence that matches the function entry point but that wouldn't work with older versions of Go that do not emit a sequence for each function.
The linker-side fix would be to not use putpclcdelta at the end of generateDebugLinesSymbol and instead issue a DW_LNS_const_add_pc followed by a DW_LNS_advance_line manually.
cc @thanm

Does this happen on tip? CL 258422 is a backport of a CL on tip. So if that CL is causing problem, it probably also causes problem on tip. Thanks.

I haven't looked, I'll look tomorrow but I'd be surprised if it didn't.

I'll take a look.

@gopherbot please open a backport issue for 1.15.


HIE reports garbled source code

This is really strange. Not sure if this is issue with VS Code plugin of HIE.
It looks like HIE under some conditions is working on malformed source. HIE stops working properly and reports strange parse errors for some files: source code in error message is garbled, some characters are repeated and sections are duplicated and reversed. Changing file (also emptying it and reverting previous content) does not help. Restarting HIE does not help too. Sometimes restart of VS Code helps. Source code in subject ofc is correct and compiles fine. Parse errors are reported both from ghc-mod and hlint sources of HIE.

the actual source was
type CheckoutEffs effs =
   ( LoggerEff effs
   , Member RestaurantL effs
   , Member AccountL effs
   , Member MenuL effs
   , ...

I am unable to provide reproducible steps, however it happens quite often for me. Are there any other logs I should look into?
Full log:
2018-04-27 14:36:58.567859 [ThreadId 7] - setTypecheckedModule: Didn't get typechecked module for: "[REDACTED].hs"
2018-04-27 14:36:58.568015 [ThreadId 7] - ghcDispatcher: top of loop
2018-04-27 14:36:58.568101 [ThreadId 7] - got request with id: Nothing
2018-04-27 14:36:58.568726 [ThreadId 5] - <--2--{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file://[REDACTED].hs","diagnostics":[{"severity":1,"range":{"start":{"line":59,"character":11},"end":{"line":59,"character":12}},"source":"ghcmod","message":"parse error on input ‘,’"}]}}
2018-04-27 14:36:58.573423 [ThreadId 7] - ghcDispatcher: top of loop
2018-04-27 14:36:58.573527 [ThreadId 7] - got request with id: Nothing
2018-04-27 14:36:58.573967 [ThreadId 7] - ghcDispatcher: top of loop
2018-04-27 14:36:58.574173 [ThreadId 7] - got request with id: Nothing
2018-04-27 14:36:58.574251 [ThreadId 7] - Processing request as version matches
2018-04-27 14:36:58.698242 [ThreadId 7] - ghcDispatcher: top of loop
2018-04-27 14:36:58.698399 [ThreadId 7] - got request with id: Nothing
2018-04-27 14:36:58.6985 [ThreadId 7] - Processing request as version matches
2018-04-27 14:36:58.703254 [ThreadId 5] - <--2--{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file://[REDACTED].hs","diagnostics":[{"severity":1,"range":{"start":{"line":59,"character":11},"end":{"line":59,"character":12}},"source":"ghcmod","message":"parse error on input ‘,’"},{"severity":3,"range":{"start":{"line":59,"character":11},"end":{"line":59,"character":100000}},"code":"parser","source":"hlint","message":"Parse error: ,\n  type CheckoutEffs effs ==\n     ( LoggerEff effssssffffffeee   ffffffEEErrreeeggggggoooLLL      \n>       ,    ,,,   ember RestaurantL effs\n     , Member AccountL effs\n     , Member MenuL effs\n\n"}]}}
2018-04-27 14:36:58.703698 [ThreadId 4] - ---> {"jsonrpc":"2.0","id":143,"method":"textDocument/codeAction","params":{"textDocument":{"uri":"file://[REDACTED].hs"},"range":{"start":{"line":27,"character":73},"end":{"line":27,"character":73}},"context":{"diagnostics":[]}}}
2018-04-27 14:36:58.7043 [ThreadId 8] - reactor:got CodeActionRequest:RequestMessage {_jsonrpc = "2.0", _id = IdInt 143, _method = TextDocumentCodeAction, _params = CodeActionParams {_textDocument = TextDocumentIdentifier {_uri = Uri {getUri = "file://[REDACTED].hs"}}, _range = Range {_start = Position {_line = 27, _character = 73}, _end = Position {_line = 27, _character = 73}}, _context = CodeActionContext {_diagnostics = List []}}}
2018-04-27 14:36:58.704609 [ThreadId 5] - <--2--{"result":[],"jsonrpc":"2.0","id":143}
2018-04-27 14:36:58.837856 [ThreadId 4] - ---> {"jsonrpc":"2.0","id":144,"method":"textDocument/codeAction","params":{"textDocument":{"uri":"file://[REDACTED].hs"},"range":{"start":{"line":27,"character":73},"end":{"line":27,"character":73}},"context":{"diagnostics":[]}}}
2018-04-27 14:36:58.83814 [ThreadId 8] - reactor:got CodeActionRequest:RequestMessage {_jsonrpc = "2.0", _id = IdInt 144, _method = TextDocumentCodeAction, _params = CodeActionParams {_textDocument = TextDocumentIdentifier {_uri = Uri {getUri = "file://[REDACTED].hs"}}, _range = Range {_start = Position {_line = 27, _character = 73}, _end = Position {_line = 27, _character = 73}}, _context = CodeActionContext {_diagnostics = List []}}}
2018-04-27 14:36:58.838558 [ThreadId 5] - <--2--{"result":[],"jsonrpc":"2.0","id":144}
2018-04-27 14:37:02.120167 [ThreadId 7] - setTypecheckedModule: Didn't get typechecked module for: "[REDACTED].hs"
2018-04-27 14:37:02.120338 [ThreadId 7] - ghcDispatcher: top of loop
2018-04-27 14:37:02.120601 [ThreadId 5] - <--2--{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file://[REDACTED].hs","diagnostics":[{"severity":1,"range":{"start":{"line":59,"character":11},"end":{"line":59,"character":12}},"source":"ghcmod","message":"parse error on input ‘,’"}]}}
2018-04-27 14:37:02.252693 [ThreadId 4] - ---> {"jsonrpc":"2.0","id":145,"method":"textDocument/codeAction","params":{"textDocument":{"uri":"file://[REDACTED].hs"},"range":{"start":{"line":27,"character":73},"end":{"line":27,"character":73}},"context":{"diagnostics":[]}}}
2018-04-27 14:37:02.252957 [ThreadId 8] - reactor:got CodeActionRequest:RequestMessage {_jsonrpc = "2.0", _id = IdInt 145, _method = TextDocumentCodeAction, _params = CodeActionParams {_textDocument = TextDocumentIdentifier {_uri = Uri {getUri = "file://[REDACTED].hs"}}, _range = Range {_start = Position {_line = 27, _character = 73}, _end = Position {_line = 27, _character = 73}}, _context = CodeActionContext {_diagnostics = List []}}}
2018-04-27 14:37:02.253226 [ThreadId 5] - <--2--{"result":[],"jsonrpc":"2.0","id":145}

And the log does not show the problem itself, which will be in prior DidChange message.
But I think I have a usable log locally too.

And this is a fragment of log from my incident observed in the wild
2018-04-20 10:35:44.606412 [ThreadId 4] - ---> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"[Redacted]","version":13},"contentChanges":[{"range":{"start":{"line":13,"character":25},"end":{"line":13,"character":25}},"rangeLength":0,"text":"x"}]}}
2018-04-20 10:35:44.606831 [ThreadId 4] - ---> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"[Redacted]","version":13},"contentChanges":[{"range":{"start":{"line":13,"character":25},"end":{"line":13,"character":25}},"rangeLength":0,"text":"x"}]}}
2018-04-20 10:35:44.607123 [ThreadId 4] - ---> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"[Redacted]","version":13},"contentChanges":[{"range":{"start":{"line":13,"character":25},"end":{"line":13,"character":25}},"rangeLength":0,"text":"x"}]}}
2018-04-20 10:35:44.6073 [ThreadId 4] - ---> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"[Redacted]","version":13},"contentChanges":[{"range":{"start":{"line":13,"character":25},"end":{"line":13,"character":25}},"rangeLength":0,"text":"x"}]}}
2018-04-20 10:35:44.6075 [ThreadId 4] - ---> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"[Redacted]","version":13},"contentChanges":[{"range":{"start":{"line":13,"character":25},"end":{"line":13,"character":25}},"rangeLength":0,"text":"x"}]}}
2018-04-20 10:35:44.607674 [ThreadId 4] - ---> {"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"[Redacted]","version":13},"contentChanges":[{"range":{"start":{"line":13,"character":25},"end":{"line":13,"character":25}},"rangeLength":0,"text":"x"}]}}

The user is typing the x of the word Text, and it is coming through multiple times.
And I suspect that either the machine is heavily loaded. and gnome is sending repeat chars (which is something I have seen recently on my machine), or there is a bug in vscode.
@kfigiela, what operating system/distribution did you see this on?

And I just realised that the input in vscode is not garbled, so it is not extra UI events being injected by gnome etc.

Could the duplicate didChange events be related to #531?

@alanz I am using macOS (10.13.4).

I think this problem has gone away?  Can I close it?


Fix/Vue3 landmark WCAG fixes

What this does
Add some fixes for current WCAG issues on the Home (landing), Login, and Signup pages:

Update the html lang attribute to contain a value (en) in index.html

Axe Dev tools WCAG Issue Description: Ensures every HTML document has a lang attribute

Adds fixes for landmark tags in the Vue3 app HTML structure.

Axe Dev tools WCAG Issue Description 1: Ensures the document has a main landmark
Axe Dev tools WCAG Issue Description 2: Ensures all page content is contained by landmarks

Checklist

[x] Update the <html> tag for the Vue3 index.html file to be <html lang="en">
[x] Add a <main> tag for the main content to be display on the page
[x] Add a <nav> tag for the navigation content + links to be displayed at the top of the screen

How to test
If you have the axe dev tools extension in Chrome, you can use them to scan the page and verify that Home, Login, and Sign Up pages do not contain issues related to WCAG guidelines.

For reference, the above fixes will now structure the DOM for the Vue3 side to look as follows:
(Note: the green underlines are to help indicate the main changes with this PR)


Attempting to analyse old-style CSProject file - Method initialize in type PipeLogger does not have an implementation

Hi!
I've been trying to use Buildalyzer to analyse CSProject files for compliance to guidelines with the framework I'm working in. This works well for netstandard2.0 and net5.0 CSProject files, but when trying to analyse older-style CSProject files for net452 and net472, I get the following error:
System.TypeLoadException: Method 'Initialize' in type 'MsBuildPipeLogger.PipeLogger' from assembly 'MsBuildPipeLogger.Logger, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
   at Buildalyzer.ProjectAnalyzer.GetCommand(BuildEnvironment buildEnvironment, String targetFramework, String[] targetsToBuild, String pipeLoggerClientHandle, String& arguments)
   at Buildalyzer.ProjectAnalyzer.BuildTargets(BuildEnvironment buildEnvironment, String targetFramework, String[] targetsToBuild, AnalyzerResults results)
   at Buildalyzer.ProjectAnalyzer.Build(String targetFramework, BuildEnvironment buildEnvironment)
   at BH.Adapter.CSProject.CSProjectAdapter.IRead(Type type, IList indices, ActionConfig actionConfig)

I have tried to set up a custom ILoggerFactory to just ignore this (as I generally am not caring too much for the reports of the logging at this stage) but this didn't work.
I have also tried it with ensuring that the EnvironmentOptions.Preference is set to Framework rather than Core but the same error occurs.
The code I currently have for this is as follows:
ILoggerFactory factory = LoggerFactory.Create(builder => builder.AddConsole());
StringWriter log = new StringWriter();

AnalyzerManagerOptions opt = new AnalyzerManagerOptions() { LoggerFactory = factory, LogWriter = log };
AnalyzerManager analyzerManager = new AnalyzerManager(opt);
ProjectAnalyzer projectAnalyzer = analyzerManager.GetProject(m_fileSettings.GetFullFileName()) as ProjectAnalyzer;

ProjectFile projectFile = new ProjectFile();
projectFile.TargetNETVersions = projectAnalyzer.ProjectFile.TargetFrameworks.ToList();
projectFile.OutputPaths = ExtractOutputPaths();

try //Code in a try-catch simply to catch the initialize error for old-style csproj files and avoid the app crashing completely
{
    EnvironmentOptions options = new EnvironmentOptions();
    options.DesignTime = true;
    /*options.Preference = EnvironmentPreference.Core; //This if-block wasn't working to fix the problem so currently commented out but included in this snippet in case anyone can point out how I'm using it badly!
    if (!projectFile.TargetNETVersions.Contains("netstandard2.0"))
        options.Preference = EnvironmentPreference.Framework;*/

    AnalyzerResult result = (projectAnalyzer.Build(options) as AnalyzerResults).First() as AnalyzerResult;

    var refs = result.Items.Where(x => x.Key == "Reference").FirstOrDefault();
    if(refs.Value != null) //If the refs.value is null then it means there was no references in the csproject file
        projectFile.References = Convert.ToAssemblyReference(refs.Value.ToList());

    projectFile.TargetNETVersions = projectAnalyzer.ProjectFile.TargetFrameworks.ToList();
}
catch(Exception e)
{
    projectFile.AnalysisErrors = e.ToString();
}

Any help with this will be gratefully received! Thanks in advance :smile:

Interesting, I haven't seen this particular error before. It's almost like your app has a reference to MsBuildPipeLogger but the logger isn't being loaded into your assembly context. What happens if you add a direct reference to https://www.nuget.org/packages/MsBuildPipeLogger.Logger/? I'm also wondering if there's a version mismatch - what's your full set of referenced packages in the app that's using Buildalyzer (not the app being analyzed)?

Hiya, so I appeared to have a MsBuildPipeLogger.Logger.dll file in my build folder, I'm presuming that comes in via one of the dependencies to Buildalyzer itself, but have added MsBuildPipeLogger.Logger and copied all DLLs I can find to the execution folder but still the same error.
For the app using Buildalyzer I have the following packages installed now:

NetStandard.Library v2.0.3
Buildalyzer v3.2.3
MsBuildPipeLogger.Logger v1.1.3 (just installed)

There are then DLL dependencies to the parts of BHoM the project is building on top of too.
I have also found that if I try to run the analyser on a .NetFramework472 project file (which throws the above error) and then try to run it on a .netstandard20 project file, the second attempt throws the same error still. However, if I boot cleanly and run the .netstandard20 project file first, then it works.
I did also try building both the Buildalyzer and MsBuildPipeLogger projects from source just to debug through and make sure I was using the absolutely latest up to date versions of the code though that did not yield any positive results.


tests:Re-enable DS attachment for TriTest

Three cases were disabling DS attachment to accomodate a driver bug,
but this is actually invalid for the tests.
Re-enabling the DS attachment for those cases as with device updates
and other workarounds, the tests are now working across all devices.

@krOoze FYI this is working now

@tobine yay


k.velocity is not a function

ERROR TypeError: k.velocity is not a function
at h (materialize.js:3)
at HTMLDivElement. (materialize.js:3)
at HTMLDivElement.dispatch (jquery.js:4737)
at HTMLDivElement.elemData.handle (jquery.js:4549)
at Object.trigger (jquery.js:7807)
at HTMLDivElement. (jquery.js:7875)
at Function.each (jquery.js:365)
at jQuery.fn.init.each (jquery.js:137)
at jQuery.fn.init.trigger (jquery.js:7874)
at jQuery.fn.init.open (materialize.js:3)
at jQuery.fn.init.a.fn.modal (materialize.js:3)
at HTMLDocument. (materialize-directive.js:185)
at fire (jquery.js:3187)
at Object.add [as done] (jquery.js:3246)
at jQuery.fn.init.jQuery.fn.ready (jquery.js:3496)
View_OperationalComponent_1 @ OperationalComponent.html:6
DebugContext_.logError @ core.es5.js:13000
ErrorHandler.handleError @ core.es5.js:1145
next @ core.es5.js:4774
schedulerFn @ core.es5.js:3848
SafeSubscriber.__tryOrUnsub @ Subscriber.js:234
SafeSubscriber.next @ Subscriber.js:183
Subscriber._next @ Subscriber.js:125
Subscriber.next @ Subscriber.js:89
Subject.next @ Subject.js:55
EventEmitter.emit @ core.es5.js:3834
NgZone.triggerError @ core.es5.js:4205
onHandleError @ core.es5.js:4166
ZoneDelegate.handleError @ zone.js:369
Zone.runTask @ zone.js:168
ZoneTask.invoke @ zone.js:460
ERROR CONTEXT DebugContext_ {view: Object, nodeIndex: 13, nodeDef: Object, elDef: Object, elView: Object}
I am using Angular2 Cognito Quickstart with Materializecss. I am trying to open modal but I  am facing the above issue. I have tried many issue related to this but many solutions includes webpack plugin addition or defining externals in webpack.config.js. I don't contain webpack.config.js file in my folder structure created by this quickstart.
Please help.

Try to add in app.component constructor next line:
(window).$ = (window).jQuery;
Maybe it will help you.

In addition to what @n0mid said, please make sure you've followed the instructions for adding angular2-materialize to the Angular CLI.

Should be good in the latest release of angular2-materialize, following the CLI instructions

@rubyboy well, it looks like it's not good yet. I followed the guide but I'm still getting the same error.
Any help will be appreciated

@guibot17 share a repo and someone may be able to help. With the CLI it's very important to make sure you've made all changes to the angular-cli.json properly

@rubyboy this is what I have:
package.json:
"dependencies": {
"@angular/animations": "^4.2.2",
"@angular/common": "^4.2.2",
"@angular/compiler": "^4.2.2",
"@angular/compiler-cli": "^4.2.2",
"@angular/core": "^4.2.2",
"@angular/forms": "^4.2.2",
"@angular/http": "^4.2.2",
"@angular/material": "^2.0.0-beta.6",
"@angular/platform-browser": "^4.2.2",
"@angular/platform-browser-dynamic": "^4.2.2",
"@angular/platform-server": "^4.2.2",
"@angular/router": "^4.2.2",
"angular-in-memory-web-api": "^0.3.2",
"angular2-materialize": "^15.0.4",
"angularfire2": "^4.0.0-rc.1",
"core-js": "^2.4.1",
"firebase": "^4.1.2",
"hammerjs": "^2.0.8",
"jquery": "^2.2.4",
"materialize-css": "^0.98.2",
"rxjs": "^5.1.0",
"typescript": "^2.3.4",
"zone.js": "^0.8.4"
},
"devDependencies": {
"@angular/cli": "1.1.1",
"@angular/compiler-cli": "^4.0.0",
"@angular/language-service": "^4.0.0",
"@types/jasmine": "2.5.45",
"@types/node": "~6.0.60",
"codelyzer": "~3.0.1",
"jasmine-core": "~2.6.2",
"jasmine-spec-reporter": "~4.1.0",
"karma": "~1.7.0",
"karma-chrome-launcher": "~2.1.1",
"karma-cli": "~1.0.1",
"karma-coverage-istanbul-reporter": "^1.2.1",
"karma-jasmine": "~1.1.0",
"karma-jasmine-html-reporter": "^0.2.2",
"node-sass": "^4.5.3",
"protractor": "~5.1.2",
"raw-loader": "^0.5.1",
"sass-loader": "^6.0.6",
"ts-node": "~3.0.4",
"tslint": "~5.3.2",
"typescript": "~2.3.3"
}
angular-cli:
"styles": [
"../node_modules/materialize-css/dist/css/materialize.css",
"styles.sass",
"_theme.sass"
],
"scripts": [
"../node_modules/hammerjs/hammer.js",
"../node_modules/jquery/dist/jquery.js",
"../node_modules/materialize-css/dist/js/materialize.js"
]
app.module:
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { ReactiveFormsModule, FormsModule } from '@angular/forms';
import { HttpModule } from '@angular/http';
import { MaterialModule } from '@angular/material';
import { AngularFireModule } from 'angularfire2';
import { AngularFireDatabaseModule } from 'angularfire2/database';
import { AngularFireAuthModule, AngularFireAuth } from 'angularfire2/auth';
import { environment } from '../environments/environment';
import 'hammerjs';
import 'materialize-css';
import { MaterializeModule } from 'angular2-materialize';
import { AppRoutingModule }     from './app-routing.module';
import { AppComponent } from './app.component';
import { HomeComponent } from './home/home.component';
import { HeaderComponent } from './header/header.component';
import { FooterComponent } from './footer/footer.component';
import { AuthService } from './auth/auth.service';
import { UserService } from './auth/user.service';
@NgModule({
declarations: [
AppComponent,
HomeComponent,
HeaderComponent,
FooterComponent
],
imports: [
BrowserModule,
BrowserAnimationsModule,
ReactiveFormsModule,
FormsModule,
HttpModule,
MaterialModule,
AngularFireModule.initializeApp(environment.firebase, 'bzh-header'),
AngularFireDatabaseModule,
AngularFireAuthModule,
AppRoutingModule,
MaterializeModule
],
providers: [
AuthService,
UserService
],
bootstrap: [AppComponent]
})
export class AppModule { }
As you may see, I'm using Angular 4.2.2 along with materialize-css 0.98.2, jquery ^2.2.4, hammer.js ^2.0.8.
I'm facing this issue when trying to open a modal.
Your help is greatly appreciated.

Still not resolved. @rubyboy . Any update @guibot17 ?

Hello, I am using angular2 with webpack and I am trying to open a modal but getting an below error:
ERROR TypeError: k.velocity is not a function     at h (materialize.js:3)     at HTMLDivElement.<anonymous> (materialize.js:3)     at HTMLDivElement.dispatch (jquery.js:4737)     at HTMLDivElement.elemData.handle (jquery.js:4549)     at Object.trigger (jquery.js:7807)     at HTMLDivElement.<anonymous> (jquery.js:7875)     at Function.each (jquery.js:365)     at jQuery.fn.init.each (jquery.js:137)     at jQuery.fn.init.trigger (jquery.js:7874)     at jQuery.fn.init.open (materialize.js:3)     at jQuery.fn.init.a.fn.modal (materialize.js:3)     at HTMLDocument.<anonymous> (materialize-directive.js:213)     at fire (jquery.js:3187)     at Object.add [as done] (jquery.js:3246)     at jQuery.fn.init.jQuery.fn.ready (jquery.js:3496)
I tried all the solutions mentioned above but nothing worked for me. Can anyone share the webpack.conf.js and list the settings which perfectly worked.
Its urgent, please help. Thanks in advance.

@akashbiz , yes! It was due to the fact that I was importing materialze-css in my app.module.ts as such:
import "materialize-css"
import { MaterializeModule } from 'angular2-materialize'
You may just remove it because it's not needed in this case; leave the'angular2-materialize' import:
import { MaterializeModule } from 'angular2-materialize'
I hope this helps.
#256

Hey Thanks a lot @guibot17 , It solved my issue.

@guibot17 @rubyboy @akashbiz
I tried your solution to remove import statement import "materialize-css". It does not work for me.
Also I followed the instruction provided on link angular2-materialize.
I tried both ways given on link but nothing works for me.

Installing and configuring angular2-materialize with webpack
Installing & configuring angular2-materialize in projects created with the Angular CLI

Following are some details for 2nd option and I get error like:
ERROR TypeError: k.velocity is not a function
at h (materialize.js:3)
at HTMLDivElement. (materialize.js:3)
at HTMLDivElement.dispatch (jquery.js:4737)
at HTMLDivElement.elemData.handle (jquery.js:4549)
at Object.trigger (jquery.js:7807)
at HTMLDivElement. (jquery.js:7875)
at Function.each (jquery.js:365)
at jQuery.fn.init.each (jquery.js:137)
at jQuery.fn.init.trigger (jquery.js:7874)
at jQuery.fn.init.open (materialize.js:3)
at jQuery.fn.init.a.fn.modal (materialize.js:3)
at HTMLDocument. (materialize-directive.js:185)
at fire (jquery.js:3187)
at Object.add [as done] (jquery.js:3246)
at jQuery.fn.init.jQuery.fn.ready (jquery.js:3496)
Following is my configuration in files:
for angular-cli.json
"styles": [
"../node_modules/materialize-css/dist/css/materialize.css",
"styles.css"
],
"scripts": [
"../node_modules/jquery/dist/jquery.js",
"../node_modules/hammerjs/hammer.js",
"../node_modules/materialize-css/dist/js/materialize.js"
],
for app.module.ts - Added import statement
import { MaterializeModule } from 'angular2-materialize';
Please help.
Thanks in advance.

@SPradnya
If I understand correctly, you tried the following:
1. Project created by Angular-CLI:
app.module.ts file
import { MaterializeModule } from "angular2-materialize";
@NgModule({
imports: [
//...
MaterializeModule,
],
//...
})
Along with the settings that you posted for the angular-cli.json
2. Project configured with webpack:
app.module.ts file
import 'materialize-css';
import { MaterializeModule } from "angular2-materialize";
@NgModule({
imports: [
//...
MaterializeModule,
],
//...
})
index.html file
<head>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/materialize/0.98.2/css/materialize.min.css">
</head>
And in your webpack config file:
const ProvidePlugin = require('webpack/lib/ProvidePlugin');
module.exports = {
//...
plugins: [
new ProvidePlugin({
"window.jQuery": "jquery",
Hammer: "hammerjs/hammer"
})
]
//...
};
Please confirm.
Thanks

@guibot17
Yes. Done the same thing.


Spring 4.3 support

Spring is officially supported in 2.0: documentation is added, automated tests are added to the existing suites.
Note that as Spring makes heavy use of static contexts, it is recommended to share class loaders between job instances. (this feature already exists in 1.4).

Note: this should focus on bootstrapping easily the Spring context. A test project was provided by the customer and should be integrated in the test suite.


Really dispose OutgoingBoundary

Fixes #3007

While debugging #3007, I discovered that the newly-added worker crashed about 5 seconds after restarted.  That corresponded exactly to the reconnect time by OutgoingBoundary actors that should've been halted: they had buffered un-acked items and resent those items, including old barrier tokens, when it reconnected.


Tracy profiling in pipelined-rendering

This has already been reviewed and merged into main but we need it on pipelined-rendering too for awesome profiling tools!
Tracy is:

A real time, nanosecond resolution, remote telemetry, hybrid frame and sampling profiler for games and other applications.

With the trace_tracy feature enabled, you run your bevy app and either a headless server (capture) or a live, interactive profiler UI (Tracy), and connect that to your bevy application to then stream the metric data and events, and save it or inspect it live/offline.
Previously when I implemented the spans across systems and stages and I was trying out different profiling tools, Tracy was too unstable on macOS to use. But now, quite some months later, it is working stably with Tracy 0.7.8. You can see timelines, aggregate statistics of mean system/stage execution times, and much more. It's very useful!

Use the tracing-tracy crate which supports our tracing spans
Expose via the non-default feature trace_tracy for consistency with other trace* features

Objective

Describe the objective or issue this PR addresses.
If you're fixing a specific issue, say "Fixes #X".

Solution

Describe the solution used to achieve the objective above.

Is this not going to cause a problem when we land pipelined-rendering, since this would conflict with the same commit
I think the correct thing to do is to rebase pipelined-rendering onto main?

Sadly rebases aren't an option for pipelined-rendering because our oldest commits are not compatible with the latest commits. The only option at this point (if we want to preserve history) is a merge commit. I don't think a duplicate commit is the worst thing in the world in this context, but it should be avoided if possible.
Given that this already exists on main, I think the best solution is probably to not merge here and just merge pipelined-rendering into main asap.

Fine by me. Closing.


❓ [Question] How do you debug errors in the compilation step?

❓ Question
Hello all,
After training a model, I decided to use torch_tensorrt to test and hopefully increase inference speed. When compiling the custom model, I get the following error: RuntimeError: Trying to create tensor with negative dimension -1: [-1, 3, 600, 400]. This did not occur when doing inference in regular PyTorch. Further the following warning was issued (before receiving the error):
The compiler is going to use the user setting Float16
This conflict may cause an error at runtime due to partial compilation being enabled and therefore
compatibility with PyTorch's data type convention is required.
If you do indeed see errors at runtime either:
- Remove the dtype spec for x.1
- Disable partial compilation by setting require_full_compilation to True```

The code to compile is as follows:
```inputs = [torch_tensorrt.Input(
            min_shape=[2, 3, 600, 400],
            opt_shape=[4, 3, 600, 400],
            max_shape=[8, 3, 600, 400],
            dtype=torch.half,
        )]
enabled_precisions = {torch.float, torch.half}
trt_ts_module = torch_tensorrt.compile(model, inputs=inputs, enabled_precisions=enabled_precisions)

My question is: what can I do to properly debug this error?
What you have already tried

Use mobilenet_v2, as specified in the example https://pytorch.org/TensorRT/tutorials/use_from_pytorch.html#use-from-pytorch. This model compiles successfully.
Change the input size (change the batch size, i.e. the first dimension, use shapes of >= 100). This gave the same error.
Set require_full_compilation to True, which was not fruitful either.

Environment

PyTorch Version (e.g., 1.0): 1.11.0+cu113
Torch-TensorRT version: 1.1.0
CPU Architecture: x86_64
OS (e.g., Linux): Ubuntu 20.04 (kernel: 5.4.0-122-generic)
How you installed PyTorch (conda, pip, libtorch, source): pip, from within a virtual environment (pyenv)
Are you using local sources or building from archives:
Python version: 3.8.13
CUDA version: 11.4.4 (Driver: 470.82.01)
GPU models and configuration: Nvidia RTX A2000
Any other relevant information: TensorRT has been installed via pip, to install torch_tensorrt (and getting it to import in Python), I followed the answer in the following issue: https://github.com/pytorch/TensorRT/issues/1026#issuecomment-1119561746

Looking forwards to your answer, thanks in advance.

This error is due to trying to use dynamic shape with partial compilation enabled. Currently there is a limitation in Torch-TensorRT where you cannot use these features together. For further debugging usually the first thing I do is enable the debug logs:

inputs = [torch_tensorrt.Input(
            min_shape=[2, 3, 600, 400],
            opt_shape=[4, 3, 600, 400],
            max_shape=[8, 3, 600, 400],
            dtype=torch.half,
        )]
enabled_precisions = {torch.float, torch.half}

with torch_tensorrt.logging.debug():
    trt_ts_module = torch_tensorrt.compile(model, inputs=inputs, enabled_precisions=enabled_precisions)

This gives you more information about the internal state of the compiler including what symbols have already been parsed and translated


Support dragging menu open from anywhere

Still a WIP!!
Rogue event.preventDefault()'s were the cause of the scrolling fail, but it also needs some interesting checks to make it so it only ever scrolls OR drags open... not both at the same time.

This pull request is now managed with CodeReviewHub. Refresh.

Giving up on this till I have a think about how it could be done right...


how to code splitting and dynamic require

Hi there!
I'm really interested in using webpack for one of my projects where I'm working with require.js right now.
Currently I have this Single Page Application where I render the first page in the server and then there is client side navigation. I have a commons.js bundle where I put vendor code and all the common custom components written in-house, and I have a bundle for every page in my application.
When I move from one page to another (client-side navigation), I request this new page to the server. The info of this new page holds the name of the JS bundle I need to load for it. So my router component requires that bundle.
I've been reading the code splitting docs this weekend and also checking the demo app but I can't figure out the way I need to set this up.
This was my best shot:
var path = require('path'),
	webpack = require('webpack'),
	CommonsChunkPlugin = require('webpack/lib/optimize/CommonsChunkPlugin');

module.exports = {
	context: process.cwd() + '/public',
	entry: {
		shared: ['jquery', 'dustjs', 'dustjs-helpers', 'pagejs', 'handlebars',
			'./js/main.js',
			'./js/controllers/mini-cart-controller.js',
			'./js/controllers/main-navigation-controller.js'],
		home: './js/controllers/home-controller',
		category: './js/controllers/category-controller',
		product: './js/controllers/product-detail-controller',
		shopCart: './js/controllers/shop-cart-controller'
	},

	output: {
		path: './public/js/dist',
		filename: "[name].entry.chunk.js"
	},

	resolve: {
		root: [
			path.resolve('public'),
			path.resolve('public/js'),
			path.resolve('public/vendor'),
		],
		modulesDirectories: [
			'vendor'
		],
		alias: {
			jquery: process.cwd() + '/public/vendor/jquery/dist/jquery.js',
			'dustjs-linkedin': process.cwd() + '/public/vendor/dustjs-linkedin/lib/dust.js',
			'dustjs-helpers': process.cwd() + '/public/vendor/dustjs-linkedin-helpers/lib/dust-helpers.js',
			pagejs: process.cwd() + '/public/vendor/page.js/page.js'
		}
	},

	module: {
		loaders: [
			{ test: /\.css$/, loader: 'style!css' }
		]
	},

	plugins: [
		new CommonsChunkPlugin({
			name: 'shared',
			filename: 'shared.js',
			minChunks: Infinity
		})
	]
};

I don't get how to use the require.ensure thing and how webpack can create the different bundles.
Could anybody help?
Thanks.

What does the code where you're using require.ensure look like?
In your app's code, if you:
require(['./a-script-loaded-async.js'], function (myAsyncScript) {
  console.log(myAsyncScript)
})

It will generate a separate chunk for the file ./a-script-loaded-async.js and any of it's dependent modules.


Verify that "Deleni-Obârșie" is listed in the dropdown menu when searched

Description:
"Deleni-Obârșie" should appear in the dropdown menu with correct spelling and locality information.
Preconditions:
The website is up and running.

Step 1
Type "Deleni-Obârșie" in the search bar.
Expected results:
The dropdown is listing "Deleni-Obârșie" as the first location in the dropdown menu.

Step 2
Observe the dropdown menu.
Expected results:
"Deleni-Obârșie" is displayed and selectable from the dropdown menu.


Panic when generating serviceuser:v1

2017/02/10 12:41:21 Generating API serviceuser:v1
panic: Clash on name Service

See google-api-go-generator/gen.go:1050.
Seems there's a public field also named Service...

@zombiezen, as you'll see, this panic is explicit in the code, not the result of some bug. I'm not sure how to handle it.

Renaming the top-level Service is not an option, in my opinion, as it would potentially break all users of this library of APIs.
It might be possible to patch the serviceuser:v1 API and rename their Service struct.
I'm leaning toward temporarily black-listing the serviceuser:v1 API in order to update the other APIs.

Created https://code-review.googlesource.com/#/c/11171/ as recommended by @broady.

Yes, sorry, missed this bug.
Renaming the struct is the correct thing to do.

Fixed in https://github.com/google/google-api-go-client/commit/64485db7e8c8be51e572801d06cdbcfadd3546c1
Thank you, @broady!


[Event Request] table 246 "Requisition Line" - Event for trigger OnLookup Field "Vendor No."

Can we get the following event for the "Requisition Line" table: OnVendorNoOnBeforeLookup
trigger OnLookup()
            var
                Vend: Record Vendor;
            begin
                ///
                IsHandled := false; ///NEW
                OnVendorNoOnBeforeLookup(Rec, IsHandled); ///NEW
                if not IsHandled then ///NEW
                    exit; ///NEW
                ///-
                if LookupVendor(Vend, true) then
                    Validate("Vendor No.", Vend."No.");
            end;

    [IntegrationEvent(false, false)]
    local procedure OnVendorNoOnBeforeLookup(var Rec: Record "Requisition Line"; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


ako/ update main to master

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.564%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
5639

Relevant Lines:
6131

💛  - Coveralls


Grant read permissions to CRD for authenticated users in the virtual cluster

How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
This PR grants list, watch and get permissions to custom resource definitions in the virtual cluster for any authenticated user. This way, shoot owners can use kube-state-metrics with custom resource state configurations to generate their own shoot metrics. These permissions are required by kube-state-metrics even though shoots are part of the aggregation layer and do not have a custom resource definition (see here).
Shoot owners will need to provide the --namespaces flag when running kube-state-metrics to avoid trying to access namespaces that are forbidden for them. Otherwise kube-state-metrics won't produce metrics and will log errors.
During the preparation of this PR, we found a bug in kube-state-metrics worth mentioning. Metrics from custom resources defined in the aggregation layer are only generated if at least a custom resource definition exists in the virtual cluster. Therefore, this feature might not work out of the box for Gardener installations where the virtual cluster has no custom resource definitions (e.g., the local setup). An issue to kube-state-metrics will follow up.
Special notes for your reviewer:
/cc @istvanballok @chrkl @petersutter @rfranzke
Release note:
Grant get, list and watch permissions to the `customresourcedefinitions` resource in the virtual cluster for authenticated users. Shoot owners can now generate their own shoot metrics using custom resource state configurations by kube-state-metrics.

@vicwicker The Shoot API is not backed by a CustomResourceDefinition. Can you explain how this works/why the permissions are relevant then?
@ialidzhikov @vpnachev @petersutter @vlerenc Any concerns allowing all authenticated users to read CRDs in the garden cluster?

I think we have been asked multiple times so far to grant these permissions (e.g. terraform provider) and we never got a justified answer why such tools really need to read a CRD, especially when there is no such CRD for shoots.

kube-state-metrics supports wildcard matching for the version and kind fields in the custom resource state configuration (link). For this feature, they need to watch the CRDs. We agree that we don't need this feature to expose metrics about the shoots at all but unfortunately kube-state-metrics doesn't start with a custom resource state config if it can't list CRDs (link).

Example of kube-state-metrics failing to start
Given a dummy custom resource state configuration to expose metrics about a shoot:
kind: CustomResourceStateMetrics
spec:
  resources:
    - groupVersionKind:
        group: core.gardener.cloud
        kind: Shoot
        version: v1beta1
      labelsFromPath:
        name: [metadata, name]
      metrics:
        - name: observedgeneration
          help: "Observed Generation"
          each:
            type: Gauge
            gauge:
              path: [status, observedGeneration]

Fails when using the kubeconfig from a service account.
$ go run . --custom-resource-state-config-file crs.yaml --custom-resource-state-only --kubeconfig ~/Downloads/kubeconfig.yaml
I0809 15:23:31.664522   56596 wrapper.go:120] "Starting kube-state-metrics"
I0809 15:23:31.672643   56596 server.go:215] "Used CRD resources only"
I0809 15:23:31.672910   56596 types.go:227] "Using all namespaces"
I0809 15:23:31.672988   56596 types.go:145] "Using node type is nil"
I0809 15:23:31.673365   56596 server.go:245] "Metric allow-denylisting" allowDenyStatus="Excluding the following lists that were on denylist: "
I0809 15:23:31.679744   56596 utils.go:72] "Tested communication with server"
I0809 15:23:32.754584   56596 utils.go:77] "Run with Kubernetes cluster version" major="1" minor="28" gitVersion="v1.28.6" gitTreeState="clean" gitCommit="be3af46a4654bdf05b4838fe94e95ec8c165660c" platform="linux/amd64"
I0809 15:23:32.754626   56596 utils.go:78] "Communication with server successful"
I0809 15:23:32.760410   56596 server.go:372] "Started metrics server" metricsServerAddress="[::]:8080"
I0809 15:23:32.760417   56596 server.go:361] "Started kube-state-metrics self metrics server" telemetryAddress="[::]:8081"
I0809 15:23:32.762704   56596 server.go:78] levelinfomsgListening onaddress[::]:8081
I0809 15:23:32.762742   56596 server.go:78] levelinfomsgListening onaddress[::]:8080
I0809 15:23:32.762842   56596 server.go:78] levelinfomsgTLS is disabled.http2falseaddress[::]:8081
I0809 15:23:32.762867   56596 server.go:78] levelinfomsgTLS is disabled.http2falseaddress[::]:8080
W0809 15:23:32.793414   56596 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.3/tools/cache/reflector.go:232: failed to list apiextensions.k8s.io/v1, Resource=customresourcedefinitions: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:garden-d067773:admin" cannot list resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope
E0809 15:23:32.793671   56596 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.3/tools/cache/reflector.go:232: Failed to watch apiextensions.k8s.io/v1, Resource=customresourcedefinitions: failed to list apiextensions.k8s.io/v1, Resource=customresourcedefinitions: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:garden-d067773:admin" cannot list resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope
W0809 15:23:33.963416   56596 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.3/tools/cache/reflector.go:232: failed to list apiextensions.k8s.io/v1, Resource=customresourcedefinitions: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:garden-d067773:admin" cannot list resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope
E0809 15:23:33.963493   56596 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.3/tools/cache/reflector.go:232: Failed to watch apiextensions.k8s.io/v1, Resource=customresourcedefinitions: failed to list apiextensions.k8s.io/v1, Resource=customresourcedefinitions: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:garden-d067773:admin" cannot list resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope
W0809 15:23:35.702016   56596 reflector.go:547] pkg/mod/k8s.io/client-go@v0.30.3/tools/cache/reflector.go:232: failed to list apiextensions.k8s.io/v1, Resource=customresourcedefinitions: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:garden-d067773:admin" cannot list resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope
E0809 15:23:35.702111   56596 reflector.go:150] pkg/mod/k8s.io/client-go@v0.30.3/tools/cache/reflector.go:232: Failed to watch apiextensions.k8s.io/v1, Resource=customresourcedefinitions: failed to list apiextensions.k8s.io/v1, Resource=customresourcedefinitions: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "system:serviceaccount:garden-d067773:admin" cannot list resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope

We will open an issue to upstream to relax this requirement. In the meantime, we have some stakeholders who would like to use the custom resource state feature to monitor their shoots. To allow them to do this soon, assuming the upstream discussion will take some time, we would like to grant such permissions to authenticated service accounts and users of the virtual Garden cluster. We think it exposes no risks.

asked multiple times so far to grant these permissions (e.g. terraform provider)

Maybe this will be helpful for other tools as well.
cc @istvanballok

Generally speaking CRDs just describe different API resources, which should be more or less public information.
But on the other side, maybe gardener operators would not like to expose to all users what kind of APIs are available and could be eventually (mis-)used by users.

Maybe this will be helpful for other tools as well.

No, it will not helpful because there is no CRD for shoot.

maybe gardener operators would not like to expose to all users what kind of APIs are available and could be eventually (mis-)used by users.

What are you thinking of in particular? The /apis (kubectl api-resources) or /openapi/v2 endpoint can also be accessed by authenticated users and gives similar "information"

maybe gardener operators would not like to expose to all users what kind of APIs are available and could be eventually (mis-)used by users.

What are you thinking of in particular? The /apis (kubectl api-resources) or /openapi/v2 endpoint can also be accessed by authenticated users and gives similar "information"

👍
I created a new service account in my project in the dev landscape, without roles like Admin, Viewer or UAM, so it is only an authenticated service account without additional permissions. I could retrieve metadata about all the resource types that are managed by the Gardener API, both about custom resources and also about resources that are contributed via the aggregation layer. So exposing the custom resource definitions to authenticated users would not reveal more information than what is already available today.
$ kubectl --kubeconfig serviceaccountkubeconfig get --raw /openapi/v2 | jq '
  .definitions | keys[]
' -r | grep Shoot
com.github.gardener.gardener.pkg.apis.core.v1beta1.Shoot
...

/lgtm

/lgtm

/approve

Issue to upstream: https://github.com/gardener/gardener/pull/10293


V1.3 add birthday field

This PR fixes #148
This Pull Request introduces the ability to add optional birthday fields to a person
Changes Made:

Add person with specified birthday with b/ddmmmyyyy
Birthday field is optional

Testing:
Unit Testing: Developed and executed a suite of new unit tests designed to validate birthdays
Additional Notes:
ddmmmyyyy has been chosen as the input format as it avoids unnecessary characters like spaces and '-', suitable for fast typists and increases efficiency.
Please feel free to provide feedback or suggestions for further improvements!

Is 06Jun2006 allowed? Will the 0 affect anything? Otherwise, looks good!

06Jun2006 or 6Jun2006 are both accepted!

@wapisai may need your help to fix the edit function for the birthday field

@wapisai may need your help to fix the edit function for the birthday field

Will do it as soon as this is merged! ✔💪

Fix #148

Missing AddCommandParser and ParserUtilTest tests


Skinny Window Header Fix

This is to fix the spacing of the icons in the top bar as previously, these were overlapping. This might not be the correct way to fix it but it works.

LGTM


CIV-5482 : Update task completion event for Listing Officer task

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

DO NOT MERGE THIS UNTIL ADIVSED


Remove host from url.Opaque

Summary
This addresses #167
Analysis
The Opaque in the URL structure ultimately lead to the issue in #167, which had the request not just allowing unicode urls (the expected result), but also not scrubbing -anything-... including the host info (unexpected).
While RFC 2616 allows this ( see http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.2 )the result affects openstack's conservative swift3 middleware. The middleware seems to identify and parse the parts of the url correctly, but otherwise doesn't know how to treat the scheme and host details in the URI and fails rather than guess (after all, the middleware doesn't even know that the host details are its own).
Regressions
This should work fine, because the .Host field in the http.Request had ought to keep special characters (In fact, I think Url.Opaque only exists for avoiding fanciness in the Request URI), however, care should be taken all the same. If a future version of http messes with 'Host', I'm thinking the only real solution would be to dig even deeper into the Url object.
Notes
I've already run go test on this, however I haven't been able to run the test suite for mc due to gopkg.in/check.v1 not being vendored in.
Should I also make a PR to minio/mc for adding the check.v1 to vendor?

I've already run go test on this, however I haven't been able to run the test suite for mc due to gopkg.in/check.v1 not being vendored in.
Should I also make a PR to minio/mc for adding the check.v1 to vendor?

gopkg.in is vendored in - https://github.com/minio/mc/tree/master/vendor/gopkg.in/check.v1 - there must be some other problem.
               {
                        "canonical": "gopkg.in/check.v1",
                        "comment": "",
                        "local": "vendor/gopkg.in/check.v1",
                        "revision": "11d3bc7aa68e238947792f30573146a3231fc0f1",
                        "revisionTime": "2015-07-29T10:04:31+02:00"
                }

This should work fine, because the .Host field in the http.Request had ought to keep special characters (In fact, I think Url.Opaque only exists for avoiding fanciness in the Request URI), however, care should be taken all the same. If a future version of http messes with 'Host', I'm thinking the only real solution would be to dig even deeper into the Url object.

Yes i agree.

Thanks for the PR, it looks good. There is one more change needed i.e https://github.com/minio/minio-go/blob/master/request.go#L421
Move the uri block into "r.req.URL.Opaque"

Following change will do.
@@ -417,12 +417,9 @@ func (r *request) getSignedHeaders() string {
 func (r *request) getCanonicalRequest(hashedPayload string) string {
        r.req.URL.RawQuery = strings.Replace(r.req.URL.Query().Encode(), "+", "%20", -1)

-       // get path URI from Opaque
-       uri := strings.Join(strings.Split(r.req.URL.Opaque, "/")[3:], "/")
-
        canonicalRequest := strings.Join([]string{
                r.req.Method,
-               "/" + uri,
+               r.req.URL.Opaque,

ah man, I totally forgot about those v4 signatures. This won't be necessary on legacy, right?

ah man, I totally forgot about those v4 signatures. This won't be necessary on legacy, right?

I will have to see..

LGTM


Country Code is not working for me can you please help me

<AccountKit
loginType = 'PHONE'
appId="XXXXXXXXXXXXXXXXX"
version="v1.0" // Version must be in form v{major}.{minor}
onResponse={(resp) => this.phoneLogin(resp)}
csrf={'absdfsdgfdgfdcd'} // Required for security
countryCode={+91} // eg. +60
                >
                    {p => <button {...p}>Phone</button>}
                </AccountKit>

Should be countryCode="+91". The value needs to be a string.

I have used but no luck but from the help of your code. I have written my own custom code. Thanks