Multiple relations for the same Entity => wrong SQL

Consider the following models
class Grade {
 public int Id {get; set;}
 public List<Fee> Fees {get; set;}
 public List<AdmissionFee> AdmissionFees {get; set;}
}

class Fee {
 public int Id {get; set;}
 public string Name {get; set;}
}

class AdmissionFee : Fee {
 public int YearId {get; set;}
}

The generated SQL will be
      SELECT "f"."Id",  "f"."Description",
       "f"."Discriminator",
       "f"."GradeId", --  ✅
       "f"."Name",
       "f"."YearId",
       "f"."GradeId1" --  ❌
      FROM "Fee" AS "f"
      INNER JOIN (
          SELECT DISTINCT
           "x"."Id"
          FROM "Grade" AS "x"
      ) AS "x" ON "f"."GradeId" = "x"."Id"
      WHERE (("f"."Discriminator" = 'AdmissionFee') OR ("f"."Discriminator" = 'Fee'))))

There is no Column named GradeId1

You need to let EF know what the column is called. Given you don't have foreign key properties in your model, EF is introducing them by convention and giving them names that it picks. By default it's the primary key name, but since there are multiple it needs to de-dupe them.
        protected override void OnModelCreating(ModelBuilder modelBuilder)
        {
            modelBuilder.Entity<Grade>()
                .HasMany(g => g.Fees)
                .WithOne()
                .HasForeignKey("GradeId");

            modelBuilder.Entity<Grade>()
                .HasMany(g => g.AdmissionFees)
                .WithOne()
                .HasForeignKey("<whatever the other FK column is called>");
        }

It's working !  😀 many thanks,
But why not picking the Primary Key always ? I can't imagine a scenario where generating virtual column is useful (e.g. GradeId1)

But why not picking the Primary Key always ?

I'm not sure what you mean by this. Because you don't have any foreign key properties in your model EF is introducing two foreign key columns for you (GradeId and GradeId1). If EF were generating the database for you then this would work and both columns would be added and setup with FK constraints. Because you are mapping to an existing database, you need to let EF know what the column names are (either by including corresponding properties in your class, or setting the names of the shadow state foreign key properties).

Actually my real models are slightly different than what I have provided above, So I've tried to reproduce the issue on a separate project, noting that:

I am generating the db from the models (Code first)
Developing on Mac, using the 1.0.0-rc1-update1    coreclr x64          darwin
Using Sqllite as db

My models
public class Fee {
    public int Id { get; set; }
    public float Value { get; set; }
    public int? GradeId { get; set; }
    public Grade Grade { get; set; }
}

public class AdmissionFee : Fee {}

public class Grade {
    public int Id { get; set; }
    public string Name { get; set; }
    public List<Fee> Fees { get; set; }
    public List<AdmissionFee> AdmissionFees { get; set; }
}
public class ApplicationDbContext : IdentityDbContext<ApplicationUser> {
    public DbSet<Grade> Grades { get; set; }
    public DbSet<AdmissionFee> AdmissionFees { get; set; }
    public DbSet<Fee> Fees { get; set; }
}

The generated table Fee has now the following columns: Id, Discriminator, GradeId, Value, GradeId1.
1 (Failed to reproduce, so you can ignore it for now)
For the main Issue I have opened it seems that I am doing something wrong since the generated db is now containing the GradeId1 (Maybe I have changed the models without regenerating the db by mistake), anyway I will try to investigate more, to see how it happened
2 (Enhancement)
My Second question was why it generates the second column GradeId1 when GradeId alone is sufficient since AdmissionFee and Fee cannot be set in the same row according to TPH.
So instead of

Id
Discriminant
GradeId
GradeId1

1
Fee
1
null

2
AdmissionFee
null
1

Suggested schema

Id
Discriminant
GradeId

1
Fee
1

2
AdmissionFee
1

3 GradeId1 is always null when inserting data (Bug)
Here is how am inserting data
var grades = Enumerable.Range(1, 10).Select(x => new Grade {
  Name = $"Grade {x}"
});

foreach(var g in grades){

  db.Grades.Add(g);

  db.Fees.Add(new Fee {
     GradeId = g.Id,
     Value =  g.Id * 100
  });

  db.AdmissionFees.Add(new AdmissionFee {
     GradeId = g.Id,
     Value =  g.Id * 50
  });
}

return db.SaveChanges();

and here is a snapshot of the table

Id
Discriminant
GradeId
Value
GradeId1

1
Fee
1
100
null

2
AdmissionFee
1
50
null

And Always it's returning as their is no admission fees
return db.Grades
    .Include(x => x.Fees)
    .Include(x => x.AdmissionFees)
    .ToList();

returns

  [
  {
    "id": 1,
    "name": "Grade 1",
    "fees": [
      {
        "id": 1,
        "value": 100.0,
        "gradeId": 1
      },
      {
        "id": 18,
        "value": 50.0, // <-- this should be admission fee and not regular fee
        "gradeId": 1
      }
    ],
    "admissionFees": [
       // <--- there is no admission fees
    ]
  },
// ....
]

Ah, I think I see what the point of confusion is now. I think what you really want is just one relationship that can contain both Fee and AdmissionFee. What you are getting though, is two separate relationships:

Grade.Fees give you a relationship where a Grade can have many Fees (either Fee or AdmissionFee.
Grade.AdmissionFees gives you a second relationship where a Grade can have many AdmissionFees.

Because there are two relationships, there have to be two separate FK columns in the database. To demonstrate this, here is some code that adds several different Fees to the two different navigation properties:
db.Grades.Add(new Grade
{
    Name = "New Grade",
    Fees = new List<Fee>
    {
        new Fee {  Value = 10 },
        new AdmissionFee {Value = 20 }
    },
    AdmissionFees = new List<AdmissionFee>
    {
        new AdmissionFee {Value = 30 }
    }
});

db.SaveChanges();

And here is the resulting data in the database:

Id
Discriminator
GradeId
Value
GradeId1

1
AdmissionFee
NULL
30
1

2
Fee
1
10
NULL

3
AdmissionFee
1
20
NULL

As you can see GradeId identifies which Grade it is related to via the Grade.Fees collection and GradeId1 identifies which `Grade

BTW you could always leave the Grade.AdmissionFees property and just make it a wrapper over the Fees property:
public class Grade
{
    public int Id { get; set; }
    public string Name { get; set; }
    public List<Fee> Fees { get; set; }

    [NotMapped]
    public IEnumerable<AdmissionFee> AdmissionFees
    {
        get { return Fees.OfType<AdmissionFee>();
    }
}

Closing out as I am confident we have got to the bottom of this one. But feel free to re-open or comment if you do not agree :smile:

Many thanks, Yes I can follow the approach for now .OfType<AdmissionFee>() but actually here I am filtering at the app level and not the db level.
Anyway no doubt that EF7 is going to a next level, great job guys, this is the first time that I feel that am really satisfied with ASPNET !! <3


Add "options" support #291

What do these changes do?
Add support for options , @devin-petersohn not sure what kind of test to do for this, i test it by checking pd.options.display.max_rows when printing but i don't think its the best option.
Related issue number
#291

[X] passes flake8 modin
[X] passes black --check modin

Thanks @ipacheco-uy, I think the challenge here is making sure that the updates to the display are propagated. Here is internally where repr needs to be updated: https://github.com/modin-project/modin/blob/master/modin/pandas/dataframe.py#L134-L136
There are several options in pandas that will be difficult because all of the workers need those options. For now this could work with the display options, as long as we change the code in __repr__.
For now, the best way to test for the display options is probably to just call repr(some_df) and make sure that the number of rows/columns is correct. Other than that, as long as the call to pandas repr (link) gets the correct display options it still should be working.

Yo are right devin i forgot of the fixed value in dataframe.

Thanks @ipacheco-uy, for some reason the Ray engine was failing due to the options being kept around for Modin but not for pandas. I fixed the issue by moving the test below test___repr__, which should (hopefully) fix the issue.

The current test failure is fixed by #539, the tests are timing out on Travis.

@ipacheco-uy I went ahead and merged your PR into master. The tests should all be fine now. Thanks again for the PR!


Add feature to retrieve user info from every friend added to a friend list

I originally tried to query the friend lists data in order to get user IDs using the Graph API but quickly found out that isn't supported with 2.0.
It'd be cool if we could retrieve every friend in a friend list with a function like getList().
Alternatively, maybe this could just be added onto getFriendsList() as another field under a user such as lists: blah, blahblah

My gut response to this is that it doesn't seem like a chat-related feature to me and so is out of the scope of this API.  If the getFriendsList() call already has access to this data and we're simply not returning it, I could understand adding it in, but I think other than that it is unlikely that we will do any work to add this feature.
If you're set on having this, you can always fork this repo and add it yourself to your own branch, using our login and cookie management code.

Going to close this for the reasons above.  Feel free to comment back here if you manage to get it to work in case someone in the future wants to do the same thing :smile:


Game modes

Doest anyone have working Zombies/HungerGames or other unusual game modes for current MultiOgar version?

Proxiemind has a Hunger Games server running on MultiOgar-Edited

@freaky767 thanks, but Proxiemind didn't finish work on it(

@F0RIS I don't think so, I've been meaning to make some/port some over from Ogar but never really got into it.

porfavor agreguen los demas modos de juego , esta triste con solo 4 modo de juego

@F0RIS I have a Hunger Games server working on 1.6.1


Updated to reflect moved Census URLs

Census changed the lookup tools without providing a redirect.

You can also use http://censusreporter.org ;)


add Count method

closes #7

Please add bindings in index.js, tests, and type definitions.

In order to close #7 we need to implement an overload Count<T>: ((x: T) => boolean): number. Do you want to merge as-is and keep the issue open?

Same as I said on my other PR, I think it's okay as is and we can allow others to contribute as well.

Thank you for your contribution. Happy hacking 🎃


Move Phase2::create_tml to coreneuron/sim/multicore

Move Phase2::create_tml to coreneuron/sim/multicore

Codecov Report

Merging #562 (82cae27) into master (c938e4f) will not change coverage.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master     #562   +/-   ##
=======================================
  Coverage   56.48%   56.48%
=======================================
  Files          98       98
  Lines        8001     8001
=======================================
  Hits         4519     4519
  Misses       3482     3482

Impacted Files
Coverage Δ

coreneuron/io/phase2.hpp
66.66% <ø> (ø)

coreneuron/sim/multicore.hpp
100.00% <ø> (ø)

coreneuron/sim/multicore.cpp
79.41% <85.00%> (+2.32%)
:arrow_up:

coreneuron/io/phase2.cpp
64.09% <100.00%> (-0.68%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c938e4f...82cae27. Read the comment docs.


ADA balance 0 after claiming Sundae tokens

Hello Sir, I connected my ledger and got this message "We have detected that the current wallet seed has been used with another wallet." This occurred after I claimed my Sundaeswap rewards. And it's showing that my ledger balance is 0.00 ADA. However, it shows what that real balance is. I am not sure what is going on. I even tried deleting the wallet and connecting it back and it's still saying the same thing

https://cardanoscan.io/transaction/5e844c50e6991fc76c6ffd57fabbafe5cf3f17ea441db951cdf254f727e3fe8d
This is the transaction output

I used yoroi wallet and was able to transact with my ledger. But still wondering while nami is having this issue


Add index for attempts in delayed_jobs table

With adding an index to attempts, the query time can be improved
significantly.
This will improve SELECT "queue", count(*) AS "count" FROM
"delayed_jobs" WHERE ("attempts" = 0) GROUP BY "queue";

Signed-off-by: Philipp Thun<EMAIL_ADDRESS>Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

A short explanation of the proposed change:

An explanation of the use cases your change solves

Links to any other associated PRs

[x] I have reviewed the contributing guide

[x] I have viewed, signed, and submitted the Contributor License Agreement

[x] I have made this pull request to the main branch

[x] I have run all the unit tests using bundle exec rake

[ ] I have run CF Acceptance Tests

We had a look at which queries are executed on the delayed_jobs table and how often they are run.
For the most important query (SELECT * FROM "delayed_jobs" WHERE ... FOR UPDATE) there is already an index over multiple columns. This query is used to select the next job to process and is executed on a large foundation ~10 million times per day.
There are two additional queries that are executed ~500 thousand times per day that don't use an index. Both queries look like this:
SELECT "queue", count(*) AS "count" FROM "delayed_jobs" WHERE (<some condition>) GROUP BY "queue";

The condition is either "attempts" = 0 or failed_at IS NOT NULL. On the first one, an index had a significant impact; it reduced the execution time from 7.3ms to 0.4ms. For the second condition, adding an index did not have an effect due to the fact that the majority of the table was returned.


<EMAIL_ADDRESS>hash check failed

doom-retro: 5.0.3 -> 5.0.4
WARN  Scoop uses 'aria2c' for multi-connection downloads.
WARN  Should it cause issues, run 'scoop config aria2-enabled false' to disable it.
WARN  To disable this warning, run 'scoop config aria2-warning-enabled false'.
Updating one outdated app:
Updating 'doom-retro' (5.0.3 -> 5.0.4)
Downloading new version
Starting download with aria2 ...
Download: Download Results:
Download: gid   |stat|avg speed  |path/URI
Download: ======+====+===========+=======================================================
Download: 936b22|OK  |   3.9MiB/s|C:/Users/hylianux/scoop/cache/doom-retro#5.0.4#https_github.com_bradharding_doomretro_releases_download_v5.0.4_doomretro-5.0.4-win64.zip
Download: Status Legend:
Download: (OK):download completed.
Checking hash of doomretro-5.0.4-win64.zip ... ERROR Hash check failed!
App:         games/doom-retro
URL:         https://github.com/bradharding/doomretro/releases/download/v5.0.4/doomretro-5.0.4-win64.zip
First bytes: 50 4B 03 04 14 00 00 00
Expected:    885339cd41804e113f0448ca0606087db56007424b4f040eac84e13de2db51dc
Actual:      0e363a7d32c6a781818bb1b0a59e3e6d34dd43f2be7971f15b202e69b7154e5f

Superseded by 5.0.6 update which is now in https://github.com/Calinou/scoop-games/blob/master/bucket/doom-retro.json.


Implement ClientSettingsPolicy API

Use Cases:

As a Cluster Operator, I want to set defaults for client settings that will work for most applications so that most Application Developers will not have to tweak these settings.
As an Application Developer, I want to be able to configure client settings for my application based on its behavior or requirements.
As an Application Developer, I want to override the defaults for client settings set by the Cluster Operator because the defaults do not satisfy my application's requirements or behavior.

A/C:

A user can create a ClientSettingsPolicy and attach it to a Gateway and/or HTTPRoute. A setting attached to an HTTPRoute overrides the same setting attached to a Gateway.
The Accepted Condition is set on every ClientSettingsPolicy using the reasons defined in the PolicyCondition API. If these reasons are not sufficient, we can add implementation-specific reasons.

Questions:

Which fields of the ClientSettingsAPI do we want to implement first? Just max body size? All fields? A subset?
Should we split up this issue and tackle each attachment point separately?

The completion of this issue will complete the work first defined in:
#1245
#1398
#483


POSTing to /cluster with custom dockerRootDir does not override default

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
POST to /cluster with the following body:
{ "dockerRootDir": "/var/vcap/store/docker/docker",
"enableClusterAlerting": false,
"enableClusterMonitoring": false,
"enableNetworkPolicy": false,
"type": "cluster",
"name": "myname" }

Apply manifestURL.
Check API for resulting cluster.
Result:
dockerRootDir": "/var/lib/docker"
Other details that may be helpful:
Because this is a Kubernetes cluster built by VMware Enterprise PKS (Pivotal Container Service), it uses a non-standard Docker root at this path.
Environment information

Rancher version: 2.2.8
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): VMware Enterprise PKS
Machine type (cloud/VM/metal) and specifications (CPU/memory): VM
Kubernetes version (use kubectl version): 1.13.5

(paste the output here)

Docker version (use docker version):  18.06.3-ce

(paste the output here)

However, in checking the cluster resource, the value for key dockerRootDir is apparently defined correctly:
$ k get cluster c-cngls -o yaml
apiVersion: management.cattle.io/v3
kind: Cluster
metadata:
  annotations:
    authz.management.cattle.io/creator-role-bindings: '{"created":["cluster-owner"],"required":["cluster-owner"]}'
    field.cattle.io/creatorId: user-km5hk
    lifecycle.cattle.io/create.cluster-agent-controller-cleanup: "true"
    lifecycle.cattle.io/create.cluster-provisioner-controller: "true"
    lifecycle.cattle.io/create.cluster-scoped-gc: "true"
    lifecycle.cattle.io/create.mgmt-cluster-rbac-remove: "true"
    provisioner.cattle.io/ke-driver-update: updated
  creationTimestamp: "2019-09-23T16:50:12Z"
  finalizers:
  - controller.cattle.io/cluster-agent-controller-cleanup
  - controller.cattle.io/cluster-scoped-gc
  - controller.cattle.io/cluster-provisioner-controller
  - controller.cattle.io/mgmt-cluster-rbac-remove
  generation: 23
  labels:
    cattle.io/creator: norman
  name: c-cngls
  resourceVersion: "3802185"
  selfLink: /apis/management.cattle.io/v3/clusters/c-cngls
  uid: 35b47810-de22-11e9-aa61-0050568c586e
spec:
  description: ""
  desiredAgentImage: ""
  desiredAuthImage: ""
  displayName: czk8smini08
  dockerRootDir: /var/vcap/store/docker/docker
  enableClusterAlerting: false
  enableClusterMonitoring: false
  enableNetworkPolicy: false
  internal: false
  localClusterAuthEndpoint:
    enabled: false


db.r5.4xlarge - wrong RAM size - should be 128 GiB instead of 192 GiB

The db.r5.4xlarge instance has wrong RAM size - should be 128 GiB instead of 192 GiB:
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.DBInstanceClass.html#Concepts.DBInstanceClass.Summary
This is a large difference and can make somebody a little too optimistic (and then disappointed) about the newly available family.

Data issue... eg for eu-west-1:
      "sku" : "QUCASZB8UYFSQEBS",
      "productFamily" : "Database Instance",
      "attributes" : {
        "servicecode" : "AmazonRDS",
        "location" : "EU (Ireland)",
        "locationType" : "AWS Region",
        "instanceType" : "db.r5.4xlarge",
        "currentGeneration" : "Yes",
        "instanceFamily" : "Memory optimized",
        "vcpu" : "16",
        "physicalProcessor" : "Intel Xeon Platinum 8175",
        "clockSpeed" : "Up to 3.1 GHz",
        "memory" : "192 GiB",
        "storage" : "EBS Only",
        "networkPerformance" : "Up to 10 Gigabit",
        "processorArchitecture" : "64-bit",
        "engineCode" : "18",
        "databaseEngine" : "MariaDB",
        "licenseModel" : "No license required",
        "deploymentOption" : "Single-AZ",
        "usagetype" : "EU-InstanceUsage:db.r5.4xl",
        "operation" : "CreateDBInstance:0018",
        "dedicatedEbsThroughput" : "3500 Mbps",
        "enhancedNetworkingSupported" : "Yes",
        "instanceTypeFamily" : "R5",
        "normalizationSizeFactor" : "32",
        "servicename" : "Amazon Relational Database Service"
      }
    },```

@ccayg-sainsburys please create an AWS support case to have the data corrected by the pricing team.

Sorry - I'm not sufficiently interested as I'm not using this instance class I just happened to notice when I was looking at diff issue.

Fair enough, I hope there's someone out there who is interested in this enough to make a support case. Thanks for reporting this though.

This seems to be correct in the API but it still shows the previous value on the website. I wonder whether we're caching the incorrect value somehow.
$ aws --region us-east-1 pricing get-products --service-code AmazonRDS --filters Type=TERM_MATCH,Field=instanceType,Value=db.r5.4xlarge Type=TERM_MATCH,Field=sku,Value=QUCASZB8UYFSQEBS --output text   | sed -e 's/aws_v1.*//' -e 's/PRICELIST//' | jq .
{
  "product": {
    "productFamily": "Database Instance",
    "attributes": {
      "engineCode": "18",
      "enhancedNetworkingSupported": "Yes",
      "instanceTypeFamily": "R5",
      "memory": "128 GiB",
      "dedicatedEbsThroughput": "3500 Mbps",
      "vcpu": "16",
      "instanceType": "db.r5.4xlarge",
      "usagetype": "EU-InstanceUsage:db.r5.4xl",
      "locationType": "AWS Region",
      "storage": "EBS Only",
      "normalizationSizeFactor": "32",
      "instanceFamily": "Memory optimized",
      "databaseEngine": "MariaDB",
      "servicecode": "AmazonRDS",
      "physicalProcessor": "Intel Xeon Platinum 8175",
      "clockSpeed": "Up to 3.1 GHz",
      "licenseModel": "No license required",
      "currentGeneration": "Yes",
      "networkPerformance": "Up to 10 Gigabit",
      "deploymentOption": "Single-AZ",
      "location": "EU (Ireland)",
      "servicename": "Amazon Relational Database Service",
      "processorArchitecture": "64-bit",
      "operation": "CreateDBInstance:0018"
    },
    "sku": "QUCASZB8UYFSQEBS"
  },


[REQUEST] Notification of all Pokémons in certain area

Checklist

[X] I have read the FAQ
[X] I have checked if this issue already exists (both open and closed issues)
[X] I am using the most recent version of pogom from the master branch
[ ] If this is an installation issue, I am posting my OS, OS version, python version, pip version
[ ] I'm posting the complete log
[X] I'm using a descriptive title for this issue

My Request
How about to implement a notification for a certain area (location). Say you are scanning a very large area but you want to be notified of any pokemon (or some defined pokemons) in a certain area around you.

Run two instances on different ports and only turn on notifications for the second instance with the smaller scan area.

great idea, thanks! Nevertheless I think it would be more userfriendly with one instance ;-)

made in #279


Issue 2790/xlsx stream missing worksheets

Summary

Provides a integration test case for issue 2790 as well as a possible solution.
The stream namespace for xlsx workbook reader does not correctly parse large numbers of worksheets > 100. This is due to the way it is unzipping the file, it is reading the entries from the unzipper parse however it is not correctly draining each entry resulting in the stream halting node-unzipper. The iterateStream util does not call autodrain for each data when reading the unzipper stream.
Test plan

This is the test xlsx file that has 188 worksheets.
WORKBOOK_WITH_188_SHEETS.xlsx
I've created a test case that will read the file and check whether the count of worksheets emitted is equal to the count of worksheets in the file.

Related to source code (for typings update)

Are there any guarantees that the workbookReader would return worksheets in the order they appear in the workbook? I ran a test and it seems like the order is not guaranteed. The total number of worksheets returned appear correct.

There are no guarantee that the worksheets are returned in the way they appear in the workbook. I believe the order is effectively set by how unzipper extracts the xlsx. I believe the order on this branch is the same as on master.
Also regarding the rows not return the correct data. I think that is not an issue introduced by my changes. I am able to replicate the same results on master as on my branch.


Logframe XLS export crash - unicode encoding error

When exporting a Logframe XLS on QA w/ Spanish active: https://tola-activity-qa.mercycorps.org/program/618/logframe_excel/?groupby=1
Environment:

Request Method: GET
Request URL: https://tola-activity-qa.mercycorps.org/program/618/logframe_excel/?groupby=1

...

Traceback:

File "/home/tolafabric/venv-tola/local/lib/python2.7/site-packages/django/core/handlers/exception.py" in inner
  41.             response = get_response(request)

File "/home/tolafabric/venv-tola/local/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
  187.                 response = self.process_exception_by_middleware(e, request)

File "/home/tolafabric/venv-tola/local/lib/python2.7/site-packages/django/core/handlers/base.py" in _get_response
  185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/home/tolafabric/venv-tola/local/lib/python2.7/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
  23.                 return view_func(request, *args, **kwargs)

File "/var/www/TolaActivity/tola_management/permissions.py" in wrapper
  228.             return func(request, *args, **kwargs)

File "/var/www/TolaActivity/indicators/views/views_program.py" in logframe_excel_view
  174.         '{} - {}.xlsx'.format(program['name'], ugettext('Logframe'))

Exception Type: UnicodeEncodeError at /program/618/logframe_excel/
Exception Value: 'ascii' codec can't encode character u'\xf3' in position 7: ordinal not in range(128)

@KennyMonster Anything special I should do to test this, aside from setting my language to Spanish and attempting to export some logframes?

Nope that's pretty much it. Maybe test in French as well.

PASSED. Didn't experience any crashing or error messages when exporting the logframe, while the language was set to Spanish or French.


added NDE extensions for SY 2023-2024

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

pushed a signed version


[DH-301] point the build and push cannon to artifact registry

welp apparently the docs aren't correct, or i'm doing something weird and wrong.
https://github.com/jupyterhub/repo2docker-action?tab=readme-ov-file#push-repo2docker-image-to-google-artifact-registry

now to merge and see if it pushes...


Mixed elements and text nodes

This code sample:
    const src = `
    <?xml version="1.0"?>
    <root>
        <x>blah</x>
        xlub
        <x>blah</x>
    </root>
    `;

    const parsed = parse(src);

Fails with
error: Uncaught SyntaxError: Expected next sequence to be "<", got "x" instead
throw new SyntaxError(Expected next sequence to be "${content}", got "${this.peek(bytes)}" instead);
I do think it should parse as mixing element nodes and text nodes is allowed. (The sample was deduced from some xhtml which did not parse).

Yes indeed, seems that currently mixed nodes content is only supported when the first node is a textnode, if it's a content node then it fails as you mentioned
I'll look into it somewhere next week, thanks for reporting this

Hello!
Any news on this issue?
I stumbled into same error but with following xml structure:
<parameters>
    <!-- some comments -->
    text line 1
    text line 2
</parameters>

The comment is parsed correctly but thereafter it expects a tag and tries to find <.
I've tried to fix it inside utils/parser.ts and found two spots where it wrongly assumes to consume a tag:

anywhere after line 53 but before 74: check that there could be a text node.
between 104 and 104: same.
especially between lines 199 - 200; node is assumed and expected, but can be text or comment.
... not sure if more spots need to be reviewed.

Then I tried to insert the following between 199-200:
if ((this.#peek(tokens.cdata.start)) || (!this.#peek(tokens.tag.start))) {
     Object.assign(tag, this.#text({ close: name, path: [...path, tag] }));
     continue
}

And it worked, but it's only for the case 3) and not foolproof.
Maybe the can give some suggestions?! 🙂

Hi !
I'm so sorry, I completely forgot about this 😅 !
Yes indeed, as you noted the main issue is around lines 200

Then I tried to insert the following between 199-200:
if ((this.#peek(tokens.cdata.start)) || (!this.#peek(tokens.tag.start))) {
    Object.assign(tag, this.#text({ close: name, path: [...path, tag] }));
    continue
}

And it worked, but it's only for the case 3) and not foolproof.

I think your patch should cover most cases, as the main reason why it's currently not working is because it first checks whether the stream is currently faced with a cdata/text node, and if not, assume that everything will be child content node, but between each child node it should check again the presence of cdata/text nodes which is currently not done (and what your patch actually fixes)
Also, it may be possible that your issue is slightly different that the one reported in the first post, because it seems like comments are not peeked/consumed if they're the first child (there's no this.#peek(tokens.comment.start)) in the mentioned lines) which I think is the reason why it fails in the example you provided
I'm fine with the patch proposed, but I'm not sure if the output match the current stated behaviour in the doc which is to treat mixed content as raw text. If not, maybe one solution would be to store the stream cursor position before entering the conditional, and if fails to consume a tag start toke, backtrack the stream cursor at previous position and force the text consuming path 🤔 ?

As for case 1, I don't think it's possible to have text node at the same level of prolog/doctype/root node, but I could be wrong
For case 2, seems the lines numbers you provided are the same, but assuming you mean these lines:
https://github.com/lowlighter/xml/blob/448b77319701201654c8dc3f5a6ea7451fdf9f90/utils/parser.ts#L96-L105
Then it should be already be covered by the case 3 fix
Anyway thanks a lot for investigating through this, I really appreciate it 👍


Fail to load pretrained checkpoints

Hi,
I try to load a part of variables from download models. But it turns out Key Not Found Error, even though the variables names are same. The only difference is the ':0' in tails, but I think it does not matter since this is added automatically by tensorflow op.
Here is what I read from checkpoints and the Key not found error log.

I think this might be related to your tensorflow version.


@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/genno-feedstock#3.


Product url keys

I have two stores and all product url keys is lost after command bin/magento ok:urlrewrites:regenerate. So it doesn't save url keys to any product.
Tested also commands and doesn't work: bin/magento ok:urlrewrites:regenerate --no-clean-url-key and bin/magento ok:urlrewrites:regenerate --save-old-urls

You need to update to 1.3.
bin/magento ok:urlrewrites:regenerate --no-clean-url-key

I have latest version 1.3.0 and Magento 2.2.6 but it is after command every products url keys empty.

Are you running multistore? Are your URLs different per store/website? Maybe try running the store code within the command like below. Replace the 2 for store id you need to regen.
bin/magento ok:urlrewrites:regenerate 2 --no-clean-url-key

All commands tested and same issue. This empty url keys issue is only with products.

Anything idea how bulk save all products so i get back all url keys?

i'm having the same issue.

Fixed issue in v1.3.1. Please update extension and regenerate URL rewrites - URL keys will be back.
Please, confirm a fix.

I can confirm. It's working now.

Fixed. Closed.


software bug: failed to install docker 20.10

Describe the version
version about:

kubean 0.3.7

Describe the bug
failed to install docker

How To Reproduce
when the version of kubean is 0.3.7 and usring docker version 20.10, it's certainly be reproduced.
Expected behavior
docker version about rhel7 or centos7 in kubespray already upgraded to 20.10.20, so docker version in kubean need to upgrade too.
Screenshots and log
packages.yml in kubean

rhel-7.yml in kubespray

/kind bug


Write CMake installation rules

Install the plugins in the right place and whatnot.

The plugin handler will need to have the correct prefix of the installation, also.


Fix VNC SecurityType None on RFB v3.8

Description
This PR fixes the console access for Vmware 6.7 which offers SecurityType = 1 (None) - Reference: https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#721none
The CPVM access uses the RFB protocol 3.8 since #7015 (previously it used version 3.3). From the link above:
Version 3.8 onwards
The protocol continues with the SecurityResult message.
Version 3.3 and 3.7
The protocol passes to the initialisation phase ([Initialisation Messages](https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#initialisation-messages)).

This PR fixes the behavior of the security type None, continuing with the SecurityResult message instead of the Initialisation Phase as it was on version 3.3
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[x] Major
[ ] Minor

Bug Severity

[x] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
Vmware 6.7 environment
Access any VM console before the fix -> Observe that the console is visible for less than a second, then an error is thrown
After the fix -> Console access works fine

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5638

@blueorangutan test

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

code looks good @nvazquez . Did youcheck if this also works when no SecurityResult message is send on SecurityType None? or is it somehow guaranteed to never happen?

@blueorangutan package

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5641

Thanks @borisstoyanov @rohityadavcloud @DaanHoogland
@DaanHoogland yes, the case for version 3.3 is already covered and working, this will fix only the 3.8 protocol in which it will never happen for a working console

Trillian test result (tid-6224)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38099 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7287-t6224-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


Display warning if onset file is missing

As pointed out by @nicholsn https://github.com/incf-nidash/nidm-results_fsl/issues/39#issuecomment-108105696, the export is failing if the onset file cannot be found on the system.
We might want to display a warning and perform the export without the nidm:designType (i.e. event-related, block-based, mixed) information if the onset file is missing.

Perhaps there could be a nidm:UnknownDesignType that simply points to the absolute path?

@nicholsn: I am bit afraid this might be confusing and we probably want to avoid including full path (that can potentially disclose privacy info).
I am going to merge and release on pypi once the tests pass.
If you feel this should be further discussed, then it would probably be best to open an issue at https://github.com/incf-nidash/nidm as the changes you are suggesting impact the data model.

This is now available on pypi as nidmfsl version 0.2.0. I will merge as soon as the tests pass on Travis (they pass locally on my machine).


Optimizing the Pill Canisters!

Optimizing the Pill Canisters!
Changes pill canisters capacity to 9. Up to two will now fit in the small storage space that coats have!
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Whisper

Tweak: Pill canisters will now fit in coat storage, at the cost of having less space for pills. (12 -> 9)

The consensus of this PR seems to be it's a bad idea. I'll leave it as a draft. Currently there is no other way for pill canisters to fit in coat pockets for now.

Reopening this, after discussion in # development on the discord


Trips reports

Added trips report, key features of trips detector are here #2224
Refactored reports models and moved some code to ReportUtils
Added tests for ReportUtils

I've added "Spent fuel" only to trips (not summary) because it is very unlikely that fuel increases during a trip. It is calculated only for 3 protocols for now. It is String and formatted in java, because web-client never knows which format is used for KEY_FUEL.
If you don't mind I've added speed to test-generator.py. It helps to test motion, overspeed, and trips detector.
Also I can add comments to detectTrips for how it is work explanation if need.

I haven't had much time to look at the actual logic, but at first glance it looks OK. Have you tested it with real trips?

Sure, in #2224 screenshot if my real trips and it correspond to facts 100%.
My device is rather precise and sleep on parking. On some other devices that always send positions may happen "false trips" but I think it can be handled with configuration and filters.

OK. Used double.
I just was repairing my car, and tracker sent positions for whole period.
As I guessed logic produces some false trips. For such devices need additional filtering, but I think CoordinatesHandler will be enough in most cases

Merged, thanks.


Fix/broken medium tests

Split long tests in sequential and mpi in the same way as medium tests
Restore the Antares study in its initial state after running the tests
Check that optimality_gap and relative_gap match the expected values
Restore the expected values introduced in PR #291 that were overwritten when merging PR #284

This PR closes #300

ok for this pr.
some 'long' tests failed, further investigation is needed --> see #305


onLayoutChange is not triggers if children's changed, whithout changed children's count.

When children of component changed, but count of children isn't, layout is not recalculated.
It happes due to comparison only lengths of this.props.children and nexProps.children, completely ignoring children's content. Quick example:
render() {
  <ReactGridLayout>

    {this.state.flag ?
 :
}
  </ReactGridLayout>
}

If this.state.flag changed, layout should be recalculated. But there is no recalculation.
/cc @javacer

fix in commit https://github.com/megaplan/react-grid-layout/commit/ab1c37791aac1cbf46b095d096bd12765e40dbd7

@STRML seems that that kind of fix is useless. Because on each render this.props.children contains a bunch of react elements created by React.createElement. That method on each call returns new instance of ReactElement, so, shallowCompare will return false on each componentWillReceiveProps, because shallowCompare goes to first deep level, and there would be different objects.
I think that more accurate check - is to compare previous/next bunch of children keys, instead of children objects.
Please correct me if I'm missed something.

You are correct.
Unfortunately comparing React elements for this purpose is very error-prone. Would be nice if we could eliminate more of the state here.

ec8816b seem correct to you @Strate?

Thanks a lot, I'll test it tomorrow:)


Make night version of this theme

It would be really awesome if you could make a nice night version of this theme. I know you can change the color of the background but I found it to not be enough and I had to edit many other things just so it worked.
Would be nice to create a config option to make the theme go dark.

I would love to see a dark version of this theme too :) \o/


Some role cannot be changed

Role generated with the account configurator are not changeable.
Ask to the team for the latest list. ( example: poweruser, admin, read only , fullstop )
Report also usage of unapproves AWS services

this include also #35

will not include #35


how to generate libyoga.so for android

I install buck, and want to build out a libyoga.so and the Java wrapper.
however, It failed to generate the libyoga.so.

"buck build //:yoga" will just generate a libyoga.a

"buck build //java:jni" will generate a libjni.a

"buck build //java:java" will generate java.jar and java-abi.jar, from my understanding, the //java:java build target  depends on jni&yoga, so it should generate both the libyoga.so library and jar file.
Is my understanding correct? should I covert the static library to dynamic library manully?

I use " buck build java:jni#default,shared" can generate a libyouga.so,but when I use the so in Android project, it crashed

it generate a libyoga.dylib in my mac... do you know how to set the platform?

there is a properties "soname" in buck soname = 'libyoga.$(ext)',maybe you can set soname = 'libyoga.so"
you can see https://buckbuild.com/rule/cxx_library.html,but some properties doesn't work
and I am also very confused

Thanks koudle, just set soname to libyoga.so should be wrong,  I saw the LinkMap.txt of libyoga.so, it is still a Mac specific library.
Object files:
[  0] linker synthesized
[  1] buck-out/gen/java/jni#compile-pic-YGJNI.cpp.o8c77d5e7,default/jni/YGJNI.cpp.o
[  2] buck-out/gen/lib/fb/fbjni#default,shared/liblib_fb_fbjni.dylib
[  3] buck-out/gen/yoga#default,shared/libyogacore.dylib
[  4] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/usr/lib/libc++.tbd
The so library should be built out through NDK, That's why it crashes.

You can use android-armv7 flavor.
$ buck build //java:jni#android-armv7,shared
$ buck targets --show-output //java:jni#android-armv7,shared
//java:jni#android-armv7,shared buck-out/gen/java/jni#android-armv7,shared/libyoga.so
$ file buck-out/gen/java/jni#android-armv7,shared/libyoga.so
buck-out/gen/java/jni#android-armv7,shared/libyoga.so: ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /system/bin/linker, ..., not stripped

@splhack many thanks, it works now.

@Shuijwan It works for me,but in my project,the so load failed.How do you solve it?

@koudle have you copied all so files?
buck-out/gen/java/jni#android-armv7,shared/libyoga.so
buck-out/gen/lib/fb/fbjni#android-armv7,shared/liblib_fb_fbjni.so
buck-out/gen/yoga#android-armv7,shared/libyogacore.so

@koudle also you need copy the libgnustl_shared.so to your jniLibs. it is under /Users/Aaron/Downloads/android-ndk-r13b/sources/cxx-stl/gnu-libstdc++/4.9/libs/armeabi-v7a

@splhack I have copied all so files ,and @Shuijwan Shuijwan is right,also need copy the libgnustl_shared.so to  jniLibs,it works now,thanks very much

@Shuijwan could you share your so files Plz. Currently I'm trying to use it. But, fail to build it(via Windows). Now trying to build it via Linux. But I eager to touch it.
<EMAIL_ADDRESS>Thx.

@liao123abc you can see my github https://github.com/koudle/AndYogaExample,麻烦star一下，thanks

Is the libgnustl_shared.so really needed? It is rather large and bloats the final apk when supporting multiple architectures.

@mpost not sure.
It is on my todo list to create a sample gradle setup for android and posting it to jcenter / maven central. Just not the highest priority right now.

@emilsjolander that would be very handy. Please keep us posted.

You can specify C++ runtime in .buckconfig.local file. For example,
[ndk]
  ndk_version = r10e
  app_platform = android-21
  compiler = clang
  cxx_runtime = libcxx

$ buck build //java:jni#android-armv7,shared
$ for f in `find buck-out -name "*.so"`; do echo "$f:"; strings $f|grep libc++_shared.so; done
buck-out/gen/java/jni#android-armv7,shared/libyoga.so:
libc++_shared.so
buck-out/gen/lib/fb/fbjni#android-armv7,shared/liblib_fb_fbjni.so:
libc++_shared.so
buck-out/gen/yoga#android-armv7,shared/libyogacore.so:
libc++_shared.so

But unfortunately apparently current buck doesn't have direct support to link C++ runtime statically, like libc++_static
https://github.com/facebook/buck/issues/741

Hi @splhack , I check the cxx_binary in https://buckbuild.com/rule/cxx_binary.html, it said use strip-debug or strip-non-global flavors can strip the debug symbols. however when I run it through
buck build //java:jni#android-armv7,strip-debug,shared or
buck build //java:jni#android-armv7,strip-non-global,shared
the generated library is always not stripped.
file buck-out/gen/java/jni#android-armv7,shared,strip-non-global/libyoga.so
buck-out/gen/java/jni#android-armv7,shared,strip-non-global/libyoga.so: ELF 32-bit LSB shared object, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /system/bin/linker, BuildID[sha1]=29cf1aa8ddf3258760dfc0eae212427a122f4bb9, not stripped
is this expected result?

maybe that feature wasn't implemented yet in buck ndk shared library target. arm-linux-androideabi-strip -g instead.

@splhack many thanks, it works now.

When I try to run
buck build //java:jni#android-armv7,shared
buck says:

BUILD FAILED: Unrecognized flavor in target //java:jni#android-armv7,shared while parsing //java/BUCK
Here are some things you can try to get the following flavors to work::
android-armv7 : Make sure you have the Android SDK/NDK installed and set up. See https://buckbuild.com/setup/install.html#locate-android-sdk

Closing this as we have buck/gradle building these for android in the sample app. jcenter/maven dependencies are being deployed. Expect them early next week.

Having it in jcenter will make a lot of people very happy. Thanks for that.

@emilsjolander  is jcenter ok ?


cookbook installs outdated version

Cookbook version
3.2.5
Chef-client version
# etcdctl -v
etcdctl version 2.2.2

Platform Details
# cat /etc/*-release
CentOS Linux release 7.2.1511 (Core)
NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"

CentOS Linux release 7.2.1511 (Core)
CentOS Linux release 7.2.1511 (Core)

Scenario:
I'm installing an etcd cluster with DNS discovery.
Due to a bug in 2.2.2 etcdctl connects to wrong port.
Steps to Reproduce:
See discussion on https://groups.google.com/forum/?pli=1#!topic/etcd-dev/R4x9l7pi6fc
Expected Result:
etcdctl is updated to 2.3.7
Actual Result:
etcdctl version 2.2.2

Cookbook version 4.0 now install 2.3.7. The resource also allows you to install any version you want so you don't need to necessarily bring in the latest release of the cookbook in order to install a newer version of etcd. Check out the usage details in the readme.


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from  to before v5.10.84",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=74aafe99efb68f15e50be9f7032c2168512f98a8"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "74aafe99efb68f15e50be9f7032c2168512f98a8",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "drm/amd/amdkfd: Fix kernel panic when reset failed and been triggered again\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.10.84 by commit 74aafe99efb68f15e50be9f7032c2168512f98a8. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2021-1002482


Bug: Dot-notation not working as expected for nested values

Looks like if you have the following XML:
<root>
      <nested>
           <name>Sam</name>
      </nested>
      <name>Alex</name>
      <name>Taylor</name>
</root>

Then with the following reader code:
$reader->value('nested.name')->get();

Will return:

Sam
Alex
Taylor

Closing as I wasn't able to replicate it using the above example


Add "Dim Inactive Regions" setting to dim code inside undefined preprocessor directives

Is your feature request related to a problem? Please describe.
It's very hard to determine if a code block inside a preprocessor directive is compiled or not:

Describe the solution you would like
Add an option to dim the code inside undefined preprocessor directives.
Applicable Scenarios
Every C# code that uses preprocessor directives.
Describe alternatives you've considered
AFAIK there are no alternatives in Visual Studio Code.
Additional context

Visual Studio Community Edition has this feature
Visual Studio Code C++ extension has this feature (link) (link)

@yasirkula this should already be supported, would you mind providing the details listed here?
https://github.com/dotnet/vscode-csharp/blob/main/SUPPORT.md#colorization-problems

@dibarbet I'm using the Dark Modern theme that comes with the built-in vscode.theme-defaults v1.0.0 extension. Screen recording:
https://github.com/user-attachments/assets/996361b2-76b6-42ee-8f87-cf5052cd6f7c
I've noticed that the code looks dimmed in Visual Studio 2019 Light and Visual Studio 2019 Dark themes.
My VS Code version is as follows:
Version: 1.93.1 (system setup)
Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
Date: 2024-09-11T17:20:05.685Z
Electron: 30.4.0
ElectronBuildId: 10073054
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045

Thanks.  It looks like the server's semantic classification is working (it has the correct excludedCode for the semantic token type).  But it seems as though the Dark Modern theme doesn't provide any specific colorization for it.  Unfortunately, that theme is shipped by VSCode and we can't easily modify it.
I'd generally recommend using the VS 2019 dark/light themes we ship in the extension.  Otherwise, you can enable the correct colorization in the Dark Modern theme by adding the following to your settings.json:
"editor.semanticTokenColorCustomizations": {
    "rules": {
        "excludedCode": {
            "foreground": "#808080",
        }
    }
},

Closing this as this is the expected behavior.


Reflexive-transitive closure for well-founded relations

This change is

I did some stylistic changes.

Now, sfrel by default does not remove anything from the list that f returns.
I've added a notation for filter_neq
I've renamed some definitions. The function that computes the list of predecessors is called s_up_set for a strict upward set.
I've borrowed terminology from order theory. The intuition is the following. Given function f we can view it as a relation R. Then, our function, given some element x, computes the set of accessible elements of x, that is a set { y | x R^+ y }. That is an upper (upward) set of x.
Then the computational transitive and reflexive-transitive closures are named t_closure and rt_closure (without the _rel suffix as was before).

@dmitromikh @volodeyka have a look.
If you have any objections, please share it.


User's nickname required needed

We should add asterisk to Nickname field too.

Not sure what's happened here, but somehow there's a conflict. Perhaps fetch and rebase the develop branch

I manually added this to master.


Suggestion for "Downscaling" NIfTI volume for displaying in Niivue

Hi,
Thank you for continuing to develop and add features to Niivue—it’s a fantastic tool!
I’m currently using Niivue for a website that runs AI-based segmentation on CT/MRI images. Some of the volumes, after conversion to NIfTI, are quite large (200–300 MB is typical), which makes the Niivue interface slow, even on high-end hardware (my workstation is an i9 with an RTX 4090).
Do you have any suggestions for downscaling these volumes? I’d prefer a Python-based solution since my processing pipeline is already server-based.
Thanks again!

@thangngoc89 downsampling data depends a lot on your source images. For T1-weighted magnitude MRI scans of the brain, where the size of the object is known, the origin of the image is typically know (either iso-center or anterior commissure) and the image contrast falls into a narrow dynamic range, people often conform the data to UINT8 (voxel intensity 0..255,  scaling for 0..99% of voxel intensities) with 1mm isotropic is sufficient with a 256x256x256 resolution resulting in a compact 16mb image. The FreeSurfer executable mri_convert will conform data very rapidly, while niibabel provides a Python port.
Things are more tricky for CT - here the voxel intensity is scaled in Hounsfield units with air at -1000 and bone at +1000, with metal fillings much brighter. However, if you are interested in soft tissue, the difference in terms of intensity fills a tiny part of this dynamic range, with CSF, gray matter, white matter, and muscle all in the 0..50 range (with blood ~150 for images with contrast). So for CT, if you are only interested in bone, the UINT8 is sufficient, but for soft tissue you need to either clamp you window width or use higher precision (e.g. UINT16). The SNR of bone to other tissues is very high, so you will want to retain high spatial resoultion if you are interested in bone. On the other hand, the SNR of different soft tissues relative to each other is much lower for CT than a T1 scan, and therefore spatially downsampling makes sense. Further, with CT scans the DICOM origin is the table center, not the isocenter, so this varies a lot with different individuals (e.g. with height of participant). Therefore, you may want to use the volume center as your origin.
Another challenge is that different body parts may have fields of view. So the 1mm isotropic with 256^3 dimensions useful for T1 scans may not be suitable.
Downsampling data is challenging as one needs to avoid high frequencies aliasing as lower frequenceis. A common solution to this is to use trilinear interpolation (B = 1, C = 0) or even a Gaussian blur prior to resampling. Both of these remove high frequencies. I also like the Mitchell–Netravali filter where B = 1/3	and C = 1/3 which balances blurring to avoid aliasing and a mexican-hat kernel to retain high frequencies.
If you know the anatomy (e.g. head) and modality (e.g. CT without contrast), you can spatially normalize (coregister) every image to a common template of known resolution and dimensions. I would suggest ANTsPy as a nice Python wrapper for the robust and high performance (though slow) ANTS.
I do think that nibabel and ANTsPy provide the Python tools you need, but you will need to use them wisely depending on your source data and application.

Thank you for your very detailed answer. For context, I’m mostly dealing with dental CBCT. My first attempt was scaling to uint8 but I loss a lot of contrast and details. I will experiment with the techniques you mentioned. My aim is sub 30MB for most volumes.


Update to Tracy protocol 66

tin
updated for Tracy 0.11.0
tested & working
https://github.com/wolfpld/tracy/commit/133d52a6dd4e55a74947d1bfea1ef7919742d8d0
https://github.com/wolfpld/tracy/commit/41fc2930434bb2296cc8c255f82bcb731f8c0f06

There is no need to make changes in byond-tracy, we can maintain backwards compatibility
EventType enum used only for file decoding, when frames sended to tracy they use QueryResponseType enum as header marker

@Dimach as requested, tested and works with unmodified pbt

@checkraisefold  good job!


Current Weather Module 0° Bug

Platform: Rpi3
MagicMirror Version:  JavaScript version (v2).
Description: If the temperature is exactly 0.0° the currentweather module is suspended due to the poor checking mechanics of the initial if statement in processWeather (!data.main.temp).
It would be better to check for the pressure (data.main.pressure) instead of the temperature.

This should be fix in commit 93c07b2b1e2e4218d17ceead43b63509b6beb7e0
What version and branch are you using?
The previous change is in the develop branch. Are you using from the master branch?

sorry for your inconvenience ! I´m on the master branch - so yeah:D


1.17 Release?

Hi there, this mod currently does not work with the release of 1.17 and I was wondering if there are plans to update this mod so that it works with the full release of 1.17! I would like to use it in my personal server modpack.
Thank you in advanced for any responses!

yup - will be done eventually


Fine-tuning, ValueError: DistributedDataParallel device_ids and output_device arguments only work...

Hi,
trying for the 1st time to fine-tune colbert-ir/colbertv2.0 on my mac, an error is shown in the log:
ValueError: DistributedDataParallel device_ids and output_device arguments only work with single-device/multiple-device GPU modules or CPU modules, but got device_ids [0], output_device 0, and module parameters {device(type='cpu')}

My code is just the following, mostly copy/paste from the readme (I removed the all_documents arg)
trainer = RAGTrainer(model_name = "MyFineTunedColBERT",
        pretrained_model_name = "colbert-ir/colbertv2.0") # In this example, we run fine-tuning

# This step handles all the data processing, check the examples for more details!
trainer.prepare_training_data(raw_data=pairs,
                                data_out_path="../data/",
                                # all_documents=my_full_corpus
                                )

(pairs is a List of 3581 tuples such as:
('1234yf', "Le 1234yf est un bla bla...")

Here is the trace:
...
Using config.bsize = 32 (per process) and config.accumsteps = 1
[Jan 28, 14:42:04] #> Loading the queries from ../data/queries.train.colbert.tsv ...
[Jan 28, 14:42:04] #> Got 3581 queries. All QIDs are unique.

[Jan 28, 14:42:04] #> Loading collection...
0M
[Jan 28, 14:42:05] Loading segmented_maxsim_cpp extension (set COLBERT_LOAD_TORCH_EXTENSION_VERBOSE=True for more info)...
Process Process-5:
Traceback (most recent call last):
  File "/Users/fps/.pyenv/versions/3.10.11/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/Users/fps/.pyenv/versions/3.10.11/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/fps/.pyenv/versions/fps_env/lib/python3.10/site-packages/colbert/infra/launcher.py", line 128, in setup_new_process
    return_val = callee(config, *args)
  File "/Users/fps/.pyenv/versions/fps_env/lib/python3.10/site-packages/colbert/training/training.py", line 55, in train
    colbert = torch.nn.parallel.DistributedDataParallel(colbert, device_ids=[config.rank],
  File "/Users/fps/.pyenv/versions/fps_env/lib/python3.10/site-packages/torch/nn/parallel/distributed.py", line 603, in __init__
    self._log_and_throw(
  File "/Users/fps/.pyenv/versions/fps_env/lib/python3.10/site-packages/torch/nn/parallel/distributed.py", line 769, in _log_and_throw
    raise err_type(err_msg)
ValueError: DistributedDataParallel device_ids and output_device arguments only work with single-device/multiple-device GPU modules or CPU modules, but got device_ids [0], output_device 0, and module parameters {device(type='cpu')}.

This didn't stop the execution, which seems to be continuing (without any new output)

Ah, sorry, only now that I see https://github.com/bclavie/RAGatouille/issues/69 : no support of CPU for training


build: require java 17+ and update readme

MC 1.18+ require java 17+
Update readme accordingly and replace old links

This does however bring up the issue of the CI running gradle with Java 11, which is a bit redundant since 17 will have to be downloaded by Gradle anyways.
You should be able to add a runtime_version: 17 to the with: block on all the shared workflow actions used in SpongeAPI to avoid that.


Error: Unable to find a valid app

nativefier --name "Wechat" "https://wx.qq.com/"
sudo electron-installer-debian --src /home/deepin/wechat-linux-x64/ --dest /home/deepin/wechat --arch amd64
3 . sudo dpkg -i wechat_1.0.0_amd64.deb

deepin@deepin:~$ /usr/lib/wechat/wechat
But I Dclick /usr/lib/wechat/wechat is running，Dclick desktop file is not running.
A JavaScript error occurred in the main process
Uncaught Exception:
Error: Unable to find a valid app
    at Object.<anonymous> (/usr/lib/wechat/resources/electron.asar/browser/init.js:121:9)
    at Object.<anonymous> (/usr/lib/wechat/resources/electron.asar/browser/init.js:173:3)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:431:7)
    at startup (bootstrap_node.js:155:9)

@jingle0927 if the nativefied app runs but no longer does after being packaged by electron-installer-debian, then you should ask electron-installer-debian people, not Nativefier. When you do so, providing the text contents of the .desktop file will certainly help.


Implement em::findAndCount and repository::findAndCount method

Is your feature request related to a problem? Please describe.
The problem is just to implement paging that requires totalCount as well as items in paging window.
Now i need to send 2 separate queries and write 2 where conditions that causes boilerplate. Also some databases (like mysql) allow to calculate total count in more efficient way.
Describe the solution you'd like

Implement em::findAndCount method that will return Pormise<[T[], totoalCount]>

Just tried postgres specific way to do this in single query (via over()) and it performs really badly on large tables (millions of rows). I do not have such database in mysql to test it, but I can imagine it won't be worth it to implement it... Let's start with simply doing 2 queries in the background, it is much simpler to implement than supporting driver specific ways to achieve this, sometimes via one query (postgres), sometimes via two (even mysql requires to do 2 queries, and they have to be ran against same connection, so effectively wrapped in a transaction from knex' perspective).

Available for testing in 3.0.0-alpha.16.


Error with loader.png

Hi @cajames !
I am experiencing an error with loader.png

Can you reproduce the issue?

Hey @mynameisfreedom! Oh, that's interesting. Though I haven't released any updates and it used to work before right?
Did you upgrade your version of Kirby or the Editor? What version are you using?
I just tested it on Kirby 3.3.6, with the editor (probably not the latest version), and it seem to work fine.

I've also just tested it on the latest Kirby 3.4.2, with the latest Editor 1.0.4, and it seems to work fine. Could you please let me know what versions you're using?

Hi, @cajames sorry for the delay.
It is happening from the beginning, I just didn't see it though.
I am using all the latest versions, and Kirby, and your Gallery block.
But, as you can see from the screenshot, issue happens when Kirby website installation is in the subfolder.
Add install to the subfolder and test.

I had the same problem. For compatibility reasons I had to change the Kirby folder from "media" to "resources". No problem with Kirby and Kirby Editor.
The image "loader.png" is not found under /media/plugins/...
@mynameisfreedom: you use a sub folder. the file is under /zero-one/media/plugin/...
https://github.com/cajames/kirby-editor-gallery-block/blob/ef56d8695a1f66765d0d9142db075dde6368a024/src/components/Gallery.vue#L51
My simple solution https://github.com/zufallswerk/kirby-gallery/commit/22f0d652d592a43b8651ab872aca3b545f3c9c6c was to change the URL in the plugin. But this is not a good solution. But I have no other one at the moment.


Soundscape goes quiet in the background

Sometimes, when using Soundscape with the screen locked, after a few minutes of updates I'll stop hearing any callouts. I was attributing this to intermittent connectivity issues, but now I'm thinking it might be an iOS 16.4+ change in the location services API, based on this discussion I came across: https://developer.apple.com/forums/thread/726945
Sorry I don't have more specific reproducibility steps, but has anyone else experienced this phenomenon?

Myself and @StevenAbrams have definitely seen this before. We did spend quite a bit of time investigating this going back probably at least 3 years, and it was very hit and miss so we never got a concrete answer as to what was going on.
Sometimes it would work perfectly for hours on end, but sometimes callouts would appear to stop until we unlocked the phone and brought Soundscape to the foreground.
Given the iOS 16.4 change, so it I would think it warrants looking at again. I will see if I can reproduce it, and see if I can get a sense for whether it is more frequent than and used to be, suggesting something may have change since our original investigation.


Use a CP check for whether a dependency is a dev pod

To quote the Core:
    # @return [Bool] whether the dependency points to an external source.
    #
    def external?
<EMAIL_ADDRESS>    end

    # @return [Bool] whether the dependency points to a local path.
    #
    def local?
      if external_source
        external_source[:path]
      end
    end

I think the usage of external? is returning a wider net than you wanted, at least I couldn't use CocoaPods Check on artsy/eigen
Specs still pass:
~/d/r/l/cocoapods-check (master) ⏛  rake spec
/Users/orta/.rvm/rubies/ruby-2.1.3/bin/ruby -I/Users/orta/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.4.4/lib:/Users/orta/.rvm/gems/ruby-2.1.3/gems/rspec-support-3.4.1/lib /Users/orta/.rvm/gems/ruby-2.1.3/gems/rspec-core-3.4.4/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
.....

Finished in 2.04 seconds (files took 0.14975 seconds to load)
5 examples, 0 failures

Yep, thanks!


Extensions: decorators

Description
My demonstration of decorators in the extensions file.
I have implemented it on one of the example tutorials.
If we're happy with it I think we will have two further issues:

Decorators behaviour, where further functions are added in extensions (e.g., extend.surface, etc.)
Decorators notebook, where we update existing tutorials with this new usage (they need updating anyway)

I think we will also want a notebook for extensions in general, but for me it makes sense to do this after we support subclasses via it.

Supersedded by #101


Automated cherry pick of #1050: ucloud image upload bugfix & storage type fix

Cherry pick of #1050 on release/2.10.0.
#1050: ucloud image upload bugfix & storage type fix

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.10.0@114534b). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release/2.10.0   #1051   +/-   ##
================================================
  Coverage                  ?   7.91%
================================================
  Files                     ?     356
  Lines                     ?   56372
  Branches                  ?       0
================================================
  Hits                      ?    4464
  Misses                    ?   51514
  Partials                  ?     394

Flag
Coverage Δ

#aFlag
7.91% <0%> (?)

Impacted Files
Coverage Δ

pkg/util/ucloud/zone.go
0% <ø> (ø)

pkg/util/ucloud/host.go
0% <0%> (ø)

pkg/util/ucloud/storagecache.go
0% <0%> (ø)

pkg/util/ucloud/instance.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 114534b...de02c85. Read the comment docs.

/hold
原PR #1050 有变化，需要再次执行cherrypick

/hold cancel
/approve
/lgtm


Add OpenTelemetry variables to manifest files

Context

Add OTel env vars to manifest template files

This is to setup observability (X-Ray) for services.

Looking good, my only wonder is if this might get expensive if we enable for everything?

@acodeninja Would you suggest enabling on the web/public facing services as a default?

@acodeninja Would you suggest enabling on the web/public facing services as a default?

I reckon we should to start off with, from my understanding though this will not be enabled unless the process is prefixed with the otel collector application.


an error like "unauthorized: authentication required" occured always

docker-compose version:
docker-compose version 1.8.1, build 878cff1
docker-py version: 1.10.3
CPython version: 2.7.9
OpenSSL version: OpenSSL 1.0.1e 11 Feb 2013
docker version:
Docker version 1.10.3

when I push an image to harbor, an error like "unauthorized: authentication required" occured always.
The username and password is right and the project is always existed also.
The logs like below:
2017-03-13T09:54:24Z [INFO] request url: /service/token?scope=repository%3Aswarm001%2Fjavatest2%3Apull&service=token-service
2017-03-13T09:54:24Z [WARNING] Failed to get secret cookie, error: http: named cookie not present
2017-03-13T09:54:24Z [DEBUG] [token.go:53]: uid for logging:
2017-03-13T09:54:24Z [DEBUG] [authenticator.go:57]: Current AUTH_MODE is db_auth
2017-03-13T09:54:24Z [DEBUG] [authenticator.go:69]: Login failed, locking , and sleep for 1.5s
2017-03-13T09:54:25Z [WARNING] login request with invalid credentials in token service, uid:
2017-03-13T09:54:25Z [DEBUG] [token.go:63]: username for filtering access: .
2017-03-13T09:54:25Z [INFO] current access, type: repository, name:swarm001/javatest2, actions:[pull]
2017-03-13T09:54:25Z [DEBUG] [notification.go:107]: receive an event:
----ID: bdf25c07-1fa4-4653-ad41-2dccce093add
----target: swarm001/javatest2:v20170313.1725
----digest: sha256:e6da445c1549e5d0917d59d2b7d334b51eb360e09012acbf593a06bd36c5660e
----action: pull
----mediatype: application/vnd.docker.distribution.manifest.v2+json
----user-agent: docker/1.10.3 go/go1.6.3 git-commit/cb079f6-unsupported kernel/3.10.0-327.28.3.el7.x86_64 os/linux arch/amd64
2017-03-13T09:54:24Z [INFO] request url: /service/token?scope=repository%3Aswarm001%2Fjavatest2%3Apull&service=token-service
2017-03-13T09:54:24Z [WARNING] Failed to get secret cookie, error: http: named cookie not present
2017-03-13T09:54:24Z [DEBUG] [token.go:53]: uid for logging:
2017-03-13T09:54:24Z [DEBUG] [authenticator.go:57]: Current AUTH_MODE is db_auth
2017-03-13T09:54:24Z [DEBUG] [authenticator.go:69]: Login failed, locking , and sleep for 1.5s
2017-03-13T09:54:25Z [WARNING] login request with invalid credentials in token service, uid:
2017-03-13T09:54:25Z [DEBUG] [token.go:63]: username for filtering access: .
2017-03-13T09:54:25Z [INFO] current access, type: repository, name:swarm001/javatest2, actions:[pull]
2017-03-13T09:54:25Z [DEBUG] [notification.go:107]: receive an event:
----ID: bdf25c07-1fa4-4653-ad41-2dccce093add
----target: swarm001/javatest2:v20170313.1725
----digest: sha256:e6da445c1549e5d0917d59d2b7d334b51eb360e09012acbf593a06bd36c5660e
----action: pull
----mediatype: application/vnd.docker.distribution.manifest.v2+json
----user-agent: docker/1.10.3 go/go1.6.3 git-commit/cb079f6-unsupported kernel/3.10.0-327.28.3.el7.x86_64 os/linux arch/amd64

It appears the request goes to token service didn't carry a valid basic auth header.
Did you run docker login?

yes, i'm sure that I have logined everytime.

Is it installed via a offline installer?
Could you repeat the steps, and paste the commands you used?
docker login, docker push

Hi any update?

Closing due to inactivity.


⚠ Bofrost.es has degraded performance

In 7c4e5b8, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1677 ms

Resolved: Bofrost.es performance has improved in 537b013 after 26 minutes.


fix: fix a possible bug in msgext-python to avoid none summary

workitem: https://msazure.visualstudio.com/Microsoft Teams Extensibility/_workitems/edit/27587429
local debug project
in ME search input box, input "teamsapp" and select "TeamsApp" in the dropdown list. It will get error message in terminal

Build status - All builds passed
https://github.com/OfficeDev/Microsoft-Teams-Samples/actions/runs/8658138002


ECMAScript export issue

Hello,
I'm using your solution from npm version 1.0.2.
First of all, I've tried to run the example ECMAScript by using
node --experimental-modules test.mjs

with output:
~/workspace/temp node --experimental-modules test.mjs
(node:16043) ExperimentalWarning: The ESM module loader is experimental.
file:///home/michal/workspace/temp/test.mjs:1
import { AesCmac } from 'aes-cmac';
         ^^^^^^^
SyntaxError: The requested module 'aes-cmac' does not provide an export named 'AesCmac'
    at ModuleJob._instantiate (internal/modules/esm/module_job.js:79:21)

After some troubleshooting I've realized that there might be some issue with exporting.
This code:
import AesCmac from "aes-cmac";

const key = Buffer.from('2b7e151628aed2a6abf7158809cf4f3c', 'hex');
const msg = Buffer.from('6bc1bee22e409f96e93d7e117393172a', 'hex');

const algorithm = new AesCmac.AesCmac(key)

console.log(algorithm.calculate(Buffer(msg)).toString('hex'));

Returns proper NIST test vector output:
~/workspace/temp node --experimental-modules test.mjs
(node:16330) ExperimentalWarning: The ESM module loader is experimental.
070a16b46b4d4144f79bdd9dd04a287c

Please throw an eye if ES6 export works well - if so, mind you to somehow introduce me where may be the issue on my site?
Regards.

Hello,
It seems to work for me with node@16. What version of node you use, please?
$ cat test.mjs
import { AesCmac } from "aes-cmac"

const key = Buffer.from('2b7e151628aed2a6abf7158809cf4f3c', 'hex');
const msg = Buffer.from('6bc1bee22e409f96e93d7e117393172a', 'hex');

const algorithm = new AesCmac(key)

console.log(algorithm.calculate(msg).toString('hex'));

$ node test.mjs
070a16b46b4d4144f79bdd9dd04a287c

Seems that you've got me - sorry, still beign a rookie with web dev.
Got the Node@10 since the repository I'm aiming to contribute uses it.
~/workspace/temp node -v
v10.19.0

Anyway, thanks for clarification where the problem may be!
Cheers!


Use range types for some parameters?

Such as imageRotate.degrees, imageColorContrast.contrast, imageColorBrightness.brightness, colorBrightness.factor, colorContrast.contrast, etc.
On the other hand https://status-im.github.io/nim-style-guide/language.range.html advises to avoid range types...

distinct range can work better maybe?.  Less ergonomic but solves some of the linked issues.


Snapshot and revert should handle a replica go bad during the operation

Snapshot and revert operations both assume all replicas are good. It should handle the situation a replica goes bad during the operation. As long as there's one good replica, the operation should succeed. Otherwise it is very difficult for the user to check for errors and recover.
If we are making snapshot and revert resilient to replica errors during the operation, we might as well make them work if there are bad replicas before the operation starts. This makes the whole operation a lot easier to use.

Snapshot has it all fixed at: https://github.com/rancher/longhorn/commit/e85cfa5cbdceb01260b544a44c6bb6bde5b9658b
Revert should be fixed at: https://github.com/rancher/longhorn/commit/1557011b05730942260550fee9afa0b7590ae61e but we need test case for it.


[REQUEST] API key description

Would it be possible to add a description parameter for confluentcloud_api_key resource?

@petern-sc added this in #27 :)


plot tests: ensure all figures are closed

Test testxyincrease_false_changes_axes is flaky in nature.
TestCase passes consistently in the actual order with command:
pytest tests/test_plot.py

TestCase fails when one randomises the order in test_plot.py module by using the plugin pytest-random-order with command:
pytest tests/test_plot.py --random-order-seed=802425 -v

The victim test_xyincrease_false_changes_axes fails in a failing test order because there is at least one test that runs before the victim and “pollute” the state (e.g., global state: here, it is matplotlib's plt) on which the victim depends. (Paper)
After investigation, we found the polluter test to be test_ylim_kwarg
Potential Fix: Adding a plt.clf or plt.cla at the end of the polluter test. Let us know your preference.
Please let us know if you require the pass and fail logs.
Also, if one runs test_plot.py in any random order, Teardown phase throws an error which is raised by test_all_figures_closed().
Should I raise a separate PR for the same?
Contributors:
Yash Saboo
Nirupam K N

Thanks for looking into this. Yes, closing the figure at the beginning is brittle, unless every test does it. However, it cannot be done at the end because else the figure is not closed if there is an error in the test (and the figure is still open at the start of the next test).
My preference is to enclose the test in a figure_context as already done for some of the tests:
https://github.com/pydata/xarray/blob/9533c92c675a30b8c9803da8d5c9bc529763f3eb/xarray/tests/test_plot.py#L2456-L2457
figure_context is a small context manager that wraps a try: ... finally  block, closing all open figures.
https://github.com/pydata/xarray/blob/9533c92c675a30b8c9803da8d5c9bc529763f3eb/xarray/tests/test_plot.py#L49
I think all plt.clf() instances should be replaced with figure_context. I missed those in my PR (#4365). Let us know if you are up to that.
cc @dcherian

Thanks a lot for the feedback.
We have addressed all the above issues and made the necessary changes. Please let us know your thoughts on these new changes.

Thanks! There are two more instances that would be good to wrap in a figure_context.
https://github.com/pydata/xarray/blob/a28f0df559cf5a18fce6c4a78277d3ef60898c0f/xarray/tests/test_plot.py#L316
https://github.com/pydata/xarray/blob/a28f0df559cf5a18fce6c4a78277d3ef60898c0f/xarray/tests/test_plot.py#L1759
If you want you can also give yourselves credit in whats-new.

Thanks a lot again for the feedback. Appreciate it! We have made the necessary changes.

how thorough should this be? If I understand it correctly, there are still a few calls left, e.g. in test_plot_transposed_nondim_coord (hidden by getattr calls).

Good catch! If you haven't lost patience, there are two more things that leave open figures: test_plot_transposed_nondim_coord and some of the tests in TestDiscreteColorMap.

To fix the first both of these lines need to be enclosed in a figure_context (each line separately):

https://github.com/pydata/xarray/blob/f1e2f9d510a63480f4dd7917083cd982ac4d451d/xarray/tests/test_plot.py#L2431-L2432

To fix the second you can add the following code

        yield
        # Remove all matplotlib figures
        plt.close("all")

after the following line:
https://github.com/pydata/xarray/blob/f1e2f9d510a63480f4dd7917083cd982ac4d451d/xarray/tests/test_plot.py#L964
And you should give yourselves credit in what's new. That's now more than a one-liner ;-)

Just as an addendum. The figures in the PlotTestCase class are autoclosed by
https://github.com/pydata/xarray/blob/f1e2f9d510a63480f4dd7917083cd982ac4d451d/xarray/tests/test_plot.py#L128-L133
but only if no more than one figure is opened per method.

Thanks, @keewis for bringing that point up. We were aware of test_plot_transposed_nondim_coord polluter but were still investigating the test cases it was polluting. FYI, you can try this --random-order-seed=846619. Please feel free to give more suggestions. Highly appreciate it!
@mathause, we have implemented all of the above changes. Thanks a lot again! :)

I am not sure why the check was unsuccessful. It says that the action in CI was terminated.
I opened a new PR for the new amends here. I closed it since it would be taken care here itself. Can that be the cause? I reopened it later though.

Sounds good @mathause. Thanks again! :)

Thanks @yashsaboo ! Great to have you as a contributor!

This closes all figures at the end of the tests. I'll merge in a few days to see if others have comments.
I changed the title of the PR. Let me know if you object.

@mathause @keewis Thanks a lot for all your feedback!
I and @yashsaboo enjoyed working on this! And it was our first open source contribution! Hope to contribute more!

@Nirupamkn @yashsaboo do you want to add an entry to the whatsnew file?

@Nirupamkn @yashsaboo do you want to add an entry to the whatsnew file?

Yeah sure! @max-sixty
Is there any specific procedure to do it? or Just have to write 2 lines writeup at the end?

Yes exactly, under "Internal Changes"

Thanks @max-sixty!! We have updated the whats-new file too now.

Ok. let's get this in before the release. Thanks again @Nirupamkn @yashsaboo, happy to have you as contributors!

It was our pleasure. Thanks @mathause for all the help! :)


topic_based_ros2_control: 0.1.0-2 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository topic_based_ros2_control to 0.1.0-2:

upstream repository: https://github.com/PickNikRobotics/topic_based_ros2_control.git
release repository: https://github.com/PickNikRobotics/topic_based_ros2_control-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: null

topic_based_ros2_control
* Fix joint state for mimic joints & expose epsilon parameter (#7 <https://github.com/PickNikRobotics/topic_based_ros2_control/issues/7>)
  * Check the difference between command and current joint state to stop command publication
  * Set mimic joints values
  * Move magic numbers to constants
  * Remove last_position_command_ variable
* Replace Isaac with TopicBased and generalize package (#5 <https://github.com/PickNikRobotics/topic_based_ros2_control/issues/5>)
* Clean up documentation (#4 <https://github.com/PickNikRobotics/topic_based_ros2_control/issues/4>)
* Removed unused node. (#3 <https://github.com/PickNikRobotics/topic_based_ros2_control/issues/3>)
* Add issac ros2 control hardware interface (#1 <https://github.com/PickNikRobotics/topic_based_ros2_control/issues/1>)
* Contributors: Alex Moriarty, Giovanni, Jafar Uruç

Humble is currently being held for sync. Once the hold is released this change can be merged.


ES6 support

With the recent changes to how our Gulpfile compiles/run apps and tests, adding other languages/versions shouldn't be too difficult anymore.
ES6 support using 6to5 or Traceur - maybe offer either as an option when the user selects ES6. Gulp should also inject these into index.html during the build process. I'm not sure if wiredep automatically adds these first, so might need to manually add them to the beginning of injected scripts.
Since we'd want to make it obvious these files are using ES6, it might be wise to use an .es6 extension. (Research what others are doing. AtScript project might have some suggestions.) We'll definitely want to use something like .es6 on the ng-poly side for storing the templates.

This would be very cool
+1

+1 for 6to5 support

e20287f79485418637a1e77f47b3b8479b44a211 implemented using Babel (6to5). Not going to worry about Traceur at the moment because Babel seems to be to the go-to.


fix a bug when running in Python 3.10 above

The current solution to obtain Python version is not correct when the version is more than 3.9, this fixes the problem

已收到邮件  阿里阿豆故咋一马斯！如未及时回复，请致电15868848097  QQ：812737452


voice distribution: note offs from DAW not registered?

experienced this recently:

make a midi clip in reaper with a bunch of notes. this was a monophonic Maj7 patch, some kind of arp-like thing, probably all overlapping notes
put this clip on repeat
eventually, when i stopped playback, the note kept playing.

some note-off had not been registered at some point. because i never experienced this with other synths, seems something wrong with our voice distribution

i believe this is fixed with commits from the past days; buffer overruns were causing corruption leading to mIsPedalDown being stuck on. If I recall, this proc'd after saving the song, which would have been the condition to overflow the event buffer. And i had to restart the DAW to correct it, again the symptom of the buffer overrun.


feat(Locomotion): translate play area jump into game jump

Adds the player jump script, and demo scene 039 to exercise it.

Sometimes you have to nuke it from orbit, just to be sure.

SO IT IS ASKED.....SO IS IT DONE!
( i think ).  Also, do you prefer amends only for these feature branches, or could I just have made a separate commit?

all the code looks good, i'll check out the PR a bit later and give it a test to give it the final check

Just realised, you need to make sure your master branch is up to date.
There is already a example scene 39. i think the next available one is 41 now

I'm also struggling to get this consistently working. may be worth getting some others to check out the PR for some feedback. I'll post in the slack channel

did you forget to do a rebase?
you have a "lot" of extra commits :(

No, I rebased.  These are whitespace errs, I think.  I asked for a rebase --whitespace=fix
I am going to have to scale back my ambitions for open source contribution at this rate!  I may just start again.  It is far easier to copy the code in than to f-around with all the minute conflicts.

I guess I am mistaken.  Whatever.  Time to get mopping

Sometimes it is easier to just start on a fresh branch and copy the changes over. I do that all the time :)


System Access Violation when exiting "using" statement

When closing the application I get an exception on the "using" statement of the Program class of the WPF application  - Any idea if where I am going wrong?
public class Program     {         [System.STAThreadAttribute()]         public static void Main()         {             using (new UWPMapperApp.App())             {                 WpfMapper.App app = new WpfMapper.App();                 app.InitializeComponent();                 app.Run();             }  *** exception occurs here         }     } }
System.AccessViolationException
HResult=0x80004003
Message=Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Source=
StackTrace:

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc7ec471-9257-39ba-173b-eb7973f4c360
Version Independent ID: 3e07d5f0-8b19-2ef4-dc2a-48659f42c12e
Content: Host a custom WinRT XAML control in a WPF app using XAML Islands - Windows apps
Content Source: hub/apps/desktop/modernize/host-custom-control-with-xaml-islands.md
Product: reunion
Technology: apps
GitHub Login: @Karl-Bridge-Microsoft
Microsoft Alias: kbridge

Hi @dchillman123 - as this isn't a doc issue, try posting your question at https://docs.microsoft.com/en-us/answers/index.html.
Thanks


Add sdio apis to common io.

Add sdio apis to common io.
Description

Checklist:

[x] I have tested my changes. No regression in existing tests.
[ ] My code is Linted.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Unable to amend.  Abandoned and create new one.

Unable to amend. Abandoned and create new one.

When you amend the commit, it overrides the existing commit and then your local and remote diverges. That’s why you do a force push to override remote as well.
A better approach is to just do normal commit in the PR. To clean the commits history, we do “squash and merge” as the final step.


Cirrus: Disable master-success IRC notices

Since on_failure notification is working, and IRC activity
is picking up, these messages mostly just get in the way.
Leave the PR-testing success messages in place for now,
since they're helpful when someone's waiting.
Signed-off-by: Chris Evich<EMAIL_ADDRESS>

@vrothberg PTAL

Awesome! Thanks a lot, @cevich :pray:

LGTM

/approve

/LGTM


Filter conditions are discarded when using multiple filter conditions in similarity_search_with_relevance_scores

System Info
Windows 10
Python 3.11.5
langchain==0.0.331
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
I want to do a similarity search on a vectorstore created beforehand and use multiple filtering conditions. The relevant part of the code is as follows:
from langchain.vectorstores import Chroma
from langchain.embeddings import SentenceTransformerEmbeddings
import chromadb

db_path = "my_db"

embeddings = SentenceTransformerEmbeddings(cache_folder='intfloat/multilingual-e5-large')
chroma_client = chromadb.PersistentClient(path=db_path)

db= Chroma(persist_directory=db_path, embedding_function=embeddings, client=chroma_client)

query = "My query"

filtered = db.similarity_search_with_relevance_scores(k=5, query=query, filter={"key1":value1, "key2":value2})

When using one filtering condition like
filtered = db.similarity_search_with_relevance_scores(k=5, query=query, filter={"key1":value1})

the filtering condtion is applied and it works fine. But when using multiple conditions, neither of the conditions is applied.
How can I use multiple filtering conditions?
Expected behavior
I would expect, that both conditions are applied either connected by an "and" or an "or".

@ dosubot can you help me with a query for 3 keys -  2keys with "and" and one key with "or"


Enable category selection for non dynamic widgets

Fixes https://github.com/CartoDB/support/issues/890#issuecomment-325933518
Made under the Response Team umbrella.

retest this please


Always return pointer object on indexing

Currently indexing to a non exiting group shows to distinct behaviors.  If the file exists a new pointer object is returned and writing to it will create the group. If the file does not exist None is returned.  This patch makes both cases return a pointer object which creates the underlying file/group once written to it.  Imo this is more convenient for downstream users because otherwise they need to maintain separate code paths for creating new groups in existing and non existing files, since there are no methods to force creation of an empty group (what would be create_group in pyiron_base speak).

======================================================================
FAIL: test_empty_file_root (test_pointer.TestPointer)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/h5io_browser/h5io_browser/tests/test_pointer.py", line 42, in test_empty_file_root
    self.assertIsNone(p["test"])
AssertionError: <h5io_browser.pointer.Pointer object at 0x7fb8e3287a30> is not None

----------------------------------------------------------------------


Update geopandas and other libraries to newer version

V1.2 tests did all execute successfully after lib update


WebJobs: Display log entries from logs stored in blob or table storage

As per this discussion on StackOverflow, I'm opening up a feature request issue.
At https://[mysite].scm.azurewebsites.net/azurejobs/#/jobs/continuous/[myjob] the log output is limited to X number of lines, then you receive this message:

Reached maximum allowed output lines for this run, to see all of the job's logs you can enable website application diagnostics

Enabling website application diagnostics indeed give me the full job logs, in my table storage, but I still can't see the log output at the above mentioned address.
It would be nice to be able to configure where the WebJob Details site pulls its logs from, so that I can keep monitor my WebJobs through that site, even though they are continuous.

+1

:+1:

+1

+1

+1

+1

+1

+1

+1

+1

+1

Hi
Kudu will continue to run in Azure App Service. However, this repo will no longer be maintained.
If the problem persists and is related to running on Azure App Service, please open a support incident in Azure:
https://learn.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request
This way we can better track and assist you on this case
Thanks,
Joaquin Vano
Azure App Service


bug: CoreGrid same props are called multiple times

Description
Need to filter the props that are used multiple times and make all those types in a single prop.

this issue has been opened by mistake so i am closing it


Fix use of errno in SystemError

Calling errno inside SystemError.description() is far too late and will almost always return the wrong error number. Instead, pass the errno at the throw site, which is consistent with how most of the other SystemError throws work.

@swift-ci please test

I think we should continue to check for a return value of -1 before we consult errno.

I think we should continue to check for a return value of -1 before we consult errno.

Only return values of 0 and -1 are defined in POSIX. So what value we should be using instead for a theoretical -2 is unclear to me.
RETURN VALUES
     Upon successful completion, a value of 0 is returned.  Otherwise, a value
     of -1 is returned and the global integer variable errno is set to
     indicate the error.


webpack hot-updates are not being applied in<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Vue.js version
2.0.0.rc-3
Reproduction Link
Check this repository link
Steps to reproduce

Run repository project.
Open http://localhost:8080 in the browser
You should see "Change me"
Change the text in file app/assets/javascripts/App.vue and save. Webpack should detect the change and rebuild the bundle.

What is Expected?
Change should be reflected when hot-update is applied.
What is actually happening?
You can see the hot-update js file being injected into the HEAD but no changes are being applied to the DOM

https://github.com/vuejs/vue/wiki/Vue-2.0-RC-Starter-Resources#standalone-vs-runtime-builds
Read that whole section.

Thanks @LinusBorg for the answer.
I used 'vue/dist/vue.js' instead of just 'vue' because it gives me the following warning:
[Vue warn]: Failed to mount component: template or render function not defined. (found in root instance)
And the components is not rendered at all.

Configure the alias per instructions in the link and it should work as expected.

@yyx990803, I made that change and it keeps doing the same thing. hot-update is not applied to the element.
Correct me if I'm wrong, but In this configuration, I'm using vue-loader with webpack, so all the templates should be compiled to render functions already and I can use the runtime-only version of Vue, right?
I have a working version with beta-7. I will upload that to the repository for comparison.

@gbisheimer where did you get this setup from? It seems it's a custom-modified version of the webpack template, but it's most likely not configured correctly instead of a bug.

@yyx990803
Here I uploaded a working version with beta.7.
I used vue-cli output project as base but I modified it a little bit to integrate it into a rails project.

It seems related to vue and vue-loader. If you use the master branch of the reproduction repo and replace the node_modules/vue and vue-loader folders with the ones in working-beta-7 branch, it works as expected.
Nothing else was modified.

Just replacing vue-loader is incorrect, because npm3 installs flat deps and without replacing those you are creating version mismatches. I would

remove the vue-html-loader, vue-style-loader, vue-hot-reload-api deps since they are not needed for latest vue-loader. They are now deps of vue-loader itself.

Make sure you have the alias configured correctly.

Remove node_modules and re-install everything fresh.

I'll close this because a modified setup involves too many variants that we may not be responsible for - it would be a different matter if the same can be reproduced in an official 2.0 template. If the problem persists, please try to further narrow down the issue and open issue at vue-loader.


add image.repository Value for memcached

Allow image.repository for memcached much like already done for "quay.io/weaveworks/flux:1.10.0".
This could be included with a PR that addresses: https://github.com/weaveworks/flux/issues/1716 for memcached.

Memcached has a repository option: https://github.com/weaveworks/flux/blob/master/chart/flux/templates/memcached.yaml#L26

Ah, perfect! This option would be great to include in: https://github.com/weaveworks/flux/tree/master/chart/flux#configuration


Nomination of @fg-j as a contributor

In keeping with the Paketo Buildpacks Governance document, I am nominating @fg-j as a contributor to the Paketo Website/content repositories.
@fg-j has contributed to different docs pages and formatting files over time, for example adding answers to a number of FAQs on the website.

@ForestEckhardt @kvedurmu bumping this thread

@ForestEckhardt @kvedurmu bumping this thread

We have reached a super majority. Congrats to @fg-j, we will get you add as a contributor ASAP!

We have reached a super majority. Congrats to @fg-j, we will get you add as a contributor ASAP!