Error when colorscheme does not set a background

I'm getting this error with the latest version:
Error detected while processing /home/aguth/.config/nvim/init.lua:
E5113: Error while calling lua chunk: /home/aguth/.config/nvim/lua/colorschemes/gruvbox-nvim.lua:42: /home/aguth/.config/nvim/init.lua..nvim_exec() called at /home/aguth/.config/nvim/init.lua:0..ColorScheme Autocommands for "*": Vim(append):Error
executing lua callback: /home/aguth/.local/share/nvim/lazy/bg.nvim/plugin/bg.lua:11: bad argument #2 to 'format' (number expected, got nil)
stack traceback:
        [C]: in function 'format'
        /home/aguth/.local/share/nvim/lazy/bg.nvim/plugin/bg.lua:11: in function </home/aguth/.local/share/nvim/lazy/bg.nvim/plugin/bg.lua:9>
        [C]: in function 'cmd'
        /home/aguth/.config/nvim/lua/colorschemes/gruvbox-nvim.lua:42: in main chunk
        [C]: in function 'require'
        /home/aguth/.config/nvim/init.lua:35: in main chunk
stack traceback:
        [C]: in function 'cmd'
        /home/aguth/.config/nvim/lua/colorschemes/gruvbox-nvim.lua:42: in main chunk
        [C]: in function 'require'
        /home/aguth/.config/nvim/init.lua:35: in main chunk
Press ENTER or type command to continue

vim.api.get_hl_by_name("Normal", true) returns { foreground = 15457202 } for my colorscheme (gruvbox.nvim), so bg is nil here.
gruvbox has a "transparent mode", and when you turn it on, it doesn't set a background. it works fine without transparent mode. I'm guessing when the current colorscheme has no background, bg.nvim should probably also just not call update and reset 🤔

Hi, thanks for the report, trying to reproduce the issue. Would you mind sharing your gruvbox.nvim setup function?

Forget about it, I had a typo when trying to setup gruvbox.nvim. I just published a fix :)
When there's no background, bg.nvim resets terminal background.


Gramine runtime does not build dcap on debian

Any particular reason for enabling dcap only for Ubuntu?
https://github.com/gramineproject/gsc/blob/master/templates%2FDockerfile.common.compile.template#L33
I removed if statement locally and graminized debian image. Building worked, but during execution I get the error that some Intel sgx library is missing (don't remember exactly the name, I am on mobile now).
I assume in Dockerfile, the build step of installing Intel's sgx packages, misses attestation verification package.
From git blame, seems like the if statement I removed for my local experiment should be more like:
'if not centos then dcap=enable'??

I think this one:
https://github.com/gramineproject/gsc/blob/master/templates%2Fdebian%2FDockerfile.compile.template#L45
Is missing in BUILDING docker template.
Graminized container should give access to this package if dcap is enabled. I think 🤔?

Any particular reason for enabling dcap only for Ubuntu?
From git blame, seems like the if statement I removed for my local experiment should be more like: 'if not centos then dcap=enable'??

Yes, I agree, there is no reason to not enable DCAP on Debian. I don't think there is any explanation for Debian omission, just a historical bug.

I removed if statement locally and graminized debian image. Building worked, but during execution I get the error that some Intel sgx library is missing (don't remember exactly the name, I am on mobile now).
I assume in Dockerfile, the build step of installing Intel's sgx packages, misses attestation verification package.

Could you tell us the exact error and what exactly you ran?
In Dockerfiles, we actually have the installation of the required SGX packages, you found it yourself: https://github.com/gramineproject/gsc/blob/fcf96546f4a23a4e6bcc6a14d80cf1521c018fc9/templates/debian/Dockerfile.compile.template#L45. The packages installed in this Dockerfile.compile should have propagated to the final Docker image, but now I think -- maybe they don't? I agree that those SGX packages should be (also) installed in Dockerfile.build.
@anjalirai-intel @jinengandhi-intel @jkr0103 Is there anything more you could add?

The error I get:
error while loading shared libraries: libsgx_dcap_quoteverify.so.1: cannot open shared object file: No such file or directory

The binary I try to launch in gramine links to these (ignore not found, the LD_LIBRARY_PATH was not set on this shell):
root@d3498d9e573e:/# ldd my-binary
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
	linux-vdso.so.1 (0x00007ffd9b7f3000)
	libra_tls_verify_dcap.so => not found
	libra_tls_attest.so => not found
	libssl.so.3 => /lib/x86_64-linux-gnu/libssl.so.3 (0x00007fb46773c000)
	libcrypto.so.3 => /lib/x86_64-linux-gnu/libcrypto.so.3 (0x00007fb4672b9000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fb467299000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fb4671b8000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fb466fd7000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fb468a76000)

Wonder why libsgx_dcap_quoteverify.so is not present here, probably it's loaded dynamically during runtime?
On graminized container there is dcap lib (when I remove the if from template):
root@243b219091fd:/# find . -iname *dcap*
./gramine/meson_build_output/lib/x86_64-linux-gnu/gramine/runtime/glibc/libra_tls_verify_dcap_gramine.so
./gramine/meson_build_output/lib/x86_64-linux-gnu/gramine/runtime/glibc/libsecret_prov_verify_dcap.so
./gramine/meson_build_output/lib/x86_64-linux-gnu/gramine/runtime/glibc/libra_tls_verify_dcap.so
./gramine/meson_build_output/lib/x86_64-linux-gnu/libra_tls_verify_dcap_gramine.so
./gramine/meson_build_output/lib/x86_64-linux-gnu/libsecret_prov_verify_dcap.so
./gramine/meson_build_output/lib/x86_64-linux-gnu/libra_tls_verify_dcap.so

But I don't see any of Intel's sgx library:
root@243b219091fd:/# find . -iname *sgx*
./dev/sgx_enclave
./sys/class/misc/sgx_vepc
./sys/class/misc/sgx_provision
./sys/class/misc/sgx_enclave
./sys/devices/virtual/misc/sgx_vepc
./sys/devices/virtual/misc/sgx_provision
./sys/devices/virtual/misc/sgx_enclave
./sys/module/kvm_intel/parameters/sgx
./gramine/app_files/entrypoint.manifest.sgx
./gramine/meson_build_output/lib/x86_64-linux-gnu/gramine/sgx
./gramine/meson_build_output/lib/x86_64-linux-gnu/libsgx_util.a
./gramine/meson_build_output/lib/python3.11/site-packages/graminelibos/sgx_get_token.py
./gramine/meson_build_output/lib/python3.11/site-packages/graminelibos/sgx_sign.py
./gramine/meson_build_output/include/gramine/sgx_attest.h
./gramine/meson_build_output/include/gramine/sgx_arch.h
./gramine/meson_build_output/bin/gramine-sgx-ias-verify-report
./gramine/meson_build_output/bin/gramine-sgx-pf-tamper
./gramine/meson_build_output/bin/gramine-sgx-pf-crypt
./gramine/meson_build_output/bin/gramine-sgx-sign
./gramine/meson_build_output/bin/gramine-sgx-gen-private-key
./gramine/meson_build_output/bin/gramine-sgx-quote-view
./gramine/meson_build_output/bin/gramine-sgx-sigstruct-view
./gramine/meson_build_output/bin/gramine-sgx-get-token
./gramine/meson_build_output/bin/gramine-sgx-ias-request
./gramine/meson_build_output/bin/is-sgx-available
./gramine/meson_build_output/bin/gramine-sgx

@szymek156 Thanks for this exploration!
Can you try adding these lines: https://github.com/gramineproject/gsc/blob/fcf96546f4a23a4e6bcc6a14d80cf1521c018fc9/templates/debian/Dockerfile.compile.template#L44-L45
To the Dockerfile.build file, somewhere after here: https://github.com/gramineproject/gsc/blob/fcf96546f4a23a4e6bcc6a14d80cf1521c018fc9/templates/debian/Dockerfile.build.template#L47
I think your original suspicion is correct, and we miss the installation of the SGX DCAP library in Dockerfile.build. But then I don't understand how our tests work for Ubuntu ones, if they fail for Debian as you found out...

Hey @dimakuv I was busy with other stuff, but this one strike me again.
Here you can see the changes I made in order to finally build and run verification:
https://github.com/gramineproject/gsc/compare/master...szymek156:gsc:master
I had to add libsgx-dcap-default-qpl-dev package because of the following error:
libdcap_quoteprov.so: cannot open shared object file: No such file or directory[sgx_dcap_load_qpl config.cpp:161] Couldn't find the Quote Provider library libdcap_quoteprov.so.1 or libdcap_quoteprov.so

This package provides libdcap_quoteprov library.
 In particular this entry in config file:
  //PCCS server address
  "pccs_url": "https://localhost:8081/sgx/certification/v4/"

Is problematic, it needs to point to valid PCCS server address.
What I found out is to mount the file  while running container from the host machine: -v /etc/sgx_default_qcnl.conf:/etc/sgx_default_qcnl.conf that contains correct configuration.
And in manifest file add these:
sgx.allowed_files = [
    "file:/etc/sgx_default_qcnl.conf"
]

This works, verification goes as expected. However now gramine yells at me that allowed_files are insecure...
I wonder if there is a better way of doing this? Another approach I tried:
In app Dockerfile (the one that I want to graminize) I added:
COPY --from=builder /src/deploy/sgx/sgx_default_qcnl.conf /etc/sgx_default_qcnl.conf

So my image contains valid sgx_default_qcnl.conf file from the beginning.
Updated my manifest:
sgx.trusted_files = [
    "file:/etc/sgx_default_qcnl.conf"
]

In order to include that file into final graminized image. However this not works because, during building unsigned graminized image I get following error:
Setting up libsgx-dcap-default-qpl (<IP_ADDRESS>-bionic1) ...

Configuration file '/etc/sgx_default_qcnl.conf'
 ==> File on system created by you or by a script.
 ==> File also in package provided by package maintainer.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : start a shell to examine the situation
 The default action is to keep your current version.
*** sgx_default_qcnl.conf (Y/I/N/O/D/Z) [default=N] ?
dpkg: error processing package libsgx-dcap-default-qpl (--configure):
 end of file on stdin at conffile prompt
dpkg: dependency problems prevent configuration of libsgx-dcap-default-qpl-dev:
 libsgx-dcap-default-qpl-dev depends on libsgx-dcap-default-qpl (= <IP_ADDRESS>-bionic1); however:
  Package libsgx-dcap-default-qpl is not configured yet.

dpkg: error processing package libsgx-dcap-default-qpl-dev (--configure):
 dependency problems - leaving unconfigured
Processing triggers for libc-bin (2.36-9+deb12u8) ...
Errors were encountered while processing:
 libsgx-dcap-default-qpl
 libsgx-dcap-default-qpl-dev
ESC[91mE: Sub-process /usr/bin/dpkg returned an error code (1)
ESC[0m
Successfully built an unsigned graminized Docker image `gsc-operator-sgx:latest-unsigned` from original application image `operator-sgx:latest`.

The file already exists (as expected) and dpkg expects user interaction, but will not get it, since it docker image build.
What do you think, is it possible to have valid qcnl.conf, and not rely on host mount to that file? Or I did something completely wrong? Maybe installing libsgx-dcap-default-qpl-dev was a mistake on a first place?
I would like to avoid string substitution in that file during startup of my enclave. I prefer clean solution where file is somehow provided.

Maybe installing libsgx-dcap-default-qpl-dev was a mistake on a first place?

No, this sounds correct.

The file already exists (as expected) and dpkg expects user interaction, but will not get it, since it docker image build.

I think the default choice (N) is a correct one for your case, but the subsequent error is weird. You may ask in DCAP developers at https://github.com/intel/SGXDataCenterAttestationPrimitives/issues. The error seems to me an incorrect implementation of DCAP packaging.

I would like to avoid string substitution in that file during startup of my enclave. I prefer clean solution where file is somehow provided.

The simplest thing you can do is to learn the hash of your config file ($ sha256sum /src/deploy/sgx/sgx_default_qcnl.conf) and add this hash to the Gramine manifest file:
sgx.trusted_files = [
    { uri = "file:/etc/sgx_default_qcnl.conf", sha256 = "<sha256sum output>" },
]

Now you can run Docker container with -v /etc/sgx_default_qcnl.conf:/etc/sgx_default_qcnl.conf.

@dimakuv trusted_files approach works like a charm! Thank you!
What about this: https://github.com/gramineproject/gsc/compare/master...szymek156:gsc:master
prepare pull request?

Hm, isn't it enough to add libsgx-dcap-default-qpl-dev to this line: https://github.com/gramineproject/gsc/blob/3168b08b36d6367488d1e02ae9a378b570ac0afa/templates/debian/Dockerfile.compile.template#L45

Btw, officially Intel SGX SDK/PSW/DCAP is not supported on Debian, at least I don't see the corresponding packages here: https://download.01.org/intel-sgx/sgx_repo
So I'm not sure it would be correct for GSC to "support" DCAP libraries from Ubuntu that run in a Debian Docker container. I think that's the main reason why we have {% if template_path(Distro) == 'ubuntu' %}-Ddcap=enabled{% endif %} condition.

True, debian distro should not include ubuntu packages.
I changed my base Docker image to use ubuntu:22.04, graminized one still returns error
error while loading shared libraries: libra_tls_verify_dcap.so: cannot open shared object file: No such file or directory
I am using gsc on commit 3168b08b36d6367488d1e02ae9a378b570ac0afa (latest master)
Seems like
       {% if template_path(Distro) == 'ubuntu' %}-Ddcap=enabled{% endif %} \

Is not working
I am using the config.yaml that looks like so
# Specify the OS distro that is used to build Gramine, i.e., the distro from where the Gramine build
# gets all tools and dependencies from. This distro should match the distro underlying the
# application's Docker image; otherwise the results may be unpredictable (if you specify `"auto"`,
# which is recommended, you don't need to worry about the mismatch).
#
# Currently supported distros are:
# - ubuntu:20.04, ubuntu:21.04, ubuntu:22.04, ubuntu:23.04
# - debian:10, debian:11, debian:12
# - centos:8
# - redhat/ubi8:8.8
# - redhat/ubi8-minimal:8.8

# If Distro is set to "auto", GSC detects the distro automatically by examining the supplied
# Docker image. Alternatively, Distro can be set to one of the supported distros mentioned above.
Distro: "ubuntu:22.04"

# If the image has a specific registry, define it here.
# Empty by default; example value: "registry.access.redhat.com/ubi8".
Registry: ""

# If you're using your own fork and branch of Gramine, specify the GitHub link and the branch name
# below; typically, you want to keep the default values though.
#
# It is also possible to specify the prebuilt Gramine Docker image (that was built previously via
# the `gsc build-gramine` command). For this, remove Repository and Branch and instead write:
#   Image:      "<prebuilt Gramine Docker image>"
#
# GSC releases are guaranteed to work with corresponding Gramine releases (and GSC `master`
# branch is guaranteed to work with current Gramine `master` branch).

I created PR https://github.com/gramineproject/gsc/pull/216 to fix it. Can you try it?

I tried, and it works, however I do not understand at which stage the libsgx libs (libsgx-dcap-default-qpl-dev) goes to the final image?

@szymek156 I'm also not sure :)
Could it be that this line that installs the DCAP QuoteVerification package also installs the QPL-dev package? https://github.com/gramineproject/gsc/blob/3168b08b36d6367488d1e02ae9a378b570ac0afa/templates/debian/Dockerfile.compile.template#L45

Nah mistake in my environment, build scripts were still using my forked repo, sorry for confusion, now building using yours #216
it breaks as expected:
error while loading shared libraries: libsgx_dcap_quoteverify.so.1

adding
apt install libsgx-dcap-default-qpl-dev fixes it but then:
Couldn't find the Quote Provider library libdcap_quoteprov.so.1 or libdcap_quoteprov.so

so adding to that: apt install libsgx-dcap-default-qpl-dev
finally resolves the problem

@dimakuv I think adding libsgx-dcap-default-qpl-dev, libsgx-dcap-default-qpl-dev packages should be part of https://github.com/gramineproject/gsc/blob/master/templates/ubuntu/Dockerfile.build.template


Promote GetNewBlockV3 and enable by default

PR Description
This PR unhides the GetNewBlockV3 and enables it by default.
Fixed Issue(s)

Part of #7779
Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

Make sense to me, I'll keep it as experimental them.


Update US19JanTaxR1.md

updated steps

Docs Build status updates of commit e44a790:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dynamics-gp/payroll/US19JanTaxR1.md
:warning:Warning
View
Details

dynamics-gp/payroll/US19JanTaxR1.md

Line 1201, Column 80: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/dynamics/s-e/gp/tugp2018_391' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 1222, Column 259: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/dynamics/s-e/gp/tugp2018_391' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Learn Build status updates of commit e44a790:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/payroll/US19JanTaxR1.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit f365bf8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/payroll/US19JanTaxR1.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


liftoff 2x / v8flags 2x released

Heya, this is just a friendly note to let you know that a new version of Liftoff and some of the dependencies commonly used in conjunction with it have been released. This release adds better support for situations where your user's configuration files are written using features behind a v8 flag (e.g. --harmony). Windows users and io.js users should see less issues if you upgrade!
Some helpful links:
https://github.com/tkellen/node-liftoff/blob/master/UPGRADING.md#100---200
https://github.com/tkellen/node-v8flags/blob/master/README.md#example
https://github.com/tkellen/node-hacker/blob/master/bin/hacker.js#L10-L14
Thanks!

Will upgrade soon. Thank you Tyler.


fix lint hint "Private field could be final"

I am attaching the image of the hint that lint reports for the generated file.

Thanks for this issue. I will fix that!

Added in 4.11.0


Speech rate variation range

It seems to be desirable to increase upper limit of speech rate.

Hello @poretsky.
While using ru_tts on a daily bases, me and people who listens to the synthesizer at higher rates noticed that ru_tts is not as fast in terms of speech rate as we might like to have.
I understand that at higher rates, synthesizer can be crackling, but if it is possible, could you please look at this issue?
Maybe if you don't want to increase rate with main adjust mechanism, it would be possible to make a flag like rate boost, which shifts frames in the table or something like that.
Thanks for your work.


Use new parameter format [docs only]

The parameter format in the doc is outdated and an error is thrown if used with Neo4j 4.x.
Fixes #<Replace with the number of the issue, Mandatory>
One sentence summary of the change.
Proposed Changes (Mandatory)
A brief list of proposed changes in order to fix the issue:

@FrankR85 thank you so much for the contribution, please sign the CLA in case you already didn't.

Yes, I signed the CLA.

@FrankR85 thank you


tip for overriding 'window' error when trying to 'yarn build' ?

Getting this:
  ReferenceError: Failed exporting HTML for URL /map/ (src/containers/MapView): window is not defined

when running 'yarn build'
It must be because the 'google-map-react' package I'm using is referencing the window somehow..
Is there any way I can stub it out?
I tried setting up an empty var in the offending file.. but no luck
const window = {}

Any help would be amazing many thanks :)

I would recommend you to wrap your render google maps component with
conditional.
Something like :
‘’’
{
typeof window !== “undefined” && (

)
}
‘’’
So it will be ignored on serverside render, and catch up on client side
render

Thanks so much,
I tried it like this:
export class MapContainer extends React.Component {
  render () {
    const style = {
      width: '100%',
      height: '100%',
    }

    return (
      <div>
        {
          typeof window !== 'undefined' && (
            <MapComponent
              google={this.props.google}
              style={style}
              onClick={this.onMapClicked}
            />
          )
        }
      </div>
    )
  }
}

App runs fine locally but get the same error when building :(
ReferenceError: Failed exporting HTML for URL /map/ (src/containers/MapView): window is not defined

Which npm package do you use? I use react-google-maps, an I do not have issues with rendering.
I guard every use case of window or document in class methods too.
On other hand, you could try to guard import of the component. for me it was useful to require instead of import npm history:
let history // eslint-disable-line

if (typeof document !== 'undefined') {
  const createBrowserHistory = require('history/createBrowserHistory').default

  history = createBrowserHistory()
} else {
  history = void 0
}

export default history

You could try to do the same with your Map component in question.

Yeah I'm using react-google-maps
I'm not referring to window in any of my code.. So I guessed it must be coming from the library code..
Not sure how the history example will help.. have you got a fuller example?

I guard every use case of window or document in class methods too

Does that mean you add that 'typeof window' check to every render return for all your components?

No, it does means that I guard every Component which uses unguarded window or document under the hood.
If I use window or document in lifecycle methods - I guard it in place.

For your particular case you may find google-map-react useful. It’s a popular, fresh library that renders the map server-side, no problem.
Note that guarding in render produces mismatching HTML between the server and the client. Unfortunately these warnings are hidden today, see #500. You can both fix the mismatch and simplify the guards with a reusable wrapper component:
class InBrowserOnly extends React.Component {
  state = { mounted: false }
  componentDidMount() { this.setState({ mounted: true }) }
  render() {
    if (!this.state.mounted) return null;
    return this.props.children;
  }
}

<InBrowserOnly>
  <MapComponent ... />
</InBrowserOnly>

Note that the authors of google-map-react claim it renders on the server, so your assumption that it’s because it uses window is likely incorrect.
Note that guarding in render produces mismatching HTML between the server and the client. Unfortunately these warnings are hidden today, see #500. You can both fix the mismatch and simplify the guards with a reusable wrapper component:
class InBrowserOnly extends React.Component {
  state = { mounted: false }
  componentDidMount() { this.setState({ mounted: true }) }
  render() {
    if (!this.state.mounted) return null;
    return this.props.children;
  }
}

<InBrowserOnly>
  <MapComponent ... />
</InBrowserOnly>


try to recover on server TelemetryCommand transmission error

I'm trying to solve the issue described by @guyinyou in #182
The new flow of execution after transmission error looks as follows:

we encounter a server TelemetryCommand transmission error
we set the state of recovery to true and skip to the next loop iteration
if there is a transmission error when we are in recovery we release the observer and set the state of recovery to false
if we manage to read the message we check if each of the servers is healthy, if not we release the observer and set the state of recovery to false
if we managed to read the message and each server is healthy we process the message and set the state of recovery to false.

I'm going to write the unit tests for this next.

Codecov Report

Merging #408 (900d1e2) into master (514056c) will increase coverage by 0.00%.
The diff coverage is 39.58%.

@@            Coverage Diff            @@
##             master     #408   +/-   ##
=========================================
  Coverage     34.22%   34.22%
+ Complexity      663      662    -1
=========================================
  Files           220      220
  Lines         11458    11485   +27
  Branches        279      279
=========================================
+ Hits           3921     3931   +10
- Misses         7284     7298   +14
- Partials        253      256    +3

Flag
Coverage Δ

golang
33.61% <39.58%> (+0.36%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

golang/client.go
37.58% <39.58%> (+1.92%)
:arrow_up:

... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks @Anakin100100 !


Unable to write collections

v.0.9.24 - windows ui
With Steam (Steam Client Service) stopped / shut down, I'm unable to write collections

I'm finding it hard what other information I can provide to help figure out what could be the underlying issue

In your screenshot you show that the Steam SERVICE is stopped, but have you checked in Task manager that the Steam client isn't running?

Yes, its not running there either :)

I can confirm that this is still an issue in v.1.0.3

I have heard from other sources that they also has this problem, so it is not just you. I just can't reproduce it myself currently.

Same here with my steam deck, I'll restart and try again

Can confirm this myself. No Collections created here too. In both Native and Flatpak

i have the same issue, my steam is installed in a different drive and folder, and it seems is ignoring the steam path from the settings and using instead hardcode path like $HOME (*linux) and "Program Files (x86)", it should use the path from the config.toml
https://github.com/PhilipK/BoilR/blob/main/src/steam/collections.rs#L173-L210

Alright, this seems to be fixed in the newest version https://github.com/PhilipK/BoilR/releases/tag/v.1.4.3
I have testet on a windows, linux and steamdeck setup, it works on all of them for me now.
Can someone confirm that it works for them as well?
The problem seems to have been the rusty-leveldb package/crate that was used to write to steams leveldb, after i updated the package to the newest version things started working.
If someone can confirm it works for them I will close this issue.

Yesterday I used version 1.4.1, there it didn't (always) work, it did some times.
But I can confirm that it worked just now when I tried on 1.4.3.
I haven't battletested it multiple times, but on my first try, it seems to work :)

Alright I am going to close this then.
If anyone experiences that it still does not work post comment here and I will reopen the issue

@PhilipK it works fine :) thanks.

Hi! It seems I'm having this issue right now. But the field where I should have the steam folder is empty, maybe it's related? The new shortcuts are created though just not put in the existing collections... Steamdeck here btw.

@ZoidbergForPresident does everything else work? Just the collections missing?

@PhilipK It would seem so, I redid everything after deleting the collections and I had to readd each game to their new collections.

@ZoidbergForPresident I will have to play around with it to see if I can reproduce it.


Remove tick mark from price label

Currently a price label has a line in front of the text:

Please add an option to remove this line. For someone it can look like a minus.

Should it be the only one option to hide all tick marks at all or for every case separately (time/price axis' tick marks, labels' tick marks, cross hair, etc)?

one option for all price marks should work

@timocov Hello, I just faced the same issue. I don't know if you have decided to hide them all with a single option or doing it for each serie. We definitely need to be able to set this on a serie basis. Like current price is fine, but we are adding moving averages and we don't want the lines for these.

Hey @AoDev, do you want to have them like this, right?

@timocov ow, I have misunderstood this issue. What I'd like to do, is to remove the horizontal line completely, the one that marks the price. Sorry for the misunderstanding.

I haven't found a setting for it in the customization section or line series docs.
I guess this should be a separate issue?

@AoDev see https://github.com/tradingview/lightweight-charts/blob/master/docs/series-basics.md#price-line


Add the possibility to highlight several places on the protein model

Hi Mandar,
I was wondering if this would be possible to highlight several places on a protein model ?
For instance I would like to be able to highlight the positions 10-12, 25-28 and 53 on a protein model.
Actually in my use case it would be more likely to be something like highlighting the positions 5,32,58,96.
Thanks,
Laurent

Hi Laurent,
You can use the 'SelectExtractFocus' helper function to accomplish this. Here is a demo for your reference - https://embed.plnkr.co/c5K23wAX0TWexmIsLOVm/
Cheers,
Mandar

Brilliant!
Thank you Mandar!
Laurent
On 24/03/2017 16:27, Mandar Deshpande wrote:

Hi Laurent,
You can use the 'SelectExtractFocus' helper function to accomplish
this. Here is a demo for your reference -
https://embed.plnkr.co/c5K23wAX0TWexmIsLOVm/
Cheers,
Mandar
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mandarsd/pdb-lite-mol/issues/1#issuecomment-289072230,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFzaZ5yWs3tHZIcwbeAnZplAr-O_9zMfks5ro-7-gaJpZM4MocP6.

Hi Mandar,
Sorry, just a follow up question regarding the multiple selection: is it possible to colour the different elements selected on differents colours ?
e.g.:

selection 1: residues 10 to 15 highlighted in blue
selection 2: residues 22 to 24 highlighted in red
selection 3: residue 35 highlighted in yellow
... and so on

This could be useful to differentiate the selected elements without having to move the mouse over them.
Cheers,
Laurent

Hi Laurent,
To accomplish this you'll have to do custom themes implementation. Currently you have to use some LiteMol core commands/methods for which we don't have any helper function in the component.
Here is the working demo - https://embed.plnkr.co/HmclfeEXY2diUEf6mQqA/
You can refer to LiteMol core documentation to check all the advance implementations you can do using the core library functions.
https://github.com/dsehnal/LiteMol/tree/master/examples
https://github.com/dsehnal/LiteMol/tree/master/examples/Commands
https://webchemdev.ncbr.muni.cz/LiteMol/Examples/Commands/
I have added the litemol-custom-theme.js script snippet in the demo from the commands example.
Hope this helps!
Cheers,
Mandar

Hi Mandar,
Thank you very much for the demo! I added it to my test and it worked!
Cheers,
Laurent

Excellent! I'll close this issue then.
Cheers,
Mandar


优化点击事件透传机制

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.huangyu.hy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.huangyu.hy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Fixes broken class and error on re-import

Type of Change

[x] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Pester test is included

Purpose

Fixes wrong typename causing errors and fail
Suppresses errors on re-import

The change on line 36 to switch to the extension to the Database class is correct.
I am curious about the additions to ignore (and not display) errors on these Update-TypeData calls.

@FriedrichWeinmann - can i merge once tests have passed?

Also thank you for solving and doing so, so quickly 🙇

Sure and can merge.
@DavidSingletonTN  the ignores are for re-importing the module. This script is run on each import and will cause duplicates on each subsequent intervals.
Whether those properly work the first time around is tested by testing commands that use them. I also have adding dedicated tests for them themselves on my todo list. It's a long list and I'm busy with work so I only fix things that are actively broken and queue the rest for later consideration. (I expect that to get better in the coming weeks)

That makes sense @FriedrichWeinmann.  I noticed the extra errors with the other extensions on subsequent  imports.
Thank you again for the quick fix.


added Spanish option to dropdown menu

Please review and let me know if I am missing something. Hope this helps :)

Thank you! Can you please add in the algolia key, and then we can merge 🎉

Sweet, but I am not sure if I understand. @sdras Algolia key, could you point me to that, please?

@chrisvfritz said that he sent you one- Chris, can you please advise?

@sdras I haven't got it! should I get that on my email?

I'll gladly take this over. Spanish is pretty huge to not have in the translation section. @chrisvfritz can you send me over the Algolia key, please. CC @sdras

Maybe @yyx990803 you could help with getting me the Algolia key?

I gave the Algolia key to Diana - we just touched base again and she's working on the search now.

@sdras @chrisvfritz so, you're not using my PR?

@Davidcreador Your PR looks great! 😊 We just want to make sure the Algolia search is working before we merge, thereby officially "publishing" the Spanish translation. That work is being done by @alphacentauri82 in another repo which deploys to es.vuejs.org.

The work is done in another repo. I will add the PR. check es.vuejs.org

Great, then I think we just have to resolve conflicts before merging @Davidcreador. 🙂

@chrisvfritz  awesome! I'll fix the conflicts

Haz El PR!


Resolving Missing ShortId in the Database

Describe the bug
After shortening a URL, we get an URL in form of https://urlsrt.vercel.app/data.
Now if we pass a arbitrary value in place of data then it shows the following.
In the example below, I used the URL : https://urlsrt.vercel.app/111222

So, I think if in getSpecificUrl() (in server/controller/urls.js)
once we find the data based on shortId then check if its null. If null, then we will redirect the user to an 404 page which will say that
"This link does not exist".
And will also add link to navbar, which will redirect to homepage.
Could you please assign this issue to me under GSSOC 24.
To Reproduce
Steps to reproduce the behavior:

Go to https://urlsrt.vercel.app/111222

Expected behavior
The above screenshot.
Desktop (please complete the following information):

OS: Windows
Browser: Arc
Version: 1.2.1 (29300)

Great, Assigning this issue to you now.
You are implementing frontend and backend both rigth?
The UI should be responsive also right?

Great, Assigning this issue to you now.
You are implementing frontend and backend both right? The UI should be responsive also right?

Yes, I will implement both responsive frontend and backend.


Add Nala

Nala is an apt replacement that handles parallel Downloads and easier ability to visualize what is happening with installs and updates

Closing this pull request - this is not working right - didn't realize I was getting a GPG error in testing...


fix(redis): remove REDIS_CA_CERT secret key

The cert can't be used with this type of service.

The cert is also hidden in the Console.

tests


The argument type 'String' can't be assigned to the parameter type 'URLRequest'.

How to fix this issue
I want to take the value of a string like this with my defined string - String myurl
webViewController?.loadUrl(urlRequest: myurl);

but I get this error The argument type 'String' can't be assigned to the parameter type 'URLRequest'.

did it using
                        webViewController?.loadUrl(urlRequest: URLRequest(url: myurl as Uri?));


Help: How to best utilize domdiff to render long markup fragments

I've been highly inspired by your ideas regarding dom performance which led to me to rethink a lot of the existing abstractions, like markup.
I am hitting the point where "Virtual scrolling for long document fragments" is needed, and I am not sure how to best approach this.
domdiff seems like a good fit so I hope you can help me figure out how to go from a long document fragment to a virtually "smooth" scrolling one using domdiff.
Thanks 👍

not sure I understand your goal, but I'm developing these days this sort of component:
https://webreflection.github.io/eyeo/custom-elements/smoke/io-filter-table.html
the table could render hundred thousand items without a sweat, and it's fully hyperHTML based (in case you didn't know, hyperHTML uses domdiff).
How to create infinite lists

you need to keep the row position, and the scroll one too (or relate both somehow)
you need to know the length of each row, at least each row you have rendered, theoretically each row you have previously rendered too if you want to have a meaningful scrollbar
you show the row before, each row needed to cover the visible area, the row after

Last point is to give you room for smoother scrolling.
Now, all this is very complex, but at least you know the primitives needed to obtain that.
If each row has fixed length, things are easier and probably faster too.
I am closing this since this is not a bug or anything related to domdiff, domdiff just provides the best way to keep appending sequential rows, removing them, or sorting them asc/desc, etc etc ... the amount of rows, and which row you need to render, won't ever land in this library since it's out of scope.


replace np.int to int as np.int is deprecated and throws an error

This will fix AttributeError: module 'numpy' has no attribute 'int'..
Got this error while doing inference on CPU.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feat: added functions into token-api module

feat: added functions into token-api module

Hi @bobo-k2  @nick8319  @sirius651 Please take a look at this PR when you are available


Support botocore.response.StreamingBody from boto3 as input to smart_open.smart_open()

I noticed that for boto.s3.key.Key you use io.BufferedReader.
boto3's botocore.response.StreamingBody has the attribute _raw_stream which it looks like you can just pass to io.BufferedReader and it works.
>>> s3 = boto3.resource('s3',
...          aws_access_key_id=ACCESS_KEY,
...          aws_secret_access_key=ACCESS_SECRET)
>>> a=s3.ObjectSummary(BUCKET_NAME, KEY_NAME).get()["Body"]
>>> a
<botocore.response.StreamingBody object at 0x108898690>
>>> stream = io.BufferedReader(a._raw_stream)
>>> stream.readline()
'first line\n'

This is currently possible on the master branch:
>>> from smart_open import open
>>> import boto3
>>> s3 = boto3.resource('s3')
>>> summary = s3.ObjectSummary('commoncrawl', 'robots.txt')
>>> stream = summary.get()['Body']._raw_stream
>>> open(stream).read()
'User-Agent: *\nDisallow: /'

I don't think any further work is necessary here.


Created a draft version of the new refined core API

This PR incorporates a series of API changes and core concept refinements.

Finally merged to master


FileIO integration

Codecov Report

Merging #9 (3826316) into master (a17847d) will increase coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   97.40%   98.44%   +1.03%
==========================================
  Files           1        1
  Lines         193      193
==========================================
+ Hits          188      190       +2
+ Misses          5        3       -2

Impacted Files
Coverage Δ

src/QOI.jl
98.44% <0.00%> (+1.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17847d...3826316. Read the comment docs.


Sanitize Handlebars HTML Templates escaping partials

We are using this package to sanitize handlebars templates. Handlers has a concept of partials which works just like a macro. Here is how its supposed to be used https://handlebarsjs.com/guide/partials.html#basic-partials
Since it has a > sign to invoke the partials, sanitization is replacing {{> myPartial}} to {{> myPartial}}and this breaks our template.
Is there a way to solve this or get around this problem ?

Handlebars templates are not HTML and are out of scope for this module. But, if you can write something to sanitize the handlebars bits, you can use this module to sanitize individual HTML sub-bits, perhaps.


batched reading in Dataloader not working

I am trying to iterate over the dataset using pytorch's dataloader.
here's the code snippet which shows how I have created the dataset and how I am trying to read it.
import torch
import webdataset as wds
import pandas as pd
from itertools import islice
import imageio

# creating dataset
def image_samples(csv_path="metadata.csv"):
    df = pd.read_csv(csv_path)
    for row in df.itertuples():
        sample = {
            "__key__": row.image_id,
            "image.pyd": imageio.imread(row.image_path),
            "label.pyd": imageio.imread(row.label_path)
        }
        yield sample

with wds.ShardWriter("dataset-%06d.tar", maxcount=10) as sink:
    for sample in islice(image_samples(),0, 200):
        sink.write(sample)

# reading dataset
url = "dataset-{000000..000005}.tar"
batch_size = 4
num_workers = 4
dataset = (
    wds.WebDataset(url, shardshuffle=False).batched(batch_size)
    .decode("pil")
    .to_tuple("image.pyd", "label.pyd")
)

dataloader = torch.utils.data.DataLoader(dataset, num_workers=num_workers, batch_size=None)
for i_iter, batch in enumerate(dataloader):
    print(i_iter) # breaks here
    break

When I try to read the dataset I get this error :
Traceback (most recent call last):
  File "/Users/asav.patel/Library/Application Support/JetBrains/PyCharm2021.2/scratches/jupiter_scratch.py", line 39, in <module>
    for i_iter, batch in enumerate(dataloader):
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 345, in __next__
    data = self._next_data()
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 856, in _next_data
    return self._process_data(data)
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 881, in _process_data
    data.reraise()
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/torch/_utils.py", line 394, in reraise
    raise self.exc_type(msg)
AssertionError: Caught AssertionError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/torch/utils/data/_utils/worker.py", line 178, in _worker_loop
    data = fetcher.fetch(index)
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/torch/utils/data/_utils/fetch.py", line 34, in fetch
    data = next(self.dataset_iter)
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/webdataset/iterators.py", line 230, in map
    if handler(exn):
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/webdataset/utils.py", line 12, in reraise_exception
    raise exn
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/webdataset/iterators.py", line 228, in map
    result = f(sample)
  File "/Users/asav.patel/.pyenv/versions/jupiter_env/lib/python3.6/site-packages/webdataset/autodecode.py", line 331, in __call__
    assert isinstance(sample, dict), (len(sample), sample)
AssertionError: (3, [['__key__', '__key__', '__key__', '__key__'], ['image.pyd', 'image.pyd', 'image.pyd', 'image.pyd'], ['label.pyd', 'label.pyd', 'label.pyd', 'label.pyd']])

What am I doing wrong here?
btw this works just fine :
# notice there's no `.batched(batch_size)` applied here.
dataset = (
    wds.WebDataset(url, shardshuffle=False)
    .decode("pil")
    .to_tuple("image.pyd", "label.pyd")
)

for sample in dataset:
    print(sample)
    break

wds_loader = wds.WebLoader(dataset, num_workers=num_workers, batch_size=batch_size)
for i_iter, batch in enumerate(wds_loader):
    print(i_iter)
    break

dataloader = torch.utils.data.DataLoader(dataset, num_workers=num_workers, batch_size=batch_size)
for i_iter, batch in enumerate(dataloader):
    print(i_iter)
    break

You're batching before decoding.

Decoding needs to happen before batching, because the decoders expect individual samples and files for decoding.
Furthermore, batching works on tensors, not on PIL images.

This would work; it will write batches consisting of lists of PIL images to disk:
dataset = (
    wds.WebDataset(url, shardshuffle=False)
    .decode("pil")
    .listed(batch_size)
    .to_tuple("image.pyd", "label.pyd")
)

You probably want something more like:
dataset = (
    wds.WebDataset(url, shardshuffle=False)
    .decode("rgb8")
    .batched(batch_size)
    .to_tuple("image.pyd", "label.pyd")
)

But is there any reason to write whole batches to disk in the first place? Since WebDataset already does sequential reads, you don't gain I/O speed for writing unbatched images and batching upon read. Unless there is a functional reason for wanting to keep batches together (e.g. for reproducibility or because you constructed them according to some criteria), you're probably better off just writing individual samples.

@tmbdev Thanks for the response. Makes sense.
So what do you suggest? batch inside the WebLoader or DataLoader?

PyTorch pretty much requires you to do batching inside the Dataset for
sequential I/O; that's also good for efficiency.
If you use WebDataloader (a thin wrapper around DataLoader), you can
rebatch the data:
ds = WebDataset(...) ... .batched(64)
dl = WebDataloader(...).unbatched().batched(batch_size)

On Mon, Aug 9, 2021 at 2:36 PM Asav Patel @.***> wrote:

@tmbdev https://github.com/tmbdev Thanks for the response. Makes sense.
So what do you suggest? batch inside the WebLoader or DataLoader?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/webdataset/webdataset/issues/98#issuecomment-895567412,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACRQP6L6J54D5SVMSJKVXDT4BC7JANCNFSM5BSGLJGQ
.


rate limit

2024-10-01T20:53:54.926091589Z 2024-10-01T20:53:54Z ERR Unable to obtain ACME certificate for domains error="unable to generate a certificate for the domains [meilisearch-foodie-store.<IP_ADDRESS>.sslip.io]: acme: error: 429 :: POST :: https://acme-v02.api.letsencrypt.org/acme/new-order :: urn:ietf:params:acme:error:rateLimited :: Error creating new order :: too many certificates already issued for "sslip.io". Retry after 2024-10-01T21:00:00Z: see https://letsencrypt.org/docs/rate-limits/" ACME CA=https://acme-v02.api.letsencrypt.org/directory acmeCA=https://acme-v02.api.letsencrypt.org/directory domains=["meilisearch-foodie-store.<IP_ADDRESS>.sslip.io"] providerName=letsencrypt.acme routerName=https-0-nsowkkcgcck0kwoc4kg8cooo-meilisearch@docker rule="Host(meilisearch-foodie-store.<IP_ADDRESS>.sslip.io) && PathPrefix(/)"

Closed in favor of issue #57


I get a black screen when using this

followed the instructions and tried implementing this with the v1 example project, which was working fine prior.
Now as you can see below I get a black screen :/
I've tested this on rn 57.1

Be sure to change the import of "react-native-navigation" to "react-native-navigation-v1-v2-adapter"

Be sure to change the import of "react-native-navigation" to "react-native-navigation-v1-v2-adapter"

Problem was with the RNN version 2.0.555 works!


Think how to handle multiple modifier spaces, e.g. ArraySpace{PiecewiseSpace{}} vs PiecewiseSpace{ArraySpace{}}

I'm leaning towards allowing either and implementing the appropriate conversion routines.

I think this depends on #209 as the constructor tests for ArraySpace via isa(S,ArraySpace) where we want isa(basistype(S),ArrayBasis)

Whatever we are currently doing seems to work so far, so I think we can close this.  I think it works by having suitable conversion operators.


Build kafka-manager docker image from source

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:


Notes for the exclude predicted

ENSVAR-6372

@olaaustine - this isn't quite right. The option works to remove predicted RefSeq transcipts for all species (dog, mouse, etc) but we don't support predicted RefSeq transcipts for GRCh37.
We could document that here
http://www.ensembl.org/info/docs/tools/vep/script/vep_other.html#refseq

Looks good - thanks Ola!


More human readable and writable dates

For example, [July 4 1776, 4th of July 1776, July fourth 1776] instead of 7/4/1776

or other date formats like 1776-07-04 or my fav 17760704
minor thing tho

What about support for https://momentjs.com/ in this place?

Cool!


Show bottom menu for scene which button is not present in menu

Its possible to render bottom menu for Scene which is not in Tabs (doesn't have button on menu)?
showIcon={false} - not hide this icon

It is not supported


CP-65208: Implementation of OutEdges(TVertex v) for BidirectionalGraph is (I think) wrong

From unknown CodePlex user on Thursday, 01 September 2016 00:41:20
Here is the implementation for BidirectionalGraph :
        public IEnumerable<TEdge> OutEdges(TVertex v)
        {
            IEnumerable<TEdge> result;
            if (this.TryGetInEdges(v, out result))
                return result;
            else
                return Enumerable.Empty<TEdge>();
        }

I think it should not use the method "TryGetInEdges".
A symptom of this problem is that the algoritms have a weird behaviour. For exemple, is i have the following graph:
v1->v2
^    |
|    v
v4<-v3

and if I use the StronglyConnectedComponents algorithm on this graph, the algorithm will output that there is 4 components (we should have only one component). I think, this is because the StronglyConnectedComponents algorithm use the OutEdges method, and since it is wrong, the algorithm actually see the following graph:
|-----|   |-----|   |-----|    |-----|
v1<---|   v2<---|   v3<---|    v4<---|

(each vertex has a self-loop, and there is no other edge excepts these loops)

As far as I can see this issue is fixed, the current implementation is:
public IEnumerable<TEdge> OutEdges(TVertex v)
{
    return this.vertexOutEdges[v];
}

I see you branched from another QuickGraph fork (https://github.com/YaccConstructor/QuickGraph/), which seems to be more active.
Can you tell me what the purpose of this project is? Also, if I wanted to contribute, should I contribute to that other fork? Unfortunately, the other team has not added the archived issues and discussions.

@ktnr I suggest that you contribute to the other project instead of this one. I opened an issue explaining the current situation: #162.


_WD_ExecuteScript  $bValueNode > $sJSONNode

by mistake I do the last commit in:
https://github.com/Danp2/WebDriver/pull/114
https://github.com/Danp2/WebDriver/pull/114/commits/a7fe5b1837f8b5b4b6f275947ac84b3dd14faa9a

by mistake I do the last commit in:
https://github.com/Danp2/WebDriver/pull/114
https://github.com/Danp2/WebDriver/pull/114/commits/a7fe5b1837f8b5b4b6f275947ac84b3dd14faa9a

$vValueMode

I didn't initially catch that this changed from "Node" to "Mode", but I still stand by my earlier comments. 😉

$vValueMode

I didn't initially catch that this changed from "Node" to "Mode", but I still stand by my earlier comments. 😉

I don't like the way this is implemented. Instead of $vValueNode, I would suggest $iReturnType. Then we need an enum with JSON (default), value node, etc.

ok. Will work on it

I don't like the way this is implemented. Instead of $vValueNode, I would suggest $iReturnType. Then we need an enum with JSON (default), value node, etc.

ok. Will work on it

maybe just  this way:
_WD_ExecuteScript($sSession, $sScript2, $_WD_EmptyDict, Default, "[value]")
or
_WD_ExecuteScript($sSession, $sScript2, $_WD_EmptyDict, Default, "[value][" & $_WD_ELEMENT_ID & "]")
I mean if string is given then it means that you want to get value ...

maybe just  this way:
_WD_ExecuteScript($sSession, $sScript2, $_WD_EmptyDict, Default, "[value]")
or
_WD_ExecuteScript($sSession, $sScript2, $_WD_EmptyDict, Default, "[value][" & $_WD_ELEMENT_ID & "]")
I mean if string is given then it means that you want to get value ...

If you accept please do not merge as I will need to change _WD_GetElementFromPoint
		$aCoords = _WD_ExecuteScript($sSession, $sScript2, $_WD_EmptyDict, Default, True)
And I want to do this here.

If you accept please do not merge as I will need to change _WD_GetElementFromPoint
		$aCoords = _WD_ExecuteScript($sSession, $sScript2, $_WD_EmptyDict, Default, True)
And I want to do this here.

I will need to change _WD_GetElementFromPoint
Done

I will need to change _WD_GetElementFromPoint
Done

I know that this is merged, but I would like to bring up something, does the WebDriver ever return anything other than a object with a single value property? I quickly glanced through the W3C draft and it doesn't mention anything other than returning the return value.
Also I think it would be better if we maintain backward compatibility with the old function and check if the argument is a boolean, and if it is and it's True then we treat it like before and return the value directly.

I know that this is merged, but I would like to bring up something, does the WebDriver ever return anything other than a object with a single value property? I quickly glanced through the W3C draft and it doesn't mention anything other than returning the return value.

I do not know what you want to propose.

Also I think it would be better if we maintain backward compatibility with the old function and check if the argument is a boolean, and if it is and it's True then we treat it like before and return the value directly.

IMHO current features is more flexible, and consistent.

I do not know what you want to propose.

I am not really proposing anything, was just curious if there was an use-case for this feature, I am not aware of JSON values that might be returned by ExecuteScript. Do you have any examples of such values that you can quickly share? All of the JSON I saw follows the same format: {value:"<insert return value here>"}

IMHO current features is more flexible, and consistent.

I agree, but we can also make it backward compatible for older scripts without compromising on the current new feature. Win-win for everyone.

Do you have any examples of such values that you can quickly share?

Almost there... I will do next PR soon which will fit:
https://github.com/Danp2/WebDriver/issues/116

@TheDcoder

does the WebDriver ever return anything other than a object with a single value property? I quickly glanced through the W3C draft and it doesn't mention anything other than returning the return value.

I think you may be correct. However, the idea here is to allow for the retrieval of specific nodes within the value node. For example, this is from _WD_GetMouseElement --
	$sResponse = _WD_ExecuteScript($sSession, $sScript, '')
	$oJSON = Json_Decode($sResponse)
	$sElement = Json_Get($oJSON, "[value][" & $_WD_ELEMENT_ID & "]")

With the revision, this could be written as a single line of code --
$sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, "[value][" & $_WD_ELEMENT_ID & "]")

Also I think it would be better if we maintain backward compatibility with the old function and check if the argument is a boolean, and if it is and it's True then we treat it like before and return the value directly.

Personally, I'm ok with not being backward compatible since this was only recently added.

I'm ok with not being backward compatible since this was only recently added.

Exactly this was released officially 5 days ago.
So I do not think that this is a ScriptBreakingChange as yet.

With the revision, this could be written as a single line of code --
$sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, "[value][" & $_WD_ELEMENT_ID & "]")

Exactly.
And this will be done in relation to:
https://github.com/Danp2/WebDriver/issues/116

My bad, looks like I didn't properly understand the code first time. Now it makes more sense to me.
Although I must admit that I liked the $bValue parameter because it was so simple, in fact I was able to add it in myself but then saw that @mlipok had already done it. I did not realize that it was a very recent change.
Nevertheless I would love to see the parameter also accept True to simply return the parsed value, I can see myself using this all the time to get strings without additional processing or writing [value] everytime.

Do you have any examples of such values that you can quickly share?

Almost there... I will do next PR soon which will fit: #116
as currently I'm waiting for: #117 aprroval.

Approved and merged. Hopefully, you will one day be able to handle more than on PR at a time. 😝

Nevertheless I would love to see the parameter also accept True to simply return the parsed value, I can see myself using this all the time to get strings without additional processing or writing [value] everytime.

Makes sense. I think @mlipok will address this for you.

I don't like the way this is implemented. Instead of $vValueNode, I would suggest $iReturnType. Then we need an enum with JSON (default), value node, etc.

I still think this is how I would do it.

I still think this is how I would do it.

The currently implemented way ?

@mlipok No, the way I quoted above with predefined enums.

@mlipok No, the way I quoted above with predefined enums.

But as far as I understand you , and after checking UDF I think that this wil require 2 additional parameters,
one to passs the enum and second to pass string for Json_Get($oJSON, $sJSONNode)

Nevertheless I would love to see the parameter also accept True to simply return the parsed value, I can see myself using this all the time to get strings without additional processing or writing [value] everytime.

it is for you:
https://github.com/Danp2/WebDriver/pull/122/commits/87e9adaa9ba6f9e63ec5c4d79a69747027c0a17a

But as far as I understand you , and after checking UDF I think that this wil require 2 additional parameters,
one to passs the enum and second to pass string for Json_Get($oJSON, $sJSONNode)

No, I meant to replace the current $sJSONNode with  $iReturnType, which would be the parameter where the enum was specified. There would be an enum for each of the allowed options (Raw, Value, Element, etc)

so How would you like to put parameters like this:
"[value][" & $_WD_ELEMENT_ID & "]"
Which is used:
Func _WD_GetMouseElement($sSession)
	Local Const $sFuncName = "_WD_GetMouseElement"
	Local $sScript = "return Array.from(document.querySelectorAll(':hover')).pop()"
	Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, "[value][" & $_WD_ELEMENT_ID & "]")
	Local $iErr = @error

	If $_WD_DEBUG = $_WD_DEBUG_Info Then
		__WD_ConsoleWrite($sFuncName & ': ' & $sElement & @CRLF)
	EndIf

	Return SetError(__WD_Error($sFuncName, $iErr), 0, $sElement)
EndFunc   ;==>_WD_GetMouseElement

Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, "[value][" & $_WD_ELEMENT_ID & "]")

Instead of this, you would use one of the predefined enums to indicate the result that you want returned, ie --
Global Enum _
		$_WD_RETURN_Raw = 0, _
		$_WD_RETURN_Value = 1, _
		$_WD_RETURN_Element = 2

	Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, $_WD_RETURN_Element)

_WD_ExecuteScript will internally know how to handle the enum and return the desired result. I feel this is while not as powerful as the current implementation, it is more user friendly and will suffice for 99% of all usage.
And we could still check for True and handle it like $_WD_RETURN_Value

So I would propose:
Global Const $_WD_RETURN_Raw = False
Global Const $_WD_RETURN_Value = True
Global Const $_WD_RETURN_Element = "[value][" & $_WD_ELEMENT_ID & "]")

and all kind of coding ways should be possible:
Raw
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, $_WD_RETURN_Raw)
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, False)
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, Default)
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, '')

Value
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, $_WD_RETURN_Value)
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, True)
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, "[value]')

element
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, $_WD_RETURN_Element)
Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, "[value][" & $_WD_ELEMENT_ID & "]")

by hand:
`Local $sElement = _WD_ExecuteScript($sSession, $sScript, '', Default, "[value][error]")
`

Personally, I would prefer to see
Global Const $_WD_ESRETURN_Raw = ""
Global Const $_WD_ESRETURN_Value = "[value]"
Global Const $_WD_ESRETURN_Element = "[value][" & $_WD_ELEMENT_ID & "]")

However, it may make more sense to define these as $WD_JSON* so that they can be reused in other portions of the UDF.
Either way, this will still require $sJSONNode to be renamed so that it appropriately reflects the type and usage.

Of course internally True should be still valid.
@TheDcoder  Your opionin ?

I like the approach of using constants instead of arbitrary enums, they provide more flexibility without compromise. As for the actual values of the constants, I am leaning towards this:
Global Const $_WD_RETURN_Raw = False
Global Const $_WD_RETURN_Value = True

Simply because a boolean value is simpler than a string, we have to check both types anyway and checking for boolean by default would be easier. It self-documents the fact that True and False are valid values, otherwise we may have to specify that they're valid in the function header docs.

While boolean values are being supported today, that may not be true forever. Therefore, I'd suggest sticking with the string constants.

that may not be true forever

Why not? As I have expressed previously, I would prefer using them instead of constants.

IDK. It just doesn't feel "natural" to me to design a function to accept multiple variable types when it isn't necessary IMO.

I thought it was one of the highlights of a dynamic-typed language, you can all types with any value :grinning:
Anyway, I know that it's a matter of opinion, I have placed mine before you and as the project leader you have the final say :)

it may make more sense to define these as $WD_JSON* so that they can be reused in other portions of the UDF

Ok

Either way, this will still require $sJSONNode to be renamed so that it appropriately reflects the type and usage.

Yours proporsal for the name is....

I was just thinking about that. My initial idea is to change the name to $vSubNode. Thoughts or other suggestions?

ok
I will introduce an amendment


Feature: nginx dynamic module support

Get rid of trailing whitespace
Feature: nginx dynamic module support

@kriegsmanj: Sorry, we actually do not actively use or support this module. So please don't expect a merge soon.


[av1d] add support av1d multiple sequence headers with different resolution

If there is a new av1 sequence header connected to old one with different resolution, MSDK lib will return MFX_ERR_INCOMPATIBLE_VIDEO_PARAM.
Signed-off-by: ZefuLI<EMAIL_ADDRESS>

@wangyan-intel , can you please review?

@wangyan-intel , can you please review?

@dmitryermilov I have reviewed it in close repo. So it is LGTM. Thanks.


Only one DS18B20 is read

Hi, I have been struggling for several days , cannot find the solution to this issue :
Device ESP8266 (3.3v) USB and externally powered reading 2 Dallas DS18B20, they work in single mode ( one at the time ) tested with 10K, 4K7, 3K3 , 2K2 pull up resistors. I am not using parasite mode.
The only improvement I found was to place these 2 lines before initializing :
digitalWrite(2, HIGH); // <- incantation code: same number as OneWire port
pinMode(2, OUTPUT); //<- incantation code: same number as OneWire port
With those to lines I managed to discover 2 deivces but only one of them is read.
The first one reply its memory address, and proper data. The second one report 000000000 memory address and of course (as per library definition) temp -127 .
Also tested with Method 1.
I have tried almost everything but no success to make it work with 2 sensors.
This is the declaration.
#include <OneWire.h>
#include <DallasTemperature.h>
#define MAX_TEMP_DEVIATION 10
#define MAX_DS18B20_SENSORS 5
/// Data wire is plugged into port 2 on the Arduino
#define ONE_WIRE_BUS 2
// Setup a oneWire instance to communicate with any OneWire devices (not just Maxim/Dallas temperature ICs)
OneWire oneWire(ONE_WIRE_BUS);
// Pass our oneWire reference to Dallas Temperature.
DallasTemperature sensors(&oneWire);
// arrays to hold device addresses
DeviceAddress insideThermometer, outsideThermometer;
and the init function ...
int init_DS18B20(void){
    digitalWrite(2, HIGH); // <- incantation code: same number as OneWire port
    pinMode(2, OUTPUT); //<- incantation code: same number as OneWire port
    Serial.print("Locating devices...");
    sensors.begin();
    Serial.print("Found ");
    Serial.print(sensors.getDeviceCount(), DEC);
    DS18B20_sensor_config.sensors_conunt = sensors.getDeviceCount();
    Serial.println(" devices.");
    // report parasite power requirements
    Serial.print("Parasite power is: ");
    if (sensors.isParasitePowerMode()) Serial.println("ON");
    else Serial.println("OFF");
    // Assign address manually. The addresses below will beed to be changed

// to valid device addresses on your bus. Device address can be retrieved
// by using either oneWire.search(deviceAddress) or individually via
// sensors.getAddress(deviceAddress, index)
// Note that you will need to use your specific address here
//insideThermometer = { 0x28, 0x1D, 0x39, 0x31, 0x2, 0x0, 0x0, 0xF0 };
// Method 1:
// Search for devices on the bus and assign based on an index. Ideally,
// you would do this to initially discover addresses on the bus and then
// use those addresses and manually assign them (see above) once you know
// the devices on your bus (and assuming they don't change).
//      if (!sensors.getAddress(insideThermometer, 0)) Serial.println("Unable to find address for Device 0");
// method 2: search()
// search() looks for the next device. Returns 1 if a new address has been
// returned. A zero might mean that the bus is shorted, there are no devices,
// or you have already retrieved all of them. It might be a good idea to
// check the CRC to make sure you didn't get garbage. The order is
// deterministic. You will always get the same devices in the same order
//
// Must be called before search()
oneWire.reset_search();
// assigns the first address found to insideThermometer
if (!oneWire.search(insideThermometer)) Serial.println("Unable to find address for insideThermometer");
// show the addresses we found on the bus
Serial.print("Device 0 Address: ");
printAddress(insideThermometer);
Serial.println();
delay (1000);
Serial.print("Device 1 Address: ");
printAddress(outsideThermometer);
Serial.println();
// set the resolution to 9 bit (Each Dallas/Maxim device is capable of several different resolutions)
sensors.setResolution(insideThermometer, 9);
sensors.setResolution(outsideThermometer, 9);
    Serial.print("Device 0 Resolution: ");
    Serial.println(sensors.getResolution(insideThermometer), DEC);
    Serial.print("Device 1 Resolution: ");
    Serial.println(sensors.getResolution(outsideThermometer), DEC);
    Serial.println();

    return 0;

}

Some questions:

Do the sensors work with a standard 5V Arduino board?
Can you post the output of the program above?
Do the sensors get hot?

Maybe wires are too long ?

Nothing heard, reopen if it's still a problem


Add pipeline template

Title is self-explanatory.

Codecov Report

Merging #330 (f1e6f33) into main (b516b61) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   69.17%   69.17%
=======================================
  Files         212      212
  Lines        7837     7837
  Branches     1063     1063
=======================================
  Hits         5421     5421
  Misses       2156     2156
  Partials      260      260

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b516b61...f1e6f33. Read the comment docs.

Closing this PR: we'll use the pipeline family templates on the hub as a reference point as opposed to this repo.


Don't patch AdminReadOnlyField#contents

This breaks in 1.8.3. They were doing it to get localization of money
strings in the admin, but we don't really need that.

I'll cut a release on this after I merge, then update the requirements.txt on web to use the new version.

Great, looks good


Handle Deletes for POD/ShareVDE and OCLC

POD/SVDE need a list of FOLIO HRIDs
OCLC needs holdings unset via API.
POD
File with .mrc file extension. Record specified as deleted by using d in position 05 in the MARC Leader
At a minimum, each record should also contain a MARC 001 field identifying the record to delete
Deletes sent as MARC21 binary records may be included in a file with added and updated records
OCLC
Divide records into three groups as specified on https://github.com/sul-dlss/libsys-airflow/pull/912 and submit API request to unset holdings if Record has one or none unique OCLC record id.

PR https://github.com/sul-dlss/libsys-airflow/pull/963 in review in preparation for the Marc transforms needed for the deletes.

Closing in favor of specific tickets for each vendor.


(MAINT) fixed require issue in ubuntu-specific testing

@kevpl For future reference with acceptance fixes: you can use [skip ci] in your commit message body to skip our PR CI process (it doesn't run acceptance tests).

CLA signed by all contributors.


No slash command for pomodoro timer

I installed the plugin sample for pomodoro, and can't see the slash command for creating a new pomodoro for some reason. This happened to me on earlier versions of logseq as well. Not sure what could be the problem. I restarted logseq after installing it as wel
https://user-images.githubusercontent.com/31581044/156960126-4463261d-22a5-4029-ac37-ca7a748b077c.mp4
l

I checked the console and saw this error
main.js:3890 $APP.$cljs$core$ExceptionInfo$$
(anonymous) @ main.js:3890
5main.js:3890 TypeError: Cannot read properties of null (reading 'trim')
    at $APP.$goog$string$internal$trim$$ (main.js:59222)
    at main.js:41586
    at main.js:41593
    at Function.$G__23205__1$$ [as $cljs$core$IFn$_invoke$arity$1$] (main.js:64567)
    at main.js:80674
(anonymous) @ main.js:3890

Ah, silly me. I did not read the instructions and run yarn && yarn build


Create Basic Items

We just need placeholder items as a shell to add more and to test other systems

https://github.com/FailedIndustry/Industrial-Failure/commit/2f817577cf0b40aa0c96f3a23ca3e6ecc04624fd

The item.tscn scene has the framework needed for interactions. We may need to pass some player variables to the item. We can pass the whole player and let the .interact() decide what it needs, but when we do multiplayer we don't want to be passing the entire object around

I'm not sure what POC we can implement with items without https://github.com/FailedIndustry/Industrial-Failure/issues/2 being complete

The item.tscn scene has the framework needed for interactions. We may need to pass some player variables to the item. We can pass the whole player and let the .interact() decide what it needs, but when we do multiplayer we don't want to be passing the entire object around

Instead of doing any of this, we assume that the player is already properly synced and only calling the interact function on the object (which will verify that the player can interact with it properly). It will know what player interacted with it due to RPC's sender ID function and can find the variables themselves.
For interaction functions that require variables to be passed to it to know what kind of interaction to do or how to preform the interaction, those will still have to be passed. But any verification of the player having ability to call the interaction function should all be serverside, along with anything that the server can find with the synced player object

Done via items branch


rbenv-rehash: look for program==ruby*

When "program" is not ruby, but e.g. ruby2.1, it should be handled
specially, too.
I came across this for pyenv.
Some discussion: https://github.com/yyuu/pyenv/pull/368#issuecomment-102810231

Thanks for bringing it to my attention, but not sure about whether I want to support this. Nobody has come up against this in a real-world scenario. Why would someone suffix their ruby executable with a version number if they're not installing under a shared location like /usr/bin, but under RBENV_ROOT/versions?

I guess that's more likely to be the case (or rather only relevant) with pyenv, where you can have multiple versions being active at the same time, e.g. "python3" and "python2".

JRuby historically could execute in different compatibility modes (Ruby 1.8 vs. 1.9 vs. 2.0) but that was decided using command-line flags or environment variables.
I'm going to close this because the only time people choose to suffix the ruby executable is when they are installing in a shared location. This isn't the same case as when rbenv is managing versions.
We can reopen if someone reports that they've hit against this.

Please consider re-opening it: there is more information with the issue for pyenv (where it was merged): https://github.com/yyuu/pyenv/pull/379#issuecomment-120716518

What's the exact issue with symlinks and how does it relate to comparing the program name to "ruby" or "ruby*"?


Seo

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.xpf seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


React Native Android Native UI Components doesn't find @ReactProps

I'm trying to implement a Native UI component for Android but Android Studio cant compile because it doesn't find @ReactProps, this is my code
public class CameraViewManager extends SimpleViewManager<CameraPreview> {

    public static final String REACT_CLASS = "RCTCameraView";

    @Override
    public String getName() {
         return REACT_CLASS;
    }

    @Override
    public CameraPreview createViewInstance(ThemedReactContext context) {
        return new CameraPreview(context);
    }

    @ReactProp(name = "test")
    public void setTest(CameraPreview view, @Nullable String test){
        Log.i("TESTWD", test);
    }

}

If i don't put @ReactProp the code compiles but if i use this component nothing appears

Solved using react-native 0.13.+ instead of 0.11.+


Definition of FusedLeakyRelu

Hi,
I was wondering whether you can explain how the FusedLeakyRelu differs from a regular LeakyRelu. Could not find any reference to such an operation in the original paper.
Thanks :)

FusedLeakyReLU(x) is equivalent to scale * LeakyReLU(x + bias).

Cool, thanks!

I really cannot understand why the authors don't use the offical operators of pytorch, the self defined operation is quiet annoying when I use a different version of pytorch.


Invalid content /en/shelley/get-started/installing-and-running-the-cardano-node/building-the-node-from-source/

Where does the issue occur?
On the Shelley public testnet documentation site.
Describe the issue
While following the instructions to install this on an AWS instance, the "build all" step fails.
Expected changes
Not sure.  "stack build all" was a shot in the dark, but does not seem to be the correct command.

It seems the command should perhaps be "stack build all".

We hope you have resolved this issue. Closing this PR, if you encounter any other problems, please reach out to our support team.

We hope you have resolved this issue. Closing this PR, if you encounter any other problems, please reach out to our support team.


Slate parsing failure.

By deleting characters form the slatepack mwc713 was crashed with error
thread 'main' panicked at 'range start index 1618 out of range for slice of length 1617', /home/vsts/.cargo/git/checkouts/mwc-wallet-9ca0cd1867b6d24c/0ee707d/libwallet/src/slatepack/armor.rs:74:28

Duplicate of https://github.com/mwcproject/mwc-qt-wallet/issues/748


fix replicator FD leak: client side of websocket needs to drain all messages before returning otherwise the underlying connection will not be closed

Coverage decreased (-0.2%) to 67.852% when pulling e256a352d8428b2c850455a5d387ace15e6b5abf on really_fix_FD into 8c9381ac46fea014813841877504f0f5337bb007 on master.


add vintage specific resources

Towards https://github.com/giantswarm/giantswarm/issues/29151

Tested and working on gaia


greatest_common_divisor_efficient

I want to add new function which will count GCD faster.

Not efficient function uses O(n) memory because it needs to ыфму


fix(storybook): Add docgen babel plugin to allow for proptype/comment parsing in prop tables

This adds a dependency on the docgen plugin that parses components for improved prop tables in Storybook. The version provided by the info addon doesn't work with multiple named imports and this dependancy circumvents it. This helps with the opaque defaults, requirement, Proptypes, and especially descriptions in the prop tables. Given that the storybook effectively serves as the documentation, this could go a long way towards making the library more accessible to new-comers.
Before:

After:

Changelog
New

babel-plugin-react-docgen

Changed

added babel-plugin-react-docgen to parse proptypes and documentation for storybook tables.

I think migrating to the withInfo syntax would also make defining modifying these tables' settings globally a little bit easier.  #326


Replace puppet lint rule right_to_left_relationship

Fixed in https://github.com/iwarapter/sonar-puppet/pull/82


log = None cannot complete suppress stdout in GOEnrichmentStudyNS

Thanks for the great project!
I want to stop logging completely, but __init__ function in GOEnrichmentStudy has print regardless of log kwd, so I cannot.
https://github.com/tanghaibao/goatools/blob/d3a63f9738efcdb9f2f49e40cf1fadeb58de9bac/goatools/go_enrichment.py#L256
I think if log is None, nothing should be output to stdout.
This is not a so big problem, but not useful when redirecting or something.

@illumination-k
Thank you for the issue report. I added the fix that considered the log keyword.

@dvklopfenstein
Longer-term, we could move to using logging instead of using prt and log parameter throughout the code, as suggested in #159.


[Test]branch-2.9: fixed eror test case at AdminApiTest2

Contribution Checklist
Fixes #14863
Motivation
see #14863
Modifications

fixed AdminApiTest2 problem test case

brokerNamespaceIsolationPoliciesUpdateOnTime: change immutable list to ArrayList
testDistinguishTopicTypeWhenForceDeleteNamespace: fixed outdated test case.  NamespaceService.getFullListOfTopics at last version not supports dirty data any more.
testMaxTopicsPerNamespace:  fixed outdated test case. 1. Adding asynchronous tests; 2. At last version not allow create system topic by hand-operation

Verifying this change

[x] Make sure that the change passes the CI checks.

Documentation

[ ] doc-required
[x] no-need-doc
[ ] doc

Hi @eolivelli,  file AdminApiTest2 has removed at master, so i submit test-fix to branch-2.9 can you please take a look?


Allow to select model checker version

Currently here the model checker choice is limited to unversioned TLC or Apalache, which defaults to already pretty outdated versions of both. We need to change this scheme as follows:

leave those options, but now they should refer to the latest version of the model checkers bundled with the corresponding modelator release
add versioned options, e.g. TlcVersion(String), and ApalacheVersion(String), that would attempt to download a specific version of model checkers. This will allow both to deterministically fix the MC versions for some tests, as well as to experiment with the newer versions of model checkers.

postponing to v.0.4; integration of recent versions of Apalache will require more work (see #81)

We've discussed setting up integration tests to check the head of modelator against the head of apalche, so we'll get advanced warning of any breakage or needs to patch one way or the other. Andrey noted that this is a pre-requisite for such tests.

This should be implemented as part of mbt-python/mbt-core.


Fix include guards

Our include guards are supposed to start with the project name, which is GOOGLE_CLOUD_CPP_SPANNER_, but https://github.com/googleapis/google-cloud-cpp-spanner/blob/master/ci/check-include-guards.gawk#L29 is requiring that our guards start with GOOGLE_CLOUD_CPP_.
We should fix that script, and fix all the project include guards.

So, for example, we're looking for GOOGLE_CLOUD_CPP_SPANNER_GOOGLE_CLOUD_SPANNER_VERSION_INFO_H_, yes?

Yep. https://google.github.io/styleguide/cppguide.html#The__define_Guard
"All header files should have #define guards to prevent multiple inclusion. The format of the symbol name should be H"
It's verbose, but I think it's what's recommended by the style guide.


Migration: Component Unauthorised.coffee documentation

Description
This pull request has been created with a markdown document for the component "Unauthorised.coffee" by reviewing the project task Migration Unauthorised.coffee.
It is used to handle errors and if it needs access permissions this displays the error message. if the user has been distracted from the system for a longer time (specific type period), the system displays that the "session has expired!".
this enhance the security, privacy and intergrity of the system.
This is component combination of unauthorised.coffee and unauthorised.tpl.html
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as
expected)
[x] Documentation (update or new)
[ ]

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have requested a review from ... on the Pull Request

@s222356873 will be reviewing this

Reviewed 17/04/2024
##Purpose
Display the error message for access authorization and session timeout
##Outcomes
A message should display notifying customer to take action.
##Proposal
Considering the proposed changes , It has enhance the user experience with buttons and the clear instruction about the next action that user should take after getting the error message.
##Other notes
Overall the markdown document is successfully done. And ready for the migration.


add Bogus to list

This is great, thanks. I had no idea this existed.

You're most welcome! Adding this was a suggestion from a fellow user on daily.dev 🙂.


fixes in context-aware (#512)

Aaagh, such a silly error. We were copying the byPtr map instead of obtaining a reference to it.
Refs #512
Fixes #516

Confirmed this fixes the issue, thanks @mildsunrise


[BUG] DiscordAPI Missing Permission

Describe the bug
Not sure where is this coming from, but it keeps throwing a DiscordAPIError: Missing Permissions error at certain interval time.
To Reproduce
Steps to reproduce the behavior:

Starts the bot in production mode
Type pm2 log in the terminal
See error

Expected behavior
The current permissions integers should be logically correct. Or perhaps there's one of the features that requires admin privilege?
Screenshots

this can be caused by a number of things that could be out of our reach
Permissions

oh well.. i guess this bug gonna stay for a while,


When UN_WEBSERVER_METRICS is enable logs are spammed

My unpackerr logs are being spammed with...
<IP_ADDRESS> - - [26/Feb/2024:21:52:25 -0500] "GET /metrics HTTP/1.1" 200 1879 "-" "Prometheus/2.49.1"

It would be nice if these could be could be silenced  or sent to a different logging channel (e.g. trace)

Set a log file for the web server.
https://github.com/Unpackerr/unpackerr/blob/main/examples/unpackerr.conf.example#L66

Thanks for the fast reply, can this be /dev/null? 🤣

Let me know?

I had to set it to a file path on disk, but it's a Kubernetes emptyDir so that's fine. Thanks for the quick reply!


Use HTTPS URL for example Podfile

This way, does not require the user to have a GitHub account setup with
an SSH key.
Fixes #5

Yes sir! :+1: :shipit:


_.eq redundant comparison when both null

in _.eq function:
 eq = function(a, b, aStack, bStack) {
    // Identical objects are equal. `0 === -0`, but they aren't identical.
    // See the [Harmony `egal` proposal](http://wiki.ecmascript.org/doku.php?id=harmony:egal).
    if (a === b) return a !== 0 || 1 / a === 1 / b;
    // A strict comparison is necessary because `null == undefined`.
    if (a == null || b == null) return a === b;
   ......
}

a === b is true when a = null and b = null, so the function will return true.
and then, if (a == null || b == null) is true, return a === b.
It would never be true, why not directly return false:
if (a == null || b == null) return false;

I checked the #2180 and #2179 , but I still don't understand why not directly return false?

Yah, looks like we could. Want to open a PR?

Nice, I have opened a PR #2630

@ahonn since we are using a == null || b == null, a and b could be null or undefined due to == not being a strict equal comparison. Hence a === b is needed to ensure that a and b are not the same, if one is null and the other is undefined.

Yes, but we've already done a a === b check above it. So, if either a or b is null or undefined, we know that both aren't.

Yes, but we've already done a a === b check above it

Ah, I completely missed that :| Thanks @jridgewell!

When running if (a == null || b == null) ..., a === b would never be true.
Because if a === b is true, will return a !== 0 || 1 / a === 1 / b. So, That must be false.


Readme fixes and indentation

The readme file mentions the paystream folder when running the project for the first time.
I think this is an issue (may be other name of streamium) so removing it to the latest one.
Then there are indentation fixes.

Thanks!


Sx126x Receive Irq race condition

In the SX126x::process_irq_event, it is possible for the system to be waiting for an interrupt from the radio that will never happen, as it was already processed. If the radio signals both "PreambleDectected" and "RxTxTimeout" in the same read of the IRQStatus, process_irq_event will return that a preamble was detected, and the outer loop in LoRa::rx will continue to wait for a timeout or reception. At the same time, the radio has already signaled the timeout event, and so the code waits for an IRQ that will never come.
Of course, like any good race condition, it only shows up with heavier CPU loading.
There are three possible ways I have thought about for solving this:

Make wait_for_irq have a timeout, and return Err(RxTimeout) in that case. Tested, functional, but discarded due to hard dependency of the interface variant on knowing how long the radio will take for any operation, especially where that is variable on the user's configuration.
Switch the check in process_irq_events such that it checks for timeout first, and then preamble detected. I have tested this, it has been running on my testbench sending and receiving about ten messages (and about 40 calls to RxSingle) per second for approximately 50 minutes so far. I would be happy to create this as a pull request with my patch if there aren't any more subtle issues that anybody can think of by doing this.
It may be possible to only clear the IRQ flags that the code is checking on any particular run, but that would need extra care to make sure that everything handles the change to the interrupt line and needing to poll process_irq until it returns no irqs. A quick check seems to indicate that both the STM32WL and the GenericInterfaceVariants will correctly handle this case where the IRQ line is high on entry. However, as my patch in 2 appears to be working, I have not further investigated this solution.

My current platform is an STM32WL.
I have attached Saleae captures of the SPI/BUSY/IRQ lines, there are timing markers placed on the start of the GetIrqStatus transactions.
Without my patch.zip
With my patch.zip

Yeah, sorry, I seem to have failed to link things in my issue correctly. You are correct. Sorry for making you have to figure out what I meant.
I'll edit my initial post for posterity to have the right links.


refactor(wallet): inheritance-based partial providers

Context
An alternative approach to solve problem described in #306
Note: this PR is to be merged into #306 and not master.
Proposed Solution
This PR reverts the generics-based approach commits and adds a commit to demonstrate a new approach: e61e600faec199ed99330319aa95fa5630475533
You may also look at the diff between the 2 branches to see the differences.

Closing in favor of #306


Update valine.swig

New valine version released.
"#vcomment" does not work because the id of comment element is "comment", so it should be modified by "#comment".

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines.
[x] Tests for the changes have been added (for bug fixes / features).

[x] Muse | Mist have been tested.
[x] Pisces | Gemini have been tested.

[x] Docs have been added / updated (for bug fixes / features).

PR Type
What kind of change does this PR introduce?

[x] Bugfix.
[ ] Feature.
[ ] Code style update (formatting, local variables).
[ ] Refactoring (no functional changes, no api changes).
[ ] Build related changes.
[ ] CI related changes.
[ ] Documentation content changes.
[ ] Other... Please describe:

What is the current behavior?

Issue Number(s): #1933
What is the new behavior?
Now valine can work.

Screens with this changes: N/A
Link to demo site with this changes: N/A

How to use?
N/A
Does this PR introduce a breaking change?

[ ] Yes.
[x] No.

Thanks!


feat(golf): add normalize package to normalize styles across all brow…

…sers
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
Inconsistencies in default styles
Fixes: N/A
What is the new behavior?
Better cross-browser consistency in the default styling of HTML elements.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@xelaint this has a build error that needs to be checked out.


Update documentation to reflect changes.

Obviously, this fork entailed a lot of changes to the original repository.
All such changes should be documented appropriately in package-specific READMEs, at the minimum.

#6 has achieved part of this task, but more work remains particularly for trak_ik_kinematics_plugin and trac_ik_python.


Auto-generated HTML documentation with doxygen

Make Travis do this and publish it!

Not perfect, but this took 2 clicks to set up:
https://codedocs.xyz/zbanks/radiance/hierarchy.html

http://zbanks.github.io/radiance/annotated.html


fix: disables input field for form name on published forms

Summary | Résumé
The form name component appears to be editable after publishing even though it doesn't update or save
The easiest way to fix this is by simply disabling the input field when a form is published

Before
After

Test instructions | Instructions pour tester la modification
Published forms:

Publish a form
Go to the settings of the form
Click on the form name. It should not be editable.

Unpublished forms:

Go to an unpublished form
Click on the form name. It should still be editable and saves on "Save on draft" or by clicking on another page.

Pull Request Checklist
Please complete the following items in the checklist before you request a review:

[x] Have you completely tested the functionality of change introduced in this PR? Is the PR solving the problem it's meant to solve within the scope of the related issue?
[ ] The PR does not introduce any new issues such as failed tests, console warnings or new bugs.
[ ] If this PR adds a package have you ensured its licensed correctly and does not add additional security issues?
[ ] Is the code clean, readable and maintainable? Is it easy to understand and comprehend.
[ ] Does your code have adequate comprehensible comments? Do new functions have docstrings?
[ ] Have you modified the change log and updated any relevant documentation?
[ ] Is there adequate test coverage? Both unit tests and end-to-end tests where applicable?
[ ] If your PR is touching any UI is it accessible? Have you tested it with a screen reader? Have you tested it with automated testing tools such as axe?

Tested and works well :) one thing ...
It would be nice to remove the hover state for the input that is disabled


adds title to also be translated in campaign run nodes

What does this PR do?
Adds title field to be also translated in campaign runs (was forgotten about in #6037)
How should this be manually tested?
In your vagrant, run drush updb -y in dosomething@dev:/var/www/dev.dosomething.org/html$
What are the relevant tickets?
#6037 and #5961

:+1:


Create a footer blue-11

One need to make this component using HTML and Tailwind CSS. I would suggest to use Tailwind Playgrounds to make things faster and quicker.
Here is a reference to the component.

After building the component please raise a PR with a screenshot of the component and add the component in Footer/footer-blue11.html.
If you need to use any icon please use it from Hero Icons
Good luck.

Can you assign me @rupsha014

Go ahead @AmitDeka

Done @Rajdip019


Documentation for 404.html, 500.html templates

This mechanism is not documented: https://github.com/simonw/datasette/blob/30b98e4d2955073ca2bca92ca7b3d97fcd0191bf/datasette/app.py#L1119-L1129

Also link to these from the docs added in #964.

In documenting this I realized that it's confusing that the default 500.html template is often used for non-500 errors (404 for example). I think I'll rename that default template to error.html instead.

Documented here: https://docs.datasette.io/en/latest/custom_templates.html#custom-error-pages


Add RepaintBoundary to improve scroll performance

Fixes https://github.com/flutter/flutter/issues/25372
Before:

After:

I'm closing this as we've cherry picked this change before making the repository public. Please open an issue if anyone is concerned about the changes made here.