Install profile

Pulls in all the work to use Born Digital's new install profile.

I just tried this out on a clean checkout of isle-dc and it didn't complete successfully:
$ git checkout -b install-profile origin/install-profile
Branch install-profile set up to track remote branch install-profile from origin.
Switched to a new branch 'install-profile'
$ cp sample.env .env
$ make local
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5596  100  5596    0     0   8757      0 --:--:-- --:--:-- --:--:--  8743
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1704  100  1704    0     0   5958      0 --:--:-- --:--:-- --:--:--  5958
docker-compose pull
Pulling activemq   ... done
Pulling alpaca     ... done
Pulling blazegraph ... done
Pulling cantaloupe ... done
Pulling fcrepo     ... done
Pulling fits       ... done
Pulling crayfits   ... done
Pulling homarus    ... done
Pulling houdini    ... done
Pulling hypercube  ... done
Pulling mariadb    ... done
Pulling matomo     ... done
Pulling milliner   ... done
Pulling recast     ... done
Pulling solr       ... done
Pulling traefik    ... done
Pulling drupal     ... done
Unable to find image 'islandora/nginx:c2d65aee856887b49b2cbf889060e549a83e4946' locally
c2d65aee856887b49b2cbf889060e549a83e4946: Pulling from islandora/nginx
Digest: sha256:7df17a78c0554243bee046c81bdb0ac1b5bcfa16fe2a2930fbf94744c9aba6ee
Status: Downloaded newer image for islandora/nginx:c2d65aee856887b49b2cbf889060e549a83e4946
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 00-container-environment-00-init.sh: executing...
[cont-init.d] 00-container-environment-00-init.sh: exited 0.
[cont-init.d] 00-container-environment-01-override-nginx.sh: executing...
[cont-init.d] 00-container-environment-01-override-nginx.sh: exited 0.
[cont-init.d] 00-container-environment-01-override-php.sh: executing...
[cont-init.d] 00-container-environment-01-override-php.sh: exited 0.
[cont-init.d] 00-container-environment-02-database-defaults.sh: executing...
[cont-init.d] 00-container-environment-02-database-defaults.sh: exited 0.
[cont-init.d] 01-confd-render-templates.sh: executing...
[cont-init.d] 01-confd-render-templates.sh: exited 0.
[cont-init.d] 02-fpm-install.sh: executing...
[cont-init.d] 02-fpm-install.sh: exited 0.
[cont-init.d] 02-ngnix-install.sh: executing...
[cont-init.d] 02-ngnix-install.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
Cloning into '/tmp/codebase'...
[27-Jul-2021 18:01:23] NOTICE: fpm is running, pid 727
[27-Jul-2021 18:01:23] NOTICE: ready to handle connections

  [InvalidArgumentException]
  Package islandora/islandora_profile exists in composer repo (https://repo.packagist.org) and package repo (defining 1 package) which has a higher repository priority. The packages with higher priority do not match your constraint and are therefore not installable. See https://getcomposer.org/repoprio for details and assistance.

require [--dev] [--dry-run] [--prefer-source] [--prefer-dist] [--fixed] [--no-suggest] [--no-progress] [--no-update] [--no-install] [--no-scripts] [--update-no-dev] [-w|--update-with-dependencies] [-W|--update-with-all-dependencies] [--with-dependencies] [--with-all-dependencies] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [--sort-packages] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--] [<packages>]...

[cmd] with-contenv exited 1
[27-Jul-2021 18:01:32] NOTICE: Terminating ...
[27-Jul-2021 18:01:32] NOTICE: exiting, bye-bye!
[cont-finish.d] executing container finish scripts...
[cont-finish.d] done.
[s6-finish] waiting for services.
[services.d] service fpm finish: executing...
[services.d] service fpm exiting with exit code: 0
s6-svwait: fatal: supervisor died
[services.d] service nginx finish: executing...
[services.d] service nginx exiting with exit code: 0
[s6-finish] sending all processes the TERM signal.
[s6-finish] sending all processes the KILL signal and exiting.
make: *** [local] Error 1

@seth-shaw-unlv try again- I just pushed a small patch for this issue. @dannylamb put install_profile in packagist, which means we can remove the package declaration https://github.com/Islandora-Devops/islandora-project/pull/2

Status update - @dannylamb is going to get this back to the point where Composer installs cleanly, and then I'll jump back in and see if all the configs are landing correctly.

This works with make demo but not with make local.  I'm currently investigating what the difference is between the two codebases and trying to bring them into alignment.

This works now with make local. Haven't tested anything super thoroughly, but the site comes up now.
The issue was with trying to use https://github.com/islandora-devops/islandora-project.  There's some additional things I added to the composer.json in https://github.com/Islandora-Devops/islandora-sandbox that would need to be added.  Mostly just stuff around the config sync / config split directories.

I can confirm that this works - thanks @dannylamb !
@seth-shaw-unlv this is ready for re-testing. Just git pull, sudo rm -rf codebase and make local and you should be back in action.

Actually, if we can get confirmation that this is in a good working state, I'd love to move forward with merging PR...

I started it up yesterday but it appeared to hang and I didn't get to take a closer look before I left for the day. Unfortunately I'm now stuck at home until we can confirm that the fever one of my kids developed isn't COVID. I can test as soon as I can get back to the office, but if someone else beats me to it, that would be great.

Hello Seth
Hope ur kid is feeling better.
Have you tested this?
I did but it gave me error on installing modules?
Thanks
On Wed, 4 Aug 2021 at 10:21 PM Seth Shaw @.***> wrote:

I started it up yesterday but it appeared to hang and I didn't get to take
a closer look before I left for the day. Unfortunately I'm now stuck at
home until we can confirm that the fever one of my kids developed isn't
COVID. I can test as soon as I can get back to the office, but if someone
else beats me to it, that would be great.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Islandora-Devops/isle-dc/pull/160#issuecomment-892911197,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD2TQTNLZ254FQGLTMG7FF3T3GHK3ANCNFSM44C3PLMQ
.

--
Yamen Saleh

Actually the error is on run Islandora Migrations, (output below)
In bootstrap.inc line 230:
The configuration directory type 'sync' does not exist
site:install [--db-url DB-URL] [--db-prefix DB-PREFIX] [--db-su DB-SU]
[--db-su-pw DB-SU-PW] [--account-name [ACCOUNT-NAME]] [--account-mail
[ACCOUNT-MAIL]] [--site-mail [SITE-MAIL]] [--account-pass ACCOUNT-PASS]
[--locale [LOCALE]] [--site-name [SITE-NAME]] [--site-pass SITE-PASS]
[--sites-subdir SITES-SUBDIR] [--config-dir CONFIG-DIR] [--existing-config]
[-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi]
[--no-ansi] [-n|--no-interaction] [-d|--debug] [-y|--yes] [--no]
[--remote-host REMOTE-HOST] [--remote-user REMOTE-USER] [-r|--root ROOT]
[-l|--uri URI] [--simulate] [--pipe] [-D|--define DEFINE] [--xh-link
XH-LINK] [--druplicon] [--notify [NOTIFY]] [--]  []...
[sudo] password for yamen:
Command pm:enable was not found. Drush was unable to query the database.
As
a result, many commands are unavailable. Re-run your command with
--debug
to see relevant log messages.
Command config:set was not found. Drush was unable to query the database.
A
s a result, many commands are unavailable. Re-run your command with
--debug
to see relevant log messages.
Command config:set was not found. Drush was unable to query the database.
A
s a result, many commands are unavailable. Re-run your command with
--debug
to see relevant log messages.
Command role:list was not found. Drush was unable to query the database.
As
a result, many commands are unavailable. Re-run your command with
--debug
to see relevant log messages.
Command role:create was not found. Drush was unable to query the
database.
As a result, many commands are unavailable. Re-run your command with
--debu
g to see relevant log messages.
Command user:role:add was not found. Drush was unable to query the
database
. As a result, many commands are unavailable. Re-run your command with
--de
bug to see relevant log messages.
make[1]: [Makefile:137: update-config-from-environment] Error 1 (ignored)
Command pm:enable was not found. Drush was unable to query the database.
As
a result, many commands are unavailable. Re-run your command with
--debug
to see relevant log messages.
Command config:import was not found. Drush was unable to query the
database
. As a result, many commands are unavailable. Re-run your command with
--de
bug to see relevant log messages.
make[1]: [Makefile:138: update-config-from-environment] Error 1 (ignored)
Command pm-list was not found. Drush was unable to query the database. As
a
result, many commands are unavailable. Re-run your command with --debug
to
see relevant log messages.
Command pm:enable was not found. Drush was unable to query the database.
As
a result, many commands are unavailable. Re-run your command with
--debug
to see relevant log messages.
Command pm:uninstall was not found. Drush was unable to query the
database.
As a result, many commands are unavailable. Re-run your command with
--deb
ug to see relevant log messages.
make[1]: [Makefile:140: update-config-from-environment] Error 1 (ignored)
Command pm-list was not found. Drush was unable to query the database. As
a
result, many commands are unavailable. Re-run your command with --debug
to
see relevant log messages.
Command pm-list was not found. Drush was unable to query the database. As
a
result, many commands are unavailable. Re-run your command with --debug
to
see relevant log messages.
Command pm-list was not found. Drush was unable to query the database. As
a
result, many commands are unavailable. Re-run your command with --debug
to
see relevant log messages.
Command pm-list was not found. Drush was unable to query the database. As
a
result, many commands are unavailable. Re-run your command with --debug
to
see relevant log messages.
Waiting for 80 on blazegraph to open.
% Total    % Received % Xferd  Average Speed   Time    Time     Time
Current
Dload  Upload   Total   Spent    Left
Speed
100   736  100    18  100   718     34   1359 --:--:-- --:--:-- --:--:--
1391
% Total    % Received % Xferd  Average Speed   Time    Time     Time
Current
Dload  Upload   Total   Spent    Left
Speed
100   283  100    61  100   222     36    132  0:00:01  0:00:01 --:--:--
169
Command migrate:import was not found. Drush was unable to query the
databas
e. As a result, many commands are unavailable. Re-run your command with
--d
ebug to see relevant log messages.
make[1]: *** [Makefile:149: run-islandora-migrations] Error 1
make: *** [Makefile:354: local] Error 2
On Sat, Aug 7, 2021 at 2:54 PM Yamen Saleh @.***> wrote:

Hello Seth
Hope ur kid is feeling better.
Have you tested this?
I did but it gave me error on installing modules?
Thanks
On Wed, 4 Aug 2021 at 10:21 PM Seth Shaw @.***> wrote:

I started it up yesterday but it appeared to hang and I didn't get to
take a closer look before I left for the day. Unfortunately I'm now stuck
at home until we can confirm that the fever one of my kids developed isn't
COVID. I can test as soon as I can get back to the office, but if someone
else beats me to it, that would be great.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Islandora-Devops/isle-dc/pull/160#issuecomment-892911197,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD2TQTNLZ254FQGLTMG7FF3T3GHK3ANCNFSM44C3PLMQ
.

--
Yamen Saleh

--
Yamen Saleh

He is feeling better, thanks! Fortunately it wasn't COVID.
That said, I haven't been back to my office yet where I was testing this. I can give it a go on Monday.

I came back to the office this morning and realized that it hadn't completed running before I left the office and was still waiting for a password. So I had it finish running.  (See the attached terminal output: isle-born-digital.log.)
It appears to be working although there are some oddities about it:
Going to the front page just after it finished gave me a 404:

And after I created my first object it became my homepage:

Also, I had to use the OpenSeadragon display hint because without it we only see the original file download link, rather than the Jpeg service file:

Yes, finally it worked, but i had to use the demo values with the
local environment in the .env file to get it working properly
ENVIRONMENT=local
If you're just demoing or are starting from scratch, use this.
INSTALL_EXISTING_CONFIG=false
DRUPAL_INSTALL_PROFILE=islandora_install_profile_demo
and i have the same scenario Seth had
On Mon, Aug 9, 2021 at 9:31 PM Seth Shaw @.***> wrote:

I came back to the office this morning and realized that it hadn't
completed running before I left the office and was still waiting for a
password. So I had it finish running.  (See the
attached terminal output: isle-born-digital.log
https://github.com/Islandora-Devops/isle-dc/files/6956503/isle-born-digital.log
.)
It appears to be working although there are some oddities about it:
Going to the front page just after it finished gave me a 404:
[image: Screen Shot 2021-08-09 at 11 17 29 AM]
https://user-images.githubusercontent.com/29869988/128754836-9fcdcda8-79a7-45d3-ad01-948aa4619d7d.png
And after I created my first object it became my homepage:
[image: Screen Shot 2021-08-09 at 11 23 38 AM]
https://user-images.githubusercontent.com/29869988/128755555-b0285268-e105-4eca-9db8-264643072f0f.png
Also, I had to use the OpenSeadragon display hint because without it we
only see the original file download link, rather than the Jpeg service file:
[image: Screen Shot 2021-08-09 at 11 26 03 AM]
https://user-images.githubusercontent.com/29869988/128755569-a0af971b-e2f3-4729-9b7f-2a33d6163665.png
[image: Screen Shot 2021-08-09 at 11 26 50 AM]
https://user-images.githubusercontent.com/29869988/128755582-c5668ef5-829f-41fd-be4c-527312df5e7b.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Islandora-Devops/isle-dc/pull/160#issuecomment-895444262,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD2TQTPTNUQ2SJKBQUKUMFTT4ANGLANCNFSM44C3PLMQ
.

--
Yamen Saleh

Brought in upstream changes to resolve conflicts.

@dannylamb Is this ready to test?

Yes, make demo-install-profile and make local-install-profile should all bring you up a newly improved and d9 site with islandora_install_profile_demo.
Just make sure you set ENVIRONMENT=local or ENVIRONMENT=demo as appropriate in your .env file.

fixed the merge conflict :sweat_smile:

@dannylamb I was left more confused about where this is going. Are we trying to get this merged in or was there something else that we're doing?

This depends on a lot of stuff.  If you merge it now it works, and make local and make demo are unchanged.  But there's install_profile and bd-d9-updates branches for various repos you'll want to merge in as well.

https://github.com/Islandora-Devops/isle-buildkit/tree/install-profile
https://github.com/Islandora-Devops/islandora_install_profile_demo/tree/bd-d9-update
https://github.com/Islandora-Devops/islandora-sandbox/tree/install-profile
https://github.com/Islandora-Devops/islandora_base_theme/tree/bd-d9-updates
https://github.com/Islandora-Devops/islandora_starter_theme/tree/bd-d9-update

I'm swamped now but can make those PRs for those branches, though presumable everybody here as permissions to do that if they'd like. I didn't get around to making them b/c I wanted to QA it all a bit first since folks usually immediately descend onto a PR that isn't quite ready yet :sweat_smile:

Also, just to be clear, this doesn't change make local or make demo.  All the new stuff is under make demo-install-profile and make local-install-profile.

@dannylamb are you seeing during during the build this error? I ran make demo-install-profile
In SolrCommandHelper.php line 41:
  Unknown server

search-api-solr:get-server-config [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-d|--debug] [-y|--yes] [--no] [--remote-host REMOTE-HOST] [--remote-user REMOTE-USER] [-r|--root ROOT] [-l|--uri URI] [--simulate] [--pipe] [-D|--define DEFINE] [--xh-link XH-LINK] [--notify [NOTIFY]] [--druplicon] [--] <command> <server_id> [<file_name>] [<solr_version>]

unzip: can't open /tmp/ISLANDORA/solr_config.zip[.zip]
Waiting for 8983 on solr to open.

@dannylamb To test this, am I expected to run make demo then make demo-install-profile?

But there's install_profile and bd-d9-updates branches for various repos you'll want to merge in as well.
https://github.com/Islandora-Devops/isle-buildkit/tree/install-profile
https://github.com/Islandora-Devops/islandora_install_profile_demo/tree/bd-d9-update
https://github.com/Islandora-Devops/islandora-sandbox/tree/install-profile
https://github.com/Islandora-Devops/islandora_base_theme/tree/bd-d9-updates
https://github.com/Islandora-Devops/islandora_starter_theme/tree/bd-d9-update

See:

https://github.com/Islandora-Devops/isle-buildkit/pull/170
https://github.com/Islandora-Devops/islandora_install_profile_demo/pull/5
https://github.com/Islandora-Devops/islandora-sandbox/pull/5
https://github.com/Islandora-Devops/islandora_base_theme/pull/2
https://github.com/Islandora-Devops/islandora_starter_theme/pull/4

From scratch without any modifications running make demo results in many errors including Failed to chmod file "/var/www/drupal/web/sites/default/settings.php".
  Command migrate:import was not found. Drush was unable to query the databas
  e. As a result, many commands are unavailable. Re-run your command with --d
  ebug to see relevant log messages.

make[1]: *** [Makefile:150: run-islandora-migrations] Error 1
make[1]: Leaving directory '/home/admin/isle-dc'
make: *** [Makefile:322: demo] Error 2

@Natkeeran and @alxp does this match your understanding of where you left things in the last Sprint? What is the path forward here?

Prior to testing I wiped out all things docker to test on a vanilla install. Testing was done on Linux machine running on the most recent commit #ca1d24b

Docker version 20.10.12, build e91ed57
docker-compose version 1.29.2, build 5becea4c
Afterwords I also tested updating the sample.env locally prior to building with no difference. As a last ditch effort I tried to run it with codeserver knowing it builds the stack a little differently but again no luck.

Also just tried with Docker Compose version v2.2.3 in case the docker-composer version mattered but it didn't make any difference.

This code is intended to make make local-install-profile and make demo-install-profile work. In order to "not clobber" they were given separate commands, but originally these just overwrote make local and make demo with the install profile versions. But because of how make demo works, i don't think it's in a good state. It pulls the latest container from dockerhub that was populated by buildkit, and I think this is now the one designed for the install profile (since buildkit only builds one demo box and the newer ones were made for the install profile).
I think that make local should work. In my personal opinion it should be fine to remove the original make demo and just let the install profile version be our demo.  it's been very lonely in the discussion of what the build options should be, so please feel free to chime in.

I support Rosie's proposal

In my personal opinion it should be fine to remove the original make demo and just let the install profile version be our demo.

To test this, do I need to use TAG=aed5adc95784c1dd24589a0f77c3bbb063c92113 or can i use the latest isle-dc tagged version?

Regarding the commit tag, Buildkit still has an 'install-profile' branch (and a PR to merge it to main) so I think it should be the most recent commit from that branch.
Sorry bout the conflicts - seems like it should be okay to include all the new variables? Do they affect the install profile?

Rebase attempted. https://github.com/Islandora-Devops/isle-buildkit/pull/170

I just ran the make demo-install-profile task and everything seemed to build happily.  I did notice that the homepage shows a 404.

I did notice that when setting a custom domain the step for setting demo-data/homepage.json fails out
 [notice] Rolled back 13 items - done with 'islandora_defaults_tags'
make[1]: Entering directory '/klib/app/docker-compose/isle-dc'
curl -u admin:<PASSWORD> -H "Content-Type: application/json" -d<EMAIL_ADDRESS>https://islandora.SERVER.net/node?_format=json
curl: (60) SSL: no alternative certificate subject name matches target host name 'islandora.SERVER.net'
More details here: https://curl.haxx.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.
make[1]: *** [Makefile:391: initial_content] Error 60
make[1]: Leaving directory '/klib/app/docker-compose/isle-dc'
make: *** [Makefile:384: local-install-profile] Error 2

I don't know if it would be better to have curl ignore the ssl cert errors during install?

Maybe that just needs a -k ? https://curl.se/docs/manpage.html#-k

I noticed while running through make local-install-profile again that there was a couple of errors (listed below). Are these anything to be concerned about?
WARNING: Some services (activemq, alpaca, blazegraph, cantaloupe, crayfits, drupal, fcrepo, fits, homarus, houdini, hypercube, mariadb, matomo, milliner, recast, solr, traefik) use the 'deploy' key, which will be ignored. Compose does not support 'deploy' configuration - use `docker stack deploy` to deploy to a swarm.
--driver mysql
--host mariadb
--port 3306
--dbuser drupal_default
--dbpassword <password>
--dbname drupal_default
PROFILE: islandora_install_profile_demo
<EMAIL_ADDRESS>--account-name=admin
--account-pass=1vagVTs86Cp6LkjjYVynHRwcZ8gdTQwzFXzlMQ1qiR1P1BDO
<EMAIL_ADDRESS>--locale=en
--site-name=Default
--sites-subdir=default
USE_EXISTIG_CONFIG:
EVERYTHING ELSE:
Installing site.
-n si islandora_install_profile_demo<EMAIL_ADDRESS>--account-name=admin --account-pass=<password><EMAIL_ADDRESS>--locale=en --site-name=Default --sites-subdir=default --db-url=mysql://drupal_default:<password>@mariadb:3306/drupal_default

 You are about to:
 * Create a sites/default/settings.php file
 * DROP all tables in your 'drupal_default' database.

 [notice] Starting Drupal installation. This takes a while.
 [notice] Performed install task: install_select_language
 [notice] Performed install task: install_select_profile
 [notice] Performed install task: install_load_profile
 [error]  Error importing/updating configuration
 [error]  Error importing/updating configuration
 [notice] Performed install task: install_verify_requirements
 [notice] Performed install task: install_settings_form
 [notice] Performed install task: install_verify_database_ready
 [notice] Performed install task: install_base_system
 [notice] Performed install task: install_bootstrap_full
 [warning] Could not find required jsonld.settings to add default RDF namespaces.
 [warning] The "views_block:members-block_1" was not found
 [error]  Error getting JWT token for message. Check JWT Configuration.
 [error]  Error getting JWT token for message. Check JWT Configuration.
 [notice] Performed install task: install_profile_modules
 [notice] Performed install task: install_profile_themes
 [notice] Performed install task: install_install_profile
 [notice] Performed install task: install_configure_form
 [notice] Performed install task: islandora_install_profile_demo_grant_shortcut_access
 [notice] Performed install task: islandora_install_profile_demo_set_default_theme
 [notice] Performed install task: islandora_install_profile_demo_finish_install
 [notice] Performed install task: install_finished
 [success] Installation complete.

My experience (backed up by @dannylamb) is that these errors are benign. It would be nice to eliminate them, but maybe we should acknowledge them in the docs until that's done?

Something is up, I've tested this from a completely clean environment (cleared all docker cached images and configurations). Running make local, make demo, and make local-install-profile all resulting in several errors. All of which block it from fully building. I can run the make local and make demo from the development branch without any issues.

@DonRichards what I I ended up doing was rebasing this branch against development. Not sure if someone could do that in this PR and make it a little easier to test?

After a rebase locally I'm seeing this during the build and I'm not completely sure what to look for sinse Defaults is included as well as sandbox. It does appear to me that this might be working.
...
Installing site.
-n si islandora_install_profile_demo<EMAIL_ADDRESS>--account-name=admin --account-pass=password<EMAIL_ADDRESS>--locale=en --site-name=Default --sites-subdir=default --db-url=mysql://drupal_default:password@mariadb:3306/drupal_default

 You are about to:
 * Create a sites/default/settings.php file
 * DROP all tables in your 'drupal_default' database.

 [notice] Starting Drupal installation. This takes a while.
 [notice] Performed install task: install_select_language
 [notice] Performed install task: install_select_profile
 [notice] Performed install task: install_load_profile
 [error]  Error importing/updating configuration
 [error]  Error importing/updating configuration
 [notice] Performed install task: install_verify_requirements
 [notice] Performed install task: install_settings_form
 [notice] Performed install task: install_verify_database_ready
 [notice] Performed install task: install_base_system
 [notice] Performed install task: install_bootstrap_full
[warning] Could not find required jsonld.settings to add default RDF namespaces.
 [warning] The "views_block:members-block_1" was not found
 [error]  Error getting JWT token for message. Check JWT Configuration.
 [error]  Error getting JWT token for message. Check JWT Configuration.

Should I push the rebase?

If one of you is capable of pushing your rebase to this branch that would be great, I see it as something outside my skill level.

@rosiel I'm just waiting on some confirmation just in case this messes someone else up.

Well I guess 2 weeks is long enough. I'll start the rebase process.

@wgilling will be testing this today or early next week

Ok - here are my results today.  Success. I cloned the isle-dc project locally and changed to this install-profile branch, ran the make demo-install-profile and it completed without any failures and the resultant local website looks fine.
I added some taxonomy values for Family entities to refer to with one of the fields that is indexed by the default Solr config and was able to search for the related item based on the family name value. I even made a collection item and related the items to the collection and search and all other functionality worked as expected.
The only errors during the internal Makefile's islandora_install_profile_demo method were:
    [notice] Performed install task: install_load_profile
    [error] Error importing/updating configuration
    [error] Error getting JWT token for message. Check JWT Configuration.

I am not sure that those errors are critical or would needed addressed. Please let me know if any clarification is needed.

If the site functions, then that can be ignored.  That function runs twice iirc, so one failure out of the two i think is normal.  TL;DR if you can make a derivative or put something in Fedora, then JWTs are properly configured and there's no issue.

Our testing found a duplicate function in the Makefile which I have now removed.

We've tested this again. Don's rebase is good, and we (Born-Digital) recommend that this be merged. I assume that someone else needs to hit the button, though?

I don't think I have any code in this, so I'll hit the button.

YAY thanks Rosie!

Thanks everyone!


HtmlTreeBuilderState.InHead missing in HtmlTreeBuilder.java?

jsoup-1.13.1.jar
jsoup-1.13.1-sources.jar
When parsing a html string I was having an issue with
Unexpected token [StartTag] when in state [InBody] 7
That made me visit the issues list and have a look into the code.
method void resetInsertionMode()
           } else if ("head".equals(name)) {                 transition(HtmlTreeBuilderState.InBody);                 break; // frag
Should the state not be InHead ?

Thanks, looks like the spec (https://html.spec.whatwg.org/multipage/parsing.html#the-insertion-mode) has been updated. Fixed.


Exec tachikoma update<PHONE_NUMBER>3332

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage remained the same at 67.647% when pulling 69de8af2fe5183da9332639abcc063e0ed7d2329 on pazjacket:tachikoma/update-20170820163332 into ec251e61adc687ae0589e5283f1773ece07521c0 on sanemat:master.


Emmet gets in the way of CSS intellisense

Found during Smoke Test
Notice how the first option is hardly the best one in this case:

This one is due to the below from the emmet cheet sheet

If abbreviation wasn’t found, it is transformed into property name: foo-bar → foo-bar: |;

I don't like it either. We can prune this type of expansion out from our side.

Am out on vacation all next week. This is an easy fix. If anyone wants to give it a try, the place to add the fix is
https://github.com/ramya-rao-a/vscode-emmet-helper/blob/543c06c55e2cd8ff26575811b0c0c0bba6d823e1/src/emmetHelper.ts#L56
Once you have the vscode dev env set up, you can start by making changes directly to the javascript file emmetHelper.js in extensions/emmet/node_modules/vscode-emmet-helper.


fix assorted typos in toolsPane.js

fixes #6

@timbl @megoth - This PR is an obvious typo fix. I cannot understand it sitting for two weeks when it needs only a single click to be applied.

@timbl @megoth - This PR is an obvious typo fix. I cannot understand it sitting for two weeks when it needs only a single click to be applied.

Sorry for late reply - I've been away on vacation for two weeks, and the rest of the team has been focusing on other tasks, hence the delay.
It was an easy merge though, thank you for your contribution ^_^


MF-540 - Add pagination in API responses for Bootstrap service

What does this do?
This PR adds Page response for listing Configs.
Which issue(s) does this PR fix/relate to?
This PR resolves #540.
List any changes that modify/break current functionality
Bootstrap service API is changed. An endpoint for fetching a list of Configs returns a page entity response with metadata as well as a list of Configs.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
Yes.

Codecov Report

Merging #575 into master will decrease coverage by 0.08%.
The diff coverage is 76.08%.

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
- Coverage   87.21%   87.13%   -0.09%
==========================================
  Files          62       62
  Lines        3419     3444      +25
==========================================
+ Hits         2982     3001      +19
- Misses        298      302       +4
- Partials      139      141       +2

Impacted Files
Coverage Δ

bootstrap/api/responses.go
100% <ø> (ø)
:arrow_up:

bootstrap/api/endpoint.go
100% <100%> (ø)
:arrow_up:

bootstrap/service.go
81.28% <100%> (ø)
:arrow_up:

bootstrap/postgres/configs.go
75.4% <71.05%> (-0.37%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df4dcd...c0b35ef. Read the comment docs.


Run ebpf program Error when I use goland IDE

I can build the ebpf program with the terminal command such as go build xxx. After build the ebpf program，it can run rightly.
But when I use the goland IDE to build the ebpf program，there are some errors as follows.
GOROOT=/usr/local/go #gosetup
GOPATH=/home/wys/go #gosetup
/usr/local/go/bin/go build -o /tmp/GoLand/___1go_build_libbpfgo_hello libbpfgo-hello #gosetup
# github.com/aquasecurity/tracee/libbpfgo
/usr/bin/ld: $WORK/b040/_x003.o: in function `init_ring_buf':
/home/wys/go/pkg/mod/github.com/aquasecurity/tracee/libbpfgo@v0.0.0-20210308231044-6b6a8d6ac59a/libbpfgo.go:40: undefined reference to `ring_buffer__new'
/usr/bin/ld: $WORK/b040/_x003.o: in function `init_perf_buf':
/home/wys/go/pkg/mod/github.com/aquasecurity/tracee/libbpfgo@v0.0.0-20210308231044-6b6a8d6ac59a/libbpfgo.go:55: undefined reference to `perf_buffer__new'
/usr/bin/ld: $WORK/b040/_x003.o: in function `attach_kprobe_legacy':
/home/wys/go/pkg/mod/github.com/aquasecurity/tracee/libbpfgo@v0.0.0-20210308231044-6b6a8d6ac59a/libbpfgo.go:159: undefined reference to `bpf_program__attach_perf_event'
/usr/bin/ld: /home/wys/go/pkg/mod/github.com/aquasecurity/tracee/libbpfgo@v0.0.0-20210308231044-6b6a8d6ac59a/libbpfgo.go:160: undefined reference to `libbpf_get_error'
/usr/bin/ld: $WORK/b040/_x003.o: in function `_cgo_93d29fe7eb73_Cfunc_bpf_link__destroy':
/tmp/go-build/cgo-gcc-prolog:74: undefined reference to `bpf_link__destroy'
/usr/bin/ld: $WORK/b040/_x003.o: in function `_cgo_93d29fe7eb73_Cfunc_bpf_map__fd':
/tmp/go-build/cgo-gcc-prolog:93: undefined reference to `bpf_map__fd'
/usr/bin/ld: $WORK/b040/_x003.o: in function `_cgo_93d29fe7eb73_Cfunc_bpf_map__pin':
/tmp/go-build/cgo-gcc-prolog:113: undefined reference to `bpf_map__pin'
/usr/bin/ld: $WORK/b040/_x003.o: in function `_cgo_93d29fe7eb73_Cfunc_bpf_map__set_pin_path':
/tmp/go-build/cgo-gcc-prolog:133: undefined reference to `bpf_map__set_pin_path'

Goland IDE version is 2021.3.3
Build #GO-213.6777.51, built on January 27, 2022
Runtime version: 11.0.13+7-b1751.25 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.

Linux System Version :
Linux wys-ubuntu20-04 5.15.0-43-generic #46~20.04.1-Ubuntu SMP Thu Jul 14 15:20:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

I have install the related software: sudo apt install build-essential git make libelf-dev strace tar bpfcc-tools libbpf-dev linux-headers-$(uname -r)  linux-tools-common gcc- clang llvm

That is because your IDE needs setup.


PadLocal:

Wechaty Puppet PadLocal

Repo: https://github.com/padlocal/wechaty-puppet-padlocal
Provider: PadLocal
Support: https://github.com/padlocal/wechaty-puppet-padlocal/issues

Question
Hi, I wanna apply a token for my customer service bot development. Happy to be helpful with related open source stuff later.

@wangdahoo Could you send an email to oxddoxdd#gmail.com ? Then I can send you related materials.

@padlocal sent to<EMAIL_ADDRESS>


DPL-435 Heron OKR UAT data tests

User story
As PSD I want to run data testing between UAT and production to check that new code generates exactly the same data from the input coming from the queues  as it was from SFTP
Who are the primary contacts for this story
Eduardo Martin
Andrew Sparkes
Stuart McHattie
Acceptance criteria
To be considered successful the solution must allow:

[ ] add a list of acceptance criteria here
[ ] ...

Dependencies
This story is blocked by the following dependencies:

#<issue_no.>
sanger/#<issue_no.>

References
This story has a non-blocking relationship with:

#<issue_no.>
sanger/#<issue_no.>

Additional context
Add any other context or screenshots about the feature request here.

Tasks:

[ ] Compare Mongodb production and uat
[ ] Compare Mysql production and uat
[ ] Compare DART production and uat

To compare:

Get a list of valid barcodes to check (all barcodes received in a time period)
Query in database
Convert to same format (csv) with same order of headers, sorted by coordinate and barcode
Diff of files should be equal

Get a list of valid barcodes:

select distinct plate_barcode from lighthouse_sample where created_at>='2022-07-15' and id>...;

46 barcodes

Query in mlwh prod:

select * from lighthouse_sample where plate_barcode in (.... list of barcodes.... ) order by rna_id;

Coordinates are padded A01 in devdata (they should be unpadded A1). Removing that column from diff

ch1_target, ch1_result, ch2_target, ch2_result, ch3_target, ch3_result, ch4_target, ch4_result are set to NULL instead of having a value (from the files). Removing those columns from diff.

must_sequence and preferentially_sequence, they get false in devdata when the are updated and dont have a value. In production they have NULL in that case. Removing those columns from diff

current_rna_id and is_current dont match in some entries (like GLS-GP-020772_G11) (they have a value in prod but NULL in uat. I'll remove from diff

plate barcode GLS-GP-020773 has samples missing in devdata that are present in production, this needs checking

Comparison script:
#!/bin/bash

FILE1=$1
FILE2=$2

gunzip -c $FILE1 | cut -d, -f 3,5,6,8,9,10,11,12,15,18,21,24,25,26 |sed 's/positive/Positive/g' >$FILE1.tmp
gunzip -c $FILE2 | cut -d, -f 3,5,6,8,9,10,11,12,15,18,21,24,25,26 | sed 's/positive/Positive/g' >$FILE2.tmp

diff $FILE1.tmp $FILE2.tmp

Preferentially sequence is false in UAT, but is set to true in PROD. It seems we received it as false in the message (mongodb has it as fals).  Examples: PLY-chp-00007107_B9, PLY-chp-00007108_H7, PLY-chp-00007108_H8...:

Checking in dart with this query:
select distinct lab_ids.lab_id,w.well_pk,wp.wellp_name,wp.wellp_value from wells as w
inner join ( select lp.labp_value, max(lp.lab_fk) as lab_id
from labwareProps as lp
where lp.labp_value in (...list of plates...)
group by lp.labp_value) as lab_ids on lab_ids.lab_id=w.lab_fk
inner join wellprops as wp on w.well_pk=wp.well_fk
where wp.wellp_name in ('state', 'root_sample_id', 'rna_id', 'lab_id', 'lh_sample_uuid')
order by lab_id, well_pk, wellp_name, wellp_value;

Ok checks in DART looks good

All data correct in mongo, except priority flags as expected

Check again mysql after they modify default for the flags

Checked with the plates of today in mlwh, all looks good; the only remaining difference is with the columns must_sequence and preferentially_sequence that can't be tested in uat, but all other columns match.


Fix: The “Related Reference” section title of the example pages for i18n

The “Related Reference” section title of the example pages has been revised to include internationalized words as well as other pages.
Changes:
"Related Reference" to "Related References"

Looks good. Thanks!


Update build-source-gem script to support v2.

As far as I understood the coffee-script integration for rails depends on coffee-script-source gem which is built via this script.
I modified the script to use version 2 of the CoffeeScript compiler instead of version 1.
Also I make sure that if no version is set I get the latest tag for the build.

@gobijan can you explain how to use it and specify V2 in rails app ? (who using "gem 'coffee-rails'" only, by default when create new rails app and not "ruby-coffee-script"). What we have to added to gem file?

@Argorate After investigation,  I made coffeescript2 worked with sprockets together, hope this answer helps .

Install latest coffee-script.
Add COFFEESCRIPT_SOURCE_PATH to your operation system's variables.
Set COFFEESCRIPT_SOURCE_PATH value to your coffeescript.js path.
Please make sure you use a standalone file, you can get it from https://coffeescript.org/v2/browser-compiler/coffeescript.js.

Everything done, enjoy!
FYI https://github.com/rails/ruby-coffee-script#installation


Update horizontal-masonry.css

Fixes following issues|Adds following features:

Issue/Feature 1
Fixes incorrect mobile image width for tall variants of the interactive marqueee

Resolves: MWPW-NUMBER
Steps to test the before vs. after and expectations:

Steps for feature 1

Pages to check for regression and performance:

https://tall-mobile-image-fix--express--adobecom.hlx.page/drafts/echen/interactive-marquee-4-square

not live yet so not risk. Merging to unblock authoring


Weekend toggle

Is it possible to have a weekend toggle button for showing or hiding Saterdays an Sundays?
I see the property 'Show Weekends'but this is a static setting.
Best regards,
Patrick Verhoeven - Appronto

Hi Patrick,
There is no setting for a button in this library by default. Furthermore, we don't want to build this in ourselves, as we would like to stick to the library and be able to update the library when a new release comes out(without losing our own work).
However, we will look into a possibility to implement  the weekend toggle to be influenced  by an attribute property, which you would have to define in the property settings of this widget.
Maybe this fits nicely with the 'renderview' which @chadevans  is working on! As soon as that one is available we will check if it's feasible to implement your request!


Move junk between imports and main to bottom of _test files.

Description
This moves any definitions between the main function in test files to the end of the file.  This is because when working in VSCode, it's usually necessary to find the main function to launch the test by clicking on the "Run" link above it. If the main is buried in the file, then it's hard to find.
Also, test files should start with the main, since that's where the meat of the tests are anyhow.

Can we enforce this with a lint or other kind of presubmit check?

Yes, probably, we could just run the script I wrote to do this migration and make sure it doesn't change anything.
Ideally, the script would use the analyzer, but it doesn't at the moment (regexps were good enough).
Is this an OK migration in your opinion, or is it frivolous?

Is this an OK migration in your opinion, or is it frivolous?

Generally, that's how I like to structure my tests, but so far I haven't had any issues with tests that are structured differently. In IntelliJ I can just right-click anywhere inside the body of a test I want to run and select "run test". VSCode doesn't have this? You have to find the main method to run a test? I wonder if maybe the ergonomics of VSCode should be improved instead, if possible?


Missing hint for removing the elem function

In the following example
foo :: Char -> Char -> Bool
foo a b = a `elem` [b]

shouldn't HLint suggests
Found:
  a `elem` 'b`
Why not:
  a == b

?
The missing hint was suggested by @andreasabel here.
$ hlint --version
HLint v1.9.34, (C) Neil Mitchell 2006-2016

Yep, that seems like a good idea!

Note that the hint should be suggested in the general case
foo :: Eq a => a -> a -> Bool
foo a b = a `elem` [b]

HLint is not type directed, so it will definitely be the general case.

Note that the real issue was:
a `elem` "b"

Which in HLint requires a separate hint, since its purely syntax directed.

Implemented the list variant. I decided against the String variant for two reasons: 1) it's technically difficult to implement in HLint requiring new pieces of scaffolding; 2) the OverloadedStrings extension means it might be wrong in some circumstances.
Will be in the next release, but am not intending to make a release until something else crops up. Let me know if you'd prefer a release with it in sooner.

Implemented the list variant.

Thanks!

Let me know if you'd prefer a release with it in sooner.

I can wait for the release.


No latest version of binderhub helm chart

helm show chart jupyterhub/binderhub
Returns:
Error: failed to download "jupyterhub/binderhub" (hint: running helm repo update may help)
I've opened a sister issue at helmsman because helmsman relies on there being a latest helm chart available.
https://github.com/Praqma/helmsman/issues/512
Would it be possible for binderhub to have a latest version assigned like with jupyterhub?
Best
Craig

Any thoughts on this?

I know it has been an intentional choice in the past, but I know Helm charts typically has this, so I'm inclined to say it would be fine to package a latest version as well.

How would I get this implemented?

Whats needed is proper version bumps of binderhub. We now only create pre-releases and the helm chart repo doesnt contain anything else i think.


Handle serialization of weak reference to data buffer.

The problem comes up when we are trying to do data transfer in a distributed system.
The weak reference used for GC is optional for native, but will cause issues with data transfer.

Done.


[FEA] Allow StructType as input and output type to InMemoryTableScan and InMemoryRelation

Is your feature request related to a problem? Please describe.
Need to test and add struct type to InMemoryTableScan and InMemoryRelation operators as output and input data types.

closed by #1596

I am reopening this because I should add tests before closing this

This is dependent on rapidsai/cudf/7230

Depends on https://github.com/rapidsai/cudf/pull/7998 and https://github.com/NVIDIA/spark-rapids/pull/1969

closed by #1969


Define a global context in a function signature, to enforce typing.

🔍 Search Terms

global context
enforce global variable

✅ Viability Checklist

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
I would like to be able to define that a method can have access to a custom global environment, within the function.
It can be implemented exactly as the this typing.
the main issue is to find a reserved keyword, or syntax to do that.
📃 Motivating Example
Improve puppeteer extensions.
💻 Use Cases
This feature is most useful when we write a code that will be executed in another javascript environment like:

writing code that will be injected into a browser (like puppeteer)
writing a code that will be called in a nodejs worker.

if I use puppeteer-jquery to enable jQuery into my browser.
I can now write:
import puppeteer from 'puppeteer';
import { PageEx, pageExtend } from 'puppeteer-jquery'

interface Items{ item: string; }

var jQuery: JQueryStatic; // declare that a jQuery object exists

const browser = puppeteer.launch(option); // start a browser
const page = await browser.newPage(); // create a tab
const page2 = pageExtend(page0); // inject jQuery to the page
const data = (await page.jQuery('div.entry').map((id: number, elm: HTMLElement) => {
    const impData = jQuery(elm).find('.important');
    return { item }
}).pojo()) as Items[];

the jQuery object is available inside the browser but not inside the nodeJS, this code works, but I need to add a dirty var jQuery: JQueryStatic; at the top of the file
currently, the jQuery method of page signature is:
    jQuery(selector: string): PJQuery;

with a feature to define a custom environment, this code will be replaced by:
import puppeteer from 'puppeteer';
import { PageEx, pageExtend } from 'puppeteer-jquery'

interface Items{ item: string; }

const browser = puppeteer.launch(option); // start a browser
const page = await browser.newPage(); // create a tab
const page2 = pageExtend(page0); // inject jQuery to the page
const data = (await page.jQuery('div.entry').map((id: number, elm: HTMLElement) => {
    const impData = jQuery(elm).find('.important');
    return { item }
}).pojo()) as Items[];

and, the jQuery method of page signature will be something like:
  interface {
    navigator: Navigator;
    jQuery: JQueryStatic;
    // ...
  }
 // ...
    jQuery(global: JQPage, selector: string): PJQuery;

The tsConfig.json can be used to define if the code is used inside a nodeJS or a browser, but when we mixte the two destinations in the same code... it can not be used.

In this issue, wilsonpage wants to specify a global environment for some of his files, and he works in JS.
I only work in Typescript, and I want my environment to be per function. I think this can also be applied to some web development framework, like in the VueJS composition API, typically the code you are typing will be embedded into a component, and will have access to some new global variable.
With this approach, the new variables are only available in some methods, but not around the method.
in my first code sample, using var jQuery: JQueryStatic;, the jQuery is available everywhere in the file but will fail at runtime if used outside the function block.


Refactoring mocks and ping-pong

Closes #746
I did a bunch of things here:

I put ping-pong inside a mocha test. This makes it way easier for testing, as you only have to run npm run pin-pong instead of all those docker-compose scripts like ./pong-nightfall, pong-down, ganache-standalone etc. This also removes a lot of duplicate code. Ping-pong now uses the same environment as all the other tests.
Config files are now split in many files. I didn't use any criteria, simply wanted all the truffle configs to be in a different files. But this will allow us to break up config files in the future which is easier for development and to reduce merge conflicts
Nightfall-deployer now will not deploy mocks. Future developments (like enterprise users) may not want mock contracts to be deployed in production, even if they were protected by an environment variable. Instead, start-nightfall will now run a script that deploys mocks if you use the -dev flag. When you run any of the tests (including ping-pong) the mocks will be there.

Reverted the latest commit as I was heading a bit ahead of what's in the ticket. Ping-pong is not refactored, I'll cherry-pick it in some other branch later

Dropping this. The move to a multisig ownership makes impossible to approve the set restrictions as we "lose" the private key once the main deployment is done. We could do this by programatically interact with nightfall-administrator but that seems a bit of overhead we currently don't need.
We'll get back to this once we remove restrictions altogether.


Add diff-hl background face for TUI

Fringe is unavailable in terminal, so I'm using diff-hl-margin-mode in
terminal.
Add background color works in terminal and makes the vc-change more visible in
GUI.
Btw, does the t inside ct- means terminal? I have not tested it on a
16-color terminal, but it works fine on my 256-color terminal and true-color
terminal.

Here is the comparison:

GUI

before

after

TUI

before

after

Here is the comparison:

GUI

before

after

TUI

before

after

GUI

GUI keep same as TUI

TUI under true-color

TUI under 256-color

Sorry, I just found that :foreground will affect the color in terminal, so I won't delete them. But it's strange that although the :foreground and :background colors keep same in ct-, they look different.

GUI

GUI keep same as TUI

TUI under true-color

TUI under 256-color

Sorry, I just found that :foreground will affect the color in terminal, so I won't delete them. But it's strange that although the :foreground and :background colors keep same in ct-, they look different.

:+1: Thank you for the great comparison! :heart:

Use the built-in dark color makes it a little hard to tell the difference

Should we use the default dark variant, or keep pace with terminal?

We already have a darker red (ct-red-dd/red-dd)  and a darker green (ct-green-dd/green-dd) for this.
https://github.com/challenger-deep-theme/emacs/blob/b0d5f103db8ee846580617cc3a2f44f89edd5a6d/challenger-deep-theme.el#L40
https://github.com/challenger-deep-theme/emacs/blob/b0d5f103db8ee846580617cc3a2f44f89edd5a6d/challenger-deep-theme.el#L59
I think they should work fine, have you tried using those?

:+1: Thank you for the great comparison! :heart:

Use the built-in dark color makes it a little hard to tell the difference

Should we use the default dark variant, or keep pace with terminal?

We already have a darker red (ct-red-dd/red-dd)  and a darker green (ct-green-dd/green-dd) for this.
https://github.com/challenger-deep-theme/emacs/blob/b0d5f103db8ee846580617cc3a2f44f89edd5a6d/challenger-deep-theme.el#L40
https://github.com/challenger-deep-theme/emacs/blob/b0d5f103db8ee846580617cc3a2f44f89edd5a6d/challenger-deep-theme.el#L59
I think they should work fine, have you tried using those?

Sorry, I have not tested it. But they look good.

It's a mistake I wrote a yellow-dd in the above picture. There is no yellow-dd actually. But would you mind I add #7b5b3d as yellow-dd? I added a ct-yellow-dd, it's chosen from 256-color.

Sorry, I have not tested it. But they look good.

It's a mistake I wrote a yellow-dd in the above picture. There is no yellow-dd actually. But would you mind I add #7b5b3d as yellow-dd? I added a ct-yellow-dd, it's chosen from 256-color.

It's a mistake I wrote a yellow-dd in the above picture. There is no yellow-dd actually. But would you mind I add #7b5b3d as yellow-dd? I added a ct-yellow-dd, it's chosen from 256-color.

:+1: Sounds good

It's a mistake I wrote a yellow-dd in the above picture. There is no yellow-dd actually. But would you mind I add #7b5b3d as yellow-dd? I added a ct-yellow-dd, it's chosen from 256-color.

:+1: Sounds good

OK, I've rebased it to one commit. Thanks for your patience!

OK, I've rebased it to one commit. Thanks for your patience!

:+1:  Thank you!

:+1:  Thank you!


cannot softdelete laravel Notifications

I am using laravel default database notifications, I want to add softdelete to notifications table.
I have created a migration with softdelete which has added deleted_at column to the notifications table. The problem is I have to add 'use SoftDeletes' to notifications model(according to laravel docs) but cannot find the notifications model.
I tried adding 'use SoftDeletes' to HasDatabaseNotifications trait but it still deletes the row.

Heya, thanks for submitting this.
This seems like a feature request or an improvement. It's best to post these at the laravel/ideas repository to get support for your idea. After that you may send a PR to the framework. Please only use this issue tracker to report bugs and issues with the framework.
Thanks!


⚠ Bofrost.lu has degraded performance

In 4ad8897, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1571 ms

Resolved: Bofrost.lu performance has improved in b0c2ff6 after 6 minutes.


[POC] Can the mutating webhook for docker registry secret be dropped ?

Description
Prove that function build jobs (kaniko) can push to docker registry identified by secret of docker-registry type (w/o any additions like registry address)
apiVersion: v1
kind: Secret
metadata:
  ...
  name: regcred
  ...
data:
  .dockerconfigjson: eyJodHRwczovL2luZGV4L ... J0QUl6RTIifX0=
type: kubernetes.io/dockerconfigjson

Reasons
Serverless should operate on docker registries identified by secrets of dedicated type docker-registry
https://github.com/kyma-project/serverless-manager/issues/121
Attachments
Check if build job can push to docker registry identified by secret of docker-registry type (w/o any additions like registry address)

Current state
Serverless receives a secret serverless-registry-config from the user containing explicitly written data (https://kyma-project.io/#/serverless-manager/user/00-20-configure-serverless?id=configure-docker-registry). If it is not there, it uses the default secret file serverless-registry-config-default (it is built from resources/serverless/templates/registry-config.yaml).
Both of these secrets are populated with the .dockerconfigjson field (if they have the serverless.kyma-project.io/remote-registry: config label - see components/function-controller/internal/webhook/remote_registry_cfg_webhook.go and resources/serverless/charts/webhook/templates/webhooks.yaml - secret serverless-registry-config-default already has this field) and replicated to other namespaces (if they have the label serverless.kyma-project.io/config: credentials - see components/function-controller/internal/controllers/kubernetes/namespace_controller.go).
Serverless builds Job based on the .dockerconfigjson field (components/function-controller/internal/controllers/serverless/system_state.go and components/function-controller/internal/controllers/serverless/function_reconcile.go) - we don't need to change anything.
If Serverless is a module managed by the Serverless Operator, the user can additionally pass secret through the ServerlessCR configuration (by filling spec/dockerRegistry/secretName). This serverless must contain explicitly written data (same as the serverless-registry-config described earlier). Based on this secret, data is transferred to Serverless to build serverless-registry-config-default.
Proposals of changes

Add support for secrets containing the .dockerconfigjson field to the Serverless Operator - we also need to add the ability to build a secret on the Serverless side based on the .dockerconfigjson field.
Add to the documentation a description of creating a secret with the .dockerconfigjson field and configuring it in ServerlessCR.
Remove the description of creating the serverless-registry-config secret from the documentation.
Remove serverless-registry-config secret support from Serverless.
Possible change of the name serverless-registry-config-default - it is the only secret responsible for storing this data.
Remove support for explicitly written data fields from secrets - only .dockerconfigjson will be supported.

@anoipm when creating serverless build job serverless reads pushAddress.
Can this push address be deducted from the  .dockerconfigjson field?
https://github.com/kyma-project/kyma/blob/161f02d573b24f59078787b14ac464aa396af35c/components/function-controller/internal/controllers/serverless/system_state.go#L240

Yes. .dockerconfigjson field is json encoded by base64.
You could see example solution [here]( https://github.com/kyma-project/kyma/pull/18141/files#:~:text=func-,getRegistryAddressFromSecretData,-(data%20map )


nydus: add raw bootstrap digest annotation for validation

Ref:
https://github.com/containerd/nydus-snapshotter/pull/45
This pr adds an annotation(containerd.io/snapshot/nydus-bootstrap-digest) for raw bootstrap validate
Signed-off-by: zyfjeff<EMAIL_ADDRESS>

It's a feature addition for the nydus driver, can we change the commit title like this nydus: add raw bootstrap digest annotation for validation?

@imeoer ping

@imeoer PTAL, BTW your review comments helped me a lot, thank you very much.

@zyfjeff Please add SOB for all commits, so that we can merge it.

@imeoer SOB already exits

@imeoer SOB fixed


WhisperX takedown

WhisperX was taken down by github. How can we still have access to it?

You mean this one?
https://github.com/m-bain/whisperX
Is online for me.

It's back online


Set-facing tracks

Also, I do have the idea that we could also make a track limit only forward trains to enter the siding. This would make it so your siding can still be used in random mode, but the train will never enter it backwards.
Originally posted by @Novakasa in https://github.com/Novakasa/brickrail/discussions/113#discussioncomment-6098983

let's keep this open until we have visual feedback that the filter is set.


Merge Network-2018-02-01 to Master Networking Swagger Changes for Feb 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-libraries-for-java

Automation for azure-sdk-for-python

Automation for azure-sdk-for-go

Do not merge until https://github.com/Azure/azure-rest-api-specs/pull/2567 is merged into Network-2018-02-01

It depends on the fix https://github.com/Azure/azure-rest-api-specs/pull/2646

@dedhar can you pull down the latest changes from master into Network-2018-02-01 and push the commit. That might probably be causing the build errors

@lmazuel Is the python failure due to XmsParameterLocation errors reported?

Do not merge before https://github.com/Azure/azure-rest-api-specs/pull/2644

@vinayada1  Please pull the latest changes from this branch and work on your changes

Automation for azure-sdk-for-node

@lmazuel Can you take a look at the CI failures here

All builds are a go!

@AutorestCI rebuild azure-sdk-for-python


Language Detection with CLD2 with Mixed Inputs in long documents

Internals Recap. CLD2 is a Naïve Bayesian classifier, trained on documents of mean size of 200 characters, trained on a corpus of 100M scraped and human expert selected web pages.
When working on long documents size like
~3000-4000 words,
~40-50.000 characters

of mixed input texts (at least 2-3 languages in the same document), I see that CLD fails the recognize all the mixed inputs, resulting in only the most common language, like being having a polarization around this language like in this document excerpt:
Only come and treat me right
And you'll never guilty
Sekarang kamu sudah ada di depanku
Aku pun berdebar menanti kata-katamu
Honey Bunny Sweety
Let's take a chance

This will be recognized as english so I get
{
  "results": [
    {
      "reliable": true,
      "detection": {
        "name": "ENGLISH",
        "code": "en",
        "percent": 54,
        "score": 930
      }
    }
  ]
}

while I would expect here to have at least 2 languages. Internally CLD2 uses NGram decomposition of the input text, that is known to perform very will on language detection in a text: the feature space is very compacted when using a bigram, since the latin alphabet you will get 26^2=676 bigram of possibile features in the training set. See here for more details.
If I generate ngram of a given size (this case N=2) of this document I will get this time
{
    "count": 86,
    "code": "na",
    "name": "na",
    "mean": 0.45989304812834225
  },
  {
    "count": 50,
    "mean": 16.503352692086242,
    "code": "id",
    "name": "INDONESIAN"
  },
  {
    "count": 38,
    "mean": 12.779225483523962,
    "code": "en",
    "name": "ENGLISH"
  },
  {
    "count": 13,
    "mean": 1.5371176291771826,
    "code": "ms",
    "name": "MALAY"
  }

i.e. a more detailed detection of the mixed input language that are in this document. Of course this detection depends on N i.e. the size of the ngrams, so it may happens that for some values of N it have false positive (like a new language detected that it is not in the mixed inputs).
Assumed that CLD2 is using Ngram internally, and that the Bayes classifier was trained on ~200 characters wide text (~2-3 sentences), it seems to have a polarization in some way, and to provide better results, when working in this way - in the case of mixed inputs. The question is if this is arguable in some way and if there is a different approach that could bring to the same results obtained here.
Originally posted here.

[UPDATE]
A good explanation about the mixed input results was given by Dick Sites here


PatientMenu, Patient, Appointment, AOR

Went back to user hierarchy after a long thought process

I decided to go back to user hierarchy instead of the separate user table approach as before. Eventhough the effect is minimal on the inheritance part, it makes the login functions easier to implement.


BatchGradientVerification should probably turn off batch norm

🐛 Bug
In networks using Batch norm, there is "mixing" across the batch dimension but this probably doesn't indicate an error. Might be worth augmenting BatchGradientVerification and the associated callback to
(1) either always turn off batch norm, OR
(2) if we're about to return False, then check if turning it off will return True
Otherwise it can be super confusing to add this check and have it fail, forgetting about batch norm
To Reproduce
https://colab.research.google.com/drive/1dlY2vCBqMasrihIv_Y4DU-3BeKLd0Gox#scrollTo=fDRd_pRn_jL1
Expected behavior
See above.
cc @awaelchli

Hi @indigoviolet
Thanks for trying out my callback hihi <3
That's a very good observation! I was aware of it and also bumped into this myself a few times haha, just never had the time to address it properly. I should have made it clearer that it is a heuristic :) But of course an extension would be nice to support this. Your two proposed solutions are both reasonable imo. I would go with the first one since it's the simplest.
Do you have an interest in sending a PR?

cool, PR attached @awaelchli


Dutch translation

Added a nl.json file to the tr directory and an nl folder containing four html files with the Dutch translations. Added a new language line to the config.json file. Also updated the credits as requested by Paul Igodt. These translations will be used for the Flemish and Dutch Imaginary exhibitions.

Apologies for that. I have now added the pug files in the src/pug/pages/nl as well as some Dutch translations of the images and built these using gulp html.
Kind regards,
Jarne
P.S.: The internalization section in the readme suggests that the pug files should be created in src/pages/<langcode> instead of in src/pug/pages/<langcode>.


(NFC) Replace unused variable hack with (void)

@compnerd Thoughts?

@swift-ci please test

I'm not sure about the value of this change tbh. There is active work to re-core to swift-foundation and that will entirely remove CoreFoundation. In the mean time, this diverges from the internal copy of CoreFoundation which might make it more difficult to backport changes if critical.


Mobile Menu Button

In this Milestone, I;

Added functionality to the mobile menu using javascript
Edited the README.md file
Set up JavaScript linters
Fixed errors in the javascript file

Hello omarsalem7, could you please show me how to add these links as you suggested? Thanks

Thanks for the Approval 👍


Shared http client

This PR includes couple of improvements:

ability to pass a http client to use. Useful for the cases when using library to work with multiple accounts (different refresh tokens), and benefit from common http collection pool, keep alive, etc. For this reason oauth handling moved to HttpTdaClient so the http client is not bound to specific refresh token.
ability to pass access token if known (optional)
placeOrder returns id of the created order
RuntimeException replaced by a more specific one
Minor dependencies upgrade (addresses https://nvd.nist.gov/vuln/detail/CVE-2021-28170 and alike)

@studerw can you take a look by chance please?

Hi @zhemaituk i will have time to look at this later this week. Thanks for the PR!

Any chance for review @studerw please?

@studerw any chance for merge or feedback?
If this project is abandoned let me know also, I'll stop trying and will keep the changes just in my fork.

Does this PR resolve this issue?
When passing client - 1st request fails, but 2nd works?
Seems like it does
[main] INFO com.studerw.tda.client.HttpTdaClient - Fetching Fundamental Instrument data with id: ACABU
[main] INFO TDA_HTTP - REQUEST GET: https://api.tdameritrade.com/v1/instruments?symbol=ACABU&projection=fundamental
[main] INFO TDA_HTTP - RESPONSE [401 - Unauthorized]: https://api.tdameritrade.com/v1/instruments?symbol=ACABU&projection=fundamental in 422.6 ms
[main] INFO TDA_HTTP - REQUEST POST: https://api.tdameritrade.com/v1/oauth2/token
[main] INFO TDA_HTTP - RESPONSE [200 - OK]: https://api.tdameritrade.com/v1/oauth2/token in 140.5 ms

@oldcatpiss it was addressing it just partially (only if you supply access key in input properties).
But updated the PR to address that as well fully, if no access key is known it will try to retrieve one, instead of failing first.
Btw, for the time being I am releasing my changes to maven central under this group id:
<dependency>
    <!-- TODO: Switch to original groupId after https://github.com/studerw/td-ameritrade-client/pull/54 merged. -->
    <!-- groupId>com.studerw.tda</groupId -->
    <groupId>com.breakingequity</groupId>
    <artifactId>td-ameritrade-client</artifactId>
    <version><IP_ADDRESS></version>
</dependency>

@zhemaituk @oldcatpiss
The way the original design works was that it will ALWAYS fell on the first call because, by design, the interceptor catches authentication issues and tries to fix it within its own class which offloads that functionality from the main client in order to massively simplify its design.
Yes it is known that this will ALWAYS waste the first call which will fail fast, but it makes things a lot more simple in the many corner cases where, at any time - you have no idea because it's determined by the server - your auth session may expire or time out or be reset. Again, if you handle all that initial authentication logic within the client itself to avoid that first failure call, then you still need all that extra logic to handle session failures.
Without having to dig through your code, what was your solution @zhemaituk ?
Theoretically, you could keep some state variable that knows if we've yet to create an initial session and pre-fetch it to avoid that first fail call, but then you have to deal with concurrency issues (e.g. multiple threads using the client initially at once, and then overriding each other's sessions) which creates more problems than it is worth, IMO. The way my auth interceptor works it shouldn't have that problem because that session info is handled by the OKCupid client, which they've probably dealt with in much more depth than we're able to do.

Yeah, no biggie - I just noticed the pr and gave it a look.  Thanks for the response! Great client and Thanks for sharing!
@studerw

@zhemaituk  I did finally get around to updating some of the dependencies that were failing security scans and I also cherry picked your code to return the order ID using the location header. Thanks for that code!
As for some of the other more complex stuff to do with authentication, I'm not even sure it is worth the effort. FYI, TDA was bought out by Schwab, and supposedly they're migrating users to a different API they may or may not be compatible with this version, assuming it will actually exist some day.
It was supposed to happen this year, but their docs and notices are very sparse.
Regardless, this is the 2nd time in 5 years they've completely screwed over users and devs who counted on their "personal" API access, and I'm not real interested in wasting any more time & effort with TDA (or whichever megacorp currently owns them). 🤷

@alexgolec Take a look at this: June Announcment.
I personally have not got an email with a link to create a Schwab developer API, but I'm on the lookout for it.

update @alexgolec  I just looked and  I did get a notice for the new developer API at Schwab sent to my old email.
Regardless, I was able to create a new account on their Beta site here: Schwab beta. I don't think you need a special invite code, though not sure how much access I will actually have.

I think I received a similar email as well. I went ahead and registered, but I haven't heard anything about my application for API access yet. Have you been able to do anything besides request access?

I did not try anything yet because my account hasn’t even been moved over. I do have another Schwab account, though, so I’ll check it out later this week and report back.


Add agent.pause() and agent.unpause()

Adds ability to pause the agent, preventing events from being sent to transports.
Can be used when you do not want to track certain pages in your SPA.
Alternative to https://github.com/grafana/grafana-javascript-agent/pull/29

also added ability to initialize paused, updated docs


Delete appid/password from tests

Fixes https://github.com/microsoft/botbuilder-dotnet/issues/5831

Pull Request Test Coverage Report for Build 263789

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.007%) to 75.751%

Files with Coverage Reduction
New Missed Lines
%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs
1
90.91%

/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs
1
90.91%

Totals

Change from base Build 263770:
-0.007%

Covered Lines:
23051

Relevant Lines:
30430

💛  - Coveralls


Updated ITPA confinement scalings: ITPA20

Discussed in https://github.com/ukaea/PROCESS/discussions/2889

Originally posted by jonmaddock July  9, 2018
In GitLab by @mkovari on Jul 9, 2018, 11:36
The analysis of the updated energy confinement scaling is now published:
The updated ITPA global H-mode confinement database: description and analysis
G Verdoolaege et al

Extrapolation of this scaling to ITER yields a somewhat lower confinement time compared to the IPB98(y,2) prediction.

The paper also includes regression results for individual machines, including MAST and NSTX, which may be helpful for ST work.
The engineering scaling, henceforth referred to as ITPA20 is

The original version of this issue quoted a slightly different equation, in which triangularity appeared as $\delta_{95}$, rather than $\delta$.  However, Geer Verdoolaege confirmed that the LCFS values should be used, so the formula above from the  Nuclear Fusion paper is correct.
This is based on the entire set of ELMy H-modes in the database, not restricted to the ITER-like subset.
There is also another scaling expressed in dimensionless variables, not intended for the purpose of prediction, denoted ITPA20-
IL-dim, using only ITER-like data.
Mikhail Maslov is one of the authors.
Note that Mikhail also has very important data on the dependence of confinement on the separatrix density $n_{e,sep}$
Suggestions

Update PROCESS.
Investigate what the updated database says about low aspect ratio machines.
Investigate what the database can tell us about the dependence of confinement on the separatrix density.

@stuartmuldrew @jmorris-uk @ajpearcey @cjwgriesel @dshort

Definitions.

The table of energy confinement times now looks like this:
****************** Energy confinement times, and required H-factors : ***********************

      scaling law              confinement time (s)     H-factor for
                                   for H = 1           power balance
   ITPA20               (H)        2.072                     1.165
   IPB98(y,2)           (H)        2.454                     0.984
   ISS95            (stell)        1.441                     1.675
   ISS04            (stell)        2.502                     0.965
   DS03                 (H)        3.803                     0.635
   NSTX (Spherical)     (H)        5.437                     0.444
   NSTX-Petty08 Hybrid  (H)        4.571                     0.528
   NSTX gyro-Bohm Buxton(H)        38.020                    0.063

You can see that the ITPA20 confinement time is less than the IPB98(y,2) value.
With the large-tokamak scenario (rmajor fixed, hfact variable), the outcome when ITPA20 is selected is a little unexpected: hfact hardly changes (and remains below the upper bound), but all the other variables change, including the plasma current, helium content and radiation power.  The xenon content has doubled.

Now that we have an up-to-date confinement scaling, I suggest people use it.
* Switch for energy confinement time scaling law
isc = 50

A unit test can be derived from this check I did:


evaluation the model

Hi!
I want to use your trained model on LINEMOD dataset to get 6DOF position of my own object.
I have a 3d model and pictures for testing. Do I need something else?
How can I do this?

You need to provide initial poses for each test image (DeepIM is for pose refinement), and then follow the data preparation steps (see toolkit) to convert the data format to be compatible with the model.

Thank you for reply!
Also, How can I evaluate your already trained model for my new 3d-object?

If your "new 3d object" is not in LINEMOD dataset, maybe you need to train your own DeepIM model.
Otherwise you can just follow the guides of this repo for standard LINEMOD objects.

Thank you so much!
I have an engineering problem - to find the rotation angle of the object in a 2D image using its 3d model.
We know the exact position of the object and its maximum sizes. The single problem is to find a rotation angle - yaw angle.
May you give me some advice on what's a technique to use? Because for this task deep learning is looking overkilled.
Thank you in advance!

A naive approach is to render your 3d model on some yaw angles (uniformly or randomly) and try to match the rendered image to the object in the 2D image. You can also try some traditional template matching (if the model is textureless) or local-feature matching (if the model is rich in texture) methods. You could also try to render a lot of synthetic images and train a deep learning based pose estimation or refinement model.

@wangg12
Thank you!


[Question]: how to change the keyword 'sks' as it would pollute data

请提出你的问题
lab: ppdiffusers, dreambooth
The 'sks' is the fixed point in dreambooth, we may use the sentence "a photo of sks {keyword}" for models' fine tuning, but the 'sks' is also know of a kind of semi-automatic rifle ref: https://en.wikipedia.org/wiki/SKS, our results might be polluted by the images of gun, and with the increasing of epochs, the result would be more probable generated as some kinds of wired machine gun instead of what we pointed
So, how can I change the keyword 'sks' in ppdiffusers to avoid this pollution? ref: https://github.com/XavierXiao/Dreambooth-Stable-Diffusion/blob/main/ldm/data/personalized.py#L10

用 placeholder_token 是可以，但是如果我需要指定多个（上千/上万）这种 token 就会很麻烦，不是个特别好的方案感觉
dreambooth原版里面是存在'sks'替换的能力的，不过不知道被封装到哪去了，是根据他的思路重写了整个逻辑吗？


Add cropping to train and validation when para_load = False

Before fixing this bug, when use para_load = False, the size of input data that was set to shared_x in every iteration does not match the correct input size of the model, giving a dimension mismatch error when doing matrix-matrix multiplication.
The reason of the bug is that there's no cropping when para_load is False in two places, i.e. in get_val_error_loss() and train_model_wrap(). However, when para_load is True, there's cropping inside the loading process.
After fixing the bug, the cropping is active under both condition.

I tried this version just now on Windows platform with the para_load = False (para_load is not supported on Windows) and it works well. The training cost goes down from 6.9 to 5.7 after 3600 iterations.

@hma02 how about just removing the parameter flag_datalayer? and only use flag_para_load
since flag_datalayer can only do batch-wise cropping and mirroring, which isn't correct any way
if you could do crop_and_mirror, then flag_datalayer is actually not needed.


Link against LibRT on older Linux distros

Fix for The-OpenROAD-Project/OpenROAD-flow-scripts#64
See here for explanation

Given that this is currently working outside of RHEL 6, is it possible to be more targeted in the conditions to only include this on that OS?

We had this problem in OpenROAD quite a while ago and this was the fix that we inserted. I did look it up but there really isn't a low-overhead way of checking the glibc version short of creating a custom cmake function to use an external program. Here's one way someone did it.
If you prefer the more-work but more-specialized approach of getting the glibc version, I can do that instead. We preferred the former in OpenROAD because linking libRT when not needed is rather harmless.

linking libRT when not needed is rather harmless.

Works for me

I'm guessing the CI won't get triggered until someone starts it manually?

I have no idea why the checks aren't running. I've just manually merged it.


Add instructions for picking commit in the release

Changes
/kind documentation
Add instructions for how to pick latest commit based on whether it's a major/minor release or a patch release.

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep

Release Notes
NONE

cc @jerop and @tektoncd/core-maintainers. PTAL!

/test pull-tekton-pipeline-integration-tests


InterSystems IRIS driver: fix broken link, update to 3.6.1

Old link is not working anymore, replaced jar link. Driver version 3.6.1 is compatible with old servers, so users who are using version 3.1.0 would not be affected.

Thank you for contribution. We appreciate it.
Unfortunatelly, we have already got PR with the same changes https://github.com/dbeaver/dbeaver/pull/18916
I have to close this PR as a duplicate. Sorry.


proposal: testing/slogtest: Add RunWithSkip func

Proposal Summary
Allows skipping of tests with specific names
func RunWithSkip(t *testing.T, newHandler func(*testing.T) slog.Handler, result func(*testing.T) map[string]any, skipTestName ...string)

It is behind of #61758

Problems
Several logging libraries trying to support log/slog, but seem to not much imported testing/slogtest
Background
This is just a guess based on my personal insight:

Currently slogtest is all or nothing.

Pass or fail-all, or no slogtest

Existing logging libraries may take time to adapt to all of slog, Or they may not be able to.

In particular, grouping logs.

https://github.com/uber-go/zap/issues/1402
https://github.com/rs/zerolog/issues/571

Logging library should not be broken to support slog.

Most OSS will not merge code that test failed.

Proposal
Add RunWithSkip, allows skipping of tests with specific test names.
Benefits

Expecting more slogtest imports.
It makes possible "partial slog support" approach

I think that partial approach is better than all-or-nothing.
For example, kubernetes gateway-api conformance supports skipping tests.

CC @jba

If could not skip the test,
Future additions of slogtest cases that support edge cases, it might break the GHA pipeline and block Golang updates.

I think you can do what you want with the existing slogtest.Run function:
slogtest.Run(t, func(t *testing.T) slog.Handler {
    if skipNameMap[t.Name()] {
        t.Skip()
   }
   ...,
}, ...)

Please correct me if I've misunderstood.

you are right,
This proposal is retractable.
https://go.dev/play/p/nJY0XtnW6mz
newHandler := func(tt *testing.T) slog.Handler {
if slices.Contains([]string{"TestSlogtest/empty-attr", "TestSlogtest/inline-group", "TestSlogtest/empty-group-record"}, tt.Name()) {
tt.Skip("skipped.")
}
buff.Reset()
return zapslog.NewHandler(core, nil)
}
run := func(tt *testing.T) map[string]any {
var ent map[string]any
if err := json.Unmarshal(buff.Bytes(), &ent); err != nil {
t.Fatal(err)
}
return ent
}
slogtest.Run(t, newHandler, tf)


password configuration doesn't work

I forgot to restart shadowsocks client after alter it's server perferences.
I edited the server port that I used before on my shadowsocks client, which will not automatically take effect. This means my client still use the old configurations instead of the newer.
Everything works fine after I restart my shadowsocks client.


attempt to isolate failing test

cf. https://github.com/TuringLang/Turing.jl/actions/runs/11153664418/job/31001609351?pr=2341
trying to see why this fails (i can't repro locally)
do not merge

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 5 (0.0%)  changed or added relevant lines in 3 files are covered.
1341 unchanged lines in 21 files lost coverage.
Overall coverage decreased (-87.1%) to 0.0%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/mcmc/ess.jl
0
1
0.0%

src/mcmc/particle_mcmc.jl
0
1
0.0%

src/mcmc/mh.jl
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/variational/VariationalInference.jl
4
0.0%

src/Turing.jl
9
0.0%

src/mcmc/gibbs_conditional.jl
12
0.0%

src/mcmc/is.jl
16
0.0%

src/stdlib/RandomMeasures.jl
24
0.0%

src/essential/container.jl
27
0.0%

ext/TuringDynamicHMCExt.jl
29
0.0%

src/mcmc/emcee.jl
48
0.0%

ext/TuringOptimExt.jl
50
0.0%

src/mcmc/ess.jl
52
0.0%

Totals

Change from base Build<PHONE_NUMBER>6:
-87.1%

Covered Lines:
0

Relevant Lines:
1552

💛  - Coveralls

it works 🤷♀


model: same job of different roles should resolve links differently

When a job is used in multiple roles, we might need to resolve its BOSH
link consumers differently.  For example, many roles have a consul_agent
job; when resolving links to consul, they should find it on the same
role instead of looking in a different role.

Found a bug with the generated link info; uaa-mysql won't come up.


Dark mode for documentation

Please provide a dark mode for the Gradle documentation.

Yes, I need it

Unfortunately, we don't have the bandwidth to tackle this issue now. You can try to use some browser extension to show the docs in the dark mode.

It's sad that this issue was closed, will it ever be reconsidered? Browser extensions are usually quite suboptimal, and although I do value dark mode a lot, I never quite got hooked to such extensions.


DeviceAuthGenerator

Hi there
I came across this and wondered if it was beneficial to the project?
Please excuse my ignorance, maybe you already use it, just trying to help.
https://github.com/xMistt/DeviceAuthGenerator
Thanks for continuing to support this great project.

Duplicate of #136


Check Travis set up for pushed tags results in releases now

It should now be possible that on pushing a tag starting with v, a release is made with binaries uploaded as assets, the job currently relies on GH_TOKEN being set.

Update, I did push a tag just for testing, https://github.com/rhd-gitops-example/services/releases/tag/v0.0.1 - no binaries and the job can be seen at https://travis-ci.org/github/rhd-gitops-example/services/jobs/678603395, not the results I expected!
The command "$GOPATH/bin/golangci-lint run" exited with 0.
42.55s$ go test ./...
?   	github.com/rhd-gitops-example/services/cmd/services	[no test files]
ok  	github.com/rhd-gitops-example/services/pkg/avancement	0.020s
--- FAIL: TestCopyWithMissingSource (32.70s)
    repository_test.go:271: exit status 128
FAIL
FAIL	github.com/rhd-gitops-example/services/pkg/git	36.857s
ok  	github.com/rhd-gitops-example/services/pkg/git/mock	0.003s [no tests to run]
ok  	github.com/rhd-gitops-example/services/pkg/local	0.007s
ok  	github.com/rhd-gitops-example/services/pkg/util	0.001s
?   	github.com/rhd-gitops-example/services/test	[no test files]
FAIL
The command "go test ./..." exited with 1.

hmm

I have access to the Travis settings, now seeing bad token errors as expected, so I'm gonna go through https://docs.travis-ci.com/user/deployment/releases/ information here and https://developer.github.com/v3/guides/managing-deploy-keys/#machine-users to get this passing

root@de917a495135:/# curl -O -L -k https://github.com/rhd-gitops-example/services/releases/download/v0.0.1/services_linux
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   627  100   627    0     0   4679      0 --:--:-- --:--:-- --:--:--  4679
100 11.2M  100 11.2M    0     0  3941k      0  0:00:02  0:00:02 --:--:-- 5531k
root@de917a495135:/# ./services_linux promote
NAME:
   services - A new cli application

USAGE:
   services_linux [global options] command [command options] [arguments...]

DESCRIPTION:
   manage services lifecycle via GitOps

COMMANDS:
   promote  promote from one environment to another
   help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --github-token value  oauth access token to authenticate the request [$GITHUB_TOKEN]
   --help, -h            show help (default: false)
2020/04/27 14:00:07 Required flag "github-token" not set

All sorted now, green Travis build and checked binary is ok on both platforms, lemme know if you want more details around the IDs please privately


Building Examples with catkin

I tried using the catkin instructions here to build the examples: https://ethz-adrl.github.io/ct/ct_doc/doc/html/install_guide.html#build
When I try to run
rosrun ct_optcon ex_NLOC,
I get the error
[rosrun] Couldn't find executable named ex_NLOC below /home/noopygbhat/catkin_ws/src/control-toolbox/ct_optcon
Thoughts?

Did you solved this error? I am also having this error. I have some findings that might be helpful.
When you run catkin build -DCMAKE_BUILD_TYPE=Release -DBUILD_EXAMPLES=true
You will have warning that Could not find HPIPM or BLASFEO and that is why optcon examples are not building because it depends on blasfeo.
My problem is, I have tried to install all the packages of HPIPM and BLASFEO but I am still getting this warning and that is why when you run rosrun ct_optcon ex_NLOC, the error is coming.
Hope that will help you to find the reason of the error that you are getting. However, I am still finding the solution. Kindly please let me know if you already solved it and how did you do.

Actually, the executables were commented in /src/control-toolbox/ct_optcon/examples/CMakeLists.txt. So, uncomment them and try building again. That will work.

It works! Thanks!

@haasithp Thank you, I follow the guild but got this error fatal error: coin/IpTNLP.hpp: No such file or directory


update authentication method

What was the feature/problem?
Still can redirect to login after i logged in,
How does this PR address the above feature/problem?
i wrote a new component called private & temporary route for handle routing after & before login, and i store something like 'token' to localStorage as a sign already logged in or not
Check lists (check x in [ ] of list items)

[ ] Test passed
[ ] Coding style (indentation, etc)

Additional Comments (if any)
sorry for my bad english :)

@alisyahidin can you fix the tests that are failing and also make new tests for the components that you created?

okay, i will try it

@crstamps2 i have an issue here, correct me if i'm wrong.
I put a localStorage action before i use history.push to save 'token' before redirect to landing page after login. The toHaveBeenCalled's test is failed if i put a localStorage action before history.push.
hmm what's wrong with that?

Can you push your changes to your fork so that I can pull it down and see what you are talking about? It's kind of hard to make it out in that gif.

Oh sorry, i have already push it to branch authentication on my fork

i created test for new routing component that i have created, but still have no idea about the issue, i just commenting it to pass circle-ci test :smile:

Codecov Report

Merging #106 into master will decrease coverage by 1.06%.
The diff coverage is 70.58%.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   95.54%   94.48%   -1.07%
==========================================
  Files          28       29       +1
  Lines         404      417      +13
  Branches       42       46       +4
==========================================
+ Hits          386      394       +8
- Misses         15       20       +5
  Partials        3        3

Flag
Coverage Δ

#api
97.12% <ø> (ø)
:arrow_up:

#ui
92.59% <70.58%> (-1.76%)
:arrow_down:

Impacted Files
Coverage Δ

ui/src/app/App.js
100% <ø> (ø)
:arrow_up:

ui/src/app/Routing.js
100% <100%> (ø)

ui/src/wishList/wishHeader/index.js
20% <20%> (-80%)
:arrow_down:

ui/src/login/ValidatedSignInForm.js
95% <75%> (-5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3fc099...e689143. Read the comment docs.


Manager service caching issue during rules refresh on a Redis cluster

Issue summary
The existing logic on refreshRules() in the Manager service causes intermittent issues on applications using Redis in a replication cluster to cache the results.
Once retrieving the rules using getRules(), if the data is not available in cache the following code is executed:
if (null === $data && !$this->refreshRules($url, $ttl)) {
    throw new CouldNotLoadRules(sprintf('Unable to load the public suffix list rules for %s', $url));
}

The rules are refreshed as intended (via the CurlHttpClient), however right after this is processed the library attempts to json_decode() the data from cache again:
$data = json_decode($data ?? $this->cache->get($key), true);

For applications that use Redis in a replication cluster, the key might not yet be available to be accessed from cache (since the process is executed extremely fast), and causes the issue below intermittently:
┐
├ TypeError: json_decode() expects parameter 1 to be string, null given
│
╵ /var/www/app/vendor/jeremykendall/php-domain-parser/src/Manager.php:109

Do we think that instead of returning a bool as a result of refreshRules(), would be best to return the data that was parsed and cached instead? This in my opinion could make this logic more efficient since we won't need to access the cache twice.
For example, if we could do something similar to the following instead:
if (null === $data && null === ($data = $this->refreshRules($url, $ttl))) {
    throw new CouldNotLoadRules(sprintf('Unable to load the public suffix list rules for %s', $url));
}

All we would have to do is:
$data = json_decode($data, true);

Thoughts?
P.S.: As a workaround, I added a retry-policy on my cache pool that I have configured for this library. This basically gives me the ability to retry accessing the key again after a few milliseconds.
System informations

Information
Description

Pdp version
5.7.2

PHP version
7.4.23

OS Platform
Amazon Linux

I just realized after creating this issue that the library changed completely on version 6.x.
Please disregard.


Eats permanent Performance even when not in a (emergency) car

Love this - its what i searched for, so thank first...
i noticed that this resource is eating permanent performance, even when you are not in a (ermergency) car and on driver seat.
So is it possible to reduce it to be in a "emergency" car and on drivers seat to reduce the performance impact ?
Regards

What's 'eating performance' to you?

pma-sirensync.
its minimum on 0.03
even on foot and miles away from any vehicle

0.03ms, does that sound like a lot?

yah when a resource is running in background, even there is no need to ? it should just sleep whenn you are not in any vehicle/ as driver ..

0.03ms is not a lot at all, it's still running because sounds need to be synced even though you're out of the vehicle

What would've been a lot was 0.10ms for idle

You too!


[ROCm] Testcase updates to get ROCm Community Supported Builds passing again

Recent changes have broken a couple of tests that get run as part of the ROCm Community Supported Build, leading to the failure of the ROCm Nightly CSB.
This PR modifies those testcases (adding no_rocm tag to one, skipping subtests on the other) to make tests pass on the ROCm platform to get the ROCm Nightly CSB passing again (see commit messages for details)

@whchung @chsigg

@rthadur I am unable to access the logs for the CI run failures above.
All but the "Ubuntu Sanity" failure are unlikely to be caused by changes in this PR.  I have been trying to take a peek at the failure log for "Ubuntu SAnity" for a couple of hours now with no success (connection times out).


Add suppress offline mode warning

Why?

We don't suppress useful information

How is it useful?

Its just an annoyance when you are running a bungee server

Join us on Discord if you'd like to have a conversation about it (or search it up in there to see previous discussions on it).

Its so we know who not to provide support for.

Ah, fair enough. Thanks anyways

That's actually not any of the valid reasons we don't do this. We will only suppress pointless information, not useful information. And these offline messages (whether the server is in offline mode for piracy, testing, or behind a proxy) are very important information the server admins need to read and be aware of. It doesn't matter how annoying it is, it is important information, so it will never be suppressed by us.


Update dependencies, fix incompatibility with image 0.24

Fixes https://github.com/abonander/img_hash/issues/52

@lovasoa your PR contains the whole renaming to image_hasher

@lovasoa Is this still being maintained?

no :grimacing:


Remove separate AsyncLocal for ActivityId

Simplify handling and fallbacks of ActivityIDs to something similar to how it was before the move to AsyncLocal.
Add RequestContext.ActivityId property for ease of flowing an end-to-end activity ID even in .NET Standard, where Trace.CorrelationManager.ActivityId does not exist.
Avoid setting an explicit null value if the AsyncLocal is already null when clearing.

Thank you , @jdom.