How to test on multi devices?

When I test on multi devices. It throws the following error:
It looks like the error caused by FlutterDriver using “adb forward”.
[debug] [FlutterDriver] D:\Work\AndroidSDK\platform-tools\adb.exe forward tcp:40477 tcp:40477
[debug] [FlutterDriver] Deleting Flutter Driver session
[debug] [BaseDriver] Event 'newSessionStarted' logged at<PHONE_NUMBER>702 (16:48:01 GMT+0800 (GMT+08:00))
[debug] [W3C] Encountered internal error running command: Error: Command failed: D:\Work\AndroidSDK\platform-tools\adb.exe forward tcp:40477 tcp:40477
[debug] [W3C] adb.exe: error: more than one device/emulator

When I comment the following codes, It can run. But can't test flutter code
flutterCapabilities.setCapability ("automationName", "Flutter");

@hbolin
Please share the complete logs using gist.

Hello,
I discovered the same issue. Here is my error message:
[debug] [W3C] Encountered internal error running command: Error: Command failed: /Users/jakubstephan/Library/Android/sdk/platform-tools/adb forward tcp:51006 tcp:51006 [debug] [W3C] adb: error: more than one device/emulator
I looks like a problem with this function: https://github.com/truongsinh/appium-flutter-driver/blob/424a9fb38152b450c8bc0b35fbbccd7fa00e9b1b/driver/lib/sessions/android.ts#L34
I dont know why, but in my case, this command is executed without -s UDID parameter as it's wrote in the code.
I have 2 devices connected, but in capabilities i'm pointing into specific one by: udid, name, os_version.
In the attachment i have added also appium full log, with capabilities etc.
appium.log

Hello,
I discovered the same issue. Here is my error message:
[debug] [W3C] Encountered internal error running command: Error: Command failed: /Users/jakubstephan/Library/Android/sdk/platform-tools/adb forward tcp:51006 tcp:51006 [debug] [W3C] adb: error: more than one device/emulator
I looks like a problem with this function: https://github.com/truongsinh/appium-flutter-driver/blob/424a9fb38152b450c8bc0b35fbbccd7fa00e9b1b/driver/lib/sessions/android.ts#L34
I dont know why, but in my case, this command is executed without -s UDID parameter as it's wrote in the code.
I have 2 devices connected, but in capabilities i'm pointing into specific one by: udid, name, os_version.
In the attachment i have added also appium full log, with capabilities etc.
appium.log

Thanks @jstephancc for reporting this. Strange thing is I am not able to see -s udid in the logs. Will try to reproduce the issue.
@hex0cter is it fine for you to reproduce this.

Thanks @jstephancc for reporting this. Strange thing is I am not able to see -s udid in the logs. Will try to reproduce the issue.
@hex0cter is it fine for you to reproduce this.

@shibupanda if you will be able to debug this code, please check if this function is called during this issue. It might be a issue, that method is called from appium-base instead of your implementation ?
Please let me know, can i help you somehow ?

@shibupanda if you will be able to debug this code, please check if this function is called during this issue. It might be a issue, that method is called from appium-base instead of your implementation ?
Please let me know, can i help you somehow ?

@shibupanda if you will be able to debug this code, please check if this function is called during this issue. It might be a issue, that method is called from appium-base instead of your implementation ?
Please let me know, can i help you somehow ?

If you can build the driver locally by adding some logs after https://github.com/truongsinh/appium-flutter-driver/blob/424a9fb38152b450c8bc0b35fbbccd7fa00e9b1b/driver/lib/sessions/android.ts#L36 and check if the udid is getting printed.

@shibupanda if you will be able to debug this code, please check if this function is called during this issue. It might be a issue, that method is called from appium-base instead of your implementation ?
Please let me know, can i help you somehow ?

If you can build the driver locally by adding some logs after https://github.com/truongsinh/appium-flutter-driver/blob/424a9fb38152b450c8bc0b35fbbccd7fa00e9b1b/driver/lib/sessions/android.ts#L36 and check if the udid is getting printed.

@shibupanda will you be able to give some short instruction how to make it ?
I guess after cloning repo, i need to go inside driver dir and process there prepare & compile scripts?
Then should i move build dir into my path where global node_modules are stored? Or there is some easiest way to use locally build package ?
I'm working on OSX.

@shibupanda will you be able to give some short instruction how to make it ?
I guess after cloning repo, i need to go inside driver dir and process there prepare & compile scripts?
Then should i move build dir into my path where global node_modules are stored? Or there is some easiest way to use locally build package ?
I'm working on OSX.

@shibupanda will you be able to give some short instruction how to make it ?
I guess after cloning repo, i need to go inside driver dir and process there prepare & compile scripts?
Then should i move build dir into my path where global node_modules are stored?

Yes inside appium-flutter-driver

@shibupanda will you be able to give some short instruction how to make it ?
I guess after cloning repo, i need to go inside driver dir and process there prepare & compile scripts?
Then should i move build dir into my path where global node_modules are stored?

Yes inside appium-flutter-driver

@jstephancc this is how I tested it locally:

clone the repo
go to the driver folder
run npm link
Find out where you appium is installed (different for command line and appium desktop). In my case which appium suggests it is installed ~/.nvm/versions/node/v12.16.2/bin/appium. Based on that I can tell the appium-flutter-driver is in ~/.nvm/versions/node/v12.16.2/lib/node_modules/appium/node_modules/appium-flutter-driver
run rm -r ~/.nvm/versions/node/v12.16.2/lib/node_modules/appium/node_modules/appium-flutter-driver
create a symbolic file ln -s <repo path>/driver ~/.nvm/versions/node/v12.16.2/lib/node_modules/appium/node_modules/appium-flutter-driver
Next time you run the tests, appium should pick up what you have locally.

Hope this helps.

@jstephancc this is how I tested it locally:

clone the repo
go to the driver folder
run npm link
Find out where you appium is installed (different for command line and appium desktop). In my case which appium suggests it is installed ~/.nvm/versions/node/v12.16.2/bin/appium. Based on that I can tell the appium-flutter-driver is in ~/.nvm/versions/node/v12.16.2/lib/node_modules/appium/node_modules/appium-flutter-driver
run rm -r ~/.nvm/versions/node/v12.16.2/lib/node_modules/appium/node_modules/appium-flutter-driver
create a symbolic file ln -s <repo path>/driver ~/.nvm/versions/node/v12.16.2/lib/node_modules/appium/node_modules/appium-flutter-driver
Next time you run the tests, appium should pick up what you have locally.

Hope this helps.

Hi,
I have some problem with running my version of appium-flutter-driver.
I removed rm -r /usr/local/lib/node_modules/appium-flutter-driver
I have project cloned into:
/Users/jakubstephan/dev/appium-flutter-driver
I have run there a command npm link:
MacBook-Pro-Jakub:driver jakubstephan$ npm link

><EMAIL_ADDRESS>prepare /Users/jakubstephan/dev/appium-flutter-driver/driver
> npm run clean && npm run compile

><EMAIL_ADDRESS>clean /Users/jakubstephan/dev/appium-flutter-driver/driver
> rm -rf build

><EMAIL_ADDRESS>compile /Users/jakubstephan/dev/appium-flutter-driver/driver
> tsc

audited 629 packages in 4.614s

26 packages are looking for funding
  run `npm fund` for details

found 1 high severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
/usr/local/lib/node_modules/appium-flutter-driver -> /Users/jakubstephan/dev/appium-flutter-driver/driver

It looks like link is created (location: /usr/local/lib/node_modules/appium-flutter-driver):
lrwxr-xr-x    1 jakubstephan  admin    52B 27 sty 08:11 appium-flutter-driver -> /Users/jakubstephan/dev/appium-flutter-driver/driver
I have added some basic modification like:
logger.debug(`JS modification - Executing Flutter driver command '${cmd}'`);

But there is no effect while running a tests...
[debug] [FlutterDriver] Executing Flutter driver command 'implicitWait'

Hi,
I have some problem with running my version of appium-flutter-driver.
I removed rm -r /usr/local/lib/node_modules/appium-flutter-driver
I have project cloned into:
/Users/jakubstephan/dev/appium-flutter-driver
I have run there a command npm link:
MacBook-Pro-Jakub:driver jakubstephan$ npm link

><EMAIL_ADDRESS>prepare /Users/jakubstephan/dev/appium-flutter-driver/driver
> npm run clean && npm run compile

><EMAIL_ADDRESS>clean /Users/jakubstephan/dev/appium-flutter-driver/driver
> rm -rf build

><EMAIL_ADDRESS>compile /Users/jakubstephan/dev/appium-flutter-driver/driver
> tsc

audited 629 packages in 4.614s

26 packages are looking for funding
  run `npm fund` for details

found 1 high severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
/usr/local/lib/node_modules/appium-flutter-driver -> /Users/jakubstephan/dev/appium-flutter-driver/driver

It looks like link is created (location: /usr/local/lib/node_modules/appium-flutter-driver):
lrwxr-xr-x    1 jakubstephan  admin    52B 27 sty 08:11 appium-flutter-driver -> /Users/jakubstephan/dev/appium-flutter-driver/driver
I have added some basic modification like:
logger.debug(`JS modification - Executing Flutter driver command '${cmd}'`);

But there is no effect while running a tests...
[debug] [FlutterDriver] Executing Flutter driver command 'implicitWait'

Together with my team college we found an issue.
Problem is, that appium uses appium-flutter-driver from:
/usr/local/lib/node_modules/appium/node_modules/appium-flutter-driver
i had also appium-flutter-driver installed in latest version but in:
/usr/local/lib/node_modules/appium-flutter-driver
And...
/usr/local/lib/node_modules/appium/node_modules/appium-flutter-driver - verision 0.0.23
/usr/local/lib/node_modules/appium-flutter-driver - verision 0.0.27
Fix/change for it is already in place:
https://github.com/truongsinh/appium-flutter-driver/commit/813dd31d562fa1b58fb7af310641b2ac75a5051b#diff-2d098b30480f3d2c04ff2e94d5b06d801d2df603df05e8d5ac7fb4d798621bb8R42
I guess problem is, that appium has older version of appium-flutter-driver by default.

Together with my team college we found an issue.
Problem is, that appium uses appium-flutter-driver from:
/usr/local/lib/node_modules/appium/node_modules/appium-flutter-driver
i had also appium-flutter-driver installed in latest version but in:
/usr/local/lib/node_modules/appium-flutter-driver
And...
/usr/local/lib/node_modules/appium/node_modules/appium-flutter-driver - verision 0.0.23
/usr/local/lib/node_modules/appium-flutter-driver - verision 0.0.27
Fix/change for it is already in place:
https://github.com/truongsinh/appium-flutter-driver/commit/813dd31d562fa1b58fb7af310641b2ac75a5051b#diff-2d098b30480f3d2c04ff2e94d5b06d801d2df603df05e8d5ac7fb4d798621bb8R42
I guess problem is, that appium has older version of appium-flutter-driver by default.

I was going to ask the same question. But maybe it is a question for Appium?

I was going to ask the same question. But maybe it is a question for Appium?

@hex0cter @jstephancc that should not be the case because "appium-flutter-driver": "^0" mentioned in appium package.json so it should pick latest one started with 0.. until will release a major version.
https://github.com/appium/appium/blob/d37090e67e88d2f59113b62174f1dcd1d2e8611f/package.json#L48

@hex0cter @jstephancc that should not be the case because "appium-flutter-driver": "^0" mentioned in appium package.json so it should pick latest one started with 0.. until will release a major version.
https://github.com/appium/appium/blob/d37090e67e88d2f59113b62174f1dcd1d2e8611f/package.json#L48

I just double checked that:
<EMAIL_ADDRESS>-><EMAIL_ADDRESS><EMAIL_ADDRESS>-><EMAIL_ADDRESS>As of today when we install appium by npm install -g appium, by default<EMAIL_ADDRESS>is installed.
So I guess next release of appium will pick up<EMAIL_ADDRESS>and above.

I just double checked that:
<EMAIL_ADDRESS>-><EMAIL_ADDRESS><EMAIL_ADDRESS>-><EMAIL_ADDRESS>As of today when we install appium by npm install -g appium, by default<EMAIL_ADDRESS>is installed.
So I guess next release of appium will pick up<EMAIL_ADDRESS>and above.

Probably the next 1.21.0 will have the version

Probably the next 1.21.0 will have the version

In case anyone wants to try the latest version<EMAIL_ADDRESS>already have<EMAIL_ADDRESS>https://david-dm.org/appium/appium

In case anyone wants to try the latest version<EMAIL_ADDRESS>already have<EMAIL_ADDRESS>https://david-dm.org/appium/appium


docs: add OG meta tags, including the image

Fix #59 by adding open graph protocols meta tags.
Here is a preview of how it looks. Disregard the URL, it was just to test it.

Note: A bunch of files were modified by the linter, I think that's desired behavior but if it's not I"ll revert it. All of the non-linter changes are in the example-nextjs/components/Layout.tsx file.

Thanks for the PR!
@all-contributors add @pouannes for these code contributions :)


GCP endpoint validation error

While working with GCP if the provided endpoint has a port number for example ("storage.googpleapis.com:443") then the endpoint validation using the function IsGoogleEndpoint() fails and throws an error
"Google Cloud Storage endpoint should be 'storage.googleapis.com'"
In the function IsGoogleEndPoint() there is exact hostname matching happens but in the GO-URL package in the struct URL host contains both hostname and port this causes the error if the provided endpoint has a port.

This issue is resolved in this PR


Click on 'Filter einblenden....'
select " Vergangegen Veranstaltungen"
by Event location enter Bürger
see the location options '....'
See error Location not selectable

Expected Behavior

Actual Behavior

Additional Information

Traceback

Related Issues


Topk and arange

Continue after the rebase of NNVM.

@thirdwing A lot of R lint errors poped up after merging in master. Did you change anything in master?

I don't think so. I will check that tomorrow.

@piiswrong Seems the following code will not trigger error now:
import mxnet as mx
a = mx.nd.ones((10,10))
b = mx.nd.sum(a, axxxxis=1)

a = mx.nd.ones((10,10))
b = mx.nd.sum(a, axxxxis=1)
Traceback (most recent call last):
File "", line 1, in
File "/scratch/mxnet/python/mxnet/_ctypes/ndarray.py", line 131, in generic_ndarray_function
c_array(ctypes.c_char_p, [c_str(str(i)) for i in kwargs.values()])))
File "/scratch/mxnet/python/mxnet/base.py", line 75, in check_call
raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: Cannot find argument 'axxxxis', Possible Arguments:

axis : Shape(tuple), optional, default=()
Empty or unsigned or tuple. The axes to perform the reduction.If left empty, a global reduction will be performed.
keepdims : boolean, optional, default=False
If true, the axis which is reduced is left in the result as dimension with size one.

@piiswrong OK, I find that I'm using Cython. ctypes works correctly.

Weird. Seems there is a bug with cython interface. @tqchen

what happened to R lint?

@piiswrong I find the python test fails because when I use a = mx.nd.ones(shape=(10,10), ctx=mx.cpu(1)) , the context of a will still be mx.cpu(0).

The r lint problem also popped up on my machine. It wasn't failing before. Does anyone know why suddenly we have errors like this:
R-package/src/symbol.h:6:  #ifndef header guard has wrong style, please use: R_PACKAGE_SRC_SYMBOL_H_  [build/header_guard] [5]

I found the issue. Was due to this change in dmlc-core: https://github.com/dmlc/dmlc-core/commit/a3b2fbeb360a15cfbfd5762dd62c1b81309f5c6a#diff-460cb56a7855c776ca8943d6f4f2c6c4
Will pr to dmlc-core to fix it. Please update dmlc-core afterwards

Please manually update dmlc-core to current master

looks ok now. Please fix lint


Build order issue for nvidia backend

NVIDIA Backend Build Dependency Issue with CUDA Headers
Issue Description
The NVIDIA backend build in Triton fails because it attempts to compile files that depend on CUDA headers before the required directory structure (backend/include/) is generated during the build process. This is a build dependency ordering issue.
Current Behavior
When building Triton with NVIDIA backend support, the compilation fails because cublas_types.h tries to include headers from a directory that hasn't been created yet:
[ 76%] Building CXX object third_party/nvidia/CMakeFiles/TritonNVIDIA.dir/triton_nvidia.cc.o
In file included from triton/third_party/nvidia/include/cublas_instance.h:4,
                 from triton/third_party/nvidia/triton_nvidia.cc:4:
triton/third_party/nvidia/include/cublas_types.h:6:10: fatal error: backend/include/cuda.h: No such file or directory

The failure occurs because:

The build system tries to compile triton_nvidia.cc which includes cublas_instance.h
cublas_instance.h includes cublas_types.h
cublas_types.h expects headers in backend/include/, but this directory hasn't been generated yet

Root Cause Analysis
Looking at the CMake files:

In third_party/nvidia/CMakeLists.txt, we see:

add_triton_plugin(TritonNVIDIA ${CMAKE_CURRENT_SOURCE_DIR}/triton_nvidia.cc LINK_LIBS TritonNVIDIAGPUToLLVM NVGPUToLLVM)

The add_subdirectory(include) is called before this target, but the actual generation of backend/include appears to happen at build time rather than configure time.

Proposed Fix
I think that there needs to be ordering established in the CMakeLists inside of third_party/nvidia and its include directory.
 We don't support building just with cmake.

To elaborate a bit more, this is not a dependency ordering issue as setup.py's download_and_copy is supposed to ensure the presence of the nvidia libraries/headers. If you do an offline build with TRITON_OFFLINE_BUILD=1 or skip the setup.py and call cmake directly, it's your responsibility to copy the required files to the right places.
https://github.com/triton-lang/triton/blob/a2b398e0bb1b120f31cf386d6ae3261c3ab84207/python/setup.py#L297-L330
https://github.com/triton-lang/triton/blob/a2b398e0bb1b120f31cf386d6ae3261c3ab84207/python/setup.py#L525-L583
Before https://github.com/triton-lang/triton/pull/4085 triton would at least build without cuda libraries even if triton.backends.nvidia wasn't active at runtime,
>>> import triton
>>> triton.backends.backends
{'amd': Backend(name='amd', compiler=<class 'amd.HIPBackend'>, driver=<class 'amd.HIPDriver'>), 'cpu': Backend(name='cpu', compiler=<class 'cpu.CPUBackend'>, driver=<class 'cpu.CPUDriver'>), 'nvidia': Backend(name='nvidia', compiler=<class 'nvidia.CUDABackend'>, driver=<class 'nvidia.CudaDriver'>)}
>>> triton.backends.nvidia
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'triton.backends' has no attribute 'nvidia'
>>> triton.backends.amd
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'triton.backends' has no attribute 'amd'
>>> triton.backends.cpu
<module 'triton.backends.cpu' from .../triton-cpu/python/triton/backends/cpu/__init__.py'>

I think this change was unintentional and have opened https://github.com/triton-lang/triton-cpu/issues/202 and https://github.com/triton-lang/triton-cpu/pull/203 in triton-cpu to address this.


Mobile modals

Description
On mobile device in modals btn close closed modal sometimes on second click

Not reproducible with the example from your other issue (Chrome 56 on Android 7 here).
Please always provide a codepen and some information about the used browser.

Not reproducible on: Win10 64bit Chrome, Edge, Firefox), Mac OsX 11.11(Chrome, Safari, Firefox) as well on ios and Android 7

ok i thought it is problem)


issue: /tmp/mnt is a size limited ram mounted partition on linux with the AppImage

Issue
when trying to side-load some big files, I got a message which said No space left on the device:
Error: ENOSPC: no space left on device, copy file ....

BUT, I did had space in both the device and the PC file system. Looking further I found it was mounting
the remote source at /tmp/mnt.
The problem is that /tmp in most linux systems is mounted in the ram memory and the size is limited.
Temporal solution
By monitoring the mounted partition /tmp while sideloading I handle to side 2 OBBs files like 4 GB each.
by increasing the ram memory filesystem size  of  /tmp

Note: this is limited to the users ram and in my case probably because I was running many programs.

sudo mount -o remount,size=10G /tmp/

Possible Solutions.

Change the mounting point to a non-ram based directory or a .tmp hidden directory where the AppImage has control.
Cleanup the directory after the procedure is finished.

You can change "temp" folder at app settings


Remove deployer dependency in core-modules

We are not going to do this refactor, as is simpler to use the deployer for testing purposes on specific contract tests.


I want to build tensorflow-gpu 1.4.0

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):no
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):Ubuntu 16.04.4 LTS
TensorFlow installed from (source or binary):source
TensorFlow version (use command below):tensorflow-gpu 1.4.0
Python version: 2.7.12
Bazel version (if compiling from source):0.5.4
GCC/Compiler version (if compiling from source):5.4.0
CUDA/cuDNN version:8.0/6.0.21
GPU model and memory:GeForce GTX 980 4GB
Exact command to reproduce:

Describe the problem
I am trying to install TensorFlow from Sources. I did it with reference to https://www.tensorflow.org/install/install_sources.But I accidentally built a CPU version.
I want to build tensorflow-gpu 1.4.0 from source. But I cannot find the GPU version of tensorflow.
Any suggestions would help. Thanks.

Hi @nagata-tensor -- please make sure you have the NIVIDIA prerequisites installed on your system before installing from source. Then you can proceed with the install from source instructions.

Hi @karmel I have the NVIDIA prerequisites installed on my system. I could proceed with the install from source instructions.


Small change docs/1

Some small changes on the docs.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.02%) to 85.963%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
4
90.63%

crates/qasm2/src/parse.rs
6
97.58%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
71492

Relevant Lines:
83166

💛  - Coveralls


Cannot suppress started/processing in new rails app

No matter how much configuration I throw at rails_semantic_logger I can't seem to make it behave as expected, which leads me to believe that my expectations are wrong.
Personal context: old with ruby, new with rails, new with semantic_logger, completely befuddled by autoload and how the Rails config system determines order of processing.
Environment

ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin15]
Rails 5.1.4
rails_semantic_logger (4.1.3)
semantic_logger (4.2.0)
puma 3.10.0 (ruby 2.4.0-p0), codename: Russell's Teapot.

Reproduce
Create and fire up a new rails app, without initially mucking with anything other than the Gemfile
$> rails new s_l_app
$> # edit Gemfile to add `gem "rails_semantic_logger"`
$> bundle install
$> bundle list rails_semantic_logger #=>.../ruby/2.4.0/gems/rails_semantic_logger-4.1.3
$> bundle exec rails s
$> curl 'http://localhost:3000/'
$> # stop it and explicitly add `config.rails_semantic_logger.started  = false` to `application.rb`
$> mv log/development.log log/dev1.log
$> bundle exec rails s
$> curl 'http://localhost:3000/'

Expected Behavior

Default logging behavior as described at https://rocketjob.github.io/semantic_logger/rails.html
Directives in application.rb will be honored, e.g. config.rails_semantic_logger.started = false

Actual Behavior

$> diff log/dev1.log log/development.log
# the same except for timestamps, pids

$> cat log/development.log

2017-09-14 06:38:57.032152 D [81773:puma 002] Rack -- Started -- {:method=>"GET", :path=>"/", :ip=>"<IP_ADDRESS>"}
2017-09-14 06:38:57.041290 D [81773:puma 002] Rails::WelcomeController -- Processing #index
2017-09-14 06:38:57.204222 D [81773:puma 002] ActionView::Base --   Rendering /Users/dueberb/.gem/ruby/2.4.0/gems/railties-5.1.4/lib/rails/templates/rails/welcome/index.html.erb
2017-09-14 06:38:57.207505 D [81773:puma 002] ActionView::Base --   Rendered /Users/dueberb/.gem/ruby/2.4.0/gems/railties-5.1.4/lib/rails/templates/rails/welcome/index.html.erb (3.2ms)
2017-09-14 06:38:57.207720 I [81773:puma 002] (166.4ms) Rails::WelcomeController -- Completed #index -- {:controller=>"Rails::WelcomeController", :action=>"index", :format=>"*/*", :method=>"GET", :path=>"/", :status=>200, :view_runtime=>18.33, :status_message=>"OK"}

Crappity crap. Those things are all at :debug and are appearing as they're coded to. I'll just write a filter to do what I need to do.


Allow dynamic add observer

Add the following methds for component:

dynamicAddObserver
addLifetimeListener
addPageLifetimeListener

Some test cases are needed?


Update return types of characteristic notification functions

https://webbluetoothcg.github.io/web-bluetooth/#bluetoothremotegattcharacteristic

BluetoothRemoteGATTCharacteristic.startNotifications -> Promise(BluetoothRemoteGATTCharacteristic)
BluetoothRemoteGATTCharacteristic.stopNotifications -> Promise(BluetoothRemoteGATTCharacteristic)

Is the solution to this simply calling resolve(this) instead of just resolve at api.web-bluetooth.js lines 502 and  509 ?

I think so. Same for stopNotifications, too.


⚠ Samsung has degraded performance

In 5e7689c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2394 ms

Resolved: Samsung performance has improved in 3478815.


Plan out relation between projects, users, beaver, and api keys

Created ER diagram

Closed pr #7

closed


Add plots

Add plot module: TS diagram
Add projection attribute
Address #54, #53,
Implement aliases on missing functions

I added the option killAxes in cutout. This option will remove the axes with just one point. For example, if you run od.cutout(timeRange='2007-09-01') it will return an oceandataset with 2 time points and 1 time_midp point. If you run od.cutout(timeRange='2007-09-01', killAxes=True), then time will be removed from the  grid object and it will return an oceandataset with 1 time and 1 time_midp dimension. It works on every dimension. So, let's say you only want 1 point in every Z dimension, then kill the Z axis.

killAxes can be set True, or you can specify the axis that you want to kill (e.g., killAxes=['time', 'Z']).

Use killAxes only if you are sure that you won't need the axis in the future. So, don't use it untill the very end of your script, use only use it for visualization purposes, like the example below.

Now you can use cutout arguments directly in the plot function, and the title is more informative.

Here are 2 examples that hopefully will make it more clear:

Don't kill the time axis, and get 2 time points even if timeRange only has 1 value:

import oceanspy as ospy
%matplotlib inline
od = ospy.open_oceandataset.EGshelfIIseas2km_ASR()
od.TS_diagram(cutout_kwargs={'ZRange': 0, 'timeRange': '2007-09'}

Kill the time axis, and get 1 time point only:

import oceanspy as ospy
%matplotlib inline
od = ospy.open_oceandataset.EGshelfIIseas2km_ASR()
od.TS_diagram(cutout_kwargs={'ZRange': 0, 'timeRange': '2007-09', 'killAxes': True}

You can now easily plot timeseries. Here is an example. With one line of code I'm plotting the verticaly integrated zonal velocity in the top 100m for different latitudes:
import oceanspy as ospy
%matplotlib inline
od = ospy.open_oceandataset.EGshelfIIseas2km_ASR()
ax = od.time_series(varName  = 'U',
                    sumAxes  = ['Z'],
                    meanAxes = ['X'],
                    cutout_kwargs={'timeRange': ['2007-09-01', '2007-09-10'],
                                   'YRange': [ 62,  62.1],
                                   'ZRange': [0, -

100]})

Suggestions:
TS_diagram computes the density anomaly, even if it's already present. Check if Sigma0 is available and, if so, use it rather than re-compute.
Also: plot Sigma0 contours over the full oceanographic TS range so that subsequently adjusting axis limits avoids the contours ending.
BTW, please remind how to retrieve the latest documentation.
Thanks!

Good timing! I'm almost done with plots and animations:

Re-computing Sigma0 sounds like a slowdown, but it's actually faster because a matrix with only 100 Temp and 100 S values is usually enough. If you are plotting a lot of T and S points, using Sigma0 in the dataset would make things slower. I've added another argument  though, which allows to provide a custom DataArray to use for the isopycnals (could be for example od.dataset['Sigma0']). It is used for example by the animations, so the isopycnals are only computed once. If for some reason the density matrix automatically computed doesn't work well, then you can provide your own density values.
I'm now computing the freezing point and masking out densities below the freezing point.
Using isopycnals for full TS range has some pros and cons. Pros: you can adjust the axis after the plot and see isopycnals in the whole domain. Cons: the isopycnals are not optimized for the TS range of the specific plot (e.g., number of levels, labels outside of the domain), 100x100 T and S values could not be enough.

I think we have two options: 1) Compute Sigma0 for the full oceanographic TS range but also plot the full oceanographic TS range; 2) Keep it like that, and add a note in the documentation that suggests to use Tlim and Slim rather than ax.set_xlim and ax.set_ylim after.
What do you think?

Thanks Mattia, See inline below.
Professor Thomas W. N. Haine,
Department of Earth & Planetary Sciences,
329 Olin Hall, The Johns Hopkins University,
Baltimore, MD 21218
Tel.:<PHONE_NUMBER>
Fax.:<PHONE_NUMBER>
Thomas.Haine<EMAIL_ADDRESS>http://www.jhu.edu/~eps/faculty/haine
On Mar 3, 2019, at 4:59 PM, Mattia Almansi <notifications<EMAIL_ADDRESS>wrote:
Good timing! I'm almost done with plots and animations:

Re-computing Sigma0 sounds like a slowdown, but it's actually faster because a matrix with only 100 Temp and 100 S values is usually enough. If you are plotting a lot of T and S points, using Sigma0 in the dataset would make things slower. I've added another argument though, which allows to provide a custom DataArray to use for the isopycnals (could be for example od.dataset['Sigma0']). It is used for example by the animations, so the isopycnals are only computed once. If for some reason the density matrix automatically computed doesn't work well, then you can provide your own density values.

Good plan. That also allows the user to plot, say, Sigma4 instead of Sigma0.

I'm now computing the freezing point and masking out densities below the freezing point.

Good plan.

Using isopycnals for full TS range has some pros and cons. Pros: you can adjust the axis after the plot and see isopycnals in the whole domain. Cons: the isopycnals are not optimized for the TS range of the specific plot (e.g., number of levels, labels outside of the domain), 100x100 T and S values could not be enough.

Understood.
I think we have two options: 1) Compute Sigma0 for the full oceanographic TS range but also plot the full oceanographic TS range; 2) Keep it like that, and add a note in the documentation that suggests to use Tlim and Slim rather than ax.set_xlim and ax.set_ylim after.
What do you think?
I like option 2 better!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://github.com/malmans2/oceanspy/pull/56#issuecomment-469069108, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ap_0KjrYpM2_PRP_aXwpQ5qeB864Nwxqks5vTEXagaJpZM4bXEVi.

I'm always storing the documentation of the last push in the shared folder on SciServer. If you want to make sure that you are reading the documentation associated with your code:

Go in the docs folder: cd ocenaspy/docs
Create the documentation environment: conda env create -f environment.yml
Activate the documentation environment source activate ospy_docs (depending on the conda version, it might be conda activate ospy_docs, the terminal will tell you.
Create the documentation make html (make clean and rm -r generated/ first if you want to compile from scratch).
The documentation is stored under ocenaspy/docs/_build/html
If you are on SciServer, you can't use the browser. I usually zip the html folder and download it on my laptop.

The terminal shows the name of the active environment. If you do pip or conda install, then it will install in that environment. So,

Make sure you deactivate (or open a new terminal) before installing packages that you need for you base environment (e.g., a new package that you want to use in your notebook) .
Make sure the ospy_docs environment is activated if you need to compile the documentation.

Understood!  Thanks!!
On Mar 3, 2019, at 5:16 PM, Mattia Almansi <notifications<EMAIL_ADDRESS>wrote:
I'm always storing the documentation of the last push in the shared folder on SciServer. If you want to make sure that you are reading the documentation associated with your code:

Go in the docs folder: cd ocenaspy/docs
Create the documentation environment: conda env create -f environment.yml
Activate the documentation environment source activate ospy_docs (depending on the conda version, it might be conda activate ospy_docs, the terminal will tell you.
Create the documentation make html (make clean and rm -r generated/ first if you want to compile from scratch).
The documentation is stored under ocenaspy/docs/_build/html
If you are on SciServer, you can't use the browser. I usually zip the html folder and download it on my laptop.

The terminal shows the name of the active environment. If you do pip or conda install, then it will install in that environment. So,

Make sure you deactivate (or open a new terminal) before installing packages that you need for you base environment (e.g., a new package that you want to use in your notebook) .
Make sure the ospy_docs environment is activated if you need to compile the documentation.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://github.com/malmans2/oceanspy/pull/56#issuecomment-469070559, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ap_0Klb_JBmjOR8tm9o3DNeUt1tYh4Edks5vTEmrgaJpZM4bXEVi.

I've improved the TS diagram. New features:

use meanAxes parameter to compute mean along axes before plotting. E.g., meanAxes=['Z']
compute freezing point using S, and mask out isopycnals below freezing temperature
use dens parameter to provide a DataArray that will be used to plot isopycnals (if not provided, Sigma0 will be computed).

@asiddi24 please review and let me know if anything is missing.
I'm implementing animations. There is a new module named animate.
Here is a minimal example:
import oceanspy as ospy
import matplotlib.pyplot as plt
%matplotlib inline
od = ospy.open_oceandataset.EGshelfIIseas2km_ASR()
XRange      = [-45, -18]
YRange      = [ 62,  70]
timeRange =  ['2007-08-29T15:00:00','2007-09-02T00:00:00']

Do you want a static plot?

ax = ospy.plot.TS_diagram(od, cutout_kwargs={'ZRange': ZRange,
                                             'XRange': XRange,
                                             'YRange': YRange,
                                             'timeRange': timeRange})

Do you want an animation? Same code, but use ospy.animation:

anim = ospy.animate.TS_diagram(od, cutout_kwargs={'ZRange': ZRange,
                                                  'XRange': XRange,
                                                  'YRange': YRange,
                                                  'timeRange': timeRange})

Alternatively, you can do od.TS_diagram(animate=True, ...) or od.TS_diagram(animate=False, ...)
@hooteoos-waltz  please review and let me know if anything is missing.
There are a lot of options! Check out the documentation. Just be aware that scatter plots (activated by colorName) can be very slow. You might want to reduce the number of points, for example using meanAxes.
One more thing. You need to install a new package in order to use animations. Please create a new container and install from scratch. Installing in a pre-existing container can take forever (I didn't have time to check why). Here is the installation:
$ conda config --remove channels defaults
$ conda config --add channels conda-forge
$ conda install dask distributed bottleneck netCDF4 xarray cartopy esmpy ffmpeg
$ pip install geopy xgcm xesmf xmitgcm

To download the new branch
$ git clone --single-branch --branch add_plots https://github.com/malmans2/oceanspy.git

And install in develop mode
$ pip install -e oceanspy/

The horizontal plots movies are ready as well. They work as the TS diagram.
Let's use the same cutout used before:
import oceanspy as ospy
import matplotlib.pyplot as plt
%matplotlib inline
od = ospy.open_oceandataset.EGshelfIIseas2km_ASR()
XRange      = [-45, -18]
YRange      = [ 62,  70]
ZRange      = [  0, -30]
timeRange   = ['2007-08-29T15:00:00','2007-09-02T00:00:00']

Plot first:
ax = ospy.plot.horizontal_section(od, varName='Temp', contourName='Depth',
                                  meanAxes=['Z'], center=False, robust = True, cmap='viridis',
                                  cutout_kwargs={'ZRange': ZRange,
                                                 'XRange': XRange,
                                                 'YRange': YRange,
                                                 'timeRange': timeRange})

And the movie:
anim = ospy.animate.horizontal_section(od, varName='Temp', contourName='Depth',
                                       meanAxes=['Z'], center=False, robust = True, cmap='jet',
                                       cutout_kwargs={'ZRange': ZRange,
                                                      'XRange': XRange,
                                                      'YRange': YRange,
                                                      'timeRange': timeRange})

Did you notice that the movie uses Mercator projection? The first plot doesn't project because it's a little hard to make it work with several subplots. If you want subplots and projection, it's better create your own for loop for now.
If your plot doesn't require subplots (e.g., average in time), then oceanspy will use the projection associated with the oceandataset. Do you want to change the projection? Just use od.set_projection:
ax = ospy.plot.horizontal_section(od.set_projection('PlateCarree'), varName='Temp', contourName='Depth', plotType='contourf',
                                  meanAxes=['Z', 'time'], center=False, cmap='hot',
                                  cutout_kwargs={'ZRange': ZRange,
                                                 'XRange': XRange,
                                                 'YRange': YRange,
                                                 'timeRange': timeRange})
ax.set_title('PlateCarree')

Or just switch the projection off
ax = ospy.plot.horizontal_section(od.set_projection(None), varName='Temp', contourName='Depth',
                                  sumAxes=['Z'], center=False,  cmap='inferno',
                                  contour_kwargs={'levels': [100, 200, 500, 600, 1000]},
                                  cutout_kwargs={'ZRange': ZRange,
                                                 'XRange': XRange,
                                                 'YRange': YRange,
                                                 'timeRange': timeRange[0],
                                                 'dropAxes': True})
ax.set_title('No Projection')

High temperature values because I'm summing on the Z axis now.
I've only shown a few options, hopefully everything is in the documentation!

Vertical sections done!
import oceanspy as ospy
import matplotlib.pyplot as plt
%matplotlib inline
od = ospy.open_oceandataset.EGshelfIIseas2km_ASR()
lats_Kogur = [ 68.68,  67.52,  66.49]
lons_Kogur = [-26.28, -23.77, -22.99]
timeRange   = ['2007-08-29T15:00:00','2007-09-02T00:00:00']

Plot:
ax = ospy.plot.vertical_section(od, varName='Temp', subsampMethod='survey_stations', contourName='Sigma0',
                                center=False, robust = True,
                                subsamp_kwargs={'Xsurv': lons_Kogur,
                                                'Ysurv': lats_Kogur,
                                                'ZRange': [0, -1600],
                                                'timeRange': timeRange,
                                                'dropAxes': 'time',
                                                'delta': 2,
                                                'varList': ['Temp', 'S']})

Animation:
anim = ospy.animate.vertical_section(od, varName='Temp', subsampMethod='survey_stations', contourName='Sigma0',
                                     center=False, robust = True,
                                     subsamp_kwargs={'Xsurv': lons_Kogur,
                                                     'Ysurv': lats_Kogur,
                                                     'ZRange': [0, -1600],
                                                     'timeRange': timeRange,
                                                     'dropAxes': 'time',
                                                     'delta': 2,
                                                     'varList': ['Temp', 'S']})

Plots need some minor fix, and I need to clean up a little the code, but they're pretty much ready.
I'm going to merge with master!


MIAD-59 Disable prometheus alerts (dev) in non business hour

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.32%. Comparing base (e9a5bd4) to head (29f2eb3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #130   +/-   ##
=========================================
  Coverage     95.32%   95.32%
  Complexity      579      579
=========================================
  Files            91       91
  Lines          1841     1841
  Branches         97       97
=========================================
  Hits           1755     1755
  Misses           67       67
  Partials         19       19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add description to buttons in panel app

In Panel 1.3, it is now possible to add descriptions to buttons. This will make it easier to show the intent between each button in the Panel app.
https://github.com/holoviz/holonote/assets/19758978/fa68fc68-c6f5-41af-8d85-9de189694985

Makes a lot of sense! Thanks!


Ability to clear the error on demand

Add a boolean flag to delete the error or pass it.
Flage should be called 'Erase error ?' and set to False by default

closed in v2.0.0


fs page metrics not updating

The file / space pie charts are not consistently updating due to the fact that metrics are not directly placed on the table. We may need to poll these metrics separately.

Dup of #1285


Update pulumi/eks docs for v0.18.10

Proposed changes

Update pulumi/eks docs for recent release of v0.18.10
@lukehoban @justinvp Note that I am not seeing the deprecated being marked here in the doc updates for options like here and here for the Cluster class. Thoughts?

Note that I am not seeing the deprecated being marked here in the doc updates for options like here and here for the Cluster class. Thoughts?

I'll have to look into it, but we may need to do something explicit in tsdocgen to read and emit this JSDoc tag from TypeDoc's JSON output. Mind opening an issue?


Failed to log into ED account for ship data

Please upgrade to 2.2.3 version of EDDI. FDev changed the Companion App API and older versions of EDDI won't work anymore.

Please try removing %APPDATA%\EDDI\credentials.json and see if this fixes your issue.


⚠ Bofrost.be has degraded performance

In 0e5d1c9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 884 ms

Resolved: Bofrost.be performance has improved in bb04e9a.


popover: added ability for user to specify position as for mdl-menu

-added ability for user to specify popover position using [mdl-popover-position] attribute which can take the following values: 'bottom-left', 'bottom-right', 'top-left', 'top-right'
-added some examples with different popover positions to e2e demo app:

Coverage decreased (-4.0%) to 92.882% when pulling 0ff62720034d945830e4026544a61676b93e6012 on AVykhrystyuk:vykhrystyuk/feature/popover-custom-position into 4f0bcd94360137c2ada00028098150d6c97407cb on mseemann:master.

Hi,
Currently there is no way for user to specify popover desired position. But in most cases this should be configurable, for example same way as it is for mdl-menu component.
Once user specify the position it should not care of checking if popover reached the edge of the window. The user is responsible for such checks and now he has an API to change the position any time he wants.
This PR makes the component position to be configurable using new [mdl-popover-position] attribute.

Coverage decreased (-1.3%) to 95.533% when pulling 12534cadaf6e1f7ac1838baf6e2bdb421d79ab9d on AVykhrystyuk:vykhrystyuk/feature/popover-custom-position into 4f0bcd94360137c2ada00028098150d6c97407cb on mseemann:master.

Coverage decreased (-1.8%) to 95.017% when pulling a8d929a77fe3f5d164169ca690d050f860df37df on AVykhrystyuk:vykhrystyuk/feature/popover-custom-position into 4f0bcd94360137c2ada00028098150d6c97407cb on mseemann:master.

@mseemann I will review it in evening, can you publish what we have in master so far, in particular the select fixes

@tb publish is done:  @angular-mdl/select:0.11.3

@AVykhrystyuk Thanks for PR. Code works as expected. Can you fix the two commented things?

Coverage decreased (-0.6%) to 96.22% when pulling 8e8d915064deb7cbeb8f0ab5b4bdcb4de256d7a6 on AVykhrystyuk:vykhrystyuk/feature/popover-custom-position into 4f0bcd94360137c2ada00028098150d6c97407cb on mseemann:master.

@tb Could you please review the update?

@tb you didn't forget about this PR, didn't you? ;)

@AVykhrystyuk Merged! Thank you for your contribution!

published as @angular-mdl/popover:0.9.0 and demo app updated.


Support running e2e tests on MacOS

Should we add a new CI env of MacOS to verify this?

Should we add a new CI env of MacOS to verify this?

Yes. @ethan256 Please add a simple GHA to verify the plugin test on MacOS. a single plugin testing is enough, such as the native HTTP plugin.

@lujiajing1126 Please make sure you have commit logs reset when squash. It is very crazy to see this on commit log.

Most are only noises.

@lujiajing1126 Please make sure you have commit logs reset when squash. It is very crazy to see this on commit log.

Most are only noises.

I will notice next time


Events for organizations

Feature Request
Desired behaviour
Display events for organizations. May need to flesh-out and make wireframe more attractive
┆Issue is synchronized with this Jira Story
┆Issue Number: DOCK-229

The basics of this have been done. Planning to add the following:

Pagination (webservice) and maybe
Add timestamp in UI on hover

FYI, there's pagination code that can be copied/re-used from tools/workflows

REPLACED BY DOCK-519


Hot reload doesn't work in Gitpod after fresh CRA install

Describe the bug
I set up a fresh React project in a Gitpod workspace using create-react-app. After starting the dev server with npm start, hot reload doesn't work. Changes to App.tsx are only rendered after refreshing the browser.
The following error is displayed in the console:

WebSocket connection to 'wss://3000-(private GitPod URL redacted).gitpod.io:3000/ws' failed

Based on this error, I suspect the problem is that when using GitPod you are supposed to access open ports through these special automatically generated subdomains, that proxy connections into the workspace. So for example http://localhost:3000 is accessed through https://3000-workspace-id.gitpod.io:443, where the HTTPS port (443) is proxied to port 3000.
The dev server detects that it's running on localhost:3000 and tries to connect to wss://3000-workspace-id.gitpod.io:3000 instead, which fails.
Changing the websocket port through an environmental variable just causes the same problem on a different port number.
Here is a link to open an example of this issue in GitPod: https://gitpod.io/#https://github.com/monophthongal/create-react-app-gitpod-bug
Interestingly GitPod's own create-react-app example works fine, but is using an older version of react-scripts: https://github.com/gitpod-io/create-react-app
Did you try recovering your dependencies?

This happens on a fresh install.
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

GitPod workspace accessed through Chrome 96.
  current version of create-react-app: 5.0.0
  running from /home/gitpod/.npm/_npx/c67e74de0542c87c/node_modules/create-react-app

  System:
    OS: Linux 5.13 Ubuntu 20.04.2 LTS (Focal Fossa)
    CPU: (16) x64 Intel(R) Xeon(R) CPU @ 2.80GHz
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v16.13.0/bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: Not Found
  npmPackages:
    react: ^17.0.2 => 17.0.2
    react-dom: ^17.0.2 => 17.0.2
    react-scripts: 5.0.0 => 5.0.0
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

Create a new React project with create-react-app and push to a GitHub repository.
Open the GitHub repository in a Gitpod workspace by adding gitpod.io# in front of the GitHub URL.
In the GitPod workspace, run npm install and npm start.
The app should open in a new tab automatically, but if not, you can do so by opening the Remote Explorer sidebar and clicking "Open Browser" next to port 3000.
Make any change to App.tsx.

Expected behavior

Changes should appear immediately without having to refresh the browser (hot reload).
Actual behavior

Changes are not displayed until the browser is refreshed.
Reproducible demo
https://github.com/monophthongal/create-react-app-gitpod-bug
You can open in GitPod at the following URL: https://gitpod.io/#https://github.com/monophthongal/create-react-app-gitpod-bug

Workaround: Setting WDS_SOCKET_PORT=0 causes the client to use window.location.port as the websocket port and makes hot reloading work as expected.
Explanation:
CRA is passing port: 3000 to webpack-dev-server like this (excluding unrelated options):
{
  client: {
    webSocketURL: { hostname: undefined, pathname: undefined, port: undefined },
  },
  port: 3000,
}

It looks like at some point webpack-dev-server started defaulting to port for the websocket connection when client.webSocketURL.port is undefined:
https://github.com/webpack/webpack-dev-server/blob/90a96f7bd8e5338f91ef8e4fd6c2ddc01e8174db/lib/Server.js#L547
So with the config passed in by CRA, it tries to connect to the websocket on port 3000, even when the server is being proxied through another port.
In order for it to use window.location.port as the websocket port instead, client.webSocketURL.port needs to be set to '0'. This can be accomplished by setting WDS_SOCKET_PORT=0:
{
  client: {
    webSocketURL: { hostname: undefined, pathname: undefined, port: '0' },
  },
  port: 3000,
}

So with that in mind, would it make more sense for CRA to set client.webSocketURL.port: '0' by default instead of client.webSocketURL.port: undefined?
Connecting to window.location.port is probably the expected behavior for most users, and seems to be how CRA worked before 5.0.

Work for me, i have the same problem with Docker.
ADD WDS_SOCKET_PORT=0 to my .env file of my react project.
This adding delete the warning in my console : WebSocket connection to 'ws://localhost:3000/ws' failed
Hot Refresh work again, and i can see again the error on the main screen of my website and not just in the console.

This just saved me a week.

Saved me so much time, hope this gets resolved in future react versions!

The WDS_SOCKET_PORT=0 workaround fixes the port, but it seems the protocol has a related regression.  It's being forced to "ws://" whereas it used to figure out it needs to use "wss://" from window.location.  If one reverse proxies both the dev server and the web socket behind a web server that does the TLS termination, browsers will complain about mixed content. The workaround there would be to disable the mixed content warning in dev, but that seems less desirable than how it used to work. The use case is integrating with other HTTPS-only web applications in dev behind the same reverse proxy.

after adding that command to .env new error shown in console.
(index):2762
   crbug/1173575, non-JS module files deprecated.

add WDS_SOCKET_PORT=0 to docker-compose file will also work

Workaround: Setting WDS_SOCKET_PORT=0 causes the client to use window.location.port as the websocket port and makes hot reloading work as expected.

This should be the default as it says in the docs: https://create-react-app.dev/docs/advanced-configuration/.

Hi,
If I add the WDS_SOCKET_PORT=0 to the .env file (same directory as package.json in my react app), the error  disappears:

WebSocket connection to 'ws://localhost:3000/ws' failed

But then, my react app comes up with a different error:

Uncaught runtime errors:
ERROR
Unexpected token 'o', "[object Blob]" is not valid JSON
SyntaxError: Unexpected token 'o', "[object Blob]" is not valid JSON
at JSON.parse ()
at https://myserver.com/absproxy/3000/static/js/bundle.js:39942:24
at client.onmessage (https://myserver.com/absproxy/3000/static/js/bundle.js:37954:9)

I am running the react app using "npm start" from within the dockerized codeserver.
lscr.io/linuxserver/code-server:latest
Any tipps on the above error?


PostContactsTransactionalDataImport method is incomplete

Hi,
this method
https://github.com/romanpitak/dotMailer-API-v2-PHP-client/blob/master/src/Resources/Resources.php#L492
doesn't use passed parameter, so it's always returns an error that transactional data can not be null.

Fixed in romanpitak/dotMailer-API-v2-PHP-client@0e45fc71306cb017bbe0dcd972549cd95201ef96


fix: fix severity lookup in Qualys parser

Description
Fixes a bug in the Qualys parser where the severity lookup was not correctly handling integer values. This caused incorrect severity values to be returned. The fix updates the severity lookup to convert the severity value to an integer before performing the lookup.
Test results
Ideally you extend the test suite in tests/ and dojo/unittests to cover the changed in this PR.
Alternatively, describe what you have and haven't tested.
Documentation
Please update any documentation when needed in the documentation folder)
Checklist
This checklist is for your information.

[X] Make sure to rebase your PR against the very latest dev.
[X] Features/Changes should be submitted against the dev.
[X] Bugfixes should be submitted against the bugfix branch.
[X] Give a meaningful name to your PR, as it may end up being used in the release notes.
[X] Your code is flake8 compliant.
[X] Your code is python 3.11 compliant.
[X] If this is a new feature and not a bug fix, you've included the proper documentation in the docs at https://github.com/DefectDojo/django-DefectDojo/tree/dev/docs as part of this PR.
[X] Model changes must include the necessary migrations in the dojo/db_migrations folder.
[X] Add applicable tests to the unit tests.
[X] Add the proper label to categorize your PR.

Extra information
Please clear everything below when submitting your pull request, it's here purely for your information.
Moderators: Labels currently accepted for PRs:

Import Scans (for new scanners/importers)
enhancement
performance
feature
bugfix
maintenance (a.k.a chores)
dependencies
New Migration (when the PR introduces a DB migration)
settings_changes (when the PR introduces changes or new settings in settings.dist.py)

Contributors: Git Tips
Rebase on dev branch
If the dev branch has changed since you started working on it, please rebase your work after the current dev.
On your working branch mybranch:
git rebase dev mybranch

In case of conflict:
 git mergetool
 git rebase --continue

When everything's fine on your local branch, force push to your myOrigin remote:
git push myOrigin --force-with-lease

To cancel everything:
git rebase --abort

Squashing commits
git rebase -i origin/dev

Replace pick by fixup on the commits you want squashed out
Replace pick by reword on the first commit if you want to change the commit message
Save the file and quit your editor

Force push to your myOrigin remote:
git push myOrigin --force-with-lease

Would you mind adding a unit test here with an example file that triggers the bug you mention, in order to validate this fix and ensure we don't have a regression?

Would you mind adding a unit test here with an example file that triggers the bug you mention, in order to validate this fix and ensure we don't have a regression?

Should I close this PR and open a new one with the UNITTEST?

Would you mind adding a unit test here with an example file that triggers the bug you mention, in order to validate this fix and ensure we don't have a regression?

Should I close this PR and open a new one with the UNITTEST?

You can push a new commit to your branch with the unit test and it will update this PR automatically. You're welcome to create a new PR if you want, but it's not strictly necessary.

@mtesauro
I added the unit test.
Additional changes follow the logic of https://github.com/DefectDojo/django-DefectDojo/issues/6248#issuecomment-1164293652. Pull severity from 'SEVERITY' field in source XML, if not available, try to extract it from CVSS_VALUE field (logging a warning).

@mtesauro I added the unit test.
Additional changes follow the logic of #6248 (comment). Pull severity from 'SEVERITY' field in source XML, if not available, try to extract it from CVSS_VALUE field, if neither are available: default to Informational and log a warning. Before this PR: it was the other way around: first 'CVSS_VALUE' then 'SEVERITY'.

@nv-pipo
This makes sense to me - be warned we've see 2 instances where the CVSS score from a vendor's tool does not match the "word" severity reported in the same scan export e.g. Report says "High" but the CVSS score is a "Low" when you calculate it from the CVSS vector.
This is the reason we generally use the 'word' severity and then fall back to the CVSS score if it's not available.
You'd like to think vendors could make their 'word' score match CVSS but :shrug:

@mtesauro I added the unit test.
Additional changes follow the logic of #6248 (comment). Pull severity from 'SEVERITY' field in source XML, if not available, try to extract it from CVSS_VALUE field, if neither are available: default to Informational and log a warning. Before this PR: it was the other way around: first 'CVSS_VALUE' then 'SEVERITY'.

@nv-pipo This makes sense to me - be warned we've see 2 instances where the CVSS score from a vendor's tool does not match the "word" severity reported in the same scan export e.g. Report says "High" but the CVSS score is a "Low" when you calculate it from the CVSS vector. This is the reason we generally use the 'word' severity and then fall back to the CVSS score if it's not available.
You'd like to think vendors could make their 'word' score match CVSS but 🤷

It may be a case where they get CVSS info from NVD or similar but then decide based on their own analysis that the implied severity is wrong. In that case, I expect they probably don't update the CVSS score/vector.

@Maffooch and @mtesauro,
As requested, I've updated the code to remove the fallback to cvss_value. (code looks cleaner, simpler now 👍 )
There seem to be some build problems, but I doubt it has anything to do with this PR (ran the Qualys unit_tests locally without problems). Please advise how to fix.
Thanks!

@nv-pipo

There seem to be some build problems, but I doubt it has anything to do with this PR (ran the Qualys unit_tests locally without problems). Please advise how to fix. Thanks!

There was a commit in Dev that broke the tests that require building a container. The best way to fix is to rebase against what's currently in the Dev branch (the fix to what broke tests has been merged already)


Not anymore on Arch User Repository

Hello,
I noticed that the AUR package (https://aur.archlinux.org/packages/clipmenu/) is not available anymore.
If I'm correct, @cdown was owner, was it done on purpose ? May I bring it back to life ?

clipnotify is gone as well

It appears to have moved to to [community]

hhttps://www.archlinux.org/packages/community/any/clipmenu/
https://www.archlinux.org/packages/community/x86_64/clipnotify/

Guess it's been blessed by the powers that be. Nice work Chris!

Oh ok thanks, that's great :+1:
Good job !

You can thank @foxxx0 :-) Thanks Thore!


Possible inconsistent behavior between co().then(_, onRejected) and co().catch()

What would be the difference between using the error handler from co(generator).then(...) as shown here:
co(function* () {
...
}).then(undefined, (err) => console.error(err.stack))

and using catch?
co(function *(){
}).catch(onerror);

I read here that

The catch() method returns a Promise and deals with rejected cases only. It behaves the same as calling Promise.prototype.then(undefined, onRejected).

While I do have some runtime errors caught by co(app).catch(here), errors that I throw myself are only caught if I use the onRejected handler as in the first example above.

Invalid. I had a bug in my code.


Extract modelmesh part in helm chart

What this PR does / why we need it:

For serverless installation without modelmesh

Which issue(s) this PR fixes :
x
Type of changes
x
Feature/Issue validation/testing:
helm template kserve ./charts/kserve-resources \
  -n kserve \
  --set kserve.modelmesh.enabled=false \
  > kserve-helm.yaml

kserve-helm.yaml and kserve.yaml  should be approximately the same without CRDs.
Special notes for your reviewer:
x
Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Add kserve.modelmesh.enabled option to kserve-resources helm chart

@hhk7734 Thanks for the PR and it looks good ! just a few nits for fixing the new lines

should we make the modelmesh resources as a subchart?
that way we can enable or disable their creation via variables in values.yaml
Random example form google
Eg: https://stackoverflow.com/questions/54032974/helm-conditionally-install-subchart

@yuzisun Please review again :)

@yuzisun Please review again :)

@hhk7734 have you considered the sub chart idea @sukumargaonkar commented ? This avoids all the if checks

@yuzisun Please review again :)

@hhk7734 have you considered the sub chart idea @sukumargaonkar commented ? This avoids all the if checks

If this is turned into a subchart, version control for the modelmesh chart should also be considered. I am wondering if the kserve organization plans to manage this.

@yuzisun Please review again :)

@hhk7734 have you considered the sub chart idea @sukumargaonkar commented ? This avoids all the if checks

If this is turned into a subchart, version control for the modelmesh chart should also be considered. I am wondering if the kserve organization plans to manage this.

@hhk7734 modelmesh is always released together with kserve, we do not have separate cadence for modelmesh.

@yuzisun If you want to apply subchart, I'll make the following changes. Do you want to use subchart?
CC. @sukumargaonkar
Directory layout
charts/
└── kserve-resources/
    ├── Chart.yaml
    ├── charts/
    │   └── modelmesh/
    │       ├── Chart.yaml
    │       └── templates/
    │           ├── clusterrole.yaml
    │           ├── clusterrolebinding.yaml
    │           ├── clusterservingruntimes.yaml
    │           ├── configmap.yaml
    │           ├── deployment.yaml
    │           ├── networkpolicy.yaml
    │           ├── role.yaml
    │           ├── rolebinding.yaml
    │           └── serviceaccount.yaml
    ├── templates/
    │   ├── certificate.yaml
    │   ├── clusterrole.yaml
    │   ├── clusterrolebinding.yaml
    │   ├── clusterservingruntimes.yaml
    │   ├── configmap.yaml
    │   ├── deployment.yaml
    │   ├── role.yaml
    │   ├── rolebinding.yaml
    │   ├── service.yaml
    │   ├── serviceaccount.yaml
    │   └── webhookconfiguration.yaml
    └── values.yaml

Add modelmesh Chart.yaml
apiVersion: v1
name: modelmesh
version: v0.10.0
description: Helm chart for deploying kserve resources
keywords:
  - kserve
  - modelmesh
sources:
  - http://github.com/kserve/kserve

Add modelmesh dependency to kserve-resources Chart.yaml
...
dependencies:
  - name: modelmesh
    version: v0.10.0
    condition: modelmesh.enabled

Change the hierarchy of kserve-resources values.yaml
kserve:
  ...
  modelmesh:
    enabled: true
    ...
  ...

to
kserve:
  ...
modelmesh:
  enabled: true
  ...

Change the modemesh values
        image: {{ .Values.kserve.modelmesh.controller.image }}:{{ .Values.kserve.modelmesh.controller.tag }}

to
        image: {{ .Values.controller.image }}:{{ .Values.controller.tag }}

@yuzisun
How about reflecting this PR without modification first for backwards compatibility, and later if a subchart is needed?

@yuzisun
Reflected changes in the master chart.

Thanks @hhk7734 !
/lgtm
/approve


ISPN-14675 PFADD

https://issues.redhat.com/browse/ISPN-14675
This adds the PFADD command and the whole HyperLogLog structure. The implementation is based primarily on Redis and on https://github.com/aggregateknowledge/java-hll. Just following the C implementation was not enough in some instances.
The Redis implementation is based a lot on https://arxiv.org/pdf/1702.01284.pdf. This implementation is doing the same.
A small script to generate some data with 10 billion unique elements and calculate the relative error:
   public static void main(String[] args) throws Exception {
      HyperLogLog hll = new HyperLogLog();

      long maximum = (long) Math.pow(10, 10);
      try (Writer relativeErrorWriter = new BufferedWriter(new OutputStreamWriter(new FileOutputStream("/home/jbolina/hll-complete.txt"), StandardCharsets.UTF_8))) {
         for (long i = 1; i <= maximum; i++) {
            hll.add(("data-" + i).getBytes(StandardCharsets.US_ASCII));
            if (i <= 1000 || i % 250 == 0) {
               long card = hll.cardinality();
               double re = ((double) (card - i)) / i;
               relativeErrorWriter.write(String.format("%d, %.10f\n", i, re));
            }
         }
      }
   }

This writes all the points for a real cardinality less than 1000 and then at every 250 insertions (otherwise the data file is too big). Interpolating the relative error with Gnuplot:

The red line is when we transition from explicitly counting the values to the compact representation. Notice the error estimate remains pretty small. Something around +-0.025 to the 10 billion verified.

There are already a few runs reporting failures on the Hot Rod server tests. Looking into it, probably I am using IDs for protostream that are already in use.

The issue is coming from the native tests. Updated, let's see how it goes.

@jabolina tests passed, squash commits and let's merge here

Seems good to go.

Integrated into main, thanks @jabolina !


⚠ Bofrost.fr has degraded performance

In 0f83456, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1330 ms

Resolved: Bofrost.fr performance has improved in c5b3170 after 7 minutes.


Can i upload Video?

I really love this library, i've used this library for my company's project. I'm indeed sorry for opening new issue just for asking can i upload video. Thanks you all.

You can upload MP4 videos only. Also they have to be smaller than the upload limit (pictshare shows the upload image in the upload form)
If you have a video other than mp4, you have to convert it first


Accessing strings (for example in keys or values) without having the lib create a copy of it.

I am ok with just having a "const char *" of the string.
I have tried several times an I haven;t had any luck, all I get are copies.

How about using get_ptr() to get a pointer to the stored object?

Would that not create a copy of an std::string when we try to use it as a string?

Correct. The following code is one way to test it (live example):
Note: Per documentation, writing data to the returned pointer is discouraged. Take following code just as a demonstration.
#include "json.hpp"
#include <iostream>

int main() {

  nlohmann::json j;
  j["key"] = "hello";

  auto p1 = j["key"].get_ptr<std::string *>();
  auto p2 = j["key"].get_ptr<std::string *>();

  std::cout << "Addresses: " << p1 << "," << p2 << std::endl;

  std::cout << "Original:  " << j["key"].get<std::string>() << "," << *p1 << ","
            << *p2 << std::endl;

  *p1 += "1";
  std::cout << "Change p1: " << j["key"].get<std::string>() << "," << *p1 << ","
            << *p2 << std::endl;

  *p2 += "2";
  std::cout << "Change p2: " << j["key"].get<std::string>() << "," << *p1 << ","
            << *p2 << std::endl;

  return 0;
}

Typical output:
Addresses: 0xe37b20,0xe37b20
Original:  hello,hello,hello
Change p1: hello1,hello1,hello1
Change p2: hello12,hello12,hello12

Hmm, that works for me! Thanks
Not sure about the OP, their needs might be different.

@nlohmann any chance that we could have const string &myvar =  json["myvar"] 'to not return a copy as the default behaviour? This would speed up things a lot :)

json::operator[] returns a (const) reference of type json&. From there, you can use get, get_ref or get_ptr to access the value for various conversions.

why not make an operator overload to get json::operator[] return a std::string?

For several reasons:

The type of the string is templated. It is std::string by default, but it could be another type. That's why the get_ptr and get_ref functions are do delicate as they allow you to dig into the JSON type which may lead to problems.
What happens if you write std::string& mystring = myjson["foo"], but myjson["foo"] is an integer?

Alright, thanks for the explanation and for such a good lib :)
On Sun, Feb 9, 2020 at 10:15 AM Niels Lohmann<EMAIL_ADDRESS>wrote:

For several reasons:

The type of the string is templated. It is std::string by default,
but it could be another type. That's why the get_ptr and get_ref
functions are do delicate as they allow you to dig into the JSON type which
may lead to problems.
What happens if you write std::string& mystring = myjson["foo"], but
myjson["foo"] is an integer?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nlohmann/json/issues/1916?email_source=notifications&email_token=ABHVYEZWJUNTAOB4OFA42P3RB7CRRA5CNFSM4KNEETO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELGG3WY#issuecomment-583822811,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABHVYE3AWEX7X4KMHXFZBBLRB7CRRANCNFSM4KNEETOQ
.


getting syntax errors when running svn2git

Environment:
ubuntu 10.04.
git version <IP_ADDRESS>
git-svn installed
ruby 1.8.7
svn2git 2.1.1
When running the following command
 /var/lib/gems/1.8/bin/svn2git http://host/svn/myrepo

I then get the following syntax errors. What did I miss in the installation?
/usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in gem_original_require': /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:246: syntax error, unexpected $undefined, expecting ')' (SyntaxError)         run_command("git checkout \"#{branch}"\")                                                ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:253: syntax error, unexpected tIDENTIFIER, expecting kEND         run_command("git checkout svn/trunk")                         ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:253: syntax error, unexpected tSTRING_BEG, expecting kDO or '{' or '('         run_command("git checkout svn/trunk")                                             ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:254: syntax error, unexpected tIDENTIFIER, expecting kEND         run_command("git branch -D master")                         ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:254: syntax error, unexpected tIDENTIFIER, expecting kDO or '{' or '('         run_command("git branch -D master")                                          ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:255: syntax error, unexpected tIDENTIFIER, expecting kEND         run_command("git checkout -f -b master")                         ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:255: syntax error, unexpected tUMINUS, expecting kDO or '{' or '('         run_command("git checkout -f -b master")                                       ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:257: syntax error, unexpected tIDENTIFIER, expecting kEND         run_command("git checkout -f master")                         ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:257: syntax error, unexpected tIDENTIFIER, expecting kDO or '{' or '('         run_command("git checkout -f master")                                            ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:262: syntax error, unexpected tIDENTIFIER, expecting kEND       run_command("git gc")                       ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:266: syntax error, unexpected tCONSTANT, expecting kEND       log "Running command: #{cmd}"                   ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:271: syntax error, unexpected kDO_BLOCK, expecting kEND       IO.popen(cmd) do |stdout|                       ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:272: syntax error, unexpected kDO_BLOCK, expecting kEND         stdout.each do |line|                       ^ /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:273: syntax error, unexpected tIDENTIFIER, expecting kDO or '{' or '(' /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git/migration.rb:309: syntax error, unexpected kEND, expecting $end 	from /usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in require'
from /var/lib/gems/1.8/gems/svn2git-2.1.1/lib/svn2git.rb:1
from /usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in gem_original_require' 	from /usr/lib/ruby/1.8/rubygems/custom_require.rb:31:in require'
from /var/lib/gems/1.8/gems/svn2git-2.1.1/bin/svn2git:23
from /var/lib/gems/1.8/bin/svn2git:19:in `load'
from /var/lib/gems/1.8/bin/svn2git:19

I'm just starting to play with svn2git and haven't verified my migration yet, but if I change line 246 of svn2git-2.1.1/lib/svn2git/migration.rb from:
run_command("git checkout "#{branch}"")
to
run_command("git checkout "#{branch}"")
I'm at least able to proceed. This looks like a very slick program except for the minor typo. :)

Sorry, this was a massive oversight.  I just pushed 2.1.2 with the fix.


[KOGITO-384] - Add libsunec.so and cacerts to Kogito runtime native i…

…mage
Signed-off-by: Filippe Spolti<EMAIL_ADDRESS>

Looks good! Could you please test with onboarding example? The only service that needs to be deployed as native is the onboarding. The others might use JVM. The discovery mechanism will use ssl to call Kubernetes APIs.


Video conference mute information bar not visible after changing screen resolution

Microsoft PowerToys version
0.60.1
Running as admin

[X] Yes

Area(s) with issue?
Video Conference Mute
Steps to reproduce
Video conference mute has an symbol bar that shows current status. That bar can be hidden when muting is off (mic+video are on). After changing the monitors resolution (e.g. docking/undocking a laptop or switching between picture-in-picture and full monitor mode), the symbol bar is not visible - properly because old positions are used. The symbol bar will be visible again as soon as its position is changed in Power Toys settings.
✔ Expected Behavior
The position shall not only be recalculated when the settings are changed, but also when display resolution ist changed.
❌ Actual Behavior
When switching from a 4K-resolution to FullHD, the symbol bar is not visible even if muting is changed.
Other Software
No response

VCM is in maintenance mode and we will only resolve a small amount of adjustments from the core team moving forward, please see #21473.  We will accept community contributions to resolve issues


[OTHER] move all socket function in chat.jsx into chatSocket.js

What would you like to share?
The chat component
https://github.com/Dun-sin/Whisper/blob/dbec99c68f63c606647ea2cef1d458a72ae83b1b/client/src/components/Chat.jsx
The chatSocket file:
https://github.com/Dun-sin/Whisper/blob/dbec99c68f63c606647ea2cef1d458a72ae83b1b/client/src/lib/chatSocket.js

Can I work on this issue? Also I have a question, what do you want to be moved to chatSocket.js?
Only this?
	const emitTyping = useCallback((boolean) => {
		socket.timeout(5000).emit(NEW_EVENT_TYPING, { chatId: app.currentChatId, isTyping: boolean });
	}, []);

Can I work on this issue? Also I have a question, what do you want to be moved to chatSocket.js?
Only this?
	const emitTyping = useCallback((boolean) => {
		socket.timeout(5000).emit(NEW_EVENT_TYPING, { chatId: app.currentChatId, isTyping: boolean });
	}, []);

No all socket functions, meaning find all the socket emit or on methods and the functions they put as a second argument should be moved.

hey can i get tbis one

hey can i get this ?

Sure @azr-arch , thanks for wanting to contribute. Make sure to read the issue description carefully and ask if you have questions on the discord server. Follow the rules here, or your PR won't be accepted and will be closed. Good luck!

hey @Dun-sin, do you know how to fix this
C:\Users\Desktop\Github Repositories\Whisper\server\utils\lib.js:391
  message = CryptoJS.AES.encrypt(message, secretKey).toString();
                                          ^

ReferenceError: secretKey is not define

?

Can you track where secretKey is coming from?

hey @Dun-sin, do you know how to fix this
C:\Users\Desktop\Github Repositories\Whisper\server\utils\lib.js:391
  message = CryptoJS.AES.encrypt(message, secretKey).toString();
                                          ^

ReferenceError: secretKey is not define

?

Can you track where secretKey is coming from?

the whole file doesn't have any imports or variables for secretKey

hey @Dun-sin, do you know how to fix this
C:\Users\Desktop\Github Repositories\Whisper\server\utils\lib.js:391
  message = CryptoJS.AES.encrypt(message, secretKey).toString();
                                          ^

ReferenceError: secretKey is not define

?

Can you track where secretKey is coming from?

the whole file doesn't have any imports or variables for secretKey

is this blocking your PR? if it is, move the other socket functions and leave the one for editing

there are already some bugs with the current version, like when you try to delete or copy the message, error occurs. so how do i record

hey @Dun-sin, do you know how to fix this
C:\Users\Desktop\Github Repositories\Whisper\server\utils\lib.js:391
  message = CryptoJS.AES.encrypt(message, secretKey).toString();
                                          ^

ReferenceError: secretKey is not define

?

Can you track where secretKey is coming from?

the whole file doesn't have any imports or variables for secretKey

is this blocking your PR? if it is, move the other socket functions and leave the one for editing

its not blocking, i'll it for you.
thanks for helping

there are already some bugs with the current version, like when you try to delete or copy the message, error occurs. so how do i record

hey @Dun-sin, do you know how to fix this
C:\Users\Desktop\Github Repositories\Whisper\server\utils\lib.js:391
  message = CryptoJS.AES.encrypt(message, secretKey).toString();
                                          ^

ReferenceError: secretKey is not define

?

Can you track where secretKey is coming from?

the whole file doesn't have any imports or variables for secretKey

is this blocking your PR? if it is, move the other socket functions and leave the one for editing

its not blocking, i'll it for you.
thanks for helping

Don't worry about recording🙌🏾

message copy, edit and delete are not working, look into them too


Support context in odo push commands

Signed-off-by: John Collier<EMAIL_ADDRESS>What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind feature
/area devfile
What does does this PR do / why we need it:
This PR adds support for the --context flag to odo push commands. Before this PR, --context didn't do anything, and the devfile and env info file would only be read from the current directory odo is run from.
I've also added an integration test case for the --context flag.
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/2744
How to test changes / Special notes to the reviewer:

Run integration tests
Manual test:

Create a devfile component
Change to a different directory
Run odo push --context <dir-containing-component>

you will also need to change the sourcePath for watch too
[mrinaldas@localhost ~]$ odo watch --context /home/mrinaldas/che-nodejs
I0507 20:56:48.418615   24957 cert_rotation.go:137] Starting client certificate rotation controller
/home/mrinaldas    <-------------------------- here
 ✗  error watching source path /home/mrinaldas: open /home/mrinaldas/openshift.local.clusterup/etcd/member: permission denied

Putting a log statement I was able to verify that the context was not changed while running watch and thus it failed. Push works fine though.

@mik-dass Ah, you're right! Good catch about odo watch, not sure why I didn't see that before.
Easy fix, I'll push a change up, thanks!

@mik-dass Fixed!

/retest

/approve


Usage of a react-autocomplete inside of a container with overflow:scroll

Using the autocomplete component inside of a container with overflow:scroll produces undesired behaviour: ideally the popup should just go outside of the container but instead the container will get scrollbar and the popup is initially hidden (or at least partially hiddden).
This is not really a problem specific to react-autocomplete but a more general problem with absolute positioned elements inside of an overflow container: http://wiki.orbeon.com/forms/doc/contributor-guide/browser#TOC-Absolutely-positioned-box-inside-a-box-with-overflow:-auto-or-hidden
However for (as a react novice) I find it hard to find a react-like solution. Possible solutions:
Position the autocomplete suggestions with position fixed instead of absolute
This fixes the scrollbar issue, however the container needs to be "manually" positioned. Doesn't feel very "reacty".
Position the autocomplete suggestions container with position absolute instead of relative
Again, this fixes the scrollbar issue. But now the parent needs to be "manually" positioned.
Render the popup not in the dom position of the autocomplete parent, but to a parent position (e.g. the body)
In the past (pre react) I've worked with a similar component for bootstrap (bootstrap-select). With this component it was possible to give the popup a specific parent element selector.
This is not an option with react-autocomplete and I wonder if this would even be possible in react?

Render the popup not in the dom position of the autocomplete parent, but to a parent position (e.g. the body)

There is a way of achieving this in React. The way it's usually done is to create a new React root under document.body, then render into that. This is what react-bootstrap does with most of their popups (dropdowns, overlays, etc). Read the source code of OverlayTrigger if you're curious as to how it's done.
As for how this all works with Autcomplete: While it would be nice to offer this feature, it's not something we currently have on the roadmap. At the moment you can solve most situations by using positioning and z-index.
I'm closing this for now, but please let us know if you have a strong case for this feature to be included.


Step Increment in the BinPacking Environment

Hi,
In the BinPacking environment, the step_count parameter is not incremented in the Step function.

Thanks! We'll get that fixed in an update soon!

Fixed!


Make available on Hombrew

After I seen astronomer on HN I put together this homebrew tap to ease installation on OSX: https://github.com/dkanejs/homebrew-astronomer
It would be cool to get this into the official Homebrew itself or have you as the maintainer of the tap under your own GitHub namespace, this way you can also update the formulae with each release 👍
What do you think?

I'm fine with you being the maintainer of the tap if you're okay with it, I would gladly document it in the readme, but if you want I can do one as well and maintain it 👍
What sounds better for you? :)

I'm happy to maintain.
If that changes (or if the community feels different in the future) for whatever reason we can migrate it over, etc 👍
It's a quick thing anyway 😄

I will document it then, thanks :)


Use provider for shared version_data

Use provider instead shared memory directly.

I'll check out the behaviour on Windows in the meantime.

I'm facing some issues running it on Windows (but this is not limited to your changes, I'm afraid). Could you check it out with #192 please?

@jfclere httpd 2.4.59 is officially out (incl. apache lounge), could you please rebase? I've updated the PR mentioned above accordingly.


Add ConfigurationExtension

Current status
We have a lot of cli parameters, but no way to get them configured directly in the behat.yml file (and to configure different options for different profile).
Proposed evolution
This PR propose to add a configuration key in the behat.yml that can handle a subset of the cli parameters (for now only stop_on_failure).
This way we can configure our behat.yml file like this:
default:
  configuration:
    stop_on_failure: true

ci:
  configuration:
    stop_on_failure: false

We could add more configuration option in the future (--strict or --snippet-xxx for example).
Fixes #1488

@jdeniau how does this interact with the parameter sent on the command line? Which one takes precedence if both the command line parameter and the config file value are set to different values?

@carlos-granados good question : I didn't think of that.
The way it's coded, it's a OR (if one is set to true, then it will stop on failure. As a matter of fact, the listeners will be registered twice).
We might want to change that to let the cli have the last word, but in that case we may want to implement --no-stop-on-failure

@carlos-granados good question : I didn't think of that. The way it's coded, it's a OR (if one is set to true, then it will stop on failure. As a matter of fact, the listeners will be registered twice).
We might want to change that to let the cli have the last word, but in that case we may want to implement --no-stop-on-failure

Yes, I would like to make sure that there is a clear priority so you may need to work on your code. Don't forget to add new tests that check this

@carlos-granados no problem to improve that.
Are you OK on the global idea of the configuration key in behat.yml to be sure that I do not develop something that is not related to behat's way of think?

@carlos-granados no problem to improve that. Are you OK on the global idea of the configuration key in behat.yml to be sure that I do not develop something that is not related to behat's way of think?

I believe it is a good idea but would also like to hear the opinion of @acoulton so please wait until we hear from him

Ah, and I would probably use config: instead of configuration:, that seems to be the term used elsewhere in Behat

I think config: / configuration: might be a bit too generic - maybe command_options: or cli_options: to make the relationship clear? And call it DefaultCommandOptionsExtension? Just a thought...

In my case I find config: to be clearer: what you are defining is the configuration. The fact that this can also be defined on the command line should not direct the naming in my opinion

symfony/console 5.3 introduced support for negatable options for flag options, adding automatically the ability to use --no-foo to set the foo flag to false even if its default is true (or null). I think this feature should be used, to preserve the ability for the CLI flags to disable some features again.
This will require dropping support for Symfony 4.4. I think this is fine to do for a next minor version of Behat (maybe releasing first the current merged changes), given that Symfony 4.4 is EOL since 11 months.

Happy with all your arguments. I didn't know about auto-negatable-flags, in that case perfect. Agree with dropping symfony 4.4 in a minor - and we have released up to date so that can happen soon.
Carry on @jdeniau 😀

well, negatable flags still require an opt-in when defining the option, but it is quite easy: https://symfony.com/blog/new-in-symfony-5-3-negatable-command-options

@acoulton @carlos-granados PR is updated


feat: Update Anon Aadhaar circuit setup

This adds the AA circuits with just Sha256 + RSA and no nullifiers with 917,344 constraints.
Changes:

Stores input value in JSON to have a lighter middleware
Adds a new setup of AA
Updates hardcoded bindings to use AA ones
Add a new view for testing

I don't think it's necessary to merge this one, I'll do another one with the latest version of the circuits.


Add tutorial for solving quadratic equations

PR features
Adds tutorial for solving quadratic equations. I don't know if I fit it to the right audience though.
Evaluation for math education
I was looking for a simple graphing solution to embed. An embedded version of Wolfram|Alpha would've been the dream. Using Geogebra and taking screenshots would probably work if you have a place to host the photos (probably in the repo?).
It might be possible to embed Geogebra with an iframe https://wiki.geogebra.org/en/Tutorial:Creating_HTML5_documents_with_GeoGebraWeb
Can't seem to find the Embed button though. Interactive graphs are nice though.

Managed to get Geogebra embeds "working" - but the user experience is kinda bad.

Thank you! This is great! 👍


Wei/slow on turn

slow on turn, and add display for target speed.
read speed limit from map box and display on UI
use speed limit in planner. set cruise speed using speed limit if speed limit is valid.

I'm changing merge base to be the default branch sf2la.


some minor fixes to paths

I made some super minor fixes to how you deal with paths - mainly consistently using paste as opposed to file.path, and fixed a path that wasn't constructed correctly in the later sections.

Thanks @jeanetteclark!


Fix lookups of methods

Methods currently start lookup at the current object, then work upwards to the metatable.
Change this to do a single lookup in the metatable, then fail. This fixes many inconsistencies we currently have with method lookups in YASL.

Fixed in v0.12.0


Chrome on Android reloads the parent page, fails authentication with facebook.

When trying to leverage facebook authentication in chrome on Android, the facebook login page opens (as new tab) and my app looses focus. Due to this the chrome seems to be unloading the app from page.
So when you complete the authentication in facebook and try to get your app back in focus it refreshes and looses the javascript state.
I came across a blog post http://www.seanshadmand.com/2015/03/06/facebook-js-login-on-chrome-ios-workaround/ which talks a possible solution for this problem but not the exact scenario I am raising
Which explains a way to overcome this problem.
It does not seem to be happening on phones with better memory and processing power but on the basic android phones.

@moha297 this does not seem an issue directly related to this Ember add-on. If so, I would close it. If you, instead, think that it is something related to this project, please provide an example so that we can work on that case.


unit tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b858ae5) 53.66% compared to head (bc8e974) 57.02%.
Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   53.66%   57.02%   +3.35%
==========================================
  Files           7        7
  Lines         477      477
==========================================
+ Hits          256      272      +16
+ Misses        180      161      -19
- Partials       41       44       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


DID-SDID format subtly different than RFC 8331

flow_sdianc_data.json has the regex pattern for both DID and SDID as ^0x[0-9a-fA-F]{2}$. There are no examples in the spec repo, but it is clear this requires exactly two hex digits but accepts upper- and lower-case.
On the other hand, the representation in SDP files is governed by RFC 8331 which uses the ABNF:
TwoHex = "0x" 1*2(HEXDIG)
DidSdid = "DID_SDID={" TwoHex "," TwoHex "}"

Where HEXDIG is defined in RFC 2234 by:
DIGIT          =  %x30-39
                       ; 0-9
HEXDIG         =  DIGIT / "A" / "B" / "C" / "D" / "E" / "F"

Therefore, though the examples given in RFC 8331 are like "DID_SDID={0x61,0x02};DID_SDID={0x41,0x05}" which suggests two hex digits is good form, the TwoHex production allows a single hex digit, but requires uppercase for A-F.

This makes the values "0x41", "0x0c" valid in IS-04 but "{0x41,0x0c}" not valid in SDP, while "{0x41,0xC}" is valid in SDP but "0x41", "0xC" is not valid in IS-04.
This is probably worth at least a little note somewhere.

Something for a future INFO- implementation guide, assuming that has a section on SDP attributes?


Roll Engine from 679a7adb3596 to 3920f41dcd29 (1 revision)

https://github.com/flutter/engine/compare/679a7adb3596...3920f41dcd29
2021-07-03<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from oiyYFMOd3... to chKeQc7Mz... (flutter/engine#27157)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from oiyYFMOd30Op to chKeQc7Mz3t2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Add the option to close the popup on background click

I think some users expect an exit intent popup to close when the background is clicked and I believe it is a useful option to have.

Closing this PR and I will re-create it because I accidentally included more changes than I intended to.


Marker.bindPopup() throws exception if passed invalid argument fix

Error throwing was added for this issue:
https://github.com/Leaflet/Leaflet/issues/8029
Marker.bindPopup() expects 'string', 'function', 'HTMLElement' or 'Popup'. Otherwise, the error is thrown.
According to the documentation:
// @method bindPopup(content: String|HTMLElement|Function|Popup, options?: Popup options): this
// Binds a popup to the layer with the passed content and sets up the
// necessary event listeners. If a Function is passed it will receive
// the layer as the first argument and should return a String or HTMLElement.

We intentionally avoid excessive validation of arguments so that the code doesn't become too verbose. The benefit of this is too low for the added complexity if we start applying this consistently all over the codebase.

If you want to ensure these kind of exceptions do not happen in your application you can use TypeScript to get compile-time guarantees about the correctness of your code.