SGD decay cannot be a tf.Variable

System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Keras .devcontainer Docker image
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v1.12.1-70295-gce17c4f9c3d 2.9.0-dev20220121
Python version: 3.9.10
Bazel version (if compiling from source): 5.0.0
GPU model and memory: None
Exact command to reproduce: python repro.py

Describe the problem.
Keras does not support the use of a tf.Variable as the decay parameter for SGD, whereas the other parameters do. Supporting the use of tf.Variable would increase consistency and be useful in hyperparameter searching.
Describe the current behavior.

    OperatorNotAllowedInGraphError: Using a symbolic `tf.Tensor` as a Python `bool` is not allowed: AutoGraph did convert this function. This might indicate you are trying to use an unsupported feature.

Describe the expected behavior.
tf.Variable(x) can be used in place of the Python literal x.
Contributing.

Do you want to contribute a PR? (yes/no): yes
If yes, please read this page for instructions
Briefly describe your candidate solution(if contributing): Rewrite the logic in __decayed_lr to use tf.cond and tf.greater to allow a tf.Tensor to be used as the decay parameter.

Standalone code to reproduce the issue.
import tensorflow as tf
from tensorflow.keras.layers import Input, Flatten, Dense
from tensorflow.keras.models import Model
from tensorflow.keras.optimizers import SGD

def model_():
    x = Input([32, 32, 3])
    y = Flatten()(x)
    y = Dense(10, activation='softmax')(y)
    return Model([x], [y])

(x_train, y_train), (x_test, y_test) = tf.keras.datasets.cifar10.load_data()
y_train = tf.keras.utils.to_categorical(y_train, 10)

model_def_ = model_()
ds = tf.data.Dataset.from_tensor_slices((x_train, y_train))
ds = ds.batch(2, drop_remainder=True)

model_def_.compile(optimizer=SGD(learning_rate=1e-05, momentum=0.99, decay=tf.Variable(0.1)), loss='categorical_crossentropy')
model_def_.fit(ds, steps_per_epoch=50, epochs=2)

Source code / logs.
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

@sachinprasadhs Was able to reproduce the issue in TF v2.7 and tf nightly please find the gist here. Thanks!


If my Heart Had Wings [PCSG00357]

Game summary

Game name: Kono Oozora ni, Tsubasa o Hirogete
Game serial: PCSG00357

Vita3K summary

Version: 0.01
Build number: 404
Commit hash: https://github.com/vita3k/vita3k/commit/d4cd595

Test environment summary

Tested by: waterflame
OS: Windows 7
CPU: Intel i7-2600
GPU: AMD Radeon HD 6700 Series
RAM: 8 GB

Issues
Softlocks at sceKernelSetTimerTimeWide. No noticeable regressions against 328-https://github.com/vita3k/vita3k/commit/6525c1c
Screenshots

Log
vita3k-404.log
Recommended labels

Softlock

Vita3K summary

Version: v0.1
Build number: 571-70599d3
Commit hash:  https://github.com/Vita3K/Vita3K/commit/70599d3

IfMyHeartHadWings.log

Vita3K summary

Version: v0.1
Build number: 1315
Commit hash: https://github.com/vita3k/vita3k/commit/5b070aac

- Takes a bit, but boots to menu, and then you can boot in-game
- Seems to run slower in-game(it certainly loads slower)
- Hitting triangle to open backlog... backlog flashes in and out, hitting X to leave results in black screen but you're still ingame as you can advance text(It prints in console everytime you advance text... apparently there are 66109 lines of text to advance through :p)
- Apparently this game is all about waiting... the render is back, can see the game again.
- Hitting sqaure brings up the menu
- There's some pretty flashy backgrounds sometimes that I don't think are suppose to be black and white flashes (or over backgrounds)... I think it's probably a glitched transition of sorts.
vita3k.log

App summary

App name: If my Heart Had Wings
App serial: PCSG00357
App version: 1.00

Vita3K summary

Version: v0.1.6
Build number: 3047
Commit hash: https://github.com/vita3k/vita3k/commit/9258811b
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: nishinji
OS: Windows 10
CPU: AMD
GPU: NVIDIA
RAM: 32 GB

Issues
All loading is slow.
Screenshots

Log
PCSG00357 - [この大空に、翼をひろげて CRUISE SIGN].log
Recommended labels
slow
Ingame +

I think its playable as of https://github.com/Vita3K/Vita3K/commit/e1560db6de94aeee22e43724b98981a1e6071a93, i only noticed a slight graphical bug while using fast-fowarding the scenes (see in 4th screenshot).
Screenshots

Log
vita3k.log
Recommended Labels

Playable
graphical bug

sometime freeze (maybe my cpu is too fast)

vita3k.log


Return Validation Messages When Exception Occurs In Handler

Currently, when an exception occurs, the data/subject is removed from the response and replaced with a generic error message; this was done to prevent handler processing data from returning to the caller; However, in some projects, we are noticing the use of exceptions as a means to stop handler processing. This is nice, but the problem with utilizing exceptions, means data such as IValidation validators are also removed which in some cases are needed.
When exceptions occur, IValidation should be added to the response for the caller to display.

So what's the design plan for this.
It seems trivial to add the messages from IValidate into result.Messages.
I think that should suffice.
This should probably happen, exception thrown or otherwise.

Yes, the IValidation messages would simply be added in the exception case.
We'll see about warning message :)

So this isn't as straight forward as it looks...
the ICommand or ICommandAsync isn't privy to the concept of a Message; this is the sole responsibiliyt of the IValidation classes which populate the IResult object (e.g. this is populated by handler.InvokeAsync() and more specifically, the ValidateAsync() method).
the question becomes, how do we get validation messages from commands onto the IResult when a command was never designed to understand what a validation Message is?

Err, can't we just save every output of IValidate.Mesaage into a local list
and add to IResult when everything is done?
On Tue, 13 Jul 2021, 22:51 Diran Ogunlana, @.***> wrote:

So this isn't as straight forward as it looks...
the ICommand or ICommandAsync isn't privy to the concept of a Message;
this is the sole responsibiliyt of the IValidation classes which populate
the IResult object (e.g. this is populated by handler.InvokeAsync() and
more specifically, the ValidateAsync() method).
the question becomes, how do we get validation messages from commands onto
the IResult when a command was never designed to understand what a
validation Message is?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mrogunlana/Panama.Core/issues/11#issuecomment-879426772,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHDNOOYEAM4ATPY6LV6FK2LTXSYOVANCNFSM5AJSM3FA
.

I think the main reason why this ticket was created was to pass validation messages from nested handlers onto their parent handler via command.
one non-pretty way to do this is to separate the validation stack from the command stack in nested handler scenarios e.g.:
var validations = await new Handler(ServiceLocator.Current)
	.Add(model)
	.Validate<ValidateModelScenario1>()
	.Validate<ValidateModelScenario2>()
	.InvokeAsync();

if (!validations.Success)
	return validations;

var commands = await new Handler(ServiceLocator.Current)
	.Add(model)
	.Command<GetFoo>()
	.Command<SaveBar>()
	.InvokeAsync();

the other way to pseudo accomplish this would be to add the data context to the exception IResult where the caller could IResult.KvpGet<string>("ValidationMessages")

Err, can't we just save every output of IValidate.Mesaage into a local list and add to IResult when everything is done?
…
On Tue, 13 Jul 2021, 22:51 Diran Ogunlana, @.***> wrote: So this isn't as straight forward as it looks... the ICommand or ICommandAsync isn't privy to the concept of a Message; this is the sole responsibiliyt of the IValidation classes which populate the IResult object (e.g. this is populated by handler.InvokeAsync() and more specifically, the ValidateAsync() method). the question becomes, how do we get validation messages from commands onto the IResult when a command was never designed to understand what a validation Message is? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#11 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHDNOOYEAM4ATPY6LV6FK2LTXSYOVANCNFSM5AJSM3FA .

so the scenario is this:
command A has a handler and/or a third-party request that fails but returns some reason(s) why it fails. the stipulation in command A is that if the handler and/or other request fails, then the command A stops its handler from processing by throwing an exception.
the caller of command A wants its handler to return these "reasons" in order to show some "friendly" message as to why the processing of their request failed.
now let's look at what a command is designed to do:

atomically execute a business rule on a payload and stop processing if an exception occurs.

now we could always add custom exception types like ValidationException where it would either except a string  or IEnumerable<string> that could get returned the caller...

This (https://github.com/mrogunlana/Panama.Core/issues/11#issuecomment-879429863) will be cumbersome, for now at least with the way iak.data is structured.
We'd have to expose the validations as grpc service calls

I'm veering towards this solution https://github.com/mrogunlana/Panama.Core/issues/11#issuecomment-879431240

I think I like the ValidationException route because this way we can cleanly pass validation messages and stop processing in one go...

I'll go ahead and add the data context along with ValidationException as I think the data context when the handler stops processing may be useful in other scenarios

It sure can. Stuff like logging downstream

@oneEyedSunday I've added a ServiceException in v2.0.4 which is a more appropriate exception type for internal or third-party service request failures.


IE11 doesn't work - polyfill error

Hello, your demo at https://angular2-tree.readme.io/docs doesn't work.

Link works fine for me. Perhaps a transient outage?

Check this photo http://prntscr.com/in3osb

Loads fine for me in both Chrome on MacOS and Safari on iOS. What browser, version, & platform are you using? What errors appear on the browser console?

It fails to load in IE11 with an exception:

SCRIPT5022: Exception thrown and not caught
polyfills.bundle.js (804,36)

Looks like a problem with polyfills. No idea why it suddenly started happening. Maybe need to include core-js polyfills as mentioned here:
https://github.com/angular/angular-cli/issues/4128

Fixed in docs. Thanks
Using the following polyfills:
import 'core-js/es6/string';
import 'core-js/es6/object';
import 'core-js/es6/array';

I do use, but [].includes does not work in IE11, others work


ensuring we pass text objects to sqlalchemy

While testing our 0.7 release (https://github.com/ploomber/jupysql/pull/362) I realized that this would break on MySQL:
%%sql --save some_name
SELECT *
FROM some_table
-- remove top 1% observations
WHERE x > 10

The problem was that the MySQL driver would interpret % o as a query parameter, throwing an error whenever we tried to run it. The solution was to wrap every query run and pass a text object driver.execute(text(query)).
However, this problem might reappear if some contributor forgets to add the text part and runs a query with driver.execute(query).
I'm unsure what the best solution is here. At the very least, we should add this to the developer documentation, and ensure all contributors are aware of this, but it might still happen.
On the other hand, we should ensure that our integration tests cover this scenario and we could run queries across all databases to ensure a comment with the -- %something format doesn't break them. I think this is driver dependent, so other things like -- $something might break in other drivers.

this is no longer a problem since sqlalchemy forced us to pass text(query), so now everything is passed like that


Error on unhandle Promise rejection

Promise are rejected even if callback are pass to onesignal notification.
It result to reject a promise which is not handle.
https://github.com/zeyneloz/onesignal-node/blob/32d35f8dae14d052e47b66e766e2b91df1ac06e6/lib/client.js#L37-L40
[DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
The problem is developer have to add a callback and catch the error.
// send this notification to All Users except Inactive ones
myClient.sendNotification(firstNotification, function (err, httpResponse,data) {
   if (err) {
       console.log('Something went wrong…');
   } else {
       console.log(data, httpResponse.statusCode);
   }
}).catch(() => {
       console.log('Something went wrong…');
});

Thanks for opening this issue.
This problem has been fixed in v2.1.1


Error Message:
 Test method MSTestAdapter.Smoke.E2ETests.CompatTests.RunAllCompatTests threw exception:
System.InvalidOperationException: Test run ended with 1 errors.
An exception occurred while invoking executor 'executor://mstestadapter/v2': 3 arguments were passed to 'Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner::RunSingleTest'. 2 arguments were expected by this method.
Stack Trace:
    at Microsoft.MSTestV2.CLIAutomation.RunEventsHandler.EnsureSuccess() in D:\a\1\s\test\E2ETests\Automation.CLI\RunEventsHandler.cs:line 125
   at Microsoft.MSTestV2.CLIAutomation.CLITestBase.InvokeVsTestForExecution(String[] sources, String runSettings, String testCaseFilter) in D:\a\1\s\test\E2ETests\Automation.CLI\CLITestBase.cs:line 80
   at MSTestAdapter.Smoke.E2ETests.CompatTests.RunAllCompatTests() in D:\a\1\s\test\E2ETests\Smoke.E2E.Tests\CompatTests.cs:line 34

The build fails becase the api is no longer compatible with the api published by the legacy adapter that is used in the test. Investigating what is the best way to fix this.

@jayaranigarg I can't figure this out, I can't locate where exactly it fails and figure out how to better debug this. Any suggestions who could help me with this?

@nohwnd: Sorry I usually tend to miss github tags. Please hit me up on teams if you need anything I haven't responded on. This specific issue does indeed sound like we have two different versions of the adapter on either side of the app domain which is a recipe for disaster. I dont know if these smoke tests test the adapter against its latest self - It ideally should. Maybe that's the problem.

@AbhitejJohn no problem, it's stale, I ended up fixing it and we even discussed it in an internal mail thread about how to evolve the test platform interfaces. :)
The problem was that there is non-explicit dependency on an interface, and because we compile against one version of the library, but end up resolving to another version on runtime it fails when non compatible change is done to that interface. Closing this.

ah sounds good.


[MINOR] Fix string interpolation in CommandUtils.scala and KafkaDataConsumer.scala

What changes were proposed in this pull request?

This PR proposes to fix a string interpolation in CommandUtils.scala and KafkaDataConsumer.scala.
Why are the changes needed?

To fix a string interpolation bug.
Does this PR introduce any user-facing change?

Yes, the string will be correctly constructed.
How was this patch tested?

Existing tests since they were used in exception/log messages.

Test build #132242 has started for PR 30609 at commit 9e11e37.

Test build #132242 has finished for PR 30609 at commit 9e11e37.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36843/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132242/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36843/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36843/

retest this please

Test build #132260 has started for PR 30609 at commit 9e11e37.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36861/

Test build #132260 has finished for PR 30609 at commit 9e11e37.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132260/

Yep looks good. I don't know of a good way to find these in IntelliJ, but if you know of any more, go ahead and fix here.

Yep looks good. I don't know of a good way to find these in IntelliJ, but if you know of any more, go ahead and fix here.

I ran [^s]".*\$.*" regex search in IntelliJ (which gave me a sizable list to go through manually) and found one more occurrence.

Test build #132276 has started for PR 30609 at commit 6ed2c38.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36877/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36877/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36877/

Test build #132276 has finished for PR 30609 at commit 6ed2c38.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132276/

Merged to master, branch-3.1 and branch-3.0.

+1, late LGTM. Thanks!


Add method for reporting Hill chemical formula of Molecule

Is your feature request related to a problem? Please describe.
The Hill chemical formula (e.g. C6H6) is easy to calculate and a convenient hash for speeding up various similarity comparisons between molecules for force field caching.
Describe the solution you'd like
It would be useful to add a method or property Molecule.chemical_formula that would return the chemical formula for the small molecule.
Describe alternatives you've considered
Because we store the elements for each atom, we do not need to extend the toolkit wrapper API to support this---we can add it directly to the Molecule class.

I helped with something similar to this in cclib, but in the end one core developer took over. Look
here for a reasonable implementation and the corresponding tests!

Ha! I had actually hacked in a quick hill formula calculator in a previous feature sprint. I think it's mature enough to move into a more general location.

That said, I wouldn't use it for molecule comparisons -- n-propanol and isopropanol have the same Hill formula but are different molecules.


Formally addresses implementing the observed hospitalizations module

This PR contributes to the support of the hospital admissions signal. It includes the following:

Adds process.DeterministicProcess and observation.DeterministicObs to the corresponding modules. This can be used to wrap fixed quantities when needed.
Updates latent.HospitalAdmisions latent class to treat IHR, weekday effect, and p hosp as RandomVariable. Again, with the DeterministicObs these can be passed as fixed quantities (or inferred).
Adds more details to the hospitalization bit of the equations.md file, mostly pointing to the wastewater model.
Re-organizes the getting-started.qmd documentation to clarify.
latent.Infections now receives a RandomVariable for the generation interval. Before it was a fixed array.
Extends testing of model.Hospitalizations assessing that the new bits that can either do inference or reuse some of the new components (e.g., generation weekday effect).

OK, @dylanhmorris. I've included the discussed changes. More improvements will be addressed/discussed during the next sprint!

High-level comment: we need to standardize language on "Hospital admissions" versus "Hospitalizations". I prefer the former ("Hospital admissions"), because there's less chance of confusion between incidence and prevalence.

Yes, I think it is worthwhile having a single issue to standardize language across the package. And have a document to summarize all.

@dylanhmorris, this is ready for review.

Implemented requested changes in 33d9ed0 and 39c54c4. The two existing models do not have any default values now.


Lab 1 RBAC - Cloudshell use temporary

Task 1: Use PowerShell in cloudshell, tell student to select subscription and create temporary shell

You can't use a CloudShell with a 365 account (provided by lab hoster) : you need an Azure subscription.


Prisma Client error 'PrismaClientUnknownRequestError' is not handled and results in an error of undefined

The error handler is not handling the error PrismaClientUnknownRequestError. This causes the variable feathersError in the error handler to remain undefined, because no default error is set. Because of the undefined error the error cannot be processed correctly by feathers.
The error can be reproduced by, for example, sending a query that contains an integer value that is too large.
Module versions: 0.5.8
NodeJS version: 16.15.1

Fixed in 0.6.0


Possibility to have grid devtool be enabled in non-dev env

We need a major overhaul of this component.
I'm going to create a new npm package where this developer toolbar lives for easier production integration via env flag.


Content: What are Data Structures

Description
Add the article for What are Data Structures. The basic layout for the article should be:

Introduction to Data Structures
Types of Data Structures
Major Operations in Data Structures
Advantages of Data Structures

This article should be between 500-700 words in length. You should use traditional Markdown to prepare the content and the use of external images is prohibited. You can however create your own images. Run a proper Grammarly Lint check before submitting the PR.

I would like to work on this issue.

Hi @Saatvik21
Thanks for taking this up! I hope you spend some time in understanding the directory structure and where to make the PR. If you are confused, check it right here: https://github.com/TesseractCoding/NeoAlgo-Docs/tree/main/docs/data-structures
I have already created a file for you named data-structures.md. And I have added the same on the sidebar. So I guess you will have a fair understanding of how to contribute (which is much different from NeoAlgo)

Heya - Hope you are working on this ✨
We have just pushed some new features on the main so it would be great if you can pull the changes from the main branch, so that we don't run into any merge conflicts.
Second, I have some important notes for you. While adding the articles, it would be preferred if you use the mdx file extension instead of md. mdx provides us to combine Markdown + React. And we will be using it for a good reason.
First, we want to tab the codes like these:

Using standard markdown won't be beneficial for us. We can use some React Code to make it possible. Don't fret out if you don't know React. Here is an official documentation that you can refer to format the Code in separate tabs. Have a look and let me know if you are still in trouble.
Also try to keep the I/O samples same for both the Code. If it requires minor altercations, feel free to do them. Thanks!

@HarshCasper Hey, I've a doubt. Do I have to show code examples for the major operations in data structures or just the theory part of it?

@HarshCasper Hey, I've a doubt. Do I have to show code examples for the major operations in data structures or just the theory part of it?

Don't focus on any specific Data Structure. Just focus on what they are, their types, advantages and applications.


[MB-4333] Create prime-api-client command and support API endpoint for EDI generation

Description
This PR adds a support API endpoint for viewing the EDI for a given payment request, along with a prime-api-client command (support-get-payment-request-edi) to invoke it.
Reviewer Notes

I refactored the EDI generator a little so that it exposes an interface similar to other service objects.  This allowed me to generate a mock for testing purposes.
The EDI is returned as a JSON string in the returned payload.  Since there doesn't appear to be a way to have line breaks in a JSON string, you will see \n where there normally is a line break (although I show a way to below to have jq show it in "raw" mode).
To avoid confusingly formatted endpoint URLs, I used the payment request ID as the identifier for the EDI to match what we do with other support API endpoints.  Our command line utility uses payment request number, however.  We may want to get them in sync at some point.

Setup

make db_dev_e2e_populate
make server_run
Save the following payload in create_payment_request.json:{
  "body": {
    "isFinal": false,
    "moveTaskOrderID": "9c7b255c-2981-4bf8-839f-61c7458e2b4d",
    "serviceItems": [
      {
        "id": "722a6f4e-b438-4655-88c7-51609056550d"
      },
      {
        "id": "ca9aeb58-e5a9-44b0-abe8-81d233dbdebf"
      },
      {
        "id": "6431e3e2-4ee4-41b5-b226-393f9133eb6c"
      },
      {
        "id": "fd6741a5-a92c-44d5-8303-1d7f5e60afbf"
      }
    ]
  }
}

Create the payment request using the file above:go run ./cmd/prime-api-client --insecure create-payment-request --filename create_payment_request.json | jq '.id,.paymentRequestNumber'

This will show two lines -- the first has the payment request ID and the second has the payment request number.
Save the following payload to get_payment_request_edi.json, replacing <paymentRequestID> with the ID that was output from the previous step:{
  "paymentRequestID": "<paymentRequestID>"
}

Get the EDI for that payment request:go run ./cmd/prime-api-client --insecure support-get-payment-request-edi --filename get_payment_request_edi.json | jq

Given that JSON can't contain embedded newlines, we can use jq to help us show it in its raw form:go run ./cmd/prime-api-client --insecure support-get-payment-request-edi --filename get_payment_request_edi.json | jq -r '.EDI'

Locally, you can also test this against the EDI returned by our generate-payment-request-edi command below.  Replace the <paymentRequestNumber> with the payment request number output earlier (note that it's the number in this case not the ID).go run ./cmd/generate-payment-request-edi --payment-request-number <paymentRequestNumber>

The EDI should match (except possibly some timestamps in the first few lines).

Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change
Acceptance Testing for Invoicing EDI design document

Messages

:book:
:link: MB-4333

  Generated by :no_entry_sign: dangerJS against b1512bec7300d0184481de5644ce4950bde7eda0


pull request for e2e test at 12/25/2016 07:26:10

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Always read plugin manifest as UTF-8

The manifest can contain UTF-8 data and if no LANG is set (like in minimal environments), this causes the read to fail. This forces it to read the file using UTF-8 encoding.

The previous build failed, but it looks like there were 2 occurrences of File.read. Trying with the other one too.

It doesn't help to fix the EL7 tests under docker :(


Save Function Broken

Database is not updated so changes are not included in the save. Issue with the entities becoming decoupled from the manager thus no longer managed by it.

Fixed by e8a36ba4ad5e815d656d1a9172944f88dc6ff2bc


[CINFRA-181] Rest API default limits

Scope & Purpose
This pull requests sets the following default values for some of the methods:

head?limit=10
tail?limit=10
slice?start=0&end=11
poll?first=0&limit=10

Constants are used instead of hardcoded values.
Some tests were modified to ensure consistency between the V8 implementation and the HTTP client.

[x] :hankey: Bugfix (requires CHANGELOG entry)
[ ] :pizza: New feature (requires CHANGELOG entry, feature documentation and release notes)
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification
[ ] :book: CHANGELOG entry made

Testing & Verification

[ ] This change is a trivial rework / code cleanup without any test coverage.
[x] The behavior in this PR was manually tested
[x] This change is already covered by existing tests, such as replication2 tests.
[ ] This PR adds tests that were used to verify all changes:

[ ] Added new C++ Unit tests
[ ] Added new integration tests (e.g. in shell_server / shell_server_aql)
[ ] Added new resilience tests (only if the feature is impacted by failovers)

[ ] There are tests in an external testing repository:
[ ] I ensured this code runs with ASan / TSan or other static verification tools

Some inconsistencies might arise due to the way args is handled in v8-replicated-logs.cpp. It is indexed like an array, therefore arguments are expected in the same order as they are in the docs. For example the JS_Slice method expects start on args[0] and stop on args[1]. On the other hand, the HTTP API does not have this limitation. For now it is not a problem, but this felt like a good moment to point it out.


Will this be updated in the future?

today it seems that it no longer works, until yesterday it worked well, in the future will it come back?

If you do not see this error, it still works
Can't verify license request signature; either the platform is wrong or the key has changed!

So I confirm it still works, you can check by yourself here https://bitmovin.com/demos/drm

On which website ?
If you do not see this error, that means it still works :
Can't verify license request signature; either the platform is wrong or the key has changed!

So I confirm it still works, you can check by yourself here https://bitmovin.com/demos/drm

yes bro that is the message that shows me until yesterday it worked fine today that poster already appears

yes bro that is the message that shows me until yesterday it worked fine today that poster already appears

Have you at least tested on https://bitmovin.com/demos/drm with Chrome 88 ?

Look here, bro, I wanted to get the audio, can you see if you have more luck? https://watch.boomerang.com/watch/38/13

Have you at least tested on https://bitmovin.com/demos/drm with Chrome 88 ?

Look here, bro, I wanted to get the audio, can you see if you have more luck? https://watch.boomerang.com/watch/38/13


Dlib's detector: eyes detection is inaccurate

Consider this code:
                shape = self.model["sp"](img, detection)
                left_eye = (shape.part(2).x, shape.part(2).y)
                right_eye = (shape.part(0).x, shape.part(0).y)

The coordinates are taken from part 2 and 0 of the shape for left and right eye respectively.
However the documentation says the 5 landmarks model (actually implemented) returns 2 points for each eye and 1 point for the nose.
As a result the code above returns one boundary point for each eye and not the center of the eye (as other detectors do)
Imo the correct code should be
                shape = self.model["sp"](img, detection)
                left_eye = ((shape.part(2).x + shape.part(3).x) // 2), (shape.part(2).y + shape.part(3).y) // 2))
                right_eye = ((shape.part(0).x + shape.part(1).x) // 2), (shape.part(0).y + shape.part(1).y) // 2))

Also I have a question : the code above swaps the left eye with the right one. Does deepface consider left and right from the perspective of the observer or from the image perspective ?

Left eye means eye on the left of the image. In other words, it is the right eye of the person.

Left eye means eye on the left of the image. In other words, it is the right eye of the person.

This is a great clarification and I believe should be put in extreme evidence in all documentation. For instance if somebody wants to use an eye's position to do some math it should be aware that left and right are "mirrored"

BTW, 0 and 1 indexes are for one eye and 2 and 3 indexes are for another eye. Using 0 and 2 indexes are okay for alignment, we cannot say that is not a bug. But as you mentioned they are not centers of eyes similar to other detectors. I agree with using the centers. That is why, I set its label enhancement instead of bug.

About the definition of left and right, you are right. We should adopt the approach in biology instead of observers perspective.

Highlighted eye location of dlib detector with the current implementation

Closed with PR - https://github.com/serengil/deepface/pull/1138
Also created a different ticket to set left and right eyes according to the person itself's perspective instead of observer: https://github.com/serengil/deepface/issues/1139


Metastore Manager and Hive Editor assist do not display DB tables for non-default databases unless ALL DB Ranger Hive policy access

Hi,
Metastore Manager and Hive Editor assist do not display DB tables for non-default databases unless Ranger Hive policy is set to ALL DB access. If access is granted to a single or multiple DBs (but not ALL - *) Hue does not display the tables list, however running: use DB; show tables; in the Hive Query Editor and we are able to properly have the tables in the results. Running queries against the DBs and tables works fine, as well.
We enabled debug but there's no additional info that could help trace the problem.
Thanks

@weixiaxu would be great to confirm if the HS2 GetSchemas() call used by Hue as an issue with Ranger
https://github.com/cloudera/hue/blob/master/apps/beeswax/src/beeswax/server/hive_server2_lib.py#L757 and get_tables

Hi Romain and Wei,
Do you have some hints on how we can test/check further?
Thanks a lot

This is similar to https://issues.cloudera.org/browse/HUE-6256, where some corner cases might still be there

Hi,
Can you please share a bit more about your env? I tried with new user t1 belongs to grp1, and grant all permission for 't1' user with 'testdb' access only, not 'all'. Log in as t1, we can do any operations as granted/expected for 'testdb' only. Make sure this user/group exists on your cluster OS level.
Hope this helps!
Weixia

Hi Weixia and Romain,
Thanks a lot for your quick replies. We actually have SSSD-AD OS integrations, as such the users and groups membership already exists . We can also see the Hive DBs list and can perform  operations on the DBs and tables, however we are no able to see the tables and their fields displayed under the corresponding   Hive DBS Hue left pane or the Table Browser (no entries found), for users that do not have ALL DBs permissions.  Nevertheless, we are able to properly consult the default DB tables and fields in the above mentioned Hive DBs pane and in the Table Browser.  Is there any specific configuration that would allow a different behaviour from Hue for the default DB?

Thanks a lot

Hi Elisabetao,
Are you using a secure HDP cluster(kerberos +ranger) with Hue?  Which version? Ranger integration is not fully certified. We could have an issue on hive assist panel.
Cheers,
Weixia

Hi Weixia,
Indeed, we are on HDP 3.1.1 secure ( Kerberos + ranger) with Hue 4.3. Would you mind giving more details about this issue about the assist panel?
Is there a workaround/patch code we could apply?
Thanks so much,
Elisabeta

On Jun 26, 2019, at 4:57 PM, Weixia Xu<EMAIL_ADDRESS>wrote:
Hi Elisabetao,
Are you using a secure HDP cluster(kerberos +ranger) with Hue? Which version? Ranger integration is not fully certified. We could have an issue on hive assist panel.
Cheers,
Weixia
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Elisabeta,
Unfortunately HDP+Hue is not a supported combination as of now.  We do have an internal JIRA filed  against hive/hue ranger integration which has not being worked on yet.  We will keep you update once it gets resolved.
Sorry for the inconvenience!
Weixia

Hi Weixia,
Thanks to you for the quick reply and help. Since we are already preparing this for our Prod deployment could you maybe help pointing me to which are the assist panel functions/code we could look into to correct and why this is working propely for the Default Hive DB ?
Thanks  a lot,
Elisabeta

Hi Weixia,
Do you happen to have visibility to when this issue will be fixed? The fact that we are not able to properly view the Hive tables in assist while having access to them can be quite frustrating when accessing Hive through Hue.
Thanks a lot for the help,
Elisabeta

Hi Elisabeta,
HDP with HUE is not on our plan as of now. We tried with our new product, after config hive-site properly we are able to see granted db/tables(by Ranger) for the specific user. So please check if you have "hive.server2.authentication.kerberos.principal" setup properly.   If issue still exists, you can check apps/beeswax/src/beeswax/server/hive_server2_lib.py or related files to understand more.
Hope this helps.
Weixia
Hope this helps!
Weixia

Hi @romainr @weixiaxu, we also encountered this issue with the latest version of Hue and HDP 3.1.
How would this work with CDP which has both Hue and Ranger in the stack ?
Thanks for your help.

Hi,
To overcome this, I have replaced the use of thrift GetTables based call from get_tables_meta in https://github.com/cloudera/hue/blob/master/apps/beeswax/src/beeswax/server/dbms.py  with :
def get_tables_meta(self, database='default', table_names='*', table_types=None):
    database = database.lower() # Impala is case sensitive

    if self.server_name == 'beeswax':
      identifier = self.to_matching_wildcard(table_names)
    else:
      identifier = None
    #tables = self.client.get_tables_meta(database, identifier, table_types)
    #Switch back to show tables/views since GetTables does not return all tables/views in DB for non-default databases unless ALL DB Ranger Hive policy access
    query_tbls = "show tables IN "+str(database)
    query = hql_query(query_tbls)
    timeout = SERVER_CONN_TIMEOUT.get()
    handle_tbls = self.execute_and_wait(query, timeout_sec=timeout)
    if handle_tbls:
      result = self.fetch(handle_tbls, rows=5000)
      self.close(handle_tbls)
      tbls = [[table_name[0],'Table'] for table_name in result.rows()]

    query_vws = "show views IN "+str(database)
    query = hql_query(query_vws)
    handle_vws = self.execute_and_wait(query, timeout_sec=timeout)
    if handle_vws:
      result = self.fetch(handle_vws, rows=5000)
      self.close(handle_vws)
      vws = [[view_name[0],'View'] for view_name in result.rows()]

    query_mvws = "show materialized views IN "+str(database)
    query = hql_query(query_mvws)
    handle_mvws = self.execute_and_wait(query, timeout_sec=timeout)
    if handle_mvws:
        result = self.fetch(handle_mvws, rows=5000)
        self.close(handle_mvws)
        mvws = [[mview_name[0],'Materialized view'] for mview_name in result.rows() if str(mview_name[0])  and  str(mview_name[0]) != "# MV Name" ]

    tables = tbls + vws + mvws
    hive_objects = [{'comment': None, 'type':table[1], 'name':table[0]} for table in tables]

    if len(hive_objects) <= APPLY_NATURAL_SORT_MAX.get():
      hive_objects = apply_natural_sort(hive_objects, key='name')

    #if len(tables) <= APPLY_NATURAL_SORT_MAX.get():
    #  tables = apply_natural_sort(tables, key='name')
    #return tables
    return hive_objects

Hope this helps.
Thanks

Hi Elisabetao,
Thanks a lot Elisabetao. The workaround indeed resolves the issue after pressing the refresh icon on Tables at least once. But this is a bug and needs to be fixed by Cloudera as DAS LTE 1.3.0 version with HDP 3.1.0 is very immature and a lot of bugs. For the customers who cannot upgrade either HDP or DAS due to cascading effects to other software versions are getting this problem and need to look back to HUE as a workaround UI to support analysts.

Hi Elisabetao,
Thanks a lot Elisabetao. The workaround indeed resolves the issue after pressing the refresh icon on Tables at least once. But this is a bug and needs to be fixed by Cloudera as DAS LTE 1.3.0 version with HDP 3.1.0 is very immature and a lot of bugs. For the customers who cannot upgrade either HDP or DAS due to cascading effects to other software versions are getting this problem and need to look back to HUE as a workaround UI to support analysts.

Please proceed with closing the case.
Regards,
Deepak
From: github-actions[bot]<EMAIL_ADDRESS>Sent: 09 March 2021 07:43
To: cloudera/hue<EMAIL_ADDRESS>Cc: JAIN Deepak<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [cloudera/hue] Metastore Manager and Hive Editor assist do not display DB tables for non-default databases unless ALL DB Ranger Hive policy access (#883)
This issue is stale because it has been open 30 days with no activity and is not "roadmap" labeled or part of any milestone. Remove stale label or comment or this will be closed in 5 days.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://smex-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3A%2F%2Fgithub.com%2Fcloudera%2Fhue%2Fissues%2F883%23issuecomment-793271673&umid=b646a519-a2d4-49a4-9de6-0d858f1eeb0a&auth=c8b736f3f2ae8a131812ffc19cf36efa73a889aa-e4f368a7d05b7ca98aad5731e13c9027a1bc00b3, or unsubscribehttps://smex-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANR2F6DDNQWMO26HISCX63DTCV727ANCNFSM4HXFJE6Q&umid=b646a519-a2d4-49a4-9de6-0d858f1eeb0a&auth=c8b736f3f2ae8a131812ffc19cf36efa73a889aa-73fdc5667863850624b4441465ce0d4b470f6cea.

The operating companies affiliated with Atradius N.V. (Atradius Group) conduct insurance, debt collection and information services business through their registered (branch) offices in many countries. For information about the main registration details of Atradius Group offices in your country, please visit https://group.atradius.com/contact-us/
Important Notice
This e-mail, including any and all attachments, is intended for the addressee or its representative only. It is confidential and may be under legal privilege. Any form of publication, reproduction, copying or disclosure of the content of this email is not permitted, unless expressly otherwise indicated in the email by the Atradius contact person. If you are not the intended recipient of this email and its contents, please notify the sender immediately by reply email and delete this email and all its attachments subsequently. Although this email and any attachments are believed to be free of any virus or other defect that might affect any computer system into which it is received and/or opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by Atradius Group companies, either jointly or severally, for any loss or damage arising in any way from its use. Email received by Atradius Group can be stored for business purposes.


(Question) Why service objects can hold multiple errors?

Since

the first error is immediately rescued by Service::Wrapper#perform!
aldous seems encourage to return Result::Failure (or raise errors) as soon as possible

Why a service object can hold multiple errors?
Correct me if I am wrong. Thanks!

I am not 100% sure I understand your question. A service object itself doesn't hold/store any errors.
A result object can store a list of errors (or error messages), perhaps you're referring to that?
You're right that Aldous does encourage you to short-circuit the perform method, by returning Result::Failure as soon as you can, but you don't want to be locked in to doing things a specific way.
You may choose to collect a number of errors (e.g. by rescuing several statements separately) and then return them all at once, which is why a Result::Failure object takes a list of errors. The point is to encourage the usage of specific patterns, but not to architecturally lock you in to doing things in specific ways. If you want/need to do something different you should be able to.
Does that answer your question?

Yes, thanks!!!


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.10.176 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ADD: threshold function to remove small clusters

Following up from issue #5279. Discussion with @agramfort about adding a cluster-size threshold.
This does not make the cluster test much faster, but it allows the user to not return clusters that are smaller than X-many time/spatial samples. For example, it can be used to remove clusters that are just 1 or 2 samples big -- i.e. unlikely to reflect a meaningful result.

@larsoner what is your take on this?
not much on my side. If it's useful to a few people why not.
@LauraGwilliams Does it match what another software does?

@larsoner what is your take on this?

I don't think it will effect speed.
For spatially smooth data like MNE solutions I have to imagine spatial extent won't make much difference in H0 (if there is a single huge voxel neighboring voxels should also be significant). Filtering of the clusters after clustering thus could suffice.
For the temporal dimension, maybe it makes some sense if you are looking for only low-frequency / sustained responses. But in that case you might be better off low-pass filtering your data, as this is a better way to increase SNR.
For sparser data it could matter for H0. But for sparser data, I'm not sure when you'd want to use such a size threshold.
So I'm having trouble finding a suitable use case. @LauraGwilliams WDYT?

I hadn't realised that removing clusters ends up affecting the result of other clusters in the test.
The original reason I wanted to do this, was to i) make things quicker (which, now I see it makes no difference) ii) reduce the size of the output for saving the result.
Maybe the answer is to put the thresholder after the cluster test is performed? That way, the result of the clusters are not affected, but the user still has an easy way of discarding clusters that are only 2 or 3 samples big (which, in my experience can make up nearly 80% of the found clusters).

(which, in my experience can make up nearly 80% of the found clusters).

These all should have very bad (close to 1) p-values. So culling clusters with p-values near 1 (or even >= 0.5) should remove many of them. Can you check? Would this work for your use case? If not, doing a size-based filtering should also be straightforward.

Hi there,  this thread caught my attention so I jump in to the risk of
side-tracking
One issue we often observe is that n.s. small clusters separated by only a
few samples may be numerous but taking the perspective of a longer time
scale, these may reflect a real cluster. I think Alex had incorporated the
Friston et al trick in the code but it still happens quite often. Filtering
or detrending doesn't do.
Could there be a smart way of conceiving of clusters, for instance: if 10
clusters of a couple samples each agglomerate within a 50 ms window then
likely a real cluster? (i.e. implement some sensible (spatio)temporal
constraints to time series?
Virginie van Wassenhove
https://brainthemind.com/ https://brainthemind.com/
On Thu, Jun 14, 2018 at 4:00 PM, Eric Larson<EMAIL_ADDRESS>wrote:

(which, in my experience can make up nearly 80% of the found clusters).
These all should have very bad (close to 1) p-values. So culling clusters
with p-values near 1 (or even >= 0.5) should remove many of them. Can you
check? Would this work for your use case? If not, doing a size-based
filtering should also be straightforward.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/5283#issuecomment-397306337,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDKInDLxdVcmwv_UtaQd0mC8flmoCzMks5t8myVgaJpZM4UmxIw
.

implement some sensible (spatio)temporal constraints to time series

The spatial can be controlled in the def of the connectivity (for cortical surfaces this can be a physical distance).
For temporal it can be controlled by max_step parameter. Perhaps this is what you are looking for?

yes and no - an example strictly in time to simplify:
say you have an epoch of 1 s. Between 150 and 200 ms we see 10 clusters of
2 to 10 samples each spread over. Some reach significant because they reach
the max_step defined as 7 but some don't. Should we consider this time
period be significant or not? Currently not because there are
discontinuities between the samples yet there may be a real effect.
So the idea would be to use conditional probabilities so that if a certain
numbers of clusters are non-contiguous by just a few samples over a longer
time period (biologically relevant) then it could be considered a cluster.
Does it make sense? (I am afraid I make it more complicated than it is but
Alex can transcribe :)
Virginie van Wassenhove
https://brainthemind.com/ https://brainthemind.com/
On Thu, Jun 14, 2018 at 5:04 PM, Eric Larson<EMAIL_ADDRESS>wrote:

implement some sensible (spatio)temporal constraints to time series
The spatial can be controlled in the def of the connectivity (for cortical
surfaces this can be a physical distance).
For temporal it can be controlled by max_step parameter. Perhaps this is
what you are looking for?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/5283#issuecomment-397328477,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHDKIvzC1wobYU23L_uL20wanEYTAtlJks5t8ntogaJpZM4UmxIw
.

You're right @larsoner -- setting the p-value threshold would also do a similar job.
We could have an argument to only return clusters that exceed a certain p-value threshold, then?

I'm not sure it buys us much, as it can be done easily by the user (and otherwise adds more keyword arguments to an already dense function)

Yeah makes sense. No worries then!

what is the plan here?

@larsoner thoughts?

Agreed we can close


k3s.io "this won't take long" missing sudo

on https://k3s.io, there is a text at the top:
 curl -sfL https://get.k3s.io | sh -
  # Check for Ready node,
  takes maybe 30 seconds
  k3s kubectl get node

running the last bit on a totally new system, fails:
$   k3s kubectl get node
The connection to the server localhost:8080 was refused - did you specify the right host or port?
``

considering `-rw------- 1 root root 1108 Nov  2 12:16 /etc/rancher/k3s/k3s.yaml`, I presume you mean to add `sudo` to that line too

$ sudo k3s kubectl get nodes
NAME        STATUS   ROLES    AGE   VERSION
onaci-010   Ready    master   23m   v1.18.9+k3s1

I think the instructions may assume you're running it as root.

@cjellick I'm not sure where the copy on get.k3s.io lives; it doesn't appear to be in the docs?

"this won't take long" is pretty misleading when trying with a non-root user, the script uses sudo so it looks like it all went well and then you get stuck trying to actually use it.

Closing as complete.


Decode Serialized JSON Back to Binary Object After Upload

I have a use case where when a user uploads a file using the Budibase-File-Upload plugin, I would like to send out an email with the same file attached to it.  I am using an MS SQL database with a nvarchar(max) field configured to accept the JSON string.  Is there a way to pull the string into some Javascript that can decode it back into a file?  All of the files involved with this use case would be .pdf files.

Hi, take a look at the source code for the corresponding File Repeater plugin. The string is decoded back into a file there.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Chad Griffith @.>
Sent: Monday, September 18, 2023 6:51:46 PM
To: chungchunwang/Budibase-File-Upload @.>
Cc: Subscribed @.***>
Subject: [chungchunwang/Budibase-File-Upload] Decode Serialized JSON Back to Binary Object After Upload (Issue #11)
I have a use case where when a user uploads a file using the Budibase-File-Upload plugin, I would like to send out an email with the same file attached to it. I am using an MS SQL database with a nvarchar(max) field configured to accept the JSON string. Is there a way to pull the string into some Javascript that can decode it back into a file? All of the files involved with this use case would be .pdf files.
—
Reply to this email directly, view it on GitHubhttps://github.com/chungchunwang/Budibase-File-Upload/issues/11, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOZ73DBWDJCXQDBRHZY34XLX3ARUFANCNFSM6AAAAAA44QTMBU.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

The repo is here: https://github.com/chungchunwang/Budibase-File-Repeater


Python default interpreter is not reacting to changes in settings

Issue Type: Bug
Set the "Python: Default Interpreter Path" to /usr/local/bin/python3 - on my system this is version 3.9.2
The Python version in the bottom corner remains 3.8.8
Restarting doesn't update it.
VS Code version: Code 1.54.2 (fd6f3bce6709b121a895d042d343d71f317d74e7, 2021-03-11T00:56:09.783Z)
OS version: Darwin x64 20.3.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (12 x 3200)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
32.00GB (0.32GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (18)

Extension
Author (truncated)
Version

htmltagwrap
bra
0.0.7

path-intellisense
chr
2.3.0

vscode-eslint
dba
2.1.17

prettier-vscode
esb
6.2.0

file-icons
fil
1.0.29

auto-rename-tag
for
0.1.6

code-runner
for
0.11.3

vscode-pull-request-github
Git
0.24.0

applescript
idl
0.20.0

vscode-pigments
jas
2.0.0

vscode-mdx
Jou
0.2.2

vscode-styled-components
jpo
1.5.0

vscode-docker
ms-
1.10.0

python
ms-
2021.2.636928669

jupyter
ms-
2021.3.619093157

remote-containers
ms-
0.163.2

color-manager
roy
0.6.2

material-theme
zhu
3.9.15

Did you select right interpreter?

I think so, does this look correct?

Selecting the 3.9.2 option after clicking the interpreter label in the bottom left corner does change it to 3.9.2 but only by creating a .vscode folder with a settings.json containing:  "python.pythonPath": "/usr/local/bin/python3" - the same location as I had specified as default. If I delete this folder it returns to 3.8.8

Are you tried to change it, in default settings.json? On MacOs should be in: $HOME/Library/Application Support/Code/User/settings.json

Looks like the change was automatically saved to that file. "python.defaultInterpreterPath": "/usr/local/bin/python3", is already included.

hmm, maybe try restart vscode, you can also try to delete a settings.json file.

Fixed by changing python.pythonPath as well as python.defaultInterpreterPath. Thanks for trying to help @GNUSheep!


Feature request: Device is not showing the Buttons

Opening the device overview page shows sections for Sensors, Controls and Diagnostic but is not showing the Button entities.
Only the List overview of entities is showing button sensors like button.carname_start_charging or button.carname_start_climate

The screenshot in under https://github.com/daernsinstantfortress/cupra_we_connect
is as far as I can see a dasboard view.
Probbaly it is helpful to see under the device the possible actions as Press function like in other devices

Same here. I have MJ25 Born with software 5.0, the sliders do work, but there are no buttons.

I have the same problem.

Holy... the buttons are there. Go to config -> entities and search for cupra, the buttons are in the list and can be used in dashboards.

Holy... the buttons are there. Go to config -> entities and search for cupra, the buttons are in the list and can be used in dashboards.

Good catch!

But why not visible at the integration page?
For others it is visible there as well.


Custom plugin does not have beforeDestroy call

I have to manually destroy my chart instance by calling this.chart.destroy();  My problem is that I have a custom plugin which has event listeners. When a chart is destroyed, it notifies the plugins, and in the plugin's destroy call I call chart.canvas.removeEventListener(). But this works only for the automatic destroy, and when I call destroy manually, the canvas stops existing before the plugins are notified. As far as I could find, there are no events that are run before destroy, according to the documents stop and uninstall are also called after destroy.
I managed to make a workaround by placing event listener removers to reset, and calling chart.notifyPlugins('reset') before destroying the chart. However, this way the event listener removing is entirely manual, have to be remembered each time the plugin is used in different contexts, and there's no way to ensure the event listeners were removed when chart is destroyed. There has to be a way to do a beforeDestroy call for a custom plugin.
Chart.js version: 3.6.1

Is there a reason you are handling the listeners manually?
You could just configure the events you need for your plugin and let Chart.js handle the listeners.
For example:
new Chart(canvas, {
  data: ...
  options: {
    // defaults + 'mousedown' (these are all the listeners the chart will register)
    events: ['mousemove', 'mouseout', 'click', 'touchstart', 'touchmove', 'mousedown'],
    plugins: {
       PLUGIN_ID: {
         // only pass mousedown to this plugin
         events: ['mousedown']
       }
    }
  },
  plugins: [{
    id: 'PLUGIN_ID',
    beforeEvent(chart, args, opts) {
     console.log(args.event.type, 'before');
    },
    afterEvent(chart, args, opts) {
     console.log(args.event.type, 'after');
    }
}

@kurkle The plugin creates custom element(s) that can be dragged in the chart, and different events happen during and after drag and during and after mouse move that is not a drag.

It seems like we could add a plugin hook beforeDestroy rather easily. I'm happy to look at a PR for it


[Doc] Improve documentation on how to build python client wheels

Problem
There are several scripts involved. As a new user I fumbled my way through figuring what I needed to run in order to get a python 3.9 wheel built. See PR #9389 . I also fixed a couple of minor issues in the process.
Desired outcome
The goal is to make it easier to do this for new or existing python versions without any surprises. This may involve more than documentation -- for example some refactoring of the scripts.

Thanks @vkvm for tracking this issue.

Hi @vkvm, since you did the code job, would you like to add the doc correspondingly? Many thanks

Hi @vkvm, thanks for your work, any progress about the doc?

Hi @vkvm, would you like to add docs accordingly? Then I can help review, thanks

Hi @vkvm, would you like to add docs accordingly? Then I can help review, thanks

Hi @Anonymitaet - I will work on it later this week.

Hi @vkvm  any progress on the docs? I would like to help review, thanks

Hi @vkvm any progress on the docs? We would like to help review, thanks

Hi @momo-jun can you follow up on this doc? Thanks

Since #15024 adds another script to build Python wheel files for macOS, this PR is used to track documents of these two scripts.

pulsar-client-cpp/docker/build-wheels.sh
pulsar-client-cpp/python/build-mac-wheels.sh

Hi @BewareMyPower any updates on this issue or can you pls share your updated plan? Thanks.
Just a quick follow-up because this is involved in 2.11 release.

No update yet.

Closed as stale. The development of the Python client has been permanently moved to https://github.com/apache/pulsar-client-python. If this is still relevant, please open an issue there.
This can be superseded by https://github.com/apache/pulsar/issues/17918.


[r] Set the package version to 1.5.0

Issue and/or context:
Following on #1854 / #1855 the PR sets to package version to 1.5.0
Changes:
None
Notes for Reviewer:
SC 36501

Can you update the header in NEWS.md as well?

Sure thing. Thanks for catching that. Someone with a bit of time and good cup (or pot !!) of coffee or tea may want to expand NEWS.md for all the changes since 1.4.0.

Good call! Would you be up for adding some details about the enumeration support in this pr?

@aaronwolen @eddelbuettel https://github.com/single-cell-data/TileDB-SOMA/pull/1856/commits/7435fc09d4bf707acb3446c006ef23e719056a8f with NEWS.md changes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
see 34 files with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.


Charger selection Implementation of the following functions:

It has implemented a function for the type of charger.
What features will be implemented next?

We'll make Map


[PRES-356] Player + NPC Density Control

This PR makes it possible to control the density of players and NPCs using the AIGymGameMode and the AIGym map.
The GameMode is configured through the following parameters both using the command line for native Unreal as well as through worker flags:

Override spawning flag - denotes whether or not to override the default spawning
Total players - the total number of players that are to connect to the deployment
Player density - the number of players that are clustered together and can see each other
NPC to player ratio - the number of NPCs to spawn per player

The AIGym map has been changed by enlarging the floor and the navmesh to create a bigger world - currently the world edge length being 8000 SpatialOS World Units.
The NPC spawns and chooses a random location to walk to based on a radius center at its spawning location.
The spacing between the clusters is calculated based on the size of the Floor along with the default checkout radius of the Player's character - currently the default configuration supports 256 clusters.

This PR will be closed due to being out of date and the logic will be moved to PRES-366


Added GitHub push functionality

Added Github push functionality: By pressing the button, the user will be asked for a name of a repo, his github username and his github token.
This code is being run client side so the user will always be asked for his credentials (for security reasons).
I think the code is pretty straight forward. Let me know if you have any questions or would like any changes to the code.

I was thinking about this. It pushes into the main branch, right?
Is it better to create new branches or pull requests?
It is just on the main branch there could be conflicts
Any thoughts about that?

It creates a repo and pushes it to the main branch. You can check an example in here
I don't really understand the rest of your questions. Can you please elaborate? I think I need a bit more detail to understand them.

What I mean is that I have a concern about pushing directly to the main branch. In most cases, this is not a great practice, especially when the main branch is being worked on by others. The issue is that it can easily cause conflicts or overwrite someone else’s changes, which can disrupt the whole project.
A more effective approach is to create a new branch for your changes, and then submit a pull request. This allows for a smoother process where changes can be reviewed, conflicts can be resolved ahead of time, and everyone can stay on the same page without risking the stability of the main branch.
I am not interested in pushing into the main branch in that sense.
But that's me.
Maybe we can have an option of pushing to the main branch directly or making pull requests into the main branch.

Also please store the GitHub Token in an encrypted format so we don't have to login over and over again

@wonderwhy-er Right now it is creating a new branch and pushing to main.
I'm not really sure if what you are discussing is possible, because when using bolt, the code generated is "new" so there shouldn't exist a repo with that code already.
Can you give me a more detailed use case? I cannot wrap my mind around what you said.
@Felitendo Storing tokens in the frontend is generally considered a bad practice. There is feature request to store the AI APIs in the frontend but I think that should be reviewed. What is your take on it?

The best thing would be via making a docker-compose.yml file with full docker support. Then attaching bolt.new to a database like postgresql. Then making a register/login page that can be turned on/off via the Environtment Variable "ALLOW_SIGNUPS = true/false". Then creating a settings page with the options to add an AI API key and a GitHub API key. Then when creating a new Project, ask the user if he wants to sync a project to and from GitHub. If he says yes, then store the project files on postgresql and GitHub, if he says no, only store it on postgresql.

This worked wonderfully, thank you @goncaloalves! Tested it out and here is the repo I pushed:
https://github.com/coleam00/bolt-generated-project
I appreciate the conversation here as well, thank you for your thoughts @Felitendo and @wonderwhy-er. I think there is some more work to be done to handle the token (and the API keys) better, I will create a follow up item for this.
Also making the UI better for the GitHub push would be a nice addition too! But for now this is great and I am merging it!


AST: fix build with newer clang

Elaborate the NodeKind typename to avoid ambiguity with llvm::yaml::NodeKind
and swift::experimental_dependencies::NodeKind.  This fixes the build with
newer compilers.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @davidungar

@swift-ci please test and merge


Update wifi configuartion

Describe the issue
A clear and concise description of where you're stuck in the guide. What are you trying to do, and how is it not working?
I am trying to update my wifi configuration after setting up the pi on one network and needing to switch it to another network. I am at the step of setting up the Electrum server in the Bitcoin section so most of the network and remote access setup has been completed on the old wifi network. What's the best way to update my wifi network?
Is the best thing to connect it to a display and keyboard to log in directly and update the wpa_supplicant.conf?
Thanks again for the help and for making the guide! I have learned a lot in the process of setting up my node. 🙏🏽
Location in guide
Link to the corresponding page and section on https://raspibolt.org
https://raspibolt.org/electrs.html
Screenshots
If applicable, add screenshots to help explain your problem.
Environment

Hardware platform: Raspberry Pi 4 8GB RAM
Operating system: 2021-10-30-raspios-bullseye-arm64-lite.img

Additional context
Add any other context about the problem here.

On "Raspberry Pi OS", you can run sudo raspi-config and select 1 System Options --> S1 Wireless LAN to configure the Wifi.
If you're wifi is currently not working, you can either by log in with SSH with an Ethernet cable, or connect the Pi to a screen/keyboard and log in locally.

Can you give an update on the status of this issue?


updates to dependency versions

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

requirements: run: missingno==0.4.2 must contain a space between the name and the pin, i.e. missingno ==0.4.2

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Gemini can't create or edit files

Copied @ssillah10 question from #168.

Hi Paul, I am having the same issue but with Gemini. It can't create or edit files. Any suggestions?

Can you tell me the aider version, exact model name and any other settings/switches you are using? Easiest thing would be to copy & paste the "announcement" lines that aider prints on startup:
Aider v0.XX.Y
Model: gpt-N-... using ???? edit format
Git repo: .git with ### files
Repo-map: using #### tokens

Aider v0.30.1
Model: gemini/gemini-1.5-pro-latest with whole edit format
Git repo: .git with 0 files
Repo-map: using 1024 tokens

Hi,
Can you tell me how I can change from gpt-4 to Gemini or Groq models?
Thanks
Aider v0.30.2-dev
Models: gpt-4-1106-preview with udiff edit format, weak model gpt-3.5-turbo
Git repo: none
Repo-map: disabled

Can you tell me how I can change from gpt-4 to Gemini or Groq models?

Here are the docs in connecting to other LLMs:
https://aider.chat/docs/llms.html

Aider v0.30.1
Model: gemini/gemini-1.5-pro-latest with whole edit format
Git repo: .git with 0 files
Repo-map: using 1024 tokens
On Mon, Apr 29, 2024 at 7:56 PM paul-gauthier @.***>
wrote:

Can you tell me the aider version, exact model name and any other
settings/switches you are using? Easiest thing would be to copy & paste the
"announcement" lines that aider prints on startup:
Aider v0.XX.Y
Model: gpt-N-... using ???? edit format
Git repo: .git with ### files
Repo-map: using #### tokens
—
Reply to this email directly, view it on GitHub
https://github.com/paul-gauthier/aider/issues/579#issuecomment-2083549001,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOH4FJOKP3VLJYEHVGSN45LY72QXPAVCNFSM6AAAAABG66OKT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGU2DSMBQGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

@SharadK9 can you show me the problem you are having with aider and gemini? Either take a screenshot, copy & paste the text from your terminal or pull the lines from .aider.chat.history.md.

@SharadK9 can you show me the problem you are having with aider and gemini? Either take a screenshot, copy & paste the text from your terminal or pull the lines from .aider.chat.history.md.

Thanks Paul. Its working now. Uninstalled aider and then reinstalled again and set groq api key.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.

this is the error i get
Malformed response #3, aborting.
https://aider.chat/docs/faq.html#aider-isnt-editing-my-files
No filename provided before ``` in file listing

i updated aider but gemini still isn't writing or updating to files, is there a fix?

Can you show me more of the output? Ideally I would like to see what gemini is sending back as far as the code and the wrapping around it.
Also, you can try using --edit-format diff with gemini. I am about to switch gemini to use that as the default edit format.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Updates Helm charts that staticly reference istio-system namespace.

Previously, several Helm charts made reference to the istio-system namespace. This causes Helm installations to fail when using a ns other than istio-system. This PR replaces the static references with the correct Helm variables.
Fixes issue #7538

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: danehans
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
If they are not already assigned, you can assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danehans: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
23e6d68e6212c0f5443ea34411af93cf7222d42d
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danehans: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
23e6d68e6212c0f5443ea34411af93cf7222d42d
link
/test istio-unit-tests

prow/istio-presubmit.sh
23e6d68e6212c0f5443ea34411af93cf7222d42d
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danehans: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans I've just run straight into this issue too, so :+1: for making this PR.
But I tried installing the chart from this branch and got:
Error: parse error in "istio/charts/security/templates/meshexpansion.yaml": template: istio/charts/security/templates/meshexpansion.yaml:9: undefined variable "$spec"

$spec is only defined in some places, and is not a global.


Sticky Footer aint stickin.

I just pulled down a fresh copy of bourbon/neat/bitters and installed it in my project. The styles seem to be all working fine. I have not changed any of the code yet.
I then turned on "superglue sticky" mode for footer-2 by uncommenting the SCSS and the HTML, but was unable to see the footer stick.
It seems there is no live example of a sticky footer in the example, so its possible something broke it and no one noticed?
Its also not working when I resize the page-- I have not put my code inside of any neat containers etc.
Here's my code:
Layout:
body
  .wrapper-for-content-outside-of-footer
    include _navigation
    block content
  include _bottom_navigation

Bottom Nav is copy pasted from the refills page.
Let me know if anyone can reproduce this!
Thanks,
Jon

Hi @jontonsoup, when I try the following code (and add the real code where I have the "out-of-the-box code" commented out) it seems to work fine. Would you mind sending us your whole code snippet in case this doesn't solve your problem?
<div class="wrapper-for-content-outside-of-footer">
  content
</div>

<footer class="footer-2" role="contentinfo">
  <!-- footer-2 html code here -->
</footer>

@import "bourbon/bourbon";
@import "neat/neat";

$large-screen: em(860) !default;

.wrapper-for-content-outside-of-footer {
  min-height: 100%;
  height: auto !important;
  height: 100%;
  margin: 0 auto -4em;
}

html, body {
 height: 100%;
}

.wrapper-for-content-outside-of-footer:after {
  content: "";
  display: block;
}

.footer-2, .wrapper-for-content-outside-of-footer:after {
  height: 17em;

  @include media($large-screen) {
    height: 4em;
  }
}

.footer-2 {
  // all the footer-2 styles here
}

Hey, @Magnus-G .
Sure--
application.scss
@import "bourbon/bourbon";
@import "base/base";
@import "neat/neat";
@import "application/base";

application/base.scss
@import "utilities";
@import "cards";
@import "footer";

// Uncomment this for a sticky footer.
//
.wrapper-for-content-outside-of-footer {
  min-height: 100%;
  height: auto !important;
  height: 100%;
  margin: 0 auto -4em;
}

html, body {
 height: 100%;
}

.wrapper-for-content-outside-of-footer:after {
  content: "";
  display: block;
}

.footer-2, .wrapper-for-content-outside-of-footer:after {
  height: 17em;

  @include media($large-screen) {
    height: 4em;
  }
}

.footer-2 {
  $base-spacing: 1.5em !default;
......

layout.html
body
  .wrapper-for-content-outside-of-footer
    include _navigation
    #sheet_id.hide
      = sheet_id
    #token.hide
      = token
    block content
  include _footer

footer.html
footer.footer-2(role="contentinfo")
  .footer-logo
    img(src="https://raw.githubusercontent.com/thoughtbot/refills/master/source/images/placeholder_logo_1.png", alt="Logo image")
  ul
    li
      a(href="javascript:void(0)") About
    li
      a(href="javascript:void(0)") Contact
    li
      a(href="javascript:void(0)") Products
  .footer-secondary-links
    ul
      li
        a(href="javascript:void(0)") Terms and Conditions
      li
        a(href="javascript:void(0)") Privacy Policy
    ul.footer-social
      li
        a(href="javascript:void(0)")
          img(src="https://raw.githubusercontent.com/thoughtbot/refills/master/source/images/facebook-logo-circle.png", alt="Facebook")
      li
        a(href="javascript:void(0)")
          img(src="https://raw.githubusercontent.com/thoughtbot/refills/master/source/images/twitter-logo-circle.png", alt="Twitter")
      li
        a(href="javascript:void(0)")
          img(src="https://raw.githubusercontent.com/thoughtbot/refills/master/source/images/youtube-logo-circle.png", alt="YouTube")

Finally, here is a screen shot of my console:

Thanks!
Jon

I've reworked the code to match the behavior I expect -- not sure if its compatible in the same way as the previous code (CSS is my weakest spot).
.wrapper-for-content-outside-of-footer {
  overflow: scroll;
  height: calc( 100vh - 4em );
}

.footer {
  @include fill-parent;
  background: $footer-background;
  padding: $base-spacing;
  width: 100%;
  height: 4em;

I’m closing this as we are focusing our efforts on a new, rewritten Refills library with a focus on accessibility and removal of grid and visual opinion for components. You can see a preview of the work here: http://refills.netlify.com/
Existing components and patterns from the 0.2.0 release will be provided as-is (no longer maintained) until the new version is released.


setMaxSupply fix

Previously i suggested u check newMaxSupply against totalMinted() for ERC721 for the reason :
_checkMintQuantity Fn will always revert if u set newMaxSupply to a number less then totalMinted because totalSupply() returns
totalMinted() - burnedTokens.
        if (quantity + totalMinted > maxSupply) {
            revert MintQuantityExceedsMaxSupply(
                quantity + totalMinted,
                maxSupply
            );
        }

example :
-initial maxSupply : 5000

totalMinted : 5000
-burn: 1000
-setMaxSupply: 4500

Result : not possible to mint any more tokens . ERC721A version  u use doesnt have spotMint to remint burned tokens ..
Adding to that :
ERC721SeaDropRandomOffset will revert always if u try to setRandomOffset after changing newMaxSupply to a number less then totalMinted().
        // Revert if the collection is not yet fully minted.
        if (_totalMinted() != maxSupply) {
            revert NotFullyMinted();
        }

Regarding ERC1155 . I didnt check

Thanks, just don't set max supply under total minted then?
My reasoning for using total supply instead of total minted is because if you have 1000 tokens and 100 burned, I think it's okay to set max supply to 900 to signal there will never be more than 900, instead of being limited to 1000, but you are right then you can't mint more.

if its used for that purpose then its correct. But as i mentioned the ERC721A u are using doesnt have the latest feature ( spotMinting) means if the maxSupply 5000 and u burn 1000 .. the max mintable remains 5000 and can never change becuase the token ids are sequential.
no?

Sure, I don't see what's wrong with that, but I can change to checking total minted instead of total supply so it's less confusing.

this is done, thanks!


introduce performance testing

This is a bigger PR to introduce performance tests for Nginx.
This is a first version - everything in conftest.py will be extracted to a separate module in the future.

Is this PR for performance tests or functional integration tests, or both?
If performance tests are included, would it make sense to have them run only on demand, after manual approval?
See examples in aws-operator circleci configuration, push to aliyun/alibaba, implemented with two steps (one of type approval that human has to approve, and one which depends on the approval step) https://github.com/giantswarm/aws-operator/blob/master/.circleci/config.yml#L58-L82

Is this PR for performance tests or functional integration tests, or both?

Both, as you can't do one without the other. The test scenario is like that:

GS cluster is created
app+chart-operators are installed together with chart-museum
current Nginx chart is built and deployed to the cluster
pytest starts:

launches loadtest-app
launches gatling test against the loadtest app through Nginx Ingress
test results are parsed and asserted

If performance tests are included, would it make sense to have them run only on demand, after manual approval?

I think it's up to you - I would run them automatically on every tag, but whatever works best for you.

Both, as you can't do one without the other.

Of course performance tests are exercising some functionality, but it's not primary focus and purpose of performance tests to verify functional correctness. Performance tests depend on app being functionally correct first, makes no sense to test for performance while functionality is broken.
With little time I had before to see what was going on with the PR, I was confused by failing e2eBasicTest (now named basic-integration-test), thought PR with performance tests is trying to replace integration tests too.

I think it's up to you

I've applied master changes and made perf tests step require manual approval.


adds 'make' and 'unzip' to a clean Ubuntu server 14.04.2 for 32-bit

Hi all,
We should install make and unzip  in order to prevent the following on default Ubuntu server 14.04.2 instances:
user@host:~$ dnvm upgrade
Determining latest version
Latest version is 1.0.0-beta4
Downloading dnx-mono.1.0.0-beta4 from https://www.nuget.org/api/v2
Download: https://www.nuget.org/api/v2/package/dnx-mono/1.0.0-beta4
######################################################################## 100.0%
Installing to /home/cmpunk/.dnx/runtimes/dnx-mono.1.0.0-beta4
dnvm needs unzip to proceed.

Hi @thekane, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

:+1:

@glennc

Going to start pointing people at http://docs.asp.net/en/latest/getting-started/installing-on-linux.html instead of this. And remove the instructions here. Consolidate on one place.


clamav-daemon starting at boot on Debian

🐛 Bug Report
clamav-daemon is running at boot on debian.
To Reproduce
Steps to reproduce the behavior:

Start up an OpenVPN server.
See it running.

Expected behavior
We decided to run the clamav via cron and not use the daemon in PR https://github.com/cisagov/ansible-role-clamav/pull/1
Any helpful log output
root@ip-172-31-18-119:/etc/openvpn/server# uname -a && systemctl status clamav-daemon.service
Linux ip-172-31-18-119 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2 (2019-08-28) x86_64 GNU/Linux
● clamav-daemon.service - Clam AntiVirus userspace daemon
   Loaded: loaded (/lib/systemd/system/clamav-daemon.service; enabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system/clamav-daemon.service.d
           └─extend.conf
   Active: active (running) since Fri 2019-09-20 02:50:00 UTC; 9min ago
     Docs: man:clamd(8)
           man:clamd.conf(5)
           https://www.clamav.net/documents/
  Process: 514 ExecStartPre=/bin/mkdir /run/clamav (code=exited, status=0/SUCCESS)
  Process: 522 ExecStartPre=/bin/chown clamav /run/clamav (code=exited, status=0/SUCCESS)
 Main PID: 528 (clamd)
    Tasks: 2 (limit: 2314)
   Memory: 911.2M
   CGroup: /system.slice/clamav-daemon.service
           └─528 /usr/sbin/clamd --foreground=true

Have you rebuilt the packer AMI since I merged cisagov/ansible-role-clamav#1?

Yes: https://travis-ci.com/cisagov/openvpn-packer/builds/128444850

Verified.  Closin... oh.
mark.feldhousen@ip-172-31-18-75:~$ uname -a && systemctl status clamav-daemon.service
Linux ip-172-31-18-75 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2 (2019-08-28) x86_64 GNU/Linux
● clamav-daemon.service - Clam AntiVirus userspace daemon
   Loaded: loaded (/lib/systemd/system/clamav-daemon.service; disabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system/clamav-daemon.service.d
           └─extend.conf
   Active: inactive (dead)
     Docs: man:clamd(8)
           man:clamd.conf(5)
           https://www.clamav.net/documents/

The jazz you posted shows that the service is disabled and inactive.  Are you saying otherwise?


Delete branch when closing stale PRs

I want to automatically delete branches when the pull requests are closed with actions/stale.  Today https://github.com/actions/stale/pull/190 was finally merged, but as far as I can see there is no new release, yet.  @SaschaMann can I use commit https://github.com/actions/stale/commit/b12dccced80582bf8c52244f75838892ec5c1e82 (currently the latest commit on main) as reference?  I'm always a bit confused about which branch to look at for GitHub Actions.

I'm always a bit confused about which branch to look at for GitHub Actions.

The safest way is to click on the latest release in the sidebar and then copy the commit it points to:

The details of which branch that is on can vary between actions. Using the commit associated with the tag should always work because that's what people would access via @v3.0.14 etc at the time of copying the commit (this association may change later, hence we use the hash, not the tag)

I'm always a bit confused about which branch to look at for GitHub Actions.

The safest way is to click on the latest release in the sidebar and then copy the commit it points to:

The details of which branch that is on can vary between actions. Using the commit associated with the tag should always work because that's what people would access via @v3.0.14 etc at the time of copying the commit (this association may change later, hence we use the hash, not the tag)

The safest way is to click on the latest release in the sidebar and then copy the commit it points to:

The problem is that there is no tag here to look at, that's why I want to reference the commit.  But good to point out I could have just looked what branch they tagged before, thanks!

The safest way is to click on the latest release in the sidebar and then copy the commit it points to:

The problem is that there is no tag here to look at, that's why I want to reference the commit.  But good to point out I could have just looked what branch they tagged before, thanks!

The problem is that there is no tag here to look at, that's why I want to reference the commit.

Those screenshots were from the actions/stale repo. You can reference the commit but use the tag to find which commit it is.

The problem is that there is no tag here to look at, that's why I want to reference the commit.

Those screenshots were from the actions/stale repo. You can reference the commit but use the tag to find which commit it is.

Sorry I misunderstood you, I overread the part where you wanted to use a not-yet-released version.

Sorry I misunderstood you, I overread the part where you wanted to use a not-yet-released version.

It worked, yay!

It worked, yay!


Error setting addon, possibly related to logo.

This particular minecraft mod Hostile Neural Networks produces an error when it is created.
Code copied and tested from Advik-B's issue because their program let me find this issue.
from cursepy import CurseClient
from v import api_key

c = CurseClient(api_key)
game = c.game(432) # Minecraft
addon = c.addon(552574) # Hostile Neural Networks

My error is as follows and seems to imply it could be related to the mod's logo data.
Traceback (most recent call last):
  File "/home/twigglenn4/Downloads/curseTest/test.py", line 6, in <module>
    addon = c.addon(552574) # Hostile Neural Networks
  File "/home/twigglenn4/Downloads/curseTest/cursepy/wrapper.py", line 124, in addon
    return self.handle(5, addon_id)
  File "/home/twigglenn4/Downloads/curseTest/cursepy/handlers/base.py", line 990, in handle
    inst = hand.handle(*args, **kwargs)
  File "/home/twigglenn4/Downloads/curseTest/cursepy/handlers/base.py", line 411, in handle
    return super().handle()
  File "/home/twigglenn4/Downloads/curseTest/cursepy/handlers/base.py", line 190, in handle
    data = self.format(raw_data)
  File "/home/twigglenn4/Downloads/curseTest/cursepy/handlers/metacf.py", line 316, in format
    logo = base.CurseAttachment(logoa['title'], logoa['id'], logoa['thumbnailUrl'] if 'thumbnailUrl' in logoa.keys() else logoa['thumbnailurl'], logoa['url'], True, data['id'], logoa['description'])
TypeError: 'NoneType' object is not subscriptable

Thanks for reporting this!
The issue was the addon you were trying to work with did not have a logo, as you suggested. If this is the case, the cursepy will skip that part of when loading the addon. This should be fixed in the latest version of cursepy, the version you want is 2.2.0. Please let me know if any more issues arise, but otherwise we can close this issue.
Thanks!


export BlockApi

Pull Request Test Coverage Report for Build 75

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 53.638%

Totals

Change from base Build 74:
0.0%

Covered Lines:
1245

Relevant Lines:
2053

💛  - Coveralls

Thank for your contribution but there are several things that breaks the lib correct behavior


feat: swap fee accounting config

Why the different values in signet / and regtest? Which one is the default?

The default in the source code is true: https://github.com/GaloyMoney/galoy/blob/main/galoy.yaml#L182
But in the deployment it is set to false: https://github.com/GaloyMoney/galoy-deployments/pull/2644/files#diff-f18d77850a07073c181f62369beae2503b63697286ce8caa4cac7c7f67446a72R77
I am unsure in the local dev charts the order things get applied, so to be sure I just explicitly set it.

If the default is true then I'd say you should only override it in signet. Only one of the files gets applied - not both.


Clear the multiple selection

Excuse me,how can clear all selection while in mutiple mode.
I create an button order to clear all selection.
here is my codpen: https://plnkr.co/edit/ndqd1RW0O9thxEVsG7uq?p=preview
i found the same issuse in chosen's github :https://github.com/harvesthq/chosen/issues/2779.
look like i need to "trigger("chosen:updated")" and how can i trigger this event in angular?

Hi @ChangYinShung,
You are in the right track;
It was missing the ng-click method:
ng-click="ClearOption()">
https://plnkr.co/edit/sLYK5hhc9F6yBaglyPa1?p=preview


Added response to exception

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Error handling has been re-written, and I've included this update.


Update dependency on @io_bazel and create new jars

Please address the buildifier warnings (you can see them under buildkite/skydoc findings below)


modem: fix socket descriptor leak

z_free_fd() is called twice then you close(). For example in ublox sara r4 driver offload_close() calls  modem_socket_put() where z_free_fd() is called first time. Then this same function is called another time in socket.c in z_impl_zsock_close() after this function has called offload_close() in ublox sara r4 driver. This causes socket descriptor leak.
Fixes #26819
Signed-off-by<EMAIL_ADDRESS>

peltsu changed the title ~fix modem socket descriptor leak~ modem: fix socket descriptor leak

Unfortunately github does not propagate changes in PR description to the actual commit. You will need to force push a new version of the patch.

@peltsu sorry for long delay. The signed-off-by line needs tweaking, the sanitychecker now complains about
Error: See https://docs.zephyrproject.org/latest/contribute/#commit-guidelines for more details

a4f50ed8df92d70c52dd890a19f25984b48d4751: author email (Akseli<EMAIL_ADDRESS>needs to match one of the signed-off-by entries.
a4f50ed8df92d70c52dd890a19f25984b48d4751: author email (Akseli<EMAIL_ADDRESS>does not follow the syntax: First Last <email>.
Error: See https://docs.zephyrproject.org/latest/contribute/#commit-guidelines for more details


deprecated upload-artifact

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v1. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Solution:
Change 'v1' to  'v3'  here: https://github.com/chtrembl/azure-cloud/blob/59efd9e011d3c11d18ee5d8c32f6981600133c52/.github/workflows/petstoreapp_ci_cd_to_appservice.yml#L43
I tried to create a pull request but was not able to so opened this under Issue. Thanks for this project.

I also have the same issue. I get the same error when I click "Run workflow" in Actions. I am assuming this is why pushing changes to my repository doesn't trigger Actions.

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v1. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Solution: Change 'v1' to 'v3' here:
https://github.com/chtrembl/azure-cloud/blob/59efd9e011d3c11d18ee5d8c32f6981600133c52/.github/workflows/petstoreapp_ci_cd_to_appservice.yml#L43
I tried to create a pull request but was not able to so opened this under Issue. Thanks for this project.

There is a step that is kind of easy to miss. You can delete the "Upload Maven build artifact" task and that allowed me to run the workflow without error. Unfortunately my GitHub Actions still isn't being triggered when committing and pushing. Any ideas on why that may be?

Thanks all, just updated. This upload is really just for academic purposes to view/download the artifact etc... Hope you enjoy the project.


Tip4commit (receiving BTC for PRs)

Creating typings from existing plain Javascript libraries is really time consuming (plus adjusting jsdoc to the definition as well), and people would be happy to receive some 'tips' for creating those typings IMHO (I do because I need everything Typescript now, it's my mania).
https://tip4commit.com/github/borisyankov/DefinitelyTyped

the bountysource is pretty active already, there should be a tight integration in the repo here
https://www.bountysource.com/teams/borisyankov-definitelytyped/issues?tracker_ids=303325


case data and demographics rendering of case

Doing small incremental changes to display components and associated unit tests, will finish the integration tests after the component is complete.

 Page to display a full case details


Update results table and fix frontend formatting

Updating the Texera UI display for the results table with enhanced readability with larger columns and adding scroll bars. Also displaying message when no results are shown in empty results panel. Fix formatting for frontend, which was missing in the initial pull request.

Before running with empty results panel:

After running and displaying the results table:

Per our discussion in meeting today:

show the “result” frame even if there is no result of an operator
In the “result” frame, use two different text to indicate “no result” vs “empty result set”
For the two scroll bars of the table, see if we can get rid of the outer scroll bar.


Fix auto-generated js variable names

Tested fix in colab; will merge pending travis tests.
It would be nice to properly test the svelte stuff so we can catch things like this in the future, but not sure exactly how to do so. Headless chrome?

Pull Request Test Coverage Report for Build 112

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.182%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lucid/scratch/web/svelte.py
0
1
0.0%

Totals

Change from base Build 110:
0.0%

Covered Lines:
930

Relevant Lines:
1449

💛  - Coveralls

Pull Request Test Coverage Report for Build 112

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 64.182%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lucid/scratch/web/svelte.py
0
1
0.0%

Totals

Change from base Build 110:
0.0%

Covered Lines:
930

Relevant Lines:
1449

💛  - Coveralls

Looks good!