Doesnt work with mcc-island

It breaks with mcci, I can't join the server with this mod installed

Hello! I just tested it, and it seems to work fine... Can you describe what's wrong more specifically? What's your Minecraft version?

Does it crash your Minecraft when you log on the server? Or the server kicks you because it fails to apply the pack?

Does the server kick message look like this by any chance?

Minecraft version 1.20.1, yea I got that error message, It happened when I logged onto the server and hopped off and restarted my minecraft. It only happened after a few times. The issue was not a crash, but I couldn't log onto mcci cuz that kick message. It worked fine before that. Sorry for the lack of information in my first comment :\

Is this option set as "Enabled"?

Yea, and if I don’t enable it than it will ask in game to enable it and kicks after that

Huh, thats weird... I suppose you didnt change the mod's config?
I have 2 theories on what could be wrong:

Downloaded zip file got corrupted
Mod's config got corrupted

Can you send me the mod's config? (.minecraft/config/rptweaks.properties)

I don't have a config for this mod apparently, it didn't make one

Hmm, try deleting the config, and if it stops working again, please send me the logs

error with logging into mcci
Connecting to play.mccisland.net, 25565
net.minecraft.class_1066
Netty Client IO #6
.minecraft\server-resource-packs\f27e50e9b8ef6286d1167409de3ccf33aae49361 matching requested hash a703a5ce8051e8926bbd1d7bef6397119f7a6357
net.minecraft.class_634
Render thread
Ignoring player info update for unknown player playerid
Netty Client IO #6
.minecraft\server-resource-packs\f27e50e9b8ef6286d1167409de3ccf33aae49361 matching requested hash a703a5ce8051e8926bbd1d7bef6397119f7a6357
deleting config changes nothing
and if you install modmenu it will give this error:
Mod rptweaks provides a broken implementation of ModMenuApi
java.lang.NullPointerException: Cannot invoke "net.minecraft.class_327.method_27525(net.minecraft.class_5348)" because "net.minecraft.class_310.method_1551().field_1772" is null
at me.shedaniel.clothconfig2.gui.entries.BooleanListEntry.(BooleanListEntry.java:75)
at me.shedaniel.clothconfig2.impl.builders.BooleanToggleBuilder$1.(BooleanToggleBuilder.java:101)
at me.shedaniel.clothconfig2.impl.builders.BooleanToggleBuilder.build(BooleanToggleBuilder.java:101)
at dev.drtheo.rptweaks.modmenu.RPTweaksMenu.getModConfigScreenFactory(RPTweaksMenu.java:26)
at com.terraformersmc.modmenu.ModMenu.lambda$onInitializeClient$1(ModMenu.java:75)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at com.terraformersmc.modmenu.ModMenu.onInitializeClient(ModMenu.java:70)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:53)
at net.minecraft.class_310.(class_310.java:468)
at net.minecraft.client.main.Main.main(Main.java:198)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:468)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Mod Menu/Update Checker
Worker-Main-1
Checking mod updates...
net.minecraft.class_310
Render thread
Backend library: LWJGL version 3.3.1 SNAPSHOT
net.minecraft.class_156
Worker-Main-1
Caught exception in thread Thread[Worker-Main-1,5,main]
java.util.NoSuchElementException: No value present
at java.base/java.util.Optional.get(Optional.java:143)
at com.terraformersmc.modmenu.util.ModrinthUtil.lambda$checkForUpdates$4(ModrinthUtil.java:86)
at java.base/java.util.Map.forEach(Map.java:713)
at com.terraformersmc.modmenu.util.ModrinthUtil.lambda$checkForUpdates$5(ModrinthUtil.java:79)
at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

Huh, need to fix the modmenu integration... Try deleting server-resource-packs folder. If the resourcepack got somehow corrupted, deleting the folder might solve the issue.

rptweaks-1.0.1-1.19.3.jar.zip
I wonder if... Try this build (the jar is in the zip file), let me know if it works

It works now thank you so much :D

Gonna get the patched version on modrinth tomorrow :D

Whoops, completely forgot about this, uhhh
I'll update modrinth soon

@OmegaPhoenix637 I'd recommend to re-download the mod from the modrinth page. I fixed the mod menu integration in the release as well.

Okay thank you


[Revert] [ALLUXIO-2233] Update S3A min copy part size.

Reverts Alluxio/alluxio#3928
This causes significant performance overhead for renaming large (~GBs) files in S3. We should make this either tunable or set automatically based on a heuristic in the future.

LGTM

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/11631/
Test PASSed.

Merged build finished. Test PASSed.


Multi-line config comments

Sacred can pick comments for config arguments, but only single lines. The reason is that it shows the comment after the argument on the same line.
It would be nice if it can pick even multi-line comments, so that the comment doesn't have to be a single long line. In such case it print the comment before the argument, the same way it's in the code.
from sacred import Experiment

ex = Experiment('multiline')

@ex.config
def my_config():
    # foo comment
    foo = 1
    # multiline
    # bar comment
    bar = 2

@ex.automain
def main():
    pass

Actual output:
$ python multiline.py print_config
INFO - multiline - Running command 'print_config'
INFO - multiline - Started
Configuration (modified, added, typechanged, doc):
  bar = 2                            # bar comment
  foo = 1                            # foo comment
  seed = 718098747                   # the random seed for this experiment
INFO - multiline - Completed after 0:00:00

Expected output:
$ python multiline.py print_config
INFO - multiline - Running command 'print_config'
INFO - multiline - Started
Configuration (modified, added, typechanged, doc):
  # multiline
  # bar comment
  bar = 2
  foo = 1                            # foo comment
  seed = 718098747                   # the random seed for this experiment
INFO - multiline - Completed after 0:00:00

I agree that multiline comments might be nice. Though I think I'd prefer the format:
$ python multiline.py print_config
INFO - multiline - Running command 'print_config'
INFO - multiline - Started
Configuration (modified, added, typechanged, doc):
  bar = 2                            # multiline
                                       bar comment
  foo = 1                            # foo comment
  seed = 718098747                   # the random seed for this experiment
INFO - multiline - Completed after 0:00:00

Also there should then probably be a way to choose between a short and a verbose version of the config. Maybe the default could be this:
$ python multiline.py print_config
INFO - multiline - Running command 'print_config'
INFO - multiline - Started
Configuration (modified, added, typechanged, doc):
  bar = 2                            # multiline [...]
  foo = 1                            # foo comment
  seed = 718098747                   # the random seed for this experiment
INFO - multiline - Completed after 0:00:00

All of this should not be too hard to implement. It should be enough to modify this function to gather multiple comment lines.

We might want to think about the exact syntax for this. Some cases are obvious, but some other might confuse the users, like discussed in the rejected PEP 258 (https://www.python.org/dev/peps/pep-0258/#attribute-docstrings). If we allow all cases shown below, there are some ambiguous cases if the newlines are omitted. If we just allow the multiline comments with # before the variable, everything should be fine. But, some users might be confused if other documenting styles are not supported.
@ex.config
def config():
    # Single line docstring before the value
    a = 0

    # Long docstring
    # before
    b = 1

    c = 2 # Short docstring in line

    d = 3  # Long docstring in line
    # could be ambiguous if the next value definition follow immediately
    whats_the_docstring_of_this = '?'

    e = 4
    """One-line function-like docstring after the value like PEP 258"""

    f = 5
    """
    Multi-line function-like docstring,
    like in PEP 258
    """

    """Do we allow docstrings with triple qotation marks?"""
    g = 6

Good point. I would be ok with both: only supporting multiline comments before a variable and a more comprehensive solution. But in the latter case I agree that we should be very clear on the supported syntax.


Add support for timedelta in serializers

Had to also add support here on config to the issue`. Because the error would occur when trying to serialize a config.
This is a similar implementation to what we did on core 425. Here we don't need the decoder because this is handled by the _TemplateHandler class. We can't import the common code from taipy-core to avoid circular imports, but it is recommended that we isolate this Enconder/Decoders in only one place to avoid mismatch of functionality between config and core.

Here we don't need the decoder because this is handled by the _TemplateHandler class. We can't import the common code from taipy-core to avoid circular imports, but it is recommended that we isolate this Enconder/Decoders in only one place to avoid mismatch of functionality between config and core.

1 - First, I believe there is some room for improvement in the code design of the TemplateHandler/baseSerializer. While _BaseSerializer is responsible for Config serialization methods
_TemplateHandler is responsible for replacing at runtime a config attribute value by an environment variable. They could share the usage of some new Encoder/Decoder classes that would be responsible for converting each field into a string and revert.
2 - These new Encoder/Decoder classes could be used or eventually extended in taipy-core for the entity serialization.
This is for the future. Hopefully, not for the long term future.


[HTTP Probe] Probe uses HTTP/1.1 instead of HTTP/2.0 when connecting to api.push.apple.com

Describe the bug
I'm trying to probe apple's push API reachability. Target seems to support HTTP/2.0 only.
Docs says that HTTP/2 is enabled by default, but probe have no luck with request.
 http.go:298] [cloudprober.apple_push] Target:api.push.apple.com, URL:https://api.push.apple.com, http.doHTTPRequest: Get "https://api.push.apple.com": net/http: HTTP/1.x transport connection broken: malformed HTTP status code "HTTP/1.x"

As I can see, there is no way to enforce HTTP/2 for specific target. Wish there be an option to do so, like 'enforce_http2'.
We need to set  http.Transport field ForceAttemptHTTP2 to true.
Cloudprober Version
v0.11.7
To Reproduce
probe {
    name: "apple_push"
    type: HTTP
    targets {
      host_names: "api.push.apple.com"
    }

    http_probe {
      protocol: HTTPS
    }

    ip_version: IPV4
  }

Additional context
Some test code to reproduce the problem. Try to uncomment ForceAttemptHTTP2.
package main

import (
	"fmt"
	"net"
	"net/http"
	"time"
)

func main() {

	dialer := &net.Dialer{
		Timeout:   5 * time.Second,
		KeepAlive: 30 * time.Second, // TCP keep-alive
	}

	transport := &http.Transport{
		DialContext: dialer.DialContext,
		//ForceAttemptHTTP2: true,
	}

	client := &http.Client{
		Transport: transport.Clone(),
	}

	resp, err := client.Get("https://api.push.apple.com/")
	if err != nil {
		panic(err)
	}
	fmt.Println(resp.Status)
}

I see that we don't use DefaultTransport which automatically enables ForceAttemptHTTP2. I'll look into it.

Last commit should fix this. It will go out in the next release: v0.11.8.


[DOCFIX] Add masterInfo command in docs

Can one of the admins verify this patch?

ok to test

add to whitelist

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/13571/
Test PASSed.

Merged build finished. Test PASSed.

@aaudiber Thanks very much for your review and advice. I have addressed your comment, and also updated the javadoc in MasterInfoCommand.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/13577/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/13581/
Test PASSed.


chore: reuse existing AppRouter type

Minor update to reuse existing AppRouter type via import.

Thanks for the PR. I agree with the change. Could you add a proper changeset? (delete the existing changeset file, run pnpm changeset and follow the cli instructions)

I'm less familiar with changeset so feel free to correct me if I did anything wrong, but it should be good to go now!
Thanks for the review 😁


feat: Starknet plugin

PR turned into type and import cleanup. Conflicts were happening between bundled and non-bundled types. This is now resolved
Implements scaffold for Starknet plugin that allows swapping.
adds pr title workflow - for sanity and cleanliness

After building and tests, lets merge to keep head clean, then will keep iterating on SN plugin

This seems to have removed all tests. Is there a plan for adding them back? If we want to get into a reliable release path we should have proper test coverage.


LMB-640 | Has many relation to fractie for person

Description
We want to set multiple current fracties for a person. A person can only have one current fractie for a bestuursperiode and bestuurseenheid.
How to test

FInd a person without mandatarissen
Create a new mandataris and set a correct start date for that period
Wijzig the mandataris (fractie) and check if the current fractie for that person has been updated
Create a new mandataris in another bestuursperiode
The person should now have two currentFracties but in a different bestuursperiode

Links to other PR's

https://github.com/lblod/mandataris-service/pull/31
https://github.com/lblod/app-lokaal-mandatenbeheer/pull/183

I believe this PR has been replaced by this one https://github.com/lblod/frontend-lokaal-mandatenbeheer/pull/295?


Run 'git submodule update --init' after clone

To build the repository which has git submodule, we need to update git submodule. To handle this case, execute git submodule update --init after checking out the target repository.
git submodule update --init is safe even if submodule is already updated or no submodule is included.
cc: @spesnova @dtan4

git submodule update --init is safe even if submodule is already updated or no submodule is included.

OK! LGTM :+1:


Instruction in README raises error

% mix help build_dot_zig.gen.c_nif
** (Mix) The task "build_dot_zig.gen.c_nif" could not be found

Are you executing this inside the library itself or do you have another project which uses :build_dot_zig as a dependency? I'm not sure this works in the first case, it's meant to work in the latter

Are you executing this inside the library itself or do you have another project which uses :build_dot_zig as a dependency?

It is using :build_dot_zig as a dependency. the strange thing is that I can run the mix build_dot_zig.gen.c_nif Math math sum/2 multiply/2 command with no problem but the mix help fails


EAD = AAEQ if EAD same for base and future year

I think we need some checks to see if the ead distribution is the same for both analysis years - in which case the aaeq distribution should match the ead distribution. At the moment, these two things do not match after uncertainty.
EAD:

AAEQ:

I think that this issue is related to #798 - there is a frequent difference between base year EAD and mlf year EAD for a given probability step
The three highlighted numbers should theoretically be exactly the same.

This is it. Although there is a small difference - the difference is amplified by the sum of the bin count of base year EAD and the bin count of future year EAD.

The logic in the way that results are obtained stopped making sense when we moved to the quantiles approach for distribution combination. If we are not going to randomly sample EAD distributions then it does not make sense to create an AAEQ distribution - we should just calculate the moments and pass over the paired data (freq, aaeq) to plot that instead of the histogram. This means that the main object of alternative results will change from a histogram to a paired data object.
For now, I'll keep creating a junk histogram so that we're plotting something, but I am going to completely re-wire the way that the results are obtained.

same data different results

@rnugent3 follow up on this one

I'll follow up on this one after I address #798

4hrs -

@rnugent3 Confirm this is fixed and close

The residual difference is much smaller now after a few fixes that were jointly causing the problem. One more fix in making the checks I described above and this issue is complete.


i18n(es): update cli-reference.md

What kind of changes does this PR include?

New or updated content
Changes to the docs site code

Description

Updates cli-reference.md in spanish
Changes an h3 html tag to the markdown equivalent in the english version (cc @delucis @sarah11918 )

Thank you @agustinmulet and @fredoist 🎉


Release for GHC 9.6

Hi @jfischoff, I'm slowing rolling out GHC 9.6-rc1 to my projects, and while it seems like the repository HEAD of postgres-options is compatible with GHC 9.6 (or at least does not emit build errors), the latest version on Hackage has some problems:

src/Database/PostgreSQL/Simple/Options.hs:204:22: error: [GHC-39999]
Error: cabal: Failed to build postgres-options-<IP_ADDRESS> (which is required by
test:entity-test from pg-entity-<IP_ADDRESS>). See the build log above for details.

Error:     • No instance for ‘Alternative (Either String)’
        arising from a use of ‘<|>’
    • In a stmt of a 'do' block:
        parseKeywords url' <|> (uriToptions =<< parseURIStr url')
      In the expression:
        do url' <- maybe (Left "failed to parse as string") Right
                     $ parseString url
           parseKeywords url' <|> (uriToptions =<< parseURIStr url')
      In an equation for ‘parseConnectionString’:
          parseConnectionString url
            = do url' <- maybe (Left "failed to parse as string") Right
                           $ parseString url
                 parseKeywords url' <|> (uriToptions =<< parseURIStr url')
    |
204 |   parseKeywords url' <|> (uriToptions =<< parseURIStr url')
    |                      ^^^
make: *** [Makefile:5: build] Error 1

Do you think a minor release is warranted?

Yeah this is the code that is on Hackage: https://hackage-search.serokell.io/viewfile/postgres-options-<IP_ADDRESS>/src/Database/PostgreSQL/Simple/Options.hs#line-204

Anyways:
diff --git a/postgres-options.cabal b/postgres-options.cabal
index 8f5cdd2..0d71088 100644
--- a/postgres-options.cabal
+++ b/postgres-options.cabal
@@ -22,6 +22,7 @@ library
     , split
     , uri-bytestring
     , generic-monoid
+    , semigroupoids
   default-language:    Haskell2010
   ghc-options: -Wall
                -fno-warn-unused-do-bind
diff --git a/src/Database/PostgreSQL/Simple/Options.hs b/src/Database/PostgreSQL/Simple/Options.hs
index fad9383..eb0e784 100644
--- a/src/Database/PostgreSQL/Simple/Options.hs
+++ b/src/Database/PostgreSQL/Simple/Options.hs
@@ -7,6 +7,7 @@ module Database.PostgreSQL.Simple.Options
   , parseConnectionString
   ) where
 import Data.Maybe (Maybe, maybeToList)
+import Data.Functor.Alt
 import Data.Typeable (Typeable)
 import GHC.Generics (Generic)
 import Data.Monoid.Generic
@@ -201,4 +202,4 @@ parseKeywords x = fmap mconcat . mapM (uncurry keywordToptions <=< toTuple . spl
 parseConnectionString :: String -> Either String Options
 parseConnectionString url = do
   url' <- maybe (Left "failed to parse as string") Right $ parseString url
-  parseKeywords url' <|> (uriToptions =<< parseURIStr url')
\ No newline at end of file
+  parseKeywords url' <!> (uriToptions =<< parseURIStr url')

Looks like an orphan instance got removed in transformers-0.6 https://hackage.haskell.org/package/transformers-<IP_ADDRESS>/docs/Control-Monad-Trans-Error.html#v:-36-fAlternativeEither

@jfischoff Ping. If you would like help maintaining this library I am more than happy to help. This is one of the few packages stopping us upgrading to GHC 9.6, so I'm quite invested in seeing this issue resolved.

I ran into this as well, while upgrading a project to 9.6. I wonder what the workaround would be.

I've dropped Jonathan an email to help maintain, hopefully we can get this released soon :crossed_fingers:


C++20 scan sources for module

Hello!
For proper generating header units from regular header files, there is a switch in MSVC "ScanSourceForModuleDependencies" in the "ClCompile" block which is currently missing from Sharpmake.

Heya! Sharpmake doesn't (yet) support c++20 modules. I'll leave this open till we look into it :)
Thanks!

Any plans or progress on the c++20 modules matter?
Especially the "ForceCreateReferences" switch #146 would be great.

Hey @belkiss - using a direct ping to ask the same question. Any progress made on module support? If not yet, is it on a roadmap anywhere or just sitting in todo status?
Thanks for any insights.

Hey @belkiss - using a direct ping to ask the same question. Any progress made on module support? If not yet, is it on a roadmap anywhere or just sitting in todo status?
Thanks for any insights.

I'm able to use modules right now with dependencies from other projects with this simple change:
https://github.com/ubisoft/Sharpmake/compare/dev...Cheaterdev:Sharpmake:dev#diff-3b4daac922926a117976678caf15dc7f785154add1e9fd2f3eab0eddf6f129d7

I could only confirm what @Cheaterdev did, I am using his patch as-is to make Sharpmake work with c++20 modules in my project with no issues.

Thanks both. For anyone else who stumbles over here you will also want to add the .ixx extension to the project.
(in project constructor):
SourceFilesExtensions.Add(".ixx");
SourceFilesCompileExtensions.Add(".ixx");

Other helpful settings for visual studio:
// "All Modules Are Public" from the VC++ Directories project page
CustomProperties.Add("AllProjectBMIsArePublic", "false");

// PublicModuleDirectories: "Public C++ Module Directories" from the VC++ Directories project page
CustomProperties.Add("PublicModuleDirectories", @"$(ProjectDir)..\Public");

Heya!

Hey @belkiss - using a direct ping to ask the same question. Any progress made on module support? If not yet, is it on a roadmap anywhere or just sitting in todo status?
Thanks for any insights.

Nothing on the roadmap, modules are not something we have investigated yet internally. Note that my time at Ubisoft is coming to an end very shortly, so can't say if that's gonna change.
Thanks to the other contributors for the workarounds!
Cheers

@belkiss: before you go... making a public branch with just this two-liner (literally) would lead to c++20 modules (virtually) free-testing by community - in the mean time... since you are not investigated this topic internally yet

@Cheaterdev I have made a PR in your behalf - I am tired to "manually" add it every time I update the tool ;)
https://github.com/ubisoft/Sharpmake/pull/253


consider enabling trailing commas

Describe the feature you'd like:
trailingComma: 'es5'

Suggested implementation:
Describe alternatives you've considered:
Teachability, Documentation, Adoption, Migration Strategy:
https://prettier.io/docs/en/options.html#trailing-commas

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add marks for including accross docs

This is to be used by documentation in Guide.
It doesn't add extra docs for users.

Used by https://github.com/vmware/repository-service-tuf/pull/254

Codecov Report
Base: 90.56% // Head: 90.56% // No change to project coverage :thumbsup:

Coverage data is based on head (dac0f7c) compared to base (1ea1bcc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   90.56%   90.56%
=======================================
  Files          10       10
  Lines         636      636
=======================================
  Hits          576      576
  Misses         60       60

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

When you use import a part of this document the way you did in vmware/repository-service-tuf#254:
.. include:: ../repository-service-tuf-cli/index.rst
    :start-after: rstuf-cli-admin

this will import everything after the rstuf-cli-admin mark and until it finds a new mark, correct?

You can use the options start-after, end-before for the include directive
See https://docutils.sourceforge.io/docs/ref/rst/directives.html#including-an-external-document-fragment

When you use import a part of this document the way you did in vmware/repository-service-tuf#254:
.. include:: ../repository-service-tuf-cli/index.rst
    :start-after: rstuf-cli-admin

this will import everything after the rstuf-cli-admin mark and until it finds a new mark, correct?

You can use the options start-after, end-before for the include directive See https://docutils.sourceforge.io/docs/ref/rst/directives.html#including-an-external-document-fragment

I read it and it's clear why you added start-after.
My question is don't we need to also and end-before or something like this in order to not import more than we want we do for example:
.. include:: ../repository-service-tuf-cli/index.rst
    :start-after: rstuf-cli-admin-import-targets

I don't see an example where we have used this to check.

I read it and it's clear why you added start-after. My question is don't we need to also and end-before or something like this in order to not import more than we want we do for example:
.. include:: ../repository-service-tuf-cli/index.rst
    :start-after: rstuf-cli-admin-import-targets

I don't see an example where we have used this to check.

We don't need to add end-before because the rstuf-cli-admin-import-targets is the last part of the /repository-service-tuf-cli/index.rst.
But you can use it as well.

Yes, I agree for rstuf-cli-admin-import-targets, but don't we expect we would include the other sections of this document as well?
Why then we add marks for the rest of the document if we don't expect them to be imported?

Yes, I agree for rstuf-cli-admin-import-targets, but don't we expect we would include the other sections of this document as well?
Also, we could add a next section after that one tomorrow and we should not forget to add end-before then.

We don't know yet. We could add rstuf-cli-end-of-file

Why then we add marks for the rest of the document if we don't expect them to be imported?

We add because we use the   notation in the title, which makes the built-in title marks not work properly.
But, we add for all also to be consistent in this file.


Add supoprt for GPT to research from images .png .jpg .jpeg among other documents

Currently supported file formats are: PDF, plain text, CSV, Excel, Markdown, PowerPoint, and Word documents.
.png .jpg .jpeg would be really nice to see here on the list in the upcoming updates!

Can you give examples of what use cases would images support? I assume this would need vision in models? @hemeratrading

even the ability to extract images found from the web search, and include them in the final report would be good - will require vision so the model knows what the image contains, and where to use that

I am sorry for late replay but i thought something like OCR, similar to text just to read images for local document research.
But yes even what @pkandarpa-cs said would be awesome! Thank you for this great app! @assafelovic


How to train swin model on signle machine with 4 GPUs?

When I set the --gpus 4 and --gpu-ids [0,1,2,3], I meet the following error.
File "/home/ahs/anaconda3/envs/swintrans-xiaolin/lib/python3.7/site-packages/mmcv/parallel/data_parallel.py", line 55, in train_step
('MMDataParallel only supports single GPU training, if you need to'
AssertionError: MMDataParallel only supports single GPU training, if you need to train with multiple GPUs, please use MMDistributedDataParallelinstead.

When I set the --gpus 1 and --gpu-ids [0], it works well...

How to fix this Error? Thanks a lot.

Hi, could you post the command you used?

python -m torch.distributed.launch --nproc_per_node=4 tools/train.py --config configs/swin/upernet_swin_small_patch4_window7_512x512_160k_pascalVoc.py --launcher pytorch It seem works.


WIP: Rename struct to schema struct

WIP for issue https://github.com/elixir-ecto/ecto/issues/2091
I am not sure if I should go ahead and rename every instance of struct where it technically means a schema struct?  In this PR I have replaced several instances of struct to schema struct.
However, I haven't touched the variable names used in code. Should I this be also changed? I feel that would make it too verbose but not sure.
Any decision made here needs to be carried to other modules such as Ecto.Repo which also has references to struct.
Please advise.

The changeset is not a good place for doing this change because it actually allows regular structs to be used. Ecto.Repo would be a good place for this though.

Also, we don't need to change all mentions of structs. We just need to have a disclaimer at some points that says something like: "This module (or this function) expects a schema struct, i.e. a struct that is defined via Ecto.Schema".

@josevalim Changeset still needs a schema struct for cast function, IMHO. So I have changed the documentation in 3 places to keep the changes to minimum. Please check.

One last comment and we should be good to go!

@josevalim I have modified the commit as you have mentioned. Please check now.

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


feat: remove babel polyfill package

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

after the three PRs are tested and merged, we can say goodbye to polyfill
Ref #49916
Ref #49915
Ref #49914

Edit: I am hoping by remove it, we won't get error about<EMAIL_ADDRESS>anymore

@Sboonny do not bother resolving any conflicts to this PR. We will tackle this after the renovate PRs are in.


Bundle Error when install with Cocoapods

Hi, if I install the lib via cocoapods, i always have the crash that it cant find the nib for the cell, because it's pointing bundle nil, which is not suitable for cocoapods, hope u can update so that it will check for bundle and load correct nib files

@Tj3n Same issue. Any update?

@Fenil15 I have to use workaround as bring GLCalendarView.xib and GLCalendarDayCell.xib to my main project :/ I think the dev forgot to add resource_bundle in their podfile that's why it never got called


Search for uninitialized object errors

There are multiple places in the code base with uninitialization errors. E.g.: declaring a variable but without a value and then using it later without setting one.

Already did this with the introduction of clang-tidy


Missing files in sdist

It appears that the manifest is missing at least one file necessary to build
from the sdist for version 0.0.8. You're in good company, about 5% of other
projects updated in the last year are also missing files.
+ /tmp/venv/bin/pip3 wheel --no-binary openapi-tester -w /tmp/ext openapi-tester==0.0.8
Looking in indexes: http://<IP_ADDRESS>:9191/root/pypi/+simple/
Collecting openapi-tester==0.0.8
  Downloading http://<IP_ADDRESS>:9191/root/pypi/%2Bf/80b/bd7c93d28b10e/openapi-tester-0.0.8.tar.gz (20 kB)
    ERROR: Command errored out with exit status 1:
     command: /tmp/venv/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-wheel-z6cpb7yr/openapi-tester/setup.py'"'"'; __file__='"'"'/tmp/pip-wheel-z6cpb7yr/openapi-tester/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-wheel-z6cpb7yr/openapi-tester/pip-egg-info
         cwd: /tmp/pip-wheel-z6cpb7yr/openapi-tester/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-wheel-z6cpb7yr/openapi-tester/setup.py", line 10, in <module>
        with open('CHANGELOG.rst') as changelog_file:
    FileNotFoundError: [Errno 2] No such file or directory: 'CHANGELOG.rst'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Version 0.0.8 is an alpha version during development. There is no reason to not be on a 1.x build, so I’m closing this issue. Feel free to open a new one if you have issues with the stable version.

0.0.8 is the latest version you have on pypi...

https://pypi.org/project/django-swagger-tester/, django-swagger-tester 1.0.3 @thatch

Ah, I was using https://pypi.org/project/openapi-tester/ whose homepage redirects to this repo, and only has up to 0.0.8.  I suppose that's abandoned?  Your 1.0.3 passes this check.

You’re right, the project got renamed during alpha. I’ll ping @sondrelg, he’s in charge of PyPi for this project. Might want to mark it as deprecated or delete it entirely.

The old pypi project has now been deleted.


Adding CODE_OF_CONDUCT.md and LICENSE.md

@ramyashreeshetty  I would like to work on this!

@kailashchoudhary11 okay go ahead 🚀


Shift and Ctrl keyup events bug

Keyup events for shift and ctrl keys don't work as intended, other keys are ok though.
Example: https://jsfiddle.net/uem1wkaz/

they do work 😅
You will have to provide more info about what isn't working, like steps to reproduce. Closing for the moment

oooh, now I understand, you meant the keyup event not working!
Let me explain what is happening there, ctrl and shift are modifiers. Therefore the keyup.prevent.ctrl only triggers on a keyup while ctrl is being hold (same for shift).
This should be doable using a key code though. Let me put up the example

For control, you will have to write this:
<global-events
  @keydown.prevent.17="plusOne"
  @keyup.prevent.17="minusOne"
/>


Exported variables reset to their default values in all scene instances when the variable name in the source is changed

Godot version
Godot 3.4.4 and previous versions, Godot 3.5 RC5, Godot 4.0 Alpha11
System information
Win Nidea 765M
Issue description
If the name of an exported variable is changed, the value of this export variable in all instances of this scene are reset.
This can be detrimental to a project since the behaviour of an instance is often set and determent by it's exported variables. This is often missed and only many commits later discovered (if at all), leading to lot's of time wasted on pointless bug hunting.
I often come across people in the community channels going through the same thing. Often the reasons why this happens are not obvious which can lead to lot's of insecurity and confusion, especially for beginners.
Possibly related:
https://github.com/godotengine/godot/issues/43659
https://github.com/godotengine/godot/issues/45337
https://github.com/godotengine/godot/issues/46103 # very similar, however this one is about changing the type, not the name
https://github.com/godotengine/godot/issues/43402
Steps to reproduce

create a main scene
create another original scene
add export variable to original scene
instance original scene in main scene
set exported variable of instances in main scene to unique values per instance
change exported variable name in original scene and save
observe all instances in main scene having their exported variable value reset to default

Minimal reproduction project
Godot 3.X:
export_var_name_change_bug_G3.zip
Godot 4.0 Alpha11:
exported_variable_name_change_bug_G4_Alpha11.zip

That's a necessary design constraint of the whole system, I don't see how it could happen otherwise? If you rename an exported variable, you "break compat" with your own framework and thus the previous name doesn't exist anymore. Existing scenes that have a value saved for the old name won't know what to assign it to and it will be dropped.
Possibly it could show an error dialog when you open or save such a scene and tell you that some_var with value 42 doesn't seem to correspond to any builtin or exported variable, and ask you if you want to assign this value to another builtin or exported variable. But that could be quite tedious and make e.g. opening 3.x scenes in 4.0 a hassle.

Idk what the best solution is for this from the core perspective, I just know that this is quite a massive issue from a user perspective who is not aware about this.
Personally I would want and expect the values of my instanced scenes to stay the same. After all I changed the name in the source scene, not the value. But I also understand what you are saying how Godot currently does not seem to have a way to know or differentiate this name change to someone completely removing an existing exported variable and create a totally new one. How should Godot know one is the same as the other while something else is not?
The only option I can think of right now is by allowing the user to right-click on the exported variable in the Inspector and then click "Rename variable in all it's instances", and then Godot collecting all the files in which this node is used, temporarily store the individual value those individual instances, rename the in the source script file, then apply the temporary stored values to the individual instances variable with the new name.

I don't really see how this is an issue someone with experience in programming etc. would not be aware of, but I could see a reason to pop up a warning when changing a script with "this will make instances of this script lose track of this value/break compatibility", but otherwise this isn't something I have seen ever be something that software or tools really had systems for
But I can imagine a solution as follows, as part of a tool for the editor specifically just to fix/update instances:

Fetch all instances of this script
Load their properties and locate the property being renamed
Write back with the property renamed

This would have to be done specifically from the editor when changing the script as otherwise you could get into really confusing territory by having conflicting renames, for example:

Rename property_a to property_b
Create new property_a
Rename property_a to property_c

If the fixing of this would happen on opening rather than when a command is invoked this would require the editor to know when in this sequence the file was originally saved, or it would rename some original property_a to property_c when they should in fact be property_c, etc.

My suggestion for that if it would be something to implement would be to add a function to ResourceLoader, basically like rename_dependencies but for properties in scripts, which renames any instance of property X in a node/resource which has a script that inherits from a script Y

I think any of those options would be an improvement. Right now this value reset is completely silent. I think at the very least a warning is needed to let users know when they change exported variable names, they will lose the value of this variable in all existing instances. To you and other expert programmers this may be so obvious they have not even be reminded about it. I on the other hand know about all this too well since years (because I have lost a lot of data this way), but I still regularly forget about it and kill my data. This happened so often now I just avoid export variables altogether.

I'm sorry I didn't mean to say it was obvious, I only meant it to say I wouldn't consider it a bug as such

I use Godot C# 3.5.
Yes it is really a problem when you are making a game with a lot of custom resources. At first, I was seeing this custom resource system as an opportunity to gain time by avoiding passing datas by code but  since changing name of exported varaible reset the values, I am now wasting a lot of time with this feature. Also another problem close to this one : when you have an exported enum, if you add a constant to your enum, then all the enum will be disturbed in the custom resources.
I dont know how Godot internally handles this but it seems that this system should work with references rather than with values.

I dont know how Godot internally handles this but it seems that this system should work with references rather than with values.

Are you talking about resources open in the editor currently? Because otherwise I don't see how references matter? Have you looked at how scene and resource files are laid out in the filesystem and how properties are handled?

So as an immediate solution to this for anyone who suffers from this would be to simply rename the properties in the files affected by an external text editor (requires them to be saved in text format .tscn/.tres, but that's the recommended approach if you are using VCS)

My suggestion for a feature would be:

Add a context menu option for export variables, "rename variable" which would rename it in all instances (and possibly in this same script, doing it across all other scripts is far more involved)
Make script editor track all exported variables on most recent save/load and have it warn when one is lost
Have it prompt the user when saving with one of these warnings unresolved, to preclude this being missed
Add a function to the ResourceLoader akin to rename_dependencies taking a `HashMap<Pair<String,String>,String> renaming property X in class Y (or any inheriting from it, could be more involved) to Z

This would be decently complex I think in total but I think most of the underlying steps could be straight forward, my main concern would be that it would require traversing all files in the project as there is no tracking of instances in files from what I know

Are you talking about resources open in the editor currently? Because otherwise I don't see how references matter? Have you looked at how scene and resource files are laid out in the filesystem and how properties are handled?

Maybe I was unclear but I was talking about custom ressources opened in editor. I was not talking about Godot's reference class.

I don't see how references would matter here, the access to properties in the editor operates through the get/set functions and not by having a reference to the property, as far as I know there's no way of doing that, properties in the inspector and in the loaded scene are handled by name

Why isnt it possible to track the properties in the inspector and in loaded scenes by reference instead of by name ?

Firstly a number of types (the builtin primitive types like Vector2/3, Transform2/3D, Basis, etc.) are not handled by reference internally, especially not in GDScript, secondly a lot of properties have special get/set behavior, for example most of the transform related properties in Node3D does some magic on getting and setting, updating dirty transforms etc.
Now one could do this by instream having references to the get/set functions but that again would not work for GDScript
Further there are properties that simply do not have a dedicated get/set function to reference, nor any value to reference, those provided by get_property_list for example, these can only really be managed by using the functions, with these cases you'd also risk running into a ton of dangling references if you for example remove a track from an animation
I'm not well versed in the deep internals of some of this but as I understand it the use of the property name is the only way that works universally, and provides a straight forward single interface for doing this not having to deal with the various ways this would be solved for different types, for example the difference between a type from C++ and one from GDScript, having very different internals
And in the end this would do nothing to remedy this problem, the exported variable vanishes if you rename it
Further doing any kind of automatic resolution of this would cause bugs of its own, consider this:
@export var A : int
@export var B : int

Changing to
@export var B : int
@export var C : int
@export var D : int

How should this be resolved automatically, does the user want to rename A to C, or to D, or delete A and just add C and D?

I see that you work in C# and I haven't touched C# in years and years and perhaps references work differently there

Thanks for your reply, the first part of your answer outperforms my competencies but I can try to answer about the very end :
In your example with exported variables A and B becoming B, C and D, it is imppossible to know how godot should interpret this by only see the beginning and the end of the process, but  does the fact  those changes are made one after one by the user can help ? For example A becomes C first, then it is moved after B... etc...
I dont know if scriptable objects are handled better in Unity.

I mean that's still not reliable, the script editor can't read your mind, what if you delete A, then add C, and then decide to add D to replace A, this is mostly to explain why I think this kind of thing isn't really done much in my experience at least, the risk of misinterpreting the user's intention and making things worse is high

If A is deleted, then A is deleted, there is no problem with that case. Very same for adding C. But if you cut A and paste it, the intended behaviour is that the editor keeps the values you stored before.

 Unless you cut it, save the script, and then paste it, and save again?

I you cut it and paster it nothing happens indeed. If you cut it, build the solution (with Godot C") and then paste it and build it again, then the value is reset.

Like build it in the editor? I haven't used Godot C# so I'm not familiar with the work flow, but why would you do that? What would you expect the engine to do?

Ah, btw, when you cut and paste varaibles in another order, it works ! The values are still there. The only case when it doesnt work is then :

changing variable name of an exported variable
adding or removing a constant in en enum, then the exported enum variable is disturbed

The second is a separate issue #56000
The thing with the cut, build, paste thing is that there's no variable with that name in between, I don't see how that would work, nor why it would be expected to work?

Actually it already works, see my previous post.

Okay! I wasn't sure what you meant by another order

The problem is non-existent if you use a VCS in your project (even offline).
Also there is a proposal that would solve this problem:
https://github.com/godotengine/godot-proposals/issues/3152

The problem is non-existent if you use a VCS in your project (even offline).

I wouldn't say non-existent, as you still need to be tech savvy enough to:

Notice in your diffs that you're losing data
Retrieve it manually before committing / from an old commit when you lost it

But yeah, it helps a lot to recover potential data loss.

Also there is a proposal that would solve this problem:
https://github.com/godotengine/godot-proposals/issues/3152

I had a feeling from the start that this issue should have been a proposal, and indeed there's one. Let's continue the discussion there. (Folks who commented above, feel free to add/summarize your ideas in that proposal.)


🐞 Markdown text of non-conditional elements transforms into a list

Check for existing bug reports before submitting.

[X] I searched for existing Bug Reports and found no similar reports.

Expected Behavior
These elements display a usual - as before.
Current behaviour
In my statblocks I use some properties where "Conditional" parameter is off, and "Fallback" is - by default.
In result, it creates a huge el-ul > ul > li construction inside statblock-markdown class. Also, almost all themes, including the default one, add dot marker before the (even empty!) list element.

         ::marker

Reproduction

Create new statblock;
Add new property into it;
Save changes;
Create a note for your new statblock and go to Reading view.

Which Operating Systems are you using?

[ ] Android
[ ] iPhone/iPad
[ ] Linux
[X] macOS
[ ] Windows

Obsidian Version Check
1.5.3 and 1.5.12
Plugin Version
4.3.3
Confirmation

[X] I have disabled all other plugins and the issue still persists.

Possible solution
I hope it's possible to switch it back to the statblock-markdown > p, for example.

This is a side effect of doing markdown rendering by default. Guess I need to escape this case. Thanks.


Suggestion: option to enforce case sensitive imports

I work on the Node version of the BotBuilder SDK and on more than one occasion we've had MAC users of our SDK complain of module load errors. The reason for that is that Windows is case insensitive with regards to import paths where the MAC is case sensitive. Since we develop our SDK using Windows machines it's super easy for us to introduce an error if we get the case wrong in one of our imports.  We're not setup to be able to run our unit tests on macs so we currently don't have a great way of catching these issue.
I realize this isn't a TypeScript issue but I thought it could be nice to have a TypeScript compiler option that says all import paths should be case sensitive.

Would forceConsistentCasingInFileNames help? https://www.typescriptlang.org/docs/handbook/compiler-options.html

@jwbay does that actually enforce that the casing match the file casing? I read that as ensuring that all file references have the same case. In the early days of TypeScript (pre-1.0) if you had references with different case the file would actually get processed twice.  I assumed that flag was to prevent that. I think you're on the right path though.

Actually, just tried that and it does help.  It's not a perfect solution because it only catches differences in case across imports but it effectively solves the problem so long as you get the case for at least one import correct. Thank you much!

I think this should still be open and considered. If we don't enforce or at least warn about case mismatches in import statements at transpile time, then if we bundle, we may run into issues. E.g. SystemJS does not normalize import paths, so if the TS file says import { X } from "blah/X"; but the path is actually blah/x, this will fail at runtime (which is the worst time, of course).

I actually just ran into this as well.  On my mac I did an import { X } from "Bluebird" accidentally (which runs fine) and then when deployed to an ubuntu system (luckily not prod yet) it threw lots of errors because Bluebird should be bluebird.  Maybe there is a setting we are missing in our setup?


Request with query parameters are getting overided

Welcome! Please use this template for reporting bugs or requesting features. For questions about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox
Library Affected:

workbox-sw
workbox-cli

Browser & Platform:
Test on Chrome 64 for Windows 10
Issue or Feature Request Description:
I was following the Udacity course on Progressive Web Apps, great course btw, and I had to use an alternative endpoint the weather calls. This endpoint, as many, use query params to give the information. I'm using workbox-cli to generate the service worker, and I edit the file following the migration tutorial. Still, when the request are made, they seems to use only the url part of the request to save into the cache, and the query params are being ignored.

I open the app.
The first request is cached for the current city.
I add a second city.
The second request is cached for the second city.
I set in Dev Tools to offline mode
I reload the application
Only the second city is showed (with the right cached data)
A request is made to load the first city.

When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.
// workbox-config.js
module.exports = {
  globDirectory: 'public/',
  globPatterns: ['**/*.{ico,png,svg,html,json,js,ts,css}'],
  swDest: 'public\\service-worker.js',
  runtimeCaching: [
    {
      urlPattern: new RegExp('^https://api\.weatherbit\.io'),
      handler: 'networkFirst',
      options: {
        cacheName: 'weatherData',
      },
    },
  ],
};

Am I missing an option here or something?

Hey @michaeljota
Is there any chance that you try this with the latest stable version of Workbox? (currently 3.6.x)

I'll try, but it won't happen soon as my laptop recently died, sorry.

What you might be seeing is that the Cache Viewer within the Application panel in Chrome's DevTools hide query parameters when you're viewing entries, like so:

The query parameters are being saved with the URL, but they're just not displayed under the "Path" column.
I'm assuming that's it, but if you do end up being able to reproduce a failure scenario, please ping this issue and we can reopen.

@jeffposnick as I explain, if I reloaded the app, just the city added at the latest was being showed. It doesn't have anything to do with Chrome Tool Box.

I'm afraid that I'm not sure what kind of assistance we could provide at this point—it sounds like the issue could be related to your application's logic. If you are still able to reproduce, and can point to a specific deployment of your web app that we could visit and observe the behavior, perhaps we will be able to debug further.


SMS OTP can not be configured as first factor

Flow is tested using below steps:

Create a user. Add a mobile number to him. This number also will be used in the latter stages.
Go to the application and create an app. Then add SMS OTP as the first factor or use it as the second factor.
Then you need to create a Twillo account. Use your email and the mobile number used in step 1.
Then you will have 15.5$ worth sms sending capability. To use this service copy the Account SID, Auth Token, and My Twilio phone number given by Twillo to the Email & SMS configuration in the IS console.
Try to log in to the created app using the user we created in step 1.


Stop retrying by default after a request timeout

Disables retrying requests on TimeoutError by default, exposing a new option retryOnTimeout for those who still wish to use the old behavior.
See https://github.com/elastic/elasticsearch-js/issues/2087.

@ezimuel The transport doesn't have its own changelog, other than on the releases page, but I'll make sure to document this functionality when I update the client to use this change.


Automatically add new manifests to the Jenkins pipeline

Is your feature request related to a problem? Please describe.
In https://github.com/opensearch-project/opensearch-build/pull/461 we generate a new manifest. Add it to the build pipeline.
Describe the solution you'd like
Part of the update modify something that adds the version to the build/test pipeline.

@peternied I don't see where I can add/commit configuration that would, for example, add 2.0 builds. Where's the list of the manifests that we're building?

To do this I think we need to set up a job DSL with pipelineJob that kicks off a job using our Jenkinsfile with a manifest as input. Right now the job is created manually that loads the Jenkinsfile from this repo and invokes it with the 1.1 manifest.

We have too many manual processes around the build at the moment, if we enable more than one at a time it is going to bog ~us~ me down.
When logs are publicly accessible #453 and the public CI instance is available - I'd be happy to support N manifests build because then the primary bottleneck is removed.

Here's a manual version of what we're trying to automate: https://github.com/opensearch-project/opensearch-build/pull/664.

Closed via https://github.com/opensearch-project/opensearch-build/pull/1407


addCircleMarkers radius smaller than 1

Hi, thanks for maintaining leaflet!
I wonder how I might get a better control of the circle radius. Depending on the zoom factor it can get pretty clumpy. How is it possible to get smaller circles, say 1/2 or 1/4 the size? I tried values smaller than 1, but decimal resolution doesn't seem to be possible. Please see example below.

co <- replicate(20, c(-74.04456199608506, 40.68923184725649)) + replicate(20, rnorm(2, .0001, .0001))
m <- leaflet() %>%
  addTiles("https://{s}.basemaps.cartocdn.com/dark_all/{z}/{x}/{y}.png") %>%
  setView(-74.045, 40.689, zoom=14)
m$x$options <- append(m$x$options, list("zoomControl"=FALSE))
m %>%
  addCircleMarkers(co[1, ], co[2, ], radius=1, color='white')

Hi, and thanks for taking the time to open a bug report in Leaflet.
However, in this repository we only handle bugs in "vanilla" Leaflet. This means that we do not handle bugs which are specific to frameworks such as:

React
Ractive
AngularJS
Bootstrap
Leaflet for R
Joomla
Wordpress
Ionic
Cordova
Vue
Electron
Polymer
TypeScript
D3
Folium
NativeScript
...etc

Please understand that we only have the time and energy to test Leaflet in plain web browsers.
Please try to either reproduce the bug without using any frameworks, or submit a bug to the appropriate repo.

By the looks of it, you're using R, not vanilla javascript.

@IvanSanchez Ah, yes I am working R focused and didn't realize yet that Leaflet actually bases on Java Script. Thanks for taking the time to point me in the right direction.

I have moved this there.

Hi Ivan, Did you figure out how to make the radius smaller?


Prometheus queries return nothing

Hello,
This is the first time that happened to me, everything under the monitoring is in running state but when I query prometheus returns empty results. Grafana also shows empty results. What went wrong?

You need to check Prometheus targets if they are connected to the collectors.

How could I perform a check like this?

Go into Prometheus web GUI, Status -> Targets. They all should be in "UP" state.
Similar to this:

I made a make teardown.
<IP_ADDRESS> is the IP of the master node
192.168.3 and <IP_ADDRESS> are worker nodes
Again the prometheus IP is responding with an "Your connection was interruptedA network change was detected.
ERR_NETWORK_CHANGED" error

Sorry, you need to debug what's wrong in the cluster not the stack.
You should point the URL IP (in nip.io) to the IP your ingress controller runs.


Retry docker login

modify retry to try to get the stdin, then send that stdin each try.
adds test of retrying with stdin

fixes #71
fixes #62

Thank you for opening this pull request @robotdana, this was on my list to look at today so it’s very timely and appreciated!


fix: async.run_command: report error exit code and stderr

I ran into an error like #2733 when opening a project where go was unable to start, and noticed async.run_command didn't report an error at all.
This adds a check for the exit code of the command, reporting that back to the user with stderr output, and changes the existing error check:  jobid -1 is returned when the command can't start at all, and there shouldn't be any stderr output at that point either.  Normally, you could get further detail "errno" style, but i don't see that this is exposed by the job api.
Example after fix:

It's possible merging this will add some insight into the ways people are still running into #2733 - though it doesn't mess with the actual place where mod_cache is nil and emitting that message.

make sense thanks.


loosen regex to fix issue 609

Description
Loosen regex to fall back to anonymous authentication after a failure
Issues Resolved
https://github.com/chef-cookbooks/jenkins/issues/609
Check List

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[ ] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Confirming that this change fixes 609 for me.

This also solved my problem. Does anyone know how to make it work with a ssh key so I can avoid no private key accepted all together? Is that possible?

Thank you for your contribution. I've merged #617 instead of this PR.


#739 - fix(services) - Fix exposed ports

Closes #739
Get real exposed ports (Endpoint) instead of Spec

Thanks @WTFKr0 !


Export distro refactor configuration reading logic

Now it used const hardcode, should read from config file. Can I apply this ticket to fix?

This is getting address globally (see https://wiki.edgexfoundry.org/display/FA/Architecture+Issues+and+Decisions#ArchitectureIssuesandDecisions-ServiceIdentifiers).  You can look at core services for the initial implementation.

thanks all of you, closing this issue


CS lime-158, Wrong Calculation of Collateral Ratio in CreditLine

Description
The borrow function in CreditLine computes the collateral ratio before an _amount is borrowed as follows:
uint256 _collateralRatioIfAmountIsWithdrawn = _ratioOfPrices.mul(_totalCollateralToken) .div((_currentDebt.add(_amount)).mul(10**_decimals));

A simplified version of the above formula with corresponding decimals in square brackets is: (_ratioOfPrices[30] * _totalCollateralToken[x] * 10^30)/(_currentDebt + _amou nt)[y], where x is the decimals of the collateral token and y is the decimals of the borrow token. The result is in other decimals than 30.
Integrations Checklist

[ ]  Have any function signatures changed? If yes, outline below.
[ ]  Have any features changed or been added? If yes, outline below.
[ ]  Have any events changed or been added? If yes, outline below.
[ ]  Has all documentation been updated?

Changelog

Adding correct calculation for collateral ratio.

Event Signature Changes
Function Signature Changes
Features
Events

Codecov Report

Merging #282 (0877e75) into v1-alpha (b4e9cf6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           v1-alpha     #282   +/-   ##
=========================================
  Coverage     38.82%   38.82%
=========================================
  Files            16       16
  Lines          1749     1749
  Branches        323      323
=========================================
  Hits            679      679
  Misses         1070     1070

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e9cf6...0877e75. Read the comment docs.

The borrow function uses a different way to calculate borrowable amount and hence the above logic is not used anymore.


task/180/midi-preset-button-improvements'

Codecov Report

Merging #181 (fc0544f) into main (2559eb8) will increase coverage by 0.27%.
The diff coverage is 89.79%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   77.47%   77.75%   +0.27%
==========================================
  Files          79       79
  Lines        2198     2162      -36
  Branches      363      335      -28
==========================================
- Hits         1703     1681      -22
+ Misses        494      480      -14
  Partials        1        1

Files Changed
Coverage Δ

client/src/components/KeyIcon.tsx
92.85% <ø> (-0.48%)
:arrow_down:

client/src/store/actions/midiActionCreators.ts
72.72% <ø> (+9.09%)
:arrow_up:

client/src/components/PresetButton.tsx
63.41% <83.33%> (ø)

client/src/utils/MIDIMappingClass.ts
54.80% <83.33%> (+1.53%)
:arrow_up:

client/src/utils/MIDIControlClass.ts
65.35% <88.88%> (-1.52%)
:arrow_down:

client/src/components/PresetButton.style.tsx
82.35% <100.00%> (+0.53%)
:arrow_up:

client/src/components/PresetButtons.tsx
97.87% <100.00%> (+0.25%)
:arrow_up:

client/src/constants.ts
54.28% <100.00%> (+1.34%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Replace the placeholder video with level 1 video

This is what level 1 looks like now

Looks good.


feature Enable write into file cache for hdfs writer

Proposed changes
Issue Number: close #xxx
This is the first version implementation of "hdfs write into file cache", which writes data into both HDFS and file cache within the same thread. Currently, there is duplicate code in both the HDFS writer and the upload file buffer. These duplications will be removed in the next refactoring. This version is intended for testing the performance of queries after data import.


Fixes issue where nearby blocks on angles displayed as fog

Fixes #52

Also, keyed off of :transparent attribute, not
"block" name
let (angles) call to only calculate once
As discussed with @oconn, changed transparency
of food and poison to true
Altered test-arena to match new transparency rules

Fixes #52

Just tested it out and it looks great. Thanks man!


[ACL] Update Compute Library to v22.11

Changelog for this version can be found at:
https://arm-software.github.io/ComputeLibrary/v22.11/
cc @leandron @driazati

Thanks @lhutton1 @driazati !


Data validation using database connection

So, I've got everything setup and it's working great with the .env file settings, but I was wondering if it's possible to set L5SimpleFM as the default database connection?
Specifically, what I'm trying to do is to call validation rules on the database using Laravel's Validator class. Eg:
$validator = Validator::make($request->getContent(), [
'company_ref' => 'required|alpha_num|unique:mdl_Companies,company_ref',
]);

But, after following the setup notes, I've found that the validator uses the default connection specified in database.confg which I'm not sure how to configure to be L5SimpleFM?

Hey Sam,
At the moment L5SimpleFM doesn't use Laravel's Eloquent structure, it's a separate database access method.
I couldn't build it into Eloquent itself because behind the scenes Eloquent is using sql statements to query the data and FileMaker's custom web publishing doesn't work with sql.
It may be possible to make FileMaker accessible via Eloquent by implementing the interfaces Eloquent requires within L5SimpleFM, but it's not something I currently have time to explore.
For now I would suggest using the validator statement above minus the rule that requires database interaction:
$validator = Validator::make($request->getContent(), [
    'company_ref' => 'required|alpha_num',
]);

And then within the FileMaker Model class you're using (here I'm assuming it's Company) create a method for the uniqueness check:
namespace MyApp\FileMakerModels; // whatever namespace you keep your FileMaker Model classes in

use App\FileMakerModels\BaseModel;

class Company extends BaseModel
{
    protected $layoutName = 'mdl_Companies';

    public function findCompanyByRef($ref){
        try {
            $result = $this->findByFields(['company_ref', $ref])->executeCommand();
        } catch (\RecordsNotFoundException $e) {
            return false;
        }
        return $result->getRows();
    }
}

Then you could use this method to determine if the company is unique:
if ( $this->company->findCompanyByRef($request->input('company_ref')) !== false ){ // if it's not false, meaning we found a company with this ref
    // error out because we found at least one match
}


Add example Typescript project

This pull request adds the example project provided from VS.
It also adds the resources folder to show file icons.

I think we need to be careful just copying Visual Studio's project template. I tend to avoid copying and pasting templates from Visual Studio. I think we should create our own templates which are not are not exact copies.
How do you run the project so you can see the HTML page? I would be tempted to create an empty ASP.NET project with a single HTML page. That way you could run the project and see the html page and test the JavaScript.
Other problems with the pull request I can see:
You have added a custom startup command which will only work on Linux.
You have added another syntax highlighting and mime type which is different to the existing mimetype and syntax highlighting which is built in to MonoDevelop. Why do we need a separate one?
The project type is a resource but the file template is a just a file. Can we make these consistent? I would just copy the template to the output directory next to the file template.
For the icon resources I would give them a logical resource name in the property window so you do not have put the full resource name in the addin.xml file:
resource="ICSharpCode.TypeScriptBinding.Resources.TypeScript.Template.EmptyFile.png"

So you could use something like the following instead:
 resource="TypeScript.Template.EmptyFile.png"

Looking at the project template that Visual Studio creates they are creating a web application with the project type guids of:
   <ProjectTypeGuids>{349c5851-65df-11da-9384-00065b846f21};{fae04ec0-301f-11d3-bf4b-00c04f79efbc}</ProjectTypeGuids>

This is the same project type guids that MonoDevelop creates for an empty ASP.NET project. Visual Studio also has extra MSBuild targets which build the TypeScript files which we do not support.


Make capa working parrallel for large dataset

What about if I want to run an analysis on a large dataset? scalability? I would like suggest to adding this feature, which will make the analysis faster.
capa -d /path/malware-directory -procs 32 -o /out-dir
-d: input directory (malware smaples)
-proc: number of processes of that would analyst to use
-o: output directory (results)

would you review https://github.com/mandiant/capa/blob/master/scripts/bulk-process.py and see if this fits your needs?

bulk-process
Invoke capa recursively against a directory of samples
and emit a JSON document mapping the file paths to their results.
By default, this will use subprocesses for parallelism.
Use `-n/--parallelism` to change the subprocess count from
 the default of current CPU count.
Use `--no-mp` to use threads instead of processes,
 which is probably not useful unless you set `--parallelism=1`.
example:
    $ python scripts/bulk-process /tmp/suspicious
    {
      "/tmp/suspicious/suspicious.dll_": {
        "rules": {
          "encode data using XOR": {
            "matches": {
              "268440358": {
              [...]
      "/tmp/suspicious/1.dll_": { ... }
      "/tmp/suspicious/2.dll_": { ... }
    }
usage:
    usage: bulk-process.py [-h] [-r RULES] [-d] [-q] [-n PARALLELISM] [--no-mp]
                           input
    detect capabilities in programs.
    positional arguments:
      input                 Path to directory of files to recursively analyze
    optional arguments:
      -h, --help            show this help message and exit
      -r RULES, --rules RULES
                            Path to rule file or directory, use embedded rules by
                            default
      -d, --debug           Enable debugging output on STDERR
      -q, --quiet           Disable all output but errors
      -n PARALLELISM, --parallelism PARALLELISM
                            parallelism factor
      --no-mp               disable subprocesses


proposal to update CMakeLists.txt at top folder

Just suggestion.

I prefer to use static lib. I'm not expecting to run several apps using the same SDL2 shared lib. So shared lib is not useful for me.

If it's clang16 complier, you must disable int-conversion error by set (CMAKE_C_FLAGS "-Wno-error=int-conversion"). I update my commit.


input with yaml or json config

It would be helpful to provide input parser to parse yaml or json config, for high throughput data generation. A similar request was mentioned in #269. I think we can learn from Psi4's input language, and design something fitting better into the model of data generation pipeline. Let's set it a milestone in pyscf 2.0 design.

How about supporting toml?

This feature is implemented in another repo https://github.com/pyscf/pyscfcli
Let's discuss more in that repo

How about supporting toml?

Toml is considered in https://github.com/pyscf/pyscfcli , although not utlizing all features of toml.


[Removal]: Sour Blood Deer

Hotspot Name
Sour Blood Deer
Hotspot b58 Address
11mfacvSSKYdxWCgwDyfuuEGSv8Lo9YkQyKNS7aqisha7paFvg8
Discord Handle
Toxar#5466
Hotspot Manufacturer
Sensecap M1
Removal Reason
As far as I know, I haven't done anything wrong. The hotspot has been running for almost 5 months now with the same setup. I haven't changed or added anything. I have absolutely no clue why I'm on the list.
My parameters are real, same goes for the location. Height is approx right. My antenna gain has included the connector and cable loss.
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
So this is my setup. A sensecap m1 with 10m LMR 400 cable and a Rakwire 8dbi antenna. If there is anything wrong here, I will definitely adjust it and fix it. So I can help out on the PoC and get rewards again.
Also if possible, I would like to know what got me on the list in the first place? So I can prevent this from happening in the future. Thanks.

Hi, after 7 days of receiving no rewards I'm finally receiving HnT again. I'm glad for that, but I still wanna know how I got onto the denylist. Simply to prevent happening again in the future.

After earning again for 12h or so, I'm back on the denylist again. What's going on?

We do not have sufficient evidence to remove these hotspots from the denylist. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.

So how does this work? Someone puts me on the list-> accuses me of fraude or whatever. While I get no chance to prove my innocents? In meanwhile I just need to sit and wait, missing all these helium rewards and not able to take part of PoC?


feat(proto): add appVersion field

This provides a simple field to expose the version of the application
contained in a chart.
Closes #2036

@technosophos Desired behavior question for you, should this expose a .Chart.AppVersion for people to use? I can't get that to work if that is the case.

agree @thomastaylor312, .Chart.AppVersion should be available


revert slashCommandsTable.PNG

Image file slashCommandsTable.PNG was deleted by this commit.
But slashCommandsTable.PNG has referred from docs/source/developer/slash-commands.rst, so it should be reverted.

Thanks @kaakaa! In this commit: https://github.com/mattermost/docs/pull/1356/commits/668860a9f0132d6424a7f71e3cbbcb20b5ab54e0 I replaced the image with a table in reStructuredText, but I incorrectly assumed that it was used only in the one file, not in docs/source/developer/slash-commands.rst too. :(
Can you help to copy that table into slash-command.rst? If you don't have time, let me know and I can do it myself.  You can either modify this PR or close it an create another one, your choice.

Okay, I got it!
I'll try to fix it  and modify this PR soon.


[SDL-0188] Interior Vehicle Data Resumption

Implements #2661
This PR is ready for review.
Summary
SDL-0188 Interior Vehicle Data Resumption feature implementation
CLA

[x] I have signed the CLA

@yang1070, please approve this PR


[CXF-7673] MP Rest Client 1.1 Impl

Includes async method support and tests, updated TCK, etc.
This will still require some changes - particularly in the pom.xml files since the MP Rest Client 1.1 APIs and TCK has not yet been released.
I'm looking for confirmation that my changes in the rt/rs/client module are acceptable - and an overall review of the async functionality.
Thanks in advance!

@johnament I've updated the PR with your changes.  The build is failing because I am using a non-published build of MP Rest Client 1.1.  I really need to get a release candidate out to build against properly... there is still a question on how the async methods should be implemented in MP Rest Client PR 85.

@johnament - I know it has been a while, but could take another look at the changes here?  I've updated them to use public 1.1 API/TCK and I can get the TCK to pass locally - note that I had to use a testng.xml file to work around an issue with URI invocation checking (fixed by MP Rest Client PR 108 ).  Thanks!


Appstudio update test-component-pac-pxtw

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-pxtw-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
26 seconds
build-container

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
15 seconds
inspect-image

✅ Succeeded
32 seconds
clamav-scan

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
13 seconds
optional-label-check

✅ Succeeded
13 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
9 seconds
show-summary

Pipelines as Code CI/test-component-pac-pxtw-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
23 seconds
build-container

✅ Succeeded
15 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
16 seconds
inspect-image

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
15 seconds
optional-label-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
3 seconds
show-sbom

✅ Succeeded
5 seconds
show-summary


Rust formatting fix for templates/mopro-example-app/core

Before the fmt ci was not checking the issues in the templates/mopro-example-app, which resulted in the code not being correctly formatted error when running cargo fmt  --all -- --check.
This PR:

Fixed the code formatting issue.
Added the additional check to the ci to catch similar issues.

This PR's cli CI fails, even though the PR does no breaking changes, rather reordering the code. Do not understand why. Managed to run the same IOS test where the issue occures successfully on my local machine.


Discuss whether or not an ARP may define a policy for a single attribute multiple times, and adjust AttributeReleasePolicy VO accordingly

This issue is imported from pivotal - Originaly created at Mar 8, 2016 by Daan van Renterghem
This could be tackled in the new ARP VO. For now it is backwards compatible thus not eagerly checking whether or not a policy has already been defined for an attribute.

Several options:

if a second policy is discovered, it is merged with the first
as is now: the first policy defined is the policy used
throw an error when adding a policy for an attribute that already as a policy defined.

Unclear to me what the goal/value is of this story. (Thijs Kinkhorst - Sep 11, 2019)


use import.meta.hot in a vitepress plugin

Describe the bug
Trying to implement client server communication in a vite-plugin I'm receiving Property 'hot' does not exist on type 'ImportMeta' just like in #416.
Try to import vite/hmr but it is not exported
but importing vite/client fix it (at least volar and build stop complaining...)
but when I run client I got an error in the import line
https://github.com/emersonbottero/vitepress-plugin-search/blob/flexsearch/src/Search.vue#L4
GET http://localhost:5173/@fs/C:/Users/emers/Source/Repos/vitepress-plugin-search/dist/Search.vue net::ERR_ABORTED 500 (Internal Server Error)
P.S.:
I'm trying to improve the vitepress-plugin-search so it is easy to provide options to the builder and search.
in the current version is hard to add languages for example
Reproduction
press . on my repository within the browser 😁
Steps to reproduce
pnpm i
pnpm build
cd demo
pnpm i
pnpm dev
System Info
System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
    Memory: 6.20 GB / 15.92 GB
  Binaries:    Node: 16.18.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.5 - ~\AppData\Roaming\npm\yarn.CMD    npm: 8.1.3 - ~\AppData\Roaming\npm\npm.CMD
  Browsers:
    Chrome: 106.0.5249.119
    Edge: Spartan (44.22621.746.0), Chromium (106.0.1370.42)
    Internet Explorer: 11.0.22621.1

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I make it work with
import type from "vite/client";
and took a wile to discover
this should be updated in the docs

import.meta.hot intellisense should be set similar to https://vitejs.dev/guide/env-and-mode.html#intellisense-for-typescript. Feel free to update the docs with that info though.

is anyone working on this ? @emersonbottero @bluwy

I don't think so. Feel free to take it!

@bluwy @emersonbottero
Can you guide me on which exact snippet should i update with this import?
A little more context would help me
import type from "vite/client";

I should have created a branch and keep that state there.
while trying to communicate between server and client and when I tried to use https://vitejs.dev/guide/api-plugin.html#client-to-server I needed to add
import type from "vite/client";
so the build stop complaining..
but I didn't implemented , couldn't make it work, my intent was to pass data to the server, the server computed the values and sent it back to the client...
and I would use Client-server Communication and Server-Client communication for that.

@emersonbottero in that case it isnt the solution its just a hack if i am not wrong?

I think we still need better documentation for
The need of import type from "vite/client" in ts files and preferebly an working example of using client/server server/client communication

Shouldn't this fix the issue? I was suggesting to add a similar info of that to the plugin API docs too.


Move the license into its own file

Move the license into its own LICENSE file so it's usable with the Github license API.

Coverage increased (+21.2%) to 95.794% when pulling 1ff3ed87d1084b590a0ac2d7162ada49076d91c2 on rothwerx:master into c712117887375110efde044a93a8cba8bd2c45a5 on paulmillr:master.


Add date format settings

It seems to me that the full date format is not something that everyone wants to see in their notes. For example, just a date is enough for me.
I have added a parameter that will be used by the plugin to display the dataSaved field when rendering the template.
P.S. Do not judge strictly, TypeScript as well as JavaScript are not the most familiar languages for me.

I will merge this to test


Instructions?

Is there instructions anywhere?

Yes, here: https://github.com/IsThisMyRealName/too-many-tokens-online/wiki/How-to-use-Too‐Many‐Tokens‐Online
Hope that helps. If you have any questions feel free to ask.


Get email messages, dom elements and data

First stab at two new api calls. Slightly related to #584

Hey there, @mikob. Thanks for the patch!
First of all: Sorry about the slow response.
Just looking at the code (that means I haven't actually tested any of this yet), I have a few comments and questions:

api.new.get.message_data() is DOM based, but is positioned in a namespace usually reserved for data-based operations.
I can't see a way to reverse-trace data from api.new.get.message_data() back to individual DOM-nodes, or threads. There is no .$el-property nor a .threadId property. Was this a deliberate omission?

I did a quick test in gmail, and from what I can tell, you should be able to extract thread-IDs from the nodes:
        const msgEles = api.dom.visible_messages();
        const ret = [];
        for (const msgEle of msgEles) {
            const idNode = msgEle.querySelector("span[data-thread-id]");
            const threadId = idNode.dataset.threadId;
            // "#thread-f:1638756560099919527|msg-f:1638756560099919527"
            const legacyThreadId = idNode.dataset.legacyThreadId;
            // "16be0868ae18c6a7"

I really think you should add these, along with the element property.
And if you add those, what that message will return is .... a list of visible email-threads, based exclusively on DOM-data!
So how about we drop/inline api.dom.visible_emails(), and just have one function which does everything. And that function could be called  api.dom.visible_emails()?
I think API-wise that would work much better. Opinions?

api.new.get.message_data() is DOM based, but is positioned in a namespace usually reserved for data-based operations.

OK, I thought the dom.* methods were for calls that returned DOM data, not just operated with it. Btw, why do we care if the API works with the DOM as opposed to other means?
Yes, I can combine both methods into api.dom.visible_emails() and add the $el and threadId props.

OK, I thought the dom.* methods were for calls that returned DOM data, not just operated with it.

There's several methods which work on DOM-based content and allows you to interact with it, api.dom.compose probably being the most common in use.

Btw, why do we care if the API works with the DOM as opposed to other means?

I think it matters.
It highlights to an extension-developer if the APIs they invoke depends on the user actually being navigated to a particular part of Gmail, with the associated page DOM.
If we don't signal this somehow, developers may expect these methods to work in contexts which they obviously not will. And IMO that's not a good API-design.

OK, I thought the dom.* methods were for calls that returned DOM data, not just operated with it.

There's several methods which work on DOM-based content and allows you to interact with it, api.dom.compose probably being the most common in use.

Btw, why do we care if the API works with the DOM as opposed to other means?

I think it matters.
It highlights to an extension-developer if the APIs they invoke depends on the user actually being navigated to a particular part of Gmail, with the associated page DOM.
If we don't signal this somehow, developers may expect these methods to work in contexts which they obviously not will. And IMO that's not a good API-design.

Yes, I can combine both methods into api.dom.visible_emails() and add the $el and threadId props.

Great. Make it so!
If you could also update the documentation, not to mention add this new method to the typescript annotations (gmail.d.ts.) that would be great. Let me know if you need help with these.

@josteink how's this?

Hey there. Sorry about the slow response.
This looks pretty good! I still have a few tiny nitpicks, but really, after that I'll be happy :)

the comment // legacy: does not match the content. The comment represents the value found by idNode.dataset.threadId and has little to do with "legacy" IDs as used elsewhere in GmailJS. As such, in its current form it's can be a cause of confusion. Can you replace legacy:  with for instance expected value:  ?
We should apply the same kind of filtering to this thread_id as we did in the api.compose.thread_id()-patch. The value returned from this function should be directly usable in api.new.get.thread_data()! At this point it may be worth extracting the thread-id cleanup-logic into its own function?
We should be explicit about the difference between legacy IDs and "new-style" IDs in our objects. Please create a dedicated property for legacyMessageId, and leave thread_id empty if none can be found there.

If you can make these changes, I promise this will get merged without much further delay :smile:

@josteink how's this?

I've added one final nitpick, and if you fix that one too, I promise that is final.
Thanks for your patience and thanks for a great patch! I'll be happy to bump the version and make a new release for this one :smiley:

You know what... The "improper" legacyMessageId vs legacy_email_id thing was my partially bad. I'll pull in your changes and fix that up myself :)
Again: Thanks for the patch!


SSL support for client-node encrypted communication

Hi,
Is there any plan to add ssl support for all the calls from the client to the cassandra server node?
Thanks,

FYI this has been merged into [1] with all the tests passing BUT hasn't been properly tested yet with production code... so try it and report back here? :-)
https://github.com/bixuehujin/YACassandraPDO/tree/php7

Thanks @simonhf. We used it for production in my previous company it worked great. At that time new DataStax driver for PHP was not out.


workflow to automate generating the musicplaylist

todo: figure out a better way to do this, probably add in func with musicplayer2

no longer needed. see https://github.com/Noah-Jaffe/music for this version


Internals redesign + cleanup

Currently, the internals of spock engine are unclear from misorganized data to unclear naming or lack of clear naming standard.
This leads to an odd access pattern with in data/variables.
Solution:

Provide a Markdown/Text file on naming conventions and other programming conventions.
Remove the usage of contexts in ECS systems and access them directly via global variable.
Remove components that must not be copy constructed and replace them with a component that instead points to it; this allows external allocation outside of flecs. Reason being that if flecs must move a component in memory, it will copy construct a new one, and then delete the old one via its deconstructor; if a components has a memory pool or some heap allocated variable/controller its deconstructor will be called leading to an issue like wild pointers.
Rename "state_t" to a more purposful name such as "internal_t" to mirror that it is internal access only, and make it so that it acts as private interface rather then a "state" only getters and setters structure. This will allow a more clear sense for the resource manager, ECS world, and other misc. data that is in the engine_t interface to be merged or incorperated into it. Leading to an overall increase in structure/data comprehensibility within the project.

solved + refactored.
Commit: #d861f88


Bun 1.1 - Nixpacks Feature Request

Feature request
Bun 1.1.5 is currently the newest version of Bun. Nixpacks currently uses Bun 1.0 which lacks a LOT of features that 1.1 introduced, such as Globs which are a crucial part of the Bun apps I build, like ProBun.
Motivation
I host my apps on Coolify and writing Dockerfiles for each Bun app to use 1.1 is a pain - if Nixpacks supported the newest versions then I wouldn't have to do this. Thank you so much to anyone that sees this.
Contribution
No response

You can get nixpacks to use bun 1.1.4 by adding a nixpacks.toml file to your project -
[phases.setup]
    # https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/web/bun/default.nix
    nixpkgsArchive = 'd05592ea7e9656648093dfe0e817819486bd5054' # https://github.com/NixOS/nixpkgs/commit/d05592ea7e9656648093dfe0e817819486bd5054

You can get nixpacks to use bun 1.1.4 by adding a nixpacks.toml file to your project -
[phases.setup]
    # https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/web/bun/default.nix
    nixpkgsArchive = 'd05592ea7e9656648093dfe0e817819486bd5054' # https://github.com/NixOS/nixpkgs/commit/d05592ea7e9656648093dfe0e817819486bd5054

Thanks. Ill use this for now- hopefully they can add the latest version natively though


Fix MON_IP in the Ceph pod for multinode OCP CI

The Ceph pod is supposed to be single node, single pod, single container. If MON_IP is not passed and computed by the get_pod_ip function, in a multinode context it might return a list of InternalIP addresses. This patch represents an attempt to only support a single IP address from the list and assign it to the mon spawned as first process during the cluster bootstrap.
By doing this we pin the ceph pod on a specific (worker) node using nodeSelector.

recheck

/lgtm
thank you, Tested locally on multinode OCP environment, it works.
make ceph target is only for dev/ci usecase, so I think its okay to pin ceph pod to a particular worker.

/approve cancel

/lgtm cancel

/lgtm
thanks for the update


fix: Read data length from data type

For opaque types we read the data length from the type if read as a byte array
Fixes issue #105

As discussed in the linked issue the underlying issue is that PureHDF writes opaque data in compact format, which is readable by other libraries but apparently PureHDF can't read opaque data in compact format unless explicitly given the length of the data.
This should have no other impacts but maybe there is a better place for this fix.
I've also added a round trip test to catch issues with round tripping opaque data in the future.

Thank you :-) Probably I will be able to have a more detailed look on it on Thursday.

This still does not work for Memory as the way that is constructed doesn't seem to work with anything but single bytes anyway. Not sure if that is tested anywhere right now but I've commented out the relevant test section and added a TODO.

I had a look into the problem and found it to be a more general one and not only related to opaque datasets. I recently implemented the raw mode concept which allows the user to get raw data (byte[] or Memory<byte>) and I created the following unit tests for this feature:

CanRead_Raw_ByteArray
CanRead_Raw_Memory
CanRead_Raw_Span

But those tests always used the method overload which accepts a buffer. When using this overload, the memory dimensions are well defined and the problem does not occur. However the raw mode is also active without the use of that method overload but this code path was not covered by the tests.
I extended the tests to close that gap and replicated the code changes in NativeDataset to the HsdsDataset to keep them similar.
Since the problem is not only relevant for opaque datasets, I had to remove the explicit check for it. Some code has been added to also support the Memory<byte> case.
So I think everything is covered now and ready for merge. Thanks for your efforts! Tomorrow I will work on support for symbolic links and also on further performance improvements and release a new version probably in the evening.


z.input, z.get functions not found with %r

Hi -
I'm getting error messages like:
  <simpleError in eval(expr, envir, enclos): could not find function "z.get">

when accessing the z object under the %r interpreter using an example from the 'R Tutorial' notebook, eg:
%r
z.input("name", "sun")
print(paste0("%html Hello ", z.input("name", "sun")))

Output:
z.input("name", "sun")
<simpleError in eval(expr, envir, enclos): could not find function "z.input">

This is using the recently merged PR into upstream for the rinterpreter (not sure if you want issues recorded here any more ...).
Any ideas what might be going on here?
Thanks,
Piers Harding.

@piersharding The command should be ".z.input()" with a "." before the "z".
If that doesn't work please let me know as soon as you can  There were two interpreters merged at the same time, and I'm concerned that there may be a conflict between them.

That fixed it - thanks very much.  All the examples from the sample notebook had the same problem.
Cheers,
Piers.

It's not a problem, it's a feature ;)
BTW - the .z.show() functions in the demo notebook are no longer present because they're no longer necessary, since the relevant visualization packages now are much simpler to work with.
Feel free to ping me here or on the zeppelin mailing list if you have any issues.
Thanks, Piers.