Add haul and specimen samplesize summary calculation example

Issue
This year BS and GOA stock assessors requested summary tables of:

how many hauls a type of sample (e.g., lengths, otoliths) was collected at and
how many total samples were collected across a survey

In the past, we prepared summary "samplesize" tables with these values (samplesize_nbs.csv and samplesize_ebs.csv in the Bering Sea and possibly by request in GOA/AI(?)) from SQL scripts that relied on RACEBASE and RACE_DATA oracle schemata. Below is an excerpt from samplesize_nbs.csv:

SPECIES_CODE
SPECIES_NAME
COMMON_NAME
YEAR
TOTAL_HAULS
HAULS_W_LENGTH
NUM_LENGTHS
HAULS_W_OTOLITHS
HAULS_W_AGES
NUM_OTOLITHS
NUM_AGES

10115
Reinhardtius hippoglossoides
Greenland turbot
2019
144
6
7
2

3

10115
Reinhardtius hippoglossoides
Greenland turbot
2023
116
2
3
2

3

Solution notes
Rewrite old samplesize scripts to use theGAP_PRODUCTS.AKFIN_* tables
We need to modernize these scripts to use the GAP_PRODUCTS.AKFIN_* tables to ensure that only data from standard hauls that have been approved for stock assessments are incorporated into these summary values (aka make sure all data products match). Note that even after updating these summaries, not all summary calculations will be able to be summarized from the GAP_PRODUCTS.AKFIN_* tables and still require a few reference and data tables in RACE_DATA (especially for calculating the number of lengths that were collected).
Decide on sharing platform** for these summary values
Options:

Add an example recreating old samplesize csv's in the gap_products example documentation

pros: Give users the tools to calculate these summary values themselves
cons: Users would need access to RACE_DATA (not recommended)
notes: I was previously hopeful we could do this and previously advocated for this, but don't think we can/should because it requires access to RACE_DATA tables.

Suggest that users submit an issue to the data-request repo for this

pros: Only a few users request this product and we could then tailor this table to user's needs.
cons: This workflow may lead to redundancy

Create a new AKFIN_SAMPLESIZE (name negotiable) table

pros: All values for all possible summaries are prepared and in one place. Users will not need to calculate values or require access to RACE_DATA tables. This table could additionally be useful for preparing data reports and end-of-year ADFG report summaries.
cons: This becomes another table that has to be created annually.
notes: I think this is the solution I am currently leaning towards (but could be talked away from).

Decide on the table layout (wide or long) and column names

Here I used the prefix N_ for summary values to show that these are count
I included suffixes of _H and _S to say if the value was the number of hauls samples were collected at or total samples that were collected, respectively. Open to suggestions.
N_WEIGHT(_H), N_COUNT(_H),  N_LENGTH(_H), and N_HAUL are redundant to GAP_PRODUCTS.AKFIN_BIOMASS but are included here, at least temporarily, to match with old tables. We could remove these from here or move them from AKFIN_BIOMASS, depending on opinion.

Long (my vote)

Only includes relevant content and no empty/NULL values. Flexible to different summary types.

SPECIES_CODE
AREA_ID
YEAR
N_SAMPLE_TYPE
N

…
…
…
HAULS
#

…
…
…
COUNT_H
#

…
…
…
WEIGHT_H
#

…
…
…
LENGTHS_H
#

…
…
…
LENGTHS_S
#

…
…
…
GENETICS_H
#

…
…
…
GENETICS_S
#

…
…
…
STOMACHS_H
#

…
…
…
STOMACHS_S
#

Wide (similar to old tables)

Clunky and includes empty/NULL values. Each new summary type requires a column.

SPECIES_CODE
AREA_ID
YEAR
N_HAULS
N_COUNT_H
N_WEIGHT_H
N_LENGTH_H
N_LENGTH_S
N_OTOLITHS_H
N_OTOLITHS_S
N_AGES_H
N_AGES_S

…
…
…
#
#
#
#
#
#
#
#
#

Tasklist
### Tasks
- [ ] Choose how these data will be shared (e.g., [documentation example](https://github.com/afsc-gap-products/gap_products/blob/main/content/akfin-api-r.qmd)/[data-request repo](https://github.com/afsc-gap-products/data-requests)/new `GAP_PRODUCTS.AKFIN_SAMPLESIZE` table)
- [ ] Decide on table name (`AKFIN_SAMPLESIZE` is used here, but negotiable)
- [ ] Decide on table organization (wide or long)
- [ ] Decide on column names nomenclature (e.g., prefix with `N_`; differentiate between haul counts (something like `_H` and `_S`, respectively?))
- [ ] Review if the summary values are correct and table coverage is meeting need (e.g., types of samples) is meeting need.

First steps
I've started the summary-tbl-ex branch to work on this issue. I've added some initial code for developing long tables with sharing options 1 (documentation example) and 3 (new GAP_PRODUCTS.AKFIN_SAMPLESIZE table).

Questions:

What is the spatial scale at which these data were provided? Is it all regional estimates or is the idea to provide this by all the spatial scales (stratum, subarea, management area, region)? I think it's regional but just checking to make sure.
How many sample types are there? Shouldn't this table only be restricted to core collections? Special projects outside of the core collection are trickier because I don't think those data are in our database (although I would love to know where they live if so).
What is GENETICS? Is that like for special projects (e.g., eDNA, fin clips, eyeballs, etc.)?
In the wide-example, what is the difference between the N_OTOLITH_* and N_AGES_* fields?
Stomach Data: Is the stomach collection data in RACE_DATA somewhere? Would this table distinguish stomachs scanned at sea by stomach lab folks vs stomachs collected at sea by the stomach collector? Would this table tabulate how many stomachs have been processed either in lab or at sea? And would this include the target number of stomachs? Same questions for otoliths (tabulating target number and/or collected otoliths and/or read otoliths). Wouldn't the food habits lab already have/provide this information somewhere (idk shrug emoji).
6)  I am also leaning towards providing this as a standalone materialized view that is queried along with the other AKFIN tables. It’s a non-standard request but it doesn’t take a whole lot of finagling to query unlike for example GOA_SPLIT_FRACTIONS. Do you think AKFIN would be able and/or willing to accommodate a table like this?
What is the timeline for development on this new table? Do we have a list of folks who have made this request so we can direct their feedback on the new table?

To build on Emily's table example, I would modify it to this:

SURVEY_DEFINITION_ID
AREA_ID
SPECIES_CODE
YEAR
SPECIMEN_TYPE
N_SAMPLE
COUNT

98
99900
10110
2022
LENGTH

98
99900
10110
2022
STOMACH

98
99900
10110
2022
OTOLITH

The “N_” prefix has been our convention when denoting haul-level sample sizes (e.g., N_LENGTH is the number of hauls with length data for a given species_code/year/area_id). N_SAMPLE could be the number of hauls where we collected a particular SPECIMEN_TYPE (one of LENGTH, STOMACH, OTOLITH if we restrict ourselves to core collections). We could then use something like COUNT to denote the number of sampled individuals similar to how we use the COUNT field in GAP_PRODUCTS.CPUE to denote the number of individuals (although currently the description for the COUNT field is "Total whole number of individuals caught in haul." so maybe a synonym of COUNT or we need to generalize the field description).

Responding and summing up from yesterday's discussion:

Regional, but I am open to the idea of other area_ids.
For now, we'll focus on core collections (lengths, otoliths, ages), but in the future it would be great to include other special collections. I've added an issue (https://github.com/afsc-gap-products/data-requests/issues/80) about this so we can try and separately tackle quantifying non-core collections in the data processing working group (or something like it). We should take a look at the new special_collections*  tables in the future_orale google spreadsheet together I just (very quickly) drafted and make sure we would be able to use them for this samplesize table in the future.
In this case, genetics is just an example. For example, we currently collect genetics fin clips (like those noted here but you are right, there are lots of different genetics collections. That column should really be an ID key for any type of collection or special project that collected it.
N_OTOLITHS is how many otoliths were collected on deck during the survey, and N_AGES is how many otoliths were aged by age and growth.
I don't believe (but could be wrong) that the stomach/age data are available on oracle... possibly not even through the stomach/age folk's oracles. We'll need to follow up with them. The best we currently have (to my knowledge) are the .csv's from the stomach deck tablets.
I think AKFIN is ready and happy to take on any data products that we want to give them. Though I think a materialized view for just us could be fine, too, if we go that way.
For now, we have lots of time. Timeline, if we go with this idea, could be to have this done a year from now? I think this table will become more useful and important the more types of collections are summarized in it.
I like your new table design! Seconded.

I am going to backtrack on my response here after thinking about this issue after the discussion here. I now propose that if we restrict this table to just lengths, otoliths, and read otoliths, the table could be kept in a wide format.
This is a draft query to create something that kind of looks like samplesize_nbs.csv and Table 5 in the 2022 Bering Sea Report
This is a preview of the 2022 EBS records of that table:

Yes, I am also jarred by the number of nulls and yes it's not the nicest looking from a database perspective. However, this table would only be treated as a VIEW and works pretty well for summary purposes only so I'm not too miffed on wide vs long here. If the number of quantities of interest was longer (addition of stomachs, genetics, etc.) then that would be a different issue. Additionally but off topic, for AI/GOA purposes the format of this version of the table would be helpful during our otolith collection rule negotiations.
The counts of the lengths are a little bit off if you compare them with the 2022 Bering Sea Report but I commented in the code that the way I queried RACE_DATA.LENGTHS may include hauls with ABUNDANCE_HAUL = 'N', so it's approximate.

Summarizing discussion today between @Ned-Laman-NOAA, @zoyafuso-NOAA, and myself:

Use long form of table

SURVEY_DEFINITION_ID
AREA_ID
SPECIES_CODE
YEAR
SPECIMEN_SAMPLE_TYPES
N_SAMPLE
COUNT

98
99900
10110
2022
1
1
2

98
99900
10110
2022
[length]
3
4

98
99900
10110
2022
[age]
5
NULL

Sample scope

For now, just summarize otolith, length, and age data.
Hopefully, in the near future, we can add

Stomach data with coordination with the stomach group
all SPECIMEN_SAMPLE_TYPES listed in the RACE_DATA.SPECIMEN_SAMPLE_TYPES table/collected by the specimen tablet on deck.

In the far future, it would be great to add

special projects data (https://github.com/afsc-gap-products/data-requests/issues/80; e.g., genetic fin clips, etc.).

New column definitions

SPECIMEN_SAMPLE_TYPES is derived from the RACE_DATA.SPECIMEN_SAMPLE_TYPES table. We would need to add some specimen sample types to this table

Looks great! Thanks for putting this together! But did we decide to use survey_definition_id or area_id? And what's the name of the table? I'm not seeing in oracle, but I could just be missing it.

We did talk about it, I don't know whether we came to a resolution. But SURVEY_DEFINITION_ID should suffice given these summaries are at the region level. For Bering Sea purposes, SURVEY_DEFINITION_ID = 98 will only refer to the EBS+NW area.
It's not in Oracle because it is still a draft and we haven't confirmed it yet. You can

This is now a VIEW in GAP_PRODUCTS. Take a look at it. SELECT * FROM GAP_PRODUCTS.SAMPLESIZE. We should close this issue and create a new one for any future improvements or requests.

This looks great, Zach!
On Thu, Feb 29, 2024 at 3:18 PM zoyafuso-NOAA @.***>
wrote:

This is now a VIEW in GAP_PRODUCTS. Take a look at it. SELECT * FROM
GAP_PRODUCTS.SAMPLESIZE. We should close this issue and create a new one
for any future improvements or requests.
—
Reply to this email directly, view it on GitHub
https://github.com/afsc-gap-products/gap_products/issues/12#issuecomment-1972134909,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANKDWAXUSB3OUZ7ZTKY7JALYV63MXAVCNFSM6AAAAAA7QDVVKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSGEZTIOJQHE
.
You are receiving this because you were assigned.Message ID:
@.***>

--
Duane Stevenson, Ph.D.
Supervisory Fish Biologist
Groundfish Assessment Program
NMFS, Alaska Fisheries Science Center

Looks good

It looks good. My only comment is that should really use (also use?) codes from SPECIMEN_SAMPLE_TYPES is derived from the RACE_DATA.SPECIMEN_SAMPLE_TYPES table (see comment from Jan 9).

I remember this discussion, the issue was that we don't have a sample type id that codes for a length measurement nor do we have a sample type id that distinguishes between a collected otolith and a read otolith. Of course we could add them but I am unsure of what the implications would be w.r.t the infrastructure of the RACE_DATA schema. I get scared when we start thinking about messing around with the RACE_DATA tables.
SELECT * FROM RACE_DATA.SPECIMEN_SAMPLE_TYPES

SPECIMEN_SAMPLE_TYPE_ID
DESCRIPTION

1
Otoliths

2
Scales

3
Otoliths and Scales

4
Scales and Dorsal Fin Spine

5
Dorsal Fin Spine or Ray

6
Opercular Bone

7
Oxytetracycline (OTC) Marked Otolith

8
Length Weight

0
Undefined

9
Vertebra(e)

10
Whole Organism

11
Genetic Tissue and Otoliths

12
Stomach

Regardless, the VIEW as it is currently resolves the initial issue posted. So I think we can close it and then make another issue for maybe improvements to the SPECIMEN_SAMPLE_TYPES table (and that discussion can live there), which could then set up another issue to improve this VIEW.

Aged otoliths are indicated by a record with specimen_sample_type = 1 where age is not null, right? I can't think if a reason we'd want to know about failed ageing attempts; that sounds like age&growth lab data.
If we need a code for "length" as different from "length weight" then we should simply be able to add another line to the list of specimen_sample_types without breaking anything.

I guess stock assessors are interested in the number of aged otoliths whereas we're concerned with that number as well as the total number of otolith collected (regardless if they were aged or not). That latter value is what is presented to the Plan Team Meetings and reported in at least the Bering Sea survey Data Report Tech Memo (not sure if the AIGOA report that as well).
Glad to know that the length cade can be added fairly painlessly.

Then I stand by my original statement. We don't need a code that indicates an otolith was aged in our specimen table lookup. Aged will be indicated by a not null age for an otolith specimen. Look at it this way. We'd need to get the code for "aged" from Age&Growth because there are some otoliths they try to age and fail. We'd have to use their code to distinguish between otoliths they didn't age (null age) and otoliths the failed to age (null age). Maybe this was obvious and didn't need repeating, but in the interest of thoroughness...

Issue Description
Sorry to open this up again, but it looks like the lengths in this table are extrapolated for species with juvenile codes! The code as you have it now works for all species except walleye pollock, Pacific cod, and other species that can employ juvenile codes on deck during data collection.
Filtering the GAP_PRODUCTS.SAMPLE_SIZE table for YEAR = 2024 AND SURVEY_DEFINITION_ID = 98 AND SPECIES_CODE IN (10112, 10110, 21720, 21740) AND SPECIMEN_SAMPLE_TYPES = 'LENGTH' (where 10112 = Kamchatka flounder, 10110 = arrowtooth flounder, 21720 = walleye pollock, and 21740 = pacific cod) returns:

Using essentially what I do for the data report and plan team presentation in R:
# download data ---------------------------------------------------------------------------

locations <- c(
  "RACE_DATA.LENGTHS",
  "race_data.edit_events",
  "RACE_DATA.HAULS", # need for manipulating RACE_DATA.LENGTHS
  "RACE_DATA.CRUISES",
  "RACE_DATA.SURVEYS",
  "RACE_DATA.SURVEY_DEFINITIONS")

for (i in 1:length(locations)) {
  print(locations[i])
  a <- RODBC::sqlQuery(channel = channel, # NOT RACEBASE.HAUL
                       query = paste0("SELECT * FROM ",locations[i],"; "))
assign(x = a, value = paste0(gsub(pattern = ".", replacement = "_", x = locations[i], fixed = TRUE), "0"))
}

# Collect length data ----------------------------------------------------------------

lengths <- race_data_cruises0 %>%
  dplyr::select(cruise_id, survey_id, vessel_id, cruise) %>%
  dplyr::left_join(race_data_surveys0 %>%
                     dplyr::select(survey_definition_id, survey_id, year),
                   by = "survey_id") %>%
  dplyr::left_join(race_data_survey_definitions0,
                   by = "survey_definition_id") %>%
  dplyr::left_join(race_data_hauls0 %>%
                     dplyr::select(cruise_id, haul_id, performance, haul_type),
                   by = "cruise_id") %>%
  dplyr::left_join(race_data_lengths0 %>%
                     dplyr::select(length_type, haul_id, length, species_code, frequency),
                   by = "haul_id") %>%
  dplyr::filter(region == "BS" &
                  !is.na(species_code) &
                  survey_definition_id %in% SRVY00 &
                  performance >= 0 &
                  haul_type == 3) %>%
  dplyr::mutate(species_code = dplyr::case_when(
    species_code == 21721 ~ 21720,
    species_code == 21741 ~ 21740,
    TRUE ~ species_code) ) %>%
  dplyr::group_by(survey_definition_id, species_code, year, length_type) %>%
  dplyr::summarise(frequency = sum(frequency, na.rm = TRUE)) %>%
  dplyr::ungroup()

# Summarize length data -------------------

sample_size_length <- lengths %>%
  dplyr::group_by(survey_definition_id, year, species_code) %>%
  dplyr::summarise(length_count = sum(frequency, na.rm = TRUE)) %>%
  dplyr::ungroup()

Here is what I calculated:

Suggested solution
Option 1: Edit the GAP_PRODUCTS.SAMPLESIZE View table
GAP_PRODUCTS.SAMPLE_SIZE uses the GAP_PRODUCTS.AKFIN_LENGTH table, which has extrapolated lengths, not how many were actually counted, so we can't use that table. We need to use code more similar to that used in the GAP_PRODUCTS.V_EXTRACT_FINAL_LENGTHS table View or, more specifically, insert the code from the GAP_PRODUCTS.AKFIN_LENGTH_NONEXTRAP_OPT2 table I created for option 2.
Option 2: Edit the GAP_PRODUCTS.AKFIN_LENGTH table that feeds the GAP_PRODUCTS.SAMPLESIZE View table
Is if there is a reason we use extrapolated lengths in GAP_PRODUCTS.AKFIN_LENGTH? If not, then I vote for this option!
I suggest we change GAP_PRODUCTS.AKFIN_LENGTH table to show how many were actually counted on deck. If we edit GAP_PRODUCTS.AKFIN_LENGTH, then no further changes to GAP_PRODUCTS.SAMPLESIZE are needed.
I would edit GAP_PRODUCTS.AKFIN_LENGTH with the following code (following something more similar to GAP_PRODUCTS.V_EXTRACT_FINAL_LENGTHS already in the GAP_PRODUCTS Views). I've added the below code as the view  GAP_PRODUCTS.AKFIN_LENGTH_NONEXTRAP_OPT2 in oracle so you can see the table in action (note accompanying GAP_PRODUCTS.SIZECOMP_OPT2 View where FROM GAP_PRODUCTS.AKFIN_LENGTH_NONEXTRAP_OPT2 is listed in the code instead of GAP_PRODUCTS.AKFIN_LENGTH):
SELECT
  F.HAULJOIN HAULJOIN,
  CASE -- make juv codes adult codes
    WHEN C.SPECIES_CODE = 21721 THEN 21720 -- walleye pollock
    WHEN C.SPECIES_CODE = 21741 THEN 21740 -- pacific cod
    WHEN C.SPECIES_CODE = 10116 THEN 10115 -- greenland turbot
    WHEN C.SPECIES_CODE = 10141 THEN 10140 -- Bering flounder
    WHEN C.SPECIES_CODE = 10209 THEN 10210 -- yellowfin sole
    WHEN C.SPECIES_CODE = 10263 THEN 10261-- northern rock sole
    WHEN C.SPECIES_CODE = 21736 THEN 21735 -- saffron cod
    WHEN C.SPECIES_CODE = 22501 THEN 22500 -- Pacific hake
    ELSE C.SPECIES_CODE
  END AS SPECIES_CODE,
  C.SEX SEX,
  SUM(C.FREQUENCY) FREQUENCY,
  C.EDIT_LENGTH LENGTH_MM,
  C.LENGTH_TYPE LENGTH_TYPE,
  C.LENGTH_SUBSAMPLE_TYPE SAMPLE_TYPE
-- get RACE_DATA data
 FROM RACE_DATA.CRUISES A
 JOIN RACE_DATA.SURVEYS S
   ON (S.SURVEY_ID = A.SURVEY_ID)
 JOIN RACE_DATA.SURVEY_DEFINITIONS SD
   ON (SD.SURVEY_DEFINITION_ID = S.SURVEY_DEFINITION_ID)
 JOIN RACE_DATA.HAULS B
   ON (B.CRUISE_ID = A.CRUISE_ID)
 JOIN RACE_DATA.LENGTHS C
   ON (C.HAUL_ID = B.HAUL_ID)
-- connect these data to GAP_PRODUCTS key columns
 JOIN GAP_PRODUCTS.AKFIN_CRUISE E
   ON (E.CRUISE = A.CRUISE
   AND E.SURVEY_DEFINITION_ID = SD.SURVEY_DEFINITION_ID
   AND E.VESSEL_ID = A.VESSEL_ID)
 JOIN GAP_PRODUCTS.AKFIN_HAUL F
   ON (F.HAUL = B.HAUL AND F.CRUISEJOIN = E.CRUISEJOIN)
GROUP BY
E.SURVEY_DEFINITION_ID, -- SD.REGION,
          E.CRUISEJOIN,
          F.HAULJOIN,
          C.SPECIES_CODE,
          C.SEX,
          C.EDIT_LENGTH,
          C.LENGTH_TYPE,
          C.LENGTH_SUBSAMPLE_TYPE

GAP_PRODUCTS.SIZECOMP_OPT2 using `YEAR = 2024 AND SURVEY_DEFINITION_ID = 98 AND SPECIES_CODE IN (10112, 10110, 21720, 21740) AND SPECIMEN_SAMPLE_TYPES = 'LENGTH' comes up with the correct values:

Thanks for the catch and the code @EmilyMarkowitz-NOAA. The current version of the view ultimately pulls from GAP_PRODUCTS.AKFIN_LENGTH which pulls lengths from RACEBASE.LENGTH, so I think that’s why those expanded lengths are in the view.
I kind of tinkered around with this, the advantage of pulling length records directly from RACE_DATA.LENGTHS is that the frequencies are not expanded. I think the drawback might be that the data only go back to 2005, and if so is that okay for the purposes of this view?


Data counter implementation

The functionality of counting how many nodes a data block has visited has been implemented. This information is used in the decompose operation and when composing the feature mask.

Hello @Dreamlone! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file test/unit/data/test_data_info.py:

Line 65:1: W391 blank line at end of file


Homepage requires scrolling

Reaching 'Go to the coding curriculum' button requires scrolling. this should be the case imo

We could adjust the make a BEM modification to the  big breaks class making the margin top 40px and margin bottom 35px. I think it would look better this way.

@supuun can you specify what the problem is and what you want to see happen?

This is what I'm talking about:

the whole page doesn't fit on my laptop's screen

I think that the text size should be decreased or whitespace between the lines should be removed.
Open for beginners.

as far as I'm concerned, the font isn't responsive.

I don't think this should be done, there are other things that we want the user to see too. So @jooji-san please close the issue :)


Document the Indy SDK to Askar Migration process

Signed-off-by: Stephen Curran<EMAIL_ADDRESS>

Let me know what you think of this as a migration document.  It covers both the why and the how -- borrowing heavily from the blog post type article that Alex created, and the process that @WadeBarnes uses in migrating BC Gov instances.
Suggestions welcome!


Object browser with max item selectable

If maximumSelectionSize is set in widgetOptions.pattern_options from plone, widget allows to select the maximumSelectionSize items.
This will need to be merged after this pullrequest:
https://github.com/plone/volto/tree/object_browser_with_selectable_types

@tisto @sneridagh, do you think this can be merged in to the master?
We would need it for some of our projects
Thank you!

@giuliaghisini do you have an example how to set pattern_options? Does that happen in the z3c form interface declaration? Sorry for my ignorance here but apart from the very beginning I never worked with patternslib.
PR looks ok to me. We would just need to resolve the merge conflicts...

@giuliaghisini do you have an example how to set pattern_options? Does that happen in the z3c form interface declaration? Sorry for my ignorance here but apart from the very beginning I never worked with patternslib.
PR looks ok to me. We would just need to resolve the merge conflicts...

Yes!
These are  two examples where we set the number of maximumSelectionSize when declaring a field for contentype:
form.widget(
"a_cura_di",
RelatedItemsFieldWidget,
vocabulary="plone.app.vocabularies.Catalog",
pattern_options={
"maximumSelectionSize": 1,
"selectableTypes": ["UnitaOrganizzativa"],
},
)
form.widget(
"notizie_correlate",
RelatedItemsFieldWidget,
vocabulary="plone.app.vocabularies.Catalog",
pattern_options={
"maximumSelectionSize": 10,
"selectableTypes": ["News Item"],
},
)

@tisto this is ready to merge

@giuliaghisini Can you also add some documentation here? https://github.com/plone/volto/blob/master/docs/source/blocks/editcomponent.md
The ObjectBrowser is documented there. Also, fix the broken format of that document, it's broken at its end.
See https://docs.voltocms.com/blocks/editcomponent/ to see how it's rendered.

added and fixed docs!


fix(coverage): omit explicit-resource-management from runtime test

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#6804  👈
#6802
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


Remove manual redirect and statistics markup

What

Remove the conditional in the manual redirect written into the statistics controller
remove all markup templates associated with statistics in whitehall

Why
The statistics routes have been redirected however locales have not. Eg:

https://www.gov.uk/government/statistics.uk
https://www.gov.uk/government/statistics.bg
https://www.gov.uk/government/statistics.es-419

These locale pages are behaving a bit weirdly when following the usual redirect method so removing the locale conditional from the controller to ensure that the stats page and all its locales redirect to the research and statistics search page gets the work done at least whilst we work out why these redirects are being weird.
Card
No visual changes.

@thomasleese I've updated the commits with some context.
Regarding the comment on a non-English page going to an English page, I have some product insight here. Almost all these translated stats pages have no statistics on them and there are also almost no ways to actually reach these pages anyway. I believe Welsh is the one exception but there are still very few views on this template (20 views in the last 2 weeks, including myself and team members looking at the pages).
The additional points here are that non-English finders are due to be retired anyway and there's a much wider issue around how non-English speaking users find non-English content on govuk which isn't going to be solved by us not redirecting these templates.
I'll updated the PR description with the above.


fix: Correct sign-in page max with and height

Correct sign-in page max with and height
The sign-in page's max width doesn't extend properly. The other pages should also not overflow on default screen height.
Tasks

[x] Fix sign-in page width.
[x] Fix height overflow on normal screen height.

Done ✅


Remove unused build scripts and configuration

Once merged we can delete the gh-pages and prod-pages branches.
Closes https://github.com/GSA/sdg-indicators-usa/pull/990

Part of https://github.com/GSA/datagov-deploy/issues/641


fix: Upgrade from CreateWebLayersSDDraft to getWebLayerSharingDraft

Hopefully, this fixes the issues that @MichaelAGRC has reported with tags being cleared. I tested adding tags and republishing and all tags stuck around.

@MichaelAGRC is going to send me some general tags that he wants to be applied to all of the layers. So once he gets those to me, I'll add them to this PR.

@MichaelAGRC: I've got the Utah, AGRC, SGID, <category> tags working. There's a bug in the tool that causes tags with multiple words (with spaces) to be split up into separate tags so the layer name tag isn't working yet. I've opened a ticket with Esri.


Revert 23 develop

Reverts AudioKit/AudioKitUI#23 until we can figure out how to correct the sound energy for FFTView

Whoops, meant to be for the develop branch.

oh dang

well, now we really need to get this all sorted :)


Support multi lang

[x] Enhancement Request

Hey guys.
Currently we can only override parts of interface text.
"Showing ${first} to ${last} ${this.ofText} ${this.total} entries"
You end up with mixed lang texts and a lot of properties being passed to set these props up.
Does someone know if there's a way to set a lang specific text to the component?
If there isn't, is there anyone working on it?
I could make a PR, but I'd like to know if there's any work in progress.
Ty.

@machadodev the above code only executes if you don't provide your own info function.
you can use your own function for this information instead of passing properties in whatever language you want:
https://xaksis.github.io/vue-good-table/guide/configuration/pagination-options.html#infofn
closing.

My bad.
I'm using v2.21.4
I just checked releases and infoFn is available on v2.21.5.
I'll update it.
Thank you for the quick reply! :)

Ah! Makes sense. 👍


DrawingContext.FillRectangle in Control.Render has offset issues

I've made three controls for this repro since I first observed an issue with tile brushes being offset by one.  All of them are basic controls that inherit Control and override the Render method.

SolidBrushControl - Renders a yellow fill with a blue border over the bounds.
DrawingBrushCheckerboard - Renders a yellow fill with a blue border over the bounds, and then renders a red checkerboard using DrawingBrush.
ImageBrushCheckerboard - Renders a yellow fill with a blue border over the bounds, and then renders a red checkerboard using ImageBrush.

The code for these controls is below.
Current Behavior

You can see in all 5 cases, the blue border renders where the control should be positioned.  In the top 3 cases, the fills are rendering offset about double from the offset of the actual control location, which is very wrong.  In the bottom 2 cases, we surround the custom controls with a Border that renders a black border.  You can see how the fill in those cases is offset by one pixel, which also is wrong.
Expected Behavior
If things were working correctly, the yellow background and red checkerboards would all render in the same bounds as the blue border.
XAML
<TextBlock Text="SolidBrushControl with fixed size:" />
<local:SolidBrushControl Width="100" Height="100" />
<TextBlock Text="DrawingBrushCheckerboard with fixed size:" />
<local:DrawingBrushCheckerboard Width="100" Height="100" />
<TextBlock Text="ImageBrushCheckerboard with fixed size:" />
<local:ImageBrushCheckerboard Width="100" Height="100" />
<TextBlock Text="Border with fixed size surrounding DrawingBrushCheckerboard:" />
<Border Width="100" Height="100" BorderBrush="Black" BorderThickness="1">
	<local:DrawingBrushCheckerboard />
</Border>
<TextBlock Text="Border with fixed size surrounding ImageBrushCheckerboard:" />
<Border Width="100" Height="100" BorderBrush="Black" BorderThickness="1">
	<local:ImageBrushCheckerboard />
</Border>

C#
public class SolidBrushControl : Control {

	public override void Render(DrawingContext context) {
		context.FillRectangle(Brushes.Yellow, Bounds);
		context.DrawRectangle(new Pen(Brushes.Blue), new Rect(0.5, 0.5, Bounds.Width - 1.0, Bounds.Height - 1.0));
	}

}

public class DrawingBrushCheckerboard : Control {

	public override void Render(DrawingContext context) {
		var len = 16;

		var square1Drawing = new GeometryDrawing() {
			Brush = Brushes.Green,
			Geometry = new RectangleGeometry(new Rect(0.0, 0.0, len, len))
		};

		var square2Drawing = new GeometryDrawing() {
			Brush = Brushes.Green,
			Geometry = new RectangleGeometry(new Rect(len, len, len, len))
		};

		var drawingGroup = new DrawingGroup() {
			Children = {
				square1Drawing,
				square2Drawing
			}
		};

		var tileBrush = new DrawingBrush(drawingGroup) {
			AlignmentX = AlignmentX.Left,
			AlignmentY = AlignmentY.Top,
			DestinationRect = new RelativeRect(new Size(2 * len, 2 * len), RelativeUnit.Absolute),
			Stretch = Stretch.None,
			TileMode = TileMode.Tile,
		};

		context.FillRectangle(Brushes.Yellow, Bounds);
		context.DrawRectangle(new Pen(Brushes.Blue), new Rect(0.5, 0.5, Bounds.Width - 1.0, Bounds.Height - 1.0));

		context.FillRectangle(tileBrush, Bounds);
	}

}

public class ImageBrushCheckerboard : Control {

	public override void Render(DrawingContext context) {
		var len = 16;

		var bitmap = new RenderTargetBitmap(new PixelSize(2 * len, 2 * len));

		using (var bitmapContext = bitmap.CreateDrawingContext()) {
			bitmapContext.FillRectangle(Brushes.Red, new Rect(0.0, 0.0, len, len));
			bitmapContext.FillRectangle(Brushes.Red, new Rect(len, len, len, len));
		}

		var tileBrush = new ImageBrush(bitmap) {
			AlignmentX = AlignmentX.Left,
			AlignmentY = AlignmentY.Top,
			DestinationRect = new RelativeRect(new Size(2 * len, 2 * len), RelativeUnit.Absolute),
			Stretch = Stretch.None,
			TileMode = TileMode.Tile,
		};

		context.FillRectangle(Brushes.Yellow, Bounds);
		context.DrawRectangle(new Pen(Brushes.Blue), new Rect(0.5, 0.5, Bounds.Width - 1.0, Bounds.Height - 1.0));

		context.FillRectangle(tileBrush, Bounds);
	}

}

Bounds property includes the Control's offset relative to its parent. It's basically combined VisualTreeHelper.GetOffset and ActualWidth/ActualHeight from WPF.

Sorry, false alarm and you are absolutely correct.  It works fine with new Rect(Bounds.Size) instead.


User attributes for it.yml

This was updated on localeapp - please review your PR to see if there are still changes to be made.

Theirs is better than mine, thanks!


Feature/migrate to mui v4

Changes

Upgrade to material-ui v4 according to the  v3 to v4 migrate Guide
Fix grid spacing issue for migrating API changes.

Testing

all unit tests passed
testing under latest react and react-dom passed.

Coverage decreased (-0.07%) to 77.293% when pulling 390d8067282f46daa27a8f5ce42ca2d99f1ad8f6 on wuhuizuo:feature/migrate_to_mui_v4 into 86deadf48722453db45f68116638dee1c627f9b5 on gregnb:master.

Although I appreciate the effort here, this isn't quite the way I want to handle this. The PR is too large for me to properly review. What I'd like to do is collect any issues that migration causes into a bunch of separate PRs which can be reviewed and merged separately (as well as rolled back if there's an issue). If you'd still like to help with that, I'd be glad to have your help, just submit separate, small PRs for each migration issue and I'll be able to review each.

@gabrielliwerant ok, i will try by best.

@gabrielliwerant made commits pretty by rebase.

Current migration effect for MUI v4 can be found here: https://github.com/gregnb/mui-datatables/pull/1300
I don't see anything additional from this PR for the upcoming version. However, if you notice something please feel from to jump in there.


Implement lifecycle so before the owner is destroyed the dialog dismiss itself

Using the lifecycle we can avoid leaks when the activity is destroyed with an open dialog

This should probably not be in the core module.
It forces consumers of the module to include Lifecycle.

I thought the same, but the implementation of LifecycleObserver needs the OnLifecycleEvent annotation so i did't know how to separate from core

I tried separating all the code into a new module.... i don't have much experience separating things into modules so... probably it will have some errors


Fix file URIs on Windows

What was the end-user problem that led to this PR?
The problem was that file:// URIs were not properly handled on Windows, and those are heavily used by our specs.
What was your diagnosis of the problem?
My diagnosis was that Windows paths do not start with a slash, so we need to add an extra slash to
separate the host from the path in file:// urls. Otherwise "D:" is parsed as the host segment in the URI.
As a consequence of that change, we also need to strip that leading character when using the path segment for those URIs, so that it's a valid file path on Windows.
This change reduces Windows CI spec failures from 429 to 355.
In order to apply this fix for all file URI's in tests, I extracted a helper method and searched and replaced all file:// ocurrences with the method. The diff is big because of that, but I think it works fine.

/cc @hsbt Because he fought against file:// and their different behavior accross platforms/ruby versions recently.
/cc @MSP-Greg @janpio because Windows :)

Sometimes the exisiting code uses file:, sometimes file:// - is this important?
Is there something present to avoid "plain" file URLs being used again? Or would this be caught by a new test failure on Windows?

Sometimes the exisiting code uses file:, sometimes file:// - is this important?

The file:// protocol specification is quite complicated, but in principle both are correct variants. I think the variability used in specs is because the standard library behaves quite differently accross rubies & platforms, I think most likely because of bugs fixed in recent versions. See https://github.com/bundler/bundler/pull/7161#discussion_r282456588.

Is there something present to avoid "plain" file URLs being used again? Or would this be caught by a new test failure on Windows?

Can you clarify, I didn't understand what do you mean.

As I understand the this, both file: and file:// variants are correct. Then, if there's no host, we get a third slash meaning "absolute path starts". On Linux, this is the implicit behavior because absolute paths actually start with a slash, but on Windows it has to be added explicitly. Essentially, file:/// URIs are correct, but the third slash is not part of the protocol.

Is there something present to avoid "plain" file URLs being used again? Or would this be caught by a new test failure on Windows?

Can you clarify, I didn't understand what do you mean.

I effectively answered this myself: If someone introduces a spec change that uses file:// again without the new helper method, this spec will just fail on Windows CI. Correct?

I effectively answered this myself: If someone introduces a spec change that uses file:// again without the new helper method, this spec will just fail on Windows CI. Correct?

Ah, I see. Yes, I'm pretty sure it would fail on Windows :+1:.

PR was rebased and now it doesn't have unrelated changes.
As a side note, I think this can probably be fixed in ruby-core. In my opinion, ruby -e 'puts URI.parse("file:///c:/path/to/file").path' should print c:/path/to/file instead of /c:/path/to/file as it does not.

Check

ping @hsbt since you assigned this to yourself :)

#7215 failed because of varying behaviour of file:// URL parsing on different rubies. That should also be fixed by this PR.

Thanks @hsbt!
@bundlerbot r=hsbt

😂😂
Sincerely -
Higher Commander - DPO
U.S AirForce - Armed Forces in Europe
Unit: 527th - Space ࿇ Aggressor ࿇ Squadron
Ambjoern Skoeld
DPO16G4
Armed Forces of Europe - “EA”
APO/DPO Air/Army
19 juni 2019 kl. 18:38 skrev David Rodríguez<EMAIL_ADDRESS>ping @hsbt since you assigned this to yourself :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.


"Unsaved Saved, exit anyway?" closes app even if user answers no

This means there is a potential loss of data in the query editors. The onClosing event is handled correctly (the Cancel flag is set) but the app still closes.

This was caused by the transition to .NET core.


problem with address length longer than 16 on 64 bits system

Originally reported on Google Code with ID 704
What steps will reproduce the problem?
1.  What do you see instead?
the assembly code of a subprogram

What version of the product are you using? On what operating system?
I am using gperftools 2.4 on a Ubuntu 14.04 64 bits
The compiler is g++-4.9.2

Please provide any additional information below.
I am attaching the program (prog2) that runs with no argument and the profile (profile.prof)

Reported by karlaesva on 2015-08-04 08:45:48

 * *Attachment: [profile.prof](https://storage.googleapis.com/google-code-attachments/gperftools/issue-704/comment-0/profile.prof)*
 * *Attachment: [prog2](https://storage.googleapis.com/google-code-attachments/gperftools/issue-704/comment-0/prog2)*

BTW perl pprof is now deprecated in favor of golang implementation at github.com/google/pprof
Keeping it open though, since I can't get golang implementation to disasm at all.

Ok. Latest version of golang pprof has functional disasm (yay!). Closing the ticket.


Build fails on Arch Linux

Followed the steps of the Readme, and it fails with the following error:
mkdir -p build
ls -lh build/v86_all.js
ls: cannot access 'build/v86_all.js': No such file or directory

I can't reproduce this. It shows the error, but continues compiling the script. Can you try make -i?

Hi!
I had the same issue and "make -i" fixed it. Didn't dig in any further though, let me know if you need more info.
Voicu

Oops.. Missing environment variable. I close this issue. Thanks!


Can't add resource to API imported from OAS with clientCredentials security flow

Description
The following error gets printed when trying to add a resource to an API imported from OAS with clientCredentials flow.
ERROR Error while parsing OpenAPI definition:attribute components.securitySchemes.default.scopes is missing {org.wso2.carbon.apimgt.rest.api.publisher.v1.impl.ApisApiServiceImpl}
Steps to Reproduce

Create an API
Download the API swagger definition
Then change the implicit flow config with client credentials flow config.

clientCredentials:
tokenUrl: https://test.com/token
scopes: {}

-Import the API definition file and create a new API.
-Add a new resource
Affected Component
APIM
Version
3.0.0
Environment Details (with versions)
No response
Relevant Log Output
No response
Related Issues
No response
Suggested Labels
No response

This issue does not apply to the master branch.


Don't 'gem install' dependencies anymore

Instead, package them as real Omnibus Software definitons
\cc @schisamo

Tagging @mwrock because he had a comment about not knowing which version of winrm-transport we pin in the ChefDK.
This won't prevent something else from pulling in winrm-transport as a transitive dependency and getting a different version, but I don't know of anything that does that.

Shouldn't we just push the following software defs up into omnibus-software (since you are already doing that for RuboCop):
config/software/chefspec.rb
config/software/fauxhai.rb
config/software/knife-spork.rb
config/software/knife-windows.rb

We can - I didn't know the correct pattern to follow.  Because other chef workflow specific tools were in omnibus-chef (like inspec, chef-provisioning, chef-vault) I put these here.  I'm hoping you can just tell me the correct thing to do :)

@tyler-ball We should just push everything up into omnibus-software.

@tyler-ball Looks like all of these were missed:

chef-provisioning
chef-provisioning-*
chef-vault
foodcritic
inspec
kitchen-inspec
kitchen-vagrant


Add correct mapping for Alpine's jemalloc

I found this missing mapping for Alpine: libjemalloc2 is used in Debian-based distros, while Alpine simply uses jemalloc.
I'm unsure if this needs a dedicated test, update test_alpine.rb to include jemalloc option, or if this is sufficient. Happy to update the PR with more tests

Good catch!  And feel free to use your own judgement.
I would lean towards not adding a test.  At the moment, the tests are rather time consuming.  The main focus of the tests is that the erb files are rather complicated and it is possible that a fix for one combination of options would break another option -- or even introduce benign but undesirable changes like extra/missing blank lines.
It seems unlikely that adding another alpine mapping would affect other combinations.


Rewriting the Key from the Authorize method when using the createStorageServer

Describe the feature
I am building a tiny sync layer between my client and server using the createStorageServer which is working great! However, I would like to be able to rewrite the request key from the authorize method. This would allow me to namespace the data for each user.
I noticed that there is also the resolvePath method, but this is called before the authorize method, and is synchronous, so I can't use it to rewrite the key.
I ended up using a middleware to authorize and rewrite the key, but I think it would be nice to have this functionality built-in to the createStorageServer.
Example
import { createStorageServer } from "unstorage/server";

const storageServer = createStorageServer(storage, {
  authorize: async (req) => {
   const auth = req.event.headers.get('authorization')
    if (!auth) { throw new Error('Unauthorized') }

    const [type, token] = auth.split(' ')
    if (type !== 'Bearer') { throw new Error('Unauthorized') }

    // now we can verify the token
    const user = await verifyToken(token)
    if (!user) { throw new Error('Unauthorized') }
    const userId = normalizeKey(user.id)

    // rewrite the key
    req.key = joinKeys('user', userId, req.key)

    // or maybe return the new key
    return joinKeys('user', userId, req.key)

  },
});

I would be happy to submit a PR for this if you think it's a good idea.
Additional information

[X] Would you be willing to help implement this feature?

Looking at the code, the key modification should be respected given that we are creating a custom context just for the authorize function.
IMO a PR for this would be good

Thanks for making this issue suggestion. I think it would be nice idea to allow transforming context (key rewrite) but probably we can introduce a new hook that gets called after authorize to allow this (we can create an object to make reusable context)
Feel feee to open a draft PR for this 💯


Fix filename in getstarted doc

Thanks for you contribution.
I upgrade this page, so this pr is no longer needed.


Update expressroute-locations-providers.md

Newport(Wales)+

@ganesr @cherylmc @charwen

Hi @anzaman, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (alzam). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@anzaman : Thanks for your contribution to the Azure documentation! The author, @cherylmc, has been notified to review your proposed change.


IssueInstant check

This PR adds support for a strict check about IssueInstant attributes in the requests and the subsequent responses. An accepted clock skew is configurable with the new clockSkewTolerance setting.
All the changes are backward compatible as the IssueInstant check is an opt-in feature.
All the changes are tested and docs updated accordingly.

Tests are passing => https://travis-ci.org/onelogin/php-saml/builds/593893031

This feature adds a lot of complexity to the toolkit (new settings and new methods for a lot of methods).
If you want to force that an AuthNRequest or a LogoutRequest has a reply in X time, I think you can do that at a high level, just saving the IDs of the request and timestamp and rejecting "expired" responses.
As far as a understand, SAML does not define a valid time between requests and responses.
Also, take in mind that some authentication process with 2FA and biometrics process can take time, so not sure about the convenience of this kind of restriction.

Hi @pitbulk, the new check is not about the time between the request and the subsequent response, but for ensuring that the issue instant of the response in not earlier than the one the request.
Ad suggested in the SAML specifications I introduced a clock skew parameter to allow a tolerance window and avoid false positives.


test: refactor SessionFilterTest by rector 0.18.6

Description
This PR is a refactor for testing using Rector.
See https://github.com/codeigniter4/shield/actions/runs/6641954393/job/18045603644
follow-up https://github.com/codeigniter4/shield/pull/929
Checklist:

[x] Securely signed commits
[ ] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

@kenjis @samsonasik thanks!


Allows users to supply default props to components

It would be neat if users of the plugin could provide their own default props to be used in the components this plugin supplies.
Proof of concept here: https://github.com/NickyMeuleman/gatsby-mdx-embed/tree/default-props
Eg. I want tweets to be dark mode, but don't want to add theme="dark" to every tweet I add.
Instead I provide some default props via my gatsby-config
module.exports = {
  plugins: [
    {
      resolve: "@pauliescanlon/gatsby-mdx-embed",
      options: {
        defaultProps: { Tweet: { theme: "dark" } },
      },
    },
  ],
}

This will merge supplied props with the plugin's defaults.
So the resulting default props would be
theme: "dark"
align: "left"

since align:"left" is a default used by the theme and not overwitten in gatsby-config.
Would you be interested in this feature/me PRing my branch against this one and supplying more default props (branch currently only merges options for CodePen and Tweet)

converted .js files to .ts (initially used method that used gatsby-node and thus didn't support TypeScript) and made a useDefaultProps hook that uses the props passed to the component and if they aren't there, falls back to the defaults (either provided by user or the default of the plugin)

@NickyMeuleman this is a great idea, did you mention it to me before, i'm sure someone did. Yeah please create a PR and we can discuss. Nice work!

Yup. We talked briefly on Twitter where I floated this idea :)


Add Account Region Limitation

[Enter feedback here]
Hi team,

Please help update the doc, as we are also seeing account region is also restricting the deployment. Lots of cx raised case regarding this.
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2be08842-0295-353e-e835-582605f28854
Version Independent ID: 41957b6a-14f7-ddcf-9e8d-f40833bf1fdf
Content: How to deploy Mistral family of models with Azure Machine Learning studio - Azure Machine Learning
Content Source: articles/machine-learning/how-to-deploy-models-mistral.md
Service: machine-learning
Sub-service: inferencing
GitHub Login: @msakande
Microsoft Alias: mopeakande

@Jessieliu111
Thanks for your feedback! We will investigate and update as appropriate.

@Jessieliu111
Thank you for bringing this to our attention.
I've delegated this to content author @msakande, who will review it and offer their insightful opinions.


Accessibility fix

Hi,
I've noticed that nivoSlider does not show any image on IE when Windows is set to High contrast mode.
When in this mode, IE does not show CSS background-images.
You can test it using Control Panel/Accessibility/Display/High Contrast mode.
Hope this helps, and thanks for that plugin.

Is High Contrast mode still about in IE 11 & Edge? The PR is based on old code. If this feature is still in those IE editions, can you update the PR for the new v3.2 base?

Part of #126.


Add Bubble Sort in C++ , Java & Python

Description
Problem - Sort of Array using Bubble Sort in C++ , Java & Python
Examples -
Inout : 3, 1, 8, 6, 5
Output : 1, 3, 5, 6, 8
Inout : 19, 15, 22, 16, 25
Output : 15, 16, 19, 22, 25
Time Complexity  : O(N2)
Space Complexity : O(1)

Sorry this algorithm has been implemented already


🐛 [Bug]: Edit the code after saving, perform other operations, come back to edit the code, the previous code disappeared.

Environment
develop
Version
latest
Version
latest
Link to minimal reproduction
none
Step to reproduce

first: input code。

seconde: close this dialog and do other thing.

third: return to the previous dialog, which is empty.
What is expected
be solved
What is actually happening
No response
Any additional comments (optional)
No response

@WangJueStar After you enter a code in the code editing box, click "保存" to save the code. If you click  "取消" or close the dialog, the code will not be saved.


Add Healthcheck & Variables tests

NOT to be merged before #373
When #373 is merged, make sure to add the helpers in the healthcheck tests and review the unused imports.

Actually remembered that the tests PR need to go to meta-balena.
Let's bolt things down here, merge this and I will put something here too.


Particle systems with the same material should share draw call

Related forum issue: https://forum.babylonjs.com/t/can-2-particle-systems-share-a-draw-call/33548/2

https://forum.babylonjs.com/t/particle-systems-with-the-same-material-should-share-draw-call/52142


Add buffer method

Added buffer: The difference between this and preserve_buffer is that it only goes one layer deep. The primary motivation for this is when we want to basically perform parent but there is no formal parent array and we don't care if we get an array type out of it (sparse arrays are a good example of this).
Added dependencies: SparseArrays and LinearAlgebra. Figured this was fine since they were standard libraries.
Use buffer internally for preserve_buffer: No changes to tests for this to pass, but I wanted to make you aware since last time I did something like this it caused a bunch of upstream errors from ArrayInterface.jl.

See https://github.com/JuliaArrays/ArrayInterface.jl/pull/195


pest control: layout pc widgets

Since runescape widgets aren't layoutable by default, they get consumed by RL widgets.

changed to use the recent layout code

Do you have screenshot?


Color by decreasing vertex degree

Core

Replace default col/row order by decreasing degree order for coloring
Fix color_groups so that it returns groups in the same order as the color numbers (which it didn't before because of unique)
Clarify docstrings in the sparse implementation
Add more tests

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.53%. Comparing base (8aa5bb4) to head (b3848a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   95.13%   92.53%   -2.61%
==========================================
  Files          74       16      -58
  Lines        3929     1782    -2147
==========================================
- Hits         3738     1649    -2089
+ Misses        191      133      -58

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Display swap

Hi,
Looks like Google changed the url since this feature was released. Can you maybe tell me how to implement the display=swap for these fonts?
urls: [
  'https://fonts.googleapis.com/css?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;0,900;1,400&display=swap',
  'https://fonts.googleapis.com/css?family=Nunito+Sans:ital,wght@0,600;0,700;0,800;0,900;1,400;1,700;1,800;1,900&display=swap'
],

I'm referring to 400;0 and 900;1 for example. With Roboto I have a 400;0 and a 400 How does my families: [] need to look like?

Thanks, will give it a try :)

Tried it, with this code. BUt unfortunatly the fonts aren't loading:
webfontloader: {
        google: {
            families: [
              'Roboto',
              'Nunito+Sans',
            ],
            urls: [
              'https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;0,900;1,400&display=swap',
              'https://fonts.googleapis.com/css2?family=Nunito+Sans:ital,wght@0,600;0,700;0,800;0,900;1,400;1,700;1,800;1,900&display=swap',
            ]
        },
    },

try replacing the & in your urls with just &

Didn't help :( Site keeps showing the default font when code above is added.
Do I need to set something in my CSS?

Any idea? :)

@gizburdt As a workaround (and a complete copy/paste fix for your issue), try using the custom example in the README:
webfontloader: {
    custom: {
        families: [
            'Roboto:i3,i4,i5,i7,i9,n4',
            'Nunito Sans:i6,i7,i8,i9,n4,n7,n8,n9',
        ],
        urls: [
            'https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,300;0,400;0,500;0,700;0,900;1,400&display=swap',
            'https://fonts.googleapis.com/css2?family=Nunito+Sans:ital,wght@0,600;0,700;0,800;0,900;1,400;1,700;1,800;1,900&display=swap',
        ]
    },
}

The i<number> and n<number> are quite important to the webfontloader, as this implies the italic or normal - even though it's defined in the url. Trial and error has learnt me this.

Works, thanks!


Fixed ft-mode-download crashing in client side

closes #11
Looking for reviews...

LGTM, thank you for your contribution ♥


UAT Dashboard Approvals

Describe the issue
Dashboard Approvals capability is now available in TEST. A few things to validate:
Approve New Project

[ ] Create New Project (Silver)

[ ] Observe pending Create request on dashboard view
[ ] Receive "New project request" email (What PO/TC will receive)
[ ] Receive "Pending request" email (What Olena/Justin will receive)
[ ] Observe request isn't showing in Github

[ ] Approve Create Project request

[ ] Observe pending Create request is gone from request dashboard view (still shows in All projects view as pending)
[ ] Observe request is now showing in Github (this can take a few minutes for provisioner to catch up.

[ ] Approve PR in GitHub

[ ] Receive "New project request approved" email (What PO/TC will receive)
[ ] Observe new project shows as provisioned on Dashboard

Approve Project Quota Edit

[ ] Edit Project Quota (Created in first step)

[ ] Observe pending Edit request on dashboard view
[ ] Receive "project quota request" email (What PO/TC will receive)
[ ] Receive "Pending request" email (What Olena/Justin will receive)
[ ] Observe request isn't showing in Github

[ ] Approve Project Quota edit request

[ ] Observe pending Edit request is gone from request dashboard view
[ ] Observe request is now showing in Github (this can take a few minutes for provisioner to catch up.

[ ] Approve PR in GitHub

[ ] Receive "project request approved" email (What PO/TC will receive)
[ ] Observe project shows new quota values on Dashboard

Approve Project Description/Contact Edit

[ ] Edit Project Description or Contact

[ ] Observe No pending Edit request on dashboard view
[ ] Check you don't receive "project quota request" email (What PO/TC will receive)
[ ] Check you don't receive "Pending request" email (What Olena/Justin will receive)
[ ] Observe request is showing in Github

[ ] Approve PR in GitHub

[ ] Observe project shows new description/contact values on Dashboard

Reject New Project

[ ] Create New Project (Silver)

[ ] Observe pending Create request on dashboard view
[ ] Receive "New project request" email (What PO/TC will receive)
[ ] Receive "Pending request" email (What Olena/Justin will receive)
[ ] Observe request isn't showing in Github

[ ] Reject Create Project request

[ ] Observe pending Create request is gone from request dashboard view and dashboard view
[ ] Observe request is still not showing in Github
[ ] Receive "New project request rejected" email (What PO/TC will receive) {including potential comments included by Olena/Justin}

Additional Information
Feel free to just poke around and test as much or as little of the above as you would like. I figured there is value in going through all the steps so you can familiarise yourself with the new flow. The only difference to what you will see in production is the GitHub interaction. This will be completed by Justin Pye or Myself in the meantime and eventually will be automatically merged when we are confident the changes don't break anything.
I have noticed that on occasion the Registry notifications have ended up in my Spam folder. This typically occurs when I was doing rapid testing and hitting my inbox with 20-30 emails in a short window of time. I don't expect you to see this, but if you notice an email didn't show in your inbox I'd check the spam before raising the alarm. :)
Definition of Done
This will be complete when Olena and/or Justin H have had the opportunity to review the dashboard approval capability and are happy with how everything flows and operates.

Dashboard Approvals was promoted to PROD: Jun 15, 2021


fix: Fix wrong package name in domain ids

Summary
Fix remotePluginImpl.RootPkgPath that caused the domain id generator to generate wrong plugin names in domain ids..
Does this close any open issues?
Closes #4970

Lgtm


Show command output progressively

I'd like to run our test suite using gulp-run in which case it would be useful to see the output as the test runner progresses. Is there a way to achieve this?

See #27

As of b104831761d7a7914259dfd2bd33be1bfb8dc0c1 you can use verbosity level 3 to see progressive output.
Published as v1.6.8


test.html not being generated

I added
"test": {
    "type": "mocha",
    "source": "./test"
 }

to the config file, which is adding "Test" to the navbar, but test.html is not being created.

It's a little non-obvious, but the default test includes regexp value for config.test.includes is '(spec|Spec|test|Test)\\.(js|es6)$' and for config.test.excludes is '\\.config\\.(js|es6)$'.  If you set config.test.includes to '\\.js$' then likely your tests will be picked up.
The author of ESDoc takes a prescriptive viewpoint trying to enforce uniformity on codebases which you can see with his opinion of how the manual sections are hardcoded. This is similar with the default test regexp values; IE all tests should in in Test.js
Meh I don't exactly agree. The default test regex confused the heck out of me at the beginning too.

@typhonrt that worked; thanks!


Schema Imports

query/schema.graphql
type SimpleStorage @extension("subgraph") {
  id: ID!
  lastSetBy: Bytes
  setBy: [Bytes!]!
}

The syntax for this is currently:
type EthereumQuery @imported_type(
  namespace: "Ethereum"
  uri: "ethereum.web3api.eth"
  type: "Query"
) {
  callView(
    address: String!
    method: String!
    args: [String!]!
  ): String!
}

This can be simplified to something like:
!import { Query } from Ethereum at "ethereum.web3api.eth"

and the schema-composer package can parse and transform this into the final result.
An example of this can be seen here: https://github.com/Web3-API/prototype/blob/a487293a99ec2dafe65fccd9bd739a7758f6216f/packages/schema-binding/src/tests/cases/sanity/input.graphql#L53

This issue is related to: https://github.com/Web3-API/prototype/issues/41

This has been completed in prealpha-dev

This has been completed in prealpha-dev


not sure that the mini theme can support table of content in the blog

I appreciate this hugo-theme, but I'm not sure that this theme can support TOC which I think is very necessary for the writer or reader

I'm not good at html and css

Hi @brettKK , now this theme can support TOC, commit https://github.com/nodejh/hugo-theme-mini/commit/925467c448aac192afd45520cdb95d83bcf67cc1 .
You can set showToc: true  in to enable TOC, this is document: README#Table Of Content

Hi @brettKK , now this theme can support TOC, commit 925467c .
You can set showToc: true in to enable TOC, this is document: README#Table Of Content

i will try it later, thanks for your reply


Tree traversal on binary tree.

I want to implement an algorithm to treverse a binary tree.
First we create root node having value, let 10 . Then, insert node values into the tree (left & right). suppose we insert 20,30, 40,50, 60,70.
Output: Preorder 10 20 40 50 30 60 70
inorder  40 20 50 10 60 30 70
postorder 40 50 20 60 70 30 10
I want add this algorithm in c++
Thus, I request maintainers to allow me to add this algo.
@rudrakshi99 @plazzy99 @nakul-19 @tarun26091999 @OjusWiZard @shreyanspoddar @anjul2000

@rudrakshi99 @plazzy99 please /assign me this issue.

#144


todo: get rid of the function, bad design

https://github.com/zilliztech/knowhere/blob/main/src/common/utils.cc#L75-L87
completely eliminate this function!
Put it inside .train() calls

/assign @cydrain


Availability of intakeOutput table

The intakeOutput table is not currently available in the public dataset. Any idea when will it be available?

The table will be released by the end of this month.
Sent from my iPhone
On 6 Nov 2017, at 18:37, pini <notifications<EMAIL_ADDRESS>wrote:
The intakeOutput table is not currently available in the public dataset. Any idea when will it be available?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/MIT-LCP/eicu-website/issues/37, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAyNSQH1LVLVpHwjBaju9NlOLLVJl1rzks5szuFwgaJpZM4QTCQl.

Hi Again,
The intakeOutput table is still unavailable. Are there any updates?
Thanks!

@piniakiva the data has not yet been released and I'm sorry my earlier estimate was off. We are fitting this work alongside research tasks, so it is difficult to estimate a date, but we still intend to release the data and aim to do this in the coming months (< 2019).

Hi Tom, thank you for providing this resource. I've been using the database for a research project led by a clinician from the Alfred Hospital in Melbourne, concerning urine output. We've found some interesting results using other datasets that we are really keen to replicate with this database, and we need the intakeOutput table to finish the paper - are you able to give us (another) estimate on when this will be available - Omar tentatively suggested a month :)
Thank you very much


[Sprint: 44] XD-2287: Centrally shared ModuleRegistry

This PR does the following:

Rework ResourceModuleRegistry so that it is not tied to java.io.File (contrary to ArchiveModuleRegistry, which is removed in this PR)
Add md5 file generation for uploaded modules
Introduce SynchronizingModuleRegistry which acts as a registry but knows about two delegates: the source (remote) and the target (local). It will do as if it queries the source registry (e.g. hdfs:), but fetch the module bits back to the target registry (which is meant to use file:)
Replace the registry that stores custom modules with such an instance if needs be

General question. The standalone module projects exclude spring-data-hadoop. Does this create a hard runtime dependency even for single node?

General question. The standalone module projects exclude spring-data-hadoop. Does this create a hard runtime dependency even for single node?

I believe so. Maybe we could prevent the hard dependency by hardcoding the HdfsResource class name. I'd really like to see this class expose its path and filesystem though.

squashed and merged


Standings Traversal broken

Now that we have multiple seasons of NFLPool, the Standings traversal is broken when updating to a new season past the first one.
The Standings Service needs to be updated.  It currently looks like:
def get_seasons():
    session = DbSessionFactory.create_session()
    season_row = session.query(SeasonInfo).filter(SeasonInfo.id == '1').first()
    current_season = season_row.current_season

    return current_season

This only returns the current season - the function needs to be re-written to get the matching ID from the season the user clicks on.

This is fixed for the Season standings in commit b11047f9c573af8816dd300904af2a26b6df2b17
However, need to test the player details sub-pages - I have a feeling they're broken based on the way the season is passed to those sub-pages

Looking at the code again, this is fixed and I don't think the player detail sub-pages will be affected as it inherits from the season that is passed.


Support export Otlp for metrics

[x] I have searched the issues of this repository and believe that this is not a duplicate.
[x] I have searched the release notes of this repository and believe that this is not a duplicate.

Describe the feature

https://github.com/apache/dubbo/issues/12497
Users hope that in future versions, metrics will support OTlp export. Currently, tracing has been implemented

ref: https://micrometer.io/docs/registry/otlp

Is there anyone want to do it?i want to try it if no one want do it.

Is there anyone want to do it?i want to try it if no one want do it.

help check this pr  #13902


Test file issue

Thanks for sharing this amazing project!
I have trained ResUnet on BUSI dataset (2D) and it worked well. However, there is an issue with the test file because it requires 3d images. Would you take a look at it?
Also, one suggestion, why don't you split the BUSI dataset to train and test or use k-fold validation since the dataset is small?

Hi! If you look into the function segment_3d_input, you might notice that the arg path_to_image is a directory containing a set of 2D images - I was working on some private video-like data which were unpacked into 2D images. So for the inference, I would suggest using segment_3d_input still, but make path_to_image be some directory containing the images you'd like to get predictions, or make some slight changes to predict on your test set.
I agree that having k-fold would be nice; I actually did it with some other datasets but not having the codes for BUSI in this repository.


Update classifier to read new format of training files in data/WHAM_training_data.txt

Zev;
Thanks much for the recent updates. When evaluating them, ran into the issue that the classifier is looking for the older training data format. This updates the script to match the currently available data.

Thanks for catching this Brad.  I just re-formatted the classifier data.  Sorry.


Is it possible to read qrcode from an image

I use react-native-qrcode-scanner to scan QR-code and it works well, But I need to Read QR-code from the captured image.
Is it possible with QRCodeScanner?

Sorry, unfortunately, this is not supported currently! But it's definitely a pretty good case to build a feature to support that. Then, in order to make it possible in the future as this is a good feature suggest to be built, I've created this another issue #265 to work on it.
I'm not sure if you already did find a workaround to make it work, but in this case, it would be great to have this as an example of workaround to share with someone else looking for the same thing, and in the case of you didn't get it yet, no worries, I'll try to find any workaround to support that in advance. So, in the meanwhile, we’ll gonna share it in the issue of this feature request in. Until there, we won't be able to support this feature officially.


Experiencing difficulties running npx expo prebuild -p ios command with Customerio-Expo-Plugin

Hello there,
I'm experiencing difficulties while trying to execute the npx expo prebuild -p ios command with the customerio-expo-plugin.
I carefully followed the steps outlined in the Getting Started Guide, but unfortunately, I'm still encountering an error.
✔ Config synced ⚠  Something went wrong running pod installin theiosdirectory. Commandpod install` failed.
└─ Cause: Unable to integrate the following embedded targets with their respective host targets (a host target is a "parent" target which embeds a "child" target like a framework or extension):

C2S (true) and NotificationService (false) do not both set use_frameworks!.`

To provide a more comprehensive view of what's going on, I've attached a screenshot below.

It would be great if anyone could provide some guidance on this matter or suggest potential solutions.
Thanks in advance for your help!

Hi @oallanmendes
You are getting this error because your main target sets use_frameworks to static. To fix this, you need to set ios.useFrameworks to static for customerio-expo-plugin in app.json or app.config.js. Here is an example:
"plugins": [
      [
        "customerio-expo-plugin",
        {
          "android": {
            ...
          },
          "ios": {
            "useFrameworks": "static",
            "pushNotification": {
              ...
            }
          }
        }
      ],
    ...

the error happens when I initialize the sdk
import React, {useEffect} from 'react';
import { CustomerIO, CustomerIOEnv, Region } from 'customerio-reactnative';
const App = () => {
useEffect(() => {
const env = new CustomerIOEnv()
env.siteId = "YourSiteId"
env.apiKey = "YourAPIKey"
// Region is optional, defaults to Region.US.
// Use Region.EU for EU-based workspaces.
env.region = Region.US
CustomerIO.initialize(env)
}, [])
IN App.js
@xtreem88

Closing due to inactivity. Please, comment back if there are still problems you're encountering.


ksp-allow-mysql-files

The same file name exists. If it is a different policy then please reraise the PR with a different name. @rohitrishim


Minor fixes

Added sample .yaml for nav2 tutorials
Fixed tables
Fixed TODO's

@tonybaltovski Fixed.


Rename field_masking_span to span_field_masking

Is your feature request related to a problem? Please describe.
According to customer confusion from this issue #1299
In Span Queries group, queries are like span_containing span_first span_within etc. Currently the field_masking_span query is the only one that end with _span instead of starting with span_.
Describe the solution you'd like
Rename field_masking_span to span_field_masking.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
https://github.com/opensearch-project/OpenSearch/blob/996d33adb22ac6a523962166f3677f8dc6ac9c1f/server/src/main/java/org/opensearch/index/query/QueryBuilders.java#L413

PR merged. Closing this issue.


Add vuetable in devices

Add vuetable in devices

VueTable is already included globally. An even then we are using GwBrowse instead of VueTable directly. Look at the other tables within Settings.


from_file in process.Audio dimension issue

https://github.com/sensein/b2aiprep/blob/ac73e7b1cf043415d2bec1a2338755c1199b9ce6/src/b2aiprep/process.py#L34
When I run from_file on data/test_audio.wav I get the error:
IndexError: too many indices for tensor of dimension 1
Since the signal that gets loaded only has one dimension. Is this a data issue or is the code handling the situation incorrectly?

i thought i checked two types of files. but this is where tensor shapes on different channel data can be different. if you simply load it what does the shape look like?
i would change that to:
if len(signal.shape) > 1 and ...
    ...
else:
    signal = signal[:, None]

That audio looks like this:

It was a mono 44khz audio I recorded in audacity.
I can make the change


Fix operation bug

Codecov Report

Merging #18 (55925f1) into dev (77428a4) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

:exclamation: Current head 55925f1 differs from pull request most recent head 1f4b7c2. Consider uploading reports for the commit 1f4b7c2 to get more accurate results

@@            Coverage Diff             @@
##              dev      #18      +/-   ##
==========================================
- Coverage   84.31%   84.03%   -0.28%
==========================================
  Files           5        5
  Lines         306      307       +1
==========================================
  Hits          258      258
- Misses         48       49       +1

Impacted Files
Coverage Δ

src/test.jl
94.89% <100.00%> (-0.98%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add support user export & refactor supplier export

Context
Support users require on-demand exports of all users in the system
Changes proposed in this pull request

Added a user export button for support users
Refactored device supplier exports

Guidance to review
Visit support/users as a support user and click Download CSV

 Add a support link to export all users and their schools


Custom subpackage name in poetry (poetry issue #6258)

Resolves: python-poetry#

[X] Added tests for changed code.
[x] Updated documentation for changed code.

https://github.com/python-poetry/poetry/issues/6258

My other two points in https://github.com/python-poetry/poetry-core/pull/672#discussion_r1428109158 seem to have been overlooked. I hope you don't mind I just implemented them myself. Please take a look and let me know if the changes make sense to you.

My other two points in #672 (comment) seem to have been overlooked. I hope you don't mind I just implemented them myself. Please take a look and let me know if the changes make sense to you.

Looks Good To Me!
I thought I had checked the code, but I guess I forgot. Thank you for letting me know!


CLI not working on Windows?

Hello,
First, excellent work on this utility. its exactly what I want, simple and lightweight. I'm baffled how hard it has been to find something that's not some huge Media Server/SDK for simple casting.
Anyway, I cant seem to get go2tv to work at all in command line mode on Windows 10. GUI mode works just fine.
I'm able to find my device fine using
go2tv.exe -l
Results
Device 1
--------
Model: [LG] webOS TV NANO85UNA
URL:   http://<IP_ADDRESS>:1688/

Then I've tried running this from command line
go2tv.exe -t http://<IP_ADDRESS>:1839 -v c:\TheHobbit.mp4
I get this error
Encountered error(s): interactive screen error: The handle is invalid.

I've tried using a Media URL instead of a local file, get the same error.
If I use the GUI and select the same file and select the device which shows under Select Device, and hit Play, it works great
I'm wondering if I'm just missing some simple syntax. I've also tried adding -tc and made sure ffmpeg is installed but no difference.
I've tried 2 machines on my network (both Windows 10) with the same result. Any ideas?
Thanks!

Hello! Thanks for taking the time to raise it. This looks like a windows specific error. I'll try to replicate and let you know

Could please omit the -t option and just run go2tv.exe -v c:\TheHobbit.mp4. Do you still get the same error?

Thanks for the reply
I just tried it without -t but unfortunately the same error occurs
Results
Encountered error(s): interactive screen error: The handle is invalid

Something else that I'm not sure if it could be related or not but wanted to mention. I'm unable to execute go2tv directly from cmd or Powershell and get any output. In order to see any output, I have to use the following syntax (here in Powershell)
go2tv -v c:\TheHobbit.mp4 | out-string

If I dont add the out-string pipe, nothing ever outputs to console. Must have something to do with how it writes to stnd output?
Alternatively this also works in powershell to get output written to a file (though doesn't output to console)
Start-process 'go2tv.exe' -ArgumentList '-v c:\TheHobbit.mp4' -RedirectStandardOutput "c:\logs\go2tv_standard.log"  -RedirectStandardError "c:\logs\go2tv_error.log"

Here is another example using .NET directly in PS. This will output standard and errors to console. So it appears to only work if using output redirection. I dont know anything about go so not sure if any of this information is helpful but sharing it all the same
$process = [System.Diagnostics.Process]::new()
$process.StartInfo.FileName = 'go2tv.exe'
$process.StartInfo.Arguments = '-v c:\TheHobbit.mp4'
$process.StartInfo.UseShellExecute = $false
$process.StartInfo.RedirectStandardOutput = $true
$process.StartInfo.RedirectStandardError = $true
$process.Start()
[console]::WriteLine($process.StandardOutput.ReadToEnd())
[console]::WriteLine($process.StandardError.ReadToEnd())
$process.WaitForExit()

Unfortunately any of these methods results in the same original error. I just had to get a bit creative to finally get any output to know what was going on

I have the feeling that the reason you can't get any media playback is the fact that there is no attached console to the application. When I first built the application for Windows, there was a command prompt appearing when I double clicked the app. The solution to that was to use the "windowsgui" flag during compilation. I didn't realize that this flag would cause issues with ability to pass arguments from cmd. I’m a Linux user myself and nobody raised it until now.
There is no clean way to both get a “prompt-less” GUI and a fully working command line. I did find some workarounds online, but I need to invest some more time into it.
I compiled the latest stable version without this flag just to confirm if this is what is causing the "The handle is invalid" error. Could you please test it and let me know if that fixes it?
go2tv.zip

Ah ok that makes sense. I had wondered if there were little to few Windows users. Honesty, for my needs I don't really need any gui at all since I want to incorporate it into automation script/app. So if I can use it 100% command-line, that is perfect for me!
I just tested the upload you provided and I'm happy to say it now works as expected! I tested quickly with go2tv -v c:\TheHobbit.mp4 and casting started and worked first attempt. This is great! I'll do some more extensive testing in a day or so  (such as casting URLs and trying transcoding with -tc..etc) but otherwise this version looks like it will solve my issue. Can't thank you enough!

No worries, glad this fixed the issue. I also have https://github.com/alexballas/go2tv/tree/main/cmd/go2tv-lite which is an ever lighter version. No gui and no ability to use hot keys in the CLI. Just raw streaming. Also pasting it here in case you want to use that instead.
go2tv-lite.zip

Oh wow, now I feel kind of silly for not seeing that! That is actually exactly what I was looking for! Thank you!
One last question and this is a bit off topic but, is there a way to transcode with ffmpeg and pass parameters to it through go2tv when casting from URLs? Such as if I want to change the encoding format or other parameters?. I'm doing some streaming through libvlc and I'm having a lot of trouble with its transcoding while also streaming via HTTP. If I can bypass transcoding at all with libvlc and instead do so while casting through go2tv, that would simplify my life significantly!

Transcoding in Go2TV with URLs works by passing the http stream through pipes to the ffmpeg command as seen here https://github.com/alexballas/go2tv/blob/main/utils/transcode_windows.go#L24-L45. It's all hard coded as the goal of the app to provide an easy way for everyone to stream stuff. If you have some specific ffmpeg parametres in mind you can change the code in that part and recompile.

Ah ok understood and makes sense. I haven't ever compiled with go before so it will be a good learning exercise at least.
Thanks again!

Nothing further to do in this issue. Resolving.

go2tv_1.15.zip

Thank you so much for including an updated build!

go2tv_1.17.1.zip
go2tv-lite_1.17.1.zip

Starting with release 1.18.0, the CLI will work smoothly on Windows by default. A brief black prompt will appear during app initialization, but it won’t impact the experience.


Sort the attributes for events

This is add support for #19559
We tried sort it in client side, and it sort follow go
sort : sorts a slice of strings in increasing order.
Signed-off-by: Kai Qiang Wu(Kennan<EMAIL_ADDRESS>

Test is failing:
03:15:11 FAIL: docker_cli_events_test.go:142: DockerSuite.TestEventsContainerEventsAttrSort
03:15:11
03:15:11 docker_cli_events_test.go:165:
03:15:11     c.Assert(matchedEvents, checker.Equals, 2)
03:15:11 ... obtained int = 4
03:15:11 ... expected int = 2
03:15:11

Please, do NOT reorder the imports, use https://godoc.org/golang.org/x/tools/cmd/goimports to sort them automatically for you.

hi @calavera  the import was used by
gofmat -s -w  <file>
I did not manual change that

Seems the server jenkins or event api have some issue, it could pass in my local container environment.
Strange ~

hi, @thaJeztah  @calavera  do you know what's janky about ?
I found same unit test, can pass in experimental
03:19:03 PASS: docker_cli_events_test.go:142: DockerSuite.TestEventsContainerEventsAttrSort	0.553s
But failed for janky

the import was used by
gofmat -s -w

no idea why it's changing the order, but we're not going to merge that change :wink:
The test is getting more events in the janky suite, that's why it's failing.

Not know why jenkins hang there

@HackToday Probably because of yesterday's GH outage...

Hi @thaJeztah  how can I kick a run again ? It seems the jenkins tests can not run(it has been waited for one day)

I'll kick it; Janky was having issues due to the GitHub outage

It looks like remote system is not stable
05:25:35  ---> Running in ebeaead39ce1
05:25:35 + mktemp -d
05:25:35 + export GOPATH=/tmp/tmp.84bumRWIaw
05:25:35 + git clone https://github.com/docker/distribution.git /tmp/tmp.84bumRWIaw/src/github.com/docker/distribution
05:25:35 Cloning into '/tmp/tmp.84bumRWIaw/src/github.com/docker/distribution'...
05:25:51 error: RPC failed; result=52, HTTP code = 0
05:25:51 fatal: The remote end hung up unexpectedly
05:26:08 Removing intermediate container ebeaead39ce1
05:26:08 The command '/bin/sh -c set -x 	&& export GOPATH="$(mktemp -d)" 	&& git clone https://github.com/docker/distribution.git "$GOPATH/src/github.com/docker/distribution" 	&& (cd

Still the build is not stable, checked the above output

13:16:31 Build step 'Execute shell' marked build as failure
13:16:31 Performing Post build task...
13:16:31 Could not match :Build timed out  : False
13:16:31 Logical operation result is FALSE
13:16:31 Skipping script  : cd c:\scripts
13:16:31 sh timeout-post-build.sh

@jhowardmsft  still windows jenkins failed for not related with my change.
Could any docker maintainers to kick the test again ?   And BTW How can others(for example me)  kick it ?

@HackToday restarted the build. Restarting the builds is currently only possible for maintainers that are voiced in the #docker-maintainers IRC channel

ping @calavera @vieux   PTAL. Thanks

LGTM

LGTM

LGTM


BlockAwareSegmentInputStreamImpl shouldn't use LedgerEntry#getLength

LedgerEntry#getLength() returns the length of the ledger up to and
including the length of the entry, not the length of the entry as you
would expected (and the documentation states). So we shouldn't use it
when serializing the entry, because what we need is the length of the
entry.
This patch changes BlockAwareSegmentInputStreamImpl to use the
readable bytes of the bytebuf instead.
Master Issue: #1511

@merlimat please check @ivankelly 's comment


feat: remove next/image

:tada: This PR is included in version 1.141.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Is computation_time only related to the GPU model?

I'm trying to create a config file ***.yaml, but confused about the meaning of computation_time , is it related to batchsize? If I change the batchsize, do I need to  run the actual workload to find out the corresponding computation_time?

Yes it is related to the batch size. It is the computation time for processing one batch of data. So you'll have to measure the computation time in the actual hardware for that.

It is necessary to maintain consistent data format. How do you measure the computation_time of NPZ format data in UNET3D? Can you provide me with a reference code?

If possible, please also provide a copy of the test code in tfrecord format for the cosmoflow workload


Add and derive deserialize_from

The actual deserialize work is WIP, because I probably need to refactor it so it can be feature-flagged off. I think the first two commits are "good to go", though.
One thing missing from this design is deriving deserialize_from for exactly C-like enums, but that can obviously be done later.
Pushing this up now because my brain is melting trying to do the non-C-like enum work I need for webrender, and so I'm gonna take a bit of a "break" by dealing with review complaints.

Oh also obviously BLATANTLY MISSING: TESTS. ANY TESTS.

Any tips on testing this kind of thing would be appreciated. My local experiments have mostly consisted of asserting that serializing and deserializing round-trips correctly.

Currently grinding through the serde test suite, lots of little derive bugs.
Starting to regret changing a bunch of things from -> Body to -> (Option<Common>, Body, Option<FromBody>) in order to prevent duplicating a static.

Pushed fixes:

Fixed bad cfg's in builtin impl commit
Got existing test-suite passing with derive changes

One thing I didn't realize until now is that deserialize_from kinda doesn't make any sense when doing "remote" impls?

I have fallen behind on PRs so I haven't had a chance to review the implementation yet, but -- I would be interested in exploring some ways to modularize the serde and serde_derive crates better so that large but uncommonly required features like this one can be delivered in their own crate. The serde_state / serde_derive_state feature is in a similar situation where it seems somewhat overwhelming to maintain as part of Serde but the community that wants the feature is willing to maintain it on the side.
Maybe this means factoring a lot of the serde_derive code into a separate pre-1.0 helper crate that is depended on by serde_derive, serde_derive_state, and a deserialize_from derive crate.
Would you be interested in figuring out a structure that would work for deserialize_from as part of getting this integrated? Otherwise would it be possible to provide deserialize_from in its own crate somehow, even if it means some code duplication with serde_derive?

I don't really see how deserialize_from could be seperated out, realisitically? It's part of the trait definition.

I don't really see how deserialize_from could be seperated out, realisitically? It's part of the trait definition.

You can make a DeserializeFrom trait which is implemented for all Deserialize types

How would that work? It can't be blanketed, because actual type-specific code needs to be emitted.

Okay I can see how shipping this outside of the Deserialize trait definition would be problematic.
I am on board with accepting this as long as it does not affect compile times for anyone not using deserialize_from (basically the same concern as for clone_from). As is, when I tried this it raises compile time for the serde crate by 13% (5.9 seconds to 6.7 seconds) which is a bit much for something that few people will use. Worse, Deserialize impls already compile very slow (https://github.com/serde-rs/json/issues/313) so something like 2x more generated code in every impl would not be nice.
Could you propose what you think is the best way to feature gate this?
Up to you how you want to get this merged. If it is easier, we can merge the serde pieces up front and follow up in one or more other PRs with the serde_derive pieces as those are written and tested.
One thing I don't like here is all the deserialize_from impls that are conceptually no different from the default implementation. For example the bool one:
fn visit_bool<E>(self, v: bool) -> Result<(), E> {
    *self.0 = v;
    Ok(())
}

Could you share some benchmarks that show these outperform the default deserialize_from? Is there an easy way to tell which types benefit from a custom deserialize_from? Or is a custom deserialize_from always preferable?

Ok finally got a chance to double check primitive stuff. Looks like, at least on webrender, removing the primitive impls is neutral, or possibly even profitable (the deserializer went from 7.1% to 6.6% of backend time; probably noise).
I'll take them out, then.

Ok I refactored out all the deserialize_from derivation code out so it could be feature'd out. Ultimately we weren't sharing a ton of code, so it's not a huge loss. Writing it that way helped me incrementalize the development process for myself better, but that doesn't matter now.
I also did a kinda naive addition of deserialize_from to the test suite.

Webrender, and therefore gecko, will likely be moving forward with a soft fork of serde in the next few days with these patches, plus the additional patch found on https://github.com/Gankro/serde/tree/deserialize_from_enums3
Even if you aren't ready to make a call on merging this, we'd certainly appreciate more thorough review. :)

I'd be on board with merging this PR as it is if we make the deserialize_from feature require nightly. Then we can play around with it a little without having to immediately stabilize it

That makes sense to me.

Wait, would that also put the trait method behind the feature?

Also CC https://github.com/serde-rs/serde/issues/855

Hmm right, that could be messy with derives and such :/

I started making progress on the review -- pushed a few fixup commits as I go. Some remaining items:

Before merging, I would like to get a sense of what this means for the future of csv::Reader and serde_json::StreamDeserializer. Is there a nice way to adapt these APIs to take advantage of deserialize_from? (I have not started thinking about this; it may turn out to be an easy answer.)

Benchmarks! It seems obvious that this would be faster in some usage patterns, but I would want to see at least one basic not-too-contrived benchmark that I can run using a real existing data format to see an improvement from this.

Currently for every struct with named fields we emit two totally identical copies of the __Field enum and the __FieldVisitor and its Visitor and Deserialize impls, which is a ton of redundant code. These should be emitted in a higher scope and shared by deserialize and deserialize_from. It is not critical to fix this before merging; will file an issue to follow up.

I don't know what's interesting about those, I'll take a look in a bit.
I'll try to cut out some basic workloads. Where do you put benches?
Yes, I originally put in a fair bit of work trying to avoid this, but I backtracked on it when I deintegrated stuff to support cfg(). This ends up being pretty nasty to thread through the code for things like deserializing struct-like enum variants. Not clear it's worth the effort.

The CSV reader and JSON stream deserializer are interesting because they are APIs designed for deserializing lots of instances of the same type that are processed one at a time -- seems like an obvious candidate for deserialize_from. CSV is why we filed #855 in the first place so we may as well be certain that we are addressing their use case in the best way.
There aren't really benchmarks of Serde by itself since nothing interesting happens without a data format, but JSON benchmarks live here and Bincode benchmarks live here. I wouldn't bother with either of those, not looking for anything fancy just a 30 line thing I can run and see an improvement. I would do this myself but I am about to call it a night. 😴


Module parse failed:

I am working on merging an old, but working react-redux project into a new project. The goal was to use what was already completed and build off of it in a group of 4 developers. I, for the life of me, cannot figure out the latest error message and how to fix it. The others are also stumped. Any help would be greatly, greatly appreciated 👍 Here is the error:
./node_modules/react-redux/src/components/connectAdvanced.js
Module parse failed: Unexpected token (242:29)
You may need an appropriate loader to handle this file type.
|         // instance. a singleton memoized selector would then be holding a reference to the
|         // instance, preventing the instance from being garbage collected, and that would be bad
|         const withExtras = { ...props }
|         if (withRef) withExtras.ref = this.setWrappedInstance
|         if (renderCountProp) withExtras[renderCountProp] = this.renderCount++

DEPRECATED
Please use: https://github.com/webpack-contrib/mini-css-extract-plugin


Move all docs content to docs repo, add pointer from README.md

Signed-off-by: Guillaume Tardif<EMAIL_ADDRESS>

nit: This can be removed as well


Gateway Controller crashes when moved by vanilla pistons

This bug is in 1.14.
The Gateway Controller, despite being moveable by vanilla pistons (and other methods) causes a ticking entity crash when pushed by a vanilla piston, and if it has been activated with a wrench when it gets moved (I used Create's Mechanical Pistons, as they don't cause a crash) then whichever Gateway Frame/Controller blocks get moved have no texture, and work as an x-ray bug.
If you successfully move a gateway (again, I used Create's Mechanical Pistons), then the visually empty void where the gateway should be still works. However, while the moved gateway deposits you at the expected spot in the gateway that it's linked to, going to the moved gateway will deposit you at the location that the moved gateway started at. This happens regardless of whether you crashed and logged back in, or managed to move the gateway without crashing.
To reproduce, simply try pushing the controller block with a vanilla piston (Essentials Multipiston does nothing)
I appreciate the fact that the gateway works a moveable portal between dimensions, (I'm currently making a world with a moving house) and requiring that one end stays still so that it can avoid entropy buildup seems balanced, however the combination of the crash, and the lack of adjustment of the exit point when traveling to the moved gateway stops this from being useful.

That would explain it…
I keep on forgetting that Quark makes many things moveable.
…and sometimes I forget that I have Quark.


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] My answer given in the checkbox above is a lie.

What problem did you encounter?
problem during the game, roblox starts showing artifacts, in this case the problem was captured on video, this problem only appears in bloxstrap, there is no such thing in the microsoft/original version. technical information about my PC:

gparhics card: Intel(R) HD Graphics 520
processor: Intel(R) Core(TM) i5-6300U CPU @ 2.40 GHz

video link: https://imgur.com/a/pMmeWyd

Upload your configuration please: https://github.com/pizzaboxer/bloxstrap/wiki/Uploading-your-Bloxstrap-configuration

Issue has been awaiting clarification for over a month, closing as stale. If you have anything further to add, just respond and I'll reopen