Fixed imported get_nbext_dir function name

Updated to match the newest code in jupyter notebook master

Good plan, but we ought to wrap this in a try/except to work with both cases


RL-32 Publish test results and coverage to main README

Description
Publish unit test coverage to Codecov and show in README
https://app.codecov.io/github/CDCgov/RecordLinker

Related Issues
[Link any related issues or tasks from your project management system.]
Additional Notes
[Add any additional context or notes that reviewers should know about.]
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:

[x] I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
[x] I have reviewed my changes to ensure they are clear, concise, and well-documented.
[x] I have updated the documentation, if applicable.
[x] I have added or updated test cases to cover my changes, if applicable.
[x] I have minimized the number of reviewers to include only those essential for the review.
[x] I have notified teammates in the review thread to build awareness.

Checklist for Reviewers
Please review and complete the following checklist during the review process:

[ ] The code follows best practices and conventions.
[ ] The changes implement the desired functionality or fix the reported issue.
[ ] The tests cover the new changes and pass successfully.
[ ] Any potential edge cases or error scenarios have been considered.

Welcome to Codecov 🎉
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered ☂

cool. thanks..


osm-controller: use fixed port number for ADS server

Description:
Resolves #2190 by using a constant port number for the
ADS server in osm-controller. The port number was partially
configurable via the controller's command line flags but
this isn't enough to make the port number configurable.
Since there is no use case for this port to be configurable,
use a fixed port number. Also, renames the name of the port
for clarity.
Resolves #2190

Affected area:

Functional Area

Control Plane
[X]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Codecov Report

Merging #3394 (dc9c2ec) into main (2614202) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #3394      +/-   ##
==========================================
- Coverage   65.88%   65.83%   -0.06%
==========================================
  Files         169      169
  Lines        7839     7839
==========================================
- Hits         5165     5161       -4
- Misses       2644     2648       +4
  Partials       30       30

Flag
Coverage Δ

unittests
65.83% <50.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/osm-controller/osm-controller.go
16.54% <0.00%> (ø)

pkg/injector/envoy_config.go
94.77% <100.00%> (ø)

pkg/kubernetes/announcement_handlers.go
71.42% <0.00%> (-5.72%)
:arrow_down:

pkg/ticker/ticker.go
68.00% <0.00%> (-2.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2614202...dc9c2ec. Read the comment docs.


Remove version: Ziad.TCG version 6.9-stable

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://deac-fra.dl.sourceforge.net/project/temp-cleaner-gui/temp_cleaner_gui_v6.9-stable_win7sp1to11_amd64_mrx.exe
Status Code: 200
(Automated message - build 896)

Close with reason: Package still available.;


Investigate mini.css's table rules

and whether there's something we'd want to adopt/adapt.
https://chalarangelo.github.io/mini.css/table.html

Another table enhancement, which could be an interesting addition to this baseline style, is highlighting the current (hovered) row. This seems similar to the behavior implemented for links (they get underlined on hover).
Two possible ways to do this:
tr:hover:after { content:"◂"; font-weight: normal; color: #ccc; margin-left:.3em; position: absolute; }
tr:hover, tr:hover th{ background: AliceBlue; }


don't make plus-signs selectable

Expected behavior:
I can copy and paste the code, the plus-signs are not copied with the code.
Current behavior:
When I copy and paste the code, I manually need to remove each + because the the plus-signs are copied along with the code.

Those + and - signs are required in order to make it better to understand how to change the code for migration or how to replace any deprecated APIs with the new one.
these are not usually long snippets so manually deleting should not be a much of work. 👍

I was thinking that maybe

+document.body.removeChild(element);

+element = component();

+document.body.appendChild(element);

would be a good solution.
I agree that it is not much work to manually remove the plus-signs but I think it is unnecessary and that the guides would be improved when the code can just be copied and pasted.

@SimonSiefke  It could be possible if we bring Prismjs plugin https://prismjs.com/plugins/diff-highlight/ support into Refactor  which this doc site relies one.

Or render :before pseudo elements.
I think this issue can be closed as https://github.com/PrismJS/prism/pull/2281 is merged?

@DanielRuf That commit is not released in a new version PrismJS yet. Maybe we can keep this issue open if we do want to bring this feature into doc site.

[x] Wait for new PrismJS to be released (1.21.0 is out)
[ ] Wait for refractor to update to PrismJS 1.21.0
[ ] Wait for remark-refractor to update to then-latest refractor

I've created a pull request here https://github.com/webpack/webpack.js.org/pull/3912 so anyone can check how it looks like now https://webpack-js-org-git-fork-chenxsan-feature-user-select-none-diff.webpack-docs.vercel.app/guides/asset-management/#loading-images.


Refactor code for some ansatzes

Basically, rewriting and cleaning up some older code
Notes:

Converting the function to build the hardware-efficient ansatz to return a circuit to make it consistent with the functions for the other ansatzes

Updated the associated tests and documentation as well

Should be done, now waiting for #85 to be merged in case of any possible conflicts.


makeStats does not generate correct error message for index 0

Perhaps we should change the message to be INDEX (must be a positive integer)?

Happens for mailEvent


The application panicked (crashed).

Command : target/release/mevi chromium
Result :
2023-03-23T14:52:11.818086Z  WARN mevi::tracer: a thread is changing the brk for the process, we should handle that
[26942] => [1] mapping 7fdf7a100000..7fdf7a102000 (8 KiB) with NotResident
The application panicked (crashed).
Message:  called `Option::unwrap()` on a `None` value
Location: crates/mevi/src/tracer.rs:200

'hack' to bypass the issue ? :
diff --git a/crates/mevi/src/tracer.rs b/crates/mevi/src/tracer.rs
index 4518cb1..dd0dbc4 100644
--- a/crates/mevi/src/tracer.rs
+++ b/crates/mevi/src/tracer.rs
@@ -195,7 +195,9 @@ impl Tracer {
                                         "{tid} => {for_tid} mapping {range:x?} ({}) with {state:?}",
                                         formatter(range.end - range.start)
                                     );
-                                    let target = self.tracees.get(&for_tid).unwrap();
+                                    let target = self.tracees.get(&for_tid);
+                                    if target.is_some() {
+                                    let target = target.unwrap();
                                     match &target.kind {
                                         TraceeKind::Fresh => unreachable!(),
                                         TraceeKind::Process { uffd, .. } => {
@@ -213,6 +215,7 @@ impl Tracer {
                                             panic!("thread {for_tid} of process {pid} mapping memory should show up in the parent");
                                         }
                                     }
+                                }

                                     let ev = MeviEvent::TraceeEvent(
                                         for_tid,

'hack' to bypass the issue ? :

That'll get rid of the crash, sure, but it won't be correct.
I've tried real hard to get mevi working with Chromium, and have failed after a week+ of efforts. I don't really want to get rid of that panic without fixing the underlying cause.
Btw, if you're trying to make changes to get it working with Chromium - you will have to disable all its sandboxing mechanisms, just like the README Indicates for Firefox. The sandboxing mechanisms will break mevi for sure - even crashpad_handler is tricky to deal with (due to its use of ptrace).


entity and biome id extension needed!

this mod is great for block ID's and stuff but there are more mods that add entities, mobs and biomes. For example Æther mod, Hardcore Ender expansion, Mo' Creature, Ore Spawn, Inferno's Nether Expansion, Flans, Astromech Droids Mod, Custom NPCs, Legendary Beasts, Dalek Mod, Creepy pastas, Creeps and weirdo's, Mutant Creatures, etc. PLEEEAASE add, at the very least, entity IDs, and biome ids if you can. Thank you

support

Support. Would be willing to contribute, too.

isn't JEID supports that already?


[WIP] Add selinux changes for cockpit

This allows the cockpit proxy to work while also allowing
us to access the cockpit webconsole for the appliance.
37502e865ffd60a836cfdeefc39587401fce3f36 removed the previous implementation
but that breaks to cockpit VM console (cockpit_ws) role
This was the original implementation in https://github.com/ManageIQ/manageiq-appliance/pull/130, but was rejected for being needlessly complex. Now we seem to need that complexity to simultaneously proxy cockpit connections and run cockpit on the appliance itself. That didn't work.
This was created by the following process:

set selinux to permissive
enable the cockpit role
Request a cockpit webconsole to a VM
audit2allow -a -m cockpit_ws_miq > cockpit_ws_miq.te

https://bugzilla.redhat.com/show_bug.cgi?id=1779988

Looks like this isn't good enough, but after fixing the UI I was able to get this running with setenforce 0 so I'll try to figure out an alternative.

With this and https://github.com/ManageIQ/manageiq-ui-classic/pull/6522 I was able to get both a webconsole to a remote VM and access cockpit for the appliance running manageiq.

Moving this to WIP while I try to minimize the changes.

Minimized the selinux changes and moved the auth script to this repo.
These changes require https://github.com/ManageIQ/manageiq/pull/19631

This is clearly better than it was after you reduced the scope of the needed selinux permission changes.  👍

Ivanchuk backport details:
$ git log -1
commit b915ed726529e28a4e1f25fa7def9b4ba56fab5c
Author: Joe Rafaniello<EMAIL_ADDRESS>Date:   Wed Dec 11 17:18:04 2019 -0500

    Merge pull request #266 from carbonin/readd_selinux_changes_for_cockpit

    Add selinux changes for cockpit

    (cherry picked from commit 2d4ef11e7144313970cd1a1f97ffd80eed409d49)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1784555


DxfArc.GetBoundingBox incorrect for StartAngle>EndAngle

Consider a counter-clockwise arc with startangle=90° (top point) and endangle=0° (right point) centered at (0,0). It defines a 270° sweep and looks like this:

The current bounding box calculation calls into DxfEntityExtensions.ContainsAngle which reverts the order of the angles and assume an arc from 0° to 90°. The resulting bbox min=(0,0) max=(1,1) is wrong.
Correct handling of angles is always tricky, mostly because of the 360° boundary (think of start=359°, end=1° and other boundary crossing cases). Unfortunately, this blocks a relatively simple solution for #102.

Since DxfArc seems to be CCW always, the correct way to test if an angle is contained in the arc includes three cases:
If startAngle < endAngle then target angle must live between start and end.
Otherwise the CCW arc end goes beyond 360° and we split the arc into two parts: "from start to 360°" and "from 0° to end". Those can be easily tested with normalized angles.

Fixed via #104.


Change const to var

Because const will break on older browsers like in iOS 9.3

:herb:
Thank  you.  I don't know how these snuck in.

Thank you. That was quick. This should be released as soon as possible because without that fix some applications will break without knowing what's going on 😉 (I had this kind of issue for example)

I'll try to get to it tonight.  There's some other things that should make it into a quick release.

Great! 🎉


Webhook deleting branch considered a push

Gitea version (or commit ref): 1.11+ (We built a develop version of 1.12 that isnt released.)
Git version:
Operating system: Ubuntu
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No
[X] Not relevant

Log gist:

Description
When I delete a branch its considered a push to the branch instead of deleting. Same with if a PR gets syncronized, its considered a push. If its accurate for them to be pushed, it would be helpful if deleting a branch ALSO had the 'action' field, that way I can filter it out so it doesn't built on my pipeline when i delete branches.
...
Screenshots

Same for me. I've configured the webhook to only be triggered on Create and Push Events but the webhook is always triggered on Delete Events (git push -d origin branch).

Still would like a resolution to this issue
On Tue, Jun 2, 2020 at 2:47 AM stale[bot]<EMAIL_ADDRESS>wrote:

This issue has been automatically marked as stale because it has not had
recent activity. I am here to help clear issues left open even if solved or
waiting for more insight. This issue will be closed if no further activity
occurs during the next 2 weeks. If the issue is still valid just add a
comment to keep it alive. Thank you for your contributions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/go-gitea/gitea/issues/10578#issuecomment-637317618,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB7R7JO57R4PG4I2PJD6M5TRUSN7VANCNFSM4K7ZC72A
.

--
Kimberly Boynton
Umass Amherst '14

Fixed by #12212


[AUTO] Update input manifests

I have noticed that a repo has incremented a version. This change updates the corresponding input manifests.

Codecov Report
Patch and project coverage have no change.

Comparison is base (976b6a9) 91.74% compared to head (976b6a9) 91.74%.

:exclamation: Current head 976b6a9 differs from pull request most recent head 6fe81bf. Consider uploading reports for the commit 6fe81bf to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@             Coverage Diff             @@
##           manifest-2      #23   +/-   ##
===========================================
  Coverage       91.74%   91.74%
===========================================
  Files             172      172
  Lines            4991     4991
===========================================
  Hits             4579     4579
  Misses            412      412

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Use deconstruct_keys instead of deconstruct

Hi,
How about using  deconstruct_keys instead of deconstruct for pattern matching support?

Thank you, I didn't find info about what's deconstruct_keys for, now it's clear. Obviously, it'll be better this way, and I'll cut a new release next week. I reckon we can release it as a minor version since it's not going to break anything existing.

Thanks.

I didn't find info about what's deconstruct_keys for, now it's clear.

Maybe a following slide can help you.
https://speakerdeck.com/k_tsj/pattern-matching-new-feature-in-ruby-2-dot-7?slide=32


Feature request: HTTP Server-Timings header

Hi there! Thank you so much for creating and maintaining this. I've just added this to my atomic-server project and really love how much insights I can get from this.
I have one usecase in mind that I think could be interesting for others: the HTTP Server-Timing header. This header allows clients to gain insight into which parts of a request take up most time. I find this very useful both in production as during development, as you can use your browser's built-in tools to get an idea of why a request might be slower than usual.

I've currently imlemented this header at the handler level, with some custom Timing struct, but I think it makes far more sense to use Tracing for this - it would allow me to share far deeper insights in this Header than I currently can.
I think this could be implemented as an optional Middleware. It would need access to the RootSpan, I think, and it would need to iterate over it's children.
This is what my current Timer looks like:
//! Monitor performance using HTTP headers
use std::time::Instant;

/// Timer used to share performance metrics to the client using the HTTP Server-Timing header
/// https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Server-Timing
pub struct Timer {
    last: Instant,
    timings: Vec<Timing>,
}

struct Timing {
    name: String,
    /// Time in milliseconds
    duration: u128,
}

impl Timer {
    pub fn new() -> Self {
        Timer {
            last: Instant::now(),
            timings: Vec::new(),
        }
    }

    /// Adds a named measurement, counting from the last one
    pub fn add(&mut self, name: &str) {
        let now = Instant::now();
        let duration = now.duration_since(self.last).as_millis();
        self.last = now;
        self.timings.push(Timing {
            name: name.into(),
            duration,
        });
    }

    /// Returns the value for a Server-Timings header.
    /// https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Server-Timing
    pub fn to_header(&self) -> String {
        let mut out = String::new();
        for timing in self.timings.iter() {
            out.push_str(&format!("{};dur={}, ", timing.name, timing.duration));
        }
        out
    }
}

Nesting / Grouping
The Server-Timing header does not have nesting / grouping, and names have to be unique. This differs from Spans in Tracing, of course. We can deal with this in (at least) two ways:

we only go one span deep. This would mean some insights will be lost.
we create longer names for nested spans (e.g. level1name-level2name). This will lead to a more complete, but harder to understand timings header.
leave it up to the one using the middleware, add an option for allowed depth.

@LukeMathWalker I'd love to hear your thoughts about this. Is this relevant for this library? I haven't created an actix middleware yet, but I might be willing to take a go at this.

Hey!
I am not interested in supporting this functionality in tracing-actix-web - while I can see the appeal, it introduces a lot of complexity and the value of the insights quickly diminishes if you are not using a monolithic backend. It also increases considerably the size of the response while leaking details about the internals of the service, which I strongly advise against in a production deployment.
My suggestion would be to return the trace identifier and use that to query the tracing data from a specialised service (e.g. Honeycomb/Jaeger/etc.)/require the API client to submit that when having issues with a specific request..
If you really want to push this forward in your own project/as a separate crate, I can offer some suggestions:

Even though you can get access to the Span wrapped inside RootSpan, this will not allow you to iterate over its children. To get access to those APIs you need to implement a custom tracing Layer or Subscriber - you can look into tracing-bunyan-formatter to get an idea of what that looks like;
You can use some "special" fields to mark the root span (by using the root_span! macro) which can then be intercepted by your custom layer to know where to start tracking the server timings. You can look at the tracing-opentelemetry crate for inspiration;
You can then provide an extension method over Span that returns the Server-Timing header. You can look again at tracing-opentelemetry for inspiration. You will probably need something similar to their collector to be able to access the stored information from outside the layer.

Thank you for your insights!


Use coffee-script npm package conventions

This is the convention for a node.js module. @honzajavorek Please review & merge.

@pksunkara @honzajavorek @smizell actually we are publishing boutique to npm. Hence https://www.npmjs.com/package/boutique
Please use npm scripts for prepublish, not install. And also use coffee -cb -o lib src to actually not wrap generated JS in closures.

@kuba-kubula The hook has been changed to prepublish after this PR once I realized it.

@pksunkara :+1:


How do I upgrade to V3.4 after Docker has deployed V3.3

What would you like to share?
Docker 部署 V3.3 后，如何升级到V3.4
Additional information
No response

Retrieve the Path of the Data:

Run the command in your terminal:
cat .env | grep DATA_DIR

This will output the current value of DATA_DIR which should be something like DATA_DIR=${DATA_DIR}/components/.

Copy the Path to a New Location:

After identifying the path, use the cp command to copy it:
cp -r DATA_DIR/ /openim/data

Replace components/ with the actual path if it's different.

Set the Environment Variable to the New Location:

Set the DATA_DIR environment variable to the new path:
export DATA_DIR="/openim/data"

Note: This change is temporary and only applies to your current session. For a permanent change, you'll need to modify the .env file or your system's environment settings.

Clone a New Repository and Initialize Variables:

Clone the new repository :
git clone https://github.com/openimsdk/openim-docker

Navigate to the repository directory and run:
make init

Start Docker Containers:

Finally, start the Docker containers:
docker compose up -d

Remember to adjust the commands according to your actual file paths and repository details. Also, ensure you have the necessary permissions to execute these commands and that Docker is properly installed and configured on your system.
In addition, we are currently considering developing a comprehensive upgrade plan. It would be greatly appreciated if you could pay attention to it and provide any assistance or guidance you may have. Your support would be invaluable to us.

Thanks for your guidance and I haved upgrade to V3.4 successfully.
But now I have a new question with V3.4
When I open ther Admin Web and try to login，It reports a CORS ERROR.
How can I customize the API URL

@linyouye Has the issue at hand been resolved at this point in time?


[UI] Show System project first when selecting a project

What kind of request is this (question/bug/enhancement/feature request):
Feature Request
Description
For large Rancher installations, such as 20+ clusters with 50+ projects, it's difficult for the administrator to navigate to the System project, which is done often for administrators. The Search field cannot be leveraged, because searching on "System" returns the System project for every cluster.
A possible recommendation to make this easier is to always list the System project first in the UI.
Specifically referring to this UI:

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v2.3.3

gz#7393

Not relevant with the new UI.


Library for running JAGS over all species in parallel

I am proposing to merge this into main with minimal changes to the model currently in main.
When we eventually settle on the preferred form of the default model, then we can merge that into combined.R with the small changes needed to adapt it to the funtion(params) API.
Reviewers: please try your own test run and say whether it works or give feedback on the API.
When reading the code, I suggest setting the UI to ignore whitespace differences when looking at the diff.

That looks great! I think it might be worth looking into the specific model used, as I believe that the model in this PR is not the "latest and greatest." But changing the model should not be too difficult. Also, certain models use top1 instead of all of the data, so we might want to add the ability to change which csv the model_read_lib.R uses (that would also make it faster because reading top1 is much faster than the entire dataset).

Thanks for looking Mark.
On model selection, the design criterion I adopted here is "separation of concerns." Specifically, (A) define the model, (B) run the model with lots of different parameter settings, collect the results, and parallelize well.
In other words, this was designed to work for any "model," where "model" is just a function taking a params list and returning a jagsResult.
"changing the model shouldn't be too difficult" - yes. Any of the many copies of combined.R have been created could just make the analogous change to the one this has made in combined.R, i.e. wrap the model as a trialFn.
I totally agree with reworking model_read_lib.R to allow a parameter for selecting between top1 / top3 / threshold. I think R has some sort of categorical type, like what's called enum in other languages. (enum ScoreSpace { TOP_1, TOP_3, THRESHOLD }). Wouldn't it be great if the enum values could also take parameters (c++ std::variant, but I digress).
Then that scoreSpace could become a trial hyperparameter, like species and year are in this PR.
If we were looking for even more efficiency, both speed and memory, we could consider changing the signature of trialFns so that the data list from model_read_lib was also an argument (trialFn(params, fullData)). That way we wouldn't re-read separately for every trial, and it would be more RAM efficient when the executor is multiprocessing because that uses fork, and Linux fork is copy-on-write (shares RAM from the parent process until it changes). However, that would come at the cost of some rework and a breaking change to function signature of readCombined. It would add an extra step if trying to use readCombined independently of run_trials.R.

Ok, that sounds good.

If we were looking for even more efficiency, both speed and memory, we could consider changing the signature of trialFns so that the data list from model_read_lib was also an argument (trialFn(params, fullData)).

Regarding this change, I attempted to do this in the combined-input-function branch (with the amount of data, not species). If we make a list of length(nspecies) where each item in the list is a jagsinput for a different species, we can just loop through each of the items in the list as an input to the model function. It would still take a while to make the giant data_list, but we would not have to remake it every time we run the model (if we are running different models).

Something like this
data <- future_map(speciesCodes,
              ~ readCombined(
                  species = c(.x),
                  years = c(2021),
                  beginTime = dhours(6),
                  endTime = dhours(10),
                  visitLimit = aruVisitLimit,
                  visitAggregation = "file",
                  thresholdOptions = list(
                    value = threshold,
                    is.quantile = F
                  ),
                  squeeze = T
))

Using furrr allows for it to run more quickly, but ideally this should only have to be run one time as data can be reused.


executeCommand() in CallbackqueryCommand()

Hello! I read a lot of posts, but I can not fully understand how to properly make executeCommand () in CallbackqueryCommand ()
I tried this, but caused a recursion of the answer.
if ($cmdobj = $this->getTelegram()->getCommandObject($callback_data)) {
    // Get the message array.
    $new_message_array = json_decode($callback_query->getMessage()->toJson(), true);

    // Override from so that it looks like we're the ones who sent the message.
    $new_message_array['from'] = $new_message_array['chat'];

    $new_update = new Update(
        ['update_id' => '-1', 'message' => $new_message_array],
        $callback_query->getBotName()
    );

    $cmdobj->setUpdate($new_update)->preExecute();
}

Please! Help me :'(

up

Check here: https://github.com/php-telegram-bot/core/issues/485#issuecomment-298847941


added the SBB open data

Relates to | Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] ./test.bash passes locally
[ ] Appropriate changes to documentation are included in the PR

Very sorry for the (red) build failure here! I'll merge this when I've fixed that this week-end.

Tx! This was merged as 5914ec8851a307e4207bdd18defebe1759bac244 as part of #538.


Remove skip while

See 0d62caa99110c9569d4efa5f886c6cbcadd54c75

Thanks, did't catch that.
I'd wouldn't update bacon-vs-kefir-api.md though. It needs much more fixes than that. Currently it's a comparison of API's of two specific versions of libraries:

Bacon v0.7.52 and Kefir v2.0.0

Please leave the change only in docs and squash commits, and we can merge this.

Thanks, did't catch that.
I'd wouldn't update bacon-vs-kefir-api.md though. It needs much more fixes than that. Currently it's a comparison of API's of two specific versions of libraries:

Bacon v0.7.52 and Kefir v2.0.0

Please leave the change only in docs and squash commits, and we can merge this.

done deal

done deal

Ok, thanks.

Ok, thanks.


"undefined" error in typeahead

Hi,
the value for the typeahead property of the typeahead component might be undefined sometimes in my app. Currently this gives an error in typeahead.directive.ts processMatches(), when it tries to get the length of typeahead.
PR follows.
Thanks for this otherwise great component :)
Greetings, Marc

see https://github.com/valor-software/ng2-bootstrap/pull/346


proxy.conf.erb seems to be missing

Hi,
In config.pp, we can find
$proxy_conf_template            = 'nginx/conf.d/proxy.conf.erb',

but the directory templates/conf.d does not contain that file.
Am I missing something ?
I discovered this issue when trying to use the puppet-nginx-hardening module.
Regards,

Hmm this is caused by an incomplete patch in https://github.com/jfryman/puppet-nginx/pull/642.
That line in config.pp is being ignored and the puppet-nginx-hardening module should not override that file because it no longer exists.

I've raised an issue on that module: https://github.com/hardening-io/puppet-nginx-hardening/issues/9

OK, thanks for the information.
I finally extracted the "hardening" configuration part of the module and inject it directly as configuration in my manifest.


Reimplement CI using Nix

This adds Nix expressions to build/check tree-sitter-nix and implements a few other required changes:

Migrate away from the nodejs based tree-sitter-cli to tree-sitter
The node based one is deprecated and no longer maintained.

Moves checks from the github yml to flake.nix
Run checks locally with nix flake check.

Regenerate the parser using new tree-sitter.

Closes https://github.com/nix-community/tree-sitter-nix/issues/37

Closing in favour of #42 for technical reasons.


Replace unneeded lodash methods with native JS

There are a couple of lodash functions in use that are covered by native JavaScript. This PR replaces those uses.
Note: I left _.each untouched since we often use _.each on objects. Since this is some more work I'd like to hear feedback on this first. .forEach is only defined on arrays and our objects would have to be passed through Object.keys to be iterable.

So in theory if enough of these are replaced, would it be possible to switch to modularized lodash builds?

@acburdine Pretty sure that'd be possible.

And once we drop v0.10 we may be able to drop lodash completely.

Is there a quantifiable or tangible benefit to our users here?
Type specific changes like Object.keys() instead of _.keys() and _.isArray -> Array.isArray I get, to a point, as there's no need for the abstraction.
With things like map/reduce, I think the power of lodash is the type agnostic concept of a collection.  It makes maintaining and refactoring code much simpler. There's a reduction in cognitive load that lodash provides as well, which I believe will disappear over time, but the fact that the functions all share a recognisable signature makes functional code easier to write IMO.
However, I'm fully on board that "great for users" > "great for developers" so if there are tangible benefits for users (speed, memory usage, etc) then I'm all for it.
In a similar vein, I don't think (at the moment) modularised lodash builds are all that useful, given that lodash is a dependency of most of our major dependencies, we have to load it anyway.
I'm fully willing to be educated that I'm completely wrong on this, but I think taking the time to provide reasons for syntactic changes is necessary, otherwise they're just changes for changes sake.

Closing this as it's gone stale - might be worth opening an issue to discuss the changes?


Any way to get jsDoc?

I am going to collect all jsdoc when visit all typescript ast node
in typescript source code, many node was extends JSDocContainer
they may have a property called jsDoc
but it's a internal property
how can i get jsDoc property
for example in my code

function collectJsDoc(node: ClassDeclaration) {
   console.log(node.jsDoc)
}

same as #7393


[IDEA] Add "copy to clipboard" button on every address tooltip

Problem to solve
Copy-pasting wallet/contract addresses is a common action in Web3. Currently, a user has to manually highlight the wallet address text to copy it. This is slightly inconvenient and is error-prone.
Proposal
Add a "copy to clipboard" button whereever we have tooltips for wallet addresses. Some (all?) addresses ahve tooltips with a link to etherscan - a small "copy to clipboard" button next to that might work well.

great suggestion. i've gotten so used to copying addresses manually that i hardly think of it anymore.
adding a copy button next to the etherscan link in the FormattedAddress.tsx component would work great


Audit Keybinds Documentation With Source Code

Describe the solution you'd like
Make sure that the keybinds guide rendered at (1.0) and done in markdown at (1.1) line up with the actual keybinds in rust done at (1.2).
Describe alternatives you've considered
N/A, at request of @Xithrius
Additional context
Links are as follows:
1.0: https://xithrius.github.io/twitch-tui/keybinds/index.html
1.1: https://github.com/Xithrius/twitch-tui/tree/main/book/src/keybinds
1.2: https://github.com/Xithrius/twitch-tui/blob/main/src/handlers/user_input/input.rs

Issue 1 Documentation:
I went through and looked at your source code, and made notes of the following functionality with each mode.  I will update as i keep going through each. @Xithrius is this the best place to put this or would you prefer if I put as an issue on the github?
Normal Mode Audit:
c = goes to chat window
s = channel switch dialogue pops up
ctrl + f = searches messages
ctrl + t = toggles filter on and off.
ctrl + r = reverse filter toggle
i = opens up message input prompt
@ = opens up message input prompt with @ symbol ready
/ = opens up message input prompt with / symbol ready
ctrl + p = triggers panic and exits program
? = opens up Help option and lists all commands
q = quits program
Esc = exits any layers/ prompts and goes back to the base/normal view.
Insert Mode Audit:
ctrl + f = moves cursor one space to the right
ctrl + b = moves cursor one space to the left
ctrl + a = moves cursor to the beginning of the messge
ctrl + e = moves cursor to the end of the message
Note: I am running a Mac, alt keywords do not perform as intended, notes as to functionality are listed below:
alt + f = appends f to where the cursor is. documented functionality not performed.
alt + b = does nothing. documented functionality not performed.

alt keybinds do not work as intended on mac due to lack of Alt keyword. Suggestion: Add Option/Mac support for Alt keywords? Curious on feedback on this.

Interesting. I will find a solution to this, although so far I don't see an option keycode, at first glance. Gonna dig deeper.

What terminal are you using?

I'm using zsh for my terminal. I've tested in a vscode terminal instance as well (which I believe is also running zsh).
For reference, my Mac (at least the one I'm currently using) does not have an alt key but does contain fn control option and command keys.
Macs are cool, but weird.

I also have a mac machine, so I'll test this application with the option key in the near future. By terminal I mean the emulator, and not the shell.
Shells examples are bash, zsh, fish, which terminal emulator examples are iterm 2, kitty, alacritty.

Just the default Terminal (i.e. 'Terminal') application that comes pre-installed, nothing special like iTerm or iTerm2 etc.

I believe that iterm2 is much better than the regular terminal application, due to the customization and overall amount of features it contains. I would recommend it very much.

Sounds good, I appreciate the suggestion and I will implement that into my workflow

Alright, after testing on my mac I can see the pretty bad input problem. Instead of going to the end of the next word with option + w, the summation symbol is inputted.
I'll probably make a configuration option to route option to something else on macos.

Do you have a suggestion to what option should be rebound to? Doesn't look like it can be used as a leader key.

I believe the keyboard guide is fine at this time.


Register series bar issue with lots of series

Looks like the bars stop filling in when we run out of colors? Need to fix so the colors loop.

related : https://github.com/PredixDev/px-vis-timeseries/issues/1

fixed in v0.6.28


Fix Column not found in where clause (1.7.7)

Questions
Answers

Description?
Names of modules should be wrapped with single quotes to be searched as text and not as SQL columns.

Type?
bug fix

BC breaks?
no

Deprecations?
no

How to test?
Without this fix, execution of autoupgrade module SQL migration from CLI with command php modules/autoupgrade/cli-upgrade.php --dir=admin834sd7uzf --chanel=major --action=upgradeDb fails from a PrestaShop database of version <IP_ADDRESS> ; with the fix, it is OK

Full error reported without the fix :
php modules/autoupgrade/cli-upgrade.php --dir=admin834sd7uzf --chanel=major --action=upgradeDb

INFO - === Step upgradeDb
PrestaShopException^ {#16162
  #message: "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'sekeywords' in 'where clause'"
  #code: 42
  #file: "/var/www/html/classes/db/DbPDO.php"
  #line: 151
  -previous: PDOException {#13002
    #message: "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'sekeywords' in 'where clause'"
    #code: "42S22"
    #file: "/var/www/html/classes/db/DbPDO.php"
    #line: 149
    +errorInfo: array:3 [
      0 => "42S22"
      1 => 1054
      2 => "Unknown column 'sekeywords' in 'where clause'"
    ]
    trace: {
      /var/www/html/classes/db/DbPDO.php:149 {
        DbPDOCore->_query($sql)^
        › try {
        ›     return $this->link->query($sql);
        › } catch (\PDOException $exception) {
        arguments: {
          $query: "UPDATE `ps_tab` SET `enabled` = 0 WHERE `module` IN (sekeywords,statsequipment,statslive,statsorigin,statsvisits,welcome,ps_mbo,ps_emailsmanager,ps_advertising)"
        }
      }
      /var/www/html/classes/db/Db.php:377 { …}
      /var/www/html/classes/db/Db.php:567 { …}
      /var/www/html/modules/autoupgrade/upgrade/php/ps_1770_preset_tab_enabled.php:47 { …}
      ps_1770_preset_tab_enabled() {}
      /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php:382 { …}
      /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php:346 { …}
      /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php:270 { …}
      /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader80.php:49 { …}
      /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php:103 { …}
      /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader81.php:46 { …}
      /var/www/html/modules/autoupgrade/classes/TaskRunner/Upgrade/UpgradeDb.php:43 { …}
      /var/www/html/modules/autoupgrade/classes/TaskRunner/ChainedTasks.php:52 { …}
      /var/www/html/modules/autoupgrade/cli-upgrade.php:39 { …}
    }
  }
  trace: {
    /var/www/html/classes/db/DbPDO.php:151 {
      DbPDOCore->_query($sql)^
      › } catch (\PDOException $exception) {
      ›     throw new PrestaShopException($exception->getMessage(), (int) $exception->getCode(), $exception);
      › }
    }
    /var/www/html/classes/db/Db.php:377 { …}
    /var/www/html/classes/db/Db.php:567 { …}
    /var/www/html/modules/autoupgrade/upgrade/php/ps_1770_preset_tab_enabled.php:47 { …}
    ps_1770_preset_tab_enabled() {}
    /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php:382 { …}
    /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php:346 { …}
    /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php:270 { …}
    /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader80.php:49 { …}
    /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader.php:103 { …}
    /var/www/html/modules/autoupgrade/classes/UpgradeTools/CoreUpgrader/CoreUpgrader81.php:46 { …}
    /var/www/html/modules/autoupgrade/classes/TaskRunner/Upgrade/UpgradeDb.php:43 { …}
    /var/www/html/modules/autoupgrade/classes/TaskRunner/ChainedTasks.php:52 { …}
    /var/www/html/modules/autoupgrade/cli-upgrade.php:39 { …}
  }
}

Duplicates. Closing in favor of #571.
@ Could you please review #571 PR and merge ?


Add git daemon

git daemon can be run as inetd daemon, but here is an example how to run it in s6. The script assumes an existing git user, but the user is normally created anyway to gain ssh-git acces with<EMAIL_ADDRESS>

On Tue Mar 30, 2021 at 4:29 PM CEST, Muhammad Mahendra Subrata wrote:

@mumahendras3 requested changes on this pull request.
I think the service name should be changed to git-daemon instead of
just git to be more clear on what the service is for.

@@ -0,0 +1,14 @@
+#!/bin/execlineb -P

+########################
+# Start the git daemon #
+########################
+
+fdmove -c 2 1
+s6-setuidgid git
+s6-envdir env
+multisubstitute {

importas -u CMD CMD
importas -usCd" " CMD_OPTS CMD_OPTS
+}
+exec -c $CMD $CMD_OPTS

I believe this should be emptyenv instead of exec :)

@@ -0,0 +1,2 @@
+/var/log/git

Let's change the name to git-daemon instead of just git

@@ -0,0 +1,5 @@
+bind-run
+# Comment out "remount-root" and uncomment "local-fs"
+# if you use separate partition for /var

Probably /srv instead of /var?

@@ -0,0 +1,14 @@
+#!/bin/execlineb -P

+########################
+# Start the git daemon #
+########################
+
+fdmove -c 2 1
+s6-setuidgid git
+s6-envdir env
Add emptyenv -p before s6-envdir env

@@ -0,0 +1 @@
+git

Will there be a problem if we invoke /usr/libexec/git-core/git-daemon
directly? Because it seems that git daemon will just invoke
/usr/libexec/git-core/git-daemon with all command line arguments given
after git daemon passed to /usr/libexec/git-core/git-daemon.
Invoking /usr/libexec/git-core/git-daemon directly will simplify the
process tree as shown in htop tree format (for example).

This seems to work.

On Sat Apr 3, 2021 at 8:21 AM CEST, Muhammad Mahendra Subrata wrote:

@mumahendras3 requested changes on this pull request.

@@ -0,0 +1,15 @@
+#!/bin/execlineb -P

+########################
+# Start the git daemon #
+########################
+
+fdmove -c 2 1
+s6-setuidgid git
+emptyenv -p
+s6-envdir env
+multisubstitute {

importas -u CMD CMD
importas -usCd" " CMD_OPTS CMD_OPTS
+}
+emptyenv -c $CMD $CMD_OPTS

Just a minor request, please change emptyenv -c $CMD $CMD_OPTS to
emptyenv -c
exec -a git-daemon $CMD $CMD_OPTS

To make it cleaner to look at when looking at the process name in htop
or ps for example :D

Done.

Sorry for not mentioning this before (I forgot to mention it), does git-daemon still work when PATH is undefined? If it still works, probably change emptyenv -c to emptyenv -c unexport PATH. If it needs a proper PATH, then restrict it to just /usr/bin:/bin (or other else) by creating env/PATH.
I've never used git-daemon before so I'm not really familiar with it.

exec -a git-daemon broke the daemon because it couldn't find other
binaries and I got "error: cannot run upload-pack: No such file or
directory" when I tried to clone something.
So I've set the path to /bin:/usr/libexec/git-core.
On Sat Apr 3, 2021 at 10:14 AM CEST, Muhammad Mahendra Subrata wrote:

Sorry for not mentioning this before (I forgot to mention it), does
git-daemon still work when PATH is undefined? If it still works,
probably change emptyenv -c to emptyenv -c unexport PATH. If it
needs a proper PATH, then restrict it to just /usr/bin:/bin (or
other else) by creating env/PATH.
I've never used git-daemon before so I'm not really familiar with it.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/mumahendras3/sl6ckware/pull/8#issuecomment-812832736


chore: bdd-spring-1582900929 to 0.0.1

chore: Promote bdd-spring-1582900929 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Remove table name globals

These make the code more complex and make the the queries harder to read.
(A bit of history, since I was a dev way back when this became a Big Deal: configurable table names is an antipattern that stemmed from old PHP (or similar) web hosts that came with a single MySQL database requiring you use different prefixes to load multiple instances of code into the same database.  Without insane mysql configurations, prefix configurability is an antipattern that just results in less readable code.)
Also a one-line fix here that lets the program work on slightly older rust compiler versions.

Not a strong opinion, but these globals were preventing typos in table names and would make refactoring easier. I don't think the purpose was to make them "configurable".


Read config from filesystem

Would be nice to be able to read the config from a file. This would allow you to point this extension to your ~/.aws/config, meaning any updates only need to be done once.

:+1:

I was actually thinking about creating a PR for this. The extension cannot read a file outside of itself afaik. What it can do, is read a file from it's local folder.
So if you would create a symlink from ~/.aws/config to the extension directory (that would be ~/Library/Application Support/Google/Chrome/[profile]/Extensions/[extension_id]/[version]/. The extension would be able to read it from there.
I'll see if I can create a PR for that feature.

A limitation of the browser extension is that it cannot load the local file system in the background.


[METRICS-2805] Add default query context

Description
This PR configures default query context
priority = -1
timeout = 30000

Reference
PR for adding the "defaultQueryContext" field

This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Key changed/added classes in this PR

MyFoo
OurBar
TheirBaz

Can u edit the PR description and explain why we are setting this?

Once the build succeeds, we can try this in lab cluster

removed reference to internal documents and plans


DropShadowFilter initial commit

@bigtimebuddy, will DropShadowFilter be included in the next PixiJS release? It is missing in the 4.0.1 too as far as I can see.

Life is pretty busy at the mo, but this task is next on my hit list peeps 👍

+1

@GoodBoyDigital Any updates?

We are also very interested in this. We have been waiting since 4.0. It looks from the review comments that the review requests only deal with examples, while the filter itself works. So maybe this can be considered as is for the next release?

@alstrup I haven't been able to get funkypaul's implementation working. Gives me some undefined errors.

Its not finished, there are errors in pixi itself preventing from having dropshadow working. I reported that to pixi guys, but it seems theyre pretty busy atm.

Any details if we could have somehow help out?

If you lanch the branch you can see that:
FilterManager.js:289
Uncaught TypeError: Cannot read property 'bind' of undefined
the gl.TEXTURE0 is undefined
This is in filtermanager. I didnt proceed from that step.

@funkypaul, Hi, there is a problem when building this dropshadow filter with npm. Am I doing something wrong?
npm run build:dropshadow

<EMAIL_ADDRESS>build:dropshadow /Users/vzakharov/pixi-filters-DropShadowFilter
pixify -s src/dropshadow -n dropshadow

/Users/vzakharov/pixi-filters-DropShadowFilter/node_modules/pixify/index.js:49
options = Object.assign({}, options, args);
^
TypeError: undefined is not a function
at bundle (/Users/vzakharov/pixi-filters-DropShadowFilter/node_modules/pixify/index.js:49:22)
at Object. (/Users/vzakharov/pixi-filters-DropShadowFilter/node_modules/pixify/index.js:61:1)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Function.Module.runMain (module.js:501:10)
at startup (node.js:129:16)
at node.js:814:3
npm ERR! Darwin 15.6.0
npm ERR! argv "node" "/usr/local/bin/npm" "run" "build:dropshadow"
npm ERR! node v0.12.0
npm ERR! npm  v2.5.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build:dropshadow: pixify -s src/dropshadow -n dropshadow
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:dropshadow script 'pixify -s src/dropshadow -n dropshadow'.
npm ERR! This is most likely a problem with the pixi-filters package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     pixify -s src/dropshadow -n dropshadow
npm ERR! You can get their info via:
npm ERR!     npm owner ls pixi-filters
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/vzakharov/pixi-filters-DropShadowFilter/npm-debug.log

You need to be using node v6.x; you are on 0.12.x

@themoonrat , thanks a lot. Builds fine with v6. Unfortunately mac brew does not provide the latest node version.

To me that was enough to add a check for default value of sampler2D in the FilterManager.prototype.syncUniforms and do nothing for default value 0.
...
//TODO Cacheing layer..
for(var i in uniformData)
{
if(uniformData[i].type === 'sampler2D' && uniforms[i] != 0)
{
shader.uniforms[i] = textureCount;
...

And its appplying shadow correctly? can you share a screenshot? if yes, please create a PR to pixi with this fix.

That is your DropShadow around rectangle 100x100

@funkypaul , minor issue: in the alpha getter/setter this.blurYTintFilter.uniforms.alpha should be used instead of this.blurYTintFilter.uniforms.alpha.value.

Any news on this ?

Please, dear Pixi, we need DropShadowFilter! 🙏

I used this for Pixi 4:
`DropShadowFilter.sharedCopyFilter = new PIXI.Filter();
function DropShadowFilter(angle, distance, spread, color, alpha) {
PIXI.Filter.call(this);
angle *= Math.PI / 180;
this.angle = angle;
this.padding = distance;
this.distance = distance;
this.color = color;
this.padding = distance < 10 ? 10 : distance;
this.blur = spread;
this.alpha = alpha;

this.tintFilter = new PIXI.Filter(
    PIXI.Filter.defaultVertexSrc,
    ['varying vec2 vTextureCoord;',
    'uniform sampler2D uSampler;',
    'uniform float alpha;',
    'uniform vec3 color;',
    'void main(void){',
    '   vec4 sample = texture2D(uSampler, vTextureCoord);',
    '   gl_FragColor = vec4(color, sample.a > 0.0 ? alpha : 0.0);',
  '}'].join("\n")
);
this.tintFilter.uniforms.alpha = alpha;
this.tintFilter.uniforms.color = PIXI.utils.hex2rgb(color);

this.blurFilter = new PIXI.filters.BlurFilter();
this.blurFilter.blur = spread;

}
DropShadowFilter.prototype = Object.create(PIXI.Filter.prototype);
DropShadowFilter.prototype.constructor = DropShadowFilter;
DropShadowFilter.prototype.apply = function (filterManager, input, output) {
var rt = filterManager.getRenderTarget();
rt.clear();
if (!output.root) output.clear();
rt.transform = new PIXI.Matrix();
rt.transform.translate(this.distance * Math.cos(this.angle), this.distance * Math.sin(this.angle));
this.tintFilter.apply(filterManager, input, rt);
this.blurFilter.apply(filterManager, rt, output);
DropShadowFilter.sharedCopyFilter.apply(filterManager, input, output);

rt.transform = null;
filterManager.returnRenderTarget(rt);

};
PIXI.filters.DropShadowFilter = DropShadowFilter;`

@VsevolodZakharov thanks for this! However it doesn't quite work? It appears to be incorrectly copy/pasted from your other post here: http://www.html5gamedevs.com/topic/24999-dropshadowfilter/
And even when using that other post, the shadow always appears white? How would I get a black shadow?

@kennardconsulting , it is not copy-paste , the version above is better (no bugs, working shadow parameters). Unfortunately GitHub code tag does not work well for this piece of code somehow. I've attached the file here - just include that after including pixi.min.js
pixi.filters.js.zip.
Filter constructor example is "new DropShadowFilter(0.5, 10.0, 2.0,  0, 1.0)"

Just upgraded to 4.0 after two years, can confirm that @VsevolodZakharov's solution works perfectly!

Cleaned up a version of DropShowFilter posted here by @VsevolodZakharov. Will add to coming v1.1, see PR #30.

Fantastic! Thanks everyone!


Fix typos and grammatical errors in README.md file

Summary:
Fixed grammatical errors.
Fixed spelling mistakes.

I signed it

I signed it

@Chiranjivee thanks for your PR. Please take a look at some of the suggestions I made.

what are the contributions in this PR?

@tengqm fixed spelling mistakes and grammatical errors.

@Rajakavitha1 I am not able to find your suggestions.

@tengqm fixed spelling mistakes and grammatical errors.

@Chiranjivee there are no spelling mistakes. The fix you made are better wording (site to website) :)

/lgtm
/approve


BiTrade Support

Tested & confirmed working
May cause some resolves, still do after PR #16

Shouldn't AdminEventListener be changed too?

There was a reason why i didn't, cant remember what it was though


In Dockerfile section: npm run docker:run not working

There's currently an issue with the npm run docker:run command.
It seems that Docker doesn't properly read the .env file, resulting in the error.

More details on the issue: when ran inside the container, @azure/identity cannot access the managed identity from the Azure CLI: https://github.com/Azure/azure-sdk-for-net/issues/19167
Workarounds are pretty convoluted here, and the issue has been fixed in the qdrant variant of the workshop.
The AI Search variant of the workshop cannot run the image locally, so the workshop will be updated to reflect that.


DOC: removed a triple f in Difffusion. (#308)

Coverage remained the same at 43.671% when pulling ffe37295b83e5b280895fd3d2bb0e3a8b8666cec on DOC_diffusion_typo into f2506facd51591e521a83a36c5972fe0435b945a on master.

@agahkarakuzu can you approve this typo?

Closing this PR for now, will repoen again to test if PR templates are functional.


ReferenceError: Can't find variable: Promise

I'm using mocha-phantomjs 3.5.0 (phantomjs 1.9.7). My mocha tests pass in Chrome but phantom gives the error above.
:ghost:

@JamesMGreene some update about this? :)

I ended using a simple workaround; adding this Promise Polyfill at the beginning of the tests, hope be util for you!

Although the current master isn't quite where we hoped it would be, we are planning to release it as v2.0.0 on January 23rd (?) and work out the remaining kinks from there once we can all shift focus to v2 x.

That said: I have not verified that the native Promise API is implemented in master.

PhantomJS 2 doesn't have support for native Promise API.

+1
Promise is available natively in all modern browsers except IEs (IE12 has it)... it's a must have!

+1

Node has Promise and notably SilmerJS it too. The devs had the idea to make webpage.open to return a Promise which is IMHO a great improvement to the API.

Just ran into this. I'll give the polyfill a try.

Shims (polyfills) for promises work well.

Any progress on this?

Using es6-promise polyfill works for me. But the promise must be put into the page's js code, not to the phantomjs script.

+1
es6-promise works for me as well as polyfill though (PhantomJS 2.0.0).

+1

+1

+1

We had the same problem and choose to inject Babel into our test suite for now.
Our unit tests runs on node.js with jasmine and are therefor ok with Promise.
But our cucumber tests runs into phantom.js and we injected Babel libray to polyfill Promise.
https://babeljs.io/ works great, but maybe to have «native support» of ES6 feature would even better :)

@floverdevel That is what i have been doing. Would agree that it would be cool to have native support. but there is things that not even a precompiler can solve... like if the website i'm navigate to uses arrow function, generators and what not.
That is why i'm considering switching to SlimerJS to use an up to date Gecko browser. Seems to me that phantomjs is falling behind on the webkits release cycle's :-1:
Would love phantomjs if it used Blinks engine and had auto update as well. Having to wait for a third party to update their product and update is dependency is urck.
It's like this with samsung phones. Just buy Google's Nexa phone and you know you will be the first to receive an update. Don't have to wait for samsung to wait for next android version so they can update the consumer's phone 3-8 month later or even at all.

@jimmywarting i love the comparison with Samsung and the Android update :P

+1

+1

+1

+1

+1

+1

+1

+1

+1

+1

Can you stop writing +1 so we don't get useless notifications all the time
Github have introduced reactions. use that instead.

Running into this issue also. including https://raw.githubusercontent.com/stefanpenner/es6-promise/master/dist/es6-promise.min.js does the job. Would be great to support es6 in pjs though..

I have an open issue on StackOverflow regarding promise support and CasperJS.  We ended up moving to SlimerJS until the support for native promises is added to phantomJS.  The issue is here:   http://stackoverflow.com/questions/36603470/casperjs-phantomjs-es6-promise-polyfill for others facing this same issue.  No resolution has been posted on how to handle this in the client and I was unable to inject anything into phantom that would handle the support for whatever reason.  If someone has a resolution it would be greatly appreciated otherwise I look forward to the native promise support in Phantom when it becomes available.  Thank you for the hard work!

Either es6-promise and promise-polyfill do the trick!
Thank you @dbaba, @zzarcon and @kawing-chiu for the suggestions!
Just need to include one of them in karma.conf.js in files option
es6-promise:
files: ['./node_modules/es6-promise/dist/es6-promise.js']
promise-polyfill:
files: ['./node_modules/promise-polyfill/promise.js']

Please track ES6 support in #14506. Thank you!

+1

@dbaba how did you go about adding the Promise polyfill?  Are you adding it to original source webpage or injecting it somehow using PhantomJS?
Thanks in advance.

There's a phantomjs polyfill that can downloaded via the npm manager, https://www.npmjs.com/package/phantomjs-polyfill this helps resolve the promise error you will encounter

@Zoheb-hassan the page of https://github.com/ariya/phantomjs/issues/link is 404

+1 :D Get ES6 support faster ffs.

The following in karma.conf.js did not work for me
files: ['./node_modules/es6-promise/dist/es6-promise.js']
I had to change it to this to get it to work :)
files: ['./node_modules/es6-promise/dist/es6-promise.auto.js']


Tire pressures are being converted incorrectly

I think sometime recently the reported tire pressures in PSI are now showing values that are actually in kPa. All of my PSI values in homeassistant/sensor/[VIN]/tire_pressure/state  are now in the ~260 range, and 260 kPA is about 38 PSI. The standard non-PSI values are in the ~1800 range, so it really seems like all of the pressure values are getting an extra PSI-to-kPA conversion.
I don't see any open issues in OnstarJS, so I'm not sure whether I should submit this here or there. I see some unit conversions in the onstar2mqtt source, but it could be that OnstarJS is reporting the wrong units.
I'm currently running the latest docker image that reports version 1.5.5 in the logs.

Submitted a corresponding issue to OnStarJS.
OnStarJS Issue #219
For now, I'm doing additional conversions to compensate.

Noticed this too, but looks to be back to normal now.


[loc][Query][testfx | Test Adapter for ASP.net ] Localizability of string: 0; "DynamicDataIEnumerableEmpty"

Hi,
please help localization team to answer question from translator.
In case translator is not sure about context/meaning/localizability of string we raise a question to Core team.
Could you help please? Thanks!**
Source:
Property or method {0} on {1} returns empty IEnumerable<object[]>.
File Name:
TestFramework\MSTest.Core\Resources\xlf\FrameworkMessages.xlf
Resource ID:
0; "DynamicDataIEnumerableEmpty"
Query:
Please clarify the meaning of the placeholders and IEnumerable<object[]>.

@PDostalek : We don't need translation of {0}, {1} and IEnumerable<object[]>. Let them as they are.
For reference, you can see how translation is done for 'DynamicDataIEnumerableNull' in https://github.com/Microsoft/testfx/blob/master/src/TestFramework/MSTest.Core/Resources/xlf/FrameworkMessages.xlf#L275

@jayaranigarg THanks for your reply, I get it. But we would like to know what placeholders stand for to make the rest of string properly localized.

@PDostalek :
String - Property or method {0} on {1} returns empty IEnumerable<object[]>
{0} - can be a method/property name
{1} - Class name containing the above property/method.
Let me know if you need more details.

@PDostalek : Any updates on this?

Thanks for provided info

@PDostalek : Will you be raising a PR for this loc string?

@PDostalek : Any updates on this?


[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line.

What changes were proposed in this pull request?
Refactor the logic for constructing the user classpath from yarn.ApplicationMaster into yarn.Client so that it can be leveraged on the executor side as well, instead of having the driver construct it and pass it to the executor via command-line arguments. A new method, getUserClassPath, is added to CoarseGrainedExecutorBackend which defaults to Nil (consistent with the existing behavior where non-YARN resource managers do not configure the user classpath). YarnCoarseGrainedExecutorBackend overrides this to construct the user classpath from the existing APP_JAR and SECONDARY_JARS configs.
Why are the changes needed?
User-provided JARs are made available to executors using a custom classloader, so they do not appear on the standard Java classpath. Instead, they are passed as a list to the executor which then creates a classloader out of the URLs. Currently in the case of YARN, this list of JARs is crafted by the Driver (in ExecutorRunnable), which then passes the information to the executors (CoarseGrainedExecutorBackend) by specifying each JAR on the executor command line as --user-class-path /path/to/myjar.jar. This can cause extremely long argument lists when there are many JARs, which can cause the OS argument length to be exceeded, typically manifesting as the error message:

/bin/bash: Argument list too long

A Google search indicates that this is not a theoretical problem and afflicts real users, including ours. Passing this list using the configurations instead resolves this issue.
Does this PR introduce any user-facing change?
No, except for fixing the bug, allowing for larger JAR lists to be passed successfully. Configuration of JARs is identical to before.
How was this patch tested?
New unit tests were added in YarnClusterSuite. Also, we have been running a similar fix internally for 4 months with great success.

Test build #139432 has started for PR 32810 at commit fdf6b8d.

cc @mridulm @tgravescs @HeartSaVioR

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43955/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43955/

Test build #139432 has finished for PR 32810 at commit fdf6b8d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43955/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139432/

Pushed up a new commit addressing test failures -- there was a difference between 2.3 and master that I didn't account for.
That also made me realize that due to the changes in YarnCoarseGrainedExecutorBackend from #23706, this can probably be done more cleanly without adding a new configuration. I'll investigate and probably put up a new commit tomorrow.

Test build #139435 has started for PR 32810 at commit 10d1764.

Test build #139435 has finished for PR 32810 at commit 10d1764.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43958/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139435/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43958/

Pushed up a new commit with a simplified approach that doesn't involve a new internal configuration. Updated the description as well. Should be ready for review now.

Test build #139502 has finished for PR 32810 at commit 00518ab.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139502/

The Jenkins build failure is some sort of compilation issue within the catalyst module, doesn't seem related AFAICT. Similar for the GA build, it is failing on the Python linter with some complaints in pandas module.
cc @dongjoon-hyun @holdenk as well in case you have any commentary from the k8s side. I couldn't find any related code in any of the other resource manager modules, but any input would still be welcomed in case k8s suffers from a similar problem, or has already solved this in a different way.

I realized that the existing logic in my PR, which was copied from the ApplicationMaster/driver, wouldn't properly handle local paths which used the GATEWAY_ROOT_PATH / REPLACEMENT_ROOT_PATH mechanism to use a different path on- vs. off-cluster. I guess this was previously a bug in the driver code, but which would only manifest itself with the combination of cluster mode and local URIs leveraging the gateway/replacement paths.
New code follows the strategy used by the old code in ExecutorRunnable to perform local URI replacements as necessary, and since this code is shared between the driver and executors, it fixes the bug discussed above. I also make use of Java NIO APIs for performing the relative-to-absolute and path-to-URL conversions, instead of relying on the Java File API in combination with manual string manipulation to add a file: prefix.
I added more tests in both ClientSuite and YarnClusterSuite for the various options, and also tested running a real job on a real YARN cluster which made use of:

local URI requiring gateway/replacement configs
local URI not requiring gateway/replacement configs
a relative file in the local working dir
a file on shared storage using hdfs scheme, for good measure

Everything works as expected with the latest diff (only the 2nd through 4th would succeed with the previous).

Test build #139719 has started for PR 32810 at commit f780111.

Test build #139719 has finished for PR 32810 at commit f780111.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139719/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44244/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44244/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44244/

Gentle ping @tgravescs if you have a chance to look at the latest diff

Pushed up a new version which expands test cases, extracts some shared constants in the test, and simplifies the logic in getUserClasspathUrls and makes the assumptions more clear via an assert.

Test build #139997 has started for PR 32810 at commit 335256b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44523/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44523/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44523/

Test build #139997 has finished for PR 32810 at commit 335256b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139997/

test this please

@xkrogen can you retriever your GitHub action to test this?

Test build #140080 has started for PR 32810 at commit 335256b.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44608/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44608/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44608/

Hm. The test build did run here, not sure why it's not showing up in the last of checks. Some UI/Selenium builds failed, but it doesn't look related. I will re-trigger.

Test build #140082 has started for PR 32810 at commit f194c2b.

Test build #140080 has finished for PR 32810 at commit 335256b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44610/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140080/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44610/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44610/

Test build #140082 has finished for PR 32810 at commit f194c2b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140082/

can you rekick tests, failures look unrelated

Test build #140150 has started for PR 32810 at commit 31502e3.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44676/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44676/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44676/

Re-triggered, there was again one spurious test failure: PluginContainerSuite.plugin initialization in non-local mode with resources
That test succeeded in the last run; last time the failure was in the hive - slow tests build, which failed on the re-trigger.
Looks like just flaky tests to me, let me know what you think.

Test build #140150 has finished for PR 32810 at commit 31502e3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140150/

Ping @mridulm as well in case you're interested in looking -- since the code has changed quite a bit since you last reviewed.

@xkrogen please look at the test failure:
[info] - plugin initialization in non-local mode with resources *** FAILED *** (11 seconds, 97 milliseconds)
14319
This could very well be from this change is the class path is not being setup properly to pick up the plugin class

Test build #140282 has started for PR 32810 at commit 7eac14a.

Thanks @tgravescs , that's a good point. I was unable to reproduce the test failure locally, and the other plugin-related tests are fine. Re-kicking the test builds again to be sure.
Looks like the test failure is coming from here:
      eventually(timeout(10.seconds), interval(100.millis)) {
        children = dir.listFiles()
        assert(children != null)
        // we have 2 discovery scripts and then expect 1 driver and 1 executor file
        assert(children.length >= 4)
      }
      val execFiles =
        children.filter(_.getName.startsWith(NonLocalModeSparkPlugin.executorFileStr))
      assert(execFiles.size === 1)
      val allLines = Files.readLines(execFiles(0), StandardCharsets.UTF_8)
      assert(allLines.size === 1) // <- fails here

Looks to me like the issue is that the eventually is waiting for all of the files to be present (children.length >= 4), but we don't wait for the content to be ready. Instead, we assume that as soon as the file exists, it's safe to read the content. I can create another JIRA to fix this if you agree.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44813/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44813/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44813/

Test build #140282 has finished for PR 32810 at commit 7eac14a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140282/

looks like the tests passed in the normal QA build and different tests failed this run, so I'll merge

merged to master, it wasn't a clean merge to branch-3.1, were you wanting to get it into that, if so could you put up separate pr?

Thank you @tgravescs ! Your comments along the way were much appreciated.
I put up a branch-3.1 backport at #33090.


Not working with Macbooks with Touch Bar ?

It looks like the touchbar media-keys of MacBooks (with touchbar) is not working, can somebody confirm or is it me ?

It works fine for me, I have a 2017 mac. The button on the touch-bar are greyed out but they work


Limit hit early

I am running a get request from open states people.geo in knime. My workflow is working for the first 10 records and then throwing status 429 which I read as being limit being surpassed but I am only getting 10/500. Please help

Please contact<EMAIL_ADDRESS>for help with this.


More error handling for recoverable/reconnect errors and trade

See title ;)

Hay, good job mate.
I get a NULL pointers when the API throws and error and no data is returned
I changed the lines where you check for data errors
if (data.error.length)
to
'if (data && data.error.length) '

@crubb @nibzo1 I had to refactor the error matching, could you please check if it works as expected ?

@Alexandre-io this seems to trade now for me and I dont seem to have many errors, The bot has been running for 14hrs now and execute about 8 trades with my config.
All look to be good trades too :+1:
Ill look at my log and see what exactly it has done in more retail

@Alexandre-io Working. I'm still running into quite a few timeout errors, I just increased the timeoutMS of the kraken-api 0.1.7 from 5s to 10s.

Yes I see the timeout error too, Does the timeout update fix it?
Also does it fix the
Kraken API is down! unable to call getBalance, retrying in 2.5s


update crio man page.

What I did
update crio man page.

How I did it

How to verify it

@Chenditang Are you still working on this?

/ok-to-test

/retest

Taking over in #2126 since haven't heard back from @Chenditang


"Send" doesn't work with button which contains JSON

Hello!
I'm currently working with this bot and faced the issue which were hard to catch.
Issue appears when to unique field of button assigned string longer then 21 symbol and to data provided marshalized JSON.
As a result no message received from bot.
You may check it by creating a command and handle it by following
import (
	"database/sql"
	"encoding/json"

	tb "gopkg.in/tucnak/telebot.v2"
)

type (
	uniqueInfoTest struct {
		UserID int    `json:"userId"`
		ChatID int64  `json:"chatId"`
		Data   string `json:"data,omitempty"`
	}
)

func Handler(bot *tb.Bot, m *tb.Message) {
	uit := uniqueInfoTest{
		UserID: m.Sender.ID,
		ChatID: m.Chat.ID,
	}
	byteArray, _ := json.Marshal(uit)
	data := string(byteArray)

	menu := bot.NewMarkup()
	btn1 := menu.Data("Up", "ThisIsLongNameOfTheUpButton", data)
	btn2 := menu.Data("Down", "ThisIsLongNameOfTheDownButton", data)

        menu.Inline (
		menu.Row(btn1, btn2),
        )

	bot.Send(m.Sender, "Hello!", menu)
}

First, check the error Send function returns.

It return
Code:400
Description:"Bad Request: BUTTON_DATA_INVALID"
Message:""

Where may I get the reason, why data invalid?

Probably it's too long. It is a bad idea to store the whole structure, especially if you need user and chat IDs as they're already presented in every update you receive.


preflight make build fails on s390x with cgo: C compiler "s390x-linux-gnu-gcc" not found: exec: "s390x-linux-gnu-gcc": executable file not found in $PATH

Bug Description
preflight make build fails on s390x with cgo: C compiler "s390x-linux-gnu-gcc" not found: exec: "s390x-linux-gnu-gcc": executable file not found in $PATH
Version and Command Invocation
(The output of preflight --version)
Steps to Reproduce:
(How can we reproduce this?)

git clone https://github.com/redhat-openshift-ecosystem/openshift-preflight.git
cd openshift-preflight
make build

Expected Result
make build should create a preflight binary.
 If you want to build your app using go-sqlite3, you need gcc. However, after you have built and installed go-sqlite3 with go install github.com/mattn/go-sqlite3 (which requires gcc), you can build your app without relying on gcc in future.
Important: because this is a CGO enabled package, you are required to set the environment variable CGO_ENABLED=1 and have a gcc compile present within your path.

Hi @vikasmulaje,
please see if you have GCC installed. yum list | grep gcc

@itroyano before github.com/mattn/go-sqlite3 library it used to work without asking any dependency. if this is not an issue can we add some note/documentation to add more clarification on this?

Hi @vikasmulaje,
I'm not sure if a note is needed since this isn't an issue with Preflight functionality.
the use case is building the binary natively on your specific s390 machine.
sqlite is a library added to support UBI 9 Beta, and seems it requires the above specific C compiler.  please see if there's a way to install it and have it present in the PATH so the Go compilation can invoke it.

one more thing you can try, is setting CGO_ENABLED=0.
depending on your Go version, it may be enabled by default - and is enabled for native compilation.
note the Preflight build uses Cross-Compilation to create a binary for s390x.

CGO_ENABLED=0 worked thanks


Clearing database + deleting all migrations is not enough to reset wagtail app. Needs removal of venv.

I'm trying to upgrade an app to Wagtail 6.0.1+Django 5.02+python 3.12.2, and it is not going well.
In the process to find the root cause I need to frequently reset the sqlite database and remove all migrations. I expected that after nuking everything, even my custom Pages, that a migration would result in a clean environment.
Instead I get this error:
django.core.exceptions.FieldDoesNotExist: NewQueryDailyHits has no field named 'query'

The only way to 'fix' this is to recreate the venv. Then makemigrations+migrate will work again.
I can't say I'm quite sure why this happens, but haven't had this with other Django packages.
Any suggestions welcome.

I think your issue may be the same or similar to https://github.com/wagtail/wagtail/issues/11690
See the documentation update here https://github.com/wagtail/wagtail/pull/11712
Sorry this has caused you frustration. Please have a look at the PR and see if updating your installed apps makes a difference.

Yes, thank you. I can confirm that adding wagtail.contrib.search_promotions to the installed apps fixes the problem.

Thanks. I'll close this issue then.


keepalived: Please specify full path for pgrep

WARNING - script `pgrep` resolved by path search to `/usr/bin/pgrep`. Please specify full path.

It is /usr/bin/pgrep for Centos/RHEL and Debian/Ubuntu
Thanks!

Added


Accessibility: Intellisense/autocomplete alerts contains superfluous words when using a screenreader

Reported by Rob Gallo:
The text of intellisense/autocomplete needs to be much shorter, perhaps containing only the suggestion and insertion.
In a typescript file in VS Code, using jaws as my screen reader, when I type the letter ‘c’, I hear “’console’ suggestion”. And when I then press enter, I hear, “accepting ‘console’ did insert the following text.”
Every word in both strings is superfluous except for the two instances of ‘console’. The meaning would be perfectly clear if ‘console’ were the only word spoken. In fact, as it stands, the verbosity of these strings is so long that it actually slows me down.
I understand the urge to provide context. However, the distraction and speed bump caused by the repetition of these strings vastly outweighs the benefits of the extra context over time.
I have used intellisense for many years in VisualStudio where it only reads the names of the symbols. I probably know as many blind developers as anyone out there. And I can tell you that this will drive us all crazy.

closing this as dupe of #65499


MCTS training data generation in round1

@lovecambi  It seems that during mcts training data generation in round 1, no "Final Answer:" will be generated by LLM?
# Checkpoint Initialization is required by adding value head python solver_demo.py \ --custom_cfg configs/mcts_round1.yaml \ --qaf ../MARIO_EVAL/data/math_testset_annotation.json
max_solver_steps is set to 1 by default, so LLM generation will stops at "Observation:"?

@lovecambi It seems that during mcts training data generation in round 1, no "Final Answer:" will be generated by LLM?
# Checkpoint Initialization is required by adding value head python solver_demo.py \ --custom_cfg configs/mcts_round1.yaml \ --qaf ../MARIO_EVAL/data/math_testset_annotation.json
max_solver_steps is set to 1 by default, so LLM generation will stops at "Observation:"?

You are correct. I just updated the mcts_round1.yaml.

@lovecambi It seems that during mcts training data generation in round 1, no "Final Answer:" will be generated by LLM?
# Checkpoint Initialization is required by adding value head python solver_demo.py \ --custom_cfg configs/mcts_round1.yaml \ --qaf ../MARIO_EVAL/data/math_testset_annotation.json
max_solver_steps is set to 1 by default, so LLM generation will stops at "Observation:"?

You are correct. I just updated the mcts_round1.yaml.

According to our experience, the iterations can range from 30 to 60 for difficulty levels.


Fix player entity meta data

I'm not 100% confident that what I'm doing here is correct, but looking at http://wiki.vg/Pre-release_protocol#Spawn_Player I think I'm doing it right.
fixes #58

I should probably mention I tested it with this change and it fixed it, so if I didn't do anything obviously wrong it is probably correct.
Without this change you would get the exception if someone was holding an item.
With this change that is no longer the case.

Thanks, this fixes the error not sure if it fixes issues for players but good work!


Fix eth transfer fee

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.78%. Comparing base (fbaacb3) to head (1561162).
Report is 8 commits behind head on develop.

Files with missing lines
Patch %
Lines

src/app.rs
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #329      +/-   ##
===========================================
- Coverage    35.78%   35.78%   -0.01%
===========================================
  Files           23       23
  Lines        10026    10027       +1
===========================================
  Hits          3588     3588
- Misses        6438     6439       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


optimize(undo): change default parser name to json from jackson

close #503

Codecov Report

Merging #525 (277d89f) into master (46da59f) will decrease coverage by 1.56%.
The diff coverage is 30.53%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   38.38%   36.83%   -1.56%
==========================================
  Files         155      159       +4
  Lines       10319    11020     +701
==========================================
+ Hits         3961     4059      +98
- Misses       6032     6615     +583
- Partials      326      346      +20

Impacted Files
Coverage Δ

pkg/client/client.go
0.00% <0.00%> (ø)

pkg/datasource/sql/at_resource_manager.go
0.00% <ø> (ø)

pkg/datasource/sql/conn_at.go
49.20% <ø> (ø)

pkg/datasource/sql/exec/executor.go
0.00% <ø> (ø)

.../datasource/sql/exec/select_for_update_executor.go
0.00% <ø> (ø)

pkg/datasource/sql/plugin.go
100.00% <ø> (ø)

pkg/datasource/sql/tx_at.go
23.52% <ø> (ø)

pkg/datasource/sql/tx_xa.go
45.45% <0.00%> (+12.12%)
:arrow_up:

pkg/datasource/sql/types/types.go
12.82% <ø> (ø)

pkg/datasource/sql/xa/oracle_xa_connection.go
0.00% <ø> (ø)

... and 16 more

... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Detect initial notification on iOS

On iOS, we only get one chance to display the native modal which asks the user if they would like to enable push permissions. Is there a way to detect if they have already said no to this prompt?

I solved this myself by just setting an internal storage flag to true after calling Notifications.registerRemoteNotifications() so I could invoke the settings page when i needed to


Term ref sourcing failed in CSD due to bibitem typo (should be bibitemid)

Trace. This is identical to the bibitemid "typo" we had in the other gem (https://github.com/metanorma/isodoc/issues/117) that was supposed to have fixed by https://github.com/metanorma/metanorma-standoc/commit/14f9d04e626bc52a130532597a4b1835f2fb181e .

====== #<Nokogiri::XML::Element:0x3fe6b5840bbc name="eref" namespace=#<Nokogiri::XML::Namespace:0x3fe6d5f165e8 href="https://www.calconnect.org/standards/csd"> attributes=[#<Nokogiri::XML::Attr:0x3fe6b5840414 name="bibitem" value="CCSTD">]>
bundler: failed to load command: metanorma (/Users/me/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/bin/metanorma)
TypeError: no implicit conversion of nil into String
  /Users/me/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/isodoc-1.0.1/lib/isodoc/function/inline.rb:87:in `+'
  /Users/me/.rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/isodoc-1.0.1/lib/isodoc/function/inline.rb:87:in `eref_parse'

Can we ensure that all gems have this issue fixed? Thanks.

@opoudjis this fix is apparently not released... It's breaking all documents that source terms. We need to add a rspec for term sourcing in metanorma-standoc.

Released


[Wallet] Add display names of scanned QRs to cache

Description
When scanning a QR, the link embedded on the QR has a display name. This PR stores that info on a cache to use it on the activity feed to show the name of the person we scanned the QR from.
Tested
Read a QR code to make a transfer and saw the display name of the scanned QR on the transactions feed.
Related issues

Fixes #1005
Part of #4835

How would you feel about holding off on this PR until the next release?

No strong opinion, sounds good to me :)

Hi @gnardini We have verified task on latest Android play store internal build v1.3.0(1004294316) & Test Flight build v1.3.0(27) and found the following.

Scanned user name is shown on transaction feed when user sending an amount by scanning QR code.
Also, verify that User name is shown on transaction feed for receiver as well.

However, we have updated below issues related to name and profile pic:

https://github.com/celo-org/celo-monorepo/issues/4086
https://github.com/celo-org/celo-monorepo/issues/4084

Please let us know if we need to verify any thing else.
Thanks!


WIP: MultiKueue memory leak test - if I can trigger in the tests [DO NOT MERGE, EXPERIMENT]

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:

Experiment to check if  #3818 is detectable in automated tests
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/close
it seems more work that on the surface, let me open a proper issue for some contributor to take a look.
For the fix, for now, I tested the fix in unit tests and manually.


Add partial haml to reuse topology header toolbar

@miq-bot add_label ui, refactoring, providers/containers
@himdel @martinpovolny please review. thank you

cc @pilhuhn

@miq-bot add_label providers/hawkular

The travis failure looks unrelated:
rspec ./spec/models/ems_refresh/save_inventory_infra_spec.rb:29 # EmsRefresh::SaveInventoryInfra.find_host with ems_ref, hostname and ipaddress

LGTM :) (and agreed, the test does seem unrelated)

@martinpovolny @chessbyte merge please?


esp32 recive from mobile but cannot awnser

Hi, I'm trying to connect the device to my mobile pone using bluetooth and the app Serial Bluetooth Terminal, I have follow this steps:
Using the console of cutecom, connected to the device:
Set the device as server
at+bleinit=2
Create and start services
at+blegattssrvcre
at+blegattssrvstart
Set what data we send (needed specifically this one to connect with SBT)
At+bleadvdata="0201061aff4c000215fda50693a4e24fb1afcfc6eb0764782527b7f206c5"
Look what is the address of the device
At+bleaddr?
Config the serial port
At+blesppcfg=1,1,7,1,5 (this are the characteristics that we want to write and that we want to read from the client)
Start advising
At+bleadvstart
From this point I work in the app:
I look for my device press it and enter to edit, select custom, press at service uuid, the device will connect and give you his services to choose what you will listen and write.
At that point I can send information to the device that is printed in the console, but I can't do the same in the other way, if i try, the device report me an error. How I can configure the app and the device to open a bidireccional comunication?
Thanks

Hi ,
Before ESP32 sends data to the  phone, the phone needs to write the descrption of the 7th characteristic( Enable notification).
And then, Put ESP32 into SPP mode.

AT+BLESPP

Oh, thanks very much, i forgot to put the ESP32 into SPP mode.
Now everything is working nice, but now I can't close the communication without disconecting the terminal app or the device (I tried to send +++ as it's said in the manual, but nothing happen).
Thanks again for everything


Fluxbox vs DateEntry

Desktop (please complete the following information):

ttkbootstrap: 1.9.0

Linux: Linux mx 5.10.0-18-amd64 1 SMP Debian 5.10.140-1 (2022-09-02) x86_64 GNU/Linux

Linux Distro: MXLinux 21.2 (FluxBox)

Fluxbox: fluxbox/mx,now 1.3.7-1~antix1 amd64

Python: 3.9.4, 3.9.14, 3.10.4 and 3.10.7. (I use pyenv to switch versions)

Describe the bug
On FLUXBOX (MX Linux/Fluxbox), when you press DataEntry button, the data entry window does not show. But, if you press ALT-TAB making main app window go away and back, the data entry window appear properly.
I switched back to XFCE and everything works just fine. FluxBox desktop environment is a bit odd compared to the mainstream desktop environments. It is really fast, but some software, like "sqlitebrowser" for example, have problem with their windows sizes.
Maybe it is just a problem with fluxbox, or this fluxbox specific version. But I would like to know if you guys have problems with DataEntry in your desktop enviromment.
To Reproduce
Click on DataEntry button. Window does not appear.
Expected behavior
DataEntry window should appear when DataEntry button is clicked.
Screenshots
No response
Additional context
No response

This problem happened on my Plasma desktop too.

My guess is it is something related to some FOCUS event. What ALT-TAB does is switch focus, so maybe it is related to toplevel focus.

The problem also happens on Linux mint Mate, python 3.10 and ttk 1.10.
Has anyone found a workaround to resolve the issue?


Rows not displayed for Static Table

Have just updated to v0.4.3 and now when adding a new entry the row is not displayed for static table in "table layout". Only the column headings are shown.

@richhayler Sorry about that issue, please refer to the 0.4.4 release where this is fixed. Sorry again!

All good. I love this plugin - so awesome to have more control over my field layouts.

Great! Any suggestions on how we can make it better let us know :smiley:

Here's a screenshot of a little extra CSS I added to the plugin to hide the table and row styling. Happy to share if you would like me to send this to you. http://hayler.com/supertable.png

@richhayler Seems pretty cool! Happy to stick with the Craft-esque style at the moment, but I do plan on giving a lot more control in how things are laid out. Thanks for sharing though!


Suggestion about PHP 5 compatibility

Hello
Thanks for this great packages, that is very interresting. I've just one regret, that there is no version compatible with PHP 5.
Perharps a version 1.x compatible PHP5, and get version 2.x compatible PHP 7.
What do you think about this ?

Hey, I'm glad you like this library.
But as for PHP 5 support, I've used many PHP 7 features in both code and tests, so making them compatible with older PHP versions would be wasted effort . Besides, I believe that one of the ways to stimulate/make people use latest PHP versions is just by libraries specifying them in system requirements.

I'll have a deeper look tomorrow, but as at my office we still use PHP 5.6, I'd like to use your library.
I've myself created a solution, but it seems too complex to be understood by many of developpers in my current entreprise.
So, what is I will propose: I've able to create a PHP5 version and keep maintained until PHP 5 disappear complety. Are you agree ?

Feel free to fork my library and adapt it work on PHP 5.6. That way someone will have a reference to my version that is PHP7-only. Also, I would appreciate if you don't publish it on Packagist, but tell the Composer to install it directly from GitHub repo.

Will do it (fork) in next days. And of course reference you !
In my compagny we will use my PHP 5 version until we switch to PHP 7, and then use your version !
Thanks for quick feedback : I've appreciated a lot !

The PHP 5 version will be a private copy available only on my compagny (with a credit note to your package and link of course).
When we will switch to PHP 7, one day, we will use your package ! I will close this question report now

That's great, thank you.