MTR and Microsoft 365 network connectivity principles

[Enter feedback here]
Feedback on this statement:
Generally, Teams Rooms has the same network requirements as any Microsoft Teams client. Access through firewalls and other security devices is the same for Teams Rooms as for any other Microsoft Teams client. Specific to Teams Rooms, the categories listed as "required" for Teams must be open on your firewall. Teams Rooms also needs access to Windows Update and Microsoft Store. For the full list of IPs and URLs required for Microsoft Teams Rooms, see:
This does not completely match our O365 URL/IP category guidance published here.
And specifically:
In our previous guidance for managing Microsoft 365 traffic, endpoints were organized into two categories, Required and Optional. Endpoints within each category required different optimizations depending on the criticality of the service, and many customers faced challenges in justifying the application of the same network optimizations to the full list of Office 365 URLs and IP addresses.
In the new model, endpoints are segregated into three categories, Optimize, Allow, and Default, providing a priority-based pivot on where to focus network optimization efforts to realize the best performance improvements and return on investment. The endpoints are consolidated in the above categories based on the sensitivity of the effective user experience to network quality, volume, and performance envelope of scenarios and ease of implementation. Recommended optimizations can be applied the same way to all endpoints in a given category.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa81c0c7-1f2d-09ed-da2d-298aba689e56
Version Independent ID: 73fd96c0-2b94-d7ea-f900-e88b84344bdd
Content: Microsoft Teams Rooms Security - Microsoft Teams
Content Source: Teams/rooms/security.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Thanks for the feedback Paul.  My understanding is that these new categories are defined where customers can focus their efforts to optimize traffic on between the services and the different endpoints.  I still think our statement of all the "required" addresses should be open to the firewall, but within each of these "required" addresses, there are the new categories on where admins have more flexibility to optimize the network performance for the scenarios.

Thanks for the feedback Paul.  My understanding is that these new categories are defined where customers can focus their efforts to optimize traffic on between the services and the different endpoints.  I still think our statement of all the "required" addresses should be open to the firewall, but within each of these "required" addresses, there are the new categories on where admins have more flexibility to optimize the network performance for the scenarios.

@paulch7780 If you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.html
Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=npherson
@kdspiess It seems that the article does not exist or I don't have access. If you need help with it, please let me know. Thanks!

@paulch7780 If you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.html
Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=npherson
@kdspiess It seems that the article does not exist or I don't have access. If you need help with it, please let me know. Thanks!

Converted my account, thanks for the hint.
Dario, are you saying you cannot access: https://review.docs.microsoft.com/en-us/microsoftteams/rooms/security?branch=dstrome-mtr-security#network-security ?
From: Dario Woitasen<EMAIL_ADDRESS>Sent: Friday, January 8, 2021 8:40 PM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Paul Cherbin<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] MTR and Microsoft 365 network connectivity principles (#6434)
@paulch7780https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpaulch7780&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186403059|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Kl8qNnjiHMABPs7tn%2B%2BKtLpN0Cb8xq%2BiebqNq8%2BjxEA%3D&reserved=0 If you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.htmlhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.opensource.microsoft.com%2Ftools%2Fgithub%2Findex.html&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186413006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=aNh%2FcKqk0fhTpioYCxkjuGoyNJzw4UVB7i%2B36Xr9d0c%3D&reserved=0
Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=nphersonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepos.opensource.microsoft.com%2Fpeople%3Fq%3Dnpherson&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186413006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=LkLW4r16g6cLRj6o%2B8BMO0H8fu3eUGWVa2XYb%2BEA1dU%3D&reserved=0
@kdspiesshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkdspiess&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186422972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=nh1hprlb4vFaJxXPLJrGVY7wa1kgYIOs7hBHk3K7j6Y%3D&reserved=0 It seems that the article does not exist or I don't have access. If you need help with it, please let me know. Thanks!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F6434%23issuecomment-756956122&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186422972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2FT%2BqXy8TFqc0BRmnLCfhgynlzixdtjl7bA85Oem%2Fkbw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJVLUH45LX4QYO65XXQJNQDSY5NR7ANCNFSM4VUMI43A&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186422972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=f0dj5IZ9CNOQo631Zo%2FVMfcgTBirJd%2FfCz4SvoPEZRU%3D&reserved=0.

Converted my account, thanks for the hint.
Dario, are you saying you cannot access: https://review.docs.microsoft.com/en-us/microsoftteams/rooms/security?branch=dstrome-mtr-security#network-security ?
From: Dario Woitasen<EMAIL_ADDRESS>Sent: Friday, January 8, 2021 8:40 PM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Paul Cherbin<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] MTR and Microsoft 365 network connectivity principles (#6434)
@paulch7780https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpaulch7780&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186403059|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Kl8qNnjiHMABPs7tn%2B%2BKtLpN0Cb8xq%2BiebqNq8%2BjxEA%3D&reserved=0 If you have a Microsoft alias, you can link your accounts in GitHub so that a blue "Microsoft submitter" label appears to any PR's or issue you submit. Guidance on it here: https://docs.opensource.microsoft.com/tools/github/index.htmlhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.opensource.microsoft.com%2Ftools%2Fgithub%2Findex.html&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186413006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=aNh%2FcKqk0fhTpioYCxkjuGoyNJzw4UVB7i%2B36Xr9d0c%3D&reserved=0
Here is the site you can use to see the mappings between GitHub and Microsoft aliases: https://repos.opensource.microsoft.com/people?q=nphersonhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepos.opensource.microsoft.com%2Fpeople%3Fq%3Dnpherson&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186413006|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=LkLW4r16g6cLRj6o%2B8BMO0H8fu3eUGWVa2XYb%2BEA1dU%3D&reserved=0
@kdspiesshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkdspiess&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186422972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=nh1hprlb4vFaJxXPLJrGVY7wa1kgYIOs7hBHk3K7j6Y%3D&reserved=0 It seems that the article does not exist or I don't have access. If you need help with it, please let me know. Thanks!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F6434%23issuecomment-756956122&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186422972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2FT%2BqXy8TFqc0BRmnLCfhgynlzixdtjl7bA85Oem%2Fkbw%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJVLUH45LX4QYO65XXQJNQDSY5NR7ANCNFSM4VUMI43A&data=04|01|pacherbi%40microsoft.com|ed17b2585e224267f44208d8b40d392f|72f988bf86f141af91ab2d7cd011db47|1|0|637457316186422972|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=f0dj5IZ9CNOQo631Zo%2FVMfcgTBirJd%2FfCz4SvoPEZRU%3D&reserved=0.

Thank you, Kyle. Required may indeed be a good "tag".
Are we sure we only need Teams required, do we also need EXO?
Specific to Teams Rooms, the categories listed as "required" for Teams must be open on your firewall.
From: Kyle Spiess<EMAIL_ADDRESS>Sent: Friday, January 8, 2021 7:59 PM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Paul Cherbin<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] MTR and Microsoft 365 network connectivity principles (#6434)
Thanks for the feedback Paul. My understanding is that these new categories are defined where customers can focus their efforts to optimize traffic on between the services and the different endpoints. I still think our statement of all the "required" addresses should be open to the firewall, but within each of these "required" addresses, there are the new categories on where admins have more flexibility to optimize the network performance for the scenarios.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F6434%23issuecomment-756937483&data=04|01|pacherbi%40microsoft.com|3c72d6b00b3d44d3881c08d8b4076adf|72f988bf86f141af91ab2d7cd011db47|1|0|637457291256068887|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=r%2BS7xOtRj%2FxqL7TwoV7RvSBOx902bYuV5igzc%2BhdhH0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJVLUH7EVJ43R76LQNYWO6TSY5IWDANCNFSM4VUMI43A&data=04|01|pacherbi%40microsoft.com|3c72d6b00b3d44d3881c08d8b4076adf|72f988bf86f141af91ab2d7cd011db47|1|0|637457291256078844|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PvIHw%2BziKkNZ77A3sSsY2NF2IwuHBqGdxQC1%2BFt4saU%3D&reserved=0.

Thank you, Kyle. Required may indeed be a good "tag".
Are we sure we only need Teams required, do we also need EXO?
Specific to Teams Rooms, the categories listed as "required" for Teams must be open on your firewall.
From: Kyle Spiess<EMAIL_ADDRESS>Sent: Friday, January 8, 2021 7:59 PM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Paul Cherbin<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] MTR and Microsoft 365 network connectivity principles (#6434)
Thanks for the feedback Paul. My understanding is that these new categories are defined where customers can focus their efforts to optimize traffic on between the services and the different endpoints. I still think our statement of all the "required" addresses should be open to the firewall, but within each of these "required" addresses, there are the new categories on where admins have more flexibility to optimize the network performance for the scenarios.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F6434%23issuecomment-756937483&data=04|01|pacherbi%40microsoft.com|3c72d6b00b3d44d3881c08d8b4076adf|72f988bf86f141af91ab2d7cd011db47|1|0|637457291256068887|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=r%2BS7xOtRj%2FxqL7TwoV7RvSBOx902bYuV5igzc%2BhdhH0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJVLUH7EVJ43R76LQNYWO6TSY5IWDANCNFSM4VUMI43A&data=04|01|pacherbi%40microsoft.com|3c72d6b00b3d44d3881c08d8b4076adf|72f988bf86f141af91ab2d7cd011db47|1|0|637457291256078844|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=PvIHw%2BziKkNZ77A3sSsY2NF2IwuHBqGdxQC1%2BFt4saU%3D&reserved=0.

Hi @paulch7780,
I don't have access because I don't have a Microsoft account. I'm a member of a team of freelancers technical writers helping to improve docs.microsoft.com.
I think @dstrome can help you.
Thanks!

Hi @paulch7780,
I don't have access because I don't have a Microsoft account. I'm a member of a team of freelancers technical writers helping to improve docs.microsoft.com.
I think @dstrome can help you.
Thanks!

@paulch7780 now this article is public, and I can see it.
It seems that this issue can be closed and the other you opened as all of them were fixed or answered. Are you agree?

@scanum I think we can close this issue. Thank you!

Hi Dario, please do not close the issue. We have customer feedback on this specific point and a side conversation with Kyle + Paul.
From: Dario Woitasen @.>
Sent: Wednesday, April 7, 2021 10:09 AM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness @.>
Cc: Paul Cherbin @.>; Mention @.>
Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] MTR and Microsoft 365 network connectivity principles (#6434)
@scanumhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fscanum&data=04|01|pacherbi%40microsoft.com|56a7f2c0651443a770a408d8f99c58d3|72f988bf86f141af91ab2d7cd011db47|1|0|637533797195919608|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2B%2FIot9bfhmn6Ki6Ut2XrWU65VQFRYxLAbiasFhY6ic0%3D&reserved=0 I think we can close this issue. Thank you!

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fissues%2F6434%23issuecomment-814701386&data=04|01|pacherbi%40microsoft.com|56a7f2c0651443a770a408d8f99c58d3|72f988bf86f141af91ab2d7cd011db47|1|0|637533797195919608|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=1rvDCdgi6cbLTODUhD3ZvCLXre3OIeRS1lbP5YZZKNI%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJVLUHYCUAA2CLWE6RDG6F3THQHIJANCNFSM4VUMI43A&data=04|01|pacherbi%40microsoft.com|56a7f2c0651443a770a408d8f99c58d3|72f988bf86f141af91ab2d7cd011db47|1|0|637533797195929601|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=v5H2F2f0PP7p4bdjTjErDkBVtSkP2Fngwbgj1Xb6VeE%3D&reserved=0.

Ok, don't worry @paulch7780, we can keep it open. Please keep us posted on the resolution to feed whatever information you discover into the content.
Thank you!

@scanum please keep it open. Thank you!


Throw in all try/catch assertions to catch false-positive tests

This PR adds a throw statement at the end of all try blocks found in the tests to ensure that tests cannot pass because the expected error was not thrown.
This caught three false-positives:

Packing should fail if a number greater than 32 bits is used - The test number used did not actually have 36 bits.
Reverts when querying an invalid proposal id - This function is not expected to revert when a proposal ID does not exist.
Authentication should fail if the correct hash of the payload is not committed on l1 before execution is called - The test was using the correct selector.

Thanks for your PR! ❤
I'm glad you caught these. I'm also glad the code itself is behaving as expected, and it's the "only" the tests that invalid.
I'll let @Orland0x have a look before we merge.
One thing that caught my attention is the reverts when querying an invalid proposal id. I'm wondering if it would make more sense, for the end user, for this call to fail, rather than to ask the user to check that proposal.timesetamp == 0. What do you both think, @Orland0x @solimander ?

Agreed, I think a revert here if the proposal does not exist would be good

LGTM


Web: Close paymentsheet gives console error and cancellation event not sent and invalid cards sending Complete Event

Describe the bug
On the web, when presenting a paymentsheet, if the end-user clicks on the close button it results to a console error. And as the DOM is not cleaned (we see several stripe-payment-sheet tags when closing and reopening), the last event sent seems to be duplicated. We can have the completed event fired twice and sometimes even thrice or more.
Additionally when using an invalid test card provided by stripe<PHONE_NUMBER>009995 for instance, the presentPayment sends back a complete event instead of a Failed one (the payment actually fails on the stripe server)
ERROR Error: Uncaught (in promise): [object Undefined]
    at w (polyfills.2de6c3c3713ec7b7058a.js:1)
    at polyfills.2de6c3c3713ec7b7058a.js:1
    at polyfills.2de6c3c3713ec7b7058a.js:1
    at e.invoke (polyfills.2de6c3c3713ec7b7058a.js:1)
    at Object.onInvoke (main.6ccd78685919c5fcb4bf.js:1)
    at e.invoke (polyfills.2de6c3c3713ec7b7058a.js:1)
    at t.run (polyfills.2de6c3c3713ec7b7058a.js:1)
    at polyfills.2de6c3c3713ec7b7058a.js:1
    at e.invokeTask (polyfills.2de6c3c3713ec7b7058a.js:1)
    at Object.onInvokeTask (main.6ccd78685919c5fcb4bf.js:1)

To Reproduce
Steps to reproduce the behavior:

Go to https://capacitor-community-stripe.netlify.app/tabs/tab1
Click on F12, create payment sheet, close it and check the console to see the error
Verify that no PaymentFlowEventsEnum.Canceled is sent
See error
Go to https://capacitor-community-stripe.netlify.app/tabs/tab1
Click on F12, create payment sheet, present it and enter a test card with insufficient fund eg.<PHONE_NUMBER>009995
Verify that no PaymentFlowEventsEnum.Completed is sent instead of PaymentFlowEventsEnum.Failed
See error
Expected behavior
Closing the payment sheet should not result on error and send Canceled event. Moreover, the stripe-payment-sheet should be removed from the DOM to avoid unexpected behaviors.
Failed cards should not send Completed event but Failed event

Screenshots

Desktop (please complete the following information):

OS: windows 10
Browser chrome
Version 95.0.4638.54 (Official Build) (64-bit)

@ivantchomgue
I'm curious to know how you got it to work on web. I setup a "Pay Now" button, which await createsStripePaymentIntent()
await createEphemeralKeys()
await createPaymentSheet()
// Display payment sheet.
I keep getting Missing argument, make sure to call mount() with valid DOM.
Mind sharing what your doing? I am using NuxtJS.
Thanks!

in my main.ts

` async checkout() {
  if(!this.connectedUser.paymentCustomerId) {
    //create stripe customer account if not existing
    try {
      const customer = await this.http.post<{paymentCustomerId: string}>(environment.dev.serverUrl + '/api/customer', {
        email: this.connectedUser.email,
        name: this.connectedUser.given_name?
        (this.connectedUser.given_name + (this.connectedUser.family_name?` ${this.connectedUser.family_name}`:'')):
        this.connectedUser.family_name || this.connectedUser.nickname,
        id: this.connectedUser.sub
      }).toPromise();
      console.log(customer);
      this.connectedUser.paymentCustomerId = customer.paymentCustomerId;
    } catch(error) {
      console.error(error);
    }
  }

  if (!this.paymentIntent || !this.ephemeralKey) {
    const { paymentIntent, ephemeralKey, customer, error } =  await this.http.post<{
      paymentIntent?: string;
      ephemeralKey?: string;
      customer?: string;
      error?: any;
    }>(environment.dev.serverUrl + '/api/payment-sheet', {
      customer: this.connectedUser.paymentCustomerId,
      amount: this.totalAmount * 100,
      currency: 'eur'
      }).pipe(first()).toPromise(Promise);
      if(error) {
        console.error('payment intent failed', error);
      } else {
        this.paymentIntent= paymentIntent;
        this.ephemeralKey = ephemeralKey;
      }
  }
  if(this.paymentIntent && this.ephemeralKey) {
    await Stripe.createPaymentSheet({
      paymentIntentClientSecret: this.paymentIntent,
      customerEphemeralKeySecret: this.ephemeralKey,
      customerId: this.connectedUser.paymentCustomerId,
      merchantDisplayName: 'kingdame',
      style: 'alwaysDark'
    });
    // https://stripe.com/docs/testing to see test cards to use
    const res = await Stripe.presentPaymentSheet();
    console.log(res);
  }

}`
And in my nodeJS server:
// https://github.com/stripe/stripe-node app.post('/api/customer', async (req: Request, res: Response) => {   console.log(Date.now(), 'Entering api/customer');   try {     const customer: Stripe.Customer = await stripe.customers.create({       description: req.body.id || '',       email: req.body.email,       name: req.body.name,     });     res.json({paymentCustomerId: customer.id});     const firestore = new FireStore();     firestore.firestore().doc(users/${req.body.id}`).update({
paymentCustomerId: customer.id,
});
} catch (error) {
res.json({error})
}
console.log(Date.now(), 'Exiting api/customer');
});
app.post('/api/payment-sheet', async (req: Request, res: Response) => {
try {
const ephemeralKey = await stripe.ephemeralKeys.create(
{customer: req.body.customer}, {apiVersion});
const paymentIntent = await stripe.paymentIntents.create({
amount: req.body.amount, // in cents
currency: req.body.currency || 'eur',
customer: req.body.customer,
});
res.json({
paymentIntent: paymentIntent.client_secret,
ephemeralKey: ephemeralKey.secret,
customer: req.body.customer,
});
} catch (error) {
res.json({error});
}
});`

 in my main.ts     ` async checkout() {
  if(!this.connectedUser.paymentCustomerId) {
    //create stripe customer account if not existing
    try {
      const customer = await this.http.post<{paymentCustomerId: string}>(environment.dev.serverUrl + '/api/customer', {
        email: this.connectedUser.email,
        name: this.connectedUser.given_name?
        (this.connectedUser.given_name + (this.connectedUser.family_name?` ${this.connectedUser.family_name}`:'')):
        this.connectedUser.family_name || this.connectedUser.nickname,
        id: this.connectedUser.sub
      }).toPromise();
      console.log(customer);
      this.connectedUser.paymentCustomerId = customer.paymentCustomerId;
    } catch(error) {
      console.error(error);
    }
  }

  if (!this.paymentIntent || !this.ephemeralKey) {
    const { paymentIntent, ephemeralKey, customer, error } =  await this.http.post<{
      paymentIntent?: string;
      ephemeralKey?: string;
      customer?: string;
      error?: any;
    }>(environment.dev.serverUrl + '/api/payment-sheet', {
      customer: this.connectedUser.paymentCustomerId,
      amount: this.totalAmount * 100,
      currency: 'eur'
      }).pipe(first()).toPromise(Promise);
      if(error) {
        console.error('payment intent failed', error);
      } else {
        this.paymentIntent= paymentIntent;
        this.ephemeralKey = ephemeralKey;
      }
  }
  if(this.paymentIntent && this.ephemeralKey) {
    await Stripe.createPaymentSheet({
      paymentIntentClientSecret: this.paymentIntent,
      customerEphemeralKeySecret: this.ephemeralKey,
      customerId: this.connectedUser.paymentCustomerId,
      merchantDisplayName: 'kingdame',
      style: 'alwaysDark'
    });
    // https://stripe.com/docs/testing to see test cards to use
    const res = await Stripe.presentPaymentSheet();
    console.log(res);
  }

}`
And in my nodeJS server: // https://github.com/stripe/stripe-node app.post('/api/customer', async (req: Request, res: Response) => { console.log(Date.now(), 'Entering api/customer'); try { const customer: Stripe.Customer = await stripe.customers.create({ description: req.body.id || '', email: req.body.email, name: req.body.name, }); res.json({paymentCustomerId: customer.id}); const firestore = new FireStore(); firestore.firestore().doc(users/${req.body.id}`).update({ paymentCustomerId: customer.id, }); } catch (error) { res.json({error}) } console.log(Date.now(), 'Exiting api/customer'); });
app.post('/api/payment-sheet', async (req: Request, res: Response) => { try { const ephemeralKey = await stripe.ephemeralKeys.create( {customer: req.body.customer}, {apiVersion}); const paymentIntent = await stripe.paymentIntents.create({ amount: req.body.amount, // in cents currency: req.body.currency || 'eur', customer: req.body.customer, }); res.json({ paymentIntent: paymentIntent.client_secret, ephemeralKey: ephemeralKey.secret, customer: req.body.customer, }); } catch (error) { res.json({error}); } });`

I think the error may come from dependent libraries issue.
The event of closing modal seems not processing in this library.
So we may need to check and fix this library to resolve it.
https://github.com/stripe-elements/stripe-elements
But sorry, I'm not sure how to reproduce the issue or resolve this library issue for now...

Is this issue resolved? This don't has any update, so will close. If be update, please re-open.
Thanks.

I have same error.
How did you solve it?
I have:
"@capacitor-community/stripe": "^4.1.2"
"@stripe-elements/stripe-elements": "^2.0.2"


Dynamic dbt configuration with airflow jinja template fields for SparkThriftProfileMapping host value

In my DAG, I am setting up an emrjobflow and retrieving the dns of cluster before calling the dbttaskgroup.
To the DbtTaskGroup, I want to pass this dynamic runtime value as host and for the Thrift configuration
However that is not possible because the profile class does not accept XCom jinja templating.
Is it possible to pass a dynamic configuration to dbt task group using XCom jinja templating ? Or are there any workarounds ?

We also would like to dynamically configure output from previous tasks (or, for example, Airflow run id) to the dbt cli as dbt_vars. This does not seems possible when initialising DbtTaskGroup.


Multiple lv2lint problems

The following errors are seen, when running lv2lint on DPF examples.

[x]  Options Iface
opts:interface not defined
seeAlso: http://lv2plug.in/ns/ext/options#interface
[x]  State
state:interface not returned by 'extension_data'
seeAlso: http://lv2plug.in/ns/ext/state#interface
[x]  Worker
work:interface has no 'work_response' function
seeAlso: http://lv2plug.in/ns/ext/worker#interface
[x]  Resize Interface
lv2:extensionData ui:resize missing
seeAlso: http://lv2plug.in/ns/extensions/ui#resize

Moreover it's complaining when license is not specified as URI, which would be a defect of the examples and not of DPF itself.

[ ]  License
doap:license not a URI
seeAlso: http://usefulinc.com/ns/doap#license

Good stuff, I need to install lv2lint myself so I can keep track of these things.
Do you mind creating the same ticket against DISTRHO-Ports? thanks
For the license, I always though simple text was a valid value to use in there. does it really have to be a URI?

For the license, I always thought simple text was a valid value to use in there. does it really have to be a URI?

The property describes as: "The URI of an RDF description of the license the software is distributed under. E.g. a SPDX reference"
Reference

Now fixed in develop branch.
lv2lint is part of the example-plugins CI tests, where this CI file is usable to test other plugins / projects in general.
See https://github.com/DISTRHO/DPF/runs/3640475589?check_suite_focus=true for a test run.
Will add in runtime check, just need to see why carla from PPA leaks memory but my local one does not..


Conflict with zsh-autocomplete and fast-syntax-highlighting

General information
Please report the following information as possible as you can:

Terminal program: gnome-terminal 3.38.1-1ubuntu2
Operating system: Ubuntu 21.10
ZSH framework: zinit
ZSH version: zsh 5.8 (x86_64-ubuntu-linux-gnu)

Basic examination

[X] I have read through the README page
[X] I have the latest version of zsh-vi-mode
[X] I have tested with another terminal program

Problem description
Syntax highlighting gets stop working until change in prompt when entering inserts mode

Reproduction steps

Type cd # Highlighting is working
Press ESC to exit insert mode
Press i to enter insert mode # Highlighting stops working
Enter some character # Highlighting works again

Expected behavior
Highlighting should work all the time
zshrc
source ~/.zinit/bin/zinit.zsh

zinit lucid light-mode for \
 atinit"zicompinit; zicdreplay" \
    jeffreytse/zsh-vi-mode \
    marlonrichert/zsh-autocomplete \
    zdharma-continuum/fast-syntax-highlighting

Hi @BonaBeavis,
Sorry for the late reply, thanks for your reporting, and could you try again with the latest update? Let's see if your issue is settled now.
Thanks & Regards

I also have this exact same issue with the exact same plugin. The same issue was mentioned here too: marlonrichert/zsh-autocomplete#667
zsh: Version 5.9 (x86_64-apple-darwin23.0)
terminal: wezterm, Version (20240203-110809-5046fc22)
OS: macOS Sonoma Version 14.5 (23F79)
zsh-autocomplete: Version HEAD-cfc3fd9
zsh-vi-mode: Version 0.11.0


Overhauled structure and build system

I took some time to restructure the project and add a conan/cmake based build system in case you are interested in those changes.
Also there are very simple emissive maps now

Hi :) thank you for the PR, I have a few questions though, which might make sense to discuss first... If you join the Graphics Programming discord and find me there (same name) then we can talk... and you might like the server anyway.


Explain maxWordCount / maxCharCount settings

It's not immediately clear what they do.
The comments in the readme could be more explicit.

I tried to make it more clear, feel free to make a pull request if you have a better solutio.


Editorconfig linting

We often get PRs with whitespace issues which could be detected by tools that lint for editorconfig violations. Possible options:

https://gitlab.com/greut/eclint
https://github.com/editorconfig-checker/editorconfig-checker
https://github.com/jedmao/eclint

greut/eclint says it's the fastest in its README. jedmao/eclint is unmaintained and has a few bugs the last time I tried it, I would not consider it.

Gave the two golang tools a try, they both suck. greut/eclint won't even compile and editorconfig-checker/editorconfig-checker apparently can not parse .editorconfig. So I guess we have to do without such linting until better tooling is made.


Datetime Parsing not utc

https://github.com/recurly/recurly-client-net/blob/60e750f075a3c5ce2ca5f4574c593edfaa83ba57/Library/Usage.cs#L140
Currently  I am trying the following code to update the amount for usage based addons
 var usage = Recurly.Usages.List(subUuid, addonCode).OrEmpty().FirstOrDefault();
  if(usage!=null)
  {

            usage.Amount = quantity;
            usage.Update();
  }

I think the issue is that Datetime.Parse used to get recording timestamp and usage time timestamp doesn't return date in UTC . However when in the WriteXML it is just converted using DatetimeToString("s").  So if I am passing a local date time , which is something I got when I retrieved the usage , it throws an error. I think API expects it in UTC and the current time in AEST when read as UTC will be in future and it throws an error.
This forces me to write the above code as  so that timestamps are ignored
{

           usage.Amount = quantity;
           usage.UsageTimestamp = null;
           usage.RecordingTimestamp = null;
            usage.Update();
  }

Is there a better fix for this so that I don't have to set the properties which I don't want to update
For eg :

DateTime.Parse("2018-09-13T00:43:14Z").ToString("s")

will give the result

2018-09-13T10:43:14

instead of

2018-09-13T00:43:14Z

Hey there @unnijeevan! I'll take a look at this and see if I get the same behavior. If so, we'll take a look and see if we can find a solution


[TIR][REFACTOR] Remove te::Tensor dependencies from TIR passes.

te::Tensor is an useful object for tensor expression.
However, making it part of the TIR makes the abstraction less clean.
This PR is a first step to remove this dependency. In particular,
we will use Buffer in all the places where the te::Tensor is being used.
We can not use IRModule of PrimFunc to represent TIR at any point of the
optimizations.

The TIR passes will no longer need to consider Provide/HalideCall and Realize
Instead, we will use the BufferLoad/Store and BufferRealize.

Buffer will serve as the only abstraction for the TIR data models to represent the intermediate storage among computations. We still keep Realize/HalideCall and Provide as TIR nodes for now to make the change minimum. Right after ScheduleOps, we call SchedulePostProcToPrimFunc to canonicalize the temporary IR generated by TE(which contains these nodes) to the TIR.
The TIR optimizations are now mostly migrated to to the pass manager. With only a few to be migrated as subsequent PRs.

cc @merrymercy @zhiics @yzhliu @hzfan @ZihengJiang @masahi @were @Hzfengsy @spectrometerHBH @FrozenGene @junrushao1994


Nick: Watch tuvanduphonghiv.com

Nick requests the watch of the watch_keyword tuvanduphonghiv\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

tuvanduphonghiv\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


Access to slack team

At kickoff I think a slack team was mentioned? A few questions are popping up that could use some quick real-time comm

I invited @cromulus to our own slack


Add WithoutMiddleware option to route

Added missing option to define a withoutMiddleware when defining single route.
Also have changed FallbackAttributeTest.php to use named arguments when calling assertion, to avoid parameters mismatch error.

@freekmurze Looking forward to your review and thoughts on merging this feature.

Thanks!


ember-cli-notifications no longer uses ember-cli-sass

per this commit: https://github.com/stonecircle/ember-cli-notifications/commit/cfc407564146a12293908a8286b0de68ae33ab05
... perhaps you can choose a new example for the README?

Cool, thanks. Have done.


Add Tact to scc to get LoC and other statistics

https://github.com/boyter/scc?tab=readme-ov-file#addingmodifying-languages

One can also use tokei (at least the alpha released version), as Tact was already merded there two weeks back: https://github.com/XAMPPRocky/tokei/pull/1103


Update validations.py

Closes: #1
updated the user validation to include not to begin with '.' or '_'
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

updated user validation


iitu

International University of Information Technology

add domain iitu.edu.kz

write

@Seysenbekassel I am closing this request as a duplicate to #19257.


Fix timerange presets

"When enabling the “Granule Selection”, the time range should not automatically get populated in the request.  You can either have an additional check box that enables the time range -OR- if you want to have the populated then I’d set “t0” to the start of the mission 10/1/2018 and “t1” to today’s date."

fixed v1.0.4


#3234 exclude extra field when represent model

Change Summary
has been modified to exclude unpredictable "extra" fields from "repr"
Related issue number

#3234
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please review

I thought it was right to exclude "extra field".
Let me know if I'm thinking in a different direction from main

please update.

updated

HI @COCOLMAN you seem to have prevented me from contributing to your PR which means I can't fix the small issue in tests.
Please accept this change. In future it would be easier if you gave permissions to maintainers to contribute to your pull requests for situations exactly like this.

Thx.
I will check Allow edits by maintainers next time

Thanks so much.


isync: 1.4.4 -> 1.5.0

Description of changes
"Buffer too small" error can now be fixed by defining QPRINTF_BUFF (see isync mailing list).
Patch on unexpected EOF is part of new version.
Release notes: https://sourceforge.net/projects/isync/files/isync/1.5.0/
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks good to me. (Minor nit: You should also add the link to the mailing list either to the commit message or the comment over -DQPRINTF_BUFF so it's not vendor locked to the GitHub pr)

Thanks for your review and tip! The link was added to the commit message :)

I've got bitten by a bug introduced by this new version, looks like there were a number of patches submitted after 1.5.0 was released that are getting picked up by others:
https://bugzilla.redhat.com/show_bug.cgi?id=2314719

@Jdogzz, any chance you could do up a PR with the required patches?

@peterhoeg I've now tried my hand at it in #345713, please let me know if there's a preferable way to do so in that thread.


Improve PDF/A compliance

I had the need to implement Facture-x/ZUGFeRD compliant PDF for invoicing.
During this task I found two issues with PDFlib.
1. File attachments are not PDF/A3 compliant (maybe not PDF/A compliant at all).
When adding an attachment, the attachment needs an AFRelationship entry with one of the following values:
type Relationship = | 'Alternative'
      | 'Data'
      | 'Source'
      | 'Supplement'
      | 'Unspecified';

Also an AF entry in the catalog must be added.
Both points should not add issues for different subsets AFAIK, so the only harm would be an increased API surface when adding attachments (add an option to set the attachment relationship).
2. Font CIDSet generation
The CIDSet generation here https://github.com/foliojs/pdfkit/blob/2554c088ca1824119d77a27944eace83ed54d6b4/lib/font/embedded.js#L186 breaks PDF/A3 validation (probably A2 as well). It is only needed for A1 AFAIK, so it can be omitted for other subsets, which would make the resulting PDF compliant.
I have both features implemented in a downstream repo of React-pdf (which uses a fork), but I can port those changes and draft a PR, if this is worth merging. Both points are small in scope and should be backwards compatible.

CIDSet tested with veraPDF and it is only for PDF/A1. Implemented by commit https://github.com/foliojs/pdfkit/commit/75a8dbc0aaae4b36713edfdc7b84d1491d6d7938.

Attachments fixed by PR https://github.com/foliojs/pdfkit/pull/1562


feat: allow using other HTTP clients

closes #2659

See https://gist.github.com/janbuchar/3a4724927de2c3a0bb16c46bb5940236 for an example curl-impersonate client.
The following got-scraping options were ignored (they will still work, but they're not part of the new interface):

decompress,
resolveBodyOnly,
allowGetBody,
dnsLookup,
dnsCache,
dnsLookupIpVersion,
retry,
hooks,
parseJson,
stringifyJson,
request,
cache,
cacheOptions,
http2
https
agent
localAddress
createConnection
pagination
setHost
maxHeaderSize
methodRewriting
enableUnixSockets
context

So if I understand this correctly, we cannot get rid of got-scraping just yet because of the breaking change in BasicCrawlingContext.sendRequest, right?
Does it mean we have to model the BaseHttpClient to follow the got-scraping interfaces, though? It would make more sense to me to make BaseHttpClient independent (or have it follow some well-known API like fetch) and only care for the got-scraping interface where it matters, i.e. sendRequest.
In sendRequest, we would then translate from the got-scraping interface to the independent fetch API (and, in case of GotScrapingClient, later from fetch API back to the got-scraping calls).

Also, a completely unrelated thought / nit, but what file and directory casing convention are we following in Crawlee? It's already messy in the current codebase, but seeing snake_case files together with kebab-case in this PR made me think about it once again 😅

So if I understand this correctly, we cannot get rid of got-scraping just yet because of the breaking change in BasicCrawlingContext.sendRequest, right?

Well, yeah, since got is part of our public API, we cannot completely remove it :shrug:. We'll see what our default http client for 4.0 will be.

Does it mean we have to model the BaseHttpClient to follow the got-scraping interfaces, though? It would make more sense to me to make BaseHttpClient independent (or have it follow some well-known API like fetch) and only care for the got-scraping interface where it matters, i.e. sendRequest.

Not really, but I'd prefer to implicitly support got stuff that won't be part of the http client interface (e.g., parseJson or cacheOptions, and this way, we can do it kinda easily with index signatures on http request/response. It would be doable if we used a fetch-like interface, but a bit more difficult.

Also, a completely unrelated thought / nit, but what file and directory casing convention are we following in Crawlee? It's already messy in the current codebase, but seeing snake_case files together with kebab-case in this PR made me think about it once again 😅

Well, I didn't notice any, so I just look at the nearest files and do my best effort.

Historically things were snake case, but I believe nobody from the current team is in favor of that (I never like this). I would go with kebab case for anything new, and unify in v4 maybe (or sooner, I don't think it has any effect downstream, we don't allow deep imports anywhere).

Alright, I just went through it; it seems like reasonable stuff to me 👍🏽  I dislike the idea of responseType on Request from got, but the generic typing looks good.
Two ideas:

The file naming (kebab-case) from the review above
Some tests, perhaps? Those IMO don't have to be as extensive as the curl-impersonate gist, but showing that this all works (and how it works) would be nice.

Also, it would be cool if we used this for network request mocking in new tests — that is, if the minimal HTTP client setup is quicker than setting up a mock server.

Alright, I just went through it; it seems like reasonable stuff to me 👍🏽 I dislike the idea of responseType on Request from got, but the generic typing looks good, meaning I would happily keep it until the API change.

I'm still in favor of removing it right now (https://github.com/apify/crawlee/pull/2661#discussion_r1787906158).

The file naming (kebab-case) from the review above

Sure thing, kebabs all the way :tada:

Some tests, perhaps? Those IMO don't have to be as extensive as the curl-impersonate gist, but showing that this all works (and how it works) would be nice.

I'd argue that since this really is just a refactor, new tests shouldn't be necessary

Also, it would be cool if we used this for network request mocking in new tests — that is, if the minimal HTTP client setup is quicker than setting up a mock server.

Yeah, for unit tests, it'd definitely be nice if we could just mock this service out. Would that qualify as a test of this PR as well for you? :slightly_smiling_face:

new tests shouldn't be necessary

Sure, I'd just like to see the "minimal HTTP client example", but you're probably right; we don't need to add more tests because of that.

...could just mock this service out. Would that qualify as a test of this PR as well for you?

See above - I'd really just want to see how nifty the usage is. There is no need to replace it in all the tests, but e.g. one HttpCrawler test where we just pass the httpClient that always returns "Hello world!" and test whether everything works passed as expected would be nice.

This is a feature, not a refactor. We are adding a new public option that enables new behavior.

This also reminds me we need some docs around it. It would be nice to have a guide on how to create the fetch HTTP client.

This is a feature, not a refactor. We are adding a new public option that enables new behavior.

This also reminds me we need some docs around it. It would be nice to have a guide on how to create the fetch HTTP client.

Absolutely. I just have this hunch against advertising this interface - we will probably break it in just a couple of months.

Well, we will break it with a breaking release, that's fine. We could as well state that this is an experimental API subject to change. Either way, we need to document this.

@barjin @B4nan I added a basic test and a guide (I'll pull out the code samples later). Can you check it out? The request type will sadly have to stay this way.

Then how can I send a stream request from the router handler using sendRequest?
crawlingContext just only exposes a sendRequest property by createSendRequest.

That's the point, you don't have to change anything in your sendRequest calls. You just use https://crawlee.dev/api/basic-crawler/interface/BasicCrawlerOptions#httpClient to an alternative implementation of BaseHttpClient and you're done.


Update ephemeral volumes feature state

Fixes: https://github.com/kubernetes/website/issues/42259
GenericEphemeralVolumefeature gate  is removed in k8s v1.25 https://github.com/kubernetes/kubernetes/pull/109435
CSIInlineVolume feature gate is removed in k8s v1.27 https://github.com/kubernetes/kubernetes/pull/114410
see the preview page.

/sig storage

Comments addressed.


Question about filtering in templates

Great tool. I was able to set up in 10 minutes.
I just have a single question. (I was hoping to find a template 👍 ). I would like my change log to only show changes that start with a commit string of [bug] or [feature]. And then ideally for each release/tag to order by Feature and then Bug. Is this easy to do?

That's very easy to accomplish with a custom template:
{{#each releases}}
  ### {{title}}

  {{#commit-list commits heading='### Feature' message='\[feature\]'}}
    - {{subject}}
  {{/commit-list}}

  {{#commit-list commits heading='### Bug' message='\[bug\]'}}
    - {{subject}}
  {{/commit-list}}
{{/each}}

Find more information here: https://github.com/cookpete/auto-changelog#custom-templates
auto-changelog --template custom-template.hbs

Let me know if that helps.

Thank you, this was very helpful. Here is the final result:
{{#each releases}}
  {{#if href}}
    ###{{#unless major}}#{{/unless}} [{{title}}]({{href}})
  {{else}}
    #### {{title}}
  {{/if}}
  {{#if tag}}
    > {{niceDate}}
  {{/if}}
  {{#if summary}}
    {{summary}}
  {{/if}}

  {{#commit-list
    commits
    heading='### New Features'
    message='(feature: )|(Feature: )'
    exclude='(fix: )|(Fix: )|(break: )|(Break: )'}}
  * {{subject}} ([`{{shorthash}}`]({{href}}))
  {{/commit-list}}
  {{#commit-list
    commits
    heading='### Bug Fixes'
    message='(fix: )|(Fix: )'
    exclude='(break: )|(Break: )|(Feature: )|(feature: )'}}
  * {{subject}} ([`{{shorthash}}`]({{href}}))
  {{/commit-list}}
  {{#commit-list
    commits
    heading='### Breaking Changes'
    message='(break: )|(Break: )'
    exclude='(fix: )|(Fix: )|(Feature: )|(feature: )'}}
  * {{subject}} ([`{{shorthash}}`]({{href}}))
  {{/commit-list}}
{{/each}}

Looks great!


Rename to material-motion-milemarker

Hooray naming conventions!

Oh yeah!

So, for projects that aren't strictly related to what we're building here I think the naming conventions may not be as applicable.
E.g. this tool could very easily work for any org.
Thoughts?

In that manner of thinking it probably should live in material-foundation.

material-motion is hardcoded in a number of places right now.  So long as that's true, it really is the material-motion-milemarker.
Of course, you could factor out the common parts into a reusable component, but it depends on how much flexibility you want, going forward, to make changes that specifically benefit our team.

Here's one potential plan:

[ ] Move the repo to material-foundation. Call it milemarker.
[ ] Remove the configuration assumptions in the material-foundation repo. Provide a clear place to fill things out.
[ ] Fork the material-foundation repo to material-motion. Call it material-motion-milemarker.
[ ] Make a local modification to our fork with the configuration.
[ ] Deploy the code to gh-pages.

This gives a healthy balance of configuration, minimal overhead, and the ability for others to hack on the project as well.


Update/replace arb during runtime

I know this is kind of an edge case, but I really want to know if there is a way to do it. Basically I want to update my string during runtime for different locales.
I see using intl to generate arb for different languages is really cool but that can only happen during development. Is there a way to download all the text(like JSON?) and replace the arb for a particular locale during runtime? That will enable the app to update the text dynamically. Or maybe there is an alternative to achieve the same effect.
Thanks

Hi @PandaGeek1024
if I understand correctly what you are trying to achieve is a "dynamic internationalization"
which can be achieved as described in this documentation.
Does this solution solve the issue?
thank you

Hi @iapicca , thanks for your response. I have already read that documentation but it is more a compile-time thing. What I mean for dynamic is when the app is installed on the mobile and the user opens the app to download the latest strings from backend to replace the current one. So the app texts are alway up to date with the server. Im currently thinking about downloading it through json file and load it through a customised localization class. But Im not sure if this is the proper way to do so, any suggestion will be appreciated.

Hi again @PandaGeek1024
it is certainly "possible" to update this kind of information through a back-end,
although I'm not sure what could be the advantage to do so;
you may very well follow , as recommended , the docs for internationalization
and on the need update your app with you favorite CI/CD.
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


Split etcd files

This PR simply splits etcd rulesets.go file into multiple files

@asdine Can we merge this?


Build modules against ABI

Gradle should build modules against ABI of their dependencies.

https://artemzin.com/blog/fundamental-design-issues-of-gradle-build-system/#designissuemodulesarenotbuiltagainstabi
This would allow for a huge performance increase and build parallelization. Once a module’s ABI has been built, downstream modules can start building while the module completes compiling internally

If this does happen, please build it in a way that is easily reusable for other languages (namely Kotlin). Compilation avoidance was written without consideration for the external community's ability to reuse it, and the result is that only Java supports it.

Compilation avoidance was written without consideration for the external community's ability to reuse it, and the result is that only Java supports it.

Ahem. As the implementer of compile avoidance, I disagree with this. It's not because it's been written without blablabla that Kotlin can't use it. It's been written for java, which is great. And the reality is that the ABI is different depending on the language. For example groovy compiler requires classes and some specific resources.
Turns out abstracting this is and making this available to other languages is not easy. It's better to deliver something for the most widely used language supported by Gradle first than nothing.
Blaming to get a feature in will not help. We want compile avoidance for Kotlin too. That's it.

I was referring to this:
https://github.com/gradle/gradle/issues/5226

General support for arbitrary languages wrt compilation avoidance is not
on our roadmap currently.

On Fri, May 15, 2020 at 2:21 AM Cédric Champeau<EMAIL_ADDRESS>wrote:

Compilation avoidance was written without consideration for the external
community's ability to reuse it, and the result is that only Java supports
it.
Ahem. As the implementer of compile avoidance, I disagree with this. It's
not because it's been written without blablabla that Kotlin can't use it.
It's been written for java, which is great. And the reality is that the ABI
is different depending on the language. For example groovy compiler
requires classes and some specific resources.
Turns out abstracting this is and making this available to other languages
is not easy. It's better to deliver something for the most widely used
language supported by Gradle first than nothing.
Blaming to get a feature in will not help. We want compile avoidance for
Kotlin too. That's it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/gradle/gradle/issues/10396#issuecomment-629052240,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKMJPUKA5Z3O2YTHUKFB5LRRTNPLANCNFSM4ISICANA
.

I still think this is a good idea.


⭐ Refactor UpdatesViaWebhook to be server agnostic

⭐ Feature description
UpdatesViaWebhook should really be server agnostic to achieve ease of creating multiple bots from one server and use with custom servers with already existing functionality.
This is definitely a breaking change.
Modify to accept custom options:

StartListeningForWebhook

Deprecate after changes:

StartListeningForWebhookTLS
StartListeningForWebhookTLSEmbed
StartListeningForWebhookUNIX

🌈 Your view
Create an interface for Server with default implementation of net/http and fasthttp servers.
🧐 Code example
No response

Updated in v0.20.0


Added support for deployments api

Hello,
I have added support for githubs Deployments API. https://developer.github.com/v3/repos/deployments/.

@neekipatel yes, this should be in node-github. Could you change this PR to include only the changes in routes.json? The code will be auto-generated.

I would love to see this get merged. Anything I can do to help?

@neekipatel Thanks for this contribution! I was silly not to take it earlier... In the commit listed above I included your routes.json code updates. The other files are auto-generated by the generate.js script. Saves a lot of manual coding!!


Options are not passed to StubRunnerRule

Hi, you sent me some instructions today via email for me to try to debug the problem. Would it be possible to put them here as I usually don't have access to my work email at home. Thanks.

I've fixed the problem. Tomorrow I'll release it in version 1.3.1. The system props will work and there will be additional props


[Release-1.27] - Bump containerd to v1.7.7

Backport fix for Bump containerd to v1.7.7

#8603

Validated on commit 40f29507
Environment Details

Infrastructure

[ ] Cloud
[ ] Hosted

Node(s) CPU architecture, OS, and Version:

Ubuntu

Testing Steps

Copy config.yaml

$ sudo mkdir -p /etc/rancher/k3s && sudo cp config.yaml /etc/rancher/k3s

Install k3s
Check containerd verison running /var/lib/rancher/k3s/data/current/bin/containerd -v

Validation Results:

---------------------
Version Checked: k3s version v1.27.6+k3s-40f29507 (40f29507)
go version go1.20.8
IP Address: <IP_ADDRESS>
Command Executed: /var/lib/rancher/k3s/data/current/bin/containerd -v
Execution Location: Node
Expected Value: v1.7.7
---------------------

Command:
/var/lib/rancher/k3s/data/current/bin/containerd -v
---------------------
Assertion:
v1.7.7
----------------------
Matched with result:
containerd github.com/k3s-io/containerd v1.7.7-k3s1.27


Pin the inkwell version to latest stable on master

The current master branch of inkwell seems to change a lot and for compatibility issues it might help to pin the commit.
I was having trouble building this as well because the macro for llvm_versions now uses different syntax so I fixed that as well.
Please let me know what steps I can take to help get this merged, I really like the idea of this tool and this allows me to use it for my research.

Most MacOS tests failed and some Linux tests failed as well.
For MacOS, it seems that https://github.com/TheDan64/inkwell/commit/5c9f7fcbb0a667f7391b94beb65f1a670ad13221 fixes the issue. For Linux, however, we may have to pin to a an older commit (which would not break on MacOS either).

Cool I'll start the search from there thanks!

is there some sort of docker style tests for this? the different linux instances/would you be opposed to introducing that so I can build the linux builds locally?

There are no docker images for testing the Linux builds, since I wanted to keep the CI workflow similar between MacOS, Windows and Linux.
If you look at the .github/workflows/linux.yml file, you can reproduce the Linux test locally with a few commands. Running the test 4 (which fails) with llvm-12 for instance:
$ wget -O llvm.tar.gz https://github.com/jamesmth/llvm-project/releases/download/v12.0.1-rust-1.55/llvm-lld-12.0.1-rust-1.55-linux-x86_64.tar.gz
$ tar xf llvm.tar.gz
$ LLVM_SYS_120_PREFIX=$PWD/llvm cargo b --manifest-path tests/plugins/Cargo.toml -p plugin* --no-default-features --features target-x86,llvm12-0
$ llvm/bin/opt --load-pass-plugin="tests/plugins/target/debug/libplugin4.so" --passes="mpass,function(fpass)" tests/test.ll -disable-output

Anyway, I fixed the issue with Linux tests with the following modifications:
Replacing these lines:
https://github.com/jamesmth/llvm-plugin-rs/blob/31cc6f2fc50f99e6b35edf8145a52292fba4a427/llvm-plugin/src/analysis.rs#L74-L81
With:
let res = crate::get_function_analysis_cached_result(
     self.inner,
     id,
     function.as_value_ref().cast(),
);

if !res.is_null() {
    let res = unsafe { Box::leak(Box::from_raw(res.cast())) };
    Some(res)
} else {
    None
}}

And replacing this line:
https://github.com/jamesmth/llvm-plugin-rs/blob/31cc6f2fc50f99e6b35edf8145a52292fba4a427/llvm-plugin/src/analysis.rs#L217
With:
if !res.is_null() {
    let res = unsafe { Box::leak(Box::from_raw(res.cast())) };
    Some(res)
} else {
    None
}

If you apply these changes it should pass the CI tests (hopefully).


How to acces page with Proxy in testcafe. I need to set Automatic proxy configuration URL = http://wpad/wpad.dat and No proxy for <IP_ADDRESS>.

File a new question on StackOverflow
https://stackoverflow.com/questions/ask?tags=testcafe

I am able to access URL using selenium - below code but not sure how to use that in testcafe.
	Proxy proxy = new Proxy();

	proxy.setProxyAutoconfigUrl("http://wpad/wpad.dat");

	FirefoxOptions options = new FirefoxOptions();
	options.setCapability("proxy", proxy);
	options.addArguments("--headless");

	options.addPreference("network.proxy.no_proxies_on", "<IP_ADDRESS>");

	// Calling new Firefox profile for test
	driver = new FirefoxDriver(options);

Thank you for your inquiry. This issue looks like a question that would be best asked on StackOverflow - an amazing platform for users to ask and answer questions. We try to keep the GitHub issues tracker for bugs and feature requests only (see also: Contributing). If you think that this issue is a bug, feel free to open a new issue, but please make sure to follow the bug template


Issue building 'Setup Rust'

Hey Im experiencing the following error when trying to build at the end of the setup rust tutorial
target/x86_64-unknown-linux-gnu/debug/librust_os.a(core-1357b93f.0.o): In function core::panicking::panic_fmt': /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/obj/../src/libcore/panicking.rs:69: undefined reference to rust_begin_unwind'

Ah I've seen that you already raised the issue on the rust-lang page https://github.com/rust-lang/rust/issues/38281 and they posted a solution that seems to work,

Thanks for reporting!
Yeah, this is a rust problem that was introduced in the 2016-12-05 nightly: https://github.com/rust-lang/rust/issues/38281. It seems like the panic_fmt lang item doesn't export the rust_begin_unwind symbol anymore.
I know of two workarounds:

Use the 2016-12-04 nightly until the issue is resolved.
Define a exported rust_begin_unwind symbol in the assembly sources. However, with this approach rust will jump to the assembly symbol on panic, which isn't desirable.

I left a comment on the blog post DIsqus, but you don't need to export that symbol in the sources. Just add #[no_mangle] to the panic_fmt entry like so:
#[lang = "panic_fmt"] #[no_mangle] pub extern fn panic_fmt() -> ! {loop{}}
This compiles and runs without error.

Thanks a lot for the hint! It works without problems.
I added no_mangle to all panic_fmt declarations in #262.


Html5 video

Adding an htmlvideomodule which is essentially a Javascript behavior : binding control elements to a video element :

playpause button
forward/rewind buttons (some browsers don't fully support it, see in-code comments)
display current/remaining time
time range
(wip for more)

Adding an example page with the previously described features and impemented through SUI / HTML elements :

.ui.button
.ui.statistic
input type="range"

Sorry that the dist folder has been commited along with it.

Hi, there's currently 131 files changed. Could you make sure this matches current next branch with only modified src/ files.
You can try
git checkout dist/

see #2230 for cleaner version

You can also feel free to use the name video. All modules are single most common english words.
I'm currently working on retooling the embed component in branch embed
It will support any third party content that can be hidden behind a placeholder image, this is to avoid including external APIs until a user confirms he wants to activate the content.
Another thing I've noticed, be sure to organize method calls in verb -> object order, for example
time: {

   current: function() {

  }
}

Works better for external APIs if you use
current: {

   time: function() {
     // get time
  }
}


workflow:feat - Automating the release body

In this PR I'll update Release Beta, RC and Final to set automatic
body in release notes. I changed file release-new.yml to
release-final.yml and I changed file alpha.yml to release-alpha.yml
Signed-off-by: Wilian Gabriel<EMAIL_ADDRESS>

This PR Depend of the https://github.com/ZupIT/horusec-devkit/pull/166

I created a validation to check if pipeline failed and remove tag created on github: https://github.com/wiliansilvazup/horusec/runs/5280186446?check_suite_focus=true
And now is possible see the users on Release Notes :partying_face:

Action: https://github.com/wiliansilvazup/horusec/runs/5280295946?check_suite_focus=true
Release Notes:

Wouldn't be better change the commit message to workflow:feat - Automating the release notes?

Wouldn't be better change the commit message to workflow:feat - Automating the release notes?

yeah, I'll adjust this.

Wait the PR https://github.com/ZupIT/horusec/pull/996 to fix problems on sintax

@wiliansilvazup resolve the conflicts  please


add EnsureInitialized;

What

You need to explicitly require WidgetsFlutterBinding.ensureInitialized ()

sorry, to late.
okay, reason the
If you need to access a binary messenger before runApp () is called (for example, during plugin initialization), you must first explicitly call WidgetsFlutterBinding.ensureInitialized ()


Bump version on japp

This changed the clock leap logs to debug and actually named the threads it creates.
One bigger change is that the pool it used (which wasn't sized at all, because no good timeout period for tearing down the threads) is now removed and it will use threads as it needs them, the threads tearing themselves down as they finish.


Enhance about us page

Is your feature request related to a problem? Please describe.
Enhance the about us page.
Describe the solution you'd like
Enhance the about us page with more details and minimalist UI.
Describe alternatives you've considered
NA
Additional context
No response

assign this to me i will try my level best

I want to work on this issue under JWOC @wasimreja

hello sir...I want to work on this issue under jwoc

Please give me this issue, I will make it interactive and user-friendly.


Cannot toggle the group chat notifications

Reported by @gcthomas:matrix.org
The toggle to enable notifications in group chats goes back to off position as soon as you leave the settings via the back arrow. No notifications are received for group chats, but are for a one to one chat
https://riot.im/bugreports/listing/2017-04-22/161521/details.log.gz

It seems that the push rule update request succeeded but the server sync did not provide the same status

Move to P2 because i don't reproduce it.

I have the same issue, except with both one-on-one chats and groupchats.
The toggle in settings seems to work fine, but once I leave the settings and open it back up the notifications are set to off again.
This is for the google play version 0.6.12 using Lineageos 14.1 and pico Gapps.
I tried clearing cache from the settings menu with no effect, though I haven't reinstalled the app yet.
On a different phone with lineageos 14.1 with the f-droid version (without gapps) this issue doesn't exist.


Biome Changer remote not working - Possible crashing of server

Version of Advanced Rocketry
1.12.2-1.4.0-95
Have you verified this is an issue in the latest unstable build
N
Version of LibVulpes
1.12.2-0.2.8-32
Version of Minecraft
1.12.2 (modded) forge-<IP_ADDRESS>15
Crash report or log (if applicable)
https://gyazo.com/7639786cfb01144a9c7d047095b0fc4c
Description of the problem
Shift right click with biome changer remote, it doesn't open the GUI, and it throws that error on the server.
I implemented this to the file in question for the biome changer. https://github.com/zmaster587/AdvancedRocketry/commit/6b2ccaff8cf76d5de1f415f6d24efb1d5b7164ca
Since this, the satellite isn't even being picked up.

while i don't have access to see any errors on the server, my remote worked for about half a dozen areas then stopped. This may be related to the Remote unexpectedly changing to a biome of ocean. This biome is being used while trying to change land areas but I can't seem to get it to learn more than one biome, OR to change from ocean. ((Is it even possible to select a biome from another world ?))

What I think needs to happen is that biome.getBiomeName() needs to pass an isRemote check or needs to go though a proxy.  The problem is the getBiomeName does not exist server side for some reason.


Continuously watch and rebuild source files

A la 'webpack --watch'.
Could close https://github.com/natejenkins/squire/pull/55 as this essentially makes it redundant, though I s'pose we could leave it for extra insurance against pushing un-built changes.

@nate gonna go ahead and merge since it's pure dev (and will help me currently).


Implement I'm a Teapot

Because we all love Teapots a new Endpoint to return 418 I'm a Teapot is needed. We don't like coffee therefor we need to drink more tea: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/418

LGTM @michaelbeutler @yannikinniger

Fixed!

Please use 418 HTTP code

LGTM


The order of jobs in CI is currently a bit backwards (test -> build -> release makes little sense), but it works for now. Once tests that are ran in an actual browser are added, that order has to adapted.

Every time I add tests to a module, I find stuff to refactor, so I'm half-tempted to merge this already and then work on tests and refactoring simultaneously in smaller PRs.
For example, the gmxhr refactoring (#69) already conflicts with the tests added here...

You don't have to create a separate branch for each change just for the purpose of easing reviews, do whatever feels most convenient for you. As long as there are separate commits for the different changes, I have no problem with a huge "refactoring & tests" PR. However, I think that I won't have time to review any PR in detail until the end of the week.

I decided against refactoring qs/qsa/qsMaybe because both qs and qsa do useful things (asserting existence and converting to a real array, respectively). qsMaybe does nothing but wrap querySelector though, so it's a bit useless, but IMO it makes sense to keep it for the sake of consistency.

I've done some experimentation, it appears that we'll run into quite a lot of problems if we try to test files containing JSX. We'd need to run them through babel first, but we can't do that with nativejsx currently. I don't feel like changing the way we handle JSX at the moment. I could write a babel plugin, but that's of course not going to be straightforward and I doubt it's worth it. On top of all that, the SCSS imports will be quite the challenge to deal with too.
Instead, I'd propose to split off the UI elements into separate TSX files whose sole responsibility will be UI stuff. I should be able to mock those imports in the unit tests, and besides, it's good software design to separate UI from logic anyway :)

@kellnerd Marking this one as ready, as the lib and build stuff is fully covered with these tests, where possible*. I'm going to branch off to a separate PR to test the ECAU script source, since this one has already grown sufficiently.
Feel free to take a look through some of the changes on your own pace if you'd like, merging these changes isn't urgent. I'll likely go over the history once more myself soon-ish. Just let me know if you intend on reviewing or if I should just merge whenever I complete my double-checking pass. I'm fine with either. :)
*In terms of build, I'm only really testing the userscript metadata generator, not anything else. I'd rather not touch the build scripts too much, since I can't fully remember how they work 😅 Large swaths of its code are very difficult to properly test, and most (if not all) of that code is exercised by the CI build anyway. That of course doesn't verify that the scripts run properly when built, but I intend on adding real E2E browser tests at some point in the near future anyway, after unit testing the script code itself.

I will have a closer look over the weekend and might leave you some comments 😄

I definitely would have been too lazy to write most of them ("this method is unlikely to break, that one too..." 😅).

I always tell students that 100% code coverage doesn't mean much more than e.g. 90% code coverage. Your tests can achieve 100% coverage, but if you've got code like
function abs(x) { return x; }

and you only test abs(1), abs(0) and abs(100), you'll get 100% code coverage but your code will still do wrong things on abs(-1).
Nevertheless, 100% code coverage looks nice :) I use coverage mainly as a guidance to check what I might have forgotten to test, and if everything is green now in the coverage overview, and next week I make a change and all of a sudden it's not green anymore, I'll immediately know that certain parts need to be tested again. But I'm not going to go out of my way to cover some statement which is nearly impossible, I'll just add an /* istanbul ignore next */ comment before them (istanbul being the coverage provider) if I'm reasonably sure that 1) that statement is correct or 2) there will be another way to fail the deployment if the statement isn't.
Thanks for the review!


add params to headers

amazing work!
my backend is based on JWT (json web token) ,  it's there a way to add 'Authorization' key in request header ?

+1 :)

So the Dropzone.js config accepts headers as an option: http://www.dropzonejs.com/#config-headers
I guess the React-Dropzone-Component config prop would pass that through to the Dropzone.js underneath?

That should be exactly how it works - does it not work for y'all?

:+1:  thx for reply @cgwyllie @felixrieseberg

Actually I need to put headers in disConfig

djsConfig={{   headers: {     Authorization:       "Bearer " + localStorage.getItem("token"),   }, }}


[FEATURE] Remove older BERT notebooks and XLNet in favor of Transformer based notebooks

Description
BERT is currently used independently as well as through transformers. Prefer to use it through transformers for consistent API.
Expected behavior with the suggested feature

Other Comments

Referencing #491


Rename pytorch_lightning/loggers/csv_logs.py to pytorch_lightning/loggers/csv.py

Proposed refactor
Rename pytorch_lightning/loggers/csv_logs.py to pytorch_lightning/loggers/csv.py
Motivation
None of the other Logger files have "logs" as a suffix in the filename, e.g. comet.py, neptune.py, tensorboard.py
cc @borda @justusschock @awaelchli @akihironitta @rohitgr7

The file was named like this because it otherwise clashes with the built-in csv module. I would advise no to rename it.

@awaelchli I see, thanks! Why is this not a problem with mlflow?:
https://github.com/PyTorchLightning/pytorch-lightning/blob/86b177ebe5427725b35fde1a8808a7b59b8a277a/pytorch_lightning/loggers/mlflow.py#L32
or neptune?:
https://github.com/PyTorchLightning/pytorch-lightning/blob/86b177ebe5427725b35fde1a8808a7b59b8a277a/pytorch_lightning/loggers/neptune.py#L46

because they are not built-in modules? csv module comes by default when you install python even with no dependencies.

@rohitgr7 are you sure? I don't see csv listed here: https://docs.python.org/3/library/functions.html

@daniellepintz I think the list of standard modules are here https://github.com/python/cpython/tree/main/Lib, and csv is one of them.

Yeah, conflicts with stdlib modules are very annoying and confusing to users. Let's not do this.


Custom error

Make sure these boxes checked before submitting your pull request.

[x] Do only one thing
[x] No API-breaking changes
[x] New code/logic commented & tested

For significant changes like big bug fixes, new features, please open an issue to make an agreement on an implementation design/plan first before starting it.
What did this pull request do?

Add a field called SQL to the DB stuct. This SQL field contains a String with the last SQL executed.
Create a custom error that contains the original error and contains the SQL string that caused the error. With this custom error it is possible which SQL caused the error, this way it is possible to record in sentry and other platforms what happened, it is a better way to know what error is happening.

Looking at my project's error logs, the only thing that comes up is `pq: syntax error at or near") ". I have about 10 ")" in my SQL. How will I know where the error is happening without running SQL? With this new custom error, and with this new SQL property I can know which SQL is causing the problem.

isn't this repo deprecated?

isn't this repo deprecated?

Yes. This repository is obsolete. But I'm doing maintenance on giant projects that use this repository, and unfortunately I don't have the possibility for GORM V2


[Bug Report]: module path are not all updated to remove 'microsoft.' prefix in the folder names

Describe the bug
after the 'microsoft. prefix was removed from all the top level folders, some modules are still referencing other modules with the name name. for example this is in the ADF module:

To reproduce
n/a
Code snippet
No response
Relevant log output
No response

Hey @tyconsulting, good catch ;)
This was introduced by part 1 of 2 PRs and will be addressed by #3189

Also note the disclaimer on the home page. We're working through the changes as quickly as possible.

@tyconsulting, we now merged also the 2nd PR and will now try to quickly fix any unexpected issue (e.g. the font page table + publishing). Note that there is at least one more major breaking change coming - as part of #3132 we have to push through.
If you encounter any further issues, please let us know. These breaking changes are very nasty.


Documentation or Enhancement - Ability to send in-game shouts using pre and post hooks

Good morning,
I want to be able to send shout messages in game so that players know when the server is being shutdown or restarted. The pre and post hooks can be used for this and combine both discord and in-game shouts.

Does it work, if you run the PRE_BOOTSTRAP_HOOK via bash?
docker exec -ti CONTAINERNAME bash

and then:  (don't forget to replace the Variables)
curl -sfSL -X POST -H "Content-Type: application/json" -d "{\"username\":\"Valheim\",\"content\":\"$$(eval echo Starting Valheim server $$SERVER_NAME)\"}" "https://discord.com/api/webhooks/yadayadayadayada"'

That gave me the info I needed to be able to test. it does work and I can control the payload. still having trouble getting the yaml to correctly recognize the string

Finally got it working with:
- 'PRE_SERVER_SHUTDOWN_HOOK=curl -sfSL -X POST -H "Content-Type: application/json" -d "{\"username\":\"Valheim Server\",\"content\":\"$actualMessage\"}" "$actualwebhook" && sleep 60'


Wrong skill on Floor 40 boss info

Hello!
DDD says Bhima casts a half-roomwide AOE. He casts a line AOE after the knockback, then repeats it's pattern (targeted circle AOE, knockback, line AOE.)
Maygi's guide also says nothing about a half-roomwide.
Maybe it's just phrasing, but for previous floors bosses, half-roomwides actually meant get behind the boss.

Weird that that slipped in there and went unnoticed for so long. I blame hasty editing when I was first writing the short descriptions for the plugin. 😅 I'll revise, thanks for bringing it up!

Revised description in 8bdd1c0.


JTAF is now version 0.1.2

Major improvements to the way providers are created.

Provider code is now entirely copied to the working directory that is referenced in the config file. That means all of the .go code is in one place without copying indivial files.

Commits are handled on terraform destroy

There is now a new commit resource called destroycommit which has inverse logic; it commits on a Terraform delete instead of create. This means that when a Terraform module makes use of it, the commit is automatically applied when the resources are destroyed.

There is now a full example including terraform module best practice sample in the samples directory.

This is our best practice approach.

The Wiki on the GitHub page is updated. Once this PR is merged, I'll finish the build example steps.

The go.mod is magically populated into the terraform_providers working directory identified in the config file.

Testing now with Terraform 0.15.5 and the module 'depends_on' key, which gives us great flexibility.

The providers generated can now be called other names other than 'junos-device'. For example, if you put the name 'vsrx' into the 'providerName' field in the config file, the provider will be called junos-vsrx and when the Go code is compiled, the provider will be called terraform-provider-junos-vsrx

When destroying resources, the driver calls are now without a commit where previously a commit was attempted for every resource removal. The commit requirement is a part of the terraform input file process now instead of in code. We can't infer when to apply commit through some CRUD actions, so it was an inefficient way of doing this task.

Dealt with the conversion of qfx_1 to vsrx_1 in all locations (pushed to the latest commit on this branch.
Regarding the YANG files - the idea here is that everything is included to run a successful demo. The file overhead is minimal and users can concentrate on JTAF itself.


Clear set of readOnlyObjects in UnitOfWork

This fixes issues due to hash collisions, as spl_object_hash reuses hash values, when using clear interspersed within a bulk insert.

Please rebase your branch on top of master instead of 2.1.x:
$ git fetch upstream # being sure to have an uptodate remote
$ git rebase --onto master 2.1.x patch-1
$ git push origin patch-1 --force

I followed your instructions, as you can see there isn't a huge pile of commits along with it.

did you change the line endings in the file to make so much changes ?

I used the github 'fork and edit' feature -- it might well have munged up the line endings.

Well, before the rebase, there was no such changes in the UnitOfWork replacing all lines. So it is not the "Edit and fork" feature

I don't follow, I'm pretty sure it is the "edit and fork" feature, as I do all my work in Linux, the only time I used Windows is at work, and even then my php environment is in a VM running Ubuntu, with PHPStorm (line-endings set to Unix, and encoding set to UTF-8). The github editor probably borked up the line-endings, so I know to be cautious of it.
Regardless, should we kill the pull request and create a new one with a saner patch?

yeah, probably

What did this commit do? clear readOnlyEntities when -<clear is called?

That's all it did, which fixed two bugs for us, one is a collision with hashes, the other is dangling references which consume memory in long running jobs.

I believe that should fix the diff.

http://www.doctrine-project.org/jira/browse/DDC-1659


[Bug]:  TACLS does not install

Is there an existing issue for this?

[X] I have searched the existing issues

Operating System
Linux PopOS (latest)
CKAN Version
1.32.0 (latest)
KSP Version
1.12.5 (latest)
Did you make manual changes?
No
Describe the bug
It fails to install
Even without any other mods installed, and after I cleared the cache and verified the integrity of the game files.
Steps to reproduce
Select TAC and press Apply
Relevant log output
File      : GameData/ThunderAerospace/TacLifeSupport/LifeSupport.cfg
Installing Mod : TACLS-Config-Stock v0.12.4
Owning Mod: TACLS
CKAN Version   : v1.32.0
Your GameData has been returned to its original state.
Error during installation!
If the above message indicates a download error, please try again. Otherwise, please open an issue for us to investigate.

Don't install TACLS-Config-Stock. This is an old module that existed to support an old way of handling TACLS's configs, and is no longer needed (see #5326 and #5330).


Do not completely synchronize read-only modules and models

The idea is to synchronize only those parts of the read-only Modules and Models that are used in MPS:

Modules and all their Models, because it makes creating Model Imports for read-only Models easier,
Models,
Module Dependencies for read-only Modules but not between the read-only Modules,
Model Imports for read-only Models but not between the read-only Models,
Nodes that are referred to in our MPS models. All such Nodes are added as rootNode to the read-only Models. Although it may make the uploaded read-only Models structurally invalid, but we do not read those Models via their original, generated language so it's fine.

I've developed a new language for the read-only Modules, Models, etc that should be safe to use as meta-model to read the aforementioned modelix nodes.
Such feature comes in handy, when we have a DevKit in a plugin that imports a lot of languages and Modules that we do not want to sync to the cloud, but we also do not want to lose the references for them (and the nodes used from them).
Bug (!!!): test the code if it works when we have a DevKit and a module that is synchronized to modelix and we add a new model import / node referenece / module dependency, etc. to a model/module/node that is readonly, but is not synchronized to modelix yet. Do we synchronize the references and the targets in this case?

Nodes that are referred to in our MPS models. All such Nodes are added as rootNode to the read-only Models. Although it may make the uploaded read-only Models structurally invalid, but we do not read those Models via their original, generated language so it's fine.

I think we do not need to sync the referenced nodes at all.
The reference can be made to an `MPSNodeReference.
(Its serialized string starts with "mps:")

All such Nodes are added as rootNode to the read-only Models. Although it may make the uploaded read-only Models structurally invalid, but we do not read those Models via their original, generated language so it's fine.

TODO (1): As suggested by Oleks, instead of this we could use the MPSNodeReference and save only the INodeReference instead of the INode itself (in the MPS -> modelix sync direction).
TODO (2): remove the code that creates a ReadonlyModelNode and remove the ReadonlyModelNode as Concept.
TODO (3): When we want to read the target of this INodeReference (in the modelix -> MPS sync direction), then do the following in the ModelixTreeChangeVisitor.referenceChanged:
Instead of
val targetINode = iReferenceLink?.let { iNode.getReferenceTarget(it) }
val targetSNode = targetINode?.let { nodeMap.getNode(it.nodeIdAsLong()) }

we resolve the targetSNode as follows:
val targetSNode = iReferenceLink?.let {
	val targetRef = iNode.getReferenceTargetRef(it)
	if(targetRef == null) {
		null
	} else {
		val serializedRef = targetRef.serialize()
		val pNodeRef = PNodeReference.tryDeserialize(serializedRef)
		if (pNodeRef == null) {
			val area = MPSArea(mpsRepository)
			val mpsNode = area.resolveNode(targetRef) as MPSNode
			mpsNode.node
		} else {
			val targetNode = iNode.getReferenceTarget(it) ?: throw IllegalArgumentException("PNodeReference exists, but PNode cannot be resolved: '$serializedRef'")
			nodeMap.getNode(targetNode.nodeIdAsLong())
		}
	}
}

As suggested in the previous comment, https://github.com/modelix/modelix.mps-plugins/pull/154 will replace this PR.


[Lambda] new Segment does not appear when using facade as parent

I'm trying to set the addIncomingRequestData in Lambda. Using this function on the facade Segment does not work, and X-Ray just seems to ignore the additional data:
// Koa middleware
const koaMw = async (ctx, next) => {
  const parent = AWSXRay.getSegment(); // returns the Lambda facade segment
  const segment = parent.addNewSubsegment('Koa');
  parent.addIncomingRequestData(new IncomingRequestData(ctx.req));
  await next(); // Continue Koa request execution
  segment.close();
  parent.http.close();
  // ... Lambda will close the facade segment, so don't worry
}

As an alternative, I thought that if I created a new Segment and using Lambda's facade Segment's trace_id as the parent for the new Segment I could get it to work. Based on the X-Ray docs, I would expect this to create a new node on the service map that would be downstream from the lambda execution. This was even worse because X-Ray just ignored my new Segment completely.
// Koa middleware
const koaMw = async (ctx, next) => {
  const parent = AWSXRay.getSegment(); // returns the Lambda facade segment

  const amznTraceHeader = mwUtils.processHeaders(ctx);
  const segment = new Segment(
      'Koa',
      amznTraceHeader.Root || amznTraceHeader.root,
      parent.trace_id,
    );
  mwUtils.resolveSampling(amznTraceHeader, segment, ctx);
  segment.addIncomingRequestData(new IncomingRequestData(ctx.req));
  await next(); // Continue Koa request execution
  segment.http.close();
  segment.close();
  segment.flush();
  // ... Lambda will close the facade segment, so don't worry
}

Is there anyway to create a new downstream service Segment on service map, separate from the Lambda node?
(I need some way to capture the HTTP request details because HTTP API Gateways do not support X-Ray)
Cheers,
Bryan

Hi Bryan,
I think as reference from here, I believe segments created within lambda function are treated as facade segments hence no operation could be performed using that segment. I believe when you call parent.addIncomingRequestData(new IncomingRequestData(ctx.req)); from within your lambda function SDK treats that function call as no-op. https://github.com/aws/aws-xray-sdk-node/blob/c3e7b859b4c6e223c568dc4f7a3a54848625df19/packages/core/lib/segments/segment.d.ts#L17 As per your original question this answer would explain better on having separate nodes on X-Ray console when you create segment within your lambda function.

@bhautikpip Yes, I'm aware of the no-op. that's why I thought using the facade as a parent and creating a new Segment would work.
Specifying the lambda facade as a parent should theoretically work, because it is the same thing that happens when you create a sub request to another service. In that scenario, the second service would use the lambda facade trace_id as the parent in order connect it to the same service graph.
As a note, if you create a new Segment without a parent, the node will show up, but without any relation to the lambda initialization and invocation node, which makes the waterfall kind of useless.

right. I think as per my understanding this case would be similar as having Express server deployed to lambda and Express middleware tries to create segment but Lambda facade segment will ignore that and on the X-Ray console you will only see one node AWS::Lambda::Function as being discussed here https://github.com/aws/aws-xray-sdk-node/issues/45


Updated Documentation for DevExchange Vault Service and implementation.

My team just completed an implementation of the DevExchange Vault service offering.  We've complied some notes and examples of how we did the implementation.

@ShellyXueHan you approved this in rocket-chat, can you please approve here so I can get this PR merged and closed?  ty!

Thanks for the contribution!


NPT_Flutter shows disconnected but it is not

Describe the bug
Connected to remote webserver which continued to be connected but the GUI said disconnected
Steps to reproduce
1.Unknown
Expected behavior
Display the actuall connectivity status ?
Screenshots
See attached video
https://github.com/user-attachments/assets/9b106141-1d0b-472b-89e9-0262703c7890
Smartphones

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Were you using an atApplication when the bug was found?
No response
Additional context
No response

Do we by default use the -K keep alive as I do not see that as an option.. I have tested again and it is repeatable

It works a little differently, it didn't make sense to offer it. The built-in settings are pretty much identical to what -K does.

It will not restart the connection on failure though


Post using localhost instead of IP where server resides.

Using code from the examples, when I try and upload an image it attempts to use localhost instead of the IP where the server resides for POST.  Am I wrong in thinking this is causing the failure?  I'm getting ERR_CONNECTION_REFUSED @ ufs-uploader.js:369
I am accessing the meteor server via a web browser on one machine and hosting meteor server on another on a local network.

figured it out I was running as localhost on starting meteor.  Fixed by using --port : sorry to bother.

Hi @ardwyn no problem, if someone faces the same problem, he'll have the solution ;)


globalThis not working within workers-override.ts

Hallo,
thanks for this template. I tried it out and without a Tunnel Security set, it works.
Now i want to secure my tunnel so i need to set the:
globalThis.CF_CLIENT_ID
and
globalThis.CF_CLIENT_SECRET
Like in the template said.
The 'globalThis' works fine in the normal worker template i can set and get out of it.
BUT those 'globalThis' does not work in the 'workers-override.ts' where the Headers to the tunnel get setted.

@dominikzach - thank you for pointing this out. An update has been made to the template which should fix this! Please re-open the issue if that is not the case.