[Combobox] [React] Open and Clear Trigger can't be focused with keyboard

Description
Current behavior
The combobox has open and clear trigger primitives to either open the combobox, or clear the selected value(s) in the input. Both triggers can be used by clicking them with the mouse. However it is impossible to focus them with the keyboard (tab on it). Both primitives have a tabindex of -1.

Expected behavior
I would expect both elements to be able to navigate with keyboard as well. Removing the negative tab index makes them focusable and controllable.
Link to Reproduction (or Detailed Explanation)
https://codesandbox.io/p/devbox/stupefied-robinson-fgfpv9?file=%2Fsrc%2FApp.tsx
Steps to Reproduce

Open the sandbox
Inspect the triggers

Ark UI Version
"@ark-ui/react": "3.0.3"
Framework

[X] React
[ ] Solid
[ ] Vue

Browser
All
Additional Information
I don't know if there are any specific reasons why the negative tabindex is set, if so I'd be happy to know them :)  Thanks a lot for your work, it's really a great base to build your components on.

Okay, I did some follow-up and saw this behavior is defined in zag itself:
Trigger:
https://github.com/chakra-ui/zag/blob/main/packages/machines/combobox/src/combobox.connect.ts#L243
Clear Trigger:
https://github.com/chakra-ui/zag/blob/main/packages/machines/combobox/src/combobox.connect.ts#L329
For the trigger it seems it's configurable, for the clear trigger it's not.


removeStream not working

I have tried to remove streams with stream id
connection.removeStream(streamid)
or with stream type
connection.removeStream('audio') connection.removeStream({audio:true})
All of which would return warning(s) stream not found.
So i tried to use addStream function, then remove it with removeStream function, addStream worked, removeStream return stream not found warning.
I'm trying to make a chat app similar to facebook, which allows user to send files, add audio call stream if need be, then remove audio stream when they're done but still allows users to send files. Closing entire session then re-initialize a new one would cause send file errors.

Using v3
// either
connection.removeStream('streamid' || stream.id);

// or
var streamToRemove = null;
var newArray =  [];
connection.attachStreams.forEach(function(stream) {
   if(stream.id === 'streamid-to-remove') {
       streamToRemove = stream;
   }
   else newArray.push(stream);
});
connection.attachStreams = newArray;

// skip above steps if you already know the "StreamToRemove"

connection.getAllParticipants().forEach(function(participantId) {
    var peer = connection.peers[participantId].peer;

    // call RTCPeerConnection Native "removeStream"
    // it works only in Chrome
    peer.removeStream(streamToRemove);
});

// sync above action across all users
connection.renegotiate();

Using v2

http://www.rtcmulticonnection.org/docs/removeStream/


bundler doesn't install gem specified with :git option

Rails 3.0.10
Bundler 1.0.18
My Gemfile has the following:
gem 'active_scaffold',  :git => 'git://github.com/activescaffold/active_scaffold.git', :branch => 'rails-3.0'
I'm install my gems into my system Ruby installation.
When I execute "sudo gem install", I see:
Using active_scaffold (3.0.19) from git://github.com/activescaffold/active_scaffold.git (at rails-3.0)
If I look at my Gemfile.lock file, I see:
GIT
remote: git://github.com/activescaffold/active_scaffold.git
revision: 81e801e2c0dfa71a7ae41808e015e8e80b105537
branch: rails-3.0
specs:
active_scaffold (3.0.19)
rails (~> 3.0.0)
render_component_vho
verification
which shows the correct git revision to pull for the branch.
But the active_scaffold gem is NOT installed in GEM_HOME nor in ~/.bundle/ruby/1.8/gems.
I get
"git://github.com/activescaffold/active_scaffold.git (at rails-3.0) is not checked out. Please run bundle install"
when I attempt to run the Rails server ("rails s").
Subsequent runs of sudo bundle install do not work.
I also tried this on a brand new installation of a Rails app. and got the same results, even excluding the :branch option.
Interestingly, the two dependencies noted above (render_component_vho) and verification are installed just fine, but I imagine that's because they're coming from Rubygems.

I run into this problem again on AWS ElasticBenstalk
Gemfile:
gem 'wisper-activejob', git: 'https://github.com/krisleech/wisper-activejob', branch: 'rails5'

Gemfile.lock:
GIT
  remote: https://github.com/krisleech/wisper-activejob
  revision: 88a7ecdf1faf17d448d74f52fb88b0c774df7c94
  branch: rails5
  specs:
    wisper-activejob (0.0.2)
      activejob (>= 4.0.0)
      wisper

on AWS:
[ec2-user current]$ rails -T
https://github.com/krisleech/wisper-activejob (at rails5@88a7ecd) is not yet checked out. Run `bundle install` first.

Any idea what can help?

@fones this is a 6 year old issue, please open up a new issue with the details requested in https://github.com/bundler/bundler/blob/master/doc/contributing/ISSUES.md


Disable Dictionaries for High Cardinality MV Fields

We have a MV columns called tags__VALUES in one of our tables. It is a very high cardinality columns. Here's some data from an existing segment:
column.tags__VALUES.cardinality = 776088
column.tags__VALUES.totalDocs = 4105983
column.tags__VALUES.dataType = STRING
column.tags__VALUES.bitsPerElement = 20
column.tags__VALUES.lengthOfEachEntry = 512
column.tags__VALUES.columnType = DIMENSION
column.tags__VALUES.isSorted = false
column.tags__VALUES.hasNullValue = false
column.tags__VALUES.hasDictionary = true
column.tags__VALUES.textIndexType = NONE
column.tags__VALUES.hasInvertedIndex = true
column.tags__VALUES.hasFSTIndex = false
column.tags__VALUES.hasJsonIndex = false
column.tags__VALUES.isSingleValues = false
column.tags__VALUES.maxNumberOfMultiValues = 61
column.tags__VALUES.totalNumberOfEntries = 35572346
column.tags__VALUES.isAutoGenerated = false
column.tags__VALUES.minValue =
column.tags__VALUES.maxValue = {id}/reset
column.tags__VALUES.defaultNullValue =

AND
tags__VALUES.dictionary.startOffset = 294056019
tags__VALUES.dictionary.size = 397357064
tags__VALUES.forward_index.startOffset = 691413083
tags__VALUES.forward_index.size = 93441573

For tags__VALUES, then dictionary size is ~ 397M. The total size of this segment is 813M, so the dict. itself is occupying around 49% of the size. This certainly doesn't look very optimal.
Docs themselves suggest that dict. encoded forward indices are most helpful when the cardinality of the column is low. But this is certainly not the case her.
Not sure if this'll violate any invariant on segments/indexes, but if we can turn off dict. compression for such MV columns, that'd be helpful.
Note: From this thread, I remember Pinot didn't let me create an inverted index on this column while also disabling dict. on it.

Related issue - https://github.com/apache/pinot/issues/7870

For this column, the length of the values are quite skewed (from 20 to 512). The default string dictionary stores values with fixed length (shorter values are padded to be the same length), so the size of the dictionary is 8 (header) + 512 * 776088 = 397357064. Instead, we can store it using var-length dictionary, which has a 4 bytes overhead per entry, but avoid padding the values.

@Jackie-Jiang So that'd be 8 + 4 * 776088 ~ 3M. Sounds good. Shall I create an issue for this?

It is already supported if you configure it as varLengthDictionaryColumns: https://docs.pinot.apache.org/configuration-reference/table#table-index-config
Created #9865 to automatically use var-length dictionary


Fix/mysql workflow dao update / remove

Duplication of the fix for MySql based on problems discovered in our testing of v28.0 with Postgres:

adding workflow for a given name but not in increasing version order does not work - workflow out of order will not get added to the database but will incorrectly cause the latest_version column in the db to be set to its version.

removing workflow does not update latest_version column

The first problem can cause a workflow not found when trying to retrieve the latest version of the workflow via the API - i.e. version number is not supplied.
Reference original PR #1826 for Postgres fix for the same.

Pull Request Test Coverage Report for Build 4488

14 of 16 (87.5%)  changed or added relevant lines in 1 file are covered.
31 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.2%) to 69.342%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mysql-persistence/src/main/java/com/netflix/conductor/dao/mysql/MySQLMetadataDAO.java
14
16
87.5%

Files with Coverage Reduction
New Missed Lines
%

postgres-persistence/src/main/java/com/netflix/conductor/dao/postgres/PostgresQueueDAO.java
4
92.56%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraEventHandlerDAO.java
8
68.42%

cassandra-persistence/src/main/java/com/netflix/conductor/dao/cassandra/CassandraMetadataDAO.java
8
55.44%

postgres-persistence/src/main/java/com/netflix/conductor/dao/postgres/PostgresMetadataDAO.java
11
80.75%

Totals

Change from base Build 4475:
-0.2%

Covered Lines:
12666

Relevant Lines:
18266

💛  - Coveralls


[Cosmos v4] Possible null passed to HttpUtils.urlEncode(token)

the token could be null based on the logic in this method, if so then we're passing null for URL.
https://github.com/Azure/azure-sdk-for-java/blob/650ab28c669cf2132129abfd4da79007ae8f9e1a/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/directconnectivity/GatewayAddressCache.java#L292

This logic has been updated, so that token will never be null.


Susm03

added .venv/ to .gitignore

tried to merge into fork... didn't realize that it pointed towards the master... closing


Bump async version

https://github.com/caolan/async/blob/master/CHANGELOG.md#v100
shouldn't break anything
@alexindigo

Fixed in v1.0.0-rc1


chore(ocean-api): initial nestjs monorepo setup

What this PR does / why we need it:
A pre-cursor to workflow and shift left adjustments in jellyfish to prepare for consolidation with playground and whale. Also preps for deployment tickets #942 #943

Thanks for the feedback @fuxingloh , I think with the realignment in thinking this PR does not serve a practical purpose. Will move onto the tickets and solve them from the main structure. 👍🏻


Exported vars gives error in text editor if are initialized by default with a const or variable from an user singleton.... but games executes without problem.

Godot version:

compilation from master 02/03/2019
OS/device including version:

wint 7 64 bit
Issue description:

I have this error in script editor. The variable is not exported to inspector. The value entered (recursos.TEXT_SPAM_BASIC) is 1. "recursos" is an autoload. The game executes (no error in runtime, all syntax errors should stop game from executing). If i delete "export" word and hints, there is no error. Don´t know if this is a bug report or a feature request, but in exported variables you should be allowed to enter a default value from constants or variables in user singletons the same way as you can enter constants from godot singletons (ex: if you enter TYPE_BOOL, error is gone).
Edit: This is basic feature, if you can´t use  a constant from singleton in exported vars, you have to maintain a bunch of repeated constants in every script that uses that funcionality, or use integers losing readability...

Confirmed in 49d82f24:
SCRIPT ERROR: GDScript::reload: Parse Error: invalid index 'TEXT_SPAM_BASIC' in constant expression
   At: res://Node2D.gd:3.
ERROR: reload: Method/Function Failed, returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:580.

Interestingly, it actually works fine when you run the game.
MRP: New Game Project.zip

Duplicate of #19704.

Sorry, promise that i search for duplicates....

No worry, it's fine to open duplicates. I didn't see it initially either.


Fix missing provider consideration in type sort sorting logic

Currently, the type sort function only sorts by category, leading to inconsistent ordering when provider is not taken into account.
This fix introduces sorting by both category and provider to ensure the correct order and eliminate sorting issues.
Before

After

my opinion is that projects should be sorted by column order first and then tvl

imo not needed, @torztomasz feel free to reopen if you think otherwise


use setuptools_scm version

This only failed because I accidentally had the wrong event type attached to the GH action.


docs for autoloading .net core / NLog 4.5

See https://github.com/NLog/NLog/issues/1091

Yes it is only NetCoreApp1, that needs manually explicit help for loading assemblies coming from Nuget-packages.

NetStandard1.6 allows access to runtime assemblies:
Microsoft.Extensions.DependencyModel.DependencyContext.Default.RuntimeLibraries
But this doesn't help UWP10-Apps.

nice!

Guess we should update the documentation about auto-loading assemblies has been disabled in NLog 5.0. See also #4232

Updated wiki about NLog 5.0 is not loading assemblies automatically:

https://github.com/NLog/NLog/wiki/Configuration-file#extensions
https://github.com/NLog/NLog/wiki/Register-your-custom-component


Missing script visualize_output.py

I tried to run the scripts\train_rams.sh and noticed that the python script visualize_output.py appears to be missing from the master branch.

Please see the viz/ folder for the visualization scripts.


Feat: Enhance Destination form

Describe the feature
On the webpage https://buddytrail.netlify.app/destinationform, I want to enhance the look of Book Your Dream Destination form. I want to add few more features and give it more designs using suitable colour and background.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Is there an existing issue for this?
I have searched the existing issues
What happened?
Hey @PriyaGhosal
The "Destination" page doesn't look attractive .It looks very simple & I want to enhance it that's why please assign me this issue.
your current page

Record
I agree to follow this project's Code of Conduct
I'm a GSSOC'24 Extended Contributor
I want to work on this issue

@PriyaGhosal Please Assign me this issue

I would like to work Please assign it to me.


doc: move to Sphinx

Adding the files necessary to start building the docs in Sphinx. The output is currently available at https://lxd-sphinx.readthedocs.io/en/move-to-sphinx/
The docs should still build fine in the current format. Some toctrees will be visible as code blocks in the output.
The only content changes are on the index page. The current structure does not work in Sphinx, because you cannot have a start page that has both subpages and siblings. Therefore, I moved the start page out of Getting started and moved the installation instructions to a separate topic under Getting started. Also, there was one FAQ on the start page and one under Getting started, so I combined those.
Closes #9566

This pull request didn't trigger Jenkins as its author isn't in the whitelist.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Can you open another PR with just:

https://github.com/lxc/lxd/pull/9556/commits/5b3bc475b536c197de81a6661b3c0764e8c7d3b2
https://github.com/lxc/lxd/pull/9556/commits/5eddc2853b37ca46cd3ccfe26aff2f9b969d3f48

Those two look safe to merge on their own already.
For https://github.com/lxc/lxd/pull/9556/commits/099aa5e15d7560a876039eadc59355e906a5ef9e, I don't think we need all that stuff inside our doc/ directory as that's causing quite a lot of code duplication (with the theme) and is likely to mostly look confusing. I think I'd prefer we put a Github Action in place (.github/workflows/sphinx.yml) which will:

Setup a venv
Download the dependencies
Clone the vanilla theme
Build the sphinx docs
Pack the result as an artifact

This should avoid having to ship a lot of those files directly in the repo and should make maintaining things a bit easier.

Can you open another PR with just:

https://github.com/lxc/lxd/pull/9562

This should avoid having to ship a lot of those files directly in the repo and should make maintaining things a bit easier.

I agree it would be good to leave out the Vanilla files, but most of the other files need some tweaks and are therefore required.
For the Vanilla files, how will that work for local builds? Do we need to duplicate the GitHub Action in the Makefile? Or should we add scripts that work both for building locally and through the action?

I updated the Makefile now to download the theme, so this can be done locally and through GitHub actions.
I also added a workflow - not quite happy with that yet (I would want it to fail when there are warnings, but still upload the doc output), but it's a first attempt.

I also added a workflow - not quite happy with that yet (I would want it to fail when there are warnings, but still upload the doc output), but it's a first attempt.

Fixed now. I couldn't figure out a way though to output the warnings.txt file in an easily accessible location.

Moved back to Draft because of the conflicts and most of the immediately useful bits having been split up.

For the swagger API, I'd prefer it if we could git clone the repo that has the original JavaScript and CSS and use that in our build rather than embedding our own copies in the repo.

For the swagger API, I'd prefer it if we could git clone the repo that has the original JavaScript and CSS and use that in our build rather than embedding our own copies in the repo.

Makes sense - but we'll probably need to tweak the CSS.

For the swagger API, I'd prefer it if we could git clone the repo that has the original JavaScript and CSS and use that in our build rather than embedding our own copies in the repo.

Makes sense - but we'll probably need to tweak the CSS.

Hopefully we can have it include a secondary CSS or something so we don't need to actually alter the files coming from upstream.

All changes merged through other PRs.


Model checkpoints for inference

Thanks for releasing the code! Do you plan to make trained model checkpoints available for inference?

Thanks for releasing the code! Do you plan to make trained model checkpoints available for inference?

Hi, please see the checkpoints here:
https://github.com/zengqunzhao/DFER-CLIP/tree/main?tab=readme-ov-file#test-pre-trained-models


Optimizer Race in Variable Update under PS strategy

Summary
Using tf.optimizers.experimental, variable update step is not sufficiently locked and can race across workers. This can lead to inconsistent updates of model variables/accumulator state. For some models I've observed consistent nan loss/explosions with tf.optimizers.experimental, but tf.optimizers.legacy training is stable.
There was a pr that partial fixed this here and also cited an internal google issue. That pr got reverted for no specified reason shortly after here. Manually patching that pr back does eliminate nan/loss explosion issue for some models I tested it with. That pr is mostly improvement, but it does sometimes appear to sometimes cause new error in training. The exact error message after patching that pr back in looks like,
self._critical_section.execute(
Node: 'while/critical_section_execute_114/MutexLock'
6 root error(s) found.

(0) UNAVAILABLE:   Stream IDs exhausted
Additional GRPC error information from remote target /job:chief/replica:0/task:0:
:{"created":"@1697949288.512862705","description":"Error received from peer ipv4:<IP_ADDRESS>:2222","file":"external/com_github_grpc_grpc/src/core/lib/surface/call.cc","file_line":1056,"grpc_message":"Stream IDs exhausted","grpc_status":14}
 [[{{node while/critical_section_execute_114/MutexLock}}]]
Additional GRPC error information from remote target /job:ps/replica:0/task:5:
:{"created":"@1697949288.513712689","description":"Error received from peer ipv4:<IP_ADDRESS>:2222","file":"external/com_github_grpc_grpc/src/core/lib/surface/call.cc","file_line":1056,"grpc_message":"Stream IDs exhausted\nAdditional GRPC error information from remote target /job:chief/replica:0/task:0:\n:{"created":"@1697949288.512862705","description":"Error received from peer ipv4:<IP_ADDRESS>:2222","file":"external/com_github_grpc_grpc/src/core/lib/surface/call.cc","file_line":1056,"grpc_message":"Stream IDs exhausted","grpc_status":14}\n\t [[{{node while/critical_section_execute_114/MutexLock}}]]","grpc_status":14}
 [[while/body/_1/while/critical_section_execute_192/ReadVariableOp/_11604]]

I'm unsure if this is deadlock related, transient networking issue more likely with criticalsection usage, or something else. If it's transient networking issue maybe just need to add more retries/fault tolerance adjustments on user side.
Also while for some models this leads to nan/crash if you check for nans in training, in other models it may lead to silent model quality changing due to undefined ordering behavior of variable updates. While PS is async strategy I'd still except individual optimizer updates to be applied fully (potentially with stale gradients) and be consistent with how tf.optimizers.legacy behaved.  As tf.optimizers.experimental is default for tensorflow >2.11 and with PS strategy may lead to large model quality metric inconsistencies this seems valuable to fix.
One thing I'm confused/unaware is how did legacy optimizer api avoid this race condition issue? Big difference I see in update step is old optimizer tended to use ResourceApplyAdagradV2 vs individual operations in python but unsure that's related to locking difference.
This is fairly model + optimizer specific for how big behavior difference is. Simple model should show inconsistencies in variable update consistency, but metric gap/nan loss is trickier to reproduce. I think model that's somewhat unstable like GAN with separate optimizer for generator and discriminator would be a way to make large gap. Also race condition here is more likely the higher worker count. For small cluster of 4 workers I didn’t notice an issue. At 30 workers for same model/data/other settings it produced nans and failed.
edit: For stream id issue maybe it's this? Maybe critical section just increases number of network calls and for long enough training jobs leads to enough requests to go beyond max rpc calls for connection. If that's case error is mostly unrelated to lock and long enough training run that forces enough communication could also trigger this and is more tensorflow repo issue then keras one.

Hi, Thanks for reporting the issue.
Keras is now migrated to Keras 3 which is a new multi-backend implementation of the Keras API, with support for TensorFlow, JAX, and PyTorch.
Could you please test it with the Keras 3 code.
You can install Keras using below steps.
pip install -U keras-nightly
import os
os.environ['KERAS_BACKEND'] = 'tensorflow'
import keras

My bad, I did not notice the PS strategy, you can close this issue and follow up the progress in your previous issue here https://github.com/keras-team/keras/issues/18624

The two issues are both specific to PS strategy but the bug is very different for the two. This one the bug affects model training stability in any job. Higher amount of workers the more races will happen. The other is specific to multiple gpu devices per worker and crashes immediately. I would expect the fix for each to be separate and mostly unrelated.

I'll work on this issue this week. I've been testing a lot of models/comparing legacy.Optimizer vs experimental.Optimizer code and think I have reasonable fix in mind.
The main change will be to add use_locking=True to the Variable update operations. Legacy optimizer had use_locking=True for individual updates which ensured consistency. CriticalSection approach mostly works (40 workers is stable/fine), but at high worker counts may deadlock (80+ workers). use_locking=True is finer lock and with older optimizers have been able to train with pretty high (100+) workers.
With the new keras 3 I expect this will be add a new optional argument use_locking and only tf backends direct assign will use it. Unsure other backends have equivalent need.


Register on Asterisk with TLS

Good morning sir.
I can't register on an Asterisk server with TLS, the Baresip client fails issuing a "Connection timed out" error. On server side I see TLS traffic being exchanged (so not a firewall issue) but no logs on Asterisk console.

OS server: Amazon Ubuntu server 18 kernel 4.15.0
OS client: Ubuntu kernel 4.15.0
Asterisk version 17 with Pjproject 2.9
Baresip 0.5.7
Certificates issued by Letsencrypt
Client certificate created with this command:

ast_tls_cert -m client -c /etc/letsencrypt/live/sip.pgpwaves.eu/fullchain.pem -k /etc/letsencrypt/live/sip.pgpwaves.eu/privkey.pem -C sip.pgpwaves.eu -O "PGPwaves" -d /etc/asterisk/keys -o client
Here is the source of the "ast_tls_cert" helper script:
https://github.com/asterisk/asterisk/blob/master/contrib/scripts/ast_tls_cert#L49
On client machine I've copied:

fullchain.pem -> renamed to ca.crt
client.pem

Server is natted (Amazon web services), client too (behind home router).
Domain name and server IP are correctly matched.
Server hostname is correct ( "hostname" returns sip.pgpwaves.eu)
All relevant files are attached.
Thanks in advance for your valuable time!
pjsip.conf.txt
tcpdump.zip
baresip.cli.output.txt
baresip.accounts.txt
baresip.config.txt

Baresip 0.5.7 was silently ignoring sip_cafile directive.
Upgraded to baresip v0.6.5 but still having the same issue.

the TCP connection is closed by the server, after the first encrypted SIP packet
has arrived.
here are a couple of ideas:

can you test if SIP over TCP is working ?

can you test if the TLS server is working, by using a different client ?
for example openssl client:

$ openssl s_client -connect www.apple.com:443

can you test other SIP client and see if that is working ?

can you enable verbose logging on the server to see what is going on ?

Alfred

Hello and thank you!

SIP TLS without client certificate checking works so I assume SIP/TCP works too but I'll try.
I presume I've messed up certificates because...

openssl s_client -connect sip.pgpwaves.eu:5561
...reports multiple issues:

depth=0 CN = sip.pgpwaves.eu
verify error:num=20:unable to get local issuer certificate
verify return:1
depth=0 CN = sip.pgpwaves.eu
verify error:num=21:unable to verify the first certificate
verify return:1
139916936294848:error:14094410:SSL routines:ssl3_read_bytes:sslv3 alert handshake failure:../ssl/record/rec_layer_s3.c:1399:SSL alert number 40

I get same results with Blink client (timeout errors and identical tcpdump trace).
Asterisk server verbose logging is silent.

So 99% not a Baresip issue but rather me doing a mess with certificates. Solving that would be a nice and useful wiki page for future reference! Thanks again.

Hello!
After cleaning up the mess with certificates I'm getting NO ERRORS when testing Asterisk TLS with:
openssl s_client -connect sip.pgpwaves.eu:5561 -cert client.pem -CAfile fullchain.pem
as per attached file! openssl-test.txt
But still being kicked off at the first encrypted packet in the tcpdump trace!

Can you please test 2-3 other SIP clients and try to determine if the problem
is on the Client side or the Server side ?
I think you should report this issue to the Asterisk Project.

Yes, I'll report to Asterisk and close this. How can I report back to you if needed? Thanks a lot.


Bullets, Dashes, and Asterisks...

So I was playing around with Markdown and HomeBrewery and this happened:

Now with the problem code...
First bug: (in code)
Removing line 26 resolves the issue. As does adding something to it (continues the previous bullet though and not a new line, may be expected behavior).
Second bug: if I remove the separating line(34) or add something to it, then it all becomes proper hanging indent again until the bugbear line. Same happens if you change 35-37 to dashes instead of asterisks. I have tested all issues in Edge, some in Chrome.
Code for copy/pasta: (had to add grave accents to the blank lines so the code would show instead of formatting due to spacing which will show differently when plugged into Homebrew)
- I guess this is bullet form.
- And continuing with the bullets.
`
* I wonder if this causes the same bug as below?
* Does not seem to be the case.
That's a whole new timorous beasty.
___
- Can this be close groups of one line text? It is!
- And all without the indent. I wonder what happens if I cross into the next line.
- So really this is a hanging indent toggle. That's useful. Kinda. Now I really want to put in a lot of jibberish and filler text to see if the hanging applies to the first line, like it should. Wonderful.
`
* This does more bullets.
* They look the same but I will probably get them confused with the italics.
* Playing with the bug some more.
`
***I may have found a bug. Bugbear? Bugbear.***

I think you can add another linebrak to separate lists instead of using the grave accent, like this
- I guess this is bullet form.
- And continuing with the bullets.

* I wonder if this causes the same bug as below?
* Does not seem to be the case.

There is a special css rule in the phb.css for an ul following a hr, it looks like this:
.phb hr+ul {
    margin-bottom: .5em;
    padding-left: 1em;
    text-indent: -1em;
    list-style-type: none;

This rule was set up to do the special formatting of abilities etc inside monster blocks.
If you want to separate two groups of list items into two lists, then put two blank lines between.
Kinda working as intended, if perhaps too broadly. Closing.


Issue with OData context and nextLink urls behind gateway

I'm trying to use OData APIs behind an Ocelot gateway.
For example:
{
"DownstreamPathTemplate": "/odata/{everything}",
"UpstreamPathTemplate": "/reports/odata/v1/{everything}"
}
In this scenario, the OData APIs use the internal host and path in all metadata urls (like @odata.context and @odata.nextLink).
ex: {"@odata.context":"http://internal.host.name/reports/odata/v1/$metadata", ... }
I could customize those urls by code, but the OData service host doesn't know anything about the public url through which it was published.
Is there any way to forward the original url from the gateway to the underlying service? (maybe through headers?)
Or maybe transform the urls in the response body through custom functions?
Any suggestion on how to make OData work through the gateway?
Thank you!

See if this helps https://github.com/OData/odata.net/issues/1694

Hi @gyula-uszkai ,
thank you for your answer. I had already read that post: this is actually how I would expect to customize the urls by code in my OData implementation.
However, what I'm missing is how to retrieve the original (public) request url from the Ocelot gateway.
I was looking for some header that could be added to the upstream request, but I didn't find anything useful.
The only value I was able to forward through a UpstreamHeaderTransform was the {BaseUrl}, but this is a fixed configuration value.
I would have expected I could use a placeholder like {DownstreamPath} to forward the entire original url in a custom template or something like that.
I also tries to use the UpstreamHeaderTransform to add a custom header with the following value "{BaseUrl}/odata/{everything}", only to find out that placeholders are not handled as expected in the header tranform values (the header was created with that exact string value, placeholders not replaced).
By now I'm avoiding to use an Ocelot gateway in front of the OData APIs, but I think this is a great limitation.
Any additional advises are greatly appreciated.

Hello @codegolem !
The problem was that OData filters cannot be routed by Ocelot as query strings.
This problem is fixed by #1182
See commit https://github.com/ThreeMammals/Ocelot/commit/ae43f32fe32b322487623e4b1a22299c3d91bb73
To route all OData filtering URLs to downstream service you have to define special route by Catch All Query String feature.
So, instead of {BaseUrl}/odata/{everything} you need to define {BaseUrl}/odata/?{everything}
Please, upgrade to the latest version and let us know your testing results!
Going to close the issue...


Add configuration to always show prev/next buttons

This adds 2 props to Paginator:

alwaysShowPrevNext (bool): Always show prev/next buttons even if the
page is the first or last, respectively.
inactiveClassName (string): Class name to add to the prev/next buttons
if they should be considered inactive (e.g., the prev button should be
inactive if page is the first page).

@bebraw if you're interested in adding the ability to always show the prev/next buttons, here's a patch.  I added this to the demo app mainly for testing, you may not want it there permanently.  If there are any changes you'd like to see, just let me know.
I'm still in the process of evaluating this library for my project, so there's no rush (or even need) to merge this.  After implementing this, I realized I might need a paginator with a fixed number of pages (including ellipses), and I'm not sure that's a trivial patch to this project.  Example:
< *1*  2   3   4   5  ...  9  >
<  1  *2*  3   4   5  ...  9  >
<  1   2  *3*  4   5  ...  9  >
<  1   2   3  *4*  5  ...  9  >
<  1  ...  4  *5*  6  ...  9  >
<  1  ...  5  *6*  7   8   9  >
<  1  ...  5   6  *7*  8   9  >
<  1  ...  5   6   7  *8*  9  >
<  1  ...  5   6   7   8  *9* >

@jacktrades What if we made it possible to swap the pagination algorithm? It's always good if you can solve some of these things at the user space while benefitting from the basic structure and markup.

That was my initial thought too.  The biggest problem I see with that is adding complexity to the interface.  Maybe there's some common ground we can establish for parameters to the pagination algorithms...
For example, the current algorithm (if I'm understanding it correctly) allows you to set the number of pages to show at the beginning/end, but the number of pages to show in the "center" is fixed (to 3, the selected page, and one to either side of it).  So the relevant configuration parameters would be beginPages and endPages.
The algorithm I have in mind would allow you to configure the number of pages to the left and right of the selection, let's say leftPages and rightPages.  Originally, I was thinking beginPages and endPages would be fixed at 1, but there's no reason they need to be, it just adds another 2 parameters to the minimum pages calculation, which would be something like (excuse my math): (beginPages + 1) + (endPages + 1) + (leftPages + rightPages + 1).
So a common configuration might be something like:
propTypes: {
    paginator: React.PropTypes.function,  // the pagination algorithm
    beginPages: React.PropTypes.number,  // number of pages at the beginning of the range
    endPages: React.PropTypes.number,  // number of pages at the end of the range
    leftPages: React.PropTypes.number,  // number of pages to the left of the selection
    rightPages: React.PropTypes.number,  // number of pages to the right of the selection
    page: React.PropTypes.number,  // current page
    totalPages: React.PropTypes.number,  // total pages

Personally, I'd like to see the signature of paginator become more explicit, instead of passing props to it directly, maybe something like:
function arbitraryPaginator(page, totalPages, opts) { ... }

Where opts is an object of optional values for the *Pages parameters, that each pagination algorithm is expected to define sane defaults for.
I'm not sure if that covers the "general" use-case, but I think it adequately covers both the current and my intended use-cases.  Thoughts?

What if we let Paginator simply to consume segments? After that you'll use segmentize or its variant to generate those. This will clean up the interface massively.

I think I like where you're going with that.  What might that interface look like?

I think I like where you're going with that. What might that interface look like?

Simply pass segments: React.propTypes.Array. So instead of var segments = segmentize(this.props); we just consume the segments through a prop.

That would mean the user would have to do something like:
render() {
    // ...
    var paginated = Paginator.paginate(data, pagination);
    var segments = Paginator.segmentize(...);
    return (
          <Paginator
                    segments={segments}
                    showPrevNext={true}
                    onSelect={this.onSelect}></Paginator>
    );

Ooops, hit send too early...
I kind-of like that.  You can default to a sane segmenter if segments isn't provided.  Then let the user override with whatever they want, and you don't even have to force a function signature on them for the segmenter.  I think I'm sold on that.

Yeah. Do you want to alter the PR? Maybe I should accept this one first and then we do another one for segments?

Yeah, let's consider this a stand-alone patch.  My current client doesn't have the fixed-width paginator as a requirement (I do for a personal project), so it might be a bit before I can devote time to this.

Yeah, let's consider this a stand-alone patch. My current client doesn't have the fixed-width paginator as a requirement (I do for a personal project), so it might be a bit before I can devote time to this.

Alright. I pushed out 0.9.0 with your changes. It feels like we should redesign Paginator interface for 1.0.0. Extracting segments is a good first step. Perhaps we can extract something more. The current component is too bloated for my tastes.


🐛 Bug Report: <Add Shortcut shouldn't accept duplicate url & duplicate name>

📜 Description
Add short cut feature accepts duplicate name as well as duplicate url
when user click on the add shortcut and gives same url and names for multiple times its creates without any error message
👍 Expected behavior
If shortcut url or name already exist or created its should show the popup or error as "short cut url or name already exist"
👎 Actual Behavior with Screenshots
If shortcut url or name already exist or created its keep on accepting duplicates and getting created

👟 Reproduction steps
1.Go to add shortcut section click on it
2.Create a shortcut by filling the form, once shortcut created
3.Again Create a shortcut with same name and url it will create duplicates
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

I am really interested in working on this one.

closing this as iam gonna work on https://github.com/backstage/backstage/issues/18733


Regarding the Attention Addition

Hi @sgrvinod
I would like to ask regarding the addition of the attention in att1 + att2.unsqueeze(1)
att1 is of shape (N, pixels, att_dim)
att2 after unsqueeze is of shape (N,1,att_dim)
When you are adding att1 and att2, then att2 is being expanded automatically to be of the same shape as att1. Therefore, you are adding the same thing for every row of att1 (i.e. all pixels of att1 get added to the same values). Is that how it should be? Or must we multiply att2 with a ones matric to reshape the attention size, as in the following code:
        ones_mx = torch.ones(batch_size], 1, att_dim).to(device) # (batch_size, 1, att_dim)
        hidden_mul = torch.bmm(att2.unsqueeze(2), ones_mx) # (N,49,1 bmm N,1,49) --> (N,49,49) (batch_size,att_dim, att_dim)
        addition_out = F.relu(att1 + hidden_mul)   # (batch_size,49,49)

Or does it not matter?
Thanks

Yes, that's right. we're adding the same thing to each pixel because each pixel (in att1) will be evaluated with respect to the same thing, i.e. the hidden state of the decoder (att2).
I think the equivalent of the first two lines of code in your question is:
hidden_mul = att2.unsqueeze(2).expand(N, att_dim, att_dim) # (N, att_dim) -> (N, att_dim, 1) -> (N, att_dim, att_dim)

In this case, att2 is getting broadcasted along the 3rd dimension. But we'd actually need to broadcast it along the 2nd dimension since they need to be the same for each pixel, and the pixels are the 2nd dimension of att1.

Would add be a suitable operator here? Since we are checking the compatibility between att1 and att2, should we use concat, or diff instead?


Azure ARM for bosh deployment failed

Hi,
i am getting following issue after executing ARM template:
OPERATION IDD501FEF65F5C99D0
TRACKING IDd4716c96-bc6e-4543-a530-773224958f85
STATUSConflict
PROVISIONING STATEFailed
TIMESTAMP01/02/2017, 17:59:55
DURATION8 minutes 32 seconds
TYPEMicrosoft.Compute/virtualMachines/extensions
FVM/extensions/CustomScript
STATUSMESSAGE{
"status": "Failed",
"error": {
"code": "ResourceDeploymentFailure",
"message": "The resource operation completed with terminal provisioning state 'Failed'.",
"details": [
{
"code": "VMExtensionProvisioningError",
"message": "VM has reported a failure when processing extension 'CustomScript'. Error message: "Enable failed: failed to execute command: command terminated with exit status=1"."
}
]
}
}
RESOURCECloudFVM/CustomScript

@nishantsinha-5 You need to logon to your dev box which was created by Azure template and check the detail error in ~/run.log. Mostly it may be caused by a wrong/invalid service principal.

I could not find any run.log, however I got install.log present in home direcotry
Th last statement from log is below:
Operation failed: pip install msrest==0.4.4
Attached log file :
install.txt
Cloud you please share your bosh.yml, which is generated after the script successfully run. so that I can make minor azure changes and do it manually.
Thanks

@nishantsinha-5 Which region are you using? Did you use the latest Azure template? It seems like that the dependencies parsing for nodejs in your deployment is wrong.
Your logs:
Downloading/unpacking cffi>=1.4.1 (from cryptography->secretstorage->keyring>=5.6->msrest==0.4.4)
  Running setup.py (path:/tmp/pip_build_root/cffi/setup.py) egg_info for package cffi

Downloading/unpacking appdirs>=1.4.0 (from setuptools>=11.3->cryptography->secretstorage->keyring>=5.6->msrest==0.4.4)
  Downloading appdirs-1.4.0-py2.py3-none-any.whl
Downloading/unpacking packaging>=16.8 (from setuptools>=11.3->cryptography->secretstorage->keyring>=5.6->msrest==0.4.4)
  Downloading packaging-16.8-py2.py3-none-any.whl
Downloading/unpacking pycparser (from cffi>=1.4.1->cryptography->secretstorage->keyring>=5.6->msrest==0.4.4)
  Running setup.py (path:/tmp/pip_build_root/pycparser/setup.py) egg_info for package pycparser

    warning: no previously-included files matching 'yacctab.*' found under directory 'tests'
    warning: no previously-included files matching 'lextab.*' found under directory 'tests'
    warning: no previously-included files matching 'yacctab.*' found under directory 'examples'
    warning: no previously-included files matching 'lextab.*' found under directory 'examples'
Downloading/unpacking pyparsing (from packaging>=16.8->setuptools>=11.3->cryptography->secretstorage->keyring>=5.6->msrest==0.4.4)
...

  File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 70, in <module>

    import packaging.version

ImportError: No module named packaging.version

My logs in a successful deployment:
Downloading/unpacking cffi>=1.4.1 (from cryptography->secretstorage->keyring>=5.6->msrest==0.4.4)
  Running setup.py (path:/tmp/pip_build_root/cffi/setup.py) egg_info for package cffi

Downloading/unpacking pycparser (from cffi>=1.4.1->cryptography->secretstorage->keyring>=5.6->msrest==0.4.4)
  Running setup.py (path:/tmp/pip_build_root/pycparser/setup.py) egg_info for package pycparser
Installing collected packages: msrest, requests-oauthlib, keyring, chardet, enum34, certifi, isodate, requests, oauthlib, secretstorage, cryptography, idna, pyasn1, setuptools, ipaddress, cffi, pycparser
...

We have tried with East US and SouthEast Asia. We have used the same template.

@nishantsinha-5 We can reproduce this issue. It seems like that changes in some nodejs packages cause this issue. @gossion will help to investigate and fix this issue.

can we point to stable version of nodejs used earlier in the azure ARM template so that the deployment is not affected.
Let us know where we can edit to make it happen.
Thanks.

@AbelHu it will be great if you can help us with sample bosh.yml then we can try the manual method.

Hi @nishantsinha-5 , we don't do any change on the template recently. It looks like this error is caused by setuptools,  some other people file issues on the network about this, for example: link
I have uploaded a sample bosh.yml to this link for your reference, but it is better to follow this workaround to re-run extension and make the environment ready.
workaround:

Re-install pip on your devbox (which you saw it fail to deploy extension)
sudo su -
wget https://bootstrap.pypa.io/get-pip.py
python get-pip.py
logout

Logout/Login and you will see pip works.

Re-Run the extension(setup_env.sh) manually(login as root)
sudo su -
export tenantID="your-tenant-id"
export clientID="your-client-id"
export clientSecret="your-client-secret-encoded-by-base64"   #Note: this must be base64-encoded. you can encode it online: https://www.base64encode.org/
pushd /var/lib/waagent/custom-script/download/0/
./setup_env.sh $tenantID $clientID $clientSecret | tee /tmp/install.log
popd
logout

If everything goes well, you will get your environment prepared. And you will see manifests(bosh.yml, multiple-vm-cf.yml, etc) at your home directory(not root).

Let me know if you get any other error.

It worked bro !!
you made my day, thanks a lot. 👍
Bosh is successfully deployed, will proceed with CF deployment.


Port Replication.stop() method from iOS

Java version of Replication.stop() method is different from iOS. By porting iOS implementation, replicator can stop quickly.

#435 Should be fixed before this.


fix get_maintainer_info is undefined error

This method has been removed by
https://github.com/openshift/doozer/pull/710/.
This PR changes it to the new method get_jira_info. Or we can completely remove the logic of notifying maintainers for missing component if this is not needed any more.

Sorry for missing this. This check / nag can be completely removed for now.

I've gone ahead a removed the code here since ocp4 jobs are broken: https://github.com/openshift/doozer/pull/718


Graph based upon database relations

It would be nice to see relations between both page references and database relations.
Most of my notion links are from database relations. This could help visualize project sizes and effort for those utilize notion as a project management tool.

I currently don't have time to make these changes, maybe later... But here are my thoughts:
When parsing the result form the Notion API the parser generates an attribute called link_type (I just made a commit https://github.com/dominiquegarmier/notion-graph/commit/4cbaeb5779ebcfcf06f158d70286a5ce7d5c8fd4 to distinguish database and page, there was a bug previously).
https://github.com/dominiquegarmier/notion-graph/blob/f538864722d848026a0afeed8337f0a26a5f348b/graph.py#L123
We would have to pass this property to the frontend and render it. I.e. we have to change:
https://github.com/dominiquegarmier/notion-graph/blob/f538864722d848026a0afeed8337f0a26a5f348b/graph.py#L248
https://github.com/dominiquegarmier/notion-graph/blob/f538864722d848026a0afeed8337f0a26a5f348b/graph.py#L268
and we have to change index.html to then render this data (different colors for each link type?). It would be nice to have the colors be configurable (via a constant in graph.py for now) so we would have to use a jinja template instead of just raw html.
Feel free to make changes and create a PR.

also you will have to re-parse all your notes since the graph format changed. Maybe we could make this smarter in the future.


Correct the documentation

Fix some style issue, typos, and examples
Follow the variable naming conventions
Fix tables both in the project and on the webpage

JerryScript-DCO-1.0-Signed-off-by: Zsolt Borbély<EMAIL_ADDRESS>

LGTM

LGTM


cardano wallet: ConnectionError

I have followed the instructions on https://github.com/input-output-hk/cardano-wallet/blob/master/README.md
using mainnet.
command curl http://localhost:8090/v2/network/information works but docker run --network host --rm inputoutput/cardano-wallet network information does not
root@cardano-main:~# docker run --network host --rm inputoutput/cardano-wallet network information
ConnectionError (HttpExceptionRequest Request {
  host                 = "localhost"
  port                 = 8090
  secure               = False
  requestHeaders       = [("Accept","application/json;charset=utf-8,application/json")]
  path                 = "/v2/network/information"
  queryString          = ""
  method               = "GET"
  proxy                = Nothing
  rawBody              = False
  redirectCount        = 10
  responseTimeout      = ResponseTimeoutDefault
  requestVersion       = HTTP/1.1
}
 (ConnectionFailure Network.Socket.getAddrInfo (called with preferred socket type/protocol: AddrInfo {addrFlags = [AI_ADDRCONFIG], addrFamily = AF_UNSPEC, addrSocketType = Stream, addrProtocol = 0, addrAddress = <assumed to be undefined>, addrCanonName = <assumed to be undefined>}, host name: Just "localhost", service name: Just "8090"): does not exist (Name or service not known)))

root@cardano-main:~# docker ps
CONTAINER ID        IMAGE                               COMMAND                  CREATED             STATUS              PORTS                    NAMES
610e88da5d45        inputoutput/cardano-node:latest     "/nix/store/w8zm0231…"   27 hours ago        Up 9 minutes                                 root_cardano-node_1
9c6c3f060052        inputoutput/cardano-wallet:latest   "bash -c ' ([[ $NETW…"   27 hours ago        Up 9 minutes        <IP_ADDRESS>:8090->8090/tcp   root_cardano-wallet_1

It works without using docker. Solved for me

I think --network host only works on Linux systems, Docker doesn't support this type of network layer for OSX and Windows. Are you running on OSX by any chance?

@SimonHausdorf this might be a docker limitation if you're base system is not Linux. -> https://docs.docker.com/network/host/
The host networking driver only works on Linux hosts, and is not supported on Docker Desktop for Mac, Docker Desktop for Windows, or Docker EE for Windows Server.

On my end I see it is working on Ubuntu 20.04:
$ docker run --network host --rm inputoutput/cardano-wallet network information
Ok.
{
    "network_tip": {
        "epoch_number": 206,
        "slot_number": 6365
    },
    "node_tip": {
        "height": {
            "quantity": 25093,
            "unit": "block"
        },
        "epoch_number": 1,
        "slot_number": 3506
    },
    "sync_progress": {
        "status": "syncing",
        "progress": {
            "quantity": 0.56,
            "unit": "percent"
        }
    },
    "next_epoch": {
        "epoch_start_time": "2020-07-24T21:44:51Z",
        "epoch_number": 207
    }
}

Hm that's weird, I am on ubuntu 20.04 as well, didn't make any customizations except switchting it to mainnet.

root@cardano-main:~/cardano-wallet-byron-linux64# ./cardano-wallet network information
Ok.
{
    "network_tip": {
        "epoch_number": 206,
        "slot_number": 6381
    },
    "node_tip": {
        "height": {
            "quantity": 4453756,
            "unit": "block"
        },
        "epoch_number": 206,
        "slot_number": 6380
    },
    "sync_progress": {
        "status": "ready"
    },
    "next_epoch": {
        "epoch_start_time": "2020-07-24T21:44:51Z",
        "epoch_number": 207
    }
}

root@cardano-main:~/cardano-wallet-byron-linux64# docker run --network host --rm inputoutput/cardano-wallet network information
ConnectionError (HttpExceptionRequest Request {
  host                 = "localhost"
  port                 = 8090
  secure               = False
  requestHeaders       = [("Accept","application/json;charset=utf-8,application/json")]
  path                 = "/v2/network/information"
  queryString          = ""
  method               = "GET"
  proxy                = Nothing
  rawBody              = False
  redirectCount        = 10
  responseTimeout      = ResponseTimeoutDefault
  requestVersion       = HTTP/1.1
}
 (ConnectionFailure Network.Socket.getAddrInfo (called with preferred socket type/protocol: AddrInfo {addrFlags = [AI_ADDRCONFIG], addrFamily = AF_UNSPEC, addrSocketType = Stream, addrProtocol = 0, addrAddress = <assumed to be undefined>, addrCanonName = <assumed to be undefined>}, host name: Just "localhost", service name: Just "8090"): does not exist (Name or service not known)))

:thinking: Not sure what might be the issue. I am able to switch between NETWORK=mainnet and NETWORK=testnet (with this small fix for byron testnet, but that should not be related to your problem -> https://github.com/input-output-hk/cardano-wallet/pull/1934).
But perhaps clearing volumes might be helpful? (if that's an option).


Add my account to jenkins admins on integration

This is so I can deploy branches to integration.

:+1: merge when green


Integrate tasks into Hub

Hub should have the concept of "task" and this "task" should come from the InteractionRegistry. This will most probably be an ID of the Interaction Token ID (such as INT23 -> the 23rd Interaction) + a "local ID" (such as T2:20:22:40 —> Task 2 in its 20th iteration at 22:40 UTC). We can use the concepts of Open Task (and other Tasks, we can ask more to Tao on where they are located) and the existing Off-chain and On-chain verifiers we have. Ideally, we could universalized these "local Tasks" - so that instead of using them locally only, they'd be registered in the InteractionRegistry, and called from there first, as described above.

Rather, this will be done within Membership.sol which contains all data on members.


Add names and links of the various sub-repos

Lots of work is being done, towards making py-ipfs a complete project.
However, since the dependencies and all need to be worked up from scratch, not much work is being done directly in this repo. Various contributors are working on various other repos.
Maybe, we can put a link to those repos in the README.md file, so that new contributors know where to look for issues and where to contribute.
1 more suggestion: We can separate those repos as:

Core jobs (The protocols ...)
Dependencies (libp2p ...)

I did some updates in be0f35e0d6267ee15065c59eb2bf356104ed960b, I'm not sure that was everything you had in mind through.
Are you interested in commit access to this repository? I welcome all serious contributors & maintainers and you've been around these last 3 months and I still see you helping out. :slightly_smiling_face:

@alexander255 It would be awesome, if you would give me commit access. 😄
I will add the repo links and all.


feat(build): add travis-ci support

@cburgdorf If you're interested we could add Travis-CI support. This would require some steps be completed in the clog repo settings page in addition to this PR.
Follow:
http://docs.travis-ci.com/user/getting-started/

We still need to setup a webhook, right?

Done ;)
https://travis-ci.org/thoughtram/clog

Sorry, didn't see the question until just a second ago, but looks like you got it! Awesome! :)


Following instructions on Target Version produced an exception while creating the project.

[Enter feedback here]
This produced an error for me - I had to set both Target Versions as Windows 10 2004 to get it to work (running on 20H2)
Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c6a5c75-6cdc-a97f-df50-938ac5534e28
Version Independent ID: e7195fca-7687-4296-6aa8-638ce198d549
Content: Get started with WinUI 3 for desktop apps - WinUI
Content Source: hub/apps/winui/winui3/get-started-winui3-for-desktop.md
Product: reunion
Technology: winui-conceptual
GitHub Login: @mcleanbyron
Microsoft Alias: mcleans

@AlanBourkePgi - thanks for reporting this issue.  Do you have a small repro sample you could share, along with details on the build error you're seeing?


Full review

PR for commenting on the complete codebase.

As I'm not the original (nor the main) author here, I didn't address all comments :slightly_smiling_face:

I propose we have a meeting to address the comments of @rokusottervanger and @Rayman, we can also elaborate more on the design choices. I will sent an email about it.

I propose we have a meeting to address the comments of @rokusottervanger and @Rayman, we can also elaborate more on the design choices. I will sent an email about it.

Great idea! Tim has already elaborated on some, and the principle is starting to grow on me. Implementation-wise it could do with some improvements to make it

More widely applicable
Follow interface and behavior standards better to improve interchangeability with other controllers
Maybe even less complex, so that a fix to handle one edge case doesn't break other edge cases (or even nominal behavior).

Let's discuss soon!

We would like to separate the controller core code from the plugin wrapper. Eventually we could wrap the controller into a nav2 plugin as well

Some compiler warnings are only generated when optimizations are turned on I think. That's because additional code-flow analysis is then needed.


Feature method run multi prompts

Change Description

[ x] My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

[x] I have read the Contribution Guide
[x] My code follows the code style of this project
[x] My code builds (or compiles) cleanly without any errors or warnings
[x] My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

[ ] My fix includes a new test that breaks as a result of the bug (if possible)
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

[ ] I have added or updated the docstrings associated with my feature using the NumPy docstring format
[ ] I have updated the tutorial to highlight my new feature (if appropriate)
[ ] I have added unit/End-to-End (E2E) test cases to cover my new feature
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

[ ] Any updated docstrings use the NumPy docstring format

Build/CI Change Checklist

[ ] If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
[ ] If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

[ ] Any new or updated docstrings use the NumPy docstring format.
[ ] I have updated the tutorial to highlight my new feature (if appropriate)
[ ] I have added unit/End-to-End (E2E) test cases to cover any changes
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

Codecov Report
Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (3c7e0a0) 97.17% compared to head (905ae5f) 83.41%.
Report is 1 commits behind head on main.

Files
Patch %
Lines

src/autora/doc/pipelines/main.py
14.81%
23 Missing :warning:

src/autora/doc/util.py
42.85%
8 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #33       +/-   ##
===========================================
- Coverage   97.17%   83.41%   -13.77%
===========================================
  Files           3        4        +1
  Lines         177      217       +40
===========================================
+ Hits          172      181        +9
- Misses          5       36       +31

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(keystone): oidc driver turn on debug mode if log-level is debug

oidc driver turn on debug mode if log-level is debug
这个 PR 实现什么功能/修复什么问题:
修正：当打开debug日志时，打开oidc驱动的debug模式

是否需要 backport 到之前的 release 分支:

release/3.5
release/3.6

/cc @zexi
/area keystone

Codecov Report

Merging #9248 (57a0e8d) into master (7ef268e) will increase coverage by 10.99%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #9248       +/-   ##
===========================================
+ Coverage    5.85%   16.85%   +10.99%
===========================================
  Files         835       85      -750
  Lines      129729     8900   -120829
===========================================
- Hits         7599     1500     -6099
+ Misses     121444     7268   -114176
+ Partials      686      132      -554

Flag
Coverage Δ

aFlag
16.85% <ø> (+10.99%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/monitor/models/alertrecord.go

pkg/appsrv/workers_watchdog.go

pkg/compute/models/infrasquota.go

pkg/mcclient/options/k8s/secret.go

pkg/compute/models/guest_template.go

pkg/cloudcommon/cronman/cronman.go

pkg/compute/guestdrivers/zstack.go

pkg/compute/models/purge.go

pkg/baremetal/tasks/ipmiprobe.go

pkg/compute/models/cloudproviders.go

... and 740 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef268e...57a0e8d. Read the comment docs.


Can't suppress outliers in bqplot.Boxplot

I would like to suppress plotting the outliers on a boxplot. Looks like you can do this a few ways with pylab
https://stackoverflow.com/questions/22028064/matplotlib-boxplot-without-outliers

Thanks @basketballrelativity We will try to add this. You are also welcome to have a stab :)


Disable "Save" button when time is up for editing a message

At present, we show the following UI when a user runs of out time for editing a message:

Clicking the "Save" button (correctly) does not actually save any previously made changes at this point. We should make this clear by making the "Save" button disabled, with a tooltip: "You can no longer save changes to this message."

@alya I put up a PR for fixing this. However, I made some different choices. Please let me know what you think.

I think "You can no longer save changes to this message." doesn't explain the why. I thought the current tooltip text is better so opted for that. Can easily update it if you disagree.
I found that there are several edge cases if the textbox becomes readonly. I outlined them in my PR and why I opted to keep the textbox editable.

Thanks


Pre-integration

Resolves #24

#33 and last TODO should be resolved before merging

some generic work is still tbd ofc, but at this point we can prototype a Spotify API client


Require authentication when accessing certain API endpoints

Acceptance Criteria:

[ ] All endpoints starting with users/ should require admin role or authentication as the specified user.
[ ] Product/Location (products/, locations/) GET endpoints should require authentication as any logged in user.
[ ] Product/Location POST, PATCH, and DELETE endpoints should require admin role.

Might be helpful:
https://jrizmal.medium.com/how-to-authenticate-firebase-users-in-django-rest-framework-c2d90f5a0a11


Dev context menu placement

Looks good, redux is used in correct manner.
Two little things:

the offset does not seem to have an effect in the upper left area
i don't think we need js-docs comments on private methods and fields (they are not visible in the rendered docs)


[FB Messenger] Error: Request to 'https://state.botframework.com/v3/botstate/facebook/users/xxxxx' failed: [500] Internal Server Error

Bot Info

SDK Platform: Node.js
SDK Version: v3
Active Channels: Facebook Messenger
Deployment Environment: Heroku

Issue Description
All messages to the bot throw an error similar to this one now Error: Request to 'https://state.botframework.com/v3/botstate/facebook/users/1161434730636148' failed: [500] Internal Server Error

Happy New Year!
It happens the same with my production bot since yesterday. I also use node.js, SDK v3 and Facebook Messenger, deployed in a VM hosted in Azure. This is what I see in the logs:
{"trans":"39429903-0460-4598-8ec2-fe3c0eabda10","corr":"39429903-0460-4598-8ec2-fe3c0eabda10","time":"2018-01-01T10:15:13.716Z","lvl":"ERROR","err":{"message":"Request to 'https://state.botframework.com/v3/botstate/facebook/users/1046304145498637' failed: [500] Internal Server Error","name":"Error","constructor":"Error","stack":"Error: Request to 'https://state.botframework.com/v3/botstate/facebook/users/1046304145498637' failed: [500] Internal Server Error\n    at Request._callback (/opt/botcorn/node_modules/botbuilder/lib/bots/ChatConnector.js:452:46)\n    at Request.self.callback (/opt/botcorn/node_modules/request/request.js:186:22)\n    at emitTwo (events.js:106:13)\n    at Request.emit (events.js:191:7)\n    at Request. (/opt/botcorn/node_modules/request/request.js:1163:10)\n    at emitOne (events.js:96:13)\n    at Request.emit (events.js:188:7)\n    at IncomingMessage. (/opt/botcorn/node_modules/request/request.js:1085:12)\n    at IncomingMessage.g (events.js:292:16)\n    at emitNone (events.js:91:20)\n    at IncomingMessage.emit (events.js:185:7)\n    at endReadableNT (_stream_readable.js:974:12)\n    at _combinedTickCallback (internal/process/next_tick.js:80:11)\n    at process._tickDomainCallback (internal/process/next_tick.js:128:9)"},"msg":"Error: Request to 'https://state.botframework.com/v3/botstate/facebook/users/1046304145498637' failed: [500] Internal Server Error"}
This does not happen in my preproduction environment (hosted in my own VMs).
Could you help me?

@achadha0111 @advl03 Thanks for reporting - I have forwarded the issue to our platform team for investigation.

Closing the issue assuming it as resolved. Please reopen a new issue if it still persists.


Added server parsing logic

Searches user entry for "://" at the server login page.  If present, checks for "http" or "https" preceding "://".  If one of these is not found, an error is thrown.  If "://" is not found "https://" is prepended to the user entry.

Automated message from Dropbox CLA bot
@richardhuang09, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

Automated message from Dropbox CLA bot
@richardhuang09, thanks for signing the CLA!

Neeraj wanted me to capture anything that looked like a protocol and then
return an error before calling the api if it wasn't http or https.  Are you
suggesting that we simply check for http or https and then append https to
the beginning of the user input if neither matches?
On Wed, Nov 2, 2016 at 1:04 AM, Boris Yankov<EMAIL_ADDRESS>wrote:

@borisyankov commented on this pull request.
In src/start/RealmScreen.js
https://github.com/zulip/zulip-mobile/pull/90#pullrequestreview-6749982:

@@ -33,8 +33,22 @@ class RealmScreen extends React.Component {
}

tryRealm = async () => {

const { realm } = this.state;

const protocol = /:///;

You can consolidate the http/https check into a single regex.
Something like /\b(http|https):///
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zulip/zulip-mobile/pull/90#pullrequestreview-6749982,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMMAYzPmjqXx63wufgAk34FYdnuk8i4wks5q6BnMgaJpZM4Kmd-9
.

Yeah. That is what I meant.
It is very unlikely that a user will actually enter an incorrect protocol, while it is very likely that he will enter the url without a protocol.

Another, more general advise: the PR / commit messages are written in active voice (not always, but most projects nowadays, including this one). So instead of 'added' it would be 'add'.

Thanks for the tips Boris.  I've change the code to reflect your comments.

Thanks for the PR @richardhuang09 ! Merging now


util/cedarish: Missing packages

The Heroku Cedar 14 stack has postgresql-client-9.5 but this is missing from the Flynn cedarish image.
We should check what other packages are missing too:
https://devcenter.heroku.com/articles/cedar-ubuntu-packages
Perhaps write a script which parses that page and updates the Dockerfile.

P.S. if you need a package which is missing, consider using the Apt buildpack (add it to .buildpacks along with the buildpack you use, and put your packages in Aptfile).

Or maybe we should just run the Heroku cedar-14.sh script:
https://github.com/heroku/stack-images/blob/master/bin/cedar-14.sh

Or just use the Heroku Cedar Docker image rather than building our own...

Would it also be useful to have a concept similar to heroku's stacks: https://devcenter.heroku.com/articles/stack? That way people could configure the base image / os that their applications are run on relatively easily (and flynn could provide a ubuntu 16.04 version of the current slugbuilder image).

@slurms in terms of deploying using Heroku buildpacks, we plan to provide the same stacks that Heroku do to maintain as much compatibility as possible (some buildpacks may not currently function on 16.04 for example).
Moving forward, we plan to provide other build strategies which support arbitrary workflows (see #3753 for the beginnings of that).

@lmars nice, I didn't see that, but it looks like the best approach :+1:. This is one of the things I'm most looking forwards to (that and letsencrypt support). Ideally it'd be great to be able to specify your own docker image to build from on a per-application level.

Hi,
Do you still plan to do this changes? And also support ubuntu 16.04 stack?
Heroku have also an Heroku 16 Docker image.

Flynn is unmaintained and our infrastructure will shut down on June 1, 2021. See the README for details.


N15 The Honor Sagas

Apologies for almost missing the soft deadline!
Refs #320

Thanks for the PR!


Volume creation does not work

With latest build, logs folder is not creating log file to local volume.
Current docker-compose file contains:
thumbor:
image: apsl/thumbor-multiprocess:5.2.1c
volumes:
- "./data:/data"
- "./logs:/logs"

We change the log out to the standard in docker systems: STDOUT.
https://docs.docker.com/engine/reference/commandline/logs/
The docker engine or the orchestator you use can manage the logs. The volume log is deprecated.
We will remove the logs volume in the next release.
Sorry about the inconvenience.

Fixed in release 6.0.1


About Regression in the test folder

Hello,
I tried to run the object "RegressionSingle" in"src/test/scala/vexiiriscv/tester/Regression.scala" which seems like the similar regression test in Vex and Nax. The flow processed just well, but when I open the related fst wave in the related folder (for example "VexiiRiscv/regression/VexiiRiscv_557671459_tests/riscv-arch-test/rv32i_m/M/divu-01/wave.fst"), it do not contain any waves.

The file is only 44KB btw, which I think is not reasonable.
I tried to add some parameters and run it in both IntelliJ IDEA and sbt in terminal, but the parameters which are used in the Self Contained Tutorial cannot be reused here, and I cannot extract the wave still.
Maybe the regression flow is still WIP? If I want to extract these waves, how should I modify the code?
Appreciate it if some guidance can be given!

Hi,
The testbench always run verilator with the wave generation code in, but disable the capture of the wave by default. This allows to have the same behaviour between a simulation without wave and with wave (verilator run differently when the wave generation code in is disabled).
I push in dev the possibility to add --trace-all as an command line argument to ask capturing the wave and a few other logs
Should work well with it ^^

Maybe the regression flow is still WIP? If I want to extract these waves, how should I modify the code?

So, normaly, i'm not asking the regression flow to generate waves, because it can get big realy fast.
instead, i'm using the text files "args" generated in the regression folder to collect the regular vexiiriscv.tester.TestBench commands to rerun a specific test, and there add --trace-all


add kms key filter for mq message broker

Codecov Report

Merging #29 (faaa210) into master (ba8569b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   90.94%   90.93%   -0.01%
==========================================
  Files         299      299
  Lines       35017    35021       +4
==========================================
+ Hits        31847    31848       +1
- Misses       3170     3173       +3

Impacted Files
Coverage Δ

c7n/resources/mq.py
92.94% <100.00%> (+0.34%)
:arrow_up:

c7n/resources/s3.py
84.77% <0.00%> (-0.14%)
:arrow_down:

c7n/mu.py
84.26% <0.00%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8569b...faaa210. Read the comment docs.

Codecov Report

Merging #29 (faaa210) into master (ba8569b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   90.94%   90.93%   -0.01%
==========================================
  Files         299      299
  Lines       35017    35021       +4
==========================================
+ Hits        31847    31848       +1
- Misses       3170     3173       +3

Impacted Files
Coverage Δ

c7n/resources/mq.py
92.94% <100.00%> (+0.34%)
:arrow_up:

c7n/resources/s3.py
84.77% <0.00%> (-0.14%)
:arrow_down:

c7n/mu.py
84.26% <0.00%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8569b...faaa210. Read the comment docs.


Session errors be gone

Install error as shown below is fixed
Traceback (most recent call last):
File "setup.py", line 17, in
install_reqs = parse_requirements('requirements.txt', session=uuid.uuid1())
TypeError: parse_requirements() got an unexpected keyword argument 'session'

You get this error because you have an old pip version.
To update your pip version you can do pip install -U pip.

You may have found your self in this position if you are

on a Mac
Using easy_install to install virtualenv

This results in using virtualenv default version of pip which I believe is at 1.3.1 :(
You can solve this by instead:

using brew to install the latest 2.7 python ~ 2.7.9 as of this note.
Brew will also install pip.
use pip to install virtualenv : pip install virtualenv

You will now be using the latest version of pip, but the global one rather than the virtualenv local one.
NOTE: This is a change from the older easy_install workflow.
NOTE: The above solution works for the same reason. pip install -U pip will result in a global pip of updated version.

First of all Thanks a bunch , error is gone after upgrade of pip version. I had this issue in aws ec2
instance possibly AMI had old version original error was  "ImportError: No module named tweepy" . Re install of tweepy failed with session error. finally everything run fine with advise . thanks again.


fix: load all tabs if lazyLoad=false and display config options in gui correctly

Fixes #32 and #31

:tada: This PR is included in version 1.1.2 :tada:
The release is available on:

Chrome Web Store
GitHub release

Your semantic-release bot :package::rocket:


[firebase_analytics]: Not working at all

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Core, Analytics
Which platforms are affected?
Android, iOS
Description
The events are not being recorded.
Created brand new flutter project, followed the official documentation (https://firebase.google.com/docs/analytics/get-started?platform=flutter), but didn't succeed.
DebugView always shows 'No Device Available'
Reproducing the issue
Bare minimum code.
flutterfire version: 0.3.0-dev.20
firebase_analytics: ^10.9.0
import 'package:firebase_analytics/firebase_analytics.dart';
import 'package:firebase_core/firebase_core.dart';
import 'package:flutter/material.dart';

import 'firebase_options.dart';

void main() async {
  WidgetsFlutterBinding.ensureInitialized();
  await Firebase.initializeApp(
    options: DefaultFirebaseOptions.currentPlatform,
  );
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final _analytics = FirebaseAnalytics.instance;

  void _incrementCounter() {
    _analytics.logEvent(name: "hello");
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

Firebase Core version
2.27.2
Flutter Version
3.19.3
Relevant Log Output
No response
Flutter dependencies

Expand Flutter dependencies snippet

Replace this line with the contents of your `flutter pub deps -- --style=compact`.

Additional context and comments
No response

@SannyRai - you have to run iOS Flutter app from Xcode for it to work. See this issue for why: https://github.com/firebase/flutterfire/issues/11780
For android, it can be difficult. Here is a Stack Overflow thread on possible solutions to get it to work: https://stackoverflow.com/questions/42769236/firebase-analytics-debug-view-does-not-show-anything

@russellwheatley Thanks for the response. Well I already had referred to the Stack Overflow thread you mentioned, didn't succeed so. Since the event takes time to get recorded in dashboard, so its been little overwhelming on not to be able to test realtime.


Retry if request failed due to rate-limit

Temporary fix for #6 so things stop failing due to rate-limits.
If the request fails, waits retry_after_ms and then resends it.
Signed-off-by: Jan Petykiewicz<EMAIL_ADDRESS>

ok to test

LGTM


[VL] Enable local sort-based shuffle

The UT failure of commit https://github.com/apache/incubator-gluten/pull/5811/commits/56580aa690fd5099c55fcf01e213b9cad1267fad is due to metrics changed which causes AQE suites failure https://github.com/apache/incubator-gluten/actions/runs/9185004959


Add support to unicode characters on email validation

This solves issue #19

Coverage remained the same at 100.0% when pulling 610bfa8dcef2fccc3977335c1207c211a533657c on smaniotto:email-unicode into 9a6fb9915326f711617a22d5392a19f59ba3bb20 on dleitee:master.

Perfect!


Only monkey-patch the store once

Was causing a new level of super wrappers for every startApp() in the tests :)

:boar:


Not compatible with JS/PHP version

If you use the Salt like "\xcb\x91\x96\xd0\xa7\x36\x91\x5b\xbf\xd4" the output of both the JS and PHP version is the same (haven't tested other libraries) but the output of his library is completely different

Will look into it, thanks for the report.

The problem is probably that both the alphabet and the salt get converted into the runes. Instead they should be treated as a opaque set of bytes. Or maybe the signature of the function should be to accept []byte but this would be a BC break. I have no idea on how the js version treats the mentioned "strings" but the PHP one treats both of them as single byte characters

I had a look, it's doing that because you're using latin1 encoding when Go expects strings to be UTF8.
Using code from https://stackoverflow.com/questions/13510458/golang-convert-iso8859-1-to-utf8 I am now getting the same values in both JS and Go.
Go version:
package main

import "fmt"
import "github.com/speps/go-hashids"

func toUtf8(iso8859_1_buf []byte) string {
	buf := make([]rune, len(iso8859_1_buf))
	for i, b := range iso8859_1_buf {
		buf[i] = rune(b)
	}
	return string(buf)
}

func main() {
	hd := hashids.NewData()
	hd.Alphabet = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890";
	hd.Salt = toUtf8([]byte("\xcb\x91\x96\xd0\xa7\x36\x91\x5b\xbf\xd4"))
	hd.MinLength = 8
	h, _ := hashids.NewWithData(hd)
	e, _ := h.Encode([]int{1, 2, 3})
	fmt.Println(e)
	d, _ := h.DecodeWithError(e)
	fmt.Println(d)
}

JS version: https://codepen.io/anon/pen/Lrpyqv

According to official golang blog,

It's important to state right up front that a string holds arbitrary bytes. It is not required to hold Unicode text, UTF-8 text, or any other predefined format. As far as the content of a string is concerned, it is exactly equivalent to a slice of bytes.

So I'd still say that the package assumption of string being a valid utf-8 string is wrong as it converts everything into the runes which are unicode and also 32bit on top.

I've searched around a bit and both php and python versions got requests to support unicode alphabets as they both treat the string as opaque set ob bytes and they both declined, the postgresql implementation also works with "bytes"

But the JS version uses String.charCodeAt so it supports Unicode technically.
I'm not sure what you're expecting of me here, go-hashids does give you the same values if you give it a UTF8 string so you can go on with your project. I'll probably update the documentation to explain the quirk but that's it.

What I'm afraid of is that this will somewhat bite somebody.
If you think this is the correct behavior, then there is Valid function inside utf8 package..
Maybe on creation both the salt and alphabet could be checked and then the library should panic if either of them is not valid utf8

I agree it can be confusing hence why I'll update the documentation but I don't think I'll make a validity check. If you're using this library you should understand what it's doing. Every language has their own quirks and this is one of them.


improvement-make monitor mode independent on PTT

improvement-make monitor mode independent on PTT. At the moment the PTT cancels monitor mode.

What monitor mode ?
I can only think of.. but that functions reversed.....

PTT enters detail monitor mode when Spectrum-analyzer is active.

I am talking about normal mode.  For me, the  spectrum is a gadget only. I do not compile it.

Aha you mean when the Monitor function is set under Custom Button 1 or 2.
Well this functions for VFO.
But there is a difference
When monitor is set open on a Memory channnel. Than is stays open after TX.
This is NOT on original firmware.
If you prefer continuously Open Monitor on VFO
Set squelch to 0 with
Menu option 60 Sql - squelch sensitivity level (0=OFF/1 .. 9)

The issuevis not to set sql=0. It works in  way I described on 1of11 builds but last time his build are extremally bugged and cannot repport issues :(

Than use VFO-mode for now.

VFO the same, PTT cancels monitor mode

BTW. Squelch=0 makes monitor mode. No difference but much quicker

My testing that it worked with VFO was not correct.
Squelch (re)opend due to QRM/interference from PC.

So we have a bug

Yes, thats why I made that a separate issue.
I think it would be better to interpret your request as a request for an extension to Monitor mode.
Mode 0 behaves as set Squelch = 0.
Mode 1 the current behavior: Squelch open but back to old level when TX is pressed.


Action for generating release asset jar

This PR is for #25 .
When you create a release on Github, the tag name is passed to the pom.xml and builds a jar like: keycloak-rest-provider-TAG_NAME.jar and adds it as a release asset.
I think this is what you wanted when you asked: "Do you think you could incorporate version changes in the POM". Lmk if I didn't understand correctly and I will adjust the code. Thanks

Thanks for the PR!
I was thinking more in terms of how it works in Dummy4j, that is:

Create a new release with name $releaseVersion
Update POM version to $releaseVersion
Commit change
Deploy jar
Update POM version to snapshot (mvn versions:set -DnextSnapshot)
Commit change
Push changes

That way the POM will always be showing the correct version.

Would using https://github.com/qcastel/github-actions-maven-release greatly simplify the configuration here?

I'm closing this due to finally getting around to creating the workflow I wanted.
Thanks to everyone who contributed!


Review for 246-2

WiP. Please don't review or merge yet.

Closing just in case to avoid accidental merge. This is still WiP.


[OSF-8307] Add tests for sitemap generation.

Purpose
This PR aims to add unit tests to the sitemap generation script.
Changes
scripts/generate_sitemap.py is changed so that the url method for nodes and users are used to generate links.
test_generate_sitemap.py is added as unit tests.
Side effects
Ticket
https://openscience.atlassian.net/browse/OSF-8307

@caseyrollins Thanks for the notice on optimization! Now it makes perfect sense. I have reverted the changes made, and have added a minor change to the script to remove the trailing slash for user urls.

Fixture names are changed. Waiting for Travis to pass before move to CR again.

@adlius names look great, thanks 👍


0x80041002 error when running debian

Windows Version
Microsoft Windows [Version 10.0.22631.2861]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
debian <IP_ADDRESS>
Other Software
No response
Repro Steps
run the debian app from the start menu
Expected Behavior
runs like usual
Actual Behavior
it errors; 0x80041002
Diagnostic Logs
WslLogs-2024-04-24_15-14-09.zip

Thank you @grandpa1946. Looking at the logs, this looks like a vmswitch error:
Microsoft.Windows.Hyper.V.NetMgmt	NetMgmt::CreateVirtualSwitch	04-24-2024 06:14:50.597	"	"	"ErrorID: 	-2147217406
Message: 	CreateVSwitchExtensionMiniport call failed"				2764	19356	2		00000000-0000-0000-0000-000000000000

Does updating Windows to the latest version help solve the issue ? If not please capture /logs again


Gene Annotation System

Description
We want to be able to include arbitrary annotation information into the subnetwork table. Create a system that loads annotation tables from a ~/.cob/ directory or some installed python path and that displays that information when a gene is loaded into the subnetwork tab.
Use Case:

Rob wants to include functional annotations with his results so he generates a table that includes two columns, one for Gene name and the other for functional annotations. He puts this table in ~/.cob/annotations which gets loaded when cob is started. He moves to the browser and loads a dataset. He clicks a gene that has 3 neighbors and wants to know what the neighbors do so he finds the subnetwork tab. He sees that one of the neighbors has a functional annotation that he likes so he orders pizza to celebrate :pizza: .

Lets start with simple logic of using gene names as keys ( we will expand this logic later to include WIndowSize and FlankLimit ). For example there might be 3 annotation files in the annotation directory. The annotation files are simple CSVs and in each annotation file there is a column with gene IDs. So if there are 2,3 and 5 colums in the files (one of which is the gene ID) the annotation table will show 7 columns of annotation information for each gene ((2+3+5) - 3).
Tasks

[ ] Create/Include a annotations directory that we can put annotation files in (~/.cob or something)
[ ] Replace the subnet data in the subnetwork tab with information from the annotation tables

Should this be part of a grander project to integrate GWS into the site? Because it could be interesting results for both subnetworks in terms and custom network in the advanced query system, and I already have a fairly well refined way to handle these tables, not to mention all of the management stuff around it, so I will be borrowing code either way, but if we are going to wholly integrate GWS seamlessly, then I will approach it differently.

Okay FYI I went the full integration route, gene word search is now a dependency for COB, but I upgraded it such that we can now get out the words for each gene individually, so we can piggyback off of it's handling of the databases completely, so I will simply query the folder, look for files with a specific pattern in the title (to denote species), feed them to gws and just query them at will.
Also now that it will essentially be in there anyway, I will add the functionality to quickly query gws for the significant annotations of a subnetwork in the polywas layout, or the entire custom network, after I finish the annotations in the table and the stuff to spruce the custom network graph.

So this feature is even simpler to what GWS does. GWS find significantly enriched words from a query set, I am just looking for gene annotations for genes that happened to get loaded in the network.
You know the raw database that GWS uses? Pull out the gene ids from that table as well as the "functional annotation" column (first and last colums). Load those annotations for each gene that gets loaded in the subnetwork table.
After we have gene annotations loaded, we will fully integrate GWS to make sure that annotations are statistically correct. Sometimes its just nice to get an idea of what the genes are doing as a gut check before you do enrichment.

That is what I am doing initially, I am just using the GeneWordSearch package since it is already  reasonably robust and fairly effectively handles parsing the table and getting rid of useless words, and then I don't have to keep a separate set of code that does the same effective thing. When I get it implemented you shouldn't be able to tell the back end is being handled by gws, it's just a way to make the code more maintainable and robust.

OK, but just to be clear, on first pass its not just words, it's the whole annotation? right? Like simply adding columns to the subnetwork table. Nothing fancy.

...it is now....

Done in #40, for now there is just an annotations folder in the repo, but We can decide on a place to put it permanently later when we decide how this can be packaged.


Routine v2 card

Create routine v2 service and card

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@e436776). Click here to learn what that means.

:exclamation: Current head 065bdcb differs from pull request most recent head f565897. Consider uploading reports for the commit f565897 to get more accurate results

Files
Patch %
Lines

diagnostics-extension/src/utils.ts
33.33%
2 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage        ?   77.10%
=======================================
  Files           ?        4
  Lines           ?      166
  Branches        ?       21
=======================================
  Hits            ?      128
  Misses          ?       38
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Could you have a screenshot in comment#0 for future reference?

Could you have a screenshot in comment#0 for future reference?

Done. See edited comment#0


Integration Tests: Check for exceptions at build time

In the event of an exception in the docker/install_chrome_dependencies.py file at build time, the exception should not be swallowed, and instead raised to prevent unit tests from churning needlessly
[sc-7194]

This test was ran when we knew integration tests would fail, and the error was still not caught earlier.. It seems like more attention is needed on this one

This is the type of error I would except to see when searching for dependencies fails

I will now pull the latest dev images. I know those will build correctly, so if the tests are successful with this changes with solid containers, than I believe we will be good here

Looks like I will need to spend more time on this solution...

@cneill I swapped in the dynamic chrome version fetching and the builds still failed. The interesting part is that the script is working sorta as expected? ldd is not failing this time, but some dependencies are still not appearing to be pulled in
#18 [build  9/17] RUN   missing_chrome_deps=$(python install_chrome_dependencies.py) &&   apt-get -y install $missing_chrome_deps
#18 0.101 Reading package lists...
#18 0.507 Building dependency tree...
#18 0.614 Reading state information...
#18 0.731 0 upgraded, 0 newly installed, 0 to remove and 13 not upgraded.
#18 DONE 0.7s

#19 [build 10/17] RUN apt-get install -y libxi6 libgconf-2-4 jq libjq1 libonig5 libxkbcommon0 libxss1 libglib2.0-0 libnss3   libfontconfig1 libatk-bridge2.0-0 libatspi2.0-0 libgtk-3-0 libpango-1.0-0 libgdk-pixbuf2.0-0 libxcomposite1   libxcursor1 libxdamage1 libxtst6 libappindicator3-1 libasound2 libatk1.0-0 libc6 libcairo2 libcups2 libxfixes3   libdbus-1-3 libexpat1 libgcc1 libnspr4 libgbm1 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxext6   libxrandr2 libxrender1 gconf-service ca-certificates fonts-liberation libappindicator1 lsb-release xdg-utils

That seems out of the scope of this PR. Does the current implementation of check the error codes of ldd satisfy your request?


fix(kafka-exporter): fixed can't create bug

The billing id wasn't set in the ref inside the create message.

:tada: This PR is included in version 1.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Bug Fixes

Eric
This PR provides fixes for
https://github.com/thomasjacquin/allsky/issues/2858 - [BUG]: Unnecessary 15px bottom margin on overlay editor
https://github.com/thomasjacquin/allsky/issues/2860 - [BUG] Text alignment is slightly off when comparing the overlay editor to the final image
https://github.com/thomasjacquin/allsky/issues/2856 - [BUG] Missing ERROR message for text fields totally outside of image dimensions
https://github.com/thomasjacquin/allsky/issues/2855 - [BUG]: "ERROR: ${MEAN2} has no variable type; check 'fields.json'. Using '???' instead." refers to wrong file
https://github.com/thomasjacquin/allsky/issues/2854 - [BUG] Overlay issue - Moon altitude not correct
https://github.com/thomasjacquin/allsky/issues/2851 - Hide temperature variables for Rpi cameras until the kernel module is fixed
https://github.com/thomasjacquin/allsky/issues/2838 - [BUG]: Default stroke color doesn't work
https://github.com/thomasjacquin/allsky/issues/2837 - [BUG]: Changing field contents or font size resets X to 0
https://github.com/thomasjacquin/allsky/issues/2833 - [BUG] Ensure overlay processor only processes .json and .txt files
https://github.com/thomasjacquin/allsky/issues/2861 - [BUG] Fixes for the overlay editor
Can you cast your eyes over it and if you are happy I'll merge it. It will require a fair bit of testing as there are some quite fundamental changes in the way overlay fields are positioned.

As we discussed in Discord, excludeVariables will need rework to take into account hasSensorTemperature

Eric
Updated the code to use the hasSensorTemperature. I fixed the error in the ASICameraInfoArray array locally only so that will need doing, I wasnt sure of you are doing anything to the capture routines


IOS - Error building CDVBarcodescanner.mm

Expected Behaviour
Successfull building on IOS
Actual Behaviour
Error building on IOS retrieving the error:
/Users/danielscarpim/Projetos/IonicLMS/Ionic/platforms/ios/MSX Learn/Plugins/phonegap-plugin-barcodescanner/CDVBarcodeScanner.mm:1028:146: Property 'safeAreaLayoutGuide' not found on object of type 'UIView *'

What's your Xcode version?

I'm getting the same error.
I also get one that says Unexpected '@' in program
It doesn't like if (@available(iOS 11.0, *))
Both errors are in a function called resizeElements in the CDVBarcodeScanner.mm file.
I'm using xCode 8.2.1.

Since 1st of April, Xcode 9 is required to submit the apps to the App Store.
If you want to use Xcode 8 you can put that part of the code inside a #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000


Change FlexFieldsModelSerializer to a mixin to make it usable with other (model)serializers.

I like your issues/suggestions. Any chance you want to work them into a pull request? :)


WhatsApp Desktop does not work

Problem
Upon clicking the WhatsApp Share button on a web browser on a desktop, it opens web.whatsapp.com, which prompts to scan a QR code if not already signed in.
Many people use WhatsApp Desktop App (Windows, Mac, Linux).
Currently, there's no way to open WhatsApp Desktop in the current implementation.
Solution
I've made a PR here -> #56
Might need a review and merge, if fits the usecase.

[ ]