From a state, loading a newState view which is not a child in the same window

I have a state called "ProductState" which further contains ui-sref to "ChatState" (Chat State is not the child of ProductState". What I am trying to implement is how to load the ChatState template below the ProductState template without loading the ProductState template again.
Initial state
`

`
After I visit "/product" url --
`
/* html related to product*/

`
After clicking on the hyperlink , I want my page be like
`
/* html related to product /
/ html related to chat */
`
I know I can create a new state or a template to achieve this but this will make my code redundant. Is there any way I can achieve this without repeating the code.

i had problem.

So you want to load two different views on the same state? If so, look at named views.
Otherwise maybe look at the sticky states plugin

thanks i know it. nested views solved

I want two states in a single page but the second state is loaded only when I trigger it from a link in my first state. And my first state is not loaded again during the process. That's what I'm trying to implement

I assume you want ChatState to be openable from anywhere in the app (or maybe just from certain states, but more than one).   Otherwise, I would say ChatState can be a child of ProductState.
You have a few options:

Don't use a state for the Chat feature.  Use a plain old directive and plain old angular logic to show/hide the Chat UI
Make a copy of the ChatState for each parent state (such as ProductState) you want ChatState to work underneath.  (use a forEach loop, and angular.copy(chatState), for example)
Use ui-router-extras project's "sticky states" to have the chat state tree live alongside the main app.

It's on our radar to support your use case natively (but no planned date).  Beyond that, ui-router doesn't currently support what you're asking of it.

Closing due to inactivity


Flaky test: FrameConnectionManagerTests.UnrootedConnectionsGetRemovedFromHeartbeat

Assert.Equal() Failure
Expected: 1
Actual:   0
   at Microsoft.AspNetCore.Server.Kestrel.Core.Tests.FrameConnectionManagerTests.UnrootedConnectionsGetRemovedFromHeartbeatInnerScope(String connectionId, FrameConnectionManager frameConnectionManager, Mock`1 trace) in C:\BuildAgent\work\2b0c8ce712895332\.r\KestrelHttpServer\test\Microsoft.AspNetCore.Server.Kestrel.Core.Tests\FrameConnectionManagerTests.cs:line 58
   at Microsoft.AspNetCore.Server.Kestrel.Core.Tests.FrameConnectionManagerTests.UnrootedConnectionsGetRemovedFromHeartbeat() in C:\BuildAgent\work\2b0c8ce712895332\.r\KestrelHttpServer\test\Microsoft.AspNetCore.Server.Kestrel.Core.Tests\FrameConnectionManagerTests.cs:line 26

http://aspnetci/viewLog.html?buildId=205441&tab=buildResultsDiv&buildTypeId=XPlat_Windows_Win10Universe

Also happened on appveyor with @halter73 's initial commit

It happened again on @natemcmaster 's PR https://ci.appveyor.com/project/aspnetci/kestrelhttpserver/build/1.0.5088. I skipped the test https://github.com/aspnet/KestrelHttpServer/commit/d0743806d8d8675e82afd665ecdd9bd208564cf7

Fixed by #1727.


update create-llama to llama-index 0.10 +

Llama - Index had a huge upgrade, and the create-llama need to be updated as well. For example, ServiceContext is depreciated.
from llama_index import ServiceContext

from app.context import create_base_context
from app.engine.constants import CHUNK_SIZE, CHUNK_OVERLAP

def create_service_context():
    base = create_base_context()
    return ServiceContext.from_defaults(
        llm=base.llm,
        embed_model=base.embed_model,
        chunk_size=CHUNK_SIZE,
        chunk_overlap=CHUNK_OVERLAP,
    )

Hi @ohdearquant, Thanks for the request! I'm already on it and hope to deliver it soon.


Maybe I found a bug in ./DDM-Net/modeling/position_embedding.py  line: 34

The code here should be written like this. I am looking forward to you can proofread it.
    def forward(self, locations):
        result = (
            # self.position_table[: locations.shape[1]]
            self.position_table[:, :locations.shape[1], :]
            .clone()
            .detach()
            .repeat(locations.shape[0], 1, 1)
        )
        return result

This is NOT a bug.
You can simply try a simple case with torch.rand(32, 10, 512), and the result will be the same.
First, the position table only has 2 dims.
Second, .repeat(bs, 1, 1) is exploited to generate positional embedding for each sample


Permanent excludes: Non applicable tests for openj9

These openjdk tests have been permanently excluded since they are currently unsuitable for OpenJ9 as they refer to Hotspot specific internals or implementations (please add to this list using the same format shown below).
Format:

[testname] \n [link to test] as per [link to issue] \n

JDK8

java/lang/invoke/VarargsArrayTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/invoke/VarargsArrayTest.java#L1 as per https://github.com/eclipse/openj9/issues/7183

java/lang/ref/OOMEInReferenceHandler.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/ref/OOMEInReferenceHandler.java#L1 as per https://github.com/eclipse/openj9/issues/7251

java/lang/ref/NullQueue.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/ref/NullQueue.java#L1 as per https://github.com/eclipse/openj9/issues/7251

java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java#L1 as per https://github.com/eclipse/openj9/issues/6963

java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java#L1 as per https://github.com/eclipse/openj9/issues/6963

java/lang/annotation/AnnotationsInheritanceOrderRedefinitionTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/annotation/AnnotationsInheritanceOrderRedefinitionTest.java#L1 as per https://github.com/eclipse/openj9/issues/6700

java/lang/invoke/ArrayConstructorTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/invoke/ArrayConstructorTest.java#L1 as per #1288

java/lang/invoke/LambdaFormTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/invoke/LambdaFormTest.java#L1 as per eclipse/openj9#7055

java/lang/ref/FinalizerHistogramTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/03cb3a3cb42f9b8992a9e4f5821a557f3ca9eaa4/jdk/test/java/lang/ref/FinalizerHistogramTest.java#L1 as per eclipse/openj9#7226

java/lang/invoke/ExplicitCastArgumentsTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/b2a1abf9261a42a96ca250812fe1004e40440855/jdk/test/java/lang/invoke/ExplicitCastArgumentsTest.java#L1 as per https://github.com/eclipse/openj9/issues/6856

JDK11

java/lang/StackWalker/LocalsAndOperands.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/965d0c0df359f3da224b865701bbcc044b7104c2/test/jdk/java/lang/StackWalker/LocalsAndOperands.java#L1 as per https://github.com/eclipse/openj9/issues/6704

java/lang/StackWalker/ReflectionFrames.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/965d0c0df359f3da224b865701bbcc044b7104c2/test/jdk/java/lang/StackWalker/ReflectionFrames.java#L1 as per https://github.com/eclipse/openj9/issues/6724

java/lang/invoke/ClassSpecializerTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/965d0c0df359f3da224b865701bbcc044b7104c2/test/jdk/java/lang/invoke/ClassSpecializerTest.java#L1 as per https://github.com/eclipse/openj9/issues/6779

java/lang/Enum/ConstantDirectoryOptimalCapacity.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/b44d19c4cbca42541aef5132f21870c1b924a68c/test/jdk/java/lang/Enum/ConstantDirectoryOptimalCapacity.java#L1 as per https://github.com/eclipse/openj9/issues/6660

java/lang/invoke/VarHandle/AccessMode/OptimalMapSize.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/8bf2a8166185765e9c6ddbffb66d1adbee67fd16/test/jdk/java/lang/invoke/VarHandle/AccessMode/OptimalMapSize.java#L1 as per https://github.com/eclipse/openj9/issues/6660

java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/259a016054953a431bbcb198848372c7830116ad/test/jdk/java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java#L1 as per https://github.com/eclipse/openj9/issues/6963

java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/3c31c8cb4eb3eaed4de1a1438fa4f83e550fa51e/test/jdk/java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java#L1 as per https://github.com/eclipse/openj9/issues/6963

java/lang/annotation/AnnotationsInheritanceOrderRedefinitionTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/openj9/test/jdk/java/lang/annotation/AnnotationsInheritanceOrderRedefinitionTest.java as per https://github.com/eclipse/openj9/issues/6700

java/lang/invoke/ArrayConstructorTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/965d0c0df359f3da224b865701bbcc044b7104c2/test/jdk/java/lang/invoke/ArrayConstructorTest.java#L1 as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/1288

java/lang/invoke/LambdaFormTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/3c31c8cb4eb3eaed4de1a1438fa4f83e550fa51e/test/jdk/java/lang/invoke/LambdaFormTest.java#L1 as per https://github.com/eclipse/openj9/issues/7055

java/lang/invoke/PrivateInterfaceCall.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/6716544a3e1aab5520e36418b4378172e358fd2f/test/jdk/java/lang/invoke/PrivateInterfaceCall.java#L1 as per https://github.com/eclipse/openj9/issues/7071

java/lang/invoke/SpreadCollectTest.java
https://github.com/M-Davies/openj9-openjdk-jdk11/blob/3c31c8cb4eb3eaed4de1a1438fa4f83e550fa51e/test/jdk/java/lang/invoke/SpreadCollectTest.java#L1 as per https://github.com/eclipse/openj9/issues/7123

java/lang/invoke/TryFinallyTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/4d41e016d25f4fd55a044c9e6556dba844f164a3/test/jdk/java/lang/invoke/TryFinallyTest.java#L1 as per https://github.com/eclipse/openj9/issues/7154

java/lang/invoke/SpecialInterfaceCall.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/4d41e016d25f4fd55a044c9e6556dba844f164a3/test/jdk/java/lang/invoke/SpecialInterfaceCall.java#L1 as per https://github.com/eclipse/openj9/issues/7154

java/lang/invoke/VarargsArrayTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/502ab02dbda2e8b021cffedc3f52e25246cdeec1/test/jdk/java/lang/invoke/VarargsArrayTest.java#L1 as per https://github.com/eclipse/openj9/issues/7183

java/lang/ref/CleanerTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/502ab02dbda2e8b021cffedc3f52e25246cdeec1/test/jdk/java/lang/ref/CleanerTest.java#L1 as per issue https://github.com/eclipse/openj9/issues/7205

java/lang/invoke/DefineClassTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/502ab02dbda2e8b021cffedc3f52e25246cdeec1/test/jdk/java/lang/invoke/DefineClassTest.java#L1 as per https://github.com/eclipse/openj9/issues/6800

java/lang/ref/OOMEInReferenceHandler.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/502ab02dbda2e8b021cffedc3f52e25246cdeec1/test/jdk/java/lang/ref/OOMEInReferenceHandler.java#L1 as per https://github.com/eclipse/openj9/issues/7251

java/lang/ref/NullQueue.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/502ab02dbda2e8b021cffedc3f52e25246cdeec1/test/jdk/java/lang/ref/NullQueue.java#L1 as per https://github.com/eclipse/openj9/issues/7251

java/lang/ref/ReachabilityFenceTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/b44d19c4cbca42541aef5132f21870c1b924a68c/test/jdk/java/lang/ref/ReachabilityFenceTest.java#L1 as per https://github.com/eclipse/openj9/issues/7251

java/lang/reflect/AccessibleObject/ModuleSetAccessibleTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/b44d19c4cbca42541aef5132f21870c1b924a68c/test/jdk/java/lang/reflect/AccessibleObject/ModuleSetAccessibleTest.java#L1 as per https://github.com/eclipse/openj9/issues/7412

java/lang/ref/FinalizerHistogramTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/502ab02dbda2e8b021cffedc3f52e25246cdeec1/test/jdk/java/lang/ref/FinalizerHistogramTest.java#L1 as per https://github.com/eclipse/openj9/issues/7226

java/lang/invoke/LoopCombinatorTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/3c31c8cb4eb3eaed4de1a1438fa4f83e550fa51e/test/jdk/java/lang/invoke/LoopCombinatorTest.java#L1 as per https://github.com/eclipse/openj9/issues/7009

java/lang/reflect/AccessibleObject/TrySetAccessibleTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/b44d19c4cbca42541aef5132f21870c1b924a68c/test/jdk/java/lang/reflect/AccessibleObject/TrySetAccessibleTest.java#L1 as per https://github.com/eclipse/openj9/issues/7412

java/lang/reflect/Nestmates/TestReflectionAPI.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/cc4272e86c12e635710cca2a4c5833c37e398c7b/test/jdk/java/lang/reflect/Nestmates/TestReflectionAPI.java#L1 as per Internal Conversations (Test uses Hotspot specific error messages)

java/lang/invoke/ExplicitCastArgumentsTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/32a0264d0318487ca1a46c7406ea2724d347b5aa/test/jdk/java/lang/invoke/ExplicitCastArgumentsTest.java#L1 as per https://github.com/eclipse/openj9/issues/6856

java/lang/StackWalker/Basic.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/2c50aba301747fe52e52253e9193ea8c5029c0eb/test/jdk/java/lang/StackWalker/Basic.java#L1 as per https://github.com/eclipse/openj9/issues/6698 (see https://github.com/eclipse/openj9/issues/7124#issuecomment-565446631)

java/lang/reflect/Proxy/ProxyLayerTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/fa28912a4b2a5a239b4ce8b4ee94a5952d70fb3d/test/jdk/java/lang/reflect/Proxy/ProxyLayerTest.java#L1 as per https://github.com/eclipse/openj9/issues/7775

java/nio/Buffer/LimitDirectMemoryNegativeTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/d1ca0ebebed5e71a5737159c2259d562b8c8ed9b/test/jdk/java/nio/Buffer/LimitDirectMemoryNegativeTest.java#L1 as per issue https://github.com/eclipse/openj9/issues/8065

JDK13

java/lang/invoke/VarargsArrayTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk13/blob/f960ab42e3d88b96046b2f4971a98b1d265dd814/test/jdk/java/lang/invoke/VarargsArrayTest.java#L1 as per https://github.com/eclipse/openj9/issues/7183

java/lang/ref/ReachabilityFenceTest.java#L1
https://github.com/ibmruntimes/openj9-openjdk-jdk13/blob/f960ab42e3d88b96046b2f4971a98b1d265dd814/test/jdk/java/lang/ref/ReachabilityFenceTest.java#L1 as per https://github.com/eclipse/openj9/issues/7251

java/lang/reflect/AccessibleObject/ModuleSetAccessibleTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk13/blob/f960ab42e3d88b96046b2f4971a98b1d265dd814/test/jdk/java/lang/reflect/AccessibleObject/ModuleSetAccessibleTest.java#L1 as per https://github.com/eclipse/openj9/issues/7412

java/lang/ref/FinalizerHistogramTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk13/blob/f960ab42e3d88b96046b2f4971a98b1d265dd814/test/jdk/java/lang/ref/FinalizerHistogramTest.java#L1 as per https://github.com/eclipse/openj9/issues/7226

java/lang/invoke/LoopCombinatorTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk13/blob/f960ab42e3d88b96046b2f4971a98b1d265dd814/test/jdk/java/lang/invoke/LoopCombinatorTest.java#L1 as per https://github.com/eclipse/openj9/issues/7009

java/lang/reflect/AccessibleObject/TrySetAccessibleTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk13/blob/f960ab42e3d88b96046b2f4971a98b1d265dd814/test/jdk/java/lang/reflect/AccessibleObject/TrySetAccessibleTest.java#L1 as per https://github.com/eclipse/openj9/issues/7412

java/lang/reflect/Nestmates/TestReflectionAPI.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/cc4272e86c12e635710cca2a4c5833c37e398c7b/test/jdk/java/lang/reflect/Nestmates/TestReflectionAPI.java#L1 as per Internal Conversations (Test uses Hotspot specific error messages)

java/lang/StackWalker/ReflectionFrames.java
https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/965d0c0df359f3da224b865701bbcc044b7104c2/test/jdk/java/lang/StackWalker/ReflectionFrames.java#L1 as per https://github.com/eclipse/openj9/issues/6724

java/lang/invoke/ExplicitCastArgumentsTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk13/blob/d90d6bee77de18a6a8f3dbd0452a37941b13ecf4/test/jdk/java/lang/invoke/ExplicitCastArgumentsTest.java#L1 as per https://github.com/eclipse/openj9/issues/6856

JDK14

java/lang/StackWalker/Basic.java
https://github.com/ibmruntimes/openj9-openjdk-jdk14/blob/4dfccdbccdeb7ac68a5a7631f8652e37043385f6/test/jdk/java/lang/StackWalker/Basic.java#L1 as per https://github.com/eclipse/openj9/issues/6698 (see https://github.com/eclipse/openj9/issues/7124#issuecomment-565446631)

java/lang/reflect/Proxy/ProxyLayerTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk14/blob/9c80b65998489ca6deb5fecd9dce5b9e2e6e2196/test/jdk/java/lang/reflect/Proxy/ProxyLayerTest.java#L1 as per https://github.com/eclipse/openj9/issues/7775

java/nio/Buffer/LimitDirectMemoryNegativeTest.java
https://github.com/ibmruntimes/openj9-openjdk-jdk14/blob/openj9/test/jdk/java/nio/Buffer/LimitDirectMemoryNegativeTest.java#L1 as per issue https://github.com/eclipse/openj9/issues/8065

Can i suggest a change to this to help with readability; using the format:
java/lang/String/test1.java      [link to issue]
As it is quite hard to see which tests are in this list

Done 👍

jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java https://github.com/eclipse/openj9/issues/7167 11,13

I noticed that the links to the files were all pointing to JDK11 files and not their own implementations. This has been fixed

java/lang/Class/GetModuleTest.java on jdk11 and 13: https://github.com/eclipse/openj9/issues/3040

java/util/concurrent/atomic/VMSupportsCS8.java on jdk8 and 11: https://github.com/AdoptOpenJDK/openjdk-tests/issues/1347

java/util/logging/TestLoggerWeakRefLeak.java (all versions) https://github.com/AdoptOpenJDK/openjdk-tests/issues/1352

Permanently excluding, java/util/WeakHashMap/GCDuringIteration.java (for jdk11+, https://github.com/eclipse/openj9/issues/10256) via #2083

java/lang/StringBuilder/HugeCapacity.java (for jdk16, https://github.com/eclipse/openj9/issues/10582) via https://github.com/AdoptOpenJDK/openjdk-tests/pull/2141

java/lang/StringBuilder/HugeCapacity.java (for jdk16, https://github.com/eclipse/openj9/issues/10582) via https://github.com/AdoptOpenJDK/openjdk-tests/pull/2141

Adding for jdk8 only:
com/sun/crypto/provider/Cipher/AES/TestAESCiphers/TestAESWithProviderChange.java
com/sun/crypto/provider/Cipher/AES/TestAESCiphers/TestAESWithRemoveAddProvider.java

Highlighted originally by issue: https://github.com/eclipse/openj9/issues/11614

Adding for jdk8 only:
com/sun/crypto/provider/Cipher/AES/TestAESCiphers/TestAESWithProviderChange.java
com/sun/crypto/provider/Cipher/AES/TestAESCiphers/TestAESWithRemoveAddProvider.java

Highlighted originally by issue: https://github.com/eclipse/openj9/issues/11614

Excluding java/lang/management/MemoryMXBean/ResetPeakMemoryUsage on openj9 as this test is specific to hotspot.
Excluding the above on jdk11+.

com/sun/jdi/JdbMethodExitTest.sh as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/Redefine-g.sh as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/AllLineLocations.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/EarlyReturnTest.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/MethodExitReturnValuesTest.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/NativeInstanceFilter.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/PopAndStepTest.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/PopAsynchronousTest.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/PopSynchronousTest.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/RedefineCrossStart.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415
com/sun/jdi/redefineMethod/RedefineTest.java as per https://github.com/AdoptOpenJDK/openjdk-tests/issues/2415

Excluding below tests as per #2422
java/lang/management/ManagementFactory/ValidateOpenTypes.java
java/lang/management/MemoryMXBean/MemoryManagement.java
java/lang/management/ManagementFactory/ProxyTypeMapping.java
java/lang/management/MemoryMXBean/CollectionUsageThreshold.java
java/lang/management/MemoryMXBean/LowMemoryTest2.sh
java/lang/management/GarbageCollectorMXBean/GcInfoCompositeType.java
java/lang/management/CompositeData/MemoryUsageCompositeData.java
javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
sun/management/jmxremote/bootstrap/LocalManagementTest.java
sun/management/jmxremote/startstop/JMXStartStopTest.java
sun/management/jmxremote/startstop/JMXStatusPerfCountersTest.java
sun/management/jmxremote/startstop/JMXStatusTest.java
java/nio/channels/Selector/OutOfBand.java
java/nio/channels/FileChannel/directio/ReadDirect.java
java/nio/channels/FileChannel/directio/PreadDirect.java
java/nio/channels/FileChannel/directio/PwriteDirect.java
java/nio/channels/FileChannel/TempDirectBuffersReclamation.java

Excluding below tests as per #2590
java/lang/management/MemoryMXBean/MemoryManagementConcMarkSweepGC.sh
java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh
java/lang/management/MemoryMXBean/MemoryTestAllGC.sh
java/lang/management/MemoryMXBean/MemoryTest.java
java/lang/management/MemoryMXBean/LowMemoryTest.java
javax/management/Introspector/ClassLeakTest.java
java/lang/management/MemoryMXBean/MemoryTestZGC.sh

Excluding below test on OpenJ9 for JDK11+ releases.
tools/launcher/MainClassCantBeLoadedTest.java

Excluding below tests on OpenJ9 for JDK11+ releases.
com/sun/management/DiagnosticCommandMBean/DcmdMBeanDoubleInvocationTest.java
com/sun/management/DiagnosticCommandMBean/DcmdMBeanInvocationTest.java
com/sun/management/DiagnosticCommandMBean/DcmdMBeanPermissionsTest.java
com/sun/management/DiagnosticCommandMBean/DcmdMBeanTest.java

Excluding below test as per runtimes/backlog/issues/795
sun/security/ssl/CipherSuite/DisabledCurve.java

Excluding below test on OpenJ9 for JDK20 as per https://github.com/adoptium/aqa-tests/pull/4489 given VaList was removed in https://openjdk.org/jeps/442:
java/foreign/valist/VaListTest.java

Excluding below test as per https://github.com/adoptium/aqa-tests/issues/4535
sun/security/pkcs12/KeytoolOpensslInteropTest.java

Excluding below tests on z/OS for both JDK11 and JDK17
java/lang/management/MemoryMXBean/MemoryManagementConcMarkSweepGC.sh
java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh
java/lang/management/MemoryMXBean/MemoryTestAllGC.sh
java/lang/management/MemoryMXBean/MemoryTest.java
java/lang/management/MemoryMXBean/LowMemoryTest.java
javax/management/Introspector/ClassLeakTest.java
java/lang/management/MemoryMXBean/MemoryTestZGC.sh
com/sun/management/OperatingSystemMXBean/GetFreePhysicalMemorySize.java
java/nio/channels/FileChannel/directio/WriteDirect.java
java/nio/channels/DatagramChannel/Promiscuous.java
java/lang/management/MemoryMXBean/MemoryManagementConcMarkSweepGC.sh
java/lang/management/MemoryMXBean/MemoryManagementParallelGC.sh
java/lang/management/MemoryMXBean/MemoryManagementSerialGC.sh
java/lang/management/MemoryMXBean/MemoryTestAllGC.sh
java/lang/management/MemoryMXBean/MemoryTest.java
java/lang/management/MemoryMXBean/LowMemoryTest.java
javax/management/Introspector/ClassLeakTest.java
java/lang/management/MemoryMXBean/MemoryTestZGC.sh
com/sun/management/OperatingSystemMXBean/GetFreePhysicalMemorySize.java
java/nio/channels/FileChannel/directio/WriteDirect.java
java/nio/channels/DatagramChannel/Promiscuous.java

Excluding below tests on JDK17 z/OS
java/foreign/SafeFunctionAccessTest.java
java/foreign/TestNative.java
java/foreign/TestSymbolLookup.java

Excluding below tests on JDK17 z/OS
java/foreign/TestVarArgs.java
java/foreign/valist/VaListTest.java
java/foreign/virtual/TestVirtualCalls.java
javax/xml/crypto/dsig/SecureValidation.java

exclude javax/management/security/HashedPasswordFileTest.java as per https://github.com/eclipse-openj9/openj9/issues/20587#issuecomment-2479467441


Swap: Validate balances needed to cover fees

closed by https://github.com/thorchain/asgardex-electron/pull/663


Feature: Record Tokenization

Feature description
Add support for tokenization of records. Put record into datastore and replace record with a reference.
This would not necessarily be something added to conduit core, but instead could be a processor.

Ideally we could reuse connectors for inserting records into the datastore. This would kind of be something between a processor and a connector.


Failed to handle PDU

Synapse 1.73.0
Python3.8
Ubuntu 20.04
When I used it, I found a large number of errors, such as
2022-12-13 00:00:14,690 - synapse.federation.federation_server - 504 - ERROR - PUT-235833-!ttKPgmaucSQTHmGurC: example.com -$VSsQ9L4ygzCuIqA1Lc_LGTvPuQsPXKBGSZQBteBTeoY - Failed to handle PDU $VSsQ9L4ygzCuIqA1Lc_LGTvPuQsPXKBGSZQBteBTeoY
Traceback (most recent call last):
  File "/opt/venvs/matrix-synapse/lib/python3.8/site-packages/synapse/federation/federation_server.py", line 497, in process_pdu
    await self._handle_received_pdu(origin, pdu)
  File "/opt/venvs/matrix-synapse/lib/python3.8/site-packages/synapse/federation/federation_server.py", line 1112, in _handle_received_pdu
    pdu = await self._check_sigs_and_hash(room_version, pdu)
  File "/opt/venvs/matrix-synapse/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 889, in _wrapper
    return await func(*args, **kwargs)  # type: ignore[misc]
  File "/opt/venvs/matrix-synapse/lib/python3.8/site-packages/synapse/federation/federation_base.py", line 140, in _check_sigs_and_hash
    spam_check = await self.spam_checker.check_event_for_spam(pdu)
  File "/opt/venvs/matrix-synapse/lib/python3.8/site-packages/synapse/logging/opentracing.py", line 889, in _wrapper
    return await func(*args, **kwargs)  # type: ignore[misc]
  File "/opt/venvs/matrix-synapse/lib/python3.8/site-packages/synapse/events/spamcheck.py", line 408, in check_event_for_spam
    res = await delay_cancellation(callback(event))
  File "/opt/venvs/matrix-synapse/lib/python3.8/site-packages/twisted/internet/defer.py", line 1697, in _inlineCallbacks
    result =
context.run
(gen.send, result)
  File "/opt/venvs/matrix-synapse/lib/python3.8/site-packages/synapse_spamcheck_badlist/bad_list_filter.py", line 167, in check_event_for_spam
    for _ in automaton.iter(text):
AttributeError: Not an Aho-Corasick automaton yet: call add_word to add some keys and call make_automaton to convert the trie to an automaton.

I found that the federation function was severely affected.

That looks like the links_table has been improperly configured, or is empty.


updated README to include module registry path

/do-e2e-tests

Looks good. Approve to merge to main.


Techempower Web Framework Benchmarks: colossus added

Hi,
don't know if you guys heard of Techempower's Web Framework Benchmarks.
They basically have been running some tests and compared different web frameworks.
Their 11th round will be up soon and I've added code for colossus. Preliminary results are already available here.
Their second preview of round11 will be available on June 16th. If you guys feel like my code is missing something, feel free to PR.

Any reason why Colossus is only showing up in the JSON section, and not any others?
If we wanted to swap out lift-json for something else(ie: jackson), would that be cool?

Also, I'm curious to the 74 errors in the plaintext section.  Anyway we can have a peek at those?

Just to make things clear: I am in no way involved in Techempower or anything. I was just passively following their benchmark until I realized I wanted to see results for frameworks I follow/like (colossus*, http4s). So I did what they require you to do if you want to add your own implementation.
That said, you can either fork their repo and fix/add what I already committed.
Or we can work together, should you like us to do.
errors for the preview tests are here
There's a google group if you want to talk to them here.
*I do realize colossus is much more than "just" a web framework, but nonetheless I wanted to check out on its performances.

Ah..ok, my mistake.  Well, thanks for the heads up, this is actually something we've been meaning to do, so thanks for spurring us on!

Sure, no problem. Let me know if you go ahead with this and if you need me for anything. (you can close this non-issue)

Hey thanks a bunch for submitting the code.  I was actually going to do this myself pretty soon.  The service code itself looks pretty good.
I'll have to dive in a bit and see what's going on.  The results from both benchmarks diverge quite a bit from our internal benchmarks (done on similar hardware and in the same fashion), but the throughput on the plaintext benchmark is especially surprising.  In all our internal benchmarks Colossus is basically on par with Vertx, so I would expect to see similar results here.
Also the fact that the plaintext latency numbers for Colossus are significantly lower than everybody else is really bizarre.  It leads me to believe that the service was not actually being pushed to its limits.  Also all of the "dropped reply" error messages are very odd.

Ok, so I've uncovered a few very interesting things.  For one thing, I've been using wrk wrong this whole time!  I had assumed it was doing pipelining on its own, and didn't realize you had to feed it a Lua script to enable it (which in retrospect makes a whole lot more sense actually).  you can see where Techempower is doing it here
In short, I found a pretty big performance bottleneck in Colossus with pipelined requests.  Essentially it's being way too eager with trying to write responses to the socket.  Currently it's doing a write for every response, whereas it should be buffering and doing only one write per event loop iteration.  I experimented with a hacky implementation that adds the buffering and that immediately more than doubled performance.
I have a similar setup as the Techempower environment (2 machines with dual Xeon E5 v2 and 10GbE) and now I'm getting 2.1M req/sec (with latency 50% at 1.2ms) for a barebones Colossus service.
I'll be working on the proper implementation for the fix over the next couple days and we'll push it out with an 0.6.4 release and hopefully get it in before the next preliminary run on the 16th.
In terms of the benchmark code, I also found a few things and will be submitting a PR once we get the updates into Colossus:

generating a timestamp per request has a huge performance impact.  We can use an actor with a timer to generate them only once per second.  Eventually we should probably bake that logic into colossus.
chaining .withHeader calls also has a performance hit.  We should just create the HttpResponse all in one shot
The Url matching DSL is doing some somewhat inefficient stuff.  I've known about this but the impact is more than I would have suspected.  I think for the benchmark we should just look at the raw url.

There's still some weirdness with the Techempower numbers, particularly the latency numbers, but I think this'll put us on the right track.  So I'll leave this ticket open until we get all that done and merged in.  I'll also start a separate issue for the buffering fix.

Awesome work! I don't know whether I should be happy or sorry this all thing came out somehow because of me.
Keep it goin' folks!

Preliminary results: https://www.techempower.com/benchmarks/previews/round11/

Gonna close this issue now as I think all the low-hanging fruit has been addressed.  The first round of fixes nearly doubled our score on the plaintext benchmark and another PR is out that I think will give it another big bump.  On our own hardware, I have the benchmark service up from 2.1M req/sec to 3.6M.


assignment mismatch when installing chromedp

What versions are you running?

$ go list -m github.com/chromedp/chromedp
go list -m: not using modules
$ google-chrome --version
google-chrome : The term 'google-chrome' is not recognized as the name of a cmdlet, function, script file...
$ go version
go version go1.15.6 windows/amd64

What did you do? Include clear steps.
Ran "go get -u github.com/chromedp/chromedp"
What did you expect to see?
Something about it being successfully installed.
What did you see instead?
# github.com/chromedp/chromedp
..\github.com\chromedp\chromedp\chromedp.go:157:15: assignment mismatch: 2 variables but action.Do returns 1 values

When I removed "ok" from line 157 of chromedp.go, I then got this error:
"assignment mismatch: 1 variable but action.Do returns 2 values"
So I'm not sure what's going on.

I just tagged a new version, v0.6.0. You likely updated in the brief window and pulled the previous tag, but then updated the cdproto package. Due to a (minor) change in how the CloseTarget API is defined by Chromium v87 vs v89, this necessitated this minor change. Either pin chromedp to the previous v0.5.5 tag, or use v0.6.0. You should be able to force an update to v0.6.0:
$ go get -u<EMAIL_ADDRESS>

I just tagged a new version, v0.6.0. You likely updated in the brief window and pulled the previous tag, but then updated the cdproto package. Due to a (minor) change in how the CloseTarget API is defined by Chromium v87 vs v89, this necessitated this minor change. Either pin chromedp to the previous v0.5.5 tag, or use v0.6.0. You should be able to force an update to v0.6.0:
$ go get -u<EMAIL_ADDRESS>

go get -u<EMAIL_ADDRESS>

It says I "cannot use path@version syntax in GOPATH mode" but manually downloading the v0.6.0 files did indeed fix it

go get -u<EMAIL_ADDRESS>

It says I "cannot use path@version syntax in GOPATH mode" but manually downloading the v0.6.0 files did indeed fix it

There was a minor typo in my comment. I misspelled the package name in the path. Apologies. If you're using Go modules, make sure they are enabled. If you're not using Go modules, then you'll need to make sure you have the latest chromedp source tree on disk.

There was a minor typo in my comment. I misspelled the package name in the path. Apologies. If you're using Go modules, make sure they are enabled. If you're not using Go modules, then you'll need to make sure you have the latest chromedp source tree on disk.


Need support for "url safe base64"

Some apps that use base64 encoding use url-safe format instead of just url-encoding problematic base64 characters. Need to add a mode to account for this.

fixed in 2.1


[Feature Request] Dark Mode Support

A dark mode would be great for reading.

Assign me this issue


feat: add path breadcrumbs

Summary of changes

convert path bar to a component that renders clickable breadcrumbs instead of a static path
add button to copy path to clipboard which works on all OS
keep path in Attribution Wizard unchanged

Context and reason for change
Closes #1501.
How can the changes be tested
Check that "copy to clipboard" link produces a correct path on Windows.
File with resources which are nested 10 levels deep:
input.json

Great PR, just one request: a way to collapse the path again, without reopening the file.

MUI does not support re-collapsing. The question would probably be: where should such a button to re-collapse be located and why should it even be there? In my opinion, we're also fine without this.

Great PR, just one request: a way to collapse the path again, without reopening the file.

MUI does not support re-collapsing. The question would probably be: where should such a button to re-collapse be located and why should it even be there? In my opinion, we're also fine without this.

I would argue, that if it worth collapsing in the first place, it is worth being able to go back to that default condition. Having said that, I have no genius idea. There is no obvious opposite of the three points, and an explicit collapse button would probably look bad. We could just reset it when moving to a different resource. What do you think about that?

Great PR, just one request: a way to collapse the path again, without reopening the file.

MUI does not support re-collapsing. The question would probably be: where should such a button to re-collapse be located and why should it even be there? In my opinion, we're also fine without this.

I would argue, that if it worth collapsing in the first place, it is worth being able to go back to that default condition. Having said that, I have no genius idea. There is no obvious opposite of the three points, and an explicit collapse button would probably look bad. We could just reset it when moving to a different resource. What do you think about that?

Yes, that I can do: https://github.com/opossum-tool/OpossumUI/pull/2283/files#diff-c3f47559928cee00d819d0ab68bd8a3510c5c8c436e8e9d074c3ea0f488aaa87R60


Font management

I have no better idea than what teek does.
Usually you don't need a named, mutable font object, just an object to specify the widget font, so a tcl namedfont is a total waste of memory. On the other hand it isn't good to have multiple font classes to different tasks.

Resolved bx #70


Improve .gitignore by generating

Git .gitignore files are most of the time generated based on the environment in which you are working. Our gitignore is still made from scratch and thus a lot of awareness must be given to not adding files we do not want in this repo.
Using tools like this one: https://github.com/generate/generate-gitignore, we can easily improve our .gitignore with all common file names that are not interesting in a js/node env.

Has been fixed when env folder has been removed #409


Enforce explicit finalization on Harvester or ImageAcquirer objects.

Is your feature request related to a problem? Please describe.
In the early versions before or equal to 0.2.6, Harvester and ImageAcquirer objects executed their finalization procedures on the __del__ method call but it brought us an inconsistency: For example, when a __del__ method is called the program is being shut down and some Python objects including built-in methods such as open have already been destructed. It means our __del__ method might not work due to the objects that have been destructed during the shutdown process. Actually, we can get the following exception when we try to log using the file handler:
NameError: name 'open' is not defined
Describe the solution you'd like
There could be a better solution but enforce users to explicitly call ImageAcquirer.descruct or Harvester.reset method. However, Harvester should keep the __enter__ and the __exit__ methods so that people can rely on the with method.
Describe alternatives you've considered
None.
Additional context
None.

This issue has finally resolved by #73.


Error when run make on windows

trying to compile columbus with go, we got the following errors for each try/proxy conf.

go version
go version go1.16.5 windows/amd64

go env GOPROXY GONOPROXY
https://proxy.golang.org,direct

cd  path\to\columbus

make
go build -ldflags "-X main.Version=" "github.com/odpf/columbus"
go<EMAIL_ADDRESS>Get<EMAIL_ADDRESS>read tcp <IP_ADDRESS>:61982-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host.
make: *** [Makefile:10: build] Error 1

go env -w GONOPROXY=https://github.com
go env GOPROXY GONOPROXY
https://proxy.golang.org,direct
https://github.com

make
go build -ldflags "-X main.Version=" "github.com/odpf/columbus"
go<EMAIL_ADDRESS>Get<EMAIL_ADDRESS>read tcp <IP_ADDRESS>:62019-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host.
make: *** [Makefile:10: build] Error 1

go env -w GOPROXY=direct
go env GOPROXY GONOPROXY
direct
https://github.com

make
go build -ldflags "-X main.Version=" "github.com/odpf/columbus"
go<EMAIL_ADDRESS>reading github.com/PaesslerAG/jsonpath/go.mod at revision v0.1.1: unknown revision v0.1.1
make: *** [Makefile:10: build] Error 1

go env -u GONOPROXY
go env -w GOPROXY=http://my.company.proxy:port

make
go build -ldflags "-X main.Version=" "github.com/odpf/columbus"
go<EMAIL_ADDRESS>reading<EMAIL_ADDRESS>403 Forbidden
make: *** [Makefile:10: build] Error 1

trying again, after get rid of my company proxy

go env GOPROXY GONOPROXY
direct

make
go build -ldflags "-X main.Version=" "github.com/odpf/columbus"
go<EMAIL_ADDRESS>reading github.com/elastic/go-elasticsearch/go.mod at revision v0.0.0: unknown revision v0.0.0
make: *** [Makefile:10: build] Error 1

Hi  @hossam-houssien, I tried reproducing your error but no success.

go version
go version go1.16.5 windows/amd64

go env GOPROXY GONOPROXY
https://proxy.golang.org,direct

make
The system cannot find the path specified.
go build -ldflags "-X main.Version=" "github.com/odpf/columbus"
# get<EMAIL_ADDRESS># get<EMAIL_ADDRESS># get<EMAIL_ADDRESS># get<EMAIL_ADDRESS>...

which built columbus.exe at the end.
Can you try installing the package manually by running
go get<EMAIL_ADDRESS>

turned out it was a bad day for our vpn system "cisco anyconnect", so I had to shutdown on my pc, and now I got columbus.exe.
thanks a lot

Oh glad to hear it is working.
Will close the issue since it seems to be resolved. 😄


Prohibit use of WorkflowClient from workflow code - proposal

What was changed
Added explicit checks that throw exception from WorkflowClient and Activity APIs if they are called from workflow threads.
Why?
New users might not be aware of nondeterministic requirements and might use WorkflowClient and Activity interfaces from the workflow code.
Checklist

Closes #402

How was this tested:
Unit test

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: vkoby:x: Dmitry SpikhalskiyDmitry Spikhalskiy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Step

"A Survey of Collaborative Editing Techniques" by Sun and Scissors, "Operational Transformation in Real-Time Group Editors: Issues, Algorithms, and Achievements" by Ellis.
ShareJS.
ShareDB

I was wrong. CRDTs are the future

High-Latency, Low-Bandwidth Windowing in the Jupiter Collaboration System.

Concurrency control in groupware systems


Clarification + Documentation

Hi Team,
I have two questions.

I get the same values when I run GeneUsage for TRAV and TRBV, and similarly the same data frame output for TRAJ and TRBJ. There should be variation in the alpha and beta chains of the TCR returning different clonotype values and sequences. Kindly clarify.

I'm looking for detailed documentation about the GeneUsage feature in the package.  I want to get a hold of how the matching/alignments take place to give an output of the TRBV sequences.  Understanding the algorithm behind which it's run might help validate no loss of sequences - since our objective centers around novelty.

Hi @shreyarajasekar
Thank you for opening the issue. Could you share the code that you use to run geneUsage please?
The docs are available on the website: https://immunarch.com/reference/geneUsage.html
Or you could run the following command in the R console: ?geneUsage
I'm open to scheduling a short call to discuss this issue over Zoom if this accelerates things.

Hi @vadimnazarov thanks for the prompt response, appreciate it.
A quick Zoom call would be great.
Here's what  I ran.

I've gone through the documentation that exists, but would be helpful to have a deeper insight into the algorithms behind it.

Hi @vadimnazarov, following up regarding getting the same alignment for alpha and beta sequences.


refactor(ci_skeleton): template

Checklist

[ ] Added a news entry

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
2552 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-64.0%) to 3.645%

Files with Coverage Reduction
New Missed Lines
%

conda_smithy/azure_defaults.py
2
0.0%

conda_smithy/cirun_utils.py
12
0.0%

conda_smithy/validate_schema.py
14
42.11%

conda_smithy/github.py
20
0.0%

conda_smithy/utils.py
32
31.18%

conda_smithy/azure_ci_utils.py
40
0.0%

conda_smithy/feedstock_io.py
51
14.89%

conda_smithy/ci_register.py
54
0.0%

conda_smithy/anaconda_token_rotation.py
87
0.0%

conda_smithy/variant_algebra.py
137
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-64.0%

Covered Lines:
209

Relevant Lines:
4003

💛  - Coveralls


[FEATURE] Support describe command in PPL

Is your feature request related to a problem?
Currently there's no way to query the metadata of an index using ppl.
What solution would you like?
Support the describe command (like sql) in ppl.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
For the observability plugin, queries are associated with a date/time range specified in the date/time selection UI. We insert a where-command into the PPL query to filter out the specified date/time range. To achieve that, we need to know the field names that contain the date/time info. A describe command in ppl could help with that.

Regarding the command syntax, I have a couple of candidates. I need some comments and feedback.
Candidate 1
describe source=<index> [column_pattern=<column pattern>]
Examples:

describe source=web_logs
describe source=web_logs column_pattern="%time%"

Comments:

straightforward enough
distinguish admin statements from data query statements

Candidate 2
[search] source=<index> | describe [column_pattern=<column pattern>]
Examples:

source=web_logs | describe
source=web_logs | describe column_pattern="%time%"

Comments:

mixing admin statements and data query statements might not be a good idea

Candidate 3
describe source=<index> [column_pattern=<column pattern>] [type_name=<type name>]
Examples:

describe source=web_logs type_name="date"

Comments:

judging from the specific use case for the observability plugin, merely pattern matching in field name might not be enough. The timestamp field could have all kinds of names, e.g. timestamp, utc_time, etc., even names that don’t have time in it, e.g., date_nanos. Type filtering could help with this use case.

Candidate 4
A wilder one would be allowing piping out from the describe command, so that we can do something like this:
describe source=<index> | where type_name="date" | fields column_name
I'm not sure how feasible this is, though.

My opinion:

I find candidate 4 to be the most PPL-like and extendable.
If you can't go with candidate 4, candidate 1 or 3 is fine.
I don't think candidate 2 is necessary, and may cause syntax issues as you mentioned.

You may run into issues with the column_pattern, like: https://github.com/opensearch-project/sql/issues/259

Currently, when I run SQL describe tables - if I use the columns like pattern I get no data back:
sql-cli -q "DESCRIBE TABLES LIKE \"calcs\" COLUMNS LIKE \"TABLE_NAME\";"
fetched rows / total rows = 0/0
+-------------+---------------+--------------+---------------+-------------+-------------+---------------+-----------------+------------------+------------------+------------+-----------+--------------+-----------------+--------------------+---------------------+--------------------+---------------+-----------------+----------------+---------------+--------------------+--------------------+----------------------+
| TABLE_CAT   | TABLE_SCHEM   | TABLE_NAME   | COLUMN_NAME   | DATA_TYPE   | TYPE_NAME   | COLUMN_SIZE   | BUFFER_LENGTH   | DECIMAL_DIGITS   | NUM_PREC_RADIX   | NULLABLE   | REMARKS   | COLUMN_DEF   | SQL_DATA_TYPE   | SQL_DATETIME_SUB   | CHAR_OCTET_LENGTH   | ORDINAL_POSITION   | IS_NULLABLE   | SCOPE_CATALOG   | SCOPE_SCHEMA   | SCOPE_TABLE   | SOURCE_DATA_TYPE   | IS_AUTOINCREMENT   | IS_GENERATEDCOLUMN   |
|-------------+---------------+--------------+---------------+-------------+-------------+---------------+-----------------+------------------+------------------+------------+-----------+--------------+-----------------+--------------------+---------------------+--------------------+---------------+-----------------+----------------+---------------+--------------------+--------------------+----------------------|
+-------------+---------------+--------------+---------------+-------------+-------------+---------------+-----------------+------------------+------------------+------------+-----------+--------------+-----------------+--------------------+---------------------+--------------------+---------------+-----------------+----------------+---------------+--------------------+--------------------+----------------------+

source is always the first cmd, that is a PPL syntax limitation for now which invalidates option, 4,3,1
Ideally a user should be able to return query data and describe data. or choose between it. Hence, Open 2 is best
source= | describe [column_pattern=]
Examples:
source=web_logs | describe
source=web_logs | describe column_pattern="%time%"
source=web_logs | describe pipe-passthrough=true ( i.e describe with existing query response )  [ default false ]

@penghuo @mengweieric please review and comment

column_pattern is good to have, may not be required for phase 1 release

not necessary. if we consider DML. we could loose this limitation. I prefer add option 4, but remove source=
describe <index> | where type_name="date" | fields column_name

if we could allow the first cmd to be describe, I prefer option 4, as any cmd that works with search could potentially also work with describe. However, a lot of cmds only make sense for search queries, so supporting all of them for describe might be an overkill.

You'd want to support anything that you get for free.  Many commands would work out of the box because the describe command returns in a table format.

Need feedback to decide what response format to use for PPL describe.
Currently all SQL responses are formatted by JdbcResponseFormatter (by default), while all PPL responses are formatted by SimpleJsonResponseFormatter (by default). This is what caused the mismatch in their responses for the DESCRIBE cmd.
The options are:

Change protocol for PPL so that describe response matches that of SQL (both use Jdbc)
Allow the mismatch

Relevant lines:

https://github.com/opensearch-project/sql/blob/127b6627f380272da48c21705224802d1b717862/legacy/src/main/java/org/opensearch/sql/legacy/plugin/RestSQLQueryAction.java#L164
https://github.com/opensearch-project/sql/blob/127b6627f380272da48c21705224802d1b717862/plugin/src/main/java/org/opensearch/sql/plugin/rest/RestPPLQueryAction.java#L208

Personally leaning towards option 2

PPL does not intend to support JDBC. The difference is only schema type, string is more make sense. By the way, most of columns is meaningless. I suppose frontend only care about COLUMN_NAME, DATA_TYPE.


Single phase problem and calcium summation in control

All Submissions:

[ ] Have you followed the guidelines in our Contributing document [docs/contribution.md]?
[ ] Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
[ ] Have you opened/linked the issue related to your pull request?
[ ] Have you used the tag [WIP] for ongoing changes, and removed it when the pull request was ready?
[ ] When ready to merge, have you sent a comment pinging @Kev1CO in it?

New Feature Submissions:

[ ] Does your submission pass the tests (if not please explain why this is intended)?
[ ] Did you write a proper documentation (docstrings and ReadMe)
[ ] Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new examples for your core changes, as applicable?
[ ] Have you written new tests for your core changes, as applicable?

This change is

cocofest/examples/getting_started/pulse_intensity_optimization.py line 17 at r1 (raw file):
Previously, Ipuch (Pierre Puchaud) wrote…
Think the interface twice.

Done. Removed n_shooting option to automaticaly calculate it based on final time and stimulation instant


Automator: update<EMAIL_ADDRESS>dependency in<EMAIL_ADDRESS>

Generated by Automator - 2022-11-07T18:39:08+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.16
7843e1824f294e35d940a022af064d83ef00ca75
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.16
7843e1824f294e35d940a022af064d83ef00ca75
link
true
/test lint

unit-tests-arm64_istio_release-1.16
7843e1824f294e35d940a022af064d83ef00ca75
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Update README.md

Thanks!

welcome :) i know it’s a small thing but thought on the readme it would be better to have it all straight!


NETOBSERV-1091: remove CO-RE file and extensions as that causes douple allocations

it was noticed cpu and memory are higher than 1.2 release
that change was triggered by #110
it seems using co-re results in a significant memory and cpu increase https://github.com/libbpf/libbpf/issues/697 is opened against libbpf to track this, issue has been seen even with latest version of the lib, we don't use CO-RE apis at all so for now we will remove it and once we have libbpf fix we will re-enable
diag on left side with this PR changes the diag on right is with 1.3 baseline

/ok-to-test

https://github.com/libbpf/libbpf/issues/697

I'm fine to merge it and also backport on 1.3
@msherif1234 can you open the backport PR as well ?

I'm fine to merge it and also backport on 1.3 @msherif1234 can you open the backport PR as well ?

I linked the issue as well as the PR that trigger this in the PR description shouldn't that be enough ?

/lgtm

/approve
muchas gracias @msherif1234 !!!


Fixed 403 Errors and Dockerfile

YoutubeDL is out of date. The latest yt_dlp works with current codebase. I made the changes and was able to create an updated Docker image that works. I no longer get any errors from YouTube-dl

I hope @LaurenceRawlings you still maintain this project. Would it be possible to merge this since Savify is currently unusable?

I hope @LaurenceRawlings you still maintain this project. Would it be possible to merge this since Savify is currently unusable?

Only @LaurenceRawlings has write access to this repo I believe. I am unable to perform the pull request

I got frustrated and moved on to https://github.com/spotDL/spotify-downloader
It works very well too!


observing check/uncheck

Hi Kartik,
Are there any plans to observe message selections/checkboxes?
Or is there another way I can build a list of message IDs that are currently selected?
Many thanks,
Ian

This issue has been inactive for over 2 years, so assuming dead. Besides, the question was answered.
Closing.


Better info for using options

Hi!
I use this and found it useful, but I'd need to use some option to delay it so it wouldn't take the first click which opens the menu (which uses this to close itself). I found there is delayClickOutsideInit, but I have absolutely no idea where this option goes in my code and found no answers. Can you improve your readme file so that it tells where it should go?

Alright, I found out that it needs to go to my element in html file like this:

,but better info for other rookies would be good 👍

Alright, I found out that it needs to go to my element in html file like this:

,but better info for other rookies would be good 👍

It's assumed that Angular developers already know how to use directives, but I'll just answer questions as needed instead of having overly verbose documentation. :)

Another problem. When I'm running unit tests I get this error message:
Error: Template parse errors:     Can't bind to 'delayClickOutsideInit' since it isn't a known property of 'div'. ("

][delayClickOutsideInit]="true" (cli ck)="hideMenu()">.
Am I missing something in my spec file or?


Time to release your excellent code

Nice work for stylized motion analysis! I am just wondering when you will release your code. Can't to wait. lol.

Thank you for waiting. The codes have been uploaded. Wishing you success with your task ahead!

Thx! So efficient! Looking forward to your next wonderful job!


Bug report: 'm365 spo serviceprincipal grant revoke' deletes all the granted permissions for the resource

Priority
(Medium) I'm annoyed but I'll live
Description
I had approximately 20 permissions granted for the Microsoft Graph resource. My intention was to remove a specific permission using the m365 spo serviceprincipal grant revoke --id {ObjectId} command. However, it removed all 20 permissions instead. I believe this could be a misunderstanding, as the command requires the ObjectId as a parameter, and all permissions for the specific resource have the same ObjectId (I noticed it only while reproducing the bug). Therefore, it may not necessarily be a bug, but rather a misunderstanding in how the command is understood and used, particularly when combined with the m365 spo serviceprincipal grant list command. Nevertheless, considering that I have granted a specific permission to a resource, I should be able to delete only that particular permission.
Steps to reproduce

Login to CLI
Grant service principal permissions using the below:

m365 spo serviceprincipal grant add --resource 'Microsoft Graph' --scope 'User.Read.All'
m365 spo serviceprincipal grant add --resource 'Microsoft Graph' --scope 'Mail.Read'

List permissions and pick up the ObjectId for Mail.Read

m365 spo serviceprincipal grant list

Revoke permission

m365 spo serviceprincipal grant revoke --id I6-sC-jI3Uu37C1NtmZqA0SVQmWC1_RCvP7NnEv1Zus
Expected results
It should remove only the Mail.Read permission from the Microsoft Graph resource
Actual results
It removes both the scopes User.Read.All and Mail.Read from Microsoft Graph resource.
Diagnostics
debug.txt
CLI for Microsoft 365 version
v6.9.0
nodejs version
v18.16.0
Operating system (environment)
Windows
Shell
PowerShell
cli doctor
clidoctor.txt
Additional Info
No response

Nice catch @Saurabh7019, from my point of view this is indeed not what people would expect.
Looking at the permissions granted to my tenant, all permissions of the same resource indeed have the same ObjectId which is very unfortunate.
We could add an optional option scope where you can define the scope. Any other ideas @pnp/cli-for-microsoft-365-maintainers ?

It's odd indeed. Isn't there's just one serviceprincipal? In for example spo serviceprincipal set, we don't ask for the objectId of that principal. We just discover it for the user. So why would we need an id property for the serviceprincipal here?
I'd say the id should indeed refer to the id of the grant. We could add an extra option though to revoke by scope. That would be a nice addition.

Nice find @Saurabh7019.

We could add an optional option scope where you can define the scope. Any other ideas

I agree that it would be a good improvement to add an additional option scope to resolve this annoyance.

I wonder if something has changed along the way. I can't imagine we've missed something so fundamental. Nonetheless, this is an obvious bug. Sorry for the bad experience @Saurabh7019. We should definitely add a required scope option.

I just had another look at it, and it seems that the current implementation works correctly, albeit not what you would assume.
When you retrieve grants using m365 spo sp grant list, you'll see a list similar to the following:
IsDomainIsolated  ObjectId                                     PackageName  Resource         ResourceId                            Scope
----------------  -------------------------------------------  -----------  ---------------  ------------------------------------  ---------
false             sBQBziklJ0KrwVyRV8C_9iymdHsnnLxDtlVzd4LmSmE  null         Microsoft Graph  7b74a62c-9c27-43bc-b655-737782e64a61  User.Read
false             sBQBziklJ0KrwVyRV8C_9iymdHsnnLxDtlVzd4LmSmE  null         Microsoft Graph  7b74a62c-9c27-43bc-b655-737782e64a61  Mail.Read

Notice, that despite the different scopes, the objectId for all grants is the same. So if m365 spo sp grant revoke only accepts the objectId, it makes sense that it will revoke all scopes associated with that grant.
That said, I agree that there should be an option to remove just one scope rather than the whole grant. That's however a new feature rather than a bug. Let's create a new issue for it.


marker was not found on big images

Expected Behavior
i want to resize my image
Current Behavior
when I try to do anything with big images I get this error
Failure Information (for bugs)
E:\Server\Server.js:118
if (err) throw err;
^
Error: marker was not found
at decodeScan (E:\Server\node_modules\jpeg-js\lib\decoder.js:324:15)
at Object.parse (E:\Server\node_modules\jpeg-js\lib\decoder.js:744:29)
at Object.decode [as image/jpeg] (E:\Server\node_modules\jpeg-js\lib\decoder.js:983:11)
at Jimp.parseBitmap (E:\Server\node_modules@jimp\core\dist\utils\image-bitmap.js:117:53)
at Jimp.parseBitmap (E:\Server\node_modules@jimp\core\dist\index.js:498:32)
at E:\Server\node_modules@jimp\core\dist\index.js:440:15
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:447:3)
Steps to Reproduce
newname = path to file
Jimp.read(newname, (err, lenna) => {
if (err) throw err;
lenna
.resize(1024, Jimp.AUTO) // resize
//.quality(60) // set JPEG quality
//.greyscale() // set greyscale
.write(newname); // save
});
here are the pictures I used

Screenshots

Context

Jimp Version:5.6
Operating System: windows server 2012 R2 Standerd
Node version: 6.11.3

Failure Logs

Can I get your test image?
On Thu, Nov 8, 2018 at 11:53 AM hershyheilpern<EMAIL_ADDRESS>wrote:

Expected Behavior
i want to resize my image
Current Behavior
when I try to do anything with big images I get this error
Failure Information (for bugs)
E:\Server\Server.js:118
if (err) throw err;
^
Error: marker was not found
at decodeScan (E:\Server\node_modules\jpeg-js\lib\decoder.js:324:15)
at Object.parse (E:\Server\node_modules\jpeg-js\lib\decoder.js:744:29)
at Object.decode [as image/jpeg]
(E:\Server\node_modules\jpeg-js\lib\decoder.js:983:11)
at Jimp.parseBitmap (E:\Server\node_modules@jimp
\core\dist\utils\image-bitmap.js:117:53)
at Jimp.parseBitmap (E:\Server\node_modules@jimp
\core\dist\index.js:498:32)
at E:\Server\node_modules@jimp\core\dist\index.js:440:15
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:447:3)
Steps to Reproduce
newname = path to file
Jimp.read(newname, (err, lenna) => {
if (err) throw err;
lenna
.resize(1024, Jimp.AUTO) // resize
//.quality(60) // set JPEG quality
//.greyscale() // set greyscale
.write(newname); // save
});
here are the pictures I used
[image: occu-lux-250-jb-bo-a]
https://user-images.githubusercontent.com/12531645/48223271-accab280-e364-11e8-8268-92b1a69eb026.jpg
[image: arthur_ hi_res]
https://user-images.githubusercontent.com/12531645/48223272-accab280-e364-11e8-85e7-583626648486.jpg
Screenshots
Context

Jimp Version:5.6
Operating System: windows server 2012 R2 Standerd
Node version: 6.11.3

Failure Logs
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/oliver-moran/jimp/issues/654, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIyBCHtFKwlAq44tZh9QvIloA0nJidyks5utIvUgaJpZM4YVX0l
.

the 2 images that i posted on top

Sorry didn’t show up in the email
On Thu, Nov 8, 2018 at 12:41 PM hershyheilpern<EMAIL_ADDRESS>wrote:

the 2 images that i posted on top
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/oliver-moran/jimp/issues/654#issuecomment-437148264,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIyBBClIppQXHbuDAf_zqoDaNbCBn2Dks5utJcPgaJpZM4YVX0l
.

http://1hclouds.com/temp/OCCU-LUX-250-JB-BO-A.jpg
http://1hclouds.com/temp/Arthur_(hi_res).jpg

did you find anything

I'm with same problem...please fix this...

I am still facing this issue Error: marker was not found


Add set-project-id function.

Add set-project-id function that sets project-id setter and cnrm.cloud.google.com/project-id annotation on Config Connector resources to the provided project ID, if they have not been set already.

CI is failing. Please update the expected diff.patch


feat: identity sync

Issue being fixed or feature implemented

Sync identities for a mnemonic
What was done?

Added new class to mahage synced identities
How Has This Been Tested?

Not yet
Breaking Changes

None
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

Duplicates #80, https://github.com/dashevo/wallet-lib/pull/142


[ASCII-2461] Fix flaky TestRunProviders

What does this PR do?
Update TestRunProviders to fix a race condition.
Still check that providers are started, and that we don't wait for them forever.
Motivation
Not have a race.
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

/merge


[Docs] Make Contributors Guideline

Feature :rocket:
Objective :pushpin:
To create Contributors Guideline to help new Contributors get started with this Project.
Features to be added / modified :ballot_box_with_check:

Add a CONTRIBUTING.md to allow new users to get started with knowing how to contribute.
Add Screenshots wherever possible.
Mention the way to set the project locally in the PC
Add the basic information about creating Issues, Pull Requests and Branching.
Mention tutorials related to Git and GitHub to help them better understand.

/assign


Not working here either for the past week, maybe a bit longer.

Not working here either for the past week, maybe a bit longer.

Thanks for hanging in there, I am working on it. The API that provides the data changed its format.

@Phando Temporary Fix - > https://github.com/Phando/Streamdeck-Stonks/pull/37

Thanks! Didn't work though.

How did you try it? I haven't done a release, just creating a PR.

Oh? I downloaded from github manually and installed the latest available version you uploaded 3 hours ago?

Nope, that was created by @Phando. I'm waiting for him to review it and create a new one.

@TheSimArchitect Could you please download the fix from here and let me know if it works ?

Yes, it does! Thanks!!

Thank you all for looking into this and for the PR.
I am going to do a little testing and run with the v6 changes if all looks good.
V10 looks promising and has a way better return than v6 and v7, but it only allows for single quotes per request. It would cool to run with that, but I think we will hit API limits.
@TheSimArchitect What will fix the currency issue you are seeing?

Thanks @Phando !
As you can see the charts for fiat currencies are flat and the values won't update during non business hours and weekends (it never worked).
It's funny because it's not even the minute chart, but the 5 days and one month ones (yearly shows up), which should have the information visible doesn't, as you can see, the entire chart is wiped and you only get the "last quote" (from whenever it is) and a horizontal line.

Can you give v1.1.14 a try, if this doesn't work I will move to the v6 API.


use POST instead of GET for executing flow

because GET has url length limitation, this will cause problem when we have a large flow, and we disable a lot of the job inside, as the disabled jobs list will need to be included in the request param.

Pull Request Test Coverage Report for Build 5365

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 40.784%

Totals

Change from base Build 5357:
0.003%

Covered Lines:
13210

Relevant Lines:
32390

💛  - Coveralls

Updated the documentation as well.

Hi @wilson-lauw,
So sorry for the delays!
Could you please update the curl example in the documentation here to use the POST HTTP method instead?
Also, could you please resolve the conflicts to merge this PR? I'm not sure why commit https://github.com/azkaban/azkaban/pull/2560/commits/6126379ef6386a630aa9068e9b652810ebeddd2e which belongs to PR #2549 is showing up in this PR.

let me check on that, seems like someone force push on the master branch on the main repo causing that commit to be gone from the master branch

I recreated the PR here: https://github.com/azkaban/azkaban/pull/2613


Import @slack/types using the npm: specifier

Type of change

[ ] New sample
[x] New feature
[ ] Bug fix
[ ] Documentation

Summary
This PR uses the npm: specifier to import definitions directly from @slack/types instead of with a CDN.
This feature was added to Deno in 1.28 and is supported by our minimum required Deno version of 1.31.1. More info here<EMAIL_ADDRESS>Requirements

[x] I’ve checked my submission against the Samples Checklist to ensure it complies with all standards
[x] I have ensured the changes I am contributing align with existing patterns and have tested and linted my code
[x] I've read and agree to the Code of Conduct

@misscoded thank you for the review!


Absolute paths in cache

When deploying to, say heroku, you'll get a different temporary path on every deploy. And although you can carry over the .happypack cache we won't be able to use it because the paths are absolute.
Would you be open to changing that to make it relative to the root?

Caching has been removed in v4 so this issue isn't applicable anymore. Is there a reason you can't use the latest version?

I think v4 is in beta? Also caching was removed? Why? That's the major reason we use happy pack, concurrency is nice to have for initial cold cache builds but that doesn't happen often

v4 is out of beta since 8ef785245159bcefa9e394ee5eddc0e584796933 (about 3 months ago.)
Re caching, see https://github.com/amireh/happypack/issues/154#issuecomment-305627697.


Cannot set different schema on database config

Laravel Version: 7.27.0
PHP Version: 7.3
Database Driver & Version: sqlsrv 5.8

Description:
Cannot set different schema on database config
Steps To Reproduce:
set 'schema' => env('DB_SCHEMA', 'dbo') on config
and test the connection with a model query

schema option is  not available for SQL Server, only for Postgres
Also I don't think PDO's DSN for SQL Server supports specifying a schema:
https://docs.microsoft.com/en-us/sql/connect/php/connection-options?view=sql-server-ver15
But, you can specify the schema during a query:
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Route;

Route::get('/test', function () {
    return DB::table('INFORMATION_SCHEMA.COLUMNS')->get();
});

Or in a eloquent model's $table attribute:
<?php

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Route;

class Column extends Model
{
    protected $table = 'INFORMATION_SCHEMA.COLUMNS';
}

Route::get('/test', function () {
    return Column::all();
});

See above.

Thank you @rodrigopedra. I have added the schema on $table attribute

You're welcome! Great you got it working. Have a nice day .


when CONFIG_BT_SETTINGS is enabled, stack stores id in flash memory each power up of device (call to bt_enable)

Describe the bug
BT settings commit procedure calls bt_settings_save_id each bt_enable at power up:
	if (!atomic_test_bit(bt_dev.flags, BT_DEV_PRESET_ID)) {
		BT_WARN("commit");
		bt_settings_save_id();
	}

As far as I found the commit proceudre is registered as static handler for settings and is triggered by settings driver after load finishes.
BT_DEV_PRESET_ID bit is set by bt_init() if CONFIG_BT_SETTINGS is enabled.
To Reproduce
Steps to reproduce the behavior:

Run a sample that uses CONFIG_BT_SETTINGS (e.g. nRF Desktop) that uses BLE and check if save_id is called by BT settings commit.

Expected behavior
BT init should not store id if ID were already stored.
Impact
May decrease lifetime of flash memory if device goest to power down mode very often.
Block execution system work queue for long time because of use of flash write operation.
Can't run very high frequecy task in a work queue when BT settings are loading.

CC @nvlsianpu @jhedberg @Vudentz

If you look at the bt_settings_save_id() function in  subsys/bluetooth/host/settings.c you'll see that the storing to flash is done through the system workqueue, meaning the ID creation functions should return immediately. This is intentionally designed this way so that you can call bt_id_create() multiple times in a loop, and only when a context switch occurs will the identities be stored into flash. So I'm not sure what the problem is - perhaps I'm misunderstanding your description.

I apologize for wrong description. It've updated the comment - update section of Description

The question here is: if store of that id - by bt_settings_save_id is required each time I call bt_enable on power up? Even the device has already stored some ids in settings?

Hi @dleach02 it does not look low as it will cause FLASH memory degradation. This will especially impact devices that reboot frequently (e.g. use off mode for power saving) and have small settings partition.
Hi @aescolar , even if the write operation occurs in workqueue it will cause system block for 10s of milliseconds during each reboot. Not at the ble initialization but at the first thing that will require system workqueue to be available.
Hi @nvlsianpu , would it be possible to create some async mechanism for writing to storage? Something that would not require blocking threads during it? Is there a way for HW to notify that operation is done (so we don't have actively wait for it)?

@ppryga - Are you sure that write to the flash really occurring? Normal settings check storage content and avoid write of duplicates (although it reads storage while searching for similar key-value).
@pdunaj - first we have to make settings multi-threading safe, other problem is that at the lowest level the flash driver is just blocking API now.

Expected behavior
BT init should not store id if ID were already stored.

@ppryga thanks for clarifying - it is indeed a bug if data that was just read from flash upon Bluetooth init gets written back to flash. That's something we actively detect and prevent for all other types of data we store in flash.

@nvlsianpu Yes I'm sure.
This part of code from bt_init sets the flag  BT_DEV_PRESET_ID
	if (IS_ENABLED(CONFIG_BT_SETTINGS)) {
		if (!bt_dev.id_count) {
			BT_WARN("No ID address. App must call settings_load()");
			return 0;
		}

		atomic_set_bit(bt_dev.flags, BT_DEV_PRESET_ID);
	}

This part of commit (settings.c) triggers save settings:
        if (!atomic_test_bit(bt_dev.flags, BT_DEV_PRESET_ID)) {
		BT_WARN("commit, bt_def.flags: %x", bt_dev.flags);
		bt_settings_save_id();
	}

And be_settings_save_id triggers work responsible for settings store:
void bt_settings_save_id(void)
{
	k_work_submit(&save_id_work);
}

And save_id does store operation unconditioanlly:
static void save_id(struct k_work *work)
{
	int err;
	BT_INFO("Saving ID");
	err = settings_save_one("bt/id", &bt_dev.id_addr,
				ID_DATA_LEN(bt_dev.id_addr));
	if (err) {
		BT_ERR("Failed to save ID (err %d)", err);
	}

#if defined(CONFIG_BT_PRIVACY)
	err = settings_save_one("bt/irk", bt_dev.irk, ID_DATA_LEN(bt_dev.irk));
	if (err) {
		BT_ERR("Failed to save IRK (err %d)", err);
	}
#endif
	BT_INFO("Saving ID Done");
}

I can confirm the reported bug. I don't understand the reason that the commit calls a 'save, I think it should be the bt_id_create() that calls the save`.

Or maybe the save should be called only when there was no bt_dev.id_count in the commit routine.

BT_DEV_PRESET_ID bit causes that 'bt/id` key is not loaded from the storage and bt_dev.id_count is never assign. so bt_dev.id_count keep 0 values, which causes generation of new ID and attempt to write it to the settings storage. somehow new ID must be always different than the old one...
What BT_DEV_PRESET_ID flag suppose to do?

What BT_DEV_PRESET_ID flag suppose to do?

It's supposed to track whether the application explicitly created identities before calling bt_enable() in which case those identities take precedence over anything that might be stored in flash.
The code in the commit() function looks buggy to me - it seems it was introduced by commit 2b84c726c8893eaaa1bf26dfddf2798b159cd47d so I hope @joerchan can provide some clarity on this. It seems to me like we should be tracking through the set() callback if any identities were stored in flash, and if so not try re-write them to flash through commit(). It looks like the existing code was put there for the use case bt_enable(); .. create identities; settings_load(); in which case we do want to store those in flash through commit(), however it doesn't consider the simpler (and probably more common) case of bt_enable(); settings_load(); when flash already contains identities.

@jhedberg Thank you for the analysis. I will check if I can solve the problem.
The reason why I added it is for the simple scenario where the application does not create any identities at all. In this case the Host will read an identity address and generate an identity resolving key (IRK). And it is the generation of the IRK that is the problem since it is not stored in flash.
This resulted in the IRK being generated on every power-up and the privacy feature is then completely broken.

So, I investigated the issue - write to the storage is requested (nvs_write() ) but is not executed in fact as NVS discard duplicates writes (other settings back-end filter duplicates on higher level).
So increase of wear leveling is not an issue.

@ppryga >
Block execution system work queue for long time is in fact due to fact that storage is scanned for settings record duplicates.
Impact
May decrease lifetime of flash memory if device goes to power down mode very often.
Block execution system work queue for long time because of use of flash read operations for searching entire storage for a settings duplicate .
Can't run very high frequecy task in a work queue when BT settings are loading.

@joakimtoe  From conversation above I see that if  BT_DEV_PRESET_ID flag is set basically writing of bt/id and bt/irk settings records should be disabled.

@joakimtoe From conversation above I see that if BT_DEV_PRESET_ID flag is set basically writing of bt/id and bt/irk settings records should be disabled.

Wrong Joakim, @joerchan maybe?

So, I investigated the issue - write to the storage is requested (nvs_write() ) but is not executed in fact as NVS discard duplicates writes (other settings back-end filter duplicates on higher level).
So increase of wear leveling is not an issue.

Thank you @nvlsianpu that is good to hear that flash wear is not an issue. I`m working an fix that would prevent the attempted write when no new IDs has been generated. On nRF devices we shouldn't have to generate an IRK at all.

@nvlsianpu Is the conclusion correct that there is no flash wear? Maybe so for the bt/id and bt/irk flags, but bt/hash gets rewritten always. An excerpt from my storage memory of a device resetting multiple times:
0x0007B000: C0FFEEEE 0007FF01 2F746218 68736168   |.........bt/hash|
0x0007B010: 9243D53D 3B7FBAD2 2DD486F0 2AD9F5CC   |=.C....;...-...*|
0x0007B020: 6218905A 61682F74 003D6873 00000000   |Z..bt/hash=.....|
0x0007B030: 00000000 00000000 EF000000 2F746218   |.............bt/|
0x0007B040: 68736168 9243D53D 3B7FBAD2 2DD486F0   |hash=.C....;...-|
0x0007B050: 2AD9F5CC 6218905A 61682F74 003D6873   |...*Z..bt/hash=.|
0x0007B060: 00000000 00000000 00000000 EF000000   |................|
0x0007B070: 2F746218 68736168 9243D53D 3B7FBAD2   |.bt/hash=.C....;|
0x0007B080: 2DD486F0 2AD9F5CC 6218905A 61682F74   |...-...*Z..bt/ha|
0x0007B090: 003D6873 00000000 00000000 00000000   |sh=.............|
0x0007B0A0: EF000000 2F746218 68736168 9243D53D   |.....bt/hash=.C.|
0x0007B0B0: 3B7FBAD2 2DD486F0 2AD9F5CC 6218905A   |...;...-...*Z..b|
0x0007B0C0: 61682F74 003D6873 00000000 00000000   |t/hash=.........|
0x0007B0D0: 00000000 EF000000 2F746218 68736168   |.........bt/hash|
0x0007B0E0: 9243D53D 3B7FBAD2 2DD486F0 2AD9F5CC   |=.C....;...-...*|
0x0007B0F0: 6218905A 61682F74 003D6873 00000000   |Z..bt/hash=.....|
0x0007B100: 00000000 00000000 EF000000 2F746218   |.............bt/|
0x0007B110: 68736168 9243D53D 3B7FBAD2 2DD486F0   |hash=.C....;...-|
0x0007B120: 2AD9F5CC 6218905A 61682F74 003D6873   |...*Z..bt/hash=.|
0x0007B130: 00000000 00000000 00000000 EF000000   |................|
0x0007B140: 2F746218 68736168 9243D53D 3B7FBAD2   |.bt/hash=.C....;|
0x0007B150: 2DD486F0 2AD9F5CC 6218905A 61682F74   |...-...*Z..bt/ha|
0x0007B160: 003D6873 00000000 00000000 00000000   |sh=.............|
0x0007B170: EF000000 2F746218 68736168 9243D53D   |.....bt/hash=.C.|
0x0007B180: 3B7FBAD2 2DD486F0 2AD9F5CC 6218905A   |...;...-...*Z..b|
0x0007B190: 61682F74 003D6873 00000000 00000000   |t/hash=.........|
0x0007B1A0: 00000000 EF000000 2F746218 68736168   |.........bt/hash|
0x0007B1B0: 9243D53D 3B7FBAD2 2DD486F0 2AD9F5CC   |=.C....;...-...*|
0x0007B1C0: 6218905A 61682F74 003D6873 00000000   |Z..bt/hash=.....|
0x0007B1D0: 00000000 00000000 EF000000 2F746218   |.............bt/|
0x0007B1E0: 68736168 9243D53D 3B7FBAD2 2DD486F0   |hash=.C....;...-|
0x0007B1F0: 2AD9F5CC 6218905A 61682F74 003D6873   |...*Z..bt/hash=.|
0x0007B200: 00000000 00000000 00000000 EF000000   |................|
0x0007B210: 2F746218 68736168 9243D53D 3B7FBAD2   |.bt/hash=.C....;|

@mfiumara It seems to alternate between the same value and zero. Is it deleted by the application at one point perhaps?

@joerchan I just checked again and can explain what is happening in my flash storage partition. I'm calling settings_load in my bt_ready callback, which results in a db_hash_store with hash=0x00000. After this, somewhere db_hash_gen is triggered, which generates the proper hash and stores it again to the flash. Whenever I reset the same happens, which causes the switching of hashes.

The original issue I believe has been fixed by #21217
If anybody disagrees please re-open the issue.
The issue about flash wear on the bt/hash setting has been moved to it's own issue: #22730


Error on composer update after dingo/blueprint 0.4.6 update

Q
A

Bug?
yes

New Feature?
no

Framework
Laravel

Framework version
9.40.1

Package version
4.0.2 (and 4.1.0)

PHP version
8.1.7

OS
Windows 8.1 and Debian AWS EC2 (EBS)

Actual Behaviour
I had an error when doing a composer update :
This seems to be caused by the recent (14/05/2023)  dingo\blueprint 0.4.6 update, required by api-ecosystem-for-laravel (as "dingo/blueprint": "^0.4.5").
[previous exception] [object] (ReflectionException(code: -1): Class \"Doctrine\\Common\\Annotations\\SimpleAnnotationReader\" does not exist at C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php:889)
[stacktrace]
#0 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(889): ReflectionClass->__construct('Doctrine\\\\Common...')
#1 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(770): Illuminate\\Container\\Container->build('Doctrine\\\\Common...')
#2 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php(856): Illuminate\\Container\\Container->resolve('Doctrine\\\\Common...', Array, true)
#3 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(706): Illuminate\\Foundation\\Application->resolve('Doctrine\\\\Common...', Array)
#4 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php(841): Illuminate\\Container\\Container->make('Doctrine\\\\Common...', Array)
#5 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(1043): Illuminate\\Foundation\\Application->make('Doctrine\\\\Common...')
#6 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(959): Illuminate\\Container\\Container->resolveClass(Object(ReflectionParameter))
#7 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(920): Illuminate\\Container\\Container->resolveDependencies(Array)
#8 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(770): Illuminate\\Container\\Container->build('Dingo\\\\Blueprint...')
#9 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php(856): Illuminate\\Container\\Container->resolve('Dingo\\\\Blueprint...', Array, true)
#10 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(706): Illuminate\\Foundation\\Application->resolve('Dingo\\\\Blueprint...', Array)
#11 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php(841): Illuminate\\Container\\Container->make('Dingo\\\\Blueprint...', Array)
#12 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(1431): Illuminate\\Foundation\\Application->make('Dingo\\\\Blueprint...')
-> #13 C:\\laravel-app\\vendor\\api-ecosystem-for-laravel\\dingo-api\\src\\Provider\\DingoServiceProvider.php(182): Illuminate\\Container\\Container->offsetGet('Dingo\\\\Blueprint...')
#14 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(885): Dingo\\Api\\Provider\\DingoServiceProvider->Dingo\\Api\\Provider\\{closure}(Object(Illuminate\\Foundation\\Application), Array)
#15 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(770): Illuminate\\Container\\Container->build(Object(Closure))
#16 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php(856): Illuminate\\Container\\Container->resolve('Dingo\\\\Api\\\\Conso...', Array, true)
#17 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Container\\Container.php(706): Illuminate\\Foundation\\Application->resolve('Dingo\\\\Api\\\\Conso...', Array)
#18 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Application.php(841): Illuminate\\Container\\Container->make('Dingo\\\\Api\\\\Conso...', Array)
#19 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Console\\Application.php(280): Illuminate\\Foundation\\Application->make('Dingo\\\\Api\\\\Conso...')
#20 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Console\\Application.php(294): Illuminate\\Console\\Application->resolve('Dingo\\\\Api\\\\Conso...')
#21 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Support\\ServiceProvider.php(404): Illuminate\\Console\\Application->resolveCommands(Array)
#22 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Console\\Application.php(161): Illuminate\\Support\\ServiceProvider->Illuminate\\Support\\{closure}(Object(Illuminate\\Console\\Application))
#23 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Console\\Application.php(82): Illuminate\\Console\\Application->bootstrap()
#24 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Console\\Kernel.php(417): Illuminate\\Console\\Application->__construct(Object(Illuminate\\Foundation\\Application), Object(Illuminate\\Events\\Dispatcher), '9.52.7')
#25 C:\\laravel-app\\vendor\\laravel\\framework\\src\\Illuminate\\Foundation\\Console\\Kernel.php(155): Illuminate\\Foundation\\Console\\Kernel->getArtisan()
#26 C:\\laravel-app\\artisan(37): Illuminate\\Foundation\\Console\\Kernel->handle(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))
#27 {main}

Possible Solutions
Switch back to the previous dingo\blueprint version, adding to your composer.json: "dingo/blueprint": "0.4.5"
Should I report this to dingo\blueprint ? This issue may be related.

Having the same issue. Laravel 10.10.1
Looks like the problem is that SimpleAnnotationReader was dropped in doctrine/annotations 2.0 (https://github.com/doctrine/annotations/issues/232), but dingo/blueprint is still using it (https://github.com/dingo/blueprint/blob/master/src/Blueprint.php#LL53C1-L53C1)

I have the same problem here. I update version 9 to 10 of Laravel.
The solution "adding to your composer.json: "dingo/blueprint": "0.4.5"" doesn't work because still install the version 0.4.6... :/

@TSerra-PT are you sure that you don't have another package requiring dingo/blueprint? Adding the strict 0.4.5 version should work after a composer update.

@mtx-z  In composer.json i have the version 0.4.5, but it install the 0.46.... :/

I'm double checking but are you sure you're doing a "composer update"? As composer install may install 0.4.6 from lock.

@mtx-z yes...

Strange. You can try delete lock file (and vendor?) then composer install again. It worked from my end.

I can confirm this issue, the update for blueprint latest (0.4.6) isn't enough, because not only should doctrine/annotations be updated to 2, but I think the code needs to also be updated.
I will comment out the registration of the blueprint cli command for the time being and tag as a bugfix, until it's resolved in blueprint.
If anyone is using the blueprint package, please take a look at it - personally I have not been using it.

Tagged as v4.1.1 - but I'll keep this open as an ongoing issue, especially if anyone encounters it they can check here.

@mtx-z delete lock file and vendor did the trick. thanks!

Another solution is it to lock "doctrine/annotations" in tag 1.14.3, the latest version before 2.0 was published. Because of the composer.json in
<EMAIL_ADDRESS>requires "doctrine/annotations": "~1.2 ",
while
<EMAIL_ADDRESS>requires "doctrine/annotations": "~1.2 | ^2.0".
is what created this issue.
Locking  "doctrine/annotations": "v1.14.3" in the composer.json file, delete the lock file and a composer update did the trick.

^ With above, keep in mind that v1 of doctrine/annotations doesn't support PHP 8, hence why that dep was updated in the first place.


ARM template for Azure app configuration not considering SKU Free/Standard.

Referring to https://docs.microsoft.com/en-us/azure/templates/microsoft.appconfiguration/2019-10-01/configurationstores.
I'm providing Free/Standard but resource SKU didn't get changed as per the value provided in ARM.
Can somebody help me out with this asap?
{   "name": "string",   "type": "Microsoft.AppConfiguration/configurationStores",   "apiVersion": "2019-10-01",   "location": "string",   "tags": {},   "identity": {     "type": "string",     "userAssignedIdentities": {}   },   "properties": {},   "sku": {     "name": "string"   } }
Awaiting response.

@kaushik-hemant not sure I get the question. The value of "sku" can be either "free" or "standard", but this may not be your question. Can you please clarify?

@zhenlan The template specified above is not creating the resource as per the value specified in "SKU" property, It'll create a free tier despite Standard in value. And there is no update from Free to Standard if provided Standard and existing one is on Free.

@kaushik-hemant if I understand correctly, you are talking about two issues. Can you please confirm?

You cannot create a Standard SKU App Configuration store with ARM template even if you specify "standard" in the sku parameter. You always get a Free SKU store. Can you please share your ARM template?
You cannot upgrade a Free SKU App Configuration store to Standard SKU with ARM template. Did you get any error?

@zhenlan Yes, for 2, there is no error in response but tier remains unchanged.

we had the exact same thing happen on a customer install...we only discovered the issue AFTER we hit the free tier quota restrictions :/ we found no errors in the ARM output to indicate something went wrong.....only that the new standard SKU was NOT applied

Thanks for the information. We are looking into this.

@kaushik-hemant  @wahyuen Could you share the template and steps that can repro the issue?
I'm unable to repro using below template.
{
"$schema": "https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#",
"contentVersion": "<IP_ADDRESS>",
"variables": {},
"resources": [
{
"name": "test-sku",
"type": "Microsoft.AppConfiguration/configurationStores",
"apiVersion": "2019-10-01",
"location": "westus",
"sku": {
"name": "free"
}
}
]
}

Use AZ CLI to provision with above template. The config store can be successfully provisioned and it's free tier.
Change free to standard in the template and rerun the AZ command. The config store can be changed to standard tier successfully.

If standard sku is specified in the first place, the config store can also be provisioned and it cannot be downgraded to free tier, which is by design.

Any update? If possible, please share the configuration store name and the time.
One possibility is that incorrect API version is used. Old API version '2019-02-01-preview' doesn't support the 'sku' property.

Perhaps that is the issue...it unfortunately does not seem to indicate any error when you run this, thus we had assumed it had worked. We'll update the API version in our templates to adjust.

Awesome! Below is a useful link that you can reference for API versions and their supported properties.
https://docs.microsoft.com/en-us/azure/templates/microsoft.appconfiguration/allversions


Add ChaCha20-Poly1305 cipher suites

This adds ChaCha20-Poly1305 TLS cipher suites to caniuse.com. This feature is part of #1144.
Spec: https://tools.ietf.org/html/draft-ietf-tls-chacha20-poly1305-04
This feature is supported in Chrome, Opera, and definitely not supported in IE or Edge. I am not sure about the support status on some platforms. To check if a browser supports this feature, visit https://www.ssllabs.com/ssltest/viewMyClient.html

Thanks!


GRID-287: Add dataSource.calculators array

👍
Hopefully this won't be too much to refactor in the near future when we add the simplied column object on the grid


unframework doesn't add all frameworks (ART only)

Affected module(s): getframeworks, unframework, frameworkdb. frameworkdexdb
On Lollipop with ART, the directory "/system/framework/" is not a definitive list of frameworks.  The "arm(64)?/" sub-directory has the "boot.oat" file, which will have the remaining frameworks.
As it is now, getframeworks will pull everything from "/system/framework/", and unframework is responsible for doing the extraction of the OAT files from "boot.oat", but it does this to the "unframework/" directory.
frameworkdb relies on the *.jar files in the "frameworks/" directory, but this isn't really a good approach, since things like "framework2" do not have a JAR for ART.
There needs to be a operation that actually makes changes to the "frameworks/" directory, much like sysappdb oatextract, or frameworkdb needs to have a better approach for generating it's listing.

Added: https://github.com/jakev/dtfmods-core/commit/82beaaefb5bec95d77b8b25f3d145b6b61332304