pythonPackages.ptyprocess: fix stuck tests on darwin

Motivation for this change
Not sure why ofborg doesn't check darwin.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 118948 at ec0e1f0e run on x86_64-linux 1

168 packages marked as broken and skipped:

agdaPackages.iowa-stdlib
apostrophe
aqemu
awsebcli
bareos
bonfire
cassandra_2_1
cassandra_2_2
couchdb
gnome3.gnome-documents
...

10484 packages skipped due to time constraints:

DisnixWebService
EBTKS
Fabric (python38Packages.Fabric)
R
abcl
acd-cli
acousticbrainz-client
actdiag (python38Packages.actdiag)
adafruit-ampy
adapta-gtk-theme
...

29 packages built successfully:

python38Packages.argon2_cffi
python38Packages.betamax
python38Packages.cachecontrol
python38Packages.chardet
python38Packages.factory_boy
python38Packages.faker
python38Packages.flask
python38Packages.flask_sqlalchemy
python38Packages.hypothesis
python38Packages.isort
python38Packages.pexpect
python38Packages.poetry-core
python38Packages.ptyprocess
python38Packages.pytest-localserver
python38Packages.pytest-timeout
python38Packages.requests
python38Packages.requests_download
python38Packages.responses
python38Packages.sphinx
python38Packages.terminado
python38Packages.validators
python38Packages.virtualenv
python38Packages.werkzeug
python39Packages.ipython
python39Packages.jupyter_core
python39Packages.pexpect
python39Packages.ptyprocess
python39Packages.pytest-timeout
python39Packages.terminado

1 suggestion:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?
Near pkgs/development/python-modules/ptyprocess/default.nix:24:3:
   |
24 |   meta = {
   |   ^

Result of nixpkgs-review pr 118948 run on x86_64-darwin 1

1 package built:

python3Packages.ptyprocess

Not sure why ofborg doesn't check darwin.

Because it has no or to little darwin builders and if everything is done except darwin it is ignored.


Prevent duplicate bottom sheet entry

Hi,
I liked to prevent wolt_modal_sheet not to open if there is another wolt modal sheet opened or the screen which requested the bottom sheet just destroyed/exited from navigation. Is there currently any feature for this?

@ribuemsyne this should be done in state management level. I am working on a comprehensive demo app. You can do the following:

Give a name to your modal sheet:

Get the current route name: https://stackoverflow.com/a/54962118

Check if it is wolt:modal_route


Japanese Translation - three items not displaying (Mac OS)

André, I had a look at the newest version (on my Mac) and three items are not showing translations in the menus (screenshots attached).
I think I provided translations for two of these items (emoji and full screen), but now see that I'm missing one for "Use System Date Format".  Here's the current code.
    "edit": {
        "title": "編集",
        "undo": "元に戻す",
        "redo": "やり直し",
        "paste": "ペースト",
        "cut": "カット",
        "copy": "コピー",
        "copy_image_link": "イメージのリンクをコピー",
        "copy_link": "リンクをコピー",
        "copy_image": "イメージをコピー",
        "select_all": "すべてを選択",
        "language": "言語 (Language)",
        "dateformat": "Use system date format"
    },
    "view": {
        "title": "表示",
        "emoji": "絵文字に変換",
        "hide_dock": "ドックのアイコンを隠す",
        "fullscreen": "全画面表示",

I'm happy to add a translation for Use system date format ("システムの日付形式を使用する") (it wasn't in template I used originally) -- should I edit, commit and a new Pull Request, or do you want to add it?
I don't know how to fix the emoji and full screen translations.
Happy to help... I'll follow your lead.
Thanks.
Jeff

suggest emoji on typing
I've updated the latest ja.json (and all other transalation files) to include the suggestemoji string.
Use system date format
Also updated that in all translation files
Fullscreen
This seems to be a bug of some sorts in Mac OSX, can you try other translations to see if the same string is also untranslatable?
Start dictation and Emoji & Symbols
This is something Mac OS X or the framework that we use does automatically... There is still no translation for these ones

if you want to finish the japanese translation, do the same steps as you did before to create the patch-1 branch
you just have to get the latest version from the Yakyak repository. This is usually done via a pull action
Then create patch-2 (or some other branch), perform the changes and then create another pull request :)

Got it.  But I have a question first...
I'm not sure how to deal with the two emoji commands... would you please confirm so I don't mess it up again?

Hi André.  I made the changes (in the online editor -- I can't figure out the pull action or how to upload files I edit offline) and, added the missing bits, and did a pull request.   Fingers crossed it works this time!

again great work!!


Feature/dynamic target

Coverage decreased (-1.1%) to 95.954% when pulling af8bd2d6152345c93477cc448cbbc7e723212cb2 on Cecil0o0:feature/dynamic-target into 80fc9e8c87120b1b2abe90a73cfdd5c7abc635a0 on chimurai:master.

Dynamic target is already possible with the router option.
https://github.com/chimurai/http-proxy-middleware/blob/master/recipes/router.md#router
Currently target is mandatory; so if you doesn't need the target, you can provide just some dummy value as target.


install_mt4-xdot.sh: fix installer's downloader

This should resolve the issues with the installer's downloader, but it still need the workaround for the download hanging. It appears to complete if the installer is exited through the GUI and then restarted multiple times until the download manages to finish. See #113.

I think build 383757121 it's stuck for an hour. Then 383757120 got problem with w2ksp4_en.exe (could be related to outdated winetricks?).

I'm still working on fixing the installer part. I'll review this again after that.


chore: npm 发布移除 src 目录

PR includes

[ ] fixed #0
[ ] add / modify test cases
[ ] documents, demos

Screenshot

Before
After

❌
✅


Lost custom annotations on parameterized methods

Hi, i've faced a problem with annotations on parameterized methods. Here is a test reproducing it.

@jrmichael can you look at this please?

@artkoshelev We are working on it now. I suppose that we deliver fix for the issue soon.

Hi @artkoshelev
We tried to implement it together with @woprzech
It turned out to be impossible with current version of JUnit. The only place to pass annotations is JUnits Description object. However it has all the constructors private and all the fields final. Since we have to pass uniqueMethodId and custom name, we cannot add annotations anymore. We are bound to use this method. We can of course use reflection to construct this object but it may have a significant performance impact.
Maybe you can describe us your use case for custom annotations and we can think of a workaround. Why do you need them? What is your goal? What are you building? etc.

I was writing mobile app tests with appium and allure frameworks when faced this issue. I use @Feature and @Story annotations on test methods to build nice reports with Allure framework. While searching for solution i tried to fix it in your code, but faced same limitations in JUnit. Since JUnit 4.x branch is no longer developing i don't think solution can be found except the hacky ones with bytecode modifications.
So, i ended up with standard JUnit parametrization for my task, despite the fact your solution is really cool to work with. But if you going to work with new JUnit (which was completely rewritten), that case is probably the one to keep in mind.

@artkoshelev We won't implement a fix for this issue as I described it before.
We think that you can still use JUnitParams and @Story / @Feature  annotations by adding them on classes instead of methods.


[BUG] CI failing for ubuntu + python3.6

Describe the bug
CI is failing for python3.6 on ubuntu-latest. This is because ubuntu-latest now uses ubuntu-22.04. This is somehow breaking the setting up of python3.6 which doesn't appear to be properly supported anymore. @Samyak2 should we revert to ubuntu-20.04 or remove support for python3.6 altogether?

IMO we should drop 3.6 since it has reached end-of-life. We should add 3.10 and 3.11 though.


chore: upgrade charts

updated chart jxgh/jx-kh-check from 0.0.79 to 0.0.80

All build are failing with this issue:
error building image: error building stage: failed to get files used from context: when specifying multiple sources in a COPY command, destination must be a directory and end in '/'

/retest


Create initial sass folder structure

The structure is a combination of ITCSS by Harry Roberts
and how NHSUK currently structures components and elements

👍


[model] Add formatted version properties

Given a project with version 12.3.0-SNAPSHOT and a snapshot label {{{{projectVersionNumber}}.EarlyAccess}} the following properties should become available
    extraProperties:
        # existing
        projectVersionMajor: 12
        projectVersionMinor: 3
        projectVersionPatch: 0
        projectVersionNumber: 12.3.0
        projectVersionTag: SNAPSHOT
        # new
        projectVersionWithUnderscores: 12_3_0_SNAPSHOT
        projectVersionWithDashes: 12-3-0-SNAPSHOT
        projectVersionNumberWithUnderscores: 12_3_0
        projectVersionNumberWithDashes: 12-3-0
        projectEffectiveVersionWithUnderscores: 12_3_0_EarlyAccess
        projectEffectiveVersionWithDashes: 12-3-0-EarlyAccess

Even though https://github.com/jreleaser/jreleaser/issues/311 adds f_underscore and f_dash I think keeping version number explicit key names is OK, considering how important the version number is.
{{projectVersionNumberWithDashes}} is equivalent to {{#f_dash}}{{projectVersionNumber}}{{/f_dash}}.


Does not work with DllReferencePlugin

Issue description
Getting following error message
Could't analyze webpack bundle:
TypeError: Cannot read property 'raw' of undefined
Could't find any javascript bundles in provided stats file

Technical info

Webpack Bundle Analyzer version: 2.3.1
Webpack version:2.2.1
Node.js version:v6.9.5
npm/yarn version: yarn 0.19.1
OS: Ubuntu

Debug info
How do you use this module? As CLI utility or as plugin?
Plugin
If CLI, what command was used? (e.g. webpack-bundle-analyzer -O path/to/stats.json)
If plugin, what options were provided? (e.g. new BundleAnalyzerPlugin({ analyzerMode: 'disabled', generateStatsFile: true }))
new BundleAnalyzerPlugin({
      analyzerMode: isProduction ? 'server': 'disabled',
      analyzerHost: '<IP_ADDRESS>', //I am using vagrant
      analyzerPort: 8888,
      generateStatsFile: false,
      openAnalyzer: false
 })

What other Webpack plugins were used?
    new webpack.NoEmitOnErrorsPlugin(),
    new webpack.HotModuleReplacementPlugin(),
    new webpack.NamedModulesPlugin(),
    new WebpackNotifier({
      alwaysNotify: false,
      title: 'Hello World',
      contentImage: root('src/assets/images/favicon.ico')
    }),
    new webpack.LoaderOptionsPlugin({
      debug: true
    }),
    new webpack.DefinePlugin({
      'process.env': {
        'ENV': JSON.stringify(ENV)
      }
    }),
    new webpack.DllReferencePlugin({
      context: root('src'),
      manifest: require('build/dll/vendor-manifest.json')
    }),
    new webpack.DllReferencePlugin({
      context: root('src'),
      manifest: require('build/dll/polyfill-manifest.json')
    })

Hmm this might be interesting. I've never tried DllReferencePlugin so it might be the one causing issues.
Are you able to get the stats successfully if you don't use it?

If I first genertate stats.json file using webpack cli and fed this file to webpack-bundle-analyzer cli , It seems working but cannot figure out why its not working via plugin.

Please try running your bundling without the webpack.DllReferencePlugin instances in your plugins array. It would help in debugging this :)

Yes, It works when omitting webpack.DllReferencePlugin from the plugins list and adding new BundleAnalyzerPlugin() instance to the plugins list.

Ok great! Could you modify the title of this issue to be this?

Does not work with DllReferencePlugin

This way the title would be a little less generic than just the analyze error.

Hiya @lekhnath, sorry for not getting back to you sooner.
Are you able to generate a stats.json file and zip it with your built files so we could try to reproduce your error? Alternatively, if you'd be able to whip up a reproduction repository for your issue, that would also be ace! 💞

@valscion Today I give it another try and surprised to see that there is no issue at all. It is working like a charm even with DllReferencePlugin. I've done lots of changes to my configuration and code in the meantime though. I would open a new issue with reproduction if it encountered again.
Thanks.

Ok, thanks for following up!

I am having issues with trying to get the AutoDLL plugin output to show up.

Please open a new issue @vjpr and fill the issue template


cannot install voyager using composer require

Laravel version
10.3
PHP version
8.2
Voyager version
1.6
Database
Na
Description
When I tried to install voyager using composer require tcg/voyager, it returns back to me below.
Problem 1
- Root composer.json requires tcg/voyager ^1.6 -> satisfiable by tcg/voyager[v1.6.0].
- tcg/voyager v1.6.0 requires illuminate/support ~8.0|~9.0 -> found illuminate/support[v8.0.0, ..., v8.83.27, v9.0.0, ..., v9.52.16] but these were not loaded, likely because it conflicts with another require.
You can also try re-running composer require with an explicit version constraint, e.g. "composer require tcg/voyager:*" to figure out if any version is installable, or "composer require tcg/voyager:^2.1" if you know which you need.
Steps to reproduce
Running command composer require tcg/voyager
Expected behavior
Voyager installed successfully
Screenshots

Additional context
No response

I guess because as the doc says https://voyager-docs.devdojo.com/getting-started/prerequisites
it's only compatible with
Laravel 8
Laravel 9


feat(dsp): add transformer for JsonObjectToDataAddress

What this PR changes/adds
Adds a JsonObjectToDataAddressTransformer plus tests.
Why it does that
DataAddresses must be (JSON-LD)-type-aware, so we need a transformer for it.
Further notes
this PR is needed for #2767

I had to (re-)create the CoreConstants.java into the core-spi, because we need access to the EDC_NAMESPACE. This is already done in PR #2807, but that is not yet merged.

Linked Issue(s)
Needed for #2767
Needed for #2806
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[ ] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Codecov Report
Patch coverage: 76.19% and project coverage change: +0.07 :tada:

Comparison is base (e0717bd) 65.87% compared to head (4203745) 65.95%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2811      +/-   ##
==========================================
+ Coverage   65.87%   65.95%   +0.07%
==========================================
  Files         974      982       +8
  Lines       19770    19847      +77
  Branches     1168     1169       +1
==========================================
+ Hits        13024    13090      +66
- Misses       6278     6288      +10
- Partials      468      469       +1

Impacted Files
Coverage Δ

...nsformer/DspTransferProcessTransformExtension.java
0.00% <0.00%> (ø)

.../org/eclipse/edc/spi/types/domain/DataAddress.java
84.84% <25.00%> (ø)

...sformer/to/JsonObjectToDataAddressTransformer.java
92.85% <92.85%> (ø)

...ype/from/JsonObjectFromDataAddressTransformer.java
100.00% <100.00%> (ø)

...ansformer/from/JsonObjectFromAssetTransformer.java
100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Rename "turbo_cacti" to "turbo_cactus" according to /sbadev

Shoutout to NopoTheGamer!
— Erymanthus | u/RayDeeUx

i dont think i have any perms

oh its alr done


Worked on Issue #359

UI/UX enhancement
Description
This pull request addresses UI/UX Issues which involves various problems and includes additional improvement in "Are you Seller section".
Fixes #359

@HimaniSrivastav

please resolved the conflict


Feature Request: cursor focus to integrated terminal on VSCode reload

Upon a re-launch/re-load of VS Code, please re-apply the cursor focus to the integrated terminal if it was the last item to have focus before a re-load. This will save us from having to grab the mouse then click into the integrated terminal to give it focus again before continuing our typing.  Currently, the integrated terminal will lose focus after a re-launch of VS Code.

The editor always gets the focus by design. You could probably write an extension to do what you're after.


Make script loading async?

Currently you're adding the script into the head which will block the page loading until the script is downloaded.
/cc @mickeyreiss-visor

@KyleAMathews did you workaround this somehow or you still don't have Sentry in Gatsbyjs.org?

Interested to hear if you got this going too @KyleAMathews.
We had to turn Sentry off due to lots of errors coming from the Gatsby generated code.

@gilesbutler I get a good number of errors as well on my site, but they are legit errors that mean that the user had to click a link twice or something like that. I think it's worth keeping it enabled to check out.

Oh, instead of pulling it from a CDN, this plugin should just add it directly via their NPM package https://docs.sentry.io/clients/javascript/install/#npm
onClientEntry makes this sort of thing pretty easy for a plugin to do https://www.gatsbyjs.org/docs/browser-apis/#onClientEntry

There's related talk in #6 about how to pull the library in. I agree and I'd like to get it to pull from npm. I just copied the Google Analytics plugin to get Sentry loading on my site.

@octalmage Any update on pulling from NPM?

I sent a pull request regarding the loading from NPM instead of the CDN #9

I have to remove the plugin because of that, scripts are usually never added to the

Version v0.1.0 has been published to npm which resolves this, and it's also been deployed to my site https://jason.stallin.gs and appears to be working. Got some errors related to cached bundles so I got to see it work in production.
Thanks everyone!


Fix SBCK installation calls

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[ ] HISTORY.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

[ ] The relevant author information has been added to .zenodo.json

What kind of change does this PR introduce?

Fixes the installation call for SBCK in the tox config
Minor updates to the documentation

Does this PR introduce a breaking change?
No.
Other information:
It seems as though the older method of calling setup.py directly doesn't lend well to libraries being seen properly in conda/virtualenv running in tox.

Looks good to me


Feat: copy programme membership table TIS21-2509

This duplicates the existing ProgrammeMembership table into CurriculumMembership. This will prevent issues with partial programmeMembership data being saved into TraineeProfiles pending a complete sync of the new CurriculumMembership table from TCS.
There is some weirdness with Mongock not picking up the migration-scan-package when used via @EnableMongock and requiring manual instantiation on some machines.
TIS21-2509: ProgrammeMembership to CurriculumMembership - TSS Sync

We may just have to put up with the tight coupling in this case, but I'd like to have a proper look over it myself before merging.

@hihilary before I merge (I accidentally fixed some code smells after Andy's review, so I'll need a fresh approval anyway) - would you mind pulling and seeing if the mongock migration runs for you with just the annotation (i.e. as the code stands) - or if you need to uncomment the @Bean and remove the @EnableMongock annotation? That might help get to the bottom of why there's been this issue 😃

I copied the "ProgrammeMembership" collection from preprod into my local, and tried the data migration again. Both of @EnableMongock and @bean methods work on my side.
@ReubenRobertsHEE have you tried a empty collection of "ProgrammeMembership"? I'm wondering if you get the same error as me and if some null check needs to be added.

I copied the "ProgrammeMembership" collection from preprod into my local, and tried the data migration again. Both of @EnableMongock and @bean methods work on my side. @ReubenRobertsHEE have you tried a empty collection of "ProgrammeMembership"? I'm wondering if you get the same error as me and if some empty value check needs to be added.

Thanks Yafang, good to know both ways work on your side. I'll add an empty collection check - shouldn't happen in real life (given the code will be run only once), but better safe than sorry 😁

I've also removed the commented-out bean creation. It must be something weird on my side.


Allow overriding of 'hidden'

I'm not sure if this adds too much complexity to the library, but, for my uses, I didn't want a 'hidden' class added to the end of every leave transition. This would allow the library to be used for simple animations that don't result in visibility changes. I went through a couple iterations with the goal of preserving the same invocation syntax, except now it checks for two additional data attributes.
This PR adds data-transition-enter-final and data-transition-leave-final. These classes get added at the end of their respective directions, and get removed at the beginning of their opposition directions. It preserves the hidden default by adding a default data-transition-leave-final attribute of hidden.
enter() and leave() now track their last status by settings a data-transitioned attribute, rather than the presence of css classes. With the presence of potential multiple transition-leave-final classes, checking the transitioned status would be complicated. I thought leveraging another data attribute would be more precise and consistent.
I understand if this is more complicated than you want to make the library, but I wanted to at least make a PR in case you found it valuable to add this extra flexibility. Javascript is not my primary language so also completely happy to make syntax changes if you like the functionality but not the look!

@mmccall10 is this something you would consider? I'm about to pull my fork into another project and it reminded me of this PR so I figured I'd see if there were any updates

This is actually a nice idea. You don't always want to hide something, you might just want an animation to expand an element.


fix: stop split from creating too big right leaf

Another solution could be to find another LEAF_BULK_SPLIT_THRESHOLD but I couldn't find any value which was passing the tests introduced in #493, thus a recursive call to split was the easiest solution to cover this edge case

#492  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gabriele-0201 and the rest of your teammates on  Graphite

Yes, the branch updater should have the same problem. I was just focused on the leaf stage, so I pushed the fix and tests only for this. I will, of course, push it also for the branch in a following pr!


missing guard case in getParserPath with flat config format

Hey there,
I've run into an issue with the new flat config format: repro
Eslint outputs the error: Parse errors in imported module './test': parserPath or languageOptions.parser is required! (undefined:undefined) which originates from the function getParserPath of the 'eslint-module-utils' package: source
The function returns context.parserPath as a fallback (when the values of import/parsers are invalid). But as far as I can tell context.parserPath is not defined with the new flat config format, right?

We don’t yet support the new flat config format - see #2873.


Add systemd highlighting for Markdown code blocks

It would be pretty neat to have highlighting for systemd unit files inside Markdown code blocks. It was recently added to github/linguist and is already available with prismjs and chroma for Go. I think this is handled by the Markdown Preview extension, right?

This can be contributed by extensions, see https://github.com/mjbvz/vscode-fenced-code-block-grammar-injection-example


[wasm] Remove too conservative guards around file operations

Those guards were added to prevent the build from failing on WASI, but they are too conservative and the latest wasi-libc is now providing enough support for these operations.

@swift-ci Please test

@swift-ci test

@swift-ci test

@swift-ci test windows

@swift-ci test

@swift-ci test

@swift-ci test windows

@swift-ci test windows


Fix typo on "Create a volume by using az netappfiles volume create"

Hi,
Can you please fix the typo on a flag passed when creating a volume using "az netappfiles volume create" ?
Where is --creation-token $UNIQUE_FILE_PATH it should be --file-path $UNIQUE_FILE_PATH

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a07e71bf-5b6e-69fb-8fd5-79f33d344d7f
Version Independent ID: 4469d3b4-1f93-5dde-edd3-95723e49a3db
Content: Integrate Azure NetApp Files with Azure Kubernetes Service - Azure Kubernetes Service
Content Source: articles/aks/azure-netapp-files.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@mracfa Thank you for the feedback. We will work on it and will keep you updated on the thread

@mracfa The document is updated and changes will go live soon.

@mracfa Hope the provided information is helpful.
We will now close this issue. If there are further questions regarding this, please tag me in a comment. I will reopen it and we will continue the discussion.

Hi @psmanhas , i can still see the same typo. Were the changes already applied?
Please check below:
az netappfiles volume create
--resource-group $RESOURCE_GROUP
--location $LOCATION
--account-name $ANF_ACCOUNT_NAME
--pool-name $POOL_NAME
--name "myvol1"
--service-level $SERVICE_LEVEL
--vnet $VNET_ID
--subnet $SUBNET_ID
--usage-threshold $VOLUME_SIZE_GiB
--creation-token $UNIQUE_FILE_PATH
--protocol-types "NFSv3"

@mracfa  Here is the link for PR raised https://github.com/MicrosoftDocs/azure-docs-pr/pull/130699.
There are some internal events which might cause a slight delay in PR merge so you might expect it by End of week or so.
Hope it helps!!!
Do let me know in case of any more queries.

Ok, thanks for clarifying.


Updated comments on the test cases, removed duplicate test

Added more descriptive comments to all test cases, as well as removed a duplicate test case. Started setup for csv API route.


Additional attribute position for crop area

We add additional scope attribute position with params:

size
x
y

For saving position for crop area

Hi. I needed your changes and since this project is not maintained anymore, I forked it and published it as osd-ng-img-crop on bower: https://github.com/Osedea/ngImgCrop

Not to put you on the spot or anything like it, but would this become the "official" fork?

That's not up to me to decide this, but feel free to use the fork. I just put it on bower because others could need it.
If one day @alexk111 works on it again, I could make a PR to merge back stuff.


Users can't tell if their action is terminated because of action time limit

I have seeing two users report this, as they try to figure out why their actions are failing.
I'm not sure if we already print to stderr logs, so they can easily tell from the logs that action was terminated.
Also from activation id information might be another way to inform them that activation was terminated because it reach limit.
cc @rabbah @markusthoemmes

The activation start and end times in the activation record will allow a user to know: if end - start >= action limit then it was a time out vs an application error. We could adjust the error message accordingly.

I think having an error message/code that indicates a timeout error as opposed to the current error which just indicates that the action did not return valid json, would be a better way of handling the situation

having user do calculation on end - start, it's too low level, I agree error message is more usable to users.

+1
on top of that, should there be a corresponding error code, eg a 504?

I think having the 3 are very useful

return code
return string
stderr message in user logs (user will see it in wsk activation poll or UI console)

I favor doing only 2 from the list above.
We can achieve 3 by projecting the error from the activation during an activation poll.
We return BadGateway already for application/developer errors including actions that timeout and don't produce a response. Consider this nodejs action as an example function main() { return whisk.async(); }. This is a developer error and the action will timeout.

I'm OK not writing to stderr 3 above, if we can achieve goal of letting user know what happens when his running wsk activation poll

The error message will now indicate the action timed out. 3 from above is not yet done.

As @rabbah mentioned, warnings are in place. @csantanapr close?

The status code returned by an invoke is covered by #645.
To generate a message in the wsk activation poll, if the result of the activation is an error, it could be printed to the console. This would be the last remaining bit from the items listed in this issue.


Add script(s) for 3797 and 3798 issues

ATF Test Scripts to check FORDTCN-12772 and FORDTCN-12773
This PR is [ready] for internal review.
Summary
Add new script to check issues
ATF version
develop
Changelog

Added new script and updated test set

CLA

[x] I have signed the CLA

Moved to https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2599


Crash where suffix of an ngram not present in count file

What steps will reproduce the problem?

Create a large counts file in which there an ngram (e.g. "foo bar baz") whose
suffix ngram ("bar baz") doesn't exist earlier in the file.

Run `estimate-ngram -wl lm.arpa -counts counts` on it.

Note this doesn't always happen consistently for me with smaller count files,
but seems to replicate fairly consistently with larger (or at least
middle-sized) files.

What is the expected output? What do you see instead?

I'd ideally expect it allow a language model to be built in this case, even if
it means removing/skipping over the ngram in question, or making some
assumption about the count for the missing suffix (e.g. same as the
higher-order ngram).

I realise that these missing suffixes won't occur if I use MITLM itself to
compute the counts from a corpus, however if dealing with large amounts of
count-based source data from some other tools/sources, it's possible for these
kinds of constraints to be violated accidentally due to data corruption or bugs
beyond your control, and so it would be convenient if MITLM could cope
gracefully with these cases.

Alternatively if this is a WONTFIX then it would be good to at least document
what the constraint is on acceptable input for counts files, and give a more
friendly error message if the constraint is violated, so people know how to fix
up their input files in order to get MITLM to work.

Currently what you see is:

estimate-ngram: src/NgramModel.cpp:811: void
mitlm::NgramModel::_ComputeBackoffs(): Assertion `allTrue(backoffs !=
NgramVector::Invalid)' failed.
Aborted (core dumped)

What version of the product are you using? On what operating system?

Built from latest github master, Ubuntu 14.04.1

Cheers!

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 11 Feb 2015 at 12:08

A patch is welcome and collaborators are welcome as well. :-)
Unfortunately mitlm development has stopped a few years ago and I have never been one of the developers. However I am doing some maintenance work in my spare time, because I think it is a useful tool and I hope someone will pick it up in the future.

I was using srilm toolkit to prune the language model. When using mitlm toolkit to interpolation the pruning model, it occurs the same problems. I focus the code. When loading LM, it will first create the index of every grams. But when computing the conditional probabilities of higher grams, it will backoff. But now, the information of lower grams is missing. So the index of lower grams is not created, finally compute the info of higher grams is not finding the index. Regrettably, I'm not correct the bug as I'm not familiar with total process of interpolation of mitlm toolkit.


how to capture the audio wave, so I can draw it

how to capture the audio wave, so I can draw it

Please, follow the issue template when opening issues.
Either way I don't think this is on the scope of this library, Here we focus on playing the audio, for that low level stuff you will probably need a library focused on audio manipulation.


feat: support fs.inotify.max_user_instances as custom os config

What type of PR is this?
/kind feature
/kind api-change

What this PR does / why we need it:
support fs.inotify.max_user_instances as custom os config
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.005%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
2564

Relevant Lines:
3611

💛  - Coveralls


Add cloud service provider connection string documentation

Adds documentation for #62 as well.

Codecov Report

Merging #66 (77e5073) into main (d449676) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 77e5073 differs from pull request most recent head 24098d8. Consider uploading reports for the commit 24098d8 to get more accurate results

@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   81.21%   81.21%
=======================================
  Files          42       42
  Lines        1565     1565
  Branches      200      200
=======================================
  Hits         1271     1271
  Misses        260      260
  Partials       34       34

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ENH: support any order >=0 in ndimage.gaussian_filter

Probably more important than supporting higher order derivatives is the fact that the kernel generation is vectorized and doesn't rely on hard-coded formulas, but is instead automatically generated using NumPy's Polynomial.deriv().

Test error was a timeout only. LGTM now, so in it goes. Thanks @jaimefrio


docs: fix simple typo, succesful -> successful

There is a small typo in watson/cli.py.
Should read successful rather than succesful.
Semi-automated pull request generated by
https://github.com/timgates42/meticulous/blob/master/docs/NOTE.md

Thanks @timgates42 :pray:

Thanks @timgates42 :pray:


Extension causes high cpu load

Issue Type: Performance
Extension Name: quicktype
Extension Version: 12.0.46
OS Version: Windows_NT x64 10.0.17763
VSCode version: 1.31.1

quicktype.quicktype-unresponsive.cpuprofile.txt
Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

The extension only does computation when you generate code, and these calls are quite fast. Can you tell us more about what happens?


Add support for private AWS hosted zones

Private hosted zone can look like this
aws route53 get-hosted-zone --id=Z01234567T8N9RVU0NABC
{
    "HostedZone": {
        "Id": "/hostedzone/Z01234567T8N9RVU0NABC",
        "Name": "abc.def.com.",
        "CallerReference": "terraform-20240319062238790500000003",
        "Config": {
            "Comment": "Dev Managed Zone",
            "PrivateZone": true
        },
        "ResourceRecordSetCount": 5
    },
    "VPCs": [
        {
            "VPCRegion": "us-east-1",
            "VPCId": "vpc-0f11d467dd89ac123"
        }
    ]
}

It is used for private DNS within a given VPC. In order to support this the operator needs to deal with the fact that VPC is there instead of nameservers
This issue was created upon request in this slack thread:
https://kubernetes.slack.com/archives/C05J0D0V525/p1710844895665569

could be resolved by: https://github.com/Kuadrant/dns-operator/issues/60

could be resolved by: #60

Could be but not necessarily. That one is more about "fail gracefully if NameServers are not present" rather than "support private Hosted Zones (which have VPCs rather than NameServers)"

The nameservers are not actually used other than to put them into the status. So it is possible that fixing the bug would allow the zone to be created and used. We would just be misssing the VPC info in the status which shouldn't cause any issues

can be completed by running the e2e tests against a private AWS Route53 Zone

@trepel marking as done.

I was able to create records against a private zone now


Selecting and character copying issue

example: https://www.ietf.org/proceedings/82/slides/rtcweb-13.pdf (take side 2)

When copying the normal text everything works (expect that some characters like { and � seem to be inserted in some places).
If I copy the site two it looks like this:

Trust Model

Browser acts as the
Trusted Computing Base
(TCB)
{
Only piece of the system user can really trust
{
Job is to enforce user's desired security policies

Authenticated entities
{
Identity is checked by the browser (sometimes transitively)

Unauthenticated entities
{
Random other network elements who send and receive tra

Selecting the whole site is also not really possible:

Tested with Firefox 42

expect that some characters like { and � seem to be inserted in some places

This part is caused by the PDF itself, and not PDF.js, since copy-paste from Adobe Reader produces the exact same characters. (The only difference being that the PDF.js copy-paste result contains a number of unwanted extra line-breaks.)

When copying the normal text everything works (expect that some characters like { and � seem to be inserted in some places).

This was fixed by PR #7550.

Selecting the whole site is also not really possible:

This was fixed by PR #7879.
Closing, since all the points reported above should now have been fixed.


Are quantized models supported yet?

Feature request
Since i spotted bert_quant.rs in the candle backend i was curious if it is currently possible to point the embedding server to a "*.gguf" file and load a quantized model.
Motivation
Quantized models are often way smaller and should perform better on a cpu only server. I recently played around a bit with quantized BERT-like models and achieved 5x reduction in model sizes with only marginal hits to model performance. I guess it would also be a good thing for "serverless" deployments as a 25MB models should be simpler to distribute than a 200MB one 🤔.
Your contribution
At a second look the quantized bert model doesn't currently support batched inputs, which probably hurts throughput quite a bit, i guess that was caused by matmul_t not natively supporting batched inputs, which could be solved by reshaping the inputs.

I was curious if it is currently possible to point the embedding server to a "*.gguf" file

No that's not possible to do yet. It was removed from the first release as I want to do more tests.

and should perform better on a cpu only server.

That's the claim I want to explore. In my tests, some model performed way worse and it's not 100% clear why.

[quant model] doesn't currently support batched inputs, which probably hurts throughput quite a bit

I am not sure it has any effect. You are already compute bound without batching so it shouldn't really impact throughput.

But overall that's for sure something that we want to add. I just want to make sure we understand the advantages and drawbacks beforehand.

That's the claim I want to explore. In my tests, some model performed way worse and it's not 100% clear why.

I would greatly appreciate any benchmarks/test of the different quantization schemes on a bigger embedding dataset. I only played around with Q8 and Q5K quantizations on a very small datasets so it's likely my findings are simply just wrong/incorrect.

I am not sure it has any effect. You are already compute bound without batching so it shouldn't really impact throughput.

Good point, i just thought that the batching would enable rayon to better distribute the matmul_t across the available threads. But i'm not nearly knowledgeable enough to be sure about any of this.

Any updates on this?

Hi! any updates on quant support? I can support with testing, i'm not specialist on embeddings but we can define the metric for evaluation, ex: some kind of distribution of distances between each embedding's vectors of the orginal model and quant model, or other metric for testing this use case.

I'm really looking forward to this feature.


Double quote "" strings?

Can double-quoted strings be added to this extension? It would help as we run black formatter over Tiltfiles

Hello @omh1280 !
Thank you for your interest :)
I made the change, it is right ?
Before:

After:

I will publish the fix if you approve it

Yes that’s perfect, thanks for the timely response!

You're welcome
Extension is released to solve your issue :)
https://github.com/Tchoupinax/tilt-vscode-extension/releases/tag/v1.0.7


Handle 's  specially?

I'm calling String.replace(string, ~r/['’]s\s/u, "s ") before passing the string to Slugger, because otherwise possessives look odd to me.
"Sheep's Milk"
|> Slugger.slugify_downcase() # => "sheep-s-milk" 🤔

"Sheep's Milk"
|> String.replace(~r/['’]s\s/u, "s ")
|> Slugger.slugify_downcase() # => "sheeps-milk" 😀

Is this something you think is worth changing in Slugger itself? (Maybe not, because it's multilingual?)
Feel free to 👎 and move on if you don't care to have this. If you want it, let me know and I'll PR.

I like the idea. In the and the whole library is multilingual thingy :)


Regarding some questions about the paper.

Hi, I'm reading your paper and have a question about Figure 5. Can you share the specific numerical values in that figure or guide me to where I can find them? Thanks!

Hi, the specific numerical values you are looking for are provided in the following chart. Please refer to this for the detailed information you need.

I hope this helps!

Thank you very much for your response. Is the 'LLama' in the table referring to llama 1?

It refers to LLama-2-chat.


reporting unresponsive dnscrypt servers

what is the appropriate method to report unresponsive dnscrypt servers.
For example, d0wn-at-ns1 hasn't been responsive for a few weeks now.
thanks

The best thing to do would be to report it to the people maintaining the server :)


Fix for ms win

Fixed an issue where go generate command doesn't work on windows.
The go generate command does not work for the following reason.

The path separator of go generate directive generated by assets-life command is not Unix style

Therefore, the go generate command can be executed in the windows by the following way.

Add filepath.ToSlash() before generating go generate directive

And, when the go generate command fails, filepath.Walk() is not checked for errors and the cause of the error is not reported.
Therefore, error handling has been added too.
Thanks.

Please review this.
I want to use it on Windows.

Sorry for late reply.
LGTM. Thanks!


helm uninstall does not clear up the mount data from /mnt

🐞 Bug Report
Affected Services [REQUIRED]

Metadata service is getting effected with this stale data
 The issue is located in: helm uninstall command.
Is this a regression?
 No
 Yes, the previous version in which this bug was not present was: ....
Description and Minimal Reproduction [REQUIRED]
Command helm uninstall edgex-minnesota -n edgex is not clearing up the mounted data from /mnt directory. Maybe we can have some script to delete the residual data volumes once we uninstall using helm so that we have everything fresh when we install again.
Because of this old data we have inconsistency in the metadata.
Tested with Minnesota release (3.0.0) helm chart.
🔥 Exception or Error

ls -ltra /mnt
total 12
drwxr-xr-x 18 root root      279 Mar 14  2023 ..
drwxr-xr-x  7 root root       79 Aug 23 13:12 edgex-kuiper-plugins
drwxr-xr-x  8 1001 wheel     185 Aug 23 13:12 edgex-kuiper-data
drwxr-xr-x  2 root root        6 Sep 20 05:55 edgex-kuiper-sources
drwxr-xr-x  2 root root        6 Sep 20 05:55 edgex-kuiper-connections
drwxr-xr-x  2 _apt root    6 Sep 20 05:55 edgex-vault-logs
drwxr-xr-x 17 root root     4096 Sep 20 05:55 .
drwxr-xr-x  3 _apt root   20 Sep 20 05:55 edgex-vault-config
drwxr-xr-x  6 _apt root   56 Sep 20 05:56 edgex-vault-data
drwxr-xr-x  6 _apt root  126 Sep 20 05:56 edgex-consul-data
drwxr-xr-x  2 _apt root   47 Sep 20 05:56 edgex-consul-config
drwxr-xr-x  2 root root       57 Sep 20 05:56 edgex-consul-acl-token
drwxr-xr-x  2 lxd  root   52 Sep 20 05:56 edgex-redis-config
drwxr-xr-x  6 root root     4096 Sep 21 06:01 edgex-init-volume
drwxr-xr-x 10 root root     4096 Sep 21 06:01 edgex-kuiper-etc
drwxr-xr-x  2 1001 wheel     138 Sep 22 05:13 edgex-kuiper-log
drwxr-xr-x  2 lxd  root       22 Sep 22 05:13 edgex-db

🌍  Your Environment
Deployment Environment:
Ubuntu single node cluster created with K3s
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.2 LTS
Release:        22.04
Codename:       jammy
Kubernetes version
Client Version: v1.27.4+k3s1
Kustomize Version: v5.0.1
Server Version: v1.27.4+k3s1
EdgeX Version [REQUIRED]: v3.0.0 (Minnesota)
Anything else relevant?
k get sc
NAME                   PROVISIONER             RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
local-path (default)   rancher.io/local-path   Delete          WaitForFirstConsumer   false                  29d

Won't fix.  If you don't want to use /mnt volumes, customize the parameters in the storage section (https://github.com/edgexfoundry/edgex-helm/blob/main/values.yaml#L649).
You will want to set edgex.storage.useHostPath=false and set the storageClass parameters to your local-path provisioner.


how can I use your code with angular Cli?

just a textare appears in chrome.

look in closed issues and you will find the answer


Upgrade reading VCFs

I'm currently using pyvcf (https://pyvcf.readthedocs.io/en/latest/) to read VCF files. This project however is a bit older and uses the option use_2to3 in Python, which is no longer available in Python setuptools >=58 (https://setuptools.readthedocs.io/en/latest/history.html#v58-0-0). I should look into either updating pyvcf, or try to find another solution for reading VCF files that works with newer Python/setuptools.

This was completed by switching to vcfpy - https://github.com/apetkau/genomics-data-index/pull/130


Use custom FileLoaders to sanitize include error messages

This is a few parts, and was pretty involved.

First, plrust passes plrustc information about the crate being compiled via the environment, specifically the crate name (in PLRUSTC_USER_CRATE_NAME), and a list of directories that it's expected to access for source files (in PLRUSTC_USER_CRATE_MAY_ACCESS).
This is pretty coarse-grained, and is just a colon-delimited path list. We could consider something more robust if it would be useful.

Then, plrustc detects when the crate it's compiling happens to be the one given by PLRUSTC_USER_CRATE_NAME. If it is, it requires that the paths be subdirectories of the ones given in PLRUSTC_USER_CRATE_MAY_ACCESS.

Finally, Regardless of the crate being compiled, any io::Errors that come from reading files are now always reported as file not found (e.g. ENOENT). This is mainly to avoid this sort of issue happening in the future.

To fix this issue for include_bytes! we will also need https://github.com/tcdi/postgrestd/pull/39, since FileLoader does not (yet) support binary files.
I added a new dependency on omnipath to help make paths absolute, even in the case where they don't exist. It's maintained by one of the other maintainers of the rust stdlib, is part of an (unfinished) proposal for new stdlib APIs, and I've given it a read-through and it seems reasonable. I'm not sure it's exactly what we want, but if it's wrong it should be overly-strict rather than overly-permissive.
Still needs tests. Doesn't fix the related issue with the env macros (might require error matching...).

This needs https://github.com/tcdi/postgrestd/pull/39.

Crap, I think I just realized an issue here.

Commits like https://github.com/tcdi/plrust/commit/d277e0b1e3a425c07c168df5d5a3cfef1f83daad make me nervous only because this kind of thing is incredibly hard to get right. Definitely glad you realized this here in the PR!

Yeah, I agree :(.


cache/caching_bucket: add path to hash

Add path to the hash. This allows identifying difference instances by different config paths.

i am using 0.35.0 version of thanos, and have tried to setup bucket cache with memcache and S3 as storage, but found the behavior still exists, i.e., I see log message from one store that tried to reference another store's S3 bucket id and got into failure, as the result my long term metrics are having issues. It seems that this PR was merged on Feb 23, but I can't find a change log that says the issue is being put in a release. Anyone else still experiences this issue?


BitChoiceGroup disabled mode issue (#1199)

This closes #1199

in Fluent site  When set  ChoiceGroup Is disabled mood and user set DefaultSelectedKey we have selected item even but selected item color is different


Service Hosting - ServlyHostBuilder

🚀 Feature Request
Description
To minimize the contents of Program.cs with a Servly Application and to provide more control over application start up when using hosting a ServlyHostBuilder should be provided to complement the default HostBuilder in dotnet.
Proposed Solution
Implement a new IHostBuilder called ServlyBuilder this should implement the required interface as well as having extension points for concepts specific to Servly that need to be configured. It should also be trivial to use this host builder to extend into an AspNetCore application.
The implementation of host builder should have a tight integration with Servly and where possible should mirror the implementation of the default dotnet type.

A first draft of this has been implemented in dd70f55973a58f0746069df1e4037e14f5fe7765, closing this issue.


Adicion railway

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+5.3%) to 81.79%

Totals

Change from base Build<PHONE_NUMBER>:
5.3%

Covered Lines:
706

Relevant Lines:
822

💛  - Coveralls


Add ListenAndServeTLSConfig() accepts an already setup TLS Config.

Much better. Please add a comment to the method and then I'll get it merged. Thanks!

done -- thanks.

Thanks!


Update tensorflow to pick up a recent change:

https://github.com/tensorflow/tensorflow/commit/ebc41609e27dcf0998d8970e77a2e1f53e13ac86 improved the debug printing for TF_Function objects.

@swift-ci please test tensorflow

@swift-ci please test tensorflow

@swift-ci Please test tensorflow

@swift-ci please clean test tensorflow

@swift-ci Please clean test tensorflow

@swift-ci Please clean test tensorflow

@swift-ci Please clean test tensorflow linux GPU

@swift-ci Please clean test tensorflow linux

This requires a few more changes. I am abandoning this PR and will open a new one.

@dan-zheng Sorry for closing this PR. I did not realize you were making these changes as well. In addition to the CMakeLists.txt change, we will need to change utils/fix-tf-headers.sh as well. I am creating a patch with all the necessary changes.


[BUG] Please configure your GitHub settings first - Configured everything correctly

🐛 Bug Description

📝 Steps to Reproduce

Go to '...'
Click on '....'
See error '...'

✅ Expected Behavior

❌ Actual Behavior

📸 Screenshots

🔍 Environment Details

Chrome Version:
Extension Version:
Operating System:
Bolt.new Project Type:

💾 Additional Context

Did this work before?
Are you using any specific GitHub organization/repository settings?
Any error messages in the Chrome DevTools console? (Press F12 to open)

✔ Checklist

[x] I am on bolt.new website when trying to use the extension
[x] I have provided my GitHub token with correct permissions
[x] I have the latest version of the extension installed
[x] I have checked the extension popup for any error messages

I did those and still doesn't work

🚀 Version 1.1.0 is now live on Chrome Web Store and should fix this issue. Plus, there's a new Projects tab that lets you view all your pushed projects in one place and reload them back into Bolt.
Please update and let me know if you're still experiencing any problems!


need fontAwesomeIconWithUnicode

For some reason my php sends me article icons got from fontawesome.io lists
f0f6 (this is plain string, not Unicode character)
to convert it to \u{f0f6}" (singleUnicode  character) I have to do:
let t="f0f6" //got this icon from server
let c=Int(strtoul(t, nil, 16))
let ch=Character(UnicodeScalar(c))
var s=""
s.append(ch)
iconLabel.text = s

I think we need func doing this, a kind of String.fontAwesomeIconWithUnicode

So you need to make your php sends you the icon name instead of the Unicode string. Or if you could write the String.fontAwesomeIconWithUnicode function it would be awesome.


organization owner: dropdowns in public profiles have wrong links

Context
when logged in as organization owner, the links in the dropdown of an public profile are wrong
Steps to Reproduce

log in as organization owner
go to any public profile

Current Result

the dropdown is different from those in organization view, and dashboard view (see attached)
you can't go to organization page from public profile
the link in the own public profile to the own public profile doesn't make much sense

Expected result

the dropdown must be the same
a link to the organization must appear in the dropdown
maybe add links to dashboard in organization view

Additional info

related: https://github.com/CartoDB/cartodb/issues/4400
/cc @CartoDB/design

related with https://github.com/CartoDB/design/issues/467

This is still valid but we'll define the design first here https://github.com/CartoDB/design/issues/467


Update blank-issue.md

@Rick-Anderson @tdykstra @wadepickett ...
I see a possible error with the metadata naming. I'll try this fix.

Internal previews

📄 File
🔗 Preview link

.github/ISSUE_TEMPLATE/blank-issue.md
.github/ISSUE_TEMPLATE/blank-issue

🎉🍻
That LICK'D IT! ... I just need to make one more set of changes to the links because they don't format in the text area.


Set volumes as delegated mounts

https://docker-docs.netlify.app/docker-for-mac/osxfs-caching/
Sets docker volume mounts for the dev-shell and dependabot CLI as delegated mounts, which uses the Container as the source of truth.
From the docs:

When any container sharing a delegated mount terminates, changes to the mount must be written back to the host file system. If this writeback fails, the container’s execution must fail via exit code and/or Docker event channels.

I haven't observed any real speed-ups since using a dependabot core container with delegated mounts. Closing this out


How can I config SSH on windows

Our server is Windows 2008.
when i use ssh -v with public key,it shows:
Hi shlyz ! You've successfully authenticated, but Gogs does not provide shell access.
but when I request a clone using ssh, it told me:
Gogs: internal error: exec: "git-upload-pack": executable file not found in %PATH%
but I add this binary to PATH

It needs to be on the path in the CMD environment while gogs.exe runs. It's possible for you to have it in your own %PATH% (when doing echo %PATH%), and for it to not be in the environment when gogs.exe runs.
Check that the directory for git-upload-pack is permanently added to the %PATH% of the user that gogs.exe runs as during your test.

You can also test it with:
C:\gogs\>PATH=%PATH%;C:\Program Files (x86)\Git\libexec\git-core
C:\gogs\>gogs web

Set RUN_USER in gogs\custom\conf\app.ini to your own username. That will run gogs as yourself, with git-upload-pack guaranteed to be on the path if you installed msysgit in the default location.

LOL, we finally solved this problem:
1、Using Git Bash to start gogs service. NOT the window cmd.
2、Using COPSSH instead of FreeSSHD.

@ElvizLai very well! Can issue be closed?

Thanks for all of the tips.

Then the issue was that C:\Program Files (x86)\Git\libexec\git-core was not actually on gogs.exe environment path, and the above solution worked because that environment will be enforced by executing gogs.exe within Git Bash's sh.exe.

@victorsegall looks like so.


WIP tests for rqworker command positional arguments

It should fail right now (at least on Django 1.9.x) due to wrong argument parsing. Needs review.

Thanks for the PR!. This is fixed in https://github.com/ui/django-rq/pull/199

I believe in fail-fast principle, so it will be good to add tests from this PR too, but it's all up to you, of course.


Advanced Tab Switcher

Summary of the Pull Request
This PR adds the Advanced Tab Switcher (ATS) to Terminal. It'll work similarly to VSCode's tab swticher. Because this implementation rides off a lot of the Command Palette's XAML code, it'll look just like the Command Palette, and also have support for tab title search.
References
#3753 - ATS Spec
PR Checklist

[x] Closes #1502
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[x] Schema updated.

Detailed Description of the Pull Request / Additional comments
There are a couple things I'm aware of and planning/attempting to fix:

[x] The default mode should be in tab index order, but the command palette's default ordering is alphabetical by command name.
[x] Set command palette actions whenever keybinding is pressed.
[x] Add option to go backwards in tab switcher.
[x] Rearranging tabs still messes up index KeyChordText.
[x] Investigate hiding the text box when in Anchor mode
[x] Add Tab Icons - Ended up making a default "small left chevron" font icon for commands that don't have a specified icon as well.
[x] Ensure toggling tab switcher through the Command Palette works
[x] Update the schema
[x] Selected Index upon open should be on the currently focused tab index (or index + 1)

Just an idea. Would it be favorable to also include the icons next to the names in the drop down? Maybe a before and after to compare.

Maybe there needs to be a bit more spacing between the "Icon" column and the "Name" column?

Design feedback: (full review in progress)
I fricken love that you got the icons figured out. Now we can follow up by letting commands specify the icon too! (not in this PR for sure)
I agree that they maybe need a tad bit more spacing.
I'm not sure I love the labels for Index:0 etc.
Maybe change the Type a command name... string depending on which mode we're in?

I'm not sure I love the labels for Index:0 etc.

Same, I'm not sure what it should look like otherwise though. Also the index is kinda the only identifying information to differentiate tabs with the same titles from each other. 😞 -- Definitely open to ideas from the team on how to present it!

Works great!

. Because this implementation rides off a lot of the Command Palette's XAML code, it'll look just like the Command Palette, and also have support for tab title search.

Can we just consolidate with the Command Palette then? That would be better code-wise I think. When you open the Command Palette, just type in the name of the profile as shown here get the tab switched. I think that would be preferable from a user perspective as well. We already have profile options there, they just don't have the profile names. This feels very redundant, especially after seeing example usage.

consolidate

I mean, they’re already the same thing with different entry points; how much more consolidated do you want them, @WSLUser?

Just open the Command Palette and switch tabs from there. Add a default binding.

Yes, we should have a default keybinding for command palette.
From<EMAIL_ADDRESS>Sent: July 27, 2020 12:20
To<EMAIL_ADDRESS>Cc: Eric<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [microsoft/terminal] Advanced Tab Switcher (#6732)
Just open the Command Palette and switch tabs from there. Add a default binding.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/pull/6732#issuecomment-664589158, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALKX3RQLHLLYBLNQW5VP4L3R5XHQHANCNFSM4OMPLUQA.

Please do not inundate Leon's pull request with unrelated comments.
Thanks!

Sorry

Love all the new stuff in 1.3.  Great job
Russ

We'd love feedback on why the new tab switcher didn't work for you!

Not sure where this feedback should go, this seems like a reasonable place. I found it distracting to pop up on ctrl+tab every time, so I turned it off.
I do find the list of tabs to be valuable, but would prefer it to be accessible with a separate key (I guess that's the tabSearch action, which I have bound to ctrl+shift+s).

Strongly agree with @simonratner on the Advanced Tab Switcher - when I press ctrl+tab or ctrl+shift+tab, I just want to go to the next/previous tab, not get a modal popup. The tabSearch action does seem to be a better application of this functionality in terms of having a way to efficiently navigate through large numbers of open tabs.
Having said that, I thought the implementation of Advanced Tab Switcher was very clean. And since you exposed the useTabSwitcher setting, we can all just enable/disable the feature as desired.
You guys rock. Please keep making Windows Terminal great!


Suggestion: Shall we add some new options like: gvm list --release or gvm list --stable or gvm list --lts

Shall add some new options: gvm list --release or gvm list --stable  or gvm list --lts like nvm  --lts
why

this can reduce more early unstable or old versions to show;
this can help gvm users upgrade the major version to that latest more convenient;

ref
maybe can ref the nvm usage, like nvm --lts
others

gvm list --lts=<major[.middle][.micro]> show the release versions by version regex
gvm list --version=<major[.middle][.micro]> show the versions by version regex
gvm list --lts --num=[count] show the latest count release verisons
gvm list --num=[count] show the latest count verisons

@xwi88 kindly try this GO Version Manager: https://github.com/ankitcharolia/goenv


list.onShow

I'm not sure if I'm using .onShow() correctly. But shouldn't it be called when the component is shown?
Vars<String> items = Vars.of(String.class);
for (int i = 0; i < 50; i++) {
    items.add("item " + i);
}

Var<String> selection = Var.of("item 42");

of(this).withLayout("wrap, fillx")
    .withPrefSize(300, 200)
    .withBackground(Color.ORANGE)
    .add(GROW_X, scrollPane()
        .add(GROW_X, UI.list(selection, items)
            .onShown(it -> it.getComponent()
                .ensureIndexIsVisible(it.getComponent().getSelectedIndex())
            )
        )
    );

Yes it should.
But this is currently a simple delegate to ComponentListener::componentShown, so
if this does not work in the above scenario then it is a Swing bug.

I looked into it a bit and it seems that ComponentListener::componentShown is pretty useless. Maybe we should consider adding a HierarchyListener and look for DISPLAYABILITY_CHANGED events instead. 🤔
This will be called when the component is actually shown and I would say this is what .onShow() implies.

Oh wow.
Of course it doesn't do anything...
Well then let's fix this for Swing.
I have never used the HierarchyListener this way, but if you think it might work, give it a shot.
The first approach that comes to my mind is a regular component property listener.
But this is based on the assumption that a listener is fired in case of the visibility flag changing.
So that might also be worth investigating, but I have not yet looked at this in closer detail hover.

Do you already have an idea how to do this or should I maybe give it a shot?

I just had a quick look, but didn't have time for more. You can take it if you want.

I just took a bit of time to take a closer look
and as so often in Swing, the events the ComponentListener
is receiving here are kind of right, but all in all pretty
incorrect...
What it does is to literally listen to changes to the isVisible flag.
So when you bind a property to the visibility, and then toggle its,
you will receive show and hide events corresponding to the actual visibility on
the screen of the user!
So the assumption here was that the visibility flag actually
models the visibility of the component on the screen of the user.
But you cannot make these bold assumptions in Swing, oh no.
Because it turns out that isVisible may not actually mean that a component
is visible, it just means that it could be, depending on other factors.
Or to break it down more clearly:

a component is definitely invisible when the visibility flag is set to false
...and a component may be, or rather "wants to be" visible when it is set to true

So what that means in practice is that
a component whose visibility flag is set to true, may still
have a totally different visibility on screen depending if one of
its parents is visible or not!

I pushed a fix for both onShown and onHidden.
Could you take a look at it and tell me if this also works in your scenarios?

Thanks for fixing it. Yeah, I saw that inconsistency too, but I guess this is the best we can do. At least we get the right events sometimes. 😅


refactor: Store ListItems

Types of changes
Internal changes:

[x] Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
[x] Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

store list item objects when reading .md files

Motivation and Context
Store list items and tasks hierarchy
How has this been tested?
Unit tests
Checklist

[x] My code follows the code style of this project and passes yarn run lint.
[x] My change has adequate Unit Test coverage.

Terms

[x] My contribution follows this project's contributing guide
[x] I agree to follow this project's Code of Conduct

@stasmarkin - this is really exciting - thank you very much.

Great stuff - thank you very much indeed, @stasmarkin  and @ilandikov! 🎉


add autoschema validator

@alainjobart @sougou
add a simple validator that validates whether a given list of sql statements
are valid or not.
Next steps:

improve validator by adding more validation rules.
add endpoint in VtGate to get schema info (or connect to VtTablet instead ?)
add Autoschema (with Validator) into vtctld

@sougou
removed all error codes and updated comments. Please check again.

@sougou
I've been working on a schema management framework right now and feel this code might be obsolete later. I will not merge the code at this point and may issue a more complete view of the schema management tool later.


Fix typo causing dynamic property deprecation warning in Concerns\WithColumnFormats

Hi 👋
Currently dealing with deprecation warnings for a project I'm working on, and traced one back to this library.
Creation of dynamic property pxlrbt\FilamentExcel\Exports\ExcelExport::$columnFormat is deprecated in /var/www/vendor/pxlrbt/filament-excel/src/Exports/Concerns/WithColumnFormats.php on line 19

Looking at the code, I assume $columnFormat was a typo as the $columnFormats property already exists in the class.
This PR fixes that typo, when then removes the deprecation warning.
I think technically this is a breaking change, as anything relying on $columnFormat being set won't work anymore.
Thanks for your work on this library!

Thanks. Nice when we find broken code through deprecation warnings 😅

I think technically this is a breaking change, as anything relying on $columnFormat being set won't work anymore.

I don't think anything outside the library itself should rely on that property.


trying to improve codeclimate grade

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (17850db) 100.00% compared to head (f55b460) 99.60%.

Files
Patch %
Lines

src/components/LinkRedirect/index.tsx
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #49      +/-   ##
===========================================
- Coverage   100.00%   99.60%   -0.41%
===========================================
  Files           36       36
  Lines          249      250       +1
  Branches        44       45       +1
===========================================
  Hits           249      249
- Misses           0        1       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Conhost/ConPTY as used by Win32 Open-SSH inserts/modifies ANSI escape codes (specifically testing bolded text)

Environment
Windows build number: 10.0.19041.746
Windows Terminal version (if applicable): Preview v1.5.3242.0\

The Problem
My color scheme in Windows Terminal has default black text, and the default foreground bold color (<ESC>[1m) comes out dark grey. I'm assuming this is due to Windows Terminal using bright colors since we have no actual bold font support.
The default foreground bold color fails to work correctly when ssh-ing into a machine running the windows OpenSSH server (as installed from the Optional Features settings page). It comes out as bright white (color 97 for 256 color supporting terminals). It doesn't appear to matter what the shell on the other end is, I've tested this using both bash.exe as the shell, or the default cmd.exe. All that matters is that sshd allocates a pty.

Steps to reproduce
On a machine running Win32 OpenSSH server, make a script that outputs some default fg color bolded text.
For instance, if bash.exe is your shell, test.sh with contents:
#! /usr/bin/env bash
echo -e "\e[1m Bold Text \e[m"

If cmd.exe is you shell, try test.bat:
forfiles /m some_file_in_your_default_folder /c "cmd /c echo 0x1B[1m Bold Text 0x1B[m"

Then, ssh into that machine from a terminal (note this works with either Windows Terminal, or the default conhost.exe terminal, and it doesn't matter what your local shell is, WSL or cmd.exe) and run the command. It is helpful if you are in a color scheme that has a white background and a dark foreground color.
ssh user@targetmachine test.sh will write Bold Text to the terminal with correct ("light black") colors.
ssh -t user@targetmachine test.sh will write Bold Text to the terminal in bright white text. This is easily visible by showing the control codes themselves:
ssh -t user@targetmachine test.sh | sed 's/\x1b/\\e/g' Will show something like: \e[2J\e[m\e[H\e]0;C:\WINDOWS\system32\conhost.exe\e[?25h\e[1m\e[97m Bold Text \e[m
You can clearly see, along with sending an additional code to set the terminal title string, it changes <ESC>[1m to <ESC>[1m<ESC>[97m
Expected behavior
conhost.exe leaves my terminal control codes well enough alone.
I'm not sure if this is the right place for this, if conhost.exe is doing this, or if I'm even understanding/diagnosing the problem 100% correctly. I'll also crosspost this to PowerShell/Win32-OpenSSH on github.
NOTE: I do not see this incorrect behaviour if I ssh into sshd running as a service in WSL, i.e. apt get openssh-server && service sshd start.

So! This is definitely the right place. I’ve got good news and bad news.
This was one of our most annoying subtle bugs (in my opinion), which we tracked with #2661. There’s a heck of a lot of technical detail on why it existed and how it was fixed over there.
Good news: it’s fixed.
Bad news: the version of conpty OpenSSH uses is tied to the version of Windows on the server. Unfortunately, we can’t service that one. 😦
Thanks for writing up such a comprehensive report. Sorry to dupe it.
/dup #2661

So! This is definitely the right place. I’ve got good news and bad news.
This was one of our most annoying subtle bugs (in my opinion), which we tracked with #2661. There’s a heck of a lot of technical detail on why it existed and how it was fixed over there.
Good news: it’s fixed.
Bad news: the version of conpty OpenSSH uses is tied to the version of Windows on the server. Unfortunately, we can’t service that one. 😦
Thanks for writing up such a comprehensive report. Sorry to dupe it.
/dup #2661

(That issue bugged me so much that even as our issue tracker is approaching 9,000 total issues I still remember it by number :smile:)

(That issue bugged me so much that even as our issue tracker is approaching 9,000 total issues I still remember it by number :smile:)

Thanks for the response. I don't think I ever would have come up with the right search terms to find that issue on my own, so I appreciate the link. Is the real fix to wait until a windows update comes down the line that pulls this in to the packaged conhost? Will me being on an insider ring affect that time? Would #1817 help at all with this in the meantime?

Thanks for the response. I don't think I ever would have come up with the right search terms to find that issue on my own, so I appreciate the link. Is the real fix to wait until a windows update comes down the line that pulls this in to the packaged conhost? Will me being on an insider ring affect that time? Would #1817 help at all with this in the meantime?

Insider builds are closer to our development branches, and I believe the current one does have the fix. :)
re 1817: no warranty expressed/implied but it should work and I can’t officially support it if it doesn’t 😉

Insider builds are closer to our development branches, and I believe the current one does have the fix. :)
re 1817: no warranty expressed/implied but it should work and I can’t officially support it if it doesn’t 😉

It appears like the beta track (on windows build 19042.782 and conhost.exe version 10.0.19041.746, same as the non-insider track windows version) still exhibits the problem, and I don't have any machines on the dev track, so maybe I'll give 1817 a try (but you didn't hear that...). Thanks again for your help, I'll stop spamming this issue now.

It appears like the beta track (on windows build 19042.782 and conhost.exe version 10.0.19041.746, same as the non-insider track windows version) still exhibits the problem, and I don't have any machines on the dev track, so maybe I'll give 1817 a try (but you didn't hear that...). Thanks again for your help, I'll stop spamming this issue now.


[Bug] No Validation between Access Token URL and Client ID and secret

Steps to reproduce:

Add an API
Click on "Set as Datasource"
Select Authentication Type : Autho 2.0
Add inappropriate Access Token URL
Add correct Client ID and secret
Click on Save
Now navigate to API pane
Click on Run
and observe

Observation:
It is observed that the it depends on the API inserted and no Authentication done if the API belongs to said Client ID and secret
Video:
https://www.loom.com/share/90f0aad436f643d9acf6e631152f4d2b

Isn't this the expected behaviour here?

It is, I'm wondering if we should add some kind of validation while execution to disallow execution if you added extra credentials :D That might be more irksome though.

@Nikhil-Nandagopal thoughts?

@nidhi-nair @ofpiyush is any kind of validation even possible here? We don't know what are inappropriate Access URLs right?

We don't, we'll only know after we've hit it and not come back with a useful response. @Nikhil-Nandagopal

Then I guess this is sort of moot? Is there a soln here?


Concurrency handling in shout()

Hi, thank you for writing this inspiring piece of code!
I have a question about the concurrency handling in the shout() function. To my understanding in the current implementation  concurrent shout() calls that happen while the invoke-loop is being executed get silently ignored. Did I understand the code correctly? What is the rationale behind this design? Please see below the code of shout() with my comments:
     template<class T, class ... T_args>
     std::enable_if_t<std::is_same<T_message, T>::value>
     shout(T_args && ... args) {
       std::list<typename T_message::handler> handlers;

        {
            std::lock_guard guard{ mutex };
            handlers.swap(this->handlers);
            // this->handlers is now empty
        }

        // if shout() gets called by another thread now, the call will do nothing
        // because this->handlers is empty
        for(auto &handler : handlers) {
            std::invoke(handler, std::forward<T_args>(args) ...);
        }

        {
            std::lock_guard guard{ mutex };
            handlers.splice(handlers.end(), this->handlers);
            this->handlers.swap(handlers);
        // calling shout() will have effect again, as this->handlers has been restored
        }
      }

Hello! Thanks for the interest!
FUSS has been absorbed into Iara, a kind of framework I am developing. Sorry for leaving this repository unarchived.
You are right, that was a bug in the original code. The version published in Iara's repository was changed to disregard syncing altogether because it make sense in the broad sense considering the reactive model proposed by Iara.
In a multithreaded or interruptible system, a single thread / execution context should spin an event loop and any message handlers attached by listen should schedule an event to be executed by the loop (which does all the syncing by itself) when shout is called. Please note that if your application listens for the same message on the same object from multiple threads, you must manually synchronise accesses.
This means you can use it in typical multithreaded applications as well (without an event loop) albeit with a little more boilerplate, just add some mutexes and locks around.


Memory leak?

Thats flipclockjs.com in its own process and my implementation of it in its own process, both left to run over night.

This may just be a bug in chrome?  I tested a canvas based "flipclock" that had nearly exact same animation as flipclock, and by morning, memory usage was 17gb!!!
FlipClockJS seems to stick around 1.8-2.4gb range
If I can trust this memory addon in Firefox memory usage doesn't exceed 15mb
(all tests done on mac so far)

For reference, remove flipclock from my custom page and it stays a steady 200mb

Well guess I was wrong, it did go above 2.6

Tests on Windows latest chrome show much better memory management. No leak that I can see as of yet.  Page runs between 40-80mb.
Tests on Safari latest El Capitan show the SAME memory leak (not surprising, its webkit engine, same as chrome).
Tests on Firefox latest for mac show the best memory usage at around 10-20mb, no leak.

After a few hours, it seems windows chrome also has the leak.  up to 420mb now

Same Problem

This is an interesting post. Just getting back to it after a long time. I rewrote the library completely with ES6 classes and compiling with Rollup for UMD and all the latest stuff. I wonder if this still an issue. I don't see it in my profiling in the testing of the new js-es6 branch.


Why a same code's GPU version cost more memory than CPU version?

I made a very simple network using mxnet(two fc layers with dim of 512).
By changing the ctx = mx.cpu() or ctx = mx.gpu(0), I run the same code on both CPU and GPU.
The memory cost of GPU is much bigger than CPU version.(I checked that using 'top' instead of 'nvidia-smi').

It seems strange, as the GPU version also has memory on GPU already, why GPU still need more space on memory?

+1, I have this problem too. When I test a SSD detection model in CPU, the host memory consumption is about 400MB. However, in the GPU context the host memory consumption is about 1200MB and GPU memory consumption is about 500MB.

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


Asana<>GH integration

Task/Issue URL: https://app.asana.com/0/488551667048375/1202810419472777/f
Description
Change the GH action for the Asana<>GH integration
Steps to test this PR
Comment should be automatically created in the Asana task above

Current dependencies on/for this PR:

develop

PR #2198   👈

This comment was auto-generated by Graphite.


Issues resolved in screens and auth.dart

screens alag nhi khulni cahite bottom navigation bar me. It works like tab ek hi screen me hote hai different screens.
and fix some issues like 2 logout buttons in app bar and make their color white

Look how the page are refreshing on tab changing. Please make sure that they are not build again and again when I change tabs and remain in memory.


react-dom dependency not properly declared

Current requirement as a development dependency results in errors when required by other packages:

ERROR in ./~/react-bootstrap-table/~/react-toastr/lib/ToastMessage/animationMixin.js
Module not found: Error: Cannot resolve module 'react-dom' in /home/bveerman/code/climate-explorer/client/node_modules/react-bootstrap-table/node_modules/react-toastr/lib/ToastMessage
@ ./~/react-bootstrap-table/~/react-toastr/lib/ToastMessage/animationMixin.js 5:15-35

Changes introduced in e8b71523c64f152f257213c0a08a1ff5f34d11a4 require react-dom as a dependency.

Good catch. You are correct. ReactDOM was introduced in React 0.14 as a dependency since React.render is now deprecated. React-dom should be a peer dependency. I'll get a PR request for this asap.
Jer

Thanks the PR #41 by @jerairrest ! Current up to date version is v2.2.2


Update OData Entities with the SAP Cloud SDK's Virtual Data Model

Tutorial URL: https://developers.sap.com/tutorials/cloudsdk-js-vdm-update.html
Please specify the step you are referring to Step 4: Test yourself

What is the code I must to write here?

@mr-flannery Generally, to paste in a bunch of code is probablemtic since we do a text compare only. And though we ignore extra white space and casing, the text will not match when, for example, the user enters parameters in a different order, or uses different variable names, or puts code in different order.

Hi Ivan,
let me respond to your issues in bunch, since I've seen you opened similar issues in #5261 #5260 and #5258.
First of all apologies for this, I imagine it's frustrating to experience this on four tutorials at once.
Second, we will take a look at how to improve this. Please understand that this will probably not happen in the next few days. If you need to get past these checkpoints, let me know, then I'll post the solution here (given that we will rethink these questions, I see no harm in doing that).

@iMilazzo, this time I double checked everything. The tutorials have been updating. I hope you will finally be able to pass the test yourself sections. ;)


on processor/cookie generate_masked_cookies called with a String

the method generate_masked_cookie is coded as
def generate_masked_cookies(cookies)
      cookies.merge(cookies) { STRING_MASK }
    end

but on my API server (Grape + Rack & Puma)
the variable cookies is String like "(....)" result is a double exception in Sentry
where on top of the captured expression I get
NoMethodError
undefined method `merge' for "(...)":String
raven/processor/cookies.rb in generate_masked_cookies at line 33

would it be reasonable to check a little bit more if cookie quack as Hash ?
with something along the line bellow
def generate_masked_cookies(cookies)
      return if cookies.nil?
      cookies.merge(cookies) { STRING_MASK }   if cookies.respond_to?(:merge)
end

It work well for me and I retrieved the proper capture inside Sentry along with proper execution of my
code, instead of the 'exception during captured exception' as with thus issue.

thanks for reporting! this should be fixed by https://github.com/getsentry/raven-ruby/pull/996.
you can use the current master with gem "sentry-raven", github: "getsentry/sentry-ruby". I will release a new version for it later this week as well.

Closing it because the fix will be released in 3.0.3


Lightning Launcher removed from Play Store causing licensing issues

Lightning Launcher keeps trying to open the Play Store because it thinks I don't have a license to use it. It appears it's been removed from the Play Store.
Anybody have any solutions?

Follow the discussion and find some workarounds here:
https://github.com/TrianguloY/LightningLauncher/issues/24


Increment package versions for core releases

API change check
API changes are not detected in this pull request.


fix pokedata

Remove XL Pokemon
Fix Alolan/Galar SIDs

I used this as reference

I used this as reference

Accidentally pushed cmp fix in this branch

Accidentally pushed cmp fix in this branch


Apps: scatterplot is over-constraining variables

In both of the computation apps (ranked abundance and alpha div), when using the scatterplot, for the x axis we're unable to pick vars from some entities that are ancestors of the data entity from the y axis.
For example, below we're in the ranked abundance app making a scatterplot and using WGS Species as the input collection var. This means the y axis should have that same entity Whole metagenome sequencing assays, and so we should be able to use any continuous var from Participants or Samples on the x axis. However, when toggling on the Only show compatible vars toggle, we see that we can't choose anything from the Sample entity. Turning off the toggle, we can verify that Sample does contain Age, for example, which is a continuous var that should be allowed in this spot.

We also know this is not dataset specific, nor specific to the ranked abundance app. For example, the following is from a different dataset, and we cannot choose the Age variable from Sample or a similar var from Participant.

Note, the same behavior is seen in the alpha diversity scatter, but not in the XY Relationships scatter. For this reason, i'm suspecting the issue is related to web-eda 952.

duplicate of https://github.com/VEuPathDB/EdaDataService/issues/200
closing


Use batch ID for generating unaddressed QID Pairs

Motivation and Context
We need to be able to identify batches of unaddressed uac qid pairs, the easiest solution for this was to add in a UUID batch_id column which is set off the unaddressed request messages.
What has changed

Add a batch ID text box to the UI or generate one if left empty
Pass the batch ID into the unaddressed qid request messages
Copy across generate qid batch changes from qid-batch-runner branch

How to test?
Build and run the linked case-processor branch, try generating multiple batches from the ops UI. It should pass a valid UUID in if it is given one, or generate one if not.
Links
https://github.com/ONSdigital/census-rm-case-processor/pull/18
https://github.com/ONSdigital/census-rm-case-api/pull/6
https://github.com/ONSdigital/census-rm-qid-batch-runner/pull/3
https://trello.com/c/sOyLOxiP/783-add-batch-identifier-to-unaddressed-qid-uac-pairs-5

 Add batch identifier to unaddressed QID/UAC pairs (5)


RDA/RDF Manifestation data on classification not in BIBFRAME Instance data

Our RDA/RDF Instance data sometimes includes classification data as follows:

<> ns2:hasLcClassificationPartA "PZ7.D664"@eng ;
ns2:hasLcClassificationPartB "Han 1929"@eng .

This does not get transformed into BIBFRAME Instance data.
...probably because it is "not mapped" in the "M" tab of our rda2bf_rdaExtension sheet.
Noteworthy: the same data exists in RDA/RDF Item data and it does get transformed into BIBFRAME Item data.

Added mappings to rda2bf_rdaExtension > M tab.
Note that the "need-to-place-multiple-values-within-the-same-blank-node-in-converted-BIBFRAME" issue arises here. For example an rda:Manifestation may have:
<> <https://doi.org/10.6069/uwlib.55.d.4#hasLcClassificationPartA> "BMR01IDK" ;
     <https://doi.org/10.6069/uwlib.55.d.4#hasLcClassificationPartB> "IDKINAC" .

And output bf:Instance should have:
<> bf:classification [ a bf:ClassificationLcc ;
     bf:ClassificationPortion "BMR01IDK" ;
     bf:itemPortion "IDKINAC" ] .

Same applies to:

https://doi.org/10.6069/uwlib.55.d.4#hasNlmClassificationPartA
https://doi.org/10.6069/uwlib.55.d.4#hasNlmClassificationPartB

Thought this worth mentioning to @mcm104 because I believe that a mechanism exists to combine such values within a given bnode (but I don't know exactly where it is in the code).

I'm having an issue with these properties in manifestations...
It's easy enough to have Part A and Part B in the same blank node like in Ben's example, IF there are is only one classification number for a given resource. I didn't notice any problems with this for items, but I was just testing out some manifestations and I immediately ran into an example that had multiple values for hasLcClassificationPartA/B.
From 0010d9b0-ec29-4ab0-b25a-9a1a87108dd2.xml:
<rdf:Description rdf:about="https://api.sinopia.io/resource/0010d9b0-ec29-4ab0-b25a-9a1a87108dd2">
    <rdax:hasLcClassificationPartA xml:lang="zxx">PG1419.22.A34</rdax:hasLcClassificationPartA>
    <rdax:hasLcClassificationPartB xml:lang="zxx">M33 2003</rdax:hasLcClassificationPartB>
    <rdax:hasLcClassificationPartA xml:lang="zxx">PZ70.S42</rdax:hasLcClassificationPartA>
    <rdax:hasLcClassificationPartB xml:lang="zxx">L356 2003</rdax:hasLcClassificationPartB>
</rdf:Description>

When we have multiple part As and Bs, our combined blank nodes end up looking like this:
<rdf:Description rdf:nodeID="N2b9cd179d5e84915a1b69c7b14729350">
    <rdf:type rdf:resource="http://id.loc.gov/ontologies/bibframe/ClassificationLcc"/>
    <bf:classificationPortion>PG1419.22.A34</bf:classificationPortion>
    <bf:itemPortion>M33 2003</bf:itemPortion>
    <bf:classificationPortion>PZ70.S42</bf:classificationPortion>
    <bf:itemPortion>L356 2003</bf:itemPortion>
</rdf:Description>

This seems problematic to me because you can't tell which A goes with which B -- but then again, you can't tell that from the original RDA, either!
The only way to separate these would be to separate all of them, i.e.:
<rdf:Description rdf:nodeID="bnode1">
    <rdf:type rdf:resource="http://id.loc.gov/ontologies/bibframe/ClassificationLcc"/>
    <bf:classificationPortion>PG1419.22.A34</bf:classificationPortion>
</rdf:Description>
<rdf:Description rdf:nodeID="bnode2">
    <rdf:type rdf:resource="http://id.loc.gov/ontologies/bibframe/ClassificationLcc"/>
    <bf:itemPortion>M33 2003</bf:itemPortion>
</rdf:Description>
<rdf:Description rdf:nodeID="bnode3">
    <rdf:type rdf:resource="http://id.loc.gov/ontologies/bibframe/ClassificationLcc"/>
    <bf:classificationPortion>PZ70.S42</bf:classificationPortion>
</rdf:Description>
<rdf:Description rdf:nodeID="bnode4">
    <rdf:type rdf:resource="http://id.loc.gov/ontologies/bibframe/ClassificationLcc"/>
    <bf:itemPortion>L356 2003</bf:itemPortion>
</rdf:Description>

which doesn't seem any better.
Is this just a mistake in the original RDA, or is it something that needs to be accounted for? @gerontakos @briesenberg07 @CECSpecialistI @JianPLee

My opinion: put this "on the back burner" but it's something we'll have to deal with at some point. I would say just output it all into a single bnode and cry yourself to sleep for now. It's a problem with our extension. One thing we can do: change the range of the properties so that the expected value is a node; then create (in our extension) the required class to type the node, and keep class numbers together as a distinct resource. Does anyone have a better idea?

This is interesting! I would think our first step here would be to find out why an rda:Manifestation might have two classification part As and/or classification part Bs.
I would hold off on adding any additional terms to the vocab to accommodate this data until we understand the data better. I suspect that there is a (MARC?) cataloging practice behind these multiple classification values that we (or at least I) don't quite understand?

I think my concerns may have been premature -- it looks like the example I posted (which just happened to be the first one I checked) is our only manifestation to have this issue. I would assume that means it's an error, but either way, it seems ignorable.

Classification properties now included in RML for manifestations.

It is not unusual for a bib record to have two call numbers. Sometimes if a cataloger does not agree with the call number that's already there, the cataloger can add another one.


Create workflow to update version on behalf of contributor

Is your feature request related to a problem? Please describe.
Recently switched to the mac world and there are some issues with sed compatibility with Akri's version.sh script.
Rather than modifying the script for various OSes, it would be nice to have a workflow that will increase the version on behalf of the contributor. Instead/in addition to a version check workflow, we could have a version bump workflow that increases the version according to PR labels.

Note: for other mac users, updating sed -i s/"$LINE_PATTERN"/"$NEW_LINE"/g $FILE and sed -i "/$LINE1_PATTERN/ {n;/$LINE2_PATTERN/ {s/$LINE2_PATTERN/$NEW_LINE2/;p;d;}}" $FILE to use perl instead as perl -i -pes/"$LINE_PATTERN"/"$NEW_LINE"/g $FILE and perl -i -pe"/$LINE1_PATTERN/ {n;/$LINE2_PATTERN/ {s/$LINE2_PATTERN/$NEW_LINE2/;p;d;}}" $FILE make the script successfully update the version (with some warnings).

I would love to take this up


Exec tachikoma update<PHONE_NUMBER>2344

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io

Coverage remained the same at 77.5% when pulling ef64aa7e96788f673415287cbdfe8d715ad858c8 on tachikomapocket:tachikoma/update-20150129102344 into c940b64c3f22d5ffc18146f74377f14f2baa3f0e on app2641:master.


Add hooked rune, run damage roll strike adjustments set by property runes

The goal here was to close #9519, but the challenge was that Hooked has different behaviors based on whether it added a trip trait and I couldn't identify a way for a static roll note to distinguish if a trait had been present on the source weapon or not. Certainly one might be able to abuse predicates, but even introducing a new roll option from a rune wasn't straightforward without uncomfortable levels of indirection.
So then I observed that strike adjustments have an adjustDamageRoll function -- sure this currently only tweaks the damage materials, but it seemed by its name, placement, and 2nd-argument genericness that the intent was to provide a hook for any necessary data modifications. Thus this PR does as follows:

Updated adjustDamageRoll to also pass the current RollNotePF2e array
Fixed API omission where adjustDamageRoll on runes would never be called (it was only applied to adjustments from synthetics)
Updated typing on WeaponPropertyRuneData.strikeAdjustments to exclude StrikeAdjustment.adjustTraits and clarify that it is not currently supported
Introduced hooked weapon property rune, which adds the trip trait, and a critical damage note when the source weapon already had the trip trait

I'm sure it's very plausible I overlooked a better approach though.

Using strike adjustments to add notes is a no-go, but I think we already have a place for it?

No prob.
Runes can add roll notes easily, but there aren't any roll option predicates that would correctly distinguish which weapons originally had the trip trait.  It seemed like adding a new roll option just for this rune was a messy solution.
Was there another place you had in mind?

I acknowledge that might be trying to over-automate, but the note risks being pretty confusing if it isn't conditional. When the player sees "If a hooked weapon normally has the trip trait [...]" they immediately have to ask themselves if the trip badge was added automatically by the rune or not...

I would skip the note for now. Rune automation is getting moved to rule elements, so something that can't currently be replicated by them generally shouldn't be hard-coded in.

Well that future work makes sense to just wait for, sounds like a lovely improvement. I'll just start a fresh PR rather than force pushing over the top of this.