Extracting the syncing protocol from sc-network

At the moment, sc-network contains a pretty generic low-level networking stack, on top of which the syncing and transaction protocols are implemented.
sc-network exposes both the API of the low-level networking stack, but also an API for syncing and transaction-related actions.
I think it would make sense to move the syncing and transaction out of sc-network.
I focused on the syncing in the issue title, because transactions are already more or less segregated from the rest.

Issue still relevant and important.

I just briefly discussed this with @tomaka. Sync is rather tightly integrated with the networking currently. This manifests mainly in the sync peer-set being explicitly used by grandpa to keep both in sync. For now this should stay this way, this means we keep a hard coded sync peer-set inside the networking crate. For now, we would only move out the sync related code into its own crate.

Code can mainly be found here: https://github.com/paritytech/substrate/tree/master/client/network/src/protocol/sync

Okay, I will try to extract anything related to client/network/src/schema/api.v1.proto into a new crate sc-network-sync under client/network-sync

FYI, it is mainly this https://github.com/paritytech/substrate/blob/master/client/network/src/protocol/sync.rs and this https://github.com/paritytech/substrate/tree/master/client/network/src/protocol/sync.
And while I see that network-gossip is on the client folder level, sync should go to client/network/sync.

What is complicated is that the code in protocol.rs works as follow:

The low-level code reports that a substream has been opened.
We check whether this peer's handshake is ok.
If no, we ask the low-level code to close the substream.
If yes, we generate a SyncConnected event in the public high-level API.

If you want to plug the sync code through the public high-level API, you need to refactor this, but I don't really know how.

Turns out I need this for changing sync mechanics.
Can anyone share priority/ETA on this so I can manage expectations better?

I am learning a lot about the Substrate libp2p integration as I slowly crawl with this PR. I wanted to do too much refactoring at first, but got some intermediate milestone I can reach in a week, I guess.

@wigy-opensource-developer can you please give details on what is planned.

Of course.
As a first step sc-network will depend on an extracted crate sc-network-sync that will contain all handling of the block and state synchronization messages defined in the api.v1 Protobuf protocol.
As a second step message handling for light.v1 will go into an sc-network-light crate, but it will be still sc-network that depends on both.
As a third step, abstractions common to sc-network-sync and sc-network-light will be introduced into sc-network and the direction of dependency will be reversed.
My estimation is that the first step will get to master next week.

Hey, any progress here?

Hey, no there is not yet any real progress. This will also still take quite some time to have something proper.

Is there something I can do to speed up the process here? I can do some refactoring if I understand what it should look like in the end.

Can you again say what you need @nazar-pc?

To replace sync mechanism with a custom one. Let's say node discovers it is significantly behind the tip of the chain and needs to reach out to archival node to get last 1000 blocks. I need that to happen over our distributed storage network instead, archival nodes in traditional sense will not be feasible on our network due to scale.

Do you have any write up of your syncing algorithm? I mean it is enough to have some rough write up on how it works.

There is a lot to it, but somewhat abstractly the algorithm would be like this:

for older archival history:

identify the tip of the chain and root of the archived history (used to verify individual pieces)
start pulling segments of archived history corresponding to desired blocks in parallel from different peers (each segment is 128 pieces erasure coded into 256)
verify witness embedded in each of those pieces against root of the history
repair source data in case parity pieces were used
feed source pieces into reconstructor that will spit out encoded blocks as vectors of bytes alongside with corresponding block numbers (reverse of archiving process encoded blocks are fed into archiver and pieces are returned back)
at this point we have blocks we needed and can verify and import them

most recent blocks that were not archived yet (archiving is done over blocks at certain confirmation depth) should be synced in normal Substrate way from other full nodes

This replaces how node requests ranges of blocks of archival history from other nodes, I expect that majority of the remaining logic will remain the same as it is in Substrate though.

Okay ty.

I need to expand that syncing Subspace from Subspace DSN using described approach is the first step. We'd like to enable other chains to be able to sync from Subspace DSN in a similar way, so ideally we'd write some kind module that others can import into their project if they so choose. We were discussing about enabling parachains on Rococo to sync this way for instance.

As a first step sc-network will depend on an extracted crate sc-network-sync that will contain all handling of the block and state synchronization messages defined in the api.v1 Protobuf protocol.

@nazar-pc if you like you could start working on this. This is just the first iteration and is rather simple. It is really just about moving the code related to syncing to a new crate. sc-network for now will depend on this crate.

Cool, I'll notify once I start actively working on it

I started working on this, will send a PR once I have something useful

I believe I have this covered (links in the comment above):

As a first step sc-network will depend on an extracted crate sc-network-sync that will contain all handling of the block and state synchronization messages defined in the api.v1 Protobuf protocol.
As a second step message handling for light.v1 will go into an sc-network-light crate, but it will be still sc-network that depends on both.

There are 24 mentions of sc_network_sync in sc_network in my branch and 4 mentions of sc_network_light.
Waiting for review and open to suggestions on next steps.

Part 4 is ready on my side, it makes sc-network, sc-network-light and sc-network-sync depend on sc-network-common, but not on each other. Everything is wired together at sc-service level and sc-network-sync/sc-network-light theoretically can be swapped/customized: https://github.com/nazar-pc/substrate/compare/network-sync-refactoring-part-3...nazar-pc:network-sync-refactoring-part-4
Not 100% sure yet, but it might be just enough for me to do some of the tweaks to the sync process I wanted to do for a while.
Will submit as a PR once third PR is merged.

Not 100% sure yet, but it might be just enough for me to do some of the tweaks to the sync process I wanted to do for a while.

Sounds good :)

Yes, I do expect more PRs after that, just need feedback and to sync with maintainers before moving forward.
I'd like to not only sync to be decoupled, but eventually to have networking interface where sc-network would be just one possible implementation with ability to wrap/swap it with a custom one. So there would be a set of traits where some of the methods you mentioned would go for instance.
Just trying to make small steps without breaking things in the process.

With latest PR still not merged I already started working on more changes. First of all addressing some of review comments from that PR that'll land separately, but also on refactorings around NetworkService.
On NetworkService specifically I noticed that there were traits here and there that were proxying calls into NetworkService, so I decided to move them into sc-network-common as well as extracting more traits for different use cases so that most of Substrate would depend on generic traits from sc-network-common instead of NetworkService explicitly.
It'll allow wrapping NetworkService or even wrapping default Substrate networking layer with an alternative just like you can swap consesnsus and other parts. It'll take time to make those interfaces truly generic (making it independent from libp2p is out of scope though IMO, so things like PeerId will remain in many places).

@nazar-pc what is your future plans here? Do you still want to continue pursuing this issue or can I assign it to someone else?

Okay :) Yeah, sync is still really deeply backed into sc-network and this assumptions needs to be removed. In the end sync should be its own protocol that just sits on top of sc-network like Polkadot networking for example.

@nazar-pc I've also started to slowly work on this. So far I'm just getting familiar with the code and seeing how deep it goes but if you have any pending changes you've made since #11940 that you feel like sharing, that would be much appreciated so we don't do the same work twice.

I don't have anything refactoring-wise pending.

I have removed rest of the syncing code from sc-network, demo/PoC is here. It's not meant to be reviewed as-is and acts more as a reference because it's a) too big for a single PR b) has some solutions that are still a little rough around the edges and c) and is lacking tests. I'll be working next towards splitting it into smaller and more reviewable PRs.
Unfortunately, as we want to keep the hardcoded entry in the peerset, I've had to add some workarounds around the sc-network code to make it work with the now "transparent" syncing protocol and the calls it makes. I wish to remove these in the future if we can remove the hardcoded entry from the peerset. The testing framework is also going through some async growing pains which means that some tests in finality-grandpa must be rewritten to be fully async or the testing framework (e.g., for adding blocks for peers) must be internally async and then just expose sync interface but that may have unintended consequences. I'll get back to dealing with that issue when the time comes.
Currently the syncing code is installed as a bunch of generic request-response protocols (+ block announcement notification protocol) and the NetworkPeers is amended to contain report_peer_validation_result(PeerId, Enum::{Accept, Reject}) which the syncing code calls when it has determined whether Substrate should keep the connection open to this peer. If the peer is accepted by the syncing code, only then does sc-network emit SyncConnected event. This can be made more generic in the future by providing some mechanism for protocols to inform sc-network that they would want to validate incoming peers and sc-network would then wait for validation results from all of these protocols before emitting SyncConnected event. I would prefer something like this to what is currently implemented but I'm not sure if there is a need for such a mechanism, maybe in the future. I think it may be worth trying to fix https://github.com/paritytech/substrate/issues/5685 while working with the handshaking/peer connection code.
NetworkNotifications is also modified (temporarily) to contain write_sync_notification() which uses the hardcoded peerset ID to send syncing-related notifications to peers. I don't like it at all but as long as we have hardcoded entries inside sc-network, we need to have some mechanism to use that entry and this is probably the path with least friction. I hope to remove it in the near future.
This was more of a status update. I've started to split the work and I hope to have something reviewable soonish. Let me know what you think about all of the above. I would especially appreciate any feedback on what needs to be done so that the hardcoded entry can be removed from the peerset.

only then does sc-network emit SyncConnected event.

This should entirely go out of sc-network. I think what we should do is the possibility to register in the sync protocol callbacks aka channels that get informed when sync adds or removes a peer. Then we could use this to make any protocol that follows the same peers as sync to use these callbacks. sc-network should really not assume anything about the protocols running on top of it.


Allow non-utf8 characters in arrow_csv::reader::infer_reader_schema

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I'm writing some code to infer types from a bunch of different CSV files. I ran it on one and got this error:
Sampled 100000 lines from ./backup/Book-0.tsv
Error: Csv error: Encountered UTF-8 error while reading CSV file: invalid utf-8: invalid UTF-8 in field 4 near byte index 149

because it contained this string serving as the navy�s liaison
Describe the solution you'd like
I'd like to be able to pass an additional field to the ReaderOptions struct parameter to infer_reader_schema_with_csv_options, or better yet infer_reader_schema function, and have the library silently continue on non-utf8 values. It could still output their schema type as utf8, or a NullType, or even better BinaryType.

Describe alternatives you've considered
I could handle this in my code. I imagine there may be many users with non-utf8 CSVs that would still like to pass the data verbatim through Apache Arrow.
Additional context

Diving into the code, it looks like we'd need to use read_byte_record instead of read_record below. I'm not sure the extent of changes this would require in the arrow-csv crate.
https://github.com/apache/arrow-rs/blob/9e39f96b121d88b7427295bd326d14bb78d0fb39/arrow-csv/src/reader.rs#L487-L499

It could still output their schema type as utf8

It would need to infer it as binary, as UTF-8 data is not allowed to contain UTF-8 data.
As it stands the crate does not support reading or writing binary data, I would be happy to review PRs that would add support for this, but there are some open questions on what this might look like.

Closing as a duplicate of #3291


Ensure tests clean their tempfiles

A number of tests were not cleaning up after themselves, which left
a bunch of files in the TMPDIR.
Ensure we remove all the tmpfiles and dirs we create.

@grahamwhaley CI error:
ERROR: No "Fixes" found

Hmm, but it is in the second commit.... let me check....

I don't think the Fixes:  is needed for every commit, but I see something weird here: the checkcommits tool says that it found 3 commits, while the PR contains 4.
 See the document below for help on formatting
commits for the project.

bug in the checkcommits tool?

Err.... no you do not.
From: https://github.com/kata-containers/tests/tree/master/cmd/checkcommits#overview
checking for at least one "Fixes #XXX" entry in the commits
and from https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#general-format:
A "Fixes #XXX" comment listing the GitHub issue this change resolves.
This comment is required for the main patch in a sequence. See the following examples.

I've never 'Fixes' every commit - just normally the last one in the sequence :-)
Maybe that is the thing here - it is not the first or last commit - but, I've never seen that fail before.
I'll have a look

@chavafg - yeah, hmm, that could be a bug in the tool or CI - there are indeed 4 patches. Heh, looks like we are going to have some checkcommits fun with no @jodh-intel :-)

OK, I think I know what happened!
Over on #475 I also fixed one of the issues in one of the commits here - so during the rebase/merge on the CI I think that commit gets dropped - hence the CI only sees 3 commits (the same happened to me here when I rebased to master - took a little bit of figuring out why I only then had 3 commits!).
It also happened to have been the commit with the Fixes in it :-) Lesson learnt - something to look out for in the future...
Rebased, reworeded, re-pushed...

Looks like static checks are fine, but the CIs suffered from the (unrelated I believe) https://github.com/kata-containers/tests/issues/513
Rather than re-kick them all, will wait for any input from @chavafg on if that is a transient, persistent or sporadic failure mode.

@grahamwhaley @chavafg  - we still waiting for a new rekick?

Yep, let me do that (probably with a rebase) - let's see how the CI is feeling..

LGTM!
Looks like travis-ci is having issues with linux-ppc64le platform. Let's merge ignoring it since all the other CIs have passed.

@grahamwhaley please backport this PR to stable branches if not present.

Nevermind, it's already part of the stable branches.


prompt: update powerlevel10k submodule to v1.15.0

Release notes:

https://github.com/romkatv/powerlevel10k/releases/tag/v1.15.0

Thank you @romkatv as always!


Bot composer always prompts for LUIS and QnA keys even though they exists

Hello,
Apologies not sure if this already exists as I couldn't find an entry.

Bot Composer v1.3.1
If I edit with a trailing space and remove again, this resolves.

Hi @danielallen73 the team will look to reproduce this issue and report back. Thanks!

@danielallen73 I was trying this scenario on 1.3 Composer. It seems to work fine. These were the steps I tried.

Create a new bot with the template Todo with LUIS
Composer prompts for the LUIS key the first time. I entered it and the LUIS region.
The error indicator does not appear now
Restart Composer app
Open the bot again. I dont see the error indicator.

Are these good steps to repro your error or is there a different workflow that could create the scenario you are showing?

Closed due to no activity..

Apologies for not getting back to you and team. Thanks @srinaath for your attempts to reproduce.
@daveta - Happy for you to close although I still have the issue everytime I restart Composer app. v1.3.1. I'll try and reproduce by start a new bot as per your advice. If it still occurs I'll get back to you. Many thanks


Segmentation fault (core dumped)

Hi,
Ubuntu 16.04
Node 8.16
Everything built without issue, index.js give no error, yet i've got a Segmentation fault (core dumped) with
~/node-hasher-mtp# node test.js
Finding nonce...
Segmentation fault (core dumped)
Thanks

valgrind output:
Finding nonce...
==6645== Invalid read of size 8
==6645==    at 0x98E18C1: copy_block (in /root/node-hasher-mtp/build/Release/hashermtp.node)
==6645==    by 0x98EA933: mtp::compute_blake2b(block_ const&, unsigned char*) (in /root/node-hasher-mtp/build/Release/hashermtp.node)
==6645==    by 0x98EAD28: mtp::hash(char const*, unsigned int, unsigned int&, unsigned int, unsigned char*, unsigned long () [128], std::deque<std::vector<unsigned char, std::allocator >, std::allocator<std::vector<unsigned char, std::allocator > > >, uint256&) (in /root/node-hasher-mtp/build/Release/hashermtp.node)
==6645==    by 0x98F9E62: hash(Nan::FunctionCallbackInfov8::Value const&) (in /root/node-hasher-mtp/build/Release/hashermtp.node)
==6645==    by 0x98F9784: Nan::imp::FunctionCallbackWrapper(v8::FunctionCallbackInfov8::Value const&) (in /root/node-hasher-mtp/build/Release/hashermtp.node)
==6645==    by 0xA98152: v8::internal::FunctionCallbackArguments::Call(void ()(v8::FunctionCallbackInfov8::Value const&)) (in /root/.nvm/versions/node/v8.16.0/bin/node)
==6645==    by 0xB0F37B: v8::internal::MaybeHandlev8::internal::Object v8::internal::(anonymous namespace)::HandleApiCallHelper(v8::internal::Isolate, v8::internal::Handlev8::internal::HeapObject, v8::internal::Handlev8::internal::HeapObject, v8::internal::Handlev8::internal::FunctionTemplateInfo, v8::internal::Handlev8::internal::Object, v8::internal::BuiltinArguments) (in /root/.nvm/versions/node/v8.16.0/bin/node)
==6645==    by 0xB0FFCE: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) (in /root/.nvm/versions/node/v8.16.0/bin/node)
==6645==    by 0x2F1BEBE842FC: ???
==6645==    by 0x2F1BEBF3EDB5: ???
==6645==    by 0x2F1BEBF3EDB5: ???
==6645==    by 0x2F1BEBF3EDB5: ???

The segmentation fault could be because you don't have enough memory.


BUGFIX: Enter in register now

Github Issue (if applicable): #481
Trello Link (if applicable): n/a
Forum Link (if applicable): n/a
Explanation of Bugfix/Feature/Enhancement:
Just a chaining issue with jQuery -- on click was getting added to the entire list of elements in the modal, no bueno.
Recommended Release Notes:
Fixed an issue where scheduled transactions would get "entered now" when you tried to delete them.

That's a nasty one, thank you!


BUG: Multiple issues on about us page, read later page.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

Social media links are not working.
Email validation hasn't been provided in subscription of newsletter on both about us and read later page.
In free e-books section the github logo has been put twice.

@anuragverma108 sir do you want me to work on these  issues together and level it accordingly or shall I raise separate issue for each?
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I would like to work on this project. Please assign it to me.

Assigned! @Aarzookhunger
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it. Happy open-source contributing!


Remote control buttons in MyController

jkandasa, as we talk on mysensors forum, it's very kindly and would make mycontroller almost a perfect controller that we can control the IR devices from an interface on own mycontroller website, where you could save the signals of each button of the remote of TV, for example, and send the IR signals with no need of its remote fo this.
Thanks for your support.

Added as dashboard widget. Buttons detail should be in JSON format.
To create json configuration error free way use http://www.jsoneditoronline.org/
We can include button names as HTML or icons(recommended: font awesome icons)
In configuration name and payload are mandatory fields.
btnType is optional and can be any one of default, primary, success, info, warning, danger
Example json as follows,
[
  {
    "name": "",
    "payload": "P",
    "btnType": "danger"
  },
  {
    "name": "1",
    "payload": "1"
  },
  {
    "name": "2",
    "payload": "2"
  },
  {
    "name": "3",
    "payload": "3"
  },
  {
    "name": "4",
    "payload": "4"
  },
  {
    "name": "5",
    "payload": "5"
  },
  {
    "name": "6",
    "payload": "6"
  },
  {
    "name": "7",
    "payload": "7"
  },
  {
    "name": "8",
    "payload": "8"
  },
  {
    "name": "9",
    "payload": "9"
  },
  {
    "name": "0",
    "payload": "0"
  },
  {
    "name": "",
    "payload": "PL",
    "btnType":"success"
  },
  {
    "name": "",
    "payload": "PA",
    "btnType":"warning"
  }
]


[MAD][DATA1018][lab-pivot-table-and-correlation] Ivan Cernicharo

Hello Belen,
I have just finished the lab. Not difficulties found. I look forward to hearing from your feedback.
Best regards,
Ivan

P.S.: Last modification >  lab-pivot MOD #5 Modifications on NAN values


Add details of using RRT to move from SQL to WID

RRT can be useful for customers that want to simplify a SQL based farm configuration by moving to WID. Similarly a customer that grows an existing WID based farm to sizes requiring SQL, could do so using the RRT tool. RRT is often suggested via support cases to customers but we dont have this documented in public for customers to self discover.

@billmath Please confirm if this text is okay to merge. Thanks!!

#sign-off


in memory shared cache connection string not working

This connection string
"FullUri=file::memory:?cache=shared;"
produce Keyword not supported: 'fulluri'
Please support in memory sqlite shared cache

Try using "Data Source= :memory: ; Cache = Shared" instead.

While the connection string doesn't throw exception, the shared cache is not working.

Can you provide more details? Build version, platform, evidence/error messages, etc.

When you use in memory shared cache with SQLite,
Opening and closing in memory connection should be able to connect to the same in memory database,
https://www.sqlite.org/inmemorydb.html
So when you use in memort database without cache
Open in memory database
CreateTable test
Close
//Table test gone
but when you use in memory database with shared cache
Open in memory database with shared cache
CreateTable test
Close
//Next connection can still see table test

Opening and closing in memory connection should be able to connect to the same in memory database

I believe you have to keep at least one connection to the database open for the lifetime of the database. As soon as all connections are closed, the database is deleted.

Confirmed.

The database is automatically deleted and memory is reclaimed when the last connection to the database closes.

Yes you are correct, thanks!


pool should always come from client

may fix this
when comparing two IPPools, values should be specified, if create one IPPool, masquerade, ipip, ipam may not be the same as stored in etcd.

@tonicbupt Thanks for the PR!  In order to review and accept the fix, we would like you to sign a contributor's agreement, basically certifying that this code isn't owned by someone who might not want it in Calico.
http://docs.projectcalico.org/en/latest/contribute.html#contributor-agreements

@spikecurtis done

@robbrockbank ping

@tonicbupt Looking into this now.

LGTM.  Thanks for the PR.  Merging now.


Fix broken code in Snackbar example

i guess this pull request is no longer required since the changes made in README

Thanks for that, I think it has already been corrected in the readme, but thanks for having dedicated your time to this PR.

No problem, thanks for your work :)


Build consolidated flow of DPC experiments

1. JAX
2. MSK
3. UCSF
4. NWU

https://encyclopedia.pub/entry/28064#:~:text=The procedure of metabolomics analysis,impact on the final results.
Metabolomics assay explanation

Rough consolidated workflow for Genomics/transcriptomics (Still pending on lipidomics/metabolomics<EMAIL_ADDRESS>


Publish-NavContainerApp failes because of warnings

Freddy,
I publish the spring release as an bigapp as shown in Kopenhagen with Redcarpet.
the compile of this bigapp goes fine, alot of warnings but MS already told us that there where around 800 warnings for now...
but when i publish it fails

do you know how to ignore warnings during Publish? in the end we want to fix the warnings, but standard BC warnings must be fixed by MS themselfs.

It shouldn't fail due to warnings - and the warnings are some that MS will fix.
Search the output for ": err" and you will probably find an error.
If you find the error and need help to resolve if, you will need to explain the steps done before and how you try to publish.

Did you make this work - or did you find the errors blocking the publish?

You are right,
found:
: error AL0451: An assembly named 'Microsoft.Dynamics.Nav.Client.CodeViewer, PublicKeyToken=null' could not be found in the assembly probing paths 'C:\Program Files\Microsoft Dynamics NAV\140\Service\Add-Ins, C:\Windows\TEMP\Microsoft Dynamics NAV\Add-Ins\14.0.31606.0, C:\Program Files\Microsoft Dynamics NAV\140\Service, C:\Windows\Microsoft.NET\assembly'
: error AL0417: Control add-in '"Microsoft.Dynamics.Nav.Client.CodeViewer"' not found

Freddy,
It fixed the problem, only i have another question maby you know the answer.

how is it that an app of 20 mb  (i made the big app of the april release MS objects like around 6000)
how is it that it takes like 5,5 GB / 6GB for the NST during the publish..
is that normal?

Sorry for the delay.
Spring release 2019 RTM is very very memory consuming (as you have found). CU1 (which comes out very soon) is better - but will still have a big memory footprint.
I am afraid that with RTM, what you see is normal - lets try this again with CU1 - or create an Azure VM with 32GB or memory using http://aka.ms/getbc and run it in there.


v6 chatbot - User message text color should be white in light theme

User message text color should be white in light theme

Hi @divyanshiGupta - I'm trying to look into this. Are you seeing this in https://github.com/janus-idp/backstage-plugins/pull/2145?

I am seeing this issue in the chatbot as this class pf-v6-c-content which changes the text color to black is getting added onp element inside of message-text div but to fix this I am doing the following here https://github.com/janus-idp/backstage-plugins/pull/2145.
'& div.pf-chatbot__message--user': {
   '& div.pf-chatbot__message-text': {
       '& p': {
           color: theme.palette.common.white,
         },
    },
}

Thanks for the extra info @divyanshiGupta; I'll take a look at this today!

Hi @divyanshiGupta - Would you be able to try pulling in version 2.0.0-alpha.25?
The release is available on:
GitHub release
npm package (@alpha dist-tag)
It should contain my attempt at fixing this, but please let me know if it doesn't work! We'll try something else in that case.


Don't report error when installing exists version

Signed-off-by: Lonng<EMAIL_ADDRESS>
What problem does this PR solve?
Don't report error when installing exists version.
➜  tiup git:(verbose-list) tiup install tidb:v3.0.11 tikv:nightly pd:v4.0.0-rc.1
download http://<IP_ADDRESS>:8989/pd-v4.0.0-rc.1-darwin-amd64.tar.gz 37.88 MiB / 37.88 MiB 100.00% 7.59 MiB p/s
Error: component tidb version v3.0.11 is already installed
component tikv version nightly is already installed
➜  tiup git:(verbose-list) git branch -b verbose-list

Check List
Tests

Manual test (add detailed scripts or steps below)

➜  tiup git:(fix-install) ✗ tiup install tidb:v3.0.11 tikv:nightly pd:v4.0.0-rc.1
component tidb version v3.0.11 is already installed
component tikv version nightly is already installed
component pd version v4.0.0-rc.1 is already installed

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   23.48%   23.48%
=======================================
  Files          36       36
  Lines        2955     2955
=======================================
  Hits          694      694
  Misses       2167     2167
  Partials       94       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6177262...02199a5. Read the comment docs.


ONE 6 vCenter - network creation on default cluster

Description
After importing all vCenter resources inside default ONE cluster 0, when we create new networks, they lose their Cluster ID membership and we need to manually re-assign the Cluster.
To Reproduce

Setup ONE and import vCenter resources (vCenter, Datastores).
Create a network specifying

Cluster ID = 0
Network mode = vCenter
Switch Name =
Port group type = Distributed Port Group
Host ID =

Network is successfully created, but the CLuster ID is lost (right after creation you can see it, but after a refresh of the page the ID is gone)
At this stage, you need to manually re-assign the Cluster ID to the new network, otherwise no VM can be instantiated with that network interface.

Expected behavior
The new Network should keep the Cluster ID setting when created.
Details

Affected Component: Sunstone, Network
Hypervisor: vCenter/ESXi
Version: <IP_ADDRESS> and 5.13.80 (Beta 6)

Additional context
See attached screenshots.

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches
vnet-creation-cluster-issue.docx

Doc: https://github.com/OpenNebula/docs/blob/one-6.0-maintenance/source/intro_release_notes/release_notes_enterprise/resolved_issues_602.rst

PR: https://github.com/OpenNebula/one-ee/pull/1240

* Doc: [https://github.com/OpenNebula/docs/blob/one-6.0-maintenance/source/intro_release_notes/release_notes_enterprise/resolved_issues_602.rst](url)

* PR: [https://github.com/OpenNebula/one-ee/pull/1240](url)

Hello,
The first link leads to a page listing resolved issues in 6.0.2. None of them seem to apply to this case, according to the title.
The second link leads to a non-existing web page.
Did I miss anything? Can you please provide some info?
Thank you very much

Hello,
Sorry, the links are updated now with the correct information.

* Doc: [https://github.com/OpenNebula/docs/blob/one-6.0-maintenance/source/intro_release_notes/release_notes_enterprise/resolved_issues_602.rst](url)

* PR: [https://github.com/OpenNebula/one-ee/pull/1240](url)

Hello,
The first link leads to a page listing resolved issues in 6.0.2. None of them seem to apply to this case, according to the title.
The second link leads to a non-existing web page.
Did I miss anything? Can you please provide some info?
Thank you very much

OK, now I see you edited that page and now it shows this issue in the list of resolved issues for 6.0.2.
So, I assume that 6.0.2 will deliver the proper bug fix.
Thank you


Include Alice in Wonderland Stylised graphics

In-keeping with the style of the text and the prevalence of execute @outoftardis suggested that we add some Alice in Wonderland-styled graphics.
We need something very schematic, preferably in the style of a book illustration that could be put as a watermark on the page, rather than a graphic.
Drawings that we need

[ ] Red queen ordering an execution
[ ] White rabbit with a pocket watch
[ ] As separate characters

[ ] Alice,
[ ] Mad Hatter,
[ ] March Hare,
[ ] Dormouse
[ ] Playing cards

[ ] Alice and Mad Hatter's tea party, where the Mad Hatter pours too much tea into Alice's cup.

low priority


Improve painfully slow place method in WordCloud

specifically the double for loop

I think it's worth looking at some other implementations of this. For example, WordCram has WordPlacers, which suggest a place to put a word - and if that place doesn't work, there are WordNudgers, which nudge the word in some direction according to their individual strategy.

@Namnodorel Thanks. I will do. I really wish I just did this when I first started building this thing. I was just hacking it out for fun at first. :)


Issue 1160: remove redundant as imports

I still have an open question as to how this logic would be expected to interact with "keep_direct_and_as_imports", specifically when it is False.
This behavior is changed, but to me the result is pretty obvious
import isort
import isort as isort
# now produces -->
import isort

This behavior is also changed, and IMO makes for cleaner code, but would probably surprise me if I had used the keep_direct_and_as_imports=False option.
import isort as isort
# now produces -->
import isort

Given that the above, simpler code, was achieved without additional special cases in output.py, and that I opened #1192, I have submitted with this new behavior.

@ucodery this import x as x syntax is used in mypy with https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport

@graingert interesting, it is good to see some documentation why this shadowing is used in some places. Given the MyPy convention, would you still agree that the first example is correct? I still see two import lines importing the same thing, and not changing the namespace, as a lint error, and I still see defaulting to the shorter as more straightforward.

Thanks for all the input and work here! Took the ideas, and additional feedback, and this is now incorporated under this flag: https://timothycrosley.github.io/isort/docs/configuration/options/#remove-redundant-aliases


Peculiar velocities or magnitudes

An implementation of the peculiar velocity (or peculiar magnitude) correlation function.  Reference is Equation 29 in https://arxiv.org/pdf/1012.2912.pdf.

Hi @philbull .  I suggest using as default the truncation given in Huterer et al. https://arxiv.org/pdf/1611.09862.pdf
We therefore assume max = 20 if cos(θ) < 0.95 and max = 200 otherwise
Although the truncation could be user configurable.
I do not believe that any flat-sky approximation is used for the equation in question.
Finally, the application in question assumes spectroscopic redshifts, which effectively have delta-function uncertainties.  The science is not feasible in the LSST era with photo-z uncertainties.

@AlexGKim - can I ask if this is still something you would want? Sorry this issue has been hanging so long.

@c-d-leonard yes, this is something we still want to include, and the peculiar velocity folks have expressed more interest on it lately. I'd actually try to make this happen soon-ish

Okay, good to know. Do you think it would make sense to include it in the v3 milestone? (v3 is basically the proxy for the version we want for paper 2).

If we could do it quickly enough...

Having it sooner than later would be great.  I am unfamiliar with CCL but if you need help let me know.

@AlexGKim Based on previous experience our main bottleneck is gonna be getting a benchmark (i.e. the observable calculated with a different code to compare with)

@damonge .  For example, you would like the correlation function as a function of redshift for a fiducial cosmology?  I ask because I probably don't have the benchmark you are looking for (the reason I am interested in the CCL!) so we will have to engage others.

@AlexGKim yes that's about right - from an independent code. This can be anything from another existing public code base to something somebody has sitting on their laptop from a project five years ago and is willing to put public on github. I'm guessing someone in the supernova group will have at least some version of this coded up somewhere?
Also, just to check - I'm guessing this really does need the full bessel function treatment as in eq 29 of the linked paper since we are talking about the correlation for individual SN redshifts right? there's no equivalent to the Limber approximated version here?


Errors: Ability to suppress a single line

This allows the user to suppress errors on a single by appending a trailing comment in the format // jscs: ignore requireSemicolons
Fixes #1372 - issue
Possible edgecase that I've not handled:
var a = 1
// jscs:disable requireSemicolons
var b = 2
var c = 3
var d = 4 // jscs:ignore requireSemicolons
var e = 5
var f = 6 // should it be enabled or disabled here?

Awesome. Thanks for contributing! Without reviewing your PR just yet and looking at the edge case, the jscs:disable (without a matching jscs:enable should disable jscs for the entire file. The jscs:ignore, in that case, is redundant. As for the question on var f = 6, it should be disabled due to the jscs:disable comment.

Coverage increased (+0.0%) to 99.17% when pulling 4950f5d9b1710204e0e3e2ba390c159a01552523 on lpil:ignore-line into f963cd496d4e5d89bb8ffee9abc1c8114b69f41f on jscs-dev:master.

OK. In which case I think I need to know whether the rule or rules in question is enabled or disabled at that point in time.
I could split the list of rules and then check each with isEnabledRule, but that doesn't seem quite right somehow. Do you have any suggestions? Otherwise I'll keep playing about and see if I can find something that feels nicer.

Coverage increased (+0.0%) to 99.17% when pulling 426c929bf9373c4e3713ac6a0bba5b8b87097ce5 on lpil:ignore-line into f963cd496d4e5d89bb8ffee9abc1c8114b69f41f on jscs-dev:master.

Coverage increased (+0.0%) to 99.17% when pulling 140b7ed2379f7718e6477776b89c6b306d252bc6 on lpil:ignore-line into f963cd496d4e5d89bb8ffee9abc1c8114b69f41f on jscs-dev:master.

I've made the trailing ignore comment require a rule always. This is largely due to the behaviour of enabling/disabling all and specific rules in the same area being poorly defined.
It's also nice as it discourages the user from being heavy handed with ignoring rules.
What are your thoughts?

Coverage increased (+0.0%) to 99.17% when pulling 8e183a41fd152d926f1b62eea0e0dd1c0a13b4b5 on lpil:ignore-line into f963cd496d4e5d89bb8ffee9abc1c8114b69f41f on jscs-dev:master.

Also, the most important thing :-), could add a note to the docs about this feature?

There you go.
I wasn't entirely sure what to say about the regexes, let me know what you think. :)

For some reason coverage decreased, but changed js-file is still 100%, so i landed it regardless.
Anyway, awesome! Thank you :-)

Thanks! :D :dancer:


Create Indexes for All Products

All products that provided datasets are now indexed. I have created functions for all the functions, and added them to 2 groups.
The amount of datasets that will be indexed is also customisable by providing the variables INDEX_LIMIT.

@alexgleith When I ran it now I managed to get it at around 17 minutes.


[EnhancedTextArea] Remove style-propable mixin

Removed overprotective behavior that overrides user provided style (comment)

Awesome :+1: Thanks :grin:

Related to #3059. If that issue describes the correct behavior, this PR should be changed, I didn't see changes in the commit referenced when I was migrating.

@newoga Thanks!


Spam upgrade feature

Fully implemented spam feature and unit tests

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


IOS attachment image not showing

I have tried to show push notification with an image in it for ios,
Current Behaviour:  only the text and body displayed in the notification.
Expected Behavior: text, body and image should be displayed in the notification
React native version: 0.70.3
Notifee version: 7.5.0
notifee.displayNotification({
    title: 'Notification Title',
    body: 'Main body content of the notification',
    android: {
      channelId,
      smallIcon: 'name-of-a-small-icon', // optional, defaults to 'ic_launcher'.
      // pressAction is needed if you want the notification to open the app when pressed
      pressAction: {
        id: 'default',
      },
    },
    ios: {
      foregroundPresentationOptions: {
        badge: true,
        sound: true,
        banner: true,
        list: true,
      },
      sound: 'default',
      interruptionLevel: 'timeSensitive',
      attachments: [
        {
          url: 'https://gcdnb.pbrd.co/images/PeKIc9bwelSH.jpg',
          thumbnailHidden: false,
        },
      ],
    },
  });

Hi, as you are setting the thumbnail to false, does the image show when you expand the notification?

Hi, No, The notification is not expandable.

Have you tried with thumbnail set to true?

Thank you @helenaford, I will try

Hi @helenaford, I mixed a native code with a previously integrated notification library. After a code clean up it worked. Thank you for your time.

for me, it was JPEG file not working vs JPG, PNG all work fine.

I was wrong.
I turned out some images are failing to be rendered and don't know why.
this works
https://storage.googleapis.com/ttopet-uploads/uploads/thumbnail_2a8d9fd2_b781_482b_952e_36986bb0e891_95da91b749/thumbnail_2a8d9fd2_b781_482b_952e_36986bb0e891_95da91b749.jpeg
this does not work
https://storage.googleapis.com/ttopet-uploads/uploads/thumbnail_hello_755c44ce00/thumbnail_hello_755c44ce00.jpeg
These are the same files tho...

2024-01-18 22:43:21.246110-0800 TtoPet73[18769:26124771] NotifeeCore: An error occurred whilst trying to resolve an attachment {
    id = kZFIElNv0spdgpNaxURR;
    thumbnailHidden = 0;
    url = "https://storage.googleapis.com/ttopet-uploads/uploads/thumbnail_hello_755c44ce00/thumbnail_hello_755c44ce00.jpeg";
}: Error Domain=UNErrorDomain Code=101 "Unrecognized attachment file type" UserInfo={NSLocalizedDescription=Unrecognized attachment file type}
2024-01-18 22:43:21.270144-0800 TtoPet73[18769:26124774] 10.19.0 - [FirebaseMessaging][I-FCM019001] Analytics logging is disabled. Do not log event.
2024-01-18 22:43:21.271478-0800 TtoPet73[18769:26124774] 10.19.0 - [FirebaseMessaging][I-FCM006000] Received message missing local start time, not a contextual message.
2024-01-18 22:43:22.320243-0800 TtoPet73[18769:26124189] [javascript] \^[[95m오후 10:43:22 | DEBUG : OPEN APP WITH NOTI EVENT
{

I can follow up with the xcode log
Thanks for directions @helenaford helenaford

solved the issue, listed here https://github.com/invertase/notifee/issues/968


Application to plot and compare sim_telarray histograms

I implemented this application to plot and compare sim_telarray histograms because it will be useful to test the muon simulations.
I had to implement a couple of new functions in SimtelHistograms.
The application accepts multiple lists of files and plot the histograms side-by-side.
See example here

The example is here https://desycloud.desy.de/index.php/s/PotmRqAc9DQYqWG


Telemetry : Fix for #902

What this PR does / why we need it:
Add description in GET url response
remove url from the name
Which issue this PR fixes
https://github.com/opensds/opensds/issues/902

@skdwriting @wisererik @leonwanghui

Can u solve the commits burden? It seems that some commit are conflict.


Unpack files

Unpack files but excluded from search and allow to be switched on in query

Open todo's:

[ ] Add is_expanded_file to the index
[ ] Output is_expanded_file for NPPO
[ ] Create parameter that filters on is_expanded_file

Won't fix as solutions would always harm suggestions and search results. Instead Main will be managing the multi-file product scenario.


added navbar and improved the alignment

I have resolved #152
I have aligned the items and added a navbar.
for your reference:

@Pv200 the issue was not assigned to you. Please don't submit PR for issues not assigned to you. This will not be entertained in future.


Deleting master1 destroys cluster

I have a setup of 3 master nodes and 1 worker and have a working cluster with name franz
masters_pool:
  location: fsn1
  instance_type: cx21
  instance_count: 3
worker_node_pools:
- name: test
  location: hel1
  instance_type: cx31
  instance_count: 1

If a delete master1 on hetzner console, and also execute kubectl delete node _franz_-cx21-master. I would expect to keep the same cluster with a replacement of master1 after run of hetzner-k3s create --config ./hetzner-k3s_cluster_config.yaml.
The script hangs in Deploying k3s to worker franz-cx31-pool-test-worker1... step, if i execute kubectl get nodes I get
NAME                 STATUS   ROLES                       AGE   VERSION
franz-cx21-master1   Ready    control-plane,etcd,master   11m   v1.26.12+k3s1

The original cluster is gone :(
Validating configuration......configuration seems valid.

=== Creating infrastructure resources ===
Network already exists, skipping.
Updating firewall...done.
SSH key already exists, skipping.
Placement group franz-masters already exists, skipping.
Placement group franz-test-1 already exists, skipping.
Server franz-cx21-master2 already exists, skipping.
Server franz-cx31-pool-test-worker1 already exists, skipping.
Server franz-cx21-master3 already exists, skipping.
Creating server franz-cx21-master1...
...server franz-cx21-master1 created.
Server franz-cx21-master1 already exists, skipping.
Waiting for successful ssh connectivity with server franz-cx21-master1...
Server franz-cx21-master2 already exists, skipping.
Waiting for successful ssh connectivity with server franz-cx21-master2...
Server franz-cx21-master3 already exists, skipping.
Waiting for successful ssh connectivity with server franz-cx21-master3...
Server franz-cx31-pool-test-worker1 already exists, skipping.
Waiting for successful ssh connectivity with server franz-cx31-pool-test-worker1...
...server franz-cx21-master2 is now up.
...server franz-cx21-master3 is now up.
...server franz-cx31-pool-test-worker1 is now up.
...server franz-cx21-master1 is now up.
Load balancer for API server already exists, skipping.

=== Setting up Kubernetes ===
Deploying k3s to first master franz-cx21-master1...
[INFO]  Using v1.26.12+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.26.12+k3s1/sha256sum-amd64.txt
[INFO]  Downloading binary https://github.com/k3s-io/k3s/releases/download/v1.26.12+k3s1/k3s
[INFO]  Verifying binary download
[INFO]  Installing k3s to /usr/local/bin/k3s
[INFO]  Skipping installation of SELinux RPM
[INFO]  Creating /usr/local/bin/kubectl symlink to k3s
[INFO]  Creating /usr/local/bin/crictl symlink to k3s
[INFO]  Creating /usr/local/bin/ctr symlink to k3s
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  systemd: Starting k3s
Waiting for the control plane to be ready...
Saving the kubeconfig file to /Volumes/Development/IFX/deployments/franz/kubeconfig...
...k3s has been deployed to first master franz-cx21-master1 and the control plane is up.
Deploying k3s to master franz-cx21-master2...
Deploying k3s to master franz-cx21-master3...
[INFO]  Using v1.26.12+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.26.12+k3s1/sha256sum-amd64.txt
[INFO]  Using v1.26.12+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.26.12+k3s1/sha256sum-amd64.txt
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s.service
[INFO]  systemd: Enabling k3s unit
[INFO]  systemd: Starting k3s
[INFO]  systemd: Starting k3s
...k3s has been deployed to master franz-cx21-master3.
...k3s has been deployed to master franz-cx21-master2.
Deploying k3s to worker franz-cx31-pool-test-worker1...
[INFO]  Using v1.26.12+k3s1 as release
[INFO]  Downloading hash https://github.com/k3s-io/k3s/releases/download/v1.26.12+k3s1/sha256sum-amd64.txt
[INFO]  Skipping binary downloaded, installed k3s matches hash
[INFO]  Skipping installation of SELinux RPM
[INFO]  Skipping /usr/local/bin/kubectl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/crictl symlink to k3s, already exists
[INFO]  Skipping /usr/local/bin/ctr symlink to k3s, already exists
[INFO]  Creating killall script /usr/local/bin/k3s-killall.sh
[INFO]  Creating uninstall script /usr/local/bin/k3s-agent-uninstall.sh
[INFO]  env: Creating environment file /etc/systemd/system/k3s-agent.service.env
[INFO]  systemd: Creating service file /etc/systemd/system/k3s-agent.service
[INFO]  systemd: Enabling k3s-agent unit
[INFO]  systemd: Starting k3s-agent

My guess is, that in case of not existing master1 first_master should be set to master2, and therefor the k3s_token should be read from master2 or master3

Or
getter first_master : Hetzner::Server { masters[0] } should be executed before === Creating infrastructure resources === step

Sorry for the delay. This is indeed a scenario I hadn't come across. What you suggest might work the first time when master1 is being recreated so we use say master2 as the first master, but then not sure what this would cause when running the create action again after master1 became operational again. It requires some thinking and proper testing.

My solution is https://github.com/vitobotta/hetzner-k3s/pull/312 . I have successfully deleted and recreated master1.

@cwilhelm let's continue this discussion in the PR.

@cwilhelm I have finished work on the release candidate for v2, which include some more robust handling of these scenarios. Would you be able to help with testing? See this discussion for more info on v2 https://github.com/vitobotta/hetzner-k3s/discussions/385


Display of asset URLs and checksums can cause confusion

The current display of the asset URLs and checksums can cause confusion on which link pairs with which checksum. I illustrate this in the below screen shot:

As a user, if I begin at the top or the bottom of the asset list, I can see the pairings properly. But if I am looking for a build for an architecture in the middle, see the fourth red box 4, it isn't apparent what they pairs are. This can lead to mismatched download links and check sums.
Possible solution: Add a line to break it up or even a background box of a different color. I am not a frontend person, so not sure of the technical terms there for web dev.

@rgeniesse I like the idea of dividing by a horizontal light grey border to provide some visual differentiation between the items.  CC @pzupan

Pull request #138


V0.1.11 fails to write to Chrome Console

Tested V0.1.11 today. It works in Firefox V66.0.3. It does not work in Chrome. My version of Chrome is Version 73.0.3683.103 (Official Build) (64-bit)

Make sure your filters are set up correctly. This is probably the same issue as #16 and #7 — you need to actually ask Chrome to show verbose logs.

Indeed. As mentioned in  issue #16, a note in the readme telling users about the difference between chrome and the others would be a good idea. Just copy in the verbiage and reference the image from #7. Such a note in the documentation would have saved me a quite a bit of time and saved the authors/maintainers from Yet Another Logged Issue That Is Actually A User Error :-). Thanks for this library!


Include the user id in the rating table, and returns the user id, score and the comment, in the comments return of the rating API

Returns the user id and user score in the rating API response, in addition to the user comment. To do this, there has to be an user id in the rating table. This is necessary to make the design made in Figma.

Okey, I'm working.

@vicetr3s, I'm not sure we should include those things, since they're not mentioned in the professor's document. I think returning the score for each comment is fine, but returning the user ID might not be, as it could be related to maintaining the anonymity of the reviewers, for example.

@fraco-oxza Yes, you are right about the user id, I have thought about it and is going to be complicated maintaining the anonymity given the endpoints we have right now.  Having the individual score will be enough.


[Hidden] mdDown is shown when width is md on implementation=css

Regarding the docs  components with property mdDown  should not be shown:

If true, screens this size and down will be hidden.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

maybe related to #8172 and #6767
Expected Behavior
<Hidden mdDown> components must not be displayed when withStyles() returns width: "md"
Current Behavior
Content is shown.
Neither Safari's nor Chrome's "inspect" shows that the media query for class MuiHiddenCss-mdDown is matched.
Steps to Reproduce (for bugs)
https://codesandbox.io/s/7wlyw4y8m0

change window size in project view

Your Environment

Tech
Version

Material-UI
1.0.0-beta.2

React
16.2.0

browser
Safari 11.0.1, Chrome 64.0.3278.0

If you confirm that this is a bug, please give me a hint where to fix it.

I confirm, the JS implementation is correct, not the CSS one 😱 .

Wait, no. It's the other way around! The JS implementation is not correct. It's should be inclusive=false so both isWidthDown() and theme.breakpoint.down() behave identically.
https://github.com/mui-org/material-ui/blob/d81f1a94b0534b476e7ed5eb992e347c301f1513/src/utils/withWidth.js#L34

I do agree to #9420 in terms that the css behaviour is more intuitive, but regarding the docs the js implementation is now not correct. I’ll look at the withWidth and may send a PR.

Are you sure it's fixed?
If you look at the examples on https://material-ui.com/layout/hidden/ it seems wrong i.e. it's actually doing the opposite of what's written. 'Breakpoint Up' for example should hide the the children above a certain breakpoint. The exact opposite is the case i.e. it's shown. Same for the 'Breakpoint Down' example.

@markusgattol We should probably change the demo, it's confusing!

It is. If what's shown on this page is actually correct then it's explained/shown in a way that makes you think it's the inverse what's written vs what the demo shows.


README and code samples out of date

Hey there... Great package! Thanks for building it. It's very useful.
I'm linking to your package in an article of mine, so it'd be really great if you could find a few minutes to update the sample code that displays on Pub and the Github page to be current. Looks like the Firebase constructor takes a Uri reference instead of a string now, etc.
Thanks!

Thanks for pointing this out to me (and thanks for the citation).
Should be fixed now.


Maven Dependency spring-cloud-config-client causes issues with spring-boot-autoconfigure in Cloud Foundry

Summary
I was trying to get a spring-cloud-configuration-server running in our cloud environment. When extending an existing component with the maven dependency spring-cloud-configuration-client to make it consume the configuration from the configuration server, the application startup failed with the following error:
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT ***************************
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT APPLICATION FAILED TO START
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT ***************************
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Description:
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Failed to configure a DataSource: 'url' attribute is not specified and no embedded datasource could be configured.
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Reason: Failed to determine a suitable driver class
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Action:
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Consider the following:
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT     If you want an embedded database (H2, HSQL or Derby), please put it on the classpath.
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT     If you have database settings to be loaded from a particular profile you may need to activate it (no profiles are currently active).
   2018-10-10T09:28:51.91+0200 [APP/PROC/WEB/0] OUT Exit status 1

I've created the minimal application to reproduce the error. See steps below.
Steps to reproduce
Step 1
Create a minimal spring-boot application using a database:
pom.xml
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>com.example</groupId>
    <artifactId>spring-config-demo</artifactId>
    <version>1.0-SNAPSHOT</version>

    <parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>2.0.5.RELEASE</version>
    </parent>

    <dependencies>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-web</artifactId>
        </dependency>

        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-data-jpa</artifactId>
        </dependency>
        <dependency>
            <groupId>org.mariadb.jdbc</groupId>
            <artifactId>mariadb-java-client</artifactId>
        </dependency>

    </dependencies>

    <build>
        <plugins>
            <plugin>
                <groupId>org.springframework.boot</groupId>
                <artifactId>spring-boot-maven-plugin</artifactId>
            </plugin>
        </plugins>
    </build>

</project>

DemoApplication.java
package com.example.spring_config_demo;

import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;

@SpringBootApplication
public class DemoApplication {

    public static void main(String[] args) {
        SpringApplication.run(DemoApplication.class, args);
    }
}

DemoController.java
package com.example.spring_config_demo;

import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.web.bind.annotation.RestController;

@RestController
@RequestMapping("/")
public class DemoController {

    @RequestMapping(method = RequestMethod.GET)
    public String helloWorld() {
        return "Hello World";
    }
}

Step 2
Build and deploy application to your cloud foundry environment. Create a MariaDB service and bind it to the application. Restart the application and check if the logs are fine.
Step 3
Add the dependency spring-cloud-configuration-client to the pom.xml, build and deploy the application
Dependency:
<dependency>
    <groupId>org.springframework.cloud</groupId>
    <artifactId>spring-cloud-config-client</artifactId>
    <version>2.0.1.RELEASE</version>
</dependency>

Expected result
The application should start up without any change in behavior.
Actual result
The startup of the application fails with the following message:
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT 2018-10-10 07:28:51.827 ERROR 8 --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   :
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT ***************************
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT APPLICATION FAILED TO START
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT ***************************
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Description:
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Failed to configure a DataSource: 'url' attribute is not specified and no embedded datasource could be configured.
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Reason: Failed to determine a suitable driver class
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Action:
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT Consider the following:
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT     If you want an embedded database (H2, HSQL or Derby), please put it on the classpath.
   2018-10-10T09:28:51.82+0200 [APP/PROC/WEB/0] OUT     If you have database settings to be loaded from a particular profile you may need to activate it (no profiles are currently active).
   2018-10-10T09:28:51.91+0200 [APP/PROC/WEB/0] OUT Exit status 1

Actions taken

Aligned the versions of the dependencies (using spring-boot-starter-parent version 2.0.1.RELEASE)
Rebinding the service
Setting the driver with the property spring.datasource.driver-class-name

Additional Information

I attached the full log of the failed application startup startup.log
As far as I can tell we are using cloud foundry with these versions: Portal 4.10.6 - EXT API 4.10.1 - CF API 2.121.0
MariaDB version: 10.1.22

Can you please retry using the Spring Cloud BOM?

I've added spring-cloud-dependencies to my pom and removed the version of the spring-cloud-config-client:
    <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>org.springframework.cloud</groupId>
                <artifactId>spring-cloud-dependencies</artifactId>
                <version>Finchley.RELEASE</version>
                <type>pom</type>
                <scope>import</scope>
            </dependency>
        </dependencies>
    </dependencyManagement>

The result is still the same.

Is there additional information I can provide to support the analysis?

Not at the moment.  The team is a little busy doing releases this week, we need to find some time to look at it.

Switched to Finchley.SR2 and added spring.cloud.refresh.extra-refreshable=javax.sql.DataSource, same result. Here is a link to a repo containing the code required to reproduce the issue containing the latest suggested fixes: https://github.com/Huo12345/spring-cloud-config-issue-1161-demo

Im still not sure how to reproduce this given I cant deploy it to PWS.  Is it only present when using MariaDB or could another DB be used?

I was able to reproduce the issue with docker. With this I could check if the issue occurred with a different relational database, MySQL in this case, and I saw the same error in the log. Originally I thought that the issue was custom to cloud foundry since it didn't occur on my computer. I've added all files required for testing with docker to the repository. There are comments in application-docker.properties, docker-compose.yml and pom.xml to switch between MariaDB and MySQL.

Sorry for all the back and forth, but when I tried to start the containers with docker-compose up --build either using MySQL or MariaDB I get
Failed to configure a DataSource: 'url' attribute is not specified and no embedded datasource could be configured.

From the app.
Also when starting MariaDB I get
db_1      | error: database is uninitialized and password option is not specified
db_1      |   You need to specify one of MYSQL_ROOT_PASSWORD, MYSQL_ALLOW_EMPTY_PASSWORD and MYSQL_RANDOM_ROOT_PASSWORD

I've added some environment variables to the DB container to have valid account to access the container. There is still the same error while starting up the DB container, but when testing the access, the credentials are valid. For the error message in the app, to me it looks the same as the error message I reported having on cloud foundry.

Thanks.
When I take spring-cloud-config off the classpath I still see the error, so I dont see how it has anything to do with spring cloud config.

You are right, the error in the startup was caused by me using the wrong parameter to set the spring profile in the startup of the docker container. When changed the container starts just fine, so unfortunately the error cannot be reproduced with docker. But putting the jar working with docker on our cloud foundry instance still causes an error in startup. The changes are in the repository.
I've compared the startup logs of the docker container and the cloud foundry container and stumbled upon two additional log entries:
INFO 9 --- [           main] o.c.r.o.s.c.s.r.PooledDataSourceCreator  : Found HikariCP on the classpath. Using it for DataSource connection pooling.
INFO 9 --- [           main] o.c.reconfiguration.CloudServiceUtils    : 'dataSource' bean of type with 'javax.sql.DataSource' reconfigured with 'Application Key DB' bean

This leads me to believe that the data source gets loaded correctly. Talking to a college I learned that there seems to be more than one application contexts in a spring application when using cloud configuration. Is it possible that data source is only loaded in one context, but not the other?
As an additional test I defined the jdbc properties that should be injected through cloud foundry as properties and the startup error went away.

Can you try setting spring.cloud.refresh.enabled=false and trying again?

Setting the spring.cloud.refresh.enabled property to false lets the container start up without any errors. I will need to do some further testing since we aim to use the refresh scope.

Use refresh scope or rebind @ConfigurationProperties?

Thats good, that gives me a better idea of what the problem might be then.  Unfortunately I am not sure what the right solution is, I will have to talk it over with the team.


fix egrep rule and ncat rule

fixed the grep binaries list that had egre instead of egrep
added the ncat command line arguments -c and -e that can be used to spawn remote shells
Launching this :  ncat -l localhost 4443 -e "/bin/ls"
would not match anything when running: sudo sysdig "proc.name = \"ncat\" and (proc.args contains \"--sh-exec\" or proc.args contains \"--exec\")"
using sudo sysdig "proc.name = \"ncat\" and (proc.args contains \"--sh-exec\" or proc.args contains \"--exec\" or proc.args contains \"-e\")" fixes this

The cause of the test failures was a recent sysdig change that I fixed with https://github.com/falcosecurity/falco/pull/646, and not due to the rules, so I'll go ahead and merge.


Map packaging to non-optional

Fixes #2377.  Depends on https://github.com/coursier/test-metadata/pull/8.

Hey @alexarchambault (or @julienrf) any chance this could be reviewed, merged and released, please?

@dwijnand I'll have a closer look later, but at first sight, this is not a trivial change… Packaging has been optional on purpose. Some dependencies do miss a JAR, and they shouldn't fail.
About the repo linked in https://github.com/coursier/coursier/issues/2377, I'd need to have a closer look, but at first, I'd assume the repository to be broken.

That said, if I read https://github.com/coursier/coursier/issues/2377#issuecomment-1309691107 correctly, and if your change is only about the case where the dependency has an explicit <packaging>jar</packaging>, that might work…

I agree with @julienrf comments. I'd like to take the time to understand why the databind and the scala-xml changes are necessary

AFAIU, this PR may not completely address the linked issue because it will not, by default, expand dependency descriptors to type=jar,optional=false.

I don't know what that means, outside of not making packaging=jar non-optional..

I don't know what that means, outside of not making packaging=jar non-optional..

I might be missing something, but what I meant is that with this PR Courser will not set the packaging to jar by default when reading dependences from a pom. It will still have to be specified in the pom. Probably, this is fine and should not hold this PR.

I'll try to find time to have a closer look in the coming days (until next Monday say, don't merge until then)

Thank you ❤

So I had a closer look at the changes in test fixtures that looked suspicious. https://github.com/coursier/coursier/pull/2776 and https://github.com/coursier/coursier/pull/2777 deal with those. I just pushed a rebased version of the original code of this PR, and the diff looks much nicer now 🎉
I don't feel like writing a long explanation about this right now, given it's quite late for me 😬 I might tomorrow or later during the week.
In any case, thanks for having pushed for this, @dwijnand! I'll merge if the CI gets green (it should), and this'll be part of the next release.

Very nice, thank you.  It's green, btw.

@alexarchambault could we merge this, please?


Generate only simple assignments in verilog backend

Yosys currently emits assigns with a concatenated expression on the LHS in form like:
assign {a,b} = {c,d,e};
this change generate instead (note that size is taken into consideration):
assign a = {c, d};
assign b = e;
This fixes issue #1286

Seems reasonable, would be good to double check that it works correctly when dealing with 'upto' wires or non-zero start offsets

Changing this by default would negatively impact nMigen because it relies on Yosys-produced Verilog being relatively human-readable. Adding an option to enable this behavior seems fine though.

Please keep the old behavior and make the new behavior opt-in.

@whitequark sure, any idea for good option name ?

Seems reasonable, would be good to double check that it works correctly when dealing with 'upto' wires or non-zero start offsets
Good idea, will make some more test cases.

@daveshah1 Seams good to me with next example :
module a();
wire [1:2] b;
wire [3:1] c;
assign {b, f} = c;

endmodule
/* Generated by Yosys 0.9+3696 (git sha1 cf67e6a3, clang 11.0.0 -fPIC -Os) /
( cells_not_processed =  1  )
( src = "a.v:1.1-6.10" )
module a();
( src = "a.v:2.13-2.14" )
wire [1:2] b;
( src = "a.v:3.13-3.14" )
wire [3:1] c;
( src = "a.v:5.13-5.14" *)
wire f;
assign f = c[1];
assign b = c[3:2];
endmodule

any idea for good option name ?

-simple-lhs?

One last comment, could you add a simple test for this to CI?

@daveshah1 for consistency sake I will add test in yosys-tests since we need to check generated verilog at the end

@daveshah1 added https://github.com/YosysHQ/yosys-tests/commit/d323bec22d076f673e97800b5267dd0d5403f715 (note I also did additional commit to fix eol :) )


Fix Genres padding on activity updates

The in-line list of genres on activity updates has a padding-right which makes it look awkward and makes genres use way more space than needed.
With padding:

Without padding:

Caused by a CSS override here:
.inline-list li,
.update-panel .genre-list li {
    display: inline-block;
    float: left;
    padding-right: 10px; /* This line */
}

.update-panel .inline-list li,
.update-panel .genre-list li {
    padding-right: 0;
}

Can you send a PR?

Can you send a PR?

Aye, just made it an issue due to noticing it while on phone...also because the css that's overriding it is in the base.scss and I couldn't check where else it was used.
https://github.com/hummingbird-me/hummingbird/blob/1b9a321a9e5c8718f35abc17a76eddbebcf0b63b/app/assets/stylesheets/base/base.css.scss#L55


NETOBSERV-1632: metrics API, allow empty unit

Description

Dependencies

n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[x] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?

[ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[x] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.06%. Comparing base (e19e733) to head (301d297).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   67.01%   67.06%   +0.05%
==========================================
  Files          68       68
  Lines        7783     7783
==========================================
+ Hits         5216     5220       +4
+ Misses       2192     2190       -2
+ Partials      375      373       -2

Flag
Coverage Δ

unittests
67.06% <ø> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/approve


added excepted files and getting user by name instead by ID

I managed to exclude the lines from files like package.json or package-lock.json. Also I made that the user has to input only the name of the user to look for, not the ID.

@Ti7oyan There are several bugs in your PR. Some of them are:

Some Repositories are not counted yet. They just return error.
you used 'dRepository' instead of 'd'
leaving the username field blank raises an error.

Please fix them. Thank you!

I'll be working on it, thank you!

I fixed the user find and re-implemented the logic behind excluding files. Now it excludes all of the files in node_modules folder. The only thing that's bugging now is that in some repos returns 'NoneType' object has no attribute 'id'. I think that it has something to be with the commit object.

For some reason, if we try to pass the two conditions at the same time both type of files, excepted and node, are being passed and count. So, putting them in separated statements work. Maybe there is a way to reduce the code, but this does the work.

@Ti7oyan, Now it counts everything wrong!

And if we go back to the is False statement?

And if we go back to the is False statement?

I tested in both scenarios!

How are you testing it? in my account works fine. Without the checks it shows like +150k and with them not more thant 55k

How are you testing it? in my account works fine. Without the checks it shows like +150k and with them not more thant 55k

I am trying to spot the issue... Here is an example of a Repository which is wrongly counted: https://github.com/Ananya-0306/Jarvis-desktop-assistant

I really don't know about that, I can tell you that all of my repos that have node_modules are OK. Tell me if you know anything more!

I spotted the Bug! It is likely because, when we get the total number of additions or deletions in a file, it returns overall stats, not stats in a single commit alone! Since this is put in a for loop based on commit, this issue occurred, I am working on this!

Nice! Let me know if you got something!.

@Ti7oyan, It is not a bug! I saw my commit history and found this: https://github.com/Ananya-0306/Jarvis-desktop-assistant/commit/d2db743753e58d45b1b1b3f4608ed989a21b66b1. I think Github did not count these lines in contributors graph because this is a license file.

The code doesn't make anything to license files so maybe they are excepted, like you say!

Hooray! Now, there isn't much difference in number of lines! I still wonder why there is a difference :thinking: ?

Hi!, maybe we can go further testing different instances of the loop, but in general terms, we are good!


Error trying to download a package with custom colors

After the cursor are generated i push download, then XCursors then the various cursors are processed and it ends up on an error page:
{ "error": [ "Empty build directory", "[Errno 2] No such file or directory: '/tmp/bibata-builds/171ff290-7958-48f1-bbb0-0f082db2de2b/Bibata-171ff/cursor.theme'" ], "id": "171ff290-7958-48f1-bbb0-0f082db2de2b",

Closing due to inactivity. Can reopen later.


[ci] Disable flaky ethosu tests

See #10487
Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@driazati would it be possible to disable only the failing tests ? (See https://docs.pytest.org/en/latest/how-to/skipping.html#skip-xfail-with-parametrize)


doesn't find paper-button

error GET http://localhost:5000/bower_components/pf-calendar/bower_components/paper-button/paper-button.html

Paper button Import fixed


Update VisualStudio.gitignore

These three files need to be ignored when using Visual Studio 2019.
Here they are: .sln、.vcxproj、*.vcxproj.filters
Thanks.
Reasons for making this change:
TODO These three files need to be ignored when I using Visual Studio 2019,
they will be uploaded to the repositories
Links to documentation supporting these rule changes:
TODO
If this is a new template:

Link to application or project’s homepage: TODO

I agree with the .vcxproj and .vcxproj.filters, but not the .sln. Thought this is / was a core VS project file? 😕


Folowing readme results in multiple errors

System Details

posh-git version/path: 0.7.x
PowerShell version: 5.1.18362.752
git version 2.26.2.windows.1
OS: Microsoft Windows NT 10.0.18363.0

Issue Description
First error one encounters is that -AllowPrerelease is not a valid flag of PowerShellGet\Install-Module.
Second and the part is that Import-Module is disabled by default.
Import-Module : File C:\Users\...\Documents\WindowsPowerShell\Modules\
posh-git\0.7.3\posh-it.psm1 cannot be loaded because running scripts is disabled
on this system. For more information, see about_Execution_Policies at
https:/go.microsoft.com/fwlink/?LinkID=135170.

For the version of posh-git you are on, you want to use this version of the readme: https://github.com/dahlbyk/posh-git/tree/v0 master is set to our latest v1 version.  Or upgrade to v1.

I was instaling a fresh copy on a computer, but it will not download v1.
Also, there is error if AllowPrerelease is present:
Install-Module : A parameter cannot be found that matches parameter name 'AllowPrerelease'.
At line:1 char:58
+ ... et\Install-Module posh-git -Scope CurrentUser -AllowPrerelease -Force
+                                                   ~~~~~~~~~~~~~~~~
   + CategoryInfo          : InvalidArgument: (:) [Install-Module], ParameterBindingException
   + FullyQualifiedErrorId : NamedParameterNotFound,Install-Module

Looks like you have an older version of PowerShellGet.  You need a newer version of PowerShellGet that supports installing pre-release versions of module.  You can either update PowerShellGet using these instructions OR use Chocolatey to install posh-git.

I do have the PowerShell you get with fresh Windows 10 install...

What version of PowerShellGet do you have? Get-Module PowerShellGet -List
I have 2.2.3 which has the AllowPrereleaseParameter:

I have version 2.2.1, It got installed with my computer around a month ago with fresh install

Looks like AllowPrerelease got added in either 2.2.2 or 2.2.3.  Follow the instructions I linked to above to get the latest version of PowerShellGet or use Chocolatey.

That's a bummer, not being able to install it right away :/

Yeah, PowerShell 7 would have a version of PowerShellGet that supports the AllowPrerelease parameter.  This situation will change for PS 5 when we finally release a stable (non-prerelease) version to the PowerShellGallery.


[Outlook] (isSetSupported) 1.3 reported as supported in error for OWA…

… with Exchange 2013
Related to issue https://github.com/OfficeDev/office-js/issues/1287.

Docs Build status updates of commit 7db6ead:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference/objectmodel/requirement-set-1.3/office.context.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/outlook-api-requirement-sets.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Simplified the code for the renderer mixin + small changes to the enum

This commit adds a parameter to the wolf variants enum that specifies the name of the wolf variant, which the renderer uses to get the texture more easily.
I've also removed the pale wolf's textures as they didn't seem necessary to include, opting to use the vanilla textures instead, but if that is a problem they can simply be added back.

Great stuff! I don't think removing the vanilla texture is going to be a problem.
Thanks for the PR!

(I'll make sure to credit you.)


Setuptools doesn't play nice with Numpy

See: https://github.com/numpy/numpy/blob/master/numpy/distutils/extension.py#L42-L52
That functionality was broken by:
https://github.com/pypa/setuptools/blob/master/setuptools/extension.py#L39-L41
In this pr: https://github.com/pypa/setuptools/pull/718
Here's the the pdb session where I debugged this:
(Pdb) old_Extension.__module__
'setuptools.extension'

Oops, I just sunk some time because of this and (wrongly) traced it to #728. Only after creating a simple travis build to illustrate this did I think about looking at the newest issues.
Currently it seems impossible to install numpy from source on a Unix system, as this build illustrates:

It seems like @bcbrown is correct about the location of this problem.

I made pull request #753 for this, not sure why it is not picked up automatically.

Can I also recommend that numpy only pass keyword arguments to Extension (for future simplicity)?

I think this is a good case for PEP 3102 keyword only arguments. Unfortunately they are available only starting with CPython 3. One of the great improvements - in my eyes the API should define if parameters should be passed positional or via keyword to ease backwards compatibility.
I think the best that setuptools can do is to generate a warning when positional arguments are used for the keyword parameters of Extension. Probably my company is not the only Python user that partially has obsolete libraries in use (be it for updates to a legacy branch of the software) but try to use the newest setuptools and pip packages for installing them...

I think this is a good case for PEP 3102 keyword only arguments.

I had the same thought (and same conclusions).

I think the best that setuptools can do is to generate a warning when positional arguments are used for the keyword parameters of Extension.

Seems a good idea.


TypeError: Request with GET/HEAD method cannot have body while running locally

I tried to run the sample code given in README.md. It threw following error after opening localserver in browser:

Versions:
Deno: 1.11.5
OS: Ubuntu (WSL) on Win 10

Hi @borsemayur2 , thanks for reporting the issue!
I would appreciate it if you could answer this question so I can further clarify the situation:

May I see the contents of the script you ran with deployctl?

Here's what I'm suspecting given the information I have so far:

Old hello world?
I've updated the hello world example to a new one. This is because some of the req and res handling has changed between the very first time I published this repo and the first time I released v0.1.0. I just released v0.2.0 so make sure to check that out!

Bad Request from callee?
The error itself reads "Request with GET/HEAD method cannot have body", which implies that a faulty new Request() was called. Kyuko doesn't instantiate new Request objects, so the error is probably being thrown by some other part of the system.
It may be a deployctl specific problem, or something could be wrong with the callee (http request) itself.

1. import { Kyuko } from<EMAIL_ADDRESS>
   const app = new Kyuko();

   app.get("/", (req, res) => {
     res.send("Hello World!");
   });

   app.get("/:name", (req, res) => {
     res.send(`Hello ${req.params.name}!`);
   });

   app.listen();

Here is the script:
import { Kyuko } from "https://raw.githubusercontent.com/rikilele/kyuko/main/mod.ts";

const app = new Kyuko();

app.get("/", (req, res) => {
  res.send("Hello World!");
});

app.get("/:name", (req, res) => {
  res.send(`Hello ${req.params.name}!`);
});

app.listen();

v0.2.0 throws same error.

The issue was with deployctl version (0.1.0). Able to run the code after upgrade to 0.3.0. Thanks.


⚠ Jenkins Plugins Artifactory has degraded performance

In 0691378, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1182 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 587d99c after 46 minutes.


Workflow file provisioning fails

Bug Report
This is for the GA4GH Dream Challenge workflow bcbio_NA12878-chr20, which runs fine with cwltool=1.0.20170217172322
bcbio.json
Expected behaviour
Stage files in /datastore directory so that they can be retrieved
Actual behaviour
File gets hardlinked to ()/datastore/launcher-ef66914e-b880-4d56-b1dc-9432d92afd49/inputs/f7e25976-8b3b-4460-929c-787d64ed8015/hg38.fa.fai
but that's not where the runner looks when it's trying to run:
No such file or directory: '()/datastore/launcher-ef66914e-b880-4d56-b1dc-9432d92afd49/biodata/collections/hg38/seq/hg38.fa.fai
dockstore3.err.txt
dockstore3.log.txt
The reason appears to be that the workflow's JSON specifically states the location of secondaryFiles:
            "class": "File",
            "path": "biodata/collections/hg38/seq/hg38.fa",
            "secondaryFiles": [
                {
                    "class": "File",
                    "path": "biodata/collections/hg38/seq/hg38.fa.fai"
                },
                {
                    "class": "File",
                    "path": "biodata/collections/hg38/seq/hg38.dict"
                }
            ]

Dockstore apparently sees this as a reason to go look for secondaryFiles not in the same directory as the primaryFile.
To verify this, I removed this secondaryFile section from the input JSON - there are many more so I expected this to lead to a similar issue with another file.
my.json.txt
But no, this time it dies with
No such file or directory: '(...)/datastore/launcher-63977c42-f73d-4d3f-bff1-fc8d04b80c2f/biodata/giab/na12878/NA12878-platinum-chr20.bam'
This is a regular (not secondary) file, and this time it's nowhere to be found in launcher-63977c42-f73d-4d3f-bff1-fc8d04b80c2f/inputs
dockstore4.err.txt
dockstore4.log.txt
Steps to reproduce the behaviour
dockstore workflow launch --local-entry main-NA12878-platinum-chr20.cwl --json my.json
Environment (Browser or OS and Dockstore version)
Dockstore 1.2.4 - while writing this I noticed there has been an upgrade, so I did a quick test with 1.2.5 and found the same issues.

Interesting, I ran into this, didn't have a chance to look deeply had thought that this was #563
Thanks for the additional info

bcbio is now functional with Dockstore 1.2.10 as per https://www.synapse.org/#!Synapse:syn10876714


[Vectorize] Remove $vectorize field in the document

If an update come in for $vector field directly, remove $vectorize field in the document if it exist.
@vkarpov15 FYI

"remove" means just set "$vectorize" field as empty string, or delete "$vectorize" field in the whole document?

If the existing document in the DB is, in that case $vector field would have been generated using $vectorize field data
{   "id" : "1",   "name" : "test",   "$vectorize" : "Test data",   "$vector" : [0.25,0.25,0.25] }
and we get a update clause as {"$set" : {"$vector" : [0.11,0.11,0.11]}} where update is directly to $vector field. This should remove $vectorize field too when $vector field is updated. Post update document should look as:
{   "id" : "1",   "name" : "test",   "$vector" : [0.11,0.11,0.11] }

This is a good suggestion, makes a lot of sense. $vectorize and $vector need to stay in sync.


blind-control - overwrite expire not working

Describe the bug
In previous versions a overwrite with a priority over 0 the overwrite did not expire. Now they expire with the default expiration timer. Log message:
Overwrite is set which expires in 1800000ms = 2020-03-30T11:27:51.312Z (no expire defined)
Expected behavior
do not expire overwrites with priority > 0
System information (please complete the following information):

Version 1.0.15
Node-Red Version 1.0.4
Hardware VMware

Regards

This was changed with #127 .
There is a for and again to maintain or change that again. In any case, it now does not match the documentation. I will adapt the documentation.
To have a time never expiring no default expiring time value needs to be set to the node settings or in the overwrite message a msg.expire or msg.payload.expire property needs to be given with a value of -1.

Hi,
thanks for the feedback. I tried to send the manual mode with position -1 and expire -1. this results in the error message: Error: Cannot read property 'overwrite' of undefined

you are right, will fix this asap

thanks for the fast fix :)


fix(nginx) wait for nginx reload to avoid zombies

If a unix process is spawned, the parent process must wait for its pid or the process will become a zombie after exit. This fixes the problem that the /opt/router/sbin/router binary leaves behing a defunct nginx process each time the config is reloaded by spawning "nginx -s reload".
Fixes #331.

@felixbuenemann to the best of my knowledge, no one is actively maintaining the old components of Deis Workflow anymore.


update deployment for k8s v1.16

New daemonset to support k8s v1.16
Moved daemonsets into K8s versions specific dir
Removed redundant/not-used sample deployments
Moved Dockerfile into image/
Removed additional daemonset yaml from docs/dpdk and docs/rdma

@ahalim-intel thanks for the quick fix!
/lgtm


How to do /admin/xx/xx

How can i add sub url
now only /admin/xx

Hello, @Ryan0204 ! Thanks for using our products !

Go in /src/index.tsx and change <Route path={'/admin'}> to your liking
In /src/layouts/**' change the getRoutes, getActiveRoutes, and getActiveNavbar` so they use your path.
In /src/routes.tsx , add your pages while using your own paths for layout and path props.

I hope it helps! Regards, Vlad.