bimap-0.3.1 does not build (Can't make a derived instance of ‘Typeable BimapException’)

Hi! Latest version does not build:
➜  /tmp  cabal get bimap
Downloading bimap-0.3.1...
Unpacking to bimap-0.3.1/
➜  /tmp  cd bimap-0.3.1
➜  bimap-0.3.1  cabal sandbox init
Writing a default package environment file to
/tmp/bimap-0.3.1/cabal.sandbox.config
Creating a new sandbox at /tmp/bimap-0.3.1/.cabal-sandbox
➜  bimap-0.3.1  cabal install
Resolving dependencies...
Notice: installing into a sandbox located at /tmp/bimap-0.3.1/.cabal-sandbox
Configuring stm-2.4.4...
Configuring transformers-<IP_ADDRESS>...
Building stm-2.4.4...
Building transformers-<IP_ADDRESS>...
Installed stm-2.4.4
Installed transformers-<IP_ADDRESS>
Configuring transformers-compat-<IP_ADDRESS>...
Configuring mtl-2.2.1...
Building transformers-compat-<IP_ADDRESS>...
Building mtl-2.2.1...
Installed transformers-compat-<IP_ADDRESS>
Installed mtl-2.2.1
Configuring exceptions-<IP_ADDRESS>...
Building exceptions-<IP_ADDRESS>...
Installed exceptions-<IP_ADDRESS>
Configuring bimap-0.3.1...
Building bimap-0.3.1...
Failed to install bimap-0.3.1
Build log ( /tmp/bimap-0.3.1/.cabal-sandbox/logs/bimap-0.3.1.log ):
Configuring bimap-0.3.1...
Building bimap-0.3.1...
Preprocessing library bimap-0.3.1...
[1 of 1] Compiling Data.Bimap       ( Data/Bimap.hs, dist/dist-sandbox-ea5d7e38/build/Data/Bimap.o )

Data/Bimap.hs:120:22:
    Can't make a derived instance of ‘Typeable BimapException’:
      You need DeriveDataTypeable to derive an instance for this class
    In the data declaration for ‘BimapException’
cabal: Error: some packages failed to install:
bimap-0.3.1 failed during the building phase. The exception was:
ExitFailure 1
➜  bimap-0.3.1  ghc --version
The Glorious Glasgow Haskell Compilation System, version 7.8.4

This is bimap-0.3.1 not building on ghc < 7.10. I added a revision here https://hackage.haskell.org/package/bimap-0.3.1/revisions/ so a cabal update should make older GHCs use an older bimap.
It would be nice if the repository was updated to support older GHCs again, or by adding a base >= 4.8' lower bound. Both would make sure that cabal install bimap` worked for everyone.

Isn't it better to just add DeriveDataTypeable pragma instead of stopping support for 7.8?

I enabled the DeriveDataTypeable extension. I don't have a copy of 7.8 handy, so can you tell me if it works fine now?

Yes, it compiles now, thanks!
If you want to test your project against different ghc versions automatically you can use travis (its free for open source) https://travis-ci.org.
You will need to add .travis.yml file to your project, you can generate it using this script: https://github.com/hvr/multi-ghc-travis


[cmd][xzcatomicswap] Change dumprivkey RPC sequence for Zcoin

Zcoin added a one-time authorization key returned in error string from a first call to dumpprivkey. Along with a warning. The key is used in 1 (one) subsequent call to the same RPC function. The idea is that inexperienced people are warned if scammers propose they use `dumpprivkey'.

This replaces https://github.com/decred/atomicswap/pull/102 which I will close.

If this is acceptable now please merge


[New Port Request] VMime

Library name: vmime
Library description: powerful C++ class library for working with RFC-822 and MIME messages and Internet messaging services like IMAP, POP or SMTP.
Source repository URL: https://github.com/kisli/vmime
Project homepage: https://www.vmime.org/

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


⚠ St. Lawrence Global Observatory CKAN Sitemap has degraded performance

In 15f57aa, St. Lawrence Global Observatory CKAN Sitemap (https://catalogue.ogsl.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 7085 ms

Resolved: St. Lawrence Global Observatory CKAN Sitemap performance has improved in 006c9f0 after 5 minutes.


Symlinks still gets resolved on MacOS

Issue Type: Bug
Testing https://github.com/Microsoft/vscode/issues/59245
Symlinks still gets resolved on MacOS.
Steps:

Create symlink dev -> /%HOME%/Downloads in HOME
Open code-insiders ~/dev
Notice that the symlink has been resolved in the explorer, and editor paths (to Downloads/) but the terminal shows dev

VS Code version: Code - Insiders 1.28.0-insider (fe8d9d2470ddffb9dc2da604b23f5bd8a185cd66, 2018-09-25T07:29:33.175Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-6267U CPU @ 2.90GHz (4 x 2900)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
4, 4, 4

Memory (System)
8.00GB (0.04GB free)

Process Argv
.

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

jsx
Twe
0.0.1

chrome-vs-code
fab
0.0.1

vscode-pull-request-github
Git
0.1.6

vscode-azureappservice
ms-
0.9.1

azure-account
ms-
0.4.3

debugger-for-chrome
msj
4.10.1

vscode-icons
rob
7.27.0

@auchenberg I cannot reproduce, here is the exact steps I followed:

cd ~
ln -s ~/Downloads/ dev
code-insiders ~/dev

I see that ~/dev is preserved

Verified working in today's build.


snakefmt: workaround for regression in 0.8.0

There is a fairly annoying regression bug in snakefmt v0.8.0 (https://github.com/snakemake/snakefmt/issues/169) that triggers a parsing error if the first line in a new block is a comment #. Since v0.8.0 contains fixes for wrong indentation, the conda envs in the template stick to 0.8.0 and a small syntax change in snaketests.smk::test_find_script_success is introduced as a workaround as part of the fix for issue #15
As soon as snakefmt has been updated, it should be tested if the new version works properly with all snakemake files and if so, the template must be updated immediately.

apparently, Snakefmt has also problems finding the correct indentation level for block comments; sometimes, the indentation level of the line above the comments is used as reference, as opposed to the line below (= the comment refers to), leading to a violation of PEP8.
Consequently, the result of Snakefmt may need some manual inspection / should not be followed w/o checking


ctrl+shift+T to restore accidentally closed tab

It would be rather nice to be able to quickly restore accidentally closed tabs with the ctrl+shift+T key binding that some of us have deep in their muscle memory.
Provided it's not an unreasonable request, please outline a reasonable approach so that one may implement it on a slower weekend.
Thank you for an awesome job, by the way.

Shouldn't be too difficult to do. I suppose you're assuming it remembers multiple closed tabs, like an undo stack? That's what Safari seems to do, for example.

There seems to be a duplicate: #446


Change subscription to license

@richagi : Thanks for your contribution to the Azure documentation! The author, @MicrosoftGuyJFlo, has been notified to review your proposed change.

#sign-off


get_name() doesn't seem to be virtual

I'm trying to compile the add_rrbot_system_position_joints branch, and I'm getting this error:
.../ros2_control_demos/ros2_control_demo_hardware/include/ros2_control_demo_hardware/rrbot_system_position_only.hpp:50:15: error: ‘std::string hardware_interface::BaseSystemHardwareInterface::get_name() const’ marked ‘final’, but is not virtual

If I remove final it seems to compile fine.

it should be now. check here


Remove standard output from with_rubygems

This PR might be very specific to my setup, but it would certainly help me.
What was the end-user problem that led to this PR?
The problem was that sometimes I don't find out early about rubocop issues, so I have to push extra commits to fix them, and that means time and CI resources.
What was your diagnosis of the problem?
My diagnosis was that:

I run rubocop automatically on save from `vim using ale.
I set ENV["RGV"] = master, so that I always run the latest rubygems.

Because of setting ENV["RGV"], the with_rubygems script is run everytime a binstub is loaded (including rubocop). This script prints some git information to the standard output. Since ALE expects a very specific output from rubocop, the fact that the with_rubygems script prints stuff to the standard output means that ALE no longer works, and I don't get to early fix style issues.
What is your fix for the problem, implemented in this PR?
My fix is to make the with_rubygems script be silent.
Why did you choose this fix out of the possible options?
I could've removed loading the with_rubygems script from the rubocop binstub, but I chose this fix because other subcommands in the script already seemed to try to be silent, like the --quiet flag passed to git checkout.

Unless anyone has a very strong opinion here, I'd like to get this in... Otherwise I feel I need to choose between setting RGV=master or having a working linter configuration, and I'd like to have both :sweat_smile:.

$ bin/rubocop
Fetching origin
Checked out rubygems 'master' at b2ec76a447f3670b115c1dd1267869427d968b7b
Inspecting 368 files
...........................C....................................................................................................................................................................................................................................................................................................................................................

Offenses:

spec/bundler/env_spec.rb:57:7: C: Layout/AccessModifierIndentation: Outdent access modifiers like private.
      private
      ^^^^^^^

368 files inspected, 1 offense detected

The first two lines of the output is what I'm removing here, so that tools relying on rubocop's output having a specific shape don't get tripped up.

Doing this since it's handy for me and there's no strong opposition.
@bundlerbot r+


Update user.name reference in Account and Admin collection

When the username changes in the Users collection
the reference in Account and Admin should also be
updated.

Closes #258
I'm not sure if this is the best approach, let me know if you would like a different implementation.
I thought about checking if the username really changed before calling update on Admin and Account but I wasn't sure how to go about it.

I just remembered that folks can change their own usernames. We should probably update this handler too: https://github.com/jedireza/aqua/blob/6d30d0ae63165f03f60adbdfca6009ef2f39fe25/server/api/users.js#L304

Pushed a new commit with the changes to the /users/my endpoint.
I'll squash everything at the end.

💥 Very cool! Thanks for taking this on. If you're up for it we can apply the same patch to Frame.

Sure, I'll reopen jedireza/frame#184 if that's okay.


Supports for Lists endpoint?

User story
As a Client, I want to support the Lists endpoint so that I can process a number of transactions.
https://www.hl7.org/fhir/list.html
Acceptance criteria

List is supported. Can you clarify.

Apologies.
We have a need to create a list (how does one create one through the API?) which maintains a list of Patients whose details have otherwise recently changed (keeps two disparate systems syncing). We are aware this isnt perfect for now but its our MVP.
Is that possible?

The purpose of List is to create a point in time collection of resources and you would create it with:
POST /List

With the actual list. The List resource does not imply a query or collection that is dynamically updated when things change.
What you are talking about could be a Subscription where changes to a certain search trigger some hook. That spec is currently in some flux and we don't support it.
A simpler version may be just using the _history query as a change feed.
Either way, I don't think List is what you are looking for unless you are reading something different into the spec?

No that's all good.
We are looking to keep two fhir servers in sync which actually brought up another issue in Id's relating to this issue here: https://github.com/microsoft/fhir-server/issues/236
Our source FHIR server provides Id's, but the CREATE request on our OSS MS Server doesn't respect those if passed in as spoken about here: https://www.hl7.org/fhir/http.html#upsert
If we try the PUT request, that doesnt work either, however it does say its supported here: https://docs.microsoft.com/en-us/azure/healthcare-apis/fhir-features-supported#rest-api

Please clarify.
PUT is supported. Specifically if you do say:
PUT //fhirserver/Patient/1234

with a payload of:
{
    "resourceType": "Patient",
    "id": "1234",
     //...
}

Patient 1234 will get replaced (creating a new version) with the new Patient payload. If you have an example of this not working, please submit it here and we will investigate.

@courtenayparserr wanted to follow up here Can you confirm that PUT is working for you or do you still have issues.

Given the name of the original issue, I'm tracking support for _list here: https://github.com/microsoft/fhir-server/issues/1071


1.0.1 release

Added QEMU memory locking support
Shortlog:
3e350ab vendor: Updates
Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

LGTM

Coverage remained the same at 65.949% when pulling b1022d0d290c58fe1071bc04f6e1f988b41e3218 on topic/releases into c280b452bf075d3bac786f8a92ab70c6a1742600 on master.


Migrate from Sanic to FastAPI

Migrate from Sanic to FastAPI because Sanic seems unmaintained.
Also add a pinned Jedi for Python 3.13 support in IDEs.

@billkamp did you test it this time? make sure to say in your comment that you tested it.

I actually tested them this time!!


fix panic on parsing elgamal sign-or-encrypt private key

Ref: https://github.com/keybase/client/issues/18944

Also, it seems like we can fix CI if we don't test the failing subdir (or merge changes from that subdir in, grr...)

Did this ssh package use to pass CI?

I'm guessing that it broke with 1.12
On Fri, Aug 23, 2019 at 3:09 PM heronhaye<EMAIL_ADDRESS>wrote:

Did this ssh package use to pass CI?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/keybase/go-crypto/pull/81?email_source=notifications&email_token=AAGTT73R23OYWOBAED4IBUTQGAYYDA5CNFSM4IPCMKF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BCSZI#issuecomment-524429669,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGTT7ZMOVAOY4UN7SNXGIDQGAYYDANCNFSM4IPCMKFQ
.

Ok should I try to rebase that directory? I saw there were only 2 commits from us in ssh

That would be super

We actually use it for terminal sensing: minterm/minterm_nix.go: "github.com/keybase/go-crypto/ssh/terminal"


Fix multithreaded RTL resetting scroll position on resize.

Fixes https://github.com/godotengine/godot/issues/68567

Thanks!


superClass's field is null

hi , i'm new bee about cglib , today i write some code by cglib , code show as below
public class App {
    public static void main(String[] args) {
        //filed
        UserService userService = new UserService();

        RealSubject realSubject = new RealSubject();
        realSubject.setUserService(userService);
        Enhancer enhancer = new Enhancer();

        enhancer.setSuperclass(realSubject.getClass());

        enhancer.setCallback((MethodInterceptor) (obj, method, args1, proxy)
                          -> proxy.invokeSuper(obj, args1));
        realSubject = (RealSubject) enhancer.create();
        realSubject.doService();

         // i expect get userService but null
        System.out.println(realSubject.getUserService());
    }
}

os : uname -a
Darwin tes.local 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64 x86_64

jdk : java -version
➜  ~ java -version
Java(TM) SE Runtime Environment (build 1.8.0_161-b12)
Java HotSpot(TM) 64-Bit Server VM (build 25.161-b12, mixed mode)

how can i get the field? , Please forgive my bad english.

please close this issue, you should ask such questions on SO community

i can't find  SO community , can you give me a address. @clevertension

https://stackoverflow.com/questions/tagged/cglib
@chenshun00

thinks


Breaks accessed properties

Title is a bit hard to say, so here's an example
This
elem.addEventListener("click", event => {
  event.currentTarget.classList.toggle("active");
  var content = event.currentTarget.nextElementSibling;
  if (content.style.maxHeight) {
    content.style.maxHeight = null;
  } else {
    content.style.maxHeight = content.scrollHeight + "px";
  }
});

Turned into something similar to this as generated code
a.addEventListener("click", event => {
  e.currentTarget.classList.toggle("active");
  var c = e.currentTarget.nextElementSibling;
  // entire c.style.maxHeight is missing, instead is a new variable which doesn't exist
  if (b) {
    // for some reason it also renamed this one too
    b = null;
  } else {
    // and this one
    b = c.scrollHeight + "px";
  }
});

The workaround is to assign the accessed property thing to a new variable in order to make the minifier ignore the inside ones and actually assign to it.
elem.addEventListener("click", event => {
  event.currentTarget.classList.toggle("active");
  var content = event.currentTarget.nextElementSibling;
  // fix bug in minifier which shortened this to only one var
  var height = content.style.maxHeight;

  if (height) {
    content.style.maxHeight = null;
  } else {
    content.style.maxHeight = content.scrollHeight + "px";
  }
});

Hi!
I can't reproduce the bug.
This code
---
layout: js_minifier
---
const elem = {};
elem.addEventListener("click", event => {
	event.currentTarget.classList.toggle("active");
	var content = event.currentTarget.nextElementSibling;
	if (content.style.maxHeight) {
	  content.style.maxHeight = null;
	} else {
	  content.style.maxHeight = content.scrollHeight + "px";
	}
  });

gives me
const d={};d.addEventListener("click",c=>{c.currentTarget.classList.toggle("active");var b=c.currentTarget.nextElementSibling;if(b.style.maxHeight){b.style.maxHeight=null;}else{b.style.maxHeight=b.scrollHeight+"px";}});

Maybe something else in your code is causing this bug.

That's unfortunate. I was hoping the minimal example would here. Here's a permalink to the line+entire file which I know for sure did cause it.
https://github.com/cherryleafroad/cherryleafroad.github.io/blob/e0ba3b4744b7d56a95a417e28d972a7e2a8dad0e/assets/js/deferred.js#L55


Touch delegate?

Is there any way to get notified which point of the graph is touched by the user? I need to display additional information based on the point of the graph the user touched... Thanks!!!

Refer to  #810


Added a script and config for bringing interop test to kokoro

The grpc_interop.sh is ported from jenkins/run_interop.sh

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

test this please

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Updated the timeout value used for internal CI settings.


Fix move calls that are not from step

This fixes an issue where calls to widowx_client.move (for example to set the goal or initial gripper position) would sometimes cause the arm to move very fast. This was caused by using move_to_eep with blocking=False. When blocking=False the move_to_eep function uses a custom implementation of set_ee_pose_matrix (original is here) that does not set the velocity profiles and ignores the move duration that is passed in (in order to execute the action faster). Instead the velocity profiles get set only once in the call to bridge_env.start. The overall effect was that widowx_client.move would cause the robot to move with the very small duration used for executing actions with step (thus moving extremely fast in order to cover the large distance need to move to the initial/goal gripper postion).
To fix this I did a few things:

Add back the bridge_env.start call in the reset function. This will make sure the velocity profiles are set correctly for non-blocking control.
Modify the move_to_eep function to take in a new argument step that determines whether this call is coming from the step function or whether it's coming from the move function. If the call comes from step we use the custom implementation of set_ee_pose_matrix that ignores the duration. Otherwise we use the default set_ee_pose_matrix that respects the duration and sets the velocity profiles accordingly.

Thanks for nailing down the issue. so with the step argument,
should the client interface move() interface uses step=false?

Thanks for nailing down the issue. so with the step argument,
should the client interface move() interface uses step=false?

Yeah it's been changed here


Postgres enums and query_as!

I have the following enum and struct:
#[derive(sqlx::Type, Debug)]
#[sqlx(rename = "service_state", rename_all = "SCREAMING_SNAKE_CASE")]
pub enum ServiceState {
    Available,
    NotAvailable,
}

pub struct ServiceStatus {
    pub ip: String,
    pub state: ServiceState,
}

Corresponding type and table:
CREATE TYPE service_state AS ENUM (
    'AVAILABLE', 'NOT_AVAILABLE'
);

CREATE TABLE service_statuses (
    ip TEXT PRIMARY KEY,
    state service_state NOT NULL
);

I'm trying to fetch all rows like so:
sqlx::query_as!(ServiceStatus, "SELECT * FROM service_statuses")
    .fetch_all(&pool)
    .await
    .expect("Failed to execute query");

But compiler fails with the following message:
error: unsupported type service_state of column #2 ("status")

Am I doing something wrong?
I've tried to search through issues first and got an impression that there are no compile-time checks for this now, is that right?

I was running into something similar. I found that this worked.
sqlx::query_as!(ServiceStatus, r#"SELECT ip, state as "state: _" FROM service_statuses"#)
    .fetch_all(&pool)
    .await
    .expect("Failed to execute query");

or you can make the type explicit.
sqlx::query_as!(ServiceStatus, r#"SELECT ip, state as "state: ServiceState" FROM service_statuses"#)
    .fetch_all(&pool)
    .await
    .expect("Failed to execute query");

https://docs.rs/sqlx/0.4.2/sqlx/macro.query.html#force-a-differentcustom-type

I was running into something similar. I found that this worked.
sqlx::query_as!(ServiceStatus, r#"SELECT ip, state as "state: _" FROM service_statuses"#)
    .fetch_all(&pool)
    .await
    .expect("Failed to execute query");

or you can make the type explicit.
sqlx::query_as!(ServiceStatus, r#"SELECT ip, state as "state: ServiceState" FROM service_statuses"#)
    .fetch_all(&pool)
    .await
    .expect("Failed to execute query");

https://docs.rs/sqlx/0.4.2/sqlx/macro.query.html#force-a-differentcustom-type

@ZacharyLeBlanc, thanks, this works! Is this a runtime or compile-time check?

@ZacharyLeBlanc, thanks, this works! Is this a runtime or compile-time check?

I just picked up sqlx for a side project so I'm no expert but reading the docs it looks like this would be a runtime error. If there is a better solution I would love to hear it as I was running into this as well. I just found that this worked for me.

I just picked up sqlx for a side project so I'm no expert but reading the docs it looks like this would be a runtime error. If there is a better solution I would love to hear it as I was running into this as well. I just found that this worked for me.

This disables the compile-time type check for the specific column. Checking custom types for compatibility at compile time is not currently supported.

This disables the compile-time type check for the specific column. Checking custom types for compatibility at compile time is not currently supported.

I also interested in how one can insert UDT with an update on the conflict, like so:
INSERT INTO service_statuses (ip, state) VALUES ($1, $2)
ON CONFLICT (ip) DO UPDATE SET state = $1 as ServiceState

I also interested in how one can insert UDT with an update on the conflict, like so:
INSERT INTO service_statuses (ip, state) VALUES ($1, $2)
ON CONFLICT (ip) DO UPDATE SET state = $1 as ServiceState

INSERT INTO service_statuses (ip, state) VALUES ($1, $2)
ON CONFLICT (ip) DO UPDATE SET state = $1

Are you sure that's right?
You are setting ip to $1 in line 1 but state to $1 in the second

INSERT INTO service_statuses (ip, state) VALUES ($1, $2)
ON CONFLICT (ip) DO UPDATE SET state = $1

Are you sure that's right?
You are setting ip to $1 in line 1 but state to $1 in the second

Sorry, it's a typo. Actual message: error: unsupported type service_state for param #2

Sorry, it's a typo. Actual message: error: unsupported type service_state for param #2

Ah you need https://docs.rs/sqlx/0.4.2/sqlx/macro.query.html#type-overrides-bind-parameters-postgres-only
query!(
  r#"
INSERT INTO service_statuses (ip, state) VALUES ($1, $2)
ON CONFLICT (ip) DO UPDATE SET state = $1
  "#,
  one as _,
  two as _,
)

It is a similar concept but in the inverse direction for parameters.

Ah you need https://docs.rs/sqlx/0.4.2/sqlx/macro.query.html#type-overrides-bind-parameters-postgres-only
query!(
  r#"
INSERT INTO service_statuses (ip, state) VALUES ($1, $2)
ON CONFLICT (ip) DO UPDATE SET state = $1
  "#,
  one as _,
  two as _,
)

It is a similar concept but in the inverse direction for parameters.

Yep, that works, appreciate it!
Is there any issue about compatibility for UDT at compile time I can follow?

Yep, that works, appreciate it!
Is there any issue about compatibility for UDT at compile time I can follow?

I'm getting this error from sqlx::query_file_as!(, but not from sqlx::query_as!(. I assume it's not supported yet?

I'm getting this error from sqlx::query_file_as!(, but not from sqlx::query_as!(. I assume it's not supported yet?

I'm running into the same issue except with an INSERT statement. The advice above helped with SELECT, but not with INSERT. Specifically, my code compiles fine but at runtime I get a TypeNotFound error:
thread 'actix-rt|system:0|arbiter:0' panicked at 'called `Result::unwrap()` on an `Err` value: TypeNotFound { type_name: "TweetClass" }', src/twitter/domain/tweet.rs:178:6
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

My query code:
    sqlx::query!(
        r#"
        INSERT INTO tweets
        (id, created_at,
        tweet_id, tweet_created_at, tweet_text, tweet_url,
        replied_to_tweet_id, quoted_tweet_id, tweet_class,
        like_count, quote_count, reply_count, retweet_count, total_retweet_count, popularity_count,
        user_id)
        VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15, $16)
        "#,
        Uuid::new_v4(),
        Utc::now(),
        tweet_id,
        tweet_created_at,
        tweet["text"].as_str(),
        tweet_url,
        replied_to_tweet_id,
        quoted_tweet_id,
        tweet_class as TweetClass, // also tried "as _" - neither works
        tweet_metrics.like_count,
        tweet_metrics.quote_count,
        tweet_metrics.reply_count,
        tweet_metrics.retweet_count,
        tweet_metrics.total_retweet_count,
        tweet_metrics.popularity_count,
        author.id,
    )
    .execute(pool)
    .await
    .unwrap();

TweetClass (defined in the same file):
#[allow(non_camel_case_types)]
#[derive(Debug, sqlx::Type)]
pub enum TweetClass {
    normal,
    rt_original,
    helper,
}

What am I missing?

@ilmoi Your enum definition is likely wrong. What you need:
// assuming your postgres type name is in snake_case like the variants seem to be
#[derive(Debug, sqlx::Type)]
#[sqlx(rename = "tweet_class", rename_all = "snake_case")]
pub enum TweetClass {
    Normal,
    RtOriginal,
    Helper
}

I'm having a similar issue but with an array of enums, trying to insert in bulk using unnest like the FAQ calls for:
sqlx::query!(
     r#"
                INSERT INTO "Expansion"(region)
                SELECT * FROM UNNEST($1::"Region"[])
       "#,
         &region[..] as _,
        )
.execute(&ctx.db)
.await?;

where Region is
pub enum Region {
    #[sqlx(rename = "intl")]
    International,
    #[sqlx(rename = "jp")]
    Japan,
}

the trait bound `[db::models::region::Region]: sqlx::Type<sqlx::Postgres>` is not satisfied
the following implementations were found:
  <[&[u8]] as sqlx::Type<sqlx::Postgres>>
  <[&str] as sqlx::Type<sqlx::Postgres>>
  <[(T1, T2)] as sqlx::Type<sqlx::Postgres>>
  <[(T1, T2, T3)] as sqlx::Type<sqlx::Postgres>>
and 36 others

How can we bulk insert enums? Thanks!

As of the latest release, to make arrays of custom types work you just have to implement PgHasArrayType for the enum, returning PgTypeInfo::with_name("_foo") (where foo is the name of the postgres enum type) from the array type info method.

Is there a reason why #[derive(sqlx::Type)] doesn't derive PgHasArrayType as well, returning the type name prefixed by _?

I didn't try implementing that. It would probably only make sense when a #[sqlx(type_name = "...")] attribute is used.

As of the latest release, to make arrays of custom types work you just have to implement PgHasArrayType for the enum, returning PgTypeInfo::with_name("_foo") (where foo is the name of the postgres enum type) from the array type info method.

Hi!, I had the exact problem and this worked, but my question is why the underscore? is this because of postgres or sqlx?

It's Postgres' default naming convention for array types.

It's Postgres' default naming convention for array types.

@LukeMathWalker where is this documented so I can understand that convention better?

As of the latest release, to make arrays of custom types work you just have to implement PgHasArrayType for the enum, returning PgTypeInfo::with_name("_foo") (where foo is the name of the postgres enum type) from the array type info method.

I'm trying to go with this approach and use the PgHasArrayType trait, but sqlx still seems to return an error. As a minimal example, I've defined the struct and enum for the table I'm using like this:

#[derive(Debug, sqlx::Type)]
#[sqlx(type_name = "user_type", rename_all = "snake_case")]
pub enum UserType {
    Viewer,
    Editor,
    Admin,
}

impl PgHasArrayType for UserType {
    fn array_type_info() -> PgTypeInfo {
        PgTypeInfo::with_name("_user_type")
    }
}

#[derive(Debug, sqlx::Type)]
pub struct User {
    pub username: String,
    pub user_type: UserType,
}

And this is the corresponding SQL:
create type user_type as enum ('viewer', 'editor', 'admin');

create table users (
    user_id serial not null primary key,
    username text not null,
    user_type user_type not null
);

However, when I try to query it like this,
#[tokio::main]
async fn main() {
    dotenv().ok();

    let database_url = std::env::var("DATABASE_URL").expect("DATABASE_URL not set");
    let pool = PgPool::connect(&database_url)
        .await
        .expect("Could not connect to DATABASE_URL");

    let users = sqlx::query!(r#"select user_id, username, user_type from users;"#)
        .fetch_all(&pool)
        .await
        .unwrap();

    println!("{:?}", users);
}

I get unsupported type user_type of column #3 ("user_type"), and I still have to write sqlx::query!(r#"select user_id, username, user_type as "user_type: UserType" from users;"#) to get it to stop complaining.
Is there something else I have to do here?

Im having the same problem @rminami
Anyone have some time to spare to provide some clarity on this because enums are obviously important and I'm disappointed to be missing out on the compile-time checks of the macro

any updates on this for how you guys handled it?

I've just been using the non-macro forms of query and query_as 🙁

Well that works but it kinda bugs me that macro's are giving me error. Feels like it's a wrong practice

It's not ideal but it is what it is.

@ewrogers  r#"SELECT id, status as "status: JobStatus" FROM job_history"#

@ewrogers r#"SELECT id, status AS "status!: JobStatus" FROM job_history"#

Yeah that works if I just need the two properties, but if I need "everything" I can't use * if I need to AS cast something unfortunately...

Using SELECT * is rarely a good idea

That's a fair point, and I admit that I'm "getting back into SQL" after recent years of Mongo/DynamoDB land so there's a good chance I'm re-learning best practices there.
Though is it a matter of "we don't support this because it's not a good idea and you shouldn't do it" (opinionated), or simply "we haven't found a way to support it yet"?
I'm not arguing either side, just more or less to manage expectations of people who run into this.

Unfortunately, it's not supported yet. Personally, I'd love to skip casting each enum column in the future.

Any workaround for inserts?

Any workaround for inserts?

https://github.com/launchbadge/sqlx/issues/1004#issuecomment-764964043

Just wanted to add for reference how I got enum of custom type + query_qs! working.
#[derive(Debug, Deserialize, Serialize, ToSchema, sqlx::Type)]
pub enum LightCondition {
    DirectSunlight,
    BrightIndirectSunlight,
    MediumIndirectSunlight,
    LowIndirectSunlight
}

impl PgHasArrayType for LightCondition {
    fn array_type_info() -> PgTypeInfo {
        PgTypeInfo::with_name("_light_condition")
    }
}

// SQL query in query_as!
SELECT  s.light_conditions AS "light_conditions: _" FROM species s

Also had the same issue using query_as! with enums.
Ended up using something like
#[derive(sqlx::Type, Serialize, Deserialize, Debug)]
#[sqlx(type_name = "git_source", rename_all = "lowercase")]
pub enum GitSource {
  Github,
  Gitlab,
  Bitbucket,
}

let project = Project {
    id: Uuid::new_v4(),
    git_source: GitSource::Github,
  };

sqlx::query_as!(
      Project,
      r#"INSERT INTO projects (id, git_source)
       VALUES ($1, $2)
       RETURNING id, git_source AS "git_source!: GitSource"
       #",
      project.id,
      project.git_source as GitSource,
    ).fetch_one(pool).await;

Hope this helps anyone wanting to do inserts.

            let updated_user = sqlx::query_as!(
                UserModel,
                r#"UPDATE users SET role=$1 as "role:UserRole",updated_at=$2 WHERE id=$3 RETURNING id,name,email,verified,created_at,password,updated_at,role as "role: UserRole""#,
                role.into(),
                now,
                user_id,
            )
            .fetch_optional(&self.pool)
            .await?;

does it possible to UPDATE role ? in my example syntax error. i've tryed without as "role:UserRole" after $1 but it's not working

            let updated_user = sqlx::query_as!(
                UserModel,
                r#"UPDATE users SET role=$1 as "role:UserRole",updated_at=$2 WHERE id=$3 RETURNING id,name,email,verified,created_at,password,updated_at,role as "role: UserRole""#,
                role.into(),
                now,
                user_id,
            )
            .fetch_optional(&self.pool)
            .await?;

does it possible to UPDATE role ? in my example syntax error. i've tryed without as "role:UserRole" after $1 but it's not working
i opened issue here

YES!
Here is right query
r#"UPDATE users SET role=($1::text)::user_role, updated_at=$2 WHERE id=$3 RETURNING id, name, email, verified, created_at, password, updated_at, role as "role:UserRole""#,

Polluting the SQL with weirdly named columns isn't ideal, as this might cause issues if you want to reuse the same SQL files for other stuff.
What stops the macro from type-checking these fields without further annotation, considering the type of the field in the rust struct has a type_name set?

@heksesang https://github.com/launchbadge/sqlx/issues/514


The build script seems to expect gmock to be there

/src/CMakeLists.txt:3 add_subdirectory(gmock)
should gmock be a submodule?

That appears to be an accident. You should get gmock independently and build & install it yourself (iff you want to run the tests).
Delete the line and try again.


Jcenter still coming in, old gradle coming in during app build

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
jcenter proclaimed they would stay up in readonly forever, but their service has become incredibly flaky.
I was no longer able to build my android app because jcenter was down this morning and this module brought in an old gradle and jcenter even when it was not necessary
I replaced the gradle plugin dependency with a block that works the way I do it in the react-native-device-info module I maintain as well as all the other modules - it only pulls in gradle and the module dependencies when it's necessary, which is to say: it does not pull them in during app builds
Here is the diff that solved my problem:
diff --git a/node_modules/react-native-sqlite-storage/platforms/android-native/build.gradle b/node_modules/react-native-sqlite-storage/platforms/android-native/build.gradle
index 94a8675..53e90cc 100644
--- a/node_modules/react-native-sqlite-storage/platforms/android-native/build.gradle
+++ b/node_modules/react-native-sqlite-storage/platforms/android-native/build.gradle
@@ -1,11 +1,17 @@
 buildscript {
-    repositories {
-        google()
-        jcenter()
-    }
+    // The Android Gradle plugin is only required when opening the android folder stand-alone.
+    // This avoids unnecessary downloads and potential conflicts when the library is included as a
+    // module dependency in an application project.
+    if (project == rootProject) {
+        repositories {
+            mavenCentral()
+            google()
+        }
+        def buildGradleVersion = ext.has('buildGradlePluginVersion') ? ext.get('buildGradlePluginVersion') : '7.0.3'

-    dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.4'
+        dependencies {
+            classpath "com.android.tools.build:gradle:$buildGradleVersion"
+        }
     }
 }

@@ -16,12 +22,11 @@ def safeExtGet(prop, fallback) {
 }

 android {
-    compileSdkVersion safeExtGet('compileSdkVersion', 23)
-    buildToolsVersion safeExtGet('buildToolsVersion', '27.0.3')
+    compileSdkVersion safeExtGet('compileSdkVersion', 30)

     defaultConfig {
         minSdkVersion safeExtGet('minSdkVersion', 16)
-        targetSdkVersion safeExtGet('targetSdkVersion', 22)
+        targetSdkVersion safeExtGet('targetSdkVersion', 28)
         versionCode 1
         versionName "1.0"
     }
diff --git a/node_modules/react-native-sqlite-storage/platforms/android/build.gradle b/node_modules/react-native-sqlite-storage/platforms/android/build.gradle
index ff79b10..a0c6468 100644
--- a/node_modules/react-native-sqlite-storage/platforms/android/build.gradle
+++ b/node_modules/react-native-sqlite-storage/platforms/android/build.gradle
@@ -1,11 +1,17 @@
 buildscript {
-    repositories {
-        google()
-        jcenter()
-    }
+    // The Android Gradle plugin is only required when opening the android folder stand-alone.
+    // This avoids unnecessary downloads and potential conflicts when the library is included as a
+    // module dependency in an application project.
+    if (project == rootProject) {
+        repositories {
+            mavenCentral()
+            google()
+        }
+        def buildGradleVersion = ext.has('buildGradlePluginVersion') ? ext.get('buildGradlePluginVersion') : '7.0.3'

-    dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.4'
+        dependencies {
+            classpath "com.android.tools.build:gradle:$buildGradleVersion"
+        }
     }
 }

@@ -16,12 +22,11 @@ def safeExtGet(prop, fallback) {
 }

 android {
-    compileSdkVersion safeExtGet('compileSdkVersion', 23)
-    buildToolsVersion safeExtGet('buildToolsVersion', '27.0.3')
+    compileSdkVersion safeExtGet('compileSdkVersion', 30)

     defaultConfig {
         minSdkVersion safeExtGet('minSdkVersion', 16)
-        targetSdkVersion safeExtGet('targetSdkVersion', 22)
+        targetSdkVersion safeExtGet('targetSdkVersion', 28)
         versionCode 1
         versionName "1.0"
     }

This issue body was partially generated by patch-package.

@fogg4444 no idea - I'm actually not using this package anymore but I don't see why the PR wouldn't still be valid. Feel free to ping on it + ask the maintainer, until then you've always got patch-package...

@fogg4444 no idea - I'm actually not using this package anymore but I don't see why the PR wouldn't still be valid. Feel free to ping on it + ask the maintainer, until then you've always got patch-package...

I copied your patch file approach for now. I'll ping the maintainer. Thanks!


Error: unknown format "email"

Hello,
I'm trying to use the email format, but no success.
Here's the schema:
{   "type": "object",   "required": ["email", "password"],   "properties": {     "email": {       "type": "string",       "format": "email"     },     "password": {       "type": "string"     }   } }
Then when the server is starting (even before any request), I get this error:
Error: unknown format "email" ignored in schema at path "#/properties/email"
My Validator is being stantiated with this:
const { validate } = new Validator({ allErrors: true });
If I remove "format": "email" from the schema, validation works fine.
What I'm doing wrong?
Edit: already installed ajv-formats package too, but no success; I don't know how to add the formats I would like to use and connect with the middleware.

Well, I've done like this...
`import { Validator } from "express-json-validator-middleware";
import Ajv from "ajv";
import addFormats from "ajv-formats";
const ajv = new Ajv();
addFormats(ajv, { mode: "full" });
export const validateEmail = ajv.compile({ format: "email" });
const { validate } = new Validator({
allErrors: true,
formats: {
email: validateEmail
},
});`
Not sure if it's the best approach, but at least it seems to work.

The Ajv instance is available via the Validator.ajv property. You can configure it to use ajv-formats like this:
const { validate, ajv } = new Validator({});

addFormats(ajv);

Aww... I totally missed that one.
Thank you.

Aww... I totally missed that one.
Thank you.

No problem! I'll see if I can improve this part of the docs, perhaps by adding a more concrete example with ajv-formats.


Timeout2

What this PR does:
This PR moves the timeout config outside the clusters. In detail, it moves connect_timeout and request_timeout from clusters into timeout_config in  conf.yaml.
Which issue(s) this PR fixes:

Fixes #189

Codecov Report

Merging #190 (9cd9bb7) into develop (5c98b5e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
- Coverage    43.19%   43.14%   -0.05%
===========================================
  Files           33       33
  Lines         1755     1757       +2
===========================================
  Hits           758      758
- Misses         888      890       +2
  Partials       109      109

Impacted Files
Coverage Δ

pkg/client/dubbo/dubbo.go
20.75% <0.00%> (-0.40%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c98b5e...9cd9bb7. Read the comment docs.


Create VM for "closed" sandbox, relevant rules not applied to new vm

When a sandbox is closed, data sets are made available.
But these rules are not applied to vms that are created after sandbox is closed
Also ensure that rules are cleaned up after VM is deleted

This was not the case after all, as rules are between dataset and NSG, and not directly configured on VM

This was not the case after all, as rules are between dataset and NSG, and not directly configured on VM


[Feat]: Create profile updating component for settings page

What feature?
The Settings page requires a new component to be added, following the design provided in the attached screenshot. The component should be created as a separate file in the component folder. Additionally, ensure that the buttons within the component are clickable and functional.
🎨 Tailwind classes

delete button icon: rose-500
button: zinc-900
delete button border: zinc-200
input label: zinc-500
input border: zinc-200
input text: zinc-900
border-radius : rounded-md

✨ Expected Deliverables:

Create a new component for the Settings page based on the provided design.
Place the component in the appropriate location within the component folder.
Implement functionality for the buttons within the component to make them clickable.
Use react useState variable for input buttons.

🔀 Make sure to use only Google material icons :

Find the desired icon on the Google Material Icons website (https://fonts.google.com/icons) and copy the class name associated with it.
usage example -: arrow_outward

Show us the magic with screenshots

Agreement to Code of Conduct

[X] I agree to follow this project's Code of Conduct

Plz assign this task to me under gssoc'23.

Sure @abhi03ruchi, I am assigning this task. Make sure to follow the given guidelines and tailwind classes.

I am getting this error , when after i ran npm run dev.

Plz help

This issue is resolved ?? If not please go through the contribution guide.

We are closing this issue, as it has been inactive for a long time. If you think you want to work on this issue please create a new ISSUE.


added context-free endSubsegment method to AWSXRay class

Issue #, if available:
#227
Description of changes:
This change is important because we should make this API as visible as possible to assist our customers using asynchronous or multi-threaded programming. I will also update the docs to emphasize this.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Will wait to merge until right before the next release.


[SPARK-36689][PYTHON] Cleanup the deprecated APIs and raise proper warning message.

What changes were proposed in this pull request?
This PR proposes cleanup the deprecated APIs in missing/*.py, and raise proper warning message for the deprecated APIs such as pandas does.
Also remove the checking for pandas < 1.0, since now we only focus on following the behavior of latest pandas.
Why are the changes needed?
We should follow the deprecation of APIs of latest pandas.
Does this PR introduce any user-facing change?
Now the some APIs raise proper alternative message for deprecated functions such as pandas does.
How was this patch tested?
Ran dev/lint-python and manually check the pandas API documents one by one.

Test build #143064 has started for PR 33931 at commit de6d1fd.

Test build #143064 has finished for PR 33931 at commit de6d1fd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47567/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47567/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143064/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47567/

Can you fix tests?
======================================================================
ERROR [0.038s]: test_missing (pyspark.pandas.tests.test_series.SeriesTest)
----------------------------------------------------------------------
pyspark.pandas.exceptions.PandasNotImplementedError: The method `pd.Series.slice_shift()` is deprecated in pandas and will therefore not be supported in pandas-on-Spark. Use `shift` instead.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/__w/spark/spark/python/pyspark/pandas/tests/test_series.py", line 1040, in test_missing
    getattr(psser, name)()
AssertionError: "method.*Series.*tshift.*is deprecated" does not match "The method `pd.Series.slice_shift()` is deprecated in pandas and will therefore not be supported in pandas-on-Spark. Use `shift` instead."

----------------------------------------------------------------------

Otherwise looks good. cc @ueshin too fyi

Test build #143107 has started for PR 33931 at commit 3550117.

Test build #143107 has finished for PR 33931 at commit 3550117.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47611/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143107/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47611/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47611/

Merged to master.


[feat] Supporting 16bits images

Fix https://github.com/Photoroom/datago/issues/57

For real I should add a unit test, but didn't get the time


unexpected error message in response header

when 401 is returned, following error also present
Bearer error="invalid_token", error_description="An error occurred while attempting to decode the Jwt: Invalid JWT serialization: Missing dot delimiter(s)", error_uri="https://tools.ietf.org/html/rfc6750#section-3.1"

not able to reproduce in local


chore: update codecov and use OIDC

ok, that won't work

@gruebel do you know why that won't work? Using OIDC would be nice.

@beeme1mr Yeah, basically the GH token can't have the needed permission, when coming from a fork. It would only work for PRs from the same repo.

Okay, yeah. That was the issue Todd reported a few months ago. CodeCov doesn't seem to have a great answer for that unfortunately.


Selecting "none" as absolute encoder type causes rotation NEOs to blink sensor fault error and not spin

I am using the vendordep.
I tried it with YAGSL-Example with a modified configuration (to set absolute encoders to none) and the issue still occurred.

I see I've put this issue in the wrong place.
Do you want me to move it to YAGSL or can you do that?

The motors spin as expected using the example code with the modified configuration, however I wasn't able to get the change to appear using the vendor library.


WPF-MediaKit not working with webcam

I'm trying to run a Test Application from the repo to see the output of a webcam. The program works as expected on 2 of 3 of my computers (all of them on Windows 10). I installed K-Lite codec pack but that didn't seem to help. I run GraphStudioNext, inserted video source and video renderer and it displays the camera correctly.
Are there any further steps I can take to debug the problem?
Before reporting an issue, check and answer the following points if they are valid for your case:

Does the problem emerge on different HW, OS versions? Describe your HW configuration.
HP Laptop with Windows 10 Home, dual graphics card (Intel HD 630, Geforce GTX 1050), built-in camera and Logitech HD Pro Webcam C920.
Is the problem caused by the DirectShow codecs or the player itself?
Not sure

Try the clean install of DirectShow codecs.
Tried it, didn't seem to help
Try another DirectShow player (e.g. MPC-HC).
Possibly not relevant?
Use GraphStudioNext to see, what codecs are used for your video.
Possibly not relevant?

Describe the video format. Consider providing a HTTP link to download a video which causes the problem.
Direct connection to webcam

Any help would be highly appreciated

Do not understand what's the problem: you have 3 machines, the problem is on one machine only? Is the problem with the built-in camera or Logitech HD Pro Webcam C920?

@xmedeko Yes, the problem is on one machine only. It doesn't show camera feed for any of those two cameras (both built-in camera and Logitech C920).

Sorry for the late reply. Unfortunately the system I've been experiencing this problem on has been wiped and I cannot reproduce it anymore. I'm closing this issue.


Fix some EBNF cases in grammar.md

I added some cases that were missing in the grammar.md
I'm pretty confident about all of them except for:
parlist = bindinglist [',' '...'] | '...' [':' GenericTypePack]

Can there be more than just GenericTypePack? I think (Type | GenericTypePack) may be the right one here.

Yeah we support ... : number which means "arbitrary number of numbers", so it can be a type

I just fixed the two cases you pointed out @zeux


HDFS-15987. Improve oiv tool to parse fsimage file in parallel with d…

…elimited format
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 33s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 31s

trunk passed

+1 :green_heart:
shadedclient
18m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m 14s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 5 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 57s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 13 new + 51 unchanged - 0 fixed = 64 total (was 51)

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
3m 35s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
shadedclient
18m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
237m 43s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

333m 11s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Found reliance on default encoding in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.outputInParallel(Configuration, FsImageProto$FileSummary, ArrayList):in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.outputInParallel(Configuration, FsImageProto$FileSummary, ArrayList): new java.io.PrintStream(String)  At PBImageTextWriter.java:[line 788]

Exceptional return value of java.io.File.delete() ignored in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.mergeFiles(String[], String)  At PBImageTextWriter.java:ignored in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.mergeFiles(String[], String)  At PBImageTextWriter.java:[line 1036]

Failed junit tests
hadoop.hdfs.web.TestWebHDFS

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2918

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux fa7ab46a034d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8c94660d3c4b670e74aa18c332009073209fca2b

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/1/testReport/

Max. process+thread count
2946 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
21m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 53s

trunk passed

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 37s

trunk passed

+1 :green_heart:
shadedclient
20m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 13 new + 50 unchanged - 0 fixed = 63 total (was 50)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 16s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
3m 21s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
shadedclient
19m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
323m 21s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

441m 33s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Found reliance on default encoding in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.outputInParallel(Configuration, FsImageProto$FileSummary, ArrayList):in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.outputInParallel(Configuration, FsImageProto$FileSummary, ArrayList): new java.io.PrintStream(String)  At PBImageTextWriter.java:[line 788]

Exceptional return value of java.io.File.delete() ignored in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.mergeFiles(String[], String)  At PBImageTextWriter.java:ignored in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.mergeFiles(String[], String)  At PBImageTextWriter.java:[line 1036]

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestDFSShell

hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.TestPersistBlocks

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2918

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 5dd62605fb92 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ffeb0faf05c434cafe6150c688ab6424910c5cfd

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/2/testReport/

Max. process+thread count
2270 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Failed junit tests
| hadoop.hdfs.server.namenode.TestDecommissioningStatus
  | hadoop.hdfs.TestDFSShell
  | hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized
  | hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList
  | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
  | hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
  | hadoop.hdfs.server.datanode.TestDirectoryScanner
  | hadoop.hdfs.server.namenode.ha.TestEditLogTailer
  | hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
  | hadoop.hdfs.TestPersistBlocks
  | hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

All failed tests are passed in local. It seems unrelated to this PR.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 35s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  5s

trunk passed

+1 :green_heart:
shadedclient
16m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 26s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  8s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 51 unchanged - 0 fixed = 52 total (was 51)

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
3m 22s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs.html
hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
shadedclient
16m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
243m 30s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

332m 12s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs

Found reliance on default encoding in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.outputInParallel(Configuration, FsImageProto$FileSummary, ArrayList):in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.outputInParallel(Configuration, FsImageProto$FileSummary, ArrayList): new java.io.PrintStream(String)  At PBImageTextWriter.java:[line 788]

Exceptional return value of java.io.File.delete() ignored in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.mergeFiles(String[], String)  At PBImageTextWriter.java:ignored in org.apache.hadoop.hdfs.tools.offlineImageViewer.PBImageTextWriter.mergeFiles(String[], String)  At PBImageTextWriter.java:[line 1037]

Failed junit tests
hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2918

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 0c3d1926bf11 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df79febc16235dcf64a4dd9d82beb4a3336d11dc

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/3/testReport/

Max. process+thread count
3287 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 42s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 20s

trunk passed

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 16s

trunk passed

+1 :green_heart:
shadedclient
18m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  3s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 33s

the patch passed

+1 :green_heart:
shadedclient
19m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
352m  2s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

445m 20s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2918

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c1e69be34c13 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1adc7f42b27867d0626d8021f9b71f5ce59c5024

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/4/testReport/

Max. process+thread count
2488 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@whbing This feature is useful for parse fsimage. It is near to check in when fix the comment. Any plan to push this forward? Thanks.

@whbing This feature is useful for parse fsimage. It is near to check in when fix the comment. Any plan to push this forward? Thanks.

Thanks for attention. The PR works well and I will improve some details if needed.
It should be pointed out that IOUtils will become higher when using more threads.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 28s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 16s

trunk passed

+1 :green_heart:
shadedclient
24m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 52s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)

+1 :green_heart:
mvnsite
1m 19s

the patch passed

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
24m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
382m 35s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

486m 38s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2918

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux f5ed3d4b1bd5 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 66502f901c3d5ec3410965ea5fdef2b31947d816

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/1/testReport/

Max. process+thread count
1979 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

It seems that some comments are not fixed now. Any plan to push this improvement forwards? This PR has pending here for near year, we should check in ASAP once ready. Thanks.

It seems that some comments are not fixed now. Any plan to push this improvement forwards? This PR has pending here for near year, we should check in ASAP once ready. Thanks.

Sorry for the late follow-up and reply. The new commit will be tested later in our cluster and it will be submitted these days.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m 16s

trunk passed

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 25s

trunk passed

+1 :green_heart:
shadedclient
25m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 15s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 36 unchanged - 0 fixed = 37 total (was 36)

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 24s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 26s

the patch passed

+1 :green_heart:
shadedclient
25m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
313m 21s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

423m 32s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.mover.TestMover

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2918

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 74351207ae22 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f99527d85dfe93d4005f00ac68d1b2f48d1652b2

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/2/testReport/

Max. process+thread count
2242 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The latest commit works well in prod env. @Hexiaoqiao @symious PTAL.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m  3s

trunk passed

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 29s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 26s

trunk passed

+1 :green_heart:
shadedclient
25m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 19s

the patch passed

+1 :green_heart:
compile
1m 25s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 25s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 36 unchanged - 0 fixed = 37 total (was 36)

+1 :green_heart:
mvnsite
1m 22s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
26m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
354m 20s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

465m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2918

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux bd75065c6862 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0dbfa74ab952e5f8c7cbacb6c122ec39b748949f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/3/testReport/

Max. process+thread count
1916 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks @whbing for your updates. It almost look good to me. Please fix checkstyle issue also.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 30s

trunk passed

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
25m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 18s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 23s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
25m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
359m 32s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

469m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2918

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 3635b55300a7 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 362762d88d75c8d11cab324c3f9ce79d638e7be3

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/4/testReport/

Max. process+thread count
2219 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2918/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Committed to trunk. Thanks @whbing for your contributions! Thanks all to reviews!

revert and re-check in to correct the git message.


sumOfProperty wrong

Hi, Please see the question on SO: http://stackoverflow.com/q/34216584/528629
I did a deleteAllObjects and then add them back quickly. But the sumOfProperty gives me 0 instead of the correct sum. Meanwhile, a for loop that add each works.

Hey, I saw your question and gave some first general hints in the comments, but I couldn't yet figure out where this difference is originating from just from the snippets you posted there. Could you share a simple sample project with us, which reproduces this behavior? You can also send us code privately to<EMAIL_ADDRESS>

I created a repository: https://github.com/shaozi/RealmSumReproduce.git

Thanks for the excellent test case, @shaozi! I was able to reproduce the problem by following your instructions, and could easily see where the bug is.
The underlying issue is that TableView appears to fail to update m_num_detached_refs in some cases. This can result in TableViewBase::aggregate thinking that all refs in the table view are detached, causing it to early-exit with a result of 0. It can also result in an incorrect result when the table view is empty, since the assumption is that for an empty table view m_num_detached_refs will be zero. This will need to be fixed in core. I'll file a core issue once I have a chance to boil the test case down to something that uses core directly.

Great! Once it is fixed, will this method be faster than loop and sum?

@shaozi: Yes, once this is fixed, it should be vastly faster than looping manually over the objects. Internally we're able to iterate over all relevant values of the column and to add up those without having to instantiate full accessor objects in the Objective-C runtime for every object in the array.

When will the fix be merged?

When will the fix be merged?

It's fixed in core, but we need a new release of our core binaries, which should happen soon.

A fix for this was merged in #3015. Thanks all for reporting this and helping us identify what was wrong!


config.telefuncFiles: Wrongly formatted path

I tried the babel example from telefunc/examples/babel folder and had the following error:
 Debug info (this is for the Telefunc maintainers; you can ignore this): Wrongly formatted path: C:\CodeW\telefunc\examples\babel\hello.telefunc.mjs.
    at assertPosixPath (C:\CodeW\telefunc\telefunc\dist\cjs\utils\filesystemPathHandling.js:21:25)
    at isTelefuncFilePath (C:\CodeW\telefunc\telefunc\dist\cjs\utils\isTelefuncFilePath.js:7:50)
    at C:\CodeW\telefunc\telefunc\dist\cjs\node\server\serverConfig.js:48:69
    at Array.forEach (<anonymous>)
    at Object.validateUserConfig [as set] (C:\CodeW\telefunc\telefunc\dist\cjs\node\server\serverConfig.js:45:13)
    at file:///C:/CodeW/telefunc/examples/babel/server.mjs:10:24

Windows 10
Node.js v18.17.1
maybe windows related?

Fix pre-released in 0.1.60-commit-e16c585, can you confirm it's working now?

I see 2 more errors (the second error will be in the next comment):
fail on assertion-  assert(filePath.startsWith('/')) in isTelefuncFilePath.ts
I had a print of the filePath so the stack is +1 in line number below.
filePath   C:/CodeW/telefunc/examples/babel/hello.telefunc.mjs
node:internal/process/esm_loader:97
    internalBinding('errors').triggerUncaughtException(
                              ^

Error<EMAIL_ADDRESS>You stumbled upon a bug in Telefunc's source code. Reach out at https://github.com/brillout/telefunc/issues/new or https://discord.com/invite/3DYWwk4xRQ and include this error stack (the error stack is usually enough to fix the problem). A maintainer will fix the bug (usually under 24 hours). Don't hesitate to reach out as it makes Telefunc more robust.
    at isTelefuncFilePath (C:\CodeW\telefunc\telefunc\dist\cjs\utils\isTelefuncFilePath.js:9:25)
    at C:\CodeW\telefunc\telefunc\dist\cjs\node\server\serverConfig.js:48:69
    at Array.forEach (<anonymous>)
    at Object.validateUserConfig [as set] (C:\CodeW\telefunc\telefunc\dist\cjs\node\server\serverConfig.js:45:13)
    at file:///C:/CodeW/telefunc/examples/babel/server.mjs:10:24

on windows fail to load the resolve .telefunc.mjs file:
Server running at http://localhost:3005
filePath   C:/CodeW/telefunc/examples/babel/hello.telefunc.mjs
filePath   /hello.telefunc.mjs
filePath   /hello.telefunc.mjs
Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'
   at new NodeError (node:internal/errors:405:5)
   at throwIfUnsupportedURLScheme (node:internal/modules/esm/load:131:11)
   at defaultLoad (node:internal/modules/esm/load:82:3)
   at nextLoad (node:internal/modules/esm/loader:163:28)
   at ESMLoader.load (node:internal/modules/esm/loader:603:26)
   at ESMLoader.moduleProvider (node:internal/modules/esm/loader:457:22)
   at new ModuleJob (node:internal/modules/esm/module_job:64:26)
   at #createModuleJob (node:internal/modules/esm/loader:480:17)
   at ESMLoader.getModuleJob (node:internal/modules/esm/loader:434:34)
   at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Alright, it should now be fixed as the CI now also runs /example/babel/ on Windows. Can you confirm? I'll then release the fixes.

fixed!
for the server-side:
other than automatic TypeScript runtime validation, is there any other benefits using telefunc transformer over telefuncFiles?
While trying telefunc with DigitalOcean Functions (serverless), i found telefuncFiles a bit easier to setup.

It's also less bookkeeping.
Released as 0.1.61.


P38

the last closing parenthesis  ")" in the book at page 38
Scope.prototype.$applyAsync = function(expr) {
var self = this;
self.$$applyAsyncQueue.push(function() {
self.$eval(expr);
});
});
is wrong, should not exist

Fixing, thanks


How to swap out Pydantic-settings

I am trying to use this template to create a FastAPI + Langchain project, however, Langchain only supports Pydantic < v2 while Pydantic-settings which is tightly coupled with Pydantic + FastAPI depends on Pydantic v2.0+.
Any tips on how to swap it out?

There's no way to swap pydantic version from cli, but this option exists.
Just clone the repo, add this line context.pydanticv1 = True here https://github.com/s3rius/FastAPI-template/blob/master/fastapi_template/main.py#L20, right before the actual generation.
I'll make an option later. Actually, you can make a PR that adds this option, I'd really appreciate this.

@s3rius
PR opened: https://github.com/s3rius/FastAPI-template/pull/184


Duplicate Listing in api view

I have a simple controller with one exposed method /trails that is type get that returns list of trails. when I visit http://localhost/trails/api I have duplicate listings of the get call.
/trails
GET : /trails
GET : /trails
They both work as expected, but why are they duplicated within the api view?  For simplicity I have it boiled down to the simple case.
The application is within a java spring environment using gradle for build and dependency management.

I am using tomcat 7 and i have integrated swagger-springmvc in my project.
My Controller is as follows
@RestController
public class HelloController {
@RequestMapping(method=RequestMethod.GET,value="ninad/hello")
@ApiOperation(httpMethod = "GET", value = "Say Hello To World using Swagger")
public ResponseDate sayHelloInMobileGateway() {
ResponseDate res= new ResponseDate();
res.setMessage("Greetings from ninad!");
return res ;
}
}
When i deploy it as war file, on Spring UI, i can see this method picked up 4 times.  Did i missed out anything?