Cherrypick #10379 back on master (Addresses #13880)

I'm not sure of the status of
pilot/pkg/proxy/envoy/v2/discovery.go
that currently contains a mutex locking strategy dating back from October
while #10379 1.0 change happened 2 months later.
The pushContext mutex strategy seems replaced by some version mutex,
I will gladly have another pair of eyes looking at that.

As for the mutex logic of eds.go, I followed #10379 @costinm would be the best judge to know if this cherrypick makes sense or not.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: fpesce
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: greghanson
If they are not already assigned, you can assign the PR to them by writing /assign @greghanson in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fpesce: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
af528e188a93db61a7e0b9efca310c567cc45873
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fpesce: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
af528e188a93db61a7e0b9efca310c567cc45873
link
/test e2e-mixer-no_auth-master

prow/integ-pilot-k8s-presubmit-tests.sh
af528e188a93db61a7e0b9efca310c567cc45873
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-master

@fpesce: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
af528e188a93db61a7e0b9efca310c567cc45873
link
/test e2e-mixer-no_auth-master

prow/integ-pilot-k8s-presubmit-tests.sh
af528e188a93db61a7e0b9efca310c567cc45873
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master

@fpesce: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
af528e188a93db61a7e0b9efca310c567cc45873
link
/test integ-pilot-k8s-presubmit-tests-master

prow/e2e-mixer-no_auth.sh
af528e188a93db61a7e0b9efca310c567cc45873
link
/test e2e-mixer-no_auth-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth-master

/test integ-pilot-k8s-presubmit-tests-master

/test integ-pilot-k8s-presubmit-tests-master

(last call before I close #14339 @costinm  / @howardjohn , because you said in environment meeting 1.1 is heavily tested and should not have bugs, even if this specific code definitely look like it didn't land in master from 1.0)

Closing sgtm. If we run into mutex issues we can refer back to this for potential fixes but for now let's not fix what isn't broken as discussed


Question about the value of 'fov' for 'ns-render camera-path' that can render exactly as in training dataset

Hi, thank you for making the project available to the public and for maintaining it.
I have a question about the value of 'fov' used in camera_path.json. How can I find the value of 'fov' such that the rendered images from ns-render camera-path are the same/close to that obtained from ns-render dataset or is this possible?
I'm current computing these values using the focal length in transforms.json as below.
fov_x = 2 * std::atan(0.5 * image_width / f_x);
fov_y = 2 * std::atan(0.5 * image_height / f_y);
I tried both fov_x and fov_y but I can't get the results closer to the original training images.
Due to some limitations of the repo I used, my camera poses are optimised prior to the training. However, I have applied dataparser_transforms to the exported camera pose using ns-export when computing the camera-path.json file. Does this affect the rendered results or do I have to apply any transform to 'fov'?
Thank you very much for your help.

To answer one of my questions, it's fov_y = 2 * std::atan(0.5 * image_height / f_y) if the camera poses are not optimised.


bug: Weird symbol/character!!

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[x] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.9.4
Operating system/version
Arch Linux
Describe the bug
I tried many nerd fonts and configured fontconfig with fallback fonts as well, everything looks good except this character keep showing idk how to remove it.

Steps To Reproduce

installed LazyVim.
installed some extras from :LazyExtras = dap,lsp,.... this issue appears exactly after enabling lang.rust Extra.
no configuration added except some recipes from documentation page.

Expected Behavior
i just want this character to disappear from the editor.

It seems that you have some kind of transparency. Are you sure it's not something showing from the background?
no its not, i configured terminal to no transparency, but no luck.

Maybe it's a problem with the fonts you use? Have you tried different fonts?

I missed reading the part about you trying different fonts, sorry about that. I'm afraid I'm out of ideas, especially since I can't reproduce the issue, as everything looks normal on my end when I enable the lang.rust extra, as shown in the picture in my first post.

Edit: I imagine your terminal is properly configured to use the fonts that you use, right?

yes, in system fontconfig:
<family>monospace</family>
  <prefer>
   <family>JetBrainsMono Nerd Font</family>
   <family>Noto Color Emoji</family>
   <family>Symbols Nerd Font</family>
  </prefer>

on Alacritty settings:
# Font configuration
font:
  normal:
    family: JetBrainsMono Nerd Font
  size: 11.0

I'm sorry, but if it's running fine on other terminals (I use kitty and cannot see this issue), then it's definitely a rendering issue. I would suggest switching to another terminal, since the alacritty team doesn't seem to consider this their fault. I don't know whose fault it is, but it definitely is not LazyVim's fault. The terminal uses the font you use to render that icon. That icon is probably provided by rust-tools codelens. So, you might want to take it up there if you like.

i think lts time to go with kitty terminal.

Hi @sentakuhm,
Could you close this issue?


Is there a way to get pdf's total number of pages?

I know there are many ways to do this, but when people use ImagePut, they probably prefer to use the built-in methods of ImagePut.

I am thinking that
index = 1 ; first page
index = 2 ; second page
index = 3 ; third page

index = 0 ; All pages

index = -1 ; Last page

If this is the case is it still necessary to get the total number of pages?
loop
    try ImagePutFile({pdf: "1.pdf", index: A_Index})
    catch
        break

I agree with this
index = 1 ; first page
index = 2 ; second page
index = 3 ; third page

index = 0 ; All pages

index = -1 ; Last page

maybe no longer need to get the total number of pages.

index = 0 ; All pages will be very hard to implement.


How to compare more than one image

I have two objects I need to compare, but for one I only have two pictures (two descriptors) and for the other three pictures(three descriptors), so, how can I try to match them if the descriptors array must have same length ?

You compute the distance of every descriptor of image1 with every descriptor of image2. Those distances which are < 0.6 correspond to a match.


TreeNode move is losing index path level

https://github.com/DeclarativeHub/Bond/blob/256bb4bb2492670dd0f9957a7c0b178137b60a3a/Sources/Bond/Observable Collections/TreeChangeset.swift#L106
I think it's coming from this method, but I'm not 100% sure.
Given the following data structure:
┌───┐
│ 0 │
└───┘
  │    ┌───┐
  ├───▶│ 0 │
  │    └───┘
  │    ┌───┐
  └───▶│ 1 │
       └───┘

If I call move like so:
myCollection.move(from: [0, 1], to: [0, 0])

My custom data binder subclass receives the following operation via the applyOperation method:
.move(from: [0, 1], to: [0])

There appears to be a separate move that comes after this, but I can't get to that data in LLDB at the moment.
This doesn't seem right, but I'm having trouble finding the point where it's falling apart (I actually assume it's within generatePatch(…)).
Any thoughts? I'm happy to fix it, if you can point me in the right direction.

Hmm, 2-level index paths are invalid for the tree in your example. For example, index path [] refers to the root node, index path [1] refers to the second child of the root node, while index path [1, 2] refers to the third child of the second child of the root node.
Following works correctly for me:
var t = TreeNode("Child 00", [
    TreeNode("Child 000"),
    TreeNode("Child 001"),
])

let ot = MutableObservableTree(t)

ot.observeNext { (cs) in
    print(cs.collection, cs.diff, cs.patch)
}

ot.move(from: [1], to: [0])

When I do ot.move(from: [0, 1], to: [0, 0]), it crashed as expected.

┌───┐
│ 0 │
└───┘
  │    ┌───┐
  ├───▶│ 0 │
  │    └───┘
  │    ┌───┐
  └───▶│ 1 │
       └───┘
┌───┐
│ 1 │
└───┘
  │    ┌───┐
  ├───▶│ 0 │
  │    └───┘
  │    ┌───┐
  └───▶│ 1 │
       └───┘

Right, but in this situation (which is what I have), wouldn't a move from [0, 1] to [0, 0] be valid?

That would be valid, sure. I can't reproduce you issue though:
var t = TreeArray([
    TreeNode("Child 0", [
        TreeNode("Child 00"),
        TreeNode("Child 01")
    ]),
    TreeNode("Child 1", [
        TreeNode("Child 10"),
        TreeNode("Child 11")
    ])
])

let ot = MutableObservableTree(t)

ot.observeNext { (cs) in
    print(cs.collection, cs.diff, cs.patch)
}

ot.move(from: [0, 1], to: [0, 0])

correctly gives me:
[(Child 0: (Child 01: -), (Child 00: -)), (Child 1: (Child 10: -), (Child 11: -))] Inserts: [], Deletes: [], Updates: [], Moves: [(from: [0, 1], to: [0, 0])] [M(from: [0, 1], to: [0, 0])]

Yeah, this seems to be an issue in my implementation. Sorry for taking up time on it!


Fixing Confirmation page observations

	- [x] Review all transaction information
	- [x] Maintain all boxes with the same width
	- [x] Use 2 lines to display the addresses
	- [x] Include 0x at IN THE OP_RETURN for Ledger only
	- [x] For Trezor hdwallet display only 3 columns
	- [x] Remove unused information for native
	- [x] Remove unused information for flyover
	- [x] Include the copy button in all addresses
	- [x] Include the button to see address in the explorer

For flyover Pegin confirm bar is bigger than steps columns


OSL fails to compile with openimageio-<IP_ADDRESS>

Compiling osl-1.10.10 with openimageio-<IP_ADDRESS> fails with formatting of non-void pointers is disallowed.  The problem arises in liboslexec/context.cpp  in lines 100-101               info ("  ShadingContext %p growing heap to %llu",                   this, (unsigned long long) heap_size_needed); which tries to format an integer.
Versions

OSL 1.10.10:

OS: Gentoo Linux

openimageio-<IP_ADDRESS>

C++ compiler:  gcc-10.2.1

This was fixed in 1.10.13, released on August 1.


Android Playbook not installing android-19 anymore

The Android playbook is defaulting to android-21 now. Will need to ensure that either we bump our setup commands to android-21 or force the install of android-19.

This has been fixed.


Add additional fields for CoinMarketCap v1 API

Added rank in CmcCurrency
Added 5 new fields related to percent change and market cap in CmcQuote
Added additional sort param for cryptocurrency/map endpoint
Updated json payloads for tests

Reference can be found here: https://coinmarketcap.com/api/documentation/v1/#

:O


Add 'console log' to upstart scripts

This will capture stdout and stderr to logfiles under /var/log/upstart, which is very helpful when homu and/or buildbot wake up on the wrong side of bed.
Docs at http://manpages.ubuntu.com/manpages/trusty/en/man5/init.5.html.

Just kidding, this is already enabled!


Adding badges

Pull Request Test Coverage Report for Build 26

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.0%

Totals

Change from base Build 24:
0.0%

Covered Lines:
174

Relevant Lines:
184

💛  - Coveralls

:tada: This PR is included in version 2.1.4 :tada:
Your semantic-release bot :package::rocket:


Support ES module output

When used in an Angular app, this library causes build warnings about possible optimization bailouts, due to it being a CommonJS module. This PR moves the cjs output to dist/cjs, and adds a new output folder of dist/esm for ES module output.
Additionally, the package would not build on Windows previously due to the use of mv and rm in the build scripts. With moving the tsconfig.json to the src folder, and removing demo from the default tsconfig includes, those steps are no longer necessary. clean was also updated to use rimraf instead of rm -rf.
However, currently the webpack command to build the demo does not work on my machine, and I cannot figure out why. I wanted to put this PR in front of you for your feedback. Let me know what you think. Thanks!

FWIW, checking package-lock.json into source control is best practice, but if you'd prefer removing that, I can update this PR.
Node docs: https://nodejs.dev/learn/the-package-lock-json-file

The package-lock.json file needs to be committed to your Git repository, so it can be fetched by other people, if the project is public or you have collaborators, or if you use Git as a source for deployments.

We are using yarn.lock, which is essentially the same thing, but don't want to have both!

I am going to put up another PR, and would love your review/test on it to make sure it works for you.

Can you take a look at #7 to see if it satisfies all of your requirements? If so I will merge that in and release a new npm version.
(sorry for closing this PR, I don't know how to get a commit to your fork!)

Ah, I'm not a big yarn user so I missed that. Thanks for considering this and jumping on it so quickly! This library has been super valuable to me. I appreciate it.


Rename common_runtime directory to common-runtime for consistency with other crate directory names

Is your feature request related to a problem or challenge?
The new common_runtime directory uses an underscore as a separator, but other crates, such as physical-expr and functions-array use a hyphen. I think it would be better to stick to one format.
Describe the solution you'd like
Rename common_runtime directory to common-runtime for consistency with other crate directory names
Describe alternatives you've considered
No response
Additional context
No response

I will make a PR for this shortly


Run start/stop goals standalone

Hi,
I was just curious if you were making a standalone start/stop plugin?  We have appium installed with our appium build but would like to use your pluggin to start/stop the appium server since we area already installing npm and node.
Thanks


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v 2.5.4
What problem did you encounter?
System.AggregateException: One or more errors occurred. (The given key 'content-platform-dictionaries.zip' was not present in the dictionary.)
[Inner Exception]
System.Collections.Generic.KeyNotFoundException: The given key 'content-platform-dictionaries.zip' was not present in the dictionary.
Bloxstrap Log
file:///C:/Users/rboon/AppData/Local/Temp/Bloxstrap_20241214T151446Z.log

Update to the latest version.

Update to the latest version.
can u explain how?

Just go here https://github.com/bloxstraplabs/bloxstrap/releases/tag/v2.8.1 (or the main page of the repository then releases) and download the .exe


Ensure defined attributes do not overwrite existing methods

Because overwriting existing methods with component attributes or elements is bad.

Looks great! Thanks for the contribution :)


Find Method for Seamless Arrays

Seamless-Immutable Arrays lack .find method, therefore one is force to .filter(...)[0] which saddens.

Tripped me up too, would be a great addition.

How come there is no find-method? Would have been great!

Isn't find in the prototypical inheritance tree (Array is the prototype)?


Upgrade to TF 2.6

/modeltest
include:
 - dataset: ["all"]
   config: ["all"]

Note also that some places now use the Keras library, as this was split off in TF 2.6 (see here)

Just fyi: sth is wrong with the GPU runner lib. So I canceled the tests running

/modeltest
include:
 - dataset: ["Carbon Bot"]
   config: ["Sparse + DIET(bow) + ResponseSelector(bow)"]

Note: as per discussion here, we can't set TF_DETERMINISTIC_OPS to true anymore:

Stock TensorFlow version 2.6+ will throw a tf.errors.UnimplementedError if the nondeterministic path through this op is used with the expectation of determinism (i.e. with TF_DETERMINISTIC_OPS set to "true" or "1").

@dakshvar22 please see note above.. I've had to disable TF_DETERMINISTIC_OPS for our GPU model regression tests. What else do you think is needed? Not sure if I should make a PR to add this to the docs, or maybe print a warning if the env var is set that it will crash with sparse features?

I think the impact of that will be that we'll probably see more triggers of the regression warnings on slack? I think currently it accounts for 2-3% of regression between runs but that was taking into account the nondeterminism of tf.sparse.matmul alone. However, if we completely remove the flag we might see larger regressions between runs? How about we create a separate issue which cross-checks whether the amount of allowed regression needs to be tweaked?

How about we create a separate issue which cross-checks whether the amount of allowed regression needs to be tweaked?

Yes, definitely, thank you! I was going to see how this latest round of regression tests goes and then create the issue with that context. I'm not as concerned about the internal stuff, though bc I figure I can let everyone on the team now what they might need to expect.
I'm more worried that users may see crashes now if they had been setting TF_DETERMINISTIC_OPS, where they didn't see crashes before. To be clear, we never had determinism there, but I think most users probably didn't know this

Not sure if I should make a PR to add this to the docs, or maybe print a warning if the env var is set that it will crash with sparse features?

I think TF will anyways crash if the env var is set to that. If we want to add a warning from our code then we'll have to:

Detect whether the env var is set
Detect whether GPU will be used.

There are hacky ways of doing (2) but (1) we can do very cleanly I suppose. How about we add a warning in our code which checks for (1) alone?
Let's also add this information to our docs and the changelog as part of this PR then.

@dakshvar22 as you can see we’re running into OOM on the TF 2.6 PR for:
BERT + DIET(seq) + ResponseSelector(t2t), Hermit
and Sparse + BERT + DIET(seq) + ResponseSelector(t2t), Hermit
I tried re-running them, and also re-running just one of them (jic memory wasn’t being freed or other weirdness) but no dice.
I’m thinking I can run them on a gcloud instance and check whether there was a drop in accuracy there for this particular PR.
As for the scheduled tests, I’m thinking maybe skip those particular tests for now, and create a followup issue to re-enable them once memory issues have been addressed post-upgrade.
What do you think?

As for the scheduled tests, I’m thinking maybe skip those particular tests for now, and create a followup issue to re-enable them once memory issues have been addressed post-upgrade.

Or reduce the size of the dataset and create a follow up issue to revert it back to original size when the memory issues are addressed? That way we don't lose a dataset + config combo for model regression runs on PRs (I know there are going to be quite a few of them close to the 3.0 release).

@koernerfelicia I am sorry, I misinterpreted the OOM error to be one from CPU and not GPU. When I look at it again, it seems like when the batch size increases to 224, GPU runs out of memory. Decreasing the dataset size will not help here. Lets go with your suggestion then of disabling the particular pair of datasets + config.

@dakshvar22 good catch, I hadn't come to this realisation.


Please add a way to copy cipher contexts

I am currently working on OpenSSL bindings for the declarative programming language Prolog:
http://eu.swi-prolog.org/pldoc/man?section=crypto
In this language, destructive modifications of existing terms must be avoided. For the bindings I have provided so far, I am always internally copying contexts, and then modifying the fresh copy, thus preserving existing contexts. This has important benefits regarding thread safety etc. and already works for the hash API via EVP_MD_CTX_copy_ex.
I now would like to add a way to incrementally encrypt and decrypt data, and I find that the OpenSSL API falls short in the following respect:
Currently, there is no way to copy ciphers contexts. Please add such an API.
For example, in analogy to EVP_MD_CTX_copy_ex, please add EVP_CIPHER_CTX_copy_ex.
Thank you!

Err...there is an EVP_CIPHER_CTX_copy()?
https://github.com/openssl/openssl/blob/master/include/openssl/evp.h#L471

Yes, thank you! However, could you please make this officially available by documenting it? It seems completely undocumented as far as I can tell.

Yes it's undocumented.  Too much of the API isn't documented.  But that doesn't mean it's not official.  The fact that it is in a public header file is sufficient.


Order models by name, model provider

The current order is random in the UI.

Ideally, I want each models to sorted alphabetically and grouped by model provider. See how openai does it below:

Additionally let's make it a combo box to allow users to filter results via their keyboard

When testing with version -   "obot": "v0.0.0-dev+264972e6"
Model dropdown in now ordered by name and model providers.


Add command pallete like for search

We would like to have some command pallet like is in VSCode or in Obsidian

Mission

we would like to speed up collectors search to be more convenient
style with bulma
keyboard shortcut to call pallet
bounty price could be extended

Found components

https://github.com/james2doyle/vue-omnibar
React https://npm.io/package/react-command-palette
https://www.npmjs.com/package/vue-ace-palette - http://derekries.github.io/angular-palette/#/

Hi @yangwao. I just needed clarifications on a few doubts. Should the search bar be modified to show suggestions like command palette, or the command palette appears only when called(via keyboard shortcuts)? The suggestions to be displayed are collection names, right? or categories also like audio, images etc?

it's working on vite.dev https://vitejs.dev/ using Algolia https://www.algolia.com/pricing/ isn't that expensive!

Hi @yangwao. I just needed clarifications on a few doubts. Should the search bar be modified to show suggestions like command palette, or the command palette appears only when called(via keyboard shortcuts)? The suggestions to be displayed are collection names, right? or categories also like audio, images etc?

Oh, I've missed this one.
Yeah, it could work appear on keyboard shortcut, maybe a button, people will learn later.
Yeah searching over collections would be best and showing nft names.

Good idea, it could be somehow joined with #348

cmd k <3
https://chakra-ui.com/

May option to use CommandBar

👋

It might be interesting to use vue-command-palette

Wow, great find @roiLeo!
However there is just support for Vue3

However there is just support for Vue3

You're right 😢

Blocked by #2081

Now that the app uses vue 3 and already has a cmd+k search bar, is this still needed? If so, what would be the difference with the current one?

@iMac7 wondering the same
maybe speed?

Cc @yangwao can we close?

Cc @yangwao can we close?

Luu said close


Issues while using manifestPlaceholders on Android

Hi there!
Great job with this library, been using it and I love it. However, I've been having some issues with the docs on manifestPlaceholders (Google implementation).
When implementing it in default it wouldn't parse or it would get replaced. I end up with an error and can't get over it. I found this comment https://github.com/openid/AppAuth-Android/issues/323#issuecomment-384318085 that explained it.
Can you help me?
Can I put that string inside the AndroidManifest.xml somehow?

Ok. I was using the onesignal-cordova-plugin so it was replacing my placeholders. Just had to do the following in my grade files:
buildTypes {
        release {
            ...
            manifestPlaceholders.appAuthRedirectScheme = "com.companyname.appname"
        }
        debug {
            ...
            manifestPlaceholders.appAuthRedirectScheme = "com.companyname.appname"
        }
    }

Was confused afterwards of why it was opening twice (thought the placeholders had something to do with it) but #15 fixed that issue for me.
Would you be so kind to mark in that in the docs? Thank you.

Hi,
could you be so kind to point me to the right position in the docs.
In which section would you find the info most useful? I only ask because I want to place it somewhere to be obvious for first time users.
thx

I would love to see under:
Android

Add customScheme in android/app/build.gradle as well. Without :/.

android.defaultConfig.manifestPlaceholders = [
  'appAuthRedirectScheme': 'com.companyname.appname'
]

The following:
Find in your AndroidManifest.xml file the line
<data android:scheme="@string/custom_url_scheme" />
and change it to
<data android:scheme="@string/custom_url_scheme" android:host="oauth" />

Notice: If your appAuthRedirectScheme doesn't get recognized because you are using a library that replaces it (e.g.: onesignal-cordova-plugin), you will have to add it to your buildTypes like the following:

android.buildTypes.debug.manifestPlaceholders =  [
  'appAuthRedirectScheme': 'com.companyname.appname'
]
android.buildTypes.release.manifestPlaceholders = [
  'appAuthRedirectScheme': 'com.companyname.appname'
]

Thanks a lot for this great module!

Thanks for this.


EgorBot for AndyAyersMS in #109209

Processing https://github.com/dotnet/runtime/pull/109209#issuecomment-2439851846 command:
Command
-intel -arm64 -profiler --envvars DOTNET_JitDisasm:TestInner
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
using System.Runtime.CompilerServices;

BenchmarkSwitcher.FromAssembly(typeof(Bench).Assembly).Run(args);

public class Bench
{
    static string[] Data = new string[512];

    [Benchmark]
    public int Test() => TestInner(Data);

    [MethodImpl(MethodImplOptions.NoInlining)]
    int TestInner(ICollection<string> c) => c.Count;
}

(EgorBot will reply in this issue)

Benchmark results on Arm64
BenchmarkDotNet v0.14.0, Ubuntu 24.04 LTS (Noble Numbat)
Arm64
  Job-TLRIDZ : .NET 10.0.0 (<IP_ADDRESS>424), Arm64 RyuJIT AdvSIMD
  Job-AXELQD : .NET 10.0.0 (<IP_ADDRESS>424), Arm64 RyuJIT AdvSIMD
EnvironmentVariables=DOTNET_JitDisasm=TestInner  StdDev=0.0004 ns

Method
Toolchain
Mean
Error
Ratio

Test
Main
1.001 ns
0.0005 ns
1.00

Test
PR
1.188 ns
0.0005 ns
1.19

BDN_Artifacts.zip
Profile for Bench_Test:
Flame graphs: Main vs PR 🔥
Speedscope: Main vs PR
Hot asm: Main vs PR
Hot functions: Main vs PR
Counters: Main vs PR

cc @AndyAyersMS (logs)

Benchmark results on Intel
BenchmarkDotNet v0.14.0, Ubuntu 24.04 LTS (Noble Numbat)
Intel Xeon Platinum 8488C, 1 CPU, 8 logical and 4 physical cores
  Job-JYJDFD : .NET 10.0.0 (<IP_ADDRESS>424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
  Job-SIQINM : .NET 10.0.0 (<IP_ADDRESS>424), X64 RyuJIT AVX-512F+CD+BW+DQ+VL+VBMI
EnvironmentVariables=DOTNET_JitDisasm=TestInner

Method
Toolchain
Mean
Error
Ratio

Test
Main
3.634 ns
0.0087 ns
1.00

Test
PR
3.637 ns
0.0090 ns
1.00

BDN_Artifacts.zip
Profile for Bench_Test:
Flame graphs: Main vs PR 🔥
Speedscope: Main vs PR
Hot asm: Main vs PR
Hot functions: Main vs PR
Counters: Main vs PR

cc @AndyAyersMS (logs)


Fix datetime input in airmass example app

I believe a recent release of suntime changed the expected input type of get_sunrise_time() and get_sunset_time(). https://github.com/SatAgro/suntime/releases/tag/v1.3.0

The failing test is unrelated, I'll work on that in a separate PR

Looks good!


Quick fix tap to focus #286

Simple fix for Tap to Focus:
The issue
The order of the view hierarchy was wrong and the gesture recogniser wasn't able to recognize anything.
Fix
Reorder hierarchy so overlayView is always on top and is able to capture the gestures.
Walk-around
pod 'YPImagePicker', git: 'https://github.com/bithavoc/YPImagePicker.git', branch: 'feature/286'

@s4cha does this look ok to you to merge?

@bithavoc This is a very nice catch! Looking about it I think the fix would be to use
public var overlayView: UIView?

in YPImagePickerConfiguration.swift
This would play nicely with the existing logic and people using the overlayView probably want to receive touch events on it, which means we need to keep it the topmost view.
Do you want to update the PR or should I?
Cheers,


Opening a new project should open in a new window.

VSCode Version: Version: 1.45.1
OS Version: MacOS 10.14.2

Steps to Reproduce:

Have any project open
Go to open
Select some other project and open it
Instead of opening a new window with the new project as everyone on Earth wants the current project is replaced.

 I'm filing this under bug because no one in the history of the world has every gone to open a new project and wanted their current project closed automatically. I have like 5 projects open at once usually. I can't imagine why this behavior would be on purpose. Would someone only want 1 project open at a time? Why would opening something close the thing you're working on? Why would doing something have this undesired side effect? In order to get the behavior you want you need to open a new blank project unnecessarily and then open the project that you want to open. There does not seem to be any technical limitation involved in opening a new project in a new window. Thanks for your help!

Does this issue occur when all extensions are disabled?: Yes

VS Code doesn't use the term 'project'. Presumably you are opening either a folder or a workspace (a file with a .code-workspace extension).
When I open either of these from the Open Recent... submenu, holding Shift down when I click on a recent entry will make it open in a new window. The same happens if I hold down Ctrl instead (I work on Windows).
Similarly, if I hold down Ctrl when I click an entry in the Recent section of the Welcome page, a new window is created.
If you always want a new window, change the window.openFoldersInNewWindow setting.

@gjsjohnmurray Great so you have to hold down a button or change a buried project setting to make if function how any sane person would expect. That's fantastic /s.

No, you can change a setting once and get the behaviour you prefer.

@gjsjohnmurray Or I can use a different IDE that can do one of the most basic things without having to change a setting.

@nickatrokit indeed you can.


fix(requestinterception): fix font loading issue

See upstream: https://github.com/puppeteer/puppeteer/pull/7060
Fixes #1185

Nice job upstream @Androbin!

Can you check the builds here?

I think we are getting consistent fails here @Androbin

This change is needed to fix #1185 but it breaks the ShouldProperlyReturnNavigationResponseWhenURLHasCookies test. The same test was unaffected in upstream JavaScript Puppeteer.
 private Task UpdateProtocolCacheDisabledAsync()
     => _client.SendAsync("Network.setCacheDisabled", new NetworkSetCacheDisabledRequest
     {
-        CacheDisabled = _userCacheDisabled || _userRequestInterceptionEnabled
+        CacheDisabled = _userCacheDisabled
     });

@kblok This PR is ready to merge, let's find out what's keeping us from re-enabling the cache in another ticket.

Maybe the issue is just that PuppeteerSharp.TestServer doesn't honor cookies properly

The PuppeteerLaunchTests.ShouldWorkWithNoDefaultArguments test is unrelated and failing on master branch as well.


typeof does not get concatenated string type

The pattern I used in code below is originally from Redux. When I use strings "as is", without any concatenation, it works. But when I try to move common part (prefix) out, it brokes. Intuitively I assume that since prefix and other parts are constants typeof should get united type.

TypeScript Version:  2.7.0-dev.20171213
Code
const prefix = 'prefix';

const TOKEN1 = `${prefix}/token1`;
const TOKEN2 = `${prefix}/token2`;

interface Wrapper {
    type: string;
}

interface WrapperToken1 extends Wrapper {
    test: string;
    type: typeof TOKEN1;
}

interface WrapperToken2 extends Wrapper {
    other: number;
    type: typeof TOKEN2;
 }

function test(wrapper: WrapperToken1 | WrapperToken2): string {
    switch (wrapper.type) {
        case TOKEN1:
            return wrapper.test;
        case TOKEN2:
            return wrapper.other.toString();
        default:
            return '';
    }
}

Expected behavior:
No errors raised.
Actual behavior:
Raises errors:
Property 'test' does not exist on type 'WrapperToken1 | WrapperToken2'.
  Property 'test' does not exist on type 'WrapperToken2'.

Property 'other' does not exist on type 'WrapperToken1 | WrapperToken2'.
  Property 'other' does not exist on type 'WrapperToken1'.

Duplicate of #12940 -- currently we never compute string literal types for concatenations.

@andy-ms Thanks! Should I close this issue?

I think so, you could add your use case as a comment to that issue.


Added support for a global omnisharp.json

Fixes #717
The global omnisharp.json file location is:

On Windows: %APPDATA%\OmniSharp\omnisharp.json
On Mac/Linux: ~/.omnisharp/omnisharp.json

The folder and an empty {} file are created automatically if they are not there.
The live reload logic introduced here https://github.com/OmniSharp/omnisharp-roslyn/pull/804 also supports this global file, meaning any changes to it are automatically reflected.
The global omnisharp.json file is given a lower precedence than a local one, so global settings can be overridden locally. It is however given a higher precedence than environment variables and command line arguments.

I moved it from APPDATA to USERPROFILE as suggested - the paths are now unified for both OS families ({HOME}|{USERPROFILE}/.omnisharp/omnisharp.json). There is no more automatic file creation, but we still have directory creation there.
Aside from convenience for the user, having the directory there allows us to use the file watcher under the hood of the Options library - as it can watch for a non-existing file, and light up as soon as it's created, which is a nice user experience. This wouldn't be possible if the folder wasn't there.
Also addressed all the other code review feedback.

I think we're in good shape here. @david-driscoll, holler if you disagree.

@filipw: I think this change warrants an update to https://github.com/OmniSharp/omnisharp-roslyn/wiki/Configuration-Options.

indeed 📚


Docker images for meltano 2.x

Opening this tracking issue for the 2.0 docker image.
Follow this issue for updates. 👂

The latest version of meltano Docker images are available for use now from DockerHub. 🎉
Available 2.0 images:
latest
latest-python3.6
latest-python3.7
latest-python3.8
latest-python3.9
v2.0.1
v2.0.1-python3.7
v2.0.1-python3.8
v2.0.1-python3.9

Note: These images should be lighter weight than Meltano's pre-2.0 docker images, making for faster download and and run experience.


new feature: any savepoint to change runtime layer parameters

Feature Description
E.g, i would like to change rate limit  or concurrent limit at runtime ,but i can only stop it and start it again. Can it change the layer parameter at some savepoint time?
Problem and Solution
add checkpoint time
Additional Context
No response
Are you willing to contribute to the development of this feature?

[ ] Yes, I am willing to contribute to the development of this feature.

E.g, i would like to change rate limit or concurrent limit at runtime ,but i can only stop it and start it again. Can it change the layer parameter at some savepoint time?

I believe you can implement a layer and store it's value inside Arc<Mutex<usize>>.


Added support for maven

@daniellavoie I'd rather not have to maintain two sets of build files for Gradle and Maven for a sample project. Is there an objection to using Gradle to build the project?

Just pure accessibility as this is a sample project. Besides from that I have no hard opinion :)


add scipy for Dockerfile

Dockerfile lack scipy module, docker image build:
from mmdet.apis import init_detector, inference_detector
ModuleNotFoundError: No module named 'scipy'

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

scipy has already been in optional.txt. Maybe you should try directly add pip install -r requirements in dockerfile ？

Hi
@mukangt
We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have a WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤


Package multiple configs?

Currently, scikit-build-core builds a CMake project only once, in Release mode by default. It would be useful to be able to additionally package Debug binaries.
This would involve re-configuring with -DCMAKE_BUILD_TYPE=Debug in place and re-running the build for single-config generators (Ninja). For multi-config generators (e.g. Visual Studio), it would need to run cmake --build ... --config Debug. Then one would simply install to the same prefix.
Naturally this should be opt-in, perhaps by setting cmake.build-type to a list of types. It might additionally be useful to provide an option to use multiple build directories rather than reconfiguring in place when using a single-config generator. Some projects break under such circumstances.

Would make sense for non-python wheels.
What is the install process for the libraries in this case? And how would the python library part make sure it is linked to at least one version of the library? I think this would make sense in the editable environment, but I'm not sure about the wheel install part.

We should look at what py-build-cmake does, as that is supported there. Maybe this would make more sense once we have an install command?


Default session length and cookie expiry to match Google Analytics

Shouldn't the default session length and cookie expiry match the defaults in Google Analytics (30 min and 2 years)?
utm_form defaults to 1 hour and 1 year.
What do you think?

Session length is configurable using _uf.sessionLength


[QUERY] Throughput control failing - Cosmos Spark Connector on Azure Databricks / PySpark

Query/Question
The throughput control on the Cosmos spark connector seems to be failing to provide even a nominally close throttle of throughput usage. We currently have 40000 RU/s set globally across our DB. Generally, we only interact with one collection at a time. We also confirmed that our partitionKeys were evenly distributed (because I am aware that each partition only receives an equal share of the global RU). However, with setting throughput control to say 0.5 on a particular pipeline, it will almost always hit 100% usage. It depends on the query, but in some cases I even have it set to 0.01 and it still uses over 50% when reading a subset of columns from a single collection.

We first tried using the globalControl configuration and came across that the throughput container was in itself causing all RU/s to be consumed. The container queried is around 6 million documents. Not sure on average size but I can get that information. Something like 10,000 of ours records costs 140 RU I believe.

(
        spark.read.format('cosmos.oltp')
        .option(
            'spark.sql.catalog.cosmosCatalog.spark.cosmos.accountEndpoint',
            cosmos_endpoint,
        )
        .option('spark.cosmos.read.inferSchema.enabled', 'true')
        .option('spark.cosmos.accountEndpoint', cosmos_endpoint)
        .option('spark.cosmos.accountKey', cosmos_master_key)
        .option('spark.cosmos.database', db)
        .option('spark.cosmos.container', container)
        .option('spark.cosmos.read.partitioning.strategy', 'Aggressive')
        .option('spark.cosmos.throughputControl.enabled', 'true')
        .option('spark.cosmos.throughputControl.name', 'ThroughputControl')
        .option('spark.cosmos.throughputControl.targetThroughputThreshold', '0.5')
        .option('spark.cosmos.throughputControl.globalControl.container', throughput_container)
        .option('spark.cosmos.throughputControl.globalControl.database', db)
        .load()
        .select(
          'id',
          'address', 'city', 'state', 'zip_code',
          'address_2', 'city_2', 'state_2', 'zip_code_2',
          'address_3', 'city_3', 'state_3', 'zip_code_3',
          'old_residences'  # an array of objects
        )
        .write
        .option('overwriteSchema', 'true')
        .mode('overwrite')
        .saveAsTable('some_schema.address')
 )

This hit the full 40,000 RU/s and stayed there until completed.

Next we tried using local control, aka .option('spark.cosmos.throughputControl.globalControl.useDedicatedContainer', 'false')

Which also using a targetThroughputThreshold = 0.5 maxed out RU usage pretty much immediately.

Finally, with some experimentation we tuned to using 0.01 for that particular query and it hovered at 23k usage but sometimes even spiked to the full 40k usage for several minutes.

While I'm aware the threshold set has no guarantee to be how many RUs are consumed, it seems pretty insane that setting it to 1% still uses over 50% of global RUs.
Why is this not a Bug or a feature Request?
I am unsure if this is a bug, considering I don't see any other issues posted here that talk about this. So, I'm curious if I'm doing something incorrectly.
Setup (please complete the following information if applicable):

Azure Databricks 12.2 LTS ML - Apache Spark 3.3.2, Scala 2.12
Using PySpark
com.azure.cosmos.spark:azure-cosmos-spark_3-3_2-12:4.24.1

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Query Added
[x] Setup information Added

@kushagraThapar could you help route this issue?

@xinlian12 can you please take a look at this, thanks!

@kushagraThapar @xinlian12 heartbeat check on this?

@bmckalla for the RU usage, are you referring to the normalized RU usage or the avg RU usage. currently the throughput control is a best efforts, so you might still see it hitting 100% normalized RU usage.
From the config you have shared, can you try the following two changes and see how it goes:

use Restrictive read strategy: spark.cosmos.read.partitioning.strategy -> Restrictive
try the #1 change first and check whether any RU usage change. If not, tune down this parameter spark.cosmos.read.maxItemCount to 100 or 10.


mergekit_with_sparsify

PR types

New features
PR changes

Others
Description

add merge kit

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: lugimzzz:white_check_mark: Mangodadada:x: huangziyihuangziyi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


cmd/fetch- use FileSource

https://github.com/ziglang/zig/pull/7959 got merged, so update deps.zig generation to account for it.
I planned to update the deps.zig file for zigmod itself, but looks like aquila.red is down. I validated the change works in a project of mine (ran zigmod fetch && zig build in it).

great to hear, can you also change the zig version string in README.md, docs/README.md, and .circleci/config.yml to the zig version you tested with?

Thanks! I've been away from my main laptop the past few days so I really appreciate this :)

Aaaand I shouldn't have merged this yet because the self used deps.zig wasn't updated. That's my bad. Also for not having PR CI.

deps.zig is now updated so anyone trying should be able to build from source. however, the CI still failed from Aquila being down. I will be remedying this asap on the 26th when I am able to access the server again and putting in place multiple measures to prevent downtime like this from happening again in the future.


What is the attention map?

What is the attention map? Is it the same as a feature map? What is the gt attention?

I have the same problem


v3.6.0

Date
2022-04-18
Changelog

feat: combatant update locker
fix: combatant detail not displayed issue
fix: dev panel backdrop filter
chore: move mocking into dev panel
chore: tree-shaking sentry when no env set
build: react-redux v8 for future concurrent mode

Thank you!!


[RFC] migrate from stitches

Overview
Stitches is no longer actively maintained since June 2023. It is not a problem for the moment, but it might pose problems if we want to keep up with the ecosystem in the future (for example, if we wanted to use Next.js app folder, stitches wouldn't play so well with it).
We might want to consider to start migrating from stitches to another alternative.
Related discussion: https://github.com/stitchesjs/stitches/discussions/1149
Additional context
Possible alternatives:

Panda
cva
Linaria

Notes from discussion 06/03

vanilla-extract is out of context of discussion for now
Panda seems the easiest to migrate to - similar syntax, some shared functionalities
cva only has variants as the plus point, on other points Pandas still preferable
Linaria seems like it doesn't have the necessary functionalities that we'd need

Next steps

dig deeper into Panda, identify any possible pain points to migrate
rediscuss and define tasks to migrate

StyleX could be another choice too. We are doing a PoC on it.


Create new Merge Template list

We needs to reproduce the legacy MergeTemplate list.
We need to:

Read in the merge templates in a sheet from the /api/MergeTemplates/{SheetId} endpoint. This will require the MergeTemplate.js store to be updated.
The Home component will need to be updated to display the merge templates
Routes will have to be added for editing and previewing templates.  New components should be added for these but should not be implemented - just placeholders for future implementation
Placeholder button is needed to run the template
Placeholder button is needed to delete the template


Add some vertical space to drawer items on mobile

Description
Clearly and concisely explain the problem.
You can mention unclear or missing information, typos, grammatical mistakes, etc.
Any contributions and suggestions are welcome!
From Aldrin:

The menu items probably need some y padding, they look very close to each other in mobile almost zoomed for me

@NiccoloMenozzi what do you think?
Website Section URL
Website live preview, paste the page URL or section name (eg. Docs, if it happens on all docs page) below.
Everywhere

We can increase the size for mobile devices in order to improve the tapping area but I would wait for the desktop part. The new denseness is nothing really out of standard (36 pxl) and it will help navigate pages while reducing a bit the necessity to scroll. It also helps reducing a bit the material look-and-feel in favor of a stronger identity. As far as the pages are so many as now, it is absolutely acceptable to adopt a dense items list.

From Luke too

left drawer could be spaced out a little more
Left drawer spaced out basically means a bit of padding above and below the list items


fix(ssa): RC correctness issue

Description
Problem*
Resolves #6123
Summary*
Still a draft as I want to test it a bit more and am not fully sure if it is the best solution.
Additional Context
Documentation*
Check one:

[X] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

SSA after this PR:
After Array Set Optimizations:
brillig fn main f0 {
  b0():
    inc_rc [Field 0, Field 0]
    v4 = allocate
    store [Field 0, Field 0] at v4
    v5 = allocate
    store u32 0 at v5
    inc_rc [Field 0, Field 0]
    v8 = allocate
    store [Field 0, Field 0] at v8
    jmp b1(u32 0)
  b1(v0: u32):
    v10 = lt v0, u32 2
    jmpif v10 then: b6, else: b2
  b6():
    v23 = lt v0, u32 2
    jmpif v23 then: b7, else: b8
  b7():
    v24 = cast v0 as Field
    v25 = load v5
    v26 = lt v25, u32 2
    constrain v26 == u1 1 '"push out of bounds"'
    v28 = load v4
    v29 = load v5
    v30 = load v5
    v31 = array_set v28, index v30, value v24
    inc_rc v31
    v32 = add v29, u32 1
    store v31 at v4
    store v32 at v5
    dec_rc v31
    dec_rc v31
    jmp b8()
  b8():
    v33 = add v0, u32 1
    jmp b1(v33)
  b2():
    v11 = load v4
    v12 = load v8
    v15 = array_set v12, index u32 1, value Field 27
    store v15 at v8
    inc_rc v11
    v16 = array_get v11, index u32 0
    inc_rc v11
    v17 = array_get v11, index u32 1
    inc_rc v11
    v18 = array_set v11, index u32 1, value v16
    inc_rc v18
    v19 = array_set v18, index u32 0, value v17
    store v19 at v4
    dec_rc v19
    jmp b3(u32 0)
  b3(v1: u32):
    v20 = eq v1, u32 0
    jmpif v20 then: b5, else: b4
  b5():
    v21 = array_get v11, index v1
    constrain v21 == v16
    v22 = add v1, u32 1
    jmp b3(v22)
  b4():
    return
}

Tested on aztec here (https://github.com/AztecProtocol/aztec-packages/pull/8730). Regression of 4-6% in a couple constructors and transfer_public.


v2: Initial support for NTNDArray and correct timestamp -> timeStamp

Allow Ophyd V2 to read from an NTNDArray type pva variable.
At the moment it is using the standard array converter, which means that the array is always provided downstream as 1-D - it might be better to eventually do the reshaping into a correctly-shaped NTNDArray in the converter, but this is sufficient for my simple use-case at the moment and it wasn't entirely clear to me how to get at the metadata (i.e. shape) from within the current converter mechanism.
Also fixes a typo (?) of timestamp -> timeStamp, which I think would have affected every pva variable and was preventing me from reading array data over PVA. As far as I can tell from the various PVAccess specs/documents online, timeStamp is always the standard name that is used. Happy to be corrected on this if I'm wrong though...

Unsure why codecov is complaining as the lines affected haven't been touched by this PR, anyone have any ideas?

Seems reasonable to me, though I think we need a test. e.g. adding bits to the .db file here: https://github.com/bluesky/ophyd/blob/master/ophyd/v2/tests/test_records.db and checking that we can successfully extract the NTNDArray type from it.

Test added. Sorry I hadn't quite noticed how these were run previously!

I think @coretl will have some thoughts on the dimensions of these tables, so I think we ought to wait for his input on this.

From my perspective the shape isn't a blocker - I can get shape from elsewhere and reshape downstream. But long term it would be a nice-to-have for the shape to be correct here.

Thanks for this. I'll see about adding some config for codecov to stop complaining when there are tiny changes (i.e. +/- 0.1%) to code coverage for the project/patch...

I've made an issue about the codecov job failing; you can read it here: https://github.com/bluesky/ophyd/issues/1149
There's a PR to introduce tolerances here: https://github.com/bluesky/ophyd/pull/1150
Once that's merged we could rebase this on top of it, and then merge it in. Most likely this will happen tomorrow when the NSLS-2 ophyd v2 meeting takes plcae

Discussed this with @Tom-Willemsen in person and agreed that the output should be N-dimensional rather than the 1-dimensional array that is present in the PVA structure

Closing in favor of https://github.com/bluesky/ophyd-async/pull/19 now that ophyd-async has been moved to a different repo.


Ubuntu 17.04 segfault after password prompt

From #139 :

I still have this problem on kubuntu 17.04. so I guess it's not really fixed?
The client works and asks for the code after that it crashes with a segfault error.

Reproduced on Kubuntu and Ubuntu 17.04.
Not reproducible on Ubuntu 16.04
Syslog says:
May  3 09:40:23 yubico-VirtualBox kernel: [ 805.064021] yubioath-deskto[4360]: segfault at 18 ip 00007fca940be96f sp 00007ffd2ec67120 error 4
A key with no password set works fine.

Fixed with cc86c37adf9974cf395fd8cf2501c6a5572e510b.
Verfied on Kubuntu and Ubuntu 17.04.
Might be a bug in Qt?
https://bugreports.qt.io/browse/QTBUG-60730


Engine.backward() disables Config.cleanupWikifierOutput = true

Describe the bug.
Using Engine.backward() in a story with Config.cleanupWikifierOutput = true generates a passage with
 tags as if Config.cleanupWikifierOutput was not set.
To Reproduce:

Set Config.cleanupWikifierOutput = true in story JS
View a passage
Go to a second passage
Run Engine.backward() to go back to the first pasage

Expected behavior.
The first passage should have
 tags as normal, but just has plain
 instead
Project details.

SugarCube Version: 2.36.1
Compiler & Version: Twine 2.6.1

Desktop details.

OS & Version: OSX
Browser & Version Firefox

Related  #189

This is likely related to timing.  I.e., Going backwards before the last moment has finished rendering.

This is likely related to timing. I.e., Going backwards before the last moment has finished rendering.

It seemed to happen even if I waited a long while. Could it be that the engine renders the past moment differently and doesn't load the config setting?

Config settings, in general, should be set in either the story JavaScript or StoryInit, which is to say not only outside of the story history but before it even begins.  In that case, the setting should always be active during normal operation.
All moments are rendered equally, wrt. the setting anyway.
The cleanup setting is only used if no other Wikifier calls are active somewhere.  This is the likely culprit of "it no worky at all" the majority of the time.

Yes, I didn't mean that the Config setting was being reset, I was implying that the rendering process involved in Engine.backward() didn't honour it.
So, given that this happens even if there is a long delay before going backwards, it implies that the process nevertheless invokes another Wikifier? Could it be related to StoryInterface rendering passages?

I tested the reported behaviour using links like...
<<link 'Backward'>><<run Engine.backward()>><</link>>

...and...
<<link 'Forward'>><<run Engine.forward()>><</link>>

...and the issue also occurs when Engine.forward() is used to wind History forward again.
The Undo and Redo navigation links did not display the reported behaviour when used in the same testing project.


Translate tasks/configure-pod-container/assign-memory-resource.md in Korean

This is a Feature Request

What would you like to be added

Translate tasks/configure-pod-container/assign-memory-resource.md in Korean
Why is this needed
No translation tasks/configure-pod-container/assign-memory-resource.md in Korean
Comments

https://kubernetes.io/docs/tasks/configure-pod-container/assign-memory-resource/

/language ko
/assign


⚠ Nebulance has degraded performance

In b802c68, Nebulance ($NBL) experienced degraded performance:

HTTP code: 200
Response time: 7650 ms

Resolved: Nebulance performance has improved in bf039cf after 14 minutes.


Error when changing working directory

if the current directory is changed, log4rs pumps a error message to stderr:
log4rs: No such file or directory (os error 2)

This is my Cargo.toml config:
[dependencies]
log = "0.4"
log4rs = { version ="1.2", features = ["gzip"] }

This is the test program:
use log::*;
use log4rs;
use std::{thread, time::Duration};

fn main() -> Result<(), std::io::Error> {
    log4rs::init_file("log4rs.yaml", Default::default()).expect("Open log4rs config");
    info!("Starting up");
    // if this line is commented, the error goes away
    std::env::set_current_dir(&std::path::Path::new("/tmp"))?;
    for i in 1..11 {
        info!("{i}");
        thread::sleep(Duration::from_millis(1500));
    }
    info!("Finished");
    Ok(())
}

This is log4rs.yaml:
refresh_rate: 2 seconds
appenders:
  stdout:
    kind: console
    encoder:
      pattern: "[{d(%Y-%m-%d %H:%M:%S)} {l}] {m}{n}"
  requests:
    kind: file
    path: "my.log"
    encoder:
      pattern: "[{d(%Y-%m-%d %H:%M:%S)} {l}] {m}{n}"
root:
  level: info
  # level: debug
  appenders:
    - stdout
    - requests
loggers:
  app::requests:
    level: debug
    appenders:
      - requests
    additive: false

I apologize if this is the desired behavior and this is not an error.

No, the error happend only if this call is in effect (try comment it out)
std::env::set_current_dir(&std::path::Path::new("/tmp"));
El mié, 15 mar. 2023 14:00, Dirreck @.***> escribió:

maybe you forget to copy log4rs.yaml to your program's directory?
—
Reply to this email directly, view it on GitHub
https://github.com/estk/log4rs/issues/297#issuecomment-1470412395, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AALBP4GQHA5A4GGP47CPBLLW4HYUHANCNFSM6AAAAAATT4SUEI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Cold/Flu - Admin can CREATE a cold/flu submission on behalf of another user

User Story
As a Cold/Flu admin, i should be able to create a submission on behalf of another registrant, as some registrants may not have IDIR to access DJ
AC

[x] Admin should be able to create multiple cold/flu submissions

Notes

We do not need to clear the worksite contact field that are pre-populated with admin details fornow

Work has been updated on DEV and TEST.

Ready to test

Tested and verified working. As an Admin, I was able to create multiple cold/flu submissions.
Acceptance criteria met ✔

Tested with Stella and Heather - PO approved.


Need to implement a ping/pong method in the communication protocol

If using a virtual ip in front of pulse server, and it moves hosts, the tcp connection is still established, not allowing stats to be submitted until a full client reconnection is initiated. If there was a ping/pong method, the client could detect if the host was unreachable and re-initiate a connection.

This should be fixed with this commit (The implementation has changed from linked commit, but disconnect detection should still work, resolving this issue (#7)


Fix and improve release workflow

It would probably be a good idea to split the release process for the server and the extension to be able to create separate releases.
Or at least improve the dependency issues in e2e tests with unreleased server versions.
Note: replace old action create-release too.

Should be already improved by #244


When user's Cell URL is different from Unit Manager App Cell session storage is empty

Function in boxProfile.js is called but never included in any HTML files.


Wrap and support Sparse Vector Creation

FastEmbed should/can support sparse vector creation which is based on Bag of Words e.g. TF-IDF and BM25 Okapi. We can launch with existing Python implementations e.g https://pypi.org/project/rank-bm25/
This will help adoption for sparse vectors within the Qdrant ecosystem itself as we can recommend this as the canonical place to make some sparse vectors.

Alternatively to BM25, we can consider running SLADE-like models. Last time I tried them, the inference speed was my top concern

They continue to be slow, and I don't know of an obvious way to run them with onnxruntime yet. Will keep an eye out on SPLADE though

#149
New models to follow.


Blur text on floating label animation on md-input in a form

Bug, feature request, or proposal:
Bug
What is the expected behavior?
The floating label animation on md-input should NOT make the text blur while transforming
What is the current behavior?
The text will become blur while transforming (floating)
What are the steps to reproduce?
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, browsers are affected?
Angualr2 / "@angular/material": "^2.0.0-alpha.10" / Windows 8.1 / Only on desktop but not on mobile browsers
Is there anything else we should know?

@hansl may be fixed as obselete as part of md-input refactor

The text doesn't seem blurry. There is a little bit of jank in the transition, I think because the padding change isn't transitioned. #2246 should fix that.


TestngMetrics: Testng-metrics doesnt works while using other listeners

Testng-metrics doesnt works while using other listeners (user mention listeners) in testng.xml

I don't see this happening. Can you add more details?

@nainappa One of the user raised this point. I'm trying to reproduce this!


add latexmk rule...

...the main improvement wrt to standalone rule is the usage of latexmk, which automatically runs latex the right number of times, and, if needed, can call bibtex as well.
Co-authored-by: Oliver Reiche<EMAIL_ADDRESS>

Thanks @aehlig for your review. The patch is ready for the second review


Travis CI for OSX 5x slower than Ubuntu

Do we know why this is happening? It is a pain to have to wait 30 + minutes for CI. If we could figure out what is wrong and get it on par with ubuntu it would speed up development quite a bit.

The answer is probably just "it's slow", but I'll take a look. One option is having the build do much less on OSX. Do the nuttx builds ever break on one platform, but not the other? Maybe OSX only needs to be building posix.

Yes, POSIX only would be enough on OS X. That would allow us to skip the arm compiler install, which should speed it up dramatically. Please only comment out, not remove those bits though, thanks!

Same thing with QGC OSX builds, make me crazy!


NPM task doesnt update working directory after build task

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Environment

Server - Azure Pipelines

If using Azure Pipelines, provide the account name, team project name, build definition name/build number:
Account Name: decentralized-identity
Project Name: Core
Build Definition Name: sidetree-core
Build Number: 174
Build link: https://decentralized-identity.visualstudio.com/Core/_build/results?buildId=174

Agent - Hosted Ubuntu 1604

Issue Description
The project is a typescript code and the build command generates the output in the dist folder in the default working directory. In the next task, on running the jasmine tests, it doesn't recognize the dist folder which was outputted as part of the previous build task.
NPMTestFailedLog.zip

Do you mean that the dist folder is not present - or that the working folder is not set to the dist folder?

I'd recommend doing a tree listing from $(System.DefaultWorkingDirectory) to get a sense of the source tree layout after the build step. That will prove one way or the other that the dist files are where you think they are and then help you debug why some of the tests are failing.

I'd recommend doing a tree listing from $(System.DefaultWorkingDirectory) to get a sense of the source tree layout after the build step. That will prove one way or the other that the dist files are where you think they are and then help you debug why some of the tests are failing.

Sure, will do that and revert back


Update README.md

Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Run the unit tests with gradlew app:connectedGmsDebugAndroidTest to make sure you didn't break anything (with an emulator running or phone connected)

[ ] If you have multiple commits please combine them into one commit by squashing them.

Looks like this just adds a trailing cr.


feat: clock_nanosleep()

What does this PR do
Pick up #1315, add clock_nanosleep().
Closes #1315
Closes #1299
Checklist:

[x] I have read CONTRIBUTING.md
[x] I have written necessary tests and rustdoc comments
[x] A change log has been added if this PR modifies nix's API

That DragonFlyBSD CI error, seems to be nightly toolchain bug, I can reproduce it with 1.77.0-nightly (595bc6f00 2024-01-05), but with 1.77.0-nightly (f688dd684 2024-01-04), everything works just fine.


error running the test

Hi,
I am trying to use sarek in a local workstation. After installing singularity and docker, and pulling the Sarek-test I obtain the following error when I try to execute it:
jl@lynx:/soft/Sarek-test$ nextflow run build.nf --outDir References/smallGRCh37   --refDir Sarek-data/reference --tag latest   -profile singularity
N E X T F L O W  ~  version 19.10.0
Launching build.nf [sad_boyd] - revision: 4b1f23a848
WARN: Access to undefined parameter verbose -- Initialise it to a default value eg. params.verbose = some_value
WARN: Access to undefined parameter containers -- Initialise it to a default value eg. params.containers = some_value
____        _____               _
.' _  .     / ____|             | |     /  |\-_ \   | (___  ___  _ __ __ | | __
|   | \  -|   \___ \/__ \| ´__/ _\| |/ /  \ |   \  /    ____) | __ | | |  __|   <    |_'    |__/_||  _/||_
Sarek - Workflow For Somatic And Germline Variations ~ 2.3 - 4b1f23a848
Command Line: nextflow run build.nf --outDir References/smallGRCh37 --refDir Sarek-data/reference --tag latest -profile singularity
Project Dir : /soft/Sarek-test
Launch Dir  : /soft/Sarek-test
Work Dir    : /soft/Sarek-test/work
Out Dir     : References/smallGRCh37
Genome      : smallGRCh37
Containers
Repository   : docker://maxulysse
WARN: Access to undefined parameter containerPath -- Initialise it to a default value eg. params.containerPath = some_value
ContainerPath: null
Tag          : latest
[-        ] process > BuildWithDocker     -
[-        ] process > PullToSingularity   -
[-        ] process > PushToDocker        -
[-        ] process > DecompressFile      -
[-        ] process > BuildBWAindexes     -
[-        ] process > BuildReferenceIndex -
[-        ] process > BuildSAMToolsIndex  -
[-        ] process > BuildVCFIndex       -
[-        ] process > BuildCache_snpEff   -
[-        ] process > BuildWithDocker     -
[-        ] process > PullToSingularity   -
[-        ] process > PushToDocker        -
[-        ] process > DecompressFile      -
[-        ] process > BuildBWAindexes     -
[-        ] process > BuildReferenceIndex -
[-        ] process > BuildSAMToolsIndex  -
[-        ] process > BuildVCFIndex       -
[-        ] process > BuildCache_snpEff   -
[-        ] process > BuildCache_VEP      -
[-        ] process > DownloadCADD        -
Pulling Singularity image docker://maxulysse/sarek:latest [cache /home/jl/.singularity/maxulysse-sarek-latest.img]
N E X T F L O W  ~  version 19.10.0 5170
Sarek - Workflow For Somatic And Germline Variations ~ 2.3 - 4b1f23a848
Workflow execution stopped with the following message:
null
N E X T F L O W  ~  version 19.10.0 5170
Sarek - Workflow For Somatic And Germline Variations ~ 2.3 - 4b1f23a848
Command Line: nextflow run build.nf --outDir References/smallGRCh37 --refDir Sarek-data/reference --tag latest -profile singularity
Project Dir : /soft/Sarek-test
Launch Dir  : /soft/Sarek-test
Work Dir    : /soft/Sarek-test/work
Out Dir     : References/smallGRCh37
Genome      : smallGRCh37
Containers
Repository   : docker://maxulysse
ContainerPath: null
Tag          : latest
Completed at: 2020-01-02T16:33:48.201923+01:00
Duration    : 3s
Success     : false
Exit status : null
Error report: Error executing process > 'DecompressFile (Mills_and_1000G_gold_standard.indels.b37.small.vcf.gz)'
Caused by:
Failed to pull singularity image
command: singularity pull  --name maxulysse-sarek-latest.img docker://maxulysse/sarek:latest > /dev/null
status : 1
message:
WARNING: pull for Docker Hub is not guaranteed to produce the
WARNING: same image on repeated pull. Use Singularity Registry
WARNING: (shub://) to pull exactly equivalent images.
ERROR MANIFEST_UNKNOWN: manifest unknown
ERROR: pulling container failed!
WARN: Access to undefined parameter snpEff_cache -- Initialise it to a default value eg. params.snpEff_cache = some_value
WARN: Access to undefined parameter cadd_version -- Initialise it to a default value eg. params.cadd_version = some_value
WARN: Access to undefined parameter vep_cache -- Initialise it to a default value eg. params.vep_cache = some_value
WARN: To render the execution DAG in the required format it is required to install Graphviz -- See http://www.graphviz.org for more info.
Error executing process > 'DecompressFile (Mills_and_1000G_gold_standard.indels.b37.small.vcf.gz)'
Caused by:
Failed to pull singularity image
command: singularity pull  --name maxulysse-sarek-latest.img docker://maxulysse/sarek:latest > /dev/null
status : 1
message:
WARNING: pull for Docker Hub is not guaranteed to produce the
WARNING: same image on repeated pull. Use Singularity Registry
WARNING: (shub://) to pull exactly equivalent images.
ERROR MANIFEST_UNKNOWN: manifest unknown
ERROR: pulling container failed!
If I try to run the command that fails alone:
jl@lynx:/soft/Sarek-test$ singularity pull  --name maxulysse-sarek-latest.img docker://maxulysse/sarek:latest
WARNING: pull for Docker Hub is not guaranteed to produce the
WARNING: same image on repeated pull. Use Singularity Registry
WARNING: (shub://) to pull exactly equivalent images.
Docker image path: index.docker.io/maxulysse/sarek:latest
ERROR MANIFEST_UNKNOWN: manifest unknown
Cleaning up...
ERROR: pulling container failed!

Hi,
I'm sorry, I'm on vacation and have a less than reliable connection.
We recently ported sarek to nf-core: https://github.com/nf-core/sarek so I'll recommend you have a look at it. There are lots of improvement.
But if you still want to use this version I'll recommend using --tag 2.3 or 2.3FIX1 instead.
All the best,
Maxime

Hi,
Good, I will try that one :)
However I have a question, why singularity was prefered before nf-core and now docker is favoured?
Best,
JL

Hi JL!
the profiles in the nf-core version should load Singularity and pull the Docker Image, giving you the same behaviour. In other words, we only store the Docker Image but users can use both Docker directly or Singularity that can convert the docker image "on-the-fly" to a Singularity container without you noticing 👍


ModuleTrace: address code review comments. NFC

Addressing code review comments on the previous PR: https://github.com/swiftlang/swift/pull/77217

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Make lookup template and user input cv column ordering match

Is your feature request related to a problem? Please describe.
Make lookup template and user input cv column ordering match. This would allow users to directly copy lookup qualification lines into the upload csv
Describe the solution you'd like
Check the ordering of each to see which is most logical and adjust the other to match

lookup table column ordering has been adjusted in the 2024U run (and onwards) such that the order will match the user template.


September 2023 Recovery 1

[x] Create a milestone September 2023 Recovery 1 @bhavyaus
[ ] Bump the version number @bhavyaus
[ ] 🔖candidate issues
[ ] Assign candidate issues to the recovery milestone team
[ ] Review the candidate issues, and if they pass the review assign them to the recovery milestone team
[ ] All candidate fixes are peer reviewed and pushed to main and then cherry-picked into the release branch team
[ ] Initiate insiders build from main
[ ] Issues are tested in the insiders team
[ ] Build stable for all platforms from release branch @bhavyaus
[ ] Issues are verified on stable build and the verified label is added @bhavyaus
[ ] Check https://github.com/Microsoft/vscode/compare/release/<x.y> to ensure no other commits have been made in the release branch @bhavyaus
[ ] Update the release notes and include a link to a query for the fixed issues @gregvanl
[ ] Sanity Testing

[ ] Windows 32 bit owner

[ ] System Installer
[ ] User Installer
[ ] Archive
[ ] Server
[ ] CLI

[ ] Windows 64 bit owner

[ ] System Installer
[ ] User Installer
[ ] Archive
[ ] Server
[ ] CLI

[ ] Windows ARM64 owner

[ ] System Installer
[ ] User Installer
[ ] Archive
[ ] CLI

[ ] macOS Intel owner

[ ] Archive
[ ] Universal Archive
[ ] Server
[ ] CLI

[ ] macOS ARM64 owner

[ ] Archive
[ ] Universal Archive
[ ] Server
[ ] CLI

[ ] Linux x64 owner

[ ] Archive
[ ] DEB
[ ] RPM
[ ] Snap

[ ] Linux Server owner (can be tested from any OS with Docker)

[ ] x64
[ ] ARM32
[ ] ARM64
[ ] x64 Alpine
[ ] ARM64 Alpine

[ ] Linux CLI owner (can be tested from any OS with Docker)

[ ] x64
[ ] ARM32
[ ] ARM64
[ ] x64 Alpine
[ ] ARM64 Alpine

[ ] Publish website @gregvanl
[ ] Publish stable build @bhavyaus
[ ] Create an official release @bhavyaus

[ ] Create a tag (make sure you pull the release branch first): git tag <x.y.z> release/<x.y>
[ ] Push the tag: git push origin <x.y.z>
[ ] Create a GitHub release: Open the GitHub tags, and click far right ... > Create Release. Use the correct title and description from our release notes. Example

[ ] Close the milestone on GitHub @bhavyaus

The 'candidate issues' link uses the wrong milestone.


Config as variable

It would be great if environment variables could be used instead of config.yaml. This would add security and make it easier to work with the docker

5.10.168-android12-9-00001-g26e4292d27d7-ab10 628739

https://github.com/504dev/logr/issues/11#issuecomment-2267192031


Access control section is visible to non admin users

When logged in as an collection administrator i can to visualize and even access the Access control section. I even can see the groups and people lists and access to person and group details. But i can't edit groups that i don't belong to (this is ok)
Steps to reproduce the behavior:

Log in as an collection admin
Open the "Access control" section in the menu
Enter groups or people sections

A collection admin shouldn't be able to visualize the access control section

@artlowel : assigning this to you for your feedback.  I suspect this is a "side effect" of the fact that Community/Collection Admins can view People & Groups (as they need to be able to view them in order to manage Community/Collection based groups).  However, I wonder if there's a way to either hide the "Access Control" section, or perhaps somehow make it clearer that they only have read-only access to much of the information in that section?

I don't think we can hide the groups page entirely for community or collection admins. They need to manage the groups related to the communities and collections they manage. See #927
The best solution for groups in my opinion would be to add a search endpoint for groups similar to findSubmitAuthorized for collection, to allow us to only return the groups a user has edit or delete access to.
A less ideal, but perhaps easier way to fix this would be to still list everything, but to add a canManageGroup feature (or perhaps extend canEditMetadata to also work for groups) that we could use to determine for each individual group in the list whether you can edit it. We already use the canDelete feature to do that for the delete button in that list.
Either solution would take about 4 hours on the angular side, but either solution needs some rest work first
For epersons I can't think of a reason why collection or community admins would ever need access to that page, so I propsose we put that route behind an isAdmin check. This can be done within the 4 hours of the estimate.

@artlowel : thanks for the notes. I agree that your "best solution" is ideal in this scenario, but the other solution would also work and be good enough (if the best solution is too complex to implement at this time).
@benbosman : Assigning this over to you for REST API analysis (as you worked on this previously).  Do you agree with the solution proposed by @artlowel , and could you share an estimate for fixing it on the REST side?

The best solution suggested by Art was a search endpoint for groups: e.g. findManageGroupsAuthorized, which will only return the groups a user has edit or delete access to.
This would require a scalable solution to identify which groups a user can manage, and thus implies the groups will need to be indexed in discovery. I would expect 1-2 days of work to deal with this
The less ideal solution suggested by Art was to use a canManageGroup feature that we could use to determine for each individual group in the list whether you can edit it. This already exists in REST: https://github.com/DSpace/DSpace/blob/main/dspace-server-webapp/src/main/java/org/dspace/app/rest/authorization/impl/ManageGroupsFeature.java

Just discussed this with Art, we already have canManageGroups, but not canManageGroup (given a specific group), I will update the ticket based on that

We can create a canManageGroup feature, with the group as resource type. It will check whether the user is admin for that specific group
Including ITs, this should be realistic in 2 hours

Thanks @benbosman & @artlowel  .  In that case, let's go with the easier approach for 7.0.

REST API: Implement canManageGroup (estimate 2 hours)
Angular UI: Use canManageGroup to only display an edit button next to groups you can edit.  Update EPerson management to be behind an isAdmin check. (estimate 4 hours)

This will mean that Community/Collection Admins see all Groups still. I'm OK with that though, as they already can see all Groups when they edit/create a Community/Collection Group (as they have the ability to select subgroups).

I'll assign this to both of you as there's two parts to this ticket.  I'll also add the overall estimate of 6hours


Active Directory - Integrated Not Supported

This connection option does not appear to be supported in vscode. Could you provide an example or please add this feature? Thanks.

@databoxinsights -- Thanks for your feedback; we appreciate it. To make sure we have all the information needed to triage your issue, please let us know which topic you’re referencing, or provide more context around the general task.

I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


Add Quarto as a framework sample

Quarto has become the go-to framework for creating static sites in R. Could you add Quarto as one of your framework samples? Here is a repo to related GitHub actions.
Adding @agaengel @Robert95Sch

Mart at customer support told me:
Upon further checking, there is no option to manually set up the new project for Quarto Framework. However, you may try contacting our dedicated Deploy now team via email at<EMAIL_ADDRESS>I'll send an email. This seems strange, though---see here for major platforms supporting Quarto (such as Netlify).
It would be great if you could add the framework sample! Thanks for your help

Hey @de-barros,
thank you for your feedback. We packed adding Quarto to our supported framework in our backlog.
Unfortunately, I cannot guarantee implementation at the moment.
Best
Chris


Can we add csv to a map?

Geoportal works fine and collects metadata for csv file and create a link.
Unfortunately "Add to Map" fails to load a csv file and says "Unable to load: http://.....csv"
I opened arcgis.com "http://www.arcgis.com/home/webmap/viewer.html?useExisting=1" and drag and drop the same csv file. I also used "add layer from web" and pasted the same url on geoportal. It worked.
Assuming WebApp Builder has the same function, I hope to see the csv data on a map. CSV file contains around 4000 rows.

currently "add to map" only add map services to the map viewer, it does not add csv files to map,  you might check if web app builder have some existing widget let user add csv files to the map.


xfailing ls test

On master, I wrote a test for ls that's currently failing
The setup in conftest.py is
    bbs = BlockBlobService(
        account_name=USERNAME,
        account_key=KEY,
        custom_domain=f"http://{host}/devstoreaccount1",
    )
    bbs.create_container("data", timeout=1)

    bbs.create_blob_from_bytes("data", "/root/a/file.txt", data)
    bbs.create_blob_from_bytes("data", "/root/b/file.txt", data)

which IIUC is
- root/
  - a/
    - file.txt
  - b/
    - file.txt

The test is
    fs = adlfs.AzureBlobFileSystem(storage.account_name, "data", storage.account_key)
    assert fs.ls("/") == ["root"]
    assert fs.ls("/root/a/") == ["file.txt"]

Regardless of what we pass to ls, the contents seem the same
(Pdb) pp fs.ls("/")
['/root/a/file.txt', '/root/b/file.txt']
(Pdb) pp fs.ls("/root/")
['/root/a/file.txt', '/root/b/file.txt']

cc @hayesgb

A similar reported error led to new tests to investigate this issue and implemented fixes in the code.  Additional work from @AlbertDeFusco on implementing Azurite greatly simplified fixing this issue.


Peering Request

Full Name
DSM Group
ASN
48070
PeeringDB Integration

[X] My PeeringDB Entries are current
[ ] Peer at ALL EXCHANGES (and skip the Peer Address(es) field below)

Peer Address(es)
LINX LON1
<IP_ADDRESS>
2001:7f8:4::bbc6:1
Multihop

[ ] Multihop Peering Request

Code of Conduct (TODO)

[X] I agree to follow this project's code of conduct

The peering is up on our side:
    Neighbor        V         AS   MsgRcvd   MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd   PfxSnt Desc
    <IP_ADDRESS>  4      48070         0         0        0    0    0    never      Connect        0 DSM (GB) Limited
    Neighbor                V         AS   MsgRcvd   MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd   PfxSnt Desc
    2001:7f8:4::bbc6:1      4      48070         0         0        0    0    0    never      Connect        0 DSM (GB) Limited

Our details:
as: 6447
ip4: <IP_ADDRESS>
ip6: 2001:468:d01:33::80df:336c
fqdn: route-views3.routeviews.org

Shouldn't this be your LINX LON1 details?
<IP_ADDRESS>
2001:7f8:4::192f:1
RP/0/RSP0/CPU0:teleh-nrth-9k-core01#show bgp ipv4 unicast neighbors <IP_ADDRESS>
Thu Jun  8 07:57:58.872 GMT
BGP neighbor is <IP_ADDRESS>
Remote AS 6447, local AS 48070, external link
Description: PEERING: RouteViews (AS6447)
Remote router ID <IP_ADDRESS>
BGP state = Idle

Take 2! 📣
    Neighbor        V         AS   MsgRcvd   MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd   PfxSnt Desc
    <IP_ADDRESS>  4      48070    130892        39        0 8710    0 00:06:16       855119        0 DSM (GB) Limited
    Neighbor                V         AS   MsgRcvd   MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd   PfxSnt Desc
    2001:7f8:4::bbc6:1      4      48070     46174        39        0    0    0 00:06:16       172363        0 DSM (GB) Limited

as: 6447
ip4: <IP_ADDRESS>
ip6: 2001:7f8:4::192f:1
fqdn: route-views.linx.routeviews.org

Thanks for giving us a chance to fix this and reach out if you need anything else.


Add first name and last name in UserInformation

It will be useful to include also user's first name and last name requested in scopes (as ".fullName") in UserInformation. I can contribute this addition.

Invalid request. User's first name and last name cannot be retrieved from authorization code


Cancel timeout timer as soon as operation finished.

This solves the problem of dangling operation being retained within dispatch_after block and waiting for timer to fire up. Only then operation would be released.

Is there a test that can show that the current implementation of OPTimeoutObserver isn't doing what is expected, and displays that this resolves it?

@colinmcardell
It's not that it does not do what expected, it actually does, but it retains the entire operation until dispatch_after fired. Which means that if operation completed in 1 second but the timeout is set for 30, then the entire op won't be released until then.
As you know, dispatch_after does not have cancellation policy so therefore once set, will always run and retain all objects within its block.
I will think of some test to demonstrate that.


How to deal with race conditions caused by concurrency

2015-10-27T15:33:42.642Z 3123 TID-oxfjnp9pw WARN: ActsAsTaggableOn::DuplicateTagError: 'orange' has already been taken
As part of my project I'm working on I use Sidekiq to run a tagger on 25,000 AR-backed models in postgres. With the default concurrency of 25 workers I instantly run into the above problem every single time.
I assume the responsible code is L74 of https://github.com/mbleigh/acts-as-taggable-on/blob/fd28222629ad59f5a3958424e66e5b9f81a5be18/lib/acts_as_taggable_on/tag.rb
which is existing_tag || create(name: tag_name)
By the time existing_tag returns false another worker has created the tag and then create fails.
There are a number of solutions to the race condition and I'm happy to implement. But does anyone have an opinion here? Would a patch be accepted?
Something perhaps like insert/select/where not exists?

Also, if the DuplicateTagError gets raised perhaps retry the fetch and return the good tag?

We seem to have a similar problem

Also, if the DuplicateTagError gets raised perhaps retry the fetch and return the good tag?

I think the problem there might be that since you're inside a transaction at that point (eg due to ActiveRecord::Base#save), you won't be able to see the results of the other transaction that created the tag, right?

This bit me today.  Would it be possible to lock the table prior to reading existing tags and creating?

Here is a 'hacked' version that allows for retry.  Admittedly not a perfect solution, but it works for the time being.  https://github.com/adam-e-trepanier/acts-as-taggable-on/tree/double-check-tag-doesnt-exist

@adam-e-trepanier hmm, I'm still having problems with that approach - eg with Post.find(1).update_attributes(tag_list: 'x'), retry_find_or_create_all_with_link_by_name is going to occur within the transaction that ActiveRecord wraps any save calls with, so you'll still get a DuplicateTagError on the retry.

@jdelStrother Yes, you are correct.  please disregard.  I am working on something to try nested transactions.  Ill let you know if that works.


CameraX chooses low resolution for given aspect ratio

I want to get the best quality for square aspect ratio and setup the next preview and capture configs for CameraX.
val SQUARE_ASPECT_RATIO = Rational(1, 1)

val previewConfig = PreviewConfig.Builder().apply {
    setTargetAspectRatio(SQUARE_ASPECT_RATIO)
    setTargetRotation(viewFinder.display.rotation)
}.build()
preview = Preview(previewConfig)

val imageCaptureConfig = ImageCaptureConfig.Builder().apply {
    setCaptureMode(ImageCapture.CaptureMode.MAX_QUALITY)
    setTargetAspectRatio(SQUARE_ASPECT_RATIO)
    setTargetRotation(viewFinder.display.rotation)
}.build()
imageCapture = ImageCapture(imageCaptureConfig)

CameraX.bindToLifecycle(this, preview, imageCapture)

CameraX chooses 352x288px resolution, so result image resolution equals 288x288px. From documentation it should be the highest resolution available for current device, but it is not.
Tested on emulator and Google Pixel 3.

What resolutions are available in the devices you are testing this in? Asking for a squared aspect ratio will severely limit the resolutions that CameraX will attempt to choose from.

Got the same problem, if I specify the aspect ratio CameraX will choose an incredible low resolution. Tried with more ratio on really good camera (Galaxy s10+)

Please try again with the updated version of the sample since we just upgraded to alpha05. This problem should have been resolved now, feel free to reopen if that's not the case.


SW-2735 show time zone selector in org create form

required input
use time zone when creating org
known error: user is informed that time zone was set in info message after org switch (to be addressed separately)

@karthikbtf the know issue is just the message or is it also overriding the time zone of the new organization?

@karthikbtf the know issue is just the message or is it also overriding the time zone of the new organization?

just the message.. Chudo is fine with that.. see https://terraformation.atlassian.net/browse/SW-2708

@karthikbtf the know issue is just the message or is it also overriding the time zone of the new organization?

just the message.. Chudo is fine with that.. see https://terraformation.atlassian.net/browse/SW-2708

Sounds good, thank you!


[REQUEST] - Consider if it is truly necessary to put user_id in the session - it would be more secure to only put the token

The session can be modified client-side and what is generated here makes it too easy to trust that the user_id in the session is trustworthy.

I am starting to think that :fetch_current_user should be removed from the browser pipeline.
Firstly, all it does is assign the user_id to the session, which is probably not ideal.
Secondly, it clears the session when there is no token. This removes anything in the session from other plugs, e.g. locale, user_return_to, etc.
I think the best thing would be to modify RequireUser functions to use the token in the session.
Feel free to ignore this issue and my musings on it. I will open a PR that encapsulates.

Note to self: don't forget to test with Strict cookies. These would be broken for common flows, e.g. "confirm email".
Simple solution - like the remember_me token in phx.gen.auth, have a 2nd cookie, Lax, with just the token as value. Encrypt it.

This week, I learned that Safari misbehaves when accessing localhost with secure: true.
https://codedamn.com/news/web-development/safari-cookie-is-not-being-set
The workaround I found was to set secure: Application.fetch_env(:my_app, :env), where :env is set to the Mix compile environment.


Query: correlated collections optimization doesn't work if the outer query itself is correlated using outer parameter

see: GearsOfWarQueryTestBase -> Correlated_collections_nested_mixed_streaming_with_buffer1
the problem is interaction between CorrelateSubquery and InjectParameters, we should look for ways to make them work with each other.

note: if/when this is addressed, consider optimization for https://github.com/aspnet/EntityFrameworkCore/issues/10813 that @smitpatel mentions in the comment

Note: optimization may not work with weak types.


Possible typo OP-Revocation response-non-existing-token.json

The "in" clause inside the message operations is set to "123.123.123" https://github.com/stfbk/mig/blob/master/testplans/spid-cie-oidc/implementations/spid-cie-oidc-django/input/mig-t/tests/single/OP/OP-Revocation%20response-non-existing-token.json. What does it mean?

Understood


CPOL-102 Also provide policy create time.

Fix a bug in mtime handling as well.

Signed-off-by: Heiko W. Rupp<EMAIL_ADDRESS>

Looks good, but has conflicts now.

@josejulio The existingTrigger is the one requested from the engine, which has the id fields set etc. We need to send this one back to the engine (in modified form).


SSO: Class Schedule: Refinements and review

This task is to refine and review the Class Schedule user experience.
This is a screenshot in-app of the Class Schedule card a student will see after logging in:

TestFlight Alpha and Google Play Alpha builds will be activated when a stable build is available.

This has been completed in v6.0-rc.
Classes Card:

Classes Full View:

Refinements completed, reviewed, and verified in v6.0-rc, closing.


GitHub Pages Demo not working because of Underscore.js not found.

The Demo Pages no longer work because of underscore.js throwing a 404 error. I am fixing it and issuing a pull-request.

Thanks. :)


Go back from BangBang convention to enforcing mutation?

Just to keep track of the discussion with @devmotion: https://github.com/SciML/OptimizationBase.jl/pull/31#discussion_r1559316902

Main problems spotted:

even stuff like ForwardDiff.jacobian! is not guaranteed to mutate with a DiffResult object, see https://github.com/JuliaDiff/DiffResults.jl/issues/27

I assume DiffResults predates the bang bang convention. But similar to the discussion in the other thread IMO this behaviour (note that these examples are for immutable arrays!) is not relevant for the point I'm trying to make: When you require/assume mutable containers, then you should directly use the more direct and more efficient inplace function. Bang bang is useful for generic code that accepts both mutable and immutable  arrays.

The code in DI is trying to be as generic as possible, but I realized yesterday that every downstream user, myself included, would have to make heavy use of copyto!(x, operator!!(x)) which is suboptimal, so I am indeed working to change that


SLIM-895 Create functional exceptions for failing device operations

SLIM-895

SonarQube analysis reported 3 issues

 3 major

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 WebServiceResponseMessageSender.java#L51: Reduce this anonymous class number of lines from 32 to at most 20, or make it a named class.

All is well.

This pull request makes the build fail.

retest this please

SonarQube analysis reported 3 issues

 3 major

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 WebServiceResponseMessageSender.java#L51: Reduce this anonymous class number of lines from 32 to at most 20, or make it a named class.

All is well.

SonarQube analysis reported 3 issues

 3 major

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 WebServiceResponseMessageSender.java#L51: Reduce this anonymous class number of lines from 32 to at most 20, or make it a named class.

All is well.

SonarQube analysis reported 3 issues

 3 major

Watch the comments in this conversation to review them.
1 extra issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 WebServiceResponseMessageSender.java#L51: Reduce this anonymous class number of lines from 32 to at most 20, or make it a named class.

All is well.