[SMALLFIX]Support for setting the JAVA_HOME environment variable in alluxio-config.sh file

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20657/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.server.ft.ZookeeperFailureIntegrationTest.zkFailure
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20664/Failed Tests: 2org.alluxio:alluxio-tests: 2alluxio.client.fs.ConcurrentFileSystemMasterCreateTest.concurrentListFilesalluxio.server.ft.ZookeeperFailureIntegrationTest.zkFailure
Test FAILed.

@witgo  you may ignore the failing tests which are flaky.
Can you elaborate on your patch here? Do you plan to support setting JAVA_HOME in alluxio-env.sh?

thanks for the improvement.
LGTM


Trivy Action times out since today

Until ths morning everything worked well. In all our GitHub Actions Workflows the Trivy Image Scanning worked normal and took around 30 seconds.
Since some hours now, the scanning times out. Even increasing the timeout to 15 minutes and disabling the secret scanning does not help. Maybe something is wrong with the trivy database?
Please see our output:
Run aquasecurity/trivy-action@master
Running trivy with options: trivy image  --format sarif --vuln-type  os,library --severity  UNKNOWN,LOW,MEDIUM,HIGH,CRITICAL --output  trivy-results.sarif --ignore-policy  ./trivy_ignore.rego  xxxxxxxxxxxxx.dkr.ecr.eu-central-1.amazonaws.com/cccs/centraladdresssearchservice:qa
Global options:
2023-01-12T11:03:15.708Z	INFO	Need to update DB
2023-01-12T11:03:15.708Z	INFO	DB Repository: ghcr.io/aquasecurity/trivy-db
2023-01-12T11:03:15.708Z	INFO	Downloading DB...
27.06 MiB / 36.04 MiB [--------------------------------------------->_______________] 75.09% ? p/s ?36.04 MiB / 36.04 MiB [----------------------------------------------------------->] 100.00% ? p/s ?36.04 MiB / 36.04 MiB [----------------------------------------------------------->] 100.00% ? p/s ?36.04 MiB / 36.04 MiB [---------------------------------------------->] 100.00% 14.94 MiB p/s ETA 0s36.04 MiB / 36.04 MiB [---------------------------------------------->] 100.00% 14.94 MiB p/s ETA 0s36.04 MiB / 36.04 MiB [---------------------------------------------->] 100.00% 14.94 MiB p/s ETA 0s36.04 MiB / 36.04 MiB [---------------------------------------------->] 100.00% 13.98 MiB p/s ETA 0s36.04 MiB / 36.04 MiB [---------------------------------------------->] 100.00% 13.98 MiB p/s ETA 0s36.04 MiB / 36.04 MiB [---------------------------------------------->] 100.00% 13.98 MiB p/s ETA 0s36.04 MiB / 36.04 MiB [-------------------------------------------------] 100.00% 22.16 MiB p/s 1.8s2023-01-12T11:03:18.536Z	INFO	Vulnerability scanning is enabled
2023-01-12T11:03:18.536Z	INFO	Secret scanning is enabled
2023-01-12T11:03:18.536Z	INFO	If your scanning is slow, please try '--security-checks vuln' to disable secret scanning
2023-01-12T11:03:18.536Z	INFO	Please see also https://aquasecurity.github.io/trivy/v0.34/docs/secret/scanning/#recommendation for faster secret detection
2023-01-12T11:08:15.773Z	WARN	Increase --timeout value
2023-01-12T11:08:15.773Z	FATAL	image scan error: scan error: scan failed: failed analysis: analyze error: timeout: context deadline exceeded

I believe this is not our issue. GitHub Container Registry distributing Trivy DB was slow and it caused timeout in my environment. Others saw timeout with search.maven.org. If you are scanning images with JAR/WAR files, it is worth trying --offline-scan. You can set it via trivy.yaml.
https://aquasecurity.github.io/trivy/v0.36/docs/references/customization/config-file/

This worked for me, which should be the same as @knqyf263 comment.
- name: Run Trivy
  uses: aquasecurity/trivy-action@master
  env:
    TRIVY_OFFLINE_SCAN: true
...

That is working for me as well

gonna add a me-too post to keep track ... seems to really affect java projects only. Node / Go projects seem to be running fast as ever 🤷🏻

we've just released a new version of trivy action (https://github.com/aquasecurity/trivy-action/releases/tag/0.9.0) please give it a shot and see if the problem still persists.

It still fails here for OSS DataHub project https://github.com/datahub-project/datahub/actions/runs/4070080489/jobs/7020725786. Started happening 2 days ago.

We currently use aquasecurity/trivy-action@master in our tags. Is using<EMAIL_ADDRESS>instead recommended?

This had happened a few weeks ago and we added https://github.com/datahub-project/datahub/pull/7050/files this environment variables based on the github discussions in the issues. But seems that stopped working on 31st-Jan-2023.

aquasecurity/trivy-action@master is using v0.9.0 since today and it is using Trivy v0.37.1 - and it has stopped working with this environment variable for us as well. We changed our pipeline to<EMAIL_ADDRESS>and it is working again.

Thanks for the feedback. We’ll another look at it.

I am facing same issue with the @master tag. and getting below error
FATAL	image scan error: scan error: unable to initialize a scanner:
unable to initialize a docker scanner: failed to parse the image name: could not parse reference:
${REGISTRY}/${REPOSITORY}:${IMAGE_TAG}

@b44rawat Your error is something different. The variable is not evaluated well.


Logging operation

We should audit/log all operations that a Management Portal user does. In this way there is a clear understanding of who did what and when.

#133 implements auditing through a JPA Event Listener. I think we can use the same approach, i.e. use the spring application event framework with event listeners, to log important events in production mode in a unified way. For logging debug messages using a Logger in each class seem totally fine.


Smithfield - Instead of the city "Timisoara" the message "Romania is not a city in Romania" is written

ENVIRONMENT: production
URL: https://scrapers.peviitor.ro
Browser: Microsoft Edge
Device: Laptop
OS: Windows 10
STEPS TO REPRODUCE:

Open the URL in the browser
Search for "Smithfield" Company
Check the job locations
Open https://www.smithfield.ro/ro/cariere
Check the job locations

EXPECTED RESULTS:
Job locations are the same in Scrapers-UI as on the company website - Timisoara
ACTUAL RESULTS:
The message "Romania is not a city in Romania" is displayed instead of the job locations

Issue opened 2 times by 2 different people


Enhancement: Capture and report back the log statements from journey script.

Hi Team,
In recent past we were trying to check if there's a way to capture and report back the log statements from journey script to observability uptime monitor and there's was discussion about the same here.
Basis the discussion it was concluded to open up an enhancement request for the same.
Thanks,
Zaid

@ZaidMomin1 Thanks for opening the Enhancement request. Just for myself to clarify, Do you want

Log statements from the Journey script to be associated with the Monitor OR
Log statements from the Browser window which is the URL under test. If this was the case, we do collect those log statements, but will be reported only for failed journeys to save space.

For no 1, we would need to implement something like this #188

Hi @vigneshshanmugam
Apologies for the extremely delayed response.
Consider I have a below step which calls the wrapper methods like navigateTo, waitForElementToBeVisible etc and displays the message App successfully launched once everything is done (this is a simple example)
step('Launch app', async () => {
        let joinNowButton = '#joinNow'
        await navigateTo(page, url)
        if (!(await isElementVisible(page, joinNowButton)))
            await reloadPage(page)
        await waitForElementToBeVisible(page, joinNowButton)
        let joinNowButtonText = await getElementInnerText(page, joinNowButton)
        expect(joinNowButtonText).toBe("JOIN NOW")
       console.log(`App successfully launched`)
    });
`

Once this step is executed on the monitor, the way script executed is captured it would be great if the console logs are displayed on the monitor as well.

I'm assuming issue-188 that you mentioned would solve this problem.

@vigneshshanmugam would https://github.com/elastic/synthetics/pull/817 help with this (looks like we're including console.log in those too, assuming there aren't too many messages in total)?

would https://github.com/elastic/synthetics/pull/817 help with this (looks like we're including console.log in those too, assuming there aren't too many messages in total)?

#817 only captures the browser log messages, we don't associate all the console logs from the Journey scripts itself.

Once this step is executed on the monitor, the way script executed is captured it would be great if the console logs are displayed on the monitor as well.
We don't have this capability right now, but we capture raw logs from the STDOUT and STERR, but don't use show them on the UI under the monitor. Yeah #188 is the way to go to get this associated with the step level information, We will update this issue once we start working on this. Thanks!

@ZaidMomin1 @vigneshshanmugam wouldn't using page.evaluate solve this use?
i mean using it
    await page.evaluate(() => {
      console.log('test lgog');
    });


Add changelog

Towards https://github.com/giantswarm/giantswarm/issues/6211

Going with this because I want to cut the first release.


Add encryption configuration details to ODF dashboard

https://issues.redhat.com/browse/RHSTOR-5286

MCG deployment without KMS

MCG with KMS

As seen in this screenshot wile testing your PR I see that both encryptions are enabled in the popover but the title is not enabled. This is something that needs to be fixed.

This PR does not incorporate external mode details card, external mode supports in-transit as well.

All comment seem to be addressed, so @SanjalKatiyar to finally tag it.


Link is incorrect

In the section "Generating the publish scripts", the link labelled "generate publish scripts for web apps in Azure App Service." goes to a page that doesn't describe how to generate publish scripts. I was expecting instructions on how to create a powershell script?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b189030a-64a4-8c4b-2300-5b22a24c1c10
Version Independent ID: 5e6b615f-12dc-b591-310f-552b283d08dc
Content: Using Windows PowerShell Scripts to Publish to Dev and Test Environments
Content Source: articles/vs-azure-tools-publishing-using-powershell-scripts.md
Service: unspecified
Product: visual-studio-dev15
GitHub Login: @ghogen
Microsoft Alias: ghogen

@mcrsw Thank you for your feedback! We have assigned this issue to the author to investigate further and take the right course of action.

#please-close

@mcrsw We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Issue #1 DrilldownPageID and LookupPageID must be set in table when table is used in list page

see title

Update of the readme is missing ;)


[Feat]: add block explorer concepts

Description
add block explorer sections
Solution
No response
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

should i add it in documentation?


Population bar chart bars overlap the population axis when there are few zones

Addressed by @mapmeld 's PR.


Crashes if initialized too early

I attach a listener when my root component mounts, which appears to be too early in the lifecycle; before the catalyst is ready (specifically here)
E/AndroidRuntime(32754): java.lang.RuntimeException: Trying to invoke JS before CatalystInstance has been set!
E/AndroidRuntime(32754): 	at com.facebook.react.bridge.ReactContext.getJSModule(ReactContext.java:94)
E/AndroidRuntime(32754): 	at com.walmartreact.ReactOrientationListener.ReactOrientationListenerModule$1.onOrientationChanged(ReactOrientationListenerModule.java:45)
E/AndroidRuntime(32754): 	at android.view.OrientationEventListener$SensorEventListenerImpl.onSensorChanged(OrientationEventListener.java:143)
E/AndroidRuntime(32754): 	at android.hardware.SystemSensorManager$SensorEventQueue.dispatchSensorEvent(SystemSensorManager.java:405)
E/AndroidRuntime(32754): 	at android.os.MessageQueue.nativePollOnce(Native Method)
E/AndroidRuntime(32754): 	at android.os.MessageQueue.next(MessageQueue.java:143)
E/AndroidRuntime(32754): 	at android.os.Looper.loop(Looper.java:122)
E/AndroidRuntime(32754): 	at android.app.ActivityThread.main(ActivityThread.java:5254)
E/AndroidRuntime(32754): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(32754): 	at java.lang.reflect.Method.invoke(Method.java:372)
E/AndroidRuntime(32754): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
E/AndroidRuntime(32754): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
W/ActivityManager(  541):   Force finishing activity 1 com.robinpowered.rooms/com.robinrooms.MainActivity

If there's a way to queue items for the catalyst, that would be safer

@ajwhite I ran into the exact same problem, so I'll comment and listen here. In order to move forward, I hacked this up. It sleeps and then sends the event (which gets the JSModule which by then has activated). Note that I'm not a fan of this, but if people need to move forward, this does work:
try {
  Thread.sleep(100);
    nfc.sendEvent("NFCFOUND", null); // The thing that eventually tries to send a message to React
} catch(InterruptedException ex) {
  Thread.currentThread().interrupt();
}

Whats the long term fix on this

Avoid accessing the Catalyst before it's available. You can check if the reactApplicationContext hasActiveCatalystInstance as well as hook into the lifecycle events with addLifecycleEventListener which may let you observe when the catalyst becomes available, and then take attach the listener.


Dashboard - Format files & enable linting

Summary
Format all files from the dashboard & push them together. Also, enable linting for future commits.
Motivation
Files are being formatted and included in individual PRs even for a single liner change. So, formatting all files altogether and pushing them should reduce the review time.
Proposal

Format files (some manually & remaining automatically using eslint CLI)
Enable linting before committing for everyone
Raise the PR

AB#353

Hi @OtherHorizon,
We haven't yet prioritized this ticket but yes we would like to fix this soon.
Let us know if you'd like to work on it. We'll help you start with some suggestions.

Sure, I would like to work on this issue.

Hey @OtherHorizon,
Here are some suggestions/pointers to get you started,
Formatting with Prettier

Codebase sync - Take the latest pull or clone for the fresh start
Run yarn or yarn install for the first time. Ignore if done already.
No additional installation steps required as prettier is already part of devDependencies & .prettierrc.js is also present that contains the preferences we use to format files.
Run the following commands to automatically check or format the files,

Checks if files are formatted - yarn prettier --check src
Format all supported files - yarn prettier --write src

Note: Running formatting command at root directory (/ src) might take some time to complete and there might be some wrong formatting for mixed conditions containing both && and ||, most likely to happen in tsx files. So you can,

Create a feature branch. E.g. formatting-changes
Start formatting files at child folder level something like,
yarn prettier --write src/components/app
Then verify the changes locally for conditions like mentioned above
Commit the changes with meaningful commit message something like Formatted app details files and push the changes to feature branch

Setting up ESLint, Prettier & Husky
We already have .eslintrc.js, .prettierrc.js & .huskyrc.js in place, we just have to fix a couple of things & make these work inorder to enable linting on commit & also lint-fix command to auto fix the linting errors. You can refer official docs of prettier/eslint for more info.
Let know for any queries. Thanks 🙂

Hi @OtherHorizon,
Did you get a chance to start on this? Anything I can help you with? 🙂

Hi @OtherHorizon, Did you get a chance to start on this? Anything I can help you with? 🙂

hi, sry for getting back so late. yarn --check  after yarn install at child level doesn't work because Package.json doesn't exist. how should i proceed?

Hi @OtherHorizon,
So were you trying to build - https://github.com/devtron-labs/devtron repo?  Actually, this has to be done in https://github.com/devtron-labs/dashboard repo.
Let know if there's anything I can help you with.

Hi @OtherHorizon,
So were you trying to build - https://github.com/devtron-labs/devtron repo? Actually, this has to be done in https://github.com/devtron-labs/dashboard repo.
Let know if there's anything I can help you with.

Thanks i'll start working on now


[Bug]: (slow network) Black screen shows on start whilst all balance data loads with no indication of loading

Describe the bug
On app start, we now wait for all balance data to be retrieved before displaying the main screen. This is great in most cases but with a slow/intermittent network (not airplane mode) this can take a long time and only a black screen is shown with no indication of loading whilst data is being retrieved. We should at least indicate loading.
Reproduce

With a Bitkit wallet already created (so it opens to main screen)
With a throttled network (can be done in android emulator using network type HSDPA or slower)
Open Bitkit from closed and wait
After the orange splashscreen a black screen with be displayed for as long as it takes to retrieve wallet data

Screenshots / Recording
https://github.com/synonymdev/bitkit/assets/74595920/13ce362d-2c00-453c-b7bb-7a0e6a87d156
Operating system
Android 13 TKQ1.220829.002
Bitkit version
2c5b07726fd35cb796a9566c47d0f6c36fda4ef4
Log output
No response

This doesn't appear to be an issue anymore. However, I suspect it may have been protection against https://github.com/synonymdev/bitkit/issues/1841


InvalidUpdateError raised in graph.astream() when given a list of HumanMessage

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangGraph/LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangGraph/LangChain rather than my code.
[X] I am sure this is better as an issue rather than a GitHub discussion, since this is a LangGraph bug and not a design question.

Example Code
For easy reproduction, I added the exact same code of the tutorial to a Google Collab, where I encounter the same error:
https://colab.research.google.com/drive/1fxIsAfZkLjWumc_HJfymTgiUYZkUjO3q?usp=sharing
But this is a minimal example:
from langchain_core.messages import HumanMessage
from langgraph.graph import StateGraph
from typing_extensions import TypedDict
from typing import Annotated, List
from langgraph.graph.message import add_messages
import asyncio

class State(TypedDict):
    messages: Annotated[List[HumanMessage], add_messages]

async def dummy_node(state: State):
    return state

builder = StateGraph(State)
builder.add_node("dummy", dummy_node)
builder.add_edge("dummy", "dummy")
graph = builder.compile()

async def main():
    async for event in graph.astream([HumanMessage(content="This is a test message")]):
        print(event)

if __name__ == "__main__":
    asyncio.run(main())

Error Message and Stack Trace (if applicable)
----> 1 async for event in graph.astream(
      2     [
      3         HumanMessage(
      4             content="Generate an essay on the topicality of The Little Prince and its message in modern life"
      5         )

8 frames
/usr/local/lib/python3.10/dist-packages/langgraph/graph/state.py in _get_state_key(input, config, key)
    541                 return value if value is not None else SKIP_WRITE
    542             else:
--> 543                 raise InvalidUpdateError(f"Expected dict, got {input}")
    544
    545         # state updaters

InvalidUpdateError: Expected dict, got [HumanMessage(content='Generate an essay on the topicality of The Little Prince and its message in modern life')]

Description
I'm trying to reproduce the Basic Reflection notebook. However, in all environments I tested (Python 3.10 - 3.12, notebook and package environment) I get a InvalidUpdateError: Expected dict, got [HumanMessage(content="...")].
What exactly does the astream() method expect? The type signature Union[dict[str, Any], Any] and the description "The input to the graph." is not very specific imO
System Info
langchain==0.2.14
langchain-core==0.2.35
langchain-openai==0.1.22
langchain-text-splitters==0.2.2
mac m3
Python 3.12.4

Thanks for reporting -- fixed in https://github.com/langchain-ai/langgraph/pull/1512
Since the state is actually a dictionary with a messages key, the input should be {"messages": [...]}

Thanks for reacting so quickly, I tried this as well.
This, however, leads to a ValueError:
ValueError: variable messages should be a list of base messages, got {'messages': [HumanMessage(content='Generate an essay on the topicality of The Little Prince and its message in modern life', id='18eaa929-6ce5-4a7d-9c82-eab714702329')]} of type <class 'dict'>
Do you know what I'm still doing wrong?

But this is exactly what I'm doing in the demo notebook on Google Collab:
https://colab.research.google.com/drive/1fjZRWLtVgwyBmZMqOM-2NbfH1R-45mSW?usp=sharing
I install and import the latest versions and use exactly the same code as in the tutorial. I understand that I can have mismatches in my local environments, but this is already very isolated, no?

You're awesome, thanks. Will check it out after some meetings^^

Now it works, thanks again for the support


How can I register an exit handler

I have an application which start a thread using the @hug.startup() API. Currently I'm trying to find a way to gracefully stop the thread at exit. something like @hug.cleanup()

Did you find out how to do this?


Feat:Audio Book Support

Describe the feature
Integrate audiobook support, allowing users to listen to books directly on the platform.
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[x] I want to work on this issue

@sanjay-kv please assign to me

Assigned!
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it. Happy open-source contributing!   @Vin205


Required basic features for code generator

[ ] RegExp match
[ ] RegExp test (?)
[ ] RegExp replace
[x] String split
[ ] String concat
[ ] String join (?)
[ ] Array SubArray (?)
[ ] Any to string (?)
[ ] JSON parse
[ ] YAML parse
[x] Enum support
[x] Map support (contains key, remove, add, get values, get keys)
[x] Import tracking (causes Go error)

I've been trying to figure out how to get anonymous functions into Onelang. I see why you left them out, it's tough! Especially when trying to generate them across all the different languages.
In my opinion, adding anonymous function support should be high on the priority list. I'm still trying to figure out the best way to add it to Onelang.

By the way, I think there'd be a lot more support if there was only a single language used to generate code, in my opinion, it should be Typescript. It was after all what it was designed for.

By the way, I think there'd be a lot more support if there was only a single language used to generate code, in my opinion, it should be Typescript. It was after all what it was designed for.

Currently only TypeScript used for code generation. The project also includes python and bash scripts, but those only for auxiliary functionalities. Which non-TS code part were you referring to?

Preferably just adding anonymous functions to TypeScript. Here's an example:
let anonFunction = function ()
{
    console.log ("Anonymous function");
}

function TestFunction ()
{
    console.log("Test function");
}

anonFunction ();
TestFunction ();

Both of these won't work. I get that a regular function such as TestFunction above won't translate properly into Java and C#. However, the anonFunction should. Problem is, I'm still going through your codebase trying to figure out how to best get anonymous functions such as anonFunction in.

btw, do you have any pointers for me on how to add that functionality?


Test for commonjs first so webpack will work

I'm seeing a problem consuming localforage in webpack right now that seems to be due to define.amd existing but webpack expecting commonjs-style exports.
This is a working solution, but there might be a better/less fragile solution to this, happy to do something else if you have suggestions or I can find out how this is dealt with by other packages.

I think a lot of these things are a bit fragile, but frankly this looks fine to me. Still passes all the tests so until anyone else proposes anything fancier this is :+1:
(Getting JS libs to play well with the countless module system confounds me as I don't have enough experience outside a few.)

Thanks, PS!

I'll actually publish a bugfix version for this, in case you're pulling this in via bower or npm.

Tag pushed: https://github.com/mozilla/localForage/releases/tag/1.2.2

Thanks, much appreciated!


tegraflash on TX2

@madisongh Any thoughts on the error below.
When I add
IMAGE_CLASSES += "image_types_tegra"
IMAGE_FSTYPES = "tegraflash"

to the end of my local.conf  and try to bitbake core-image-sato I get
NOTE: Resolving any missing task queue dependencies
ERROR: Nothing PROVIDES 'u-boot'
ERROR: u-boot-tegra PROVIDES u-boot but was skipped: incompatible with machine jetson-tx2 (not in COMPATIBLE_MACHINE)
ERROR: u-boot was skipped: PREFERRED_PROVIDER_virtual/bootloader set to u-boot-tegra, not u-boot
ERROR: u-boot-tegra PROVIDES u-boot but was skipped: incompatible with machine jetson-tx2 (not in COMPATIBLE_MACHINE)
ERROR: Required build target 'core-image-sato' has no buildable providers.
Missing or unbuildable dependency chain was: ['core-image-sato', 'u-boot']

without adding the IMAGE_FSTYPES it builds fine.

I haven't yet worked out all the necessary pieces to make a tegraflash-able image for the TX2, so you can only build an SDcard image at this point.
Besides U-Boot, it looks like the tegraflash tooling and configuration is a bit different for TX2 than for TX1, so the bbclass will need updating, too.  I've just been too busy with my day job lately to get to it.

got it. Thanks for the quick reply.

Hey there!
Awesome work you're doing.
I would also very much like to be able to get a tegraflash-able TX2 image. Your stuff is working awesome for the TX1, by the way. Thanks for your time and all you've done!

I am working on supporting flashing the TX2, but the differences between TX1 and TX2 are significant, so it will take some time.  I may hold off on doing this until R28 is released.

I have pushed tegraflash support for the TX2 to master for experimentation and testing.

@madisongh thanks for the updates! Got sato working. I'll keep plowing ahead trying a few different things.

@madisongh so the plus side is the flashing works great.
not sure I want to open a new issue for this. But, having some issues writing new images/dtb to the /boot directory. If I put a new file there I get this
ext4fs_devread read outside partition<PHONE_NUMBER>8

and then it bails on retrieving the kernel
I've had issues with ext4 and u-boot in the past. I was wondering if you've seen anything like this.
My immediate thought would be to make /boot a separate partition and make it ext2 or vfat.

@madisongh I changed ext3 to ext4 in image_types_tegra.bbclass and it seems to be working now.

OK, I'll make the switch.   This could the what's causing #36, too.

hmm, hadn't seen #36. well that's interesting, I see
/dev/mmcblk0p1  1.2G  893M  157M  86% /

I'll play with it and see if I can come up with anything.


Feature Request: DeepL supports additional parameter in the request.

Please select the affected platforms

Android Studio

Please select the translator to use

DeepL

Issue details
Please refer to - https://www.deepl.com/docs-api/translate-text/ it supports multiple other parameters with the request. Could you please provide a way to add these to the plugin?

DeepL API supports many other parameters, what specific parameter options would you like to add?

DeepL API supports many other parameters, what specific parameter options would you like to add?

formality, preserve_formatting, and ignore_tags

Hi @Airsaid do you have timeline for this feature?

Sorry, I've been busy with other work lately and can't give an exact schedule right now.


Fix: list items are not refreshed when the items’ source e.g. a change notifier Provider sends an updated list.

Fix: list items are not refreshed when the items’ source e.g. a change notifier Provider sends an updated list.
Correct spelling mistakes.

Can you open an issue first and describe with an example?

Here is the issue: https://github.com/akbarpulatov/flutter_awesome_select/issues/15

Issue is not fixed in the latest version, you should merge this PR to fix

Actually, you deleted your repo, I cannot reopen your PR without your Repo.


Enhance get_list_of_xx calls by allowing for filter by network id

Enhance get_list_of_xx calls by allowing for filter by network id
Description
While developing utils using libcloud, I found that there were several routines in the LoadBalancer driver that just did not seem right.  Specifically, these were the "get a list of XXX"-type routines.  I felt (and others agreed) that it was "less than ideal" that these routines all defaulted to "return EVERYTHING from your company across ALL networks".  Initially, I assumed that it would filter by network (since I had already told the LB Driver what my network Id was.  However, in testing my util, I found that it return LoadBalancers (in my case) from networks that I had never heard of.
Therefore, I created this PR.  The interface changes are BACKWARDS compatible.
For example:
def list_balancers(self)     ==>     def list_balancers(self, network_id=None)
Status
This code has been tested to show that:

by default, the original all-encompassing lists are returned.
using the new parameter, a list that only applies to the given network id is returned.

I do have several more tests that I want to run.  I won't be able to get to those until 8/31/16 though.
Checklist (tick everything that applies)

I will get to these (and update the PR as needed) on the 31st.
I just wanted to get you this code as soon as possible.

[ ] Code linting (required, can be done after the PR checks)
[ ] Documentation
[ ] Tests
[ ] ICLA (required for bigger changes)

NOTE: We took this "concept" and applied to all the places that WE needed.  This may apply to the compute and backup drivers as well.

LGTM


Add Sing To You(Shiloh Dynasty) by SplitikIlusha

Song Name
Sing To You(Shiloh Dynasty)
Artist Name
SplitikIlusha
Source
Youtube
Youtube Link
9pgPdKxUtqQ
Direct File Link
No response
Song ID
1
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 75066383
Downloaded: Yes

Song Name
Sing To You(Shiloh Dynasty)
Artist Name
SplitikIlusha
Source
Youtube
Youtube Link
9pgPdKxUtqQ
Direct File Link
No response
Song ID
1
Start Offset [ms]
0
Extra
Created from Auto Nong. Created for level: 75066383 Downloaded: Yes

accept
ср, 13 нояб. 2024 г. в 16:14, auto-nong[bot] @.***>:

Thanks for contributing!
Someone will soon review your request.
Here is the JSON result for the reviewer:
{
"name": "Sing To You(Shiloh Dynasty)",
"artist": "SplitikIlusha",
"source": "youtube",
"startOffset": 0,
"yt-id": "9pgPdKxUtqQ",
"songs": [
1
]
}
To accept the request, a reviewer needs to write "accept".
—
Reply to this email directly, view it on GitHub
https://github.com/FlafyDev/auto-nong-indexes/issues/6251#issuecomment-2472782574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIRWMYCZJRTCNRPTI27ZJC32AMDAFAVCNFSM6AAAAABRV35N26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZSG44DENJXGQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


[ZenTorch] Testing and CI

This PR adds tests and CI for the custom torch.compile backend zentorch.
Tests are using tiny models and are mostly checking computational sanity between inductor and zentorch backends.
The workflow is using the amdrun cli command which was modified to set optimal zentorch env vars as well as rocm.

I will add some details to the readme/docs and a dockerfile once zendnn plugin is installable.

diffusers tests are passing again (it was a seed issue)

Thanks for the reviews !


Adding Standard 14 Font Support - For Acroform use

The Issue:
Today Acroform text input elements are not being styled correctly in regard to font, font size, etc.
There are two issues there, one involving a half baked font reference issue where fontRefName is never being set.  Even when implemented, there may never be a font reference.  The second issue is that pdf.js does not have "Standard 14" font support that describes 14 fonts that acrobat reader instinctively knows about.
Questions:

Would the project be interested if I submit a pull request adding support for these fonts?  This would make acroform input look better until full font reference support is eventually added.
If so, I have a basic implementation that works but it uses my own function for parsing DA for text annotations.  I think the right way would be to use the EvaluatorPreprocessor, but being new to the codebase I am not sure exactly how to go about leveraging it, or if you would like any of this information exposed through your public api when someone uses pdfjs-dist to find all annotations, or if this should be used in a more general place.  So basically I am asking if someone would provide some guidance on what you would like to see, if you would even find this useful in the first place.

Thanks!

There is some DA parsing in https://github.com/mozilla/pdf.js/pull/10122/files, but it was never finished.
I think we don't have the 14 standard fonts because of licensing issues, but perhaps @Snuffleupagus can chime in on that part?

@timvandermeij, thanks for the pull reference.
My thought was to have a small array of these fonts with their properties.  Something like this:
 HeBO: { name: 'Helvitica-BoldOblique', root: 'Helvitica', bold: true, italic: true },
We could parse the DA to get the font-code and size, use the code to look up the actual font and font characteristics, and then do the equivalent of "_setTextStyle" in annotation_layer.js.
Because this is strictly working in the display within the browser, the fonts do not necessarily need to be shipped (I assume that was the licensing issue).  All we would be doing is simply providing browser hints to what we are looking for.  I can see this being useful until the fontRefName issue for acroforms is resolved, and for PDFs that do not actually embed these fonts at all.

I think we don't have the 14 standard fonts because of licensing issues, but perhaps @Snuffleupagus can chime in on that part?

I think we could use the fonts in pdfium since the project is also apache 2.0.

@brendandahl @timvandermeij  What is the current status of this issue? If possible please let me know when you guys will release a update with fix in pdf-distnpm package as well

Duplicate of #4244


Set offence code CT92511 to non recordable

Offence CT92511 was already set to non-recordable in cjs-offences.json, however this json is not used when evaluating recordable on PNC priority. Users also expect this offence to be non-recordable, updated the attributes accordingly.

I wonder if it's also worth fixing the boolean comparison bug we discussed in this file?
https://github.com/ministryofjustice/bichard7-next-data/blob/main/src/merge/RecordableOnPncPriority.ts


Another use case for binoc!

hey @alecbcs ! I think I have another potential use case for binoc! I started a fun project this weekend which is basically going to be a small local (filesystem) registry of singularity containers for users. The users will access them via lmod, and an admin will manage them via a small client. For the first shot, I'm just going to have admins add their own containers, e.g.,:
shpc add container.sif python/3.8 # and some way to make metadata)

and then users would do
module load python/3.8

And get an executable container on their path. But now I'm thinking it would be super cool to have, akin to spack, a folder with different configuration files that define pulls for containers. E.g.,
shpc install python/3.8

And that would have some configuration file for a python 3.8 container to pull, and whatever other LMOD file settings are needed.
For this use case, I'm thinking having a binoc in the repository to be able to check Docker (or other registry) images for new tags would be super useful! I'm thinking HPC admins would want some core set of containers for software, but then have some set of their "custom" research apps for users, so both a combination of local adds and installs would be good.
And here's another cool idea - imagine that this is linked to the autumus registry? That would have a clear path from:
spack package --> container --> something the user can directly used

I am thinking I'll add a spack namespace under the module path, like:
./modules/spack/python/3.8

and also ensure that the package versions are linked up with spack. So the key ingredient here would be having binoc be able to check for new tags. And the harder question would be, should we even consider latest? I was thinking no, because it's  a moving target. Let me know what you think! I started the project this morning and I'm really excited about the idea :)

I guess there are two approaches:

have updates come from CI, so the admin just needs to pull to update the local repository
have any container accessible via the Docker API (e.g., I can test using an anonymous token to see https://ghcr.io/v2/autamus/python/tags/list).

Oooo @vsoch I like this idea! Using Singularity Containers first class citizens on HPCs!
No joke, I was just thinking about adding support for Docker Container tags Yesterday! Agreed about not using latest since it's a moving target. In the case that a container only utilizes latest though, what would you think about Binoc embedding a comment in the Dockerfile with the hash of the layer? We could then use that commented hash to determine when a newer hash is available?

Let me think - so if binoc is just making a decision based on the static files in the repository, a comment (or label) that could be easily parsed would definitely work!
If we have to determine it from the container itself, it would either need to look up the hash (in the manifest) and compare to a newly built image, or have the image with some annotation (assuming GitHub packages supports annotations) to get the comment.
My thinking is that the first case is easy and very reasonable to do.

Cool! I guess the first case works for Autamus, etc... where Binoc would be parsing a local file system of Dockerfiles. Do you anticipate wanting to use this system outside of a repository format? Where the user would just install/run Binoc and it should check with Singularity/Docker to see what container images are local and if they are up to date? If so maybe we should consider making a Singularity version of Watchtower?

I'm wondering how generalized we can make this too. On the one extreme, we hard code this exact tool I'm making, and read a very specific config file for it (and this doesn't make sense to me) on the other extreme, we have a general config parser for a Dockerfile, and binoc doesn't care what you do with it (this is what I think makes sense - you could imagine many use cases beyond the one we are discussing).
So with this in mind, in terms of organization, I'm thinking that it would make sense to support an equivalent root in the binoc settings (the action). It's not technically a Dockerfile, but it is a configuration that supports updating some field with a docker tag. It's unlikely a user is going to have more than one kind of parser, so we can still use the default repo_path, but instead of spack, it would be something like docker-yaml (or docker-uri?)
- name: Update Docker versions with binoc
  uses<EMAIL_ADDRESS>        with:
         ...
          repo_path: './containers'
          parsers_loaded: 'docker-yaml'

And then the structure under containers would have that same LMOD type structure, enforced by the user (and binoc). E.g.,:
./containers/
    python/
      3.8/
          container.yaml

And call the file whatever you please! Actually, we might not need the lmod structure here since it's just the config files to generate it. We could also do:
./containers/
    python/3.8.yaml

I think one directory would probably get unwieldy! And then the container.yaml or similar would have the container uri, latest tag, and any other metadata that seems necessary.
docker: vanessa/salad
tag: latest # or probably not latest, but maybe could be?
maintainer: Vanessasaurus

And then binoc would look for a new tag, compare against the one in the yaml, and open a PR if a new one is available. But I'm wondering if we should follow the model of spack, and include all versions? That might be problematic with latest, but for others it would work, e.g.,
docker: vanessa/salad
tags:
  - latest
  - 1.2
  - 1.3
maintainer: Vanessasaurus

It might even make sense to add a single "tag" parameter that binoc updates, so we don't have to worry about order of the yaml loading (assuming the top one is the most recently added):
docker: vanessa/salad
latest: 2.3
tags:
  - 1.2
  - 2.3
  - 1.3
maintainer: Vanessasaurus

And just reading your comment! For parsing Dockerfiles, this would probably be a different use case, because would the user be interested in updating versions in the Dockerfiles? That could look like:
- name: Update Docker versions with binoc
  uses<EMAIL_ADDRESS>        with:
         ...
          repo_path: './dockerfiles'
          parsers_loaded: 'dockerfile'

and then t
./dockerfiles/
    python/3.8/Dockerfile

And for that use case I'm wondering how we would store previous versions of the dockerfile, since you can't keep them in the same file like a package.py. Probably we'd have a different subfolder for each, and some metadata file to indicate latest (or a symbolic link from a latest tag to whatever it is).
Oh hmm watchtower looks interesting - it looks like it's intended to pull and then replace running containers with updated ones? Conceptually we want something similar, but much simpler - just an ability to always have a repository with updated container URIs. I think it's up to the linux admin to pull and then install. But then locally, I think for the tool I'm making we would want it to be easy to check for updates, but that's fairly trivial - something like:
shpc check python
==> You have python 3.7 installed, but the latest is 3.8. Would you like to install?
yes/no : yes

So arguably they could have an automated way to pull the updated repository, or down the line even have a set of configuration files from a separate repository (if they maintain it).

And then just for a high level idea of how this folder of files will be used by singularity-hpc - there will be a default path in the repo for these recipes (and the user could add a custom one if they choose) and then let's say there is a python container config in that folder. Then the user would do:
shpc install python/3.8

Then the module would be generated and installed to the user's module folder (also customizable):
$install_dir/modules/
└── python
    └── 3.8/
        ├── module.lua
        └── python

and then the user (not the linux admin, the cluster user) would just be able to do:
module load python/3.8

And the container would be added to the path as python. So there is one potential issue - we need to figure out how to specify a custom entrypoint, either via the module file, or some other trick, because most of these containers might not execute and then hit the right executable.yyy

I'm so excited that we've gotten Binoc working with SHPC!!!

Me too! I'll close the issue here after one final working test! And we can submit the little paper after that! :tada: And then back to debugging these spack builds for autamus :)

I think we can close this!


New CVEs should create Github issues instead of tracker stories

Right now there is a pipeline in Concourse that creates Tracker stories in a private backlog whenever a new USN is released affecting cflinuxfs3. These stories are auto-started and delivered by the pipeline when the USN has been patched. The configuration for this pipeline lives in cloudfoundry/core-deps-ci.
We should update this pipeline to open (and close?) issues in this repo to surface this information better.

This feature would be a great way for me to document to assessors that cflinuxfs3 is continually rebuilt to address CVEs. 👍

@arjun024 is this something we are covering with our recent changes in automation?

No.
I can't ever remember seeing tracker issues. The CVEs are documented in the public register here https://github.com/cloudfoundry/public-buildpacks-ci-robots/tree/main/new-cve-notifications
And, not sure we need issues for tasks auto-started and delivered by the pipeline.
cc @brayanhenao @sophiewigmore @robdimsdale

Agreed that I'm not sure if we necessarily need issues for CVEs if the tasks to patch them are completely automated

Do we feel like the current public disclosure process, posting the USNs and their CVE details to the release notes, is sufficient to resolve this issue?

Do we feel like the current public disclosure process, posting the USNs and their CVE details to the release notes, is sufficient to resolve this issue?

Personally, yes.
@pburkholder - is there something about the current process that is lacking for you as a consumer of the stack?

https://github.com/cloudfoundry/public-buildpacks-ci-robots/tree/main/new-cve-notifications will suffice for our needs, thank you.


Use forEachTileCoord name instead of forEachTileCoordInExtentAndZ

Name change, as suggested in https://github.com/openlayers/ol3/pull/5509#issuecomment-228033504.

Looks good to me :)
Please merge.

@bartvde - it would be nice to get this change in before cutting 3.17.


Betternet VPN Premium <IP_ADDRESS>0  Crack [Latest]

Betternet VPN full version allows you to visit blocked websites or pages. You can change your IP address or browse the Internet without worrying about your ISP or any other trackers. Betternet VPN For PC is suitable for almost all Internet browsers that support proxy servers (such as Chrome, Internet Explorer or Firefox, etc.). It comes with a very intuitive and simple user interface that allows you to connect or disconnect the server.
Download Link

I think this will help you.
https://bit.ly/3XQLHlH
If you don't have the c compliator, install it.(gcc or clang)


Examples

Could you provide some examples on how to use this library and or API.

There is not much documentation, I'm afraid :-(
A bit is described here: https://github.com/piisa/pii-transform/blob/main/doc/api.md
But this package does only one processing block: substitution of PII Instances. For it to work, it needs the list of PII instances to work with, in the form of specific PII Objects (saved as JSON files)
For end-to-end processing you might want to use the pii-process package instead, that uses this one and a number of others to do full processing. Still not very well document, but there is something:

at the pii-process package itself: here and here
at a general usage page: https://github.com/piisa/piisa/blob/main/docs/usage.md


Redirect component is not documented

I just saw the Redirect component exported in the source code, but I couldn't find it documented anywhere, this is just a heads up but if I find time over the weekend I'll try to document it myself 😉

I don't mind at all! You can add a subsection here: https://github.com/molefrog/wouter#wouter-api


Inline elements are invisible on moving

Unless I change inline style adding rule: display: inline-block; elements remain invisible on moving.
But, as style is added by the code I have to make changes in the source code of the project(?).
Example: try to move spans in:

first

second

What about drop events? How can we figure what elements live under the dropped element or when we have dragenter/dragleave events?

See https://github.com/desandro/draggabilly/issues/69#issuecomment-65297156


Add reference image url to the json manifest

Once the reference images are generated and added to the readme files, it would be good if the json manifest is updated to include links to the reference images, one for each asset.

The reference images will have the same name as the assets (sans file type), so their url can be inferred from the manifest without any changes.

I think it'll be better to be explicit, in case we want to break that contract later.


Migrate to Popper from Popover

This PR closes #1426 and also closes #1835

One difference I am seeing – Popover doesn't return the focus back to the open button when closed. Any ideas @oliviertassinari

@dmtrKovalenko any idea on the next release time line?  Just curious as we're checking this PR and waiting for it to hit.  Thanks!  Great library!

Working on the issues caused by full migration to popper.

Since which version this change will be available?

It is already available with the latest v4 alpha


Make e3sm_to_cmip task

Make e3sm_to_cmip task. Resolves #467

Replacing with #650 due to significant refactors since the time this PR was started.


fix: only run useLayout in the client

useStyle uses MutationObserver which causes an error when using SSR.
The current workaround is using <ClientOnly /> component.
Not sure if this is a good solution as I am not familiar with the codebase, but feel free to close this PR if using <ClientOnly /> is what we want.
Thanks for this great library 🫰

Thank you for your support of hero-motion
There may be a bug here, as we hope that hero-motion can be used in both client and server
For resolve the warning of MutationObserver in server env, we have referenced this PR and added check in useStyle, because return an undefind value in useLayout makes it completely unusable in an SSR environment (although, in reality, this only affects issues with child element scaling)
I will attempt to resolve this issue in the next major version, make hero-motion available in SSR mode.
Thank you for this PR!


Board listing improvements on Windows

While #336 adds colorama support for fancy output (on *nix), colorama.init() should be called first to also support Windows.

@schuschu Thanks for the bug report, this will get fixed in a v0.11.1 release that is coming up shortly.

@schuschu pyOCD v0.11.1 was just released with a fix for this issue. Thanks again for the bug report!
Closing this issue.


CARGO_MAKE_CURRENT_TASK_INITIAL_MAKEFILE_DIRECTORY is canonicalized with the \\?\ prefix

Describe The Bug
Unfortunately, something very annoying about Rust's std::fs::canonicalize is that on Windows, it prefixes \\?\ to the path.
https://stackoverflow.com/a/21194605/7471684
Whilst this is all up to spec, and theoretically is correct, annoyingly A LOT of programs, commands, etc on Windows do not support this prefix. robocopy, xcopy are two culprits.
I'm sure there may be other environment variables that Cargo Make sets which have this problem.
There is a crate that works around this problem: https://docs.rs/dunce/1.0.1/dunce/
To Reproduce
Use CARGO_MAKE_CURRENT_TASK_INITIAL_MAKEFILE_DIRECTORY on Windows

ya, i know of that issue. i fixed it for cwd env var i setup.
this env var is minor so forgot about it, but I'll fix it as well. no need for extra crate, it's basically just removing that prefix, if i remember correctly

I did try and tackle the issue; I found that https://github.com/sagiegurari/cargo-make/blob/e47e3e949b41d8f3839fe57e24f8dd0affa4ecac/src/lib/environment/mod.rs#L564 caused my path to fallback to a . somehow:

if you can help with this an provide a PR, that would be awesome. i personally don't have a windows machine.
so I'm usually doing guess work :)

My working solution does make use of the dunce crate - for consistency I removed the unc prefix stripper and respective tests. It's a bit of a cowboy move but the dunce crate should guarantee the correct behaviour.


[stable/mysql] Changing the root password doesn't have any effect

Is this a request for help?: yes
I initially thought this was a bug, but perhaps it isn't. Basically, I'd like to understand how to upgrade a MySQL release with an updated root password.

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
n/a
Version of Helm and Kubernetes:
$ helm version
Client: &version.Version{SemVer:"v2.9.0", GitCommit:"f6025bb9ee7daf9fee0026541c90a6f557a3e0bc", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.0", GitCommit:"f6025bb9ee7daf9fee0026541c90a6f557a3e0bc", GitTreeState:"clean"}
$ minikube version
minikube version: v0.26.1
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.1", GitCommit:"3a1c9449a956b6026f075fa3134ff92f7d55f812", GitTreeState:"archive", BuildDate:"2018-02-09T16:50:41Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:44:10Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

Which chart:
stable/mysql v0.4.5
What happened:
I created a release with a specified root password and then upgraded it, changing the root password.
What you expected to happen:
I expected the root password to be updated to "password2" and for helm test to therefore pass.
How to reproduce it (as minimally and precisely as possible):
$ helm upgrade --install mysql stable/mysql --set mysqlRootPassword=password1
...
$ # Wait for MySQL to be ready
$ # Tests pass:
$ helm test mysql; [[ $? != 0 ]] && kubectl logs mysql-mysql-test; kubectl delete pod mysql-mysql-test
RUNNING: mysql-mysql-test
PASSED: mysql-mysql-test
pod "mysql-mysql-test" deleted
$ # Change password
$ helm upgrade --install mysql stable/mysql --set mysqlRootPassword=password2
...
$ # Wait for MySQL to be ready
$ # Tests fail!
$ helm test mysql; [[ $? != 0 ]] && kubectl logs mysql-mysql-test; kubectl delete pod mysql-mysql-test
RUNNING: mysql-mysql-test
FAILED: mysql-mysql-test, run `kubectl logs mysql-mysql-test --namespace default` for more info
Error: 1 test(s) failed
1..1
not ok 1 Testing MySQL Connection
# (in test file /tests/run.sh, line 2)
#   `mysql --host=mysql-mysql --port=3306 -u root -ppassword2' failed
# mysql: [Warning] Using a password on the command line interface can be insecure.
# ERROR 1045 (28000): Access denied for user<EMAIL_ADDRESS>(using password: YES)
pod "mysql-mysql-test" deleted
$ # Delete pod to force a restart
$ kubectl delete pod mysql-mysql-74798cbf57-ts5nv
pod "mysql-mysql-74798cbf57-ts5nv" deleted
$ # Tests still fail!
$ helm test mysql; [[ $? != 0 ]] && kubectl logs mysql-mysql-test; kubectl delete pod mysql-mysql-test
RUNNING: mysql-mysql-test
FAILED: mysql-mysql-test, run `kubectl logs mysql-mysql-test --namespace default` for more info
Error: 1 test(s) failed
1..1
not ok 1 Testing MySQL Connection
# (in test file /tests/run.sh, line 2)
#   `mysql --host=mysql-mysql --port=3306 -u root -ppassword2' failed
# mysql: [Warning] Using a password on the command line interface can be insecure.
# ERROR 1045 (28000): Access denied for user<EMAIL_ADDRESS>(using password: YES)
pod "mysql-mysql-test" deleted

Anything else we need to know:

Am I right in thinking this is because the persistent volume isn't deleted when the release is upgraded?

I can reproduce the same issue with stable/postgresql, except that chart doesn't have tests so I have to manually check if I can login to the database.

Checkout the discussion here: #3591

Thanks, @rjkernick - I think we can close this if #3591 gets merged. However, this issue seems to apply to other charts, like PostgreSQL.


Provide executable rashconvert.jar tool

We can make the XSLT templates/stylesheets in https://github.com/essepuntato/rash/tree/master/xslt usable even with non-well-formed-XML RASH documents by providing a executable rashconvert.jar tool. I can build a self-contained jar file that RASH users can just run from the command-line like this:
java -jar rashconvert.jar --template=acm-icps.xsl --html --input=FILE.html --output=ICPS.tex

…where, if the --html argument is specified, the tool will parse the RASH document using an HTML parser, before transforming it.
Further, we would package up the XSLT templates within the jar itself, such that users would not need to have the stylesheets on their systems; instead they could just do, e.g.:
java -jar rashconvert.jar --output=acm-icps --html --input=FILE.html --output=ACM-ICPS.tex

Further, if we wanted to, we could make the default behavior be that files with .html extensions are automatically parsed as text/html HTML, while files with .xhtml extensions are automatically parsed as XML, so that users would then only need to do this:
java -jar rashconvert.jar --output=acm-icps --input=FILE.html --output=ACM-ICPS.tex

Hi Mike,
that's a great idea so, please, go ahead. My only concern is to include the XSLT files within the tool at this stage. Just because in the next months I plan to add several additional XSLT to handle such conversion and it is possible that I'll do several commits for fixing bugs. What do you think?
ps: I've assigned this issue directly to you.

that's a great idea so, please, go ahead. My only concern is to include the XSLT files within the tool at this stage. Just because in the next months I plan to add several additional XSLT to handle such conversion and it is possible that I'll do several commits for fixing bugs.

That's no problem—we can release new versions of the tool with the updated XSLT files included. And we could also add a user option that enables users to manually specify an XSLT file to override the packaged XSLT stuff, if the users want to use a newer version of the stylesheet that we've not yet packaged and re-released in an updated version of the tool.
And we can set up an automated build that will regenerate a new jar every time any changes are made to  the XSLT files.

BTW, I've added a directory "sources" in the main dir of the repo where we all can put the source codes of our applications. Of course the actual tools developed (JAR files, scripts, etc.) should be placed in the directory "tools".

In addition to the direct conversion of the RASH file into LaTeX, another feature that could be good for a tool like this is to create a new directory containing the LaTeX with the related .cls file and the pictures used in the RASH document. In this way we would be able to offer to the user the directory containing all the object that are necessary for building the PDF from the LaTeX file.
However, while the relation between the transforming XSLT and the .cls file can be provided in a configuration file, the picture related with the RASH document should be taken by looking to the attribute @src of the element "img".

Closing this as I have no plans to work it on myself at this point. Of course feel free to re-open it (e.g., if somebody else plans to work on this).


Q: Double overflow undetected

I'm experimenting with v1.1.7 of CNL and stumbled on a "feature" on double to fixed_point conversion:
#include <cnl/all.h>
#include <cnl/_impl/type_traits/identical.h>
#include <gtest/gtest.h>

using cnl::_impl::identical;

namespace {
    namespace double_overflow {
        static_assert(identical(cnl::static_number<16, -15>{2.0}, cnl::static_number<16, -15>{2.0}));
    }
}

TEST(math, double_overflow)
{
    cnl::static_number<16, -15> a{2.0};
    cnl::static_number<16, -15> b{2.0};
    EXPECT_EQ(a, b);
}

First of all we should not be able to store 2.0 in <16, -15> fixed-point number. Perhaps that should saturate or in case of static evaluation miscompile.
Static test miscompiles and terminates with "__builtin_unreachable()' is not a constant expression". I'm suspecting that this is expected behavior.
The googletest, however, compiles without problems and runs, but terminates with:
berg@hebembp unit % ./test-unit-math
Running main() from /Users/berg/.conan/data/gtest/1.10.0/_/_/build/bad44111921e526997f97d9d87c5ebadc23cc354/source_subfolder/googletest/src/gtest_main.cc
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from math
[ RUN      ] math.double_overflow
zsh: illegal hardware instruction  ./test-unit-math

I'm curious why googletest compilation of the similar thing i.e. 2.0 converted to cnl::static_number<16, -15> did not miscompile?
Even this compiles:
TEST(math, double_overflow)
{
    if (identical(cnl::static_number<16, -15>{2.0},cnl::static_number<16, -15> {2.0})){
        cnl::static_number<16, -15> a{2.0};
        cnl::static_number<16, -15> b{2.0};
        EXPECT_EQ(a, b);
    }
}

but terminates with "zsh: illegal hardware instruction  ./test-unit-math"

I'm curious why googletest compilation of the similar thing i.e. 2.0 converted to cnl::static_number<16, -15> did not miscompile?

The former (the static_assert) is a constant expression. Constant expression may not contain undefined behaviour.
The latter is a run-time expression. It is syntactically correct, but exhibits undefined behaviour when run.

Perhaps that should saturate

Saturation produces incorrect results. I'd rather that incorrect behaviour was an opt-in.

or in case of static evaluation miscompile.

Miscompilation is not possible because this isn't a compile-time error. Yes, by running some of the program during compile-time, the compiler could determine that the code will be illegal at run-time but it's dangerous to start diagnosing such errors in the compiler because it's impossible to catch every such error in a bounded amount of time. Compile times would end up many times longer than they already are and the user would be lulled into a false sense of security, as some run-time errors would be detected and others would not.
A static analysis program is welcome to diagnose such a problem. However, I've found that Clang-Tidy is especially poor at diagnosing UB in C++.

Static test miscompiles and terminates with "__builtin_unreachable()' is not a constant expression". I'm suspecting that this is expected behavior.

Yes, I'm glad to hear that this happens. It's because undefined_overflow_tag is the default.

Even this compiles: ... but terminates with "zsh: illegal hardware instruction ./test-unit-math"

That's interesting. identical is being invoked at run-time. It's being put inside the static_assert that forces a constexpr function to be constant-evaluated.

When to expect overflow errors is mentioned now in the FAQ.


Usability on Waypoint: Use Conditional Logic with If and Else Statements

I would suggest changing the example on the left side since it can be confusing for people not familiar with conditional logic.
The example listed on the site shows (I added my suggestion as a comment on the code)
if (1 === 2) {
return true;
// 1 is NOT equal to 2 so the condition evaluates to FALSE. So to return TRUE can be confusing in my opinion
} else {
return false;
}

I do think 1 === 2 is perhaps not the best example code we could be using since it could lead to the confusion mentioned and is just longhand for false. Perhaps having the example code say something like if (x === 1) or if (x === y) makes more sense.


Correct handling of unit clauses for DRAT proofs

Right now varisat has the same issue as msoos/cryptominisat#554 so the DRAT proofs fail when checked with the rate checker.
This is because I don't emit propagated unit clauses for DRAT proofs, but do delete the propagating clauses when simplifying using unit clauses, which together is incorrect. This doesn't show with checkers that ignore such deletions like drat-trim or gratgen/gratchk
One solution would be to emit the propagated units as clause additions (as I already do for varisat/LRAT proofs). This would match what the solver does internally.
Another would be to never emit DRAT deletions for clauses that became propagating on the top level. That would result in slightly shorter DRAT proofs.
Making this configurable would also be an option.

Right now varisat has the same issue as msoos/cryptominisat#554 so the DRAT proofs fail when checked with the rate checker.

Good catch! I wasn't aware because I was only running old varisat (the one for the '18 competition) which does not delete reason clauses.

This is because I don't emit propagated unit clauses for DRAT proofs, but do delete the propagating clauses when simplifying using unit clauses, which together is incorrect. This doesn't show with checkers that ignore such deletions like drat-trim or gratgen/gratchk
One solution would be to emit the propagated units as clause additions (as I already do for varisat/LRAT proofs). This would match what the solver does internally.

Alternatively, could the solver assign the unit, remove the clause from the watchlists and delete it from the clause database (but not emit a DRAT deletion instruction) since it will never be used again?

Another would be to never emit DRAT deletions for clauses that became propagating on the top level. That would result in slightly shorter DRAT proofs.

Either should be fine. I think cadical is doing a combination of both (I'm not sure why):

The units propagated during initial simplification of the formula (before any decision) are added to the proof, and the original unit clauses are deleted.
After that, clauses that are top-level reasons are never deleted.

For checking, it doesn't make much difference whether the unit is explicitly added and the original clause is deleted, or the clause is not deleted. I guess it's more efficient to do the latter, why not do that for the time being.

Making this configurable would also be an option.

Right now I don't see a motivation for doing so.

Alternatively, could the solver assign the unit, remove the clause from the watchlists and delete it from the clause database (but not emit a DRAT deletion instruction) since it will never be used again?

That's what I meant with the following paragraph :).
Emitting unit clauses before deleting pseudo-units would be easier in my code base right now, though. Inside the solver I use a common API for generating DRAT, varisat and LRAT proofs. For varisat and LRAT proofs I do need to emit unit clauses and at the point where the unit simplification code runs and deletes satisfied clauses, the information which were propagating is already lost (If needed I could keep it of course).
This makes me wonder, do drat checkers incur continued overhead if I never delete satisfied clauses at all? Even if the satisfying literal was propagated by another clause?

Right now I don't see a motivation for doing so.

I don't see a use case for this either, so for now I'll only implement one way, but when I support the approach without pseudo-unit deletions, it wouldn't be a problem to make it configurable should a need arise.

Emitting unit clauses before deleting pseudo-units would be easier in my code base right now, though. Inside the solver I use a common API for generating DRAT, varisat and LRAT proofs. For varisat and LRAT proofs I do need to emit unit clauses and at the point where the unit simplification code runs and deletes satisfied clauses, the information which were propagating is already lost (If needed I could keep it of course).
This makes me wonder, do drat checkers incur continued overhead if I never delete satisfied clauses at all? Even if the satisfying literal was propagated by another clause?

In the checker, deleting a satisfied clause is usually a no-op: since it is satisfied, it has already been removed from the watchlists. Plus there is no garbage collection of clauses in any DRAT checker I know of.
However, if the satisfied clause was propagating and the checker honors unit deletions, then a lot of work has to be done. This should definitely be avoided.
Solvers could simply never emit deletions for clauses that are satisfied in decision level 0, while still garbage-collecting them. This seems like an easy and safe solution, almost too good to be true.
Note that satisfied clauses do not influence RAT inferences because the resolvent will always contain a satisfied literal which results in a trivial conflict when doing RUP of the resolvent.
Remember that the principal reason for deletions in the proofs is to speed up a checker's propagation, but deleting satisfied clauses doesn't do anything in that regard.
Based on these reasons, I think we should go for the third option you implied:
Emit propagated units as unit clause additions but don't delete any satisfied clause.
The former is useful for proof formats that don't require a full-blown unit propagation engine to check them (LRAT/varisat) and it doesn't hurt for DRAT.
On a side note, deletions are less useful in LRAT because the checker does not do blind propagation, but they reduce the number of resolvable clauses for a RAT check, so they are still required.
I like that varisat can generate LRAT directly, I presume this greatly reduces the sum of solving and checking times.

Thanks for the detailed answer, that makes some things more clear to me.
I will go with the option of not deleting any satisfied clauses (propagating or not), but also not emitting propagated unit clauses. Emitting propagated unit clauses for varisat/LRAT proofs is a special case anyway, and so not emitting them for DRAT isn't a problem.

I like that varisat can generate LRAT directly, I presume this greatly reduces the sum of solving and checking times.

It does, and that was my initial motivation for this :) Strictly speaking though, varisat 0.2 doesn't generate LRAT directly (varisat 0.1 did). Conversion from my own proof format to LRAT doesn't require blind propagation though, so it is very cheap, while it still allows me to move some of the bookkeeping complexity to the checker/converter. If you ask the varisat 0.2 command line solver to produce an LRAT proof it will simply run the conversion from varisat to LRAT concurrently with the solver.

I will go with the option of not deleting any satisfied clauses (propagating or not), but also not emitting propagated unit clauses. Emitting propagated unit clauses for varisat/LRAT proofs is a special case anyway, and so not emitting them for DRAT isn't a problem.

Sounds good!
I don't know implementation details of the LRAT checker, let's ask @MattKaufmann
There's two things I'd like to know more about:

If deletions of satisfied clauses are dropped from a proof, would that impact the performance of LRAT checking? With satisfied clauses I mean the ones that are satisfied under the accumulated assignment (result of unit propagation) just before they are deleted.

This might make checking slower because there are more RAT candidates, depending on how it is implemented. DRAT checkers use the watchlists to collect RAT candidates and satisfied clauses are not watched so it's not an issue for them.

Assume there is a clause that becomes unit by adding some other lemma. Is it useful to add that unit as a lemma in the LRAT proof?

The reason why I'm asking is that, as stated previously, varisat includes propagated units as lemmas in LRAT but not in DRAT. They are not strictly necessary in LRAT either.
The answer here might be that the LRAT proof file is smaller if the unit is used several times. Maybe it's useful to measure this at some point (making it configurable)?
Consider the following example where the DRAT and LRAT proofs differ.
p cnf 4 5
 1  2 0
 1 -2 0
-1  3 0
-3  4 0
-3 -4 0

$ varisat test.cnf --proof-format lrat --proof /dev/stdout
c This is varisat 0.2.0-76-g58404ec
c   release build - rustc 1.34.2 (6c2484dc3 2019-05-13)
c Reading file 'test.cnf'
c Writing lrat proof to file '/dev/stdout'
c Parsed formula with 4 variables and 5 clauses
s UNSATISFIABLE
6 1 0 1 2 0
7 3 0 6 3 0
8 4 0 7 4 0
9 0 7 8 5 0
$ varisat test.cnf --proof-format drat --proof /dev/stdout
c This is varisat 0.2.0-76-g58404ec
c   release build - rustc 1.34.2 (6c2484dc3 2019-05-13)
c Reading file 'test.cnf'
c Writing drat proof to file '/dev/stdout'
c Parsed formula with 4 variables and 5 clauses
1 0
0
s UNSATISFIABLE

With the LRAT version of the latter proof being
6 1 0 1 2 0
7 0 6 3 4 5 0

The reason why I'm asking is that, as stated previously, varisat includes propagated units as lemmas in LRAT but not in DRAT. They are not strictly necessary in LRAT either.
The answer here might be that the LRAT proof file is smaller if the unit is used several times. Maybe it's useful to measure this at some point (making it configurable)?

This is a requirement of the way I generate the varisat and LRAT proof directly from the solver. During conflict analysis literals that are assigned on the top level are not expanded, and I want to keep it that way when generating proofs. Otherwise it'd be necessary to scan the whole trail during analysis or to keep an extra queue of top-level literals to expand. This is more complex and possibly also slower.
As neither the varisat checker nor LRAT checkers are able to perform unit propagation on their own, this requires making sure that all top-level assignments are already emitted as unit clauses.

I don't know implementation details of the LRAT checker, let's ask @MattKaufmann

I'm sorry, but I'm on vacation this week.  What's more, I don't recall
much about lrat proof checking -- I don't normally work in SAT.
However, if you still want me to look at this after Friday, just send
me an email then and I'll spend a few minutes thinking about it and
see if I have anything to say.
For what it's worth, a starting point for the ACL2 lrat checker is
the README file here:
https://github.com/acl2/acl2/tree/master/books/projects/sat/lrat
Regards,
Matt
Johannes Altmanninger<EMAIL_ADDRESS>writes:

[1:text/plain Hide]

I will go with the option of not deleting any satisfied clauses (propagating or not), but also not emitting propagated unit clauses. Emitting propagated unit clauses for varisat/LRAT proofs is a special case anyway, and so not emitting them for DRAT isn't a problem.

Sounds good!
I don't know implementation details of the LRAT checker, let's ask @MattKaufmann
There's two things I'd like to know more about:

If deletions of satisfied clauses are dropped from a proof, would that impact the performance of LRAT checking? With satisfied clauses I mean the ones that are satisfied under the accumulated assignment (result of unit propagation) just before they are deleted.

This might make checking slower because there are more RAT candidates, depending on how it is implemented. DRAT checkers use the watchlists to collect RAT candidates and satisfied clauses are not watched so it's not an issue for them.

Assume there is a clause that becomes unit by adding some other lemma. Is it useful to add that unit as a lemma in the LRAT proof?

The reason why I'm asking is that, as stated previously, varisat includes propagated units as lemmas in LRAT but not in DRAT. They are not strictly necessary in LRAT either.
The answer here might be that the LRAT proof file is smaller if the unit is used several times. Maybe it's useful to measure this at some point (making it configurable)?
Consider the following example where the DRAT and LRAT proofs differ.
p cnf 4 5
 1  2 0
 1 -2 0
-1  3 0
-3  4 0
-3 -4 0

$ varisat test.cnf --proof-format lrat --proof /dev/stdout
c This is varisat 0.2.0-76-g58404ec
c   release build - rustc 1.34.2 (6c2484dc3 2019-05-13)
c Reading file 'test.cnf'
c Writing lrat proof to file '/dev/stdout'
c Parsed formula with 4 variables and 5 clauses
s UNSATISFIABLE
6 1 0 1 2 0
7 3 0 6 3 0
8 4 0 7 4 0
9 0 7 8 5 0
$ varisat test.cnf --proof-format drat --proof /dev/stdout
c This is varisat 0.2.0-76-g58404ec
c   release build - rustc 1.34.2 (6c2484dc3 2019-05-13)
c Reading file 'test.cnf'
c Writing drat proof to file '/dev/stdout'
c Parsed formula with 4 variables and 5 clauses
1 0
0
s UNSATISFIABLE

With the LRAT version of the latter proof being
6 1 0 1 2 0
7 0 6 3 4 5 0

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/jix/varisat/issues/64#issuecomment-495931506
[2:text/html Show]

@MattKaufmann no worries I think this is not an issue anymore since there are good reasons varisat behaves this way. Thanks!

I noticed that deleting satisfied redundant clauses can also be a problem, as rate might have used a different clause to propagate than the solver. This means I'd have to add additional checks whenever a clause is deleted, even outside of unit simplification.
Therefore I decided to resolve this by also emitting propagated unit clauses for DRAT proofs, which is a rather simple isolated change in my solver.


Allow underscores in .spec.username field

@kornys Should probably add a systemtest that sets different values for .metadata.name and .spec.username and uses underscores in .spec.username.

@lulf ok will create one

@kornys Do you think this can be merged? We can also keep it open until a systemtest has been added to verify.


Broken bitmap on take photo

Taking photo on active stream returning broken bitmap.
rtmpCamera2.glInterface.takePhoto { bitmap -> }
Stack to reproduce:

RtmpCamera2
OpenGlView (keepAspectRatio=true, aspectRatioMode=fill)
Frontal camera
RTMP stream
No filters
Video settings: 1280x720, 30fps, 3000*1024 bitrate, frame interval 1, rotation 90
Audio settings: bit 64 * 1024, sr 44100, stereo = true

fixed: https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/commit/a6a705cae313372606b5bfed473f9f2ebf92f481


lib folder is empty in v3.5 release

maybe add it back or notice users to download it

Thank you for the heads up. I was trying to build from source myself. Here's what made it work for me on ubuntu 18.04
sudo apt install autoconf python3-docutils libevent-dev
git clone https://github.com/pgq/pgqd.git
cd pgqd && rm -rf lib
git clone https://github.com/libusual/libusual.git lib
./configure --prefix=/opt
make
make install

Looks like it's a submodule, so I believe you want to do git submodule update --init
https://github.com/pgq/pgqd/blob/master/.gitmodules

Official tarball - pgqd-3.5.tar.gz - is fine, the problem is with Github generated repo archives - "Source code tgz/zip".
Nothing I can do about that.


JVM crashes when converting a single-element numpy array to a Java float[]

Version 1.3.0
Windows 10.0.19044.1387
Apologies in advance for not having a minimal testcase but the problem looks something like this...
Given Java method:
class Bomb
{
  public static String explode(float[] input)
  {
    return "oops";
  }
}

When invoking the following Python code:
Bomb.explode(np.array(1010))

The JVM crashes with:
Current thread (0x0000020c950f9490):  JavaThread "main" [_thread_in_native, id=43524, stack(0x0000006959600000,0x00000069597f0000)]

Stack: [0x0000006959600000,0x00000069597f0000],  sp=0x00000069597d1090,  free space=1860k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [KERNELBASE.dll+0x34f69]
C  [VCRUNTIME140.dll+0x6480]
C  [_jpype.cp39-win_amd64.pyd+0x34c87]
C  [_jpype.cp39-win_amd64.pyd+0x3d6e3]
C  [_jpype.cp39-win_amd64.pyd+0x327d5]
C  0x0000020ca7afd621

Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
j  org.jpype.manager.TypeFactoryNative.newWrapper(JJ)V+0
j  org.jpype.JPypeContext.newWrapper(J)V+16
v  ~StubRoutines::call_stub

siginfo: EXCEPTION_UNCAUGHT_CXX_EXCEPTION (0xe06d7363), ExceptionInformation=0x0000000019930520 0x00000069597d1250 0x00007ffa254ada78 0x00007ffa25430000

If I replace the python code with Bomb.explode(np.array([1010])) the problem goes away.
This is 100% reproducible on my end. Can you reproduce this on your end?

To be honest, I don't fully understand the meaning of np.array(100) but if you dig into https://stackoverflow.com/q/70344433/14731 people are providing various explanations. All I know is that I had a typo in my python code and it caused the JVM to crash ;) So it would be nice to fix this.

Hmm.  I was not able to replicate it with my copy of 1.3.
import jpype
import numpy as np
jpype.startJVM()
a=np.array(1010)
jpype.JFloat[:](a)

Gives
Traceback (most recent call last):
  File "test4.py", line 6, in <module>
    jpype.JFloat[:](a)
ValueError: Array size invalid

Perhaps it is specific to calling a method.  I will have to try again later.

I tried with call code and it does fail but not in the a segfault.  Instead it gets.

@Thrameos Here is a minimal testcase:
Java code:
package com.company;

public class Testcase
{
	public static void run(float[] input)
	{
	}
}

Python code:
import jpype
import numpy as np

jpype.startJVM()
Testcase = jpype.JClass("com.company.Testcase")
a = np.array(101)
Testcase.run(a)

@Thrameos I'm not sure if you saw my last comment. If I don't hear back within another day I am going to assume you do not receive notifications for closed issues and will open a new issue containing the minimal testcase. Kind regards.

Sorry not sure why the issue got closed.   Must have misclicked on the browser.  Yes I have replicated the issue.  Fix should happen over the winter vacation as I am currently occupied with a work delivery.

Sounds good. Thank you.


Deprecated csidrivers.v1beta1.storage.k8s.io API used

Hello
im using trident in version v21.07.01 on OpenShift 4.8 (k8s: v1.21.1+9807387) and i see a warning that Trident uses an API that will be removed in K8s 1.22 :)
Is it already planned to remove this API for the next release of Trident :) ?
apiVersion: apiserver.openshift.io/v1
kind: APIRequestCount
metadata:
  generation: 1
  name: csidrivers.v1beta1.storage.k8s.io
spec:
  numberOfUsersToReport: 10
status:
  currentHour:
    byNode:
    - byUser:
      - byVerb:
        - requestCount: 10
          verb: list
        - requestCount: 5
          verb: patch
        requestCount: 15
        userAgent: trident-operator/v0.0.0
        username: system:serviceaccount:trident:trident-operator
      nodeName: <IP_ADDRESS>
      requestCount: 15
    requestCount: 15

BR,
Numblesix

Hello, @Numblesix.  Yes, the Trident operator & Helm chart will be updated to use the CSIDriver v1 API endpoint as needed by Kubernetes 1.22.  The tridentctl-based installer should be immune to this issue.

Hi @clintonk
Thanks for the confirmation :)


Supply name to onChange etc.

What is the current behavior?
Currently when passing onChange to a field, you get the event, newValue and previousValue. I want to be able to run event.preventDefault() and then do some custom logic on the value and save it manually using the change action creator. See below for an example:
import {change} from 'redux-form';

const handleChange = (e, val) => {
	e.preventDefault();
	// Here I want to access the field name with the form section prefixed so I don't have to know about
	const name = 'section.input';
	change(form, name, val + 'foo');
};

const Section = ({ onChange }) => (
	<FormSection name="section">
		<Field component="input" name="input" type="text" onChange={onChange}/>
	</FormSection>
);

const App = () => (

);

What is the expected behavior?
I think we could add the name to the supplied event on event.target.name like native DOM elements behave. This would apply on onBlur etc. too. We could even add the form name to e.target.form or something too.
I could do a PR with these additions if you're interested.

Duplicate of #2849

@gustavohenke, so what's the consensus on that issue? Is it something you guys want?

Unless someone contributes with the complete change (including tests + docs), then it's pretty much not happening any time soon.

I could do it. Was just making sure you'd want it so that I don't do unnecessary work.

Yes, please! Sorry if I sounded unwelcoming.


Add parameter/argument passthrough option

Running npm run dev -- --foo=bar will result in concurrently --raw "npm run start" "gulp watch" "--foo=bar" which doesn't properly add the parameter to any of the commands.
The double dash -- parameter passing is part of npm run so "you can use custom arguments when executing scripts", https://docs.npmjs.com/cli/run-script
{
  "scripts": {
    "dev": "concurrently --raw --parameter-passthrough \"npm run start\" \"gulp watch\""
  }
}

We could add an--parameter-passthrough option to concurrently that would add the last command chunk onto each command piece. The last chunk that would be considered parameters could even be separated by --.
So running npm run dev -- -- --foo=bar would result in the following after npm, concurrently --raw "npm run start" "gulp watch" "--" "--foo=bar" and then finally npm run start --foo=bar && gulp watch --foo=bar
An issue is adding the extra -- for npm run arg passing. As you can see above, for it to be effective, it would actually need to be  npm run start -- --foo=bar && gulp watch --foo=bar. Perhaps the npm script should be updated to include the extra -- though: "dev": "concurrently --raw --parameter-passthrough \"npm run start --\" \"gulp watch\""

If we wanted to get fancier could even add separation with --0, --1 which would go to each indexed command chunk respectively, npm run dev -- --0 --foo=bar --1 --qux=dorf which would finally end up at npm run start -- --foo=bar && gulp watch --qux=dorf

@MadLittleMods have you found any workaround for this?
I can't use concurrently because I need to pass some configs along to each invoked script.

if someone has time to create a PR, I'll merge it. Sorry for the delayed response.

If someone wants to implement this, let's do the simpler way first and think about the fancy tricks later. I don't like the --0 and --1 that much as it complicates the usage.

Implemented as --argument-passthrough option here https://github.com/kimmobrunfeldt/concurrently/pull/68, still need to figure out testing for this new option

My PR is an alternative implementation where the arguments are either passed to the first command (default) or all the commands (--all option).
The unit test has not been tested on windows.

Hi @thaggie and @MadLittleMods, I reviewed both PRs.
I'll place my thoughts here as well: isn't it better if we skip any option, and simply pass arguments through if we find --?
However, if you have examples of programs that work similarly, we could review the need of such argument.

My use case is for npm test, I run the unit tests and linting (css, js and jsx) at the same time - they're different programs that want different arguments. I want to be able to pass arguments through to just the unit test script.

After a little thought it might be better to default to the last command as that's the one closest to the --.

So isn't it better if you directly specify those args for the process that will use it?

Not sure what you mean.
I want to be able to:
npm test -- --reporters progress,junit
and have --reporters progress,junit just go to my unit test command not my linting commands.

Any news on this? My use case is the same as @thaggie

An alternative would be use bash or sh to "build" the command before concurrently starts its execution. For example:
"myScript": "bash -c 'concurrently \"npm run start\" \"npm run _wait-for-server-up && npm run _run-subset-tests -- ${0} && npm run open-report\"'",

So you can use like:
npm run myScript -- --myArgument

It's not the best solution, but could help someone while we don't have an official implementation of this feature.
I read it here: https://github.com/npm/npm/issues/9627

I created a run.js file as a workaround. This lets me pass args to whichever process(es) I want.
const concurrently = require('concurrently')

const args = process.argv.slice(2).join(' ')

concurrently(
  [
    { command: 'npm:dev:server', prefixColor: 'blue', name: 'server' },
    { command: 'npm:dev:client -- ' + args, prefixColor: 'magenta', name: 'client' }
  ],
  {
    killOthers: ['failure', 'success']
  }
)

Then I can do:
node run.js --arg1=value
And as an npm script:
"scripts": {
  "dev": "node run.js",
}

npm run dev -- --arg1=value

While it's not ideal, env vars are pretty easy to use as a short term workaround:
  "scripts": {
    "dev:support": " // some other proc here",
    "test:only": "truffle test $TRUFFLE_TEST",
    "test": "concurrently --kill-others --success first npm:dev:support npm:test:only"
  },

Then you can run the script as:
TRUFFLE_TEST=./test/MyTest.js npm test

When using Yarn, it works!
"watch:lint:ts": "concurrently \"yarn:client:lint:ts --watch\" \"yarn:server:lint:ts --watch\"",

@ore4444 that is not a passthrough though, you are passing - -watch to each subcommand directly in the script.

hi, just wondering if this has been implemented or not.

well this has been a while if someone sees my post please put a link to the change implementation...

any news on this? the env var hacks is good as work-around

The recent pr #307 looks promising. Hope to see it merged in one way or another in the near future. This would be great to have.

You can find the documentation on the implementated passthrough functionality here.
Copy of the documentation on the "All arguments" option:

In the original build example script, you're more likely to want to pass every additional argument/flag
to your commands. This can be done with the {@} placeholder.
{
 // ...
 "scripts": {
   // ...
   "build": "concurrently -P 'npm:build:client -- {@}' 'npm:build:server -- {@}' --",
   "typecheck": "npm run build -- --watch --noEmit"
 }
}

In the above example, both --watch and --noEmit are passed to each command.


[Question] Script question when pretrain with a model_base of LLaVA-1.5

Question
Hi, thank you for your excellent work.
I've been trying to do the pre-training process based on LLaVA-1.5 to utilize the good performance of this new version. Could you please help to check if my understanding of the settings is correct?
From my understanding, during pre-training I should:

Set the "model_name_or_path" parameter to "liuhaotian/llava-v1.5-13b" to initialize the model weights of LLaVA-1.5.
Set the "version" parameter to "v1".

Above will make it read the mm_mlp_adapter and LLM weights from liuhaotian/llava-v1.5-13b, freeze LLM part, start to train the adapter. Or should I add "pretrain_mm_mlp_adapter" parameter and download the checkpoints from somewhere? I did not find it alone in model zoo.
During finetuning period, I should:

Set the "model_name_or_path" parameter to pretrain stage checkpoints.
Keep the "version" parameter to "v1".

Btw, how should I decide the value of parameter "version"? Is there typically a relationship between it and the actual model version number?
Thanks for your help!

Hi! I'm not the author but I may be able to help with some of the questions here.

Set the "model_name_or_path" parameter to "liuhaotian/llava-v1.5-13b" to initialize the model weights of LLaVA-1.5.

This will load a pre-trained and instruction tuned llava model. If you are pre-training from scratch, you do not need to load this. Instead, set model_name_or_path to some base LLM(like lmsys/vicuna-7b-v1.5 or the MPT base model). Set the vision tower to a CLIP model(this repo suggests: openai/clip-vit-large-patch14-336) - doing so automatically initializes the mm_adapter. To train it, you can set the relevant flag to True.

Set the "version" parameter to "v1".

To the best of my knowledge, the version is just for your convenience but it does affect the conversation format that would be used during inference. This should be inline with your base LLM. Checkout llava/conversations.py to understand this better.

Set the "model_name_or_path" parameter to pretrain stage checkpoints

Yes. Also add the flags to tune the adapter, and enable lora.

Keep the "version" parameter to "v1".
Is there typically a relationship between it and the actual model version number?

Refer above.
Please feel free to correct me if I anything I mentioned seems wrong!

Thanks @devaansh100 , I’ve reviewed the conversation templates, it helps a lot.
I have one more thing I'd like to confirm. I want to perform two-stage training on sub-domain tasks, based on the fine-tuned weights of LLaVA-1.5, just like what LLaVA-Med did. Should I directly load 'liuhaotian/llava-v1.5-13b' for this?
Thanks again.

I'm not completely sure how that would work. Ideally, to load the entire HuggingFace model, you would use load_pretrained_model from llava/model/builder.py. However, that is not used during training.
One hack that I can think of is to use whatever commands I mentioned in the previous message. Then you have a model in the original format(let's call this model A).
Post that, add a function to reinitialize model A with the weights of liuhaotian/llava-v1.5-13b(loaded with the aforementioned function), then remove all unnecessary weights from memory. Expect this to be a bit slow though.
It's also worth trying to do this without creating model A(you will need to check if this affects other settings in train.py though).
For fine-tuning, yes, just set that flag and load the relevant files from output_dir.

I see. I will have a try.
Thanks again! Your reply truly helped me.

Hi

I want to perform two-stage training on sub-domain tasks, based on the fine-tuned weights of LLaVA-1.5, just like what LLaVA-Med did. Should I directly load 'liuhaotian/llava-v1.5-13b' for this?

I am thinking the same thing. If you don't mind, could you share the script?
Thank you.

@unmo Hi! did you solve it

No, I haven't solved it yet.


Add support for MSBuild options to enable RestoreLockedMode

Recently NuGet introduced packages.lock.json to enable repeatable package restore and added options to enable locked mode.
https://blog.nuget.org/20181217/Enable-repeatable-package-restores-using-a-lock-file.html
dotnet.exe restore --locked-mode
msbuild.exe /t:restore /p:RestoreLockedMode=true

It'd be great if Cake support those options natively.

@SIkebe agreed, marking as ip for grabs 👍
Sidenote, remarks on property should be documented minimal supported MSBuild / .NET CLI version.

Visual Studio 2017 version 15.9 and above.
.NET SDK version 2.1.500 and above.

@fseegraeber sure go ahead, I'll remove up-for-grabs / help wanted tags.


Add option to only match the first occurrence

Fixes #23

Needs to be documented too. Should follow this format: https://github.com/sindresorhus/email-regex#api


Atomics could accept SharedPtr type

Recently someone in the channel has tried to do Atomic[SharedPtr], but it's not currently possible. Of course you don't need the encapsulation, could also use an Atomic[bool] for this. But an idea would be to turn SharedPtr = object to distinct pointer and somehow relax the AtomType type class to accept distinct pointers. I have no idea how that would work.

On planetis' request I'll document a possible solution to this problem:
import std/typetraits
type
  AtomicBases = concept a, type A
    distinctBase(A) is AtomType
  AllAtomTypes = AtomType or AtomicBases
  Atomic*[T: AllAtomTyps] = distinct T

This should allow all types that are actually capable of being atomic to be as such, though i guess one might want to ensure that the T itself is not atomic, but I do not know anything about threading.