cmd/go: behavior of go list ... is not documented in module mode

go help packages documents the special path all both for gopath and module mode:
"all" expands to all packages found in all the GOPATH trees. For example, 'go list all' lists all the packages on the local system. When using modules, "all" expands to all packages in the main module and their dependencies, including dependencies needed by tests of any of those.

However the ... pattern is documented only for gopath module:
An import path is a pattern if it includes one or more "..." wildcards, each of which can match any string, including the empty string and strings containing slashes. Such a pattern expands to all package directories found in the GOPATH trees with names matching the patterns.

How is the ... pattern supposed to work in module mode?
As a test, I ran go list ... | wc -l  inside the github.com/golang/mod (golang.org/x/mod) directory with different versions of the go tool.  The directory is outside GOPATH.  The results are:

go1.11.13: 501
go1.12.16: 526
go1.13.8: 632
go1.14rc1: 634

As a side note, how can I tell go list to list only packages in the main module?

In an empty module inside GOPATH, where go list all matches no packages:

go list ...: 300
go list std cmd: 376

/cc @jayconrod @bcmills @matloob per owners.

I think that go list ... should never match packages outside the main and active modules.
The difference between go list ... and go list std cmd is that the latter also includes the vendor directories.

It is true that we have not documented the ... package pattern in module mode. The intent is for it to have the same meaning as in GOPATH mode: every package that can be found in any of the available package roots. (In GOPATH mode, the available package roots are GOROOT/src, and GOPATH/src for each entry in GOPATH. In module mode, the available package roots are GOROOT/src and each active module.)
The increase from Go 1.11 to 1.12 is due to the change from vendor/golang_org/x to internal/x for packages vendored into the standard library (see CL 147443).
The increase from Go 1.12 to 1.13 is due to the inclusion of the cmd subtree plus the addition of crypto/ed25519. (The previous lack of cmd packages was a bug present since Go 1.11: note that the cmd subtree was always included in GOPATH mode.)
The minor changes from Go 1.13 to 1.14 are due to changes in internal packages plus the addition of hash/maphash.

The difference between GOPATH mode and module mode in Go 1.13 is due to the requirement that each package have a unique path in module mode: for example, the package reported as cmd/vendor/golang.org/x/sys/unix would be just one of many possible packages known as golang.org/x/sys/unix in GOPATH mode.
Arguably the lack of such a listing entirely in GOPATH mode is a bug, but it is a fairly minor one and at this point almost certainly not worth fixing.

There is still something missing, in module mode.
For go1.13, the number of packages in GOROOT is 376 (and ... only matches 300 packages).
Inside the golang.org/x/mod module:

go1.13 list all: 170
go1.13 list std cmd all: 392
go1.13 list std cmd ...: 708

Am I missing something?

Per https://tip.golang.org/cmd/go/#hdr-Package_lists_and_patterns:

When using modules, "all" expands to all packages in the main module and their dependencies, including dependencies needed by tests of any of those.

Since no package in the main module can import a package main from cmd, that is a strict subset of ....

Is it only me that thinks this is really complex?

The ... pattern is just not all that useful. It's an edge-case of a general wildcard. So, yeah: edge cases are complex, but generally avoidable. (The all pattern is usually what you want instead, and that one is well-defined.)

It could be make useful if ... matches only the packages in the main module, since there are no other means to get that list.

@perillo can you not do
go list $(go list -m)/...

I think we do need a pattern that matches only the packages in the main module, but ... is not that pattern.
(./... is such a pattern, but it only works in the module root.)

@myitcv: go list $(go list -m)/... will catch packages in nested modules too.

@jayconrod, @matloob, and I were discussing such a pattern this morning, in fact.
(We're thinking maybe mod, since it's a three-letter shortening like std and cmd and less likely than main to be used as the name of someone's local toy module.)

@bcmills I tested go list $(go list -m)/... from inside the golang.org/x/tools directory and it does not list the golang.org/x/tools/gopls sub module.

It would if x/tools depended on gopls, which it (intentionally) does not.
I think cloud.google.com/go has that sort of structure, though.

Ok, one last try 😄
go list -f "{{\$p := .}}{{with \$p.Module}}{{if eq .Path \"$(go list -m)\"}}{{\$p.ImportPath}}{{end}}{{end}}" $(go list -m)/...

My suggestion is to update the documentation to say a pattern containing a ... pattern expands to all packages with names matching the patterns found in std or the modules in the build list. In GOPATH mode such a pattern expands to all package directories found in the GOPATH trees with names matching the patterns.


⚠ Bofrost.fr has degraded performance

In 7a3d907, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1055 ms

Resolved: Bofrost.fr performance has improved in cd56241 after 19 minutes.


Sending message to group

How to sending messages to groups?

see examples folder.

Sorry, I've seen the example, but there's only a message replay. There's no way to send a message directly to a group. I've also tried sending a message to a group using the group ID, but the message wasn't sent. Please help me.

Sorry, I've seen the example, but there's only a message replay. There's no way to send a message directly to a group. I've also tried sending a message to a group using the group ID, but the message wasn't sent. Please help me.

see examples folder.

Sorry, I've seen the example, but there's only a message replay. There's no way to send a message directly to a group. I've also tried sending a message to a group using the group ID, but the message wasn't sent. Please help me

there is a client.send_message(chat, text) in the example file. send_message takes two arguments: to a JID object, and message which can be either a str or a Message object.
e.g., this should work:
from neonize.proto.Neonize_pb2 import JID

group_id = "..."

group_jid = JID(
    User=group_id,
    Device=0,
    Integrator=0,
    IsEmpty=False,
    RawAgent=0,
    Server="g.us",
)
client.send_message(group_jid, "hi there!")

there is a client.send_message(chat, text) in the example file. send_message takes two arguments: to a JID object, and message which can be either a str or a Message object.
e.g., this should work:
from neonize.proto.Neonize_pb2 import JID

@client.event(events.MessageEv)
def on_message(client: NewClient, messageEv: events.MessageEv):
    # echo messages!
    text = message.Message.conversation or message.Message.extendedTextMessage.text
    chat = message.Info.MessageSource.Chat

    client.send_message(chat, text)

or from a stored group id
group_id = "..."
group_jid = JID(
    User=group_id,
    Device=0,
    Integrator=0,
    IsEmpty=False,
    RawAgent=0,
    Server="g.us",
)
client.send_message(group_jid, "hi there!")

for the first code isn't it to reply to incoming messages?
while for the second code I have tried but it does not work, an error appears
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x6e9ac826]
goroutine 17 [running, locked to thread]:
go.mau.fi/whatsmeow.(*Client).getOwnID(...)
/home/runner/go/pkg/mod/go.mau.fi/whatsmeow@v0.0.0-20240619210240-329c2336a6f1/client.go:374
go.mau.fi/whatsmeow.(*Client).SendMessage(0x6f1ffe80?, {0x6ed7ed60?, 0x6f1fe660?}, {{0xc000318000, 0x12}, 0x0, 0x0, 0x0, {0xc00008864c, 0x4}}, ...)
/home/runner/go/pkg/mod/go.mau.fi/whatsmeow@v0.0.0-20240619210240-329c2336a6f1/send.go:179 +0x126
main.SendMessage(0x7?, 0x1cf65294370, 0x22, 0x1cf6528fd10, 0x1f)
/home/runner/work/neonize/neonize/goneonize/main.go:119 +0x286
I've also tried with how to
client.send_message(build_jid('jid group'+@g.us,'text') but the message is also not sent (no error appears)

for the first code isn't it to reply to incoming messages?

yes. but you can nonetheless send to groups other than those triggered the inbound message.
This error is showing because you didn't run client.connect()
client.connect() will block the main thread. You can run it in a separate thread. Or run your logic in a new thread separately.

client.send_message(build_jid('jid group'+@g.us,'text')

no error appears because the JID is wrong. it will output something like: group_id<EMAIL_ADDRESS>i've issued a PR to fix this. but in the main time you can do something like this:
def build_jid(chat_id, server="s.whatsapp.net")
  return JID(
      User=chat_id,
      Device=0,
      Integrator=0,
      IsEmpty=False,
      RawAgent=0,
      Server=server,
  )

there is a client.send_message(chat, text) in the example file. send_message takes two arguments: to a JID object, and message which can be either a str or a Message object.
e.g., this should work:
from neonize.proto.Neonize_pb2 import JID

@client.event(events.MessageEv)
def on_message(client: NewClient, messageEv: events.MessageEv):
    # echo messages!
    text = message.Message.conversation or message.Message.extendedTextMessage.text
    chat = message.Info.MessageSource.Chat

    client.send_message(chat, text)

or from a stored group id
group_id = "..."
group_jid = JID(
    User=group_id,
    Device=0,
    Integrator=0,
    IsEmpty=False,
    RawAgent=0,
    Server="g.us",
)
client.send_message(group_jid, "hi there!")

for the first code isn't it to reply to incoming messages?
while for the second code I have tried but it does not work, an error appears panic: runtime error: invalid memory address or nil pointer dereference [signal 0xc0000005 code=0x0 addr=0x0 pc=0x6e9ac826]
goroutine 17 [running, locked to thread]: go.mau.fi/whatsmeow.(*Client).getOwnID(...) /home/runner/go/pkg/mod/go.mau.fi/whatsmeow@v0.0.0-20240619210240-329c2336a6f1/client.go:374 go.mau.fi/whatsmeow.(*Client).SendMessage(0x6f1ffe80?, {0x6ed7ed60?, 0x6f1fe660?}, {{0xc000318000, 0x12}, 0x0, 0x0, 0x0, {0xc00008864c, 0x4}}, ...) /home/runner/go/pkg/mod/go.mau.fi/whatsmeow@v0.0.0-20240619210240-329c2336a6f1/send.go:179 +0x126 main.SendMessage(0x7?, 0x1cf65294370, 0x22, 0x1cf6528fd10, 0x1f) /home/runner/work/neonize/neonize/goneonize/main.go:119 +0x286
I've also tried with how to client.send_message(build_jid('jid group'+@g.us,'text') but the message is also not sent (no error appears)

It seems I was not careful with this instruction, but now my problem has been solved with this. Thank you very much😊🙏


Mac setup

It looks like the git user couldn't write the gogs.db file. I was able to set the username to root (and again on the install page) and it all worked. Thanks for the docker image!
Here's the run command I used to get it to work on Mac.
docker run --name=gogs -d \
  -e USER=root \
  -e USERAME=root \
  -p 10022:22 \
  -p 10080:3000 \
  -v ~/Desktop/gogs:/data \
  codeskyblue/docker-gogs ./gogs web

Maybe you need use chmod to change prop.


make strftime() $timestamp optional

I think this should be optional and default to the value returned by time(): https://www.php.net/manual/en/function.strftime.php

makes complete sense, i just copied it from the strtotime function since it seemed to do the same thing 😅


Update CityHash to version v1.0.3.

See here for changes: http://code.google.com/p/cityhash/source/browse/trunk/NEWS

closed by 24530ce8aeca84804f985798fb2514bdf4816460


Missing StrStringsUpgradeableString is causing tests to fail

📝 Details
The CI tests for this repo are failing because there is an undeclared identifier in ECDSAUpgradeable.sol. On line 219, StrStringsUpgradeableString does not resolve to anything. Instead, it should use StringsUpgradeable.toString()

🔢 Code to reproduce bug
See the CI logs: https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/runs/4027734122?check_suite_focus=true

Resolved by https://github.com/OpenZeppelin/openzeppelin-transpiler/commit/b3c645661038bdbe81cda258f73cfd6722b224b5.


Show question image on website from backend

Mostly done, just needs to be altered slightly once question functions have  been adjusted to have an image attached too

Should use a better example image that is more like an actual diagram that would make sense for one of these questions.


Patching an isomorphic structure

I have a remote data structure that is isomorphic to the local structure I'm diff'ing and I'd like to use the edit script to patch the remote structure (in an effect-full way). @eelco - in your paper you describe the edit script referring to an internal stack that pushes and pops subtrees from the source and target tree. Is there any more information about that process you could provide me?

@kosmikus, @ggreif - I realize @eelco may not be watching this repo. If you know how to get in touch with him please let me know - thank you! :)

@schell you might get inspirations from my slides http://bobkonf.de/2015/slides/greif.pdf
Anyway, extending patch to effectful operation is on my agenda (especially when deletions must be reified effectfully, which I haven't so far managed to emulate in terms of stock patch).

@ggreif thank you! This looks great. I'll let you know if I have questions. Is that okay?

@schell yea, sure, keep asking!

:+1:

I'm definitely interested in the polymorphic containers addition - is that available now? Are there any examples you have of using located values?
I'm a little confused about calling diff on an (IO Configtree) - how can diff compare IO actions?

@schell regarding IO you only ever diff purely packed values, where unsafePerformIO is safe :-). Then IO is "just like" a polymorphic Id functor. patch is a different issue, altogether.
For polymorphic containers you need -XRankNTypes IIRC. You start like this:
data Fam t ts where
  Just' :: Fam el elts -> Fam (Maybe el) elts
  Nothing' :: Fam (Maybe el) CNil

Writing the Family instance is pretty straightforward, Type is a bit tricky. Please look at the other open issue to get some hints. I have to run now, but if you wish I can set up a gist later (or add to the wiki?).
One more hint: I do not have a satisfying story for decEq on Nothing', since there is nothing we can delegate the decision to. I currently use unsafeCoerce Refl for this, but I also considered adding a Typeable constraint and an eqT test.

Thank you! And yes, please start the wiki, that would be very helpful.

@schell I have written https://github.com/eelco/gdiff/wiki/PolymorphicContainers. For now it explains [a], but Maybe should be the same, unless you want the optimization Just' :: Fam a ts -> Fam (Maybe a) ts which needs the Meta constructor descriptor, which is not on mainline (yet?).

@schell I’m still watching the repository, but @ggreif is doing excellent work and is way more on top of it (thanks!)

Thank you :)

@ggreif I think I've come up with another way of doing polymorphic containers without unsafeCoerce. By adding a qualifying type variable and one more constructor to the initial data type we can encode the values within the polymorphic type, and then we need some constraints on the Family and Type instances:

data ListFam a t ts where
    Nil'  :: ListFam a [a] Nil
    Cons' :: ListFam a a Nil -> ListFam a [a] (a `Cons` [a] `Cons` Nil)
    Val'  :: a -> ListFam a a Nil

instance (Eq a, Show a) => Family (ListFam a) where
    decEq (Cons' a) (Cons' a') = do (Refl, Refl) <- decEq a a'; Just (Refl, Refl)
    decEq Nil' Nil' = Just (Refl, Refl)
    decEq (Val' a) (Val' a') | a == a'   = Just (Refl, Refl)
                             | otherwise = Nothing
    decEq _ _ = Nothing

    fields (Cons' _) (a:as) = Just (a `CCons` as `CCons` CNil)
    fields Nil' [] = Just CNil
    fields (Val' _) _ = Just CNil
    fields _ _ = Nothing

    apply (Cons' _) (a `CCons` as `CCons` CNil) = a : as
    apply Nil'  CNil = []
    apply (Val' a) CNil = a

    string (Cons' _) = "Cons"
    string (Val' a)  = show a
    string Nil'      = "Nil"

instance (Eq a, Show a) => Type (ListFam a) a where
    constructors = [Abstr Val']

instance (Eq a, Show a) => Type (ListFam a) [a] where
    constructors = [ Concr Nil', Abstr $ \(x : _) -> Cons' $ Val' x ]

After that it's business as usual as far as I can tell.
I'm still working on a way of transforming a Editscript (ListFam a) [a] [a] into a EditScript (ListFam b) [b] [b]. I thought it would be as easy as
fmapEditList f (Ins (Val' a) es) = Ins (Val' $ f a) (fmapEditList f es)
fmapEditList f (Cpy (Val' a) es) = Cpy (Val' $ f a) (fmapEditList f es)
fmapEditList f (Del (Val' a) es) = Del (Val' $ f a) (fmapEditList f es)
fmapEditList f (CpyTree es) = CpyTree $ fmapEditList f es

But it isn't! Thoughts?

I guess since the types in the AST can be heterogeneous, a transformation may not be possible. I'm not sure...

@schell I think what is tripping yo over are the List ListFam ts constraints that live in Ins and co. I suggest writing a slightly more complex function that also gives back a Dict (List ListFam) ts constraint reified as a value and pattern match on that. For Dict see the "dirt-eliminator" branch in my fork, or ekmett's constraints library.
But in this simple case you might get away with specifying
List (ListFam b) (b `Cons` [b] `Cons` Nil)

on your fmap's signature. But you probably have to also check for Nil' etc. there.

Hi @schell, I am trying to do exactly the same thing. Did you have any success patching the isomorphic structure, or even just defining fmapEditList?

@rvl - no! Sorry!
tldr; I gave up on this approach and switched to an entirely different strategy.
I was building a tree of datatypes that represent graphical elements in a scene, and then attempting to use gdiff to create an edit script to apply to an isomorphic tree of renderers that would render the 'elements' to the screen.
My new strategy is to write Hashable instances for all elements and hold them in a flat list with a transformation and hold the renderers in a map keyed by the elements' hashes. When an element is updated its hash changes and its previous renderer can be removed from the map (and dealloc'd). The strategy is less elegant but also less 'deep'.
I hope you figure it out!

Thanks for your help @schell. I am diffing something like
Text.XML.HXT.DOM.TypeDefs.XmlTrees
and want to apply the edit script to an actual DOM.
If possible I will persist with this strategy. My plan is to parse the
edit script with Parsec to produce a list of DOM operations. For this,
I need a function similar to fmapEditList:
import Text.Parsec.Prim

type XmlDiff = EditScript XmlTreeFamily XmlTree XmlTree

instance Monad m => Stream XmlDiff m XmlDiff where
  uncons = return . diffUncons

diffUncons :: XmlDiff -> Maybe (XmlDiff, XmlDiff)
diffUncons x@(Ins _ d) = Just (x, diffUncons d)
diffUncons x@(Del _ d) = Just (x, diffUncons d)
diffUncons x@(Cpy _ d) = Just (x, diffUncons d)
diffUncons x@(CpyTree d) = Just (x, diffUncons d)
diffUncons End = Nothing

The problem is that the type of the Stream instance and uncons are
wrong. But at this point I don't know enough about GADTs and
heterogenous lists to make it right.

@rvl What about setting up a small concrete example of what you want to accomplish (as a gist with MIT license) and give me perms? Then I can give it a try. I spent a few months of my life gdiff-whispering all kinds of GADTs, so there is a fair chance that I can help you.

Hi @ggreif, thanks for your generous offer. I have put the essence of my plan and some context in a standalone script: PatchDom.hs.

Cool. I doubt you'll get far with the "parse . show" approach. I'll try the
method sketched in the presentation I linked in an earlier comment. But now
I have to sleep first.
Em sábado, 9 de janeiro de 2016, Rodney Lorrimar<EMAIL_ADDRESS>escreveu:

Hi @ggreif https://github.com/ggreif, thanks for your generous offer. I
have put the essence of my plan and some context in a standalone script:
PatchDom.hs https://gist.github.com/rvl/f710168be81b5428835c.
—
Reply to this email directly or view it on GitHub
https://github.com/eelco/gdiff/issues/10#issuecomment-170169496.

Has anyone had any luck with this? I'm revisiting with a new project and am now in need of the ability to patch a separate structure. I think this would be the defacto operation in this library. It seems to me that patch by itself is superfluous given that you already have the target value in order to diff in the first place - but maybe I'm not understanding the main use case. Is the main use case saving the edit script to disk and applying later?


CORS allowed origins need "https://"

In the section marked "configure CORS" above, the allowed origins must be preceded by "https://" for this to work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 84aabaf3-e7da-3519-995c-72d36c537843
Version Independent ID: b35afa8d-a02c-a77a-6831-2b3f6a6c1a7d
Content: Customize the user interface of your application using a custom policy in Azure Active Directory B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-ui-customization-custom.md
Service: active-directory
Sub-service: b2c
GitHub Login: @davidmu1
Microsoft Alias: davidmu

@AndyEdmonds Thanks for your feedback.We will investigate and update the thread.

@AndyEdmonds Thanks for reporting this. I have updated the doc accordingly and it will be published shortly.


Test on Windows.

I have a dual booted Windows 8 machine I can test Superzippy on. I'm not sure if it's worth   actually supporting Windows, but I'd be interested to know how difficult it would be. I can set up a VM to run tests if I do decide to support Windows.

I have not used superzippy before, but I will need to distribute tools to all of the major platforms (Windows/Mac/Linux) and just experimented with zipping up the code and prefixing it with shell commands - as superzippy does, so I thought to share how I think it could be done.
For windows support I see two options:
Windows can directly execute files with .cmd extensions if they contain meaningful batch commands.
So the code before the zip is different for Windows - it is something like (use CRLF as end of line!!!)
@echo off
python.exe "%~f0" %*
exit /b %errorlevel%

for explanation of the magic characters see http://ss64.com/nt/syntax-args.html
This feature would need something like

--windows switch
.cmd extension when --windows is specified
Windows specific code before the zipped content

Another option is to provide a .cmd file that registers the .sz extension as Python.File and let python run Python.Files, also making .sz a known executable extension.  Running this .cmd file once will enable use of .sz files created for linux/macosx.
This needs changing some settings permanently

FTYPE & ASSOC
PATHEXT variable (from windows 7 there is a setx command to do this)

The .cmd trick sounds good to me. It's straightforward, portable, and doesn't require an installation step besides having Python around. These are all attributes of super zips on non-Windows platforms too, so it would be good to keep them consistent.
Thank you for investigating this! I'm not sure when I'd be able to implement this, but if you or anyone else wants to implement it I'd be excited to bring it in.

Creating a simple bootstrapping program that just runs Python on itself also seems easy to do, and that could be a .exe file. I'd like cross-compiling to be dirt-easy, which seems like it might be at least a little tricky. But probably not too bad.


Empty state registered models

Closes: https://issues.redhat.com/browse/RHOAIENG-2229
Description

Added empty state for Registered models

How Has This Been Tested?

Change empty prop in ModelRegistry.tsx(there is no delete API yet) and navigate to Model Registry from sidebar
Test Impact

Added e2e tests
Request review criteria:

Self checklist (all need to be checked):

[X] The developer has manually tested the changes and verified that the changes work
[X] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[X] Included any necessary screenshots or gifs if it was a UI change.
[X] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

@yih-wang Do we need the table header(filter and buttons) provided in the mocks? There are several empty states do not have these. Here's an example(there's just an action button without the headers):

Also, now that the design is changing, do we still use the PlusCircleIcon, I tried using the Model Serving empty state image and it looks like this - let me know if we are still going ahead with the PlusCircleIcon for this:

/hold
Please merge #2677 before merging this PR

Do we need the table header(filter and buttons) provided in the mocks?

@manaswinidas  Yes, we need the table header in the case of Model Registry. The empty state only implies there are no models in the current registry. There could potentially be models in other registries, and we have to provide the ability for users to switch to them.

Also, now that the design is changing, do we still use the PlusCircleIcon, I tried using the Model Serving empty state image and it looks like this - let me know if we are still going ahead with the PlusCircleIcon for this:

We will follow the old style (PlusCircleIcon) for now. The illustration that is used in the empty state varies between different components. The one you are using here is specifically for adding the model server. There is additional work from the design perspective to choose the proper illustration and adjust the color theme. So all the components (including Model Registry) that haven't been launched to the console are postponed to use the new style.

@lucferbux addressed the changes

/retest


Add Dozer lambda runtime sample

Add Dozer lambda runtime sample - react room temp monitoring app with twilio SMS notification

Tested on Dozer release 0.1.19 and  pydozer_log version 0.1.19


(demo) Load unsplash images end to end

Summary
This PR combines the API and Media3pPane work together to demonstrate a working end to end Unsplash media list.
2 changes:

A cherry-pick of Diego's Media3pApiProvider from: https://github.com/google/web-stories-wp/pull/3004
A commit to fix the broken things in State Management.

@cvolzke4 is this still needed or can it be closed?


Improved "bank-account" example

Make sure we close redundancies
Make sure we using the features of case classes
Make sure we using flatMap as functional approach (The monadic version is prefered by the scala guys)

Greetz
Freshwood

Thanks @Freshwood ! Looks good.


[SMALLFIX] add @Nullable for GlusterFSUnderFileSystem.java

add @Nullable for GlusterFSUnderFileSystem.java

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16355/
Test PASSed.

@whatbeg Thanks for the improvement. Should we annotate the interface instead of the implementing class?

@whatbeg any updates on this? thanks.

@calvinjia what do you mean? which @nullable annotation should not be added?

@whatbeg If the interface contract is to return null in certain cases, I think we should annotate the interface (UnderFileSystem) as well

@whatbeg Thanks for the contribution. Can you address the comment and resolve the conflict?

@whatbeg feel free to reopen this PR after you address the comments.


Server Dropdown Doesn't Always Stay Open From A Tap

I have not tested this in any other browser than Chrome but from time to time the dropdown menu will not stay open with a tap as from a laptop. I'll tap on my trackpad and it opens and closes immediately. I am forced to click and drag. Is there a timeout option or something in your UI for this that can be adjusted?

No timeout, just the default select2 functionality. I have updated select2 to the latest version and did small changes to the code in this regard. In 24 hours I'm releasing 17.60.
In case it doesn't work after update please post the video-screencast with opened console and I'll try to figure this out.

You're sure on top of these things!

This is not fixed. It's just as bad as before although I like the fact it opens up further without the scroll bars.

Steffan, could you post video-screencast please? I can't imagine how it can look bad?

tapping-closing.mov.zip


Documentation updates

The documentation needs some updates. This will pr will aim to vastly improve and update the documentation

@magnouvean I left you a PR to your branch in your repo (is this the way to.contribute to your draft PR?) bc I think we should provide both a "homemanager standalone" and a "homemanager as a module" example


provide feedback to user when "save analysis" is clicked

report success or error (with details) using our new alert system

LGTM


[BUG] Error 268.

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[ ] My answer given in the checkbox above is a lie.

What problem did you encounter?
Even though i am not hacking i get this error, i reinstalled. i followed multiple guides, restarted multiple times, etc.

What are you doing before this pop up appears?

i wasnt doing anything else, i opened my computer, opened roblox and experienced this

I guess try doing a complete reinstall (Uninstalling through the control panel or settings app, then deleting the Bloxstrap folder)

As the preliminary instructions asked, does this happen only when using Bloxstrap? https://github.com/pizzaboxer/bloxstrap/wiki/Switching-between-Roblox-and-Bloxstrap

Only with bloxstrap happens, I did do reinstall through control panel, and nothing.

Upload your configuration: https://github.com/pizzaboxer/bloxstrap/wiki/Uploading-your-Bloxstrap-configuration

Settings.json
State.json
ClientAppSettings.json
here

My antivirus is off though, same with firewall, and i dont have any 3rd party antivirus/firewall

You have a completely stock config, there isn't any real reason for variations like this to be happening unless something external was interfering.

I'll look more into firewall, etc. and see what i can do

Assuming issue is resolved


Performance improvement

I found that performing forward-backward in a loop is much faster than using autograd.grad with retain_graph=True. Your current code is:
        loglikelihood_grads = zip(*[autograd.grad(
            l, self.parameters(),
            retain_graph=(i < len(loglikelihoods))
        ) for i, l in enumerate(loglikelihoods, 1)])

https://github.com/kuc2477/pytorch-ewc/blob/master/model.py#L75
after I change it to:
        for batch, label in zip(buffer_data, buffer_label):
            self.zero_grad()
            loglikelihood = F.cross_entropy(self(batch), label)
            loglikelihood.backward()
            for n, p in self.named_parameters():
                n = n.replace('.', '__')
                grads[n] = grads.get(n, 0) + p.grad ** 2

it runs much faster. Can you please investigate this?
Thank you.
Thanh Tung

Hey!
Quick question: don't the gradients for each parameter have to be averaged out batch-wise?
Thanks!
Sungwon Hwang


Support HarmonyOS

Is there already an issue requesting this feature?

[X] I have searched the existing issues.

Please select affected platform(s)

[ ] Android
[ ] iOS
[ ] Linux
[ ] macOS
[ ] Web
[ ] Windows

Use case
OpenHarmony will support flutter base on Flutter 3.7.12. it comes from https://gitee.com/openharmony-sig/flutter_flutter.
Proposal
If it's okay, I can help complete the implementation of this platform. and OpenHarmony is not stable for now, maybe the api will update regularly, geolocator_ohos is independence package and it only dp on geolocator_platform_interface, so i think it will be ok, right?  i will submit a pr after i finish it ,thanks.
Specific requirements or considerations
No response
Additional information or context
No response

move to https://github.com/HarmonyCandies/geolocator_ohos


Mat/Pat - Parental leave start date validation doesnt work in review page

If parental leave start date is not valid the error e.g. it is before maternity end date, the error does not show in the Review page, only in the parental leave start date page
Video - https://bcgov.sharepoint.com/:v:/r/teams/03991/Shared Documents/Maternity and Parental Leave/Test Screenshots %26 Recordings/Screen Recording 2024-06-21 at 12.02.43 PM.mov?csf=1&web=1&e=h0zm9F
AC

[ ] If parental leave start date is not valid the error should show in both review page and the Parental leave - start date tab

Tested and updated!

validation works


Use HTTPS for fetch gems

@Maks3w  :+1: this and your other two PRs are awesome. Would you mind repointing them to the dev branch though? Thanks!

(Whoops, didn't see that dev was in a bad state. I hard reset it and it should be better now. Sorry about that!)

@lord Unfortunatelly develop branch does not have the changes done in master.
Please sync develop with master or cherry pick the commits of PRs #247 #248 #249

@Maks3w just did that a second ago!


IndexedArray in Numba-jitted code

Hi! I took an indexed array from the tests and tried to apply a jitted function.
content = awkward1.layout.NumpyArray(numpy.array([0.0, 1.1, 2.2, 3.3, 4.4]))

ind = numpy.array([0,0,0,0,1,2,3,4,4,4,4,4,], dtype=numpy.int64)
index = awkward1.layout.Index64(ind)
array = awkward1.layout.IndexedArray64(index, content)

@njit
def foo(x):
    return x[1]

foo.py_func(array) #works
foo(array) #fails

with error
Invalid use of Function(<built-in function getitem>) with argument(s) of type(s): (awkward1.IndexedArrayType(array(int64, 1d, C), awkward1.NumpyArrayType(array(float64, 1d, A), none, {}), none, {}), Literal[int](1))
This is using version 0.2.19, and numba 0.49.1rc1

The reason is that only high-level ak.Array objects can be passed into (and out of) a Numba-compiled function. (By design: the high-level arrays are the ones that users are supposed to interact with primarily; the layout objects you're creating, such as IndexedArray, are part of the "internals". Also, behaviors such as "this array of variable-length lists is actually an array of strings" are defined at the ak.Array level and not the layout level.)
To make your example work, you only need to wrap your array as an ak.Array:
>>> array2 = awkward1.Array(array)
>>> foo(array2) #works
0.0

The limitations of what is supported inside the lowered code need to be listed prominently, as it is for Numba itself (Supported Python features and Supported NumPy features). PR #268 adds subs for where this would go, just under "Converting arrays" and "Creating arrays", visible without scrolling on a regular-sized screen.


add test that checks that generated code is compilable

The thing with _test-cache is not that elegant as it's stateful, but otherwise the tests just become too slow, I think.
Great library, btw.

Thanks!
Could you have a look at getting Elm installed in the Travis environment? It should be straightforward - see https://github.com/elm-community/elm-test/blob/master/.travis.yml

@mattjbray: Yes, travis is green now.

Great, thank you.


GH-2198: Switch from Timer to Observation

https://github.com/spring-projects/spring-kafka/issues/2198 Phase 1

I looked a Spring Batch, per this document https://docs.google.com/document/d/1hF3djSMo45NcaivbFEI3E9ruITm-3DjOSZ6VxO4Kg8U/edit#


[Feature] Specs for RVML

Contains approved parts from rusty-parts as well as modifications to make it compatible with main branch
-Added new directory inside the qmd folder to store templates
-Organized raw and processed data inside the rvml folder
-Made minor modifications to rvml-parsing.R to allow for processing without the creation of en and fr directories

Parts qmd is found in rvml/content/en

@DougManuel Can I merge this into master?

Do we need/want the .Rproj file?

I would keep only so the folder can be opened and edited in RStudio.


Calico Node pods stuck in boot loop after hostname change.

Summary

Microk8s is installed on a machine running a single-node cluster.
To prepare for the following week, the hostname of the device was updated (from zaphire-iot to zaphire-local).
A couple days later, on Friday (27.10.2023) at about 11PM, the cluster seems to have had some issue causing all pods to be restarted.
Attempting to restart the pods in the cluster caused everything to lock up, seemingly because  a new calico pod is started with the updated hostname, but detects an old pod with a different name still existing and therefore instantly shuts down.
Logs:
2023-10-31 14:17:51.442 [INFO][10] startup/startup.go 390: Early log level set to info
2023-10-31 14:17:51.442 [INFO][10] startup/startup.go 406: Using NODENAME environment for node name zaphire-local
2023-10-31 14:17:51.442 [INFO][10] startup/startup.go 418: Determined node name: zaphire-local
2023-10-31 14:17:51.442 [INFO][10] startup/startup.go 103: Starting node zaphire-local with version v3.19.1
2023-10-31 14:17:51.446 [INFO][10] startup/startup.go 450: Checking datastore connection
2023-10-31 14:17:51.472 [INFO][10] startup/startup.go 474: Datastore connection verified
2023-10-31 14:17:51.473 [INFO][10] startup/startup.go 113: Datastore is ready
2023-10-31 14:17:51.520 [INFO][10] startup/startup.go 515: Initialize BGP data
2023-10-31 14:17:51.522 [INFO][10] startup/startup.go 774: Using autodetected IPv4 address on interface br0: <IP_ADDRESS>/24
2023-10-31 14:17:51.522 [INFO][10] startup/startup.go 591: Node IPv4 changed, will check for conflicts
2023-10-31 14:17:51.536 [WARNING][10] startup/startup.go 1135: Calico node 'zaphire-iot' is already using the IPv4 address <IP_ADDRESS>.
2023-10-31 14:17:51.536 [INFO][10] startup/startup.go 354: Clearing out-of-date IPv4 address from this node IP="<IP_ADDRESS>/24"
2023-10-31 14:17:51.574 [WARNING][10] startup/startup.go 1347: Terminating

Steps to reproduce

Install microk8s on a device.
Change the hostname of the device.
Kill the calico pod

A host restart may be required for step 3 to have an effect, and would probably cause this issue by itself since restarting the host seems to cause microk8s to restart all pods on said host.
What Should Happen Instead?
A change of the devices hostname should preferably have no effect on the ability of the cluster to restart pods.
Introspection Report

inspection-report-20231031_140914.tar.gz

Hey @Jabbl ,
Generally changing the hostname of a running node is not recommended. Please check #3753 to see if any of the recommendations there help with the issue.

Understood.
I've decided to completely reinstall microk8s since the effort to try and restore it ended up not being worth it.
Will try to avoid doing this in the future.


Bad SEO

Hello,
The problem is SEO. There is missing description in Google but in Bing there is. When I browse your code I see:
<meta data-n-head="ssr" data-hid="description" name="description" content="Simple. Fast. Reliable. Content delivery at its finest. cdnjs is a free and open-source CDN service trusted by over 10% of websites, powered by Cloudflare. We make it faster and easier to load library files on your websites.">

So I don’t know where is the problem.

Google is showing a description for me, but I'll request a re-index :)


start collector supervised in each test case

having one collector run for the whole suite allows a race condition, instead, start and stop NewRelixir.Collector with each test

fixes https://github.com/TheRealReal/new-relixir/issues/38


Support for 13G OSD configs on 13.0

I managed to deploy with 13g storage nodes set with CephPoolDefaultSize = 1
Can we calculate the settings to apply based on the number of OSD's available dynamically as part of those changes @alp317 ?


linuxPackages.rtl8821ce: unstable-2021-05-28 -> unstable-2021-11-19

Motivation for this change
This fixes https://github.com/tomaspinho/rtl8821ce/issues/244, making compilation succeed on kernel 5.15+. I use this driver on my laptop, so I've added myself as a maintainer as well.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

This should be ready now :)

/marvin opt-in
/status needs_reviewer


Final drawing OCR

As a User,
When I click "Done",
Then draw Kanji is evaluated using an OCR.

For the prototyoe use ETLCDB dataset


Usage of 'immutable' for keccak variables

Use of Immutable will be more worthy here rather than constant, cuz constant results in extra hashing thus increasing gas costs..
Better explained here
Thanks @PowVT

Hi @Aryan9592 thanks for looking at the protocol and providing you input. There are a couple of comments I have about this PR and why I have closed it.
In adherence to best practices, when utilizing immutable values, it is recommended to initialize the variable in the constructor, as outlined in the docs The modification you submitted does not align with this established pattern.
Furthermore, passing hashed values through the constructor can impact the readability of the contract and hinder the ability to verify these inputs post-deployment. In the current implementation, recreating the hash off-chain, as demonstrated in our test suite, is straightforward.
Considering the marginal 10 gas savings, it appears inconsequential to forgo this change, especially when it has a tangible effect on the readability of the contract.

@PowVT Makes sense...Thanks for the valuable time you put in to lay down the reasons for closing this PR!


Please change the version name from 1.19 to 1.19.2.(modrinth)

It helps when using ferium (mods auto-updater)

hopefully done


Add simple character to node dialog

The SimpleCharacter should be available in the node creation dialog box!

Instantiating it as a scene worked fine for me yesterday. But if you want to add it as a node, is OK with me. Just make sure to do the same to SimpleScoring for consistency.

The SimpleScoring is already available in the picker, and I'd just rather the learner not have to go into the source code of the plugin if they don't have to.

Oh and remainder to add the details in the commit message, not in the PR. We do that so the info remains in the git history, not just in github.

And yes! I'll do that. I just thought it was pretty self explanatory :)

Oh so this is removing simple character from a list of filtered nodes. Merging then.


Add an option to the deployment script so a bundle can use an already-existing SecretRegistry

(to be drafted)

This depends on #967.

deploy raiden will get new command line options that specify the existing SecretRegistry.  There are different ways for doing this.

An address, a deployed-on block number, etc
The path of a deployment file

And then, the script

compiles SecretRegistry and compares the result with the deployment file
checks the contents of the deployment file against what's onchain
and writes about the existing instance in the new deployment file

The new option will look like --secret-registry-from-deployment-file ../data_0.12.0/deployment-goerli.json


[CP] merge into [beta] channel: Create a CL to disable dartdev in 2.9

commit(s) to merge: f6a82443e4
link to issue: https://github.com/dart-lang/sdk/issues/42748
merge instructions: clean merge
what's the problem:
dartdev has some open issues which are being addressed in https://dart-review.googlesource.com/c/sdk/+/154706
https://github.com/dart-lang/sdk/issues/42630
https://github.com/dart-lang/sdk/issues/42092
https://github.com/dart-lang/sdk/issues/42664
https://github.com/dart-lang/sdk/issues/41978
why cherry-pick:
Cherry picking this change would ensure that we don't release the dartdev feature in a state that can cause annoying problems to the users.
/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow

lgtm per discussion today
@pcsosinski @franklinyow - are we set on this and/or do we need @whesse do to anything besides merge this in?

lgtm

Cherry-picked to 2.9.0-21.10.beta.


Added the abstraction

Added my website theabstraction.co

Thanks for the PR! We've simplified the process of adding your site/repo to the list. Instead of updating SITES.md you would add the utterances topic to your repo.


Release 2022.12.04 does not show up in PCB editor, but release 2022.12.02 does work

I tried the release 2022.12.04 on two Linux machine (Debian KDE and manjaro i3), and on windows 11.
In all platform, after installing (I tried via the gui and with putting the files manually in the plugin folder), after closing and restarting kicad, the jlcpcb button does not appear in the tool bar in the pcb editor.
It does not appear in Tools > external plugins either.
I installed the previous release, 2022.12.02, and it works fine.

Same for version 2022.12.03 and cloning directlry from git, windows 11 and KiCad 6.0.9... I can confirm latest working version is 2022.12.02

Can you check settings -> action plugins -> ⚠ button. It might show what's the cause

I tested 2022.12.04 (via Plugin Repo) on KiCad 6.0.9 on Linux.
  File "/usr/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/florian0/.local/share/kicad/6.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/__init__.py", line 4, in <module>
    from .plugin import JLCPCBPlugin
  File "/home/florian0/.local/share/kicad/6.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/plugin.py", line 5, in <module>
    from .mainwindow import JLCPCBTools
  File "/home/florian0/.local/share/kicad/6.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/mainwindow.py", line 18, in <module>
    from .fabrication import Fabrication
  File "/home/florian0/.local/share/kicad/6.0/3rdparty/plugins/com_github_bouni_kicad-jlcpcb-tools/fabrication.py", line 9, in <module>
    from pcbnew import (
ImportError: cannot import name 'DRILL_MARKS_NO_DRILL_SHAPE' from 'pcbnew' (/usr/lib/python3.10/site-packages/pcbnew.py)

Looks like DRILL_MARKS_NO_DRILL_SHAPE is only available in Kicad nightly right now. That's why its not working.

Ok I know what causes the problem but I can't fix it before Tuesday 🫤

Ok I know what causes the problem but I can't fix it before Tuesday 🫤 As a quick fix for 6.0 users you can comment this line
https://github.com/Bouni/kicad-jlcpcb-tools/blob/main/fabrication.py#L10

This worked for me, cheers.

I hope that #257 will fix this, had no chance to test it on a 6.0 installation 😅

Yep, it worked for me! Thanks for your efforts! :)


refactor: Clean up code duplication in ReactiveComponentBase classes

There are three classes affected:

ReactiveComponentBase
ReactiveInjectableComponentBase
ReactiveLayoutComponentBase

The goal is to reduce code duplication between these three classes, as well as eliminating any behavioral differences that may not have been intentional. With that in mind, the changes in each class is outlined below.
ReactiveComponentBase
This class is now the base class for others. Logically it hasn't changed much. A few methods were made virtual in order for them to be overridden in derived classes. Its main purpose now is to house shared logic that was previously duplicated between the other two classes.
Its implementation of OnAfterRender() was modified to use the more succinct implementation from ReactiveLayoutComponentBase.
ReactiveInjectableComponentBase
Nearly 100% gutted. It now derives from ReactiveComponentBase and only overrides ViewModel in order to specify the [Inject] attribute.
ReactiveLayoutComponentBase
I'll be completely honest, I have no idea what the purpose of this class is. I made many efforts to understand:

git log to read the history of the file to make out its purpose.
Read certain pull requests on github that involve changes to this file.
Ask various individuals on Slack
Carefully reading the code and comparing it to the implementation of ReactiveComponentBase.

Despite these efforts, I failed to find any meaningful differences. Semantically the only difference I found was that it did not use a CompositeDisposable to be rid of its connections to the ViewModel on its destruction, but I assume this doesn't matter since it can safely assume ownership of the ViewModel.
Based on this, I have marked the class [Obsolete] to discourage users from using it and migrate them to ReactiveComponentBase. It has been kept as an empty class that implements ReactiveComponentBase only for backward compatibility.

I apologize for ignoring the PR template. I had already typed up a large description of my change in my git commit and I didn't want to take the time to break it up to fit the template.

@glennawatson Would love your feedback!
I was not able to compile or test my changes here because of this error:

Workarounds.targets(27, 5): If you are building projects that require targets from full MSBuild or MSBuildFrameworkToolsPath, you need to use desktop msbuild ('msbuild.exe') instead of 'dotnet build' or 'dotnet msbuild'

I'm not sure how to address that. I am using Jetbrains Rider as my IDE.
I also had to modify the list of target frameworks in ReactiveUI.csproj because of errors finding .NET 6.0 for Android and the like. I made this change locally and did not add it to this PR:
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>

Lastly, I had to unload all projects in the solution except for ReactiveUI and ReactiveUI.Blazor. There were just too many errors in the other projects, but I didn't need to build them anyway as I'm only concerned with Blazor.

I'm aware of the build failures. I am not going to worry about addressing those until I get feedback on the overall design / approach (in order to avoid wasted effort on my part).

@rcdailey I will take a look at this this evening

@rcdailey Thanks for this PR, I can see what you are trying to achieve however having the separate functionality to extend the base classes of ComponentBase and LayoutComponentBase allows us to add functionality that is specific to those bases, as time goes by the base functionality tends to differ extensively meaning we need to have differing code to match.
On this occasion this is not the direction we wish to go.
Thank you very much for your efforts.

@rcdailey This is one case where probably having a common base class is not the direction we want, mainly due to performance. If you want to fix the two components of the bugs you were encountering that's fine, this is one scenario where code duplication is fine.
LayoutComponentBase is also not obsolete, still used for making layout components.

Thanks for the feedback. I do have some concerns / questions:

What is the actual purpose of LayoutComponentBase? The documentation does not make this clear, and the implementation makes it even more confusing as I do not see a meaningful distinction. Can someone explain the differences?
I understand that having the separate classes allows adding separate functionality, however the current situation is that there is no meaningful difference between them. Am I wrong on that? If I'm not, then wouldn't it be fair to say that when such a need arises, you can then duplicate code as needed based on those requirements?

Here's the issue I see. These classes contain code duplication that incurs significant maintainability overhead. That overhead does not seem fully justified here just based on the percentage of similarity. I didn't run any real numbers but it certainly seems like 90% duplication which is significant.
This also impacts future contributions. The reason why I'm even doing this is because I do not want to implement the same fix 3 different times. That's certainly discouraging and again goes back to the maintainability overhead I mentioned earlier.
I apologize for seeming argumentative. At the end of the day, you guys are calling the shots. I'm just sharing my perspective. My understanding of the objections is that you just don't want this, however I haven't heard any logical reasons. If you're not interested in further explanation that's fine too. I was hoping for more of an open discussion with some more technical deep dive into the PR itself and why what I'm doing isn't suitable.
If you can offer me that, I'd appreciate it.

The big issue I have is just for a library like RxUI, adding additional inheritance adds potential performance hits. It can be minor except for a scaled-up Blazor app that was relying on performance and suddenly having an additional layer of inheritance.
Layout Component bases have some documentation here https://blazor-university.com/layouts/nested-layouts/
One potential way we can avoid duplication is by using T4-based library scripts, which we've done elsewhere. This is a compile-time feature and avoids the inheritance hit.

@glennawatson For my own educational benefit, what are the specific performance concerns you have with an additional layer of inheritance?


can u make all links in events open in a new tab

What's your idea?
[10:54 AM] jasonw: can u make all links in events open in a new tab pls thx
[10:55 AM] EthanThatOneKid: Good idea
[10:56 AM] EthanThatOneKid: Which links were you talking about
[10:56 AM] jasonw: all of them
[10:56 AM] jasonw: clicking anything on that page should never make me leave

I was thinking that it may be possible to use JSDOM to parse the HTML from Google Calendar, giving us the ability to forcefully assert target="_blank" for all instances of  tag.
See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#external_links_and_linking_to_non-html_resources.

[3:47 PM] diamond (they/them): have you tried: 🌈 regex 🌈
[6:17 PM] Ethan (he/him/Webmaster): Is there a magic pattern for this replacement? Problem I had in mind is that the input html is might not be predictable enough. It is probably possible in regex tho ty for the suggestion I’ll look more into it this weekend
[6:26 PM] diamond (they/them): I can whip something up; it's not like we gotta deal with mega complex HTML
[2:20 AM] diamond (they/them): https://go.dev/play/p/_wxztmECmEQ

@diamondburned suggested via Discord that we instead try to use regular expressions to prevent over-complicating this process using JSDOM. I initially chose JSDOM to get rid of any doubt in case there are any cases where regular expressions would not be able to replace each link properly, but the regular expression that @diamondburned produced passes several important test cases that we need. So, the regular expression might be the best way to go!

[5:14 PM] Ethan (he/him/Webmaster): Diamond’s Go code:
package main

import (
    "fmt"
    "regexp"
    "strings"
)

func main() {
    var re = regexp.MustCompile(`(?m)<a.*href=".*">`)
    var str = `

asdasda
`

    str = re.ReplaceAllStringFunc(str, func(match string) string {
        if !strings.Contains(match, `target="`) {
            match = strings.TrimSuffix(match, ">") + ` target="_blank">`
        }
        return match
    })

    fmt.Println(str)
}

[6:07 PM] Ethan (he/him/Webmaster): Rewritten in TypeScript:
function assertHtmlHasAllExternalLinks(html: string): string {
    return html.replaceAll(//gm, (match: string): string => {
        if (match.includes("target=\"_blank\"")) return match;
        return match.replace(/target="_.*"/g, "").slice(0, match.length - 1) + " target=\"_blank\">";
    });
}

console.log(assertHtmlHasAllExternalLinks(`

asdasda
`));

[6:07 PM] Ethan (he/him/Webmaster): ^ Untested written in discord on mobile
[4:47 PM] Joel Anil John (he/him): Wait so what is the purpose of the code?
[5:55 PM] Joel Anil John (he/him): Also, would event-item.svelte be the ideal place to implement this function?
[7:54 PM] Ethan (he/him/Webmaster): Sorry for not replying sooner, but the purpose of the code is to make sure that all of the links in the google calendar description are external links. We can pass the html from the google calendar description through this function and it will make sure any occurrences of a link will be external as expected
[7:56 PM] Ethan (he/him/Webmaster): We would do this text transformation on the backend before it hits the client malformed, likely within the makeAcmEvent function
[9:10 PM] Joel Anil John (he/him): ahh gotcha
[9:10 PM] Joel Anil John (he/him): so we're not gonna need JSDOM then?
[9:40 PM] Ethan (he/him/Webmaster): Yes, the regex solution is a replacement for the jsdom idea. Should be much more efficient and will take up 0 dependencies.
[9:40 PM] Ethan (he/him/Webmaster): I should write up another comment on GitHub to reflect this

Above is a conversation from Discord about our current plan to fix this issue. In our fix, we can add a test for the assertHtmlHasAllExternalLinks utility function in /src/lib/ical/utils.test.ts with our input being the sample text used in the above example code.

hey wait a minute, i know we spent all this time writing the actual function but like, did we ever bother to call it in events cus the board applications dont open in a new tab LOL


test date input for time slider and adjust input element

This is related to https://github.com/VEuPathDB/web-monorepo/issues/775. Tested controlled Brush by adding date input fields and it works fine: date picker is also added. In addition, considering the size of time slider, especially low height, a new prop, inputHeight, is added to adjust the height of the input element.
These are tested with storybook and video capture is made in the following. If this is alright then it will be applied to SAM.
https://github.com/VEuPathDB/web-monorepo/assets/12802305/4eced702-9620-4d2d-806c-2dea31dcdf6c

@bobular applied to SAM and adjusted layout. It seems to work fine for me. Here are screenshots:

@bobular step buttons are added. Tested with storybook and SAM. Some notes are:

currently it is set to be 1 year as a step
right arrow increases range.end and left arrow decreases range.start
considered data min/max not to go over
also added a function parameter to change number of years for step
mouseover tooltip for each arrow is added

screenshots are:

enabled

disabled

@bobular Thank you for your reviews and comments. Yes some features are not implemented at storybook as there are some diff between storybook and actual one at SAM.
I will change the behavior of arrows next week as you suggested: I was also thinking of "window" :) As for the 4th item, I didn't notice a specific drift when playing with those buttons. Will see/test more when addressing your feedbacks.
One thing I am concerned is that for the example case I used (screenshots), the data range is over 100 years so the step of 1 year may be too small in such a case. Perhaps we can consider a sort of a dynamic step, e.g., data range/10? This may make user a confusion, though. On the other hand, 1 year may be okay as we also have date input/picker.

Hi @moontrip - is there a mock-up that says the step will be one year? I suggest it should be whatever the size of the selection is.
Thus after one click on :arrow_right: the window would move like this:
   [-------]
            [-------]

@bobular Aha I see. Thank you for your clarification. 👍

@bobular I addressed your feedbacks and committed them. Here is a short video capture, just in case: you can test it at your local more extensively :)
https://github.com/VEuPathDB/web-monorepo/assets/12802305/47a6d2c2-c441-42c1-9b5a-8ef924a4deb7

@bobular You might have missed this review as you were hectic to deal with others. Can you please take a look at this when you are available?

This works really nicely and the EDA/MapVEu code looks good :-)
If possible please could you

look into why the left/right arrows only get disabled after a "failed click" - is it possible to pre-empt this?
When setting a year-based range (e.g. 2005-01-01 to 2006-01-01) would it be possible to handle leap-years so that the ranges always stay on Jan 1st? Even if the code is a bit ugly I think this would be worthwhile.

@bobular Thank you for your reviews and suggestions 👍 Those suggestions seem to be quite tricky but I will see if I can address them 🤞

@bobular Your suggestions are addressed in some ways. For the first one, overall logic was changed to handle enabled/disabled, so it is now pre-emptive. For the second one that considers leap year, there are several edge cases to deal with, I suppose. Thus, what I did is to have a toggle button to move the range by year difference (please see a screenshot below) by ignoring month/date. For example when the toggle is on, a) 2007-01-01 to 2008-01-01 -> 2008-01-01 to 2009-01-01 (year 2008 is leap year so this becomes to 2008-12-31 if the toggle is off); b) 2007-01-01 to 2007-12-31 -> 2008-01-01 to 2008-12-31 (year difference is set to be 1 year at minimum)
perhaps the toggle label needs to be changed like Year range at least which needs some space arrangement for layout. I didn't do that yet because I want to see if this approach is alright.
By the way, vectorbase backend does not respond with map data but at least timeslider can be used for testing. It would be great if you can test it and share your thoughts.

Hi @moontrip - as I mentioned in Slack, I'm not too keen on the year-based-movement-toggle. One of the reasons is that we don't offer month- or week-based movement also (which I guess we could, but it would complicate the UI and implementation more than necessary IMO).
I had an idea while walking the dogs... It solves the issue of cleanly stepping through the years if the user has chosen Jan 1 as start and end dates, without an extra toggle switch, and without explicitly checking to see if the user entered the same day-of-the-year as start and end dates.
Firstly we need a countLeapDays in date range function.  Here's one that ChatGPT provided. It looks solid, but of course double-check.
function isLeapYear(year) {
    return (year % 4 === 0 && year % 100 !== 0) || (year % 400 === 0);
}

function countLeapDays(startDate, endDate) {
    const startYear = startDate.getFullYear();
    const endYear = endDate.getFullYear();
    let leapDayCount = 0;

    for (let year = startYear; year <= endYear; year++) {
        if (isLeapYear(year)) {
            const leapDay = new Date(year, 1, 29);
            if (leapDay >= startDate && leapDay <= endDate) {
                leapDayCount++;
            }
        }
    }

    return leapDayCount;
}

Then the main idea is to count the number of leap days in the current and next ranges and calculate the difference
  const deltaLeapDays = countLeapDays(newSelectedRange) - countLeapDays(selectedRange);

Then adjust the newSelectedRange.end by the number of days deficit/surplus.
Example:
Current range contains 2 leap days and has length 500 days. Next range contains 1 leap day. deltaLeapDays works out as -1. The next window length needs to be adjusted to have a length of 499, achieved by subtracting one day from the end date.
There's an edge case where the current range is, for example, 2024-02-29 to 2024-02-29 (just one leap day). The new range would end up zero width, so we have to make sure the range is at least one day wide!
What do you reckon?

@bobular Thank you for your suggestion. The logic looks reasonable so I will test it. Though the function is incorrect in part as the Date is not considered correctly :)

@bobular Ok it seems to work fine with your logic 👍 Here is a quick video capture: year 2008 is leap year
https://github.com/user-attachments/assets/b5157672-408b-4f5d-9b17-2ec1036db01d

@bobular Thank you for your comments and suggestions. I will see if I can address those warnings: it is not always true to believe as it may sometimes cause issues (infinite loops for example).
By the way I am confused that the useEffect to deal with enabling/disabling arrows and those useState setter functions (setDisableLeftArrow and setDisableRightArrow) are all defined at TimeSliderQuickFilter where the arrow UI exists, not TimeSlider component? Did I miss or misunderstand something?

Also, if required hook dependencies cause infinite loops that means the design should be revisited, in my opinion.

@bobular Thank you for your comments. I will check them out more carefully. 👍

@bobular I simplified codes which were originated from old logic. It would be great if you can check it out again. Thanks!


fix typo

Hi @StalkAlex,
thanks for pointing to this mistake.
But there was more than one file to change. I have pushed a commit that fixes typos to master branch.
Btw, if you would click on namespace and press Shift + F6 in PHPStorm, you would rename namespace and all usages.
I would close this PR.
With best regards,
Dmitry

Ok, not problem. Thanks for the hints!


Build a plugin that has a dependency on code published in Maven/Cocoapods

Both Android and iOS have existing ecosystems for distributing code. For example, Google Analytics for Android is on Maven (com.google.android.gms:play-services-analytics:10.0.1), and for iOS on Cocoapods (e.g. Google/Analytics).
This tracks the ability to declare a dependency on such existing code in a plugin, and the build logic related to handling both the building of the plugin, and an app that consumes it.

Should work as of #8891, but needs testing.

Closing, this was verified by the new google_sign_in work: https://github.com/flutter/flutter/issues/7816#issuecomment-289930437


Better documentation around array (nested object) reactivity

What problem does this feature solve?
A common occurrence within vue is getting a fresh array hot off the api.  I then replace an existing array with the fresh array.
data: {
   items: []
},
methods: {
    refresh: function () {
        var newArray = apiCall();
        this.items = newArray; // could use this.$set() as well
    }
}

My question is, what are the reactivity implications of replacing an array (or deep object) in vue?  Will this.items remain reactive?  Will this.items be diff'd and take advantage of performance optimizations?  Are the answers to these questions yes only if setters are used?  Does this object swap wipe out any watchers?
Can anyone clarify the expected outcome/offer guidance how to approach this common problem in the best way?
What does the proposed API look like?
Re-observation of deeply nested objects

setting the new array like you're doing is fine, I think it's actually in the docs.
Closing as this is a question and you know the rules 😉


Label property is ignored in list/cred/edit views

Create entity
nga.entity("items").label("DVDs")

Open list/create/edit pages, check header:

Items list
Create new item
Edit item

Expected:

DVDs list
Create new DVD
Edit DVD

True, that's a bug

OK, this just caught me. :+1:


Apply HostPointer and HostPointerMut

What this PR does

Introduce HostPoinerMut which are used to access "mutable physical host region".
HostPointer is used for

Params for REALM_CREATE
Params for REC_CREATE
Source data page for DATA_CREATE

HostPointerMut is used for

Run  (it needs to be mutable to handle RSI. e.g., HOST_CALL handler modifies Run)

Note

Rec/Rd/Data(target_data)/... --> those that involve granule states should be handled in a different way than HostPointer. I'll do update codes to manage those struct in a separate PR that might have to do with #113 .

Related issue: #107

TO-DO

#112
#113    --> this issue is likely the next to go
#114

NOTICE:  I will change this PR a lot (eliminate host_pointer_mut part) and do this in a different way in #113.

NOTICE:  this pr has become ready for review. And I modified the PR description. Please check out the description.

Minor comments. I agree overall.

All reflected:
let params = host_pointer_or_ret!(Params, arg[2], mm)?; --> looks really nice, I left a todo comment to do it next time (maybe with Result as a return value)


(roadmap || priority) to include slider

Thank you for the great work!!
I was just wondering where including the slider was on the roadmap or list of priorities? (Bonus: with tap on slider to go full screen.) This would make a big difference to me.

Added

Material Box
Material Box with captions
Slider
Fullscreen Slider
to #1

You are welcome to contribute ;)


Service does not restart with nftables

Suggestion/Question.... Shouldn't there be a dependency to restart after a nftables service restart? TY

Or a service reload that doesn't purge old records (Because they were already purged on nftables reload/restart. It just re-updates the DNS records.

I suppose I need to add into the service:

Requires=nftables.service

https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html#Requires=


[elasticsearch] New Feature - Adding plugin support through values file

[x] Chart version not bumped (the versions are all bumped and released at the same time)
[x] README.md updated with any new values or changes
[x] Updated template tests in ${CHART}/tests/*.py
[x] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

I've seen a couple of issues (https://github.com/elastic/helm-charts/issues/1035, https://github.com/elastic/helm-charts/issues/869) created around wanting to support adding plugin support through the values file.  I had to figure this out myself, and so I thought I would submit this change back for review as a new feature.
I totally understand the recommendation of using a custom container image with your plugins baked in: more immutability, no dependency on startup to fetch plugins, etc., but sometimes using a custom image is not an issue because you don't have a private image repository for your use.

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Hi @grantholly, thanks for this PR, we may revisit it one day but for now, we still prefer not adding this feature in the charts for the known reliability reasons.
Maybe you can deploy the registry as a pod in your K8S cluster for these kind of use cases.


tinygo: 0.13.1 -> 0.16.0

And enable microcontroller targets. Works for me for microbit.

Motivation for this change
The microbit target didn't work
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build tinygo


CI fails for working_with_datasets tutorial

Steps to reproduce the problem
The working_with_datasets tutorial  fails in CI on #652 due to some ray commands not being handled well.
What is the current behavior?
The tutorial above can be run in a container locally, but it fails in CI. More investigation needed.
What is the expected behavior?
Tutorial should run in CI, as it does locally

The working with datasets tutorial was deleted in #980


unit tests for UDS components

Chip  -> Check for disabled = false
Try to add snapshots.
DropDown -> Make tempData keys more readable.


[AIRFLOW-2435] Change ecs_operator.py to be able to pass launch_type

Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2435
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
Added launch_type to ECSOperator. Default value remains EC2

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:
If someone can point me in the right direction for this, gladly.

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[ ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Could you also extend the tests?
======================================================================
18) FAIL: test_execute_with_failures (tests.contrib.operators.test_ecs_operator.TestECSOperator)
----------------------------------------------------------------------
   Traceback (most recent call last):
    tests/contrib/operators/test_ecs_operator.py line 124 in test_execute_with_failures
      taskDefinition='t'
    .tox/py27-backend_sqlite/lib/python2.7/site-packages/mock/mock.py line 948 in assert_called_once_with
      return self.assert_called_with(*args, **kwargs)
    .tox/py27-backend_sqlite/lib/python2.7/site-packages/mock/mock.py line 937 in assert_called_with
      six.raise_from(AssertionError(_error_message(cause)), cause)
    .tox/py27-backend_sqlite/lib/python2.7/site-packages/six.py line 737 in raise_from
      raise value
   AssertionError: Expected call: run_task(cluster='c', overrides={}, startedBy=<ANY>, taskDefinition='t')
   Actual call: run_task(cluster='c', launchType='EC2', overrides={}, startedBy='airflow', taskDefinition='t')
======================================================================
19) FAIL: test_execute_without_failures (tests.contrib.operators.test_ecs_operator.TestECSOperator)
----------------------------------------------------------------------
   Traceback (most recent call last):
    .tox/py27-backend_sqlite/lib/python2.7/site-packages/mock/mock.py line 1305 in patched
      return func(*args, **keywargs)
    tests/contrib/operators/test_ecs_operator.py line 102 in test_execute_without_failures
      taskDefinition='t'
    .tox/py27-backend_sqlite/lib/python2.7/site-packages/mock/mock.py line 948 in assert_called_once_with
      return self.assert_called_with(*args, **kwargs)
    .tox/py27-backend_sqlite/lib/python2.7/site-packages/mock/mock.py line 937 in assert_called_with
      six.raise_from(AssertionError(_error_message(cause)), cause)
    .tox/py27-backend_sqlite/lib/python2.7/site-packages/six.py line 737 in raise_from
      raise value
   AssertionError: Expected call: run_task(cluster='c', overrides={}, startedBy=<ANY>, taskDefinition='t')
   Actual call: run_task(cluster='c', launchType='EC2', overrides={}, startedBy='airflow', taskDefinition='t')

@ThomasVdBerge
Add launchType='EC2' to https://github.com/apache/incubator-airflow/blob/7ca45b252bbeeb2de223a835b8fa8b6b6200423c/tests/contrib/operators/test_ecs_operator.py#L120
i.e.
client_mock.run_task.assert_called_once_with(
            cluster='c',
            launchType='EC2',
            overrides={},
            startedBy=mock.ANY,  # Can by 'airflow' or 'Airflow'
            taskDefinition='t'
        )

Do the same here https://github.com/apache/incubator-airflow/blob/7ca45b252bbeeb2de223a835b8fa8b6b6200423c/tests/contrib/operators/test_ecs_operator.py#L98

Can you please squash commits to just have a single commit?

Codecov Report

Merging #3329 into master will increase coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3329      +/-   ##
==========================================
+ Coverage   75.89%   76.41%   +0.52%
==========================================
  Files         197      203       +6
  Lines       14729    14993     +264
==========================================
+ Hits        11178    11457     +279
+ Misses       3551     3536      -15

Impacted Files
Coverage Δ

...irflow/example_dags/example_kubernetes_operator.py
72.72% <0%> (-27.28%)
:arrow_down:

airflow/settings.py
80.5% <0%> (-1.9%)
:arrow_down:

airflow/utils/db.py
34.14% <0%> (-0.28%)
:arrow_down:

airflow/bin/cli.py
63.9% <0%> (-0.13%)
:arrow_down:

airflow/jobs.py
82.8% <0%> (-0.04%)
:arrow_down:

airflow/utils/module_loading.py
100% <0%> (ø)
:arrow_up:

airflow/utils/configuration.py
100% <0%> (ø)
:arrow_up:

airflow/logging_config.py
100% <0%> (ø)
:arrow_up:

...rflow/api/common/experimental/get_dag_run_state.py
100% <0%> (ø)

airflow/lineage/backend/__init__.py
66.66% <0%> (ø)

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281a081...056f937. Read the comment docs.

LGTM. Thank you for your contribution. 👍


TypeError: cm.getHelpers is not a function, foldcode.js.

When the foldCode function is called it is giving me this error in the console:
Uncaught TypeError: cm.getHelpers is not a function            foldcode.js  :  line 121
When starting up the comment-fold.js file I also get this error in the console:
Uncaught TypeError: CodeMirror.registerGlobalHelper is not a function        comment-fold.js  :  line 14

Could it be that you are using an old version of CodeMirror with addons from a more recent distribution? CodeMirror.registerGlobalHelper definitely exists in current versions.


Dedicated nginx configuration file

I moved the nginx configuration part into a dedicated file to make the configuration editing simple. The nginx.conf file already includes the directives previously set from the Dockerfile.
I find this approach of configuration more clean and useful instead of manipulating the config with sed commands.

Is this different from doing:
FROM jwilder/nginx-proxy
COPY nginx.conf /etc/nginx/nginx.conf

The solution you mentioned works just fine, but IMO could be very error-prone for inexperienced users as it actually replaces the already-configured nginx.conf with a custom config (which might not contain the necessary directives for the reverse proxy setup).

I think the idea was to track the upstream nginx.conf, so as the nginx team updates it, we immediately get those changes (for better or for worse).  It should be relatively safe to track the upstream config since we pin the nginx version in the Dockerfile, but I could certainly see the upside to having a static config in the repo.  I just added an option to the default config in my PR #589 and it was a big precarious using sed.


Update OpenCensus version for all README files

Coverage remained the same at 81.309% when pulling 525e8435c46e126d37d743de34a8ab7556b279bf on songy23:update-doc into f502b667483174b4b93df9233099f89b79dddc1b on census-instrumentation:master.

Codecov Report

Merging #849 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #849   +/-   ##
=========================================
  Coverage     79.36%   79.36%
  Complexity      910      910
=========================================
  Files           157      157
  Lines          4018     4018
  Branches        378      378
=========================================
  Hits           3189     3189
  Misses          751      751
  Partials         78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f502b66...525e843. Read the comment docs.


Update to follow standard node.js callback pattern

I really like your work but wanted it to follow the standard node.js callback(err, results) pattern.  I updated your functions to callback with that pattern.  Updated the readme as well.

Thank you for contribution. I will merge it, but I dont get it why you wanna change to npm install?

didn't mean to have you merge that.  just put that there in case you didn't merge or didn't respond so people could still npm install it.

Can you remove this change of the request?

i changed it back to the normal npm package

Thank you i didn't know about this standard!

You're welcome.  Thanks for saving me a ton of work by building this.  I do think I'll build one that talks directly to the steemd client instead of piston.rocks but this is a great start for me.

Do you think steemd websocket is more legit? I could set it by default.

I think it would mean not having to rely on another company / product to pull block information.  Every API call you do would have to change because the format to talk to steed is different than Piston.
Example :
self.getBlock = function(blockNum, allDone){
	self.sendMessage(['database_api', 'get_block', [blockNum]])
}

Maybe we can roll the calls to steemd into another module and then when creating a new Steem you can specify a "mode" or something - default to Piston but allow for steemd and then swap out the calls depending on which mode they set.

Exactly, i'm interesting about how exactly steemd.com WS work. Is there a doc?
I'm now using the steemit WS to dev in local, it's using the same standard than pistol.

Are you on Slack?

What is the url for the steemit ws?  I was using a copy of steemd on my local machine and querying it directly over ws.
I'm not on slack.  I'm not sure what I'm supposed to use for an email address to get signed in. - i'm on Skype as kaptainkrayola though if you want to chat

Here is the Steemit WS wss://steemit.com/wstmp3

I added you on Skype!


old postgres_ha_cluster_master_host stuck when trying new cluster

I am running against a new cluster group
when I run the role against a new cluster group, it is failing
[root@AnsibleServer ~]# ansible-playbook --ask-pass sds-postgres-ha.yml --flush-cache
SSH password:
PLAY [install PG/Redis HA] *********************************************************************************************************
TASK [Gathering Facts] *************************************************************************************************************
ok: [sds02.prodea-int.net]
ok: [sds01.prodea-int.net]
TASK [disable firewall] ************************************************************************************************************
ok: [sds01.prodea-int.net]
ok: [sds02.prodea-int.net]
TASK [postgres-ha : debug] *********************************************************************************************************
ok: [sds01.prodea-int.net] => {
"msg": "MASTER NODE SET TO dbs03.prodea-int.net"
}
TASK [postgres-ha : verify postgres_ha_cluster_master_host] ************************************************************************
fatal: [sds01.prodea-int.net]: FAILED! => {"changed": false, "failed": true, "msg": "CRITICAL: defined master host (dbs03.prodea-int.net) is not in host list ([u'sds01.prodea-int.net', u'sds02.prodea-int.net'])"}
fatal: [sds02.prodea-int.net]: FAILED! => {"changed": false, "failed": true, "msg": "CRITICAL: defined master host (dbs03.prodea-int.net) is not in host list ([u'sds01.prodea-int.net', u'sds02.prodea-int.net'])"}
to retry, use: --limit @/root/sds-postgres-ha.retry
PLAY RECAP *************************************************************************************************************************
sds01.prodea-int.net       : ok=3    changed=0    unreachable=0    failed=1
sds02.prodea-int.net       : ok=2    changed=0    unreachable=0    failed=1
[root@AnsibleServer ~]#

Hi @frank3427.
The error message is saying that postgres_ha_cluster_master_host is set to dbs03.prodea-int.net but you run this role over sds0[12].prodea-int.net. The postgres_ha_cluster_master_host should point to a host that is present in the ansible play (and is the master pg database).
Jan

I have two clusters

dbs
sds
each cluster has 2 hosts
I first ran against dbs, all went well, then I ran against sds. in the sds run it failed with master needing to be dbs

I ran the role against a new host_group I was expecting sds01 to be master, based on
postgres_ha_cluster_master_host: "{{ ansible_play_batch[0] }}"

Can you please share your main yml file?

sorry, i will close the issue, I found the variable hardcoded.
<EMAIL_ADDRESS>


Investigate UpdateLinkedTasksToChangeset

This method is not implemented and I haven't explored how Plastic calls this or what it is supposed to be used for. The docs do mentiond it, but still hard to get the idea without an example.
As a first test it would probably help to attach the debugger, set a breakpoint in the method and then going through a few interactions in the Plastic GUI.

At the moment, this method isn't really usable, because the Plastic UI doesn't expose the necessary widgets. Maybe in the future they will reintroduce the "extension" tab in the changeset sidebar.


More support for generic all in one nets

Do a little work to enable all-in-one nets in the generic path. See the added test for the type of network this enables.

Oops, the caffe build on TravisCI doesn't know about Input layers yet.


Can't install archon on ubuntu 14.04

i tested on ubuntu 14.04 and using google chrome version 47.0.2508.0 dev is can't installed

can you help my problem ?
i use OS 32 bit

Same problem! Linux Mint 17.1 x64
Please Help!! :-(

Same problem here...

@arifpurwanto92 try downgrade Chrome to v.38 (it helped me):
i386
amd64


drivers: sensor: Move to vendor subdirectory

Organizes sensor drivers by vendor to distribute maintainership
responsibilities.
Signed-off-by: Maureen Helm<EMAIL_ADDRESS>

very nice

Not a bad idea and I personally like it.


Early on-set info

If 30s or 40s is selected the 'early on-set' service is weighted more heavily.
links to #7

closed via #75


Unable to get next Libraries.io token from pool

Are you experiencing an issue with...
shields.io
🐞 Description
The badge renders with the error in subject rather the number of dependents
🔗 Link to the badge
https://img.shields.io/librariesio/dependents/npm/next-json?logo=npm
💡 Possible Solution
Drop Libraries.io and use npm as source of data

This is not a question, this is the report of a problem in production.
Ok, the test passes, but (I guess) just because it uses a distinc pool of tokens from production.

I'm going to close this issue as a duplicate of https://github.com/badges/shields/issues/9839 - see there for more details.
In terms of

Drop Libraries.io and use npm as source of data

The badges we serve from https://img.shields.io/librariesio/... are always going to use libraries.io as the source of data.
If you wanted to also implement a NPM dependents badge that gets data from another source, that would be a different badge badge route and a different issue. Although I am not sure NPM actually expose that data via an API.

Hi @chris48s , thank you for you kind reply


Implement Vst Version Callback

Some hosts check the VST-standard version of plugins.
This fixes MIDI Ports, which are only available in VST 2.x, for some hosts (Ardour 5.x in particular)

thanks ! I recently fixed the same thing in the debug plugin but forgot to update the VSVR plugin, too.


Updating for features enabled in CU7

Thanks.
From: James Birkinshaw<EMAIL_ADDRESS>Sent: Tuesday, August 28, 2018 1:16 PM
To: MicrosoftDocs/OfficeDocs-SkypeForBusiness<EMAIL_ADDRESS>Cc: Phillip Garding<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/OfficeDocs-SkypeForBusiness] Updating for features enabled in CU7 (#709)
Merged #709https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fpull%2F709&data=02|01|phillipg%40microsoft.com|3f33eb2f15ae4acc541c08d60d232154|72f988bf86f141af91ab2d7cd011db47|1|0|636710841867884614&sdata=23EKkJNsE6nOun5Zjd5sThJHBzgym4%2FWmBd%2Bsg9DPHI%3D&reserved=0 into live.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2FOfficeDocs-SkypeForBusiness%2Fpull%2F709%23event-1814054029&data=02|01|phillipg%40microsoft.com|3f33eb2f15ae4acc541c08d60d232154|72f988bf86f141af91ab2d7cd011db47|1|0|636710841867884614&sdata=exQyCR%2FkUrWzI00de0Fqo%2Fyp8S3lsU4tLQz3xRqeUtk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAkYGQx386zLJUzl8JdKanupKOPnV01_1ks5uVaUYgaJpZM4WQUVe&data=02|01|phillipg%40microsoft.com|3f33eb2f15ae4acc541c08d60d232154|72f988bf86f141af91ab2d7cd011db47|1|0|636710841867884614&sdata=x%2FSAMnzq8J0ZwfRVVO8YH%2B43U5O%2B19F08mXJYfEU96U%3D&reserved=0.


incomplete sentence on key vault rbac migration page

There's an incomplete sentence which reads: "Vault access policy permission model is limited to assign policy only at Key Vault resource level, which"
Besides the grammar and punctuation issues, this sentence seems to contradict another sentence nearby: "Azure RBAC for Key Vault allows roles assignment at following scopes: ..."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9fe2188c-d08d-be91-bf80-9665cac23596
Version Independent ID: e0cf82de-bdf5-97a4-f9e0-f40e8c12b064
Content: Migrate to Azure role-based access control
Content Source: articles/key-vault/general/rbac-migration.md
Service: key-vault
Sub-service: general
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

The whole page needs a review.  Lots of grammar and punctuation issues.

Thanks for calling this out. I made a pull request to fix many of these errors. https://github.com/MicrosoftDocs/azure-docs-pr/pull/163755
CC @msmbaldwin


Verify filter prefix for labels

The official docs show the example labels.color:red label.size:big. Verify that projects can be filtered by both labels and label. If not, fix the docs on gcloud-ruby and submit a doc fix to the Google Cloud docs.

I've verified that label is not supported by the filter option. Correcting the ruby docs now.
@jgeewax How do we submit an issue on the official docs to get this corrected?

There should be a button somewhere on the page.... ?

I can't find one. But there is a rating widget with stars in the upper right corner!


Flutter : Intoduction to Gestures

Description
Cover the widget GestureDetector and How to use it in our Apps.
Domain
Android Dev (Flutter)
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign

/assign

@iamayushkr have you completed the issue?


Non developer readme contribution

I have written a clear, easy-to-comprehend introduction for Pixi.js.
I believe this introduction, free of complex technical terms, will swiftly and thoroughly inform anyone about the use-cases, merit, and advantages, including the celebrated features, of Pixi.js.
Seasoned developers, new programmers, and even nontechnical visitors will benefit from the clear language, exposing Pixi.js to a broader range of users.

:+1:


wi: prefix doesn't work anymore

http://iiifpres.bdrc.io/2.1.1/collection/wi:bdr:W22084 return an error, it shouldn't

http://presentation.bdrc.io/2.1.1/collection/i:bdr:W22084 is also broken...


'pub upgrade' gives an less than helpful error message

I think the error is due to angular versions, but the result talks about collection.
See attachments.
The error output:
Package collection has no versions that match >=0.9.1 <1.0.0 derived from:

angular depends on version >=0.9.1 <1.0.0
this_package depends on version any

Attachments:
pubspec.yaml (100 Bytes)
pub_update_solver.txt (6.97 KB)

This issue has been moved to dart-lang/pub#959.


proper support for svelte files

Description
I don't see .svelte files working good, it would be great to get it working properly.
Neovim version
0.9.4
Expected behavior
See ts-context working properly in svelte files. See parent tags fixed on the top.
Actual behavior
ts-context doesn't work in svelte files. Tags are not being displayed fixed on the top.
Capture
https://github.com/nvim-treesitter/nvim-treesitter-context/assets/45423661/dc65485f-2b83-44bf-bc19-ad16f768d95d

PR's welcome. Please don't open issues for individual languages.


HDFS-16329. Fix log format for BlockManager

JIRA: HDFS-16329.
Fix log format for BlockManager.

Thanks @aajisaka for your review.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m  0s

trunk passed

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 35s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 29s

trunk passed

+1 :green_heart:
shadedclient
23m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

the patch passed

+1 :green_heart:
mvnsite
1m 27s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 31s

the patch passed

+1 :green_heart:
shadedclient
22m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
235m 13s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

339m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3670/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3670

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 51627f975527 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d5b66ce1e7ee59c370c19cd01cf1a43f88c8f7df

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3670/1/testReport/

Max. process+thread count
2998 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3670/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thank you @tomscut and @virajjasani !

Thanks @aajisaka for the merge.


Perf Test Coverage: Port Xamarin benchmarks to xunit

Port relevant benchmarks from:
https://github.com/xamarin/benchmarker/tree/master/tests to xunit and enable them for coreclr

Wrong repository