feat: vm.finalize

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (6b3db2a 2022-08-19T00:04:42.579272325Z)
What command(s) is the bug in?
forge test --gas-report
Operating System
Linux
Describe the bug
#1543 discusses 'each test being considered one tx' regarding selfdestruct.
However there's another aspect that this affects - gas reports.
Since some opcodes depend on whether the address/key is warm or cold (i.e. if it has been used in current tx), considering the test as one tx can make the gas cost estimation significantly lower (since using cold key/address are very expensive, for example warm sload would cost 0.1K units while a cold one would cost 2.1K).
I've created a gist that demonstrates that.
For full list of opcodes that are affected by this, see this link.
Solution
As suggested in #1543, maybe allow to finalize a tx from the test (maybe also allow an auto-finalizing before each call to non-test contracts).

Any progress on this?

I can see how this is useful.
just to summarize, vm.finalize should
commit the current state changes in a transaction?
what should happen with the current (in memory) state of the test at this point? Like all variables etc.?
would cheatcodes that load/unload address/slots be equivalent here?

The finalize() is needed to solve 2 issues:

As mentioned here, gas calculations depends on if a key or address is 'warm' or 'cold'. At the beginning of each tx all addresses and keys are cold, therefore finalize() should make all keys and addresses cold.
As mentioned in issue #1543, selfdestruct should take effect at the end of a tx, therefore finalize() should also clear out the code and storage of destructed addresses.

I don't think there's a need to change the state of the memory of the stack, since those don't affect external calls.
The way I see it is that usually the 'real' tx are the external calls done to the source code, and finalize() would be called in the test code. Therefore as long as the calls to those external functions in the source code act as separate tx that's all we need.
It'd also be nice if there would be an option to set the finalize function to run automatically between each call from the test-code to an external function in the source code, since that's when it's normally needed (people are just unaware of this issue currently, and are getting wrong gas calculations due to that. Enabling this auto-finalize by default would help them get more accurate result without putting too much effort). But this might be too complicated to implement so I'll understand if you'll skip this 'auto-finalize'.

I guess a yearly poke is in order. Any update on this? Not being able to inform the VM to reset access lists effectively makes almost all gas reports generated by forge useless, so I'd consider this to be a pretty important feature, or dare I say, fix.
Thanks!

We've recently added support for isolation mode (--isolate) which should address the issue. This has been enabled by default for --gas-report. See: https://github.com/foundry-rs/foundry/pull/7186
Marking this as not planned as it is was superseded by the isolation mode.


I want to use / to search text as done in vim.

I want to use / to search text as done in vim instead of the filter now being done. Changing key to "F" does not remove default keymap. Instead it maps both "/" and "F" to filter.

Sorry, this should have been documented. You can override the built-in mapping by re-mapping it to something that is neither a valid string or a function. I would suggest one of these mappings:
    ["/"] = "noop"
    ["/"] = {}

I meant to support nil as a means of removing the built-in mapping as well but that doesn't seem right now. I will fix the documentation to include this.


time_series_aggregating requires 24+ threads!

Edit: down to 16 after client refactor
Edit: down to 13

Edit: down to 0. I deleted the job!


[develop < T0103-GA] Add docstring examples

Description

Added new examples in docstrings and corresponding tests.
Changed double to single quotes in docstrings (it wasn't generating properly before in our docs).
Changed order_by argument type back to List (it was changed to Iterable by accident in the previous PR).
Added new tests from docs how-to guides.
Added kwargs in tests - @BorisTasevski once mentioned that it's nicer that we have keyword arguments in our tests so that it's clear what is being used. I agree with him, so I added it where I noticed it's missing.
Added str to delete() and remove() procedure argument type in query builder (it was only List before and called with delete({"n"}) and remove({"n"}) previously, which I think is not nice - it should have been delete(["n"]) in tests, at least).

While working on this, I also noticed the variable_expressions in the delete() procedure argument in the query builder. I like items argument name that is used in the remove() procedure more, so we can maybe change this (totally not necessary, just a suggestion). I also noticed another thing: the arguments of skip() and limit() are str and I would expect them to be int. It works with int, since it's being cast to str, but should the argument type maybe be Union[int, str]?
Pull request type

[x] Documentation content changes

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Update arguments for skip() and limit(). @katarinasupe


in some environments register_organ_donors isn't in the campaign variables

What's this PR do?
In some environments the register_organ_donors variable does not exist, so now we make sure it's in the array before pulling the value.
How should this be reviewed?
If you were seeing this error before on global campaigns, make sure this gets rid of it.
Any background context you want to provide?
@deadlybutter and @weerd were seeing this. I was unable to recreate locally but @deadlybutter wasn't seeing the error anymore with this line changed.

🚢


Setup react

In this PR, it will be implemented the following:

Install React files with Vite;
Install required packages such as @reduxjs/toolkit/ react-router-dom / react-icons/ react-redux;
Install linters;
Set the Routes structure in App file;
Create components;

Hi @RicardoEgas
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights

Boiler-plated files removed :heavy_check_mark:
Install necessary project dependencies :heavy_check_mark:
Set up Routes :heavy_check_mark:

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @mohammadnewton


OBO flow credentials improvement

Core Library
MSAL Node (@azure/msal-node)
Wrapper Library
Not Applicable
Description
If the Azure Function needs to do so much work to validate the token in this sample, shouldn't the MSAL SDK wrap that for me?
I want to take the function token and get a credential to use with the Azure SDKs. Why doesn't the sample use the Azure SDKs instead of an REST API?
Source
Internal (Microsoft)

Tagging this with node validation library, cc @jo-arroyo.

Closing, as this will be handled in teh new Token Validation library, let us know if there are still questions.


unable to access fields in temporary record

Already posted as pyorient issue, but it belongs probably here:
Using  pyorient_native 1.2.3 and pyorient 1.5.5 when result of query is not  actual record in database, but temporary record, fields in this record  can not be accesses by dotted syntax. For example:
res = client.query(SELECT *, @Rid, in('EQOSChild').@Rid AS parentrid ...
print(res[0].rid, res[0].parentrid)
when using native driver output is:
('OrientRecordLink', 42, 1) ('OrientRecordLink', 35, 0)
when using csv driver output is:
#42:1 #35:0

mogui/pyorient#260

This is related to #2. This is fixed in the develop branch of pyorient (specifically the commits mogui/pyorient@10db8b754a9434e9a1519b8112f833153fd37cd0 through mogui/pyorient@6e68b280fac117c8be9b752b01ae638f5001afdd )and will be part of the next pyorient release. If you need it before then, please patch your pyorient installation with the above commits.
Closing for now, feel free to reopen if the above does not solve the issue.


Prevent NullPointerException when app closes and activity is null.

This catches an instance where the activity has been destroyed but there is still a method call heading out.

Hi. Thanks for this. How can I test it?

In our case, we could close the Ti app. But we might also have a method that was calling setTitle(). For whatever reason, the race condition would end up that that the Activity would close out before setTitle() would be called.  Resulting in a nullPointerException as the activity == null.
I also just added to this, a new method "getDrawableFromFont" as a helper and then added in the ability to use fonts in setHomeAsUpIcon.
I just check for a HashMap or String and adjust the icon accordingly.

Cool, I really like this. Before merging, can you please exclude all changes from the PR except for the changes on the code (ActionbarextrasModule.java)?
I don't want the build.properties, gitignore etc. to be changed. Thanks!


[i18n] Update translation of 合計(in en and zh-tw)

📝 関連issue / Related Issues

#680
close #1227

⛏ 変更内容 / Details of Changes

FIX :  "Japanese text {date}の合計 without translation"

en: {date}の合計 => Total of %{date}
zh-tw: {date}の合計 => %{date} 當日總數
zh-cn: {date}の合計 => %{date} 当日合计

📸 スクリーンショット / Screenshots

zh-TW: {date} 的合計 maybe more near the Japanese meaning on wording?
Btw, there is the translation table: https://docs.google.com/spreadsheets/d/1aksSfWIXE_L3rFYFjHz9xtVhh0n7ealMQ0eEz8GGPlw/edit#gid=0

Ref: #1227

Ref: #1227

thank you

zh-TW: {date} 的合計 maybe more near the Japanese meaning on wording?
Btw, there is the translation table: https://docs.google.com/spreadsheets/d/1aksSfWIXE_L3rFYFjHz9xtVhh0n7ealMQ0eEz8GGPlw/edit#gid=0

zh-TW: {date} 的合計 is good , I already updated it  as your suggestion :)
The lastest commit I did     is the same as translation-wordstable that you shared

Thank you so much for translation table :)


De-brand site

Describe the bug
Site looks like template: clean up the css to make it look more neutral and adopts LF colours.
See #13

Thought I'd link this here: https://www.linuxfoundation.org/brand-guidelines

@Laphatize That's helpful - we'll dig into it when we add the logos.

Closed by #15 though


passes: init at 0.8

Description of changes
motivation: NixCon :D

sample pass:

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 253801 run on x86_64-linux 1

1 package built:

passes

It also runs fine for me


Support barrier operation in NCCL commlib implementation

As proposed in the design doc here: https://github.com/sql-machine-learning/elasticdl/blob/140491358168ee202e013e0bd2c8b8f8ddfd46d2/docs/designs/allreduce.md#fault-tolerant-allreduce-implementation
See discussion in https://github.com/sql-machine-learning/elasticdl/pull/1420#discussion_r344993595
/kind feature

This is already supported in PyTorch commlib implementation but not for NCCL. I just renamed the issue.

/close


Docker hub 9.2.0 arm image is absent

Version 9.2.0 somehow got an arm version of image deleted: https://hub.docker.com/layers/flyway/flyway/9.2.0/images/sha256-f3a2aee4c210a9fc5444f7ca39de0bce723eef00e0b292353d806fa920eadcc1?context=explore
At first I've thought it was some sort of cleanup keeping arm image for only latest version, but both 9.3.x and 9.1.x versions still have arm available.
9.2.0 definitely used to have an arm version as I had successfully built from it.
Decided to report this just in case it's a sign of some build pipeline issue.

Hi @aliusmiles
Thank you for bringing this to our attention, we will investigate.


Fix empty for loop, if statements and children

We expand empty rsx statements to None instead of an empty template so that there is a root node for the template for diffing. This PR expands that behavior to the body of if statements, for loops and children
Fixes #2270

This is technically a breaking change but since it only fixes cases it's fine!


Grafana dashboards should match release version

These files need to match the release. Update build process to modify or generate based on release.

cmd/tools/grafana/grafana.go:32
grafana/dashboards/dashboard.yml
grafana/dashboards/dashboard7.yml

is this done with folder specific dashboards?

[ ] Support dashboard versioning with cli. Handled in #818
[ ] Support dashboard versioningin docker-compose workflow


A way to know which version of this plugin I need for which version of Godot

Is your feature request related to a problem? If so, please describe.
Although Godot 4.2 is stable at the moment, I'm still using Godot 3.5 for an ongoing project. I'm trying to figure out which version of this plugin I need to match the version of Godot I'm using, but apparently this isn't documented.
What feature or improvement would you like to see?
Document up to which version of Godot a release is working.
Additional context
I could be doing something wrong, I'm also pretty new to this so I have no idea what is possible.

Hi, do you mean this?
https://github.com/Poing-Studios/godot-admob-plugin/discussions/88

The v1 is for Godot 3, V2 is for Godot 4, and v3 is for Godot 4.1+

Hi @davekaa does this satisfy your question?

Sorry for the late response. Yeah, that image is helpful!
Since I didn't get it working in the meantime, I started upgrading my project to Godot 4.2. Now I have another problem, since the latest version of your plugin doesn't seem to support Godot 4.2, is that right? This thread is probably not the right place to discuss it, but just wanted to ask.

The plugin supports Godot 4.2, please read this: https://github.com/Poing-Studios/godot-admob-android/issues/211
Closing the issue since seems to be resolved


crystal_0_32: Fix hydra build

Motivation for this change
It seems that there might be hydra machines that run an older version of Nix
where https://github.com/NixOS/nix/pull/2878 is not yet included
(unconfirmed)
In addition crystal 0.32.1 has a bug that only occurs when there is no
tty: https://github.com/crystal-lang/crystal/issues/8609
Combining this lead to a crystal build failing: https://hydra.nixos.org/build/113074265
This fixes that probably rather uncommon occurence by applying the
upstream fix for the bug: https://github.com/crystal-lang/crystal/issues/8609
Ping @peterhoeg @manveru @david50407
Relevant for ZHF https://github.com/NixOS/nixpkgs/issues/80379, so I'll backport this once merged
Things done

[ ] Checked that it still builds

As https://github.com/NixOS/nixpkgs/pull/80390 is being worked on (by me), and the described failures no longer occur, I propose this PR be closed after 0.33.0 is merged.

@filalex77 20.03 feature freeze has already happened, so even version updates shouldn't go into it anymore. We can have 0.33 on master, but I think this patch here is better for 20.03. I'll change this to target 20.03 only though.

@Infinisil Sure, I can get behind this. I'll try to remember not to backport this one to the release branch.


Fix #1389 clean-up 'Forms' component, which is obsoleted in connect-app

Issue - https://github.com/appirio-tech/connect-app/issues/1389

Thanks @sachin-maheshwari for cross checking the references.

LGTM 👍


U-boot instructions for SDRAM interactions

Hello! I was working in the FPGA - SDRAM Communication project. All was going fine up to the part of the U-boot programming.
In instruction # 4:
"""
Now we load the rbf file into memory and then flash the FPGA with it. The reason we do this is because the FPGA design has some configuration bits on the bridge that get enabled when we flash it. However, this needs to be done when the sdram bridge is in reset mode and when it is not being used by the HPS. Hence it needs to be done in u-boot.
fatload mmc 0:1 0x2000000 sdr.rbf
fpga load 0 0x2000000 0x700000
"""
the fpga load instruction does not work.
I was able to load my rbf file appropiately (The rbf file was generated based on the given instructions starting from the barebones project from the prior project):
=> fatload mmc 0:1 0x2000000 soc_system.rbf
2081456 bytes read in 106 ms (18.7 MiB/s)
But, when trying to do the fpga load part, I get the following error:
=> fpga load 0 0x2000000 0x1FC2B0
Command 'load' failed: Error -6
I was wondering why I happened to get different project sizes than those presented in the guide. I tried to adjust the hex part to reflect the size of the rbf, but still I wasn't able to progress. Thank you for your responses.

@GustavoDLRA perhaps it's due to the format of the .rbf file?  In the process of converting the image to .rbf, you have to set a format, e.g. Passive Parallel x16, which is what the instructions show here:
https://github.com/zangman/de10-nano/blob/master/docs/Flash-FPGA-from-HPS-running-Linux.md#create-a-blink-design
I'm fairly sure there's only one format that will work with U-boot, and I haven't personally verified that those instructions are correct, so it may be worth trying others.
Using robseb/rsYocto (which is a similar system to the Zangman one) it's possible to load an FPGA image after the system has booted, from the linux command line (bash, IIRC), or from a script.  I'm not sure if the Zangman system allows that, but it's another option for you to try:
https://github.com/robseb/rsyocto
I have tried that and I seem to remember it's possible to load different formats of .rbf that way.  I didn't try loading them in U-boot.
I was able to send .rbf files to the microSD card via the USB-serial connection on both robseb/rsYocto and Zangman, but to do it on Zangman I had to install the lrzsz package first.  The version I needed for Debian was lrzsz_0.12.21-10_amd64.deb
To install that, I placed it on the FAT partition of the microSD card then mounted that to copy the file.  I had to umount it afterwards to avoid Windows giving a warning message and wanting to scan it for errrors, afterwards.  I can give more details if you want them, but I think if you want to try loading a .rbf from linux, rather than u-boot, you may need to use robseb/rsYocto instead.
The way I was trying .rbf images was to just let U-boot load whatever was on the card, then loading my own image from the command line, or from a script that ran automatically when it booted up, overwriting the one from U-boot.  Provided that the device tree is the same, or a least that the parts of it that you want to use are the same, there's no need to change the device tree.

Thank you so much. I'm gonna try these things and report back later.
Thanks again


Vertical layout?

Is there any ability to configure the chart so the header columns are vertical? I.e. the normal horizontal layout looks like

And i'm looking for something like:a

@timkpaine This would require an alternate grid renderer, which is not huge, although there will be ripple effects with other parts of code that assume y is rows and x is columns. So this would be opening a whole can of worms. That said, this would certainly be a worthy feature...!
Have you considered:

making the headers an actual row
subclassing the data model to transpose the data on the fly
set the first column (no the headers) as fixed (non-scrolling)

Another thing we could more easily do is rotate the headers _n_° (e.g., n = 45 or n = 90).
JE


Unshift is broken on data rendered with components

Wen using a component, using unshift (and splice) on the data array behaves incorrectly. It removes the element from the end of the array and adds two new elements to the beginning of the array. push still works as expected
This occurs on both edge and latest.
Here's a demo: http://jsfiddle.net/zeuk7j17/

Looks like there's a bug with implicit bindings across component boundaries. As a workaround, if you bind the value explicitly, the bug does not occur: http://jsfiddle.net/zeuk7j17/1/

Thanks for figuring out a workaround. If I were to try to figure out a bugfix, do you have any suggestions for where to start looking?

seems to be related... not sure... even the suggested workaround (thanks for that @Madgvox ) doesn't work when using computed attributes in the component.  See it here (adapted from the workaround by @Madgvox ) http://jsfiddle.net/ac00dnmb/ .
I didn't even get to the point of having the computed attributes depend on attributes from the parent. In my example I'm just returning a fixed value.

You put the computed property on the component, then attempted to pass it into the component from the parent. Moving the computed value definition from the component to the main ractive fixes your issue: http://jsfiddle.net/ac00dnmb/1/

Yes, your fix works @Madgvox, thank you. Putting the computed method in the component is suggested in the documentation http://docs.ractivejs.org/latest/computed-properties, last example on the page. Also, the component seems to be the appropriate location (similar to Backbone collections and models), since it applies to the member and not the list.
Nevertheless, it works, can't beat that! Thanks again @Madgvox. Confess I don't understand your workaround.

It appears I mislead you with my example; it seems I solved a different problem than the one you were trying to fix. Can you give me a summary of what you're attempting to do, so I can point you in the correct direction?

The last example on the docs page for computed properties (http://docs.ractivejs.org/latest/computed-properties) is what I'm trying to do. I'm not seeing how to apply your workaround to that example.
Here's a jsfiddle for clarification: http://jsfiddle.net/Nightingill/brpbu630/2/  it exhibits the bug which is the subject of this thread. How would one apply the workaround?
Many many thanks for your help @Madgvox

Here I'm passing the width and height explicitly into the component, and that lets it work correctly: http://jsfiddle.net/brpbu630/3/
Is this what you were referring to?

Perfect! thank you @Madgvox

This now fixed in edge.


Fixed null reference exception on context menu buttons

Summary of the Pull Request
Added a null check to fix the null reference exception

PR Checklist

[X] Applies to #4579
[X] CLA signed. If not, go over here and sign the CLA

Validation Steps Performed
Tried searching through various results by hovering and arrow keys but I couldn't repro it anymore.

i assume the answer is doubtful, is this a bit of code we can add a unit tests around?


Caught Wind Joule added support for Decred

Catching wind Joule added support for Decred.  Can someone else verify?  We may need to adjust the site accordingly.

https://github.com/joule-labs/joule-extension/pull/230

Good spot! Thanks. Will merge a pull request removing joule when one is available or when I am back at keyboard (few days)

Pull request made.

Removed https://github.com/bitcoin-only/bitcoin-only/pull/35


refactor substitution?

From #279 :

[ ] getsubs and vectorsub are undocumented and confusing (they seem to have similar roles, but one returns something, and the other operates by side effect)
[ ] In #273 we discussed that functions involving varlocs, exps, cs, should perhaps be implemented as part of a renamed PosyTuple
[ ] A lot of repeated code, e.g. under elif isinstance(sub, VarKey) vs elif isinstance(sub, Monomial).
[ ] "too-many-branches" warning from pylint -- feels like a maze of conditionals...

Some amount of 3 and 4 above is the attempt to do typed programming in Python. :-/ Which would be great to fix, I'm just not sure how.

This got a whole lot better.


Need Keeper app loading animation updated with new tagline

https://bithyve-workspace.slack.com/archives/C02P2JWALJZ/p1709742432541509

I don't think I will be able to take this

Animation Flow made. Its at the top of  Figma file:
https://www.figma.com/design/m5eMFTKD391AiJAXaEzgxB/Bitcoin-Keeper?node-id=386-6364&t=eF7mLajoMLxiV4d1-1
Here's the preview:
https://github.com/user-attachments/assets/4dd84a42-230e-46a7-8333-ef05a8eebe89

Completed


[KYUUBI #5237] ConfigMaps deletion on Kubernetes

:mag: Description
Issue References 🔗

This pull request fixes #5237
Describe Your Solution 🔧
Extended the implementation of pod deletion method and which deletes the config maps associated with the pod, if the config map contains spark-exec keyword in it. Here I used specific matching to avoid the deletion of any other important config maps
Types of changes :bookmark:

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Locally, attaching the results

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Codecov Report
Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (8e2b1b3) to head (340c3d7).

Files with missing lines
Patch %
Lines

...kyuubi/engine/KubernetesApplicationOperation.scala
0.00%
24 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6700   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         684     684
  Lines       42279   42303   +24
  Branches     5765    5771    +6
======================================
- Misses      42279   42303   +24

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @pan3793 @turboFei , please review the change

The overall design here is, in Spark on K8s cluster mode, all resources created by the Spark app should set the owner reference to the Spark driver pod, which means all resources will be deleted automatically after deleting the driver Pod, is this not sufficient? Can you elaborate more about your use cases and problems?

Hi @pan3793, As per my understanding I was expecting the same behaviour, cm to be deleted by spark.
But what I am observing that, driver configs are getting deleted, not executor configs.
While launching the kyuubi-server I have defined, spark.submit.deployMode=cluster
This is the engine launch submit command:
/opt/spark/bin/spark-submit
--class org.apache.kyuubi.engine.spark.SparkSQLEngine
--conf spark.hive.server2.thrift.resultset.default.fetch.size=1000
--conf spark.kyuubi.client.ipAddress=<IP_ADDRESS>
--conf spark.kyuubi.engine.engineLog.path=/opt/kyuubi/work/madlnu/kyuubi-spark-sql-engine.log.3
--conf spark.kyuubi.engine.submit.time=1726597018098
--conf spark.kyuubi.ha.addresses=<IP_ADDRESS>:2181
--conf spark.kyuubi.ha.engine.ref.id=1218c38d-f742-402e-84bf-161b89552eb6
--conf spark.kyuubi.ha.namespace=/kyuubi_1.9.1-SNAPSHOT_USER_SPARK_SQL/madlnu/default
--conf spark.kyuubi.ha.zookeeper.auth.type=NONE
--conf spark.kyuubi.kubernetes.master.address=$MASTER
--conf spark.kyuubi.kubernetes.namespace=scaas
--conf spark.kyuubi.server.ipAddress=<IP_ADDRESS>
--conf spark.kyuubi.session.connection.url=<IP_ADDRESS>:10009
--conf spark.kyuubi.session.engine.initialize.timeout=PT10M
--conf spark.kyuubi.session.real.user=madlnu
--conf spark.kyuubi.zookeeper.embedded.client.port=2181
--conf spark.app.name=kyuubi_USER_SPARK_SQL_madlnu_default_1218c38d-f742-402e-84bf-161b89552eb6
--conf spark.driver.extraJavaOptions=-Divy.home=/tmp
--conf spark.driver.port=7078
--conf spark.eventLog.enabled=true
--conf spark.hadoop.scaas.skipDeleteOnTerminationValidation=true
--conf spark.kubernetes.authenticate.driver.serviceAccountName=spark
--conf spark.kubernetes.authenticate.serviceAccountName=spark
--conf spark.kubernetes.container.image=$IMAGE
--conf spark.kubernetes.driver.label.kyuubi-unique-tag=1218c38d-f742-402e-84bf-161b89552eb6
--conf spark.kubernetes.driver.pod.name=kyuubi-user-spark-sql-madlnu-default-1218c38d-f742-402e-84bf-161b89552eb6-driver
--conf spark.kubernetes.executor.deleteOnTermination=false
--conf spark.kubernetes.executor.podNamePrefix=kyuubi-user-spark-sql-madlnu-default-1218c38d-f742-402e-84bf-161b89552eb6
--conf spark.kubernetes.namespace=scaas
--conf spark.rpc.askTimeout=300
--conf spark.security.credentials.hbase.enabled=false
--conf spark.submit.deployMode=cluster
--conf spark.kubernetes.driverEnv.SPARK_USER_NAME=madlnu
--conf spark.executorEnv.SPARK_USER_NAME=madlnu
--proxy-user madlnu /opt/kyuubi/externals/engines/spark/kyuubi-spark-sql-engine_2.12-1.9.1-SNAPSHOT.jar


Fix multiple reloads in one change

Simply fix multiple reloads in one change

Hi @012e thanks for your effort, but I don't think this solution is going to work.

It might work on the first reload, but not subsequent reloads
If you subtract 1ms every reload, you're back at where it is right now

I'd recommend trying the solution I suggested earlier.
By the way, I'm a bit confused why the Ubuntu tests are passing the watcher, but the watcher isn't working for your machine. Do you have any idea why that might be?

This code only initialize the startTime variable once, minus by 1ms to ensure it won't get ignore by time.Since(startTime).Milliseconds() > 1.
startTime := time.Now().Add(-1 * time.Millisecond)

Each time an event is triggered startTtime will be reset.
startTime = time.Now()

For example, if 2 events are triggered in one change, 0ms between each. Then time between (3) to (4) is also 0ms and ignored.
I tested it on my local machine, it works properly, there's no extra reloads. I did test CI/CD twice on my fork before pushing. It works.
Now I am also confused 😕.

By the way, I'm a bit confused why the Ubuntu tests are passing the watcher, but the watcher isn't working for your machine. Do you have any idea why that might be?

Probably because it changes the file one time, and getEvent only expect at least a response to pass the test. So if there are more, the test still doesn't fail.
https://github.com/livebud/bud/blob/ee97bd4d1baceaa45feaaa612f1619985c29ea1f/package/watcher/watcher_test.go#L35-L41
Is it something related to system hardware or drivers + OS?

Hmm, okay let me pull this done and test it locally! Cool diagram btw :-D

I think this will work 😀

Hey @012e, just pulled it down. It seems to be working. Can you remind me of the problem this solves for you? From the previous PR it was to avoid multiple triggers, is that still the problem?
With this PR, I'm still a bit hesitant: if a single new file change occurs within 1 millisecond of the last file change, the last file change is lost, leading bud/ build to be older than what's in your filesystem. This is hypothetical though since I'm not able to reproduce this behavior.

My issue:
It reloads multiple times because of multiple write signals.
Normally, when I make a single file change while bud run:
| Ready on http://<IP_ADDRESS>:3000
| Ready on http://<IP_ADDRESS>:3000
| Ready on http://<IP_ADDRESS>:3000
| Ready on http://<IP_ADDRESS>:3000

If I add this line here (fix-multiple-reloads branch)

case evt := <-watcher.Events:
        // Add here
         fmt.Printf("Current event: %s, time between previous event: %s\n", evt, time.Since(startTime).String())
	switch op := evt.Op; {

Each time I make a single file save:

Current event: "controller/controller.go": WRITE, time between previous event: 1.407399441s
| Ready on http://<IP_ADDRESS>:3000
Current event: "controller/controller.go": WRITE, time between previous event: 2.25µs
Current event: "controller/controller.go": WRITE, time between previous event: 27.773µs
Current event: "controller/controller.go": WRITE, time between previous event: 33.173µs

bud run

if a single new file change occurs within 1 millisecond of the last file change, the last file change is lost

OK, because the write handler wasn't triggered (event triggered within 1ms cool down period)

leading bud/ build to be older than what's in your filesystem

Uh, since the watcher didn't emit a write event, no re-compile is made. This is the flaw using a cool down, not much way to prevent.

Just tested again, you're not seeing 2 events per save on your linux? I created a test script:
scripts/test-watcher/main.go
package main

import (
	"context"
	"fmt"
	"log"
	"os"

	"github.com/livebud/bud/internal/current"

	"github.com/livebud/bud/internal/sig"
	"github.com/livebud/bud/package/watcher"
)

func run(ctx context.Context) error {
	dirname, err := current.Directory()
	if err != nil {
		return err
	}
	ctx = sig.Trap(ctx, os.Interrupt)
	return watcher.Watch(ctx, dirname, func(path string) error {
		fmt.Println("-> triggered", path)
		return nil
	})
}

func main() {
	ctx := context.Background()
	if err := run(ctx); err != nil {
		log.Fatal(err)
	}
}

scripts/test-watcher/a.txt
aa

Then using the Ubuntu image in the contributing Readme
docker build -t bud:latest contributing
docker run -it --rm -v $(PWD):/bud bud /bin/bash

Results:
docker run -it --rm -v $(PWD):/bud bud /bin/bash
root@5d9c4cac4118:/bud# go run scripts/test-watcher/main.go
-> triggered /bud/scripts/test-watcher/a.txt
-> triggered /bud/scripts/test-watcher/a.txt

Whenever I make a change, it triggers twice.


 Registered: 1024 Unregistered: 60
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Creating services
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Registering tile image types
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Registering heightmaps
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Registering renderers
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Registering worlds
[22:48:53 ERROR]: Error occurred while enabling Pl3xMap v1.21.4-512 (Is it up to date?)
java.lang.NoClassDefFoundError: org/bukkit/craftbukkit/v1_21_R3/CraftWorld
	at Pl3xMap-1.21.4-512.jar/net.pl3x.map.bukkit.Pl3xMapImpl.lambda$loadWorlds$0(Pl3xMapImpl.java:190) ~[Pl3xMap-1.21.4-512.jar:?]
	at Pl3xMap-1.21.4-512.jar/net.pl3x.map.core.registry.WorldRegistry.getOrDefault(WorldRegistry.java:37) ~[Pl3xMap-1.21.4-512.jar:?]
	at Pl3xMap-1.21.4-512.jar/net.pl3x.map.bukkit.Pl3xMapImpl.lambda$loadWorlds$1(Pl3xMapImpl.java:189) ~[Pl3xMap-1.21.4-512.jar:?]
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596) ~[?:?]
	at Pl3xMap-1.21.4-512.jar/net.pl3x.map.bukkit.Pl3xMapImpl.loadWorlds(Pl3xMapImpl.java:189) ~[Pl3xMap-1.21.4-512.jar:?]
	at Pl3xMap-1.21.4-512.jar/net.pl3x.map.core.Pl3xMap.enable(Pl3xMap.java:235) ~[Pl3xMap-1.21.4-512.jar:?]
	at Pl3xMap-1.21.4-512.jar/net.pl3x.map.bukkit.Pl3xMapImpl.enable(Pl3xMapImpl.java:76) ~[Pl3xMap-1.21.4-512.jar:?]
	at Pl3xMap-1.21.4-512.jar/net.pl3x.map.bukkit.Pl3xMapBukkit.onEnable(Pl3xMapBukkit.java:62) ~[Pl3xMap-1.21.4-512.jar:?]
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:655) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:604) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:768) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:530) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:326) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1235) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:340) ~[paper-1.21.3.jar:1.21.3-81-da71382]
	at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.ClassNotFoundException: org.bukkit.craftbukkit.v1_21_R3.CraftWorld
	at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:197) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:164) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526) ~[?:?]
	... 20 more
[22:48:53 INFO]: [Pl3xMap] Disabling Pl3xMap v1.21.4-512
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Stopping tasks
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Stopped progress tracker: true
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Stopping internal server
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ WARN ]   An error occurred with the internal webserver
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Unregistering players
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Unregistering worlds
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Unregistering renderers
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Unregistering icons
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Unregistering heightmaps
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Unregistering tile image types
[22:48:53 INFO]:  [ P l 3 x M a p ]   [ DEBUG ] Unregistering blocks

my config.yaml (just changed the port):
settings:
  # Extra logger/console output. (can be spammy)
  debug-mode: true
  # The language file to use from the locale folder.
  language-file: lang-en.yml
  # Set the web address players use to connect to your map. This
  # is only used for the client mod to know where to connect.
  web-address: http://<IP_ADDRESS>:25566
  web-directory:
    # The directory that houses the website and world tiles.
    # This is a relative path from Pl3xMap's plugin directory,
    # unless it starts with / in which case it will be treated
    # as an absolute path.
    path: web/
    # Set to true if you don't want Pl3xMap to overwrite
    # the website files on startup. (Good for servers that
    # customize these files)
    # Note: Be sure this is false when upgrading.
    read-only: false
    # The image format for tile images.
    # Built in types: bmp, gif, jpg, jpeg, png
    tile-format: png
    # The quality for image tiles (0.0 - 1.0)
    # 0.0 is low quality, high compression, small file size
    # 1.0 is high quality, no compression, large file size
    # Note: Not all image formats honor this setting.
    tile-quality: 0.0
  map:
    zoom:
      # Forces the map's zoom level to always be a multiple of this.
      # By default, the zoom level snaps to the nearest integer; lower
      # values (e.g. 0.5 or 0.1) allow for greater granularity. A
      # value of 0 means the zoom level will not be snapped.
      snap: 0.25
      # Controls how much the map's zoom level will change after a zoom in,
      # zoom out, pressing + or - on the keyboard, or using the zoom controls.
      # Values smaller than 1 (e.g. 0.5) allow for greater granularity.
      delta: 0.25
      # How many scroll pixels (as reported by L.DomEvent.getWheelDelta) mean
      # a change of one full zoom level. Smaller values will make wheel-zooming
      # faster (and vice versa).
      wheel: 120
  internal-webserver:
    # Enable the built-in web server.
    # Disable this if you want to use a standalone web server
    # such as apache or nginx.
    enabled: true
    # The interface the built-in web server should bind to.
    # This is NOT always the same as your public facing IP.
    # If you don't understand what this is,
    # leave it set to <IP_ADDRESS>
    bind: <IP_ADDRESS>
    # The port the built-in web server listens to.
    # Make sure the port is allocated if using Pterodactyl.
    port: 25566
    # Allows the built-in web server to follow symlinks.
    # It is generally advised against enabling this,
    # for security reasons. But you do you, boo boo.
    follow-symlinks: false
  performance:
    live-update:
      # Whether or not the real-time marker system should run.
      enabled: true
      # The number of process-threads to use for real-time marker updates on the map.
      # Value of -1 will use 50% of the available cpu-threads. (recommended)
      threads: -1
    # The number of process-threads to use for loading and scanning chunks.
    # Value of -1 will use 50% of the available cpu-threads. (recommended)
    render-threads: -1
    gc:
      # Runs the JVM GC after a render job stops to free up memory immediately.
      when-finished: true
      # Runs the JVM GC aggressively while a render is running
      # CAUTION: this _will_ slow down your renders!
      when-running: false
world-settings:
  default:
    enabled: true
    render:
      renderers:
        vintage_story: overworld_basic
      skylight: 15
  world:
    enabled: true
    render:
      renderers:
        vintage_story: overworld_basic
    ui:
      display-name: Overworld
      order: 0
  world_nether:
    render:
      renderers:
        basic: nether_basic
      skylight: 0
    ui:
      display-name: The Nether
      order: 1
  world_the_end:
    render:
      renderers:
        basic: the_end_basic
      skylight: 0
    ui:
      display-name: The End
      order: 2

Loading Paper 1.21.3-81-master@da71382

Enabling Pl3xMap v1.21.4-512

Please use the correct version of Pl3xMap for the required minecraft version.
If you still need help, please join the discord server for support. https://granny.dev/discord


Seed enable / disable commented

Hello,
I just wanted to ask why the enable and disable method of the Seed have been commented. Is it an issue with their equipment ?

Hi,
It's been a while since I worked on this but the issue was that different revisions of the seed laser had different methods for enabling, and I didn't implement a way to distinguish the revisions yet.

Hi,
Can i ask how you managed to find the corresponding byte strings to send to the device ? What i have in the documentation does not match what's in the code (and what's in the code works, but not for enabling / disabling the seed)


Can't type '[' in editor with French Canadian keyboard on Mac OS X

From<EMAIL_ADDRESS>on 2011-01-31T19:55:43Z
What steps will reproduce the problem?

Open Spyder editor
Try to type a left square bracket character '[' using Alt+9 What is the expected output? What do you see instead? With a french canadian keyboard on a Macbook running Mac OS X 10.6.6, the left square bracket is usually typed using the combination of the Alt key and 9. In the Spyder editor, this combination does nothing. Note that the right square bracket works fine (Alt+0).

Moreover, the Alt+9 combination works perfectly fine in the Spyder Console. This is an issue that affects only the editor. What version of the product are you using? On what operating system? Spyder 2.0.6
Python 2.7.1, Qt 4.7.0, PyQt 4.8.2
Mac OS X 10.6.6
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=549

From<EMAIL_ADDRESS>on 2011-02-06T11:59:24Z
Le 2011-02-06  09:46<EMAIL_ADDRESS>a crit :
There is indeed a traceback in the internal console:
Traceback (most recent call last):
File "/Users/loic/local/virtualenvs/py2.7/lib/python2.7/site-packages/spyderlib/widgets/codeeditor/codeeditor.py", line 1538, in keyPressEvent
Qt.Key_BracketLeft: '[]'}[key])
KeyError: 57
Hope this helps.
Loc

From pierre.raybaut on 2011-02-06T13:19:54Z
This issue was closed by revision b748c8ec00 .
Status: Fixed

From pierre.raybaut on 2011-02-06T06:45:16Z
Could you please try to open the 'internal console' in Spyder to see if there is any error traceback there?
I can't see why this shortcut is not working in the editor... the only difference with the console is the automatic parenthesis closing feature for (, [ and {.

From<EMAIL_ADDRESS>on 2011-02-06T13:28:35Z
Le 2011-02-06  16:20<EMAIL_ADDRESS>a crit :

From pierre.raybaut on 2011-04-24T07:38:20Z
This issue was closed by revision b748c8ec002a .


Update noUiSlider from 8.0.2 to latest (9.x)

I am encountering some problems with the range/slider control, such as annoying round-off errors (e.g. 0.9999999999 or 1.00000 appearing instead of 1 for the tooltips). As I understand it, these have been fixed in the upstream package. Could you please update the forked version bundled with materialize?

Updated to 9.1 in 7992168

Still there are issue with noUiSlider version bundled with materialize css, with scrolling. Which is not happening when using the latest version of the plugin (ver: 13.1.4). Could you please update the forked version bundled with materialize css?


clone with --depth=1 --no-single-branch

This works with both Gitbox and Github and gives good performance.
Needs some more testing.

Tests out fine for the case of output branch nonexistent

Tests out fine with a local git repository.


Update CodeClimate badges

The badges in README are a bit old, let me update it to new one.

@toshimaru thanks for your contribution. After taking a look at the code climate docs the path for the code quality is still not the most up to date, is it?
I checked this page.
Can you please re-check and update the PR if necessary?

@scepticulous Hey, I updated my PR! Could you check this again?

@toshimaru Wow, now we have coverage rate in README.md too. Thanks for the contribution!

u r welcome <3


More information related to calling StartNewAsync while passing InstanceId

Its not exactly obvious the behavior of StartNewAsync when passing InstanceId while an existing orchestration with the same id already exists.
I was assuming the behavior might be just doing nothing since an orchestration with the same id already exists but seems like its doing some sort of restart (even if an instance is already in running state)
I can contribute to documentation once someone explains that behavior to me :)
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c17b738-aa32-4cbb-3d82-bda2bc032487
Version Independent ID: a34e246c-7c65-461f-4417-3c47eb4672e2
Content: Manage instances in Durable Functions - Azure
Content Source: articles/azure-functions/durable/durable-functions-instance-management.md
Service: azure-functions
GitHub Login: @cgillum
Microsoft Alias: azfuncdf

@harouny Thank you for posting your question! We will review and update as appropriate.
@cgillum can you help here?

@harouny you are right - it looks like we did not explain this in the official docs. There is a bit more detail in the API documentation here. Basically, if another orchestration with the same ID already exists, it will be silently overwritten with the new instance. It's not a behavior we like right now, but it's the way it works currently and will probably stay this way until we do a breaking 2.0 release. I'd be happy to review a docs PR if you want to open one. :)

@harouny We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Text with background, not updated

Text with background widget, is only updated when it's hovered

Text widget (without bg) is not updated.

Also related ? https://matrix.to/#/!ozhuuBcieNoMbRkvVj:matrix.org/$9KmWG7csm-kDvOIV2vXL4S2b1qr9HuVdshrsmy0e144


Use a more accurate number library

From https://github.com/phetsims/dot/issues/113 and many other times since moving to javascript, there are rounding problems with javascript's floating point implementation.
We have reached the point that it would be nice to investigate another library, and we feel like it is potentially possible to do so in specific cases, instead of needing to use this everywhere all at once.
Marking as an epic.

Some ideas about this over in https://github.com/phetsims/dot/issues/113 is to replace the ScientificNotationNode's usage of toExponential, and potentially to rewrite DOT/Utils.toFixed.

Found a different solution. Closing, and will re-open if needed.


Create a navbar-9

Here is a reference to the component.

After building the component please raise a PR with a screenshot of the component and add the component in Navbar/.
If you need to use any icon please use it from Hero Icons

Hi, I would like to work on this issue, kindly assign it to me

Hey can you assign me this

Please assign me this issue.


github release for readable semver dependency

I am using dep for dependency management.
( While I could still use master branch directly for the same ) , it would be useful if a github release ( say, 0.0.1 or similar ) were made so the semver dependency could be more readable and maintainable.

Just tagged the latest master as v1.0.0. Please see if it helps :-)

Thanks a lot. This helps !

[[constraint]]
  name = "github.com/yookoala/realpath"
  version = "1.0.0"

For those stumbling upon this - you can add the above to Gopkg.toml to set the right constraint and allow dep to consistently reproduce the same


Create tests

Currently there is no any tests set up for the code to verify everything works fine.
If someone wants to contribute by creating a test suit, any contribution is welcome.

Hi @davbrito , I would like to work on this. Can you please let me know what sort of testing would you like?


SharpHound.ps1 does not produce output

Description:
Many times the PowerShell script will not produce the designated output file. The .exe ingestor works perfectly every time. Sometimes, the problem is resolved when I use the -OutputDirectory option.

I'm not really sure how we would go about debugging this, especially since the .ps1 script is just wrapping the .exe, so functionally there shouldn't be any real difference other than how its delivered into memory. Can you isolate a reproduction of this in a specific scenario?

It could potentially be due to PowerShell tracking the current directory differently than what the .NET libs see:

Closing this issue as we've not heard any updates. We can always re-open with more info!

Not sure if this is going to be seen since this issue is closed but giving it a try anyway. I have run into the same issue as described above.
In my case I opened a PowerShell shell from another shell using the runas /user:<domain>\<user> powershell.,exe command. When the PowerShell shell opened it opened in C:\Windows\System32. I navigated to the directory where the Sharphound.ps1 file was located and ran the commands to collect from the domain (twice because I did not see any results).
Then I ran a search for *bloodhound.zip and found that the collection files are in the C:\Windows\System32 directory. I believe that @leechristensen hit the nail on the head here.
Sharphound.ps1 / Invoke-Bloodhound run from the C:\users\rstrom\Downloads\SharpHound-v2.3.3 directory

Resulting files are located in the C:\Windows\System32 directory

The cache file ended up in System32 also


Installation error

os=windows server 2008
node version=12.19.0
nvm=6.14.8
sharp version=0.30.6
getting this error:
PS E:\rendering\nodeapp> node app.js
E:\rendering\nodeapp\node_modules\sharp\lib\sharp.js:34
throw new Error(help.join('\n'));
^
Error:
Something went wrong installing the "sharp" module
The specified module could not be found.
\?\E:\rendering\nodeapp\node_modules\sharp\build\Release\sharp-win32-x64.node

Hi, the issue template was ignored/deleted. Please can you open a new installation issue and answer all of the questions. https://github.com/lovell/sharp/issues/new?labels=installation&template=installation.md


Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in [...]/node_modules/esmock/package.json

Importing<EMAIL_ADDRESS>leads to the following error:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: No "exports" main defined in [...]/node_modules/esmock/package.json
// @ts-ignore
import esmock from "esmock";

esmock('./foo', {]);

@ericmorand would you give more information about your setup so that I can reproduce the issue?
Is there another "export" definition that needs to be added? https://github.com/iambumblehead/esmock/blob/master/package.json#L9-L13

@ericmorand is it possible that your setup is not using esm? I did a google search and this github issue came up in the results https://github.com/ipfs/js-ipfs/issues/4138

The tests must be run using esm. Closing this issue, but feel free to re-open if necessary


Use semantic versioning

Hello,
First of all, thanks for the software! :-)
You may want to use semantic versioning for this project so the meaning of version numbers will be more "readable".

Hi thanks for the hint @turicas :+1:   !
I will remember to use it from now on :).


The dotnet Bash commands for the Verified ID - Verify project contain errors (typos)

[Enter feedback here]
Original Bash (Verify part)
cd active-directory-verifiable-credentials-dotnet/1. asp-net-core-api-idtokenhint
dotnet build "asp-net-core-api-idtokenhint.csproj" -c Debug -o .\bin\Debug\netcoreapp3.1
dotnet run
Correct Bash (Issue part since it is the same piece of code that is used)
cd active-directory-verifiable-credentials-dotnet/1-asp-net-core-api-idtokenhint
dotnet build "AspNetCoreVerifiableCredentials.csproj" -c Debug -o .\bin\Debug\netcoreapp3.
dotnet run

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3675f188-3fde-635b-0ef3-4ea74781fc05
Version Independent ID: ddb65f00-f254-b237-2200-c0edd8ad104f
Content: Tutorial - Configure Microsoft Entra Verified ID verifier - Microsoft Entra
Content Source: articles/active-directory/verifiable-credentials/verifiable-credentials-configure-verifier.md
Service: decentralized-identity
Sub-service: verifiable-credentials
GitHub Login: @barclayn
Microsoft Alias: barclayn

Thanks for discovering this. I have a pending PR that will address it.


bundle create: set default channel if only one channel is set

Description of the change: set default channel if only one channel is set
Motivation for the change: a default channel should always be set, and we can infer which one it is if there is only one channel.
See https://github.com/operator-framework/operator-sdk/pull/3106#issuecomment-634431106
/cc @hasbro17 @camilamacedo86

/lgtm


Fix output

https://github.com/ddddddO/gtree/issues/56

Codecov Report
Patch coverage: 88.23% and project coverage change: +0.25 :tada:

Comparison is base (180b146) 89.86% compared to head (c64495e) 90.12%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   89.86%   90.12%   +0.25%
==========================================
  Files          18       18
  Lines        1076     1083       +7
==========================================
+ Hits          967      976       +9
+ Misses         79       76       -3
- Partials       30       31       +1

Impacted Files
Coverage Δ

tree_handler_programmably.go
100.00% <ø> (ø)

stack.go
93.54% <81.81%> (-6.46%)
:arrow_down:

node.go
94.82% <100.00%> (+0.59%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

01:42:14 > cat ../../testdata/sample2.md | ./gtree mkdir --dry-run
k8s_resources
├── (Tier3)
│   └── (Tier2)
│       └── (Tier1)
│           └── (Tier0)
├── Deployment
│   └── ReplicaSet
│       └── Pod
│           └── container(s)
├── CronJob
│   └── Job
│       └── Pod
│           └── container(s)
└── (empty)
    ├── DaemonSet
    │   └── Pod
    │       └── container(s)
    └── StatefulSet
        └── Pod
            └── container(s)

20 directories, 0 files


Switch to guaranteed producer using opaque

Attempt number 3.
The newest version of the kafka driver support a message opaque feature. In C++ land it's basically attaching an arbitrary pointer to the message and then returns the pointer together with a delivery report. Node driver supports providing an arbitrary Javascript object, pointer to which would be used as an opaque in C++ land, so we can get back the same exact object. Since the object in JS land gets out of the scope and might be GCed normally, driver uses native Nan::Persistent in order to hold on to the object while it's in the C++ land and resets the persistent before passing it back to JS land.
Using this feature we now can pass promise resolve and reject functions through native code, get them back in the delivery report and call them which makes guaranteed producer implementation so much easier (and scarier)
I've verified the driver code around this new feature we're adopting and done very extensive memory-leaks testing - locally all runs fine. Doesn't guarantee we won't have a memory leak in production again though..
Also, this version doesn't poll on each and every produce call, but polls once in 100 ms instead. It is a bit riskier, but the buffer size is 100.000 messages and I don't think we'd ever produce fast enough to overflow the buffer.
cc @wikimedia/services

Coverage increased (+4.9%) to 90.958% when pulling 0a9cc6ed3e40c75e9bdef34da3a7edcc3b804eda on Pchelolo:guaranteed2 into fe92c9ab02f3e2a555f1dfc398aae18d74e51108 on wikimedia:master.

Coverage increased (+4.9%) to 90.958% when pulling 0a9cc6ed3e40c75e9bdef34da3a7edcc3b804eda on Pchelolo:guaranteed2 into fe92c9ab02f3e2a555f1dfc398aae18d74e51108 on wikimedia:master.

Coverage increased (+4.6%) to 90.597% when pulling 0a9cc6ed3e40c75e9bdef34da3a7edcc3b804eda on Pchelolo:guaranteed2 into fe92c9ab02f3e2a555f1dfc398aae18d74e51108 on wikimedia:master.

This looks good to me. On the C++ side, I think this is the section where the void* is set up.

@gwicke Yep, that's the code. Not guaranteed it won't leak again, local testing didn't show the leak before too, but let's hope for the best :)

The corresponding dereferencing is happening here. The Nan::Persistent handling looks correct to me, but I haven't dug very deep to verify that all (error-) code paths really hit that callback handling code. But, we'll find out soon enough I guess ;)

Tested for native leaks using instruments (gdb Mac alternative) and nothing found..

Coverage increased (+4.6%) to 90.614% when pulling f5b10b6628dd5c3f2dbec210cec5d6c540bf1eba on Pchelolo:guaranteed2 into fe92c9ab02f3e2a555f1dfc398aae18d74e51108 on wikimedia:master.

Done some more testing and update the PR to call poll after every call to produce for safety. We can consider making less polls in the future, but we should start conservatively.


OverrideParameters example - AzureResourceGroupDeployment@2

There is a space after colon ":" which makes the yaml invalid. Remove that space and it works.
overrideparameters
-options ["option1"] -map {"key1": "value1" }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a59ea95e-b51a-e529-37a8-215e383c9a0b
Version Independent ID: f1afdb0e-f090-3193-9bb8-ce5952016768
Content: Azure Resource Group Deployment task - Azure Pipelines
Content Source: docs/pipelines/tasks/deploy/azure-resource-group-deployment.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

@RoopeshNair Roopesh, there are a couple of instances of key value pairs separated by colons with a space. The one mentioned above is the only code (the others are explanatory). I don't know whether you want to change them all for consistency.


Playback error due to website changes

Netflix add-on version
1.22.1+matrix.1
Operative systems used
Android
Kodi version used
Kodi 20 (Nexus)
Description of the bug
Device: Mi Stick
Current Kodi version: v20.2 (but the same error is also being encountered with v19 for several weeks
Netflix Add-on error
Due to a msl error you cannot playback videos with this device. This is a know problem due to a website changes. This problem could be solved in the future, but at the moment there is no solution
Playback failed
One or more items failed to play. Check the log for mor information about this message.
Steps to reproduce the behavior
No response
Debug log - mandatory
https://paste.kodi.tv/dewaramatu.kodi
Possible fix
No response
Additional context
No response
Screenshots
No response

I had identical error on Xiaomi Mi Box 3, Xiaomi Mi Box S (first gen) and Xiaomi Mi Tv Stick (old FHD model).
As i know, all three are L1 and Netflix certified. All three have AndroidTV 9 and disabled Netflix app.
I have tried addon version 1.22.0, as suggested in #1597 and it worked.
So i have done some tinkering and this is result:
Version: 1.22.3 on Kodi 20.2 from play store, all three mentioned Xiaomi devices.
Logged in with key and password, playback shows this "msl website changes" error.
In expert settings, i have disabled atmos (don't have HW for it), enabled vp9 and hevc.
Then in ESN / Widevine settings, turned off 540p limit, set Force L3 and hit OK.
Now playback works, even in 1080p (only FHD tv's, can't test 4K).
I don't understand why, because all three are L1 devices..

I hopefully managed to solve it. My previous comment was complete bullshit, so I crossed it out. I tried the addon for the first time then..
Reason why this MSL error shows on Xiaomi devices is wrong ESN.
On my Nvidia Shield "tube" is prefix of ESN same for official app and addon.
But on my Xiaomi devices not.
(Is it OK and safe to publish this?)
Xiami Mi Box 3 (pretty old, but still working)
Official ESN: NFANDROID2-PRV-XIAOMIM12TRIAL-....
Addon ESN: NFANDROID1-PRV-T-...
Xiaomi Mi Box S (1st gen, same HW as Box 3):
Official ESN: NFANDROID2-PRV-M19-....
Addon ESN: NFANDROID1-PRV-T-...
Xiaomi Mi Tv Stick (first HD model, own it twice):
Official ESN: NFANDROID2-PRV-AQUAMAN-....
Addon ESN: NFANDROID1-PRV-T-...
Addon have same wrong ESN on all 4 Xiaomi devices i own.
@Warprein - try it, just check your official app ESN and edit ESN prefix in addon, keep other ESN settings at default, it works for me, few days so far 😊
@CastagnaIT - maybe it will help as a hint for other devices with the same error from version 1.22.1, I don't know how the ESN is generated in the addon, but at least it doesn't work correctly on Xiaomi devices.

Hi All..
I had the same on some xiami boxes and sticks..
What worked for me to get arround this was as following :
Reset the whole netflix addon and inputstream.. then re-login and all should work again..
Hope this helped
Kind regards

Oh crap, I have found why is addon generating T - ESN.. Because (on Box 3) value for ro.build.characteristics is literally default..

@cache-sk exact tv boxes with andoird tv OS should always have "TV" on ro.build.characteristics
if you can confirm that on all your 4 xiaomi devices
the ro.com.google.clientidbase have android-xiaomi-tv value,
then i can add a special case to force generate the NFANDROID2 when that value match

@CastagnaIT
I finally found time to check it on all these devices and I confirm that on all four named xiaomi boxes/tv sticks with Android TV 9 is ro.build.characteristics == default and ro.com.google.clientidbase == android-xiaomi-tv
Checked with qute terminal and getprop command.

thanks i will add this check

When i try to change the ESN prefix from NFANDROID1-PRV-T to my device NFANDROID1-PXA-T it says Wrong ESN format, i also tried  NFANDROID2-PRV it chnges without any error but when i try to play a video i get logout problem

Can anyone help? @CastagnaIT


Add "refresh all" to the "unread" tab

The "unread" tab is the one in which I spend most of my time. I think it makes sense to be able to "refresh all" feeds from within this view. I suggest placing the option to "refresh all" before the option to "sort by date".
I believe the option to "refresh all" could be removed from the "subscriptions" tab. IMO, it has more in common with sorting and reading than with adding, importing, and exporting.

I use it often in the subscriptions tab, it offers an easy overview. I would argue against removing it from there.


Use correct shade of Kubernetes blue

Per https://github.com/kubernetes/kubernetes/blob/1dc30bf/logo/colors.md, our RGB blue color is #326CE5. Use that.
/area web-development

agree with this, thanks Tim
/approve


Add a CONTRIBUTE.MD

Currently there is no CONTRIBUTE.MD which has all the instructions on how to contribute and run the project in local and many other instructions that a open source project usually has.
The contribution instructions provided here  is not enough in my opinion.

Totally agree, let's write some contributing guides to help people contribute to this package. Thanks for opening this

Agree, because at the moment I can't even get started to dev locally, as I never dealt with turbo, it seems to fail to install packages and when it works it spawns tons of nodejs process, that uses all of free memory on Mac M1 (16Gb).
I guess I am missing some requirements to get started :(

Hey! Can I work on this?

I'd like to work on this but I think we should have a discussion on what all to take into account

@dotarjun Did you run on dev correctly?


Managed Service Identity

If the VM has Azure Identity turned on and gets an object ID - does this not meet the Azure AD app registration requirements? As far as I understand, using managed service identity creates an app registration to generate a service principal for a vm.
I am unable to locate the service principal that got created in Azure AD, however if I attempt to assign it to a key vault access policy, the SP is available.  The need for a separate app registration for this vm is unclear.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 38838df3-4e07-1722-d828-e38e00fc296e
Version Independent ID: 80efdd1d-4756-c10d-681f-892a83330f69
Content: Quickstart - Install Ansible on Linux virtual machines in Azure
Content Source: articles/virtual-machines/linux/ansible-install-configure.md
Service: ansible
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@tomArcherMsft - any insights please?

@puicchan Could you please help answer this question?

@derekschauland I just published a new article for installing Ansible that should resolve any issues. Please let me know if you encounter any further problems. https://docs.microsoft.com/en-us/azure/developer/ansible/install-on-linux-vm

#please-close


Merge develop into master Version 1.1

Merge develop into master Version 1.1

Pull Request Test Coverage Report for Build 236

16 of 34 (47.06%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-7.2%) to 86.1%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/controllers/application_controller.rb
1
2
50.0%

app/models/user.rb
5
7
71.43%

app/controllers/user_controller.rb
8
23
34.78%

Files with Coverage Reduction
New Missed Lines
%

app/controllers/user_controller.rb
1
48.39%

Totals

Change from base Build 226:
-7.2%

Covered Lines:
223

Relevant Lines:
259

💛  - Coveralls


Different Notification Sounds and Enable/Disable

Have a different notification sound for when someone comes online or hosts a game and when i am pm'ed. So i don't have to tab out of something to check every time someone comes online.

We currently have different sounds for "mention" and "private message" (I'm open to use the same sound however; if it was a PM you'd see it; if not you know you got mentioned)
Sound for "friend online" is planned but not yet found. Feel free to propose one.
The settings to enable/disable particular toasts are already there (the settings dialog is an ugly draft however)
The setting to "disable toasts when in-game" yet needs to be added.


Remove trailing whitespace from text editor docs

Description of the Change
Remove trailing whitespace from text editor API docs so the linter is happy (and thus the tests pass 😄)

Thanks for this :+1:


Setup GitHub Actions

This might break out into separate sub issues but it would be nice to setup some GitHub actions for the following:

[ ] publishing the package on PyPi (see #12)
[ ] building the package over multiple python versions
[ ] automated testing
[ ] building documentation and publish to GitHub pages (see #16)

What else?

cibuildwheel might be useful for building against multiple Python versions.
If the API docs use restructuredText (and Sphinx?) it may be easier to publish to ReadTheDocs (they have pretty good GitHub integration)
Since the project uses linters, it may be a good idea to set up pre-commit to make them easier to run on CI (and for contributors, but that’s another topic of course).

FYI I built a prototype GitHub action to play with setting up the CD/CI environment in my fork.  The "install dependencies" step took over 45 minutes to run.
See: https://github.com/jsexauer/yamm/runs/6262985452?check_suite_focus=true

I was playing with this earlier and it seems we are at somewhat of an impasse. It seems the template for conda follows this article. https://autobencoder.com/2020-08-24-conda-actions/. In this article it goes onto say that it can't use conda env create. I tried several ways around this to no avail.  It seems the update process just takes a very long time.
I would say that if install from pip can work that would be a good thing to have built in testing in the CI.


Configurable maximum packet size

So far there is no way to configure a maximum packet size above 1252 bytes for IPv4 and 1232 bytes for IPv6. This means that on networks with a higher MTU (i.e. ethernet links in private networks with 9000 byte jumbo frames, or in my case, overlay networks with larger packet sizes up to 65535 bytes) we cannot take advantage of the extra packet sizes in streams and we cannot send datagrams larger than 1220 bytes.
It would be amazing if this was configurable for these environments.

How would you deal with cases where the actual MTU is smaller than you expect?
Furthermore, would this be a per-connection or a per-server option?

I would naively expect that the message would be padded up to the expected size in the HELLO phase to test the viability of the MTU and if a problem is identified there, it would either fail to handshake or fall back to a lower MTU.
In our particular use-case, we have a solid guarantee from the layer beneath us that the MTU is always 65535 bytes so we don't even really want to do that (in fact it is quite an annoying/wasteful property of QUIC to have to send so much data up front, particularly over slow links, when you already know for certain that the MTU requirement is met, but I expect that's specced behaviour).
I would imagine that this would need to be configured per-connection if it is a part of the client initiation to send that much data to a given destination — the server can't possibly know if the return path is going to be asymmetric at any rate — but it's also not inconceivable that the server might want to limit the maximum allowable size for other reasons.

Anything new regarding configuring mtu for QUIC?
I need to set max mtu to 1200 for my cases.

I am actually running into a similar issue as @dimalukas: I am using a satellite link that has known compatibility issues with regards to PMTUD, so the ability to manually set a max MTU would help me greatly!

@YRoelvink What's the issue with PMTUD, and what's the MTU you'd like to set?

I have had contact with my link provider (I am testing in a dev environment with a dedicated link) and they, for now, only informed me that there have been previous issues with PMTUD using similar setups. hey did, however, suggest that decreasing the MTU could improve the performance of the overall system, so that is what I would like to verify.

I'd be curious what those issues what be.
PMTUD is designed to be very non-invasive: Occasionally, we'll send a packet that's larger than the current MTU. If that packet is acknowledged, we conclude that the link supports higher MTUs and we start sending packets with that packet size. We continue probing for larger packet size until one of those probe packets is lost, interpreting this loss as "this link doesn't support this packet size".
In effect, PMTUD does a binary search of the packet size space between 1280 and 1500 bytes. In total, we shouldn't send more than 10 probe packets over the life time of a connection.

I believe some network equipment can be (and is) configured to ignore the DF bit, so the larger discovery frames are fragmented and forwarded along and transparently defragmented at the far end. I have seen quic-go using an MTU of 1452 on my VPN with an MTU of 1400.

Once we implement GSO (see https://github.com/quic-go/quic-go/issues/2877#issuecomment-1508137221 for recent discussion), we'll need much larger buffers to send out packets. It would be nice if we could make use of that to also enable the sending of jumbo packets.
Here's an API proposal for a Config change. MaxPacketSize would replace the DisablePathMTUDiscovery flag.
type Config struct {
     ...
     // MaxPacketSize is the maximum size of UDP datagrams.
     // QUIC connections start sending packets around 1280 bytes during the handshake,
     // and then run DPLPMTUD to determine the MTU, up to MaxPacketSize, supported by the link.
     // If unset, a default value of 1452 bytes is used.
     // Setting it to -1 disables DPLPMTUD.
     // Values above 65355 are invalid.
     MaxPacketSize int
}

With #3727 it would be possible to set this field (among others) based on the remote's IP address.
What do you guys think? Would that API work for your use case?

I think that could work for me.

Ideally the maximum packet size and whether or not to run DPLPMTUD would be separate flags — in my use-case we have guarantees from the lower layer so don’t need to work upwards to discover the max packet size — but otherwise yes, this seems like a good step in the right direction!

@neilalexander want to make an API proposal? It needs to work on links where we don’t know the MTU in advance as well.

@marten-seemann I can certainly try — now that I've thought about it some more, my best proposal would be to add an additional MinPacketSize flag too, which controls the starting packet size during the handshake, and automatically disable DPLPMTUD in the specific case that MinPacketSize and MaxPacketSize are set to the same value:
type Config struct {
     ...
     // MinPacketSize and MaxPacketSize control the packet sizes for UDP datagrams.
     // If MinPacketSize is unset, a default value of 1280 bytes will be used during the handshake.
     // If MaxPacketSize is unset, a default value of 1452 bytes will be used.
     // DPLPMTUD will automatically determine the MTU supported by the link up to the MaxPacketSize,
     // except for in the case where MinPacketSize and MaxPacketSize are configured to the same value,
     // in which case path MTU discovery will be disabled.
     // Values above 65355 are invalid.
     MinPacketSize int
     MaxPacketSize int
}

That way it gives the flexibility to set both upper and lower bounds and to optionally disable DPLPMTUD by just setting both options to the same value, i.e. I could just set MinPacketSize and MaxPacketSize to 65535 to get a fixed packet size of 64KB and disable DPLPMTUD for example, or I could set 1280 and 65535 and let DPLPMTUD work out what's best.
WDYT?

That would work as well. I'm just a bit concerned that MinPacketSize could be interpreted as "quic-go will never send packets smaller than this".

Maybe InitialPacketSize as a name is less confusing?

+1 for this feature: I am trying to use quic-go to implement reliable transport over a lossy overlay network where the payload size is configurable but known. I implemented net.PacketConn, and this works great, but I'd like to be able to take advantage of larger payload sizes because the overlay network packet format adds quite a bit of overhead and 1200b is too small. I attempted to implement OOBCapablePacketConn but because socket options are set by syscall interface I'm not able to hook the Control function and set the returned size value to trick quic-go into trying larger payload sizes. In fact just setting a larger minimum without path MTU discovery would be ideal. Happy to help implement this feature, is anyone working on this?

+1 for this feature as well. Apple's new coredevicetunnel (for device debug/development) is very particular about packet/datagram sizes and it'll eagerly disconnect if it detects initial packets/size limits that are too small. The protocol tunnels ipv6 packets as QUIC datagrams and expects full MTU size (1420B) packets to be sendable/receivable immediately.


shell_unittests flaky segfault

Seeing the following flaky failure on the host_mac_debug run of shell_unittests, which appears to be terminating with segfault (-11). This occurred on the LUCI bots on commit https://github.com/flutter/engine/commit/67de0bf44b80dda972fb8cecbdf1f48f4fa57aac.
[----------] 31 tests from ShellTest
[ RUN      ] ShellTest.FixturesAreFunctional
[       OK ] ShellTest.FixturesAreFunctional (71 ms)
[ RUN      ] ShellTest.InitializeWithSingleThread
[       OK ] ShellTest.InitializeWithSingleThread (38 ms)
[ RUN      ] ShellTest.WaitForFirstFrameInlined
[       OK ] ShellTest.WaitForFirstFrameInlined (70 ms)
[ RUN      ] ShellTest.InitializeWithGPUAndPlatformThreadsTheSame
[       OK ] ShellTest.InitializeWithGPUAndPlatformThreadsTheSame (39 ms)
[ RUN      ] ShellTest.InitializeWithInvalidThreads
[       OK ] ShellTest.InitializeWithInvalidThreads (5 ms)
[ RUN      ] ShellTest.WaitForFirstFrameTimeout
[       OK ] ShellTest.WaitForFirstFrameTimeout (111 ms)
[ RUN      ] ShellTest.ReloadSystemFonts
[       OK ] ShellTest.ReloadSystemFonts (39 ms)
[ RUN      ] ShellTest.SetResourceCacheSizeEarly
[       OK ] ShellTest.SetResourceCacheSizeEarly (69 ms)
[ RUN      ] ShellTest.WaitForFirstFrame
[       OK ] ShellTest.WaitForFirstFrame (72 ms)
[ RUN      ] ShellTest.BlacklistedDartVMFlag
[       OK ] ShellTest.BlacklistedDartVMFlag (26 ms)
[ RUN      ] ShellTest.ReportTimingsIsCalled
Traceback (most recent call last):
  File "/b/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 344, in <module>
    sys.exit(main())
  File "/b/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 323, in main
    RunCCTests(build_dir, engine_filter)
  File "/b/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 104, in RunCCTests
    RunEngineExecutable(build_dir, 'shell_unittests', filter, shuffle_flags)
  File "/b/s/w/ir/cache/builder/src/flutter/testing/run_tests.py", line 67, in RunEngineExecutable
    subprocess.check_call(test_command, cwd=cwd)
  File "/b/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/subprocess.py", line 190, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/b/s/w/ir/cache/builder/src/out/host_debug_unopt/shell_unittests', '--gtest_shuffle', '--gtest_repeat=2']' returned non-zero exit status -11

/cc @chinmaygarde for any thoughts he might have.

Can we do a tsan sanitizer pass over the same.

Duplicate https://github.com/flutter/flutter/issues/43192


Unhandled error event

What have I done to cause this?  I don't know where the event.js code is in order to inspect it.  I'm on version 1.1.2 of homekit2mqtt
2018-10-01 16:57:31.455  mqtt subscribe #
events.js:183
throw er; // Unhandled 'error' event
^
Error: listen EADDRINUSE :::51888
at Object._errnoException (util.js:992:11)
at _exceptionWithHostPort (util.js:1014:20)
at Server.setupListenHandle [as _listen2] (net.js:1355:14)
at listenInCluster (net.js:1396:12)
at Server.listen (net.js:1480:7)
at Function.listen (/usr/lib/node_modules/homekit2mqtt/node_modules/express/lib/application.js:618:24)
at Object. (/usr/lib/node_modules/homekit2mqtt/index.js:478:9)
at Module._compile (module.js:652:30)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)

EADDRINUSE -- obviously I have another instance still running.


Business calls keep failing on non running instance using load-balancer=least-response-time

My discovery returns 2 service instances:

8080 (running)
8090 (not running)

My client application repeatedly calls this service. The first call succeeds, the subsequent calls all fail.
To reproduce:
mvn clean install
java -Dquarkus.http.port=8080 -jar target/quarkus-app/quarkus-run.jar
curl http://localhost:8080/hello/stork => SUCCESS
curl http://localhost:8080/hello/stork => KO
curl http://localhost:8080/hello/stork => KO
curl http://localhost:8080/hello/stork => KO
...

see https://github.com/vsevel/stork-issue/tree/issue_233

Isn't it an issue of non preserving the service instance ids?
The code below seems to assing a new id on every service discovery refresh

    private List<ServiceInstance> map(String list) {
        return Arrays.stream(list.split(",")).map(this::createInstance).collect(Collectors.toList());
    }

    private ServiceInstance createInstance(String hostPort) {
        String[] split = hostPort.split(":");
        String host = split[0];
        int port = Integer.parseInt(split[1]);
        return new DefaultServiceInstance(ServiceInstanceIds.next(), host, port, false);
    }

I confirm that by changing that line in the LeastResponseTimeLoadBalancer fixes the problem:
long errorPenalty = DurationUtils.parseDuration(config.getErrorPenalty()).toNanos();
note that caching the service id is probably a bad idea because an instance that failed once would be ignored forever I suspect. changing the service ids after each refresh will loose the stats, but allow failed instances to be retried.
the way we handled this in our impl was that failed instance would go on the "not_ok" list for 1 minute with no calls dispatch to it (unless there were no instances available at all), and come back into the "ok" list after spending this minute on the side.
if this instance was still failing. we would put it back into the "not_ok" list, and continue the cycle ...
since we were recognizing the idempotent situations, we would not mind trying out an instance that had failed, as long as we would not try to use it more than once per, until there was one successful call. then the instance would go back into the "ok" pool.
the the difference is that our default refresh period (3 mins) was unrelated to our purgatory period (1 min).
right now, the only way we get our failed instance to be retried is to reset stats, and my understanding is that the way to do this is to change the service ids during the discovery refresh. but it does not have to.
anyway, I am going to do a PR for the nanos issue.

I confirm that by changing that line in the LeastResponseTimeLoadBalancer fixes the problem: long errorPenalty = DurationUtils.parseDuration(config.getErrorPenalty()).toNanos();

note that caching the service id is probably a bad idea because an instance that failed once would be ignored forever I suspect. changing the service ids after each refresh will loose the stats, but allow failed instances to be retried.

it's up to load balancer to choose when to decide when to reuse an instance that failed. The serviceIds should be preserved to let LB get a chance to make that decision

the way we handled this in our impl was that failed instance would go on the "not_ok" list for 1 minute with no calls dispatch to it (unless there were no instances available at all), and come back into the "ok" list after spending this minute on the side. if this instance was still failing. we would put it back into the "not_ok" list, and continue the cycle ... since we were recognizing the idempotent situations, we would not mind trying out an instance that had failed, as long as we would not try to use it more than once per minute, until there was one successful call. then the instance would go back into the "ok" pool.
the the difference is that our default refresh period (3 mins) was unrelated to our purgatory period (1 min). right now, the only way we get our failed instance to be retried is to reset stats, and my understanding is that the way to do this is to change the service ids during the discovery refresh. but it does not have to.
anyway, I am going to do a PR for the nanos issue.

great, thank you!

it's up to load balancer to decide when to reuse an instance that failed. The serviceIds should be preserved to let LB get a chance to make that decision

so I understand this is a must to preserve those ids.
I put the code back.
however, least-response-time seems to be designed to never retry a previously failed instance (unless all other instances would fail).
is this correct?
is this by design (considered a characteristic of this load balancer), or a non optimal behavior that shall be fixed?
that would not work for me, because we would be loosing load balancing after the first failure. is that correct?

here is how the least-response-time works now: https://github.com/smallrye/smallrye-stork/pull/225
E.g. if your error-penalty is set to 60s, and declining-factor is 0.9, after another 60 other calls made, it's significance will be as if it was ca 100 ms response time at the most recent call.
So in time, the significance of the data collected in the past is lowered, hence even service instances that were failing, or had a long response time, a while back, will be retried in the future.

interesting. so if you have a high rate of outgoing calls (e.g. 20 per sec) the failed instance will be retried more often than if you have a low rate. I like better the predictable nature of the 1 minute penalty box, but this is not a big concern for me.
the ability to do automatic retries when possible (which means that the load balancer should be able to provide a list of prioritized eligible instances, and instruct on the situations where calls can be retried or not) is what I would be looking at next.
I am not an expert on MP fault tolerance, but one thing I would like to avoid is having all developers to annotate their @GET services with @Retry just because they know those services are idempotent as defined by the http spec. And even if we were asking them to do it, they would not know how many retries to set, because only the client side load balancing component knows how many instances are worth retrying.
I will expand those thoughts in https://github.com/smallrye/smallrye-stork/issues/232

in our own approach we got some inspiration from:

https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpRequestRetryExec.java
https://github.com/apache/httpcomponents-client/blob/master/httpclient5/src/main/java/org/apache/hc/client5/http/impl/DefaultHttpRequestRetryStrategy.java


Date AND Time picker combined?

Although UserDialogs supports a Date and a Time picker, it appears it does not support a DateTime picker combined. In order to leverage iOs' UIDatePicker's Mode property to set it to DateAndTime, I essentially have subclass UserDialogsImpl and provide my own PromptDateTimeAsync method.
So my question is, would you be open for a PR where I provide a PromptDateTime version?
Or is the issue that other platforms (Android, Windows Phone) don't natively support a datetime picker like iOs does?

I appreciate the offer, but iOS is really the only platform that would serve to benefit from this which means I have to respectfully decline.  If a piece of logic like that only hits one platform, it really defeats cross platform and the purpose of this plugin.  If it was something like a simple style ID or something, it would be different.

Yeah I was afraid that was the reason. Thanks for confirming.


HIVE-24804: RANGE with offset PRECEDING/FOLLOWING requires exactly one ORDER BY column

What changes were proposed in this pull request?
I just wanted to own the 2000th PR so created this. :)
Btw, throwing an exception if the user tries to use bounded range window without ORDER BY clause, similarly to Postgres.
the patch is basically only a check and throw:
        if (windowFrame.getWindowType() == WindowType.RANGE
            && (windowFrame.getStart().isBoundedNotCurrent()
                || windowFrame.getEnd().isBoundedNotCurrent())) {
          throw new SemanticException(
              "RANGE with offset PRECEDING/FOLLOWING requires exactly one ORDER BY column");
        }

all other changes are only formatting...WindowingSpec class was in very bad shape from formatting point of view, I think this was a good opportunity to clean it
Why are the changes needed?
Described in JIRA.
Does this PR introduce any user-facing change?
The exception in the mentioned use-case.
How was this patch tested?
Manually and with a negative test.

changed message to show "at least" instead of "exactly" because hive supports multiple ordering columns

merged, thanks @kasakrisz for the review!


phpBB 3.2.7 admin panel

Description
I'm running phpBB 3.2.7 on a shared hosting environment. The admin panel suddenly stopped working yesterday. Presumably, my hosting providers updated the rules.
Audit Logs / Triggered Rule Numbers
[Fri Sep 04 01:17:16.246929 2020] [:error] [pid 12571] [client IP:PORT] [client IP] ModSecurity: Warning. Pattern match "(?i)(?:\\\\x5c|(?:%(?:c(?:0%(?:[2aq]f|5c|9v)|1%(?:[19p]c|8s|af))|2(?:5(?:c(?:0%25af|1%259c)|2f|5c)|%46|f)|(?:(?:f(?:8%8)?0%8|e)0%80%a|bg%q)f|%3(?:2(?:%(?:%6|4)6|F)|5%%63)|u(?:221[56]|002f|EFC8|F025)|1u|5c)|0x(?:2f|5c)|\\\\/))(?:%(?:(?:f(?:(?:c%80|8)%8)?0%8 ..." at ARGS:redirect. [file "/dh/apache2/template/etc/mod_sec3_CRS/REQUEST-930-APPLICATION-ATTACK-LFI.conf"] [line "47"] [id "930100"] [msg "Path Traversal Attack (/../)"] [data "Matched Data: /../ found within ARGS:redirect: ./../adm/index.php"] [severity "CRITICAL"] [ver "OWASP_CRS/3.2.0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-lfi"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "OWASP_CRS/WEB_ATTACK/DIR_TRAVERSAL"] [hostname "HOST"] [uri "/forums/adm/index.php"] [unique_id "X1H4DKraMUZnlbZvnjyFVQAAAAM"], referer: https://HOST/forums/adm/index.php
[Fri Sep 04 01:17:16.247219 2020] [:error] [pid 12571] [client IP:PORT] [client IP] ModSecurity: Warning. Pattern match "(?:^|[\\\\/])\\\\.\\\\.(?:[\\\\/]|$)" at ARGS:redirect. [file "/dh/apache2/template/etc/mod_sec3_CRS/REQUEST-930-APPLICATION-ATTACK-LFI.conf"] [line "71"] [id "930110"] [msg "Path Traversal Attack (/../)"] [data "Matched Data: /../ found within ARGS:redirect: ./../adm/index.php"] [severity "CRITICAL"] [ver "OWASP_CRS/3.2.0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-lfi"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "OWASP_CRS/WEB_ATTACK/DIR_TRAVERSAL"] [hostname "HOST"] [uri "/forums/adm/index.php"] [unique_id "X1H4DKraMUZnlbZvnjyFVQAAAAM"], referer: https://HOST/forums/adm/index.php
[Fri Sep 04 01:17:16.247303 2020] [:error] [pid 12571] [client IP:PORT] [client IP] ModSecurity: Warning. Pattern match "(?:^|[\\\\/])\\\\.\\\\.(?:[\\\\/]|$)" at ARGS:redirect. [file "/dh/apache2/template/etc/mod_sec3_CRS/REQUEST-930-APPLICATION-ATTACK-LFI.conf"] [line "71"] [id "930110"] [msg "Path Traversal Attack (/../)"] [data "Matched Data: /../ found within ARGS:redirect: ./../adm/index.php"] [severity "CRITICAL"] [ver "OWASP_CRS/3.2.0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-lfi"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "OWASP_CRS/WEB_ATTACK/DIR_TRAVERSAL"] [hostname "HOST"] [uri "/forums/adm/index.php"] [unique_id "X1H4DKraMUZnlbZvnjyFVQAAAAM"], referer: https://HOST/forums/adm/index.php
[Fri Sep 04 01:17:16.258898 2020] [:error] [pid 12571] [client IP:PORT] [client IP] ModSecurity: Access denied with code 418 (phase 2). Operator GE matched 7 at TX:anomaly_score. [file "/dh/apache2/template/etc/mod_sec3_CRS/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "91"] [id "949110"] [msg "Inbound Anomaly Score Exceeded (Total Score: 15)"] [severity "CRITICAL"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-generic"] [hostname "HOST"] [uri "/forums/adm/index.php"] [unique_id "X1H4DKraMUZnlbZvnjyFVQAAAAM"], referer: https://HOST/forums/adm/index.php
[Fri Sep 04 01:17:16.259409 2020] [:error] [pid 12571] [client IP:PORT] [client IP] ModSecurity: Warning. Operator GE matched 7 at TX:inbound_anomaly_score. [file "/dh/apache2/template/etc/mod_sec3_CRS/RESPONSE-980-CORRELATION.conf"] [line "86"] [id "980130"] [msg "Inbound Anomaly Score Exceeded (Total Inbound Score: 15 - SQLI=0,XSS=0,RFI=0,LFI=15,RCE=0,PHPI=0,HTTP=0,SESS=0): individual paranoia level scores: 15, 0, 0, 0"] [tag "event-correlation"] [hostname "HOST"] [uri "/forums/adm/index.php"] [unique_id "X1H4DKraMUZnlbZvnjyFVQAAAAM"], referer: https://HOST/forums/adm/index.php

Your Environment
I'm using a shared hosting environment. The issue started yesterday, so I assume that DreamHost has updated the rules that are deployed to their servers.
Confirmation
[X] I have removed any personal data (email addresses, IP addresses,
passwords, domain names) from any logs posted.

There was a similar problem posted about a year or two back. The common thought is to add the following exclusions:
# ModSec Rule Exclusion: 930100 : Path Traversal Attack (/../)
SecRule REQUEST_URI "@beginsWith /forums/adm/index.php" "phase:2,nolog,pass,id:10000,ctl:ruleRemoveTargetById=930100;REQUEST_BODY"

# ModSec Rule Exclusion: 930110 : Path Traversal Attack (/../)
SecRule REQUEST_URI "@beginsWith /forums/adm/index.php" "phase:2,nolog,pass,id:10001,ctl:ruleRemoveTargetById=930110;REQUEST_BODY"

However these are not ideal as your forum may be located at forums, forum, community, phpBB, phpBB3.. etc. That could be improved by adding (forum|forums|community|phpbb|phpbb3) and perhaps a lowercase modifier. Is there any other way to identify the program running as phpBB?

Can you provide all POST and GET parameters?

Hi @rednoah, thanks for reporting. We have just merged support for phpBB. It will be in our next release (3.4.0) but it could take a while before that's released.
If you want to try it right now, it's easy:

Download https://raw.githubusercontent.com/coreruleset/coreruleset/v3.4/dev/rules/REQUEST-903.9007-PHPBB-EXCLUSION-RULES.conf and put it in your rules folder.
In your crs-setup.conf enable phpBB support by adding:

#SecAction \
 "id:900130,\
  phase:1,\
  nolog,\
  pass,\
  t:none,\
  setvar:tx.crs_exclusions_cpanel=0,\
  setvar:tx.crs_exclusions_dokuwiki=0,\
  setvar:tx.crs_exclusions_drupal=0,\
  setvar:tx.crs_exclusions_nextcloud=0,\
  setvar:tx.crs_exclusions_phpbb=1,\
  setvar:tx.crs_exclusions_wordpress=0,\
  setvar:tx.crs_exclusions_xenforo=0"

(And also keeping enabled other software that you use.)
For now, I will close this issue because I think it will most likely be resolved, but if you still experience problems, please comment and reopen it.


SMS Template Page - to just show Templates

SMS Template Page Required to show Templates
Warning -
We already showing all Templates wherever User can Send SMS
This Page is Different from Admin SMS Template page where Admin Creates Template

#332


Adjust css to auto adapt light/dark themes

Hello! Nice Plugin!
I made a little modifications for css: Use css variables rather than static colors, so that the color could adapt to light or dark themes, and make it more consistent with the overall theme color scheme.
Here is how it looks like before:

After:

Just discovered that if the image is smaller, it's gonna be hard to distinguish from button bg and note bg.
So changed the variable to background-secondary:

@Moyf  Hello!
Thanks for your fix color, it actually look nice =)
It looks like a bug. UI items must be on a picture.

I create a issue.


Bug/hide encrypted json

updated.

Coverage increased (+0.07%) to 93.446% when pulling 4c9e00c462c83e8973d6aeaa1a41bfc80c9dd6b5 on matiu:bug/hide-encrypted-json into 7d3eb1ae04932e4906e2fec24ee6fde293acada9 on bitpay:master.


add name to slo-controller-config cfg->NodeStrategies as selector alias

Ⅰ. Describe what this PR does
add name to slo-controller-config cfg->NodeStrategies as selector alias
see details https://github.com/koordinator-sh/koordinator/issues/1011

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm

/approve


Emit primitiveRestartEnable disabled warning only for strip topology.

Move check and warning to MVKRenderingCommandEncoderState.
Pass primitiveRestartEnable to MVKRenderingCommandEncoderState.
Warn only if primitiveRestartEnable disabled and strip topology is used.

Fixes issue #2045.

What about triangle fans?

What about triangle fans?

Good catch!
I had tried working that in, but because there is no Metal triangle fan topology value, I ended up having to double-track both Metal and Vulkan topology values in MVKRenderingCommandEncoderState, which felt like I was adding a bunch of confusing special-case-outlier code and tracking, all for an unenforceable warning message, so I dropped it.
Triangle fan restart will work (it's handled in the index conversion), but like strips in Metal, cannot be disabled. The app log just won't see a warning for TriStrips.