Implement Zstandard Compression for Smaller and Faster Updates

Issue: Enhance Bundle Compression with Zstandard
Hello CodePush Maintainers,
I am currently developing a React Native app utilizing CodePush for updates and have been exploring ways to optimize the update experience for our users. One significant factor that impacts the update process is the size and speed of the deployment bundles.
Suggestion: Zstandard Compression
After researching various compression algorithms, I suggest considering the integration of Zstandard (zstd) as an alternative to the existing ZIP compression method. Developed by Facebook, Zstandard offers several advantages:

Higher Compression Ratios: Zstandard can significantly reduce the bundle size compared to ZIP compression, potentially leading to smaller update payloads for end-users.
Faster Decompression Speed: Zstandard provides much faster decompression times, which could accelerate the update installation process and enhance the overall user experience.
Adjustable Compression Levels: It allows for a fine-tuned balance between compression ratio and speed, accommodating different deployment scenarios.

Benefits for CodePush:

Data Usage: Smaller update sizes would save users' data, which is particularly valuable for those on limited data plans.
Update Speed: Quicker decompression on the client side means faster update installations, making the process less intrusive.
User Experience: Enhanced update speed and reduced download sizes contribute to a smoother and more positive user experience.

I believe that adopting Zstandard could be a valuable enhancement for CodePush. I would love to hear your thoughts on this and discuss the feasibility of such an integration.
Thank you for considering this suggestion.

@sean5940 , thanks for reaching out! Since the standalone version of code-push-server is out, feel free to create a fork or contribution and implement this feature.


Week 2 fetch

I am not really sure how my old pull request got folded into this one. Everything is fine though.


Some aggregates.

Add aggregate normalization for lower-bounded count and sum.

Please address failing test cases in at.ac.tuwien.kr.alpha.solver.AggregatesTest.

All raised issues should be addressed now. Please have a look again.


some formatting can't be converted to PDF

Problem
Pages 10 (durable references) and 44/45 (common method properties table) of the PDF show some pieces of text as plain HTML instead of formatted properly.
Analysis
When running the make all locally, I get some errors:
...
docker run -v /home/pebermann/projektoj/restful-api-guidelines:/documents/ asciidoctor/docker-asciidoctor:latest asciidoctor \
  -D /documents/output index.adoc;
docker run -v /home/pebermann/projektoj/restful-api-guidelines:/documents/ asciidoctor/docker-asciidoctor:latest asciidoctor-pdf \
  -D /documents/output index.adoc;
asciidoctor: ERROR: failed to parse formatted text: https://infrastructure-api-repository.zalandoapis.com/ – used to refer to user defined, immutable API specification revisions published via the internal API repository.
asciidoctor: ERROR: failed to parse formatted text: https://opensource.zalando.com/restful-api-guidelines/{model.yaml} – used to refer to guideline defined re-usable API fragments (see {model.yaml} files in restful-api-guidelines/models for details).
asciidoctor: ERROR: failed to parse formatted text: ⚠ No, but SHOULD consider to design POST and PATCH idempotent
asciidoctor: ERROR: failed to parse formatted text: ⚠ May, but only if specific POST endpoint is safe. Hint: not supported by most caches.
asciidoctor: ERROR: failed to parse formatted text: ⚠ No, but SHOULD consider to design POST and PATCH idempotent
asciidoctor: ERROR: failed to parse formatted text: ⚠ No, but SHOULD consider to design POST and PATCH idempotent
asciidoctor: ERROR: failed to parse formatted text: ⚠ May, but only if specific POST endpoint is safe. Hint: not supported by most caches.
asciidoctor: ERROR: failed to parse formatted text: ⚠ No, but SHOULD consider to design POST and PATCH idempotent
mv -f output/index.pdf output/zalando-guidelines.pdf;
...

It looks like the HTML→PDF conversion did break here somehow?
The only thing I can see which those have in common is that some more or less complicated HTML is included via a {...} directive into the actual code here.

I checked this before and back than I found no serious consequences based on this warning for the created pdf-file, so I decided to ignore it.

Yeah, but it has the effect that on two pages the formatting is broken. (The ERRORs are just a symptom which might help identify the problem.)

The icons in front of the Yes/No are broken too, but that seems to be a separate issue and not related to these ERRORs.

If fixing this issue turns out to be not straightforward (asciidoc update?), then we do not further support pdf generation / download option.

The table for rule 149 is fixed, but the link in rule in rule 234 is still broken.


Move to ROCm 6.0 sources , bump minor version to 2

changes to move to rocm 6.0 sources
bumps version to 18.0-2

Seems to work for me

Is there any plan to tag AOMP 18.0-1 or is AOMP 18.0-2 the next target? It would be great to have a release of it since it includes several fixes for OMPT and would be the first release where almost everything regarding device tracing works.

[AMD Official Use Only - General]
I believe we are going to produce a 18.0-1 sometime this week
From: Jan André Reuter @.>
Sent: Tuesday, January 9, 2024 10:27 AM
To: ROCm/aomp @.>
Cc: Lieberman, Ron @.>; State change @.>
Subject: Re: [ROCm/aomp] Move to ROCm 6.0 sources , bump minor version to 2 (PR #763)
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Is there any plan to tag AOMP 18.0-1 or is AOMP 18.0-2 the next target? It would be great to have a release of it since it includes several fixes for OMPT and would be the first release where almost everything regarding device tracing works.
—
Reply to this email directly, view it on GitHubhttps://github.com/ROCm/aomp/pull/763#issuecomment-1883261222, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD3EYZ7GLHF7KORRKTCZTNDYNVOTRAVCNFSM6AAAAABAX3ML7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBTGI3DCMRSGI.
You are receiving this because you modified the open/close state.Message ID<EMAIL_ADDRESS>


Obsidian hotkeys don't work while custom frame has focus

Possibly related to #59. Hotkeys like "Focus on last note" don't work if a website in the custom frame has focus. For example, in the custom frame, if the focus is in a text input box, I cannot use cmd + 1 which I have set to "focus on last note".  Other examples include "Create new note" and "Search: Search in all files". If the last user actions were in the top bar in the custom frame, then Obsidian hotkeys are not overridden. I tried other key combinations like control + option + j, but it seems the website in the custom frame hijacks globally every possible Obsidian hotkey.

This is related to #49, and essentially has the same problems and potential fixes.


Allow rendering when using Filesystem source

What problem are you facing?

When using filesystem source, it's not possible as stated in the README to use crossplane beta render.
At this point the only workaround is to use inline source.
How could this Function help solve your problem?

It would be nice to allow mounting a volume (bind mount?) to access the actual template files or alternatively read from a YAML file containing a configMap.

Relates to #54


LDAPSocketReceiveError (timeout config to 70sec)

Someone facing this issue?
My command was
bloodhound-python -u  --hashes <>:<> -c all -d DOMAIN.COM --dns-tcp --dns-timeout 70 -ns DC.DOMAIN.COM -v
(I check the user and NTLM with Impact and its work great)
DEBUG: Authenticating to LDAP server
Traceback (most recent call last):
  File "c:\python27\lib\runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "c:\python27\lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "C:\Python27\Scripts\bloodhound-python.exe\__main__.py", line 7, in <module>
  File "c:\python27\lib\site-packages\bloodhound\__init__.py", line 300, in main
    timestamp=timestamp)
  File "c:\python27\lib\site-packages\bloodhound\__init__.py", line 73, in run
    self.pdc.prefetch_info('objectprops' in collect, 'acl' in collect)
  File "c:\python27\lib\site-packages\bloodhound\ad\domain.py", line 393, in prefetch_info
    self.get_objecttype()
  File "c:\python27\lib\site-packages\bloodhound\ad\domain.py", line 223, in get_objecttype
    self.ldap_connect()
  File "c:\python27\lib\site-packages\bloodhound\ad\domain.py", line 69, in ldap_connect
    baseDN=self.ad.baseDN, protocol=protocol)
  File "c:\python27\lib\site-packages\bloodhound\ad\authentication.py", line 78, in getLDAPConnection
    if not conn.bind():
  File "c:\python27\lib\site-packages\ldap3\core\connection.py", line 671, in bind
    self.refresh_server_info()
  File "c:\python27\lib\site-packages\ldap3\core\connection.py", line 1427, in refresh_server_info
    self.server.get_info_from_server(self)
  File "c:\python27\lib\site-packages\ldap3\core\server.py", line 525, in get_info_from_server
    self._get_schema_info(connection)
  File "c:\python27\lib\site-packages\ldap3\core\server.py", line 489, in _get_schema_info
    get_operational_attributes=True
  File "c:\python27\lib\site-packages\ldap3\core\connection.py", line 853, in search
    response = self.post_send_search(self.send('searchRequest', request, controls))
  File "c:\python27\lib\site-packages\ldap3\strategy\sync.py", line 178, in post_send_search
    responses, result = self.get_response(message_id)
  File "c:\python27\lib\site-packages\ldap3\strategy\base.py", line 355, in get_response
    responses = self._get_response(message_id, timeout)
  File "c:\python27\lib\site-packages\ldap3\strategy\sync.py", line 196, in _get_response
    responses = self.receiving()
  File "c:\python27\lib\site-packages\ldap3\strategy\sync.py", line 99, in receiving
    raise communication_exception_factory(LDAPSocketReceiveError, type(e)(str(e)))(self.connection.last_error)
ldap3.core.exceptions.LDAPSocketReceiveError: error receiving data: timed out

Same. Would appreciate if someone found the cause/solution.


Support encrypted private keys

Some private key formats are not supported by either openssl (eg. Ed25519) or by its PHP binding (eg. ecdsa-sha2-*), so we currently handle them ourselves.
This works quite well except for encrypted keys which we do not support yet.
The goal of this ticket is to add support for such keys.

This is a follow-up issue on #18 & #29.


odd-numbered scale factors snap incorrectly

can't say i ever tried it but yeah that's busted

fixed in https://github.com/zero01101/openOutpaint/commit/89c759876740788b217f0dd8f7cc2f64af5d34a7

uh maybe try actually generating an image with an odd-numbered scale factor instead of just observing the reticle because it's still super broken and trying to snap() the mouseDown rect is making things much worse

fixed in https://github.com/zero01101/openOutpaint/commit/28ac3e2fb06e07e7c85e752b135c86478a7212f3


Installer refactor + getPrefix()

This rewrites the toplevel installer such that it uses object+method style instead of a bunch of toplevel functions. This is mainly useful so we can keep installer state over time: for example, I plan on using this to keep a "logical tree" around that I can use so scripts run in their logical dependency order.
As a bonus, this also pulls in get-prefix so we calculate the installer prefix using the same logic as npm.

Coverage decreased (-21.5%) to 74.497% when pulling 5195d695e15ac3ff7ada82df84a4a837f9d03068 on zkat/refactor into f631203db7247b431986d780e9cf0d214a87590b on latest.

Coverage decreased (-21.5%) to 74.497% when pulling 5195d695e15ac3ff7ada82df84a4a837f9d03068 on zkat/refactor into f631203db7247b431986d780e9cf0d214a87590b on latest.

Coverage decreased (-21.5%) to 74.497% when pulling c7d44b5c7fa90cb2c4b1d9fc5708281ceebace37 on zkat/refactor into f631203db7247b431986d780e9cf0d214a87590b on latest.

Coverage increased (+1.4%) to 97.315% when pulling 2c5f8b29c8f6db3e0e8b04381b4d06870d87a3bc on zkat/refactor into f631203db7247b431986d780e9cf0d214a87590b on latest.

Shucks, I wish I knew about tacks before making my own, essentially. Looks good!


Add Workflow Manager React Plugin

This PR links with the JIRA Issue OODT-1016
This PR contains:
Workflow Listing Component which is capable of Stop/Resume/Pause workflow instances

@NGimhana This is ready to be merged right?

Yes. It is ready to be merged


add detail log when failed to send a http request

What type of PR is this?

/kind enhancement
What this PR does / why we need it:
add detail log when failed to send a http request
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/assign @fisherxu

/close

/reopen

/lgtm

/lgtm
/approve


Fix bugs in compose stop and restart

In both command the timeout arg is --timeout, -t while the underlying command (nerdctl restart/stop) uses --time, -t. Change to use -t when constructing the underlying command. Also fix a pointer deference bug.
Fix them and add testcases.
Signed-off-by: Jin Dong<EMAIL_ADDRESS>

@djdongjin why are you pushing to use -t for both compose and nerdctl when it invokes stop/start ?
they are two different commands though, no direct link between them!

@djdongjin why are you pushing to use -t for both compose and nerdctl when it invokes stop/start ?
they are two different commands though, no direct link between them!

I'm not pushing to use -t for both (or for either nerdctl or compose) :) . Here I only changed the compose part (no change to nerdctl) to fix the naming bug.
The same argument in nerdctl compose and nerdctl (in terms of functionality, i.e., time to wait before sending SIGKILL) has different names (--timeout, -t in nerdctl/docker compose v.s. --time, -t in nerdctl/docker) (docker compose: stop, restart; docker: stop, restart, same in nerdctl).
I didn't notice this naming difference previously, so if we pass --timeout from nerdctl compose to nerdctl it has errors (nerdctl stop/restart don't have such arg). So this PR is to fix this. I changed --timeout to -t when nerdctl compose stop/restart invoke nerdctl stop/restart.
That being said, I'm okay with either full name (--time) or short name (-t) when compose stop/restart pass to nerdctl stop/restart. I can change to --time if that's preferred :)
Please lmk if I miss anything or my understanding is not correct.
Thanks.

@djdongjin why are you pushing to use -t for both compose and nerdctl when it invokes stop/start ?
they are two different commands though, no direct link between them!

I'm not pushing to use -t for both (or for either nerdctl or compose) :) . Here I only changed the compose part (no change to nerdctl) to fix the naming bug.
The same argument in nerdctl compose and nerdctl (in terms of functionality, i.e., time to wait before sending SIGKILL) has different names (--timeout, -t in nerdctl/docker compose v.s. --time, -t in nerdctl/docker) (docker compose: stop, restart; docker: stop, restart, same in nerdctl).
I didn't notice this naming difference previously, so if we pass --timeout from nerdctl compose to nerdctl it has errors (nerdctl stop/restart don't have such arg). So this PR is to fix this. I changed --timeout to -t when nerdctl compose stop/restart invoke nerdctl stop/restart.
That being said, I'm okay with either full name (--time) or short name (-t) when compose stop/restart pass to nerdctl stop/restart. I can change to --time if that's preferred :)
Please lmk if I miss anything or my understanding is not correct.
Thanks.

thank you for the details. I think it is better to change to --time to highlight this diff for readers and avoid confusing

thank you for the details. I think it is better to change to --time to highlight this diff for readers and avoid confusing

Thanks for the suggestion! yeah it's a little confusing 😅. updated to use --time and add comment to highlight the diff :)


fix(package.json): fix dependency graph

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Document possible unit values in date_diff() documentation

Today the date_diff() docs are very vague.

list possible unit values
provide some examples

@findepi  Possible values of 'unit' are defined in the documentation https://prestodb.github.io/docs/current/functions/datetime.html, just above date_add function under "Interval Functions" heading
Is that what you are asking or something else?

@Anurag870 thanks for checking this!
When you start reading docs from a link like https://prestodb.github.io/docs/current/functions/datetime.html#date_diff it's not that obvious, because unit description is not initially visible.
Still would be good to add some examples, I will edit this issue.


⚠ ClamAV has degraded performance

In 395e28c, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 451 ms

Resolved: ClamAV performance has improved in 2a1a2c1.


Work pagev2

Ref #3705
Renders the data using the MetaUnit component for consistent spacing and typography

That makes sense, but I might do that if/when they do start evolving differently. If that's cool with you?

That makes sense, but I might do that if/when they do start evolving differently. If that's cool with you?

I wonder if it's the fact that things are still a bit nunjucksy in the component that's confusing me, and feels anti-paradigmatic to general React component structure, where we have:
renderParagraphs(text), renderLinksList(links), renderList(list)
Could we rather have something like:
<Paragraphs text={text} />
<Paragraphs text={text} />


Admin Setting features part 2

This is a list of all things missed from doing the initial Admin Settings feature.
Edit this list issue in place to add more possible items.
Not all of the things listed here will be done, it's just more of a brainstorming/way of tracking possible features.

Have way to add New Sender and Receiver Settings, not just clone.

This should be a giant TextArea where new json can be pasted in.
Captured in this story

JSON diff on save is probably a bigger deal.

might be partly be addressed by 3970  as well, as we are considering making the JSON diff page the default way to update AND create new settings

Allow editing of the top-most Setting for Org.

Back button missing from top-most Setting for Org

Some text values that only allow a subset of valid string constants should be dropdowns.

Error notify toast UI doesn't fit. Make dialog bigger and add close box.

Show json diff of before/after before saving setting.

Fix  layout so it resizes on mobile correctly.

Future: Show history of edits (API addition)

Related to #3433

@sethdarragile6 Is the brainstorming list in priority order? If not, can we prioritize the list based on Mo's needs?
cc: @rachelhanster

@sethdarragile6 Is the brainstorming list in priority order? If not, can we prioritize the list based on Mo's needs? cc: @rachelhanster

It pretty much is in priority order already (that's probably intentional, thanks @TomNUSDS ). I added a couple notes to the above regarding 3970. The rest of the list are mostly in priority order and just small things- so perhaps we can group some of the smaller things into one story.

@sethdarragile6 can you break this story up into individual tickets for the "must haves" so that we can look at during the next refinement

@sethdarragile6 can you break this story up into individual tickets for the "must haves" so that we can look at during the next refinement

@loripusey this is done now, sorry for the delay. Must-haves boil down to

#3970
#4121
#4122

closing, this was just a scratchpad to gather input for stories which have already been created.


nixos: add configuration for firewalld

Description of changes
Add new module to allow for configuration of firewalld.
This PR contains a couple auxiliary fixes:

nftables: Fixed python module default SO import path.
firewalld: Fixed firewall-applet and networkmanager integration.

I can split this into other PRs if that's desired.
TODO (in a future PR, maybe):

Add an option to allow for overlaying extra default configurations. NetworkManager is known to ship with a zone configuration (disabled by default on NixOS, though).
Patch firewalld to let it load base config from the default config directory (ie. /lib/firewalld/firewalld.conf). This should allow for services.firewalld.config to be used in tandem with ordinary user configs.

Fixes #165882
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@lukegb Please help me write tests for nftables python module :P

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1813

Will this get merged or is a new PR necessary?

Some of this was already merged, but it still needs more work. Here's the overlay I apply to get a working firewalld:
  firewalld = prev.firewalld.overrideAttrs (old: {
    # Patch /usr/lib, and fix typo in nm-connection-editor
    postPatch = ''
      substituteInPlace src/firewall/config/__init__.py.in \
        --replace "/usr/share" "$out/share" \
        --replace "/usr/lib/" "/run/current-system/sw/lib/"

      for file in config/firewall-{applet,config}.desktop.in; do
        substituteInPlace $file \
          --replace "/usr/bin/" "$out/bin/"
      done
      substituteInPlace src/firewall-applet.in \
        --replace "/usr/bin/nm-connection-editor" "${final.networkmanagerapplet}/bin/nm-connection-editor"
    '';
    # Make NM available for gobject-introspection
    buildInputs = old.buildInputs ++ [final.networkmanager];
    # Fix applet executable
    nativeBuildInputs = old.nativeBuildInputs ++ [final.libsForQt5.wrapQtAppsHook];
    dontWrapQtApps = true;
    preFixup = old.preFixup + ''
      makeWrapperArgs+=("''${qtWrapperArgs[@]}")
    '';
  });

I'm closing this PR to signal that I'm not planning to work on this anytime soon.
If anyone is interested, feel free to make a new PR based off the work done here.

Some of this was already merged, but it still needs more work. Here's the overlay I apply to get a working firewalld:
  firewalld = prev.firewalld.overrideAttrs (old: {
    # Patch /usr/lib, and fix typo in nm-connection-editor
    postPatch = ''
      substituteInPlace src/firewall/config/__init__.py.in \
        --replace "/usr/share" "$out/share" \
        --replace "/usr/lib/" "/run/current-system/sw/lib/"

      for file in config/firewall-{applet,config}.desktop.in; do
        substituteInPlace $file \
          --replace "/usr/bin/" "$out/bin/"
      done
      substituteInPlace src/firewall-applet.in \
        --replace "/usr/bin/nm-connection-editor" "${final.networkmanagerapplet}/bin/nm-connection-editor"
    '';
    # Make NM available for gobject-introspection
    buildInputs = old.buildInputs ++ [final.networkmanager];
    # Fix applet executable
    nativeBuildInputs = old.nativeBuildInputs ++ [final.libsForQt5.wrapQtAppsHook];
    dontWrapQtApps = true;
    preFixup = old.preFixup + ''
      makeWrapperArgs+=("''${qtWrapperArgs[@]}")
    '';
  });

the modules were merged? i don't see any in nixos options

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/firewalld-systemd-service/49129/8


Plain models are not calling callbacks when cached

System Info
pip freeze | grep langchain
langchain==0.0.268
langchainplus-sdk==0.0.17

Who can help?
@hwchase17 @agola11
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[X] Callbacks/Tracing
[ ] Async

Reproduction
from typing import Any, Dict, List

import langchain
from langchain.cache import SQLiteCache
from langchain.callbacks.base import BaseCallbackHandler
from langchain.chat_models import ChatVertexAI
from langchain.llms import VertexAI
from langchain.schema import HumanMessage

langchain.llm_cache = SQLiteCache(database_path="langchain-llm-cache.db")

class CallbackHandler(BaseCallbackHandler):
    run_inline = True

    def __init__(self, logger=None):
        self.messages = []

    def on_llm_start(self, serialized: Dict[str, Any], prompts: List[str], run_id, parent_run_id, **kwargs: Any) -> Any:
        self.messages.append(run_id)

callback = CallbackHandler()
bison_text_llm = VertexAI(model_name="text-bison@001", temperature=0.0, max_output_tokens=500, callbacks=[callback])
bison_chat_llm = ChatVertexAI(model_name="chat-bison@001", temperature=0.0, max_output_tokens=500, callbacks=[callback])

bison_chat_llm([HumanMessage(content="Hello, how are you?")])
assert len(callback.messages) == 1
bison_chat_llm([HumanMessage(content="Hello, how are you?")])
assert len(callback.messages) == 2

bison_text_llm("Hello, how are you?")
assert len(callback.messages) == 3
bison_text_llm("Hello, how are you?")
assert len(callback.messages) == 4

Expected behavior
It's unclear to me whether callbacks should be called when call is cached, but we can see that chat and plain text models implement different behaviour.
Ideally, callbacks would be called, with a flag saying that call is cached.

@dosu-bot
What about adding a new event like on_llm_cached?
Maybe it will be simpler to implement?

Hey @dmytro-karpovych-maxa as of now Dosu only responds to the author of issues. This may change in the future.
Let me know if you have any feature requests or ideas for Dosu!

@devstein It's not so critical
what about having one more event to track cached LLM calls?

Sounds good to me, given that these requests are behaving quite differently (e.g. streaming LLMs won't call callbacks etc).

This issue is still relevant.


Qusetion about hardware

Hello:
Can you provide hardware code?

Sorry, we currently don't have the plan to release the hardware code. This hardware code targets to run the shiftresnet on Amazon F1 cloud FPGA, which shares a similar structure and architecture as our design. This could be a good reference to look at.
Thanks!


Update README.md

Good catch @nivla !

@nivla can you recreate this PR but merging into develop branch instead of master?

Of course :D

Thanks @nivla! I have also changed the default branch to develop so the process of creating PR and commits will be more straightforward.


Gal.open() on Samsung device

On Android, when we call the Gal.open() command the user is presented with a list of gallery application to open with.
If the user selects the Samsung Gallery app then they are shown a 'blank tile/missing file'.

Tested on
Samsung S22 Android 14.

I don't have that device so can't test it, please consider submitting a PR.

I have teh same problem

any updates?

I have the same problem. Samsung a54 256gb

I have researched this issue.
First, there is no way to always transition to the home of the Photos app on Android. This is because it depends on that Photos app. For example, Google Photos works fine.
On top of that, there is a way to open individual photos instead of home, but you need to get the path, and to get the path you need read permission as well as write permission.


Detect and recognize meter reading

Hi, First of all, Thank you for the great project!
I would like to use it to detect and recognize the electric meter reading, is it possible using this library ?

Sure, that's probably a good use case, though you will probably benefit from fine-tuning the detector and recognizer on a custom dataset. Closing for now since this is not a bug.


cannot reproduce your learning curve

Hi, I tried to train resnet-20 using your prototxts, but failed to reproduce your learning curve. For example, when iter_num = 10,000, my test accuracy is still around 0.8. May you please also share your training logs? Thanks a lot!

https://github.com/yihui-he/resnet-cifar10-caffe/blob/master/resnet-20/logs/resnet-20__2016-08-14_00-25-56.log

I see. you used 4 GPUs. So your actual batch_size is 128*4.
BTW, I have another question regarding the prototxt, should there be a ReLU layer after each Eltwise SUM layer?

see the official ResNet50
https://github.com/KaimingHe/deep-residual-networks/blob/master/prototxt/ResNet-50-deploy.prototxt
`
layer {
bottom: "res2a_branch1"
bottom: "res2a_branch2c"
top: "res2a"
name: "res2a"
type: "Eltwise"
}
layer {
bottom: "res2a"
top: "res2a"
name: "res2a_relu"
type: "ReLU"
}
`

(1) that's a big mistake I didn't realize!
(2) You are right. However, the performance is better without ReLU on CIFAR-10.


OAuth2 provider that requires basic authorization to get access token

After trying to get django-all-access to work with the OAuth2 server of FIWARE lab, I found out that it was expecting an Authorization key in the header of the POST request that gets the access token (I was getting a 405 error). I managed to get it working by passing the following header to the request made in get_access_token in OAuth2Client:
headers = {'Authorization' : 'Basic ' + base64.b64encode(str(self.provider.consumer_key) + ':' + str(self.provider.consumer_secret))}
response = self.request('post', self.provider.access_token_url, data=args, headers=headers)

Not sure how it would be the best way to patch the code to make it more general (I have no idea if this may cause problems with other providers or if more kinds of authorizations should be included). I hope this helps.

You can configure the callback view to use a custom client for this provider which overrides get_access_token. Nothing to patch in django-all-access. These are already available customization hooks.

Cool thanks!


List of files modified during watch cycle is now accessible to plugins

The motivation behind this PR is discussed in issue #9632, but to recap, before the only way to find out which changed files triggered a re-compilation was to use WatchPack's mtimes variable, but this variable has been removed since WatchPack 2.0.0 (beta), so this PR provides a replacement way of getting access to this list of changed files.
What kind of change does this PR introduce?
This PR adds a property to the compiler to expose the files modified during watch mode. It also fixes the test for removed files (RemoveFiles.test.js) and adds a new test ModifiedFiles.test.js
Did you add tests for your changes?
Yes, in ModifiedFiles.test.js
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
the new compiler property modifiedFiles should be documented (though note that removedFiles isn't documented either). Also, it's important to note that currently, modifiedFiles includes all removed files. This is due to this line of NodeWatchFileSystem, which was introduced before my PR.

Looks good, I can merge it once you signed the CLA: https://cla.js.foundation/webpack/webpack?pullRequest=9679

@sokra sorry I had to double check with some people about the CLA but I just signed it!

@maxwoo-houzz CLA problem fixed

@sokra Is this relative to webpack@5 ? As I understand plugins must use FileSystemInfo API

@sokra, will this find it's way into the next beta or does it need some more work? webpack-contrib/stylelint-webpack-plugin#190 seems to depend on it.
Thanks a lot for looking into this!

@sokra, will this find it's way into the next beta or does it need some more work? webpack-contrib/stylelint-webpack-plugin#190 seems to depend on it.
Thanks a lot for looking into this!

It's done, just forgot to merge it...

/cc @sokra

It's done, just forgot to merge it...
Thanks! :D

It's done, just forgot to merge it...
Thanks! :D

CI is broken now... Working on it...

Thanks

@sokra thanks for all those fixes, I couldn't really figure out what the problem was so I'm glad you got it sorted!


Failed to startup after fresh flash.

I am using the "Espressif ESP32 Development Board - Developer Edition" dev board to test it out, and I cloned this repo, the idf repo, and downloaded the toolchain as it says in the instructions. I do a "make flash" and keep the menuconfig as default. It flashes successfully, but when I connect to it via serial it keeps failing and rebooting. The first poweron_reset is due to me pressing the reset button, the rest is it rebooting itself. (Same stuff after the "Rebooting...") Have I done something wrong? Am I supposed to do some configuration voodoo to make this work? If so, can someone point me to the correct docs?
rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
ets Jun  8 2016 00:22:57

rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0x00
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0008,len:8
load:0x3fff0010,len:3464
load:0x40078000,len:7828
load:0x40080000,len:252
entry 0x40080034
[0;32mI (43) boot: ESP-IDF v2.0-rc1-257-g4745895 2nd stage bootloader[0m
[0;32mI (44) boot: compile time 14:16:11[0m
[0;32mI (44) boot: Enabling RNG early entropy source...[0m
[0;32mI (64) boot: SPI Speed      : 40MHz[0m
[0;32mI (77) boot: SPI Mode       : DIO[0m
[0;32mI (89) boot: SPI Flash Size : 4MB[0m
[0;32mI (102) boot: Partition Table:[0m
[0;32mI (113) boot: ## Label            Usage          Type ST Offset   Length[0m
[0;32mI (136) boot:  0 phy_init         RF data          01 01 0000f000 00001000[0m
[0;32mI (159) boot:  1 ota_0            OTA app          00 10 00010000 000ea000[0m
[0;32mI (182) boot:  2 nvs              WiFi data        01 02 000fa000 00016000[0m
[0;32mI (205) boot:  3 ota_1            OTA app          00 11 00110000 000ea000[0m
[0;32mI (229) boot:  4 otadata          OTA data         01 00 001fd000 00003000[0m
[0;32mI (252) boot: End of partition table[0m
[0;32mI (265) boot: Disabling RNG early entropy source...[0m
[0;32mI (282) boot: Loading app partition at offset 00010000[0m
[0;32mI (1449) boot: segment 0: paddr=0x00010018 vaddr=0x00000000 size=0x0ffe8 ( 65512) [0m
[0;32mI (1450) boot: segment 1: paddr=0x00020008 vaddr=0x3f400010 size=0x19cf8 (105720) map[0m
[0;32mI (1467) boot: segment 2: paddr=0x00039d08 vaddr=0x3ffb0000 size=0x02144 (  8516) load[0m
[0;32mI (1497) boot: segment 3: paddr=0x0003be54 vaddr=0x40080000 size=0x00400 (  1024) load[0m
[0;32mI (1520) boot: segment 4: paddr=0x0003c25c vaddr=0x40080400 size=0x1a70c (108300) load[0m
[0;32mI (1598) boot: segment 5: paddr=0x00056970 vaddr=0x400c0000 size=0x00034 (    52) load[0m
[0;32mI (1599) boot: segment 6: paddr=0x000569ac vaddr=0x00000000 size=0x0965c ( 38492) [0m
[0;32mI (1615) boot: segment 7: paddr=0x00060010 vaddr=0x400d0018 size=0x78e70 (495216) map[0m
[0;32mI (1643) heap_alloc_caps: Initializing. RAM available for dynamic allocation:[0m
[0;32mI (1665) heap_alloc_caps: At 3FFBA668 len 00025998 (150 KiB): DRAM[0m
[0;32mI (1686) heap_alloc_caps: At 3FFE8000 len 00018000 (96 KiB): D/IRAM[0m
[0;32mI (1708) heap_alloc_caps: At 4009AB0C len 000054F4 (21 KiB): IRAM[0m
[0;32mI (1728) cpu_start: Pro cpu up.[0m
[0;32mI (1740) cpu_start: Single core mode[0m
[0;32mI (1753) cpu_start: Pro cpu start user code[0m
[0;32mI (1814) cpu_start: Starting scheduler on PRO CPU.[0m
[0;31mE (1820) uart: uart_wait_tx_done(703): uart driver error[0m
[0;32mI (1820) uart: queue free spaces: 10[0m
heap:227152

E (1825) wifi: esp_wifi_set_storage 1231 wifi is not init
E (1831) wifi: invalid magic number 2, call WIFI_INIT_CONFIG_DEFAULT to init config
E (1838) wifi: wifi_init 1230 ret=258
assertion "0 && "esp_wifi_init(&cfg)"" failed: file "/home/xcg/workspace/esp_iot_at/esp-at-application/components/esp-at-core/./at_port.c", line 560, function: initialise_wifi
abort() was called at PC 0x400f774f
Guru Meditation Error: Core  0 panic'ed (abort)

Backtrace: 0x40008155:0x3ffbbee0 0x40007d16:0x3ffbbf00 0x40111acf:0x3ffbbf30 0x4011227a:0x3ffbbf60 0x4010d288:0x3ffbbfa0 0x4010cdb2:0x3ffbbfe0 0x400d0b2d:0x3ffbc000

Rebooting...

Hi, robbym, I had the same problem, and finally I solved the problem by pointing ESP_IDF to commit 7eaf1c76dc281c37075f8a8dac34cc3e09669f59, I guess the problem is that they add some parameters in the ESP_IDF of esp_wifi, resulting in the failure to compile.

Hi yake827, pointing to that commit fixed the problem. Thank you!
However, after it boots up, it doesn't respond to AT commands:
ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
ets Jun  8 2016 00:22:57

rst:0x10 (RTCWDT_RTC_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0x00
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0008,len:8
load:0x3fff0010,len:3488
load:0x40078000,len:7548
load:0x40080000,len:252
entry 0x40080034
[0;32mI (43) boot: ESP-IDF v2.0-rc1-82-g7eaf1c7 2nd stage bootloader[0m
[0;32mI (43) boot: compile time 17:51:18[0m
[0;32mI (44) boot: Enabling RNG early entropy source...[0m
[0;32mI (63) boot: SPI Speed      : 40MHz[0m
[0;32mI (76) boot: SPI Mode       : DIO[0m
[0;32mI (88) boot: SPI Flash Size : 4MB[0m
[0;32mI (101) boot: Partition Table:[0m
[0;32mI (112) boot: ## Label            Usage          Type ST Offset   Length[0m
[0;32mI (135) boot:  0 phy_init         RF data          01 01 0000f000 00001000[0m
[0;32mI (158) boot:  1 ota_0            OTA app          00 10 00010000 000ea000[0m
[0;32mI (181) boot:  2 nvs              WiFi data        01 02 000fa000 00016000[0m
[0;32mI (205) boot:  3 ota_1            OTA app          00 11 00110000 000ea000[0m
[0;32mI (228) boot:  4 otadata          OTA data         01 00 001fd000 00003000[0m
[0;32mI (251) boot: End of partition table[0m
[0;32mI (264) boot: Disabling RNG early entropy source...[0m
[0;32mI (281) boot: Loading app partition at offset 00010000[0m
[0;32mI (1425) boot: segment 0: paddr=0x00010018 vaddr=0x00000000 size=0x0ffe8 ( 65512) [0m
[0;32mI (1426) boot: segment 1: paddr=0x00020008 vaddr=0x3f400010 size=0x19a50 (105040) map[0m
[0;32mI (1443) boot: segment 2: paddr=0x00039a60 vaddr=0x3ffb0000 size=0x020f0 (  8432) load[0m
[0;32mI (1473) boot: segment 3: paddr=0x0003bb58 vaddr=0x40080000 size=0x00400 (  1024) load[0m
[0;32mI (1496) boot: segment 4: paddr=0x0003bf60 vaddr=0x40080400 size=0x1d210 (119312) load[0m
[0;32mI (1579) boot: segment 5: paddr=0x00059178 vaddr=0x400c0000 size=0x00034 (    52) load[0m
[0;32mI (1580) boot: segment 6: paddr=0x000591b4 vaddr=0x00000000 size=0x06e54 ( 28244) [0m
[0;32mI (1596) boot: segment 7: paddr=0x00060010 vaddr=0x400d0018 size=0x74d54 (478548) map[0m
[0;32mI (1624) heap_alloc_caps: Initializing. RAM available for dynamic allocation:[0m
[0;32mI (1646) heap_alloc_caps: At 3FFBA640 len 000259C0 (150 KiB): DRAM[0m
[0;32mI (1667) heap_alloc_caps: At 3FFE8000 len 00018000 (96 KiB): D/IRAM[0m
[0;32mI (1689) heap_alloc_caps: At 4009D610 len 000029F0 (10 KiB): IRAM[0m
[0;32mI (1710) cpu_start: Pro cpu up.[0m
[0;32mI (1721) cpu_start: Single core mode[0m
[0;32mI (1734) cpu_start: Pro cpu start user code[0m
[0;31mE (2131) phy_init: PHY data partition validated[0m
[0;32mI (2494) phy: phy_version: 258, Nov 29 2016, 15:51:07, 0, 0[0m
[0;32mI (2495) cpu_start: Starting scheduler on PRO CPU.[0m
[0;31mE (2501) uart: uart_wait_tx_done(703): uart driver error[0m
[0;32mI (2507) uart: queue free spaces: 10[0m
heap:224496

E (2512) wifi: esp_wifi_set_storage 1218 wifi is not init
I (2518) wifi: frc2_timer_task_hdl:3ffc43ac, prio:22, stack:2048
I (2527) wifi: Init lldesc rx mblock:25
I (2527) wifi: Init lldesc rx ampdu len mblock:7
I (2531) wifi: Init lldesc rx ampdu entry mblock:4
I (2535) wifi: pp_task_hdl : 3ffd11bc, prio:23, stack:8192
I (2541) wifi: mode : softAP (24:0a:c4:05:b5:b9)
I (2547) wifi: mode : sta (24:0a:c4:05:b5:b8) + softAP (24:0a:c4:05:b5:b9)
I (2553) wifi: mode : softAP (24:0a:c4:05:b5:b9)

Notice the "[0;31mE (2501) uart: uart_wait_tx_done(703): uart driver error[0m".
Is this why? I am obviously able to connect to it via uart, but it throws an error?

There may be internal conditions are not met, since it can be controlled through uart,  ignore it maybe a good choice. :)

@robbym ,We have fixed the bug,and you could try it using the latest code.Thanks.


Updated exports as it should be today :)

Coverage remained the same at 100.0% when pulling 6d5675ef6546d2af65141cb56b110355398f2388 on removing-checks-around-exports into 48d013c71fb3a7fc2f9a87cd056581eb1a9743b2 on master.


[Blog] OpenSearch Dashboards: A snapshot of the current usability

Description
Publishes blog to update open source community about Dashboards usability study and findings.
Issues Resolved
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.

For visibility cc: @hdhalter @apasun

@vagimeli LGTM with a minor deletion. @pajuric This is ready to be published once the deletion is pushed. Thanks!

Thanks @natebower. Accepted and pushed. @pajuric It's ready for you.

Should we close this one and continue with https://github.com/opensearch-project/project-website/pull/1934 ?


Updated jcef to latest version and KCEF for improved custom request context handler

@DatL4g Great Job! Thank you so much!

@DatL4g One issue I encountered is that you are using the KCEFResourceRequestHandler for request interception. However, it only has the onBeforeResourceLoad method, which will be called multiple times for a single URL request. Is it possible to provide the CefRequestHandlerAdapter instead, so that we can override the onBeforeBrowse method, which will only be called once for each URL request?

@KevinnZou this should be no problem now. You can call this method on the client addRequestHandler

@DatL4g So the issue you mentioned in this link has been solved? It appears that you have provided a default CefResourceRequestHandler, but the default CefRequestHandler is still missing. So should the same problem still exist if we just call addRequestHandler which will override the default implementation?
Update: I have tested it with the latest KECF version and confirmed that the problem still exists.


containerObject cpuLimit in devfile

/kind feature

Which functionality do you think we should add?
I want to be able to define cpu limits for my devfile
Why is this needed?
In my namespace I have cpu and memory limits set by default that is kind of low.
It's not a problem on the memory side since I can define memoryLimit: 1512Mi in my devfile as described in: https://odo.dev/file-reference/#containerobject
But I can't set cpuLimit, due to this I have to manage two default limits for my developers. One that is running odo and one that is not using it and I can't set a default limit that is something like 50m because it won't work with odo so it's a bigger risk of over commitment from my odo developers.

Currently the devfile schema doesn't support cpuLimits. There is a issue about adding additional resources in future https://github.com/devfile/api/issues/131

In an ideal world users should set a proper LimitRange to the namespace that they are working against and odo should inherit those values. However sometimes users does not have that privilege and the default LimitRange may set default values that is not suitable.
For those cases we should have a configuration on odo that users can set that will work well against the cluster they are working with that will allow them to override the default limits.

In an ideal world users should set a proper LimitRange to the namespace that they are working against and odo should inherit those values.

@gorkem  What do you mean by inherit? Do you mean that if there is for example memory LimitRange min: 1Gi, max: 2Gi on the namespace, odo should try to detect those values and automatically set memory limit within the range?
I thought that the problem defined in the issue description could be just solved if we have an option to specify cpu limit in Devfile, which we are currently missing.

It can be done through devfile. I am concerned that the values on devfile will be set without taking cluster configuration into account and may cause the deployment to fail.

@gorkem , I would argue that it is correct to set resource limits without taking the cluster into account. Limits should be set based on the application requirements. Yes, it could lead to a situation where the given devfile can't be deployed to the cluster because it simply can't fit the namespace LimitRange. But I would say this is correct, as in this situation application might not be stable.

this has been implemented
/close


Add button to copy markdown changelog

In the markdown view:

When using this as a base for a blog post, I usually copy the contents to a local file to edit. It would be nice to have a button to copy the whole text area, or support Ctrl+A when it has focus.

This was implemented in https://github.com/godotengine/godot-interactive-changelog/commit/991a38b066f885c94bbb69e0ebf61eac14de6f98.


Different/wrong results when using Speech-to-text container

Describe the bug
When using Python SDK for Speech-to-text with endpoint pointing to Container, we see 2 issues:

numbers in the result are not converted to digits, but are output as text
Punctuation and capitalization is wrong in DisplayText output - almost all words start with capital letter and it merges words, while it is OK when using cloud endpoint.

To Reproduce
Steps to reproduce the behavior:

Run Speech-to-text docker container tag "2.13.0-amd64-sk-sk" (released 2021-07-30)
Use Python SDK to process wav file via SpeechRecognizer and recognize_once_async() method.

Expected behavior

Numbers returned as digits (as it is the case when run against the azure cloud endpoint).
Correct punctuation and capitalization

Version of the Cognitive Services Speech SDK
python azure-cognitiveservices-speech 1.18.0
Platform, Operating System, and Programming Language

OS Debian 10, Python 3.7.3

Additional context

Result from container:
Dobre Niekoho Z Panenská Trinásť Mám Pre Vás Balíček Na Prevzatie Bude Potrebné Aby Kľúčová Poslal Odpovede.
Result from westeurope azure region:
Dobre ďakujem, ddd panenská 13 mám pre vás balíček na prevzatie potreba kipling otcov a poslalo dph.
The number "trinásť" should be written as "13" also when using a container. And also here you can see the second issue that all words start with capital letter.

Result from container:

"Lexical":"dobrý deň prosím vás spojte má s pani doktorkou kozákov",
"ITN":"dobrý deň prosíMVás spojte má s pani doktorkou kozákov",
"Display":"Dobrý deň prosíMVás spojte má S Pani Doktorkou Kozákov."}

Notice for example the merged words "prosim vas" into "prosiMVas".
Is the container using different model than the cloud endpoint? In Speech Studio I see the current model for Slovak (sk-SK) language is 20210628, so I guess the container image released 2021-07-30 should be also using it. Should the container also produce the same results as cloud endpoint? Because also the text output is slightly different, but those 2 mentioned errors are more of a concern for us. Or is there any configuration parameter in the SDK which can fix it?
I can provide the input audio file if needed.

This is a know issue, there are differences between cloud and container because not all components are shipped into the container. One of these components is the full Post Processing components, what is shipped is a lite version. We are working on a new capability that will allow our containers to download the full post processing models and bring them closer to parity with the cloud version.


next@latest is pointing at a canary release

Expected Behavior
next@latest points at the latest stable release.
i.e: npm install next installs<EMAIL_ADDRESS>Current Behavior
next@latest points at the latest canary release.
i.e: npm install next installs<EMAIL_ADDRESS>Context
Maybe I'm misunderstanding what the canary releases are, but shouldn't next@latest point at the latest stable build not the latest experimental build?
The Next canary blog post says that next@canary should be used to install the latest canary release. It seems kinda pointless if next@latest points at canary too.

@Rowno Thanks! I've updated the dist tag 🙏


fix(auto-complete): solid item hover style

Checklist

[x] Fix linting errors
[x] Tests have been added / updated (or snapshots)

Task linked: CU-3vkgzu change background color in input components

:tada: This PR is included in version 1.0.0-alpha.29 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


fix(NODE-4139): allow monitor to yield control

Description
Changes the monitor to process incoming hellos when the streaming protocol is enabled in a timeout, so that it can yield the process to other potential commands.
What is changing?
Adds a setTimeout in the callback after the hello command is run. This has been shown on aws lambda to reduce processing time after a function is idle for hours from over 20 seconds to ~400ms.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4140

Double check the following

[x] Ran npm run check:lint script
[x] Self-review completed using the steps outlined here
[x] PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
[ ] Changes are covered by tests
[ ] New TODOs have a related JIRA ticket

Per our discussion this solution is gone away in favour of a message stream optimisation in lambda environments.


[Sema] Improve handling of invalid protocols during conformance checking

Fixes 4 compiler_crashers.

Nice stuff! :+1:
Very happy to see these fuzzing cases getting fixed :-)

@practicalswift I'm afraid I'll never catch up with your fuzzer :smile:

@jtbandes No worries - the number of possible crash locations is finite, so given enough time you'll catch up eventually :-)

But also — thanks for doing the fuzzing! It provides a great source of "intro" bugs for gaining some familiarity with the codebase :)


[PQL Cleanup] Remove all PQL related code

Sub-task of #7430
Remove all PQL related code.
The UI cleanup for the PQL endpoint will be done separately.

Codecov Report

Merging #8626 (9ced956) into master (d49d117) will decrease coverage by 44.36%.
The diff coverage is 46.47%.

:exclamation: Current head 9ced956 differs from pull request most recent head 3ba1969. Consider uploading reports for the commit 3ba1969 to get more accurate results

@@              Coverage Diff              @@
##             master    #8626       +/-   ##
=============================================
- Coverage     70.44%   26.07%   -44.37%
=============================================
  Files          1703     1642       -61
  Lines         89607    86027     -3580
  Branches      13568    12906      -662
=============================================
- Hits          63122    22431    -40691
- Misses        22038    61459    +39421
+ Partials       4447     2137     -2310

Flag
Coverage Δ

integration1
?

integration2
26.07% <46.47%> (+0.26%)
:arrow_up:

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...mentpruner/MultiPartitionColumnsSegmentPruner.java
0.00% <0.00%> (-74.15%)
:arrow_down:

...mentpruner/SinglePartitionColumnSegmentPruner.java
0.00% <0.00%> (-68.22%)
:arrow_down:

...roker/routing/segmentpruner/TimeSegmentPruner.java
0.00% <0.00%> (-80.23%)
:arrow_down:

...uting/segmentselector/RealtimeSegmentSelector.java
82.53% <0.00%> (-12.78%)
:arrow_down:

...a/org/apache/pinot/common/metrics/BrokerMeter.java
100.00% <ø> (ø)

...t/common/response/broker/BrokerResponseNative.java
87.21% <ø> (-5.59%)
:arrow_down:

.../main/java/org/apache/pinot/common/utils/Pair.java
60.00% <ø> (ø)

...pache/pinot/common/utils/request/RequestUtils.java
53.94% <ø> (-32.45%)
:arrow_down:

...src/main/java/org/apache/pinot/sql/FilterKind.java
100.00% <ø> (ø)

...g/apache/pinot/sql/parsers/CalciteSqlCompiler.java
100.00% <ø> (ø)

... and 1286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d49d117...3ba1969. Read the comment docs.


Add support for issue links

The 5 calls API sends back link and linkTitle data values for each issue. When these values are undefined, they should be displayed below the script. See script.js and issueLink.js in the Choo repository for details. Also, according to call.js in the Choo repository, when an issues link data exists, a contact should not be displayed.

Reference implementation from previous choo app: https://github.com/5calls/5calls/blob/master/static/js/components/issuesLink.js

Gonna attempt this issue!

This is in #50

PR #50 has been merged into master


Implement GitLFS

Our current approach of building local data files (segments, standardized crashes & concerns, predictions and so on) and using data.world for storage is starting to become a development issue.
I thought it might be worthwhile for everyone to list ideas about where they think the current setup has strengths & weaknesses, and some ideas of alternatives.
My initial thoughts:
strengths:

allows for rapid development, files can be created as needed
reading local files means cities can be developed & tested without the need for access to a remote service
data.world is free, like all of the other tools we're using

weaknesses:

reading local files is likely to have performance issues, especially once we start enabling viz-based filtering / searching
data.world has storage limits which we are close to hitting
there isn't any structure around data revisioning, 'data-latest.zip' just gets replaced continuously which will become problematic if different branches require different file states

alternatives:

moving to Git Large File Storage (LFS - https://www.youtube.com/watch?v=uLR1RNqJ1Mw):

would mean we could keep building & using local data files for the time being, though that itself is likely to become a performance issue eventually
would give us access to data file revisions in the same way we do for our source code

a network database:

would be a step towards a formal deployment infrastructure
would allow for more sophisiticated interrogation of the data and discovery of relationships / trends

Please add your ideas below, thanks.

Adding on:
strengths:

part of a larger data hosting ecosystem (i.e., other people looking for open data might discover our project)

weaknesses:

lack of flexibility. it's incredibly annoying to have to upload/download the entire zipfile just to update one single dataset in it, especially given how large the zipfile is
no way to [easily] track what in data-latest.zip got modified from the previous version

There is a new branch in the repo lfs_data which has the entire /data folder under version control using GitLFS.
Steps to configure this were:

install git lfs (https://git-lfs.github.com/)
remove /data from .gitignore
enable LFS tracking of all files in /data by running git lfs track "data/**" (this creates a .gitattributes file which is now also under version control)
commit /data, .gitignore and .gitattributes and push to the lfs_data branch
wait half an hour while 1gb of files is uploaded =)

I committed the files from data-latest-2018-08-26.zip from data.world, which contains the preds_final.json files for each of the 3 cities - https://github.com/Data4Democracy/crash-model/tree/lfs_data/data
You can see the "Stored with Git LFS" message when viewing files in the repo, e.g https://github.com/Data4Democracy/crash-model/blob/lfs_data/data/boston/raw/crashes/vzopendata.csv
Next step is for someone to install LFS on their machine, and then checkout the lfs_data branch (if you check it out prior to installing LFS, you won't get the files, according to the documentation).
One last note - when I tried to push the commit to GitHub using the GUI client SourceTree on Mac, I hit an error about file locking. After some research I ran the command git config lfs.locksverify false which adds an entry to the git config file, and the error went away. But then I removed that new config and pushed another commit, this time using the console, and it worked without error. So I guess give it a go without running this step first and use it if necessary. Thanks.
@alicefeng @bpben @j-t-t @mtjones330

This seems to work, although yeah, that was really slow. Maybe we should just have the zipped file under version control instead of the whole directory structure? It's just going to keep getting bigger as we add more cities...

If we create an archive, that'll mean the whole thing will need to be downloaded whenever a single file changes. Or are you talking about zipping individual files?
Now that you have the files locally from the repo, that should be the worst of the delays done anyway?

From the github.com documentation:
We recommend repositories be kept under 1GB each. This limit is easy to stay within if large files are kept out of the repository. If your repository exceeds 1GB, you might receive a polite email from GitHub Support requesting that you reduce the size of the repository to bring it back down.
In addition, we place a strict limit of files exceeding 100 MB in size. For more information, see "Working with large files."
Using GitLFS removes the constraint of 100mb per file (I got an error message about this prior to having LFS working properly). If/when GitHub contact us about removing the big files, then we may need to adjust our plan, but until that happens I don't know of a better solution? We could potentially removed the /data/[city]/processed folder from version control as that is probably the worst offender, but that would mean running the pipeline locally for whatever city you wanted to predict on when changes are made to the process.. not the worst outcome I guess.
@bpben @alicefeng @mtjones330 @shreyapandit any thoughts on this?

I think we should continue to store the processed data somewhere, because otherwise different people might end up developing on different maps. I still think zipping the files up, while not ideal, might be the best option here. We can just zip each city individually though, so that when people add new cities, or update data sources for new cities, we wouldn't need to get the whole zip. But when we make code changes that require rerunning the pipeline, that would require a full update, yes.

@j-t-t I think your idea of city-specific zips is the best strategy for now. This lets us get both input & output files under version control, both of which need compression if we're going to stick to a reasonable repo footprint (without compression /data for our 3 initial cities is at 1.41gb, with bzip2 compression it drops to 127mb). I've gone ahead and run each city's folder through tar & bzip2 and pushed the changes to the lfs_data branch.
Do we have consensus on using this approach now? The only real change to the workflow required is unzipping the archive if you want to run a city, and then rezipping if you make changes. Could / would that be something we want to add to the pipeline?

I'm not sure about adding it to the pipeline. Well, unzipping, maybe. But I'm not sure that this is the best way to ensure that the zipped files are up to date, because if we make code changes that will affect all the cities' maps, you'd have to rerun all those cities, and at the moment the pipeline doesn't support that.
I guess we could have another script that runs all cities for which we have config files, and if you run it with the --forceupdate flag, then rebundle everything.
If we go with the zip each city model, we'd also want to add each city's subdirectory into .gitignore. Although that means that each new added city would also have to be added to .gitignore, so perhaps we'd want to have a data/ directory that things get unzipped into that is ignored, and a zipped-data/ directory that is under version control.

PR to merge in our new city-based archiving strategy - https://github.com/Data4Democracy/crash-model/pull/188

@j-t-t I made some updates to the documentation that should cover off how to use GitLFS, let me know if you spot any problems. Thanks.

PR has been merged to master and this is now complete.

@j-t-t this P.R re-introduces GitLFS into master with the setup we were discussing - https://github.com/Data4Democracy/crash-model/pull/199


Fix to formatting issues in Play Pen Tutorials

The tutorials have some formatting issues (mostly related to indentation). This PR fixes them, enhancing readability. Discussion on #599.

Huge!! thanks a lot


Tauri init and first time use

Is your feature request related to a problem? Please describe.
When first installing and running tauri init, we should provide an input for a few of the major required settings specifically the path settings and app name. At the completion of the init script, we can note where these config options were stored to make it easier for the user to find them.
Additionally, we can add a readme.md in src-tauri with the simple instructions for running and point them to our docs for further help.


[Merged by Bors] - doc: Add Gödel's Incompleteness Theorem to Freek's list

Add formalized proofs of Gödel's first and second incompleteness theorem to Freek Wiedijk's list.
I may have the wrong notation to describe multiple theorems, please tell me if it is.

bors merge

@fpvandoorn
Maybe the link is broken?
https://leanprover-community.github.io/100.html#6


Add support for iPad idiom when exporting images / icons

🚀  Feature request
Sometime, Designer might want to have a different kind of image show up for iPad platform compare to iPhone platform
for example: different size / different color or shape...etc
will it be possible to support this feature for iOS, so the developer can see something like this (idiom shows either iphone or ipad instead of universal):

💡 Possible solution
To achieve the feature, we can use some kind of naming convention, I suggest that we can make designer control the idioms by using the ~ tilde symbol:

as the image shows, we can combine them into same imageset when parsing, and note different idiom in content.json.
with this tilde naming convention, I think there will be more flexibility for image / icons to show up for different platform.

Hi @subdan, would like to know if there will be any update relative to this feature request, or is there anything I can help with 🙂

Hi. I’m busy right now. I plan to make this feature in November.
Do you know Swift?

we've look into how the process worked in (AssetsProcessor.swift), it is quite hard to add grouping feature (img/some-img, img/some-img~ipad,...) in with current architecture, we might need to modify the struct in Image.swift, (for example, add basename and idiom Property) which seems will make too much changes 😓


CIFTI outputs not keeping track of voxels that are not included in brain mask

fMRIPrep version 20.2.0, singularity container
dataset: ds001110 sherlock merlin
ran with additional flags:
--task-id MerlinMovie --cifti-output --skull-strip-t1w skip --nthreads 4 --skip_bids_validation --ignore slicetiming
I noticed that after running the cifti outputs through fitlins with a simple contrast, many of the subjects show unusual activations that appear to line up with voxels not included in their brain mask, which varies from subject to subject. see the red regions of sub-19 for an example:

If I look at the dtseries.nii cifti file that was the output of fmriprep and plot only the values of the brainstem, it appears that many of the values are close to (but never exactly) zero:

Is it possible for fmriprep to mark these voxels somehow like as NaNs or make a cifti brainmask label that fitlins can then use, or a simpler way around this? For now I can probably figure out a hacky way around this. Thanks!

Unfortunately, this looks to me like a bigger problem - a failure with either the brain-masking / spatial normalization. Would it be possible to rerun adding the --output-spaces MNI152NLin6Asym:res-2 option so we can view the intermediate files?

@mgxd will do!

I've rerun fmriprep with that option added and here is the report from subject 19:
sub19_report.zip
Which specific files would be best to share? I can post links to them here or maybe I can move them to somewhere on openmind or elsewhere if that is easier

Ok, taking a look at sub-19/figures/sub-19_task-MerlinMovie_desc-bbregister_bold.svg, it seems the BOLD's FOV does not fully capture the brainstem, among other regions, which might explain the zeros you are seeing the CIFTI for that particular region. You can quickly see the regions affected by looking at the carpetplot which leverages the CIFTI when generating them (note the gray horizontal lines)

I'm not entirely sure what's the best way to handle this, as I'm hesitant to change any values within the CIFTI generation. Post-processing the affected regions and changing values near 0 to NaN might be good enough?

The hacky way around this for me was to set voxels with 0 or close to 0 variance to NaN after fmriprep similar to what you are suggesting. Though I haven't run it through fitlins after that yet.
The points that end up NaNed seem to be what are expected, here they are colored dark red:

fyi setting them to NaNs doesn't seem to interfere with fitlins, at least it ran alright, so if the values are set to NaN (or zero if that is better?) within fmriprep maybe that is ok as suggested and/or:
I've been looking into this, getting a bit lost, but it might be useful to output for each run a brain_mask.dlabel.nii cifti2 file analogous to the brain_mask.nii.gz. It's not yet clear to me if there is a more efficient way where this info can be captured in the metadata or if there is a simpler way to apply that already existing brain mask .nii to the cifti file.
If these cifti brain masks are generated then they can be used by users to make a xx% coverage mask or sent into fitlins or other apps if they can accept them as inputs

Yes, I think we might have an issue for providing a gifti mask. Should expand it for cifti.


Deprecation Warning with SQLAlchemy 1.3 beta

This is probably a bit premature, but when using SQLAlchemy 1.3.0b2 I encountered a deprecation warning at https://github.com/pallets/flask-sqlalchemy/blob/master/flask_sqlalchemy/init.py#L157.
This can be easily addressed by replacing
info = getattr(mapper.mapped_table, 'info', {})

with:
info = getattr(mapper.persist_selectable, 'info', {})

Also, what are the plans for updating for 1.3 compatibility in general?

And now it's released and quite noisy
 xx passed, xxx skipped, 7300 warnings from my test-suite that used to be warnings free

Their are commits in #684 that resolve this issue.

This SADeprecationWarning (/usr/local/lib/python3.6/site-packages/flask_sqlalchemy/__init__.py:157: SADeprecationWarning: Use .persist_selectable) has been polluting our log files for days.
I'm super grateful to the volunteers that keep this package usable for the ecosystem.   Just wondering when this may be merged, and/or is there anything specific holding it back? :)

The fix is in: https://github.com/pallets/flask-sqlalchemy/pull/684
I've been waiting for approval on that PR.  As soon as I get or get some kind of response, I'm hoping to get a release out soon.

@rsyring Looks like it's approved - thanks for putting in the effort to keep this package up to date for us.


[v2.0.0-alpha16] unable to read client-cert ( minikube )

Rancher versions:
rancher/server: 2.0.0-alpha16
rancher/agent:
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable): v1.8.0 / minikube v0.25
Docker version: (docker version,docker info preferred) 17.12.0-ce
Operating system and kernel: (cat /etc/os-release, uname -r preferred) macOS High Sierra
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO) VirtualBox
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Trying Rancher 2 with minikube
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
k8s
Steps to Reproduce:
minikube start
sudo docker run -d --restart=unless-stopped -p 80:80 -p 443:443 rancher/server:preview
Results:
Rancher 2 ask the profile, I put the ~/.kube/config ( after renamed to .yml to be permit to select it )
The file is correctly read, but the state stay to "provisioning" with this big red warning:
| invalid configuration: [unable to read  client-cert /Users/guillaume/.minikube/client.crt for golf due to open  /Users/guillaume/.minikube/client.crt: no such file or directory, unable  to read client-key /Users/guillaume/.minikube/client.key for golf due  to open /Users/guillaume/.minikube/client.key: no such file or  directory, unable to read certificate-authority  /Users/guillaume/.minikube/ca.crt for golf due to open  /Users/guillaume/.minikube/ca.crt: no such file or directory]
As the config file point to external cert files, I suppose Rancher can't have access to theses files. So how to fix that please?

Yes the config file needs to be self-contained and include the keys.  The "give us your kubeconfig file" mode is going to be gone in the next preview because of situations like this (and Google GKE configs execute a shell command to get the keys), so you will run a kubectl command we give you instead.

Thanks @vincent99 !
So, currently, is there a temporary solution to include my keys inside the config.yml file, or may be you could give me the kubectl command to use please?

cluster -> certificate-authority-data: base64 encoded contents of ca.crt
user -> client-certificate-data: base64 encoded contents of client.crt
user -> client-key-data: base64-encoded contents of client.key

Thanks!

A simple script to help to translate easily the ~/kube/config to the base64 data format:
#!/bin/bash
MKPATH="$HOME/.minikube/"
MK=$(echo $MKPATH | sed 's/\//\\\//g')
CA=$(base64 -w 0 "${MKPATH}ca.crt" | sed 's/\//\\\//g')
CRT=$(base64 -w 0 "${MKPATH}client.crt" | sed 's/\//\\\//g')
KEY=$(base64 -w 0 "${MKPATH}client.key" | sed 's/\//\\\//g')
cat ~/.kube/config | sed "s/: ${MK}ca\.crt/-data: ${CA}/g" | sed "s/: ${MK}client\.crt/-data: ${CRT}/g" | sed "s/: ${MK}client\.key/-data: ${KEY}/g"

This worked for me.
Run the following command
kubectl config view --flatten

Copy the output and replace it with ~/.kube/config. (Considering you have only minikube cluster)


Merge pkg/shelfice with pkg/steep_icecavity

What changes does this PR introduce?
Suggestion instead of PR #368. I am opening this PR only to support my review of PR #368: Starting from Ou's careful work, it pretty is straightforward to include the innovations of #368 into pkg/shelfice without breaking anything. Note that only 33 files change plus 10 new verification experiment files. See commit message of first commit, repeated below.
One issue remains with the 3D transfer coefficients, but I am confident, that this is simple to fix. I am sure that there are still more issues that I didn't see, but as this is for now only intended as a basis for discussion, I am not going to check this any further until we have reached a decision about #368.
What is the current behaviour?
(You can also link to an open issue here)
What is the new behaviour
(if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Other information:

make ALLOW_STEEP_ICECAVITY a CPP flag in SHELFICE_OPTIONS.h and
change useSTIC to SHEFICEuseSTIC to be set in data.shelfice
the most pain was caused by the flag ALLOW_SHITRANSCOEFF_3D, which
is only indirectly related to the merge.

forward verification experiments:

compiles and does not break isomip reference experiments as long as
ALLOW_STEEP_ICECAVITY is undefined
with ALLOW_STEEP_ICECAVITY defined, there are naming conflicts with
pkg/icefront (naturally), but when icefront is disabled in
packkages.conf, the remaining verification experiments do not break
new verification experiment isomip.stic

TAF-AD verification experiments:

isomip does not break when ALLOW_STEEP_ICECAVITY is undefined
no additional recomputations when ALLOW_STEEP_ICECAVITY is
defined
does not yet work with ALLOW_SHITRANSCOEFF_3D (unclear)
new AD-verification experiment isomip.stic

TODO:

rename icefront variables to given them unique names so that
shelfice and icefront can be compiled together
in SHELFICE.h separate icefront and shelfice code (separate common
blocks)
sort out use of ALLOW_STEEP_ICECAVITY (define fields only when
necessary)
fix AD of 3D transfer coefficients, if necessary
formatting, details ...

Suggested addition to tag-index
(To avoid unnecessary merge conflicts, please don't update tag-index. One of the admins will do that when merging your pull request.)

I summarise a conversation with @jm-c and @owang01

it would be nice keep the steep_icecavity code in a separate package, but reuse most of the shelfice code, so that the steep_icecavity code needs pkg/shelfice to be compiled and used.
in order to see, how this works, I will try this in two steps:

call stic_thermodynamics from within shelfice_thermodynamics (done in commit 3f598e3)
move steep_icecavity code to a separate package.

before I work on step ii., there's time to comment on 3f598e3

With the latest commit, I can use both 2D and 3D shiTransCoeffT/S, but the AD-results change from
Y Y Y Y 16>16<16 16 14 16 14 12 14 16 16 12 13 13 13 13 12 14 13 pass  isomip  (e=0, w=0, lfd=1, dop=1, sm=0)
Y Y Y Y 16>16<16 16 16 14 16 13 13 16 14 12 13 13 14 14 10 13 16 pass  isomip.htd
Y Y Y Y 16>16<16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 16 pass  isomip.stic

with#undef ALLOW_SHITRANSCOEFF_3D to
Y Y Y Y 16> 9<16  9 10 10  2  4  6  5  5  2  1  4  3  1  4  2  3 FAIL  isomip  (e=0, w=0, lfd=1, dop=1, sm=0)
Y Y Y Y 16>10<16 11 11 12  0  5  7  6  5  5  2  5  5  2  5  3  5 pass  isomip.htd
Y Y Y Y 16> 8<16  6  8  7  5  5  7  6  6  5  4  7  6  5  7  4  7 FAIL  isomip.stic

with #define ALLOW_SHITRANSCOEFF_3D, so not only for the new STEEP_ICECAVITY code. @owang01 Maybe the latest change in PR #368 (commit 28770a3) will help?

b82bbc3 fixes the problem with  ALLOW_SHITRANSCOEFF_3D, because

it is only applied to pkg/steep_icecavity
common block for 2D and 3D shiTransCoeff a cleanly separated.

I think this is now (nearly) ready for review. There a few things to do:

[ ] work on names:

I changed IceFront to ICF, STIC, or even STC and we should probably think about a more unique naming convention.
I used pkg/steep_icecavity but never STEEP_ICECAVITY as a prefix, which cause some issues with
IF (useSTIC) CALL PACKAGES_ERROR_MSG('STEEP_ICECAVITY',' ',myThid)
maybe rename useSTIC to useSteep_iceCavity or similar.
name of ALLOW_SHITRANSCOEFF_3D, now it belongs to pkg/steep_icecavity, maybe it should be called STIC_SHITRANSCOEFF_3D instead (because it's not "allowing" it, but setting it?)

[ ] sort out the defaults for temp/salt_addMass in set_default.F

[ ] I am not sure about the contribution pkg/ecco. Maybe we want to remove this from this PR and do it in a different one, including some documentation? There now changes in shelfice_init_fixed.F related to this, and I am not sure where this belongs.

[ ] some cleanup in stic_solve4fluxes.F, sic_thermodynamics.F and some more of the new code? Maybe later? I did not check these routines at all, except where they were giving me compile errors or similar, so I do not know if they could made more efficient (e.g. loop pushing for stic_solve4fluxes.F, which case one could even use it for shelfice_thermodynamics.F)

[ ] check for duplicate diagnostics?

[ ] check the new verification experiments, do they make sense?

[ ] documentation of the new pkg!!!

[ ] update new experiment results to reference maching

Closing this PR since this got moved to PR #789 (which is now merged).


Typo in Config-commands.md wiki page

Minor one that the code under '#7' has a copy-paste of the '#6'.
It should be
'#79876;'
instead of:
'#69876;'

Config Commands shows a proper restart cmd.
Thanks!


This component can not used in andoriod?

Hello,I used your component in my APP , It run in ios is ver very nice, but in andorid has problem , can you tell me how to fixed it?Thank you.

I'd recommend you to use https://github.com/react-native-community/react-native-drawer-layout for Android as it follows Android design patterns


Add usePreventWindowUnload hook.

Related to #799

In my testing, if you open the editor do nothing and try and leave, I still see a message saying I will leave my changes. This seems weird, as I haven't done anything yet.

Interesting @spacedmonkey. It should not happen since it is using the changes history to control when to register the event. I will take a look for potential edge cases.

@obetomuniz Here is a video of it happening - https://youtu.be/LocZ6bR4EGY
My money is that something is trigger an event that goes into the history. Seems like the undo button is highlighted, so something happened. But easy to replicate.

I have created a related issue for adding this hook while files are uploading - https://github.com/google/web-stories-wp/issues/971

Done @dvoytenko 👍

LGTM

The failing test should be fixed by merging in master (as #1129 has been merged), as it actually specifically fails because you can't add onBeforeUnload before any user interaction.
Didn't know you couldn't do that, TIL!

@googlebot I consent.


Checkpoint map support

Description
This adds the map type to the checkpoint schema, pending completion of the feature in arrow-rs.
Related Issue(s)
TODO
Documentation
TODO

@xianwill I've temporarily pointed this to the map-support on my arrow fork. I expect some tests to fail (datafusion might not compile because of different arrow versions), but the core Rust tests with default features pass, showing that the map support works.
We can update the PR when the arrow-rs work is complete and a new version is released, but I'm hoping this unblocks your progress in the interim.

Superseded by https://github.com/delta-io/delta-rs/pull/349


Modularise cf-plot codebase

Currently the vast majority of the code is contained in one file, cfplot.py, which as a consequence is over 10,000 lines long and difficult to follow, manage and navigate. It would be much better to split this into separate files in a modular hierarchy based on functionality and natural groupings of objects, etc.
I will come up with a plan for what I see is the most appropriate modularisation for cf-plot shortly and post it here as a proposal, before undertaking the work.

This will include moving any testing out to a separate dedicated directory, towards (also) #12.


Set_value plugin: change logger level and re-evaluate pattern on event

In GitLab by @ksiero on Jul 30, 2021, 11:15
Set_value plugin should be able to change change logger level, pattern and re-evaluate pattern on event.
The same should be able to be achieved from PDI API.

In GitLab by @ksiero on Nov 14, 2021, 21:24
mentioned in commit 051f240a55db1c6507b4ac397b37ea5d4213b1ca

In GitLab by @ksiero on Nov 14, 2021, 18:51
mentioned in commit b889539337cfd2ada361c59888034a4649bc7e0c

In GitLab by @ksiero on Nov 14, 2021, 21:25
mentioned in commit 96f9d1f88b458ad641bcbd3942a7e4f7a0916478

In GitLab by @ksiero on Nov 14, 2021, 18:01
mentioned in commit 3927c140203f83ecd5180fc676c88db08552a010

In GitLab by @ksiero on Nov 14, 2021, 17:38
mentioned in commit 78280df7bbf572b84e6b3ec689fef8865f0bc4bf

In GitLab by @ksiero on Aug 31, 2021, 14:42
mentioned in commit db14d9ed56982213ad1c9610910182a5e7fd1f4a

In GitLab by @ksiero on Nov 14, 2021, 21:28
mentioned in commit bb6ddfbae0a3247056877960db29662a26574dc7

In GitLab by @ksiero on Nov 15, 2021, 17:08
mentioned in commit 10498c578a0e491ebfebda7677f234a7fdc03a70

mentioned in commit 56102037f7e36417ee4b42a2928c50fbb075f1b7


Allow enabling TCP keepalive for PostgreSQL connections

we don't need this any longer for now, right?

Not really, as they're not kept alive anyway


Storm 1226

This is translating util.clj into java functions mostly in utils/Utils.java.
Translation is half way done, passing all unit tests. Putting the pull request up to get reviews.

First off RAT is complaining about 3 files.  Please take a look into that.

Finished with my first pass through the code.  For the most part things are looking very good.

Also, will you kindly edit the title of this PR so it follows protocol?

It would be good to move MockedUtils.java into org/apache/storm/testing/staticmocking where the other mocking stuff is.

Let's rename the title of this pull request so it describes the work being done. Something about translating the utils namespace to Java.

Should close this PR because of #1074


Fix Intel Compile errors with cxxopts and json.

Intel was finicky and required adjustments to these two files.

@davidbeckingsale, @jdahm, this is ready for review.

Thanks @jdahm,
@davidbeckingsale ? :-)


Fixed up some commands

Fixed up /bofh and /roll commands

And also added a requirements.txt file

Ok I removed the requirements.txt file :/

Fix the failing linter. You can see what went wrong by clicking details on the check

ok github is being annoying but i think it works now

:/

Hi,
Still awaiting the requested changes. Marking them resolved doesn't mean they're actually fixed.

This is stale and probably won't be worked on, closing


Go Managed Identity example in README.md still references environment variable for user-assigned managed identity client id

Bug Report

azure-sdk-for-go/sdk/azidentity/README.md (1.3.1 and 1.4.*)

This functionality no longer exists, now replaced with credential options parameter:

Specify a user-assigned managed identity for DefaultAzureCredential
To configure DefaultAzureCredential to authenticate a user-assigned managed identity, set the environment variable AZURE_CLIENT_ID to the identity's client ID.

Is this feature not working for you? It should--we haven't removed the implementation and our unit test for it still passes:
https://github.com/Azure/azure-sdk-for-go/blob/bd79d36ce1bb052df2db67ff466d7c75f58180f2/sdk/azidentity/default_azure_credential.go#L100-L104

I see that now - debugging...

found the typo on my env variable.  closing.

closing - false alarm


508 Issues - From #2208 (Edit Monitoring Qualifications Data)

To be resolved: (Relevant to Edit Monitoring Qualifications Ticket)

The name of the data table on the qualifications modal under 'Qualification Percent' is generic: aria-label="Data Table". Should be labeled by the qualification percent text.
When you view qualification percent, the back button is labeled aria-label="go back to systems details". Should be changed to aria-label="go back to Qualification details"

Fixed the aria-label's for all of the data tables (Select Configurations, Expanded Configurations Tab, Methods, Systems, Qualifications, etc.)

Back buttons aria-labels are fixed for System tables (Fuel Flows/System Components) and Qualification tables (PCT/ LME/LEE)

Looks great, found one minor issue, the aria label is misspelled for Unit Capacities: aria-label="DataTable for Unit Capacitys

Fixed typo with aria label for Unit Capacities data table.


error during run flutter app

Such an error occurs after a recent update during project execution
No new projects will be implemented
Details
Target Platform: ANDOID
Target OS version/browser: 21
Devices: virtual devices
Logs
Launching lib\main.dart on HTC One E8 in debug mode...
[!] Your app isn't using AndroidX.
To avoid potential build failures, you can quickly migrate your app by following the steps on https://goo.gl/CP92wY.
Running Gradle task 'assembleDebug'...
Compiler message:
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:7:8: Error: Error when reading '/C:/flutter/.pub-cache/hosted/pub.dartlang.org/collection-1.14.11/lib/collection.dart': The system cannot find the path specified.
import 'package:collection/collection.dart';
^
/C:/flutter/packages/flutter/lib/src/widgets/shortcuts.dart:7:8: Error: Error when reading '/C:/flutter/.pub-cache/hosted/pub.dartlang.org/collection-1.14.11/lib/collection.dart': The system cannot find the path specified.
import 'package:collection/collection.dart';
^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:10:8: Error: Error when reading '/C:/flutter/.pub-cache/hosted/pub.dartlang.org/collection-1.14.11/lib/collection.dart': The system cannot find the path specified.
import 'package:collection/collection.dart' show PriorityQueue, HeapPriorityQueue;
^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:375:9: Error: Type 'PriorityQueue' not found.
final PriorityQueue<_TaskEntry> _taskQueue = HeapPriorityQueue<_TaskEntry>(_taskSorter);
^^^^^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:375:9: Error: Expected 0 type arguments.
final PriorityQueue<_TaskEntry> _taskQueue = HeapPriorityQueue<_TaskEntry>(_taskSorter);
^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:464:5: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.

'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:504:5: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.
'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) => a.rect.center.dx.compareTo(b.rect.center.dx));
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:529:5: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.
'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) => a.rect.center.dy.compareTo(b.rect.center.dy));
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:717:9: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.
'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:749:9: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.
'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:847:5: Error: Method not found: 'mergeSort'.
mergeSort<_ReadingOrderSortData>(list, compare: (_ReadingOrderSortData a, _ReadingOrderSortData b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:920:5: Error: Method not found: 'mergeSort'.
mergeSort<_ReadingOrderDirectionalGroupData>(list, compare: (_ReadingOrderDirectionalGroupData a, _ReadingOrderDirectionalGroupData b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:1001:5: Error: The method 'mergeSort' isn't defined for the class 'ReadingOrderTraversalPolicy'.
'ReadingOrderTraversalPolicy' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort<_ReadingOrderSortData>(candidates, compare: (_ReadingOrderSortData a, _ReadingOrderSortData b) => a.rect.top.compareTo(b.rect.top));
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:1349:5: Error: The method 'mergeSort' isn't defined for the class 'OrderedTraversalPolicy'.
'OrderedTraversalPolicy' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort<_OrderedFocusInfo>(ordered, compare: (_OrderedFocusInfo a, _OrderedFocusInfo b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/shortcuts.dart:81:22: Error: The method 'UnmodifiableSetView' isn't defined for the class 'KeySet'.
'KeySet' is from 'package:flutter/src/widgets/shortcuts.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/shortcuts.dart').
Try correcting the name to the name of an existing method, or defining a method named 'UnmodifiableSetView'.
Set get keys => UnmodifiableSetView(_keys);
^^^^^^^^^^^^^^^^^^^

Compiler message:
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:7:8: Error: Error when reading '/C:/flutter/.pub-cache/hosted/pub.dartlang.org/collection-1.14.11/lib/collection.dart': The system cannot find the path specified.
import 'package:collection/collection.dart';
^
/C:/flutter/packages/flutter/lib/src/widgets/shortcuts.dart:7:8: Error: Error when reading '/C:/flutter/.pub-cache/hosted/pub.dartlang.org/collection-1.14.11/lib/collection.dart': The system cannot find the path specified.
import 'package:collection/collection.dart';
^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:10:8: Error: Error when reading '/C:/flutter/.pub-cache/hosted/pub.dartlang.org/collection-1.14.11/lib/collection.dart': The system cannot find the path specified.
import 'package:collection/collection.dart' show PriorityQueue, HeapPriorityQueue;
^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:375:9: Error: Type 'PriorityQueue' not found.
final PriorityQueue<_TaskEntry> _taskQueue = HeapPriorityQueue<_TaskEntry>(_taskSorter);
^^^^^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:375:9: Error: Expected 0 type arguments.
final PriorityQueue<_TaskEntry> _taskQueue = HeapPriorityQueue<_TaskEntry>(_taskSorter);
^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:375:9: Error: 'PriorityQueue' isn't a type.
final PriorityQueue<_TaskEntry> _taskQueue = HeapPriorityQueue<_TaskEntry>(_taskSorter);
^^^^^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:375:57: Error: Method not found: 'HeapPriorityQueue'.
final PriorityQueue<_TaskEntry> _taskQueue = HeapPriorityQueue<_TaskEntry>(_taskSorter);
^^^^^^^^^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:464:5: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.

'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:504:5: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.
'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) => a.rect.center.dx.compareTo(b.rect.center.dx));
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:529:5: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.
'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) => a.rect.center.dy.compareTo(b.rect.center.dy));
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:717:9: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.
'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:749:9: Error: The method 'mergeSort' isn't defined for the class 'DirectionalFocusTraversalPolicyMixin'.
'DirectionalFocusTraversalPolicyMixin' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort(sorted, compare: (FocusNode a, FocusNode b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:847:5: Error: Method not found: 'mergeSort'.
mergeSort<_ReadingOrderSortData>(list, compare: (_ReadingOrderSortData a, _ReadingOrderSortData b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:920:5: Error: Method not found: 'mergeSort'.
mergeSort<_ReadingOrderDirectionalGroupData>(list, compare: (_ReadingOrderDirectionalGroupData a, _ReadingOrderDirectionalGroupData b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:1001:5: Error: The method 'mergeSort' isn't defined for the class 'ReadingOrderTraversalPolicy'.
'ReadingOrderTraversalPolicy' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort<_ReadingOrderSortData>(candidates, compare: (_ReadingOrderSortData a, _ReadingOrderSortData b) => a.rect.top.compareTo(b.rect.top));
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart:1349:5: Error: The method 'mergeSort' isn't defined for the class 'OrderedTraversalPolicy'.
'OrderedTraversalPolicy' is from 'package:flutter/src/widgets/focus_traversal.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/focus_traversal.dart').
Try correcting the name to the name of an existing method, or defining a method named 'mergeSort'.
mergeSort<_OrderedFocusInfo>(ordered, compare: (_OrderedFocusInfo a, _OrderedFocusInfo b) {
^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/widgets/shortcuts.dart:81:22: Error: The method 'UnmodifiableSetView' isn't defined for the class 'KeySet'.
'KeySet' is from 'package:flutter/src/widgets/shortcuts.dart' ('/C:/flutter/packages/flutter/lib/src/widgets/shortcuts.dart').
Try correcting the name to the name of an existing method, or defining a method named 'UnmodifiableSetView'.
Set get keys => UnmodifiableSetView(_keys);
^^^^^^^^^^^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:375:9: Error: 'PriorityQueue' isn't a type.
final PriorityQueue<_TaskEntry> _taskQueue = HeapPriorityQueue<_TaskEntry>(_taskSorter);
^^^^^^^^^^^^^
/C:/flutter/packages/flutter/lib/src/scheduler/binding.dart:375:57: Error: Method not found: 'HeapPriorityQueue'.
final PriorityQueue<_TaskEntry> _taskQueue = HeapPriorityQueue<_TaskEntry>(_taskSorter);
^^^^^^^^^^^^^^^^^
Target kernel_snapshot failed: Exception: Errors during snapshot creation: null
build failed.

FAILURE: Build failed with an exception.

Where:
Script 'C:\flutter\packages\flutter_tools\gradle\flutter.gradle' line: 882

What went wrong:
Execution failed for task ':app:compileFlutterBuildDebug'.

Process 'command 'C:\flutter\bin\flutter.bat'' finished with non-zero exit value 1

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 12s
Exception: Gradle task assembleDebug failed with exit code 1

It seems that Dart package collection couldn't be found after the update. @a-siva : would someone from the Dart team have a good idea about what's happening here?

Which update is the user talking about, can we get some reproduction instructions?

Hi @silverboy66000
Please explain the issue in detail
can you please provide your flutter doctor -v and flutter run --verbose?
Also, to better address the issue, would be helpful if you could post a minimal code sample to reproduce the problem
Thank you