Keyboard SharedValue stop responding on Android when using WebBrowser after installing unistyles

Description
After returning to the application from a WebBrowser session, the keyboard related SharedValues from react-native-reanimated or react-native-keyboard-controller stop responding to keyboard changes until the app is closed and reopened.
This is problematic since WebBrowser is a common way to perform authentication for social login. After the user gets redirected back to the app, all dependencies on the keyboard's shared value stop working.
Importantly, one does not need to use any feature of unistyles for this to manifest. Simply configuring unistyles causes the issue.
The issue could not be reproduced on iOS.
Steps to Reproduce
In the reproduction repo:

Click on the text input field. Observe that the animated view attached to the shared value of the keyboard height gets properly animated.
Click on the button saying "Click to launch WebBrowser". While nothing seems to happen, the app just got back from a webbrowser session.
Click on the text input field again.

On the main branch, the animated view would work. On unistyles-2.20 or unistyles-3 branches, the view would stop responding.
Snack or Repository Link (Optional)
https://github.com/vaharoni/expo-webbrowser-keyboard-issue
Unistyles Version
Both 3.0 and 2.20
React Native Version
0.76.3
Platforms
Android
Expo
Yes

Hey! Thanks for the report.
Based on your description, I can already explain why this is happening. I’m not sure if there’s anything I can do about it or if you should open an issue in the Reanimated repo.
This issue occurs only on Android because Unistyles 2.8+ enforces edge-to-edge layout. Additionally, when you return from a web browser session, Unistyles once again enforces edge-to-edge layout (when app comes to foreground). I’m not sure how Reanimated handles this, and I can’t check it right now, but that’s my assumption.
To confirm, you can either install Unistyles 2.7.2 and try reproducing the issue or uninstall Unistyles and install react-native-edge-to-edge, which functions the same way as Unistyles (forces edge to edge).
I hope this provides more clarity. Unfortunately, I can’t disable edge-to-edge layout since I rely on Android’s inset system, which requires it. Also, with the release of Android 15, this has become the standard.
I can be mistaken, so if that's not the case then please let me know I will try to find the root cause.

Thank you for your response. I tried to reproduce with 2.7.2 and indeed the issue does not occur.
However, installing react-native-edge-to-edge did not cause the issue. I also tried react-native-keyboard-controller, which enforces edge-to-edge (see here), and observed no issue.
So I suspect this issue is not caused by edge-to-edge per-se.

Thank you for your response. I tried to reproduce with 2.7.2 and indeed the issue does not occur.

That was the main change compared to version 2.8.0. Additionally, reading the keyboard height is based on IME insets (keyboard insets), so it must be related to that.
Unistyles does not modify any insets, it only reads them and forces edge-to-edge rendering. I'm not sure how I can help with this issue as I'm not blocking Animated from reading these values.

Nevertheless will try to debug your repro (thanks you for that) in free time, maybe I will find the problem


Can I use hover intent for better interaction with dropdown menus?

Currently I have some menus appearing on hover using [hover, hold] but due to the space between the activator button and the dropdown menu, if you're not quick the menu will disappear before your mouse pointer gets there.
Is there a way to utilize the existing hover intent service for this purpose?

Yes! You can make the hover intent smarter by detecting wether you're moving the cursor towards the pop over.

(PRs welcome)


allow chaning initial path when launching hyper

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: Windows 10
Hyper.app version: 2.0.0
The issue is reproducible in vanilla Hyper.app:  Is Vanilla

Issue

When using hyper on Windows with WSL like Ubuntu, I use the shell option defined to shell: 'C:\\Windows\\System32\\bash.exe' which works great.
However it will always open a terminal window under /mtn/c/Users/username instead of ~/ .
It would be nice to have an option where we can define the initial path that is applied once opening a Hyper window. like
initialPath: '~/'

This can already be achieved, and has been 'reported' as an issue here before. #1998

That's great! Thanks for referencing this and sorry I didn't spot it previously.


Change apply link to interest form

Since apps are closed, I figured we should redirect to the interest form

Sorry self-approving this time-sensitive one since people might be coming to the site from the Instagram Story. Let me know if you want to revert.

All good, not much being changed!


Added a side_effect function to return unique ids for most run_* functions.

For the following functions i added a side_effect function to return unique ids.

run_once
run_at
run_daily
run_hourly
run_minutely
run_every
run_at_sunrise,
run_at_sunset

I already created a pull request for this in the past
https://github.com/FlorianKempenich/Appdaemon-Test-Framework/pull/26
but we closed it due to the changes which where coming from @lifeisafractal .
However i just updated to the current master an this functionality was still missing. Thus i reimplemented the changes.

Hey 👋
For now, you can consider this project unmaintained, unfortunately.
I haven't had time to maintain this repo in the last few years, in good parts because I moved home and I haven't had a HomeAssistant setup for a very long time. So I'm a bit disconnected with the latest updates, and it's a huge overhead to start everything again, get context and understand how to fix issues on this project
However, I've finally taken the task to set up my server at home again, so I'll probably use this project for my own use again soon.
This means I may bring this project up-to-date in the next few months. No guarantees, obviously, but I may.
Best,
Flo


OFFICE_ACTION npl_class: Parsing and Consolidation ?

Hello,
Since v0.2-npl, we have introduced a OFFICE_ACTION npl_class
Question
How should this class of citations be structured and consolidated?
Food for thoughts
Below is a sample of 100 citations for this class.

WITH
  tmp AS (
  SELECT
    npl_publn_id
  FROM
    `npl-parsing.patcit.v02_npl`
  WHERE
    npl_class="OFFICE_ACTION")
SELECT
  npl_biblio
FROM
  `usptobias.patstat.tls214` AS tls214,
  tmp
WHERE
  tmp.npl_publn_id = tls214.npl_publn_id
LIMIT 100

Row | npl_biblio |
-- | -- | --
1 | Office Action Response for KR Application No. 10-2013-7015884, filed Aug. 27, 2014, 28 pages. |
2 | 'Non-Final Office Action', U.S. Appl. No. 10/396,653, (Sep. 19, 2006),24 pages. |
3 | Official Action for European Patent Application No. 07021150, dated May 6, 2010. |
4 | U.S. Appl. No. 14/639,310, Aug. 13, 2015, Office Action. |
5 | Office Action for U.S. Appl. No. 13/087,239, filed Apr. 14, 2011, dated May 22, 2013. |
6 | Final Office Action dated Jul. 22, 2008; U.S. Appl. No. 10/282,289, filed Oct. 28, 2002; 10 pages. |
7 | First Office Action issued by the State Intellectual Property Office of People's Republic of China in corresponding CN Application No.<PHONE_NUMBER>69.8, dated Nov. 18, 2013. |
8 | U.S. Appl. No. 13/177,341, Response filed Aug. 20, 2012 to Non Final Office Action mailed May 18, 2012, 11 pgs. |
9 | In the U.S. Patent and Trademark Office, Notice of Allowance in re: U.S. Appl. No. 12/806,356, dated Jul. 11, 2011, 1 page. |
10 | Notice of Reasons for Rejection from Japanese Patent Application No. 2011-533175, dated Apr. 2, 2013. |
11 | ' U.S. Appl. No. 11/462,281, Response filed Dec. 29, 2009 to Non Final Office Action mailed Oct. 1, 2009', 11 pgs. |
12 | Jun. 4, 2008 communication from our foreign associate forwarding Official Communication. |
13 | IP Australia Office Action dated Jul. 2, 2010 for Australian Patent Application No. 2005-319965, corresponding to U.S. Appl. No. 12/098,263 issued on Jul. 1, 2010. |
14 | United States Patent and Trademark Office, U.S. Appl. No. 12/685,843, Office Action, Aug. 19, 2010. |
15 | Non-Final Office Action from U.S. Appl. No. 12/773,781, dated Sep. 23, 2010. |
16 | Office Action dated Nov. 8, 2011, U.S. Appl. No. 12/745,081. |
17 | Preliminary Amendment dated Jun. 23, 1997, U.S. Appl. No. 08/881,176, 4 pages. |
18 | U.S. Appl. No. 10/374,000, Response to Office Action, filed May 12, 2006, 7 pages. |
19 | 'Non-Final Office Action', U.S. Appl. No. 12/244,545, (Mar. 27, 2012),18 pages. |
20 | Non-Final Office Action mailed on Feb. 14, 2014, for U.S. Appl. No. 13/498,099, filed Jan. 14, 2013, 20 pages. |
21 | Office Action issued in Eurasian Patent Application No. 201270371 on Sep. 10, 2015; 5 pages. |
22 | Office Action issued Sep. 4, 2014 in Chinese Patent Application No.<PHONE_NUMBER>05.4 (with English language translation). |
23 | Notice of Allowance and Fee(s) Due for U.S. Appl. No. 13/234,421, dated Sep. 21, 2012. |
24 | Office Action from U.S. Appl. No. 10/851,471 dated Mar. 27, 2006. |
25 | 'U.S. Appl. No. 12/987,584, Response filed Sep. 6, 2012 to Non Final Office Action mailed Jun. 6, 2012', 12 pgs. |
26 | Japanese office action and English translation for JP application No. 2005-539859, dated Jul. 27, 2007 (13 pages). |
27 | Office Action dated Mar. 7, 2007 cited in U.S. Appl. No. 11/254,264. |
28 | Non-final Office action regarding U.S. Appl. No. 11/617,497, dated Jun. 26, 2009. |
29 | U.S. Appl. No. 11/198,606, mailed Feb. 24, 2009, Office Action. |
30 | U.S. Office Action re U.S. Appl. No. 11/585,230, dated Apr. 5, 2010. |
31 | Non-Final Office Action mailed on Oct. 12, 2010 in U.S. Appl. No. 12/397,855. |
32 | Non-Final Office Action from U.S. Appl. No. 09/410,132, mailed on Nov. 21, 2000. |
33 | Respondent Carsem, Inc.'s Preliminary Invalidity Charts U.S. Patent No. 6,630,728 (Jun. 24, 1998) v. ESEC U.S. Patent No. 5,417,905 (Aug. 4, 1992). |
34 | Email regarding Office Action 1 (OA1) for ID Application No. W00200700972, dated Jan. 11, 2010, 2 pp. |
35 | Japanese Office Action, dated Dec. 6, 2011, issued in corresponding Japanese Patent Application No. 2006-305987, with English translation. Total 3 pages. |
36 | Nonfinal Office Action dated May 11, 2011, in U.S. Appl. No. 12/560,297, filed Sep. 15, 2009, entitled 'Network Intrusion Detection Visualization'. |
37 | Brayton, John Joseph, 'Office Action re U.S. Appl. No. 13/193,345', Jun. 6, 2013, p. 8, Published in: US. |
38 | European Patent Office, Communication of a Notice of Opposition issued in Application No. 09742120.0 dated Jun. 26, 2014. |
39 | U.S. Appl. No. 12/563,798, Office Action mailed Mar. 4, 2011. |
40 | Final Office Action for U.S. Appl. No. 11/527,246, mailed Mar. 1, 2011. |
41 | US Ex Parte Quayle Action in U.S. Appl. No. 13/190,143 DTD Aug. 23, 2013. |
42 | Final Office Action mailed Dec. 13, 2013 in related U.S. Appl. No. 13/113,826. |
43 | German Office Action for Priority Application DE<PHONE_NUMBER>63.1 dated May 27, 2014. |
44 | 'U.S. Appl. No. 13/547,455, Non Final Office Action mailed Oct. 22, 2015', 24 pgs. |
45 | Final Office Action Mail Date Feb. 13, 2008; U.S. Appl. No. 11/481,194. |
46 | Office Action mailed Jan. 22, 2015 for U.S. Appl. No. 13/182,914. |
47 | Non-Final Office Action dated Jul. 3, 2014 for U.S. Appl. No. 13/788,061, filed Mar. 7, 2013 (inventors David Colvin et al.). |
48 | Notice on the First Office Action issued Oct. 19, 2015 in corresponding Chinese Application No.<PHONE_NUMBER>92.6 (with English translation). |
49 | Japanese Office Action (w/translation) issued in application No. 2016-006559, dated Aug. 29, 2016 (3 pgs). |
50 | Office Action for U.S. Appl. No. 11/964,182, dated Jul. 12, 2011, 12 pages. |
51 | Office Action dated May 19, 2015, from the Japanese Patent Office in related Japanese Patent Application No. 2014-014941, and English translation thereof. |
52 | Response to Final Office Action dated Mar. 1, 2013, in connection with related U.S. Appl. No. 12/787,281, filed May 25, 2010. |
53 | Communication dated Sep. 4, 2014, issued by the State Intellectual Property Office of the People's Republic of China in counterpart Application No.<PHONE_NUMBER>20.7. |
54 | Office Action dated Aug. 5, 2014 in related Australian Patent Application serial No.<PHONE_NUMBER>, 4 pages. |
55 | U.S. Final Office Action dated Dec. 13, 2006 issued in U.S. Appl. No. 10/461,451. |
56 | U.S. Appl. No. 13/341,760 Office Action dated Nov. 20, 2013. |
57 | 'U.S. Appl. No. 11/517,886, Non-Final Office Action mailed Aug. 6, 2009', 12 pgs. |
58 | Final Office Action received for U.S. Appl. No. 12/085,389, mailed on Nov. 17, 2009, 14 pages. |
59 | Restriction Requirement mailed on Jul. 27, 2011 for U.S. Appl. No. 12/418,094, filed Apr. 3, 2009. |
60 | 'Chinese Application Serial No.<PHONE_NUMBER>09.5, Voluntary Amendment filed Aug. 23, 2013', w/English Translation, 13 pgs. |
61 | Excerpted file history of U.S. Appl. No. 13/383,658: USPTO Office action mailed Sep. 27, 2013 for U.S. Appl. No. 13/383,658, The United States Patent and Trademark Office, Alexandria, VA; and Applicants' Amendment and Reply filed Dec. 2, 2013. |
62 | M. Hachman, “Bluetooth 4.1 Prepares Headsets and More to Connect to the 'Net”, online publication dated Dec. 4, 2013 (http://www.techhive.com/category/holiday/. |
63 | Office Action for U.S. Appl. No. 13/719,947 dated Apr. 1, 2013, pp. 1-15. |
64 | USPTO, Office Action for U.S. Appl. No. 12/879,004 mailed Feb. 25, 2013. |
65 | Office Action for U.S. Appl. No. 10/644,060, mailed on Jun. 3, 2005; 11 pages. |
66 | 'U.S. Appl. No. 12/770,890, Notice of Allowance mailed Sep. 26, 2012', 7 pgs. |
67 | Non-Final Office Action Mailed Sep. 19, 2012 in Co-Pending U.S. Appl. No. 12/844,818 of Glover, R., filed Jul. 27, 2010. cited by applicant. |
68 | U.S. Appl. No. 12/737,887, Notice of Allowance mailed Feb. 24, 2014, 9 pages. |
69 | Office Action from U.S. Appl. No. 10/571,148 mailed Sep. 10, 2010. |
70 | Japanese Patent Office, Office Action in App. No. 2011-524128, Aug. 25, 2013. |
71 | Notice of Ailowanct dated Dec. 4, 2014; for U.S. Appl. No, 13/405,406; 11 pages. |
72 | Communication from the Japanese Patent Office mailed Jul. 10, 2012, in Japanese application No. 2009-203514. |
73 | Office Action issued Oct. 18, 2013, in Japanese Patent Application No. 2008-206291 (with English-language translation). |
74 | Japanese Notice of Reasons for Rejection for Japanese Application No. 2010-032671; Date of Mailing: Aug. 20, 2013; with English Translation. |
75 | U.S. Appl. No. 10/392,697, dated Jan. 5, 2007 Final Office Action. |
76 | USPTO Jun. 27, 2013 Final Office Action from U.S. Appl. No. 12/968,163. |
77 | U.S. Appl. No. 11/416,473, Response to Rule 312 Communication mailed Jun. 11, 2010. |
78 | Office Action for U.S. Appl. No. 12/101,099 dated Apr. 19, 2010. |
79 | Advisory Action of U.S. Appl. No. 10/613,608 mailed Aug. 4, 2005. |
80 | Notice of Allowance dated Jan. 20, 2012, U.S. Appl. No. 12/349,513, filed Jan. 6, 2009. |
81 | Notice of Rejection issued on Jul. 27, 2010 in related matter Japanese Patent Publication JP 2007-540191. English translation provided by Kashiwabara International Patent Bureau. |
82 | U.S. Appl. No. 12/022,098 Office Action dated Mar. 16, 2009. |
83 | Korean Notice of Allowance for KR Appl. No. 10-2011-7002566 dated Sep. 26, 2011. |
84 | Non-Final Office Action for U.S. Appl. No. 09/753,982; Mailed on Nov. 9, 2004; 8 pages. |
85 | Official Action for U.S. Appl. No. 11/782,569, mailed Oct. 12, 2010. |
86 | English Translation of Japanese Patent Application No. 2013-083152 Office Action dated Oct. 21, 2014. |
87 | Nov. 22, 2011 Japanese official action in connection with a counterpart Japanese patent application. |
88 | Office Action for Swiss National Phase Patent Application No. 01183/14, mailed Mar. 24, 2016, 3 pages. |
89 | Notice of Reasons for Rejection dated Aug. 9, 2016 corresponding to Japanese Patent Application No. 2013-012447 and English translation thereof. |
90 | European Patent Application No. EP-06804122.7, Official Letter mailed Jan. 25, 2011. |
91 | Notification of First Office Action in counterpart Chinese Patent Application No.<PHONE_NUMBER>77.7 dated Dec. 24, 2010. |
92 | China Office Action for Application No.<PHONE_NUMBER>70.6, Aug. 5, 2010, Panasonic Corporation. |
93 | 'U.S. Appl. No. 14/207,476, Non Final Office Action mailed Jun. 13, 2014'. |
94 | Japanese Office Action dated Jul. 20, 2010 in Japanese Application No. 2004-167589. |
95 | Official Communication for Australian Patent Application No.<PHONE_NUMBER> dated Feb. 2, 2015. |
96 | “U.S. Appl. No. 15/072,484, Response filed Jul. 6, 2017 to Non Final Office Action dated Jan. 6, 2017”, 7 pgs. |
97 | USPTO; Office Action forU.S. Appl. No. 12/154,465, mailed May 4, 2012. |
98 | Final Office Action for U.S. Appl. No. 11/185,247, mailed Feb. 26, 2010. |
99 | Second Office Action Issued in Chinese Patent Application No.<PHONE_NUMBER>17.2, Mailed Date: May 25, 2015, 6 Pages. |
100 | Office Action from U.S. Appl. No. 11/888,251, dated Mar. 21, 2008.

Open questions

Need for further sub-classification? If yes, which sub-classes?
Fields to be parsed?
Corpus/ reference database for consolidation?

I leave these questions open to discussion.
Cheers

Did you have a look at patents-public-data:uspto_oce_office_actions on BigQuery? It could provide useful food for thought.

Follow up: The dataset is described in USPTO Patent Prosecution Research Data: Unlocking Office Action Traits.

The Office Action Research Dataset for Patents contains detailed information derived from the Office actions issued by patent examiners to applicants during the patent examination process. The “Office action” is a written notification to the applicant of the examiner’s decision on patentability and generally discloses the grounds for a rejection, the claims affected, and the pertinent prior art. This initial release consists of three files derived from 4.4 million Office actions mailed during the 2008 to mid-2017 period from USPTO examiners to the applicants of 2.2 million unique patent applications.

--> partial coverage, still can help shape the parsing strategy and address part of the consolidation task.

application_id: the unique application number + conolidation from grobid?
document_cd: document code identifying the type of document issued by the examiner. For the USPTO, it can be CTNF (non final rejection) or CTFR (final rejection) -> we will certainly extend the possible categories
maild_dt: mail date


How can I update the "New Document menu" from the PnP Provisioning Template?

Modern libraries allow you to edit the "New" menu based on the normal default document templates for Office Online.
Although this is something I can action through the browser, I have exported the template and cannot see any settings which would affect this.

@MartinHatch I know it's been a long time but if you still have a need for this please see my answer here for a way to accomplish this.


does ROCm support R9 280x  ？

Sorry, that is Tahiti class hardware,  The base Linux driver we run on only take only back to Hawaii class GPU.

ok i see


ci: disable failing test in OR-CI

[skip ci]
Not clear if this is of interest to OL team, but below are the reasons for the failures. They do not have anything to do with OR. You can get full logs here.

BM64
[ERROR]: 16 errors found by Verilator
[ERROR]: Step 0 (verilator_lint_check) failed with error:
-code 1 -level 0 -errorcode NONE -errorinfo {
    while executing
"throw_error"
    (procedure "run_verilator" line 35)
    invoked from within
"run_verilator"
    (procedure "run_verilator_step" line 3)
    invoked from within
"run_verilator_step"} -errorline 1
[INFO]: Saving current set of views in 'designs/BM64/runs/openlane_test/results/final'...
[INFO]: Generating final set of reports...
[INFO]: Created manufacturability report at 'designs/BM64/runs/openlane_test/reports/manufacturability.rpt'.
[INFO]: Created metrics report at 'designs/BM64/runs/openlane_test/reports/metrics.csv'.
[INFO]: Saving runtime environment...
[ERROR]: Flow failed.
make: *** [Makefile:184: test] Error 255
script returned exit code 2

y_huff
[INFO]: Running Synthesis (log: designs/y_huff/runs/openlane_test/logs/synthesis/1-synthesis.log)...
[ERROR]: Yosys checks have failed: Encountered check error:
Warning: Wire y_huff.\Y_AC_run_code[11] [7] is used but has no driver.
[...]
child process exited abnormally
[ERROR]: See the full report here: designs/y_huff/runs/openlane_test/reports/synthesis/1-synthesis_pre_synth.chk.rpt
[ERROR]: Step 1 (synthesis) failed with error:
-code 1 -level 0 -errorcode NONE -errorinfo {
    while executing
"throw_error"
    (procedure "check_synth_misc" line 13)
    invoked from within
"check_synth_misc $report"
    (procedure "run_synthesis_checkers" line 5)
    invoked from within
"run_synthesis_checkers $log $pre_synth_report"
    (procedure "run_synthesis" line 19)
    invoked from within
"run_synthesis"} -errorline 1
[INFO]: Saving current set of views in 'designs/y_huff/runs/openlane_test/results/final'...
[INFO]: Generating final set of reports...
[INFO]: Created manufacturability report at 'designs/y_huff/runs/openlane_test/reports/manufacturability.rpt'.
[INFO]: Created metrics report at 'designs/y_huff/runs/openlane_test/reports/metrics.csv'.
[INFO]: Saving runtime environment...
[ERROR]: Flow failed.
[INFO]: The failure may have been because of the following warnings:
[WARNING]: 19 warnings found by Verilator
make: *** [Makefile:184: test] Error 255
script returned exit code 2

Is there an option to skip Verilator (or at least ignore failures) that we could use for these frozen designs?

I'd rather fix the warnings or errors rather than removing the designs entirely. Is this a blocking issue for you ?

@vvbandeira can you just disable verilator for these instead?

@kareefardi, thanks for the tips. I have disabled the quit-on error for the designs, and now the flow completes -- although with fanout violations.


Make updated_at have the same value as inserted_at

An attempt to fix #2633. Kudos to @fertapric for the idea.

I miss some tests asserting that both values are the same 🙂

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

Thank you @qcam for all the help in all of those issues and thank you @fertapric for the amazing reviews! \o/

Hi @qcam and @fertapric! I have invited you to the contributors team in the Ecto organization! The invitation is just to formalize your contributions. You don't have to worry about it or change anything in the way you are contributing to the project. Thank you for all of your work!


[Starter Set] Starter pack

im not seeing the starter package in any of my journal entries or compediums. The package didnt basicly add anythingFrom: MajRikerfoundry: 12.331wfrp4e: 8.2.3wfrp4e-core: 6.0.1wfrp4e-ua1: 6.0.1Active Modules: dice-so-nice, warhammer-lib, wfrp4e-character-details, wfrp4e-gm-toolkit

You do not have the Starter Set enabled in your World.


Minor fixes

Output test results in junit format and upload them as artifacts and populate the Test Summary view
Use npm install instead of npm ci as npm ci seems to regenerate the node_modules directory even if it exists
Add some comments to guide users who wish to adapt the config for usage with yarn
Remove yarn.lock and Dockerfile for now as they are not used
Simplify config.yml

Going ahead to merge this but please feel free to add on your revisions!

@jkzilla After more reading up I realize npm ci together with caching the npm cache as you originally had done might be even faster so feel free to restore those changes (together with making sure npm 6 is used)!

@lokst are we supposed to get this using orb syntax ? you can use the node orb's default executor, for example. or use any random executor and install node w/ the orb

Hi @iynere The goal of these PRs was to fix any issues in the current master branch (which does not currently use orbs) first. We could have orbs and non-orbs branches (one of them could be the master branch I guess) so that Server customers have something to reference too. Do you know if the node orb is ready to be used in the sample project?

@lokst the node orb is fine to be used right now, it could use more added to it but everything that's in it should be ok to use


StreamProcessor.Stop doesn't take effect

While trying to stop a StreamProcessor ( in order to stop event consumption ), I got this error as "info" in the logs, and the event consumption kept working...
[NakadiClient] executor service did not shutdown cleanly java.util.concurrent.Executors$FinalizableDelegatedExecutorService@319003ee

At that time I was using nakadi-java version: 0.9.17, but then upgraded it to 0.13.0, but that didn't help either.
Is there a way to totally shutdown a StreamProcessor?

We found out that we had two places in the code that start the StreamProcessors. Leaving a referenced one, and a non-referenced one. When ask to stop one, only the referenced gets stopped, while the other one keeps running in the background. We fixed that in our code.

@BaraaBathech thanks for following up, much appreciated. Are you happy this isn't an issue with the library or its documentation?

@dehora I think it is not related to the library or the documentation, it is more of how the ExecutorService coming with java is behaving.


Spelling error in pull request template

Spelling mistake in the pull request template
affects:
InsanityNetwork/InsanityBot/master@035510b (latest)
InsanityNetwork/InsanityBot/2.0.0-dev@2c0c448 (latest)

May I ask what spelling errors there are?

@ExaInsanity Please open a PR for any updates you want done to any of the files.

closed by #46

Fixed in #46


add restaurant address in footer

missing restaurant adderess


RealtimeIt#testExtraTrip fails for some local time zones

I just ran the tests for the current master using the time one UTC+10:00 and the test RealtimeIt#testExtraTrip failed. If I change my time zone to Shanghai UTC+08:00 it works. If I change my time zone to Perth AWST (same time as UTC+08:00 right now), it fails.
Maybe @michaz you have an idea what might be happening here? In the test we define the time zone, but maybe the server itself runs on a different time zone?

Haha, nice. I probably left some debug or mock thing in there which uses the "current" time zone. Good that we are a global team. :)

(Will look at it today)

As we stumbled over this recently #1209 maybe we should use something like the policeman tools?
https://github.com/policeman-tools/forbidden-apis/wiki
http://blog.thetaphi.de/2012/07/default-locales-default-charsets-and.html

maybe we should use something like the policeman tools?

I second that! I think this is a good idea :). I created a PR #1213 testing the policeman tools.

Any updated on this @michaz? Could we ignore this test until the problem is solved?

Just a second..

That was a really helpful ticket, thanks for reminding me!

Thanks so much for fixing this @michaz!


Unify iterators

This PR fills some gaps in the set of iterators to cover environments
and to make all string iterators use the is_na() methods rather than Option<&str>.
The environment method as_env() now returns the parent and an iterator over elements
of  the environment.
The PartialEq operator only compares pointers for environments, so enva == envb will
just compare SEXP pointers,
The integer and real iterators return actual i32 and f64 values instead of references which
will make it easier to write stats functions.

There's a stack overflow error on Windows:
https://github.com/extendr/extendr/pull/124/checks?check_run_id=1697541518#step:8:92
The error on macOS seems to be related to the R setup, not your code.

There's a stack overflow error on Windows:
https://github.com/extendr/extendr/pull/124/checks?check_run_id=1697541518#step:8:92
The error on macOS seems to be related to the R setup, not your code.

The windows error is in the rprintln tests which use pipes. I'm not sure how well this is supported on windows.
It may be worth putting a [cfg] guard around the test.

The windows error is in the rprintln tests which use pipes. I'm not sure how well this is supported on windows.
It may be worth putting a [cfg] guard around the test.

We do not increase the stack size for windows, it seems:
            if cfg!(not(target_os = "windows")) {
                R_CStackLimit = usize::max_value();
            }

Is there a reason for this. Maybe a more conservative value would work, such as 32MB?

We do not increase the stack size for windows, it seems:
            if cfg!(not(target_os = "windows")) {
                R_CStackLimit = usize::max_value();
            }

Is there a reason for this. Maybe a more conservative value would work, such as 32MB?

Here's a discussion about the stack size and the error:
https://github.com/extendr/extendr/issues/129#issuecomment-761196797

Here's a discussion about the stack size and the error:
https://github.com/extendr/extendr/issues/129#issuecomment-761196797


Configurator vpn module

This PR is not auto merge-able as it deviated from base branch (configurator). Closing this as a new PR is #111


fix: Add missing validation for LegacyMetrics APIKey

Which problem is this PR solving?

Adds missing validation to LegacyMetrics.APIKey.

Short description of the changes

Add api key format validation
Regenerate files

The reason this wasn't specified as an apikey format is that we often have example files that specify "yourkeyhere" or something like it -- for classic keys, that won't conform to the format. "SetThisToAHoneycombKey" is a valid modern format. I'm OK with enforcing it but it might cause some problems with demo data.


Fieldmanager

Add Fieldmanager

@tomharrigan the framework is now listed on the site https://includewp.com/
The scraper didn't find any matching plugins/themes on .org so either no one is using it, or something wrong with the thumbprint. If you know there's a plugin/theme using it for sure, please share the URL so we can check why it wasn't recognized.


Debugging tests in vscode -  No breakpoints being hit

I'm trying to setup vscode to debug tests, I haven't been able to find any guidance.
The tests run fine, but breakpoints are not hit. Any one have a working setup for debugging tests in vs-code?
node: 9.5.0
jest: 21.2.1
react-app-rewired: 1.4.1
My vs-code launch.json
{   "version": "0.2.0",   "configurations": [     {       "name": "Debug Jest Tests",       "type": "node",       "request": "launch",       "program": "${workspaceFolder}/node_modules/.bin/react-app-rewired",       "env": {},       "args": [         "test",         "--env=jsdom",         "--testPathPattern",         "ActionButton.test.js"         //"--testNamePattern",         //"renders the loading state",       ],       "protocol": "inspector",       "console": "integratedTerminal",       "internalConsoleOptions": "neverOpen"     }   ] }

Hey, @thejuan!
Do you remember, what was the solution for you?

This post is quite old, but i run in the same issue.
Below some lines of the config-overide.js that should work to force the Debug-Mode in VSCode:
const paths = require('react-scripts/config/paths');
module.exports = {
    webpack: (config) => {
        config.output = {
            path: paths.appBuild,
            pathinfo: true,
            filename: 'static/js/[name].[hash].js',
            chunkFilename: 'static/js/[name].[hash].chunk.js',
        };
        return config;
    },
};


Add option to have coordinates around the edge of a print

It would be useful to be able to be able to have coordinates spaced out along the edges of the map. This functionality was available in the previous version.

This should use the users current view projection.

https://viglino.github.io/ol-ext/examples/canvas/map.control.graticule.html


KAMI status: Unconnected

I have an issue, get status Unconnected while playing Killzone 2 on RPCS3 0.0.22 13635-7c8fbc35 Alpha master
Kami is not really working

What i am doing wrong ?

You need the special IPC build which is impossible to get unless you know how to build your own version.

so Kami is useless for official RPCS3 builds ?

Correct, requires the IPC PR build.

IPC has been merged into mainline rpcs3, use build 0.0.22-13800 or newer


Cover a wider range of telemetry data?

This proposal is rather motion centric (It was my initial concern after all), but @SHWotever of SimHub (https://github.com/SHWotever/SimHub) asked the question about including a greater range of telemetry, and the potential this could have for helping indie game developer know what to provide, as well as the simplicity it could lead to for integrators.
Spitballing how to achieve this we came up with the idea of an initial endpoint that lists primary data, which could provide links to additional endpoints, split by relevant data.
Some examples:

Racing games
Flight simulation

The advantage of this is that it would allow for staging of each schema, and future creation of new schema types for games genres we are unaware of at this point

Via pmvcda on Xsimulator:
Telemetry for motion
Telemetry for transducers
Telemetry for lighthing (yes, sun position and cloudness)
Telemetry for dashes
Telemetry for driving analysis
Units used for each value


Javascript SDK DefaultAzureCredentials stops working under high load

Package Name:  @azure/identity"
Package Version: 1.1.0
Operating system: Linux
[x] nodejs

version:  12.13.0

[ ] browser

name/version:

[ ] typescript

version:

Is the bug related to documentation in

[ ] README.md
[ ] source code documentation
[ ] SDK API docs on https://docs.microsoft.com

Describe the bug
We have a cluster with many pods running NodeJS. We use managed identity to access Azure resources, and for this we use DefaultAzureCredentials from the javascript SDK. What we observed is that under heavy load after some point some pods cannot get a token anymore, basically they end up in a zombie state and cannot access any Azure resource.
To Reproduce
Many pods using managed identity.
Additional context
Add any other context about the problem here.
We believe that the issue is that ManagedIdentityCredentials class caches the negative results, if a call timeouts then getting the token will not attempted anymore:
https://github.com/Azure/azure-sdk-for-js/blob/dcae3ace0872180e0a542a00ca8c8c0b427def42/sdk/identity/identity/src/credentials/managedIdentityCredential.ts

 	      // the latter indicating that we don't yet know whether
	      // the endpoint is available and need to check for it.
	      if (this.isEndpointUnavailable !== true) {
	        result = await this.authenticateManagedIdentity(
	          scopes,
	          this.isEndpointUnavailable === null,
	          this.clientId,
	          newOptions
	        );

	        // If authenticateManagedIdentity returns null, it means no MSI
	        // endpoints are available.  In this case, don't try them in future
	        // requests.
	        this.isEndpointUnavailable = result === null;
	      } else {
	        const error = new CredentialUnavailable(
	          "The managed identity endpoint is not currently available"
	        );
	        logger.getToken.info(formatError(error));
	        throw error;
	      }

@balazsmolnar Hello! I'm Daniel, I'll be doing my best to help you.
Recently, we did considerable fixes to the Managed Identity Credential. Out of a quick guess, I believe that our fixes could have had a positive impact to resolve this issue.
What we recently did was: https://github.com/Azure/azure-sdk-for-js/pull/11426
These changes will go out next week. Before we release, I'll do my best to reach to a conclusion on what addresses this issue. If our recent changes don't fix this issue, I'll do my best to provide a fix before our upcoming release.
I'll be able to provide an update by Monday! Thank you for your patience.

@balazsmolnar We're actively talking about this internally. In the mean time, do you mind answering me the following questions?

Do you have a sample code we could try?
Do you have the HTTP logs relative to the exception? Or at least some portion of the logs?
Where is this running? In Azure containers, for example? The details of the environment can help immensely.
For how long was this running without trouble? Or: How many iterations did this run without trouble?

@balazsmolnar If you decide to share some logs with us, please remember to remove any information about your credentials, secrets or passwords.
We will be releasing tomorrow an update to the Identity library that might help your case, but to be sure we would need more information indeed. Thank you for submitting this issue! We want to make sure your issue is resolved. Take your time on providing us as much information as possible.

@sadasant Thanks for looking into it!
We have an AKS cluster in Azure which uses managed identity to access some of the resources e.g. Storage Account, it's pretty basic:
const transferBlobClient = new BlobServiceClient(
      `https://${transferAccountName}.blob.core.windows.net`,
      tokenCredential, { retryOptions: retryOptions }
    );

Note that the credential is cached between requests.
The problem occurs under high load only so it's hard to reproduce. In our load test setup we provision 100 VMs to send requests to the server.
The errors we see in the logs:
EnvironmentCredential is unavailable. Environment variables are not fully configured. Error: ManagedIdentityCredential is unavailable. No managed identity endpoint found. Error: Azure CLI could not be found. Please visit https://aka.ms/azure-cli for installation instructions and then, once installed, authenticate to your Azure account using 'az login'. Error: Visual Studio Code credential requires the optional dependency 'keytar' to work correctly, stack: AggregateAuthenticationError: undefined Error: EnvironmentCredential is unavailable. Environment variables are not fully configured. Error: ManagedIdentityCredential is unavailable. No managed identity endpoint found. Error: Azure CLI could not be found. Please visit https://aka.ms/azure-cli for installation instructions and then, once installed, authenticate to your Azure account using 'az login'. Error: Visual Studio Code credential requires the optional dependency 'keytar' to work correctly at DefaultAzureCredential. (/app/node_modules/@azure/identity/dist/index.js:262:29) at Generator.throw () at rejected (/app/node_modules/@azure/identity/node_modules/tslib/tslib.js:112:69)
Our workaround for the issue is that we cache the access token for a minute to prevent overloading the managed identity endpoint, and we always create a new instance of DefaultAzureCredentials.
Let me know if you need more information.

@balazsmolnar To help us narrow this issue down, we'll be asking you to test our latest Identity beta version once we release it, most likely today. I'll follow up with instructions as soon as I'm able to. Thank you for your time!

@balazsmolnar Hello! I hope things are going good for you!
We have released<EMAIL_ADDRESS>Please install it and try again. Your feedback will help us narrow down this issue.

@sadasant I can test it early next week, I will let you know the results.

@balazsmolnar thank you!

@sadasant We tested the fix yesterday, and I'm happy to report that we did not experience any managed identiy related issue. Thnk you for the fix!

@balazsmolnar that's awesome! Thank you so much. I'll close this issue for now. Feel free to re-open this issue or make any other issue anytime! We're here to help 👋


Use object-fit: cover in gallery grid

I think this fixes #184. I did not test this locally, only in the developer tools of the browser.

I shell test this, but I have the feeling this does not produces the correct result. (See details in the bug)

I had a quick look and it seems in Firefox it crops the photo, while in Chrome it increases the distortion. :/


HSEARCH-2500 backport to branch 5.5

This PR is a partial backport of #1258, so we'll have to merge that one into master first.
Relevant ticket: https://hibernate.atlassian.net/browse/HSEARCH-2500
This is a backport of HSEARCH-2500 for branch 5.5. Branch 5.5 doesn't actually need a fix, but the "instanceof TikaBridge" hack wasn't needed on this branch in the first place. So we might as well remove it and add the tests to make sure it isn't needed.

Merged https://github.com/hibernate/hibernate-search/pull/1261


don't hide exceptions' traces when wrapping

This fix re-raises exceptions keeping their stacktrace to facilitate debugging

@Lacrymology nice, but doesnt work in python3. Can you adapt please?


doc:Updates to Doc

Added Documentation for ad4110-1
Corrected typo in AD717x iio
Added ad411x to title in console and iio projects. Arranged TOC alphabetically.

Curious question- we dont have the AD4110-1 project in this repo yet. Any idea why the documentation is being added?

Curious question- we dont have the AD4110-1 project in this repo yet. Any idea why the documentation is being added?

Removing the documentation based on offline discussion

Hi @CMinajigi @ribdp, are there any more comments on this PR?

Hi all, I have added iio osc timeout limitation fix also to this PR, so that for future projects a note can be added pointing to this with the capture_timeout value that needs to be set for that particular project.

Hi all, are there any more comments on this PR?


Do not used Rubix parallel warmup by default

Stress testing showed that Rubix caching is not stable with parallel
warmup enabled. Temporarily diabling by default.

@losipiuk you probably need to update TestRubixConfig

@losipiuk you probably need to update TestRubixConfig

True - just noticed :)

@stagraqubole you expressed concerns about this change in #3592

We didnt discuss this much in the initial PR, we fixing on read-through mode by default now? read-through will impact the query times when query hits the cold cache

I agree that it may decrease performance. On the other hand currently we have correctness issues if we use parallel-warmup. I think it justifies to temporarily disable it by default. We should revert this change as soon as we update rubix library to one with fix.

Ah, missed this one.
Fixes to parallel warmup are now under review (https://github.com/qubole/rubix/pull/368), I thought we should be able to get the fixes in before next presto version. But makes sense to not take the chance and disable it by default.

I thought we should be able to get the fixes in before next presto version. But makes sense to not take the chance and disable it by default.

Let's revert this after parallel warmup is fixed

@losipiuk please create an issue for pre-warm bug

@losipiuk please create an issue for pre-warm bug

It is there. Even mentioned in comment in this PR:
// TODO enable by default again after https://github.com/prestosql/presto/issues/3494 is fixed


Is this module have duplicate npm packages ?

I npm installed following module, but it's still v0.1.0.
https://www.npmjs.com/package/webpack-strip
However, I found the same module with the latest version v0.1.2.
https://www.npmjs.com/package/strip-loader
Are these modules are duplicated?
If so, please update webpack-strip.

+1
Got caucght using webpack-strip, had a problem (it strips even in dev mode)
then tried strip-loader...


wifi scan not showing anything

when the config portal starts it does not show any available WiFi stations. Why not?

Im having the same problem

I'm having the exact same problem...

Hi all, I’m also having the same problem.
Any suggestions yet on what could be the issue?

I added:
    // Set WiFi to station mode and disconnect from an AP if it was previously connected
    WiFi.mode(WIFI_AP_STA);
    WiFi.disconnect();
    delay(100);
    Serial.println("WiFi to station mode and disconnect from an AP if it was previously connected");

    Serial.println("scan start");
    // WiFi.scanNetworks will return the number of networks found
    int n = WiFi.scanNetworks();
    Serial.println("scan done");
    if (n == 0) {
        Serial.println("no networks found");
    } else {
        Serial.print(n);
        Serial.println(" networks found");
        for (int i = 0; i < n; ++i) {
            // Print SSID and RSSI for each network found
            Serial.print(i + 1);
            Serial.print(": ");
            Serial.print(WiFi.SSID(i));
            Serial.print(" (");
            Serial.print(WiFi.RSSI(i));
            Serial.print(")");
            Serial.println((WiFi.encryptionType(i) == WIFI_AUTH_OPEN)?" ":"*");
            delay(10);
        }
    }
    Serial.println("");

before the wifiManager.startConfigPortal() or the wifiManager.autoConnect()
I think the first 2 lines is really what fixes it ... but the rest gives you some troubleshooting to go by. My issue was that the number of networks returned as -2
This should be added to the void WiFiManager::handleWifi(boolean scan) right after the
int n = WiFi.scanNetworks();
if(n == -2) DEBUG_WM(F("scan not triggered"));
if(n == -1) DEBUG_WM(F("scan not finished"));
-2 is scan is not triggered and -1 is that it didn't finish


Fix open/create of UTF8 names

re: issue https://github.com/Unidata/netcdf-c/issues/1666
The code in NC_open and NC_create (in dfile.c)
was using improper testing for leading whitespace chars.
It was treating UTF-8 as whitespace.
Fix is to do tests using unsigned char.

Are you going to add a test?

@DennisHeimbigner I will pull this into a branch and add the test, I'm in a good spot to do that anyways.

Sorry about forgetting a test.


bugfix: stop ignoring first line of imported email

I have stumbled upon a bug where almost all of the restored emails were corrupted. The emails in question seemed to have almost the same text but the formatting was all over the place and some of the words were mangled badly. HTML tables were broken.
Upon investigation I noticed that actual body of the email in the original .eml file and one downloaded from Googles "Download message" was practically identical with exception of few headers. One of those headers was Content-Transfer-Encoding which happened to be very first line of each corrupted email.
Example diff:
$ diff docker_meetup_email_after_gyb_restore.eml original_docker_email.eml
1,11c1
< Authentication-Results: mx.google.com;
<        dkim=neutral (body hash did not verify<EMAIL_ADDRESS>header.s=s1 header.b="Ivpq/sFe"
< X-Google-Smtp-Source: AGHT+IGEy4ty3doaMTjFqiOkSsSCpk9NLEy/NCs28XMnDJUGPy5CZ54yo2foi5usb9P4cI1hNo4Fqzyh56Lj5OK1xw==
< Received: from<PHONE_NUMBER>27
<       named unknown
<       by gmailapi.google.com
<       with HTTPREST;
<       Fri, 1 Nov 2024 20:03:11 +0000
---
> Content-Transfer-Encoding: quoted-printable
46a37
> X-Google-Smtp-Source: AAOMgpen7PSnhPReh9WOrpUPOxq9IhkBBjd6pokoxWeGNf9xtEIQtwHrvjIF7wax5u3067qhdJYI
$

After looking into the source code of fmbox.py I noticed that constructor of class fmbox() advances the self._file when initialising the _last_from_line but does not rewind it back which effectively produces a message that is stripped of first line.
Presumably this is not a problem when a message starts with a From header but it is when it's anything else.
At this point I am not sure if this is provider specific or what, but for some context, my .eml files have been created by Proton Mail export tool. The same emails were imported from Google Takeout to Proton few years earlier if that matters.
I have tested the fix by importing about 500 messages and they all display correctly.
This is also likely related to the problem @infovations has seen in  https://github.com/GAM-team/got-your-back/issues/148 as well as #157

Hmmm...
So this is a difference between mbox files where the first line is the From delimiter (see https://en.wikipedia.org/wiki/Mbox) and .eml files where the first line is an email header.
The proper fix here would be to examine that first line and if it's actually "From " (notice no :) then remove that first line.


Promote HVPA feature gates to beta

How to categorize this PR?

/area auto-scaling
/kind enhancement
/priority normal
What this PR does / why we need it:
With this PR we promote the HVPA feature gates to beta as the features are quite stable meanwhile.
Which issue(s) this PR fixes:
Fixes #2724
Special notes for your reviewer:
/invite @ggaurav10 @amshuman-kr
Release note:

The `HVPA` and `HVPAForShootedSeed` feature gates have been promoted and are enabled by default. You can still disable them explicitly if you prefer so.

/close due to the upcoming HVPA redesign


field name change between database stack deploys

I created 2 cloudformation stacks for this a few years ago, and the schema fields that represent multiple words like requestip and hostheader are single words as typed here.
In December 2019, the fields were updated to use snake_case to conform to AWS Cloudfront specs:
https://github.com/aws-samples/amazon-cloudfront-access-logs-queries/commit/c76192a2dfd0881ef404a31977aefda26911e34f
I created a 3rd stack for new product sites after this, and the schemas don't match.  I have a service that runs queries to find bot crawl numbers, and I'm going to have to come up a  way to construct the WHERE clauses to differ based on which database is accessed.
Is there a way to safely modify the older 2 stacks to the new snake_case field names?

Hi @leecookson, sorry to hear that the stack did not cope well with the schema evolution. Can you confirm, please: Did the data in the two older stacks change at some cut off date from requestip to request_ip for new data deliveries (if so, when?) or does it continue to be requestip?

the original stacks still have the pre-scheme-change field names.  I've adapted by configuring things like host_where_clause clause and user_agent_field_name along with product-specific query configuration.  These values get spliced into the SELECT statements so they work properly for both old and new stacks.  Since I already had config per-product for database name and host header value, adding these wasn't a big problem, but still an awkward compromise.
I've never re-deployed the cloud formation stacks once deployed, and if I had, I guess it could have broken existing queries using the no-hyphen field names.

I haven't tried it myself, but if you want to create a new stack for the old data, you need to recreate and reconvert the partitions with a script (or an AWS Glue crawler) from the gzipped files to get rid of all old schema names.
The easier way if you just want to query the old stacks and the new ones with a uniform query, is to wrap the old combined view with a new view such as:
CREATE OR REPLACE VIEW "combined2" AS
SELECT
  requestip request_ip,
  hostheader host_header
  [...]
FROM
  combined

Would the latter work in your case?

@leecookson, could you resolve this?


Wrong result for self-defined inputs

System: ubuntu 14.04 LTS
Environment: Python 3.6.4
Description: I set my own test case to run the palletier but the solver.print_solution() function print the wrong answer, in which two object are overlapped. My test case is as follow:
6.text
1
120, 100, 120
40, 26, 22, 4
35, 21, 29, 4
30, 44, 24, 4
Is it the problem of my setting of pallet dims?

The result of my test case is:
Box #0 with dims (40, 22, 26) located at (0, 0, 0)
Box #1 with dims (40, 22, 26) located at (40, 0, 0)
Box #2 with dims (40, 22, 26) located at (80, 0, 0)
Box #3 with dims (40, 22, 26) located at (0, 0, 26)
Box #4 with dims (35, 21, 29) located at (40, 0, 26)
Box #5 with dims (35, 21, 29) located at (75, 0, 26)
Box #6 with dims (35, 21, 29) located at (5, 0, 52)
Box #7 with dims (35, 21, 29) located at (5, 0, 55)
Box #8 with dims (44, 30, 24) located at (0, 22, 0)
Box #9 with dims (44, 30, 24) located at (44, 22, 0)
Box #10 with dims (24, 30, 44) located at (88, 22, 0)
Box #11 with dims (44, 30, 24) located at (44, 22, 24)
It can be found that box 6 and box 7 are overlapped.

Hey @Magic-Fang. is the problem still present? I see the overlap but I'm not sure what might be causing it.

Hi @Magic-Fang were you able to fix the overlap error? I have the same issue when I use my own data sets. Also, I would like to add different dimensions of the pallet in a single run. Is it possible to do that?

Hi @alanbato, and thank you very much for this library. I found the problem that causes the overlapping of boxes. Basically when the algorithm goes from right to left (situation 2) at a certain point the coordinates are updated considering the highest x of the last box placed, while there are previous boxes already packed which are occupying space.
In the example attached (plot as 2d for the sake of simplicity) you see the sequence used by the code for packing. 1,2,3,4 then the algo starts moving on the left packing 5 and 6. At box 7, the edges to evaluates are [Corner(x=32, z=44), Corner(x=80, z=36)] while they should be [Corner(x=64, z=44), Corner(x=80, z=36)] because of box 5.
I've not the overall picture of the algo so I've not found a solution yet. May you help?
Thanks


feat: 70-connection-implementing-openconfirm-handshake

Description:
As a developer, I want to be able to use the Open Confirm Handler to specify custom logic for handling confirmation messages, such as verifying the authenticity of the message or triggering additional actions based on the contents of the message.
Commit Message
feat: implement openconfirm handshake

see the guidelines for commit messages.
Checklist:

[x] I have performed a self-review of my own code
[ ] I have documented my code in accordance with the documentation guidelines
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have run the unit tests
[x] I only have one commit (if not, squash them into one commit).
[x] I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Codecov Report

Merging #216 (6956b32) into main (697a59d) will increase coverage by 0.68%.
The diff coverage is 83.04%.

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   57.74%   58.42%   +0.68%
==========================================
  Files          68       69       +1
  Lines        6562     6733     +171
==========================================
+ Hits         3789     3934     +145
- Misses       2773     2799      +26

Impacted Files
Coverage Δ

...asm-vm/cw-ibc-core/src/ics03_connection/handler.rs
83.64% <80.79%> (-6.84%)
:arrow_down:

...vm/cw-ibc-core/src/ics03_connection/conn2_types.rs
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Added ?support? for scrolling.

Hello, I thought the best was to give you a pull request so you can see what i tried to do to add scroll support.  I m sure I am not using your calls correctly, as you can see that how I got it to work differs from your code.
I do think it is best for you to have the  support to turn it on or off many people using your lib will not know how to do as you suggested.  Please feel free to see what I tried to do, than reject it as I know if you do it it will be done better.

I have merged your PR and will test and update it as necessary. the byte modifications are correct as per the data sheet.


Convert ServerVersion to downstream env var

Don't sync with settings sync handler, instead pass as env var to downstream cluster agent. If that cluster-agent contains the Rancher controllers then it should pick up this env var, if it doesn't (local rancher install downstream) then it should not.

Adding @rmweir for dev-validate. @jakefhyde let us know when its ready for validation.

removing dev-validate because this is now a more complex test

Root cause
The server-version setting does not propagate to downstream clusters, which causes issues when a downstream requests a chart that is only available for a specific version (range) of rancher.
What was fixed, or what changes have occurred
The server-version setting is now being passed in the cluster-agent template as the CATTLE_SERVER_VERSION environment variable.
Areas or cases that should be tested
Chart install, edit, upgrade, uninstall, as well as install, upgrade rancher, and then edit.
Testing should be done with rancher installations using a valid semver server version (v2.6.1, rc, etc)., versions which have special meanings (dev, master, master-head), as well as default developer versions which default to git short hashes (e.g. 3eaa377d3).
What areas could experience regressions ?
Downstream clusters have defaulted to using dev as the server-version at least are early as 2.6. Catalogs and KDM query server version, and non production setups may be affected.
Are the repro steps accurate/minimal ?
Todo

Assigning @brendarearden for dev-validate here.

Validation: PASSED
Steps to Test:

Installed HA Rancher v2.6.0
Created downstream DO cluster, rke, k8s v1.21.5
In downstream cluster add new chart repository - url: https://github.com/jakefhyde/charts branch: add-min-rancher-version
Navigated to charts and validated that I was able to see all of the chart version that met the rancher-version annotation requirement
Example list from rancher-istio chart:

Then I upgraded the rancher instance to Rancer v2.6.1-rc5
Naviated to charts and validated that on the charts the met the rancher-version annotation requirement were listed and available in index response.
Example list from rancher-istio chart after upgrade:


[5.4] Add clearPunctuation and clearWhitespaces methods to Support\Str class

No plans on adding this to core.


Add INSTANCE_ORIGINAL_TIME column to instances. Implements #564

This adds a column to the instances table to hold the original date and time of an instance. To make this easier instance creation has been refactored into smaller components.
This is a prerequisite for recurrence support.

@lemonboston I've fixed the tests. Please check again.

That's odd. The -timezone Europe/Paris parameter doesn't seem to work on Travis :-|
qemu-system-armel: -timezone: invalid option

I removed the timezone argument for now to make it work.

Ok let's see how this works out.


ERROR: Could not build wheels for mamba-ssm, which is required to install pyproject.toml-based projects

Building wheels for collected packages: mamba-ssm
Building wheel for mamba-ssm (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [8 lines of output]
 somebody help!
  torch.__version__  = 2.0.1+cu117

  running bdist_wheel
  Guessing wheel URL:  https://github.com/state-spaces/mamba/releases/download/v1.2.0.post1/mamba_ssm-1.2.0.post1+cu118torch2.0cxx11abiFALSE-cp38-cp38-linux_x86_64.whl
  error: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:1131)>
  [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for mamba-ssm
Running setup.py clean for mamba-ssm
Failed to build mamba-ssm
ERROR: Could not build wheels for mamba-ssm, which is required to install pyproject.toml-based projects

Have you solved this problem?

Have you solved this problem?

I changed to another conda envs, then it worked just fine.

Have you solved this problem?

I changed to another conda envs, then it worked just fine.

To which python version?
You can use this to create a new version

conda create -n your_env_name python=3.10.13
conda activate your_env_name
conda install cudatoolkit==11.8 -c nvidia
pip install torch==2.1.1 torchvision==0.16.1 torchaudio==2.1.1 --index-url https://download.pytorch.org/whl/cu118
conda install -c "nvidia/label/cuda-11.8.0" cuda-nvcc
conda install packaging
pip install causal-conv1d==1.1.1
pip install mamba-ssm

if you has this error:
      running bdist_wheel
      Guessing wheel URL:  https://github.com/state-spaces/mamba/releases/download/v2.2.2/mamba_ssm-2.2.2+cu118torch2.1cxx11abiFALSE-cp310-cp310-linux_x86_64.whl
      error: Remote end closed connection without response
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for mamba-ssm
  Running setup.py clean for mamba-ssm
Failed to build mamba-ssm
ERROR: Could not build wheels for mamba-ssm, which is required to install pyproject.toml-based projects

you can download mamba*.whl and pip install it, by folllowing cmd.
wget https://github.com/state-spaces/mamba/releases/download/v2.2.2/mamba_ssm-2.2.2+cu118torch2.1cxx11abiFALSE-cp310-cp310-linux_x86_64.whl

pip install mamba_ssm-2.2.2+cu118torch2.1cxx11abiFALSE-cp310-cp310-linux_x86_64.whl


Server disconnect issue

When i add this mod to my modpack and load a world on a server, i cant connect to it. I am getting this error

:

https://www.curseforge.com/minecraft/modpacks/deathdusk

Its version 1.18.2, on fabric, with modversion 2.8.2.

Some players was also able to produce this bug with the current 2.0.9 version of my modpack. But i was unable to reproduce it.

Actually, I may have just figured out the issue. It may be caused by the sheer volume of recipes in the pack. I tried searching for the error message, and I found this issue in the Forge repository. I realize that this is a Fabric mod and modpack, but I can't help wondering if Fabric has the same limitation.
https://github.com/MinecraftForge/MinecraftForge/issues/6703
As a matter of fact, it looks like this might be a bug in Minecraft itself:
https://bugs.mojang.com/browse/MC-185901

Try with 2.0.10, and update minekea to latest update there. This should make it reproduce able.

The issue for me is that I can reproduce the crash both with and without my mod. If it is indeed a bug in Minecraft itself caused by too many recipes, there may not be a fix available other than finding a way to reduce the overall count (which basically means removing mods, as much as I hate to say it).
It might be worth posting this in the FabricMC issue tracker to see if there's anything that can be done within the loader itself similar to what Forge did in the link above. I will try to get that created tonight, unless you want to do it.

@TheButterbrotMan I just created an issue in the Fabric repo. Here's hoping!

Thank you! :)

@TheButterbrotMan since there isn't anything specific to Minekea that we were able to determine, I am going to go ahead and close this. If it is still a problem after the recent changes to the NBT Crafting mod, and you're able to determine that there is something about Minekea in particular that causes the bug, we can reopen it.


Viz: Maximal Image Projection

This work is being done on Colab, datatset_get_eyes_on_image_stack.ipynb.
Maximal Image Projection (MIP) is the basic 3D z-stack to 2D overview viz for microscopy slides. Technically "Minimal" because brightFIELD. This seems to be a pretty fundamental overview visualization of slide image stacks. The algorithm to make the 2D projection just sifts through the z-stack, and for each (x,y) column keep the lowest (darkest) pixel value for the 2D projection.

This would require loading all images into ram at same time, no?

https://jicbioimage.readthedocs.io/projects/jicbioimagetransform/en/stable/_modules/jicbioimage/transform.html

Same thing. Nice but heavy:

https://docs.scipy.org/doc/scipy/reference/tutorial/ndimage.html

this is just a numpy thing comparing 2 2D arrays, one image in ram at a time.

Just a wee bit of NumPy: https://stackoverflow.com/a/52085463
import numpy as np
import matplotlib.pyplot as plt
from skimage import io

path = "test.tif"
IM = io.imread(path)
IM_MAX= np.max(IM, axis=0)
plt.imshow(IM_MAX)

That's loading the whole stack as a single TIFF. Just do the same but one TIFF at a time.

And here's how to load/save TIFF to NumPy for manipulation by code. https://stackoverflow.com/a/7572079


tag 0.3.0 release

We got 0.3.0 last month in https://github.com/for-GET/know-your-http-well/commit/13858ba6c41fa74a8687ab784aa4574417935efa, but it'd be great to have a tagged release for MELPA.
Thanks!

@dunn pushed 0.4

💙


Avoid dead-lock on broker service when broker failed to load managed-ledger

Motivation
Recently we have seen that sometimes broker get stuck with dead-lock when it fails to load managed-ledger. From thread-dump it seems that when a thread tries to create a topic in concurrentOpenHashMap and if the thread fails to create topic due to failure in loading managed-ledger then same thread tries to remove topic from concurrentOpenHashMap which causes the deadlock and all io and web threads result in deadlock.
Broker version: 1.20
java.lang.Thread.State: WAITING (parking)
        at sun.misc.Unsafe.park(Native Method)
        - parking to wait for  <0x000000029e30d960> (a org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap$Section)
        at java.util.concurrent.locks.StampedLock.acquireWrite(StampedLock.java:1119)
        at java.util.concurrent.locks.StampedLock.writeLock(StampedLock.java:354)
        at org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap$Section.remove(ConcurrentOpenHashMap.java:305)
        at org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap$Section.access$200(ConcurrentOpenHashMap.java:181)
        at org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap.remove(ConcurrentOpenHashMap.java:143)
        at org.apache.pulsar.broker.service.BrokerService$3.openLedgerFailed(BrokerService.java:597)
        at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl.lambda$asyncOpen$7(ManagedLedgerFactoryImpl.java:260)
        at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl$$Lambda$255/449424498.apply(Unknown Source)
        at java.util.concurrent.CompletableFuture.uniExceptionally(CompletableFuture.java:870)
        at java.util.concurrent.CompletableFuture.uniExceptionallyStage(CompletableFuture.java:884)
        at java.util.concurrent.CompletableFuture.exceptionally(CompletableFuture.java:2196)
        at org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl.asyncOpen(ManagedLedgerFactoryImpl.java:259)
        at org.apache.pulsar.broker.service.BrokerService.lambda$10(BrokerService.java:568)
        at org.apache.pulsar.broker.service.BrokerService$$Lambda$247/1679793959.accept(Unknown Source)
        at java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:656)
        at java.util.concurrent.CompletableFuture.uniAcceptStage(CompletableFuture.java:669)
        at java.util.concurrent.CompletableFuture.thenAccept(CompletableFuture.java:1997)
        at org.apache.pulsar.broker.service.BrokerService.createPersistentTopic(BrokerService.java:565)
        at org.apache.pulsar.broker.service.BrokerService.createPersistentTopic(BrokerService.java:536)
        at org.apache.pulsar.broker.service.BrokerService.lambda$4(BrokerService.java:423)
        at org.apache.pulsar.broker.service.BrokerService$$Lambda$244/1271565658.apply(Unknown Source)
        at org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap$Section.put(ConcurrentOpenHashMap.java:275)
        at org.apache.pulsar.common.util.collections.ConcurrentOpenHashMap.computeIfAbsent(ConcurrentOpenHashMap.java:130)
        at org.apache.pulsar.broker.service.BrokerService.getTopic(BrokerService.java:422)
        at org.apache.pulsar.broker.service.ServerCnx.lambda$5(ServerCnx.java:481)
        at org.apache.pulsar.broker.service.ServerCnx$$Lambda$294/982643452.apply(Unknown Source)
        at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602)
        at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:614)
        at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:1983)
        at org.apache.pulsar.broker.service.ServerCnx.handleProducer(ServerCnx.java:448)

Modifications

Clean up topic map in different thread.

Result

It will prevent possible dead-lock when broker fails to cleanup failed topic.

I would say we shouldn't block 1.21 to wait for this fix though.

Yes, my bad. By mistake I selected 1.21 instead 1.22. And yes, this issue doesn't occur frequently and it's not blocking change for 1.21 so, I have changed it 1.22.

@rdhabalia Should we merge to 1.21 branch?

I think it's very likely to happen but it's small fix and will not create any issue for 1.21 so, we can take it.


File upload support

[ ] create an array of supported file types
[ ] create a default file uploader route
[ ] create options to upload to google cloud , aws_buckets ..


Removes an ineffective line of code

This PR removes an ineffective line of code in edit_link_save() with an undefined variable data.url.date (this is because data.url.date is not set in the function invoked via ajax, i.e. in yourls_edit_link() in functions.php).
Most probably this is just a leftover. Then the line should be deleted (as done in this PR).
If however you should (now) want to update the timestamp on edition, more code needs to be added to yourls_edit_link(): i.e. including the current timestamp into the update query, e.g. by setting $timestamp = date( 'Y-m-d H:i:s' );, followed by a query like e.g. $update_url = $ydb->query( "UPDATE $tableSETurl= '$url',keyword= '$newkeyword',timestamp= '$timestamp',title= '$title' WHEREkeyword = '$keyword';" );, and then finally adding 'date' => $timestamp to the hash/associative array returned in $return['url'] (much like it is already done in function yourls_add_new_link in functions.php).
In the latter case: just give me a nod, and I should be able to update the PR appropiately.

Yeah, probably leftover, or bad copypasta. Let's just assume that when you edit a link, you don't want the date changed. If you need a new date, you probably need a new link :)

Okidoki, thanks for merging!


Improve testability

Improve testability for Heroku actions
Why:

It was very coupled and difficult to test in isolation, there was pretty much one single integration test.

This change addresses the need by:

Making it easier to test and reason about Heroku functionality we want to use, by allows for smaller, faster and more focused tests.
Using mocks instead of depending on side effects because it was tricky to build a fake of the an AppBuilder, that has a lot of functionality and it is already being tested in our integration tests.
Using a mockist approach, that ensures the correct methods are called with the right arguments (this last part is wip)

Interested in opinions before I go much further with this. /cc @tute

Looks good to me! Left some comments and questions, will wait for your answers and we merge. Thank you! :smiley: :clap:

@tute I made the expectations a bit more specific, what do you think?

Left a question around ENV["TESTING"], all else looks good to me! :clap:

@tute What do think of this solution?

Looking great! A super minor nitpick, and a more real question. I think then we merge.

:clap: :smiley: :heart:

Yes, my idea is to eventually get it all removed. This is just a start. What are your thoughts?

Sounds good to me. Will loop in another pair of eyes before merging. @mcmire @jferris can you please let me know what you think?

Ping me tomorrow on this again, I'll take a closer look then.

Ping me tomorrow on this again, I'll take a closer look then.

Pinging @mcmire again!

I extracted some more examples, which I think makes the discussion even easier.

I don't know how hard it is, but I'd be interested in seeing the adapters restructured as other generators. We call some generators (like rspec:install), and I think it would be awesome if Suspenders could be broken down into largely calling a number of generators that you could opt in or out of.
That would also have the interesting effect of making it easier to pull in some Suspenders configurations after the fact, so you could opt out of mailer configs and then apply them later. This is something we've had a lot of requests for.
If that's particularly difficult, I could see the delegator-based adapter approach as a solid first step. Either way, I think it's great to see the app builder class getting broken up a bit; that thing has become massive and hard to navigate.

@jferris The idea me and @tute were tossing around was that of being able to call a generator for heroku whenever you want, not only when creating the app, because it turns out a lot of people forget about it (see #604). This is a first step towards that.

I don't know how hard it is, but I'd be interested in seeing the adapters restructured as other generators.

That's what I've called for too, and I think we're slowly getting there.

@zamith Sorry for the late review on this. I think this looks good overall, I just had a few suggestions/comments above.

Rebased and squashed commits together. Mind double checking the commit message and we merge, @zamith? Thanks so much! :clap:

@tute Does it not refer to the adapter organisation we're following on purpose? Is it clear enough from the code?
I'm still doing a commit with some small changes, but we can then squash it back with this one.

@tute @mcmire I've rebased with master and squashed everything, do you have any further comments?

@zamith Nope, this looks good to me.

Thank you, @zamith! Now back to our good old Pipelines PR! :)

Yay. :tada:
Let's do that then. Also, we still need to move the rest of the heroku related functionality from the app_builder to the adapter. Do you want to do this now, or is this something that can be done piece by piece?

we still need to move the rest of the heroku related functionality from the app_builder to the adapter. Do you want to do this now, or is this something that can be done piece by piece?

If you think it will make Heroku Pipelines easier, now sounds better. Otherwise, after that feature sounds best.

Thank you!! :)


[FR] - Being able to configure the mainnet network magic in cardano-cli

Internal/External
External
Area
Cardano CLI
Describe the feature you'd like
It looks like it is not possible to configure the mainnet network magic in cardano-cli.
There are comments on the code saying it is taken from the shelley genesis, but testing it, it does not happen.
I also tried to rebuild the cardano-cli changing the files under the configuration folder, and didn't take effect either.
Is there a way to do this? There can be people interested in deploying a mainnet based on cardano, like my case, and I have been performing some tests but I need to create the addresses using --mainnet to avoid introducing the networkmagic and then I need to use --testnet-magic xxxx for submitting transactions.
If this is already possible it would be great if you could give some hints on how to do it.
Thank you very much!
Describe alternatives you've considered

The default option of pulling from shelley genesis.
Re-building cardano-cli changing files under configuration folder.
Changing files under configuration folder on the bin directory after installing the cardano binaries.

Additional context / screenshots

Closing the issue since after reading the code for some time I understood the approach above didn't make sense. The mainnet network magic is hardcoded into the cardano ledger, so I guess it is needed to rebuild that and then rebuild the node and CLI using the changed dependencies.


How to add Custom Editable drop down in Grid

Hello,
For custom drop down I create typescript file
@Serenity.Decorators.registerEditor()
export class XYZType extends Serenity.Select2Editor<any, any>
{
...
this.addItem({ id: "", text: "" });
...
}
and in Row I used it
[DisplayName("Type"), NotNull, Width(150), XYZType]
public String Field1
{
get { return Fields.Field1[this]; }
set { Fields.Field1[this] = value; }
}
I want create editable drop down in grid and want to use XYZType editor
protected getColumns() {
var columns = super.getColumns();
var fld = OtherRow.Fields;
var sp = Q.first(columns, x => x.field === fld.Field1);
sp.referencedFields = [fld.Field1];
// facing problem here to add XYZType
sp.format = ctx => this.selectFormatter(ctx, fld.Field1,XYZType  );
}
How I can use custom drop down (Select2Editor) in Grid? or How to use hard coded drop down?
Or any other alternative.
Thanks

Hello,
Because am using hard coded drop down i don't have XYZrow.getLookup().
sp.format = ctx => this.selectFormatter(ctx, fld.Field1,XYZRow.getLookup() );
can anybody help me to add custom drop down in grid??

Hi!
In the comments to the Grid Editor, it is written that there are no questions on this topic ((
I would have written this part of the code to the one I needed for a particular case.

Thanks for your replay.
I already added selectFormatter.
but How can pass hard-coded value to , lookup: Q.Lookup<any>)
thanks

see this
https://github.com/dfaruque/Serenity.Extra#to-make-a-detail-grid-inline-editable

I removed last parameter from selectFormatter method, and manage code as per @Zahar661  suggested.


Autocomplete panel not close on clicking outside in react 18

Description
import { autocomplete } from '@algolia/autocomplete-js';
import React, { createElement, Fragment, useEffect, useRef } from 'react';
import { createRoot } from 'react-dom/client';
import<EMAIL_ADDRESS>
export function AutoComplete(props) {
  const containerRef = useRef(null);
  const panelRootRef = useRef(null);
  const rootRef = useRef(null);

  useEffect(() => {
    if (!containerRef.current) {
      return;
    }

    const search = autocomplete({
      container: containerRef.current,
      renderer: { createElement, Fragment,
        render : () => {},
        },
        render({ children }, root) {
          if (!panelRootRef.current || rootRef.current !== root) {
            rootRef.current = root;

            panelRootRef.current?.unmount();
            panelRootRef.current = createRoot(root);
          }

          panelRootRef.current.render(children);
        },
        ...props,
    });

    return () => search.destroy();
  }, [props]);

  return  <div ref={containerRef} />;
}
export default AutoComplete;

<Autocomplete
placeholder=“Search for courses…”
plugins={plugins}
// initialState={initialState}
onReset={onReset}
insights={true}
onSubmit={onSubmit}
openOnFocus
autofocus
/>

I am using these two components in react 18 and the autocomplete feature is working but when I am loosing focus by taping or clicking any where outside then the panel container is not hiding and still it’s visible.
Please help on this.
using
https://github.com/algolia/autocomplete/assets/141819397/c7ab4324-a320-4144-9caa-c8ea9e7cb4fb
Steps:
Go to search box and then click on it. The panel will open and try to click outside it won't close.

"@algolia/

https://github.com/algolia/autocomplete/assets/141819397/5d2f6935-6562-4c83-9853-a39cfadba5a3
autocomplete-js": "^1.11.0",
2.   react 18

Do you have a reproduction of that? I just checked the official example: https://codesandbox.io/s/github/algolia/autocomplete/tree/next/examples/react-18?file=/src/App.tsx, which has very similar code and the close on blur seems to work correctly.

IC-Agile-business-requirements-document-template-11238_WORD

var inputElements = document.getElementsByClassName('aa-Input');
    if(inputElements){
    for (var i = 0; i < inputElements.length; i++) {
      var inputElement = inputElements[i];

      inputElement.addEventListener('blur', function(event) {
          search.setIsOpen(false)
      });
  }

Issue was solved by implementing this for now.
So, I am closing this for now

This really seems like a bug given that it can be reproduced on Algolia's own docs pages. If you have multiple instances of autocomplete on a page then the first one doesn't disappear correctly when clicking outside.

Hi @AlistairNorman, multiple instances of Autocomplete in the same page are not supported, as only one of them can attach mouse/pointer events to the document to trigger the behavior responsible for closing the panel.
What's your use case for multiple autocomplete in the same document?


Move luyuhuang.DWords2 0.2.1 to LuyuHuang.DWords2 0.2.1

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/pull/156289#issuecomment-2146097791

[Policy] Reset Labels


Fix typo in constraints page

The y of "Foreign key" was not included in the code-formatted text.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a9b4dca6c5df7acaadaec87bba0b452440c52d64/
Edited pages:

v19.1/constraints.md
v19.2/constraints.md
v20.1/constraints.md

@pbardea this LGTM - merge at will!  Thanks!


Can't render multiline text in CocoaList

Hi, guys. I want to render a very very long text in CocoaList. But it only render one line and text is clipped with .... I find a solution, that add  .fixedSize(horizontal: false, vertical: true) on Text, it's working on SwiftUI native List. But not work on CocoaList.
Just like this.
On top of view is CocoaList, bottom of view is List.

There is my test code.
 VStack {
            CocoaList(items) { item in
                Text(String(repeating: "\(item.text) ", count: 3))
                    .fixedSize(horizontal: false, vertical: true)
            }

            List(items) {
                item in
                Text(String(repeating: "\(item.text) ", count: 3))
                    .fixedSize(horizontal: false, vertical: true)
            }
        }

I'll check out this bug! SwiftUI unfortunately exposes very little in terms of layout priorities or sizing preferences when writing [UI/NS]ViewRepresentable(s), so fixing this may be impossible to do in a generic fashion. But I will try nonetheless! :)

Closing this issue for now as I'm not able to reproduce it, could be a SwiftUI hosting controller bug. Could you upload a full sample project if it still persists? Feel free to reopen with the sample project.

Sorry. I didn't check the reply. This is the demo code.

import SwiftUI
import SwiftUIX

fileprivate struct Item: Identifiable {
    var id: UUID = UUID()
    var text: String {
        String(repeating: "A very very long text. ", count: 10)
    }
}

struct TestView: View {
    @State var index = 1
    @State fileprivate var items = [Item]()
    var body: some View {
        List(items) {
            item in
            Text(String(repeating: "\(item.text) ", count: 3))
                .fixedSize(horizontal: false, vertical: true)
        }

        .onAppear {
            for _ in 0 ..< 2 {
                items.append(Item())
            }
        }
    }
}

struct TestView2: View {
    @State var index = 1
    @State fileprivate var items = [Item]()
    var body: some View {
        CocoaList(items) { item in
            Text(String(repeating: "\(item.text) ", count: 3))
                .fixedSize(horizontal: false, vertical: true)
        }

        .onAppear {
            for _ in 0 ..< 2 {
                items.append(Item())
            }
        }
    }
}

struct TestView_Previews: PreviewProvider {
    static var previews: some View {
        ZStack {
            TestView()
        }.ignoresSafeArea(.all, edges: .bottom)
        ZStack {

            TestView2()
        }.ignoresSafeArea(.all, edges: .bottom)
    }
}

Sorry. I didn't check the reply and forgot about it. This is the demo code.

import SwiftUI
import SwiftUIX

fileprivate struct Item: Identifiable {
    var id: UUID = UUID()
    var text: String {
        String(repeating: "A very very long text. ", count: 10)
    }
}

struct TestView: View {
    @State var index = 1
    @State fileprivate var items = [Item]()
    var body: some View {
        List(items) {
            item in
            Text(String(repeating: "\(item.text) ", count: 3))
                .fixedSize(horizontal: false, vertical: true)
        }

        .onAppear {
            for _ in 0 ..< 2 {
                items.append(Item())
            }
        }
    }
}

struct TestView2: View {
    @State var index = 1
    @State fileprivate var items = [Item]()
    var body: some View {
        CocoaList(items) { item in
            Text(String(repeating: "\(item.text) ", count: 3))
                .fixedSize(horizontal: false, vertical: true)
        }

        .onAppear {
            for _ in 0 ..< 2 {
                items.append(Item())
            }
        }
    }
}

struct TestView_Previews: PreviewProvider {
    static var previews: some View {
        ZStack {
            TestView()
        }.ignoresSafeArea(.all, edges: .bottom)
        ZStack {

            TestView2()
        }.ignoresSafeArea(.all, edges: .bottom)
    }
}

And, my xCode version is 12.5, complied target is iOS14.0, complied on macOS 11.3.1.

@vmanot I try to change target to iOS 14.5, same as before

@Innei The fixedSize approach is wrong in my opinion.
@vmanot try this code, it's shorter and better to understand the issue:
import SwiftUI
import SwiftUIX

struct Test: Identifiable {
    let id = UUID()
}
struct ContentView: View {
    var body: some View {
        CocoaList([Test(), Test()]) { number in
            Text("Hello, world loooooooooooooooooooooooooooooooooooooong!")
                .padding()
        }
    }
}

If I had to guess the problem stems from there: https://github.com/SwiftUIX/SwiftUIX/blob/1ebbad6c9e6aa326234f4544135db9c0372c53e0/Sources/Intermodular/Helpers/UIKit/UIHostingTableViewController.swift#L183
I have no idea how to fix this.

@Innei a possible workaround would be to get the available space with a geometry reader and tell the Text his maximum frame size:
struct Test: Identifiable {
    let id = UUID()
}
struct ContentView: View {
    var body: some View {
        GeometryReader { size in
            CocoaList([Test(), Test()]) { number in
                Text("Hello, world loooooooooooooooooooooooooooooooooooooong!")
                    .frame(maxWidth: size.size.width)
            }
        }
    }
}

I hope that @vmanot can find a proper fix, but in the meantime this issue should be re-opened

@MarcoCount thanks, I'll take a look into this.

get the available space with a geometry reader and tell the Text his maximum frame size
Multiple layout passes are hard to balance with the performance tradeoffs, and unfortunately SwiftUI doesn't give me access to a whole host of methods that are used internally for calculating sizes in a more performant manner. Ideally, I wouldn't even be using UIHostingController (there's no UIHostingView for SwiftUI :/). So while I will try and find time to look at this, it's not super high on the priority list at the moment.

@MarcoCount thanks, I'll take a look into this.

get the available space with a geometry reader and tell the Text his maximum frame size

Multiple layout passes are hard to balance with the performance costs, and unfortunately SwiftUI doesn't give me access to a whole host of methods that are used internally for calculating sizes in a more performant manner. Ideally, I wouldn't even be using UIHostingController (there's no UIHostingView for SwiftUI :/). So while I will try and find time to look at this, it's not super high on the priority list at the moment.

Yes, I perfectly understand.
My comment about the GeometryReader is a good workaround while you find time for the fix.
I honestly can't help more than that there.

Closing as I'm officially marking this out of scope for CocoaList. I've exhausted a wide range of solutions trying to balance the tradeoff between performance and layout magic - sticking with performance here.


[INLONG-2296] Added lag consumption log

Fixes #2296

Codecov Report

Merging #2298 (a9142ef) into master (bc58c9e) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #2298   +/-   ##
=========================================
  Coverage     12.54%   12.54%
- Complexity     1217     1219    +2
=========================================
  Files           420      420
  Lines         36229    36235    +6
  Branches       5670     5670
=========================================
+ Hits           4545     4547    +2
- Misses        30875    30881    +6
+ Partials        809      807    -2

Impacted Files
Coverage Δ

...emq/server/broker/offset/DefaultOffsetManager.java
0.00% <0.00%> (ø)

.../inlong/tubemq/server/common/TServerConstants.java
0.00% <ø> (ø)

.../producer/qltystats/DefaultBrokerRcvQltyStats.java
46.09% <0.00%> (+0.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc58c9e...a9142ef. Read the comment docs.