ci: increase test parallelism when lots of CPU available.

Our new CI machines will opportunistically group jobs together on fairly beefy machines, in which case we may not be parallelizing as much as we could in terms of test cases being run.
Trying this out to see if it speeds up test runs.

Based on the run so far, the tests are actually collectively slower. I was hoping that we were io-bound enough that just using all the CPUs would still be an improvement, but doesn't seem like that worked out in practice based on this.
I'm going to try one more thing: we can just run only testrace rather than both test and testrace. I'm wondering if on the new runners the fact that we are duplicating the test runs actually adds more overhead than just only running the (slightly slower) testrace.

Only running testrace did improve things relative to the previous run.
Last thing I'll try: rather than setting -parallel to the min of 16 and cpu count, I'll see what happens if I set it to the min of 16 and half the cpu count.

Last thing I'll try: rather than setting -parallel to the max of 16 and cpu count, I'll see what happens if I set it to the max of 16 and half the cpu count.

It wasn't clear this made any difference relative to the start, so I just removed the commits that tweak parallel for now.


can't modify frozen String

on lib/axlsx.rb
  # returns the provided string with all invalid control charaters
  # removed.
  # @param [String] str The string to process
  # @return [String]
  def self.sanitize(str)
    str.delete!(CONTROL_CHARS)
    str
  end

when i use rubocop and make FrozenStringLiteral to be true, rendering the axlsx with frozen_string_literal causing exception triggered
can't we change the str.delete! to str.delete ?

I've got a PR to fix this or you can look at our fork:
https://github.com/randym/axlsx/pull/565
https://github.com/ezcater/axlsx

merged


could not find implicit value for parameter um

Hi,
I am using akka-http-circe and getting the following error:
Error:(53, 83) could not find implicit value for parameter um: akka.http.scaladsl.unmarshalling.Unmarshaller[akka.http.scaladsl.model.ResponseEntity,com.msilb.scalanda.restapi.Response.AccountDetailsResponse]
    getWithQueryParams(s"accounts/$accountId").flatMap(r => Unmarshal(r.entity).to[AccountDetailsResponse])

Here is the code excerpt where it fails:
import de.heikoseeberger.akkahttpcirce.CirceSupport._

def getAccountDetails(accountId: AccountId): Future[AccountDetailsResponse] = {
  import io.circe.generic.auto._
  getWithQueryParams(s"accounts/$accountId").flatMap(r => Unmarshal(r.entity).to[AccountDetailsResponse])
}

AccountDetailsResponse is a case class which contains nested case classes and case objects. I am thinking circe fails to find implicit decoders for the given domain model but unfortunately the error message does not tell me which value it fails to decode, otherwise I could provide it manually. Is there any way to add this information to the error message?

Sorry, but this library can't influence the error messages of the Scala compiler.


librdp.so module broken

The librdp.so module (RDP proxy) is not working with the current devel branch. That's the only module that reports its version as 2; other modules report version 3.
There are some differences in struct mod for librdp.so and the genetic struct xrdp_mod. The last common field is si in struct xrdp_mod and sck in struct mod, and it's not the same thing.
It is worth the trouble to fix librdp.so? What are the use cases? Isn't it obsoleted by libxrdpneutrinordp.so?

This module is obsolete. we should remove it.
for RDP proxy use neutrinordp module.


bump up private api sdk version

bump up private api sdk version
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[x] Infrastructure change

Pull request checklist

[ ] I have added unit tests for new code that I have added
[ ] I have added/updated functional tests where appropriate
[ ] The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: Security warnings found!


Upstream a few more constants from rustix.

Add a definition of CIBAUD for powerpc and powerpc64 on glibc.
And a definition for RLIM64_INFINITY on linux_like platforms.

@bors r+
Thanks!

:pushpin: Commit b5aaa6f936865800d39747b9f8871ea3cf2e0e7d has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit b5aaa6f936865800d39747b9f8871ea3cf2e0e7d with merge df60243915304e1c09139ae670db0f9830186150...

@bors r+

:pushpin: Commit deec65c325b47d061a6d1283cc3b6b784cce585b has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit deec65c325b47d061a6d1283cc3b6b784cce585b with merge ff90c4767408674117f1435aeab69bd5ed635366...

Some jobs failed, could you check?
@rustbot author

Fixed the declaration of rlim64_t on i686-linux-android, and squashed into a single commit.

r? @JohnTitor

@rustbot review

Thanks and sorry for the delay! @bors r+

:pushpin: Commit 5597f33a53cd3a544f9da9979a28ece1451df1f9 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 5597f33a53cd3a544f9da9979a28ece1451df1f9 with merge 1bffdc6b1c62e5a111dd6a5b9204bd0ba9bab23e...

:broken_heart: Test failed - checks-cirrus-freebsd-14

This PR doesn't touch any files used by FreeBSD, but CI is failing on FreeBSD like this:
RUNNING ALL TESTS
bad tcp_info size: rust: 240 (0xf0) != c 256 (0x100)
bad tcp_info align: rust: 4 (0x4) != c 8 (0x8)
bad field offset __tcpi_pad of tcp_info: rust: 164 (0xa4) != c 176 (0xb0)
bad field type __tcpi_pad of tcp_info: rust: 0x2b1529dd778c != c 0x2b1529dd7798
size of struct tcp_info is 256 in C and 240 in Rust
thread 'main' panicked at 'some tests failed', /tmp/cirrus-ci-build/target/x86_64-unknown-freebsd/debug/build/libc-test-6b8396ef363a1463/out/main.rs:12:21

The issue is now fixed on master, @bors retry

:hourglass: Testing commit 5597f33a53cd3a544f9da9979a28ece1451df1f9 with merge e4996760e16b62423440342ec52d22d53f9bc21c...

:broken_heart: Test failed - checks-actions

Seems there's a typo in cfg.

Oops, fixed.

@bors r+

:pushpin: Commit 0ba1fc4d6658317ca1ad79e5b62677ba4c772f0c has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 0ba1fc4d6658317ca1ad79e5b62677ba4c772f0c with merge 8077351f4b28a1b9fc46e2ac11a530d782264273...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 8077351f4b28a1b9fc46e2ac11a530d782264273 to master...


Timeline - Length of tracked activity/project displayed

Case 417339
Is there a limit of what can be displayed by timeline. This user would like to see the project totals for work in Adobe Premiere Pro but can only see directory paths, as seen in attached screenshot in case.
Thanks,

The display issue is connected to the way the web app handles showing timeline data in their UI. This is not directly connected to Toggl Desktop. We send data as we get it. We have a character limit, but it is a big one. Something like 200 characters or so. Anyhow contact web masters for an answer.


[Coverity CID :188747]Security best practices violations in /subsys/shell/shell.c

Static code scan issues seen in File: /subsys/shell/shell.c
Category: Security best practices violations
Function: shell_execute_cmd
Component: Other
CID: 188747
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

ignored als false positive in coverity


Update to com.github.scribejava?

Hi,
Could you consider to bump org.scribe to com.github.scribejava?

Seems like we just need to bump the version and update the imports?

It's worth a try. :)


random order at every page refresh

I create a code that return image from db with a specific order
But at every refresh the slider change randomically the order of the image
Can i force the fixed order in the slider?

like in this example
https://bqworks.net/slider-pro/#example3
the order is changing at every refresh, i don't want this

That's because of the shuffle option, which is disabled by default, but probably enabled in your implementation. You just need to remove it or set it to false.
Best,
David


Update device-management.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/3414
Fixed link.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.


Move deprecated components to separate folder

Let's create a deprecated folder and move some components there. As we talked, they should put a message to the console, proposing good alternative instead of it.
List of deprecated components:

Container (alternative will be Card, release in 0.2)
FieldFeedback (there probably isn't alternative)
Input (not sure if there will be alternative for this, it's just a Label in there)
InputText (alternative will be InputField probably, release in 0.2)
InputTextarea ((alternative will be InputTextarea probably, release in 0.2)
Radio (alternative will be RadioButton, release in 0.2)*
Checkbox (alternative will be Checkbox, release in 0.2)*
Select (alternative will be InputSelect, release in 0.2)*
SystemMessage (alternative: Alert)
Typography (alternatives: Text, Heading)

these release 0.2 names can be changed once we start working on them

Done in #201


Add basic information and formula list for various shapes for younger audience

i would like to add a column dedicated to providing basic info about shapes and some related formula which could be helpful for younger audience.

Can you please elaborate on what all information and formulae you are planning to add? That would be helpful in going ahead with the issue :)

The idea is to include an image with an image of the shape along with basic information about it like maybe for a triangle- I am a three shape, things that are triangle shaped and so. The basic aim is to focus on the younger age group and just act as a medium of making them familiar with the shapes.

Actually, most of the formulas for shapes is already there under Shapes Calculator


403 - Limit to use gpt-3.5-turbo, gpt-4 and embeddings.

Suddenly, the free key cannot be used properly.What happened when the following message appeared？
403 - Limit to use gpt-3.5-turbo, gpt-4 and embeddings. If you have additional requirements, please visit https://peiqishop.me to purchase a premium key.

你解决了吗 我也遇到了这个问题

same here


SQL Import: Apply a lower file size limit for launched envs

Description
Apply a different file size limit for SQL files for launched sites (to maintain site stability).
When a file is deemed too large for safely importing into a launched site (currently 350 MiB), show an error:

Unlaunched sites will continue to be subject to the previous file limit and will show the same error (minus the bit about launched sites).
Steps to Test

Check out PR.
Run npm run build
Run ./dist/bin/vip-import-sql.js with a known good import file smaller than the new limit
Verify it is not incorrectly gated by this change
Copy the known good import file to a temporary location
Expand the file size to be greater than the limit (truncate -s 400M /tmp/your/test/file.sql)
Run ./dist/bin/vip-import-sql.js with the expanded file against a launched test site
Verify it is blocked by this change and an appropriate error shown
Run ./dist/bin/vip-import-sql.js with the expanded file against an unlaunched test site
Verify it is not blocked by this change
Expand the file size to be greater than the unlaunched limit (truncate -s 11000M /tmp/your/test/file.sql)
Run ./dist/bin/vip-import-sql.js with the expanded file against an unlaunched test site
Verify it continues to be blocked with this change in place

@markowsiak re-requested a review since this is materially different than before.


Add Support for Lenovo Y530-15ICH

Description of changes
Adding hardware support for the Lenovo Legion Y530-15ICH. My specific configuration has the Core i7-8750H with a 4GB 1050Ti.
Things done

[X] Tested the changes in your own NixOS Configuration
[ ] Tested the changes end-to-end by using your fork of nixos-hardware and
importing it via <nixos-hardware> or Flake input

I have tested this by importing the nixos-hardware repo as a submodule of my configuration repo and updating files as required. I will be leaving this as draft until I am confident everything works as intended, though I see no current issues.

As far as my basic testing has gone, I have seen no issues with the above configuration for the hardware.

bors merge

bors cancel

bors merge


should compiler update vl after typecast?

For an example:
#include <riscv_vector.h>

unsigned short x[8] = {1, 2, 3, 4, 5, 6, 7, 8};
unsigned char y[16];

void foo() {
  vsetvl_e16m1(8);
  vuint16m1_t vx = vle16_v_u16m1(x);
  vuint8m1_t vy = vreinterpret_v_u16m1_u8m1(vx);
  // vsetvl_e8m1(16); // should compiler update vl correctly?
  vse8_v_u8m1(y, vy);
}

When cast from vuint16m1_t to vuint8m1_t, the element length also changes from 8 to 16. So should compiler update vl, or do it manually?

When cast from vuint16m1_t to vuint8m1_t, the element length also changes from 8 to 16. So should compiler update vl, or do it manually?

No, compiler won't automatically change vl, the compiler only insert vsetvli x0, x0, e8, m1 to make sure vtype is correct (and without changing vl) before the operation.
But it's an interesting question if the vl is unchanged, it should work as expect at vector v0.9, but it will got an illegal-instruction exception, so I will suggest you should add  vsetvl_e8m1(16);
https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#61-vsetvlivsetvl-instructions
...
Use of the instruction with a new SEW/LMUL ratio that would result in a
change of VLMAX is reserved. Implementations may set vill in this case.
...

See more discussion for this issue:
https://github.com/riscv/rvv-intrinsic-doc/pull/52

So I think this can be taken as a narrowing type cast, thus the vector value will be truncated. The following test can show the result.
#include <stdio.h>
#include <riscv_vector.h>

unsigned short x[8] = {1, 2, 3, 4, 5, 6, 7, 8};
unsigned char y[16];

int main() {
  vsetvl_e16m1(8);
  vuint16m1_t vx = vle16_v_u16m1(x);
  vuint8m1_t vy = (vuint8m1_t)vx; // The vector value will be truncated.
  vsetvl_e8m1(16); // Even though specify the vl to 16, ...
  vse8_v_u8m1(y, vy); // ... the last 8 elements is undefined.

  for (int i = 0; i < 16; ++i) {
    printf("y[%d]=%d; ", i, y[i]);
  }
  printf("\n");
}

I was under the impression that we hadn't yet defined the cast operator (type-name) expression for the new types defined by the RVV C dialect: https://github.com/riscv/rvv-intrinsic-doc/issues/13#issuecomment-617623923

I was under the impression that we hadn't yet defined the cast operator (type) expression for the new types defined by the RVV C dialect: #13 (comment)

I guess just because we didn't fully check and forbid that on our GCC implementation, so there is some default one? but I think we should forbid that before we have consensus/conclusion.

So I think this can be taken as a narrowing type cast, thus the vector value will be truncated. The following test can show the result.

Hmmm, I think we don't have well-define that behavior for such C casting operator, so I would suggest you using explicit intrinsic to do like vreinterpreter or vncvt.x.x.w.

For an example:
#include <riscv_vector.h>

unsigned short x[8] = {1, 2, 3, 4, 5, 6, 7, 8};
unsigned char y[16];

void foo() {
  vsetvl_e16m1(8);
  vuint16m1_t vx = vle16_v_u16m1(x);
  vuint8m1_t vy = vreinterpret_v_u16m1_u8m1(vx);
  // vsetvl_e8m1(16); // should compiler update vl correctly?
  vse8_v_u8m1(y, vy);
}

When cast from vuint16m1_t to vuint8m1_t, the element length also changes from 8 to 16. So should compiler update vl, or do it manually?

Users need to do it manually, see https://github.com/riscv/rvv-intrinsic-doc/blob/master/rvv-intrinsic-api.md#reinterpret-cast-conversion-functions
Reinterpret the contents of a data as a different type, without changing any bits and generating any RVV instructions.
You could also found reinterpret api does not have vl argument in the explicitly vl document.
https://github.com/riscv/rvv-intrinsic-doc/blob/master/rvv_intrinsic_funcs_vl/12_miscellaneous_vector_functions.md


docs: Add a Japanese translation style guide.

Added a Japanese translation style guide.
Current contents are based on discussions at #translation in the Zulip development community server.
Fixes: [no issue]

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

@gnprice Could you review this too?

@gnprice I applied your suggestion. Thanks!

Merged, thanks @oribe1115 and reviewers!


Issue: Talent ranks doesn't change in charsheet overview

If I change the rank of a talent, it doesn't change in the overview on the charsheet.

This is fixed in the next update.


We would like to change our token name from "name": "UBIK Token" to "name": "UBIK"

I'm submitting a ...
[ ] bug report
[x] feature request
[ ] question about the decisions made in the repository
[ ] question about how to use this project

Summary
We would like to change our token name from: UBIK Token to: UBIK
please see the PR from below
https://github.com/solana-labs/token-list/pull/9397

Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

merged


support using git-sync with PVC (allowing there to only be one git-sync container)

Currently, we don't let users enable dags.gitSync  and dags.persistence at the same time.
If we do this (obviously requiring dags.persistence.accessMode = ReadWriteMany), we can massively reduce the number of git-sync containers required.
This is because we won't have to put a git-sync container in every Pod, but rather have all pods mount the PVC, while having a central single git-sync deployment that keeps the PVC up to date.

in airflow1 version, gitSync with dags pvc works. we hope it keeps the same in airflow2. which would not leading the task container waiting for git clone done (this masters a lot if the git repo is too big or poor network connection)

@justbeay two comments:

version 8.X.X of the chart can be used with both airflow 1 and airflow 2 (see the Airflow Version Support table)
while the 7.X.X version of the chart may have let you enable a PVC with git-sync enabled, it would have resulted in all the git-sync containers fighting over the sync

Bumping for bot.

Reopening

I think this feature is really important for KubernetesExecutor, as right now if cloning the git repo takes a long time, then EVERY task will take at least that long, this is because the git-clone init-container must run before the task can, as it needs the DAG definitions.

I have created a PR trying to address these, I'd appreciate feedback on it.


default browser coutermeasure doesn't crash the browser..

I'm not really sure if this should be a feature request or issue
When it's supposed to "crash the process" on browser, all it does it run document.documentElement.innerHTML = ''; which doesn't crash anything
maybe it could run an infinite loop to actually crash? like for(;;){while(1){}}

You are right. The new behavior will just be an infinite loop as the default countermeasure. I will change this for next update.

An infinite loop can be easily stopped by just pressing the "Pause script execution" button in devtools.
There are better ways to crash a tab like spamming iframes. (this absolutely kills devtools if it runs for a few seconds)
for(;;) {
    let a = document.createElement("iframe");
    a.src = "/"
    document.body.append(a)
}

Maybe the countermeasure should be configurable?
Some may want to just pause script execution, and others crash the page..

@fuzzbuck The countermeasures is configurable by setting it a string, it can be a custom callback. This issue is related to the default behavior (no value provided) is incorrect. I like @Le0Developer 's code snippet and it will be the default behavior


update rc

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Happens to the best of us 😎


BREAKING CHANGE: mark @material-ui/core dependency as externals

DON'T MERGE!

Why not ?

@talyak needs to run some tests before merging this.

opened new PR


⚠ ClamAV has degraded performance

In fe2e476, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 448 ms

Resolved: ClamAV performance has improved in b12670f.


Format code using 'cargo fmt'

I get that some things get worse, but I like autoformatting too much.
Since we have a large PR incoming with changes ( #23 ). I'd prefer to hold up on applying rustfmt to after that.

@oli-obk ok, once that PR is merged please me ping here & I can rebase this from master & update the PR

Thanks! will do

@Atul9 the other PR has been merged

@oli-obk done, I have branched-off from master & updated this PR

Ok, CI passes now. @Atul9 lmk whether you prefer to merge it as is or to address the formatting comments before merging (in which case we'll do it after the merge).

@oli-obk I prefer to merge it as is.


[stable/openebs] update charts to latest 0.8.1 release

Updated README
Updated chart version
Updated values.yaml
Added liveness probe in all control-plane component templates
Change NDM update strategy to 'RollingUpdate'

Signed-off-by: prateekpandey14<EMAIL_ADDRESS>
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/hold

/unhold

/hold cancel

/ok-to-test

/lgtm


Short 'or' in expression

Is there a way to write something like that <h1>{{title || body}}</h1> with context
{    title: "",    body: "This is my first post!" } and it would output body value since in javascript !!title === false
I know about {{#if title}}{{title}}{{else}}{{body}}{{/if}} but is there a shorter way or should be a shorter way some time added? Going further would be even more awesome like {{value1 || value2 || value3}} etc.

Not in the language itself, but you can easily achieve this with a helper:
{{coalesce title body}}

Handlebars.registerHelper('coalesce', function(a, b) { return a || b; });

So this takes only to arguments? What about if I want indefinite arguments. like so {{value1 || value2 || value3}}

Untested:
Handlebars.registerHelper('coalesce', function() {
  for (var i = 0; i < arguments.length - 1; i++) { // - 1 because last should be handlebars options var
    if (arguments[i]) {
      return arguments[i];
    }
  }
  return null;
});

You could also use Array.find()
Handlebars.registerHelper('coalesce', (...args) => args.find(i => !!i));
{{coalesce a b c d e f g}}


Added New game Tic Tac Toe

PR Description 📜
Added New Game
Fixes #4524

Mark the task you have completed ✅

[x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x ] I have performed a self-review of my own code or work.
[x ] I have commented my code, particularly in hard-to-understand areas.
[ x] My changes generates no new warnings.
[x ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x ] I have added screenshot for website preview in assets/images
[x ] I have added entries for my game in main README.md
[x ] I have added README.md in my folder
[x ] I have added working video of the game in README.md (optional)
[x ] I have specified the respective issue number for which I have requested the new game.

@ishita-43  please review

Thank you @Saipradyumnagoud ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Thank you  @Saipradyumnagoud , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Changing templates from Node to DeviceType

Related to #221 and #217.

Codecov Report

Merging #225 into master will decrease coverage by 0.04%.
The diff coverage is 98.14%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   97.53%   97.48%   -0.05%
==========================================
  Files          40       40
  Lines        1948     1950       +2
==========================================
+ Hits         1900     1901       +1
- Misses         48       49       +1

Impacted Files
Coverage Δ

packages/Utils/src/DTK_KokkosHelpers.hpp
100% <ø> (ø)
:arrow_up:

...h/src/details/DTK_DetailsTreeConstruction_decl.hpp
100% <ø> (ø)
:arrow_up:

...es/Search/src/details/DTK_DetailsTreeTraversal.hpp
100% <100%> (ø)
:arrow_up:

packages/Search/src/DTK_LinearBVH_def.hpp
100% <100%> (ø)
:arrow_up:

packages/Search/test/tstLinearBVH.cpp
100% <100%> (ø)
:arrow_up:

packages/Search/src/DTK_LinearBVH_decl.hpp
100% <100%> (ø)
:arrow_up:

...ch/src/details/DTK_DetailsTreeConstruction_def.hpp
98.19% <100%> (+0.01%)
:arrow_up:

...ackages/Search/test/tstDetailsTreeConstruction.cpp
99.37% <88.88%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb338a...da49d5e. Read the comment docs.

Update PR to include files in Interface.


Service worker broken when ng build with custom base href

🐞 Bug report
Command (mark with an x)

- [ ] new
- [ *] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?
Don't know
Description
Service worker isn't registered (ngsw-worker.js never called) when building with a custom --base-href.
Related stackoverflow post : https://stackoverflow.com/questions/53329924/angular-7-service-worker-not-registered
Related closed issue : https://github.com/angular/angular-cli/issues/13351
🔬 Minimal Reproduction
On localhost, I have 2 apps :

1 with default base-href : service Worker working without problem ng build --project=projectA
1 with custom base-href (given from the cli ng build --project=projectB --base-href=/projectB/

Manifest reflects this with start_url and scope to "/projectB"
🔥 Exception or Error

🌍 Your Environment
Angular CLI: 8.1.0
Node: 10.15.3
OS: darwin x64
Angular: 8.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.801.0
@angular-devkit/build-angular      0.801.0
@angular-devkit/build-ng-packagr   0.801.0
@angular-devkit/build-optimizer    0.801.0
@angular-devkit/build-webpack      0.801.0
@angular-devkit/core               8.1.0
@angular-devkit/schematics         8.1.0
@angular/cdk                       8.0.2
@angular/fire                      5.2.1
@angular/flex-layout               8.0.0-beta.26
@angular/http                      7.2.15
@angular/material                  8.0.2
@angular/pwa                       0.801.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   8.1.0
@schematics/angular                8.1.0
@schematics/update                 0.801.0
ng-packagr                         5.3.0
rxjs                               6.5.2
typescript                         3.4.5
webpack                            4.35.2

Tried to :

register it relatively with "./ngsw-worker.js" without success
manual register in browser console works (after app load)
deps updated to latests
Note that the workaround provided in the SO post works totally (= angular.json, ngsw-config, manifest file is well configured)

@gkalpak, I think this might be some related more to the service-worker package.

Hard to tell what this is related with, without a minimal reproduction. (For example, the SO question mentions http://<IP_ADDRESS> which will of course not work, because SW requires HTTPS or localhost (not <IP_ADDRESS>).)
I would be happy to investigate this, if someone can provide a minimal reproduction (i.e. a ZIP file I can download or a repo I can check out and run a command to see the problem).

@jscti, it would be great if you can provide a minimal repo to speed up the process in looking into the issue.
Thanks

Same thing on Angular CLI 7.3.6, any update?

This might help:
https://github.com/angular/angular-cli/issues/8515#issuecomment-486017106
OR
https://github.com/angular/angular-cli/issues/13351#issuecomment-516342267


Feature or API to update EML data for multiple datasets in cloud IPTs

Help desk occasionally gets requests from publishers to be able to update EML files for multiple datasets at once - either programmatically or by development of a feature. This issue may be related https://github.com/gbif/ipt/issues/1973 but does not concern cloud IPTs.
Below are two concrete examples of the need for the feature/IPT API:

we recently were asked to add a data manager as a contact to ~ 30 datasets that fell under the purview of a US federal program. The solution was to programmatically download and update the EML locally. However, the final step was a manual upload and then a manual publication of each dataset through the IPT.
We recently updated a link to a project website for about 20 datasets. The solution was the same as before: download and update locally with a script, but then upload and publish manually.

I anticipate more of this happening as data accrues, so if we could gain programmatic access to the IPT it would make these updates a little less time-consuming.

It may be worth considering either:

Implement a feature in the IPT to bulk edit metadata for selected datasets
some sort of managing access through an IPT API to programmatically change metadata for selected datasets

@CecSve Thank you Cecilie
There is something to think about, I have no idea how to implement it yet

Having to update the metadata in multiple datasets at once is a pretty common use case for me as well. I typically do this by opening the datasets in different tabs, editing them and publishing them. I guess it would be nice to see this supported in a bulk feature, but I'm not sure how it would look like. I think I mostly want to be able to update metadata without having to then also republish the datasets (cf. how it works in Zenodo), as it avoids having to republish for minor corrections/typos etc.

I can see this will be a productivity booster for organisations that manage it's own dataset metadata and use IPT as the gateway facility to publish data to the GBIF Network.

I like where @peterdesmet is headed in regard to NOT have to republish every time a minor detail is updated in the metadata.
Speaking for myself,  I have had to update metadata in multiple datasets under the same publisher several times a year. Also, at least once a year (when it comes to Arctos) I have to update metadata across multiple publishers. Usually these changes are uniform across datasets (e.g., the removal of one contact person and replacement with a new person). I do this just as Peter has described above, by opening separate tabs, updating individually and then republishing. I don't know how this process could be streamlined, but it would be amazing to be able to make changes across more than one EML at a time, perhaps @ckotwn is onto something with the POST call, but my experience is very limited with such things. I would be happy to learn a new skill, however....

I've got an interesting parallel potential use case here, OTN maintains a constantly-growing source database of machine-derived animal presence data, that will be the origin for hundreds of resource-level entries in an IPT. To publish everything equally well, i've created templates for eml.xml and meta.xml that each project's data fills in, and built extraction scripts that produce Occurrence Core and Event Core w/ Occurrence extension filesets for each project, depending on whether they are deploying tags, or tags and monitoring equipment. Zipping these up creates a valid (Thank you, GBIF Validator!) DwC-A file that I can use to create new resources on an IPT, with every piece of metadata and mapping falling nicely into place. What a time-saver!
But next time I go to update all of these DwC-As, I can't use a fully-packaged DwC-A file to update an existing resource with new eml.xml and potentially even small changes to meta.xml.
What I'd like to do, is be able to drop-in my updated DwC-As and have everything re-map and repopulate just as it did the first time I created the resource, but without having to delete anything.


Update Content Security Policy for ReadySetCyber Dashboard

🐛 Summary
Within the ReadySetCyber Dashboard footer, an Iframe has been added to display the National Terrorism Advisory System (NTAS) widget. This widget is displayed within a local environment, but once in staging it is prevented from loading by the content security policy.
Current view in staging:

Intended view:

Resolved by PR #244

Resolved by PR #244


Update development.md - bug fix

bug fix

:warning: Validation status: warnings

File
Status
Preview URL
Details

mixed-reality-docs/development.md
:warning:Warning
View
Details

mixed-reality-docs/development.md

Line 0: [Warning] Invalid file link:(~/HoloLensIcon.jpg).
Line 0: [Warning] Invalid file link:(~/OpenSourceIcon.jpg).
Line 0: [Warning] Invalid file link:(~/DirectXIcon_b.jpg).
Line 0: [Warning] Invalid file link:(~/GettingStarted.jpg).
Line 0: [Warning] Invalid file link:(~/ImmersiveHeadsets.jpg).
Line 0: [Warning] Invalid file link:(~/UnityIcon.jpg).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Support sending/receiving FDs over UNIX sockets

Add UnixStream::read_recv_fd and write_send_fd, which can read and write a RawFd that is passed over the socket. The file descriptor is duplicated as if with dup(), except that it can be passed across processes.
Also add try_read_recv_fd, try_read_buf_recv_fd, try_write_send_fd, and try_write_buf_send_fd, analogous to the functions on the TryRead and TryWrite traits.
Since this functionality is unique to UNIX domain sockets, the new functions are directly on UnixStream and not part of a trait.

Depends on a nix with carllerche/nix-rust#197 (cmsg, merged earlier today) and carllerche/nix-rust#198 (fix sockaddr_un, just proposed for merge). Also I have a tiny refactoring of to_non_block which captures a common pattern in a more readable way IMO, but if you don't like it I can drop it.

This was merged! f4b3c3570c54472ff79127d1290f4762c1849f99


⚠ 366.ru has degraded performance

In 923d57d, 366.ru (https://366.ru) experienced degraded performance:

HTTP code: 200
Response time: 1238 ms

Resolved: 366.ru performance has improved in 74a7935 after 5 minutes.


Reimplement CustomizeConnection::on_release()

#94 implemented the equivalent of r2d2's on_release method, but reverted it before release.
This is exactly what we'd need for lettre. We have a PR https://github.com/lettre/lettre/pull/550 which implements connection pooling for the async version of our API. However, before dropping an SMTP connection, the client must send a QUIT command (see https://tools.ietf.org/html/rfc5321#section-<IP_ADDRESS>). My thinking is that on_release would be perfect for this use-case.
I'll later send a PR to reimplement on_release.

Out of curiosity, what's your reason for closing this?

We ended up having our own pool implementation https://github.com/lettre/lettre/pull/637, which would also allow us to support both tokio and async-std

Fair enough, thanks for the explanation!


Accuracy or similar metrics used for autonet.score

I found that autonet.score is different from the loss for training.
As I am using custom loss function, it would be more convenient and appropriate to have
custom score function. Anyway thank you for the package.

Hey,
there are three different scorings:
i) Training loss (e.g. cross_entropy) that is used for the optimizer when training an NN
ii) Metrics for scoring (e.g. accuracy_score), these are logged in results.json under their name
iii) The loss considered by BOHB. This is the main metric (could be accuracy_score) transformed to a metric that is minimizable, that is 1-accuracy_score. This loss is logged as loss.
You can change ii) via the optimize_metric argument in the autonet config.

I wrote a code with new optimization metric
def qloss(y_true, y_pred, qs):
        e = y_true - y_pred
        return np.maximum(qs * e, (qs-1)*e).mean()
metric_ql = functools.partial(qloss, qs = np.array([[0.1, 0.5, 0.9]]))

def qinputloss(y_true, y_pred, ws):
    w_q = ws[0,0]
    w_input = ws[0:1, 1:]
    q = y_true[:, 0:1]

    e_q = np.abs(y_true[:,0]-y_pred[:,0])
    e = y_true[:, 1:] - y_pred[:, 1:]

    #print(w_input)
    #print(q*e, (q-1)*e)

    ret = w_input * np.maximum(q*e, (q-1)*e)
    #print(ret)

    return np.mean(ret)+ np.mean(w_q*e_q)
metric_qil = functools.partial(qinputloss, ws=np.array([[0,1]]))

metric_selector = autonet.pipeline[MetricSelector.get_name()]
metric_selector.add_metric('metric_ql', metric_ql, loss_transform=False, requires_target_class_labels=False)
metric_selector.add_metric('metric_qil', metric_qil, loss_transform=False, requires_target_class_labels=False)

results_fit = autonet.fit(X_train=train_x_wq,
                          Y_train=train_y_wq,

                          loss_modules=["qinput_loss"],
                          optimize_metric = 'metric_qil')

I have not test it fully, but it looks working

Looking at your code, it looks like you are adding your metrics to the metric selector (which is used to choose configurations with BOHB) but also add loss_modules (which is the module used as training loss).
If you want to just use the metric, you should omit selecting the loss module (which will use cross_entropy per default). If you actually want to use a different training loss, you have to add it to the respective node.


Resolve "Refactor code and remove type annotate."

What does this MR do and why?
This PR is for refactoring and maintaining code:

[x]  Refactor optimizeized imports.
[x]  Removed unused variables.
[x]  Removed type annotate.

Screenshots or screen recordings
N/A
How to set up and validate locally

Run the test for the project.

Thanks for your contribution, I really appreciate it, I will review your request as soon as possible

it will help developers who use fatoora to know the type of output and arguments

Example

it will help developers who use fatoora to know the type of output and arguments

Example


Remove remaining vestiges of MUI/material from code and remove package dependencies

As part of this, we'll want to remove extensions\src\hello-someone\src\emotion-test.web-view.tsx or re-write it to test the analogous thing for shadcn.

Comment from TJ on a duplicate case: FYI I noticed there is some MUI stuff used directly in paratext-bible-extensions


Work View shows all work types

 Issue by julesies
Friday Mar 10, 2017 at 15:55 GMT
Originally opened as https://github.com/projecthydra/sufia/issues/3136

This is maybe a feature request, but I wanted to make sure it's known. Sorry for noise, if so.
We are just now testing multiple work types in 7.3.0rc2. We have two Work, Dataset. I noticed on the work view, the top section "Relationships" is growing and it's really not meaningful if there are no relationships. If say we have 5 work types...would they all show?

I'd like to enlist the help of @projecthydra-labs/hyrax-ui-ux-advisors @ggeisler here: should we hide relationships rows if there are no relationships of that type? See @julesies description & screenshot above for more context about why she's asking.

+1 to hiding empty relationship rows.

@mjgiarlo Agree with hiding rows with no relationships.

This seems to be fixed by Hyrax 2.1 (maybe 2.0 as well?)


BUG: Toggled zip_safe

Coverage remained the same at 91.987% when pulling a2440b810afe70ecbfdc83446b150caaf79924a5 on thermokarst:oops into a7e83cab5fe6717449597ad45e530054e60a8842 on nervous-laughter:master.


Test and publish to GitHub pages

This adds a GitHub Action workflow that
runs the tests on all commits (including PRs).
If the commit is in 'master' it will
publish the website to the gh-pages branch,
so it can be served.

Test run in my repo: https://github.com/coderbyheart/conference-buddy-web-app/runs/4418553391?check_suite_focus=true


🐛 [Bug] Encountered bug when compiling yolov5-face JIT model

Bug Description
I try to convert yolov5-face torch model (more specifically yolov5n-0.5.pt) to TensorRT embedded torchscript model with your repo. The JIT model works correctly and there is no problem in pytorch side. When I run the converter code by your instructions, I get the following error.
  File "/home/python-ce/helpers/pydev/pydevd.py", line 1483, in _exec
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/home/python-ce/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/home/torch-tensorRT/test_torch-tensorrt.py", line 35, in <module>
    enabled_precisions={torch.half})
  File "/home//torch_tensorrt/_compile.py", line 97, in compile
    return torch_tensorrt.ts.compile(ts_mod, inputs=inputs, enabled_precisions=enabled_precisions, **kwargs)
  File "/home/.local/lib/python3.6/site-packages/torch_tensorrt/ts/_compiler.py", line 119, in compile
    compiled_cpp_mod = _C.compile_graph(module._c, _parse_compile_spec(spec))
RuntimeError: outputs_[i]->uses().empty()INTERNAL ASSERT FAILED at "../torch/csrc/jit/ir/ir.cpp":1286, please report a bug to PyTorch.
python-BaseException

To Reproduce
You can run the following code:
import torch_tensorrt
import torch
from PIL import Image
from torchvision import transforms
import cv2
import torchvision.models as models

img = cv2.imread('zidane.jpg')
img = cv2.resize(img, (1600,960))
img = Image.fromarray(img).convert('RGB')

convert_tensor = transforms.ToTensor()
img = convert_tensor(img).unsqueeze(0).to('cuda')

jit_module = torch.jit.load("yolov5n-0.5-jit.pt").eval().to('cuda')

trt_ts_module = torch_tensorrt.compile(jit_module,
    inputs=[
        img,
    ],
    enabled_precisions={torch.half})

result = trt_ts_module(img).cpu().detach().numpy()
cv2.imwrite('results_img.jpg', result)
torch.jit.save(trt_ts_module, "trt_torchscript_module.ts") # save the TRT embedded Torchscript

Expected behavior
The code should convert Torch model to TensorRT embedded torchscript model and save the corresponding model.
Environment

Build information about Torch-TensorRT can be found by turning on debug messages

Torch-TensorRT Version : 1.0.0
TensorRT Version : <IP_ADDRESS>
PyTorch Version : 1.10.1
OS : CentOS 7
How you installed PyTorch : pip
Python version: 3.6.8
CUDA version: 11.3
GPU models and configuration: GeForce RTX 2060 Super

Additional context
I tried to convert pretrained ResNet50 model from torchvision, it is converted and gave no error with the same configuration, code and environment.
Thanks in advance!

Can you share the debug logs?

I am sorry but which debug logs that you mentioned about? Only log I have is the one in the issue.

So try running your application but with torch_tensorrt.logging. set_reportable_log_level ( level : torch_tensorrt.logging.Level ) set to DEBUG

First of all, thanks for your quick reply @narendasan.
I tried what you said as follows:
import torch_tensorrt
import torch
from PIL import Image
from torchvision import transforms
import cv2
import torchvision.models as models

img = cv2.imread('zidane.jpg')
img = cv2.resize(img, (1600,960))
img = Image.fromarray(img).convert('RGB')

convert_tensor = transforms.ToTensor()
img = convert_tensor(img).unsqueeze(0).to('cuda')

jit_module = torch.jit.load("yolov5n-0.5-jit.pt").eval().to('cuda')

torch_tensorrt.logging.set_reportable_log_level(torch_tensorrt.logging.Level.Debug)
trt_ts_module = torch_tensorrt.compile(jit_module,
    inputs=[
        img,
    ],
    enabled_precisions={torch.half})

result = trt_ts_module(img).cpu().detach().numpy()
cv2.imwrite('results_img.jpg', result)
torch.jit.save(trt_ts_module, "trt_torchscript_module.ts") # save the TRT embedded Torchscript

Unfortunately, the log gives no clue:
INFO: [Torch-TensorRT] - ir was set to default, using TorchScript as ir
INFO: [Torch-TensorRT] - Module was provided as a torch.nn.Module, trying to script the module with torch.jit.script. In the event of a failure please preconvert your module to TorchScript
DEBUG: [Torch-TensorRT] - Settings requested for Lowering:
    torch_executed_modules: [
    ]
Traceback (most recent call last):
  File "/home/torch-tensorRT/test_torch-tensorrt.py", line 37, in <module>
    enabled_precisions={torch.half})
  File "/home/.local/lib/python3.6/site-packages/torch_tensorrt/_compile.py", line 97, in compile
    return torch_tensorrt.ts.compile(ts_mod, inputs=inputs, enabled_precisions=enabled_precisions, **kwargs)
  File "/home/.local/lib/python3.6/site-packages/torch_tensorrt/ts/_compiler.py", line 119, in compile
    compiled_cpp_mod = _C.compile_graph(module._c, _parse_compile_spec(spec))
RuntimeError: outputs_[i]->uses().empty()INTERNAL ASSERT FAILED at "../torch/csrc/jit/ir/ir.cpp":1286, please report a bug to PyTorch.

@peri044 I tried running this model and seems like there is an off by one error in the _convolution converter. Can you take a look? I can share the model with you over slack


Remove scripts from the package.json before publishing

This is related to installing 3.4 version or higher which throws on husky script.

Do I need to run npm run publish when publishing to npm?

Yes, you can still run npm publish from the folder. This will remove unnecessary fields from the package.json. Library consumers don't need scripts, devDependencies, ... fields when they install the package. We need these fields only for development.

Awesome, great work here, thank you!


Builder : output link support

We need to be able to add link in output sentences.

linked to #243


Add example for differential drive robot controller by ROS

And we need to add apt-get install libudev-dev in the CI.


power up include handling

Handles 2-arg forms: include(::Module, ::AbstractString)

Codecov Report

Merging #303 (dcc5124) into master (2f97d54) will decrease coverage by 1.71%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   89.20%   87.48%   -1.72%
==========================================
  Files          10       10
  Lines        2241     2270      +29
==========================================
- Hits         1999     1986      -13
- Misses        242      284      +42

Impacted Files
Coverage Δ

src/toplevel/virtualprocess.jl
96.68% <94.44%> (-0.70%)
:arrow_down:

src/abstractinterpret/abstractanalyzer.jl
74.40% <0.00%> (-7.57%)
:arrow_down:

src/analyzers/jetanalyzer.jl
92.32% <0.00%> (-3.85%)
:arrow_down:

src/JET.jl
70.34% <0.00%> (-2.14%)
:arrow_down:

src/abstractinterpret/typeinfer.jl
92.68% <0.00%> (-1.01%)
:arrow_down:

src/analyzers/optanalyzer.jl
87.36% <0.00%> (-0.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f97d54...dcc5124. Read the comment docs.


Bold text on the "Create Account" button.

I have a book about graphic design, and it's been a while since I have read it, but I know that you should change the "Create Account" button to bold so that it is more eye-catching and that is the first thing you see when you open the website.

Is it just me or is the “Create Account” button not even visible?

Is it just me or is the “Create Account” button not even visible?

That would be just you...

Reply to retronbv:
Try turning on desktop mode on your browser.
This might also be fixed when mobile mode becomes a thing.

Yeah, I've made it so if your screen is small, it will remove that button... my thought process was if you are on mobile, there's a bigger chance you want to log in than to create a new account. However, I can change this.

Yeah, I've made it so if your screen is small, it will remove that button... my thought process was if you are on mobile, there's a bigger chance you want to log in than to create a new account. However, I can change this.

If we needed more space we could always just remove the create account button and then when you click it there will also be an option to sign in instead or vice versa.

Reply to retronbv:
Try turning on desktop mode on your browser.
This might also be fixed when mobile mode becomes a thing.
chromebook user here, I do not see a sign in button....

Reply to retronbv:
Try turning on desktop mode on your browser.
This might also be fixed when mobile mode becomes a thing.

Chromebook user here, I don't see a sign in button either.

Done in #14


 But the code that produces these structs is susceptible to the foibles of floating-point math, so you want to use the equivalent of the XCTAssertEqual overload that takes an accuracy parameter. This would let you assert on a whole struct or nested tree of structs, where any floating-point properties are compared with the given accuracy.
To Reproduce
Proposed syntax:
struct MyThing: Equatable {
    var foo: Double
}

let a = MyThing(foo: 1)
let b = MyThing(foo: 1.0001)

XCTAssertNoDifference(a, b, accuracy: 0.01)

Expected behavior
This code compiles, and any floating-point values found in the structs or their children are compared using the given precision.
Additional context
An alternative (that I'm going to use in my app for now) is to write a property wrapper such that you can do:
@CloseEnough var foo: Double

And then have a global/Current-style precision value that you can set before you write an assertion. The @CloseEnough property wrapper would use default == comparison in production, and use the precision value only when running in tests.
I tried adding my proposed fix to swift-custom-dump, but got bogged down in _openExistential soup that I didn't understand enough to proceed.

Rough sketch of a property wrapper, in case anyone wants to use it. The naming is just the first thing that popped into my head and it hasn't been tested enough, but it's a starting point.
CloseEnough.swift:
import Foundation

/// Change this if you want. Remember to put it back when you're done.
public var enoughCloseness = 0.01
public func resetDefaultEnoughCloseness() {
    enoughCloseness = 0.01
}

public func withEnoughCloseness(_ closeness: Double, work: () throws -> Void) rethrows {
    enoughCloseness = closeness
    defer { resetDefaultEnoughCloseness() }
    try work()
}

public func withEnoughCloseness(_ closeness: Double, work: () async throws -> Void) async rethrows {
    enoughCloseness = closeness
    defer { resetDefaultEnoughCloseness() }
    try await work()
}

@propertyWrapper
public struct CloseEnough: Equatable {
    public var wrappedValue: Double

    public init(wrappedValue: Double) {
        self.wrappedValue = wrappedValue
    }

    public static func ==(lhs: Self, rhs: Self) -> Bool {
        isTesting
            ? abs(lhs.wrappedValue - rhs.wrappedValue) < enoughCloseness
            : lhs.wrappedValue == rhs.wrappedValue
    }
}

private let isTesting = NSClassFromString("XCTestCase") != nil

CloseEnoughTests.swift
import XCTest
import CloseEnough

final class CloseEnoughTests: XCTestCase {

    func testCloseEnough() {
        struct MyThing: Equatable {
            @CloseEnough var foo: Double
        }

        let a = MyThing(foo: 1)
        let b = MyThing(foo: 1.0002)

        XCTAssertEqual(a, b) // use default closeness

        withEnoughCloseness(0.001) {
            XCTAssertEqual(a, b)
        }

        withEnoughCloseness(0.0001) {
            XCTExpectFailure {
                XCTAssertEqual(a, b)
            }
        }
    }
}

Hey @ZevEisenberg! Thanks for exploring and sharing this. Since this is more of a feature request than a bug in the library, I'm going to convert to a discussion. From there maybe folks will have ideas on how to implement the functionality.


Add extra classes and rules for NanoServer

Update project files and add extra configuration documentation

Because this version requires additional assemblies for compiling and building, I will add test cases later in a separate pull request.

pls merge if you have addressed the CR comments

Thanks.


Fix search estimates requests

Problem Description:
The frontend fails to retrieve search estimates when the search string contains an ampersand.
Expected Behavior/Solution:
The frontend should show estimates when using special characters.
Requirements:

[x] The getSearchEstimates function should convert params using the javascript URLSearchParams object

Needed for promotion:
If an item on the list is not needed, it should be crossed off but not removed.

[x] Wireframe/Mockup - Kam
[x] ~Committee discussions - Sarah~
[x] ~Feasibility/Team discussion - Sarah~
[x] ~Backend requirements - TBD~
[x] Frontend requirements - Kam
[x] ~Are new regression tests required for QA - Amy~
[x] ~Questions~

UAT/LUX Examples:

https://lux-front-tst.collections.yale.edu/view/results/objects?q={"AND"%3A[{"text"%3A"McKinsey"%2C"_lang"%3A"en"}%2C{"text"%3A"%26"%2C"_lang"%3A"en"}%2C{"text"%3A"Company"%2C"_lang"%3A"en"}]}&sq=McKinsey+%26+Company

Dependencies/Blocks:
N/A
Related Github Issues:
N/A
Related links:

https://www.bugherd.com/projects/284041/tasks/2153

Wireframe/Mockup:
Current:

Expected:

Looks good in PROD. Closing


RFC: Standardized title components in Components Library

overview
Currently, we have a few repeating title styles throughout the App and PD -  and a few one offs.
All titles share the same size

font-size: header --fs-header

Titles have 2 weight variants

font-weight: semibold  --fw-semibold (modals)
font-weight: regular --fw-regular (cards)

Alert Modal titles always have an icon and grey background
Wizard Modal titles are always uppercase
Outstanding Questions:
1-  Do Card and Modal components always have title?
2- Should the CardTitle or ModalTitle render as an (optional?) prop of Card or Modal?
Or should the CardTitle or ModalTitle be their own Title atoms that are passed in as children to cards, modals, or other instances of titles with that style?
Title assets across projects
PD- modal labware select

PD- 'section' title
note: this is the only title I could find that was not within a card or modal

APP- card title

APP -  Modal Page (Wizard) title

COMP LIB - Alert Modal title

COMP LIB-  Generic modal title

All modal titles and headers are now in Aa instead of AA.
All modals have titles. All cards in PD have titles too. I can't speak certainly on run app. @pantslakz ?
--
I've made titles semibold in modals but regular weight in cards because when I initially designed the robot dashboard having a semibold title in each card felt like too much. That was a total off the cuff choice and I'm down to change it.

@howisthisnamenottakenyet  @pantslakz
1- If all titles are now Aa, instead of AA am I correct in assuming the titles in ModalPages (Wizards) should be changed to match this?
2- All cards have titles in the app, the only modals that dont have titles are 1-offs which would be updated to be a- AlertModals or b- Plain modals with titles. And example of this is:

3- I personally prefer the lighter font weight for the cards as well.

@mcous @b-cooper
Based on Morgan's comments above,

all cards have titles
all modals have titles
all card title styles should be the same
all modal titles should be the same

Based on this, how do we feel about keeping title as a prop in both cards and modals as opposed to making title components?

@Kadee80 I vote yes for changing all modals to have titles, and titles that are Aa.
However I'm sure Pantea's far more aware of the nuances of Run App modals and can better speak to their needs. If there are currently modals without titles then that could be an issue.


Breaking custom http client instrumentation

Hello!
We're maintaining an instrumentation plugin for the Manticore JRuby http client. https://github.com/runtastic/newrelic-manticore
We noticed that 6.10 introduced a breaking change for us by renaming the file containing Agent::HttpClient::AbstractRequest from abstract_request.rb to abstract.rb. We require this class to implement a request wrapper used for our instrumentation.
I'd just like to clarify whether this is something we should generally expect to happen at all release levels (including minor/patch) or not? Do you have any standard procedures for compatibility of plugin instrumentation? (The class is marked as public API in its comments.)
Thanks!

@alexJunger, thank you for reaching out to us and also authoring and maintaining one of the many excellent gems out there that enhance the agent's core functionality.
The recent changes are not historically a typical set of changes we would make.  The 6.10 release touched on almost every instrumentation as we added ability to notice errors at the segment level.  As part of this large effort, we took the opportunity to refactor much of the HTTP client instrumentation and this unfortunately affected your gem adversely.
As for standard procedures, we've been discussing this more internally and the need to develop and document standards to make it easier to build and maintain plugins and minimize potential to break existing ones like yours.
The abstract class is still present and I don't believe the API signature itself changed, only the file name was changed and relocated to sub-folder to help organize the project code better.  If the API signature inadvertently changed, please elaborate further on the exact error you're experiencing and we'll try to help resolve it.

@mwlang got it! And thanks for your efforts in making and keeping the agent extensible!
The Api signature itself didn't change, correct. We simply got a load error due to the changed file name:
LoadError:
  no such file to load -- new_relic/agent/http_clients/abstract_request

Ok, thank you for clarifying.  I have a question for you @alexJunger:
One of the reasons for the extensive changes on HTTP clients is that we refactored to make all the supported HTTP client libraries we auto-instrument capable of capturing the HTTP response codes and error messages at the segment level.  I took a brief look at your gem to see if I could quickly wrap your instrumentation as well, but I wasn't to pull this off in the time I allotted.
Is this something you'd be interested including in a future update of your gem?

@mwlang that seems worth integrating for sure! Would this data already be used (eg. in APM) or queryable somewhere?

Hi @alexJunger,
When error information is captured at the segment level, error attributes show up on spans in New Relic's Distributed Tracing UI and can also be used to query span events. Check out the release notes for version 6.10 of the agent for more information.


Adds workspaces announcement to CHANGES.md

Since we won't be merging https://github.com/CesiumGS/cesium/pull/10874 till after 1.99, this PR adds an announcement to CHANGES.md informing users about the upcoming changes related to workspaces.

Thanks for the pull request @sanjeetsuhag!

:heavy_check_mark: Signed CLA found.
:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

@ggetz Updated.

Thanks @sanjeetsuhag!


DatabaseDescriptor gives NullPointerException

Using the provided BulkLoad.java, as is, to create the SSTables gives the following error:

Exception in thread "main" java.lang.ExceptionInInitializerError
at org.apache.cassandra.cql3.statements.UpdateStatement.addUpdateForKey(UpdateStatement.java:109)
at org.apache.cassandra.io.sstable.CQLSSTableWriter.rawAddRow(CQLSSTableWriter.java:218)
at org.apache.cassandra.io.sstable.CQLSSTableWriter.addRow(CQLSSTableWriter.java:138)
at org.apache.cassandra.io.sstable.CQLSSTableWriter.addRow(CQLSSTableWriter.java:113)
at bulkload.BulkLoad.main(BulkLoad.java:145)
Caused by: java.lang.NullPointerException
at org.apache.cassandra.config.DatabaseDescriptor.createAllDirectories(DatabaseDescriptor.java:605)
at org.apache.cassandra.db.Keyspace.(Keyspace.java:73)

Using the provided gradle-wrapper.jar file works fine, though.
Is there something necessary which is present in the project that isn't in the provided source file? Or, some additional configuration that needs to be set, but is not mentioned in the associated blog post?

We had bug in  recent version of Cassandra (both 2.0 and 2.1) and was fixed in CASSANDRA-8808 to be released in v2.0.14 and 2.1.4.

Alright. Thank you!


Use pre-commit to standardize code formatting

Request Summary
I would like to implement a tool like pre-commit to handle auto-code formatting and quality checks.  This would be very helpful for onboarding new contributors.
Let me know if this is of interest I'm happy to help implement it.
As a contributor I would like:

A consistent code format across the repo
A way to enforce this code formatting on my own code without having to think too hard (see black)
A one time formatting of all existing code to match this style

Implementation Details
Step 1)
Add a new .pre-commit-config.yaml file at the root of the repo (I'll explain below what this does)
exclude: docs|.git|.tox
default_stages: [commit]
fail_fast: false

repos:
-   repo: https://github.com/pre-commit/pre-commit-hooks
    rev: v4.3.0
    hooks:
    -   id: trailing-whitespace
    -   id: end-of-file-fixer
    -   id: check-yaml
    -   id: check-ast
    -   id: check-docstring-first
    -   id: check-merge-conflict
    -   id: mixed-line-ending

-   repo: https://github.com/timothycrosley/isort
    rev: 5.10.1
    hooks:
    -   id: isort
        args: [--profile, black]

-   repo: https://github.com/psf/black
    rev: 22.6.0
    hooks:
    -   id: black-jupyter

-   repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
    rev: v2.4.0
    hooks:
    -   id: pretty-format-yaml
        args: [--autofix, --indent, '4']
    -   id: pretty-format-ini
        args: [--autofix]
    -   id: pretty-format-toml
        args: [--autofix]

# sets up .pre-commit-ci.yaml to ensure pre-commit dependencies stay up to date
ci:
    autoupdate_schedule: weekly
    skip: []
    submodules: false

The above config file sets up a number of tools to run automatically on edited files when the git commit action is performed:

black python code autoformatting
isort python import sorting
More!

Trailing whitespace cleanup
Newline Adders
Merge Conflict Checkers
toml/yaml/ini autoformatting

Step 2)
Commit the above file and install pre-commit:
pip install pre-commit
pre-commit install
pre-commit autoupdate

Run a onetime code-cleanup of everything
pre-commit run --all-files

Step 3)
Push all of these changes up into GitHub. This can be a painful part of implementing a tool like pre-commit since there will be a massive diff - I recommend the original maintainer be the one to push those changes to retain git blame history.
Step 4)
Add some details for new contributors. I have an example here I try to re-use across GitHub: https://juftin.com/camply/contributing.html

Sounds interesting, let me check it out. Only issue might be that Databricks notebooks are saved as ".py" files, so we'd have to exclude them somehow.

We might also want to check out how the core mlflow repo handles code formatting so as to be compatible with them.


vss vector search tables is not supported in CR-SQL

Dear Team,
We working on privacy firest ai agent and for our data vector search is a critical feature.
i tried to use https://github.com/asg017/sqlite-vss extension that is quite popular vector extension
Steps to reproduce
1 . install deps
npm install sqlite-vss @vlcn.io/crsqlite better-sqlite3

my deps :
<EMAIL_ADDRESS>"^0.16.3",
"better-sqlite3": "^9.4.3",
"fastembed": "^1.14.1",
"sqlite-vss": "^0.1.2",
"uuid": "^9.0.1"

try to turn vss table to a CR-sql table

import Database from "better-sqlite3";
import { extensionPath } from<EMAIL_ADDRESS>import * as sqlite_vss from "sqlite-vss";

const setupDb = (path) => {
    const db = new Database(path);
    db.loadExtension(extensionPath);
    sqlite_vss.load(db);

    console.log('0')
    db.exec(`
     CREATE TABLE IF NOT EXISTS nodes (
        id PRIMARY KEY NOT NULL,
        label VARCHAR
     )
    `)

     db.exec(`select crsql_as_crr('nodes');`)
     console.log('1')
     db.exec(`
    create virtual table node_vector using vss0(
        vectorLabel(768)
      );
    `)
     db.exec(`select crsql_as_crr('node_vector');`)

}
setupDb('mydb.sqlite')

error result :
SqliteError: Table node_vector has no primary key or primary key is nullable. CRRs must have a non nullable primary key
at Database.exec (/Users/volodymyrpavlyshyn/Documents/work/hyphen/cr-sql-playground/vector-test/node_modules/better-sqlite3/lib/methods/wrappers.js:9:14)
at setupDb (file:///Users/volodymyrpavlyshyn/Documents/work/hyphen/cr-sql-playground/vector-test/vec.js:27:9)
at main (file:///Users/volodymyrpavlyshyn/Documents/work/hyphen/cr-sql-playground/vector-test/vec.js:35:18)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
code: 'SQLITE_ERROR'
I also noticed that
CREATE TABLE IF NOT EXISTS nodes (
id VARCHAR(36 ) PRIMARY KEY NOT NULL,
label VARCHAR
)
will throw error

Sorry for the late reply. Was on a family trip.

I see the issue. node_vector is a virtual table so can't itself be made a crr.
sqlite-vss should create base tables underneath the virtual table. Converting those base tables (rather then the top level virtual interface) to crrs would be what we need to do.


Start recording

I have faced issue in recording audio. app starts recording but some time we face issue in recording app do not record audio but audio recording state shows app is recording but in actual in native no thread is running.
startRecorder = async (
uri?: string,
audioSets?: AudioSet,
meteringEnabled?: boolean,
): Promise => {
if (!this._isRecording) {
this._isRecording = true;
  return RNAudioRecorderPlayer.startRecorder(
    uri ?? 'DEFAULT',
    audioSets,
    meteringEnabled ?? false,
  );
}

return 'Already recording';

};
I that code first time if hit button audio recording state update that  value   this._isRecording = true; with out checking wheter app is recording or not. I face issue app is not recording but state shows true

same issue with me not recording at all

https://user-images.githubusercontent.com/27461460/205488009-836f611b-70cc-47fd-afdd-feb4b27c5dcb.mp4
Could you kindly test the example app too? I couldn't reproduce this.


Can't get sql command line client, usage always printed

I want to start the Sql4DClient.jar with the following command:
java -jar target/Sql4DClient.jar  -bh d-bro -bp 8085  -ch d-coord -cp 8085  -pp 8085 -i 200
(d-bro and d-coord are real hostnames and are defined in my /etc/hosts)
When executing the command, I always get the usage screen:
usage: java -jar Sql4DClient-1.0.0.jar
-bh,--broker_host         Druid broker node hostname/Ip
-bp,--broker_port         Druid broker node port
-ch,--coordinator_host    Druid coordinator node hostname/Ip
-cp,--coordinator_port    Druid coordinator node port
-hh,--http_headers        Http He
.... and so on:
what am I doing wrong?

Why do you have  -pp 8085 ?
pp = proxy port
and also i see that cp and pp are both set to 8085.

Sorry, this might be from trying around:
java -jar target/Sql4DClient.jar  -bh d-bro -bp 8085  -ch d-coord -cp 8085   -i 1000
I have different servers so using different hosts and same ports shouldnt be a problem. But I still get printed for the usage information and can't start the client. This happens now on a completely different computer.
Any idea what it might be? This is what I did:

I cloned the repository
mvn clean  install -DskipTests  (tests failed because the provided host didn't exist)
call java -jar target/Sql4DClient-4.1.0.jar  -bh d-bro -bp 8085  -ch d-coord -cp 8080   -i 1000

Am I doing anything wrong or am I missing something?

I think you need -oh and -op as well for the overlord

Also there is not proxyhost in the usage options where in the file it is written to provide proxy host


Dealing with invalid host names

Someone sniffing for open vulnerabilities send our server a request with the URL: http://('4drsteve.com', [], ['<IP_ADDRESS>'])/xmlrpc.php
Our server handles traffic for multiple domains, so it passes the Host header toTLD.js to determine which domain the request belongs to. TLD.js extracts the tail portion of the value (177'])), which has no matching rule, and attempts to create a rule by turning this string into a regular expression without escaping it first.
So we get:
SyntaxError: Invalid regular expression: /.+\.177'])$/: Unmatched ')'
File "/app/node_modules/tldjs/lib/tld.js", line 107, in <unknown>
        if ((new RegExp(pattern)).test(host)) {
  File "/app/node_modules/tldjs/lib/tld.js", line 41, in _someFunction
          if (i in t && fun.call(thisArg, t[i], i, t))
  File "/app/node_modules/tldjs/lib/tld.js", line 91, in Function.getCandidateRule
      _someFunction(rules, function (r) {
  File "/app/node_modules/tldjs/lib/tld.js", line 247, in tld.getDomain
      rule = tld.getCandidateRule(host, rules);

Not sure where to patch fix, probably in Rule constructor when creating a new rule it should always attempt to escape a string?
Or should this even be patched? Should TLD.js throw an error on invalid host names, or just return null?

This is not a valid hostname so I guess it could be addressed by #53.
Thanks for reporting it :-)

Let us know if the 1.5.3 fixed your issue. If so, you can thank @myndzi and close the issue :-)

Still getting the same error with 1.5.3:
> tld.getDomain('(\'4drsteve.com\', [], [\'<IP_ADDRESS>\'])')
SyntaxError: Invalid regular expression: /.+\.177'])$/: Unmatched ')'

Herpaderp. It works when there's a path but not just a hostname. Kind of a problem with accepting mixed format inputs I guess. I'll check it out a little further. My main instinct is to expand cleanHostValue to return only valid hostname characters, which are all acceptable as regular expression characters. Not entirely sure why a regex is being composed from the input, but I don't think I have to internalize all that to fix this problem.

@assaf closing as @myndzi fixed it in #60


HDDS-2987. Add metrics to OM DoubleBuffer.

What changes were proposed in this pull request?
Add a metric that will help in understanding the Average flush time which will help in understanding how the flush time increases over time.
Add another metric to show the average number of flush transactions in an iteration. This will show how many transactions are flushed in a single iteration over time.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2987
How was this patch tested?
Added a UT and also deployed cluster to look into these new metrics.

Thanks the patch @bharatviswa504
Overall it looks good. I have a small question inline.
And one note: I am not sure if calculating the average it the most effective way. External metrics tool (like prometheus) can do it in a much smarter way (instead of calculating an generic average, they can return with moving average).
After a few days a global average couldn't say too much about the current state. (But I have no problem to commit it, if you really need it...)

Thank You @elek for the review. So here the suggestion is to use MutableRate, which will calculcate Average automatically? But anyway the current implementation also does the same right, totalNumberOfFlushedTransactions/totalFlushOps which gives the same value over time. let me know your thoughts?

let me know your thoughts

I misunderstood the average calculation previously therefore I used the wrong examples. This is a better one:
Let's say you have 100 day uptime and at each of day you had 2_000_000 flush transactions with 1_000_000 flush operations. The avgFlushTransactionsInOneIteration is 2_000_000 * 100 / 1_000_000 * 100 = 2.0
The 101st day is a very bad day as you have 2_000_000 transaction per day but with 1_500_000 operations. This is 50% bigger than before, but from the average it's very hard to notice: 2_000_000 * 100 + 2_000_000) / (1_000_000 * 100 + 1_500_000) = 1.99...
I think a generic average (which is calculated based on all the events from the start-up) is not so effective. It is very expressive at the beginning but later it couldn't show real problems.
With real moving averages (which can be easily calculated by prometheus or any other monitoring system) you can see the average of the last day or any period.
But this is not a blocking problem. I don't think that the average of this patch is a very useful metric for production but it might be useful for your performance tests (where you are interested only about the few hours after the startup). (But you can always use prometheus to calculate moving averages...)
Long story short: I will merge it now... Thanks the patch...


backslashes used in bash script for linux/macos

https://github.com/devonfw/devon-ide/blob/02b7493440e987fdfcc516a67e754807dcb8b412/scripts/src/main/resources/create-or-update-workspace#L44
Can never ever have worked like this...

Done.


Feature request: allow paying to LNURL

https://github.com/BoltzExchange/boltz-web-app/blob/7f3791406db4c042cdbe6b5f86528d0b5498423b/src/utils/invoice.ts#L67
Feel free to look at that for reference

Fixed by cd97da3


Unused Suppression Rule reporting bundled(?) suppressions

Describe the bug

[INFO] Suppression Rule had zero matches<EMAIL_ADDRESS>regex=true, caseSensitive=false},cpe={PropertyType{value=cpe:/a:redhat:etcd, regex=false, caseSensitive=false},PropertyType{value=cpe:/a:etcd:etcd, regex=false, caseSensitive=false},}}
[INFO] Suppression Rule had zero matches<EMAIL_ADDRESS>regex=true, caseSensitive=false},cpe={PropertyType{value=cpe:/a:grpc:grpc, regex=false, caseSensitive=false},}}

Version of dependency-check used
The problem occurs using version 11.1.0 of the maven plugin
Log file
https://gist.github.com/OrangeDog/c862ee88f715bce8b31aca626acb0d7a
Expected behavior
It should only be telling me about my own suppressions.

I believe this should have been resolved with #7137. Are you still seeing this?

Folks will still be seeing this until a "legit" FP suppression is published via the Github Actions workflow (PR was merged directly to the generatedSuppressions branch, but such direct PRs don't trigger the publishing right now - only a GHA managed merge does)
Can probably trigger one by approving #7132 which looks like a legit FP.

Yes, it is still happening.

It's fixed now :-)


feat: extractShebangCommand

Add below function:
/**
 * Extracts the command to run a script, from its shebang line.
 * @param scriptContents the script source code
 * @returns array of command and parameters
 */
export function extractShebangCommand(scriptContents: string): string[] {
  return scriptContents.split("\n")[0].replace(/^#!/, "").split(" ");
}

...with the following edits:
TODO

[ ] Use .split("\n", 1) to not read more than necessary.
[ ] Use<EMAIL_ADDRESS>instead of .split(" ").
[ ] Return some more "Command":y type from this repo?

import argvSplit from "argv-split";

/**
 * Extracts the command to run a script, from its shebang line.
 * @param scriptContents the script source code
 * @returns array of command and parameters
 */
export function extractShebangCommand(scriptContents: string): string[] {
  return argvSplit(scriptContents.split("\n", 1)[0].replace(/^#!/, ""));
}


Add Missing VPC Endpoints Backport - terraform 0.11.X

Based on
https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/269#issuecomment-496150401 request to back port changes

Thanks @DrFaust92 !
v1.67.0 has been just released.


Remove version: SmartSoft.SmartFTP version 10.0.3188.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://static.smartftp.com/static/Products/Client/10.0.3188.0/x64/SmartFTP.msi
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 912)


SRA Identity & Auth: [M5] Codegen Changes

Relevant issue(s):
Parent ticket: https://github.com/awslabs/aws-sdk-swift/issues/1119
Grandparent ticket: https://github.com/awslabs/aws-sdk-swift/issues/1095
Pre-existing ticket (used in Q4 planning): https://github.com/awslabs/aws-sdk-swift/issues/700
Summary
Milestone 5 of SRA Identity & Auth Project
* Add codegen for service specific AuthSchemeResolverParameters default implementation
* Add codegen for service specific, model based AuthSchemeResolver protocol and default implementation
* Add codegen for default values of service client auth schemes and auth scheme resolver
* Update AWSServiceSpecificConfiguration - add AuthSchemes field and AuthSchemeResolver field for end-user customizations
* Refactor client operation codegen to use the new middlewares, and stop using SigV4Middleware

PRs:

https://github.com/smithy-lang/smithy-swift/pull/609
https://github.com/awslabs/aws-sdk-swift/pull/1190


The same problem again: problem with character encoding and icons on some russian sites?

I use some Russian torrent trackers (https://kinozal.tv) and they have a problem with character encoding.

And a lot of Russian sites don't have icons (https://www.avito.ru, https://www.ozon.ru etc.). Why are the icons not parsing? Thank's!

Should be fixed in 1.4.11