PassManager.passes() needs a drawer

For context, originally posted by @jaygambetta in https://github.com/Qiskit/qiskit-terra/issues/2179#issuecomment-489385917

I also think I should be able to draw a pass manager
pm.draw()
and it make a flow diagram of all the passes I have in my pass manager with the inputs going into them

Via #2079, PassManager.passes() returns structure with the passes and flow control in a pass manager instance. A drawer should take that structure and make flow diagram based on it.

I'm happy to do this if no one has started on it already? Are there any further ideas about what this should look like?

I was thinking in something like a flow chart in graphviz (we use it already for drawing the dag)... Let me know if you have questions about the PassManager.passes() structure.

I think the thing to show would be that blocks of multiple passes can have a "control" (do-while) and/or a "condition" (if). Otherwise just drawing each pass in a box, and showing the input parameters of the pass, seems ok.


Lerasium spike causes crash

Issue description
I am using the port version and I tried to put a lerasium spike in (the one with all the powers) and it crashed me. I can no longer boot the world
Caused by: java.lang.IllegalStateException: Missing key in ResourceKey[minecraft:root / minecraft:damage_type]: ResourceKey[minecraft:damage_type / cosmere:spiked]
Steps to reproduce
Put lerasium spike in
Profit
Minecraft version
1.19.2 (Latest)
Forge version
47.3.0
Cosmere version
port branch
Other relevant versions
No response
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
https://mclo.gs/LjObzVB

this will be related to me not committing the full datagen changes, runData gets rid of the old copy of spike damage types


Implement String

Implement https://tc39.github.io/ecma262/#sec-string-objects
test with node test/test262.mjs "built-ins/String/**/*.js"

I'm working on it incrementally


chore(main): release 2.7.0

:robot: I have created a release beep boop
2.7.0 (2024-10-31)
Features

Support queries with multiple labels or not-labels (8af2156)

Bug Fixes

deps: update rust crate reqwest to v0.12.9 (9e023c7)
deps: update rust crate serde to v1.0.214 (8fde199)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/philipcristiano/et/releases/tag/v2.7.0 :sunflower:


⚠ API - Lens has degraded performance

In 686a139, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 502
Response time: 715 ms

Resolved: API - Lens performance has improved in 9fb2144 after 6 minutes.


linux.template_release.x86_64.so fails to load on Linux

The Linux implementation of this does not function. "Can't open dynamic library: linux.template_release.x86_64.so" "Error: undefined symbol: clBuildProgram." returns in the editor when loading plugin on Linux.
Linux Kernel 6.8
Linux Mint 22

Getting the same error on Pop OS (Linux)

The problem seems to be that getting OpenCL to work is complex, and we're still getting ready to move to https://github.com/iree-gd/iree.gd with the Vulkan computation.

The problem seems to be that getting OpenCL to work is complex, and we're still getting ready to move to https://github.com/iree-gd/iree.gd with the Vulkan computation.

Thank you for your answer. Do you have any timeline on when this will be ready?

To solve this problem for Linux with the existing whisper, we'll have to make a build for each Linux operating system variety or pick an old base for GitHub actions. It sounds hard. Do you have any ideas?

Is it possible to distribute the source code instead of a built library, with instructions how to build it? The other option would be to package all dependencies in the library. I'm not familiar with this addon, so can't suggest much else.

I can try making specific Popos and Linux Mint versions via docker.

I don't mind doing a build myself, are there some instructions one can use to work around this problem by building from source?


[CS2103-T12-3] HobbyList

HobbyList is a desktop app for managing hobby activities, optimized for use via a Command Line Interface (CLI) while still having the benefits of a Graphical User Interface (GUI). If you can type fast, HobbyList can get your activity management tasks done faster than traditional GUI apps.

Codecov Report

Merging #30 (81b6388) into master (77a32bf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Impacted Files
Coverage Δ

src/main/java/seedu/address/Main.java
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Added support for minItems, maxItems property in parameters section o…

I have added support for min/max items in parameters table by adding getMin/Max items method to ParameterAdapter.
For now, I only added one test to show the functionality.

Coverage increased (+0.08%) to 88.56% when pulling 4da4bc39c21d22553343a241c733d0fc53e363e3 on MarosPataky:master into b4c7c8860c2fd76de0a7e01688cc63489841514d on Swagger2Markup:master.

Tank you very much. Could you please correct the translations.


6x Performance Drop

The benchSonicSync*1000 benchmark is about 6x slower after the commit<PHONE_NUMBER>d67c564a77660b30d8a693efa01757 ("Sync writing must be fully sync").
Before<PHONE_NUMBER>d67c564a77660b30d8a693efa01757
benchSonic*1000: 3338.809ms
benchSonicSync*1000: 3489.371ms
benchSonic4k*1000: 3302.510ms
benchSonicSync4k*1000: 3489.236ms
benchCore*1000: 10764.431ms
benchSonic*1000: 3301.564ms
benchSonicSync*1000: 3490.448ms
benchSonic4k*1000: 3229.361ms
benchSonicSync4k*1000: 3509.415ms
benchCore*1000: 10422.195ms

After<PHONE_NUMBER>d67c564a77660b30d8a693efa01757
benchSonic*1000: 3391.855ms
benchSonicSync*1000: 20495.038ms  // was 3489.371ms
benchSonic4k*1000: 4693.662ms
benchSonicSync4k*1000: 3256.744ms
benchCore*1000: 8517.529ms
benchSonic*1000: 3364.862ms
benchSonicSync*1000: 20543.356ms  // was 3490.448ms
benchSonic4k*1000: 5386.639ms
benchSonicSync4k*1000: 3167.034ms
benchCore*1000: 8749.439ms

Is it still ok to use pino.destination in production? This benchmark makes me worried since pino.destination creates a sonic-boom instance the same way as the benchmark that dropped in performance: new SonicBoom(fd, 0, true).
Also, I think the benchSonicSync4k*1000 benchmark may still be fast because it is not fully sync (possibly due to this code).

Which operating system are you using? Which version of Node.js? That should not cause a perf drop.

Ubuntu 18.04
Node 11.6.0

The answer to this is complex, but do not worry as pino is doing the right thing with the default. Before that change, pino.destination(1) could have lost or corrupt log lines on broken exits. Note that using standard process.stdout could lead to the same corrupted log lines in case of processes within a pipe (in other terms, that is also a bug in Node.js core, I can find a reference if you want one). We made the call that pino.destination(1) should be safe.
Node that for maximum throughput pino.extreme(1) is definitely recommened in combination with https://getpino.io/#/docs/api?id=pino-final.
In #23, I've fixed a bad bottleneck/memory issue condition that the current implementation had, and I also fixed the issue you noted in https://github.com/mcollina/sonic-boom/blob/f41da47b1158cdd18debe7ad2b22fc1ca193462f/index.js#L70-L74. Sync mode with buffering is actually faster in this benchmark because it allocates less memory by blocking the main JS thread. However that gain is not reflected in real-life situations.

Thanks for the explanation and the fix @mcollina!


RTL support

Ensure the Puck UI supports RTL, implementing appropriate CSS where necessary.
Considerations

Use -inline props (like border-inline-start) where appropriate
The overlay is currently rendered inside the iframe, but will be moved to the host as part of #556

try this
https://cdn.discordapp.com/attachments/1277836331501883449/1280291965879193731/fix.zip?ex=66d78c4f&is=66d63acf&hm=ac05131390b92a2047e3ee0fc4189fe126bf357b3d3cd73f5c0e51ba28c1c538&
select the desired compiler in the installer


Double audio, and no video on reels (Firefox only, in Chrome its works perfect)

Script version
5.5
Describe the bug
When I click on the YouTube video sometimes I hear the audio of the ad along with the audio of the video even though the video is started, sometimes I hear double the audio of the video I'm playing, only in the Firefox browser. Ad blocker is disabled.
+
Only audio is playing in reels, visual is not available. (only in Firefox browser)
Expected behavior
Play audio without an issue in normal videos.
Play reels with visuals
Screenshots

Desktop (please complete the following information):

OS: Windows 10 latest update
Browser Firefox
Version 126.0.1 (latest)

Additional context
Add any other context about the problem here.

for me, it doesnt work even in Chrome

Same issue in chrome. Not always. I once kept refreshing and it went away.
But I watched the video went to a other video and the same issue happened again

https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/497#issuecomment-2150654219
https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/497#issuecomment-2150758838
https://github.com/TheRealJoelmatic/RemoveAdblockThing/issues/497#issuecomment-2152530753

For me 5.5 worked fine in chrome. But apparently lots of people got the issue in chrome and edge as well. I only checked couple of times in chrome coz i mainly use firefox

Solution - credits to the fellow memeber who found it
#497 (comment) #497 (comment) #497 (comment)

I just tried it and it worked! thx

Solution - credits to the fellow memeber who found it
#497 (comment) #497 (comment) #497 (comment)

Yep, this works indeed! :)

Well.... soon this probably wont work anymore. Youtube want to implement ads into the video it self.


Optimize transcription cost+latency

Before transcription, remove silences from channel separated audio. Don't make them zero, keep a constant value as 0.5/1s.
Shift the transcript's timestamps afterwards.
Doing this will reduce transcription cost and latency.

Not a priority


Add a spring-cloud-stream-binder for Amazon SQS

Seems like this should be relatively easy by leveraging the SQS support in Spring Cloud AWS. We'd like to use this to support https://github.com/spring-cloud/spring-cloud-netflix/issues/545, so that we can use SQS when running Spring Cloud Services on PWS.

This issue was moved to spring-cloud/spring-cloud-stream-starters#8


[LANG-1682] Adding new startsWithAnyIgnoreCase method and tests cases

Adding new method startsWithAnyIgnoreCase method for case-insensitive version of startsWithAny

My preference is to stop adding APIs that are variations of other APIs based on the casing (and encoding and so on). In the longer term, I can see adding a new String utility class that tracks such an attribute on its instance such that you'd say something like Strings.caseSensitive().someOperation(...) and Strings.caseInsensitive().someOperation(...).

Thanks for the reply.
Is there any plans for this ? It's huge refactoring.

It's something I'd like to do and might take a swing at when I am on vacation in April...

Like you expose the calling to this new Strings class, it looks like you're creating new instance (like a builder) and that should lead to memory impact and performances issues (as I see it)

Like you expose the calling to this new Strings class, it looks like you're creating new instance (like a builder) and that should lead to memory impact and performances issues (as I see it)

If not, this could lead to thread-safety issues. But again I don't know what you want to do

@laurentschoelens
Closing: Please try your use case with the Strings class in git master and snapshot builds.

I've seen your commit regarding the Strings class. I'm pretty sure that will do the job.
Thanks


Update SPI on Sandbox-based architecture environment

Update SPI deployment to the latest
Context https://issues.redhat.com/browse/SVPI-266

@skabashnyuk preview.sh is pointing to spi-e2e-setup.sh from pre-kcp branch - https://github.com/redhat-appstudio/infra-deployments/blob/main/hack/preview.sh#L141 , seems that it can be switched back to main

@skabashnyuk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Not sure why this is here


Get branch name from env var (#74)

The implemented behavior will try to get the branch name from the env var first (even if the Git CLI is available).
This PR includes some refactoring to rely on Optional.

I would hold off on merging this PR until we have resolved the config caching issue explored in this PR and raised in this issue.
I believe we need to make significant changes to where we read the env vars in order to not cause constant config cache invalidation. Depending on how that will be solved, it might require a different approach/implementation.

Closing PR for now. Let's re-open after making the CC compatibility changes.

@erichaagdev how often does this actually come up? We have 1 case for sure which is the one that triggeed this PR. Before time is spend on this PR, we need to certain is worth the added complexity to itegrate and maintain. 1 single customer would not justify it.

I don't think it was intentionally left out.
I think we should also include GitHub actions but this PR is very, very old. This would improve our samples and our builds. For example here

@etiennestuder This would address the issue where CI checks out the branch in a detached HEAD state. In this case,
git rev-parse --abbrev-ref HEAD returns HEAD rather than the branch name.
This is the case for GitHub Actions when a workflow is triggered by a pull_request event. For example, consider this build for android-cache-fix-gradle-plugin:

GitHub Actions checks out the branch in a detached HEAD state: https://github.com/gradle/android-cache-fix-gradle-plugin/actions/runs/4299768295/jobs/7495318117#step:2:372
The corresponding Build Scan is tagged with HEAD and has a custom value of Git branch=HEAD: https://ge.solutions-team.gradle.com/s/5kt2y4de3ahka/custom-values#L2

My expectation in this case is that the Build Scan is tagged with erichaagdev/update-daily-dependabot-time and has a custom value of Git branch=erichaagdev/update-daily-dependabot-time.
Of course this has the side effect that you cannot filter the Build Scan dashboard to include only builds for your branch.
To better understand the impact this has, consider this filter project: android-cache-fix-gradle-plugin and tags: CI not:main not:head for the last 90 days. There are only 16 builds shown: https://ge.solutions-team.gradle.com/scans?search.relativeStartTime=P90D&search.rootProjectNames=android-cache-fix-gradle-plugin&search.tags=ci%2Cnot:head%2Cnot:main&search.timeZoneId=America/Chicago
Now if we drop the tag: HEAD, we have 1954 builds: https://ge.solutions-team.gradle.com/scans?search.relativeStartTime=P90D&search.rootProjectNames=android-cache-fix-gradle-plugin&search.tags=ci,not:main&search.timeZoneId=America/Chicago
This PR also defines a pattern for how to address #114. In that case, builds running on Bamboo with the repository caching feature enabled will see the Git repository custom value as a local file path, rather than the remote repository. See the issue for more details.

@erichaagdev Thanks for the details. But you are not addressing the core of my question which is: how often does this come up with customers?

Sorry, @etiennestuder but I will not be able to provide an exact frequency.
This would be a problem for any customer using GitHub Actions to run workflows on pull_request events, or any other CI provider which checks out projects in a detached state.
The similar #114 issue that I referenced is actually from a customer.

Closing in favor of https://github.com/gradle/common-custom-user-data-gradle-plugin/pull/240


Fix typo in SSL_state_string_long

I guess TLS_ST_SR_NEXT_PROTO means "SSLv3/TLS read next proto" and TLS_ST_SW_CERT_STATUS means "SSLv3/TLS write certificate status".

It's not clear if it will cherry-pick to 1.1.0, but it does belong even there. Suggestion also is to squash commits...

@dot-asm Do you mean squash by me?

Do you mean squash by me?

Not necessarily. Basically it was rather a question to everybody, i.e. does it make sense to squash? I say that it makes sense to do so, while second reviewer might think differently. If we agree that squashing is sensible, it is less relevant who does it in this case, because it's rather simple modification. [If modification was more elaborate, I for one would prefer to do it for contributor.]

I think it makes sense to squash, not just because it's a simple modification, but also because the changes are very very similar (apart from the copyright header, but since that simply reflects that this file was changed, I don't see that it should be separate either).
Just make sure that the message of the squashed commit is sensible...

squashed and merged to master and 1.1.0 (as shown by the commit messages above)
Thank you!


Instant error when downloading.

I get an immediate error when downloading. Here is the log. please let me know what I can do! I have updated to the most recent version of leecher, and this error has never happened before.
Download task has been started!
TWITCH LEECHER INFO
Version: 1.5.6
VOD INFO
VOD ID: 449514627
Selected Quality: 1280x720@30fps (Source)
Download Url: https://www.twitch.tv/videos/449514627
Crop Start: No
Crop End: No
OUTPUT INFO
Output File: K:\PODCAST EPISODES\20190707_449514627_Talk Shows & Podcasts.mp4
FFMPEG Path: C:\Program Files\Twitch Leecher\ffmpeg_x64.exe
Temporary Download Folder: C:\Users\user\AppData\Local\Temp\TL_2b8f979e-8388-4ea9-8399-0b27dfc1d4af
ACCESS INFO
Token: %7B%22authorization%22%3A%7B%22forbidden%22%3Afalse%2C%22reason%22%3A%22%22%7D%2C%22chansub%22%3A%7B%22restricted_bitrates%22%3A%5B%5D%7D%2C%22device_id%22%3Anull%2C%22expires%22%3A1562637314%2C%22https_required%22%3Afalse%2C%22privileged%22%3Afalse%2C%22user_id%22%3A81878460%2C%22version%22%3A2%2C%22vod_id%22%3A449514627%7D
Signature: b8f404cdaa19e1e5ff88b42f993ed18a46ddbe68
Sub-Only: No
Privileged: No
Creating temporary download directory 'C:\Users\user\AppData\Local\Temp\TL_2b8f979e-8388-4ea9-8399-0b27dfc1d4af'... done!
Retrieving m3u8 playlist urls for all VOD qualities...
Starting temporary download folder cleanup!
Deleting directory 'C:\Users\user\AppData\Local\Temp\TL_2b8f979e-8388-4ea9-8399-0b27dfc1d4af'... done!
Download task ended with an error!
System.AggregateException: One or more errors occurred. ---> System.Net.WebException: The remote server returned an error: (404) Not Found.
at System.Net.WebClient.DownloadDataInternal(Uri address, WebRequest& request)
at System.Net.WebClient.DownloadString(Uri address)
at TwitchLeecher.Services.Services.TwitchService.RetrievePlaylistUrlForQuality(Action1 log, TwitchVideoQuality quality, String vodId, VodAuthInfo vodAuthInfo)    at TwitchLeecher.Services.Services.TwitchService.<>c__DisplayClass57_0.<StartQueuedDownloadIfExists>b__2()    at System.Threading.Tasks.Task.Execute()    --- End of inner exception stack trace --- ---> (Inner Exception #0) System.Net.WebException: The remote server returned an error: (404) Not Found.    at System.Net.WebClient.DownloadDataInternal(Uri address, WebRequest& request)    at System.Net.WebClient.DownloadString(Uri address)    at TwitchLeecher.Services.Services.TwitchService.RetrievePlaylistUrlForQuality(Action1 log, TwitchVideoQuality quality, String vodId, VodAuthInfo vodAuthInfo)
at TwitchLeecher.Services.Services.TwitchService.<>c__DisplayClass57_0.b__2()
at System.Threading.Tasks.Task.Execute()<---

No, you did not :)
1.5.8 is the latest version and this error is fixed.

Ah ok thank you.
On Mon, Jul 8, 2019, 8:02 AM Dominik Rebitzer<EMAIL_ADDRESS>wrote:

No, you did not :)
1.5.8 is the latest version and this error is fixed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Franiac/TwitchLeecher/issues/361?email_source=notifications&email_token=AMRVRNGBFFX4FJ2FY7A7Y7LP6NJGRA5CNFSM4H6YD6ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZNLXZA#issuecomment-509262820,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMRVRNGAGII4ZVWRCHY5BPDP6NJGRANCNFSM4H6YD6ZA
.


Revert via

This reverts #1988 and #2044.

Please make your own revert, I only reverted the commits as is. I'd like to get this and the necessary 7.1.0 revert I'm ad soon as possible, so we can get a release out at some point....


GLControl tutorial

Purpose of this PR
Add the long requested GLControl tutorial.
Status

[x] Code a basic GLControl application
[x] Add interaction with other WinForm components
Use Camera from Common (Not possible in this specific case)
[x] Document it

I've used LeanOpenTK.GLControl as root namespace so this is blocked by #11

Awesome contribution. Thanks a bunch!


[LiveComponent] Integrated demo Dependent Form Fields with an existing form

Hi,
I have a Car entity with year, color, brand and model as fields.
I have CarController generated with make:crud and his templates.
I would like integrated demo Dependent Form Fields with an existing form but I do not know how.
When I select 'Audi' for the brand, the options for the model are 'A1', 'A4', 'A5', 'S4'.
When I select 'Citroen' for the brand, the options for the model are 'AX', 'Berlingo', 'Jumpy', 'Saxo'.
etc.
// src/Controller/CarController.php

<?php

namespace App\Controller;

use App\Entity\Car;
use App\Form\CarType;
use App\Repository\CarRepository;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

#[Route('/car')]
class CarController extends AbstractController
{
    #[Route('/', name: 'app_car_index', methods: ['GET'])]
    public function index(CarRepository $carRepository): Response
    {
        return $this->render('car/index.html.twig', [
            'cars' => $carRepository->findAll(),
        ]);
    }

    #[Route('/new', name: 'app_car_new', methods: ['GET', 'POST'])]
    public function new(Request $request, CarRepository $carRepository): Response
    {
        $car = new Car();
        $form = $this->createForm(CarType::class, $car);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            $carRepository->save($car, true);

            return $this->redirectToRoute('app_car_index', [], Response::HTTP_SEE_OTHER);
        }

        return $this->render('car/new.html.twig', [
            'car' => $car,
            'form' => $form,
        ]);
    }

    #[Route('/{id}', name: 'app_car_show', methods: ['GET'])]
    public function show(Car $car): Response
    {
        return $this->render('car/show.html.twig', [
            'car' => $car,
        ]);
    }

    #[Route('/{id}/edit', name: 'app_car_edit', methods: ['GET', 'POST'])]
    public function edit(Request $request, Car $car, CarRepository $carRepository): Response
    {
        $form = $this->createForm(CarType::class, $car);
        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {
            $carRepository->save($car, true);

            return $this->redirectToRoute('app_car_index', [], Response::HTTP_SEE_OTHER);
        }

        return $this->render('car/edit.html.twig', [
            'car' => $car,
            'form' => $form,
        ]);
    }

    #[Route('/{id}', name: 'app_car_delete', methods: ['POST'])]
    public function delete(Request $request, Car $car, CarRepository $carRepository): Response
    {
        if ($this->isCsrfTokenValid('delete'.$car->getId(), $request->request->get('_token'))) {
            $carRepository->remove($car, true);
        }

        return $this->redirectToRoute('app_car_index', [], Response::HTTP_SEE_OTHER);
    }
}

// src/Form/CarType.php

<?php

namespace App\Form;

use App\Entity\Car;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

class CarType extends AbstractType
{
    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $builder
            ->add('name')
            ->add('color')
            ->add('brand')
            ->add('model')
        ;
    }

    public function configureOptions(OptionsResolver $resolver): void
    {
        $resolver->setDefaults([
            'data_class' => Car::class,
        ]);
    }
}

// src/Entity/Car.php

<?php

namespace App\Entity;

use App\Repository\CarRepository;
use Doctrine\ORM\Mapping as ORM;

#[ORM\Entity(repositoryClass: CarRepository::class)]
class Car
{
    #[ORM\Id]
    #[ORM\GeneratedValue]
    #[ORM\Column]
    private ?int $id = null;

    #[ORM\Column(length: 255)]
    private ?string $name = null;

    #[ORM\Column(length: 255)]
    private ?string $color = null;

    #[ORM\Column(length: 255)]
    private ?string $brand = null;

    #[ORM\Column(length: 255)]
    private ?string $model = null;

    public function getId(): ?int
    {
        return $this->id;
    }

    public function getName(): ?string
    {
        return $this->name;
    }

    public function setName(string $name): self
    {
        $this->name = $name;

        return $this;
    }

    public function getColor(): ?string
    {
        return $this->color;
    }

    public function setColor(string $color): self
    {
        $this->color = $color;

        return $this;
    }

    public function getBrand(): ?string
    {
        return $this->brand;
    }

    public function setBrand(string $brand): self
    {
        $this->brand = $brand;

        return $this;
    }

    public function getModel(): ?string
    {
        return $this->model;
    }

    public function setModel(string $model): self
    {
        $this->model = $model;

        return $this;
    }
}

{# templates/car/new.html.twig #}

{% extends 'base.html.twig' %}

{% block title %}New Car{% endblock %}

{% block body %}

Create new Car

    {{ include('car/_form.html.twig') }}

    back to list
{% endblock %}

{# templates/car/_form.html.twig #}

{{ form_start(form) }}
    {{ form_widget(form) }}
    <button class="btn">{{ button_label|default('Save') }}</button>
{{ form_end(form) }}

Basically, the idea is to just put 2 fields which are dependent fields but not written form_start and form_end.
I don't know if this can help you more for my problem.

Oh yes, that's totally allowed also, and it doesn't change much... but I think we don't have it documented. Everything would basically be the same (the component would likely look the same) but you would have the component responsible for rendering a bit less:
{# templates/car/_form.html.twig #}

{{ form_start(form) }}
    {{ form_row(form.field1) }}
    {{ form_row(form.field2) }}

    {{ component('car_model_fields_component', {
        form: form,
        car: car.id ? car : null
    }) }}

    <button class="btn">{{ button_label|default('Save') }}</button>
{{ form_end(form) }}

Then the component template would basically have form_row(form.brand) and form_row(form.model). So, though it's possible, there's not much "point" to having the component only render those 2 field specifically.
There might be a way we can add something to live components to make this simpler... or more automatic... or more "focused" on just the dependent fields (e.g. so that you could render normally, but a live component wraps itself around the 2 fields), but I'm not sure at the moment :)

Unfortunately, it doesn't work.

There might be a way we can add something to live components to make this simpler... or more automatic... or more "focused" on just the dependent fields (e.g. so that you could render normally, but a live component wraps itself around the 2 fields), but I'm not sure at the moment :)

It would be very interesting :)

I would like to do the exact same thing.

@weaverryan, How could we do this? 😄

There might be a way we can add something to live components to make this simpler... or more automatic... or more "focused" on just the dependent fields (e.g. so that you could render normally, but a live component wraps itself around the 2 fields), but I'm not sure at the moment :)


Need to check compatibility between our individual IDEs, python paths... virtual envs.

Jason is currently using spyder and Anaconda as the package manager, which may not play well with everyone else's IDE and package manager (pip). Will need to see what works for 15-20 minutes by:

write a dummy script that needs a certain package to import/run properly
generate a dummy requirements.txt file from either conda or pip
git push both
on another computer, git pull and build env from req.txt, then run code and see if this works

Or jason can just figure this out on his own computer since he's the odd one out using Anaconda.... lol sorry guys

I think I fixed this, just using pip and executing from git bash from now on because of travis CI issues.


Aperture api domain needs to include EMEA and APAC

Currently Aperture modular input only support US region.  Need to update mod-input to select desired api server for user based on region which includes EMEA and APAC servers.
Affected Versions: Add-on 6.0.0-6.0.2
Workaround:  See https://answers.splunk.com/answers/592289/aperture-problem.html

This was added v6.1.0


Generating Guitar Model & Controller With Empty CRUD Actions

Generate Guitars controller with empty CRUD actions using rails generate controller
Generate Guitar model with the first migration using rails generate model
Adding resourceful routes to guitars controller
Presenting data from the DB instead of some mock data & Adding some seed to populate the DB with a few guitars

Screenshot using the Guitars found in the seed.rb file:
(when you enter the localhost on the browser after running the server the application should look like this)

@MariaAga @Ron-Lavi
I have merged this PR with the content of #33
In addition, I have changed the commits to be more precise and small
Please when you review have a look at each commit individually 🙏🏼  hopefully they would make better sense separately
You can see the top comment of this PR with the descriptions of the commits
Also, added a screenshot after populating the DB with the seed using bundle exec rake db:seed, you should see a new guitar when you enter the localhost after running the server of course :)

Tested and works, some auto generated code/files can be removed as in the comments:

Thank you Maria for the review
I have included the fixes 👍🏼

tested and went over the code, looks good!

Thank you @MariaAga  :)


Need permission node for "give-effects" that is overridden for OP users

Doesn't seem to be documented anywhere... but if a user is OP then they are not effected by the "give-effect" flag.  If they want to be effected by this flag, what permission node would we set to false?

Figured this out... the answer is that both being opped overrides most/all effects, as well as worldguard.region.bypass.*  <-- setting this node to false along with deopping myself does the trick.


pulumi.io bug-fixes and general style improvements

This meta-issue is intended to contain a proposed set of visual fixes and overall improvements to pulumi.io.

[x] Fix the search-box styling. Round the corners on the input field, and either add a little spacing between the activation button and the input, or remove the spacing and make the button and input look more unified. The activation button probably needn't be blue, either, as that competes with the SIGN UP button beside it.

[x] In general, button styles look a bit off as well: the single-pixel outline is unique to pulumi.io (so should be removed), paddings, font weights, etc. We should generally apply the same treatments we're using on pulumi.com.

[ ] Cloud-provider logos on the home and quick-start pages should be converted from PNGs to SVGs, and they should look more interactive as well. (They currently seem more decorative/informative.)

[ ] We should remove the underlines in most normal hrefs/links. The bright-blue coloring is clear enough.

[ ] The gray headings on the home page (Why Pulumi? etc.) seem a bit drab. They should be given equal or greater contrast then the content below them. We should consider styling them similarly to the Any Code, Any Cloud items on the pulumi.com home page, with higher-contrast headings, for example.

[ ] The edges of the orange images below that section (in Containers, Serverless, etc.) look fuzzy against the gray background. We could probably make these stand out better by introducing some alternative color and/or contrast.

[ ] The bright blue looks pretty dissonant in this palette. I realize we're using it elsewhere, and it works for links, but it really stands out against when used for buttons and headings in page bodies. There might be a better choice for some of these.

[ ] Items in the TOC navigation should get some sort of a hover effect, like a color change similar to the color they'd get when in the active/selected state, or maybe blue, since that's the color of in-page links.

[ ] The text of TOC items aliases poorly on normal-resolution monitors, and we probably don't need the one-pixel separators between the TOC items themselves, as they're distinguished clearly enough by their color/weight, the spacing between them, and the indentation of their children. (Down with visual noise! :smile:)

[ ] Bullets beside bright-blue/linked text should be text-colored rather than link-colored (as they're not linked themselves).

[ ] In-page TOCs should look more like TOCs, i.e., distinguished from the content below them; even a simple one-pixel seam between them and the content they refer to could help make this separation clearer. Also, since they aren't steps in a sequence, we should remove the lines that connect them. And the bullets themselves should line up vertically with the bulleted items in the pages below them.

[ ] The HubSpot cookie notification (pinned to the lower edge of the viewport) is misaligned vertically and takes up a lot more space than it needs to. If we can fix this, we should.

[ ] Code samples are a bit noisy, visually. We should be able to lighten their backgrounds, remove the pixel borders, and add a bit more border radius and padding to add some visual polish and improve readability.

[ ] In the TOC, closed-state disclosure triangles should probably also be solid, rather than outlined.

[ ] We use red for inline code snippets, but since red isn't part of our brand palette, and in our apps (and in general), red tends to denote wrongness, we might consider a more harmonious alternative for these.

[ ] The large graphic on the API reference home page should be converted somehow to SVG, assuming we need/want to keep it there.

[ ] The pink used for class headings in the API reference doesn't quite "go" with the rest of the palette on this site. We could probably find something a little more complementary for it.

[ ] We should take a pass to fix whatever syntax-highlighting problems we can. (For example, in some CLI output samples, you'll get one random blue word among a block of otherwise dark-gray text, for some reason.)

[ ] The screenshot on the State & Backends page is out of date. We should update it.

[ ] Headings in the providers table on the Organizations page look clickable, because they're the same color as in-page links. We should just make them dark-gray or black to match heading treatments elsewhere.

[ ] Heading casing is sometimes inconsistent (e.g., SEE ALSO in caps, where others are title-cased).

[ ] We should consider using tables rather than lists for CLI subcommands and the like.

[ ] We should render well across the site on mobile.

[ ] We could probably use spacing and color variation to create a slightly better visual hierarchy on these pages. For example, using darker-colored headings with slightly lighter-colored (but still appropriately high-contrast) dark-gray text in paragraphs could add some visual clarity and polish, and make things a little easier on the eyes as well. (Heroku does a nice job of this, IMO.)

[ ] The search-results page is a wall of links. Its overall presentation could probably be improved.

This was displaced by the decision to combine our websites, so I'm moving it to M24.

Is this issue tracking any specific work outside of https://github.com/pulumi/docs/issues/1213?

Some of these items were addressed with #1213, but not all. I'll review this today and close it after creating whatever concrete follow-up come out of that.

Closing as completed with #1213. Will move remaining unchecked items to a new issue and add it to M25.


improve tests to verify intermediate test scheduler updates

Update the unit tests for TestScheduler to validate that scheduler time after each time advance is updated as expected.
This tests shows how to use the updateNanoseconds property of TestScheduler.now.dispatchTime to help determine the Date associated.
I added these tests after finding that using the rawValue property of TestScheduler.now.dispatchTime was not calculated the same between mac-intel and m1 machines, but using the updateNanoseconds property was working as expected.

Hi @shailesh17, thanks for taking the time to open this PR.
If I'm reading it correctly it seems that you want to add test coverage to make sure that the test scheduler's internal now is properly advanced when advancing the scheduler. If so, I think there is a simpler way to express this, and so I have just added it to this other PR: https://github.com/pointfreeco/combine-schedulers/pull/69/files#diff-78940cf2a77de2519d5ba58dbd79f8d25a6df6dcc9ba043b337888bfce54d243
I'm going to close this for now as I think it addresses the issue you brought up, but if I'm missing something please feel free to reply.


Add persistent queues

Things included in this PR:

enable persistent queues configuration in the helm chart
post delete hook which deletes ACLs set for directories used by agent, gateway and clusterReceiver while those pods run as non-root users

Continuation of this PR: https://github.com/signalfx/splunk-otel-collector-chart/pull/668

@omrozowicz-splunk can you please split the PR separately for each problem?


Allow github.com/theforeman/foreman-installer to use internal TF

Requested by @ekohl.

recheck

recheck

recheck

I tried to rerun https://github.com/theforeman/foreman-installer/pull/921 but it still doesn't allow RHEL composes. It's unclear to me how I actually get my tests to run.
As an aside: it is also possible to build on RHEL but run the tests upstream on CentOS Stream? For our specific tests we care less that it's really compatible with RHEL and having completely visible logs to all upstream users is important.

I tried to rerun theforeman/foreman-installer#921 but it still doesn't allow RHEL composes. It's unclear to me how I actually get my tests to run.

I've commented on the PR.

As an aside: it is also possible to build on RHEL but run the tests upstream on CentOS Stream? For our specific tests we care less that it's really compatible with RHEL and having completely visible logs to all upstream users is important.

Yes, I suppose something like this should work (in this case you don't need use_internal_tf of course):
  - job: tests
    trigger: pull_request
    targets:
      rhel-8-x86_64:
        distros: [centos-stream-8]
      rhel-9-x86_64:
        distros: [centos-stream-9]


Shipping: ServiceOptionsCharges at wrong possition

@ //onlinetools.ups.com/api/shipments/v2403/ship

REQ [2024-04-23 12:26 CEST]
    $order->request->ShipmentRatingOptions->NegotiatedRatesIndicator = 'Y';
    $order->request->TaxInformationIndicator = 'Y';
    $order->request->ItemizedChargesRequestedIndicator = 'Y';

RES
    [NegotiatedRateCharges] // <<
    [PackageResults] =>
        (
            [TrackingNumber] => 1Z###
            [ServiceOptionsCharges] => // should be sub-obj. @ `[NegotiatedRateCharges]`
                (
                    [CurrencyCode] => EUR
                    [MonetaryValue] => 0.00
                )

btw/ why include ShipmentCharges if NegotiatedRateCharges are requested? may overwrite SC if NRG are req.


Cidr Attributes for setting subnet

Looks good so far @jbrockopp
Think we also need to include bip: https://github.com/chef-cookbooks/docker#properties-4
Actually, I think that's all we needed but whatevs.


Add packaging for distribution

We are already packaging windows in a way that can be distributed, this adds another CI job to package for Linux linking against GLibC 2.18 (the oldest supported by our Rust toolchain) so the object can be distributed.

@brandonmarken this can be merged, the distribution packaging is working and tests are re-added into the CI pipeline.


Adding/Removing platforms fail when index.html is read-only (on Windows 10)

PhoneGap CLI, node & npm versions
v8
Expected Behaviour
phonegap platforms add [android|ios|windows] should work if index.html has attribute R = read-only on Windows (maybe on other platforms too).
Actual Behaviour
D:\path>phonegap platforms add windows@6
Using cordova-fetch for cordova-windows@6

Adding windows project...

Creating Cordova Windows Project:

        Path: platforms\windows
        Namespace: com.example.mobile
        Name: Mobile app

Windows project created with<EMAIL_ADDRESS>
(node:6248) UnhandledPromiseRejectionWarning: Error: EPERM: operation not permitted, open 'D:\path\platforms\windows\www\index.html'
    at Object.fs.openSync (fs.js:667:18)
    at Object.fs.writeFileSync (fs.js:1326:33)
    at addBOMToFile (D:\path\platforms\windows\cordova\lib\prepare.js:686:12)
    at Array.forEach (<anonymous>)
    at addBOMSignature (D:\path\platforms\windows\cordova\lib\prepare.js:665:1
0)
    at D:\path\platforms\windows\cordova\lib\prepare.js:625:13
    at _fulfilled (D:\path\platforms\windows\cordova\node_modules\q\q.js:854:5
4)
    at self.promiseDispatch.done (D:\path\platforms\windows\cordova\node_modul
es\q\q.js:883:30)
    at Promise.promise.promiseDispatch (D:\path\platforms\windows\cordova\node
_modules\q\q.js:816:13)
    at D:\path\platforms\windows\cordova\node_modules\q\q.js:624:44

(node:6248) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either b
y throwing inside of an async function without a catch block, or by rejecting a promise which was not han
dled with .catch(). (rejection id: 1)
(node:6248) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, pro
mise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Steps to Reproduce
Mark index.html as read-only and add platform a in the log above.
Note: The issue also occurs with adding plugins and with other files marked as read-only, like any js file referenced by index.html.

In what circumstance does this happen to you? Why do you need www/index.html to be readonly?
This does not seem like an issue to me ... there are literally hundreds of things you could do to index.html that would end up breaking the tooling.

From a pure development perspective, I do not see why adding a platform would require RW access to user files including index.html in a phonegap/cordova project. This is just lazy coding.
From a user perspective, we have variations of the same app and our procedures mark files that are not supposed to be changed in a variation as read-only. This ensures that files are modified where they should be and changes be propagated appropriately to all variations.

Anything inside platforms/ is generally considered build cruft, developers should not be changing platforms/windows/www/index.html themselves.
Windows app store submissions have strict requirements on the files in a js app submission.
HTML, CSS, and JavaScript files must be encoded in UTF-8 form with a corresponding byte-order mark (BOM) to benefit from bytecode caching and avoid certain runtime error conditions.
https://docs.microsoft.com/en-us/previous-versions/windows/apps/jj657973(v=win.10)

We are not changing anything inside platforms/windows/www/index.html. We are setting www/index.html as read-only and phonegap propagates the R attribute when copying our files to platforms\windows.

Got that part.  Is it possible to use git to track file changes, or some other system?
I have created an issue here: https://issues.apache.org/jira/browse/CB-13991
This is firmly a cordova issue and not a phonegap specific issue.

We are using git, but git does not prevent changes.
Note that some VCS mark files as read-only. In the old days, this is the way Visual SourceSafe and Team Foundation Server locked checked-in files and a user checkout would remove the R attribute.

This behavior is deeply embedded in apache cordova platform add code, unfortunately it would take considerable re-architecting.


Add exclude for rubocop block length rule

#Why
Our routes get loooooonnng for this app. and the linting doesn't provide any value here. We can use code-review to keep each other honest about complexity

Already done in #25.


Externalize duration formatting, refactor intl scripts

Fixes: #1101
Duration formatting for VM uptime is now localizable:

Bump the version of moment and moment-duration-format

Add support and app initialization code to localize moment and
moment-duration-format

Add src/intl/time-durations.js:

define short and standard duration labels
apply translations of the duration labels at app-init

Refactor the intl scripts to have yarn call shell scripts
and have the scripts handle messages.js AND time-durations.js

Adjust zanata.xml to handle pulls of multiple documents

This is how the Overview card with the dummy/test locale turned on (translatable parts are surrounded by arrows):

ci test

how to properly test the changes?

yarn intl:dummy

and then enter http://localhost:3000//?locale=aa

Tested, LGTM.
Just a small question, maybe not related to the duration formatting but to other translations: is it intentional not to translate "Blank" or "Other OS"? Thanks! :)

Tested, LGTM.
Just a small question, maybe not related to the duration formatting but to other translations: is it intentional not to translate "Blank" or "Other OS"? Thanks! :)

"Blank" ... where is that string?  If it is part of data fetched from rest, we can't translate it.
"Other OS" is the label as defined in the OS info fetched from rest.  Not translatable.

"Blank" ... where is that string? If it is part of data fetched from rest, we can't translate it.
It's a chosen Template in the VM Details card.

"Blank" ... where is that string? If it is part of data fetched from rest, we can't translate it.

It's a chosen Template in the VM Details card.

Ah ok, that makes sense.  It is data!


grenade helper

a grenade helper for every map, shows a circle where to stand?

just copy and past from riptide then

@bruteforcehacker
https://github.com/Blick1337/GRENADE-API


ssh container

Hi, is it possible create a ssh connection with the docker container? I need edit wp-config file.

Just use docker-enter instead of ssh, just gogole for it.

Agreed. Use docker exec. Including ssh is a docker anti-pattern for these kinds of situations.

How to use wp cli with this?!


Allow query records using a textual search

Find records in the Feedback task dataset using a textual search based on the content of the record fields.
Note: text highlighting won't be supported for this first version.

@nataliaElv @Amelie-V the highlighting will not be included in  the MVP.

The search have been remove from the MVP. Ref: #2855


relative paths for scripts and stylesheets

Hello,
I am digging into strider for the first time and wondering if Strider is meant to be run under an nginx proxy that isn't the server root. For instance the following config works
location /build/ {
                proxy_set_header Host $host;
                proxy_set_header X-REAL-IP $remote_addr;
                proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
                proxy_set_header X-Forwarded-Proto $scheme;

                proxy_pass http://localhost:3000/;
        }

but none of the javascript or css loads because they are relative to the root and not the path.
Does Strider only work when proxied from the server root? or is there something I can do to get it working with the above config?

You are correct. Strider only works at the root or a sub-domain.


Will not install dependencies

I have done all that is stated. Installed pip correctly but it will not install dependencies. It keeps on saying error 2. Is the directory wrong? Help please.

Surely it gives more info than error 2? Did you Google fixes?


Racer crashes when referencing an external package in emacs

I made a simple example crate using the sdl2 library from crates.io. I think I set up racer correctly, and completion works when I type "std::io::B" inside the emacs buffer, but if I try and use an external package, (e.g, type "sdl2::I") I get the following error message in the emacs message buffer:
deferred error : (error "Process [/Users/liamoc/.rust/racer] exited abnormally : PREFIX 9,9,
thread '<main>' panicked at 'position 0 does not resolve to a source location', /Users/liamoc/.cargo/registry/src/github.com-0a35038f75765ae4/syntex_syntax-0.8.0/src/codemap.rs:912
")

I am using OS X, with Spacemacs (emacs 24.4.1), if that helps.

Hm, I explicitly installed the racer package, and it works now except the message still shows.

@liamoc  the racer package is really out of date and I think it has ever been updated. why it is that way  I don't know

Right, the completion (and the error) I'm getting is coming from the company-racer package.

(I think @gozes is referring to the crates.io package racer package being out of date. This isn't used by emacs)


Readme addition : How to unsubscribe

I discover recently how to use this extension to unsubscribe user. Documentation isn't explicit about it.

Again.. thanks.. your PR is applied.


Stefanozampini/small improvements

This branch contains a bugfix as discussed in https://github.com/mfem/mfem/issues/443 as well as few other small changes.
Except for the PETSc classes, the main change consists in promoting all coefficients of MFEM bilinear integrators from private to protected, so that they could be accessible from derived classes (I am working at the PDE constrained optimization code that makes uses of this https://github.com/stefanozampini/petscopt/)
New method SparseMatrix::Chop: compresses out the CSR format and remove zeros (I have used it for running some tests with LOR Elasticity)
Also, I have fixed a problem in FindPoints for NC meshes

@tzanio Do you think this branch can make it to mfem-4.0?

Do you think this branch can make it to mfem-4.0?

Possibly. @v-dobrev, what do you think?

Yes, I think this PR should be reviewed and included in mfem-4.0.

@stefanozampini, can you take a look while the Maxwell miniapp run fails on Travis?

@tzanio I tried reproducing the environment used in the Travis machine, but I cannot reproduce the problem on my machine. The only difference is the METIS install (4.0 on Travis, 5.0 locally).
Since the error is caused by the last commit of this branch, I suspect the error is originated by a process having zero elements. fe should be null in this case, and https://github.com/mfem/mfem/pull/756/commits/0c1318dfd363afca4de3486501155fa85fbdac3a assumes a scalar FE in this case. Without this commit, the code should have segfaulted, but for some reasons it did not.

Thank you @stefanozampini, do you want to mention any of the changes inCHANGELOG?
@jakubcerveny and @v-dobrev -- any objections to merging this?

@stefanozampini, we merged this for testing but please see the comments below and let us know early next week if you'd like to make any additional changes.

@v-dobrev Just another name for out-of-source builds https://www.gnu.org/software/automake/manual/html_node/VPATH-Builds.html

For the typecasting, just to use the same comments as for the other classes (PetscParMatrix, etc)

I'm fine with this branch. @v-dobrev, thanks for the fixes to example.  If you wish to make any further changes, go ahead.
@jakubcerveny If you have any faster alternative to the FindNeighbours routine, go ahead and push it.
For now, I just want to have points correctly located in the elements.

@v-dobrev Just another name for out-of-source builds https://www.gnu.org/software/automake/manual/html_node/VPATH-Builds.html

I see, thanks for the clarification.

I'm fine with this branch. @v-dobrev, thanks for the fixes to example. If you wish to make any further changes, go ahead.

I'm not going to make any further changes - this is good to go from my perspective.

@jakubcerveny If you have any faster alternative to the FindNeighbours routine, go ahead and push it.

It's on my TODO list, but I don't have a faster alternative at the moment, sorry.


WIP: V4R update

associated update to https://github.com/strands-project/v4r/pull/73

retest this please


Table Format?

The
Nice
Table

This should render
as a table
in html

| The | Nice | Table |
| ----- | ------ | -------- |
| This should render | as a table | in html |

It already exists as an extension, see here: https://github.com/showdownjs/showdown/blob/master/src/extensions/table.js

@jcbrand is right. Closing

@johnjelinek do you have suggestion regarding the documentation setup that we could improve in order for people like you to easily spot extensions besides our wiki page

table is a little strange as an extension, isn't it?

@johnjelinek Not at all. This type of table syntax is non-standard. In fact, the original markdown spec does not include tables at all (just through html inclusion). Showdown core library tries to follow this spec as much as possible. This is why tables are provided as an extension, not int he core

oic. I think in terms of docs, I wasn't expecting to search for extensions to find tables.

Where can I get the extension, the follow url is missing now.
https://github.com/showdownjs/showdown/blob/master/src/extensions/table.js


Disable all doesnt disable custom rules

Describe the Bug
Using the yaml key to disable all rules does not disable custom rules
---
disabled rules: [ all ]
---

How to Reproduce

Use custom rules
Disable all rules via yaml frontmatter
lint file

Thanks for reporting this @tim-hilde , I believe that is by design, but I will have to take another look. There was no disable option added for custom regex and custom commands if I recall.

So I am thinking that the best solution for this is to short circuit before running running rules if the option for all rules are disabled. The change would need to happen here. It would need to add a boolean value where it would return true if the file should be ignored. That value would either need to bubble up, or it will need to go ahead and be done higher up in the stack.

I am also running into this with custom regex replacements still running in content after a <!-- linter-disable -->.

I will see about tackling both problems in one go. They are a little bit related (they are in the same area of the code). So I will go ahead and make a change to that area and see how things go. I am revamping the tests for the rules runner so it should help take care of the regex replace issue pretty easily.
As for the fact that custom commands are not affected, that might need a little more work to make it play nice since it requires some more information to be present that was not previously being used.

@tim-hilde , what specifically are you calling custom rules? Does that include both custom commands and custom replacement?

@tim-hilde , what specifically are you calling custom rules? Does that include both custom commands and custom replacement?

I am only using custom replacements

@tim-hilde , what specifically are you calling custom rules? Does that include both custom commands and custom replacement?

I am only using custom replacements

Gotcha. I am adding the change for both of them. So it should not run either custom commands or custom replacements if disable all is present.

These 2 issues should be resolved on master and be in the next release. Please let us know if there are any issues with master or the next release.


Simple transient case

Compares the exact and computed solutions at evenly spaced time intervals and graphs the solutions and arc length profiles. There's a strange .5~ inaccuracy that didn't change even after modifying the cell count.

Is this missing anything?


Fix issue where newer versions of dry-core do not work on Ruby 2.7

@bdunne Please review.

Closing in favor of dropping Ruby 2.7 entirely


grpcproxy: define 'watchergroups' in pointer

With Go tip, go vet complains
gopath/src/github.com/coreos/etcd/proxy/grpcproxy/watch.go:53:
literal copies lock value from wp.wgs: grpcproxy.watchergroups contains sync.Mutex

/cc @xiang90 @heyitsanthony
https://travis-ci.org/coreos/etcd/jobs/146782257#L422
Thanks.

@xiang90 PTAL.

lgtm


Return any type that has a PUP routine from [sync] entry methods

Original issue: https://charm.cs.illinois.edu/redmine/issues/331

At present [sync] entry methods can only return a message. Thus, if users wish to return a complex object of some sort, they are forced to declare a message type to put it in and pack it up themselves. It would be much easier if the system automated that effort, allowing users to code sync entry methods of any return type supported by PUP.

Original date: 2013-11-11 06:17:14

As a suggestion to avoid some potential excess copying at the caller side, we might want a proxy object class something like this:
template <typename T>
struct SyncMethodReturnValue {
  uniq_ptr<CkMarshallMessage> msg;
  SyncMethodReturnValue(CkMarshallMessage *m)
  : msg(m)
  { }
  void pupTo(T &t) {
    PUP::fromMem p(msg->getData);
    p|t;
  }
  T operator T() {
    T t;
    this->pupTo(t);
    return t;
  }
};

template <typename T>
T& operator=(T &lhs, SyncMethodReturnValue &rhs) {
  rhs.pupTo(lhs);
}

This should optimize the simple assignment case to just the copy necessary to unmarshall, without impeding the use in an expression as well.

Original date: 2016-06-29 22:58:54

~~https://charm.cs.illinois.edu/gerrit/1294~~ https://github.com/UIUC-PPL/charm/commit/d7d7ce2e3ff742bd9fd34e2261ecd2f7f17a4308
Linking implementation.


Create myFirstFile

Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.

merge


Update smallweb.txt

https://codeconfessions.substack.com/feed
https://rb.ax/atom.xml
http://www.christopher-parsons.com/feed/

We do not take substack (not really small web). Can you find another one?

Very true. I have updated to:
+ https://encapsulate.me/rss.xml
+ https://rb.ax/atom.xml
+ http://www.christopher-parsons.com/feed/


[Feature Request]: Publish extension on OpenVSX

Description
Can you please also publish this extension on OpenVSX to make it accessible for VSCodium users?
See How to publish an extension.
Describe the solution you'd like
No response
Describe alternatives you've considered
No response

Sorry for the delay on that matter. I'm working on getting all accounts and approvals to publish extensions on OpenVSX, once these things are through, I can publish the releases to OpenVSX.

https://open-vsx.org/extension/coderline/mocha-vscode Done 🥳


Fixed that does not auto detect XML files from URL #2420

Refers: Importing an XML file from a URL does not auto detect the correct importer #2420
I tested with a number of URLs, all of which worked.
The content type response header was: application / xml or text / xml.

Nice! I am not sure which PR to merge though, since @james-cui opened another PR #2494 in the mean time (you were assigned to the issue, but it looks like this PR was influenced my review on  #2494). I do not want to be the arbiter of whose PR gets merged… It would be good to have a bit more communication to make sure efforts are not duplicated.
Can you both discuss and let me know if either @james-cui updates his PR, or we merge this?

@wetneb While I appreciate @james-cui 's effort now and in the future, the issue was properly assigned and implemented by @buntamas.  Next time @james-cui needs to ensure that he checks issue assignment.
We don't want to get into an situation where we allow issue hijacking; that will not benefit our project, nor will would it be fair to all parties.  I would also say that if someone assigned doesn't respond after 1 week, then that might be a case for reassignment but never before.  We should probably mention something like that in our CONTRIBUTING.md guide; that we expect some loose responsiveness from contributors, otherwise they risk their issues being reassigned.

I was planning to finish the issue in this week, because last week I debug the problem, only I did not make commit. I saw interested in this issue and I wanted me to solve the problem because I am a university student and my subject matter will be judged on the basis of the solved issues.

@wetneb  @thadguidry @buntamas
just saw this thread, for sure, I come after @buntamas, I was thinking no one was touching this for sometime and propose a fix. But since @buntamas has a diff, I am OK if his is get prioritized.
Next time, should I ask permission to work for an issue before I go ahead? :)

Next time, should I ask permission to work for an issue before I go ahead? :)

I think, @james-cui, the best way to go is to first check if there is an « assignee » to the original request (https://github.com/OpenRefine/OpenRefine/issues/2420), then if someone is there, ask them if they are still working on the issue. If after a week, you get no answer, then you can go ahead. Otherwise, you could work in team with the original assignee?
That's the process I read in other threads about issue assignment. Of course, if no one is assigned, then you can put your name, and can even validate it with a senior developer here (Antonin, Thad, Owen or Tom).
Regards, Antoine

Should I do something more about this issue?


Bug located in element nodal forces operator

Before submitting the issue

[X] I have checked for Compatibility issues
[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
When requesting enfo result with requested_location set to nodal. The default behavior seems to be the averaging of the element nodal values whereas, for a force type result, sum would be expected as default.
Steps To Reproduce

instantiate element_nodal_forces result operator
Set requested_location optionnel input to « nodal »
Compare the values to sum and mean of the unaveraged values

Which Operating System are you using?
Windows
Which Python version are you using?
3.7
Installed packages
Used through ansys mechanical  IPy interface in ansys 22r2

Hi @PABenard, this is an Issue on the server side and is being addressed as we speak. A fix should be available in a coming server release.


Feature/ba 75 graphic page strip

This pr includes both BA-75 graphic page strip, and BA-81 two column graphic page strip container

Looking good @Braedencraig ! Couple of things:

If I add more than one page strip, the text for the one on the right ends up outside of the container on large desktops.
If I add more than two they end up 3 across when it also needs to work in a use case like this
I hadn't mentioned them before this ticket, if you don't mind adding the classes of custom-container and custom-child to the JS blocks for the editor styles.


[FLINK-10816][cep] Fix LockableTypeSerializer.duplicate() to consider…

… deep duplication of element serializer
What is the purpose of the change
LockableTypeSerializer.duplicate() did not duplicate the nested element serializers. This is fixed by the PR.
I introduced LockableTypeSerializerTest to test the change.

Thanks for the review @zentol and @dawidwys. Will merge, including the minor changes from my response to your comments.


[Hub Generated] Review request for Microsoft.AlertsManagement to add version stable/2019-03-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[x] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

Can one of the admins verify this patch?

Hi @xccc-msft ,
Thanks in advance for the review.
I know the changes are considered a breaking change, however these are bug fixes for a misalignment between the ARM Manifest and the Alerts Management swagger.
smartGroups isn’t exposed in our manifest under 2019-03-01 so the swagger should be fixed to not expose them under that api-version.  That should not be considered a breaking change as any clients trying to use that api-version would fail.

@orieldar Could you please help update CODEOWNERS for AlertsManagement?

/azp run automation - sdk

@orieldar Could you please help update CODEOWNERS for AlertsManagement?

@orieldar Could you please help update CODEOWNERS for AlertsManagement?

Sure, done.

@orieldar Thanks. I put on the label of BreakingChangeReviewRequired as it's removing APIs in the PR. You may discuss more once the reviewers start to review.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

all tests pass except breakingchange, need your approval @iscai-msft @assing @xccc-msft, can you please review?

@orieldar We still need ARM review. I'm from SDK team.

@akning-ms Can you please check the context and help merge? Thanks.

Hi @xccc-msft ,
Thanks in advance for the review.
I know the changes are considered a breaking change, however these are bug fixes for a misalignment between the ARM Manifest and the Alerts Management swagger.
smartGroups isn’t exposed in our manifest under 2019-03-01 so the swagger should be fixed to not expose them under that api-version. That should not be considered a breaking change as any clients trying to use that api-version would fail.

Just a check, can we know why smartGroups not exposed in manifest? if it is a mistake, can we fix it in manifest, instead of change swagger?

Hi @xccc-msft ,
Thanks in advance for the review.
I know the changes are considered a breaking change, however these are bug fixes for a misalignment between the ARM Manifest and the Alerts Management swagger.
smartGroups isn’t exposed in our manifest under 2019-03-01 so the swagger should be fixed to not expose them under that api-version. That should not be considered a breaking change as any clients trying to use that api-version would fail.

Just a check, can we know why smartGroups not exposed in manifest? if it is a mistake, can we fix it in manifest, instead of change swagger?

@akning-ms the smartGroups resource is still in public preview, and as such should not be part of a stable version swagger. So this is intended


Preview Scrambled on Google Glass

Hi, thank you for making this project, it is extremely helpful.
When I use your method for adding the aar dependency with Gradle, it compiles and starts up fine, except that with Google Glass, the camera preview is all scrambled and fragmented (see screenshot). I found a SO answer (http://stackoverflow.com/a/22510862/3957976) that mentions there was a fix for this in the camera manager of the source. Is there any way to have this fix included or is that out of the scope of the minimalist idea? Thanks for your time and sorry if this has already been implemented and I'm wasting your time, still learning here.

Will you please test if this is still the case in the 3.x branch? A lot of the camera management code has been rewritten there.

This problem still persists in the 3.x branch. With a new Google Glass coming out soon (for Enterprise), it would be great if there's a module for Glass that solves this issue.

I have a problem importing the corrected zxing-android-embedded.aar into my Glass project. When I try to run:
new IntentIntegrator(this).initiateScan();
I get the following error:
java.lang.NoClassDefFoundError: com.google.zxing.BarcodeFormat
            at com.google.zxing.client.android.DecodeFormatManager.<clinit>(DecodeFormatManager.java:39)
            at com.journeyapps.barcodescanner.CompoundBarcodeView.initializeFromIntent(CompoundBarcodeView.java:128)
            at com.journeyapps.barcodescanner.CaptureManager.initializeFromIntent(CaptureManager.java:156)
            at com.journeyapps.barcodescanner.CaptureActivity.onCreate(CaptureActivity.java:24)
            at android.app.Activity.performCreate(Activity.java:5235)
            at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1089)
            at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2188)
            at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2273)
            at android.app.ActivityThread.access$800(ActivityThread.java:138)
            at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1236)
            at android.os.Handler.dispatchMessage(Handler.java:102)
            at android.os.Looper.loop(Looper.java:149)
            at android.app.ActivityThread.main(ActivityThread.java:5045)
            at java.lang.reflect.Method.invokeNative(Native Method)
            at java.lang.reflect.Method.invoke(Method.java:515)
            at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
            at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:602)
            at dalvik.system.NativeStart.main(Native Method)

Any idea why? I used this guide to import the .aar file: http://stackoverflow.com/questions/29826717/how-to-import-a-aar-file-into-android-studio-1-1-0-and-use-it-in-my-code

Yes, you will need to include zxing:core as well. It's just a jar file, so should be easy. Best is to just specify it as a dependency.

Yep, works!

@AugustoEst @rkistner Are you able to solve the issue of scrambled preview?
I am a bit confused of how to set up my project. I currently have
compile 'com.journeyapps:zxing-android-embedded:3.0.2@aar'
compile 'com.google.zxing:core:3.2.0'

in my build.gradle. If we have to make adjustments in CameraManager.setDesiredParameters(), does this mean that I need to have axing-android-embedded src code in my project?

@rbarman I applied the fixed mentioned above, generated a new .aar file and imported that one into my project. Like this:
compile project(':zxing-android-embedded-glass-fixed')
compile 'com.google.zxing:core:3.2.0'

Sorry for taking so long to get to this. I added the mentioned workaround in version 3.0.3 - please test.

I need to bring up this issue again as ticket #113. It's on a HTC One M8 with Cyanogenmod Nightlies with Android 6.0.1.

I just had a friend over with a Nexus 5 phone for testing. As we could see this problem is caused by my early Android 6.0 version from Cyanogenmod. His official 6.0 is running smooth and the FPS camera problem did not come up. The on demand permission management worked fine also.

Ok, thanks for the feedback.
It's possible that it's just a specific preview size that's not working.
There is an experimental branch for limiting the preview size, which may help as a workaround for a case like this:
https://github.com/journeyapps/zxing-android-embedded/tree/limit-preview-size
That branch is a little outdated though, will have to merge master into it.

v3.2.0 contains some fixes which may solve this issue.
Please re-open if this issue still occurs.


Recent gem releases not reflected in Github?

I noticed while upgrading some gems that Statsample went from 1.4.0 to 1.4.2 and Minimization went from 0.2.1 to 0.2.2 (and appears to have created a hard dependency on rb-gsl, as my heroku build failed—which led me here to investigate what changed).
Although I see an updated History.txt in both Gems, there's nothing reflected in the Github repos in the way of commits or tags. Were these releases made intentionally? Could we get the changes pushed to master?
Also, is rb-gsl going to become a hard dependency of statsample or minimization? (By locking to 1.4.0 and 0.2.1 I do not have rb-gsl in my dependency tree.)
Thanks!

Hi! The currently maintained repository is the SciRuby fork. There are forks for integration, minimization and distribution as well.
Can you open an issue about the hard dependency? I'll fix it this week. Sorry about that, I probably added it as a dependency by mistake when adding a gemspec.

Ah! Thanks. Would it be possible to drop a note in the top of the readme in this repo that points people to the new canonical repo?


Allow newer base and containers versions

Fixes #66.
Tested using
cabal build -c 'containers>=0.7'
Build profile: -w ghc-9.8.1 -O1

@Gabriella439 Would it be possible to review this? It would bring us closer to being able to upgrade Servant to GHC 9.8.

I published the matching revision to Hackage

Thank you!

You're welcome! 😊


Error improvements - named errors by core functions and message template

I have to think about how to add properly named Errors to the core functions.
Currently all of the uses InvalidArguments, which is not good enough, and poorly testable if you have to copy-paste the message text.
Another possible feature is message template or callback function:
UserError.extend({
    configure: function (){
        this.message = this.template();
    }
})

Hmm I think this is good enough.
UserError.extend({
    x: undefined,
    y: undefined,
    template: function (){
        return this.x + " " + this.y;
    }
});

I'll add this feature to UserError.

I move this to 0.8, no time for it in 0.7

I'll use this syntax:
UserError.extend({
    x: undefined,
    y: undefined,
    configure: function (){
        this.message = this.x + " " + this.y;
    }
});


add option to use the concat module to generate map files

In our setup, we need to dynamically generate some map files from other parts of the Puppet configuration. The simplest method for doing this was to add a parameter to postfix::map to use the puppetlabs-concat module to generate the map file instead of a simple file resource.

Ah, I didn't see this PR come in right as I was cutting the release yesterday!
Actually, I think it would be perfectly acceptable to make the file a concat all the time, it can't hurt.

Hmmm, I trashed the spec_helper_acceptance.rb in the PR because since yesterday I've switched to beaker 4 which uses metadata.json for that. I thought that action would simply remove the spec_helper_acceptance.rb diff from the PR, but it actually removes the all file. I'll let you implement concat inconditionally and reset spec_helper_acceptance.rb to its standard value from the master branch.

Sorry for the delay, I thought I'd already done this. I've just submitted a new PR (it was easier than rebasing / updating this old branch…)


Feature (Banners): Vertical alternative/bigger alternative layout.

Create an alternative layout of the banner, said being bigger vertically, similar to the headers of these projects' READMEs:

Vercel's monorepo
Vercel's Satori
Antony Fu's Vitesse
Vitest

Basic layout done in #5


Remove restangular automatic attributes from object while saving

Hi to the team,
Not sure it's a defect but more of a config thing.
Actually when I do save an object with restangular, these attributes are automatically added to my objects, ie:
{
...
reqParams: Request {url: "xxx", _body: null, method: 0, headers: Headers, contentType: 0, …}
restangularCollection:false
restangularized:true
route: myRoute
...
}

Problem is, actually I got an attribute named 'route' which is overridden by restangular while saving.
Why is that, and how not to save these unwanted attributes?
(I'm using angular4, and saving them on a mongoDb collection, if that helps)

Looks like:
export function RestangularConfigFactory(RestangularProvider: any) {
    RestangularProvider.setPlainByDefault(true);
}

did the trick!


HEVC horrible quality compared to Airlink. H264 glitch and freeze the client app.

Description
HEVC got horrible compression aftifacts (compared to Airlink) mainly in fog areas. When i try switch to H264 it glitch and freeze the client app in Quest. I own OG Quest. Testing both versions (installer, portable).
General Troubleshooting

[x] I carefully followed the instructions in the README and successfully completed the setup wizard
[x] I read the ALVR Wikis here and here

Environement
Hardware
CPU: AMD Ryzen 3950X
GPU: AMD Radeon RX6700 XT
Audio: Onboard, VB-CABLE driver for mic.
Installation
ALVR Version: latest (v16.0.0)
SteamVR Version: latest - stable
Install Type:

[x] Packaged (exe, deb, rpm, etc)
[x] Portable (zip)
[ ] Source

OS Name and Version:
Windows 10 Pro 64bit

If you can continue to replicate the crashing/freezing bug on the Quest then if you can get logs that would definitely help.
As for image quality, the biggest things to check are your bitrate settings in ALVR and the capabilities of your network.


Setweak does not recognize group prefix

The setweak command, like all other commands, should recognize the group prefix gp.

For example, setweak g/A+ should be a valid input, instead of setweak A+.

Also, please include a valid use case example like the rest of the commands.

Example: add n/John Doe id/A0123456H<EMAIL_ADDRESS>g/A+ gp/Group 1 gp/Group 1B)

Thanks!

Done in latest pr


feat: save storage secrets

Migrating
https://github.com/SwissDataScienceCenter/renku-notebooks/pull/1927
Depends on #566 and #565
Also will keep this as draft and resolve/merge only when the new data connectors code and secrets that @leafty is working on is merged.

would this be a good time to switch to direct calls in code instead of calling the data svc REST api from within data svc?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

22 of 61 (36.07%)  changed or added relevant lines in 6 files are covered.
8 unchanged lines in 5 files lost coverage.
Overall coverage increased (+0.07%) to 85.785%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

components/renku_data_services/notebooks/api/classes/k8s_client.py
6
12
50.0%

components/renku_data_services/notebooks/api/classes/data_service.py
2
10
20.0%

components/renku_data_services/notebooks/api/schemas/cloud_storage.py
1
11
9.09%

components/renku_data_services/notebooks/core.py
6
21
28.57%

Files with Coverage Reduction
New Missed Lines
%

components/renku_data_services/notebooks/api/classes/data_service.py
1
33.33%

components/renku_data_services/notebooks/api/schemas/cloud_storage.py
1
35.96%

components/renku_data_services/notebooks/api/classes/k8s_client.py
2
64.91%

components/renku_data_services/storage/blueprints.py
2
95.69%

components/renku_data_services/storage/models.py
2
84.11%

Totals

Change from base Build<PHONE_NUMBER>8:
0.07%

Covered Lines:
14556

Relevant Lines:
16968

💛  - Coveralls

would this be a good time to switch to direct calls in code instead of calling the data svc REST api from within data svc?

I would rather do this in a separate pr. I really dont want to bloat these PRs with anything else other than moving the code over form the notebook service. Then if you want to dig out what or why we did something it will be easier.

Here is a follow up PR for this: https://github.com/SwissDataScienceCenter/renku-data-services/issues/586

This is ready for review. The stuff in the pr description is needed only to be able to test and direct requests to the data service instead of the notebook service.
Also I removed http calls to the data service for cloud storage. Which were there prior to this from the code that got moved over from notebooks.

Tearing down the temporary RenkuLab deplyoment for this PR.


Can you give me a hand on how to use the colab?

First I want to thank you for making this prototype and I want to ask you how if you can give me a hand to use this api in
https://colab.research.google.com/github/TavernAI/TavernAI/blob/main/colab/GPU.ipynb

I'm sorry, I'm not good at Google Colab.
But in principle, you must do this:

Run your Colab
Run proxy at YOUR computer, and set up kobold_url link to Colab target api (proxy is your Colab Client)
Set url in your Client to PROXY url (because proxy is Server for your Cleint)


kernel: fatal: log which IRQn is triggering on spurious IRQs

LOG which IRQn line is triggering on spurious IRQs as this makes it much easier to debug spurious IRQs.
The new logs with this patch looks like:
 os: Unhandled IRQn: 227
 os: >>> ZEPHYR FATAL ERROR 1: Unhandled interrupt on CPU 0
 os: Current thread: 0x20032c20 (unknown)
 os: Halting system

@andyross : Much better.
I did not realize fatal.c was so pure.
I did this approach:
"put it in the arch-specific spurious IRQ handler up the stack"
and retested.

@andyross this file is somewhat arch specfic, it is in arch/arm. I’m not sure what would be expected from arch_curr_irqn() when custom interrupt controllers are used. This would come back down to a not-so-helpful information.
arch_handle_fatal_error() and/or soc_handle_fatal_error() could make sense and provide a flexible enough solution.

@andyross this file is somewhat arch specfic, it is in arch/arm. I’m not sure what would be expected from arch_curr_irqn() when custom interrupt controllers are used. This would come back down to a not-so-helpful information.
arch_handle_fatal_error() and/or soc_handle_fatal_error() could make sense and provide a flexible enough solution.

@ithinuel  the origin change was on kernel/fatal.c... https://github.com/zephyrproject-rtos/zephyr/commit/df1c4c97ea2a4b88eedd6668145770634682264f


The language attribute on the script element is obsolete.

Very small change to conform to HTML standards.   Affects no functionality.
This attribute language for

Hi @Cabalist  ,
the build is broken. I might need to add following changes:

to .travis.yml: https://github.com/flask-admin/flask-admin/pull/1556/files#diff-354f30a63fb0907d4ad57269548329e3 (to install correct version of postgis);
tox.ini https://github.com/flask-admin/flask-admin/pull/1556/files#diff-b91f3d5bd63fcd17221b267e851608e8 (to ignore E722);
flask_admin/contrib/sqla/tools.py: https://github.com/flask-admin/flask-admin/pull/1556/files#diff-70f36e099fa84f21ae730c1e207f8814 (to comply with E741 ambiguous variable name 'l');

That would fix the build.
Cheer!


fix(redis): Remove fullnameOverride from redis

Waits for https://github.com/iterative/helm-charts/pull/21
Copying @omesser comment from #123

I recommend the approach where for such things we provide a full name override but the default behavior is to calculate the name in the chart, so the fullnameOverride value is either commented out (@jesper7 will hate it) or just empty string.
We can create a helper template (in _helpers.tpl) along those lines:
{{- define "studio.rayOperator.fullname" -}}
{{- if .Values.rayOperator.fullnameOverride -}}
{{- .Values.rayOperator.fullnameOverride | trunc 63 | trimSuffix "-" -}}
{{- else -}}
{{- printf "%s-ray-operator" .Release.Name | trunc 63 | trimSuffix "-" -}}
{{- end -}}
{{- end -}}

and use in values via {{ include "studio.rayOperator.fullname" . }}
Whenever we have such if-else boilerplate to calc a name or field - we can move it to a helper value to keep the resource charts clean and we would probably end up reusing a lot of those.
don't have a strong opinion about ray vs rayOperator but since the actual ray cluster is a CRD and not the operator that's installed in the chart it might be less confusing to make the distinction obvious via naming, harming brevity

@mjasion is still relevant?


Implement RingQueue as a MPMC circular buffer

This is an attempt to implement a straightforward MPMC ring-buffer.
The current implementation is an exact copy of ArrayQueue, except that this branch is changed to advance the head and swap out the oldest element, instead of returning Err back to the caller.
If you think that this is worth adding to crossbeam and, more importantly, if you agree with me that this implementation is indeed correct, I'm happy to extract the common logic between the two bounded queues and reduce code duplication.
I couldn't find any benchmarks I could run, (am I missing anything obvious?), however I did run benchmarks from ring-channel where I compared this implementation against an emulation of a ring-buffer, that keeps popping elements until pushing succeeds, i.e. something like the following:
while let Err(v) = q.push(value) {
   q.pop();
   value = v;
}

I got the results below on my machine, which show that RingQueue fares much better than ArrayQueue when capacity is low and the probability that pushing fails is high, while they perform about the same when capacity is high enough that pushing almost always succeeds (the baseline was set to the ArrayQueue-based implementation).

Note 1: the relevant metric in the benchmarks below is the throughput, which is scaled by the "channel efficiency", defined as total_number_of_messages_received / total_number_of_messages_sent.
Note 2: benchmark names are suffixed by SB/PxR/C, where S is the size of the element in bytes, P is the number of threads producing, R the number of threads consuming, and C is the capacity of the ring-buffer:
Note 3: the source code for the benchmarks is available here.

Benchmarking mpmc/Block/32B/8x8/1: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 7.2s, enable flat sampling, or reduce sample count to 50.
mpmc/Block/32B/8x8/1    time:   [1.3466 ms 1.3982 ms 1.4507 ms]
                        thrpt:  [1.4117 Melem/s 1.4647 Melem/s 1.5209 Melem/s]
                 change:
                        time:   [-33.037% -28.797% -24.494%] (p = 0.00 < 0.05)
                        thrpt:  [+32.440% +40.443% +49.337%]
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
mpmc/Block/32B/8x8/16   time:   [367.57 us 374.55 us 382.12 us]
                        thrpt:  [5.3596 Melem/s 5.4679 Melem/s 5.5717 Melem/s]
                 change:
                        time:   [-2.1237% +0.3288% +2.6459%] (p = 0.79 > 0.05)
                        thrpt:  [-2.5777% -0.3277% +2.1698%]
                        No change in performance detected.
Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild

Benchmarking mpsc/Block/32B/15x1/1: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 9.9s, enable flat sampling, or reduce sample count to 50.
mpsc/Block/32B/15x1/1   time:   [3.5292 ms 3.7286 ms 3.9535 ms]
                        thrpt:  [971.28 Kelem/s 1.0299 Melem/s 1.0881 Melem/s]
                 change:
                        time:   [-51.773% -43.940% -34.318%] (p = 0.00 < 0.05)
                        thrpt:  [+52.248% +78.380% +107.35%]
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
  4 (4.00%) high mild
  1 (1.00%) high severe
mpsc/Block/32B/15x1/16  time:   [853.29 us 873.07 us 895.27 us]
                        thrpt:  [4.2892 Melem/s 4.3983 Melem/s 4.5003 Melem/s]
                 change:
                        time:   [-8.3188% +0.1727% +9.3995%] (p = 0.97 > 0.05)
                        thrpt:  [-8.5919% -0.1724% +9.0736%]
                        No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
  3 (3.00%) high mild
  2 (2.00%) high severe

spmc/Block/32B/1x15/1   time:   [163.94 us 169.05 us 173.89 us]
                        thrpt:  [1.4722 Melem/s 1.5144 Melem/s 1.5616 Melem/s]
                 change:
                        time:   [-6.0575% -1.4457% +3.5710%] (p = 0.55 > 0.05)
                        thrpt:  [-3.4479% +1.4669% +6.4481%]
                        No change in performance detected.
Found 7 outliers among 100 measurements (7.00%)
  6 (6.00%) low mild
  1 (1.00%) high mild
spmc/Block/32B/1x15/16  time:   [49.955 us 53.012 us 56.021 us]
                        thrpt:  [4.5697 Melem/s 4.8291 Melem/s 5.1246 Melem/s]
                 change:
                        time:   [-9.8603% -3.6168% +3.6703%] (p = 0.31 > 0.05)
                        thrpt:  [-3.5403% +3.7526% +10.939%]
                        No change in performance detected.

spsc/Block/32B/1x1/1    time:   [92.707 us 98.294 us 103.02 us]
                        thrpt:  [2.4851 Melem/s 2.6044 Melem/s 2.7614 Melem/s]
                 change:
                        time:   [-13.073% -5.2960% +2.5130%] (p = 0.21 > 0.05)
                        thrpt:  [-2.4514% +5.5922% +15.039%]
                        No change in performance detected.
spsc/Block/32B/1x1/2    time:   [79.525 us 87.271 us 94.110 us]
                        thrpt:  [2.7202 Melem/s 2.9334 Melem/s 3.2191 Melem/s]
                 change:
                        time:   [-18.141% -8.7754% +0.3419%] (p = 0.07 > 0.05)
                        thrpt:  [-0.3407% +9.6196% +22.162%]
                        No change in performance detected.

Two test cases failed on CI, mpmc on several runs and drop once. The former looks like an issue with the test itself, I didn't account for the fact one of the threads may never successfully pop an element. The latter got me a bit worried. I'll have a look later today.

Ok, so it turns out both test cases that failed had bugs in them, which are now hopefully fixed.

Something just occurred to me, instead of a new queue type, this could simply be a second flavor of push on ArrayQueue, perhaps push_displacing as suggested on #680.

Anything missing, that I could work on?