[general/netlify integration] nitro dev should delete build artifacts generated by previous nitro build

Describe the feature
I'll start with a specific problem, and then generalise to what the broader gap is in my view.
Given a Nitro-powered project, when running netlify build and then netlify dev, the Netlify Dev environment will pick up build artifacts like .netlify/functions-internal/server and dist/_redirect and run them as part of the dev environment. This breaks the dev environment, because those artifacts are from an old build. What should be happening instead is that the Netlify Dev environment proxies all requests to the Nitro Dev server.
There's multiple ways to fix this. One possible fix within Nitro would be to clear all artifacts generated during build on startup of the Nitro Dev server. We could also look at working around this on the Netlify Dev side, although this would probably be workaround that's specific to Nitro - which is always brittle.

The broader gap, in my view, is that Nitro presets only concern themselves with a hosting provider's deployment step (build output etc), but not with the development step.
In the code, you can see this in the fact that the dev server will alway run the nitro-dev preset: https://github.com/unjs/nitro/blob/48c79556b8588d392adfde35faf5c040e2465cf1/src/cli/commands/dev.ts#L37
My idea for how to fix this is to run provider detection in the dev server, and to use that second preset to call hooks specific to local dev. To fix the specific problem i'm reporting, an onPreDev hook could be added to the Netlify preset, which clears any existing build artifacts.
Additional information

[x] Would you be willing to help implement this feature? Yes!

Thanks for the nice writeup issue. Supporting presets in dev mode is in the plan. In the meantime, you can simply add a rm -rf to the netlify dev command i guess as a workaround.


Email verification

Currently no email is being sent to the verify the account which can lead to spammy acounts being created. When the user signs up a email should go to them and they should be able to verify that mail
Pls assign this issue under hacktoberfest to me

currently we're testing things so dummy emails are needed. this would be the last thing I'd do

ok


cannot read models in windows

when I load sd model, it cannot read successful. also do not report an error.

Could you share more information about the prompt which you tested with? The lora path config seems wrong in the image.

Why the printing lora path is ' ?  Could you test it with a safetensor model?
Please try the latest commit, thx!

I run model without lora.

It seems that the model has not been loaded.

BTW, I use visual studio 2022,  does it matter?

@ziyanxzy which SD v1.5 model did you use? The SD v1.5 models from runwayml and dreamlike-anime-1.0 are both tested.
It seems that issue is about "core.read_model" , for load_lora_weights_cpp should have printed out "model init without lora". So the pytorch model or OV model IR could be wrong.


[Wallet] Fix 8 digit codes for mainnet

Description

Fix attestaion service URL, when / in the end is missing
Remove firebase proxies.

Tested
Verification flow on Android device
Backwards compatibility
Yes

Would note that Mainnet isn't the best testing ground for this as most validators haven't updated yet. So I'd probably recommend doing it on Alfajores as well

Would note that Mainnet isn't the best testing ground for this as most validators haven't updated yet. So I'd probably recommend doing it on Alfajores as well

@nambrot this PR specifically fix 8 digit codes on mainnet, on alfajores it works fine without this PR. Also, all validators on mainnet are on >= 1.1.0 version now.

@nambrot this PR specifically fix 8 digit codes on mainnet, on alfajores it works fine without this PR. Also, all validators on mainnet are on >= 1.1.0 version now.


nix-shell-action doesn't work with nix 2.4

This project is using nix -c in https://github.com/workflow/nix-shell-action/blob/main/src/main.ts#L23 which is not present anymore in the nix command from nix 2.4 due to a significant refactor of the command itself, see release notes in https://nixos.org/manual/nix/unstable/release-notes/rl-2.4.html .
The error looks like the following:
error: unrecognised flag '-c'
12
Try 'nix --help' for more information.
13
Error: Error Error: Command failed: bash -c /home/runner/work/_actions/workflow/nix-shell-action/v1/dist/wrapper.sh, action may still succeed though
14
Error: Command failed: bash -c /home/runner/work/_actions/workflow/nix-shell-action/v1/dist/wrapper.sh

I believe a possible workaround is to stick to nix 2.1.

Good point! We can detect new nix versions and change the invocation accordingly.


Generating sequences with given values

Thanks for this library.
I couldn't find an example to generate vectors or matrices containing only 0s and 1s. I see there are lot of examples about how to generate numbers in ranges but no way of generating sequences with given values.
Maybe a method to like ranvv_given(&self, d:usize, values: Vec<T>) where d is the length of the sequence and values can accept a vector so to generate something like:
ranvv_given(3, vec![0., 1.]);
> [0., 1., 1.]

or also
ranvv_given(5, vec![0., 0.5, 1.]);
> [0., 1., 0.5, 1., 1.]

That would be helpful for my tests.

I have added to the nightly (github) code an example on how to generate binary numbers.
It is not really worth releasing a new crates.io version, so for now it is only on github.
It is possible with existing code, similarly to 'throwing dice' example, using ranv_in.
    use ran::{Rnum,Rv,set_seeds,secondary::stringv};
    set_seeds(777777_u64);
    let ru8 = Rnum::newu8();
    // ten random binary numbers
    if let Rv::U8(vecu8) = ru8.ranv_in(10,0.,1.) {
        println!("\nBinary numbers: {}",stringv(&vecu8)) };


fix: typed router export

Hey, I just made a Pull Request!

https://discord.com/channels/687207715902193673/1034089724664610938/1309619723729768448
Fixing this issue:
plugins/plugin-backend/src/schema/openapi/generated/router.ts:245:14 - error TS4023: Exported variable 'createOpenApiRouter' has or is using name 'TypedRouter' from external module "/Users/user/cyclops-backstage/node_modules/@backstage/backend-openapi-utils/dist/index" but cannot be named.

with the TypedRouter import in the generated OpenAPI code.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

You'll also want to add a changeset and signoff your commit, thanks!

Also put identifiers like TypedRouter in backticks like `TypedRouter` in your changeset so that the spell checker does lot try to analyze them

@freben @mtlewis looks like some other changes were based into this, is that causing the pipeline failure? Not sure if my change is related.

@kevspl Yeah, it looks like a bad merge state - we try to just use rebasing to prevent this, I've had it happen a bunch as well 😅 . The easiest thing I find is to
git reset --soft origin/master

to reset to master and leave your changes unstaged, then stage only the files you changed and throw away the rest. You can also do a soft reset in the VSCode UI which will let you select the file you want to add back.

@kevspl Ah, looks like we need to also remove the import here, https://github.com/backstage/backstage/actions/runs/12129004559/job/33816640127?pr=27965#step:13:12

@kevspl Ah, looks like we need to also remove the import here, https://github.com/backstage/backstage/actions/runs/12129004559/job/33816640127?pr=27965#step:13:12

Alright I think I have finally gotten the kinks worked out. Should be good to merge now, I also tested this change locally and it fixes my error with the compiler.

@aramissennyeydd Thanks for the help so far. I think I've got it ready to merge now 🤞


Markdown Preview not resolving local images.

Type: Bug
Hello,
This was working fine until yesterday, but today I cannot preview images in the markdown document I was working on.

I have tried disabling all extensions.
I have tried different folders, with different images.

The markdown itself works, it formats headers correctly, makes lists.. the rest of the usual stuff. It also resolves images if provided via a url.

does not work anymore
VS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T15:06:02.407Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 4800H with Radeon Graphics          (16 x 2894)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.87GB (5.87GB free)

Process Argv
--crash-reporter-id ede4e9c6-531f-446f-8a86-23e97dc54acb

Screen Reader
no

VM
0%

Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vscaac:30438847
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
282f8724:30602487
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
03d35959:30757346
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixshowwlkth:30771522
showindicator:30785052
pythongtdpath:30769146
i26e3531:30780429
pythonnosmt12:30779714
pythonidxpt:30784022
pythonnoceb:30776495
h7j2d465:30786200
dsvsc013:30784100

Closing this issue.
The issue is no longer present. Perhaps this was related with my machine rather than with VSCode.


MP using wrong occurs in

[ ] Need to replace with BFO:66
[ ] Add qc check to prevent from happening again

There are 506 wrong usages:

Is this something you can fix with a script? Or do we need to do it manually?

I will do it, 2 seconds.


scheherazade-new: init at 3.000

Motivation for this change
Major update: https://software.sil.org/scheherazade/release-3-000/
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hmm. I suspect that given that this font has entirely new metrics and a new name, you might be better off packaging this separately as a new package - from the homepage:

Why the name change? Why is this now called Scheherazade New?
Scheherazade has been around for many years. Over the years people have complained about the small size of the font in comparison to other fonts. We have completely resized the glyphs in Scheherazade New. If we had kept the same name, the layout of all existing documents would be affected. Thus, this name change allows users to keep using Scheherazade for older documents, but they can begin using Scheherazade New for new documents."

What do you think?

All right, let’s keep the old one and package the new one as scheherazade-new.

Merged into 20.09 as 879bc29f7605c2e49798a1b26e2a0dacaa93671f


Add clang-format 7

clang-format 7.0.0 is already available.

...and I now have 8.0.0 via homebrew on macOS :-)
clang-format version 8.0.0 (tags/google/stable/2018-12-18)

Upstream is at version 10 by now. Any news?

I've updated the setup script and added the more recent versions.  Some of the features still don't work (e.g. the custom bracketing options), but hopefully it's useful anyway.

I'd try it but I get error 503 at https://zed0.co.uk/clang-format-configurator/ right now.

Apologies, up again.

Cool, thank you!


Have the plugin adhere to exact key combinations

It would be nice if the keybinds weren't able to be activated if other modifier keys were used.
Ex:
If I have 'W' bound to North, CTRL+W shouldn't activate the keybind.

It'd make a great addition!

+1 for supporting modifier keys. I suspect WASD for regular camera movement and WASD with a modifier for NESW would be a common conclusion.


Allow WebSocket's ServerEndpointConfig.Configurator.modifyHandShake to control the outcome of the upgrade request

Our use case is to intercept a "upgrade to WebSocket" request, run some custom logic to inspect Authorization header in the HTTP request and control the outcome of that upgrade request.
The suggested interception point from Helidon team is a custom  jakarta.websocket.server.ServerEndpointConfig.Configurator added to the WebSocket routing that overrides the modiyHandshake method.   Custom implementation can fail the handshake (as desired) but there are couple of issues with the approach:

jakarta.websocket.server.HandshakeResponse supplied to  modiyHandshake doesn't allow response code to be set. One can workaround this by casting down  to the response TyrusUpgradeResponse
Response code and reason set in TyrusUpgradeResponse isn't propagated back to client. Clients see a generic handshake failure error instead.

Environment Details

Helidon Version: 3.2.2
Helidon SE
JDK version: "17.0.7" 2023-04-18 LTS
OS: MacOS
Docker version (if applicable): N/A

Problem Description
See above
Steps to reproduce

Write a custom ServerConfigurator, like so

package io.helidon.webserver.examples.websocket;

import jakarta.websocket.HandshakeResponse;
import jakarta.websocket.server.HandshakeRequest;
import jakarta.websocket.server.ServerEndpointConfig;
import org.glassfish.tyrus.core.TyrusUpgradeResponse;

import java.util.Optional;
import java.util.logging.Level;

public class FailingAuthConfigurator  extends ServerEndpointConfig.Configurator {
    private static final String WS_ACCEPT_HEADER = "Sec-WebSocket-Accept";

    @Override
    public void modifyHandshake(ServerEndpointConfig sec, HandshakeRequest request, HandshakeResponse response) {
        if (!this.isAuthenticated(sec, request)) {
            failUpgrade(response);
        }
    }

    private boolean isAuthenticated(ServerEndpointConfig sec, HandshakeRequest request) {
        // Forcefully fail to demonstrate the issue
        return false;
    }

    private void failUpgrade(HandshakeResponse response) {

        // HandShakeResponse doesn't allow setting the status
        if (response instanceof TyrusUpgradeResponse) {
            ((TyrusUpgradeResponse) response).setStatus(401);
            ((TyrusUpgradeResponse) response).setReasonPhrase("Failed to authenticate");
        }
        // response.getHeaders().computeIfPresent(WS_ACCEPT_HEADER, (k,v)->{return null;});
        // Or
        // response.getHeaders().clear()?
        // Neither choice returns a 401 to the client. In both cases, client sees a Handshake Error
        // which can be confusing for clients.
        // Tyrus client engine has the ability to send an Upgrade request with an Authentication header
        // but that's not exposed in Jakarta WebSocket API.
        response.getHeaders().clear();
    }
}

Add the configurator to a WebSocket routing end point

 WebServer server = WebServer.builder()
                .port(8080)
                .addRouting(WebSocketRouting.builder()
                        .endpoint("/websocket", ServerEndpointConfig.Builder.create(MessageBoardEndpoint.class, "/board")
                                .configurator(new FailingAuthConfigurator())
                                .encoders(encoders)
                                .build())
                        .build()
                )
                .build()
                .start()
                .await();

Start the server and connect to it using a WebSocket client.  The handshake will fail but the client will see  "Handshake Failure" response instead of a 401.

The problem is that Tyrus is only honoring the header updates in the modifyHandshake call. Any other changes to the response are ignored. Tyrus also supportsthrowing a HandshakeException, but it is a checked exception, so it cannot be thrown from modifyHandshake. The spec is not very clear about this use case either.

https://github.com/jakartaee/websocket/issues/199#issuecomment-628864319

https://github.com/eclipse-ee4j/tyrus/pull/864

Waiting for resolution of #7954

Tyrus was upgraded to 2.1.5. See #8277.

We picked up version 3.2.6 but the issue persists from a Helidon client perspective.  Status set in the updated Tyrus version is still not propagated to clients.

@spericas I don't see an option to re-open this issue here. Could you please help with that? Thank you.

@dmutreja Could you share your WS client code that is looking for the status code?

So I went back and analyze the HTTP upgrade flow through Netty -> Helidon -> Tyrus (I didn't get this far before due the issue in Tyrus):

I can confirm that Tyrus is now doing the right thing and returning the updated response from the upgrade handler

Helidon has access to any status code or error returned by the handler

However, the only thing that Netty supports and is able to propagate back are any updated headers and only if the upgrade request succeeds. If Helidon fails the upgrade (by looking at a status code different from 101) then Netty passes the request to the next handler in the chain, which is not useful in this case.

In summary, I think with the current integration in Helidon 3.x, we cannot support this this use case as it is. It may be different in Helidon 4.x where we have full control over the WS stack (no Netty there). Have you considered any other ways to implement your auth use case?
For more information on what Netty does, you can check io.netty.handler.codec.http.HttpServerUpgradeHandler:376.


Unable to find main.go file

Description:
When running the program via Pycharm, the program can't find the main.go file, even when I point it to it via the GUI:

Error:

To Reproduce
Steps to reproduce the behavior:
Just follow the documentation as specified in the README
Expected behavior
I expected it to run as it did in the demo on youtube
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: Version 88.0.4324.104 (Official Build) (64-bit)

Can anyone please tell me what I am doing wrong here?

Thank you for pointing out this error.
Cause
The error suggests that the path given to the main.go file is incorrect and if you see C:\... appears to be  repeated in the file path given in the error.
Solution
To fix this, please navigate to the GUI.py file in the src\python\GUI directory and change line 64 just below form the command  to command = "go run " + values[10] + " " + name + " " + strategy_chooser + " " + timeinterval + " " + live
Hopefully this solves the problem.

Thank you for pointing out this error.
Cause
The error suggests that the path given to the main.go file is incorrect and if you see C:\... appears to be  repeated in the file path given in the error.
Solution
To fix this, please navigate to the GUI.py file in the src\python\GUI directory and change line 64 just below form the command  to command = "go run " + values[10] + " " + name + " " + strategy_chooser + " " + timeinterval + " " + live
Hopefully this solves the problem.

Description:
When running the program via Pycharm, the program can't find the main.go file, even when I point it to it via the GUI:

Error:

To Reproduce
Steps to reproduce the behavior:
Just follow the documentation as specified in the README
Expected behavior
I expected it to run as it did in the demo on youtube
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: Version 88.0.4324.104 (Official Build) (64-bit)

Can anyone please tell me what I am doing wrong here?

Thank you for pointing out this error.
Cause
The error suggests that the path given to the main.go file is incorrect and if you see C:\... appears to be  repeated in the file path given in the error.
Solution
To fix this, please navigate to the GUI.py file in the src\python\GUI directory and change line 64 just below #form the command  to command = "go run " + values[10] + " " + name + " " + strategy_chooser + " " + timeinterval + " " + live
Hopefully this solves the problem.

Description:
When running the program via Pycharm, the program can't find the main.go file, even when I point it to it via the GUI:

Error:

To Reproduce
Steps to reproduce the behavior:
Just follow the documentation as specified in the README
Expected behavior
I expected it to run as it did in the demo on youtube
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: Version 88.0.4324.104 (Official Build) (64-bit)

Can anyone please tell me what I am doing wrong here?

Thank you for pointing out this error.
Cause
The error suggests that the path given to the main.go file is incorrect and if you see C:\... appears to be  repeated in the file path given in the error.
Solution
To fix this, please navigate to the GUI.py file in the src\python\GUI directory and change line 64 just below #form the command  to command = "go run " + values[10] + " " + name + " " + strategy_chooser + " " + timeinterval + " " + live
Hopefully this solves the problem.

Hi Sanchit,
I have done the above and I am now faced with another error message:
[image: image.png]
Would it be possible for you to help me with this one please?
Am I possibly doing something horribly wrong here?
Kind Regards,
Armandt
On Sat, Jan 30, 2021 at 4:04 AM Sanchit Ajmera<EMAIL_ADDRESS>wrote:

Description:
When running the program via Pycharm, the program can't find the main.go
file, even when I point it to it via the GUI:
[image: image]
https://user-images.githubusercontent.com/60919354/106257940-e332c780-6225-11eb-94f6-a8d0ec767369.png
Error:
[image: image]
https://user-images.githubusercontent.com/60919354/106258195-3442bb80-6226-11eb-8463-bd9cd5aa3b86.png
To Reproduce
Steps to reproduce the behavior:
Just follow the documentation as specified in the README
Expected behavior
I expected it to run as it did in the demo on youtube
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: Version 88.0.4324.104 (Official Build) (64-bit)

Can anyone please tell me what I am doing wrong here?
Thank you for pointing out this error.
Cause
The error suggests that the path given to the main.go file is incorrect
and if you see C:... appears to be repeated in the file path given in
the error.
Solution
To fix this, please navigate to the GUI.py file in the src\python\GUI
directory and change line 64 just below #form the command to command =
"go run " + values[10] + " " + name + " " + strategy_chooser + " " +
timeinterval + " " + live
Hopefully this solves the problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/SanchitAjmera/ETHena/issues/31#issuecomment-770137148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOQY4OX4N6ICIPKBXCEE4U3S4NSLJANCNFSM4WYR3HDA
.

Hi Sanchit, I have done the above and I am now faced with another error message: [image: image.png] Would it be possible for you to help me with this one please? Am I possibly doing something horribly wrong here? Kind Regards, Armandt
…
On Sat, Jan 30, 2021 at 4:04 AM Sanchit Ajmera @.***> wrote: Description: When running the program via Pycharm, the program can't find the main.go file, even when I point it to it via the GUI: [image: image] https://user-images.githubusercontent.com/60919354/106257940-e332c780-6225-11eb-94f6-a8d0ec767369.png Error: [image: image] https://user-images.githubusercontent.com/60919354/106258195-3442bb80-6226-11eb-8463-bd9cd5aa3b86.png To Reproduce Steps to reproduce the behavior: Just follow the documentation as specified in the README Expected behavior I expected it to run as it did in the demo on youtube Desktop (please complete the following information): - OS: Windows 10 - Browser: Chrome - Version: Version 88.0.4324.104 (Official Build) (64-bit) Can anyone please tell me what I am doing wrong here? Thank you for pointing out this error. Cause The error suggests that the path given to the main.go file is incorrect and if you see C:... appears to be repeated in the file path given in the error. Solution To fix this, please navigate to the GUI.py file in the src\python\GUI directory and change line 64 just below #form the command to command = "go run " + values[10] + " " + name + " " + strategy_chooser + " " + timeinterval + " " + live Hopefully this solves the problem. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#31 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOQY4OX4N6ICIPKBXCEE4U3S4NSLJANCNFSM4WYR3HDA .

Hi,
Please could you send the image containing the error again as it hasn't gone through in your message.
Thank

Hi there,
I too faced the same problem and adjusted it accordingly as mentioned here.
Please see image of the new error

Thank you

Hi,
It seems like the Go packages weren't installed on your system.

Retry the GUI after that and see if there are any further errors.
Thanks.

Hi,
It seems like the Go packages weren't installed on your system.

Retry the GUI after that and see if there are any further errors.
Thanks.

Thank you, I redid everything from start to end and now it ran


Walkthrough: Writing a Visualizer in C#

[Enter feedback here]
This page shows that the visualizer is a .Net Framework application. The problem is that this will not work if the the data to see is in a .Net Core DLL. If a .Net Core DLL project is created then the VSSDK.DebuggerVisualizers package has a warning. How do we create a Visualizer that needs to call .Net Core DLL?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de5d2403-0edc-8ee9-22f6-6ca370b40346
Version Independent ID: d34a6007-354e-0bdb-3ad7-9f15a2cb56f2
Content: Write a visualizer in C# - Visual Studio
Content Source: docs/debugger/walkthrough-writing-a-visualizer-in-csharp.md
Product: visual-studio-windows
Technology: vs-ide-debug
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@ddemland -- thank you for your question.  Please consider these resources:

Visual Studio on Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@Mikejo5000 -- please look into this potential documentation issue.

Yes. There is support for both .NET Framework and  .NET Core visualizers.
There is no big difference in the creating a C# visualizer except the target framework, the important part is installing the visualizer. See How to: Install a Visualizer

Updated doc after testing and discussion with owners. Currently, we recommend creating a .NET Framework visualizer. Calling app may be .NET Core. Custom data object may be .NET Standard. Doc is updated now:
https://docs.microsoft.com/en-us/visualstudio/debugger/walkthrough-writing-a-visualizer-in-csharp


Added viewer implementation for Bitbucket repositories (issue #197)

Hi, I also wanted to use the viewer for workbooks hosted in Bitbucket repos, and put together a small implementation.
The keys used in the view.html querystring are identical to those used for GitHub repositories, with one additional key revision, which defaults to "HEAD" (it is possible via the Bitbucket API to request a particular revision). Bitbucket repositories are served when source=bitbucket.
The main notable change is to add a new KO data-bind variable, host, reflecting where the workbook is hosted; this then is used instead of the hard-coded "GitHub" text in view.html. This value defaults to "GitHub" for the currently-supported GitHub repositories and gists, unless the source is set to bitbucket, in which case it is changed to "Bitbucket".
Thanks!

This looks great :-) Only comment is that it looks a bit strange to just have my name in the Copyright section of a file that I haven't written any of. I suggest we change it to either ,  + contributors, or if we want to be consistent across the project  + contributors. I'm happy with anything, and want to make sure everyone is appropriately credited.
Do you have a worksheet on bitbucket publicly accessible, for testing?

Thanks. There are a number of worksheets at https://bitbucket.org/fwood/anglican-examples, (which, incidentally, is currently mirrored by https://github.com/fwood/anglican-examples). For example (assuming running locally on port 8990):
http://<IP_ADDRESS>:8990/view.html?source=bitbucket&user=fwood&repo=anglican-examples&path=worksheets/gmm-iris.clj
That pulls the HEAD revision. You can also go look at an earlier version by referencing a (prefix of a) git commit hash, e.g.
http://<IP_ADDRESS>:8990/view.html?source=bitbucket&user=fwood&repo=anglican-examples&path=worksheets/gmm-iris.clj&revision=af1d127
As for credit, well: the Bitbucket file is not really appreciably different from the existing GitHub file =). I am certainly fine with it reading "Jony Hudson + contributors". How have you been handling this for previous pull requests and contributors?

I've merged this and deployed to the public viewer. See:
http://viewer.gorilla-repl.org/view.html?source=bitbucket&user=fwood&repo=anglican-examples&path=worksheets/gmm-iris.clj
Regarding the copyright notices, my approach so far could probably be described as "inconsistent"! TBH, I don't think it much matters, from a legal point of view, and the git commit records attribute stuff carefully anyway. I also maintain a list of contributors on the landing page of http://gorilla-repo.org . So, I propose ignoring it at the moment, and changing to something uniform for each file like "The Gorilla REPL contributors" at some unspecified point in the future :-)

p.s. Thanks again for the PR :-)


Do NOT hide player controls when a player is powered off.

I know that you expressed your intention not to add this. But really: in mobile mode it now takes at least three taps to start playback on a powered off Radio. With the controls there, it's one. The minimum there can be. Please :-).

I'd have to

tap player selector
select player
tap player selector again
power on
start playback

Thank you very much!


[SUPPORT] Hudi deletes fail in HoodieDeltaStreamer

Hello, we are facing issue when running the spark-submit command after performing a DELETE operation on the PostGres database.  The spark command, schema and properties file are given.  The spark command generates the target Hudi tables after an INSERT of a row into the database, successfully.  But, it fails with a "rolled-back" HudiException when after running the Spark command. We are using EMR version 6.7.0 with Hudi 0.11.0-amzn-0.  The source of the data is a PostGres database.  AWS DMS generates the parquet file from Postgres and lands the datasets into S3 landing zone.  We tried both COPY_ON_WRITE and MERGE_ON_READ, yet DELETEs fail.
Environment information:
Hudi version : 0.11.0-amzn-0
Spark version : version 3.2.1-amzn-0
Hive version :  3.1.3
Scala version : 2.12.15
Hadoop version : xxx
Storage (HDFS/S3/GCS..) : S3
Running on Docker? (yes/no) : no
DMS Engine Version: 3.4.7
Spark command
sudo spark-submit --jars /usr/lib/spark/external/lib/spark-avro.jar,/usr/lib/hudi/hudi-spark-bundle.jar,/usr/lib/hudi/hudi-utilities-bundle.jar
--master yarn
--deploy-mode client
--conf spark.serializer=org.apache.spark.serializer.KryoSerializer
--conf spark.sql.hive.convertMetastoreParquet=false
--class org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer /usr/lib/hudi/hudi-utilities-bundle.jar
--table-type MERGE_ON_READ
--source-ordering-field order_id
--props s3_url/hoodie-glue.properties
--source-class org.apache.hudi.utilities.sources.ParquetDFSSource
--target-base-path s3_url/v_hudi_orders
--target-table v_hudi_orders --payload-class org.apache.hudi.common.model.AWSDmsAvroPayload
--schemaprovider-class org.apache.hudi.utilities.schema.FilebasedSchemaProvider
--transformer-class org.apache.hudi.utilities.transform.SqlQueryBasedTransformer
--hoodie-conf hoodie.deltastreamer.transformer.sql="SELECT Op, dms_received_ts, col1, col2, col3, CASE WHEN a.Op = 'D' THEN true ELSE false  END as _hoodie_is_deleted  FROM  a"
--op BULK_INSERT
Stacktrace:
22/08/23 15:15:46 INFO OutputCommitCoordinator$OutputCommitCoordinatorEndpoint: OutputCommitCoordinator stopped!
22/08/23 15:15:46 INFO SparkContext: Successfully stopped SparkContext
Exception in thread "main" org.apache.hudi.exception.HoodieException: Commit<PHONE_NUMBER>1531894 failed and rolled-back !
at org.apache.hudi.utilities.deltastreamer.DeltaSync.writeToSink(DeltaSync.java:649)
at org.apache.hudi.utilities.deltastreamer.DeltaSync.syncOnce(DeltaSync.java:331)
at org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer.lambda$sync$2(HoodieDeltaStreamer.java:200)
at org.apache.hudi.common.util.Option.ifPresent(Option.java:97)
at org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer.sync(HoodieDeltaStreamer.java:198)
at org.apache.hudi.utilities.deltastreamer.HoodieDeltaStreamer.main(HoodieDeltaStreamer.java:549)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52)
at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:1000)
at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:180)
at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:203)
at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:90)
at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:1089)
at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:1098)
at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
22/08/23 15:15:46 INFO ShutdownHookManager: Shutdown hook called
Properties file
hoodie.table.name=t_hudi_able
hoodie.table.type=MERGE_ON_READ
hoodie.deltastreamer.source.dfs.root=s3_URL
hoodie.datasource.write.recordkey.field=col1 (pk)
hoodie.datasource.write.partitionpath.field=col3
hoodie.datasource.write.precombine.field=ts (DMS generated)
hoodie.datasource.hive_sync.enable=true
hoodie.datasource.hive_sync.table=t_hudi_able
hoodie.datasource.hive_sync.database=default
hoodie.datasource.write.hive_style_partitioning=true
hoodie.datasource.hive_sync.partition_fields=col3
hoodie.datasource.hive_sync.partition_extractor_class=org.apache.hudi.hive.MultiPartKeysValueExtractor
hoodie.datasource.hive_sync.use_jdbc=false
hoodie.deltastreamer.schemaprovider.source.schema.file=s3_url/source_schema.avsc
hoodie.deltastreamer.schemaprovider.target.schema.file=s3_url/target_schema.avsc
hoodie.datasource.hive_sync.mode=hms
Target schema file
{
"type": "record",
"name": "orders",
"fields": [
{
"name": "Op",
"type": "string"
},
{
"name": "ts",
"type": [ "null", "string" ]
},
{
"name": "col1",
"type": [ "null", "int" ]
},
{
"name": "col12",
"type": [ "null", "int" ]
},
{
"name": "col3",
"type": [ "null", "string" ]
},
{
"name" : "_hoodie_is_deleted",
"type": "boolean"
}
]
}
Source schema file
{
"type": "record",
"name": "orders",
"fields": [
{
"name": "Op",
"type": "string"
},
{
"name": "ts",
"type": [ "null", "string" ]
},
{
"name": "col1",
"type": [ "null", "int" ]
},
{
"name": "col12",
"type": [ "null", "int" ]
},
{
"name": "col3",
"type": [ "null", "string" ]
}
]
}

@santoshraj123 Could you upload the complete Spark driver log?  Do you see any error logs before Commit<PHONE_NUMBER>1531894 failed and rolled-back !, specifically sth like Delta Sync found errors when writing. Errors/Total= and Printing out the top 100 errors?

guess its an issue w/ bulk_insert. can you use "Insert" and let us know what you see.
also, may be, if you can avoid records w/ "hoodie_is_deleted" = true in the first commit, and ensure those are part of later batches, let's see whats the output look like.

@santoshraj123 : did you get a chance to check my previous response. let us know if you are still looking for assistance. may be we need full driver logs.

@santoshraj123 : any updates please.

@santoshraj123 : gentle ping. if you got the issue resolved, feel free to close it out.

Closing due to inactivity.


Unable to query Snowflake Account Usage from Superset

Importing dataset with Snowflake Account Usages causes multiple errors. Read more about read-only shared database named SNOWFLAKE https://docs.snowflake.com/en/sql-reference/account-usage.html

Setup new Database Connection with URL: snowflake://SUPERSET:XXXXXXXXXX@dr123456.eu-west-2.aws/snowflake?role=MY_ROLE&warehouse=MY_WAREHOUSE (please note the showflake database name)
Go to the SQL Lab and pick new Database connection, select schema account_usage and table schema access_history

Instantly you get following error:

Root cause
Likely the issue is that the where warehouse is not selected. But snowflake doesn't allow you to execute USE WAREHOUSE MY_WAREHOUSE command in SQL Lab

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please open a new Issue or a PR to address the problem.


6.1.1-preview WindowsAzure.Storage Exception "A strongly-named assembly is required"

I am on beta 8 (of aspnet 5) and I keep getting the following exception with WindowsAzure.Storage whenever I try to load the assembly.
"A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)"
Repro project: https://github.com/tparnell8/AspNetCache-AzureTableStorage/tree/master/src/AzureTableStorageCacheSample

Also rc1 too.

This issue has been resolved long ago, but missed closing it because it's not in the azure-storage-net repo. Feel free to report further issues with the storage client in azure-storage-net. Thanks!


Asset Number should be correspond Purchase Date

ref: http://dev.netforce.com/online/helpdesk-support/issues/164


As a reviewer, within the review interfaced I'd like guidance available on how much detail is required in my feedback

I think the headers ability to link to guide.otf should do this for now. I don't think there is anything more for the application platform to do at this point.


Errors running advection_1d example

I am getting errors while running the advection_1d example given in this python notebook. The version I have for tensorflow is same as the version shown in that example:
tf.__version__, tf.keras.__version__
('1.13.1', '2.2.4-tf')

The error I am getting is at the following line, just before neural network is trained with the data:
model_nn.compile(optimizer=tf.keras.optimizers.Adam(0.001 * 1), loss='mae', metrics=[tf.keras.metrics.RootMeanSquaredError()])

AttributeError: module 'tensorflow._api.v1.keras.metrics' has no attribute 'RootMeanSquaredError'

I checked the class tf.keras.metrics and it does not have any function called RootMeanSquaredError, which is the reason for error. After some search, I modified the metrics in above line throwing the error as metrics=["RootMeanSquaredError"], which helps get rid of that particular error, but I get another error on the next line as follows:
history = model_nn.fit(train_input, train_output, epochs=80, batch_size=32, verbose=1, shuffle=True)

ValueError: When running a model in eager execution, the optimizer must be an instance of tf.train.Optimizer. Received: <tensorflow.python.keras.optimizers.Adam object at 0x7f0c885da400>

The above error does not go away whether I enable the eager execution or not. I was curious how the example in that notebook ran with the exact same version of tensorflow that I am also using with Python 3.6. I would appreciate your help with this.

Thank you, @JiaweiZhuang . Changing the version of tensorflow as suggested makes it move past those two errors. However, before changing the version of tensorflow, I tried the alternate option you suggested, which although solves the issue of metrics argument, the second error I mentioned earlier still remains.

the second error I mentioned earlier still remains.

Ah, you are right. I also got AttributeError: 'Adam' object has no attribute 'apply_gradients' when using optimizer='adam' with tensorflow 1.13.1.
Maybe this is related to the migration to TF 2.0 (e.g. tensorflow/tensorflow#27386). We should probably require tensorflow==1.14.0 for now.

Thank you.


Problem running content server locally

Hi! I'm trying to run my own local content server. I've run:
$ yarn bazel run content:db

and it seems to be running:
$ docker ps
CONTAINER ID        IMAGE               COMMAND                  CREATED              STATUS              PORTS                    NAMES
d7b78c0e1fc3        postgres            "docker-entrypoint.s…"   About a minute ago   Up About a minute   <IP_ADDRESS>:5432->5432/tcp   postgres

but the content server can't connect to the database for some reason.
$ /Users/manu/git/catalyst/node_modules/.bin/bazel run content:server
INFO: Invocation ID: e9a9831f-987c-4b0e-ad0d-a57d31054306
WARNING: Download from https://mirror.bazel.build/nodejs.org/dist/v12.18.1/node-v12.18.1-darwin-x64.tar.gz failed: class com.google.devtools.build.lib.bazel.repository.downloader.UnrecoverableHttpException GET returned 404 Not Found
INFO: Analyzed target //content:server (1 packages loaded, 9 targets configured).
INFO: Found 1 target...
Target //content:server up-to-date:
  dist/bin/content/server_loader.js
  dist/bin/content/server.sh
INFO: Elapsed time: 0.425s, Critical Path: 0.03s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action
INFO: Build completed successfully, 1 total action
Failed to connect to the database. Error was Error: connect ECONNREFUSED <IP_ADDRESS>:5432
Failed to connect to the database. Error was Error: connect ECONNREFUSED <IP_ADDRESS>:5432

Any ideas what I might be doing wrong?

Additionally, what's the format of the .env file mentioned in the README?

Hey @maraoz !
So that's interesting. I just did the following and it worked:
yarn bazel run content:db
yarn bazel run content:server

Which OS are you running on?
Also, if you just want to run your own content server, it might make sense to simply check own catalyst-owner repo.


test: add some missing tests and imports

:tada: This PR is included in version 5.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove null-check from codegen

Description

Fixes #821
Checklist

[x] I have added tests that prove my fix is effective or that my feature works

[x] I have updated the CHANGELOG-PENDING file with my change

[ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

Working on fixing the inactive tests, but the fix and regression test looks good :)

Going to review a bit later when we get CI to green. Note that I looked into the example failure and it's unrelated, it was caused by the breaking changes propagating through azure-native provider, shortly fixed by https://github.com/pulumi/examples/pull/1275

@t0yv0 ready for review :)

There's lots of good things in here but it's a bit much for a single PR. I've lifted #838 and #837 out into separate PRs.
On the fix itself I'm wondering if the fix can be accomplished in SDK only without changing the codegen. That is if the null checks are left in on builder methods but the deserializer code stops calling builder methods with nulls. The null checks seem like they have their place for normal usage, perhaps we should leave them? The other reason this is attractive is that an SDK-only fix is much easier for us to roll out.

Thank you!

On the fix itself I'm wondering if the fix can be accomplished in SDK only without changing the codegen. That is if the null checks are left in on builder methods but the deserializer code stops calling builder methods with nulls. The null checks seem like they have their place for normal usage, perhaps we should leave them? The other reason this is attractive is that an SDK-only fix is much easier for us to roll out.

Yes, it should be possible, but the the converter would have to be made aware of the preview mode, adding complexity.
The fix removes complexity. The null checks were not present in the constructor based impl and they add weight to the codegen-ed code. Given the above I've concluded that romeoval is the simplest an the best solution in those circumstances.
Having said that, there is nothing stopping us with going the other way and making the converter aware of the preview mode.

@pawelprazak I don't think the problem is exclusive to preview mode.. There is this regression test that was masked by JUnit tests not running that has a similar failure pattern but another root cause entirely. In case of AWS sometimes the provider fails to send back required output data - marked required by the schema but not actually present. This is in preview=False mode. Still we need to handle that null.

@pawelprazak I don't think the problem is exclusive to preview mode.. There is this regression test that was masked by JUnit tests not running that has a similar failure pattern but another root cause entirely. In case of AWS sometimes the provider fails to send back required output data - marked required by the schema but not actually present. This is in preview=False mode. Still we need to handle that missing data gracefully.

Right! Maybe it could be as simple as adding return null; here 🤔 :

com/pulumi/serialization/internal/Converter.java:423

How about #840 ? It feels like the fix is falling at a somewhat strange place but it fixes both the broken example and the skipped test.

I've commented on the PR, TLDR: it should work fine.

@pawelprazak we ended up shipping #840 in the 0.6.0 release yesterday. Please let me know if we can close this PR or fi you think there's remaining value here I'm happy to take another look once it's rebased on main.

thank you, I'll have a look at what minor improvements can be used after rebase

Closing for now as it trips our PR tracking tools. Please feel free to reopen if helpful when rebased.


Standardization of use of sample and analysis names in all bcbio final output files.

Hi,
The final output files that we get from bcbio analysis we store in an object store and some of them we then load into diverse end user facing applications. In some of these applications end users search or select based on the file names (or actually the files that match with their analysis ID or sample name).
Some of these output files include the sample and / or the analysis (batch)ID in the file names.
For example:

BAM file names always include the sample name (e.g. DA_1083_05-ready.bam)
Joint VCF files always include the analysis ID (e.g. DA_1090-gatk-haplotype-annotated.vcf.gz)

It would be nice if a standard naming scheme could be used for all sample level or analysis level output files.
The situation could for example be improved in the output or RNAseq analysis:

The feature counts file already includes the sample name (e.g. DA_1083_05-ready.counts)
The Salmon file does not yet include the sample name but always is named quant.sf
Per sample GTF files are just called stringtie-assembly.gtf or cufflinks-assembly.gtf without use of sample names
The merged analysis GTF files is called assembled.gtf without the analsysis ID.

We could also do this in our code before pushing the files to the object store. But it might also make sense to have the sample names and analysis IDs already included in bcbio generated output file names.
Please let me know what you think. Thank you.

Thanks much for this discussion. Renaming some of the RNA-seq outputs to be more consistent with sample and project/batch naming makes a lot of sense. @roryk, what do you think about adding sample identifiers to these outputs? There is always a concern with breaking downstream scripts that expect certain names but normalizing these some would help a lot to avoid confusion.

Thanks, sorry for not responding. I agree it stinks the way it is. Some downstream tools need the files named in a certain way and some don't. Standardizing this would be good, but is likely to open up a host of other problems. I think I'm down for leaving it as is, despite the fact it is gross.


Update error message tests

Which issue does this PR close?

Closes #.
Rationale for this change

The latest version of reqwest updates some error messages that cause the tests to fail
What changes are included in this PR?

Are there any user-facing changes?

I'm going to merge this once CI passes as it is an uncontroversial test only change, and will make CI green again


net/http: Request.WithContext is slow

What version of Go are you using (go version)?
go version go1.11.2 linux/amd64
Does this issue reproduce with the latest release?
yes
What did you do?
I write a http router package: https://github.com/go101/tinyrouter
The benchmark result shows it spends about 3x times (24136 ns / 7285 ns/op) to match a pattern as HttpRouter.
After some profiling, I found the slowness is mainly caused by one line in my package:
req = req.WithContext(context.WithValue(req.Context(), paramsKeyType{}, Params{path, tokens}))

This line spends about 11000 ns.  In the 11000 ns, 8000ns is spent on the  req.WithContext() call.
If my package doesn't return URL path params through context (as HttpRouter does), then it only 30% slower than HttpRouter.
Considering that sometimes there may be more values to be appended into the context, it will spend more time. So I think we really need an alternative faster way to append key-values to http request context.

I counted the number of native world copied in WithContext function. The number is about 43.

.WithContext returns a full copy of the request + URL, so it's expected to be heavy.

I don't see much that can be done here. We are just copying the request, context and the url of the original request.
Any optimization will deviate from the original behavior, for eg. like just updating the context to the same request. And it seems that is exactly what you are doing too. You are re-assigning the new request to the old request.

@bradfitz's http client v2 addresses this problem: https://github.com/bradfitz/exp-httpclient/blob/master/problems.md#context-support-is-oddly-bolted-on

That's what I said. You cannot optimize this further without breaking original behavior. For v2, we can break behavior and possibly optimize this. Perhaps you want to add a note for optimizing context behavior in https://github.com/golang/go/issues/5465 ?

I'm going to close this as unfortunate for now. We can address this in a future rewrite of the client package.
For now, if you need to make Requests with Contexts cheaply, you can have a global variable holding an http.Request zero value and then use its WithContext to make your new requests. For instance, if you wanted to make a version of net/http.NewRequest that took a context, users today can write:
var zeroRequest http.Request

func NewRequestContext(ctx context.Context, method, url string, body io.Reader) (*Request, error) {
	u, err := parseURL(url) // Just url.Parse (url is shadowed for godoc).
	if err != nil {
		return nil, err
	}
...
	req := zeroRequest.WithContext(ctx)
        req.URL = u
        req.Method = method
        ...
}

And that's pretty efficient. (no deep cloning of an existing URL)


Fix link to the create an issue page for the No response to feedback

Signed-off-by: Thomas Spear<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind user-interface

/kind content

/kind translation

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area blog

/area documentation

/area videos

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: tspearconquest
To complete the pull request process, please assign kris-nova after the PR has been reviewed.
You can assign the PR to them by writing /assign @kris-nova in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Another issue. Apologies.


git pull returns Success when already has all changes

Describe the bug
When pulling from a git repository it outputs the Success state in situations where it should output No Changes
debug output:
[lima] >>> sh -c 'cd /home/fimdomeio.linux/src/neovim && git pull'
[lima] Already up to date.

To Reproduce
pull from a repo.
I'm running  this operation:
git.repo(
    name="pull from neovim repo",
    src="https://github.com/neovim/neovim",
    dest="/home/fimdomeio.linux/src/neovim",
)

operating system is a Ubuntu Virtual Machine (Ubuntu 23.04)
Expected behavior
I expect "No changes" as a Status
Meta
pyinfra --support
  System: Darwin
      Platform: macOS-13.4.1-arm64-arm-64bit
      Release: 22.5.0
      Machine: arm64
    pyinfra: v2.7
    Executable: /Users/fimdomeio/.local/bin/pyinfra
    Python: 3.11.4 (CPython, Clang 14.0.3 (clang-14<IP_ADDRESS>.1))

installed with pipx

The “success” bit is determined as “did run any commands”, in the case of git it the “git pull” command. I think this is correct (it did run, it did succeed), pyinfra is thinking on the command level rather than git itself.
We could, I think, use git fetch to pre-check for changes and only pull if so which would resolve this, though I’m not sure in reality if this is a problem?


fluent-plugin-systemd to 0.0.8 & cleanup libc6-dev

Diff: https://github.com/timstclair/kubernetes/commit/e0b766b63b4ebafb3df8acd2cbc4d36abfe81b1e
Changes:

The fluent-plugin-systemd regression was fixed in 0.0.8 (https://github.com/reevoo/fluent-plugin-systemd/issues/32)
libc-dev is an alias for libc6-dev, which works on install but not purge for some reason, so a couple build dependencies were being left behind. Changing to libc6-dev solves this.
All other gem & package changes are just updates since the last image was built.

/cc @piosz

This change is

/approve
/lgtm

@timstclair Thanks a lot!

Pushed gcr.io/google-containers/fluentd-gcp:2.0.2

cc @igorpeshansky


dashboardUrl not set in step outputs?

I just enabled recording on Cypress dashboard for my project, but am having trouble printing the dashboardUrl.
It prints at the end of a run (in the Cypress step itself), but when I try to print it in another step it's blank
Cypress step:
  (Run Finished)

       Spec                                              Tests  Passing  Failing  Pending  Skipped
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  smoke.test.ts                            00:14        3        3        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        00:14        3        3        -        -        -

───────────────────────────────────────────────────────────────────────────────────────────────────────

  Recorded Run: https://dashboard.cypress.io/projects/xxx/runs/7

Print step:
Cypress finished with: success
See results at

My configuration
name: Deploy
on:
  pull_request:
    types: [assigned, opened, synchronize, reopened]

jobs:
  build-deploy:
    ...
  smoke-test:
    needs: build-deploy
    runs-on: ubuntu-latest
    name: Smoke test
    timeout-minutes: 5
    steps:
      - name: Checkout
        uses: actions/checkout@v2
      - name: Cypress run
        uses: cypress-io/github-action@v2
        id: cypress
        continue-on-error: true
        with:
          command-prefix: yarn dlx # need this bc using yarn pnp w/o node_modules
          install-command: yarn install --immutable --immutable-cache
          build: yarn build-custom
          headless: true
          config: baseUrl=https://env.com/
          spec: cypress/integration/smoke.test.ts
          record: true
        env:
          CYPRESS_PROJECT_ID: xxx
          CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      - name: Print Dashboard URL
        run: |
          echo Cypress finished with: ${{ steps.cypress.outcome }}
          echo See results at ${{ steps.cypress.outputs.dashboardUrl }}

Update: I also tried echo ${{ toJSON(steps.cypress.outputs) }} in my step and it just prints an empty object {}
Update 2: added missing configuration for command-prefix and custom install

Hmm +1
I have the same issue when a command-prefix parameter passed
      - name: Cypress run
        id: cypress
        uses: cypress-io/github-action@v2
        continue-on-error: true
        with:
          env: fileConfig=development
          install: false
          working-directory: e2e
          record: true
          wait-on: yarn e2e:wait
          command-prefix: dotenv-flow -p ../ --
        env:
          CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Hmm +1 I have the same issue when a command-prefix parameter passed

Same! Realized i was missing my command-prefix in configuration example so i added it.

Same here ➕ 👍

@jazanne @lmeynberg what is your use-case for this?
Based on the code from #166 it's working as expected - at the end of a run via onTestsFinished (line).

i expect this step to print a link to the dashboard
- name: Print Dashboard URL
        run: |
          echo Cypress finished with: ${{ steps.cypress.outcome }}
          echo See results at ${{ steps.cypress.outputs.dashboardUrl }}

@jazanne that's considered a separate step so the output isn't going to be available there. Have you seen the dashboard link that comes with the Workflow summary #566?

@admah not sure i understand, typically outputs are available in following steps of the same job
btw, i copied this original snippet from docs, where it seems to indicate that this should be allowed
https://github.com/cypress-io/github-action#outputs

@jazanne this does look like a bug. We'll have to look into it a bit more.

Hi @admah, is there a chance to start previous/next versions of action or it's totally surprisingly new from GH itself?

@dzzk yes. Here are the instructions for specifying the version: https://github.com/cypress-io/github-action#explicit-version

Bump! 😄

@far11ven

Was it fixed somehow in some newer versions?

It seems to be working fine in cypress-io/github-action@v5. Check out job<PHONE_NUMBER> which shows:

This is a log of running the example workflow .github/workflows/example-recording.yml.
BTW: @admah unassigned himself from this issue. He is no longer a member of cypress-io.
Are you having problems with this?
Also it would be good to hear if @jazanne also still considers this to be an issue with the current @v5 version.

@far11ven
You can also try this out for yourself if you have a fork of this repository. Follow the instructions in

example-recording.yml
examples/recording

@MikeMcC399 Thanks for the quick response, I'm using v5.5.0

@far11ven
Are you setting the record  parameter of cypress-io/github-action to true or are you recording by hand?
Could you expand the arrow in the log to the left of "Run<EMAIL_ADDRESS>In the example, it looks like this:

At the end of the step log "Cypress tests" it logs
"Recorded Run: https://cloud.cypress.io/projects/3tb7jn/runs/2287"
Please check the step where you are calling<EMAIL_ADDRESS>to make sure that you are also seeing "Recorded Run:" logged for your project.
If it is not logged then the step "Print Cypress Cloud URL" will not be able to pick anything up because nothing has been saved.

Thanks for hinting to the solution @MikeMcC399 , which was not obvious at glance when reading brief documentation of this action.
Previous version failed because we were supplying our custom command input which was the culprit of not registering the dashboardUrl and leading to a blank output:
- name: Cypress run
  uses: cypress-io/github-action@v5
  continue-on-error: true
  with:
    command: npm run cy:run:ci -- --parallel --record --env CI=true,url=${{ inputs.url }},market=${{ inputs.market }},appMode=${{ inputs.appMode }},viewport=${{ inputs.viewport }}
  env:
    CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_CLOUD_RECORD_KEY }}

The new version that worked for me and my team:
- name: Cypress run
  uses: cypress-io/github-action@v5
  continue-on-error: true
  with:
    parallel: true
    record: true
    env: ${{ env.CY_ENV }}
  env:
    CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_CLOUD_RECORD_KEY }}

What is NOT OBVIOUS in the docs (at least to me and 2 other devs trying to setup the workflow) is that the action by default executes cypress run command. So we were ought to believe we should pass the custom script from package.json as the command. Allthough it worked like a charm, but it failed to set dashboardUrl. What I believe the issue behind with a custom command is that when passing --record as flag to your command, is not the same as setting the input via record: true.
Do you think this is a bug or intentional?

@Erenndriel

What is NOT OBVIOUS in the docs (at least to me and 2 other devs trying to setup the workflow) is that the action by default executes cypress run command. So we were ought to believe we should pass the custom script from package.json as the command. Allthough it worked like a charm, but it failed to set dashboardUrl. What I believe the issue behind with a custom command is that when passing --record as flag to your command, is not the same as setting the input via record: true.
Do you think this is a bug or intentional?

Many thanks for your feedback! It's good that the hints here led you to finding a solution!
There are some gaps in the documentation concerning:

Customer test command
Outputs

If you use the action's parameter command: you by-pass some of the functionality of the action. For instance if you look at the log of running example-custom-command.yml in job<PHONE_NUMBER> you will see that there is no summary produced. You can check other action logs which don't use the command: parameter and you'll find that they each have a summary at the bottom of the log.
I will submit a documentation PR to clarify this as I see it as a documentation bug. It could be an enhancement request to set the dashboardUrl if --record is used in a command line passed through the parameter command:. Since the original issue posted here uses the record: parameter and does not use the command: parameter then any further follow-up should go into a new issue.

Appreciate you're reply @MikeMcC399 !
I wholeheartedly agree you that there are gaps in that regard and that a PR to improve such docs would be a time saver for many others who'd stumble upon this inconsistent behavior.
That being said, the custom command can actually be any other command in package.json , say a custom NodeJS script that runs numerous process, one of them being cypress itself. With that in consideration, how can one consider --record flag is the flag for cypress or for another thing that the developers intended to?
E.g.:

In my package.json assume I have myScript: "node scripts/generateFromTemplate.js .
Assume I will run this from my CLI: yarn myScript --record.
The --record is parsed from the script and applied something completely different, not related to cypresss ---record flag.
If we were to grab (grep) the --record flag from the command: npm run myScript --record, we are to assume/believe that the developer intended to set Cypress' --record flag, which in this is not.

I don't think that it'd be the right direction to assume that --record is meant for Cypress when passed to command input.

@far11ven
Are you setting the record parameter of cypress-io/github-action to true or are you recording by hand? Could you expand the arrow in the log to the left of "Run<EMAIL_ADDRESS>In the example, it looks like this:

At the end of the step log "Cypress tests" it logs
"Recorded Run: https://cloud.cypress.io/projects/3tb7jn/runs/2287"
Please check the step where you are calling<EMAIL_ADDRESS>to make sure that you are also seeing "Recorded Run:" logged for your project.
If it is not logged then the step "Print Cypress Cloud URL" will not be able to pick anything up because nothing has been saved.

@MikeMcC399  see the recorded run log, but no dashboard url:

and following is my workflow step:

@far11ven
If you are using command: , then the record: parameter is not used and there is no dashboardUrl saved.

At the end of the step log "Cypress tests" it logs
"Recorded Run: https://cloud.cypress.io/projects/3tb7jn/runs/2287"
Please check the step where you are calling<EMAIL_ADDRESS>to make sure that you are also seeing "Recorded Run:" logged for your project.
If it is not logged then the step "Print Cypress Cloud URL" will not be able to pick anything up because nothing has been saved.

I apologise about the above troubleshooting steps, which are incorrect! The Recorded Run line is output by Cypress, not by the cypress-io/github-action steps.
If you want to follow exactly what happens in your workflow, then add
    env:
      DEBUG: '@cypress/github-action'

to get logging output. If the action is carrying out the recording and remembering the dashboardUrl, you will see the following at the end of the debug logs:
@cypress/github-action Cypress tests: 0 failed
@cypress/github-action Dashboard url https://cloud.cypress.io/projects/***/runs/169
@cypress/github-action all done, exiting

@Erenndriel

I don't think that it'd be the right direction to assume that --record is meant for Cypress when passed to command input.

You are right. It would not be possible to catch all cases, so it is not a good candidate at all for an enhancement request. Thanks again for your inputs and insight!

I have made a suggestion to update the README documentation in PR #846.
Whilst the pull request is still in review mode you can read the suggestion under the link Outputs.

@jazanne
Could you let us know if this is still an issue for you? We found one root cause, but I don't know if it covers your case.

@MikeMcC399 yep the issue i'm seeing seems in line with the new docs you added https://github.com/cypress-io/github-action/pull/846 - url not set using custom command.
thanks for looking into this

@jazanne
It's good to hear that we finally worked out what the problem is! Thanks for closing the loop!
Would you like to close your issue now?

Would still love to see this changed/supported in the future.

I'm guessing that this would need to be an enhancement to Cypress in order to expose / export the Cypress Cloud URL.


Use plugin name in UI when label is not set

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2043
Originally created by @DouweM on 2020-05-19 15:33:15

View 3 previous comments from the original issue on GitLab


Magic Numbers

There are a lot of magic numbers scattered throughout the drive, arm, and science code.
Things like

max speeds
lerping constants
delay intervals
peripheral settings
motor configurations,
and so on.

It may be beneficial to move all of these to a single settings.hpp file. That way to configure each system, we only have to go through a single file, rather than hunt for the variables across many variables.

settings branch has update with the drive constants into a single settings.hpp file.


The promt component not visible on version 1.0.16

Bug Description
The Prompt component is not visible in the current version. It was present in the previous version. I'm wondering if this component was removed intentionally. Due to its absence, the older flows that I developed are not working as expected.
Reproduction
The Prompt component is not visible in the current version. It was present in the previous version.
Expected behavior
The Prompt component should be visible, as it was in the previous version.
Who can help?
No response
Operating System
macos sonoma 14.0
Langflow Version
1.0.16
Python Version
3.10
Screenshot
This is version 1.0.15

Flow File
No response

@cankanatt
I just tested it, and it's working. Try updating again; if you're using the main branch, do a git pull. If you're using pip, run python -m pip install langflow -U.


Add error handling for weird characters in filenames

Currently DEE fails with weird characters such as ñ.

fixed in 2.1.0.


feat(revit): more params

Adding more parameters when sending to Speckle:

roomId: for family instances (https://speckle.community/t/include-room-property-on-familyinstance-conversion/6741/)
roomFromId: for doors and windows
roomToId: for doors and windows
worksetId: for anything that has it
all the parameters type ElementId as strings (which were previously excluded) https://speckle.community/t/model-parameters-strategy/6158/13
all of the parameters  with value null (which were previously excluded)

@connorivy would appreciate it if you could quickly benchmark if adding these extra parameters might affect send performance.

Potential issue: writing these params in the model might cause issues, eg some integers with no value, might send as 0, and throw erros on receive. Potential solutions:

add hasValue prop
use nullables

Closing this and opening new ones later to get around conflicts


Istio route rules not respected for traffic from outside Kubernetes cluster

@kalantar commented on Wed Jun 21 2017
I created a service that selects among 2 deployments (different versions).
I created two istio route-rules.
The first defaults all traffic to v1.
The second sends requests that have a particular header to v2.
I then deployed the sleep sample so that I could test these rules from inside the cluster. I found that both rules worked as expected.
I then created an ingress so that I could initiate requests from outside the cluster.
When I tested it by sending requests from outside the cluster, I found that the default rule was applied to every request, including those that match the second rule.
Note that I am doing this in a non default namespace. However, this does not seem to be the issue, see also: https://groups.google.com/forum/#!topic/istio-users/yQEogcx2hJM
Here are the rules:
$ more *rule*
::::::::::::::
default-route-rule.yml
::::::::::::::
type: route-rule
name: default-route
namespace: user-kalantar
spec:
  destination: echo.user-kalantar.svc.cluster.local
  precedence: 1
  route:
  - tags:
      version: one
    weight: 100
::::::::::::::
user-route-rule.yml
::::::::::::::
type: route-rule
name: echo-user-rule
namespace: user-kalantar
spec:
  destination: echo.user-kalantar.svc.cluster.local
  precedence: 2
  match:
    httpHeaders:
      x-user:
        exact: test
  route:
  - tags:
      version: two

The ingress is:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: echo-ingress
  namespace: user-kalantar
  annotations:
    kubernetes.io/ingress.class: istio
spec:
  backend:
    serviceName: echo
    servicePort: 80

@ijsnellf commented on Wed Jun 21 2017
@kyessenov, could you take a look at this? You are better acquainted with ingress route rules and their limitations.

@frankbu commented on Wed Jun 21 2017
To reproduce:
$ kubectl apply -f <(istioctl kube-inject -f samples/apps/helloworld/helloworld.yaml)

$ cat <<EOF | istioctl create
type: route-rule
name: hello-default
spec:
  destination: helloworld.default.svc.cluster.local
  route:
  - tags:
      version: v1
EOF

$ cat <<EOF | istioctl create
type: route-rule
name: hello-canary
spec:
  destination: helloworld.default.svc.cluster.local
  precedence: 2
  match:
    httpHeaders:
      foo:
        exact: bar
  route:
  - tags:
      version: v2
EOF

$ export HELLOWORLD_URL=$(kubectl get po -l istio=ingress -o 'jsonpath={.items[0].status.hostIP}'):$(kubectl get svc istio-ingress -o 'jsonpath={.spec.ports[0].nodePort}')

$ curl -H "foo: bar" http://$HELLOWORLD_URL/hello # always returns v1
Hello version: v1, instance: helloworld-v1-1286076397-2nrdg

There is a limitation on combining match expressions coming route rules and ingress rules but this might not be it. I'll try to run the config gen logic on the input once I get time. Thanks!

is it due to the difference in precedence?

i have the following route rule and it seems to work externally:
type: route-rule
name: maintenance-info-default
spec:
destination: maintenance-info.red.svc.cluster.local
precedence: 1
rewrite:
uri: /
route:

tags:
version: red
weight: 50
tags:
version: black
weight: 50

Haven't gotten to the bottom of it yet, but I think it's the match part that's not working

@frankbu yes it does appear to be an issue with the matching. i created a new route rule for a different microservice:
type: route-rule
name: common-default
spec:
destination: common.red.svc.cluster.local
precedence: 1
match:
httpHeaders:
uri:
prefix: "/common/"
rewrite:
uri: /
route:

tags:
version: red
weight: 0
tags:
version: black
weight: 100

and what appears to happen is the following:
http:///common/api/files returns a 404
http:///api/files returns a 200 with the expected files
/common and /api are defined in the ingress to point to the same service

fixed by #897

I am running istio 0.4.0 and we are noticing this exact behavior. Though some of the route rules will work for a while(until another update is made) and then they wont work anymore and others will work. We are only noticing this issue with ingress controller. sidecars do not appear to have this issue.
example ingress
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    kubernetes.io/ingress.class: istio
  name: app1-ingress
  namespace: ns1
spec:
  rules:
  - host: example.com
    http:
      paths:
      - backend:
          serviceName: app1
          servicePort: 80
        path: /app1/.*

Example route rule
apiVersion: config.istio.io/v1alpha2
kind: RouteRule
metadata:
  name: app1
  namespace: ns1
spec:
  destination:
    name: app1
  match:
    request:
      headers:
        uri:
          prefix: /app1/
  rewrite:
    uri: /

response from app1 http://example.com/app1/info .. we should have gotten the infor response not 404
{
"timestamp":<PHONE_NUMBER>726,
"status": 404,
"error": "Not Found",
"message": "No message available",
"path": "/app1/info"
}

Ingress /routes response
{
	"version_info": "hash_5652f7f64d6507e2",
	"route_config_name": "80",
	"cluster_name": "rds",
	"route_table_dump": {
		"name": "80",
		"virtual_hosts": [{
			"name": "example.com",
			"domains": ["example.com", "example.com:80"],
			"routes": [ {
				"match": {
					"prefix": "/app1/"
				},
				"route": {
					"cluster": "out.app1.ns1.svc.cluster.local|http",
					"timeout": "0s"
				},
				"metadata": {
					"filter_metadata": {
						"envoy.router": {
							"destination.service": "app1.ns1.svc.cluster.local",
							"mixer_check": "on",
							"mixer_report": "on",
							"mixer_forward": "on"
						}
					}
				},
				"decorator": {
					"operation": "default-route"
				}
			}, {
				"match": {
					"prefix": "/app1/"
				},
				"route": {
					"cluster": "out.app1.ns1.svc.cluster.local|http",
					"prefix_rewrite": "/",
					"timeout": "0s"
				},
				"metadata": {
					"filter_metadata": {
						"envoy.router": {
							"destination.service": "app1.ns1.svc.cluster.local",
							"mixer_check": "on",
							"mixer_report": "on",
							"mixer_forward": "on"
						}
					}
				},
				"decorator": {
					"operation": "app1"
				}
			}]
		}]
	}
}

@nmnellis Your problem sounds like a new issue. This one was a simple bug in the the ingress controller where route rule match was always failing at ingress. I'd suggest opening a new issue, since this one is closed and won't get anybody's attention.


[$250] Members - Deleted members in offline mode return after re-logging

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Issue found when executing PR https://github.com/Expensify/App/pull/40758
Action Performed:
Prerequisites:
Create workspace, create a room with 3 members, create a group conversation with 3 members

Open https://staging.new.expensify.com/
Login to the HT account
Navigate to the created group
Click on the header > Members
Go offline
Delete any member
Navigate to the created room
Click on the header > Members
Delete any member
Refresh the page
Switch on the internet
Verify group members and rooms
Re-login to your account
Verify group members and rooms

Expected Result:
Deleted offline members must be deleted irrevocably
Actual Result:
Deleted members in offline mode return after re-logging
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/01a42665-66b6-47fb-af64-8698bb06c9f6
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013de8ecf9253d513b
Upwork Job ID:<PHONE_NUMBER>580089344
Last Price Increase: 2024-05-01

@greg-schroeder  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Are staging creds available to fix it?

Happy to jump into staging, fix it and then apply to the Upwork job with a PR ready

@oscarguinane Please go through our contributing guidelines to familiarize yourself with the process.

Ok

On May 2, 2024, at 5:38 AM, Jayesh Mangwani @.***> wrote:
@oscarguinane https://github.com/oscarguinane Please go through our contributing guidelines https://github.com/Expensify/App/blob/db86427b3836a212b6fd456620907ff55baa00da/contributingGuides/CONTRIBUTING.md to familiarize yourself with the process.
—
Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/40898#issuecomment-2090025519, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCFGBWHBBE4HAV3QNX3QA3ZAICR3AVCNFSM6AAAAABGXASGDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGAZDKNJRHE.
You are receiving this because you were mentioned.

(got it - it's in the guidelines)

Ok I'm setup - requested Slack access

Waiting for proposals

Issue not reproducible during KI retests. (First week)

Closing as not reproducible, but please reopen if you disagree


GetRealmFromTargetUrl in TokenHelper.cs should not assume GUID for Realm

On-premises it is possible to set Realm to any string using Set-SPAuthenticationRealm cmdlet. GetRealmFromTargetUrl in TokenHelper.cs from Visual Studio templates does on the other hand do a Guid.TryParse (as well as assuming a length of 36) which effectively means that a GUID is required.
Either it should be considered a bug that Set-SPAuthenticationRealm allows anything but a GUID to be set or TokenHelper.cs should be considered flawed for on-prem installations. Personally I would prefer TokenHelper.cs to be updated as on-prem it is really nice to set Realm to something readable that indicates its origin (consider troubleshooting in multi farm setups using shared hosting for provider hosted Apps).
Resolving the issue could be done by simply changing this part of GetRealmFromTargetUrl:
string targetRealm = bearerResponseHeader.Substring(realmIndex, 36);
Guid realmGuid;
if (Guid.TryParse(targetRealm, out realmGuid))
{
return targetRealm;
}
into something like this:
string[] targetRealm = bearerResponseHeader.Split('"');
return targetRealm[1];

Hej Markus!
That's a valid point you're making. However, we decided to use the default TokenHelper.cs in the PnP Core library, e.g. the one that Visual Studio gives us. Basically very TokenHelper.cs out there has this issue. It helps if you create an entry on uservoice: https://officespdev.uservoice.com/, while we will also bring this to the attention of the appropriate people within Microsoft.
Tack!
/Erwin

Hi Markus,
like Erwin communicated, we will definitely loop this also through using internal rounds, but at the same time it would be great if you'd crate a user voice entry for this, for tracking purposes. That means that it will be officially tracked in our MS internal meetings.
Thanks also from my behalf. This is really good feedback with clear suggestion on how to get it resolved. I'll close this now from the PnP tracking, since we cannot really fix this "oob" component, but we will certainly follow up on this one.


Add configuration option to not use Get as the mechanism to execute the API calls

We have written an alternative API execution mechanism/invoker.    CreateAPI currently automatically includes Get in the Package.swift even when paths.imports specifies something different.
This could be done with one of these options:

removeGet or excludeGet: boolean
if the paths.imports does not include Get then ignore it
or create a pathInvoker: string, this would be the invoker, it should default to Get.

Duplicate of #84


Improved Screencast mode

While fixing #68849, we began discussing how we could further improve the screencast mode. Some of the things we want to add include:

Displaying counters for repeat key presses
Remove spaces between letters/numbers/symbols
Have letters respect the case they were typed in
More settings for screencast mode

I'd love to take this up, since I've already been working on screencast mode.

Will close this as out of scope, thanks for the ideas any way.


Redux-Saga has updated to 0.14.x

Needs to support a bumped version of redux-saga

Version 1.1.2 just published should do this.

thanks!


improve and add more suggestions

Few more translations, motly words I had trouble guessing while practicing on TypeRacer.
The translation for Benoit didn't work for me (produced "ben-wa"). My main.json doesn't have a translation for "Benoit".
I removed a few astrixes that didn't seem to be required. I hope that doesn't make more word boundary conflicts, but right now I see value in avoiding the asterisk key, at least when it doesn't add strokes.

Oh, man. I meant to write a script to check the translations against main.json and I never got around to it. I guess I need to start writing this stuff down. Weird having two coding projects on my plate that people actually care about (this and the game dev collaboration I'm doing).
Yeah, I'm not a big fan of unnecessary asterisks either.


Can we see the weights of the trained neural network?

@alexjc Alex, is there a way to see the weights of the trained model? Especially for smaller models (1 hidden layer) i'd like to plot a histogram of the weights to see what features are contributing the most.
thanks!

See #116.

Thanks!

Closed by 42397ef.


[Feature Request] zip raw report

original: https://github.com/cenfun/monocart-reporter/issues/149
The idea is
{
  reports: [
    ["raw", {
      zip: true
    }]
  ]
}

Hi @cenfun, I'm not sure that would help much. The original request was if the code coverage could be consolidated at the end of a run. So that instead of many raw code coverage files we could have one or a few. Would that be possible?
Zipping wouldn't help in my scenario, note that I already manually zip the final output from monocart reporter.  The place where I think compressing would help is on cenfun/monocart-reporter/issues/147, which if done would actually also include what you are proposing since it would zip the entire output from monocart-reporter (including raw code coverage files of course).

The original request was if the code coverage could be consolidated at the end of a run. So that instead of many raw code coverage files we could have one or a few. Would that be possible?

Note that if this is not possible, then it's ok, I have no idea how complex that would potentially be...

Thanks for the clarification.
I have implemented the capability of zip in this commit. Perhaps it is possible to implement merge, Let me do some research:
{
  reports: [
    ["raw", {
      merge: true,
      zip: true
    }]
  ]
}

The file is too large to upload here to GitHub so please download from this OneDrive link. This is a compressed file of the output of monocart-reporter for the first shard of one of my projects. It contains many raw code coverage files.
These are the second and third shard outputs (these ones don't have any code coverage on them, all of the code coverage is on the first shard which executes google chrome whilst the second shard is running firefox tests and the third is running webkit):
monocart-reporter-2.tar.gz
monocart-reporter-3.tar.gz
And this contains the merged report for the above:
playwright-test-reporters.tar.gz
In the merged report you can see that the code coverage from all the raw reports should end up being 89.55%. Is this enough? Do you need anything else?

Please try version 2.11.0

original size:  198M
after zip : 27M
after merge:  14M
after merge + zip:  2.6M

I can confirm your results and everything is working as expected. I tested both the merge and the zip options.
Is merge default value enabled or disabled? If it's not set to enable by default, is there any reason for it?
Also, I think perhaps you need to add a note on the monocart-reporter README under the Merge shard reports section to say that if the zip option is used then the user needs to extract the zip first before doing the merge or else it won't work. Perhaps you could add it near the existing note:

Note: The coverage reports will be merged automatically if we specify the raw report in coverage options:

Alternatively, you could add support for zipped code coverage reports to the merge API/CLI so that if it finds a zipped code coverage file it will unzip and just work.

Thanks for the comfirm that the options are working well.
One step, one issue.
First, we need to make monocart-coverage-reports works as expected, then next step, I will update monocart-reporter to apply the new options.
In fact, we should not manually unzip the raw.zip file, Alternatively, it should support loading zip file directly.

One step, one issue.

I agree, I'm closing this issue then. Would you like me to open a new issue for the zip support on the merge API/CLI or will you take care of that if you think it should be done?
Did you notice my question:

Is merge default value enabled or disabled? If it's not set to enable by default, is there any reason for it?

Would you like me to open a new issue for the zip support on the merge API/CLI or will you take care of that if you think it should be done?

I will open a new issue, thanks.

Is merge default value enabled or disabled? If it's not set to enable by default, is there any reason for it?

the merge option defaults to false (disabled), considering these reasons

Most of the time, raw files may not be numerous or large, so there is no need to merge or even compress them.
Merging coverage is a lossy operation and no longer the original raw data.
Merging coverage consumes some system resources, so we leave it to the user to decide.

Sounds good, thank  you for this work @cenfun . Feel free to close this issue whenever you want.


Computing the weights

Hi Damcy,
thanks a lot for the code. It helped me a lot.
I have a small comment. In the function sample from the file rank_based.py, you compute the weights as:
# w = (N * P(i)) ^ (-beta) / max w
w = np.power(np.array(alpha_pow) * partition_max, -beta)
where N is represented by the variable partition_max, defined as:
partition_max = dist_index * self.partition_num
My question is, shouldn't N be equal to the memory size? or, in this case, to the partition size? Something like:
 partition_size = math.floor(self.size / self.partition_num)
partition_max = dist_index * partition_size

@camigord yes, I make a mistake here.
partition_size is diff to partition_num. According to your suggestion, the code has been rewritten. Thanks for your issue.

Hey, thanks for replying.
I saw you changed the code, but be careful because n_partitions is not defined in that function. You could use self.partition_num instead.

ok. Fixed. Thx.
If this part still has bugs, welcome make a pull request :)


Tags on Release Commits

Would it be doable for you to add a tag to commits that you're publishing/have published to crates.io? It would make packaging for nixpkgs a bit cleaner.

maybe, if i can remember? how does it make it cleaner?

here's an example of the kind of code that you see in a nix package, fetching the source code of the thing being packaged:
src = fetchFromGitHub {
  owner = "fennewald";
  repo = "nu_plugin_net";
  rev = "refs/tags/${version}";
  hash = "sha256-GOF2CSlsjI8PAmIxj/+mR01X5XMviEM8gj7ZYTbeX7I=";
};

if there's no tag to target the fetch of of you instead would have, e.g.,
rev = c41f98632a538cad38ed0dd518340fb8eb28274e

which works, but is significantly uglier and also significantly less readable as to why that git commit in particular was picked.

make sense. let's see if i remember next time. maybe i should just leave this open until then as a reminder?

It should be pretty easy to go back and tag the commits that you made releases? I don't know if github has something inbuilt to do it, but if you grab the commit id you can tag that commit from the command line with e.g.
git tag 0.6 c41f98632a538cad38ed0dd518340fb8eb28274e

and then push that tag to github with git push origin --tags.

i remembered, yay me!


Increased asyncify data end to match stack size for built wasm modules

Toolchain is building wasm modules with the following stack size:
ENV ASYNCIFY_STACK_SIZE=24576
But we don't take advantage of that in our AsyncifyWasmInstance.
Ideally, this should be dynamic, for that I created an issue here: https://github.com/polywrap/javascript-client/issues/49
This fix should prevent any ASYNCIFY_STACK_SIZE errors in the mean time.

Great find @nerfZael! We should try and find a way to extract this from the wasm binary. Will add some thoughts to the issue you created 👏

Great find @nerfZael! We should try and find a way to extract this from the wasm binary. Will add some thoughts to the issue you created clap

It was actually @namesty . Really amazing to get this working :)


hw.device-type: Correct NanoPi R2C device contract

The device does not have any WiFi chipset so let's correct that
Change-type: patch
Signed-off-by: Florin Sarbu<EMAIL_ADDRESS>

@balena-ci I self-certify!


Unix time in millisecconds

Is there only support for secconds?
Need this:
https://momentjs.com/docs/#/parsing/unix-timestamp-milliseconds/

The same question was asked recently. https://github.com/headzoo/react-moment/issues/57
It seems easy enough to convert seconds to milliseconds. So I'm not sure the library really needs millisecond support.

I've checked the code and figured out using 'utc' instead of 'unix' param works fine with milliseconds.


About the 'ignore' class in pascal voc

in the file 'pascal_voc_loader.py'.
lbl[lbl==255] = 0, if I'm not wrong, it means that treat the 'ignore' class as background. Is this really right?

It doesn't make much difference. I've tried using it as an ignore class in the loss function.


Option to use LinkedHashMap instead of HashMap to preserve additionalProperties keys order

It's quite annoying that additionalProperties values lose their initial array order when json is parsed.
Since I use the same schema classes to generate json after tweaking, I can't sort them too.
I guess it will be easy to add an option to generate LinkedHashMap instead of HashMap for additionalProperties field.

This is an easy change, and I'm not even sure it should be configurable- I think it should be the new default behavior:
https://github.com/jdimeo/jsonschema2pojo/commit/de79bf0f52bd48b5b5529173d139a37c6a29f70f

This is an easy change, and I'm not even sure it should be configurable- I think it should be the new default behavior

I think the same way.
Do you mind creating a PR for your change?

OK I did: https://github.com/joelittlejohn/jsonschema2pojo/pull/1397/

Closed by #1397.


react-tinacms-inline 0.28.0 breaks image previews in edit mode

Description
I have a nextjs app using tinacms to edit cms content.
I've set up a strapi back-end and am adapting the steps found at https://tinacms.org/guides/nextjs/tina-with-strapi/overview/.
Updating to the latest (0.28.0) version of tinacms, react-tinacms-editor, react-tinacms-editor and react-tinacms-strapi causes an error to appear when editing the blog in the guide:

Steps to reproduce
You can refer to the associated demo repo as a reproduction: https://github.com/mittonface/tina-strapi-blog
(assuming a configured strapi backend as per the guide)
Update all tinacms related packages to 0.28.0 and run the app.
Go to edit a blog post, and while logging in to strapi back-end...
The error should appear.
Downgrading react-tinacms-inline to 0.27.3 makes the error message stop appearing.
Expected result
Should work with latest version no errors :)
Actual result
Error appears.

Hey @martaver, this pr should fix that issue. It should be out in next week's release!

I think that was released this week in 0.29

Closing for now, reopen if the issue persists in the latest release.


Port over websockets remote

Mostly done...a bit more on the js side, and of course updating docs.


float/double digits wrong when using higher precision

This is using a TI TMS320F2837xS. When using the default 6 digits of precision, the printout will print slightly wrong digits. (and when using any specific digits of precision, the print will not round the last digit).
For example: (the colons are there just to help emphasize the start and end)
TINY_PRINTF_FP_PRECISION = 6
float f_value = 2.3467216;
printf(":%f:\r\n", f_value); gives ":2.5880:"
printf(":%.1f:\r\n", f_value); gives ":2.3:"
printf(":%.2f:\r\n", f_value); gives ":2.34:"
printf(":%.3f:\r\n", f_value); gives ":2.346:"
printf(":%.4f:\r\n", f_value); gives ":2.3467:"
printf(":%.5f:\r\n", f_value); gives ":2./0))-:"
printf(":%.6f:\r\n", f_value); gives ":2.5880:"
printf(":%.7f:\r\n", f_value); gives ":2.'-*,:"
double d_value = 2.3467216;
printf(":%F:\r\n", d_value); gives "2.5880"
printf(":%.1F:\r\n", d_value); gives "2.3"
printf(":%.2F:\r\n", d_value); gives "2.34"
printf(":%.3F:\r\n", d_value); gives "2.346"
printf(":%.4F:\r\n", d_value); gives "2.3467"
printf(":%.5F:\r\n", d_value); gives "2./0))-"
printf(":%.6F:\r\n", d_value); gives "2.5880"
printf(":%.7F:\r\n", d_value); gives "2.'-*,"

Just ran your example on TM4C123GH6PM and also tried with cygwin and mingw32, all works.
Looks like by increasing the accuracy some gibberish output appears like '-*', maybe something writes on that stack?

I'll have to play with it further this week. I could increase the stack and see what happens.

I added a breakpoint to check for writing to the end of the stack - no issues. I wonder if this has anything to do with the char size on the TMS320F2837xS: the minimum size is 16bits (so char, short, etc are all full 16bits wide - although they only use 8bit to describe the value)

I figured it out. Your code makes the assumption that "int" is always 32 bits wide (regardless of architecture). So when the %f code is running it overflows quite soon with a 16 bit wide integer. I switched all of the "int"s to "int32_t" and all "unsigned int" to "uint32_t". I think that you should probably update your code to use the C99 specifications which require specifying the desired width for every type.

Hey, thank you for your feedback, I'll update the implementation to use stdint.


Allow switching of document search distributions through .env file

Similar to swiftotter/den#13, we should make it possible to easily switch between ElasticSearch and OpenSearch using only the .env file.

Great job!
Just for reference I would add https://github.com/swiftotter/den/commit/5184743f423d20574306a46efddf010f15a4e785 and https://github.com/swiftotter/den/commit/2d98cb4749cab0547008340f82b1b9871ef225a1


hack: add llama2 models

these models have the correct tags in HF but do not show up for some reason here.
Note that these require having the HF Hub token and an authorized HF account / signing Llama TOS. I also have not included the 70b model - not sure if DeepSpeed has implemented GQA yet.
I have signed the Microsoft CLA

@stillmatic what error is this resolving? I'm able to launch llama2 models with the current main branch of DeepSpeed-MII:
import mii
mii_config = {"dtype":"fp16", "hf_auth_token":<YOUR_HF_TOKEN>}
mii.deploy("text-generation", model="meta-llama/Llama-2-7b-hf", deployment_name="llama-deployment", mii_config=mii_config)
generator = mii.mii_query_handle("llama-deployment")
result = generator.query({"query": "test one two"}, max_new_tokens=1024)

It looks like you are modifying AML deployment code. Are you trying to get this working on AML resources? If so, we are aware of bugs with the AML deployment type and are resolving them in this PR: #211

cool -- I think issue was with the pip release, confirm master works (for moving past the 'unsupported model' errors) - closing the PR.
re the deployment code: I'm running locally in single-gpu setting and hitting this error
> mii.deploy("text-generation", model="meta-llama/Llama-2-7b-hf", deployment_name="llama-deployment", mii_config=mii_config)

    176 def _allocate_processes(hostfile_path, tensor_parallel, num_replicas):
    177     resource_pool = fetch_hostfile(hostfile_path)
--> 178     assert resource_pool is not None and len(
    179         resource_pool) > 0, f'No hosts found in {hostfile_path}'
    181     replica_pool = []
    182     allocated_num = 0

AssertionError: No hosts found in /job/hostfile

so was trying to work around that.

@stillmatic this looks like a bug on our side. We should be auto-generating a hostfile if one is not found, but it looks like that is not happening. You can avoid this by creating a file at /job/hostfile with the following content:
localhost slots=<NUMBER OF GPUS>
For example, on my local machine I have 2 A6000s and use:
localhost slots=2
I've created an issue and will follow up soon with a fix: #216