Signin status is CANCELLED when sign in with google home and 'personal results' setting disabled

I am developing account linking and I have a problem with google home in a certain case.
I have a DialogFlow intent that calls this code when i say "log in" :
export function signIn(app) {
  app.ask(new SignIn());
}

I have another DialogFlow intent that has "actions_intent_SIGN_IN" event and calls this code :
export function signInConfirmation(app, params, signin) {
  if (signin && signin.status === 'OK') {
    chatAsk(app, 'A');
  } else if (signin && signin.status === 'CANCELLED') {
    chatAsk(app, 'B');
  } else {
    chatAsk(app, 'C');
  }
}

Everything works fine with google home and google assistant : after logging in, the assistant answers "A".
However, when I disable the "Personal Results" setting on google home, the signin object of the signInConfirmation method has a status equal to 'CANCELLED' and I dont understand why.

I tried to authenticate (with this setting disabled) on applications available on the Google store and they all seem to handle this case: the assistant says something like : "In order to display different content, I need your permission to access your personal informations ... " and it sends a notification in the google home app to change the setting.
Thank you in advance for your help.

If you don't let the Assistant use personal information, it cannot be used to authenticate your account with other Actions.

I know but i would like to detect it and inform user to change its settings. But i don’t know how to do !?

Any workaround on that? I'm facing same issue.
Google just sends a "CANCELLED"  status code.
When using this approach you can customize a little bit your Account Linking responses, which is impossible when requiring Account Linking at intent level.

@Fleker
Shouldn't the SignInStatus reflect this or have
the auto response indicate the reason why Account Linking is automatically assuming the user has said "no" to signing in?
The current experience is jarring especially if the user thinks they have let the Assistant use personal information. I was scratching my head for 15mins wondering why it was assuming I had said "no" to signing in to an action.

The behavior that is exhibited is working as it was designed. If folks think that this behavior should be changed, then I can forward that feature request.

I believe that is what this issue is raising, @Fleker . There needs to be a more discrete differentiation between active, user-initiated cancellation via dialog vs. policy-based cancellation.
Please forward this as a feature request.

Indeed, for me, the behavior should be changed. However, there must be a workaround because as I said in my first post, some applications on the store handle this case correctly. Or is the environment in which the application is located (draft, alpha, beta, production) can change the behavior?

I second this. I think this is two-fold;

a way to check if personal results have been enabled before initiating Account Linking from new SignIn()
a more detailed description in SignInStatus similar to what @dt-tl describes

@Fleker Is this sufficient for a feature request?

A feature request has been filed internally.

Very curious how other people work around this, given the current state.
I've seen that for example Headspace has a specific welcome message when "Personal Results" is turned off:

I'm not sure who you are. Voice Match or Personal Results might be turned off. Would you like to learn how to help me recognize you?

For the moment the only solution I found is to close the application and force the user to restart to authenticate again.

@florent33700 , do you have any news about the latest point?

a feature request is already opened for that. We'll keep you updated with it.

No News

@florent33700
Concerning:

Another problem: when the user refuses to log in and so the login status is 'CANCELLED' and then he tries to log in again, Google does not manage the new SignIn() and returns "Sorry, I did not get any response. "

You might have noticed that it got fixed! Most certainly on the Actions on Google side.
About handling the 'CANCELLED' status, as I was facing the same issue, this is what I'm doing now:
app.intent('Signed In', async (conv, _, signin) => {
  switch (signin.status) {
    // Cancelled/dismissed account linking or Smart Display
    case 'CANCELLED': {
      const hasWebBrowser = conv.surface.capabilities.has(
        'actions.capability.WEB_BROWSER',
      );
      if (hasWebBrowser) {
        ...
      } else {
        // On a Smart Display, if the "Personal results" setting is disabled, the sign in status is 'CANCELLED'
        // See https://github.com/actions-on-google/actions-on-google-nodejs/issues/231#issuecomment-470281010
        // Inform the user that the "Personal results" setting needs to be enabled to sign in
        ...
      }
      break;
    }
    // User successfully completed the account linking
    case 'OK': {
      // Access token might not be available on a Smart Display if the "Personal results" setting is disabled
      if (!isSignedIn(conv)) {
        // Inform the user that the "Personal results" setting needs to be enabled to be signed in
        ...
        break;
      }
      // Welcome signed in user here
      break;
    }
    // System/network error or unknown status
    default:
      signIn(conv, 'Something went wrong during the sign in process.');
  }
});

const isSignedIn = (conv) => Boolean(conv.user.access.token);

So, basically, I'm using the surface's WEB_BROWSER capability to distinguish the Smart Display (auto cancel) form the phone Assistant (manual cancel).
Also note that in the 'OK' case I'm handling the case where the user has signed in on another device, phone typically. Indeed, I've noticed that in this case, when talking to the Smart Display with "Personal results" disabled, the intent responding to the actions_intent_SIGN_IN event receives the 'OK' signin status, but, no access token is available for the user in the conversation (I'm using the OAuth account linking). So we also need to inform the user that she's not signed in before she tries to ask for anything.
Took me quite some tome to understand this :grinning:...
Hope this helps!


echo server crash from corrupt ICMPv6 packet

Defensics test case 2: ICMPv6.Echo.Echo-Request.IPv6-Packet.payload.protocol.icmpv6-message.icmpv6-echo-request.element
This test case crashes echo server in QEMU.

icmpv6-2.zip
QEMU error logs:
[net/ipv6] [DBG] net_ipv6_process_pkt: (0x004037c0): IPv6 packet len 42 received from fe80::8c0:deff:fea4:a70d to 2001:db8::1
[net/icmpv6] [ERR] net_icmpv6_get_hdr: {assert: 'frag' failed}
[net/ipv6] [ERR] process_icmpv6_pkt: {assert: 'icmp_hdr' failed}
***** CPU Page Fault (error code 0x00000000)
Supervisor thread read address 0x00000001
PDE: 0x025 Present, Read-only, User, Execute Enabled
PTE: 0x00 Non-present, Read-only, Supervisor, Execute Enabled
Current thread ID = 0x004037c0
Faulting segment:address = 0x0008:0x00012c55
eax: 0x0000004c, ebx: 0x004078e8, ecx: 0x0040d514, edx: 0x00021bba
esi: 0x00000000, edi: 0x00404dce, ebp: 0x0040d580, esp: 0x0040d528
eflags: 0x206
Fatal fault in essential thread! Spinning...
Terminate emulator due to fatal kernel error


Mismatch between High Availability doc and Planned Maintenance doc on which tiers have available replicas/quorum

On the High Availability post, it indicates that the lower tiers of service (like Standard) operate with a single Primary replica and fail over to an instance with available capacity, if needed. The higher tiers of service (Premium, Business Critical) are represented with multiple replicas, write quorum, etc.
However, in the Planned Maintenance documentation, it indicates that all tiers have at least one active secondary replica that is available for failover:

For each database, Azure SQL Database and Azure SQL Managed Instance maintain a quorum of database replicas where one replica is the primary.

I wasn't sure which of the docs to post feedback from and whether one is outdated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 15036ef6-9c0b-044e-d600-b9f90f039720
Version Independent ID: 6fe5cd14-a1ad-e183-a048-d72686abb969
Content: High availability - Azure SQL Database and SQL Managed Instance
Content Source: articles/azure-sql/database/high-availability-sla.md
Service: sql-db-mi
Sub-service: high-availability
GitHub Login: @emlisa
Microsoft Alias: emlisa

@tarwn We are checking this and will get back to you.

In the High Availability article:
In the section on Basic, Standards, ...:

The diagram shows only a primary replica only
the write-up states:

Whenever the database engine or the operating system is upgraded, or a failure is detected, Azure Service Fabric will move the stateless sqlservr.exe process to another stateless compute node with sufficient free capacity.

In the section on [Premium and Business Critical service](Premium and Business Critical service):

The diagram shows a quorom in a ring shape, 1 primary replica + several secondaries
The explanation states:

High availability is achieved by replicating both compute and storage to additional nodes creating a three to four-node cluster.

and then goes into more detail on how the cluster works.
"Quorom" is used only in reference to the cluster of replicas for Premium/Business Tier.
In the Planned Maintenance document
Reading the planned maintenance document, it makes a general statement that sounds like all Azure SQL Database instances are part of a quorum set, the leading sentences of the second paragraph in the first section:

For each database, Azure SQL Database and Azure SQL Managed Instance maintain a quorum of database replicas where one replica is the primary. At all times, a primary replica must be online servicing, and at least one secondary replica must be healthy.

So on the one hand, the "Planned Maintenance" document is saying this is a core part of how maintenance is handled for SQL Database, but the High Availability article says only the upper tiers work this way.

@emlisa Please check feedback from @tarwn and help clarify the difference between the two.

Hi @tarwn,
Thank you so much for contacting Microsoft and our apologies for the delay in response! We beg for your patience as we're working through a long backlog of Git Issues.
Let me see what I can do to get this addressed for you.
Thanks!
Masha from the SQL Docs team
#assign:MashaMSFT

Hi @tarwn , thanks again for your feedback! We've processed a change to update the documentation that should be live next week.
I'll close out this Git Issue but please feel free to comment should you need anything further.
Thanks again for improving our docs and I hope you have a wonderful rest of your day!
Masha from the SQL Docs team
#please-close


at_c: free() major bug

It is possible for free() executions to occur in most functions when the variable was never allocated.

It could be solved by moving all the declarations and memory allocations to a point before the goto sentences

Assigning 2 SP;
Work involves going through each function and moving declarations near the top of the function.
Cases where the function is called will not be so memory efficient (as we are allocating memory that we ultimately do not use in the event of an error), but I think it would be safe to assume heavy memory intensive functions used in embedded devices will be used correctly most of the time. Some proper checking can be done on the atclient layer (the layer above atchops) to ensure input is correct before calling a memory-intensive function.


Update for Catalina

Description:
Update the present laptop script to be compatible with Mac OS Catalina. Update the applications installed via the script and creates a laptop file which can be used in the future to easily expand the capabilities of this install script.
This is dependant on the dotfiles PR getting merged as it pulls from that repository to automatically setup those dotfiles.
I wasn't able to get this to successfully install the rbenv ruby version without breaking the script. Instructions for how to do that, after the script is run, is listed in the README.md.

This is still in my court. I am planning on setting up a new machine with this when I get a chance, so I can actually provide "real" feedback. Stay tuned!

Cool! Interested to hear your thoughts on rbenv vs chruby Given rbenv's headache with Catalina + script break as a means to complete install, could be worth a transition look?

Personally I'd prefer to stick with rbenv and ruby-build given we also use them on the servers. I would hate to fall into the trap of "we implemented some else because at the time nothing else worked" and then later switch back to rbenv when it's working correctly, (and we know support will be fixed in the future), as we would then have different systems with different implementations, which can make diagnostics a nightmare.


Convert to Operator framework

Refactor to use the currently recommended framework. Also uses pytest-operator for integration tests, adds unit tests using the Harness, fixes some issues with the license, and removes EOL'd trusty.

This lgtm, it's nice seeing the test on the PR.

Looks good to me, thanks!


Initial draft of StaticWeb

Closes #48

Still in progress; do not merge. Need to write some tests at a minimum.

Good for reviewing now.


Add Request_ID in User Agent Header for Telemetry

Issue number:
Summary
Added request_id as a header for our user agent header for telemetry purposes. Also changed the caller parameter on the client side from a string to a dict so it can accommodate any future additions to the header that we want without much extra effort. Also for methods that call an rpc method multiple times (like retry_get_trace_tree_until), it will only pass in the same request_id everytime instead of a unique one so telemetry does not pick up multiple of the same method calls in our data
Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Mandatory Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] I have performed a self-review of this change
[x] Changes have been tested
[ ] Changes are documented

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

lgtm!


Fix ruby 3.0 CI

Summary
This closes https://github.com/github/view_component/issues/1223 as suggested by https://github.com/github/view_component/issues/1223#issuecomment-1003016691
Other Information
This also bumps all Rails versions to the latest patch release for each supported minor version.

Looks good to me! Thanks @Spone for this.

Waiting for a review to merge :)

@boardfish would you mind reviewing this? Weirdly, I can't add you as a reviewer...

There a "11 expected checks" that are probably obsolete since they have been renamed.
@BlakeWilliams Can you force-merge this?

Done, thanks for fixing this up!

Thanks @BlakeWilliams! I'm afraid we will have the same issue on all pending PRs. Do you know if there's a way to reinitialize the list of required checks repository-wide?


DRILL-4328: Fix backward compatibility regression caused by DRILL-4198

+1 tested the change by swapping the 1.5 mongo storage plugin jar with the 1.4 one and it worked.


the system will abruptly exit。

When I use the [precompiled executable for windows “pyrpl-windows.exe”],I cam connect my pitaya but when I reached the interface for selecting the hostname, I couldn't locate my designated hostname, causing the system to abruptly exit。

Hi @llzy665  , this happened to me, have you found any solution?, also it doesn't recognize my redpitaya and I've made sure (several times) that I'm connected on the same lan, in fact I can go to the default rp-XXXX.local but for some reason I'm not able to get it recognized by pyrpl

I also met this problem with my new PC. Even when I designed the IP address, it still crashed.  I can run the .exe in my other laptop(13xxx Intel CPU) and my VM.
My new PC uses the 14600K CPU, I am not sure if this is a problem.


How to deploy this Java web-app in Production?

Hey All,
How do we deploy an Java based web-app and controllers to Azure in PRODUCTION or other environemnts? I know FTP way of deploying the Java web-apps but in Production I dont think it is write for admins to follow steps? Any AZ CLI commands or Powershell commandds for doing the Java deployments?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b90ff6f8-f255-58b8-fc2e-f52fd1481640
Version Independent ID: 31063b65-21c4-0a7a-04bc-10be430cb116
Content: Create Java web app - Azure App Service
Content Source: articles/app-service/app-service-web-get-started-java.md
Service: app-service-web
GitHub Login: @rmcmurray
Microsoft Alias: cephalin;robmcm

@ketaanhshah
Thanks for your question. Please provide us with the link to the documentation you are referring to so we can better assist.

@ketaanhshah Any update? Please provide the doc details.

Hey Karishma, I was referring to this document/article and was thinking if their was a way if a sample AZ CLI script can be documented for Java deployments https://docs.microsoft.com/en-us/azure/app-service/app-service-web-get-started-java

@ketaanhshah Thank you for the doc feedback. We have assigned it to the author to see if they can approve/deny an update to include a sample AZ CLI script for java deployments.

@ketaanhshah For production deploy, I suggest you to use azure webapp maven plugin together with service principle(a delegated account for deploying production), see the document at https://docs.microsoft.com/en-us/java/azure/spring-framework/deploy-spring-boot-java-app-with-maven-plugin?view=azure-java-stable

Hi @ketaanhshah and team, the article has been updated to use the maven plugin. I believe it should address this issue.
#please-close


Add arch rebuild for 5.x

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Required for https://github.com/conda-forge/root-feedstock/pull/111

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge/llvmdev, ready for merging! This PR adds ARM/POWER for LLVM 5 which is required for https://github.com/conda-forge/root-feedstock/pull/111

@isuruf I guess those were the build.sh and pass-through-qemu-ld-prefix.diff changes in?
https://github.com/conda-forge/llvmdev-feedstock/pull/95/files#diff-44a73bcc045c193c3bd45da87994b03b
Or is there something else? If it's complex I might just disable POWER as I mostly care about ARM for now which is still being built natively.

Yes, and the follow up PR https://github.com/conda-forge/llvmdev-feedstock/pull/99/

pass-through-qemu-ld-prefix.diff is not strictly necessary

@isuruf I think I've backported everything that matters

@isuruf @conda-forge/llvmdev I think this is ready

Thanks @isuruf! 🍰


commented out unreferenced gitpack url in gradle

This update attempts to fix an issue where there is an existing package using  gitpack but through a private repo requiring authentication. Since there was no dependency being served over gitpack for this plugin, it made sense to remove the culprit. If there is a cleaner approach to solving this issue from the client app, you can share. Else I think this should be merged

Thank you for fix issue :)


Modify Android APIs to match Dart SDK

As a developer, I need that all APIs matches through different environments.
Review Android APIs to match Dart SDK APIs.
TikiSdk

properties:

address

methods

assignOwnership

params
String source,
TikiSdkDataTypeEnum type,
List contains,
String? about,
String? origin
returns String Ownership transaction Id

getOwnership

params
String source,
String? origin
returns TikiSdkOwnership

modifyConsent

params
String ownershipId,
TikiSdkDestination destination,
String? about,
String? reward,
DateTime? expiry
returns TikiSdkConsent

getConsent

params
String source,
String? origin
returns TikiSdkConsent

applyConsent

params
String source
TikiSdkDestination destination
Function request
Function(String)? onBlocked,
String? origin
returns void

Acceptance criteria:
1 - Updated APIs, with equivalent parameters.


Issue with python version and empty data folder

Thank you very much for sharing this scripts!
I am writing this to inform you about two issues which I encountered when trying to learn models with train.py (everything works in python 3.6 and right data folder, but warnings might be helpful for future users):

When using python version 3.5.1 the following error appears:
File "Train/train.py", line 62
if Path(f'parameters/{args.name}.json').exists()
SyntaxError: invalid syntax
When data folder is empty (which causes len(frames) = 0):
...
File "/Users/mirkocoric/Documents/vde/super-resolution/VideoSuperResolution/VSR/DataLoader/Loader.py", line 534, in _generate_crop_grid
index = np.random.randint(len(frames), size=size).tolist()
File "mtrand.pyx", line 993, in mtrand.RandomState.randint
ValueError: low >= high

Hi @mirkocoric
1st Q:
With python syntax: f'string-{var}', this string format syntax only works after python 3.6, however, it's the same as 'string-{}'.format(var).
2nd Q:
Yeah, that's a bug for empty dataset (especially triggered in training). I fixed it in today's commit.
Thank you :)


Include and Exclude problems

Describe the bug
First of all, include and exclude are more than welcome! Prefer this over the disabling in UI, because I have a lot of decives, which are found via alexa media player, but not working (e.g. all the Sonos tuples, ...) and other devices, which I do not want to have in HA. So great to have include and exlcude!

If I use include during setup and include either "Echo Dot Wohnzimmer" oder Echo Dot Wohnzimmer without "", the setup creates "Echo Dot Wohnzimmer", but my other device called "Wohnzimmer" as well. This is only not happening, if I exclude "Wohnzimmer" on top.

If I include only "Echo Dot Whatever", the integration only set up the entity/device "Echo Dot Whatever", but not the alarm, timer, ... entities. Bug or feature? What can I do, that the corresponding entities are set up as well?

To Reproduce
Use include and exclude during setup.
Expected behavior
ad 1., If I include only "Echo Dot Wohnzimmer", it should create only ""Echo Dot Wohnzimmer" (with corresponding additional entities)  and not the other device called "Wohnzimmer" as well.
ad 2. If I include "Echo Dot Whatever", it should create this, but the corresponding additional entities as well.
System details

Home-assistant (version): 2021.8.2
Hassio (Yes/No): Yes
alexa_media  (version from const.py or HA startup): Do not know how to find
alexapy (version from pip show alexapy or HA startup): Do not know how to find
Amazon 2FA is enabled (y/n). We will not debug login issues if unanswered: y

For 1, please provide logs showing startup. That will show what is being included or excluded.
For 2, please read the documentation. Include only includes what you specifically include-- Not related devices.

ad 2. I always read the documentation. ;-) But either, we are talking about different topics or the documentation can be improved. The include/exclude part is referring to include/exclude devices. And I'm talking about corresponding entities/sensors, where the documentation says
Each online media player that supports Notifications will create the following sensors:

sensor.media_player_next_alarm
sensor.media_player_next_timer
sensor.media_player_next_reminder

So I didn't find in this doc, that this is not only for devices, but for entities as well and that I have to include those entities as well. And in the referred part, that this is only happening, when including those explicitly during include as well.
Because of this, I expected that I include/exclude devices and the integration setup theses additional entities for included (and supporting) devices.
But thank you. Beside this mix of devices and entities in the doc, it worked now, if I included the entity sensors as well during setup.
Echo Dot Wohnzimmer next Alarm
Echo Dot Wohnzimmer do not disturb switch
Echo Dot Wohnzimmer next Reminder
Echo Dot Wohnzimmer next Timer
Echo Dot Wohnzimmer repeat switch
Echo Dot Wohnzimmer shuffle switch

ad 1.
2021-08-08 09:16:41 DEBUG (MainThread) [custom_components.alexa_media.config_flow] Setting up Alexa devices with {'oauth_login': True, 'email': 'xxx', 'password': 'yyy', 'url': 'amazon.de', 'debug': False, 'scan_interval': 60, 'include_devices': '"Echo Dot Wohnzimmer"', 'exclude_devices': '', 'oauth': {'access_token':

and

2021-08-08 09:16:46 DEBUG (MainThread) [custom_components.alexa_media] xxx: Existing: [] New: ['Echo Dot Wohnzimmer', 'Wohnzimmer']; Filtered out by not being in include: ['Fire TV', "Sonos One", etc etc] or in exclude: []

So it adds "Wohnzimmer" as well whereas only "Echo Dot Wohnzimmer" should be included. And yes, tried this with and withoiut "", first without. This is only not happening, if I exlude "Wohnzimmer" on top.

For 2, feel free to correct the wiki if you don't think it's clear enough.
For 1, please provide the specific "include_devices" setting you are using.

ad 1. Didn't get this anymore. I have described and posted it more than once: See last post.

'include_devices': '"Echo Dot Wohnzimmer"'

And "Echo Dot Wohnzimmer" is the only string, which I put in this case in the include textbox during integration setup.
That's it in this example/case. But it sets up "Echo Dot Wohnzimmer" and "Wohnzimmer". I assume, that the code uses contains or whatever and then Wohnzimmer is in the include "Echo Dot Wohnzimmer". But I do not know.
If you are not interested in this bug, please close it. I only made this effort to make you aware of this. My setup is now running with exluding Wohnzimmer (even if not included) on top of this.
ad 2. You are funny. I cannot change docs, if it is not clear if the docs or the program behavior are wrong? For me it is still unclear, but I can live with it. Either with the correct or wrong behavior. For me it is wrong. How should I know, which are the names and supporting entities to include them manually, if it described like

Each online media player that supports Notifications will create the following sensors

I am reviewing item 1. Thank you for bringing it up.
For 2. It's a wiki. Anyone can change it to make it clearer. There's an edit button on every page.

I know, but anyone can only make it clearer, if it is clear how it should work and what is or is not a bug. ;-)

Do "Echo Dot Wohnzimmer" and "Wohnzimmer" have the same serial number? Please check your devices page:
The include language does not use contains and relies on a literal match.
https://github.com/custom-components/alexa_media_player/blob/dev/custom_components/alexa_media/__init__.py#L488
This is toy code that does the same test:
include = ["Wohnzimmer"]
devices = ["Echo Dot Wohnzimmer", "Wohnzimmer"]
for device in devices:
     if device not in include:
            print("Device " , device, " filtered")

>>>
Device  Echo Dot Wohnzimmer  filtered

include = ["Echo Dot Wohnzimmer"]
devices = ["Echo Dot Wohnzimmer", "Wohnzimmer"]
for device in devices:
     if device not in include:
            print("Device " , device, " filtered")

>>>
Device  Wohnzimmer  filtered

Please also confirm that Wohnzimmer's serial is not appearing under appDeviceList under Echo Dot Wohnzimmer. I'll probably think about how to try to reproduce it a few more days. Please also the 5 or so lines before:
2021-08-08 09:16:46 DEBUG (MainThread) [custom_components.alexa_media] xxx: Existing: [] New: ['Echo Dot Wohnzimmer', 'Wohnzimmer']; Filtered out by not being in include: ['Fire TV', "Sonos One", etc etc] or in exclude: []

As for the wiki, the instructions say that the sensors are included by default. If you start using advanced settings like the include and exclude filters, the defaults no longer apply. The only edit I can see is to be explicit that defaults only apply when advanced settings aren't in use, but that seemed clear to me. If it wasn't clear to you, then that may be a reason to update the wiki in a way that makes it clear to you since others may read it the same way. The wiki is maintained by the community with the hope that collectivity the documentation improves as people see areas to improve.

{"accountName":"Echo Dot Wohnzimmer","appDeviceList":[],"capabilities":["I_HEART_RADIO",etc.],"charging":null,"clusterMembers":[],"deviceAccountId":"APXEN5SABAFAO","deviceFamily":"ECHO","deviceOwnerCustomerId":"bbb","deviceType":"ccc","deviceTypeFriendlyName":null,"essid":null,"language":null,"macAddress":null,"online":true,"parentClusters":[],"postalCode":null,"registrationId":null,"remainingBatteryLevel":null,"serialNumber":"fff","softwareVersion":"669702920"}

and
  {"accountName":"Wohnzimmer","appDeviceList":[],"capabilities":["APPLE_MUSIC",etc.],"charging":null,"clusterMembers":[],"deviceAccountId":"aaa","deviceFamily":"THIRD_PARTY_AVS_MEDIA_DISPLAY","deviceOwnerCustomerId":"bbb","deviceType":"ddd","deviceTypeFriendlyName":"Sonos","essid":null,"language":null,"macAddress":null,"online":true,"parentClusters":[],"postalCode":null,"registrationId":null,"remainingBatteryLevel":null,"serialNumber":"eee","softwareVersion":"0"}

Wohnzimmer Echo Dot = Echo Dot
Wohnzimmer = Sonos ZP80 (without Alexa), but connected to Wohnzimmer Echo Dot as speaker device. But this is only playing if my audio receiver is on, so useless for announcements.
So appDeviceList is empty in both devices and the serials are not equal, only deviceOwnerCustomerId is equal, see bbb=bbb.
2021-08-08 09:16:46 DEBUG (MainThread) [custom_components.alexa_media] Echo Dot Wohnzimmer: Locale de-de timezone Europe/Berlin
2021-08-08 09:16:46 DEBUG (MainThread) [custom_components.alexa_media] Echo Dot Wohnzimmer: DND False
2021-08-08 09:16:46 DEBUG (MainThread) [custom_components.alexa_media] Wohnzimmer: Locale en-us timezone None
2021-08-08 09:16:46 DEBUG (MainThread) [custom_components.alexa_media] Wohnzimmer: DND False

Has there been any progress looking into this?


Passing object argument does not work any more in v11

Calling a macro with an argument like so used to work for me in v10:
macro.execute(item5e)
Now in v11.302 I’m getting an error inside the macro on the very first line just with this:
if (!args) return
The error:

VM287868:4 Uncaught (in promise) ReferenceError: undefined. args is not defined
[Detected 3 packages: advanced-macros, lib-wrapper, rngd]
at Macro.eval (eval at #executeScript (foundry.js:22632:16), :4:13)
at #executeScript (foundry.js:22636:17)
at Macro.execute (foundry.js:22584:35)

Arguments are not an Advanced Macros feature on Foundry V11, that became a core feature and the implementation is different from what Advanced Macros used to:

The arguments are passed as part of an object now.

E.g. macro.execute(item5e) -> macro.execute({item5e}).

The macros are to be written assuming the parameter will be passed as an individual parameter instead of part of args.

E.g. if (!args) return -. if (!item5e) return.

I don't intend on fixing macros broken by V11 changes, look for more help on #macro-polo channel on Foundry's discord.

Thank you very much! I got access to the item5e parameter within the macro very nicely now with your guidance.
When I set the same macro to Execute for Specific User then the macro does not run though - no console logs and no error messages or warnings for GM or player user, just nothing happens. That is a separate issue though.

Hm, can you open another issue and share the entire macro? Just export the macro's data and upload it to the issue.


Restructure intro.rst and other pages for data warehouse

Still WIP,
Need more input on the ETL section of the intro.rst page! I think you can probably just go ahead and work off this branch too add it @bendnorman what do you think?

Move the The Data Warehouse Design and Data Validation sections on the create-naming-convention-docs branch to the Data and ETL Design Guidelines page

If we do this, I would wonder what the purpose of this introduction page is. Maybe we don't need it? Idk... I do feel like some brief description of what's going on would be nice as I don't think only developers would want to know this type of information. A lot of users might be curious what is actually happening to t the data they are using in between raw and final. Data and ETL Design Guidelines page feels a little bit hidden. Maybe we could take the mini paragraph descriptions for each section from the README page and put them in the intro instead of having longer descriptions there.

I think you're right I shouldn't assume users don't care about how the data is processed. In that case, what if we just keep the data warehouse / processing language from create-naming-convention-docs branch on the intro page? Users can jump to the data access page if they like or continue to read about the data processing steps:

To get started using PUDL data, visit our Data Access page, or continue reading to learn more about the PUDL data processing pipeline.

Or we can move the data warehouse design language to the ETL Guidelines page and just link to it in the intro page.
I think we're starting to bump up against larger unanswered questions about our docs that are out of the scope of the renaming docs. To keep things simple, what if we:

Use the README changes on this branch
Keep the intro.rst page from the other branch.
Use the Naming Convention section changes from this branch

Changes in the branch were incorporated into #2874.


Update installation instructions

OpenStack Release
Liberty +
Description
The installation instructions should be updated as follows:

add instructions for specific packages as they're made available (rpm, apt-get, pip)
remove version number from code example so it doesn't have to be updated for every release (see the lbaasv2-driver install instructions)

Closing per feedback from @jputrino.


Helm chart: fix crd issues when stacks enabled

Fixes #1026
Currently helm chart installation fails when stacks deployment enabled and installed with helm upgrade --install
helm install --name crossplane crossplane-alpha/crossplane --namespace crossplane-system  --version 0.4.0 --set 'clusterStacks.gcp.deploy=true' ==> Works
helm upgrade --install crossplane crossplane-alpha/crossplane --namespace crossplane-system  --version 0.4.0 --set 'clusterStacks.gcp.deploy=true' ==> Fails
The root cause is post-install and post-update hooks do not work reliably (i.e. work differently for helm install vs helm upgrade —install even it is first time install both).
This PR removes post-install and post-update hooks from ClusterStackInstall resources and adds crd-install hooks to CRD.
Our CRDs are auto generated by kubebuilder tools, thus this PR also updates makefile so that generated CRDs contain the annotations. Since kubebuilder does not provide a mechanism to add annotations to CRDs, I used kustomize in Makefile as suggested in this comment.
Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.
[ ] Updated any relevant documentation, examples, or release notes.
[ ] Updated the RBAC permissions in clusterrole.yaml to include any new types.

Depends on https://github.com/upbound/build/pull/76

@jbw976 done!


default workspaces on new monitors

One of the painpoints in the default configuration of Sway is the way multi-monitor setups are behaving:

Workspaces are per-output, not merged into one area made of all connected displays (I don't advocate to set it up like this, but that's one of the solutions)
New workspaces aren't created when new display is connected = when you call existing workspace and you focus on the newly connected screen, the behavior may be different, see p.3:
When you call a workspace which doesn't exist, it is created on the currently focused output, but if you call an existing one, you aren't bringing it to the currently focused output, you're changing the workspace on the output it was initially created on = there's no way to "move" workspaces between the screens.

All in all it confuses me a lot, and while it's not the worst setup of course, I think there's a better way we can do this:

External tool: swaysome
Some sort of default setup to create additional workspaces for new monitors, maybe integrated with kanshi: example, kanshi reference
I didn't research the question thoroughly yet: anyone having experience with multimonitor setups, or maybe some ideas?

swaysome looks like a great help. did you have a chance to look into it yet? should I add it to our repo?

we should ask the maintainer to make a tagged release
we should ask the maintainer to add a license

Hi! Developer of swaysome here.
I just found this issue, which is nice, because it seems I'm not the only one trying to solve the multi-monitor sway problem :)
As you needed it, and I agree it was missing, I just pushed a license and a first release tag.
Do you need anything else to help package swaysome? I do not use Manjaro personally on a desktop, so I'm not very used to its ecosystem, but I'll be happy to help if you need anything. Do you think it would help you if the repo was more accessible, on gitlab.com or github.com for example?

Hello :D
Your project is very interesting, I appreciate the effort a lot ;)
One of the questions that I've had about swaysome is its' compatibility with sworkstyle - a Rust app which changes the workspace name dynamically depending on which apps are opened on the desktop itself. As far as I understand (didn't have any experience with Rust before), swaysome uses workspace names rather than workspace number functionality of Sway. If there's a way to add support for workspace number <something>, it will be awesome, because then the workspace names will remain stylish and informative, and user will be able to change it as wanted :)
Example of how that looks now:

Indeed, it uses the workspace names rather roughly. Since there seems to be some interest for the project, I've dug up the code and am working in cleaning it a bit to get better argument parsing, better logging, and then I'll see what can be done to make it compatible with sworkstyle. I may even look into cargo publish so that it could become available with cargo install swaysome.

I've just pushed a 1.1.0 tag that includes many code rework and the compatibility with sworkstyle (awesome gadget, btw!). I still need to see how cargo publish works, but in the meantime, this should be a nicer swaysome release to build upon.

bumped to the tagged version

Interesting, I like the default behavior because it allows me to easily switch between monitors without needing a mouse or extra shortcuts. And then supplement it with https://github.com/manjaro-sway/manjaro-sway/issues/481

While I think swaysome still makes sense, I don't see us adding it to the default setup.


Docs command

Denali's documentation lives with it's source code - the guides and API docs alike. Since we have everything to generate the docs in the locally installed package, why not do it?
In addition, if we can agree on some kind of JSON structure to describe docs, we could allow addons to generate their own docs as well. This would vary based on source language (i.e. Typescript would use typedoc, Babel would use jsdoc, etc).
This would allow the user to run $ denali docs and a browser tab would open with all the docs for their own app (denali + their unique set of addons + the app itself, if they have documented any of it), offline and versioned.

Actually - we don't need to set a standard for docs content. We can have the root project that the docs command is run from generate a wrapper page with an iframe that just has "package" navigation (i.e. a dropdown listing denali, all the addons supplied, etc). The CLI can just invoke something like builder.toDocsTree() on each package's builder class, namespacing the results under the package name, i.e.:
docs-output/
  index.html    <- wrapper page with iframe and package nav
  denali/
    index.html
    ... the usual denali docs ...
  denali-auth/
    index.html
    ...
  my-app/
    index.html

This way we don't need to maintain cross-version support for a single doc standard, and each package could even theme or visually structure their own docs differently. We'll just provide default implementations for the popular languages (Typescript, Babel).
Basically all the docs command does is provide a hook for each package to supply it's own broccoli builders, and a wrapper page to navigate between them.


[BUG] Intermittent issue while generating PDF

@baharev @alixaxel

Environment

chrome-aws-lambda Version: 2.1.1
puppeteer / puppeteer-core Version:   2.1.1 (puppeteer-core`)
OS:  (Linux) on AWS Lambda function
Node.js Version:  12.x
Lambda / GCF Runtime: nodejs12

Expected Behavior
PDF should be created
Current Behavior
PDF creating at Intermittent intervals.
Sometimes PDF is generating properly and sometimes PDF is generating with blank content
Steps to Reproduce

Possible Solution
I checked the code for generating html method 'fetchHtml', and uploading pdf file to S3 functions separately they works as expected  but at Intermittent intervals generating pdf fails. I mean PDF created with blank data.
Specifically it fails at
const pdf = await page.pdf({
format: "A4",
printBackground: true,
margin: { top: "1cm", right: "1cm", bottom: "1cm", left: "1cm" }
});
console.log('pdf json stringify' + JSON.stringify(pdf));
Root Cause :
Comparison done for both 'pdf' objects when pdf is generated and when pdf is blank, compared by converting both pdf objects into buffer data and both buffer data are not the same. Thats the reason sometimes it is working and sometimes not. And this pdf object that we are creating is as per documentation only, if its not consistently creating same data , then I think the problem might be with library itself.
package.json dependancies:
dependencies": {
"chrome-aws-lambda": "^2.1.1",
"pug": "^2.0.4",
"puppeteer-core": "^2.1.1"
}
If i can get any help from this post, kindly appreciated.

@prashanthkalidindi84  I see nothing under Steps to Reproduce.

@baharev
@mithundas79
@alixaxel
my issue is fixed after adding this { waitUntil: 'networkidle0' }
await page.setContent(html, { waitUntil: 'networkidle0' });

Glad you figured it out @prashanthkalidindi84, closing this issue.


Encoding a value of empty list in Dynamo.

Hi,
We are using this wonderful library in our application, communicating with DynamoDB. Since we have our own schemas/structs, we call ExAws.Dynamo put_item and update with just a map, for example:
Dynamo.put_item("table_name", %{field: value, field2: value2})
I just noticed that attempting to insert or update a value of an empty list fails. It works if I change line 101 in the file, "lib/ex_aws/dynamo/encodable.ex", from this:
def encode([], _), do: []
to this:
def encode([], _), do: %{"L" => []}
Might this be an appropriate fix for you to apply?
Thank you,
Gilad

Fixed in master, thanks!

That's awesome, thank you very much!


Add llama download support for multiple models with comma-separated list

The Llama CLI streamlines downloading a Llama model:
llama download  --model-id Llama3.1-70B-Instruct

A nice improvement would be enabling --model-ids MODEL_A,MODEL_B to download multiple models in one go!

PR: https://github.com/meta-llama/llama-stack/pull/261


If I use a VSSM block in a model, how can I quickly calculate the FLOPs?

I modified the code in flops.py and commented out the patch_embed in backbone_vssm in vmamba.py to calculate the FLOPs for a single VSSM block.

Will this give an accurate result for the FLOPs of a single VSSM block?
the output

I think its better using the functions FLOPs.fvcore_flop_count to count the whole new model you build，with unsupported operations printed.
FLOPs.fvcore_flop_count can be seen as an extended version of fvcore.flops_count which supports s6 operations in ss2d blocks.

Thank you for your response. I would like to ask about the impact of those unsupported operations on the final results. Can they be ignored?

For vmamba specific，the selective_scan operation is supported by our own implemented flops_count (so it should not appear in the unsupported list), the crossscantritonF is just a copy operation， so it has no effect on flops. For other operations，you can refer to networks without ss2d.


Copied from create-s3-state-bucket and modified to copy tfstate file

Just thought I'd add this. I found it handy so I didn't have to log into the AWS console.

Once the tfstate file has been downloaded then you can find the public DNS name of the EC2 instance using:
aws ec2 describe-instances --instance-ids $(grep '"instance": "i' re-build-systems.tfstate | cut -d'"' -f4) --query 'Reservations[].Instances[].PublicDnsName'

and the public IP address using:
grep '"public_ip": "[0-9]' re-build-systems.tfstate | cut -d'"' -f4

I am reviewing this. Feel useful, but probably we should find another place for these utilities to keep the repository lean. Similarly to the links that have been relocated from the README file to a separate document.
Should we start a knowledge base?
Also, if the public DNS name of the EC2  is an important information, we may find other ways to obtain it - maybe outputting it at the end of a terraform apply?


One package for multiple servers

One use case is, that there are different packages, which are basically the same for multiple servers. Right now, one needs to create multiple packages, even though the only thing that changes is the priority perk (for what server it will be added for).
For such use case, it would be good to have the possibility to configure a package, which contains a priority queue perk. This perk then has a configuration of the cftools server IDs. The user will be presented with a dropdown, where they need to choose for what server they would like to have the priority queue.

[x] Configure multiple servers in the priority queue perk
[x] Render a selection menu when a donator wants to donate for a multi-options priority queue perk
[x] Redeem the priority queue for the selected server on multi-options priority queue perk
[x] Consider how multi-options priority queue perks work with Subscriptions
[x] Render the selected server in the redeem now page (instead of the "one of servers" message)

Will be released with the next release :)


Publish HelmCharts as OCI (Open Container Initative) format

Description

Publish the helm charts as OCI, example to the openebs docker hub?
Context

OCI is becoming more prevalent, example some of our dependencies like bitnami charts are also as OCI:
https://blog.bitnami.com/2023/04/httpsblog.bitnami.com202304bitnami-helm-charts-now-oci.html
In particular bitnami is deprecating the index.yaml and way and strongly suggest we migrate to OCI.
Possible Solution

My suggestion is to push as OCI as additional step (keeping existing way). If all goes well then we can also add some time frame and then start pushing new versions to OCI only. We need not disable the existing index.yaml as that would break users.
Screenshots

Seems like we should make OCI a new  option for project Helm charts.

Would be nice to get a feel for how complex this Eng work would be?

Note for observers: OCI is Open Container Imitative format/runtime
The OCI currently contains three specifications:

the Runtime Specification (runtime-spec)
the Image Specification (image-spec)
the Distribution Specification (distribution-spec).

The Runtime Specification outlines how to run a “filesystem bundle” that is unpacked on disk. At a high-level an OCI implementation would download an OCI Image then unpack that image into an OCI Runtime filesystem bundle. At this point the OCI Runtime Bundle would be run by an OCI Runtime.
Seems that @tiagolobocastro is proposing we include OCI Runtime in our Helm charts.

Would users choose/specify an to install an OCI packaged distribution? or would be do it without them knowing ?


Support http_address format of Elasticsearch 2.x in Sniff connection pool

With Elasticsearch 2.x, the address format returned from the node api has changed:
curl -s -XGET http://my-db:9200/_nodes?pretty  | grep addr
    ...
      "http_address" : "my-db/<IP_ADDRESS>:9201",
    ...

The old format was inet[my-db/<IP_ADDRESS>:9201]. When using a Sniff
connection pool, the resulting node addresses are not parsed correctly, i.e.
the hostname is not stripped off. This yields unusable connections:
[Cxn] ** [http://my-db:80/<IP_ADDRESS>:9201]-[599] Could not connect to 'my-db:80': Connection refused

The problem only occurs if a hostname is given, otherwise the content of http_address is just <ip>:<port> and the non-matching regex in Role::CxnPool::Sniff does not hurt.

thanks for reporting @tom-mi - 2.02 is now available

That was quick -- thanks :+1:


Additional text does not fit in product slider

Proposal by @clastzoo &  @Gagne87:

Width of the cards stays as it is
Height (of all cards) is dynamic and adjusts according to the longest text of the product slider
The add-on of the text should be displayed in a light font (font-weight:400)
Card shadow is added to cards (to make action more understandable)

Compare to designs in Figma.

What is the state here?

[ ] check with long test which are in the Figma

[ ] fix the alignment to top
[ ] adjust height for 3 lines


Require and/or describe authentication methods in ID Token

Because of its decentralized nature, authentication in Solid relies on the trust between a Client and an Identity Provider (OP). This trust can partially be based on the trust between the End-User and the OP (via the solid:oidcIssuer triple in the identity document), but also needs to be complemented with trust in the authentication mechanism(s) of that OP.
It would be valuable if the Solid-OIDC specification requires the use, or at least describes the possibility, of the following optional fields in the OP metadata (.well-known/oidc-configuration) and the retrieved ID Tokens, respectively.

acr_values_supported: [a] JSON array containing a list of the Authentication Context Class References that [the] OP supports

acr: [a] string specifying an Authentication Context Class Reference value that identifies the Authentication Context Class that the authentication performed satisfied

Interesting Authentication Context Class References are OpenID PAPE levels or IANA LoA profiles. Any other absolute URI can also be used, assuming that there is a shared understanding of its meaning.

Thanks to @laurensdeb for pointing this out, and @RubenVerborgh for providing the opportunity for interaction 🙏


fix: addresses import errors

Reviewers
Functional:
@metakuni @Bento007
Readability:

Changes

add
remove
modify

Definition of Done (from ticket)
QA steps (optional)
Known Issues

@Bento007 @metakuni I'm merging this since it's a feature branch and they are all changes that Trent and I already looked at together in my development branch earlier this week.


Fix "Cannot set property 'date' of undefined' error"

Okay, so I tested node-np with the latest coffea version (0.4.13). Events are received properly via (err, event), but I changed it to (event) for simplicity.
I also updated node-np to use the coffea 0.4.13 command event.
I'm still trying to reproduce the Cannot set property 'date' of undefined' error. - Can you give me any clues on that?


Dynamic Linking Error

dynamic linking error while trying to access a dll file. for clarification the file can be access by a compiled exe file, which is in the same directory. Tried putting in a direct path, but also no luck, error message below:
C:/test/modules/bin/libmtp-9.dll //printed path
C:\test\node_modules\ffi\lib\dynamic_library.js:74
throw new Error('Dynamic Linking Error: ' + err)
^
Error: Dynamic Linking Error: Win32 error 126
at new DynamicLibrary (C:\test\node_modules\ffi\lib\dynamic_library.js:74:11)
at new Library (C:\test\node_modules\ffi\lib\library.js:45:12)
at Object. (C:\test\modules\index.js:33:11)
at Module._compile (module.js:435:26)
at Object.Module._extensions..js (module.js:442:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:311:12)
at Module.require (module.js:366:17)
at require (module.js:385:17)
at Object. (C:\test\index.js:4:11)
any help would be greatly appreciated.
thanks.

The path to your DLL is not correct, check MS website
ERROR_MOD_NOT_FOUND
126 (0x7E)
The specified module could not be found.

i am aware of the error, thanks tho. the problem i am having is why it is throwing the error when i am certain i am giving the correct folder location.
// libmtp definition
var mtp = new ffi.Library(__dirname + "/bin/libmtp-9.dll", {

any help with folder path would be appreciated

Actually if the dll has been found, but it references some other dlls that is not in the path, you'll get the above error too. Kinda misleading.

Actually if the dll has been found, but it references some other dlls that is not in the path, you'll get the above error too. Kinda misleading.

well since this i have been able to use the library only if it is is in root of my electron app. works ok from there will do some investigation from there on paths. but now works closing issue

well since this i have been able to use the library only if it is is in root of my electron app. works ok from there will do some investigation from there on paths. but now works closing issue


Install of Tensorflow Lite error - :app:compiledebugjavawithjavac

Hi,
I am trying to test out the Tensorflow Lite Android demo on Android Studio, but I am always getting the build error: :app:compiledebugjavawithjavac. I set the JDK path and rebuilt the project. I have done everything the instructions have said. I recently installed the latest Android Studio 3.1.2 just before importing the Tensorflow Lite demo. So how can I fix this?
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows - on Android Studio
TensorFlow installed from (source or binary): Android Studio Demo Code
TensorFlow version (use command below): NA
Python version: 3.6.5
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: 9.0 / 7.0
GPU model and memory: GeForce GTX 750
Exact command to reproduce: NA

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

I've updated the fields.

Nagging Assignee @petewarden: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Could you describe how you are building tf lite?

Nagging Assignee @petewarden: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Issues verifying certificate connecting with HTTPS

Crystal version
~/code/nabobil/autotoll · (master±)
⟩ crystal -v
Crystal 0.23.1 (2017-10-12) LLVM 4.0.1

How to reproduce
# test.cr
require "http/client"

client = HTTP::Client.new("maps.googleapis.com", tls: true)
client.get "/"

Then run crystal run test.cr.
Expected outcome
No errors raised, or some redirect.
Actual outcome
SSL_connect: error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed (OpenSSL::SSL::Error)
0x10d990e45: *CallStack::unwind:Array(Pointer(Void)) at ??
0x10d990de1: *CallStack#initialize:Array(Pointer(Void)) at ??
0x10d990db8: *CallStack::new:CallStack at ??
0x10d98d615: *raise<OpenSSL::SSL::Error>:NoReturn at ??
0x10da33571: *OpenSSL::SSL::Socket::Client#initialize<TCPSocket, OpenSSL::SSL::Context::Client, Bool, String>:Nil at ??
0x10da333ec: *OpenSSL::SSL::Socket::Client::new:context:sync_close:hostname<TCPSocket, OpenSSL::SSL::Context::Client, Bool, String>:OpenSSL::SSL::Socket::Client at ??
0x10da29c91: *HTTP::Client#socket:(OpenSSL::SSL::Socket+ | TCPSocket+) at ??
0x10da299eb: *HTTP::Client#exec_internal_single<HTTP::Request>:(HTTP::Client::Response | Nil) at ??
0x10da26f7c: *HTTP::Client#exec_internal<HTTP::Request>:HTTP::Client::Response at ??
0x10da26e72: *HTTP::Client#exec<HTTP::Request>:HTTP::Client::Response at ??
0x10da26bdd: *HTTP::Client#exec<String, String, Nil, Nil>:HTTP::Client::Response at ??
0x10da26bb7: *HTTP::Client#get<String>:HTTP::Client::Response at ??
0x10d97bcba: __crystal_main at ??
0x10d98c678: main at ??

Notes

This also happens when running the code within the official docker image for 0.23.1.
I've managed to get it to pass randomly, but I believe there is some cipher requirement and that the certificates differ somewhat between the servers behind this domain
When running openssl s_client -connect maps.googleapis.com:443 -tls1_2 I get:

CONNECTED(00000003)
depth=2 C = US, O = GeoTrust Inc., CN = GeoTrust Global CA
verify return:1
depth=1 C = US, O = Google Inc, CN = Google Internet Authority G2
verify return:1
depth=0 C = US, ST = California, L = Mountain View, O = Google Inc, CN = *.googleapis.com
verify return:1
---
...
...

It works if I setup a similar example in Ruby:

require 'net/http'
require 'uri'

uri = URI('https://maps.googleapis.com/')

Net::HTTP.start(uri.host, uri.port, use_ssl: true) do |http|
  request = Net::HTTP::Get.new uri
  response = http.request request # Net::HTTPResponse object
  puts response
end

In other words, I don't believe this is an issue with my openssl configuration.

Duplicate of #3477.
See also https://github.com/composer/composer/issues/3346 and relevant question on SO.

I'm not sure, I'm able to connect with TLS to github.com:
HTTP::Client.get("https://github.com/") # This works
HTTP::Client.get("https://maps.googleapis.com/") # This doesn't

I belive there might be something with the allowed cipher suites as SSLLabs Test results for maps.googleapis.com show that the root certificate is insecure.

I face this problem with some URLs. I think it depends on the version of openssl. Ruby ships with one version of openssl and that's very good: reproducible builds and behavior no matter what your system is. In Crystal we dynamically link to the openssl that's present in the system and it leads to these random and hard to reproduce problems (because we have to have your version of openssl in our machines).
I wish we could just ship Crystal with one version of openssl, one version of llvm, one version of libpcre, one version of libxml2, etc., so that everything works exactly the same everywhere...

@asterite And then what if openssl has a security bug? If we distribute our own libraries we are now distro maintainers. We have to follow the security bugs closely with a quick response, and possibly backport patches, and deal with a whole bunch of things we don'y have time to do. This is the distro maintainer's job, not ours, it's already done for us.
I've never had an openssl problem with crystal on archlinux, i've only seem people have problems on osx and on debian-based (read: ancient versions of openssl) distros.

I don't have any strong opinions on whether to bundle openssl with the compiler or not, but I think this doing VERIFY_NONE as a workaround (which is mentioned in the linked issues) here unsatisfactory.
I tried to use OpenSSL::SSL::Context::Client#add_x509_verify_flags(OpenSSL::SSL::X509VerifyFlags:: TRUSTED_FIRST) which was mentioned as a fix in a Stack Overflow issue I found yesterday. I'm unable to find it again now, but the problem I ran into was that OpenSSL::SSL::X509VerifyFlags was not defined. Seems like there's a compiler flag for that constant that wasn't set.
It seems highly related, but I'm not sure? I'm building Crystal via Homebrew. Could it be that it's missing some SSL/crypto lib while compiling? Or that the compiled bottle comes without this support?

It appears to me that openssl's API is a mess, perhaps we should implement the libtls API in C using openssl, how openssl wants us to, and then use that as the base for crystal's SSL.

The workaround here is:
context = OpenSSL::SSL::Context::Client.insecure
client = HTTP::Client.new("maps.googleapis.com", tls: context)

I'm not sure if that's a very good workaround though, as if I point the client to expired.badssl.com, I'm not getting any errors.

Hence the insecure: you basically accept whatever OpenSSL supports —I'm not even sure it verifies certificates. Would you be willing to take the Client.insecure and tweak it until you find the culprit in defaults?

@ysbaddaden Yes, we're ok with Client.insecure for now, but it doesn't seem to verify certificates. I think that should probably be noted in the documentation. Currently the docs say:

Use this only if undoing the defaults that new sets is too much hassle.

Not sure if I can spend more time at the moment looking into the defaults. I'm not very fluent in TLS terminology so I'd just have to guess what the different options represent. The failures were pretty consistent with that hostname, even when I ran it in the Docker image for 0.23.1.
I still think this is highly relevant:

I'm still getting undefined constant OpenSSL::OPENSSL_102 errors when attempting to use X509VerifyFlags.

As I believe using the OpenSSL::SSL::X509VerifyFlags:: TRUSTED_FIRST might work.

Any updates? I'm basically unable to connect to any of Google's APIs :confused:
require "http/client"
client = HTTP::Client.new(URI.parse("https://google.com"))
p client.get("/")

It raises the same certificate verify failed (OpenSSL::SSL::Error).

I am also experiencing this issue here in the context of a docker image running in lambda via up.sh: https://github.com/Sija/raven.cr/issues/47#issuecomment-520280743

Hello all;
quite new to crystal; focusing on getting the smallest docker image (so, statically building a crystal app).
Currently stuck on the issue here; I was thinking about using an intermediate to retrieve the required certs :
FROM crystallang/crystal:latest as compiler
RUN mkdir /app
COPY . /app
RUN mkdir /app/bin
WORKDIR /app
RUN shards --production
RUN crystal build /app/src/appname.cr --static --release --no-debug -o /app/bin/appname

FROM alpine as certs-builder
RUN apk update && apk upgrade && apk add --no-cache ca-certificates
RUN update-ca-certificates

FROM busybox:glibc
COPY --from=compiler /app/bin/appname .
COPY --from=certs-builder /etc/ssl/certs /etc/ssl/certs

CMD ["./appname"]

Would there be a way to achieve something similar by specifying the path to the certs in the tls context ? Or should I choose another approach ?

Hello all;
quite new to crystal; focusing on getting the smallest docker image (so, statically building a crystal app).
Currently stuck on the issue here; I was thinking about using an intermediate to retrieve the required certs :
FROM crystallang/crystal:latest as compiler
RUN mkdir /app
COPY . /app
RUN mkdir /app/bin
WORKDIR /app
RUN shards --production
RUN crystal build /app/src/appname.cr --static --release --no-debug -o /app/bin/appname

FROM alpine as certs-builder
RUN apk update && apk upgrade && apk add --no-cache ca-certificates
RUN update-ca-certificates

FROM busybox:glibc
COPY --from=compiler /app/bin/appname .
COPY --from=certs-builder /etc/ssl/certs /etc/ssl/certs

CMD ["./appname"]

Would there be a way to achieve something similar by specifying the path to the certs in the tls context ? Or should I choose another approach ?

@benbonnet The problem is statically linking is only supported in Alpine linux. See https://crystal-lang.org/reference/using_the_compiler/index.html#creating-a-statically-linked-executable and https://crystal-lang.org/2020/02/02/alpine-based-docker-images.html.

@benbonnet The problem is statically linking is only supported in Alpine linux. See https://crystal-lang.org/reference/using_the_compiler/index.html#creating-a-statically-linked-executable and https://crystal-lang.org/2020/02/02/alpine-based-docker-images.html.

@Blacksmoke16
As shown above it is first built within crystallang/crystal:latest.
On the final step; the app bin was copied through a FROM scratch in the last step.
Had to move on and use FROM busybox:glibc (otherwise it could not resolve hostnames; among other problems).
As this slight change enabled a missing capability; am in hope to find a way to just get what's needed be able to verify the certs
fully statically linked are only possible within alpine; but could the same can be achieved by picking only the needed requirements and putting those in the final image ?

@Blacksmoke16
As shown above it is first built within crystallang/crystal:latest.
On the final step; the app bin was copied through a FROM scratch in the last step.
Had to move on and use FROM busybox:glibc (otherwise it could not resolve hostnames; among other problems).
As this slight change enabled a missing capability; am in hope to find a way to just get what's needed be able to verify the certs
fully statically linked are only possible within alpine; but could the same can be achieved by picking only the needed requirements and putting those in the final image ?

@benbonnet I guess what I'm getting at is couldn't you statically link the binary in the Crystal alpine image, then move it to another smaller Alpine image and just use that?  Like I suggested in https://github.com/crystal-lang/crystal/issues/6099#issuecomment-753382863?

@benbonnet I guess what I'm getting at is couldn't you statically link the binary in the Crystal alpine image, then move it to another smaller Alpine image and just use that?  Like I suggested in https://github.com/crystal-lang/crystal/issues/6099#issuecomment-753382863?

@Blacksmoke16 well you might get a way larger image (10x maybe ?). I do know my asking is completely overkill and we would still be fine by not even building statically.
But I've been super hyped to see how the smallest image possible would reduce our pipeline deployment and functions startup (we're using cloudrun, such image cold starts in 200ms or less)

@Blacksmoke16 well you might get a way larger image (10x maybe ?). I do know my asking is completely overkill and we would still be fine by not even building statically.
But I've been super hyped to see how the smallest image possible would reduce our pipeline deployment and functions startup (we're using cloudrun, such image cold starts in 200ms or less)

@benbonnet
docker images
REPOSITORY       TAG                         IMAGE ID            CREATED             SIZE
busybox          glibc                       b0748d3617e4        9 days ago          5.21MB
alpine           3.12                        389fef711851        3 weeks ago         5.57MB

Size wise they're essentially the same, but with alpine you have a package manager and such.  Granted this is not including the size of your Crystal binary, or other dependencies you may need.

@benbonnet
docker images
REPOSITORY       TAG                         IMAGE ID            CREATED             SIZE
busybox          glibc                       b0748d3617e4        9 days ago          5.21MB
alpine           3.12                        389fef711851        3 weeks ago         5.57MB

Size wise they're essentially the same, but with alpine you have a package manager and such.  Granted this is not including the size of your Crystal binary, or other dependencies you may need.

Still failing.

What exactly is failing? Is it related to this issue or a different one? From the static linking discussion it feels like something else, which would probably fit better to https://forum.crystal-lang.org/
Not sure if dynamic linking is a factor for your issue, but when you copy a dynamically linked binary to a different system, you need to make sure it has matching dynamic libraries available.
I would strongly recommend to link fully statically (can use the alpine image for that). That causes less friction with moving between systems and should help you goal to reach minimal binary size.

Still failing.

What exactly is failing? Is it related to this issue or a different one? From the static linking discussion it feels like something else, which would probably fit better to https://forum.crystal-lang.org/
Not sure if dynamic linking is a factor for your issue, but when you copy a dynamically linked binary to a different system, you need to make sure it has matching dynamic libraries available.
I would strongly recommend to link fully statically (can use the alpine image for that). That causes less friction with moving between systems and should help you goal to reach minimal binary size.


Better error or handling when passing a str to Experiment

Experiment expects operating_conditions to be a list of strings. If you just pass a string, e.g. pybamm.Experiment("Discharge at 1C until 2.5V") you get the error ValueError: Operating conditions must contain keyword 'for' or 'until'..
We should add a check to see if operating_conditions is list of strings or a str. If it's a str we should convert to a list, if not we should raise an error (see e.g. check_input_validity for QuickPlot here).

Do we need to support both strings and lists? I see no reason why we can't require the user to always send a list(str), and just add a type hint.

Yeah, happy with that. There are lots of places in PyBaMM where we aren't checking types. There is work to address this in some places, e.g. https://github.com/pybamm-team/PyBaMM/issues/3497

Can I take this up?

Hi @prady0t, I see that you're assigned to #3524, how is that coming along?

Ah yes I'm working on it. I need a bit of assistance though (I wrote a comment about it).

I can work on two issues at once no big deal. 😸

We try to only assign new developers to 1 issue at a time. If you do end up working on this issue though, you should try the type hint approach. It would make it only a couple lines.

Okay that's totally fine 👍🏼


REQUEST: New membership for kachawla

GitHub Username
@kachawla
Requirements

[x] I have reviewed the community membership guidelines
[x] I have enabled 2FA on my GitHub account, see https://github.com/settings/security
[x] I have subscribed to the Radius community Discord server
[x] I am contributing (any of the following apply: issues, discussions, PRs, reviews) to 1 or more Radius repositories

List of contributions to the Radius project
I've been a core contributor to Radius for over two years: https://github.com/radius-project/radius/graphs/contributors. My contributions include leading design, implementation, and PR reviews across several components of the system, including but not limited to Recipes, portable resources, core applications RP, and Terraform. My contributions map to the following roles:
radius-project/radius: maintainer
radius-project/recipes: maintainer
radius-project/design-notes: maintainer
radius-project/samples and docs: approver
AB#13499

+1

+1

+1 to all.


RDKBWIFI-6: Add spatial reuse tlv handle

Can you please resolve the conflicts

The GitHub action check failed because of a OneWiFi build error, not necessarily because of your code.


Unable to define an empty sealed record

Description:
Cannot seal a record with no fields.
Steps to reproduce:
public type ExposeConfig record {||};

Output:
error: ballerinax/docker:0.0.0::annotation.bal:71:34: invalid token '||'
Affected Versions:
0.990.4-SNAPSHOT
OS, DB, other environment details and versions:
MAC

The above works when there's a space between {| and |}. I'm not sure whether we should support {||}.


creating different android manifest for flavors versions

how can make  diffrent android manifest for flavors versions with different android permissions ?

Hi @kiaxseventh , you have to do it manually after running the process.
https://developer.android.com/studio/build/manifest-merge.html


OC-4050 hide contact picture container on small screens

Fix the enquire now form to hide the image next to the form on smaller screens.
Reviewers:

[ ] @itsjeyd

@itsjeyd  Removed, and merged!


PR to fix a logical error

Takes care of generating a job list file using the main bash script in the nonsequential_maxarray example.

@joseph-cooke & @visionjo, please take a look and let me know if it worked this time. There was a logical error in Exercise_nonsequential_maxarray that has been corrected, thanks to @visionjo.
I would like to merge it asap so that Bootcamp attendees get access to the updated material.

Thanks @joseph-cooke for checking this so promptly!


Can't create zulip client using Python

I am trying to create zulip client like
import zulip

client = zulip.Client(config_file="zuliprc")

but got
AttributeError: module 'zulip' has no attribute 'Client'

It happens even if I remove zulip package with pip. It don't even starts to interpret zulip/__init__.py according to debugger. I am using Python 3.6

Do you by any chance have a module called zulip in your project?  That could be masking the actual zulip in your Python path.
(As a sidenote, this issue belongs in http://github.com/zulip/python-zulip-api/issues/)

rename file


Update nlu.yml

added few new examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


MODOAIPMH-251: Release 3.2.2 version mod-oai-pmh

As I mentioned before, it would have been good if these procedures were followed:https://dev.folio.org/guidelines/release-procedures/

It is usually suggested to increment to the next minor version not bugfix versions
There is no description in the PR
Add everyone from the team for the PR review
There is no changelog
The tag is incorrect in the pom.xml


Is it possible to destroy session on deserialization issue?

Redisson version: 3.12.1
We have the next situation:
Sometimes we update some of our entities that stored in a session.
After that we get a lot of exceptions in log:
org.redisson.client.RedisException: Unexpected exception while processing command
--
at org.redisson.command.CommandAsyncService.convertException(CommandAsyncService.java:401)
at org.redisson.command.CommandAsyncService.get(CommandAsyncService.java:205)
at org.redisson.RedissonObject.get(RedissonObject.java:94)
at org.redisson.RedissonMap.readAllMap(RedissonMap.java:507)
at org.redisson.tomcat.RedissonSession.getAttribute(RedissonSession.java:111)
...
Caused by: java.io.InvalidClassException: com.SomeEntity; local class incompatible: stream classdesc serialVersionUID = 123, local class serialVersionUID = 321

We catch this exception when we trying to get some client session parameters.
And it looks strange because the client already in the authorized zone and have a session, but actually session is invalid, so is it possible to invalidate session on deserialization?

Yes, I forgot to notice, we use org.redisson.codec.SerializationCodec and can't use JSON-like codes, because we have some recursion links.

Please do it with Valve object rather than suggesting patch

@mrniko hi, we can do it. So currently we built own wrapper above your session manager with these changes.

You could add one Valve object and invalidete session in org.redisson.tomcat.Valve#invoke method

I think that org.apache.catalina.valves.RequestFilterValve looks better in this case. But the whole solution looks like a crutch because we just have to request any attribute and deny the request on any exception.
Also, in this case, we have to integrate redisson with our app, currently, we don't use redisson in it. Except for the tiny library that fixed this issue.


Shared terminal is significantly slower than SSH

Compared to SSH, a shared terminal is significantly slower; ncurses-based applications (ie, tmux) are mostly unusable.

@jacobdufault Hey! We've got #307 tracking the general issue with full-size applications, along with other terminal nuances. However, we haven't heard feedback about performance. Are you only seeing this with ncurses-based apps, or with all uses of the terminal (e.g. running basic commands like ls, running tests)?

@jacobdufault what client are you using, VS or VSCode? If it is VS, do you run shared terminal integrated in VS, or external? For full-screen, output-rich applications, external terminal in VS will provide better experience.

This is using vscode; I think terminal resize is unrelated. Even a command like ls is very slow; does live-share go through a network proxy? I'm connecting to my machine at work from my machine at home; the network at work is likely heavily restricted as well.

If there are some diagnostics/etc I can upload happy to do so.

The host is debian, the client is macos. I played with connection mode, and only "relay" works, so I suspect this is latency introduced by the relay.
Re co-editing, yes, there is some latency, but it is not as noticeable compared to remote desktop. Typing in SSH normally is somewhat slow, but tolerable - the shared terminal is too slow to be usable. I'm guessing the problem is just a high-latency low-throughput relay.
I should say that I'm not really using "co-editing", so much as starting a session at work and connecting to it myself so I can use vscode with a remote workspace.

May be related to #367. Shared terminals and shared servers use same stream mechanisms under the cover.

@jacobdufault Hey! We'll likely ship this update later this week, but in the meantime, here's a private build that includes some perf improvements for shared terminals. I'd love to hear whether this makes a noticeable (enough) difference for your use case 😄

Thanks - I'll give it a try tonight or tomorrow.

To take advantage of the changes in the private bits, both guest and host must be updated. If any is not updated, we'll fall back to old, slow, back compat way.

@jacobdufault We just released an update to the marketplace that improves the performance of shared terminals, and should significantly improve the usability for you. Could you update it and give it a try?

Sure, the performance has definitely improved but it looks like the terminal encoding/emulator is still buggy (ie, the control characters are not honored correctly, which makes programs like tmux or fzf render incorrectly).

@jacobdufault That's great to hear! The control characters is a separate issue, that we're also working on. I just wanted to check whether the perf improvements were meaningful enough.

@jacobdufault I'm going to resolve this issue, since it sounds like the performance improvements have been addressed, and we're tracking the work to resolve the terminal resizing (#307) and control characters (#306) with existing issues (we're actively working on those right now!).
Please feel free to re-open this if you think the perf improvements aren't sufficient enough, and we can continue to explore that. Thanks again for your feedback!


Upgrade policy evaluation script to support domestic standing order

Description

Add the implementation to support Domestic standing order intent here
Validate the request object with IDM object: domesticStandingOrdersPaymentIntent, see initiation match method

Acceptance criteria

[ ] The policy evaluation script is deployed on am with no errors
[ ] The current functional tests pass ( to check nothin is broken with that changes)

Hey team! Please add your planning poker estimate with ZenHub @andra-racovita @mariantiris


fix: test refactored release-please

Issue
This is just a test of the refactored release-please workflow
Description
just a test - please ignore

lgtm


Regenerate intrinsics

I fixed the issue in the CI: please rebase on the master branch.

Done!

Thanks!


Vulnerability of tough-cookie 2.3.2 bundled with package.

Good morning,
I am using fsevent version 1.1.2 with NodeJS 6.9.x and a simplified dependency tree looks like this:
┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ │ │ ├─┬<EMAIL_ADDRESS>
The problem comes from the version of tough-cookie. There is a vulnerability in tough-cookie version 2.3.2: https://github.com/salesforce/tough-cookie/issues/92. This vulnerability was fixed in 2.3.3 by https://github.com/salesforce/tough-cookie/pull/97.
The Whitesource software flags my application because of this vulnerability.
I don't know why node-pre-gyp is bundled with the package, but I'm pretty sure you have a reason for it so I will not ask to get a clean fsevents package, without bundledDependencies. But, would it be possible to re-publish a version of fsevents with a later version of node-pre-gyp bundled with it ? This will result into a later version of request which will result in version 2.3.3 of `tough-cookie'.
Thanks.

Updating node-pre-gyp (or rather: request) might be problematic because of request/request#2772.
It might be possible to move node-pre-gyp to devDependencies (see https://github.com/strongloop/fsevents/issues/157#issuecomment-333326855) but I'm somewhat wary to merge that and discover I broke all of npm.

Wow ! Was not aware of this thread on request. This is a big conundrum.
A possible solution would to increase fsevent to version 2.0.0 and support only Node 4/6/8+ ( dealer's choice ). But this is a major step and I can understand that with 90k+ downloads a day, there is some hesitation on doing that, just as the owner of request is reticent of doing it.
Well... I guess we are at an impasse on that one. I can understand that wholeheartedly.
Since most of the code we develop in our team are ultimately servers we deploy on CentOS, I guess I can live with the vulnerability. The problem would come when people on MacOS X start using my package in their projects which might be ultimately deployed on MacOS X. I guess these other teams can do their own security analysis then and decide on their strategy.
I will not close this issue because I still think it is a valid one, but will stop pushing it.

Doesn't<EMAIL_ADDRESS>depend on "tough-cookie": "~2.3.0" (https://github.com/request/request/blob/v2.81.0/package.json#L49), and so doesn't that already permit<EMAIL_ADDRESS>

The problem I think is node-pre-gyp that depends on<EMAIL_ADDRESS>https://github.com/mapbox/node-pre-gyp/blob/v0.6.36/package.json#L27

<EMAIL_ADDRESS>also points to<EMAIL_ADDRESS>It looks like the latest points to<EMAIL_ADDRESS>which would solve this problem.
We should cut a 1.1.4 branch so solve this problem.
Anyone using watchpack right now will be opened up to this vulnerability:
├─┬<EMAIL_ADDRESS>│ ├─┬<EMAIL_ADDRESS>│ │ ├─┬<EMAIL_ADDRESS>│ │ │ └─┬<EMAIL_ADDRESS>

Resolved in v1.2.0


feat(overlay): Ensure overlays are passed as a list to the js function

The javascript in inst/htmlwidgets/bpmnVisualization.js is expecting a list of overlays (l.29)
-> If the user passes a single overlay to the function it fails silently (It looks complicated to log errors from the JS in R).
So I added a small step to 'sanitize' the overlays in input: If the input is a list of overlays we do not touch it, else we wrap the single overlay into a list.
In the following example, the two calls to display work correctly. Previously, only the last one would have worked.
bpmn_file <- system.file("examples/Email_Voting.bpmn", package = "bpmnVisualization")
overlay <- create_overlay("user_task_1", "Hello")
display(bpmn_file, overlay)
display(bpmn_file, list(overlay))

closes #32

I tested manually with:

display(bpmn_file, overlay)
The diagram with the overlay is well displayed.

display(bpmn_file, list(overlay))
The diagram with the overlay is well displayed.


Surveyor View: Dropdown after Map generate not showing correct fields (“undefined”)

Fixed with JSON server data.


hal_nordic: integrate nrf_802154 component into hal_nordic

This PR provides new integration scheme for nRF IEEE 802.15.4 radio driver.
Upstream PR: zephyrproject-rtos/zephyr#33500
Signed-off-by: Rafał Kuźnia<EMAIL_ADDRESS>

I am unable to remove people unrelated to this PR from reviewers. If you are not @carlescufi or @tejlmand then please disregard this PR.

@e-rk rebase?

@nvlsianpu I will rebase once https://github.com/nrfconnect/sdk-zephyr/pull/479 is merged. I depend on some content from that PR.

Rebased on latest master.

Converted commits to fromtree, since https://github.com/zephyrproject-rtos/zephyr/pull/33500 was merged.


Updated SpineGameObject type definition

This PR

Fixes a bug

Describe the changes below:
The type exposed in the definition file does not correspond to the source code, which makes it incompatible. This commit fixes that.

👍


How to set a sub sub-domain in the Domain management console

Before opening, please confirm:

[X] I have checked the custom domains troubleshooting guide.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d3ta305xte59t6
Region
eu-central-1
Step
Domain management
Status
Failed
Issue or question
Hi,
we are working through multi environments, with several Amplify Apps
(Dev / Test / Stagging + one environment per client : prod01 / prod02 / ...)
Each environement app shared the same ressources like Cognito User Pool.
For cross authentication needs we are using cookies to share auth tokens.
For the moment our domain configuration is like that:
https://<env>-<app>.ourdomain.com (our domain is registered through AWS Route 53)
But to improve our cookies security we want to update our configuration domain to :
https://<app>.<env>.ourdomain.com  (and manage our cookies at this level .<env>.ourdomain.com
When we try in the amplify console to set up our subdomain like :  <app>.<env>  we got this issue:

How can we manage this configuration ?
thank you for your help,
Error message
No response
Additional information
No response

Hi @julienlaurent-migso 👋🏽 did you try following the steps to set up a multilevel subdomain? You'd want to add <env>.yourdomain.com as a domain and exclude the root. You would then add <app>. as a subdomain. Here are the instructions to do so: https://docs.aws.amazon.com/amplify/latest/userguide/to-manage-subdomains.html#to-add-a-multi-level-subdomain. Please let us know if these steps work for you.

Thank you for providing further clarification. You can share cookies across subdomains within an app but not across multiple apps because a CNAME can only resolve to one distribution. Each custom domain is connected to its own CloudFront distribution and there is no way to associate a domain with multiple distributions.

Hi @hloriana,
I am not agree with you, we can share cookies between all apps carried by the same domain.
I am actually doing this thing to be able to share token authentication accross my Amplify Apps.
See below my amplify app:

For each app i have defined a related sub domain for each environment:
My domains for TLG:

My domains for CORE:

Same logic for all my apps...
And my need is to be able to set my domains like that:

domain : .mydomain.com
subdomain : environmentName.mydomain.com
sub-subdomain : appName.environmentName.mydomain.com

Like that:

How can i manage my domains like that ? thank you

@hloriana any update on this subject ?

Hi @julienlaurent-migso, thank you for your continued patience and apologies for the delayed response on this issue.
Here is a solution that you can consider using for your use-case. You will need to attach 4 domains (each with 1 subdomain) to your app as follows:
Amplify App 1

Domain: env1.mydomain.com
Subdomain: app1.env1.mydomain.com

Amplify App 1

Domain: env2.mydomain.com
Subdomain: app1.env2.mydomain.com

Amplify App 2

Domain: env1.mydomain.com
Subdomain: app2.env1.mydomain.com

Domain: env2.mydomain.com
Subdomain: app2.env2.mydomain.com

and so on...


doesn't work with translatable on 3.1

Hi, on SS 3.1 with the translatable module you have to enter the locale to the URL manualy to make the fileupload work properly. E.g. &locale=en_GB
The link for the "add" button looks like:
http://www.XXX.de/admin/pages/adddocument?ID=45
http://www.XXX.de/admin/pages/adddocument?ID=45&locale=en_GB
Greetings, Carsten.

For me the add button works and is formatted this way :
http://www.XXX.de/admin/pages/adddocument/?Locale=en_GB&ID=61
The back button didn't work though,
I replaced line 166 in DMSDocumentAddController.php with :
return Controller::join_links(singleton('CMSPagesController')->Link(), 'edit/show/'.$pageID);
instead of:
return singleton('CMSPagesController')->Link().'edit/show/'.$pageID;

can be closed, #82 merged.


add setter func for mux pool conn num

Codecov Report

Merging #1531 (d951b91) into develop (a520ff2) will increase coverage by 0.08%.
The diff coverage is 85.03%.

@@             Coverage Diff             @@
##           develop    #1531      +/-   ##
===========================================
+ Coverage    58.98%   59.06%   +0.08%
===========================================
  Files          334      337       +3
  Lines        26974    27049      +75
===========================================
+ Hits         15910    15977      +67
- Misses        9287     9292       +5
- Partials      1777     1780       +3

Impacted Files
Coverage Δ

pkg/network/connection.go
37.16% <0.00%> (-4.45%)
:arrow_down:

pkg/stream/xprotocol/connpool_multiplex.go
52.63% <0.00%> (-0.31%)
:arrow_down:

pkg/config/v2/server.go
67.44% <50.00%> (ø)

pkg/upstream/cluster/cluster_manager.go
59.90% <77.77%> (+1.98%)
:arrow_up:

pkg/track/track.go
86.53% <86.53%> (ø)

pkg/stream/xprotocol/conn.go
36.84% <87.50%> (+1.25%)
:arrow_up:

pkg/track/buffer.go
90.90% <90.90%> (ø)

pkg/mosn/starter.go
54.30% <100.00%> (+0.30%)
:arrow_up:

pkg/proxy/downstream.go
47.87% <100.00%> (+0.88%)
:arrow_up:

pkg/stream/xprotocol/stream.go
31.14% <100.00%> (+3.56%)
:arrow_up:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac68cb1...d951b91. Read the comment docs.


Logger won't build

Trying to install this however at the docker-compose stage it fails with the following error:
Building logger
Step 1/8 : FROM golang:alpine AS build-env
 ---> d1ded2c82210
Step 2/8 : RUN apk --no-cache add build-base git mercurial gcc
 ---> Using cache
 ---> 89c39c9a453f
Step 3/8 : ADD . /src
 ---> Using cache
 ---> 7057a672263f
Step 4/8 : RUN cd /src && go mod init orl-logger && go build -o orl-logger
 ---> Running in 6f2f8dbf69b5
go: creating new go.mod: module orl-logger
go: to add module requirements and sums:
        go mod tidy
chatlog.go:11:2: no required module provides package github.com/MemeLabs/overrustlelogs/common; to add it:
        go get github.com/MemeLabs/overrustlelogs/common
chatlog.go:10:2: no required module provides package github.com/hashicorp/golang-lru; to add it:
        go get github.com/hashicorp/golang-lru
ERROR: Service 'logger' failed to build: The command '/bin/sh -c cd /src && go mod init orl-logger && go build -o orl-logger' returned a non-zero code: 1

Ubuntu 18.04 LTS and 20.04 LTS

Hi @TheD1ceM4n,
a fix has been pushed, please feel free to reopen if you are still experiencing an issue.


ansible-role specified does not exist as a git repo

https://github.com/Duffney/becomeansible/blob/54de10742a97937099a1feaf1555d02b0501fdda/chapter-08/roles/requirements.yml#L1
Did you forget to decouple it?

I had forgotten to update the git URL... Thanks for pointing that out.
The full story is I originally plan on doing some choco for business roles. But I accidentally created a public repo with the license which was bad. In my haste, I didn't clean everything up.
I appreciate you taking the time to open the issue.
It's now fixed with https://github.com/Duffney/becomeansible/commit/ab246cc7e4e8c914b717003888e2dea04d26ae6b

I had forgotten to update the git URL... Thanks for pointing that out.
The full story is I originally plan on doing some choco for business roles. But I accidentally created a public repo with the license which was bad. In my haste, I didn't clean everything up.
I appreciate you taking the time to open the issue.
It's now fixed with https://github.com/Duffney/becomeansible/commit/ab246cc7e4e8c914b717003888e2dea04d26ae6b


Overloading of method

FYI: I mentioned to Austin that there's an overloading of this method that accepts java.lang.Iterable<Key> as parameter, so you could remove all those values with a single call, but that would involve casting results.asIterable() into java.lang.Iterable<Key> (stream().map() is a neat way of doing that), but that might be too much work here and end up being not worth it.
Originally posted by @gbuenoandrade in https://github.com/tttzach/step/pull/30

.stream() does not work with Iterable<Entity>


WIP : Adds basic support for Gitpod and doc

Try https://gitpod.io/#github.com/adyen-examples/checkoutCreate/tree/feat/gitpod to see what it's doing (after following the steps in the README :))


New ENV parameters for customizing OpenVPN TCP and UDP subnets

Added a feature to customize OpenVPN TCP and UDP subnets in the container environment variables (ENV), to resolve conflicts with client network settings caused by the default values (<IP_ADDRESS>/22 and <IP_ADDRESS>/22).

There WIP branch to move openvpn to external container: https://github.com/xtrime-ru/antizapret-vpn-docker/tree/openvp-move-to-container.


Repeated Python calls of cyber_time.Time.now() results in a segmentation fault

Describe the bug
Repeated Python calls of cyber_time.Time.now() results in a segmentation fault. The error occurs after a finite number of calls determinable at runtime. The fault creates a core dump in data/core/. The cause may be a deallocation error in the Python cyber_time wrapper.
To Reproduce
Steps to reproduce the behavior:

Create a python script and import cyber_time: from cyber_py import cyber_time
Make repeated calls to cyber_time.Time.now().

The following script can reproduce the behavior:
from cyber_py import cyber_time
import time

while True:
    time.sleep(0.001)
    print(“cyber_time: “ + str(cyber_time.Time.now()))

The last lines of the output are something to the effect of:
…
cyber_time:<PHONE_NUMBER>155302888
cyber_time:<PHONE_NUMBER>156467792
cyber_time:<PHONE_NUMBER>157638705
cyber_time:<PHONE_NUMBER>158858018
cyber_time:<PHONE_NUMBER>160047689
cyber_time:<PHONE_NUMBER>161237213
cyber_time:<PHONE_NUMBER>162425895
cyber_time:<PHONE_NUMBER>163574659
cyber_time:<PHONE_NUMBER>164752927
cyber_time:<PHONE_NUMBER>165900939
cyber_time:<PHONE_NUMBER>167094610
cyber_time:<PHONE_NUMBER>168243628
cyber_time:<PHONE_NUMBER>169396087
cyber_time:<PHONE_NUMBER>170542029
Fatal Python error: deallocating None
Aborted (core dumped)

Expected behavior
The cyber_time.Time.now() as described should be used to provide timestamps for Cyber RT messages written via the cyber_py library and should not result in a segmentation fault despite repeated calls.
Screenshots
Screenshot 1:
An execution of the above script with python-dbg:

Desktop

OS: Ubuntu 16.04

Additional context
The error occurs whether or not the suffix .to_sec() or .to_nsec() is included.
The while loop above can be modified to demonstrate the deallocation issue:
from cyber_py import cyber_time
import time
import sys

while True:
    time.sleep(0.001)
    print(“cyber_time: “ + str(cyber_time.Time.now()))
    print(“refcount to None: “ + str(sys.getrefcount(None)))

@berthu Thank you for your question. We reviewed it as quickly as possible. The problem is caused by a reference count that has been fixed by commit #8215. Thanks again.

Closing this issue as it appears to be resolved. Feel free to reopen if you have additional questions. Thanks!


Don't work with react-scripts and vite

With react scripts I get this error:

Attempted import error: 'cosmos' is not exported from 'interchain' (imported as 'cosmos').
WARNING in ./node_modules/interchain/dist/index.mjs
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '../node_modules/interchain/src/index.ts' file: Error: ENOENT: no such file or directory, open '../node_modules/interchain/src/index.ts'
ERROR in ./src/index.tsx 39:12-18
export 'cosmos' (imported as 'cosmos') was not found in 'interchain' (module has no exports)
ERROR in ./node_modules/interchain/dist/index.mjs 1:0-26
Module not found: Error: Can't resolve './codegen' in '../node_modules/interchain/dist'
Did you mean 'index.mjs'?
BREAKING CHANGE: The request './codegen' failed to resolve only because it was resolved as fully specified
(probably because the origin is strict EcmaScript Module, e. g. a module with javascript mimetype, a '.mjs' file, or a '.js' file where the package.json contains '"type": "module"').
The extension in the request is mandatory for it to be fully specified.
Add the extension to the request.

With vite:
Safari:
`SyntaxError: Importing binding name 'cosmos' is not found.
Chrome:

Uncaught SyntaxError: The requested module '/node_modules/.vite/deps/interchain.js?v=0a96d252' does not provide an export named 'cosmos'

Last version which highlighted in IDE is 1.8.8, but it's not working.
Last version which I could run is 1.7.0.
How I can run 1.10.1?

same proplem