make clean images failing

When running make images the build is failing,
I've raised this to have a better understanding of the problem and possible fixes.
I tried to change the build to use ubuntu precise instead, and its now throwing this error:
vagrant@adoptopenjdk:/vagrant/sources/jdk9$ make clean images ;
Compiling 5 files for BUILD_GENMODULESLIST
Building targets 'clean images' in configuration 'linux-x86_64-normal-server-release'
Cleaning hotspot build artifacts ... done
Cleaning jdk build artifacts ... done
Cleaning bootcycle-build build artifacts ... done
Cleaning test build artifacts ... done
Cleaning buildtools build artifacts ... done
Cleaning support build artifacts ... done
Cleaning images build artifacts ... done
Cleaning make-support build artifacts ... done
Cleaning test-make build artifacts ... done
Cleaning bundles build artifacts ... done
Cleaned all build artifacts.
Compiling 5 files for BUILD_GENMODULESLIST
Compiling 8 files for BUILD_TOOLS_LANGTOOLS
Compiling 16 properties into resource bundles for jdk.compiler
Parsing 1 properties into enum-like class for jdk.compiler
Compiling 10 properties into resource bundles for jdk.javadoc
Compiling 9 properties into resource bundles for jdk.jdeps
Compiling 830 files for BUILD_INTERIM_LANGTOOLS
Creating buildtools/interim_langtools.jar
Compiling 23 files for BUILD_INTERIM_JIMAGE
Compiling 161 files for BUILD_TOOLS_JDK
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Creating sun/util/locale/provider/EnLocaleDataMetaInfo.java from 424 found resources.
Generating sun/misc/Version.java
Creating genSocketOptionRegistry from 1 file(s)
Creating genUnixConstants from 1 file(s)
Generating buffer classes
Generating exceptions classes
Compiling 11 properties into resource bundles for java.base
Compiling 22 properties into resource bundles for java.base
Generating icon classes
Generating X11 wrapper (64-bit version)
Verifying /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/support/gensrc/java.desktop/_x11wrappers/sizes.64.verification.tmp to /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/support/gensrc/java.desktop/_x11wrappers/sizes.64
Generating beaninfo
Generating Nimbus source files
Compiling 100 properties into resource bundles for java.desktop
Compiling 2777 files for java.base
Compiling 1815 files for java.xml
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Compiling 13 files for java.prefs
Compiling 16 files for java.datatransfer
Compiling 11 properties into resource bundles for java.logging
Compiling 32 files for java.logging
Compiling 2749 files for java.desktop
Compiling 24 files for java.activation
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Compiling 5 files for java.annotations.common
Compiling 4 files for BUILD_BREAKITERATOR
Generating blacklisted certs
Creating support/jce/policy/unlimited/US_export_policy.jar
Creating support/jce/policy/limited/local_policy.jar
Creating support/jce/policy/unlimited/local_policy.jar
Generating java.security
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Warning: generation and use of skeletons and static stubs for JRMP
is deprecated. Skeletons are unnecessary, and static stubs have
been superseded by dynamically generated stubs. Users are
encouraged to migrate away from using rmic to generate skeletons and static
stubs. See the documentation for java.rmi.server.UnicastRemoteObject.

All done.
Generating linux_amd64_docs/jvmti.html
Creating libverify.so from 2 file(s)
Creating libjava.so from 61 file(s)
Creating libfdlibm.a from 62 file(s)
Creating libzip.so from 21 file(s)
Creating libjli.so from 15 file(s)
Creating libnet.so from 21 file(s)
Creating libnio.so from 25 file(s)
Creating java from 1 file(s)
Creating keytool from 1 file(s)
Creating jexec from 1 file(s)
Compiling 114 files for java.compiler
Compiling 141 files for BUILD_IDLJ
Note: /vagrant/sources/jdk9/corba/src/java.corba/share/classes/com/sun/tools/corba/se/idl/som/idlemit/MetaPragma.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Compiling 6 files for BUILD_TOOLS_CORBA
Compiling 133 files for java.rmi
Compiling 3 files for java.transaction
Compiling 29 files for java.security.sasl
Compiling 192 files for java.naming
Compiling 1480 files for java.corba
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Creating idlj from 1 file(s)
Creating orbd from 1 file(s)
Creating servertool from 1 file(s)
Creating tnameserv from 1 file(s)
Generating HTML DTD file
[Parsed DTD html32 in 123ms]
Creating libmlib_image.so from 55 file(s)
Creating libawt.so from 72 file(s)
Creating libawt_xawt.so from 53 file(s)
/vagrant/sources/jdk9/jdk/src/java.desktop/unix/native/common/awt/awt_Font.c: In function ‘awtJNI_GetFontData’:
/vagrant/sources/jdk9/jdk/src/java.desktop/unix/native/common/awt/awt_Font.c:641:23: warning: comparison between pointer and integer
             if (xfont == (Font) NULL || xfont->ascent < 0) {
                       ^
/vagrant/sources/jdk9/jdk/src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c:69:0: warning: "MIN" redefined
 #define MIN(a, b)  (((a) < (b)) ? (a) : (b))
 ^
In file included from /vagrant/sources/jdk9/jdk/src/java.base/unix/native/include/jvm_md.h:35:0,
                 from /vagrant/sources/jdk9/jdk/src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c:33:
/usr/include/x86_64-linux-gnu/sys/param.h:99:0: note: this is the location of the previous definition
 #define MIN(a,b) (((a)<(b))?(a):(b))
 ^
Creating liblcms.so from 26 file(s)
Creating libjavajpeg.so from 46 file(s)
Creating libawt_headless.so from 26 file(s)
Creating libfontmanager.so from 94 file(s)
cc1: warning: command line option ‘-Wno-reorder’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-delete-non-virtual-dtor’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-reorder’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-delete-non-virtual-dtor’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-reorder’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-delete-non-virtual-dtor’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-reorder’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-delete-non-virtual-dtor’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-reorder’ is valid for C++/ObjC++ but not for C
cc1: warning: command line option ‘-Wno-delete-non-virtual-dtor’ is valid for C++/ObjC++ but not for C
/vagrant/sources/jdk9/jdk/src/java.desktop/share/native/libfontmanager/sunFont.c: In function ‘freeLayoutTableCache’:
/vagrant/sources/jdk9/jdk/src/java.desktop/share/native/libfontmanager/sunFont.c:357:37: warning: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type
       if(ltc->entries[i].ptr) free (ltc->entries[i].ptr);
                                     ^
In file included from /vagrant/sources/jdk9/jdk/src/java.desktop/share/native/libfontmanager/sunFont.c:26:0:
/usr/include/stdlib.h:483:13: note: expected ‘void *’ but argument is of type ‘const void *’
 extern void free (void *__ptr) __THROW;
             ^
Creating libjawt.so from 1 file(s)
Creating libsplashscreen.so from 84 file(s)
/vagrant/sources/jdk9/jdk/src/java.desktop/share/native/libsplashscreen/splashscreen_png.c: In function ‘SplashDecodePng’:
/vagrant/sources/jdk9/jdk/src/java.desktop/share/native/libsplashscreen/splashscreen_png.c:51:16: error: variable ‘row_pointers’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
     png_bytepp row_pointers = NULL;
                ^
/vagrant/sources/jdk9/jdk/src/java.desktop/share/native/libsplashscreen/splashscreen_png.c:52:15: error: variable ‘image_data’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered]
     png_bytep image_data = NULL;
               ^
cc1: all warnings being treated as errors
Awt2dLibraries.gmk:879: recipe for target '/vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/support/native/java.desktop/libsplashscreen/splashscreen_png.o' failed
make[3]: *** [/vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/support/native/java.desktop/libsplashscreen/splashscreen_png.o] Error 1
make/Main.gmk:168: recipe for target 'java.desktop-libs' failed
make[2]: *** [java.desktop-libs] Error 1

ERROR: Build failed for targets 'clean images' in configuration 'linux-x86_64-normal-server-release' (exit code 2)
Hint: If caused by a warning, try configure --disable-warnings-as-errors

/vagrant/sources/jdk9/make/Init.gmk:255: recipe for target 'main' failed
make[1]: *** [main] Error 1
/vagrant/sources/jdk9/make/Init.gmk:171: recipe for target 'clean' failed
make: *** [clean] Error 2

Got it working after updating to ubuntu 12 and changing the build to disable warning as errors, will submit pull request

Access verification succeeded.
make[3]: Leaving directory '/vagrant/sources/jdk9/make'
## Finished verify-modules (build time 00:04:12)

make[2]: Leaving directory '/vagrant/sources/jdk9'
[ -f /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/javacservers/server.port ] && /bin/echo Stopping sjavac server && /usr/bin/touch /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/javacservers/server.port.stop; true
/bin/date '+%Y %m %d %H %M %S' | /usr/bin/nawk '{ print $1,$2,$3,$4,$5,$6,($4*3600+$5*60+$6) }' > /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_end_TOTAL
/bin/date '+%Y-%m-%d %H:%M:%S' > /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_end_TOTAL_human_readable
/bin/echo `/bin/cat /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_start_TOTAL` `/bin/cat /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_end_TOTAL` TOTAL | /usr/bin/nawk '{ F=$7; T=$14; if (F > T) { T+=3600*24 }; D=T-F; H=int(D/3600); M=int((D-H*3600)/60); S=D-H*3600-M*60; printf("%02d:%02d:%02d %s\n",H,M,S,$15); }' > /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_diff_TOTAL
/bin/bash /vagrant/sources/jdk9/common/bin/logger.sh /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/build.log /usr/bin/printf  -- "----- Build times -------\nStart %s\nEnd   %s\n%s\n%s\n-------------------------\n" "`/bin/cat /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_start_TOTAL_human_readable`" "`/bin/cat /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_end_TOTAL_human_readable`" "`/bin/ls /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_diff_* | /bin/grep -v _TOTAL | /usr/bin/xargs /bin/cat | /usr/bin/sort -k 2`" "`/bin/cat /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/make-support/build-times/build_time_diff_TOTAL`"
----- Build times -------
Start 2015-06-13 17:07:48
End   2015-06-13 19:27:32
00:04:12 verify-modules
02:19:44 TOTAL
-------------------------
/bin/bash /vagrant/sources/jdk9/common/bin/logger.sh /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/build.log /usr/bin/printf "Finished building targets 'clean images' in configuration 'linux-x86_64-normal-server-release'\n"
Finished building targets 'clean images' in configuration 'linux-x86_64-normal-server-release'
make[1]: Leaving directory '/vagrant/sources/jdk9'

Thast good work - the disable warning as errors flag is a hit or miss, but our problem must have been the Ubuntu base box.
Good work and thanks for fixing this issue.

This is still failing, see:
Compiling 836 files for BUILD_INTERIM_LANGTOOLS
( /usr/lib/jvm/java-8-openjdk-amd64/bin/javac -XDignore.symbol.file=true -g -Xlint:all,-deprecation -Werror   -implicit:none -d /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/buildtools/langtools_interim_classes  @/vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/buildtools/langtools_interim_classes/_the.BUILD_INTERIM_LANGTOOLS_batch.tmp && /bin/mv /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/buildtools/langtools_interim_classes/_the.BUILD_INTERIM_LANGTOOLS_batch.tmp /vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/buildtools/langtools_interim_classes/_the.BUILD_INTERIM_LANGTOOLS_batch)
/vagrant/sources/jdk9/langtools/src/jdk.compiler/share/classes/com/sun/tools/sjavac/PubApiExtractor.java:81: error: constructor PubapiVisitor in class PubapiVisitor cannot be applied to given types;
        PubapiVisitor v = new PubapiVisitor();
                          ^
  required: StringBuffer
  found: no arguments
  reason: actual and formal argument lists differ in length
/vagrant/sources/jdk9/langtools/src/jdk.compiler/share/classes/com/sun/tools/sjavac/PubApiExtractor.java:83: error: cannot find symbol
        return v.getCollectedPubApi();
                ^
  symbol:   method getCollectedPubApi()
  location: variable v of type PubapiVisitor
/vagrant/sources/jdk9/langtools/src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/PubAPIs.java:104: error: constructor PubapiVisitor in class PubapiVisitor cannot be applied to given types;
        PubapiVisitor v = new PubapiVisitor();
                          ^
  required: StringBuffer
  found: no arguments
  reason: actual and formal argument lists differ in length
/vagrant/sources/jdk9/langtools/src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/PubAPIs.java:106: error: cannot find symbol
        publicApiPerClass.put((ClassSymbol) e, v.getCollectedPubApi());
                                                ^
  symbol:   method getCollectedPubApi()
  location: variable v of type PubapiVisitor
/vagrant/sources/jdk9/langtools/src/jdk.compiler/share/classes/com/sun/tools/sjavac/comp/dependencies/NewDependencyCollector.java:128: error: cannot find symbol
            String depPkg = Util.pkgNameOfClassName(fqDep);
                                ^
  symbol:   method pkgNameOfClassName(String)
  location: class Util
5 errors
make[3]: *** [/vagrant/sources/jdk9/build/linux-x86_64-normal-server-release/buildtools/langtools_interim_classes/_the.BUILD_INTERIM_LANGTOOLS_batch] Error 1
make[3]: Leaving directory `/vagrant/sources/jdk9/langtools/make'
make[2]: *** [interim-langtools] Error 1
make[2]: Leaving directory `/vagrant/sources/jdk9'

ERROR: Build failed for target 'images' in configuration 'linux-x86_64-normal-server-release' (exit code 2)
Hint: If caused by a warning, try configure --disable-warnings-as-errors

make[1]: *** [main] Error 1
make[1]: Leaving directory `/vagrant/sources/jdk9'
make: *** [images] Error 2

I have now zapped the files and re-running it all over again with the the disable warning as errors flag and LOG=debug flags.

This issue is long resolved.


Assert failing in WebSocketProvider.connect after repo.find

This reproduces the problem every time for me:
func testFind() async throws {
    let repo = Repo(sharePolicy: SharePolicy.agreeable)
    let websocket = WebSocketProvider(.init(reconnectOnError: false, loggingAt: .tracing))
    await repo.addNetworkAdapter(adapter: websocket)
    try await websocket.connect(to: URL(string: "wss://sync.automerge.org/")!)
    try await repo.find(id: .init())
}

The assert failure is in WebSocketProvider.connect at assert(peeredCopy == false).

Now I'm severly confused. I've got a PR that resolves the assertion failure, but as I'm testing it - with an equivalent bit of code for the pending PR (#85) that previously worked for me - now i'm very unclear on what the expected behavior is.
I'm feeling like I'm missing something here, big time. Not sure what the difference was, and I've tested against a local instance of Automerge-repo-sync-server as well as the current sync.automerge.org service.
@jessegrosjean look through the integration test I added in #93, and verify for me that it jives with what you're using - a variation of this bug with some explicit assertions embedded in it.

Actually, I have a theory about this. On the walk home, I remembered that in earlier work I filed an issue about getting first an "Unavailable" message from the remote server, followed by a sync request with content. I don't believe that's changed, but I may be calling the document "resolved" and handing back the result before I get the sync message coming in that would say "Oh wait, I've got something". I may need to re-think how that whole flow operates with that behavior, or push on that behavior if that's sending an erroneous message that it shouldn't.
I know that doesn't leave you in a great place with how to use this, and me just as confused - not to mention a pending question of "how long do we wait to know if it's really not found or it it is?"

@jessegrosjean look through the integration test I added in #93, and verify for me that it jives with what you're using - a variation of this bug with some explicit assertions embedded in it.

That integration test looks right to me. With that said I'm not 100% confident that what I'm doing with find really has the semantics that I want. It's a little unclear to me exactly how find is supposed to work. And hard to get into my head that my local repo and the web socket connected repo are peers... not client server.
This is also related to the forking discussion earlier. I will try to write up related thoughts/questions tomorrow.

I know that doesn't leave you in a great place with how to use this, and me just as confused - not to mention a pending question of "how long do we wait to know if it's really not found or it it is?"

I'm still just experimenting for fun when I should be working on other things, so don't worry about me :)

I'm digging through the tests that define repo behaviors at https://github.com/automerge/automerge-repo/blob/6ef25d8f300133bfefc71b44369cc222bcb43f0c/packages/automerge-repo/test/Repo.test.ts#L207
I'm not sure I'm reading it correctly, but how it reacts to a local JS repo appears to be different from what we're seeing with the behavior that creates a new document on find with a random DocumentId. These tests aren't 1:1 with our integration tests, as they're not interacting over the network, but that's seems to be the gist.

This is also related to the forking discussion earlier. I will try to write up related thoughts/questions tomorrow.

I've been posting more thoughts in #79. I think the summary related to this issue is probably that NSDocument probably doesn't want to be using full repo.find() implementation when loading in document data. In particular I don't think we want to wait for network timeouts with peers when loading data. Instead just want to check with local storage. Probably this is all done with a new repo method, not find.
Of course still want find to generally work :)

I dug around through the Javascript code and explored more of the testing, and I'm more convinced now than ever that the "create a new document" result we saw earlier was incorrect, although I'm at a loss as to what I had in place that enabled that result.
The API of find() in the javascript side returns a DocHandle, notably different from what Swift returns, in that the JS DocHandle is an object that emits events there. The internal concept of find() is that the request is transitive, and may come back at a later time, so "unavailable" is a current state, but not a final state in that scenario. As such, the dochandle emits events for "unavailable" when a peer in that chain says "Sorry, no beuno", but remembers the request and if it's peers find something, it CAN return the document. So in the JS world, it's far more like an active subscription for a possible eventual document, rather than a fully resolved endpoint.
Based on that, and continuing to poke at the Integration tests, I thought the PR was worthy to merge - it fixed the assert issue you saw, cleaned up the logic a bit, and puts a stake in the ground as to expectations.
There's plenty of more questions about what/how automerge-repo does with it's transitive peer links, and how find can/should work - in particular, per https://github.com/automerge/automerge-repo/issues/343, I suspect the the JS WebSocker provider may be returning a temporary unavailable message before it's finished checking with any/all connected peers, but tracking that down it and verifying that for the JS side is writing a number of integration tests in JS to verify and provide a JS-local test scenario, so for the time being I'm leaving that alone.


Legacy islands do not generate nether properly

Exactly what it sounds like.

This is probably why I got so many reports of nether islands not generating


RBAC Migration to Microsoft Graph API from Active Directory Graph API

What problem are you facing?
Currently Crossplane's Azure provider requires Azure Active Directory Graph API permission grants. Microsoft is
ending support for Active Directory Graph API on 06/30/21 https://developer.microsoft.com/en-us/microsoft-365/blogs/end-of-support-timelines-for-azure-ad-authentication-library-adal-and-azure-ad-graph/.
They are pushing for migration to Microsoft Graph API. Currently, Azure Active Directory Graph is not a one-to-one mapping to Microsoft Graph API.
For example,
In my Azure instance, I have a Service Principal with Owner role and role grant Application.ReadWriteOwned for the Azure Active Directory Graph API. This enables me to create AKSCluster resources.
When granted Application.ReadWriteOwned role grant for Microsoft Graph API, and attempting to create AKSCluster resource, I receive an "Insufficient Privileges" error within the resource.
How could Crossplane help solve your problem?
With migration from Azure's soon-to-be unsupported Active Directory Graph API to Microsoft Graph API, consumers of Crossplane will maintain on-going support for the RBAC Azure APIs.

I stumbled upon this just now because of a more broad push that Azure is now doing about the retiring of Azure AD Graph.  We got an automated email that says we have applications in Azure that are using Azure AD Graph.  Following the steps on https://github.com/microsoft/AzureADGraphApps/issues/5#issuecomment-902897058 to find which applications, it's all the applications (servicePrincipals?) that we create using the getting started docs for Azure.
So our happy path docs result in creating Azure resources that are using this soon to be retired Azure AD Graph API.  They will retire it completely in June 30 2022.
Thinking back to why we first added this requirement into provider-azure, my memory is a little hazy but it definitely has to do with AKS cluster creation.  During the creation of an AKS cluster, we must create a Service Principal that the AKS cluster will use to interact with Azure APIs during its lifecycle.  In order to create this Service Principal programmatically in provider-azure, the user supplied ProviderConfig that is uses needs to have access to the Azure AD Graph API.
Related provider-azure code: https://github.com/crossplane/provider-azure/blob/master/pkg/clients/compute/aks.go#L207
Azure docs: https://docs.microsoft.com/en-us/azure/aks/kubernetes-service-principal?tabs=azure-cli
It seems like we need to investigate further here and update our AKS create path to stop using the deprecated Azure AD Graph API use the new (non-deprecated) Microsoft Graph API instead.  Basically what @jbonafide623 concluded when they opened this ticket, but a little more roundabout way to arrive at that conclusion 😅

I encountered the same issue when creating the AKS cluster wtih a SPN which has Application.ReadWriteAll and Directory.ReadWriteAll of Microsoft Graph granted. Seems like these two permissions defined in Microsoft Graph are different from ones of Azure AD Graph, but since Azure AD graph is gonna be phased out today, could you guide how to migrate to the correct permissions of Microsoft Graph so that AKS cluster can be created successfully?


Filter card brand and model

Description
It would be nice to filter by brand and model across all sites.
Possible solution
Create global keys for brands and models and make a filter function.

Half of this is completed by https://github.com/jef/nvidia-snatcher/pull/120.
Wouldn't be much to add a filter for models.

Believe we now have this right?
SHOW_ONLY_SERIES
SHOW_ONLY_BRANDS

Unless you are also looking for filters like TUF

Offering a filter for the specific model makes sense. Ex: user is specifically looking for either evga ftw3 ultra or asus rog strix.


Error in increase sndbuf and rcvbuf.

The ftp server is so slow.
I noticed the socket send/recv buf is only 8192 and try to increase it.
Get error message: "22 Invalid Argument".
Anything wrong? Or just not support to change it?
Here is the code I add in function ftp_set_socket_nonblocking.
  int rcvbuf, sndbuf;
  socklen_t len = 4;
  getsockopt(fd, SOL_SOCKET, SO_RCVBUF, &rcvbuf, &len);
  console_print(YELLOW "SO_RCVBUF = %d  len %d (before set it)\n" RESET, rcvbuf, len);

  rcvbuf  *= 2;
  if(setsockopt(fd, SOL_SOCKET, SO_RCVBUF, &rcvbuf, sizeof(rcvbuf)) < 0) {
    console_print(RED "setsockopt: %d %s\n" RESET, errno, strerror(errno));
  }
  getsockopt(fd, SOL_SOCKET, SO_RCVBUF, &rcvbuf, &len);
  console_print(YELLOW "SO_RCVBUF = %d (after set it)\n" RESET, rcvbuf);

  getsockopt(fd, SOL_SOCKET, SO_SNDBUF, &sndbuf, &len);
  console_print(YELLOW "SO_SNDBUF = %d  len %d (before set it)\n" RESET, sndbuf, len);

  sndbuf *= 2;
  if(setsockopt(fd, SOL_SOCKET, SO_SNDBUF, &sndbuf, sizeof(sndbuf)) < 0) {
    console_print(RED "setsockopt: %d %s\n" RESET, errno, strerror(errno));
  }
  getsockopt(fd, SOL_SOCKET, SO_SNDBUF, &sndbuf, &len);
  console_print(YELLOW "SO_SNDBUF = %d (after set it)\n" RESET, sndbuf);

Increased sndbuf by setsockopt on listenfd.
But still very slow, seems caused by slow speed of write file.
Maybe async write needed?


How do I write my store and keys for the new version？

I looked at the source code and found that the new version canceled the of constructor. In the past I only needed 7 parameters to build the keys object, now I need 26 parameters. For example, registrationId was generated through KeyHelper.registrationId() in the old version. Now I have to generate it myself.

Will add in 0.0.2

Added support already, check ControllerSerializer, Store#newStore, Keys#newKeys, StoreBuilder and KeysBuilder

Added support already, check ControllerSerializer, Store#newStore, Keys#newKeys, StoreBuilder and KeysBuilder

Can you give me an example? I checked keysBuilder and I found that it still needs to fill in a lot of parameters.

Added support already, check ControllerSerializer, Store#newStore, Keys#newKeys, StoreBuilder and KeysBuilder

Can you give me an example? I checked keysBuilder and I found that it still needs to fill in a lot of parameters.

Use Keys.newKeys if you don't know how to fill it out

Use Keys.newKeys if you don't know how to fill it out

I used newKeys and got an error message saying Cannot invoke "it.auties.whatsapp.controller.ControllerSerializer.serializeKeys(it.auties.whatsapp.controller.Keys, boolean)" because "this.serializer" is null


withAuthenticator not broken

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
yarn
If applicable, what version of Node.js are you using?
v16.13.0
Amplify CLI Version
6.3.1
What operating system are you using?
macOS
Amplify Categories
auth
Amplify Commands
Not applicable
Describe the bug
Using  "@aws-amplify/ui-react": "^2.1.2" produces a skewed authentication form result as shown below:

Expected behavior
Using  "@aws-amplify/ui-react": "^1.2.26" produces the expected result as shown below:

Reproduction steps

Create ReactJS : npx create-react-app <>
amplify init
amplify add auth
4. amplify push
Add  withAuthenticator is a higher-order component
yarn start

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

@syumaK this looks like it's related to amplify ui. Transferring it to the repo so they can help you better.


quick steps using a script to generate the docker compose file

Fixes #489
Changes proposed in this PR:

a shell script designed to gather minimal end-user input and generate a basic Docker Compose file
a guide on how to use the script, along with references to various useful docs

lgtm


%() not being interpreted

Armbian 5.59 based on Debian Stretch (running on ARM64 architecture).
Why is %(title).%(ext) not creating a file of the right name ? It creates /home/username/videos/$(ext).mkv . It plays OK.
$ youtube-dl -v -o '/home/username/videos/%(title).%(ext)' https://www.youtube.com/watch?v=LrNsJrWL4kI
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'-o', u'/home/username/videos/%(title).%(ext)', u'https://www.youtube.com/watch?v=LrNsJrWL4kI']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.11.07
[debug] Python version 2.7.13 (CPython) - Linux-4.14.70-sunxi64-aarch64-with-debian-9.6
[debug] exe versions: ffmpeg 3.2.12-1, ffprobe 3.2.12-1
[debug] Proxy map: {}
[youtube] LrNsJrWL4kI: Downloading webpage
[youtube] LrNsJrWL4kI: Downloading video info webpage
[debug] Default format spec: bestvideo+bestaudio/best
WARNING: Requested formats are incompatible for merge and will be merged into mkv.
[debug] Invoking downloader on u'https://r5---sn-n4v7sn7z.googlevideo.com/videoplayback?ipbits=0&ei=SH_vW_XfL4qpgQOYkK7wCw&key=yt6&c=WEB&pl=24&ip=<IP_ADDRESS>&mm=31%2C26&mn=sn-n4v7sn7z%2Csn-q4fl6nss&initcwndbps=482500&itag=135&ms=au%2Conr&mt=1542422208&mv=m&dur=167.967&id=2eb36c26b58be242&sparams=aitags%2Cclen%2Cdur%2Cei%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Crequiressl%2Csource%2Cexpire&keepalive=yes&fvip=5&gir=yes&mime=video%2Fmp4&requiressl=yes&lmt=1464268591626562&expire=1542443946&signature=39AFA698DB0612ACFC6C981487789D8AD2C8FE59.29013BCFF1C7F7DCF0A930DD49AC51E8B6BD0A90&source=youtube&aitags=133%2C134%2C135%2C160%2C242%2C243%2C244%2C278&clen=14012563&ratebypass=yes'
[download] Destination: /home/username/videos/%(ext).f135
[download] 100% of 13.36MiB in 01:02
[debug] Invoking downloader on u'https://r5---sn-n4v7sn7z.googlevideo.com/videoplayback?ipbits=0&ei=SH_vW_XfL4qpgQOYkK7wCw&key=yt6&c=WEB&pl=24&ip=<IP_ADDRESS>&mm=31%2C26&mn=sn-n4v7sn7z%2Csn-q4fl6nss&initcwndbps=482500&itag=251&ms=au%2Conr&mt=1542422208&mv=m&dur=167.961&id=2eb36c26b58be242&sparams=clen%2Cdur%2Cei%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Crequiressl%2Csource%2Cexpire&keepalive=yes&fvip=5&gir=yes&mime=audio%2Fwebm&requiressl=yes&lmt=1464276886778876&expire=1542443946&signature=397FAE2CF1E9750DFAFE715B041B7B6ED53D6902.0D55D62586296907617A0A90A54DB42EE52C47A4&source=youtube&clen=2648699&ratebypass=yes'
[download] Destination: /home/username/videos/%(ext).f251
[download] 100% of 2.53MiB in 00:21
[ffmpeg] Merging formats into "/home/username/videos/%(ext).mkv"
[debug] ffmpeg command line: ffmpeg -y -i 'file:/home/username/videos/%(ext).f135' -i 'file:/home/username/videos/%(ext).f251' -c copy -map '0:v:0' -map '1:a:0' 'file:/home/username/videos/%(ext).temp.mkv'
Deleting original file /home/username/videos/%(ext).f135 (pass -k to keep)
Deleting original file /home/username/videos/%(ext).f251 (pass -k to keep)
username@prime:~$

it's %(title)s.%(ext)s not %(title).%(ext).

OK, thanks, but why does it need an "s"?  Surely the ")" is sufficient as a terminator of the string. The typical Linux way of doing things would be %TITLE%.%EXT% .

https://github.com/rg3/youtube-dl#output-template why. "typical Linux way" can not into formatting at all.


How cluster is managed incase of failure, Recovery mechanism for cluster in Rancher?

Environmental Info:
K3s Version:

Node(s) CPU architecture, OS, and Version:

Cluster Configuration:

Describe the bug:

Steps To Reproduce:

Installed K3s:

Expected behavior:

Actual behavior:

Additional context / logs:

Hello. The backup and restore procedure for K3s is documented here: https://rancher.com/docs/k3s/latest/en/backup-restore/
Rancher has one as well here: https://rancher.com/docs/rancher/v2.x/en/backups/


pipewire: fix build without bluez support

Description of changes
Add opusSupport option to pipewire derivation and pull libopus as a buildInput when enabled. Fixes #277076
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Looks good. Mind to rebase?

Rebased onto newest staging


Translate the website

We should probably get this set up sooner than later

Yes, I agree - it's always been a PITA to add translations after all the strings have been hardcoded into the page in the past. It's probably worth discussing how we should go about this (considering we're now not using any sort of framework or server side language (yet)).

I imagine we should probably go with some solution that works with a github plugin for translations. Anybody have any leads on that sort of thing?

maybe we should just use something like: elementaryos.org/de or elementaryos.org/fr and then link to these pages? Would be a quick fix, even if that's really static :)

What about https://github.com/wikimedia/jquery.i18n ?

Using jQuery / Javascript in general for i18n sounds like a bad idea.
If the site uses PHP without frameworks I think it would be most sensible to use the built-in functions for gettext. Templates can stay almost the same, only that every to-be-translated <?php echo "English string"; ?> has to be replaced by <?php echo _("English string"); ?> (or <?=_( "English string" )?> if you prefer it short, and enable shortcodes). GNU gettext is pretty much standard and there are a whole bunch of (including web) apps for it, but you can also edit the files with a text editor if you feel desperate.

As a temporary solution I'd agree with PhillipSz with the "elementaryos.org/lng". We would also have it easier to use the translated strings later.

much projects use Transifex, like ownCloud https://www.transifex.com/projects/p/owncloud/
it is free for open source-project. the interface is more modern than launchpad. but why not using launchpad, if you use it for the apps?
also, the localization should happen on server-side that the client simply get's a plain html file.
i hope you have caching like varnish to speed it up and don't have to apply the localization on every request. that saves lot's of resources on the webserver!
<?php echo _("English string"); ?> is really messy. there should be a more elegant way.

But if we used the local manual translation, we could easily deal with currency convertion and translated "hero" screenshots.

Please don't use Launchpad for the translation of the website. Choose Transifex or local translations. Both of them are much easier methods than the constant "something went wrong" errors we get on Launchpad.

Launchpad translations make no sense for a GitHub hosted project. They were never being seriously considered.

I understand that there is Weblate and WebtranslateIt that integrates well with Github (they are in the service hooks). Weblate is simple but seems to handle a lot of file types, and PHP files as well : http://docs.weblate.org/en/latest/formats.html#php-files

Laravel uses a nice system:
a template:
<?php echo trans('users.noaccess'); ?>

lang/fr/users.php:
return array(
   'noaccess'      =>	"Vous n'êtes pas autorisé à faire ça.",
   ...

);

Working on it, see #288


ODQA with squad noans (best ODQA)

ODQA with multi_squad_noans model
updated docs

Warning
Now ODQA can output empty answer if no other candidates are found.

Results in features.rst should also be updated


HADOOP-17951 AccessPoint verifyBucketExistsV2 always returns false

Description of PR
Turns out there was a small issue with the previous implementation that
always returned false for verifyBucketExistsV2. The more "clearer"
way to check is for an error message when there's a 403. If that error
message is present then the AP doesn't exist (the only case when a 403
is returned for an AP), otherwise 404 means definite no.
How was this patch tested?
Ran mvn -Dparallel-tests -DtestsThreadCount=32 clean verify on eu-west-1 with access points enabled (i.e. bucket pointing to AP ARN).
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran small bug fix related to Access Point PR that went in last week.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 24s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 21s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m  9s

trunk passed

+1 :green_heart:
shadedclient
22m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 14s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
1m 12s

the patch passed

+1 :green_heart:
shadedclient
22m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 24s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

92m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3516/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3516

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c9924a59f421 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0aa3bec35fe2fcca50d2f5cb481ebac6611989cc

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3516/1/testReport/

Max. process+thread count
551 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3516/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Fixed a typo

@all-contributors please give @SR-- credit for docs

@all-contributors please add @SR-- for doc


Re init indicator each loop

Thank for great tools.
Today when I used this tool I encountered a problem. This EA always initiate a indicator for each loop so that backtesting takes a long time.

This is the way how mt4 expert advisor call extern indicators. Only on mt5 you can use handle of indicators.


Vulkano has moved

Vulkano is no longer located at https://github.com/tomaka/vulkano, but is moved to https://github.com/vulkano-rs/vulkano.

Thanks! Fixed in commit dddb767


iOS 18 state loss with @Query

iOS 18 is causing Queries to lose their state and requery. This happens with more complex publishers:
public struct NotificationMessagesRequest: Queryable {

    public init() {}

    public static var defaultValue: [NotificationMessage] { [] }

    public func publisher(in appDatabase: AppDatabase) -> AnyPublisher<[NotificationMessage], Error> {
        let observation =
            ValueObservation
            .tracking(fetchValue(_:))
            .publisher(
                in: appDatabase.reader,
                scheduling: .immediate
            )

        let future = Future<[NotificationMessage], Never> { promise in
            Task {
                let messages = try appDatabase.reader.read { db in
                    try fetchValue(db)
                }

                promise(.success(messages))
            }
        }

        let foreground = NotificationCenter
            .default
            .publisher(for: UIApplication.didBecomeActiveNotification)
            .map { _ in
                future
            }
            .switchToLatest()
            .setFailureType(to: Error.self)

        return
            observation
            .merge(with: foreground)
            .removeDuplicates()
            .receive(on: DispatchQueue.main)
            .eraseToAnyPublisher()
    }

    private func fetchValue(_ db: Database) throws -> [NotificationMessage] {
        try NotificationMessage
            .all()
            .orderedByCreationDate()
            .fetchAll(db)
    }
}

I had previously tried the reader.readPublisher with more adverse affects. With this publisher in particular, the array resets to 0 on each foreground or each update to the ValueObservation

This seems to originate from a TabBar with a subview View where both have @Query variables. Removing the query from the TabBar doesn't affect downstream views. Also exclusive to iOS 18

I believe this is an issue with TabBars and children in iOS 18 across the board 🤷


Modal does not render correctly in Safari browser

Reproduction link
https://stackblitz.com/edit/angular-fpt2f5-ulf722?file=src%2Fapp%2Fapp.component.ts
Steps to reproduce
Open the stackblitz example in Safari browser. Display modal and click add new item button.
Please note that the modal has modified padding on .ant-modal-content class (see styles.css file). Any dynamic content leads to the unexpected rendering of the modal.
What is expected?
No visible gaps in the modal content.
What is actually happening?
There are visible gaps in the modal content.

Environment
Info

ng-zorro-antd
16.2.0

Browser
Safari

It seems the issue is produced by the box-shadow on .ant-modal-content class.


Add UI Support for SSL Passthrough

Is there a way to turn on SSL passthrouh ingress via the Rancher UI? Up to now it's only possible  to manually edit a yaml file for the passthrough to work (enable-ssl-passthrough) which is not persistent after k8s upgrade.

Version: master 2.2 (12/5/18)
Confirmed UI fix. If a param has empty value the UI no longer removes this. Also performed halo testing with this and made sure we can use the ingress annotation as well even though we didn't change this area in code.
Regarding the request: since this is an advanced option for nginx,etc and there are so many parameters we are not adding to the UI so we can keep it clean. It will be necessary to edit in the YAML. This issue fixed the UI so it's not removed when the value is empty.


Dev: Relaxed the conditions when safety issues are tolerated

No review needed.

coverage: 36.575%. remained the same
when pulling 0635100a135714d2c4d1ea3fef38d9b57116b431 on andy/relax-safety-fails
into af485db655e82f1f9efb90f4d612267f83c5c140 on master.


InventoryPreClickEvent is not called when a creative player is moving items inside their own inventory

Discussed in https://github.com/Minestom/Minestom/discussions/1317

Originally posted by bananasmoothii August  7, 2022
I've found that I have to use InventoryPreClickEvent to cancel an event in an Inventory (could you also explain me why InventoryClickEvent is not cancellable ?), but then I found that PlayerInventory does not extend Inventory, so using InventoryPreClickEvent doesn't work.

Creative players’ inventories work in a weird way, basically, whenever you click on an item in creative, the server thinks that item has disappeared. When you put the item back in your inventory, the server thinks you created a new item with some NBT data. This is because you can just create items out of thin air using the saved hotbars, or just the regular blocks/items in the creative menu. The server does not know about the cursor item of a creative player. This is not a minestom bug.

Oh, ok...


Make the follow button work

It does not work (just never implemented it). Key thing is to ensure the users follow list is up-to-date. Might need to add some checks. For example, if no follow list was found, ask if the user really doesn't have one.

@GBKS I can't even see a follow button on user profile pages. Is there one?

I hid it for now (because it doesn't work).

PR #85 re-enables the follow button and adds the required functionality. It's sensitive functionality and there's quite a bit of logic behind the scenes, so I'll need to test it for a few days (different accounts, browsers, devices...) to ensure it's solid.


Updating packages and course repo - Update

The image "/images/colab/07.png" showcasing the url to update Colab repo has been updated to  -
"!curl https://course.fast.ai/setup/colab | bash"
from-  " !curl https://course-v3.fast.ai/setup/colab_update | bash ".
The image may either be removed or altered containing the new url.

Thank you :)

Pleasure is all mine, @jph00 . Thank you so much for the comment. Means a lot to me, coming from you.
I am just one of the enthusiast trying to learn optimally as much possible from this amazing community. Thank you for creating such a beautiful framework and the amazing community around.


Variable that is in scope is not found.

Description
Swift compiler cannot find a variable in scope when in fact it is in scope.
Steps to reproduce
func x(a: Any) {
    let _ = a is a  // Cannot find type 'a' in scope
}

Expected behavior
A more useful error message.
Environment

Swift compiler version info swift-driver version: 1.87.1 Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.108 clang-15<IP_ADDRESS>) Target: arm64-apple-macosx14.0
Xcode version info Xcode 15.0 Build version 15A240d
Deployment target: iOS 17.0

I think this is correct, the diagnostic talks about a "type" not being found because it points to the second a after is keyword.

Yeah, the error itself is expected. I labeled this as a diagnostic QoI issue thinking we could come up with a better message for this case.

}

What do you think?

Something like - type check operator 'is' expects a type on its right-hand side (got: parameter 'a')?

I’ll take that. Or expected type on right-hand side of type-casting operator 'is', but found <descriptive decl kind> <base name> (type-casting operator is a TSPL term).

Something like - type check operator 'is' expects a type on its right-hand side (got: parameter 'a')?

I’ll take that. Or expected type on right-hand side of type-casting operator 'is', but found <descriptive decl kind> <base name> (type-casting operator is a TSPL term).

I like this message and I find it to be very descriptive, but I have a couple of questions:

the 'is' can't be hard-coded in the message as we might have situations where the operator is as instead - but I couldn't figure out how to dynamically get the cast operator to build the message.
Taking the example code above, what would be printed as the <descriptive decl kind> ?

Also, I appreciate your help as this is my first time working in this project.

the 'is' can't be hard-coded in the message

"as" is not a type check operator though, it's a type cast operator so we'd need a separate message for that I think.

what would be printed as the

It's going to be 'parameter' but I think with some recent changes we can actually use const ValueDecl * like: "type check operator 'is' expects a type on its right-hand side (got: %0)", (const ValueDecl *)

@xedin but currently both is and as fall to the same function under TypeCheckType - hence using the message type check operator 'is' expects... would be inappropriate as it would be presented for when as is used.
That's why in my PR I had changed the message to cast expression expects a type on its right-hand side (got: %0)

I think it’s fine to simply say "type-casting operator" without mentioning exactly which one it is.


Improve diagnostics in evp_pkey_provided_test and for HARNESS_VERBOSE_FAILURE

The HARNESS_VERBOSE_FAILURE did not show the errors from the failed test because they were printed after the test verdict.
The improved diagnostic might help with finding the cause of #13995.
Checklist

[x] tests are added or updated

Due to #14332 we had failing CI in master. So I've merged this PR to master a little bit earlier as it is a fairly trivial thing anyway.


Add watch support to makefile

Fixes #375
Partially addresses #501
Includes:

Updates makefile to link packages instead of creating dists and
installing them (allows for use of watch)
Add make  watch command that watches for changes and rebuilds
packages. To be used alongside jupyter lab --watch

Known issues:

jupyter lab --watch cant pick up changes in dependencies within
a monorepo, meaning it will not pick up changes in application
when called within another extension. A simple workaround is to
stop and start lab, changes in application do get picked up on start

Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@akchinSTC and @lresende I am unsure how removing the creation of the dists will affect other parts of the code. I was unable to figure out if those dists were leveraged anywhere other than the install step of the Makefile. If they are needed elsewhere I can add a new make target that builds them outside the make install flow.

With this PR you can utilize watch with the following steps:

Initial build with make clean install
Watch for changes with make watch
Run Lab with jupyter lab --watch

The caveats:

Steps 2 and 3 above tail and need their own terminal tab/window (make sure the conda env is the same)
Changes to utils in application that are called within other packages will not be picked up by jupyter lab --watch and require stopping and starting to pick up.
When running jupyter lab --watch the start up of lab takes about 2-3x longer.

After some clarification from @akchinSTC offline I've added back in the functionality to package the extensions into dists since they are included when creating elyra releases. The added make target assumes make install has already been run.
On a separate note, I updated the .PHONY targets in this PR. new targets were added to Makefile but were missing from .PHONY also since it was getting long I split it across two lines.

Per discussion in scrum I will be adding documentation for this. @lresende where should that documentation go? In the README, in the new docs we just added, or both?

The documentation should be added to where we describe the contributor workflow, currently, it's available in README.md and on the development workflow

Could we please have a single location for dev workflow and link README to the docs?
Then promote the community meeting section header up a level and add a sentence indicating/inviting folks to attend if they're interested in contributing?
Let's also remove the single ticks around Elyra in the opening dev workflow paragraph since this is more about the project and not an object within the project.
If anyone feels this needs to be its own separate pull request, then I'm happy to submit a PR later today.

@kevin-bates if you want to open another pr for that then I will only update the docs in this pr

Thanks Alex - I'll a PR with the changes I proposed above.

@lresende should we address the handling of dists in #503 rather than handling it here? ie once I push the docs update this would be ready to merge?

I've pushed docs for review

Just played around with this locally and it worked for me!

Worked for me too! This is great, gonna help a lot our dev process :)

I would prefer if we do make install to produce the necessary npm packages and the full wheel that is ready to install.  I am open to having something like make dev to do a simple build`. Otherwise, this looks good.

Addressed @lresende comments based on discussion during scrum. We will remove creation of dists in another pr when addressing build speed and/or release automation.


Monitor OCP releases and trigger relevant jobs based on z-stream version

Listen on any change in https://openshift-release.apps.ci.l2s4.p1.openshiftapps.com and check if new z-stream is available to versions configured in the config file, trigger only versions that are not only triggered.
Support trigger specific version with webhook.
curl -X POST 'http://<server-url>/process?4.13'

Report bugs in Issues
The following are automatically added:

Add reviewers from OWNER file (in the root of the repository) under reviewers section.
Set PR size label.
New issue is created for the PR. (Closed when PR is merged/closed)
Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
verified label removed on each new commit push.
To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.

Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
Cherry-pick will be started when PR is merged

To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
To add a label by comment use /<label name>, to remove, use /<label name> cancel

Supported /retest check runs

/retest tox: Retest tox
/retest build-container: Retest build-container

Supported labels

hold
verified
wip
lgtm

/wip

/retest tox

/assign-reviewers

/assign-reviewers

/assign-reviewers

/assign-reviewers

/retest build-container

/assign-reviewers

/wip cancel

/verified

Failed to create and push quay.io/redhat_msi/openshift-ci-zstream-trigger:latest

/build-and-push-container

/build-and-push-container

New container for quay.io/redhat_msi/ci-jobs-trigger:latest published


Getting latest updates for webview

RE #84

:shipit:

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/WebView-known-issues.md
:white_check_mark:Succeeded
View

docs/controls/WebView.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/controls/WebView-known-issues.md
:white_check_mark:Succeeded
View

docs/controls/WebView.md
:white_check_mark:Succeeded
View

docs/extensions/TextBoxRegex.md
:white_check_mark:Succeeded
View

docs/services/Twitter.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fixed syntax error in esp_http_server.rst (IDFGH-1701)

Changed the "const char[] name" into "const char name[]", so now the code doesn't produce the "expected identifier or '(' before '[' token" error.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@morsisko Thanks for sending this across, I have put this in our internal review queue.


webpack 3.10.0 dependency on uglifyjs-webpack-plugin 0.4.6 causing build errors - AWS

I am deploying my app to AWS using docker and it has started failing on npm install due to the following error.
aws_beanstalk/staging-app: s/webpack/node_modules/uglifyjs-webpack-plugin > node lib/post_install.js [91m [0mThe command '/bin/sh -c npm install' returned a non-zero code: 1.
Upon further investigation it looks like it is being caused by webpack 3.10.0's dependency on uglifyjs-webpack-plugin 0.4.6. It seems to be a known issue
System information
Docker image:  64bit Amazon Linux/2.10
node 8.11.2
npm 6.1.0
next 6.0.3

I can tell npm to ignore the post install script which fixes the issue and doesn't seem to cause any problems. This works for now I suppose. Below are the relevant lines from my DockerFile.
RUN npm install<EMAIL_ADDRESS>--ignore-scripts
RUN npm install

Was caused my insufficient ram on my instance


User management

This adds a user management interface for admins similar to the one for hackathons.

Thanks for throwing this together!

No problem! Probably should've added a list of hackathons a user has submitted, but I can do that in a separate PR.


Add example for AuthConfig v1beta1 in the CSV

What: Adds an example of the AuthConfig CR in v1beta1 to the CSV
Why: Having an example for each version of the API that is served is required by some operator hub test pipelines.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cdb55b4) 61.78% compared to head (5b6bc92) 61.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   61.78%   61.78%
=======================================
  Files           2        2
  Lines         785      785
=======================================
  Hits          485      485
  Misses        249      249
  Partials       51       51

Flag
Coverage Δ

unit
61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(DeprecatedTabs): Remove DeprecatedTabs component GM-54

Overview
This no longer has any instantiations so there's no real point in documenting/keeping it around.
PR Checklist

[ ] Related to designs:
[x] Related to JIRA ticket: GM-54
[x] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-labs@5.2.2-alpha.8ba164.0@codecademy/gamut@17.3.1-alpha.8ba164.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://5fad6db20a1a8b61bdecc4f1--gamut-preview.netlify.appDeploy Logs


[Priority Queue]

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[Priority Queue]
About:
A priority queue is an abstract data type that behaves similarly to the normal queue except that each element has some priority, i.e., the element with the highest priority would come first in a priority queue. The priority of the elements in a priority queue will determine the order in which elements are removed from the priority queue.
The priority queue supports only comparable elements, which means that the elements are either arranged in an ascending or descending order.
For example, suppose we have some values like 1, 3, 4, 8, 14, 22 inserted in a priority queue with an ordering imposed on the values is from least to the greatest. Therefore, the 1 number would be having the highest priority while 22 will be having the lowest priority.

Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

Do not create multiple issues.


CmdExecuteCommands fixes

A couple of fixes to avoid spurious errors/warnings I hit after doing some image transfer commands inside secondary command buffers.
See commit messages for details.

Edited commit subject lines for length (should be 50 chars) and pushed to Master -- Thanks!


Remove client side session tokens

This pull request removes the client side session tokens. Token are now generated on the server only (we still use personal tokens when you log in).
This simplifies lots of stuff, as we don't have to pass tokens around on both the client and the server (because of SSR), and we don't have to renew tokens in the client.
The one small caveat with this is that on the server we place the last requested token in a global variable. Kind of ugly, but it works.


Adding one restore test that checks for expected exceptions

During integration I sometimes see nothing and I'm trying to figure out the scenarios that cause that.

Thank you for adding these scenarios, there are a couple of minor requests.

Responded to both! Thanks.

/azp run tools - test-proxy - tests


Magnum cluster control planes not initializing the Kubernetes cluster

This may or may not be related to the root cause of Issue #168, as both occurred around the same time in our environment.
When creating a cluster based on the Ubuntu 20.04 image, cloud-init for the first control plane VM never runs through the commands needed to initialize the cluster. I haven't developed for the OpenStack provider but on the baremetal provider we use I have those in the kubeadm controlplane or kubeadm controlplane templates but I'm not seeing related objects that are created in the openstack provider CRD's.
Recently, while I was out, the team had to redeploy Atmosphere, but did not redeploy CAPI or CAPO. At that point this problem started. The cluster templates (old ones based on Ubuntu 20.04 due to the issue referenced above where we are seeing regarding 22.04 cluster templates) were recreated after the images were uploaded into Glance after the redeploy. Since then I've removed and redeployed CAPI and CAPO, as well as redeployed magnum-cluster-api (via Atmosphere) but no change. Everything works fine until the first control plane node spins up, where it never initializes the control plane.
I'm not sure which configuration, logs, etc would best help with this - I'm opening to start a conversation to see if anyone else has run into this.

👋
two questions: when was the last time you downloaded the images?  we did release a set of "bad" images for a little bit, but if you downloaded them in the past few weeks these images should be good.
we added status_reason updates so when you see the cluster stuck, do you seea nything logged there?

@mnaser I deleted all of our existing images to be sure, including the ones we created, and just downloaded the v1.27.3 image from this repository's link and confirmed the issue still exists. That said, it takes an hour or more for everything to time out so I don't have any errors yet. What I do have is:
❯ kubectl -n magnum-system get cluster,openstackcluster,kubeadmcontrolplane,machinedeployments,machines,openstackmachines
\NAME                                  PHASE         AGE   VERSION
cluster.cluster.x-k8s.io/kube-9bjwe   Provisioned   39m   v1.27.3

NAME                                                                CLUSTER      READY   NETWORK                                SUBNET                                 BASTION IP   AGE
openstackcluster.infrastructure.cluster.x-k8s.io/kube-9bjwe-wtxqg   kube-9bjwe   true    02cc4e94-87fb-48f5-9354-eeba94e1a000   0a8de594-cb90-43e2-9d43-c90d718cccfc                39m

NAME                                                                 CLUSTER      INITIALIZED   API SERVER AVAILABLE   REPLICAS   READY   UPDATED   UNAVAILABLE   AGE   VERSION
kubeadmcontrolplane.controlplane.cluster.x-k8s.io/kube-9bjwe-cgs5g   kube-9bjwe                                        1                  1         1             39m   v1.27.3

NAME                                                                 CLUSTER      REPLICAS   READY   UPDATED   UNAVAILABLE   PHASE       AGE   VERSION
machinedeployment.cluster.x-k8s.io/kube-9bjwe-default-worker-ndjvg   kube-9bjwe   1                  1         1             ScalingUp   39m   v1.27.3

NAME                                                                              CLUSTER      NODENAME   PROVIDERID                                          PHASE         AGE   VERSION
machine.cluster.x-k8s.io/kube-9bjwe-cgs5g-h4nsr                                   kube-9bjwe              openstack:///11c8f025-b440-42ae-b63f-6ebced7c17c4   Provisioned   38m   v1.27.3
machine.cluster.x-k8s.io/kube-9bjwe-default-worker-ndjvg-77c9f86c95xcb95d-7dl45   kube-9bjwe                                                                  Pending       39m   v1.27.3

NAME                                                                                CLUSTER      INSTANCESTATE   READY   PROVIDERID                                          MACHINE                                                  AGE
openstackmachine.infrastructure.cluster.x-k8s.io/kube-9bjwe-control-plane-cfzjb-cb6n9          kube-9bjwe   ACTIVE          true    openstack:///11c8f025-b440-42ae-b63f-6ebced7c17c4   kube-9bjwe-cgs5g-h4nsr                                   38m
openstackmachine.infrastructure.cluster.x-k8s.io/kube-9bjwe-default-worker-infra-xmcvf-tjb7g   kube-9bjwe

❯ clusterctl -n magnum-system describe cluster --color --grouping=false --show-conditions KubeadmControlPlane,MachineDeployment,Machine kube-9bjwe
NAME                                                                                READY  SEVERITY  REASON                           SINCE  MESSAGE
Cluster/kube-9bjwe                                                                       False  Info      WaitingForKubeadmInit            37m
├─ClusterInfrastructure - OpenStackCluster/kube-9bjwe-wtxqg
├─ControlPlane - KubeadmControlPlane/kube-9bjwe-cgs5g                                    False  Info      WaitingForKubeadmInit            37m
│ │           ├─Available                                                                False  Info      WaitingForKubeadmInit            38m
│ │           ├─CertificatesAvailable                                                    True                                              38m
│ │           ├─MachinesCreated                                                          True                                              38m
│ │           ├─MachinesReady                                                            True                                              37m
│ │           └─Resized                                                                  True                                              37m
│ └─Machine/kube-9bjwe-cgs5g-h4nsr                                                       True                                              37m
│               ├─BootstrapReady                                                         True                                              38m
│               ├─InfrastructureReady                                                    True                                              37m
│               └─NodeHealthy                                                            False  Info      WaitingForNodeRef                38m
└─Workers
  └─MachineDeployment/kube-9bjwe-default-worker-ndjvg                                    False  Warning   WaitingForAvailableMachines      39m    Minimum availability requires 1 replicas, current 0 available
    │           └─Available                                                              False  Warning   WaitingForAvailableMachines      39m    Minimum availability requires 1 replicas, current 0 available
    └─Machine/kube-9bjwe-default-worker-ndjvg-77c9f86c95xcb95d-7dl45                     False  Info      WaitingForBootstrapData          38m    0 of 2 completed
      │           ├─BootstrapReady                                                       False  Info      WaitingForControlPlaneAvailable  38m
      │           ├─InfrastructureReady                                                  False  Info      WaitingForBootstrapData          38m
      │           └─NodeHealthy                                                          False  Info      WaitingForNodeRef                39m
      └─BootstrapConfig - KubeadmConfig/kube-9bjwe-default-worker-bootstrap-b5bb2-stmgv  False  Info      WaitingForControlPlaneAvailable  38m

❯ openstack coe cluster list
+--------------------------------------+-----------------------------+--------------+------------+--------------+--------------------+---------------+
|                 uuid                 |             name            |   keypair    | node_count | master_count |       status       | health_status |
+--------------------------------------+-----------------------------+--------------+------------+--------------+--------------------+---------------+
| 6885e7fb-a435-46de-8f59-6f997df43159 | default-admin-magnum-test-1 | arkadmin-key |          1 |            1 | CREATE_IN_PROGRESS | None          |
+--------------------------------------+-----------------------------+--------------+------------+--------------+--------------------+---------------+
❯ openstack coe cluster show 6885e7fb-a435-46de-8f59-6f997df43159
+----------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|        Field         |                                                                                Value                                                                                |
+----------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status               | CREATE_IN_PROGRESS                                                                                |
| health_status        | None                                                                                |
| cluster_template_id  | 899345fd-4150-4215-abfb-9334093f3aba                                                                                |
| node_addresses       | []                                                                                |
| uuid                 | 6885e7fb-a435-46de-8f59-6f997df43159                                                                                |
| stack_id             | kube-9bjwe                                                                                |
| status_reason        | CAPI Cluster status: Provisioned: Cluster kube-9bjwe is Provisioned. CAPI OpenstackCluster status reason: Successfulcreatemonitor: Created monitor k8s-clusterapi-cluster-magnum-system-kube-9bjwe-kubeapi-6443 with id 106df097-4b51-43de-a3b1-d6640029a1b5 |
| created_at           | 2023-07-19T13:37:05+00:00                                                                                |
| updated_at           | 2023-07-19T13:38:11+00:00                                                                                |
| coe_version          | None                                                                                |
| labels               | {'kube_tag': 'v1.27.3', 'boot_volume_size': '40', 'boot_volume_type': 'rbd1', 'master_lb_floating_ip_enabled': 'false', 'audit_log_enabled': 'true', 'availability_zone': 'nova', 'auto_scaling_enabled': 'False', 'auto_healing_enabled': 'False'}          |
| labels_overridden    | {}                                                                                |
| labels_skipped       | {}                                                                                |
| labels_added         | {'availability_zone': 'nova', 'auto_scaling_enabled': 'False', 'auto_healing_enabled': 'False'}                                                                                |
| fixed_network        | None                                                                                |
| fixed_subnet         | None                                                                                |
| floating_ip_enabled  | False                                                                                |
| faults               |                                                                                |
| keypair              | arkadmin-key                                                                                |
| api_address          | None                                                                                |
| master_addresses     | []                                                                                |
| master_lb_enabled    | True                                                                                |
| create_timeout       | 60                                                                                |
| node_count           | 1                                                                                |
| discovery_url        |                                                                                |
| docker_volume_size   | None                                                                                |
| master_count         | 1                                                                                |
| container_version    | None                                                                                |
| name                 | default-admin-magnum-test-1                                                                                |
| master_flavor_id     | m1.medium                                                                                |
| flavor_id            | m1.medium                                                                                |
| health_status_reason | {}                                                                                |
| project_id           | 978a5ab908fc477f9fa42c348e2c54d2                                                                                |
+----------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

No errors in the last 100 lines of deploy/capo-controller-manager. The only error in deploy/capi-controller-manager is just the timeouts on the reconciliation checks for the cluster.
I'll update once the cluster errors out with the status_reason

As an update, at over 2 hours in Magnum still hasn't errored out. Current status shows: CREATE_IN_PROGRESS and status reason is CAPI Cluster status: . CAPI OpenstackCluster status reason: . All other checks I've done look the same as what I posted in the previous comment.
I'm not sure what the timeout is - I don't think I've waited this long before with this issue.

@runlevel-six can you take a screenshot of the console of the vm?

Not much to see, but here you go:

In debugging this, it was determined that a network change on our end was the cause of cloud-init being unable to run the user_data components. Closing this issue as such. Thank you @mnaser for the debugging assistance!


[FR] Allow custom root domain option for hosts file (Pi-hole)

Describe the solution you'd like
It would be nice to have a way to specify a root domain name to use in the hosts file referenced in #942 instead of the current .pivpn domain. This could be added as a environment variable and referenced in scripts/wireguard/makeCONF.sh instead of statically appending .pivpn
Describe alternatives you've considered
Currently, you have to manually edit the /etc/pivpn/hosts.wireguard file to change the root domain for each client individually.

Moving to discussions.


[Doc Update] document hostRedirectUrl for external OAuth flow

As of In TeamsJS version 2.11.0 or later, apps must provide a third url parameter, hostRedirectUrl. (Source) This PR should help developers to implement the external auth flow, correctly.
Unfortunately, there are several clients that don't seem to implement this but this is not part of the docs

https://github.com/OfficeDev/microsoft-teams-library-js/issues/1696#issuecomment-1979154860

Caused by

https://github.com/OfficeDev/microsoft-teams-library-js/issues/1696#issuecomment-1971904831

Relates to docs PR

https://github.com/MicrosoftDocs/msteams-docs/pull/10598

Further outdated Resources
The following examples are also outdated since they assume the initiating client is always teams client (msteams://) but could be M365 and Outlook mobile / new Outlook Windows Desktop app

https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/a73ee669a4592e5f82f385b69c297648285e2caa/samples/tab-external-auth/csharp/TabExternalAuth/Views/Auth/GoogleEnd.cshtml#L22
https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/a73ee669a4592e5f82f385b69c297648285e2caa/samples/tab-external-auth/nodejs/src/components/ClosePopup.js#L15

@onmomo please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="Starmind"]

@v-vanv @mobajemu-msft please have a look.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/how-to/authentication/auth-oauth-provider.md
92
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

@v-vanv @mobajemu-msft please have a look.

Hey @Wajeed-msft would you mind taking a look as well? Thank you.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/how-to/authentication/auth-oauth-provider.md
92
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

@onmomo I've reviewed the PR and added suggestions, request you to update the doc.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/how-to/authentication/auth-oauth-provider.md
92
15
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/how-to/authentication/auth-oauth-provider.md
94
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/tabs/how-to/authentication/auth-oauth-provider.md
94
14
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.


Sync test262 error file

The result of make test262-update

Weird indeed!

8be0358dd7b767e6665effb6157a77f0ab0de514 broke -c test262.conf -a. With that commit reverted the errors file is unchanged (i.e., this PR is not necessary.)
I know what the problem is, I'll open a pull request.

Aha! Thanks for checking!


Documentation errors loading json libs

Dear @hiukim,
There is a missing  tag in the documentation example: face mesh

And another not fully detected error:
At minimal example there are at least 2 CDN jsons files are missing.
<EMAIL_ADDRESS>and
<EMAIL_ADDRESS>they should be:
<EMAIL_ADDRESS>and
?

the doc is fixed. thx


support retry

Support retry (which in Cucumber-Ruby is implemented in the filter pipeline)
@brasmusson @mattwynne can you please give more detail or tag someone who can?

The retry feature in cucumber-ruby uses two extension points. Filters (which I described in #5) and events.
Here's the filter for retry: https://github.com/cucumber/cucumber-ruby/blob/master/lib/cucumber/filters/retry.rb
The filter (which sits on the chain between the compiler and the runner) listens for the test_case_finished event and, if the test case failed, pumps it down the chain and into the runner again.


eth_estimateGas returns error when using MM

Signed-off-by: nikolay<EMAIL_ADDRESS>Description:

Remove the eth_estimateGas validation till the method is not fully implemented
Related issue(s):
Fixes #836
Notes for reviewer:

Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

Codecov Report
Base: 73.90% // Head: 73.90% // No change to project coverage :thumbsup:

Coverage data is based on head (20dceae) compared to base (ca4b162).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #837   +/-   ##
=======================================
  Coverage   73.90%   73.90%
=======================================
  Files          29       29
  Lines        1774     1774
  Branches      323      323
=======================================
  Hits         1311     1311
+ Misses        370      369    -1
- Partials       93       94    +1

Impacted Files
Coverage Δ

packages/server/src/validator/methods.ts
100.00% <ø> (ø)

packages/server/src/server.ts
76.88% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Closing this one, as new one was opened.


[wrt] Add auto tests for wrt-security-android-tests

Impacted TCs num(approved): New 0, Update 4, Delete 0
Unit test Platform: Android
Android test result summary: Pass 4, Fail 0, Block 0

LGTM


Firestore Repeatedly Returning Error: 5 NOT_FOUND

I found support for this issue from the firebase library but the issue exists in this library as well.
cloud.google.com/support told me this was "related to code and implementation" and "falls outside the scope of GCP tech support" even though I have the Enhanced Support for $500 / mo.
The issue is that if you're not using a database with the default name you have to explicitly declare the databaseID when instantiating the Firestore object. These docs never mention that or display an example of a database with a custom ID. The example given:
const {Firestore} = require('@google-cloud/firestore');

// Create a new client
const firestore = new Firestore();

async function quickstart() {
  // Obtain a document reference.
  const document = firestore.doc('posts/intro-to-firestore');

  // Enter new data into the document.
  await document.set({
    title: 'Welcome to Firestore',
    body: 'Hello World',
  });
  console.log('Entered new data into the document');

  // Update an existing document.
  await document.update({
    body: 'My first Firestore app',
  });
  console.log('Updated an existing document');

  // Read the document.
  const doc = await document.get();
  console.log('Read the document');

  // Delete the document.
  await document.delete();
  console.log('Deleted the document');
}
quickstart();

will fail unless the custom database ID is added explicitly as so:
const firestore = new Firestore({
    databaseId: 'custom-name'
});

it's probably best if you add the projectId there explicitly as well:
const firestore = new Firestore({
    projectId: 'my-project',
    databaseId: 'custom-name'
});

The error message for trying to write to the database without an explicit ID is unhelpful:
Error: 5 NOT_FOUND:
    at callErrorFromStatus (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@grpc/grpc-js/build/src/call.js:31:19)
    at Object.onReceiveStatus (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@grpc/grpc-js/build/src/client.js:193:76)
    at Object.onReceiveStatus (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:360:141)
    at Object.onReceiveStatus (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:323:181)
    at /Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@grpc/grpc-js/build/src/resolving-call.js:129:78
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
for call at
    at ServiceClientImpl.makeUnaryRequest (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@grpc/grpc-js/build/src/client.js:161:32)
    at ServiceClientImpl.<anonymous> (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@grpc/grpc-js/build/src/make-client.js:105:19)
    at /Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@google-cloud/firestore/build/src/v1/firestore_client.js:237:29
    at /Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/google-gax/build/src/normalCalls/timeout.js:44:16
    at repeat (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/google-gax/build/src/normalCalls/retries.js:82:25)
    at /Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/google-gax/build/src/normalCalls/retries.js:125:13
    at OngoingCallPromise.call (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/google-gax/build/src/call.js:67:27)
    at NormalApiCaller.call (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/google-gax/build/src/normalCalls/normalApiCaller.js:34:19)
    at /Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/google-gax/build/src/createApiCall.js:112:30
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Caused by: Error
    at _firestore._traceUtil.startActiveSpan (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@google-cloud/firestore/build/src/write-batch.js:438:27)
    at DisabledTraceUtil.startActiveSpan (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@google-cloud/firestore/build/src/telemetry/disabled-trace-util.js:16:16)
    at WriteBatch.commit (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@google-cloud/firestore/build/src/write-batch.js:436:43)
    at /Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@google-cloud/firestore/build/src/reference/document-reference.js:354:31
    at DisabledTraceUtil.startActiveSpan (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@google-cloud/firestore/build/src/telemetry/disabled-trace-util.js:16:16)
    at DocumentReference.set (/Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@google-cloud/firestore/build/src/reference/document-reference.js:346:43)
    at /Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/index.js:35:49
    at /Users/billy/GitHub/trifle-labs/mmorps-gcp/functions/node_modules/@google-cloud/functions-framework/build/src/function_wrappers.js:100:29
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  code: 5,
  details: '',
  metadata: Metadata {
    internalRepr: Map(1) { 'x-debug-tracking-id' => [Array] },
    options: {}
  },
  note: 'Exception occurred in retry method that was not classified as transient'
}

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is this a client library issue or a product issue?
This is the client library for "@google-cloud/firestore" .

Did someone already solve this?

[x] Search the issues already opened: https://github.com/googleapis/nodejs-firestore/issues
[x] Search the issues on our "catch-all" repository: https://github.com/googleapis/google-cloud-node

Closest thing is this which has a similarly unhelpful error message because the projectId was not set but no reference to databaseId.

[x] Search or ask on StackOverflow (engineers monitor these tags): http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js

Do you have a support contract?

[x] Please create an issue in the support console to ensure a timely response.

If the support paths suggested above still do not result in a resolution, please provide the following details.
Environment details

OS: macOS 14.6.1 (23G93)
Node.js version: v18.20.3
npm version: 10.7.0
@google-cloud/firestore version: 7.10.0

Steps to reproduce

Make your first database with a custom name.
write a doc to the collection as outlined above

Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

I will inform the maintainers of documentation that we should include a named database example. https://cloud.google.com/nodejs/docs/reference/firestore/latest/firestore/firestore#examples


Relating model parameters

It would be nice if some parameters can be fixed to others.  For example, you might want the lens galaxies to be entered on the lens masses.  Or one could imaging relating the mass to the light using some function.  This would reduce the effective number of parameters, but might be hard to code.

Derived parameters are there now with #204, but it's still not easily possible to add a copy prior. The prior system would need access to the full list of parameters for this to work. Copied parameters would also necessarily have to come after the parameters they reference, which could be derived as well.


reorder organizations migration

Post merging the organizations migration, we discovered that the naming of the migration could result in it being run out of order. This PR renames the migration to ensure it is run in sequential order

MariaDB [infrastructure]> select * from knex_migrations;
+----+--------------------------------------------------+-------+---------------------+
| id | name                                             | batch | migration_time      |
+----+--------------------------------------------------+-------+---------------------+
|  1 |<PHONE_NUMBER>5119_initial_db.js                     |     1 | 2022-11-07 03:46:00 |
|  2 |<PHONE_NUMBER>5152_v2_10_validation.js               |     1 | 2022-11-07 03:46:00 |
|  3 |<PHONE_NUMBER>1152_queuedstatus.js                   |     2 | 2022-12-16 00:05:30 |
|  4 |<PHONE_NUMBER>4648_add_admin_advanced_tasks.js       |     3 | 2023-01-31 20:55:05 |
|  5 |<PHONE_NUMBER>0000_disabled_deploytargets.js         |     4 | 2023-02-21 00:34:58 |
|  6 |<PHONE_NUMBER>0000_envvar_index.js                   |     5 | 2023-02-27 04:40:25 |
|  7 |<PHONE_NUMBER>0000_task_admin_fields.js              |     6 | 2023-02-28 05:01:02 |
|  8 |<PHONE_NUMBER>3434_remove_monitoring_urls.js         |     7 | 2023-02-28 06:22:21 |
|  9 |<PHONE_NUMBER>0000_add_project_build_image.js        |     8 | 2023-04-24 00:43:31 |
| 10 |<PHONE_NUMBER>0000_advanced_task_default_optional.js |     9 | 2023-07-03 22:54:12 |
| 11 |<PHONE_NUMBER>0000_shared_baas_bucket.js             |    10 | 2023-07-17 09:12:24 |
| 12 |<PHONE_NUMBER>0000_organizations.js                  |    11 | 2023-09-15 04:46:56 |
+----+--------------------------------------------------+-------+---------------------+


[stable/grafana] Added option to add Sidecar containers (#11650)

What this PR does / why we need it:
It adds the option to specify containers to the grafana pod. This enables adding a openid-connect proxy.

Updated README
Updated values.yaml
Added extraContainer component templates

/ok-to-test

/lgtm
@MahaGamal, Thanks for contributing, and congrats on your first contribution to Helm! :)


Peek method for IWaveProvider

I'm trying to performt FFT using NAudio in Unity game engine. It fails for either WASAPI or ASIO. We want to have visualizations in our application for both local and streamed audio content. The common denominator between these is the IWaveProvider interface. It would be very useful if you could implement a Peek() method so that we could use it to grab audio data without clipping the audio (Read() advances the stream position).
Thank you.

I'm not sure what you're asking for. You can construct a pipeline passing your IWaveProvider through to another, so that as it is read it also performs FFT. If you look at the source code for the WPF demo, you'll see the SampleAggregator class which shows an example of doing this

I'll look into it. Thank you.