Taproot sig message

These changes replace unwrap() with get_or_insert_with() in cache methods. The commits explain why performance shouldn't be lost.

Thinking about it a bit more, if cache miss is very rare we could make the closures #[cold] possibly saving bunch of instructions in the cache. Seems better than saving one addition. But I wouldn't date to mess with it without actually measuring.

I am in PTO at the moment but I did a quick look and I think I am going to merge this.
Just I am not doing it now because I need some time to dedicate to this and other comments in the PR...


Adds pool to several scheduler and monitor metrics

Changes proposed in this PR

instead of statically defining the metrics, fetching them dynamically by title
adding the pool name to the metric titles via metric-title

Why are we making these changes?
This is another PR for the effort to "poolify" the necessary metrics.

Moved to #989


Tests of flutter_test package fails

System info
The issue occurs on: Android
Plugin name: package_info_plus
Plugin version: 0.6.4
Flutter doctor output:
[√] Flutter (Channel unknown, 1.24.0-10.2.pre, on Microsoft Windows [Version 10.0.19041.804], locale ro-RO)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[√] Chrome - develop for the web
[√] Android Studio (version 4.1.0)
[√] Connected device (4 available)

• No issues found!

Steps to Reproduce
In order to test my application, I use the flutter_test package. The only tests that fail are those which go through your plugin. My guess is that flutter_test is not compatible with your plugin.

Install flutter_test package
Make an app that displays the version of it
Create a test that checks the version of the app using flutter_test
Run the test on your app

I attach a screenshot of the exceptions that cause the tests to fail:

Logs

[  +90 ms] executing: [D:\Users\Flutter/] git -c log.showSignature=false log -n 1 --pretty=format:%H
[  +51 ms] Exit code 0 from: git -c log.showSignature=false log -n 1 --pretty=format:%H
[        ] 022b333a089afb81c471ec43d1f1f4f26305d876
[        ] executing: [D:\Users\Flutter/] git tag --points-at HEAD
[  +37 ms] Exit code 0 from: git tag --points-at HEAD
[        ] 1.24.0-10.2.pre
[   +7 ms] executing: [D:\Users\Flutter/] git rev-parse --abbrev-ref --symbolic @{u}
[  +27 ms] Exit code 128 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] fatal: HEAD does not point to a branch
[  +12 ms] executing: [D:\Users\Flutter/] git rev-parse --abbrev-ref HEAD
[  +26 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] HEAD
[  +27 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[   +1 ms] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterWebSdk' is not required, skipping update.
[   +2 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +44 ms] executing: D:\Android\android-sdk\platform-tools\adb.exe devices -l
[  +35 ms] List of devices attached
[   +4 ms] Artifact Instance of 'AndroidGenSnapshotArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'AndroidInternalBuildArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'IOSEngineArtifacts' is not required, skipping update.
[  +47 ms] Downloading Web SDK...
[ +738 ms] Content
https://storage.googleapis.com/flutter_infra/flutter/07c1eed46b9d9b58df78566e9b8b2e42e80d3380/flutte
r-web-sdk-windows-x64.zip md5 hash: rwW39r8dlFZZRIG8W2XCLg==
[+6249 ms] Downloading Web SDK... (completed in 7,0s)
[+3145 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update.
[        ] Artifact Instance of 'FlutterRunnerDebugSymbols' is not required, skipping update.
[  +61 ms] Multiple devices found:
[  +16 ms] Web Server (web) • web-server • web-javascript • Flutter Tools
[   +1 ms] Chrome (web)     • chrome     • web-javascript • Google Chrome 88.0.4324.190
[   +1 ms] Edge (web)       • edge       • web-javascript • Microsoft Edge 88.0.705.81
[   +1 ms] [0]: Web Server (web-server)
[        ] [1]: Chrome (chrome)
[        ] [2]: Edge (edge)
[   +1 ms] Please choose one (To quit, press "q/Q")
[        ] :
[+2607 ms] q
[   +3 ms] "flutter run" took 47.458ms.
[   +4 ms]
           #0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
           #1      DeviceManager._chooseOneOfAvailableDevices
(package:flutter_tools/src/device.dart:306:7)
           <asynchronous suspension>
           #2      DeviceManager.findTargetDevices (package:flutter_tools/src/device.dart:294:37)
           <asynchronous suspension>
           #3      FlutterCommand.findAllTargetDevices
           (package:flutter_tools/src/runner/flutter_command.dart:1106:28)
           <asynchronous suspension>
           #4      RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:427:15)
           <asynchronous suspension>
           #5      FlutterCommand.verifyThenRunCommand
           (package:flutter_tools/src/runner/flutter_command.dart:1040:5)
           <asynchronous suspension>
           #6      FlutterCommand.run.<anonymous closure>
           (package:flutter_tools/src/runner/flutter_command.dart:931:27)
           <asynchronous suspension>
           #7      AppContext.run.<anonymous closure>
(package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #8      AppContext.run (package:flutter_tools/src/base/context.dart:149:12)
           <asynchronous suspension>
           #9      CommandRunner.runCommand (package:args/command_runner.dart:197:13)
           <asynchronous suspension>
           #10     FlutterCommandRunner.runCommand.<anonymous closure>
           (package:flutter_tools/src/runner/flutter_command_runner.dart:284:9)
           <asynchronous suspension>
           #11     AppContext.run.<anonymous closure>
(package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #12     AppContext.run (package:flutter_tools/src/base/context.dart:149:12)
           <asynchronous suspension>
           #13     FlutterCommandRunner.runCommand
           (package:flutter_tools/src/runner/flutter_command_runner.dart:230:5)
           <asynchronous suspension>
           #14     run.<anonymous closure>.<anonymous closure>
(package:flutter_tools/runner.dart:63:9)
           <asynchronous suspension>
           #15     run.<anonymous closure> (package:flutter_tools/runner.dart:61:12)
           <asynchronous suspension>
           #16     AppContext.run.<anonymous closure>
(package:flutter_tools/src/base/context.dart:150:19)
           <asynchronous suspension>
           #17     AppContext.run (package:flutter_tools/src/base/context.dart:149:12)
           <asynchronous suspension>
           #18     runInContext (package:flutter_tools/src/context_runner.dart:70:10)
           <asynchronous suspension>
           #19     main (package:flutter_tools/executable.dart:90:3)
           <asynchronous suspension>

[   +5 ms] ensureAnalyticsSent: 0ms
[   +1 ms] Running shutdown hooks
[        ] Shutdown hooks complete
[        ] exiting with code 1

No issues found! (ran in 3.4s)

[√] Flutter (Channel unknown, 1.24.0-10.2.pre, on Microsoft Windows [Version 10.0.19041.804], locale
    ro-RO)
    • Flutter version 1.24.0-10.2.pre at D:\Users\Flutter
    • Framework revision 022b333a08 (3 months ago), 2020-11-18 11:35:09 -0800
    • Engine revision 07c1eed46b
    • Dart version 2.12.0 (build 2.12.0-29.10.beta)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at D:\Android\android-sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (3 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 88.0.4324.190
    • Edge (web)       • edge       • web-javascript • Microsoft Edge 88.0.705.81

• No issues found!

Hi @AnghelAndrei28 I believe that the issue is trying to use a plugin from a Flutter Widget test.
You should isolate dependencies to platform specific plugins when writing tests and not call into plugins from them, but rather to fakes or mocks.
Or if you want to test something that uses a platform plugin, use Integration Tests (also known as e2e or Flutter Driver tests): https://flutter.dev/docs/testing/integration-tests
I will mark this issue as closed, as it is unrelated to the code in the plus packages.


Added server list button shown when multiple servers register

Currently doesn't show until you visit the front end.

Currently doesn't show until you visit the front end.

Ye, so my guess it that Gunicorn is lazyloading the app.
Just add this option in the entrypoint.sh where gunicorn is started: https://docs.gunicorn.org/en/stable/settings.html#preload-app

@Tanjitsu Did you test this branch btw? Should me merge, do we need to change more?


Improve FAQ Readability: enhance h3 format and layout

The current FAQ section lacks clear visual distinction between different sections.  The h3 formatting, margins, and overall layout require design improvements to enhance readability

https://github.com/google/osv.dev/pull/2962


Images broken

On masters README.md
This project is part of our comprehensive "SweetOps" approach towards DevOps. Share via Email Share on Google+ Share on Facebook Share on Reddit Share on LinkedIn Share on Twitter

It's 100% Open Source and

I think the issue here is the markdown syntax

I think there was some kind of intermittent failure. Are the images still broken for you?


Fix definition of find methods

Hi, we've just started using Motor-Types and saw a mismatch between these types and the code. These find methods immediately return async cursors to be awaited; see https://motor.readthedocs.io/en/stable/api-tornado/gridfs.html#motor.motor_tornado.MotorGridFSBucket.find.

Thanks for the detailed explanation @L0RD-ZER0!

In the suggested fix, you have used the async keyword before find. It more or less marks that a function returns a coroutine, which is something you do await on.

I think you might have misread the diff: this PR removes the async keyword. The async def is what currently resides in master.
We ran into this issue because we have a snippet like this:
        cursor = db.fs.find()
        return [dict(result) for result in await cursor.to_list()]

This runs correctly, but after we installed Motor-Types gave us a typing error:
$ mypy app
tests/test_app.py:406: error: "Coroutine[Any, Any, AsyncIOMotorGridOutCursor]" has no attribute "to_list"  [attr-defined]
tests/test_app.py:406: note: Maybe you forgot to use "await"?

when we added await to the db.fs.find, the test failed, so it seemed clear that the typing did not match the source. The documentation says that find is not an async function, hence why I made this PR to remove the async keyword for find.

Ahhhhh, you're right. My apologies. Give me a moment.

Ahhhhh, you're right. My apologies. I indeed misread the diff. Merged!

Thanks for taking a look so quickly!! And thanks for Motor-Types, typing saves us so much dev time and I know maintaining type definitions is heavily on the tedious end of the programming spectrum.

I'll update the PyPI with a BugFix version tomorrow morning (roughly 7~ hours from now). Once again, I sincerely apologise for me not handling the issue properly. Thanks again for pointing the error out!!

PyPI listing has now been updated. You can update the package using pip install -U motor-types or the relevant command for your package manager.


P2009

First of all, according to my investigation results, it can be guessed that it is a bug in the engine. I also tried to find the specific problem, but failed
model RoleMenu {
  id         Int        @id @default(autoincrement())
  role_id    Int
  menu_id    Int
  deleted_at DateTime?

  @@unique([role_id, menu_id])
}

let role_id_menu_ids = vec![role_menu::role_id_menu_id(2, 1),role_menu::role_id_menu_id(2, 2),role_menu::role_id_menu_id(2, 3), role_menu::role_id_menu_id(2, 4)];
client
        .role_menu()
        .delete_many(role_id_menu_ids)
        .exec()
        .await?

or

client
        .role_menu()
        .update_many(
            role_id_menu_ids,
            vec![role_menu::deleted_at::set(Some(now_time()))],
        )
        .exec()
        .await?

specific error：
Error executing query: P2009 - `deleteManyRoleMenu`: Field does not exist in enclosing type.

or

Error executing query: P2009 - `updateManyRoleMenu`: Field does not exist in enclosing type.

For those that are having this issue, it seems the bug exists for create_many but not for create so I solved by looping inside a ._transaction() call like this:
    // Save to db
    prisma_client
        ._transaction()
        .run(|client| async move {
            for apr in aprs {
                client
                    .token_apr()
                    .create(
                        apr.apr,
                        token::UniqueWhereParam::KeyEquals(apr.token_key),
                        vec![token_apr::apr_set::connect(apr_set::id::equals(apr_set.id))],
                    )
                    .exec()
                    .await?;
            }
            Ok::<(), anyhow::Error>(())
        })
        .await?;

Thanks for reminding me of this issue - Took a look at the DMMF schema and it turns out that update_many and delete_many take WhereInput and not WhereUniqueInput, so using compound keys (which are only available in WhereUniqueInput is not actually valid. This should get fixed in 0.7.0 since the way types are being generated is changing.
Also @apollo-sturdy I noticed you're manually using UniqueWhereParam - I'd recommend you don't do that.
token::key::equals(apr.token_key) should work and will shield you against breaking changes to UniqueWhereParam.


Fix: site.pp content is not being imported

This closes #399 and fixes #322

Coverage increased (+0.06%) to 90.88% when pulling 64e42e18c633063a0d271612243528bbde9ad6ca on DavidS:use-site-pp-on-puppet4 into c6639523b7989fd1c935905f0348f4267d288442 on rodjek:master.

Coverage increased (+0.06%) to 90.88% when pulling b6b5b426feff97a4fe0f62cc0a627bf2dba1a1ab on DavidS:use-site-pp-on-puppet4 into c6639523b7989fd1c935905f0348f4267d288442 on rodjek:master.


Use no delay provision startegy.

Summary:
The current provision startegy considers the pending tasks in Mesos.
This number can be out dated. We should only consider the state from
Jenkins and launch the Jenkins agent immediately without a delay.
JIRA issues: D2IQ-68723

We probably should also bump USI.

Ok, we're following NoDelayProvisionerStrategy from kubernetes-plugin with minor changes to logging.


CliffordGate**0.5/-0.5

This one https://github.com/quantumlib/Cirq/pull/1417 automatically closed after not "pull rebasing".

@vtomole Yes, we should definitely have a formatting check as part of the continuous integration.

At some point I'll write an incremental format checker + incremental format applier, that only checks and only touches code you've edited.

@Strilanc  Fix the nits by using Emacs to format and it looks like it has different opinions from autopep8.

Ready for merge.


No colors

GHC 8.6.5, ghcid 0.7.5 and no colors in gnome-terminal (Ubuntu 16.04). I seem to recall that they were there. Is it a known problem?

Okay, this is the problem only until first reload. Still, fills like a bug.

I get this when running :Ghcid; might be related?
Unknown flag: --color

See https://github.com/ndmitchell/ghcid/blob/master/README.md#i-only-see-source-spans-or-colors-on-errorswarnings-after-the-first-load and https://twitter.com/ndm_haskell/status/1159207825194856449?s=20 which gives the background. Known issue, and working as intended.

I see, thanks!


Feature/spring operator

The [Spring] operator is a port of this spring movement function
https://github.com/tooll3/t3/assets/3755089/4b21f6f3-0994-4d54-bc37-ec14689ae970

I love it! We should add a small comment to [Damp] so people will find this alternative interpolation.
In the long term, it might also be cool to have something like [DampPoints]. However this will involve a secondary structured buffer to store the velocities. So it's probably going to be more involved.

I'm glad you like it! I'll will make its vec2 and vec3 siblings.
For this I think I'll need to have the spring function somewhere else in order to use it multiple times.
Should I add to MathUtils.cs ?


remove cache-loader from loaders list

Feature to document
cache-loader deprecated in favor https://webpack.js.org/configuration/other-options/#cache
Author(s)
Any
Additional information
Loader: https://github.com/webpack-contrib/cache-loader
[ ] I am willing to work on this issue and submit a pull request.

wip

@anshumanv Do you need help?

ah this got misplaced in my todo, will PR today


Update to new UI

Google has since updated their UI to a 2 column layout.
Implement:

Use grid with 2 columns for [ "Sign in"  / Input box ]
Change page background-color to #f1f4f9
Possibly implement Email prompt first then asks for password.
Keep Mobile layout

a little hard to understand, you should have posted it directly :)
THANKS


Cask request: Authy Desktop

Cask details
Please fill out as much as possible. Before you do, note we cannot support Mac App Store-only apps.
Name: Authy Desktop
Homepage: https://authy.com/
Download URL: https://s3.amazonaws.com/authy-electron-repository-production/stable/1.0.10/darwin/x64/installer.dmg
Description: Two-Factor authentication desktop application.

https://github.com/caskroom/homebrew-cask/pull/34923


Allow OPTIONS requests without user credentials

Per https://www.w3.org/TR/cors/#preflight-request, OPTIONS (CORS preflight) requests should "exclude user credentials".
This commit ensures that basic-auth-connect ignores authentication server-side when there is an OPTIONS request.

Not all OPTIONS requests are even CORS related. It is best if you set up your app such that preflight requests are terminated with a preflight response before invoking this middleware.

Thanks for letting me know! I wasn't aware of any other uses for the OPTIONS request.


[Blog] Prepare a companion blog post for CNTi updates

Describe the update:

DRAFT blog post for CNTi Certification v2.0 launch at ONE Summit
blog post will be a companion to the Day 1 ONE Summit Press Release
may be published after GB vote (GB votes on April 29, publish on April 30)

Describe why update is needed

to share updates made on the CNTI program
to announce availability of the CNTi Certification v2.0 release
to promote the session about CNTI at ONE Summit on May 1
to display quotes from certified/interested vendors
to display quotes from interested CSPs

Additional context

Taylor and Olivier are scheduled to speak at ONE Summit, which can be promoted in the blog post
if GB votes "greenlight" on April 29, then this press release can be published on April 30 and CNTi Certification v2.0 can be launched at ONE Summit

Tasks:

[x] start a drafted document > https://docs.google.com/document/d/1gdsjaryIgMxYhiNN5Q8YaXu05P64WOuI7dd9q4f3BPM/edit
[ ] share document with Jill, LFN
[ ] gather quotes from interested vendors
[ ] gather quotes from interested CSPs
[ ] iterate on press release
[ ] peer review
[ ] final draft of press release
[ ] tbd

Draft started at https://docs.google.com/document/d/1gdsjaryIgMxYhiNN5Q8YaXu05P64WOuI7dd9q4f3BPM/edit
Suggested areas to cover

CNTI progress since joining LFN
Background & details on certification (why it matters, how it works, how to get involved, etc.)
How to self-certify a CNF
How to contribute to CNTi
Endorsements from Vendors
Endorsements from CSPs
CNTi sessions at ONE Summit and Dev & Testing Forum

WIP Content started for:

How to contribute to CNTi
Endorsements from Vendors
CNTi sessions at ONE Summit and Dev & Testing Forum

Draft updated at https://docs.google.com/document/d/1gdsjaryIgMxYhiNN5Q8YaXu05P64WOuI7dd9q4f3BPM/edit

@lixuna @taylor - Please review the draft CNTi Blog.  It starts on page 5 of this document:  https://docs.google.com/document/d/1gdsjaryIgMxYhiNN5Q8YaXu05P64WOuI7dd9q4f3BPM/edit?usp=sharing


[user] weird behavior with explicit password field

Specifying the following user schema (including a password field):
curl 'https://dezik.spacedog.io/1/schema/user' -X PUT --data '{"user":{"_id":"id","_type":"object","username":{"_type":"string","_required":true,"_extra":{"com.spacedog.tsygan::id":"7abda724-db34-4c8d-8033-89f7aeb9ab68","com.spacedog.tsygan::parent":"user","com.spacedog.tsygan::related":""},"_array":false},"email":{"_type":"string","_required":true,"_extra":{"com.spacedog.tsygan::id":"26fb1082-e3d9-454e-8b17-c11e5b57299c","com.spacedog.tsygan::parent":"user","com.spacedog.tsygan::related":""},"_array":false},"password":{"_type":"string","_required":true,"_extra":{"com.spacedog.tsygan::id":"9ab7efa3-3d9f-4b18-b5aa-559b3556ca7e","com.spacedog.tsygan::parent":"user","com.spacedog.tsygan::related":""},"_array":false},"id":{"_type":"string","_required":true,"_array":false}}}'

Will get back from SpaceDog schema as this, with this weird "password": "******" field:
  "user": {
    "_id": "id",
    "_type": "object",
    "username": {
      "_type": "string",
      "_required": true,
      "_extra": {
        "com.spacedog.tsygan::id": "ecf029e8-cf40-43ee-a16c-b5a4eb017cc0",
        "com.spacedog.tsygan::parent": "user",
        "com.spacedog.tsygan::related": ""
      },
      "_array": false
    },
    "email": {
      "_type": "string",
      "_required": true,
      "_extra": {
        "com.spacedog.tsygan::id": "410fc1c0-b56f-4440-919e-e0907a93eaa1",
        "com.spacedog.tsygan::parent": "user",
        "com.spacedog.tsygan::related": ""
      },
      "_array": false
    },
    "password": "******",
    "id": {
      "_type": "string",
      "_required": true,
      "_array": false
    }
  },

Implementor may wish to specify a password field to store extra validation constraints (regexp).
Expectation would be to either:

return the field as it was specified
alternatively to not return it all

Looks like a side-effect of this https://github.com/spacedog-io/services/blob/master/services/src/main/java/io/spacedog/services/LogResource.java#L295 though I don't understand why this would alter the returned payload.


Package deployment using ZIP Deploy initiated.

Hi all,
I know there are several other issue related to the problem and some of them are closed.
But the last couple of weeks we keep getting more and more issues with the deployment of Azure Functions with the help of Zip Deployment.
We are using an Azure Function with Python with a Linux Service Plan.
Sometimes, it works instantly but sometimes the deployment is just stuck at
Package deployment using ZIP Deploy initiated.
This really needs to be fixed, imo

Hi @RoelVerhees , can you share more details like your app name or the deployment logs in which you're getting stuck and the time when you faced this issue?

Hi @RoelVerhees , if it is related to functions githubactions, can you please file it on this repo. Please feel free to re-open this issue with more details if the issue is related to the App-services github actions.


SBT PGP issue

For the same reason that pgpPassphrase I need to add another prefix in pgpPublicRing and pgpSecretRing
Please @FPerezP could you review? Thanks

Looks good!


Map trailing out params as Result for COM interface methods

This should rely on the retval attribute, but this is not currently included in the win32 metadata. https://github.com/microsoft/win32metadata/issues/207

Also transform trailing GUID*, void** parameters as a generic return value.

This has now been completed as of #909. Most COM methods and functions now provide a far superior calling experience.


Is it possible to resume a download that fails due to a network failure or similar

I've had success with resuming uploads using (as was suggested in a previous question that I asked):
UploadSessionStartAsync
UploadSessionAppendV2Async
UploadSessionFinishAsync
Is the means to resume a download similar? or even possible?
I can download using code such as:
using (DropboxClient dbx = GetAccessToken([myaccesstoken]))
            {
                  using (var response = await dbx.Files.DownloadAsync("/" + file))
                {
                    using (var fileStream = File.Create(localFilePath))
                    {
                        form1.Debuginfo += $"3\r\n";
                        (await response.GetContentAsStreamAsync()).CopyTo(fileStream);
                    }
                }
            }

I then copy it to a file and that works okay.
Could you offer any pointers on how I might resume such a download in the event of a newtwork failure?
I'd expect to have to get a session ID.  That leads me to believe that I'd need to create some sort of session for it.
Any direction is greatly appreciated
Steve

The Dropbox API v2 .NET SDK unfortunately doesn't offer resumable downloads like this, but I'll pass this along as a feature request. I can't promise if or when that might be implemented though.

Thanks @greg-db
Just some background on the reason it might be helpful.
The small app that I built, I've been using on remote systems where network connectivity is poor at best.
I've used the SDK's chunk upload feature to get logs and other info from those remote computers (without installing the dropbox client).  This method of uploading has greatly improved our success rate in getting the info we need without having to retry multiple times; especially on larger files.
Appreciate that there are no guarantees for the same in downloads.  Will just have to wait and see :-)
Regards
Steve

Thanks for the context @IamSierraCharlie !
By the way, for reference, while this isn't available in the SDK, the Dropbox API itself does support "Range Retrieval Requests" on "content-download style" endpoints, such as /2/files/download. That's a way to request only a certain portion of a file, and is likely what we would use to implement this feature request in the SDK, if/when we do so.
If it's important for your app, you could consider implementing that directly against the HTTPS endpoints, outside of the SDK functionality.

Thanks for your diection @greg-db
I've investigated this and have memanged some success in getting this to work.
I found it tricky, but in actual fact some of the techniquies used with the sdk seemed to work similarly with the HTTPS endpoints.
It would be great to have the functionality in the SDK for the sake of useability (I prefer to use the SDK if the option was available), but I'm happy with what I've achieved.
Thanks again for your direction - it is greatly appreciated.
Steve


DatafeedLoop async dispatch

Feature Request
Description of Problem:
In the current implementation of the AbstractDatafeedLoop, received events are dispatch synchronously and sequentially within the loop thread.
Here's bellow the part of code used to dispatch incoming events to registered listeners:
  protected void handleV4EventList(List<V4Event> events) {
    for (V4Event event : events) {
      if (event == null || event.getType() == null) {
        continue;
      }

      try {
        RealTimeEventType eventType = RealTimeEventType.valueOf(event.getType());
        for (RealTimeEventListener listener : listeners) {
          if (listener.isAcceptingEvent(event, bdkConfig.getBot().getUsername())) {
            eventType.dispatch(listener, event);
          }
        }
      } catch (IllegalArgumentException e) {
        log.warn("Receive events with unknown type: {}", event.getType());
      }
    }
  }

This might cause serious problems when a listener (e.g. RealTimeEventsListener)  takes long time to process an incoming event. For instance a call to an external service or even a database query.
Potential Solutions:
A potential solution is to dispatch received events using a configurable fixed thread pool:
  /** Executor service used to dispatch events to {@link RealTimeEventListener} list */
  private final ExecutorService executorService = Executors.newFixedThreadPool(10);

  protected void handleV4EventList(List<V4Event> events) {
    for (V4Event event : events) {
      if (event == null || event.getType() == null) {
        continue;
      }

      try {
        RealTimeEventType eventType = RealTimeEventType.valueOf(event.getType());
        for (RealTimeEventListener listener : listeners) {
          if (listener.isAcceptingEvent(event, bdkConfig.getBot().getUsername())) {
            this.executorService.execute(() -> {
              try {
                eventType.dispatch(listener, event);
              } catch (Exception e) {
                log.debug("An error has occurred while dispatching event={} to listener={}", event, listener, e);
              }
            });
          }
        }
      } catch (IllegalArgumentException e) {
        log.warn("Receive events with unknown type: {}", event.getType());
      }
    }
  }

Another solution is to leave that to the implementers of listeners (i.e BDK does nothing for you but gives you full control)
Given for the Spring Boot integration we start a thread for the DF loop, it would make sense to me to have a configurable thread pool for the DF loop, maybe if it is configured to a size of 0 it would mean do not used threads (or just YAGNI for now).
If it is not configured, what would be a good value for the number of threads? number of listeners? number of events? unbounded with newCachedThreadPool()?
also in your example the isAcceptingEvent should probably be called in the executor, i.e a different thread as users can override it it could be a long call too.


Empty string is registered as token

Hi!
I'm trying to use your component and I'm pretty much satisfied from it, but I've hit a rock when I'm pressing just space. It keeps adding tokens, which are pretty much in every case invalid.
I've tried using something like this in didEnterText delegate method:
var tokens = tagsTextField.texts
tokens.removeLast()
tagsTextField.resetTokens()
for token in tokens {
tagsTextField.textField.text = token
tagsTextField.completeCurrentInputText()
}
but this redraws all tags and I don't like that jump all the time.
Can you either remove the empty string as valid token or provide us a way to check the text before adding as a token.
Or probably best would be to add an array of invalid strings.
Using the develop branch (Swift 3.0 version) with Cocoapods
pod 'ICInputAccessory/TokenField', :git => 'https://github.com/polydice/ICInputAccessory.git' , :branch => 'develop'
Thanks.

Adding a delegate method to check if the input text is valid could be one of the approaches. I'll look into it. Thanks for the feedback.

Are you planning on supporting that soon or should I look for another alternative ?


Pagination on front page

Mobile browsers can't handle all courses in a table. Probably pagination is needed (or load more button).

Pagination is working but links to first and last page should be shown.


In discrete steps, Simplify the API

This PR contains a sequence of commits to simplify the API.
Class renames:

TraceContext to SpanContext
TraceContextSource to TraceContext
TraceContextCodec to TraceCodec

Removing porcelain api:

Span.createChild(..)
TraceContext.ChildSpanContext
logging methods in Span (replaced with event(message, payload)).

Look in the individual commits for the rationale to each.
It's clearer to see the value of the changes by looking at the HEAD of the branch rather than evaluating the patch.

@michaelsembwever thank you for sending this out. Per gitter, we are not on the same page.
It is apparent that either the goals of OpenTracing haven't been communicated well or you don't agree with them. :)  Especially given the comments that have come up in this PR, what you propose here is not an API simplification: it removes entire swaths of semantic functionality. If that's intended, call a spade a spade. If it's not, imagine writing (or actually write if you have the time!) example calling code that

serializes a Span to and from the wire (c.f. your enthusiasm for removing the Codec),
sets a trace attribute in a client process and reads it in a server/peer process (c.f. your enthusiasm for removing the attribute getter),
creates a child Span from a parent Span when the Tracer is not accessible (c.f. your removal of Span.startChild),
and creates a child Span that has a parent_id tag (c.f. your removal of ChildSpanContext)

... all without peeking through to the OpenTracing implementation.
As for naming (less important given the scope of the problems above):

SpanContext is an ok (if unconventional w.r.t. existing systems) name in my eyes... no strong feelings on my part, though
what you now call TraceContext (formerly TraceContextSource) is not about a single trace, nor is it a context object, so that name confuses me
TraceCodec does not encode or decode traces, it encodes or decodes a slender set of ids that refer to a span and a trace... and for that reason seems like a naming regression as well.

It is apparent that either the goals of OpenTracing haven't been communicated well …

Quite possibly. I am late to the game, but so will every subsequent person after me.
If there's documentation to which I obviously haven't read; do please reference them during the discussion.

... all without peeking through to the OpenTracing implementation.

There's a difference between "peeking through" the OpenTracing implementation, and using that OpenTracing implementation. I have presumed that the goal of OpenTracing is to provide a specification for different tracing implementations to implement. Not to provide universal documentation for all users of all different platforms.

what you now call TraceContext (formerly TraceContextSource) is not about a single trace, nor is it a context object, so that name confuses me

We're on the same page here, and that discussion continues in this PR.
The other bulleted points in your comment I'll reply to in context to the code and the previous ongoing discussions.

I'm torn between a point-by-point response to all of the various issues here and something higher-level. I'll go for the latter since it'll be less noisy for everyone involved...
I am thankful that you sent this out, as this review and some of the gitter traffic demonstrates (to me) that the current set of OpenTracing primitives apparently leads to mass confusion: surely a fault of the API/scheme, not the masses. :) Or maybe it's just missing documentation, but my instinct tells me that the problem is deeper than that.
I am going to try to send out a PR that basically gets rid of SpanContext as an API primitive... overall I think/hope it will make for an equally portable tracing API and less confusion for OpenTracing contributors present and future. In order to evaluate that I need to make sure I can adapt the (portable) OpenTracing client code I've already written with the revised/trimmed API... If I fail, then I'll come back and we can go through a lengthy micro-review (i.e., where this is headed at the moment).
Sound reasonable?
Ben

Thanks, Ben. In turn, I will post a PR with documentation of the Common Use Cases we've discussed when designing the API, with code examples of how each use case is solved by the current API.

Sounds reasonable @bensigelman
Outside of just API there's a number understandings I raised in https://github.com/opentracing/opentracing-java/pull/7#issuecomment-173814992
If any of these are wrong can you highlight them.

@yurishkuro Can you push these as documentation into opentracing.github.io ?
This really would be invaluable information for newcomers.

@michaelsembwever already in PR  opentracing/opentracing.github.io#34

@yurishkuro thanks for the examples.
They all match my previous understandings of what we're trying to achieve. So far I haven't been able to find any reasons why the API simplifications offered in the file changes here can't be adopted.
The examples do add context to two separate discussions in this PR: the getter method in SpanContext and the codec class. I'll add my thoughts to these existing discussions.

Summarising the status of the PR so far.

That TraceContext can be renamed to something better like SpanContext, and the renaming of Span.traceContext(), has been superseded by @bensigelman proposing to offer a patch that removes it altogether.
Removing the info/error methods in Span, has been agreed upon.
Removing Span.createChild(..) and ChildSpanContext remains a valid proposal, as there's no examples raised (yet) of where they are needed.
Renaming TraceContextSource to TraceContext. This depends on Ben's proposed patch to remove the TraceContext.
Rename TraceContextCodec to TraceCodec. There's confusion here because of the terms codec and serialisation. This can be spun off into a separate PR.

Actions to take.

Remove the "Rename TraceContextCodec to TraceCodec" from this PR. I will spawn a new PR suggesting alternative names, like SpanExtractor.
Wait for (agreement upon) Ben's patch to remove the TraceContext.
Evaluate naming of TraceContextSource (maybe Ben solves it).

Other suggestions that have been raised in this PR.

Tracer.startTrace(..) and tracer.jointrace(..) would be simpler as one method.
change Span event(String message, Map<String,String> payload); to Span event(String message, @Nullable Object payload);
Change the documentation on setAttribute(..) so the regular expression of keys is only a recommendation. This has been agreed upon.

Is this clear? Does everyone agree?

I sent out https://github.com/opentracing/opentracing-go/pull/40 (for better or worse, !Java since I wanted to compile against a working example implementation and a working caller that propagates across HTTP)...
@michaelsembwever if people like the direction of my RFC above, we can get rid of a lot of stuff here. And also save a lot of time and energy arguing about names that would no longer exist :)
PS: @michaelsembwever sorry I didn't respond to all of the various minor points above where you @bensigelman'd me -- I thought it would be wasted effort for both of us since so much of the debated material is presently in jeopardy :)

That's fine @bensigelman , i'll be happy to see the work here come to fruition any way possible.
As listed in my previous comment everything that this PR proposes is eventuating one way or another, plus more, and that makes me happy.
I'd only hoped that you got many more of these types of reviews opened before you started considering anything vaguely resembling a 1.0 release.

Closing this PR, the first step in a simpler API it superseded with https://github.com/opentracing/opentracing-java/pull/8


[FLINK-26163] Refactor FlinkUtils#getEffectiveConfig into smaller pieces

Refactor FlinkUtils#getEffectiveConfig into smaller pieces.
Fix the problem that the field of replicas in JobManagerSpec will not take effect.
Fix the problem that the basic podTemplate in FlinkDeploymentSpec will not take effect if JM or TM spec does not specify podTemplate on their own.
Refactor some codes in TestUtils and add unit test for FlinkUtils#getEffectiveConfig.

cc @wangyang0918 @gyfora @tweise

Refactor FlinkUtils#getEffectiveConfig into smaller pieces.
Fix the problem that the field of replicas in JobManagerSpec will not take effect.
Fix the problem that the basic podTemplate in FlinkDeploymentSpec will not take effect if JM or TM spec does not specify podTemplate on their own.
Refactor some codes in TestUtils and add unit test for FlinkUtils#getEffectiveConfig.

I am suggesting to factor out No.2 into a separate ticket.
Why we have the No.3 issue? IIUC, currently the pod template should work for both JobManager and TaskManager.
For No.1, what do you think about introducing a FlinkConfigBuilder just like following. It will make things easier to test.

/** Build effective flink config from {@link FlinkDeployment} */
public class FlinkConfigBuilder {
    private final FlinkDeployment deploy;
    private final Configuration effectiveConfig;

    public FlinkConfigBuilder(FlinkDeployment deploy) {
        this.deploy = deploy;
        this.effectiveConfig = FlinkUtils.loadConfiguration();
    }

    public FlinkConfigBuilder applyImageToConfig() {
        effectiveConfig.set(KubernetesConfigOptions.CONTAINER_IMAGE, deploy.getSpec().getImage());
        return this;
    }

    // Apply other fields to the config
    ... ...

    public Configuration build() {
        // Set some basic configuration
        final String namespace = deploy.getMetadata().getNamespace();
        final String clusterId = deploy.getMetadata().getName();
        effectiveConfig.setString(KubernetesConfigOptions.NAMESPACE, namespace);
        effectiveConfig.setString(KubernetesConfigOptions.CLUSTER_ID, clusterId);
        return effectiveConfig;
    }
}

final Configuration effectiveConfig = new FlinkConfigBuilder(flinkApp).applyImageToConfig().apply<...>.build();

Sure. It seems that the fix of JM replicas is just some lines of codes so I did it here. I will move it out and leave the work to the separate jira.
My bad. Check the KUBERNETES_POD_TEMPLATE field again and I understood it wrongly before.
Yes, I also think about using Builder pattern when refactoring. Considering not to change the code style too much, I did not use it initially. But I believe it could make codes more neat. Will update it later.

Also see #10 for related field changes


"Open in Terminal" menu option should open in PowerShell or Ubuntu depending on folder location

Description of the new feature/enhancement
Not sure if this is an enhancement versus an actual bug, but if have my default WSL distro be Ubuntu, and I click "Open in Terminal" in a Windows folder, I expect it to open up the PowerShell terminal, not the Ubuntu one. Vice versa if I have the default terminal as PowerShell and I click "Open in Terminal" in an Ubuntu folder, like in the below folders.
In other words, Terminal should know the context in which I'd want each terminal to open up.

Proposed technical implementation details (optional)

This is a neat idea! However, I think we'd probably end up getting stuck trying to pick the "right" profile for each scenarios. E.g. what about someone with both Windows PowerShell and PowerShell 7? Or multiple WSL distros?
I think it'll be easier for us to just let folks pick the profile they want to open instead, That's tracked in /dup #6111

I actually think this is really clever and worth discussing more :smile:
If the user has our stock profiles or any of the autodetected ones, we can absolutely know which distribution should be used to launch in which WSL directory.

I'm confident that us guessing means we'll guess wrong.

what about folks with the Canonical WSL profiles?
What about little old me with my Command Prompt default profile?
What about me with my non-built-in default profile?
What if I have a WSL set as the default, and I do want to open WSL navigated to %USERPROFILE%, so I can do ~sane~ bash scripting on my Windows files?

Bullet point 4 is a bit beside the point - the shell extension changes the startingDirectory somewhat by design. :smile:
For the rest: guessing wrong is low cost and I would posit rare. I guess the question is...
Is it more delightful for us to launch \\wsl\Debian\ paths into Debian under WSL automatically (before we have profile selection!) than it is annoying for us to not launch your default profile?

I also suspect most users have the default PowerShell and one WSL profile, so guessing correctly for most users would probably be accurate.

Even if the guess is the wrong version of powershell (assuming you have more than one version installed) it would still at least give you a terminal in the correct directory. Currently the "Open in Terminal" option is 100% useless to me because it opens in WSL so I still have to go through roughly the same steps to open another terminal with powershell and navigate to the correct directory.
Opening the wrong powershell can more easily fixed by just manually running the correct pwsh command.


Rework to use only listeners

While testing the beta1, I discovered that Sentry's error handler wasn't triggered, if not only on the most fatal errors. Any other intermediate approach lead to double-reporting of errors (like #156), so I have to fall back to using the framework events, and disable Sentry's error handler.

Note to self: is getsentry/sentry-php#788 is merged/tagged, it will break this one. We need to wait that before releasing a stable version.

@Jean85 if we want to strictly follow semver then that PR will be merged only in sentry-php 2.1 which will probably see the light not in the near future. I suggest to just merge this PR and rework it later when it will be time. Also I should have implemented everything in a BC-compatible manner, so you shouldn't have the need of adapting your changes to mine... Can you explain to me what is going to break?

It would break in the fact that you will add a new handler, that I would have to remove to avoid double-reporting of fatal errors.


slo on uptime metrics

Hi,
How can I use uptime metrics in sloth sli syntax?
because the common syntaxes that I see in examples include error_query and total_query, not just one query

You can use up sli plugin

Hey!
Indeed, as @christianlafleur sais, in this specific use case you can use sloth-common/prometheus/targets/availability plugin.
On the other hand, if you want raw queries that return the SLI error ratio directly you can use raw SLI.
Closing the issue..., if you need something else, please reopen :smile:


TLS handshake error using "-autocert"

Trying to use https proxy with autocert gives me error:
server.go:3228: http: TLS handshake error from <IP_ADDRESS>:54604: acme/autocert: missing server name
<IP_ADDRESS> - is my local IP, not the server

Hi!
Yeah, you need some domain name to issue certificate automatically and connect to server by it's domain name (otherwise handshake won't have domain in SNI)
Here is a complete guide in wiki for reference, should give you an idea by example: https://github.com/Snawoot/dumbproxy/wiki/Quick-deployment

just want to inform you that I had the domain name, I got it through freemyip.com.
The  issue was different here, the same name was used by "some" Telegram user and a few minutes after registration, a Telegram server was already "sitting" on my domain name.

Interesting, not sure how that's possible. Maybe some bug with service or someone else used your token to update address for domain.

I apologize for that. freemyip.com generates bind/update link and it was sent in the Telegram chat and the preview-bot followed this link.


Error handling for failed tasks

Development in Ray should be a good experience. That means that the user/developer has to be alerted about errors. Say the driver launches a task, and that task launches another task, which launches another task, and so on. And the last task throws an exception.
Then what is the appropriate way to alert the user about the exception? This is hard because the driver (say a Python shell) launches tasks asynchronously without waiting for them to execute.
We probably want to implement a method called something like get_task_statuses() in worker.cc, which gets a list of tasks that are running, tasks that have failed, and maybe tasks that have completed (or recently completed). This could be called and displayed whenever the user submits a new task or calls get (here we should probably distinguish between the user doing this and a worker doing this). It could also be run continuously on the driver.

This is partially addressed by #132.

Currently, when a user calls ray.get on an object that was created by a task that failed, the call to ray.get will hang. What should happen is that the call to ray.get should throw an exception similar to the one thrown by the task that failed.
One possible implementation: we simply store an "error" object in the object store. When ray.get retrieves an object, it checks to see if it is an "error" object, and if so it throws an exception.
Thoughts? @mehrdadn @pcmoritz @Wapaul1

#153 improves error printing

#158 causes ray.get(ref) to throw an exception if the task that created the object corresponding to ref threw an exception.

#339 improves the propagation of error messages.

Closing because this largely seems to work. Certainly the formatting of error messages could be improved.


problem displaying pointclouds that come by small packets at high rate

Hi
I am migrating from fuerte to hydro and encountered an issue with rviz in hydro. I am visualizing velodyne data, using @jack-oquin's driver. The default is to publish whole spins (large point cloud every 100ms), but you can choose to publish fractions of it at a time, so that you get more frequent and smaller pointclouds. I tried to publish one packet at a time, which corresponds to 384 points, or roughly 1 degree of data.
Then in rviz, I should be able to see the whole spin by setting the decay time to 0.1 (a revolution takes 100ms). And this works well in fuerte.
In hydro however, I see only 3 small fractions of the environment that are slowly rotating counterclockwise (the velodyne spins clockwise). See the attached screenshot
It's as if many packets are dropped. I tried setting the queue size to a large value (400 should be more than enough to hold 100ms of data) but it did not help.
how to reproduce:
download the pcap file from here: http://driving.stanford.edu/data/sample_velodyne_data.pcap if you don't have a velodyne.
Then replay it using velodyne_driver:
rosrun velodyne_driver velodyne_node _model:=64E_S2 _pcap:=vel.pcap
rosrun velodyne_pointcloud cloud_node

This should publish a pointcloud2 on /velodyne_points and should show up fine in rviz.
then kill the driver and restart it with the npackets parameter set to 1:
rosrun velodyne_driver velodyne_node _model:=64E_S2 _npackets:=1

you should see the publish rate around 4700, and rviz should show something weird.
Set npackets to 15 or more and it should be fine again.

Hi!
I'm experiencing the same problem with a Velodyne HDL-64E S3 in ros indigo (same packet rate that S2.1).
If try to visualize the pointcloud with the standard packet rate (providing a full scan per pointcloud) the image is flickering all time with a small black section spinning counterclockwise.
With a high packet rate (npackets = 1 in the driver, providing a ros message per packet) I obtain the same result that Brice in his screenshot.
Any help?
Thanks for all.

I'm still encountering this in jade, for now, I'm just publishing all the different pointclouds as one (just for visualization in rviz).

Having the same issue with VLP-16 and ros-kinetic, any new leads?

I looked at the issue in the latest melodic-branch of rviz. I can reproduce the issue using the velodyne pcap file, but I didn't see dropped messages in rviz: the message seq continuously grows when printed as suggested in https://github.com/ros-visualization/rviz/issues/689#issuecomment-30463690.
As it is hard to understand, which messages are displayed and which are dropped, I modified the send_point_cloud_2.cpp test, which publishes now a grid of points in an incremental fashion:
rosrun rviz send_point_cloud_2 10
There, increasing the decay timeout from 0.0 to 1.0 incrementally increases the number of shown points in a coherent fashion. Hence, I cannot see an issue in rviz. Did anybody ever consider that this might be a bug in the velodyne sources?


.raw.var returns .var when in backed = 'r' mode

Hi Everyone,
I have noticed an issue with returning the .var attribute.
When AnnData is read from .h5ad file with backed = 'r' option, adata.raw.var incorrectly returns the adata.var DataFrame.
This does not happen if AnnData is read entirely into memory.
Thanks a lot for developing such a useful package!

Thanks for reporting this! I went over the code and don't understand how this could happen. Would you mind sharing an example?

Thank you very much for compiling all of this! :smile: Will look into it as soon asap.

Figured this one out. The constructor for Raw copies var and varm from adata if X is None. I'm trying to figure out what the best way to fix this is. It get's kinda complicated if no var is passed, since you don't have names for genes.


Documentation around multiple custom MultiplayerApi usage is unclear

Tested versions
v4.2.1.stable.mono.official [b09f793f5]
System information
Godot v4.2.1.stable.mono - Pop!_OS 22.04 LTS - X11 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3080 (nvidia; 545.29.06) - AMD Ryzen 7 2700X Eight-Core Processor (16 Threads)
Issue description
Similar to https://github.com/godotengine/godot/issues/87023 I'm unsure if this is a documentation issue, a design issue, or a me issue but after scouring docs and google searches (and an ask on the Godot forums - https://forum.godotengine.org/t/how-are-custom-multiplayerapis-supposed-to-work-with-multiplayerspawner/42335), I can't figure out how to get a custom MultiplayerApi server and custom MultiplayerApi client working in a way that facilitates both Peer-to-Peer (Host Server and Client in a single process with Dedicated Clients connecting to the Host) and Dedicated Servers (Host Server with Dedicated Clients connecting to it).
Based on https://godotengine.org/article/multiplayer-in-godot-4-0-scene-replication/, https://docs.godotengine.org/en/stable/tutorials/networking/high_level_multiplayer.html, and https://forum.godotengine.org/t/how-to-set-a-custom-multiplayer-in-godot-4-0/6957/3 I've come up with https://github.com/Luminoth/Godot-Multiplayer-Demo (sorry about the GameLift code in there, that can be ignored) and it's failing when multiple clients are involved no matter how I run it and no matter how I try and set up the scene tree.
The basic setup is having a /root/ClientManager singleton with a custom MultiplayerApi and a /root/ServerManager singleton with a custom MultiplayerApi (I can't have just a single node for this because it seems you can't have a server peer and a client peer associated with a single MultiplayerApi). My Player has two MultiplayerSynchronizers per the official docs and my Level has a MultiplayerSpawner per the official docs. I've tried spawning the Level and Players below the ServerManager for servers and hosts, and below the ClientManager for clients, but that fails the combined use case because the ClientManager doesn't have a MultiplayerSpawner to synchronize against (and probably shouldn't because that would create duplicate Players for the local client) and spawning the Level below the root, which also fails because the MultiplayerApi's are a part of the manager nodes, causing all of the MultiplayerSpawners and MultiplayerSynchronizes to do nothing. This setup also seems to create a weird need to duplicate RPCs on both the ClientManager and ServerManager nodes for every RPC regardless of who should be handling it (because the RPCs have to exist in both node paths for each end to configure them correctly).
I don't know if it's just me, but I cannot seem to reason out a way to make this work and I haven't seen any examples, official or otherwise, that actually prove out it's even possible despite documentation suggesting that it should be - It is possible to create a new MultiplayerAPI object and assign it to a NodePath in the the scene tree, which will override multiplayer for the node at that path and all of its descendants. **This allows sibling nodes to be configured with different peers, which makes it possible to run a server and a client simultaneously in one instance of Godot.**
Steps to reproduce
This issue is pretty complex in terms of reproduction - essentially what I'm asking for is a working example of a Godot project that can act as a Peer-to-Peer host (client and server in one process) or a dedicated client / dedicated server. I can't say how to replicate doing that tho, if I could then I would just do that thing and the issue would not be here.
Minimal reproduction project (MRP)
Godot-Multiplayer-Demo-main.zip
Not exactly MRP, there's some GameLift stuff in there that isn't relevant to the issue. I can pretty easily, I think, make a new project that guts all of that if it's too much of a hassle.

I think that if all that comes out of this is an official example that works as Peer-to-Peer and Dedicated Servers, that would be incredibly beneficial to the community, just based on the range of related questions I've run into while trying to figure this out.


dateIsGregorian not working

Hi, thank you very much for your good library. DateIsGregorian does not work.

Hi
[dateIsGregorian] is a simple flag that indicate value of date provided by FormControl is gregorian or not.
With that, the lib can convert gregorian date to shamsi correctly.
If it's not working as i told, please provide a example with https://stackblitz.com/

Hi [dateIsGregorian] is a simple flag that indicate value of date provided by FormControl is gregorian or not. With that, the lib can convert gregorian date to shamsi correctly. If it's not working as i told, please provide a example with https://stackblitz.com/

Thank you, I thought this property would turn the calendar into a Gregorian calendar.There is a way to do this?

Thank you, I thought this property would turn the calendar into a Gregorian calendar.There is a way to do this?

The lib doesn't design to be a gregorian calendar, so the answer is NO.

hi first of all thanks for awesome component then i set [dateIsGregorian] to true but when submit the form the filed value is still hijrii
<ng-persian-datepicker (dateOnSelect)="onSelect($event,formItem.fieldName)"                              *ngSwitchCase="'datetime'"                              [timeShowSecond]="false"                             [dateIsGregorian]="true"                            [timeMeridian]="false">       <input type="text" [formControlName]="formItem.fieldName" [ngClass]="formItem.class||'form-control'"/> </ng-persian-datepicker>
what have I done wrong?

hi first of all thanks for awesome component then i set [dateIsGregorian] to true but when submit the form the filed value is still hijrii
<ng-persian-datepicker (dateOnSelect)="onSelect($event,formItem.fieldName)" *ngSwitchCase="'datetime'" [timeShowSecond]="false" [dateIsGregorian]="true" [timeMeridian]="false"> <input type="text" [formControlName]="formItem.fieldName" [ngClass]="formItem.class||'form-control'"/> </ng-persian-datepicker>
what have I done wrong?

@mehrdaddjb To getting gregorian value please checkout $event: IActiveDate provided by [ (dateOnInit), (dateOnSelect)] events,
As i said before:

[dateIsGregorian] is a simple flag that indicate value of date provided by FormControl is gregorian or not.
With that, the lib can convert gregorian date to shamsi correctly.

So you don't need [dateIsGregorian]="true" if your init date value is shamsi or you don't have init value at all.

Gregorian calendar added in v8.0.0 !!


DNM -Implements #35

Adds a layout CSS file containing a load of utility classes using Flex for layout
Uses some of the above utility classes to twiddle the layout of the "None of these" option in search results
Moves "None of these" option into search results list so it hides properly when search is inactive
Move most search result styling onto each search result rather than the dropdown container to match designs in Figma

Blocked. Needs rebasing to depend on #122 and for that request to be merged

I am absolutely revealing the extent of my unfamiliarity with Github's review features today, huh

looks like this one didn't get traction and would have merge conflicts with future branch, so let's close this one and future branch for now.
if we decide to use utility css styles, we can open a new PR from top of master later


Use a character map

The switch case in disp.c is hard to maintain; let's use a character map in some header file. Thes can serve as fonts in a way?
Two options; either a uint16_t *cmap[CHAR_MAX] or I can store bitfields which are then used in disp.c to toggle on/off bits. The former has the advantage of doing a single memcpy to write a character, the latter has control over brightness.

Done in #8, might be revisited later.


Use pubsub instead of map based routing

This simplifies the doppler/routing.
Benchmarks:
~/w/l/s/c/l/d/i/test (pubsub →↩☡) go test -bench=. -run=NoTest
testing: warning: no tests to run
BenchmarkPubSub-8          	  100000	     49353 ns/op	    4095 B/op	      99 allocs/op
BenchmarkDopplerRouter-8   	  200000	    119363 ns/op	     161 B/op	       1 allocs/op
PASS
ok  	code.cloudfoundry.org/loggregator/doppler/internal/test	30.061s
~/w/l/s/c/l/d/i/test (pubsub →↩☡) go test -bench=. -run=NoTest
testing: warning: no tests to run
BenchmarkPubSub-8          	  100000	     52136 ns/op	    4502 B/op	     105 allocs/op
BenchmarkDopplerRouter-8   	  200000	    117161 ns/op	     176 B/op	       1 allocs/op
PASS
ok  	code.cloudfoundry.org/loggregator/doppler/internal/test	29.691s
~/w/l/s/c/l/d/i/test (pubsub →↩☡) go test -bench=. -run=NoTest
testing: warning: no tests to run
BenchmarkPubSub-8          	  100000	     49762 ns/op	    4315 B/op	     102 allocs/op
BenchmarkDopplerRouter-8   	  200000	    116671 ns/op	     179 B/op	       1 allocs/op
PASS
ok  	code.cloudfoundry.org/loggregator/doppler/internal/test	29.540s

@apoydence can you share your benchmark test?

@bradylove I've place the required files in the following gist: https://gist.github.com/apoydence/0ef3bc8277f69dbb28561bb0c864eee2
I created a test package in dopplers internal package to gain access to the router.

I'm looking into improving the performance of this.

Three things:

If this is a big performance improvement in the router, then great! Do you have before and after benchmarks to prove the improvement? I don't know what the benchmarks above represent.
Let's remove the WIP commit from the PR. Maybe that's your plan anyway, but if the PR isn't done yet, then let's close it until it's ready.
I would prefer to see Loggregator pulling in a code.cloudfoundry.org/pubsub if it's not going to be in the source tree itself. Pulling in personal libraries establishes a bad precedent in my opinion.

Before and after pubsub library:
git co 6e8df69428d9761d7513080424243b469c891373 #Commit before pubsub
~/w/l/s/c/l/d/i/g/v1 ((6e8df69...) ) go test -bench=BenchmarkDopp -run=NoTest
BenchmarkDopplerRouter-8   	 2000000	       637 ns/op	     128 B/op	       1 allocs/op
PASS
ok  	code.cloudfoundry.org/loggregator/doppler/internal/grpcmanager/v1	2.042s

~/w/l/s/c/l/d/i/g/v1 ((6e8df69...) ) git co pubsub
~/w/l/s/c/l/d/i/g/v1 (pubsub) go test -bench=BenchmarkDopp -run=NoTest
BenchmarkDopplerRouter-8   	 1000000	      1058 ns/op	     192 B/op	       2 allocs/op
PASS
ok  	code.cloudfoundry.org/loggregator/doppler/internal/grpcmanager/v1	1.436s

My previous benchmarks include go-routines, which I think confuse the results. These benchmarks assume that only a single writer is writing to the router (current state of the world in doppler).
The things to notice:
Current implementation is able to get 637 ns/op which implies that each envelope being written to the router takes 637 ns. It only allocates a single time to the heap, which equates to 128 bytes.
The pubsub implementation takes 1058 ns/op. Therefore it is a little slower. It takes 2 allocations and 192 bytes.
The advantage is to abstract away complexity. But abstractions aren't free in go.

I would like to see a benchmark for how both perform under heavy Register load while doing writes.
That said, if this solution is less performant with both memory and CPU, and conceptually more complex (everyone understands maps), I don't see how we can merge it.
In one of your commit messages you said:

When adding a new filter parameter, more maps would have to be created and carefully added to.

Couldn't additional fields just be added to filter vs adding new maps?

@jasonkeene I can add a benchmark for both under Register load.
The catch with the current implementation is that the struct is used as the key. Therefore if someone tries to add a sub-struct and does so with a pointer, then it will compile but not work as expected.

To better summarize the user value I created the following Feature Proposal document.

We've decided to pull in code.cloudfoundry.org/go-pubsub and are presently doing the work on this branch.
Closing.


Badge Request

Username and Discrim: jakefaith#6001
User ID:<PHONE_NUMBER>84552961
Image Link: https://cdn.discordapp.com/attachments/458755142532071426/792176982473310208/emote.png

Added, make sure you completely reinstall the theme as I recently redid some things.

Added, make sure you completely reinstall the theme as I recently redid some things.


[Feature Request] Add view/edit button for PUP pack option scripts

Sometimes it is useful to take a look at these scripts.

nice!

Fixed with 3.9.1


Telemax Robot

This PR adds a model of the Telemax robot from Telerob.
Remaining tasks:

[x] Camera model.
[x] Camera slots.
[x] Track geometry model.
[x] Splash screen.
[x] Wheels
[x] World
[x] Demo controller

[x] Add camera zoom.

[x] Calibration:

[x] Masses
[x] Joint limits
[x] Motor torque/speed/acceleration
[x] Camera resolution/fov.
[x] Camera lights

[x] Docs: https://www.cyberbotics.com/doc/guide/telemax-pro?version=feature-telemax-robot

[x] Update final video link.

Progress with the track:

With real track geometries instead of boxes:

I will try to find a tradeoff between the two.

With the optionnal cameras (I managed to reduce the number of triangles of the articulated camera from 200'000 to ~3'000):

This is for sure the most good-looking model ever done in Webots :heart:

test me

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Failed :confused:
https://cyberbotics2.cyberbotics.com:8443/job/Webots/440/consoleText

test me

test me

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

https://youtu.be/vU086Fd22-0

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

test me

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Failed :confused:
https://cyberbotics2.cyberbotics.com:8443/job/Webots/453/consoleText

test me

test me

Build Failed :confused:
https://cyberbotics2.cyberbotics.com:8443/job/Webots/454/consoleText

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Remains only to calibrate the camera :smiley:

With controlled wheels:

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

test me

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

test me

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

test me

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

:+1:

:-1:  (I did forget the thumbnails)

test me

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

:+1:

test me

test me

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

Build Passed :ok_hand:
You can safely merge 'feature-telemax-robot' into 'develop'.

:+1:


Extract Config functionality

As we use the config functionality in many places, we maybe can use it extending a base Config Class

@twbs/js-review
I need some help here.
After some discussion I have concluded to the following.
Config can be three different things:

An abstract with mutable getters (as it is now on Tooltip|Popover, and can be changed by developers)
An abstract with immutable getters (private methods)
A separate Class|object that any component can initialize

The third option seems to be more strict (and with some difficulties on its implementation)
Both first and second are very close too our existing codebase.
IMO the first is ok as we give the opportunity to devs that use Bootstrap to extend/change some Defaults on the fly, with the second to be a more professional choice than first, as it can give the same freedom, only after extending a class that already extends the Config abstract
Any opinions are wellcome

So choosing the first option seems good, but the APIs should be kept private initially IMO. Since that's the fully internal thing.


How to get the val by click 'SelectAll'

I used the code below to get the selected val.
var sl = $("#id")
sl.on("changed.bs.select", function(e) {
		console.log(sl.val())
	})

But when I click the 'SelectAll', the console didn't log so how can I get the all values by the 'SelectAll'
Thank you guys!

Currently changed.bs.select isn't fired when "Select All" or "Deselect All" are clicked. It should be, but that event is mainly used so you can know which option was actually changed when the select value is changed (not possible with jQuery's change event). I'll fix this in an upcoming update.
You can fix it in your own code by adding that.$element.trigger('changed.bs.select'); after line 1248

It works! :+1:
Thank you casey. Hope the Bootstrap-Selec' Long Live :)

@caseyjhol Your fix is not exactly correct. If I select all options, then I call selectAll, the changed.bs.select event should not be fired. It should ONLY be fired when the value are really changed. Same issue with deselectAll.

How do I get if selectAll or DeselectAll is clicked, in changed.bs.select event? I see undefined

We have separate issue for this and it is here . Is there anything at this moment for catching Select All or Deselect All?


Ingress controller: testing

Test the ingress controller function, using both unit tests (where applicable) and e2e test.

Integration tests were added as part of https://github.com/istio/manager/pull/352

Unit tests and e2e tests are in place. We just need to maintain them as we add functionality now.


How to make vim mode work with pentadactyl?

Firefox vim-link plugin pentadactyl capture esc , which is conflict to vim mode. Is there any way to get around this?

You can also escape with ctrl-[. Alternatively, in Vimperator, you can press shift+esc to disable all Vimperator keys, then esc to escape the codemirror-vim input mode, then (optional) shift+esc again do activate vimperator. Not optimal and not sure if it also works in Pentadactyl.

Thanks for the suggestions, @leftaroundabout. I have no idea what we could do in CodeMirror to further mitigate this problem, so I am closing this issue for now. Feel free to comment or reopen if you have a suggestion what we could do :)


Capitalized error messages

This PR changes error messages according to #3944.

Hmm, CI fails at IO#peek related tests, dunno why...

Note that capitalizing error message given by the compiler is not correct. Right now with this code:
def foo
  A = 1
end

we get this error:
Syntax error in qux.cr:2: dynamic constant assignment

  A = 1
     ^

With your PR we get:
Syntax error in qux.cr:2: Dynamic constant assignment

  A = 1
     ^

which doesn't read that well (capitalizing after ":" doesn't look good). Compiler message are always non-capitalized because of this reason (check for example errors produced by clang, go or rustc)
I do agree about capitalizing messages of exceptions thrown in the standard library.

@asterite Reverted changes made to compiler as requested. CI is hanging due to macOS problems on Travis, while Linux is all green-good.

@asterite ping? it's ready to 🚢 !

@asterite anything more to do here?


Feature: Percentage of total budget an item is contributing with.

Story
As a user, I want to see percentage of total budget an item is contributing with, so I can better understand statistics of my inflow or outflow items
Proposed Changes

Create detail page for transactions.
Allow user to navigate to details page through Budgeting Grid.
Page should have transaction description as the title.
URL should reflect current transaction.
Show budget percentage affected by transaction as a subtitle, with a green plus sign for inflows, red minus sign for outflows.
Add a pie chart showing how much of the budget the item contributes to.
Add back button to return to Budget page.
Must be responsive.

Screenshot

Checklist

[x] Feature developed
[x] Created/updated unit tests
[x] Comments in code
[ ] Documentation written

Coverage increased (+0.6%) to 78.506% when pulling 39e6448891229d5fa005d9f46a55e5f11c70ff1a on HiroAgustin:transaction-percentage into ddf7c8e1ee591036dbf2f6285e5ae412423f4f6e on ModusCreateOrg:master.


DLAU Defect: "Calculating" remains in Deny Access Groups in Summary Page.

Reproducing Procedure
If Deny Access Group name is not listed in "Not Server Access" in "Security" tab in Server document, this happens.  This message remains appeared.
Issue
Users will be puzzled.
"Calculating" is misleading.  "Unable to Calculate.  Check Observatin page" will be batter for users, otherwise users will wait for long long time as instruction says it takes several hours.
This should be fixed or add FAQ and/or documentation, or replace the message other than "Calculating".
Screenshots

Log
4/14/2023 11:05:52 AM	In "(PullInfoConfig)" agent
4/14/2023 11:05:52 AM	Starting "GetAdminServerInfo" function"
4/14/2023 11:05:52 AM	"GetAdminServerInfo" - begin
4/14/2023 11:05:52 AM	In "GetAdminServerInfo" - svrName = CN=domino/O=HCL
4/14/2023 11:05:52 AM	"GetAdminServerInfo" - GetServerList - begin
4/14/2023 11:05:52 AM	The HCL Domino Server "domino/HCL" is not properly secured for HTTP traffic
4/14/2023 11:05:52 AM	The HCL Domino Server "domino/HCL" is not properly secured for LDAP traffic
4/14/2023 11:05:52 AM	"GetAdminServerInfo" - GetServerList - finished
4/14/2023 11:05:52 AM	"GetAdminServerInfo" - CheckUserAccess - begin
4/14/2023 11:05:52 AM	"CheckUserAccess" - begin
4/14/2023 11:05:52 AM	"CheckUserAccess" - finished
4/14/2023 11:05:52 AM	"GetAdminServerInfo" - CheckUserAccess - finished
4/14/2023 11:05:52 AM	"GetAdminServerInfo" - finished
4/14/2023 11:05:52 AM	Finished "GetAdminServerInfo" function"
4/14/2023 11:05:52 AM	Starting "CheckServerSettings" function"
4/14/2023 11:05:52 AM	"CheckServerSettings" - begin
4/14/2023 11:05:52 AM	In "CheckServerSettings" - locating Admin server doc
4/14/2023 11:05:52 AM	In "CheckServerSettings" - Admin server doc located
4/14/2023 11:05:52 AM	In "CheckServerSettings" - checking for Directory Assistance info
4/14/2023 11:05:52 AM	In "CheckServerSettings" - checking for Entitlement Tracking apps
4/14/2023 11:05:52 AM	In "CheckServerSettings" - checking for License Tracking apps
4/14/2023 11:05:52 AM	The License Tracking task is not running on the HCL Domino server: "domino/HCL|domino/HCL"
4/14/2023 11:05:52 AM	"CheckServerSettings" - finished
4/14/2023 11:05:52 AM	Finished "CheckServerSettings" function"
4/14/2023 11:05:52 AM	"(PullInfoConfig)" agent finished
4/14/2023 11:06:00 AM	In "(PullInfoUser)" agent
4/14/2023 11:06:00 AM	Obtaining Domino Directory
4/14/2023 11:06:00 AM	Obtaining Person document information
4/14/2023 11:06:00 AM	"GetPersonDocuments" - begin
4/14/2023 11:06:00 AM	Scanning Person documents in the Domino directory -"HCLMail's Directory" (domino/HCL!!names.nsf)
4/14/2023 11:06:00 AM	# of Person documents in Domino Directory = 2
4/14/2023 11:06:00 AM	"GetPersonDocuments" - finished
4/14/2023 11:06:00 AM	"(PullInfoUser)" agent finished
4/14/2023 11:06:09 AM	In "(PullInfoDAGroups)" agent
4/14/2023 11:06:09 AM	Obtaining Domino Directory
4/14/2023 11:06:09 AM	Obtaining Deny Access Groups"
4/14/2023 11:06:09 AM	"GetDenyAccessGroups" - begin
4/14/2023 11:06:09 AM	The HCL Domino server "domino/HCL" is not using any Deny Access Groups to secure server access
4/14/2023 11:06:09 AM	"ProcessDenyAccessNames" - begin
4/14/2023 11:06:09 AM	"ProcessDenyAccessNames" - finished
4/14/2023 11:06:09 AM	"GetDenyAccessGroups" - finished
4/14/2023 11:06:09 AM	"(PullInfoDAGroups)" agent finished
4/14/2023 11:06:24 AM	In "(PullInfoEntitlement)" agent
4/14/2023 11:06:24 AM	Retrieving Entitlement Information
4/14/2023 11:06:24 AM	Scanning Entitlement system
4/14/2023 11:06:24 AM	"(PullInfoEntitlement)" agent finished

This has been corrected for the next release of the DLAU (V1.0.11)


Add Tailwind config settings for site

Given your requirement for minimal and impactful changes to create unique themes, here are some recommended parts of the Tailwind CSS configuration you can consider changing:
backgroundColor: This is influential in setting the overall color scheme of a website. Changing this will notably affect the appearance of your website.
textColor: It can customize text color across the site, greatly affecting readability and visual aesthetics.
borderColor: You can create unique appearances by changing the border colors of different elements.
colors: This section can be customized to create a unique color palette for the entire website. This is highly impactful in creating distinguishable themes.
fontSize: Different font sizes can create different feelings. Larger fonts are more striking, while smaller ones are more subtle.
fontFamily: Changing the font family can drastically change the look and feel of the site.
spacing: Adjustments in spacing, padding and margins can make significant changes in layout and visual hierarchy.
borderRadius: Adjusting this property can switch between a modern, flat look (with small border radii) and a more button-like, rounded feel (with large border radii).
boxShadow: Different box shadows can also contribute to the overall visual style of the theme.
screens: Modifying your breakpoints can result in drastically different layouts on various screen sizes.
Remember, how you change these elements will depend on the inputs you get from the users. Try not to change everything at once but focus more on the most impactful properties.


fix: Add Korean AutoRAGRetrieval

Adding datasets checklist

Reason for dataset addition:
This is a Korean Retrieval benchmark dataset covering 5 domains: Finance, Public, Medicine, Law, Commerce

[x] I have run the following models on the task (adding the results to the pr). These can be run using the mteb -m {model_name} -t {task_name} command.

[x] sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2

{"ndcg_at_1": 0.29825, "ndcg_at_5": 0.3973, "ndcg_at_10": 0.42296}

[x] intfloat/multilingual-e5-small

{"ndcg_at_1": 0.59649, "ndcg_at_5": 0.73205, "ndcg_at_10": 0.75466}

[x] I have checked that the performance is neither trivial (both models gain close to perfect scores) nor random (both models gain close to random scores).
[x] If the dataset is too big (e.g. >2048 examples), considering using self.stratified_subsampling() under dataset_transform()
[x] I have filled out the metadata object in the dataset file (find documentation on it here).
[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.

Hello, I tried to contribute this AutoRAGRetrieval task, but I got some errors while testing. Can I please get some help?
My codes are in mteb/tasks/Retrieval/kor/AutoRAGRetrieval.py
Thank you.

@yjoonjang I think we are almost there. Will you complete the checklist for adding a new dataset?
I also want to double check that annotations are human and not LLM generated?

I'm sorry, but I when I try to test with the dataset AutoRAGRetrieval, I still get this error: "KeyError: 'AutoRAGRetrieval' not found. Did you mean: DuRetrieval?"

My command was this: mteb run -m sentence-transformers/paraphrase-multilingual-MiniLM-L12-v2 -t AutoRAGRetrieval
I added my dataset name to Retrieval/__init__.py, but I don't know why I get this issue. Cand I get some help please?

And yes, this dataset is not LLM-generated.

I tried to run your code and maybe you need to reinstall your package to fix your problems, because I can run task like this mteb run -m intfloat/multilingual-e5-small -t AutoRAGRetrieval

I have deleted the descriptive_stats in TaskMetadata field and made it to a json file with running calculated_metadata_metrics.

I got these results
sentence-transformers__paraphrase-multilingual-MiniLM-L12-v2 AutoRAGRetrieval.json
intfloat__multilingual-e5-small AutoRAGRetrieval.json

I got these results sentence-transformers__paraphrase-multilingual-MiniLM-L12-v2 AutoRAGRetrieval.json intfloat__multilingual-e5-small AutoRAGRetrieval.json

This is corresponds with the results I attatched on the checklist above!

Results for the e5-small model are slightly different. I suspect this is because I overlooked that the model should be initialized with model = mteb.get_model(model_name) rather than directly with SentenceTransformer. Using SentenceTransformer directly would skip the prompts.

Results for the e5-small model are slightly different. I suspect this is because I overlooked that the model should be initialized with model = mteb.get_model(model_name) rather than directly with SentenceTransformer. Using SentenceTransformer directly would skip the prompts.

Oh yes. I tested with model = mteb.get_model(model_name) and got the same reslult as yours.
I don't really know why. Because e5-small doesn't need prompts.
Do you have some opinions?
And also, is this the end of contribution, or do I have to do anything else ?

I don't really know why. Because e5-small doesn't need prompts.

e5 does use prompts though they are minimal (e.g. "query: " ).

Thank you so much for your help.
Is my point automatically updated, or do I have to add my contribution to points folder ?

@yjoonjang we no longer take point for the MMTEB contribution (it has already been submitted). However you will appear as a contributor on MTEB.


go/cmd/dolt/commands: merge.go: Make merge operate on commit specs, not branch refs directly.

My changes all happen after we resolve refs to RootValues. No conflict here.


chore: enable biome imports sorting

Summary
Enable biome's import sort to keep consistent importing sort (see https://biomejs.dev/analyzer/import-sorting/). Most of changed files are auto fixed, package.json & biome.json are the files that needed to be reviewed indeed.
This PR changes lots of code and will pollute the blame more or less.
Related Links

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

When I only update some biome ignored files, the biome check will fail with this error:

You can reproduce this issue by running:
npx biome check --apply --formatter-enabled=false --linter-enabled=false ./packages/core/compiled/sirv/index.js


:seedling: Change broken links

What this PR does / why we need it: Links have changed. Change them to ones that pass the link check.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/lgtm


Add ability to use package json version.

This will only work with top level package json file and not nested files.
Description:
Adds the ability to specify "package" as node version instead of a number
Related issue:
#467
Check list:

[x] Mark if documentation changes are required.
[ ] Mark if tests were added or updated to cover the changes.

Ok no worries I've not had much time to get back to the pr and fix it been busy with work

This is addressing the same issue as https://github.com/actions/setup-node/pull/485, correct?  Seems like that one is farther along, so let's go with that one.


Make direct download link

Would it be possible to make a direct download link to a zip file? Instead of having a user select which files he wants, just choose the files yourself and make a link.

Hey,
I'll do that soon, sorry, completely missed your message!

Cool! Looking forward to it. And just a question: would it be possible to rename files before zipping them?

Hey, just released an update so link download now works.


Angular2-highcharts in a submodule

I'm having problems making angular2-highcharts work in a submodule.
If I follow the instructions provided in the readme and add the import in app.module.ts, create a simple chart in app.component.ts and have <chart [options]="options"> in app.component.html, etc... it works fine... but if I move those bits in a submodule (stats.module.ts, stats.component.ts and stats.component.html respectively), I get this error:
Unhandled Promise rejection: Template parse errors:
Can't bind to 'options' since it isn't a known property of 'chart'.
What am I doing wrong?

Never mind, managed to make it work :)

would be great if you share your solution :)

You can only have .forRoot calls in the root of your app, so in app.module.ts you'll have:
import { ChartModule } from 'angular2-highcharts';

import * as highcharts from 'highcharts';
import { HighchartsStatic } from 'angular2-highcharts/dist/HighchartsService';

export function highchartsFactory() {
	const hc = require('highcharts');
	const dd = require('highcharts/modules/drilldown');
	dd(hc);

	return hc;
}

@NgModule({
	.....
	imports: [
		......
		ChartModule.forRoot(require('highcharts')),
		......
	],
	exports: [
		.....
		ChartModule,
		.....
	],
	providers: [
		.....
		{
			provide: HighchartsStatic,
			useFactory: highchartsFactory
		},
		.....
	],
	.....
})

Then, in your submodule.module.ts:
import { ChartModule } from 'angular2-highcharts';
.....
@NgModule({
	imports: [
		.....
		ChartModule,
		.....
	],
})
.....

Hope that helps...

Helped me a lot! Thanks!

I still get /src/app/app.module.ts (48,17): Property 'forRoot' does not exist on type 'typeof ChartModule'.
import {ChartModule} from 'angular2-highcharts';
const highstock = require('highcharts/highstock');

@NgModule({
  declarations : [
    AppComponent
  ],
  imports : [
   .....
    ChartModule.forRoot(highstock)
.....
  ],
  exports: [ChartModule],
  providers : [Feathers,AuthService,AuthGuard,DataService,MdSnackBar,
    {provide : 'AppConfigOptions', useValue : defaultOptions}
  ],
  entryComponents : [AppComponent],
  bootstrap : [AppComponent]
})
export class AppModule {
}

Sorry my mistake. I had the wrong version installed.


Properly detect debug build in slots

debug-assertions can also be enabled in for release builds. This
introduces a new build-script that extracts the build type from the
PROFILE env variable and sets the build_type cfg.

@pepyakin That said, I guess it is the best thing we have.

Half an hour later, I guess not!

Glad to be proven wrong!


Prisma is returning the DateTime in ISOstring()

Bug description
I have the createdAt and updatedAt properties in my entities inside my PostgreSQL database.
Every time Prisma returns these properties, the values are being formatted to ISOString and it removes the timezone.
I haven't found a way to return the date in the proper timezone and don't want to create a mapper for each entity, because it will cost a lot of changes. Can Prisma the DateTime return in the Brazil(UTC -3) timezone?

How to reproduce

Expected behavior
Prisma information

model User {
  id        String   @id @default(uuid())
  createdAt DateTime @default(now()) @map("created_at") @db.Timestamptz()
  updatedAt DateTime @default(now()) @updatedAt @map("updated_at") @db.Timestamptz()
  roleValue String   @map("role_value")
  name      String
  access    Access?
  role      Role     @relation(fields: [roleValue], references: [value])

  @@map("users")
}

async findAll({
    schoolId,
    role,
    name
  }: FindAllUsersParams): Promise<FindAllUsersReturn> {
    const args: PrismaTypes.UserFindManyArgs = {
      where: {
        roleValue: role,
        name: {
          contains: name,
          mode: "insensitive"
        },
        access: {
          schoolId
        }
      }
    };

    const [users, total] = await this.prisma.$transaction([
      this.prisma.user.findMany(args),
      this.prisma.user.count({ where: args.where })
    ]);

    return {
      users: users as User[],
      total
    };
  }

Environment & setup

OS: MacOS
Database: PostgreSQL
Node.js version: 20

Prisma Version
    "prisma": "^5.12.1",
    "@prisma/client": "^5.12.1",

Same Issue !!!
Model definition
model Entity {
  ...
  createdAt            DateTime              @default(now()) @map("created_at")
  updatedAt            DateTime              @default(now()) @map("updated_at")
  ...
}

MySQL DDL
CREATE TABLE `entities` (
  ...
  `created_at` datetime(3) NOT NULL DEFAULT CURRENT_TIMESTAMP(3),
  `updated_at` datetime(3) NOT NULL DEFAULT CURRENT_TIMESTAMP(3),
  ...
);

DB rows

Returned by Prisma client

Prisma Version
...
"@prisma/client": "^5.13.0",
"prisma": "^5.13.0",
...

Hi @drichardcarl.
Technicality, but Prisma does not return DateTime fields as strings, but rather, as JS Date objects which don't store the timezone. Non-UTC dates is one of the Prisma's weak spot which we are very well aware of and hope to fix one day.
If I understood correctly, in your case you always want to format the dates in GMT-3:00. If that's the case, result extension might provide some releif:
const prisma = new PrismaClient().$extends({
  result: {
    User: {
      createdAt: {
        needs: ['createdAt'],
        compute: (user) => formatInTheRightTimzone(user.createdAt)
      }
    }
  }
})


Recompute NDVI

Recomputes NDVI when data is loaded.
Demonstration of fix

Since all old models were trained on incorrect NDVI, the new NDVI values affect the model tests

Will retrain all models to ensure model tests pass

👍
Maybe we do #307 here to avoid potential merge conflict and otherwise just reduce that work to this PR.
Also retraining on this branch would be dependent on merging #308 first? Edit: neverminded, only if plan to retrain all models with GitHub actions.

Sure I can retrain the corrective labels model here. It'll take some time as it has to be done sequentially

@bhyeh based on discussion this is ready for review, let me know if it looks good!


Support for activate and deactivate methods in RabbitMQSpout

The io.latent.storm.rabbitmq.RabbitMQSpout class doesn't override BaseRichSpout activate and deactivate methods.
Here's my proposal

activate method is following:

  @Override
  public void activate() {
    logger.info("activating spout!");
    consumer = loadConsumer(declarator, reporter, consConfig);
    scheme.open(topoConfig, topoContext);
    consumer.open();
    super.activate();
  }

We will cache topoConfig and topoContext from the open method.

deactivate method is following:

 @Override
  public void deactivate() {
    logger.info("deactivating spout!");
    consumer.close();
    scheme.close();
    consumer = null;
    super.deactivate();
  }

I'll update this issue with my code in my development branch once it finishes

Closed by 0e438a383cd2187c66a94f933861a85663fd5eed


unify notifications list, add email and teams

Is your feature request related to a problem? Please describe.
Currently I need to run two commands to see all the rocketchat and/or slack notifications associated with a project. With the addition of Microsoft Teams and email notifications, this would then require me running 4 commands to see all the notifications.
Describe the solution you'd like
I should be able to run a simple command like lagoon list notifications -p project-name and get a list of all the notifications of a project, regardless of type.

This has now been implemented!


Fixed the links in the 'see also' section

Fixed these links:

Microsoft.Build.Conversion
Microsoft.Build.Evaluation
Microsoft.Build.Execution
Microsoft.Build.Framework
Microsoft.Build.Logging
Microsoft.Build.Tasks
Microsoft.Build.Utilities

Fixed formatting for MSBuild overview so that the description displays on the next line just like it does for all other reference links on the page.
Fixes #1409

@ClydeDz : Thanks for your contribution! The author, @mikejo5000, has been notified to review your proposed change.

@ClydeDz : Thanks for your contribution! The author, @mikejo5000, has been notified to review your proposed change.

Thanks for that, @Mikejo5000. I've updated the links in my recent commit.

#sign-off Thanks!


Missing indeterminate state for Progress or a Spinner component

This function solves the problem (这个功能解决的问题)
It will be really useful to have an "indeterminate" state for the Progress component or a Spinner component, because it's not always possible to have a progress value during some long processing.
Expected API (期望的 API)
<n-progress type="circle" :indeterminate="true" />

Duplicate of https://github.com/tusen-ai/naive-ui/issues/2103


Moved troubleshooting section to troubleshooting article

Docs Build status updates of commit da0a88e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-conceptual/azps-8.1.0/install-az-ps.md
:warning:Warning
View (azps-8.1.0)
Details

docs-conceptual/azps-8.1.0/troubleshooting.md
:white_check_mark:Succeeded
View (azps-8.1.0)

docs-conceptual/azps-8.1.0/install-az-ps.md

Line 72, Column 3: [Warning: bookmark-not-found] Cannot find bookmark '#az-and-azurerm-coexistence' in 'docs-conceptual/azps-8.1.0/install-az-ps.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d26fda0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azps-8.1.0/install-az-ps.md
:white_check_mark:Succeeded
View (azps-8.1.0)

docs-conceptual/azps-8.1.0/troubleshooting.md
:white_check_mark:Succeeded
View (azps-8.1.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Request: add support for docker_layer_caching in machine executor

Is there an existing issue that is already proposing this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe it
It looks like generating a machine executor from the SDK does not allow to define the docker_layer_caching property.
The MachineExecutorShape object defines this property, but it is not handled by the generateContent method in the executor itself.
Describe the solution you'd like
Maybe adding a useDockerImageLayerCaching method to the MachineExecutor class
export class MachineExecutor extends Executor<MachineResourceClass> {
  image = 'ubuntu-2004:202010-01';
  docker_layer_caching?: boolean;

  generateContents(): MachineExecutorShape {
    return {
      image: this.image,
      docker_layer_caching: this.docker_layer_caching,
    };
  }

  // [..]

  withDockerLayerCaching(activate: boolean): MachineExecutor {
    this.docker_layer_caching = activate;
    return this;
  }
}

Teachability, documentation, adoption, migration strategy
Enabling docker image layer caching on machine executors
const myConfig = new CircleCI.Config();
const machine = new CircleCI.executors.MachineExecutor('large').withDockerLayerCaching(true);
const const reusableMachine = new CircleCI.reusable.ReusableExecutor('default', machine);

myConfig.addReusableExecutor(reusableMachine);

What is the motivation / use case for changing the behavior?
We are considering using the SDK to generate our continuation step and need this feature to match our existing config file

Closed by #147, thanks again @a-cordier! Looking forward to seeing your avatar on the contributor's list.


Fixed WebHookReceiverSecret XML documentation to reflect the expected…

Updated the XML documentation on VstsWebHookReceiver and HttpConfigurationExtensions to reflect what is expected to be provided for the ReceiverSecret in a real life example.

Hi @michael-baker, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Much appreciated! Committed as ac7d8168dbff31ef8de61da4c3edbef95ed227be
Henrik