Fix reading uninitialized data in ms_queue

If you create an MsQueue with MsQueue::new(), then call push(), the first thing that is called is tail.is_data().
This function reads from the value of tail.payload whose content is set mem::uninitialized() by the new() function.
In the tests the content of tail.payload ends up being filled with 0s, so there's no problem. In my real-world application though, the enum discriminant that chooses between the enum variants Payload::Data and Payload::Blocked is 1184 , which leads to a crash.
This PR fixes that so that it no longer crashes. In reality though, the code after the fix is still technically undefined behavior since you're still reading partially uninitialized memory.

Thanks! @aturon indicates that this happened when we added blocking support to this queue, but otherwise it's intended for the sentinel to have uninitialized data. Merging for now in any case.

The people on IRC that helped me debug this problem agree that this is likely going to crash again when Rust starts to optimize enum layouts.


Fix page reloads on missing hrefs

Added a check for the href attribute to the anchor link click event listener.
Description
Since the package updates the event listener of all anchor links on the website, sometimes we might not want the behavior of the new event listener to run. In this specific example, if an anchor tag doesn't have a href attribute, the page would just reload. Sometimes the lack of href tags is intentional. For example, the hamburger menu in Buefy's navigation component looks like this:
<a role="button" aria-label="menu" class="navbar-burger burger"> ... </a>

In this scenario, the hamburger anchor opens the menu but then the page reloads. My change makes sure the href attribute actually exists before doing anything.
Related Issue
N/A
Screenshots or GIFs (if appropriate):
N/A
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@ukutaht if you have a moment, it would be great to have this fix merged.

I ran into the exact same issue and would love for this to be merged so that we can enable outbound link tracking for our sites without breaking the mobile menu.

I ran into the exact same issue and would love for this to be merged so that we can enable outbound link tracking for our sites without breaking the mobile menu.
<a> tags without href are valid HTML but there is nothing to track there.

@ionicsolutions As a temporary workaround if you use Node.js tooling, you can use patch-package to manually fix the issue. The files you will likely need to patch are:

node_modules/plausible-tracker/build/main/lib/tracker.js
node_modules/plausible-tracker/build/module/lib/tracker.js

Adding the following line to the beginning of the trackClick function should fix the issue:
if (!this.href) return;

Thanks,  @jozsefsallai, I implemented the workaround you suggested and it works like a charm.


Can't install/remove extensions / Mac OS 10.10

Hey,
I wanted to replace Sublime Text with Brackets, but it seems to be really tricky to install on Mac OS :/
I can only install extensions manually by dragging them to ~/Library/.../Brackets/extensions/user/.
Trying to add or remove any extensions from inside the Brackets results in an unknown internal error.
Looks like a permission's error? Does any Bracket folder require some special permissions to be manually set?

@ingorichter installed the latest version on Brackets 1.3 and the problem seems to be no more - should I close the issue?

As Unknown internal error issue is already tracked by #9895. closing this .

@mjurczyk yes and thanks!


Connectivity issues after the server reboots, goes on sleep, etc.

Hi,
I noticed quite a few times that the client often fails to reconnect when a server comes back up after a reboot or being suspended. I often have to restart either or both the client and server for the system to work again. Could be a dangling socket or something like that, I'm not sure yet.
I don't have logs extracts yet but I'll produce them soon.
Regards,
Jules

Hi, I'm having the same issue too.
@ckiee - this started happenning after I got your MR for TCP timeouts in. Given your code I don't see any reason why would that happen. Do you have any idea why could that be?

No idea, but I also get this, I haven't made the link yet either.
Perhaps it's better to replace it with application-level heartbeats, but I've since fixed the underlying hardware problem I was having so I'm okay with a revert if you aren't looking forward to more work.

I'm trying to reproduce this but it's not happening with some naive attempts. It takes a bit but on my system eventually everything restarts and it reconnects, which means there's something unaccounted for or it just takes a few hours to show up.
After suspending the server everything comes back relatively gracefully:

Maybe the issue emerges when the reboots are too short for the TCP timeout? I'll try to experiment today.

So I was able to replicate the issue. Here's what happened
Sep 29 17:27:08 jpenuchot-thinkpad rkvm-server[634]: [INFO  rkvm_server::server] <IP_ADDRESS>:33972: Connected
Sep 29 17:27:08 jpenuchot-thinkpad rkvm-server[634]: [INFO  rkvm_server::server] <IP_ADDRESS>:33972: TLS connected
Sep 29 17:27:08 jpenuchot-thinkpad rkvm-server[634]: [INFO  rkvm_server::server] <IP_ADDRESS>:33972: Authenticated succe
ssfully
Sep 29 17:27:14 jpenuchot-thinkpad rkvm-server[634]: [ERROR rkvm_server::server] <IP_ADDRESS>:38446: Disconnected: Conne
ction timed out (os error 110)

Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Authenticated successfully
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 0 (name "Video Bus", vendor 0, product 6, version 0)
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 1 (name "SynPS/2 Synaptics TouchPad", vendor 2, product 7, version 433)
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 2 (name "PC Speaker", vendor 31, product 1, version 256)
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 3 (name "Logitech USB Receiver Keyboard", vendor 1133, product 50503, version 273)
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 4 (name "Logitech USB Receiver", vendor 1133, product 50503, version 273)
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 5 (name "AT Translated Set 2 keyboard", vendor 1, product 1, version 43860)
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 6 (name "Power Button", vendor 0, product 1, version 0)
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 7 (name "Sleep Button", vendor 0, product 3, version 0)
Sep 29 17:27:08 jpenuchot-nzxt rkvm-client[1254]: [INFO  rkvm_client::client] Created new device 8 (name "solaar-keyboard", vendor 1, product 1, version 1)

The server notified a disconnection from the previous socket (before rebooting) after the client connected successfully on a new socket. It could be that the client wrongfully gets delisted by the server.

Could you RUST_LOG=debug systemctl import-environment RUST_LOG and restart both rkvms?

Client side, after this reboot the bug has been occurring:
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Authenticated successfully
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 0 (name "solaar-keyboard", vendor 1, product 1, version 1)
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 1 (name "Video Bus", vendor 0, product 6, version 0)
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 2 (name "SynPS/2 Synaptics TouchPad", vendor 2, product 7, version 433)
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 3 (name "PC Speaker", vendor 31, product 1, version 256)
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 4 (name "Logitech USB Receiver Keyboard", vendor 1133, product 50503, version 273)
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 5 (name "Logitech USB Receiver", vendor 1133, product 50503, version 273)
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 6 (name "AT Translated Set 2 keyboard", vendor 1, product 1, version 43860)
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 7 (name "Power Button", vendor 0, product 1, version 0)
Sep 29 17:46:58 jpenuchot-nzxt rkvm-client[1259]: [INFO  rkvm_client::client] Created new device 8 (name "Sleep Button", vendor 0, product 3, version 0)

Server side:
Sep 29 17:43:57 jpenuchot-thinkpad rkvm-server[44941]: [INFO  rkvm_server::server] <IP_ADDRESS>:56548: Connected
Sep 29 17:43:57 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rustls::server::hs] decided upon suite TLS13_AES_256_GCM_SHA384
Sep 29 17:43:57 jpenuchot-thinkpad rkvm-server[44941]: [INFO  rkvm_server::server] <IP_ADDRESS>:56548: TLS connected
Sep 29 17:43:57 jpenuchot-thinkpad rkvm-server[44941]: [INFO  rkvm_server::server] <IP_ADDRESS>:56548: Authenticated successfully
Sep 29 17:44:17 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 1
Sep 29 17:44:33 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 2
Sep 29 17:44:33 jpenuchot-thinkpad rkvm-server[44941]: [ERROR rkvm_server::server] <IP_ADDRESS>:44588: Disconnected: Connection timed out (os error 110)
Sep 29 17:44:35 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 1
Sep 29 17:44:37 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 0
Sep 29 17:46:17 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 1
Sep 29 17:46:18 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 0
Sep 29 17:46:58 jpenuchot-thinkpad rkvm-server[44941]: [INFO  rkvm_server::server] <IP_ADDRESS>:38522: Connected
Sep 29 17:46:58 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rustls::server::hs] decided upon suite TLS13_AES_256_GCM_SHA384
Sep 29 17:46:58 jpenuchot-thinkpad rkvm-server[44941]: [INFO  rkvm_server::server] <IP_ADDRESS>:38522: TLS connected
Sep 29 17:46:58 jpenuchot-thinkpad rkvm-server[44941]: [INFO  rkvm_server::server] <IP_ADDRESS>:38522: Authenticated successfully
Sep 29 17:47:08 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 1
Sep 29 17:47:08 jpenuchot-thinkpad rkvm-server[44941]: [ERROR rkvm_server::server] <IP_ADDRESS>:56548: Disconnected: Connection timed out (os error 110)
Sep 29 17:47:10 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 0
Sep 29 17:47:13 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 0
Sep 29 17:47:15 jpenuchot-thinkpad rkvm-server[44941]: [DEBUG rkvm_server::server] Switched to client 0

The bug doesn't occur on the first reconnect, but it does after the reconnect at 17:46:58

Again it happens when the port of the old socket is higher than the port of the new socket. Might be a coincidence but worth noting.

Can you try this?
diff --git a/rkvm-server/src/server.rs b/rkvm-server/src/server.rs
index 99fa531..d242c7d 100644
--- a/rkvm-server/src/server.rs
+++ b/rkvm-server/src/server.rs
@@ -63,9 +63,9 @@ pub async fn run(

                 // Remove dead clients.
                 clients.retain(|_, client: &mut Sender<_>| !client.is_closed());
-                if !clients.contains(current) {
-                    current = 0;
-                }
+                // if !clients.contains(current) {
+                //     current = 0;
+                // }

                 let init_updates = devices
                     .iter()
@@ -82,7 +82,7 @@ pub async fn run(
                     .collect();

                 let (sender, receiver) = mpsc::channel(1);
-                clients.insert(sender);
+                current = clients.insert(sender);

                 let span = tracing::info_span!("connection", addr = %addr);
                 tokio::spawn(

Sure! Could you apply this patch in a separate branch? I'm using rkvm through the AUR package but I'm not very, it would be quicker and easier for me to modify the pkgfile to simply track another branch.

sure, https://github.com/ckiee/rkvm/tree/debug-2023-09-29

Looks to me like it's still happening. Same behavior as before. I double-checked the sources after running makepkg on a PKGBUILD file that tracks your branch and the patch was applied as it should be.

Hey everyone, thanks for the help and sorry for the delay.
I reverted @ckiee's changes and looking into adding application level heartbeat so that I can release it for 0.5.0.

Fixed in 0.5.0.


Error in Main.yml - Playbook cannot run

When running 'ansible-playbook main.yml' I'm receiving the following error:
ERROR! no action detected in task. This often indicates a misspelled module name, or incorrect module path.
The error appears to have been in '/home/pi/internet-pi/main.yml': line 26, column 7, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
handlers:
- name: Include handlers.
^ here

Issue solved - did not install Ansible thru pip3 in the instructions and used sudo apt install Ansible which only gave me version 2.7.7. I believe Jeff commented that Ansible 2.9 is required at a minimum. Installers need to install pip3 first per the instructions and the follow the Ansible install instructions. Users will need to restart their PI before being able to install the requirements with Ansible in the following step.


Fix updated at time to use default branch commits and check monorepo directories

fixes #20
Why
The updated time was including any updates to the repo, such as issues created or commits in other branches. I think users would expect the updated time to either represent the last time a commit was made to the default branch e.g. master or the last publish time.
The updates would always be the same for monorepos, so every time large ones like expo had any updates the first few pages would be expo projects, even though only one of them had been updated.

Changes

Uses graphql api which allows us to make a single request to fetch the package.json and other details
Fixes updated time so it only checks commits on the default branch
Get the correct time for monorepos as it checks for commits within the folder

Checklist

If you added a feature or fixed a bug:

[x] Documented in this PR how to use the feature or replicate the bug.
[x] Documented in this PR how you fixed or created the feature.

Screenshot showing expo monorepo now has different updated dates that matches the folder location and master branch

Thanks to @kelset for providing initial graphql query in #50

hey Alex, thank you so much for picking this back up 👍
@brentvatne I think this new approach is totally worth as the original problem highlighted in my issue seems to still stand.

i pulled the branch locally and i had trouble fetching data using yarn data:update with the current batch size of 100 - i believe the graphql api has different throttling rules. i reduced the batch size to 50 and that resolved the issue for me.
we should update fetchGithubRateLimit to use the graphql api to determine how many more node requests are available and also compare that with the number of nodes required per repo request * number of repos to bail out of updating data and deploying if we are throttled

merged in https://github.com/react-native-directory/website/commit/4c1b864e616fdb5e13813acffb908b3611cc1727 - thanks a lot! if you can follow up with a fix for fetchGithubRateLimit and so on as described in previous comment that'd be amazing


Possible bug: Adding a custom repo

Fresh install of package manager, no packages matched and no settings changed.
Main menu -> package manager settings -> add custom repository -> paste repository url
When I click next the Available Repositories field is highlighted red, and an alert shows up with the message. "Required Fields missing or not passing validation. Please check red underlined fields and complete the required fields (ones with *)" It's not obvious to me how to proceed, but even checking that all the options under Available Repositories are checked I wasn't able to move forward.

I just tested and it worked for me. I suspect there are other required fields on the page that you didn't fill out, namely the "Specify what time update checking should be performed*" text box. Can you confirm that you did have a value entered for this?

I didn't touch those fields, and they didn't get marked red so I didn't even notice them. You're right that putting a value in them allowed me to continue though. Thanks for checking!

Weird, in your browser HE doesn't show the time picker in red... That would be an HE issue though, I don't have control over that. Glad it's working now!


Board Review: Azure Communication Services (SPOOL) [Recognize DTMF / Media Streaming] (.Net & Java)

Service name: ACS Server Calling
Key contact for this review: fmorales@
Link to previous API version: N/A
Description of the material to be reviewed/changed: C#/Java SDK operations for Recognize DTMF and Media Streaming.
Champion scenarios that briefly explain how developers will use your API:
Recognize: Contoso app can configure recognition of DTMF (dual-tone multiple-frequency) tones while playing IVR audio and takes necessary actions. Document link to a broader explanation.
Media Streaming: Contoso can request streaming of call audio (mixed/unmixed). Document link to a broader explanation.Languages for this review: C#, Java
Artifacts per language.

C# API View
Java Api View

Scheduled for 8/23 2p-4p PDT

Sample code for Media Streaming:
// Answer Call
var mediaStreamingConfiguration = new MediaStreamingConfigurationDto()
{
    TransportUrl = "wss://testwebsocket.webpubsub.azure.com/client/hubs/media?accesstoken={access_token}",
    ContentType = MediaStreamingContentTypeDto.Audio,
    AudioChannelType = MediaStreamingAudioChannelTypeDto.Unmixed
};
var response = await callingServerClient.AnswerCallAsync(
    incomingCallContext,
    new Uri(callConfiguration.AppCallbackUrl),
    mediaStreamingConfiguration);

// Create Call
var mediaStreamingConfiguration = new MediaStreamingConfigurationDto()
{
    TransportUrl = "wss://testwebsocket.webpubsub.azure.com/client/hubs/media?accesstoken={access_token}",
    ContentType = MediaStreamingContentTypeDto.Audio,
    AudioChannelType = MediaStreamingAudioChannelTypeDto.Unmixed
};

var createCallResult = await client.CreateCallAsync(
        callSource,
    new List<PhoneNumberIdentifier> { target },
    new Uri(callConfiguration.AppCallbackUrl),

    mediaStreamingConfiguration)

Recognize operations
var recognizeConfigurations = new RecognizeConfigurations
{
    InterruptPromptAndStartRecognition = true,
    InitialSilenceTimeoutInSeconds = TimeSpan.FromSeconds(5),
    TargetParticipant = new CommunicationUserIdentifier("8:acs:<guid>_<guid>"),
    DtmfConfigurations = new DtmfConfigurations
    {
        InterToneTimeoutInSeconds = TimeSpan.FromSeconds(5),
        MaxTonesToCollect = 5,
        StopTones = new List<StopTones> { StopTones.Pound, StopTones.Asterisk }
        },
};
var recognizeOptions = new RecognizeOptions(RecognizeInputType.Dtmf, recognizeConfigurations)
{
    OperationContext = Guid.NewGuid().ToString(),
    Prompt = new FileSource(new Uri(_callConfiguration.AudioFileUrl)),
    StopCurrentOperations = true,
};
var response = await _callConnection.GetCallMedia().RecognizeAsync(recognizeOptions).ConfigureAwait(false);

Recording (MS INTERNAL ONLY)

See also https://gist.github.com/KrzysztofCwalina/52f7a05ba6e988651d51f3e49d83569e for early thoughts on a webhook listener

I listened to the recording and wanted to share this approach I took as a helper library for my team's code (Call Automation).
The library consumes both Event Grid and CloudEvent types, handles deserialization and invocation of C# events.
Developers only need to wire up their handlers.
https://github.com/jasonshave/Azure.Communication.Services.EventHandler

Updated sample code for Recognize operation:
var recognizeOptions = new CallMediaRecognizeDtmfOptions(
    targetParticipant: new PhoneNumberIdentifier("<PhoneNumber>"),
    maxTonesToCollect: 5)
{
    InterruptPromptAndStartRecognition = true,
    InitialSilenceTimeout = TimeSpan.FromSeconds(5),
    InterToneTimeout = TimeSpan.FromSeconds(5),
    StopTones = new List<DtmfTone> { DtmfTone.Pound, DtmfTone.Asterisk }
    OperationContext = Guid.NewGuid().ToString(),
    Prompt = new FileSource(new Uri(_callConfiguration.AudioFileUrl)),
    StopCurrentOperations = true,
};
var response = await _callConnection.GetCallMedia().RecognizeAsync(recognizeOptions).ConfigureAwait(false);

New API Views, since we moved from calling server to call automation:
C# Api View

We had a follow up meeting with the following notes:

We are cleared for our Public Preview for both languages.
We received comments on the API view that we should consider for GA, but they are not a blocker for Public Preview.

With exception of Tone -> DtmfTone in Java, to keep parity.


securing links

Adding rel="noopener noreferrer" to <a href...>...</a>
In reference to issue #844

Reference taken from - (https://medium.com/@jitbit/target-blank-the-most-underestimated-vulnerability-ever-96e328301f4c)

@kd098, Thank you for your contribution. I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?

Well, it's never easy for the first time. I mistake at some point of the project, and even though it's my very first time I found it exciting and a valuable task. Though the tutorial is helpful it only takes some hours to understand it thoroughly and implement it in a real situation.
@Roshanjossey I owe my thanks

@Roshanjossey one request, can you update my username in your comment from kd098 -> pkg-96

I updated my comment but I don't see any user with GitHub username pkg-96.
We’ve added a tweet feature to our web app recently. Can you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


Add flag for cache body type

Current coverage is 100% (diff: 100%)

Merging #832 into v2.x will not change coverage

@@           v2.x   #832   diff @@
==================================
  Files         4      4
  Lines       418    429    +11
  Methods      80     80
  Messages      0      0
  Branches    100    100
==================================
+ Hits        418    429    +11
  Misses        0      0
  Partials      0      0

Powered by Codecov. Last update ce78786...1b86306

What would the (side?)-effects be to use use Symbols for the flags?

Better performance?

Hrm seems super overkill to me personally

If we're improving performance we should see a benchmark.
But yeah, seems overkill to me too

it will be a breanking change if developers already use ctx.flag for some other usage. also export flag is useless here.

I closed it.
@dead-horse Just you said, ctx.xxx would be overridden.


AutoUnmask not working on IE11

On IE11 the autounmask function is not working. It is retrieving masked values even after the option is set true. Does the option not work in IE browser.

@vikasdomakunti ,
Can you provide some info.
The mask used and some context.  Maybe a jsfiddle.

$("#callNumber").inputmask("(999) 999-9{4,46}",{autoUnmask: true});
This is the mask used.

@vikasdomakunti ,
And how do you want to retrieve the value?  by getting the value or on submit, ...

I was checking on IE11 for autounmask option working or not.
Here is the fiddle https://jsfiddle.net/vikasdomakunti/p1n4q6z1/2/

@vikasdomakunti ,
Have a look at https://jsfiddle.net/p1n4q6z1/7/
Use $.val instead of requesting the value property.
In chrome && FF it works with the value property because they allow to alter the native value property of the input.

Thanks Robin that solved the problem.

@vikasdomakunti ,
I reviewed the value patch and it it now working for IE also.
Have a look at https://jsfiddle.net/p1n4q6z1/9/


Temperature sensors giving wierd unit_of_measurement

Thank you very much for this cool tool.
It is working very well, however I have a small problem with temp-sensors as shown in the image below, the unit_of_measurement for temperature sensors is Â°C  instead of °C.

Any suggestions on how to fix this? Just for reference the units in hwinfo and SharedMemoryViewer looks fine:

did you use the latest HWINFO version? that should provide the data in unicode format
if not, then see the part here about the utf-8 checkbox in windows:
https://github.com/mhwlng/fip-elite

If you are already using the latest HWINFO+FIPHA, then please still try this checkbox, to see if it fixes your problem.

Yes I am using latest version of HWINFO+FIPHA. Now I enabled UTF-8 and it solved the problem.
Thank you :)


RuntimeError: Aborted(CompileError: wasm validation error: at offset 4: failed to match magic number). Build with -sASSERTIONS for more info

Hello !
I'm trying to reproduce your example in my code but I get an error but I get the error RuntimeError: Aborted(CompileError: wasm validation error: at offset 4: failed to match magic number). Build with -sASSERTIONS for more info

I precise that my application is in vue.js 3

What version of Vite are you using? It seems like it's serving .wasm files as text/html  instead of application/wasm.

I'm using the 5.3.1 and you have the 5.4.6.
Your fix worked, thank you very much !


Plugin Validation Issue

I'm unable to figure out why the yaegi interpreter isn't able to execute my plugin, as I'm able to run it in local-plugin mode just fine, and the line it's firing an error one doesn't seem to give me an idea of -why- it can't execute my plugin. I've confirmed the package name is the one it's referencing, it's the correct git repository, I've even put basePkg in the manifest in case for some reason it wasn't binding that git repo source to the package name correctly (although it does appear to).
failed to run the plugin with Yaegi: failed to eval `CreateConfig` function: 1:28: undefined: traefik_add_trace_id_header_2

Been doing some digging, adding log debugs to local copy of piceus to try to determine what's causing this, and it's really odd. I can run it in normal yaegi, trying to set it up as close as I can to what piceus does:
$ mkdir -p /tmp/ggg/src/github.com/cdwiegand
$ export GOPATH=/tmp/ggg
$ git clone https://github.com/cdwiegand/traefik-add-trace-id-header-2.git /tmp/ggg/src/github.com/cdwiegand/traefik-add-trace-id-header-2
Cloning into '/tmp/ggg/src/github.com/cdwiegand/traefik-add-trace-id-header-2'...
remote: Enumerating objects: 204, done.
remote: Counting objects: 100% (204/204), done.
remote: Compressing objects: 100% (124/124), done.
remote: Total 204 (delta 85), reused 183 (delta 67), pack-reused 0 (from 0)
Receiving objects: 100% (204/204), 69.75 KiB | 1.32 MiB/s, done.
Resolving deltas: 100% (85/85), done.
$ ~/go/bin/yaegi
> import "github.com/cdwiegand/traefik-add-trace-id-header-2"
: 0xc0005040d0
> traefik_add_trace_id_header_2.CreateConfig()
: &{  X-Trace-Id false 4 true}
> traefik_add_trace_id_header_2.New
: 0x4ee4c0
>

I've even confirmed the piceus is checking out the repo properly by not deleting the contents of the gopath it builds when it is checking the plugin, and if I have it dump to logger.Debug the import call and the result, I'm getting valid results:
// ~ line 153 of core/yaegi.go (https://github.com/cdwiegand/piceus/blob/cecde918260923e9db2285e52762887096d67c80/pkg/core/yaegi.go#L153)
	logger.Debug().Msg(fmt.Sprintf(`import %q`, manifest.Import))
	resp1, err := i.EvalWithContext(ctx, fmt.Sprintf(`import %q`, manifest.Import))

running with command
go build; make build; PICEUS_PRIVATE_MODE=true ./piceus run  --plugin-url https://github.com/cdwiegand/traefik-add-trace-id-header-2 --github-token xxxxx_my_readonly_token_goes_here_xxxxx --github-search-queries "repo:cdwiegand/traefik-add-trace-id-header-2" --github-search-queries-issues "repo:cdwiegand/traefik-add-trace-id-header-2" --log-level debug --run-skipped --dry-run

returns (I added --run-skipped so I could get it to re-run my repo even with the issue still on it)
{"level":"debug","yaegiMiddlewareCheck":"github.com/cdwiegand/traefik-add-trace-id-header-2","caller":"/mnt/c/Devel/piceus/pkg/core/yaegi.go:153","message":"import \"github.com/cdwiegand/traefik-add-trace-id-header-2\""}
{"level":"debug","yaegiMiddlewareCheck":"github.com/cdwiegand/traefik-add-trace-id-header-2","caller":"/mnt/c/Devel/piceus/pkg/core/yaegi.go:159","message":"Result: 0xc0005e5ae0"}

but I still get the error when it tries to call CreateConfig():
{"level":"debug","yaegiMiddlewareCheck":"github.com/cdwiegand/traefik-add-trace-id-header-2","caller":"/mnt/c/Devel/piceus/pkg/core/yaegi.go:167","message":"traefik_add_trace_id_header_2.CreateConfig()"}
{"level":"error","repo_name":"cdwiegand/traefik-add-trace-id-header-2","error":"failed to run the plugin with Yaegi: failed to eval traefik_add_trace_id_header_2.CreateConfig() function: 1:28: undefined: traefik_add_trace_id_header_2 using import \"github.com/cdwiegand/traefik-add-trace-id-header-2\"","caller":"/mnt/c/Devel/piceus/pkg/core/scrapper.go:141","message":"Failed to import repository"}

(I've added more variables in my fork to the logging to try to find the issue)
Anyone have any idea what might be causing this?

Appears it resolved, closing


Get internal route string from request

Is it possible to obtain the internal route string from a request?
If I have a route: "/api/{name}". And I request "/api/myName", I can get the url by request.url. But is it possible to the get the internal route string: "/api/{name}" somehow?

@basepaws-tech try this
app = FastAPI()
for route in app.routes:
    print(route.path)

Hey, please keep and follow the issue template, you can edit this issue or create a new one following the template here: https://github.com/tiangolo/fastapi/issues/new?assignees=&labels=question&template=question.md&title=

@basepaws-tech: from just a request, no, not readily; it's possible using a custom APIRoute class, however, considering the path template is stored in its attributes: https://github.com/tiangolo/fastapi/blob/master/fastapi/routing.py#L303-L306


Two extensions in webstore ?

There are apparently two versions of the extension in the webstore - https://chrome.google.com/webstore/search/foxish

Correct, not ideal but at one point the extension was removed by Google so
I re-added it while the issue was resolved. Now there are users on both and
I don't want to strand them by removing one of the listings.
Its the exact same offering on both listings.
On Mon, Aug 27, 2018 at 7:13 PM Ԝеѕ<EMAIL_ADDRESS>wrote:

There are apparently two versions of the extension in the webstore -
https://chrome.google.com/webstore/search/foxish
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/davidhampgonsalves/foxish/issues/7, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAK6zQiykvzOEa73OKZWMDuKT1CSpaDjks5uVG8GgaJpZM4WOlnH
.


Use JSON grammar files to generate extended instruction sets.

Overall this looks good.
The one weird thing is that the OpenCL spellings in SPIR-V assembly used lower-case names for functions instead like in the spec, but the names in OpenCL.std.h file use upper case letters.  For example SMul_hi is what's in OpenCL.std.h but the spelling we've used is s_mul_hi.
This will be a problem if we ever use the JSON file to generate the header. But we can solve it at that point, since that's a different process starting from JSON.
Sticky +2 with minor suggestion to fix the nit.  (But maybe nobody else would notice it.)

@dneto0: yeah, I agree with your thoughts on the inconsistency between the header, the spec/grammar.
And I'd prefer either snake_case or CamelCase (or consistent with the core spec), but the header is using something hybrid, which is quite strange for me.


Invalid hydration when using mergeWith of criteria with "with" models

Background

3 models defined in DB: A, B, C
A hasOne/hasMany B
A hasOne/hasMany C

Scenario
Making a query for A models with B models hydrated and merging criteria for the same base model having "with" models (here: C model)
$aModels = (new AQuery)
    ->leftJoinWith('B');
    ->mergeWith((new AQuery)->leftJoinWith('C'))
    ->find();

Produced SQL:
SELECT
    a.id, a.a_field, -- A fields
    b.id, b.a_id, b.b_field, -- B fields
    a.id, a.a_field, -- A fields again
    c.id, c.a_id, c.c_field -- C fields
FROM a
    LEFT JOIN b ON (a.id = b.a_id)
    LEFT JOIN c ON (a.id = c.a_id)

Results

model A hydrated properly
model B hydrated properly
model C hydrated improperly

Reason
PDODataFetcher::getIndexType is TableMap::TYPE_NUM so object hydration relies on the order of the columns in SELECT part.
At the beginning the offset of hydration is 0 meaning the A model is hydrated from columns indexed 0 and 1. Then offset is incremented to point to next column for next model hydration.
Then B model is hydrated from offset=2 to offset=4 (3 columns).
Then C model is hydrated from offset=5 to offset=7
Due to fact that A columns are selected twice the C model is hydrated partly from A columns being selected between B model columns and C model columns.

SELECT column
mapping
notes

a.id
A->id
valid

a.a_field
A->aField
valid

b.id
B->id
valid

b.a_id
B->aId
valid

b.b_field
B->bField
valid

a.id
C->id
(inconsistency!)

a.a_field
C->aId
(inconsistency!)

c.id
C->bField
(inconsistency!)

c.a_id

(ignored during hydration)

PR open


Missing http client host bindings

It looks like host bindings for http clients are missing, so right now an actor is unable to actually make a http request. It seems like the implementation just needs to be something like:
fn request(msg codec::http::Request) -> Result<()>

I'll take care of this

This will be taken care of by PR #13


[Question] The document of ‘code-suggestions’ is confusing

Question
When I read the document of ‘code-suggestions’ , I found that some examples are confusing.
Such as:
current : return null == a.getB() ? null : a.getB().getC();
recommendation : return Optional.ofNullable(a.getB()).map(C::getD).orElse(null);
current : return null == a ? new B() : C.newD(a);
recommendation : return Optional.ofNullable(a).map(B::newC).orElse(new D());
The code marked with the current and the code marked with the recommendation do not seem to match exactly.

Hi, If you have found that you can fix it, follow the code-suggestions .

The code marked with the current and the code marked with the recommendation do not seem to match exactly.

Sorry, I thought the document was also in this code repository (just like Spring Cloud Gateway), so I created an issue here, but now I realize that the document is in another code repository
And I have try to fix it.
current : return null == a.getB() ? null : a.getB().getC();
recommendation :Optional.ofNullable(a.getB()).map(B::getC).orElse(null);
current：return null == a ? new B() : C.newD(a);
recommendation : return Optional.ofNullable(a).map(B::new).orElse(C.newD(a));
I found these issues after a brief glance, maybe we need to recheck the document？
And I am willing to make some contributions to this project.

Hi,  Do you think there is something wrong with the documentation?   If so, you can fix it here ： https://github.com/apache/shenyu-website

current : return null == a.getB() ? null : a.getB().getC();
recommendation :Optional.ofNullable(a.getB()).map(B::getC).orElse(null);
current：return null == a ? new B() : C.newD(a);
recommendation : return Optional.ofNullable(a).map(B::new).orElse(C.newD(a));


Update OWL-API to 4.5.17

Noting: https://github.com/owlcollab/owltools/issues/298

Thanks @kltm! Forgot about that one.

And the problem remains. I think we need to adjust the code used to save to OBO format.


'Edit on GitHub' docs links broken

The 'Edit on GitHub' link in the documentation often tend to be broken.
For example, the link on the docs homepage of the 'stable' branch points to https://github.com/RPi-Distro/python-gpiozero/blob/20e9742f6f0cefa2264914de9dd19ff23312b18e/docs/index.rst which is a broken link.
@waveform80 is there a way we can resolve this? Or can we replace the link with a static link to the github repo?

Seems like the links work when viewing other versions of the docs, i.e.

'v1.4.0' -> https://github.com/RPi-Distro/python-gpiozero/blob/v1.4.0/docs/index.rst
'v1.4.1' -> https://github.com/RPi-Distro/python-gpiozero/blob/v1.4.1/docs/index.rst
'master' -> https://github.com/RPi-Distro/python-gpiozero/blob/master/docs/index.rst
'latest' -> https://github.com/RPi-Distro/python-gpiozero/blob/master/docs/index.rst
etc.

It's only these that don't work:

'stable' -> https://github.com/RPi-Distro/python-gpiozero/blob/6b9ca10eee7e27313b94aa46651a9fcc412bbc95/docs/index.rst
'pinout-man' -> https://github.com/RPi-Distro/python-gpiozero/blob/pinout-man/docs/index.rst

So maybe RTD needs to be told to ignore particular 'versions' / tags / branches ?
Is the 'stable' docs version supposed to effectively be a 'symlink' of the latest released version, i.e. 'v1.4.1' at the time of writing?

@bennuttall if you login to http://readthedocs.org/projects/gpiozero/ are you able to set the Default Version to latest?

I am - but I'd prefer the main version people see is the latest that's been released, rather than the latest on github. It could be that we implement and document new features (or make changes to existing classes), which people read about in the docs, but haven't been released yet.

Ah, yes, of course.
It's very odd because the RTD link to the current "stable" commit SHA-1 824caefc0a780a68723596275ea3019796d704dc (and previous SHA-1's above) doesn't exist at all on any GitHub repo.

This is a known problem over at RTD https://github.com/rtfd/readthedocs.org/issues/1820.
The SHA-1 is for a tag, not the commit.
On my local repo:
~/python-gpiozero $ git show 824caefc0a780a68723596275ea3019796d704dc
tag v1.4.1
Tagger: Dave Jones<EMAIL_ADDRESS>Date:   Wed Feb 21 15:35:25 2018 +0000

Release v1.4.1

The RTD PR to fix this is still waiting to be merged on the production servers.
https://github.com/rtfd/readthedocs.org/pull/3615

:+1:
I'll close this as it's out of out control, and in hand.

@bennuttall see https://github.com/rtfd/readthedocs.org/issues/1820#issuecomment-375833634 (which suggests rebuilding the docs should now fix it)

Hmm I've rebuilt stable but it doesn't seem to have changed the link

I believe RTD have still got to merge https://github.com/rtfd/readthedocs.org/pull/3615 which tells their production workflow to use git 2.  There servers are now running git 2.7.4 (as of 5 days ago) but they still need to update their workflow.


Rewrite in rust

Please, use nom

Hey @Taha-Firoz,
The benefits of Python really surpass any other language for this specific project. Ranging from; 1) UrduPython runs on Python under-the-hood and so it benefits it to be in Python as well, 2) Python is high-level and I am aiming for a trickle-down effect (i.e. from high-level language localization to lower-level language localization), 3) Assuming users already have Python installed in their systems, it's best off that UrduPython is in Python as well.
Maybe it could be looked into later, when the implementation is solid and it really needs optimization.


Update FunkinLua.hx

-- you really shouldn't just make pull requests without so much as a title or description saying, like, what your pull request is actually doing

-- thank you for the necropost kind stranger

im not necroposting, it looks like its gonna break lua scripts

-- it won't break lua scripts, it really won't do much of anything other than create a sliver of a degrade in performance for no benefit
-- also i don't think you know what necroposting is 'cause randomly commenting just "ugh" on a months old thread is definitely that

but i said ugh cuz how:
add winning icons = you broke the icon health system
@ShadowMario close this pls

and it impacts performance

-- this doesn't add winning icons


chore: 大幅なパッケージ構造変更およびGradleを用いたビルドプロセス変更

#9 と同じ

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@380a8cb). Click here to learn what that means.
The diff coverage is 71.53%.

@@           Coverage Diff            @@
##             master     #11   +/-   ##
========================================
  Coverage          ?   72.8%
  Complexity        ?     468
========================================
  Files             ?      28
  Lines             ?    1607
  Branches          ?     217
========================================
  Hits              ?    1170
  Misses            ?     389
  Partials          ?      48

Impacted Files
Coverage Δ
Complexity Δ

...ub/morichan/retuss/window/diagram/ContentType.java
100% <ø> (ø)
1 <0> (?)

...a/io/github/morichan/retuss/window/Controller.java
0% <0%> (ø)
0 <0> (?)

...orichan/retuss/window/diagram/NoteNodeDiagram.java
0% <0%> (ø)
0 <0> (?)

.../io/github/morichan/retuss/language/uml/Class.java
100% <100%> (ø)
22 <22> (?)

...hub/morichan/retuss/listener/JavaEvalListener.java
100% <100%> (ø)
16 <7> (?)

...han/retuss/window/diagram/ClassDiagramGraphic.java
100% <100%> (ø)
5 <1> (?)

...io/github/morichan/retuss/language/java/Value.java
100% <100%> (ø)
9 <9> (?)

.../io/github/morichan/retuss/language/java/Java.java
100% <100%> (ø)
8 <8> (?)

...io/github/morichan/retuss/language/java/Class.java
100% <100%> (ø)
30 <30> (?)

...hub/morichan/retuss/translator/JavaTranslator.java
100% <100%> (ø)
15 <15> (?)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380a8cb...c6cffe4. Read the comment docs.


SAK-29749 Group ID is passed over to Content Review for group assignments

-Since there is no record of who submitted for the group, I had to derive this from the attachment. This means that if an instructor submitted on behalf of the group, then it would select the instructor as the submitter
-This sends over just the original submitter as the user and not the whole group. VeriCite handles access just fine, but I'm not sure how TII would handle access for other group members
If TII wants to disable this for feature, then they will need to add a new method in Content Review like "allowGroupAssignments()" and then disable the interaction in the Create Assignment UI for instructors.

@buckett Could you please take a look at this PR?

I'm not sure how TII will handle this.

I'm not sure how TII will handle this.

My assumption is that TII will all it to submit fine and both the instructor and the submitter will be able to view it. However, I don't believe the other students in the group will be able to view it.
VeriCite trusts the LTI consumer, so VeriCite doesn't have a problem with letting the other users view the report. However, TII has external credentials and other non-LTI trusting walls in place.

Can this be merged?

I've made the changes requested by @buckett


Remove vSphere worker credentials

For 1.1, the user will no longer need to configure the vSphere worker
credentials, resolving a high severity security issue.

[#157813130]

Thanks @afong94!


Performance Acceptance Testing - Automation

Once Performance Acceptance Testing has been resolved (#166) we need to explore adding the Performance Acceptance Tests to the CI pipelines to validate performance on an ongoing basis going forward.

This may be something to look at for performance testing in the future: routing-perf-release


Dose the NVIVIA A6000 support the use of habitat-lab?

When I use the NVIVIA 6000, I met the issue when the habitat is initialized:
GL::Context: cannot retrieve OpenGL version: GL::Renderer::Error::InvalidValue
Aborted (core dumped)
What should I do to solve this problem?

I am using the NVIDIA A6000 graphics card.


Report all data from advertisement during discovery

From the examples it seems that only the device name and the MAC address are reported during a discovery. This was ok for classic bluetooth. But BLE can also deliver UUIDs during the undirected advertisement which is very useful for device discovery.
E.g. the Lego WeDo-2.0 hub is otherwise impossible to identify as the user is allowed to change the device name and the OID is from Texas Instruments. Thus the UUID from the undirected advertisement is needed to detect the device.

Good point! If you have time, we welcome your pull request!


snapserver listen only on ipv4

like explained in badaix/snapcast#715.
By default Snapserver broadcast both ipv4 and ipv4 addresses, but listen only to ipv4.

snapserver now listens on both ipv4 and ipv6.


Search for spectrum transform with higher resolution (singlets?).

Perhaps have a look into this webpage and referenced github!
https://builtin.com/data-science/wavelet-transform
They use a discrete wavelet transform to find R-peaks in an ECG heart-signal with an additional function!


Remove Basscss dependency for component CSS

Fixes #102.

Can we get this merged and a release out if possible please? The upgrade to the newer version here has knocked out a whole load of styling based on this inclusion in one of our projects, and would be lovely to simply upgrade with this PR and have it resolved! :)

@ToMoCoop Just published 4.0.10 with this fix 🚀


Train Model

I modified the st_gcn_aaai18.py， and want train a new model by using the dataset kinetics and NTU-D, but the accuracy is very low.
So I use the original st_gcn_aaai18.py and train a new model by using the dataset kinetics and NTU-D, the accuracy is very low too. But in theory, its accuracy should as same as the pre-train model, what is wrong with it?

same with you


Update to pull the rapids spark extra plugin jar

This adds the spark rapids private jar to the Aggregator jar.  This means we have to have this jar published for the build to work so we shouldn't merge this until that is ready, or users manually install that jar in their .m2.  Marking this as draft until that jar has been deployed.
We look for a file with extra plugins and then we load those and call the corresponding functions from our RapidsDriverPlugin and RapidsExecutorPlugin.
NOTE: We may want to find easy way for devs to point to internally pushed extra jar until it gets published externally.

build

the rapids-private jar is available on OSS snapshots repo: https://oss.sonatype.org/content/repositories/snapshots/com/nvidia/rapids-4-spark-private_2.12/23.04.0-SNAPSHOT/
trigger premerge build to verify

pre-merge CI PASS

NOTE: We may want to find easy way for devs to point to internally pushed extra jar until it gets published externally.
--> the private jar is published to the OSS snapshots repo, which is available for external user.

I am testing this now and running into issues. I can see that the final jar includes the classes from the private jar, but when I try and enable the plugin, I am getting a ClassNotFoundException. I'm debugging this now and will post an update once I understand more.

I am testing this now and running into issues. I can see that the final jar includes the classes from the private jar, but when I try and enable the plugin, I am getting a ClassNotFoundException. I'm debugging this now and will post an update once I understand more.

I understand now. I was explicitly adding the private plugin to spark.plugins but this is not necessary since the main plugin automatically loads it based on the spark-rapids-extra-plugins text file from the private jar.

build

From here, it seems that only 23.04.0-SNAPSHOT and 23.06.0-SNAPSHOT were published. Any plan to publish 23.04.0 and other official releases in the future? Otherwise, the teams outside NVIDIA have to point to SNAPSHOT ones when they build from source for a specific release.

we publish official release to sonatype, there is a 23.04.0 release of this and when we release 23.06.0 there will be a version of that as well.
https://oss.sonatype.org/content/repositories/staging/com/nvidia/rapids-4-spark-private_2.12/23.04.0/

Also easy to see how replacing snapshots to releases in the link in question redirects
- https://oss.sonatype.org/content/repositories/snapshots/com/nvidia/rapids-4-spark-private_2.12/
+ https://oss.sonatype.org/content/repositories/releases/com/nvidia/rapids-4-spark-private_2.12/

https://oss.sonatype.org/content/repositories/releases/com/nvidia/rapids-4-spark-private_2.12/ redirects to the URL Tom shows

Thanks for the reply! However, it seems there is not a one built against Spark 3.4.0 (332 at most). For SNAPSHOT ones, there is a one with Spark 3.4.0 indeed: https://oss.sonatype.org/content/repositories/snapshots/com/nvidia/rapids-4-spark-private_2.12/23.04.0-SNAPSHOT/rapids-4-spark-private_2.12-23.04.0-20230414.041020-2-spark340.jar. Any ideas why 23.04.0 with Spark 3.4.0 was not published? Ideally, I'd expect official ones and SNAPSHOT ones can have the same sets of SPARK support. BTW, maybe this is out of scope, but is there any plan/way the team outside NVIDIA can build this private artifact by ourselves?

The released plugin jar supports only released versions of Spark.
3.4.0 was released when 23.04 was already finalized, and as a FEATURE release hard to accommodate for last minute.

BTW, maybe this is out of scope, but is there any plan/way the team outside NVIDIA can build this private artifact by ourselves?

It's not something I can answer. On the flip side I have filed #7981 for making the private dependency optional but it hasn't been prioritized one way or another.


Upgrade Nom

[x] Nom 5
[x] Nom 6
[ ] Nom 7

For anyone following, I would love to finish this, but the new custom Error handling in nom is so painful, I have not found a good way to make it work

Last time I tried this, got stuck because of https://github.com/Geal/nom/issues/1078

Closing in favor of #214


Merge new-dartdocs into master branch

1.12 is out, I think we can merge branches. Thanks!

Handled in https://github.com/dart-lang/api.dartlang.org/pull/44


Issue In Bootstrap Form

Hi
I am creating an issue cause you did not respond to the findings I posted. The issue does not originate from the modal but from the form. Hope you can check and provide a fix soon.
So I managed to figure out a major bug in this plugin. This plugin cannot be used within a form when using bootstrap. As soon as the form tags are used, issues I have mentioned above arises. Additionally the element on change method fires an infinite loop that does not exit even after the event is fired. I also manage to figure out that this has nothing to do with modals as even an on page form causes this issue.
inputpicker-master without form.zip
inputpicker-master with form.zip
Originally posted by @KirenJames7 in https://github.com/ukalpa/inputpicker/issues/43#issuecomment-487256638

Hi @KirenJames7
Thank you very much for the feedback. I checked your code and encountered the different circumstance with you. What I have found is that both of two examples as you provided in the ajax mode are unable to be loaded when the page opens in the first time, after you reload the page, the inputpicker can be opened normally.
Can you please confirm if you encounter the same issue as me?
I do not know what your means of "change method fires an infinite loop that does not exit even after the event is fired", can you please explain it? Thanks a lot.

Hi @ukalpa

"change method fires an infinite loop that does not exit even after the event is fired"
hope the below explains

Check the console log in the example with the form element. You could see that once the input is focused a loop starts running and once item is selected of input focus is blurred the loop seems to be still running. (what I mean by loop may be a recursive function i couldn't dive deep into the plugin code). I couldn't check the ajax functionality yet as I haven't linked the back end to the app I am developing. But I will try to give you a feedback on this ASAP.  However there seems to be some bugs here and there.
However I hope you could fix the issue that occurs with the form tag ASAP. It's hard not to use the form tag.


Docker Image 1.4.0 is throwing "Permission denied" issues

Hi,
I'm having an issue when using version 1.4.0 of the docker image.
After populating /tmp/nvd, the application is unable to copy the files over to /usr/local/apache2/htdocs.
Running the container
mkdir -p /tmp/target/docs/

docker run -dit \
    --name mirror \
    -p 80:80 \
    --mount type=bind,source=/tmp/target/docs/,target=/usr/local/apache2/htdocs \
    sspringett/nvdmirror:1.4.0

Logs
2020-01-07 10:15:55,354 INFO Set uid to user 0 succeeded
2020-01-07 10:15:55,355 INFO supervisord started with pid 1
2020-01-07 10:15:56,357 INFO spawned: 'httpd' with pid 8
2020-01-07 10:15:56,358 INFO spawned: 'crond' with pid 9
2020-01-07 10:15:56,359 INFO spawned: 'initialize_htdocs' with pid 10
Updating...
crond 4.5 dillon's cron daemon, started with loglevel notice
AH00558: httpd: Could not reliably determine the server's fully qualified domain name, using <IP_ADDRESS>. Set the 'ServerName' directive globally to suppress this message
AH00558: httpd: Could not reliably determine the server's fully qualified domain name, using <IP_ADDRESS>. Set the 'ServerName' directive globally to suppress this message
[Tue Jan 07 10:15:56.384458 2020] [mpm_event:notice] [pid 8:tid<PHONE_NUMBER>53832] AH00489: Apache/2.4.39 (Unix) configured -- resuming normal operations
[Tue Jan 07 10:15:56.384489 2020] [core:notice] [pid 8:tid<PHONE_NUMBER>53832] AH00094: Command line: 'httpd -D FOREGROUND'
2020-01-07 10:15:57,385 INFO success: httpd entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2020-01-07 10:15:57,385 INFO success: crond entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
2020-01-07 10:15:57,385 INFO success: initialize_htdocs entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
/tmp/nvd/nvdcve-1.0-modified.meta
cp: can't create '/usr/local/apache2/htdocs/nvdcve-1.0-modified.meta': Permission denied

... snipped ...

/tmp/nvd/nvdcve-1.1-2020.json
cp: can't create '/usr/local/apache2/htdocs/nvdcve-1.1-2020.json': Permission denied
2020-01-07 10:22:44,156 INFO exited: initialize_htdocs (exit status 1; not expected)

Running processes
# ps -ef
PID   USER     TIME  COMMAND
    1 root      0:00 {supervisord} /usr/bin/python2 /usr/bin/supervisord -n -c /etc/supervisor/conf.d/supervisord.conf -l
    8 root      0:00 httpd -DFOREGROUND
    9 root      0:00 crond -s /var/spool/cron/crontabs -f
   25 daemon    0:00 httpd -DFOREGROUND
   26 daemon    0:00 httpd -DFOREGROUND
   27 daemon    0:00 httpd -DFOREGROUND
  122 root      0:00 /bin/bash
  323 root      0:00 ps -ef

Files in /tmp/
# ls -lah /tmp/
total 20
drwxrwxrwt    6 root     root        4.0K Jan  7 10:15 .
drwxr-xr-x   51 root     root        4.0K Jan  7 10:19 ..
drwxr-xr-x    2 root     root        4.0K Jan  7 10:30 cron.fObHDd
drwxr-xr-x    2 mirror   mirror      4.0K Jan  7 10:22 hsperfdata_mirror
drwxr-xr-x    2 mirror   mirror      4.0K Jan  7 10:22 nvd

Files in /usr/local/apache2/
total 48
drwxr-xr-x   15 www-data www-data    4.0K Jan  7 10:15 .
drwxr-xr-x   15 root     root        4.0K Jan  7 10:15 ..
drwxr-xr-x    2 root     root        4.0K May 11  2019 bin
drwxr-xr-x    2 root     root        4.0K May 11  2019 build
drwxr-xr-x    2 root     root        4.0K May 11  2019 cgi-bin
drwxr-xr-x    4 root     root        4.0K Oct 18 19:50 conf
drwxr-xr-x    3 root     root        4.0K May 11  2019 error
drwxrwxr-x    2 1000     1000        4.0K Jan  7 10:15 htdocs
drwxr-xr-x    3 root     root        4.0K May 11  2019 icons
drwxr-xr-x    2 root     root        4.0K May 11  2019 include
drwxr-xr-x    2 root     root        4.0K Jan  7 10:15 logs
drwxr-xr-x    2 root     root        4.0K May 11  2019 modules

Thank you for your time.

Hi,
If I start the container without specifying the volume to mount, it will work correctly.
I was following the instructions specified in the readme -- I don't need to mount it for my usage, closing this issue.
Kind regards.


Incoming Hazardous Weather - Status bug

Incoming Hazardous Weather - seek shelter immediately. Persistent Status character bug even if you entered interiors or changed location.

Details
I found a temporary solution by removing spell 281ED2 via console commands. Could also get stuck with 1639ee/281ecf/163fe0.
Game Version
1.9.67
Language
English (EN)
New Game
Yes
Reproduction Steps
started a new character

I too have encountered this, however, there is no reproduction steps that I have found, and as such, this tick is not very production or useful to the developers.

I created a fix for it here:
https://www.nexusmods.com/starfield/mods/8629

I created a fix for it here: https://www.nexusmods.com/starfield/mods/8629

Your fix for this works.

No longer an issue with newest patches 1.10.31 -> 1.10.32

Fixed in 1.10.32


[Accessibility] Support audio cues and alert for progress status

Type: Feature Request
CC @meganrogge
I think progress status is used in many cases, but I encounter this when using Jupyter Notebook. If current cell execution takes a long time, sighted people may see some visual cues indicating its progress status. However, there is no non-visual indication for screen reader users. Please consider adding audio cues.
Also, please consider adding alert as an independent configuration for deaf-blind and braille users.
VS Code version: Code - Insiders 1.84.0-insider (7dff07893ac160244db210e574eccc05f1cba2cb, 2023-10-24T05:33:54.929Z)
OS version: Windows_NT x64 10.0.22621
Modes:

@jooyoungseo thank you! Pretty sure this will be implemented, but I had a sidebar question: I’m always updating my audit of assistive audio in the wild—do you have any favorite progress audio cues you might name?

Would also apply to settings search progress.
We have the in progress chat response cue already, should that be used?

@meganrogge would it make sense to implement the same system as Copilot chat progress -- i.e. only triggering after x seconds, looping every y seconds, leaving/returning to window, etc?

If it is possible to estimate the progress ratio, I suggest an incremental tone just like Gauge Sounds. Otherwise, using audio cue the same as Copilot Chat would be fine.

@jooyoungseo thanks! Love this idea. However, I'd really want to hear it in context to confirm that I'm understanding it right. I've searched w/out luck -- do you know how I might get a screen recording of it?

@jooyoungseo Just wanted to check in about this -- you don't have the gauge sounds implemented, do you? If so, might you send me a screen recording of it for more context, or do you have any leads on how I might get a hold of some footage?

@meganrogge @jooyoungseo  Having footage of the incremental tone system, like Gauge Sounds would still be helpful if Jooyoung, you have a way to make that happen. In the meantime though, I'm curious what you all think (?):
If scenarios where progress takes greater than x seconds create a significant enough pain point among screenreader users, I do think having a system like this would be greatly beneficial (like a realtime progress bar via visual feedback).
From my understanding, there would need to be data that quantifies estimated percentage of completion, which informs the real time audio system as it increments. Flagging that we'd also need to investigate what that wait time threshold needs to be, in oder to justify the engineering needed for incrementing  — e.g. maybe it's >7, 12, 18 sec?
If the issue isn't significant enough, then yes, we could use the chat progress audio loop system (or something similar).

status is used in many cases, but I encounter this when using Jupyter Notebook. If current cell execution takes a long time, sighted people may see some visual cues indicating its progress status

@meganrogge  Trying to pick this conversation back up, since the speech to text ticket might be relevant. I have been working on this. Can you please send me screen grab videos of both the Settings search progress and Jupyter Notebook current cell execution examples? Thanks!

Are you just trying to see what cell execution looks like? Here is an example.
We don't have a way to know how long the execution is going to take since it's executing arbitrary code, it could be hours.

I'm not sure about settings search - if I understand what this is referring to, I've never seen the search take longer than a few hundred milliseconds.

@amunger Thank you!

@amunger @meganrogge @jooyoungseo Just wanted to see if we can come to a consensus. What kind of wait times exist for these use cases? Is it usually max 2-3 seconds, does it ever last >5, 12, 18 sec?
If we aren't using an incremental tone system, do we need an additional cue to indicate completion in cases where there are multiple progress statuses?
Microsoft team, what do we think about leveraging progress ratio calculation for an incremental tone system?

Question, are we considering replacing the copilot in progress cue with this one? If so, it can last a long time - 30 seconds or more

I believe I have answered your questions on the other issue @Afre100.
Are there downsides to using an incremental tone system?

@meganrogge  thanks! Re downsides to incremental tones…Highly informative real time feedback is great, but it could be quite disruptive if triggered accidentally (more so than the CoPilot progress loop, as there is much more sound happening/beeping over time than that system). This doesn’t mean the appropriate guardrails can’t be placed to mitigate that, or that it couldn’t be justified. I’m going to speak to partners, team, contacts to research more to give you a full cost benefit analysis.
As part of this research, It’s important to get footage/screen grabs of any incremental tone system in action, like Gauge Sounds which Jooyoung suggested. I haven't been able to find any w/in IDE's or similar and haven't heard back from him.
If JooYoung is able to work with us on any of this, I could definitely use a meeting with you all to help clarify/align on the best way to solve for all of these progress indicator use cases.
Also, would be great to know if people would want to end up switching windows/contexts while waiting for progress time on this interaction as well, if anyone knows

@meganrogge Where did the current version finally land with VSC CoPilot chat sounds, in terms of whether they're on by default when screen reader detected?

chatResponsePending is on by default for screen reader users. The other two are opt in.

@meganrogge @jooyoungseo  et all,
Looping in @codeofdusk (Engineer in Accessibility Insights) who flagged a few things:

Progress bars w/visual feedback for percentage often provide incremental tones through NVDA by default. Is it confirmed that this isn't available here, and is it available in any other instances of Progress Status?

Is there any reason we can’t mark up those progress bars with the appropriate UIA or ARIA attributes?

(adding @rperez030 for awareness/unsilo-ing convos)

I don't think our progress bars work with percentage and believe ours are custom vs native.

If it's a thing, how would ratio-based ARIA alerts play into this, if at all...is the idea that an incremental tone system would be less chaos than ratio-based ARIA alerts? (Because, if a screen reader voice is reading another window simultaneously, incrementing tones are easier to distinguish than the ARIA's 2nd voice)

@codeofdusk Is likely referring to aria progress bar https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/progressbar_role. A working example of this is present in devbox.microsoft.com where there is a loading status that uses this aria widget.  NVDA can be configured to either speak the status as percentage or play an incremental tone. Unfortunately, I don't believe there is complete support for this patter in JAWS, although I haven't tested that recently. In my opinion, this would only make sense if we can accurately estimate the completion time, and if it is long enough to matter. If we're thinking of communicating progress through audio cues, my first thought would be to use the same progress loop that is already in place for copilot chat, especially if there is no estimate.

That makes sense! What i'm stuck on is, it's unclear to me how much of a premium SR users put on incremental tone (indicating ratio/wait time, etc) over a progress loop (w/no ratio/wait time).
Intuitively, the incremental system seems significantly better, but as I’m not an SR user, I’m seeking to learn and build consensus.
From a design perspective, if it’s beneficial enough to design/implement an incremental system, I believe we can address the potential disorientation for SR users who are familiar with the CoPilot Chat loop. For instance, we could develop an incremental system that builds upon the existing sound of the progress loop, modulating it to create a more robust, dynamic, and incremental version of what users are accustomed to.
(I’m curious about how many users are even aware of the CoPilot Chat loop, especially if our decisions depend on this.)
Penny for anyone's thoughts :)

premium SR users???
As a screen reader user myself, I would tell you that I like it, but don't consider it that important. I'm sure there are others that do, and that's why we have this feature request. There are also screen reader users that rely on percentage rather than tones for accurate progress. That's why it is a configurable setting in NVDA. Different people process information in different ways.
Answering the question or whether it is worth investing in an incremental tones system would probably require a survey. For sure it would be a convenient feature for those who favor that type of feedback.
Regarding the copilot loop, if we are talking about screen reader users, I believe it is on by default when the screen reader mode is active, so anyone who uses a screen reader and uses the existing copilot flow is familiar with it.

@rperez030 To clarify, by "how much of a premium SR users put..." I'm referring to how much value SR users assign to  incremental tone (indicating ratio/wait time, etc) vs progress loop (w/no ratio/wait time). Sorry if that was unclear. You've actually answered that though in your awesome response already -- thank you!

Thank you! I'm glad because I wasn't sure whether I was helping you or confusing you even more.

@codeofdusk @rperez030 Do either of you know where I can hear/see recording/screengrabs of incremental tone in action? (I have access to the instructions/files for Gauge Sounds's release, but I'm trying to find examples of it, in action.). Thanks!

@amunger @meganrogge From an engineering perspective, is it known whether an incremental tone system, designed for the use cases mentioned here, could be repurposed and applied to other progress status situations?

Do either of you know where I can hear/see recording/screengrabs of incremental tone in action?

Sure:

Install NVDA.
With NVDA running, go to this page.

Huge thank you, @codeofdusk, for whipping that demo up for us! How do screen reader users (NVDA or other) using the progress bar "Beep" feature to perceive closeness to completion, given that there isn't a reference point for how high of a pitch "100% complete" sounds at the beginning of the interaction?
If there's no reference, wouldn't that only offer a vague sense of closeness to completion, at best?  Maybe it's the kind of thing where power users have internalized a ballpark pitch range, or remind themselves of the range by auditioning the lowest/highest pitch in a menu, or just replacing it w/their own familiar sounds...
If this is an issue, I wonder if there's a way to communicate what the "100% complete" pitch would sound like at the beginning to denote pitch range? (E.g. a quick playback of lowest pitch followed by highest pitch at progress bar's start, or accessed via a menu.)

For accurate value, screen reader users can employ speech alert along with the audio cues if they would like.

@jooyoungseo the repeated Current-to-reference playback was exactly what I imagined when I got looped into this!
If we think that'd end up feeling unnecessarily fussy, solving a non-problem w/yet more sound and cacophony, I'd love to know people's thoughts on that and act accordingly.
But on paper, it a) sounds like it could provide more of a sense of completion ratio and b) could be designed to be way less abrasive-sounding than the existing incremental beep sounds I've heard, which might help mitigate the cacophony concern

@AFre100 I think it's a matter of personal preference - some people will simply want to hear the current progressbar tone, while others will want to hear it alongside the reference tone to get a more detailed progression, and I'm fine with both. If you play the reference tone after the current tone, I think it's self-explanatory enough that screen reader users will quickly adapt and understand it without any training.

How do screen reader users (NVDA or other) using the progress bar "Beep" feature to perceive closeness to completion, given that there isn't a reference point for how high of a pitch "100% complete" sounds at the beginning of the interaction?

I'm probably the wrong person to ask (I have absolute pitch and have used NVDA for years) but I think people would develop a vague sense of the scale after using it for a while?

I think it's a matter of personal preference

Agree with this – once I internalize the scale (either by using it a couple of times or through hearing the reference tone in isolation) I'd probably turn it off.

@AFre100 what is your timeline for this?

@meganrogge checking in with a few parties -- will give you a detailed update by tomorrow!

@rebornix and I discussed this with @jooyoungseo and Venkatesh today.
We decided that we will likely:

loop the progress sound while a single cell runs
loop the progress until all cells have completed when run all cells is invoked

@meganrogge Nice, that makes sense!
In other news, this morning, I sent out this survey about preference for incremental tone vs progress loop to program-l, and an internal Msft list. So far there are 8 responses. We could get another 20-30 responses by Tuesday (hard to tell).

3 people strongly prefer an incremental tone system
3 people somewhat prefer an incremental tone system
1 person strongly prefers a progress loop
1 person has no preference

Do we want to definitely commit to a progress loop still, or shall we try to get more data about incremental vs loop?

@meganrogge If we're going with a progress sound loop, we're updating the existing Copilot Chat progress loop sound in order to be more globally usable, and improve upon some feedback (but still appropriate enough for the original interaction where it shouldn't cause any friction). So we can use this, as previously discussed.
We can deliver the progress loop update one month upon confirmation on whether we're going w/this direction (?).
Or, we can deliver the sounds for the incremental system 1-2 months upon confirmation. I suggest both engineering/design deciding a specific timeline together after one meeting because I think it could take some real time discussion sussing out what's possible in terms of real time audio processing in the code, (there could be some lightweight ways to do that are more efficient), and other variables. This could end up being more like 1 month depending on what we want/decide.
Thoughts?

Just checked out the survey again, at this time -- 7 prefer incremental (comprised of 4 strongly, 3 somewhat) vs 3 somewhat prefer progress loop sound, 1 has no pref. There are 3 "other" responses which prefer neither and want native, not custom progress bars

@AFre100 I thought we agreed we want a different sound for chat response pending?
@jooyoungseo and @rperez030 do you have thoughts on reusing this sound vs having another? I'm worried it'll be confusing to reuse here.

@jooyoungseo and @rperez030 do you have thoughts on reusing this sound vs having another? I'm worried it'll be confusing to reuse here.

I would strongly favor reusing the existing progress sound that we have become familiar with.

Ok great, then I think we can close this when @amunger has added this for running notebook cells.

@meganrogge  heads up -- if progress loop is the consensus, we're most likely updating the existing Copilot Chat progress loop sound (which would be used here too). That's being done in order to improve upon some feedback. I expect it to be close enough to the original sound where it shouldn't cause any friction for users who depend on it.
What's the next audio file delivery deadline for sound to be:
a) implemented for any non-copilot chat use of progress status loop (notebook cells, settings search, etc)?
b) swapped into existing copilot chat usage

Sounds good @AFre100. If we want this in by April, then April 17th

@meganrogge  thanks! And if it needed until the following release, that would be roughly one month later, a mid-May deadline, correct?

@meganrogge heads up -- if progress loop is the consensus, we're most likely updating the existing Copilot Chat progress loop sound (which would be used here too).

curious how you will determine the ETA for copilot generation so that the progress sound can reflect reality.

We cannot ATM determine the ETA, thus I don't think we should go with an incremental tone. Rather, we should play the sound every few seconds to indicate something is still happening.

Another use case is in the scm view, when changes are getting committed or pushed, there's a progress bar. We should play the cue for this to indicate the non-visual state.
https://github.com/microsoft/vscode/assets/29464607/a6426eeb-2527-46bb-adf0-76d60ec5b542

Another use case is in the scm view, when changes are getting committed or pushed, there's a progress bar. We should play the cue for this to indicate the non-visual state.
Screen.Recording.2024-04-04.at.7.53.21.AM.mov

if the proper markup is used, screen readers such as NVDA that support the progress bar pattern can communicate that using their standard mechanism. I don't oppose providing a vS Code signal if we believe it to be valuable, but I would prioritize supporting established accessibility practices first whenever possible.

That's a great point @rperez030.
Does VoiceOver have a similar concept @rperez030 ?
Is it the ARIA: progressbar role ?

One concern I have with playing this audio cue in the SCM, chat response view, settings UI, etc is these could happen simultaneously, which would be very disruptive and confusing.
The alternative would be to cancel one that's playing when focus is moved from that area, but I worry that is also a bad solution.
Perhaps we can do as @rperez030 suggests for the cases that have an actual progress bar rendered (SCM, settings search UI, etc.) instead.

That's a great point @rperez030.
Does VoiceOver have a similar concept @rperez030 ?
Is it the ARIA: progressbar role ?

Yes to all. I don't have Chrome install in this machine so cannot test chromium / voiceover support, but there is a working example to test here: https://github.com/microsoft/vscode/issues/196396#issuecomment-1908559313

@amunger, unassigning myself as this issue is now strictly about notebooks adopting chatResponsePending. We should probably rename that and migrate the setting. LMK if you need help with that.
Creating a separate issue about progress status in places with the progress bar, which we will add the role for as @rperez030 has suggested.

@meganrogge @amunger There's still the possibility that both notebook cell progress and chat response pending will take place, right? If, so, what did you all have in mind — keeping only one at a time via a focus shift/context switching?

One concern I have with playing this audio cue in the SCM, chat response view, settings UI, etc is these could happen simultaneously, which would be very disruptive and confusing.
The alternative would be to cancel one that's playing when focus is moved from that area, but I worry that is also a bad solution.
Perhaps we can do as @rperez030 suggests for the cases that have an actual progress bar rendered (SCM, settings search UI, etc.) instead, using this sound only for the cases that do not - notebook cell progress, chat response pending, etc.

That's unlikely to happen. But yeah, we'll probably cancel based on focus

@meganrogge @amunger Feel free to use the existing chatResponsePending progress sound if we're antsy for notebooks to have a progress sound for April. Would be nice to start with the updated sound in this new use case but it's not worth blocking users from its use. Otherwise, I expect to have the updated progress sound for May (as discussed above), which would be used wherever chatResponsePending would be used.  (I'm OOF 4/17-4/24 just fyi.)

i've been taking advantage of these audio cues when running long-running operations in notebooks in the latest insider build, thank you for implementing this! I wanted to make a few suggestions based on my observations to improve the experience.

determinant Vs. indeterminant progress bars could use different audio cues. I observe that VSCode plays the chat response pending sound for any operation that takes above a certain time. It may be useful to have a different sound as suggested by @jooyoungseo  that conveys the actual progress for long operations that surface this information (e.g. operations using the TQDM progress bars), with the chat response pending sound reserved for operations with indeterminant progress.
option to set smart repeat frequency based on desired verbosity for determinant progress bars. The current experience results in an audio cue being played every few seconds irrespective of the duration of the operation. This could result in noisy output for long-running operations. For example, hearing an alert every 3 seconds for an operation that is expected to take a few hours may not be desirable. updates with lesser verbosity, combined with VSCode's ability to play these cues in the background could enable an amazing multi-tasking developer experience. TQDM progress bars provide the following information to screen readers which makes me think that smart repeat frequency may be possible: " 57%|█████▊    | 115/200 [1:55:47<1:25:38, 60.46s/it]"
Option to disable audio cues when VSCode is out of focus. This may be less necessary if the alert frequency can be adjusted based on operation time for tasks that provide information for the runtime to be estimated as suggested in my previous point but may still be useful for long-running tasks where runtime cannot be estimated.
potentially confusing reasons for progress. I do not have a suggestion yet on how to address this, but I notice that VSCode plays a few progress sounds when I wake my computer up even if there is no running operation. I work by connecting to a computer via remote-ssh so I am not sure if this sound is a result of my local IDE re-connecting to VSCode Server on the remote machine. Being able to identify what a progress bar corresponds to could be helpful.

@venkateshpotluri thanks! Checking this out when I return tomorrow. Stay tuned


DEC-684: Unable to save metadata

Problem was due to the items controller not allowing arrays for some of the metadata fields that allow multiples. Fixed the items controller to allow arrays as params for all multiple fields. Also changed to permit user_defined_id to allow the user to change this if necessary.

:+1:

:+1:


feature/SC-5674-refactoringHomework

Description
I transferred all methods from homework.js to new PO. I matched the test. It is not finished yet. My plan is to merge my changes to develop, than I have to wait for Alicja refactoring of course area (courses and homeworks are connected, I don't want to work in this area in the same time to avoid conflicts), then I will back to finish refactoring the homework/tasks area.
Links to Tickets or other pull requests

Changes

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

[ ] All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Link to Definiton of Done
More and detailed information on the definition of done can be found on Confluence

Let's set WIP label on this PR.

new PR https://github.com/hpi-schul-cloud/integration-tests/pull/122 to this branch.


Router.navigate() not loading a page

hello i am trying to load a page using navigate but it wont work.
app.router.navigate('/prospects.html', { reloadCurrent: true});

There is no app.router instance, check documentation http://framework7.io/docs/view.html#view-methods-properties

oh okay, how do you define router then?

It must be used on view instance, not on the app

Do you want to ask a question? Are you looking for support? The Framework7 forum and Stack Overflow are the best places for getting support

Please, don't use GitHub issues for questions

sorry  for asking here, it just solved my problem. more power!


Missing BinaryOperator.cs file

Please add the file.

Fixed in https://github.com/m7nu3l/TinyBCT/commit/83355208af157e932bed350489ed27a99455ec23


./php-fpm/xdebug status no work

Info:

Docker version ($ docker --version): 18.09.2, build 6247962
Laradock commit ($ git rev-parse HEAD): #8254c34
System info (Mac, PC, Linux): WIN10
System info disto/version: 18945

Issue:

./php-fpm/xdebug status no work as XDEBUG GUIDE

Expected behavior:

Show the XDEBUG STATUS as XDEBUG GUIDE

Reproduce:

Type ./php-fpm/xdebug status in powershell

Relevant Code:
// place a code sample here

try php-fpm/xdebug status without './' in the begin of the command

Hi, i have the same problem, When i execute ./php-fpm/xdebug status from powershell doesn't work like the guide say. I have tried both ways with . and without . Even if i execute inside the php-fpm container doesn't work either because doesn't recognize docker executable. What should i do?
Program 'xdebug' failed to run: No application is associated with the specified file for this operationAt line:1 char:1 + ./php-fpm/xdebug status                                                                                + ~~~~~~~~~~~~~~~~~~~~~~~.                                                                                At line:1 char:1                                                                                + ./php-fpm/xdebug status                                                                                + ~~~~~~~~~~~~~~~~~~~~~~~                                                                                + CategoryInfo          : ResourceUnavailable: (:) [], ApplicationFailedException                                       + FullyQualifiedErrorId : NativeCommandFailed


resolver fixes

fix: handle improperly deployed components gracefully
fix: read tag from image_tag too https://keboola.slack.com/archives/CQB468K63/p1624543038092300

Sjednoceni image_tag a tag se teda zatim nekona, jo? :)

No nevím jak no :)


(FACT-2882) Fix fqdn on Linux

Description of the problem: Domain is not retrieve correctly on Linux based systems and results in a faulty fqdn fact.
Description of the fix Use Ruby Socket's methods to retrieve domain correctly.

Jenkins please test this on all

Jenkins please test this on all

Jenkins please test this on all

Jenkins please test this on all


can't loading libgit2.so

askgit: error while loading shared libraries: libgit2.so.1.1

askgit -v
askgit: error while loading shared libraries: libgit2.so.1.1: cannot open shared object file: No such file or directory
whereis libgit2.so.1.1
libgit2.so.1: /usr/local/lib/libgit2.so.1.1

closing due to staleness, please let me know if you've encountered this again in recent releases. sorry I wasn't able to follow up a year ago!


Adds new tools to create unit tests over Ledger types

Description
This was partly addresses issue #4171 .
That issue identified some potential problems with the code in  [eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs]
And suggested some tests to resolve the issue. Such a test need specific values with types such as Credential, StakeReference, UtxO,   IncrementalStake, PParams, Rewards, Deposits, all with complex interrelation-ships.
The module Test.Cardano.Ledger.UnitTestTools provided the tools to make such values clearly and succinctly. Here is an example

-- There are 2 Pools
pool1 = poolHash 30
pool2 = poolHash 31

-- There are 5 wallets, each with its own Credential
tom = stakeCred 1
ann = stakeCred 2
ron = stakeCred 3
john = stakeCred 4
mary = stakeCred 5

-- They each own an address
tomAddr = addr 1 0 -- 0 means tomAddr  does not have a StakeReference
annAddr = addr 2 2
ronAddr = addr 3 3
johnAddr = addr 4 4
maryAddr = addr 5 0 -- 0 means maryAddr  does not have a StakeReference

-- Each wallet has registered its credential,
rewards :: Map (Credential 'Staking StandardCrypto) RDPair
rewards = Map.fromList  -- (rdpair reward deposit)
    [ (tom,rdpair 5 6)  -- only rewards should be distributed
    , (ann,rdpair 7 6)  -- so we should see 53 distributed
    , (ron,rdpair 11 6)
    , (john,rdpair 13 6)
    , (mary,rdpair 17 6) ]

rdpair :: Word64 -> Word64 -> RDPair
rdpair x y = RDPair (CompactCoin x) (CompactCoin y)

-- Each wallet delegates to one of the pools
delegations :: Map (Credential 'Staking StandardCrypto) (KeyHash 'StakePool StandardCrypto)
delegations = Map.fromList
    [ (tom,pool1)   -- since every one is delegated
    , (ann,pool2)   -- no ones stake should be left out
    , (ron,pool1)
    , (john,pool2)
    , (mary,pool2) ]

-- Each wallet has one or more UTxO entries
-- Since tom and mary use a StakeRefNull those entries will not be distributed
utxo = UTxO(Map.fromList
   [(txIn 40 1,txOut tomAddr (Coin 23))  -- Not distrubuted 23
   ,(txIn 40 2,txOut tomAddr (Coin 29))  -- Not distributed 29
   ,(txIn 42 4,txOut annAddr (Coin 31))
   ,(txIn 43 1,txOut ronAddr (Coin 33))
   ,(txIn 44 2,txOut johnAddr (Coin 41))
   ,(txIn 45 1,txOut maryAddr (Coin 43)) -- Not distributed 43
   ])                 --total 200 - 95  105 should be distributed

umap :: UMap StandardCrypto
umap = unify rewards Map.empty delegations Map.empty

Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
[x] Self-reviewed the diff

It looks to me like the tools duplicate a lot of what we already have in ImpTest. For example tomAddr, annAddr, ronAddr, johnAddr, maryAddr etc. is already doable in ImpTest without having to provide indices manually:
pool1 <- freshKeyHash
...
tomAddr <- freshKeyAddr
annAddr <- freshKeyAddr
...

Also we're trying to get rid of tests in test-suite directories and move them to testlib, so it's better to write the tests there instead. New tests should be written using Spec from hspec instead of TestTree from tasty, since we agreed to move the tests to hspec. It'd be really nice if you could rewrite the tests using ImpTestM, it makes the tests much easier to follow and we're planning to move older tests to ImpTest anyways.

Replaced by PR #4242


Added evaluation code for VOC Pascal dataset

With the following PR it is possible to train FasterRCNN network using VOC dataset.
It was tested on fasterrcnn_resnet50_fpn and got over 70% mAp in 10 epochs.
python train.py --dataset voc --epochs 15 --lr-steps 10 -b 4 --lr 0.04 --model fasterrcnn_resnet50_fpn --data-path /data/set/
notes:

I'm pretty sure that the two eval method can easily be merged in a single one but I have no experience with the DistributedDataParallel module so i left it as it is
The eval code for VOC is file based, probably it is not the best idea to store the results in /tmp/ but it works
In ConvertVOCtoCOCO the name of the file is converted from string to array of int8, this is not as clean as parsing the actual image number, but it generalize better if used on other dataset that have more complex indexing system (e.g. WIDER FACE)
If you note useless code it may be because i have more advanced features in my repo that I didn't include in the PR

Are the changes proposed by @lpuglia are good to use for VOC evaluation?

Hello @lpuglia and sorry for the taking that long for an update.
As far as my understanding goes, it seems that in general, the references folder contains few reference scripts to train
various categories of computer vision models. I am not sure what is the strategy for the object detection subfolder (or other subfolders): is it planned to add more datasets and more training recipes or keep it "as is" for now and maybe link to external resources that provide other recipes. @pmeier has more details to share most likely.
In the meantime, there is a new datasets API being designed and since you use an existing dataset (namely VOCDetection),
I would like to share some details:

the main strategy is to pause development while the new API is being finished
otherwise, you can port the dataset to the new API and then use it in your proposed PR. Of course, someone else can do the migration first in another PR.

That being said, before embarking on this development, let's first check if this feature is still needed. Have you used this branch in some work or do you use another project to do this VOC Pascal evaluation? Or maybe another alternative?
Please share if this feature is still relevant @lpuglia. Many thanks in advance and sorry again for the delay.

@yassineAlouini This PR does not add a new dataset. The VOC detection dataset is supported in the old
https://github.com/pytorch/vision/blob/a1232c212d7cf84806189910ba83bc36bcea916c/torchvision/datasets/voc.py#L133
as well as the new API:
https://github.com/pytorch/vision/blob/a1232c212d7cf84806189910ba83bc36bcea916c/torchvision/prototype/datasets/_builtin/voc.py#L50
This PR adds support for this dataset in the reference training scripts, which only supports COCO
https://github.com/pytorch/vision/blob/a1232c212d7cf84806189910ba83bc36bcea916c/references/detection/train.py#L37
@lpuglia As @yassineAlouini mentioned, we are currently redesigning the datasets as well as the transforms. This in turn means that we also will adapting the reference scripts quite a bit and it should be easier to add new datasets.
IIUC, the major part of this contribution is to implement the evaluation method used for VOC. There shouldn't be much changes there, so we can port easily.
That being said, we are trying to close stale PRs. I would open an issue linking this PR so we don't forget (again) about this and close the PR for now. How does that sound?

@yassineAlouini This PR does not add a new dataset. The VOC detection dataset is supported in the old
https://github.com/pytorch/vision/blob/a1232c212d7cf84806189910ba83bc36bcea916c/torchvision/datasets/voc.py#L133
as well as the new API:
https://github.com/pytorch/vision/blob/a1232c212d7cf84806189910ba83bc36bcea916c/torchvision/prototype/datasets/_builtin/voc.py#L50
This PR adds support for this dataset in the reference training scripts, which only supports COCO
https://github.com/pytorch/vision/blob/a1232c212d7cf84806189910ba83bc36bcea916c/references/detection/train.py#L37
@lpuglia As @yassineAlouini mentioned, we are currently redesigning the datasets as well as the transforms. This in turn means that we also will adapting the reference scripts quite a bit and it should be easier to add new datasets.
IIUC, the major part of this contribution is to implement the evaluation method used for VOC. There shouldn't be much changes there, so we can port easily.
That being said, we are trying to close stale PRs. I would open an issue linking this PR so we don't forget (again) about this and close the PR for now. How does that sound?

I'm ok to close this, the feature is not needed anymore


updated citadel assets to remove manager relations, extra groups

This PR cleans up the citadel objects and relations json assets.
It removes manage relations completely. It also removes extraneous groups, and associated relations between users and the removed groups.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 38.522%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1183

Relevant Lines:
3071

💛  - Coveralls


docs: remove audio from autoplaying video

It was distracting when you navigate to the page and didn't serve an important purpose since it was only mouse click sounds, not a voiceover.
The result matches what we do for the other autoplaying video on https://docs.dxos.org/guide/getting-started.html, where the "volume" button is grayed out and can't be clicked.

ugh yes, I noticed this as well. thanks for this PR.