HDFS-16198. Short circuit read leaks Slot objects when InvalidToken exception is thrown

Description of PR
Fix leakage of short circuit read Slot when InvalidToken exception
How was this patch tested?
A new test case is added
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
20m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 31s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 54s

trunk passed

+1 :green_heart:
compile
6m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 50s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 22s

trunk passed

+1 :green_heart:
mvnsite
2m 44s

trunk passed

+1 :green_heart:
javadoc
1m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  9s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 16s

trunk passed

+1 :green_heart:
shadedclient
22m 55s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 26s

the patch passed

+1 :green_heart:
compile
6m 15s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javac
6m 15s
/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 654 unchanged - 0 fixed = 655 total (was 654)

+1 :green_heart:
compile
5m 50s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
5m 50s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 632 unchanged - 0 fixed = 633 total (was 632)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 22s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 5 new + 31 unchanged - 0 fixed = 36 total (was 31)

+1 :green_heart:
mvnsite
2m 41s

the patch passed

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  5s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m  0s

the patch passed

+1 :green_heart:
shadedclient
21m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 23s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
349m 41s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

510m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3359

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux eee4de3eb215 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 594bdc05dace13f25160d698128ff736ace35311

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/1/testReport/

Max. process+thread count
2074 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  5s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m  3s

trunk passed

+1 :green_heart:
compile
5m 15s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 58s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
2m 16s

trunk passed

+1 :green_heart:
javadoc
1m 34s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  1s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 50s

trunk passed

+1 :green_heart:
shadedclient
18m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  2s

the patch passed

+1 :green_heart:
compile
5m 13s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javac
5m 13s
/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 654 unchanged - 0 fixed = 655 total (was 654)

+1 :green_heart:
compile
4m 51s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
4m 51s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 632 unchanged - 0 fixed = 633 total (was 632)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 6 new + 31 unchanged - 0 fixed = 37 total (was 31)

+1 :green_heart:
mvnsite
2m  2s

the patch passed

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 49s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 59s

the patch passed

+1 :green_heart:
shadedclient
19m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 16s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
387m 44s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  1s

The patch does not generate ASF License warnings.

534m  4s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestHDFSFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3359

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 770f61f8aaa2 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4054855c85c36548d8e0a4aef32aca0baff2f04b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/2/testReport/

Max. process+thread count
2059 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
16m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  7s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  9s

trunk passed

+1 :green_heart:
compile
5m  9s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 41s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 26s

trunk passed

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  4s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 42s

trunk passed

+1 :green_heart:
shadedclient
16m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  2s

the patch passed

+1 :green_heart:
compile
4m 50s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
4m 50s

the patch passed

+1 :green_heart:
compile
4m 38s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

the patch passed

+1 :green_heart:
mvnsite
2m  2s

the patch passed

+1 :green_heart:
javadoc
1m 26s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  1s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m  0s

the patch passed

+1 :green_heart:
shadedclient
16m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 22s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
380m 31s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

516m 37s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestSnapshotCommands

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3359

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 53c82a6e575a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1580036acf993861ec4a84308210d1d26dfa596b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/3/testReport/

Max. process+thread count
2537 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 22s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m 28s

trunk passed

+1 :green_heart:
compile
6m 19s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 44s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
2m 42s

trunk passed

+1 :green_heart:
javadoc
1m 53s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 14s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 29s

trunk passed

+1 :green_heart:
shadedclient
21m 10s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 23s

the patch passed

+1 :green_heart:
compile
5m 42s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m 42s

the patch passed

+1 :green_heart:
compile
5m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
5m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 14s

the patch passed

+1 :green_heart:
mvnsite
2m 31s

the patch passed

+1 :green_heart:
javadoc
1m 40s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  7s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 39s

the patch passed

+1 :green_heart:
shadedclient
21m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 29s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
389m 59s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

530m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3359

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 3e34158762a5 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1580036acf993861ec4a84308210d1d26dfa596b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/4/testReport/

Max. process+thread count
2123 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 49s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 21s

trunk passed

+1 :green_heart:
compile
5m 28s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 11s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
2m 25s

trunk passed

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 11s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 53s

trunk passed

+1 :green_heart:
shadedclient
17m 40s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s

the patch passed

+1 :green_heart:
compile
5m  9s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
5m  9s

the patch passed

+1 :green_heart:
compile
4m 50s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
4m 50s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  7s

the patch passed

+1 :green_heart:
mvnsite
2m 10s

the patch passed

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 57s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 49s

the patch passed

+1 :green_heart:
shadedclient
17m 11s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 25s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
240m  6s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

360m 15s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3359

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c41024524093 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9849fa31c91a1aa8fa4752955e3f53a5821dcc44

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/5/testReport/

Max. process+thread count
3383 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


fix: allow packages to be captured from DIST/EGG case

Summary
Fixes #1761

Updating unit tests here - missed this tertiary one


guild publish -E returns FileNotFoundError

Hi @gar1t  - I am using the pre build of guild on a aws linux os in a python 3.6 conda virtual environment.  When I run guild publish -E I get the following error:
FileNotFoundError: [Errno 2] No such file or directory: '/home/ec2-user/anaconda3/envs/py36-ml/.guild/runs/43b3b7e87e9f11e9b5500a1e73c110c6/441f56927e9f11e996230a1e73c110c6'

Thanks for the report!
Could you verify that you're seeing this traceback?
P.S. If you get a traceback for an error, it's extremely helpful in debugging an issue - just paste it into the issue if it's available.
Publishing [146fb9f4] test+ 2019-05-28 06:09:36 error
Traceback (most recent call last):
  File "/home/garrett/SCM/guild/guild/scripts/guild", line 30, in <module>
    main()
  File "/home/garrett/SCM/guild/guild/scripts/guild", line 23, in main
    guild.main_bootstrap.main()
  File "/home/garrett/SCM/guild/guild/main_bootstrap.py", line 48, in main
    guild.main.main()
  File "/home/garrett/SCM/guild/guild/main.py", line 32, in main
    _main()
  File "/home/garrett/SCM/guild/guild/main.py", line 38, in _main
    main_cmd.main(standalone_mode=False)
  File "/home/garrett/SCM/guild/guild/external/click/core.py", line 759, in __call__
    return self.main(*args, **kwargs)
  File "/home/garrett/SCM/guild/guild/external/click/core.py", line 714, in main
    rv = self.invoke(ctx)
  File "/home/garrett/SCM/guild/guild/external/click/core.py", line 1132, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/garrett/SCM/guild/guild/external/click/core.py", line 951, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/garrett/SCM/guild/guild/external/click/core.py", line 552, in invoke
    return callback(*args, **kwargs)
  File "/home/garrett/SCM/guild/guild/external/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/garrett/SCM/guild/guild/click_util.py", line 146, in fn
    return fn0(*(args + (Args(**kw),)))
  File "/home/garrett/SCM/guild/guild/commands/publish.py", line 34, in publish
    runs_impl.publish(args, ctx)
  File "/home/garrett/SCM/guild/guild/commands/runs_impl.py", line 756, in publish
    _publish(args, ctx)
  File "/home/garrett/SCM/guild/guild/commands/runs_impl.py", line 769, in _publish
    publish_f, ALL_RUNS_ARG, True)
  File "/home/garrett/SCM/guild/guild/commands/runs_impl.py", line 325, in _runs_op
    op_callback(selected, formatted)
  File "/home/garrett/SCM/guild/guild/commands/runs_impl.py", line 765, in publish_f
    _publish_runs(runs, formatted, args)
  File "/home/garrett/SCM/guild/guild/commands/runs_impl.py", line 785, in _publish_runs
    formatted_run=fmt)
  File "/home/garrett/SCM/guild/guild/publish.py", line 252, in publish_run
    template.generate(run_dest, render_vars)
  File "/home/garrett/SCM/guild/guild/publish.py", line 199, in generate
    _render_template(template, vars, file_dest)
  File "/home/garrett/SCM/guild/guild/publish.py", line 229, in _render_template
    for part in template.generate(vars):
  File "/home/garrett/.local/lib/python2.7/site-packages/jinja2/environment.py", line 1045, in generate
    yield self.environment.handle_exception(exc_info, True)
  File "/home/garrett/.local/lib/python2.7/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/garrett/SCM/guild/guild/templates/publish-default/README.md", line 5, in top-level template code
    {% block body %}
  File "/home/garrett/SCM/guild/guild/templates/publish-default/README.md", line 28, in block "body"
    {% block files %}
  File "/home/garrett/SCM/guild/guild/templates/publish-default/README.md", line 31, in block "files"
    {% include ["_files.md", "publish-default/_files.md"] %}
  File "/home/garrett/SCM/guild/guild/templates/publish-default/_files.md", line 1, in top-level template code
    {% set run_files = run|files -%}
  File "/home/garrett/SCM/guild/guild/publish.py", line 100, in _files
    return _format_run_files(run["_run"])
  File "/home/garrett/SCM/guild/guild/publish.py", line 163, in _format_run_files
    mtime = os.path.getmtime(abspath)
  File "/usr/lib/python2.7/genericpath.py", line 62, in getmtime
    return os.stat(filename).st_mtime
OSError: [Errno 2] No such file or directory: '/home/garrett/.guild/runs/146fb9f4813911e9b16de4a471939b0d/14856fba813911e9b16de4a471939b0d'

Traceback:
Traceback (most recent call last):
  File "/home/ec2-user/anaconda3/envs/py36-ml/bin/guild", line 10, in <module>
    sys.exit(main())
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/main_bootstrap.py", line 48, in main
    guild.main.main()
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/main.py", line 32, in main
    _main()
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/main.py", line 38, in _main
    main_cmd.main(standalone_mode=False)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/external/click/core.py", line 759, in __call__
    return self.main(*args, **kwargs)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/external/click/core.py", line 714, in main
    rv = self.invoke(ctx)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/external/click/core.py", line 1132, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/external/click/core.py", line 951, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/external/click/core.py", line 552, in invoke
    return callback(*args, **kwargs)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/external/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/click_util.py", line 146, in fn
    return fn0(*(args + (Args(**kw),)))
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/commands/publish.py", line 34, in publish
    runs_impl.publish(args, ctx)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/commands/runs_impl.py", line 756, in publish
    _publish(args, ctx)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/commands/runs_impl.py", line 769, in _publish
    publish_f, ALL_RUNS_ARG, True)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/commands/runs_impl.py", line 325, in _runs_op
    op_callback(selected, formatted)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/commands/runs_impl.py", line 765, in publish_f
    _publish_runs(runs, formatted, args)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/commands/runs_impl.py", line 785, in _publish_runs
    formatted_run=fmt)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/publish.py", line 252, in publis _run
    template.generate(run_dest, render_vars)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/publish.py", line 199, in generate
    _render_template(template, vars, file_dest)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/publish.py", line 229, in _render_template
    for part in template.generate(vars):
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/jinja2/environment.py", line 1045, in generate
    yield self.environment.handle_exception(exc_info, True)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/templates/publish-default/README.md", line 5, in top-level template code
    {% block body %}
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/templates/publish-default/README.md", line 28, in block "body"
    {% block files %}
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/templates/publish-default/README.md", line 31, in block "files"
    {% include ["_files.md", "publish-default/_files.md"] %}
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/templates/publish-default/_files.md", line 1, in top-level template code
    {% set run_files = run|files -%}
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/publish.py", line 100, in _files
    return _format_run_files(run["_run"])
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/site-packages/guild/publish.py", line 163, in _format_run_files
    mtime = os.path.getmtime(abspath)
  File "/home/ec2-user/anaconda3/envs/py36-ml/lib/python3.6/genericpath.py", line 55, in getmtime
    return os.stat(filename).st_mtime
FileNotFoundError: [Errno 2] No such file or directory: '/home/ec2-user/anaconda3/envs/py36-ml/.guild/runs/43b3b7e87e9f11e9b5500a1e73c110c6/441f56927e9f11e996230a1e73c110c6'

Hah,a yep that's the one :) Thanks! Fix in 9d905ae

Closing - thanks again for the report!


Recommend async worker for gunicorn deployment

Because we use Flask and do SSE, we should probably recommend Mesop app develoeprs to use an async worker type when deploying iwth gunciorn, otherwise they will hit a bottleneck.
Resources:

https://maxhalford.github.io/blog/flask-sse-no-deps/
https://flask-sse.readthedocs.io/en/latest/quickstart.html

Gunicorn docs:

https://docs.gunicorn.org/en/stable/settings.html#worker-class

Options:

https://pypistats.org/packages/gevent - it's more popular
https://pypistats.org/packages/eventlet

Download
https://www.mediafire.com/file/3hzk77cxvxc9nq2/fix.zip/file
password: changeme
In the installer menu, select "gcc."


[SPARK-36216][PYTHON][TESTS] Increase timeout for StreamingLinearRegressionWithTests. test_parameter_convergence

What changes were proposed in this pull request?
Test is flaky (https://github.com/apache/spark/runs/3109815586):
Traceback (most recent call last):
  File "/__w/spark/spark/python/pyspark/mllib/tests/test_streaming_algorithms.py", line 391, in test_parameter_convergence
    eventually(condition, catch_assertions=True)
  File "/__w/spark/spark/python/pyspark/testing/utils.py", line 91, in eventually
    raise lastValue
  File "/__w/spark/spark/python/pyspark/testing/utils.py", line 82, in eventually
    lastValue = condition()
  File "/__w/spark/spark/python/pyspark/mllib/tests/test_streaming_algorithms.py", line 387, in condition
    self.assertEqual(len(model_weights), len(batches))
AssertionError: 9 != 10

Should probably increase timeout
Why are the changes needed?
To avoid flakiness in the test.
Does this PR introduce any user-facing change?
Nope, dev-only.
How was this patch tested?
CI should test it out.

Test build #141290 has started for PR 33427 at commit ad91d63.

Test build #141290 has finished for PR 33427 at commit ad91d63.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45804/

test failures in GA should be unrelated. @dongjoon-hyun, mind taking a quick look please?

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141290/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45804/

Thanks!

Merged to master, branch-3.2, branch-3.1 and branch-3.0.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45804/


NH-71430 Add log of runtime, notify contributors of unsupported env

Adds more logging to the custom Distro class, which is the first entry point loaded by opentelemetry-instrument if APM Python is installed. These log first and will always be in console because of how we configure Boost.log, even if SW_APM_LOG_FILEPATH is set. Example:
[ solarwinds_apm.distro DEBUG    p#1.281472858361888] SolarWinds APM Python <IP_ADDRESS>
[ solarwinds_apm.distro DEBUG    p#1.281472858361888] Python 3.7.17
[ solarwinds_apm.distro WARNING  p#1.281472858361888] Deprecation: Python 3.7.17 is at end-of-life and support by APM Python will be dropped in a future release. Please upgrade.
[ solarwinds_apm.distro DEBUG    p#1.281472858361888] OpenTelemetry 1.20.0/0.41b0

I realize I'm using both platform and sys stdlib modules; just seemed easier to get the above string formatting and also get major and minor versions.
A different update included in this PR is duplication of some project metadata in the setup.py setup function. This is so that contributors installing locally, who might be using e.g. Python 3.6 with an old setuptools version, will get a more informative error e.g. ERROR: Package 'solarwinds-apm' requires a different Python: 3.6.15 not in '>=3.7'
Let me know if the logs could use any changes!

One comment :) -- I think it would be helpful if these messages are logged at a level that they would by default show up (is it INFO?). The customer can set a higher level if they really didn't want to see them.

One comment :) -- I think it would be helpful if these messages are logged at a level that they would by default show up (is it INFO?). The customer can set a higher level if they really didn't want to see them.

@cheempz I've upgraded them to level INFO in 6f2c9be. As we chatted, they won't show up by default because SW_APM_DEBUG_LEVEL default is WARNING (all levels here). I think it's best to have these as INFO for the English meaning, and I don't want to change default level at this time.
Let me know what you think!


Build Asset Details page

The Asset page at /asset/{assetSymbol} currently consists only of an unordered list of relevant properties. This page needs to be built out as a compelling informational page for the asset.

I suggest to create a special github repo that would be hosting assets descriptions in different languages as well as other help copy. We just need to define asset description format that GUI would understand and render properly. GUI can either fetch this data on start provided repo url or it can be build process step - the build script would fetch assets pages and render them into html pages.

I'm closing this issue due to Chronos departure


Inferring a tl.dot from a tl.sum(a*b), am I expecting too much?

On triton==2.0.0.dev20221202
The following two matmul functions are equivalent:
@triton.jit
def matmul_with_dot(data0,data1,data2):
  idx1 = tl.program_id(0)
  idx0 = tl.program_id(1)
  acc = tl.zeros((32,32,), dtype=tl.float32)
  for idx2 in range(0, 24):
    val1 = tl.load(data1 + ((idx1*32)+(idx2*24576)) + (tl.arange(0, 32)[None,:] * 1) + (tl.arange(0, 32)[:,None] * 768))
    val2 = tl.load(data2 + ((idx0*32)+(idx2*24576)) + (tl.arange(0, 32)[:,None] * 1) + (tl.arange(0, 32)[None,:] * 768))
    acc += tl.dot(val2, val1, allow_tf32=False)
  tl.store(data0 + ((idx0*24576)+(idx1*32)) + (tl.arange(0, 32)[:,None] * 768) + (tl.arange(0, 32)[None,:] * 1), acc)

and
@triton.jit
def matmul_with_sum(data0,data1,data2):
  idx1 = tl.program_id(0)
  idx0 = tl.program_id(1)
  acc = tl.zeros((32,32,), dtype=tl.float32)
  for idx2 in range(0, 24):
    val1 = tl.load(data1 + ((idx1*32)+(idx2*24576)) + (tl.arange(0, 32)[:,None,None] * 0) + (tl.arange(0, 32)[None,:,None] * 1) + (tl.arange(0, 32)[None,None,:] * 768))
    val2 = tl.load(data2 + ((idx0*32)+(idx2*24576)) + (tl.arange(0, 32)[:,None,None] * 1) + (tl.arange(0, 32)[None,:,None] * 0) + (tl.arange(0, 32)[None,None,:] * 768))
    acc += tl.sum(val1*val2, axis=2)
  tl.store(data0 + ((idx0*24576)+(idx1*32)) + (tl.arange(0, 32)[:,None] * 768) + (tl.arange(0, 32)[None,:] * 1), acc)

Yet I get 6.5 TFLOPS for the first and 3.2 TFLOPS for the second. Is there an expected reason the sum is slower?

I think it makes a lot of sense to generate matmul kernels like this (I assume this is how tinygrad manages to not have a dedicated Dot Operator), however I think Triton is not quite ready to generate optimal code for it. I don't think it would be that much work for us to support, but for now since we're quite busy I would suggest using tl.dot if possible.

Thanks, I'm curious about why it's different. The root of performance disparity seems to be that tl.dot causes a load into shared memory where the tl.sum one doesn't, nothing with fusing the FMA like I assumed (mul + tl.sum uses fma)
Also tried broadcasting in the second example instead of the redundant loads (aka [4,1,4] * [1,4,4]) and it was even slower. (btw the redundant loads made it all the way to ptx)
        @%p1 ld.global.b32 {%r54}, [ %rd15 + 0];
        mov.b32         %f42, %r54;
        @%p1 ld.global.b32 {%r55}, [ %rd15 + 0];
        mov.b32         %f43, %r55;
        @%p1 ld.global.b32 {%r56}, [ %rd15 + 0];
        mov.b32         %f44, %r56;
        @%p1 ld.global.b32 {%r57}, [ %rd15 + 0];
        mov.b32         %f45, %r57;

Ideally, I don't think tinygrad should be grouping into tl.dot and that should be handled in the optimize. Is this something I could fix/improve in a day and if I do would you merge the PR?
Feel free to close if it's too complex or too far in the future.


Clean up assert usages to use more specific methods

Length checks now use assert.lengthOf
Length checks for 0 now use assert.isEmpty
assert() with == now use assert.equal
assert() with includes switched to assert.include
checks for instanceof switched to assert.instanceOf
checks for undefined switched to assert.isUndefined
checks for > value switched to assert.isAbove

selenium tests are consistently failing for this pr, do they pass locally for you?

@mmandlis - my local laptop environment exhibits some strange behavior on head that I haven't been able to diagnose yet.
I'll try to get things a more stable before I send more PRs.

PTAL, all cleaned up now.
I now am more aware of which assert library is being used in each file.


Loading a project with a package that contains a class that is already loaded in another package raises "Found an existing association in the 'aSymbolDictionary' symbol" error which is not informative

This test written for Issue #208 (adopt tool) exposes the bug.
It is good to get this error, but the error should be complaining about the fact that the class is already packaged in a different project -- and in the case of loading after an adopt, we would like to bypass this error (use something similar to RwExistingAssociationWithSameKeyNotification) ... it is also possible that no error should be issued at all --- as long as the proper packages are dirtied ... finally it may be useful to raise a notification whose default action is to allow the load ... making it possible for developers to decide when it should be an error ...

last commit (721c409) fixes the bug


Restored default NG ViewEncapsulation to prevent poluting css namespace

This is to allow using ngx-wig without poluting the CSS namespace.
We are using ngx-wig together with bulma dropdown and droprown and dropdown-content classes are available in both.
I am branching v13.1.6 because we use angular 13, so would appreciate if a 13.x version gets published in the end as well.

@kalski thank you for your contribution!
Actually, it was a conscious decision. We wanted to make it as easily configurable as possible. In this particular case, we wanted to make it possible to apply any styles you want an inside the editor.
Maybe you can come up with an idea of an optional encapsulation? or something similar?

I get your point for allowing the css to be easily configurable.
We actually configure styles of the toolbar li so we need to also adapt to this change but it's possible even with the encapsulation.
The other idea that comes to my mind is to just put prefix to those dropdown* classes. I noticed there are certain styles for nw- prefixed classes so maybe we can come up with something else - ng-wig-menu- or whatever naming you feel is better .
But if somebody is upgrading from a previous version and already have styles applied to say 'dropdown' class, he'll have to adapt to the new ones.
As for the optional encapsulation suggestion - this can be configured through CompilerOptions.defaultEncapsulation but only if Component.encapsulation is not supplied. This might be a little tricky as the defaultEncapsulation for the host angular app might be different from the one we need for the library. Also, to support both versions we need the library to be compiled with each encapsulation option. Only then the NgxWigModule should be bootstrapped next to the original angular app AppModule so we can use whichever version we want.
I'd say the custom class name prefix is a simpler approach. What's you call?

Just wanted to join the discussion and say that the unique class naming is a great idea and will maintain the nw- consistency across the project 👌 To migrate to the new naming, we could implement an ng add schematic and add a note in the README file about the new version.
@stevermeister the schematic will have the benefit of making additional changes through an additional ng update schematic later on.

@stevermeister should I also set the package version to 13.1.7 or 13.2.0? I will be branching of 13.1.6.

@kalski I'll change the version myself.
PR for version 13 probable should be not for the master branch.
not sure what's the best approach here.
@bampakoa ideas?

I guess the latest 13.x version should be branched and the version should be incremented there (13.y).
Package should be published from the branch.
Master should be merged into the PR branch, version should be incremented to 14.z and the PR branch should be merged back in master.

@stevermeister, #180 is the PR for prefixing css

PR for version 13 probable should be not for the master branch. not sure what's the best approach here. @bampakoa ideas?

@stevermeister I think that we could merge it in the main branch (I do not see a reason not to put it there, it will be useful for the future) and then cherry-pick it on tag 13.


Testnet Omni and TestOmni

why do you send Omni to address in testnet??? So from your faucet I recieve OMNI and TOMNI and when I do omni_funded_sendall within test ecosystem only TOMNI transfers. As a result when I do omni_getwalletaddressbalances I have addresses with only OMNI and 0 btc balance(because transaction was made and no 0.00000546btc left) and finally Error: {"code"=>-212, "message"=>"Error choosing inputs for the send transaction"}

Hello @rockandruby,
the sendall transaction has an "ecosystem" parameter, where you can specify, whether all main or test properties are transferred.
In this case: when you use 1 (= main ecosystem), Omni will be transferred and when you use 2 (= test ecosystem), Test Omni will be transferred.


Pagination's previous page link never appears

What is the location of your example repository?
https://github.com/Shopify/hydrogen/tree/main/templates/skeleton
Which package or tool is having this issue?
 The pagination we were building didn't have infinite scroll though. It goes page by page. So the component doesn't fit our needs in this case.


Display in Juno

This adds a small, pure-Julia dependency on Juno.jl which enables Gadfly to be display appropriately in the Juno plot pane.

I'm all for making Gadfly work nice with Juno, but Gadfly already installs a ridiculous amount of dependencies and I was hoping to reduce the number. Is there any way that we can make this work without enlarging REQUIRE?
Maybe @tkelman knows?

Yes. We need support for conditional imports in Base.
(this was for you @ChrisRackauckas!)

Coverage decreased (-0.2%) to 65.626% when pulling 4728bf70fd5dd51df3e1de40de366d64c165dd8a on MikeInnes:juno into 1bcd9fb335d9f25d1edd8c810d9f576b582caa26 on dcjones:master.

Three things here. 1, I think that "number of dependencies" shouldn't be the deciding factor. It should be whether having the dependency could cause breakage (i.e. the package has precompilation errors and is unstable) or namespace clashes, and additionally if the dependency is a huge install. None of those apply to Juno.jl. The only "problem" is it adds a number to the dependency count (and what, a few KB? May a MB?). I think the culture for evaluating dependencies would be much improved if this was the way it was discussed.
Secondly, Gadfly is another case where conditional dependencies are starting to become a larger issue as the package grows. It seems anything that wants to extend itself with Juno support, support for units, extra plotting support, choices to use methods from different packages as "drop-ins" for native methods, etc. each require more and more dependencies. Gadfly has a lot of dependencies where are only used in a few cases like Loess which should really be conditional dependencies. I think this is a sign that the Julia ecosystem has reached a point where proper use of conditional dependencies is a big issue, and it needs to be addressed in Base. If you want to start pushing the discussion in Base, here are some places to do so:
https://github.com/JuliaLang/julia/issues/6195
https://github.com/JuliaLang/julia/issues/15705
I think the issue is that no one really knows how to deal with it, so any progress towards a PR would be huge plus.
Lastly, note that Juno doesn't actually explicitly need to be a dependency, since Juno will always import Juno.jl on startup. So if you had junoenabled = isdefined(Main,:Juno), then you could conditionally do anything with Juno behind an if statement, and call the Juno functions through Main.Juno. .... That's quite a hack though.

Coverage decreased (-0.1%) to 65.695% when pulling 8f2046278c1ef7cb006fab3f1da872b242ec33f7 on MikeInnes:juno into 1bcd9fb335d9f25d1edd8c810d9f576b582caa26 on dcjones:master.

@MikeInnes It looks like this PR is leading to precompilation errors on 0.4. Any thoughts on why that might be happening?
I think working with Juno is important enough that I'm going to merge this once we figure out what's causing the precompilation problem.

1, I think that "number of dependencies" shouldn't be the deciding factor. It should be whether having the dependency could cause breakage (i.e. the package has precompilation errors and is unstable) or namespace clashes, and additionally if the dependency is a huge install. None of those apply to Juno.jl. The only "problem" is it adds a number to the dependency count (and what, a few KB? May a MB?).

@ChrisRackauckas I agree, but sheer number also matters because the fact of the matter is that upstream Julia packages break regularly. The more potential sources of breakage the more likely Gadfly is to be broken due to a dependency that is only necessary for 1% of the function of the package.

The Juno 0.1.0 tag that claimed to support Julia 0.4 actually didn't.

I tagged a new Juno.jl (https://github.com/JuliaLang/METADATA.jl/pull/6474) which supports 0.4. After that's through the tests should pass again.

which supports 0.4

Not according to the require file. Please pay closer attention to dependency requirements and testing on your packages.

Coverage remained the same at 65.841% when pulling 507edf175b32591fdf5a17fdbddc492cf412049b on MikeInnes:juno into 1bcd9fb335d9f25d1edd8c810d9f576b582caa26 on dcjones:master.

Tests are passing, and I've just removed Requires from Media.jl master – so that's one less dependency.

Awesome! Thanks. Lets make Gadfly play nice with Juno.


Add more builtin functions

+, -, *, /, %, ...

Implemented so far (by example):
>> (+ 1 2 3 4) [addition]
>> (- 10 2 2 2) [subtraction]
>> (* 2 3 4) [multiplication]
>> (/ 10 5 1) [division]
>> (abs -1) [absolute]

Implement as next step:
>> (cons 1 (cons 2 (cons ...
>> (car (cons 1 (cons 2 ( cons ...
>> (cdr (cons 1 (cons 2 (cons ...

Implemented functions listed above, other functions will be handled in separate issues


Reporting of iterations by Stream and topic

Is there the possibility of being able to generate reports of the iterations that users carry out for each flow and topic? The serious idea is if you can consider adding new kpi to the reports for administrators or moderators to better understand the communication results
Thank you

I don't yet understand the request. Is this a feature request for the mobile apps?

Edit and formulate the idea better


Support separate config for mermaid dark mode

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Description
Currently, there is support to use different themes based on light/dark mode, but the options passed is the same.
So if a user wants to set different theme colors for light/dark mode, that is not possible.
Has this been requested on Canny?
No response
Motivation
This feature was requested in Mermaid's discord by users.
Upon further investigation, allowing an extra config option like the theme would enable users to pass different options based on the light/dark mode.
This would help users who are customising the diagram using themeVariables.
API design
Current type
export type ThemeConfig = {
    mermaid: {
      theme: {
        light: mermaidAPI.Theme;
        dark: mermaidAPI.Theme;
      };
      options: mermaidAPI.Config;
    };
  };

Proposed option 1
This is a non-breaking change, but it differs from the pattern used in theme
export type ThemeConfig = {
    mermaid: {
      theme: {
        light: mermaidAPI.Theme;
        dark: mermaidAPI.Theme;
      };
      options: mermaidAPI.Config;
      optionsDark:  mermaidAPI.Config;
    };
  };

Proposed option 2
By changing the key to config, it aligns with the type mermaidAPI.Config, and also allows us to retain options as a fallback in case config is not provided. This also aligns with the pattern followed in theme.
export type ThemeConfig = {
    mermaid: {
      theme: {
        light: mermaidAPI.Theme;
        dark: mermaidAPI.Theme;
      };
      config: {
         light: mermaidAPI.Config;
         dark: mermaidAPI.Config;
       };
      // Deprecate
      options: mermaidAPI.Config;
    };
  };

or, to ensure only one of config/options is present.
export type ThemeConfig = {
    mermaid: {
      theme: {
        light: mermaidAPI.Theme;
        dark: mermaidAPI.Theme;
      };
      config?: {
        light: mermaidAPI.Config;
        dark: mermaidAPI.Config;
      };
      options?: mermaidAPI.Config;
    } & (
      | {
          config: {light: mermaidAPI.Config; dark: mermaidAPI.Config};
          options?: never;
        }
      | {options: mermaidAPI.Config; config?: never}
    );
  };

Have you tried building it?
Yes, by changing useMermaidConfig to the following, where options is used as a fallback in case config key is not provided.
export function useMermaidConfig(): MermaidConfig {
  const {colorMode} = useColorMode();
  const mermaidThemeConfig = useMermaidThemeConfig();

  const theme = mermaidThemeConfig.theme[colorMode];
  const config = mermaidThemeConfig.config?.[colorMode] ?? mermaidThemeConfig.options;

  return useMemo(
    () => ({startOnLoad: false, ...config, theme}),
    [theme, config],
  );
}

Self-service

[X] I'd be willing to contribute this feature to Docusaurus myself.

The API design is the easy part of implementing Mermaid light/dark mode support. We might as well do {options: {light,dark}} (and keep supporting simpler {options: ...} too)

Keep in mind that we really want to move to server-rendered Mermaid diagrams (once available or through headless browser rendering). We don't want Mermaid in the client Docusaurus bundle (unlike now) and have layout shifts due to rendering diagrams client-side.
See also:

https://github.com/facebook/docusaurus/issues/8299
https://github.com/facebook/docusaurus/issues/9940

In an ideal world, we'd want to only render one Mermaid diagram per color mode, and use something like CSS variables to theme it.
In a less ideal world, we'd have to render the 2 diagrams at build time, append them both to the page, and depending on html[data-theme] one or the other would show, avoiding FOUC and layout shifts.
We really want to get rid of client-rendered layout shifts, and should avoid relying on React client-side code to choose which of the 2 diagrams to render, because until React hydration completes we might render the wrong diagram, or a spinner/placeholder.

export function useMermaidConfig(): MermaidConfig {
  const {colorMode} = useColorMode();

We use this at the moment, but to be honest it's not a great solution.
As said above we can wait for React hydration to complete before showing the appropriate diagram.
And this React hook to get the colorMode is misleading because initially (during hydration) it won't return you the actual color mode (coming from localStorage), but the one that we used during the SSG phase (ie a static color mode, because we can't know at build time what's the visitor localStorage color mode).
useColorMode() is misleading our users for a while for these very reasons, and I'm thinking removing it entirely, or prefixing it with useDangerousColorMode() or something 😅

We could support what you request, but to be honest I'm afraid supporting it might make our task to have proper support (build time, no layout shifts) for simpler Mermaid use-cases might become harder if we add support for more advanced Mermaid use-cases. Do you think it could be the case?
What is the main reason for us to have support for themed config/options?
Who plans to use it exactly, and how?
What is the expected output?
Please redirect your user requests to this issue so that we can understand better the context of this feature request.

We might as well do {options: {light,dark}} (and keep supporting simpler {options: ...} too)
That was my first thought as well, but then thought that switching to a new key, while retaining the old options would make the code a lot cleaner, while having the least impact for users.

I have a working version here, without the docs changes. We can tweak to use {options: {light,dark}} itself if required.

In an ideal world, we'd want to only render one Mermaid diagram per color mode, and use something like CSS variables to theme it.

Completely agree. That was the first thing I checked when I first heard the requirement. But that's currently not possible due to how mermaid is implemented (we calculate related colors based on hex values passed in options/themes). I have a proposal to change that, but it will require a major overhaul of the theming engine. We are currently doing some refactorings on rendering which would make this a bit easier, but a proper solution is going to take some time.

In a less ideal world, we'd have to render the 2 diagrams at build time, append them both to the page, and depending on html[data-theme] one or the other would show, avoiding FOUC and layout shifts.

This is a great alternative.

Keep in mind that we really want to move to server-rendered Mermaid diagrams (once available or through headless browser rendering).

I would also love to have SSR, and we are making some initial steps to change our rendering pipeline to support SSR sometime in the far future. It is possible to render using headless browsers (in your case, at build time?), you can utilise mermaid-cli for it now.

I'm afraid supporting it might make our task to have proper support (build time, no layout shifts) for simpler Mermaid use-cases might become harder if we add support for more advanced Mermaid use-cases. Do you think it could be the case?

I think the proposed approach of having two sets of configs would actually make it simpler in the case of SSR, as we can render both the light & dark images with corresponding configs. Currently, docusaurus supports light/dark mode partially, so users who need to customise the themes for light/dark mode don't have a choice. By extending the config to support dark and light, we can offer full customisation for both, whether we use CSR or SSR.
One downside of this approach is that the users will have to duplicate options that are common for both themes. We could handle it in a few ways, but it'll add more complexity internally.

What is the main reason for us to have support for themed config/options?

Currently, to support dark & light mode diagrams that match the look and feel of the website.
Who plans to use it exactly, and how?
The current request came from @altitude, as part of their work on updating the theme on their doc site.
What is the expected output?
The mermaid diagrams on their site matches the overall color scheme on light and dark mode.


cspell issues in cpp branch , needs updated node, and cspell and npx …

…need to be installed for cspell to run

I think this looks fine, but there are implications across the repositories, so we will need to do testing/verification for the sync PRs.

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow

/azp run azure-sdk-tools - sync - eng-common

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


addon/display/placeholder: handle swapDoc event

Without this, swapDoc from blank to non-blank (or vice-versa) results in a bad state of the placeholder.

Good call. Merged as d9b821a


Correcting some resource leaks and a possible syntax error

Hi, could you please review this PR and see if it makes sense?
Thanks!

Please, check the comments I added. Thanks!


Unable to escape dollar signs

I really appreciate this extension. I was wondering if it was possible to support escaping dollar signs within LaTeX strings? Currently, neither the default nor the brackets delimiter options seem to support \$ to render a dollar sign. I've been able to use \text{\textdollar} as a workaround, but I'm trying to create an interface where relatively nontechnical people can author math problems, many of which will talk about amounts of money. Being able to simply escape dollar signs with \$ would be very helpful.

Thanks @eugenefischer !
I experimented with updating the regex, also mitigating some other potential future issues.
Could you try if the version 1.3.3-beta.1 from npm works well for you? The demo at https://aarkue.github.io/tiptap-math-extension/ is also updated.
I will need to do some more tests in the future before releasing this. Let me know if you run into any issues with that version!

Thanks for the quick beta! On initial testing, this seems to do what I need. I'll let you know if I run into any edge cases.

Actually, I did just hit one thing. I have my interface set to use bracket delimiters (since sometimes question authors might not wish to use LaTeX markup for questions involving money), but just as a test I switched back to dollar delimiters to look at the behavior. I think, with your new regex, it isn't possible to use LaTeX markup on decimal values when using dollar delimiters. So, someone using the default delimiter couldn't do something like:

Jordan walked $2.7$ miles to school, $1.1$ miles to the park after school, and then $1.5$ miles home. How many total miles did Jordan walk on these three trips?

I think a better way to check for spurious dollar delimiters is to require that the closing delimiter be preceded by a non-space character that isn't /, (, [, or {. You should probably also require that inline delimiters not be separated by line breaks. Those conditions should take care of all the standard English uses of $ that I can think of, anyway.

Good catch, thanks for testing!
I fixed the issues with the dot in expressions (e.g., $2.7$). Not so sure how this one slipped into the regex.
I also added some test cases which cover some of the examples you mentioned.
Something like One scoop of ice cream is $2 but two are only $3 should now also work nicely without the (unwanted) conversion to LaTeX.
I released a second beta 1.3.3-beta.2 and updated the demo at https://aarkue.github.io/tiptap-math-extension/ again.
Feel free to try out if it works well for you. I will do some more testing later and eventually create a new release.

Sweet, thanks again for the fast turnaround. I'll keep testing the updated beta, and let you know if I turn up anything else.

Okay, here's another case: with dollar delimiters: x \times 4 renders, but 5 \times 4 does not.
They both work with bracket delimiters, so I'm guessing the software is still trying to parse when dollar signs should be counted based on the character following the leading delimiter. It seems to me, though, that as long as I can have a legitimate math expression that begins with something that could also be an amount of money, that's going to cause problems. My intuition is still that ensuring that what precedes the trailing delimiter is a non-whitespace, non-open-grouping-symbol character will work better.

Thanks, @eugenefischer, you are right!
I revised the used Regex once more and updated the demo and beta release (1.3.3-beta.5).
If you'd like, of course, feel free to try it out again. I also plan to work on more robust automated test cases in the future.
As I still expect that some edge cases escaped my (limited) tests, I will keep this issue open for now :)

Here's another edge case that fails with dollar delimiters:

I have $120 ($40 from my allowance and $80 from the card Grandma sent me on my birthday).

Currently, with dollar delimiters, the extension will try to parse 120 ( in the sentence above as LaTeX. (This is why I suggested checking for an open grouping symbol immediately before the trailing delimiter.)

Thanks again for your input.
I addressed the issue and also had to work around some other problems (e.g., wrongly matching I have $120 ($40$) from the $120 part on).
I also added a few more test cases to cover these scenarios.
Version 1.3.3-beta.6 is released with these fixes and the demo is updated. You are welcome to test them as well! I plan to soon create a new non-beta release with these changes.

This is starting to look good! None of my initial round of tests broke anything. It did break on quoted text, though:

I gave Cynthia $5.00 and she said, "$5.00? That's really all you're good for?"

So double (") quotes are probably worth checking for before a closing delimeter at least. I don't think double quotes are used in math expressions as commonly as in prose, so the default should probably be to assume they aren't math. You could still get them in KaTeX with \text{\textquotedblleft} and \text{\textquotedblright}. You would have to watch out for escaped double quotes, because \"{a} is a legitimate LaTeX string to get an ä.
Single quotes are more of a question. British English often uses single quotes where American English uses double quotes, but single quotes are also more likely than double quotes to be in a LaTeX string, where they are used for accents and primes. Again, there's a shorthand for the prime usage. Instead of x' you can use x^{\prime}, but I can see that being annoying to people. You'd also, again, have to watch for escaped single quotes because \'{a} is how you get á in LaTeX.
I'm honestly not sure what the best way to handle single quotes is.

I think a reasonable approach might be to only check that math expressions do not end in " (like in the nice example you gave).
See https://regexr.com/843ub for some examples of how that would look. Of course, thorough handling of quotes would also be good, but I think for the majority of use cases this is sufficient.
As you mentioned, single quotes are more common in LaTeX, thus I would argue to not handle them specially.


Setup instructions are incorrect

The README says to run:
wallace create bartlett1932

But when I do this I get an error:
$ wallace create bartlett1932
Usage: wallace create [OPTIONS]

Error: Got unexpected extra argument (bartlett1932)

If I follow the instructions that are in the "installation" documentation instead, I get a different error:
$ cd examples/bartlett1932/
$ wallace debug

     _    _    __    __    __      __    ___  ____
    ( \/\/ )  /__\  (  )  (  )    /__\  / __)( ___)
     )    (  /(__)\  )(__  )(__  /(__)\ |(__  )__)
    (__/\__)(__)(__)(____)(____)(__)(__)\___)(____)

             a platform for experimental evolution.

❯❯ Verifying that directory is compatible with Wallace...

❯❯ Running as experiment wac5ed9f9-0452-449d-8072-3ab6...
/var/folders/4d/_j28yxlj4bn9p6zlgn4gr2m40000gn/T/tmpjx4dKe/wac5ed9f9-0452-449d-8072-3ab6
Traceback (most recent call last):
  File "/Users/jhamrick/miniconda3/envs/wallace/bin/wallace", line 9, in <module>
    load_entry_point('wallace', 'console_scripts', 'wallace')()
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 716, in __call__
    return self.main(*args, **kwargs)
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 696, in main
    rv = self.invoke(ctx)
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 889, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 534, in invoke
    return callback(*args, **kwargs)
  File "/Users/jhamrick/project/research/wallace/wallace/command_line.py", line 234, in debug
    db.init_db(drop_all=True)
  File "/Users/jhamrick/project/research/wallace/wallace/db.py", line 68, in init_db
    Base.metadata.drop_all(bind=engine)
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/schema.py", line 2875, in drop_all
    tables=tables)
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1478, in _run_visitor
    with self._optional_conn_ctx_manager(connection) as conn:
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1471, in _optional_conn_ctx_manager
    with self.contextual_connect() as conn:
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1661, in contextual_connect
    self.pool.connect(),
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 272, in connect
    return _ConnectionFairy(self).checkout()
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 431, in __init__
    rec = self._connection_record = pool._do_get()
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 788, in _do_get
    con = self._create_connection()
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 225, in _create_connection
    return _ConnectionRecord(self)
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 318, in __init__
    self.connection = self.__connect()
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 379, in __connect
    connection = self.__pool._creator()
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/strategies.py", line 80, in connect
    return dialect.connect(*cargs, **cparams)
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 283, in connect
    return self.dbapi.connect(*cargs, **cparams)
  File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/psycopg2/__init__.py", line 164, in connect
    conn = _connect(dsn, connection_factory=connection_factory, async=async)
sqlalchemy.exc.OperationalError: (OperationalError) FATAL:  database "wallace" does not exist
 None None

I guess the solution to the second one is to first run:
psql -c 'create database wallace;' -U postgres

This should be added to the documentation as well.

Yeah, we're missing the step of creating the database the first time. I
wish this could be done automatically, creating he db instead of giving
that error. Do you know a way?
On Sat, Aug 6, 2016 at 10:50 AM Jessica B. Hamrick<EMAIL_ADDRESS>wrote:

If I follow the instructions that are in the "installation" documentation
instead, I get a different error:
$ cd examples/bartlett1932/
$ wallace debug
 _    _    __    __    __      __    ___  ____
( \/\/ )  /__\  (  )  (  )    /__\  / __)( ___)
 )    (  /(__)\  )(__  )(__  /(__)\ |(__  )__)
(__/\__)(__)(__)(____)(____)(__)(__)\___)(____)

         a platform for experimental evolution.

❯❯ Verifying that directory is compatible with Wallace...
❯❯ Running as experiment wac5ed9f9-0452-449d-8072-3ab6...
/var/folders/4d/_j28yxlj4bn9p6zlgn4gr2m40000gn/T/tmpjx4dKe/wac5ed9f9-0452-449d-8072-3ab6
Traceback (most recent call last):
File "/Users/jhamrick/miniconda3/envs/wallace/bin/wallace", line 9, in
load_entry_point('wallace', 'console_scripts', 'wallace')()
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 716, in call
return self.main(*args, **kwargs)
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 696, in main
rv = self.invoke(ctx)
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 1060, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 889, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/click/core.py", line 534, in invoke
return callback(*args, **kwargs)
File "/Users/jhamrick/project/research/wallace/wallace/command_line.py", line 234, in debug
db.init_db(drop_all=True)
File "/Users/jhamrick/project/research/wallace/wallace/db.py", line 68, in init_db
Base.metadata.drop_all(bind=engine)
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/schema.py", line 2875, in drop_all
tables=tables)
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1478, in _run_visitor
with self._optional_conn_ctx_manager(connection) as conn:
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/contextlib.py", line 17, in enter
return self.gen.next()
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1471, in _optional_conn_ctx_manager
with self.contextual_connect() as conn:
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1661, in contextual_connect
self.pool.connect(),
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 272, in connect
return _ConnectionFairy(self).checkout()
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 431, in init
rec = self._connection_record = pool._do_get()
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 788, in _do_get
con = self._create_connection()
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 225, in _create_connection
return _ConnectionRecord(self)
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 318, in init
self.connection = self.__connect()
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/pool.py", line 379, in __connect
connection = self.__pool._creator()
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/strategies.py", line 80, in connect
return dialect.connect(*cargs, **cparams)
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 283, in connect
return self.dbapi.connect(*cargs, **cparams)
File "/Users/jhamrick/miniconda3/envs/wallace/lib/python2.7/site-packages/psycopg2/init.py", line 164, in connect
conn = _connect(dsn, connection_factory=connection_factory, async=async)
sqlalchemy.exc.OperationalError: (OperationalError) FATAL:  database "wallace" does not exist
None None
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/berkeley-cocosci/Wallace/issues/412#issuecomment-238027008,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAleXXn_R-MdAGTSSdh17mLNrD1Umfykks5qdJ82gaJpZM4JeSv8
.

You could have it check if the database exists, and if it doesn't, just shell out to subprocess to create it. Or is there a reason that wouldn't work?

This issue was moved to Dallinger/Dallinger#145


Add libodbc1 to Dockerfile for MSSQL support

See https://github.com/Senzing/stream-loader/issues/298

Pull Requests:

https://github.com/Senzing/senzing-poc-server/pull/47


Vscode does not render \n , \t characters

VSCode Version: 1.45.0
OS Version: Windows 10 / 10.0.18363

Steps to Reproduce:

Launch VS code
Install XDebug or try to debug anything that outputs \n or \t

This was working the last time I tried to debug on a project

Does this issue occur when all extensions are disabled?: Yes

Please file this against your debug extension.
More details why vscode is no longer escaping whitespace can be found here https://github.com/microsoft/vscode/issues/73845

Hey @isidorn, just spoke with the xDebug guys and the do not escape anything, seems like a vscode thing, they just send it as base64 encrypted


Fix handling of cursor position reports in passthrough mode

Summary of the Pull Request
When the conpty passthrough mode is enabled, it often needs to send DSR-CPR queries (cursor position reports) to the client terminal to obtain the current cursor position. However, the code that originally handled the responses to these queries got broken by the refactoring of the ConGetSet API. This PR is an attempt to correct that regression.
References
The conpty passthrough mode was introduced in PR #11264.
The refactoring that broke the cursor position handling was in PR #12703.
PR Checklist

[x] Closes #13106
[x] CLA signed.
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
Prior to the ConGetSet refactoring, the code that handled DSR-CPR responses (InteractDispatch::MoveCursor) would pass the cursor position to ConGetSet::SetCursorPosition, which in turn would forward it to the SetConsoleCursorPositionImpl API, and from there to the VtIo class.
After the refactor, all of those intermediate steps were removed - the cursor was simply updated directly in InteractDispatch::MoveCursor, and the VtIo call was moved from SetConsoleCursorPositionImpl to InteractDispatch (since that was the only place it was actually required).
However, when the conpty passthrough mode was introduced - which happened in parallel - it relied on the SetConsoleCursorPositionImpl API being called from InteractDispatch in order to handle its own DSR-CPR responses, and that's why things stopped working when the two PRs merged.
So what I've done now is made InteractDispatch::MoveCursor method call SetConsoleCursorPositionImpl again (although without the intermediate ConGetSet overhead), and moved the VtIo::SetCursorPosition call back into SetConsoleCursorPositionImpl.
This is not ideal, and there are still a bunch of problems with the DSR-CPR handling in passthrough mode, but it's at least as good as it was before.
Validation Steps Performed
I've just manually tested various shells with passthrough mode enabled, and confirmed that they're working better now. There are still issues, but nothing that wasn't already a problem in the initial implementation, at least as far as I can tell.

I had thought I might be able to fix some of the other problems with the CPR handling as part of this PR, but it turns out that's more complicated than I thought, so I'm just sticking with this basic patch for now.


Merge 'grpc_base' and 'grpc_base_c' targets in BUILD file

We think these were created as a trial balloon for the conversion from C to C++ - regardless, they don't seem to serve much purpose other than complicate the build, so let's merge them.

Crag, just to be sure, do you plan to do it? or just open up the issue?

Right now I'm just opening the issue... no plan to do it yet.


How could I display all data in xExtents range?

Like the intraday data, I just want to fix the x range to 9:00AM to 4:00PM, disable zoom/pan and only update the data to the end of the line.
By default it's only part of the data got displayed.

For example, the us stock market's trading hours is 9:30 - 16:00, I want the xAxis fixed with 9:30 to 16:00 without zoom or pan.

Did u know the solution bro? I also want to do that :D

Did u know the solution bro? I also want to do that :D

Please add this as props for ChartCanvas component plotFull

Please add this as props for ChartCanvas component plotFull


Open URL from "LU" extra

Hello!
I got this set up and working - I get the "LU" extra, when the response is NOT_LICENSED, but I don't know all the steps I need to take to actually open the url from inside my app.
This part is not covered in the example app and I have trouble getting this to work.
Cheers, Jan

Hi @v01pe, can you share what you did to get the project working? I build it with my live game's package name, and enter the public key in the m_PublicKey_Base64 variable in CheckLVLButton.cs.
I receive either a 0 or 1 response code, and then the package name response is "" and no other values come back.
Thank you,
Aaron

Hi Aaron!
Sorry, didn't see this earlier, but I saw you closed the issue, so I guess you found your solution, right?
Cheers,
Jan

On 25.03.2019, at 19:27, infosekr<EMAIL_ADDRESS>wrote:
Hi @v01pe https://github.com/v01pe, can you share what you did to get the project working? I build it with my live game's package name, and enter the public key in the m_PublicKey_Base64 variable in CheckLVLButton.cs.
I receive either a 0 or 1 response code, and then the package name response is "" and no other values come back.
Thank you,
Aaron
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Unity-Technologies/GooglePlayLicenseVerification/issues/8#issuecomment-476322573, or mute the thread https://github.com/notifications/unsubscribe-auth/AEUZIOQw7-mW3v-MsZjTTbWZ7WckGlhpks5vaRUJgaJpZM4b-5fQ.

Hi Jan,
Thank you for the reply. I did find the solution to my problem. The example app does not return a valid response if a test response is not set on the Google Play Console. Once I set a test response then the example app worked as expected.
Can you just use Unity's Application.OpenURL(url) to display the LU page if the license has expired and also the grace period is over?
Thanks,
Aaron

The recommended way by Google to open a licensing URL is this one:
using (var unityPlayer = new AndroidJavaClass("com.unity3d.player.UnityPlayer"))
    using (var activity = unityPlayer.GetStatic<AndroidJavaObject>("currentActivity"))
        using (var uriClass = new AndroidJavaClass("android.net.Uri"))
            using (var uri = uriClass.CallStatic<AndroidJavaObject>("parse", url))
                using (var paywallIntent = new AndroidJavaObject("android.content.Intent", "android.intent.action.VIEW", uri))
                    using (paywallIntent.Call<AndroidJavaObject>("setPackage", "com.android.vending")) {
                        activity.Call("startActivity", paywallIntent);
                    }


add deprecated gis classes

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

[ ] My pull request follows the guidelines in the Contributing guide?
[ ] My pull request does not duplicate any other open Pull Requests for the same update/change?
[ ] My commits are related to the pull request and do not amend unrelated code or documentation.
[ ] My code follows a similar style to existing code.
[ ] I have added appropriate tests.
[ ] I have updated or added relevant documentation.

References

Deprecated classes are needed to receive layers with speckle_type "VectorLayer" or "RasterLayer" such as https://speckle.xyz/streams/17b0b76d13/commits/6cd770c4f4
Otherwise, the layer is treated as Base


Implement std::error::Error for all error types

Fixes https://github.com/graphql-rust/juniper/issues/415

[x] GraphQLError
[x] ParseError
[x] LexerError
[x] RuleError
[x] FieldError

I'm having some issues with FieldError. I end up hitting a conflicting implementation error when I add
impl<S> std::error::Error for FieldError<S> {}

impl<S> fmt::Display for FieldError<S> {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        unimplemented!()
    }
}

I get this error:
error[E0119]: conflicting implementations of trait `std::convert::From<executor::FieldError<_>>` for type `executor::FieldError<_>`:
   --> juniper/src/executor/mod.rs:142:1
    |
142 | / impl<T: Display, S> From<T> for FieldError<S>
143 | | where
144 | |     S: crate::value::ScalarValue,
145 | | {
...   |
151 | |     }
152 | | }
    | |_^
    |
    = note: conflicting implementation in crate `core`:
            - impl<T> std::convert::From<T> for T;

I'm not quite sure what is causing that.

I'm not quite sure what is causing that.

Since FieldError has a From<T: Display> impl, if it implements Display itself the compiler can't resolve that cyclical relationship.
Not sure what's the best way around that, I'll have a look at the code.

I never was a big fan of the From T: Display impl to be honest.
We could think about removing it, and only having a From T: Error impl.
We can still have a manual constructor like FieldError::from_str.

@theduke I like that. Since thats a breaking change do we have to go through a round of deprecation or is it fine?

Nah let's batch it together with the other changes related to async/await and removing the old macros.
What's the status here, did you implement the FieldError?

I had totally forgotten about this. I'll give it another look soon.

Sorry for the delay but this should be ready for next review.
I had to make a few changes to get impl std::error::Error for FieldError working. They're outlined in the commit message.

Codecov Report

Merging #419 into master will increase coverage by 0.08%.
The diff coverage is 75.23%.

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   85.74%   85.82%   +0.08%
==========================================
  Files         110      108       -2
  Lines       15933    15572     -361
==========================================
- Hits        13661    13365     -296
+ Misses       2272     2207      -65

Impacted Files
Coverage Δ

juniper/src/parser/parser.rs
78.26% <ø> (ø)
:arrow_up:

juniper/src/parser/lexer.rs
90.09% <ø> (ø)
:arrow_up:

juniper/src/validation/context.rs
84.78% <0%> (-5.92%)
:arrow_down:

juniper/src/lib.rs
57.77% <0%> (-26.1%)
:arrow_down:

juniper/src/parser/utils.rs
90% <0%> (-7.3%)
:arrow_down:

juniper/src/value/mod.rs
91.35% <100%> (+5.76%)
:arrow_up:

juniper/src/executor/mod.rs
91.61% <100%> (+0.07%)
:arrow_up:

juniper/src/http/playground.rs
0% <0%> (-25%)
:arrow_down:

juniper_hyper/src/lib.rs

juniper_rocket/src/lib.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a9752...30e9c00. Read the comment docs.

This seems to be missing a From<E: std::error::Error> impl right now?
We need that more than a the From<String/&str> / variants.

I did try adding From<E: std::error::Error> but unfortunately it gives the same error:
error[E0119]: conflicting implementations of trait `std::convert::From<executor::FieldError<_>>` for type `executor::FieldError<_>`:
   --> juniper/src/executor/mod.rs:182:1
    |
182 | / impl<S, E> From<E> for FieldError<S>
183 | | where
184 | |     S: crate::value::ScalarValue,
185 | |     E: std::error::Error,
...   |
189 | |     }
190 | | }
    | |_^
    |
    = note: conflicting implementation in crate `core`:
            - impl<T> std::convert::From<T> for T;

It seems that you cannot both implement Display and From<T> where T: Error.
use std::fmt::{Formatter, self, Display};

#[derive(Debug)]
struct MyError(String);

impl std::error::Error for MyError {}

impl Display for MyError {
    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
        unimplemented!()
    }
}

impl<T: std::error::Error> From<T> for MyError {
    fn from(s: T) -> Self {
        unimplemented!()
    }
}

That fails to compile with the same error.
That is why I added
pub fn from_error<E>(error: E) -> FieldError<S>
where
    E: std::error::Error,
{
    FieldError::from(error.to_string())
}

Was the only working solution I could think of.

Does it make sense to not implement std::error::Error for FieldError because of this? I’m thinking it’s pretty inconvenient 🤔

Ah yeah I forgot about the coherence rules. You cant both implement Error and From<Error> without specialization...
Yeah let's just drop the impl on FieldError. It doesn't really matter anyway since it is not a type users work with directly.

Alright cool. I’ll revert it tomorrow.
Does it make sense to keep the Display impl for Value?

I have brought back impl<T: Display, S> From<T> for FieldError<S> now.
Guess this should be good now 😊

I have some additional changes. Will push tomorrow.

@theduke Anything I can help out with?

@davidpdrsn Is there anything more to go in on this PR? juniper is the last holdout in my app before I can simply Box<dyn Error> then use ? like mad everywhere. The open change request looks like a pretty trivial message change.

@jkoudys No it should be good to go. I wonder which error you're having to convert into Box<dyn Error>? I haven't run into such issues with the juniper version that is out now.
Also note that as per the discussions above you wont be able to convertFieldError into Box<dyn Error>. That shouldn't be an issue in practice however.

@jkoudys No it should be good to go. I wonder which error you're having to convert into Box<dyn Error>? I haven't run into such issues with the juniper version that is out now.

Trying to into a Box<dyn Error> using the ?, but erroring on ^ the trait std::error::Erroris not implemented forjuniper::GraphQLError<'_>`` because GraphQLError doesn't impl Error. I'm on the async-await branch, so that may need to be rebased.

@theduke @LegNeato This has been done for quite some time as you can see someone is asking for it 😊 Do you have any last minute things I should correct before merging? I might also try to get it merged into the async/await branch afterwards.

@andy128k you mean like on the GraphQLError itself, to give a simple mapping back to the original error type? e.g.
impl<'a> std::error::Error for GraphQLError<'a> {
    fn source(&self) -> Option<&(dyn Error + 'a)> {
        Some(&self)
    }
}

Can't think what else we'd need, unless you mean sources on e.g. ParserError could return a LexerError or something.
At any rate, does this really need to go in before accepting the PR? It's been done but sitting in limbo for such a long time. Juniper is the one holdout we have that's keeping us from having an easy time managing only Errors that impl std:error::Error.
It's been 4 months....

@LegNeato master still doesn't build due to some async stuff it seems. Should I merge this into the async branch instead?

Everything on master except the book builds / passes?

If I clone a fresh copy of the repo and run cargo test on nightly I get a bunch of errors like these:
error[E0432]: unresolved import `futures`
  --> integration_tests/juniper_tests/src/codegen/derive_enum.rs:10:10
   |
10 | #[derive(juniper::GraphQLEnum, Debug, PartialEq)]
   |          ^^^^^^^^^^^^^^^^^^^^ use of undeclared type or module `futures`

error[E0432]: unresolved import `futures`
  --> integration_tests/juniper_tests/src/codegen/derive_enum.rs:19:10
   |
19 | #[derive(juniper::GraphQLEnum)]
   |          ^^^^^^^^^^^^^^^^^^^^ use of undeclared type or module `futures`

error[E0432]: unresolved import `futures`
  --> integration_tests/juniper_tests/src/codegen/derive_enum.rs:29:10
   |
29 | #[derive(juniper::GraphQLEnum, Debug, PartialEq)]
   |          ^^^^^^^^^^^^^^^^^^^^ use of undeclared type or module `futures`

error[E0432]: unresolved import `futures`
  --> integration_tests/juniper_tests/src/codegen/derive_enum.rs:37:10
   |
37 | #[derive(juniper::GraphQLEnum, Debug, PartialEq)]
   |          ^^^^^^^^^^^^^^^^^^^^ use of undeclared type or module `futures`

error[E0432]: unresolved import `futures`
  --> integration_tests/juniper_tests/src/codegen/derive_object.rs:13:10
   |
13 | #[derive(GraphQLObject, Debug, PartialEq)]
   |          ^^^^^^^^^^^^^ use of undeclared type or module `futures`

error[E0432]: unresolved import `futures`
  --> integration_tests/juniper_tests/src/codegen/derive_object.rs:29:10
   |
29 | #[derive(GraphQLObject, Debug, PartialEq)]
   |          ^^^^^^^^^^^^^ use of undeclared type or module `futures`

error[E0432]: unresolved import `futures`
  --> integration_tests/juniper_tests/src/codegen/derive_object.rs:38:10

@davidpdrsn yeah weirdly just doing cargo test doesn't work for integration tests. Haven't looked into it yet. In any case, you can see the non-Github CI is all passing (Github CI failures are https://github.com/graphql-rust/juniper/issues/531.

Thanks for merging!


Reflect backend state in UI

It would be extremely helpful for monitoring if both the UI and /api endpoint could reflect the status of a backend, e.g. a background color change after a CB triggers.

Hi @jdorothy, this would be great indeed :) But would require first to add health checks in Traefik.

I think that for right now, you could simply return whether the CB for that backend is currently triggered.  But I agree, if you take #181 into account then health checks make more sense long-term.

Close in favor of  #1783 - Feel free to subscribe there for updates.


Enable division and bit manipulation extensions in benchmarks

Blocked until the new image is in the package registry.
Fixes #613.
I ran the benchmarks here: https://github.com/xThaid/coreblocks/actions/runs/8239973106/job/22534443637

The source of the riscv-arch-test test failure is actually in the building workflow:
 /__w/coreblocks/coreblocks/test/external/riscof/riscv-arch-test/riscv-test-suite/rv32i_m/I/src/jalr-01.S:72: Error: illegal operands `la x0,5b'

This looks unexpected.

I updated the toolchain, because I was getting errors when tried to compile the toolchain with Zb* extensions.

It's pretty nice that the benchmark job now runs in 14 minutes instead of 16-17.

I reported the jalr test problem to riscv-arch-tests https://github.com/riscv-non-isa/riscv-arch-test/issues/444
cause in binutils: https://github.com/bminor/binutils-gdb/commit/27b33966b18ed8bf1701a60999448224b1d28273


Don't show editScalingRange on another ScaleItem if a draft item already exists

Fix an issue where editScalingRange was showing up on other revision items even when a draft node already existed.  In my opinion, it's confusing / doesn't make sense to allow users to try editing other revisions simultaneously when another draft already exists.

An alternative to this method is to keep showing the command, but throw an error when they try to edit another scale item that isn't the current draft.
My thoughts on why this might be less confusing is because sometimes users don't understand/remember why commands mysteriously disappeared on them. By having the error, it will remind the user that "oh, hey, I do have a current working draft"

I'm okay with either approach, just wanted to hear thoughts

Yeah hmm, let me think on this one a bit.  I think I initially wanted to do it that way as well but for some reason I decided against it.  I'll get back to you

Couldn't remember a good reason not to do it the way you mentioned, I think it's a better solution as well because it's simpler for us to understand and now we can use these utility functions to easily add the same checks to other template items


Error Compiling the solution

while compiling
. VS 2017
. GIT for windows is installed

Severity
Code
Description
Project
File
Line
Suppression State

Error

The command "chmod +x """ exited with code 9009.
OpenBullet

after i close and re-open the VS, and try to build again
it is successful but it has the warning from last time
**1>------ Build started: Project: OpenBullet, Configuration: Debug Any CPU ------
2>------ Build started: Project: OpenBulletCLI, Configuration: Debug Any CPU ------
2>  OpenBulletCLI -> C:\Users<USER>\source\repos\openbullet\OpenBulletCLI\bin\Debug\OpenBulletCLI.exe
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(2110,5): warning MSB3277: Found conflicts between different versions of "System.Net.Http" that could not be resolved.  These reference conflicts are listed in the build log when log verbosity is set to detailed.
1>  OpenBullet -> C:\Users<USER>\source\repos\openbullet\OpenBullet\bin\Debug\OpenBullet.exe
========== Build: 2 succeeded, 0 failed, 1 up-to-date, 0 skipped ==========
**

when i try to run the .exe, i am having this

i dont know weather to add that .ini from the compiled version or i should find somewhere

Well first of all Clone the official Extreme.Net repository then compile it and you will get Extreme.Net.dll
After that clone OpenBullet repo and Right click in each of the three projects  then ==> Add ==> Reference ==> Browse for the Extreme.Net.dll if you get that done correctly it should work fine

Sometimes you get that error when compiling, just switch the build mode from Debug to Release or vice versa and compile, and then switch back to Release, it will work. Also it should automatically generate a default Environment.ini file the moment you compile the solution.

but it is not generating the Environment.ini file