TypeError: Cannot read property 'call' of undefined

I have a kind of critical bug with "modern" build mode (not in dev, not in non modern mode).
TypeError: Cannot read property 'call' of undefined
at r (3a431c40f1ac84aab470-app.js:formatted:41)
at Object.693 (5e2083c4.js:1)
at r (3a431c40f1ac84aab470-app.js:formatted:41)
at Object.853 (0d43857a.js:1)
at r (3a431c40f1ac84aab470-app.js:formatted:41)
at Object.607 (288dc8e0.js:1)
at r (3a431c40f1ac84aab470-app.js:formatted:41)
at Module.1003 (index.js:1)
at r (3a431c40f1ac84aab470-app.js:formatted:41)
at async http:/localhost.at:3000/website/_assets/70df557e5c5f4faf5bbc-app.js:2
it seems it loads the legacly build version at one point,
at Object.693 (5e2083c4.js:1)
which is: _assets/legacy-3aa82e6f50e494e1c6cd-node_modules/5e2083c4.js
and then it tries to load a file that actually exists, but somehow didn't make it into the webpack "resolver".

e[d] (d = 9)

is here, but probably due to the legacy vs modern mixup something fails then.
here element 9 is missing

Versions

nuxt: v2.14.1
node: v12.18.3

Reproduction
Pretty hard to track down right now
What is Expected?
shouldn't fail with modern mode, it only happens when build mode modern is set.
What is actually happening?
it fails to load a javascript file and the whole site stops working.

Not sure if relevant, but if I inspect the array of "e", there are mainly "modern" assets, but "693" (the point where it loasd the legacy file) is pointing to the legacy version. Are there any valid reasons that a legacy version is loaded? E.g. if there is no difference between a modern build?

It breaks here:
// EXTERNAL MODULE<EMAIL_ADDRESS>var classCallCheck = webpack_require(9);
and the really werid thing: only on desktop version, not on mobile. Super strange, how can this be related at all? (Guess maybe somethign isn't loaded on mobile which causes the issue, but not quite sure yet)

Hi. Asset names seem not matching 2.14. Are you using custom Chunk names? And any reproduce repo || URL?

hi @pi0, thanks for looking into it,
I have set custom filenames, but i removed this settings for now to track it down, doesn't change anything.
My setting was
	this.options.build.filenames = {
		...this.options.build.filenames,
		app: ({ isModern, isDev }) =>
			`${!isModern ? 'legacy-' : ''}${!isDev ? '[contenthash]' : '[name]'}-app.js`,
		chunk: ({ isModern, isDev }) =>
			`${!isModern ? 'legacy-' : ''}${!isDev ? '[contenthash]-' : ''}[name].js`
	};

Debug build is up and runnign at http://3d45e0f594df.ngrok.io/jobs
Current learnings:

It works in mobile mode -> no idea why
It can load something else from bubel/runtime, right before, but the classCallCheck.js fails

Its loaded through a date fn helper function, which I don't understand why it actually needs this one dependency at all (And therefore believe it already loads a wrong file?)

Regarding my last point:
according to the comments in the file it should load
// EXTERNAL MODULE: ./node_modules/date-fns/esm/_lib/startOfUTCISOWeek/index.js
var startOfUTCISOWeek = __webpack_require__(693);

but it 693 is something else, it loads a compnent called HokSelect.vue instead.

    /***/
    693: /***/
    (function(module, __webpack_exports__, __webpack_require__) {

        "use strict";

        // CONCATENATED MODULE: ./node_modules/vue-loader/lib/loaders/templateLoader.js??vue-loader-options!./node_modules/vue-loader/lib??vue-loader-options!./node_modules/@hokify/shared-components/lib/components/HokSelect.vue?vue&type=template&id=4fc308f6&scoped=true&
        var render = function() {
            var _vm = this;

I'm stuck, my guess is that something seems to be mixed up with modern and legacy build. But I'm out of ideas how to track this down.
It should load id 693 from /website/_assets/node_modules/288dc8e0.f27f277.modern.js (the same file where the call of webpack_require(693) is happening, but it loads
but it loads 693 instead from /website/_assets/node_modules/5e2083c4.4f8e4af.js which is a completely differnt code. The chunks seem to be mixed up. Module 693 is not in installedModules. The webpack_require is the one from the "root", but the entry of 693 just points to a different function it seems.

/cc @clarkdo

I have one import to a component that is some times async and sometimes directly imported. I have changed it now that all occurences are imported async, and it seems this has somehow solved the issue. Still looking into it, not sure what is going on here though.

Hi @simllll , are you using ssr or spa mode? And what’s the modern mode are you using?
Can you send us the manifest files in your dist and also screenshot of the link and script tags in your broken page ?

Hi @clarkdo , thanks for your answer.
I'm using SSR, modern is set to "client".
manifest files:
Uploading dist.zip…
desktop:

<script nomodule src="/website/_assets/runtime.fa009b9.js" defer></script><script type="module" src="/website/_assets/runtime.3f02afd.modern.js" defer></script><script nomodule src="/website/_assets/40.c765e0f.js" defer></script><script type="module" src="/website/_assets/37.c2155fc.modern.js" defer></script><script nomodule src="/website/_assets/129.1dd27da.js" defer></script><script type="module" src="/website/_assets/126.7f1e543.modern.js" defer></script><script nomodule src="/website/_assets/30.86aeb8b.js" defer></script><script type="module" src="/website/_assets/288.16f3f35.modern.js" defer></script><script nomodule src="/website/_assets/130.be13865.js" defer></script><script type="module" src="/website/_assets/127.75b77f7.modern.js" defer></script><script nomodule src="/website/_assets/pages/jobs/index.f2a9af8.js" defer></script><script type="module" src="/website/_assets/pages/jobs/index.85d3d8e.modern.js" defer></script><script nomodule src="/website/_assets/node_modules/0d43857a.28504fe.js" defer></script><script type="module" src="/website/_assets/node_modules/0d43857a.cf4d41c.modern.js" defer></script><script nomodule src="/website/_assets/node_modules/288dc8e0.929319e.js" defer></script><script type="module" src="/website/_assets/node_modules/288dc8e0.f27f277.modern.js" defer></script><script nomodule src="/website/_assets/commons/62c6da1a.d8fb4f0.js" defer></script><script type="module" src="/website/_assets/commons/62c6da1a.de12725.modern.js" defer></script><script nomodule src="/website/_assets/pages/empty.8499b08.js" defer></script><script type="module" src="/website/_assets/pages/empty.4194d9e.modern.js" defer></script><script src="/website/_assets/node_modules/5e2083c4.4f8e4af.js" defer></script><script nomodule src="/website/_assets/42.bef11fd.js" defer></script><script type="module" src="/website/_assets/39.3b0d27a.modern.js" defer></script><script nomodule src="/website/_assets/278.fd24ac2.js" defer></script><script type="module" src="/website/_assets/274.0e6f0d0.modern.js" defer></script><script nomodule src="/website/_assets/14.9aaf416.js" defer></script><script type="module" src="/website/_assets/137.2902e3c.modern.js" defer></script><script nomodule src="/website/_assets/112.258d4b4.js" defer></script><script type="module" src="/website/_assets/11.cb95906.modern.js" defer></script><script nomodule src="/website/_assets/node_modules/commons.c1101f0.js" defer></script><script type="module" src="/website/_assets/node_modules/commons.b005655.modern.js" defer></script><script nomodule src="/website/_assets/app.2417406.js" defer></script><script type="module" src="/website/_assets/app.fa2606e.modern.js" defer></script>
mobile:

<script>!function(){var e=document,t=e.createElement("script");if(!("noModule"in t)&&"onbeforeload"in t){var n=!1;e.addEventListener("beforeload",function(e){if(e.target===t)n=!0;else if(!e.target.hasAttribute("nomodule")\|\|!n)return;e.preventDefault()},!0),t.type="module",t.src=".",e.head.appendChild(t),t.remove()}}();</script><script nomodule src="/website/_assets/runtime.fa009b9.js" defer></script><script type="module" src="/website/_assets/runtime.3f02afd.modern.js" defer></script><script nomodule src="/website/_assets/40.c765e0f.js" defer></script><script type="module" src="/website/_assets/37.c2155fc.modern.js" defer></script><script nomodule src="/website/_assets/129.1dd27da.js" defer></script><script type="module" src="/website/_assets/126.7f1e543.modern.js" defer></script><script nomodule src="/website/_assets/30.86aeb8b.js" defer></script><script type="module" src="/website/_assets/288.16f3f35.modern.js" defer></script><script nomodule src="/website/_assets/130.be13865.js" defer></script><script type="module" src="/website/_assets/127.75b77f7.modern.js" defer></script><script nomodule src="/website/_assets/pages/jobs/index.f2a9af8.js" defer></script><script type="module" src="/website/_assets/pages/jobs/index.85d3d8e.modern.js" defer></script><script nomodule src="/website/_assets/node_modules/0d43857a.28504fe.js" defer></script><script type="module" src="/website/_assets/node_modules/0d43857a.cf4d41c.modern.js" defer></script><script nomodule src="/website/_assets/node_modules/288dc8e0.929319e.js" defer></script><script type="module" src="/website/_assets/node_modules/288dc8e0.f27f277.modern.js" defer></script><script nomodule src="/website/_assets/commons/62c6da1a.d8fb4f0.js" defer></script><script type="module" src="/website/_assets/commons/62c6da1a.de12725.modern.js" defer></script><script nomodule src="/website/_assets/42.bef11fd.js" defer></script><script type="module" src="/website/_assets/39.3b0d27a.modern.js" defer></script><script nomodule src="/website/_assets/278.fd24ac2.js" defer></script><script type="module" src="/website/_assets/274.0e6f0d0.modern.js" defer></script><script nomodule src="/website/_assets/14.9aaf416.js" defer></script><script type="module" src="/website/_assets/137.2902e3c.modern.js" defer></script><script nomodule src="/website/_assets/112.258d4b4.js" defer></script><script type="module" src="/website/_assets/11.cb95906.modern.js" defer></script><script nomodule src="/website/_assets/node_modules/commons.c1101f0.js" defer></script><script type="module" src="/website/_assets/node_modules/commons.b005655.modern.js" defer></script><script nomodule src="/website/_assets/app.2417406.js" defer></script><script type="module" src="/website/_assets/app.fa2606e.modern.js" defer></script>
--
  | <script>window.addEventListener('load', function() { try{for(var nonCriticalCss=document.head.querySelectorAll("link[rel=stylesheet][media=none]"),i=0;i<nonCriticalCss.length;++i)nonCriticalCss[i].media="all"}catch(e){} })</script>

Thanks for the reporting information, I’ll take a look.
BTW, I suggest using server modern mode for SSR.

Unfortuantely our setup required client mode, as the web page is pre rendered in a warm cache. We already generating a version for mobile and a version for desktop, adding two more versions depending for each device ("modern" and "legacy") would need a lot of more ressources to fill and keep the cache fresh

From your information, I found

From your information, I found

When I change some specfic imports to async, I found a working solution (hacky though), but jsut checked the output in this situation then (the filenames are different here again with my specific setup):
<script nomodule src="/website/_assets/legacy-ba7a729375b1c859dd7b-app.js" defer></script><script type="module" src="/website/_assets/77c74d1469cb7f454e28-app.js" defer></script><script nomodule src="/website/_assets/legacy-88ac7487e35e949e3d72-pages/jobs/index.js" defer></script><script type="module" src="/website/_assets/f0d4bdeed546a8fa9663-pages/jobs/index.js" defer></script><script nomodule src="/website/_assets/legacy-2c7811a172afff8c6bf8-node_modules/0d43857a.js" defer></script><script type="module" src="/website/_assets/3abb1dc591b767ee0b2b-node_modules/0d43857a.js" defer></script><script nomodule src="/website/_assets/legacy-653b3056e44d5a749116-node_modules/288dc8e0.js" defer></script><script type="module" src="/website/_assets/b2fc2f85c568c6b1db7f-node_modules/288dc8e0.js" defer></script><script nomodule src="/website/_assets/legacy-183dca45315cf1c7b6cc-commons/62c6da1a.js" defer></script><script type="module" src="/website/_assets/d633932a25d845a51e42-commons/62c6da1a.js" defer></script><script nomodule src="/website/_assets/legacy-bfce6b2e40d22d445dae-pages/empty.js" defer></script><script type="module" src="/website/_assets/12bd90c4abb406a77f8c-pages/empty.js" defer></script><script src="/website/_assets/legacy-628a2edab1d8fc14b6cd-node_modules/5e2083c4.js" defer></script><script nomodule src="/website/_assets/legacy-316a95a407ef8012cc1c-node_modules/commons.js" defer></script><script type="module" src="/website/_assets/9565f2f1edecce6df008-node_modules/commons.js" defer></script><script nomodule src="/website/_assets/legacy-83681289f48116ce6529-app.js" defer></script><script type="module" src="/website/_assets/a63eb854b1bec9fe25ba-app.js" defer></script>
the interesting part is 5e2083c4.js again .. it also has no nomodule tag, so the issue actually still exists, probably just the order of script tags is different which makes it work somehow.

Can you please go to node_modules/@nuxt/vue-renderer/, search <script nomodule and add log to print noModuleTag + moduleTag before return  ?

@simllll I may know the reason of this bug now, 5e2083c4.4f8e4af.js is a special bundle which doesn't have corresponding modern bundle which may be because it's extracted into other common chunks as size is small or some other unknown reason.
Let's confirm my thought, if you can see 5e2083c4.4f8e4af.js in log with my above comment, can you try to change this and try if issue is fixed ?

// From
if (!modernJsFile) {
  return scriptTag
}
// To
if (!modernJsFile) {
  return scriptTag.replace('<script', `<script nomodule`)
}

Can you please go to node_modules/@nuxt/vue-renderer/, search <script nomodule and add log to print noModuleTag + moduleTag before return ?

noModuleTag + moduleTag                                17:50:23
noModuleTag + moduleTag                                          17:50:23
noModuleTag + moduleTag                                        17:50:23
noModuleTag + moduleTag                                         17:50:23
noModuleTag + moduleTag                                        17:50:23
noModuleTag + moduleTag                        17:50:23
noModuleTag + moduleTag    17:50:23
noModuleTag + moduleTag              17:50:23
noModuleTag + moduleTag                                            17:50:23
noModuleTag + moduleTag    17:50:23
noModuleTag + moduleTag                                         17:50:23
noModuleTag + moduleTag                                        17:50:23
noModuleTag + moduleTag                                        17:50:23
noModuleTag + moduleTag                                         17:50:23
noModuleTag + moduleTag                                         17:50:23
noModuleTag + moduleTag      17:50:23
noModuleTag + moduleTag                                        17:5

Alright, it's not in the output, but I guess that's what you mean, beacuse the return is done before.
I changed the return to your suggestion and IT WORKS!!! :partying_face: :partying_face: :partying_face:
I'm really impressed how fast you tackled this issue!
Thank you very very much!
I will try to patch this for now at my side and see if it still holds in production. But I assume so! Thank you very much again!

Can you elaborate why there are bundles that have a legacy file, but no a modern version? This kinda confuses me.

@simllll All thanks to the useful information you provided, I've opened a pr to fix this edge case, it should be released in next patch release after code review.
/cc @pi0

Can you elaborate why there are bundles that have a legacy file, but not a modern version? This kinda confuses me.

I think you can have a look at the content of that bundle and search which file is same content in modern bundle, if it's hard to read, you can disable terser and minimizer.
If that chunk is an async component and also imported synchrousely, webpack might bundle it into a common module if component is small in modern bundle and the parent comonent is also using that common module.

Some final comments from my side:
1.) I also applied the patch to my production deployment, it works perfectly!
2.) We had some issues in the past with different kind of includes (async vs direct/sync import mixed in different components), and I just tested reverting one related commit that solved an issue that we couldn't really explain in the past -> it seems this was the same root cause! This also works now as expected! Nice (y)
Thanks again, I'll close this.


Multitenant support for CosmosDB

How to approach multi-tenant Database in CosmosDB?
Should I declare partition key as tenant key?  Right now there is default Partition Key like ResourceType_ResourceId, so is there a way to achieve multi-tenant in CosmosDB

You do not want to use the partition key as the tenant id.  The partition key is used to distribute resources across Cosmos DB partitions, and it is currently the resource id in order to distribute resource across partitions evenly.
If you want to have a multi-tenant FHIR server you will need to manage the tenant ids yourself somewhere, and then add those values to the resources so you can filter the results for the currently calling tenant.  One possible suggestion is to use the Meta element which is on all resources.  It has two collections, tag and security.  Either could potentially store a tenant_id.  Another possibility would be to create your own FHIR extension and store the tenant id there.

Can you suggest changes in Fhir code to handle tenant_id condition

Can you suggest how to create FHIR extension or can you share the link for the same

Can you suggest how to create FHIR extension or can you share the link for the same

https://www.hl7.org/fhir/extensibility.html


[Issue]: Insufficient documentation on the repo tool and associated manifest.xml file

Problem Description
The top level README.md was altered in https://github.com/RadeonOpenCompute/ROCm/commit/1ae99c5e4bc77dd1dc4760eb29edfeb76c833229 to mention the manifest.xml file. However all it says is The default.xml file uses the repo Manifest format..
There should be a link to the specification of this format.
There should be a link to the repo tool.
Ubuntu 20 didn't package the repo tool, apparently because of python2 to python3 changes. There should be a link to the repo tool site explaining how to install the tool.
Operating System
N/A
CPU
N/A
GPU
N/A
ROCm Version
5.7.x
ROCm Component
Documentation
Steps to Reproduce
No response
Output of /opt/rocm/bin/rocminfo --support
Not applicable.

Hi @saadrahim and @amd-isparry, do we still need this ticket to be opened?  Thanks.

I have not seen any mention that the documentation has been improved, so there is no reason to close it yet, the documentation does need to be improved.

I will create an internal ticket to track any progress.

Hi @amd-isparry, the README.md file has since been updated and now provides information on how to install the repo tool.  Please see the excerpts below:
Installing the repo tool
The repo tool from Google allows you to manage multiple git repositories simultaneously. Run the following commands to install the repo tool:

mkdir -p ~/bin/
curl https://storage.googleapis.com/git-repo-downloads/repo > ~/bin/repo
chmod a+x ~/bin/repo

Information on how to use the tool to download the ROCm source code is also now present.
Downloading the ROCm source code
The following example shows how to use the repo tool to download the ROCm source code. If you choose a directory other than ~/bin/ to install the repo tool, you must use that chosen directory in the code as shown below:

mkdir -p ~/ROCm/
cd ~/ROCm/
~/bin/repo init -u http://github.com/ROCm/ROCm.git -b roc-6.0.x
~/bin/repo sync

I will close this ticket for now. If you feel these changes do not completely address the issue, please re-open this ticket. Thanks!


Upon startup, receive "Install error" on macOS Ventura (13.0 beta)

Install Error says We were unable to load KBFS Fuse kext...
my log id: faeed243c0a014d703edc01c

Good

I am also affected by this issue after update to MacOS X 13.0 official release.

Also having this issue after upgrading to macOS Ventura.
Log ID: 36a14ffecd9f22ffe14a301c

Same here
fb3e0d7f685676b089b38a1c


Update cck.md

The options to enter for --recover was not documented anywhere so I am adding this here.

Thanks! I reworded some things for clarity and added a warning on automating its usage. Feel free to comment if I lost some of your original intention.


CTD when hooking up logistical transporters to Refined Relocation buffers

Ran into this while testing for mod interactions. I don't have a callstack, since I only thought to report this after I had removed RR from my pack and purged my test instance, but I'll get one as soon as I finish my custom pack.
Repro Steps

Chest ---[transporter]---> Regular Buffer ---[relocator + filter module]----> Enrichment Chamber
With the Configurator, set the transporter attached to the chest to Export mode

Expected
Items go from chest, to regular buffer, to enrichment chamber
Actual
CTD, array index out of bounds exception with Mekanism in callstack
Notes
I had the RR filter module configured to only keep 2 iron ore inside the enrichment chamber. Not sure if that matters or not.
Refined Relocation is here: https://refinedrelocation.github.io/

Could you provide a log?

Sorry for the delay. I uh ... kinda forgot about this! I can get it to repro still using the latest versions of RR and Mek (downloaded from your site). I think it's actually the interaction between the Mek Transporter and the RR buffer only.

Chest (with items inside!) ---[transporter]---> RR Buffer
With the Configurator, set transporter to extract from the chest

Crash doesn't occur if the chest has no items inside it.
fml-client-latest log that has the callstack of the crash
fml-client-latest.txt
I've long scrapped my custom modpack, so this is just a minimal modlist with Waila, NEI, Mek, and RR installed.
The arrangement from the screenshot doesn't actually do anything, since the RR buffer needs another pipe attached to the other side for it to have something to pipe to (it's meant for connecting piping systems of different mods to each other). This is the minimum configuration I found that causes the crash though.
Let me know if you need more info from me, or want me to try anything else on my test instance.

I'm going to call this on RR's end, it seems like the block is returning a different inventory size value than the array of slots it returns on its side.  Thanks for looking into it!


multi-region topology section on two regions

I've sat on a few different customer calls where we get the question "Can I run 6 nodes in two regions?" This seems like something we should have docs on. It could be under our current multi-region topology section.

@jseldess assigning this to you since I think you are the latest writer to work on topology patterns. Feel free to re-assign.

2 regions is an anti-pattern that we mention here: https://www.cockroachlabs.com/docs/v20.2/topology-patterns#anti-patterns. We definitely need to surface this info better and more explicitly. Closing this in favor of https://github.com/cockroachdb/docs/issues/6651


setopt: DRY out repetitive calls to curl_{easy,multi}_setopt

Some of these calls had gotten a bit lengthy and there are a lot of them so factoring out some of the repetetive boilerplate seems worthwhile.

Codecov Report

Merging #87 (e4b4325) into master (239ebc0) will decrease coverage by 1.70%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   93.08%   91.37%   -1.71%
==========================================
  Files           5        5
  Lines         477      464      -13
==========================================
- Hits          444      424      -20
- Misses         33       40       +7

Impacted Files
Coverage Δ

src/Curl/Easy.jl
94.49% <97.22%> (-0.03%)
:arrow_down:

src/Curl/Curl.jl
100.00% <100.00%> (ø)

src/Curl/Multi.jl
95.76% <100.00%> (ø)

src/Curl/utils.jl
71.42% <0.00%> (-26.08%)
:arrow_down:

src/Downloads.jl
83.87% <0.00%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 239ebc0...e4b4325. Read the comment docs.

Codecov Report

Merging #87 (e4b4325) into master (239ebc0) will decrease coverage by 1.70%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   93.08%   91.37%   -1.71%
==========================================
  Files           5        5
  Lines         477      464      -13
==========================================
- Hits          444      424      -20
- Misses         33       40       +7

Impacted Files
Coverage Δ

src/Curl/Easy.jl
94.49% <97.22%> (-0.03%)
:arrow_down:

src/Curl/Curl.jl
100.00% <100.00%> (ø)

src/Curl/Multi.jl
95.76% <100.00%> (ø)

src/Curl/utils.jl
71.42% <0.00%> (-26.08%)
:arrow_down:

src/Downloads.jl
83.87% <0.00%> (-0.18%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 239ebc0...e4b4325. Read the comment docs.


File corrupted

LiteDB v4, some BSON corrupted in  collection.
How can i figure out what happened?
service.c.db.zip

Hi @hulucc, here your database recovery database
service.c-recovery.db.zip
You can recovery your datafile with current master branch version. Has an static method in LiteEngine to recovery data (and a sample in LiteDB.Demo project).
But, how this happened? How is your environment?

Maybe, it's a good way that creating a new data file, recreate the index and copy all collection items to the new file.It's much faster.

Hi, @mbdavid
Thank you for the information.
It happens on one of my client's computer, only once.
I don't think it can be reproduced...

Hi! With the objective of organizing our issues, we are closing old unsolved issues. Please check the latest version of LiteDB and open a new issue if your problem/question/suggestion still applies. Thanks!


MRG, MAINT: Improve memory usage

Reduces memory usage and run times of a few of our worst offenders. @drammock feel free to review/merge if you're happy.

Couldn't resist pushing a commit to cut down OPM, which is otherwise our slowest example (and also has not great memory usage)

brainstorm master 12 sec 1257 MB -> PR 8 sec 950 MB
OPM master 154 sec 800 MB -> PR 137 sec 1036 MB (I think this estimate must be off... also the thumbnail is fixed)
patterns master 6 sec 1150 MB -> PR 10 sec 1038 MB
cov whitening master 58 sec 1215 MB -> PR 65 sec 907 MB

In local testing the memory usage went down for all of these, maybe some CircleCI variability in the memory usage based on garbage collection? In any case, should hopefully be good.


Fix smart quotes in docs on publishTestResults in DotNetCoreCLIv2

Minor fix to the documentation for the publishTestResults in the dotnet test task, replacing the "smart quotes" with actual quotation marks.

Can you build the task with 'node make.js --task <>'. THis will auto-generate some files used for localization.

Hi @sachinma,
I got some errors when trying to run the script you suggested, but from reading the contributing documentation (which I probably should've done to begin with, but still), I found 'node make.js build --task DotNetCoreCLIV2' which seems to have generated the localisation files.
Hope that's right. :-)

Thanks for fixing this.


KAFKA-3138: 0.9.0 docs still say that log compaction doesn't work on compressed topics.

Log compaction is supported on compressed topics as of 0.9.0, so update the docs to reflect that.

The "Log Compaction Limitations" section now has a numbered list with only 1 item in it. Seems a little odd, but I wasn't sure what to do with that, so I didn't change that.

LGTM, thanks!


Mistake in ReadTheDocs generate_data function

pyod.utils.data.generate_data, it is said the next one about the 'behaviour' parameter: 'Behaviour of the returned datasets which can be either ‘old’ or ‘new’. Passing behaviour='new' returns “X_train, y_train, X_test, y_test”, while passing behaviour='old' returns “X_train, X_test, y_train, y_test”.'
I've check that it is in the wrong way and it should be 'Behaviour of the returned datasets which can be either ‘old’ or ‘new’. Passing behaviour='new' returns “X_train, X_test, y_train, y_test”, while passing behaviour='old' returns “X_train, y_train, X_test, y_test”.' as the returns are of the other behaviour.

+1 i also ran into this issue.

Thanks for notifying us! We just fixed the documentation :)


Problem with powerline symbol for column number

Hello,
I'm looking into a strange issue, my airline statusbar looks like this:

See that unrecognized unicode glyph?
I don't know where to look to fix it
I'm using nerd-fonts (as fontconfig fallback) and vim-devicons, but even disabling this plugin doesn't fix the problem, it seems that airline has hardcoded that char somewhere but I can't find it
I don't have problems displaying other glyphs and I have found what symbol to use:

but I don't know how
Any suggestion?

use a different font.

It still doesn't work,
I use Terminus as base font I tried changing but this problem doesn't disappear
Isn't that symbol configurable in airline?

this is my vimrc
set nocompatible              				" be iMproved, required
syntax on									" set syntax highlighting
filetype off                  				" disable filetype indent, required for Vundle to initialize
" Vundle Setup
set rtp+=~/.vim/bundle/Vundle.vim 			 " set the runtime path to include Vundle
call vundle#begin() 						 " initialize
											 " list of plugins to load
	Plugin 'gmarik/Vundle.vim' 				 " let Vundle manage Vundle, required
	Plugin 'terryma/vim-multiple-cursors'	 " Vim Multiple cursors

	Plugin 'scrooloose/nerdtree'			 " NERDTree

	Plugin 'ctrlpvim/ctrlp.vim'					 " Ctrl-P
	Plugin 'tpope/vim-surround'				 " Vim Surround
	"Plugin 'vim-scripts/simple-pairs'
	Plugin 'jiangmiao/auto-pairs'
	Plugin 'vim-airline/vim-airline'				 " Vim-Airline
	Plugin 'vim-airline/vim-airline-themes'	 " Vim-Airline Themes
	"Plugin 'saihoooooooo/glowshi-ft.vim'	 " f search motion highlight
	"Plugin 'edkolev/tmuxline.vim'			 " duplicate airline config in tmux
	Plugin 'nathanaelkane/vim-indent-guides' " indent guides
	Plugin 'miyakogi/conoline.vim'			 " highlight current editing line
	Plugin 'luochen1990/rainbow'			 " rainbow parentheses
	Plugin 'jnurmine/Zenburn'				 " Zenburn colorscheme
	"Python coding plugins
	Plugin 'nvie/vim-flake8'				 " PEP8 checking
	Plugin 'tmhedberg/SimpylFold'			 " Folding
	Plugin 'vim-scripts/indentpython.vim'    " Python autoindent
	"Plugin 'MarcWeber/vim-addon-mw-utils'
    "Plugin 'tomtom/tlib_vim'
    "Plugin 'garbas/vim-snipmate'
    "Plugin 'honza/vim-snippets'
    "Plugin 'ervandew/supertab'
    Plugin 'ryanoasis/vim-devicons'
    Plugin 'sunaku/vim-hicterm'             " Color Highlighter for vim
call vundle#end()            				 " required all of your Plugins must be added before the following line
filetype plugin indent on    				" set indent on plugin, required for Vundle

let g:zenburn_force_dark_Background = 1
set background=dark
colorscheme zenburn			" Default Color Scheme

set pastetoggle=<F2>						" Paste mode to disable auto-indenting while pasting text
set tabstop=4     							" a tab is four spaces
set expandtab								"
set backspace=indent,eol,start				" allow backspacing over everything in insert mode
set autoindent    							" always set autoindenting on
set copyindent    							" copy the previous indentation on autoindenting
set relativenumber        					" always show line numbers
set shiftwidth=4  							" number of spaces to use for autoindenting
set shiftround    							" use multiple of shiftwidth when indenting with '<' and '>'
set showmatch     							" set show matching parenthesis
set smarttab      							" insert tabs on the start of a line according to shiftwidth, not tabstop
set hlsearch      							" highlight search terms
set incsearch     							" show search matches as you type
set omnifunc=syntaxcomplete#Complete 		" activate autocomplete with <C-X><C-O>, navigate with <C-N> and <C-P>
set completeopt=longest,menuone				" inserts the longest common text of all matches; and the menu will come up even if there's only one match.
set mouse=a									" activate mouse support
set t_ut=									" disable Background Color Erase
set ruler
set ttyfast

" Disable Arrow keys in favor of hjkl
nnoremap <up> <nop>
nnoremap <down> <nop>
nnoremap <left> <nop>
nnoremap <right> <nop>
" Map Leader key to SpaceBar
let mapleader=" "

" Python setup
" Enable folding
set foldmethod=indent
set foldlevel=99
let python_highlight_all = 1
autocmd FileType python set omnifunc=pythoncomplete#Complete
autocmd FileType javascript set omnifunc=javascriptcomplete#CompleteJS
autocmd FileType html set omnifunc=htmlcomplete#CompleteTags
autocmd FileType css set omnifunc=csscomplete#CompleteCSS
autocmd FileType htmldjango.html let b:surround_{char2nr("v")} = "{{ \r }}"
autocmd FileType htmldjango.html let b:surround_{char2nr("{")} = "{{ \r }}"
autocmd FileType htmldjango.html let b:surround_{char2nr("%")} = "{% \r %}"
autocmd FileType htmldjango.html let b:surround_{char2nr("b")} = "{% block \1block name: \1 %}\r{% endblock \1\1 %}"
autocmd FileType htmldjango.html let b:surround_{char2nr("i")} = "{% if \1condition: \1 %}\r{% endif %}"
autocmd FileType htmldjango.html let b:surround_{char2nr("w")} = "{% with \1with: \1 %}\r{% endwith %}"
autocmd FileType htmldjango.html let b:surround_{char2nr("f")} = "{% for \1for loop: \1 %}\r{% endfor %}"
autocmd FileType htmldjango.html let b:surround_{char2nr("c")} = "{% comment %}\r{% endcomment %}"
au BufNewFile,BufRead *.html set filetype=htmldjango

"vim airline
set laststatus=2
let g:airline_powerline_fonts = 1
let g:bufferline_echo = 0
let g:airline#extensions#whitespace#enabled = 0 " turn off the whitespace extension
set noshowmode

  if !exists('g:airline_symbols')
    let g:airline_symbols = {}
  endif
" powerline symbols
  let g:airline_left_sep = ''
  let g:airline_left_alt_sep = ''
  let g:airline_right_sep = ''
  let g:airline_right_alt_sep = ''
  let g:airline_symbols.branch = ''
  let g:airline_symbols.readonly = ''
  let g:airline_symbols.linenr = ''
  let g:airline_symbols.columnr = ''

"tmuxline theme disable autoset via airline
let g:tmuxline_theme = 'zenburn'
let g:airline#extensions#tmuxline#enabled = 0

"Conoline setup
let g:conoline_auto_enable = 1
" Use theme colors in normal mode
let g:conoline_use_colorscheme_default_normal=1

"Indent Guides Dark Background
let g:indent_guides_auto_colors = 1
let g:indent_guides_enable_on_vim_startup = 1
"rainbow parentheses
let g:rainbow_active = 1 " 0 if you want to enable it later via :RainbowToggle

yes it is configurable. read the documentation

I've read the configuration, but it's only mentioned the linenr symbol, nothing about the columnnr symbol.
I've found this
let g:airline_section_z = airline#section#create(['windowswap', '%3p%% ', 'linenr', ':%3v'])
in the faq, the makes the glyph disappear, because it recreates the z_section but it's not clear what the command does, and I don't seem to be able to add the symbol, not a big deal, but I just don't understand how this works

search for maxlinenr

It's that!
damn I lost the entire afternoon searching for that, not very intuitive, I was looking for column reference instead of maxline (also in the docs this symbol is mentioned only in unicode symbols, not powerline ones)
well thanks, it was the last piece I was missing


Update move-support-resources.md for Microsoft.AzureArcData

Update resource move information for Microsoft.AzureArcData top level resources.
Resources:

Data controller
SQL Managed Instances
Postgres Instances
SQL Server instances

@mumian

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@charmainewkchan - thank you for your contribution.
#sign-off


Add support page to documentation

Thanks for contributing.
Please squash the two commits together (one cannot live without the other).

Merged thanks !


The authentication over the current SSH connection failed

I installed deployer via composer.
I also installed herzult/php-ssh.
My previous deploy strategy was using capifony, with a key to login on the remote server.
My deploy.php:
<?php

require 'recipe/symfony.php';
set('ssh_type', 'ext-ssh2');
server('stage1', 'full_address_of_my_server')
    ->user('my_user')
    ->stage('staging')
    ->env('deploy_path', '/home/my_user/test_deployer');
set('repository', 'git@bitbucket.org:company/repo.git');

When i try to execute bin/dep deploy:prepare staging I get the exception mentioned in the title (along with a strange message about POSIX compliance of my remote shell, that is a bash)

Look like bash does not available on your remove server. %)

I'm not sure to understand... I can ssh on my remote server and bash is there.
On my remote server:
$ echo $0
-bash

I have the same issue, but are using a servers.yml file with the following settings:;
production:
  host: localhost
  user: test-prod
  identity_file: ~
  stage: production
  deploy_path: /home/test-prod/production

But also get the "  The authentication over the current SSH connection failed.  "
Also using ext-ssh2
Any ideas?

@erickr
what is your ext-ssh version?
Are you try with phpseclib?

I'm using php5-ssh2 in debian jessie,
Package: php5-ssh2
New: yes
State: installed
Automatically installed: no
Version: 0.12-3
Priority: extra
Section: php
Maintainer: Debian PHP PECL Maintainers<EMAIL_ADDRESS>Architecture: i386
Uncompressed Size: 151 k
Depends: phpapi-20131226, php5-common (>= 4.0.0), php5-common (<= 6.0.0), php-pear (>= 1.4.0), libc6 (>= 2.4), libssh2-1 (>= 1.2.9)
Breaks: libssh2-php (< 0.12-2)
Replaces: libssh2-php (< 0.12-2)
Description: Bindings for the libssh2 library
Provides bindings to the functions of libssh2 which implements the SSH2 protocol.
Homepage: http://pecl.php.net/package/ssh2
I've tried with phpseclib as well, but it doest work either, that gives:
"Unable to login with the provided credentials."
Is it required to supply the path to the ssh keys or does it automatically check in ~/.ssh/ to find them?
Using commandline ssh works fine without any additional arguments, like: ssh test-prod@localhost for example.

It turned out I had added my dsa key to the authorized keys file of the target account, using an rsa key with set('ssh_type', 'ext-ssh2'); works correctly. Thanks!

I'm using a dsa key also. What's wrong with it?

@garak that didnt work for me at least, switching to a rsa-key made it work instantly as long as ssh_type was set to ext-ssh2.
Did you try that?

I don't know why DSA key does not work. But DSA key is 1024 bits. It is not secure today.

Sorry, I double checked and ny key is ECDSA, not DSA. Any hint?

@garak at least phpseclib seems to not handle dsa-keys at all if I read the code right:
https://github.com/deployphp/deployer/blob/49bfff673ae49b95029831d2038b924c4cfccb43/src/Server/Remote/PhpSecLib.php#L58-L66
So try a rsa-key.

@erickr you're right :disappointed:
See also https://github.com/phpseclib/phpseclib/issues/216


Full precision (fp32) support for ZeRO Stage2 and Stage3

🚀 Feature
Deepspeed v0.3.16 supports fp32 for ZeRO Stage2 and Stage3.
Is it possible to have it in pytorch-lightning?
Motivation
To train fp32 models with higher speed

@SeanNaren

I am also facing issues when I try to use mix precision. Please share a solution if it is possible

This is possible now in Lightning 1.4, just install the latest DeepSpeed and do not pass the precision=16 flag!


Dependency and Build Fixes

This is a potpourri of fixes.
Dependencies
Currently, we require very specific package versions for any install. This is too restrictive for a research package where researchers may have a variety of reasons to carefully tailor their environment. This PR resolves the issue by allowing general installation to have flexible packages. To maintain CI stability and functionality, the fixed version requirements have been moved to dev.
Build
We build our CPP extension using load instead of setup.py. This removes PyTorch as a dependency at install time and removes the need for us to distribute binaries. This required adding ninja as a dependency. Hopefully we can get rid of it eventually, but this temporarily should fix distribution.
CI testing
isort was misconfigured and missed a lot of import changes. I fixed the config and ran it on all files to update import sorting.
Other
While implementing this I also found a few other minor issues with respect to versioning, tests, and formatting that I resolved.
This PR makes NeuralCompression require Python 3.8 due to its usage of importlib.
Testing
Testing done via CI.

@QuentinDuval @0x00b1 any actionable requests on this PR? Otherwise I need one of you to approve so we can merge. It's not a perfect fix but I think it allows distribution.

@QuentinDuval @0x00b1 any actionable requests on this PR? Otherwise I need one of you to approve so we can merge. It's not a perfect fix but I think it allows distribution.

LGTM, I approved it :)

@mmuckley LGTM. I apologize for the delay. I wanted to read up on torch.utils.cpp_extension.load before approving.

No worries @0x00b1!


Fix for issue #2593

Fixes the failed test for patients/care-goals/CareGoalTab.test.tsx on Mac OSX.
Changes proposed in this pull request:
Increased timeout allowed for the failed test from 30000 ms to 50000 ms.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @jrmkim50 could you sign the CLA and create a commit using the semantic standard?
eg.
fix(test): timeout for caregoaltab test is 50000 ms
Thanks!


Fix mis-typing in README.md of UDP Service

Required for all non-trivial PRs

[X] Rebased/mergable
[X] Sign CLA (if not already signed)

Is there no response for this PR?


KH2.5 Demo Debug Documentation - Phase Two

That's enough crashing for me right now. Marking as ready for review.


Update external signer block signing integration test

PR Description
Update external signer block signing integration test. Use parameterized test for Bellatrix and Capella block signing.
Fixed Issue(s)

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

Are we planning on putting more tests in? i don't see why we'd do this restructuring currently...
i'd probably prefer its an abstract base class and we don't have to do data. everywhere like the AbstractDataBackedIntegrationTest  as a concrete example...

@rolfyone The primary intention is to use parameterized test for bellatrix, capella and onward specs for blocksigning.

Have a quick look at
  @ParameterizedTest
  @MethodSource("allNetworksWithAllMilestones")

And make sure, but I think you're better off not breaking all of that information out potentially...


I would like to be notified as soon as TensorRT supports ControlNet. Thank you.

+1

+1

+1

+1

+1

+1

TRT can support controlnet now?


Return the underlying images metadata

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #3874 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3874   +/-   ##
=======================================
  Coverage   42.34%   42.34%
=======================================
  Files         130      130
  Lines       14683    14683
=======================================
  Hits         6217     6217
  Misses       7540     7540
  Partials      926      926

Flag
Coverage Δ

#linux
45.76% <ø> (ø)
:arrow_up:

#windows
37.82% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed7ec4...6a22a8f. Read the comment docs.


JDK11 support

[x] Make CloudStack build against JDK11 (with -Dmaven.test.skip=true)
[x] Run mgmt server, deploy db, work against simulator
[x] Upgrade mvn dependencies
[x] Fix compatible dependency issue  #3660 #3671 #3672 #3673 #3674 #3675 #3676
[x] Fix/support JDK11 in systemvmtemplate (make it work)
[x] Fix docker container packaging images to have jdk11
[x] Use jdk11 compatible mysql-connector via maven, instead of distro-provided
[x] Fix failing tests and runtime issues against JDK11
[x] Ready for smoketest matrix and testing

This splits the Debian10 base/template changes to this PR https://github.com/apache/cloudstack/pull/3797
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

This is a good start!
In #3195 @GabrielBrascher and me are working on porting scripts to Python 3.
Inside the SSVM we have a lot of Python 2 code which needs to be looked at.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-366

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-367

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-368

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-369

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✖debian. JID-370

Unit test component/failures report: (-fn flag)
[INFO]
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [  0.688 s]
[INFO] Apache CloudStack .................................. SUCCESS [  0.892 s]
[INFO] Apache CloudStack Framework - Managed Context ...... SUCCESS [  3.738 s]
[INFO] Apache CloudStack Framework ........................ SUCCESS [  0.097 s]
[INFO] Apache CloudStack Framework - Certificate Authority  SUCCESS [  1.171 s]
[INFO] Apache CloudStack Utils ............................ SUCCESS [ 22.481 s]
[INFO] Apache CloudStack Framework - Database ............. SUCCESS [  8.837 s]
[INFO] Apache CloudStack Framework - Configuration ........ SUCCESS [  6.207 s]
[INFO] Apache CloudStack Framework - Direct Download to Primary Storage SUCCESS [  0.596 s]
[INFO] Apache CloudStack API .............................. FAILURE [ 19.732 s]
[INFO] Apache CloudStack Framework - REST ................. SUCCESS [  2.929 s]
[INFO] Apache CloudStack Framework - IPC .................. SUCCESS [  4.518 s]
[INFO] Apache CloudStack Cloud Engine ..................... SUCCESS [  0.033 s]
[INFO] Apache CloudStack Cloud Engine API ................. SUCCESS [  5.099 s]
[INFO] Apache CloudStack Cloud Engine Schema Component .... FAILURE [ 26.274 s]
[INFO] Apache CloudStack Framework - Security ............. SUCCESS [  1.917 s]
[INFO] Apache CloudStack Core ............................. SUCCESS [ 14.629 s]
[INFO] Apache CloudStack Agents ........................... FAILURE [  6.850 s]
[INFO] Apache CloudStack Framework - Clustering ........... SUCCESS [  5.255 s]
[INFO] Apache CloudStack Framework - Event Notification ... SUCCESS [  1.291 s]
[INFO] Apache CloudStack Framework - Jobs ................. SUCCESS [  4.874 s]
[INFO] Apache CloudStack Cloud Engine Internal Components API SUCCESS [  2.750 s]
[INFO] Apache CloudStack Agent Management Servers Load Balancer SUCCESS [  0.723 s]
[INFO] Apache CloudStack Framework - Storage Config Drive Component FAILURE [ 20.282 s]
[INFO] Apache CloudStack Server ........................... FAILURE [01:36 min]
[INFO] Apache CloudStack Framework - Quota ................ FAILURE [  6.353 s]
[INFO] Apache CloudStack Usage Server ..................... FAILURE [  7.758 s]
[INFO] Apache CloudStack Cloud Engine API ................. SUCCESS [  1.270 s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component SUCCESS [ 10.112 s]
[INFO] Apache CloudStack Cloud Services ................... SUCCESS [  0.027 s]
[INFO] Apache CloudStack Secondary Storage ................ SUCCESS [  0.030 s]
[INFO] Apache CloudStack Secondary Storage Service ........ FAILURE [ 10.823 s]
[INFO] Apache CloudStack Engine Storage Component ......... SUCCESS [  8.414 s]
[INFO] Apache CloudStack Cloud Engine Service ............. FAILURE [  0.753 s]
[INFO] Apache CloudStack Engine Storage Cache Component ... SUCCESS [  2.808 s]
[INFO] Apache CloudStack Engine Storage Image Component ... SUCCESS [  3.434 s]
[INFO] Apache CloudStack Engine Storage Volume Component .. SUCCESS [  5.326 s]
[INFO] Apache CloudStack Engine Storage Data Motion Component FAILURE [ 11.022 s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  FAILURE [ 14.673 s]
[INFO] Apache CloudStack Plugin POM ....................... SUCCESS [  0.449 s]
[INFO] Apache CloudStack Plugin - ACL Dynamic Role Based .. SUCCESS [  5.243 s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based ... SUCCESS [  1.634 s]
[INFO] Apache CloudStack Plugin - Explicit Dedication Processor SUCCESS [  2.341 s]
[INFO] Apache CloudStack Plugin - Host Affinity Processor . SUCCESS [  6.036 s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor SUCCESS [  1.828 s]
[INFO] Apache CloudStack Plugin - SNMP Alerts ............. SUCCESS [  4.797 s]
[INFO] Apache CloudStack Plugin - Syslog Alerts ........... SUCCESS [  4.194 s]
[INFO] Apache CloudStack Plugin - API Discovery ........... SUCCESS [  5.341 s]
[INFO] Apache CloudStack Plugin - API Rate Limit .......... SUCCESS [  7.391 s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider SUCCESS [  3.869 s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider SUCCESS [  5.097 s]
[INFO] Apache CloudStack Plugin - API SolidFire Integration Testing SUCCESS [  2.195 s]
[INFO] Apache CloudStack Plugin - Inbuilt Root Certificate Authority FAILURE [  6.976 s]
[INFO] Apache CloudStack Plugin - Quota Service ........... FAILURE [  7.103 s]
[INFO] Apache CloudStack Plugin - Dedicated Resources ..... FAILURE [  6.830 s]
[INFO] Apache CloudStack Plugin - Implicit Dedication Planner SUCCESS [  8.012 s]
[INFO] Apache CloudStack Plugin - User Concentrated Pod Deployment Planner SUCCESS [  1.753 s]
[INFO] Apache CloudStack Plugin - User Dispersing Deployment Planner SUCCESS [  1.816 s]
[INFO] Apache CloudStack Plugin - In Memory Event Bus ..... SUCCESS [  4.666 s]
[INFO] Apache CloudStack Plugin - Kafka Event Bus ......... SUCCESS [  1.508 s]
[INFO] Apache CloudStack Plugin - RabbitMQ Event Bus ...... SUCCESS [  2.599 s]
[INFO] Apache CloudStack Plugin - Skip Heurestics Planner . SUCCESS [  2.238 s]
[INFO] Apache CloudStack Plugin - Host Allocator Random ... SUCCESS [  2.234 s]
[INFO] Apache CloudStack Plugin - Hypervisor Baremetal .... SUCCESS [  4.140 s]
[INFO] Apache CloudStack Plugin - Hypervisor Hyper-V ...... SUCCESS [  6.171 s]
[INFO] Apache CloudStack Plugin - Open vSwitch ............ SUCCESS [  3.019 s]
[INFO] Apache CloudStack Plugin - Hypervisor KVM .......... FAILURE [ 27.600 s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM3 .... SUCCESS [  6.964 s]
[INFO] Apache CloudStack Plugin - Hypervisor OracleVM ..... SUCCESS [  2.528 s]
[INFO] Apache CloudStack Plugin - Hypervisor UCS .......... SUCCESS [  2.455 s]
[INFO] Apache CloudStack Plugin - Hypervisor XenServer .... FAILURE [01:10 min]
[INFO] Apache CloudStack Plugin - Cloudian Connector ...... SUCCESS [  8.675 s]
[INFO] Apache CloudStack Plugin - Prometheus Exporter ..... SUCCESS [  1.790 s]
[INFO] Apache CloudStack Plugin - Metrics ................. SUCCESS [  2.389 s]
[INFO] Apache CloudStack Plugin - BigSwitch Virtual Network Segment SUCCESS [  9.585 s]
[INFO] Apache CloudStack Plugin - Dns Notifier Example .... SUCCESS [  2.329 s]
[INFO] Apache CloudStack Plugin - Network Internal Load Balancer FAILURE [  9.469 s]
[INFO] Apache CloudStack Framework - Spring Life Cycle .... SUCCESS [  1.854 s]
[INFO] Apache CloudStack Plugin - Network Juniper Contrail  SUCCESS [ 16.217 s]
[INFO] Apache CloudStack Plugin - Network Elastic Load Balancer SUCCESS [  6.287 s]
[INFO] Apache CloudStack Plugin - GloboDNS ................ SUCCESS [  8.223 s]
[INFO] Apache CloudStack Plugin - Network Netscaler ....... SUCCESS [  3.819 s]
[INFO] Apache CloudStack Plugin - Network Nicira NVP ...... FAILURE [ 12.548 s]
[INFO] Apache CloudStack Plugin - Network Opendaylight .... SUCCESS [  5.791 s]
[INFO] Apache CloudStack Plugin - Palo Alto ............... SUCCESS [  6.841 s]
[INFO] Apache CloudStack Plugin - Stratosphere SSP ........ SUCCESS [  6.994 s]
[INFO] Apache CloudStack Plugin - Network Brocade VCS ..... SUCCESS [ 10.493 s]
[INFO] Apache CloudStack Plugin - Network VXLAN ........... SUCCESS [  6.432 s]
[INFO] Apache CloudStack Plugin - Power Management Driver ipmitool SUCCESS [  4.792 s]
[INFO] Apache CloudStack Plugin - Power Management Driver nested-cloudstack SUCCESS [  4.932 s]
[INFO] Apache CloudStack Plugin - Storage Image default provider SUCCESS [  2.251 s]
[INFO] Apache CloudStack Plugin - Storage Image S3 provider SUCCESS [  2.264 s]
[INFO] Apache CloudStack Plugin - Storage Image sample provider SUCCESS [  2.118 s]
[INFO] Apache CloudStack Plugin - Storage Image Swift provider SUCCESS [  2.156 s]
[INFO] Apache CloudStack Plugin - Storage Volume CloudByte Provider SUCCESS [  2.998 s]
[INFO] Apache CloudStack Plugin - Storage Volume Datera Provider SUCCESS [  3.260 s]
[INFO] Apache CloudStack Plugin - Storage Volume Nexenta Provider SUCCESS [  4.475 s]
[INFO] Apache CloudStack Plugin - Storage Volume sample provider SUCCESS [  1.964 s]
[INFO] Apache CloudStack Plugin - Storage Allocator Random  SUCCESS [  1.752 s]
[INFO] Apache CloudStack Plugin - User Authenticator LDAP . SUCCESS [  3.514 s]
[INFO] Apache CloudStack Plugin - User Authenticator MD5 .. SUCCESS [  4.963 s]
[INFO] Apache CloudStack Plugin - User Authenticator PBKDF2-SHA-256 SUCCESS [  5.639 s]
[INFO] Apache CloudStack Plugin - User Authenticator Plain Text SUCCESS [  1.490 s]
[INFO] Apache CloudStack Plugin - User Authenticator SAML2  FAILURE [ 23.701 s]
[INFO] Apache CloudStack Plugin - User Authenticator SHA256 Salted SUCCESS [  5.154 s]
[INFO] Apache CloudStack Plugin - F5 ...................... SUCCESS [  2.332 s]
[INFO] Apache CloudStack Plugin - Juniper SRX ............. SUCCESS [  3.088 s]
[INFO] Apache CloudStack VMware Base ...................... SUCCESS [ 14.989 s]
[INFO] Apache CloudStack Plugin - Hypervisor VMware ....... FAILURE [ 24.049 s]
[INFO] Apache CloudStack Plugin - Cisco VNMC .............. SUCCESS [  8.624 s]
[INFO] Apache CloudStack Plugin - API VMware SIOC ......... SUCCESS [  2.609 s]
[INFO] Apache CloudStack Plugin - MySQL HA Strategy ....... SUCCESS [  1.926 s]
[INFO] Apache CloudStack Plugin - Hypervisor Simulator .... SUCCESS [  4.289 s]
[INFO] Apache CloudStack Framework - Spring Module ........ SUCCESS [  5.418 s]
[INFO] Apache CloudStack Secondary Storage Controller ..... SUCCESS [  7.073 s]
[INFO] Apache CloudStack Console Proxy .................... SUCCESS [  0.029 s]
[INFO] Apache CloudStack Console Proxy - RDP Client ....... SUCCESS [ 12.783 s]
[INFO] Apache CloudStack Console Proxy - Server ........... SUCCESS [  5.229 s]
[INFO] Apache CloudStack System VM ........................ FAILURE [  1.219 s]
[INFO] Apache CloudStack Client UI ........................ FAILURE [  5.903 s]
[INFO] Apache CloudStack Framework - QuickCloud ........... SUCCESS [  0.085 s]
[INFO] Apache CloudStack Test ............................. SUCCESS [  0.287 s]
[INFO] Apache CloudStack Developer Mode ................... SUCCESS [  0.459 s]
[INFO] Apache CloudStack Developer Tools .................. SUCCESS [  0.028 s]
[INFO] Apache CloudStack apidocs .......................... FAILURE [  1.530 s]
[INFO] Apache CloudStack marvin ........................... FAILURE [  0.237 s]
[INFO] Apache CloudStack DevCloud4 ........................ SUCCESS [  0.663 s]
[INFO] Apache CloudStack DevCloud-KVM ..................... SUCCESS [  0.278 s]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-api: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/api/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-engine-schema: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/engine/schema/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.1:copy-dependencies (copy-dependencies) on project cloud-agent: Artifact has not been packaged yet. When used on reactor artifact, copy should be executed after packaging: see MDEP-187. -> [Help 2]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-engine-storage-configdrive: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/engine/storage/configdrive/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-server: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/server/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-framework-quota: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/framework/quota/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.1:copy-dependencies (copy-dependencies) on project cloud-usage: Artifact has not been packaged yet. When used on reactor artifact, copy should be executed after packaging: see MDEP-187. -> [Help 2]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-secondary-storage: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/services/secondary-storage/server/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.2:war (default-war) on project cloud-engine-service: Failed to copy file for artifact [org.apache.cloudstack:cloud-api:jar:<IP_ADDRESS>-SNAPSHOT:compile]: /home/rohit/lab/apache/cloudstack/api/target/classes (Is a directory) -> [Help 2]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-engine-storage-datamotion: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/engine/storage/datamotion/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-engine-storage-snapshot: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/engine/storage/snapshot/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-ca-rootca: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/ca/root-ca/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-database-quota: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/database/quota/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-dedicated-resources: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/dedicated-resources/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-hypervisor-kvm: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/hypervisors/kvm/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-hypervisor-xenserver: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/hypervisors/xenserver/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-network-internallb: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/network-elements/internal-loadbalancer/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-network-nvp: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/network-elements/nicira-nvp/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-user-authenticator-saml2: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/user-authenticators/saml2/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project cloud-plugin-hypervisor-vmware: There are test failures.
[ERROR]
[ERROR] Please refer to /home/rohit/lab/apache/cloudstack/plugins/hypervisors/vmware/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (make-systemvm) on project cloud-systemvm: Failed to create assembly: Error adding file 'org.apache.cloudstack:cloud-api:jar:<IP_ADDRESS>-SNAPSHOT' to archive: /home/rohit/lab/apache/cloudstack/api/target/classes isn't a file. -> [Help 2]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-shade-plugin:3.0.0:shade (rebuild-war) on project cloud-client-ui: Error creating shaded jar: /home/rohit/lab/apache/cloudstack/api/target/classes (Is a directory) -> [Help 2]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project cloud-apidoc: Command execution failed.: Process exited with an error: 1 (Exit value: 1) -> [Help 2]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (generate-sources) on project cloud-marvin: Command execution failed.: Process exited with an error: 1 (Exit value: 1) -> [Help 2]

@blueorangutan package

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

When using Jetty with maven to start/stop management server, exceptions are seen which were not seen in previous jetty-maven-plugin before. I've opened an issue in this regard: https://github.com/eclipse/jetty.project/issues/4410

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-455

Kicked smoketests in the background as this PR requires a new systemvmtemplate.

This is ready for review @wido @GabrielBrascher and others added as reviewer

Trillian test result (tid-595)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34984 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t595-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 69 look OK, 8 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_04_extract_Iso
Failure
1.06
test_iso.py

test_01_create_template
Error
25.62
test_templates.py

test_02_create_template_with_checksum_sha1
Error
65.35
test_templates.py

test_03_create_template_with_checksum_sha256
Error
65.38
test_templates.py

test_04_create_template_with_checksum_md5
Error
65.33
test_templates.py

test_05_create_template_with_no_checksum
Error
65.36
test_templates.py

test_03_delete_template
Error
1.06
test_templates.py

test_04_extract_template
Error
1.06
test_templates.py

ContextSuite context=TestISOUsage>:setup
Error
0.00
test_usage.py

test_01_template_usage
Error
25.67
test_usage.py

test_01_volume_usage
Error
186.57
test_usage.py

test_13_attachAndDetach_iso
Failure
1510.78
test_vm_life_cycle.py

test_06_download_detached_volume
Error
9.29
test_volumes.py

ContextSuite context=TestVPCRedundancy>:setup
Error
0.00
test_vpc_redundant.py

ContextSuite context=TestVPCNics>:setup
Error
0.00
test_vpc_router_nics.py

ContextSuite context=TestRVPCSite2SiteVpn>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVpcRemoteAccessVpn>:setup
Error
0.00
test_vpc_vpn.py

ContextSuite context=TestVpcSite2SiteVpn>:setup
Error
0.00
test_vpc_vpn.py

Trillian test result (tid-598)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40520 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t598-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 71 look OK, 6 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestTemplateHierarchy>:setup
Error
1517.44
test_accounts.py

test_04_extract_Iso
Failure
1.06
test_iso.py

test_01_scale_vm
Failure
13.32
test_scale_vm.py

test_04_extract_template
Failure
1.06
test_templates.py

test_06_download_detached_volume
Failure
11.33
test_volumes.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
427.04
test_vpc_redundant.py

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-456

Trillian test result (tid-608)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41552 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t608-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_simulator.py
Intermittent failure detected: /marvin/tests/smoke/test_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 69 look OK, 8 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestTemplateHierarchy>:setup
Error
1518.23
test_accounts.py

runTest
Error
0.00
test_hostha_simulator.py

test_04_extract_Iso
Failure
1.07
test_iso.py

runTest
Error
0.00
test_outofbandmanagement.py

test_04_extract_template
Failure
1.06
test_templates.py

test_06_download_detached_volume
Failure
10.40
test_volumes.py

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
369.16
test_vpc_redundant.py

test_04_rvpc_network_garbage_collector_nics
Error
3815.17
test_vpc_redundant.py

runTest
Error
0.00
test_hostha_kvm.py

The only three consistent failures are:
test_04_extract_Iso>Failure>1.06>---test_iso.py
test_04_extract_template>---Error>--1.06>---test_templates.py
test_06_download_detached_volume>---Error>--9.29>---test_volumes.py

This suggests symlink management on SSVM to allow downloading of iso/template/volume.

 I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian.  I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-534

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-535

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-542

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Split the Debian 10 base systemvmtemplate to https://github.com/apache/cloudstack/pull/3797 cc @PaulAngus @borisstoyanov @andrijapanicsb @DaanHoogland

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-544

@blueorangutan package

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian.  I'll keep you posted as I make progress.

Trillian test result (tid-721)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27985 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t721-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-546

Trillian test result (tid-723)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40632 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t723-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 71 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_00_deploy_vm_root_resize
Failure
293.62
test_deploy_vm_root_resize.py

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✖centos7 ✖debian.  I'll keep you posted as I make progress.

@DaanHoogland I've fixed the comments, the systemvm/debian/opt/cloud/bin/getRouterAlerts.sh change was to make it executable to be consistent with other scripts in the directory. Yes, the PR is ready for testing/review.
I've also synced the systemvmtemplates/4.14 here: http://download.cloudstack.org/systemvm/4.14/
cc @wido @GabrielBrascher @andrijapanicsb @PaulAngus @DaanHoogland @borisstoyanov

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-552

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-554

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian.  I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-587

jenkins makes sense (java 8 running target language level 11 fails)
the rest looks fine
@rhtyd , ready for more reviews, than just mine?

Yes

@wido @kiwiflyer @weizhouapache Any of you guys want this in ;)

just updated jenkins to run javac 11. rekicking to see how big a blunder that was.

checkstyle fails :( @Pearl1594 or @rhtyd, can you check locally?

I've pinged @Pearl1594 to have a look @DaanHoogland, turns out a test failure for the newly added/merged VM ingestion feature on master.

Auch, i checked that one before merge and all passed. @shwstppr can you have a look, please?

@DaanHoogland looking into it

@DaanHoogland - I've handled the test failure

@DaanHoogland looks like something's up with jenkins? Can you check I don't have access, not sure if there's something I can fix. The checkstyle run in Travis and by BO-Jenkins passes. I'll kick a pkging job.
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

I reverted the javac version on jenkins to see if that explains failures on other PRs (won't help here)
As you suggested @rhtyd , I'll see if i can get jenv on the jenkins boxes.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-743

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-891)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35072 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t891-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Smoke tests completed. 79 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

@DaanHoogland @andrijapanicsb cc @PaulAngus @borisstoyanov I've kicked a vmware test env as well, but based on the latest kvm/smoketest re-run that should pass as well (#hope).

I think we have to move forward. i asked infra for jenv on jenkins so commits can than specify their requirement.

 I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-776

fixed the intermittently failing issue, on error it was calling delete on an array that was the bug. Fixed:
==== Marvin Init Successful ====
=== TestName: test_dedicatePublicIpRange | Status : SUCCESS ===

=== TestName: test_dedicate_public_ip_range_for_system_vms | Status : SUCCESS ===

=== TestName: test_dedicate_public_ip_range_for_system_vms_01_ssvm | Status : SUCCESS ===

=== TestName: test_dedicate_public_ip_range_for_system_vms_02_cpvm | Status : SUCCESS ===

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-780

@wido @GabrielBrascher @weizhouapache @kiwiflyer , i feel like merging this. I'll hold for a few hours to give you the chance to stop me,.... :tik: :tok:

@DaanHoogland it has conflicts with master, you have to fix it before merging :-D
I will test it today

might be due to me merging your PR @weizhouapache :)

might be due to me merging your PR @weizhouapache :)

yes, the change in debian/control

@rhtyd @DaanHoogland have we decided not to support openjdk8/openjdk9 since 4.14 ?

@weizhouapache no because jdk8 has reached EOL, jdk9 is not a LTS. The next/current LTS is jdk11.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@weizhouapache I had started a discussion last year that got no objections so this PR for 4.14 - https://markmail.org/message/6nnlxdh3zjenqjrx

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-786

Checking/fixing pkging failure...

@weizhouapache I had started a discussion last year that got no objections so this PR for 4.14 - https://markmail.org/message/6nnlxdh3zjenqjrx

thanks @rhtyd
is it possible to support both openjdk8/9 and openjdk 11, at least by cloudstack-agent (on kvm hypervisors) ?
upgrading hundreds of servers is a big task and very complicated if we do not have a version supporting both old versions and openjdk11.

@weizhouapache unfortunately in jdk11 they removed many of the core java-runtime packages which are now needed to be installed separately. The other issue is compiled bytecodes are not backward but forward compatible, so this PR can work with java runtime v11 (and above) but not below v11.

@DaanHoogland @andrijapanicsb @weizhouapache @wido @GabrielBrascher any objections on merging this towards 4.14? This is ready and needs a final smoketest run.
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@weizhouapache unfortunately in jdk11 they removed many of the core java-runtime packages which are now needed to be installed separately. The other issue is compiled bytecodes are not backward but forward compatible, so this PR can work with java runtime v11 (and above) but not below v11.

@rhtyd I understand it will be lots of work if we support both jdk11 and old versions on management server. I am ok with removing openjdk8 support in cloudstack-management.
This PR is not a problem for centos7 because it supports both jdk8 and jdk11. However, for ubuntu16 servers, we have to upgrade servers to ubuntu18 (or ubuntu20) before upgrading cloudstack to 4.14.
We can merge this PR at first. I will work on improvement to support both jdk8 and jdk11 on cloudstack-agent before <IP_ADDRESS> release.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-789

@weizhouapache okay, there is one solution that you may explore for cloudstack-agent to use jlink (or similar approaches) to create a deb/rpm package which bundles both the jre11 and the agent without requiring any external jdk dependency. On kvm hosts, you would any way require installing the new cloudstack-agent package so why not an additional jre11 package?
(I'll kick tests in the background)

@weizhouapache okay, there is one solution that you may explore for cloudstack-agent to use jlink (or similar approaches) to create a deb/rpm package which bundles both the jre11 and the agent without requiring any external jdk dependency. On kvm hosts, you would any way require installing the new cloudstack-agent package so why not an additional jre11 package?
(I'll kick tests in the background)

@rhtyd there is no official openjdk11 package for ubuntu16. it is supported from ubuntu 18.04 (Bionic)
https://launchpad.net/ubuntu/+source/openjdk-lts

@weizhouapache there are alternative builds from openjdk, azul, amazon. For example http://repos.azulsystems.com/

@weizhouapache there are alternative builds from openjdk, azul, amazon. For example http://repos.azulsystems.com/

thanks.
it might be a good solution if cloudstack-agent does not work with openjdk8 + this PR

@rhtyd
FYI,
I could not build the project plugins/network-elements/brocade-vcs
it is fixed by
diff --git a/plugins/network-elements/brocade-vcs/pom.xml b/plugins/network-elements/brocade-vcs/pom.xml
index cb6420c..0d3805f 100644
--- a/plugins/network-elements/brocade-vcs/pom.xml
+++ b/plugins/network-elements/brocade-vcs/pom.xml
@@ -32,7 +32,7 @@
             <plugin>
                 <groupId>org.jvnet.jaxb2.maven2</groupId>
                 <artifactId>maven-jaxb2-plugin</artifactId>
-                <version>0.7.1</version>
+                <version>0.14.0</version>
                 <executions>
                     <execution>
                         <id>interface</id>

@weizhouapache this maybe related to jdk or mvn version. Can you try with latest mvn, I'm using 3.6.3 and jdk11 11.0.4 or above?

@rhtyd @weizhouapache just solved another merge conflict. do we run trillian again or await travis and leave it at that?

Travis and packaging should be okay

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✖centos7 ✖debian. JID-790

@DaanHoogland leave it I'll check and fix the branch later. Let's wait for currently running tests to come nonetheless.

mvn -Penablefindbugs install cobertura:cobertura won't run locally @rhtyd. I just tried to see how i messed up that merge above. I'll try again later.

@weizhouapache this maybe related to jdk or mvn version. Can you try with latest mvn, I'm using 3.6.3 and jdk11 11.0.4 or above?

@rhtyd could be maven version related. I am using maven 3.6.0 and openjdk 11.0.6.
anyway, maven-jaxb2-plugin 0.7.1 is too old, it was released in 2010...
it should be better to use latest 0.14.0
https://mvnrepository.com/artifact/org.jvnet.jaxb2.maven2/maven-jaxb2-plugin

Fixed dependency version @weizhouapache
@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Manually rekicked packaging

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-794

@rhtyd have you build new systemvm template with jdk11 ?

@weizhouapache http://download.cloudstack.org/systemvm/4.14/

@weizhouapache http://download.cloudstack.org/systemvm/4.14/

@rhtyd thanks.
my mistake, I re-upload new systemvm template but did not clean template_spool_ref so systemvms still use old 4.11.3 template.
I will test it.

Trillian test result (tid-940)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t940-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 78 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
223.32
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
222.00
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
320.87
test_privategw_acl.py

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-798

Trillian test result (tid-941)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35935 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t941-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 73 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
333.01
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
338.23
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
520.67
test_privategw_acl.py

VP failures are consistently failing on few others PRs.
The following tests on Travis are consistently failing:
| test_03_delete_detached_volume | Failure | 90.193 | test_volumes |
| test_11_destroy_vm_and_volumes | Failure | 46.104 | test_vm_life_cycle |
| test_09_delete_detached_volume | Failure | 5.401  | test_volumes

@weizhouapache can you check ^^ and advise? This is also seen on master. cc @DaanHoogland @andrijapanicsb

@rhtyd @DaanHoogland I will check
Do we have same issue on other PRs ?

Possibly @weizhouapache, the test failures hint at the recently merged feature perhaps. Can you check?

Trillian test result (tid-944)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31118 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t944-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 78 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
215.17
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
211.53
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
315.04
test_privategw_acl.py

Trillian test result (tid-945)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45861 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t945-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 77 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_02_vpc_privategw_static_routes
Failure
355.77
test_privategw_acl.py

test_03_vpc_privategw_restart_vpc_cleanup
Failure
348.59
test_privategw_acl.py

test_04_rvpc_privategw_static_routes
Failure
555.38
test_privategw_acl.py

test_01_scale_vm
Failure
19.60
test_scale_vm.py

Smoketests LGTM, except for test_privategw_acl.py failures which are known. Travis LGTM except for the failures shared, I'll collaborate with @weizhouapache to get it addressed via https://github.com/apache/cloudstack/pull/3880

Considering no objections and lgtm from Andrija and Daan will merge this.


USING  MAVEN_OPTS  inside  the ARTIFACTORY_MAVEN task

Is your feature request related to a problem? Please describe.
Defining MAVEN_OPTS as a variable inside an artifactory_maven task is not working.We were able to overcome the heap memory error after defining the MAVEN_OPTS as a global variable which is having the scope of all tasks.
Here we defined the variable in our environment, removing it from Maven@3 task .
Pipeline snippet:-
variables:

name: MAVEN_OPTS
value: '-Xms10m -Xmx10m -client -XX:MaxPermSize=500m  -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -Xverify:none'

Describe the solution you'd like to see
As it is just a work around with defining the MAVEN_OPTS as a global variable and outside the ARTIFACTORY_MAVEN task ,we are looking for a scenario where if there is a scope where we can define a variable inside the maven task with MAVEN_OPTS.
Describe alternatives you've considered
Scope where we can define a variable inside the maven task
Additional context
Add any other context or screenshots about the feature request here.
variables:

name: BuildParameters.mavenPOMFile
value: pom.xml
trigger:
main
pool:
vmImage: ubuntu-latest
steps:
task: JFrogMaven@1
inputs:
mavenPomFile: 'pom.xml'
goals: 'install'
mavenVersionOption: 'Default'
env MAVEN_OPTS: '-Xmx10m'
publishJUnitResults: true
artifactoryResolverService: 'art2'
targetResolveReleaseRepo: 'manu-libs-release'
targetResolveSnapshotRepo: 'manu-libs-snapshot'
artifactoryDeployService: 'art2'
targetDeployReleaseRepo: 'manu-libs-release'
targetDeploySnapshotRepo: 'manu-libs-snapshot'
collectBuildInfo: true
buildName: '$(Build.DefinitionName)'
buildNumber: '$(Build.BuildNumber)'
includeEnvVars: true
task: PowerShell@2
inputs:
targetType: 'inline'
script: |
task: PowerShell@2
inputs:
targetType: 'inline'
script: |
$env:MAVEN_OPTS="-Xms1024m -Xmx4096m -client -XX:MaxPermSize=500m  -XX:+TieredCompilation -XX:TieredStopAtLevel=1 -Xverify:none"
write-host "before: $($env:MAVEN_OPTS)"
task: Bash@3
inputs:
targetType: 'inline'
script: 'env | sort'
task: JFrogMaven@1
inputs:
mavenPomFile: 'pom.xml'
goals: 'install'
mavenVersionOption: 'Default'
mavenOptions: '-Xmx10m'
artifactoryResolverService: 'art2'
targetResolveReleaseRepo: 'manu-libs-release'
targetResolveSnapshotRepo: 'manu-libs-snapshot'
artifactoryDeployService: 'art2'
targetDeployReleaseRepo: 'manu-libs-release'
targetDeploySnapshotRepo: 'manu-libs-snapshot'
collectBuildInfo: true
buildName: '$(Build.DefinitionName)'
buildNumber: '$(Build.BuildNumber)'
includeEnvVars: true
task: ArtifactoryMaven@2
inputs:
mavenPomFile: 'pom.xml'
goals: 'install'
mavenVersionOption: 'Default'
mavenOptions: '-Xmx10m'
artifactoryResolverService: 'art1'
targetResolveReleaseRepo: 'manu-libs-release'
targetResolveSnapshotRepo: 'manu-libs-snapshot'
artifactoryDeployService: 'art1'
targetDeployReleaseRepo: 'manu-libs-release'
targetDeploySnapshotRepo: 'manu-libs-snapshot'
collectBuildInfo: true

Because the MAVEN_OPTS is stripped, I cannot increase the java memory heap size. For large builds, this may result in build failures.


Syntax highlighting incorrect around document partitions

Single-line comments often do not render in green.
May just be an issue with single-line comments, or may be a general issue with highlighting and document partitions.
(Imported from Bitbucket #13 reported by maxg on 2010-06-07)

Fixed by 3a90ad557d9e37198f459e602aa55c59bbce9b33.
(maxg on 2011-06-08)


Odd issue with EF7 (RC2) returning all virtual collections from entity, without the use of Include

It looks like Entity Framework 7, while lazy loading isn't supported / implemented, is returning all relationships for a given entity without using the Include(...) method.
I'm not sure I follow what the expected behavior should be in this case. See my reproduction below. Note, this github branch/commit reproduces this.
Add DbContext and a repository provider:
// In ConfigureServices
services.AddDbContext<PouarfDbContext>(options => options.UseInMemoryDatabase());
services.AddScoped<IContactProvider, ContactProvider>();

Seed application data:
// In Configure
// CreateSampleData() adds a bunch of `People` objects to a list,
//  and then loops through them, adding each one to the DbContext
//  through the `ContactProvider`
Task.Run(async () =>
  await new
  MockPeople(app
      .ApplicationServices
      .GetService<IContactProvider>()).CreateSampleData());

Couple of examples from ContactProvider implementation:
public async Task AddPerson(Person person)
{
    await Task.Run(() => _dbContext.Add(person));
}

public async Task<IEnumerable<Person>> GetPeople()
{
    // Notice no Include(...)
    return await _dbContext.People.ToListAsync();
}

Person object:
public class Person : ContactInformationBase // Contains Id
{
    ...

    public virtual ICollection<PhoneNumber> PhoneNumbers { get; set; }
}

And then in my controller action, I'm getting the people from EF:
public async Task<IActionResult> Index()
{
    // Contains a populated list of `PhoneNumbers`, even though
    //  they should only be included if I explicitly asked EF7 to load them.
    var people = await _contactProvider.GetPeople();
    ..
}

So basically, EF7 is providing mapped entities from my main object, even though they should only be included when I explicitly ask for them, via an Include(p => p.PhoneNumbers).
I'm using ASP.NET Core 1 RC2, with Entity Framework 7
EDIT
Just added an API action to my controller, and the results are... odd.
[Route("api/[action]")]
public async Task<IEnumerable<Person>> People()
{
    // True adds all the Includes off the DbSet as needed.
    return await _contactProvider.GetPeople(true);
}

Now I'm not getting back any mapped entities with this call. If I remove or add Include() call, it doesn't have an effect on the result. Only the core Person entity is returned, all mapped entities are null.

Solved.
The issue was in the approach of utilizing the Include pattern on the DbSet.
I had this, WRONG:
        var people = _dbContext.People;

        if (includeRelationships)
        {
            people.Include(p => p.PhoneNumbers)
                .Include(p => p.EmailAddresses)
                .Include(p => p.StreetAddresses);
        }

        return await people.FirstOrDefaultAsync(p => p.Id.Equals(id));

And changed it to this, notice the actual applying of the Include here, RIGHT:
        IQueryable<Person> people = _dbContext.People;
        if (includeRelationships)
        {
            people = people
                .Include(p => p.EmailAddresses)
                .Include(p => p.PhoneNumbers)
                .Include(p => p.StreetAddresses);
        }

        return await people.FirstOrDefaultAsync(p => p.Id.Equals(id));


native_dash: autoplay does not work

neather setting the autoplay attribute, nor using data-mejsoptions='{"autoplay": true}'
does make the player start on load, when using mpd file as source.
mediaelement.js
dash.js

best thing is: when you load my example, it works. but if you reload the page, it doesn't

Chrome fix for Vimeo video was updated for autoplay.
Maybe worth taking a look at #2622 as it may be similar issue ?

In vimeo.js:

	if (mediaElement.originalNode.autoplay) {
				vimeoPlayer.play();
	}

in dash.js:

	if (autoplay) {
		dashPlayer.play();
	}

Closing the issue because @karawitan  gave the solution. If there is still work to do here, please reopen the issue.


Remove delay after cancelled streaming requests are aborted

Motivation

The purpose of this PR is to reduce wasted compute on cancelled streaming requests
Modifications

In this PR I removed the asyncio.sleep in the StreamingResponse BackgroundTasks so that the abort_request is sent immediately after a request is cancelled/completed
Checklist

[X] Format your code according to the Contributor Guide.
[X] Add unit tests as outlined in the Contributor Guide.

It doesn't seem necessary (provided benchmarking below)

[X] Update documentation as needed, including docstrings or example tutorials.

Benchmarking
I ran this before/after building from source with/without this PR's change:
python3 -m sglang.bench_serving --backend sglang --dataset-name random --num-prompts 500 --random-input 1024 --random-output 1024 --random-range-ratio 0.5

... and received very comparable results.
Before my change:

After my change:

On a separate note, should we add an asyncio.Event() for watching request.is_disconnected() for both streaming and non-streaming requests?
Currently the BackgroundTask works nicely for this purpose, but I think it would be nice to also have this for non-streaming requests without having to use a while loop with 4s timeout like we do here.

Why was this closed? Does sglang support immediate cancellation of streaming requests? I need to instantly stop generations as I implement a custom stopping mechanism and rely on the batch size = 1 generation speeds

@SinanAkkoyun I ran some other tests and removing the delay actually increased latencies as it is now - so mixed results. Once new CPU managing is introduced (avoiding Python GIL), I think we can revisit


How to specify TTD log location when using --record instead of -TTRecord:[dir]?

Hello,
I previously used time travel debugging in visual studio code with the -TTRecord:log option. After installing the latest nightly build, I'm seeing this command is deprecated and I should use --record instead.  I run this command and it looks successful, but I have no idea where the logs are being saved to.  How can I configure the log directory? I checked the command list in the help menu, but I'm not seeing anything there.
Thank you,
Dan

Hi Dan, we updated the log output to give both an out-of-the-box result and allow for programmatically controlling the output location.
We have hooked up the logger to output to ./_diagnosticTraces/[name] on common error events, like assert failures or unhandled exceptions, in Node. It should also write a trace if you exit the program with a ctrl-c. We updated the trace replay/debug commands as well which are described more in the link.
You can also explicitly write a trace to a location from within your code using the method global.emitTTDLog([path]). This call assumes you have already created the directory given by [path].
Hopefully this solves the issue, if not please let me know.
Thanks,
Mark

Ah! Thank you for the link!
It took a few failed attempts, but eventually the logs are saving:

And success when I have an error thrown in a setInterval call.

I'll close the issue, thanks again for your help.