Support isNew returning a Promise.

Permits overriding Model#isNew to return a promise that resolves to a boolean. This restores save to its behaviour before 0.8.2.
Fixes #885.

After a lot of consideration I'm not going to merge this. The functionality would be awesome to have, but I agree with Rhys that mentioned on #885:

Personally I think overridden functions should maintain their original contract - they should not modify their return type.

Also, since this PR was opened there have been a few changes to saveMethod() that made it more complex.
Furthermore there is now usage of a synchronous isNew() on Model#serialize() and the Model#toJSON() method of the Virtuals plugin, thus making it considerably harder to handle a possible promise returning isNew() without increasing the complexity of the code base exponentially for something that can be solved with:

...modifying save directly or hooking into an event feels like a cleaner approach.

Which, given the use case for this feature as stated on the above linked issue, would be:
initialize: function() {
  this.on('saving', (model, attrs, options) {
    return this.constructor.where('id', this.id).fetch().then(function (existing) {
      options.method = existing == null ? 'insert' : 'update';
    });
  }
}


Better instructions on how to use FTheoryTools

Upon starting Julia, say that one has to issue using FTheoryTools.
Maybe mention that one can configure julia to always do that upon start.
Explain why using Oscar appears in the examples of the documentation.

Cf. https://github.com/Julia-meets-String-Theory/FTheoryTools.jl/pull/18/files.


Window dragging problems

Window dragging works with most applications, but there seems to be a couple of exclusions. Some applications, despite being draggable with a click-hold, do not respond to three-finger-drag. The most peculiar case is the Task Manager as it is a system application. Other cases are Intel Extreme Tuning Utility, AOMEI Backup Professional, ThrottleStop and some installers.
What could be the case?

This might be related to #2, but this bug is fixed in the latest version of the app.
I'll try on my side to reproduce the issue.

Could indeed be an UWP problem. Task Manager is a part of Windows Tools collection, so I just tested dragging on apps from Windows Tools: Device manager (no), Defragment and Optimise Drives (yes), Services (no), Computer management (no), Registry Editor (no), System Information (yes) .... actually most of them are not responding to the drag.

The New Microsoft Edge Version.114, Microsoft Teams cannot be dragged too. Can you help to test ?

The New Microsoft Edge Version.114, Microsoft Teams cannot be dragged too. Can you help to test ?

Both Microsoft Edge 114 and Teams can be dragged on my machine.
Windows 11 22H2.

This issue is due to the TFDOW not runing as an elevated process (administrator). Then, the handler can't receive touchpads events when an elevated window is focused.
In the next release (v2.0), the handler will be an elevated process run at startup with a skipUAC technique, see #27.
Thank you.


binary transport

Binary transmission support

Sending a binary payload cannot be  designed this way. protoo has notifications and requests and responses to requests. Binary payload cannot be a separate message type. Sorry, I cannot accept this PR.

ok~, it doesn't matter
But
first,  I designed the binary transfer to not conflict with the previous features (requests, responses, notifications).
second，The protoo should not lose the transmission binary feature of websocket.
third，Fox example upload file: setup connection -> send data block -> close connection, like this, there is no need to keep a long connection to transmit binary data.
fourth，I used protoo in my project and some service scenarios require sending binary data. If I use another websocket package，I have to maintain two ways of using websocket，so I modify protoo to support binary transfers.

I'm not against the binary feature. It's just that the way you have added binary into protoo is exactly the way is done in raw WebSocket. Now imagine you want to send a protoo request and have a binary body as response. We need a proper protoo response with proper id field and a binary data field into it. That's the way it must be done.

Maybe I didn't make myself clear.
You mean, the binary is payload for protoo in requests, responses, notifications. Binary doesn't make sense in this case. I agree !
I mean, the binary is in a stream, be used for files, images, videos, anything transfer, it does not participate in the request, It doesn't respond. It is independent of the request response pattern.
For example. I want upload a file to the server. Maybe I first send a request telling the server to create a file, then send a series of binary data, just like a stream. After the end, send another request to tell the server it's done.

That's not how a real protocol works. In a real protocol you send a notification with its corresponding notification name or type plus more metadata (such as chunkId) plus a binary body. Imagine you want to upload two files at the same time by sending separate chunks of both files at the same time. That's why we need a real protocol and not just a way to send binary chunks.

Yes, It cannot transfer two files at the same time.
but this is just a json protocol，Message class { id, method, data }，the format is fixed, use JSON.stringify  then socket send. I try to put binary in message.data，this increases the size of the message. The data sent will be much larger than the file size.
The chunkId and binary body in Message，It's impossible，unless you make big changes to protoo.
Maybe add a layer of binary protocol before the JSON protocol. Is this necessary？ I can transfer one file at the same time and I think that's fine, it better than nothing.

Binary payload support will be properly implemented in some weeks, but approach in current PR is not the way to go.

ok, thanks


Not work well with kotlin coroutine

Overview
I'm using the ktx library. Since I want to handle each type of permission denied event separately, I was trying to convert the callback API to coroutine and call every kind of permission request sequentially. Then I found that after the first coroutine executed and the request dialog was showed, the next coroutine will be inactive, and could not to resume, thus the future coroutines could not be execute.
I also found that when all the permissions was granted, the coroutine sequence could execute correctly. The only difference between the two cases is whether or not a permission request dialog pops up.
Expected
Permission request coroutine could run correctly.
Actual
After a permission request dialog was showed, the next coroutine will be inactive.
Environment
permissionsdispatcher-ktx:1.0.1

thx for the report, could we possibly get a minimum example project to repro the issue? 🙏

a simple demo:
fun FragmentActivity.pickPhoto() {
    GlobalScope.launch {
        catchAll {
            requestSinglePermission(this@pickPhoto, Manifest.permission.CAMERA)
            requestSinglePermission(
                    this@pickPhoto,
                    Manifest.permission.READ_EXTERNAL_STORAGE,
                    Manifest.permission.WRITE_EXTERNAL_STORAGE
            )
            // do works after granted
        }
    }
}

// make callback as coroutine API
suspend fun requestSinglePermission(fragmentActivity: FragmentActivity, vararg permissions: String): Boolean {
    return suspendCancellableCoroutine {
        fragmentActivity.constructPermissionsRequest(
                *permissions,
                onShowRationale = { it.proceed() },
                onPermissionDenied = {
                    it.cancel()
                },
                onNeverAskAgain = {
                    it.cancel()
                }
        ) {
            if (it.isActive) {
                it.resume(true)
            }
        }.launch()
    }
}

I don't know if it's possible to make this work. But what I really need is a parameter who can let me know witch permission(s) has been denied.

thx, let us check

https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/730#issue-911348900


Area Light issue

A single side light illuminates an object, and the light image will be displayed on both sides of the object.
When the light is below the plane, there will still be light display.

Thanks for the issue! They have been resolved!


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 11:03:29 on 2023.08.17
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 0, errors out: 0
Original problem ID: 76242
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=76242

Problem has been resolved in 36m 0s at 11:39:29 on 2023.08.17
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 76242


Catching ValueError

Generating error message in 294 and 295, but not being caught and/or updated in code coverage.

correct implementation - fault in testing method


Adding filter settings documentation

Documents the list of filter settings.
A little formatting in the filters.

Good additions, but I am considering removing this repo entirely, since the new site will have the new documentation.

Is there a way I could help with the documentation on the new site? I'd like to help you with this.


Opencv version compatibility issue

Hi, thanks for your work.
While testing your codes, I found an error:
/content/LineFiller/linefiller/trappedball_fill.py in get_border_point(points, rect, max_height, max_width)
    284
    285     # Get shape.
--> 286     _, contours, _ = cv2.findContours(fill, cv2.RETR_EXTERNAL, cv2.CHAIN_APPROX_SIMPLE)
    287     approx_shape = cv2.approxPolyDP(contours[0], 0.02 * cv2.arcLength(contours[0], True), True)
    288

ValueError: not enough values to unpack (expected 3, got 2)

I guess there is a version compatibility issue for opencv, since cv2.findContours may return 2 or 3 values according to the opencv version.
I think the solution is simple:
# as is
_, contours, _ = cv2.findContours(fill, cv2.RETR_EXTERNAL, cv2.CHAIN_APPROX_SIMPLE)

# to be
contours = cv2.findContours(fill, cv2.RETR_EXTERNAL, cv2.CHAIN_APPROX_SIMPLE)[-2]

Thanks.

Yes, thank you for your advice.


CI/CD Automate the building of example images that can be done prior to releasing new version

There are 3 related issues associated with the overall goal of being able to automate the release of new A8 versions.  Currently the sidecar, controller, and registry have automation in place.  The goal of this set of issues is to extend automation to the building, testing, and publishing of the examples that are associated with A8 (bookinfo and helloworld).
Following are the manual steps that are occurring for each of the A8 releases).
1. Update changelog.
2. Update Dockerhub images to install new release.
3. Create interim release.
4. Build bookinfo/helloworld app images.
5. Verify bookinfo/helloworld demo steps in K8S and Docker environments.
6.  Make release public.
7. Push bookinfo/helloworld images to Dockerhub.

When a git commit is tagged with a version for release (e.g., v0.4.3), we need to run the following tasks in automated fashion:
1) Build bookinfo/helloworld app images using the latest version of sidecar in master, as opposed to the one in GitHub. [Look into docker args or docker compose build for this]
2) Verify bookinfo/helloworld demo steps in K8S and Docker environments. [Reuse the a version of demo_script.sh from this commit 659dc19e82c5b179c9159b176affcb085841448e]
3) push docker images for the example images for bookinfo and helloworld. [We already have a mechanism in place to push docker images for a8-controller,registry and sidecar

This issue will focus on step 4, Build bookinfo/helloworld app images.
https://github.com/amalgam8/amalgam8/issues/405  will focus on step 5 (automated testing)
https://github.com/amalgam8/amalgam8/issues/404 will focus on step 7 (automated publishing of the bookinfo/helloworld images to Dockerhub).

Right now I perform the following manual steps for each A8 release (most relevant portion in bold):

Update changelog.
Update Dockerhub images to install new release.
Create interim release.
Build bookinfo/helloworld app images.
Verify bookinfo/helloworld demo steps in K8S and Docker environments.
Make release public.
Push bookinfo/helloworld images to Dockerhub.

closing as duplicate of #404

We would like to treat the automation associated with delivering new versions as several separate items so that we can have distinct notes/discussion about each of these items.  The overall functionality can be delivered in stages thus wanting to keep these issues separate.  Reopening this issue.

Addressed by PR 467


Inconsistent docstrings in pulse module

What is the expected enhancement?
In order to have documentation that is uniform over all Qiskit elements, the type annotations used in the Pulse module, and related functions, need to be converted into the standard docstring type used in most other modules.

Ok I transferred this issue here. As discussed, seems there is agreement that this should be handled by the docs.
@SooluThomas is there any update?

I don't have any positive update for this yet. The best way is to stick on to a standard (either with type hints or without). I talked to @lcapelluto about this and got an understanding that having type hints is a better option for the developers but, for a user perspective, its not an ideal thing.

It would be helpful if you could explain a bit on why there is a problem pulling them into the documentation? It was my understanding that the Sphinx, Napolean package supported type hints in google style docstrings. Its possible we are not using this package?


Unexpected token ILLEGAL - ERROR LOADING PLUGIN homebridge-alarmdotcom

My Alarm.com plugin seems to have started failing this weekend.  Not sure if others experience the same.
ct 31 11:37:42 raspberrypi homebridge[8343]: [10/31/2016, 11:37:42 AM] ====================
Oct 31 11:37:42 raspberrypi homebridge[8343]: [10/31/2016, 11:37:42 AM] ERROR LOADING PLUGIN homebridge-alarmdotcom:
Oct 31 11:37:42 raspberrypi homebridge[8343]: [10/31/2016, 11:37:42 AM] SyntaxError: Unexpected token ILLEGAL
Oct 31 11:37:42 raspberrypi homebridge[8343]: at exports.runInThisContext (vm.js:53:16)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Module._compile (module.js:413:25)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Object.Module._extensions..js (module.js:452:10)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Module.load (module.js:355:32)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Function.Module._load (module.js:310:12)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Module.require (module.js:365:17)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at require (module.js:384:17)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-alarmdotcom/node_modules/asn1/lib/ber/index.js:6:14)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Module._compile (module.js:434:26)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Object.Module._extensions..js (module.js:452:10)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Module.load (module.js:355:32)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Function.Module._load (module.js:310:12)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Module.require (module.js:365:17)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at require (module.js:384:17)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Object.<anonymous> (/usr/local/lib/node_modules/homebridge-alarmdotcom/node_modules/asn1/lib/index.js:6:11)
Oct 31 11:37:42 raspberrypi homebridge[8343]: at Module._compile (module.js:434:26)
Oct 31 11:37:42 raspberrypi homebridge[8343]: [10/31/2016, 11:37:42 AM] ====================

It looks like when the plugin attempts to load, it fails, and then homebridge itself crashes since the plugin cannot be found/registerd due to the loading issue.

I have not seen this, although I have not restarted homebridge in some number of weeks. I'll try when I get home and report back.

@amitgandhinz I just stopped and restarted homebridge. Everything is running fine. However, I have not update homebridge in quite some time. Maybe there are issues in a recent release? I'll upgrade and see if it still works.

@amitgandhinz I just installed the latest release of homebridge and everything works fine. I have to assume this is either a raspberrypi issue or due to one of your other plugins. Those are obviously just guesses, though.

ok weird.  mine was working fine and randomly stopped working with this plugin.  Im going to try some more things this weekend to see what could be causing it.  It doesn't look like anything was updated specifically with this plug in, so maybe something else is causing this particular on to fail. I will let you know what i find.
Thanks for looking into it.

okay figured it out.  the main homebridge package had upgraded and took on a dependency on the latest node version.  After upgrading node and reinstalling (npm install -g homebridge) I was able to narrow down the issue with alarmdotcom using a corrupted asn library.  So i uninstalled and reinstalled the homebridge-alarmdotcom package, and all issues appear to be now resolved.
Not sure how that asn package was corrupted.  I suspect it was due to the change in node versions.
In Conclusion

Upgrade node version to the latest (v7).  I did it via n
Uninstall, then Reinstall npm install -g homebridge
Uninstall, then Reinstall npm install -g homebridge-alarmdotcom

@amitgandhinz Cool. Glad it's working again.


[Enhancement]:Support concurrent backup/restore support

What would you like to be added?
Support concurrent backup/restore support and make it configurable
Why is this needed?
No response
Anything else?
No response

/assgin


Allowing client to use multiple servers

I share my meshnet with friends who have homelabs of their own. I don't think this is a particularly uncommon use-case, and I think it will become more common as time goes on. The best solution for us right now is Tailscale, but I'd really like to use something completely open-source instead. Besides perhaps a kind of MagicDNS substitute (which, I'm not sure-- might actually be a prerequisite for this) (#216) the single thing that is preventing people like me from being able to use innernet is that it can only use a single coordination server at a time.
There are several servers and clients which my friends wouldn't want anyone else to access, myself included. For this reason alone, we have little choice but to stick with Tailscale and their machine sharing functionality or to write our own Wireguard configurations manually (sacrificing all of the other niceties of using a meshnet provider).
If the innernet client could be configured on the device to log in to multiple coordination servers and combine the permissions they are presented from each in a manner which the user desires for that device, that would be fantastic.

I didn't try it out, but I would assume that innernet already supports that? "innernet install" creates a new innernet config. You can enable the systemd service as<EMAIL_ADDRESS>and the wireguard device is also named like the network name. So I would assume that you can just run a second innernet service when you get the invite link of a differently-named innernet server (your friend's).
The host file editing "DNS" of innernet should also not collide because of the network name is part of the used domain.
Just make sure your IP subnets don't collide.

Thanks @csarn for responsing, it is indeed the case! You should be able to run as many innernet interfaces as you want as long as the IP subnets don't collide.


WIP Better documentations

Overview
Just readme and documentation updates.
Includes:
See files tab for reference
Developer Checklist:

[x] The code follows the Quality Policy file on Google Drive
[x] My code has been developer-tested and includes unit tests
[x] I have considered proper use of exceptions
[x] I have eliminated IDE warnings

Notes:
NA
Refs:

HM-319
#89
#91
#92

@aschnapp is this still a work in progress?

@aneuhold mostly done, one last thing which is still getting resolved in slack

@aneuhold this is done now.

@aneuhold done!


Correct canonical url for non-versioned docs pages

On current site, non-versioned docs pages have incorrect canonical url resulting in 404s.

This change is


Use Document Consumer Grouping

close #3
✅ Checks

[x] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[x] I have updated the documentation as required
[ ] All the tests have passed
[x] I have selected a committee co-chair to review the PR

ℹ Additional Information
Note that this drastically simplified the text.
This also resulted in many of the original figures to be unnecessary or out of date.
New diagram is from the HIE Whitepaper, or are plantuml

given the significant changes, this likely should have some committee time.

http://build.fhir.org/ig/IHE/ITI.mXDE/branches/align-content-consumer/index.html

@lukeaduncan can you approve this PR for merging?

should this change the version? Version 2.0.0?


Adding new info state and screen to splash mode

Issues

Resolves #169
Closes #

Description
I made the splash screen into a new mode with multiple screens that you can cycle through by tapping like any other mode. Currently there are 2 states, logo and info.
I added the "info" screen which at the moment just displays the firmware version.
Created a version define that we can override at compile time in the build process to use the actual release version.
Disclaimer
I had to use 3 separate defines for major, minor and patch instead of a string because the arduino-cli does not support string type defines due to a bug (https://github.com/arduino/arduino-cli/issues/846#issuecomment-678842289)
Types of changes
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[X] Requested changes are in a branch
[ ] Compiled and tested requested changes on target hardware (PC, device)
[ ] Updated the documentation, if necessary
[ ] Updated the LICENSES file, if necessary
[ ] Reviewed the guidelines for contributing to this repository

Added built date below the firmware version


Please keep the version button on the homepage... :-)

Hi @adriankumpf, I noticed in 1.19.0-dev, that you removed the version button on the home page in favour of having the info in the settings.
Couldn't we have both? I really liked it on the homepage...
(Btw, perhaps it would be good to have separate images for latest, testing, dev?)

Why, though? 😄 Are you worried you'll miss an update? Starting with v1.19 you'll get an update notification. That's why I removed the version button.

+1 to this request.  @adriankumpf  how would the update notification work? I like the simplicity of being able to click on this and get to see if there is something new. Is the notification on the same page?

Why, though? 😄 Are you worried you'll miss an update?

Eh, no. Having several instances installed, I soometimes get confused, which version is running where.

Starting with v1.19 you'll get an update notification. That's why I removed the version button.

That is, of course, excellent. Any chance for automatic update? Or update by button push?

I see. But most users probably have only one instance, right? ;-) I think the extra click needed to get to the version is okay for now.

+1 to this request. @adriankumpf how would the update notification work? I like the simplicity of being able to click on this and get to see if there is something new. Is the notification on the same page?

Wait and see! :)

Hey @adriankumpf - I wanted to understand how is this going to work? Upgraded to v1.19.0 yesterday, and saw this morning that v1.19.1 came out but didn't get any notification when I login. I got to know of the update because of github notifications. Is there a config change I need to do. I don't see anything on the settings page. So curious to know what I am missing.
Thanks.

Hey @adriankumpf - I wanted to understand how is this going to work? Upgraded to v1.19.0 yesterday, and saw this morning that v1.19.1 came out but didn't get any notification when I login. I got to know of the update because of github notifications. Is there a config change I need to do. I don't see anything on the settings page. So curious to know what I am missing.
Thanks.

@bahree - bottom of the home page is a subtle, gray text that lists that there is an update. Suggest making that more persistent and visible @adriankumpf

I don't see that. Any ideas on what is missing or blocking?
E.g here is the image from the bottom of the settings page:

And on TeslaMate's 'home page' - I only see the donate option.

The update check is performed 5 minutes after startup and every 72 hours:
https://github.com/adriankumpf/teslamate/blob/b670d2a4729f0dd236ba6e9c1e02e2c52c994243/lib/teslamate/updater.ex#L26-L27
If you do not see a notification after restarting/three days, as usual, check the logs to see if the request failed :)


MP+ migration

Took #483, rebased, applied my comments, and added one commit on top.

As of now, I think there would be unwanted changes on the Automotive cluster

I tested on the auto - stg and I'm not aware of any unwanted changes. Will test with the MP+ stg tomorrow and merge then.

Looks OK on MP+ (stg) as well, merging.


Disallowed undefined rotation value

See https://github.com/openlayers/ol3/pull/3174#issuecomment-71606896

LGTM

+1

See also #3179

Why treating rotation differently from resolution and center? I do not see any reason. We should also think about the case where no initial state passed to the View constructor: new ol.View().

Because rotation has a clear default value and resolution and center do not?

Why treating rotation differently from resolution and center? I do not see any reason.

Because rotation has a default value which is set in the constructor. The rotation is always a number (except if view.setRotation(undefined) or view.setRotation(false) is used)

We should also think about the case where no initial state passed to the View constructor: new ol.View().

In this case rotation is 0 and center is null. resolution is not set (undefined)

Because rotation has a clear default value and resolution and center do not?

Ok, that makes more sense now, and I agree.
So resolution and center have no natural default values, so undefined/null are possible values for them. Ok.
Thanks @bartvde and @fredj.

Thanks a lot for the review


Support only latest version of apiVersion in alfresco-repository ingress.

Deprecated by https://github.com/Alfresco/alfresco-helm-charts/pull/211


issue #4100 added progress bar to the "Run all"

the top bar should not become taller when the progress appears

color of cancel button should always use this brighter red, from the ambiance theme:

and use the dark gray bkg, again like ambiance:

the color of the cancel button and the bkg of the progress meter are still wrong.

this progress meter should not appear when you just run a single cell with the normal run button,
only when you run multiple cells.


Censored sln Image

Used a ruleset though i believe one or two of these passwords can be cracked without the ruleset (most were not)
I have emailed the accounts in question to let them know their passwords are insecure.

Ready for review? LMK when; I'll pull and view the flag image locally


799-Iterator-basicAssociationsDo-is-not-basic

rename #basicAssociationsDo: to #associationsDo:
implement #associationsDo: in term of #nextAssociation, as we want to restore the value and need associations anyway, no need to use #basicAssocations here

fixes #799

SmalltalkCI is broken in Pharo13, there is an issue already:https://github.com/pharo-project/pharo/issues/17012


operator falcon-operator (0.8.1)

Thanks for submitting your Operator. Please check the below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want to use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description of the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible

/merge possible

@redhatrises this change breaks the upgrade graph of the operator. Bundle 0.5.5 is left with no upgrade path.
This is also breaking the index consistency check in the release pipeline.
Can you please fix this by either adding replaces: falcon-operator.0.5.5 or by moving this bundle to a different channel?
Thanks!


Handle should happen before Observe

@mcollina Might need a look off you one this one. My observers get the pattern before the handler does. Logically in code, this makes sense, the handler is a callback. But I would like to handle observers after the fact as they are second in priority. Any ideas.
Logic is here: https://github.com/senecajs/varo/blob/master/lib/varo.js#L17-L41

You should encapsulate the Parralel instance in the instance.
Do not allocate next and complete, but rather instantiate an object as state, and stick everything in there. This is roughly 20-100% faster than allocating those function, see https://github.com/mcollina/aedes/blob/master/aedes.js#L201-L212 as an example.
I would call the handler first, store the result in the State object, and then call the observe handlers.

Basically you should never allocate a callback, if you want your code to be fast :).

@mcollina That's why you're my hero :D

@mcollina Removed a lot of this code in the end, split emit() and act() to simplify usage of each. Will move to steed over fastparallel. This should give me what I am looking for here. For now, this can be closed. Thanks for the input.


Automatic color conversion

Could this extension also prettify the colors by finding the closest standard tailwind color?
Example: https://find-nearest-tailwind-colour.netlify.app/

https://github.com/edjw/find-nearest-tailwind-colour

@andraz Good idea! At the moment, the extension compares colors strictly, but regardless of the color format.


Change the build system used  (CMake -> Meson)

CMake is quite complex and error prone by design, we should change to something better that can be easily written and also is a multi-platform build system. Our picked choice is meson and the following tasks should be complete:

[ ] Substitute the old build system with a meson one (on another branch and then merge it).
[ ] Create unit tests within the build system to assure the modules created on the framework.
[ ] Change the README.md accordingly with the new build system.

Also consider using other build systems, such as: https://github.com/tboox/xmake 😄


[SUPPORT]How to query history snapshot by given one history partition?

How to query history snapshot by given one history partition?
At present, through the following method, I can query the historical snapshot of a Hudi partition, but for me, this method is very unfriendly. Because I didn't know how many times there were the most recent commits in the partition I want to query when I query.
add jar ${hudi.hadoop.bundle};

set hoodie.stock_ticks_cow.consume.mode=INCREMENTAL;
set hoodie.stock_ticks_cow.consume.max.commits=3;
set hoodie.stock_ticks_cow.consume.start.timestamp='${min.commit.time}';

If the Hudi community can provide a way to query the full history snapshots of a partition in Hudi, I think this is a great feature, because it can solve the pain point of querying the full history snapshots.
In this way, I can directly switch the current full data warehouse Hive on HDFS model to Hive on Hudi

@hushenmin I'm trying to understand your request a little better. Are you wanting to query older snapshots of the table ? Something like select * from hudi_table where timeAsOf (commit_time). Can you explain what you mean by "history partition" ?
Some of the details around time-travel have been listed here -> https://cwiki.apache.org/confluence/display/HUDI/RFC+-+07+%3A+Point+in+time+Time-Travel+queries+on+Hudi+table.
Is that what you're looking for ?

In short, in the case of non-global index writes, backtrack historical snapshots and remove duplicates

@hushenmin You want to time travel to a historical snapshot ? That should be possible with Hudi. Although, I'm not following the "remove duplicates" requirement, can you elaborate this with an example please ?

@hushenmin Time travel queries through spark sql should be doable in the upcoming release. See #3360
Can we close this issue if it satisfies your requirement? If not, it would be great if you could share an example.

Closing due to inactivity


Remove preventDefault calls from certain click handlers on Item

preventDefault is called on the following item actions:
Item actions

onMouseDown and onTouchStart - the reason for this is, I believe, we need to accommodate selecting, dragging etc
onContextMenu - preventDefault is called only if we have passed in an onItemContextMenu handler.  This makes sense to me and we detail it in the README
onDoubleClick - preventDefault is called regardless of if we pass in a onItemDoubleClick handler or not. Why?  I don't know.  Edit: heres why

Anyways, I'd like to remove this call to preventDefault on double click of items as its causing me issues in an app of mine (double click doesnt remove focus from a control and there's weirdness with bringing that focused element into view after certain actions).  The event for double click is returned in the onItemDoubleClick prop so if the user wants to preventDefault in that handler, they can.

Done in v0.15.11

Looks like my issue is related to mouseDown being cancelled, no doubleClick.  preventDefault on mousedown prevents blur from being called on the activeElement. sigh
I'm keeping this closed, but its not fixed.  The way Item interaction is handled could possibly be refactored and that could fix this but I'm just going to handle this issue in my app code.


Change 6mon to be aware of renaming "master" to "main" and have it automagickally switch to "main" from "master" for local git repos

The goal here is to reduce impact on developers and 6mon users.
When a user runs 6mon start or 6mon sync-all it should just work.

This is very 6RiverSystems-specific and doesn't belong in this GitHub repo, will use 6RS issue tracking instead


Add failing troublesome pyc file test

Finally managed to reproduce the issue, which as expected, only happens with certain .pyc files.

Thanks for the test case @johtso, appreciate it :smiley_cat:

@audreyr Fails on appveyor but not travis?
https://ci.appveyor.com/project/audreyr/binaryornot/build/1.0.41/job/j0jxnu1m52s0x8hv
https://travis-ci.org/audreyr/binaryornot/jobs/92296767


Maybe parser(specifier) instead of format(specifier).parse?

It might be a little cleaner if time parsers were constructed separately from formatters. In most cases, I end up doing something like this:
var parseTime = d3.timeFormat("%x").parse;

How about this instead:
var parseTime = d3.timeParser("%x");

Though, the asymmetry between “format” (which can be both a noun and a verb), “formatter”, “parse” (which can only be a verb) and “parser” bothers me.

Done in 0.3.


enochian timer stays at "over"

Hello, I am having problem getting enochian timer to work, I am using english client, the most recent version of MP Timer but it's always staying on over. This is the setting i am using.

I was just able to get it to work. Keep up the good work :)

Hey, would you mind describing how you manage to make it work ? I got the exact same problem.
Thanks !


No update for bagisto version received.

Bug Report

Issue Description

Currently, I have not received any notification regarding the version update.  My project is on version 1.20 and I am not able to update it new version.
Preconditions

Bagisto Version

[ ] master branch
[ ] 1.3.3
[ ] 1.3.2
[ ] 1.3.1
[ ] 1.3.0
[ -] 1.2.0

Steps To Reproduce

Actual Result

Getting errors in admin panel w.r.t. to  updating the project from 1.2.0 to 1.3.*
Expected Result

I should be able to update my store

Hi @soodankush
Can you please elaborate what issues are getting exactly

Hi @Sanjaybhattwebkul ,
I am not sure whether should I update from ver 1.2.0 because I have tried in my local and getting way too many errors.
What do you suggest?? Should I do it or not ???
Which is the stable version which I should update to from 1.2.0

Hi @soodankush
Have you done any core customization?

@Sanjaybhattwebkul,
I have only added the Razorpay package for payment. Rest there is no customization.
What do u say? Should I proceed

@soodankush
Yes you can process, but the First Razorpay package has to be compatible for the V1.3.3

Okay, @Sanjaybhattwebkul.
Thanks. I will try and keep you updated.


Support 1.1.0 manifests

Description of the new feature/enhancement
Be prepared to switch to Manifest version 1.1.0 once microsoft/winget-pkgs/issues/27937 is completed
Proposed technical implementation details (optional)

Review the 1.1.0 manifest schema for any important fields that should be prompted for  (see also microsoft/winget-cli/issues/1243
Ensure validation for all fields is correct

Other Considerations

Do we need to support 1.1.0 and 1.0.0 schema manifest creations

@OfficialEsco Would you be able to suggest which of the fields we should prompt for?
I'm thinking

Release Date
Release notes URL
ElevationRequirement

@OfficialEsco Would you be able to suggest which of the fields we should prompt for?

Well, I also have some fields which can be taken into consideration:

Channel
Dependencies
DisplayVersion

@OfficialEsco Would you be able to suggest which of the fields we should prompt for?

Well, I also have some fields which can be taken into consideration:

Channel
Dependencies
DisplayVersion

Dependencies might be a bit difficult due to the structure, but I could see where it would be good to add. I think they exist in the 1.0 schema too

Release Date
Release notes URL
ElevationRequirement

Yeah these are good/important

Channel
Dependencies
DisplayVersion

Channel is important, however we need to know if they actually support and how to use it.. This might be a waaaay too advanced for most people.
Dependencies is also complicated and not something you need to add often other than once
I think we might need all of these to be optional
AppsAndFeaturesEntry:
  DisplayName:
  Publisher:
  DisplayVersion:
  ProductCode:

Tbh Schema 1.1.0 seems a lill bit messy

I think just before testing and submitting the manifest, we can include a prompt something like this "Do you want to fill additional/advanced manifest fields" and then we can prompt for these fields.

I think we can and should be able to move over to manifest schema 1.1.0 fairly quickly
We can add the different variables as needed

I think there's a couple ways to approach it; The first is to just add the variables, and that is probably the best next step. It is the approach I want to take.
The second step, then, it is to change how the data gets populated into the manifest. Ideally, we would never be creating new manifests, only modifying them. Yes, I do truly mean this. Even for "new" manifests, we should ideally be starting with a full manifest, where all the fields are simply null. This would make a lot of the logic more direct, since we would never have to worry about fields being missed. I'll document a bit more of this later in #37, but the main idea is that we always either 1) Create a blank manifest of the latest version, copy over all the metadata that we can, and then continue - or 2) Check which fields exist in the current manifest, add the ones which do not exist, then continue.

Please also set v2.1.0 as the default branch

I think that the best way to go about adding support for additional manifest fields will be to rethink the idea of how we are creating the Yaml files in the first place.
Currently, we are asking users to select a program flow, then enter variables which get populated into an untracked object, and then eventually get written into Yaml. This requires careful scrutiny of all the parameters and where they are placed, has a lot of potential for duplicate code, and is overall an inefficient way of coding. As the manifest schema gets more complex, this requires each flow to be updated and validated independently.
I had done some experimentation in a separate branch on using a -InputObject parameter for updating existing manifests. After more consideration, I think that this can be used to optimize the logic flow. Here's what I'm thinking:

The main thing to note is that every single property that we would request would get its own function - referred to here as a property function. This would allow for the ability to customize each flow individually and handle the cases on a more dynamic basis, while avoiding duplication of code.
The second thing to note here is the recursive nature of the script. It would only ever go to writing the manifests if it was called using the input object parameter. This means that the script has two main sections -

Primary Flow - Creating or updating a manifest from an input object
Secondary Flow - Creating the object to feed into the primary flow

By doing it this way, the primary flow becomes the single point that needs to be tested. Not to say that the secondary flow doesn't need to be tested, but more that it reduces the logic to a single place where manifest data is ever changed, making debugging easier.
@OfficialEsco  @jedieaston  I'd love to know your thoughts on this proposal before I start the work

Finally, some examples of how this would simplify the flows -
Example 1 - Auto Update
PS> YamlCreate.ps1 -PackageIdentifier Example.Package -PackageVersion 1.0.0 -AutoUpdate
# becomes
PS> YamlCreate.ps1 -InputObject @{'PackageIdentifier'='Example.Package';'PackageVersion'='1.0.0'}

Example 2 - Simple Update
Object output from Simple Update Secondary Flow -
{
'PackageIdentifier' : 'Example.Package',
'PackageVersion' : '1.0.0',
'Installers' : [
  {
    'InstallerUrl' : 'https://example.url/1.exe',
    'InstallerSha256' : 'BLAHBLAHBLAH',
    'Architecture' : 'x64'
  },
  {
    'InstallerUrl' : 'https://example.url/1.exe',
    'InstallerSha256' : 'WORDSWORDSWORDS',
    'Architecture' : 'x86'
  }
  ]
}

This data would then be passed back into the YamlCreate script, and the data would be merged with the existing manifest to create the new manifest

I'm running on final exam brain atm, but this looks like a good idea to me. The refactor will be complicated.

I'm running on final exam brain atm, but this looks like a good idea to me. The refactor will be complicated.

It will be very complicated, if this is a route we want to go. I'm thinking that I might start it in a new file until I actually get it working

The ReleaseNotes field should be cleared during Quick Update.

@SpecterShell that will be implemented in YamlCreate 2.1.0, same as https://github.com/Trenly/winget-pkgs/issues/116
@Trenly took upon him self to rewrite/structure YamlCreate as you can see so it will take some time, winget dosn't fully support the 1.1.0 schema yet (wingetcreate reverts to 1.0.0) either so we got some time, currently we manually implement the needed 1.1.0 features where it is needed and stay away from the features that require updated metadata for each version.

@Trenly since i don't understand the script anymore, how "hard" would it clear the ReleaseDate, ReleaseNotes and ReleaseNotesUrl field? Since @SpecterShell love adding them i think this could be prioritized for 2.0.5 since its not merged yet
Later we could look into suggesting ReleaseDate as today (skip prompt for Vedant's automation), + there is currently a "bug" here that makes the date invalid, not sure how it affects Vendant's automation
ReleaseNotesUrl could also be automated IF its a GitHub url, could probably do the same for LicenseUrl.
ReleaseNotes could be scraped, not sure if Vedant have looked into this or he just added patch notes as a test?

@Trenly since i don't understand the script anymore, how "hard" would it clear the ReleaseDate, ReleaseNotes and ReleaseNotesUrl field? Since @SpecterShell love adding them i think this could be prioritized for 2.0.5 since its not merged yet
Later we could look into suggesting ReleaseDate as today (skip prompt for Vedant's automation), + there is currently a "bug" here that makes the date invalid, not sure how it affects Vendant's automation
ReleaseNotesUrl could also be automated IF its a GitHub url, could probably do the same for LicenseUrl. ReleaseNotes could be scraped, not sure if Vedant have looked into this or he just added patch notes as a test?

I don't think it would be hard to clear them; Adding a prompt for them gets a little more involved, and adding a parameter for it would be difficult until the rewrite.
What are all the fields that should be cleared when updating automatically?

What are all the fields that should be cleared when updating automatically? Is it just the 3 you mentioned?

Yup that should be enough
https://github.com/microsoft/winget-pkgs/pull/41683/files
https://github.com/microsoft/winget-pkgs/pull/41248/files
https://github.com/microsoft/winget-pkgs/pull/41247/files
Also about our Channel discussion somewhere on GitHub, the REST Schema 1.1.0 does still not support it, but would be smart to have a module ready in the rewrite

What are all the fields that should be cleared when updating automatically? Is it just the 3 you mentioned?

Yup that should be enough https://github.com/microsoft/winget-pkgs/pull/41683/files https://github.com/microsoft/winget-pkgs/pull/41248/files https://github.com/microsoft/winget-pkgs/pull/41247/files
Also about our Channel discussion somewhere on GitHub, the REST Schema 1.1.0 does still not support it, but would be smart to have a module ready in the rewrite

See #137 regarding the fields;
As for channels, I'll include it in the rewrite; Seems like it's a bit far out for right now

Later we could look into suggesting ReleaseDate as today (skip prompt for Vedant's automation), + there is currently a "bug" here that makes the date invalid, not sure how it affects Vendant's automation

GitHub's API returns created_at and published_at parameters so I can automate ReleaseDate once I know which format I have to convert it to.
API returns the data in ISO-8601 format:

ReleaseNotesUrl could also be automated IF its a GitHub url, could probably do the same for LicenseUrl. ReleaseNotes could be scraped, not sure if Vedant have looked into this or he just added patch notes as a test?

ReleaseNotesUrl is pretty simple. For ReleaseNotes, it is a little tricky since the API returns data in RAW format:
"body": "### Bug Fixes\n\n* use debug for logging pwd ([d75f6e3](https://github.com/JanDeDobbeleer/oh-my-posh/commit/d75f6e30aafbe8818332cc1010d37607355062a8))"

so, I need to write a manual function to scrape the real content and remove all formatting, headings, code, etc...


Added deccan ruby conf 2018

Deccan Ruby Conf 2018 happening in Pune on 4th Aug 2018

2018 is almost over, so I'll close this. Thanks for creating the PR, much appreciated!


Load Routes From Variable

Hi,
I am trying to load the routes from variable using the following code, Whenever I try to open the home page or the root "/", the components loaded inside the element app instead of the page-wrapper.
var myroutes = (<Route path="/" component={App}>
	<IndexRoute component={Home}/>
	<Route path="Home" component={Home} />
</Route>);
var App = React.createClass({
	render: function(){
    return(

          <LeftNavigation/>

							{this.props.children}

    );
	}
});
module.exports = App;
ReactDOM.render(<Router>
	{myroutes}
</Router>,document.getElementById('app'));

On the other hand, if I used the following code, it works fine
ReactDOM.render(<Router>
	<Route path="/" component={App}>
	<IndexRoute component={Home}/>
	<Route path="Home" component={Home} />
</Route>
</Router>,document.getElementById('app'));

What am I missing here ?

Thanks for your question!
We want to make sure that the GitHub issue tracker remains the best place to track bug reports and feature requests that affect the development of React Router.
Questions like yours deserve a purpose-built Q&A forum. Would you like to post this question to Stack Overflow with the tag #react-router? https://stackoverflow.com/questions/ask?tags=react-router.
We also have an active and helpful React Router community on Reactiflux, which is a great place to get fast help with React Router and with the rest of the React ecosystem. You can join at https://discord.gg/0ZcbPKXt5bYaNQ46.


⚠ API - Lens has degraded performance

In f31e1eb, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 619 ms

Resolved: API - Lens performance has improved in 6c5f111 after 12 minutes.


There is a wrong

In the line 282
Its like that
self.log(f"{hijau}green}Farming started")
That wrong
It should be like this
self.log(f"{hijau}green Farming started")
And secend problem, that script can't play the gime 😞

Git pull

Same bro. The game didn't played

Wait for update payload


TinyMCE integration

hey guys,
here are the first caveat bumping up during my TinyMCE integration.
Custom Image plugin (to use FirebaseFileUploader !?)

i had to copy over the sources of the original image plugin because TinyMCE only takes an upload URL which won't work with the Firebase except you have a server which does the actual upload
by copying the sources, it also requires to rewrite slightly the image plugin to meet the TS rules in place
not only the image plugin has to be rewritten, it also comes with some dependencies which are then loaded twice. this can be prevented to build tinymce yourself which is needed anyways to get rid of the most built-in loaded code.

however, this penalties/overhead seems still ok to me and so I will go ahead for now.
Other issues :

editor controls such as the save button beneath the editor have to be done in higher component because for now I am only doing a React component which wraps TinyMCE and adds the needed plugins (image, file, whatever) and it takes a single property to setup all, ie: Editor variant={VARIANTS.SMALL|HOWTO|COMMENT|REPLY} handler={this:IEditorDelegate}

@BenGamma or @chrismclarke :
so I am ready for adding PP v4 specs (behaviour, presets). Mind the questions above...
![image](https://user-images.githubusercontent.com/1205100/52125841-02de8780-262e-11e9-8af4-
9327a67b4073.png)
It's working quite well and I managed to get the code in the way as I like, clean and less, see here for the code for above : https://github.com/tx4x/onearmy/blob/module--discussions/src/components/Editor/plugins/image/ui/Dialog.tsx
See you monday

more @todos:

add resize recommendation/actions as gmail (large, medium, small) when pixel/mb limit exceeded
clarify that original sizes should kept intact : should be
enable multiple uploads : i want it, tired of clicking around if it's not needed :-)
integrate preview for making next steps,  in discussion and how-to pages

This is all looking really promising! I'm away travelling for the next week but if you reach any sticking points just send a message with a direct mention and I'll try to prioritise it. Otherwise can't wait to put it to use!
In terms of deleting image there's a few ways to do it and I'm not particularly set on current implementation vs api endpoint, so if you come across a way you think it would be useful to have things done then just let us know and I can add it to the roadmap.

@chrismclarke : well, there is indeed something you may can enlighten me:
react-hooks (this what i use) requires currently whatever is in React@next right now. I have opened a pull-request for that but i am not sure we're on the same page about react-hooks. i guess the time v4 goes live, react-hooks should be ready for production, so we should be fine.
see why react hooks is the new way of doing FP like code : https://www.youtube.com/watch?v=wXLf18DsV-I
g

thanks @tx4x  for opening #252 for discussion on hooks, have added my comments there so we can keep this issue cleaner for TinyMCE

@mattia-io @chrismclarke
I need to know a few things to finish the editor component which is mainly preconfigured via presets here
The idea is to use the Editor via the property 'variant'. So I need to know what to disable for each module.
For instance :
module-disussion :
all base plugins,ie: undredo, tables, text formatting, insert image (s), mention, insert link, embedd media
module-how-to
step's description
base plugins : undredo, text formatting, insert link (other posts, howtows pickers)
question: no free inserting of pictures at any position, tables within the description ?
etc...etc..
Apart from the pre-configuration, these are still to do :

basic localization for save/cancel
network link went down, save in localstorage til back ?
where or how to show error messages (failed image uploads/removals)
focus management/policy for buttons or other widgets is missing
image oversize handling
image drop into editor
retrieve all users for the mentions plugin
retrieve all posts/how-to-pages for the link picker
multiple image upload
clarify max editor height / autoresize per variant
content parser for display only

fully forgot: more likely it's better to make a custom build of Tinymce, someone please create a repository ? Currently the OneArmy app is already pretty heavy and the Tiny build defaults add around 1MB ...

@mattia-io , @BenGamma
a list of all modules would be already enough for me to keep going. Of course I checked but I couldn't find modules for :

polls (any user)
machine upgrades/addons
user profile/space

and so all i see now is :

how-tow
discussion
comment
post

may be someone can point me to the final design ? thanks
g

Hey @tx4x , I understand your excitement about the plateform and your contribution is helpfull but please try to keep issues a bit organize here.
You are throwing a few different things and it is hard to follow you.
Next time create a proper issue for the thing you want to discuss or it will be lost in an ocean of comments.
To come back to the TinyMCE integration :

What is the undredo plugin you are talking about ?
Can you clarify your question :

no free inserting of pictures at any position, tables within the description ?

We are keeping everything in this repository for now.
Please understand that this project is still a massive work in project and that everything is not ready to build yet. If you cannot find a module it means that it is not ready for developement. For now if you want to keep on going, everything is in the issues list.

ok, never mind, i will go ahead as it fits :-)
please check the available plugins for TinyMCE on their demo pages.
g

Yeah that's quite a lot to get any head around! I've tried to group my responses by how I've interpreted the question.
1,6,9 - Features you're working on (assumed) -, great, keep us in the loop when things are done of if you need specific support
2,3,4 - Questions/decisions that haven't been made (assumed) - I would suggest implementing something simple in the first instance which we can later review and go back to the UI guys to see what improvements they suggest (as @BenGamma said above, some stuff in issues but still a long way to go on others)
5 - We have server-side image compression so assuming a non-issue.
7,8 - Retrieving data - Create a mock for now, add separate issue once done and I'll support best way to pull in what you need
10,11 - Not exactly sure what you mean, hopefully falls into one of above categories, if needs explicit input just let me know
12 - Created a fork which can be the base for a One Army custom editor here: https://github.com/OneArmyWorld/tinymce, although this will add considerable work as we would either need to add its build into the CI pipeline, or find a better way to host the dist version (e.g. publish to npm). I'll let you think about how you might want to do this and if required let's talk about in another thread.
I think before you try to take things too much further it might be good to put what you have into operation, and then base future development of a couple different threads (again as benji said, it's getting quite hard to fully follow this thread).

ok, thanks for the directions, deal !
Give me some days to roll out the next slices

PR to use editor in existing modules, controlled via presets set in the 'variant' prop
PR for custom TinyMCE build, basically just a collection of long-term apply-able patches and scripts. i don't expect to have this changed often, only for major TinyMCE updates but that happens once in 2 years, no worry.
single PRs and issues for all other points

I work in the next months half time on this and the other issues, the other half I am 5 meters away in the machine shop or just off time :-)
g

@chrismclarke : i think you can delete the tinymce repo because adding a script which downloads via git the tinymce sources, then applies the patches (remove plugs,...) and builds it on the fly seems more easy. this will add then of course some dev deps but that's still ok.
g

If not publishing a package with the version we want would it not be easier to just build the version we want offline and stick the output dist directly in assets or somewhere?

@chrismclarke , this is how it's done for now (official TinyMCE 4.9.3 build placed in public/vendor/tinymce) . I tried making a custom build yesterday but I came across various TS build errors, I suppose this is their way of pushing folks into their commercial version, at least this is the impression I've got looking at their github  activities.
However, I also made a loader for TinyMCE, which loads the script on demand (Editor:componentWillMount)
I'd say, lets forget about the tinymce build story altogether for now, there isn't much difference in script size to gain after all, and there is so much more work still : link/people/... picker, mention plugin etc..
g

I think that sounds sensible for the time being. Agreed on priorities


Question

Hello,
Is it also possible to convert all existing remotes from irdb and lirc to yaml ?
If not could you change the code so it loops through every remote listed ?
Because I would like to put this script on my VPS and let it generate the yaml files for all existing remotes in those databases and then upload them to github for everyone to use.

It's possible, sure. You can pull down all of irdb's codes from their github then run this script in a loop over every file.
But I don't recommend it because you're effectively maintaining a copy of those sites which will get out of date.
It would be better to write a website which queries those sites and then runs this tool in the background.
Even better, add it to irdb.tk's list of outputs.


Replaced netcoreapp2.1 with netcoreapp3.1 to fix obsolete test warnings

Funny how xunit suddenly triggers warnings when updating to netcoreapp3.1. Guess it needs more time to cook.

From the build log:
The given project `NLog` has no vulnerable packages given the current sources.
Project `NLog.UnitTests` has the following vulnerable packages
   [netcoreapp3.1]:
   Transitive Package      Resolved   Severity   Advisory URL
   > System.Net.Http       4.3.0      High       https://github.com/advisories/GHSA-7jgj-8wvc-jh57
   [net461]: No vulnerable packages for this framework.
The given project `SampleExtensions` has no vulnerable packages given the current sources.
The given project `NLogAutoLoadExtension` has no vulnerable packages given the current sources.
The given project `NLog.MSMQ` has no vulnerable packages given the current sources.
The given project `NLog.WindowsIdentity` has no vulnerable packages given the current sources.
The given project `NLog.Wcf` has no vulnerable packages given the current sources.
The given project `NLog.WindowsEventLog` has no vulnerable packages given the current sources.
The given project `PackageLoaderTestAssembly` has no vulnerable packages given the current sources.
The given project `ManuallyLoadedExtension` has no vulnerable packages given the current sources.
The given project `NLog.MSMQ.Tests` has no vulnerable packages given the current sources.
Project `NLog.Wcf.Tests` has the following vulnerable packages
   [netcoreapp3.1]:
   Transitive Package                    Resolved   Severity   Advisory URL
   > System.Net.Http                     4.3.0      High       https://github.com/advisories/GHSA-7jgj-8wvc-jh57
   > System.Text.RegularExpressions      4.3.0      Moderate   https://github.com/advisories/GHSA-cmhx-cq75-c4mj
   [net452]: No vulnerable packages for this framework.
   [net461]: No vulnerable packages for this framework.
Project `NLog.WindowsIdentity.Tests` has the following vulnerable packages
   [netcoreapp3.1]:
   Transitive Package                    Resolved   Severity   Advisory URL
   > System.Net.Http                     4.3.0      High       https://github.com/advisories/GHSA-7jgj-8wvc-jh57
   > System.Text.RegularExpressions      4.3.0      Moderate   https://github.com/advisories/GHSA-cmhx-cq75-c4mj
   [net452]: No vulnerable packages for this framework.
   [net461]: No vulnerable packages for this framework.
The given project `NLog.PerformanceCounter` has no vulnerable packages given the current sources.
Project `NLog.PerformanceCounter.Tests` has the following vulnerable packages
   [netcoreapp3.1]:
   Transitive Package                    Resolved   Severity   Advisory URL
   > System.Net.Http                     4.3.0      High       https://github.com/advisories/GHSA-7jgj-8wvc-jh57
   > System.Text.RegularExpressions      4.3.0      Moderate   https://github.com/advisories/GHSA-cmhx-cq75-c4mj
   [net452]: No vulnerable packages for this framework.
   [net461]: No vulnerable packages for this framework.
The given project `NLog.WindowsRegistry` has no vulnerable packages given the current sources.
Project `NLog.WindowsRegistry.Tests` has the following vulnerable packages
   [netcoreapp3.1]:
   Transitive Package                    Resolved   Severity   Advisory URL
   > System.Net.Http                     4.3.0      High       https://github.com/advisories/GHSA-7jgj-8wvc-jh57
   > System.Text.RegularExpressions      4.3.0      Moderate   https://github.com/advisories/GHSA-cmhx-cq75-c4mj
   [net452]: No vulnerable packages for this framework.
   [net461]: No vulnerable packages for this framework.
The given project `NLog.OutputDebugString` has no vulnerable packages given the current sources.
The given project `NLog.Database` has no vulnerable packages given the current sources.
Project `NLog.Database.Tests` has the following vulnerable packages
   [netcoreapp3.1]:
   Transitive Package                    Resolved   Severity   Advisory URL
   > System.Net.Http                     4.3.0      High       https://github.com/advisories/GHSA-7jgj-8wvc-jh57
   > System.Text.RegularExpressions      4.3.0      Moderate   https://github.com/advisories/GHSA-cmhx-cq75-c4mj
   [net462]: No vulnerable packages for this framework.

I'm confused. When building NLog.Wcf.Tests for .NET Core 3.1 I get:
NLog.Wcf.Tests.deps.json
But I build NLog.Wcf.Tests for .NET Core 2.1 I wont get the NLog.Wcf.Tests.deps.json.
Anyway in NLog.Wcf.Tests.deps.json I see:
      "NETStandard.Library/1.6.1": {
        "dependencies": {
          "Microsoft.NETCore.Platforms": "2.1.0",
           ....
          "System.Net.Http": "4.3.0",

So we need to manually bump System.Net.Http

--> try here: https://github.com/NLog/NLog/pull/4946

But I build NLog.Wcf.Tests for .NET Core 2.1 I wont get the NLog.Wcf.Tests.deps.json.

That explains why  .NET Core 2.1 doesn't produce the warnings, because it doesn't generate the output-file necessary to validate it.
Anyway I'm fine with leaving it as it, until xunit v2 is fixed, or xunit v3 is released.


[Bug] 0.4.0是还不支持qwen1.5 110b吗?

Checklist

[X] 1. I have searched related issues but cannot get the expected help.
[X] 2. The bug has not been fixed in the latest version.

Describe the bug
我用0.4.0的版本跑qwen110b的模型一直报错内存不足, --quant-policy 4也不行. 是目前还不支持吗?
我用vllm跑qwen110b PF16, GPTQ-Int4 都是运行正常的.
我的机器是8卡 v100 32G
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 2.32 GiB. GPU 7 has a total capacity of 31.73 GiB of which 848.44 MiB is free. Including non-PyTorch memory, this process has 30.90 GiB memory in use. Of the allocated memory 0 bytes is allocated by PyTorch, and 0 bytes is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)

Reproduction
lmdeploy serve api_server /Qwen1.5-110B-Chat --server-port 23333 --model-name qwen110b --tp 8 --log-level INFO --quant-policy 4
Environment
LMDeploy: 0.4.0+
transformers: 4.40.1
gradio: Not Found
fastapi: 0.110.3
pydantic: 2.7.1
triton: 2.2.0

Error traceback
No response

支持的

请看一下pipeline.md文档关于内存分配的说明

目前码表没有按TP切分，Qwen的码表特别大影响会比较明显。

会支持，不过没那么快，估计2周以后了。

Please try the latest version https://github.com/InternLM/lmdeploy/releases/tag/v0.5.1


dnscrypt-proxy on Openwrt crashes

Hi,
For some reason dnscrypt-proxy seems to stop and die once in a while, running on OpenWRT Linux  4.9.82 #0 SMP Sat Feb 24 15:12:57 2018 armv7l GNU/Linux
I noticed this in the logs
panic: runtime error: slice bounds out of range

goroutine 3244 [running]:
main.ReadPrefixed(0x13defb98, 0xe195aae5, 0xbea2fbcb, 0xa321dd88, 0xab, 0x5e93a8)
        /home/travis/gopath/src/github.com/jedisct1/dnscrypt-proxy/dnscrypt-proxy/common.go:67 +0x294
main.(*Proxy).tcpListener.func1(0x427d18, 0x13defb98, 0x119c01a0)
        /home/travis/gopath/src/github.com/jedisct1/dnscrypt-proxy/dnscrypt-proxy/proxy.go:174 +0xf8
created by main.(*Proxy).tcpListener
        /home/travis/gopath/src/github.com/jedisct1/dnscrypt-proxy/dnscrypt-proxy/proxy.go:166 +0x78

Is this a bug or a memory issue?

This is a bug that I think was fixed in ba2f43e6db22b35dd66061cc30dce591259db576


tools: remove swift-test-utils

This seems to have been introduced for SwiftSyntax which is no longer in
the tree.  No additional dependencies exist.  Clean up the dead code
which prevents cross-compilation of just the host tools.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@nkcsgexi, @jrose-apple - any objections?

None from me, go for it.


SMTP Connection failed

Tests are failing because there is an error connecting to the SMTP server. This is likely due to mailtrap not properly being configured in the project yet.

This issue was resolved my creating an account on mailtrap, creating an env file using the env.sample as an example and adding my mailgun details to it


Prepare a dataset for RL

Hi CARLA team!
My goal is to prepare a dataset to test a reinforcement algorithm. To achieve that goal it seems I can use one of the two scripts manual.py or client_example.py in autopilot mode. I read in one issue that the autopilot mode is not a good option for data collection? Can someone please clarify why?
If one need to use manual.py is it necessary to use joystick or logitech?
Thanks in advance.

Hey, what do you mean by dataset for RL ? Shouldnt you try to learn directly by interaction ?
I think the best way to perform data collection is to have an "oracle" a hardcoded programmed agent that has priveledge information and drive perfectly on the CARLA scenarios.

check this repository
https://github.com/carla-simulator/data-collector

It does not have bounding boxes on the image data directly. However it comes with semantic segmentation images and the world position for all the objects.


Add disabling contacts of particles with negligible motion

Description of the problem

Some DEM/CFD-DEM type of simulation has areas in their domain where particles are almost motionless, this results of irrelevant computation of contact list, contact forces and velocity integration where all particles are constantly vibrating in place
The potential of the calculation of the granular temperature was not fully exploited

Description of the solution

A feature that can associate status to cells regards the mobility of their particles has been implemented. When disabling particles' mobility is enabled, this feature is called after the "sort_particles_into_subdomains_and_cells"
The general idea behind the algorithm :

It uses the granular temperature to determinate if particles in a cell are mobile enough that the contact forces are worth computation. A cell having a granular temperature under a value (default is 1e-4) will have an inactive status which makes them rejected in the broad search step. This results in no contact forces or velocity integration in future steps for those particules, which make less computation cost for the simulation.
Cells may be flagged as that called mobility status : mobile (everything is calculated like if feature is not enabled), active (motionless particles next to mobile particles, see above) or inactive (particles are not in a neighbor’s candidate list of cells around)
There are some edge cases that need some attention. In these cases, particles in cells can't be deactivated :

The solid fraction of the cell is under a value (default = 40%) : particles in the cell may have other forces that can move them and it is supposed that with this fraction, there is not enough particles around to hold them in their position.
Cells having empty cell neighbors : it means that particles are next to a floating wall/mesh and they may have a change of contact forces from it if the wall disappears or is moving.
The cell has cell neighbors which is flagged as mobile from the 3 criteria mentioned above (granular temperature, solid fractions or floating walls) : this is because motion is badly propagated to particles to the cell around without this additional "layer" of mobile cells.
The cell has cell neighbors which is flagged as mobile from the previous criterion (additional layer of mobile cells) : this is again to allow the propagation of motion, but only the particles in contact with particles from the mobile cells are considered for the contact force calculation but their position is not computed at the integration step. Those cells are flagged as active cells.

- It works with the assignment and verification of the mobility status at nodes to check the status of the neighboring cells. (See in the comments section.)

How Has This Been Tested?

Computational gain is significative for the hopper case (2x faster) where some of the particles are motionless during loading and when there's an accumulation of particles at the bottom.
Mass flow rate results for the hopper have no significative difference (<1%)
An application test was developed to evaluate each case of status for dem_3d (mobility_status.output)

Documentation

No documentation for now : this feature will be improved in the future and tested more rigorously (especially for CFD-DEM) before.

Future changes

Enhancement of the feature integration in the code
Modification regards testing results interpretation in CFD-DEM
Add doc and maybe an example

Comments

A trivial version with checks to the neighbor cells state (and not the node status) was first made, but this results in issues using multiprocessing. Since there are at least 3 stages of information of cells (e.g., 1st cell from granular temperature value, 2nd cell from the additional layer of mobile cells and the 3rd from the active cells layer), having the data from the locally owned and ghost cells is not enough (only 2 stages of information is available in some case for a processor), we need to exchange information. To exchange this information, having information at nodes allows using the LinearAlgebra::distributed::Vector where data is exchanged with the easy call of update_ghost_values(). But this is harder to understand.
Functions in broad search classes (p-p, p-w, ...) are copy pasted and slightly modify to evaluate the cell mobility status. This doesn't look good, in my opinion, but this allows preventing lots of "if calls" for no reason when the feature is not enabled.
Open to better suggestions of the names (mobility status, disabling contact of particles etc), I will rename files or functions.

@voferreira @blaisb
I did most of the modifications suggested by you guys :

Change the vector of set to a unordered map
Add more comment in the code
Change the logic for the verlet integrator
Change the parameter subsection for disabling contacts

What I have to do :

Add "official" doc for parameters (it won't be very explicit)
Add an application test for load balancing with disabling contacts (or I will remove this feature from this PR I think)

About the suggestion to change the mobility_status from enum to enum class, I really don't know. The core of the node-based algorithm is kinda designed on integer comparison at node values. For me, using integers with a name was kinda convenient since we manipulate integers, but we read names (mobile, active, inactive). If you think this is bad programming or I should not do that, I can change it, but in my opinion, it's not that bad and changing it seems less clean (but not impossible). Let me know. Also, I replied to all the comments, the ones still unresolved are the one that I would like feedback or are responses to suggestions, feel free too resolve if there's nothing to say or to do.
Thanks a lot for your precious feedbacks!

The following test crashed on debug on my machine
dem_3d/load_balancing_mobility_status.mpirun=2.debug
99: ##331     #:1   <== dummy
99: ##331     #:1   ==> 1
99: @                                                     @@
99: ##331           <==
99: ##331     #>2   ==> 8
99: @ Line 331 in file "/home/blaisb/work/lethe/lethe/lethe/applications_tests/dem_3d/load_balancing_mobility_status.mpirun=2.output" is shorter than expected!
99: ----------------
99: ##332     #:1   <== 1
99: ##332     #:1   ==> 0
99: @ Absolute error = 1.0000000000e+0, Relative error = Inf
99: ##332     #:2   <== 8
99: ##332     #:2   ==> 0
99: @ Absolute error = 8.0000000000e+0, Relative error = Inf
99: ##332           <==
99: ##332     #>3   ==> 0 0 0 0 0 0
99: @ Line 332 in file "/home/blaisb/work/lethe/lethe/lethe/applications_tests/dem_3d/load_balancing_mobility_status.mpirun=2.output" is shorter than expected!
99: ----------------
99: ##333     #>1   <== 0 0 0 0 0 0 0 0
99: ##333           ==>
99:

Ok, everything should be fixed! :dancers:


Copyright transfer

Summary
This patch simply transfers copyright of this module from myself to Greg Nutt.
Impact
Testing

Hasn't Dave already provided an ICLA?
I recall Justin McClean saying that an ICLA is not required for a single file or for small changes.  The ICLA would transfer Copyrights to the ASF (not me).  I am no attorney, but believe that Dave is fully within his rights to re-assign the Copyright in this way.
Since I have provided an SGA, would it make sense to go directly to the Apache header?  Or is it better to leave the history trail of copyrights:  Dave -> Me -> ASF?  I think the latter.

I think that is better to have the copyright trail Dave ->you >Apache


[WIP] Docker Container labeling docs

Still need to update calicoctl node run reference page

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Fixes #472

I don't particularly like the name "Simple Profile Policy". Profiles and Policies are two different objects in the Calico data model. I understand that we're using "Policy" here to mean general networking policy. But I wonder if there's a different word we can use so as to not confuse users.

Simple Profile Security?
Simple Security with Profiles?

Open to other suggestions

How about for the 3 different tutorials these names

Security using Calico Profiles
Security using Calico Profiles and Policy
Security using Calico Labels and Policy

I like it a lot. I'd revise the third one though, it's not "Calico Labels". Maybe

Security using Calico Label-based Policy

?

Security using Calico Label-based Policy
Could work but I feel like that could also describe the "Profiles and Policy" page too, what about
Security using Docker Labels and Calico Policy

I suppose they are "Docker Labels", so that sounds good.

This will need to be merged into the v2.1 dir too as part of this PR.

Last two comments, then LGTM


Performance improvement for CFB on 3.0 branch

There has been a performance enhancement patch added to openssl 3.1 and master branch.
https://github.com/openssl/openssl/pull/18267
When this patch is added to openssl 3.0.8 tag, performance enhancement is also seen on 64bit openssl build on AIX.
This issue is reported to include the above pull request onto 3.0 branch.
Please let me know if I need to request a separate pull request for it ?
Thanks

Our stable release update policy explicitly rules out performance enhancements being back ported, so this isn't going to happen.

The fix is fairly trivial and should be safe. So IMO we should at least discuss within OTC whether we want an exception for this.

Thank you.
To add on, we are seeing close to 50% improvement with this patch when measured through openssl speed command.
With Openssl 3.0 having LTS, it gives us more flexibility to have it in 3.0 branch than 3.1 branch.

OTC: we will hold a vote for this.

Removing the "won't fix" label.
The vote was held and passed (i.e. allowing a backport):
https://github.com/openssl/technical-policies/issues/70
I can't find a record of the backport actually occurring though.
@t8m - since you proposed the vote, do you recall if anything further happened about this?

@mattcaswell Created https://github.com/openssl/openssl/pull/23463 - please approve

#23463 was merged to 3.0 branch.


Added new JUnit tests for password and find features

Pull Request Test Coverage Report for Build 341

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 71.433%

Totals

Change from base Build 340:
0.2%

Covered Lines:
2288

Relevant Lines:
3203

💛  - Coveralls


Remove unnecessary dependencies in favor of native

Given that these features have been supported in NodeJS for years, it
would be better to remove them as dependencies. This is better for
maintances, performance, and security.

This has been designed to work on node >= 0.8


Missing act event id 40

Describe the bug
We're missing parsing, docs, implementation, etc for act event id 40.
Here are some examples of this line:
40|2022-02-09T20:09:55.2440000-06:00|722|The World Unsundered|The Fervid Limbo||0ef3e05a8b4d07ed
40|2022-02-09T20:10:09.4740000-06:00|722|The World Unsundered|The Fervid Limbo||36b37746522a69c1
40|2022-02-09T20:32:13.0510000-06:00|193|The Black Shroud|The Lavender Beds|The Lavender Beds Subdivision|4f44898aa006e166
40|2022-02-09T20:40:16.4290000-06:00|731|The World Unsundered|The Sanguine Limbo||dd7ced0fe5c70831
40|2022-02-09T20:41:00.6750000-06:00|731|The World Unsundered|The Sanguine Limbo||63ece5b3a40da39c
40|2022-02-09T22:42:17.8380000-06:00|193|The Black Shroud|The Lavender Beds|The Lavender Beds Subdivision|dd5786198b3dc7e5

They look like additional zone information (similar to ActEventType.zonechange).
To Reproduce
Attempt to run through any log with raise_on_invalid_id turned on:
for event in ActLogReader(path_to_log_file, raise_on_invalid_id=True):
    pass

Expected behaviour
This is either noop'd in the mapping file or parsed correctly.
Additional context
I'd say the real treasure is the friends we made along the way, but it seems like the universe conspires to make me question that most of the time.

There's been some changes in ACT around this. The old ZoneChange was renamed to Territory but still does the same thing. This new event is called ChangeMap (idk why "change" was inverted here, makes less sense this way), and the structure is MapID|PlaceNameRegion|PlaceName|PlaceSubName, the latter 3 of which can be dereferenced from the Map ID in game EXD data. I expect this still comes from memory since the Map.ID isn't something generally exposed in packets, they usually use Territory stuff instead.


Adjust reference scripts to make pre mRNA fasta needed to generate index

These files include updates needed to generate a pre-mRNA index for single-nuclei RNA sequencing with alevin and kallisto, see #54. Before actually making the index, we need to create an expanded fasta file that includes the sequences for unspliced and spliced mRNA to use to build the index.
I followed the steps in the Alevin tutorial here and after some reading of this preprint it appears that we should be able to use this pre mRNA fasta to generate both a salmon and kallisto index.
In order to do this, I needed to update the dockerfile for images/scpca-r which I have done and it is currently able to be pulled from github using docker pull ghcr.io/alexslemonade/scpca_r:v2.  I also updated the reference files that are being used to the most recent release - ensembl-103 and have created a new directory in  s3://nextflow-ccdl-data/reference/homo_sapiens/ensembl-103. I'm not entirely sure how necessary this is, but while I was working on this I went ahead and did this.
The script to actually generate the fasta file, make_pre_mrna_fasta.R currently runs on it own and generates the necessary output files, but when run inside the container, it stops mid script, failing in the middle of the eisaR::getFeatureRanges call without any error... I'm going to continue to try and troubleshoot this, but also in the meantime, I will make sure that the nextflow processes are updated for actually building the mRNA index using the output since having the indexes built is the ultimate goal. It does appear to me that this is an error with running the script in the container and not an error with the script itself since it is able to run independently of the container, unless I'm missing something.

For now, I am not running this inside the docker container. Additionally, I merged the build_tx2gene_mito.R and make_pre_mrna_fasta.R into one script, also removing the dependence on AnnotationHub. The expanded fasta and Tx2Gene.tsv is created from an input gtf (currently ensembl-103) and then synced to S3 for use in creating the index, which I will add in a separate PR.
I grabbed both the spliced and unspliced transcripts to create the expanded files used for snRNA-seq and then subset to only the spliced transcripts for the main Tx2Gene.tsv used in alevin for scRNA-seq.

Oh, that was not my interpretation. I was expecting that tximeta import would result in a SingeCellExperiment matrix with two rows for each gene: one ENSG000 and one ENSG000-I; The splitSE turns that into two congruent matrices of half the size, labelled with the ENSG000 for each gene. As far as alevin was concerned, those were two different genes, so it quantifies them separately, and we would have to collapse them ourselves (but splitSE makes this simpler).

Okay so it looks like according to the way that alevin is using tximeta and splitSE there are 3 assays in the final summarized object. a) a counts assay, which theoretically is going to contain the gene x count matrix separating out the counts by intron vs. exon, b) a spliced only counts matrix, and c) an unspliced (i.e. intron reads) only count matrix. So I think what you are saying and how our ultimate gene x counts matrix can be computed is by doing what you said earlier about splitting the original counts assay into spliced and unspliced and then summing the counts that correspond to the same gene. The question is can we also do this for kallisto and based on my naive understanding of kallisto I think we could?
All that being said, I think the approach here is to follow a similar approach to the alevin tutorial and produce the following reference files:
To be used for snRNA-seq:

spliced + introns fasta
spliced + introns gtf
spliced + introns Tx2Gene mapping

To be used for scRNA-seq:

spliced only fasta (i.e. txome.fa)
spliced only gtf
spliced only Tx2Gene

For QC:

mitochondrial gene list

The question is can we also do this for kallisto and based on my naive understanding of kallisto I think we could?

I think so too, but we will probably have to do some finagling to parse things out. (Or maybe we can use BUSpaRse to smooth things a bit).
I think your plan sounds good, I would just add that we will want to output the metadata(grl)$corrgene table with the snRNA-seq annotations to ease later parsing (I'm sure we could generate it on the fly, but that seems unnecessary).
A couple other comments as you finalize this:

It is probably worth compressing the gtf file & fasta files. It looks like the main output functions won't do that, so we should add that to the wrapper function before syncing to s3.
Do we want to put the fasta files in the fasta directory? I can't say why I kept them separate from annotations before, but we should be consistent somehow...
Does the spliced gene list have every gene, including noncoding genes? I ask because I assume that those are less likely to have introns, and I just don't know what the eisaR package is doing there. I hope that it keeps everything, and single exon genes just have a corresponding "intron" gene with no transcripts, but I fear that they might be dropped. We should do a quick sanity check comparing the gtf (and fasta?) generated by eisaR for spliced only transcripts with the txome gtf from ensembl.

The scripts have now been updated to include the following outputs.
To be used for snRNA-seq:

spliced + introns fasta
spliced + introns gtf
spliced + introns Tx2Gene mapping
spliced mrna + introns metadata table

To be used for scRNA-seq:

spliced only fasta (i.e. txome.fa)
spliced only gtf
spliced only Tx2Gene

For QC:

mitochondrial gene list

I have also modified them to include compressing the fasta and gtf files. The fasta files can be compressed as they are exported using Biostrings::writeXStringSet, but the gtf files will need to be compressed in the get-refs.sh wrapper.
That being said, I have also added in a notebook in analysis that compares the fasta and gtf files that we get when directly fetching from ensembl vs. grabbing just the sequences corresponding to spliced transcripts using eisaR::getFeatureRanges.  The analysis is fairly surface level and mainly looks at the intersection of transcript ID's in both the fasta and gtf files, but it is clear that we are missing some transcripts that correspond to both ncRNA and protein coding transcripts. In terms of trying to make sure we are not veering too far of course (from the public standard and in terms of time spent), it seems like we should be sticking with the indexes we have originally made for scRNA-seq and removing those parts of the script, but am definitely open to other suggestions if people have them.

I don't particularly care if you use stringr::word from my other lingering suggestion, but the other things should get done before merging.

Sorry I missed that in the previous review. It's incorporated now along with the other changes. All the files should be synced and on AWS now as well.


Device Provisioning Service

Description

Re-opening device provisioning service PR due to swagger name changes.  https://github.com/Azure/azure-rest-api-specs/tree/master/specification/deviceprovisioningservices/resource-manager
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@shahabhijeet is it possible to get someone assigned to review this PR? The initial PR was opened mid December and closed due to requested changes to Swagger naming.


Site doesn't work on mobile properly.

Playground is hard to use. Can't enter text easily.

Ok, i fixed the sidebar (missing js for semantic ui) and removed the download button (it does exactly the same that "Get Started" button), that should fix the first and last issue.
As for the playground, i will see later, i don't have my phone at hand

Good work @TheBITLINK

Maybe there should be a mobile version called Anything Anywhere

@tu-maurice I like the way you think


[File Explorer] keyboard shortcut not working

Environment
Microsoft Windows [Version 10.0.19041.208]
Steps to reproduce
press alt + p in file explorer
Expected behavior
previe panel should show up;
Actual behavior
previe panel should dont't show up in place of it folder options show up
Screenshots

sorry for polish names

we don't do anything to this keystroke.  do you have AHK or something that could cause this?


Wrapped governance tokens need to rely on underlying() for total supply

Overview
When using a wrapped governance token, we need to rely on the underlying token (underlying() function) for getting the total supply of the token.
Also, for proposal details specifically, we should be using the votingSupply on the proposal strategy struct, not the current total supply:
https://github.com/decent-dao/fractal-contracts/blob/develop/contracts/azorius/LinearERC20WrappedVoting.sol
Additional Info
Here is an example of a wrapped governance token, with 0 total supply, since nothing is wrapped:
https://app.dev.fractalframework.xyz/daos/0x1d53C00c8b7FD7af9B370F464eF86BDf6324fa01/proposals/0
https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/master/contracts/token/ERC20/extensions/ERC20WrapperUpgradeable.sol
Version
Dev (app.dev.fractalframework.xyz/)

Stale, closing


Format/Indent all source code files that are a part of charmxi (xlat-i)

Original issue: https://charm.cs.illinois.edu/redmine/issues/1535

The indentation for the source code files in src/xlat-i is quite messed up and non-uniform with different regions of tabs/spaces. Fix the indentation of all the source code files with standard indentation. (2 white spaces maybe). This can be quite easily done with a good editor.

Original date: 2017-04-24 15:23:38

This patch include a clang-format file that can be used to do this automatically: ~~https://charm.cs.illinois.edu/gerrit/#/c/1255/~~ https://github.com/UIUC-PPL/charm/commit/274ff61afe68ac95ec4617ee08b52c131a390067

Original date: 2017-04-25 01:34:23

Used clang-format to format all .C and .h files in src/xlat-i/
Fix: ~~https://charm.cs.illinois.edu/gerrit/#/c/2429/~~ https://github.com/UIUC-PPL/charm/commit/4c92dc300c4f7110fa6943ed89f297d5b50d5de8

Original date: 2018-01-19 15:55:27

Fix: ~~https://charm.cs.illinois.edu/gerrit/#/c/2429/~~ https://github.com/UIUC-PPL/charm/commit/4c92dc300c4f7110fa6943ed89f297d5b50d5de8


Avoid symmetric parameter in ifft()

The symmetric option is used currently in interpolate_ir(), compare also #130,  and modal_weighting(). Under Octave this option is not available for ifft(), which means we have to replace it.
One solution might be to replace it by real(ifft(spec)); as it is done in signal_from_spectrum(). I guess one problem might be that this will be not as fast as the other option.
@chris-hld could you please test the performance of interpolate_ir() with the old symmetric option and the real(ifft()) version.

For general signals, the performance is surprisingly similar and fast. For the example I tested (4 channels of a few seconds input), I could not reliably tell, which one is faster.
I am still a bit worried about the output though, since it can be quite different.
As long as everything is correct there shouldn't be any imaginary part in the first place. 'symmetric' restores and corrects the input, while real() just discards everything.

There is a bug somewhere in interpolate_ir()!
The remaining imaginary part of ir is around 0.3 -- this is definitely not round-off errors.
I'll have a deeper look at it, any ideas?

https://github.com/sfstoolbox/sfs-matlab/pull/153

Just for testing, I implemented a version with an extra function that checks for Octave and uses than real(ifft(...)). Under Matlab still ifft(...,'symmetric') is used: #154

https://github.com/sfstoolbox/sfs-matlab/pull/155

Solved by #155


Remove PHPStan setting and improve related script

Changed log

Removing empty PHPStan configuration file and improve related script.
The PHPStan will not report phpstan.neon config file not found issue now.

I think I want to keep this file because in phpstan 1.x we may need it to define the level and to disable some checks.

Here are some approaches about defining PHPStan versions:

"phpstan/phpstan": "0.* || 1.*"
"phpstan/phpstan": "1.*"

Which above one that we need to choose?

This: "phpstan/phpstan": "^1"

After upgrading PHPStan to v1, I got following error:
> phpstan analyse src tests --level=max -c phpstan.neon --no-progress --ansi
 ------ ----------------------------------------------------------------------
  Line   src/BasePathDetector.php
 ------ ----------------------------------------------------------------------
  57     Parameter #1 $path of function dirname expects string, mixed given.
  81     Parameter #1 $url of function parse_url expects string, mixed given.
  82     Parameter #1 $path of function dirname expects string, mixed given.
 ------ ----------------------------------------------------------------------

The parameters src tests --level=max should be remove and defined within the phpstan.neon file.
For example:
parameters:
    level: max
    paths:
        - src
        - tests

The shown phpstan warnings can be fixed in another PR.

I've done for phpstan.neon file and phpstan script in the latest commit.
I think these above error reported by PHPStan should add ignoreErrors setting on the phpstan.neon file?
But I think above problem can be resolved by my another PR :).

Thanks!


Date fields

Add date fields like created and last edited to posts

Great idea - these are available on the REST API.
Is this adding these to the post template or to the search.json or both?

I added the Date field to the post list and the post page.
We probably only want to add the Last Edited to the Post Page, not on the homepage or archive list
we also want to definitely include these in the search index created in search-index-compiler so we can sort on them


Integration Test - Release - 2019/05/16 11:40:16

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@adunndevster : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@adunndevster : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Please add a license

Is this abandoned?   I hope not, thanks for your previous work.   If it is could you add a license so somebody else can pick it up?   Preferably Apache 2.0, MIT, BSD.

It's Apache 2.0 see
http://www.jpatterns.org/license/

Indeed, Apache 2.0.  A bit of history:  We wrote all the code really quickly back in 2010 and since it is primarily used for documentation, didn't see need for much in terms of changes.  But please feel free to contribute!  I use these a lot to teach my Design Patterns Course (http://www.javaspecialists.eu/courses/dpc.jsp and https://vimeo.com/ondemand/javadesignpatternscourse) and they are intended primarily for documentation purposes.  Some of my clients use them internally to document their patterns usage.


Is Kestrel a necessary for MQTT server?

Describe your question
I see the samples in ASP.NET Core Integration and https://github.com/dotnet/MQTTnet/blob/master/Samples/Server/Server_Asp_Net_Samples.cs all have useKestrel. Currently our project doesn't use Kestrel and we want to integrate MQTT. I want to know if we must use Kestrel for this project.
Which project is your question related to?

Server

I have found that we already use Kestrel.