add cjs/esm compatibility

Fixes #3 and #13
Adds an optional module.exports CJS export which can also be comsumed by both CJS require and ESM import.

@LingDong- You'll need to publish the new version to npm as well. Thanks

Hi @LingDong-
It seems like the new changes have not been reflected in the 0.0.4 npm release, and my bundler is rejecting the import. Could you fix this?
Thanks

sorry about that! my mistake. Just published 0.0.5


Flag generic route as fallback instead of using middleware to inject #70

Putting this out as an alternative to the middleware injection of the generic route.  But - this solution has its own issues.  While it leverages the ->fallback() method to flag the route as a fallback, the way laravel implements fallbacks is by simply sorting ALL routes flagged as a fallback so they come last (actually not even a sort - it partitions non fallback and fallback routes then merges the fallback routes back onto the non fallback routes making them last).  Because of this, there is no way to control the ordering within the fallbacks themselves.  So, if there are multiple packages with fallback routes, OR the app registers its own fallback route (which uses a .* pattern to match everything) this solution could suddenly stop working / stop serving pages and posts because some other fallback route is being matched.
Looking at the classes that implement the fallback sorting logic, it would be difficult to customize the laravel behavior via a modified class override in the container.

How would this approach differ from our current approach in regard's to @jasonmccreary's questions (https://github.com/drewroberts/blog/issues/70) here:

Are application fallback routes called when package is installed?
Can package routes leverage fallback routes in some way?
Can package routes be cached?
Does any of the above change with or without Nova installed?

It deals with the last 3 --- but not the first.  That would require some type of predictable sequencing when an app also defines a fallback route is the big issue I'm calling out in the original description.   Depending on how the fallback routes end up being ordered, it will either behave the same as the current solution (stealing all 1, 2 or 3 segment routes for blogs) or, it won't work at all and the blog page and post routes stop working completely.

I should add - the only route not cached is the single generic route and not caching a single route isn't really a big deal (item 3) and the current solution does require Nova to be installed because the middleware is extending an existing Nova class (item 4).  But, nova is a stated dependency for all of these packages.
So, this PR really only addresses item 2 - item 3 and 4 don't need any resolution.

Ultimately this may not be a problem with needs a solution. Unless there are other issues arising, I'd continue to leave the current code in place and revisit this at the end.


feat: add docker verdaccio 4 release blog

What's new in Verdaccio 4 (Docker Image)
This is just small article that will be part of the V4 release.

Thanks @s-h-a-d-o-w @stackdumper for the CR 👍

Thanks @stackdumper . I'll merge on May 13th.

argggggg I'm so 😡 with myself. I did not want to squash :( sorry.

Ah, take it easy. :smile:
I for one expected you to do that, since it was fragmented into so many tiny commits.
What I did find a bit surprising since I've never used suggestions before was that git (or github, I suppose) includes the co-author in the generated commit message but not the authors. Seems like something that should be fixed?

I think the commit itself is authored by the user that suggests the commit, seems normal I guess.

Yes but why does git discard that information when it generates the message for the squashed commit but obviously retains that about co-authors?


[COMPILING FROM SOURCE] Cabal build fails - No instance for (Read StdGen)

Context
When trying to compile cardano-wallet using cabal I'm getting the following error:
src/Cardano/Wallet/DB/Sqlite/Types.hs:575:24: error:
    • No instance for (Read StdGen)
        arising from a use of ‘fromPersistValueRead’
    • In the expression: fromPersistValueRead
      In an equation for ‘fromPersistValue’:
          fromPersistValue = fromPersistValueRead
      In the instance declaration for ‘PersistField StdGen’
    |
575 |     fromPersistValue = fromPersistValueRead
    |                        ^^^^^^^^^^^^^^^^^^^^
cabal: Failed to build cardano-wallet-core-2021.4.28 (which is required by
exe:local-cluster from cardano-wallet-2021.4.28, test:integration from
cardano-wallet-2021.4.28 and others).

tried ghc 8.10.2 and 8.10.4
Essential Information

Version:      cardano-wallet release/tag  v2021-05-26
Platform:    Linux (Ubuntu 20.04)
Installation: from source
Network:  any

Steps to Reproduce

git clone https://github.com/input-output-hk/cardano-wallet.git
git fetch --all --recurse-submodules --tags
git checkout tags/v2021-05-26
cabal configure --with-compiler=ghc-8.10.4
cabal build all

Expected behavior
I expect it to compile succesfully
Actual behavior
I get the following error and compilation fails:
src/Cardano/Wallet/DB/Sqlite/Types.hs:575:24: error:
    • No instance for (Read StdGen)
        arising from a use of ‘fromPersistValueRead’
    • In the expression: fromPersistValueRead
      In an equation for ‘fromPersistValue’:
          fromPersistValue = fromPersistValueRead
      In the instance declaration for ‘PersistField StdGen’
    |
575 |     fromPersistValue = fromPersistValueRead
    |                        ^^^^^^^^^^^^^^^^^^^^
cabal: Failed to build cardano-wallet-core-2021.4.28 (which is required by
exe:local-cluster from cardano-wallet-2021.4.28, test:integration from
cardano-wallet-2021.4.28 and others).

Resolution
QA

The team mostly use Stack and Nix for building the project. We try to maintain build for Cabal along the way but few things might have broken in the cabal build with the various updates for Alonzo.
This will get addressed eventually, but for now it's better if you stick with stack. It seems that cabal is picking either and old or too recent version of persistent somehow.
Note that It's surprising that the CI automated jobs didn't catch that? cv @rvl

For any questions about building with stack, please refer to: https://github.com/input-output-hk/cardano-wallet/wiki/Building#stack
Alternatively, you may also get a precompiled binary or a docker image to avoid building yourself from sources (unless this is specifically what you want).

For any questions about building with stack, please refer to: https://github.com/input-output-hk/cardano-wallet/wiki/Building#stack
Alternatively, you may also get a precompiled binary or a docker image to avoid building yourself from sources (unless this is specifically what you want).

Thank you, I am writing a documentation about Cardano Components so I'm trying all the options. But looks like I'll just recomend using stack for now when dealing with cardano-wallet.

I also found this related issue: https://github.com/input-output-hk/cardano-wallet/issues/2579

It's due to changes in random-1.2.0.
Cabal picks whatever versions are newest according to its local index state, and any package version contraints.
Stack uses curated "LTS snapshot" package sets.
So there are often slight differences between dependency versions, depending on which build tool that you use.
Here is a workaround for Cabal:
$ cabal configure --constraint="random<1.2"
$ cabal build all

There is only a cabal configure test in CI at them moment. Because the packages are already built once with stack, then again with nix. But we can add a nightly cabal build test to pick up these issues.

Thank you so much for the answer, much appreciated!

It's due to changes in random-1.2.0.
Cabal picks whatever versions are newest according to its local index state, and any package version contraints.
Stack uses curated "LTS snapshot" package sets.
So there are often slight differences between dependency versions, depending on which build tool that you use.
Here is a workaround for Cabal:

$ cabal configure --constraint="random<1.2"

$ cabal build all

There is only a cabal configure test in CI at them moment. Because the packages are already built once with stack, then again with nix. But we can add a nightly cabal build test to pick up these issues.


Less verbose unit types

Please make all pull requests on the dev branch.
Don't commit build files
Try to get all tests to pass.

Use template literal types
Use recursive conditional types for type MidiNote
Makes it less verbose and doesn't take half the screen.

This is awesome! super late reply, but great improvement


related.IDKotum undefined

I got this error when i'm test the models. Fyi, i'm using mysql
related.IDKotum undefined

This happens only for table that use 2 same foreign keys
for example sample.sql
use Sample;

CREATE TABLE `SampleMain` (
  `id_kota` int(11) NOT NULL,
  `sequence_number` int(11) DEFAULT NULL,
  `name` varchar(45) COLLATE utf8_unicode_ci DEFAULT NULL,
  PRIMARY KEY (`id_kota`)
  ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

CREATE TABLE `Detail` (
  `id_harga_detail` int(11) NOT NULL,
  `source_id` int(11) DEFAULT NULL,
  `dest_id` int(11) DEFAULT NULL,
  `harga` double DEFAULT NULL,
  `create_at` datetime DEFAULT NULL,
  `update_at` datetime DEFAULT NULL,
  PRIMARY KEY (`id_harga_detail`),
  KEY `fk_list_asal_idx` (`source_id`),
  KEY `fk_list_tujuan_idx` (`dest_id`),
  CONSTRAINT `fk_detail_asal` FOREIGN KEY (`source_id`) REFERENCES `SampleMain` (`id_kota`) ON DELETE NO ACTION ON UPDATE NO ACTION,
  CONSTRAINT `fk_detail_tujuan` FOREIGN KEY (`dest_id`) REFERENCES `SampleMain` (`id_kota`) ON DELETE NO ACTION ON UPDATE NO ACTION
) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;

After the models generated, i got the error when i test the models.
*ps, could you create topic on stackoverflow.com please ?? My reputation not enough to create new topic/tag.
**ps : sorry for my bad grammar

Yes, the problem here is that "kota" according to our pluralization library is the plural of "kotum". So it tries to singularize your column name in one area and that breaks it.
We will most likely fix this by tomorrow and release a minor version update to deal with it. For now you can apply this patch:
diff --git a/strmangle/inflect.go b/strmangle/inflect.go
index 78945b6..8499bda 100644
--- a/strmangle/inflect.go
+++ b/strmangle/inflect.go
@@ -184,5 +184,6 @@ func newBoilRuleset() *inflect.Ruleset {
        rs.AddIrregular("move", "moves")
        rs.AddIrregular("zombie", "zombies")
        rs.AddIrregular("cookie", "cookies")
+       rs.AddUncountable("kota")
        return rs
 }

One reason I'm asking you to try this patch, is to see if you can find any other problems before we release this patch. Better to fix many problems at once :)

Well, thanks for fast response. Maybe i need to try more. And of course , i need
"more documentation"  :)
How to deal with null.*Datatypes  ?
I don't see on your documentation , any explanation about this.
for example  this is the model:
`type OkAkun struct {
	IDAkun      int         `boil:"id_akun" json:"id_akun" toml:"id_akun" yaml:"id_akun"`
	Username    null.String `boil:"username" json:"username,omitempty" toml:"username" yaml:"username,omitempty"`
	PhoneNumber null.String `boil:"phone_number" json:"phone_number,omitempty" toml:"phone_number" yaml:"phone_number,omitempty"`
	Email       null.String `boil:"email" json:"email,omitempty" toml:"email" yaml:"email,omitempty"`
	CreateAt    null.Time   `boil:"create_at" json:"create_at,omitempty" toml:"create_at" yaml:"create_at,omitempty"`
	UpdateAt    null.Time   `boil:"update_at" json:"update_at,omitempty" toml:"update_at" yaml:"update_at,omitempty"`
	Password    null.String `boil:"password" json:"password,omitempty" toml:"password" yaml:"password,omitempty"`

	R *OkAkunR `boil:"-" json:"-" toml:"-" yaml:"-"`
	L OkAkunL  `boil:"-" json:"-" toml:"-" yaml:"-"`
}`

And when i try to insert,
i got error's like this, (this happen on all null.*Datatypes )
cannot use<EMAIL_ADDRESS>(type string) as type null.String in field value

Can you show the line that's causing this? Also check out the documentation for the null package we use: https://godoc.org/gopkg.in/nullbio/null.v6
This shouldn't happen unless there's some problem with the struct generation. Can you show me the "show create table" from mysql for that table? Alternatively show the relevant part of the output when you run sqlboiler --debug mysql

This is the Sql :
CREATE TABLE `OkAkun` (
  `id_akun` int(11) NOT NULL AUTO_INCREMENT COMMENT '	',
  `username` varchar(45) COLLATE utf8_unicode_ci DEFAULT NULL,
  `phone_number` varchar(45) COLLATE utf8_unicode_ci DEFAULT NULL,
  `email` varchar(45) COLLATE utf8_unicode_ci DEFAULT NULL,
  `create_at` datetime DEFAULT NULL,
  `update_at` datetime DEFAULT NULL,
  `password` varchar(45) COLLATE utf8_unicode_ci DEFAULT NULL,
  PRIMARY KEY (`id_akun`)
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci

I also asked for the line of code that is causing the error, that is essential in order to figure out what's going on :)

I've update my comment

Yes, you have to use the null package helpers. I suggest null.StringFrom: https://godoc.org/gopkg.in/nullbio/null.v6#StringFrom
a := &models.OkAkun{
  Username:    null.StringFrom("bxcodec"),
  PhoneNumber: null.StringFrom("882292348292"),
  Email:       null.StringFrom("bxcodec@gmail.com"),
}
if err := a.Insert(db); err != nil {
  log.Error("Failed TO Insert Akun", "err", err);
}

But the bigger problem is that you should NOT have these as nullable in your database. That's a very bad database design, please change your table so that these fields cannot be null.

Yeahh... I just figured it after i do  show create table . But, look for the positive, now i can deal with the null-able column :D
Thanks for the response, and I hope, this is also documented as soon as the development process.


Logging Library

Consider using a logging library like pino.
This could help to visually emphasize logs from different types like INFO, DEBUG or ERROR.

actually not really needed, because logging should not be done in the application calling geoserver-node-client


 You don't want that in your house... do you?!

So, looking into this further, I’m actually not sure what I can do about it. Here’s the source image that I uploaded to YouTube:

As you can see, the eyes are perfectly solid. I think we’re seeing the result of some kind of weird resampling or compression setup that YouTube is using. I’m open to suggestions on what I can try!


Update icon size

Describe the bug
Incorrect icon size. The icons used here should all be 32x32px in size. Looks like they are only 24x24px in size.
Expected behavior
Should be 32px x 32px

Screenshots
If applicable, add screenshots to help explain your problem.

@Laurendragonscale Is it intentional that the sizes for these icons are different for the Video and Sound components? They are 24px on the Video component on Figma. Just want to confirm.

@kaseyvee I think the size should be updated for both the media components.


Unnecessary locking of the AppLockActivity

Hi! I encountered some strange (in my opinion) behavior. When I'm starting the AppLockActivity to change pin-code or disable I need to enter pincode first to enter this activity. I think this is unnecessary, because If I already in place from where I starting this activity means I was able to pass the lock previously.
I think check at line 313 of AppLockImpl is not needed:
 @Override
    public boolean shouldLockSceen(Activity activity) {
...
        // already unlock
        if (activity instanceof AppLockActivity) {
            AppLockActivity ala = (AppLockActivity) activity;
            if (ala.getType() == AppLock.UNLOCK_PIN) { // THIS ONE
                Log.d(TAG, "already unlock activity");
                return false;
            }
        }
...

What do you think?

Want to add that it possible to bypass this by adding my custom AppLockActivity as the ignored one, but it lead to not calling the setLastActiveMillis() because of check in onActivityResumed and onActivityPaused:
if (isIgnoredActivity(activity)) {
      return;
}

It is possible to bypass this by adding my custom lock activity as the ignored. It it safe to do so?

@Jeevuz This behavior was meant to be, and was mimicking what is happening when you want to change your password on a website for instance (and you are already logged in).
Let's say you increase the timeout to 1h, you unlock your app. During this time, anyone can change the password without needing the old one. It's a big loss of security.
At least if you ask for the previous password, no one can change it and the app will lock itself again after the timeout.
Cheers,
Olivier

Hi @olivierg13! I totally agree with your point. But maybe there is misunderstanding. Currently if I want change passcode and the timeout is not so big I must firstly enter passcode via UNLOCK_PIN, and only then confirm via CHANGE_PIN before start to actually change it.


account is not configured

I am admittedly extremely naive when it comes to Azure, but I cannot seem to sort out what the issue is here.  Any suggestions would be greatly appreciated.  Note this is using azure-nuke version 1.0.0-next.4
I created a service principal like so:
az ad sp create-for-rbac --name nuke-role --role contributor --scopes /subscriptions/redacted-subscription-id

My config.yaml currently just looks like this, but I've also tried many other combos of config.yaml settings and get the same results:
regions:
    - global
    - eastus

I then run:
azure-nuke run --tenant-id=redacted --client-id=redacted --client-secret=redacted --subscription-id=redacted --log-level trace --log-caller

And get:
TRAC[0000]command.go:45 tenant id: redacted
DEBU[0000]auth.go:30 authentication type: client secret
TRAC[0000]command.go:55 preparing to run nuke
TRAC[0000]tenant.go:32 start: NewTenant                              handler=NewTenant
TRAC[0000]tenant.go:46 attempting to list tenants                    handler=NewTenant
TRAC[0000]command.go:31 2024/03/20 17:16:56 [DEBUG] POST https://login.microsoftonline.com/redacted/oauth2/v2.0/token  source=standard-logger
TRAC[0000]tenant.go:59 listing subscriptions
TRAC[0000]tenant.go:70 adding subscriptions id: redacted
TRAC[0000]tenant.go:73 listing resource groups
INFO[0000]tenant.go:77 configured locations[global eastus]
DEBU[0000]tenant.go:89 resource group name: redacted
DEBU[0000]tenant.go:89 resource group name: NetworkWatcherRG
DEBU[0000]tenant.go:89 resource group name: redacted
FATA[0000]main.go:46 account is not configured

@andrewfraley you have to configure at least one tenant in your blocklist configuration and the tenant you are targeting in the config as well.
regions:
  - global
  - eastus

blocklist:
  - production-tenant-id

accounts:
  TARGET_TENANT_ID: {}

{} is if you do not want to configure any filters.

@ekristen thank you!  I was able to get it working with this.


publish 0.3 to crates.io

Hi, thanks for this awesome crate.
Noticed that the latest version on crates.io is only 0.2.2 instead of your newest version 0.3.
Would be cool to see it published on crates.io as its easier to consume downstream.
Thanks in advance :D

Published!


Fixing a python3 issue in bias_op_test.py

Issue 1: range in python3 does not return a list as in python2
Note that this PR doesn't fix all the currently failing Python3+GPU tests. It only gets the basic issues out of the way. Deeper issues related to dimension mismatches in bias_op_test, conv_op_test and pooling_op_test need to be addressed.

Looks like a flaky test?  Should we merge?

@tensorflow-jenkins test this please

Yes, that was a flaky test: //tensorflow/python:coordinator_test
Ready to merge.


Smooth animation card coming to the foreground

Might be putting in the wrong place (apologies if so).
When the top card is swiped away on stack view the next card springs. Is there a way to have it start moving forward as the top card is swiped?

Currently there is no way to customize the animation. But a simple solution could be to provide a linear animation instead of a spring.


input type validatation (e.g. date) is running while the date picker has focus.

Describe the bug
input type validatation (e.g. date) is running while the date picker has focus.
To Reproduce
Steps to reproduce the behavior:

Go to 'http://auro.alaskaair.com/components/auro/combobox
Scroll to the type example that uses date format
Focus the input
Enter 1
See error

Expected behavior
The type validation should not be run while the datepicker has focus.
This looks like it may be an issue with auro-input specifically not with combobox.

What is the actual error with this that is being addressed? What is the impact on the UI?


[SPIKE] Multi-Modal/Model

figure out what changes need to be made to support using multiple models or a single model with multiple features.

@Stevenic


Check first versionIRI then versionInfo in ontology.get_version()

Description:

Improve on get_version in ontology so that also versionInfo is checked for.
See discussion on #299
Also changed so that rdflib can guess format in ontoversion.
Ontoversion only checks for version from versionIRI as this should be the case for a correctly defined ontology.
Type of change:

[x] Bug fix.
[ ] New feature.
[ ] Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

[ ] Is the code easy to read and understand?
[ ] Are comments for humans to read, not computers to disregard?
[ ] Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
[ ] Has the documentation been updated as necessary?
[ ] Does this close the issue?
[ ] Is the change limited to the issue?
[ ] Are errors handled for all outcomes?
[ ] Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@jesper-friis
Can you please look at the ontology.get_version() now and see if you think this is the way to go forward?
I am now giving precedence to versionInfo, but this should be discussed.
the tools/ontoversion is not implemented correctly yet as I want us to decide if this is the right approach first.

Looks very good.
My only question is whether we should encourage setting versionInfo to just be the version number without the prepended "v".

Sure, it did it to keep track of versionIRI vs versionInfo, but it should be removed now.


INFINITY-2189 Resolve StateStore.storeStatus() TODO

... and add unit tests for task id repair.

@nickbp looks like this should be good to merge upon rebase + conflict resolution.


Factor out sequence state update logic

In the Parties generator, there is code to update the sequence state in the same way as Parties_logic. The Parties_logic code was updated, but the generator code did not change to match it.
Factor out the sequence update logic into a new function update_sequence_state in Parties_logic. Make that function available in unchecked code from Mina_transaction_logic (which includes an instantiation of Parties_logic).  In turn, Mina_ledger.Ledger includes Mina_transaction_logic, so we can export update_sequence_state from it. And so the Parties generators can use that function, instead of duplicating the update logic.
That's all a bit circuitous, imports a lot of extra code into the generators, and perhaps funny to offer that functionality from Ledger, but perhaps OK.
Closes #11752.

The dev unit tests passed on the first try in CI, which is a good sign.


rewritefs: 2020-02-21 -> 2021-10-03

Motivation for this change
Removing the fuse2 dependency and fixing a file locking bug.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all packages that depend on this change
[x] Tested execution of all binary files
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

missing unstable- prefix

Is it "unstable" even when the software has no tagged releases?

AFAIK it is always unstable when a commit sha is used.


⚠ Bofrost.nl has degraded performance

In a283b5b, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1218 ms

Resolved: Bofrost.nl performance has improved in cda6add.


UI: Font-Family Should be configable

Describe the bug
Some characters are not displayed properly. Because bindiff trying to use Roboto Mono as the only font, However this font family doesn't support non-ASCII  characters. Maybe font-family config can be add into config>main settings>general card.
To Reproduce
Just Open it and open any config window.
Screenshots

Environment (please complete the following information):

OS and version: Windows 10
Locale: zh-CN (Simplified Chinese)
Disassembler and version: IDA Pro 7.1

Additional context
Add any other context about the problem here.

Oh wow. Sorry for that. We really only support (and test) US English as the locale.
As a workaround, try setting the font in the config file (in %AppData%\Roaming\BinDiff\bindiff.json):

Setting this to "Segoe UI" for example, works for setting the UI font, but the core problem is that the Java runtime does not have a concept of fallback fonts if characters needed for a locale are not available.
Setting the font to "SimSun" looks ugly for western text, but seems to work (I don't know any Chinese...):

Thanks very much! It works for me. And may I ask are there any plans to include font configuration in the configuration menu in a future release?

I don't see why not. It'd be good to revamp the settings dialog anyways.


Fix gulp default command (memory consumption)

Our gulp default task had a meltdown on windows systems due to a problem with memory consumption.
Constant streams are known to consume a lot of memory, and we have a lot of them running in sequence.
As a solution i reduced the memory used by karma (by removing unneeded files). As another solution we can increase the memory provided to node for the task, but this will require creating an npm task for gulp.

Please test it before merging.
Another recommendation that came from teams with the same problem is to move to gulp 4 and not use run-sequence, which has a bit of a problem with memory management.


Configurable distance is in blocks.
Think of a zombie apocalypse, fire a gun and a ton of zombies nearby will hear that and start following the sound.
Via the upcoming attachments this should be possible to reduce/increase.
Configuration
Shooting_Attract_Mobs:
  Distance: <amount>
  Blacklist: <true/false>
  Entities:
    - "<ENTITY>"

That is good, I like that.

https://cjcrafter.gitbook.io/weaponmechanics/weapon-modules/shoot#attract_mobs
Added in WMP 1.4.0


Referenced images outside of publishing root are not found

Referenced images that are outside of the publishing root are not found when publishing.

This probably applies for any kind of attachments.

Support for images, attachments and include files outside of the documentation root folder has been added via #74.
Note: cross-references to AsciiDoc pages outside of the documentation root folder are not supported.


metricbeat filesystem metrics not being output to prometheus

In my metricbeat console output I have this:
  "system": {
    "filesystem": {
      "type": "fuse.glusterfs",
      "device_name": "<IP_ADDRESS>:vol_f19380703ea925da14813fcfa05fa331",
      "available":<PHONE_NUMBER>4,
      "mount_point": "/mnt",
      "free_files": 5225819,
      "used": {
        "pct": 0.0189,
        "bytes": 202223616
      },
      "total":<PHONE_NUMBER>0,
      "files": 5242880,
      "free":<PHONE_NUMBER>4
    }
  },

But in metric output from beat-exporter I only have:
metricbeat_metricbeat_system_filesystem system.filesystem
metricbeat_metricbeat_system_filesystem counter
and event failures and success.. Nothing about the above stats - which is what I actually need :(

from a quick glance at the GO code (I've never written GO before :) - it seems it would need to add a filesystem struct like this memstat one: https://github.com/trustpilot/beat-exporter/blob/master/collector/beat.go#L33
And then adding sections for parsing each counter like that : https://github.com/trustpilot/beat-exporter/blob/master/collector/beat.go#L109
But only for metricbeat with system collector enabled ofcourse.. (or does it just ignore if its not there)
?

or perhaps more like this: https://github.com/trustpilot/beat-exporter/blob/master/collector/beat.go#L89 - setting labels for instance and device_name and counter name simply being the used.pct and used.bytes total, files, free and free_files (which I assume is actually inodes free :)

Am I on the right track here? then I can try it out :)

and it should be a gauge - not a counter I think

I just investigated a bit, and can see that filesystem stats is not exposed via http interface - and it seems from discussion on elastic forum that they never will be (they're not interested in metricbeat being usable for anything other than their stack :(


Add submission ex2 Spanish translation ex2 and Spanish translation for ex3

Submission for ex2 by Mauricio Gómez Viloria. Not a solution but theoretical tutorial to arrive at the optimal solution.
Also added a translation of ex2 and ex3 in Latin American Spanish by Mauricio Gómez Viloria and Manuel Morgado.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Sorry for the delay. Thank you very much for your submission! Muchas Gracias!


Cannot cache play payment, please try again!

Hi i have paid 2 times and i become this error.  My phone is rooted with magisk!

Try again. And make sure Brevent can visit aws.jianyv.com

IT'S WORK AGAIN AND IT RECOGNIZE MY LAST PAYMENT. THANKS!

Try again. And make sure Brevent can visit aws.jianyv.com

Strange.Reinstall again it's normal

It was an issue of brevent payment server.


There is no git tags on GitHub repository

Hi @joaopereirawd  ,
We are cdnjs team, we're going to host this library.
The git auto-updater in cdnjs relies on git tags so that it can recognize the correct version and automatically update the repo.
Could you please add git tags for the repo?
If you have any suggestions, please let me know.
Thank you.
cdnjs/cdnjs#8337
cdnjs/cdnjs#8360

I saw the git tag, thank you.


more precise details for TextChatService.MessageReceived

Changes
I've clarified some slightly ambiguous technical details for the TextChatService.MessageReceived event. Before, it wasn't entirely clear if the event was only fired on the client because saying "fired exclusively on the client when [...]" or "fired exclusively on the client under two circumstances [...]" suggests that there are cases where it may be fired in contexts other than the client under different circumstances. Rather than finesse the sentence to make it clear that it's only ever used on the client, I just added a new sentence later in the same way TextChannel::SendAsync does. I also added information about how TextChannel.ShouldDeliverCallback affects TextChatService.MessageReceived.
This is my first time ever using GitHub. I was told I could edit Creator Docs pages through here on the DevForum: https://devforum.roblox.com/t/_/2706053/7
Checks
By submitting your pull request for review, you agree to the following:

[X] This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
[X] I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
[X] To the best of my knowledge, all proposed changes are accurate.

Not sure what the "source.fixAll.markdownlint": "explicit" change is, I don't remember messing with that. I'm new, forgive me 🙈

I made a few tiny edits to your suggestions... how does it look now?
I think TextChannel.MessageReceived may also need some edits... could you please suggest those too? Thanks!

Testing shows it follows the same rules as TextChatService.MessageReceived, so I assume it would just be copy-and-paste (also those pages currently have the same text for this event).
Repro is attached with relevant comments; GitHub doesn't support .rbxm files so it's zipped here: MessageReceived repro.zip

Are the oddly placed linefeeds intentional? Maybe it looks different in the final version but I'm wondering if there's a guideline for restricting the number of characters per line. It looked weird in the editor so I deleted some of them.
Also, should it be mentioned in the docs that this event works the same with both the TextChatService and TextChannel instances? Maybe copy-pasting isn't the only thing that should be done

I made a final round of slight edits, could you please review and let me know if it's good now? I can then merge and release. Thanks!

Looks good, although I had changed one thing earlier today which is the parameter name for TextChannel.MessageReceived. The TextChatService and TextChannel versions of this event share the same parameter class (TextChatMessage), but the docs page show them with a different name. TextChatService.MessageReceived calls it textChatMessage while TextChannel.MessageReceived calls it incomingMessage, yet for the OnIncomingMessage callback both instances call this parameter just 'message' — so maybe change that parameter name for both MessageReceived events to 'message' also.
I am still curious about the copy-paste thing going on here. Since the TextChatService and TextChannel page share a lot of documentation, is it a foregone conclusion to copy and paste info between the two pages? Maybe a base class or something would work here, in the same way that SpawnLocation and Part share a lot of properties and methods through their abstract class BasePart. Or if that doesn't work, some central place that both of these articles pull from to fill in that information automatically without needing to copy and paste.

Yep, I saw your request to change the name of textChatMessage to something like incomingMessage. Unfortunately the system is fairly strict and only allows docs to change summary, description, and deprecation_message fields... everything else will just be overwritten by the source.
As for the copy-paste thing for the two MessageReceived callbacks, I agree it's a bit redundant but that is how it was engineered and I'm not able to change that (without basically the entire API being rewritten internally lol). That does result in some copy-pasting which would ultimately be better as a shared snippet; I'll discuss this with engineering and see if there's a future solution.
Thanks again for your efforts on this fix; looking forward to any future contributions you may have on these classes and perhaps others as well. :)


add/remove from library undo bug

Go into browse
Add a manga
Quickly go into library
Click undo
Manga does not disappear
Similarly:
Go into browse
Remove a manga already in library
Quickly go into library
Click undo
Manga does not reappear
Problem is temporary; reloading app or interacting with app for a while will fix the issue.


APEX launch criteria attestation automation requirements

This epic will identify the requirements needed to enable the automation of the attestation of the APEX launch criteria.  We will identify requirements for Phase 1 and 2.  If time permits, we may implement phase 1 toward end of Gallium.  Given the loss of engineering resources, we have to prioritize the release planner functionality so we can onboard teams.  Phase 2 cannot be achieved without the release planner.
Scenario Today

Service partners have to provide evidence for completion of APEX launch criteria via email, forms, teams channels, etc.
This evidence is then evaluated by the Azure SDK PM team to ensure that the criteria is met.  The Azure SDK PM team copies the evidence into the appropriate field in the Azure Devops work item.  The Azure SDK PM confirms that they service partner can mark the APEX launch criteria complete, N/A, or request an extension.
Next the Service Partner has to manually update Cloud Lifecycle to mark the launch criteria as complete, N/A, or request an extension.
Azure SDK PM team has to manually go approve the attestation of the launch criteria in S360 approval hub.

Between now and June 2023 there are currently 157 product launches that required APEX launch criteria validation.
This is a manual process that is time consuming for both the service partner and the Azure SDK PM team.  Being manual, it is also more prone to errors.
Automating the APEX launch criteria state

Review the information provided on the CLC wiki page for providing evidence stream/automation - https://eng.ms/docs/products/genevaanalytics/servicelifecycle
Phase 1: Consider if using the Azure Devops work item as initial data source so that we could begin automation of CLC updates.  The Azure Devops work items already have the fields that represent the state of each APEX launch criteria.  We would still have to rely on the manual steps of 1 and 2 above (for service teams not yet using the release planner) but we could eliminate steps 3 and 4 for everyone.  This would begin to elevate some of the frustration and pain point now vs waiting for all service teams to be using the Release Planner. Also, the logic from ADO to Kustos tables would not need to change.  Phase 2 (#3 below) would automate #1 and #2 of the manual process (Scenario above).
Phase 2: The release planner would update the Azure Devops work item field that corresponds to launch criteria state when the service partner submits request for sign-off via the Release Planner application.  (Release Planner would validate the evidence is provided, work is done, and update launch criteria status in the Azure Devops work item).

[ ]  I will provide the list of Azure Devops fields that map to the launch criteria and put in this spreadsheet (just started, will finish by 01/27/2023) - https://microsoft-my.sharepoint.com/:x:/p/ladonnaquinn/EX3fkxU0SwlMoGVi7f0SHQkB-22Drd8b_JBj-sorDa63rg?e=G9x2uM.

@live1206 @josefree We should start on this work in parallel with the new UI.  We have a dependency from the Azure Global APEX team to automate the attestation of the APEX launch criteria for Gallium.  This is part of the overall push for automation and "default-green" for all S360 KPI action items.  Let's talk through this github issue when we meet next week.

Email templates started here: https://microsoft-my.sharepoint.com/:w:/p/ladonnaquinn/EbrUkOkGf2dLtUzeoEDnszQBh6eqoLR0HIFYDgA8FOdndw?e=8U1eLN
It also includes discussion


Address cannot be built from coinbase tx script

Hi, I'm having an issue with parsing coinbase transactions. They seem to be recognized as p2pk but the address is None.
This is reproducible for coinbase txs until height ~900 including the genesis block.
    // height: 0
    // txid: 4a5e1e4baab89f3a32518a88c31bc87f618f76673e2cc77ab2127b7afdeda33b
    // script: 4104678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5fac
    let bytes: &[u8] = &[
        65, 4, 103, 138, 253, 176, 254, 85, 72, 39, 25, 103, 241, 166, 113, 48, 183, 16, 92, 214,
        168, 40, 224, 57, 9, 166, 121, 98, 224, 234, 31, 97, 222, 182, 73, 246, 188, 63, 76, 239,
        56, 196, 243, 85, 4, 229, 30, 193, 18, 222, 92, 56, 77, 247, 186, 11, 141, 87, 138, 76,
        112, 43, 107, 241, 29, 95, 172,
    ];
    let script: Script = Script::from(Vec::from(bytes));
    let address = Address::from_script(&script, Network::Bitcoin);
    assert!(&script.is_p2pk());
    println!("address: {:?}", &address); // None

This behavior is intentional. There never was an address standard for p2pk scripts. Somehow someone just used the p2pkh scheme for p2pk scripts too, which is a bit silly as you can't reconstruct the script from the address. Bitcoin Core still shows these addresses in some cases, but doesn't recognize them when searching for UTXOs.

@sgeisler I didn't know that, thanks. Does the Builder or Script API allow replicating this behaviour in its current state? I'm in the process of replacing my code with this library and I don't want to break things that were working before. Any pointer is appreciated

You could probably just build a little helper serialization function that uses the Address type for all but p2pk addresses and if a script is p2pk you use your own implementation like this for serialization.

Awesome, thank you!

Idk if the ergonomics would be any better, but you might also use the iter method of Script and get the first Instruction which should always be a PushBytes. That would avoid the branching for compressed/uncompressed keys.


cross-platform: ChakraCore StaticLibrary

Implements static library support on xplat
Fixes thread cleanup issue xplat - shared lib

:shipit:

@curtisman @jianchun @digitalinfinity Thanks for the reviews!

@dotnet-bot test Copyright Check please


Enable animation based on navigation transitions.

Responses can now send a name value which will be used to construct "from"
and "to" CSS classes that will be applied during updates.  These two classes
will be applied with the following patterns:

config['animation-class'] + '-from-' + _previous_name_
config['animation-class'] + '-to-' + _current_name_

This will allow transitions to be applied based on state of the page (i.e.
navigating from page A to page B) instead of based on the action (i.e.
navigating back in the history stack).
Currently, a name must be sent with each part of a multipart response for it
to be used when processing that part.  The last name value will be saved
for upcoming "from" classes.
In order to initialize a "from" class before the first SPF navigation, pages
can set the data-spf-name attribute on the <body> tag:
<body data-spf-name="home" ...>

Progress on #299.

LGTM


Added button space view that fill safe area bottom space till input view

This should fix https://github.com/badoo/Chatto/issues/398

Codecov Report

Merging #447 into master will increase coverage by 0.12%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   64.47%   64.59%   +0.12%
==========================================
  Files          74       74
  Lines        3851     3867      +16
==========================================
+ Hits         2483     2498      +15
- Misses       1368     1369       +1

Impacted Files
Coverage Δ

...Source/ChatController/BaseChatViewController.swift
83.49% <94.11%> (+0.86%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebd21f...b46f86b. Read the comment docs.


bug(mat-error): No style on mat-error without form-field in the same component

Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
16.2.14
Description
Hi 👋
in a component using a mat-error
without any mat-form-field in the component
the mat-error is displayed without using the color warn (missing definition of mat-mdc-form-field-error class)
Reproduction
StackBlitz link: https://stackblitz.com/edit/jzya6i?file=src%2Fmain.ts
Steps to reproduce:

Go to with-color to see a mat-error using $theme-warn color
Go to without-color to see a mat-error not using $theme-warn color

Expected Behavior
<mat-error> are displayed using color: warn
Actual Behavior
<mat-error> are displayed without using color: warn
Environment

Angular: ^17.0.0
CDK/Material: ^17.0.0
Browser(s): Chrome/Firefox
Operating System (e.g. Windows, macOS, Ubuntu): Ubuntu

mat-error is only meant to be used with mat-form-field so this is working as expected.

re-asking :
"if the behavior is expected, is there a way to detect that kind of usage within a project"


MatTable page size not stable after updating 1.7.4

Page size automatically(zigzag) change 10 to 5

Did you try to set the following properties?
PagingDataPropertyName="Id" PagingRecordsCountPropertyName="Id" PageSize="3"
For me it's working

try this after that also same problem

@SamProf   table page size changed automatically from 10(fixed page size) to 5 and also in mat tab selection values not loaded i use the button for that click

I also have problems with PageSize, it flicker between my PageSize and default value.
When i load the page for the first time its allways default PageSize and as soon as i do something(push button or something) it jumps to my PageSize value.

in matblazor 1.7.2 working fine

I was able to temporarily workaround this by invoking StateHasChanged within the lifecycle method OnAfterRenderAsync, although this momentarily flashes the widget with fewer rows than I intended. To avoid this I put the widget behind an if block which is toggled during onAfterRender.
Looking forward to this being officially fixed, I've just recently discovered this library and very much enjoy and appreciate it.

@novfal ,
I believe this issue no longer exists. Can you confirm?


Update README and add .github/

Update README with badges
Create .github/ file with Contributing Guidelines

LGTM


Develop for Firefox and Chrome

What steps are necessary to make this adapter work both with chrome and firefox?

I'm new here, just getting started trying to build a cross-browser extension with SvelteKit, so take this all with a big fat grain of salt.
From the looks of it in the README, you'd have several <PLATFORM>_manifest.json files in static, only one of which will be used each time you build.
In svelte.config.js, the adapter function accepts a manifest attribute as part of its options. So you'd likely need to do something like have an environment variable for PLATFORM_TARGET, set it to "chrome" or "firefox", then have the manifest set accordingly, maybe the pages and/or assets attributes as well (if you want to output to different folders for each version).
Doesn't have to work exactly like that, but that seems like how to do it. Aside from that, may want to look into mozilla/webextention-polyfill for cross-browser compatible plugin APIs.

It should work for all chromium based clients but @Jack-Barry's response is accurate. We could make a generic fork for all browsers with polyfills


CTHUB - List of geographic locations

Describe the task
GER dataset and likely other datasets contain community names. In order to find typos, the easiest way is to first obtain a list of all communities in BC. The goal of this task is to research where to obtain a list that is updated regularly by Stats Canada or BC Government that we can access via API.
Purpose
To find typos in geographic name spellings.
Timebox
1 day
Acceptance Criteria

[ ] A list of BC communities that are incorporated (e.g. Vancouver) or designated places.
[ ] Access via API or download (if API options are not available)

Additional context
A full list can be found here: Stats Canada. BC also has BC Geographical Names portal here. They are both problematic because the former is a CSV download and the latter does not appear to have an API. But if we do not find anything better, we can use the former.

Hey team! Please add your planning poker estimate with Zenhub @emi-hi @JulianForeman @tim738745

@emi-hi Sounds great! Many thanks for finding it. Would it be possible to update the data in our system every year or so?

@katerinkus @emi-hi Just to add to what Emily wrote, we thought that to check a community name, we would have to make a request to the API with the name and with the "exactSpelling" flag set to true, and so that means we would have to query the API once for each record in an uploaded spreadsheet. This is less scalable than using a downloaded data set, which is why we were leaning towards using a download.
But I realized another way of doing the checks would be to :
(1) send the API a string of community names (with exactSpelling set to false), and it does return a list of features that match the names according to its own internal matching logic.
(2) Iterate through our community names and see which ones are in the list (meaning no typo), and which ones are not (meaning typo)
Then we would only have to do one query per upload, and we wouldn't have to maintain our own dataset of geographic locations.
Sorry for changing my mind, but now I'm leaning more towards using the API!

@emi-hi I think you can use the featureType parameter of the API (featureType=1 means city, =2 means community; see the /featureTypes endpoint). So we can do 2 search queries, one for cities and the other with communities, each with the same search string.
Alternatively, we can do featureType=* (the default), and we can process the query result on our end to exclude any of the features that's not of the type we want.

Reviewed


pip2 Packages All Always Reinstall

Any  pip2 packages declared in vars.yml always result in a change/reinstall on the target machine, even when they have already been installed.
Current behavior on second run of deploy-kali.sh:
./deploy-kali.sh
...
TASK [Install Python2 Pip packages] **********************************************
changed: [<IP_ADDRESS>] => (item=setuptools)
changed: [<IP_ADDRESS>] => (item=cffi)
changed: [<IP_ADDRESS>] => (item=dpkt)
changed: [<IP_ADDRESS>] => (item=scapy)
...

Expected behavior on second run of deploy-kali.sh:
./deploy-kali.sh
...
TASK [Install Python2 Pip packages] **********************************************
ok: [<IP_ADDRESS>] => (item=setuptools)
ok: [<IP_ADDRESS>] => (item=cffi)
ok: [<IP_ADDRESS>] => (item=dpkt)
ok: [<IP_ADDRESS>] => (item=scapy)
...

Resolved issue by adding creates checks for each item. See commit 9453a3330148fda89b9ffd085a718243c22d3ec1 for further details.

Fixed with more appropriate solution in commit 178f06b88975f8eaa6634644d07a352273a1625b.


Update canary per ode-1264 library changes

Ref: https://github.com/usdot-jpo-ode/ode-output-validator-library/pull/27

TIM broadcast functionality can be implemented as a configuration change. To add TIM validation support, users will need to set the MESSAGE_TYPES environment variable, like so:
MESSAGE_TYPES=bsm,tim


SQL: create external version of style guide

Why no SQL code style?
thank you!

we have an internal SQL style guide.  we need someone to figure out how to export/sanitize it though :).

There are many SQL dialects used at Google, such as ..., etc. However all of these flavors stem from the ISO/IEC 2011 standard which is the baseline of this style guide.

@papillonnette in case you want to pick this up, or find someone to


Remove incorrect reference in docs to list.html in content type directories

Discussed in forums.

@robmuh, did you mean to include the surge.sh commit in this PR?  My suggestion would be to use a separate branch for each PR.

I already merged surge.sh in #1996.

Sorry about that I thought I had pulled down the latest. I think it snuck in when I did the git stash on the other changes for the tutorial I want to submit later today. How would you like to proceed? I can redo it.

Merged in 49b4f8e.  Thanks, @robmuh!


Modified Chat for Greeters

Test plan:
Attach https://hifi-content.s3.amazonaws.com/liv/Production/Start/loadSupportApp.js to an entity in a domain
Confirm that users around the entity are able to communicate via the SUPPORT app

This has been working perfectly as expected. Greeters have been using this with users and it's been great!


The end_time and start_time in ISearchTweetsV2Parameters should serialize to 24h format

It appears that the properties StartTime and EndTime on ISearchTweetsV2Parameters are serialized to a 12h format rather than the expected 24h format producing unexpected search results

As a warning for others: I run into this as well and tried using CustomQueryParameters instead, but that falls into another bug where the SearchTweetsV2Parameters is copied, but the custom parameters are not.

I have run into this, too: https://github.com/linvi/tweetinvi/issues/1221


[SMALLFIX] Use static imports for standard test utilities in Configur…

…ationRuleTest.java

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16946/
Test PASSed.


Feature request: example of sending attachments/clearer documentation of attachments param please

Thanks again for the awesome package.
Any chance you have an example of sending attachments... About to start working it out.. just looked like your doc said an object but mailcomposer took and array of objects, so was not sure of the format.
My example, trying to send an iCal/ics as an attachment
any help appreciated

Hi @adamgins. This was added in PR https://github.com/lookback/meteor-emails/pull/60, and the code says "array of objects", but the README says object. I missed that, sorry. Does it work with arrays of objects?

Fixed in https://github.com/lookback/meteor-emails/commit/cb012595518932c0e06b6fd99cb75a33aff8af1f.

@johanbrook thanks heaps for the quick response.
how do make the attachments show up??? is there an example pls
I tried:
var result = Mailer.send({
                    to:  email,           // 'To: ' address. Required.
                    subject: "Some subject",
                    template: "<template name>",               // Required.
                    replyTo: '<email addres>',       // Override global 'ReplyTo: ' option.
                    from: "Do Not Reply" +<EMAIL_ADDRESS>        // Override global 'From: ' option.
                    data:{},
                    attachments: [{   // binary buffer as an attachment
                        filename: 'text2.txt',
                        content: new Buffer('hello world!','utf-8')
                    }]
                });

I get the email but does not seem to have the attachment
Any ideas, pls?

Any errors? Try cloning down the package into your local packages folder and add some console logs to see that the attachments property really is what it is.

can't seem to see anything on the server console.
on the client I see
Exception while simulating the effect of invoking 'microAppEmailCalendar' ReferenceError: Mailer is not defined(…) ReferenceError: Mailer is not defined
    at microAppEmailCalendar (http://localhost:3000/packages/buzzy-buzz_resources-core.js?hash=f03a9066c3fb909b4683239cd90496a2ecf9ddc1:1101:34)
    at http://localhost:3000/packages/ddp-client.js?hash=b5f1b97df6634673c68f37914ae9f4c3231c438e:3957:25

But I still get the email. That error line 1101 must be in generated Meteor code as it's for code that does not even run in my source file.

Hm, seems like Mailer is called on the client somewhere, in a method.
But as I said: the attachments is just sent to Meteor's Email.send(). Try popping into meteor shell and call Email.send() programmatically, with the necessary options.

ok, will check thanks
I think that error may have been that I did not wrap the method in Meteor. isServer


No link to the "team" page

There's no link to https://www.enersaveapp.org/teams/# from the main page

Going to close this because I think we do not want to expose the teams interface to non-logged in users.


Optimize encoding path for escaped string

Codecov Report

Merging #311 (0d18c6d) into master (5686ae0) will decrease coverage by 0.05%.
The diff coverage is 58.82%.

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   80.49%   80.44%   -0.06%
==========================================
  Files          48       49       +1
  Lines       17034    17081      +47
==========================================
+ Hits        13712    13740      +28
- Misses       2779     2793      +14
- Partials      543      548       +5


Auto Identification of Smart Clauses

Chunk the document into clauses and then identify smart clauses from existing template libraries. Could use a service like this:
https://dandelion.eu/docs/api/datatxt/sim/v1/

I would like to work on this, it should be like filter or we need to show only smart clause @dselman


Check i2s_ASN1_INTEGER's return value for NULL in print_notice

Checklist

[x] CLA is signed

Description of change
print_notice() doesn't check i2s_ASN1_INTEGER's return value for NULL, so the invalid pointer is later passed to strlen() where it causes a crash.
This was encountered by browsing www.digikam.org with w3m.

So, what's the state on this?  @levitte still dislike it?

Yup, still dislike it

okay, @ciz, will you make the printf changes like @levitte wants?

ping @ciz .

Seems this is stuck...
How about this, for a compromise:
Print "(null)" if sk_ASN1_INTEGER_value(ref->noticenos, i) returns NULL,
this leaves only the OOM error why i2s_ASN1_INTEGER(NULL, num) may return NULL,
and IMHO in that case it would be OK to return immediately ?

That works for me.  @ciz?  Maybe start your own PR to replace this one Bernd

Are you that a NULL return from i2s_ASN1_INTEGER is a memory failure in that case, or can it still be invalid non-NULL input that can cause it to return NULL?
If the former, I find it acceptable. If the latter, then not.

I looked very close at i2s_ASN1_INTEGER and discovered no other possibility,
except OOM and NULL-input, I was also a bit concerned about invalid
certificates that could end up with a null-element in ref->noticenos
but I don't see how the ASN.1 parsing could produce such an invalid
data structure, at least I was unable to create a certificate that induces
the described crash.

Awright, thanks for indulging me. :-)

#2935 merged, closing this.


Notification detail page consistency changes

:nut_and_bolt: Description: What code changed, and why?
consistency improvements for the notifications detail page same as the rest of automate.

updated details page
test the notification webhook URL with success/failure notification

:chains: Related Resources
https://github.com/chef/automate/issues/3706
:+1: Definition of Done
I have added consistency changes notification details with UI changes.
:athletic_shoe: How to Build and Test the Change
visit the Settings >> Notifications page
if you have no data then add some notification entries to see the list of notifications.
you can see the list of notifications >> click to any notification to see the notification details page.
STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

STEP 3
Review #3705
And create and test all the appropriate screens

:white_check_mark: Checklist

[ ] I have read the CONTRIBUTING document.
[ ] Tests added/updated?
[ ] Docs added/updated?
[ ] All commits have been signed-off for the [Developer Certification of Origin]

:camera: Screenshots

notification details page

test notification URL failure

test notification URL success

update notification details

So trying to catch up on this one after reading the original request, from you screenshots, are we currently disabling the buttons until a change is made?
"should work like the rest of our forms on detail pages, disabled until a change is made,"
https://github.com/chef/automate/issues/3706
Also in one your screenshots, it appears that the "Test data feed" has a black outline?
@susanev is out right and expected back next week, Im sure she has more feedback for this as well.

also according to https://github.com/chef/automate/issues/3706 looks like in the form Labels the "type"  needs to be capitalized to "Type" e.g. Failure Type, Webhook Type

@vinay033 so sorry for taking so long to review...

[ ] when you make a change on the detail page it should not change in the section above until they use the save button, right now for example if i change the failure type or webhook type it changes in that section before save
[ ] for the webhook url, could we get the validation on the url to show up below the field instead of in the top after trying to use the save button?

@vinay033 so sorry for taking so long to review...

[x]  when you make a change on the detail page it should not change in the section above until they use the save button, right now for example if i change the failure type or webhook type it changes in that section before save
[ ]  for the webhook url, could we get the validation on the url to show up below the field instead of in the top after trying to use the save button?

I have fixed the first point and for the second we follow the same like destination and if you need to show in a different manner then we can add changes accordingly.

@vinay033 so right now, the error messages comes in the banner up above after you press save if your url doesn't meet the validation, id prefer the error message show on the input itself before they are able to save. does this make sense?

@vinay033 so right now, the error messages comes in the banner up above after you press save if your url doesn't meet the validation, id prefer the error message show on the input itself before they are able to save. does this make sense?

ok, I will check for this and let you know.

@vinay033 so right now, the error messages comes in the banner up above after you press save if your url doesn't meet the validation, id prefer the error message show on the input itself before they are able to save. does this make sense?

I have added valid URL validation.

this good to merge?


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-1.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 1113

Questions ?
Please refer to the Backport tool documentation


fix: Resolve errors for vm resource not found

Fixes #
Description
https://github.com/Azure/karpenter-provider-azure/issues/525
https://learn.microsoft.com/en-us/azure/azure-resource-manager/troubleshooting/error-not-found?tabs=bicep#symptoms
When using the GET method to obtain a VM, the Error Code returned when the VM does not exist can be either NotFound or ResourceNotFound.
{"level":"ERROR","time":"2024-12-24T08:08:51.172Z","logger":"controller","message":"Reconciler error","commit":"56aa2e0-dirty","controller":"node.termination","controllerGroup":"","controllerKind":"Node","Node":{"name":"aks-cloud-fip-mcu-arm64-mkr2f"},"namespace":"","name":"aks-cloud-fip-mcu-arm64-mkr2f","reconcileID":"2ee3a64a-083f-4743-84fa-661820165f2c","error":"ensuring instance termination, getting cloudprovider instance, getting instance, failed to get VM instance, GET https://management.azure.com/subscriptions/xxxx/resourceGroups/xxxx/providers/Microsoft.Compute/virtualMachines/aks-cloud-fip-mcu-arm64-mkr2f\n--------------------------------------------------------------------------------\nRESPONSE 404: 404 Not Found\nERROR CODE: NotFound\n--------------------------------------------------------------------------------\n{\n  \"error\": {\n    \"code\": \"NotFound\",\n    \"message\": \"The entity was not found in this Azure location.\"\n  }\n}\n--------------------------------------------------------------------------------\n"}

In IsNotFoundErr, only the situation of ResourceNotFound will be judged, which will cause the node to remain in the notready state and cannot be deleted.
func IsNotFoundErr(err error) bool {
	azErr := IsResponseError(err)
	return azErr != nil && azErr.ErrorCode == ResourceNotFound
}

How was this change tested?

Using az vm simulate-eviction to simulate spot node release

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

Release Note

@microsoft-github-policy-service agree

https://github.com/Azure/azure-sdk-for-go-extensions/blob/main/pkg/errors/armerrors.go#L34 can we also add this change here too?


Debian 8 installation issue!

First of all, nice project.
Debian (8) users need to install node, git and npm before starting. Server side instruction are good, just use node server.js. Issue comes with client setting.
Error after running make:
mkdir -p schemes
lessc --global-var='name=atelier-lakeside' scheme.less > schemes/atelier-lakeside.css
Makefile:8: recipe for target 'schemes/atelier-lakeside.css' failed
make: *** [schemes/atelier-lakeside.css] Error 1
Have a nice day.

Do you know why lessc fails on your machine? Could you run it in verbose mode?

works fine for me (debian 8 too but maybe an older patch? havent updated since intial release :grin:)

npm start gives this:
0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/nodejs', '/usr/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info prestart<EMAIL_ADDRESS>6 info start<EMAIL_ADDRESS>7 verbose unsafe-perm in lifecycle true
8 info<EMAIL_ADDRESS>Failed to exec start script
9 error<EMAIL_ADDRESS>start: node server.js
9 error Exit status 8
10 error Failed at the<EMAIL_ADDRESS>start script.
10 error This is most likely a problem with the hack.chat package,
10 error not with npm itself.
10 error Tell the author that this fails on your system:
10 error     node server.js
10 error You can get their info via:
10 error     npm owner ls hack.chat
10 error There is likely additional logging output above.
11 error System Linux 2.6.32-042stab108.5
12 error command "/usr/bin/nodejs" "/usr/bin/npm" "start"
13 error cwd /opt/hack.chat
14 error node -v v0.10.29
15 error npm -v 1.4.21
16 error code ELIFECYCLE
17 verbose exit [ 1, true ]
Even when i install nodejs-legacy. This issue could be fixed with ln -s /usr/bin/nodejs /usr/bin/node, but it's better to install package who will do this for us.

Started from 0. Server side crash. Client make and http-server start working now.
Issue in this moment.
Server side (npm start):
http://paste.debian.net/hidden/93d9f4cc/
Provided logs:
http://paste.debian.net/hidden/25a2b387/

Node v0.12 is required to run the server. I've added that message to the README,


Simple compability for engine compilation + crash fix

added the UPROPERTY Category to allow Plugin compilation with engine
Fixed a crash in HandleTaskHeartbeat :
If you let a task live long enough, in case of a hitch or a low FPS, the task seem to be destroyed but keeped in the map RunningTasks. The check will avoid the crash, clean the list and throw a log message to avoid error shadowing in future développement.

For what it's worth, I'm going to recommend holding off on merging this in; the changes for the crash fix conflict with the rewrite to how attributes are replicated in pull request 55.
(The addition of categories to all UPROPERTY entries to allow GMAS to be compiled as an engine plugin is a change still worth merging in separately.)

Understood, on the need we could split this pull request in two part.
I think we will also do this for future pull request to simplify revision, instead of bundling features/fix/enhancements.

Pull request close, switched to dev branch and crash change will be re-implemented with PR55


Created gallery page

Fixes #723

But smaranjitghose bhaiya told me to not put the link in the Navbar for now. Here( #723 ) is the conversation.
And also, I think simplicity of the design may get affected if I incorporate 4/3 item grid.
So,
Should I add the page in the navbar and incorporate 4/3 item grid ?

okay, but in my suggestion having less scrolling on a laptop is the great user will look through all the mockups and designs then.
@smaranjitghose what say?

at least make the header's bold like all the other pages.

I made the header text bold ( @anushbhatia  )

Could you please fix the responsiveness issues on mobile screens?

Is it responsive now?. If not please tell me what is the exact issue, else please merge it.
And also I will try to implement AOS in the next PR after learning it ( If you allow ). @smaranjitghose

Is it responsive now?. If not please tell me what is the exact issue, else please merge it.
And also I will try to implement AOS in the next PR after learning it ( If you allow ). @smaranjitghose

Sure. you can raise an issue for it and raise the corresponding PR related to AOS for this page


[Analyzer] null-safe no warning or compilation error for inner generic.

This tracker is for issues related to:

Analyzer

Dart SDK Version (dart --version)
Dart SDK version: 2.12.0 (stable) (Thu Feb 25 19:50:53 2021 +0100) on "macos_x64"

Dart analyzer don't provide warning or compilation error when Map<String, Completer> is passed to a function with argument Map<String, Completer<Object?>>. But throws a error at runtime which basically remove all the benefits of a null/type safe code.
As you can see Completer is not equal to Completer<Object?>
code to replicate:
import 'dart:async';

void main() {
  final Map<String, Completer<Object>> tracker = <String, Completer<Object>>{
    '1': Completer(),
    '2': Completer(),
    '3': Completer(),
  };

  allCompleted(tracker);

  // trows Uncaught Error: TypeError: null: type 'Null' is not a subtype of type 'Object'
  tracker['2']?.complete();

  allCompleted(tracker);
}

void allCompleted(final Map<String, Completer<Object?>> tracker) {
  tracker.forEach(
    (key, completer) => print("${key} is completed ${completer.isCompleted}"),
  );
}

According to the Completer.complete() documentation:

If the value is omitted or null, and T is not nullable, the call to complete throws.

So it is statically valid to complete a Completer<T>, for a non-nullable T, with an omitted value, even though the code is guaranteed to throw at runtime.
This is also true for Future.value() for a non-nullable T.
@lrhn @bwilkerson I think it makes sense for the analyzer to Hint here, given the guarantee to throw at runtime. WDYT? Something like:

Given a Completer<T>, c, for a non-nullable T, report a Hint if:

c.complete() is called with no argument.
c.complete() is called with a Null-typed argument.
c.complete() is called with a Never-typed argument.
c.complete() is called with a Future<Never>-typed or FutureOr<Never>-typed argument. (I think we can simplify these examples to something about assignability...?)

Mutatis mutandis for Future<T>.value() for a non-nullable T.

Examples:
void m1()                   => Completer<int>().complete(); // proposed Hint
void m2()                   => Completer<int>().complete(null); // proposed Hint
void m3(Null a)             => Completer<int>().complete(a); // proposed Hint
void m4(FutureOr<Null> a)   => Completer<int>().complete(a); // existing Error
void m5(Future<Null>? a)    => Completer<int>().complete(a); // existing Error
void m6(void a)             => Completer<int>().complete(a); // existing Error
void m7(Future<void> a)     => Completer<int>().complete(a); // existing Error
void m8(FutureOr<void> a)   => Completer<int>().complete(a); // existing Error
void m9(Never a)            => Completer<int>().complete(a); // proposed Hint
void m10(Future<Never> a)   => Completer<int>().complete(a); // proposed Hint
void m11(FutureOr<Never> a) => Completer<int>().complete(a); // proposed Hint

I think it makes sense for the analyzer to Hint here, given the guarantee to throw at runtime.

I agree. Any time there is guaranteed to be a runtime exception and we can accurately determine that case statically then it makes sense for analyzer to produce a hint.

iii. c.complete() is called with a Never-typed argument.

I'm not sure about Never. I might have the wrong understanding of Never, but doesn't the Never guarantee that we won't actually invoke complete? Hence there is no runtime exception thrown in that case. It seems like we should instead be letting the user know that the invocation of complete is unreachable.

If the argument has type Never, then we know the call is dead code (in sound mode).
If we don't warn about other Never-guaranteed dead code, I can't see why this should be special.
For Future<Never> or FutureOr<Never>, it's not necessarily dead code. That value can be a future containing an error. (In fact, it's the perfect type for creating an error future that can be reused at any type).
The cases that really needs help is "no argument, non-nullable type" and possibly "nullable argument, non-nullable type", where the latter is enabled because the value is optional and therefore forced to be nullable. The latter call might actually be correct if you know, for some reason not reflected in the type system, that the value is not null. Wouldn't hurt you to write the ! then.

Excellent, thanks for the feedback!

I've opened https://dart-review.googlesource.com/c/sdk/+/202622. It handles "no argument, non-nullable type" and "null argument, non-nullable type" since those can't have false positives. I can change it to handle "nullable argument, non-nullable type" too but I'm not sure if it should be a default diagnostic if it can have false positives? In particular, it would warn about Future.value(x as dynamic) then.

@simolus3 I think your decision is sound. Later on, we can trigger on nullable arguments either in the same Hint, or with a new Hint (with a different message).


module to remove missing fields from VEP105 HT

Add one module to remove missing fields from VEP105 annotation HT.
Made some minor changes in annotation resources to include both exomes and genomes.

@KoalaQin this doesn't look like its comparing to the current main. I noticed when looking at the annotations root adding in data_type. Could you pull those changes in? Looks like they all went in #358 so there is a merge conflict right now. I just want to be sure I'm comparing again the up to date version.

Hi Mike, this was pushed before Julia approved my previous PR. Sorry about the confusion. Can you see the correct version now?

Yes thank you! Looks like the diff is just single function now with a minor edit to another file


Re-investigate Ctrl+S pausing

At some point in history, we broke Ctrl+S to pause the output in the console host. I think it was around the time that we messed with the ExtendedEditKeys stuff.
I don't have the full context on this anymore, this is just another note-to-self title only bug I had as MSFT: 17790922 that I'm porting to the outside.
We need to reinvestigate the state of Ctrl+S pausing throughout the ages. How did v1 do it? How did v2 do it over the releases of Windows 10? Do we need to reintroduce it as an option somehow?

Ctrl+S / XOFF , ctrl+Q XON. It's just ye olde software flow control. Speaking for myself, I'd use it quite a lot with streaming logs, cat, tail etc. A vestige from old teleprinters / terminals and carried on in VT.

Oh, and yes, methinks you should definitely reintroduce it.

In NT 4, with line-input mode enabled, console output could be suspended either via the pause key (VK_PAUSE) or Ctrl-S. I'm certain Ctrl-S was chosen for the convenience of people accustomed to terminals. That said, pressing any key resumes output; it doesn't have to be Ctrl-Q since the console isn't actually a terminal responding to XOFF/XON.
Around Windows 2000 the "ExtendedEditKey" registry setting was added. If this was enabled, custom edit keys could be defined in "ExtendedEditkeyCustom". I don't think this was ever documented. If no custom mapping was defined, it used a default mapping that included the Ctrl-S -> VK_PAUSE mapping. So Ctrl-S still worked by default even if "ExtendedEditKey" was enabled.
The new console exposes "ExtendedEditKey" in the properties dialog, but it's repurposed now for "extended text selection keys". Since "ExtendedEditkeyCustom" no longer seems to be implemented beyond a vestigial CONSOLE_REGISTRY_EXTENDEDEDITKEY_CUSTOM macro in the source, I think IsPauseKey should simply return true for VK_PAUSE or Ctrl-S, which will restore the original behavior.
On a related note, in the source I see that  "ExtendedEditKey" and the properties dialog set the value of global g_fEditKeys, but it seems to be used.

Do I understand it correctly that it's not only the keybinding that is missing but the whole feature of suspending the output? I would greatly appreciate the reintroduction of Ctrl-S. Sorry, if this is a developer-only forum and I'm intruding.

@KhabarlakKonstantin that is the responsibility of the shell (bash, cmd, pwsh, zsh), not the terminal (iterm2, xterm, windows terminal)

Btw. I'm on Windows Terminal Preview, Version: 1.12.3472.0 and Ctrl+S (pause), Ctrl+Q (unpause) seems to work correctly, just as was said here https://github.com/microsoft/terminal/issues/809#issuecomment-492462593.

This is great that this functionality - that was damaged at some point - has been restored.  I am training networks - on Linux, I can Ctrl-s and check output -see how things are going.  But on my new Windows-11 laptop, Ctrl-s still does NOTHING.  I'm glad that this has been fixed - except I find I am unable to ENABLE the fix, despite having a current machine which is updating regularly.  I am guessing a registry edit is needed?
SO, what is the secret trick to actual enable Ctrl-s / Ctrl-q  flow-control style pause and resume, in Windows-11 Cmd (the legacy version, of course).  Thanx for any info!  - M.

Great catch @oising!

Since the PR was so long ago my memory of it is a bit hazy and I may be misreading the linked comment chain, but why do you believe this was not fixed? Ctrl+S for pausing works perfectly fine for me in OpenConsole and Windows Terminal 1.19 and later.

Since the PR was so long ago my memory of it is a bit hazy and I may be misreading the linked comment chain, but why do you believe this was not fixed? Ctrl+S for pausing works perfectly fine for me in OpenConsole and Windows Terminal 1.19 and later.
Edit: "perfectly fine" = "like old conhost". Dustin cleared me up about how XON/XOFF on other OS also properly pauses interactive prompts, etc., whereas the Windows implementation doesn't. Ctrl+S only pauses output for as long as you don't type any other characters. I wasn't aware about this difference and I apologize for that. We could consider changing this behavior. As far as I can tell it hasn't ever been different on Windows though even before ExtendedEditKeys was removed.

Oh, well, this is news to me too :) I read the original PR as saying it wasn't implemented to spec/as expected. But it seems to function well enough for me with terminal now that I tested it.
@Gemesys Please ensure you're on the latest version of windows terminal.


⚠ Samsung has degraded performance

In 4668302, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 1770 ms

Resolved: Samsung performance has improved in c8393b7.


HTTP Request Buffering

Is there a way to extend Envoy with a custom extension like the ones below
https://www.envoyproxy.io/docs/envoy/latest/extending/extending to buffer HTTP request traffic ideally in a database engine until the upstream server has recovered from failure (i.e. becomes available again) and then immediately start the request resending.
If not what extension type should I be building to allow such functionality.
Thank you.

Yes you can do this with an HTTP filter. See the buffer filter and the caching filter for inspiration.

A few questions

In the case the upstream connection cannot be established, is an encoding http filter called to encode the error response after all retries have failed ?
In the case the HTTP connection manager is set to mirror traffic for other upstream clusters. Can we detect a failed request to these mirrored clusters and buffer/re-send traffic to them as well ?

@mattklein123, A few concerns by priority

Our usecase requires the HTTP request is replicated to multiple hosts. I see that the http filter supports fire-and-forget mirror clusters but not synch req/resp broadcasting. Is there a way for our HTTP filter to detect failed FAF requests to mirrors and buffer/re-send traffic to these as well ? If not, is there anyway to replicate requests in envoy other than mirroring ?
The filter stack is instantiated on a request, is there some async callback to detect that the upstream is available ?
A filter stack is per-request, so I assume buffered requests can't be sent over the same connection with the original. Im thinking the only
way to solve this is to pause iteration, use an http client to send the buffered request and resume the filter stack afterward ?

@Charana123 sorry this is going to require some code splunking to understand Envoy and develop a solution I would start by studying the router filter, async client, etc.


More data

Pretty cool little package. More suggestions and possibly relevant links

analysis, data, also here
Data and analysis
Maybe something can be selected here

Not sure how relevant this is, but I sometime wondered how many unique (and named) car characters there are in Cars trilogy, for example (my son's question). So I would turn to fan pages like this. It is not in tabular form, but as a community we could probably scrape/clean it into a table.
I imagine this could be an exciting dataset for teaching!

Thanks for the resources!
Some notes:

Analysis = I think most of the data here is in my package. What I could do and have thought about is having a small vignette with a similar simple analysis to get people started working with the data
Data = I think I have most of the data here, except duration of films
Data = I think most of this is covered
Disney Character Success = I'm hesitant on including things from here because my package is on Pixar, not Disney; maybe someone should make a disneyfilms package :smile:
Analysis = as mentioned in another point, something like this could be done as a vignette and hosted on the website

A dataset on Pixar characters would be cool to have. But yes, scraping that kind of information from that website might take a bit.
I'll keep this issue open to brainstorm other ideas.


moveMotorStep and angle

The Tapo C200 accepts both horizontal and vertical angle as this picture shows. The moveMotorStep function accepts only a single value of angle (0-360), how can i position the camera at a particular horizontal/vertical angle?

Use moveMotor function. Example: https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/blob/main/custom_components/tapo_control/camera.py#L298


Added Tax assessment data via opendata API #198

TaxApiConn class created.
python data.py tax get_tad is command to create file with the current datestamp.

@eng1nerd Thanks for this! It's a good start, but it looks like opendata.dc.gov is deciding not to play nicely with us. The csv file created only had 1,000 rows - I looked into this and it appears this is an ESRI default from their geojson api: https://geonet.esri.com/thread/67749
It turns out that the csv files we've been manually downloading from opendata.dc.gov can actually be queried directly from their API, which is the better way to get a bulk download without limits. They note that it's just a matter of swapping .geojson for .csv in the geojson api endpoint:
http://opendata.dc.gov/pages/using-apis (bottom of page)
I merged your code into the 198-add-tax-data branch instead of into dev. That way we have it in the codefordc repo but can pick up resolving these issues.

@eng1nerd You mentioned you were busy with starting this new job - do you want to try changing this to the .csv approach or would you rather I put this back out to the team?


Bundler crashes when using npm to install dependencies

Description
With an app running in the emulator, when running the command npm install --save lodash I get this output:
Bundler:
 ERROR  EPERM: operation not permitted, lstat 'C:\Users\Trevor\Code\Learn\test\node_modules\.staging\lodash-f4bb885f\fp'
{"errno":-4048,"code":"EPERM","syscall":"lstat","path":"C:\\Users\\Trevor\\Code\\Learn\\test\\node_modules\\.staging\\lodash-f4bb885f\\fp"}
Error: EPERM: operation not permitted, lstat 'C:\Users\Trevor\Code\Learn\test\node_modules\.staging\lodash-f4bb885f\fp'

Npm error:
npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\Trevor\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install" "--save" "lodash"
npm ERR! node v7.6.0
npm ERR! npm  v3.8.0
npm ERR! path C:\Users\Trevor\Code\Learn\test\node_modules\lodash
npm ERR! code EPERM
npm ERR! errno -4048
npm ERR! syscall rename

npm ERR! Error
npm ERR!     at moveAway (C:\Users\Trevor\AppData\Roaming\npm\node_modules\npm\lib\install\action\finalize.js:38:5)
npm ERR!     at destStatted (C:\Users\Trevor\AppData\Roaming\npm\node_modules\npm\lib\install\action\finalize.js:27:7)
npm ERR!     at FSReqWrap.oncomplete (fs.js:114:15)
npm ERR!
npm ERR! Error: EPERM: operation not permitted, rename 'C:\Users\Trevor\Code\Learn\test\node_modules\lodash' -> 'C:\Users\Trevor\Code\Learn\test\node_modules\.lodash.DELETE'
npm ERR!  { Error
npm ERR!     at moveAway (C:\Users\Trevor\AppData\Roaming\npm\node_modules\npm\lib\install\action\finalize.js:38:5)
npm ERR!     at destStatted (C:\Users\Trevor\AppData\Roaming\npm\node_modules\npm\lib\install\action\finalize.js:27:7)
npm ERR!     at FSReqWrap.oncomplete (fs.js:114:15)
npm ERR!
npm ERR! Error: EPERM: operation not permitted, rename 'C:\Users\Trevor\Code\Learn\test\node_modules\lodash' -> 'C:\Users\Trevor\Code\Learn\test\node_modules\.lodash.DELETE' parent: 'test' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Trevor\Code\Learn\test\npm-debug.log

Note: I was running as admin, and my environment variables are set properly, and I do not get errors when using npm install when the bundler is not watching my files.
Reproduction Steps and Sample Code
I'm honestly not sure - you can try to npm install a dependency while the bundler is running, but I haven't been able to find anything regarding this issue online :\
Solution
No idea - seems to be some sort of permissions issues, I don't know if the bundler modifies the permissions of files it's watching, but I am running as an admin. Ideally I wouldn't have to shut the application down each time I needed to install an outside dependency.
Additional Information

React Native version:
react-native-cli: 2.0.1
react-native: 0.42.3

Platform: Android

Development Operating System: Windows 10

Dev tools:
Android Studio version: 2.3
Android SDK version: 23

Would really appreciate a fix! I love developing in React, but honestly, I may have to just roll native Android development if I can't get this environment issue figured out.

It seems I've fixed this by using watchman - However, this is not apparent anywhere on the official documentation (https://facebook.github.io/react-native/docs/getting-started.html).
Finding a windows version of watchman could also be easier.

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


Option to minify HTML output

It would be great to be able to use MJML's built-in minify option, unless using another minifier (like gulp-htmlmin) is OK, in a matter of compatibility with email clients. But i'm not sure about what options to set.

For the record : looks like MJML is using html-minifier with options :
collapseWhitespace: true, removeEmptyAttributes: true, minifyCSS: true


E492: Not an editor command: ],0>},0|,0},0],0) when editing OCaml files

Describe the bug
nvim-cmp crashes with E492: Not an editor command: ],0>},0|,0},0],0) when editing an arbitrary OCaml file. It seems, that there are some incompatibilities with the default ocaml.vim runtime file, because nvim-cmp works perfectly on other file types.
Minimal config based on this
set nocompatible

call plug#begin('~/.local/share/nvim/plugged')
Plug 'hrsh7th/nvim-cmp'
call plug#end()

set completeopt=menu,menuone,noselect

lua <<EOF
  require'cmp'.setup({})
EOF

To Reproduce

Open or create the OCaml file using the minimal config: nvim -u init.vim test.ml
Start writing some reserved OCaml keyword. For example, type let.
See error in the messages area. Autocompletion won't work after the crash:

Expected behavior
No crash.
Additional context
neovim version: v0.5.1. nvim-cmp commit hash: 6696c6a0.

Probably related to indentkeys (also no crash for me, for some reason).

Hi @dmitmel, thanks for the quick reply.

no crash for me, for some reason

By "crash" I mean, that autocompletion doesn't work after this error.

Probably related to indentkeys

Yes, that's right. The runtime/indent/ocaml.vim file contains the following line:
setlocal indentkeys+=0=and,0=class,0=constraint,0=done,0=else,0=end,0=exception,0=external,0=if,0=in,0=include,0=inherit,0=initializer,0=let,0=method,0=open,0=then,0=type,0=val,0=with,0;;,0>\],0\|\],0>},0\|,0},0\],0)

After commenting it in /usr/share/nvim/runtime/indent/ocaml.vim everything works.
Could this be fixed in nvim-cmp?

nvim-cmp doesn't modify the indentkey at the moment.
https://github.com/hrsh7th/nvim-cmp/blob/main/lua/cmp/core.lua#L217

@hrsh7th Ah, yes, I see. Everything works after update.
Thank you very much for this project, and sorry for that noise.

Ah, yes, I see. Everything works after update.

Could you explain what did you update to fix the issue? I'm encountering it as well.

@undu I just updated nvim-cmp using my plugin manager. This issue has been fixed in the current version.

I had to remove the indentkeys in installed vim-ocaml and vim-polyglot as well


Application started action

In response to this https://github.com/aspnet/Hosting/pull/129, here is the solution proposed by @lodejard
Please review: @lodejard @davidfowl
cc @Tragetaschen

I'm sorry this API isn't good. I can't think of any example where I've seen an assignable delegate type in a property. A register method call would be better

this also doesn't work if you want to disable the default behavior of hosting.

Maybe appLifetime.OnApplicationStarted(() => { })?

Some of the OWIN security libraries have Actions and Funcs as properties, e.g. OpenIdConnectAuthenticationNotifications.AuthenticationFailed

@JamesNK that doesn't count.

@davidfowl what do you think about the updated PR?

A little better but the setting of the default is in the wrong place. Helios also uses this API and there should be no call to Console.Read or Console.WriteLine.

Maybe a dumb question but why not use a C# event to add/remove startup events?

I cannot really wrap my head around the naming here. Everything points to a semantic that is usually implemented using an event and it sounds like you would do stuff in here that is necessary right after everything started to run. But the truth is that the registered function defines the lifetime of the program.
That being said, I think there is value in an event in IApplicationLifetime as described.

@victorhurdugaci, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;


send-request required attribute documentation issue

The documentation states that the "response-variable-name" attribute is not required in the "send-request" policy.  However, APIM appears to be requiring this attribute.  Is this correct?  Thank you.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5310021d-de39-9418-2a55-ccdd9c2f4db0
Version Independent ID: ad38bf02-de35-7d67-def7-b1a064dd032f
Content: Azure API Management advanced policies
Content Source: articles/api-management/api-management-advanced-policies.md
Service: api-management
GitHub Login: @vladvino
Microsoft Alias: apimpm

Good catch, thank you @dapathy. "response-variable-name" attribute is required. I'll update the article.

Resolved in https://github.com/MicrosoftDocs/azure-docs/commit/607aab6f6b6e917e9b2a27c816a168292b08a4cc#diff-18e3d4b822d42490db51093d9c5dd539. #please-close


Fix CountDownLatch usage of NSCondition

NSCondition.wait must be run in a loop that continuously checks the actual predicate. The wait method can randomly wake up without the condition being signaled.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Adds PlayMode Tests for Interactables + Some Test Cleanup

Overview
PlayMode tests for interactables.
Changes

Fixes: #4723
I've updated BaseNearInteractionTouchable so that EventsToReceive is modifiable at runtime.

Verification
We should make sure the simulated input events being raised correctly.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

Instead of checking that a press event happened by seeing if the movable component moved, it would be much better to actually add a handler in Interactable.OnClick that sets some variable like onclicked to true.

Adding a listener to OnClick is a good idea. We should keep the translate check too, though. There have been a few cases where input gets passed through the system without actually triggering a visible change. If that happens it could mean something has broken.

After reviewing with @killerantz and @julenka we're breaking out runtime assembly of an Interactable theme to a separate issue: #5050
For now our runtime-assembled button will use a theme loaded from the asset database. This is still a worthwhile test.

/azp run mrtk_pr

TestSimulatedMenuInputOnPrefab and TestSimulatedVoiceInputOnPrefab are failing on build check. Can anyone get these to fail locally?

Hey Lars, I've got a script that you can run which will run the tests in headless aka batch mode, I've found that some tests fail only in batch mode. You can run it from powershell.
ci_run_tests.zip

@googlan Thanks I'll see if that helps.

/azp run mrtk_pr

/azp run mrtk_pr

/azp run

/azp run mrtk_pr

/azp run mrtk_pr

/azp run mrtk_pr

A few tests are still not passing so we files #5153 to track fixing those, since debugging this is currently blocking progress on other GA issues.

/azp run mrtk_pr

/azp run mrtk_pr

The new raycast provider tests were using the 'wrong' utilities class (as of this PR) for setup and teardown.

/azp run mrtk_pr


Should/Could a listing of datatype(s) of a dataset be included within dataset download .tar?

Echoing my brief question during our jitsi session, I think it might be valuable (especially for datalad crawling and aggregation of datasets) to have brainlife data types present somewhere (in a canonical location, e.g. within .brainlife.json)

OK. I've updated it to .brainlife.json. Thanks for your feedback!


Arrival of the Birds by The Cinematic Orchestra unsupported.

Check if issue with swaglyrics or whether song lyrics unavailable on Genius.

Not on Genius