Update AWS SDK to latest - v1.6.10

In order to fix #92, AWS GO SDK was updated to the latest by running glide up --all-dependencies
Built a binary as suggest on OS X and seems to run fine as expected.
Unit test output in case it is needed
mechastorm@nerv terragrunt (aws-sdk-update) $ glide up --all-dependencies
[WARN]	The name listed in the config file (github.com/gruntwork-io/terragrunt) does not match the current location (github.com/mechastorm/terragrunt)
[INFO]	Downloading dependencies. Please wait...
[INFO]	--> Fetching updates for github.com/mitchellh/mapstructure.
[INFO]	--> Fetching updates for github.com/go-errors/errors.
[INFO]	--> Fetching updates for github.com/hashicorp/hcl.
[INFO]	--> Fetching updates for github.com/aws/aws-sdk-go.
[INFO]	--> Fetching updates for github.com/urfave/cli.
[INFO]	--> Fetching updates for github.com/mattn/go-zglob.
[INFO]	--> Fetching updates for github.com/stretchr/testify.
[INFO]	Resolving imports
[INFO]	--> Fetching updates for github.com/jmespath/go-jmespath.
[INFO]	--> Fetching updates for github.com/go-ini/ini.
[INFO]	--> Fetching updates for github.com/BurntSushi/toml.
[INFO]	--> Fetching updates for gopkg.in/urfave/cli.v1.
[INFO]	--> Fetching updates for gopkg.in/yaml.v2.
[INFO]	Found Godeps.json file in /Users/mechastorm/.glide/cache/src/https-github.com-stretchr-testify
[INFO]	--> Parsing Godeps metadata...
[INFO]	--> Fetching updates for github.com/davecgh/go-spew.
[INFO]	--> Setting version for github.com/davecgh/go-spew to 04cdfd42973bb9c8589fd6a731800cf222fde1a9.
[INFO]	--> Fetching updates for github.com/pmezard/go-difflib.
[INFO]	--> Setting version for github.com/pmezard/go-difflib to d8ed2627bdf02c080bf22230dbb337003b7aba2d.
[INFO]	Downloading dependencies. Please wait...
[INFO]	Setting references for remaining imports
[INFO]	Exporting resolved dependencies...

--- PASS: TestRunModulesOneModuleSuccess (0.00s)
--- PASS: TestRunModulesNoModules (0.00s)
--- PASS: TestToRunningModulesMultipleModulesWithAndWithoutDependenciesReverseOrder (0.00s)
[terragrunt]  Module /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-g depends on module /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-f, which is an external dependency outside of the current working directory. Should Terragrunt skip over this external dependency? Warning, if you say 'no', Terragrunt will make changes in /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-f as well! (y/n)
[terragrunt] 2017/01/05 10:16:48 The non-interactive flag is set to true, so assuming 'yes' for all prompts
--- PASS: TestResolveTerraformModulesMultipleModulesWithExternalDependencies (0.00s)
--- PASS: TestFindStackInSubfolders (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 2 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module large-graph-f must wait for 2 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module f must wait for 2 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished with an error: Expected error for module c
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished with an error: Expected error for module a
[terragrunt]  Module /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-j depends on module /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-i, which is an external dependency outside of the current working directory. Should Terragrunt skip over this external dependency? Warning, if you say 'no', Terragrunt will make changes in /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-i as well! (y/n)
[terragrunt] 2017/01/05 10:16:48 The non-interactive flag is set to true, so assuming 'yes' for all prompts
--- PASS: TestRunModulesReverseOrderOneModuleError (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished with an error: Expected error for module a
--- PASS: TestRunModulesOneModuleError (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
--- PASS: TestRunModulesReverseOrderOneModuleSuccess (0.00s)
--- PASS: TestToRunningModulesTwoModulesNoDependencies (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module d must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module e must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module f must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module f now
[terragrunt] 2017/01/05 10:16:48 Module f has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Dependency f of module d just finished succesfully. Module d must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module d now
[terragrunt] 2017/01/05 10:16:48 Module d has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Dependency d of module c just finished succesfully. Module c must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished with an error: Expected error for module c
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 2 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency d of module a just finished succesfully. Module a must wait on 1 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Module large-graph-g must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module large-graph-a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module large-graph-a now
[terragrunt] 2017/01/05 10:16:48 Module large-graph-a has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module large-graph-b must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency large-graph-a of module large-graph-b just finished succesfully. Module large-graph-b must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module large-graph-b now
[terragrunt] 2017/01/05 10:16:48 Module large-graph-b has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module large-graph-c must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency large-graph-b of module large-graph-c just finished succesfully. Module large-graph-c must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module large-graph-c now
[terragrunt] 2017/01/05 10:16:48 Module large-graph-c has finished with an error: Expected error for module large-graph-c
[terragrunt] 2017/01/05 10:16:48 Module large-graph-d must wait for 3 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency large-graph-a of module large-graph-d just finished succesfully. Module large-graph-d must wait on 2 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Dependency large-graph-b of module large-graph-d just finished succesfully. Module large-graph-d must wait on 1 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Dependency large-graph-c of module large-graph-d just finished with an error. Module large-graph-d will have to return an error too.
[terragrunt] 2017/01/05 10:16:48 Module large-graph-d has finished with an error: Cannot process module Module large-graph-d (dependencies: [large-graph-a, large-graph-b, large-graph-c]) because one of its dependencies, Module large-graph-c (dependencies: [large-graph-b]), finished with an error: Expected error for module large-graph-c
[terragrunt] 2017/01/05 10:16:48 Dependency large-graph-d of module large-graph-f just finished with an error. Module large-graph-f will have to return an error too.
[terragrunt] 2017/01/05 10:16:48 Module large-graph-f has finished with an error: Cannot process module Module large-graph-f (dependencies: [large-graph-e, large-graph-d]) because one of its dependencies, Module large-graph-d (dependencies: [large-graph-a, large-graph-b, large-graph-c]), finished with an error: Cannot process module Module large-graph-d (dependencies: [large-graph-a, large-graph-b, large-graph-c]) because one of its dependencies, Module large-graph-c (dependencies: [large-graph-b]), finished with an error: Expected error for module large-graph-c
[terragrunt] 2017/01/05 10:16:48 Module large-graph-e must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Assuming module large-graph-e has already been applied and skipping it
[terragrunt] 2017/01/05 10:16:48 Module large-graph-e has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Dependency large-graph-e of module large-graph-g just finished succesfully. Module large-graph-g must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module large-graph-g now
[terragrunt] 2017/01/05 10:16:48 Module large-graph-g has finished successfully!
--- PASS: TestRunModulesMultipleModulesWithDependenciesLargeGraphPartialFailure (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency a of module b just finished succesfully. Module b must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency b of module c just finished succesfully. Module c must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module d must wait for 3 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency a of module d just finished succesfully. Module d must wait on 2 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Dependency b of module d just finished succesfully. Module d must wait on 1 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Dependency c of module d just finished succesfully. Module d must wait on 0 more dependencies.
[terragrunt]  Module /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-k depends on module /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-h, which is an external dependency outside of the current working directory. Should Terragrunt skip over this external dependency? Warning, if you say 'no', Terragrunt will make changes in /Users/mechastorm/work/go/src/github.com/mechastorm/terragrunt/test/fixture-modules/module-h as well! (y/n) [terragrunt] 2017/01/05 10:16:48 Running module d now

[terragrunt] 2017/01/05 10:16:48 Module d has finished successfully!
[terragrunt] 2017/01/05 10:16:48 The non-interactive flag is set to true, so assuming 'yes' for all prompts
[terragrunt] 2017/01/05 10:16:48 Dependency d of module f just finished succesfully. Module f must wait on 1 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Module e must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module e now
[terragrunt] 2017/01/05 10:16:48 Module e has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Dependency e of module f just finished succesfully. Module f must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module f now
[terragrunt] 2017/01/05 10:16:48 Module f has finished successfully!
--- PASS: TestRunModulesMultipleModulesWithDependenciesLargeGraphAllSuccess (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished with an error: Expected error for module a
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 1 dependencies to finish
--- PASS: TestResolveTerraformModulesMultipleModulesWithNestedExternalDependencies (0.00s)
[terragrunt] 2017/01/05 10:16:48 Dependency a of module b just finished with an error. Module b will have to return an error too.
[terragrunt] 2017/01/05 10:16:48 Module b has finished with an error: Cannot process module Module b (dependencies: [a]) because one of its dependencies, Module a (dependencies: []), finished with an error: Expected error for module a
[terragrunt] 2017/01/05 10:16:48 Dependency b of module c just finished with an error. Module c will have to return an error too.
--- PASS: TestToRunningModulesOneModuleNoDependencies (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module c has finished with an error: Cannot process module Module c (dependencies: [b]) because one of its dependencies, Module b (dependencies: [a]), finished with an error: Cannot process module Module b (dependencies: [a]) because one of its dependencies, Module a (dependencies: []), finished with an error: Expected error for module a
--- PASS: TestRunModulesMultipleModulesWithDependenciesMultipleFailures (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 1 dependencies to finish
--- PASS: TestToRunningModulesNoModules (0.00s)
[terragrunt] 2017/01/05 10:16:48 Dependency c of module b just finished succesfully. Module b must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b has finished with an error: Expected error for module b
[terragrunt] 2017/01/05 10:16:48 Dependency b of module a just finished with an error. Module a will have to return an error too.
[terragrunt] 2017/01/05 10:16:48 Module a has finished with an error: Cannot process module Module a (dependencies: []) because one of its dependencies, Module b (dependencies: [a]), finished with an error: Expected error for module b
--- PASS: TestRunModulesReverseOrderMultipleModulesWithDependenciesOneFailure (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency a of module b just finished succesfully. Module b must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b has finished with an error: Expected error for module b
[terragrunt] 2017/01/05 10:16:48 Dependency b of module c just finished with an error. Module c will have to return an error too.
[terragrunt] 2017/01/05 10:16:48 Module c has finished with an error: Cannot process module Module c (dependencies: [b]) because one of its dependencies, Module b (dependencies: [a]), finished with an error: Expected error for module b
--- PASS: TestRunModulesMultipleModulesWithDependenciesOneFailure (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Dependency c of module b just finished succesfully. Module b must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Dependency b of module a just finished succesfully. Module a must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
--- PASS: TestRunModulesReverseOrderMultipleModulesWithDependenciesSuccess (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency a of module b just finished succesfully. Module b must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module c must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency b of module c just finished succesfully. Module c must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Assuming module c has already been applied and skipping it
[terragrunt] 2017/01/05 10:16:48 Module c has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module d must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency c of module d just finished succesfully. Module d must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module d now
[terragrunt] 2017/01/05 10:16:48 Module d has finished successfully!
--- PASS: TestRunModulesMultipleModulesWithDependenciesWithAssumeAlreadyRanSuccess (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
--- PASS: TestResolveTerraformModulesInvalidPaths (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 1 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Dependency a of module b just finished succesfully. Module b must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Dependency b of module c just finished succesfully. Module c must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module c now
[terragrunt] 2017/01/05 10:16:48 Module c has finished successfully!
--- PASS: TestRunModulesMultipleModulesWithDependenciesSuccess (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
--- PASS: TestToRunningModulesTwoModulesWithDependenciesReverseOrder (0.00s)
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished with an error: Expected error for module a
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module b has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Module b has finished with an error: Expected error for module b
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b has finished successfully!
--- PASS: TestRunModulesMultipleModulesNoDependenciesSuccess (0.00s)
--- PASS: TestRunModulesMultipleModulesNoDependenciesMultipleFailures (0.00s)
[terragrunt] 2017/01/05 10:16:48 Dependency f of module e just finished succesfully. Module e must wait on 0 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Running module e now
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Module b must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module b now
[terragrunt] 2017/01/05 10:16:48 Module b has finished with an error: Expected error for module b
--- PASS: TestRunModulesMultipleModulesNoDependenciesOneFailure (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Running module a now
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
--- PASS: TestRunModulesReverseOrderMultipleModulesNoDependenciesSuccess (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module e has finished successfully!
[terragrunt] 2017/01/05 10:16:48 Dependency d of module b just finished succesfully. Module b must wait on 1 more dependencies.
[terragrunt] 2017/01/05 10:16:48 Dependency c of module b just finished with an error. Module b will have to return an error too.
[terragrunt] 2017/01/05 10:16:48 Module b has finished with an error: Cannot process module Module b (dependencies: [a]) because one of its dependencies, Module c (dependencies: [b]), finished with an error: Expected error for module c
[terragrunt] 2017/01/05 10:16:48 Dependency b of module a just finished with an error. Module a will have to return an error too.
[terragrunt] 2017/01/05 10:16:48 Module a has finished with an error: Cannot process module Module a (dependencies: []) because one of its dependencies, Module b (dependencies: [a]), finished with an error: Cannot process module Module b (dependencies: [a]) because one of its dependencies, Module c (dependencies: [b]), finished with an error: Expected error for module c
--- PASS: TestRunModulesReverseOrderMultipleModulesWithDependenciesLargeGraphPartialFailure (0.00s)
--- PASS: TestToRunningModulesTwoModulesWithDependencies (0.00s)
--- PASS: TestResolveTerraformModulesOneModuleWithIncludesNoDependencies (0.00s)
--- PASS: TestResolveTerraformModulesMultipleModulesWithDependenciesWithIncludes (0.00s)
--- PASS: TestResolveTerraformModulesOneModuleNoDependencies (0.00s)
--- PASS: TestResolveTerraformModulesNoPaths (0.00s)
[terragrunt] 2017/01/05 10:16:48 Module a must wait for 0 dependencies to finish
[terragrunt] 2017/01/05 10:16:48 Assuming module a has already been applied and skipping it
[terragrunt] 2017/01/05 10:16:48 Module a has finished successfully!
--- PASS: TestRunModulesOneModuleAssumeAlreadyRan (0.01s)
--- PASS: TestResolveTerraformModulesTwoModulesWithDependencies (0.00s)
--- PASS: TestResolveTerraformModulesMultipleModulesWithDependencies (0.00s)
--- PASS: TestToRunningModulesMultipleModulesWithAndWithoutDependencies (0.00s)
PASS
ok  	github.com/mechastorm/terragrunt/spin	0.038s
# github.com/mechastorm/terragrunt/test
test/integration_test.go:276: cannot use "github.com/mechastorm/terragrunt/vendor/github.com/aws/aws-sdk-go/service/s3".ListObjectVersionsInput literal (type *"github.com/mechastorm/terragrunt/vendor/github.com/aws/aws-sdk-go/service/s3".ListObjectVersionsInput) as type *"github.com/gruntwork-io/terragrunt/vendor/github.com/aws/aws-sdk-go/service/s3".ListObjectVersionsInput in argument to s3Client.ListObjectVersions
test/integration_test.go:294: cannot use deleteInput (type *"github.com/mechastorm/terragrunt/vendor/github.com/aws/aws-sdk-go/service/s3".DeleteObjectsInput) as type *"github.com/gruntwork-io/terragrunt/vendor/github.com/aws/aws-sdk-go/service/s3".DeleteObjectsInput in argument to s3Client.DeleteObjects
test/integration_test.go:299: cannot use "github.com/mechastorm/terragrunt/vendor/github.com/aws/aws-sdk-go/service/s3".DeleteBucketInput literal (type *"github.com/mechastorm/terragrunt/vendor/github.com/aws/aws-sdk-go/service/s3".DeleteBucketInput) as type *"github.com/gruntwork-io/terragrunt/vendor/github.com/aws/aws-sdk-go/service/s3".DeleteBucketInput in argument to s3Client.DeleteBucket
test/integration_test.go:311: cannot use config (type *"github.com/gruntwork-io/terragrunt/vendor/github.com/aws/aws-sdk-go/aws".Config) as type *"github.com/mechastorm/terragrunt/vendor/github.com/aws/aws-sdk-go/aws".Config in argument to dynamodb.New
FAIL	github.com/mechastorm/terragrunt/test [build failed]
=== RUN   TestListContainsElement
=== RUN   TestRemoveElementFromList
=== RUN   TestGetPathRelativeTo
=== RUN   TestCanonicalPath
=== RUN   TestGetRandomTime
--- PASS: TestCanonicalPath (0.00s)
--- PASS: TestListContainsElement (0.00s)
--- PASS: TestRemoveElementFromList (0.00s)
--- PASS: TestGetPathRelativeTo (0.00s)
--- PASS: TestGetRandomTime (0.00s)
PASS
ok  	github.com/mechastorm/terragrunt/util	0.023s
?   	github.com/mechastorm/terragrunt	[no test files]

👍

Wonderful, thanks!

Just created a new release here: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.7.4. Assuming the build passes, the new binaries should be there in a few minutes.

Seems the builds are failing since the merge - https://circleci.com/gh/gruntwork-io/terragrunt/196
Seems to be because of failing tests
-- FAIL: TestAcquireLockHappyPath (51.66s)
	Error Trace:	dynamo_lock_test.go:27
	Error:      	Expected nil, but got: &errors.Error{Err:(*awserr.requestError)(0xc420801020), stack:[]uintptr{0x47a210, 0x4798cd, 0x477b6b, 0x47f229, 0x473421, 0x45e421}, frames:[]errors.StackFrame(nil), prefix:""}
	Error Trace:	dynamo_lock_test_utils.go:52
			dynamo_lock_test.go:28
	Error:      	Expected nil, but got: &awserr.requestError{awsError:(*awserr.baseError)(0xc4205e3bc0), statusCode:400, requestID:"52M41GGOQMARVP3A8D5U02OOJ7VV4KQNSO5AEMVJF66Q9ASUAAJG"}
	Messages:   	Unexpected error: ResourceNotFoundException: Requested resource not found: Table: terragrunt_test_gCSkJD not found
	            		status code: 400, request id: 52M41GGOQMARVP3A8D5U02OOJ7VV4KQNSO5AEMVJF66Q9ASUAAJG

Kinda odd because I did not encounter that error in my test run.

@mechastorm Yea, I'm looking into it and trying to figure out what the cause is. There actually seem to be a few bugs at play, including one that has to do with DynamoDB resource limits (the automated tests are creating/deleting too many tables concurrently), and one that is mysteriously causing the tests to fail without a clear error message. Very confusing.

OK, apologies for the delay. There turned out to be two bugs:

The automated tests were trying to create/delete more DynamoDB tables concurrently than AWS allows. I've put in a counting semaphore to prevent this.
The latest version of the urfave/cli library, which we probably pulled in as part of this PR, added a new OsExiter setting which defaults to os.Exit. Because of this, when there was an error, the automated tests would exit without any useful error message, without running defered cleanup tasks, etc. This made it very hard to debug. I'm getting a bit fed up with urfave/cli, so if anyone has a recommendation for a better Go CLI library, let me know.

Both of these issues should now be fixed and the new binaries are available here: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.7.4


fixed select menu items

Deleted menu items need to be excluded
Thanks for the great module! Helped to develop a new frontend :)

Great Thanks!


Add syncer alias

First-time contributors' checklist

[ ] I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added, or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

[ ] master (the latest development version, including v3.0 changes)
[x] v2.0 (TiDB DM 2.0 versions)
[ ] v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s): https://github.com/pingcap/docs/pull/4542, https://github.com/pingcap/docs-cn/pull/5213

Do your changes match any of the following descriptions?

[ ] Delete files
[x] Change aliases
[ ] Need modification after applied to another branch
[ ] Might cause conflicts after applied to another branch

/merge


(MAINT) Bumpt to 4.0.0-SNAPSHOT

I think you missed some occurrences, try s/hsqldb//

this should be 3.2.0-SNAPSHOT, reopening

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://jenkins.puppetlabs.com/job/platform_puppetdb_intn-sys_pr/1851/


asr phone dict different from this

hi，
https://github.com/yl4579/StyleTTS/blob/eac67158fd21578ea950ff4d6734bf6e6434b6b5/meldataset.py#L28C5-L28C5
the pretrained ASR model use this ""AA0",10
"AA1",11
"AA2",12
"AE0",13
"AE1",14
"AE2",15
"AH0",16
"AH1",17
"AH2",18
"AO0",19
"AO1",20
"AO2",21
"AW0",22
"AW1",23",
Why？

Because it is a different model The ASR repo was made for StarGANv2-VC initially, while StyleTTS uses a different set of phonemes (IPA). I haven't updated the ASR repo yet, I will do so after I finish cleaning up the StyleTTS 2 code.


A preprocessor to create a cube of area/volume in m^2/m^3.

Hi,
After implementing some of the ice surface plots in pull request #609 , I was just wondering about creating a preprocessor that returns the total area or volume of a field.

For instance, this figure shows the total extent of the Arctic ice in squared meters for the HadGEM2-CC cmip5 historical run. The total ice extent is the total area where the sea surface has more than 15% ice cover. Note that the required threshold masking preprocessor has already been implemented with PR #549. At the moment, these values were calculated in the sea ice diagnostic script. If we were looking at (for instance) phytoplankton bloom volume, or total anoxic volume, the calculation is non-trivial and would benefit from being hidden behind a preprocessor. I propose creating two new preprocessors - one for 2D, another for 3D.
These preprocessors would need to take a standard 2D/3D cube return a scalar value (0D) cube with only a time dimension.. The new cube would also need to have a new standard_name (like ice extent), units, dimensions, etc.

What would be a good starting to implement this?
Is there an example of a preprocessor which completely changes the dimensionality, units and standard name of a cube?

Thanks!

@ledm a good starting point would be to think if this would be used by more than just one or two diagnostics, so that it can justify its status as a preprocessor function; if so, then ideally, a generalized function, say _compute_something_something_dark(args, Aggregator, **kwargs) would be ideal, where only the function sits in the preprocessor and depending on the type of Aggregator(**kwargs) it executes different calculations (equations) that can be stored in a utility script outside the preprocessor module. I dn't see the need to set a standard_name unless you need to save the cube, in any case setting the standard_name and a whole bunch of other metadata is easy, uless it needs to strictly adhere to CMOR, if it's just an output then you can set it to whatever

I suspect that this is the kind of preprocessor that would be useful in several places. Off the top of my head.:
Area calculations

Total ice extent/ice area (Sea ice)
Land surface area covered by dessert/forest/fire/ice (Land surface)

Volume calculations

Total anoxic volume (Ocean physics/chemistry)
Ocean Bloom volume/area (Ocean biogeocemistry)
Volcanic plume volume

Perhaps it would be more sensible to calculate the total area/volume in an add_total_volume_to_cube preprocessor and save it as an auxiliary data (or as an auxiliary coordinate) in the same cube? I don't know whether this is possible in iris.

Alternatively to creating a preprocessor function, you could also create a shared diagnostic script function, e.g. in esmvaltool/diag_scripts/shared/area.py (with the downside that those can be only used in a single programming language, i.e. if you write it in Python, you can only use it in Python diagnostics). I'm not sure what the best place (preprocessor function or shared diagnostic function) would be for the functionality that you propose, maybe @mattiarighi  has an opinion on this?
Preprocessed data is expected to pass a CMOR checks, so whatever you compute should be described in a CMOR table. Note that it is possible to add custom CMOR tables if the new field you compute does not have a table entry, this is done for example for derived variables.
To answer your question: this sounds very much like the area_average preprocessor function implemented by yourself, combined with the functionality of the derive module, maybe that could be a starting point?

I think it fits better under shared/.

I think that this issue was addressed when we added the support for FX files, which simplifies the calculations. We certainly don't need to add this as a preprocessor anymore.


Test aarch64-pc-windows-msvc

This is currently untested.

It is now tested as much as it can be with cross compiling.


Eloquent's fresh method does not run scope queries

Laravel Version: 8.54.0
PHP Version: 8.0.9
Database Driver & Version: mysql:8.0.17

Description:
There are additional columns appended to an Eloquent model using the addSelect in global scopes. fresh method on the model does not update the data for those columns. However, first method does. Is this an intended feature?
Steps To Reproduce:
Let's say we defined an anonymous scope for an Eloquent model Item allowing to get the saved status of each item for the authenticated user:

static::addGlobalScope('is_saved', function (Builder $builder) {
            $builder->addSelect([
                'is_available' => DB::table('item_user_saved')
                    ->join('items', 'item_user_saved.item_id', '=', 'items.id')
                    ->selectRaw('COUNT(*)')
                    ->whereColumn('item_user_saved.property_id', 'items.id')
                    ->where('item_user_saved.user_id', auth()->id())
            ]);
        });

When I create the model and then make some changes in the database, I need to update the model loaded in the memory to fill the properties as well as the is_available. I expect, $model->fresh() would do the job, but it does not run the scope queries.

Yes that's intended.


fix($httpBackend): remove Content-Type header on DELETE requests

Sending empty string with XMLHttpRequest's post method causes browsers adding unneeded Content-Type request header on DELETE requests. Chrome adds Content-Type:application/xml, Firefox and IE adds Content-Type text/plain. Sending null insted of empty string fixes the problem.
More detail: https://github.com/angular/angular.js/issues/2149#issuecomment-22664501

Was able to fix my related problem by setting the message body to null, which removes the Content-Type header in IE11
$http({
method: 'DELETE',
data: null,
url: ...
})


No more H1 in text webpart

Seems MS, in trying to conform to accessibility standard, will only allow one H1 per page, which means it's now reserved for page title. So text web part will now only have H2, H3, H4. They rolled out this change without documentation and warning. So the TOC web part is broken for now because they've rolled this out on my tenant.

I’ve not seen that on any of the tenants I have access to at the moment, but it doesn’t surprise me if Microsoft make changes without warning. Interestingly though, the ToC webpart doesn’t use H1 tags, as the text webpart has only ever used H2, H3 and H4. It is possible they have changed something else which has broken the ToC

Ah, I've figured it out. Because existing pages that have the ToC web part was created on the old styles with H1, they continue to render fine. Now that they rolled out that "new" compliant style to my tenant, when I edit an existing page, I have to go through all the headers on the page to reassign the new style and ToC will rebuild.


Automated Release Process

Signed-off-by: mgorsk1<EMAIL_ADDRESS>

I totally support this! We have been talking internally about this for a while.
In my mind, we would have a @ci or @next release process and an official monthly release cadence, so we cover both people looking for only stable releases or user trying to get the latest bug fixes.

Thanks @Golodhros , that's another thing I wanted to raise - intermediate releases (something in shape of release candidates). In ING to be as current as possible with latest changes in Amundsen now we rely on git submodules and building Amundsen components ourselves from maste, but having possibility to do pip install --pre would come definitely in handy.

slightly off-topic but releasing alongside docker images could also be useful and made onboarding Amundsen even easier

slightly off-topic but releasing alongside docker images could also be useful and made onboarding Amundsen even easier

@allisonsuarez are we ok to merge this RFC given all the work you did is merged?


Wayland Drag and Drop

Implements Drag and Drop for the Wayland backend.
This actually also fixes a bug in the previous implementation for the clipboard.
As the clipboard and drag and drop both use the wl_data_device, the dataDeviceHandleDataOffer callback is called for new clipboard and new drag and drop requests. So previously while an item has been hovered over the window the glfwGetClipboardString function would return the current drag and drop payload. The new version uses dataDeviceHandleSelection and dataDeviceHandleEnter to distinguish between clipboard and drag-and-drop data respectively.
Similar to the other backends, only the text/uri-list mimetype is handled. The uri-list is parsed with the parseUriList function which has been copied from the X11 backend. This function could be moved to a general utility file to remove this duplication.

Thank you! There was a lot to address in the clipboard and drop paths so the final commit ended up a bit different but this PR was very helpful!


fastdvdnet training

why did not the training process consider the case of noise mean not equal zero

Only AWGN was considered, each noise sample is uncorrelated with noise in other pixels--the mean value of this noise is zero


Center scrolling content on screen

Before
After

Ah, much better, thank you so much @meow-d!


[MM-19928] Change permissions error wording

Summary
This PR changes the channel subscription permissions error to:

You do not have permission to edit subscriptions for this channel. Subscribing to Jira events will create notifications in this channel when certain events occur, such as an issue being updated or created with a specific label. Speak to your Mattermost administrator to request access to this functionality.

This change was requested here https://github.com/mattermost/mattermost-plugin-jira/pull/372#pullrequestreview-310639140
Ticket Link
https://mattermost.atlassian.net/browse/MM-19928
Screenshots

Closing as this is already taken care of here https://github.com/mattermost/mattermost-plugin-jira/pull/379


Do not include cmap table with pid=0/eid=3 and name ids with platformID=1, platEncID=0

At least, NotoSansKhmer-VF.ttf has cmap table with pid=0 and eid=3. It also has variation-font related name ids with platformID=1, platEncID=0.
The former (cmap table) does not increase the file size much (~ 100 bytes) because the actual table is shared with pid=3/eid=1.  However, the latter increases the file size by ~ 4kB.
fontmake should not include those entries.
@marekjez86 @behdad @roozbehp

Static instances corresponding to NotoSansKhmer-VF.ttf also have cmap table with PID=0/EID=3.

About fvar-related name ids with platform 1 platEncID 0:
https://github.com/fonttools/fonttools/issues/683
https://github.com/fonttools/fonttools/issues/756

the cmap subtables are written by ufo2ft here:
https://github.com/googlei18n/ufo2ft/blob/b2db479a87cdc484c0b50f550478bb7b4983a6a5/Lib/ufo2ft/outlineCompiler.py#L381
I don't think it's worth dropping platform 0 (Unicode) cmap for just a few bytes.

I don't think it's worth dropping platform 0 (Unicode) cmap for just a few bytes.
I'm aware that the difference is very small because the actual data is shared, but Android wants to drop them anyway. @roozbehp

Thank you for the pointer the fvar-related name ids with PID/EID=1/0 on Mac. It appears that at least for now, PID/EID=1/0 name ids have to be removed when variation fonts are installed on other platforms if they do care about the size reduction.
@dougfelt

Close for now.


Massive memory spikes when MEMCG is enabled

While experimenting with massive consolidation of small docker containers, I ran into peculiar memory usage behavior. My setup is Docker 1.13.1, Linux kernel 4.9.9. I'm using a small container that runs a micropython script.
What I noticed is that the memory usage grew superlinearly, and showed massive spikes after spawning certain containers; see the purple line in the attached graph. After some digging, I tracked this behavior down to memory cgroups. When disabling the CONFIG_MEMCG option in the kernel, the behavior seems much more sane (see teal curve). As you can see, the spikes seem to occur at regular intervals, roughly doubling in interval and magnitude with each step.
I wonder whether Docker does something with cgroups that could explain this spiky behavior? Sadly, the Docker code base is quite large, so I didn't find where the cgroup management is done within docker. (Ignoring for the time being that I also don't have any real experience with Go.) I'm happy to try to provide more details, but I'm at a loss where to go from here to investigate further.

Steps to reproduce the issue:

Run docker run -d --rm --net=none <container> a few thousand times.
Measure memory consumption as containers are spawned.

Describe the results you received:
Memory usage spiking after a certain number of containers is spawned (see purple curve).
Describe the results you expected:
Roughly following the trend of the teal curve.
Additional information you deem important (e.g. issue happens only occasionally):
Fine print: I also tried this setup with some variations, all showing the same behavior:

Instead of the micropython container, I tried using a minimal container that does nothing but start a program that sleeps indefinitely, so the container itself doesn't seem to have any influence on the results shown below. (I didn't use the standard hello-world container, because I wanted to have something to continue running indefinitely.)
For speed reasons, the tests were done with the whole system running from a ramdisk, which required the DOCKER_RAMDISK environment variable to be set. However, a test while running from an NFS mount (without DOCKER_RAMDISK) showed similar behavior.
The tests were done with overlayfs, but aufs showed similar behavior.
You can see below that some cgroup options are missing. This is because I wanted to get a minimally-working example, starting from the Linux kernel's "make defconfig", without changing more than necessary. This doesn't really affect the results; enabling all cgroup options still gives the same behavior: if MEMCG is enabled, the memory spiking happens, otherwise, it does not.
I tried several older kernel versions, which showed the same behavior.
The machine is an Intel Xeon E5-1630 v3 3.7 GHz with 64GB of RAM. I tried other machines that behave similarly, with a tendency to gobble up more RAM as the number of cores increases.
The memory usage was measured by using the "free" command, plotting the used memory "-/+ buffers/cache".

Output of docker version:
Client:
 Version:      1.13.1
 API version:  1.26
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:36:34 2017
 OS/Arch:      linux/amd64

Server:
 Version:      1.13.1
 API version:  1.26 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   092cba3
 Built:        Wed Feb  8 06:36:34 2017
 OS/Arch:      linux/amd64
 Experimental: false

Output of docker info:
Containers: 3600
 Running: 3600
 Paused: 0
 Stopped: 0
Images: 2
Server Version: 1.13.1
Storage Driver: overlay
 Backing Filesystem: extfs
 Supports d_type: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: aa8187dbd3b7ad67d8e5e3a15115d3eef43a7ed1
runc version: 9df8b306d01f59d3a8029be411de015b7304dd8f
init version: 949e6fa
Kernel Version: 4.9.9-defconfig+igb+overlay+cgroupdev+bridge
Operating System: Debian GNU/Linux 8 (jessie)
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 62.81 GiB
Name: docker-bisect
ID: 76UN:MUPO:XPAI:IRNT:JZ7C:AS2N:NJF4:LBDW:FE7Y:ZF75:QPFZ:NYWF
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Http Proxy: http://<IP_ADDRESS>:8123
Https Proxy: http://<IP_ADDRESS>:8123
Registry: https://index.docker.io/v1/
WARNING: No memory limit support
WARNING: No swap limit support
WARNING: No kernel memory limit support
WARNING: No oom kill disable support
WARNING: No cpu cfs quota support
WARNING: No cpu cfs period support
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Additional environment details (AWS, VirtualBox, physical, etc.):
memory-1.13.1.pdf

If you want a simpler codebase you can look at runc which Docker is using to configure the cgroups. But the setup is fairly simple, and you can inspect it easily from the cgroup filesystem.
Can you make an easily reproducible test case? It makes it much easier to see what you are actually doing.

Thanks, I'll have a look.
As test case would probably comprise a Dockerfile and a shell script that starts the test environment?

Yes, anything that I can run and replicate.

OK, I'll bundle up a minimal use case. It will take me until the end of the week to get around to it, though.

So you aren't specifying memory limits at all?

Not knowingly, no. If any limits are set, they would have to come from defaults. And since I'm running these tests as root, I don't think there should be any default limits.

I found some time this evening to prepare a minimal case. Here's a tarball (instructions inside). Hope this works on your side.
minimalcase.tar.gz

Any news on this? Anything I can do to track this down further?

Asked @justincormack but he didn't have time yet to look into it
ping @ijc25 perhaps you have ideas?

I dug a bit deeper today. The graphs in the initial post show that memory is used up at an increasing rate, with prominent spikes. But where is it used? I noticed that /proc/meminfo showed a lot of memory used by slab, so I collected /proc/slabinfo after spawning each container. There are a few noticeable differences. For one, when CONFIG_MEMCG is enabled, a lot of extra memory is used in the slab cache for proc_inode_cache and dentry (about 4GB and 1GB more respectively). The first one sounds to my untrained ears like a cache that would go away under memory pressure, though, and an additional GB of dentries won't make a big difference considering the big picture.
The largest contributor is, strangely enough kmalloc-32, and it matches the overall behavior of the memory usage curve very well: see here the numer of kmalloc-32 items in the slab cache and the resulting memory usage (for this, I assumed no overhead at all: bytes = 32*items, which is most probably an underestimation; by how much, I cannot tell). The curve for the setup without MEMCG isn't missing: It's just so low it's barely visible. At 3600 containers, the numbers are ~316000 vs ~389 million items. That's (using the conservative estimation) almost 11.8 GB, which accounts for slightly more than half of the 22.3 GB difference at 3600 containers.
To get an idea just how much the curves correlate in the MEMCG scenario, here is a plot of the overall memory usage of the system (from the last post) and the memory usage of the kmalloc-32 slab cache (as in the above graph), in one graph.
So. Hm. Now I'm not really sure where to go from here.
attachments:
kmalloc32.pdf
overall-kmalloc32.pdf

@fajs: Can you test with a vanilla kernel? Can you test with the latest 4.9.x kernel and with 4.10, please?

@unclejack I can test with a 4.10. Considering that this behavior happens over a bunch of versions though (I checked back to at least some 4.6 version if I remember correctly), I'm not holding my breath. The kernels I tested are about as vanilla as it gets, I think. linux-stable repository, checked out to specific version tags, configured with make defconfig, only enabling what was necessary for me to get the tests running.

@fajs: Can you post the config for 4.10, please? I'd like to use the same config you've used to try to reproduce this.
I apologize for the late reply. GitHub doesn't send notifications for edited comments.

@unclejack Here's the config. This one produces the large memory consumption. You should be able to see the more "sane" behavior simply by taking this same config, and disabling CONFIG_MEMCG.
Yes, editing the answer probably wasn't the smartest move on my part.

Just wondering, any news about this?


[Docs] Move Review App docs to own file

I was looking for these docs yesterday (thinking that at one point I had seen the file in the docs folder) but then stumbled on the script, thinking that the docs in the shell script were all there were. To make things clearer, I moved the existing docs out of Contributing and into its own file, discoverable from the file-tree.

Warnings

:warning:
The staging version of Metaphysics has breaking changes, this might not affect your build, but could mean your queries don't work the way you expect. See below for breaking changes:

:warning: Type for argument 'ids' on field 'Query.submissions' changed from '[ID]' to '[ID!]'
:warning: Argument 'user_id: [ID]' was removed from field 'Query.submissions'
:warning: Field 'additional_info' was removed from object type 'ConsignmentSubmission'
:warning: Field 'artist_id' was removed from object type 'ConsignmentSubmission'
:warning: Field 'authenticity_certificate' was removed from object type 'ConsignmentSubmission'
:warning: Field 'created_at' was removed from object type 'ConsignmentSubmission'
:warning: Field 'dimensions_metric' was removed from object type 'ConsignmentSubmission'
:warning: Field 'edition_number' was removed from object type 'ConsignmentSubmission'
:warning: Field 'edition_size' was removed from object type 'ConsignmentSubmission'
:warning: Field 'location_city' was removed from object type 'ConsignmentSubmission'
:warning: Field 'location_country' was removed from object type 'ConsignmentSubmission'
:warning: Field 'location_state' was removed from object type 'ConsignmentSubmission'
:warning: Field 'minimum_price_dollars' was removed from object type 'ConsignmentSubmission'
:warning: Field 'user_id' was removed from object type 'ConsignmentSubmission'
:warning: Field 'asset_type' was removed from object type 'ConsignmentSubmissionCategoryAsset'
:warning: Field 'gemini_token' was removed from object type 'ConsignmentSubmissionCategoryAsset'
:warning: Field 'image_urls' was removed from object type 'ConsignmentSubmissionCategoryAsset'
:warning: Field 'submission_id' was removed from object type 'ConsignmentSubmissionCategoryAsset'
:warning: Type for argument 'input' on field 'Mutation.addAssetToConsignmentSubmission' changed from 'AddAssetToConsignmentSubmissionInput' to 'AddAssetToConsignmentSubmissionInput!'
:warning: Type for argument 'input' on field 'Mutation.createConsignmentSubmission' changed from 'CreateSubmissionMutationInput' to 'CreateSubmissionMutationInput!'
:warning: Type for argument 'input' on field 'Mutation.updateConsignmentSubmission' changed from 'UpdateSubmissionMutationInput' to 'UpdateSubmissionMutationInput!'

  Generated by :no_entry_sign: dangerJS against 408eb0f42bea99e331da69703bdd8807822eb923

Sounds good! I've made this mistake too.
cc @anandaroop who I believe added this doc in the first place 😄.

Awesome, thanks!
I updated this doc with the Reaction canary steps a few months ago. Some of that may be obsolete now in light of https://github.com/artsy/reaction/pull/3168 — but that can be a separate change.
Thanks for moving this to a clearer location.


BUG: Update Debug tools with new Combinatorial Spaces

Currently the Debug tools still use the :src and :tgt instead of :∂v0 and :∂v1. This should be updated, and tests added to Debug.jl

Resolved with #31. Will add separate issue for building the test suite


Analyzer thinks that Equality.hash override is renaming a parameter from Object.hash

Starts after https://github.com/dart-lang/sdk/commit/83376bf1ee81607a182f8558b242f1c9f4883246
More context in https://github.com/flutter/flutter/pull/85364
I tried to reproduce this in a smaller project but could not.
@pq @bwilkerson

Possible duplicate of https://github.com/dart-lang/sdk/issues/31201?

@scheglov

@dnfield what was a non-small project on which it can be reproduced? I tried to remove the corresponding // ignore in dev/integration_tests/web/lib/stack_trace.dart:156, but even then flutter/dev/integration_tests/web can be analyzed without diagnostics.

@dnfield Actually, I see that the lint is reported when I debug. But for some reason it is not printed by analyzer CLI. So, I don't need anything from you at the moment. Thanks :-)

OK, I see that ClassElement.lookUpInheritedMethod() uses ClassElement.getMethod() and does not check whether the method is static. This is a quite old code. We probably should rewrite it using InheritanceManager3, which skips static members.

@pq @bwilkerson What is the expected way avoid_renaming_method_parameters should work when you implement an interface and so that you strongly speaking don't "override" the method. Should we still report the lint?
class A {
  void foo(int a) {}
}
class B implements A {
  void foo(int a2) {}
}

What if the method is declared both in the superclass, and an implemented interface, and the name in the override is not the same as in (1) the superclass, (2) the interface?
class A {
  void foo(int a1) {}
}
class B {
  void foo(int a2) {}
}
class C extends A implements B {
  void foo(int a3) {}
}

One issue with ClassElement.lookUpInheritedMethod() is that it returns you just one, the most specific element, not all of them. For all overridden elements we need to use InheritanceManager3.getOverridden2(). My CL loosely keeps status quo, but I wonder if that status quo is satisfactory.

Should we still report the lint?

The rationale for the lint reads (emphasis mine):

Methods that override another method, but do not have their own documentation
comment, will inherit the overridden method's comment when dartdoc produces
documentation. If the inherited method contains the name of the parameter (in
square brackets), then dartdoc cannot link it correctly.

If the issue is doc comments copied from elsewhere, and if dartdoc copies comments from interfaces (which I believe that it does), then it should also flag methods that aren't technically overrides but do implement a method inherited from an interface.

What if the method is declared both in the superclass, and an implemented interface, and the name in the override is not the same as in (1) the superclass, (2) the interface?

Then I suppose it ought to compare against the method from which the doc comment will be copied. I'm guessing that dartdoc would copy from (1) before (2).

It seems (from my experiment, not from looking into the implementation) that dartdoc always copies from the superclass, so if the superclass does not have the doc comment, it is not copied from the interface. Hm... Maybe my change to InheritanceManager3 was too radical. It changes the behavior of the method.
I guess we could just fix ClassElement.lookUpInheritedMethod() to skip static methods.
It still feels somewhat unsatisfactory, because I cannot put a finger on what lookUpInheritedMethod should return. It is not the thing that would be invoked with super.foo(), because that should be concrete. It is just whatever is the closest in the superclass hierarchy. Or maybe "why" it returns whatever it returns, because it is not in the spec. But we decided that it is something useful for clients.
Anyway, my change it not right, because formally it breaks API. I will rework it to be a fix.

... it is not copied from the interface.

@jcollins-g Is that really the expected behavior? In the analyzer code base we tend to treat implementations of methods from interfaces as overrides (in the sense of not repeating the doc comment).

... I cannot put a finger on what lookUpInheritedMethod should return.

It was probably intended to return a value that made sense in Dart 1 (or even earlier) that no longer makes sense. It's possible that we should deprecate it in favor of more specific lookup methods, but I'd have to look at where it's being used to have a concrete suggestion for what those would be.

Or maybe "why" it returns whatever it returns ...

Server might well be using it to copy doc comments for things like hovers. I would expect that doc lookup wouldn't care whether the nearest overridden method were abstract, only whether it has a comment.

I landed the fix as https://dart-review.googlesource.com/c/sdk/+/205180.
We seem to use some of these methods for recovery.
analysis_server copies documentation from implemented interfaces for hover, not only from superclass.

It seems (from my experiment, not from looking into the implementation) that dartdoc always copies from the superclass, so if the superclass does not have the doc comment, it is not copied from the interface. Hm... Maybe my change to InheritanceManager3 was too radical. It changes the behavior of the method.
I guess we could just fix ClassElement.lookUpInheritedMethod() to skip static methods.
It still feels somewhat unsatisfactory, because I cannot put a finger on what lookUpInheritedMethod should return. It is not the thing that would be invoked with super.foo(), because that should be concrete. It is just whatever is the closest in the superclass hierarchy. Or maybe "why" it returns whatever it returns, because it is not in the spec. But we decided that it is something useful for clients.
Anyway, my change it not right, because formally it breaks API. I will rework it to be a fix.

The new lookup code is going to copy documentation like the old one, but

(clicked the wrong button, sorry for close/reopen)

... it is not copied from the interface.

@jcollins-g Is that really the expected behavior? In the analyzer code base we tend to treat implementations of methods from interfaces as overrides (in the sense of not repeating the doc comment).

I am not sure I understand the question.  Documentation should be copied from the interface, just as it would be copied from a superclass implementation.  Dartdoc is supposed to follow the inheritance chain and stop at the first supertype that has documentation for a method, e.g.:
abstract class A {
  /// I have documentation
  void method();
}

class B implements A {
   @override
   void method() {
     // I have an implementation but no doc comment
   }
}

class C extends B {
   /// I have an implementation and a doc comment
   @override
   void method() {}
}

Here, C.method should have its own documentation, and B.method should have A.method's documentation.  If it doesn't, that's a bug.
The old lookup code would render A.method's doc for B.method in B's context.   This worked well when referring to member variables, but not to parameters or the defining namespace for A, and so forth.
The new lookup code is "smarter" in that it looks up in the context documented first, but if it can't find something there, looks up via the defining context.    This lessens the need for a lint slightly, as Dartdoc will now know what you meant instead of emitting an unresolved-doc-reference warning, but it still would look better to the user if they didn't do that.
As an aside, documentation inheritance behavior is another of the ambiguous scoping problems in dartdoc that I'm hoping will be possible to address eventually...

... I cannot put a finger on what lookUpInheritedMethod should return.

It was probably intended to return a value that made sense in Dart 1 (or even earlier) that no longer makes sense. It's possible that we should deprecate it in favor of more specific lookup methods, but I'd have to look at where it's being used to have a concrete suggestion for what those would be.

Or maybe "why" it returns whatever it returns ...

Server might well be using it to copy doc comments for things like hovers. I would expect that doc lookup wouldn't care whether the nearest overridden method were abstract, only whether it has a comment.

+1.

Similar fixes for other ClassElement methods.
https://dart-review.googlesource.com/c/sdk/+/205360


Update README.md

PR Type
documentation

Description

Added a new section titled describe to the README.md file.
Included a brief description of the project in the new section.

Changes walkthrough 📝
Relevant filesDocumentation

README.mdAdded a new section with project description.

README.md
Added a new section titled describe.  Included a brief description of the project.

+4/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Preparing PR description...

PR Description updated to latest commit (https://github.com/tomorrowthief/Flowise/commit/0e689c9e1f54696b3029703e035024fcdf4a6c70)


save_topk_models() timeout in when num_trainer > 0

I get this error when using num_trainer > 0. It seems like a multi-process dead-lock issue according to Timed out waiting 1800000ms for recv operation to complet?
Full error:
Traceback (most recent call last):
  File "main_ssl.py", line 156, in <module>
    main(args)
  File "main_ssl.py", line 134, in main
    trainer.fit(
  File "/home/ubuntu/workspace/ssl_utils.py", line 207, in fit
    early_stop = True
  File "/usr/local/lib/python3.8/dist-packages/graphstorm-0.1.0.post1-py3.8.egg/graphstorm/trainer/gsgnn_trainer.py", line 263, in save_topk_models
Traceback (most recent call last):
  File "main_ssl.py", line 156, in <module>
      File "/usr/local/lib/python3.8/dist-packages/graphstorm-0.1.0.post1-py3.8.egg/graphstorm/trainer/gsgnn_trainer.py", line 190, in save_model
main(args)
  File "main_ssl.py", line 134, in main
  File "/home/ubuntu/.local/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 2791, in barrier
    trainer.fit(
  File "/home/ubuntu/workspace/ssl_utils.py", line 147, in fit
    work.wait()
RuntimeError: [../third_party/gloo/gloo/transport/tcp/unbound_buffer.cc:81] Timed out waiting 1800000ms for recv operation to complete
    loss.backward()
  File "/home/ubuntu/.local/lib/python3.8/site-packages/torch/_tensor.py", line 396, in backward
    torch.autograd.backward(self, gradient, retain_graph, create_graph, inputs=inputs)
  File "/home/ubuntu/.local/lib/python3.8/site-packages/torch/autograd/__init__.py", line 173, in backward
    Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
RuntimeError: [../third_party/gloo/gloo/transport/tcp/pair.cc:598] Connection closed by peer [<IP_ADDRESS>]:33476
Client[4] in group[0] is exiting...
Client[7] in group[0] is exiting...

I got the above error by using single machine standalone mode with num_trainer=2 and num_sampler=8, with torch=1.12.0.

I am still having this error when using graphstorm=0.2 version. It seems like the code was stopped at th.distributed.barrier() https://github.com/awslabs/graphstorm/blob/d010ed45d549cf4a3029854053f6dc0354ccf2aa/python/graphstorm/trainer/gsgnn_trainer.py#L190C1-L191C1 to wait for the sparse optimizer to update its parameters? Its not a storage issue as I still have more than 1.2 T available.
My implementation is based on GSgnnLinkPredictionTrainer and its save_model part is using existing graphstorm's functions. The code can successfully save models for already 28 rounds, therefore it should be a RAM OOM issue ... To reproduce this error, one can just take the MAG link prediction example, adding learnable node embedding to all nodes, and frequently save model params.
Epoch 00000 | Batch 14460 | Train Loss: 0.2059 | Time: 0.8983
Epoch 00000 | Batch 14480 | Train Loss: 0.1833 | Time: 0.9150
Traceback (most recent call last):
  File "main_ssl.py", line 90, in <module>
Traceback (most recent call last):
  File "main_ssl.py", line 90, in <module>
    main(args)
  File "main_ssl.py", line 74, in main
    trainer.fit(
  File "/home/ubuntu/workspace/step_by_step_dev/trainer.py", line 86, in fit
    main(args)
  File "main_ssl.py", line 74, in main
    trainer.fit(
  File "/home/ubuntu/workspace/step_by_step_dev/trainer.py", line 108, in fit
    early_stop = self.save_topk_models(
  File "/home/ubuntu/workspace/step_by_step_dev/trainer.py", line 168, in save_topk_models
    self.optimizer.step()
  File "/home/ubuntu/pytorch-1-12-0/lib/python3.8/site-packages/graphstorm-0.2-py3.8.egg/graphstorm/model/gnn.py", line 100, in step
    self.save_model(model, epoch, i, save_model_path)
  File "/home/ubuntu/pytorch-1-12-0/lib/python3.8/site-packages/graphstorm-0.2-py3.8.egg/graphstorm/trainer/gsgnn_trainer.py", line 190, in save_model
  File "/home/ubuntu/pytorch-1-12-0/lib/python3.8/site-packages/dgl/distributed/optim/pytorch/sparse_optim.py", line 343, in step
  File "/home/ubuntu/pytorch-1-12-0/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 2791, in barrier
    alltoall_cpu(
  File "/home/ubuntu/pytorch-1-12-0/lib/python3.8/site-packages/dgl/distributed/optim/pytorch/utils.py", line 26, in alltoall_cpu
    dist.scatter(
  File "/home/ubuntu/pytorch-1-12-0/lib/python3.8/site-packages/torch/distributed/distributed_c10d.py", line 2359, in scatter
    work.wait()
RuntimeError: [../third_party/gloo/gloo/transport/tcp/unbound_buffer.cc:81] Timed out waiting 1800000ms for recv operation to complete
Client[3] in group[0] is exiting...
    work.wait()
RuntimeError: [../third_party/gloo/gloo/transport/tcp/pair.cc:598] Connection closed by peer [<IP_ADDRESS>]:53988
Client[0] in group[0] is exiting...


v11.0.0

Codecov Report

Merging #36 (a100254) into master (24dfd71) will increase coverage by 0.10%.
The diff coverage is 98.75%.

:exclamation: Current head a100254 differs from pull request most recent head 7a9ccd1. Consider uploading reports for the commit 7a9ccd1 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   96.96%   97.06%   +0.10%
==========================================
  Files          19       19
  Lines        1218     1261      +43
==========================================
+ Hits         1181     1224      +43
  Misses         37       37

Impacted Files
Coverage Δ

lib/src/text/text_field.dart
100.00% <ø> (ø)

lib/src/check/switch.dart
98.64% <93.33%> (-1.36%)
:arrow_down:

lib/src/check/checkbox.dart
100.00% <100.00%> (ø)

lib/src/date_time/calendar.dart
100.00% <100.00%> (ø)

lib/src/date_time/date_picker.dart
93.24% <100.00%> (+0.09%)
:arrow_up:

lib/src/date_time/date_range_picker.dart
98.24% <100.00%> (+0.03%)
:arrow_up:

lib/src/date_time/time_picker.dart
100.00% <100.00%> (ø)

lib/src/form.dart
96.25% <100.00%> (+0.46%)
:arrow_up:

lib/src/options/choice_chips.dart
98.43% <100.00%> (+0.05%)
:arrow_up:

lib/src/slider/range_slider.dart
100.00% <100.00%> (ø)

... and 1 more


Training code

Thanks for your excellent work.
Is there any plan to release the training code recently?

The results in Fig. 3 are amazing. However, it seems that I could not find the corresponding images in the testing set (the released result.
Could you provide more details regarding it?
Thanks


Refactor wego-app service account role binding

Since we are now "additive to flux" we need to change some things about how GitOps Core is installed and run on the cluster:

Do we run in the flux-system namespace now?
What permissions does our service account need now?
Do we need to make any changes to our installation command to support this?

Acceptance Criteria:

Ensure that wego-app can start and run on a cluster via the install command (v2 branch)

@J-Thompson12 do you have the helm chart that you created?  This might be useful here so people can just add a helm chart and helm release.

This is a POC and we want to move it into its own repo for actual use but here is what I had. https://github.com/weaveworks/weave-gitops/pull/1409

Just a couple of questions for whoever is up, if i discover the answers in the meantime I will update so please ignore.

Do we run in the flux-system namespace now?

These feels like a product-y decision, but for now I am going to say "yes" and can move around if the decision changes.

What permissions does our service account need now?

I am guessing that the service account (and associated role) in question is the one in manifests/wego-app?

Do we need to make any changes to our installation command to support this?

I am guessing that this depends on whether we want to start installing wego via a Helm Chart, on which note...

This might be useful here so people can just add a helm chart and helm release. This is a lighter weight approach from updating install which is going to change drastically by the "clear the way" team.

Is the plan then to have a Helm Chart be "the" way to install wego and (going from that quote) not have it be done through the install command at all? What would the user experience be? (there is some form of Helm chart for wego here)

@Callisto13

I am guessing that the service account (and associated role) in question is the one in manifests/wego-app?

Yes.

Is the plan then to have a Helm Chart be "the" way to install wego and (going from that quote) not have it be done through the install command at all? What would the user experience be? (i'm guessing once their source repo has been created they can just push the chart to it?) (there is also some form of Helm chart for wego here but i doubt it is of any use.)

@sympatheticmoose @JamWils ^^

testing something

Is the plan then to have a Helm Chart be "the" way to install wego and (going from that quote) not have it be done through the install command at all?

During the "clear the way" we will no longer have the command for gitops install.  Instead the user is expected to run flux bootstrap manually and then add the helm chart and release to their repository.
We have a separate initiative where we are supporting an "official" version of flux.  During that initiative we will add gitops bootstrap and gitops install back into the application, but they will add the helm chart and release instead of having the manifest folder like we do today.

👍  yep thank you

@ozamosi can you confirm whether your side are touching just the install command or if you will also be changing anything around the wego installation manifests?

Sorry, I missed this comment. This is in scope for clear the way, we've not started work on it yet.

A thought: If we are going to make the wego pod role impersonate only, then should WEAVE_GITOPS_AUTH_ENABLED be on by default in the Chart (with customers expected to configure their users)? Otherwise in the default case there will be noone for the server to impersonate. For dev we can have it disabled unless explicitly testing that feature

One thing I've learned in my spike is that the impersonation setup is mostly done in the leaf cluster. It will only the there that we'll need to setup impersonate rbac rules
Here is a example on how that setup needs to be done: https://github.com/weaveworks/weave-gitops/pull/1556/files#diff-63fa25e919d6252750928dd7f73dfc4da5e7388073361c9ed8dbcb9d557919fb
On the wego-server side we only need to make sure to add the Impersonate details, for instance, user and teams, in every call.


How to update ngModel on colour click and not on select button?

Thanks for an excellent job on the colour picker @brianpkelley. I am trying to get the value of a selected colour on the mouseDown event (clicking on any of the colours) and not the 'Select' button. The requirement is that we should preview the chosen colour on our custom component before clicking the 'Select' button and closing the dialogue. Any suggestions to achieve this without changing the source code?

@ihanif  Did you find a workaround for this?

This has been fixed in 6ff793c47066cf121211c10dfa3b870ece0a0d29
Sorry, I'm not sure how to get the same functionality without modifying the source.
You can demo it here: http://labs.tastybytes.net/mdColorPicker/demo/


Fix up Windows-related first-run examples.

Touch command does not exist in windows cmd. Prepare the user for the hundreds of lines of messages generated on first run.

If Windows is supported, do it. Don't just expect users to translate from Linux commands.


fix(decode): handle pubkey flag

nak decode's subcommand accepts a --pubkey flag to print only the pubkey if applicable instead of JSON, however it wasn't being used.

Thank you very much.


Preview doesn't work in breadboard debug

When clicking on "Preview"

I get this in DevTools console:

I am guessing some files are missing maybe? Or logic?

Ah this usually happens when the web server does a rewrite of the preview URL and casually removes the search params. I'll take a look.

Aye, the change was here: https://github.com/breadboard-ai/breadboard/commit/2b105e084608306e9471c647b6ff8f9bba6c639c#diff-d91b32ed90d91eb4b06379bf47fe78decec71153dfc5cdf14210163596c34db6R146 – just finding out why.

Looks like there might be a case where something doesn't work, but it's not clear. So I've reverted it for now, but in the event we find a case where the lack of clean URLs is causing problems, I'll fix it.


Add support for YouTube IFrame API already being loaded

In cases where the YouTube IFrame API has already been loaded on the page, the video big directive does not work because the YouTubeIframeApiReady event never fires.

#15

Please accept #23 , it will fix this bug

Thanks for fixing this.


Menu tests finished

This PR solves the tests for Issue #4 [Create Menu Screen] and also fix the tests for #11 [Landing page]

This PR looks good and logical.


secret-service: Deleting a secret does not remove it from the respective role

Environment

Client OS (e.g., Linux, macOS, Windows): Linux
Keptn Version (keptn version): 0.14.2
Kubernetes Cloud Provider (e.g., GKE, AKS): K3d 1.21
Kubernetes version (kubectl version): 1.21

Affected Component

[x] secret-service

Describe the bug
When deleting a secret, it is not removed from the respective role. Worst-case, we end up having the same secret multiple times within the role.
To Reproduce

Create secret

$ keptn create secret secret-1 --scope="keptn-prometheus-service" --from-literal="KEY=VALUE"

Verify role

$ kubectl -n keptn get role keptn-prometheus-svc-read -oyaml
...
rules:
- apiGroups:
  - ""
  resourceNames:
  - secret-1
  resources:
  - secrets
  verbs:
  - get

Delete secret

$ keptn delete secret secret-1

Verify role again - secret-1 is still in there
Add secret again

$ keptn create secret secret-1 --scope="keptn-prometheus-service" --from-literal="KEY=VALUE"

Verify role

rules:
- apiGroups:
  - ""
  resourceNames:
  - secret-1
  - secret-1
  resources:
  - secrets
  verbs:
  - get

Expected behavior
secret-1 should be removed when we call keptn delete secret
Current behavior
secret-1 stays in the role, and is duplicated over and over again

Problem here is, that the secret was created with scope "keptn-prometheus-service" and deleted without giving a scope (then scope "keptn-default" will be applied. The secret is deleted tho. But it cannot update the references wrt to roles and stuff bc it's using the wrong scope.

Problem here is, that the secret was created with scope "keptn-prometheus-service" and deleted without giving a scope (then scope "keptn-default" will be applied).

Understood. If that's the case, we should check and alarm the user in case of a wrong scope.

The secret is deleted tho.

Exactly... this leads to an inconsistent state, and also duplicates.
I'm fine with setting keptn delete secret ... --scope=keptn-prometheus-service, but I think secret-service should check that the secret scope is correct before deleting the secret.

I'm fine with setting keptn delete secret ... --scope=keptn-prometheus-service, but I think secret-service should check that the secret scope is correct before deleting the secret.
sure :)


Security/Dep: fix RUSTSEC-2024-0019 by bumping mio

Fixes #37.

Thanks

Assuming you don't have other stuff in your dev pipeline at the moment that you're waiting to merge would you mind bumping the version number so I can include this patch on Arch? Thanks!


✔ question 4 passing

that'll do Aloysious, that'll do

                  🚧 What we do this time? 🚧
------------------------------------------------------------------
[x] wrote a function named `greeting` that took in a single
string and returns the string in all uppercase letters,
and followed by an "!".
[x] wrote a function named `speaker` that takes in an array of strings
and a callback function.
[x] used `forEach` to build a new array of strings,
each string was modified by the callback.
[x] returned the new array.
💻 Github
💼 Linkedin


Loading graphic exceeds 100%

Description
During the initial loading of a json file, the progress bar exceeds 100%
This only happens when using the latest develop versions, where a new algorithm and data model is used for recording file counts etc. These counts are used to animate the progress bar, so it makes sense that this bug would occur.
See:

#300 merged, closing this.


tiltfile: extensions should reset state in OnStart

Hello @jazzdan, @maiamcc,
Please review the following commits I made in branch nicks/k8scontext:
17b2e34f0c0a894d7f86b8404cefd689322a3083 (2019-10-15 13:52:26 -0400)
tiltfile: extensions should reset state in OnStart

i need to think of a better way to manage extension state...one possibility is that all extensions should be non-stateful, and attach their state to the starlark thread.


refactor: streamline and cleanup i18n 📦

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[ ] Feature
[x] Refactoring

What's new?

[x] PR closes #2096
[x] only rely on nuxt-i18n and use current i18n.ts file as config for nuxt-i18n. sadly we cannot get rid of markdownit.

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[ ] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 100 usd

😍 Perfect, I’ve sent the payout
💵 $100 @ 118.72 USD/KSM ~ 0.842 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0x2ba17bd9a2882f0e4d72e1e663a5e1f16439f004d158899dedd3674e7a297ba5
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Handle empty branches

I thought I handled empty commits and diff branches, but I realized I didn't.

How about output commit hash and diff hash instead of outputting nothing.

How about output commit hash and diff hash instead of outputting nothing?

I think the change of this PR provides the feature.

Am I missing something??
# build
(~/go_projects/git-ghost/src/git-ghost)
 [handle-empty-branch|✚ 1…2⚑ 1] $ make
dep ensure
go build -tags netgo -installsuffix netgo -ldflags="-s -w -X \"github.com/pfnet-research/git-ghost/cmd.Version=v0.1.1-dev\" -X \"github.com/pfnet-research/git-ghost/cmd.Revision=0f56d0f\" -extldflags \"-static\"" -o /Users/everpeace/go_projects/git-ghost/src/git-ghost/dist/git-ghost

(~/go_projects/git-ghost/src/git-ghost)
 [handle-empty-branch|✚ 1…2⚑ 1] $ make install
dep ensure
go install -tags netgo -installsuffix netgo -ldflags="-s -w -X \"github.com/pfnet-research/git-ghost/cmd.Version=v0.1.1-dev\" -X \"github.com/pfnet-research/git-ghost/cmd.Revision=0f56d0f\" -extldflags \"-static\""

# at repo
$ git remote -v
origin  git@github.pfidev.jp:omura/git-ghost-test.git (fetch)
origin  git@github.pfidev.jp:omura/git-ghost-test.git (push)

$ export | grep GIT_GHOST
declare -x GIT_GHOST_REPO="git@github.pfidev.jp:omura/git-ghost-test.git"

$ git status
HEAD detached at 0563ef1
nothing to commit, working tree clean

$ ~/go_projects/git-ghost/bin/git-ghost push
## Nothing output ###

I confirmed your change correctly works!  Thanks!


agent state to 2D pose

❓ Questions and Help
I was trying to convert agent state into a 2D pose tuple (x, y, theta). I followed some existent code, but the result doesn't seem to be correct.
Here is the code.
position = sim.get_agent_state().position
rot = sim.get_agent_state().rotation
pose = [0.0, 0.0, 0.0]
pose[0] = position[0] # for x
pose[1] = position[2] # for y

direction_vector = np.array([0, 0, -1])
heading_vector = quaternion_rotate_vector(rot.inverse(), direction_vector)
pose[2] = cartesian_to_polar(-heading_vector[2], heading_vector[0])[1] # for theta

Can you give more information about why "the result doesn't seem to be correct"?  This is the 2D pose of the agent in some coordinate system, but maybe not the coordinate system you are expecting.

I want the agent to be in 2d world coordinate system that x,y-coordinates achieve minimum value at left-bottom corner.

Using the current code I give, the pose is not consistent when the agent moves in some direction.

You'll need to correct the angle like here: https://github.com/facebookresearch/habitat-api/issues/109#issuecomment-499668103

I've computed the angle like that before by adding pi/2 to the negative angle but it doesn't seem to be right.
For example, when the agent turns left by pi/6, the pose (x, y, theta) changes from (7.35, -4.61, 0.74) to (7.35, -4.61, 0.21), which should be (7.35, -4.61, 0.74 + pi/6) = (7.35, -4.61, 1.25) if the computation is right.
When the agent moves forward by 0.3, the agent moves from (6.76, -4.74, 0.21) to (6.47, -4.80, 0.21), which is not right as the correct next pose should be (6.76 + 0.3*cos(0.21), -4.74 + 0.3*sin(0.21), 0.21) = (7.06, -4.74, 0.21) if the computation is right.
Sorry to bother you so much.

@stbook, does HEADING_SENSOR work for you? You can use theta from  observations["heading"].
Otherwise, that would be cleaner if you can provide test that shouldn't fail but fails in form like this:
def test_heading_vector():
    config=habitat.get_config("./configs/tasks/pointnav.yaml")
    env = habitat.Env(config)
    observations = env.reset()
    state_start = env.sim.get_agent_state()
    env.step("TURN_RIGHT")
    env.step("TURN_RIGHT")
    state_final = env.sim.get_agent_state()
    ... <your code calculating angles> ...
    assert actual_angle == calculated_angle
    env.close()

That will make easy to reproduce the setup, thanks.

@stbook -- Looks like the link I pointed you to is for a different coordinate system all-together :)
It seems like you want something that is like the TopDownMap measure.  The way we get the angle for that is here: https://github.com/facebookresearch/habitat-api/blob/master/habitat/tasks/nav/nav.py#L667

The subtraction of pi/2 deals with the flip of x and y that happens when you assign x to x and z to y.  In the agents coordinate system, z corresponds to theta=0, not theta=pi/2.

Thanks a lot.


fix issue: #52

Fix issue: #52
Cause:
due to injection of comment by five/live server extension , the commented part of the code was getting uncommented (due to nested commenting) causing unwanted section of code to appear in UI.

Solution:
moved the commented portion of the code to the bottom of the file so it doesn't interact with the code injection by the extension

Thankyou @vaibhav-yerkar for detailing the exact issue. I will check it soon.


Support for swipe left|right?

This is a fairly good component. Thank you very much!
I was wondering, how would I go if I wanted to implement onSwipeLeft for this component?

+1

By looking at the code react-hammerjs only supports listening to the entire onSwipe event, and not individual onSwipeLeft, onSwipeRight, onSwipeUp, and onSwipeDown events.
To get to know the direction of a swipe, do this: in your onSwipe event handler compare event.direction to one of the Hammer.DIRECTION_* contstants. See http://hammerjs.github.io/api/#constants for a full list of constants.

you should provide the prop vertical={true},then you will know the direction of a swipe by e.deltaX or e.deltaY

Fixed by #51


1.0 broke the ability to add arbitrary properties to macros

It was previously possible to add arbitrary properties to the macro objects, this seems to be broken after the 1.0.0 release.
Usecase: In the TrueCoach app we added groupHeader and summary properties to the macro objects so that we could show users what keyboard shortcuts are available and what they do, and store all of that information on the macro object itself.
This seems to no longer be possible since the Macro's constructor is manually setting only specific options that it expects.
https://github.com/IcarusWorks/ember-key-manager/blob/591992f6fdf541da07ba44b40e6b00f186ad381d/addon/utils/macro.ts#L28-L51
A possible solution may be a meta property that can act as a grab-bag for additional user-land properties for the macro.

A meta prop would be one way to go. Another solution would be to allow optional key-value pairs on MacroOptions.
export interface MacroOptions {
  callback: KeyMacroModifierCallback;
  executionKey: string;
  modifierKeys?: string[],
  keyEvent?: KeyEvent;
  element?: HTMLElement;
  isDisabledOnInput?: boolean;
  priority?: number;
  groupName?: string | null;
  isDisabled?: boolean;
  [key: string]: unknown; // <--- added
}

Then loop all the keys (completely untested):
  constructor(options: MacroOptions) {
    Object.keys(options).forEach((key) => {
      if (options[key] === 'modifierKeys') {
        this.modifierKeys = A(options.modifierKeys);
      } else {
        this[key] = options[key];
      }
    });
  }

A meta prop would be one way to go. Another solution would be to allow optional key-value pairs on MacroOptions.
export interface MacroOptions {
  callback: KeyMacroModifierCallback;
  executionKey: string;
  modifierKeys?: string[],
  keyEvent?: KeyEvent;
  element?: HTMLElement;
  isDisabledOnInput?: boolean;
  priority?: number;
  groupName?: string | null;
  isDisabled?: boolean;
  [key: string]: unknown; // <--- added
}

Then loop all the keys (completely untested):
  constructor(options: MacroOptions) {
    Object.keys(options).forEach((key) => {
      if (options[key] === 'modifierKeys') {
        this.modifierKeys = A(options.modifierKeys);
      } else {
        this[key] = options[key];
      }
    });
  }

I think either approach would be fine. Your suggestion would be nice since it keep compatibility with pre-1.x functionality. But I also like the explicitness of a meta property and the clear delineation it provides between the MacroOptions properties and custom properties.

I think either approach would be fine. Your suggestion would be nice since it keep compatibility with pre-1.x functionality. But I also like the explicitness of a meta property and the clear delineation it provides between the MacroOptions properties and custom properties.


HTML Streaming

Here's one example of using renderToNodeStream
https://github.com/GoogleChromeLabs/progressive-rendering-frameworks-samples/blob/82ccd045264753c11966c59bb63dcba76b8b9f5c/react-streaming-ssr/server.js#L83-L113
What sticks out to me in that example is the the first write includes the  assets

Should be possible to do the same by using pageContext._pageAssets instead of html._injectAssets().
@jfsiii
@lukasluecke
@orenelbaum

@brillout Do you think this rendering strategy could work with vite-plugin-ssr?

@OfekA Yes it should work. See the CF workers example and return the stream in render() instead of returning an HTML string.

@brillout I've managed to use renderToNodeStream with express to stream the app, but what I'm having difficulties with is sending the wrapping HTML for the app with the page assets.
Any chance you can make an example for it?

I'm thinking about implementing a new built-in functionallity:
escapeInject`<!DOCTYPE HTML>

${injectStream(appHtmlStream)}

  `

(html is renamed escapeInject in the upcoming 0.3.0 version).
The plugin would then automatically inject the assets.
In the meantime you can do this:
// Note how div#app is empty
const htmlWrapper = html.injectAssets(`<!DOCTYPE HTML>

  `)

const parts = htmlWrapper.split('

')

const streamBegin = parts[0] + '
'
const streamEnd = '
' + parts[1]

// We can now construct the stream ourself

Thanks @brillout! I think the injectStream API will make things a lot easier, especially after the changes in 3.0+

@OfekA I started working on it

https://github.com/brillout/vite-plugin-ssr/blob/f0c799852e34e965772ac66b952b6d5d08b9c825/examples/react-full/renderer/_default.page.server.tsx#L16
https://github.com/brillout/vite-plugin-ssr/blob/f0c799852e34e965772ac66b952b6d5d08b9c825/examples/react-full/renderer/_default.page.server.tsx#L30
https://github.com/brillout/vite-plugin-ssr/blob/f0c799852e34e965772ac66b952b6d5d08b9c825/examples/react-full/server/index.ts#L34-L35
I will also implement a CF workers Vue HTML streaming example.

Docs at https://vite-plugin-ssr.com/html-streaming

@brillout I've been testing out the new streaming feature, trying to delay rendering until some promise(s) resolve.
A simple example:
// index.page.vue
<template>

    {{ lazyload }}

</template>

But when running this I get the following error:
Error [ERR_METHOD_NOT_IMPLEMENTED]: The _read() method is not implemented
    at Readable._read (internal/streams/readable.js:623:9)
    at Readable.read (internal/streams/readable.js:462:10)
    at maybeReadMore_ (internal/streams/readable.js:610:12)
    at processTicksAndRejections (internal/process/task_queues.js:82:21) {
  code: 'ERR_METHOD_NOT_IMPLEMENTED'
}
error Command failed with exit code 1.

Any idea what I'm doing wrong or if this is even possible?

Does the error disappear if you make it sync (i.e. setup() instead of async setup())?

@brillout Do you mean like this?
<template>

    {{ lazyload }}

</template>

That doesn't throw the error, but that doesn't wait for the promise to resolve so it doesn't really solve the problem.

I'm asking to make sure it's async that causes the error.
Sure it should work with async as well, since the whole purpose of HTML streaming is to enable efficient suspensed SSR.

@OfekA
Did you wrap it with <suspense>? See https://v3.vuejs.org/api/sfc-script-setup.html#top-level-await
Do you know whether Error [ERR_METHOD_NOT_IMPLEMENTED]: The _read() method is not implemented originates from vite-plugin-ssr or Vue?

@brillout
I tried it with Suspense as well, got the same error, but I may have used it wrong.
Regarding the origin of the error, I'm not entirely sure..

Regarding the origin of the error, I'm not entirely sure..

It would help to know. I'm fairly busy with another ticket right now, so I'll gladly take any help I can 😊.

Regarding the origin of the error, I'm not entirely sure..

It would help to know. I'm fairly busy with another ticket right now, so I'll gladly take any help I can 😊.

Definitely, I'll report back with findings soon 😊

Perfect 👌

@brillout
I checked again with Suspense and it doesn't work - same error.
Regarding the origin of the error, I tried debugging the code from vite-plugin-ssr but I didn't manage to, not really sure how to debug it...

@OfekA I'd debug this by setting console.log()s in node_modules/vite-plugin-ssr/ as well as node_modules/vue/ to understand the execution flow that leads to the error. The error originates somehwere in one of these two pacakges.

If you can shed some light on what causes the error, I'll implement the required changes to fix it.

@brillout Exactly what I tried, for some reason I couldn't see the console.log in /node_modules/vite-plugin-ssr/node/renderPage.ts - maybe I shouldn't be trying in the .ts files?

Yes put them in dist/

On another note, I thought of making a PR that implements a simple example, first in vue-full and then in react-full + add tests, thoughts?

Yes that'd be lovely actually.

Could you please document an example using renderToPipeableStream? renderToNodeStream no longer does streaming in react 18.

@nitedani See https://github.com/brillout/react-streaming and the 0.4 branch has a couple of examples of using it with vps.


I can't understand how send images to the bot

the log:
><EMAIL_ADDRESS>start /home/macunaima/codes/Stickerworld
> node index
info:     [session] Initializing browser wss...
Chrome not found, using chromium
info:     [session] Browser successfully opened
info:     [session] checking headless...
info:     [session] headless option is active, browser hidden
info:     [session] Checking page...
info:     [session] Page successfully accessed
and  after read the QR code:
✓ [instance: session]: Connected
Session started
[0d187518e9756caffd545b2a154dae6c] New group message: group-name, for user: user-number
[0d187518e9756caffd545b2a154dae6c] Url no detected
What is the number for the bot?

The number of the bot is the one from which WhatsApp account you have scanned the QR-Code. If you scanned the QR-Code with your own phone with your own WhatApp account/number then that is the number of the bot. Though only others can create stickers by sending YOU (bot) the image/gif/video with the message "!sticker" or "!Sticker", you can not create stickers by sending it to yourself from the same number (would be cool if the developers add this feature)

thx for the explanation 🤗


fix: AIChat responsive fix - cherry pick of pr 844

Fixes Issue
Closes #805

Changes proposed

added overflow on chat content
recent chat box moved to absolute positioning under 800px to avoid overcrowding on mobile devices
overlapping grid styles in Prompts component removed

Screenshots
337881101-7dbfa97c-07a9-4375-956f-68fceb7f6f97.webm

Note to reviewers
done by @SinanovicAhmed
It is a cherry pick duo to changed dev branch

Code of Conduct

[x] By submitting this pull request, I confirm I've read and complied with the CoC 🖖

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

You can also join our Discord community.
Feel free to check out other cool repositories of the Thecyberworld.
Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

@SinanovicAhmed Thanks for contributing, I have some comments.
Before the comments, notice the next important note:
The dev branch is a new branch which was changed due to repo technical errors
What you need to do:
Step one in github:
Go to local repo
Click "Synk fork"
Click Discard  Commits/Changes
Step two in local editor:
You will notice a number of commits that it wants to push let's call it
In terminal:
git reset HEAD~
git pull
If you would like to solve the comments you should do them in this branch:
gh pr checkout 855
Sorry for this scenario, it is not something that happens often.

https://github.com/thecyberworld/TheCyberHUB/assets/76536506/35d11e90-c681-45c0-a0de-a7bdbf6143d4
In some widths it is still not responsive as needed

https://github.com/thecyberworld/TheCyberHUB/assets/76536506/e8814e57-fc7c-463d-803e-a5b721b64670
@kabir0x23 what do you think about this way that the left menu opens? I think it is ok, however, maybe better on clicking the icon, the left menu will slide to right and the right menu will not be displayed

Tell me that you see this black border and black lines, please, remove them.

@ArkadiK94 I fixed points 1 and 2, but I couldn't get the black borders and lines to appear from point 3.

@SinanovicAhmed what do you mean? don't you see them or you could not find the reason for them?

@ArkadiK94 I can see the lines in the image you provided, but they don't appear when I run the project locally.  Are they always there or when you do specific action they appear?

@SinanovicAhmed When I click around the arrow btn.

@ArkadiK94 Me mindlessly clicking around arrow button 😄
screen-capture (3).webm

@SinanovicAhmed Haha, please, push the changes maybe it was fixed 😅 I will check and let you know :)

@ArkadiK94 I was working directly on cherry-pick/pr-844 branch because I wasn't familiar with "gh pr checkout 855" command you mentioned. Should be ok to  push changes to that branch?

@SinanovicAhmed Your work-around is a great idea :)

about black lines, I use Firefox browser, maybe it is related, you can leave it for now.
however, I didn't line that when you click it slides inside the "New Chat" In my opinion, it should be instead.

@SinanovicAhmed Hi, how is it going?

@SinanovicAhmed Hi, how is it going?

Hi, I wasn't really looking into it so far. So you want on smaller devices only one window to be open and on larger they can both be open at the same time? I haven't tried to fix it yet but it seems to be decent amount of work for minimal change in my opinion. I can work on it when I get the time if it's 100% what you need.

@SinanovicAhmed ok, I will merge it and we will handle this later. Thanks for your contribution.