Builder pattern + methods

Currently, this crate uses the builder pattern to assure a stable API i.e https://github.com/Emilgardis/twitch_api2/blob/e1ba9faff6c72b92f271a888b480a016c334b82a/src/helix/channels.rs#L82-L88
I decided to do it this way due to Twitch not guaranteeing a stable API themselves on documented items, so marking structs as #[non_exhaustive] and using a builder seems better.
However, sometimes this makes things harder to use, as typed-builder does not exactly make structs more accessible.
While this is done for stability, I feel like some structs don't lend themselves to the builder pattern, like the above example.
I want to solve this somehow, without sacrificing API stability.
To do that I think what needs to be done is creating methods for common usages of requests.
Example:
impl GetChannelInformationRequest {
    pub fn get_channel(broadcaster: String) -> GetChannelInformationRequest {
        GetChannelInformationRequest::builder().broadcaster_id(broadcaster).build()
    }
}

or for https://github.com/Emilgardis/twitch_api2/blob/e1ba9faff6c72b92f271a888b480a016c334b82a/src/helix/games.rs#L59-L68
impl GetGamesRequest  {
    pub fn get_game(id: types::CategoryId) -> GetGamesRequest {
        GetGamesRequest::builder().id(vec![id]).build()
    }
}

There is the crate derive_builder that could help also.

impl GetGamesRequest  {
    pub fn get_game(id: types::CategoryId) -> GetGamesRequest {
        GetGamesRequest::builder().id(vec![id]).build()
    }
}

Question is, if it wouldn't be better to stick to the naming convention and name the function new as a constructor? Thoughts?

I want to add to this that it makes it really difficult to optionally set some fields.
This is the simplest I could do this, but Maybe there is also a  better way, I'm not seeing:
pub struct ChannelInformation<'a> {
    title: Option<&'a str>,
    language: Option<&'a str>,
    game: Option<&'a str>,
}
impl ChannelInformation<'_> {
    fn to_modify_body(&self) -> ModifyChannelInformationBody {
        match (self.title, self.game) {
            (Some(t), Some(g)) => ModifyChannelInformationBody::builder()
                .title(t)
                .game_id(g)
                .broadcaster_language(self.language.map(ToOwned::to_owned))
                .build(),
            (Some(t), None) => ModifyChannelInformationBody::builder()
                .title(t)
                .broadcaster_language(self.language.map(ToOwned::to_owned))
                .build(),
            (None, Some(g)) => ModifyChannelInformationBody::builder()
                .game_id(g)
                .broadcaster_language(self.language.map(ToOwned::to_owned))
                .build(),
            (None, None) => ModifyChannelInformationBody::builder()
                .broadcaster_language(self.language.map(ToOwned::to_owned))
                .build(),
        }
    }
}

this is due to strip_option, should consider not using it at all and just rely on into

How does typed_builder currently work? The builder type is private, the build function is crossed-out and RA fills in a single parameter channel_points_custom_reward_redemption_add_v1_builder_error_missing_required_field_broadcaster_user_id. I can't figure out how to finalize the builder.

@spikespaz the typed_builder crate creates a builder that throws a compile error if setters are missing, the parameter you get contains the missing setter, you need to add broadcaster_user_id. Anyway, I'd recommend using ChannelPointsCustomRewardRedemptionAddV1::broadcaster_user_id(...) instead which is what this issue is about. Looks like I forgot to link the pr that created them: #262
Also, this issue


Assets

Change all asset ressources by the asset() version.
This will allow to the system to retrieve all ressources whatever the directory installation.
What have been changed ?

css links
images (icons, avatar, ...)
js files

So actually, if the URL was an https:// URL, this would still serve up the asset via http:// Let me know if there's another reason why this may be better and I can definitely merge it in.
I would think it would be best to keep the URL's to the assets relative. Let me know, maybe I'm missing something :)
Thanks 👍

OK,
For now, the relative path is not working for me (as the routes) because I'm using subdirectories. And yes, I had not thought about the https.
I will think for a better solution :)


elementOpen is not defined

I'm getting Uncaught ReferenceError: elementOpen is not defined
I'm running into issues with the attached webpack + babel project.  It looks like elementOpen is in the output, just not in scope for some reason.
To see the error happen, just run your favorite http server on the dist directory and load up index.html.  You can run the webpack build with npm run build if you'd like.
Archive.zip

You're not importing (or auto-importing) in the my-test.js file.

Oh wow, how did I miss that!  I swear I looked for something like it too.  Thanks!
As a side note, this is a somewhat unexpected behavior in my mind since I expect to be able to write JSX and just have it work out of the box (with the plugin).  It might be worth enabling auto-import by default in a future major release.
Thanks again!


Ux-webdesign

Fixes Issue🛠

Closes #2
Description👨💻

The event section cards needed to be changed first. Their design was too simple, and for some events, there was no clear distinction between the card and the background. Made all necessary changes.
Added a hover effect for nav links would look good like one cyan color underlines fade-in fade-out effect.

Type of Change📄

[ ] New feature (non-breaking change which adds functionality)
[ ] Style (non-breaking change which improves website style or formatting)

Checklist✅

[ ] I am an Open Source contributor
[ ] I have performed a self-review of my code
[ ] My code follows the style guidelines of this project

Screenshots/GIF📷

Can we implement the same or similar design for upcoming events cards also, make the new commits in this same PR @wildcraft958

The Register button is not shown now in upcoming events card, please fix and make the new commits in this same PR @wildcraft958

okay let me check once

Any update on this PR @wildcraft958

is it working now?


Time sync issue

I had a host that's time was 300.7s off from 'correct'.  The 'aws' command was able to talk to the API from the same node, but key-manager resulted in no output.
Debug output resulted in:
AuthFailure: AWS was not able to validate the provided access credentials
	status code: 401, request id: SNIP

Perhaps failure-message can be emitted in commented / sshd-safe form:
# AuthFailure: AWS was not able to validate the provided access credentials
#	status code: 401, request id: SNIP

Also, if the required s3 options are not provided then emit the usage.

Good idea, will implement as soon as I get a chance.
Thanks!

docker run alexrudd/key-manager:2.1
# RequestError: send request failed
# caused by: Get http://<IP_ADDRESS>/latest/meta-data/instance-id: dial tcp <IP_ADDRESS>:80: getsockopt: no route to host


Create validator to options

Hi,
I need a custom validator for work with meta in codeblock.
Does it look like something useful?

Pull Request Test Coverage Report for Build 29

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 26:
0.0%

Covered Lines:
26

Relevant Lines:
26

💛  - Coveralls


Does the color attribute work?

May I learn whether the color attribute work as expected? If yes, could you please provide me a way to use it.

Yes, it works, there are multiple examples in the docs.  Can you give a complete minimal example of it not working?

from dash import Dash, html
from dash_iconify import DashIconify
def get_icon(icon, height, color=None):
return DashIconify(icon=icon, height=height, color=color)
app = Dash(name)
app.layout = html.Div([
html.Div([
"Icon:",
get_icon("emojione-monotone:letter-s", 18, color="red")  # working example
], style={'display': 'flex', 'alignItems': 'center'})
])
if name == 'main':
app.run_server(debug=True)
I just happen to see that color attribute does not work for certain icons (e.g. #twemoji:letter-s).
Is there any way to change color of the icon on my example for instance? If no, is there any way to tell which icons have changable color?

You can find more information in the Iconify docs  https://iconify.design/docs/icons/icon-basics.html#colors


Add copy to clipboard buttons in explore and sqllab

This is a second attempt at https://github.com/apache/incubator-superset/issues/6064.
I've decided that if we want to display the copy to clipboard button in the View results modal, then my component is not needed because the data is already available there. Therefore I think https://github.com/apache/incubator-superset/pull/6452 should be closed, but I'll refrain from doing so till I get a review on this one.
Not sure if we'd like to create another component, e.g. CopyToClipboardTabularData to avoid duplication of prepareCopyToClipboardData.
Preview:

Codecov Report

Merging #6461 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6461   +/-   ##
=======================================
  Coverage   73.32%   73.32%
=======================================
  Files          67       67
  Lines        9592     9592
=======================================
  Hits         7033     7033
  Misses       2559     2559

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3a625...7497f96. Read the comment docs.


Crash when receiving an error from LCU Client through obs tool

Crash when receiving an error from LCU Client through obs tool
Occurs in state-league/controller/LCUDataReaderController
if (event.data.timer.phase !== PickBanPhase.GAME_STARTING) {
caused by some key missing or being undefined

Solved through fix in Observer Tool


New Minor Release?

We are maintaining an image with the last handful of commits on master that haven't been released yet. Would it be possible to cut a new minor release with these changes?

Just did it.


Buffer fix

Dear,
when a Buffer needs to be returned, NodeJS will first convert it's Buffer to an UTF8 string, and afterwards Node-Red will convert it back to a buffer.  This results in a lot of performance loss.
I have explained the problem in detail on this forum discussion.
If any doubts, please let me know !
Kind regards,
Bart Butenaers

Coverage remained the same at 87.24% when pulling bf22706cf571ae26a8fda4dd06fc0497f88d29d3 on bartbutenaers:multipart_stream into 052b5e0ea8979f29bfa39a6434b41949cce17481 on node-red:master.

an idle thought : if this is the case then would it be better to always treat as binary in the inner loop - and only convert to string (and then maybe json) at the end ?

Dave,
do you mean that we always should get a Buffer from NodeJs, and convert it on the 'end' event to a Buffer, JSON object or string (depending on the return type specified by the user)?   Sounds logic.  If so please let me know: I will create a new version and update it here.
Thanks for your idle thoughts !!
Bart

yes - that would replace all the internal if... with just one at the end.. - but then pits the performance of .push and .concat and one if   against the string += and multiple if     - who knows :-)
(As I said - I'm not really fussed - just a thought)

Coverage remained the same at 87.24% when pulling 2d2ba0e94e767c9ea400856b21a29c0449ad3b33 on bartbutenaers:multipart_stream into 052b5e0ea8979f29bfa39a6434b41949cce17481 on node-red:master.

Hi Dave,
I have created a new version, which will always ask NodeJs to get a Buffer.
The conversions will currently look like this:

Binary : binary buffer (NodeJs) -> binary buffer (Node-Red)
Text : binary buffer (NodeJs) -> UTF8 string (Node-Red)
Json : binary buffer (NodeJs) -> UTF8 string (Node-Red) -> Json object (Node-Red)

For return type 'text' we changed from 'appending string chunks to a response string' to 'appending buffer chunks to an array'.   This was not the original intent of my fix, but following this benchmark it 'could' also be faster.  However, I haven't profiled it myself...
I have done some tests, to avoid existing flows to be impacted...

[{"id":"e05ab4f6.b3c8f8","type":"http request","z":"254261b4.45828e","name":"","method":"GET","ret":"bin","url":"https://shipitsquirrel.github.io/images/ship%20it%20squirrel.png","tls":"","x":470.89573669433594,"y":401,"wires":[["2b840f33.605a6"]]},{"id":"35dac082.79b","type":"inject","z":"254261b4.45828e","name":"","topic":"","payload":"","payloadType":"str","repeat":"","crontab":"","once":false,"x":310.89573669433594,"y":401,"wires":[["e05ab4f6.b3c8f8"]]},{"id":"2b840f33.605a6","type":"file","z":"254261b4.45828e","name":"","filename":"/tmp/image.png","appendNewline":false,"createDir":false,"overwriteFile":"true","x":660.8957366943359,"y":401,"wires":[]},{"id":"c6c20629.bb3998","type":"debug","z":"254261b4.45828e","name":"","active":true,"console":"false","complete":"payload","x":654.8957672119141,"y":512.8888854980469,"wires":[]},{"id":"8ffee6b7.c6f758","type":"http request","z":"254261b4.45828e","name":"","method":"GET","ret":"obj","url":"https://api.coinmarketcap.com/v1/ticker/bitcoin/","tls":"","x":473.8957824707031,"y":512.8888854980469,"wires":[["c6c20629.bb3998"]]},{"id":"ea998437.e1c2a8","type":"inject","z":"254261b4.45828e","name":"","topic":"","payload":"","payloadType":"str","repeat":"","crontab":"","once":false,"x":309.8957824707031,"y":512.8888854980469,"wires":[["8ffee6b7.c6f758"]]},{"id":"e18d5f78.129cc","type":"comment","z":"254261b4.45828e","name":"Return as JSON object","info":"","x":334.2742919921875,"y":475.1562805175781,"wires":[]},{"id":"80a3aa47.328198","type":"comment","z":"254261b4.45828e","name":"Return as binary Buffer","info":"","x":332.89576721191406,"y":361.8888854980469,"wires":[]},{"id":"d620b9ff.3e7dd8","type":"debug","z":"254261b4.45828e","name":"","active":true,"console":"false","complete":"payload","x":650.8958129882812,"y":288.8888854980469,"wires":[]},{"id":"5a25704c.f1778","type":"http request","z":"254261b4.45828e","name":"","method":"GET","ret":"txt","url":"http://loripsum.net/api","tls":"","x":469.8958282470703,"y":288.8888854980469,"wires":[["d620b9ff.3e7dd8"]]},{"id":"2f039f29.213bc","type":"inject","z":"254261b4.45828e","name":"","topic":"","payload":"","payloadType":"str","repeat":"","crontab":"","once":false,"x":305.8958282470703,"y":288.8888854980469,"wires":[["5a25704c.f1778"]]},{"id":"b3135f.7073aca","type":"comment","z":"254261b4.45828e","name":"Return as UTF8 string","info":"","x":330.2743377685547,"y":251.15628051757812,"wires":[]}]

Did also some other tests.  From my perspective, it seems to be working fine in all cases...
P.S. As soon as this fixed is merged, I will use it as a starting point for a new pull request for HTTP multipart streaming.
Kind regards,
Bart

As this is a core node, and the code paths touched are used by every user of the node, we need to be pretty certain about this change. By inspection, I think it looks good. But I'm not going to merge it until we have some unit tests in place for this node against master, which we can then run these changes against. I'll get some in place this week.

Coverage remained the same at 87.302% when pulling bd671e75e6174350e386d9b2c259e7ba1769bbd2 on bartbutenaers:multipart_stream into b2390f1cafefb413f4413e069d1de12f900e6b94 on node-red:master.

Coverage remained the same at 87.302% when pulling 2ae7e13959363ed50aa9218e7bf09e922b306e94 on bartbutenaers:multipart_stream into b2390f1cafefb413f4413e069d1de12f900e6b94 on node-red:master.

I have merged these changes into the 0.17 branch.
Give the 'fix' includes doing things with internal state (delete res._readableState.decoder), I've added an extra check just in case a future node.js release changes the behaviour - 0a6ff900dac4532da91fa764b7ba341fd4bd1627 - This will throw a very noisy error in the tests and not go unnoticed.


Getting blank page while navigate to new screen in release mode (debug mode app runs fine)

flutter run --release
Launching lib/main.dart on Redmi 4 in release mode...
Running Gradle task 'assembleRelease'...
Running Gradle task 'assembleRelease'... Done                      43.5s
✓ Built build/app/outputs/apk/release/app-release.apk (10.1MB).
Installing build/app/outputs/apk/app.apk...                        12.0s

To quit, press "q".
I/flutter (21679):
I/flutter (21679): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'
I/flutter (21679): Another exception was thrown: Instance of 'DiagnosticsProperty<void>'

Hi @RashminDungrani
can you please provide your flutter doctor -v
and flutter run --release --verbose?
Also, to better address the issue, would be helpful
if you could post a minimal code sample to reproduce the problem
Thank you

Problem was solved !
There was a method of return  type List so it's not properly respond to build method
Anyway thanks for your help..


--snap-fix CLI argument

As per #123, my bad for creating an issue with multiple points.
Please can we have a new --snap-fix or --sfix argument (or something else concise) which implies both --inline-snapshot=fix and --inline-snapshot=create.
I'd also be fine if --sfix was a concise version of --inline-snapshot=fix, and there was a config setting to make --inline-snapshot=fix imply --inline-snapshot=create.

I'd also be fine if --sfix was a concise version of --inline-snapshot=fix.

Or if #128 is sorted, I could have --inline-snapshot=create on by default.

FWIW I just always use fix. When I want to create, I write assert ... == snapshot(0), which requires basically no additional finger movement to type. Then I don't need a different workflow.

ok, I think the underlying problem is that everyone has his own workflow and wants a short cli argument for it. What do you think about the idea to provide explicit shortcuts which can be defined by the user in pyproject.toml.
[tool.inline-snapshot.shortcuts]
sfix="create,fix"

This would provide a new pytest option and pytest --sfix would be the same as pytest --inline-snapshot=create,fix. It would of course also be possible to define several abbreviations.

Sounds good to me!

Fixed in 0.14.0

Trucks so much.


Reducing the window size cuts off text for individual ships

Using Google Chrome on W.10.RS4 System.
Reducing the size of the window and ship text starts getting cut off.
Possibly set minimum size for the Tab or at least the ships, rearranging columns until it's only one column, but can still see the entire details for each ship, if that is possible.

Fixed in f6d4adef5adc4116fff4b7699e358fceca532fa1


'Quickstart' notebook outputs an error

Thanks for the interesting work! When I tried to run your quickstart.ipynb notebook, I got an error message at the second cell of code, where the first call to your library is made
bounds = ab.taylor_bounds(f, max_degree=2)(x0, trust_region)

The error shows up both on the "colab" link I followed from your github repo (with jax 0.4.20), and on my machine (with jax 0.4.19). The error reads
AttributeError: module 'jax' has no attribute 'abstract_arrays'

Thanks for reporting this! I'll push a fix soon.

This is fixed now.


[BUG] Unreachable code generated for function definitions

Describe the bug
Cython 3.0.2 generates unreachable code for every function definition.
> python setup.py build_ext
Compiling test.pyx because it changed.
[1/1] Cythonizing test.pyx
running build_ext
building 'test' extension
clang -Wsign-compare -Wunreachable-code ...
test.c:2172:3: warning: code will never be executed [-Wunreachable-code]
  goto __pyx_L3_error;
  ^~~~~~~~~~~~~~~~~~~
1 warning generated.

Code to reproduce the behaviour:
Run python setup.py build_ext with the following files:
test.pyx:
# cython: language_level=3
# cython: binding=True

def myfunction(arg):
    return arg

setup.py:
from setuptools import setup, Extension
from Cython.Build import cythonize

ext_modules = cythonize([
    Extension("test", ["test.pyx"])
])

setup(ext_modules=ext_modules)

Expected behaviour
Expected no compiler warnings. Cython generates the following code:
2170   __pyx_L5_argtuple_error:;
2171   __Pyx_RaiseArgtupleInvalid("myfunction", 1, 1, 1, __pyx_nargs); __PYX_ERR(0, 4, __pyx_L3_error)
2172   goto __pyx_L3_error;
2173   __pyx_L3_error:;

Line 2172 does seem to be unreachable since __PYX_ERR expands an identical goto statement.
OS
macOS
Python version
3.11.4
Cython version
3.0.1, 3.0.2
Additional context
The issue is still there on master. A bisect pointed me to e1d9c5a03af7a7c, and it looks like this is where the unreachable goto is generated:
https://github.com/cython/cython/blob/8d20040844dbff3e8113fe2d7fb96312fd72cb9e/Cython/Compiler/Nodes.py#L3922-L3925

That's a pain. The goto is to shut up another compiler warning. So unless someone can do something clever, you just have a choice of which warning you want to see.

I'll try if I can do something.

Ah I see, the unused-label warning that this fixes doesn't come up on that small example, but I see it does occur on a larger codebase if I remove the above goto.


Fix email -> user_id hard codings.

Automated message from Dropbox CLA bot
@showell, it looks like you've already signed the Dropbox CLA. Thanks!

Some parts of this probably deserves some more node tests eventually, but this looks good.  Merged, after fixing a whitespace typo :).


How to get the relative path for the uploaded image?

Hello,
I have configured lfm and it is working fine but I would like to get the relative path/url of the image but I can't figure it out. Could you help or give me and advice, please?

I have the same issue/problem?

You must configure your config/filesystems.php like this
'disks' => [
    'my' => [
        'driver' => 'local',
        'root' => './uploads/',
        'url' => '/uploads', //relative url to your file
    ],

Same problem, my workaround is to modify the config/filesystems.php like this:

'public' => [
            'driver' => 'local',
            'root' => storage_path('../public'),
            'url' => env('APP_URL'),
            'visibility' => 'public',
        ],


Circles for 'your predictions' on multi-choice don't always correspond to the colors of the options

Current behavior
E.g. draaglom's predictions here (yellow circles should be red):

This is a duplicate of https://github.com/Metaculus/metaculus/issues/385 and should be fixed on dev.
@George3d6 the fix was merged on September 4th. Have we updated the beta since then?

Confirming this looks to be fixed.


Added spaces/delay

I added spaces and delays (via the time module) to make the text more readable. It can definitely still be tweaked to get precisely what we want, but I definitely think even this basic space between inputs and 3-second delay improves the UX

@tyiop794 Would you like me to further refine how many spaces? How many do you think you would like?

As I noted in issue #5, most of the questions output to the user are being done by separate functions. I have fixed this issue by calling these functions through main(); however, this means that your pull request needs to be applied to those functions rather than to the main() function itself. I can help you with that if you would like.
As far as the pull request itself, I think 3 seconds is a bit on the longer side; maybe one second is better? One addition (definitely would take a while) to the program I see myself adding in the future is an ncurses-style interface allowing one to change the source elements (if they input something by mistake) or input the elements in different order.
However, for the time being, I could see adding spaces as something which could improve the UX of the program in its current state.


Support lambdas without full src directory

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
Hi, thanks for a great tool! Did run into a problem trying to adapt some existing repos to use hatch and this plugin though.
To limit the size of published lambdas, at work we often specify the CodeUri of the lambda to be a subset of the src directory. Trying that with this build system produced FileExistsErrors from the call to copytree however.
For example with your test setup, a template.yml of the following doesn't build using hatch but does using sam build:
Resources:
    MyLambda1Func:
        Type: AWS::Serverless::Function
        Properties:
            CodeUri: src/my_app/lambdas/lambda1
            Handler: main.app
            # ...

Unfortunately the dirs_exist_ok flag for copytree was only introduced in python 3.8, but if we just ensure the parent build directory is present, then copytree doesn't complain.

Thanks for the very useful project!


max sessions limited under Myrtille ? or IIS ?

Dear,
First of all thanks for this wonderfull product.
I make an event booking portal with registration and online payment for an association.
For this, my software works only on Windows and is placed in DB/C (dbcsoftware.com).
To allow most people to book in, I decided to do a "kiosk" using a Windows 10 Pro PC, CONFIGURED with RDP Wrapper (also on GitHub) and blueberry. This will allow all the OS and all the hardware to connect via HTML5.
The kiosk starts working well and I get what I want, except that the maximum number of sessions I am able to open under Myrtille is 10.  You cannot open a new session under Myrtille, but you can open new sessions using the classic Microsoft RDP client.  So the limitation does not come from RDP wrapper.
Where can I change this limit (Myrtille? IIS? WebSocket?)
Thank you for your help

There is no such a limitation into Myrtille.
Maybe it doesn't come from RDP Wrapper, but from the host itself. RDP Wrapper states that it supports

Up to 15 concurrent sessions (the actual limitation depends on your hardware and OS version)

https://github.com/stascorp/rdpwrap#key-features
What happen when you try to open a 11th session? when you have 10 concurrent sessions with Myrtille, can you connect using mstsc?
It will be better to host your application on a Windows Server 2016, with the RDS role enabled (and a connection broker with multiple hosts in a load balancing scenario, if you have many connections). The number of concurrent connections will only be limited by the number of CALs provided by your license server (https://docs.microsoft.com/en-us/windows-server/remote/remote-desktop-services/rds-client-access-license).

By the way, how do you proceed to have 10 concurrent sessions with myrtille? did you enabled cookieless sessions (for multiple tabs/sessions), as explained into the readme? or do you test from 10 different clients?


Missing functions/docs?

I decided to try out google-drive, and managed to get the "context", but there seem to be some holes in the functionality and/or docs:
How do you list files/folders?
How do you get a parent-folder-id or file-id?

Using the java api, it is possible to search for a file by name, and thus extract its id from the meta-data. This functionality has not yet been written in clojure here, but can be added. If you would like to add that functionality, feel free to fork and submit a PR to develop. Otherwise, I'll add that in the next release. Once you have received the Drive File object from creating or updating a file, the parent-folder-id and file-id can be extracted from the returned meta-data(these are also visible from the drive UI in the url).


Ability to disable a checkbox in a quick pick

Useful in Manage Trusted Extensions:

Verification:

Run the command: Accounts: Manage Trusted Extensions For Account
Pick an account
Ensure that the items under the "Trusted by Microsoft" section are grayed out and cannot be changed in any way.
Ensure that the items not under that section can still be toggled (grab Joh's PR Pinger extension and log into it via the status bar when the vscode repo is open if you need an extension that isn't trusted)
Make sure changes persist. Make a change, hit OK, reopen, change it back, hit OK, make sure it changed back.


Add codecov support

Add codecov stuff, like badges.

No, I forgot to remove it.

It'll be nice when this gets in.

Hooray! May I steal this sometime? :-)

It looks like the Windows job broke. I didn't change the cmake.yml file, so I don't know what caused it to break. Someone with more experience with Windows might want to check it  out.

Same message we've gotten over at p4. I'm suspecting a GHA windows-image error that will hopefully get fixed upstream.

Well, in that case I believe this pr is ready for review


⚠ Turnos 24x7 has degraded performance

In 7305e49, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 5716 ms

Resolved: Turnos 24x7 performance has improved in 74210a2.


GH Actions

If I ever want to make a release, I'll need to have some sort of automated system for doing it. This would honestly be super useful for testing/nightly releases or something, as well. Like #68, I am not very knowledgable in this area.
In general, when a release is made the following needs to happen:

server build

linux, macos, windows binaries (this can probably be done at once thanks to this

web build
desktop build

linux, macos, windows (AppImage, dmg, msi - I think? Unsure what best is for Linux broad support)

docker server build

arm, amd64

Some constraints that I have no idea how to go about yet:

prisma client needs to be generated, cached and shared between rust actions

this might be tricky with docker? include_str! macros might mess things up but also 🤷

rust dependencies should be cached (https://github.com/Swatinem/rust-cache)

Hello! I'll give it a try :)

Just assigned you, thanks! If you have any questions please let me know 🙂

Hey there @f8thl3ss, just merged a few additional changes to gh-actions (see #72). Those involved changes to the PR checks, not the release actions for this issue but wanted to let you know in case there are any conflicts 🙂

Thanks for letting me know! :) I've pulled the latest changes.


Use http.ServeContent

Description
This PR switches the HTTP server implementation to use http.ServeContent, which means that it now has support for more features like sending MIME types and handling range requests.
Why is this needed
In certain cases, BMCs try to make HTTP range requests to avoid accessing downloading the entire boot media at once. With this change, those attempts no longer fail.
How Has This Been Tested?
Booted a Dell R640 with a virtual media image hosted on ipxedust.
How are existing users impacted? What migration steps/scripts do we need?
Should be no impact. HTTP server just supports more features.
Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

The changes look good. I think the failing unit test can be removed because it doesn't necessarily make sense: if we fail to write data via w.Write() we probably can't write headers either and I think that's the rationale the ServeContent implementation follows.

@mergify queue


CORS preflight request with URL Path versioning results in ArgumentNullException

I have a .NET Framework 4.5 project using OWIN & ASP.NET Web API, with CORS support using Microsoft.AspNet.WebApi.Cors. Runtime is Mono 6.x.
When I add URL Path versioning, preflight requests fail with ArgumentNullException: Value cannot be null.\nParameter name: response, and stack
  at System.Web.Http.HttpResponseException..ctor (System.Net.Http.HttpResponseMessage response) [0x00018] in <4f8d88aa02d546f6963914471854cb7c>:0
  at Microsoft.Web.Http.Dispatcher.HttpResponseExceptionFactory.CreateBadRequest (Microsoft.Web.Http.ApiVersion requestedVersion) [0x00007] in <603f310054da465a9f47899e3083913f>:0
  at Microsoft.Web.Http.Dispatcher.HttpResponseExceptionFactory.CreateBadRequest (Microsoft.Web.Http.Dispatcher.ControllerSelectionResult conventionRouteResult, Microsoft.Web.Http.Dispatcher.ControllerSelectionResult directRouteResult) [0x00027] in <603f310054da465a9f47899e3083913f>:0
  at Microsoft.Web.Http.Dispatcher.HttpResponseExceptionFactory.NewNotFoundOrBadRequestException (Microsoft.Web.Http.Dispatcher.ControllerSelectionResult conventionRouteResult, Microsoft.Web.Http.Dispatcher.ControllerSelectionResult directRouteResult) [0x00000] in <603f310054da465a9f47899e3083913f>:0
  at Microsoft.Web.Http.Dispatcher.ApiVersionControllerSelector.SelectController (System.Net.Http.HttpRequestMessage request) [0x00143] in <603f310054da465a9f47899e3083913f>:0
  at System.Web.Http.Cors.AttributeBasedPolicyProviderFactory.SelectAction (System.Net.Http.HttpRequestMessage request, System.Web.Http.Routing.IHttpRouteData routeData, System.Web.Http.HttpConfiguration config) [0x00018] in <a9bb4129cf4d431da372d3b3dbf7a190>:0
  at System.Web.Http.Cors.AttributeBasedPolicyProviderFactory.GetCorsPolicyProvider (System.Net.Http.HttpRequestMessage request) [0x000f9] in <a9bb4129cf4d431da372d3b3dbf7a190>:0
  at System.Web.Http.Cors.CorsMessageHandler.GetCorsPolicyAsync (System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken) [0x0001e] in <a9bb4129cf4d431da372d3b3dbf7a190>:0
  at System.Web.Http.Cors.CorsMessageHandler.HandleCorsPreflightRequestAsync (System.Net.Http.HttpRequestMessage request, System.Web.Cors.CorsRequestContext corsRequestContext, System.Threading.CancellationToken cancellationToken) [0x0010e] in <a9bb4129cf4d431da372d3b3dbf7a190>:0
  at System.Web.Http.Cors.CorsMessageHandler.SendAsync (System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken) [0x000a2] in <a9bb4129cf4d431da372d3b3dbf7a190>:0

Minimal repro solution: CorsVersioningExample.zip
Debug build
This has CORS support only.
$ curl -v -X OPTIONS -H 'Access-Control-Request-Method: POST' -H 'Access-Control-Request-Headers: content-type,authorization' -H 'Origin: https://example.com' http://localhost:9999/test/

> OPTIONS /test/ HTTP/1.1
> Host: localhost:9999
> User-Agent: curl/7.64.1
> Accept: */*
> Access-Control-Request-Method: POST
> Access-Control-Request-Headers: content-type,authorization
> Origin: https://example.com
>
< HTTP/1.1 200 OK
< Access-Control-Allow-Origin: https://example.com
< Access-Control-Allow-Credentials: true
< Access-Control-Allow-Headers: content-type,authorization
< Server: Mono-HTTPAPI/1.0
< Date: Thu, 16 Apr 2020 06:36:19 GMT
< Content-Length: 0
< Keep-Alive: timeout=15,max=100
<

Release build
This has CORS support & URL Path versioning.
$ curl -v -X OPTIONS -H 'Access-Control-Request-Method: POST' -H 'Access-Control-Request-Headers: content-type,authorization' -H 'Origin: https://example.com' http://localhost:9999/v1/test/

> OPTIONS /v1/test/ HTTP/1.1
> Host: localhost:9999
> User-Agent: curl/7.64.1
> Accept: */*
> Access-Control-Request-Method: POST
> Access-Control-Request-Headers: content-type,authorization
> Origin: https://example.com
>
< HTTP/1.1 500 Internal Server Error
< Content-Type: application/json; charset=utf-8
< Server: Mono-HTTPAPI/1.0
< Date: Thu, 16 Apr 2020 06:38:19 GMT
< Content-Length: 2415
< Connection: close
<
{"Message":"An error has occurred.", ... }

Possibly related:

https://github.com/Microsoft/aspnet-api-versioning/issues/393
https://github.com/microsoft/aspnet-api-versioning/issues/402

Thanks for the repro. I was able to recreate your conditions.
It took some digging and debugging, but I was able to track down where the problem occurs. It actually comes from the CORS library itself. For some reason it's doing something that it definitely should not:
AttributeBasedPolicyProviderFactory (Line 49)
The request pipeline uses the Flyweight pattern to pass the request around as a monad. You can see from this referenced code, however, that the CORS library is creating an entirely new request and forwarding it on. The comments claim that this is done due to things in the request property bag that shouldn't be passed along (but I don't know why). IMO, if this is really required, then the properties should be removed, the original request forwarded, and then re-add the properties after the return. This would maintain the monad.
This behavior breaks API Versioning, specifically, in the case of versioning by URL segment (which I don't recommend). This is because the only time API Versioning knows which route parameter value contains the API version is when the ApiVersionRouteConstraint is evaluated. When the route constraint matches, it gets or adds the ApiVersioningProperties from the request's property bag. Since there are two different request instances, there are two different property bags and two different sets of ApiVersioningProperties, one of whom does not have the API version because it wasn't the one used by the route constraint. Ultimately, this is a sequencing problem in the CORS library design.

NOTE: Other methods for API versioning are not affected by this because their readers can easily extract the scalar API version value from any request via a query string, header, or media type. Versioning by URL requires using a route constraint to avoid magic string parsing.

Honestly, I feel like this is a bug in the CORS library as I don't see any real compelling reason why a new request has to be created. This is certainly not something that extensions would expect to encounter. I only discovered this was the case by first noticing the property was missing later in the pipeline and that the hash code of the request objects didn't match at different points in the pipeline.
Ideally, it would be great if API Versioning can handle this situation, despite it being something that should never happen. I'm not sure what that solution is yet and it may take a little bit.
In the meantime, there are at least two possible workarounds:

Use a different method of versioning
Fork the AttributeBasedPolicyProviderFactory class, prevent it from creating a new request, and replace the default implementation in your configuration

I haven't tested this, but I expect it to work because simply setting the API version to the correct value while debugging made everything happy

Probably not the answers your hoping for, but that will hopefully unblock you while something more out-of-the-box is evaluated.
BTW: I noticed you had a lot of conflicting and unnecessary transitive dependencies in your repro. To use Autofac with the latest OWIN and Web API stacks, you need to target .NET 4.6.1. I'm not sure if there's a reason why you can't, but there are warnings of conflicting versions. You also don't need to list all of your transitive dependencies. The following subset resolves the same references:
<PropertyGroup>
 <TargetFramework>net461</TargetFramework>
</PropertyGroup>
<ItemGroup>
 <PackageReference Include="Autofac.WebApi2.Owin" Version="5.0.0" />
 <PackageReference Include="Microsoft.AspNet.WebApi.Cors" Version="5.2.7" />
 <PackageReference Include="Microsoft.AspNet.WebApi.OwinSelfHost" Version="5.2.7" />
 <PackageReference Include="Microsoft.AspNet.WebApi.Versioning.ApiExplorer" Version="4.0.0" />
 <PackageReference Include="Microsoft.Owin.Security.Jwt" Version="4.1.0" />
 <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
 <PackageReference Include="Owin.Logging.Common" Version="1.0.5506.19675" />
</ItemGroup>

Thanks @commonsensesoftware for this amazingly quick & comprehensive response. I'll need a bit of time to digest this & work out what to do.

A quick follow up. I looked at this just a bit more. The new request is definitely the culprit, but I figured out exactly why. AttributeBasedPolicyProviderFactory.cs (Line 72) does not account for GetRouteData possibly having side effects. That method ultimately triggers the evaluation of route constraints, but on the original request. As a result, this process never happens on the new request object and, therefore, the new request doesn't have the API version information.
I need to test and flush out whether it's the right thing, but it looks like I can tell if this has happened in a generic way by checking for the presence of the MS_RoutingContext key in the property bag. If it's not there, I can force route constraint evaluation by calling GetRouteData. It's not yet clear what other side effects that might have.
If I'm right, this means the ApiVersioningProperties extension method can change to something like this:
public static ApiVersionRequestProperties ApiVersionProperties(this HttpRequestMessage request)
{
 if ( request == null )
 {
  throw new ArgumentNullException( nameof( request ) );
 }

 if ( !request.Properties.TryGetValue(
        ApiVersionPropertiesKey,
        out ApiVersionRequestProperties properties ) )
 {
  // assume route constraints haven't been evaluated if this key isn't present
  var forceRouteConstraintEvaluation =
    !request.Properties.ContainsKey( RoutingContextKey );

  // add to the property bag FIRST because the ApiVersionRouteConstraint will re-enter,
  // resulting in StackOverflowException
  request.Properties[ApiVersionPropertiesKey] = properties =
    new ApiVersionRequestProperties( request );

  if ( forceRouteConstraintEvaluation )
  {
   // now force evaluation; reentrancy is safe at this point
   request.GetConfiguration().Routes.GetRouteData( request );
  }
 }

 return properties;
}

Testing against your repro seemed to behave as expected. I'll need to put this against the full suite, but hopefully I can get this patched in the next day or two. In the meantime, the other workarounds are still applicable.

Checking back in. Did the workaround work for you? I've incorporated my proposed generic solution, but it won't go out until the next release. If the workaround worked for you, I'll close this issue so I know it's complete and add the details to the release notes. Thanks.

Hi @commonsensesoftware. We ended up going with a different method of versioning. When you've released the fix we'll reconsider whether to revert to the original approach. Thanks for checking in.

Thanks for confirming. I'll mark this is an answered, but leave it open. It will auto-close once the changes are merged. That will be time to consider/reconsider incorporating things. Glad you got something working.

This is now fixed in 4.1.0-RC.1. The RC is just status parity with the other libraries at the moment. The official release should happen shortly after a little burn-in; probably 2 weeks. There's no additional work or fixes expected to go in. If the issue remains, feel free to reopen the issue or open a new one.  Thanks for helping track down the issue.


Add docs page for data contentlayer document field type

Feature added in PR #221

Guess this goes in https://flowershow.app/docs/mdx (?)


Added FIONREAD and FIONWRITE support for pipes

This is needed for nsh shell support over MAVLink

Committed: https://bitbucket.org/patacongo/nuttx/commits/f326ebd276fcac19a831867f41af6683a234b594
This was a difficult merge.  You will probably want to verify the result.
Greg


Backport: HBASE-24273 HBCK's "Orphan Regions on FileSystem" reports regions wit…

…h referenced HFiles (#1613)
Signed-off-by: stack<EMAIL_ADDRESS>

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
1m 21s
Docker failed to build yetus/hbase:d9b4982ad4.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/1682

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1682/1/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
2m 47s
Docker failed to build yetus/hbase:d9b4982ad4.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/1682

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1682/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
0m 52s
Docker failed to build yetus/hbase:d9b4982ad4.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/1682

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1682/3/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

It looks like there is an issue with docker, I built it locally with branch-2.2 and test passed with the test modified. The backport is a clean backport from branch-2.3, I am going to push and will revert if there is any issue.


refactor: Centralize config of pyright.

We should favor setting all exclusions and other configs in pyproject.toml. As such, this PR removes the exclude hook config for the pre-commit pyright. Ideally, there should be no difference between running pre-commit run pyright --all-files and pdm run --venv 3.11 pyright, and I propose that centralizing the config in this manner is the best way to achieve that.
This PR makes an effort to minimize the amount of excluded modules. So, in addition to moving the exclude config from .pre-commit-config.yaml to pyproject.toml, it also omits some of the exclusions and addresses the arising type issues.

Pull Request Checklist

[ ] New code has 100% test coverage
[ ] (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
[ ] (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
[ ] Pre-Commit Checks were ran and passed
[ ] Tests were ran and passed

Description

Close Issue(s)

Ideally, there should be no difference between running pre-commit run pyright --all-files and pdm run --venv 3.11 pyright

This is far from my experience, however. Even after removing exclude from pre-commit, pdm run --venv 3.11 pyright would report a lot more errors than pre-commit would.

Thanks for doing this!

@peterschutt any reason you're not targeting main with this?

@peterschutt any reason you're not targeting main with this?

Having v2 in the env fixes quite a few type errors - I had the v2 pinning logic in here first before opening #2438


Please push package for Ubuntu 19.10 Eoan Ermine

Ubuntu 19.10 Eoan Ermine was released on 10/17.
I believe someone needs to package_cloud push to make it available for eoan:
https://packagecloud.io/segment/aws-okta/

https://packagecloud.io/segment/aws-okta/packages/ubuntu/eoan/aws-okta_0.26.3_amd64.deb
In the process, I realized we hadn't published anything to packagecloud since v0.20.x 😬 Fixed!


FOV needs to be changed to 360

Widget
Visibility
Version of widget
Bug or Enhancement
Bug
Repo Steps or Enhancement details
The  visibility currently is set to have a FOV as 0 as the default. This needs to be changed to 360. When thinking about how a user would use our tools we want to capture the least amount of steps the user could take to get an answer. Most users would run this tool as a full 360 degree FOV; however, if we keep this at 0 then no matter what the user has to interact with the tool.

Complete please verify

I have verfied that this has been changed to 360:


Draft: Report collection

DESC

maybe short report

not necessary -- will be handley by gdrive and not the CMS


Fix case for headings in StatefulSet tutorial

Split out from #42767 to help reviewers. preview

Thanks.
/lgtm
/approve

Need to retrigger a build.


How can I handle "Error: Invalid specification provided"

I used
const { createGraphQLSchema } = require("openapi-to-graphql");

const { schema, report } = await createGraphQLSchema( openapi-url );

like
const { schema, report } = await createGraphQLSchema('https://raw.githubusercontent.com/OAI/OpenAPI-Specification/master/examples/v3.0/api-with-examples.yaml');

or saved openapi file to my computer and tried
const { schema, report } = await createGraphQLSchema( openapi-file-path );

I always got this error
(node:98189) UnhandledPromiseRejectionWarning: Error: Invalid specification provided

when I check validation of my swagger on https://editor.swagger.io/
The error I got is "Query strings in paths are not allowed."
Is "Query strings in paths are not allowed." error has any problem using openapi-to-graphql?

what should I do?
Please help me.

This is most likely coming from our Swagger to OAS translator/OAS validator swagger2openapi.
You can use the online tool to verify: https://mermade.org.uk/openapi-converter

If you do indeed get this error, then unfortunately, you will probably have to go report this error to swagger2openapi.
This error sounds like a valid error however. I believe query strings should be expressed using the (parameter object)[https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.3.md#parameterObject] instead of being hard coded in the path. Is it possible to use the parameter object instead?


Splitted LDAP directory tree

Hello,
I have two user groups and two organizational units (OU).
For example: User A is in the ou1 and user B is in the ou2.
All users in ou2 have a special mark in their name.
LDAP_BASE_DN for the first user is 'OU=ou1,dc=example,dc=org'
and for the second user 'OU=ou2,dc=example,dc=org'.
Is it possible to pass several LDAP_BASE_DN's?
My quick and dirty workaround is to add following code at line 181:
if 'special_mark' in request.authorization.username:
    records = conn.search_s('OU=ou2,dc=example,dc=org',
                                             ldap.SCOPE_SUBTREE, query, fields)
else:
    records = conn.search_s(current_app.config['LDAP_BASE_DN'],
                                             ldap.SCOPE_SUBTREE, query, fields)

Do you have some hint to make it better, without hard-coded changes in flask-simpleldap module?

It's not possible to have multiple BASE_DN in python-ldap (the underlying lib) so it's not possible and won't be in flask-simpleldap as well.
You may be able to use dc=example,dc=org as your BASE_DN and modify your search filters to search in both OU if you also set the following option:
LDAP_CUSTOM_OPTIONS = {ldap.OPT_REFERRALS: 0}

Thank you for your answer.
I'll try LDAP_CUSTOM_OPTIONS = {ldap.OPT_REFERRALS: 0} option and let you know if it worked for me.

Yes, it works for me. I think it would be good if that will be documented. It will help many AD users.


Error: task completion callback called too many times

Not sure if this is related to #41 but if I do the following, the gulp task hangs as if waiting on something async:
gulp.task('default', ['selenium'], function(done) {
  return gulp.src('wdio.conf.js').pipe(webdriver());
});

If I try doing the following, it errors with Error: task completion callback called too many times
gulp.task('default', ['selenium'], function(done) {
  return gulp.src('wdio.conf.js').pipe(webdriver())
  .on('end', function() {
    done();
  });
});

btw doing process.exit() works within end but that seems wrong

Er realized that selenium was still running and needed to do selenium.process.kill();


Set a default appUpdatePollInterval value

This default value is set to 60000 ms (1 second)

It feels to me like maybe this default should be shared somehow, @emirotin

@Page- Shared where?

@Page- I'll merge this one for now in order to not be blocked by it. We can refactor afterwards.


Update some steps according to the new Python build changes

Hi Team,
According to the latest Python build and runtime workflow changes that is announced here:
https://github.com/Azure-App-Service/KuduLite/wiki/Python-Build-Changes
Step 2 in this tutorial:

Should be update to use $APP_PATH instead of site/wwwroot "cd $APP_PATH"
Since the upgraded apps will no longer have the app running in site/wwwroot, instead it would have a dynamic runtime directory, that can be retrieved using the APP_PATH environment variable.
Step 3:

Is probably no longer needed, not sure how to confirm when this is needed and when it is not, but in our case we could not find the directory /antenv/, skipping this step worked fine and we were able to successfully deploy the app. So I guess it is worth verifying/mentioning this in the document.
Thanks in advance!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f4d873da-7721-07bf-9584-78d1b5788167
Version Independent ID: 81490eea-63aa-d729-c9fb-6753961e39cc
Content: Tutorial: Deploy a Django app with PostgreSQL using the Azure portal
Content Source: articles/python/tutorial-python-postgresql-app-portal.md
Product: azure-python
GitHub Login: @kraigb
Microsoft Alias: kraigb

Done.
Please note that the SSH session is reporting an error for antenv/bin/activate, and it's still necessary to manually install dependencies:

/  _  \ __________ _________   ____
/  /\  ___   /  |  _  __ _/ __
/    |    /    /|  |  /|  | /\  /
_|__  /_____ _/ ||    ___  >
/      /                  /
A P P   S E R V I C E   O N   L I N U X
Documentation: http://aka.ms/webapp-linux
Python 3.8.6
Note: Any data outside '/home' is not persisted
-bash: antenv/bin/activate: No such file or directory

Done.
Please note that the SSH session is reporting an error for antenv/bin/activate, and it's still necessary to manually install dependencies:

/  _  \ __________ _________   ____
/  /\  ___   /  |  _  __ _/ __
/    |    /    /|  |  /|  | /\  /
_|__  /_____ _/ ||    ___  >
/      /                  /
A P P   S E R V I C E   O N   L I N U X
Documentation: http://aka.ms/webapp-linux
Python 3.8.6
Note: Any data outside '/home' is not persisted
-bash: antenv/bin/activate: No such file or directory

One clarification: the source /antenv/bin/activate is still needed, and doing so removes the need to pip install requirements. It appears that App Service is trying to activate antenv by default, but doesn't have the leading /. The antenv folder is there in the root. So I'm leaving the activate command but removing pip install.

One clarification: the source /antenv/bin/activate is still needed, and doing so removes the need to pip install requirements. It appears that App Service is trying to activate antenv by default, but doesn't have the leading /. The antenv folder is there in the root. So I'm leaving the activate command but removing pip install.


switch to envconfig

In-order to reach docker-compose/docker compatibility the config is now coming from the env vars.

Coverage decreased (-0.1%) to 77.473% when pulling 204a3128b4bd4c75693b643a1b72c105c1ea3204 on env-config into 1b70d662e6ab8179cb7e878ff75aa54dc12606ff on master.


Redoing stuff from October

See #338 (https://github.com/chaoss/wg-diversity-inclusion/pull/338)

Thanks @LawrenceHecht
Taking a look, I think your additions are much appreciated. From a formatting perspective, we follow the template from here:
https://github.com/chaoss/metrics/blob/master/resources/metrics-template.md
This would have an impact on a few of the header changes that you suggest.
@Ruth-ikegah -- what do you think of the proposed changes?

Signed-off-by @LawrenceHecht

signed-off-by Lawrence Hecht<EMAIL_ADDRESS>

Taking a look, I think your additions are much appreciated. From a formatting perspective, we follow the template from here:
https://github.com/chaoss/metrics/blob/master/resources/metrics-template.md
This would have an impact on a few of the header changes that you suggest.

@germonprez I tried to tweak a couple of headers -- but I'm still having problems with the DCO through my browser, so my update didn't go through. If that still doesn't work, then just get rid of the "###" tags in this document -- they are not needed.

signed-off-by Lawrence Hecht<EMAIL_ADDRESS>

@LawrenceHecht these changes have been captured in another doc and will be resurfaced when we do our periodic review of the Burnout metric. This should be happening in the next month or so. :+1: I'm closing this for now. Thanks for your work here! :pray:


Import-Export States to your DevTools

I've put together a small addition to the code that would allow us to import and export action logs.

Export button added to top bar.
Copy the current state from the textarea and paste it on another session running the app.

This feature (or something similar) would be awesome to use for QA purposes among other things.

Huge :+1: Anything keeping this back? @gaearon seemed keen on it in #117

Only that we're splitting LogMonitor into a separate project: https://github.com/gaearon/redux-devtools/pull/132. Once that's done, I'll definitely take a look. Sorry it's taking long!

Haha, I love how you define this as a long wait, when it's been a week. I was just wondering if it had fallen through the cracks :smile: No problem there though, apparently. Keep up the great work!
Btw (and sorta related), is there any possibility of getting a sync between browsers/sessions? So you can have different browsers up at the same time all getting the same data automatically. I sorta have it now using browsersync, but that syncs clicks and inputs, and not actual state, which would be nicer, IMO. If it's available, or discussed in another issue, apologies.

Btw (and sorta related), is there any possibility of getting a sync between browsers/sessions?

You can implement as a store enhancer for regular Redux—it will work with Redux DevTools just fine. You can use persistState as inspiration (though it does a different thing).

@pabloalonsos
Can I ask you to tweak this to:

Have separate Import and Export buttons on the toolbar (never mind the design; we'll fix it later)
Remove the notion of "export mode"
Instead of a text area, show JSON in window.prompt for both import and export

?

sounds good! I'll try to make the changes today :+1:

There you go. Let me know if all is good and I can squash those commits into one.
There are a couple of "issues" (not really issues but worth bringing up) I ran into:

By using window.prompt instead of the textarea component, ESLint is throwing a couple of warnings. I don't mind finding a different approach if we want to get rid of those warnings without modifying the lint rules (using a custom modal component with a textarea or something like that).
ESLint was also complaining about having import as an action (because of the reserved word) so I switched it to importState. I'm pretty bad at picking names for attributes and variables so feel free to suggest alternatives if those are not the best names for this.

Thanks guys!

Updated :+1:

One more thing: can you please add some tests?

Busy couple of days at work. I'll try and add the tests before the end of the week!

Sure, thanks! Sorry I'm a bit stuck here too—on a vacation.

Test added! Let me know if anything is missing

I'm bringing this in via b4da7aa in vNext branch.
Closing this PR as is because it won't merge cleanly there.
Thanks!


Update example docker compose so services restart on crash

Restic backup can fail for a number of reasons. If the process crashes once, it should be restarted, so once the underlying failure is resolved (B2 API downtime, internet connectivity issues, etc) backups will resume automatically.

As far as I can see, the container should never crash because everything is wrapped in a cron scheduler process. Does the container crash for you?

This happened a long time ago. I don't recall if the container crashed fully, but I assume so. The failure had to do with a server error at B2

Would be good if anyone can confirm that the container can crash. (And I would really like to know how that can happen.)
As I don't think the container will crash, the restart option won't help with your problem either way.

either can the container crash or not is not the question here imo, having a restart policy is a really good docker practice, and can be useful in other cases like a restart or else, not only to prevent crashes (and even if they are rare, they can still happen)
but the unless-stopped policy should be a better choice, always would trap people into having restic always on 24/7, and their only way to shutdown it would be to delete the container, so it's not ideal

Okay, let's do that. I also trapped on restart: always quite a few times, so @tobiasmuehl please change it to unless-stopped.

done


HDH-245-tab-color-in-dark-mode-detals-sections

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://662087059005a6e4280c5edd--harness-developer.netlify.app


Update DefaultSslProtocolSocketFactory.java

@YYTVicky Please create a Jira issue for your code change and resubmit a PR

Hi @nichunen , a JIRA issue has been created and a PR has been resubmitted as per your instruction to @YYTVicky .


Markdown build

Copying over the setup from the Digital Playbook and the Open First Whitepaper.
If you're interested, someone with admin permissions will need to enable to Travis-CI hook to test the commits.
For viewing the non-whitespace changes https://github.com/canada-ca/OS-Advisory_Conseil-SO/pull/13/files?w=1

Let me know if you need Travis setup.

@nschonni are all of your commits created using TravisCI hook?

Oops, didn't give a good explaination.
No, all the commits are still manual, but the Travis-CI hook is used to check that whoever is making the commit doesn't break formatting of the documents. They all just look similar because I try to use a consistent commit format, and keep the changes small and related.
I'll rebase this to address the confilicts if you're interested in adding this.

Thank you so much Nick, I am interested in adding your changes and am interested in setting up the Travis-CI hook-up @MaryBethBaker

@MaryBethBaker I think this is probably the best setup guide https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI
You'd just need to do the step 1&2
PS: Maybe this stuff would be good to add some of the setup stuff to the doc you're talking about in https://github.com/canada-ca/welcome/issues/29

Great idea!
Mary Beth

On Apr 20, 2018, at 10:32 AM, Nick Schonning<EMAIL_ADDRESS>wrote:
@MaryBethBaker I think this is probably the best setup guide https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI
You'd just need to do the step 1&2
PS: Maybe this stuff would be good to add some of the setup stuff to the doc you're talking about in canada-ca/welcome#29
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Adds code to be able to work around if the go runtime can't find the

profiledirectory.  Agent doesn't need it, anyway.  All we require
is the users's SID.  Was needlessly preventing agent from starting.
Adds additional logging to detect this case in the future, even when
agent starts correctly
Motivation
Customer bug report
Additional Notes
Anything else we should know when reviewing?

@derekwbrown something went wrong on your branch, you'll likely want to start from master again and only include the relevant commits :)

recreated cleanly as https://github.com/DataDog/datadog-agent/pull/3859


LLVM ERROR: Cannot select: t3: i32,ch = AtomicLoadAdd

Building the example https://github.com/zjin-lcf/HeCBench/tree/master/gc-omp
shows the error
LLVM ERROR: Cannot select: t3: i32,ch = AtomicLoadAdd<(load store monotonic (s32) on %ir.369, addrspace 5)> t0, FrameIndex:i32<0>, Constant:i32<1>
t1: i32 = FrameIndex<0>
t2: i32 = Constant<1>
In function: __omp_offloading_33_79b0ac0__ZL4initiiPKiS0_PiS1_S1_S1_S1_i_l103
PLEASE submit a bug report to https://github.com/ROCm-Developer-Tools/aomp and include the crash backtrace.
Stack dump

This compilation issue will be fixed in 14.0-1

I updated the example yesterday. I hope running on a device will be successful after the fix. Thank you for your test.

I converted the omp directives for a cpu to directives for a gpu. Running the program hangs. If the omp directives are not applied correctly for target offloading, please let me know. Thanks.

I am trying to replicate this now and test in 14.0-2

I don-t see this failing on 14.0-2 so I would like to close this.   Compile works.   Execution fails because of a missing input file.
/work/grodgers/rocm/aomp/bin/clang++ -std=c++14 -Wall -I../mis-cuda -O3 -DOMP_TARGET -target x86_64-pc-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx906  -c main.cpp -o main.o
/work/grodgers/rocm/aomp/bin/clang++ -std=c++14 -Wall -I../mis-cuda -O3 -DOMP_TARGET -target x86_64-pc-linux-gnu -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx906  main.o -o main
./main ../mis-cuda/internet.egr 256
ECL-GC OpenMP v1.2 (main.cpp)
Copyright 2020 Texas State University

ERROR: could not open file ../mis-cuda/internet.egr

Makefile.aomp:68: recipe for target 'run' failed
make: *** [run] Error 255

Thanks for reporting this issue.   BTW, I would make this simple change to Makefile.aomp to make your build more portable.  We do not like requiring clang in the PATH.
grodgers@r4:~/git/APPS/HeCBench/gc-omp$ git diff Makefile.aomp
diff --git a/gc-omp/Makefile.aomp b/gc-omp/Makefile.aomp
index d6715cb6..d1d12c88 100644
--- a/gc-omp/Makefile.aomp
+++ b/gc-omp/Makefile.aomp
@@ -3,11 +3,13 @@
 #===============================================================================

 # Compiler can be set below, or via environment variable
-CC        = clang++
+AOMP     ?= /usr/lib/aomp
+CC        = $(AOMP)/bin/clang++
 OPTIMIZE  = yes
 DEBUG     = no
 DEVICE    = gpu
-ARCH      = gfx906
+ARCH      = $(shell $(AOMP)/bin/offload-arch)
+TRIPLE    = $(shell $(AOMP)/bin/offload-arch -t | awk '{print $$2}')

 #===============================================================================
 # Program name & source code list
@@ -43,8 +45,8 @@ endif

 ifeq ($(DEVICE),gpu)
   CFLAGS += -DOMP_TARGET -target x86_64-pc-linux-gnu \
-          -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa \
-          -Xopenmp-target=amdgcn-amd-amdhsa \
+          -fopenmp -fopenmp-targets=$(TRIPLE) \
+          -Xopenmp-target=$(TRIPLE) \
           -march=$(ARCH)
 else
   CFLAGS +=-fopenmp

I will run the program with the data file when 14.0.2 is released. ~20 days ago, building the program was successful.
Thank you for your comments and suggestions.

I ran the program with 14.0.2. Running the program hangs on a GPU. The dataset (e.g. internet.egr) can be downloaded from https://userweb.cs.txstate.edu/~burtscher/research/ECLgraph/index.html


Feature/improve six select

🔗 Linked issue

❓ Type of change

[x] 👌 Enhancement (improving an existing functionality like performance)

📚 Description
Resolves  #128
📝 Checklist

[x] I have linked an issue or discussion.
[x] It's submitted to the main branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] I have updated the documentation accordingly.
[ ] All tests are passing
[ ] New/updated tests are included
[ ] I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

[x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Before:

After:

I think it looks better, if there is no spacing between the first item and the start of the container. At the bottom it is the same.
There is now also a gap between the dropdown trigger and the item container. Is that intentional?

I know, that the move of the checkmark to the left was part of the ticket. Non the less, i think it isn't visually appealing that there is such a big gap on the left side of every item, if there isn't anything selected.

Maybe indicate that an item is selected by changing the background color.
It looks like most component libraries are doing it like this:
Angular Material

Bootstrap

Prime NG

I think the removal of the arrow icon, when clearable is enabled, makes it difficult to recognize it still as a select instead of a text field.
Select

Text Input

It looks exactly the same!

The "default-value" attribute doesn't seem to do anything. What was it supposed to do? Maybe it was already broken?

The item label and the checkbox in the multi select don't seem to be aligned correctly.

Missing check icon in six-header:
New (check icon missing):

Before (Correct)

In my eyes it would look better if the group item has to same height as the normal ones and the text is bold
Currently

(in my eyes) improved

Async Filtering does't seem to work anymore.

six-select is noticeably laggy
https://github.com/six-group/six-webcomponents/assets/69892203/ef62e8af-f88a-4f6a-aea6-817bac049fb1

six-select seems to be laggy
https://github.com/six-group/six-webcomponents/assets/69892203/e29c04e8-136f-4c47-8ed6-52b7e75e9b3f

When you press the mouse down on an item, move the mouse outside of the container and then release it, the item is still "hovered"
https://github.com/six-group/six-webcomponents/assets/69892203/aa6aa1b8-ebde-4f2a-a480-d89318907d03

Weird flickering in the input field when pressing the "Select all" button.
https://github.com/six-group/six-webcomponents/assets/69892203/8d1f9155-8847-42d1-9547-05c9abe0cc2e
Also. wouldn't it make more sense, if the button says "Deselect all" once pressed?

Weird flickering in the input field when pressing the "Select all" button.

The number of additional items is now computed dynamically, which can cause some flickering. I think it would be possible to prevent the flickering by hiding added items, before computing the available width. However, since we don't have a lot of resources to work on this, I think we can accept the flickering problem for now.

Also. wouldn't it make more sense, if the button says "Deselect all" once pressed?

Good idea. Changed with 6d0ac0f1a8a0f29146705aef05f9e66eec427d89


Do not run Git integration tests by default

Is this a real issue?

Well I think so yes considering that they don't pass successfully (they are using external resources that don't even exist anymore)! And IMHO integration tests shouldn't be executed in the same lifecycle as unit tests...

The change makes sense. Merged via https://github.com/apache/netbeans/commit/b4f8d19733318daff1b3d3fc538a1493b8b02bbe. Thank you.


Not support anonymous union in struct

Hello @tang4530, thanks for request.
Description
UTBotCpp don't generate test for struct with anonymous union.
typedef struct {
  int a;
  union {
    int b;
    int c;
  } u;
} Info;

int inner(Info l) {
  if (l.a == 1) {
    l.u.b = 4;
    return 0;
  }
  if (l.a == 2) {
    l.u.c = 5;
    return 1;
  }
  return -1;
}

Expected behavior
Test will generated same as struct with named union.

I have modified anonymous union to the named union. But some compile errors occured.


Add missing rich text block toolbar styles

Follow-up to #8964. Our rich text block toolbar is missing some of its styles:

Alignment between the icons and labels is off
The "No results" state has incorrect padding
The first and last items do not have the correct top and bottom padding (particularly the /-command variant without the search field
The hover styles aren’t as per the designs
Hovered items need a cursor: pointer
The height of the element (set in vh) is higher than intended

And for the variant within StreamField:

Styles for each option group label are a bit off
We’re missing the red error styles when reaching the maximum block count ("0 / 2")

Hi, @thibaudcolas can i take up on this to fix the styling issues

is it something i'll be able to work on ?

Hey @fyunusa, no need to ask, just state that you intend to work on it 🙂

Oh yeah, I'm on it already thanks
On Sun, Oct 16, 2022, 9:23 PM Scott Cranfill @.***>
wrote:

Hey @fyunusa https://github.com/fyunusa, no need to ask, just state
that you intend to work on it 🙂
—
Reply to this email directly, view it on GitHub
https://github.com/wagtail/wagtail/issues/9026#issuecomment-1280049314,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANGFPLNZOQIUY75ZK76VECTWDRP37ANCNFSM5636A6YA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Closing this in favour of #9754 which has the latest designs for this part of the UI.


Download video error

Download video error
unable to download
Authentication required cannot be used

Confirmed, after updating to Vivaldi 2.9.1732.13 / Chrome 79.0.3945.27
Seems related to Chrome 79


When install by composer error to request http

When install by composer error to request http.
When add to file "lucadegasperi/oauth2-server-laravel": "5.1.*" and execute composer update
Laravel Framework version 5.2.41
Error:
C:\Users\eteck\Documents\Proyectos\tienda_linea\codigo\tienda>composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
The "http://packagist.org/p/illuminate/routing%24b3430dfdf6c549d2b0a677f6d9d755567a1ab47d7135eb5ecfb50d536801cd6c.json" file could not be downloaded: failed to open stream: HTTP request failed!
http://packagist.org could not be fully loaded, package information was loaded from the local cache and may be out of date
[Composer\Downloader\TransportException]
The "http://packagist.org/p/league/oauth2server%242d413ba39a9b7fcce5c3f94d31c884770987dde2b173b1ec3ad33474c7fe00ec.
json" file could not be downloaded: failed to open stream: HTTP request failed!
update [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--lock] [--no-custom-installers] [--no-autoloader] [--no-scripts] [--no-progress] [--no-suggest] [--with-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] []...
Help me!! please

This isn't an issue with this package.

Thanks for using this package!
For this kind of support questions, we'd like you to use the following resources:

Documentation
OAuth 2.0 Documentation
Laracasts
Laravel Slack
Stack Overflow

This will allow us to keep the issues for bug reporting only and make our work easier.

This isn't an issue with this package. Sorry.


Rename to SDL_shadercross?

SDL_gpu_shadercross is kind of a mouthful. Maybe we could shorten it?

Resolved by https://github.com/libsdl-org/SDL_shadercross/commit/fd5a62b52059b13fb91008ee98e2168f1da31342


Alis/azure upgrade

DEVOPS PULL REQUEST

resolves #4343

Related Issue

The primary goal is to upgrade the terraform provider version to 3.
Most of the global state has also been synced, with one exception I plan to address after rolling these upgrades out.

Changes Proposed
Services

upgrade azurerm provider from 2.92 to 3.34
upgrade okta 3.19 to 3.39
allow patch upgrades for the random provider
include new terraform lock files with new provider versions selected
update module arguments
update azure resource app_service_plan_id and all references to be service_plan_id
update arguments on all function/app services
update azurerm_cdn_endpoint to use attribute fqdn
explicitly disable cross-tenant replication for the frontend storage accounts
explicitly disable blob public access for the frontend storage accounts
update assigned values for key_permissions and secret_permissions to use correct strings
update log arguments on collect_appserviceconsolelogs so that we have less churn on that resource
add lifecycles to our apps to force a recreation if our app service is recreated.
add zones to our app gateway
add priority values to our request_routing_rules

Global

update ai_ingest_cap_gb in the insights module in the global terraform to match current global settings
update string values of some global resources to match was is currently live

Testing

How should reviewers verify this PR?

Checklist for Primary Reviewer
Infrastructure

[ ] Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

[ ] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[ ] Any dependencies introduced have been vetted and discussed

Cloud

[ ] Oncall has been notified if this change is going in after-hours
[ ] If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

[ ] Any changes to the startup configuration have been documented in the README

Extra!

[ ] Check that dev2 function apps are running, and logs are viewable.
[ ] Check that dev2 service apps are running, and logs are viewable.
[ ] Check that the SR app is available and functioning properly
[ ] Check that the SR app has database access
[ ] Check that Metabase is available and configurable
[ ] Check that deploys/rollbacks work

I'll get this merge conflict dealt with today.


TSServer not finding imports from node_modules on new cli app

Versions
Angular CLI: 1.7.1
Node: 9.4.0
OS: darwin x64
Angular: 5.2.6
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cli: 1.7.1
@angular-devkit/build-optimizer: 0.3.2
@angular-devkit/core: 0.3.2
@angular-devkit/schematics: 0.3.2
@ngtools/json-schema: 1.2.0
@ngtools/webpack: 1.10.1
@schematics/angular: 0.3.2
@schematics/package-update: 0.3.2
typescript: 2.5.3
webpack: 3.11.0

Repro steps

Create a new cli project with ng new [name]
Open your this project in your favorite editor that supports auto imports. I used VSCode with TS Hero as well as Vim with tsuquyomi.
In app.component.ts try adding a class member form: FormGroup and then using whatever tool you want try doing an auto import.

Observed behavior
Error from TS Hero in VS Code
2018-02-28T15:44:07.675Z - error: [DeclarationManager] A workspace did encounter an error.
2018-02-28T15:44:07.676Z - error: [WorkspaceDeclarations] Error during indexing of workspacefiles. {"error":"TypeError: Cannot read property 'length' of undefined","workspace":"/Users/driley/dev/temp/cli-test"}

Error from Tsuguyomi
[Tsuquyomi] Nothing was hit.

Desired behavior

Have TS Server be able to resolve node module imports
Mention any other details that might be useful (optional)

I still have other angular cli projects where I'm not seeing a problem.
I also am able to auto import from components or classes in the src folder. It's just stuff in node_modules
If i manually add the import it is resolved correctly.
I tried downloading this repo and was able to do auto imports from it.

this auto import is dealt by your editor .
can you mention , which editor you have used in previous project , in which auto import worked .
and as you mentioned to "have ts server ". do you mean to make server.ts get ability to auto import.

I've mentioned 2 editors that I use. VS Code with TS Hero, and Vim with tsuquyomi. And no, i'm referring to typescripts server, which IDEs use so you can do things like rename symbol, find imports and it cover type checking for you.
So basically I have projects that were created months ago using angular cli where I don't see this problem, in either editor. So if i create a new component and add a FormGroup to it like public form: FormGroup and then in VS Code i can do command + . or TS Heros auto import and it'll automatically find the import from node modules.
but with the new app that i created yesterday using the above version of cli it can't locate anything from node_modules, and I believe somewhere in one of the angular cli package dependencies there is something that is breaking the tsserver.

Are you still seeing this problem?


merge master to live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

LICENSE
:white_check_mark:Succeeded

LICENSE-CODE
:white_check_mark:Succeeded

README.md
:white_check_mark:Succeeded

ThirdPartyNotices
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Laravel Mix + Heroku Issue (Additional Dependencies Required)

Laravel Mix Version: 1.6.0

Description:
Laravel Mix is great, and it is even smart enough to install it's own dependencies if it finds something missing. However, if deploying to Heroku, and a dependency is missing, it installs the dependency but then requires you to rerun mix. This breaks builds on Heroku, which does the deployment automatically. The user could open a shell to the server and rerun mix, or include two npm run productions in their deployment scripts, but these are less than ideal solutions.
The message from Mix 'Additional dependencies need to be installed' and 'Please run mix again' are helpful for identifying that there is a problem, but they don't say what dependencies, making it difficult to pre-install those to ensure they are installed by npm/yarn.
This issue crops up when upgrading from an older version of Mix / Laravel.
Suggested Resolution: Display names of missing dependencies in the existing console.log
Steps To Reproduce:
Try not including a dependency that Mix wants.

For me, the issue was some dependencies were in devDependencies, but really should have been in dependencies, since npm install is running in a production environment.
But, I agree. It should really say what's missing.


Kid header parameter

Decoded JWT token header looks like this:
{
    "alg": "RS256",
    "typ": "JWT",
    "kid": null
}

Is there any reason to include this parameter at all if the value is not provided?

The "kid" (key ID) Header Parameter is a hint indicating which key
was used to secure the JWS.  This parameter allows originators to
explicitly signal a change of key to recipients.  The structure of
the "kid" value is unspecified.  Its value MUST be a case-sensitive
string.  Use of this Header Parameter is OPTIONAL.
https://tools.ietf.org/html/rfc7515#section-4.1.4

The "kid" (key ID) header parameter is a hint indicating which specific key owned by the signer
should be used to validate the signature. This allows signers to explicitly signal a change of key to
recipients. Omitting this parameter is equivalent to setting it to an empty string. The interpretation
of the contents of the "kid" parameter is unspecified. This header parameter is OPTIONAL.
http://self-issued.info/docs/draft-jones-json-web-token-01.html

I don't see a reason to include kid as null.

I think this issue is addressed with the latest changes: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/KDev/src/System.IdentityModel.Tokens.Jwt/JwtHeader.cs#L65

@zygimantas @brentschmaltz closing this as fixed.


Update Korean i18n strings and ordering the entries

Related: #24346
https://github.com/kubernetes/website/pull/24592#issuecomment-709670671

I intentionally excluded #24346. This is because it cannot be approved by the authority of the Korean localization team.
@markruler Sorry for the inconvenience. Could you reopen the PR to the master branch?

/cc @kubernetes/sig-docs-ko-reviews

/language ko

/assign @seokho-son

/lgtm
as a sig-docs-ko-owners.
@kbhawkey Cloud you check and approve this PR ?
(Korean l10n team doesn't have ownership on this ko.toml file)

Page preview:
https://deploy-preview-24651--kubernetes-io-master-staging.netlify.app/ko/
Thanks @markruler
/approve


Add linkedin refs on "Bundesvorstand"-page and replace email-links with icons

remove current e-mail links with an icon
add a linkedin icon with the corresponding link (if person wants to have a linkedin-reference)

(cf. Ticket #118)

is resolved without icons in the status quo, since it looks okay i close this issue.


Sharing Control - Stale externally shared files

Update the description to reflect that this does not check if file has been opened.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0192fe47-4af3-0a7b-74a1-efbe7ad7536a
Version Independent ID: 34ff03e6-aadf-638d-1b9f-30b999b19240
Content: Policy template reference for Cloud App Security
Content Source: CloudAppSecurityDocs/policy-template-reference.md
Service: cloud-app-security
GitHub Login: @shsagir
Microsoft Alias: shsagir

@pjcarr3 Thanks for your feedback. Please can you provide a little more detail on the issue you raised? Which description are you referring to?

Sorry I called it out in my title. It is the description for "Stale externally shared files. "

@name Thanks for your the additional information. We've submitted a documentation change based on your suggestion, and the updated article should be live by tomorrow. Please let us know if there's anything more we can do for you. To follow up on this issue, leave us a comment with an @mention.


Capture Liveness event in update section

Type of question

<-- Best practices -->

Question
How do we capture liveness event change in the update section in eventFilterPredicate function?
What did you do?
func (r *MyAppReconciler) eventFilterPredicate() predicate.Predicate {
        return predicate.Funcs{
                CreateFunc: func(e event.CreateEvent) bool {
                        return true
                },

                UpdateFunc: func(e event.UpdateEvent) bool {
                             return true
                },

I want to know how do we capture the Liveness probe event when it changes from healthy to unhealthy and vice versa?  or if there is an increment in failure or success count?
What did you expect to see?

What did you see instead? Under which circumstances?

Environment
Operator type:

<-- /language go -->

Kubernetes cluster type:

$ operator-sdk version
operator-sdk version: "v1.2.0", commit: "215fc50b2d4acc7d92b36828f42d7d1ae212015c", kubernetes version: "v1.18.8", go version: "go1.15.3", GOOS: "linux", GOARCH: "amd64"
$ go version (if language is Go)
go version go1.15.8 linux/amd64
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:28:09Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.8", GitCommit:"336ccfb2560ff170c7ad8aad56944e43e4f6a170", GitTreeState:"clean", BuildDate:"2020-06-09T22:13:31Z", GoVersion:"go1.13.8 BoringCrypto", Compiler:"gc", Platform:"linux/amd64"}

Additional context

You could implement your own healthz.Checker that updates some external state on failed liveness/readiness. You might be able to do this in a predicate, but using the Checker callback would be easier.
This is a question about the controller-runtime library, so I'm going this out here. If you have further questions, please recreate this issue in the controller-runtime repo.