Proposal: declarative reducers

I propose provide option for defining reducer with a plain JS object where keys are action types and functions defined with ES6 arrow functions (which leads to less code):
Here code example based on of Redux TodoMVC reducer.
How it declared now:
const initialState = [
  {
    text: 'Use Redux',
    completed: false,
    id: 0
  }
]

export default function todos(state = initialState, action) {
  switch (action.type) {
    case ADD_TODO:
      return [
        {
          id: state.reduce((maxId, todo) => Math.max(todo.id, maxId), -1) + 1,
          completed: false,
          text: action.text
        },
        ...state
      ]

    case DELETE_TODO:
      return state.filter(todo =>
        todo.id !== action.id
      )

    case EDIT_TODO:
      return state.map(todo =>
        todo.id === action.id ?
          Object.assign({}, todo, { text: action.text }) :
          todo
      )

    case COMPLETE_TODO:
      return state.map(todo =>
        todo.id === action.id ?
          Object.assign({}, todo, { completed: !todo.completed }) :
          todo
      )

    case COMPLETE_ALL:
      const areAllMarked = state.every(todo => todo.completed)
      return state.map(todo => Object.assign({}, todo, {
        completed: !areAllMarked
      }))

    case CLEAR_COMPLETED:
      return state.filter(todo => todo.completed === false)

    default:
      return state
  }
}

How I propose to declare:
export default {
  initialState: [
    {
      text: 'Use Redux',
      completed: false,
      id: 0
    }
  ],

  [ADD_TODO]: (state, {text}) => [
    {
      id: state.reduce((maxId, todo) => Math.max(todo.id, maxId), -1) + 1,
      completed: false,
      text
    },
    ...state
  ],

  [DELETE_TODO]: (state, {id}) => state.filter(todo => todo.id !== id),

  [EDIT_TODO]: (state, {id, text}) =>
    state.map(todo => (todo.id === id) ? {...todo, text} : todo),

  [COMPLETE_TODO]: (state, {id}) =>
    state.map(todo => (todo.id === id) ? { ...todo, completed: !todo.completed } : todo),

  [COMPLETE_ALL]: state => {
      const areAllMarked = state.every(todo => todo.completed);
      return state.map(todo => ({ ...todo, completed: !areAllMarked }))
  },

  [CLEAR_COMPLETED]: state => state.filter(todo => todo.completed === false)
}

Pros

Parameter destructuring e.g:

(state, {id, text}) =>
    state.map(todo => (todo.id === id) ? {...todo, text} : todo)

No "return" statement
No "case" statement
Less code
Better readability

And here function to convert declarative reducer to standard reducer:
function createReducer(reducerConfig){
  const { initialState, ...reducers } = reducerConfig;

  return (state = initialState, action) => {
    const reducer = reducers[action.type];

    if (typeof reducer === 'function'){
      return reducer(state, action);
    } else {
      return state;
    }
  };
}

As far as I can say, similar syntax has been proposed multiple times, and even mentioned in the docs.
Generally speaking, reducer does not have to map <action type, function> one-to-one. It is more like <predicate, function>. There are valid use cases where reducer checks the presence of specific payload in the action instead of checking action type.

From http://redux.js.org/docs/recipes/ReducingBoilerplate.html#generating-reducers:

Let’s write a function that lets us express reducers as an object mapping from action types to handlers. For example, if we want our todos reducers to be defined like this:

export const todos = createReducer([], {
[ActionTypes.ADD_TODO](state, action) {
let text = action.text.trim()
return [ ...state, text ]
}
})

>We can write the following helper to accomplish this:

>```js
function createReducer(initialState, handlers) {
  return function reducer(state = initialState, action) {
    if (handlers.hasOwnProperty(action.type)) {
      return handlers[action.type](state, action)
    } else {
      return state
    }
  }
}

This wasn’t difficult, was it? Redux doesn’t provide such a helper function by default because there are many ways to write it. Maybe you want it to automatically convert plain JS objects to Immutable objects to hydrate the server state. Maybe you want to merge the returned state with the current state. There may be different approaches to a “catch all” handler. All of this depends on the conventions you choose for your team on a specific project.

The Redux reducer API is (state, action) => state, but how you create those reducers is up to you.

gaearon, does "redux" package provide "createReducer" function?
Or it need to be copy-pasted every time?

Reducer composition is a common pattern in Redux. See shopping-cart example:
function products(state, action) {
  switch (action.type) {
    case ADD_TO_CART:
      return {
        ...state,
        inventory: state.inventory - 1
      }
    default:
      return state
  }
}

function byId(state = {}, action) {
  switch (action.type) {
    case RECEIVE_PRODUCTS:
      return {
        ...state,
        ...action.products.reduce((obj, product) => {
          obj[product.id] = product
          return obj
        }, {})
      }
    default:
      const { productId } = action
      if (productId) {
        return {
          ...state,
          [productId]: products(state[productId], action)
        }
      }
      return state
  }
}

function visibleIds(state = [], action) {
  switch (action.type) {
    case RECEIVE_PRODUCTS:
      return action.products.map(product => product.id)
    default:
      return state
  }
}

export default combineReducers({
  byId,
  visibleIds
})

If we force users to declare reducers as object maps, many powerful patterns that are possible with functions become harder and non-obvious. This is why we don't encourage users to take shortcuts. If you discover a shortcut and find it convenient, use it, but we don't want to limit your imagination because otherwise you won't come up with reducer composition-based solutions like the code above.

It doesn't. It doesn't need to be copy-pasted. Create a package with it, if you like it. We don't want to support this as an official solution because we don't believe such indirection is necessary or even desirable. This is in the realm of projects like https://github.com/gajus/canonical-reducer-composition that want to dictate their specific conventions. Redux has no opinion here.

many powerful patterns that are possible with functions become harder and non-obvious.

May you give an example of such pattern?

I added comments to the example.

Same discussion in the past: https://github.com/rackt/redux/issues/883.

@gaearon
Few general questions:

Does redux "core" projects tends to stay "low level"? I mean give more control, than give abstraction layer?
If so - what kind of contribution can I provide? Performance optimization, bug fixes and docs?

Does redux "core" projects tends to stay "low level"? I mean give more control, than give abstraction layer?

There's just one core project—Redux itself. Yes, it's lower level. It's opinionated where it really matters (e.g. plain object actions, pure reducers), but other than that, you're free to implement your own conventions.

If so - what kind of contribution can I provide? Performance optimization, bug fixes and docs?

I wouldn't expect to find bugs in Redux itself because it's very small and has been thoroughly tested (we barely change the code these days). Generally it's a good idea to watch out for open https://github.com/rackt/redux/issues and offer help there if you think you can spare some.

Where can I share info about my packages for redux? Is there a wiki page with a list of redux related components?

Have a look at awesome-redux and the Ecosystem page in the docs.

Isn't this what https://github.com/acdlite/redux-actions does anyway? I don't think it's the switch statement in itself but rather the semantics of it in js that makes it unappealing (and probably the need to import the constant too)

(and probably the need to import the constant too)

Constants are just strings. Those who don't like constants are free to use strings directly..

@dzannotti redux-actions is for action creators, not for reducers :wink:

using string directly leads to inconsistency way too easely

@dzannotti
And that's why we propose to use constants :wink:
@omnidan
handleAction() generates a reducer.

@omnidan no it's for both
``const reducer = handleActions({
INCREMENT: (state, action) => ({
counter: state.counter + action.payload
}),
DECREMENT: (state, action) => ({
counter: state.counter - action.payload
})
}, { counter: 0 });```

Ah I see :smile: Well, TIL.

@dzannotti
Just create middleware to hold and validate all actions in your app. It does the same end-result as constants (consistency, flags undefined, single actions reference (json file)) and eliminates the boilerplate around importing constants all over the place.

@SebastienDaniel yep that's what i'm doing currently actually :)

One side effects of using constants and importing them in reducers, is they document which actions the reducers use.
In simple apps, this may not matter much. But for complex apps, more than one, mostly unrelated reducers may need to change the state based on an action.


fixes for TestUtils

Codecov Report

Merging #50 (91f5f34) into main (54d8c9f) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   55.01%   54.89%   -0.12%
==========================================
  Files          38       38
  Lines        3741     3749       +8
==========================================
  Hits         2058     2058
- Misses       1683     1691       +8

Impacted Files
Coverage Δ

src/ReactionMethod.jl
81.81% <0.00%> (-5.28%)
:arrow_down:

src/utils/TestUtils.jl
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


AUTOSAR, Rust in Automotive, requirements, Q&A

Who: @cpetig
General idea:
Inspired by https://www.autosar.org/news-events/details/autosar-announces-new-working-group-for-programming-language-rust-in-automotive-software-context-202/
Invite the Rust expert driving that effort to discuss their needs, requirements, and collaboration model, and have a long Q&A session.
Which of the following categories apply: (You can pick more than one!)

[ ] Status update of broad interest
[ ] Experience report with insights to share
[X] Proposal for discussion

What Rust teams would be intereted in this and why?
Lang, libs, clippy: understanding requirements and potential standards being proposed.
What kind of feedback are you looking for from the audience (if any)? Are there specific questions you'd like to ask?

This news has been withdrawn, does anyone know why?

Thanks for raising the question, I will try to figure it out next week.
I can only confirm so far that the effort has gained good speed and to my knowledge hasn't been stopped.

And @joshtriplett , I still have plenty of interest in a CTCFT track on autosar and/or functional safety, but I really need additional time to gather more material before voicing any non-obvious requirements on Rust. Right now Florian can probably offhand provide more material than I could.

Happy to help there, maybe we want to have a co-presentation?

@skade I would love to do it this way, your support is most appreciated. Thanks a lot! Feel free to contact me any time - and/or I will contact you when the next CTCFT comes close.

@cpetig I definitely appreciate taking the time to gather material together, but also, for the purposes of the CTCFT I think it'd be appropriate to bring this while still fairly early. We'd love to hear what you're working on, and we'd love to ask lots of questions while you're still in the planning phase, rather than waiting until there's something further to show.
In particular, you don't have to know what requirements you'd want to place on Rust; I'd love to have a conversation about the general class of requirements you think you might potentially have, what goals they arise from, how those requirements might compare to standards for other languages, and so on.

Just a heads up, with April's theme of "learning", we've been looking at other talks for the upcoming CTCFT. This talk will be pushed back to a future month, but I'll be sure to reach out once we find a month whose theme it synergizes well with :100:

Did you already discuss the coding guidelines for Rust in automotive? Big companies in automotive industry love static code analysis reports with all kinds of intuitive metrics. For C and C++ we are mostly checking compliance for MISRA, AUTOSAR, CERT, CWE and few metrics like e.g. HIS. I guess for Rust to be widely accepted in the industry it has to come with similar guidelines or ensure a compliance with above ones.

@drag0niro you might be looking for this https://connection.sae.org/volunteeropportunities/volunteer-opportunity-details?VolunteerOpportunityKey=057a92a9-c6b8-4405-ae81-e293136a9284
or https://anssi-fr.github.io/rust-guide/ .
And of course the short answer is "Yes, we already started the discussion. Safe Rust should need few additional metrics to be considered compliant"

This news has been withdrawn, does anyone know why?

The news item is back, with slightly changed wording https://www.autosar.org/news-events/details/autosar-investigates-how-the-programming-language-rust-could-be-applied-in-adaptive-platform-context/

@cpetig
You can pay attention to this Rust coding specification, currently the Chinese version is more perfect, the English version is being improved.

The theme for the May CTCFT is Embedded Rust, and I think this topic would be close enough to that theme that it could fit into this CTCFT. The CTCFT will take place at 11:00 EDT on the 16th of May, and we're looking at a 15-minute timeslot for now.
@cpetig @skade does this sound good?

Yes, it does to me.

Great! When you have time, could I get a description and preferred title for the talk?

@AngelOnFira I can do that, see you then!

Just want to ping again about getting a description for the blog posts :)

Blog post is live! https://blog.rust-lang.org/inside-rust/2022/05/10/CTCFT-may.html

Hi. Will a recording of the meeting be made available?
https://rust-lang.github.io/ctcft/meetings/2022-05-16.html currently just states "link posted after call". Thanks.

https://www.youtube.com/watch?v=MfG7OvfVYQY


[To Main] Fix for issue of null appearing in public URLs

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-625
Description of changes:

Removed language from URLs other than engagement/survey links
Fixed the issue of null appearing in public URLs

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.02%. Comparing base (8baeb45) to head (a0952ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2529   +/-   ##
=======================================
  Coverage   76.01%   76.02%
=======================================
  Files         619      619
  Lines       22083    22077    -6
  Branches     1702     1701    -1
=======================================
- Hits        16786    16783    -3
+ Misses       5032     5029    -3
  Partials      265      265

Flag
Coverage Δ

metapi
87.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

met-api/src/met_api/config.py
97.33% <ø> (ø)

...web/src/components/engagement/view/SurveyBlock.tsx
81.08% <ø> (ø)

...ement/view/widgets/Subscribe/FormSignUpSection.tsx
68.75% <ø> (+4.04%)
:arrow_up:

met-web/src/components/landing/EngagementTile.tsx
76.19% <ø> (-0.38%)
:arrow_down:

...t-web/src/components/publicDashboard/Dashboard.tsx
71.66% <ø> (+1.17%)
:arrow_up:

met-web/src/routes/NotFound.tsx
80.00% <ø> (-1.25%)
:arrow_down:

met-web/src/services/userService/index.ts
23.17% <ø> (-0.64%)
:arrow_down:


Can't scroll to the last items on the right when slidesToScroll={3}

When I have a carousel with 9 slides and the following settings, I can't seem to scroll to the last 2 items on the right. I get the elastic effect and the highest currentSlide will go is 6. If I set slideIndex to 8 in the settings currentSlide is 8 and I can scroll to 7, then 6, but once I'm at 6 I can't go back to 7 or 8.
var settings = {
       slidesToShow: 3,
       slidesToScroll: 1,
       cellAlign: 'center',
       cellSpacing: 0,
       slideWidth: 1,
       easing: 'easeInOut',
       decorators: null,
       slideIndex: 2
};

If I change the slidesToShow to 1 I can get to all of the slides; currentSlide will go up to 8.
Here's the state when currentSlide is 0 and 6

Using v1.2.1

Can you try with master?

Still not working on master (2.0.1) and I ended up with a few other visual bugs

@kenwheeler, can you point me to a spot in the code where I could debug in my setup? I assume it has something to do with a bounds calculation of the last slide index or something along those lines.

+1 does not drag to last item

This seems to be a problem with any number other than 1, not just 3

Fixed this in pr #110 0 for anyone interested

Definitely related to slidesToShow > 1 and cellAlign = 'center' in my case.

@kenwheeler Is this likely to be merged soon? I'm encountering this issue.

fixed with PR #159

Not sure what happened with the merge for 2.0.3, but the problem persists. PR #159 had helped a bit, letting me at least scroll to (center) the 8th of 9 slides, but now I'm back to the problem of only being able to scroll to (center) the 7th of 9 slides. I tried scrollMode 'page' and 'reminder'.
Gotta stick with my fork for now: https://github.com/gkrinc/nuka-carousel

@gkrinc sorry for the inconvenience, we haven't bumped the version for npm yet. We're going to work out a few more bugs before we do that. As a result, npm is still downloading a release from August. However, the changes that were merged into master seem to be working fine for me locally when I replicate your settings and number of children. Let me know if this looks right for your use case--
return (

        <Carousel
          slidesToShow={3}
          slidesToScroll={1}
          cellAlign='center'
          scrollMode='page'
          ref="carousel"
          data={this.setCarouselData.bind(this, 'carousel')}
          slideIndex={this.state.slideIndex}
          afterSlide={newSlideIndex => this.setState({ slideIndex: newSlideIndex })}>

        </Carousel>

    )

with those settings I get this--

Regardless of whether we get this figured out for you, due to the npm versioning it may be best to stick with your fork for now, unless you want to hardcode the nuka-carousel master branch in your package.json (probably not recommended).

Thanks @mdaxtman. Got an idea when the next version will be released?

@gkrinc. No problem. I'm not sure, but soon. Sometime next week would be my guess.


"sbt.ResolveException: unresolved dependency:" with sbt 0.13

[error] (*:update) sbt.ResolveException: unresolved dependency: com.typesafe.play#routes-compiler_2.10;2.3.8: several problems occurred while resolving dependency: com.typesafe.play#routes-compiler_2.10;2.3.8 {compile=[default(compile)]}:
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error]
[error] unresolved dependency: com.typesafe.play#sbt-run-support_2.10;2.3.8: several problems occurred while resolving dependency: com.typesafe.play#sbt-run-support_2.10;2.3.8 {compile=[default(compile)]}:
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error]
[error] unresolved dependency: com.typesafe#jse_2.10;1.0.0: several problems occurred while resolving dependency: com.typesafe#jse_2.10;1.0.0 {compile=[default(compile)]}:
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error]
[error] unresolved dependency: com.typesafe#npm_2.10;1.0.0: several problems occurred while resolving dependency: com.typesafe#npm_2.10;1.0.0 {compile=[default(compile)]}:
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error]
[error] unresolved dependency: com.typesafe#webdriver_2.10;1.0.0: several problems occurred while resolving dependency: com.typesafe#webdriver_2.10;1.0.0 {compile=[default(compile)]}:
[error] 	java.text.ParseException: Content is not allowed in prolog.
[error] 	java.text.ParseException: Content is not allowed in prolog.
Project loading failed: (r)etry, (q)uit, (l)ast, or (i)gnore? The command '/bin/sh -c ./activator -Dsbt.jse.engineType=Node dist' returned a non-zero code: 1

I am keeping getting these errors with sbt 0.13.  And I have added
resolvers += "sbt Community Repository" at "https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases"
resolvers += "Typesafe Ivy Repository" at "https://repo.typesafe.com/typesafe/ivy-releases"
This one: https://repo.typesafe.com/typesafe/releases seems not working now.
I did not find these dependencies in the new repo redirected. Is that the reason I got these errors? Will we add these plugins?

Looks like those were in http://dl.bintray.com/typesafe/maven-releases/com/typesafe/play/routes-compiler_2.10/, but Lightbend is still in the process of moving?
See https://discuss.lightbend.com/t/typesaferepo-https-repo-typesafe-com-typesafe-releases-is-returning-a-404-error/8156/4 please.


Starred messages

Added a starred message mode, where the user can:

star any important message
filter only threads that have starred messages (3 dots menu in the drawer)
(experimental) attach starred messages

See #109 for a broader idea.

Implemented:


Updating Welsh translations to v9 prototype

Short description outlining key changes/additions

Updating translations for Welsh language on verify service to Prototype v9 content
Translations matched against Excel workbook (some common screen translations transferred from Registration service)
Tests updated to match new content
Excel spreadsheet updated to flag missing translations

JIRA Ticket Number
IDVA5-1253
Type of change

[ ] Bug fix
[x]  New feature
[ ]  Breaking change
[ ]  Infrastructure change

Pull request checklist

[ ]  I have added unit tests for new code that I have added
[x]  I have added/updated functional tests where appropriate
[ ]  The code follows our coding standards

An exhaustive list of peer review checks can be read here

CI: No security warnings found


Verbose flag causes error

No matter which command I run (although I haven't tried all of them), if I include the --verbose flag, I get the following error:
Traceback (most recent call last):
  File "/home/cauebs/.local/bin/poetry", line 11, in <module>
    sys.exit(main())
  File "/home/cauebs/.local/lib/python3.6/site-packages/poetry/console/__init__.py", line 5, in main
    return Application().run()
  File "/home/cauebs/.local/lib/python3.6/site-packages/poetry/console/application.py", line 81, in run
    return super(Application, self).run(i, o)
  File "/home/cauebs/.local/lib/python3.6/site-packages/poetry/_vendor/cleo/application.py", line 91, in run
    self.configure_io(input_, output_)
  File "/home/cauebs/.local/lib/python3.6/site-packages/poetry/console/application.py", line 101, in configure_io
    super(Application, self).configure_io(i, o)
  File "/home/cauebs/.local/lib/python3.6/site-packages/poetry/_vendor/cleo/application.py", line 511, in configure_io
    or input_.get_parameter_option('--verbose') == 3:
  File "/home/cauebs/.local/lib/python3.6/site-packages/poetry/_vendor/cleo/inputs/argv_input.py", line 202, in get_parameter_option
    return tokens.pop(0)
IndexError: pop from empty list

Oh, that was very naïve of me. It seems the problem is up on cleo. Do you want me to reopen this issue there?


Build directories are excluded from the checkstyleNohttp task

This change addresses a build deprecation warning causing caching to be disabled for the checkstyleNohttp. The deprecation warning is caused by the checkstyleNohttp task using the output files of other tasks, without creating an implicit or explicit dependency between them. As a result, Gradle disables caching in order to ensure correctness of the build.
With this change, the checkstyleNohttp task will ignore all build directories. This resolves the deprecation warnings and allows the task to be cached.

Thanks @erichaagdev! This is merged into 1.1.x (and merged forward) as f6b07f5649fe5cec0507d0448733b389939a0960, so we can attempt to upgrade our OSS supported 1.x branches to Gradle 8.


Safari display problem

Hi.
I'm facing a strange behavior.
I made a simple page in vue.js with your calendar component inside.
I've put inside 3 events by code (as default array).
If I open the page with Chrome I can see all 3 events:

From Safari, same page, but only 1 event is displayed:

Safari: v14.0 (156<IP_ADDRESS>.9, 15610)
"vue-cal": "^3.7.0"
My code:
<VueCal
          today-button
          :time-from="0 * 60"
          :disable-views="['years', 'year']"
          active-view="week"
          events-on-month-view="short"
          :events="events"
          class="vuecal--blue-theme"
          locale="it"
          :no-event="false"
        >
          <template v-slot:title="{ title, view }">
            Years

            {{ view.startDate.format('YYYY') }}
            {{ view.startDate.format('MMMM YYYY') }}
            w{{ view.startDate.getWeek() }} ({{ view.startDate.format('MMMM YYYY') }})
            {{ view.startDate.format('dddd D MMMM (YYYY)') }}
          </template>
        </VueCal>

events: [
        {
          start: '2020-10-15 8:00',
          end: '2020-10-15 16:00',
          title: 'Turno',
          icon: '', // Custom attribute.
          content: '',
          contentFull: '', // Custom attribute.
          class: 'workshift'
        },
        {
          start: '2020-10-16 16:00',
          end: '2020-10-16 24:00',
          title: 'Turno',
          icon: '', // Custom attribute.
          content: '',
          contentFull: '', // Custom attribute.
          class: 'workshift'
        },
        {
          start: '2020-10-17 16:00',
          end: '2020-10-17 24:00',
          title: 'Turno',
          icon: '', // Custom attribute.
          content: '',
          contentFull: '', // Custom attribute.
          class: 'workshift'
        }
      ]

What am I missing?
Thank you.

By making some further tests, I discovered that if I use this.$refs.vuecal.createEvent in the code instead of using static events array, on Chrome I keep seeing all events, on Safari none of the events.

Hi @Nevyn75,
Mmm good to know. thanks for reporting, I'll have a closer look soon.
I know Safari handles the date formatting differently, it needs a T in 2020-10-17 24:00 like '2020-10-17T24:00' but I have done that internally, maybe not for the particular case of end at 24.
For now, don't worry about using 00:00 the next day, Vue Cal will convert it to 23:59:59 previous day.
If you prefer you can also use JS dates for start and end (you can make it end at 23:59:59 or 00:00 next day), that should work on all the systems.

Hi @Nevyn75,
Sorry for the delay, after checking this it was indeed a bug when setting the end of an event to '24:00'. As Safari converts this to an invalid date.
This is now fixed in version 3.8.4.
Thanks for reporting!


sql_exporter is losing metrics if compute is very busy

Steps to reproduce
run ingest benchmark
doc
Expected result
We see metrics collected by sql_exporter for the complete run
Actual result
we are losing metrics - most likely because sql_exporter is exceeding its scrape_timout
we observe this especially when there is large amount of backpressure from PS to compute
Environment
staging
Logs, links
https://neonprod.grafana.net/d/de3mupf4g68e8e/perf-test3a-ingest-benchmark?orgId=1&from[…]ge_tenant_endpoint_id=ep-misty-river-w2vdg495&viewPanel=19
first reported here
another observation of this - probably related
https://neondb.slack.com/archives/C04DGM6SMTM/p1731526874214679

Previous thread re this problem https://neondb.slack.com/archives/C04DGM6SMTM/p1731526874214679
Ultimately, on each scrape sql_exporter does all the SQL specified in the metrics config. So if compute is loaded, then SQL becomes slower and we see these gaps.
So what are the options we have?

Try to identify the most heavy queries and optimize them
Untie collection and reporting flows (there are tools that do that, e.g. Telegraf, iiuc). In this case, collection will be super fast, scrapes can have much longer timeouts, but instead of gaps we may see stale metrics (up to configured interval). See my comment about Telegraf (not 100% I understand it correctly), @mickael-carl was against this approach
Switch as many metrics from the collection via SQL to maintaining counters/histograms online as possible, and report them from prometheus endpoint in our extension, for example. This may be also combined with 1. I'm not sure that this path is totally realistic, though. There is some Postgres statistics maintained in the catalog, or inside Postgres shared memory structures, so we would need a lot of core patching, and it's still not clear that it will work well. Like the database size, for example. I think we need to discuss that, maybe there are some low-hanging fruits

Moved to backlog because we don't have any good ideas how to fox it except exploring another tool like Telegraf
@tristan957 suggests that we can bump the sql_exporter version

Thread about timeout issues, looks like we currently scrape every 10s, so we cannot bump the timeout significantly

Another piece of info from Tristan, sql_exporter seems to have its own metrics

Only metrics defined by collectors are exported on the /metrics endpoint. SQL Exporter process metrics are exported at /sql_exporter_metrics.


[FEATURE]: daterange support for postgresql

Describe what you want
Support for daterange doesn't seem to be available as of now, unless it is just not documented yet ?
https://www.postgresql.org/docs/current/rangetypes.html

Closing in favor of #2700.


How to send ServiceMethod calls from client?

I've been looking for a solution to gather the last played games of a user. I took a look at a steam nethook dump and found a outgoing message "ServiceMethodCallFromClient" with the target_job_name "Player.ClienGetLastPlayedTimes#1", but could not find a protobuf for it?

How can I send such service method calls?

Is this not it? https://github.com/SteamRE/SteamKit/blob/c3f261d6c0a1543f3db7117ee8ab1bc6001a042f/Resources/Protobufs/steamclient/steammessages_player.steamclient.proto#L162
You should be able to construct a UnifiedMessages instance with new Steam.SteamUnifiedMessages(steamClient, 'Player'); and then call send on it like this:
player.send('ClientGetLastPlayedTimes', { min_last_played: whatever }, (result, resp) => {
  // handle result and resp as needed
});

I didn't try it, let me know if it works.

Ah, cool, this works, thanks 😄. I didn't know that I can create new instances of unified messages.


css page-break-inside

css page-break-inside

This issue was imported from Google Moderator
Moderator votes: +4
Issue added by Yar1 on 2013-07-15
To vote this issue up or down, simply include +1 or -1 in your comment.

Duplicate of #982 so adding half the votes there


Workaround to support Annotated HM3D semantic-as-RGB observations

Do not merge. I'm documenting this hm3d_semantic_as_rgb branch.
This branch is a temporary workaround to support Annotated HM3D in Habitat. This branch makes some C++ and python changes to force semantic observations to render as (unfiltered) RGB images.
Two options to test this:

build/utils/viewer/viewer path/to/hm3d/hm3d-minival-habitat/00800-TEEsavR23oF/TEEsavR23oF.basis.glb --dataset path/to/hm3d/hm3d_annotated_basis.scene_dataset_config.json --enable-physics --disable-navmesh

After the scene loads, press 7 to toggle between RGB, depth, and semantic-as-RGB. Use arrow keys to move around.

python examples/tutorials/semantic_hm3d_tutorial.py --hm3d-data-path="path/to/hm3d"

Look for output png files.

For a semantic-as-RGB output image, the pixels should be mapped to semantic categories in python using e.g. 00800-TEEsavR23oF/TEEsavR23oF.semantic.txt. This python code isn't implemented yet! Consider using semantic_hm3d_tutorial.py as a starting point to implement this.
This branch also checks that your dataset properly selects an HM3D semantic GLB as the stage semantic asset, e.g. TEEsavR23oF.semantic.glb. As long as you're using path/to/hm3d_annotated_basis.scene_dataset_config.json and you've downloaded semantic GLBs alongside your base HM3D data, this should all just work.

This PR is obviated by this PR which has been merged into main.


Audio: Native audio support for Android

This includes a new core provider that uses native MediaPlayer
on Android. It was used before when we were using Pygame,
but the support got lost during rewriting of P4A.
Unlike SDL2 native provider, this one support natively AAC (mp4/aac/m4a)

I am having issues with it not honoring the on_stop event. With binded buttons issuing a sound.stop() or when song finishes playing(the important one) this callback is not being triggered

I am having issues with it not honoring the on_stop event. With binded buttons issuing a sound.stop() or when song finishes playing(the important one) this callback is not being triggered


move e2e test invocation script to scripts

The e2e test code directory should only contain golang code so moving
this bash script to the scripts directory. Moving ahead we will be
adding tests for kedge build, so that will also reside in the same e2e
test directory.

@kadel sure thanks :-)

Yes, LGTM.


Auto rerun test from test runner

Related: https://github.com/flutter/flutter/issues/84818
Instead of rerun a whole test from infra side, it would save resources to rerun from the test runner by running only the test part. This way no need to wait for bot schedule, env. setup, etc.
This will need infra recipe change to take care of flakiness; test runner logic change to rerun; cocoon side change to consider flakiness (before: flakiness means multiple runs contains both failure and success; now: a single success run but with flaky flag generated from test runner logic).

[x] Recipe support to parse flaky message from stdout
[x] Add rerun in test runner for devicelab tasks
[x] Add new property TestRunFlaky in cocoon Task entity, which will be used to reflect flaky box in dashboard
[ ] Test runner accepts a new arg about TestFlaky updates
[x] Update cocoon API to support TestFlaky updates
[ ] Update TestRunFlaky flaky when task finishes from recipe side
[ ] Update cocoon to reflect flake on dashboard when TestFlaky is true
[ ] Update dashboards/scripts to include flake from test runner

windows flaky step fails by not recognizing command echo: https://ci.chromium.org/ui/p/flutter/builders/prod/Windows module_custom_host_app_name_test/3382/overview
Fix: https://flutter-review.googlesource.com/c/recipes/+/15700


blender ABC publish and load

We need to be able to publish and load Alembics to blender
[PYPE-614] created by admin

resolved in 3.0


Show exception message on flexible staging

fixes #800
Since we cannot control the structure of the project and what may be causing this exception, printing the exception message to the console will at least help the user debug the issue. This will still throw and IDE exception, but will also show the following on the deployment console:

Could we validate the existence of the files specified in the run config at
launch?
On Mon, Aug 1, 2016 at 10:56 AM, Etan Shaul<EMAIL_ADDRESS>wrote:

fixes #800
https://github.com/GoogleCloudPlatform/gcloud-intellij/issues/800
Since we cannot control the structure of the project and what may be
causing this exception, printing the exception message to the console will
at least help the user debug the issue. This will still throw and IDE
exception, but will also show the following on the deployment console:
[image: image]
https://cloud.githubusercontent.com/assets/1735744/17298101/96f7bf1e-57d6-11e6-86a8-8b8fb5e802f6.png
You can view, comment on, or merge this pull request online at:
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801
Commit Summary

Show exception message on flexible staging

File Changes

M
google-cloud-tools-plugin/src/com/google/cloud/tools/intellij/appengine/cloud/AppEngineFlexibleStage.java
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801/files#diff-0
(1)

Patch Links:

https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801.patch
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHf5HSkp1PG7X-tCs_aws8yUeElHc1j1ks5qbgkpgaJpZM4JZq61
.

If it throws and IDE error, then this will be reportable by the users as
bug, right? Would it work without making it an IDE error?
On Tue, Aug 2, 2016 at 9:00 AM Patrick Flynn<EMAIL_ADDRESS>wrote:

Could we validate the existence of the files specified in the run config at
launch?
On Mon, Aug 1, 2016 at 10:56 AM, Etan Shaul<EMAIL_ADDRESS>wrote:

fixes #800
https://github.com/GoogleCloudPlatform/gcloud-intellij/issues/800
Since we cannot control the structure of the project and what may be
causing this exception, printing the exception message to the console
will
at least help the user debug the issue. This will still throw and IDE
exception, but will also show the following on the deployment console:
[image: image]
<
https://cloud.githubusercontent.com/assets/1735744/17298101/96f7bf1e-57d6-11e6-86a8-8b8fb5e802f6.png

You can view, comment on, or merge this pull request online at:
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801
Commit Summary

Show exception message on flexible staging

File Changes

M

google-cloud-tools-plugin/src/com/google/cloud/tools/intellij/appengine/cloud/AppEngineFlexibleStage.java

<
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801/files#diff-0
(1)
Patch Links:

https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801.patch
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AHf5HSkp1PG7X-tCs_aws8yUeElHc1j1ks5qbgkpgaJpZM4JZq61
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-intellij/pull/801#issuecomment-236896414,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADOO_mQeoB7ENTh6YXv99nCuo0DI_ESyks5qbz9TgaJpZM4JZq61
.

@patflynn I updated the code to also check for the existence of the deployment source. If the source does not exist, then the deployment will not be started, the IDE will not throw an exception, and the user will be shown the following:

I separated out the error cases

@patflynn I updated the logic to not throw an exception when the deployable file cannot be located. I am still throwing one with the deployable is not of the expected type.

I will write some tests to cover this.

done

:+1:

woops. sorry. hit close by accident.


“The linter (or nuclide) package was not loaded” when using with atom-ide-ui

Newly-released atom-ide comes with the Diagnostics tab from Nuclide. However, the package tries to detect the presence of hardcoded package names:
https://github.com/mybuddymichael/linter-elm-make/blob/bee4a24a6c7c8247066e7bc415f2c31ee40022ae/lib/linter-elm-make.js#L28-L33
This causes this error message to appear:

Thanks @dtinth!


⚠ Chatwoot has degraded performance

In f2b1c68, Chatwoot (https://app.chatwoot.com) experienced degraded performance:

HTTP code: 200
Response time: 6828 ms

Resolved: Chatwoot performance has improved in 8d4c67c.


Template Updates: Entertainment

Context
Updates the Entertainment template according to the table in the ticket

Summary

Updates the animations on the elements so they use the editor animations
Creates new stickers for various elements (rating stars and the music note)

Relevant Technical Choices
NA

To-do
NA

User-facing changes
https://user-images.githubusercontent.com/41136059/114254019-ea7efb80-9961-11eb-8f18-51a85c4a53e6.mp4

Testing Instructions
View the Entertainment template and compare the changes to the ticket

QA

[x] This is a non-user-facing change and requires no QA

UAT

[x] UAT should use the same steps as above.

Reviews
Does this PR have a security-related impact?
NA

Does this PR change what data or activity we track or use?
NA

Does this PR have a legal-related impact?
NA

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6972

@googlebot I consent.

Small fixes:
General

Add or change to fade in 2000ms animation for all images on each page

Page 1

Change entering position to right for text in white
Change entering position to left for text in grey

Page 2

Remove animation of "artists" text

Page 3

Remove animation for the commas
Remove animation for the "artist" text
Change entering position to right for big text "pink" in the background

Page 4

Change entering position to right for "spotlight" text in white
Remove animation of "spotlight" text in grey

Page 6

Remove animation for text on top

Page 7

Remove animation of title

Page 8

Remove animation of title

Small fixes:
General

Add or change to fade in 2000ms animation for all images on each page

Page 1

Change entering position to right for text in white
Change entering position to left for text in grey

Page 2

Remove animation of "artists" text

Page 3

Remove animation for the commas
Remove animation for the "artist" text
Change entering position to right for big text "pink" in the background

Page 4

Change entering position to left for "spotlight" text in white
Remove animation of "spotlight" text in grey

Page 6

Remove animation for text on top

Page 7

Remove animation of title

Page 8

Remove animation of title


Add new device - Window Door Sensor

Add device support for Window Door Sensors:
      "ABB28CBC3651": {
        "interface": "TP",
        "deviceId": "B008",
        "displayName": "Sensor/switch actuator, 8/8gang, MDRC",
        "unresponsive": false,
        "unresponsiveCounter": 0,
        "defect": false,
        "channels": {
          "ch0002": {
            "floor": "02",
            "room": "05",
            "displayName": "B\u00fcro links ",
            "selectedIcon": "51",
            "functionID": "f",    FID_WINDOW_DOOR_SENSOR
            "inputs": {},
            "outputs": {
              "odp000c": {
                "pairingID": 53,    AL_WINDOW_DOOR
                "value": "0"
              }
            },
            "parameters": {
              "par0010": "2"    PID_BI_CONTACT_TYPE
            }
          },

see #52


Does shieldy have analytics?

I think that's one of the big features we want versus combot

Nope, it doesn't. Shieldy isn't a group management bot, it's an anti-spam captcha bot :)


[don't review/merge] Enabled only online volume expansion

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=2059593

Coverage decreased (-0.02%) to 86.109% when pulling 9166dbd229f6db1c1509ebd4a49f54d02054428d on expVol into 11716e6fd47f7d22e7acad4ef537ecd0eea3b44f on master.

/test pull-ibm-vpc-block-csi-driver-build


[Feature]: Use gunicorn + uvicorn + uvloop on agents-api, worker, integrations (all python services)

🔖 Feature description
We need to use multiple workers since we do have a fair bit of blocking code.
🎤 Why is this feature needed ?
No response
✌ How do you aim to achieve this?
No response
🔄 Additional Information
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

Are you willing to submit PR?
None

Added for agents-api, will add them to the other services too.


Add findsubdomains

This PR aims to fix https://github.com/subfinder/research/issues/22

$ go test -v -run=FindSubdomains -bench=FindSubdomains

=== RUN   TestFindSubdomainsDotCom
--- PASS: TestFindSubdomainsDotCom (1.48s)
=== RUN   TestFindSubdomainsDotComMultiThreaded
--- PASS: TestFindSubdomainsDotComMultiThreaded (17.15s)
=== RUN   ExampleFindSubdomainsDotCom
--- PASS: ExampleFindSubdomainsDotCom (2.84s)
=== RUN   ExampleFindSubdomainsDotComMultiThreaded
--- PASS: ExampleFindSubdomainsDotComMultiThreaded (15.80s)

goos: darwin
goarch: amd64

BenchmarkFindSubdomainsDotComSingleThreaded-8   	       1<PHONE_NUMBER> ns/op
BenchmarkFindSubdomainsDotComMultiThreaded-8    	       1<PHONE_NUMBER>8 ns/op

PASS
ok  	_/research/core/sources	58.287s


Added STT Diakonos Banyumas

@sttdiakonos First stage of verification passed, official domain is sttdiakonos.ac.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

Thank You for the first verification. Hope it will merged soon ;)

@sttdiakonos Thank you for your patience while waiting for a review and processing your request. Pull request merged.

Thank you @philipto and all of JetBrains teams. 🙇♂


Refactor Calendar component with react-calendar library

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Do not change the following line aside from replacing YOUR-ISSUE-HERE with the issue this PR fixes
fixes #327
Please provide enough information so that others can review your pull request:

Refactor Calendar.jsx component with using ract-calendar library
Remove all references of the FullCalendar from Calendar Component
Remove FullCalendar reference from package.json
Render AppCalendar component in the DiagnosticContainer.jsx component
Component connect to the redux and able to pass selected date to the redux action and use it for request to the backend.

Explain the details for making this change. What existing problem does the pull request solve?
Refactor Calendar component.
Test plan (required)
yarn test

Final Checklist

[x] Have you bumped the version in package.json?

Second decimal for major change, third decimal for minor change. This can go past 10 i.e. 1.0.9 !=> 1.1.0, 1.0.9 => 1.0.10
Read here for more info

[x] Have you added any new tests necessary?
[x] Is your PR rebased off the most current master?
[x] Have you squashed all commits, or if you will merge will you squash all commits?
[x] Did you use yarn, not npm?
[x] Did you use Material-UI wherever possible?
[ ] Did you format according to Prettier?

As Carter always says LGTM 😁

Looks great!


Dev/Staging/Prod - What do we do?

Since we're moving to a Database based setup in the next version I thought it'd be nice to discuss how we want to handle Dev/Staging/Prod environments.
V1 lives on Cloudflare Pages so not much to think about there.
For V2 we keep the actualte Kit part on Cloudflare but introduce a backend (PocketBase). This server is hosted on our own server running Coolify. I asked on the PocketBase repo how other folks handle this: https://github.com/pocketbase/pocketbase/discussions/4004
I'm thinking a monorepo loosely based on https://github.com/jonshipman/sveltekit-pb-boilerplate
Thoughts?

The ideal in my mind is previews that we can see and test against with each PR and then main gets deployed to production

Closing this since it's very old - we're going with Vercel to handle the frontend and Turso as the DB, working on setting up staging and prod environments. Dev can be done locally using SQLite via the Turso CLI.
Went with monorepo structure


Generic insert statement for Sharding and encrypt on optimize module

For #3061.

Invalid pr

Pull Request Test Coverage Report for Build 411

110 of 160 (68.75%)  changed or added relevant lines in 45 files are covered.
59 unchanged lines in 8 files lost coverage.
Overall coverage decreased (-0.3%) to 64.962%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/engine/EncryptWhereOptimizeEngine.java
0
1
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/statement/EncryptConditionOptimizedStatement.java
0
1
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/statement/EncryptTransparentOptimizedStatement.java
0
1
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/sharding/statement/ShardingTransparentOptimizedStatement.java
0
1
0.0%

sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/type/broadcast/TableBroadcastRoutingEngine.java
1
2
50.0%

sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/type/standard/StandardRoutingEngine.java
1
2
50.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingPreparedStatement.java
4
5
80.0%

sharding-jdbc/sharding-jdbc-core/src/main/java/org/apache/shardingsphere/shardingjdbc/jdbc/core/statement/ShardingStatement.java
3
4
75.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java
0
1
0.0%

sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/JDBCExecuteEngine.java
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/keygen/TimeService.java
1
0.0%

sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/type/complex/ComplexRoutingEngine.java
1
94.12%

sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/router/sharding/condition/engine/InsertClauseShardingConditionEngine.java
2
67.74%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/encrypt/statement/EncryptTransparentOptimizedStatement.java
4
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/sharding/statement/ShardingTransparentOptimizedStatement.java
4
0.0%

sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/api/segment/InsertValue.java
6
67.5%

sharding-core/sharding-core-route/src/main/java/org/apache/shardingsphere/core/route/type/broadcast/TableBroadcastRoutingEngine.java
12
51.85%

sharding-proxy/sharding-proxy-bootstrap/src/main/java/org/apache/shardingsphere/shardingproxy/Bootstrap.java
29
0.0%

Totals

Change from base Build 404:
-0.3%

Covered Lines:
9539

Relevant Lines:
14684

💛  - Coveralls


Any possible way to use gl.TEXTURE_3D with webgl2?

I'd like to port this using regl, since the functional nature of regl makes a good developing experience.
I've wrapped webgl2 using the technique in #561. And I'm wondering is there any way I can use texture 3d under this wrapper? Perhaps a custom binding of 3d texture to shader uniform is possible?
Currently, I have uniform mediump sampler3D tex; in my shader.

I started a fork in which I implement regl.texture3D. You can also use EXT_texture_norm16 extension with (for now only) r16 and r16_snorm texture formats.
It is a WIP, but it works for our needs.

use the WebGL2 wrapper described in #561
write your shaders with #version 300 es
add precision <precision> sampler3D;


Revert "Warn users when overriding methods (via let, def or define_method) in the same example group."

This reverts the lib and spec pieces of e072e5358b85a971010bc1a22d04eeca646321c8.
The warning is overzealous. After upgrading a project to RSpec HEAD, I
got spammed with tons of warnings of situations that weren't actually
problematic.  For example, it's common to define a let in a shared
context that provides a default value, and than to purposefully override
that in a host group where the shared context is included. We should'nt
warn in such a situation, but this did warn.
See #1903 for the original code this reverts.
/cc @fabn

LGTM per discussion on dev list.


Invalid signature in optimized resource URLs

We noticed that a new install of ngx_pagespeed (nginx 1.10.0 with ngx_pagespeed <IP_ADDRESS>-stable on CentOS7) started serving an image with an invalid signature after a few hours of low traffic. UrlSigningKey was configured from the start and that particular image was definitely served correctly for a few hours. We purged the cache (local file cache with default shm metadata cache), restarted nginx for good measure and the image was working again until the problem recurred a few hours later. Another cache purge and nginx restart fixed the signature on this image, but over night a different image started showing the exact same problem.
Log entries:

Invalid resource signature for https://www.example.com/assets/img/redacted/logo.png.pagespeed.ce.eiOUFVYmzJIGaPzlladh.png provided. Expected qnW5iVzCbz Received IGaPzlladh
Invalid resource signature for https://www.example.com/redacted/x3-pcs-redacted-product-name-69-0-2-12345.jpg.pagespeed.ic.GKxXl6W_kw-mm20F9cI9.jpg provided. Expected QgrusbOxZv Received -mm20F9cI9

I manually generated the HMAC-SHA1 signatures of the URLs to confirm that the "Expected" signature is correct. Both times I could find entries for an unrelated file matching the "Received" signature in the file cache (one jpeg and one css file), for example:

./rname/ce_R_JT-PIosmieVi9iwDb_/https,3A/,2Fwww.example.com/size/x3-pcs-redacted-product-name-69-0-2-12345.jpg.pagespeed.ic.NluRGUzKx8IGaPzlladh.jpg,40,40_,
[...]
./prop_page/https,3A/,2Fwww.example.com/assets/img/redacted/logo.png.pagespeed.ce.eiOUFVYmzJIGaPzlladh_n79Ig3zfO6,40Desktop,40beacon_cohort,

We've not been able to reliably reproduce the issue, since it has only affected two images out of a few thousand so far and seems to happen randomly. The only thing both images have in common is that they appear twice on some pages, once near the top and once near the bottom, but so do other images that are unaffected.

that's really weird. are the rewritten urls in different directories when accepted and rejected?
Do you have an example url in the logs for when the correct qnW5iVzCbz signature is there?

also, are the images not showing up on the page when you visit, or are you just seeing this in the logs?
is it possible that there are just clients requesting an old url that is no longer valid (changed signing key and users are requesting the old url for example.)

are the rewritten urls in different directories when accepted and rejected?
Always the same url and file (local fs via LoadFromFile), and always the same hash. The same file with different hash contains the correct signature. But I'm not sure if any conclusions can be drawn from that, since only 2 files were affected as of yet.

Do you have an example url in the logs for when the correct qnW5iVzCbz signature is there?
According to our logs, the correct signature was served for a few hours until the first occurrence of the invalid signature. From that moment, nearly all requests contained the invalid signature until we restarted nginx and the metadata cache was cleared.

also, are the images not showing up on the page when you visit, or are you just seeing this in the logs?
The url with the broken signature was served to all clients (including, but not only, our web designers who noticed it first) until the nginx restart fixed it. There is no intermediary proxy or caching layer that could have served stale data. The signing key was in place the first time nginx was started (this was a fresh install) and never changed.

I tried looking through the source to see if I can find out more, but it'd take me quite a while to become familiar with how requests are processed. If I had to take a wild guess, I'd say that somehow the wrong signature (most likely one from an entirely different file that gets processed within the same request) is stored in the (shm?) cache for a particular cache key (url) and hash combination and reused from that moment forward.

Good news: I was able to reliably reproduce the issue. Bad news: The whole thing gets even weirder.
This shell script starts requesting the same (static) page over and over and after a while, the error_log will contain a line like this:

2016/05/27 18:43:31 [info] 19219#19233: [ngx_pagespeed <IP_ADDRESS>-0] Invalid resource signature for http://www.example.com/assets/img/redacted/xtouch-icon.png.pagespeed.ic.Mnuro-NRey-DLqEIhm9e.png provided. Expected fDunWXYmQr Received -DLqEIhm9e

Note that all requests were made using curl and all resources were loaded from the local file system, so no HTTP request was ever made to xtouch-icon.png.pagespeed.ic.Mnuro-NRey-DLqEIhm9e.png.
From this point forward, the url will always be served with the invalid signature until the cache is purged. Again, there is always some other resource in the file cache that contains the invalid signature, which is valid for that file.
In rare cases the invalid signature the log entry complained about will actually become valid (i.e. only the url in the log entry works), and the expected signature will result in a 404.
I can't really share my full test case with you, but let me know if you want me to try something. I also managed to log an occurrence with a debug build if you're interested.

thanks for the info. additional logging would be helpful.
if you'd like to send it off-list you can send  it to<EMAIL_ADDRESS>I'll try to see if I can reproduce this locally.
Can you share the contents of the static page too, just so that i can have an easier time matching your setup?

if you'd like to send it off-list you can send it to<EMAIL_ADDRESS>I'll try to see if I can reproduce this locally.

Thanks, just sent it.

Can you share the contents of the static page too, just so that i can have an easier time matching your setup?

That won't be possible atm but I'll try to reduce the static page to a minimal test case that I can share.


Hard to understand supported Azure Channel

In the section of FAQ, supported channels for Spot VMs are shown the table.
However, the understanding is difficult. (For example, which offer plan is included in "Benefit"?, how about 'Azure in Open' offer?)
https://azure.microsoft.com/en-us/support/legal/offer-details/
I think it should be written supported offers only and should be written that "other offers are not available."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2bcebc93-3efa-b89a-e348-cb6605dbac9e
Version Independent ID: dfae3da1-d422-f1ff-44da-2a2a6e553f9a
Content: Use Azure Spot VMs - Azure Windows Virtual Machines
Content Source: articles/virtual-machines/windows/spot-vms.md
Service: virtual-machines-windows
GitHub Login: @cynthn
Microsoft Alias: cynthn

As the table shows, only the 3 subscription types are possible. However we include a few other most commonly used subscription types to ensure those customers can easily see the information.
All our subscription types are found here: https://azure.microsoft.com/en-us/support/legal/offer-details/
@JagVeerappan is the PM for sport. However he is out of office for a while. For now I would say we leave this as is. However I will bring this up when he is back in office.
#please-close


[2012-12-16] Better shorthands for DataObject permission checks

created by: @chillu (ischommer)
created at: 2012-12-16
original ticket: http://open.silverstripe.org/ticket/8126

Reduce boilerplate code required to implement common checks,
as described by Sam here: https://groups.google.com/d/msg/silverstripe-dev/4yZagm_x3Y4/5otM4-d5r_kJ
Followup from  http://open.silverstripe.org/ticket/8121
Previous attempts at fixing in https://github.com/silverstripe/sapphire/pull/1040 and https://github.com/silverstripe/sapphire/pull/1042

Stale enhancement.


Enable reading of csv.gz files

Initially faciltiate this for Linux

I have now implemented a solution in a new development branch.
It turned out that fread from the read.table package can handle gz-files if R.utils is installed. So, I have added R.utils to the dependency list.
However, we also use read.csv a couple of times. For now I have added a small new function 'checkgz' that helps read.csv to in handling gz-files.
Another solution would be to replace all read.csv calls by fread calls, but then there is a risk for functional consistency, which would have to be checked.

Outstanding action points:

[ ] Add unit test
[ ] Update documentation
[ ] Explore whether this can easily be extend to other types of zip-formats

The base read.csv already can read csv.gz files.  Also, readr::read_csv can do that quicker.

This is now addressed in the branch: issue289_unzipping. I will make a pull request in the upcoming weeks.


findClosestPoint returns case class instead of Tuple

One new case class. The rest are mechanical changes

+1 :-)

:+1:


Can't find an enum or list of all the statid's?

I know when dealing with stats like kills, assists, etc, you just put lbKills or lb(anything), but I only learnt that from a comment left here. Where can I find a list of statid's for the API? ps. I'm not sure this is the right place to ask questions, let me know if not so I can go elsewhere.

They are in the manifest under HistoricalStatDefinition


Get location never returns on some Android devices

App blocks for ever on the call to Location.getCurrentPositionAsync() in src/sagas/services.ts
This seems to me a know problem, may just need to update expo, see this issue. Except that we did that pretty recently, so I'm not sure if that is the solution.

Some notes on this issue: https://docs.google.com/document/d/1emsj507egcqQrHfAA-i4lf_f0Vk_tf7zZ1jwkaFZBGA/edit

Further AC:

We should have two location errors: one for no location permissions and one for timeouts


Auto-close manage menu after delete

Description
The manage request doesn’t close up after deleting the media.
Desired Behavior
Would it be possible to automatically close the manage request menu after deleting it from arr*.

Additional Context
No response
Code of Conduct

[X] I agree to follow Jellyseerr's Code of Conduct

:tada: This issue has been resolved in version 2.0.0 :tada:
The release is available on:

v2.0.0
GitHub release

Your semantic-release bot :package::rocket:


Frame buffer issue on starting X with debian sid on crouton

[ 17466.574] (II) Loading /usr/lib/xorg/modules/libshadow.so
[ 17466.574] (II) Module shadow: vendor="X.Org Foundation"
[ 17466.574]    compiled for 1.18.3, module version = 1.1.0
[ 17466.574]    ABI class: X.Org ANSI C Emulation, version 0.4
[ 17466.574] (II) UnloadModule: "modesetting"
[ 17466.574] (II) Unloading modesetting
[ 17466.574] (==) Depth 24 pixmap format is 32 bpp
[ 17466.588] (==) FBDEV(0): Backing store enabled
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy
[ 17466.589] (EE) FBDEV(0): FBIOPUTCMAP: Device or resource busy

I am trying to run debian sid on Asus Flip. Was able to install without any problems. But when I try to start kde or xfce etc., I see the above error with ref to frame buffers. The process tries to start X for sometimes with the above error and then gives up. How can I resolve this issue? I tried some of the other releases but most of them fail to even properly install breaking on something here and there. Only debian sid went well, though with the above problem at the end. I am able to enter-chroot without any problem. The problem is in regards to start X windows (some windows manager) properly. Any pointers would be helpful.

Please show us the output of: sudo edit-chroot -all

Sorry, I reverted chrome OS to the stable one and was able to install xenial and everything works fine on that. I will put the output if I get a chance to again try debian sid and get the same error as above.

@aivijay - Great! Glad you got something working.
I guess if you get a chance to try it again soon you could leave this issue open, otherwise, you can close it for now and open it later if you run into problems again.


fix(core/types): remove_all not work under object-store backend

Fix #4654
The root cause is described in https://github.com/apache/opendal/issues/4654#issuecomment-2140685110
The fix covered several cases in object-store like backend:

Both prefix and objects exist, when remove_all("a"), we should not only delete the object "a", e.g.:

a
a/b
a/c

Normal case, when remove_all("a"), we should remove all objects under the prefix.

a/b
a/c

Thanks!


fail clearly on too-new JDK

Gradle will give a very confusing error, let's make it absolutely clear.

Yep. I wonder if we could do it in one script (the downloader?) to avoid running java so many times but overall I think it's better than before. :)
This also reminds me that the various java versions (minimum required for Lucene, minimum required for gradle) are scattered around in oh-so-many places. I wonder how we could somehow centralize this information. I don't have any clean ideas though.

Yep. I wonder if we could do it in one script (the downloader?) to avoid running java so many times but overall I think it's better than before. :)

I agree with this (as someone who disables the daemon and runs the commands every time). The only reason I specified it as a different command was due to the fact that if the downloader fails, the error is "trapped" and an additional version-related error (that you need at least java 11) is printed... IMO that's a bit confusing, but I get it.

This also reminds me that the various java versions (minimum required for Lucene, minimum required for gradle) are scattered around in oh-so-many places. I wonder how we could somehow centralize this information. I don't have any clean ideas though.

Maybe it could be in a .properties file? Not gradle, not groovy, a real actual .properties file that we can read with java.io.Properties too?

Maybe it could be in a .properties file? Not gradle, not groovy, a real actual .properties file that we can read with java.io.Properties too?

I was thinking about something like this too, it's convenient. There is a number of those places referencing version numbers - I can't even remember them all. A commit list referencing LUCENE-10283 is a good place to start... :)

I agree with this (as someone who disables the daemon and runs the commands every time). The only reason I specified it as a different command was due to the fact that if the downloader fails, the error is "trapped" and an additional version-related error (that you need at least java 11) is printed... IMO that's a bit confusing, but I get it.

we can clean up exit status so that wrapperdownloader uses something other than 1 when it fails. that's also the same status old java uses when it doesn't recognize --source parameter. then we can move the version check into wrapperdownloader and only say "please make sure you're using at least java 11" when it is relevant (java itself fails).  and it is safe to only apply it to exit status 1 because it is only relevant to already-released older jvms. I will look into this.

OK, @dweiss can you take another look when you get a chance?
java 8:
$ ./gradlew check
Unrecognized option: --source
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
ERROR: Something went wrong. Make sure you're using Java 11 or later.

java 18:
$ ./gradlew check
ERROR: java version must not be newer than 17 (unsupported by gradle), your version: 18

But there's still more to do. if you use java 11 it will still fail, just differently, based on our gradle actual gradle logic.
Let's say the user has java 9. It isn't good to tell a user to upgrade to java 11 or later (say they pick java 11), they download it, install it, only it then fails and says you need 17 or later. then the user download and install's the latest (say 18), only for it to fail yet one more time and tell them they need exactly 17... this is like leading them through a maze. So I want to clean up the messaging some more still...
java 11:
$ ./gradlew check
To honour the JVM settings for this build a single-use Daemon process will be forked. See https://docs.gradle.org/7.2/userguide/gradle_daemon.html#sec:disabling_the_daemon.
Daemon will be stopped at the end of the build

FAILURE: Build failed with an exception.

* Where:
Script '/home/rmuir/workspace/lucene/gradle/validation/check-environment.gradle' line: 36

* What went wrong:
A problem occurred evaluating script.
> At least Java 17 is required, you are running Java 11 [OpenJDK 64-Bit Server VM 11.0.13+8]

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s

OK, i cleaned up the messaging here to emit better messages so we don't lead users through a maze of downloading and retrying. I didn't touch the gradle checks. And yeah, it would be great to consolidate to a properties file (min and max versions?) so there is less places to change when we bump it, we could read the properties from this checker at least.
java 18
$ ./gradlew check
ERROR: java version be exactly 17, your version: 18

java 9

$ ./gradlew check
Unrecognized option: --source
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
ERROR: Something went wrong. Make sure you're using Java 17.

java 11:

$ ./gradlew check
ERROR: java version be exactly 17, your version: 11

Maybe it could be in a .properties file? Not gradle, not groovy, a real actual .properties file that we can read with java.io.Properties too?

+1 to a single source of source/target Java version(s). A simple key-value format may be easily used from the outside world of java/gradle - github actions scripts or the smoke tester, and so on.

+1 to a single source of source/target Java version(s). A simple key-value format may be easily used from the outside world of java/gradle - github actions scripts or the smoke tester, and so on.

Yes, if everyone can really restrain themselves to keep such a thing actually a simple key-value (no groovy, no nonsense), then we can read it from java/groovy with java.io.Properties and it could be read from this bash script with source.

Windows will be a problem, as it always is, argh.

Windows will be a problem, as it always is, argh.

why is windows a problem? this PR works perfectly fine on windows. I didnt touch the .bat file because, unlike the .sh file, it has no special error messaging. so there's nothing to be done with it.

I'll take a look if I can modify the windows scripts the same way - it should be doable.

There's no version numbers in the .bat script.

There's the emitted message there - I've just pushed a commit to your branch that does the same thing as the bash does. I think it's fine. We can probably add a test to check whether those scripts, even if hardcoded, are consistent with the property file (as the worst workaround).

i'm fine with starting the properties file here, but the problem is not exactly new. really fixing all the stuff like smoketester, eclipse linter config, etc etc is gonna be some amount of work. Even the gradle is some work (there are version numbers everywhere).

Yeah - I think we should do it as a separate issue. It'll be clearer.

OK let's merge this for now and investigate the properties refactoring as a separate change.


Add a button to open the literature file

It would be great to have a button/link to the source file (literature.bib) on the top of the HTML page.

Solved with the new Single Export HTML in 88a06ef

The link does not work for me. There are wrong symbols in the path and Firefox does not ask Windows for the default editor. Any ideas how to fix that?

Tried mimetype text/plain and application/x-BibTeX, but both are not opening correct in chrome (instead it downloads the file).
Another way would be to display the complete file as a popup. it could also be displayed in a separate file (but that would break the single file concept)

Is all not helpful I guess. Then just remove the download link instead.


refactor!: starknet.py 0.4 + Cairo 0.9.1 upgrades

What I did
starknet.py 0.4 + Cairo 0.9.1 upgrades.
Fixes #68.
How I did it
How to verify it
Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

For now, most tests are failing on:
Client failed: No contract found for identifier: No contract found with following identifier {}

There are now 2 kinds of failures.

Get contract type: python -m pytest -k test_get_contract_type_after_deploy
The missing TX receipt results: python -m pytest -s -x -k test_external_call_mixed_outputs_from_account

9 failures. :drum:

An "interesting" failure related to declate TX:
python -m pytest -s -k test_declare_then_deploy

We can find in the devnet logs:
[2022-07-25 19:00:55,032] ERROR in app: Exception on /feeder_gateway/get_block_traces [GET]
Traceback (most recent call last):
  File "/.../flask/app.py", line 2073, in wsgi_app
    response = self.full_dispatch_request()
  File "/.../flask/app.py", line 1518, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/.../flask_cors/extension.py", line 165, in wrapped_function
    return cors_after_request(app.make_response(f(*args, **kwargs)))
  File "/.../flask/app.py", line 1516, in full_dispatch_request
    rv = self.dispatch_request()
  File "/.../flask/app.py", line 1502, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "/.../starknet_devnet/blueprints/feeder_gateway.py", line 93, in get_block_traces
    trace = state.starknet_wrapper.transactions.get_transaction_trace(tx_hash)
  File "/.../starknet_devnet/transactions.py", line 201, in get_transaction_trace
    return transaction.get_trace()
  File "/.../starknet_devnet/transactions.py", line 135, in get_trace
    else FunctionInvocation.from_internal_version(self.execution_info.call_info)
  File "/.../starkware/starknet/services/api/feeder_gateway/response_objects.py", line 610, in from_internal_version
    caller_address=call_info.caller_address,
AttributeError: 'DummyCallInfo' object has no attribute 'caller_address'

To keep track of other issues:

https://github.com/Shard-Labs/starknet-devnet/issues/195


Naming possible issue

@ThomasArdal take a look at this issue:
https://github.com/feimosi/baguetteBox.js/issues/200
They have .js in their library name which is making problems for people.

That's a good argument for renaming the package to elmah.io.javascript, actually. I think we'll do that in the next version. Thanks!


Peer to Peer Review - Morning Session Part 1

Great Job Amel. The deployment page looks very good with all the required functionalities. However, it would be nice to see a live demo link in the Readme File. And also, the methods if included in the book class, it would be more reasonable.
Apart from that, there is nothing else to comment. Great Job. Keep up the good work. Good luck!!!

Good job so far! Here are some small suggestions to consider:

The styling is original, but the visibility of the titles and especially the highlighted menu items can be improved.
The spacing for the date could be expanded to improve readability
The date is currently hardcoded. Consider implementing the Luxon library recommended in the project.


info when load model

hi,when I load the model for train:
model = AutoModelForCausalLM.from_pretrained(
model_name_or_path,
torch_dtype=torch.bfloat16,
# device_map="auto",
trust_remote_code=True,
)
info like this:(is it right?)
Some weights of LlamaForCausalLM were not initialized from the model checkpoint at /root/bert_path/TinyLlama-1.1B-intermediate-step-240k-503b/TinyLlama-1.1B-intermediate-step-240k-503b and are newly initialized: ['model.layers.18.self_attn.rotary_emb.inv_freq', 'model.layers.21.self_attn.rotary_emb.inv_freq', 'model.layers.19.self_attn.rotary_emb.inv_freq', 'model.layers.9.self_attn.rotary_emb.inv_freq', 'model.layers.10.self_attn.rotary_emb.inv_freq', 'model.layers.20.self_attn.rotary_emb.inv_freq', 'model.layers.0.self_attn.rotary_emb.inv_freq', 'model.layers.11.self_attn.rotary_emb.inv_freq', 'model.layers.7.self_attn.rotary_emb.inv_freq', 'model.layers.15.self_attn.rotary_emb.inv_freq', 'model.layers.4.self_attn.rotary_emb.inv_freq', 'model.layers.16.self_attn.rotary_emb.inv_freq', 'model.layers.5.self_attn.rotary_emb.inv_freq', 'model.layers.1.self_attn.rotary_emb.inv_freq', 'model.layers.14.self_attn.rotary_emb.inv_freq', 'model.layers.3.self_attn.rotary_emb.inv_freq', 'model.layers.6.self_attn.rotary_emb.inv_freq', 'model.layers.13.self_attn.rotary_emb.inv_freq', 'model.layers.2.self_attn.rotary_emb.inv_freq', 'model.layers.12.self_attn.rotary_emb.inv_freq', 'model.layers.8.self_attn.rotary_emb.inv_freq', 'model.layers.17.self_attn.rotary_emb.inv_freq']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.

AutoModelForCausalLM is a huggingface based library, and from what a simple google search tells me, this is super common
This is just a warning, as quoted by the repo

This is expected, and tells you that you won't have good performance with your model before you fine-tune it.

Does finetuning give you any errors?

Also
from transformers import logging

logging.set_verbosity_warning()

@shyoulala  You can safely ignore this warning, including "You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference".


Keychain capability enabling instruction; #trivial

This was missed as a required step to integrate the SDK properly. The description why the partner has to enable it is written in the README.

          1 Warning

  :warning:
  README.md modified

  Generated by :no_entry_sign: danger

👍

@wladyslaws please use approve changes feature when you agree to merge it 😄

approve changes 👍

@wladyslaws Files changed -> Review changes -> Approve


Create breaks botania mod's terrasteel armor will effects

Description
The effects are only supposed to activate on a critical hit, but with create installed they always activate.
Game Log
Logger
Debug Information
No response

duplicate issue


Need to disguise UDP packets.

The current UDP packet features are too obvious and need to be disguised.

In order to test the filtering ability of the server for deformed data packets.


Refactoring ex2 tobi

Improve exercises 3 and 4
solution_2.pdf
exercise_2.pdf
reference #425

Can all boxes in #423 be checked? @tpielok please do so if this is the case and ping me here again to review. Thanks!

I did check all except ex2 since plotLearnerPrediction() has to be implemented in mlr3 first.
@HeidiSeibold

Any updates on plotLearnerPrediction()? Will this be available on time?


[Edit docs] Update "latest" releases to 3.1

This happens in different places.
For testnet, this also requires changes to the configuration by adding a new epoch:
[[burnchain.epochs]]
epoch_name = “3.1”
start_height = 77_770

This should be all updated on both signer guides and in the appropriate config files


Add iosScrollToTop in cobalt.conf

Enable developer to activate the scroll to top gesture (a simple tap in the status bar) on the controller he wants.
Handle iosScrollToTop:true/false in cobalt.conf on iOS. Default should be false.
This would enable scroll to top on the Cobalt webview only. We can not enable this if the developper has other scrolling native components in his view

[x] Handle on iOS
[x] Add a sample of this in Catalog App
[x] Write a quick blog post

I think we should change default to true. what do you think ?

You're a weathercock :P You told me that Cobalt should not "surpass" the native by enabling the WebView to respond to the scrollsToTop and now, you do not want?

as seen together in the doc, the default value should be true


Feature request: Sliding Window Attention

It would be wonderful if there is a support for this feature which is equivalent to flash attention v2.3.
This would also support Mistral-7B model as well, which is one of the best opensource 7B model architecture.
May I know is there a plan to bump flash attention v2.0.4 ROCm to v2.3?

Hi @tjtanaa, I am not sure when the sliding window feature will be implemented in this repo because that will depend on the feature to be implemented in the CK backend. There is a new CK for attention with better performance under development so this flash-attention for ROCm will then be refactored based on that one. But until then it will stays at v2.0.4. You may also want to check with the Flash-Attention in PyTorch for ROCm to see if their implementation are going to support that feature soon.

Hey just wanted to check in if there were any updates on this?

+1

Please, this is impacting customers.
The current flash attention version does not support sliding window attention, for a more memory efficient implementation make sure to upgrade flash-attn library.

+1 , Please~

+1


Don't discard all consumer offset data on resync

When a group resyncs we were discarding all local data about which partition offsets had been processed. Any data that had not been committed would be lost, even if the consumer was assigned some of the same partitions after the sync. With this change, consumers only discard offset data for partitions they are no longer assigned.
This should result in less reprocessing of messages. Running the consumer group fuzz test indeed indicates that this is the case, with the number of duplicates going from upwards of 10% to about 0.1%
Tasks

[x] Documentation

I'm thinking about introducing the notion of checkpoints as a more clear name of offset commits.

There's the case of:

consumer A loses connectivity
consumer B takes over, processes a bunch of messages
consumer A resumes, ends up re-processing from the old offset.

Maybe it could make a spot-check that the stored consumer position isn't ahead of it?

@dasch were you replying to me with:

@processed_offsets refers to the consumer's in-memory checkpoints, updated after every message. @committed_offsets is a cache of what the broker API returned, i.e. the committed offsets.

?

Nah, just wanted to make the diff clear.
I was thinking that I could maybe use the group generation id to ensure there hasn't been a gap in which another member was assigned the partitions...

That is, we can check if prev_generation_id + 1 == new_generation_id. That should rule out the case you described (which was also the one I was worried about, actually).
Can you think of other scenarios that could cause problems?

Okay, if the new generation isn't the immediate successor of the last we simply clear all the local offsets and resume from the commits.

@dasch does the upstream consumer do this? If not I may make an jira for them.

@tcrayford I'm actually not sure. This seems to significantly decrease the reprocessing rate.


[Jira Search] Please support multiple accounts/instances

Extension – Jira Search
Author: @svenwiegand
Hi there - any chance you could support multiple accounts or Jira instances? Or if you can provide some tips on how to duplicate the extension so I could configure a second (and third...) jira.
Thank you

I‘m not planning to implement this, as it would be tricky and require quite some efforts. Sorry. But maybe there is another developer interested in implementing this.


Remove duplicated REQUIRED_OS logic and leftovers from x509 proxy removal in volunteer sites

Fixes #9736
Status
not-tested
Description
Remove duplicated REQUIRED_OS logic, since this is integrated in T2_CH_CERN_HLT already.
Also, AuthenticatedIdentity logic is no longer needed,
as we take care of removing x509 proxies in the volunteer schedds
natively with condor job transforms (which happen before the materialization of jobs in the local queue)
Set self.reqStr to None, unless defined via
config.BossAir.condorRequirementsString
Is it backward compatible (if not, which system it affects?)
YES

@amaltaro This basically removes self.reqStr, as it is no longer needed neither for REQUIRED_OS logic in HLT nor for x509 proxy removal from volunteer sites.

@amaltaro Just changed this a little bit so setting condorRequirementsString is still supported (HTCondor gave me a way to solve what I reported in ticket 7715).

@khurtado about this sentence "...as we take care of removing x509 proxies in the volunteer schedds
natively with condor job router rules." is there any possibility that a job would actually start running before the JobRouter tweaking kicks in?

@amaltaro No, we use job transforms (performed by the schedd) to remove the x509 proxy. The transformation is executed before the materialization of the job in the queue.

Thanks Kenyi!


Memory leak

Seems scala package still have tiny-teeny memory leak during training or prediction

https://github.com/dmlc/mxnet/issues/1591


Added placeholder textures

Added temporary textures for the squirrel, an acorn, the sky, and 3 ground textures.

I merged these manually.


EssentialCmds doesn't work on SpongeForge 1.9.4 singleplayer

This listener relies on the server being available (through EssLogger). However, in 1.9.4 (clientside), the server is not always available. Specifically, it only becomes available while in a singleplayer world, as opposed to on the main screen.

Okay, thanks for the report, will fix ASAP

Fixed via eb67bf9dcba574bf16548f58397268c246411ad4


[HOTFIX] Changed unit test LRUCacheMapTest to run only with mvn verify

@deroneriksson

LGTM. Thank you @nakul02

Thanks, I'll merge


channels and apps

hello
First thanks for your work, amazing.
Everything work but If I try config channels and apps display on home app but like active on gray and its not working, could you tell me if I am doing something wrong?
This is my config:
{
"platform": "BraviaOSPlatform",
"tvs": [
{
"name": "Televisión",
"ip": "XXX.XXX.X.XX",
"port": 80,
"psk": "XXXXXXX",
"wol": true,
"channels": [
{
"channel": 1,
"source": "TVE"
},
{
"channel": 2,
"source": "2"
}
],
"apps": [
"YouTube",
"Netflix"
]
}
],
"interval": 10
},

What u mean with active on gray? Can u post a screenshot and your log pls

Is TVE given by your tv? Can u post ur whole log pls

@rmoya87
btw v3.0.6 is online

Hello my problem is (I think is my wrong): if I have this config:
{
"platform": "BraviaOSPlatform",
"tvs": [
{
"name": "Televisión",
"ip": "XXX.XXX.X.XX",
"port": 80,
"psk": "XXXXXXX",
"wol": true,
"channels": [
{
"channel": 1,
"source": "TVE"
},
{
"channel": 2,
"source": "2"
}
],
"apps": [
"YouTube",
"Netflix"
]
}
],
"interval": 10
},
Don't display apps and channels in inputs.
But if I have this:
{
"platform": "BraviaOSPlatform",
"tvs": [
{
"name": "Televisión",
"ip": "XXX.XXX.X.XX",
"port": 80,
"psk": "XXXXXXX",
"wol": true,
"apps": [
"YouTube",
"Netflix"
]
}
],
"interval": 10
},
I can see in inputs apps and works.
So I thinks something is wrong to me.
For example in my tv channel 001 call TVE but I have to type 1 in channel right? could you tell me if I am doing something wrong?
thanks

Attach picture.
This is my config now:
{
"platform": "BraviaOSPlatform",
"tvs": [
{
"name": "Televisión",
"ip": "XXXXX",
"port": 80,
"psk": "XXXX",
"wol": true,
"channels": [
{
"channel": 1,
"source": "La 1 HD"
},
{
"channel": 2,
"source": "La 2"
}
],
"apps": [
"YouTube",
"Netflix"
]
}
],
"interval": 10
},

if I remove channels apps will be on inputs but again I think problem are channels because don't display it too

@rmoya87
Di Inputs you posted in the screenshot will disappear after force quitting the home app
Yes, you need to start with 1, not 001
Can u post your Log

I briefly had this issue with the plugin, but it resolved itself after restarting Homebridge and also the Home app, so unfortunately I can’t get logs. I wonder if it’s a first-run issue?

I have the same issue with channel. if I add channel in the config.json then I see no channel in the input and all apps would be out on screen as separate accessories. the log shows:
[BraviaOSPlatform] [INFO] Sony TV: Checking Inputs for DVBT! Other channel sources are not considered!
Oct 30 01:15:21 raspberrypi homebridge[24993]: [10/30/2019, 1:15:21 AM] [BraviaOSPlatform] [ERROR] Sony TV: An error occured while handling accessories!
my config.json:
"platform": "BraviaOSPlatform",
"tvs": [
{
"name": "Sony TV",
"ip": "192.168xxxx",
"mac": "04:5d:xxxx",
"port": 80,
"psk": "xxxxxx",
"cecInputs": false,
"channelInputs": ["DVBT"],
"channels": [
{
"channel":800,
"source":"DVBT"
},
{
"channel":801,
"source":"DVBT"
},
{
"channel":802,
"source":"DVBT"
},
{
"channel":805,
"source":"DVBT"
}
],
"apps": [
"YouTube",
"Netflix",
"Kodi"
]
}
],
"interval": 10
},

Currently working on v4 and there will be some major changes, should fix this problem

Sorting out the issues. This issue is fixed in v4 (coming soon)


Use verbose for VERBOSE, vverbose for VVERBOSE

Why use verbose for VVERBOSE?

@phuongnd08 This has been implemented in recent changes. I've not been able to do a portability test, yet, so v0.0.4 is not released as a gem. You can try it out with bundler, though:
# Gemfile
gem 'guard-resque', :git => 'https://github.com/railsjedi/guard-resque.git'


MSBUILD : error MSB4132: The tools version "2.0" is unrecognized. Available tools versions are "4.0"

https://tips.tutorialhorizon.com/2018/03/14/msbuild-error-msb4132-the-tools-version-2-0-is-unrecognized-available-tools-versions-are-4-0/
npm install -g<EMAIL_ADDRESS>npm config set msvs_version 2015

https://community.slickedit.com/index.php?topic=16730.0


fix: fix slice init length

What does this PR do?
The intention here should be to initialize a slice with a capacity of len(req.State) rather than initializing the length of this slice.
The only demo: https://go.dev/play/p/q1BcVCmvidW
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

Hey @cuishuang,
Thank you so much for the contribution and for the fix 🎉

/merge


Add option to disable format on save

I often press Ctrl+S while writing code. There's nothing more annoying than writing out something like
if foo.bar {

}

to have it all get collapsed into one line when one wants to write some code in the empty line next.
You might even consider disabling it by default, I can imagine many people would rather trigger formatting manually.

It is available in main branch
https://github.com/lapce/lapce/blob/master/defaults/settings.toml#L16 set this to false in your settings.toml
or

disabling by default is good idea

While I will personally leave it on, I think the default behavior should be off: disabling it makes the default experience snappier and simpler to use for onboarding situations, where the editor needs to stay out of the user's way.
Simple, blazing-fast, and easy to customize if we want more should be the default behavior in my opinion.


Choose device, viewport size, aspect ratio, etc

Is there a way to choose which size we want our viewport to be, as well as what kind of device (tablet, desktop, phone) and the aspect ratio?

Currently defined in the code itself. But I can add an option to select by the end user.


Refactor TextMergeStream

Fixes #922

Rewrite TextMergeWithOffset. The old implementation borrowed text from the source based on the offsets, instead of combining the content properly.
TextMergeWithOffset now has the same iterator adapter API as TextMergeStream, i.e. ::new(iter), instead of replicating the parser constructors.
Implement TextMergeStream in terms of TextMergeWithOffset. The DummyOffsets adapter is a little verbose, but oh well (can't use std::iter::Map because the type must be named).
A couple simple tests

Great! But the interface has been changed, right? Then it should be merged in the 0.12 branch.
Thanks!

Ok, I hadn't noticed it.

Thanks!


Add freesurfer bids_app

We will need to include the freesurfer bids app in order to extract session (timepoint) level anatomical stats
https://github.com/bids-apps/freesurfer

You've added this.


[TACHYON-744] Clean up log message in FileInStream

Hi admins, please take a look if that is what you want.
Regards.

Jenkins, test this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7909/
Test PASSed.

Thanks for the PR! I've left a few comments

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7910/
Test PASSed.

Thanks, @aaudiber . Could you please take a look at it? Regards.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7911/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7912/
Test PASSed.

Thanks, @aaudiber. Could you please take a look at it? Regards.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7925/
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7926/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7927/
Test PASSed.

Hi @aaudiber. Does it addressed your needs?
Regards.

Hi @caadecarvalho, could you reply "done" when you address review comments so that it's clear what's left to do? I think a few of my earlier comments still need to be addressed, e.g. refactoring the repeated error message

Thanks, @aaudiber . I left some comments for you.
Regards

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7947/
Test PASSed.

@caadecarvalho When you update a PR, please don't overwrite the previous commits. We try to avoid overwriting history so that it's easier to see how the code has been updated by just looking at the latest commit.

Hi @aaudiber , I addressed all your comments, could you please take a look at it?

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7948/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/7949/
Test PASSed.

LGTM, thanks for the improvements!


Add migration process plugin to strip HTML attributes

Summary

Adds a custom process plugin to remove a given attribute from the markup.
Updates the basic page migration to use the filter.
Metadata

Question
Answer

Did you use a meaningful pull request title?
yes

Did you apply meaningful labels to the pull request?
yes

Did you perform a self review first?
yes

Documentation reflects changes?
no

CHANGELOG reflects changes?
yes

Unit/Functional tests reflect changes?
yes

Did you perform browser testing?
yes

Risk level
Low

Relevant links
https://thinkoomph.jira.com/browse/RIG-216

I'd rather @pfrilling take this if that's ok.

I'd rather @pfrilling take this if that's ok.

@pfrilling ok addressed those changes!

@pfrilling ok addressed those changes!