Disable overbright by default + make fully configurable

Change cvars so that all overbright settings can easily be tested. The current overbright-related cvars have a wonky asymmetric design that can make it impossible to test a setting without editing the map. Fix that. With this commit we can use r_overbrightDefaultExponent (0-3) and r_overbrightDefaultClamp (on/off) to control the default settings when the map doesn't say anything, and one more cvar r_overbrightIgnoreMapSettings to make those cvar values override the worldspawn values even if present. In the worldspawn entity mapOverBrightBits can stay as is, but forceLegacyOverBrightClamping drops the "force" (since it is no longer a one-way switch) and renames to just overbrightClamping.

Set overbright clamping on by default. If nothing else we should be true to the intentions of the authors of our own official maps, who were definitely targeting a renderer with clamping. For older maps, the .ent file may be used in restoration efforts if non-default settings look better.

There are physical evidences that not-clamped light was the true intention of the authors, this is true for both game engine authors and map authors.
1. Game engine authors
This quote from the official Quake3 manual:

6.3.1 RgbGen identityLighting
Colors will be (1.0,1.0,1.0) if running without overbright bits (NT, linux, windowed modes), or (0.5, 0.5, 0.5) if running with overbright. Overbright allows a greater color range at the expense of a loss of precision. Additive and blended stages will get this by default.
-- https://icculus.org/gtkradiant/documentation/Q3AShader_Manual/ch05/pg5_1.htm

This quote is about rgbGen identityLighting which only has different values than rgbGen identity if and only if there is a need to adjust for not using a brightening alternative technique to (clamped) overbright bits that was only implemented on Windows 9x.
Actually our GLSL overbright that is done in postprocess is similar to what an hardware overbright would do, and we also have to adjust the lighting on some surfaces to compensate.
2. Map authors
Those levelshots for A.T.C.S. Zone Alpha,

map-atcszalpha.pk3:levelshots/atcszalpha.jpg, file date 2006-09-02 14:09:30:

map-atcszalpha-b1.pk3:levelshots/atcszalpha.jpg, file date 2006-09-08 19:11:56:

Here is how looks the map in Dæmon engine with clamped overbright:

Here is how looks the map in Dæmon engine without clamped overbright:

I haven't found the exact viewpos but -440 -365 532 -45 40 is close enough, and resolution is 720×570.
We have minor difference in blending compared to what the mapper experienced, but the lighting is what the map author expects the map to look like in 2006. Tremulous was released in 2006 as well, so this is what Tremulous players playing fullscreen on Windows 9x experienced at release time.

That's a cool demonstration that at least one person enjoyed a genuine overbright implementation. (And even had r_gamma 1, what a good boy!) But even in 2006, surely Windows 9x users were greatly outnumbered by users of other systems? If I'm not mistaken, Tremulous always had a substantial Linux playerbase. I suppose most mappers/players would have been working with the crippled version of overbright.
Forgot to link #1289 in the OP which contains a discussion of various people on whether we should make this the default.


set geoip.ip type to ip

By default the type would be string, and ip aggregations won't work on it.

Thanks!


feat: make typegen factories an object instance

typegen factories currently are classes with static methods which is a problem when wanting to pass the whole factory as an argument because e.g. passing a whole TestContract__factory as an argument and using it in the manner of factoryArgument.deployContract would yield an undefined.deployContract error because TestContract__factory is not an object instance. This PR is necessary to be able to pass the outputs of typegen to launchTestNode in #1356. It doesn't break anything for end consumers.

@nedsalk Does the described issue with Typegen factories indicate a design flaw, or is this change primarily to fit the needs of launchTestNode?

Does the described issue with Typegen factories indicate a design flaw, or is this change primarily to fit the needs of launchTestNode?

@Torres-ssf This change is primarily to fit the needs of launchTestNode. The design itself is okay as it follows ContractFactory. There is possibility for improvement here so that we don't need e.g. the contract as unknown as ContractAbi casts, but that's more related to the internal design of how we integrate typegen outputs with the rest of our codebase.

I like this approach. Would it be worth having interfaces for these factories?

@petertonysmith94 No because these factories themselves follow the interface of the ContractFactory class. Ideally we'd be returning a ContractFactory<TTypegenAbi> and we wouldn't have the need for this *__factory object, but this is related to what I told @Torres-ssf above - an internal design restructuring.


Prevent timeouts for a pgwire conn's txns for as long as it stays open

Yeah, this is the right direction. I'm about to run out for an interview, so I my feedback is somewhat half-baked.


Add skip to flaky MacOS RPC test

Skip for #9824
cc @areusch

Hello @driazati!
Thank you for your comment! Our team also noticed this problem.
It looks like the first time this error occurred when running this action in PR#9483.
Failure occurs in a test that seeks to verify that the auto scheduler can be used with an RPC Session. The error occurs due to checking the tuning log after a tuning session. The test says that at this stage, an error code was found inside the log, which says the following:
Errors happen when compiling code on device
(e.g. OpenCL JIT on the device)

It doesn't look like the problem is in the whole test or in the iOS RPC application.
At the moment, it has not been possible to reproduce the problem locally to find out more details about this failure. If you have any additional information about this or can reproduce this problem yourself, then we would be very grateful for any additional observations.

I wasn't able to reproduce it locally either (and it doesn't seem to fail in CI super often either, maybe 1 out of every 20 recent runs on main) and I don't really know the autotuning/rpc code well enough to guess where the problem might be, but it still comes up from time to time so I think it should be disabled until a proper repro/fix is found. It makes more sense to mark this as a flaky failure with xfail rather than skip though so it will still run, but not report as an unexpected error if it fails.

Hello @driazati!
We have only been able to reproduce this issue in the azure cloud.
To do this, we slightly modified main.yaml as follows:
for ((i=1; i < 100; i++)); do python -m pytest -vrP tests/python/contrib/test_rpc_server_device.py; done

It looks like this line has fallen off:
func = remote.load_module (os.path.split (build_res.filename) [1])

The problem requires further investigation.

thanks @driazati can you create a GH issue for this test or mention it in this PR?

sorry one q: has anyone repro'd this on linux? if it hasn't failed there, i'd lean towards disabling it only on windows/os x for now. the GH actions can be retriggered and don't necessarily block commit.
@KJlaccHoeUM9l could you let us know which os you were using in azure?

oh sorry--ignore. i misread the test decorators.


How do you change the status?

In your config.ini file, add
status = some random message

With v3.0.0 and later, you can now also set the status type:
statusType = watching


Conditional expression in dyanmic import's string literal causes error [plugin:vite:asset-import-meta-url] Unterminated template literal

Describe the bug
when conditional expression exists in new URL 's string literal, dev server & build breaks, with this error message  [plugin:vite:asset-import-meta-url] Unterminated template literal (1:11)
Reproduction
https://stackblitz.com/edit/vitejs-vite-c6quvn?file=main.js
Steps to reproduce
vite 4.3.1 works fine, 4.3.5 breaks
const bool = false

// const logo = new URL(`./${bool ? `javascript` : "javascript"}.svg`, import.meta.url).href; // works
const logo = new URL(`./${bool ? "javascript" : "javascript"}.svg`, import.meta.url).href; // doesn't work

toggle comments in above to see the error
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    vite: ^4.3.5 => 4.3.5

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

fixed by #13121


No deb file for v0.2.0

there is no deb file in the assets section, can you please add it or give instructions to compile it?

Hi, sorry for that, I just added it!

Thanks for your work


fix(swap): inconsistent fee currency when swapping from CELO

Description
On the swap screen, we estimate the fee and use this to determine the "max" "from" amount. Then when we perform the swap, we calculate the gas price / currency again.
For a wallet with more stablecoins than CELO, when pressing "max" to swap all CELO to something else, the "useMaxAmount" hook returns the whole CELO balance because the stablecoin with the higher balance will pay for gas. However when we perform the swap, CELO is chosen as the gas currency and therefore the tx fails of course.
This PR:

set the preferred gas currency before sending the swap, consistent with the start of the swap flow
increase the fee estimate buffer. i was often seeing failures when swapping from max cEUR :/ this increased buffer seems to work better

Test plan

Related issues

Fixes RET-609

Backwards compatibility
Y

Great! 👍
This fix works and is good enough probably, but it seems the we should return the feeCurrency from useMaxSendAmount and pass it all the way to where we send the transaction to avoid this type of mismatch in the first place.
This is another example where we should rethink how we present TX before sending. Right now, users can accept sending TX without knowing which token will be used to pay for fees and the estimated amount (which is recalculated) after approving. This isn't right.

this might be a good one for the eng backlog? the fee estimation stuff is one of things that i don't feel super confident with in the wallet, so i don't have a vision right now for what it should look like. not all places that need a fee currency calculation use the useMaxSendAmount hook, but i don't have a good overall idea of all the use cases. maybe this is something we can discuss and document, i don't feel confident that it's the right time to do this refactor to solve this bug?
i agree that surfacing the tx data to the user would solve some of these problems (at least, this bug would have been spotted sooner), i wonder if we should also allow changing the fee currency too :/

Yes totally, let's merge this and discuss the possible bigger changes separately 👍


"Output generation failed" when transpiling "test.d.abc.ts"

🔎 Search Terms
"Output generation failed", "transpileModule"
🕗 Version & Regression Information

This is a crash
This changed between versions 5.0.0-dev.20230109 and 5.0.0-dev.20230110
This is the behavior in every version I tried, and I reviewed the FAQ for entries about file names

⏯ Playground Link
No response
💻 Code
const TS = require('typescript')

const res = TS.transpileModule('export const x = 6;', {
    fileName: 'test.d.tsp.ts',
});

console.log(res)

🙁 Actual behavior
The Typescript compiler crashes. The compiler should allow files that contain .d. in their name.
🙂 Expected behavior
The compilation succeeds
Additional information about the issue
c:\Users\osv\Downloads\test>npm i<EMAIL_ADDRESS>
changed 1 package, and audited 2 packages in 5s

found 0 vulnerabilities

c:\Users\osv\Downloads\test>node main.js
c:\Users\osv\Downloads\test\node_modules\typescript\lib\typescript.js:1772
          throw e;
          ^

Error: Debug Failure. Output generation failed
    at Object.transpileModule (c:\Users\osv\Downloads\test\node_modules\typescript\lib\typescript.js:127318:20)
    at Object.<anonymous> (c:\Users\osv\Downloads\test\main.js:3:16)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:135:12)
    at node:internal/main/run_main_module:28:49

Node.js v20.11.1

c:\Users\osv\Downloads\test>npm i<EMAIL_ADDRESS>
changed 1 package, and audited 2 packages in 745ms

found 0 vulnerabilities

c:\Users\osv\Downloads\test>node main.js
{
  outputText: '"use strict";\r\n' +
    'Object.defineProperty(exports, "__esModule", { value: true });\r\n' +
    'exports.x = void 0;\r\n' +
    'exports.x = 6;\r\n',
  diagnostics: [],
  sourceMapText: undefined
}

I can't find where it was written right now, but filenames matching *.d.*ts are considered declaration files. That's probably causing issues here.

https://www.typescriptlang.org/docs/handbook/2/type-declarations.html#dts-files
should not it be *.d.ts ?

Related #53319 and specifically https://github.com/microsoft/TypeScript/issues/53319#issuecomment-1474174018

@andrewbranch Maybe we should take this as a request to make the output a bit more informative than Debug Failure. Output generation failed? Surely we could issue a more specific and helpful diagnostic (or, like, actually issue a diagnostic at all instead of a Debug Failure)?


Workspacer logo

The current logo is a bit boring so i designed some logos for workspacer.
Which one do you think is the best and should i change some thing?

The original svg file:
logo.zip

I like the second one best. It subtly highlights the tiling.

Agree with josteink, no. 2 is my favourite. Maybe if there's some consensus on the design (and approval from rick of course 😄) we can play with the colors too?

wow, these are great!
the original logo was something I whipped up in a few minutes to get rid of the default exe icon, so no love lost.
another +1 for number 2. I'm not sure how artwork licensing works in this respect, since this isn't a commit to the repo itself. Are you interested in opening a PR to update the logos in the app?

Sure, I will open a PR for that.

Closed via https://github.com/rickbutton/workspacer/pull/145.


gtk-pipe-viewer: 0.3.0 -> 0.4.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/trizen/pipe-viewer/releases.
meta.description for gtk-pipe-viewer is: "CLI+GUI YouTube Client"
meta.homepage for gtk-pipe-viewer is: "https://github.com/trizen/pipe-viewer"
meta.changelog for gtk-pipe-viewer is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.1 with grep in /nix/store/g68n1mjcqfp9m6xd6qr0fa3as281y32k-perl5.36.0-pipe-viewer-0.3.1
found 0.3.1 in filename of file in /nix/store/g68n1mjcqfp9m6xd6qr0fa3as281y32k-perl5.36.0-pipe-viewer-0.3.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
gtk-pipe-viewer
pipe-viewer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g68n1mjcqfp9m6xd6qr0fa3as281y32k-perl5.36.0-pipe-viewer-0.3.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gtk-pipe-viewer https://github.com/r-ryantm/nixpkgs/archive/e395c0a99cb06eb26e4c895b38a289d5620581ed.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g68n1mjcqfp9m6xd6qr0fa3as281y32k-perl5.36.0-pipe-viewer-0.3.1
ls -la /nix/store/g68n1mjcqfp9m6xd6qr0fa3as281y32k-perl5.36.0-pipe-viewer-0.3.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

gtk-pipe-viewer
pipe-viewer

Maintainer pings
cc @ju1m for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/trizen/pipe-viewer/releases.
meta.description for gtk-pipe-viewer is: "CLI+GUI YouTube Client"
meta.homepage for gtk-pipe-viewer is: "https://github.com/trizen/pipe-viewer"
meta.changelog for gtk-pipe-viewer is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.1 with grep in /nix/store/v7lpqgmnzf1hdhknp9h61cln8fvmzg3m-perl5.36.0-pipe-viewer-0.4.1
found 0.4.1 in filename of file in /nix/store/v7lpqgmnzf1hdhknp9h61cln8fvmzg3m-perl5.36.0-pipe-viewer-0.4.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
gtk-pipe-viewer
pipe-viewer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v7lpqgmnzf1hdhknp9h61cln8fvmzg3m-perl5.36.0-pipe-viewer-0.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gtk-pipe-viewer https://github.com/r-ryantm/nixpkgs/archive/d3f4774c3c6e53c232d4eb45511b72681d895e37.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v7lpqgmnzf1hdhknp9h61cln8fvmzg3m-perl5.36.0-pipe-viewer-0.4.1
ls -la /nix/store/v7lpqgmnzf1hdhknp9h61cln8fvmzg3m-perl5.36.0-pipe-viewer-0.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

gtk-pipe-viewer
pipe-viewer

Maintainer pings
cc @ju1m for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/trizen/pipe-viewer/releases.
meta.description for gtk-pipe-viewer is: "CLI+GUI YouTube Client"
meta.homepage for gtk-pipe-viewer is: "https://github.com/trizen/pipe-viewer"
meta.changelog for gtk-pipe-viewer is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.3 with grep in /nix/store/22i6i5l7szraax00hlvjlfqfigzfkz2d-perl5.36.0-pipe-viewer-0.4.3
found 0.4.3 in filename of file in /nix/store/22i6i5l7szraax00hlvjlfqfigzfkz2d-perl5.36.0-pipe-viewer-0.4.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
gtk-pipe-viewer
pipe-viewer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/22i6i5l7szraax00hlvjlfqfigzfkz2d-perl5.36.0-pipe-viewer-0.4.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gtk-pipe-viewer https://github.com/r-ryantm/nixpkgs/archive/f06939789e7beb0b3e712d19f9bbfd33367ae6a2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/22i6i5l7szraax00hlvjlfqfigzfkz2d-perl5.36.0-pipe-viewer-0.4.3
ls -la /nix/store/22i6i5l7szraax00hlvjlfqfigzfkz2d-perl5.36.0-pipe-viewer-0.4.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

gtk-pipe-viewer
pipe-viewer

Maintainer pings
cc @ju1m for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/trizen/pipe-viewer/releases.
meta.description for gtk-pipe-viewer is: "CLI+GUI YouTube Client"
meta.homepage for gtk-pipe-viewer is: "https://github.com/trizen/pipe-viewer"
meta.changelog for gtk-pipe-viewer is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.4.4 with grep in /nix/store/zvm3jfhbykpdkw7d3jph65w99iqdhlmy-perl5.36.0-pipe-viewer-0.4.4
found 0.4.4 in filename of file in /nix/store/zvm3jfhbykpdkw7d3jph65w99iqdhlmy-perl5.36.0-pipe-viewer-0.4.4

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
gtk-pipe-viewer
pipe-viewer

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zvm3jfhbykpdkw7d3jph65w99iqdhlmy-perl5.36.0-pipe-viewer-0.4.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gtk-pipe-viewer https://github.com/r-ryantm/nixpkgs/archive/39bb380f53008cc5facc3c3a8a793fee006036d9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zvm3jfhbykpdkw7d3jph65w99iqdhlmy-perl5.36.0-pipe-viewer-0.4.4
ls -la /nix/store/zvm3jfhbykpdkw7d3jph65w99iqdhlmy-perl5.36.0-pipe-viewer-0.4.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

gtk-pipe-viewer
pipe-viewer

Maintainer pings
cc @ju1m for testing.

Result of nixpkgs-review pr 190980 run on aarch64-darwin 1

2 packages built:

gtk-pipe-viewer
pipe-viewer

Please repropose the update to 0.4.5.


[Question] What is the best approach for handling redirects on post actions (form post)

I have cases where the POST of a form can cause an authorize redirect back to the Id Server to re-validate the token or ask the user to log in again, which is generally good except that the return url is not applicable for a GET request
-- Is there a good approach / pattern that can be applied to handle these cases?
Context:
RP apps which have been migrated from their own Forms Auth to now use IdSrv + WsFed.
It is reasonable to assume that folks may spend quite some time on a page before actually submitting the form.
This app is Asp.Net MVC though answers can be less specific
I also realise this is not strictly a WsFed problem but rather a question on how best to put it into practice with existing applications.

Maybe this is a silly question, it seems to me that all RP form POST urls that require authorization need to support a GET action that can be called that allows the end user to resume the flow... If someone else is discovering this I'd love to hear their thoughts about it.

This is a really hard problem to solve in general web development. The user fills in a bunch of fields, and your server decides that it wants to redirect the user somewhere else -- how do you not lose the data? You'd have to capture it somehow in the server, redirect the user, and then when they come back re-submit this data (or just process it as if they had submitted). Also, what happens with multiple tabs? It's not trivial, so most people just say "screw it" and just accept that sometimes the user has to reenter the data.

You are right, it seems each case needs to be handled individually so there is no silver bullet.


Fix ESP32-C3 once again

This reverts commit 0fb93950ed1e4ff507b6dd472d4634f0a9878ac8 from PR "Undo the halting hack for ESP32-C2/C3 (#2769)"

@bugadani here's a PR which reverts the changes you introduced, I tested my esp32-c3 with it and it works


Error when running pip install -r gdt-fermi/requirements.txt

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
astro-gdt-fermi 2.1.3 requires matplotlib>=3.9.1, but you have matplotlib 3.8.4 which is incompatible.

What version of python are you using?

Python 3.10.12

It looks like this might only be an issue when installing from the requirements.txt file?
pip installs matplotlib 3.9.1.post1 for me even if I roll the setup.py for gdt-fermi back to matplotlib 3.8.4. Also, we should update the requirements file to match the setup.py. I forgot to do that when updating the setup.py.

Yup, I was installing from the requirements file. Setting matplotlib>=3.9.1 to match the setup.py solved the issue.
Thanks!


Importing Class documentation when class isn't default export

I documented classes in a separate JS file that exports an object that consolidates those classes among other objects. How can I port the documentation (including internal properties) of these classes to other files?
Input code

// models.js
/** This is an example model */
class foo { .... }

const models = { foo, otherModel1, otherModel2 }
export default models

// view.js
/** @typedef {--Somehow import foo from models.js--} */

/ **
 * @param {foo} - a foo model
 * /
function bar(foo) { .... }

Expected behavior
Being able to set type {foo} in view.js using the documentation already in models.js without foo being the default export. This includes getting documentation for public properties defined in foo.

I found one solution, which is to put a quick typedef in the source file that can then be imported.
// models.js

/** @typedef {foo} foo */

/** This is an example model */
class foo { .... }

const models = { foo, otherModel1, otherModel2 }
export default models

// view.js

/** @typedef {import ("models.js").foo} foo */

/ **
 * @param {foo} - a foo model
 * /
function bar(foo) { .... }


Support vmax css unit

Add vmax as a recognized CSS unit to the parser. It currently recognizes vh, vw, vmin, and vm. vm was the syntax originally recognized by Internet Explorer, but it has been superseded by vmax in modern browsers.
closes #519

Let's see if I remember my CI setup correctly... if I did, this change (along with Nabil's fix that has been pending since June last year >_>) should appear as 1.5.3-alpha3 on Nuget.org soon-ish.

Alright, it's up now. I had to make an adjustment -- simply adding "vmax" after "vm" wasn't quite right: the regex would match "2vmax" as "2 vm" with a trailing "ax" that the parser couldn't then deal with.

Thanks! I'll validate the fix in my environment ASAP.


APT whitelist request for puredata-dev

just to explain the setuid stuff: Pd (aka puredata, the source package for puredata-dev) is a real-time audio processing system. as such it is often run with higher-than-normal privileges.
in order to obtain real-time privileges, Pd can be run with setuid enabled, and this is mentioned in the documentation (most hits in the travis test-scripts returned documentation).
if the puredata binary is setuid'ed, it drops root-priviliges asap; for doing this, the code contains a few setuid(getuid()) calls (explaining the other hits).
The binaries in the Debian packages do not have the setuid bit set.
anyhow, all this only concerns the puredata-core package; the request was about puredata-dev which only contains a bunch of headers and no executable code.

is this real?
*Ubuntu 14.04 (trusty)" had puredata-0.45.
i can't remember which Ubuntu version had puredata-0.43 (it was released in 2012).


[Bug] Does not show up

Addon
Timezones
What happened?
The time doesn't show up on their profiles.
What Discord version do you have this issue on?
Stable
Logs
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

You must set a user's timezone by right clicking on their name/image and selecting Set Timezone.

You must set a user's timezone by right clicking on their name/image and selecting Set Timezone.

It doesn't show up for me in my context menu

I'm not seeing any timezones as well, not even in the voice channel right-click context menu. Then again, Discord completely crashes each time I try to right-click any user at all in VC list or in my DM list- which has already been reported in #32.


[CVAT][Exchange Oracle] Return correct url from get_reputation_oracle_url

Added in #2428, get_reputation_oracle_url was mistakenly returning url for recording oracle.
This PR fixes it and adds previously missing tests.

@Dzeranov, could you take a look?


Extremely slow resource opening

Describe the bug
I have more than 3000 resources. I have to wait up to 10 seconds each time a file is opened.
To Reproduce
Steps to reproduce the behavior:
0. Open DevTools in Monokle, use the shortcut "Ctrl+Shift+I" or the  key

Go to Cluster View
Click on Show Cluster Objects
Click on any Pods file in Navigator
Each time the file is opened, reloads yaml.worker.a9f4cd15.worker.js

Desktop:

OS: Ubuntu
Version 20.04

thanks @canerbasaran for reaching out! would it be possible for you to share the yaml of the pod that your are trying to load? would like to figure out if this is related to the pod itself - or the fact that you have 3000 resources...

I can't share because it belongs to the company. But the file format is correct.

hm... understand - can you share the size of the pod yaml?

3.7KB

hm.. ok... and do you see these load times for smaller objects also? (ConfigMaps, Roles, etc)

this should be resolved by #369

Closing issue as it is covered by #369


"Talk to Rusty" (Easy clue step), switches 'talk-to', to attack, despite Menu Entry Swapper config.

Type
Incorrect behavior
Operating System
Windows
OS Version
Windows 10
Bug description
Having the easy Clue step "Talk to Rusty, north of falador" swaps the talk-to, to attack.
Screenshots or videos

RuneLite version
Runelite version: <IP_ADDRESS>
Launcher version 2.1.7
Logs
client.log
launcher.log

its programmed to not swap on clue npcs for this exact reason. Maybe adding another && for if its already "talk-to" would do the trick.


pkgsStatic.dtc: fix build

Before this fix, dtc will not build on static.
This pulls fixes in the upstream PR: https://github.com/dgibson/dtc/pull/141
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4750

@ofborg build pkgsStatic.dtc

@ofborg build pkgsStatic.dtc

@ofborg build dtc

@ShamrockLee yeah, that's a good point, I misread the previous label, I thought it was impacting less than 100 packages. I retargeted to staging.

@ofborg build pkgsStatic.dtc
@ofborg build dtc
@ofborg build VirtualBox
@ofborg build qemu

@ofborg build virtualbox


[vm/ffi] Native asset resolution via embedder

We should call out to the embedder to resolve native assets and symbols.
This would enable the embedder resolving symlinks:

https://github.com/dart-lang/sdk/issues/55410
https://github.com/dart-lang/sdk/issues/55207

Also it would enable the embedder not having the files on disk at all or having the as part of a larger file and using dlopen_with_offset.
The embedder would provide an API for dlopen(), dlclose(), dlsym(), dladdr().
The embedder API would be tied to the new native assets feature. So dlopen would take a native assets mapping such as ['relative', 'some/file/path.so'] or ['process']. (As such it would not be used for DynamicLibrary.open and DynamicLibrary.lookup. https://github.com/dart-lang/sdk/issues/37771)
Having a dlclose embedder callback is only useful when we unload dynamic libraries on isolate group shutdown:

https://github.com/dart-lang/sdk/issues/55521

Having a dladdr embedder callback is only if we add some functionality that uses this. We currently don't have such functionality.

I've created a prototype here: https://dart-review.googlesource.com/c/sdk/+/361881
cc @a-siva @rmacnak-google @aam @alexmarkov @mraleph in case anyone has concerns on adding these embedder APIs. Feedback welcome!


Debug mode

This introduces a debug mode that can be enabled either via configuration or Cucumber tag. Right now debug mode only does one thing: automatically call save_and_open_page if a finder fails or an Rspec matcher fails. I want to get some feedback on this before I add anything else.
Here are a couple other debug mode features I'd like to add, based on my own experiences fumbling with failing integration tests:

Fail or log a warning message if a finder matches more than one element (ambiguous selector)
Log each action, finder, and wait (may bring some timing issues to light; addresses #377)

This really doesn't do anything compelling atm. It just adds a debug mode which does nothing. I still like the idea, and if you can work it to something more useful, we can discuss it further, but I'm closing this for now.

@jnicklas, can you be a little bit more in details on how you avoid using save_and_open_page and halt the execution?

binding.pry


python310Packages.pycaption: Re-enable tests

Description of changes
This is to just revert disabling the tests due to ZHF for 23.05 (#234418).
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

included in https://github.com/NixOS/nixpkgs/pull/279960


De2-115 Cclone IV

Works on De2-115 device? tks

no, it does not. DE2-115 does not support OpenCL


Add Tuomas Nylund to integration

Adding access for myself as per instructions https://docs.publishing.service.gov.uk/manual/get-started.html#create-a-user-to-ssh-into-integration

Looks good just needs a rebase on main :)


Add label values to inline doc for objects and behaviors

With PR #2276, behaviors and objects now have useful info in their inline documentation (Ctrl-D). Another useful piece of information are the :label values from the :params vector. That way, in some instances, you would be able to pass the args key to the inline doc.
Below, an example of :label and :params can be seen in use, but not displayed in the doc box:

@rundis - could you provide some info on how you wanted the param labels displayed? For instance, before the :doc / :desc, after it, to the right of the function name, or perhaps wrapped in a pair of [ ] with commas separating them, etc...

PR #2301 addresses issue and has been merged.


tensorflow.keras.layers.BatchNormalization deos not accept float64 input data

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version (use command below): 1.14.0
Python version: 3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 9
GPU model and memory: 1080 GTX

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with: 1. TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)" 2. TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"
Describe the current behavior
TypeError: Value passed to parameter 'x' has DataType float64 not in list of allowed values: float32
Describe the expected behavior
Code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate the problem.
import tensorflow.keras.layers as tks
input_ = tks.Input(shape=[None, None, 3], dtype='float64')
conv = tks.Conv2D(filters=3, kernel_size=3)(input_)
batch = tks.BatchNormalization()(conv)

Other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@DeeperDeeper As you can refer to the source code here, tensorflow.keras.layers.BatchNormalization() only takes float16 or float32 values as input. This is the cause of your error. Please let me know if it helps. Thanks!


Added Thomas + Translations.

Added Thomas and translations.

a. it seems like you have a JSON error
b. please remove the empty translations

thanks, merged #1


Cleanup qtransform.model

There are still some copy pasta left overs. from NanoGPT
Also we have to define what OUR GPT Tranformer should look like.

mostly done, so closing this.


Update shorty.css

Multiple color effect for Login and Signup buttons!

Share the Screenshot/ Screen Recording

https://github.com/apoorvaron/Shorty/assets/114821855/9947e090-6971-4062-872c-6c4539bcf085

@Kalivarapubindusree Actually it doesn't look good btw you can find an another issue.
Happy Coding!

@apoorvaron can I try another style for this button??? Will you consider it ??


THRIFT-4797: Golang: Fix import collisions

See THRIFT-4797 for details. In short, Golang compilation fails when a Thrift file includes two files that have the same final namespace component (e.g. namespace go packagea.common and namespace go packageb.common)
Somewhat based on fbthrift's implementation though their implementation simply always adds an alias with a unique numerical prefix.

[x] Did you create an Apache Jira ticket?  (not required for trivial changes)
[x] Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?  (not required for trivial changes)
[x] Did you squash your changes to a single commit?
[x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"

Just found another case to handle here. I should also detect collisions with the golang packages that get imported like bytes context reflect

For stdlib collisions like context etc, it would be great if the import list was a vector instead of a hardcoded string so we could reuse it everywhere.

@dcelasun I made it use a vector for system imports can you take a look?

Actually hold on merging for a bit. I may have found another edge case

Yep, confirmed. If the package has a service, and that service’s last namespace component conflicts with a previously imported package, it won’t get aliased. Hopefully I can get a chance to fix tomorrow

@dcelasun one more commit to review to fix the issue with the remote package import collisions! Hopefully this is it

LGTM. Tried testing a few different scenarios locally, everything works fine. Thanks for the PR!


failed to parse field as object, but found a concrete value

Logstash 6.4.2
logstash-codec-cloudtrail (3.0.5) still has same problem (#15).
responseElements and requestParameters (and their children like requestParameters.iamInstanceProfile)
[2018-10-23T20:26:49,297][WARN ][logstash.outputs.elasticsearch] Could not index event to Elasticsearch. {:status=>400, :action=>["index", {:_id=>nil, :_index=>"logstash-cloudtrail-write", :_type=>"_doc", :_routing=>nil}, #<LogStash::Event:0x2b804bc4>], :response=>{"index"=>{"_index"=>"logstash-cloudtrail-000004", "_type"=>"_doc", "_id"=>"H-2bomYBuhFkxAoaxCUs", "status"=>400, "error"=>{"type"=>"mapper_parsing_exception", "reason"=>"object mapping for [responseElements.role] tried to parse field [role] as object, but found a concrete value"}}}}
[2018-10-23T20:28:28,793][WARN ][logstash.outputs.elasticsearch] Could not index event to Elasticsearch. {:status=>400, :action=>["index", {:_id=>nil, :_index=>"logstash-cloudtrail-write", :_type=>"_doc", :_routing=>nil}, #<LogStash::Event:0x4cc6643b>], :response=>{"index"=>{"_index"=>"logstash-cloudtrail-000004", "_type"=>"_doc", "_id"=>"gO6domYBuhFkxAoaSECE", "status"=>400, "error"=>{"type"=>"mapper_parsing_exception", "reason"=>"object mapping for [requestParameters.iamInstanceProfile] tried to parse field [iamInstanceProfile] as object, but found a concrete value"}}}}

@jsvd @robbavey Looks like we've had issues with these fields being parsed and mapped properly for > 3 years now. Can we have someone look into way to fix this?
I'll even POST a custom template/mapping to fix these issues if that's the only solution.

Just to chime in for anyone landing here, the codec parses JSON records and does a few tricks to adjust the layout.
One of the ways forward here would be to adapt the plugin to Elastic Common Schema and leverage a predictable flat layout (similar to the one Beats has been using). This would be a separate plugin execution mode, similar to other codecs, as changing the current event layout might break backwards compatibility others might be relying upon.
The plugin mostly relies on support from the community and the last related update has been done by a plugin user.


Font Request: KDE Plasma

It would be nice if the icon for KDE Plasma would be added

Solved by #78


fix eventsource reconnect and add ping timeout

❓ Type of change

[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[x] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
When the eventsource connection could not be established the retry did not reconnect the eventsource.
Also I added a timeout function which checks if the connection is alive and reconnects the eventsource when it does not receive any ping events.
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Hey @adrianNEMO! 👋🏻
Could you please explain your changes?
The reconnection is handled automatically per the browser as per the SSE spec. There is nothing to be done in the client directly.
Also, I am unsure why you want to handle the ping message. The goal of this ping is to ensure that any proxy in the middle of your server-client connection keeps the connection alive (Cloudflare, for example, drops any HTTP connection if nothing happens for 100s).

Closing since no answer from issue reporter.


rpc: Add PendingOpenChannel to SubscribeChannelEvents

In this PR PendingOpenChannel is added to the SubscribeChannelEvents stream.
It is already possible to keep track of pending channel openings as the OpenChannel command opens a stream where you will get an update when the channel enters pending open state.
The problem though is that this does not apply to Autopilot, so there's no good way of knowing if Autopilot opened a channel without polling PendingOpenChannels, which is not a great solution.
It can also be useful for services and programs that want to track channel openings to them ("non-initiator"). Right now they can only see the channel if it has entered open state.
For pending, I suspect they poll PendingOpenChannels right now or have made a custom version of lnd. They can likely use SubscribeChannelEvents  in the future for their needs.
Currently this PR mirrors what OpenChannel sends, which is the ChannelPoint. If you need more information, you need to call PendingOpenChannel and match the right txid.
I could do so SubscribeChannelEvents sends all data about the channel as PendingChannels does, but I need some help figuring out how to do that.
The current method works fine though.
This PR does not include other pending states (i.e pending close etc).

Thank you for the review @carlaKC!☺
I've rebased the branch and addressed some of the points.

Thanks for the feedback @halseth!
I've been busy recently but hope to look into this (very) soon. :smiley:

Hi @carlaKC and @halseth, sorry for the long delay on this one.
I've rebased against master and addressed the suggestions you provided. ☺

NotifyPendingOpenChannelEvent now uses wire.OutPoint
Protobuf: ChannelEventUpdate pending_open_channel now uses the correct type, PendingUpdate
Miscellaneous things such as reordering code to be more logical and updating the SubscribeChannelEvents function inside rpcserver.go to work with the changes made to the channelnotifier (event uses outpoint)

@carlaKC

Thanks for sticking with this one @hsjoberg, it's going to be nice to have a complete channel subscription api. Just one small comment from me, and an itest fix, this is getting really close!

No worries, I appreciate the reviewing.

Itests are failing on SubscribeChannelBackups at the moment, because it subscribes to channel updates and then skips over events that aren't opens/closes. You just need to skip over pending channels in rpcserver.go#SubscribeChannelBackups in the switch on line 5553 and that should set it right :)

Right! My bad, I only tested against basic_channel_creation_and_updates.
make check should go through now.


[Bug]: Skip number doesn't update when selecting a different wordlist

Version of the software
0.1.28
Operating system
Windows 10 Pro x64 21H2 19044.1466
Browser / Native
Native
What happened?

Start a job with wordlist "A"
Wait for the skip number to be above 0
Abort job
Add new wordlist "B"

Result:
The skip number is the same when the job stopped with wordlist "A".
Relevant LoliCode if needed
No response

Fixed by PR #613


Strange effect on stone blocks

Really cool idea for a mod!
This however has a very strange effect for me on 1.20.1 with Fabric. I'm using many other mods which could be causing conflicts but I've never seen this kind of conflict before.
Some stone blocks such as the Stone Cutter are strangely difficult to break (as hard as obsidian basically) no matter what the strength of the tool, and breaking them destroys them even with the right tool.

hmmm, what other mods do you have installed?
on my testing, i don't have any other mods, and the stone blocks are working okay, so i'm wondering if i've overridden the tool file incorrectly or something?

mine i tried with LevelZ and had the same problem


Roll engine e3687f70c7ec..3280fc328413 (7 commits)

https://github.com/flutter/engine/compare/e3687f70c7ec...3280fc328413
git log e3687f70c7ec..3280fc328413 --date=short --no-merges --format='%%ad %%ae %%s'
2018-08-15<EMAIL_ADDRESS>Roll src/third_party/skia 77af386c13cb..64703d11a92a (1 commits) (flutter/engine#6030)
2018-08-15<EMAIL_ADDRESS>Roll src/third_party/skia e49966c983ec..77af386c13cb (3 commits) (flutter/engine#6029)
2018-08-15<EMAIL_ADDRESS>Wait for Dart VM initialization before the letting the service isolate constructor access the VM object. (flutter/engine#6028)
2018-08-15<EMAIL_ADDRESS>Re-apply "Log Tonic errors with FML_LOG" (flutter/engine#6026)
2018-08-15<EMAIL_ADDRESS>Roll src/third_party/skia 31a0944bb30b..e49966c983ec (8 commits) (flutter/engine#6027)
2018-08-15<EMAIL_ADDRESS>Update docker image tag and README (flutter/engine#5995)
2018-08-15<EMAIL_ADDRESS>Add message encoding/decoding utility to FML. (flutter/engine#6017)
The AutoRoll server is located here: https://flutter-engine-flutter-roll.skia.org
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://flutter-engine-flutter-roll.skia.org

Commit queue failed; closing this roll.


k8s: k8s.volume: new resource, assign CSI attrs

This follows up from https://github.com/open-telemetry/semantic-conventions/pull/1337, and adds the CSI attributes as resource attributes for kubernetes volumes for use in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32055.
xref https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/32055/files#r1805969619

not stale


Fix WindowStatisticsTransform

Before submitting (must do checklist)

[ ] Did you read the contribution guide?
[ ] Did you update the docs? We use Numpy format for all the methods and classes.
[ ] Did you write any new necessary tests?
[ ] Did you update the CHANGELOG?

Proposed Changes

Closing issues

closes #1008

Codecov Report

Merging #1128 (3e74294) into etna_v2 (17ca030) will increase coverage by 0.10%.
The diff coverage is 40.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##           etna_v2    #1128      +/-   ##
===========================================
+ Coverage    51.37%   51.47%   +0.10%
===========================================
  Files          166      177      +11
  Lines         9351     9665     +314
===========================================
+ Hits          4804     4975     +171
- Misses        4547     4690     +143

Impacted Files
Coverage Δ

etna/transforms/math/statistics.py
64.24% <40.00%> (-1.05%)
:arrow_down:

etna/auto/pool/utils.py
25.00% <0.00%> (-75.00%)
:arrow_down:

etna/models/utils.py
11.11% <0.00%> (-72.23%)
:arrow_down:

etna/transforms/encoders/segment_encoder.py
45.83% <0.00%> (-54.17%)
:arrow_down:

etna/models/nn/rnn.py
46.73% <0.00%> (-53.27%)
:arrow_down:

etna/transforms/math/sklearn.py
30.46% <0.00%> (-40.63%)
:arrow_down:

etna/commands/resolvers.py
60.00% <0.00%> (-40.00%)
:arrow_down:

etna/models/tbats.py
53.33% <0.00%> (-38.34%)
:arrow_down:

etna/transforms/timestamp/date_flags.py
43.44% <0.00%> (-36.07%)
:arrow_down:

etna/models/nn/utils.py
48.90% <0.00%> (-34.31%)
:arrow_down:

... and 38 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Why is branch named issue-1080? Is it somehow connected to this issue?

Why is branch named issue-1080? Is it somehow connected to this issue?

No, it is typo


Group / Entry fetching & querying

Provide searching features for groups and entries.

Working as of 0.7.0: getEntryByID and getGroupByID on Archive.


Automated cherry pick of #8340: feat: add valid filter for cachedimage list

Cherry pick of #8340 on release/3.4.
#8340: feat: add valid filter for cachedimage list

Codecov Report

Merging #8341 into release/3.4 will decrease coverage by 2.67%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           release/3.4   #8341      +/-   ##
==============================================
- Coverage         6.22%   3.54%   -2.68%
==============================================
  Files              759     303     -456
  Lines           117145   62242   -54903
==============================================
- Hits              7289    2205    -5084
+ Misses          109197   59884   -49313
+ Partials           659     153     -506

Flag
Coverage Δ

#aFlag
3.54% <0.00%> (-2.68%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/appsrv/stats.go
0.00% <0.00%> (ø)

pkg/compute/models/buckets.go
1.10% <0.00%> (+0.03%)
:arrow_up:

pkg/compute/models/cachedimages.go
1.70% <0.00%> (-0.11%)
:arrow_down:

pkg/compute/models/capabilities.go
0.00% <0.00%> (ø)

pkg/compute/models/cloudaccounts.go
0.48% <0.00%> (-4.66%)
:arrow_down:

pkg/compute/models/dbinstance_skus.go
2.83% <0.00%> (-0.02%)
:arrow_down:

pkg/compute/models/dns_recordsets.go
1.82% <0.00%> (-0.24%)
:arrow_down:

pkg/compute/models/dns_zones.go
1.62% <0.00%> (-0.06%)
:arrow_down:

pkg/compute/models/elasticips.go
1.08% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/models/guest_actions.go
0.00% <0.00%> (ø)

... and 455 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31de731...8bc52ce. Read the comment docs.

/lgtm
/approve


OrientDB 3.0.34 deadlocked

OrientDB Version: 3.0.34
Java Version: 1.11
OS: Linux
Expected behavior
OrientDB doesn't deadlock
Actual behavior
After some weeks running Orientdb has deadlocked
Steps to reproduce
Thread dump attached
orient-server-boot.log

Taking  a look at the logs I saw this. Just after restarting OrientDB this exception appears and OrientDB in unresponsive. Even if 3.0.34 is not as maintained as 3.1.x please review this just in case it also happens in 3.1.x. I have the feeling that an unhandled exception doesn't free a lock and provokes the deadlock.
com.orientechnologies.orient.core.exception.OStorageException: Exception during execution of atomic operation inside of storage database_name
at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:157)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage$2.run(OAbstractPaginatedStorage.java:4884)
at com.orientechnologies.orient.core.Orient$3.run(Orient.java:419)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)
Caused by: java.lang.NullPointerException
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeCollectionManagerShared.tryDelete(OSBTreeCollectionManagerShared.java:198)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage$2.lambda$run$0(OAbstractPaginatedStorage.java:4885)
at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:153)
... 4 more
Error during deletion of rid bag
com.orientechnologies.orient.core.exception.OStorageException: Exception during execution of atomic operation inside of storage database_name
at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:157)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage$2.run(OAbstractPaginatedStorage.java:4884)
at com.orientechnologies.orient.core.Orient$3.run(Orient.java:419)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)
Caused by: java.lang.NullPointerException
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeCollectionManagerShared.tryDelete(OSBTreeCollectionManagerShared.java:198)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage$2.lambda$run$0(OAbstractPaginatedStorage.java:4885)
at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:153)
... 4 more

Taking  a look at the logs I saw this. Just after restarting OrientDB this exception appears and OrientDB in unresponsive. Even if 3.0.34 is not as maintained as 3.1.x please review this just in case it also happens in 3.1.x. I have the feeling that an unhandled exception doesn't free a lock and provokes the deadlock.
com.orientechnologies.orient.core.exception.OStorageException: Exception during execution of atomic operation inside of storage database_name
at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:157)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage$2.run(OAbstractPaginatedStorage.java:4884)
at com.orientechnologies.orient.core.Orient$3.run(Orient.java:419)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)
Caused by: java.lang.NullPointerException
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeCollectionManagerShared.tryDelete(OSBTreeCollectionManagerShared.java:198)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage$2.lambda$run$0(OAbstractPaginatedStorage.java:4885)
at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:153)
... 4 more
Error during deletion of rid bag
com.orientechnologies.orient.core.exception.OStorageException: Exception during execution of atomic operation inside of storage database_name
at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:157)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage$2.run(OAbstractPaginatedStorage.java:4884)
at com.orientechnologies.orient.core.Orient$3.run(Orient.java:419)
at java.util.TimerThread.mainLoop(Timer.java:555)
at java.util.TimerThread.run(Timer.java:505)
Caused by: java.lang.NullPointerException
at com.orientechnologies.orient.core.storage.ridbag.sbtree.OSBTreeCollectionManagerShared.tryDelete(OSBTreeCollectionManagerShared.java:198)
at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage$2.lambda$run$0(OAbstractPaginatedStorage.java:4885)
at com.orientechnologies.orient.core.storage.impl.local.paginated.atomicoperations.OAtomicOperationsManager.executeInsideAtomicOperation(OAtomicOperationsManager.java:153)
... 4 more

Duplicated of https://github.com/orientechnologies/orientdb/issues/9400

Duplicated of https://github.com/orientechnologies/orientdb/issues/9400


Update DG and PPP

Changes made:

Fix the section header for the authors section in the DG
Updated the hyperlinks for Nicholas' PPP

Codecov Report

Merging #316 (a9c8963) into v1.4-UG-DG (f90d799) will increase coverage by 2.78%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             v1.4-UG-DG     #316      +/-   ##
================================================
+ Coverage         69.97%   72.76%   +2.78%
- Complexity          909     1084     +175
================================================
  Files               139      139
  Lines              2891     3260     +369
  Branches            299      385      +86
================================================
+ Hits               2023     2372     +349
- Misses              761      771      +10
- Partials            107      117      +10

Impacted Files
Coverage Δ

src/main/java/seedu/rc4hdb/model/StringField.java
71.42% <0.00%> (-8.58%)
:arrow_down:

.../java/seedu/rc4hdb/model/resident/fields/Room.java
92.30% <0.00%> (-7.70%)
:arrow_down:

...rc4hdb/model/venues/booking/fields/HourPeriod.java
82.14% <0.00%> (-6.75%)
:arrow_down:

...hdb/logic/commands/filecommands/ImportCommand.java
95.23% <0.00%> (-4.77%)
:arrow_down:

...ain/java/seedu/rc4hdb/model/resident/Resident.java
94.52% <0.00%> (-3.73%)
:arrow_down:

...logic/parser/commandparsers/EditCommandParser.java
92.00% <0.00%> (-1.94%)
:arrow_down:

src/main/java/seedu/rc4hdb/model/venues/Venue.java
82.08% <0.00%> (-0.52%)
:arrow_down:

...nds/residentcommands/ColumnManipulatorCommand.java
81.94% <0.00%> (-0.41%)
:arrow_down:

...gic/parser/commandparsers/FilterCommandParser.java
93.61% <0.00%> (-0.14%)
:arrow_down:

...gic/parser/commandparsers/RemoveCommandParser.java
93.61% <0.00%> (-0.14%)
:arrow_down:

... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


python3.12 support

Use importlib.resources instead of the deprecated pkg_resources.
The load_dsdl() step fails on Python3.12 since pkg_resources is being depreciated. This PR implements using the newer importlib.resources.files method to get the dsdl_path while still allowing to fallback to the older pkg_resources approach.

Error message when running the "dump all" example (without this PR, Ubuntu 22.04)
DSDL load exception: No module named 'pkg_resources'
Traceback (most recent call last):
  File "/home/tobias/Documents/sw-rid-beacon/main.py", line 6, in <module>
    import dronecan, time, math
  File "/home/tobias/Documents/sw-rid-beacon/venv/lib/python3.12/site-packages/dronecan/__init__.py", line 226, in <module>
    import dronecan.app as app
  File "/home/tobias/Documents/sw-rid-beacon/venv/lib/python3.12/site-packages/dronecan/app/__init__.py", line 12, in <module>
    from . import dynamic_node_id
  File "/home/tobias/Documents/sw-rid-beacon/venv/lib/python3.12/site-packages/dronecan/app/dynamic_node_id.py", line 25, in <module>
    class CentralizedServer(object):
  File "/home/tobias/Documents/sw-rid-beacon/venv/lib/python3.12/site-packages/dronecan/app/dynamic_node_id.py", line 26, in CentralizedServer
    QUERY_TIMEOUT = uavcan.protocol.dynamic_node_id.Allocation().FOLLOWUP_TIMEOUT_MS / 1000  # @UndefinedVariable
                    ^^^^^^^^^^^^^^^
AttributeError: 'Namespace' object has no attribute 'protocol'

does this still work in older python/s?

Yes, I was however only able to test it with 3.9 as I have currently no easy access to older versions


spyder 5.0.1 malfunction and time lag between typing and response; or my bad?

Description of your problem
Hi team! Thanks for your efforts.
Look! I use to work with spyder 4.2 but I uploaded to the new 5.0.1, and now a huge lag between typing and spyder screen response appears. The lag is sometimes so big that the whole pc screen gets dark, even if I use another software, e.g., firefox. It takes so much time to take back the control of the keyboard.
It's impossible to work.
What steps will reproduce the problem?

when editing code lines, like commenting some library. All methods and functions associated to that library highlight in red (that's normal), but then It's impossible to write any line, or even to move the cursor of either terminal and spyder
when commenting some heading line of a code block, like commenting fig, ax = plt.subplots(). It generates the same effect described above. Just when uncomment that line everything comes to normal

What is the expected output? What do you see instead?
Just working normally with previous versions. Uncommenting a line shouldn't interfere with writing, or even more with the whole PC's procceses
Please provide any additional information below
Name                    Version                   Build  Channel
pyls-spyder               0.3.2              pyhd3eb1b0_0
spyder                    5.0.1            py38h578d9bd_0    conda-forge
spyder-kernels            2.0.2            py38h578d9bd_0    conda-forge
Versions and main components

Spyder Version:  5.0.1
Python Version: 3.8
Operating system: Ubuntu Mate

Hey @JohannHM, thanks for reporting. If you downgrade to Spyder 4.2.5 again, is the problem fixed?

Wow!!!
@ccordoba12, I have several envs in my conda, I upgraded spyder in one of them, just for testing it (off course it was the worst idea, ever). Then when I started to work in my usual environments (4.2), my spyders in those envs completely crashed up!!! The screens of spyder in such envs were a mess: dissorted screen effect, cursor vanished, double or triple tool bars all around the screen!!!! That's why my choice was to totally upgrade to the new version in all envs.
Are your sure that downgrading is the solution?

Dear @ccordoba12
Apologize for bothering you. What should be your expertise about both problems above related?

spyder 5.0.1 slow down typing when block heading are commented. Relevant when scripting.
downgrade spyder version mess the screens up in all environments
Thanks for your recommendation.

This is discussed on issue spyder-ide/spyder#15631. Please check it for some helpful pointers.


[Security] Add adaptive_application_controls commands

Description
[Security] Add adaptive_application_controls commands
Add adaptive_application_controls commands, helps you control which applications can run on your Azure and non-Azure machines (Windows and Linux)
Testing Guide
Users can get a list, or a single adaptive application control groups:
az adaptive_application_controls list
az security adaptive_application_controls show --group-name GROUP1
Tests are included, use:  azdev test security test_adaptive_application_controls --live
This checklist is used to make sure that common guidelines for a pull request are followed.

[*] The PR title and description has followed the guideline in Submitting Pull Requests.

[*] I adhere to the Command Guidelines.

@janinezhang,
@yonzhan kindly referred me to help expedite the processing of this PR in time for S172 milestone.
I made sure all tests passed as required, thank you for your help.

Security

@ariklin Could you fix conflicting files first?

@ariklin we are reviewing this PR right now, could you please help deal with the conflicting files first?


Too many request error

i have installed plugin in ghidra after pressing ctrl+j clicking on the function , it shows the too many request error

Hi @tanishqdiwan111 ! I think that error is due to the number of calls you are making to OpenAI. Does the error always happen? Did you try after a bit to see if it disappeared?

yes this error always happen and i have tried after few minutes but it always gives too many request error
sometimes ghidra pops up with "multiple actions have been mapped to ctrl+j actions that can be enabled at the same time should be mapped to different keys" window

Hi @tanishqdiwan111, AFAIK the "multiple actions have been mapped to ctrl+j actions" error happens when you run the script from the script manager multiple times. You can restart your ghidra instance and run it just once. Also, the "too many request" error happens when your openai api_key has reached its usage limit. Try creating a new key or a key from a new account.

i tried a new key with new openai account but it still showing error
Collecting data about function.
Sending data to OpenAI api.
Error in accessing api: Too Many Requests
Invalid output from api
i also updated this in bashrc "export OPENAI_API_KEY="with my key"


feat(ec2): design dual stack vpc

Showing this here.

Merged into upstream here https://github.com/aws/aws-cdk/pull/28480.


Limiting links to pages, but not actual pages?

I'd like to let the paginator page through all my posts, but I don't want it to generate a bunch of "posts - page N" links on the home page. I do want it to let me use next/previous links in each page. Is there any way to limit just the generation of direct page links? Thanks!

I don't know if it's possible, but if the paginator could imbue the pages variable with the count of both actual explicit pages, and separately the number that were generated by the paginator, that would make it possible to do what I want to do.


Laggy video in iPhone

Firstly, thanks for the package, it's awesome.
I'm facing an issue the video stream from iPhone is extremely laggy but iPad is working fine. with the same code.
iPhone 12 with iOS versions 15.5 and 16.6
iPad 2020 with iPadOS version 16.5.1
Pictures below show that when iPhone joins a room, the RAM goes up to 600mbs+, while iPad stays at 170mbs+

First guess is to check your video quality. iPhone camera native resolution and frame rate are really too much for realtime streaming, so you should set it thoughtfully. What resolution and frame rate do you capture from camera and what resolution (or resolutions) do you encode and stream?
Here are two runs of same code on same device I've just done, but with different video quality settings:

Thanks for quick response @fedulvtubudul
Here are the resolution and frame rate which I captured from iPhone's camera. In the encoding part, I leave it at Nil.
This setup works well with the mediasoup_ios_client.
Could you tell me which resolution, frame rate, and encoded resolution did you use?

640x360 @20fps is not that much to be a problem. Have you tried to examine your app with Instruments and see where all the memory goes?


Dealing with localization for existing, pre-translated entries

From Pat:
It took me a while, but I found the list of cases that we transferred to PPedia from the Bertelsmann Foundation's 'vitalizing democracy' project in 2013. The key documents can be found in Partnerhships/Bertelsmann/ https://drive.google.com/open?id=1xHbad0uNz2PnY8T38uK6WYDcEdtuBz-_
While doing this, it finally dawned on me that these cases were only submitted in English. The agreement was that they wanted us to build the German-Language functionality so that their users could access the site and translate things into German if they chose to. There is a pdf in the folder of a brief article describing what we did.  This appears to be the most up-to-date list of cases that we added to PPedia.
https://drive.google.com/open?id=1XNajmcPyzt9ovTxy9wgTW2I5l9DUqyP4-ceG5N_MQaU
(@plscully - does the above mean we don't have an issue with the german list because these were only submitted in english?)
One last thing about this -- We tried to identify this and other cases that were in both English and German by inserting this tagline at the start of the narrative sections: "Note: a German translation of this case study is available at [url] " ...
Here examples of cases that were first submitted in Italian, and an RA then translated them into English - https://drive.google.com/open?id=1HuBg5KNKMCFRRssGbLhiHh3oTOb1P7KH
Last but not least, this report from 2013 includes lists of lots of cases that were already on the site, and that students at the U of Bremen then translated into other languages https://drive.google.com/open?id=1VmpGHSS-smIhq1wHlQF5LLMk7Hx7joKH

@jesicarson RE: the list of cases from the german foundation for the "vitalizing democracy" project -- Yes, I am pretty sure we don't have an issue with those cases b/c they were entered in English. However, I know there were some cases (maybe 2-dozen or so?) that were entered using the German-language interface on the Drupal site.

here is the spreadsheet that outlines all of the duplicated cases where multiple languages were added pre-translation system: https://docs.google.com/spreadsheets/d/1BhDy89zVHVmEeu3JJyi2vAdysDfPvz2y-tUW7iw2Fj8/edit#gid=643998910

Completed merging 111 entries from the excel sheet. Highlighted the merged rows with green.

Needs to translate the entries that column A isn't null too.


"Add your client" link is broken

go to https://matrix.to/
click "Add your client" in the footer
observe 404

Thanks, it's fixed by https://github.com/matrix-org/matrix.to/pull/159, but just hasn't been deployed yet.


More off-by-one errors in bitmap contains_range

The CRoaring code uses an exclusive u32 range for the implementaiton of
a bitset container's contains_range function.
Had to think a bit about the best way to make it work, if you can think of a prettier way to write any of it, let me know.
Fixes #238

I think I thought of a better way, by being inclusive at the bit-level only

bors merge

bors merge

Same here, no obvious reasons why the CI is stopped...
bors merge


StorageAuthenticator is broken

Evidently the auth mechanism does not care about token at all for REDIS and for GoogleStorageWrapper . More importantly,
GoogleStorageWrapper should not exist, it should be replaced with StorageWrapper which can then be used for anything.

This is fixed now.


compiler warning: "not return a value"

What is the issue you have?
const typename object_t::key_type& key() const
nlohmann/json.hpp:11996:5: warning: non-void function does not return a value in all control paths [-Wreturn-type]
static ReferenceType get_ref_impl(ThisType& obj)
nlohmann/json.hpp:20017:5: warning: non-void function does not return a value in all control paths [-Wreturn-type]
reference operator[](T* key)
nlohmann/json.hpp:20925:5: warning: non-void function does not return a value in all control paths [-Wreturn-type]
const_reference operator[](const typename object_t::key_type& key) const
nlohmann/json.hpp:20877:5: warning: non-void function does not return a value in all control paths [-Wreturn-type]
and many more... mostly looking like:
    ReturnType fooBar( xxx )
    {
        if (JSON_HEDLEY_LIKELY( xxx ))
        {
          return xxx;
        }

        JSON_THROW( xxx );
    }

Please describe the steps to reproduce the issue.

use custom JSON_THROW_USER without exceptions
compile

What is the expected behavior?
no warnings
Which compiler and operating system are you using?

Compiler: clang
Operating system: ubuntu 21.04

Which version of the library did you use?

[x] latest release version 3.9.1
[ ] other release - please state the version: ___
[ ] the develop branch

i'm not sure if this is intentional behavior. however, it floods the compiler output.
is there a trick to keep in mind when adding your own JSON_THROW?
ps: thanks for the awesome library. great work

Which version of clang are you using?
Also, can you provide a minimal code sample that reproduces this issue?

I recently fixed something similar in https://github.com/nlohmann/json/pull/2898 which is not yet merged.

From the documentation of JSON_THROW_USER:

Note that JSON_THROW_USER should leave the current scope (e.g., by throwing or aborting), as continuing after it may yield undefined behavior.

The warnings you describe only occur if you do not leave the scope, but let the control flow reach its end without returning a value. There is nothing we can do in this situation - there are no default values to return in case of exceptions.


[FEATURE] - Expand session functionality to include which programming language is allowed.

Reference Issues
No response
Summary
With the addition of a new language, an instructor should be allowed to determine which specific languages are allowed for a specific session.
Entails:

new database table AllowedLanguageInSession with reference to a session and a language enum.

many-to-many relation.

Update API to support language specification of a session.

Unresolved questions
No response
Definition of Done
When session is modified throughout the backend, the support language specification.

Fixed in #106


Support custom connection arguments for pgx driver in sql.Open("pgx")

Description
We'd like to use pgBouncer for managing a our postgres connection pool backend numbers in transaction pool mode.
Unfortunately with prepared statements, the statement ID and subsequent query can get proxy'd through different connections, which doesn't work for postgres.  The solution, which everyone seems to have implemented, (including twitch https://blog.twitch.tv/en/2016/10/11/how-twitch-uses-postgresql-c34aa9e56f58/ see binary parameters ) is to force the px driver into "prefer_simple_protocol", which makes a single round trip to the db per statement.  Downside is losing binary prep statements, but some upsides as well... (single round trip, and works with pgBouncer and other pools).
he vendored pgx driver in the latest nakama has support for this now.  Either through configuration the driver with DriverConfig, or passing an additional connection argument to the driver.  In this case prefer_simple_protocol.
I'm up for a variety of ways to implement this, as it seems pretty basic to support something like this in db.go. I'm not sure if it would be best done in the connection URI string as a named param, or explicitly through something like config.GetDatabase() in the nakama configMap, and then initializing the pgx driver with a DriverConfig.
Thoughts?

I guess the other option would be to use statement_cache_mode=describe as well in the pgx driver,  https://github.com/jackc/pgx/blob/cf0de913ee8facdfef0a7611d41cd67522b12c76/conn.go#L123-L127 .
Either way, there's a need to get this into the pgx driver in some shape or form.  Open to implement in the best way advised.

@jordo Thanks for the research. I'm not familiar with the "statement_cache_mode" option because we've never had to deploy a production game with pgBouncer so far. This statement_cache_mode=describe is it expected to be passed in through the database DSN uri?

This statement_cache_mode=describe is it expected to be passed in through the database DSN uri?

That's correct.  This is supported in the uri with the current pgx version that nakama is using.    Both prefer_simple_protocol or statement_cache_mode=describe are available as DSN uri parameters to the pgx driver, or in in the DriverConfig structure if you initialize the pgx driver with a config struct.
The current connection pooling in sql.go/nakama (maxIdle, maxOpen) isn't going to be as efficient if we deploy multiple nakama application servers as each server instance's pool config is going to be configured independently.  This makes horizontally scaling on demand a little more trickier to maximize utilization of available/reserved postgres backends ( without overloading postgres with too many connections/pids).  I imagine this is probably the number 1 use case for pgBouncer.  If we know that our optimal # of postgres backends is say 100, then we configure pgBouncer to just utilize 100 connections, and can scale our application servers in front of the connection pooler without too much worry or reconfiguration.
As far as passing any config items to pgx initialization, I'm open to achieving this is whatever was is preferrable.

@jordo If you can pass "statement_cache_mode=describe" and "prefer_simple_protocol=true" can be passed as part of the DSN uri parameters I don't think any change needs to happen in Nakama for this to work. You simply need to pass it through the start up option in the server: --database.address "somedsn?....etc". Please reopen if this requires a code change.

This does look like it gets passed through correctly to pgx.  So we can use the database.address config.  Thanks for looking into.


Access to Locale in linkResolver

Hi,
My problem is how can as handle links in RichText base on the app i18 locale.
I have one single type  - homepage, repetable types product and page.
If is page have has default locale all works fine (/products/one), but for example for en locale i need page in in this format /en/products/one.
I have this link resolver :
if (doc.type === 'home') { return '/'}
for product type i have this :
if (doc.type === 'product') {return '/products/' + doc.uid}
Is there a way how can I access app locale in linkResolver?

This is probably a question for the official Prismic library teams, but you should be able to access the language of the document through doc.lang. I found this example, which might help; https://github.com/levimykel/prismic-i18n-example/blob/master/prismic-configuration.js

I have the same question. When using i18n I need to be able to call the method app.localePath() to convert links into the correct version for the current locale. The problem is "app" is not available within the link resolver function.
Prior to using the prismic-module my solution was to make app available by setting up the link resolver as a method on Vue.prototype as below
export default ({ app }) => { 	Vue.prototype.$linkResolver = function(doc, parent) {          // app.locale() used here 	} }
This would still work but rather than have to call the link-resolver manually in my templates I really want to be able to use the  tag but somehow be able to access 'app' within the link resolver method.
Could it be possible for  to pass through the context as an additional parameter along with the doc when is calling the link resolver?


Fix @available() use in C++ code

Replace it with __builtin_available(). Fix #717.

Thanks a lot!
This didn't fix the other compilation error for me with Xcode 13 (I take it that it did work for you), so I opted for 07631894 instead. But this PR helped me understand what the actual problem was, much appreciated!

Looks like it worked for Xcode 12, but not 13.


(Chore) Fix dead link

Fixes dead link in README.md. HuggingFace model names now use kebab-case

Thanks


pybullet.error: number of forces should match the joint indices

Hi!
See attached picture for refrence.

(1) You can use Python 3
In walking_ simulation.py
Then put all the Del get_ XX [:] with get_ xx.clear ()
(2) Or restart walking_ simulation.py
I have this kind of mistake sometimes

Thanks Python 3 solved the error. 👍
But when I run: rosservice call /robot_mode "cmd: 1"
Nothing happends.


feat: destroy resource

Need to clean this up a bit but the general idea is there.

@birme I've resolved all conflicts, please take a look


True note without link

As requested in #1 here comes the feature to hide URL when sharing notes to Mastodon (if the Toot is shorter than TOOT_LENGTH).

No problem, I have no schedule 😄


Rename "export" to "release" in Key Vault Keys package (Secure Key Release)

Secure key release will be changing the export API and enum to release. We must change all our export-related APIs accordingly. Keep an eye on the swagger for when that change occurs.

@heaths Can you please update the issue title and description to reflect which Key Vault package are we talking about here? A pointer to the export API either in the source code or in the API reference docs would help as well

Maor is currently assigned to the update and cleanup of the Key Vault Admin API. We won't be releasing export/release this month though, so we will likely push this issue for a later date, but in the mean time I'll keep this issue open so Maor can decide.

Maor is currently assigned to the update and cleanup of the Key Vault Admin API. We won't be releasing export/release this month though, so we will likely push this issue for a later date, but in the mean time I'll keep this issue open so Maor can decide.

FWIW, I'm closing this issue because "export" and "release" are actually separate (but similar). I closed .NET's and forgot I opened these across languages; however, both of these - if implemented - should be moved out of the February GA as they are slated for 7.3-preview service version.

FWIW, I'm closing this issue because "export" and "release" are actually separate (but similar). I closed .NET's and forgot I opened these across languages; however, both of these - if implemented - should be moved out of the February GA as they are slated for 7.3-preview service version.


Lost my entire history

Describe the bug
I started a new test project and when I came back to this one, it was completely gone. I am receiving an import error. Additionally, I signed up for the $50.00 per month sub and it's behaving as if I have no subscription at all.

Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-c5dnrd
Steps to reproduce

Sign in.
Navigate to history.

Expected behavior
Existing conversation and chat should be present.
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 78822580,
  "usedJSHeapSize": 71397996,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = ds-prime
Chat ID = 9175abbf66fe

Additional context
Error:
An unknown error occured while running an action.

@kc0tlh email sent. Thank you.


PackagesNotFoundError when install ADCME

There is an error when I install ADCME in Julia 1.0. I need help. Thanks.
│ PackagesNotFoundError: The following packages are not available from current channels:
│
│   - zip
│
│ Current channels:
│
│   - https://repo.anaconda.com/pkgs/main/win-64
│   - https://repo.anaconda.com/pkgs/main/noarch
│   - https://repo.anaconda.com/pkgs/r/win-64
│   - https://repo.anaconda.com/pkgs/r/noarch
│   - https://repo.anaconda.com/pkgs/msys2/win-64
│   - https://repo.anaconda.com/pkgs/msys2/noarch
│
│ To search for alternate channels that may provide the conda package you're
│ looking for, navigate to

Are you using Windows? Unfortunately, the current version does not support windows. I’ll add support for the next version.

That's good. Thank you.

Hi @zoumuda , the latest version (0.5.3) now supports Windows. Here is a video how to install  and configure it on Windows: https://youtu.be/Vsc_dpyOD6k

Hi @zoumuda , the latest version (0.5.3) now supports Windows. Here is a video how to install and configure it on Windows: https://youtu.be/Vsc_dpyOD6k

Thank you so much for you kind help.


tmp fix: skip assert state root non zero in genesis

Motivation
Assertion that state root is non zero is flaky for layers 0-1.
Changes
Skip this assertion for layers 0-1.
Test Plan
This makes a test not flaky anymore.

bors merge

@barakshani

I think it is better to revert the changes than skipping the test.

I'm not skipping the entire test, I'm only skipping the assertion that the state root isn't empty during layers zero and one.
This is the quickest way to allow people to merge again, at a rather low (temporary) cost.
I'll continue to investigate.


Where is playlist-icons.js ?

See the dist branch

It's in the dist branch indeed. I've updated the readme with the correct location.


"Click Here" link display in CONTRIBUTING.md

markdown for 'click here' links in the countribution file is incorrect, and needs to be fixed to display correctly. I will take care of this

fixed and pull request submitted.


Proxy protocol listener uses exceptions on the data plane

As part of our effort to remove data plane exceptions (@asraa @yanavlasov), we probably should fix the explicit usage of exceptions in this extension.

See https://github.com/envoyproxy/envoy/blob/master/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc for source

I'm interested

Thanks @arctdav! Please tag me on a PR, would love to see.
We are using absl::Status, but other filters use their own state class like https://github.com/envoyproxy/envoy/blob/78eaac391b519a69900ebcdccea668f690593e9a/source/extensions/filters/listener/tls_inspector/tls_inspector.h#L39

Thanks, I will. I am a true beginner and need a bit of time to refresh my memory of C++ again.

@htuch, by fix the explicit usage of exceptions in this extension, do I change throw EnvoyException("failed to read proxy protocol"); into something? Like "try catch"? Sorry C++ isn't my strong suit.

Hi, I would love to help fixing this problem as well. @htuch I would appreciate if you could be more specific on what you mean by fixing "the explicit usage of exceptions." Do you want us to use another way of catching on error other than exceptions? Thank you!
Hi @arctdav I believe you use try-catch when you are testing the exceptions on the driver file.

Hey @mrSeoDavid @arctdav I might be able to offer a suggestion on where to start!
The exceptions are caught in a try/catch block in Filter::onRead() here https://github.com/envoyproxy/envoy/blob/f0ebefc2a36746dbf12301d3c258e2f1b66cfe82/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc#L44
You could instead have onReadWorker() return a status (which you could define yourself, or you can use absl::Status), and handle an error status like exceptions are handling in the catch block. This would mean replacing throw EnvoyException(...) to return Status::Error. (This status class you define/extend may or may not need to hold more information, I'm not sure how many distinct errors there are in the filter code).
You can see this L4 filter for an example state. It's methods return ParseState, and one of the parse states is an Error, which is handled https://github.com/envoyproxy/envoy/blob/f0ebefc2a36746dbf12301d3c258e2f1b66cfe82/source/extensions/filters/listener/tls_inspector/tls_inspector.h#L39

@mrSeoDavid please go ahead to handle this issue.

@htuch I wanna work on this issue. Please assign this to me and since i am new contributor so please guide me through this.

@asraa Thank you so much for your help! I understood everything, I'll get on the work.

@asraa Quick question, for the onReadWorker() method, I was able to make it return a state instead of the throwing exceptions.
However, for all the other methods who are throwing exceptions as well, do I need just need to change these throwing exceptions as just returning the state? I don't think this will work for the methods that are already assigned to return other types like "lenV2Address" method as it is assigned to return size_t values in the first place.
Then, am I supposed to make new methods that will tests individual methods just like how the "onRead()" method is testing "onReadWorker()" method? Thanks a lot!

I don't think this will work for the methods that are already assigned to return other types like "lenV2Address" method as it is assigned to return size_t values in the first place.

Right, I see. We encountered this as well from exception removal proof of concepts, and ended up using absl::StatusOr<size_t> that either returns an error status or a size_t if there is no error. I don't know if this is the best case for this scenario. Here are some general options: maybe you return absl::optional<int> with an int if success, nullopt if failed; or return -1 for an error; or decide to use statusor (but this is would mean mapping error states to statusor errors); or as maybe just another option, you can use a union type?
I suggest tackling this piece-meal. Looking at bool ReadProxyHeader, I think exception messages could be changes to trace log statements, and false could be returned. Looking at size_t lenV2Address, maybe an absl::optional<int>?
I would caution -- remember that throw will immediately stop any following execution, so when you replace something with throw, remember things need to be returned up to the try/catch.

@asraa thank you so much for your detailed suggestions and explanation. This is what I have done so far: for all of the methods that had void return type in the first place, I've created an enum class in the .h file and made these methods return enum values that represent a failure.
For the methods that were originally designated to return boolean, I've followed your suggestion and changed the exception messages to trace log statements and returned false. However, I did not know how to write the trace log statement, so after googling, I wrote this way:        "TRACE(_T(an exception message))" Is this the right way to do it? If so, do I have to #include anything in this file?
For the lenV2Address, don't we need the method's header to be "absl::optional<size_t> Filter::lenV2Address(char* but)"? not absl::optional as we are returning a size_t value or a std::nullopt?
Lastly, if I made methods like parseV2Header and parseV1Header return values of enum class, don't I need to change the code for other methods or class that use this method in detecting an error? Just like how the onRead() method's try-catch code changed to an if-statement code like you've suggested in the https://github.com/envoyproxy/envoy/issues/11044#issuecomment-624623421.
Once again, thank you so much for your help.

However, I did not know how to write the trace log statement, so after googling, I wrote this way: "TRACE(_T(an exception message))"

Envoy has log message macros. You can use format strings in them too. https://github.com/envoyproxy/envoy/blob/10c755e9d9b8acd7cf1702a4f49dbcbdf0696198/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc#L30

For the lenV2Address, don't we need the method's header to be "absl::optional<size_t> Filter::lenV2Address(char* but)"?

Yes

don't I need to change the code for other methods or class that use this method in detecting an error?

Yes you will need to propagate the error back through the methods that call them. I think readProxyHeader calls them. So you'll need to return early if readProxyHeader fails with the previous exceptions, and it looks like it already returns early if the value is false, so replacing a parse exception with false and propagating false back will be ok.
https://github.com/envoyproxy/envoy/blob/10c755e9d9b8acd7cf1702a4f49dbcbdf0696198/source/extensions/filters/listener/proxy_protocol/proxy_protocol.cc#L56
Feel free to ping me, it might just be easier to make a draft PR I can comment on the diffs

/cc @arthuryan-k


data() method when component extended

Version
2.6.11
Reproduction link
https://github.com/surjit/vue-test/commit/e7d262d421106c05774bea5b5f96f94f68c3e2fb
Steps to reproduce
npm run server
and Look into console
What is expected?
I'm expecting test_b should be object as test
CreateEdit.vue line 8,7
What is actually happening?
Now, It undefined

I'm trying to get route resolve working as the way Angular does

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.

My forum account on hold, not sure why? username surjitsidhu


/image doesn't appear to work

I too got a 500, when requesting the path with npm request.
The solution is to request the url with an Accept header containing image/webp
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,/;q=0.8
Then httpbin returned an image
		"pathname": "/image",
		"type": "image/webp",
		"statusCode": 200,
		"statusMessage": "OK",
		"headers": {
			"content-type": "image/webp",
			"content-length": 10568
		}

I am not sure whether this is right or wrong, but:
returns nothing curl http://httpbin.org/image
get something curl --header "Accept:text/html,image/webp,*/*;q=0.8" http://httpbin.org/image

The problem was related to attempting to access the accept header when there was no accept header.  I chose to return a default media type (image/png) if no accept header was provided.  Is there any reason anyone feels we should return 406 instead?

How about 300 Multiple Choices ? I am not sure how "serve several equivalent contents for a given URI" really works (source https://developer.mozilla.org/en-US/docs/Web/HTTP/Content_negotiation)

@eerne We could do that, but there are no standard media types for returning the available choices and I'm pretty sure no-one wants to start parsing link headers.  It would be nice to stick to the principle of least surprise.  If someone asks httpbin for an image, I'm assuming they want an image back, regardless of whether they bothered to set the accept header or not.  If you care about the format, then either set the accept header or use one of the variant specific resources.


Set phoneNumber attribute for billTo and shipTo on AIM requests.

The billTo->phoneNumber attribute for AIM requests is required in some situations. Without it an error is returned that states "Phone is required"
This PR supports setting these attributes via the standard omnipay method calls.

From the XML specs:

phoneNumber - Phone number associated with customer’s billing address.

(in case anyone wondered where the shipping phone number went)