Why no { Component } import?

I looked at your example and saw 1 strange thing: where is Component import? Extending React.Component is pretty common case, no?
import React from 'react'

export default class Component {
  render() {
    /* this part will be transpiled by babel itself as usual */
    return React.createElement('div')
  }
}

If you want to extend Component you should import it by yourself.
This plugin only about createElement and JSX.

Added some note in README.

@olegafx If you still need it, you can implement it yourself, its not that hard.
Here is an example (for babel v5.x):
        var reactImportDeclaration = t.importDeclaration([
          t.importDefaultSpecifier(t.identifier('React')),
          t.importSpecifier(t.identifier('Component'), t.identifier('Component')),
          t.importSpecifier(t.identifier('PropTypes'), t.identifier('PropTypes'))
        ], t.literal('react'))

take a look at the babel source, here and here


only sleep in wait() if the result is not true

there is no need to sleep if the result is already true, so save some time

This might actually be anti-optimization, because if cycle iteration count while you wait for $result to become true is >1, then you actually loose time by checking $result again inside cycle.

@aik099 if the result is true, the loop will exit

@aik099 if the result is true, the loop will exit

That is how it works currently. But what I'm saying that extra code to check same exit condition only doubles code run time which is spending more time then is saved by calling usleep extra time after $result is true.

So you suggesting the if statement will take longer than 1/10s
On May 30, 2017 2:02:48 PM GMT+05:45, Alexander Obuhovich<EMAIL_ADDRESS>wrote:

@aik099 if the result is true, the loop will exit

That is how it works currently. But what I'm saying that extra code to
check same exit condition only doubles code run time which is spending
more time then is saved by calling usleep extra time after $result is
true.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/minkphp/MinkSelenium2Driver/pull/270#issuecomment-304807654

It depends on how soon condition will become true. If element doesn't appear on the page for certain time, then total time spent on that extra IF execution might be close (I haven't measured really) to sleep time.
I think you'd better attach some benchmarks for cases with extra IF and without it with different waiting times (e.g. element appeared after X milliseconds, sleep time, extra if time, total time).

What about changing it around and having a while and not a do...while loop? Then there are the same amount of checks, but the loop only waits if the condition is not true. If the condition returns true strait away we save 1/10s

sorry $result need to be set of course


Fix banner nameko on shell

Adds tests on top of @yupeek's #444

thanks for the tests.

Thank you @ornoone!


Create a clean presentable markdown table

Ensure that all the information can be visualized in the readme in one a single  view

The open access table is now clean on clean-open-access-table branch. Also, I created the preprints and predatory journal tables. However, more details need to be added. Suggestions are welcome on what to capture in the tables.

Great work @wanjauk, thanks. Feel free to create a pull request and merge your changes to the main branch. I really appreciate your efforts.


Prewarm an audio element pool when connecting

This PR

creates an audio element pool
tries to play silent audio when connecting and triggers audioPlaybackFailed if that doesn't work
adds playback of silent pool audio nodes to startAudio

potentially fixes https://github.com/livekit/client-sdk-js/issues/589, but there are some caveats:

user still needs to click startAudio when first connecting (also this will fire a lot more now)
only works if users do not supply their own HTML element to the attach function, because we can only use prewarmed elements if we can choose which element it can be

is that due to us creating a bunch more audio elements ahead of time
yeah, the initiated elements still need to be "unlocked" with a user gesture at one point.

I'm wondering if this extra piece of code is worth only a partial fix to the issue.
I have the same reservation about this change.

Would using WebAudio help solve the case of attaching to existing audio elements too?
currently we're still adding actual audio elements (albeit muted) for attach calls in the webaudio path. I guess it would help as muted audio elements might not get blocked, but I'll have to do some tests to verify this


asp.net core signalr client issue with xamarin.forms

Hi,
In my xamarin forms project using Asp.Net Core SignalR version 1.1.0.
When I try to update to version 3.0.0 I am getting white screen can not access to login page.
All package that using at project are below
<PackageReference Include="Microsoft.AspNetCore.SignalR.Client">
      <Version>1.1.0</Version>
    </PackageReference>
    <PackageReference Include="Microsoft.Extensions.Caching.Memory">
      <Version>3.0.0</Version>
    </PackageReference>
    <PackageReference Include="NdefLibrary">
      <Version>4.1.0</Version>
    </PackageReference>
    <PackageReference Include="Prism.Core">
      <Version><IP_ADDRESS>7</Version>
    </PackageReference>
    <PackageReference Include="Prism.Forms">
      <Version><IP_ADDRESS>7</Version>
    </PackageReference>
    <PackageReference Include="Prism.Plugin.Popups">
      <Version><IP_ADDRESS>3</Version>
    </PackageReference>
    <PackageReference Include="Prism.Unity.Forms">
      <Version><IP_ADDRESS>7</Version>
    </PackageReference>
    <PackageReference Include="Rg.Plugins.Popup">
      <Version><IP_ADDRESS></Version>
    </PackageReference>
    <PackageReference Include="System.Buffers">
      <Version>4.5.0</Version>
    </PackageReference>
    <PackageReference Include="System.Memory">
      <Version>4.5.3</Version>
    </PackageReference>
    <PackageReference Include="Xam.Plugins.Notifier">
      <Version>3.0.1</Version>
    </PackageReference>
    <PackageReference Include="Xamarin.Android.Support.Design" Version="<IP_ADDRESS>" />
    <PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="<IP_ADDRESS>" />
    <PackageReference Include="Xamarin.Android.Support.v4" Version="<IP_ADDRESS>" />
    <PackageReference Include="Xamarin.Android.Support.v7.CardView" Version="<IP_ADDRESS>" />
    <PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" Version="<IP_ADDRESS>" />
    <PackageReference Include="Xamarin.Essentials">
      <Version>1.3.1</Version>
    </PackageReference>
    <PackageReference Include="Xamarin.Forms" Version="<IP_ADDRESS>5419" />
    <PackageReference Include="Xamarin.Forms.Visual.Material">
      <Version><IP_ADDRESS>5419</Version>
    </PackageReference>
    <PackageReference Include="Xamarin.HotReload">
      <Version>1.4.19</Version>
    </PackageReference>
    <PackageReference Include="ZXing.Net.Mobile">
      <Version>2.4.1</Version>
    </PackageReference>
    <PackageReference Include="ZXing.Net.Mobile.Forms">
      <Version>2.4.1</Version>
    </PackageReference>

Are you able to run the app with the debugger, set to catch all exceptions, and see if there's an exception being thrown?
There have been many API changes and probably various breaking changes between ASP.NET Core SignalR Core 1.1 and 3.0, so there could be some change in usage.
Also, can you show examples of how your app is using SignalR? That might help narrow down why you're seeing this problem.

No I can not event run it with the debugger. So no exception thrown.
this is the code block where I connect SignalR API and I also made the changes at here [signalr]. (https://docs.microsoft.com/en-US/aspnet/core/migration/22-to-30?view=aspnetcore-3.0&tabs=visual-studio#signalr-1) using NewtonJson

async void RunInMainThread()
        {
            // Code to run on the main thread
            var ip = "localhost";
            if (Device.RuntimePlatform == Device.Android)
                ip = ApplicationSettings.ExternalApiCorporateConnection;

            if (ApplicationSettings.HubConnection == null || ApplicationSettings.HubConnection.State == HubConnectionState.Disconnected)
            {
                ApplicationSettings.HubConnection = new HubConnectionBuilder()
                            .WithUrl($"{ip}/notification", options =>
                            {
                                options.AccessTokenProvider = () => Task.FromResult(ApplicationSettings.SignalRToken);

                            }).AddNewtonsoftJsonProtocol()
                            .Build();
                await Connect();

                ApplicationSettings.HubConnection.On<string>("RequestAssignment", (message) =>
                {
                    try
                    {
                        var finalMessage = $"{message}";

                        Device.BeginInvokeOnMainThread(() =>
                        {
                            // Write your code here
                            DialogService.DisplayAlertAsync("BİLGİ", message, "TAMAM");
                            CrossLocalNotifications.Current.Show("BİLGİ",message,101,DateTime.Now.AddSeconds(3));
                            //DependencyService.Get<IToastMessageService>().LongAlert(message);
                        });
                    }
                    catch (Exception ex)
                    {
                        var tt = ex;
                        throw;
                    }
                });
            }
        }

Running with the debugger or at least getting the exception (if there is one) would be very helpful.
Could you also enable logs on the client and server and share them? https://docs.microsoft.com/aspnet/core/signalr/diagnostics?view=aspnetcore-3.0

I added debug option both xamarin form and server but can not see any action on debug window. App even doest not make http call for SignalR connection. application does not fire up login page view model (using prism forms). On the startup app is entering only login page CTOR but login page viewmodel. If I get back the SignalR update its working fine. I am so confused so I removed SignalR for now.

I think we need to know more about what the actual error is. We're not aware of an issue here, though one may certainly exist.
Can you provide a simple runnable sample project that reproduces the problem?

In general, in Xamarin, you should be able to catch all exceptions if you set this setting:

Works fine for me on Windows in the Android emulator.

Re-added signalr and got some error as below but there is no Microsoft.AspNetCore.Http.Features, Version=<IP_ADDRESS> reference project in any my projects
System.TypeLoadException: 'Could not load type of field
'Microsoft.AspNetCore.Http.Features.Authentication.HttpAuthenticationFeature:<Handler>k__BackingField' (1)
due to: Could not resolve type with token 01000080 from typeref (
expected class 'Microsoft.AspNetCore.Http.Features.Authentication.IAuthenticationHandler' in assembly
'Microsoft.AspNetCore.Http.Features, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60')
assembly:Microsoft.AspNetCore.Http.Features, Version=<IP_ADDRESS>, Culture=neutral,
PublicKeyToken=adb9793829ddae60 type:Microsoft.AspNetCore.Http.Features.Authentication.IAuthenticationHandler
member:(null)'

and somes in the debug windows

**System.TypeLoadException:** 'Could not load type of field 'Microsoft.AspNetCore.Http.Features.Authentication.HttpAuthenticationFeature:<Handler>k__BackingField' (1) due to: Could not resolve type with token 01000080 from typeref (expected class 'Microsoft.AspNetCore.Http.Features.Authentication.IAuthenticationHandler' in assembly 'Microsoft.AspNetCore.Http.Features, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60') assembly:Microsoft.AspNetCore.Http.Features, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60 type:Microsoft.AspNetCore.Http.Features.Authentication.IAuthenticationHandler member:(null)'

**System.Reflection.TargetInvocationException:** 'Exception has been thrown by the target of an invocation.'

**Unity.ResolutionFailedException:** 'For more information add Diagnostic extension: Container.AddExtension(new Diagnostic())'

**Prism.Navigation.NavigationException:** 'An error occurred while resolving the page. This is most likely the result of invalid XAML or other type initialization exception'

**Prism.Navigation.NavigationException:** 'An error occurred while resolving the page. This is most likely the result of invalid XAML or other type initialization exception'

before adding signalr app was working.

Unity.ResolutionFailedException

Are you using Unity?
If that's the case, then it's likely that Unity is removing a bunch of the binaries that it doesn't think you need. To workaround that you need to add a link.xml file with the binaries you want it to keep.
See https://docs.unity3d.com/Manual/IL2CPP-BytecodeStripping.html and and example of someone else doing this https://github.com/thorgeirk11/SignalR-IL2CPP-failure-example/blob/master/Unity 2018.4 Client/Assets/link.xml

I am using Prism for MVVM and Prism Unity forms for dependecy injection. It's not Unity3D

@azizkazdal That property was removed in 3.0 but I'm failing to understand what's referencing the older version of the assembly. Are you using the 3.0.0 SignalR client? Do you have any other dependencies that reference the older version of this dll?

For now I am trying to use only version 3 and in entire solution nothing left to referencing any older version of net core. So that error I got it when I am using only version 3.

Looks like something in the project/solution/references is still referring to 2.2

Yes it's but nothing shows up. I need to recheck every project again with clean head

You could use msbuild foo to capture a binlog and use the viewer to figure out who is pulling it in http://msbuildlog.com/

@davidfowl thank you. clean all unnecessary references and it is working now.

I'm hitting the same problem. Using Prism with DryIoc. @davidfowl what am I looking for in msbuildlog exactly?

@ScarlettCode Firstly I check all project reference which referenced older version of signalr and found one. So delete it and application worked fine.

@azizkazdal this is the first time I'm adding signalr to the solution so don't think it's that

@ScarlettCode please open a new issue with details about your scenario and the errors/issues you're hitting.


TypeError: Cannot read properties of null (reading 'getContextAttributes')

Issue Description
this.canvas = args.object;
	const gl = this.canvas.getContext('webgl2', { antialias: false });
	// let drawingBufferWidth = gl.drawingBufferWidth
	// let drawingBufferHeight  =  gl.drawingBufferHeight
	// const { drawingBufferWidth: width, drawingBufferHeight: height } = gl;
	var engine: any
	var scene: any
	var sceneToRender: any
	var createDefaultEngine = function () {

		return new BABYLON.Engine(gl, true, { preserveDrawingBuffer: false, stencil: true, antialias: false });
	};

Reproduction
No response
Relevant log output (if applicable)
Refreshing application on device emulator-5554...
  JS: CONSOLE LOG: unloaded
  JS: CONSOLE LOG: Canvas<canvas>@main-page.xml:8:9; 9999
  System.err: An uncaught Exception occurred on "main" thread.
  System.err: Calling js method contextReady failed
  System.err: TypeError: Cannot read properties of null (reading 'getContextAttributes')
  System.err:
  System.err: StackTrace:
  System.err: getContextAttributes(file: app\webpack:\videoPlayer\node_modules\@nativescript\canvas\WebGL\WebGLRenderingContext\index.android.js:628:0)
  System.err:   at e(file: app\webpack:\videoPlayer\node_modules\babylonjs\babylon.js:16:367652)
  System.err:   at t(file: app\webpack:\videoPlayer\node_modules\babylonjs\babylon.js:16:112846)
  System.err:   at createDefaultEngine(file: app\webpack:\videoPlayer\app\canvas\canvas.ts:45:10)
  System.err:   at canvasLoaded(file: app\webpack:\videoPlayer\app\canvas\canvas.ts:50:11)
  System.err:   at _handleEvent(file: app\webpack:\videoPlayer\node_modules\@nativescript\core\data\observable\index.js:303:0)
  System.err:   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
Successfully synced application org.nativescript.videoPlayer on device emulator-5554.

Environment
No response
Please accept these terms

[X] I have searched the existing issues as well as StackOverflow and this has not been posted before
[X] This is a bug report
[X] I agree to follow this project's Code of Conduct

Can you share the packages used ?

Can you share the packages used ?

https://github.com/NativeScript/canvas/blob/cc723b4504a6878d8e25ec6b1fea22f5ca949f30/tools/demo/canvas-babylon/index.ts#L10

Can you share the packages used ?

Is there anything to pay attention to when using canvas-babylon

Can you share the packages used ?

{   "name": "videoPlayer",   "main": "app/app.ts",   "version": "1.0.0",   "private": true,   "dependencies": {     "@nativescript/canvas": "^1.1.0",     "@nativescript/canvas-babylon": "^1.1.0",     "@nativescript/canvas-media": "^1.1.0",     "@nativescript/core": "~8.5.0",     "@nativescript/canvas-polyfill": "^1.0.0",     "@nativescript/theme": "~3.0.2",     "babylonjs": "^4.1.0",     "babylonjs-materials": "^4.1.0",     "babylonjs-loaders": "^4.1.0"   },   "devDependencies": {     "@nativescript/android": "8.5.1",     "@nativescript/types": "~8.5.0",     "@nativescript/webpack": "~5.0.14",     "typescript": "~4.8.4"   } }

Can you share the packages used ?

Is there anything to pay attention to when using canvas-babylon

Not really but when using any external canvas lib I would recommend installing the @nativescript/canvas-polyfill then calling require('@nativescript/canvas-polyfill') as early as possible to let the polyfill work it's magic

Fixed in v2


Remove redundant sidenote counter

As mentioned in #114, the counter for sidenote-counter is defined twice.

I apologize for the radio silence on the underlying issue. Have you tested before and after side-by-side with the demo document that this in fact causes no difference?

No problem @daveliepmann. I tested it and removing this rule doesn't cause any difference.


Optimize IO in archival MMRs

@aszepieniec  do you have a particular optimization strategy in mind?

Forwarding this question to @Sword-Smith


Update sbt-best-practice to 8.3.0

Updates com.thoughtworks.sbt-best-practice:sbt-best-practice from 7.2.0 to 8.3.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.thoughtworks.sbt-best-practice", artifactId = "sbt-best-practice" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.thoughtworks.sbt-best-practice", artifactId = "sbt-best-practice" }
}]

labels: sbt-plugin-update, early-semver-major, semver-spec-major, version-scheme:semver-spec, commit-count:1

Superseded by #106.


QWenLMHeadModel does not support Flash Attention 2.0 yet.

Reminder

[X] I have read the README and searched the existing issues.

Reproduction

Expected behavior
刚刚实测transformer 4.36.1不支持flash attn v2,辛苦大佬帮忙看下
System Info
No response
Others
No response

取消 --flash_attn 参数，qwen 会自动开启


[BUG] Addons form doesn't revert to default values when second time enabling a given Addon

Describe the bug
The rancher monitoring addon if enabled - and have set custom values like Prometheus date retention to something other than 5d, to something like 10d, when addon is enabled - then addon is disabled - then when the user goes to enable the addon again, the values in the form for the addon remain at 10d instead of the default of 5d.
To Reproduce
Steps to reproduce the behavior:

Go to addons
Enable rancher-monitoring
Set Prometheus section's retention from default value of 5d to 10d
Save
Wait for addon to have deploy successful
Disable addon
Go back to re-enable addon of rancher-monitoring
You'll see that default value is no longer present in Prometheus section's retention and is not 5d as expected, but rather at 10d to what it was previously set to

Expected behavior
Default values to come across instead of custom values.
Environment

Harvester ISO version: v1.2-head /  Version: v1.2-37aeb5ff-head
Underlying Infrastructure: qemu/kvm

Hi @irishgordo   I think this is expected user behavior, because it's a value set by the user, which means he'll use it again, so we shouldn't set all values to default after the user disables them.

Oh okay :+1: :smile:  - that makes sense - thanks for providing that insight @WuJun2016  - I'll go ahead and close this out :smile:


Insert a line before h1

Description
Since it has been broken with GitHub markdown viewer like following screenshot.

@googlebot I signed it!


How to pass a refresh_token_lifetime? (v. 2.0.1)

Issues closed:
https://github.com/Filsh/yii2-oauth2-server/issues/17
https://github.com/Filsh/yii2-oauth2-server/issues/90
These solutions don't work.

same issue

same problem


Update pterodactyl.php

As this is part of https://github.com/pterodactyl/whmcs/pull/140, this should be directly part of it.


New button added

Fixes Issue
Closes #1107

Changes proposed

Screenshots

Checklist

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

Note to reviewers

Kindly merge this branch I have been assigned the issue too


Trouble signing in

What does this error say? I tired jumbling the ids but can't get the right combination. Can you help me with this?

Issue resolved. It was my mistake.


feat(TX-1022): PS Conditions of sale page

The type of this PR is: Feat
This PR solves TX-1022
Description
This PR pulls and displays a new page in the PageApp, for private sales conditions of sale, subjected to authentication. Also updates the links in the checkout flow to point to this new page.
Video
https://user-images.githubusercontent.com/42584148/225632440-650152d3-9b5a-4192-b62f-83f0a4df823a.mov

Is there a way to avoid the grey screen before the page loads?

about the grey screen, I don't know a way to prevent it as long as we want to open the page in a new tab. let me know if you do!


Random-row-batch-size not working as expected with Row level validation on multiple primary key columns

When I submit a row level validation with multiple primary-key values, and set the random-row-batch-size, then the number of validations that occur is not equal to the batch size. When I run this row validation with --verbose option, I see that the WHERE clause filter for source and target query Only includes the First primary-key that's in the comma-separated list of primary-keys. The actual number of rows that get validated is usually much more than the specified batch-size.
For example: if my PK values are id,first,last
The WHERE clause would only include something like WHERE id in (1,2,3,4,5) and no filters on 'first' or 'last'

As of now multi-PK filters are not supported for random row simply due to the complexity this will add when defining a specific batch size.
For example, if you have 3 PKs with batch size 5, the filter would need to be WHERE id in (1,2) and first in (1,2) and last in (1)

Thanks for the response @nehanene15 . I can understand how this would be complex to handle. For now we will just ensure that the first PK in the list is the one with the most unique values. We'd still need this feature to ensure we're not scanning the entire table.


Will it work for negative axes?

HI,
Thank you for the library. Is it possible to plot voxels on negative axes? I have some points on negative x, y and z axes. Is it possible to plot them? If so, can you please share an example?
Thank you

@kranti-up,
A new version has been deployed to resolve this Issue. Run pip install --upgrade voxelmap and then try the following Python code:
import voxelmap as vxm
import numpy as np

data = vxm.Data()
data.xyz = np.random.randint(-1,1,(10,3))+np.random.random((10,3))     # random x,y,z locs for 10 voxels
data.sparsity = 5                       # spaces out coordinates
cubes = data.importdata('coords')

model = vxm.Model(cubes)
model.hashblocks = data.hashblocks      # transfer colors from Data class to Model class
print(data.xyz)                              # print the xyz coordinate data
model.draw('voxels')                   # draw the model from that data

This will give you an output which looks something like this:
[Out]
[[ 0.09810283 -0.05707691 -0.40492372]
 [-0.85035545 -0.61693541  0.03495741]
 [ 0.0542932  -0.20244378  0.09935272]
 [-0.74850127 -0.50574033  0.13398549]
 [-0.87515848 -0.3319057  -0.46527974]
 [-0.16978636  0.59375739 -0.31659409]
 [-0.2467994   0.61286223 -0.67413402]
 [-0.69552436 -0.32921826 -0.68783246]
 [ 0.34158347  0.66220869 -0.26698782]
 [-0.12140307 -0.56846614 -0.21772612]]

As you can see, the xyz data also has negative xyz locations. Be wary of the data.sparsity variable. Will close this Issue.
-Andrew

Usage also found on new [voxelmap documentation]
(https://colab.research.google.com/drive/1RMEMgZHlk_tKAzfS4QfXLJV9joDgdh8N?usp=sharing) under "Draw voxels from coordinate arrays" section


daemon: disable dependent bpf-sock-lb options if bpf-sock-lb=false

Socket LB tracing and support for getpeername are only supported if bpf-sock-lb is true.
Because the default value for option.Config.EnableSocketLBTracing is true^1, e.g. the cgroup manager cell is still coming up in these cases^2, leading to unnecessary work and log messages (previously warnings) being emitted. Avoid this by disabling these two options in case bpf-sock-lb=false

/test

/test


Show which extra a dependency came from

Currently, if you compile from pyproject.toml and specify extra requirements, you don't get to see which dependencies came from the extras. For example, with this pyproject.toml:
[project]
name = "blah"
version = "0.0.1"
dependencies = [
    "requests",
]
[project.optional-dependencies]
test = [
    "pytest",
]

If I run pip-compile --output-file requirements-test.txt pyproject.toml --extra test, I get
#
# This file is autogenerated by pip-compile with Python 3.11
# by the following command:
#
#    pip-compile --extra=test --output-file=requirements-test.txt --resolver=backtracking pyproject.toml
#
certifi==2022.12.7
    # via requests
charset-normalizer==3.1.0
    # via requests
idna==3.4
    # via requests
iniconfig==2.0.0
    # via pytest
packaging==23.1
    # via pytest
pluggy==1.0.0
    # via pytest
pytest==7.3.1
    # via blah (pyproject.toml)
requests==2.28.2
    # via blah (pyproject.toml)
urllib3==1.26.15
    # via requests

You can't tell any difference in source between pytest and requests. Ideally, I would like to see something like this for pytest:
...
pytest==7.3.1
    # via blah[test] (pyproject.toml)
...

or
...
pytest==7.3.1
    # via blah (pyproject.toml[test])
...

Would that be feasible?

To clarify the request, is it right that if you get
pytest==7.3.1
    # via blah[test] (pyproject.toml)

you want
requests==2.28.2
    # via blah (pyproject.toml)

?


Delete role without migrating to other role not working

Describe the Bug
Instead an error appeared:
TypeError
BookStack\Auth\Permissions\PermissionsRepo::deleteRole(): Argument #2 ($migrateRoleId) must be of type int, string given, called in /var/www/bookstack/app/Http/Controllers/RoleController.php on line 154

Steps to Reproduce

Select a role
Click Delete role
Leave drop-down unchanged at Don't migrate users
Click Confirm

Expected Behaviour
Role is delete and the ui returned to role list view.
Screenshots or Additional Context
Stacktrace
#0 /var/www/bookstack/app/Http/Controllers/RoleController.php(154): BookStack\Auth\Permissions\PermissionsRepo->deleteRole()
#1 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(54): BookStack\Http\Controllers\RoleController->delete()
#2 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(43): Illuminate\Routing\Controller->callAction()
#3 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Route.php(260): Illuminate\Routing\ControllerDispatcher->dispatch()
#4 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Route.php(205): Illuminate\Routing\Route->runController()
#5 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(798): Illuminate\Routing\Route->run()
#6 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(141): Illuminate\Routing\Router->Illuminate\Routing\{closure}()
#7 /var/www/bookstack/app/Http/Middleware/Authenticate.php(23): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#8 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\Http\Middleware\Authenticate->handle()
#9 /var/www/bookstack/app/Http/Middleware/Localization.php(45): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#10 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\Http\Middleware\Localization->handle()
#11 /var/www/bookstack/app/Http/Middleware/RunThemeActions.php(26): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#12 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\Http\Middleware\RunThemeActions->handle()
#13 /var/www/bookstack/app/Http/Middleware/CheckEmailConfirmed.php(47): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#14 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\Http\Middleware\CheckEmailConfirmed->handle()
#15 /var/www/bookstack/app/Http/Middleware/PreventAuthenticatedResponseCaching.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#16 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\Http\Middleware\PreventAuthenticatedResponseCaching->handle()
#17 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(78): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#18 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Foundation\Http\Middleware\VerifyCsrfToken->handle()
#19 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#20 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\View\Middleware\ShareErrorsFromSession->handle()
#21 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(121): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#22 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(64): Illuminate\Session\Middleware\StartSession->handleStatefulRequest()
#23 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Session\Middleware\StartSession->handle()
#24 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#25 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle()
#26 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(67): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#27 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Cookie\Middleware\EncryptCookies->handle()
#28 /var/www/bookstack/app/Http/Middleware/ApplyCspRules.php(33): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#29 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\Http\Middleware\ApplyCspRules->handle()
#30 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#31 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(799): Illuminate\Pipeline\Pipeline->then()
#32 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(776): Illuminate\Routing\Router->runRouteWithinStack()
#33 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(740): Illuminate\Routing\Router->runRoute()
#34 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Routing/Router.php(729): Illuminate\Routing\Router->dispatchToRoute()
#35 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(190): Illuminate\Routing\Router->dispatch()
#36 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(141): Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http\{closure}()
#37 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php(39): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#38 /var/www/bookstack/app/Http/Middleware/TrustProxies.php(41): Illuminate\Http\Middleware\TrustProxies->handle()
#39 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): BookStack\Http\Middleware\TrustProxies->handle()
#40 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#41 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php(40): Illuminate\Foundation\Http\Middleware\TransformsRequest->handle()
#42 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Foundation\Http\Middleware\TrimStrings->handle()
#43 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#44 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Foundation\Http\Middleware\ValidatePostSize->handle()
#45 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(86): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#46 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(180): Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance->handle()
#47 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}()
#48 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(165): Illuminate\Pipeline\Pipeline->then()
#49 /var/www/bookstack/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(134): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter()
#50 /var/www/bookstack/public/index.php(53): Illuminate\Foundation\Http\Kernel->handle()
#51 {main}

Browser Details
No response
Exact BookStack Version
v23.02.1
PHP Version
8.1.16
Hosting Environment
Alpine-based Docker setup inspired by https://github.com/linuxserver/docker-bookstack

Thanks for reporting again @ChriFo.
Can confirm, and have patched with testing to cover this scenario in dde38e91b5fe63c5673d3c669b303a067228dc1b.
Since that's a couple of potentially annoying bugs, and since we're a couple of weeks out from a feature release, I'll backport the pending fixes to get a patch release out soon.


[Build] Add autotools build support

Adds support for native autotools builds.
Relic is imported as a git subtree in contrib/relic; this is the same commit hash pointer as what is used for CMake builds, and no changes to the files in this subtree should be made in this repository directly. This subtree should be updated at the same time as when updating the CMake build's Relic commit pointer so as to avoid any inconsistencies between the two build systems.
The autotools build mimics the CMake build closely, but isn't an exact 1:1 comparison. some compiler flags have been omitted (namely, -funroll-loops for Relic), and no attempt has been made to build for standard distribution purposes (ie, installing in /usr/ or /usr/local/).
The intended purpose of this is for use in a parent project that already uses autotools as it's build system.

Tested with #2 on top. all good :+1:

Post merge review ACK b1ef4f6.
Relic subtree hashes matching, autotools and cmake build and tests working.
Will make a small PR adding the git-subtree-check.sh script to this repo. It's a good utility.


Drop support for Python 2.6

Because the Azure driver has since dropped support and this was making
test failures noisy.

Committed in 808b908a4f743bed37719a2dac2d000cb65f06e1


[BUG]: Memory leak in RCTView

Version
6.7.0
What platforms are you having the problem on?
iOS
System Version
18
On what device are you experiencing the issue?
Real device
Architecture
Old architecture
What happened?
RCTVideo has a memory leak due to two retain cycles:

_imaAdsManager = RCTIMAAdsManager(video: self, pipEnabled: isPipEnabled) isPipEnabled closure should be called on weak self

+_imaAdsManager = RCTIMAAdsManager(video: self, pipEnabled: {[weak self] in
+            return self?.isPipEnabled() ?? false
+        })

ReactNativeVideoManager’s registerView method in the shared instance strongly retains RCTVideo instances without using them. Please clean up this unused functionality to avoid unnecessary memory retention.

Reproduction Link
repository link
Reproduction
Step to reproduce this bug are: Unmount any video component and verify that the deinit function in RCTVideo is not being called.

@Varuzh1 I have the same issue. Do you have any solutions?

@Varuzh1 can you please open a pr with your changes, I would be happy to review it quicky!

I tried the code you provided, but it didn’t work:
+_imaAdsManager = RCTIMAAdsManager(video: self, pipEnabled: {[weak self] in
+            return self?.isPipEnabled() ?? false
+        })

I’m facing a serious issue where the device (IOS) heats up after watching videos multiple times. The reason seems to be that the memory isn’t released properly. Can you take a look at this issue, @freeboub ? I would really appreciate it.

I think I have a fix for the memory leak. Please, check the #4355


Getting 403 Forbidden when updating Kubernetes version of a cluster

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Log in to the Rancher UI
Open a cluster
Click Edit
In the "Kubernetes Options" section, select the Kubernetes version as v1.17.17-rancher-2-3.
Click Save.

Result:
Error message
 <title>403 Forbidden</title>
403 Forbidden

Other details that may be helpful:
The existing Kubernetes Version is v1.17.17-rancher-2-1. This user is an administrator and has all permissions. The user is also the owner of the cluster.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.5.8
Installation option (single install/HA):

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): AWS EC2
Machine type (cloud/VM/metal) and specifications (CPU/memory): AWS EC2
Kubernetes version (use kubectl version): v1.17.17-rancher2-1
Docker version (use docker version):

Any update on this?

Please provide more information in the issue, is this single Docker install or HA? What type/version of HA cluster? Is this only on cluster update or on any other GET (just visiting pages) or POST (submitting forms) requests? Since when is this happening?

is this single Docker install or HA?

It is a single Docker

Is this only on cluster update or on any other GET (just visiting pages) or POST (submitting forms) requests?

It happens on operations like updating the Docker version from the Rancher UI or adding members to a cluster. Operations like creating a pod, etc. work fine.

Since when is this happening?

I first experienced it a month ago.

What does updating the Docker version from the Rancher UI mean exactly?

What does updating the Docker version from the Rancher UI mean exactly?

Apologies, I meant Kubernetes. Have updated the reply accordingly.

Sorry I am talking about the container running the rancher/rancher image, not the docker run command to add a node to a cluster.

docker run -d --restart=unless-stopped \   -p 80:80 -p 443:443 \   --privileged \   rancher/rancher:latest
We are not exposing ports directly as there is an ALB in front. @superseb

We got this resolved by changing the IP address in the Rancher Settings to .rancher.com Thanks @superseb for the assistance.


Feature/add user registration

Button for registration new users added
Correct button are dislayed based on if user is LoggIn/LoggedOut

It looks alright :)


How do I integrate divi-scripts npm package in my boilerplate?

This utility provides a boilerplate to create a new plugin.
I have my own boilerplate to create plugins. Also I have existing divi addon plugins which needs
frontend builder compatibility.
Do you have specific steps or process which shows how to setup things (using the divi-script npm package and in general) so that I can continue working using my workflows?
Thanks

QA Checklist
Reporter

[ ] Helpful title used

Helpful title format: Scope(s) :: One Sentence To Describe The Issue
Example: VB :: Floating Toolbar :: Jumps To Top Of Page

[ ] Detailed description

Description should usually be 150+ characters.

[ ] Steps to reproduce included
[ ] Support Ticket URL included
[ ] Image and/or gif

Developer

[ ] Steps to reproduce proven solved
[ ] Test included and coverage acceptable and all Tests passing?
[ ] PR description has layman's description of problem and solution and "Areas Affected" listed/explained?
[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Estimated points on issue
[ ] Proper code documentation and conventions?
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Peer Review

[ ] PR branch includes latest commits from master branch (at the time of checking)?
[ ] Steps to reproduce proven solved
[ ] Affected areas are tested and ok
[ ] Proper code documentation and conventions
[ ] Proper RTL appearance
[ ] i18n used if applicable
[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?

Quality Assurance

[ ] All tests passed on CircleCI.
[ ] Steps to reproduce passed, the fix works.
[ ] No errors in console or output
[ ] Affected areas are tested and ok
[ ] The fix does not change a customer's website in any surprising or unintended way

[ ] If Divi's design is adjusted, settings are migrated gracefully and invisibly

Design Review

[ ] UI is to spec
[ ] UX is to spec
[ ] Design is to spec
[ ] No surprising visual changes to a customer's website will be experienced after updating

[ ] Any/all visual changes are migrated gracefully

Dev Review

[ ] Test(s) included and coverage acceptable
[ ] Ajax/Form used? Nonce used? Perms checked? All user input sanitized and validated? Intentional unsanitized/unescaped functions used?
[ ] Database saved/updated? Data sanitized and validated?
[ ] Variable output properly escaped and validated?
[ ] i18n used if applicable
[ ] Implementation acceptable, DRY, Scaleable, future safe
[ ] Best practices used, cleverness and grokage, ES6 use, etc.

I think i would like to have a steps on how to process on existing modules. I have 4 modules which needed this. Thanks!

Hi @ketanshah79 , you can learn more about how this project is setup and how it works here. You'll find the template files that are used to generate the extensions here. I hope that helps. Let me know if you have any more specific questions. Cheers!
@mrkenng Have you reviewed the new Developer Documentation? If there is something specific that you have questions about please open a separate issue for that. Thanks!


[Question] Will nix-flatpak ever be upstreamed to nixpkgs?

Will nix-flatpak every be upstreamed to nixpkgs? There has been no offical statement on the wiki and I am curious, of course I dont expect anyone to like, do the work for me, I am just asking out of curiosity, because on the wiki there has been talks of the secure boot module being up-streamed, and many other modules, nix-flatpak makes more sense to be up streamed than any of them. Are there any plans to upstream this?

I find this very unlikely. nix-flatpak and other nix flatpak management solutions (that I've found, anyway) don't seem to be 100% reproducible in the nix way.

I am not involved with nixos/nixpkgs development, but I don't see a path to upstream.
The approach followed by nix-flatpak does indeed break reproducibility guarantees that nix provides. This project is more more similar (in spirit) to nix-darwin, which also exists as a standalone product.


Need to release 2.2.1 in "Releases"

Hi,
Could you add v2.2.1 in "Releases"?
Thanks.

Whoops. Done.


initial unit tests

would be really useful to have unit tests around core functionality
adding a few simple initial unit tests as a base to start from

Awesome i really love that one!


remove cloud shell reference

In Azure Government, there is no equivalent to Azure Cloud Shell that you can find in the Azure portal.
is no longer relevant

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2a6b8431-b6f6-8465-01d2-f66f6f4d98f7
Version Independent ID: 607755a8-442e-7b74-a98d-07b86111eb78
Content: Azure Government Connect with PowerShell
Content Source: articles/azure-government/documentation-government-get-started-connect-with-ps.md
Service: azure-government
GitHub Login: @gsacavdm
Microsoft Alias: gsacavdm

@pbous123 Can you please provide us with the URL of the Azure Doc you are having issues with? We look forward to your reply.

@pbous123 Can you please provide us with the URL of the Azure Doc you are having issues with? We look forward to your reply.

https://docs.microsoft.com/en-us/azure/azure-government/documentation-government-get-started-connect-with-ps#install-powershell

@pbous123 Thanks for the feedback! I have assigned the issue to the content author to investigate for further review.

Thanks @pbous123 , I submitted the fix. Update should be in place tomorrow.

Addressed as stated above.

#please-close


GO1.11 : go test -o NUL fails on Windows

I put it here for information, in case somebody else encounters this issue :
On Windows and Go1.11, I am not able to launch godog tests with the "godog" command anymore.
This is apparently due to this issue in Go1.11 : https://github.com/golang/go/issues/28035
The error message I get is the following :
$ godog
failed to compile tested package: qa, reason: exit status 1, output: WORK=C:\Users\CBONNA~1\AppData\Local\Temp\go-build279225422
go test gitlab.prod.saas.lan/neo/qa.test: build output "C:\\Users\\cbonnafous\\go\\src\\gitlab.prod.saas.lan\\neo\\qa\\NUL" already exists and is not an object file

To bypass this issue, I have to add a TestMain function as explained in the FAQ (https://github.com/DATA-DOG/godog#running-godog-with-go-test), and launch the tests with "go test"

made it like in previous go versions, to generate a file in temp directory. this should now work on windows too

Great, thanks !


Error about Interned strings

On interpreter close we get an error trying to remove the interned string, as the overwrited one is not in the interned dict.

The output of the issue:
$ python3 -c "import memwiper;s='Hola';memwiper.wipeit(s)"
kind: 1 - refc: 4 - buffer size: 4
Pre hash: -6410720996659587941
GIL Taked!
REFCNT!=1 - Using for+PyUnicode_WRITE
GIL Released! - Returning!
Post Ready check was OK!
Current hash: -6410720996659587941
New hash:<PHONE_NUMBER>309603554

Fatal Python error: deletion of interned string failed
KeyError: 'ÿÿÿÿ'

Current thread 0x00007f012a948540 (most recent call first):
Aborted (`core' generated)

Resolved. We modify the string object to re-hash it with the new value.


Malformed BASIC_TRANSFER transactions not rejected

It appears that malformed BASIC_TRANSFER transactions that do not include AmountNanos are not rejected by backend and can be signed and submitted into the mempool.
However, these transactions do not appear to be then accepted and mined into the chain.
@lazynina @diamondhands0 my concern is that this leaves us open to a vulnerability where the mempool could become hijacked in a DOS-type attack/clog the mempool entirely - that could overwhelm nodes and validators.
Here are the details - transactions created by user DiamondThumb:
This is his example payload provided:

Example transactions crash the blockchain explorer:
https://explorer.deso.com/txn/3JuEUQSXue97tHWVrRidZC1GUU1Qdau78YskxHGukxByz1g6xxNCCo
https://explorer.deso.com/txn/3JuETYrJjmN8LV1tvCfcZdsvMpNzB8pjzhQzAJ2BsojgcQJic4QkFu
https://explorer.deso.com/txn/3JuETB3wvCm1UQ8bFNU7uRmoWZ9hE621e4waJDYzNDeYs5a9kfb41x
https://explorer.deso.com/txn/3JuETt6hMbiYtrkAFUb1pVqWhwLj1xroXdmWbYmZzpY1SN7WKsFZua
Here is the verbose transaction details for the first example from my front-end:
{
  "TransactionIDBase58Check": "3JuEUQSXue97tHWVrRidZC1GUU1Qdau78YskxHGukxByz1g6xxNCCo",
  "TransactionHashHex": "db7fceaebbcedecbd933dfcfcc7d65d104ebc7d2578479313edeed5176716096",
  "RawTransactionHex": "00010360d99b827779f9e34fefbad4f23927fdf9bed8c90f820b0a374f7cdf03c98c5b00020021035a8155c505cc022a7bafc29d6a46ec6430cfeb68fe8cc16e613d04c6a1169d1f000001ab01ba8e15f5eb90a8aad2a0a652",
  "Outputs": [
    {
      "PublicKeyBase58Check": "BC1YLiMGYzDWEo73gJpqFZ32txELPQti7w13ccm9GTMyePHWtPNfxES",
      "AmountNanos": 0
    }
  ],
  "TransactionType": "BASIC_TRANSFER",
  "TransactionMetadata": {
    "BlockHashHex": "",
    "TxnIndexInBlock": 0,
    "TxnType": "BASIC_TRANSFER",
    "TransactorPublicKeyBase58Check": "BC1YLiJUUwY9Q5cbT1XCSVTp53piLWM3o1uCWvU8wAvG1wUVvNbupij",
    "AffectedPublicKeys": [
      {
        "PublicKeyBase58Check": "BC1YLiMGYzDWEo73gJpqFZ32txELPQti7w13ccm9GTMyePHWtPNfxES",
        "Metadata": "BasicTransferOutput"
      },
      {
        "PublicKeyBase58Check": "BC1YLiJUUwY9Q5cbT1XCSVTp53piLWM3o1uCWvU8wAvG1wUVvNbupij",
        "Metadata": "TransactorPublicKeyBase58Check"
      }
    ],
    "TxnOutputs": [
      {
        "PublicKey": "A2DZm4J3efnjT++61PI5J/35vtjJD4ILCjdPfN8DyYxb",
        "AmountNanos": 0
      }
    ],
    "BasicTransferTxindexMetadata": {
      "TotalInputNanos": 171,
      "TotalOutputNanos": 0,
      "FeeNanos": 171,
      "UtxoOpsDump": "",
      "UtxoOps": null,
      "DiamondLevel": 0,
      "PostHashHex": ""
    }
  },
  "TxnNonce": {
    "ExpirationBlockHeight": 345914,
    "PartialID":<PHONE_NUMBER>685453000
  },
  "TxnFeeNanos": 171,
  "TxnVersion": 1,
  "RawTxnMetadata": {}
}

DiamondThumb's thread regarding his issue here: https://desocialworld.com/posts/20891c713fe091a02b4bd556b4f2cfeef4a758ec6fdf5a7f3522317d6557ee9e

Suggested change to basic_transer.go
https://github.com/deso-protocol/backend/blob/e6eadebc934e18f6c3e6c595b03fa8bef6a40c7d/scripts/tools/toolslib/basic_transfer.go
func _generateUnsignedSendDeSo(senderPubKey *btcec.PublicKey, recipientPubKey *btcec.PublicKey, amountNanos int64,
params *lib.DeSoParams, node string) (*routes.SendDeSoResponse, error) {
if !amountNanos || amountNanos <= 0 {
return nil, errors.New("_generateUnsignedSendDeSo() invalid AmountNanos: must be a positive integer")
}
endpoint := node + routes.RoutePathSendDeSo

Very interesting. We're taking a look at this now.

Sorry, I'm not familiar with github else would submit the PR:

@StarGeezerPhil this should be fixed now. It looks like the mempool was failing to reject txns with an invalid signature (the amount being zero was actually a red herring). Can you try submitting the txns again to node.deso.org and lmk your results?


MQTT subscribe for remote open door

Is it possible to add subscribe for remote door opening?

Yeah totally, can you explain me how this would work? Is it safe? What if someone crafts special MQTT payload and opens the door?

It is quite safe to add auth (login/password) for MQTT.  Maybe mqtt_client.subscribe("home/rfid/door/status");

I would like to open the door remotely. Can eat still variants?

How subscribe works? The broker send an UID then we check against it or the broker tells the open door? Then how do i know the message is authentic ?

uid is not checked. Authentication passes at the level of mqtt by login and password. The idea is to make the remote door open button through mqtt. When you need to open the door a short distance or at a remote distance. I'm using the node-red mqtt link homebridge homekit

How subscribe works? The broker send an UID then we check against it or the broker tells the open door? Then how do i know the message is authentic ?

For that part you should rely on the security implemented by the owner. He should use a mqtt account with only read rights on the specific topic. No other accounts should have read rights to that topic. A second account (for publishing) should only have write rights to that topic.
A step higher in securiy is implementing SSL, but I'm afraid this would draw to much memory from the ESP to leave for the rest of the code/project.

OK. Can then implement through a POST request?

OK. Can then implement through a POST request?

You can already open the door by sending a testrely command through the websocket

I believe SSL encryption can be used also basic subscribe can be implemented, but i can not make a promise at this time.  We will see.  Closing it for now.

Is there any hope that this will be implemented in the near future?
I want to buy the official package, but its a must to be able to remote open the door/relay via HomeAssistant (secure mqtt?)


CastSpacesFixer - add space option

This one resolves #2853.
It's not BC break, original behaviour set by 'cast_spaces' => true is replaced by default value.

Thank you @kubawerlos.

thanks @kubawerlos :)


Optimised font isn't listed in CSP

Optimised font isn't listed in CSP in Safari & Chrome
https://nextjs.org/docs/basic-features/font-optimization

Also there is some problem with scripts, but I still didn't realise what exactly.

Hi @Shamilik

On the failed scripts

Is the respective route where the load fails with getServerSideProps or getInitialProps?
If so, you need to wrap the exported data fetching function with gsspWithNonce or gipWithNonce respectively (https://next-safe-middleware.vercel.app/guides/strict-csp-configuration). That is new since version 0.9.0 as there has been some internal change that makes it impossible to reliably tell apart getServerSideProps  from getStaticProps + revalidate (ISR) by DocumentContext. It is an extra step to remember, but it's unavoidable to not break the actual security feature + it will be robust towards future changes.
If not, this is super strange. With the new proxy loading mode, the actual scripts wouldn't even be in the DOM in case of a missing hash in CSP. So if the proxy loader can execute, but the inserted scripts get blocked, that would violate the transitive trust semantics of strict-dynamic and a browser bug.

An inline proxy loader looks like this:

<script id="Yedj62rQfq60uPH64PMXT3QyQOhTx9o6R8Xh7QgjDw8=" integrity="sha256-b0G+uhdQVb4QIV+2wcWxkz/zpRluWegXaRWsuzRpIao=">(function () {
  var s0 = document.createElement('script');
  s0.async=false;s0.crossOrigin='anonymous';s0.defer=true;s0.src='/_next/static/chunks/webpack-fdfc059437936d2e.js';
  var s1 = document.createElement('script');
  s1.async=false;s1.crossOrigin='anonymous';s1.defer=true;s1.src='/_next/static/chunks/framework-8e84920140c7484e.js';
  var s2 = document.createElement('script');
  s2.async=false;s2.crossOrigin='anonymous';s2.defer=true;s2.src='/_next/static/chunks/main-493ad903cf8fb0b9.js';
  var s3 = document.createElement('script');
  s3.async=false;s3.crossOrigin='anonymous';s3.defer=true;s3.src='/_next/static/chunks/pages/_app-7fb09efe43f5ca1a.js';
  var s4 = document.createElement('script');
  s4.async=false;s4.crossOrigin='anonymous';s4.defer=true;s4.src='/_next/static/chunks/618-96dee7e359cd4890.js';
  var s5 = document.createElement('script');
  s5.async=false;s5.crossOrigin='anonymous';s5.defer=true;s5.src='/_next/static/chunks/571-4efa2b5b3651989b.js';
  var s6 = document.createElement('script');
  s6.async=false;s6.crossOrigin='anonymous';s6.defer=true;s6.src='/_next/static/chunks/pages/index-1879bc8b71df0035.js';
  var s7 = document.createElement('script');
  s7.async=false;s7.crossOrigin='anonymous';s7.defer=true;s7.src='/_next/static/Z4vsrxjeHVcl6pZc5u9PF/_buildManifest.js';
  var s8 = document.createElement('script');
  s8.async=false;s8.crossOrigin='anonymous';s8.defer=true;s8.src='/_next/static/Z4vsrxjeHVcl6pZc5u9PF/_ssgManifest.js';
  var s = [s0,s1,s2,s3,s4,s5,s6,s7,s8];
  var self = document.getElementById('Yedj62rQfq60uPH64PMXT3QyQOhTx9o6R8Xh7QgjDw8=');
  var p = self.parentNode;
  p.removeChild(self);
  s.forEach(function(si) {
    p.appendChild(si);
  });
})()
</script>

Do the script problems on your site also occur with other browsers (Chrome, Firefox ...)?

Workaround for the font optimization problem

The output of Next font optimization can't be picked up during SSR of _document, it happens sometimes after.
Fortunately, there is a simple workaround:
https://github.com/nibtime/next-safe-middleware/blob/f293383966b7a7806764f0d2aa7e152e51f64549/apps/e2e/pages/_document.tsx#L29-L33
https://github.com/nibtime/next-safe-middleware/blob/f293383966b7a7806764f0d2aa7e152e51f64549/apps/e2e/pages/_document.tsx#L70-L90

I am closing this, as the font optimization thing can't be handled automatically and needs the workaround
For the script issues: I am going to release 0.10.1 now (#70). I fixed some bugs with middleware that could break CSP, but those happened on Vercel only.
I also recorded a basic click-through test of the e2e app with Safari+strict-dynamic on a iPad Pro Device (https://github.com/nibtime/next-safe-middleware/pull/69#issuecomment-1206544255) and couldn't spot any issue there, also not in the docs project.

You can disable font-optimization by adding   optimizeFonts: false, to nextjs.config
https://nextjs.org/docs/basic-features/font-optimization


Max-width Scale from v0.72 -> v1.0.1

Hi @adamwathan - so I have been using Tailwind from its infancy and I have always created my own container - in most instances this is done via a single class (.container) and uses @apply to set a max-width. So updating it should be fairly easy. However, in several instances I have also used max-width classes.
Upgrading old projects should be fine as I would keep the original max-width scale.
However, for new projects I wondered if you would consider extending the default max-width scale to include the following?
max-width: 80rem;
max-width: 90rem;
max-width: 100rem;

The old class names were:
.max-w-3xl | max-width: 80rem;
.max-w-4xl | max-width: 90rem;
.max-w-5xl | max-width: 100rem;

So perhaps the new ones would be:
.max-w-7xl	max-width: 80rem;
.max-w-8xl	max-width: 90rem;
.max-w-9xl	max-width: 100rem;

The main one being the 90rem as this equates to 1440px (on a standard 16px scale) which is an ideal max-width resolution for most containers (maxes the desktop size nicely). I always design fluid responsive websites not fixed width at breakpoints so I don't like or use the container plugin approach.
I appreciate I can naturally set these up as standard in my own config file, but I wondered if others might be in a similar position having used max-4w from versions prior to 1 fairly extensively?

Hey Terry! We did in fact have a 1440px value at one point while we were coming up with the new values, but ultimately opted to limit the number of values for default file-size considerations (the max width values don't add a lot on their own, but if we are too lax about what values we include everywhere in the framework it adds up.)
Best option for now is to add these values in your own config file, but if the demand is high enough I'm open to discussing expanding the default scale.


chore: fix pyproject implementation style

Description
This PR fixes #

@Kludex , see the commit authors!
PS - https://github.com/sansyrox/git-add-co-author


emit a warning for nested option type

<EMAIL_ADDRESS>external bsObjMake: (~comment: option(string)=?, ~platform: string, unit) => _

Here comment already had a question mark, the option seems to be redundnat in most cases.

Wouldn't such a warning be better at the compiler level?


[Docs]: ComponentDoc should dynamically require.

As of right now we generate aComponentDoc for each component. It would significantly less code to use contextual/dynamic requires in webpack.

Closed per 79e4530


Feature Request: Vim-like key bindings

I think this can be a really good thing specially for those used to type markdown on vim or using other  markdown editors that support vim keybindings.

Any progress on this? Would love to see this feature.


Show expire status when the project backup link is expired

The project backup is expired but the link is still not disable and clickable. Figma

[ ] Disable link and show expired status

Design
Current

@turk-t Will this fix apply to the previous expired links?

@turk-t Will this fix apply to the previous expired links?

It should be like that, Let me check what I missed. 🙏🏻

Released on v1.4.1


Safari not showing proper stack traces.

(This issue tracker is only for bug reports or feature requests, if this is neither, please choose appropriate channel from http://bluebirdjs.com/docs/support.html)
Please answer the questions the best you can:

What version of bluebird is the issue happening on?
<EMAIL_ADDRESS>What platform and version? (For example Node.js 0.12 or Google Chrome 32)
"node": "6.5.0",
"npm": "3.10.3"
Issue only on Safari 8, I'm on 8.0.8. Haven't tested on any other version of safari.
Did this issue happen with earlier version of bluebird?
IDK
(Write description of your issue here, stack traces from errors and code that reproduces the issue are helpful)
I'm attempting to log my promise errors. This works for Chrome and FF.

console.es6:5 Unhandled promise rejection: Error: NSBridge timed out
    at eval (http://localhost:8000/static/scripts/base/cart/cart_data/ns-cart.model.es6.js:1005:21)
From previous event:
    at NsCartData._resolveInCart (http://localhost:8000/static/scripts/base/cart/cart_data/ns-cart.model.es6.js:1001:53)
    at eval (http://localhost:8000/static/scripts/base/cart/cart_data/ns-cart.model.es6.js:973:29)
From previous event:
    at NsCartData._adding (http://localhost:8000/static/scripts/base/cart/cart_data/ns-cart.model.es6.js:969:21)
    at NsCartData.add (http://localhost:8000/static/scripts/base/cart/cart_data/cart.model.es6.js:605:18)
    at AddToCart._add (http://localhost:8000/static/scripts/base/cart/widgets/add-to-cart.ctrl.es6.js:1165:19)
    at eval (http://localhost:8000/static/scripts/base/cart/widgets/add-to-cart.ctrl.es6.js:1076:21)
    at fire (http://localhost:8000/static/jspm_packages/npm/jquery@2.1.0/dist/jquery.js:3049:30)
    at Object.add [as done] (http://localhost:8000/static/jspm_packages/npm/jquery@2.1.0/dist/jquery.js:3095:7)
    at HTMLFormElement.eval (http://localhost:8000/static/scripts/base/cart/widgets/add-to-cart.ctrl.es6.js:1066:14)
    at HTMLFormElement.dispatch (http://localhost:8000/static/jspm_packages/npm/jquery@2.1.0/dist/jquery.js:4373:9)
    at HTMLFormElement.elemData.handle (http://localhost:8000/static/jspm_packages/npm/jquery@2.1.0/dist/jquery.js:4059:28)
    at HTMLFormElement.nrWrapper (http://localhost:8000/aqua-pure-wrench-for-ap801-ap801-c-wrench/i/G9173595/:391:28)

But for Safari shows this:
tryCatcher

tryCatcher
_settlePromiseFromHandler
_settlePromise
_settlePromise0
_settlePromises
_drainQueue
_drainQueues
drainQueues
PromiseResolutionHandlerFunction@[native code]

The handler looks like:
  window.addEventListener('unhandledrejection', (event) => {
    event.preventDefault(); // Prevents default handler (would log to console).
    let reason = event.detail.reason;
    console.error(reason && (reason.stack || reason));
  });

safari stack traces are normally unhelpful like that

Yes, this is not a regression. There is no way we know of to get good stack traces in Safari.


[Fix] Slugify categories in metadata

Fixes #173
I've added an example ("My favourites" "External sources") to the example blog pages. However, I'm not sure where to add a proper test for this fix. I would really appreciate any advice on where to add an appropriate test.

Hey @jimgraham, thanks for spotting this bug and providing a fix! Can't believe I've missed this one, but thankfully not too painful to solve. Only change I see that might be better is to change the example category to "External sources" and mark the "Description of an Alembic" and "History of the Alembic" with that new category? I like to keep the example content as logical as I can for people trying to understand the usage of the theme. Since both of those articles are lifted from Wikipedia is makes sense to put them in an external sources category. Hope that's ok 😊

Thanks for the response! Are there any unit tests I should provide? Didn't see a test/ directory.

@jimgraham sadly not but there should be really 😅
Looks good though! Merging now


[GLUTEN-1369][Core] Move config 'spark.gluten.enabled' to GlutenConfig from QueryPlanSelector

What changes were proposed in this pull request?
Move the config 'spark.gluten.enabled' to GlutenConfig from QueryPlanSelector
(Fixes: #1369 )
Close #1369 .
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

it seems there are some networks issue for velox-backend-centos7-test @rui-mo


Hash/Checksum in the header

In order to not only extract assets, but modify them, you'd also need to update the hash in the header (which is currently skipped when reading v2). Do you have any idea how that is calculated?

No, that's why it's skipped.


CUDA example programs hang when run with 1 PE

Original issue: https://charm.cs.illinois.edu/redmine/issues/1464

CUDA example programs (overlapTest, concurrentKernels, callbacks, etc.) hang when they are run with only 1 PE.
For example: ./charmrun +p1 ++local ./overlapTest
After some debugging, there seems to be a problem with CmiPushPE(), because although CUDACallback function gets invoked,
functions that actually invoke the user's callback functions such as hostToDeviceCallback(), kernelCallback(), and deviceToHostCallback() do not get called.
This is where the hang occurs.

Original date: 2017-03-08 22:21:41

Thought it might be because of the handler functions indices, so wrapped and moved out CmiRegisterHandler() calls to ck-core/init.C as registerCallbacks().
So this change still works for # of PEs > 1, and it's good because the functions are no longer registered at every hapi_enqueue() call, but did not solve the 1 PE problem.
It runs fine in SMP mode, but this might be due to the presence of the comm thread (which is still weird).

Original date: 2017-11-01 19:45:45

Low priority, as the default mode of execution is CUDA events and not CUDA callbacks.
Will look into this issue again, though.

Original date: 2018-08-27 04:25:53

Does not appear in current build. May need to look at this if we ever use CUDA callbacks again, but closing for now.


If runtime doesn't support enums, VS Code reports no problems - failure only occurs on publish

The title says it all:
Here is VS Code's view of a project using runtime 2.0 in app.json but also using Enums. See how it conflicts with the server's view!

Apparently Enums are only valid from runtime version 4+.
Thus the VS Code AL extension should let us know about this early, rather than indicating everything is OK and then erroring only when we try to publish to a server with incompatible runtime.
Thanks!
Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 9.0.615906
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

Hi, this does not seem to be an error related to enums not being valid, since they are available since runtime version 2.0 (documentation refers to enums having been modified in version 4.0, not introduced). It looks like your local app is not synced with the server and that's what could be causing the error - could you try to download the symbols from the server and see if the issue persists? Thanks.

It looks like your local app is not synced with the server and that's what could be causing the error

No, there is nothing to sync; these enums are declared and used as table fields within the same app. They aren't from other apps. So downloading symbols is not applicable.
Toy projects do not readily show the problem. I'll have to work on a reduced repro from the actual app that does, to figure out where it goes wrong.

(documentation refers to enums having been modified in version 4.0, not introduced)

That's not ideal. Shouldn't it say when things were first made available, instead of being ambiguous? If you have access to that info, can users/readers have it too? Thanks!

So far I can't replicate all the publish-time problems, but I can this one:
enum 50100 TestEnum
{
    value(1; TestValue1) { }
}

table 50100 TestTable
{
    fields
    {
        field(50100; TestEnumField; Enum TestEnum)
        {
            InitValue = TestValue1;

            trigger OnValidate()
            begin
                if Rec.TestEnumField <> Rec.TestEnumField::TestValue1 then
                    Error('balp.');
            end;
        }
    }
}

VS Code reports no Problems.
But on Publishing to a BC13 server and building there:
[2022-09-09 14:35:10.67] The request for path /NAV/dev/apps?tenant=default&SchemaUpdateMode=synchronize&DependencyPublishingOption=default failed with code UnprocessableEntity. Reason: Extension compilation failed
Table.al(7,25): error AL0294: The type of property value TestValue1 does not match the field’s type.
Table.al(7,13): error AL0167: The property 'InitValue' can only be set if the property 'Type' is set with any of the values of :'BigInteger,Boolean,Code,Date,DateFormula,DateTime,Decimal,Integer,Option,Text,Time,TextConst'

I will update as I manage to replicate more of my original errors, which were failure of the BC13 server to recognise members referenced by Rec.Field::Syntax or pParameter::FieldSyntax.

Here's the others replicated. The problem seems to be simply having `"Quotes" in value names. So BC13 just does not support that, or...?!?
enum 50100 TestEnum
{
    value(1; "Test Value 1") { }
}

table 50100 TestTable
{
    fields
    {
        field(50100; TestEnumField; Enum TestEnum)
        {
            InitValue = "Test Value 1";

            trigger OnValidate()
            begin
                if Rec.TestEnumField <> Rec.TestEnumField::"Test Value 1" then
                    Error('balp.');
            end;
        }
    }
}

codeunit 50100 Test
{
    procedure TestParam(e: Enum TestEnum)
    begin
        if e <> e::"Test Value 1" then
            Error('wut');
    end;
}

giving:
[2022-09-09 14:37:48.17] Publishing AL application using launch configuration 'bc1300-20220523'.
[2022-09-09 14:37:48.56] Publishing package to tenant 'default'
[2022-09-09 14:37:48.56] Targeting server 'http://bc1300-20220523', server instance 'NAV' and tenant 'default'.
[2022-09-09 14:37:48.57] Using user name and password authentication. User name used is: 'admin'.
[2022-09-09 14:37:48.58] Sending request to http://bc1300-20220523:7049/NAV/dev/apps?tenant=default&SchemaUpdateMode=synchronize&DependencyPublishingOption=default
[2022-09-09 14:37:48.87] The request for path /NAV/dev/apps?tenant=default&SchemaUpdateMode=synchronize&DependencyPublishingOption=default failed with code UnprocessableEntity. Reason: Extension compilation failed
Enum.al(12,25): error AL0294: The type of property value "Test Value 1" does not match the field’s type.
Enum.al(12,13): error AL0167: The property 'InitValue' can only be set if the property 'Type' is set with any of the values of :'BigInteger,Boolean,Code,Date,DateFormula,DateTime,Decimal,Integer,Option,Text,Time,TextConst'
Enum.al(27,20): error AL0132: 'e' does not contain a definition for 'Test Value 1'
Enum.al(16,60): error AL0132: 'TestEnumField' does not contain a definition for 'Test Value 1'

So it seems that runtime 2.0 / BC13 are critically limited when it comes to what we can actually do with Enums... then, as I originally said, VS Code should be aware of these limitations and report them as Problems instead of deferring to publish time.

related: https://github.com/microsoft/AL/issues/3566

Thanks for the quick and helpful response! I have checked and this is indeed due to two bugs on our side; quoted enum values are not handled correctly and some properties are not supported for Enums.
Both were fixed from BC 13.1, so I can suggest you to upgrade to a higher version. Unfortunately these will not be fixed for version 13.0, since it is no longer supported.

Thanks! I don't expect them to be fixed 'in' version 13.0, but it would be great if the AL language extension could be made aware of these big limitations, and warn/error to users who try using them when targeting BC13.0 - is that not possible?

We have decided that we will not be making any changes just for BC13.0 unfortunately, since it's long out of support.


Doc updates

Coverage remained the same at 76.207% when pulling 8e0db5cbf2d47721574b3adf37f012756f9094ff on rastislavszabo:master into 7d33424cb720b8e8b95df256f3f457f604370684 on contiv:master.


added rr serve detail in readme

Q
A

Bug fix?
No

New feature?
No

Description
added rr serve detail in readme

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #31   +/-   ##
========================================
  Coverage      97.7%   97.7%
  Complexity      105     105
========================================
  Files            23      23
  Lines           262     262
========================================
  Hits            256     256
  Misses            6       6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e156be0...89818ae. Read the comment docs.

Great! Thx for your contribution!


Mangaplus error

Hey I found this weird behavior, where the script becomes stuck and won’t work anymore until I delete these 1kb files myself and restart the script. I looked on mangadex, and it appears that these mangas have some chapters on mangaplus.

i'll investigate the issue.

also not sure why but your version is reporting wrong total chapters for the language e.g 308 out of 20 for en.

also not sure why but your version is reporting wrong total chapters for the language e.g 308 out of 20 for en.

Maybe it's some sort of misinterpretation. I see this alot when a manga has these 10.3; 10.2; 11.1 chapter style

I saw someone use this for mangaplus downloads in a different mangadex downloader
https://github.com/hurlenko/mloader

Well, The function that's supposed to pick one of the scanlation is misbehaving as in its using the last indexed chapter as the right one it'll take some time to fix it.

I'll try to implement a mangaplus downloader if it's not complex as mangadex else I won't support it for now.

If there is one chapter with mangaplus it will abort the whole manga now and not download existing non mangaplus chapters
after skipping the first manga the second one https://mangadex.org/title/f2fef554-93f3-4340-af6c-cd4123168267/i-m-not-the-hero
is also skipped for mangaplus even when there are no mangaplus chapters.
The third manga
https://mangadex.org/title/f6e7ce00-e09c-4ed2-b806-eb2fdc7a5f60/i-the-strongest-demon-have-regained-my-youth
was also skipped but it contains billibord chapters and mangaplus but also normal uploaded ones that should be grabbed.

skipping chapter-13.zip
skipping chapter-13.5.zip
mangaplus links are not supported for now i hope
getting uuid.
fetching manga info 'Title' 'description' 'status' based on your language setting.
No altTitles with that language found; using default title.
fetching chapters info 'available languages' 'available volumes if any' 'available chapters' 'total chapters (language independent)'.
-------------------------------------------
I'm Not The Hero!
-------------------------------------------
fetching 'chapter list by language' 'total chapters by language.'
found 310 out of 3 for en
getting a server url to download the images from.
starting download
mangaplus links are not supported for now i hope
getting uuid.
fetching manga info 'Title' 'description' 'status' based on your language setting.
No altTitles with that language found; using default title.
fetching chapters info 'available languages' 'available volumes if any' 'available chapters' 'total chapters (language independent)'.
-------------------------------------------
I, the Strongest Demon, Have Regained My Youth!
-------------------------------------------
fetching 'chapter list by language' 'total chapters by language.'
found 311 out of 225 for en
getting a server url to download the images from.
starting download
mangaplus links are not supported for now i hope
getting uuid.
fetching manga info 'Title' 'description' 'status' based on your language setting.
No altTitles with that language found; using default title.
fetching chapters info 'available languages' 'available volumes if any' 'available chapters' 'total chapters (language independent)'.

yes i'm aware sorry for the wait it should be fixed now.


ConversationId should be propagated through the message path

In a distributed messaging system, being able to collect a set of related messages into a logical operation/transaction is extremely helpful in troubleshooting and monitoring. In order to make it easier, the message's ConversationId should be assigned when it is sent or published. If the message is newly created, such as from an IBus or ISendEndpoint, a new ConversationId will be generated if a value is not explicitly assigned.
When a message is published or sent from a consumer, the ConversationId should be copied from the ConsumeContext to the outbound message.

Testing shows this to be legit.


Rendering DateTime contants as SQL timestamp literals breaks comparisons

This bug appears after updating from EF 2.0.3 to EF 2.1.0.
I'm using EF with PostgreSQL.
I have a model with a DateTime field (which becomes a timestamp without timezone in the database).
Let's say it is looks like this:
class Model {
      public DateTime Date { get; set; }
}

And I have added some entries, like this:
var models = new[] {
    new Model() { date = DateTime.MaxValue };
    new Model() { date = DateTime.Now };
}
context.AddRange(models);

So that I have the following in the database:

Date

9999-12-31 23:59:59.999999

2018-06-07 11:41:34.6655

Then, when I try to select some entries, depending on how I pass the datetime value to the query, it gives different results (after updating to EF 2.1.0), because, as the logs show, in the first case, the value gets rendered into a SQL timestamp literal with only milliseconds precision.
Case 1: Fails
Assert.Equal(1, context.Models.Where(x => x.Date == DateTime.MaxValue).Count());

Case 2: Works
var date = DateTime.MaxValue;
Assert.Equal(1, context.Models.Where(x => x.Date == date).Count());

Queries logged:
Case 1:
[2018-06-07 11:50:56.867 -03:00] [INF] Executed DbCommand (1ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
SELECT COUNT(*)::INT4
FROM "Models" AS x
WHERE x."Date" = TIMESTAMP '9999-12-31 23:59:59.999'

Case 2:
[2018-06-07 12:04:43.101 -03:00] [INF] Executed DbCommand (0ms) [Parameters=[@__date_0='12/31/9999 23:59:59' (DbType = DateTime)], CommandType='Text', CommandTimeout='30']
SELECT COUNT(*)::INT4
FROM "Models" AS "x"
WHERE "x"."Date" = @__date_0

@filipelbc Can you please file this on https://github.com/npgsql/Npgsql.EntityFrameworkCore.PostgreSQL/issues since the issue is most likely that the PostgreSQL provider needs to override literal generation for this mapping.


Add run-time type checking to loaders

Modify ValueSetLoader and QuestionnaireLoader to check validity of the resources before returning. Unit tested everything
Apparently the questionnaire we had in our unit tests wasn't actually valid so I changed it.
to test the behavior, feel free to change some of the resources in public/static to be invalid fhir and it should yell at you.
WEIRDNESS: For some reason, the valuesets weren't validating against the interfaces because of the description property not playing nicely with the "markdown" data type (??). I think this is a bug in the typescript library, so I added a workaround and will report the issue to that repo

Reviewed...everything looks good and the functionality is as intended minus the valueset validation.


Add unit test for doc comments. [phab:D1244]

Created by fromberger at 2017-01-10 21:00:26:
Enable comments in the file parser.
Go indexer: Add doc nodes for declarations that have them.

fromberger wrote at 2017-01-10 21:34:38:
Make the commit description more useful.

zarko commented inline (context lost during migration) at 2017-01-10 23:23:21:
Are these the same node or different nodes with duplicate text?

zarko accepted this revision at 2017-01-10 23:23:21

fromberger commented inline (context lost during migration) at 2017-01-10 23:33:26:
The latter. Updated the comment.

fromberger wrote at 2017-01-10 23:34:02:

Clarify a comment about comment-text handling.

fromberger closed via commit 04da424ca51cc8472b02e3ad3f3bb86acf3930fa at 2017-01-10 23:42:37


Table list becoming buggy in sql lab when there is a table view

Bug description
I have installed superset v3.0.1 using the helm chart v0.10.11 on GKE. I recently encountered a UI issue (attached below) in sqllab, using a doris database connection and when viewing the table list. Tables names become overlapping as can be seen. assignator_store_data is a view in our db and the rest are tables(~15). If I select any of the assignator_store_data, I still get data only related to assignator_store_data in the data preview. This is the first time we have used a view and got this issue, previously there were only tables in our database and there were no such issue.
How to reproduce the bug

Go to sqllab
Select a doris connection
Select the desired db/schema which has a view
Scroll the list of tables up and down

Screenshots/recordings
https://github.com/apache/superset/assets/6321314/fbc398c9-a23c-4f1a-a1cb-fd3177d9cb60
Superset version
3.0.3
Python version
3.9
Node version
Not applicable
Browser
Chrome
Additional context
My data source is in Doris.
Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

Hi there! Sorry nobody has corroborated your issue, but we're no longer supporting Superset 3.0.x. If you can repro this issue in 3.1 or better yet 4.x, we can certainly re-open it. Otherwise, I would have probably closed this as stale anyway. Have you found a workaround or any other context you can provide? Thanks!


Fix full covariance method and add example

This fixes the full cov method and adds an example similar to the original ipython notebook. If you prefer, I can merge them separately, but since they are related, I thought it'd be fine to merge them together.

I'll split the pull into "Adding example" and Python 2/3 compatibility.

Sorry for the spamming. I'm not sure how to split the pull request into two. (Is this even possible?)


Update docs

Codecov Report

Merging #288 (3dd278b) into master (2ee8872) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #288   +/-   ##
=========================================
  Coverage     83.92%   83.92%
  Complexity     1101     1101
=========================================
  Files           148      148
  Lines          3209     3209
  Branches        391      391
=========================================
  Hits           2693     2693
  Misses          421      421
  Partials         95       95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee8872...3dd278b. Read the comment docs.


[Bug] mac os maven build  source code error

Bug Type (问题类型)
others (please comment below)
Before submit

[X] I had searched in the issues and found no similar issues.

Environment (环境信息)

Toolchain Version: v1.0.0

Expected & Actual behavior (期望与实际表现)
mvn clean install -DskipTests -X
hubble-dist model error
Caused by: org.apache.maven.plugin.MojoExecutionException: An Ant BuildException has occured: exec returned: 1
around Ant part ...<exec failonerror="true" dir="/incubator-hugegraph-toolchain/hugegraph-hubble/hubble-dist/.." executable="bash">... @ 18:147 in /incubator-hugegraph-toolchain/hugegraph-hubble/hubble-dist/target/antrun/build-main.xml

Vertex/Edge example (问题点 / 边数据举例)
No response
Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)
No response

npm install --global yarn

nodejs node-v18.12.1
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:133:10)

Open terminal and paste these as described:
export NODE_OPTIONS=--openssl-legacy-provider

build success


[MoltenVK][MSL] When MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS is 1, IDs for descriptors in buffers are re-used, causing an error

I'm running a Vulkan program with MoltenVK. When I tried to use MVK_CONFIG_USE_METAL_ARGUMENT_BUFFERS=1 to increase performance, I ran into a shader compilation error.
The original SPIR-V shader is here: https://gist.github.com/expenses/c9ac3bad847cbcfeb709e9db0a5305a0
The translated metal shader is here (condensed as much as possible):
#include <metal_stdlib>
#include <simd/simd.h>

using namespace metal;

...

struct spvDescriptorSetBuffer0
{
    array<texture2d<float>, 127> m_95 [[id(0)]];
    sampler m_96 [[id(127)]];
    device _138* m_97 [[id(128)]];
    constant _139* m_98 [[id(129)]];
    sampler m_99 [[id(130)]];
};

struct spvDescriptorSetBuffer2
{
    constant uint* spvBufferSizeConstants [[id(0)]];
    device _140* m_100 [[id(0)]];
};

struct spvDescriptorSetBuffer3
{
    texture2d<float> m_101 [[id(0)]];
};

struct fragment_transmission_out
{
    float4 m_8 [[color(0)]];
};

struct fragment_transmission_in
{
    float3 m_3 [[user(locn0)]];
    float3 m_4 [[user(locn1)]];
    float2 m_5 [[user(locn2)]];
    uint m_6 [[user(locn3)]];
    float m_7 [[user(locn4), flat]];
};

fragment fragment_transmission_out fragment_transmission(fragment_transmission_in in [[stage_in]], constant spvDescriptorSetBuffer0& spvDescriptorSet0 [[buffer(0)]], constant spvDescriptorSetBuffer2& spvDescriptorSet2 [[buffer(2)]], constant spvDescriptorSetBuffer3& spvDescriptorSet3 [[buffer(3)]], constant uint* spvBufferSizeConstants [[buffer(6)]], constant _137& _94 [[buffer(4)]])
{
    ...
}

The error I get is:

[mvk-error] VK_ERROR_INITIALIZATION_FAILED: Shader library compile failed (Error code 3):
program_source:129:201: error: cannot assign resource locations to 'spvDescriptorSet2'
fragment fragment_transmission_out fragment_transmission(fragment_transmission_in in [[stage_in]], constant spvDescriptorSetBuffer0& spvDescriptorSet0 [[buffer(0)]], constant spvDescriptorSetBuffer2& spvDescriptorSet2 [[buffer(2)]], constant spvDescriptorSetBuffer3& spvDescriptorSet3 [[buffer(3)]], constant uint* spvBufferSizeConstants [[buffer(6)]], constant _137& _94 [[buffer(4)]])
                                                                                ^
program_source:107:18: note: attribute 'id' set location to 0, but minimum is 1
    device _140* m_100 [[id(0)]];
                 ^       ~~~~~

I don't know the exact steps that MoltenVK goes through to compile shaders but hopefully this is reproducable.
In case it helps, the full log of the program is here: https://gist.github.com/expenses/7a8e11b94b252db0607288d823a451fe

My guess is that when these spvDescriptorSetBuffer structs are created, the constant uint* spvBufferSizeConstants doesn't increase some id value when it really should.

Descriptor set 2 in this shader contains a single decriptor that is an unsized array (storage buffer in Vulkan) of structs - see https://github.com/expenses/transmission-renderer/blob/8323cdd5cc15ee762b135e5f248e40a6b7eeb218/shader/src/lib.rs#L48.

I think I have a triangle for this case.
GLSL code:
#define BINDING_PARAMBUFFER 0
#define BINDING_CHECKPOINT_DATA 1

struct CheckpointInterfaceDataParams
{
	uvec4 Data;
};

layout(std140, binding = BINDING_PARAMBUFFER) uniform CheckpointInterfaceData
{
	CheckpointInterfaceDataParams params;
};

struct CheckpointDataStruct
{
	uint lower;
	uint upper;
	uint phase;
	uint type;
};

layout(std430, binding=BINDING_CHECKPOINT_DATA) buffer CheckPoints
{
	uint count;
	uint padding[3];
	CheckpointDataStruct checkPoints[];
} Data;

layout(local_size_x = 1) in;
void main()
{
	if (gl_GlobalInvocationID.x == 0)
	{
		uint myIndex = atomicAdd(Data.count, 1);
		uint arrayIndex = myIndex % Data.checkPoints.length();
		Data.checkPoints[arrayIndex].lower = params.Data.x;
		Data.checkPoints[arrayIndex].upper = params.Data.y;
		Data.checkPoints[arrayIndex].phase = params.Data.z;
		Data.checkPoints[arrayIndex].type = params.Data.w;
	}
}

SPIR-V generation and crosscompiling to Metal:
glslc -std=430 -fshader-stage=compute shader.glsl
spirv-cross --msl a.spv --output shader.metal --msl-version 20100 --msl-argument-buffers

Resulting Metal shader:
#pragma clang diagnostic ignored "-Wunused-variable"

#include <metal_stdlib>
#include <simd/simd.h>
#include <metal_atomic>

using namespace metal;

struct CheckpointDataStruct
{
    uint lower;
    uint upper;
    uint phase;
    uint type;
};

struct CheckPoints
{
    uint count;
    uint padding[3];
    CheckpointDataStruct checkPoints[1];
};

struct CheckpointInterfaceDataParams
{
    uint4 Data;
};

struct CheckpointInterfaceData
{
    CheckpointInterfaceDataParams params;
};

constant uint3 gl_WorkGroupSize [[maybe_unused]] = uint3(1u);

struct spvDescriptorSetBuffer0
{
    device CheckPoints* Data [[id(0)]];
    constant CheckpointInterfaceData* m_45 [[id(1)]];
    constant uint* spvBufferSizeConstants [[id(2)]];
};

kernel void main0(constant spvDescriptorSetBuffer0& spvDescriptorSet0 [[buffer(0)]], constant uint* spvBufferSizeConstants [[buffer(25)]], uint3 gl_GlobalInvocationID [[thread_position_in_grid]])
{
    constant uint& spvDescriptorSet0_DataBufferSize = spvDescriptorSet0.spvBufferSizeConstants[0];
    if (gl_GlobalInvocationID.x == 0u)
    {
        uint _32 = atomic_fetch_add_explicit((device atomic_uint*)&(*spvDescriptorSet0.Data).count, 1u, memory_order_relaxed);
        uint myIndex = _32;
        uint arrayIndex = myIndex % uint(int((spvDescriptorSet0_DataBufferSize - 16) / 16));
        (*spvDescriptorSet0.Data).checkPoints[arrayIndex].lower = (*spvDescriptorSet0.m_45).params.Data.x;
        (*spvDescriptorSet0.Data).checkPoints[arrayIndex].upper = (*spvDescriptorSet0.m_45).params.Data.y;
        (*spvDescriptorSet0.Data).checkPoints[arrayIndex].phase = (*spvDescriptorSet0.m_45).params.Data.z;
        (*spvDescriptorSet0.Data).checkPoints[arrayIndex].type = (*spvDescriptorSet0.m_45).params.Data.w;
    }
}

See how device CheckPoints* Data [[id(0)]]; has id(0)


Roll engine f80928a9e403..5809adea4156 (3 commits)

https://github.com/flutter/engine/compare/f80928a9e403...5809adea4156
git log f80928a9e403c6b2fc1b8de6a00bf6189b715c40..5809adea415605b821704967cd9e0b0fc05ce34a --no-merges --oneline
5809adea4 Make the layout of dynamic patch bundle similar to APK. (flutter/engine#7925)
e2a449a51 Move canvas clear after preroll (flutter/engine#7923)
8529dbc86 Remove unused FML file export.h (flutter/engine#7926)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (amirha@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


Improve front page

Context
Our previous head of technical writing pointed out that our docs front page has some style and structure issues.
Changes proposed in this pull request
Improve the front page so that it's as concise as possible by:

renaming it from 'documentation' it 'technical documentation' - to make the intended users clearer, in line with other docs like Verify and Registers
starting with a summary of what you can do with the docs - again in line with Verify, Registers, etc
directing non-technical users more clearly to the product and features pages
no longer unnecessarily describing how to use the navigation
improving the style

Guidance to review
Please check we haven't lost anything essential.

@miriamalice I've updated this following our conversation - it's ready for review.


CASMINST-6470: Update chart redeploy procedure

Description
In a number of places in the docs we have administrators redeploy charts, for a variety of reasons. These are not done in a uniform way. Many of them assume that the loftsman manifest from the CSM install/upgrade will exist unchanged in the loftsman Kubernetes configmap, while others overwrite it, in some cases overwriting it with most of the charts removed.
I raised this issue in a Slack DM and there has been much discussion about what we should be doing. I am not an expert on this, but I do know we need to make some change to the docs to at least make sure we aren't overwriting things, or having customers regress product versions inadvertently.
This PR updates chart redeploy procedure to prevent overwriting existing manifests while still using correct versions and customizations. It is not meant to be the ideal eventual solution to the problem, It is just meant to get rid of the worst problems we currently face:

Procedures that overwrite previously-deployed manifests, including those from the CSM install/upgrade
Procedures which assume that the "correct" version for a chart is the one from that manifest, even though hotfixes may have been subsequently deployed
Generally inconsistent procedures

It does this by making one page which outlines how to redeploy a chart. The high level procedure it uses is:

Download the customizations from Kubernetes and (optionally) make changes.
Download the base CSM install/upgrade manifest for the chart in question
Make a copy of that manifest file that strips out all of the charts except for the one being redeployed, and which gives the manifest a unique name (so it won't overwrite the original when deployed)
Look to see if the most recent loftsman deployment of the chart (which may be more recent than the CSM upgrade/install) is using a different version. If so, update your copied file with that version number.*

I used a small shell script for this, because it's tedious work. I originally wrote the shell script when toying with ways to handle this for CSM hotfix deploys. We ended up not using it there, but I had tested it pretty well for that purpose. It seems better and less error-prone than having the admin have to do that stuff manually.

Apply the customizations to your file.
Redeploy the chart
If you made customizations changes, then upload them back into K8s

The plan is for other pages to reference this procedure when needing to redeploy a chart.
PLEASE BEAR IN MIND that this is NOT meant to be the eventual solution. This is just meant to be something that isn't going to break customer systems the way our current procedures risk doing.

Checklist

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[X] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[X] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

Working on backports


raftstore,cdc: pass leader transferee to cdc observer

What is changed and how it works?

Issue Number: Close #12111, close pingcap/tiflow#4761
What's Changed:
Pass leader transferee to cdc observer

Check List
Tests

Unit test
Integration test

Release note
Pass leader transferee to cdc observer to reduce TiCDC latency spike.

In favor of https://github.com/tikv/tikv/pull/12124, closed.


Run integration tests with Python 3.9 and 3.10

This PR requires changing the branch protection rule to require checks "Integration tests (3.9)" and "Integration tests (3.10)" instead of "Integration tests".