Reporting: Display test results and/or code coverage when the build is done

Hi folks,
I like the idea of how jenkins build results can be visualized using dashing. For example: https://gist.github.com/akalyaev/6391422.
Would it be possible to display an additional metric when the build is finished? e.g.

class coverage in %
line coverage in %
successful unit tests in %

This could be achieved using a different colour/structure combination than the one used while the build is running. Maybe something like this:

What do you think?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

+1
It will be a nice feature and a value add too. :+1:

This would be a really handy feature! instead of a green or red a balance to show some passed some failed with coverage details.

+1
I think that number of failed tests could also be interesting. Projects with lots of tests will have very small percentage of failing tests.

+1. In many cases having only Green/Red/Yellow build in radiator does not show the full picture.  It would be useful to know either % or amount of tests failed vs. test run. E.g. , "8 / 160 tests failed" or "95% of tests passed."
Alternatively build monitor could include similar view like Jenkins Test Trend Chart showing passed/failed/skipped test statistics from job executions.

I like the Test Trend Chart/Sparkline idea - pull requests are very welcome :-)

+1 Coverage display on completed builds would be great.

+1

Agreed. It would be awesome to have this. +1

+1

Not as glamorous as the example provided by @luebbe (yet!), but the coverage could be displayed using a build badge. Please see #258 and the release notes for more details.
Hope this helps,
Jan
Ps.
If it doesn't help - please do let me know ;-)

Very cool! I'll try it out ASAP :)


Improve the docs of no_input when using defaults

Remove the exsitings TODOs
Add an example.

[Current coverage][cc-pull] is 99.66%

Merging [#701][cc-pull] into [master][cc-base-branch] will increase coverage by -0.32%

File ...ookiecutter/utils.py (not in diff) was modified. more

Misses +2
Partials 0
Hits -2

@@           master       #701   diff @@
========================================
  Files          13         13
  Lines         583        583
  Methods         0          0
  Messages        0          0
  Branches        0          0
========================================
- Hits          583        581     -2
- Misses          0          2     +2
  Partials        0          0

[][cc-pull]

Powered by Codecov. Last updated by [32e54ef...14246fc][cc-compare]
[cc-base-branch]: https://codecov.io/gh/audreyr/cookiecutter/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/audreyr/cookiecutter/compare/32e54ef6e46274ce832a90c570c08cbeb4ac8a77...14246fc9805937049e68160899cb04a0cd5b649c
[cc-pull]: https://codecov.io/gh/audreyr/cookiecutter/pull/701?src=pr

🔔

Let me know if you expect my to rebase and squash both commits in one. So when the patch is ready for mergin I will squash them in a single commit.

@pokoli Can you please rebase? #749 splits up the advanced usage docs.

@michaeljoseph  Fixes comments and rebased!

Thanks @pokoli! 🍰


ml-kem: initial public preview release.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.67%. Comparing base (0b586f0) to head (25166da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   87.67%   87.67%
=======================================
  Files          62       62
  Lines        4664     4664
  Branches      533      533
=======================================
  Hits         4089     4089
  Misses        574      574
  Partials        1        1

Flag
Coverage Δ

unittests
87.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New Features and Further Documentation Expansion

What are you trying to accomplish?
As it stands, the bot is a very serious individual. This PR aims to give it a small amount of fun stuff for members to play with.
How are you accomplishing it?
~train -> bot responds with the train from the sl (steam locomotive) command
~jail/~free -> bot puts the text passed as arguments into a jail cell with an open/closed door
Additionally, a new file (FEATURES.md) has been added which contains documentation on the specific features the bot comes with.
Is there anything reviewers should know?
train has a default 5-minute cooldown, server-wide, while jail and free have a 2 minute cooldown per user.

[x] Is it safe to rollback this change if anything goes wrong?

this looks good, good job dude :+1:


Undefined function 'GWMCMC'

The toolbox refers to the GWMCMC function, which is not provided. There is an existing implementation of GWMCMC in Github but that doesn't seem to have the argument syntax apparently used within this toolbox. Please provide the GWMCMC code or a reference to a compatible 3rd party implementation to make your toolbox usable. Thanks!

Hi,
Thank you for noticing this issue. I have now added the missing functions.
Please try again and get back to me if it doesn't work.
Best regards,
Max


Update InlineWrapper.d.ts

Description
This props must be optional, otherwise the examples wouldn't work.

Ohh, god (

Thanks for the very fast response! 👍

This wasn't fixed in 1.0, am I wrong?


FHB-52 Service detail page changes part 2

Adds the display of service-level schedules to the service details page, matching how services are displayed in Manage.
How we display service-level schedules is being revisited. If we display them the same as Manage, this should be good to do.
If we decide to change the display to better handle possible combinations in LA ingested services, then it'll need to be reworked appropiately.

Replaced with this PR...
https://github.com/DFE-Digital/fh-services/pull/85


⚠ ETF has degraded performance

In f0e9502, ETF (https://markets.hankyung.com/equity-product/etf) experienced degraded performance:

HTTP code: 200
Response time: 7047 ms

Resolved: 신규상장 performance has improved in 287cd80.


CSI provisioned volumes are missing "kubernetes.io/created-for" tags in Openstack

/kind feature
The binaries affected:

[x] cinder-csi-plugin

What happened:
Provisioning a CSI Cinder volume works, but it does not have any tags metadata that identify the PVC:

kubernetes.io/created-for/pvc/namespace
kubernetes.io/created-for/pvc/name
kubernetes.io/created-for/pv/name

What you expected to happen:
I would expect the tags to be present. This is a regression from the in-tree openstack cloud controller manager.
Anything else we need to know?:
With CSI, we get a new tag called cinder.csi.openstack.org/cluster, which is useful, which means the support for tags is there, just maybe incomplete?
Environment:

openstack-cloud-controller-manager version: v14.0.0

/assign

@lingxiankong I read the link you provided, as lack of some background , I assume this PR requirement is doable or technically/arch prevent us to do so？

@jichenjc changes should be made in external-provisioner, not cinder-csi-plugin

@lingxiankong got it ,thanks~, so should we close this issue?

We could, but I'm ok we leave it as is, just in case one day external-provisioner could pass that information to cinder-csi.

@lingxiankong why manila can create this tag? seems arch is same why we can't do in cinder only is a question..

I don't think https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/share/manila/share.go#L121 is part of manila-csi-plugin, and based on my understanding, manila-csi-plugin doesn't interact with Cinder.

I understand it doesn't interact with cinder, the question is if manila plugin is able to impelement CSI with the tags, then it should be ok for cinder, but as you mentioned, the  https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/share/manila/share.go#L121  is not part of manila plugin, then it's another topic ... need check manila code as well


Add gateway-38 repo keys

Description

Adds the keys from https://cloudsmith.io/~kong/repos/gateway-38/pub-keys
This is a no-op.
Testing instructions
Preview link:
Checklist

[x] Review label added
[x] Conditional version tags added, if applicable.

Similar to the gateway-37 PR: https://github.com/Kong/docs.konghq.com/pull/6776


Make Screen State Logic & Screen Component: Home Screen

Creating this ticket to capture the work to add Screen states to the React front end so that we can load screen components

Details:

Create a screen component for Home Screen that uses created child compents
Create state logic to decide what screen to show on App.js. This logic will be the coding framework each of us will use to add the screen components we build to the main app.

Ended up using react router for this. and created all the screen components for the screen


Lyric Icon Missing

🧐 Have you fully read the README and viewed similar issues?

[X] I have read the README
[X] I have read the FAQ
[X] I have checked previous issues, open and closed
[X] I have completed all troubleshooting steps and the issue is not present on stock but returns after re-applying SpotX-Bash

Сountry of your account
United States
What is your Spotify Plan?
Free
Do you have Spicetify installed?
Yes
ℹ Computer information
- Spotify version: <IP_ADDRESS>1.g0348b2ea
- OS: macOS 13.6.2 (Apple Silicon)
- Shell: zsh

📝 Description
Lyric icon is showing before installing SpotX-Bash, but disappears after install.
🖥 Terminal Input/Output
bash <(curl -sSL https://spotx-official.github.io/run.sh)
📸 Screenshots


display timings at the end of the export

Since script was running almost 1 hours to export all (9929  Rows) …. I would like also see timings “Elapsed: 01:02:00.000” to know how much time I can expect on next run 😊


MMKVNative bindings not installed

I did exactly how you mentioned in the docs but still getting this error: "MMKVNative bindings not installed"
here is my code
import { MMKVLoader, useMMKVStorage } from "react-native-mmkv-storage";

const MMKV = new MMKVLoader().initialize();

const App = () => {
  const [user, setUser] = useMMKVStorage("user", MMKV, "robert"); // robert is the default value

  return (
    <View>
      <Text>{user}</Text>
    </View>
  );
};

You need to rebuild your native part after installing the package

I'm new to react-native could you please explain how am i supposed to do that?

is it when you run iOS part? if so - just rebuild your project in the XCode

i have a same, when i enable debug in react native, but if i release or run it work fine

I'm having the same issue.

I am running it in the development mode using expo so, how can i go without building it.

I am using Expo as well and I ran Expo Prebuild first.  That creates the ios and Android folders etc.  Then I did the steps I listed above.

My application isn't complete yet is it ok to make a prebuild of it ? @dcassese

@saroj-regmi yes it's okay.

@saroj-regmi yes it's okay.

What is the solution for android??

In your Android / App folder add this to your build.gradle file
implementation 'com.tencent:mmkv-static:1.2.13' under the dependencies section

My test suite is failing with the above error. I even followed all the steps the documentation mentioned to mock the library.

I have exaclty the same problem wich appeared on Firebase recently :

It's strange because when i debug it, its working, but i endup having this error when i publish my app in the store.
It's only on Android 13. And i have followed all previous steps.

I too am getting this error when mocking via the docs for Jest. For now, my workaround is to just mock what I need in the jest/setup.ts file I have
// setup.ts
jest.mock("react-native-mmkv-storage", () => ({
  MMKVLoader: () => ({
    withInstanceID: () => ({
      initialize: () => ({
        getArray: (arr: any[]) => arr,
      }),
    }),
  }),
}));

Any movement on this? I get this error when trying to use react-native-debugger  and on iOS Simulator -> Shake (Dev menu) -> Debug with Chrome. Would love to be able to debug my app!!

I’ve been waiting on these developers to fix this project for almost 2 years. Our company has long since moved on. I suggest finding another solution

My mock solution for the error when using Jest with typescript:
jest.mock('react-native-mmkv-storage', () => ({
    MMKVLoader: jest.fn().mockImplementation(() => {
        return {
            setAccessibleIOS: jest.fn().mockReturnThis(),
            withEncryption: jest.fn().mockReturnThis(),
            initialize: jest.fn().mockReturnThis(),
        }
    }),
    IOSAccessibleStates: {
        WHEN_UNLOCKED: 'AccessdfdffdfdsfdfsddsfsibleWhenUnlocked',
        AFTER_FIRST_UNLOCK: 'AccessibleAfterFirstUnlock',
        ALWAYS: 'AccessibleAlways',
        WHEN_PASSCODE_SET_THIS_DEVICE_ONLY: 'AccessibleWhenPasscodeSetThisDeviceOnly',
        WHEN_UNLOCKED_THIS_DEVICE_ONLY: 'AccessibleWhenUnlockedThisDeviceOnly',
        AFTER_FIRST_UNLOCK_THIS_DEVICE_ONLY: 'AccessibleAfterFirstUnlockThisDeviceOnly',
        ALWAYS_THIS_DEVICE_ONLY: 'AccessibleAlwaysThisDeviceOnly',
    },
}))

Looks like this error doesn't have solution yet

My test suite is failing with the above error. I even followed all the steps the documentation mentioned to mock the library.

This mock works for me. This also addresses the TypeError: storage.getItem is not a function error for redux persist with react-native-mmk-storage as the storage.
jest.mock('react-native-mmkv-storage', () => ({
  MMKVLoader: jest.fn().mockImplementation(() => {
    return {
      setAccessibleIOS: jest.fn().mockReturnThis(),
      withEncryption: () => ({
        initialize: () => ({
          getItem: async () => jest.fn(),
          setItem: async () => jest.fn(),
        }),
      }),
      initialize: () => ({
        getItem: async () => jest.fn(),
        setItem: async () => jest.fn(),
      }),
      withInstanceID: () => ({
        initialize: () => ({
          getItem: async () => jest.fn(),
          setItem: async () => jest.fn(),
        }),
      }),
    };
  }),
  IOSAccessibleStates: {
    WHEN_UNLOCKED: 'AccessibleWhenUnlocked',
    AFTER_FIRST_UNLOCK: 'AccessibleAfterFirstUnlock',
    ALWAYS: 'AccessibleAlways',
    WHEN_PASSCODE_SET_THIS_DEVICE_ONLY:
      'AccessibleWhenPasscodeSetThisDeviceOnly',
    WHEN_UNLOCKED_THIS_DEVICE_ONLY: 'AccessibleWhenUnlockedThisDeviceOnly',
    AFTER_FIRST_UNLOCK_THIS_DEVICE_ONLY:
      'AccessibleAfterFirstUnlockThisDeviceOnly',
    ALWAYS_THIS_DEVICE_ONLY: 'AccessibleAlwaysThisDeviceOnly',
  },
}));

Courtesy: @nazmeln & @CoryWritesCode

I've also been getting this error with expo managed workflow. Anyone find a fix?

I also get this error, BUT only when using Expo Go on my actual iPhone. If I open the iOS simulator on my mac it works completely fine. So, for now I can keep working, but I doubt I can ignore this. Does anyone have any ideas?

Hi,
I have run app with RN Debugger and getting the following error :

@roshanShendre13 I was having this same error.  Upgrading to v0.10.3 fixed it.

this is not fixed with newArchEnabled = true
however without new architecture 0.10.3 is working

Hmm I'm using v0.10.3 and it's giving me the same eror. @Athar-glut @MrMicrowaveOven what did you two do to get it to work?

Hmm I'm using v0.10.3 and it's giving me the same eror. @Athar-glut @MrMicrowaveOven what did you two do to get it to work?

newArchEnabled = true
you need to set newArchEnabled to false

Hmm I'm using v0.10.3 and it's giving me the same eror. @Athar-glut @MrMicrowaveOven what did you two do to get it to work?

newArchEnabled = true you need to set newArchEnabled to false

Where do I set this?


Backward compatible metadata

Cookbook version
4.1.1
Chef-client version
Irrelevant
Platform Details
Chef Server 11
Scenario:
Uploading cookbook to old versions of chef-server (11)
Actual Result:
Chef Server does not understand issue_url and source_url in the metadata
Possible solution
source_url       'https://github.com/chef-cookbooks/windows' if respond_to?(:source_url)
issues_url       'https://github.com/chef-cookbooks/windows/issues' if respond_to?(:issue_url)

This cookbook requires Chef 12.7 or later and Chef 11 hasn't been a supported release of Chef for about a year now. If you need Chef 11 support you'll need to install an older version of this cookbook since none of the resources will run on Chef 11 either.

@tas50  by

Chef 12.7
you mean chef-client or chef-server?  We have issues uploading to chef-server not with running the chef-client cookbook

@tas50
So by Chef 12.7 you meant chef version on the Chef Wokrstation. After I have updated the ChefDK on the Chef Workstation it uploaded correctly


generate.py does not support paths with spaces or special characters

Little hurdle in using your library: the generate.py paths aren't handling path names with spaces and special characters.
Steps:

(On osX 10.10.2) Download ionicons to your google drive: '/Users/devuser/Google Drive/icons&stuff'.

Follow build instruction "5) Run the build command:
python ./builder/generate.py"

Expected:
Beautiful icons are generated.
Actual:
Errno 2:
fontforge: can't open file '/Users/devuser/Google': [Errno 2] No such file or directory

then...
Generate CSS From SCSS
/bin/sh: stuff/ionicons-2.0.1/builder/../scss/ionicons.scss: No such file or directory

Workaround:
Move to path without spaces or special characters or edit generate.py file.

+1

Fix #244 worked for me! Thanks.


fix(README.md): add examples to Git Commit Guidelines in README.md

Updates the Git Commit Guidelines with a few additional examples to help ensure future PRs can easily conform to desired commit message structure.
PR made in reference to this comment & this comment.
@jeff-phillips-18

Quick Q, should there be more than fix, perf, and feat?  I see one example in the history:
chore(pfToolbar): fix typo in directive name and link from 'componenet' to 'component'
chore is not doc'd here.

Hi,  chore will be merged but not update the version at all.  Yeah, I didn't see it documented either, but that is what it does :-)

Correct, chore is documented in the link but not here.
This should be a chore so as not to cause a release.

So something like:
##### Non-Release

chore(foo): some minor change that should not trigger an automated release.

So something like:
Non-Release
chore(foo): some minor change that should not trigger an automated release.

Yes, that would be perfect

Done


suggestion: add ctrl + alt + w hotkey to show electronic-wechat

as same as windows wechat client

agree!


Replace LGTM with Github Actions

Originating Project/Creator

Affected Component

Affected Architectures(s)
Github Actions

Related Issue(s)

Has Unit Tests (y/n)

Builds Without Errors (y/n)

Unit Tests Pass (y/n)

Documentation Included (y/n)

Change Description
Adds a Github Actions workflow that runs the security and quality static code analysis in order to phase LGTM out.
Rationale
lgtm.com will be shut down at the end of the year.
Future Work
Remove the LGTM configuration files once it's fully shut down.
Comments
Results should be viewable once the checks are done. It's currently running all queries from the security-and-quality suite, let me know if we want to filter some categories out.

@thomas-bc can you add these words to .github/actions/spelling/expect.txt?  This is how to fix the spelling issues.  I found these in the spelling action log:

configs
deserializes
funcs
toolchains


chore(RHTAPREL-304): add alerting for release service SLOs

add SLO alert rules for the Release Service

ReleaseServiceProcessingDuration:
90% of the releases should be processed under 1 hour

ReleaseServiceStartProcessingSeconds:
90% of the releases should start processing under 10 seconds

ReleaseServiceValidationSeconds:
90% of the releases should be validated under 5 seconds
Signed-off-by: Leandro Mendes<EMAIL_ADDRESS>

Depends on https://github.com/redhat-appstudio/release-service/pull/331

/test

@theflockers can you rebase the PR? There were some changes in the tests we're running and until the code is rebased, it's expecting status from tests that do not exist anymore.

@theflockers can you rebase the PR? There were some changes in the tests we're running and until the code is rebased, it's expecting status from tests that do not exist anymore.

sure. On it.


[WIP] Multi Account

Using the same approach with App Shortcuts I'm working on the multi account support since the reddit library already supports it.
It allows to add/remove accounts (using a Repository), switch to another or logout (while keeping the authentication data). The list can also be ordered by drag 'n' drop (same as app shortcuts).

[x] Able to Login (add account)

[x] Store users

[x] Switch between users

[x] Delete an account  (Although no confirmation)

[x] Add delete confirmation ?

[x] Logout and become userless

[x] Improve swipe actions

[ ] Investigate crashes

[ ] Testing

[ ] Code Clean Up

[ ] Use Kotlin classes

Quick problem: On fresh install when you have no accounts added application crashes when you click on profile icon.

Also, is there any reason why you decided to implement new classes in Java instead of Kotlin? I would generally prefer to have the codebase move more into Kotlin side so it would be good to have all new code written in Kotlin. Unless there is a strong reason why we wouldn't want to do that.

Well that crash is new to me. I stil have a lot to do with this, so I'll check that when I can.
I end up using the java classes since I the UI is based on the App Shortcuts. I'll make checkbox for that.

I end up using the java classes since I the UI is based on the App Shortcuts. I'll make checkbox for that.

Ok, I see. I would suggest to go for Kotlin in any new classes in future. Here you can leave this in Java since you already wrote working code. But if you want to change it's up to you to decide :)

Ok, I see. I would suggest to go for Kotlin in any new classes in future. Here you can leave this in Java since you already wrote working code.  I didn't know that. Will do for sure.

Quick problem: On fresh install when you have no accounts added application crashes when you click on profile icon.
Caused by: com.tspoon.traceur.TraceurException: Debug Exception generated at call site
	at dalvik.system.VMStack.getThreadStackTrace(Native Method)
	at java.lang.Thread.getStackTrace(Thread.java:1538)
	at io.reactivex.Flowable.scanWith(Flowable.java:12176)
	at io.reactivex.Flowable.scan(Flowable.java:12136)
	at me.saket.dank.utils.RxDiffUtil.lambda$calculateDiff$3(RxDiffUtil.java:46)
	at me.saket.dank.utils.-$$Lambda$RxDiffUtil$6HorHZveN0l7jbBNwJhmbIeQPVc.apply(Unknown Source:4)
	at io.reactivex.Flowable.compose(Flowable.java:6658)
	at me.saket.dank.ui.usermanagement.UserManagementActivity.setupUserList(UserManagementActivity.java:247)
	... 14 more
Caused by: com.tspoon.traceur.TraceurException: Debug Exception generated at call site
	at dalvik.system.VMStack.getThreadStackTrace(Native Method)
	at java.lang.Thread.getStackTrace(Thread.java:1538)
	at io.reactivex.Flowable.skip(Flowable.java:12340)
	at me.saket.dank.utils.RxDiffUtil.lambda$calculateDiff$3(RxDiffUtil.java:51)
	... 17 more
Caused by: com.tspoon.traceur.TraceurException: Debug Exception generated at call site
	at dalvik.system.VMStack.getThreadStackTrace(Native Method)
	at java.lang.Thread.getStackTrace(Thread.java:1538)
	at io.reactivex.Flowable.fromPublisher(Flowable.java:2127)
	... 16 more
Caused by: com.tspoon.traceur.TraceurException: Debug Exception generated at call site
	at dalvik.system.VMStack.getThreadStackTrace(Native Method)
	at java.lang.Thread.getStackTrace(Thread.java:1538)
	at io.reactivex.Flowable.observeOn(Flowable.java:9943)
	at io.reactivex.Flowable.observeOn(Flowable.java:9866)
	at me.saket.dank.ui.usermanagement.UserManagementActivity.setupUserList(UserManagementActivity.java:248)
	... 14 more
Caused by: com.tspoon.traceur.TraceurException: Debug Exception generated at call site
	at dalvik.system.VMStack.getThreadStackTrace(Native Method)
	at java.lang.Thread.getStackTrace(Thread.java:1538)
	at io.reactivex.Flowable.takeUntil(Flowable.java:13862)
	at me.saket.dank.ui.usermanagement.UserManagementActivity.setupUserList(UserManagementActivity.java:249)
	... 14 more

After uninstalling/installing the app db migration won't execute and I can't use onCreate() since it is only called once when db does not exists.

Closing because going stale. I'll create PR when it's done.


Elasticsearch issue

Hello.
I installed Cyphon on 2 separate machines via Cyphondock. However, the elasticsearch is not working on neither one of them.
I get HTTP 500-error when I try to add a collection.
Here's the main elasticsearch error: [36melasticsearch_1  | Caused by: java.nio.file.AccessDeniedException: /usr/share/elasticsearch/data/nodes
Here's the nginx main error:
[22/Nov/2017:04:59:03 +0000] "POST /admin/warehouses/collection/add/?_to_field=id&_popup=1 HTTP/1.1" 500 27 "http://localhost/admin/warehouses/collection/add/?_to_field=id&_popup=1" "Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0"
Is docker trying to work outside of it's container, or what is causing the issue?
I didn't have that folder mentioned. I created it, applied chmod but it still doesn't work. Nothing is being created under that folder. I'm running default settings
Java docs: "Checked exception thrown when a file system operation is denied, typically due to a file permission or other access check. "

Yes, the Elasticsearch container is trying to write to the data directory on the host. The directory needs to be writeable by the user with uid 1000 on the host (the same uid of the elasticsearch user in the container). Try:
sudo chown -R 1000:1000 /opt/cyphon/data/elasticsearch

See Elasticsearch's documentation on bind-mounted configuration for more details.

Thank you very much!! It solved my issue.
I did get a follow up error though. My elasticsearch warehouse was called "esDB", and error log said that it should be all lower cases. That prevented me from adding a new collection as well. I changed to lower casing and it's working well now.

Not sure if this is Elasticsearch related, but do you know why I can't add title to my alerts?
https://i.imgur.com/Db0z6YI.png

Glad it worked! Thanks for the note about the warehouse name. I will add a lowercase validator to the Warehouse model to fix that.

As for the question about Alert titles, these are added automatically based on the "title" field associated with the Taste used for the Distillery's Container (admin/containers/container). You won't be able to add alert titles through the admin field, because it's a readonly field. But if you configure the Taste and go back and resave the Alert, it should populate the Alert title.

Fixed validation of Warehouse names in https://github.com/dunbarcyber/cyphon/pull/306.


Revert "Revert "update packages""

Reverts flutter/flutter#61674
Many more tests become red after flutter/flutter#61674. Revert it to make the tree less red.

TBR: @CareF

There's #61678 already


How to get value from items that sorted?

[Not that real issue]
I don't know how to get value from items that sorted and I didn't see any methods to do that.
Example. I want to change color of sorted items when clicking sort button. How to get sort values when clicking it?

Can you give me some examples? I've just started to learn vuejs.
I give my example about what I want to do.
data are like this
data {
   list {
         name: 'abc',
         cat1: 1,
         cat2: 3,
         cat3: 5,
         cat4: 2
         }
    }
}

When I active sort function I sort this cat1, cat2, cat3, cat4.
Between that I want to get this the value of this category into the class itself. So I can change its color.
Kinda like this.
Click sort > get a category name > get its category value (ex. cat1 = 1), bring it to class.
<item :class="'item-color-' + CATVALUEISHERE"></item>

Any help would be much appreciated.

@plugza, I don´t understand fully your scenario, it looks like you want to apply class to your item but this is not related to isotope component. Could you give a more comprehensive scenario so I can try to help you.

The full scenario is...
I have a list of names that have various ranks by categories as you see above.
When I want to sort I want to separate the rank them by color.
1 = green
2 = yellow
3 = red
and so on...
From my understanding. I need to do something at the time I use sort method in vue.isotope.
So I have to get the value from the category, keep it in some variables
and use it as a class to change color by css class.
<item :class="item-color-' + VALUEISHERE"></item>

Example. I click "category1" button. it will sort every name in category1 by values.
aaa's category1 is 1 and bbb's category1 is 3
<item :class="item-color-1">{{aaa.name}}</item>
<item :class="item-color-3">{{bbb.name}}}</item>

*In fact i use v-for to list every names. I just write this to explain.
From above. it means aaa will get 'green' color and bbb will get red color.
And when I use sort methods to sort with another category. It should be change by the value of other category.
Things is I don't know how to get value from your sort methods.
I use this.$data but got undefined.
If I can get those values from inside sort method. I keep them in variables and use it in
Can help me on this?

Our problem is not linked to vue.isotope but to dynamic class in vue.
Did you try something like:

where sortedField will be the filed you use to filter the data.


add parameter from Env of Deployment

First step to get Env-Variables used for Kafka Scaler.
Added parameters:

bootstrapServers  -- bootstrapServersFronEnv
topic                     -- topicFromEnv
group                   -- groupFromEnv

Linked to issue:
https://github.com/kedacore/keda/issues/1190

@QuintinBecker could you please rebase your work? seems like that your commit contains changes from multiple old commits. Thanks!

I will try to add all the changes to the documentation, but it will take till next week, due to heavy load on my side.

@QuintinBecker thanks!

@QuintinBecker just checking on the documentation

@QuintinBecker hi, do you think you can add the documentation please?

Hi, does anyone knows whether this functionality actually works?
My deployment is as follows:
apiVersion: apps/v1
kind: Deployment
metadata:
  name: my-deployment
  namespace: my-ns
   .
   .
   .
spec:
    spec:
      containers:
        - name: my-container
          env:
            - name: KAFKA_BOOTSTRAP_SERVERS
              value: my-kafka-url:9094
          .
          .
          .

and I set my ScaledObject as follows:
triggers:
    - authenticationRef:
        name: my-auth-ref
      metadata:
        bootstrapServersFromEnv: KAFKA_BOOTSTRAP_SERVERS
        consumerGroup: my-consumer-group
        lagThreshold: '100'
        offsetResetPolicy: earliest
        version: 2.4.0
      type: kafka

but the environment variable value is not picked as expected.
I would appreciate any assistance on this. Thanks!

@QuintinBecker hi, do you think you can add the documentation please?

I've just submitted a PR documenting these parameters.


Don't show container labels on container images

Fixes #815
Images have their own labels. We can still use the container labels for
filtering, as the filters are "System Containers", not "System Images".

LGTM


materialize: 0.17.0 -> 0.84.0

Description of changes
This is still not building yet, but it's very close. I've got some troubles with the npm deps.
@petrosagg in case you have ideas, this is close to ready. (leaving this in draft in the meanwhile).
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@petrosagg I've added the missing cargo.lock file, and made the change, thank you for taking the time.
the rocksdb issue looks like it's more of a problem. The rust rocksdb crate is quite old and only takes care of older rockdb version. We have to wait for an update of that crate, to then make an update in nixpkgs of the rocksdb crate.
the rust rocksdb crate supports rocksdb 8.1 and currently nixkpkgs has rocksdb 8.3.2.
so we have to wait until everyone can update to 8.10.
I'll leave this in draft for now.
thanks again!

@happysalada the weird thing is that when developing materialize locally I don't have rocksdb in my system nor do I link it dynamically. So think something is causing cargo to not build librockdb-sys from source and instead to attempt to link it

@happysalada I spent some more time on this. Here is the diff that will build the required binaries correctly although I only tried with doCheck = false;. You might need to adjust a few tests if you set that to true
diff --git a/pkgs/servers/sql/materialize/default.nix b/pkgs/servers/sql/materialize/default.nix
index b9c22fec98ea..f4bba8365494 100644
--- a/pkgs/servers/sql/materialize/default.nix
+++ b/pkgs/servers/sql/materialize/default.nix
@@ -13,7 +13,6 @@
 , pkg-config
 , protobuf
 , libclang
-, rocksdb
 , rdkafka
 }:

@@ -25,16 +24,20 @@ let
       inherit hash;
     };

-    static = "./src/http/static";
-    cssVendor = "./src/http/static/css/vendor";
-    jsProdVendor = "./src/http/static/js/vendor";
-    jsDevVendor = "./src/http/static-dev/js/vendor";
-
     files = with args; [
-      { src = js_prod_file; dst = "${jsProdVendor}/${name}.js"; }
-      { src = js_dev_file;  dst = "${jsDevVendor}/${name}.js"; }
-    ] ++ lib.optional (args ? css_file) { src = css_file; dst = "${cssVendor}/${name}.css"; }
-      ++ lib.optional (args ? extra_file) { src = extra_file.src; dst = "${static}/${extra_file.dst}"; };
+      { src = js_prod_file; dst = "./src/environmentd/src/http/static/js/vendor/${name}.js"; }
+      { src = js_prod_file; dst = "./src/prof-http/src/http/static/js/vendor/${name}.js"; }
+      { src = js_dev_file;  dst = "./src/environmentd/src/http/static-dev/js/vendor/${name}.js"; }
+      { src = js_dev_file;  dst = "./src/prof-http/src/http/static-dev/js/vendor/${name}.js"; }
+    ]
+    ++ lib.optionals (args ? css_file) [
+      { src = css_file; dst = "./src/environmentd/src/http/static/css/vendor/${name}.css"; }
+      { src = css_file; dst = "./src/prof-http/src/http/static/css/vendor/${name}.css"; }
+    ]
+    ++ lib.optionals (args ? extra_file) [
+      { src = extra_file.src; dst = "./src/environmentd/src/http/static/${extra_file.dst}"; }
+      { src = extra_file.src; dst = "./src/prof-http/src/http/static/${extra_file.dst}"; }
+    ];
   in
     lib.concatStringsSep "\n" (lib.forEach files ({src, dst}: ''
       mkdir -p "${dirOf dst}"
@@ -69,8 +72,6 @@ rustPlatform.buildRustPackage rec {
   env.PROTOC = "${protobuf}/bin/protoc";
   env.PROTOC_INCLUDE = "${protobuf}/include";
   env.LIBCLANG_PATH = "${libclang.lib}/lib";
-  env.ROCKSDB_INCLUDE_DIR = "${rocksdb}/include";
-  env.ROCKSDB_LIB_DIR = "${rocksdb}/lib";
   # needed to dynamically link rdkafka
   env.CARGO_FEATURE_DYNAMIC_LINKING=1;

@@ -122,8 +123,7 @@ rustPlatform.buildRustPackage rec {
     "--skip test_tls"
   ];

-
-  cargoBuildFlags = [ "--bin mz" ];
+  cargoBuildFlags = [ "--bin environmentd --bin clusterd" ];

   postInstall = ''
     install --mode=444 -D ./misc/dist/materialized.service $out/etc/systemd/system/materialized.service

why only build environmentd and clusterd, are those the only two binaries needed to run materialized

Yeah, these two are the only ones.  It'd be useful to include a script/service that brings up everything but that can be a separate PR

@petrosagg I think I've got all the requested changes, let me know when you have time to have another look.

Result of nixpkgs-review pr 282699 run on x86_64-linux 1

1 package built:

materialize

I went ahead and merged, but if you have any other feedback later on, feel free to just post a comment and I'll go for it.

Looks great, thanks!


Upgrade > WS Connection with URL '/IPElms' is invalid: No 'OCPP16' or 'REST' in path

Hello Serge
I have a question about the connection between the server and the charging station. As a beginner I am not quite sure where to enter the data for a successful connection.
The server and dashboard are successfully built. The Ws connection with the charging station does not work.
I am sending you the screenshots of the error messages and the config.json in the attachment.
Many thanks already

config.json.txt

Hello!
It means that the charging station (CS) is not connecting with the full ws URL!
It's more a problem on the CS side.
You can check the logs of the CS.

Many thanks for the quick feedback
I will have a look at the logs and if necessary contact the manufacturer of the charging station.


Optimize the initialization method of GPTCache

Optimize the initialization method of GPTCache, so that users can use GPTCache more quickly.
@hwchase17 When you have free time, please give me a check for the pull request


'AVLayerVideoGravityResizeAspectFill' was obsoleted in Swift 4

I just updated to latest Cordova (8.0.0) and the latest cordova-plugin-qrscanner (2.6.0)
When I try to build the project I get the following error:
AVFoundation.AVCaptureTorchMode:3:18: note: 'AVCaptureTorchMode' was obsoleted in Swift 4
Does anyone else get the same error?

It sounds like your project is using Swift 4, while this plugin requires Swift 3. Are you using another plugin which requires Swift 4?

It is actually your plugin which installs swift 4
Installing "cordova-plugin-qrscanner" for android

Android Studio project detected

Subproject Path: CordovaLib
Subproject Path: app
Installing "cordova-plugin-qrscanner" for ios

Installing "cordova-plugin-add-swift-support" for ios

Adding cordova-plugin-qrscanner to package.json

Saved plugin info for "cordova-plugin-qrscanner" to config.xml

Update IOS build setting SWIFT_OBJC_BRIDGING_HEADER to: "$(PROJECT_DIR)/$(PROJECT_NAME)/Bridging-Header.h" for build configuration Debug
Update IOS build setting SWIFT_OBJC_BRIDGING_HEADER to: "$(PROJECT_DIR)/$(PROJECT_NAME)/Bridging-Header.h" for build configuration Release
Update IOS build setting ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES to: YES for build configuration Debug
Use Swift language version 4
Update IOS build setting SWIFT_OPTIMIZATION_LEVEL to: -Onone for build configuration Debug
Update IOS build setting ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES to: YES for build configuration Release
Use Swift language version 4

It is now working as expected. It started working after deleting the plugin and platform directory. I also had to remove the line which referred to using swift 4 in config.xml

QRScanner is causing error(swift support) on pgb. I have heard something like "bridging header". Can author please change your plugin code, so that it can work on pgb also. Desperately needed that. Please. Or guide me any workaround.

Has anyone find a workaround for this plugin? Swift 3 is no longer supported in XCode. I only can use Swift 4 or greater and that's causing a lot of errors from Swift Compiler.
For example, one of the errors stating:
/AVFoundation.AVLayerVideoGravityResizeAspectFill:3:12: 'AVLayerVideoGravityResizeAspectFill' was obsoleted in Swift 3


PR-41-improve-ci-standards-check

use central ci-standards-check template for https://www.notion.so/typeform/Github-Actions-Runners-revamp-d67c03f3dfb949d1a22a7abfe8c249d2
Created by Sourcegraph batch change engineering-intelligence/PR-41-improve-ci-standards-check.

[BOT] Preview available with hash ef3ddc1b531c18a94f5f1d79dd6850ae7d0c976c here.


kotlin can be supported？

The best new butterknife is support kotlin？

It already works fine. Just use kapt instead of annotationProcessor for the compiler dependency.


does not redirect me to the merchant transactions page

I have used composer require anandsiddharth/laravel-paytm-wallet package for Paytm payment gateway.
the problem i face is when I click on the payment now button. it does not redirect me to the merchant transactions page. it returns me the payment is failed.
I have updated app.php file in config. session.php and updated other required files.

what you change to solve it please help me.


Adding isFrugal() issue #31

Do the checklist before submitting the PR:

[x] Have you read the guidelines mentioned in CONTRIBUTING.md?
[x] Have you squashed your commits?

Q: What version of Node.js you've used in the project? (e.g. Node v10.11.0)
A:v11.6.0
Q: Mention the Issue Number! (e.g. Fixed #8)
A:Fixed #31

Give additional information regarding the PR below:

Done with it

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #82   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          47     47
  Lines         532    543   +11
=====================================
+ Hits          532    543   +11

Impacted Files
Coverage Δ

src/index.js
100% <100%> (ø)
:arrow_up:

src/isFrugal/index.js
100% <100%> (ø)

src/nCr/index.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279f1d4...adeda60. Read the comment docs.

So camel case is compulsory?

So camel case is compulsory?

Uh yeah, didn't notice earlier :\


Italics in Table 20

How can we make certain cells in italics?

I saw one of the captions mentioned italics, so maybe it's already done in a table? Unless it's the caption for the table you're working on ;)  xtable() is a bit trick to format certain cells, but I think Chris has done it somewhere. Chris or I can take a look tomorrow - let us know which cells in which table.
If you add \emph{..} anywhere you may need to make it \emph{..}

Yes it's easy, you need double backslashes before the emph in the tables-xxx.r code. I can do it if you let me know which ones.


Non-interactive prebuild adding and updating

Is your feature request related to a problem? Please describe.
prebuild add/update commands are only runnable interactively.
Describe the solution you'd like
They both should have flags that can be set to run the entire command non-interactively.

@Tpuljak I would like to work on this issue. By creating the flags
@quest-bot embark

@Abiji-2020 go for it!


Review prior UX feedback

We had prior UX feedback from a JHU UX expert. Much of the feedback was already implemented, but there is some that likely needs addressing / ticketing.

https://docs.google.com/document/d/1ce9lulWajkzcB60UJULXhd72iN0bS_5PAS-tIeplfbk/edit?usp=sharing

Just to clarify, is the goal of this ticket ("Done") to create specific tickets/tasks for UX changes we plan to make moving forward?

I organized the feedback into a spreadsheet to track things a little better: https://docs.google.com/spreadsheets/d/1ho71ZCOBLtpjrVg7e7pUbuRTU5DETxBMXj_yzdnPae8/edit?usp=sharing
This way we can move things from To Do to Won't Do, and there is visibility on what was already completed, etc. We should discuss as a team what we want to add as tickets for post 1.0.0 and what we should mark as Won't Do. Also this feedback might be helpful to the PASS Working Group as reference since they will be writing copy/FAQs about the PASS site/workflow.

I think all the items that had links to issues were already done. I think we still need to assess if there is anything that needs to be done. There were some paragraphs with no tickets linked or that were marked explicitly as needs to be done with no closed ticket linked to.

Yep, my spreadsheet shows the things we did (all tickets linked were closed, as you mentioned). Just need to review the other items and determine next steps for those.


Azure Communication Chat Readme Issue

Section Link

Reason:
Wrong package name.
Suggestion:
Update to:
@azure/communication-chat
@jongio for notification.

Thanks for reporting @JosueJoshua
Please feel free to send a PR to fix this

Hi @ramya-rao-a . PR(12930) is ready now.


Missing required parameter: refresh_token

I am using "nao-pon/flysystem-google-drive": "~1.0" but i am getting the following error:
'''
Error refreshing the OAuth2 token, message: '{
"error" : "invalid_request",
"error_description" : "Missing required parameter: refresh_token"
}'
'''
Refresh token is there of course set in config and also passed to the GoogleDriverServiceProvider. Any ideas?

@nikosv There was no problem with the following test code. If there is a problem, I guess it is the side of google/apiclient.
<?php

require 'vendor/autoload.php';

$client = new \Google_Client();
$client->setClientId('xxxxx.apps.googleusercontent.com');
$client->setClientSecret('xxxxx');
$client->refreshToken('xxxxx');

$service = new \Google_Service_Drive($client);

$adapter = new \Hypweb\Flysystem\GoogleDrive\GoogleDriveAdapter($service, 'root');

$filesystem = new \League\Flysystem\Filesystem($adapter);

$contents = $filesystem->listContents();

var_dump($contents);

composer show
firebase/php-jwt                v4.0.0  A simple library to encode and deco...
google/apiclient                v2.1.3  Client library for Google APIs
google/apiclient-services       v0.11   Client library for Google APIs
google/auth                     v0.11.1 Google Auth Library for PHP
guzzlehttp/guzzle               6.2.3   Guzzle is a PHP HTTP client library
guzzlehttp/promises             v1.3.1  Guzzle promises library
guzzlehttp/psr7                 1.4.2   PSR-7 message implementation that a...
league/flysystem                1.0.37  Filesystem abstraction: Many filesy...
league/flysystem-cached-adapter 1.0.6   An adapter decorator to enable meta...
monolog/monolog                 1.22.1  Sends your logs to files, sockets, ...
nao-pon/flysystem-cached-extra  1.0.2   Extra traits for Flysystem cached a...
nao-pon/flysystem-google-drive  1.1.3   Flysystem adapter for Google Drive
phpseclib/phpseclib             2.0.4   PHP Secure Communications Library -...
psr/cache                       1.0.1   Common interface for caching libraries
psr/http-message                1.0.1   Common interface for HTTP messages
psr/log                         1.0.2   Common interface for logging libraries


Big Sur menu icon does not change to black

On Big Sur, when setting the dark theme, the icons should also change to black in the menu bar. Otherwise the white is almost not visible.
Ferdi does not yet change.

This is what needs to change : https://stackoverflow.com/questions/41664208/electron-tray-icon-change-depending-on-dark-theme

This is what needs to change : https://stackoverflow.com/questions/41664208/electron-tray-icon-change-depending-on-dark-theme

Still relevant. On Big Sur icon stay white.

And on Monterey.

Related https://github.com/electron/electron/issues/25478#issuecomment-966595183


Crash when using Nx 13.9.0 and above

This commit introduced some breaking changes: https://github.com/nrwl/nx/commit/48a5d19b68b8478861dff462eea04bdb6b27f674
Error:
Cannot find module '@nrwl/tao/src/shared/params'
'@nrwl/tao/src/shared/params' needs to be replaced with: 'nx/src/shared/params'
I see the Nx versions are currently pinned.

This has been fixed in 2.21.1, thanks for the bug report.


Filters with wildcards do not work for image names

According to many docs, blog posts and personal experience, aws allows you to use limited regexes/wildcards in filter queries.  Specifically, http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Filtering.html#Filtering_Resources_CLI says that you can use * to match 0 or more characters, and ? to match exactly one character.  moto doesn't seem to correctly replicate that behavior.
I have only tested this for EC2 image names, but I dug into the code a little to try to fix this, and it seems like moto may have the correct behavior for ec2 instance tags, but not filters for other attributes.
Here is an example test:
import boto3
from moto import mock_ec2

with mock_ec2():
    ec2 = boto3.resource('ec2')
    instance = ec2.create_instances(ImageId='ami-1234abcd', MinCount=1, MaxCount=1)[0]
    image = instance.create_image(Name='test-image')
    filter_result = list(ec2.images.filter(Owners=['111122223333'], Filters=[{'Name':'name', 'Values':['test*']}]))
    assert filter_result == [image]

I have done similar tests with boto3 which I think would pass the assertion.  I have not attempted to test this using the standalone moto server.
I installed moto using pip, and here are my versions of moto and boto:
boto (2.46.1)
boto3 (1.4.4)
botocore (1.5.31)
moto (0.4.31)

Thanks for opening!
This should be fixed now, but let me know if you still see any issues against master.


Ensure Http2StreamFrameToHttpObjectCodec#decode doesn't add transfer-encoding for 204/304 response

Motivation:
There are servers that return  204/304 response as HEADERS and DATA, where the DATA has no content.
INBOUND HEADERS: streamId=3 headers=DefaultHttp2Headers[:status: 204, date: Wed, 25 Jan 2023 07:46:07 GMT] padding=0 endStream=false
and
INBOUND DATA: streamId=3 padding=0 endStream=true length=0 bytes=
For such responses Http2StreamFrameToHttpObjectCodec#decode should not add transfer-encoding: chunked.
Modification:

Ensure Http2StreamFrameToHttpObjectCodec#decode doesn't add transfer-encoding: chunked for 204/304 response
junit test is added

Result:
204/304 response is correctly decoded.

linux-x86_64-java11 build failed on codec-http module, so I don't think it is related to this change
windows-x86_64-java11-boringssl I think this is related to the current problems with GH Actions https://www.githubstatus.com

@chrisvest @franz1981 PTAL

@violetagg thanks!


[Windows] Add checksum verification for Kotlin

Description
Update installer script with checksum for Kotlin
Related issue:
https://github.com/github/c2c-actions-akvelon/issues/38
Check list

[x] Related issue / work item is attached
[ ] Tests are written (if applicable)
[ ] Documentation is updated (if applicable)
[ ] Changes are tested and related VM images are successfully generated

/azp run windows2019,windows2022

/azp run windows2019,windows2022


Project clone operation

Coverage: 93.927% (+0.006%) from 93.92% when pulling 835d32a0330d7dac61d2a23753d8392a29d593e8 on cody-project-clone into 446fa39ad9bbe8abd9ad57df76d11702bae2a90b on main.


Specify specific newline placement [question]

Is there a way to specify options such as always have a newline above and below function declarations and scoped statements with jsbeautify, are remove all other newlines? Comments should be counted as part of the function declaration or scoped statement.

This question might be better asked in the JSBeautify project: https://github.com/beautify-web/js-beautify


tensorrtllm backend fails when kv cache is disabled

System Info
x86_64, L4 GPU, debian 11 OS
Who can help?
No response
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
To Reproduce

build trtllm engine with trtllm-build --kv_cache_type=disabled
load the model in triton with batching_strategy:inflight_fused_batching, and enable verbose logging
run inference with parallel sessions

Expected behavior
triton should work well when kv cache is disabled
actual behavior
There is error
model_instance_state.cc:1117] "Failed updating TRT LLM statistics: Internal - Failed to find Max KV cache blocks in metrics."

and the batch size of trtllm is always 1
additional notes
N/A

Hi, I tried to reproduce the issue you mention above but I'm hitting a different error:
 what():  [TensorRT-LLM][ERROR] Assertion failed: KV-cache-less is only supported for context (/app/tensorrt_llm/cpp/tensorrt_llm/plugins/gptAttentionPlugin/gptAttentionPlugin.cpp:1019)

Can you share the exact build command and model you're using? Also are you running on main? Thanks.

Hi, I tried to reproduce the issue you mention above but I'm hitting a different error:
 what():  [TensorRT-LLM][ERROR] Assertion failed: KV-cache-less is only supported for context (/app/tensorrt_llm/cpp/tensorrt_llm/plugins/gptAttentionPlugin/gptAttentionPlugin.cpp:1019)

Can you share the exact build command and model you're using? Also are you running on main? Thanks.

Hi @pcastonguay, as I said above, when max output token is 1, there is warning Failed to find Max KV cache blocks in metrics.. When max output token is greater than 1, it failed with your assertion.
Can we fix both?

I cannot reproduce the warning you're seeing. Based on the line number model_instance_state.cc:1117 in your log, you must be using an older version of the backend? Could you try running with latest backend from main?

I cannot reproduce the warning you're seeing. Based on the line number model_instance_state.cc:1117 in your log, you must be using an older version of the backend? Could you try running with latest backend from main?

Yeah I was using 24.09. I can try 24.10.
But meanwhile, can we also fix the failure you see KV-cache-less is only supported for context? This one is actually more critical

I can still see
E1125 21:54:31.419785 136 model_instance_state.cc:1140] "Failed updating TRT LLM statistics: Internal - Failed to find Max KV cache blocks in metrics."

with trtllm 0.14.0 and triton 24.10.
The full reproduce is
pip3 install tensorrt_llm==0.14.0 --extra-index-url https://pypi.nvidia.com
git clone -b v0.14.0 https://github.com/NVIDIA/TensorRT-LLM.git
git clone -b r24.10 https://github.com/triton-inference-server/tensorrtllm_backend.git

python3 TensorRT-LLM/examples/llama/convert_checkpoint.py --model_dir ./llama-3.1-8b --output_dir ./tllm_checkpoint_1gpu_bf16 --dtype bfloat16

trtllm-build --checkpoint_dir ./tllm_checkpoint_1gpu_bf16 --output_dir ./tmp/llama/8B/trt_engines/bf16/1-gpu  --gpt_attention_plugin auto  --gemm_plugin auto  --max_num_tokens 16384 --max_batch_size 8 --logits_dtype=float32 --gather_generation_logits --kv_cache_type=disabled

cp ./tmp/llama/8B/trt_engines/int4_awq/1-gpu/* tensorrtllm_backend/all_models/inflight_batcher_llm/tensorrt_llm/1/

HF_LLAMA_MODEL=./llama-3.1-8b
ENGINE_PATH=tensorrtllm_backend/all_models/inflight_batcher_llm/tensorrt_llm/1
BATCH_SIZE=8

cd tensorrtllm_backend
git restore all_models/inflight_batcher_llm
python3 tools/fill_template.py -i all_models/inflight_batcher_llm/preprocessing/config.pbtxt tokenizer_dir:${HF_LLAMA_MODEL},triton_max_batch_size:${BATCH_SIZE},preprocessing_instance_count:1
python3 tools/fill_template.py -i all_models/inflight_batcher_llm/postprocessing/config.pbtxt tokenizer_dir:${HF_LLAMA_MODEL},triton_max_batch_size:${BATCH_SIZE},postprocessing_instance_count:1
python3 tools/fill_template.py -i all_models/inflight_batcher_llm/tensorrt_llm_bls/config.pbtxt triton_max_batch_size:${BATCH_SIZE},decoupled_mode:False,bls_instance_count:1,accumulate_tokens:False
python3 tools/fill_template.py -i all_models/inflight_batcher_llm/ensemble/config.pbtxt triton_max_batch_size:${BATCH_SIZE}
python3 tools/fill_template.py -i all_models/inflight_batcher_llm/tensorrt_llm/config.pbtxt triton_backend:tensorrtllm,triton_max_batch_size:${BATCH_SIZE},decoupled_mode:False,max_beam_width:1,engine_dir:${ENGINE_PATH},max_tokens_in_paged_kv_cache:16384,exclude_input_in_output:True,enable_kv_cache_reuse:False,batching_strategy:inflight_fused_batching,max_queue_delay_microseconds:0,lora_cache_host_memory_bytes:0

cd ..
docker run -it --rm --gpus all --network host --shm-size=1g \
-v $(pwd):/workspace \
--workdir /workspace \
nvcr.io/nvidia/tritonserver:24.10-trtllm-python-py3

# in the docker
python3 tensorrtllm_backend/scripts/launch_triton_server.py --model_repo tensorrtllm_backend/all_models/inflight_batcher_llm --world_size 1

# in a separate terminal
curl -X POST localhost:8000/v2/models/ensemble/generate -d \
'{
"text_input": "How do I count to nine in French?",
"parameters": {
"max_tokens": 1,
"bad_words":[""],
"stop_words":[""]
}
}'

Then check the logs on triton server


Throwing TypeError avoid dependency (*runtime)

about throw TypeError, dependencies on (*runtime) should be avoided.
So I made the following changes to increase code robustness.
add func:
func makeTypeError(args ...interface{}) typeError
replace:
panic(.*NewTypeError(
to:
panic(makeTypeError(
remove: func needNew
add: const  needNew
replace:
panic(r.needNew(
to:
panic(makeTypeError(needNew,
After modifying the code, all TypeErrors will be thrown by panic(typeError).
Finally, the correct (*runtime).NewTypeError is called in "case typeError"

Sorry, I didn't mean to replace it everywhere, only in dynamicObjects. The other places should stay as they are.

ok.


bigtable/bttest: column family does not be checked in ReadModifyWrite

hi,
in mutaterow, bttest will check the existance of a column family.
https://github.com/GoogleCloudPlatform/gcloud-golang/blob/master/bigtable/bttest/inmem.go#L468
_, famOK := tbl.families[set.FamilyName]
tbl.mu.RUnlock()
if !famOK {
    return fmt.Errorf("unknown family %q", set.FamilyName)
}

however, we haven't saw such check in ReadModifyWrite
https://github.com/GoogleCloudPlatform/gcloud-golang/blob/master/bigtable/bttest/inmem.go#L601
if f == nil {
	f = &btdpb.Family{Name: fam}
	res.Families = append(res.Families, f)
}

which means we allow ReadModifyWrite to operate on a non-existing column family.
Is it an expected behavior?

It's just an oversight.

thanks


[Bug]: Not clear what qr is for.

Issue description
On the address page it is not clear what the QR is for as it does not have an associated header.
Expected behaviour
Has a header describing what it is or a call to action describing user to scan it for a particular reason.
Actual behaviour
Floating QR code
Can the issue reliably be reproduced?
Yes
Steps to reproduce the issue
No response
Errors
No response
Duplicate declaration

[X] I have searched the issues tracker for this issue and there is none

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Should be discussed this with UI / UX team.

Update: We should probably have a label for the QR.


split log decorator into components

If we had log.start, log.stop, and log.noop, we would be able to finely tune what occurs for logging and when.  We could still have a log decorator but it would combine start and stop.  I'm thinking we should also provide non-decorator versions but that's just an idea.

After using this a bit more, I'm thinking we should implement the following:

log.arguments
log.return
log.noop


refactor create_qiime_mapping_file

From @josenavas in https://github.com/biocore/qiita/pull/678:
It is a bit weird that we are relying on the filepaths to create the qiime mapping file (so we can parse them into pandas). I remember correctly, there is a function that @ElDeveloper wrote to transform a MetadataTemplate into a pandas DataFrame. I think the way to go is to make a function on the MetadataTemplate object called to_dataframe that returns a DataFrame with the template information.
@antgonza note: this will duplicate some code (as this will be similar to what we are doing now but retrieve the info from DB and generate the pandas dataframe) and then load in memory but is another option.

I think this can be closed as everything here is implemented. Please reopen and add details if that's not the case.


啥时候更新代码阿！

The experimental codes are already ready but are not so well organized currently. We plan to upload our code after the paper is accepted. However, if you need to compare with our result we can send a copy of our experimental codes to you.

Thank u !! @Dootmaan

Dear Authors:
l am honored to read your paper "MIXED TRANSFORMER U-NET FOR MEDICAL IMAGE SEGMENTATION". This paper has inspired my research and guided my next plan,but I found that you did not provide The complete code , so I sincerely hope that you can provide the complete code. I will be very grateful.

The experimental codes are already ready but are not so well organized currently. We plan to upload our code upon paper publication. However, if you need to compare with our result right now, we can send a copy of our experimental codes to you.

Hello, I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS> .Thank you!

Dear Authors:：
I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>.Thank you!

Dear Authors:：
I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>.Thank you!

Dear Authors:：
I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>.Thank you!

Dear Authors:：
I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>.Thank you!

Dear Authors:
I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>.Thank you!

Dear Authors:
I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>.Thank u!

@Dootmaan

Dear Authors:
I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>.Thank u!

Dear Authors:：
I also need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>you!

Dear Authors:：
I need your code to compare the experimental results. My email address is<EMAIL_ADDRESS>Thank you very much!

Dear authors:
I want to further work on your paper.
can you please share the full code.
email<EMAIL_ADDRESS>Thank you.

Sorry i never noticed that so many people requested the full code in this single issue😂
The complete code is release today so you can fetch the code by yourself now! thank you for your interest in our work.

This issue is closed since no further activity has happened for a while.


Jump to panel keybinding

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
Use the bound keys to select the specified panel, just like lazygit.
Describe alternatives you've considered
No.
Additional context
No.

same issue: https://github.com/jesseduffield/lazydocker/issues/522


User friendly URLs for ideas

This adds the FriendlyId gem and changes idea page URLs to use it. An example
URL looks as follows now:
http://localhost:3000/ideat/esimerkki-idea-19
Signed-off-by: Pekka Enberg<EMAIL_ADDRESS>

Btw, if there's existing data, you need to do this:
If you're adding FriendlyId to an existing app and need
to generate slugs for existing users, do this from the
console, runner, or add a Rake task:
User.find_each(&:save)
[ From: https://github.com/norman/friendly_id ]


Looking for a maintainer

Hey guys,
I've tried to keep RNWS up-to-date and not broken in the past weeks, but unfortunately I can't dedicate much time to it these days since I'm no longer actively using the project. There's quite a bit of work to be done to get RNWS up to parity with the RN packager (and to get hot reloading to work with the recent RN versions); if you'd like to help out with these things, I'm happy to accept pull requests, and I'm sure @mjohnston would be happy to grant push access.
cc @amccloud
With that said, use this project at your own risk :wink:

Now that RN supports Babel, it seems like the only differentiating feature of RNWS is hot reloading. Therefore it's probably easier to work on adding hot reloading to RN than playing catch up with RN after every release.

True, HMR is probably the biggest reason to use RNWS. The other big thing that RNWS provides is access to webpack's loader & plugin ecosystem (e.g. for CoffeeScript support), but I'm not sure how valuable that is to most people.

Is there already some work being done to add Hot Reloading to RN?

The reason why I still use RNWS is the ability to have browserify polyfill node modules. I need to run a fair bit of code inside React Native that's shared with other clients running node, not to mention using a bunch of upstream node libraries that Just Work(tm) thanks to browserify.
Also, while the React Native packer now uses babel, it's not actually possible to supply your own .babelrc. Its baked into the transformer, which btw executes way before the dependency resolver. So it's hard to polyfill certain modules without actually physically putting them in your node_modules tree. And not being able to customize .babelrc means you're at the mercy of React Native in terms of what transforms and ES2015 features you can use in your code.

Also, while the React Native packer now uses babel, it's not actually possible to supply your own .babelrc. Its baked into the transformer, which btw executes way before the dependency resolver.

This.
I use a custom babel transform whitelist, and I actually do use RNWS for the Webpack loaders and plugins (eslint, and especially DefinePlugin is really nice for building development/staging/production versions of the app). The file loader is also really useful for adding static assets to the project, combined with venmo/synx.
I don't even use it for HMR.

Given that Dan and Sebastian are both working on FB infrastructure now, I'll second Dan's recommendation of adding these features to RN rather than play catch-up here.

Given that I will depend on rnws for the foreseeable future, I'd be happy to take up a role as (co-)maintainer. My needs only cover a subset of features (for instance, I don't care much about hotloading -- yet?). Also I believe in critical code review. So I think it'd be good if there was at least one other peer who's actively using the code in their project and can review changes. Any takers?

Seeing as I don't use this project anymore myself I'm happy to transfer or grant push access to others who rely on it and are willing to maintain it.
That being said, I believe the best outcome would be for RN to support the features that compel people to use RNWS - namely alternate bundlers and/or hot reloading.

That being said, I believe the best outcome would be for RN to support the features that compel people to use RNWS - namely alternate bundlers and/or hot reloading.

I agree wholeheartedly, as I'm sure would @amasad et.al. I think the best outcome for RNWS's future would be to push as much of the "React Native external" parts into React Native itself, so that ultimately using webpack as a packager just boils down to writing a webpack.config.js. I'd be happy to drive that effort, but it depends a bit on what the folks at FB have in mind for the packager in the near to mid-term.

Actually @sebmarkbage and I were just chatting about this the other day -- I think that ultimately Facebook's requirements will always be different. So RN should just provide the basic API and environment through globals (just like the browser does) and get out of the way. Users should be able to choose their own module systems and bundlers (or not use bundlers if they want).

I like that plan a lot. Is Facebook's ecosystem (and thus React/React Native) in the long run going to adopt the node module system, or is Haste sticking around? Currently that seems to be the biggest source of awkwardness for bundling React Native code.

I should clarify, it's not really a plan, that's just my opinion. I'm not currently as involved as I'm working on a different project. cc @martinbigio who is currently working on the RN packager.

Is Facebook's ecosystem (and thus React/React Native) in the long run going to adopt the node module system, or is Haste sticking around? Currently that seems to be the biggest source of awkwardness for bundling React Native code.

Haste is sticking around internally, people find tremendous value in using it. However, this is partly why I think FB's requirements will always be different. One of the things I tried really hard to do with the React Native packager is to shelter the community from Haste since node modules work really well in open source. But, you'll still run into it if you're doing any infra work for RN.

I think webpack has some really nice features that are useful for apps. For example, resolve.alias, resolve.modulesDirectories and a few others. Since most React web apps are built using webpack, would it not be a good idea for RN to switch to webpack in the first place?

I too was using RNWS solely for the utility webpack brings.

@braco glad there's someone who sees value in this

@radubrehar I've been trying to figure out how to use browserify polyfill node modules with React Native and have landed on this project. You might find this thread useful as it discusses some reasons RN isn't using Webpack in addition to @amasad's comment that

Users should be able to choose their own module systems and bundlers (or not use bundlers if they want).

So far this project is looking like the best option for integrating Loopback isomorphic javascript into a RN app. The Loopback code is presently intended to be compiled with Browserify.

@jeffcressman thanks for the clarifications and context. I totally agree everyone should be able to use their own module system & bundler. I'm using webpack extensively for React for more than 1.5 years now but am new to React Native, so sorry if the following question is too basic: is there a proved way to bundle files with webpack and then feed the output bundle into the RN bundler?

ye, i am using rnws;
because i just want to depart the lib code and app logic code;

Personally the only real reason I need react-native-webpack-server is resolve.alias
@radubrehar and others looking for resolve.alias support in react native packager, I created a product pains (which is how react native wants to track issues now?) if you want to +1 that
https://productpains.com/post/react-native/packager-support-resolvealias-ala-webpack/

ProductPains seems like a lot of work for very little, can't even browse existing issues, so it seems useless compared to GitHub issues.
ayway, having a settings file like webpack.config.js or .babelrc would be suitable, but even better in my opinion would me to just accept the basics in the packager and let us worry about the rest.
I'm going to have webpack output (ES5) to the file RN bundler reads. should work good enough.

@ThaJay Yes, IIRC, the reason we can't feed webpack's output into the RN bundler is that webpack doesn't understand Facebook's haste module system (https://github.com/facebook/react-native/issues/5#issuecomment-72341589). Work is being done towards allowing any CommonJS bundler to be used in place of the RN bundler (https://github.com/facebook/react-native/commit/8d397b4cbc05ad801cfafb421cee39bcfe89711d), though I'm not sure about the current progress of this.

for anyone still looking to use webpack, this externals function looks up react-native modules so webpack won't get in the way of RN-Packager.
https://gist.github.com/alexesDev/071f8935c82ca87a5b46

I'm pretty sure it's impossible to avoid "../" hell in react-native without applying a horrible hack, or am I completely wrong here? https://github.com/facebook/react-native/issues/637

uninstall Watchman + don't use Windows.
I should be okay now on ubuntu using node filewatcher with symlinks.
RNPackager really needs proper aliasing...

@gaearon Any love from facebook on resolve alias of more than 1 level deep?

Unfortunately I don’t understand the problem well enough and don’t work on the packager either.

Can I beg for a poke to that team for your previous love of this project :)
We would get bluetooth (via the noble api) in react native as a result :)
On Sun, May 1, 2016 at 7:02 PM, Dan Abramov<EMAIL_ADDRESS>wrote:

Unfortunately I don’t understand the problem well enough and don’t work on
the packager either.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/mjohnston/react-native-webpack-server/issues/143#issuecomment-216080033

Can you help me understand the problem better?

@gearon Absolutely Hopefully @elliottsj and @philikon can explain what they
need to keep react-native-webpack-server in the ecosystem.
For the rest of us stuck in the middle of the two, webpack has a key
feature missing/half implemented in the react native packager. Rather than
further squatting this thread I posted a follow up on my existing product
pains:
https://productpains.com/post/react-native/packager-support-resolvealias-ala-webpack/
Thanks for listening.
On Sun, May 1, 2016 at 8:20 PM, Dan Abramov<EMAIL_ADDRESS>wrote:

Can you help me understand the problem better?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/mjohnston/react-native-webpack-server/issues/143#issuecomment-216083729

@gaearon we need webpack mostly because the RN packager

does not support symlinks
doesn't do browserify or module aliases, as described by @jacobrosenthal
its dependency resolution does not scale well for large node_modules trees

We can help get to what we want by supporting the move to migrate Haste into libs (that are distributed with react-native) and getting the packager extracted from react-native itself.
https://github.com/facebook/react-native/issues/7636
https://github.com/facebook/react-native/issues/7668
The pain in the project is largely the result of Haste and the fact we are forced into the packager as the result of this. If the packager were on its own, we'd be getting to the place that we could use whatever packaging and bundling solution we want.
Please add your voices or work to the above issues since this is what will bring an end to the kludge and finally we can build, bundle and package in direct way with the tooling we want to use.

Hello,
in a pure React project I can do "conditional" compiling for different apps with the same code base, by using webpack as such:

I want to do the same with React-Native apps, i.e. create 3 different apps based on a single common code base. At least for the part of the JavaScript bundle (if for the native wrapper is difficult to do such).
How would I do this if I do not have access to webpack?
Thanks!

@af7 I have been working on that question a few months ago. Due to the lack of aliasing and symlink support in packager, but the general lack of actually working with react-native in webpack we decided on the following solution:
All common code goes in a core repo. Then we make a repo for eacht platform with the following structure:
app-name-platform-name
| core
| node_modules
| src
| | envSettings.js symlink (they get followed but not watched, fine for things that hardly ever change)
| static
then in index.android.js:
import React, {AppRegistry} from 'react-native'
import {AppWrapper} from './src/index.js'

AppRegistry.registerComponent('appname' () => AppWrapper)

it's not the nicest solution because there's a copy of core in each repo, but at least it works without a thousand quirks.

Hey folks. After a lot of struggling, I have moved off of react-native-webpack-server. Like a lot of folks here, the only reason I was using it was to use code written for node.js inside my React Native app. In other words, webpack's ability to browserify my code, resolve module aliases, etc. Rather than maintaining react-native-webpack-server, which has always been behind on things like hot reload, debugging, etc., I've worked on a way to get the features I needed using the regular React Native packager.
Please check out https://github.com/philikon/ReactNativify. Would love feedback from folks, ideally in the form of PRs.
Also, in case it's not clear yet, I no longer plan on maintaining react-native-webpack-server.


FIX-#4439: Fix flake8 CI fail

Signed-off-by: alexander3774<EMAIL_ADDRESS>
What do these changes do?
In the new release of the flake8-print plugin error code T001 was changed to T201. We need to reflect this change in the Modin CI to avoid CI fail.

[x] commit message follows format outlined here
[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #4439
[x] tests passing
[x] module layout described at docs/development/architecture.rst is up-to-date
[x] added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

Hi Modin team, this PR is ready for review!


output format / tooling integrations

Some tools depend on "standard" diff format. Is that format adaptable?
Has anyone successfully integrated difft as an external diff tool in Intellij for example?

non-goals from readme clarified my question


Setting minDate does not set the year minimum

I tried:
 		$validFrom.datetimepicker({
			lang:'de',
			format:'d.m.Y H:i',
			minDate: new Date()
		});

This works for min date but it does not restrict the year selector to begin before the min date's year.
See:

You should redefine yearStart https://github.com/xdan/datetimepicker/blob/master/jquery.datetimepicker.js#L511
option

Works thanks. Is there also I way to set the blue marker at a certain date?


[RFC] Configuration Management

Moved open PR from private repository.

I'll take a look at the CLA check failure. Looks like its a private/public transition thing.

Noting that some public comments were already made in #14.


MathJax CDN has closed down.

I noticed an js console warning when navigating the cookbook:
WARNING: cdn.mathjax.org has been retired. Check https://www.mathjax.org/cdn-shutting-down/ for migration tips.
So heres a PR with the location updated as per their guidance.

Hi @rozza  thanks! But the issue was solved upstream in mdbook some time ago. I don't know when the next mdbook release will happen but I venture it's within next two months @azerupi.
If you would be willing, you could with seting of local fallback for mathjax in mdbook

@rozza I'm sorry you've lost time on this. Please give me heads up if you see any other problems!

@budziq no problems, glad its getting sorted, I'll look for an easy ticket to work on :) 👍


Alpha: await algoliaClient.search doesnt accept generic anymore

Hi,
I'm using the 5.0.0-alpha.81 version, and I used to have something like this in order to type the results:
const { results } = await algoliaClient.search<MyCustomDocumentType>({ ... })

However, ever since the alpha.82 I believe, it's not accepting any generics anymore. Any reason for this? Maybe there is a new & much better way to do it :)
Thanks!

Hey @loick, thanks for testing the Alpha client :D

However, ever since the alpha.82 I believe, it's not accepting any generics anymore. Any reason for this? Maybe there is a new & much better way to do it :)

Looking at our releases, this was changed in https://github.com/algolia/api-clients-automation/pull/1774 which was released in a .7x or something I believe.
TLDR this is due to the API endpoint allowing to search for either hits or facets, meaning the generic becomes a bit cumbersome to deal with in term of implementation, since it can be mixed.
We will work on providing helpers method named searchForHits and searchForFacets which will allow generic and ease the typing :)

Okay, thanks for the quick answer! 🙏 Do you know when it will move to the beta stage also btw?

Hey @loick, we will provide some helpers in the next release https://github.com/algolia/api-clients-automation/pull/2138

Okay, thanks for the quick answer! 🙏 Do you know when it will move to the beta stage also btw?

If everything goes well we will go stable next quarter!

Thanks a lot!

@shortcuts
Is it possible to release the alpha90 that seem to exist in tags but not in the npm package. Thanks!

hey, the tag takes the highest version of all of the packages, you should find the new helpers method latest algoliasearch version (alpha.89)


Switch over ElasticSearch q usage to filters, update mappings

Previously, we were making heavy use of ElasticSearch queries (via q=) in our templates, but in 100% of these cases, we should have been using filters.  Queries, which are much slower, should generally only be used for text search.
Now that sheer allows you to use the same URL filter syntax within search_with_url_arguments() (https://github.com/cfpb/sheer/commit/9d1ad908d2bfcb1f62f8fef1438bf21f52972810), I've converted the existing instances of queries over to filters.
In order to use these types of filters, the field in question must be indexed as not_analyzed in ElasticSearch, so I had to declare that in a couple mapping files.
I've also updated documentation to reflect the change.

Cool. My comment wasn't related to the PR itself, just curious how we can find the filters we can use. I'll be sure to give elasticsearch head a try.

@dpford if you're ready, go ahead and merge this. I think on Monday we're going to try and sort out the branches and after that PRs will need to be made against flapjack instead of gh-pages.

Merged into the flapjack branch and will go into refresh with this week's Sprint.


Removing multiple entities does not invalidate Identity Map

I have a weird problem, I do not know if I am handling this the correct way.
I have a method: existsComment, with the following code:
public function existsComment(int $id): bool
{
    return $this->repository->find($id) instanceof Comment;
}

I have a record in my MySQL database with id=1. When I call existsComment(1) it returns true. So far everything is ok.
Next I delete the same entity with a custom method in my repository, see the code below:
public function deleteMultipleById(array $ids): void
{
    $builder = $this->createQueryBuilder('c');
    $builder->delete()
                    ->where('c.id IN(:ids)')
                    ->setParameter(
                        ':ids',
                        $ids,
                        Connection::PARAM_INT_ARRAY
                    );

    $query = $builder->getQuery();
    $query->execute();
}

The reason why I want to delete multiple comments at once is only for performance reason. In some case there can be 10000 comments that are spam, and we want to enable the user to delete them at once. If I use the ->remove() method on each Entity, it will result in 10000 queries. A single DELETE query will be more performant.
But if I call the existsComment again, it results in true.
If I look in the database the comments are all removed, so it probably exists only in the Doctrine cache.
If I inspect the UnitOfWork, and check the state of a removed Entity it is 1 (STATE_MANAGED), where I expect 4 (STATE_REMOVED).
So, my question is: what am I doing wrong? Is this intended behaviour? And if it is intended, what is the best way around this?

Title is miss-leading.  Identity map (which is part of unit of work) is not a cache, it is current state of unit of work. If you load something into UoW, then make something with it bypassing it, state will not be changed.

If I inspect the UnitOfWork, and check the state of a removed Entity it is 1 (STATE_MANAGED), where I expect 4 (STATE_REMOVED).

Since you are deleting your entities bypassing UoW, it has no information about it. So yes, this is intended behaviour.

what is the best way around this?

This depends on context. First of all, why you need to load all this comments into UoW in the first place? If you are going to delete it via DELETE, then you could collect needed ids also via DBAL (DQL). In this case no entities will be loaded into UoW.
Also if you only need to check that record presents in database, it will be much cheaper (from performance point of view) to add another custom query:
public function exists(int $id): bool
{
    return $this->createQueryBuilder('c')
            ->select('1')
            ->where('id = :id')
            ->setParameter('id', $id)
            ->getQuery()
            ->getOneOrNullResult(Query::HYDRATE_SINGLE_SCALAR) !== null;
}

This will not load any data into UoW.

The context: I discovered this while writing some tests. There I check if the entity exists (with the existsComment method), then I delete the comment (with deleteMultipleById). And I expected the entity to be deleted.
I really don't want to use get all the entities and delete them in a loop with the ->remove() method, from a performance point of view.
So am I correct, if I state that there is no way to combine the use of UnitOfWork with custom queries thru the QueryBuilder? Or is there a way to "clear" the UnitOfWork?
PS: I changed the title, I'm not that familiar with all Doctrine vocabulary.

You can either loop through all entities and detach them from the EntityManager or call clear which will either clear all entities or only those of the class you've passed. Either way, clear is a rather blunt tool you should be careful with.

And what happens if you update an entity with the query builder? Will the Identity Map be updated? And if not, how could you work around that?

It will not be updated: clearing the UnitOfWork is the safest approach
there.
On 15 Nov 2017 10:22, "Tijs Verkoyen"<EMAIL_ADDRESS>wrote:

And what happens if you update an entity with the query builder? Will the
Identity Map be updated? And if not, how could you work around that?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/issues/6827#issuecomment-344518965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakDUi1iGIOHGROP829AxBaqXShiRmks5s2p8ogaJpZM4Qdr9O
.

So clearing the full UnitOfWork instead of detaching the entities. I guess it will be refetched from the database when it is requested again?

Correct
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
On Wed, Nov 15, 2017 at 9:29 AM, Tijs Verkoyen<EMAIL_ADDRESS>wrote:

So clearing the full UnitOfWork instead of detaching the entities. I guess
it will be refetched from the database when it is requested again?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/doctrine/doctrine2/issues/6827#issuecomment-344520609,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJakJTbyyvnH3nof7JpBX5kE0vcnnvWks5s2qDggaJpZM4Qdr9O
.

Thx guys for helping a noob ;-)


A strange element appears at some point

![Снимок экрана 2021-09-24 в 17 31 36](https://user-images.githubusercontent.com/86955927/134691936-3b6649b8-0387-4ae7-9673-6157c9754ab4.png
Code:

)

It appears on ios after I finished typing password

On android everything ok


Extend Pod GC to keep them alive during Workflow Lifespan

Summary
Currently pods are automatically garbage collected which translates on logs being lost -unless an artifact repository is configured, and even then logs are difficult to consult-.
It would be good to have an option in spec.podGC.strategy like OnWorkflowDeletion that would allow the pods to live until then.
Use Cases
Whenever a workflow needs to be debugged, but the workflow has completed and pods have been garbage collected, so we can avoid setting up an artifact repository.
Artifact repository is not enough since, AFAIK, it's impossible to retrieve logs from Argo CLI after pods have been GC.
It is true that you can check logs stored in the Artifact repo through the Argo Server UI, but there could be cases where developers don't have access to the Argo Server.

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Isn’t this the same as not specifying pod GC and not deleting the workflow? Once you are done with debugging you can manually delete the workflow, which will also delete the pods associated with it via owner references.

Isn’t this the same as not specifying pod GC and not deleting the workflow? Once you are done with debugging you can manually delete the workflow, which will also delete the pods associated with it via owner references.

We currently don't have any pod GC and pods are being deleted automatically (sth like 10 minutes after completion) even though the workflows are kept via ttlStrategy

Sounds like an issue with ttlStrategy instead. Are you sure you don't have other GC mechanism on workflows in your cluster? Could you share a minimal reproducible example?

I've just spawned a workflow from this template, and after 20 minutes the pod was destroyed.
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: hello-world-vol
spec:
  serviceAccountName: argo-workflow-runner-dev
  ttlStrategy:
    secondsAfterSuccess: 14400    # Time to live after workflow is successful (4hours)
    secondsAfterFailure: 86400    # Time to live after workflow fails (24 hours)
  entrypoint: hello-world
  volumeClaimTemplates:
  - metadata:
      name: workdir
    spec:
      accessModes: [ "ReadWriteOnce" ]
      resources:
        requests:
          storage: 1Gi

  templates:
  - name: hello-world
    container:
      image: google/cloud-sdk:latest
      command:
        - /bin/sh
        - -c
        - |
          echo "Hello World"
      resources:
        limits:
          memory: 128Mi
          cpu: 100m
      volumeMounts:
        - name: workdir
          mountPath: /mnt/vol

    tolerations:
    - key: "argo-data-plane"
      operator: "Exists"
      effect: "NoSchedule"
    affinity:
      nodeAffinity:
        requiredDuringSchedulingIgnoredDuringExecution:
          nodeSelectorTerms:
          - matchExpressions:
            - key: argo-data-plane
              operator: In
              values:
              - "true"

For reference, this is the content of the Workflow Controller Configmap:
apiVersion: v1
data:
  config: |
    containerRuntimeExecutor: k8sapi
    artifactRepository:
      archiveLogs: true
      gcs:
        bucket: argo-workflows-logs
    workflowRestrictions:
      templateReferencing: Secure
kind: ConfigMap

I'm starting to think that it has something to do with the Persistent Volume Claim being Terminated. As I've tried exactly same workflow with no PVC and it's still alive.

Thanks. I'd suggest closing this enhancement proposal and file a separate "reproducible bug report" instead so we would have sufficient information (versions, logs, etc.) to help debug: https://github.com/argoproj/argo-workflows/issues/new/choose

Thanks. I'd suggest closing this enhancement proposal and file a separate "reproducible bug report" instead so we would have more information (versions, logs, etc.) to help debug: https://github.com/argoproj/argo-workflows/issues/new/choose

Ok, I've raised the following bug: https://github.com/argoproj/argo-workflows/issues/5518

Closing


update definition paths

Fixes # .

Changes proposed in this Pull Request:

update sprite definition paths

The d attribute defines a path to be drawn

Screenshots:

To Test:

yarn && yarn sprites should not create updated sprites

was trying to do local commit and test this but wasn't working out, so opened branch for it

now when I run yarn start, it undoes the output of yarn sprites...

now when I run yarn start, it undoes the output of yarn sprites...

wow, so weird. Ok we can just close this PR

a yarn start trumps the sprites and returns the same file changes


Add CITATION.cff file

📝 Summary
This PR adds a CITATION.cff file to the repository, providing standardized citation information for the marimo project. This addresses the discussion in #1743 about improving the project's citability.
🔍 Description of Changes
The CITATION.cff file is a machine-readable file that provides citation information for software or datasets. Key points about this change:

The file follows the Citation File Format (CFF) specification.
It includes basic information about the project, its authors, and how to cite it.
Placeholder values have been used for ORCID IDs and DOIs, which need to be filled in by the core maintainers.
The identifiers section has been included but may need to be updated or removed based on the maintainers' decision.

The CITATION.cff file was created with reference to the following resources:

Citation File Format official documentation
ArviZ CITATION.cff example
GitHub documentation on citation files
ruby-cff repository

The general usage and structure were inspired by:

Matplotlib CITATION.cff
ArviZ CITATION.cff
CFF Schema Guide

Note to maintainers:

Please add your respective ORCID IDs to the authors section.
Decide on whether to include the identifiers section. If yes, please provide the appropriate DOIs, Software Heritage numbers, or URLs. Examples of valid identifiers include:

DOI: 10.5281/zenodo.1003149 (The concept DOI of the work)
SWH: swh:1:dir:bc286860f423ea7ced246ba7458eef4b4541cf2d (The Software Heritage identifier for a specific version)
URL: https://github.com/citation-file-format/citation-file-format/releases/tag/1.1.0 (The GitHub release URL of a specific tag)
OTHER: arXiv:2103.06681 (The ArXiv preprint of a related paper)

Consider using the CFF Initializer for more detailed customization of the file.

📋 Checklist

[x] I have read the contributor guidelines.
[x] This change was discussed and approved through the community discussions.
[ ] I have added tests for the changes made.
[x] I have run the code and verified that it works as expected.

📜 Reviewers
@akshayka @mscolnick

@Haleshot - i just added by orcid number, thanks!

@Haleshot, added my orcid id as well. Thank you!

A pretty typical DOI method is produce a release under Zenodo, sometimes with the publication of a paper: https://zenodo.org
Zenodo becomes the cannonical snapshot vs using the repository itself.
Here's examples of other OSS libraries with citation methods:

Singularity: https://dl.acm.org/doi/10.1145/1243418.1243424
Numpy: https://www.nature.com/articles/s41586-020-2649-2 (wow, numpy with a nature article!)
Scikit Learn (depends on usage): https://scikit-learn.org/stable/about.html#citing-scikit-learn

Separating paper and software (and generously citing all contributors):

E3NN: https://github.com/e3nn/e3nn?tab=readme-ov-file#citing

I think marimo could easily publish something:

"Towards reproducible and deterministic notebooks"
"DAG is all you need" /s

A pretty typical DOI method is produce a release under Zenodo, sometimes with the publication of a paper: https://zenodo.org
Zenodo becomes the cannonical snapshot vs using the repository itself.

I was thinking the same; the examples provided above (from your comment and my PR) can help serve as a reference for the kind of journals which exist for publication of software/frameworks/libraries + their respective papers. Might be something for the maintainers to look into.

"DAG is all you need" /s

Perfect

Came across this, Jupyter citations: https://fangohr.github.io/blog/jupyter-for-computational-science-and-data-science.html#references

I'm sure one day we'll write a paper -- maybe under JMLR OSS Software -- but that'll be later.
In the meantime I set up Zenodo to archive each release. Here's the latest release with a DOI: https://zenodo.org/records/12735330

I'm sure one day we'll write a paper -- maybe under JMLR OSS Software -- but that'll be later.
In the meantime I set up Zenodo to archive each release. Here's the latest release with a DOI: https://zenodo.org/records/12735330

Added the identifier section pointing to the latest release (version) of marimo.

looks great, thanks @Haleshot! will merge


[WFCORE-4167] Upgrade to WildFly Galleon Plugins 2.0.2.Final and prop…

…erly configure plugin dependencies
https://issues.jboss.org/browse/WFCORE-4167

@wolfc fyi, this is the feature-spec-gen maven dependency-related change in WFCORE


Some Emails not Reaching Postal

Hi, is there any reason why postal may not receive an email? We have checked the logs, settings, etc and we get reports, from time to time, that a specific email didn't reach postal. We have nothing on logs, so wonder if this problem is something that happens often.

When you say not received an email, is someone else emailing an incoming route set up in Postal? If there are no log entries for the message then you would have to confirm with that other individual that the message was sent or what the response from Postal was.


Feature/network structure

Simple updates: server in client

@platfowner Thanks for the quick review! I am merging it now for the further updates!!


MicrogliaMorphologyR Package Trouble

Hello,
I wanted to reach out about some difficulty I've been having with installing and accessing the MicrogliaMorphologyR package in RStudio. When I attempt to install the package, a warning message appears (see attached). I've tried to troubleshoot by reinstalling the most recent versions of RStudio and R as well as several other CRAN suggestions -- but unfortunately the warning persists. There didn't appear to be any issues with using devtools to access the github, so it seems like I'm struggling with the MicrogliaMorphologyR package itself. I would be grateful for any suggestions or help you may have. Thank you!

Hello! The R package is not registered on CRAN, so you will have to use the following code to install it:
devtools::install_github('ciernialab/MicrogliaMorphologyR')