adding new StringNoHyphens func

Coverage decreased (-3.2%) to 94.294% when pulling 1639195d9fe9fde19465bd46e25d8899a6493fa2 on bpgriner:string-no-hyphens into b2ce2384e17bbe0c6d34077efa39dbab3e09123b on satori:master.

You're welcome.
// Returns string representation of UUID without hyphens.
func (u UUID) StringNoHyphens() string {
	return hex.EncodeToString(u[:])
}

looks like the build failed before the tests even ran:
exit status 1: # github.com/satori/go.uuid
codec_test.go:27:2: cannot find package "gopkg.in/check.v1" in any of:
	/home/travis/.gimme/versions/go1.6.4.linux.amd64/src/gopkg.in/check.v1 (from $GOROOT)
	/home/travis/gopath/src/gopkg.in/check.v1 (from $GOPATH)
FAIL	github.com/satori/go.uuid [setup failed]

can another build be kicked off?

@tariq1890 I updated the comment 👍


pdb files get deployed

Hi,
I found some pdb files in the folder C:\Program Files (x86)\Chocolatey GUI
chocolatey.pdb
chocolateygui.pdb
MahApps...
Mindscape...
Afaik these files are for Visual Studio debugging sessions only, no need to deploy.
Chocolatey GUI v0.16.0
hth

It appears that this question has been answered. I'll go ahead and close it. We can always re-open it in the future.


Set up Pytest Coverage

This would be a huge lift! Simply do not know how and don't have much time right now...
Generally any improvements in test coverage would be great and having evals would be amazing

On it

Name
Stmts
Miss
Cover

init.py
0
0
100%

test_distil.py
56
8
86%

test_function_calls.py
34
1
97%

test_multitask.py
9
0
100%

test_patch.py
97
31
68%

TOTAL
196
40
80%

@jxnl did the table help?


Ignore src/lib.rs or src/main.rs depending on crate type

Related issue: #12

Cargo generate 0.10 is now released. I will have a look at this in the following days :)

Just tested it and it works, thanks a lot!


LSPServer doesn't clear diagnostics for deleted files

Steps To Reproduce
Run ./scripts/run-vscode-extension and wait for the Rome extension to output that it's watching.
Add an error to an existing file so that Rome publishes a diagnostic in the Problems tab.
Delete that file.
Results
The diagnostic remains published for that deleted file in the Problems tab.

Can you repro with ‘rome lint --watch’? I think you’ll see the same behaviour.

Yes, if I run lint --watch then delete a file with diagnostics, the diagnostics will stay logged (although the code frame loses the relevant code sample).

Is there any way to get a FileReference for a deleted path?
A quick and dirty solution for this issue is that Linter#runWatch and LSPServer#watchProject each create subscriptions to handle their own deletions, but it would be better if LintRunner#run just returned diagnostics-less LintWatchChanges for deleted files.
Would it make any sense to create an AbsoluteFilePathMap<FileReference> of deleted files somewhere that LintRunner could use when it hits a FileNotFound?

but it would be better if LintRunner#run just returned diagnostics-less LintWatchChanges for deleted files.

This should already be happening. Lines 222-229 of Linter.ts is already meant to handle deleted paths. The paths that watchFilesFromArgs emits includes deleted files. Is watchFilesFromArgs not emitting them?
In LintRunner#computeChanges we should then be producing a changes object for all updated paths, and so it should then produce an empty diagnostics array.
There's already code to handle all this there must just be a bug somewhere.

I think those lines in Linter.ts only do anything when a file is deleted while the queue is spinning down. But I don't think you can currently WorkerQueue#pushQueue a path that doesn’t exist.
If LintRunner#run is being executed as part of a watchFilesFromArgs callback in response to a refreshFileEvent for a deleted file, queue.pushQueue(path) is just going to result in a FileNotFound when it tries to get a WorkerContainer.
I added the allowMissing to prevent it from crashing, but I didn’t notice at the time that we were left with uncleared diagnostics.
I'm also not sure if the updatedPaths in computeChanges includes deleted paths at the point. I haven't looked at it closely, but wouldn't the call to projectManager.getFileReference(path) on line 388  just throw an error if that were the case?

Ahhh that makes sense.

If LintRunner#run is being executed as part of a watchFilesFromArgs callback in response to a refreshFileEvent for a deleted file, queue.pushQueue(path) is just going to result in a FileNotFound when it tries to get a WorkerContainer.

I think what needs to be done to fix this:

Add LintRunner#clearDiagnosticsForPath(path: AbsoluteFilePath) that contains:

this.compilerDiagnosticsCache.set(
	path,
	{suppressions: [], diagnostics: []},
);

Update the queue.addCallback callback to use it.

Change the pushQueue wrapping to:

for (const path of evictedPaths) {
	const found = await FileNotFound.allowMissing(path, async () => {
		await queue.pushQueue(path);
		return true;
	});

	if (found !== true) {
		this.clearDiagnosticsForPath(path);
	}
}

I think that should resolve the remaining issues? I haven't tested it.

I'm also not sure if the updatedPaths in computeChanges includes deleted paths at the point. I haven't looked at it closely, but wouldn't the call to projectManager.getFileReference(path) on line 388 just throw an error if that were the case?

It should. In runGraph the returned paths are basically all the changed file paths + dependents. We do this in case since file updates can cause the dependencies of another file to potentially change to fail or pass.

I'd tried that, but I don't think that runGraph returns deleted paths in validatedDependencyPaths because of the allowFileNotFound: true in graph.seed() and because of:
for (const path of evictedPaths) {
  const newNode = graph.maybeGetNode(path);

  if (newNode === undefined) {
    continue;
  }
  validatedDependencyPaths.add(path);
  // ...
}

I think the problem is that LintRunner#computeChanges needs a FileReference to create a LintWatchChanges but if anything calls projectManager.getFileReference(path) for a missing path, it just throws an error because ProjectManager has already cleaned up in response to deletedFileEvent.
That's why I was asking about a deletedPathToFileReference map or something (maybe on ProjectManager?) that LintRunner could use to produce a LintWatchChanges object whenever it sees FileNotFound for an evicted path. I don't know whether or not that's a clean solution. I haven't tried to implement it.

Ah, you should just be able to put validatedDependencyPaths.add(path); before the if, right?

but if anything calls projectManager.getFileReference(path) for a missing path, it just throws an error because ProjectManager has already cleaned up in response to deletedFileEvent.

What specifically does getFileReference call that throws an error? It should just work fine on deleted paths, although it still shouldn't be called.
Regardless, we could just do this.server.memoryFs.exists in the loop where we do changes.push to handle it.

Ah, you should just be able to put validatedDependencyPaths.add(path); before the if, right?

I think that would cause problems later with the graph.validate() which doesn't use maybeGetNode. Plus I think you'd want to rename it if you were adding a path to the set without validating it, hah. But LintRunner#computeChanges gets passed evictedPaths, so can we just assume that any path in evictedPaths but not in updatedPaths is a deleted file?

What specifically does getFileReference call that throws an error?

Hmm, I think it was the assertProjectExisting in getFileReference that was giving me trouble, but I must have been doing something wrong because that doesn't seem like it should be a problem, now that I take a closer look at it.

It should just work fine on deleted paths, although it still shouldn't be called.

If the change object doesn't contain a filename and FileReference, then I think the old diagnostics can't be removed by Linter#runWatch and LSPServer respectively. If we shouldn't call getFileReference for a deleted path, how do we create the change object in computeChanges?

I found it pretty hard to follow so in the process of investigating I fixed it and opened #672. It's weird because we need to reconcile two different sources of diagnostics. The dependency graph which when validated will return possible cached diagnostics. And then separately diagnostics from the compiler. When we source diagnostics from only the dependency graph and never the compiler then we need to readd them. I'll leave some comments on the linked PR to clarify some things.


Slow software rendering  after big October 6 update

Hi to all the FreeRDP team (and @antenore). I have seen the big changes in October 6 updates and I'm updating Remmina to support it. I can see some interesting improvements, for example code cleanup by correctly delegating some allocations to libfreerdp and not to the client. Very good.
Currently Remmina make use of libfreerdp's software GDI, like xfreerdp /gdi:sw, and with the commits of october 6, the software GDI rendering is now noticeably slower. Are you planning to improve it, or should we try to start to develop some kind of GDI rendering inside Remmina ?
Thank You.

Not sure about GDI but I'm facing some huge memory leak after last update. Memory usage skyrocketing within 5 mins to 300+mb, sadly I have to make rollback for the time being.
My connection string: xfreerdp /u:user /p:**** /v:host +multitransport +clipboard -decorations /f /bpp:8 +compression /compression-level:2 +bitmap-cache +offscreen-cache +async-update +aero +fonts /gdi:hw /cert-ignore

@mr-wong I can confirm memory leaks: I compiled xfreerdp with "-DWITH_GCC_SANITIZE_ADDRESS=on" on cmake commandline. And at the exit, yes, the address sanitizer shows a lot of memory leaks.

any chance that you could git-bissect to find the faulty commit ?

@hardening: I'm trying to bisect to find the slowness problem. But it's hard, because intermediate steps are sometimes buggy and simply they don't work. For example, a lot of intermediate commit fails when connecting with
[12:08:25:744] [27852:27853] [ERROR][com.freerdp.core.codecs] - Failed to create h264 codec context
Is there a temporary workaround for this specific connection error?

@giox069 Bisecting will probably not be helpful here, mostly rewritten the GDI color handling. A performance profile would be very interesting though.

@giox069 if I'm not mistaken does the "the Failed to create h264 codec context" happen if you connect with gfx but don't have openh264 available. So this should be solved if you set Gfx-H264 to FALSE.
Regarding the performance issues it would be quite interesting what functions are generally causing the slowdown. What type of connection do you run? Could you run valgrind with callgrind/cachgrind and see what are the hot spots?

closing as #3536 and #3537 have been merged.


Add Findwork.dev

Oh I totally missed this. This looks like a job aggregator is that true?

Oh I totally missed this. This looks like a job aggregator is that true?

Yes it is!

Added to aggregators! Thanks!


uns must not contain values of zero length

See schema ticket

Doh. Auto-closed the wrong issue.

I re-opened the issue since we discovered a bug with this while running the dev migration. But it should be resolved by this, so re-closing this issue. https://github.com/chanzuckerberg/single-cell-curation/pull/803


How to catch webApiClient errors using Bolt?

Description
Hi,
I'm using Slack Web API client along Bolt. I would like to know if there is a way to catch errors thrown by the Web API client :
appClient.ts

import * as SlackClient from '@slack/web-api'
import Tokens from '@config/slack'

const slackApiClient = new SlackClient.WebClient(Tokens.SLACK_BOT_TOKEN)

export default slackApiClient

index.ts
import slackApiClient from '@helpers/slack/apiClient'

const displayModal = async (view: any, trigger_id: string) => {

	try {
		await slackApiClient.views.open({
			trigger_id: trigger_id,
			view:
		})
	}
	catch(e){
		// Handle error
	}
}

const res = await displayModal(myview, 'mytriggerid')

Now if I intentionally send a corrupted view (say a modal title with more than 25 characters), I will catch the API error (Error: An API error occurred: invalid_arguments) but I can't find a way to get the client  error ( WebClient:0 must be less than 25 characters [json-pointer:/view/title/text]) that is sent to stderr. Is there a way to get it within JS ?
Thanks for your help
What type of issue is this? (place an x in one of the [ ])

[ ] bug
[ ] enhancement (feature request)
[x] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Ok so a custom logger is the solution in this case, as explained here https://slack.dev/bolt/concepts#logging
appClient.ts
import * as SlackClient from '@slack/web-api'
import Tokens from '@config/slack'

const logger = {
	debug(msgs: any) { //... },
	info(msgs: any) { //... },
	warn(msgs: any) { //... },
	error(msgs: any) { //... },
}

const slackApiClient = new SlackClient.WebClient(Tokens.SLACK_BOT_TOKEN, { logger })

export default slackApiClient


Fixes #1 pane selection

if using multible panes so that a pane switch could be recognize

Thanks!


Website for doge for future use.

We could make a website with best UI?UX designers so that it could be easily accessible by others. And, also it would be very beneficial for the growth of DOGE in future. Help, to understand about the holdings, sells, buys and etc in the near future

Could also build a payment gateway for tesla and for coming projects.

Could we just develop dogecoin.com further?
What are some ideas you would like implimented?

I want to join，it's so cool~🙋

@freethe3rdworld you have done amazing work buddy. Let's try to make it more user friendly and easily accessible by others. And can also link the exchanges on the same.

@freethe3rdworld you have done amazing work buddy. Let's try to make it more user friendly and easily accessible by others. And can also link the exchanges on the same.

This is not my project, it's the official Dogecoin website.
So I suggest coming up with a list of features and products and ways to achive it.


Implement selector when using treeSelect annotation

Tested: make test

/assign @yiqigao217
/assign @adrianludwin

Tested: make test

Maybe say why you think this is sufficient testing

... make test was technically all I did for #1174 but the entire commit message is about the test!

Tested: make test

Maybe say why you think this is sufficient testing

Ping!

Work in progress
/hold

Tested: make test

Maybe say why you think this is sufficient testing

Done, please let me know if I can make it more clear

This PR is ready for review
/hold cancel

Can you please rewrap the commit message? Nice work on the testing documentation. It doesn't have to be quite that detailed, you could just say something like "added tests for treeSelect and to test interaction with select." Up to you though.

Updated

Can you please rewrap the commit message? Nice work on the testing documentation. It doesn't have to be quite that detailed, you could just say something like "added tests for treeSelect and to test interaction with select." Up to you though.

Updated

The commit message still doesn't look properly word-wrapped? I.e. some lines are much longer than others.

Can you please rewrap the commit message? Nice work on the testing documentation. It doesn't have to be quite that detailed, you could just say something like "added tests for treeSelect and to test interaction with select." Up to you though.

Updated

The commit message still doesn't look properly word-wrapped? I.e. some lines are much longer than others.

Oh the line length was decided by vim, I actually don't know why some lines are longer. If I do a manually enter to separate the longer lines, vim shows me that other lines don't have a return symbol but just those longer lines. Do you know how to format line length in vim?

Oh the line length was decided by vim, I actually don't know why some lines are longer. If I do a manually enter to separate the longer lines, vim shows me that other lines don't have a return symbol but just those longer lines. Do you know how to format line length in vim?

Highlight all the relevant lines (eg using the V command) and then hit gq.

/lgtm
/hold cancel


Elastic client update

Adding to Elasticsearch client its HNSW support. Also requiring certifications for connecting to the server (if you think its redundant, let me know)
for using elasticsearch client, pass username and password with --user, --auth as before, or use environment variable ELASTIC_PASSWORD
for passing certification file, use ELASTIC_CA environment variable.
I'm assuming the we have a server with security settings. if not, this is redundant but it should work anyway.

@GuyAv46 I suggest we simplify the host port usage due to:
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/dist-packages/elastic_transport/_serializer.py", line 93, in loads
    return self.json_loads(data)
  File "/usr/local/lib/python3.10/dist-packages/elastic_transport/_serializer.py", line 89, in json_loads
    return json.loads(data)
  File "/usr/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.10/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/root/ann-benchmarks/ann_benchmarks/main.py", line 40, in run_worker
    run(definition, args.dataset, args.count, args.runs, args.batch,
  File "/root/ann-benchmarks/ann_benchmarks/runner.py", line 102, in run
    algo = instantiate_algorithm(definition)
  File "/root/ann-benchmarks/ann_benchmarks/algorithms/definitions.py", line 24, in instantiate_algorithm
    return constructor(*definition.arguments)
  File "/root/ann-benchmarks/ann_benchmarks/algorithms/elasticsearch.py", line 62, in __init__
    es_wait(self.es)
  File "/root/ann-benchmarks/ann_benchmarks/algorithms/elasticsearch.py", line 29, in es_wait
    res = es.cluster.health(wait_for_status='yellow', timeout='1s')
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/_sync/client/utils.py", line 414, in wrapped
    return api(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/_sync/client/cluster.py", line 454, in health
    return self.perform_request(  # type: ignore[return-value]
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/_sync/client/_base.py", line 390, in perform_request
    return self._client.perform_request(
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/_sync/client/_base.py", line 286, in perform_request
    meta, resp_body = self.transport.perform_request(
  File "/usr/local/lib/python3.10/dist-packages/elastic_transport/_transport.py", line 348, in perform_request
    data = self.serializers.loads(raw_data, meta.mimetype)
  File "/usr/local/lib/python3.10/dist-packages/elastic_transport/_serializer.py", line 196, in loads
    return self.get_serializer(mimetype).loads(data)
  File "/usr/local/lib/python3.10/dist-packages/elastic_transport/_serializer.py", line 95, in loads
    raise SerializationError(
elastic_transport.SerializationError: Unable to deserialize as JSON: b'Client sent an HTTP request to an HTTPS server.\n'

lets simply use something like:
def __init__(self, metric: str, dimension: int, conn_params, method_param):
        self.name = f"elasticsearch-script-score-query_metric={metric}_dimension={dimension}_params{method_param}"
        self.metric = {"euclidean": 'l2_norm', "angular": 'cosine'}[metric]
        self.method_param = method_param
        self.dimension = dimension
        self.timeout = 60 * 60
        h = conn_params['host'] if conn_params['host'] is not None else 'localhost'
        p = conn_params['port'] if conn_params['port'] is not None else '9200'
        u = conn_params['user'] if conn_params['user'] is not None else 'elastic'
        a = conn_params['auth'] if conn_params['auth'] is not None else ''
        self.index = "ann_benchmark"
        self.es = Elasticsearch(f"{h}:{p}",  request_timeout=self.timeout, basic_auth=(u, a), ca_certs=environ.get('ELASTIC_CA', DEFAULT))
        self.batch_res = []
        es_wait(self.es)

Furthermore, starting to run the benchmark we reach timeouts after 1-2minutes:
root@ip-172-31-57-10:~/ann-benchmarks# python3 run.py --algorithm elasticsearch --dataset dbpedia-768 --runs 1 --run-group M-4 --host https://<AAAAAAAAA> --port 443 --auth <AAAAAAA> --local
Changing the workdir to /root/ann-benchmarks
2022-07-18 13:15:19,517 - annb - INFO - running only elasticsearch algorithms
2022-07-18 13:15:19,517 - annb - INFO - running only M-4 run groups
2022-07-18 13:15:19,573 - annb - INFO - Order: [Definition(algorithm='elasticsearch', run_group='M-4', constructor='ElasticsearchScriptScoreQuery', module='ann_benchmarks.algorithms.elasticsearch', docker_tag='ann-benchmarks-elasticsearch', arguments=['angular', 768, {'host': 'https://vecsim.es.us-east-1.aws.found.io', 'port': 443, 'auth': 'Q0bna41oBWcZsuR785Dr891z', 'user': None, 'cluster': False, 'shards': '1'}, {'m': 4, 'ef_construction': 500, 'type': 'hnsw'}], query_argument_groups=[[10], [20], [40], [80], [120], [200], [400], [600], [800]], disabled=False)]
Trying to instantiate ann_benchmarks.algorithms.elasticsearch.ElasticsearchScriptScoreQuery(['angular', 768, {'host': 'https://vecsim.es.us-east-1.aws.found.io', 'port': 443, 'auth': 'Q0bna41oBWcZsuR785Dr891z', 'user': None, 'cluster': False, 'shards': '1'}, {'m': 4, 'ef_construction': 500, 'type': 'hnsw'}])
Waiting for elasticsearch health endpoint...
Elasticsearch is ready
got a train set of size (1000000 * 768)
2022-07-18 13:22:00,893 - elastic_transport.node_pool - WARNING - Node <Urllib3HttpNode(https://vecsim.es.us-east-1.aws.found.io:443)> has failed for 1 times in a row, putting on 1 second timeout
Process Process-1:
Traceback (most recent call last):
  File "/usr/lib/python3.10/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/root/ann-benchmarks/ann_benchmarks/main.py", line 40, in run_worker
    run(definition, args.dataset, args.count, args.runs, args.batch,
  File "/root/ann-benchmarks/ann_benchmarks/runner.py", line 146, in run
    algo.fit(X_train, **fit_kwargs)
  File "/root/ann-benchmarks/ann_benchmarks/algorithms/elasticsearch.py", line 98, in fit
    (_, errors) = bulk(self.es, gen(), chunk_size=500, max_retries=9)
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/helpers/actions.py", line 524, in bulk
    for ok, item in streaming_bulk(
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/helpers/actions.py", line 438, in streaming_bulk
    for data, (ok, info) in zip(
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/helpers/actions.py", line 339, in _process_bulk_chunk
    resp = client.bulk(*args, operations=bulk_actions, **kwargs)  # type: ignore[arg-type]
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/_sync/client/utils.py", line 414, in wrapped
    return api(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/_sync/client/__init__.py", line 693, in bulk
    return self.perform_request(  # type: ignore[return-value]
  File "/usr/local/lib/python3.10/dist-packages/elasticsearch/_sync/client/_base.py", line 286, in perform_request
    meta, resp_body = self.transport.perform_request(
  File "/usr/local/lib/python3.10/dist-packages/elastic_transport/_transport.py", line 329, in perform_request
    meta, raw_data = node.perform_request(
  File "/usr/local/lib/python3.10/dist-packages/elastic_transport/_node/_http_urllib3.py", line 199, in perform_request
    raise err from None
elastic_transport.ConnectionTimeout: Connection timed out

so lets also try disable the index updates while we bulk load via refresh_interval changes and then enable it at the end.


Add functional tests for entry, item and record

Adding tests to ensure that entry, item and record pages return a 200 status code when we expect the thing to exist.

:+1:


BUG: Fixes KeyError when indexes don't overlap.

Closes #10291

#10291 & #12133 for easy linking.

Can you edit your first post to include "Closes #10291, Closes #12133" so that Github will auto-close those issues when we merge?
Also would need a release note in doc/source/whatsnew/v0.18.0 under bug fixes and maybe add a note to the docstring of crosstab explaining that this is the outcome for non-overlapping indices. Thanks!

you need a test to cover #12133

pls add a whatsnew as well

Thought it may be easier in the near term to reduce the scope of this change to fixing the issue associated with #10291 and not attempt a fix at #12133.
I've added #12133 to my todo list so I'll try to get back to it.

thanks @tshauck

if values_passed and not values_multi and not table.empty:
Excuse me, but how does this cover #12133? index names are dropped earlier in if not dropna: block. We need to pass names to from_arrays:
m = MultiIndex.from_arrays(cartesian_product(table.index.levels), names=table.index.names)
...
m = MultiIndex.from_arrays(cartesian_product(table.columns.levels), names=table.columns.names)

if u read the comments about it does not cover 12133


[Task]: Perform a round of testing with Ballerina Regex

Description
$subject
Describe your task(s)
No response
Related area
-> Compilation
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This is a report of the issues that found during the round of testing.
https://docs.google.com/document/d/16M00wk57wG-QeT5H4sFH3BpvoUId9oubWNRwWxd3FRg/edit?usp=sharing


Simplify Postpublish

Remove interactions with ../d3.github.com from postpublish script.
Closes #27

You can also remove this part:
VERSION=`node -e 'console.log(require(\"./package.json\").version)'`;

Not only is to not needed, but if it were, you can use the built-in ${npm_package_version}.

Thanks! I think I can also remove the zip command, I'm not sure what the utility of that is.


Samsung HW-Q990D not supported yet? :-)

Hi,
Just asking as a noob, is it possible to add support for the newest model HW-Q990D?
At the moment I figured out to get the entity.
Now I only have:
On/Off
Play/Pause
Mute/Unmute
Volume + / Volume - (with volume bar)
Thanks!

@LJ-Stevo @Greg-or-y
Can you show the state and attributes of entity that is created?

Działa  tylko  głośniej/ciszej  i  mute.  brak  wyboru wejścia (na dole pierwszego screena)

Nie widzę też wartości  liczbowej  określającej aktualny poziom   głośności, co jest przydatne w  automatyzacji.

coś w logach jest?

Do you have built-in Smartthings integration configured?

Hey @PiotrMachowski,
I'm having similar trouble with a HW-Q930D (2024).
I get the same error as @Greg-or-y in the Home Assistant log.

Update for media_player.q_series_soundbar fails

Logger: homeassistant.helpers.entity
Source: helpers/entity.py:942
First occurred: 20:52:39 (1 occurrences)
Last logged: 20:52:39
Update for media_player.q_series_soundbar fails

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 942, in async_update_ha_state
    await self.async_device_update()
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1302, in async_device_update
    await hass.async_add_executor_job(self.update)
  File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/smartthings_soundbar/media_player.py", line 68, in update
    SoundbarApi.device_update(self)
  File "/config/custom_components/smartthings_soundbar/api.py", line 39, in device_update
    playback_state = data['main']['playbackStatus']['value']
                     ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
KeyError: 'playbackStatus'

Similar to @LJ-Stevo, I'm also only presented with power, play/pause, volume up/down, and no volume level.

State: media_player.q_series_soundbar

State: on

volume_level: 1
is_volume_muted: false
media_title:
source:
device_class: speaker
friendly_name: Q-Series Soundbar
supported_features: 85389

The built-in SmartThings integration (using a separate API key with identical permissions) is able to show the current input and volume level, in addition to emitting a power switch at switch.q_series_soundbar.

States: sensor.q_series_*

I'm happy to provide any other details that could assist with debugging.
Thanks for your work on this integration :)

Same error with HE-LS60D music frame.

@PiotrMachowski below you can find a response looks like for a GET req to this endpoint: https://api.smartthings.com/v1/devices/dev_id/states
I think the problem is that they removed playbackStatus from main node.
{     "main": {         "logType": {             "value": "[\"errCode\",\"dump\"]"         },         "mndt": {             "value": "2024-01-01"         },         "mnfv": {             "value": "SAT-MT8532D24WWC-1016.0"         },         "role": {             "value": null         },         "mnhw": {             "value": ""         },         "detailName": {             "value": "External Device"         },         "data": {             "value": null         },         "di": {             "value": "xxx-xxx-xxx-xxx"         },         "supportedInputSources": {             "value": "[\"digital\",\"HDMI1\",\"bluetooth\",\"wifi\",\"HDMI2\"]"         },         "supportedWiFiFreq": {             "value": "[\"2.4G\",\"5G\"]"         },         "mnsl": {             "value": ""         },         "dmv": {             "value": "res.1.1.0,sh.1.1.0"         },         "tsId": {             "value": "VD02"         },         "switch": {             "value": "off"         },         "dumpType": {             "value": "file"         },         "mode": {             "value": "10"         },         "vid": {             "value": "VD-NetworkAudio-003S"         },         "endpoint": {             "value": "PIPER"         },         "mnpv": {             "value": "8.0"         },         "icv": {             "value": "core.1.1.0"         },         "mediaOutputSupported": {             "value": null         },         "autoReconnection": {             "value": "true"         },         "st": {             "value": "1970-01-01T00:00:44Z"         },         "updatedTime": {             "value": "1732343424"         },         "minVersion": {             "value": "3.0"         },         "wifiUpdateSupport": {             "value": "true"         },         "executableServiceList": {             "value": null         },         "setupId": {             "value": "301"         },         "supportedAuthType": {             "value": "[\"OPEN\",\"WEP\",\"WPA-PSK\",\"WPA2-PSK\",\"EAP\",\"SAE\",\"OWE\",\"FT-PSK\"]"         },         "mobileCamSupported": {             "value": null         },         "mute": {             "value": "unmuted"         },         "protocolType": {             "value": "ble_ocf"         },         "n": {             "value": "Q-Series Soundbar"         },         "mnId": {             "value": "0AJK"         },         "volume": {             "value": "15",             "unit": "%"         },         "mnmo": {             "value": "HW-Q990D"         },         "mnmn": {             "value": "Samsung Electronics"         },         "imeAdvSupported": {             "value": null         },         "mnml": {             "value": ""         },         "mnos": {             "value": "Tizen"         },         "signinPermission": {             "value": null         },         "pi": {             "value": "xxxx-xxxx-xxxx"         },         "inputSource": {             "value": "digital"         },         "status": {             "value": "Idle"         }     } }

Same as https://github.com/PiotrMachowski/Home-Assistant-custom-components-SmartThings-Soundbar/issues/71#issuecomment-2453575704
Soundbar HW-Q930D. Should I open another issue?

Should be fixed in v1.0.5

@PiotrMachowski can confirm this fixes things on my end- thanks for your work on this! 🚀

It's also kinda working for me on Q930D but I changing source does nothing and it's missing TV/ARC source.

@TTLucian is that a downgrade compared to previous version?

Nope. Previous version was not working at all. Not even the volume

Can you show state and attributes of soundbar entity from dev tools?

source_list:
  - D.IN
  - HDMI1
  - BT
  - WIFI
volume_level: 0.1
is_volume_muted: false
source: D.IN
device_class: speaker
friendly_name: Soundbar
supported_features: 85389

The current source is TV/ARC but it's missing.
I can't find anything in HA logs. Not even with debug log enabled.


Better understand Wikimedia datasets

https://www.mediawiki.org/wiki/Special:Export
Things to understand better:
topics/categories
namespaces

We have a pretty good understanding of data layout for pages now.


pgsu always writes to stderr, and this cannot be suppressed

When using functionality from pgsu in a Jupyter notebook I always get messages like the following printed to stderr:
Trying to become 'postgres' user. You may be asked for your 'sudo' password.
could not change directory to "..../code/aiida-dynamic-workflows": Permission denied

These messages cannot be suppressed with contextlib.redirect_stderr, and there is no pgsu setting that I am aware of to suppress these messages.
AFAIK this happens here: https://github.com/aiidateam/pgsu/blob/master/pgsu/init.py#L294
we explicitly set the stderr of a subprocess to subprocess.STDOUT, which does not respect any reassignments to sys.stdout (e.g. by the redirect_stderr context manager). This is expected and documented behaviour of the subprocess module.
Would it be possible to have stderr redirected to a log, so that it may be managed with standard logging infra?

Absolutely! Would you be able to make a small PR?
Happy to review and release asap

fixed by https://github.com/aiidateam/pgsu/pull/30


Framework-specific searches mostly redirect to React results without any indication

Describe the bug
When initiating a search from a framework specific subsite of the docs (ie. vue-query), search results will mostly be related to react-query, but it is not indicated. After clicking upon any of these hits, my sidebar also changes to react-related items (which I understand might be a desired behaviour for direct links, but it is a sub-optimal experience for searches initiated from the docs).
Your minimal, reproducible example
https://tanstack.com/query/v5/docs/framework/vue/overview
Steps to reproduce

Go to a framework-specific subsite of the docs, ie. https://tanstack.com/query/v5/docs/framework/vue/overview
Click on the search field in the left sidebar
Type a search term into the search window (ie. refetch)
Choose a search result
You'll (most probably, depending on the content) be redirected to the react-query subpages AND the sidebar content items' badge will also change to "react" (again, obviously depending on the content)

Expected behavior
As a developer reading the tanstack query docs, I'd expect to get framework-specific results if I initiate my search from a framework specific subsite.
If there are no hits regarding my relevant framework,

either don't even include those hits OR
add a small badge near the result (like in the sidebar), indicating the framework the given hit is relevant to

How often does this bug happen?
Every time
Screenshots or Videos
https://github.com/user-attachments/assets/280edd03-5617-4144-83f6-7d47c3004bfa
Platform
OS: Windows11
Browser: Firefox Developer Edition 132.0b9 (64-bit)
but the issue is reproducible on any browser.
Tanstack Query adapter
None
TanStack Query version
v5
TypeScript version
No response
Additional context
The issue is very similar when searching across product versions (v3-v4-v5). For example, I choose React as a framework and set v3 in the sidebar. Initiate a search. When clicking a search result (probably depending which result it is), I'm taken back to "latest", without any way of knowing whether the article applies to all versions (or only to latest, even though I specifically searched for v3 or v4).

Please file this issue in the tanstack . com repo - there isn't anything we can do here about this: https://github.com/TanStack/tanstack.com


Fix context for window.fetch; Remove unnecessary done() function in test

BUG

This change is

Comments are addressed. All tests now pass. I tested integration_tests/benchmarks also and confirmed it works, @annxingyuan

Thanks @caisq :)


HTML output of traceable directives don't contain traceable ID

Hello,
first i would like to say that i like your extension really much and i'm about to use it for my documentations.
However i have a problem with my traceable objects. When i  generate my HTML documentation the relative page links are broken and didn't work. This behaviour is also present with your example. The link "http://localhost:63342/demo/build/hercules.html#traceables-1" works only for the page but not for the specified id "#traceables-1"
After taking a look to the generated html i figured out that generated tag has no id attribute
...```

I have never written an sphinx extension but comparing to the tutorial and other sources your implementation look fine for me.

def create_target_node(self, env, tag, attributes):
serial = env.new_serialno("traceables")
target_id = "traceables-{0:d}".format(serial)
target_node = nodes.target("", "", ids=[target_id])
...

My environment is python 2.7.9 with sphinx 1.3.5.

Hope you can help me. Cya

Hello again,
I tried to generate xml instead of html with success. Here i can found the target id ** ids="traceables-1"**

Bugfix works! Thank you really much.


Add progress bar in mpris

I could find any DE or clients supporting this so it's currently untestable


Move "printer column" options under the same generator config struct

Issue N/A
Initially we used to have one config field ("is_printable") under
ackconfig.FieldConfig to instruct the code generator to generate
kubebuilder marker comments in order to include the field in kubectl get
response.
Time passed and we are in a situation where want to tune more the way
we print these fields and extend the kubebuilder:printcolumns comment
markers to include options like priority, order and default columns.
This patch reworks the field configuration structure and prepare the
laying ground for future print config fields.
This patch will simplify the realization of the following issues:

https://github.com/aws-controllers-k8s/community/issues/821
https://github.com/aws-controllers-k8s/community/issues/822
https://github.com/aws-controllers-k8s/community/issues/823

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaypipes @RedbackThomson i'm aware that this is a breaking change, but TBH this is necessary to minimize damage (very verbose and non-understandable config files) in the future.
I made a research and it looks like only sagemaker-controller uses "is_printable" field - i'll make sure to make the necessary changes there.


Preqreqs need update: az and gh cli

[Enter feedback here]
The prereqs have two issues I can see in this doc:

it does not list az cli but I believe you need it to do the az login, at least currently
it prereqs Github cli (not just git) and I don't think that's needed.  Maybe it's a soft dependency just for creating pipelines? an could be labeled this way?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d31e2f07-64ce-ae10-e15b-4bc52e1c2fd5
Version Independent ID: d31e2f07-64ce-ae10-e15b-4bc52e1c2fd5
Content: Get started using Azure Developer CLI (azd) Preview
Content Source: articles/azure-developer-cli/get-started.md
Product: azure
GitHub Login: @puicchan
Microsoft Alias: puichan

Thanks, this doc was updated but the issue wasn't closed.

#please-close


c++ cleanup: standardize file extensions to .cc and .h

https://github.com/commaai/openpilot/issues/20799

Sorry, I created a lot of these inconsistent header file names :(
Let's do the submodules next, I know cereal has a few too.


add roundnumber to the claim/commit/reveal events

we have this in commit and reveal, but not in claim.  Should we add event that sends round number in claim function and what is the reason for that?


invocationManager is cached by nodejs' require cache and prevent multiple client

Description
I'm facing an issue where I can't have multiple detox clients that handle multiple simulators, like :
const Detox = require('detox/src/Detox');
const firstDetox = new Detox({ deviceConfig });
const otherDetox = new Detox({ deviceConfig: { ...deviceConfig, name: 'iPhone 7' } });

But in the driver, the expect.js file is required directly and so the invocationManager is cached for all the subsequent calls and it will be overridden. This is due to the nodejs require caching mechanism.
So if you have 2 clients, the invocationManager will be the same for both and be set from the last one and so will only run in the second device.
Proposition
Encapsulate the expect module in a function lilke :
module.exports = function() {
  let invocationManager;
  function setInvocationManager(im) {
    invocationManager = im;
  }
  // ....
  return {
    setInvocationManager,
    //...
  };
};

And in the driver :
+ const configureExpect = require('../../ios/expect');
// ...

- this.expect = require('../../ios/expect');
+ this.expect = configureExpect();

This way the invocationManager will not be cached and each driver will have it own invocationManager.
Regards,
Emmanuel

Resolved by #1378 .


[TEST] Flaky test case in topi

http://ci.tvm.ai:8080/blue/rest/organizations/jenkins/pipelines/tvm/branches/PR-2531/runs/7/nodes/235/steps/276/log/?start=0

Perhaps was due to float near 0.5 and different rounding on device types, need to modify PRNG to avoid such case

#2557


When can I start to use the new version of Matchzoo?

I'm interested in the development progress. @faneshion @pl8787
I've read the ipython notebook, seems it's much simpler to use.

We are working on version 2.0. It will be released ASAP.


Support constant extension for android and iOS

#In react-native, we have getConstants to expose a map to js:
  @Override
  public Map<String, Object> getConstants() {
    final Map<String, Object> constants = new HashMap<>();
    constants.put(DURATION_SHORT_KEY, Toast.LENGTH_SHORT);
    constants.put(DURATION_LONG_KEY, Toast.LENGTH_LONG);
    return constants;
  }

So that js can access those constants directly without a promise. However in weex, registerModule can only do this with a callback. This is really useful if the common configs are on native side.
For more details, please refer: http://facebook.github.io/react-native/docs/native-modules-android.html

The next release of WeexSDK will support return value from a native module method call, also without Promise or callbacks.
Thanks.

@Jinjiang Thank you, looking forward to the next release


Cura crashes with empty data-set

Found a bug that seems to occur when thingiverse returns an empty dataset.
Steps to recreate:

Open Thingiverse extension
Select search field, press enter key
Cura crashes due to JSON error:
\ThingiverseService.py", line 155, in _onSearchFinished  self._things.extend(things) TypeError: 'JSONObject' object is not iterable

Cura Version: 4.1.0
ThingiBrowser Version: 1.1.1
Platform: Windows 10 10.0.17763
Qt version: 5.10.0

This was fixed in version 1.1.2 of the plugin. Thanks for reporting!


Code improvements

In this PR have added using 'std::make_shared' instead of reset call (why it's better you can read here). Also I have changed return value of Listener::bind methond because returning bool value looks obsolete.

Just one thought: right now Listener is using shared pointers but it seems that the transport is owned by the listener (as well as the reactor object that is using the transport as well). What about using unique_ptr for listener and just give a raw pointer to the reactor?


fix: MOON_COLOR number env not work

closes #787

@SoonIter How does it not work exactly?


Removing Vim Project from README

We won't be actively working on a vim plugin, at least for now, so we can just remove the info and links of that from the bottom of our README.md file.

Working on it. Please assign issue @mason-at-pieces

Fixed, check PR!


Support for elliptic curve cryptography

A while ago I asked about whether anyone was able to let prometheus scrape node exporter TLS endpoints with ECC certificates. Unfortunately, there was no answer. Thus, my assumption still is, that prometheus lacks support for curve crypto.
Proposal
I guess I don't need to explain the importance of modern cryptography and ECC is not even that new anymore. The underlying TLS lib in use by prometheus probably supports this with some adjustments. Prometheus is the only software in my infrastructure that forces me to use RSA yet for these endpoints.
I'd be glad to be told that I'm just holding it wrong.

the following cert I have created works for me:
$ cat example.com.crt
-----BEGIN CERTIFICATE-----
MIIBCDCBuwIUXY67fm5zNZIII3Uv0SZOZkURdwQwBQYDK2VwMCcxCzAJBgNVBAYT
AkRFMRgwFgYDVQQDDA93d3cuZXhhbXBsZS5jb20wHhcNMjIwMzAyMTYzMDAzWhcN
MjQwMTMxMTYzMDAzWjAnMQswCQYDVQQGEwJERTEYMBYGA1UEAwwPd3d3LmV4YW1w
bGUuY29tMCowBQYDK2VwAyEAYWl4d8WvzQledmpjH37I5Vtbuli5zJh7G9YByOBX
v7UwBQYDK2VwA0EA90RH/m+7gIwldcLx04zON472zhcNXbrgDuY1q6BjnFhEQCix
6TiXzfG/EEW2ZkzEhUWoVd0VHrdufJ6xVBpnDQ==
-----END CERTIFICATE-----
$ openssl x509 -in example.com.crt -text
Certificate:
    Data:
        Version: 1 (0x0)
        Serial Number:
            5d:8e:bb:7e:6e:73:35:92:08:23:75:2f:d1:26:4e:66:45:11:77:04
        Signature Algorithm: ED25519
        Issuer: C = DE, CN = www.example.com
        Validity
            Not Before: Mar  2 16:30:03 2022 GMT
            Not After : Jan 31 16:30:03 2024 GMT
        Subject: C = DE, CN = www.example.com
        Subject Public Key Info:
            Public Key Algorithm: ED25519
                ED25519 Public-Key:
                pub:
                    61:69:78:77:c5:af:cd:09:5e:76:6a:63:1f:7e:c8:
                    e5:5b:5b:ba:58:b9:cc:98:7b:1b:d6:01:c8:e0:57:
                    bf:b5
    Signature Algorithm: ED25519
         f7:44:47:fe:6f:bb:80:8c:25:75:c2:f1:d3:8c:ce:37:8e:f6:
         ce:17:0d:5d:ba:e0:0e:e6:35:ab:a0:63:9c:58:44:40:28:b1:
         e9:38:97:cd:f1:bf:10:45:b6:66:4c:c4:85:45:a8:55:dd:15:
         1e:b7:6e:7c:9e:b1:54:1a:67:0d
-----BEGIN CERTIFICATE-----
MIIBCDCBuwIUXY67fm5zNZIII3Uv0SZOZkURdwQwBQYDK2VwMCcxCzAJBgNVBAYT
AkRFMRgwFgYDVQQDDA93d3cuZXhhbXBsZS5jb20wHhcNMjIwMzAyMTYzMDAzWhcN
MjQwMTMxMTYzMDAzWjAnMQswCQYDVQQGEwJERTEYMBYGA1UEAwwPd3d3LmV4YW1w
bGUuY29tMCowBQYDK2VwAyEAYWl4d8WvzQledmpjH37I5Vtbuli5zJh7G9YByOBX
v7UwBQYDK2VwA0EA90RH/m+7gIwldcLx04zON472zhcNXbrgDuY1q6BjnFhEQCix
6TiXzfG/EEW2ZkzEhUWoVd0VHrdufJ6xVBpnDQ==
-----END CERTIFICATE-----

Thank you for your feedback! I realized I need to make a minimal reproducible example and while doing it I almost thought I cannot reproduce it because what I did at first was directly mounting the certificate (one like you showed) and it indeed worked. The config attribute of prometheus is named ca_file though and when I use it for that, i.e. passing a CA that has issued the curve certificate, I run into the problem I described. Please have a look: https://github.com/tumbl3w33d/prometheus-ecc

Please see: https://go.dev/play/p/OPD6rxnJGPo
It seems that your certificate is rejected by the golang library we are using:
x509: unsupported elliptic curve

We don't receive the info as we use high-level functions, that do not return such errors.

I see. I guess this can be closed then and in case anyone encounters a similar problem they will get your hint as well. I'll go evaluate curves. secp384r1 works, for example.

Thank you !


Fix keyword arguments in loop_in_executor

Hi @AnderRV
The current async implementation doesn't work properly when using keywords arguments.
functools.partial should be used to send the kwargs.

Merge in PR #3


[Feature Request] Follow windows light/dark theme

Is your feature request related to a problem? Please describe.
I can only choose either light or dark theme.
Describe the solution you'd like
It would be nice to set the theme to automatic so that it follows with the Windows light/dark theme

A new version (1.17) has been submitted, adding a new "System" option to the theme setting which follows the browser's preferred color scheme. This version is now available on Mozilla and will be on Chrome in the coming days.


create design system for feedback form

Need to improve this component on \<Component name>\src\<File Name.html>
Improvements required :
Any reference image?
Any external reference?
You can checkout this one for better understanding.

assign me @Rajdip019 @rupsha014

@Tushar98644 go ahead


'stdlib.h' file not found, an Mac OS Catalina 10.15

Yeah so everything broke when updating to the Catalina version. Any news about this?

I'm sorry to hear that! 😦
I don't have any news, unfortunately. I haven't touched this code in several years, and am not currently in a place to devote time to debugging (I'm not a C++ dev., so debugging this is a slow process for me).
With that said, if you, or anyone else reading this, gathers some info. and opens a Pull Request, I'd gladly welcome that! In the meantime, I'm sorry not to be able to offer something more concrete towards resolving this issue you brought up.


Parse array types (including multi-dimensional)

Array types should be parsed:
x: []int = ...;

As well as multi-dimensional array types:
y: [][][]int = ...;

Also array sizes should be support (as an expression, not a literal), for instance:
mut x: [32]int;

Done.


[documentation]  replace old helm contents and replace it with new apache/pulsar-helm-chart in website

We have repo https://github.com/apache/pulsar-helm-chart for the latest Pulsar-helm-chart, but the docs in website: http://pulsar.apache.org/docs/en/helm-overview/ still using the old link:
git clone https://github.com/apache/pulsar
cd deployment/kubernetes/helm

we should search and replace the old helm contents and replace it with new https://github.com/apache/pulsar-helm-chart in the website

I would like to work on this issue.

@jiazhai what is the old repo that I have to look for to replace?


Pass repo to docs build script, to fix validate_docs on forked PRs

Currently CI will fail on forked repos, since the docs repo build script always tries to clone from tigerbeetledb/tigerbeetle. Pass in the repo from CI, if it's set, to fix this.
Requires a matching PR in the docs repo - https://github.com/tigerbeetledb/docs/pull/5

@eatonphil I also do recall you mentioning you'd like to do a similar setup for the docs as for the go repo - namely we have everything in here, and push the built result via CI to tigerbeetledb/docs?

bors r+

@eatonphil I also do recall you mentioning you'd like to do a similar setup for the docs as for the go repo - namely we have everything in here, and push the built result via CI to tigerbeetledb/docs?

Yup that would be great!

bors retry

The bors failure was from me forgetting a shell $ - but looks like this didn't fix the problem because I was referencing the target repo. Oops - will fix that

bors r+


GANet2 and GANet7

Hi,I want to verify the results in the text,but I want to know the reult of GANet2 or GANet7  was directly taking the corresponding output on GANet15?Or it needs to be trained separately with its own error?
Another thing I am more curious about is that GANet has very good generalization capabilities, what is the key to the perfect performance? SGA layer or LGA layer?

Need to retrain these different models.
How do you measure the generalization ability? I didn’t test it and was not sure about  the generalization abilities. Did you test the model on other dataset?

Need to retrain these different models.
How do you measure the generalization ability? I didn’t test it and was not sure about  the generalization abilities. Did you test the model on other dataset?

Yes, I test the model on MiddleBurry dataset with the model sceneflow_epoch_10.pth.Moreover，I get some passive images pairs through Intel D435,and the GANet Deep produce nice disparity maps.

Yes, I test the model on MiddleBurry dataset with the model sceneflow_epoch_10.pth.Moreover，I get some passive images pairs through Intel D435,and the GANet Deep produce nice disparity maps.

I did some comparisons these days. Model trained on sceneflow dataset also generalize better on KITTI compared with others. I found it's mainly related with the SGA layer. SGA is a differentiable SGM and seems to be able to improve the model's generalization ability. I will add some analysis and update the arxiv paper. Thank you so much for help pointing out such an advantage!!!


Don't allow users to join group without accepting its terms.

@akatsoulas r?

Reminder: if PR #1250 is merged first, then the migration here needs update and vice versa.

@akatsoulas PR updated after #1268

Probably you need to update the has_member method in the groups/models.py to include the has_terms flag.

What happens regarding the acceptance of terms, if exist, for the creators of a group?

PR updated

Group creator accepts terms directly when creating a group
I added some more tests

You are missing a migration here. Please amend the changes in the 0006 migration.

Should this functionality be available only for groups that require approval to join or every group?

Right after a request to join a group, I am redirected to a page to accept/decline the group terms. This page should only be displayed right after the curator has accepted my request.

This functionality should be required for every group with terms not only those requiring request.

Right after a request to join a group, I am redirected to a page to accept/decline the group terms. This page should only be displayed right after the curator has accepted my request.

This was the initial implementation but I changed it. It makes sense though to be that way.

PR updated:

Code styling changes
Review terms page is only shown to GroupMembership.MEMBER.

@akatsoulas PR updated

Replaced terms_accepted with a new state in GroupMembership.status
Various minor fixes

You should update the pending_member_count in admin.py to include members that haven't yet accepted the terms of a group.

Probably, the get_annotated_groups method in users/models.py needs a small update too.

@akatsoulas PR updated

r+wc :beers:


Windows Server 2016 Download Error

Operating System Version: Windows Server 2016 14393
Deploying via (VirtualBox/VMWare/AWS/Azure/ESXi): VirtualBox
Vagrant Version (if applicable): 2.2.9

Description of the issue:
I getting error message while run build.ps1 with virtualbox keyword but when I changed checksum variable to None on box packerfile. I don't getting any error.
I think getting error therefore download link.
Download link example:
https://software-download.microsoft.com/download/pr/Windows_Server_2016_Datacenter_EVAL_en-us_14393_refresh.ISO?checksum=xxxxxx

Error:
Connection reset by peer(From Microsoft)

You should change "iso_checksum": "xxxx" to "iso_checksum": "none", variable in variable section on packer json file.
I don't have log

It sounds like your internet connection may be unstable if you're getting connection resets from Microsoft.
The iso_checksum value exists to ensure that the integrity of the downloaded ISO is intact and hasn't been corrupted or modified. Feel free to change this value on your own repo, but it doesn't make sense to do this for everyone.


Why no GPL licenses?

In the guidelines I found the following:
Licensing

All community templates are published under the MIT license. Third-party licenses, even the compatible ones (for example, GPL v2/v3) are not accepted.

Furthermore, the repo is under MIT, but Zabbix itself is under GPL. I can't quite understand this step backwards in licensing.
Would it be possible to offer another repo for GPL licensed community templates?
I would love to help the community with my templates, but then also under the condition that my contribution remains free.

This decision was made by the leadership.

I find that unfortunate but thanks for the open feedback. Would it be possible then to offer another repo for such things under [AL]GPL?
I think it is better if the Zabbix makers offer something like this than just trying to do it.


[Enhancement] DSPModSave - Notify for missing mods

In the game Desynced, the game will show the difference of mods used in the save and the current use mods.

So I wonder if DSPModSave should give a notification when there are mods with data that are not currently active. Because  DSPModSave doesn't save mod data of the inactive mods, the data will be clear after the next saving.
I ask this because some players accidentally disabled LossyCompression and lost the shell data.
Do you think it's worth adding a warning, or that's too annoying for the normal players?
Also, will CommonAPI/DSPModSave/LDBTool still be maintained after the battle update?

It all will very much depend on how significatly the devs have changed the game. Judjing from how much time has passed, I would be a lot.

Understand.
Would you accept PR for those mods in the future?
I can try to help fix DSPModSave if it breaks.

Of course. Unfortunately though my repos for my main mods (IE blueprinttweaks) are not setup for PR’s, but I’m willing to accept help fixing them.
Last, but not least, I will also be looking at updating them myself too in my free time.

@starfi5h What is the reason you closed the issue? I haven't yet got to looking at this.

sorry, I thought the info in the log was considered done


Installing Crackmapexec corrupts OS

Steps to reproduce

Tried to install crackmapexec in ubuntu via the apt repository
. After the installation of cme and crackmapexec the operating system corrupts and gives me an error "Failed to start load Apparmor profiles".

Command string used -- sudo apt install cme and

sudo apt install crackmapexec
CME verbose output (using the --verbose flag)
CME Version (cme --version) -- cme (App::Cme) version 1.032 (/usr/bin/cme)
OS -- VERSION="20.04.2 LTS
Detailed issue explanation:
I am using ubuntu for learning pentest. I tried to install crackmapexec and cme vial the apt repository which was successful with few warning when i tried to initiate the crackmapexec command. After sometime I got the authentication error due to which i restarted the guest and after which i am getting an error as "Failed to start load Apparmor profiles". I am not sure if i am doing anything wrong.

Apparmor has nothing to do with cme, you must have done something else ;)

Nope i restored the previous snapshot and did install sudo apt install but the OS failed all the times...


CacheProvider interface

Description
Fixes #28 so custom cache providers have a clean interface.
Checklist:

Issue Addressed: [x]
Link to SAML spec: [n/a]
Tests included? [n/a]
Documentation updated? [x]

@barryhagan My impression is that this is a rarely used feature and developers seem to generally on board with moving from callback interfaces to promises. We could support both interfaces during a transition, but it's a also pretty quick refactor if developers do need to adapt their callback code to promises. Shims like Bluebird's asCallback() can help with that.


Chown backup dir once gitlab installed

thx dude

Build in progress: https://travis-ci.org/scaleway/qa/builds/93569787


Added Employee Management Project

Employee Management Project using C language.
Please review and merge the PR and consider it under hacktoberfest..

completed #26


fix: add unique id to definitions

You are not able to run multiple instances on the same time, because they all take the same value of the last id #g,
This fix ensures that each instance has a fresh id, allowing multiple avatars on the same page

Codecov Report

Merging #6 (49274e2) into master (9c8c98e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           12        14    +2
=========================================
+ Hits            12        14    +2

Impacted Files
Coverage Δ

index.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c8c98e...49274e2. Read the comment docs.

Thanks for the fix!


Nodelay

Second approach to solve nodelay issue

I'm finished.
Regular response and file uploading uses TCP_CORK to push all data in a single packet.
Streaming response and websocket use TCP_NODELAY to minimize latency.
Flow can be controlled by set_tcp_nodelay() and set_tcp_cork() calls. tcp_nodelay and tcp_cork states are mutually exclusive, case with neither nodelay nor cork is possible also (current aiohttp works exactly under this case).
I'll merge PR tomorrow. The only thing left is documentation.

Is stream uncorked after writing last byte of response while in keep-alive mode ?

Also, same technique should be applied to http client when it writes http request.

I remember interesting technique in streaming over http and using chunked data. This cover not only EvenrSource http://www.w3schools.com/html/html5_serversentevents.asp but also videostreaming.
I mean that in these cases each chunk of chunked response contains complete data that should be delivered to browserwith minimal delay. Even when delay between chunks are long. So, in current implemntation, user should uncork manually after sending chunk and cork again before sending chunk. Does not it ? If yes, please document that example.
Also for websockets. Library should cork before sending frame and uncork afer sending. Is it so ?
Sorry, but code slightly complicated for me.


Document Wire Protocol

net_doc_wire_protocol
Document the initial design of the versioning, serialisation, framing and multiplexing for the protocol
Also includes the documentation for each mini protocol, including state transitions, prose descriptions and message serialisation formats.
This will be an addition to the general network design document in the github repo.
The definition of done for this work package is document review and sign-off from a majority of the document authors.

The first part is finished.

This will be an addition to the general network design document in the github repo.

It is unclear which documents are meant here.
The work can be found in ouroboros-network/doc/network.tex.

That's perfect, thanks @MarcFontaine.

So what's left is to do review the the documentation, right?


Add lnurl-auth input checkbox to allowance menu

Linked to #148, I have started this PR but it still needs work. Me and @bumi are working on this together. I have added the input checkbox element to the allowances menus. I have just done this initial work so far and haven't looked at hooking it up yet. It will be something like <input type="checkbox" id="lnurl-auth" name="lnurl-auth" checked={lnurlAuth ? checked : ""}/>. And we will have to add an onclick to change the lnurlAuth which I think is a boolean. Thanks for helping with this bumi!
Screenshot:

@secondl1ght We have a  component in the Form folder that you can use.

Awesome thanks, I've updated this to use the nice checkbox component with Alby styles.

wanna try to add the logic to save that value?
you can actually just hook into how the saving of the budget is currently done.

Ok I gave it a try, I am still getting a type error but I just pushed it anyway so that you could see it and I can fix that later if I am on the right track. Just let me know if what I did here is correct or not, I tried to follow what was already set up for the budget. But it is likely that there is still some work to be done here (maybe I am close?). Thanks!

I think @secondl1ght you could pick this up again and try if you now get it working

Closing in favour of #1539


Add name spacing for different repos

Thanks! The one that we were debating I've already resolved. I'll take a look at the issue you're seeing.

@Morganamilo I think that the rebase re-introduced this line - you just need to get rid of that.

Should be good now. Thanks for finding that. Never would have alone.

Thanks for your work on this @Morganamilo - it's now live at https://test-observability.herokuapp.com/repos.


how much memory in your machine?

it looks stuck on the 16G memory while run 'preprocess_partial_ner/save_emb.py'

It's pretty large. Over 200GB. You can do some filtering before you run the save_emb. For some of the words, they never occur in the corpus.

200G mem?it looks terrible, maybe me we just need a light version

Sorry for the confusion, our server has over 200 GB memory, but i think such large memory usage is not necessary.
That script is mainly designed for the pre-saving the word-embedding. As you may notice, the pre-trained embedding file is pretty large, and a large memory consumption is expected.
But definitely, we will also release a light version later!


Graph data is not loading

Ive been looking into a postgres monitoring solution and invested a few hours into OPM. I can log in to the UI and can see the servers and their services, but the graphs for the services are blank for both check_pgactivity services and also for the standard nagios services. Nagios has been running for a while so there should be something to see.
I can see that the check_pgactivity services are running and returning data through nagios.
The perfdata files are being generated and none of the logs are showing errors. I've tried different web browsers but no luck.
Version details:
OPM 2.3
Nagios 4.2.0
Centos7
example of what I see:

Hello,
Do you see any javascript error in your browser?  The console can be displayed with F12, at least on firefox and chrome.

Hey, turns out this was just an issue with the VM I was using having the wrong time. I was looking for data using my local time through the UI when I should have been looking for a couple days prior. Apologies!


new folder structure - packaging, setup.py, empty tox

I've changed project structure to separate dockerfile, sourcefiles, test, ...

@krak3n @peeklondon CR please.

Why do we need to move files to src dir?

Because root dir gets messy with all files like - readme, licence, circle, dockerfile, ... and i prefer to keep source files out of all those files. It could be just flask_hal but then you have nested tests inside that dir..

IMO I don't think putting things a src dir solves anything other than hiding stuff away into another dir. Either way source files will still won't be in the root anyway other than setup.py, which really should be in the root so it can be easily pip / easy_install installable.
The dir structure should really follow normal Python conventions unless there is a build requirement for it to live in a src or lib dir.
I just think it makes the project harder to work with.
- docs
  - ...
- module
  - __init__.py
  - ...
- tests
  - __init__.py
  - ...
- README.md
- setup.py

@krak3n  I've put project structure back.
I've added circle config to run tests in tox..

Thanks :+1:


migration in version 0.7 can not detect Mysql Derive

Description
In my new project. I uisng migration to manage my database model. but when I register all model to Migrator  and runing
sea-orm-cli migrate up. it report error
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Conn("The connection string 'mysql://root:lib_pwd@localhost:3306/lib_db' has no supporting driver.")'

in another project witch uisng 0.6 of seaOrm can migration successfully
Steps to Reproduce

prepare migration and add to Migrator
runing sea-orm-cli migrate up
it report that error

Expected Behavior
apply migrate
Actual Behavior
report Error
has no supporting driver.
Reproduces How Often
100% happen in new project
never happen in another old project,but when update sea-schema to 0.7 same problem happen
Versions
mysql :  Ver 8.0.28 for Win64 on x86_64 (MySQL Community Server - GPL)
dependence in migration crate
[dependencies]
sea-schema = { version = "0.7.1", default-features = false, features = [
    "migration",
    "debug-print",
] }

rustc version rustc 1.62.0-nightly (1f7fb6413 2022-04-10)
Additional Information
it seems the error is from here
https://github.com/SeaQL/sea-orm/blob/master/src/database/mod.rs#L71
when I write migrate in the start up in project , It can successfully connect to database and appling migrates
fn main() {
    let rt = tokio::runtime::Runtime::new().expect("StartUp Runtime Failure");

    rt.block_on(async {
        let conn = sea_orm::Database::connect("mysql://root:lib_pwd@localhost:3306/lib_db")
            .await
            .expect("Db Lose");

        migration::Migrator::up(&conn, None).await;

       // ...
    })
}

but when I copy the same code to the main.rs in migration , It do not work
#[async_std::main]
async fn main() {
    // cli::run_cli(Migrator).await;
    let conn = sea_orm::Database::connect("mysql://root:lib_pwd@localhost:3306/lib_db")
        .await
        .expect("Db Lose");

    Migrator::up(&conn, None).await;
}

through the source code https://github.com/SeaQL/sea-orm/blob/master/src/database/mod.rs#L56， I think the match can reach here if and only if Enable the sqlx-mysql feature,but in the cargo.toml it only enable sea-orm marco feature and disable default feature. thus can cause has no supporting driver

https://github.com/Goodjooy/sea-schema/commit/67dc5e31d5f5e7c8e50ca108896ce04ca65c39e7
I am try to fix the problem
but I do not known wether is the best or not : (

entity/Cargo.toml
[dependencies]
sea-orm = { version = "0.7.1", default-features = false, features = ["macros", "sqlx", "sqlx-sqlite", "sqlx-mysql", "sqlx-postgres", "runtime-tokio-native-tls", "debug-print"] }

do you mean add that to the migration crate in my project?

Hey @Goodjooy, I don't think this is a bug. You need to add sqlx-mysql feature to your sea-orm dependency in Cargo.toml

Hey @Goodjooy, I don't think this is a bug. You need to add sqlx-mysql feature to your sea-orm dependency in Cargo.toml

I have a bit understand why the same code can work in my old porject but can not work in that
in that old project. The dependence of migration is
[dependencies]
sea-schema = { version = "0.5.0", default-features = false, features = [ "migration", "debug-print" ] }

db-entity={path="../libs/db-entity"}

where db-entity is another crate setting all database model of sea-orm where the sqlx-mysql feature is enabled. when the migration see db-entity as dependence. the db-entity config of sea-orm will influence the feature flag of sea-orm in sea-schema, thus it can conncet to my database

I adding the crate holding my database models to migration dependence. It work as expect :)

I admit it's quite confusing. Perhaps we can somehow highlight this in our docs? Any suggestions?

I admit it's quite confusing. Perhaps we can somehow highlight this in our docs? Any suggestions?

maybe you can add features like migrate-mysql to enable sea-orm\sqlx-mysql  to select the database Derive directly?
And adding features migrate-rustls and migrate-native-tls to select the tls?
migrate has it own async-std thus not need to select async runtime

when adding dependence, user can either using feature flag or introduce the "enity" crate
"
If you are not going to add entity into dependences you can using feature flag migrate-<DATABASE> and migrate- <TLS_LIB> of sea-schema
NOTE: you MUST use either adding entity into dependence or adding feature flag migrate-<DATABASE> and migrate- <TLS_LIB> of sea-schema
"
like this ^ ?
English is not my mother tongue ， there may have some wrong : (

Conversation continue on SeaQL/sea-schema#63


v3 Demos MultiRTC: Skype-like app

Chrome (version 62) does not work with share screen (firefox works). The console lists the error ({name: "NotReadableError", message: ", constraint:", toString: ƒ} constraint: "message:" "name:" NotReadableError "toString: , video: {...}, isScreen: true})
Multiwebtc v2 worked.

fixed.
https://github.com/muaz-khan/RTCMultiConnection/commit/55168d0e6029f9512e5e3fe80693d217e31bdeb4


Improve handling of comments and doc comments

Doc comments are now properly formatted with gq and J. For example,
on this input text:
/// one
/// two

pressing J on the top line used to result in /// one / two, and now
results in /// one two. Conversely, on this input text:
/// this long line exceeds the text width

pressing gqgq with a textwidth of 20 now yields:
/// this long line
/// exceeds the text
/// width

instead of:
/// this long line
//exceeds the text
//width

Furthermore, adding a new line to an existing comment, by pressing o
in normal mode or Enter in insert mode, now automatically inserts the
appropriate comment leader (// or ///).
wchargin-branch: comment-doc-and-leader

@wchargin how about also accommodating the /**.. **/ natspec style? ;)

@wchargin how about also accommodating the /**.. **/ natspec style? ;)

Go for it! I personally don't use that natspec style and am not super
familiar with this corner of Vim config, so I'm not going to implement
this myself.

Hey @wchargin, I merged this PR in our maintained fork!


Fix callbacks still being called after destroy()

Merely disconnecting the ScriptProcessorNode doesn't seem to be sufficient to stop it from processing further audio data (testing on Firefox 55).
The connect() function connects all nodes used, so this PR changes the disconnect() to also disconnect all nodes used.
Also, for good measure, to guarantee that absolutely no further events are emitted, the script processor's event handler is nulled when destroy() is called.

Thanks for contributing!


Development cache does not work when you build multiple css files

If you are building multiple css files, development caching does not work.
Your css will still be successfully processed, but it will take up to 3 seconds every build, even if you are only editing markdown files.

The converter uses the same object instance for every document, and the the converter is not passed the filename, only the content to convert.
I don't know if if this will be fixable. I might have to clarify that you can only have one stylesheet if you want caching to work 😐.

I'm having the same problem (20s builds instead of 1s) with multiple stylesheets. While I understand why there isn't a solution for this, is there a potential workaround?

I believe the work around is to not build multiple css files.

There is now a feature to disable the cache, this should solve this i think.


Support description

Codecov Report

Merging #302 into master will decrease coverage by 0.80%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #302      +/-   ##
============================================
- Coverage     95.53%   94.73%   -0.81%
  Complexity       21       21
============================================
  Files             7        6       -1
  Lines           269      171      -98
  Branches          8        8
============================================
- Hits            257      162      -95
+ Misses           10        8       -2
+ Partials          2        1       -1

Flag
Coverage Δ
Complexity Δ

#go
?
?

#java
96.42% <ø> (ø)
21.00 <ø> (ø)

#node_js
95.91% <ø> (ø)
0.00 <ø> (ø)

#python
92.42% <ø> (ø)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ
Complexity Δ

credential/golang/service/service.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230c4dd...274fd2f. Read the comment docs.


[Spotify Player] Pause with menu bar player, after time, reverts to "non-playing" mode

Extension
https://www.raycast.com/mattisssa/spotify-player
Description
Using menu bar player, I pause the currently playing song.  The Title and Artist still appear.  Over some period of time, however, it reverts to the non-playing state: just the Spotify icon, only options are to "Open Spotify" and play, next, previous, etc are all missing.  I see only "Nothing is playing right now".    I have not yet established the length of time, but appears to be within 5 minutes or so of non-playing.
The Spotify app is still active and ready to play, and pressing play in the app "awakens" the menu bar within 10 seconds or so.
Is there a timeout in the extension?
Steps To Reproduce
With latest "everything" (MacOS, Raycast, Extension, Spotify): verify that the menu bar shows an artist and title while Spotify is playing.
Pause the song, and see that the artist and name are still present, as is the full menu.
Do other things on the computer, walk away and come back, whatever.  Within 5 or so minutes, check again.   Upon unlocking, you will see just the spotify logo and the reduced dropdown menu.  (just Your Library, Search, Open Spotify)
Current Behaviour
Menu bar player reverts to "non-playing" status after the delay.
Expected Behaviour
While Spotify App is loaded, and a song is paused, the menu bar will always show the most recent song and the full controls dropdown.  I would expect to be able to pop back in at any time and unpause or skip to the next track, etc.

This is a limitation of the Spotify API. To my knowledge, there isn't any "fix" for this.
After a certain amount of time, responses from the Spotify API just don't contain data about the "currently playing" song, or rather, the song that was just played a few minutes ago.

That would be frustrating.  I wonder, though: there appear to be two ways to get the currently playing track: /me/player/currently-playing and /me/player/queue.  Even if it's not currently active, I'd expect the second to return some info every time.  I totally get that the first one may just timeout.  Or are you suggesting that, in fact, the API just stops returning "any" data of use?
I haven't tested any of this yet, just wondering if there's an alternate path to get to the info with some assumptions (like the top of the queue would be the same as the most recently played song; that may not be true).

Or are you suggesting that, in fact, the API just stops returning "any" data of use?

I just tested this:
After exactly 10 minutes of music being paused, they all stop returning useful data.

/me/player/currently-playing returns an empty response
/me/player returns an empty response
/me/player/devices returns the devices correctly
/me/player/queue returns { "currently_playing" : null, "queue" : [ ] }

an alternate path to get to the info

Applescript is an option, and I believe is was considered before

top of the queue

queue wouldn't work, as it returns no useful info. But, recently played tracks would work

I need to do some digging, but we've been having loads of issues with the API being rate-limited. I might have to rely on AppleScript more often, which is a shame. I liked the simplicity of relying on the API.
As you can probably tell, I've not had much time in the last couple of months to address the issues, but I'll put more effort in the next few days.

To avoid the stale indicator, just checking: has any progress been made on this one?

Just catching up with this. This is actually done on purpose 😄 This is the code

When I initially built this, I had it so it wouldn't clear. But then you'll permanently have the paused song there. However, I noticed that even the Spotify Client will clear paused songs after some time.
What we could do here though, is change from 10 mins to something longer. Thoughts?

IMO, ten minutes seems like a long time but really isn't.  In the big scheme of things, I'll pause the music for a task (standup, meeting, 1:1) which will almost always be longer than 10 minutes, then desire to pick back up with the music from the taskbar.
So, if we feel this feature of "clearing the pause" is useful, the perfect ask is to let folks enter the number of minutes as a config or setting.  And the default could be 2 hours, which accounts for a pause for a meeting or other experience, and then gives time to get back into the music.
I haven't seen a time frame for the Spotify Client to pause on MacOS, but I'll keep an eye out.

Yeah, makes sense. I think I'd prefer to avoid adding even more preferences, so happy to change the default to 2 hours and see how it feels. PR Created


Adopt Black auto code formatter

In the past I've avoided using "uncompromising code formatters" and I've preferred some flexibility in style, but I think it would be helpful in OpenCDMS where we are expecting to serve a wide audience.
I suggest we adopt black for automatic code formatting for the following reasons:

It has achieved wide spread adoption and is now a project of the Python Software Foundation
It has been adopted by some of our code dependencies, e.g. see SQLAlchemy dev docs and Pandas dev docs

It would remove the need for # noqa comments (instead we just accept Black's formatting) and it would automatically take care of conventions like adding a trailing comma to lists -- so we won't have to worry about conventions like this in code reviews.

@david-i-berry @chinedu117
⚠ I've moved the original version of pyopencdms to https://github.com/opencdms-dev  ⚠
The original version has code that is used by climsoft-api and also has other features like example pygeoapi providers for Climsoft and SURFACE.
There is now a new cleaned up version of pyopencdms at https://github.com/opencdms/pyopencdms  -- everything in this new repository will be built around the Climate Data Model.
The new repo is now using black for automated code formatting.


dagster connector: None fails ingestion

<IP_ADDRESS>
The above exception was caused by the following exception:
TypeError: 'NoneType' object is not iterable
  File "/dagster/_core/execution/plan/utils.py", line 54, in op_execution_error_boundary
    yield
  File "/dagster/_utils/__init__.py", line 445, in iterate_with_context
    next_output = next(iterator)
  File "/dagster/_core/execution/plan/compute_generator.py", line 124, in _coerce_op_compute_fn_to_iterator
    result = invoke_compute_fn(
  File "/dagster/_core/execution/plan/compute_generator.py", line 118, in invoke_compute_fn
    return fn(context, **args_to_pass) if context_arg_provided else fn(**args_to_pass)
  File "/ops/open_metadata.py", line 174, in dagster_meta_lineage
    om_workflow_factory(context, workflow_config, is_profiler=False)
  File "/ops/open_metadata.py", line 87, in om_workflow_factory
    workflow.execute()
  File "/metadata/ingestion/api/workflow.py", line 215, in execute
    raise err
  File "/metadata/ingestion/api/workflow.py", line 196, in execute
    for record in self.source.next_record():
  File "/metadata/ingestion/api/topology_runner.py", line 132, in next_record
    yield from self.process_nodes(get_topology_root(self.topology))
  File "/metadata/ingestion/api/topology_runner.py", line 98, in process_nodes
    yield from self.process_nodes(child_nodes)
  File "/metadata/ingestion/api/topology_runner.py", line 75, in process_nodes
    for element in node_producer() or []:
  File "/metadata/ingestion/source/pipeline/pipeline_service.py", line 214, in get_pipeline
    for pipeline_detail in self.get_pipelines_list():
  File "/metadata/ingestion/source/pipeline/dagster/metadata.py", line 217, in get_pipelines_list
    for result in results:

a re-rececution seems to work a couple of hours later.

Since re-executing works, looks like it might be a weird response coming from Dagster itself. In any case, we should handle better these responses and not die on the execution (and just skip whatever information is not being retrieved)

@pmbrull this was failing in the 1st step while retrieving the pipeline information itself so nothing else can be processed after that


Support table_collection_expression in DELETE, INSERT, SELECT and UPDATE.

Grammar changes:
collection_expression
table_coll_expr

table_coll_expr -> TABLE '(' collection_expression ')'             : {table_coll_expr, '$3', []}.
table_coll_expr -> TABLE '(' collection_expression ')' '(' '+' ')' : {table_coll_expr, '$3', '+'}.

collection_expression -> column_ref   : '$1'.
collection_expression -> function_ref : '$1'.
collection_expression -> subquery     : '$1'.

table_dblink -> table_coll_expr           : '$1'.

Reference: https://docs.oracle.com/en/database/oracle/oracle-database/18/sqlrf/sql-language-reference.pdf
page 15-200 DELETE
page 18-63  INSERT
page 18-40  SELECT
page 19-143 UPDATE
page 19-147 table_collection_expression & collection_expression

@stoch &  @c-bik: please comment.

@walter-weinmann

Can you please provide a diff style grammar rule changes in description?
Can you provide some SQL examples which these grammar rules will cover along with the proposed parse tree?


Combine all UI Code with CRA

Combine new work done in original directory with the new CRA directories. Need to freeze UI development in the meantime while this is done. @grahamwallis @davidradl

@dkneisly

update assembly/docker to match & test

@planetf1 can you expand on the assembly/docker piece?

The file in open-metadata-distribution/open-metadata-assemblies/src/main/assemblies/egeria-presentation-server.xml defines the files that are picked from the build directory to package up
So it may be as simple as changing directory names there
Then check open-metadata-distribution/open-metadata-assemblies/target/egeria-2.5-SNAPSHOT-presentation-server
has everything needed to launch the app.
We make use of this in the docker image in open-metadata-resources/open-metadata-deployment/docker/presentation-server/Dockerfile. (the actual assembly above is copied in the pom.xml initially into a subdirectory)
Basically we end up running node src/server/index.js to launch the app - so if the invocatino has to change, it's the Dockerfile we need to do that.
The docker image has docs on dockerhub  which I can update with any links/useful info for anyone running directly.
The docker image is then used in our helm charts & docker compose environments.
These are in open-metadata-resources/open-metadata-deployment/compose/tutorials and open-metadata-resources/open-metadata-deployment/charts/odpi-egeria-lab
The key things to note there are that we just run the container with the default command, and the only relevant environment variable we set is EGERIA_PRESENTATIONSERVER_SERVER_coco
If extra environment variables are needed, they will need modification in those two directories above.
This is important as if the docker build fails our entire merge build fails. This breaks other things, but mostly stops any image updates going to docker hub. (the image not working of course also might affect anyone using it)
We need to add automated testing of the images. sadly it's not in place yet

I have merged all the UI code under the new CRA directories and deleted the old directory. I'm going to focus on the build stuff @planetf1 highlighted above, then will create a PR. My assumption with the PR is each author will test their own sections to ensure they still operate as expected, given that manually merging/resolving conflicting code is an inexact science.

To give further context on the above, all the UI pages still load/look as I would expect, but I am relying on everyone else to test the detailed functionality of interacting with Egeria.


Keybase caused amdgpu to crash?

I left my computer for some hours, came back, and GNOME was unresponsive. I dropped to a shell, dumped dmesg, and noticed this:
[16554.972320] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx_0.0.0 timeout, signaled seq=40735, emitted seq=40738
[16554.972576] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* Process information: process Keybase pid 2980 thread Keybase:cs0 pid 2994
[16554.972826] amdgpu 0000:0c:00.0: amdgpu: GPU reset begin!
[16554.972846] amdgpu: Failed to suspend process 0x8004
[16555.283004] amdgpu 0000:0c:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring kiq_2.1.0 test failed (-110)
[16555.283122] [drm:gfx_v10_0_hw_fini [amdgpu]] *ERROR* KGQ disable failed
[16555.536298] amdgpu 0000:0c:00.0: [drm:amdgpu_ring_test_helper [amdgpu]] *ERROR* ring kiq_2.1.0 test failed (-110)
[16555.536412] [drm:gfx_v10_0_hw_fini [amdgpu]] *ERROR* KCQ disable failed
[16555.789601] [drm:gfx_v10_0_hw_fini [amdgpu]] *ERROR* failed to halt cp gfx
[16555.815611] [drm] free PSP TMR buffer
[16555.860482] amdgpu 0000:0c:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0012 address=0xeebcf82b200 flags=0x0010]
[16555.860493] amdgpu 0000:0c:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0012 address=0xeec4246d280 flags=0x0010]
[16555.860500] amdgpu 0000:0c:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0012 address=0xeeba5a4ba80 flags=0x0010]
[16555.860507] amdgpu 0000:0c:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0012 address=0xeecb5e73280 flags=0x0010]
[16555.860514] amdgpu 0000:0c:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x0012 address=0xeebc0043a00 flags=0x0010]

I'm not sure if the driver crashed from something unrelated and Keybase just happened to be the last thing trying to use it (was doing an OpenCL task in the background).

Fedora 36
RX 6600 XT

Had this happen again yesterday with the same amdgpu point to Keybase, and I suspect this has been happening for over a week or two now as I've had similar unexplained graphical crashing when I would come back after some hours idle.
I've removed Keybase from this computer for the time being and I'll report back if I get any similar crashing from something else.

No crashing whatsoever when Keybase isn't installed.
Reinstalled it and caught this in dmesg:
[11401.465658] usb 3-4: USB disconnect, device number 3
[17422.404205] gmc_v10_0_process_interrupt: 133 callbacks suppressed
[17422.404211] amdgpu 0000:0c:00.0: amdgpu: [gfxhub] page fault (src_id:0 ring:88 vmid:7 pasid:32770, for process Keybase pid 2813 thread Keybase:cs0 pid 2825)
[17422.404219] amdgpu 0000:0c:00.0: amdgpu:   in page starting at address 0x0000000000002000 from client 0x1b (UTCL2)
[17422.404222] amdgpu 0000:0c:00.0: amdgpu: GCVM_L2_PROTECTION_FAULT_STATUS:0x007012B1
[17422.404224] amdgpu 0000:0c:00.0: amdgpu: 	 Faulty UTCL2 client ID: SQC (inst) (0x9)
[17422.404226] amdgpu 0000:0c:00.0: amdgpu: 	 MORE_FAULTS: 0x1
[17422.404227] amdgpu 0000:0c:00.0: amdgpu: 	 WALKER_ERROR: 0x0
[17422.404229] amdgpu 0000:0c:00.0: amdgpu: 	 PERMISSION_FAULTS: 0xb
[17422.404230] amdgpu 0000:0c:00.0: amdgpu: 	 MAPPING_ERROR: 0x0
[17422.404231] amdgpu 0000:0c:00.0: amdgpu: 	 RW: 0x0
[17422.404238] amdgpu 0000:0c:00.0: amdgpu: [gfxhub] page fault (src_id:0 ring:88 vmid:7 pasid:32770, for process Keybase pid 2813 thread Keybase:cs0 pid 2825)
[17422.404241] amdgpu 0000:0c:00.0: amdgpu:   in page starting at address 0x0000000000002000 from client 0x1b (UTCL2)
[17422.404243] amdgpu 0000:0c:00.0: amdgpu: GCVM_L2_PROTECTION_FAULT_STATUS:0x00000000
[17422.404245] amdgpu 0000:0c:00.0: amdgpu: 	 Faulty UTCL2 client ID: CB/DB (0x0)
[17422.404246] amdgpu 0000:0c:00.0: amdgpu: 	 MORE_FAULTS: 0x0
[17422.404248] amdgpu 0000:0c:00.0: amdgpu: 	 WALKER_ERROR: 0x0
[17422.404249] amdgpu 0000:0c:00.0: amdgpu: 	 PERMISSION_FAULTS: 0x0
[17422.404250] amdgpu 0000:0c:00.0: amdgpu: 	 MAPPING_ERROR: 0x0
[17422.404251] amdgpu 0000:0c:00.0: amdgpu: 	 RW: 0x0
[17432.473607] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx_0.0.0 timeout, but soft recovered
[17432.473798] amdgpu 0000:0c:00.0: amdgpu: [gfxhub] page fault (src_id:0 ring:88 vmid:7 pasid:32770, for process Keybase pid 2813 thread Keybase:cs0 pid 2825)
[17432.473807] amdgpu 0000:0c:00.0: amdgpu:   in page starting at address 0x0000000000002000 from client 0x1b (UTCL2)
[17432.473810] amdgpu 0000:0c:00.0: amdgpu: GCVM_L2_PROTECTION_FAULT_STATUS:0x007012B1
[17432.473811] amdgpu 0000:0c:00.0: amdgpu: 	 Faulty UTCL2 client ID: SQC (inst) (0x9)
[17432.473813] amdgpu 0000:0c:00.0: amdgpu: 	 MORE_FAULTS: 0x1
[17432.473815] amdgpu 0000:0c:00.0: amdgpu: 	 WALKER_ERROR: 0x0
[17432.473816] amdgpu 0000:0c:00.0: amdgpu: 	 PERMISSION_FAULTS: 0xb
[17432.473817] amdgpu 0000:0c:00.0: amdgpu: 	 MAPPING_ERROR: 0x0
[17432.473818] amdgpu 0000:0c:00.0: amdgpu: 	 RW: 0x0
[17432.473822] amdgpu 0000:0c:00.0: amdgpu: [gfxhub] page fault (src_id:0 ring:88 vmid:7 pasid:32770, for process Keybase pid 2813 thread Keybase:cs0 pid 2825)
[17432.473825] amdgpu 0000:0c:00.0: amdgpu:   in page starting at address 0x0000000000002000 from client 0x1b (UTCL2)
[17432.473827] amdgpu 0000:0c:00.0: amdgpu: GCVM_L2_PROTECTION_FAULT_STATUS:0x00000000
[17432.473829] amdgpu 0000:0c:00.0: amdgpu: 	 Faulty UTCL2 client ID: CB/DB (0x0)
[17432.473830] amdgpu 0000:0c:00.0: amdgpu: 	 MORE_FAULTS: 0x0
[17432.473831] amdgpu 0000:0c:00.0: amdgpu: 	 WALKER_ERROR: 0x0
[17432.473832] amdgpu 0000:0c:00.0: amdgpu: 	 PERMISSION_FAULTS: 0x0
[17432.473833] amdgpu 0000:0c:00.0: amdgpu: 	 MAPPING_ERROR: 0x0
[17432.473834] amdgpu 0000:0c:00.0: amdgpu: 	 RW: 0x0
[17442.713397] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring gfx_0.0.0 timeout, but soft recovered

I can't imagine what Keybase is possibly doing in the background to be using GPU resources, but whatever it's doing is mishandled badly enough to crash the display driver (I can't even manage that with various RADV and AMD_DEBUG tests and games :p)
Keybase needs an option to disable GPU acceleration.

I haven't noticed any crashing with AMDGPU as of lately, so this looks to not be an issue anymore.
nvidia-smi -q also reports Keybase using GPU while in the background:
        GPU instance ID                   : N/A
        Compute instance ID               : N/A
        Process ID                        : 2709
            Type                          : G
            Name                          : /opt/keybase/Keybase --type=gpu-process --enable-crashpad --enable-crash-reporter=[redacted],no_channel --user-data-dir=/home/espionage724/.config/Keybase --gpu-preferences=[redacted] --shared-files --field-trial-handle=[redacted] --disable-features=PlzServiceWorker,SpareRendererForSitePerProcess
            Used GPU Memory               : 13 MiB

It didn't cause a driver crash, but caught this today:
[   28.005728] traps: Keybase[2853] general protection fault ip:7f1f26e777f4 sp:7fff4e05cff0 error:0 in radeonsi_drv_video.so[7f1f26e4f000+6cc000]
[   28.675291] traps: Keybase[2985] general protection fault ip:7f1f26e777f4 sp:7fff4e05cff0 error:0 in radeonsi_drv_video.so[7f1f26e4f000+6cc000]
[   29.265124] traps: Keybase[3021] general protection fault ip:7f1f26e777f4 sp:7fff4e05cff0 error:0 in radeonsi_drv_video.so[7f1f26e4f000+6cc000]


feat: create default cache when configuring profile

Do we want to show them that we are creating a cache from them? Or should we hide the logging

for some reason I am not able to transfer this issue over https://github.com/momentohq/dev-eco-issue-tracker/issues/38 to this repo

I think instead of create cache called - maybe we can change it to creating cache

What is the experience when create cache fails?

@bruuuuuuuce probably cuz it's a private => public repo. What happens if the cache name already exists?

@bruuuuuuuce probably cuz it's a private => public repo. What happens if the cache name already exists?

If the api call fails you will just see this

@bruuuuuuuce looks like the same screenshot?

@bruuuuuuuce looks like the same screenshot?

So if the cache creates successfully you will see
create cache called
created cache <name>

if it fails you will just see
create cache called

I honestly think it might be better to just not even show anything, but this was the simpler change so i put this up first.

| I honestly think it might be better to just not even show anything, but this was the simpler change so i put this up first.
I think it's definitely better to show nothing if the call fails - user will run into the error on the next get/set command, which is what happens now. Currently, the message is confusing to show - it makes me think it created it for me successfully

I would just show nothing at all then if were not going to show failures. we should not show that we are doing this or if it succeeds.
Maybe in CLI then on get and set we can handle Cache not found error and prompt them with command to create cache or even try to do it lazily for them if we detect first call fails.

Maybe in CLI then on get and set we can handle Cache not found error and prompt them with command to create cache

I like this, but we can do this in a separate PR as an improvement to handle cases where creates fails during momento configure

LGTM, added @poppoerika to review as well since this might conflict with her other PR after getting merged.

@bruuuuuuuce one more request:

When calling create cache, change message to creating cache..., as @mjindalmotiv8 suggested above.
After the call returns, either print default cache successfully created or default cache already exists depending on if the response was OK or not


Onboarding or scam?

I have recently received many messages from concerned people because now they see a home page that claims to be onboarding despite the fact that they are wallets that are not new and have already been used before.
is it a possible scam or is it a legitimate new screen?
why doesn't the same thing happen in brave browser?

Onboarding
it will show just once for all users, later just for new ones


ready callback doesn't fire if an integration is blocked or fails to load

If an integration fails to load or is blocked by an ad blocker then the ready callback never fires. The ready function should execute even if one or more integrations fail to load.

Currently, the ready function is all or nothing (just as documented). That said, I agree that the ability to denote when a certain integration has loaded and record failures is important to many applications, but since this has already been pointed out in #409, I'll close this issue in favor of that.