Commit-wise PR review shows at most 30 commits

Issue Description
Type: bug report
There is an spurious limit of 30 on the list of commits from a PR (at least on the commit-wise pr review list).
Describe what happened (or what feature you want)
When using :Octo review commit, the list of commits displayed has at most 30 entries. If the PR has more than 30 commits, only the 30 oldest commits are shown (+ the [[ENTIRE PULL REQUEST]] option with the last commit).
Describe what you expected to happen
Either all the commits of the PR are shown (optimal solution from my perspective), or a configuration should allow to fix a higher number of PR commits to consider, or the :Octo review commit accepts a commit sha.
How to reproduce it (as minimally and precisely as possible)

Call :Octo review commit on a PR with more than 30 commits

Tell us your environment
NVIM 0.10.0-dev inside WSL2
Anything else we need to know?
I believe the problem comes from the github api call. I am not fully familiar with Octo code, but after a quick search I think you get the list of commits from the /repos/{owner}/{repo}/pulls/{pull_number}/commits endpoint. The response is paginated with a default per_page equal to 30, which I think is what limits the displayed number of commits. One would need to either increase the per_page value (max accepted is 100) or iterate the pages for getting all the commits.

Same for Octo pr changes. Only 30 changes are visible on the panel.

Thanks for reporting, can you please check if the issue gets fixed with https://github.com/pwntester/octo.nvim/pull/475?

Just tried and while it works for :Octo pr commits, it does nothing when :Octo review commit. It doesn't yield any error message or anything.

Seems to be working for me, at least in PRs with less than 30 commits. Do you have any public PR at hand with more than 30 commits to try?

Yep. I'm trying with this one: https://github.com/AnimaBeyondDevelop/AnimaBeyondFoundry/pull/181

When I review that PR, Octo commit review shows the 118 commits:

Picking one it, it correctly shows the only 5 files changed in that commit:

Are you getting a different behavior?

I'm not getting anything after doing :Octo review commit. Not sure what to try to find the reason why... Just checking... Today I just updated plugins... Is your Telescope up to date with the master branch? I'm having other random issues with Telescope after the update...

I just updated telescope and fzf-lua, tried with both pickers and both of them show the lists of commits

How can I debug what's going on? Also, is something wrong with this config?
{
    "pwntester/octo.nvim",
    branch = "fix_459",
    dependencies = {
      "nvim-lua/plenary.nvim",
      "nvim-telescope/telescope.nvim",
      "nvim-tree/nvim-web-devicons",
    },
    config = function()
      require("octo").setup({
        enable_builtin = true,
        use_local_fs = true,
        mappings = {
          issue = {
            close_issue = { lhs = "<localleader>ic", desc = "close issue" },
            reopen_issue = { lhs = "<localleader>io", desc = "reopen issue" },
            list_issues = { lhs = "<localleader>il", desc = "list open issues on same repo" },
            reload = { lhs = "<C-r>", desc = "reload issue" },
            open_in_browser = { lhs = "<C-b>", desc = "open issue in browser" },
            copy_url = { lhs = "<C-y>", desc = "copy url to system clipboard" },
            add_assignee = { lhs = "<localleader>aa", desc = "add assignee" },
            remove_assignee = { lhs = "<localleader>ad", desc = "remove assignee" },
            create_label = { lhs = "<localleader>lc", desc = "create label" },
            add_label = { lhs = "<localleader>la", desc = "add label" },
            remove_label = { lhs = "<localleader>ld", desc = "remove label" },
            goto_issue = { lhs = "<localleader>gi", desc = "navigate to a local repo issue" },
            add_comment = { lhs = "<localleader>ca", desc = "add comment" },
            delete_comment = { lhs = "<localleader>cd", desc = "delete comment" },
            next_comment = { lhs = "<localleader>cj", desc = "go to next comment" },
            prev_comment = { lhs = "<localleader>ck", desc = "go to previous comment" },
            react_hooray = { lhs = "<localleader>rp", desc = "add/remove 🎉 reaction" },
            react_heart = { lhs = "<localleader>rh", desc = "add/remove ❤ reaction" },
            react_eyes = { lhs = "<localleader>re", desc = "add/remove 👀 reaction" },
            react_thumbs_up = { lhs = "<localleader>r+", desc = "add/remove 👍 reaction" },
            react_thumbs_down = { lhs = "<localleader>r-", desc = "add/remove 👎 reaction" },
            react_rocket = { lhs = "<localleader>rr", desc = "add/remove 🚀 reaction" },
            react_laugh = { lhs = "<localleader>rl", desc = "add/remove 😄 reaction" },
            react_confused = { lhs = "<localleader>rc", desc = "add/remove 😕 reaction" },
          },
          pull_request = {
            checkout_pr = { lhs = "<localleader>po", desc = "checkout PR" },
            merge_pr = { lhs = "<localleader>pm", desc = "merge commit PR" },
            squash_and_merge_pr = { lhs = "<localleader>psm", desc = "squash and merge PR" },
            list_commits = { lhs = "<localleader>pc", desc = "list PR commits" },
            list_changed_files = { lhs = "<localleader>pf", desc = "list PR changed files" },
            show_pr_diff = { lhs = "<localleader>pd", desc = "show PR diff" },
            add_reviewer = { lhs = "<localleader>va", desc = "add reviewer" },
            remove_reviewer = { lhs = "<localleader>vd", desc = "remove reviewer request" },
            close_issue = { lhs = "<localleader>ic", desc = "close PR" },
            reopen_issue = { lhs = "<localleader>io", desc = "reopen PR" },
            list_issues = { lhs = "<localleader>il", desc = "list open issues on same repo" },
            reload = { lhs = "<C-r>", desc = "reload PR" },
            open_in_browser = { lhs = "<C-b>", desc = "open PR in browser" },
            copy_url = { lhs = "<C-y>", desc = "copy url to system clipboard" },
            goto_file = { lhs = "gf", desc = "go to file" },
            add_assignee = { lhs = "<localleader>aa", desc = "add assignee" },
            remove_assignee = { lhs = "<localleader>ad", desc = "remove assignee" },
            create_label = { lhs = "<localleader>lc", desc = "create label" },
            add_label = { lhs = "<localleader>la", desc = "add label" },
            remove_label = { lhs = "<localleader>ld", desc = "remove label" },
            goto_issue = { lhs = "<localleader>gi", desc = "navigate to a local repo issue" },
            add_comment = { lhs = "<localleader>ca", desc = "add comment" },
            delete_comment = { lhs = "<localleader>cd", desc = "delete comment" },
            next_comment = { lhs = "<localleader>cj", desc = "go to next comment" },
            prev_comment = { lhs = "<localleader>ck", desc = "go to previous comment" },
            react_hooray = { lhs = "<localleader>rp", desc = "add/remove 🎉 reaction" },
            react_heart = { lhs = "<localleader>rh", desc = "add/remove ❤ reaction" },
            react_eyes = { lhs = "<localleader>re", desc = "add/remove 👀 reaction" },
            react_thumbs_up = { lhs = "<localleader>r+", desc = "add/remove 👍 reaction" },
            react_thumbs_down = { lhs = "<localleader>r-", desc = "add/remove 👎 reaction" },
            react_rocket = { lhs = "<localleader>rr", desc = "add/remove 🚀 reaction" },
            react_laugh = { lhs = "<localleader>rl", desc = "add/remove 😄 reaction" },
            react_confused = { lhs = "<localleader>rc", desc = "add/remove 😕 reaction" },
          },
          review_thread = {
            goto_issue = { lhs = "<localleader>gi", desc = "navigate to a local repo issue" },
            add_comment = { lhs = "<localleader>ca", desc = "add comment" },
            add_suggestion = { lhs = "<localleader>sa", desc = "add suggestion" },
            delete_comment = { lhs = "<localleader>cd", desc = "delete comment" },
            next_comment = { lhs = "<localleader>cj", desc = "go to next comment" },
            prev_comment = { lhs = "<localleader>ck", desc = "go to previous comment" },
            select_next_entry = { lhs = "<localleader>k", desc = "move to previous changed file" },
            select_prev_entry = { lhs = "<localleader>k", desc = "move to next changed file" },
            close_review_tab = { lhs = "<C-c>", desc = "close review tab" },
            react_hooray = { lhs = "<localleader>rp", desc = "add/remove 🎉 reaction" },
            react_heart = { lhs = "<localleader>rh", desc = "add/remove ❤ reaction" },
            react_eyes = { lhs = "<localleader>re", desc = "add/remove 👀 reaction" },
            react_thumbs_up = { lhs = "<localleader>r+", desc = "add/remove 👍 reaction" },
            react_thumbs_down = { lhs = "<localleader>r-", desc = "add/remove 👎 reaction" },
            react_rocket = { lhs = "<localleader>rr", desc = "add/remove 🚀 reaction" },
            react_laugh = { lhs = "<localleader>rl", desc = "add/remove 😄 reaction" },
            react_confused = { lhs = "<localleader>rc", desc = "add/remove 😕 reaction" },
          },
          submit_win = {
            approve_review = { lhs = "<C-a>", desc = "approve review" },
            comment_review = { lhs = "<C-m>", desc = "comment review" },
            request_changes = { lhs = "<C-r>", desc = "request changes review" },
            close_review_tab = { lhs = "<C-c>", desc = "close review tab" },
          },
          review_diff = {
            add_review_comment = { lhs = "<localleader>ca", desc = "add a new review comment" },
            add_review_suggestion = { lhs = "<localleader>sa", desc = "add a new review suggestion" },
            focus_files = { lhs = "<localleader>e", desc = "move focus to changed file panel" },
            toggle_files = { lhs = "<localleader>b", desc = "hide/show changed files panel" },
            next_thread = { lhs = "<localleader>tj", desc = "move to next thread" },
            prev_thread = { lhs = "<localleader>tk", desc = "move to previous thread" },
            select_next_entry = { lhs = "<localleader>j", desc = "move to previous changed file" },
            select_prev_entry = { lhs = "<localleader>k", desc = "move to next changed file" },
            close_review_tab = { lhs = "<C-c>", desc = "close review tab" },
            toggle_viewed = { lhs = "<localleader><localleader>", desc = "toggle viewer viewed state" },
            goto_file = { lhs = "gf", desc = "go to file" },
          },
          file_panel = {
            next_entry = { lhs = "j", desc = "move to next changed file" },
            prev_entry = { lhs = "k", desc = "move to previous changed file" },
            select_entry = { lhs = "<cr>", desc = "show selected changed file diffs" },
            refresh_files = { lhs = "R", desc = "refresh changed files panel" },
            focus_files = { lhs = "<localleader>e", desc = "move focus to changed file panel" },
            toggle_files = { lhs = "<localleader>b", desc = "hide/show changed files panel" },
            select_next_entry = { lhs = "<localleader>j", desc = "move to previous changed file" },
            select_prev_entry = { lhs = "<localleader>k", desc = "move to next changed file" },
            close_review_tab = { lhs = "<C-c>", desc = "close review tab" },
            toggle_viewed = { lhs = "<localleader><localleader>", desc = "toggle viewer viewed state" },
          },
        },
      })
      vim.cmd([[hi OctoEditable guibg=none]])
    end,
    keys = {
      { "<leader>o", "<cmd>Octo<cr>", desc = "Octo.nvim" },
    },
    cmd = { "Octo" },
  }

The config looks ok to me. Try adding some print statements to see where you get to:

https://github.com/pwntester/octo.nvim/blob/master/lua/octo/commands.lua#L196
https://github.com/pwntester/octo.nvim/blob/master/lua/octo/pickers/telescope/provider.lua#L374
https://github.com/pwntester/octo.nvim/blob/master/lua/octo/pickers/telescope/provider.lua#L385

Alright, I was just being dumb. Didn't realise I needed to start a review first. Somehow I expected :Octo review commit to start a new review, which it doesn't (and it makes sense it doesn't, although it might be worth it to add a warning for users in case someone else tries in the future).
I can confirm it does work as expected now and PR #475 appears to solve this issue.

Thanks, I have added some error messages in #475 to make it more clear.


add the filebrowser rock and tests

This PR adds:

filebrowser/rockcraft.yaml, which implements a rock for filebrowser
filebrowser/README.md with some notes and instructions for future maintenance
filebrowser/tox.ini and related sanity tests

Closes https://github.com/canonical/kubeflow-rocks/issues/72
Testing instructions:
cd filebrowser
tox -e pack
tox -e export-to-docker
docker run -p 8080:80 -e FB_ADDRESS=<IP_ADDRESS> filebrowser:v2.27.0
# Browse in a browser to `localhost:8080` and see the app

Hit a lot of issues while creating this rock.  They're documented in the rock and included README.md, but in summary the rock:

uses a few atypical build procedures (GoReleaser, and also its go build embeds the frontend into the application)
a healthcheck script and HEALTHCHECK directive in the dockerfile
needs somewhere with write access for a local db
needs a config file to define defaults to both the healthcheck and filebrowser binary
Charmed Kubeflow uses it via a controller we don't control, so we need to emulate the API of this image to make it a drop-in replacement of the upstream docker image.  This means putting files in consistent places and setting a default entrypoint-service


On Linux Add pdo_sqlsrv support

On Linux Add pdo_sqlsrv support
https://github.com/Microsoft/msphpsql/tree/PHP-7.0-Linux

It's now possible for Medoo 1.2 with customized DSN.


Langchain Milvus - Handle switch between multiple databases

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
If I try to do operations in different databases of the vectorstore, Milvus, it doesn't work until I disconnect all existing connections. Otherwise, it always does the operation in the connection of 0th index of the global connections object
Only this works:

# This block gets called multiple times for different databases

connections.disconnect("default")
connections.remove_connection("default")

connections.disconnect("db1")
connections.remove_connection("db1")

vectorstore = Milvus(
            self.embeddings,
            collection_name=collection_name,
            auto_id=True,
            connection_args={
                "user": self.user,
                "password": self.password,
                "host": self.host,
                "port": self.port,
                "db_name": self.db_name,
            },
            index_params={}
        )

fs = LocalFileStore("./documents/kvdata/" + self.db_name + "_" + collection_name)
        store = create_kv_docstore(fs)
        parent_splitter = RecursiveCharacterTextSplitter(chunk_size=10000, chunk_overlap=2000)
        child_splitter = RecursiveCharacterTextSplitter(chunk_size=1024, chunk_overlap=400)

        retriever = ParentDocumentRetriever(
            vectorstore=vectorstore,
            docstore=store,
            child_splitter=child_splitter,
            parent_splitter=parent_splitter,
        )

        retriever.add_documents(documents)

# Do subsequent operations with vectorstore

If I don't disconnect to all databases before doing all operations, all collections get created in the default milvus db and does not respect the db_name parameter in connection_args even when I noticed that the right db_name was being passed for the collection
Description
I have commented on the same issue here: https://github.com/milvus-io/pymilvus/issues/2161#issuecomment-2281557280 - this needs an urgent look since because of this, we are unable to use multiple databases with langchain_milvus without disconnecting all existing connections which is not the right way for us and is causing a lot of trouble.
I assume because of this code block:
if given_address is not None:
            for con in connections.list_connections():
                addr = connections.get_connection_addr(con[0])
                if (
                    con[1]
                    and ("address" in addr)
                    and (addr["address"] == given_address)
                    and ("user" in addr)
                    and (addr["user"] == tmp_user)
                ):
                    logger.debug("Using previous connection: %s", con[0])
                    return con[0]

While it gets the previous, connection, I am not sure if db_name parameter supplied in connection_args is respected when it reconnects.
System Info
langchain==0.2.10
langchain-community==0.2.9
langchain-core==0.2.22
langchain-experimental==0.0.62
langchain-huggingface==0.0.3
langchain-milvus==0.1.2
langchain-text-splitters==0.2.2

@ccurme Got this working by making changes as mentioned in https://github.com/milvus-io/pymilvus/issues/2161#issuecomment-2301247209
But this needs an update in langchain_milvus package as well as suggested


test framework: use proto structs to manipulate iop yaml

Currently using string manipulation to setup meshNetworks in integration tests. This changes things to use the generated structs for all manipulation until we write the iop file.
Came up when working on https://github.com/istio/istio/pull/24162 as setting meshNetworks in the test would conflict with the multinetwork setup.
This makes things generally less fragile and users of the framework can be more comfortable setting values via ControlPlaneValues without the test framework breaking it.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b305e3ad8e72a707b782e0b00438b23949a41179
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test lint_istio

gencheck_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test lint_istio

gencheck_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test lint_istio

gencheck_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test lint_istio

gencheck_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test lint_istio

gencheck_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test lint_istio

gencheck_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test lint_istio

gencheck_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-galley-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-galley-k8s-tests_istio

integ-telemetry-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-pilot-k8s-tests_istio

integ-mixer-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
dfaf376260b7fab46efe6bc66eb9ac5025a10025
link
/test integ-mixer-k8s-tests_istio

integ-distroless-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-distroless-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-galley-k8s-tests_istio

integ-security-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-telemetry-k8s-tests_istio

integ-mixer-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
a22c319a72dd17d07b7e55cce7af4fa95cd328cc
link
/test integ-multicluster-k8s-tests_istio

lint_istio
d7473f8953011b346742985d60e28c3d808742cb
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
38c837d778e07eee433a2419f911fb4fda702a40
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Would something like this be useful in https://github.com/istio/istio/pull/24551 to have some kind of global OperatorValues that RemoteValues and ControlPlaneValues get applied on top of. Should be pretty easy to just use protomarshal.ApplyYaml to do that.

@stevenctl Yes I think something like that would make it easier than appending yaml blocks as strings

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
27c2857d900d482645a52989a04425efee74fcff
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Gender by Date of Birth from Usability Study

[ ] Help users know they can hover, zoom in and reset chart by eg. including a bold direction in the introductory text (Consult with Max for finalized text).
[ ] Add a clickable feature for users to be able to concatenate and view years by their choice, eg. by decades, centuries, 400yrs, etc (Is there a way in Bokeh just to change the scale of the X-axis without manipulating the Y-axis?) If so write about how to do it above it.

@notconfusing

Probably we can include a small section titled interacting with the charts detailing how one can use chart widgets to make sense of the data.
Will not be trivial. Probably should move to an issue titled enhancement or something similar.

@vivekiitkgp I think it's enough to write 1 sentence at the end of the top page text. We don't want to add too much because we don't want to clutter the page. How about.
"Please hover and pan to interact with graphs".


Implement support for Now function in OData 4.0

Server
Method

MS SQL
GETDATE()

MySQL
NOW()

PostgreSQL
NOW()

SQLite
date('now')

Firebird
select cast('Now' as date) from rdb$database

This will require internal changes to MicroLite to expose the now function via the SqlDialect

This may be possible using CURRENT_TIMESTAMP


Path based routing for API gateways

I may have missed something but currently, Traefik seems to only allow domain based routing.
For example with Docker microservices:
userService.docker.com -> user service container
resourceService.docker.com -> resource service container
To allow an API gateway usage, shouldn't path based routing be possible too ?
Like:
app.docker.com/userService -> user service container
app.docker.com/resourceService -> resource service container

@solher Hi, you are right, this is not possible today, using the Docker backend. Maybe we should refactor the labels.
Today, you can use the label traefik.host=bar.
We could introduce two labels instead:

traefik.frontend.rule=Host
traefik.frontend.value=test.localhost

This way, we could also use:

traefik.frontend.rule=Path
traefik.frontend.value=/test

This should be implemented with Marathon backend.
@vdemeester , @solher sounds OK?

Sounds simple and efficient to me. Thanks a lot !

I implemented something similar for the Marathon plugin, I don't remember
the method I used.  I think I added a new attribute.
It might be good to refactor this out of the config plugins somehow, to
have a consistent way of configuring.
Thor
On Wed, Oct 21, 2015 at 1:58 PM, Fabien Herfray<EMAIL_ADDRESS>wrote:

Sounds simple and efficient to me. Thanks a lot !
—
Reply to this email directly or view it on GitHub
https://github.com/emilevauge/traefik/issues/73#issuecomment-149904358.

I like the idea of traefik.frontend.rule but I would definitely think that we should have a default one (Host for example), so if not specified, it uses this one (just to make it simple :stuck_out_tongue: ).

@thorhs you're right, we could refactor a bit what you've done in your PR for Marathon :)
@vdemeester this is already the case, when you start a container without label, you ends up with a routing {containerName}.{domain} ;)

One more thing: for now, there is no URL rewriting mechanism in traefik, just to be clear ;)

Is it possible to combine both Path-based and Host-based rules to route traffic to the backends? I'd like to route the requests based on more complex rules that would be built by combining simple Host/Path-based rules using logical operators such as "and", "or", "not"...
Sorry if I missed to relevant documentation, but I couldn't find anything on the https://docs.traefik.io website.

Thanks @emilevauge

@emilevauge

One more thing: for now, there is no URL rewriting mechanism in traefik, just to be clear ;)
Your call to app.docker.com/userService will ends up at {container-ip}/userService.

Is there a plan to add some rewriting mechanisms ?
thanks

Without the rewritting mechanism this kind of routing doesn't really help in acting as an API gateway.


Fix Helm subscription error not being reported in status

Signed-off-by: Mike Ng<EMAIL_ADDRESS>

/lgtm


[Question] Is it possible to customize the visibility of edit/delete buttons?

Hi there,
is it possible to somehow change the visibility of edit/delete buttons on specific items, cuz right now is either all of them or none?

Also, would that be possible to customize the edit button (i.e. pick another icon)?


Clarify license

I'm noticing that this repository lists the MIT license, but npm lists ISC as the license. My understanding is that these are similar licenses, but I think it'd be helpful for there to be consistency. Vue itself uses the MIT license, so between the two, I think the MIT license might be preferable.

I'll update the package.json with MIT.

Fixed in v0.7.6


Add Prettier check to own pipeline job

Switch prettier check to be called by a standard devops pipeline job.

/azp run

/azp run

Once we determine the check name (see here) we should a corresponding entry in openapi-alps, here:
https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps?path=/private/openapi-kebab/src/bots/pipeline/pipelineEventListener/checksWorkflowInfo.ts&version=GBmain&line=70&lineEnd=71&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

As for the name should we call this "OpenAPI Prettier Check"? @konrad-jamrozik @mikeharder what do you guys think?

As for the name should we call this "OpenAPI Prettier Check"? @konrad-jamrozik @mikeharder what do you guys think?

Works for me! Let's agree for this to be convention and name all checks consistently, including the existing one for TypeSpec?

@raych1 Any ideas why my PR is failing the SDK breaking change even though the SDK generation steps didn't run and my changes aren't touching those at all.

I'm going to be out for the next week so I don't plan to merge this until I'm back. I agree with @mikeharder that at least during our transition we should try to keep the check names exactly the same and then after we transition we can rename them in one go. So, I will keep the check name (i.e. pipeline in this case) set to "Swagger PrettierCheck".

https://dev.azure.com/azure-sdk/public/_build/results?buildId=3076795&view=results test pipeline.

/azp run

@raych1 Any ideas why my PR is failing the SDK breaking change even though the SDK generation steps didn't run and my changes aren't touching those at all.

@weshaggard , this is interesting. Sometimes the check would run against wrong commit which could cause this issue. But it has same result by re-running the check, so it's not the commit issue. I need to dig more for how does the breaking change tracking check get the result.

Yes the change is ready from my testing. Once it merges I will need to enable the pipeline to automatically trigger on other PRs.

/azp run

/azp run

Here is the accompanying PR to remove the PrettierCheck from the unified pipeline https://dev.azure.com/devdiv/DevDiv/_git/openapi-alps/pullrequest/500709

/azp run

@weshaggard: I completed my manual testing and this looks good to me.


ORC-664: Upgrade cmake in the centos7 docker files.

Fixes the docker files to work on some of the platforms.

remove centos6
install cmake > 3 for centos7 and ubuntu14
remove special build of snappy for centos7 and ubuntu14

Since this is already in bc5f9bcb598aac66ba0db5e2ca92b8b06e443c6e , I'll close this PR and update ORC-644 JIRA issue. Thanks, @omalley .


patch: Update base image to use latest debian

Private DTs do not have base images, so switching
to using images by arch simplifies automated
testing for them.
We also remove UDEV since it's not needed
for this particular application and throws
the following warning in the application logs:
balena-hello-world Unable to start udev, container must be run in privileged mode to start udev!

@balena-ci I self-certify!


Replace CodeDom with Roslyn SyntaxFactory

By taking a dependency to roslyn the whole code dom usage could be replaced with SyntaxFactory. For example
            var @namespace = SyntaxFactory.NamespaceDeclaration(SyntaxFactory.ParseName("SomePublicApi")).NormalizeWhitespace();

             // Add System using statement: (using System)
            //@namespace = @namespace.AddUsings(SyntaxFactory.UsingDirective(SyntaxFactory.ParseName("System")));

            //  Create a class: (class Order)
            var classDeclaration = SyntaxFactory.ClassDeclaration("Order");

            // Add the public modifier: (public class Order)
            classDeclaration = classDeclaration.AddModifiers(SyntaxFactory.Token(SyntaxKind.PublicKeyword));

            // Inherit BaseEntity<T> and implement IHaveIdentity: (public class Order : BaseEntity<T>, IHaveIdentity)
            classDeclaration = classDeclaration.AddBaseListTypes(
                SyntaxFactory.SimpleBaseType(SyntaxFactory.ParseTypeName("BaseEntity<Order>")),
                SyntaxFactory.SimpleBaseType(SyntaxFactory.ParseTypeName("IHaveIdentity")));

            // Create a string variable: (bool canceled;)
            var variableDeclaration = SyntaxFactory.VariableDeclaration(SyntaxFactory.ParseTypeName("bool"))
                .AddVariables(SyntaxFactory.VariableDeclarator("canceled"));

            // Create a field declaration: (private bool canceled;)
            var fieldDeclaration = SyntaxFactory.FieldDeclaration(variableDeclaration)
                .AddModifiers(SyntaxFactory.Token(SyntaxKind.PublicKeyword));

            // Create a Property: (public int Quantity { get; set; })
            var propertyDeclaration = SyntaxFactory.PropertyDeclaration(SyntaxFactory.ParseTypeName("int"), "Quantity")
                .AddModifiers(SyntaxFactory.Token(SyntaxKind.PublicKeyword))
                .AddAccessorListAccessors(
                    SyntaxFactory.AccessorDeclaration(SyntaxKind.GetAccessorDeclaration).WithSemicolonToken(SyntaxFactory.Token(SyntaxKind.SemicolonToken)),
                    SyntaxFactory.AccessorDeclaration(SyntaxKind.SetAccessorDeclaration).WithSemicolonToken(SyntaxFactory.Token(SyntaxKind.SemicolonToken)));

            // Create a stament with the body of a method.
            var syntax = SyntaxFactory.ParseStatement("");

            // Create a method
            var methodDeclaration = SyntaxFactory.MethodDeclaration(SyntaxFactory.ParseTypeName("string"), "MarkAsCanceled")
                .AddModifiers(SyntaxFactory.Token(SyntaxKind.PublicKeyword))
                .WithBody(SyntaxFactory.Block(syntax));

            // Add the field, the property and method to the class.
            classDeclaration = classDeclaration.AddMembers(fieldDeclaration, propertyDeclaration, methodDeclaration);

            // Add the class to the namespace.
            @namespace = @namespace.AddMembers(classDeclaration);

            // Normalize and get code as string.
            var code = @namespace
                .NormalizeWhitespace()
                .ToFullString();

Generates an API to a string
Kudos to https://carlos.mendible.com/2017/03/02/create-a-class-with-net-core-and-roslyn/

I will be very happy with this change. The current way of generation through CodeCom is obscure.

The SyntaxFactory is super hardcore to use. I spiked around a bit and it would take me too much time to iterate towards using the SyntaxFactory. I might explore the SyntaxGenerator a bit which seems to be less verbose
https://gist.github.com/jagt/1b77a3c6e2c0ba2aea1ca437997289f2

But isn’t it easier to write your own renderer? Because the bodies of the methods are not needed, only the signatures.

I think that standard System.Reflection is enough to solve the problem.

Sorry I don't understand your input about reflection.
Well define easier ;)
Probably the easiest way, for now, would be string templating. This issue is more a way of publicly capturing my current thought process. Not sure I have the capacity to execute on it

Sorry I don't understand your input about reflection.

Use standard System.Reflection API instead Mono, Roslyn to read assembly information and build public api as text manually. This should not require writing more code than there is now.

Reflection brings a host of other problems like assembly loading into app domain. With mono.cecil that problem doesn't exist. So I'm not sure I'd see that value in that. Plus some information that is currently available with Mono.Cecil would be hard or even impossible to retrieve with reflection. The new reflection api might work but it is obscure and not well documented yet

Ok.

Plus some information that is currently available with Mono.Cecil would be hard or even impossible to retrieve with reflection.

For example, what?

Looked a bit more into using the SyntaxGenerator. The basic bits where easy to get started but now I'm a bit stuck to get the return type expressions done properly
https://github.com/JakeGinnivan/ApiApprover/tree/roslyn-spike

I confess I'm not really keen to bring this forward. I did another attempt last night and rebuilding everything with SyntaxFactory is painstakingly tiresome especially because I would need to make sure everything is still compatible.
Every time I give it another attempt I spend hours of diving through poorly documented roslyn APIs, using Oren's Roslyin Quoter to get a tiny sense of what is going on until my head explodes and I ask myself why I'm going through all this pain.
I tried different psychological tricks like convincing myself that this is a really rewarding learning experience but that didn't help

Perhaps later api will be simplified.

I had a lot of fun rendering to a StringBuilder directly. A bit messy to put it all in one file, but I found it very easy to tweak.
https://github.com/jnm2/ApiContractGenerator/blob/46a90b471b1d724e2fb8109ae86f5f195e5edc65/src/ApiContractGenerator/CSharpTextFormatter.cs

Found this https://github.com/dotnet/arcade/tree/master/src/Microsoft.DotNet.GenAPI

I'm not going to put any more efforts into rewriting the core of this library given that Microsoft is pushing the GenAPI forward and I've already seen some projects adopting it. Closing this issue


Command line umple compiler explains how to run java when other languages generated

When compiling on the command line, after completion Umple explains how to run the program in java. However, if another language is generated, such as php or C++ it should report how to run in that language instead. The following example shows that even though Cpp was generated, it says Run java Person.
$ java -jar umple-<IP_ADDRESS>99.60569f335.jar -g Cpp umplex.ump
Processing -> umplex.ump
 Main method found. Run java Person
Success! Processed umplex.ump.

This was resolved in PR #1669


[WIP] Update with latest torchmetrics mAP

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi, will there be any update for this PR? Thanks.

Close and use a newer version of mAP implementation instead,


As a new user, I want to record dietary requirements for guests

... so that I can cater correct types of meals for my guests

Addressed by #98.


Installation fails due to conflicting urllib3 version

Hi, users are unable to run webinfo-crawler due to dependency conflict with urllib3 package.
As shown in the following full dependency graph of webinfo-crawler, webinfo-crawler requires urllib3==1.25.2，while requests==2.21.0 requires urllib3>=1.21.1,<1.25.
According to pip’s “first found wins” installation strategy, urllib3==1.25.2 is the actually installed version.
However, urllib3==1.25.2 does not satisfy urllib3>=1.21.1,<1.25.
Dependency tree
webinfo-crawler-master
| +-dbutils(version range:==1.3)
| +-pymysql(version range:==0.9.3)
| +-redis(version range:==3.2.0)
| +-requests(version range:==2.21.0)
| | +-certifi(version range:>=2017.4.17)
| | +-chardet(version range:<3.1.0,>=3.0.2)
| | +-idna(version range:>=2.5,<2.9)
| | +-urllib3(version range:>=1.21.1,<1.25)
| +-urllib3(version range:==1.25.2)

Thanks for your help.
Best,
Neolith

Solution

Fix your direct dependency to be urllib3>=1.21.1,<1.25.
Fix your direct dependency to be requests==2.22.0.
Remove your direct dependency urllib3, and use urllib3 transitively introduced by requests.

I have checked the above revisions will not affect your downstream projects now.
Which solution do you prefer, 1, 2 or 3?
@lubosson  Please let me know your choice. I can submit a PR to solve this issue.

@NeolithEra I just upgraded requests to v2.22.0, the latest requests v2.22.0 officially supports urllib3 v1.25.2. solving it with command:
pip3 install --upgrade requests==2.22.0
I reran the pip3 freeze > requirements.txt, I will push it right now, Thanks for recommending, the solution really meaningful, that's awesome!


Based on #698

There is something wrong with the syntax highlighter here, testing a theory to riff off of #698 which attempted to fix it, but didn't seem to work.

Neither of us have guessed correctly about what causes this issue.
I now believe that the syntax highlighting issue is related to slashy strings. Parsing Groovy must be very difficult. 🤷


Fix cmake issue for arm64 on windows not passing architecture

Resolves #1587

@acwatkins thanks for the pull request. Can you explain why this fixes it? I don't understand the fix, I have to say.

@JonasVautherin right, I agree with the change but I don't understand how it solves the problem.

I think we just add -A to the cmake line, and therefore it will try to take the next word as the platform argument. Say if the line reads cmake -A -DCMAKE_PREFIX_PATH=... I'm guessing it will try to pass -D<something?> as the platform argument.

With the original if(DEFINED ${CMAKE_GENERATOR_PLATFORM}), it was not making it into the if, when an architecture was defined. So, it wasn't adding the -A argument at all to 3rd party libs.
I changed it to remove the expansion of the variable to just check that CMAKE_GENERATOR_PLATFORM is defined. This caused it to always go into the if statement as it seems it is defined as empty string always, resulting in an empty -A when not specifying an architecture. I then added the empty string check to prevent the empty -A.
I tested this on windows cross compiling for arm64 as well as native compiling for amd64 (with no -A argument) using Visual Studio 2019.


chore: add more obvious hover effect to the trending app item

As per our discussion with @charleslavon this PR introduces a better hover effect for trending apps.
https://github.com/near/near-discovery-components/assets/34593263/7ef01602-d63e-4215-b325-9d30f81f3401
I haven't touched the src/NearOrg/DataAvailabilityPage.jsx file, it was affected by prettier.

Ohh, that looks really nice!


Adding the new op: Flash Decode!

Ticket
Copied from #9510
The flash decode is the exact implementation of the state-of-the-art flash decode in cuda.
See https://pytorch.org/blog/flash-decoding/
Problem description
To speed up decode with low batch size and high sequence length, we propose to use flash decode.
This issue tracks the implementation of the kernel.
See figure below for proposed implementation.

What's changed
We added an entire new kernel. It improved existing attention computation latency by 2-4x. See below perf table:

Additional Information
The flash decode kernel exposed potential llk/metal bugs that causes deterministic hangs and nd pcc errors.
These issues are worked around using tensix_sync() and disabling features (such as fp32 accumulate), which is not ideal. The current implementation with all the worked arounds are thoroughly tested and passed all test cases. Some debug prints are left in the kernel because I expect to work on this kernel again once those issues are resolved.
See issues below:
#9370
#9608

Overall, great work Jack! Congrats on making the FlashDecode op correct and performant. Fast, super large context 🚀

Would be cool to see the perf of the old implementations as well for comparison.

Overall, great work Jack! Congrats on making the FlashDecode op correct and performant. Fast, super large context 🚀

Would be cool to see the perf of the old implementations as well for comparison.

@caixunshiren you can do this by setting num_workers=0?

Overall, great work Jack! Congrats on making the FlashDecode op correct and performant. Fast, super large context 🚀

Would be cool to see the perf of the old implementations as well for comparison.

@caixunshiren you can do this by setting num_workers=0?

I have a comparison from last week that uses 48 cores instead of 64 cores. I'm pasting it here. Meanwhile, I can run another perf benchmark on setting num_workers=0. In below chart, v0 is the old implementation.

Minor comments + question:

What is the difference between flash decode and the previous flash attention? Is it just that the height is batch?

They are some what similar. The short answer is that flash attention parallelize on batch and heads, while flash decode can parallelize batch, heads, and sequence length. Check out this article that compares flash attention with flash decode:
https://pytorch.org/blog/flash-decoding/

Overall, great work Jack! Congrats on making the FlashDecode op correct and performant. Fast, super large context 🚀

Would be cool to see the perf of the old implementations as well for comparison.

@caixunshiren you can do this by setting num_workers=0?

Done. Updated the table in the pr


nanodet does not contain load_config，load_model_weight，build_model，what need for demo

Have you setup nanodet correctly?  Make sure you fully installed the requirements and then run python setup.py develop

thanks!


table-bordered with tbody and no content = no border

I noticed a weird behaviour when using table-bordered in Firefox...
http://jsfiddle.net/B3CWR/3/
This is a very specific issue only in FF so I'm not sure if yall want to address it but this does fix it:

thead+tbody:before{
    content:" ";
}

(The proposed fix actually makes the border-width bigger so I guess it's not a fix)

Added a relevant test to the W3C CSS test suite: https://github.com/w3c/csswg-test/pull/793


DMatrix Concatenation

Hi, is there currently support for DMatrix concatenation? I saw in https://github.com/dmlc/xgboost/issues/60 that there was discussion on adding support for this, but I couldn't find any documentation on it.
Thanks!

No, we do support training on batches via external memory though.

Are there plans to do add support for this?

My current view on this is that it would be easy for us to start building a data frame library from DMatrix, instead I want to push this functionality onto external libraries. You could save a preprocessed file to a csv or libsvm and read it into a DMatrix from disk.


site, upd current date

Hi!
Small clarification:

Powered by Google ©2010-presen
Powered by Google (remove date)???

update


Update inprod(a,b)

I found that I have an error with current version inprod(a,b). * is not working for two vectors.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.934%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/BUGSPrimitives/functions.jl
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
1402

Relevant Lines:
1949

💛  - Coveralls

Hi @sunxd3
Sorry for late response. For unknown reason, I didn’t get notification.
I am actually new to Julia test, - does current test work? Also, your code
return LinearAlgebra.dot(a, b)
is the same as my current one. If you have any feedback, please let me know.

@serenlee the formatter CI is a bit strange -- it usually show suggestions, but it's not doing that now. I took the liberty to do the formatting, hope it's not offensive.

@serenlee thanks!


Upgrade to 1.0.1 and systemd support

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:


escapeUtil refactor

What type of PR is this?

[x] enhancement

What problem(s) does this PR solve?
Description:
It seems that if condition can be removed, because if str contains "\r" then "\r" will replaced, if it does not, nothing happens.

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.24 :warning:

Comparison is base (29fb764) 30.85% compared to head (6aa93bf) 30.61%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #107      +/-   ##
============================================
- Coverage     30.85%   30.61%   -0.24%
  Complexity       76       76
============================================
  Files            30       30
  Lines          1517     1509       -8
  Branches        238      231       -7
============================================
- Hits            468      462       -6
+ Misses          979      978       -1
+ Partials         70       69       -1

Impacted Files
Coverage Δ

...cala/com/vesoft/nebula/connector/NebulaUtils.scala
35.71% <100.00%> (-2.97%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@wey-gu @Nicole00 Thank you for the review! Can we merge this approved PR? )

@wey-gu @Nicole00 Thank you for the review! Can we merge this approved PR? )

merged~ thank you for the contribution!


WSAS-2030 : improving error handing for persisting globally engaged s…

…tate
Moving globally engaged state false method to disengageModuleFromSystem()

Commits here are already merged with other PRs


Shop Option: HideWithoutPermission

Description of new idea or improvement on existing one
I would like to have an option for the Jobs Shop: HideWithPermission: So I am able to hide certain items for players that already unlocked this item.
Detailed information what should do
There is already a HideWithoutPermission: false and I would like to have a HideWithPermission: false due to making an upgrade system with it, this needs the option that I asked for above to make it that way. So players can't accidently purchase the upgrade twice.
<-- Maybe a config example if related -->
      HideWithoutPermission: false

Then the players will not be able to buy or click on any items because the HideWithPermission option prevents to buy things from shop. So if players have permission to buy a item from shop, and the HideWithPermission is enabled then they will not be able to buy anything, despite they have the correct permissions.

to making an upgrade system with it, this needs the option that I asked for above to make it that way. So players can't accidently purchase the upgrade twice.

For your "upgrade system" use a gui shop plugin which doing that.


Printable oxy tanks

ive been sitting on this so longa ton of stuff has been added that just arent in this yml so I will need to manually add them

About the PR

adds emergency, extended emergency and double emergency oxygen tanks to the autolathe
by the way ive been sitting on the code for this so long that a bunch of stuff thats been added isnt in the YML yet so i need to quickly manually re add them
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: JoeHammad

add: The dark secrets of creating oxygen tanks has been revealed to the cargo department

theres no reason to print smaller ones when its just a few steel more for the vastly superior option
also cl is wrong sci hss an autolathe and sometimes engi

also webedit ops :trollface:

what the fuck is an editweb

hermm

null value ops

ss14 version of john howard: captain goes for a space walk and disappears

ss14 version of john howard: captain goes for a space walk and disappears

Are you thinking of Harold Holt?

((gaming refren)

yeah probably

zamn okay, what does this mean?

ignore

Odd

theres no reason to print smaller ones when its just a few steel more for the vastly superior option
also cl is wrong sci hss an autolathe and sometimes engi

you forgot about spiders

yes and spiders will print double emergency tanks theres no reason to print smaller ones

you're probably right but it just feels wrong not to, you know? someone might just like one aesthetically, I get your point, but I also don't see a reason why not to include it

People would powergame and only grab the double emergency ones because it makes the other two redundant.
There's a reason they're rarely mapped.

it seems weird that all of these are directly available at any autolathe.
Even if a tank has double capacity, it should have a cost that is greater than double since it has the added advantage of only taking up a single inventory slot.
Additionally, I think printing these is very bloat-y considering the autolathe is already full of random shit and oxygen tanks are extremely plentiful.
quite frankly, this just looks like your other prs trying to give salvage double extended emergency tanks but in another set of clothes.

not entirely
you can just go down to atmos and ask for a bigger oxygen tank and get it for free, they might even fill it up more for you.
the ones that you can print start empty but you could just find oxygen tanks in maints, assuming cargo didn't already steal them all
also, I was trying to give salv the single extended tank not the double extended tank

Considering these items are direct upgrades, they should not be available roundstart in an easily accessible / replenishable manner.
We've additionally rejected several other PRs which sought to similarly make these items more easily acquired.
Due to the combined benefits of having a significantly higher capacity while simultaneously fitting in a pocket, these should not be common or able to produced in any way.
closing this.


Fix govet errors in worker pool template

don't pass sync or mutex as value
remove unreachable code

John,
Do you also want the unhandled errors in the _test.go files fixed?
-Solomon
On Fri, Mar 13, 2020 at 11:53 AM John Scharber<EMAIL_ADDRESS>wrote:

Assigned #65 https://github.com/pavedroad-io/roadctl/issues/65 to
@shgayle https://github.com/shgayle.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/pavedroad-io/roadctl/issues/65#event-3127269329, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANA4GPG5D3SGVSI4CQOBBN3RHJJHFANCNFSM4KRE47GA
.

Not right now, we have other things to work on.
On Sun, Mar 15, 2020 at 9:45 AM Solomon Gayle<EMAIL_ADDRESS>wrote:

John,
Do you also want the unhandled errors in the _test.go files fixed?
-Solomon
On Fri, Mar 13, 2020 at 11:53 AM John Scharber<EMAIL_ADDRESS>wrote:

Assigned #65 https://github.com/pavedroad-io/roadctl/issues/65 to
@shgayle https://github.com/shgayle.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/pavedroad-io/roadctl/issues/65#event-3127269329, or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ANA4GPG5D3SGVSI4CQOBBN3RHJJHFANCNFSM4KRE47GA
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/pavedroad-io/roadctl/issues/65#issuecomment-599235029,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM4YWSXYC2MQGGUZO3LXCDRHUAY7ANCNFSM4KRE47GA
.

--
John Scharber
Founder/CEO
j<EMAIL_ADDRESS><EMAIL_ADDRESS>https://github.com/jscharber https://github.com/jscharber
(925) 200-7231

Understood.
-Solomon
On Sun, Mar 15, 2020 at 1:29 PM John Scharber<EMAIL_ADDRESS>wrote:

Not right now, we have other things to work on.
On Sun, Mar 15, 2020 at 9:45 AM Solomon Gayle<EMAIL_ADDRESS>wrote:

John,
Do you also want the unhandled errors in the _test.go files fixed?
-Solomon
On Fri, Mar 13, 2020 at 11:53 AM John Scharber<EMAIL_ADDRESS>wrote:

Assigned #65 https://github.com/pavedroad-io/roadctl/issues/65 to
@shgayle https://github.com/shgayle.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/pavedroad-io/roadctl/issues/65#event-3127269329,
or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ANA4GPG5D3SGVSI4CQOBBN3RHJJHFANCNFSM4KRE47GA

.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/pavedroad-io/roadctl/issues/65#issuecomment-599235029>,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAM4YWSXYC2MQGGUZO3LXCDRHUAY7ANCNFSM4KRE47GA
.

--
John Scharber
Founder/CEO
j<EMAIL_ADDRESS><EMAIL_ADDRESS>https://github.com/jscharber https://github.com/jscharber
(925) 200-7231
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/pavedroad-io/roadctl/issues/65#issuecomment-599240024,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANA4GPFHZTSDX6UTPXFC4TDRHUF6HANCNFSM4KRE47GA
.


how to deploy  durable_rules server on Gunicorn?

hi,jruizgit
Thanks your great job on durable_rules and it helps my project a lot. When I finished my development, I want to deploy it on production env using Gunicorn.
In "engine_server.py" :

if name == 'main':
run_all(host_name = '<IP_ADDRESS>', port = 5600)

start  gunicorn:

gunicorn -c   config/gun.conf  engine_server:app

However, I found it failed when deploy on gunicorn.
How can I  delpoy durable_rules on gunicorn ?
Blow is gunicorn log:

[2016-09-22 13:48:18 +0000] [589] [INFO] Starting gunicorn 19.6.0
[2016-09-22 13:48:18 +0000] [589] [DEBUG] Arbiter booted
[2016-09-22 13:48:18 +0000] [589] [INFO] Listening at: http://<IP_ADDRESS>:5600 (589)
[2016-09-22 13:48:18 +0000] [589] [INFO] Using worker: gevent
[2016-09-22 13:48:18 +0000] [594] [INFO] Booting worker with pid: 594
[2016-09-22 13:48:18 +0000] [597] [INFO] Booting worker with pid: 597
[2016-09-22 13:48:18 +0000] [600] [INFO] Booting worker with pid: 600
[2016-09-22 13:48:18 +0000] [594] [DEBUG] Exception while loading the application
Traceback (most recent call last):
File "/home/frank/.pyenv/versions/2.7.12/envs/env2712/lib/python2.7/site-packages/gunicorn/arbiter.py", line 557, in spawn_worker
worker.init_process()
File "/home/frank/.pyenv/versions/2.7.12/envs/env2712/lib/python2.7/site-packages/gunicorn/workers/ggevent.py", line 190, in init_process
super(GeventWorker, self).init_process()
File "/home/frank/.pyenv/versions/2.7.12/envs/env2712/lib/python2.7/site-packages/gunicorn/workers/base.py", line 126, in init_process
self.load_wsgi()
File "/home/frank/.pyenv/versions/2.7.12/envs/env2712/lib/python2.7/site-packages/gunicorn/workers/base.py", line 136, in load_wsgi
self.wsgi = self.app.wsgi()
File "/home/frank/.pyenv/versions/2.7.12/envs/env2712/lib/python2.7/site-packages/gunicorn/app/base.py", line 67, in wsgi
self.callable = self.load()
File "/home/frank/.pyenv/versions/2.7.12/envs/env2712/lib/python2.7/site-packages/gunicorn/app/wsgiapp.py", line 65, in load
return self.load_wsgiapp()
File "/home/frank/.pyenv/versions/2.7.12/envs/env2712/lib/python2.7/site-packages/gunicorn/app/wsgiapp.py", line 52, in load_wsgiapp
return util.import_app(self.app_uri)
File "/home/frank/.pyenv/versions/2.7.12/envs/env2712/lib/python2.7/site-packages/gunicorn/util.py", line 370, in import_app
raise AppImportError("Failed to find application: %r" % module)
AppImportError: Failed to find application: 'engine_server'
[2016-09-22 13:48:18 +0000] [594] [INFO] Worker exiting (pid: 594)

Hi, thanks for posting the question. The following code ran for me:
from durable.lang import *
import durable.interface

with ruleset('nest'):
    @when_all(m.cc_n_all > 0)
    def rule_1(c):
        print('before: c.m: {0}'.format(c.m))

    @when_start
    def start_test(host):
        host.post('nest', { "sid": 1, "id": 1, "cc_n_all":15 })

main_host = create_host()
application = durable.interface.Application(main_host, None, None)

Save it into a file called test.py and in the same directory run:
gunicorn test:application


Installing requirements-dev.txt results in a reinstall of since updated packages

Notice reinstall:
Installing collected packages: psycopg2-binary, django, google-auth, azure-core
  Attempting uninstall: psycopg2-binary
    Found existing installation: psycopg2-binary 2.9.5
    Uninstalling psycopg2-binary-2.9.5:
      Successfully uninstalled psycopg2-binary-2.9.5
  Attempting uninstall: django
    Found existing installation: Django 4.1.7
    Uninstalling Django-4.1.7:
      Successfully uninstalled Django-4.1.7
  Attempting uninstall: google-auth
    Found existing installation: google-auth 2.17.0
    Uninstalling google-auth-2.17.0:
      Successfully uninstalled google-auth-2.17.0
  Attempting uninstall: azure-core
    Found existing installation: azure-core 1.26.3
    Uninstalling azure-core-1.26.3:
      Successfully uninstalled azure-core-1.26.3
Successfully installed azure-core-1.26.4 django-4.2 google-auth-2.17.2 psycopg2-binary-2.9.6

I believe this is due to version mismatch. I assume one of the files should be re-generated but not sure which.

@kjaymiller I'm not sure workflow for re-generating requirements files to make sure they match, but I believe that's whats necessary here. It's not a huge deal that things got uninstalled, but it'd be a nicer dev experience if they weren't (and faster).

I think currently it's manual, however I do believe we have dependabot that should manage that should manage that.

Not currently relevant, right, as we moved from pip-tools to unpinned .in?

correct however if we're using requirements.in instead of requirements.txt we can manually manage the requirements.txt.


Resize Server Image and Show in Tableview - Increase memory and App Crash Randomly

Hello,
I am displaying image using below code.
cell.imgPackage.sd_setImage(with: URL(string: "MY URL STRING")! as URL, placeholderImage: UIImage(named: "testPlaceholder.png"), options: .refreshCached)
need to resize width and height of server image and set in tableview cell image.
my server image resolution is around
width - 1519
height - 950
and tableview having -
width - 320
height - 150
let me know if you need any clarification.

you should consider 2 options:
1st -> download the large resolution image and write code to make it smaller after download
2nd -> ask your server to give you smaller images in the 1st place

For the 1st case, you can Use (-[SDWebImageManagerDelegate imageManager:transformDownloadedImage:withURL:])[https://github.com/rs/SDWebImage/blob/1749666720401ff129212631886c4af7531e6584/SDWebImage/SDWebImageManager.h#L144-L154] to do  custom resizing for your case if you find the image size is larger than excepted.

@dreampiggy Thanks for replay.
I want to go ahead for 1st case.
can you please give example code for swift 3.

@kushaseum  You can do with the delegate methods to resize if need(Such as for specify URL, for size which larger than the limit). The Objective-C code is actuall no difference with Swift code :)
class ViewController: UIViewController, SDWebImageManagerDelegate {

    override func viewDidLoad() {
        super.viewDidLoad()

        SDWebImageManager.shared().delegate = self
        SDWebImageManager.shared().loadImage(with: URL(string: "http://foo/large.png"), options: [], progress: nil) { (image, data, error, cacheType, finished, url) in
            // Do something
        }
    }

    func imageManager(_ imageManager: SDWebImageManager, transformDownloadedImage image: UIImage?, with imageURL: URL?) -> UIImage? {
        guard let image = image, let imageURL = imageURL else {
            return nil
        }
        if (imageURL.lastPathComponent == "large" && (image.size.width > 1000 || image.size.width > 1000)) {
            let targetSize = CGSize(width: 1000, height: 1000)
            UIGraphicsBeginImageContextWithOptions(image.size, !SDCGImageRefContainsAlpha(image.cgImage), image.scale)
            image.draw(in: CGRect(origin: .zero, size: targetSize))

            let scaledImage = UIGraphicsGetImageFromCurrentImageContext()
            UIGraphicsEndImageContext()
            return scaledImage
        } else {
            return image
        }
    }
}

Hello,
Thanks for swift Reply.
getting one issue - Please check screen sort
I had write below code.
SDWebImageManager.shared().delegate = self         SDWebImageManager.shared().loadImage(with: URL(string: (arrInternationPackageModel.object(at: indexPath.row) as! NSDictionary).value(forKey: "image") as! String)!, options: [], progress: nil) { (image, data, error, cacheType, finished, url) in             // Do something             cell.imgPackage.image = image         }
`func imageManager(_ imageManager: SDWebImageManager, transformDownloadedImage image: UIImage?, with imageURL: URL?) -> UIImage? {
let targetSize = CGSize(width: 320, height: 150)
UIGraphicsBeginImageContextWithOptions((image?.size)!, !SDCGImageRefContainsAlpha(image?.cgImage), image!.scale)
image?.draw(in: CGRect(origin: .zero, size: targetSize))
    let scaledImage = UIGraphicsGetImageFromCurrentImageContext()
    UIGraphicsEndImageContext()
    return scaledImage
}`

Mistake. Change the 'image.size' to 'targetSize' in UIGraphicsBeginImageContext

We already have some code that handles image resize, but it's called only when SDWebImageScaleDownLargeImages option is set and the image is large enough (over 60 MB of memory for a decompressed image). See SDWebImageIOCoder
sd_decompressedAndScaledDownImageWithImage


wails build -platform windows/amd64 ERROR

The error is as follows
Building target: windows/amd64
• Generating bindings: Done.
• Installing frontend dependencies: Done.
• Compiling frontend: Done.
• Generating application assets: Done.
• Compiling application: # changeme
./app.go:24:22: undefined: malgo.AllocatedContext
./app.go:25:21: undefined: malgo.DeviceConfig
./app.go:40:25: undefined: malgo.InitContext
./app.go:40:48: undefined: malgo.ContextConfig
./app.go:45:25: undefined: malgo.DefaultDeviceConfig
./app.go:61:28: undefined: malgo.DeviceCallbacks
./app.go:66:23: undefined: malgo.InitDevice
But there are no issues with Linux compilation

Nothing to do with this repo. You are compiling cgo project with CGO_ENABLED=0. When you correct this to CGO_ENABLED=1, you will see the real error, and it should be related to you trying to cross-compile the go project with the wrong C compiler. Every cgo project is like that. I have no idea what wails build is doing, though.

gcc: error: unrecognized command-line option ‘-mthreads’; did you mean ‘-pthread’?

As I said, now you see real error. You are trying to compile for Windows using a Linux C compiler.

必须在windows上进行编译是吗？但是我使用windows虚拟机编译，还是会有错误

Of course you can cross-compile, install mingw and use that instead of your compiler. It doesn't work in VM because you probably didn't install gcc there right? See e.g. here https://github.com/gen2brain/iup-go?tab=readme-ov-file#cross-compile-linux, you can also use zig cc, probably clang, lots of options.


Remind after submitting transactions

Also, refresh tables or reload the page when the transactions are done.

Done


Sometimes get error: Error response from daemon: no available IPv4 addresses on this network's address pools

Describe the bug
$ docker compose up -d

To Reproduce
git clone https://github.com/timescale/promscale.git
cd promscale/docker-compose/promscale-demo
docker compose up -d

Also jaeger did not start:

Jaeger didn't start most likely due to a lack of ipv4 addresses, which looks more like a docker issue than promscale or docker-compose one. More can be found in https://github.com/moby/moby/issues/18527 and https://github.com/moby/moby/issues/21967


Fix Broken links

Shortcuts in the main page doesn't work. This is not perfect because links are hardcoded (it will break if the domain change ) but it should work

Links aren't broken, they are pointing to anchors in the page.
Did you encourter this issue on the blog post on the Babel's website (https://babeljs.io/blog/2016/12/07/the-state-of-babel) ?

Exact but it doesn't work when anchors are not in the page, like in the main blog page ( https://babeljs.io/blog/ ) . This is the issue , on babel's website yes

Ok yes, good point.
I guess we could also update the description of the post to avoid theses links on the page.
/cc @hzoo

Absolutely, I think it's a better fix ;)

Yeah its just auto adding the first thing there so I dono 😄 we could remove.

Thanks @maxdow :+1:

You're welcome, thanks for all the hard work and thanks @hzoo for this really good recap on the state of babel


Japanese Text Identification

Hi, I'm trying to do a OCR App made in React Native, and I met vision-camera-ocr. It's working fine with Latin letters! But I would like to extract japanese characteres (katakana, hirakana, kanji). I found that vision-camera-ocr uses Google's MLKit v2, but I do not know how to implement the  identification for the languages' cited.
Thanks for now!

Check this https://www.youtube.com/watch?v=kOYP2Xun_6o&list=PLQhQEGkwKZUrempLnmxjt7ZCZJu1W3p2i&index=77

@LeiteSS  did you try to change the pod file according tot he Google's MLKit v2?  I did that and now it's not recognizing even the latin text.


I can't download playlist as mp3

Hello, I can't download playlist as mp3. I can download only mp4 or mkv. Can you help me?
Settings;

If I remember correctly you need to uncheck Download clean audio, without converting to any format.

Its works, thank you <3


[TE] UI: Add predicted baseline to preview

@harleyjj I am going to hand this off to you. I have made the graph show upper bound and lower bound series, but it hasn't fill in  the space between upper and lower bound as the design does. It needs some hack to realize.

@tangdian  can you add a screenshot of current graph?


Options for colorized output and/or do not use white

Component
Forge
Describe the feature you would like
I think it's forge build that colorizes errors generated by solc. It looks like white is sometimes used, and for those of us that use a white background in our terminal, that's invisible. Perhaps avoid white and black as colors and/or expose color options in foundry.toml?
Additional context
No response

Do you have an example output or a repro for it? I'll take a look tomorrow

https://github.com/ethereum/solidity/issues/14358#issuecomment-1612350239

"info" error severity in Solidity is colored with white (code 37) so I just copied that from them (ethers-rs).

I'll spend some time re-familiarizing myself with terminal color theory (i.e., I am by no means an expert in this area). My original bug post made some potentially incorrect assumptions, one of which was that the invisible color was "white". At the alacritty site you posted, if the octal 037 examples visible when you scroll down correspond to the code 37, they label this not as white but "light grey." Perhaps this is alacritty's attempt to avoid having a forground color which is pure white? No idea here.
Anyway, thinking more clearly about this problem, what is to be avoided really is the use of a color which is equal to the background color of the current terminal. If there exists a way to query the latter, the former can be avoided. I'm having trouble remembering if there is a mechanism for the flow of terminal information in that direction, but there must be, since at least terminal window size can be obtained by editors.
I guess this is worth noting to the solidity team as well. I'll open a bug linking this bug for them.

Also, for anyone seeing this: see solc's --no-color


Calendar should show last date picked, not start date

Pre-flight check-list
Fixes #147
Before raising a pull request

[ ] Documentation
[x] Unit tests

Pre-merge check-list

[ ] Link to Trello ticket/GitHub issue (If applicable)
[ ] Any risky areas identified
[ ] Test plan provided
[ ] Tester approved

Tester check-list

[ ] Tested on multiple devices / OS versions (Test on the physical device(s) you have access to, otherwise use BrowserStack):

[ ] Galaxy S8 (Android 7.0/8.0)
[ ] Galaxy S7 (Android 6.0)
[ ] iPhone X (iOS 11.x)
[ ] iPhone 8 (11.x)
[ ] iPhone 7 (iOS 10.x)

Optional:

[ ] Google Pixel 2
[ ] Galaxy S8 Plus
[ ] Galaxy S7 Edge
[ ] Galaxy S6
[ ] iPhone 7+
[ ] iPhone 6

Accessibility Testing (If applicable)

[ ] Text-to-Voice (Android: Voice Assistant / iOS: Speak Selection)
[ ] Large Text (=<200%)
[ ] Landscape Screen orientation

Weak connection testing (If applicable)

[ ] Airplane mode
[ ] 2G/3G Network Settings

It seems that the forceNewRange is a state prop set by comparing  the stagedFilters with selectedFilters in the state. When dateRange is selected and forceNewRange is false then  which fixes the error of it skipping back to the startDate


Add opentracing support

http://opentracing.io/
https://github.com/opentracing/opentracing-go

As a larger topic, what tracing strategy do we want to recommend for a typical setup involving a cluster of registries (+LB, and maybe CDN)?

Closing as per:

https://github.com/distribution/distribution/pull/4188
https://github.com/distribution/distribution/pull/4196


Snippets: default variable value makes snippet treat the variable as regular text

Refs #15873
Have the following snippet. Insert your snippet in a text, notice how the postCode is not being treated as a variable. It is being nicely treated as a variable if no default value is specified.
provideCompletionItems(document, position, token) {

	    const mySnippet = new vscode.SnippetString();
            mySnippet.appendText('zurich ');
            mySnippet.appendVariable('postCode', '8008');

            const item = new vscode.CompletionItem('ZURICH', vscode.CompletionItemKind.Class);
            item.insertText = mySnippet;

            return [item];
        }

It is being nicely treated as a variable if no default value is specified.

It is treated as placeholder because it is undefined and has no value. That is very special and exists only because we have been falsely advertising TM snippet syntax (even for static snippets) and confused variables and placeholders. We have document that here: https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/snippet/common/snippet.md#L15.
Undecided yet how to proceed with unknown variables that have a default value. The implemented behaviour is correct in TM-terms but I have to see what else we have been falsely selling as TM-syntax


Fixed OPENAI model deprecated issue by changing model names

Issue #141 has many people recently report TOKEN LIMIT EXCEEDED error.
I discovered that the issue is because on Jan 4th 2024 OpenAI stopped all models with names such as "text-davinci-00x" (x=123).   (see: https://platform.openai.com/docs/deprecations).
Hence I searched through entire project for key word "davinci" and replace all of them to "gpt-3.5-turbo-instruct".
Additionally, since TOKEN LIMIT EXCEEDED error contains more than token limit error (since any other openai/network error all get concluded as TOKEN LIMIT EXCEEDED), I changed the Except clause in gpt_structure.py to print out the full error msg for better debugging

Issue #141 has many people recently report TOKEN LIMIT EXCEEDED error.
I discovered that the issue is because on Jan 4th 2024 OpenAI stopped all models with names such as "text-davinci-00x" (x=123). (see: https://platform.openai.com/docs/deprecations).
Hence I searched through entire project for key word "davinci" and replace all of them to "gpt-3.5-turbo-instruct".
Additionally, since TOKEN LIMIT EXCEEDED error contains more than token limit error (since any other openai/network error all get concluded as TOKEN LIMIT EXCEEDED), I changed the Except clause in gpt_structure.py to print out the full error msg for better debugging

Are there specific files, or a change that needs to be done through almost all files?

Issue #141 has many people recently report TOKEN LIMIT EXCEEDED error.
I discovered that the issue is because on Jan 4th 2024 OpenAI stopped all models with names such as "text-davinci-00x" (x=123). (see: https://platform.openai.com/docs/deprecations).
Hence I searched through entire project for key word "davinci" and replace all of them to "gpt-3.5-turbo-instruct".
Additionally, since TOKEN LIMIT EXCEEDED error contains more than token limit error (since any other openai/network error all get concluded as TOKEN LIMIT EXCEEDED), I changed the Except clause in gpt_structure.py to print out the full error msg for better debugging

Are there specific files, or a change that needs to be done through almost all files?

these 3

that thomas liang commit is by me so you can also just view the commit and changed files directly

@AurganicSubstance Thank you very much for your help! I did alter the files you changed and it seems to work now, I don't get the token error anymore. But is your simulation working? When I try to run I open the http://localhost:8000/simulator_home and when I run the simulation nothing happens on the page, it continues frozen and showing all characters with the same sprite. The terminal shows the simulation is running but in the webpage nothing happens, and If I try to click on something too see the details of the characters also nothing, and when I try to go back to the main page (simulator_home) I get an error, the page only loads a text saying "Please start the backend firs.".
According to the README the page http://localhost:8000/simulator_home should show the character moving and interacting while the simulation runs, but when my simulation runs the page doesn't change, neither does the replay when I try to access them, I click play and nothing happens. And every time my simulation ends, before I can enter another command, the terminal gives me this error:
Traceback (most recent call last):
  File "/Users/tiberio/Documents/Cesar School (Mac)/TCC/generative_agents/reverie/backend_server/reverie.py", line 468, in open_server
    rs.start_server(int_count)
  File "/Users/tiberio/Documents/Cesar School (Mac)/TCC/generative_agents/reverie/backend_server/reverie.py", line 401, in start_server
    with open(curr_move_file, "w") as outfile:
FileNotFoundError: [Errno 2] No such file or directory: '../../environment/frontend_server/storage/run1/movement/0.json'
Error.
Enter option: fin

Were you able to make it work?  I can provide some screenshots of the problems if you want.

I actually get the same error. I stopped working on it since authors seemed to have abandonned the project. And that s never a good sign for debugging

That's a pity, I wanted to do some testing with this project. But were you able to make the web server work? Like I said when I open the local website it looks static and while the terminal looks like things are happening in the web browser everything is stopped. Have you been able to run it with the website working? Where the characters move and you can see the interactions and all?

Same. I particularly wanted to run simulations as a test to see if this could be used to simulate social systems. If anyone has an idea of if others have built similar models, but that currently work, I would greatly appreciate it.

Same. I particularly wanted to run simulations as a test to see if this could be used to simulate social systems. If anyone has an idea of if others have built similar models, but that currently work, I would greatly appreciate it.

Interesting, i m looking for the same topic. I will try out a few similar projects in the near future maybe u can keep an eye on my repositories for reference

Same. I particularly wanted to run simulations as a test to see if this could be used to simulate social systems. If anyone has an idea of if others have built similar models, but that currently work, I would greatly appreciate it.

you can also check out my free Medium blog Shichengqi's Digest

Same. I particularly wanted to run simulations as a test to see if this could be used to simulate social systems. If anyone has an idea of if others have built similar models, but that currently work, I would greatly appreciate it.

Interesting, i m looking for the same topic. I will try out a few similar projects in the near future maybe u can keep an eye on my repositories for reference

Will definitely do that. Keenly interested :)

have you add this code in reverie.py ligne 400
curr_move_path = f"{sim_folder}/movement" if not os.path.exists(curr_move_path): os.makedirs(curr_move_path) curr_move_file = f"{sim_folder}/movement/{self.step}.json" with open(curr_move_file, "w") as outfile: outfile.write(json.dumps(movements, indent=2))

you can check my pull request's details

My reply is solution for this error on comment
Traceback (most recent call last):   File "/Users/tiberio/Documents/Cesar School (Mac)/TCC/generative_agents/reverie/backend_server/reverie.py", line 468, in open_server     rs.start_server(int_count)   File "/Users/tiberio/Documents/Cesar School (Mac)/TCC/generative_agents/reverie/backend_server/reverie.py", line 401, in start_server     with open(curr_move_file, "w") as outfile: FileNotFoundError: [Errno 2] No such file or directory: '../../environment/frontend_server/storage/run1/movement/0.json' Error. Enter option: fin
I think ...


Use webpack to bundle sources into one file

Recommended to use webpack to bundle sources into one file to improve speed: https://code.visualstudio.com/api/working-with-extensions/bundling-extension

Useful resource to implement this: https://github.com/microsoft/vscode-extension-samples/issues/191


Update README.md

see checkbox

Fixed with https://github.com/wildland/ember-bootstrap-controls/pull/121#pullrequestreview-96691949


dispatcher, raft: test errors

[Current coverage][cc-pull] is 53.81%

Merging [#1043][cc-pull] into [master][cc-base-branch] will decrease coverage by <.01%

@@             master      #1043   diff @@
==========================================
  Files            75         75
  Lines         11660      11660
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6276       6275     -1
- Misses         4480       4489     +9
+ Partials        904        896     -8

[][cc-pull]

Powered by Codecov. Last updated by [bd1c047...c97aa38][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/bd1c04747f49a4e30e04acdcc5bdb233b712c238...c97aa38bf7f7c50a17aeffc4602132953af5d6b0
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1043?src=pr

LGTM

@LK4D4 L178 and L224 in storage_test also have a missing check on error for ProposeValue. Would you mind adding it as well in this PR?
otherwise LGTM

@abronan added, thanks!


Issue with the sign in

TypeError
o.map is not a function
TypeError: o.map is not a function
at WV (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:9686912)
at Ei (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4885894)
at Oa (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4897475)
at Ea (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4896689)
at Ca (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4896303)
at Es (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4945702)
at _c (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4931630)
at bc (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4931558)
at vc (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4931421)
at ic (http://localhost:8080/assets/cvat-ui.2550f8a90bec8e109359.min.js:2:4928256)
I try to open cvat for use with Chrome or Microsoft Edge browser, through the portle localhost:8080 as i was doing minutes before and suddenly the errors below occur :
**Could not send logs to the server
 405 Not Allowed  405 Not Allowed nginx        **
or
**Could not receive server schema**
Cannot convert undefined or null to object**
or
**Could not check authentication on the server
Open the Browser Console to get details**
or
**Could not login on the server
Bad Gateway** (from console -> Failed to load resource: the server responded with a status of 502 (Bad Gateway))
CVAT version
Server:
Core: 15.3.0
Canvas: 2.20.10
UI: 1.67.0

Try to build the latest release without any modifications fisrt.


Fix a crash issue when connection to PD is not stable

What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tiflash/issues/7407
Problem Summary:

The grpc streaming client's Finish() method can not be called more than once. But the keepalive background task may not be able to unregister from the pool when the connection to PD is unstable. If the method is called twice, it cause crash

What is changed and how it works?

Avoid grpc streaming client in etcd session calling Finish() more than one time
Use advertise-addr as S3GCOwner campaign id so that other TiFlash node can connect to it correctly when deployed along with tidb-operator
Sleep for a while before next campaign when connection to PD is broken

Check List
Tests

[x] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

Fix a crash issue when the connection to the PD server is not stable

/run-all-tests

/merge


Where to see the recorded video of CodedUI Tests using vNext Build?

Hi all,
I have created .testsettings file with Video Recorder and System Info and pointed it to "Run Settings File" in Run Functional test task. I am able to see the "SystemInformation.xml" attached to the test result of the test case. But i am not able to find the video recording either in the test result as well in the test case.
Please help me to find where the video is located.

@Selvaraj1989 can u attach the test settings? you should see the video in for each test case (test results). do u see this for failed test results?

Hi @acesiddhu , please find attached the test settings file and i am able to see only the SystemInformation.xml file only attached with the failed test case.
Test Result Attachment Screenshot:

TestSettings.txt
Thanks
Selvaraj C

@Selvaraj1989 I see
in the settings. Did this test failed? this will create video for failed test case only

Saw your comment about the failing test. Let me try this out. Are you using vsts or tfs on prem? if it is TFS which version?

@acesiddhu Yes, the test case got failed and i am not able to see the video recording.
I am using TFS 2015 Update 3 and i am running the automated tests using vNext build.
Thanks
Selvaraj C

@Selvaraj1989 what is the OS you are using. if this is a server SKU did u enable Desktop experience

Check this blog for pre reqs
https://blogs.msdn.microsoft.com/rubel/2009/11/25/recording-video-of-desktop-while-testing-through-test-runner/
Desktop experience is needed for all server SKUs. Also the test agent should be configured as process in such cases

I am closing this issue. Let me know if the above links doesn't help. I tried locally and things were working for me.


Remove X-Content-Security-Policy

Fixes #59
All delete PRs are the best PRs 😀

Coverage remained the same at 100.0% when pulling c0f6a04bd54998759ae0bfd9cd51a175a30c0c99 on bazzadp:x-csp into 0632c030503c59f3f3911b458da9ff156361e32b on GoogleCloudPlatform:master.

On second though, I'm happy to remove this.