tmp: test clang-tidy

Just testing, don't merge.

clang-tidy results on my local machine.
❯ clang-tidy -p build/ -export-fixes /tmp/clang-tidy-result/fixes.yaml src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp
33073 warnings generated.
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:32:14: warning: invalid case style for function 'getGateModeName' [readability-identifier-naming]
const char * getGateModeName(const GateMode::_data_type & gate_mode)
             ^~~~~~~~~~~~~~~
             get_gate_mode_name
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:144:5: warning: uninitialized record type: 'p' [cppcoreguidelines-pro-type-member-init]
    VehicleCmdFilterParam p;
    ^
                           {}
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:156:5: warning: uninitialized record type: 'p' [cppcoreguidelines-pro-type-member-init]
    VehicleCmdFilterParam p;
    ^
                           {}
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:424:59: warning: narrowing conversion from 'double' to 'autoware_auto_control_msgs::msg::LongitudinalCommand_::_acceleration_type' (aka 'float') [cppcoreguidelines-narrowing-conversions]
    filtered_commands.control.longitudinal.acceleration = stop_hold_acceleration_;
                                                          ^
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:537:37: warning: narrowing conversion from 'double' to 'autoware_auto_control_msgs::msg::AckermannLateralCommand_::_steering_tire_angle_type' (aka 'float') [cppcoreguidelines-narrowing-conversions]
  cmd.lateral.steering_tire_angle = current_steer_;
                                    ^
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:540:35: warning: narrowing conversion from 'double' to 'autoware_auto_control_msgs::msg::LongitudinalCommand_::_acceleration_type' (aka 'float') [cppcoreguidelines-narrowing-conversions]
  cmd.longitudinal.acceleration = stop_hold_acceleration_;
                                  ^
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:555:35: warning: narrowing conversion from 'double' to 'autoware_auto_control_msgs::msg::LongitudinalCommand_::_acceleration_type' (aka 'float') [cppcoreguidelines-narrowing-conversions]
  cmd.longitudinal.acceleration = emergency_acceleration_;
                                  ^
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:618:43: warning: the const qualified parameter 'request_header' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  const std::shared_ptr<rmw_request_id_t> request_header,
                                          ^
                                         &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:619:78: warning: the const qualified parameter 'request' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  const std::shared_ptr<tier4_external_api_msgs::srv::SetEmergency::Request> request,
                                                                             ^
                                                                            &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:620:79: warning: the const qualified parameter 'response' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  const std::shared_ptr<tier4_external_api_msgs::srv::SetEmergency::Response> response)
                                                                              ^
                                                                             &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:638:60: warning: the const qualified parameter 'req_header' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  [[maybe_unused]] const std::shared_ptr<rmw_request_id_t> req_header,
                                                           ^
                                                          &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:639:75: warning: the const qualified parameter 'req' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  [[maybe_unused]] const std::shared_ptr<std_srvs::srv::Trigger::Request> req,
                                                                          ^
                                                                         &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:640:59: warning: the const qualified parameter 'res' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  const std::shared_ptr<std_srvs::srv::Trigger::Response> res)
                                                          ^
                                                         &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:650:60: warning: the const qualified parameter 'req_header' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  [[maybe_unused]] const std::shared_ptr<rmw_request_id_t> req_header,
                                                           ^
                                                          &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:651:75: warning: the const qualified parameter 'req' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  [[maybe_unused]] const std::shared_ptr<std_srvs::srv::Trigger::Request> req,
                                                                          ^
                                                                         &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:652:59: warning: the const qualified parameter 'res' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
  const std::shared_ptr<std_srvs::srv::Trigger::Response> res)
                                                          ^
                                                         &
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:672:22: error: method 'checkExternalEmergencyStop' can be made const [readability-make-member-function-const,-warnings-as-errors]
void VehicleCmdGate::checkExternalEmergencyStop(diagnostic_updater::DiagnosticStatusWrapper & stat)
                     ^
                                                                                const
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp:196:8: warning: function 'vehicle_cmd_gate::VehicleCmdGate::publishControlCommands' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
  void publishControlCommands(const Commands & input_msg);
       ^
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:381:22: note: the definition seen here
void VehicleCmdGate::publishControlCommands(const Commands & commands)
                     ^
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp:196:8: note: differing parameters are named here: ('input_msg'), in definition: ('commands')
  void publishControlCommands(const Commands & input_msg);
       ^                                       ~~~~~~~~~
                                               commands
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp:214:27: warning: function 'vehicle_cmd_gate::VehicleCmdGate::filterControlCommand' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
  AckermannControlCommand filterControlCommand(const AckermannControlCommand & msg);
                          ^
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp:506:41: note: the definition seen here
AckermannControlCommand VehicleCmdGate::filterControlCommand(const AckermannControlCommand & in)
                                        ^
/home/kenji/autoware/src/universe/autoware.universe/control/vehicle_cmd_gate/src/vehicle_cmd_gate.hpp:214:27: note: differing parameters are named here: ('msg'), in definition: ('in')
  AckermannControlCommand filterControlCommand(const AckermannControlCommand & msg);
                          ^                                                    ~~~
                                                                               in
Error opening output file: No such file or directory

How to use the clang-tidy-pr-comments-manually workflow added by https://github.com/autowarefoundation/autoware_common/pull/126
Wait for the build-and-test-differential workflow to be completed.
Click Details of any job of the build-and-test-differential.

Then, click Summary.

I assume that now you are on https://github.com/autowarefoundation/autoware.universe/actions/runs/3406380887 now.
Then, wait for the clang-tidy-differential workflow to be completed and the artifacts to be generated.

Trigger the clang-tidy-pr-comments-manually workflow
Open https://github.com/autowarefoundation/autoware.universe/actions/workflows/clang-tidy-pr-comments-manually.yaml and click Run workflow.
Input the run ID<PHONE_NUMBER>) or the URL (https://github.com/autowarefoundation/autoware.universe/actions/runs/3406380887 or https://github.com/autowarefoundation/autoware.universe/actions/runs/3406380887/jobs/5665027805) as a user input, and click Run workflow.

After the workflow is completed, the bot will comment on the pull request.

FYI @xmfcx


remove comments for upcoming 0.2.0 version

Purpose

Remove comments that address features only available with version 0.2.0

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[x] Documentation content changes
[ ] Other... Please describe:

Other Information

Closed due to issue with productive_use


Hello, doenerium6969!

This individual is a notorious scammer and fraudster involved in stealing money from innocent people. Be extremely cautious when dealing with him! He uses malicious tools such as dualhook to exploit and hack his victims.
Origin: Egypt
Discord Name: Zoher

Get all his information here!
telegram: D_E_V_3


More alignment questions

@RomanPlusPlus added the questions.

@kaustubhdhole Thank you very much!
May I ask you to reword 2 older questions, as proposed by tra38? I wanted to do it myself, but the PR was approved before I did it.

@RomanPlusPlus added those two!

@kaustubhdhole Thank you!

@nfiedel please review these additional questions - to be added with PR #195

@kaustubhdhole We are now requesting that task authors please include an explicit section in the README.md file called "data source", listing exactly where you got your data from (or explicitly state that you made it up yourself). Many thanks!

@nfiedel could you please review these and confirm them with a formal accept if they look good to merge.

Okay @Sohl-Dickstein - I removed the ambiguous questions.

I got rid of the variations on the deleted religion question, for different faiths. Let me know if you have concerns! Otherwise, looks good! Merging now.


Move from double quotes to single quote to reduce escaping

Changed all double quotes in protocol to single quote. This reduces tons of escaping and makes everything much more readable.
When checking other tools like gremlin-console - they are also using single quotes, as it is supported by groovy.

I have made a new org and forked the repo at https://github.com/grammes-go/grammes. Feel free to redirect PRs there and reach out if you'd like to contribute


Make setup works like data

In the RFC https://github.com/vuejs/rfcs/blob/function-apis/active-rfcs/0000-function-api.md#state

This works exactly like data() - msg becomes a reactive and mutable property

Changes

Plain values returned  in setup() become reactive automatically
Unit test added

Fixed


Sending serial number to api

added code to pass serial number to api, when connecting to panorama.

Sorry for the slow reply to this. Thanks for submitting.
I a little confused about why this is needed. We use the 'target' parameter to redirect the API call to the firewall itself, so we're not asking Panorama for the PCAP. We're actually asking the firewall, just via Panorama, meaning the serial shouldn't be necessary because the serial is in the 'target' param.
Does this solve a problem that you've found? Can you describe the issue or usecase that this solves?

Closing due to no reply. Please feel free to re-open if you'd like to proceed.  Thanks!


fix the comments for --public-testnet arg

fix the comments for --public-testnet arg

I've got some other command line option changes as we discussed in issue #667 So I'm going to close this PR, but I willl refernfe your issue. Thank you.


Reduce model logging verbosity

Now that we can use the logger (PR #129) , we see that info level is too verbose for the model for these methods in the model.
JIRA (SKA): SAR-155

Thanks, this will help a lot with the very verbose logging.


docs: request for triager role for ulisesGascon

Hi again! :-)
I have read and understood the project's Contributing guide.
I also have read and understood the process and best practices around Express triaging.
I request for a triager role for the below orgs:

jshttp
pillarjs
express

Hi @UlisesGascon it looks like you and one other member were lost in the shuffle adding triagers when the process was in flux and changed hands. If you are still interested in being added, please ping me and I'll get you added ASAP,. Appologies.

Hi @dougwilson! Don't worry 😉
I still interested 💪

Awesome to hear @UlisesGascon ! And once again apologies for your request getting lost in the abyss 🤣 You should have invites for membership to all three GitHub organizations. Welcome aboard 🚢 . I'm closing this PR as we moved to GH teams for record keeping is all, soon to be surfaced through API to the public too :) !


React JSX optimizations

Babel supports two JSX optimizations when using React 0.14. https://babeljs.io/blog/2015/03/31/5.0.0/#react-optimisations

Constant Elements
Inlining React.createElements

Any plans to support these sort of optimizations in TypeScript?

Note that it support is through a plugin and not natively:
require("babel").transform("code", {
  optional: ["optimisation.react.constantElements"]
});

I don't think we're going to port over all of the advanced JSX emit options. People who really need them (which should realistically be very few) can use --jsx preserve and configure their JSX transformer appropriately.
Hopefully we can get a pluggable emitter figured out in the near future so we can re-use some of these techniques.


Test and Research Question Classification

when the input is a question, the reply shouldn't begin with what the input was.

some more question classification/detection happening here https://github.com/mrzl/ECO/issues/160

dataset containing 400.000 similar question pairs: 800.000 questions that could be used for training a CNN to detect questions automatically: https://data.quora.com/First-Quora-Dataset-Release-Question-Pairs


Issue #63: Added Schema class

Added Schema class and updated the classes which are using schema.

@chenlica @JavierJia .. Please review the code

It looks good to me in general.  To make it "complete," please add a test case for the Schema class.

@chenlica .. Added the test cases. Please do a quick review.

I added a minor comment.  After taking care of it, please go ahead to do the merge.

Made the suggested changes.. Merging with the master branch


Return return value in gfo.execute_sql

Now it isn't returned but it would be useful to do so for cases where the data doesn't need to be returned as structured data (= Dataframe), ex.

return value of update statements
queries on metadata tables
query to check if spatial index exists

After further investigation doesn't seem possible/useful after all...


[DOC] Cross Cluster Search isn't covered by docs

What do you want to do?

[ ] Request a change to existing documentation
[x] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Cross Cluster Search (CCS) isn't covered by docs. It should include:

How to configure remote clusters
How to verify connection and configuration
How to make a CCS query
Limitations
etc

It is mentioned in PPL/Observability and slightly covered by security plugin doc, but it mostly covers how to configure permissions, rather how to configure remotes/CCS.
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

Thanks for entering this issue, @Yury-Fridlyand ! Would you mind taking a crack at the initial documentation? It looks like some of it is covered here (https://github.com/opensearch-project/sql/blob/main/docs/user/ppl/admin/cross_cluster_search.rst) but would be great to get complete coverage, as you say.

@praveensameneni - Do you know who might be able to support us with this update? Thanks!

Hi @ankitkala - We've made some changes to the cross-cluster search topic recently, and I came across this open PR on it. We moved the topic under the "Search" category, but didn't address the above items. We only addressed some feedback that we received from the community.
Do you want to provide some details that we can add to this topic after we merge these initial changes? https://github.com/opensearch-project/documentation-website/pull/6657. Thanks in advance.

How to configure remote clusters

https://opensearch.org/docs/latest/tuning-your-cluster/replication-plugin/getting-started/#set-up-a-cross-cluster-connection

Do you want to provide some details that we can add to this topic after we merge these initial changes?

I don't have a good reference to share around this. Let me collect the data and update here.


A stream blocks other queries to Sqlite

I was trying to use a stream() to SELECT some rows from an Sqlite database, ratelimit() it with Highland.js and process them one by one.
However all subsequent SELECTs to the database are paused: their promises neither throw errors, nor return anything. Also there is no debug output.
If this is due to how Sqlite works, there should be a warning somewhere (at least in documentation).
In other case this should be fixed.
Note: I chose a stream because I want to avoid having to load the whole result into memory (could be quite large) and also because I need to rate-limit its processing: I am querying an external API for the records in the DB that are missing data from the API.

Yeah this is basically a limitation of how the node-sqlite3 driver works, it doesn't handle backpressure on large selects so everything is fetched into memory, the stream only exists to keep a consistent api with other dbs.
https://github.com/mapbox/node-sqlite3/issues/375
I could put a warning in the docs for this

I am sorry, but now I am confused: if everything is fetched into memory for a large select, why does streaming it blocks the following selects?


AccessDeniedException when a 0 users file is processed

We have a pipeline that produces multiple files with users and then sends them to the S3 bucket. Most of them are processed correctly but I receive an "AccessDeniedException" when the file has 0 users (only headers).
An error occurred (AccessDeniedException) when calling the Invoke operation: User ... is not authorized to perform: lambda:InvokeFunction on resource: arn:aws:lambda:eu-west-1:... because no identity-based policy allows the lambda:InvokeFunction action: ClientError
Is this the expected outcome or should it be changed? In my opinion, 0 processed users should return success as there were no data points affected but I might be incorrect.

Thanks @macolko
We've applied the changes yesterday but we are receiving these errors now:
"Encountered errors processing some users: [{'type': 'no attributes provided', 'input_array': 'attributes', 'index': 2}..."
"Encountered error for user chunk. {"message":"Valid data must be provided in the 'attributes', 'events', or 'purchases' fields.",..."
I believe this is due to the empty value attribute for a user, for example:
external_id,attribute1
"user123","abc"
"user456",
"user789","def"

This would log an error for "user456" but would still update the values for the other users (fortunately). Also, the "Processed N users" message seems to be affected by this.
The documentation mentions that empty valued attributes will be ignored. Any suggestion or should we wait for the next release?

Hi!
This is just a warning from Braze that no attributes were supplied and the user was not updated. It does not affect all other user updates but it will reduce the Processed Users value because the values for the user were not updated.
If you want to get rid of this error, feel free to update your code with the v<IP_ADDRESS> release that will omit sending users with no updated attributes.

Release v0.1.4 consolidates these issues.


Peter solution

Completion 5/5
Comprehension 4/5
Feel very comfortable with the subject matter. Cool assignment!

:+1:


Paint Pennsylania NLCD Tiles

Overview
Adds:

A painting class to paint tiles from the ingested Pennsylvania NLCD raster. It picks up colors from the original GeoTIFF's embedded values. It has a number of comments to help follow the code.
make commands to allow for painting
A tile toggle button to the front-end, and the ability to render locally generated tiles in the front-end when toggled on
Relevant new information to the README

Updates:

Minor readability improvements
Upgrade GeoTrellis to 2.0.0-RC1
Change default make to also paint tiles
Conditionally run download-tif and ingest commands if their output doesn't already exist

Removes:

Unused imports from the ingest class

Connects https://github.com/azavea/civic-apps/issues/313
Notes
Once this PR is merged, I'll make a follow up that updates the README GIF with a new version that also showcases the painted tiles.
Maybe we up the version from 1.0 to something else? 1.1? 2.0?
I had to update the source TIF which was missing coordinate information to get the ingest and painting to work correctly (see discussion here: https://azavea.slack.com/archives/C049A6HC9/p1530903555000168). This new source TIF should be uploaded to S3 to replace the current one.
I should probably add the run condition to the make paint command as well so it is not extraneously run.
Testing Instructions

Checkout this branch
Get the updated source TIF from me
Run make and ensure it completes successfully
Run make server and ensure you can see the tiles by turning them on in the header

I'll set this up to test today! Looks like CI failed because it couldn't find one of the GeoTrellis dependencies when compiling.

Hmm. Maybe I should upgrade to RC2 which was released more recently and which I'm assured works the same.

Turns out GeoTrellis pre-releases are not stored on Maven Central, but the custom LocationTech repository. Added a resolver for that, and upgraded to RC2. Hopefully ready for another look 🤞

Hmm. Travis build timed out. Closing and re-opening PR to make it rebuild.

Travis keeps timing out at an npm stage. Not sure what's up with that.

LGTM!

One possibly quick update you could make to the the tiling class might be to clip it to the PA boundaries before making the tiles in order to remove the shadow extending beyond PA boundaries. Just realized the project has a geojson file containing the PA boundaries here -- https://github.com/azavea/geotrellis-collections-api-research/blob/master/app/js/pennsylvaniaBoundaries.json -- which is what's plotted as the outline.
Feel free to regard that as an enhancement, though -- if you don't do it for this step, you could suggest it as a potential next step in the blog post.

Thanks, I'll think about it. Another way of doing that would be to ignore the black cells in the source data and replace that with NODATA. Could be a nice "exercise for the reader".
Any recommendation on upgrading the version number?

Is this GIF an acceptable demo?

Is this GIF an acceptable demo?

Looks great!

Thanks for reviewing! I'll merge once green.


Audit: NFTFactoryContract Missing Error messages

There are no error messages in the “require” statements that may lead to confusion on the client side.

@vishaldantuluri Initially error messages were added, then later were removed to reduce the contract size.

@kishan79 yes that is correct

We need to include the short error msg.. Good practice to do


ENV/super: add shims_path helper method.

This allows us to stop repeatedly hardcoding this on macOS/Linux in formulae.

Review period will end on 2021-09-08 at 11:37:55 UTC.

To be clear on the intention here: is the idea to be able to use
ENV.shims_path

to refer to the shim prefix when doing inreplace in formulae?

Kinda. Yes but Superenv.shims_path instead.

Review period ended.


Error running the build-s3-dist.sh

Getting this error when trying to run the script to build out for some changes to the Lambda:
./build-s3-dist.sh wf-core-dev-templates
Staring to build distribution
export deployment_dir=/Users/robweaver/Projects/aws-transit-vpc/deployment
mkdir -p dist
cp -f *.template dist
Updating code source bucket in templates with wf-core-dev-templates
sed -i -e s/%%BUCKET_NAME%%/wf-core-dev-templates/g dist/transit-vpc-primary-account-existing-vpc.template
sed -i -e s/%%BUCKET_NAME%%/wf-core-dev-templates/g dist/transit-vpc-primary-account-marketplace.template
sed: dist/transit-vpc-primary-account-marketplace.template: No such file or directory
sed -i -e s/%%BUCKET_NAME%%/wf-core-dev-templates/g dist/transit-vpc-primary-account.template
sed -i -e s/%%BUCKET_NAME%%/wf-core-dev-templates/g dist/transit-vpc-second-account.template
Creating transit-vpc-poller ZIP file
Building transit-vpc-push-cisco-config ZIP file
/Users/robweaver/Projects/aws-transit-vpc/deployment/dist
virtualenv env
New python executable in /Users/robweaver/Projects/aws-transit-vpc/deployment/dist/env/bin/python
Installing setuptools, pip, wheel...done.
source env/bin/activate
pip install /Users/robweaver/Projects/aws-transit-vpc/deployment/../source/transit-vpc-push-cisco-config/. --target=/Users/robweaver/Projects/aws-transit-vpc/deployment/dist/env/lib/python2.7/site-packages/
Processing /Users/robweaver/Projects/aws-transit-vpc/source/transit-vpc-push-cisco-config
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/pr/59hffzcn3xn3rl2tv8tr27t00000gp/T/pip-req-build-If0il5/setup.py", line 4, in <module>
        from pip.req import parse_requirements
    ImportError: No module named req

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/pr/59hffzcn3xn3rl2tv8tr27t00000gp/T/pip-req-build-If0il5/
  adding: pip-10.0.1.dist-info/ (stored 0%)

Saw some references to this being a problem with pip version 10, so tried downgrading with no luck.

Was able to get around the issue by patching the setup.py as:
diff --git a/source/transit-vpc-push-cisco-config/setup.py b/source/transit-vpc-push-cisco-config/setup.py
index ca311f2..5caf36b 100644
--- a/source/transit-vpc-push-cisco-config/setup.py
+++ b/source/transit-vpc-push-cisco-config/setup.py
@@ -1,7 +1,14 @@
 # coding: utf-8

 from setuptools import setup, find_packages
-from pip.req import parse_requirements
+
+def parse_requirements(filename):
+    """ load requirements from a pip requirements file """
+    lineiter = (line.strip() for line in open(filename))
+    return [line for line in lineiter if line and not line.startswith("#")]
+
+    install_reqs = parse_requirements('requirements.txt')
+    reqs = install_reqs

 setup(
     name='transit_vpc_push_cisco_config',

Let me know if you need me to create a pull request - I don't see anything on the repo about how to contribute, so maybe this project has gone stale?

I had the same issue.
In my case, my workaround was:
diff --git a/source/transit-vpc-push-cisco-config/setup.py b/source/transit-vpc-push-cisco-config/setup.py
index ca311f2..027ba5d 100644
--- a/source/transit-vpc-push-cisco-config/setup.py
+++ b/source/transit-vpc-push-cisco-config/setup.py
@@ -1,7 +1,7 @@
 # coding: utf-8

 from setuptools import setup, find_packages
-from pip.req import parse_requirements
+from pip._internal.req import parse_requirements

 setup(
     name='transit_vpc_push_cisco_config',


[BUG]: Extensions get loaded multiple times

this one is really bizarre, but it was being caused by the @tiptap/pm module...

Should be fixed in 0.13.1!


testCaseRegex was removed

4b02798ea165784d1404be577a18ced10924a034 removed unityExplorer.testCaseRegex from the package.json.

It seems this has been fixed, but a release not yet created. @Florin-Popescu may you please create a new release when possible 😁 I've had to downgrade to keep my project working correctly.

Hey! I've been having terrible issues with npm since end of august, see npm/cli/issues/4028. I can't package the extension so I am stuck for the moment.

Turns out I was able to publish from a Raspberry Pi and not from my typical workstation. Try the update and let me know.

Sounds like you are hot-discovering the use-case for developing in containers :)

@jnz86 one day, when I'd have the time to set it up... Sure 😉
@NovaNekmit was this fixed properly? Can I close this?

The setting now works again, thank you.


Test cleanups

Some minor test fixes. This was prompted by pytest --help taking a long time now that I have setup ggshield as a global git hook.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e787423) 91.92% compared to head (5e7de75) 91.90%.
Report is 4 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   91.92%   91.90%   -0.02%
==========================================
  Files         158      158
  Lines        6622     6623       +1
==========================================
  Hits         6087     6087
- Misses        535      536       +1

Flag
Coverage Δ

unittests
91.90% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Useref should ignore the comments in blocks

<!-- build:js(.) scripts/vendor.js -->
    <!--script src="bower_components/jquery/dist/jquery.js"></script-->
    <!-- <script src="bower_components/jquery-ui/jquery-ui.js"></script> -->
    <script src="bower_components/angular/angular.js"></script>
    <script src="bower_components/angular-ui-router/release/angular-ui-router.js"></script>
<!-- endbuild -->

In development neither jquery or jquery ui are loaded
However useref will still add these files to the build

Original issue jonkemp/gulp-useref#100

Closed by #47

Ho @manuelcabral, I'm recognizing this issue - useref should not aplly to commented assets but does - is still present?
https://github.com/digisfera/useref/issues/44#issue-78280133

<!-- build:js(.) scripts/vendor.js -->
    <!--script src="bower_components/jquery/dist/jquery.js"></script-->
    <!-- <script src="bower_components/jquery-ui/jquery-ui.js"></script> -->
    <script src="bower_components/angular/angular.js"></script>
    <script src="bower_components/angular-ui-router/release/angular-ui-router.js"></script>
<!-- endbuild -->

In development neither jquery or jquery ui are loaded
However useref will still add these files to the build

Thank you!


Support workflows

The documentation says:

Note: The Local CLI does not yet support Workflows.

Please add support for workflows.

It's in the works.

any status or ETA on that?

Not that I know of no. This CLI is being superseded by a more feature-full CLI in the future (probably sometime this year). That new CLI is likely where the Workflow support will land. Our blog and CircleCI Discuss is the best places to watch for when that happens.


Cryptography settings are ambigiuous with multiple private keys

I'd  like to propose an improvement for the settings screen inside Settings>Account Settings>Cryptography
Expected behavior
"My key" should show the name and email on the chosen key
Actual behavior
"My key" only shows "Key has been selected"
Steps to reproduce
This is a problem when you happen to have more than one private key.

Create two email accounts
Create two PGP keys, one for each
Choose the appropriate key for each account

It's far too easy to misclick and choose the wrong key, and there is no way to check which key was chosen. This is simultaneously:

a technical issue(the email will be signed by the wrong key),
a privacy issue(allows the recipient to connect purposefully isolated identities and get to know more email addresses of the sender),
a UX issue(you only get the information on which key was chosen when encrypting the email, and if you chose wrong, it is very confusing).

A patch would include querying Open Keychain to reveal the identity connected with the chosen key(unless K9 already stores that information) and putting the result of this query into "My key". If doesn't have to be 100% of the identity, just enough to make different identities distinct, as in "last 4 digits of the credit card"
Environment
K-9 Mail version: 5.206
Android version: Used: 5.1.1, but probably all are affected.
Account type (IMAP, POP3, WebDAV/Exchange): Any
label:enhancment
This ties into https://github.com/k9mail/k-9/issues/942

Dupe of https://github.com/k9mail/k-9/issues/942?

very related, indeed. this part requires an overhaul anyways, I've been working on that. closing in favor of #942


Copying files

After installing UltraUx I can copy files into Themes folder unsung file explorer but Files doesn't copy anything into Themes folder. Hot keys (keyboard shortcuts) still don't work and I couldn't make it work.

@1keyjee1 What version of Files do you have?


Synchronize test cases with sz-sdk-go

Pull requests:

https://github.com/senzing-garage/sz-sdk-json-type-definition/pull/35


Tahoma plattform for Somfy Covers and Senors

Description:
Successor of #8338.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#3574
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: tahoma

#tahoma
tahoma:
  username: "<your.tahoma.login.email>"
  password: "<your.tahoma.login.password>!"
  exclude: [BridgeHUEComponent, HueLampHUEComponent, PodComponent]

cover:
  platform: tahoma

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

please add yourself to https://github.com/home-assistant/home-assistant/blob/dev/CODEOWNERS for the new files

Please fix your branch. I have a pending review on this PR that I'd like to finish, without redoing it.

But if it's a hassle to fix the branch to be able to continue on this PR, it's OK to make new branch and open a new PR. I can copy my comments to the new PR in that case.

now everything seems o.k.?

No, if you look at the changes tab there are 185 changes files.

shell i create a new pull request? @MartinHjelmare

You can but you need to make sure that the new branch is started from a freshly synced dev branch. Then add your changes, ie new files for tahoma.

okay


[Feature] Image preprocessing and new Dataset API

Current Dataset API is very limited and has a few sufficient limitations. We have no goal to copy-paste Keras and TensorFlow Dataset API now, but a few ideas could be adopted here.
First of all, we need in

Basic image preprocessing (resize, crop)
Currently the whole dataset is located in heap memory. We need to implement an alternative with batch-by-batch loading into RAM
Ability to write custom data loaders (it's now implemented and should not be broken in this PR)

So, the basic Image Preprocessing DSL is provided. I close this issue


Improve performance and correctness of Tiling Patterns

Fixes #6496
Fixes #5698
Fixes #1434
Fixes #2825 (the rendering issues have been fixed, but there are still spikes in memory usage (which is very problematic on low-memory devices), this is probably caused by https://crbug.com/448150, and possibly the same issue as https://github.com/bp74/StageXL/issues/214?. I think that we can work around this memory spike by introducing an artificial delay in our task scheduler to give the browser a chance to GC the temporary CanvasGradient patterns - this could be added in a separate PR).

/botio-linux preview

Amazing, thank you for looking into this! I can confirm that all four issues are fixed with this PR. The PDF file in the last issue is rendering much faster (almost instantly for me) now and I don't really experience the mentioned memory spike, so I think we're fine there too.
/botio test

@timvandermeij I've found the memory spike in Chrome (on Linux), using the following steps:

Download the PDF file from https://github.com/mozilla/pdf.js/issues/2825#issuecomment-24234561 (to make sure that rendering happens at once, without waiting for network)
Open the PDF.js PDF Viewer.
Open the task manager of Chrome (Shift + Esc) and keep an eye on the tab with PDF.js
In the Open PDF dialog, select the PDF file that you downloaded from step 1.
While the PDF is being rendered, memory usage shoots up to over 1 GB. Shortly after completion of rendering, the memory usage drops again.

The test previously failed with observable differences because I accidentally used Math.max instead of Math.min
I have updated the PR with the fix. When I ran the tests locally, 3 tests failed (chrome-High-Pressure-Measurement-WP-001287-page3,  chrome-colorkeymask-page1, chrome-issue2177-eq-page1). These failures are caused by slight differences in rounding errors (previously we manually calculated the scale, now most of the scale calculations is delegated to the canvas). I don't see any visual problems with the rendering, so you have to regenerate the refs for these three test cases after merging this PR.

/botio test

@Rob--W Do you have time to rebase this PR and fix the comments above? It looks like a nice patch to have as it fixes quite some open issues.

@timvandermeij Last month I discussed this PR with @yurydelendik over IRC (http://logs.glob.uno/?c=mozilla%23pdfjs&s=13+Nov+2015&e=13+Nov+2015&h=6606#c41194) and the conclusion is that the implementation can be improved. This change is a significant refactor of the tiling and drawing code, and I haven't allocated time for that task yet. Of course, I can rebase and fix the nits that are mentioned above (so that we have the desired functionality) and submit a new PR for an improved version.
If @yurydelendik does not have any objections against merging this PR (with the nits fixed), then I will rebase and update the PR so you can merge it.

Given that this PR completely fixes a handful of issues, and also improves a few more, could we perhaps now reconsider landing this as is (with the last round of review comments addressed)!?
It seems to me that while it's certainly possible to improve the general implementation (as outlined in the IRC discussion), this PR would still be a nice improvement of the pattern handling.

I agree with the above. I do not know enough of this part of the codebase to review it, but if it's an improvement (perhaps not a perfect solution yet), I would also like to have this landed. It can always be improved later on.

@Rob--W After addressing the review comments, the class TilingPattern could maybe look like this:
https://gist.github.com/janpe2/beb4a18d73dffb250830e7ddc41bd461
I have tested lots of PDFs and this would fix as many as 14 issues.

Given that there hasn't been any response to https://github.com/mozilla/pdf.js/pull/6606#issuecomment-455872532 for almost a month, and that the issues keep on coming, I cannot see the harm in @janpe2 (provided you want to, of course) finishing this PR so that it can land.

I'm slowly working on this.
Neither my PR nor @janpe2's PR are suitable for merging, because of one glaring issue (which I will describe below). I locally revived the patch when https://github.com/mozilla/pdf.js/pull/6606#issuecomment-455872532 was posted, but was concerned about the unaddressed issues (in https://github.com/mozilla/pdf.js/pull/6606/files/fad83a7deb2d3cb1b6597f11e4e5ecfd7e9a3c94#r44318712).
To check whether there are any potential regressions, I was looking for a test case (PDF) that has a pattern where the xstep that is smaller than the bounding box's width (or equivalently, ystep and height), AND that repeats that pattern.
In the current version of the PR, the width/height of the pattern canvas is set to the xstep/ystep (whereas it was previously set to the pattern's bounding box). The expected common case is where xstep > width (or ystep > height). This is rendered well in the current PR.
In the case where xstep < width (or ystep < height) AND the pattern is repeated, part of the pattern may be cut off.
For example, a V pattern with the xstep set to half of its width.
Base pattern:
\/

Expected rendering of repeated pattern (recall xstep = half of width):
\XXXX

Actual rendering if truncating pattern width to xstep:
\\\\\

To check whether the issue is real, and to confirm a fix, I need an actual test case (PDF). I'm probably going to create such a test case by hand, since searching for an existing test case with this issue is like looking for a needle in a haystack.

@Rob--W
patterns-Xstep5.pdf
patterns-Xstep10.pdf

@Rob--W
patterns-Xstep5.pdf
patterns-Xstep10.pdf
patterns-Xstep7.pdf

This is what the standard says about overlapping tiles (section <IP_ADDRESS>):

The order in which individual tiles (instances of the cell) are painted is unspecified and unpredictable; figures on adjacent tiles should not overlap.

However, Acrobat Reader draws them with no problems.

If someone is interested, here are the issues that would be fixed by my proposed patch:
#6496
#1434
#2825
#8264
#7731
#9763
#9927
#9928
#9922
#8579
#9665
#8083
#8373
Bugzilla-1467424

@THausherr  Thanks for sharing these test cases. That really saves me some time!
@janpe2  Thanks for checking those. I expect that the final version of this PR will fix those bugs, and avoid the regression that I described in https://github.com/mozilla/pdf.js/pull/6606#issuecomment-464784033

Here's another. The shape to the top and to the right should be "pointy" and not flat when rendering is correct.
gs-bugzilla690487.pdf
The file from #9770 does also have a "too small" step.
@Rob--W your comment from a day ago also showed that there's a bug in PDFBox 😭

FYI I was and am still traveling, and will not update this PR before 16 March. Thanks for your patience.

I have updated the PR, and while addressing the review I also tried to minimize the changes compared to the current master. I did not fix the issue that I described in https://github.com/mozilla/pdf.js/pull/6606#issuecomment-464784033 because the issue already existed before my PR (so it is not a regression), and addressing it is complicated and may result in worse performance.
Also, the specific test case that I described is not a valid PDF: Tiling patterns may overlap, but the figures on the pattern cells are not allowed to overlap by the PDF spec.
The test that I added passes, as well as the ones that I referenced in the original first comment on this PR. Please test whether this fixes other issues (@ contributors on this thread) and merge it if it looks good (@timvandermeij ).

Thank you for fixing this up! I see that Travis reports some linting issues; could you fix those? For line 412, you should be able to use the shorthand return { scale, size, }; instead to solve those errors.

@timvandermeij Done.

/botio test

I'm just wondering, should we add a test case for commit https://github.com/mozilla/pdf.js/pull/6606/commits/c4c92da57143ab39fe1c78760206a0e67a21e876 or is that also covered by the test case you have already added in another commit here?

The test case of the third commit already covered the second patch mostly: The PDF consists of 63 patterns with bbox [0 0 596 842] (same as page size), and xstep = ystep = 2876. Before my second patch, the result would be blurry in Firefox and cause an out-of-memory crash in Chrome. With the patch, the rendering is sharp.
I added a new test anyway, a minimal file that tests the relevant edge cases that caused this bug. It also features another change compared to previous code: I'm using Math.max(MAX_PATTERN_SIZE, realOutputSize) instead of Math.min, because otherwise the pattern would be clipped if the output canvas size is larger than MAX_PATTERN_SIZE (e.g. when the user uses 400% zoom).

/botio test

I updated the first comment with a list of bugs that can be closed once this is merged, from the list of issues with the 4-tiling-type or 4-shading-pattern label, or were listed in an earlier comment:

https://github.com/mozilla/pdf.js/labels/4-tiling-type
https://github.com/mozilla/pdf.js/issues?q=is%3Aopen+label%3A4-shading-pattern+-label%3A4-tiling-type
https://github.com/mozilla/pdf.js/pull/6606#issuecomment-465224776

/botio test

/botio-linux preview

/botio makeref


Application terminates when windows store wants to update it

Environment
Windows build number: Microsoft Windows [Version 10.0.19042.804]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce
Leave the app running a process overnight when an update is available
Expected behavior
The application does not terminate to update, and only updates when the user closes the app.
Actual behavior
The application seems to have terminated overnight to run an update.

+1 I am also seeing this issue.

See issue #3915.

Alas, this is a /duplicate of #3915.

@MSFT: I'm commenting on this one because my own issue (the one that this is marked as a duplicate of) was limited to collaborators because it was "being too heated".
Any updates on roadmaps or ideas to fix this? I've disabled auto updates, but it seems to somehow have been enabled again without my consent - I just came back to the office to see all my WSL sessions terminated because WSL had been updated via the Store...
In my opinion: until this issue is resolved, the Microsoft Store really isn't suitable to distribute productivity applications like WSL or the Terminal. Can you give us some insight into what you're planning to do about this, or if you just recommend us installing the Terminal and WSL outside the Store instead (potentially losing the easy access to updates altogether)?

I can't officially share any updates, but we're in touch with folks from the Store team and the App Catalog team, and we're working on a solution. We'll make sure to update that thread when there's something to share. Since this requires OS-side work, the work moves a little slower - the solution can't just be scoped to the Terminal, it's got to be something that provides a potential solution for any app that wants it (but doesn't break apps that don't).

Thanks for the quick response @zadjii-msft, good to hear that things are happening at least - that gives some hope for the future ❤


Reimplement the cargo func run command.

This PR reimplements the cargo func run command to use cargo run to
generate a script root and then func host start from the Azure Functions Core
Tools to run the application natively.
This removes the requirement for using Docker to build and run the application
locally.
Additionally, the cargo func build command has been removed in favor of cargo build.

Weird, with the recent changes it shouldn't even be using go to build 🤔.  I wonder if it's a cached CMake thing since it previously configured with go to build BoringSSL.  Since switching to OpenSSL, the golang dependency was removed.

I didn't realize it was no longer using BoringSSL. That is truly weird. I'll take a look again to see what could possibly be the issue.

@rylev I've pushed up the requested change and it dismissed your review (I've since turned that off; we don't use that for the .NET Core repos either).  Would you mind taking a look at the new commit and signing off again?  Thanks!

Ping @rylev 😁

@peterhuene trying to get it to run now. Just wanted to make sure the weird thing I saw with grpc wasn't an actual issue.

Cool! The Windows fixes PR has all the changes if you want to checkout that one to test in one go.


Fix link to url and typo in readme

Describe the pull request:
Fix link to url and typo in readme

Hello, appreciate the PR and pointing out the issues, but because this is my personal portfolio website Im not accepting public PRs


KAFKA-12263: Change MockClient.RequestMatcher to RequestAssertion

As described in KAFKA-12263, this PR refactors MockClient.RequestMatcher to become MockClient.RequestAssertion using assertions in the implementations.

@hachikuji since you raised the JIRA perhaps you could review this to check it's what you were after?

@hachikuji any chance you could take a look, since you opened KAFKA-12263?

@hachikuji any chance you could review this?


Forests are hidden by leisure areas

I don't know why but there are five _ "layout" -> "visibility" -> "visible" _ left to remove, I'm sure there weren't any when I pushed the commit to #55. Sorry. Can I do it in this issue, or do you prefer another way?

I decided to create the natural_wood layer (extracted from the natural layer match expression) and to place it above the landuse, amenity and leisure layers. We can strongly think that the woods must be above these three types of layers.
For the landuse layer, I have a little proof here :

I don't know why but there are five _ "layout" -> "visibility" -> "visible" _ left to remove, I'm sure there weren't any when I pushed the commit to #55. Sorry. Can I do it in this issue, or do you prefer another way?

Sure, no problem.

I decided to create the natural_wood layer (extracted from the natural layer match expression) and to place it above the landuse, amenity and leisure layers. We can strongly think that the woods must be above these three types of layers.

Sounds good to me.


Add Bingo Game

Fix #416 , I add the Bingo Game.

solved the conflict. And then try to push.

I resolve it, @iamrahulmahato  . Now check it.

not solved


Field hint text

Is your feature request related to a problem? Please describe.
We're creating something for clients and I'm sure they're not going to know what the variety of fields actually mean. I know the label doesn't have to match the name but I think a description/hint/help option would benefit the content author to know what that particular field does. Such as why there's a title & linktitle field, or description & summary field, or helpful information relating to the field, or even links to documentation more thoroughly describing the field.
Describe the solution you'd like
- name: "page"
  fields:
    - {
      label: "Title",
      name: "title",
      widget: "string",
      help: "The title of the page used in the hero & social meta info"
    },
    - {
      label: "Link Title",
      name: "linktitle",
      widget: "string",
      help: "Title used when linking to this page"
    }

Describe alternatives you've considered
I can create a section on our own site for documentation describing the various fields, or use CSS :after pseudos to hack in some help text, but as far as I can tell this isn't a feature just yet.

Try using the hint property: https://www.netlifycms.org/docs/widgets/#common-widget-options

Wow I guess my eyes skipped down to "default widgets". I knew I had to be missing it somewhere. Thanks for pointing this out.


chore(pingcap/tidb): disable some mergeCI on master on idc-jenkins

related to https://github.com/ti-community-infra/configs/pull/759

/lgtm
/approve


LUKS: add support for it in osbuild

Enable creating images that use LVM and LUKS.

Done via #879


Sample cs-winui miss languages after it is published as a package

Describe the bug
I am following the cs-winui sample project ( https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/ResourceManagement/cs-winui) to add globalization support to my project, but I found it always displays the default language set in package.manifest after building a package and running it. And I tried cs-winui sample project  and found the same problem, so I come to open this issue to ask for help.
When I run the sample cs-winui ( https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/ResourceManagement/cs-winui) in Visual Studio (mine is VS 2019) - after clicking "Override Language" button, I can see the German text is displayed as expected.

However, after I publish it as a sideloading package and install it - right click on package project, select Publish > Create App Packages ... .

When I click "Override Language" button, it shows me the text in English.

It seems that resources in German is gone after packaging.  Is this a bug or any additional configuration is needed ? And if this is a known issue, is there any workaround I could apply?
Steps to reproduce the bug

Pull https://github.com/microsoft/WindowsAppSDK-Samples/tree/main/Samples/ResourceManagement/cs-winui
Build a sideloading package in Visual Studio
Install and launch it
Click "Override Language" button

Expected behavior
The text in German should be displayed
Screenshots
No response
NuGet package version
1.0.0
Packaging type
Packaged (MSIX)
Windows version
Windows 10 version 21H1 (19043, May 2021 Update)
IDE
Visual Studio 2019
Additional context
No response

Actually my Windows display language and preferred language are both set to Chinese, and I added Resources.lang-zh-cn.resw as well. When clicking "Default Language" button, the text in Chinese is expected, but it still displays "English Sample" text. This behavior is same in both Visual Studio and sideloading package. Not sure if I should open a different github issue or not.

When you say you added the resources, do they show up here in the project file:

Also, in the packaging case, did you build as bundle or as single package? Bundles install only resources that are applicable to the current set of languages, though that should have picked up Chinese for you.

When you create appx package from VS, the default behavior is create bundle. When bundle is installed, you probably don't have de-DE listed as one of the user language, thus the de-DE package won't be installed. So the German string, you either not create appx bundle, or add German to your user preferred language list.
As of the text underneath Default language button, it's not localized.

Thank you guys!  It seems that the key is that I should select "Never" for "Generate app bundle" instead of "Always", then it will generate .msix instead of .msixbundle.

After I install .msix, everything works as expected.

msixbundle works for me if i add german to preferred language list. It's worth checking whether the german language package is installed when you install the bundle.

@huichen123 how/where should I check if the german language package installed or not?

When I run "Get-AppxPackage -name 323858f2-34e1-48a5-8244-5c1bc0c1f889*" from Windows Terminal, it shows "323858f2-34e1-48a5-8244-5c1bc0c1f889_<IP_ADDRESS>_neutral_split.language-de_ew1zb5244bwa6" in Dependencies.

@huichen123 , here is what I got - there is no German language package in Dependencies.
PS C:\Users\Administrator> Get-AppxPackage -name 323858f2-34e1-48a5-8244-5c1bc0c1f889*

Name              : 323858f2-34e1-48a5-8244-5c1bc0c1f889
Publisher         : CN=IBM
Architecture      : X64
ResourceId        :
Version           : <IP_ADDRESS>
PackageFullName   : 323858f2-34e1-48a5-8244-5c1bc0c1f889_<IP_ADDRESS>_x64__qbwk4wmnhe60a
InstallLocation   : C:\Program Files\WindowsApps\323858f2-34e1-48a5-8244-5c1bc0c1f889_<IP_ADDRESS>_x64__qbwk4wmnhe60a
IsFramework       : False
PackageFamilyName : 323858f2-34e1-48a5-8244-5c1bc0c1f889_qbwk4wmnhe60a
PublisherId       : qbwk4wmnhe60a
IsResourcePackage : False
IsBundle          : False
IsDevelopmentMode : False
NonRemovable      : False
Dependencies      : {Microsoft.WindowsAppRuntime.1.0_0.319.455.0_x64__8wekyb3d8bbwe, Microsoft.VCLibs.140.00.UWPDesktop
                    _14.0.30704.0_x64__8wekyb3d8bbwe, Microsoft.VCLibs.140.00_14.0.30704.0_x64__8wekyb3d8bbwe}
IsPartiallyStaged : False
SignatureKind     : Developer
Status            : Ok

make sure you do have language-de.msix in your msixbundle, and de-DE is in your preferred language list.

Hi @ilovepumpkin, is this still an issue or was it resolved through Hui's help above? Thanks

Hi @ilovepumpkin, is this still an issue or was it resolved through Hui's help above? Thanks

@ilovepumpkin a ping for this question.

Closing issue. If there is still an issue, please let us know.


Batch - various fixes

Fixes an NPE, as container_overrides is an optional argument
Adds a docker-tag for all tests - without tag, it will try to download all versions (see https://github.com/docker/docker-py/issues/2257#issuecomment-557678099)
Supercedes #2203
Fixes #2201 thanks to @mztechins
Fixes #2777 by always setting the self.log_stream_name
All of the above fixes the Batch-tests, so I dropped the @expected_failure around them

Coverage increased (+0.1%) to 94.272% when pulling 1b031aeeb0a2816bc153d64d73d47251ec642465 on bblommers:feature/2201 into c54e2ec0014245c0d589fc03bc31bac2c0e590ca on spulec:master.

Coverage increased (+0.1%) to 94.272% when pulling 1b031aeeb0a2816bc153d64d73d47251ec642465 on bblommers:feature/2201 into c54e2ec0014245c0d589fc03bc31bac2c0e590ca on spulec:master.

Looks great; thanks!


Added Comma

Added oxford comma after "for it" under Commands heading
Pull Request Template
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config Change ( change to config or build process )
[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Thanks


CSS duplication on click Apply in CSS editor

Hi Thank you for your plugin which is very helpful to me.
I have some issues while reloading the style from db and try to update CSS.
The steps are given below
I saved the data in server and using load page url to load the content again
After loading the css editor in the component shows the correct CSS, and when I just click Apply and check the Source code, it shows twice the same css again

Could you please give the suggestion to fix this issue?
Regards,
Tom

No idea to be honest, you could try selecting the duplicate css and hitting delete

I am experiencing the same issue, every time I click on apply, it keeps on adding duplicate css.

I am experiencing this too.


P2 Composite Res: Modify /hsapi/_internal/data-store-structure to include Aggregations

Modify the existing /hsapi/_internal/data-store-structure API function to include Aggregations. Need to include the full folder/file listing, but also include Aggregations and their type so that folders that are aggregations can be displayed as such with an appropriate icon in the file browser interface on the resource landing page.

@pkdash Can you please add a 1,2,3 point estimate label to these tickets?

I believe this is complete - or at least the work to make the file browser correctly display files, folders, and aggregations is complete in the phase 2 composite work.

Perhaps we should close these subtickets as they are added to the larger body of work. what do you think?

Deployed 1.16


Fix web application start url references

The web api uses :5000 port, so the web application
has to use other port, here 5001 as in server urls
This works now on OS X, so I assume should work x-plat.

Thanks!

Thanks! This will help in running a side-by-side scenario.


websockets implementation and others

Given this pull-request contains credentials, I don't think this PR was intentional.


Explore better call to action for Continue On in web terminal

Verification:

Open a GitHub repo in insiders.vscode.dev
Open the terminal
Verify that you see multiple options to continue working elsewhere and that the text and options are intuitive


While using 6 tasks and connect worker gets stopped and started due to a wrong format message , Duplicate messages are received in Kafka

What happened?
While using 6 tasks and connect worker gets stopped and started due to a wrong format message , Duplicate messages are received in Kafka
Steps To Reproduce
While using 6 tasks and connect worker gets stopped and started due to a wrong format message , Duplicate messages are received in Kafka
Environment
While using 6 tasks and connect worker gets stopped and started due to a wrong format message , Duplicate messages are received in Kafka

Anything else?
While using 6 tasks and connect worker gets stopped and started due to a wrong format message , Duplicate messages are received in Kafka
Version
1.3.4 (Default)
Relevant log output
While using 6 tasks and connect worker gets stopped and started due to a wrong format message , Duplicate messages are received in Kafkav

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @AishD3
Exactly once delivery (which avoid duplication) is available only with MQ v2 connector
https://ibm.github.io/event-automation/connectors/kc-source-ibm-mq2/installation

Closing (as the connector here only offers at-least-once delivery, so duplicate messages are possible when the connector is restarted)
For use cases where exactly-once assurances are required, we recommend using the connector that Matu links to above.


Run doctests in CI to make sure examples in the documentation work

Codecov Report

Merging #2 (6906548) into main (0f2f31e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            7         7
  Lines           58        58
  Branches         8         8
=========================================
  Hits            58        58

Impacted Files
Coverage Δ

src/bluetooth_numbers/utils.py
100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Registration page

Can't find registration page, route, template don't you have it?

Enso is generally mean to be used for private applications but you can add registration by yourself.
And you can also make a contribution in Enso for that.

I see, thanks for answer


Change timeout msg="timed out waiting for the condition"

I'm creating a workflow to execute multiple sequential steps using Argo, the problem is that one job take 20 mins to finish and Argo return level=fatal msg="timed out waiting for the condition" at 15 mins. How can I define the time to timeout?

Using the argo version 2.3.0 works with the parameter activeDeadlineSeconds


Provide arguments to cage shell label?

I'd love to be able to set my default shell for my PostgreSQL container to
services:
  pg:
    labels:
      io.fdy.cage.shell: "psql -U postgres"

... but it appears cage treats that string as the name of the executable. It works for my redis container because I don't need to provide arguments. Not providing arguments means psql tries to login as root instead of postgres which yields an authentication failure. I've also tried setting the environment variables POSTGRES_USER and PGPASSWORD but the cage shell command seems to ignore those.

I would normally recommended creating a shell script that calls Postgres with the right arguments, and using that as your "shell."

Ok, I’ll give that approach a shot.


An alternative for iterating the input and a intent for the repeat.

I start with an alternative for consuming the input and then try to implement the repeat command, but not work for nested repeat.

Great work! I did my own version today in #24 thank you for this submission! ❤


[0.29.0] - Android crashes when addressForCoordinate returns empty list

Bug report

Summary
The new addressForCoordinate will crash on android with java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
when moving the map to coordinates that tigger an empty list result from the geocoder.
Environment info

react-native info output:
# paste your react, react-native, react-native-maps versions here

Steps to reproduce

Using the new RN pre-release (0.29.0) and the new addressForCoordinate method, zoom all the way out and move around near the bearing sea on android

Describe what you expected to happen:

Invalid coordiantes or empty results should not hard crash the app but return throw and get caught in the JS code.

Describe what you actually happens:

The app will crash with java.lang.IndexOutOfBoundsException: Index: 0, Size: 0

Reproducible sample code

Related https://github.com/react-native-maps/react-native-maps/issues/3850


fix-no-pr-search - Restore feature

Fixes: #7611
Screenshot
https://github.com/user-attachments/assets/3e1fa0d5-fec4-46a6-b90f-8ba6b4378723

If you tested the latest version and it works, this is good to go 👍

@fregante It works fine in the latest version


Update setup file for pyasn1_modules

Version 0.0.6 of pyasn1_modules has been released.
This allows to use updated version of the dependency.
Fixes #199

I signed it!

Thanks for the fix!


Some metaclass conflict using loki.types.DataType and IntEnum with Python 3.11

While loading basic loki types, file enum.py raise too many data types for 'BasicType': {<class 'int'>, <class 'loki.types.DataType'>}
This occurs in the calling tree of the metaclass EnumType (more than one datatype found).

Thanks. I have observed the same, which is a change in behaviour with Python 3.12. I will take care of fixing this soon.
As we don't support or test Python 3.12, yet, please switch to an older Python version in the meantime.

Thanks, I'm indeed currently using Python 3.10. Testing the install with Python 3.11 was just a matter of prospect, mainly because of the claim of the impressive efficiency of this new release... Anyway, it may be hard to get spectacular improvement on such a code (parsing, AST), with low amount of calculations.


v0.6 Release Checklist

Remaining actions:

[ ] Review release (product owner)
[ ] Approve release (product owner and release manager)
[ ] Create binaries (any DRUD maintainer)
[ ] Draft release notes (release manager)
[ ] Draft additional announcements for blog, newsletter, etc (not applicable at the moment)
[ ] Create release (release manager)

For additional background information, please see our Product Release instructions here.

Saving a snapshot of my pre-review starting point.
ddev v0.6 Review
Executive Summary
Based on the following analysis, ddev v0.6 is NOT ready for release.
Milestone Overview (Performance)
The intention of this milestone is to ensure end-users have a positive experience with the overall real and perceived performance of ddev while performing typical day to day tasks. At a minimum, ddev's performance should be on par (or better) than alternative solutions. Out of the box, ddev's containers should be right-sized in terms of resources allocation and app/service configurations based on community accepted best practices. Performance should be testable (automated and manually) to ensure that as ddev's feature set increases that performance is not accidentally and unnecessarily sacrificed. Summarizing our key areas of focus:

PHP, Webserver, and Database Audit/Tuning
Container Resource Audit and Tuning
File System Review
Competitor Performance Analysis
Test (Automated and Manual) & Instructions
Documentation (Our Results, What Drove Our Decisions, etc)

Testing
Performed by Rick Manelius as of 2017-06-05.
Hardware Setup
I’m using a laptop with the following high level specifications:

MacBook Pro: Retina 15-inch Mid 2015
2.2 Ghz Intel Core i7
16 GB 1600 MHz DDR3 RAM
250 GB Hard Drive
macOS Sierra 10.12.4

Software Setup

Xcode
Go 1.8.1
Docker 17.06.0-ce-rc1
Git 2.11.0

Repositories Used

https://github.com/drud/ddev
https://github.com/drud/drupal8

Results
Actively Testing
Works
Fails
Decisions
Based on the following analysis, ddev v0.6 is NOT ready for release.
Recommendations

ddev v0.6 Review
Executive Summary
Based on the following analysis, ddev v0.6 is ready for release.
Milestone Overview (Performance)
The intention of this milestone is to ensure end-users have a positive experience with the overall real and perceived performance of ddev while performing typical day to day tasks. At a minimum, ddev's performance should be on par (or better) than alternative solutions. Out of the box, ddev's containers should be right-sized in terms of resources allocation and app/service configurations based on community accepted best practices. Performance should be testable (automated and manually) to ensure that as ddev's feature set increases that performance is not accidentally and unnecessarily sacrificed. Summarizing our intended areas of focus:

PHP, Webserver, and Database Audit/Tuning
Container Resource Audit and Tuning
File System Review
Competitor Performance Analysis
Test (Automated and Manual) & Instructions
Documentation (Our Results, What Drove Our Decisions, etc)

Ultimately, we postponed a thorough analysis of the PHP, MySQL, and Nginx configurations because we're already using optimized configurations from known sources. Additionally, the largest performance factor was and has been issues surrounding Docker for Mac (see reference here https://docs.docker.com/docker-for-mac/osxfs/#performance-issues-solutions-and-roadmap). And while there are known performance gains associated with switching out the file systems, they come with additional costs/complexity that we were unwilling to take on. Therefore, the 3 areas we spent the most time on were the following:

Competitor Comparisons
Docker for Mac's User-Guided Cache
Automation Tests for Repeat Performance Review

Testing
Performed by Rick Manelius as of 2017-06-05.
Hardware Setup
I’m using a laptop with the following high-level specifications:

MacBook Pro: Retina 15-inch Mid 2015
2.2 Ghz Intel Core i7
16 GB 1600 MHz DDR3 RAM
250 GB Hard Drive
macOS Sierra 10.12.4

Software Setup

Xcode
Go 1.8.1
Docker 17.06.0-ce-rc1
Git 2.11.0

Repositories Used

https://github.com/drud/ddev
https://github.com/drud/drupal8

Results
Works

Implement user-guided caching for web mount drud/ddev issue #253

Confirmed the ":cached" value is added within the Docker compose configuration file.
Confirmed the D8 GUI install times match the new and improved results posted here https://github.com/drud/ddev/issues/253#issuecomment-303728071.
Reviewed @rfay's before/after cache tests https://docs.google.com/document/d/1nFbL1QekrVmKCcn8ENH25Um2MMh_30vfnVe2v1Uz6qE/edit.

Automated Tests

While I did not specifically walk through the individual tests, evaluation of the results are highly encouraging. See below:

CMS and Competitor Performance Matrix
Automated test scripts before/after user-guided cache PR https://docs.google.com/document/d/1nFbL1QekrVmKCcn8ENH25Um2MMh_30vfnVe2v1Uz6qE/edit

Decisions
Based on the following analysis, ddev v0.6 is ready for release. This is not to state that we cannot or will not address performance issues in the future, but that we've already put considerable effort in at this time and we will need to get more real world feedback as well as wait for improvements from the Docker for Mac offering (file and networking performance improvements).
Recommendations

Versioning: Note sure why a ddev make darwin specifies cli: v0.4-30-g249cda44. I would have figured we'd be on a v0.5 tag.
Bug: I received the following when trying to spin up a d8 site right after destroying/rebuilding ddev
ERROR: for nginx-proxy  Cannot start service nginx-proxy: driver failed programming external connectivity on endpoint nginx-proxy (ee43850c08534bd3e641aaf1e2c47616b9febed54738d3c754e2657d93e95ec3): Error starting userland proxy: listen tcp <IP_ADDRESS>:80: bind: address already in use

It looks like we need to prioritize the docker image pruning because docker ps -a shows some remaining images.

System Resource Issues: When testing the user-guided cache issue for this review, my initial results for a D8 GUI install took 4 minutes. After a laptop reset, it dropped to 1:30. This seems to indicate that resource management across multiple containers or as a result of system resources can be an issue.

@cyberswat Assigned to you and ready to release. Thanks!

Since we've merged two milestones together and updated the roadmap, it's worth noting that I didn't explicitly re-review the security items that were moved in. However, they were reviewed at the time and I feel comfortable moving forward with this release.

https://github.com/drud/ddev/releases/tag/v0.6


merge achievement change

I have merged this into master in my own vs, since I kinda forgot how to fix merge conflict on web editor, so I just open this branch on my vs


SonarQube integration

Make SonarQube reports available after Travis build.

Integrated Sonarqube into Travis build.
To see the code analysis link, look for line like this in the Travis logs:

[INFO] ANALYSIS SUCCESSFUL, you can browse https://sonarqube.com/dashboard/index/org.oscm.blueprint:oscm-blueprint-service


Interest in an equivalent of @test?

I wrote a neat little macro, @plutotest, to help with test-driven development inside Pluto notebooks.  It functions essentially like the standard @test macro (so it can be copied into unit test scripts with only trivial editing) and provides a nice color-coded message box to indicate test passage/failure.  It's also designed to be useful when running the notebook as a standalone script.
If this is something others would find useful (I suspect so!) I will make a PR to add it.  I figured this would be the right package for it, but I'm open to suggestions as to alternatives.

I think this repository is closer to pluto-specialized tests → https://github.com/JuliaPluto/PlutoTest.jl - feel free to open a PR there!

@pankgeorg oh, nice.  They basically have what I do, but with extra features.  And here I thought I was so clever, haha!

They basically have what I do, but with extra features.
I'm glad you like it!

And here I thought I was so clever, haha!

Well, you did write something that other people already think is useful enough to build, that sounds pretty clever to me!
Why don't you stick around here and there and maybe try to contribute novel features if you have some time? We are be excited to see what you'll build!! And it's not that any of this is bug free; small contributions make a difference too! Let's stay in touch!
Thanks for reaching out 🎉


Redesigning about us page

I would redesign the entire about us page and make it very attractive
https://github.com/user-attachments/assets/e35ef217-18b9-4cf5-b427-2739bd258769

@vishanurag @somyadipghosh Please assign me this issue

@somyadipghosh Please assign this issue to me

@somyadipghosh Please assign this issue to me

I already made a PR


oci_pull tag non-reproducibility warning is misleading

When experimenting with rules_oci, I eventually came across warnings like this when just using tag in oci_pull:
WARNING: for reproducible builds, a digest is recommended.
Either set 'reproducible = False' to silence this warning,
or run the following command to change oci_pull to use a digest:

bazel run @ubuntu_unpinned//:pin

The code for this seems to be coming from here:
https://github.com/bazel-contrib/rules_oci/blob/82d5b6ab077f689485d9631c4744b424be30b7d2/oci/pull.bzl#L109-L121
This warning makes perfect sense, but it being a warning suggests that the @ubuntu repo will still be initialized even if I don't pin it or add reproducible = False to my oci_pull repository rule.  From the line at the bottom of this, it isn't, and leads to future errors like:
ERROR: /work/BUILD.bazel:9:10: no such package '@ubuntu//': The repository '@ubuntu' could not be resolved: Repository '@ubuntu' is not defined and referenced by '//:image'

Please consider updating this.  Perhaps this message should be printed with fail instead?

It makes sense. I tried to tackle this in #105. I'll give it another stab.


Dust off code for newer deps

Bump a bunch of deps
Nuke a duplicate instance provided by newer deps
deriveSafeCopy for Scientific (for newer aeson)

Thanks for this, I'll merge and push when I get a minute.

On hackage. @relrod good work.

Thanks!


v0.12 CHANGELOG + upgrade guide

Hey there,
It looks like 0.12.0 of the chart was published a few weeks ago but it's missing from the CHANGELOG and upgrade guide files - can we get those updated? There also isn't a tag for v0.11 so it's hard to see what's changed

Any update on this?


Local Admin Group Changes Analytics rule version 1.0.1 is Generating False Positives

Since my customer updated the Local Admin Group Changes Analytics rule from version 1.0.0 to version 1.0.1, they have been getting false positives.
My customer ran the query in the Local Admin Group Changes Analytics rule version 1.0.1, looking in the past 24 hours and got a results count of 751

Got a result count of 751

Uncommented the line 21 and got result count of 569

Got a result count of 569

We ran the query in the Local Admin Group Changes Analytics rule version 1.0.0, looking in the past 24 hours and got a result count of 11280

Got a result count of 11280

Uncommented the line 21 and got a result count of 0

Got a result count of 0

My customer wants the version 1.0.1 because it has the GroupSid in it compared to version 1.0.0 which doesn't have the GroupSid in it's query.
Help investigate why they are getting false positives when using the Local Admin Group Changes Analytics rule version 1.0.1

Hello team, please is there an update on this?

Hi @tibikunle01 , Thanks for flagging this issue, we will investigate this issue and get back to you with some updates. Thanks!

Hi @v-rusraut, Thank you for your response. Do you have an update yet?

Hello @v-rusraut Please do you have an update yet?

@v-visodadasi, look into this issue.

Hi @tibikunle01, Replacing "contains" with "==" helps refine the query to focus on the exact Local Admin Group SID, reducing false positives.

Hi @v-visodadasi thank you for your response.
I replaced "contains" with "==" on line 15 and got a result count of 761

Running the same query with "contains" on line 15, I got a result count of 761.

Please advise.

Hi @tibikunle01 , I think you had raised an ICM for the same issue, and @v-sabiraj  had reached out to you with a potential solution. Could you please confirm if that's correct? If so, I'll go ahead and close this issue

Hi @tibikunle01 , Could you please confirm?


can  not upload egg file

error info:
{
"code": 500,
"data": null,
"msg": "HTTPConnectionPool(host='localhost', port=6800): Max retries exceeded with url: /addversion.json (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x02C33C30>: Failed to establish a new connection: [WinError 10061] \u7531\u4e8e\u76ee\u6807\u8ba1\u7b97\u673a\u79ef\u6781\u62d2\u7edd\uff0c\u65e0\u6cd5\u8fde\u63a5\u3002',))",
"success": false
}
unicode info:
由于目标计算机积极拒绝，无法连接。

this error is not caused by spiderkeeper, please check the computer firewall

@Lt-grint @DormyMo @Lving
I met same error, do you know how to fix it?
{
  "code": 500,
  "data": null,
  "msg": "HTTPConnectionPool(host='<IP_ADDRESS>', port=6800): Max retries exceeded with url: /addversion.json (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x10536fe48>: Failed to establish a new connection: [Errno 61] Connection refused',))",
  "success": false
}

I have same error (I stopped before network firewall). Anyone solve the error?


Add better error handling and logging for misconfigured ingress and i…

…ngress classes

What
Updates the operator to handle logging helpful error messages for situations it can't resolve ingress for
Resolves:

#428

Catch and log a message about not supporting no rules instead of crash looping

#176

Catch and log a message for when a default backend is used
Catch and log a message for when an ingress has a rule with no host
Log a message in the driver if it detects multiple ingress with the same host and route path

#175

warn about using the old deprecated k8s ingress class annotation instead of the spec field. It looks like my kubectl now warns me, but included anyways.

#263
Includes more information about the current classes and warns if there are no classes for the controller

How

test driven dev
more validation checks
a custom error type

Validation
Got nice logs like these after recreating some of the error cases
2024-10-31T02:03:02Z	INFO	Ingress is not valid so skipping it: invalid ingress spec: [HTTP rules are required for ingress]	{"controller": "ingress", "controllerGroup": "networking.k8s.io", "controllerKind": "Ingress", "Ingress": {"name":"ingress-no-http-rules","namespace":"default"}, "namespace": "default", "name": "ingress-no-http-rules", "reconcileID": "49ecf97c-922c-403a-aa0d-a5c7cd41d12c", "ingress": {"name":"ingress-no-http-rules","namespace":"default"}}
2024-10-31T02:03:21Z	INFO	Ingress is not valid so skipping it: invalid ingress spec: [Default backends are not supported]	{"controller": "ingress", "controllerGroup": "networking.k8s.io", "controllerKind": "Ingress", "Ingress": {"name":"ingress-with-default-backend","namespace":"default"}, "namespace": "default", "name": "ingress-with-default-backend", "reconcileID": "b803f4e9-82fc-4afc-80c6-9dd6b1621024", "ingress": {"name":"ingress-with-default-backend","namespace":"default"}}
2024-10-31T02:03:35Z	INFO	Ingress is not valid so skipping it: invalid ingress spec: [A host is required to be set for each rule]	{"controller": "ingress", "controllerGroup": "networking.k8s.io", "controllerKind": "Ingress", "Ingress": {"name":"ingress-no-hostname","namespace":"default"}, "namespace": "default", "name": "ingress-no-hostname", "reconcileID": "68b80707-2434-4356-a0c6-e30248fb715a", "ingress": {"name":"ingress-no-hostname","namespace":"default"}}
2024-10-31T02:03:53Z	INFO	cache-store-driver	Deprecated annotation 'kubernetes.io/ingress.class' detected with value: ngrok
2024-10-31T02:03:53Z	INFO	cache-store-driver	Ingress class k8s.ngrok.com/ingress-controller not found	{"ingress": "ingress-deprecated-class"}
2024-10-31T02:03:53Z	INFO	Ingress is not of type ngrok so skipping it	{"controller": "ingress", "controllerGroup": "networking.k8s.io", "controllerKind": "Ingress", "Ingress": {"name":"ingress-deprecated-class","namespace":"default"}, "namespace": "default", "name": "ingress-deprecated-class", "reconcileID": "7af6cff8-8464-4f9e-8924-4e976e866b06", "ingress": {"name":"ingress-deprecated-class","namespace":"default"}}
2024-10-31T02:05:16Z	INFO	cache-store-driver	Ingress is not of type k8s.ngrok.com/ingress-controller so skipping it	{"class": "not-ngrok"}
2024-10-31T02:05:16Z	INFO	Ingress is not of type ngrok so skipping it	{"controller": "ingress", "controllerGroup": "networking.k8s.io", "controllerKind": "Ingress", "Ingress": {"name":"ingress-no-hostname","namespace":"default"}, "namespace": "default", "name": "ingress-no-hostname", "reconcileID": "e211e611-a830-4c6f-aaa1-8650a6568e1f", "ingress": {"name":"ingress-no-hostname","namespace":"default"}}

Recreated and tested with these cases
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-no-http-rules
  namespace: default
spec:
  rules:
  - host: foo.bar.com
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-with-default-backend
  namespace: default
spec:
  ingressClassName: "ngrok"
  defaultBackend:
    service:
      name: default-backend-service
      port:
        number: 80
  rules:
  - host: "test-alex-bezek.ngrok.io"
    http:
      paths:
      - path: /
        pathType: ImplementationSpecific
        backend:
          service:
            name: example-service
            port:
              number: 80
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-no-hostname
  namespace: default
spec:
  ingressClassName: "ngrok"
  rules:
  - http:
      paths:
      - path: /
        pathType: ImplementationSpecific
        backend:
          service:
            name: no-host-service
            port:
              number: 80
# Dummy conflict-service-1 and conflict-service-2 services are created in the same namespace.
apiVersion: v1
kind: Service
metadata:
  name: conflict-service-1
  namespace: default
spec:
  selector:
    app: conflict-app-1
  ports:
  - protocol: TCP
    port: 80
    targetPort: 80
---
apiVersion: v1
kind: Service
metadata:
  name: conflict-service-2
  namespace: default
spec:
  selector:
    app: conflict-app-2
  ports:
  - protocol: TCP
    port: 80
    targetPort: 80
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-conflict-1
  namespace: default
spec:
  ingressClassName: "ngrok"
  rules:
  - host: "conflict-test-alex-bezek.ngrok.io"
    http:
      paths:
      - path: /conflict2
        pathType: ImplementationSpecific
        backend:
          service:
            name: conflict-service-1
            port:
              number: 80
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-conflict-2
  namespace: default
spec:
  ingressClassName: "ngrok"
  rules:
  - host: "conflict-test-alex-bezek.ngrok.io"
    http:
      paths:
      - path: /conflict2
        pathType: ImplementationSpecific
        backend:
          service:
            name: conflict-service-2
            port:
              number: 80
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-deprecated-class
  namespace: default
  annotations:
    kubernetes.io/ingress.class: "ngrok"
spec:
  rules:
  - host: "deprecated-test-alex-bezek.ngrok.io"
    http:
      paths:
      - path: /
        pathType: ImplementationSpecific
        backend:
          service:
            name: deprecated-service
            port:
              number: 80
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: ingress-no-hostname
  namespace: default
spec:
  ingressClassName: "not-ngrok"
  rules:
  - host: "non-ngrok-test-alex-bezek.ngrok.io"
    http:
      paths:
      - path: /
        pathType: ImplementationSpecific
        backend:
          service:
            name: no-host-service
            port:
              number: 80

has this been published as 0.16.0-rc.2 or is it in need of being published?


[#111778374] Remove use of access keys in deployer concourse pipelines

This removes the remaining usage of access keys in the deployer-concourse pipelines
This does not cover removing them from the concourse resources themselves (covered in a separate story), or from the cloudfoundry manifest (also covered in a separate story).
This relies on some additional permissions that are defined in https://github.gds/government-paas/terraform-iam/pull/6, and have been manually applied to the trial account.
How to review
Run the create-microbosh and deploy-cloudfoundry pipelines from this branch and verify that they run successfully.
Run the corresponding destroy pipelines and verify that they also work as expected.
Who can review
Anyone but me.

works...