Maintenance - Package Dependancies

Hi Just seeing if this packages is still being maintained...
@microsoft/signalr is now a 5.0.0 and there is also support for 3.1.10
RxJs has moved on a bunch too...

I haven't maintained this for awhile.


Unnecessary 0.5s delay when flashing files?

Is this delay really needed?
https://github.com/kaluma-project/kaluma/blob/3bf77ea1b7278b9d236415f7df1609e0a55d10b0/src/repl.c#L509
... it makes flashing new usercode to the Pico take 0.5s more than it maybe needs to.

Just for safe YMODEM communication, not necessary. (Some YMODEM client failed without delay when we tested)


Tex.rebuild() method

Description of proposed feature

A method, perhaps animatable which can be used to change an existing Tex mobject's LaTeX text and reinitialise it, creating a new mobject with differing content.
There have been queries regarding this on reddit and discord before, and the common reply we give is "create a new mobject and Transform to it", and apart from that, this might open up new possibilities for using LaTeX in manim, such as adding text at specific points in the compiled template, outside of the regularly placed one.
How can the new feature be used?

I'm thinking something like this for a usecase:
t = Tex("some long latex code")
t.append_in_environment("other text1") ## does not exist yet
t.append_before_environment("other text 2") ## this too
t.append_after_environment("other text 3") ## and this as well.

t = t.rebuild() ## similar to TexTemplate._rebuild()

self.add(t) ## displays the new mobject with the added text

Additional comments

Or how about making Tex just a holder and the creation of the SVG files be done at the time of rendering. I mean like having an attribute where text can be changed and doesn't need a .rebuild() method.
It was previously discussed here cc @Skaft.


[Retrospective] Release Version 2.2.1

Related release issue?
https://github.com/opensearch-project/opensearch-build/issues/2481
How to use this issue?
Please add comments to this issue, they can be small or large in scope. Honest feedback is important to improve our processes, suggestions are also welcomed but not required.
What will happen to this issue post release?
There will be a discussion(s) about how the release went and how the next release can be improved. Then this ticket will be updated with the notes of that discussion along side action items.

Closing this issue, please feel-free to open or add comments if required.
Thank you
@bbarani


Unexpected page counts when switching views

The page count fails to update in a sensible way when switching views (e.g. "All Hosts" to "Latest 10 hosts"). To reproduce:

From the "All hosts" view, scroll to page 5 in the list
Switch to "Latest 10 hosts" view

Expected: Page number changes to page 1 of 1
Actual: Page number changes to page 5 of 2

It would be good if the view change caused the page number to reset and it would be good if the "Latest 10 hosts" page calculated the total number of pages as 1 instead of 2 (because there's really only one page of rows for the latest 10 hosts).

Fixed, thank you


setting CanvasData

I have certain images that will ignore the setCanvasData's height/width/left/top
It's just one value that does not get set right..
example console.log
====================================
Set CanvasData to...
Object {left: 42.34375, top: 27.849999999999994, width: 313.3125, height: 501.3}
====================================

$('img.uploaded').cropper('getCanvasData')
Object {left: 42.34375, top: 27.849999999999994, width: 313.3125, height:<PHONE_NUMBER>239382}

I am frustrated and close to giving up ..
Please someone help me understand why its behaving this way!!

Please keep the same aspect ratio to original image.
e.g., if the aspect ratio of an image is 16 / 9, then:
// 480 / 270 = 16 / 9
$().cropper('setCanvasData', {
  width: 480,
  height: 270
});

// Or only set width
$().cropper('setCanvasData', {
  width: 480
});

// Or only set height
$().cropper('setCanvasData', {
  height: 270
});


Implement IntoRobj for Dataframe

This PR closes https://github.com/extendr/extendr/issues/710
It implements IntoRobj by returning the inner Robj. The associate test asserts that the returned Robj is equal to the Robj provided by df.as_robj().clone().

I believe the issues we are seeing here are related to https://github.com/r-lib/actions/issues/395

Warning: Failed to download qpdf or ghostscript: Failed to install qpdf: Error: The process 'C:\ProgramData\Chocolatey\bin\choco.exe' failed with exit code 1


Raincatch 504

What
Update the module to handle sync remote events
How

added subsrcibers for all sync events
each time the result is listed or read syncStatus property is added/updated

JIRA
https://issues.jboss.org/browse/RAINCATCH-504
Related PR
https://github.com/feedhenry-raincatcher/raincatcher-demo-mobile/pull/55

closing in favour of https://github.com/feedhenry-raincatcher/raincatcher-sync/pull/28


database options

as we discussed here, we need a database
so, we need to pick the database type

@h1alexbel So we have several options.
in sql we can use postgresql, in nosql we can use, I don't know, anything, like mongo or graphql, etc.
wdyt

@l3r8yJ I think we can try PostgreSQL, simple relational database, in case of logic scalability we can add new tables and objects
WDYT?

@h1alexbel agree with you, i'll create an issue

OK, PostgreSQL


Add BigQuery client with basic query interface

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

137 of 211 (64.93%)  changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+10.9%) to 65.258%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/mpcq/orbits.py
38
41
92.68%

src/mpcq/submissions.py
42
55
76.36%

src/mpcq/client.py
27
85
31.76%

Totals

Change from base Build<PHONE_NUMBER>1:
10.9%

Covered Lines:
139

Relevant Lines:
213

💛  - Coveralls


AMBARI-25234 - Ambari audit log shows "null" user when executing an API call as admin

What changes were proposed in this pull request?
backport of #2925 to branch-2.5

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5145/
Test FAILed.
Test FAILured.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/5147/
Test FAILed.
Test FAILured.

These test were failing in earlier runs:
https://builds.apache.org/job/Ambari-branch-2.5/1856/#showFailuresLink


Negative index slicing seems to behave weird on devito.Data

grid = Grid(shape=(20,))
u = TimeFunction(name='u', save=None, grid=grid, space_order=0, time_order=1)

print(u.data[1, -2:])

produces the error: IndexError: index 20 is out of bounds for axis 0 with size 2
but the error does not happen on numpy objects. Also, it only happens when printing.

Looks like __repr__ is fine but __str__ is not

Thanks. Will look into this today.

So I assume this must have been a problem for a long time then? Basically the 'local indices' don't get passed correctly meaning you get out of bounds errors. This is fixed by adding:
    def __str__(self):
        return super(Data, self._local).__str__()

I'll include the above in a PR which also fixes #1007.

Fixed on https://github.com/opesci/devito/tree/misc-data-fixes. Will be PR'ing after adding a few more tests.

closing as fixed by #1008


Protractor API reference for version 1.8.0

Where is it now? http://angular.github.io/protractor/#/api only shows reference for the latest version.

At the moment, we only keep the latest version on the website. You can always see the code for previous versions on the github repo by using the old version release tags.
I'm not sure if it makes sense to have a versioned website, the way Angular does. We document changes thoroughly in our changelog, and do not support multiple branches so old versions are not officially supported. Is there a reason you cannot upgrade to 2.0?

Thanks Julie,
I managed to make the old website work locally following these instructions https://github.com/angular/protractor/tree/1.8.0/website
And I had this problem https://github.com/angular/protractor/issues/1969 when trying to install 2.0 so thought I would rely on 1.8.0 which works fine for me.

Cool, sounds like this is handled.

sometimes version upgrades are restricted by management for  reasons.  Being able to reference the correct API documentation is fundamentally necessary in these cases.

This doesn't really seem like a solution. Even if a version is no longer supported, not having API reference is a huge PITA when dealing with existing code. I'm in the same boat as @derekakers - not everyone can be on the latest version all the time.

Running into exactly this issue now.  It would be really nice if i could easily bring up online API docs for a previous, say 2.5.1 :), version.

I have similar problem too. I use nodejs v0.12.9 so I can use only protractor v2. But I can't access documentation. On this page https://github.com/angular/protractor/blob/2.5.1/docs/api.md I see only link to latest api. How can I access api documentation for Protractor v2.5.1?

Same issue here. When you've worked with supporting software products for a while, you'll realize this is a no-brainer. Especially for a non-typesafe, non-self-documenting, global-variable atrocity like javascript.
How do I find the old API docs in github? Are they gone forever?

I hope that this helps @alex-bigfoot, @Matrosskin, @rnavarette. The documentation is not gone forever...you should still be able to view the old documentation:

switch to the tag 2.5.1
in the website directory, npm install
then to start the website, use npm start

This should start gulp on localhost:8080. Hopefully that works.

Thanks @cnishina , but I think the point was something a little different.
While its good to know that we can build and launch the docs after doing a local checkout, I think the point was having access to something much more convenient.  The OP actually commented very early in the thread that the docs could be built locally.  However, having the previous versions available online would help quite a bit for those times when we can't or aren't (for some reason or another) on the latest version.

And also in documentation built locally is not available sections "Inherited from webdriver.WebDriver" so we need to build protractor's docs and also search somehow which webdriver methods also available. Such solution does not help much :(

I agree, same here, we have to remain on an older version of protractor (v3) and it's very time consuming  tohave every developper in our 80 people team checkout and install the doc for even simple corrections.


[plugin:react-svg] path is not defined

path is not defined. This might be a typo. It should be idWithoutQuery
index.js

            if (isBuild) {
              cache.set(path, result);
            }
          }

Source code is OK but publish version on NPM is not up to date

As a workaround, you can yarn add the latest code directly: yarn add https://gitpkg.now.sh/visualfanatic/vite-svg/packages/vite-plugin-react-svg?7e1571bf0636b2f341d1e66c23e8e264e64cc156.

Related to #64. For workarounds see my comment here.

If the new version with the fix has not yet been published, then just patch the package locally(for yarn):

Go to node_modules/vite-plugin-react-svg/index.js
Change
if (isBuild) {cache.set(path, result)} to if (isBuild) {cache.set(idWithoutQuery, result)}
run yarn patch-package vite-plugin-react-svg  -> https://www.npmjs.com/package/patch-package
You are awesome 👏

I fix the error with copying the npm source code  into my project. it works.


Translation string recording

Need to implement "always-on" translation string recording, with an affordance for handling the translation request workflow.

Research how other generators handle automating the "extract" command
Always create translation string files (ready for submission to translation request workflows) when building a site
Add a way to mark a string as requested, so subsequent translation requests do not include the already-requested string

From our other conversations, the built-in amagaki can do the translation usage recording, but we will handle the 'extracting for translations' kind of workflows as a plugin so that the ecosystem can create any type of translation workflows they desire. Ex: local workflow that uses amagaki caching to track or a third-party translation service that would keep track of external translations and status.

Obsolete strings should be archived (in locales/archive/{locale}.yaml) after the build is finished in order to remove stale strings from the catalogs.


Curl fails w/Foreman

Hey David,
Peter (from Heroku),
I've got a strange issue.  When I use curl http:/localhost:7000 while running foreman, I get a connection refused error.  If I run web brick and try the same (http://localhost:3000) curl works just fine.
What would account for this.  And FYI, I have verified that I can reach http://localhost:7000 via a browser.
TIA,
Peter

Foreman does not actually do any networking other than picking port numbers so your problem is likely with the app or your network.

Peter, I had the same issue on my Mac running Yosemite while connecting from curl to Unicorn or Puma started by Foreman.
After removing "fe80::1%lo0" from my /etc/hosts file as suggested by an answer on http://superuser.com/questions/830920/curl-local-host-names-on-mac-os-x-yosemite it worked for me. In my case it wasn't Foreman's fault. (So this comment is by no means an attempt to open this issue again.)


Feature/remove event listeners

Create Method To Remove Created Event Listeners Without Reloading Page
Description
Added the remove_listeners method so that it is possible to remove all of ULabel's event listeners without reloading the page. Because ULabel instantiates event listeners in multiple ways, this was achieved in multiple ways. First every jquery event listener was added to a .ulabel namespace so that they can all be removed by one jquery .off method. Then an AbortController was added to ulabel and passed as an option into every vanilla js event listener, so that they can be aborted with an abort method. Finally, a reference to every ResizeObserver is stored on ULabel instances so that they can be looped through and terminated.
This is useful for "single page" web applications where ULabel dom elements are removed during navigation but the page is never reloaded. Many ULabel event listeners reference dom elements, but because there is no error checking in place, when ULabel is unable to find them it errors out. This gives an easy way to remove them from outside of ULabel.
PR Checklist

[x] Merged latest main
[x] Version number in package.json has been bumped since last release
[x] Version numbers match between package package.json and src/version.js
[x] Ran npm install and npm run build AFTER bumping the version number
[x] Updated documentation if necessary (currently just in api_spec.md)
[x] Added changes to changelog.md

Breaking API Changes
None.

I pushed two more commits adding the remaining jQuery event listeners that I missed to the ulabel namespace. Should be good to go now :+1:


Renamings

As agreed upon.

Uhh... sorry. There should have been something about 31 bytes max length in the commit messages.

Thanks!
I'll need the VS update also when splitting the MockSupport. You saw the first splitted PR, right?

Yup, I saw the splitted PR. The basic principle is fine. In the end though, I need to be able to split roughly like I outlined. So right now, there's no point trying to merege it in my watcom branch.
I think it will work; execpt for the third file -- will remain to be seen whether it can fit with eithr of the other two. I'd like to avoid having seven executables. Six is bad enough ;-)


Missing documentation on usage with RSpec?

Hi,
When trying to rspec test a command such as:
command('support', &->(client, data, match){
        channel_real_name = client.channels.dig(data.channel, :name)
        client.say(channel: data.channel,
                         text: "#{channel_real_name} support url: https://url")
})

with the following spec file:
require_relative '../commands/support'
require 'pry'

describe MyBot::Commands::Support do

  it 'gives support link' do
    expect(message: "#{SlackRubyBot.config.user} support").to respond_with_slack_message(/support url/)
  end
end

and spec_helper:
require 'slack-ruby-bot/rspec'
require 'webmock/rspec'

$LOAD_PATH.unshift(File.dirname(__FILE__))

require 'yaml'
require 'json'
require 'async'

require_relative '../mybot'

When running rspec I get:
1) MyBot::Commands::Support gives support link
     Failure/Error: client.channels.dig(data.channel, :name)

     NoMethodError:
       undefined method `dig' for nil:NilClass

Whereas I'm expecting to get a green passing test.
In order to get over the error I think I need to connect to slack but I can’t find the proper documentation for doing so.
Thanks

The RTM client's .channels is something that comes from a local store. Since we are not actually starting a client we either need to stub that store in tests or default it. I think it's a bug either way. I'm happy to take a PR for either code or docs.


File browser name formatting

If I upload a image with a large text i get something like that:

I try it in last version of Google Chrome. This screeshot is in example here: https://metroui.org.ua/forms.html?
Is possible make Metro show file name with "..." or something like that?

Thanks, overflow fixed in 4.1.8


RGB color is not supported

Hello,
This project is very good & very useful to me for my WPF application.
Perhaps, if I am using a "" tag with "style='color: rgb(255,90,40);' then it is not getting color and set black or gray color.
I have debugged into it and found the issue in "MarkupConverter/htmlcssparser.cs ". There is a function of ParseWhiteSpace in which color is converting but I can't understand why there is :
else if (styleValue.Substring(nextIndex, 3).ToLower() == "rbg")
                {
                    //  Implement real rgb() color parsing
                    while (nextIndex < styleValue.Length && styleValue[nextIndex] != ')')
                    {
                        nextIndex++;
                    }
                    if (nextIndex < styleValue.Length)
                    {
                        nextIndex++; // to skip ')'
                    }
                    color = "gray"; // return bogus color
                }

In this "rbg" is by mistake or some other reason (it should be rgb on rbg) - I don't know.
Anyway, I have resolved it by adding following code:
                //Added by Sachin for converting rgb color to hex and return
                else if (styleValue.Substring(nextIndex, 3).ToLower() == "rgb")
                {
                    //  Implement real rgb() color parsing
                    startIndex = 4;
                    string temp_color = styleValue.Substring(startIndex, styleValue.Length - 1 - startIndex);
                    string[] rgb = temp_color.Split(',');
                    color = "#" + (byte.Parse(rgb[0])).ToString("X2") + (byte.Parse(rgb[1])).ToString("X2") + (byte.Parse(rgb[2])).ToString("X2");
                }

Thanks,
Sachin

Please submit a PR and I will gladly accept

If the merge is done, issue was not resolved?


Change array type to :array, handle null arrays and json

Snowpack was barfing when Snowflake returns a value of NULL in a column of type ARRAY (which we map to :json in snowpack).

Handled null case for parsing column of type :json

This is the only required change, but 2 & 3 will make life easier in the platform

Changed ARRAY to map to type :array rather than json, so we can return [] rather than :null.
Handled null case for :array

@sreephg I rebased your commits and used the Semantic Release commit message format so that the release version would be created correctly.
I also updated to use our new shared GHA for Semantic Release and common configs. This fixed the CI errors.

:tada: This PR is included in version 0.5.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[AlloyTransaction] Prevent deletion or edit the weight when not in the last delivery for a client

No changes required in that story. Closed


[UX] Able to start db creation without selecting agent

Steps to reproduce:

Click on "Create database"
Type in a name for the database
Notice that the "Create" button is no longer disabled
Click on "Create"
Result: "Agent went offline" - because no agent was actually selected.

Suggested solution: rework the validation logic in JS to always check whether the necessary fields are selected and valid

Issue migrated


Provide sample code service endpoint azureRm

Can you provide a sample code for create an Azure RM service point

Sorry Azure Resource Manager is not covered by this SDK.   This SDK is a wrapper around all the Azure DevOps REST APIs.

Yes I know, I want to create a service connection in AzDo for Azure RM for use it in pipeline to deploy in Azure.

@mikaelkrief , have you looked at the REST documentation here:
https://docs.microsoft.com/en-us/rest/api/azure/devops/serviceendpoint/endpoints?view=azure-devops-rest-5.1

@tedchamb , but I will be interressed to have a sample for azurerm service end point, for implement in the Terraform AzureDevOps provider https://github.com/microsoft/terraform-provider-azuredevops


onUserStatusChanged() getting fired more than once when a new user joins

On the demo of Audio+Video+TextChat+FileSharing,
when a new user joins, the onUserStatusChanged is fired more than once (about 6 times) for the new user joined.

Yep, it is intentional, to make status as much reliable as possible.
Please use onUserStatusChanged only to update offline/online icons.

I have a webpage where I am showing the list of people in the current room (in which I am also present). When a new user joins, I want to add the new user to the list of users in the room, so that now there are (n+1) people in the room.
With this behaviour, my code will definitely add a new user 6 times to the list of users in the room.
How can I update existing users, about arrival of a new user then (only once, not 6 times or so)?

connection.onUserStatusChanged = function(event) {
    numberOfUsersBox.innerHTML = connection.getAllParticipants().length;
    updateUsersList();
};

function updateUsersList() {
     usersList.innerHTML = '';
     connection.getAllParticipants.forEach(function(p) {
         var li = document.createElement('li');
         li.id = p; // to reuse this <li>
         li = connection.peers[p].userid; // or extra-data.fullName
         usersList.appendChild(li);
     });
}

Thanks but this does not serve my purpose, as I am not showing a simple text string, otherwise this would have been great solution. I have added the animation for a new user. His icon drops from top to user-in-room-div , similar to StackOverflow chat rooms. So I have to know the exact user details.
Maintaining an array locally would also suffice.
Thanks.
[PS : Can you please give any idea about issue#220]

To make sure onUserStatusChanged fires once.
var onlineUsers = {};
var offlineUsers = {};

connection.onUserStatusChanged = function(event) {
    if (event.status === 'online' && !onlineUsers[event.userid]) {
        onlineUsers[event.userid] = event.userid;

        // place your code here
        // this user is online; show him online

        yourUnique_onUserStatusChanged_Event(event);
    }

    if (event.status === 'offline' && !offlineUsers[event.userid]) {
        offlineUsers[event.userid] = event.userid;

        // place your code here
        // this user is offline; show him offline

        yourUnique_onUserStatusChanged_Event(event);
    }
};

function yourUnique_onUserStatusChanged_Event(event) {
  // this fucntion is called once for each user
  // place your codes here
}

Thanks.....
This is how I just implemented, maintaining a local array.
However, you dedication made me your fan.
Thanks. This completely solves the problem.


Read_only_fields in PostgresController

Long story short
Hi, I found that read_only_fields does not work as stated in the documentation
Expected behaviour
In the admin dashboard, field that is specified in read_only_fields should become read-only
Actual behaviour
The field remains changeable
Your environment

aiohttp_admin2 version: 0.0.5
aiohttp version: 3.8.3
Python version: 3.8.10
Operating System: Linux

Sorry, I realized late that you are Russian. Please don't use current open source software.

Sorry, I realized late that you are Russian. Please don't use current open source software.
thx

Sorry, I`m not understanding you. Why?

@KondratevAD Hto ne skache, toy moskal.

@KondratevAD russia parasha

Sorry, I realized late that you are Russian. Please don't use current open source software.
thx

Sorry, I`m not understanding you. Why?

@KondratevAD Hto ne skache, toy moskal.

And why did you decide that all the residents of Russia support all this? I am very sorry for you, you have a very good project. if you don't want to develop it, well, that's up to you. thank you at least for do this

@KondratevAD i wanna develop this project and i will do but without people from Russia. No mater that all or not all the residents of Russia support WAR. If i will support u i will support your country. No, thanks.
good luck!

good luck!

Ok, thanks for that too

thanks


Improve MaxRequestBufferSizeTests reliability

Still failed on at least one of the CIs.

This test fails on OSX

@halter73: Close as dup of https://github.com/aspnet/KestrelHttpServer/commit/1951ddf6eadc828f05eb69bf13f94b5bda4d8388?

Yep. Thanks


[filebeat] not creating index

Chart version:
7.5.0
Kubernetes version:
1.16.1
Kubernetes provider: E.g. GKE (Google Kubernetes Engine)
KVM
Helm Version:
2.15.1
helm get release output
e.g. helm get elasticsearch (replace elasticsearch with the name of your helm release)
Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting.
If you find some secrets in plain text in helm get release output you should use Kubernetes Secrets to managed them is a secure way (see Security Example).
REVISION: 1
RELEASED: Fri Dec  6 13:00:58 2019
CHART: filebeat-7.5.0
USER-SUPPLIED VALUES:
affinity: {}
extraEnvs: []
extraVolumeMounts: []
extraVolumes: []
filebeatConfig:
  filebeat.yml: |
    filebeat.inputs:
    - type: docker
      containers.ids:
      - '*'
      processors:
      - add_kubernetes_metadata:
          in_cluster: true

    output.elasticsearch:
      host: '${NODE_NAME}'
      hosts: '${ELASTICSEARCH_HOSTS:elasticsearch-master:9200}'
fullnameOverride: ""
hostNetworking: true
hostPathRoot: /var/lib
image: docker.elastic.co/beats/filebeat
imagePullPolicy: IfNotPresent
imagePullSecrets: []
imageTag: 7.5.0
labels: {}
livenessProbe:
  failureThreshold: 3
  initialDelaySeconds: 10
  periodSeconds: 10
  timeoutSeconds: 5
managedServiceAccount: true
nameOverride: ""
nodeSelector: {}
podAnnotations: {}
podSecurityContext:
  privileged: false
  runAsUser: 0
priorityClassName: ""
readinessProbe:
  failureThreshold: 3
  initialDelaySeconds: 10
  periodSeconds: 10
  timeoutSeconds: 5
resources:
  limits:
    cpu: 1000m
    memory: 200Mi
  requests:
    cpu: 100m
    memory: 100Mi
secretMounts: []
serviceAccount: ""
terminationGracePeriod: 30
tolerations: []
updateStrategy: RollingUpdate

COMPUTED VALUES:
affinity: {}
extraEnvs: []
extraVolumeMounts: []
extraVolumes: []
filebeatConfig:
  filebeat.yml: |
    filebeat.inputs:
    - type: docker
      containers.ids:
      - '*'
      processors:
      - add_kubernetes_metadata:
          in_cluster: true

    output.elasticsearch:
      host: '${NODE_NAME}'
      hosts: '${ELASTICSEARCH_HOSTS:elasticsearch-master:9200}'
fullnameOverride: ""
hostNetworking: true
hostPathRoot: /var/lib
image: docker.elastic.co/beats/filebeat
imagePullPolicy: IfNotPresent
imagePullSecrets: []
imageTag: 7.5.0
labels: {}
livenessProbe:
  failureThreshold: 3
  initialDelaySeconds: 10
  periodSeconds: 10
  timeoutSeconds: 5
managedServiceAccount: true
nameOverride: ""
nodeSelector: {}
podAnnotations: {}
podSecurityContext:
  privileged: false
  runAsUser: 0
priorityClassName: ""
readinessProbe:
  failureThreshold: 3
  initialDelaySeconds: 10
  periodSeconds: 10
  timeoutSeconds: 5
resources:
  limits:
    cpu: 1000m
    memory: 200Mi
  requests:
    cpu: 100m
    memory: 100Mi
secretMounts: []
serviceAccount: ""
terminationGracePeriod: 30
tolerations: []
updateStrategy: RollingUpdate

HOOKS:
MANIFEST:

---
# Source: filebeat/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: filebeat-filebeat-config
  labels:
    app: "filebeat-filebeat"
    chart: "filebeat-7.5.0"
    heritage: "Tiller"
    release: "filebeat"
data:
  filebeat.yml: |
    filebeat.inputs:
    - type: docker
      containers.ids:
      - '*'
      processors:
      - add_kubernetes_metadata:
          in_cluster: true

    output.elasticsearch:
      host: '${NODE_NAME}'
      hosts: '${ELASTICSEARCH_HOSTS:elasticsearch-master:9200}'
---
# Source: filebeat/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
metadata:
  name: filebeat-filebeat
  labels:
    app: "filebeat-filebeat"
    chart: "filebeat-7.5.0"
    heritage: "Tiller"
    release: "filebeat"
---
# Source: filebeat/templates/clusterrole.yaml
apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRole
metadata:
  name: filebeat-filebeat-cluster-role
  labels:
    app: "filebeat-filebeat"
    chart: "filebeat-7.5.0"
    heritage: "Tiller"
    release: "filebeat"
rules:
- apiGroups:
  - ""
  resources:
  - namespaces
  - pods
  verbs:
  - get
  - list
  - watch
---
# Source: filebeat/templates/clusterrolebinding.yaml
apiVersion: rbac.authorization.k8s.io/v1beta1
kind: ClusterRoleBinding
metadata:
  name: filebeat-filebeat-cluster-role-binding
  labels:
    app: "filebeat-filebeat"
    chart: "filebeat-7.5.0"
    heritage: "Tiller"
    release: "filebeat"
roleRef:
  kind: ClusterRole
  name: filebeat-filebeat-cluster-role
  apiGroup: rbac.authorization.k8s.io
subjects:
- kind: ServiceAccount
  name: filebeat-filebeat
  namespace: monitoring
---
# Source: filebeat/templates/daemonset.yaml
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: filebeat-filebeat
  labels:
    app: "filebeat-filebeat"
    chart: "filebeat-7.5.0"
    heritage: "Tiller"
    release: "filebeat"
spec:
  selector:
    matchLabels:
      app: "filebeat-filebeat"
      release: "filebeat"
  updateStrategy:
    type: RollingUpdate
  template:
    metadata:
      annotations:

        configChecksum: d09c5755a4e64cc09218a083e031266d48e268deab552fb964ea88238ec3b8d
      name: "filebeat-filebeat"
      labels:
        app: "filebeat-filebeat"
        chart: "filebeat-7.5.0"
        heritage: "Tiller"
        release: "filebeat"
    spec:
      serviceAccountName: filebeat-filebeat
      terminationGracePeriodSeconds: 30
      hostNetwork: true
      dnsPolicy: ClusterFirstWithHostNet
      volumes:
      - name: filebeat-config
        configMap:
          defaultMode: 0600
          name: filebeat-filebeat-config
      - name: data
        hostPath:
          path: /var/lib/filebeat-filebeat-monitoring-data
          type: DirectoryOrCreate
      - name: varlibdockercontainers
        hostPath:
          path: /var/lib/docker/containers
      - name: varrundockersock
        hostPath:
          path: /var/run/docker.sock
      containers:
      - name: "filebeat"
        image: "docker.elastic.co/beats/filebeat:7.5.0"
        imagePullPolicy: "IfNotPresent"
        args:
        - "-e"
        - "-E"
        - "http.enabled=true"
        livenessProbe:
          exec:
            command:
            - sh
            - -c
            - |
              #!/usr/bin/env bash -e
              curl --fail <IP_ADDRESS>:5066
          failureThreshold: 3
          initialDelaySeconds: 10
          periodSeconds: 10
          timeoutSeconds: 5

        readinessProbe:
          exec:
            command:
            - sh
            - -c
            - |
              #!/usr/bin/env bash -e
              filebeat test output
          failureThreshold: 3
          initialDelaySeconds: 10
          periodSeconds: 10
          timeoutSeconds: 5

        resources:
          limits:
            cpu: 1000m
            memory: 200Mi
          requests:
            cpu: 100m
            memory: 100Mi

        env:
        - name: POD_NAMESPACE
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        - name: NODE_NAME
          valueFrom:
            fieldRef:
              fieldPath: spec.nodeName
        securityContext:
          privileged: false
          runAsUser: 0

        volumeMounts:
        - name: filebeat-config
          mountPath: /usr/share/filebeat/filebeat.yml
          readOnly: true
          subPath: filebeat.yml
        - name: data
          mountPath: /usr/share/filebeat/data
        - name: varlibdockercontainers
          mountPath: /var/lib/docker/containers
          readOnly: true
        # Necessary when using autodiscovery; avoid mounting it otherwise
        # See: https://www.elastic.co/guide/en/beats/filebeat/master/configuration-autodiscover.html
        - name: varrundockersock
          mountPath: /var/run/docker.sock
          readOnly: true

Describe the bug:
A filebeat index is not being created in elasticsearch.
[elasticsearch@elasticsearch-master-0 ~]$ curl 'localhost:9200/_cat/indices?v'
health status index                  uuid                   pri rep docs.count docs.deleted store.size pri.store.size
green  open   .kibana_task_manager_1 gUJ9gAyHQv2UgPo-hbYiHw   1   1          2            0     76.5kb         38.2kb
green  open   .kibana_1              iAjgWSzNTauzEZ6Iki-wQA   1   1          9            0    134.9kb         67.4kb

I am running elasticsearch-7.4.1 helm chart. I can write to elasticsearch-master:9200 using fluentd.
Thanks in advance!

Hi @esvirskiy,
Can you paste your Filebeat logs also?

2019-12-06T18:55:56.341Z	INFO	instance/beat.go:610	Home path: [/usr/share/filebeat] Config path: [/usr/share/filebeat] Data path: [/usr/share/filebeat/data] Logs path: [/usr/share/filebeat/logs]
2019-12-06T18:55:56.342Z	INFO	instance/beat.go:618	Beat ID: bee86e9c-a67a-4201-924c-db4d563c5a6f
2019-12-06T18:55:56.347Z	INFO	[api]	api/server.go:62	Starting stats endpoint
2019-12-06T18:55:56.347Z	INFO	[seccomp]	seccomp/seccomp.go:124	Syscall filter successfully installed
2019-12-06T18:55:56.347Z	INFO	[beat]	instance/beat.go:941	Beat info	{"system_info": {"beat": {"path": {"config": "/usr/share/filebeat", "data": "/usr/share/filebeat/data", "home": "/usr/share/filebeat", "logs": "/usr/share/filebeat/logs"}, "type": "filebeat", "uuid": "bee86e9c-a67a-4201-924c-db4d563c5a6f"}}}
2019-12-06T18:55:56.347Z	INFO	[beat]	instance/beat.go:950	Build info	{"system_info": {"build": {"commit": "6d0d0ae079e5cb1d4f224801ac6df926dfb1594c", "libbeat": "7.5.0", "time": "2019-11-26T00:06:12.000Z", "version": "7.5.0"}}}
2019-12-06T18:55:56.347Z	INFO	[beat]	instance/beat.go:953	Go runtime info	{"system_info": {"go": {"os":"linux","arch":"amd64","max_procs":2,"version":"go1.12.12"}}}
2019-12-06T18:55:56.347Z	INFO	[api]	api/server.go:64	Metrics endpoint listening on: <IP_ADDRESS>:5066 (configured: localhost)
2019-12-06T18:55:56.350Z	INFO	[beat]	instance/beat.go:957	Host info	{"system_info": {"host": {"architecture":"x86_64","boot_time":"2019-10-18T01:18:23Z","containerized":true,"name":"node2-k8s.lab.xxx.net","ip":["<IP_ADDRESS>/8","::1/128","<IP_ADDRESS>/23","fdfb:8c2c:dbc:1:5054:ff:fef6:567d/64","fe80::5054:ff:fef6:567d/64","<IP_ADDRESS>/16","<IP_ADDRESS>/32","fe80::d4bf:60ff:fee1:aff7/64","<IP_ADDRESS>/24","fe80::89f:cff:fe09:38b1/64","fe80::6c46:33ff:fed2:6baa/64","fe80::d402:ddff:fe6d:94b0/64","fe80::4488:84ff:feb7:2e8a/64","fe80::84f5:caff:fe79:21c9/64","fe80::e0b4:82ff:feef:1bea/64","fe80::7052:5aff:fe75:68f7/64","fe80::e4a5:d6ff:fed9:6116/64"],"kernel_version":"3.10.0-1062.1.2.el7.x86_64","mac":["52:54:00:f6:56:7d","02:42:1f:7e:22:02","d6:bf:60:e1:af:f7","0a:9f:0c:09:38:b1","6e:46:33:d2:6b:aa","d6:02:dd:6d:94:b0","46:88:84:b7:2e:8a","86:f5:ca:79:21:c9","e2:b4:82:ef:1b:ea","72:52:5a:75:68:f7","e6:a5:d6:d9:61:16"],"os":{"family":"redhat","platform":"centos","name":"CentOS Linux","version":"7 (Core)","major":7,"minor":7,"patch":1908,"codename":"Core"},"timezone":"UTC","timezone_offset_sec":0}}}
2019-12-06T18:55:56.351Z	INFO	[beat]	instance/beat.go:986	Process info	{"system_info": {"process": {"capabilities": {"inheritable":["chown","dac_override","fowner","fsetid","kill","setgid","setuid","setpcap","net_bind_service","net_raw","sys_chroot","mknod","audit_write","setfcap"],"permitted":["chown","dac_override","fowner","fsetid","kill","setgid","setuid","setpcap","net_bind_service","net_raw","sys_chroot","mknod","audit_write","setfcap"],"effective":["chown","dac_override","fowner","fsetid","kill","setgid","setuid","setpcap","net_bind_service","net_raw","sys_chroot","mknod","audit_write","setfcap"],"bounding":["chown","dac_override","fowner","fsetid","kill","setgid","setuid","setpcap","net_bind_service","net_raw","sys_chroot","mknod","audit_write","setfcap"],"ambient":null}, "cwd": "/usr/share/filebeat", "exe": "/usr/share/filebeat/filebeat", "name": "filebeat", "pid": 1, "ppid": 0, "seccomp": {"mode":"filter","no_new_privs":true}, "start_time": "2019-12-06T18:55:55.400Z"}}}
2019-12-06T18:55:56.351Z	INFO	instance/beat.go:297	Setup Beat: filebeat; Version: 7.5.0
2019-12-06T18:55:56.351Z	INFO	[index-management]	idxmgmt/std.go:182	Set output.elasticsearch.index to 'filebeat-7.5.0' as ILM is enabled.
2019-12-06T18:55:56.351Z	INFO	elasticsearch/client.go:171	Elasticsearch url: http://elasticsearch-master:9200
2019-12-06T18:55:56.351Z	INFO	[publisher]	pipeline/module.go:97	Beat name: node2-k8s.lab.xxx.net
2019-12-06T18:55:56.356Z	INFO	[monitoring]	log/log.go:118	Starting metrics logging every 30s
2019-12-06T18:55:56.356Z	INFO	instance/beat.go:429	filebeat start running.
2019-12-06T18:55:56.357Z	INFO	registrar/registrar.go:145	Loading registrar data from /usr/share/filebeat/data/registry/filebeat/data.json
2019-12-06T18:55:56.360Z	INFO	registrar/registrar.go:152	States Loaded from registrar: 1
2019-12-06T18:55:56.360Z	INFO	crawler/crawler.go:72	Loading Inputs: 1
2019-12-06T18:55:56.360Z	WARN	[cfgwarn]	docker/input.go:49	DEPRECATED: 'docker' input deprecated. Use 'container' input instead. Will be removed in version: 8.0.0
2019-12-06T18:55:56.372Z	INFO	add_kubernetes_metadata/kubernetes.go:68	add_kubernetes_metadata: kubernetes env detected, with version: v1.16.1
2019-12-06T18:55:56.372Z	INFO	kubernetes/util.go:94	kubernetes: Using pod name node2-k8s.lab.xxx.net and namespace monitoring to discover kubernetes node
2019-12-06T18:55:56.376Z	ERROR	kubernetes/util.go:97	kubernetes: Querying for pod failed with error: pods "node2-k8s.lab.xxx.net" not found
2019-12-06T18:55:56.476Z	INFO	log/input.go:152	Configured paths: [/var/lib/docker/containers/*/*.log]
2019-12-06T18:55:56.476Z	INFO	input/input.go:114	Starting input of type: docker; ID:<PHONE_NUMBER>663050389
2019-12-06T18:55:56.476Z	INFO	crawler/crawler.go:106	Loading and starting Inputs completed. Enabled inputs: 1
2019-12-06T18:56:26.362Z	INFO	[monitoring]	log/log.go:145	Non-zero metrics in the last 30s	{"monitoring": {"metrics": {"beat":{"cpu":{"system":{"ticks":50,"time":{"ms":60}},"total":{"ticks":130,"time":{"ms":149},"value":130},"user":{"ticks":80,"time":{"ms":89}}},"handles":{"limit":{"hard":1048576,"soft":1048576},"open":9},"info":{"ephemeral_id":"7fe6f930-4d7d-4933-b666-3edbbe8b4d58","uptime":{"ms":30065}},"memstats":{"gc_next":9785584,"memory_alloc":4940376,"memory_total":14768032,"rss":30461952},"runtime":{"goroutines":34}},"filebeat":{"harvester":{"open_files":0,"running":0}},"libbeat":{"config":{"module":{"running":0}},"output":{"type":"elasticsearch"},"pipeline":{"clients":1,"events":{"active":0}}},"registrar":{"states":{"current":0}},"system":{"cpu":{"cores":2},"load":{"1":0.51,"15":1.02,"5":0.83,"norm":{"1":0.255,"15":0.51,"5":0.415}}}}}}
2019-12-06T18:56:56.358Z	INFO	[monitoring]	log/log.go:145	Non-zero metrics in the last 30s	{"monitoring": {"metrics": {"beat":{"cpu":{"system":{"ticks":80,"time":{"ms":27}},"total":{"ticks":180,"time":{"ms":42},"value":180},"user":{"ticks":100,"time":{"ms":15}}},"handles":{"limit":{"hard":1048576,"soft":1048576},"open":9},"info":{"ephemeral_id":"7fe6f930-4d7d-4933-b666-3edbbe8b4d58","uptime":{"ms":60064}},"memstats":{"gc_next":9785584,"memory_alloc":6595456,"memory_total":16423112,"rss":270336},"runtime":{"goroutines":34}},"filebeat":{"harvester":{"open_files":0,"running":0}},"libbeat":{"config":{"module":{"running":0}},"pipeline":{"clients":1,"events":{"active":0}}},"registrar":{"states":{"current":0}},"system":{"load":{"1":1.01,"15":1.04,"5":0.93,"norm":{"1":0.505,"15":0.52,"5":0.465}}}}}}

Setting hostNetworking: false gets rid of ERROR	kubernetes/util.go:97	kubernetes: Querying for pod failed with error: pods "node2-k8s.lab.xxx.net" not found
I checked /var/lib/docker/containers/ on the nodes, and I don't see any .log files...

Hi @jmlrt
I just tried 7.5.0 and still seeing the same issue.

Figured it out, by default Docker writes logs to journald in CentOS. Disavbling that in /etc/sysconfig/docker fixes this.


Provide bash completion

Similar to --help-man, create a --help-bash-completion flag (that is possibly hidden).
I'm assuming this could come out of e.g. the CmdGroupModel of Application.Model(). Having not looked at the source and only the API, that was just my best guess.
This will probably be an easier PR for me to start up on than the other issues I've opened. :wink:

I don't use bash, but this is something I've wanted for a while for zsh. I started, but unfortunately the documentation for zsh completion is lacking.
Definitely would be great to have.

Oh! If your zsh is recent enough, it should come with a function called bashcompinit that will create the completer for zsh. I've set that in #76.

Not sure if I should open a separate issue, but is it correct to have hidden cmds completed? If a cmd is marked as hidden from --help, maybe it should also be hidden from tab completion.

Yes, I would say it should be hidden. Commands, flags too.

I think this is largely complete, just needs some tweaks and bug fixes. Closing.


Change all dialog select components to auto completes

System importance
Obsolete dialog (is obsolete)
catalogue category property migration (add, edit)

Also

ensure the values and labels match for selects
remove ability to clear for mandatory selects / autocompletes


[RFC] Help / User Guide

Any ideas and suggestions where and how to maintain help pages?
My current, simple idea would be as markdown in the GitHub project wiki. Then render to HTML when building (#372 added marked). Not sure how to organize translations.

I like the simplicity of just storing it in the GitHub project wiki. I'd even consider using marked as a runtime dependency and fetch the markdown source just in time. The wiki pages are available directly, e.g. https://raw.githubusercontent.com/wiki/nrenner/brouter-web/FAQ.md, and the response also has a access-control-allow-origin: * header so SOP isn't triggered.
Regarding translations, I wouldn't initially care for those. Let's see how much documentation will be put together, and if people will start to create like "[de] help xyz" pages next to the main pages. Then a language chooser could be added like it's currently present on MDN Web Docs.
With data being retrieved dynamically it should also be easily possible to link between documents and reference images.


why multiply -1 to viewdirs in orientation_loss

Hi, I noticed that in orientation_loss, the viewdirs are multiplied with -1. The comment says this is to represent normalized vectors from point to camera.
v = -1. * rays.viewdirs
n_dot_v = (n * v[..., None, :]).sum(axis=-1)

This seems to be different with equation 11 in ref-nerf paper. Could you please give me some hints about it?

Sorry I misunderstood. The loss is computed with minimum instead of maximum, so the implementation is correct.
https://github.com/google-research/multinerf/blob/b02228160d3179300c7d499dca28cb9ca3677f32/internal/train_utils.py#L167


data

Is the Ren-CECps dataset available?
As well as the associated dependency environment in the code and the rest of the file dependencies

Hi, can I request a copy of the Ren-CECps data?

Please @.***
Best wishes,
Zhou

------------------ Original ------------------
From:                                                                                "youngzhou97qz/Prompt-consistency-for-multi-label-emotion-detection"                                                                                @.>;
Date: Thu, Aug 15, 2024 09:32 PM
@.>;
<EMAIL_ADDRESS>Subject: Re: [youngzhou97qz/Prompt-consistency-for-multi-label-emotion-detection] data (Issue #1)
Hi, can I request a copy of the Ren-CECps data?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

Please @.*** Best wishes, Zhou   ------------------ Original ------------------ From: "youngzhou97qz/Prompt-consistency-for-multi-label-emotion-detection" @.>; Date: Thu, Aug 15, 2024 09:32 PM @.><EMAIL_ADDRESS>Subject: Re: [youngzhou97qz/Prompt-consistency-for-multi-label-emotion-detection] data (Issue #1) Hi, can I request a copy of the Ren-CECps data? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Hi, I would like to get a copy of the ren-cecps dataset, my email is<EMAIL_ADDRESS>

Hello friend,
I have graduated and am not in the lab now.
If you need help with the data set, please contact AP Kang Xin at @.***
Best wishes,
Zhou
------------------ Original ------------------
From:                                                                                "youngzhou97qz/Prompt-consistency-for-multi-label-emotion-detection"                                                                                @.>;
Date: Tue, Dec 24, 2024 10:24 AM
@.>;
<EMAIL_ADDRESS>Subject: Re: [youngzhou97qz/Prompt-consistency-for-multi-label-emotion-detection] data (Issue #1)
Please @.*** Best wishes, Zhou   ------------------ Original ------------------ From: "youngzhou97qz/Prompt-consistency-for-multi-label-emotion-detection" @.>; Date: Thu, Aug 15, 2024 09:32 PM @.><EMAIL_ADDRESS>Subject: Re: [youngzhou97qz/Prompt-consistency-for-multi-label-emotion-detection] data (Issue #1) Hi, can I request a copy of the Ren-CECps data? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
Hi, I would like to get a copy of the ren-cecps dataset, my email is @.***
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


Add separable conv2d for CNTK

This PR adds separable conv2d for CNTK. The tests may be conflicted with #9359.

Updated, @fchollet.


Use newer version of nvidia-docker (Docker 1.13.0 is out)

The "Install nvidia-docker" line should be replaced like this:
wget -P /tmp https://github.com/NVIDIA/nvidia-docker/releases/download/v1.0.0/nvidia-docker_1.0.0-1_amd64.deb

See https://github.com/NVIDIA/nvidia-docker/issues/294

Thanks @boxmein, I've changed it so it links directly to the nvidia-docker README for those instructions.


quote

allways i use "quote" i get the message "OMG something is wrong with Twitter API right now."

This was a bug, thanks for report :beer:


Disarm vehicle on kill switch

Describe problem solved by the proposed feature
Hello all. In this feature request, I am suggesting a modification to the vehicle flight behavior following the activation of a vehicle kill switch. I believe that this change may bring the functionality of a vehicle to be more inline with what an end-user would expect, although admittedly I am no expert on aerospace safety best practices. What I am observing in the latest release version of the firmware in Gazebo HITL and in real-life testing is the following:

Kill switch is triggered on the transmitter. Motors power down immediately.
Kill switch is disengaged. Vehicle state is resumed exactly as it was before the kill switch was pulled. Vehicle is therefore still armed, and motors spin up (provided that the user did not disarm while the kill switch was triggered.)

Describe your preferred solution
What I would suggest is that if a user pulls the kill switch, the vehicle flight mode should automatically switch to the disarmed flight mode. The reason I believe this is a better course of action is because I see the kill switch as a safety feature that allows the vehicle to be shutdown in the event of rogue or dangerous behavior. Following this behavior, the user should be able to have time to determine the cause of the failure that caused them to initiate the termination of the flight in the first place. Further, because the kill switch functionality has the ability to crash the drone while in mid-flight, it is very possible that the vehicle is no longer flyable after the fact and should therefore be disarmed even if the switch is no longer triggered.
Describe possible alternatives
More aggressive disarming procedure: I don't even know if this exists but perhaps some description of a flight state that requires to be restarted before a flight.
Less aggressive disarming procedure: Leave the functionality exactly as it is and perhaps leave a note in the documentation pertaining to the vehicle behavior on activation of the kill switch.
Additional context
Thanks very much for taking the time to review my suggestion. I am very new to the stuff so please let me know if there is anything that I should do differently for one of these feature requests in the future.

Current PX4 has auto-disarm after the kill switch is engaged for 5 seconds. Do you think that's too long?
https://github.com/PX4/Firmware/blob/39b803a9dc894cef7d086e4e699262424f4e1423/src/modules/commander/Commander.cpp#L1629-L1630

Ah, sorry, I didn't see that. Personally speaking, I expected the kill switch to disarm the drone immediately, and I would argue that it might be a better implementation. Still, I think I should have read the documentation better as well. Is there a reason that we wait for the switch to be held for some time before disarming?

It was a compromise solution because some people seem to actually want it. You can configure it with COM_KILL_DISARM.

That makes sense. Thank you so much for the clarification and the time!


Video removed from docs pages

Explanation

Related issue

What type of PR is this

Proposed Changes

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!


Verify account - No animation when Validate your account RHP from 2FA setup is dismissed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Log in with a new Gmail account.
Go to Settings > Security > Two-factor authentication.
Dismiss the RHP.

Expected Result:
There will be animation when Validate your account RHP from 2FA setup is dismissed.
Actual Result:
There is no animation when Validate your account RHP from 2FA setup is dismissed.
Workaround:
Гтлтщцт
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/fb7d41ec-7ad3-4b76-86a5-47706005d2ac

View all open jobs on GitHub

I don't think this is a blocker since it is a new feature and isn't breaking any existing functionality.

The steps in the OP verify the issue but I'm not sure if this should be a priority. Asking the team.

Proposal
Please re-state the problem that we are trying to solve in this issue.
No animation when closing the 2fa validate code page.
What is the root cause of that problem?
The validate code itself is a modal and it will be visible as long as the user is not validated.
https://github.com/Expensify/App/blob/64cb4ee92b1f4c66e5deb96e23caf47e25423c00/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx#L164-L176
When we close the page, the modal stays visible until the 2FA page is closed (by TwoFactorAuthActions.quitAndNavigateBack).
What changes do you think we should make in order to solve the problem?

We need to store the modal visibility state to a state.
const [isModalVisible, setIsModalVisible] = useState(!isUserValidated);

And we can update it whenever isUserValidated is updated.
useEffect(() => {
    setIsModalVisible(!isUserValidated);
}, [isUserValidated]);

Then, we can set it to false when closing the modal.
onClose={() => {
    setIsModalVisible(false)
    TwoFactorAuthActions.quitAndNavigateBack(backTo)
}}

@deetergp feel free to assign me if you want as I reviewed the offending PR, happy to take over

@hungvu193 as a C+ on the offending PR, can you please review the proposal here?

Yeah surre

Proposal
Please re-state the problem that we are trying to solve in this issue.
Animation is not showing when closing two factor authentication modal.
What is the root cause of that problem?
2FA modal only shows when isUserValidated = false. In case we close the modal without authenticate isUserValidated is always false so it does not animate it.
https://github.com/Expensify/App/blob/64cb4ee92b1f4c66e5deb96e23caf47e25423c00/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx#L164-L167
What changes do you think we should make in order to solve the problem?
To fix this problem we need to make sure as long as close event is fire modal will hidden. To fix this we need to introduce new state variable.
const [showValidateCodeModal, setValidateCodeModal] = useState(false);

And pass state value as props in ValidateCodeActionModal, so once state value set to false modal will be closed.
https://github.com/Expensify/App/blob/64cb4ee92b1f4c66e5deb96e23caf47e25423c00/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx#L167
Replace with
isVisible={showValidateCodeModal}

Set showValidateCodeModal to false when we close modal. To make it cleaner extract modal close logic into handler.
https://github.com/Expensify/App/blob/64cb4ee92b1f4c66e5deb96e23caf47e25423c00/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx#L175
Replace with
onClose={handleValidateCodeModalClose}

const handleValidateCodeModalClose = () => {
    setValidateCodeModal(false);
    TwoFactorAuthActions.quitAndNavigateBack(backTo);
};

Update showValidateCodeModal value whenever isUserValidated is changed. We already have useEffect which runs when isUserValidated value changed. So we can use same effect.
https://github.com/Expensify/App/blob/64cb4ee92b1f4c66e5deb96e23caf47e25423c00/src/pages/settings/Security/TwoFactorAuth/Steps/CodesStep.tsx#L55-L62
Replace with
useEffect(() => {
    setValidateCodeModal(!isUserValidated);
    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
    if (account?.requiresTwoFactorAuth || account?.recoveryCodes || !isUserValidated) {
        return;
    }
    Session.toggleTwoFactorAuth(true);
    // eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps -- We want to run this when component mounts
}, [isUserValidated]);

What alternative solutions did you explore? (Optional)
NA

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~018e905fce69c8896f

Sorry not yet. I've been a bit under the water today. I'll try to review this weekend

@ishakakkad Your proposal is a dupe of @bernhardoj  proposal. Please checkout our contributing guides here before posting proposal. Ty.
Let's go with @bernhardoj 's proposal.
🎀 👀 🎀  C+ reviewed.

PR is ready
cc: @hungvu193

@hungvu193 can you let us know about a regression test? TY!

Regression Tests:
2FA Flow on Web:

Login with a brand new account.
Go to Settings => Security => Two factor authentication.
Click outside to dismiss the modal.
Verify that the modal is dismissed with animation.

Other flows using ValidateCodeActionModal:
Prerequisite: Using your Android Chrome browser

Login with a brand-new account.
Go to any flow that needs validate code (VerifyContactMethod or 2FA or Add Bank Account etc...)
Once the ValidateCode modal appears, press the ack button.
Verify that the modal is closed with animation.

Do we 👍 or 👎  ?

@mountiny I'm not sure if I'm eligible to be paid for this issue. During PR process we realized this issue also happened every where on mWeb Chrome and we fixed it as well.

@hungvu193 to confirm, you have been a c+ on the offending PR, right? then I think we should not really issue a payment here. Or am I misunderstanding your question?

@hungvu193 to confirm, you have been a c+ on the offending PR, right? then I think we should not really issue a payment here. Or am I misunderstanding your question?

Ah I mean, while working on the PR, we found out the the right side animation didn't work on mWeb (which is not a regression from the PR that I reviewed) and we fixed it as well.

ok sounds like $250 to @hungvu193 too

Regression test - https://github.com/Expensify/Expensify/issues/450960
Payment summary here - https://github.com/Expensify/App/issues/52339#issuecomment-2519688188
Feel free to submit a NewDot payment request @hungvu193 and @bernhardoj

Requested in ND.

DMd @hungvu193 to request payment in ND. Going to close this out.

Thanks for reminding me. I've just requested on ND

$250 approved for @bernhardoj via the summary

$250 approved for @hungvu193


Bit simpler Actions config

Not sure if it's useful for you or not, but building config can be simplified further to something like this:
# ... #
 build:
  runs-on: ${{ matrix.config.os }}
  strategy:
   matrix:
    config:
    - { os: windows-2019, script: "BuildScripts\\windows-win32.bat", artifact: binaries-windows-win32 }
    - { os: windows-2019, script: "BuildScripts\\windows-win64.bat", artifact: binaries-windows-win64 }
    - { os: ubuntu-18.04, script: "BuildScripts/linux.sh",           artifact: binaries-linux }
    - { os: ubuntu-18.04, script: "BuildScripts/android-arm32.sh",   artifact: binaries-android-arm32 }
    - { os: ubuntu-18.04, script: "BuildScripts/android-arm64.sh",   artifact: binaries-android-arm64 }
    - { os: ubuntu-18.04, script: "BuildScripts/web-release.sh",     artifact: binaries-web-release }
    - { os: ubuntu-18.04, script: "BuildScripts/web-debug.sh",       artifact: binaries-web-debug }
    - { os: macOS-10.14,  script: "BuildScripts/mac.sh",             artifact: binaries-mac }
    - { os: macOS-10.14,  script: "BuildScripts/ios.sh",             artifact: binaries-ios }
  steps:
  - uses: actions/checkout@v1
    with:
     fetch-depth: 1
  - name: Run build script
    run: ${{ matrix.config.script }}
  - uses: actions/upload-artifact@master
    with:
     name: ${{ matrix.config.artifact }}
     path: Build/Binaries
  - name: Upload FOnlineVersion.txt
    uses: actions/upload-artifact@master
    with:
     name: sdk-version
     path: Build/FOnlineVersion.txt
    if: matrix.config.artifact == 'binaries-windows-win32'
# ... #

It keeps current logic (unless i missed something), with uploading sdk-version only once. Everything after and including unit-tests job should be as it is now, except parts which needs dependency:
  make:
   needs: [build, unit-tests, code-coverage]

Didn't test it fully, but if run: ${{ matrix.config.script }} step works properly, everything else should.
There's one small disadvantage - checks names won't be as "clean" as they are now ;)

Thanks!


[Event Request] Table 39 "Purchase Line" – InitHeaderDefaults

[Event Request] Table 39 "Purchase Line" – InitHeaderDefaults
Could we please have a publisher OnInitHeaderDefaultsOnBeforeTestfieldBuyfromVendorNo with Handled Pattern in function InitHeaderDefaults Table 39 "Purchase Line"?
  local procedure InitHeaderDefaults(PurchHeader: Record "Purchase Header")

    // >>>>>>>>
    var
        IsHandled: Boolean;
    // <<<<<<<<
    begin

        // >>>>>>>>
        IsHandled := false;
        OnInitHeaderDefaultsOnBeforeTestfieldBuyfromVendorNo(Rec,PurchHeader,IsHandled);
        if not IsHandled then
        // <<<<<<<<
        PurchHeader.TestField("Buy-from Vendor No.");

        "Buy-from Vendor No." := PurchHeader."Buy-from Vendor No.";

..

    // >>>>>>>>
    [IntegrationEvent(false, false)]
    local procedure OnInitHeaderDefaultsOnBeforeTestfieldBuyfromVendorNo(var PurchLine: Record "Purchase Line"; PurchHeader: Record "Purchase Header"; var  IsHandled: Boolean)
    begin
    end;
   // <<<<<<<<

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Solandra Build Issue

@tjake  Please check with this, I have gone across web also and FYI my ant is also updated one 1.8.3 so that should not be the problem if m not wrong and java is properly configured and Java Home is also set  but where the problem rise :-
BUILD FAILED
/opt/tjake-Solandra-cfbce36/build.xml:114: The  type doesn't support the "erroronmissingdir" attribute.
Total time: 0 seconds

Embedding in an existing cassandra distribution
To use an existing Cassandra distribution perform the following steps.
1)Download your Cassandra distribution
2)Unzip it the directory of your choice
3)Run the following solandra ant task to deploy the necessary files into the unzipped dir
4)ant -Dcassandra={unzipped dir} cassandra-dist

You can now start Solr within Cassandra by using $CASSANDRA_HOME/bin/solandra command. Cassandra now takes two optional properties: -Dsolandra.context and -Dsolandra.port for the context path and the Jetty port.

I'm getting error in 4th step, most of the files were moved from solandra to cassandra. But finally its shows like BUILD FAILED D:\Solandra-solandra\build.xml:290: didn't replace anything
I checked with build file in 290 line, it has the following code. classname="org.apache.cassandra.thrift.CassandraDaemon" classname="solandra.SolandraServer"
Due to build fail, I couldn't achieve the 5th step. Thanks in advance if anybody replied.


Add first-phase rerank-count

In cases where one uses sub-linear sparse retrieval (e.g WAND with K=x) the number of exposed hits to the first-phase ranking function is unbound as WAND exposes all hits it evaluated while searching for the top x hits.  There are three reasons for introducing a rank-count also for first-phase

Conceptually when using ANN/WAND the query retrieval phase is  candidate retrieval and our first-phase is really the first ranking phase so it makes sense to limit the number of evaluations
It's more work training a first-phase ranking function as during training it needs to sample hits differently then just sample from the top-k retrieved as in reality it might see some very low performing hits
It sets upper bound on how many hits are evaluated so performance becomes more predictable

rank-profile super-phased {
   first-phase {
       expression: lightgbm("trained-first-phase.json")
       rerank-count:1000
   }
  second-phase {
     expression: query(p1_weight)*firstPhase + (1 - query(p1_weight))*onnx("ranker.onnx")
     rerank-count: 10
   }
}

With the above, max 1000 docs from the retrieval phase is evaluated using a trained GBDT model and top 10 re-ranked using a ONNX model.

wontfix

wontfix


Installing prometheus

From: https://github.com/developmentseed/eoapi-k8s/issues/42#issuecomment-1727795817
Here the documentation to install prometheus and cAdvisor at any cluster
cc. @ranchodeluxe  @batpad

Covered in the 0.1.11 chart release already


chore(CI): temporary disable Project Tests

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Since Aug 2018 update can not do simple debugging tasks

We have written the needed data into your clipboard because it was too large to send. Please paste.
Issue Type: Bug
I have very simple code. Can run Debug in both integrated and external terminal with expected results. However, the minute I set a breakpoint, I get an error indicating an IndexError that begins with this:
Traceback (most recent call last):
File "c:\Users\smcfarla.vscode\extensions\ms-python.python-2018.8.0\pythonFiles\experimental\ptvsd\ptvsd\wrapper.py", line 1254, in done
fut.result()
File "c:\Users\smcfarla.vscode\extensions\ms-python.python-2018.8.0\pythonFiles\experimental\ptvsd\ptvsd\futures.py", line 40, in result
reraise(self._exc_info)
If I choose Step In, the program runs but seems to ignores the breakpoint and does not display values for the variable listed in the Watch panel.
This was working just fine prior to the Aug 2018 update and also prior to recent Windows udpates.
Suggestions?
Thanks,
Sue
VS Code version: Code 1.27.2 (f46c4c469d6e6d8c46f268d1553c5dc4b475840f, 2018-09-12T16:17:45.060Z)
OS version: Windows_NT x64 10.0.14393

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4300M CPU @ 2.60GHz (4 x 2594)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.91GB (2.29GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

anaconda-extension-pack
ms-
1.0.0

python
ms-
2018.8.0

vscode-yaml
red
0.0.16

please file this against the python debugger


Error Message in Log looking for words.js

Hello!
During checking some other errors in the developer console in firefox, when running my vis, I found this error message:

It is not creating any problem for me for now, but probably you have the chance to fix it - or let me know what I am doing wrong.
JS Version: 3.3.18
Adapter Version: 0.9.0
Firefox Version: 93.0

fixed


[3087] Provide background name tag

Context
We need this to be able to debug issues like geocoding going haywire.
Changes proposed in this pull request
Change the ARM template so it reads from a list of names provided as pipeline variable.
Guidance to review
Make sure the names match in the app and in azure pipeline
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 [1d?] Tag background jobs correctly for logit.


typescript support

Hi Thanks for creating both marked and marked-emoji. It's really an awesome package.
I was wondering if it would be possible to make @types/marked-emoji (or maybe rewrite this in typescript) ?
Otherwise it is a bit difficult to use this in typescript projects :)
Thanks a bunch

fixed in #90


Interface suggestions

Hi, just found about this project in reddit, and I think you have done a great work!
I've tried it with great success, and have a couple of suggestions if you don't mind:

When selecting a path in "Operations", it should highlight it in the graphic view, like it does if you select it in "Elements". It whould allow for easier reordering of cuts (right now I have to sort the elements before creating a new cut operation)
Allow for placing the laser head anywhere on the table by clicking on the graphic view or something in the order: : right now it's hard to confirm that a cut fit's a tightly dimensioned material. In K40Whisperer you have a shortcut to go to the four corners of the cutting envelope.
There's a small but noticeable delay between cutting each path in a single cut operation. When cutting a lot of small parts it seem's like a lot of time lost.

I hope you don't take this comments wrong, You have done ag reat work and looking forward for improvements to make it the best software for our K40s.
I was developping a ESP32 GRBL Shield for the K40, and now that I found  meerk40t don't know if it is really worth the effort!

I can add comments to a few of your suggestions. The selection issue is a legitimate concern; and there was a previous development snapshot where that actually worked. Unfortunately it was problematic in some other ways at the time... Presumably it will return again when those details are worked out.
The newest release does have an alternative home position available; which can be helpful when placing tightly dimensioned material. There are also numeric shortcut keys (numbers 1-5) available for custom positions. One can use the arrow keys to step around 1mm at a time, and also the navigation pane which has an adjustable step size. Then simply press a number 1-5 to save that location. Further key presses of that number will recall the location saved, and the shuttle will drive to that location.
What speed are you cutting the parts when you notice a delay? There is a slowdown feature in the M2 Nano controller which drives the head backwards (a sort of active braking); and that may be at issue in this case. I just now checked one of my testing files, and noticed it might be trying too hard to slow down after running at 10mm/s (and perhaps slower). I'll raise an issue if I can find constraints; preliminary testing shows it might be attempting to slow down less at a higher speed; which isn't intuitive or helpful in this case.
I too looked at replacing my K40s stock controller early on; until I got more comfortable with the available open source software.
Your comments are absolutely appreciated; and I'm quite sure you'll receive even more feedback in regards to those suggestions here soon.

Thank you for your prompt  answer.
Custom positions are cool and a good answer for what I was looking for, but found a couple of issues: can't reset them after saving the first time, and don't work if the cursor isn't over the graphic view, like when it's over the navigation window. These two issues combined makes them hard to use, when testing more than once set a position wrong and then that key was unusable anymore (until restart, of course).
I noticed the delay between paths when cutting 3mm plywood at 18mm/s. I can send the svg if needed. I think you're right about the driving the head backwards, I've just run the file again (with the laser off just for testing) and noticed it pulls back after each path, indeed at a slower speed than the cut itself!
Thank you everyone for the good work!

Thanks for reporting those issues. I was aware of the mouse over the graphic view being an concern; but while investigating the nuances I came across some other problems that can arise from trying to navigate this way. Clicking navigation arrow buttons (maybe with the nav dialog out of focus), and then using to the arrow keys may well change the step size. This could be bad if it goes unnoticed.
It looks like key mappings are an incoming feature. Allowing the setting of custom positions manually (and resetting them), should be added to the list of possible options.
That 18mm/s is on the faster end; but I watched my machine a bit closer and can't perceive a difference in deceleration between 10mm/s and 35mm/s off hand. At 10mm/s it shouldn't really need any at all; and at 35mm/s it's still exaggerated in an unnecessary way. Maybe that needs to be a setting as well. Banding for speed codes should be user adjustable; or at least closer to those of rasters in terms of speed.
I do wonder if it has to do with the drawing order of the part though. If the component ends in the Y direction; is it faster or slower between paths? Is there another optimization happening on the fly? These are questions about MeerK40t, and the M2 Nano's reactions; and somewhat rhetorical in both cases...
What OS are you testing with?

Here is the SVG:
key.zip
I just cut it without changes, after deleting the raster lines (leftovers of dxf imported from fusion).
I'm using Windows 10.

Seriously thank you. The interface's rough edges are the current highlight in 0.5.2 all suggestions along those lines are gold.

Select items from Operation Elements and have it highlight them like when selecting the Element Branch Node. This was added with the latest commit to 0.5.2 just now.
Do move to corners navigation. This was added earlier today.

The other movement dialog does the more whisperer like functionality. It moves to the corner and the center as needed and lets you hit the side buttons there to drag the design and move the laser head.

"There's a small but noticeable delay between cutting each path in a single cut operation. When cutting a lot of small parts it seems like a lot of time lost."

This is certainly fixable. It'll help joerlane too since getting rid of the waits between elements means implementing @ in micro-gl rather than just F for everything. OSX has some issues with those waits, at times. Which would heavily reduce but not correct #111.  Basically there's two ways to quit a speed setting, and I only really implemented one. And used it for everything. I think it forces the decel when you exit a speed like that.
--
My strategy here is often squeaky wheels get the grease. Since I imagine there's dozens more people not saying things for all the people who are, and quick results might encourage more feedback. Odds are quite good all three of those will be added before next version. Especially considering two of them area already in the 0.5.2 branch.

@josemariaaraujo Okay, and the final correction got added to 0.5.2. Implements the @ command which should go markedly faster for those transitions.
Far from taking offense, I'm much more likely to move any suggestion offered to the top of the pile. Have any more?

For record keeping:

Custom positions. can't reset them after saving the first time,
Don't work if the cursor isn't over the graphic view, like when it's over the navigation window.
The rearrange of items is a bit weird when multiples are selected. Sometimes it flags the item based on the object backing it, but that's actually unhelpful since there can be multiple copies of the same item in the same job.

Thank you all for prompt replies and accepting my suggestions.
I'm just a hobbyist without professional experience that uses the k40 from time to time , those issues where the ones that standed out the most to me. Surely when more proficient users appear they will have more and better suggestions.

Most K40 users are hobbyists and while I'd like to also help out professional folks too, there's no reason to devalue your contributions. And I don't see lots of more proficient users raising issues. I'll triage the grease when there's more people offering stuff but until then, the most recent squeaky wheel. Most of these things are on the agenda but the order those items are dealt with or their importance given to them isn't something I have firm grasp on. In fact, it undervalues those contributions more because really intuitive UI should be obvious to new users.

Most of these are live now.  I pushed it to the next version.

The hotkeys things is fixed in 0.6.0 though the text movement thing might just not be feasible and I should maybe allow the arrow keys to default to arrow keys. Maybe using shift arrow keys to do jogging instead, so you can use them in the tree menu just as easily.

I moved the arrow keys to the WASD keys so they don't overlap. And added the hotkey things.
This issue was corrected in 0.6.0. Which is now in full release.


Remove regexpi logic, Augeas 1.0.0 was released 8 years ago

Coverage increased (+0.7%) to 97.917% when pulling 4a8b34c04f3163dd7266d87b0ab6106ddcf8414b on raphink:regexpi into 178d6aa07c1020399a21184f6f8d414f7e9ebc05 on hercules-team:master.


Think about why the Repository needs username and ssh key and password

Maybe for a command which wants to clone the repository and needs private access. The repository itself doesn't clone anything, it doesn't require authentication. The hook itself needs to be public only.

It passes in access to the repository to commands so we don't have to set up each command with access to the repository continuously.


powertoys run doesn't work anymore

Microsoft PowerToys version
0.86.0
Installation method
WinGet
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
So, when i startup my pc, i have to close PowerToys and then re-open it in order to get PowerToys Run to work. It is essential to me due to the fact i work on multiple monitors.
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

/bugreport


Create unit test for the influx query cli command

Add unit tests to ensure the query cli has tests for it functioning with different options.

Unit tests have been added to the query command in the new CLI repo, so closing this.


[FEATURE] Add new secrets manager implementation (Azure Key Vault)

📝 Feature Description
We need to expand our secrets manager support by integrating Azure Key Vault. Currently, our system supports three secrets manager interfaces: AWS KMS, Hashicorp Vault, and Plaintext. Adding Azure Key Vault will provide users with an additional option for securely storing sensitive configuration settings.
🔨 Possible Implementation

Research Azure Key Vault API and integration methods.
Develop a new secrets manager interface for Azure Key Vault, following the patterns established by existing integrations (AWS KMS, Hashicorp Vault).
Implement necessary authentication and access methods for Azure Key Vault.
Create functions to store, retrieve, and manage secrets using Azure Key Vault.
Ensure the new integration adheres to our existing security standards and practices.
Update configuration options to allow users to select Azure Key Vault as their secrets manager.
Develop comprehensive tests to verify the functionality and security of the Azure Key Vault integration.

🔖 Note:
The implementation should maintain consistency with our existing secrets manager interfaces while accommodating any Azure Key Vault-specific features or requirements. Ensure that the integration is scalable and performant, considering potential high-load scenarios.
Submission Process:

Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
Once assigned, submit a pull request (PR).
Maintainers will review and provide feedback, if any.
Maintainers can unassign issues due to inactivity, read more here.
For this issue, please raise a PR to juspay/hyperswitch-card-vault.

Refer here for Terms and conditions for the contest.

interested please assign @NishantJoshi00

Hey @gagandeepp Assigning this to you, thanks for your interest!

As this issue has been un-assigned, can this be assigned to me please?

Sure @TheVidz Assigning this to you.
Thanks for your interest!

Hey @TheVidz
Kindly let us know, if you're still working on the issue? If you have any questions or need assistance, feel free to reach out in the community.

I'm sorry, I couldn't figure it out, you may assign the issue if someone else can..


Try to fix macos building problems

Somehow, the linking command "ar" cannot be found.
Setting the cmake_compiler_launcher should be enough.
No reason to set CC/CXX variables, which seems to cause issues.

Ok, but doesn't this line: https://github.com/DLR-SC/tigl/pull/726/checks?check_run_id=940419430#step:19:40 mean that we are not using ccache but the native compilers?

No, we still have the line
https://github.com/DLR-SC/tigl/blob/master/.github/workflows/build-test-deploy.yml#L202
which takes care of this.

I just checked that ccache is still beeing used:
https://github.com/DLR-SC/tigl/runs/940372983?check_suite_focus=true#step:19:72

Ok, perfect!


Cluster SSH Features

Description of the new feature/enhancement

Cluster SSH support to open  and control multiple terminal windows to ssh to devices auto-scaling and arranging windows on the screen with one command window allow you to input to all windows
ping_test argument to ping devices to check if live instead of auto opening a window
sorthosts argument to sort windows by hostname
host range support using square brackets examples: hostname[0-10], 192.168.0.[5-20], host-[prod,dev][a-f], 192.168.[0,2-3].[1-2,3-5]

Related to Windows Terminal and SSH. I was playing around with the recently added wt command-line arguments and I put together a URL Protocol handler helper script that will launch ssh://someuser@someserver:port URLs in Windows Terminal using OpenSSH or Plink. https://github.com/vbyrd/windows-terminal-ssh-protocol-handler
Cluster SSH type functionality would be quite nice to have. It's saved the day for me many times.

Hey @ryanmerolle; thanks for the feature request!
This would be a great opportunity for a plugin author once we get plugin support (#4000.)
I'm not sure that this sort of feature belongs in the terminal core -- we're focusing on making a great local terminal experience first and foremost -- and I think that anything we do internally would naturally play second fiddle to that. In light of that, I'm going to close this one out after linking it up to #4000 as an interesting thing that plugins could enable.
Thank you!


Compilation Error: rs-align example on VS2017

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win 10

Kernel Version (Linux Only)

Platform
PC

SDK Version
2.16.1

Language
C++

Segment
others

Issue Description
Hello once again,
Unfortunately I have ran into errors which I have spent 2 days trying to solve. I have asked this question once before, and @dorodnic has given me guidance but I am still having trouble with it.
Things I have done

Created new empty C++ Project, copied [example.hpp, int-rs-splash.hpp, stb_easy_font.h, stb_image.h, stb_image_write.h] into File Explorer
Copied intel.realsense.props in Property Manager
Copied [imgui.cpp, imgui_draw.cpp, imgui_impl_glfw.cpp] into File Explorer
VS > Properties > C/C++ > General > Additional Include Dirs > Edit > (C:\Users\efoo1\Desktop\RealSenseCmake\third-party\imgui)
Created Source.cpp under source and copied the code from rs-align.cpp into it
VS > Solution Explorer > Source > Add Existing Item > and copied [imgui.cpp, imgui_draw.cpp, imgui_impl_glfw.cpp]

Here is how my Solution Explorer looks:

Errors

Line 5 has errors, but I figured since I manually copied example.hpp into the project in File Explorer, #include "example.hpp" directly would make more sense.
Line 25 is a bigger error, it says "no suitable conversion function from "window" to "GLFWwindow*" exists".. I don't get it since this works on CMake.

If I comment Line 25 out, I still get a magnitude of errors.. on the imgui_impl_glfw.cpp file, not on Source.cpp.

I tried to add the GLFW library into the Properties Pages and shown below. (I downloaded the GLFW files and placed it on my Desktop)

4.1. Properties > VC++ > Include Directories > (C:\Users\efoo1\Desktop\glfw-3.2.1.bin.WIN64\include)

4.2 Properties > VC++ > Library Directories > (C:\Users\efoo1\Desktop\glfw-3.2.1.bin.WIN64\lib-vc2015)

4.3 Properties > Linker > Input > Additional Dependencies > glfw3.lib & glfw3dll.lib

Lastly, I copied the glfw3.dll into the Project File Explorer.

Problems still
I am still getting so many errors during linking even after trying so many things...

CMake
NOTE: CMake works, but the problem is I cannot modify on it. Hence, I am trying to create the project from scratch and manually include the directories..
I am losing my sanity.. any help would be 150% appreciated. Thank you guys, you're my last hope

Edit 1: I just found out that on the CMake version of rs-align, the code inside #include "../example.hpp" is quite different from the #include "example.hpp" in the other simpler examples such as rs-align. So a simple copy edit of the #include is not possible...
Source Code:
#include "../example.hpp"
#include "example.hpp"
Will change it and see how it goes

[Realsense Customer Engineering Team Comment]
Hi @HippoEug,
You can build the all librealsense project and open "RealsenseExamplesAlign.sln". Then, you can apply the similar settings, files and libraries to your rs-align project.

Yeah I have tried that, had errors. But I think I found the fix for it.. but using 32bit binaries. Still gotta figure the x64 one out!

My standalone rs-align project also attached for reference.
rs-align-standaloneBuild.zip

Thank you freemanlo, that's very helpful :D

[Realsense Customer Engineering Team Comment]
Hi @HippoEug,
Still need any support for this topic?

Note: in the upcoming release the installer is going to include rs-align, post-processing, playback-record and opencv examples based on @HippoEug and others feedback.


Change openprescribing.net/caution so it doesn't redirect to RocketChat

Typing in openprescribing.net/caution directs you to the rocket chat rather than to openprescribing. Not sure if this is happening on other links, I tried openprescribing.net/analyse and openprescribing.net/ccg and they both went to the right page
www.openprescribing.net/caution goes to the right place, and so does https://openprescribing.net  - seems to be http:// that is the problem
Tried it on chrome and firefox

Thanks, well spotted Lisa! This is probably related to our CloudFlare move earlier today - will have a look at it now.

Fixed.


Fixed bugs in handling race condition for verified status / Fixed a bug when domain mgr deletes container .aci file in Verified dir.. It should not.

1) Fixed a raceCondition in using VerifyImageStatus in zedmanager. Make sure there vs.RefCount > 0 OR there is a
Verifier config already existing before using it. This is the main Fix. The rest are just cleanups.
    - Refactored processing of Images with VerifierStatus present into doInstallProcessStorageEntriesWithVerifiedImage
    - The real fix is really a few lines:
        if vs.RefCount == 0 && verifyImageConfig == nil:
               return // Treat like verifier status not found. Re-download the image..

2)     For containers, do not delete .aci file in the Verified directory from
domainMgr..
2) Fixed a logMfg from Errorf to Infof
3) Added a couple more Info messages in Verifier to make it easy to debug.
4) Removed uuidStr as an argument to functions taking AppInstanceStatus as another     argument. Passing uuidStr as another arg is superfluous in such cases - doUpdate, doInstall, doPrepare, doInactivateHalt
5) Removed safename argument from MaybeAddVerifyImageConfig as it is part of StorageStatus already which is another arg.

You really want to make it painful to code review by including random cleanup so that the important code changes are harder to find ...
Why don't you need to remove the ACIDir? Where does it get removed?

[Kalyan] As discussed, Verifier removes it..

There are two calls to lookupVerifyImageStatusAny() but you are only fixing one of them to check for the existence of config?

[Kalyan] Good catch.. Fixed..

The DownloaderStatus check has the same issue as the VerifyImageStatus check hence I'd suggest to make those checks be identical using functions with a consistent naming scheme.

[Kalyan] Good Catch.. Fixed..


Disable menu opening with right/left swipe touch events on certain div

I have an interactive map and whenever the map is browsed by zooming in and scrolling with swiping, the menus open. I would like to disable the right/left swipe touch events for the sidr menu or keep the sidr menus hidden when users swipe the #map.

Sidr do not implement swipe, so you it's not going to be solved here. Try to paste your code in stackoverflow.com


Doesn't work with node.js websocket

Doesn't work with node.js websocket. Code be at node's end but then node works with other android websocket clients.

It works well with node.js too. I am using this library only

version 2.0.0 is live which fixes some problems with NodeJS websocket


Accepts email address "John Doe<EMAIL_ADDRESS>but sets incorrect header when sending

I'm using version 4.4.5
According to the RFC John Doe<EMAIL_ADDRESS>is a valid email address.
The email validator does recognize that it is a valid email, but when it comes to actually setting the email headers, it (I assume) incorrectly wraps it in angle brackets again, resulting in the address <John Doe<EMAIL_ADDRESS>The location which this happens is in
MimeMessageHelper line 108. See attached image.

That is by design, to achieve the best compatibility with clients receiving the email
.
Are you facing a problem?

I guess I'd expect an address that has passed validation by EmailAddressValidator to send fine, but currently it's throwing an exception in InternetAddress#parse when I actually try to send the email.
It seems like github has swallowed some of the characters I typed in the opening post. I have updated it

Can you post a sample code where you provide the address? A failing junit test would suffice too.

Here you go @bbottema. https://github.com/jatcwang/repro-simplejavamail
Reproduced on 4.4.5, 5.0.0 doesn't seem to have this issue. (check git commit history)
I initially pulled in 4.4.5 for my project because v5 was still in beta, but now I can just upgrade and this shouldn't be a problem for me anymore.
Feel free to close this ticket if you're not planning to fix v4 series.


Awesome kit! Some questions..

I'm new to React-Native and I've spent the last couple of weeks on reading up and testing stuff. Everything is awesome, except there is no "best practice" to find anywhere. I'm struggling to find my own way of organizing files, organizing Redux, Navigate between views, etc.
Pepperoni with it's nice documentation gives me a great foundation and best practice. I like almost everything (Redux, Ducks, Coding style, etc), but maybe not Immutable.js. I'll give Immutable a good try though.
I have a couple of concerns:
1. Local storage and memory consumption of Redux Store.
Since AsyncStorage is used to save the complete state of the app as one big blob, there is no way to load the initial state (i.e. last snapshot) in a prioritized order. I was about to use SQLite or something for local storage, since I'll have a lot of data in the app.

How much data is reasonable to have in the Redux State? Should I throw out old data after a while and force the app to refetch this from the server when/if it's needed again?
I'll have a lot of image files in my app. Those are synced with the server and lives as files on the device local disk. My plan is to reference those files from the Redux State as kind of foreign keys (UUID). I'm thinking of having a separate slice in the state for images, but only for metadata such as isLoaded, etc. Does this make sense?

2. Upgrading
I assume/hope that Pepperoni will continue to evolve. What is the preferred concept of upgrading apps based on Pepperoni?

Are there distinct places/files in Pepperoni which could be upgraded?
Or would upgrading take a large amount of diff checking and merging?

3. dependencies
pod install got me a bunch of Cocoa Pods. Where are those used in Pepperoni? I have never used pods before. Are there similar Android "pods" available, or will these pods make the app single-platform?

@michaelswe There are some simple methods for ensuring state isn't mutated without using Immutable.js. My preference being implicit use of Object.assign by using ES7 Object Spread as described by Dan Abramov in Getting Started With Redux. I for one would eagerly like to see Immutable removed in favor of unit testing to ensure stat hasn't changed as Abramov explains in his video tutorials.

@michaelswe thanks for your interest and questions. Here's short answers:

How much data is too much? It's too much once it starts to have negative consequences, I suppose - either for the memory consumption of the app, or the startup time when rehydrating the state.

The serialization setup we use has been more than adequate for all the apps that we've built, but it won't scale indefinitely. We have implemented cache pruning on startup (we use Immutable records and add a creation timestamp to all record instances, and only rehydrate records fresher than n days). It works well and would love to open source this as part of Pepperoni, but the IP belongs to one of our customers, so we need to implement that from scratch.
At some point, you may want to look at a database like SQLite or Realm.

Upgrading is discussed at https://github.com/futurice/pepperoni-app-kit/issues/68

CocoaPods is a package manager for iOS, similar to what npm is for node and gems are for Ruby. Some React Native dependencies can be managed with former rnpm (now included in react-native core), but other package vendors choose to use platform-specific tools. In our case, the Auth0 component requires use of CocoaPods.

CocoaPods is a huge PITA, but it will be useful for any non-trivial app that targets iOS, so we chose to include it in Pepperoni.
It doesn't make the app single-platform, it simply manages and links the iOS-specific libraries and SDKs. If you use some native iOS library to achieve a certain functionality on iOS, you'll need to obviously implement the same functionality in Android yourself.

Thank you!
I'm not using Auth0, which means I'll have no Pod dependence for now.
Right now I'm trying to wrap my mind around the routing. I guess most of the logic around this will be found in NavigatorExperimental? I don't know if I should post my routing questions here or maybe try on Reactiflux.

We are not fully satisfied with the routing system we have in place - tracking work on that in https://github.com/futurice/pepperoni-app-kit/issues/51.
Reactiflux is better for general React Native issues as we currently have very limited time to provide support here, and our implementation is only a very thin abstraction over the NavigationExperimental anyways.
Closing this issue now, if you have any more specific Pepperoni-related questions, feel free to open new issues, or as you said yourself, turn to the Reactiflux community.


[nrf52x] allow users to implement power setting functions

When users add a FEM after the radio chip, the actual output power is
determined by both the radio chip and FEM. The radio driver only provide
a function to set the radio output power. This PR adds Macros and functions
to allow users to implement the power setting functions by themselves.

@LuDuda  The Nordic radio driver has implemented a FEM abstraction layer and the FEM abstraction layer only support  FEM pin PA, LNA and PDN. The FEM is using the pin CPS, CHL in our product. We have  asked Nordic to add CPS and CHL pin control logic to the Nordic’s FEM abstraction layer, but Nordic seems doesn’t want to do it (JIRA).  So we added these pin control logic in our internal source code.  Besides,  the FEM abstraction layer only control the FEM pins, it doesn’t set the FEM gain. We add these FEM  functions to update the radio power and FEM gain in the radio driver.

@LuDuda The Nordic radio driver has implemented a FEM abstraction layer and the FEM abstraction layer only support FEM pin PA, LNA and PDN. The FEM is using the pin CPS, CHL in our product. We have asked Nordic to add CPS and CHL pin control logic to the Nordic’s FEM abstraction layer, but Nordic seems doesn’t want to do it (JIRA). So we added these pin control logic in our internal source code. Besides, the FEM abstraction layer only control the FEM pins, it doesn’t set the FEM gain. We add these FEM functions to update the radio power and FEM gain in the radio driver.

Thanks @zhanglongxia. @hubertmis will comment on Radio Driver part as soon as possible.

@edmont  The function nrf_802154_tx_power_set only update the internal power variable, it's not really setting the output power. We are using the function nrf_802154_fal_tx_power_get to update the output power. So I removed the macro OPENTHREAD_CONFIG_ENABLE_PLATFORM_POWER_CUSTOM_SOURCE  from the radio driver.


Test issue

Testing Exported webhook 🤔

Triggered auto assignment to @timszot (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Sorry @timszot this was a test! Seems the Exported label autoassigner is working again 😅