Always bumps with new patch versions unless passing with the argument?

It seems the tool always bumps with new patch versions, regardless of the types and number of changelogs it parses.
Will it possible to automatically detect what version level it should bump to based on the changelogs it parses.
For example, based on semantic versioning,
If there are incompatible API changes or BREAKING changes, it may bump with a new major version.
If there are feature updates, it may bump with a new minor version.
If there are only bug fixes, it may bump with a new patch version.
This is necessary for continuous integration because it is not always possible to pass the version level argument.

Can you give examples of config and git logs where this does not work? The whole point of this tool is to read this from the commit log and release the appropriate version. If it is behaving as you say that is a bug 🐛

I didn't config anything. The command I ran is just semantic-release publish.
The semantic-release changelog outputs multiple features, and bug fixes updates.
Feature
Support threads scheduler in pipeline (b13094b)
Add "max_processes" to the pipeline constructor to set the maximum processes to be used (cdfb092)
Pipeline class now works for multiple streams (bbe891e)
...

What git logs are you looking for?
I think this should be easy to reproduce by making some testing commits.

What happens when you run DEBUG=semantic_release:* semantic-release publish?

I think this should be easy to reproduce by making some testing commits.

Yes, we have tests for this which are currently passing.

@relekang - wondering if we can re-open this issue, as I am facing a similar problem...
I am using python-semantic-release with the default commit parser on GitHub Actions. I am experiencing the same described issue. To quote @qutang above, "It seems the tool always bumps with new patch versions, regardless of the types and number of changelogs it parses."
I have tried various commit messages to no avail. Examples include a direct copy of a breaking change commit from the angular.js example (bottom of this page). This commit reads:
feat($compile): simplify isolate scope bindings

Changed the isolate scope binding options to:
  - @attr - attribute binding (including interpolation)
  - =model - by-directional model binding
  - &expr - expression execution binding

This change simplifies the terminology as well as
number of choices available to the developer. It
also supports local name aliasing from the parent.

BREAKING CHANGE: isolate scope bindings definition has changed and
the inject option for the directive controller injection was removed.

To migrate the code follow the example below:

Before:

scope: {
  myAttr: 'attribute',
  myBind: 'bind',
  myExpression: 'expression',
  myEval: 'evaluate',
  myAccessor: 'accessor'
}

After:

scope: {
  myAttr: '@',
  myBind: '@',
  myExpression: '&',
  // myEval - usually not useful, but in cases where the expression is assignable, you can use '='
  myAccessor: '=' // in directive's template change myAccessor() to myAccessor
}

The removed `inject` wasn't generaly useful for directives so there should be no code using it.

However it only resulted in a patch bump as observed here:

I also tried using one of your test commit messages that should result in a major version bump.
This commit reads:
feat(x): Add super-feature

BREAKING CHANGE: Uses super-feature as default instead of dull-feature.

Same behaviour was observed, just a patch version bump was created:

I also did as you suggest earlier, running it with DEBUG=semantic_release:* set as an env variable. Here's the output of the logs:
Run git config --local user.email<EMAIL_ADDRESS>From https://github.com/***/foocat
 * branch            master     -> FETCH_HEAD
Already up to date.
Creating new version..
Current version: 0.12.10
Bumping with a patch version to 0.12.11.
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:cli 'main args:' {'force_level': None, 'post': False, 'retry': False, 'noop': False, 'define': ()} +0.0us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:cli 'main env:' 'PYPI_USERNAME="None",PYPI_PASSWORD="None",GH_TOKEN="$GH_TOKEN",GL_TOKEN="None",' +131.75us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:cli 'main config:' {'check_build_status': 'false', 'commit_message': 'Automatically generated by python-semantic-release', 'commit_parser': 'semantic_release.history.angular_parser', 'patch_without_tag': 'true', 'upload_to_pypi': 'false', 'version_source': 'commit'} +148.0us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:history 'get_current_version_by_config_file' +0.0us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:history 'foocat/__init__.py' '__version__' +56.25us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:history <re.Match object; span=(0, 23), match="__version__ = '0.12.10'"> +535.25us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:history:logs 'evaluate_version_bump("0.12.10", "None")' +0.0us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:vcs_helpers 'Reference v0.12.10 does not exist, considering all log' +0.0us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:history:parser_angular "parse_commit_message -> (2, feature, x, ('Add super-feature', '    BREAKING CHANGE: Uses super-feature as default instead of dull-feature. ', ''))" +0.0us
Tue, 18 Feb 2020 16:02:42 GMT semantic_release:history 'get_new_version("0.12.10", "patch")' +11.1ms
Bumping version from 0.12.10 to 0.12.11
[master 92881de] Add changes
 1 file changed, 1 insertion(+), 1 deletion(-)

If it's helpful, here is my GitHub Actions workflow: https://github.com/ttimbers/foocat/blob/master/.github/workflows/release.yml
note - I opened the #175 because I need to bump both an __init__.py file and pyproject.toml, and my work around currently is to use poetry run semantic-release version followed by poetry version ... and then manually committing and pushing changes to bump both files.
And my commit history for the repo I am testing this out on: https://github.com/ttimbers/foocat/commits/master

Thanks for re-opening @relekang !

@ttimbers Can you try 4.6.0?

@relekang - I have upgraded my dep's to 4.6.0 but it still doesn't seem to be working on my CI. I tried 3 times with 3 different commit messages... Here is the log from the last commit message (which I also paste below) and the version bump it did was just from  0.12.22 to 0.12.23.
Commit message:
feat(x): Add super-feature

BREAKING CHANGE: Uses super-feature as default instead of dull-feature.

CI logs:
Run git config --local user.email<EMAIL_ADDRESS>From https://github.com/***/foocat
 * branch            master     -> FETCH_HEAD
Already up to date.
Creating new version..
Current version: 0.12.22
Bumping with a patch version to 0.12.23.
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:cli 'main args:' {'force_level': None, 'post': False, 'retry': False, 'noop': False, 'define': ()} +0.0us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:cli 'main env:' 'PYPI_USERNAME="None",PYPI_PASSWORD="None",GH_TOKEN="$GH_TOKEN",GL_TOKEN="None",' +72.75us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:cli 'main config:' {'check_build_status': 'false', 'commit_message': 'Automatically generated by python-semantic-release', 'commit_parser': 'semantic_release.history.angular_parser', 'patch_without_tag': 'true', 'upload_to_pypi': 'false', 'version_source': 'commit'} +82.25us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history 'get_current_version_by_config_file' +0.0us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history 'foocat/__init__.py' '__version__' +30.0us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history <re.Match object; span=(0, 23), match="__version__ = '0.12.22'"> +394.25us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history:logs 'evaluate_version_bump("0.12.22", "None")' +0.0us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:vcs_helpers 'Reference v0.12.22 does not exist, considering all log' +0.0us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history:logs 'ignored commit' UnknownCommitMessageStyleError("Unable to parse the given commit message: Merge branch 'master' of github.com:***/foocategoricals\n") +10.2ms
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history:logs 'commit_count=1' +189.75us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history:logs 'Changing bump to patch based on config patch_without_tag' +57.0us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history:logs 'evaluate_version_bump returned patch' +46.25us
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history 'get_new_version("0.12.22", "patch")' +10.5ms
Bumping version from 0.12.22 to 0.12.23
[master 212c20a] Add changes
 1 file changed, 1 insertion(+), 1 deletion(-)

This line might be where the error is occurring:
Wed, 19 Feb 2020 20:24:15 GMT semantic_release:history:logs 'ignored commit' UnknownCommitMessageStyleError("Unable to parse the given commit message: Merge branch 'master' of github.com:***/foocategoricals\n") +10.2ms

However, that doesn't quite make sense to me given that I copied the commit message from your tests?

I checked the github action log and it clones the repo with depth=1 so the only available commit is the merge commit.

OK, thanks for tracking down my error - I am new to GitHub Actions, and I missed this. I'll look into the docs and see how I can clone with more commits (i.e., depth > 1) and report back.

This does indeed fix it. I apologize for sending you down a 🐇 hole. Closing this issue now, and many thanks for your help. This is a very cool project and I am grateful for your work on it.

No worries, we found a pretty bad bug and got it fixed with 1daa4e2. Thank you for the thorough description, it helped a lot.


Enable extension based on project type

I enjoy using vscode now I use vscode for my (flutter, python+django, JS/TS [react, firebase]) projects
for flutter I was using Android Studio but gradually switched to vscode.
to enable extensions based on projects (dart+flutter or python+django or js+react) I used profile switcher (seems inactive recently, last commit 7 month ago)
I like the way profile switcher works
From user's standpoint I create profile (flutter-env), (django env)
for each profile I install vscode extension, and settings.json
later I just switch profile and it automagically installs extensions and setup settings.json
So it feels like dedicated ide for my environment
vscode + profile switcher seems like dedicated ide (example intelij ides)

I do not understand your request here. Can you please let us know if you are requesting a feature from VS Code and if so what is it?


Subflow issue when deleting part of a payload after its seconds use

Current Behavior
First function block in the subflow pulls a msg from an environment variable. Second function node does a node.send for msg.payload.scene_recall only. It then deletes msg.payload.scene_recall and sends the remaining msg.
After a deploy, msg.payload.scene_recall is 1 after pressing the inject which is what I am expecting, but all subsequent values after pressing inject again are undefined. Redeploying again fixes the first use of it, then continues to return undefined.
Removing the delete function works, but I don't want msg.payload.scene_recall in the second output message.
Expected Behavior
Every press of the inject should result in msg.payload.scene_recall having the value of 1, as it is defined in the environment variable. In Node-RED 3.0.2 which I have running at work, importing this flow works as expected.
Steps To Reproduce
On a fresh install using the Pi script for 3.1.3, importing the example flow shows the unexpected behavior.
Example flow
[
    {
        "id": "e65d31bfdddd6304",
        "type": "subflow",
        "name": "Subflow",
        "info": "",
        "category": "",
        "in": [
            {
                "x": 50,
                "y": 30,
                "wires": [
                    {
                        "id": "a1406e94a89f74f0"
                    }
                ]
            }
        ],
        "out": [
            {
                "x": 410,
                "y": 30,
                "wires": [
                    {
                        "id": "25253845f3c71d51",
                        "port": 0
                    }
                ]
            }
        ],
        "env": [
            {
                "name": "on_press_release",
                "type": "json",
                "value": "{}"
            }
        ],
        "meta": {},
        "color": "#DDAA99"
    },
    {
        "id": "25253845f3c71d51",
        "type": "function",
        "z": "e65d31bfdddd6304",
        "name": "Send",
        "func": "node.send({ payload: { scene_recall: msg.payload.scene_recall} });\ndelete msg.payload.scene_recall;\nnode.send(msg);",
        "outputs": 1,
        "timeout": 0,
        "noerr": 0,
        "initialize": "",
        "finalize": "",
        "libs": [],
        "x": 300,
        "y": 30,
        "wires": [
            []
        ]
    },
    {
        "id": "a1406e94a89f74f0",
        "type": "function",
        "z": "e65d31bfdddd6304",
        "name": "Get",
        "func": "msg = env.get(\"on_press_release\");\nreturn msg;",
        "outputs": 1,
        "timeout": 0,
        "noerr": 0,
        "initialize": "",
        "finalize": "",
        "libs": [],
        "x": 160,
        "y": 30,
        "wires": [
            [
                "25253845f3c71d51"
            ]
        ]
    },
    {
        "id": "84938341927d6224",
        "type": "inject",
        "z": "33871f41.a966a",
        "name": "Inject",
        "props": [
            {
                "p": "payload"
            }
        ],
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "topic": "",
        "payload": "",
        "payloadType": "date",
        "x": 330,
        "y": 3500,
        "wires": [
            [
                "6886a99e68258e66"
            ]
        ]
    },
    {
        "id": "3a48d53a659dc67f",
        "type": "debug",
        "z": "33871f41.a966a",
        "name": "Output",
        "active": true,
        "tosidebar": true,
        "console": false,
        "tostatus": false,
        "complete": "payload",
        "targetType": "msg",
        "statusVal": "",
        "statusType": "auto",
        "x": 650,
        "y": 3500,
        "wires": []
    },
    {
        "id": "6886a99e68258e66",
        "type": "subflow:e65d31bfdddd6304",
        "z": "33871f41.a966a",
        "name": "",
        "env": [
            {
                "name": "on_press_release",
                "value": "{\"payload\":{\"state\":\"ON\",\"brightness\":52,\"transition\":1.6,\"scene_recall\":1}}",
                "type": "json"
            }
        ],
        "x": 490,
        "y": 3500,
        "wires": [
            [
                "3a48d53a659dc67f"
            ]
        ]
    }
]

Environment

Node-RED version: 3.1.3
Node.js version: 18.19.0
npm version: 10.2.3
Platform/OS: Debian 12.3
Browser: Chrome 120.0.6099.71

Env properties are intended to be read-only values that should not be updated by flows.
You've found an edge case where using a JSON type env gives you an object that you have been able to modify. That is not intended behaviour.
In 3.1 we changed how env vars are evaluated - they get evaluated at start rather than on-demand. This likely explains the change in behaviour you've seen.
If you want to store values that can be modified by the flows you should use context.

Hi Nick, thanks for the reply!
Forgive my basic understanding, but I am just reading the env var to a msg and then changing the msg? The msg should be temporary, gone as soon as the subflow is finished? I don't understand why it is changing the env var, I'm not intending to change it. Like with context I have to flow.set and there is no env.set.
But if I add msg.payload.scene back after my second message it works as I intend so thank you!

Ah okay. I can see what's happening - will sort out a fix to avoid the (unintended) downstream modification of the env var.


[Bug]: Without permissions to environment, the user is not able to requests they are assigned.

SubTasks
Without permissions to environment, the user is not able to requests they are assigned.

@nsarupr  - didn't we close this with the permission fix we did last week?


Reconsider approach with cliaas

Please take this as a suggestion / constructive feedback after using these for a few months on AWS, Azure, and vSphere
The most easy to debug and customize IaaS for pcf-upgrades and installs is vSphere because of the use of govc.   Whereas the other clouds Ops Man pipelines have not once done what I'd expect, and have required many rounds of debugging to tweak my setup to the expectations of cliaas.
While golang as a CLI is great, using golang effectively as a scripting language (as it is here, since there are so many variations in the task) has major maintainability problems in the wild.
These pipelines need to be customized for specific customer environments, and unless cliaas is going to handle almost every permutation of variation, it's a black box to system administrators who are never going to learn golang , so people will wind up writing their own scripted CLI , or IaaS Template (Azure ARM template, AWS CF, etc.) or terraform-based version of the task.  I'd much rather have something easily tinker-able like this.
that said if the goal is to have cliaas "just handle it all", kudos, it's just not there for a while.
Examples include

use of private vs public IPs,  #51
customized disk settings (it uses the VMDK/VHD/AMI defaults which are usually far too low)
reserved IOPS for disks
multi-homed NICs for Ops Man
common post-processing for Ops Man including: TLS certs, LDAP PAM setup

Go isn't being used as a scripting language here, it's using the SDKs provided by the IaaS. govc does the same; it just happens to be a binary that's also released by VMWare.
cliaas is there to handle a specific problem of us wanting a single interface for doing specific things, like replace-vm. It is not meant to "handle it all".
If there are specific features you'd like or issues you are having with the pipelines, please open issues for them as they arise so we can address them.


Create file storage (different package)

Created as new project https://github.com/twlv/twlv-storage-file


Notifications for changed balance

The app could display a notification when a wallet balance changes.
Because there is no way to use PUSH notifications (would need a server), the app would need to refresh from time to time. As this is background work, a setting for the refresh interval is needed (for example off / 1 hour / 2 / 4 / 6 / 12 / 24h)

iOS: https://developer.apple.com/documentation/uikit/app_and_environment/scenes/preparing_your_ui_to_run_in_the_background/using_background_tasks_to_update_your_app

Would be a good addition for send/receive of transactions to send notification to apps OS notification service.

Would be a good addition for send/receive of transactions to send notification to apps OS notification service.

Please upvote so that I can decide by the upvotes which feature to do next. :)


Audio choppy and general server performance is slow

When testing with two people on a Google Cloud server, the performance was not good. The audio was very choppy. And there was some noticeable lag at times.

Planning to use Mediasoup to separately handle video/audio from players since it's more scalable. Though not sure it resolves the audio problem. It may just be an implementation issue. But I think in the long mediasoup is a better approach anyway.

Audio is a lot better now with the mediasoup server. However dealing with a new disconnection issue now.


Add to preserve layer opacity

Whenever we replace a symbol library, it replaced a set of layers from the selected library styles. But it forgets to preserve its opacity, and hence everything becomes filled as 100%. The problem is some of its nested elements having the same colors get merged. The example below has two layers, both of them are having the same color styles but the difference in opacity. So after applying camilo, the icon gets merged with its outer circle due to same color. If we can retain the color opacity it could solve the problem.

I'm afraid it's not possible since that way it wouldn't work in all scenarios. I recommend you to create a new layer style for that icon background.


Fix visualization tool

Fix probability and magnitude order mismatch in policy.
Change file name to lower case for file naming consistency.

Thanks!


Add GeoSpark Core Python API #394

Is this PR related to a proposed Issue?
#394
What changes were proposed in this PR?
GeoSpark Core Python API
How was this patch tested?
over 400 unit tests (some of them are rewritten from GeoSpark Java/Scala code)
Did this PR include necessary documentation updates?
Yes, docs/tutorial/geo_spark_core_python.md

@Imbruced Hi Pawel, thank you very much for this PR and thank you for your hard work.
Having said that, I have noticed a couple of things that we should do in order to draw GeoSpark 1.3.0 release. As we agreed, GeoSpark 1.3.0 will include two separate parts, Scala/Java API (which are jars hosted on Maven Central) and Python (which are packages hosted on PyPi)
First of all, I have made a cut on GeoSpark Scala/Java API on core, SQL and Viz components, for Spark 2.1, 2.2., 2.3+. You now can find them on Maven Central.
For GeoSpark RDD Python and SQL Python API,

Can you please make them have the same version numbering with GeoSpark, i.e., 1.3.0? So the users won't be confused by inconsistent version numbers.
Can you please upload the release of all GeoSpark Python code to PyPI using the account that shared by me? In GeoSpark python tutorials, I saw you mentioned "pip install geo_pyspark" but I didn't see the corresponding release on our PyPI account.

Does this make sense? Please feel free to correct me.

Hi,

I can use your version numbering.
Currently I am uploading library on Test PyPI https://test.pypi.org/project/geo-pyspark/. I want to be sure that everything works as it should. After that process I will release official version on PyPI and update existing documentation and create next PR.
Regards,
Paweł

GeoSpark Python is available on PyPi https://pypi.org/project/geo-pyspark/ :)
I created pull request with changes (docs etc.).


Update ci.yml

Should make #807 work, the pipeline reports failures related to using a Dart version that's incompatible

I would not recommend merging PR without successfully passing all the checks.


Add a shared clipboard

Adds a textarea that acts as a shared bi-directional clipboard. This is based on vnc.html:

https://github.com/novnc/noVNC/blob/v1.2.0/vnc.html#L143-L157
https://github.com/novnc/noVNC/blob/v1.2.0/app/ui.js#L924-L966

This also means you can share the link to the current instance with a browser inside itself :smile:

Thanks @yuvipanda for pointing me here! Glad to see there's a start on this one - it's not absolutely critical, but will become a bigger and bigger annoyance the more we try to do "on the inside" of the hubs.
I've resorted to using the hub's firefox a lot more precisely so I can move information around, since at least inside this does work fine...

Just tested this, and it seems to work :) We can work on the styling later! Thanks a lot, @manics!

Many thanks! Has this been released? I was just about to freshen the stat159 image and it would be nice to have this finally solved :)

@fperez not yet, but maybe there may be one tomorrow! https://github.com/jupyterhub/jupyter-remote-desktop-proxy/pull/20#issuecomment-1396481381

Awesome, thx!

@fperez done! It has a different name though - https://pypi.org/project/jupyter-remote-desktop-proxy/

Awesome, thx!! I just updated the stat159 env, can I replace jupyter-desktop-server==0.1.3with jupyter-remote-desktop-proxy==1.0.0 now?
And if so, do you have a conda package for it yet, or should I go with pip for the time being?
cc @shaneknapp @balajialg in case this update is useful for other hubs than 159.

@fperez yep, just that change would do. It is a bit complex to package on conda, might be a while! So still gotta use pip

Thx Yuvi, np!

thanks @yuvipanda - just incorporated into dandihub. required the websockify piece from conda-forge as instructed in the readme. will be very helpful to folks.


UI Bug - Misaligned commands

Environment
OS - Windows 10
Windows build number: Version 10.0.18362.239]
Windows Terminal version (if applicable):0.2.1831.0

Any other software?

Steps to reproduce

Type a any command in the new terminal for example md new_folder_name
change directory to the new folder
Press the arrow up key
Causes the misaligned text in the terminal and duplication of the text randomly on the terminal window. See the below image

That's unusual. Nobody here can reproduce this. Are you sure there aren't more steps?
What version of powershell? of PSReadline?

Those are they only steps. I am using the Windows Terminal (Preview) Version: 0.2.1831.0

What version of powershell? of PSReadline?

Version of Powershell 5.1.18362.145.  Version of PSReadline  2.0.0

@LadyNaggaga You still seeing this? It's been like, 25 releases of the Terminal since this was originally filed, so there's a very good chance this was fixed by now. Sorry this got lost in the backlog!


perf: source map

Summary

perf: stream_chunks_of_source_map_full https://github.com/web-infra-dev/rspack-sources/pull/105
perf: reduce allocation https://github.com/web-infra-dev/rspack-sources/pull/107
perf: strict lifecycle and reduce allocation https://github.com/web-infra-dev/rspack-sources/pull/106

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench

!bench


Error message:  cannot execute processor android:adaptativeicons

Error message: cannot execute processor android:adaptativeicons

Please provide more details about issue.


Please add your planning poker estimate with ZenHub @jadmsaadaot @djnunez-aot @saravanpa-aot


Update/remove rebuild-isle notes from the isle-integration.md readme

Ah, this is still not quite right (there is no caching or hash-checking at all anymore); I'll do a quick PR to update. Thank you for noticing this, I should've updated the docs when I made the change!


CI: IntegrationTests: ClusterMeshTestSuite.TestWatchConfigDirectory: timeout while waiting for changed event

Observed in https://github.com/cilium/cilium/actions/runs/4471325368/jobs/7856059453?pr=24477
----------------------------------------------------------------------
FAIL: config_test.go:69: ClusterMeshTestSuite.TestWatchConfigDirectory

config_test.go:178:
    expectChange(c, cm, "cluster2")
config_test.go:46:
    c.Fatal("timeout while waiting for changed event")
... Error: timeout while waiting for changed event

logs_1265704.zip

one more here https://github.com/cilium/cilium/actions/runs/4574123785/jobs/8075367376?pr=24649

@giorio94 Are you looking into this?

@giorio94 Are you looking into this?

Yes, and I've a fix almost ready. I'll open a PR shortly.

The PR with the fix is open: https://github.com/cilium/cilium/pull/24993


adjust paths in the ct coverspec to include/exclude the appropriate directories in _build

i noticed you are also using distributed ct which rebar3 doesn't support (rebar3 currently has no way to start up other nodes) but the test suite completes ok despite this so i left it unaltered

It doesn't really fix it :/. What I'm interested in is getting proper coverage in rebar3's coverage table!


PRs are blocked from merging due to "3 new 404s were detected"

The "Install deps and build site" workflow for PRs is failing with:
Checking http://www-testing-pulumi-docs-origin-pr-13685-7c8079ec.s3-website.us-west-2.amazonaws.com/ for new 404s...
Checking 2014 URLs...

3 new 404s were detected:

/events/exploring-the-intersection-of-cluster-api-and-infrastructure-as-code/ : 403
/events/nginx-deploy-kubernetes-and-the-kitchen-sink/ : 403
/events/winning-the-product-agility-jackpot/ : 403

These are pages that exist on pulumi.com but do not exist at http://www-testing-pulumi-docs-origin-pr-13685-7c8079ec.s3-website.us-west-2.amazonaws.com./

Please make sure any content that's been moved has been an appropriate alias or redirect in place.

https://github.com/pulumi/docs/actions/runs/12438037440/job/34729145238#step:7:2779
This is blocking automatic merging of CLI release PRs

Hey @justinvp , we have some issues with that 404 checker that was inaccurately reporting issues. We made some updates to stop erroring on these for the time being. So we just need to update the PR branches with the latest from master and they should start passing now.  Though I'm guessing we only need the latest of those failed PRs since they are updating the same version file?


Implement missing UIBezierPath APIs and add tests

Implement some missing APIs in UIBezierPath in terms of CGPath. Some general clean up was also done. Automated pixel comparison tests were added as well as simple API tests for the newly enabled APIs.
Fixes #2700
Fixes #2701
Fixes #2702

This change is

The CI build passed but GitHub was down when it passed, so rather than re-run the build, synced with @MSFTFox offline and force merging this.


Update MD file on new branch 2017-32-03_09-12-53

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fix ℝ == ℝ

Fixes the following:
julia> ℝ == ℝ
ERROR: StackOverflowError:
Stacktrace:
     [1] simplifies(d::RealNumbers)
       @ DomainSets ~/Projects/DomainSets.jl/src/generic/canonical.jl:54
     [2] isequal1(d1::RealNumbers, d2::RealNumbers)
       @ DomainSets ~/Projects/DomainSets.jl/src/generic/canonical.jl:120
     [3] ==(d1::RealNumbers, d2::RealNumbers)
       @ DomainSets ~/Projects/DomainSets.jl/src/generic/canonical.jl:118
     [4] isdifferentfrom(d1::RealNumbers, d2::RealNumbers)
       @ DomainSets ~/Projects/DomainSets.jl/src/generic/canonical.jl:19
     [5] hascanonicaldomain(ctype::DomainSets.Equal, d::RealNumbers)
       @ DomainSets ~/Projects/DomainSets.jl/src/generic/canonical.jl:40
--- the last 5 lines are repeated 15995 more times ---
 [79981] simplifies(d::RealNumbers)
       @ DomainSets ~/Projects/DomainSets.jl/src/generic/canonical.jl:54
 [79982] isequal1(d1::RealNumbers, d2::RealNumbers)
       @ DomainSets ~/Projects/DomainSets.jl/src/generic/canonical.jl:120
 [79983] ==(d1::RealNumbers, d2::RealNumbers)
       @ DomainSets ~/Projects/DomainSets.jl/src/generic/canonical.jl:118

Probably a better fix is needed, e.g., by implementing canonicaldomain, but I don't quite understand what should be done.

The underlying problem lies here. I wrote a generic fallback for equality of domains, in terms of "simplifications" of domains, but that wasn't the best idea because it seems to replace the standard (implicitly defined) equality of all concrete domains. I only realized that later. That's why you had to implement equality of these number sets explicitly, the fix is correct. The better fix would be to remove that generic equality. I have to think about it, canonical domains should be opt-in only and not interfere with anything otherwise.

See #97


TLI 01.c -- Accessibility[Fix Header]

Fixed the header formats of texts on the dashboard

Looks good to me


Fix tests in Chrome 41

Use getter to override HTMLTemplateElement.content

It doesn't like to override the content if it's a data descriptor. A getter works fine, strangely.

Use appendChild to avoid an infinite loop in ShadyDOM

Fixes #851.

Thanks @jridgewell 👍

The ShadyDOM infinite loop is actually a @webcomponents/custom-elements infinite loop: https://github.com/webcomponents/custom-elements/blob/67f5a9620aeb06c0b0d09816e4dcea3124b08810/src/Patch/Element.js#L114-L115.
I'm doing this.innerHTML = '<div>' in MutateInConstructor's constructor, and that code does document.createElement('mutates-in-constructor')!


OV5642 mini 8mb FIFO operating voltage

Hi,
Can OV5642 mini operate at 3.3 volts or is it only 5 volt operation.
Thanks

@wdouglas1999
Hi,
The OV5642 support both 5V and 3.3 V .
Let us know if you need more help.
Regards,


function findViewNames() in yii\db\pgsql\Schema skip materialized views

What steps will reproduce the problem?
I have some materialized views and try to use InitDbFixture in my test and got exception
 [yii\db\Exception] SQLSTATE[42809]: Wrong object type: 7 ОШИБКА:  "my_materialized_view" - это не таблица и не сторонняя таблица
that happens on stage
    public function beforeLoad()
    {
        $this->checkIntegrity(false);
    }

My code research  shows that problem in
namespace yii\db\pgsql\Schema;
....
    protected function findViewNames($schema = '')
    {
        if ($schema === '') {
            $schema = $this->defaultSchema;
        }
        $sql = <<<SQL
SELECT c.relname AS table_name
FROM pg_class c
INNER JOIN pg_namespace ns ON ns.oid = c.relnamespace
WHERE ns.nspname = :schemaName AND c.relkind = 'v'
ORDER BY c.relname
SQL;
        return $this->db->createCommand($sql, [':schemaName' => $schema])->queryColumn();
    }

It skip only views,  but for materialized views sql must be
$sql = <<<SQL
SELECT c.relname AS table_name
FROM pg_class c
INNER JOIN pg_namespace ns ON ns.oid = c.relnamespace
WHERE ns.nspname = :schemaName AND (c.relkind = 'v' OR c.relkind = 'm' )
ORDER BY c.relname
SQL;

Additional info

Q
A

Yii version
~2.0.11

PHP version
7.1.3

Postgres
9.6.1

@Insolita how about a pull request?


Compute shader (cleaned)

Cleaned cherry pick of #192

Damn, I forgot about this PR with all this stuff in the world...
@JSandusky Is there any reason why URHO3D_COMPUTE is off by default?
Would be nice to have the code covered by CI

Not interested in reviewing further, take it or leave it (posted code MIT as described in headers).

Yeah we are a bit holding on to it. Eugene is doing a major engine rewrite.
Seems to us it would be best to finalize this PR when new renderer is
complete. Sorry for letting it hang for so long..
On September 24, 2020 06:47:20 Jonathan Sandusky<EMAIL_ADDRESS>wrote:

Not interested in reviewing further, take it or leave it (posted code MIT
as described in headers).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

This PR is totally fine. I just want to do some other stuff before I merge
it.
I’ll hopefully return to it when I make new renderer for rbfx, at least in
some basic shape. You can see I have some work ongoing on top of this PR
branch.
Sorry for delay and thank you for this PR (and for GS/TS as well)
чт, 24 сент. 2020 г. в 07:15, Rokas Kupstys<EMAIL_ADDRESS>
Yeah we are a bit holding on to it. Eugene is doing a major engine
rewrite.
Seems to us it would be best to finalize this PR when new renderer is
complete. Sorry for letting it hang for so long..
On September 24, 2020 06:47:20 Jonathan Sandusky<EMAIL_ADDRESS>wrote:

Not interested in reviewing further, take it or leave it (posted code
MIT

as described in headers).

—

You are receiving this because you are subscribed to this thread.

Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rokups/rbfx/pull/203#issuecomment-698100893, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACBNZQBDT5FKMEWNGDG3TKLSHLBUNANCNFSM4LJWWLKA
.

No problem, there's nothing magical going on in there. Just the shortest route I saw for how things were at the time. Do what you have to.


Update .gitignore to exclude macOS system files

Extended the gitignore file to exclude macOS system files.
Is that ok like so for all of you?

Nice

good catch and great initiative!


Add support for adding/removing hostnames to Pull Zones

This Pull-Request adds support for adding/removing hostnames to Pull Zones.
It implements the endpoints:

https://docs.bunny.net/reference/pullzonepublic_addhostname
https://docs.bunny.net/reference/pullzonepublic_removehostname

It also introduces a framework  for integrationtests and adds a first testcase.
See commit messages for details

merged manually


Fix issue 2090: Correctly parse LOCK clause in ALTER TABLE statements

Summary
This PR addresses issue #2090 by adding support for parsing the LOCK clause in ALTER TABLE statements in JSQLParser. Previously, the LOCK=NONE clause was incorrectly parsed as UNSPECIFIC, causing ambiguity in the interpretation of certain ALTER TABLE statements.
Changes
Updated AlterOperation enum to include LOCK.
Modified the parser to correctly identify and handle the LOCK clause.

Greetings! Looks very clean, fantastic job! Thank you for your contribution, I will merge promptly when QA/CI tests have passed! Kudos.

Please, run './gradlew :spotlessApply' to fix these violations.

@manticore-projects
Hi, I’m working on a personal project involving MySQL DDL, and I’ve encountered several DDL statements that are not being parsed correctly. I’m actively working on fixing as many of these issues as I can. I was wondering if you have any plans for the release date of version 5.1? I’d like to contribute as much as possible before the 5.1 release.
Thank you!

Greetings to Seoul and welcome!
I personally have only little interest in DDL outside of Oracle. So you contribution is most welcome and appreciated! Keep sending please!
All the best and cheers!
(I miss Korea so much!)

Release Date for 5.1 is likely around December/January. No fixed plans, we do it when we have time.


Fix small issues with CHANGELOG-7.xmd

Changes:

Capitalize 2 words at beginning of sentence
Replace dont -> don't 3 times

Context:
Went through this change log as well, and found similar issues as the ones I fixed with pulls #34538 and #34525.

Please send to 7.x.


[HTC] mismatch in semantic loss weght between implementation and paper

The default semantic loss weight in the paper is 1 but in implementation is 0.2

Seems that that's the case. I will check some early implementations to see the difference.


Allow to set min/max value via data-field

Allow more control via Symfony form element without invoke javascript code.

Hey there!
Thanks for your PR.
I didn't find in Symfony source code that they set those attributes, did you write them yourself in the data attributes?
Wouldn't it make sense to allow to set all options through the data attribute, and not only allow-min and allow-max?
Have a great day!
Alain

Yes, you are right. Its good idea to allow all (no all make sense). I have only add what i need.
About Symfony, its easy to add data attributes in Form
class CustomCollectionType extends CollectionType {     public function configureOptions(OptionsResolver $resolver)     {         $resolver->setDefaults([             'attr'          => [                'allow-min' => 3             ],     } }
its allow to change the value dynamic with $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {}) without changing Javascript.
With this we can use singe javascript for "most" collections.

Allright! Merging your PR and creating a new issue to generalize the idea.


The ballots from the 2007 Orsay experiment.

These are the raw data from the 2007 Orsay experiment, that took place during the French presidential elections, and which is discussed at length in the book.
I got them from Rida Laraki. The original files he sent me are .xls files, which contain not only these raw data but also a lot of statistical analysis. I extracted the raw data from those files, as a CSV. I hope I extracted the right lines and columns.
Someone should try and recompute the merit profiles from those data and compare them to what is given in the book.

Note that they do not conform to the format described in the current README.md as there is a first column giving individual numbers to the ballots.
Those numbers were in the .xls files I got from Rida Laraki and I just kept them.
May that be useful? Should we remove that first column or modify the README.md to allow such a first column of identifiers? I am in favor of the latter.

Oh, don’t merge that yet! It lacks a file explaining what number correspond to what mention.

Brilliant !
We can definitely accommodate an extra column for identifiers, so long as they are anonymous.


Remove stripe and add support for razorpay and lemonsqueezy

Ideally a new table should be added to handle payment info

In ticket table a transaction column needs to be added to store transaction id

for refund process

I have a sample schema. WIll drop here

model Orders {
  id String  @id @unique
  userId String?
  user   User?   @relation(fields: [userId], references: [uid])

  amount Decimal
  currency String

  notes Json?

  status  String @default("pending")

  captureTime DateTime?

  tickets Ticket[]

  createdAt DateTime  @default(now())
  updatedAt DateTime  @updatedAt
}

You can use this for razor pay

Razorpay would do the job. Why lemon squeezy?


Set 0.2.0 Blooming Barboiry version

Please read CONTRIBUTING.md before any contribution
Description
The version displayed in front hamburger menu is not ok, and about page is not up to date.
Fixes # (issue)
#155
Type of change

[x ] Typos

Tests are not working since the base commit of this branch broke the CI.
Rebasing it should be good, since tests were fixed after this commit

This PR wasn't merged ?


proto: support sequential calls using invokeAfterMsg(s)

https://core.telegram.org/api/optimisation#sending-messages-in-bulk

keep


General face-template available

MediaPipe Solution (you are using)
v0.10.0
Programming language
Python
Are you willing to contribute it
Yes
Describe the feature and the current behaviour/state
Dear community,
we are currently working with a research application of Face Landmarks in Mediapipe and would like to make a between-subject comparison. For this reason, we would like to generate a general template of the dataset and I would like to ask you whether you have a solution for that?
Thank you very much!
Best,
Christian

Will this change the current API? How?
No response
Who will benefit with this feature?
Generalizability of the program
Please specify the use cases for this feature
Research and comparability of face landmarks

Any Other info
No response

Hello @ChristianNSchmitz
The dataset used for training of Face Mesh and face detection solution is not made available for public usage. However, you can refer to the general aspects of the dataset, like geographical distribution, gender, skintone, etc here in the face mesh model card. Also, you can check out the research papers for BlazeFace and BlazePose solution.


⚠ Bofrost.at has degraded performance

In 3a0ac4f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1744 ms

Resolved: Bofrost.at performance has improved in 09f68a3 after 10 minutes.


Allow android platform for testfairy action

Testfairy API for both iOS and Android is exactly the same so the same code can be used for Android uploading too. This PR added android to the supported platform. This is tested on my testfairy account and I am able to upload an Android APK successfully.

A good news! I'll try it


Improved handling of the bokeh root model

On bokeh plots the root model is required to set up comm callbacks. Currently this is handled in some pretty terrible ways, e.g. after subplots set up a comm callback any layout plot or similar that is wrapping the plot has to then search and replace a placeholder root model id with the actual root model id. By allowing users to pass in a root model into a plot we can at least avoid having to replicate this logic on upstream libraries like panel.
Similarly this PR also allows passing in a Comm instance, so that upstream libraries do not have to patch all plots manually.

Ready to review and merge.


chore: drop support for PHP 8.0

Signed-off-by: azjezz<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2802

Relevant Lines:
2802

💛  - Coveralls


Language guessing

The Data Editor can guess the content language.

Merged in https://github.com/apache/daffodil-vscode/pull/865


De-duped and fixed types

Removed types package/src/types.ts that already exist in package/src
Added a 3rd Worker type "AugmentedWorker" and made it more clear that the public worker type and the actual worker interface are different (still not that clear, but at least it's a little better?)
Fixed mistakes in types

Added a 3rd Worker type "AugmentedWorker" and made it more clear that the public worker type and the actual worker interface are different (still not that clear, but at least it's a little better?)

I think it helps at least draw some sort of line that they are different even if it's just creating a new AugmentedWorker type. I think it's a good idea to use your new change.


Modify cloud block volume is successful but size is not updated

Issue/Feature Description:
When an AWS cloud block volume is updated from the dashboard the update API is successful and the API returns the updated value in the response.
After a while in the subsequent GET requests the value of the Volume is reverted back to the original value.
Why this issue to fixed / feature is needed(give scenarios or use cases):
Size is modified but the incorrect, old value is returned.
How to reproduce, in case of a bug:
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)
PUT Request Payload

PUT Request response

Docker logs for PUT

Subsequent GET response value in dashboard

@anvithks Are you sending GET Volume after the PUT operation successful or in between PUT operation going on?

There is one get operation immediately after to populate the table.
In that the status is updating.
After a while when the table is refreshed the status is available. This is where the size is inconsistent.

@himanshuvar I encountered this issue again when I was making a demo. I have a video recording that shows the updated the size and then after a few GET calls the size is reverted back to the original size.
Display in SODA Dashboard

API response

From AWS Console

AWS Console API response

The volume is still available in the console if you want to debug.

@anvithks I am not able to reproduce this Issue. I have tested the following API calls/operations on Greenland release. All operations worked fine successfully as expected. Are you sure you have encountered this Issue from Dashboard using Greenland multi-cloud release.
Please check the following Snapshots for the API calls.
Create a 1GB gp2 Volume

docker logs

Volume Created Successfully with the expected size in Backend

Get Volume API result

Update the created Volume to Resize it to 300GB

docker logs

Volume Size is updated at Backend

Get Volume API result

@kumarashit @skdwriting Please review this Issue and let me know if APIs are deviated from expected results.

@himanshuvar You can check the video recording for the above API responses.
Please check from 00:46 onwards.


DNS discovery fails to sync if AlertManager has connection timeout

What did you do?
Started Prometheus with two AlertManagers alive and receiving alerts. I have a DNS service that lists both AlertManager IPs for the url I'm using to connect to the AlertManager.
I then stopped one of the two AlertManagers, so only one left working. I confirmed that my DNS service now only lists only one IP, the one that was left active. So if Prometheus queries the DNS during DNS service, it will now only see one IP.
I set the AlertManager timeout to 10s, Evaluation period is 30s
What did you expect to see?
I expected to see some error messages related to failing to connect to the now-dead AlertManager.
After 30s (I use the default DNS discovery frequency) the DNS discovery should update the list of AlertManagers to now only contain a single IP, and the errors should stop, the obsolete IP should not be used any more.
What did you see instead? Under which circumstances?

The Notifier was waiting within the Run function (https://github.com/prometheus/prometheus/blob/fa184a5fc3bd83abe37854983e0f548ceaabb4e0/notifier/notifier.go#L305) for either Alerts to arrive that needed to be sent to AlertManager, or a sync message from the DNS discovery.
When sending alerts started to run into timeout errors (old IP is no longer reachable), the sending of alerts took a lot longer, so by the time the select started to wait again, there were already new alerts waiting to be sent again.
So it took those new alerts, tried to send them, ran into timeout again, etc. It never received the sync messages from the sync channel from the DNS discovery. And fell into an endless loop of failing to reach the long-dead AlertCenter.
Hours later it finally recovered, when suddenly there were no new alerts coming every few seconds, so it had time to wait on the sync channel and finally noticed the DNS discovery, updated the IPs and everything went fine after that.

Note that the channel used for the DNS discovery sync is not buffered, so the Notifier will only see those sync messages on the channel if it is waiting inside the select at the moment. When it is busy trying to send the alerts, it will ignore the sync channel.
I tried a small fix where I made the sync channel into a buffered channel with a queue size of 1, it solved this issue, the recovery was instant when one of the AlertManager went offline.
Environment

System information:
Darwin 20.3.0 x86_64

Prometheus version:

prometheus, version 2.26.0 (branch: main, revision: f3b2d2a99889257022de5923a070e770b8d41b02)
build user:       pballok@pballok-MBP
build date:       20210428-22:20:08
go version:       go1.16.2
platform:         linux/amd64

Alertmanager version:
/bin/sh: alertmanager: not found

Prometheus configuration file:

# my global config
global:
  scrape_interval:     30s
  evaluation_interval: 30s
  # scrape_timeout is set to the global default (10s).

  external_labels:
    store_name: prometheus
    store_id: aaaaa
    cluster: local

scrape_configs:
  # metrics_path defaults to '/metrics'
  # scheme defaults to 'http'.

  - job_name: 'prometheus-exporter'
    # Use DNS service discovery to get all local instances of the exporter
    dns_sd_configs:
      - names: [***]

  - job_name: 'device-prometheus-exporter'
    static_configs:
      - targets: [***]

alerting:
  alert_relabel_configs:
    - regex: 'store_id'
      action: labeldrop
  alertmanagers:
    - dns_sd_configs:
      - names: [***]

rule_files:
  - /etc/prometheus/alert.rules.yml

Alertmanager configuration file:

insert configuration here (if relevant to the issue)

Logs:

insert Prometheus and Alertmanager logs relevant to the issue here

thank you, it seems you have a patch, would you mind opening a pull request for further discussion? Thank you!

The patch I created for this issue fails one of the CI tests (ci/circleci: test_windows), but I'm unable to check the CircleCI results, since it wants access to all my repos, and this is a company account.
I'm also unable to run the tests locally, I'd need to put more time into creating a proper environment for this. Also, I only have access to macOS environment, and the test name "test_windows" suggests I'd need a Windows environment for these specific tests.
Long story short: I need help confirming that the failing test is indeed related to my patch, and if yes, what exactly is the log of the failing test...

Hi @pballok-logmein, if you press the arrow next to the "Log In with GitHub" button, there is a "Public Repos Only" option. Maybe logging in is acceptable to you if you don't have to grant access to private repos :)

Note that the channel used for the DNS discovery sync is not buffered, so the Notifier will only see those sync messages on the channel if it is waiting inside the select at the moment. When it is busy trying to send the alerts, it will ignore the sync channel.

I do not think that the fix is correct.
The fact that it is a sync channel means that it will block the go routine that sets the targets, but it will see the new targets eventually.
The fact that it is buffered or not should have very little impact here, it might even make the situation worse as the service discoveries would queue multiple updates at the same time.

Hi @roidelapluie ,
The way I see it in the code is that the Discover Manager sends the targets here: https://github.com/prometheus/prometheus/blob/2a4b8e12bbf233a782c2d94ba3df480bf2aecbb2/discovery/manager.go#L242
It will not get blocked if the channel is not being waited on, because currently this is not a buffered channel. It will just jump to the default and try again in 5 seconds.
The receiver side is here:
https://github.com/prometheus/prometheus/blob/2a4b8e12bbf233a782c2d94ba3df480bf2aecbb2/notifier/notifier.go#L311
This will be indeed blocked if there are no new targets from the discovery manager, AND there are no alerts to send either. If there are always alerts to send, because of all the sending taking too long time, it will never read the new discovery targets.
I agree that under normal conditions when there are pauses between sending alerts, the discovery targets will be eventually read.

Note that the channel used for the DNS discovery sync is not buffered, so the Notifier will only see those sync messages on the channel if it is waiting inside the select at the moment. When it is busy trying to send the alerts, it will ignore the sync channel.

I do not think that the fix is correct.
The fact that it is a sync channel means that it will block the go routine that sets the targets, but it will see the new targets eventually.
The fact that it is buffered or not should have very little impact here, it might even make the situation worse as the service discoveries would queue multiple updates at the same time.

I think with a buffer size of 1, there won't be multiple updates waiting at the same time

I missed a piece of the puzzle. Thanks for pointing me it out.
I think that this is still not the correct fix. The issue I see is that a service discovery can have a lot of target groups, therefore buffering could still have a huge delay if multiple groups are updated.
Maybe we could have a select in a loop and the send of the alerts in another go routine.

Hi @roidelapluie,
I'm a bit confused about what the next step is. Do you still prefer a different solution that involves a separate loop / go-routine to listen to DNS discovery targets? Or is the current proposed solution ok?
The current proposed solution makes sure that the two channels (1. the one used to signal that there are alerts to be sent, 2. the one used to send DNS discovery targets) have equal chance to be read, since both will be buffered (with queue size of 1).  I agree this could also be achieved if separate loops were reading the two channels, but that change might have other implications (I'm not sure which, I didn't look into it), since this is a generic part used by other discovery notifiers too. Let me know what you guys think.

I need to dig into the code. I think that it might break other stuff in subtle ways, that I need to check. Did you look at the impact this would have on service discovery?

The only impact my proposal has for sure, that the current implementation only cares about DNS discovery results, if it's idle (ie has no alerts to send). With my proposed solution, the DNS discovery results (generated every 30s by default) will be taken into account, and updated even if there are alerts to be sent as well, and this might (slightly) disrupt the current timing. But I think this same impact would be there as well if I went with a separate loop.

I will look into possible impacts related to other service Discovery

Actually the service discovery is using a different mechanism, more elaborated, where we create a buffered chan.

Agreed, does this mean that having a similar buffered chan for DNS discovery targets could be ok? (this is what the proposed PR does)

The approach seems OK. However, the proposed PR causes a double buffer in the scrape discovery, which I'd like to avoid.

@pballok-logmein are you willing to to implement the same logic we have in the scrape manager in the notifier? Thanks.

@dschmo We use a SRV record with stable external DNS hostnames like alertmanager-0, alertmanager-1. These point to an internal cloud provider LB with static IPs. This way the path from Prometheus to Alertmanager is mostly static from Prometheus's point of view.
We did this mostly to handle cross-cluster alertmanager traffic.

@pballok-logmein I have another proposal in https://github.com/prometheus/prometheus/pull/10948 , can you please tell me what you think?

I'd like to explicitly thank you for your debugging efforts and your clear explanation of the issue.

We are still this issue with a similar setup as the configuration from #7063, while running v2.38.0, which should contain the fix from https://github.com/prometheus/prometheus/pull/10948

Prometheus & Alertmanager running both on Kubernetes
Prometheus being configured to find Alertmanager using kubernetes_sd_configs + role: endpoints

We're still seeing this issue as well. It's reproducible with > 1500 firing alerts and two alertmanager replicas. Just restart the alertmanager pods.

can you fill another issue with all your details?

can you fill another issue with all your details?

I filled in a new issue in https://github.com/prometheus/prometheus/issues/11444 :+1:


The datepicker's date-disabled validation error does not conform to angular validation error standards, and requires awkward syntax to react to on the front-end.

Reproduction Plunker can be found here
Steps to Reproduce:
Open the reproduction plunker given above.
Observe that the testText control has a min-date of 1/2/2000 and max-date attribute of 12/31/2099.
Enter a value outside of the min/max date range (e.g. 1/1/1900 or 1/1/2100)
Observe that both the form-level and control-level validation messages use the syntax, testform.$error['date-disabled'] and testForm.testText.$error['date-disabled']
In the "Form Error Dictionary Blob" section, observe that the JSON blob has date-disabled as the key.
Observed Behavior:
It's necessary to use testform.$error['date-disabled'] or testForm.testText.$error['date-disabled'] to access the error object for a date being outside of the min/max-date range.
Expected Behavior:
I should be able to use the fluent syntax, testForm.$error.dateDisabled or testForm.testText.$error.dateDisabled when interacting with the dateDisabled validation error on the front end.

What is the reason for setting disabled control to invalid? I would like to see it fixed.

Also observed this error. It messes with my form validation.

This seems like a bug.  The control adds date-disabled property under the forms $error object, but the actual control itself shows valid: true!

@Asvarduil  @wesleycho @BobbieBarker  This issue should be fixed with PR #3606.  There hasn't been any activity on it in over a month though so I'm not sure when they plan on pulling it in.
PRs #3440 and #3438 are related to this.

It appears this is already fixed - the validation key is now dateDisabled in master (may have been there for the past couple of releases.

@wesleycho It appears that the validation key is in there correctly now, however it still doesn't have the expected behavior.  In the plunker above, if you change it to use the latest angular.js (1.4.7) and latest ui-bootstrap (14.3) you still can't get the validation message to pop up if you manually type in a date outside of the range.  The only time I can see the dateDisabled error show up in the $errors array is if you have an invalid date typed in, then open up the datepicker popup.

@willisd2 I've found that if you've opened the datepicker once, it'll show up, so open it, close it, and the validator seems attached. I find it weird that the validation error is not on the field itself, only on the form $error array...

@willisd2 Yeah I'm having that problem now. The form is loading up with an illegal value but isn't mark as valid until I pop open the datepicker popup. Is there a way to auto digest the validation?

Why is this closed? The issue doesn't seem to be resolved.


Update NWWebSocket.swift

Fix multiple NWConnection during migrateConnection

Problem:
Every time migrateConnection() is called, new NWConnection will be created. The problem appear if migrateConnection() is called multiple time, the previous NWConnection from migratedConnection variable is never closed and multiple NWConnection will be alive.
Solution
change migratedConnection to global variable and make sure its cancel() and nil first before creating new one.


Update entity with detached data has odd behavior after savechanges

I retrive json data from web api and then convert it into an entity. Then update it with context.Update method. When the entity is not query with the same id before update, or just update the entity from query, everything goes fine. Yet if I query it ahead, and call context.Update, it will throw an exception, in the catch scope, I  update the properties through EntityEntry's SetValues method, the data will be updated successfully, but the add operation immediately after updating will not be performed(without exception but no data in database). Any other operations after updating are going alright. But if I make some operation after adding data(such as add a new data again), both operation succeed.
My test code:
            using (var context = new StudyContext())
            {
                //query data from database
                var data = context.Department.FirstOrDefault(e => e.Id == Guid.Parse("72c36b62-a085-d5db-bab6-a0314987abcf"));

                //simulate data from web api
                var simData = new Department
                {
                    Id = Guid.Parse("72c36b62-a085-d5db-bab6-a0314987abcf"),
                    Name = "T6",
                    ParentId = Guid.Parse("68b39117-37b4-4d6b-9281-7a904dbfc0c3"),
                    LastUpdate = DateTime.Now,
                    CreationDate = DateTime.Now
                };

                var entry = context.Entry(simData);

                try
                {
                    //if data was tracked, here will throw exception
                    context.Update(simData);
                }
                catch (InvalidOperationException)
                {
                    //update properties
                    entry =
                        context.ChangeTracker.Entries<Department>().FirstOrDefault(e => e.Entity.Id == simData.Id);
                    entry?.CurrentValues.SetValues(simData);
                }

                //update successfully
                context.SaveChanges();

                var emp = new Employee
                {
                    Id = Guid.NewGuid(),
                    Name = "Test Insert",
                    DepId = Guid.Parse("702b93b4-b7ac-6cc6-5139-12643ffda37d")
                };

                var b = context.Add(emp);
                //no data will be inserted into database, and only add operation will not be executed
                context.SaveChanges();

                //if there has other operation after adding, both operation will be executed
                //var d2 = context.Employee.FirstOrDefault();
                //d2.Name = "Change";
                //context.Update(d2, true);
            }

I'm wondering wether this is a bug or wrong operation?
Further technical details
EF Core version: 1.1.0
Database Provider: Npgsql.EntityFrameworkCore.PostgreSql
Operating system:  Windows 10
IDE: Visual Studio 2017

@sweetwxh Have you try a context.ChangeTracker.DetectChanges() before to see if something changed ?
Did you disable AutoDetectChangesEnabled within your context because of your merge system ? (it happens to me, I've found it a lot of time after ...)

@sweetwxh Rather than creating a new instance, if the entity already exists, then assign values to the properties of that instance. EF will then detect changes appropriately and make an update call. If the entity doesn't exist, then EF will insert it. Something like this:
//query data from database
var data = context.Department.FirstOrDefault(e => e.Id == Guid.Parse("72c36b62-a085-d5db-bab6-a0314987abcf"));

if (data == null)
{
    data = new Department { Id = Guid.Parse("72c36b62-a085-d5db-bab6-a0314987abcf") };
    context.Add(data);
}

data.Name = "T6";
data.ParentId = Guid.Parse("68b39117-37b4-4d6b-9281-7a904dbfc0c3");
data.LastUpdate = DateTime.Now;
data.CreationDate = DateTime.Now;

//update successfully
context.SaveChanges();


Specific reloading

This enables guard-spork to reload only specific spork instances.
watch('spec/spec_helper.rb') { :rspec }

I did a huge amount of refactoring since I felt it was hard to extend functionality in a nice way. Hope you guys don't mind that.
If I didn't follow some coding style I should've, just tell me and I'll fix it. Some of the styles were a bit inconsistent between files, so I did not know which one to pick.

There. I added two comments (one where we're storing it and one where we're doing the killing) to make the reasoning clear.

Oops, specs seems to failed on Rubinus (http://travis-ci.org/#!/guard/guard-spork/builds/374591) Hash/Array ordering problem?

hum, I just got this error after saving my environment.rb file:
ERROR: Guard::Spork failed to achieve its <run_on_change>, exception was:
NoMethodError: undefined method `kill' for RSpec:Guard::Spork::SporkInstance
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/bundler/gems/guard-spork-4f3e05161c56/lib/guard/spork/runner.rb:32:in `each'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/bundler/gems/guard-spork-4f3e05161c56/lib/guard/spork/runner.rb:32:in `kill_sporks'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/bundler/gems/guard-spork-4f3e05161c56/lib/guard/spork.rb:36:in `run_on_change'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:322:in `block in run_supervised_task'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:320:in `catch'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:320:in `run_supervised_task'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:276:in `run_on_change_task'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:215:in `block (2 levels) in run_on_change'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:254:in `block (3 levels) in run_on_guards'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:253:in `each'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:253:in `block (2 levels) in run_on_guards'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:252:in `catch'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:252:in `block in run_on_guards'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:251:in `each'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:251:in `run_on_guards'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:214:in `block in run_on_change'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:231:in `block in run'
<internal:prelude>:10:in `synchronize'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:228:in `run'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard.rb:213:in `run_on_change'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard/listener.rb:78:in `block (2 levels) in start_reactor'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard/listener.rb:74:in `loop'
/Users/Thibaud/.rvm/gems/ruby-1.9.3-p0/gems/guard-0.8.8/lib/guard/listener.rb:74:in `block in start_reactor'

Damn. I'll fix both these issues and open a new pull request.
Sorry for the trouble!

Ok thanks, no problem it happens!

I have just modify the kill_orphan_sporks method. What do you think? https://github.com/guard/guard-spork/commit/659e67b38ebf758bb5782f6ecdd9ced6fbcdd38e

Looks good!


fix: 9870 merge button visible condition

Description

updated conflicting condition of merge tab

Fixes #9870
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

refer attached issue

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/9870-merge-change-button-issue

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.12 (0)
36.65 (0.01)
34.54 (0)
55.65 (0)

:red_circle:
app/client/src/pages/Editor/gitSync/components/BranchList.tsx
23.31 (-0.29)
10.13 (-0.54)
2.5 (0)
25.34 (-0.18)

:green_circle:
app/client/src/selectors/commentsSelectors.ts
85.25 (1.64)
64.71 (2.95)
73.33 (0)
90.59 (2.35)

:red_circle:
app/client/src/selectors/gitSyncSelectors.tsx
71.65 (-0.12)
26.19 (0)
16.67 (-0.4)
64.1 (0.46)

:red_circle:
app/client/src/utils/WorkerUtil.ts
88.98 (-0.78)
70.59 (-1.96)
100 (0)
92.38 (-0.95)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.94 (0.23)
41.67 (0.84)
36.21 (0)
56.99 (0.25)

/ok-to-test sha=760c3da


HADOOP-16961. ABFS: Adding metrics to AbfsInputStream

Change-Id: I034b771533b8314364a3762034439e323758ee09

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
24m 46s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
20m 36s
trunk passed

+1 :green_heart:
compile
0m 29s
trunk passed

+1 :green_heart:
checkstyle
0m 22s
trunk passed

+1 :green_heart:
mvnsite
0m 31s
trunk passed

+1 :green_heart:
shadedclient
15m 30s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 24s
trunk passed

+0 :ok:
spotbugs
0m 52s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 49s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s
the patch passed

+1 :green_heart:
compile
0m 23s
the patch passed

+1 :green_heart:
javac
0m 23s
the patch passed

-0 :warning:
checkstyle
0m 17s
hadoop-tools/hadoop-azure: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

+1 :green_heart:
mvnsite
0m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 17s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s
the patch passed

-1 :x:
findbugs
1m  9s
hadoop-tools/hadoop-azure generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)

_ Other Tests _

+1 :green_heart:
unit
1m 25s
hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

87m 30s

Reason
Tests

FindBugs
module:hadoop-tools/hadoop-azure

Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperationStarted(long, long)  At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.readOperationStarted(long, long)  At AbfsInputStreamStatisticsImpl.java:[line 113]

Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperation()  At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.remoteReadOperation()  At AbfsInputStreamStatisticsImpl.java:[line 118]

Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.backwardSeekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long)  At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long)  At AbfsInputStreamStatisticsImpl.java:[line 47]

Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long)  At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekBackwards(long)  At AbfsInputStreamStatisticsImpl.java:[line 46]

Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.forwardSeekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long)  At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long)  At AbfsInputStreamStatisticsImpl.java:[line 60]

Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekOperations in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long)  At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekForwards(long)  At AbfsInputStreamStatisticsImpl.java:[line 59]

Increment of volatile field org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer()  At AbfsInputStreamStatisticsImpl.java:in org.apache.hadoop.fs.azurebfs.services.AbfsInputStreamStatisticsImpl.seekInBuffer()  At AbfsInputStreamStatisticsImpl.java:[line 103]

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1946

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7dd8211e3a28 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 1189af4

Default Java
1.8.0_242

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-azure.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/artifact/out/new-findbugs-hadoop-tools_hadoop-azure.html

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/testReport/

Max. process+thread count
412 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1946/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@bgaborg, Can you wait for #1956 to go in? It's trying to get the args to the input stream under control. I hope to merge it on Tuesday Apr 20.

gabor, see if I've broken this building; if so rebase and resubmit. thanks


Target .NET Standard 2.0

All the dependencies (Docnet.Core, SixLabors.ImageSharp and Verify) support .NET Standard 2.0 and Verify.DocNet code itself is also .NET Standard 2.0 compliant.
This makes Verify.DocNet available to .NET Framework 4.7.2 and .NET Core 2.0+ for free and reduces the size of the NuGet package since only one dll is required instead of two.

good point. will deploy now


Deprecated Cause

Issue fixed

Thanks for submitting an issue. @mateusloubach With regards to your initial issue, I will update this project.

Thanks for the response @wardvisual . However, I've closed the issue after having read supabase docs and videos off youtube. Nonetheless, I've always found it interesting to have a guide on readme, just for the interest of sharing the project.
Once again, thanks for the response. I would also be interested to know if the project was discontinued or earned a newer version.

This project was discontinued as it was only for showcasing purposes. However, I would be happy to update this project.


why catalog pg_stat_user_functions is can't statistics function in CV query?

I modify  track_functions = all
create stream stream_test(x bigint);
create continuous view cv_test as select my_udf(x) from stream_test;
insert into stream_test(x) values(111);
why  pg_stat_user_functions is can't statistics my_udf?
but,if i execute command select my_udf(1) ,pg_stat_user_functions is OK.

Hi @sangli00, so what was happening was that these statistics weren't being flushed for continuous views until the system was shut down. 5b645d499c54444354987826a46d2a14eedaf506 fixes this, so you should see statistics for UDFs in continuous views now. Thanks for reporting!


Label overrides.

Noticed that there is also a "genes" label in the heatmap, so this allows for an override of that.  Related to #481 and completing the work from #630.
Tested in the portal and it works:

Just tested in the portal and was able to replace cells -> observations and genes -> antigens`.  Thanks for bringing this up.


removed duplicate azure function token provider doc

Removing duplicate Token Provider tutorial documentation on fluidframework.com. Users should reference the following DCOM docs for Token Provider implementation guide.
https://learn.microsoft.com/en-ca/azure/azure-fluid-relay/how-tos/azure-function-token-provider

Just removing the file will create a 404 for the old page. Instead, this page should just be updated to EITHER:

Have a notice that says, "content has been moved to ". OR
Use Hugo's aliases feature to make a client-side redirect to the new URL.

Updated the document to direct users to learn.microsoft.com similar to https://fluidframework.com/docs/deployment/azure-frs/


update COCO format documentation

Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[ ] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[ ] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zmaslova , could you please update your PR? We have added a special site for our documentation: https://openvinotoolkit.github.io/cvat/docs/

@zmaslova , could you please update your PR? We have added a special site for our documentation: https://openvinotoolkit.github.io/cvat/docs/

Updated

@zmaslova , there is a problem in the patch. Could you please fix it?

@zmaslova , there is a problem in the patch. Could you please fix it?

Fixed. I also see issues in CHANGELOG.md, I suppose I shouldn't fix them


[BEAM-8164][website] Correct document for building the python SDK ha…

The command :sdks:python:container:docker has been changed to :sdks:python:container:buildAll by the latest
commit[1]. This pull requests fix all related places in our documents.
Note: For the section (Adding dependencies, and making Python go vroom vroom) in CONTAINERS.md, it has totally outdated, e.g.,
the add_requirements.sh script can not work now and the dependent docker file has been removed.
I think we can add python dependencies directly to the base_image_requirements.txt file and build the docker image if user need to add customized dependencies.

Hi @ibzib,
Thanks for the review. I agree with you. I removed the build-docker step in portability.md in which we are instructing users to use loopback mode.
Would be great if you can take another look.
Best, Jincheng

FYI there's been another change to the default docker container image names: #9487

Thanks for the remind @ibzib  I have update the PR and rebase the code.

Hi @ibzib Thanks a lot for the review and sorry for the conflicts. I have rebased to the latest master and updated the PR.

Run Python PreCommit

Run Python2_PVR_Flink PreCommit

Run Python2_PVR_Flink PreCommit

Thanks for updating this Jincheng. I'll fix the Flink command issue in a separate PR.

Thanks @ibzib !


aio: add aio.Poll

Add of the poll op described at https://unixism.net/loti/ref-iouring/io_uring_enter.html

Poll events should be bit map
But I don't see myself using a single Pool for several events
pub const Poll = struct {
    pub const Events = packed struct(u32) {
        in: bool = false,
        out: bool = false,
        pri: bool = false,
        _: u29 = 0,
    };

    pub const Error = std.posix.PollError || SharedError;
    fd: std.posix.fd_t,
    events: Events = .{ .in = true },
    out_id: ?*Id = null,
    out_error: ?*Error = null,
    link: Link = .unlinked,
    userdata: usize = 0,
};

aio.Single(aio.Poll{ .fd = fd, .events = .{ .out = true } });

In addition, I don't like the implementation of Readiness.mode which makes it difficult to simply check mode
pub const Readiness = struct {
    fd: std.posix.fd_t = invalid_fd,
    mode: packed struct(u32) {
        in: bool = false,
        out: bool = false,
        pri: bool = false,
        kludge: bool = false,
        _: u28 = 0,
    },
};

I am not sure how it should be 🤔

The readiness originally was not meant to implement poll. Your changes make sense. The kludge field probably can live outside of the packed struct as bool, as it is not a poll thing. Then I guess Events could be intCast'd to mode.
I'd also be grateful if you can add more tests.

Poll struct must not panic (comptime), or else building on Windows will be impossible

Thank you


Add support for ReSharper 9.2 (EAP)

It would be nice if the new EAP was supported,

It will be. The SDK isn't ready yet, though.

+1 for this, especially now VS2015 RTM is out and R# 9.2 is more likely to be widely used.

The SDK is out now, so expect it in the next couple of days.

Hmm. Actually, it might have to be EAP4. It looks like EAP3 hasn't yet updated the default extension feed to look at 9.2 compatible packages.

Any news on 9.2 EAP support?

The 9.2 SDK is now available, so should be over the next couple of days.

9.2 EAP 7 support just released. It's available via the Extension Manager. Make sure you enable pre-release extensions in ReSharper → Options → Extension Manager.


How do I use the route function in a compiled Vue component?

I'm using the following code:

 0">
                    {{ project.name }}

But I get the following error in console:

Note that both route and namedRoutes exist. I have @route above the app.js line in my layout.

I experience this issue right now.
You have to use computed properties to utilize the route() method in your components.
It seems Vue inits faster than the route helper or something? I'm not a very experienced JS dev so I'm not sure why it doesn't register when it's above my main app script.
I hope this is changed in the future so we can compile it with the rest of our components.

@stevebauman Great, thanks. I decided to use a function instead as that appears to work OK:

 0">
                    {{ project.name }}

...