KeyError: 'link' in capture

When I was running this code:
$ python3.8 test_save.py
{'Server': 'nginx/1.15.8', 'Date': 'Wed, 15 Jul 2020 11:59:50 GMT', 'Content-Type': 'text/html', 'Transfer-Encoding': 'chunked', 'Connection': 'keep-alive', 'Cache-Control': 'no-cache'}
capture: 42.963274240493774 sec.
{'Server': 'nginx/1.15.8', 'Date': 'Wed, 15 Jul 2020 12:01:37 GMT', 'Content-Type': 'text/html', 'Transfer-Encoding': 'chunked', 'Connection': 'keep-alive', 'Cache-Control': 'no-cache'}
capture_or_cache: 97.4388906955719 sec.
Traceback (most recent call last):
  File "test_save.py", line 28, in <module>
    main()
  File "test_save.py", line 24, in main
    measure(fun, url)
  File "test_save.py", line 8, in measure
    print(f(*arg))
  File "/home/eggplants/.pyenv/versions/3.8.0/lib/python3.8/site-packages/savepagenow/api.py", line 55, in capture
    header_links = parse_header_links(response.headers['Link'])
  File "/home/eggplants/.pyenv/versions/3.8.0/lib/python3.8/site-packages/requests/structures.py", line 54, in __getitem__
    return self._store[key.lower()][1]
KeyError: 'link'

I needed to figure out a quick fix for this same problem, and I ended up writing this. It's not the most exact or beautifully written piece of code in the world, but it works for my purposes. Maybe it'll work for yours.

# MIT License

import requests
from bs4 import BeautifulSoup
from urllib.parse import urljoin
import datetime
from time import sleep

def archive_url(
    url,
    timeout=100,
    user_agent='Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36'
    ):

    """Submits a URL to WebArchive's Save Page Now Feature (working as of 2020-07-31 on Python 3.6.10)

    Keyword arguments:
    url -- The url you want to archive
    timeout -- Max number of seconds you're willing to wait
    user_agent -- You can pass a custom user agent here

    """

    # POST Request
    headers = {
        'authority': 'web.archive.org',
        'cache-control': 'max-age=0',
        'upgrade-insecure-requests': '1',
        'origin': 'https://web.archive.org',
        'content-type': 'application/x-www-form-urlencoded',
        'user-agent': user_agent,
        'accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9',
        'sec-fetch-site': 'same-origin',
        'sec-fetch-mode': 'navigate',
        'sec-fetch-user': '?1',
        'sec-fetch-dest': 'document',
        'referer': 'https://web.archive.org/save',
        'accept-language': 'en-US,en;q=0.9,de;q=0.8',
    }

    data = {
        'url': url,
        'capture_all': 'on'
    }

    r = requests.post(f'https://web.archive.org/save/{url}', headers=headers, data=data)

    # BS4 get SCRIPTS and find watchJob arguments
    soup = BeautifulSoup(r.content, 'html.parser')
    scripts = soup.find_all("script")

    job_id = None
    for script in scripts:
        string = script.string
        if string and "watchJob" in string:
            args_string_list = string.strip().split('"')
            job_id = args_string_list[1]
            break

    assert job_id is not None, "Couldn't find job_id in html"

    # Request status of the job
    out_url = None
    was_pending = False
    wait_time = 0
    while wait_time < timeout:

        r = requests.get(f"https://web.archive.org/save/status/{job_id}?_t={datetime.datetime.now().timestamp()}", headers=headers)
        rj = r.json()

        if rj.get('status', 'none') == "pending":
            was_pending = True

        if rj.get('status', 'none') == "success":
            original_url = rj.get('original_url', 'none')
            ext_url = f"/web/{rj['timestamp']}/{rj['original_url']}"
            out_url = urljoin('https://web.archive.org', ext_url)
            break

        seconds_to_wait = int(r.headers.get("Retry-After", 5))
        print(f"[{wait_time} seconds elapsed] Waiting for archive to complete...")
        wait_time += seconds_to_wait
        sleep(seconds_to_wait)

    assert out_url is not None, f"Process did not complete after {timeout} seconds"

    out = {
        "original_url": original_url,
        "archive_url": out_url,
        "from_cache": was_pending == False
    }

    return out

if __name__ == "__main__":
    url = "https://ultimateframedata.com/"
    print(archive_url(url))

I'll try it soon...

Is there a way we can reliably recreate this error?

I can reproduce with savepagenow -c https://www.google.com -ua "spn test" with savepagenow==1.0.1 running on Python 3.8.2 and Ubuntu 20.04 LTS.

Not sure, but seems like the wayback machine API changed? At least happens to me every time for every url which I tried...
Anyway, a quick and dirty fix to accommodate the change (if it is indeed an API change) is to comment lines 55-62 and insert the line archive_url = domain + response.headers['Content-Location'] after line 53.
Code should then look like this (highlighted are the changes):

FWIW, this curl HEAD request seems to succeed:
$ curl --location --head --compressed --max-time 60 --user-agent 'just-curl' https://web.archive.org/save/https://www.whitehouse.gov/news/page/700/

And here is the (derived) URL and the headers returned:
https://web.archive.org/web/20200908001519/https://www.whitehouse.gov/news/page/700/
HTTP/2 200
server: nginx/1.15.8
date: Tue, 08 Sep 2020 00:15:20 GMT
content-type: text/html;charset=utf-8
content-location: /web/20200908001519/https://www.whitehouse.gov/news/page/700/
set-cookie: JSESSIONID=1A57B723E35BF79022A710B60D7BE7A9; Path=/; HttpOnly
x-archive-orig-strict-transport-security: max-age=31536000 ; includeSubDomains ; preload
x-archive-orig-vary: Accept-Encoding
x-archive-guessed-charset: UTF-8
x-archive-orig-x-frame-options: SAMEORIGIN
x-archive-orig-connection: close
x-archive-orig-content-type: text/html; charset=UTF-8
x-archive-orig-date: Tue, 08 Sep 2020 00:15:19 GMT
x-archive-orig-accept-ranges: bytes
x-archive-orig-server-timing: origin; dur=279
x-archive-orig-x-akamai-transformed: 9 - 0 pmb=mRUM,1
x-app-server: wwwb-app52
x-ts: 200
x-location: save-sync
x-cache-key: httpsweb.archive.org/save/https://www.whitehouse.gov/news/page/700/US
x-page-cache: MISS
content-encoding: gzip

I'm not familiar with what the web.archive.org/save endpoint returned previously, but it looks like the current iteration does not return Link among its headers
And no matter how recent its most current snapshot of a URL is, making a request to the web.archive.org/save endpoint will always result in a response in which content-location contains a snapshot URL corresponding to the timestamp of when the request was made.
For example, I repeated the above curl request and got the same set of headers, with content-location corresponding to the timestamp of when I made the request (a couple minutes after my initial request):
https://web.archive.org/web/20200908001640/https://www.whitehouse.gov/news/page/700/
HTTP/2 200
server: nginx/1.15.8
date: Tue, 08 Sep 2020 00:16:40 GMT
content-type: text/html;charset=utf-8
content-location: /web/20200908001640/https://www.whitehouse.gov/news/page/700/
set-cookie: JSESSIONID=BAC7D0EFD44943C953D4C3C; Path=/; HttpOnly
x-archive-orig-strict-transport-security: max-age=31536000 ; includeSubDomains ; preload
x-archive-orig-vary: Accept-Encoding
x-archive-guessed-charset: UTF-8
x-archive-orig-x-frame-options: SAMEORIGIN
x-archive-orig-connection: close
x-archive-orig-content-type: text/html; charset=UTF-8
x-archive-orig-date: Tue, 08 Sep 2020 00:16:40 GMT
x-archive-orig-accept-ranges: bytes
x-archive-orig-server-timing: edge; dur=2
x-archive-orig-x-akamai-transformed: 9 - 0 pmb=mRUM,1
x-app-server: wwwb-app52
x-ts: 200
x-location: save-sync
x-cache-key: httpsweb.archive.org/save/https://www.whitehouse.gov/news/page/700/US
x-page-cache: MISS
content-encoding: gzip

However, if I do a curl --head request for the URL returned by that most-recent-by-just-a-couple-minutes URL, I'll get a response that includes Link among its headers:
$ curl --head https://web.archive.org/web/20200908001640/https://www.whitehouse.gov/news/page/700/
HTTP/2 200

server: nginx/1.15.8
date: Tue, 08 Sep 2020 00:19:57 GMT
content-type: text/html; charset=UTF-8
content-length: 94237
x-archive-orig-accept-ranges: bytes
x-archive-orig-x-akamai-transformed: 9 - 0 pmb=mRUM,1
x-archive-orig-vary: Accept-Encoding
x-archive-orig-date: Tue, 08 Sep 2020 00:16:40 GMT
x-archive-orig-connection: close
x-archive-orig-server-timing: cdn-cache; desc=HIT
x-archive-orig-server-timing: edge; dur=2
x-archive-orig-strict-transport-security: max-age=31536000 ; includeSubDomains ; preload
x-archive-orig-x-frame-options: SAMEORIGIN
x-archive-orig-content-length: 86892
x-archive-guessed-content-type: text/html
x-archive-guessed-charset: utf-8
memento-datetime: Tue, 08 Sep 2020 00:16:40 GMT
link: <https://www.whitehouse.gov/news/page/700/>; rel="original", <https://web.archive.org/web/timemap/link/https://www.whitehouse.gov/news/page/700/>; rel="timemap"; type="application/link-format", <https://web.archive.org/web/https://www.whitehouse.gov/news/page/700/>; rel="timegate", <https://web.archive.org/web/20191209230029/https://www.whitehouse.gov/news/page/700/>; rel="first memento"; datetime="Mon, 09 Dec 2019 23:00:29 GMT", <https://web.archive.org/web/20200908001519/https://www.whitehouse.gov/news/page/700/>; rel="prev memento"; datetime="Tue, 08 Sep 2020 00:15:19 GMT", <https://web.archive.org/web/20200908001640/https://www.whitehouse.gov/news/page/700/>; rel="memento"; datetime="Tue, 08 Sep 2020 00:16:40 GMT", <https://web.archive.org/web/20200908001640/https://www.whitehouse.gov/news/page/700/>; rel="last memento"; datetime="Tue, 08 Sep 2020 00:16:40 GMT"
content-security-policy: default-src 'self' 'unsafe-eval' 'unsafe-inline' data: blob: archive.org web.archive.org analytics.archive.org pragma.archivelab.org
x-archive-src: live-20200907233222-wwwb-app52.us.archive.org.warc.gz
server-timing: PetaboxLoader3.resolve;dur=46.564307, CDXLines.iter;dur=33.142667, load_resource;dur=50.314292, captures_list;dur=274.855653, exclusion.robots.policy;dur=0.310041, esindex;dur=0.018585, exclusion.robots;dur=0.331817, PetaboxLoader3.datanode;dur=161.893453, LoadShardBlock;dur=217.201810, RedisCDXSource;dur=17.708182
x-app-server: wwwb-app41
x-ts: 200
x-location: All
x-cache-key: httpsweb.archive.org/web/20200908001640/https://www.whitehouse.gov/news/page/700/US
x-page-cache: HIT

So it seems the breakage is happening because savepagenow expects Link/memento to be included on the first response from web.archive.org/save. However, that header info only seems to appear when doing a request on an actual snapshot URL, e.g. https://web.archive.org/web/20200908001640/https://www.whitehouse.gov/news/page/700/.
Suggested fix
Maybe it's not worth checking for the 'Link' header, i.e.
    header_links = parse_header_links(response.headers['Link'])

Hmm. Sounds like we've seen a series of small changes to responses over the last couple months frustrating our efforts here. Thank you for the patience all.

Here's the headers I get back this morning.
{
  'Server': 'nginx/1.15.8',
  'Date': 'Tue, 08 Sep 2020 15:20:24 GMT',
  'Content-Type': 'text/html;charset=utf-8',
  'Transfer-Encoding': 'chunked',
  'Connection': 'keep-alive',
  'Content-Location': '/web/20200908152024/https://www.latimes.com/',
  'Set-Cookie': 'JSESSIONID=08602978E98325B0A00FCDB374EF52F3; Path=/; HttpOnly',
  'X-Archive-Orig-X-Amz-Cf-Id': 'w8k0ZEcdhaJB2rLggI7_r-Hb2MSbmzwNwl49WJOeJw2M1udibE1-3g==',
  'X-Archive-Orig-Vary': 'Accept-Encoding',
  'X-Archive-Guessed-Charset': 'UTF-8',
  'X-Archive-Orig-Server': 'Apache Tomcat',
  'X-Archive-Orig-Connection': 'close',
  'X-Archive-Orig-X-Powered-By': 'Brightspot',
  'X-Archive-Orig-Content-Security-Policy': 'upgrade-insecure-requests',
  'X-Archive-Orig-Age': '111',
  'X-Archive-Orig-Date': 'Tue, 08 Sep 2020 15:18:33 GMT',
  'X-Archive-Orig-X-Cache': 'Hit from cloudfront',
  'X-Archive-Orig-Content-Type': 'text/html;charset=UTF-8',
  'X-Archive-Orig-Via': '1.1 58b53da3f7d231b76d30fcffbf4945a1.cloudfront.net (CloudFront)',
  'X-Archive-Orig-X-Amz-Cf-Pop': 'SFO20-C1',
  'X-Archive-Orig-Cache-Control': 'max-age=180',
  'X-Archive-Orig-Transfer-Encoding': 'chunked',
  'X-App-Server': 'wwwb-app14',
  'X-ts': '200',
  'X-location': 'save-sync',
  'X-Cache-Key': 'httpsweb.archive.org/save/https://www.latimes.com/US',
  'X-Page-Cache': 'MISS',
  'Content-Encoding': 'gzip'
}

I've pushed a change as proposed here live in version 1.1.0. @dannguyen and @eggplants, tell me if it fixes things for you.
https://pypi.org/project/savepagenow/1.1.0/

The standard use-case (saving a page that actually exists) works for me, thanks!
Also tried an obvious error situation, e.g. $ savepagenow https://myksdlfasdklfjj.com and got a WaybackRuntimeError, as expected:
raise WaybackRuntimeError(error_header)
savepagenow.exceptions.WaybackRuntimeError: WaybackException: java.net.UnknownHostException: myksdlfasdklfjj.com: Name or service not known


[bug] 不能使用鼠标左键拖动滚动条

Describe the bug
https://github.com/user-attachments/assets/6825e979-b9b0-40a3-93e8-ae2e95bef7eb
Reproduction
No response
Expected behavior
No response
Software Information
{
  "appName": "EcoPaste",
  "appVersion": "0.2.0",
  "platform": "windows",
  "platformArch": "x86_64",
  "platformVersion": "10.0.22631"
}

Additional context
No response

收到反馈，后续优化下！


Add more test

for workgraph.py

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.11%. Comparing base (dd6fc9b) to head (efa5f3d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   89.57%   90.11%   +0.54%
==========================================
  Files          61       62       +1
  Lines        4507     4543      +36
==========================================
+ Hits         4037     4094      +57
+ Misses        470      449      -21

Flag
Coverage Δ

python-3.11
90.07% <100.00%> (+0.54%)
:arrow_up:

python-3.12
?

python-3.9
90.11% <100.00%> (+0.54%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Search functionality that performs a live search and displays results

Thanks! Merged in with this commit: b045476


Two modifications to handles, so that Jena can read/write streams.

Not much exciting in this PR, just getting basic functionality of Jena integration off the ground.
@sammefford  I can perform the merge to develop and 3.0-develop if you give me the goahead.

+1 to this - be good to get this in

Did a push -f to replace one of these commits from @sammefford feedback (inadvertantly removed QuadsWriteHandle)


Create graphics-engineer-2.md takehome

@michaelthatsit - added the newer version, had 2 quick questions and then feel free to make direct edits on top of this ~


HTTP/3 Support

add HTTP/3 Support

Any plan for this?

Since I followed the rabbit hole from Tokio and Tonic to here, the latest work appears to be over here currently:
https://github.com/djc/quinn/pull/734
Any best ways to support the latest efforts on http/3 support?

I have a branch going on here: https://github.com/djc/hyper/tree/quinn-h3. This adds (completely untested) support for HTTP/3 to the hyper server, but doesn't yet add any API to set it up. I have some ideas on how to do that. The work also more or less depends on #2182 and #2188 (which are currently included in that branch).

@djc Looks like all of the tickets but https://github.com/hyperium/hyper/pull/2182 were merged. Does this mean that https://github.com/djc/hyper/tree/quinn-h3 is getting close?

I've been discussing it with @seanmonstar, as far as I can tell he's still figuring out how he wants to go about it.

We've put together a proposal here: https://github.com/hyperium/h3/pull/1

With the proposal merged, what is the best way to see current status towards first MVP of the functionality? and with status, ways to support the effort?

To the best of my knowledge, work is ongoing in the h3 repo. There is a h3 channel in the Tokio Discord which you might join, as well.
(If by support the effort you mean financially, I might be available to accelerate the efforts on a consulting basis. If that is of interest, shoot me an email.)

Good point, I'll see about setting up a milestone with all the issues needed to get the design working. If by support the effort you mean to contribute code, as mentioned, there's an h3 Discord channel to discuss next features, and I'll get a milestone going. There is the general issue tracker, which already has some work split up.

Congrats on the recent h3 progress(client side request fetching from cloudflare)!
Given the recent activity in h3, and the closing of several of the functionality related issues, what would the hyper next steps look like? I assume there'd be some kind of an h3 release(which would include the minimal public api docs, etc).
Any easier coding work in view?

Yes, an h3 0.1 release would be a necessary step. I've add a few more issues, labels, and a milestone, that should have some "easier" and some more involved work to get there.
Another step to figure out is how to actually provide the support in the hyper crate. That's something I haven't thought too much about. I think some of the requirements though, considering the goal of stabilizing hyper into a 1.0 release, would require:

Not exposing the h3 library directly, so we can iterate on h3 without it being breaking changes for hyper.
Making it optional, like http1 and http2 are.
Probably not bundle any particular TLS library with hyper directly.

We can try to figure out both of these things in parallel, so thoughts are welcome!

Looks like the only issue still attached to the v0.1 milestone is docs related. Is that accurate? https://github.com/hyperium/h3/milestone/1

IETF has published RFC 9114

I've filed an issue in reqwest to explore using the h3 crate, which would help inform what APIs to expose directly in hyper: https://github.com/seanmonstar/reqwest/issues/1558

Hi, everyone, Is he ready for experimental use now? It is best to use it directly in downstream projects, such as axum, warp...
thanks a lot~

Hi,
Can you use https://github.com/cloudflare/quiche to support http/3?

So any updates on QUIC support?

Are you accepting PRs for this, perhaps a draft?

dont understand how one of most important if not most important features of modern web technologies is still not implemented in most popular Rust server framework especially when For every second delay in mobile page load, conversions can fall by up to 20% and HTTP/3 helps with load times and 0RTT a lot..

@schizobeyond-tech H3 is still fairly immature as a web technology, and things like congestion control, flow control, IO model, and the standards themselves around QUIC are all evolving still quite rapidly. To compound this, the IO model of H3 is very different than H2 or H1, creating new performance challenges. Not having a dedicated listener socket like with TCP poses a lot of questions and creates a number of challenges. Furthermore, the surface area of HTTP/3 is rapidly evolving in a manner that makes QUIC and H3 support a bit of a moving target (see the introduction of capsules and WebTransport, for example). One of the goals of hyper's H3 support has been support for multiple H3 backends, and this gets much harder because of these challenges.
H3 support in hyper is a work in progress, with much of the work still very much being around answering the question of "how should this be implemented, and what kinds of tradeoffs do we want to make".
Also, as someone with a lot of experience in this area, H3 performance in the real world is a lot more complicated than you make it out to me. In many cases, even on mobile, H2 can be faster, and we're seeing things like congestion and flow control evolve rapidly to improve the performance of H3 (and even normal TCP as well. Also, zero-RTT doesn't have necessarily the impact you might think all too often. It's very common for real-world performance to be more impacted by bandwidth than the number of RTTs required.

Thank you @Noah-Kennedy for the update. Implementing the client part of HTTP/3 first, could be a viable approach ? Especially considering that many load balancers already support translation between HTTP/3 and HTTP/2.
┌────────────┐      ┌──────────┐     ┌──────────┐
│            │      │          │     │          │
│    App     │      │    LB    │     │ Backend  │
│ H3-Client  │─────▶│ H3 -> H2 │────▶│    H2    │
│            │      │          │     │          │
└────────────┘      └──────────┘     └──────────┘

We have multiple applications running on the AppStore/PlayStore with a networking stack in Rust, having a client-side support for HTTP/3 would be a significant advantage.

@schizobeyond-tech H3 is still fairly immature as a web technology, and things like congestion control, flow control, IO model, and the standards themselves around QUIC are all evolving still quite rapidly. To compound this, the IO model of H3 is very different than H2 or H1, creating new performance challenges. Not having a dedicated listener socket like with TCP poses a lot of questions and creates a number of challenges. Furthermore, the surface area of HTTP/3 is rapidly evolving in a manner that makes QUIC and H3 support a bit of a moving target (see the introduction of capsules and WebTransport, for example). One of the goals of hyper's H3 support has been support for multiple H3 backends, and this gets much harder because of these challenges.
H3 support in hyper is a work in progress, with much of the work still very much being around answering the question of "how should this be implemented, and what kinds of tradeoffs do we want to make".
Also, as someone with a lot of experience in this area, H3 performance in the real world is a lot more complicated than you make it out to me. In many cases, even on mobile, H2 can be faster, and we're seeing things like congestion and flow control evolve rapidly to improve the performance of H3 (and even normal TCP as well. Also, zero-RTT doesn't have necessarily the impact you might think all too often. It's very common for real-world performance to be more impacted by bandwidth than the number of RTTs required.

this is just a skill issue on your end, i'll continue using .NET Core instead of hyper. Will check back in 2-5 years

@QuentinPerez I've so far suggested building out the client implementation in reqwest, where it can be an internal detail, and flesh how it works, before making some public API in hyper. There is a working (but unstable) feature in reqwest. There's likely a few more things to try out, I could put together an issue over there if interested.

There is a working (but unstable) feature in reqwest.

Can we make it available without having to pass --cfg reqwest_unstable?
Since reqwest hasn't reached 1.0 yet, it's ok to have new breaking release.
Putting the feature behind --cfg reqwest_unstable only make it harder to adopt, I really want to enable http3 support in cargo-binstall, however due to the cfg I didn't enable it.

@QuentinPerez I've so far suggested building out the client implementation in reqwest, where it can be an internal detail, and flesh how it works, before making some public API in hyper. There is a working (but unstable) feature in reqwest. There's likely a few more things to try out, I could put together an issue over there if interested.

I've been using the unstable feature since its release, such as handling media uploads or downloads on GCS. Thus far, it works as expected 🙏  (GCP LB).
Since we use GRPC, I would like to test it with Tonic. If you could provide a straightforward example of an H3 client, integrated into Hyper, it would be awesome. Then I could try integrate it in tonic and test it out with our users and report the issues if any.

@seanmonstar why not also allow an unstable (guarded by --cfg) implementation in hyper?

Any news here?

Hi,
Any news on this issue?
Love hyper and love quic...


Serve non-minified version of jump.js

I get the following error in my application when using jump.js with Webpack. Since most people are doing minimization anyways later in their compilation pipelines, shouldn't jump.js try to serve a non-minified file? It would be just one change in the gulpfile I think.
WARNING in ./~/jump.js/dist/jump.min.js
Critical dependencies:
6:406-413 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
 @ ./~/jump.js/dist/jump.min.js 6:406-413

I’m just taking a wild guess the "main": "dist/jump.min.js" in the package.json is what’s npm is using to decide which file to use? I vote +1 to change it to the non-minified file.

Correct, that's what npm is using to decide on the minified file. I think this requires a small code change to change the build script to not minify, but I'm not 100% sure.

@vincentorback @saarons makes sense, since people using this from NPM must be using a module bundler and likely minify their build anyways. I want to support ES6 practices and workflow above all else, and I think this suggestion is in line with that.
the relevant line of the gulpfile is here. removing that will keep the dist file from being minified. if it's not minified, it would also be wise to rename it, removing the .min.
this weekend, i'm planning on un-minifying all my dist files, for all my libraries, as well as adding the jsnext:main field to all my package.jsons, to support tree-shaking module bundlers like rollup

Will this be implemented any time soon?

For those waiting, Sitepoint offers a ES5 version in an article about this lib. Don't know the diff to the last version, but seems to work and includes an accessibility bugfix as a bonus. http://www.sitepoint.com/smooth-scrolling-vanilla-javascript/
(Note: I'm not affiliated with them, just thought it is worth pointing out while this case is open)

please see #31, and leave your feedback!


Matchers

Hi,
I've added a matcher to test if an object is an instance of a particular class.
Usage:
var obj = new SomeClass();
expect(obj).toBeInstanceOf(SomeClass);
Cheers,
Johan

We have another pull request that solves this issue: https://github.com/pivotal/jasmine/pull/100.
It should be in 1.2 shortly.


Integrate with Django's ManifestStaticFileStorage

Ensure's that White Noise realises these are cacheable assets and adds appropriate far-future expiry headers.
This requires Django 1.7 or later. I'm open to suggestions for how to add that into the code. Currently the option is silently ignored if the imports fail.
Fixes #56

This seems like a very good implementation. Thanks!


[QUESTION] Svelte Component Library Ergonomics

Hi again,
I wasn't sure how to contact you about any questions but I'll just ask here.
In terms of HyperUI components, there are a variety of ergonomic choices that are necessary.
There are 4 stylistic choices that I have come up with
Option 1: Using Svelte Fragments
<!-- where simple-base is a component-scoped style which is the same as the simple buttons default value -->
<Button class="simple-base user-defined-classes">
    <svelte:fragment slot="content">
        Content
    </svelte:fragment>
</Button>

<Button class="icon-border">
    <svelte:fragment slot="content">
        Content
    </svelte:fragment>
    <svelte:fragment slot="icon">
        <!-- Can be a user defined svg  -->
        <SvgRightArrow />
    </svelte:fragment>
</Button>

<!-- Default gradient pill with default content  -->
<Button class="gradient-pill"></Button>

Option 2: Using child components
<Button>
    <!-- Potentially use a separate type prop instead  -->
    <ButtonContent slot="content" type="icon">
        SomeContent
    </ButtonContent>
    <ButtonIcon slot="icon">
        <SomeSVG/>
    </ButtonIcon>
</Button>

<Button class="gradient-base user-defined-classes">
    <!-- Use classes with this method  -->
    <ButtonContent slot="content" class="user-defined-classes">
        SomeContent
    </ButtonContent>
    <ButtonIcon slot="icon">
        <SomeSVG/>
    </ButtonIcon>
</Button>

Option 3: Without slots
<Button>
    <ButtonContent>
        SomeContent
    </ButtonContent>
    <ButtonIcon>
        <SomeSVG/>
    </ButtonIcon>
</Button>

<!-- Switch the order of Icon and Button  -->
<Button class="icon-base">
    <ButtonIcon>
        <SomeSVG/>
    </ButtonIcon>
    <ButtonContent>
        SomeContent
    </ButtonContent>
</Button>

Option 4: Autogenerated
<!-- could be automatically generated from a fork of hyperui -->
<ButtonSimpleBase>
    <ButtonSimpleBaseContent>Content</ButtonSimpleBaseContent>
</ButtonSimpleBase>

For all of these options, styles could be separated out into sub-styles per component. This could be done pretty easily using @apply directives in postcss.
@tailwind base;
@tailwind components;
@tailwind utilities;

@layer components {

    .simple-base {
         @apply inline-block rounded border border-indigo-600 bg-indigo-600 px-12 py-3 text-sm font-medium text-white hover:bg-transparent hover:text-indigo-600 focus:outline-none focus:ring active:text-indigo-500;
    }

    .simple-border {
        @apply inline-block rounded border border-indigo-600 px-12 py-3 text-sm font-medium text-indigo-600 hover:bg-indigo-600 hover:text-white focus:outline-none focus:ring active:bg-indigo-500;
    }

    .icon-base {
        @apply simple-base;
        @apply inline-flex items-center gap-2 rounded px-8;
    }

    .icon-border {
        @apply simple-border;
        @apply inline-flex items-center gap-2 px-8;
    }

}

I think that's about it, I would love to hear your feedback on this!

Hi @markmead
Yeh, I agree. A lot of other popular libraries (such as skeletonUI ) use this method. I feel it gives a lot more versatility.
As for the CSS, I have taken into consideration the user's colour schemes.
Essentially, the @layer and @apply directives are our best friends here, as any additional styles that are specified will overwrite any applied styles.
E.g.
<Button class="text-xl bg-slate-600 border-slate-600 hover:text-slate-600 active:text-slate-500 simple-base">
    <svelte:fragment slot="content">Download</svelte:fragment>
</Button>

Here we pass on classes to the main styled element, alongside the simple-base class. Since simple base uses the apply directive, the user's colours will overwrite simple-base's defaults.
Maybe in the future it may be good to make a more stripped down hover:-less style for when the user specifies their own colours, but for the meantime this is good.

Also @markmead are you using heroicons for your icons? Would it be good to formalize said icons?

Essentially, the @layer and @apply directives are our best friends here, as any additional styles that are specified will overwrite any applied styles.

I wouldn't want those unused styles in my compiled CSS, or in my HTML as it looks a little amateur having bg-indigo-600 bg-red-600 on an element. I'm probably guilty of that in a few places, but definitely something I try to avoid.
And yes, the icons used are Heroicons. What do you mean by "formalize said icons"?

I enabled discussions on HyperUI but removed them as I didn't see much use, I'll enable them again for topics like this.


The script needs to be updated to support V2. The sample uses Names which is no longer there in Az module. As an example Get-AzDataFactoryActivityRun should be updated to Get-AzDataFactoryV2ActivityRun

The script needs to be updated to support V2. The sample uses Names which is no longer there in Az module. As an example Get-AzDataFactoryActivityRun should be updated to Get-AzDataFactoryV2ActivityRun. Please update the script, when i try to open the git link to edit the sample, it throws me 404.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a8e5404-ef7f-4c0c-14e4-593ec45b22d9
Version Independent ID: f715e16b-b877-3c7e-b918-3525af0dcdc2
Content: PowerShell script: Copy data in the cloud by using Azure Data Factory
Content Source: articles/data-factory/scripts/copy-azure-blob-powershell.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@rajukum Thanks for the feedback and bringing this to our notice. At this time we are reviewing the feedback and will update the document as appropriate.

@rajukum Thank you once again for reporting the issue. I have submitted a PR to update the script to support ADF V2. The changes will be merged once the PR is approved. The document should be updated anytime sooner.
I am closing the issue based on this update, please let us know if there is something else that we can help you with.
Thank you.

I was having issue in merging the PR so I have reopened this issue and assigned this to Content author to make necessary changes to the document.

Thanks for the feedback! Scripts in this article have been refreshed. We will now proceed to close this thread.
(Please open a new issue if you have follow up questions.)
#please-close


[OOBE] text for SCG is old

Microsoft PowerToys version
0.45 RC
Area(s) with issue?
Welcome / PowerToys Tour window
Steps to reproduce
Open OOBE, got to Shortut Guide page. See the Win-key text.
✔ Expected Behavior
Text to match current functionality.
❌ Actual Behavior
Text is not in line.
Either update the text (simple solution) or see #11963 - revert back asap.

Same as https://github.com/microsoft/PowerToys/issues/12635 and related to #11895?
Yeah, we need to have a way to load in load the active shortcuts or mention that it's the default but can be changed

Yes, you're right about both. Missed the first one. This needs to be handled quick tho, look at 11963.


ssl_calls: support OpenSSL 1.1.0 API for setting DH params

OpenSSL 1.1.0 makes many structs opaque now, so we can't set its values directly anymore.
Also:

fix memory leak introduced by PR #1024 in get_dh2236().
move SSL_CTX object creation check to its right place. use log_message for logging.

Meta, can you test on OpenSSL < 1.0.x (1.0.2)?
Thx
בתאריך יום א׳, 18 במרץ 2018 ב-16:12 מאת metalefty<EMAIL_ADDRESS>
:

@metalefty commented on this pull request.
In common/ssl_calls.c
https://github.com/neutrinolabs/xrdp/pull/1063#discussion_r175290570:

#if defined(SSL_CTX_set_ecdh_auto)
SSL_CTX_set_ecdh_auto(self->ctx, 1);
#endif

 if (g_strlen(tls_ciphers) > 1)
 {

   log_message(LOG_LEVEL_TRACE, "ssl_tls_accept: tls_ciphers=%s", tls_ciphers);

   log_message(LOG_LEVEL_TRACE, "ssl_tls_accept: tls_ciphers=%s", \

backslash is not needed here.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/pull/1063#pullrequestreview-104798633,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTH1H_e_RHtXSjN5cG1zbypLesw6hRtks5tfms5gaJpZM4Sutmj
.

--
Idan Freiberg
PGP FP: 8108 7EC9 806E 4980 75F2  72B3 8AD3 2D04 337B 1F18

maybe we need to add travis build with multi ssl versions

Yes. We need to switch Docker-based travis build. I already do it in RH-Matic to test multiple CentOS version. The bare travis build environment is Ubuntu 14.04. Can't test vsock, too.

Can you resolve conflict before I test with OpenSSL 1.0.x?

@metalefty docker builds will be great. I'll work on that too.
About the conflict, I was thinking maybe the static DH groups are actually ok :)
But I want to have some coding style changes

i'll add them to this PR

ok, added DH groups back and changed the function name.
can you review again? if its fine we can merge.
Iv'e tested on Ubuntu 16.04 (openssl 1.0.2) and archlinux (openssl 1.1.0g)

Overall, logic looks good. Let me test it later.

Tested, working fine. If no more concerns, let's ship it to v0.9.6.

Lets merge
בתאריך יום ה׳, 22 במרץ 2018 ב-4:59 מאת metalefty<EMAIL_ADDRESS>
Tested, working fine. If no more concerns, let's ship it to v0.9.6.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/pull/1063#issuecomment-375163279,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADTH1KL_lXIztIxUNLY8cHwQ86X2piW3ks5tgxNtgaJpZM4Sutmj
.

--
Idan Freiberg
PGP FP: 8108 7EC9 806E 4980 75F2  72B3 8AD3 2D04 337B 1F18


Don't show infobox for incomplete vaccination if Booster vaccination certificate is available (EXPOSUREAPP-9176)

Addresses user story EXPOSUREAPP-9176.
How to test:

cwa vc gen -s v.0.dn=1 v.0.sd=2 -e wru --seed mm
cwa vc gen -s v.0.dn=2 v.0.sd=2 -e wru --seed mm
cwa vc gen -s v.0.dn=3 v.0.sd=2 -e wru --seed mm (Booster)

Note: Untested, but it should work

lgtm

I think the note should disappear , right ?

lgtm

I think the note should disappear , right ?

the infobox with incomplete status is gone. The message is about "everything is ok in some days"..


Add sample/sampleTime operator split

Description:
When using a number interval, we must now use sampleTime instead of sample. This was not specified in the document.
Related issue (if exists):

Changes Unknown when pulling d04c0e8f9b281ee8eacf46060e74868f35bfd500 on sergi:patch-1 into ** on ReactiveX:master**.

👍  thank you!
LGTM


Toaster documentation missing

Description
Would be helpful to have code and examples on the taost page for the toaster wrapper. Like UI slots etc.
Additional context
No response

@HugoRCD Not exactly change but a "taoster" documentation is missing. A documentation about the theme etc would be great. Just like the "toast" documentation

I just found what I was looking for. Kinda missed it. But for the future maybe showing this block "You can check the App component toaster prop to see how to configure the Toaster globally." at the end of the page somewhere near the "theme" section on the "toast" page would help to find it better


getMaxLTV, getSaveLTV

Now that max/safe ltv is a value that can change and with eth potentially having a different LTV can we get a getMaxLTV and getSaveLTV function for borrow.

should also be allowed to feed it the asset to check the LTV for so feeding it bluna or beth will return their respective LTV or have it return a dictionary of all LTVs that programmers can sort through on their side.

sure, will add in the next release.


chore: remove createAction

The createAction was a workaround for an issue in the Node SDK. That issue has since been fixed, and createAction can be safely removed.

@ryanhopperlowe and I both tested this and saw it working, so I feel good about it.


Can you please test this repo  on the following Image

Can you please test this repo on the following Image?

This is the result from this repo.


feat: introduce namespace in logger and tracer

Issue #, if available: #146
Description of changes:
Introduce the namespace in the Tracer and Logger.
Checklist

[x] Meet tenets criteria
[ ] Update tests
[ ] Update docs
[x] PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hey @Nr18 could you wait a bit on that, please?
I haven't had time to review the RFC/proposal, and hear from other customers on that.
cc @nmoutschen @cakepietoast @igorlg if you haha the bandwidth as I'm working on other issues right now

Ah sure, no problem 😄
I actually just changed that so that I could see what was needed.


Update log index mappings prefix

Indices have the prefix logs-v0.5.4. I'd like to remove "v0.5.4" from the prefix.

https://github.com/rancher/opni/blob/1483af9cae6d7a7fe336f890ea8ee7c48b21cf43/pkg/resources/multiclusterrolebinding/settings.go#L15 should be updated


Feature: Add static get method to Api-Gateway V1 REST Api

I would like to have one API gateway instanciated in one stage and references by another.

@dror-weiss are you looking to reference the API from another stage, and then add routes to it? Can you expand on ur use case a bit?

@fwang , I need to reference an existing APIG from another sst.config.ts, having the class of it so I can call .route() without copying your logic.
The use case for it is creating a single APIG for many services, and instead of having the APIG's sst.config.ts "know" all the other services, each service will need to "know" the APIG so that it can attach and detach itself as a route to it. This enables me to better architecting my microservices.

hmm ApiGateway REST API is one of the few resources that are tricky/buggy to be shared.
REST API needs to create a Deployment resource after all routes are added. It needs to be aware of ALL the routes, and compute a unique hash based on routes' properties. When multiple SST apps are adding routes to the same API, each app will create a Deployment resource with partial information about the routes.
This is specific to REST API's design. You wouldn't have the same problem with ApiGateway HTTP API, which can be easily shared.
If your goal is to have a single API endpoint across multiple services, have u considered creating separate APIs and map them to the same custom domain?

I need a REST API due to the fact it has features HTTP doesn't have, e.g. usage plans.
I worked out the deployment issue with a common route function that is shared in every route that "joins" the APIG, so this shared code issues a deployment:
const api = ApiGatewayV1.get(...);
const route = api.route(...);
new aws.apigateway.Deployment(
      'deployment',
      {
        restApi: args.api.id,
        stageName: $app.stage,
        description: `Initiated by the "${args.route.path}" route`,
        triggers: {
          redeploy: route.nodes.integration.id
        }
      },
      {
        retainOnDelete: true
      }
    );


Do not pass Throwable in Error handling code in samples

Please see this conversation: https://github.com/lyft/domic/pull/33#discussion_r212858051

Btw. we pass errorCode : Int around (instead of Throwable)
and also display that in UI along with the corresponding error message that is determined by the error code. Helpful for bug reports.

Thank you for you contribution to this repository.
Closing this Issue as this repository is being archived.


change: Split Examples out into their own CI run

Issue #, if available: N/A
Description of changes: Split running the example notebooks into their own CI step. This should hopefully allow Windows to succeed again and make the test Project.toml more concise.
Testing done: Tests passed locally.
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
General

[x] I have read the CONTRIBUTING doc
[x] I used the commit message format described in CONTRIBUTING
[x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

[x] I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
[x] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[x] I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
Patch coverage has no change and project coverage change: -19.45% :warning:

Comparison is base (c43bc16) 95.71% compared to head (b275319) 76.27%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #64       +/-   ##
===========================================
- Coverage   95.71%   76.27%   -19.45%
===========================================
  Files          35       35
  Lines        4040     3911      -129
===========================================
- Hits         3867     2983      -884
- Misses        173      928      +755

see 27 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Way to retrieve TextInput value programmatically via property access or method call?

I've been looking @ the TextInput.ios.js source and noticed that there is no programmatic way for developers to query the current value.
Perhaps _onChange or _onTextInput should cache the value?
I'm happy to attempt a PR, but wanted to gather the team & community thoughts about this.

I've put a hack together locally:
...
    onTextInputChange : function(event) {
        this.textInputValue = event.nativeEvent.text;
    },

...
                    <TextInput
                        placeHolder="Test placeHolder"
                        autoCapitalize="sentences"
                        style={styles.textInput}
                        ref="textInput"
                        onChange={this.onTextInputChange}
                    />
...

Works but i'm really not proud of it.

See Controlled Components: https://facebook.github.io/react/docs/forms.html#controlled-components

Thanks @frantic .  It seems that I was onto the correct path with onChange. :-\
I'm used to the pattern of "asking" for the value, rather than it being constantly presented, so this feels a bit strange.
Many thanks for the prompt response.

@jaygarcia
I dont see event.target.value in case of "onSubmitEditing" event in react native, however I do see my value in event.nativeEvent.text,
So is it ok to go with event.nativeEvent.text,
Thanks

onChange is not always the solution. I am having issues when I use keyboard shorcuts:
This is the scenario: I am filling up a login form (username and password)
I set a shortcut for my username.
When I enter the shortcut and then I push on the return button, I go to the next field (password).
When I enter the last key for the shortcut, onChangeText and onChange will return the value of the shortcut.
When I push enter, none of those events are called up and therefore , I am not able to get the actual value for the shortcut.
Sine there is no way to get the value of the input text other than using those callbacks, what would be a solution for this case?

This is how I do:
class Login extends Component {
  constructor(props) {
    super(props)

    this.fields = {
      email: null,
      password: null,
    }

    this.state = {
      ...this.fields,
    }
  }

  render() {
    return (
      <View>
        <TextInput
          value={this.state.email}
          onChangeText={text => this.fields.email = text}
        />

        <TextInput
          value={this.state.password}
          onChangeText={text => this.fields.password = text}
        />

        <TouchableHighlight onPress={this._submitForm}>
          <Text>Submit</Text>
        </TouchableHighlight>
      </View>
    )
  }

  _submitForm = () => {
    const { email, phone } = this.fields

    this.setState({
      email,
      phone,
    })

    // do some stuff here…
  };
}

Probably not the best solution, but clean enough for me.

Frankly, I believe that @zoontek's solution is the cleanest I've seen thus far. All the other solutions I've seen seem to be predicated on the notion that each field will have its own method used to update the state, otherwise how will the function know which state property it's supposed to be updating?
Additionally, onSubmitEditing seems somewhat unreliable in that it doesn't fire when the user changes fields without hitting a submit button, which may leave some values unrecorded. (This was the case at least in the XCode emulator, which may not reflect actual behavior.) Better perhaps to record each change to the text with onChange, retrieve all the values from an object recording those changes and then updating the state with that when the form's submit button is pressed.

thank you @zoontek very helpful

@zoontek, your code above does not work for me unless I call this.setState.  I'm using react-ntave 0.22.2
Did they change the way react-native worked between Jan 10 and March?

@mark0978 react-native change a lot, so yes, no hack needed using 0.22.2. I updated the snippet.

@zoontek  Are you sure that is right?  Looks like you clobber the rest of the state that way.....

@mark0978 I've just tried it with RN 0.22.2 and it works great.
The rest of the state don't change because I'm using this.setState(), and not this.state = {}

It's good to know that, I'm new to react.

@mark0978 If you are like and doesn't want to use or pollute state for one-off components here's what I did:
export default class Registration extends Component {
  _register = () => {
    const payload = {
      firstName: this.firstName,
      /* other values */
    }

    console.log(payload)
  }

  render() {
    return (
      <RegisterLayout>
        <Text style={styles.welcome}>
          Register
        </Text>

        <InputText
          placeholder="First Name"
          onChangeText={(text) => this.firstName = text} />
        // More components...
        <CustomButton
          backgroundColor="steelblue"
          handlePress={this._register}>
          Submit
        </CustomButton>
     </RegisterLayout>
    )
  }
}

The value of TextInput may be retrieved through its _lastNativeTextproperty.
this.refs.myTextInput._lastNativeText
The TextInput component needs a ref assigned to it of course.

According to peacehen post, You can use
 sendMessage() {     let phone   = this.refs.phone._lastNativeText;     let encrypt = this.refs.encryptkey._lastNativeText;     //do something   }  <TextInput ref="phone" /> <TextInput ref="encryptkey" />   <TouchableOpacity style={styles.btn}                     onPress={this.sendMessage.bind(this)}                 >                    <Text style={styles.btnText}>                       Send Message                    </Text>  </TouchableOpacity>
Hope it help

No need to deal with refs. And here's how you'd clean up all the multiple calls to this.setState in case you have many form fields. Simply define a method (updateFormField) that takes a string parameter of the field name and returns an event-handling function:
class SignIn extends React.Component {
  state = {
    email: '',
    password: '',
  }

  constructor (props) {
    super(props)
    this.updateFormField = this.updateFormField.bind(this)
    this.submitForm = this.submitForm.bind(this)
  }

  updateFormField (fieldName) {
    return (event) => {
      this.setState({
        [fieldName]: event.nativeEvent.text,
      })
    }
  }

  submitForm () {
    const {
      email,
      password,
    } = this.state
    // Now do something with email and password
  }

  render () {
    return (
      <View>
        <TextInput onChange={this.updateFormField('email')}/>
        <TextInput onChange={this.updateFormField('password')}/>
        <Button title="Sign In" onPress={this.submitForm} />
      </View>
    )
  }
}

@kylecorbelli refs are only used in my example to focus on the next input when the keyboard submit button is pressed.
Your solution is interesting, and can be simplified to:
class SignIn extends React.Component {
  state = {
    email: '',
    password: '',
  }

  updateFormField = fieldName => text => {
    this.setState({ [fieldName]: text })
  }

  submitForm = () => {
    const { email, password } = this.state
    // now do something with email and password
  }

  render() {
    return (
      <View>
        <TextInput onChangeText={this.updateFormField('email')} />
        <TextInput onChangeText={this.updateFormField('password')} />
        <Button title="Sign In" onPress={this.submitForm} />
      </View>
    )
  }
}

@zoontek nice!

import React, { Component } from 'react';
import { AppRegistry, Text, TextInput, View, StyleSheet, TouchableOpacity } from 'react-native';

export default class PizzaTranslator extends Component {
  constructor(props) {
    super(props);
    this.state = {username: '', password: '', email: ''};

    this.login = this.login.bind(this);
  }

  login = () => {
    console.log(this.state, 'console')
    alert("Username : " + this.state.username);
  }

  render() {
    let {username, email, password} = this.state;
    return (
      <View>
        <TextInput
          style = {styles.input}
          value={username}
          placeholder = "Enter Your Name"
          refs = "textInput"
          onChangeText = {(username) => this.setState({username})}
          >
        </TextInput>

         <TouchableOpacity
          style = {styles.button}
          onPress = {
            () => this.login()
          }>
          <Text>Submit</Text>
        </TouchableOpacity>

      </View>
    );
  }
}

const styles = StyleSheet.create({
  input : {
    flex:1,
    margin: 20,
    height: 20,
  },
  button : {
    textAlign: 'center',
    margin: 20,
    padding: 20,
    backgroundColor: 'steelblue',
  }
})

// skip this line if using Create React Native App
AppRegistry.registerComponent('AwesomeProject', () => PizzaTranslator);

This worked for me, getting username value and showing in alert.


Allow default branch to be set to master/main on update, using a new github_branch_default resource

Closes #193
Best explanation/reasoning for the change is here: https://github.com/terraform-providers/terraform-provider-github/pull/194#issuecomment-675587125

@radeksimko Apologies for the ping, but this is ready to be merged and fixes a bug that is hurting us - does it look good to you?

ping
I have same issue with the latest releases (Terraform v0.13.0 and GitHub provider v2.9.2).
any progress?

@jcudit @liamg I think I've caught up on all the comments, so here is my $0.02:

default_branch is supposed to only be managed on PATCH, which means it shouldn't be sent on the first GET. Therefor, the check should be based on whether the repo already exists or not.

This whole issue creates a workflow issue. One must define the repo, apply, update to point at a new branch, apply again. This workflow completely breaks if the new branch was created with github_branch.

My suggestion is to create a new resource, github_branch_default, to track this attribute, and stop managing it in github_repository.

default_branch is supposed to only be managed on PATCH, which means it shouldn't be sent on the first GET. Therefor, the check should be based on whether the repo already exists or not.

This creates a fundamental workflow issue: One must define the repo, apply, update to point at a new branch, apply again. This creates a dependency cycle if the new branch is created with github_branch.

My suggestion is to create a new resource, github_branch_default, to track this attribute, and stop managing it in github_repository.

Good find, I did not notice the patch vs get here. This actually makes a lot of sense now why I solved those problems within my module by abusing auto_init to create a workflow that does not have this issue but relies on 2 plan/apply cycles. Even with this removed I will likely need to keep those "hacks" as there are similar but different issues with branch protection. There is still a part of me that dislikes forcing it as another resource for a number of reasons that mostly boil down to user experience; mostly manifesting in migration/upgrade and breaking changes. I would think we may want to keep the current behavior (with deprecation warnings) and add the new resource this will help consumers identify the issues and how to resolve them.

@majormoses @jacobisaliveandwell Thanks for the discussion! I've run with the idea above and added a github_branch_default. This is my first full new resource so all criticism/ideas will be gratefully received! Hopefully my documentation change is also sufficient...

Also I can raise this as a fresh PR if that makes things easier?

This could potentially help with the situation in #513 too

Looks good! :shipit:

@jcudit this is ready for review

Any idea on timelines for this to be released? This would be extremely useful to restore "master" on new repositories given the recent changes...

@dwilliams782 thanks for the ping.  Lets get this into the next release.
@liamg are you around to address the outstanding conflict?

@jcudit Yep, conflicts resolved :)


Add async option to RouteLayer

completed with https://github.com/aurelio-labs/semantic-router/pull/326


fix: do not fall back to node_modules in a PnP environment, and don't hide PnP errors

In a PnP environment you don't want to fall back on node_modules search logic.  If PnP says that a dependency can't be resolved, then it shouldn't be resolved.  PnP is designed to really own module resolution.
PnP is intentionally stricter about loading dependencies.  For example, it won't allow a module in one package to import another package unless the first one has declared the second as a dependency.  Being able to "find" that dependency doesn't matter.  If the environment is PnP and PnP says it can't be resolved, then it shouldn't be resolved.

But how will we resolve internal modules then ? There has to be a workaround with an exception here

Internal modules are resolved before checking PnP so they still override PnP.


Account roles

If more then one Rosa cluster is installed using the same AWS account, the account-roles must no be deleted. Added this functionality.
Fixed cluster creation error if the kms_key_arn is not defined.

Thank you


CTRL-F Replace All Not working

Another weird modelling app bug seemingly only on my machine. Ctrl-F replace all updates the code pane, but not the model. Refreshing reverts back to before the text was updated, and deletes any other changes made.
https://github.com/user-attachments/assets/355def7a-318d-4005-8635-eeb31f56b509

Core Dump
coredump-3066eef4-8e1b-4fea-afa8-943c205ab344.json
Reference ID: 3066eef4-8e1b-4fea-afa8-943c205ab344

KCL Code
//any model

A fresh install of ZMA resolved this issue


mistake in document "Bring your own keys (BYOK) with Azure disks in Azure Kubernetes Service (AKS)" commands don't work

issue in the following page: https://learn.microsoft.com/en-us/azure/aks/azure-disk-customer-managed-keys
the commands don't work in bash.
the value assignment should be in the following way:
var=$(az ...)
example 1:
# Retrieve the Key Vault Id and store it in a variable
$keyVaultId=az keyvault show --name myKeyVaultName --query "[id]" -o tsv

should be:
keyVaultId=$(az keyvault show --name myKeyVaultName --query "[id]" -o tsv)
example 2:
# Retrieve the Key Vault key URL and store it in a variable
$keyVaultKeyUrl=az keyvault key show --vault-name myKeyVaultName  --name myKeyName  --query "[key.kid]" -o tsv

should be:
keyVaultKeyUrl=$(az keyvault key show --vault-name myKeyVaultName  --name myKeyName  --query "[key.kid]" -o tsv)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cb36087b-eaa6-ae3b-b3bb-6cb58268c3b9
Version Independent ID: 2567f115-766c-f94f-7696-eb3bb94ba480
Content: Use a customer-managed key to encrypt Azure disks in Azure Kubernetes Service (AKS) - Azure Kubernetes Service
Content Source: articles/aks/azure-disk-customer-managed-keys.md
Service: container-service
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@stassorokintheta
Thanks for your feedback! We will investigate and update as appropriate.

Hi @stassorokintheta
Thanks for reporting this! We have created a PR for this issue and the changes should go live soon.


[datadog] mount auto_conf in the right folder for alpine images

Update the daemonset and deployment templates to account for alpine variants looking for auto_conf templates in the /opt/datadog-agent/agent/conf.d/auto_conf folder instead of the standard /etc/dd-agent/conf.d/auto_conf.
If you run a custom image, you need to name your tags xyz-alpine for that logic to kick in.

/ok-to-test

/lgtm

/lgtm


Add createBlessedRenderer function

Fixes #79
The diff looks long mostly because of whitespace changes, there are no major modifications to the code.

Thanks @d4rky-pl. I will need some time to read this. Just discovered neo-blessed. Didn't know about this.

@Yomguithereal someone linked it either in issues here or in original blessed. The diff looks complicated but it's basically moving everything below type Instance into a function so blessed is passed from outside and not from require and then returning what used to be the old render function.
If it helps I can split it into two commits, one without adding indentation (which is what destroyed github diff view) and then second that fixes indentation. Just let me know!

Everything looks good to me. Can you add some docs about the newly created function though, please?

I have more ideas on how to improve the codebase, builds, bundle size, APIs etc but I don't know if it makes sense to start discussions, send PRs etc.

Don't hesitate to do so. I don't have much time lately but contributions are always welcome.

I've rebased the branch to fix the merge conflict and updated README

Thanks @d4rky-pl. I'll merge now.


Triggers created

Now you can create a Ghost objects that triggers the on collision enter / exit of the scripts of the 2 objects

The develop update was for having a real scene where I can test big scenarys


Fixed deprecation warnings on Rails 4

Hey! Good news, your gem still works on Rails 4 with MiniTest::Unit. There was only one slight issue: a deprecation warning about ActiveRecord::Fixtures class being deprecated. They recommend using FixtureSet instead and it works fine.

Ping.

@colszowka Ping.


update django_irods SHA reference for release 1.14 RC

@aphelionz This PR will update django_irods SHA reference for release 1.14 RC. Please review so that it can be merged.

Build finished.


Adapt onapp tests to the libcloud test framework

Instead of mocking the response manually the tests use MockHttpTestCase.

Thanks - merged into trunk :)


BZ1303534: GSS BxMS6.2.0 Full Text search returns only 10 results even if it hits more than 10

See https://bugzilla.redhat.com/show_bug.cgi?id=1303534
This is the corollary of https://github.com/droolsjbpm/guvnor/pull/277 for 6.3.x

Part of an ensemble:
https://github.com/uberfire/uberfire/pull/311
https://github.com/uberfire/uberfire-extensions/pull/231
https://github.com/droolsjbpm/guvnor/pull/278
https://github.com/droolsjbpm/kie-wb-common/pull/293
https://github.com/droolsjbpm/drools-wb/pull/140
https://github.com/droolsjbpm/kie-wb-distributions/pull/221
https://github.com/droolsjbpm/jbpm-console-ng/pull/361
https://github.com/droolsjbpm/jbpm-designer/pull/180

6.3.x: 321623c40db13d30bac2c5f8f3204e1a5f000667


[backport] new style squared_difference function

Backport of #3549.

jenkins, test this please.

LGTM!


add one pixel of horizontal padding

adding a pixel of horizontal padding significantly improving the look of web pages from phones.

Thank you @tonyaellie for your PR.
This Boilerplate needs a better mobile version.


Propagate TooManyRowsInAWindowFault error message properly to the user

Description
Currently, TooManyRowsInAWindowFault isn't propagated properly to the user. The user sees the following:

Instead, the user should see the proper error message defined in TooManyRowsInAWindowFault.java. The issue was that TooManyRowsInAWindowFault wasn't added to the list of fault classes in MSQIndexingModule.
With this PR's changes, TooManyRowsInAWindowFault's error message is propagated properly to the end user:

This PR has:

[x] been self-reviewed.
[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Please add this in the MSQFaultsSerdeTest as well

@LakshSingla Done


Add 17.06.1 release notes

Add release for 17.06.1 and refresh the CLI for stable and edge directories
cc/ @andrewhsu

@thaJeztah I'll look at what needs to change to vendor the dockerd reference instead of using the fake YAML. cc/ @johndmulhausen

@thaJeztah the swagger files are fetched at build time. It's still fetched from the 17.06 branch, so no change at this time. Unless there is yet another new API version for this?

Just pushed a commit that pulls the dockerd.md files from upstream.

@thaJeztah let me know when the fixes have been done upstream and I will amend the CLI commit to have the improved output.

@mstanleyjones feel free to merge before that, I'd have to find a spot to make the change (and change is only a minor typo)


Feature request: dry-run against all open PR's

I see danger local and danger pr in the docs, which look great.
We're evaluating danger and would like to be able to test new rules against historical PR's before committing them. It is okay if this is slow.
We're considering writing a wrapper script, like get-open-prs -n 100 | xargs bundle exec danger pr but would be great if this was built in.
It's also not clear from the docs whether danger pr will post a comment to the PR, or print out what it would do to the console (I desire the latter behavior).
There isn't documentation for the CLI on the website that I can find, but danger --help locally does not list a --dry option.

This seems related to https://github.com/danger/danger/issues/382 but I haven't read that thread thoroughly.

You could use danger pr and it wouldn't post a comment - that should work fine 👍
I'll ship a PR making the CLI more explicit about this
I'm not actively working on Danger Ruby (but I'm maintaining it), so the local deprecation isn't really going anywhere.

WRT a feature for trying your Dangerfile against all runs, I could see it working.
Maybe danger trial https://github.com/artsy/emission --count 10 and it would run through the same as bundle exec danger pr https://github.com/artsy/emission/pull/1, bundle exec danger pr https://github.com/artsy/emission/pull/2 etc?

Awesome, yeah danger trial <repo_url> --count sounds ✨ ✨  !


Update downstream projects to use the next release of eslint-config-liferay

Update:

[x] liferay-amd-loader (after: https://github.com/liferay/eslint-config-liferay/issues/20): https://github.com/liferay/liferay-amd-loader/pull/190, https://github.com/liferay/liferay-amd-loader/pull/192
[x] liferay-npm-build-tools (after: https://github.com/liferay/eslint-config-liferay/issues/19): https://github.com/liferay/liferay-npm-build-tools/pull/278, https://github.com/liferay/liferay-npm-build-tools/pull/280
[x] alloy-editor: https://github.com/liferay/alloy-editor/pull/1168, https://github.com/liferay/alloy-editor/pull/1169
[x] liferay-themes-sdk: https://github.com/liferay/liferay-themes-sdk/pull/181
[x] clay

to use the next release of eslint-config-liferay

@bryceosterhaus update his PR (https://github.com/liferay/clay/pull/1648) to include the new config, so I am going to close this one now.


Android - sendAuthRequest doesn't opens the app and return no response

wechat.openapp() open the app
but

wechat.sendAuthRequest('snsapi_userinfo', '123353452345');
#54

doesn't open the app and iam not getting any response from the api

WeChat.addListener('SendAuth.Resp', function(data) {
console.log(data);
if(data.errCode == 0) {
that.getWeChatAccessToken(data.code);
}
});

@rengasahusoft Did you have any logs after you was calling .sendAuthRequest?

@yorkie No i am not getting any response  can you show us one example

@yorkie   this is the log which we got in out logcat after clicking sendAuthRequest

I/ActivityManager(  942): START u0 {flg=0x18000000 cmp=com.tencent.mm/.plugin.base.stub.WXEntryActivity (has extras)} from uid 10179 on display 0
V/WindowManager(  942): ** SHOWING status bar: top is not fullscreen
V/WindowManager(  942): addAppToken: AppWindowToken{293ab792 token=Token{ba7191d ActivityRecord{15672df4 u0 com.tencent.mm/.plugin.base.stub.WXEntryActivity t1431}}} to stack=1 task=1431 at 0
D/WindowManager(  942): IKSWL-9411 focusChangedLw lastFocus=Window{231c65c7 u0 com.wechat/com.wechat.MainActivity} newFocus=null
V/WindowManager(  942): ** SHOWING status bar: top is not fullscreen
I/cr_LibraryLoader(16699): Time to load native libraries: 31 ms (timestamps 1828-1859)
I/cr_LibraryLoader(16699): Expected native library version number "51.0.2704.81", actual native library version number "51.0.2704.81"
W/ActivityManager(  942): getTasks: caller 10025 does not hold REAL_GET_TASKS; limiting output
D/WindowManager(  942): IKSWL-9411 focusChangedLw lastFocus=null newFocus=Window{231c65c7 u0 com.wechat/com.wechat.MainActivity}

+1 android doesn't work

Some news ?

Not yet unfortunately, sorry, I didn't have any real android device to debug with this, so may I ask to @Richard-Cao to chime into this issue something?

I’m here

Do you met the same problem there?

No. I don't use sendAuthRequest api. Only use share api.

I solved my problem.
my problem is android sign.

WeChat.sendAuthRequest('snsapi_userinfo') set scope as u see ,the problem will fixed.
and this is the offical demo:
{
// send oauth request
Final SendAuth.Req req = new SendAuth.Req();
req.scope = "snsapi_userinfo";
req.state = "wechat_sdk_demo_test";
api.sendReq(req);
}
scope	是	应用授权作用域，如获取用户个人信息则填写snsapi_userinfo（什么是授权域？）

@tofrookie can you elaborate on how exactly did you solve your problem. Thanks in advance!

i meet this problem, in android, can't open weixin to login, i have signed my app, any solution?

See https://github.com/weflex/react-native-wechat/issues/84#issuecomment-239384413

what is the sign as @tofrookie said? please show in detail.
I added the following:
WeChat.sendAuthRequest("snsapi_userinfo", "myclient_wx_login")
            .then((result)=>{
                console.log(result)
            })
            .catch((e)=>{
                console.error(e);
            })

I have the same problem ,i cannot open the App, should someone show the hole WXEntryActivity.java?

I have solved my problem ,just keep the package name and applicaionid the same, i don't know why i can't change the applicationid for different build purpose.

可以唤醒，但是无返回结果

我也是，可以唤醒！没有返回结果 ？

可以唤醒，但是无返回结果

8102年了，我依然碰到了这个问题，神奇的是这个 bug 居然被 closed 了...

can someone explain how to resolve the issue that wechat does not get opened? @sumyfly

我是解决了但是忘记是怎么解决了😹，代码也不在手里，印象里是微信的那个 code

I have solved my problem ,just keep the package name and applicaionid the same, i don't know why i can't change the applicationid for different build purpose.

maybe wx sdk find the EXEntryActivity by the applicationId

solution：

android signature: please user md5 code of keystore to register on wechat open platform, and remove the ":" and write in lowwer case of md5.
you may need writing WXEntryActivity in your project, and detail: https://juejin.im/entry/5b65baffe51d45348a3011b9

WeChat app wakes up, but no return results...
@onlybenyang @HyperSimon @ios-xxx @ww930912 Did you figure out something?

I have cross checked Application ID and bundle ID
Application signature: MD5 lower case with : removed
Still no luck

@shekhargupta Please check the whether WXEntryActivity created by yourself and the code

@onlybenyang thanks for your reply! The issue is resolved.
I have wrongly placed WXAPI package outside com.MYPROJECT package.


Update resinhup to v1.1.2

Update to the most recent resinhup tag which allows running on staging devices.

@resin-jenkins retest this please

I think this script is currently cached in proxy. @lekkas can you confirm? If is correct we will need to change it in proxy too.

@agherzan correct, run-resinhup.sh is vendored in the proxy and can be invoked with these arguments:

--allow-downgrades
--hostos-version
--staging

Note that the proxy only copies the run-resinhup.sh to the device. Does the new version depend on any scripts that are scpied by meta-resin/scripts/resinhup/run-resinhup-ssh.sh cc @agherzan @willnewton ?
Also, do we need to change the device range where the updated resinHUP script can be applied? (It's not clear from the context of this PR what the new range is, if it has changed)

@lekkas there are no new dependencies on scripts copied across but it seems to me like we should make run-resinhup-ssh.sh and the proxy behave in the same manner to make testing more tractable. What do you think @agherzan ?

@resin-jenkins retest this please

@resin-jenkins retest this please


HDFS-13677: Swap old replicas when reconfiguration Disk

BugFix for 13677HDFS-13677

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
877
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1463
trunk passed

+1
compile
66
trunk passed

+1
checkstyle
46
trunk passed

+1
mvnsite
69
trunk passed

+1
shadedclient
851
branch has no errors when building and testing our client artifacts.

+1
findbugs
127
trunk passed

+1
javadoc
51
trunk passed

_ Patch Compile Tests _

+1
mvninstall
58
the patch passed

+1
compile
53
the patch passed

+1
javac
53
the patch passed

-0
checkstyle
38
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 90 unchanged - 0 fixed = 91 total (was 90)

+1
mvnsite
60
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
794
patch has no errors when building and testing our client artifacts.

+1
findbugs
133
the patch passed

+1
javadoc
48
the patch passed

_ Other Tests _

-1
unit
4807
hadoop-hdfs in the patch failed.

+1
asflicense
53
The patch does not generate ASF License warnings.

9638

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestBPOfferService

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.web.TestWebHdfsTimeouts

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-780/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/780

JIRA Issue
HDFS-13677

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux<PHONE_NUMBER>a3 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 43b2a4b

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/2/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/2/testReport/

Max. process+thread count
3912 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
814
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1140
trunk passed

+1
compile
61
trunk passed

+1
checkstyle
44
trunk passed

+1
mvnsite
65
trunk passed

+1
shadedclient
836
branch has no errors when building and testing our client artifacts.

+1
findbugs
125
trunk passed

+1
javadoc
51
trunk passed

_ Patch Compile Tests _

+1
mvninstall
58
the patch passed

+1
compile
55
the patch passed

+1
javac
55
the patch passed

-0
checkstyle
41
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 90 unchanged - 0 fixed = 91 total (was 90)

+1
mvnsite
62
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
804
patch has no errors when building and testing our client artifacts.

+1
findbugs
131
the patch passed

+1
javadoc
48
the patch passed

_ Other Tests _

-1
unit
5714
hadoop-hdfs in the patch failed.

+1
asflicense
33
The patch does not generate ASF License warnings.

10121

Reason
Tests

Failed junit tests
hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.server.namenode.ha.TestHASafeMode

hadoop.hdfs.web.TestWebHdfsTimeouts

hadoop.hdfs.tools.TestDFSZKFailoverController

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-780/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/780

JIRA Issue
HDFS-13677

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux b0370166451e 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 43b2a4b

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/1/testReport/

Max. process+thread count
2810 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
23
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1048
trunk passed

+1
compile
56
trunk passed

+1
checkstyle
41
trunk passed

+1
mvnsite
64
trunk passed

+1
shadedclient
723
branch has no errors when building and testing our client artifacts.

+1
findbugs
120
trunk passed

+1
javadoc
55
trunk passed

_ Patch Compile Tests _

+1
mvninstall
61
the patch passed

+1
compile
51
the patch passed

+1
javac
51
the patch passed

+1
checkstyle
38
the patch passed

+1
mvnsite
58
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
709
patch has no errors when building and testing our client artifacts.

+1
findbugs
127
the patch passed

+1
javadoc
48
the patch passed

_ Other Tests _

-1
unit
4598
hadoop-hdfs in the patch failed.

+1
asflicense
37
The patch does not generate ASF License warnings.

7914

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.web.TestWebHdfsTimeouts

hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-780/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/780

JIRA Issue
HDFS-13677

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 3140035b8a9a 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 43b2a4b

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/3/testReport/

Max. process+thread count
3989 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
12
https://github.com/apache/hadoop/pull/780 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/780

JIRA Issue
HDFS-13677

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/4/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
11
https://github.com/apache/hadoop/pull/780 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/780

JIRA Issue
HDFS-13677

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/5/console

versions
git=2.17.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
12
https://github.com/apache/hadoop/pull/780 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/780

JIRA Issue
HDFS-13677

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/6/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
11
https://github.com/apache/hadoop/pull/780 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/780

JIRA Issue
HDFS-13677

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/7/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Close the PR because it was committed via the patch attached to the jira.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
17
https://github.com/apache/hadoop/pull/780 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/780

JIRA Issue
HDFS-13677

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-780/8/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Unable to access PPP on VPN

Genentech is unable to access PPP when using VPN.
The issue is restricted to Genentech and when working from home & not when accessing it from on site.

Added new list of IPs.


Adding Ajanth as a code owner

@ajanth97 has been a regular contributor - of code, reviews, issues and design - to this repository. This patch adds him as a code owner.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO)
[x] Any necessary documentation is added, such as:

README.md
The docs/ directory
The docs repo

Fixes #

thank you @arschles and @tomkerkhove


README.md: remove unneeded character from command line invocations

When using the copy button to copy the commands, '$' character will be copied too. Hence, remove it.

Thank you!


Rancher keeps installing old prometheus-operator 0.02 even when monitoring v1 is removed from cluster

Is your feature request related to a problem? Please describe.
I cannot uninstall v1 monitoring when I've already upgraded Rancher to 2.6.x. Rancher keeps forcing prometheus-operator-0.0.2 on downstream cluster and this conflicts with v2 monitoring
Describe the solution you'd like
Documentation/steps how to fully clean out v1 monitoring so that it will not come back. How to kill that Hydra!

Facing the same issue in 2.5.12.
v1 monitoring keeps reinstalling.

@herrbpl I think we ran into the same issue (if I understand your description correctly).
The following Rancher Forum thread helped us to resolve the issue: 15908


Update local-dev to build indexes dymamically instead of inside the prebuilt docker image

Currently anytime solr indexes are changed a new docker image has to be built.  The solr indexes are not a heavy lift and we should have the ability to update them dynamically just like hsctl. Update local-dev-first-start-only.sh to build the schema dynamically.  Once this is done the prebuilt image will be irrelevant and the repository may be removed.
https://github.com/hydroshare/hs-solr/
The other Docker images in local-dev.yml can likely be updated in a similar manner.

I think this will help normal mortals update SOLR.


generate new jobs for build01

Signed-off-by: Steve Kuznetsov<EMAIL_ADDRESS>

 tide Pending — Not mergeable. Needs lgtm label.

Go home, tide, you're drunk.


time difference inflected as before/after

I'd like to see a feature like the following:
>>> p.date_diff(datetime.timedelta(minutes=-30))
'00:30:00 before'
>>> p.date_diff(5)
'00:00:05 after'
>>> p.date_diff(0)
'at'

I would expect one to use the result to produce nice output for a time difference like:

Your flight departed 00:00:05 after its scheduled departure.

It would be nice if it accepted a time formatter such that it could alternately emit:
>>> p.date_diff(datetime.timedelta(minutes=-30), fmt=nice_time)
'30 minutes before'
>>> p.date_diff(5, fmt=nice_time)
'five seconds after'
>>> p.date_diff(0, fmt=nice_time)
'at'

Perhaps that inflection is too trivial for a library like inflect. Or perhaps there are nuances I haven't yet considered.

The timeago package will format a datetime object as a "X time ago" statement.
It might also be useful to be able to convert a timedelta, or time in seconds, to a natural language time string.
Cribbing StackOverflow, here's a simple converter from seconds to a natural time, but it might make more sense to base something around a timedelta object?
#https://stackoverflow.com/a/24542445/454773
intervals = (
    ('weeks', 604800),  # 60 * 60 * 24 * 7
    ('days', 86400),    # 60 * 60 * 24
    ('hours', 3600),    # 60 * 60
    ('minutes', 60),
    ('seconds', 1),
    )

def display_time(seconds, granularity=3, sep=',', andword='and'):
    """Take a time in seconds and return a sensible
        natural language interpretation of it."""
    def nl_join(l):
        if len(l)>2:
            return ', '.join(f'{l[:-1]} {andword} {str(l[-1])}')
        elif len(l)==2:
            return f' {andword} '.join(l)
        return l[0]

    result = []

    for name, count in intervals:
        value = seconds // count
        if value:
            seconds -= value * count
            if value == 1:
                name = name.rstrip('s')
            result.append("{} {}".format(value, name))

    return nl_join(result[:granularity])


Still can't run homebridge running on FreeBSD 11.1

I'm running in some problems compiling on FreeBSD.
root@fileserver:/usr/local/share/homebridge # npm install

><EMAIL_ADDRESS>install /usr/local/share/homebridge/node_modules/mdns
> node-gyp rebuild

gmake: Entering directory '/usr/local/share/homebridge/node_modules/mdns/build'
  CXX(target) Release/obj.target/dns_sd_bindings/src/dns_sd.o
In file included from ../src/dns_sd.cpp:1:
../src/mdns.hpp:32:10: fatal error: 'dns_sd.h' file not found
#include <dns_sd.h>
         ^~~~~~~~~~
1 error generated.
gmake: *** [dns_sd_bindings.target.mk:156: Release/obj.target/dns_sd_bindings/src/dns_sd.o] Error 1
gmake: Leaving directory '/usr/local/share/homebridge/node_modules/mdns/build'
gyp ERR! build error
gyp ERR! stack Error: `gmake` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)
gyp ERR! stack     at emitTwo (events.js:126:13)
gyp ERR! stack     at ChildProcess.emit (events.js:214:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System FreeBSD 11.1-RELEASE-p4
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /usr/local/share/homebridge/node_modules/mdns
gyp ERR! node -v v8.9.1
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2017-11-28T11_42_42_023Z-debug.log

root@fileserver:/usr/local/share/homebridge # node --version
v8.9.1

root@fileserver:/usr/local/share/homebridge # npm --version
5.4.2

root@fileserver:/usr/local/share/homebridge # pkg info|grep libdns
avahi-libdns-0.6.31_2          mDNSResponder compatibility from Avahi

root@fileserver:/usr/local/share/homebridge # locate dns_sd.h
/usr/local/include/avahi-compat-libdns_sd/dns_sd.h
/usr/ports/net/avahi-libdns/work/avahi-0.6.31/avahi-compat-libdns_sd/dns_sd.h
/usr/ports/net/avahi-libdns/work/stage/usr/local/include/avahi-compat-libdns_sd/dns_sd.h
root@fileserver:/usr/local/share/homebridge #

How to debug?
Best Regards,
Donald.

The instructions tell you to install node which is currently at version 9 and Homebridge does not appear to work with this version.
instead of the step 5 pkg install try this:
pkg install -y node4 www/npm-node4 dbus avahi-libdns gcc

I had to create a symlink from /usr/include to /usr/local/include/avahi-compat-libdns_sd to get it to build:
root@fileserver:/usr/include # ls -l dns_sd.h
lrwxr-xr-x  1 root  wheel  50 Nov 28 20:20 dns_sd.h -> /usr/local/include/avahi-compat-libdns_sd/dns_sd.h
root@fileserver:/usr/include #
Issue solved.


master:examples don't work with python3

2018-04-26
tested with python2 but got errors while python3 looks fine.
For a quick fix and to resolve ambiguity, the README file describing how to run examples in master should require be run with python3:
python3 transmission_main_example.py and
python3 transmission_main_example.py coronet_conus_example.json
are we running tests against such errors?
Note: classified as a bug since users trying to run examples but having only python2 installed will run into the issue which throws an error.

ggrammel-mbp:examples ggrammel$ python2 transmission_main_example.py
File "transmission_main_example.py", line 35
f'#{idx} Carrier(frequency={c.frequency},\n  power=Power(signal={c.power.signal}, nli={c.power.nli}, ase={c.power.ase}))'
^
SyntaxError: invalid syntax
ggrammel-mbp:examples ggrammel$ python3 transmission_main_example.py
invalid souce node specified: '', replaced with Transceiver Site_A
invalid destination node specified: '', replaced with Transceiver Site_B
There are 4 network elements between Transceiver Site_A and Transceiver Site_B
Transceiver Site_A
Fiber Span1
length (m): 80000.00
loss (dB):  16.00
Edfa Edfa1
type_variety:      std_low_gain
gain (dB):         16.00
noise figure (dB): 7.12
Power In (dBm):    3.83
Power Out (dBm):   19.83
Transceiver Site_B
OSNR ASE (1nm):        34.83
OSNR ASE (signal bw):  30.75
SNR total (signal bw): 27.36
ggrammel-mbp:examples ggrammel$

Python 2 is not supported. Not a bug.
Sent from my iPhone
On Apr 26, 2018, at 7:55 AM, Gert Grammel <notifications<EMAIL_ADDRESS>wrote:
2018-04-26
tested with python2 but got errors while python3 looks fine.
For a quick fix and to resolve ambiguity, the README file describing how to run examples in master should require be run with python3:
python3 transmission_main_example.py and
python3 transmission_main_example.py coronet_conus_example.json
are we running tests against such errors?
Note: classified as a bug since users trying to run examples but having only python2 installed will run into the issue which throws an error.

ggrammel-mbp:examples ggrammel$ python2 transmission_main_example.py
File "transmission_main_example.py", line 35
f'#{idx} Carrier(frequency={c.frequency},\n power=Power(signal={c.power.signal}, nli={c.power.nli}, ase={c.power.ase}))'
^
SyntaxError: invalid syntax
ggrammel-mbp:examples ggrammel$ python3 transmission_main_example.py
invalid souce node specified: '', replaced with Transceiver Site_A
invalid destination node specified: '', replaced with Transceiver Site_B
There are 4 network elements between Transceiver Site_A and Transceiver Site_B
Transceiver Site_A
Fiber Span1
length (m): 80000.00
loss (dB): 16.00
Edfa Edfa1
type_variety: std_low_gain
gain (dB): 16.00
noise figure (dB): 7.12
Power In (dBm): 3.83
Power Out (dBm): 19.83
Transceiver Site_B
OSNR ASE (1nm): 34.83
OSNR ASE (signal bw): 30.75
SNR total (signal bw): 27.36
ggrammel-mbp:examples ggrammel$
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Telecominfraproject/gnpy/issues/68, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AbyG7FEVf8Z1DB4thywLIBM2jhMFoLNAks5tsd-cgaJpZM4TlVtc.

If Python2 is not supported it should be documented in the Readme to make sure the the examples run fine.
So the bug is then in the Readme

This is detailed in the onboarding guide. Python 2 will not be supported.
https://mail.python.org/pipermail/python-dev/2018-March/152348.html

Many folks still have python2 installed. As discussed above, if Python2 is not supported, it shoud be stated in the Readme. We can add a warning to the README or make it explicit to use python3 in the examples, but the issue needs to be addressed.

Currently, this project is focussed on code development. This means moving faster at developing features by making a set of common assumptions:

that users know the difference between Python 2 and Python 3
that users are equipped to make code contributions in Python 3

that users will have Python 3 installed
that users understand virtual environments, how to install code via setup.py, and how this differs from pip installation
that users understand PYTHONPATH/PYTHONHOME and various details of how Python code is executed

If you want to include a "Quick Start Guide for Non-Coders," we can include that in the README. This can document common aspects of how Python works for non-coding users.
However, for non-coders (for folks for whom the above are not a given,) our Binder or Azure Notebook Service solution are the proposed workflows. These provide no-install, one-click access to our demos.
We should strongly guide non-technical users toward this solution so that we can focus our efforts on feature development and code quality improvement.
Feel free to submit a pull request with any additional README changes you would like. These will be reviewed via our normal code review process. Please ensure that the PR addresses a single issue to ease in review. There is no need to open a Github issue corresponding to each PR.

Keep in mind that individuals looking at the master branch are neither code contributors nor greenhorns who never touched a piece of code. If there is confusion about the target type of users for experiencing gnpy, feel free to reach out to the WG Chairs for guidance. A "Quick Start Guide for Non-Coders" might be a useful addition. It doesn't obviate the need for a workable README though. The latter aspect is tracked in https://github.com/Telecominfraproject/gnpy/issues/55


Add errorprone plugin

Moves the generated java sources into jaeger-generated gradle subproject and uses the errorprone compiler for all other subprojects.
Also fixes bugs reported by errorprone.
Fixes https://github.com/uber/jaeger-client-java/issues/56

ahh whoops. bad memory!


v1.0 vs v2.0

It's not clear in the listed samples which version to use to connect to the BC api.
Some samples list v1.0 vs v2.0 (first part of url) against v2.0 (in the last part of the url)
https://api.businesscentral.dynamics.com/**v2.0**//api/v2.0

Is it always v1.0 when you don't specify the environment?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9a5495f-193a-9ad6-490d-8bb5d0b2d709
Version Independent ID: 95da6841-b4a7-932c-de90-4b3b93bf8eea
Content: Endpoints for the APIs for Microsoft Dynamics NAV and Microsoft Dynamics 365 Business Central - Business Central
Content Source: dev-itpro/api-reference/v2.0/endpoints-apis-for-dynamics.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: solsen

Thanks for the feedback.
You should use v2.0 (in the first part). That enable access to named environments. With v1.0 you can only access the environment named "production" and "sandbox" if you include it in the URL.
I will update the doc page, as theres no reason to use v1.0.


Refreshing of tokens

Tries to refresh the token when logging in, using the AppAuth library, and also saves the CarpUser, which contains the token in the local settings, that is saved in local storage on the phone as JSON, instead of saving the username and access token individually.
And also updated the keycloak client.

Fixes #184


Pull workflow changes and read me fixes

Pull workflow changes and read me fixes.

This merge will overwrite extended test coverage. Hence should be discarded.