Right  off of  GitHub the  UnitTest Fail...

Just  cloned the  repo  to  brush up  on  CloudKit before WWDC22 and the  simple sharing app  does NOT  pass it's own  unit test... it won't  compile.  Oh-it hurts my heart  to point out such bad coding practices  are the norm at Apple I guess.
I come from the XP era of Don't Break The  Build!
func  tearDownWithError()...
...
async {
_ = try await database.modifyRecords(deleting: idsToDelete)   //[Missing argument for  parm 'saving']
func testCreatingShare() ...
...
let (share, _) = try await viewModel.createShare(contact: testContact)   //[Type of expression is  ambiguous without more context
I could be bold and assume this test meant  vm.fetchOrCreateShare() as  it's the only method that might match...
Please update the UnitTest.   Thank  you.

Hi David, the main branch has been updated with the async version of this sample project and the tests have been updated with it. This should have fixed the issue you were seeing, but feel free to re-open this issue if you still see this behavior. Note that for this project's tests to pass, the device or simulator you run the tests on will need to be logged into an iCloud account.


1.2.18 Still causing PPV strconv issues.

I'm still getting this error, even on 1.2.18, linked to this issue: https://github.com/Threadfin/Threadfin/issues/451
2024/11/18 16:10:04 [Threadfin] [ERROR] strconv.Atoi: parsing "threadfin-61d23372fc4209fda23021e89d5a2756": invalid syntax () - EC: 0
2024/11/18 16:10:04 [Threadfin] Create Dummy Guide:     Time offset -0700 - ESPN Plus 017
2024/11/18 16:10:04 [Threadfin] [ERROR] strconv.Atoi: parsing "threadfin-61d23372fc4209fda23021e89d5a2756": invalid syntax () - EC: 0
2024/11/18 16:10:04 [Threadfin] Create Dummy Guide:     Time offset -0700 - PPV 04: UFC 309 Jones v Miocic Main Card (11.16 10:00PM ET)
2024/11/18 16:10:04 [Threadfin] [ERROR] strconv.Atoi: parsing "threadfin-bc03fb9e224b42a0b6916c1a0d5ac937": invalid syntax () - EC: 0
2024/11/18 16:10:04 [Threadfin] Create Dummy Guide:     Time offset -0700 - PPV 07: Ramirez v Smith (11.16 5:30PM ET)
2024/11/18 16:10:04 [Threadfin] [ERROR] strconv.Atoi: parsing "threadfin-bc03fb9e224b42a0b6916c1a0d5ac937": invalid syntax () - EC: 0
and here's the version header from the logs:
For help run: /home/threadfin/bin/threadfin -h
2024/11/18 16:04:28 [Threadfin] [WARNING] Don't run this as Root!
2024/11/18 16:04:28 [Threadfin] Version:                1.2 Build: 18
2024/11/18 16:04:28 [Threadfin] Database Version:       0.5.0
2024/11/18 16:04:28 [Threadfin] System IP Addresses:    IPv4: 9 | IPv6: 11
2024/11/18 16:04:28 [Threadfin] Hostname:               {masked}
2024/11/18 16:04:28 [Threadfin] System Folder:          /data/conf/
2024/11/18 16:04:28 [Threadfin] Load Settings:          /data/conf/settings.json
2024/11/18 16:04:28 [Threadfin] Temporary Folder:       /tmp/threadfin/{masked}
2024/11/18 16:04:28 [Threadfin] GitHub:                 https://github.com/Threadfin
2024/11/18 16:04:28 [Threadfin] Git Branch:             Main [Threadfin]
2024/11/18 16:04:28 [Threadfin] SSDP / DLNA:            true
2024/11/18 16:04:28 BRANCH:  Main
2024/11/18 16:04:28 TAG LATEST:  1.2.18
2024/11/18 16:04:28 FILE:  https://github.com/Threadfin/Threadfin/releases/download/1.2.18/Threadfin_linux_amd64
2024/11/18 16:04:28 [Threadfin] UUID:                  {masked}
2024/11/18 16:04:28 [Threadfin] Tuner (Plex / Emby):    2
2024/11/18 16:04:28 [Threadfin] EPG Source:             XEPG
2024/11/18 16:04:28 [Threadfin] Plex Channel Limit:     480
2024/11/18 16:04:28 [Threadfin] Unfiltered Chan. Limit: 480
2024/11/18 16:04:28 [Threadfin] Backup Path:            /data/conf/backup/
2024/11/18 16:09:45 [Threadfin] Backup file:            /data/conf/backup/threadfin_auto_backup_20241118_1604.zip
Originally posted by @lephino in https://github.com/Threadfin/Threadfin/issues/451#issuecomment-2484338311

Is the filter marked as live event?

No not ignore Filters. You're using it wrong so that's why it's broken. Use discord please


Add more logs

Adding missing logs and expanding existing ones.

tests passing, only code coverage is failing and it was failing before. Didn't have time to check it out previously


Add annotations to the state json

Closes: #480
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

On Thu, Jun 02, 2016 at 01:25:37PM -0700, Doug Davis wrote:

Add annotations to the state json

For previous work in this direction, see #188 (which was about adding
runtime-specified annotations to the state).  I think that was closed
prematurely after the config-author-specified annotations landed in
#331 1.  Is there still interest in the runtime-specified
annotations use-case that lead to #188?  For example, runC apparently
injects a ‘bundle’ field into annotations to get it into the state
JSON 2.
When I suggested including config-author-specified content in the
state 3, @gao-feng pointed out that you could retrieve that
information via bundlePath 4.  If that route to the annotations is
not acceptable, should we just copy the whole config.json into the
state JSON 5?  If not, how do we pick and choose what gets copied
over?

LGTM

While this looks fine, we need to be clear about what we copy from the configuration to the state as it is essentially redundant.

@mrunalp yes,  Since annotations are more user defined "labels" for a container not part of the configuration that create the container and its settings it makes since for something like this to be added to the state allow it to be a queried

@crosbymichael They could also potentially be used to implement extensions that aren't yet in the spec.

@mrunalp yep, its something for external tooling, the runtime will just passthough and take no actions on the values.

I am fine merging for now and we could maybe revisit if we see a need to move other values into the state. Thanks!

LGTM


[WIP] Container infrastructure

To simplify debugging and provision of the code in this repo, this PR contains a Dockerfile along with some updates to conda dependencies. Right now, the user would still need to provide an OpenEye license (until #342 is resolved) to use most of the code. Marked WIP because I need to make sure this actually builds correctly (it did before, but without the required dependencies that I've now added).

@pgrinaway : Installation of the openeye tools can now be done with:
conda install -c openeye openeye-toolkits

No need to add the openeye channel or install via pip. See more here.

@pgrinaway : If you're using the CUDA 9 image, you'll want to pin openmm to be >=7.2.0

: Installation of the openeye tools can now be done with:

Well, I wanted to add it as a dependency in the meta.yaml so that it is automatically installed. Presumably the channel needs to be added for that to happen?

Presumably the channel needs to be added for that to happen?

Ah, yes, sorry!

@pgrinaway : If you're using the CUDA 9 image, you'll want to pin openmm to be >=7.2.0

Ok, got it.

Making sure dockerhub can build this, then removing the -b  option from the git clone and merging.

Ok, the dockerhub build succeeded, merging.


adding awesome-startup

Thanks for the suggestion. :smiley:
Please have a quick read through of the instructions for creating/adding a new list.
Could you add contributing guidelines? Also some of the links need an explanation why they are awesome e.g. Startup Notes should have a description next to it stating what's in the book and why it's useful.
Also, there are some styling issues with the list:

some table of contents links don't work
some headers use colons at the end, some don't
some links are in caps (Y COMBINATOR STARTUP CLASS)

Once the changes have been made I can reopen this, just let me know here. :raised_hands:


⚠ ClamAV has degraded performance

In 448e8d6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in 5798a51.


Allowed labels for cronjobs, jobs, and changelog.

closes https://github.com/giantswarm/giantswarm/issues/28422

Hey @Strigix have you tested it ?

Not yet.
To be honest, I wasn't sure how.
The newest observe bundle hasn't got this version yet. Can I just edit the version of prometheus-operator-app?
I was unsure because it was pushed to the catalog as kube-prometheus-stack-app.
What would work best do you reckon?

Well i'm in a pickle. Is that for MCs or WCs as well?

Oh, that was quite the late answer.
I believe this is mostly for MC's.

Then I would suggest you add it here https://github.com/giantswarm/config/blob/main/default/apps/observability-bundle/configmap-values.yaml.template instead like https://github.com/giantswarm/config/compare/main...Add-job-and-cronjob-labels?quick_pull=1

Maybe we still need this here :)


Install gdb in the Intel containers

The Intel containers do not have gdb installed. This is problematic because we cannot debug.
I've hit a situation in JCSDA/ioda-engines#76 where I am encountering a segfault that only occurs inside the Intel containers.

What container are you using?  If Docker or Singularity you can install gdb yourself for debugging.  I'd have to check for Charliecloud.

I'm not sure why it's not there - intel PS comes with it and it wasn't deliberately removed.  It will take some investigation next week.  But, as I said, if you use docker or singularity you can install the gnu version on your own for debugging purposes.  Let me know which you want to work with and I can give you further info.

Unfortunately, Charliecloud.
I'll spin up a Docker container in the meantime.

Strange - I had mentioned before about a bug in the install of intel 19/20 parallel studio  where it was ignoring the component list.  Apparently it's not completely ignoring it.  This is fixed - I'm just regenerating the containers now - will be done within the hour.

@rhoneyager - Ok, the latest intel 19 docker, singularity, and charliecloud containers on AWS S3 should be updated with the the intel version of gdb, gdb-ia.   I have not tested these yet - please let me know if you notice a problem.  @mer-a-o - there is no need to change the container on AWS for CI because the only change should be this, which is not needed for CI.


fix long scroll bar issue which caused by huge raw data.

When there is a huge raw data, the scroll bar will be a disaster. Trying to fix it.

BTW. Really an awesome project. Thanks for your work on this project and open source it. :+1:


docs: update readmes

Pulls over the below commits from core

@ColinBuyck Great q! I'm wondering if Doorway will want input about how we phrase it - lemme poke Sarah and can followup if that works!


Not working since upgrade to Atom 1.3

Since Atom upgraded to 1.3, Atom is not setting the tab width to 4 spaces anymore.
Or it does, but then it switches back. When closing and re-opening Atom, you can clearly see every tab being 2 spaces wide, switching to 4 spaces for half a second, and switching back to 2 spaces again.
It looks like something else is overruling the atom-editorconfig package.
Anyone else experiencing this since Atom 1.3?
  Atom 1.30.0.

Hi @mjlehrke - thanks for reporting this.

I am seeing this as well with 1.31.1 on Ubuntu Bionic, Editor config kicks in briefly for opened files but always reverts to the Atom defaults after a few seconds.

Have two project
project A: php and it is a git repo
project B: php and it is not git repo
In project A editorconfig works, in projectB  it does not work.
In the developers tools I noted a error about missing git repo in project B. That's the moment I run git init, reopen the current document.  And all is working now.
So the workaround around is: make the project directory a git repo.
And yes I know, its not always possible to make a directory a git repo. Let's op the fix will be created soon.
HTH

So the workaround around is: make the project directory a git repo.

It's really odd this is happening only for non-Git projects. I'm guessing the activation of a Git-related core package triggered a refresh of open editors at startup.
Anyway, the fix I've applied in 304836a isn't perfect... the flickering is still visible, but at least it settles with the correct properties applied. If anybody's still experiencing this issue, please let me know.


Story Outline

Description
This feature encompasses the initial stages of the game, from setting the tone with a captivating introduction to the challenges faced during Level 1 on the planet Verdant Haven. Players will be introduced to the post-apocalyptic world, interaction with different characters, gather resources, and build a foundation for their interstellar journey.
Examples
As the player embarks, they'll experience a blend of storytelling, interactive dialogues, and resource management. The introduction sets the stage for the challenges ahead, while the following stages immerse players in a struggle for survival on an alien planet.
Dependencies

None

Milestones

[x] Design and implement a captivating introduction sequence
[x] Communication between different characters
[x] Establish dialogues with NPCs

Completion Deadline: Aug. 31
Extras (optional)

[x] Beautifying the Main Menu screen
[x] Beautifying the Settings Screen
[x] Changing the overall game UI

Documentation

Story Outline
Botanist NPC Documentation
Story Screen Implementation documentation
Main Menu and Setting Menu Display
User Interface Change wiki
TitleBox Implementation Documentation

Members

Name (GitHub Username) (Slack Handle)
Yash Mittal (@YashMitttal} (s4823869)
Rachit Chaurasia (@rachitchaurasia) (s4823870)
Dev Gupta (@DRG31) (xdrgx)
Aniket Gupta (@aniketgupta17) (s4824063)
Jival Kapoor (@JivalX) (s4824576)

Sprint 1 Milestones Achieved!


expose as ES6 in addition to UMD

Added a build step to build ES6 output in addition to UMD style output. The effect is that webpack based tools can now treeshake the component.
Checklist

[x] npm test passes (tip: npm run lint-fix can correct most style issues)
[ ] tests are included
[ ] documentation is changed or added

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Example of the effect of the es6 compile for an application that only contains this snippet (https://github.com/CarstenLeue/node-sdk-core-tree-shaking):
import { getAuthenticatorFromEnvironment } from 'ibm-cloud-sdk-core';

const auth = getAuthenticatorFromEnvironment('SECRETS_MANAGER_API');
console.log('auth', auth);

with tree shaking:

without tree shaking (i.e. before this PR):

Notice that the tree-shaken version does no longer contain the expect, jest and babel dependencies.
Both versions are still pretty large, but this is a consequence of using the mime-types and tough-cookie dependencies. If you are interested in providing a compact layer, you might want to revisit these dependencies.

@dpopp07 when building the ibm-cloud-sdk-core via npm run all I notice that the dist folder is populated but there is no package.json inside that dist folder. Maybe this gets added via the final publish step.
It's important that in the package.json that finally gets published you find the module and sideEffects entry (https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free)

@CarstenLeue I would support being more explicit in adding the package.json to the dist folder if you want. You could add a copy step to the build step, we've done this in other packages where we needed to be more explicit, e.g.
"build": "tsc && cp package.json dist/",

@dpopp07 sure. I have added a step to copy the package.json into the dist folder. I am not using cp since that does not work cross platform. Also I am removing the sections from the copied package.json that should not be published anyway.

@CarstenLeue is there anything we need to do manually to support the new documentation related additions in this PR?

@CarstenLeue is there anything we need to do manually to support the new documentation related additions in this PR?

@dpopp07 maybe not manually but there should be a step in the automation that publishes the npm package. This step should also write the generated doc files to the gh-pages branch, e.g. like so https://docs.travis-ci.com/user/deployment/pages/
But I am lacking information how the actual build integration is working

:tada: This PR is included in version 2.17.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


bitwig-studio: fix crash when creating user color palette via importing a JPEG image

Description of changes
Bitwig Studio has a hidden little feature to generate a color palette for your clips from an image. You can see an example of the feature in this timestamped video: https://youtu.be/GT0sX61LcMI?t=31
Only PNG and JPEG files are supported when choosing an image. Upon testing this out, I noticed that while PNGs worked fine, JPEGs caused Bitwig Studio to crash with the following traceback:

traceback
[2022-11-19 02:24:04.174 notifications info] Update Available - v4.4.3: A new release of Bitwig Studio is available.
(Your upgrade plan includes this version.)
[2022-11-19 02:24:26.377 float-main-app fatal] Application crashing in subsystem GUI Event Thread:
        java.lang.UnsatisfiedLinkError: /nix/store/4n8313q7knq82j86wl89sk49qadkfm1b-bitwig-studio-4.4.2/libexec/lib/jre/lib/libjavajpeg.so: libjpeg.so.8: cannot open shared object file: No such file or directory
        at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)
        at java.base/jdk.internal.loader.NativeLibraries$NativeLibraryImpl.open(Unknown Source)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(Unknown Source)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(Unknown Source)
        at java.base/jdk.internal.loader.NativeLibraries.findFromPaths(Unknown Source)
        at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(Unknown Source)
        at java.base/java.lang.ClassLoader.loadLibrary(Unknown Source)
        at java.base/java.lang.Runtime.loadLibrary0(Unknown Source)
        at java.base/java.lang.System.loadLibrary(Unknown Source)
        at java.desktop/com.sun.imageio.plugins.jpeg.JPEGImageReader$1.run(Unknown Source)
        at java.desktop/com.sun.imageio.plugins.jpeg.JPEGImageReader$1.run(Unknown Source)
        at java.base/java.security.AccessController.doPrivileged(Unknown Source)
        at java.desktop/com.sun.imageio.plugins.jpeg.JPEGImageReader.initStatic(Unknown Source)
        at java.desktop/com.sun.imageio.plugins.jpeg.JPEGImageReader.<clinit>(Unknown Source)
        at java.desktop/com.sun.imageio.plugins.jpeg.JPEGImageReaderSpi.createReaderInstance(Unknown Source)
        at java.desktop/javax.imageio.spi.ImageReaderSpi.createReaderInstance(Unknown Source)
        at java.desktop/javax.imageio.ImageIO$ImageReaderIterator.next(Unknown Source)
        at java.desktop/javax.imageio.ImageIO$ImageReaderIterator.next(Unknown Source)
        at java.desktop/javax.imageio.ImageIO.read(Unknown Source)
        at java.desktop/javax.imageio.ImageIO.read(Unknown Source)
        at bKW.jdu(SourceFile:269)
        at bKW.Das(SourceFile:256)
        at bKX.f1U(SourceFile:102)
        at bKX.CuJ(SourceFile:85)
        at bKW.jdu(SourceFile:194)
        at com.bitwig.windowing_system.wzo.ejI(SourceFile:273)
        at com.bitwig.windowing_system.wzo.Das(SourceFile:263)
        at com.bitwig.x11_windowing_system.X11FileDialog.jdu(SourceFile:23)
        at com.bitwig.x11_windowing_system.ltD.run(SourceFile:248)
        at dAU.run(SourceFile:25)
        at cCu.jdu(SourceFile:1072)
        at com.bitwig.flt.app.Jrg.jdu(SourceFile:2384)
        at cCu.wCf(SourceFile:1038)
        at cCu.Das(SourceFile:992)
        at com.bitwig.flt.app.kbj.Das(SourceFile:1996)
        at cCu.rEx(SourceFile:720)
        at com.bitwig.flt.app.BitwigStudioMain.main(SourceFile:206)

Child process with PID 1600879 exited with error code: 1

Mainly, it is looking for libjpeg.so.8. This PR adds a dependency and buildInput on libjpeg and sets the argument enableJpeg8 to true, which builds libjpeg with ABI support for libjpeg8.
Testing the generation of a color palette from a JPEG in Bitwig Studio now works!
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Recommended to review commit-by-commit. I took the liberty of organising the list of imports and buildInputs in separate commits.

Hi there. Is this waiting on anything else?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1640


Initial Integration of node-shell - iohk-monitoring.

Initial try to integrate node-shell with iohk-monitoring.

Is this a WIP?

No. It is just a first try,

it references our main branch at version 0.1.0;
this can already be used in your testing.

I see. I need to split this up then. Tell me when you think it's ready for a review, I'll tag it as WIP for now.

thanks @ksaric , we will expand on it more and then submit another PR.

bors +r


Simplify various parts of code, open possibility for more request handling

I think I managed to simplify the way various parts were written. I made small API changes, such as to fetch and removing fetchTraverse; especially the way fetch was written, it gave too much freedom to the user while not providing extra expressiveness while being too heavy-handed in exception handling.
I have pulled in async package for race, and maybe there are few more places we should be using it: I hope that's OK; these things are quite tricky to implement correctly in presence of exceptions.
Each individual comment should have relevant description, please have a look. If we don't like some changes, I'm of course open to discussion.

@Fuuzetsu Can you take a look at https://github.com/tsurucapital/franz/pull/3/files ? These changes are needed to keep compatibility

@Fuuzetsu Can you take a look at https://github.com/tsurucapital/franz/pull/3/files ? These changes are needed to keep compatibility

I saw it but didn't have time to look into the full new changes in full. If you just want the compatibility bit from it in a rush, I'm happy to revert that (no-longer-used) bit onto this branch. Sorry for being slow.

I have added the commit that brings back the old version of the protocol while changing nothing else. You should be able to use it as-is now. w.r.t. https://github.com/tsurucapital/franz/pull/3 , I think you can rebase it at some point and I'll look at it eventually.. Let me know if you'd rather I hurry.

I force-pushed "carter operator" to "caret operator" commit message change, nothing else. Will merge.


SelectedDrawingsOnList Component

I've created a script that creates dimensions for a simple single-part drawing, but one that Tekla itself cannot handle properly. When I use "Active drawing" component as a component that indicates which drawing is to be edited, everything works as intended. However, due to the fact that I've got hundreds of drawings to edit, I've tried using "Selected Drawings on List" component to speed things up. It does create some dimensions to correct points, however their location is all over the place. The location of dimension line is define relative to the part - for example: horizontal dimension is located at an extreme y coordinate of a part + some fixed value (let's say 200). As far as dimensions create, the script gives an error on the output - dimension line component - "Object reference not set to an instance of an object", while not printing any error "in the middle". If it's helpful for you to have a .gh file, hit me up and I'll share it.

Hi! Thanks for creating this issue. This is related to the same as Issue 8.
You want to manipulate multiple drawings at once. Quite a typical need, but it is hard to achieve due to the directed acyclic graph nature of the Grasshopper combined with the single-active-drawing policy in Tekla Open API.
Grasshopper is calculating nodes one by one. It does it for all of the inputs, so insertion of the drawing lines would be performed in multiple drawings at once. This is against the Tekla way of working with drawings, where every drawing is treated like a separate database.
This is a recurring problem, quite irritating for me as a software developer, where the loop concept is the standard one. In the GH world, you could try to use Anemone . Or wait ~3 months until I will release third version of Drawing Link with the main goal set to resolve looping over multiple drawings. Stay tuned!

Thanks for the answer, that's a great news! I'll keep my fingers crossed so you manage to sort out this issue. You're doing a great job, I appreciate your efforts!

Hi @Adam-Bednarek, a little late but you can try Drawing Link's foreach loop implementation based on the script:
samples/Samples.gh
More details can be found in issue:
https://github.com/LetsConstructIT/Grasshopper-TeklaDrawingLink/issues/37#issuecomment-2132225036


[INFRA-7527] Order checks by failing (sub-ordered by importance), then passing, then disabled

Minor UX improvement.

trigger build


Cannot normalize nothing on docker build

When trying to build the docker image I get the following error at stage 24 :
Sending build context to Docker daemon  1.797MB
Step 1/26 : ARG CODE_ROOT=/app
Step 2/26 : ARG ONETIME_HOME=/opt/onetime
Step 3/26 : FROM ruby:3.2-slim-bookworm AS builder
 ---> eb85b3c48fbe
Step 4/26 : ARG PACKAGES="build-essential autoconf m4 sudo"
 ---> Using cache
 ---> a0b9db534d09
Step 5/26 : RUN set -eux &&     apt-get update &&     apt-get install -y $PACKAGES
 ---> Using cache
 ---> 0d949a7e1fcc
Step 6/26 : RUN gem update --system
 ---> Using cache
 ---> da5ba5447853
Step 7/26 : RUN gem install bundler
 ---> Using cache
 ---> 6e23b316d9c9
Step 8/26 : COPY ./bin/entrypoint.sh .
 ---> Using cache
 ---> 4254a931dcf0
Step 9/26 : FROM builder AS container
 ---> 4254a931dcf0
Step 10/26 : ARG CODE_ROOT
 ---> Using cache
 ---> c17369de21fd
Step 11/26 : ARG ONETIME_HOME
 ---> Using cache
 ---> d5ba26659f78
Step 12/26 : LABEL Name=onetimesecret Version=0.13.0
 ---> Using cache
 ---> f589f189ea12
Step 13/26 : ARG PACKAGES="curl netcat-openbsd vim-tiny less redis-tools"
 ---> Using cache
 ---> 64c94b9d3bac
Step 14/26 : RUN set -eux &&     apt-get update &&     apt-get install -y $PACKAGES
 ---> Using cache
 ---> 3a5121079f31
Step 15/26 : RUN echo "Creating directories"
 ---> Using cache
 ---> 0e3e955c9ec1
Step 16/26 : RUN mkdir -p "$CODE_ROOT"
 ---> Using cache
 ---> 6f3006e378db
Step 17/26 : RUN mkdir -p "$ONETIME_HOME/{log,tmp}"
 ---> Using cache
 ---><PHONE_NUMBER>d3
Step 18/26 : WORKDIR $CODE_ROOT
 ---> Using cache
 ---> 23cb3919734f
Step 19/26 : COPY Gemfile ./
 ---> Using cache
 ---> 588baa3b0776
Step 20/26 : RUN bundle install
 ---> Using cache
 ---> 51c625987294
Step 21/26 : RUN bundle update --bundler
 ---> Using cache
 ---> f66c3a3de6ea
Step 22/26 : FROM container
 ---> f66c3a3de6ea
Step 23/26 : ENV RUBY_YJIT_ENABLE=1
 ---> Using cache
 ---> 2f08c2b38d76
Step 24/26 : WORKDIR $CODE_ROOT
cannot normalize nothing

The last line being the most important : cannot normalize nothing.
Steps to reproduce :

Clone the repository
Navigate into the onetimesecretfolder with cd onetimesecret
Run the build with docker build -t onetimesecret .

Looks like it's related to the CODE_ROOT ARG. According to the docs, it shouldn't be available after FROM container b/c it's not declared again.
https://docs.docker.com/reference/dockerfile/#understand-how-arg-and-from-interact
I don't see this error locally and we're not getting it in the github action builds. That would indicate some versions of docker behave differently in this scenario.
@dimensi0n Can you:

Try adding ARG CODE_ROOT on the line right after FROM container and building again. If that works for you, I'll update the Dockerfile (if it doesn't I'll need to investigate further).
Share the output from running docker version.

docker version on my local dev machine
$ docker version
Client:
 Cloud integration: v1.0.35+desktop.10
 Version:           25.0.1
 API version:       1.44
 Go version:        go1.21.6
 Git commit:        29cf629
 Built:             Tue Jan 23 23:06:12 2024
 OS/Arch:           darwin/arm64
 Context:           desktop-linux

Server: Docker Desktop 4.27.0 (135262)
 Engine:
  Version:          25.0.1
  API version:      1.44 (minimum version 1.24)
  Go version:       go1.21.6
  Git commit:       71fa3ab
  Built:            Tue Jan 23 23:09:35 2024
  OS/Arch:          linux/arm64
  Experimental:     false
 containerd:
  Version:          1.6.27
  GitCommit:        a1496014c916f9e62104b33d1bb5bd03b0858e59
 runc:
  Version:          1.1.11
  GitCommit:        v1.1.11-0-g4bccb38
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

@FredRa Can you try building from branch 328-cannot-normalize-nothing-on-docker-build.
$ git fetch
$ git checkout 328-cannot-normalize-nothing-on-docker-build
$ docker build -t onetimesecret .

It should be a simple fix. I just can't replicate it locally myself.

Great, thanks a lot!


feat: extend DB structure for event delivery and migration support

After some thought yesterday I decided to go for two separate tables for the event and report dead letter channels, as this resulted in a cleaner design.
The next step will be migrating DEAD_LETTER_CHANNEL to REPORT_DEAD_LETTER_CHANNEL. My naive approach is a conditional table rename, but do you have any pointers as to where in the application code it is best to add this logic?

Went for separate tables for events and aggregate reports.

renaming DEAD_LETTER_CHANNEL to REPORT_DEAD_LETTER_CHANNEL  and SUCCESS_LOG to REPORT_SUCCESS_LOG. updated README to reflect these changes.
Simple migration support: Rename table to REPORT_DEAD_LETTER_CHANNEL if DEAD_LETTER_CHANNEL table exists in the db.
add EVENT_DEAD_LETTER_CHANNEL and EVENT_SUCCESS_LOG.

Did some minor changes to the table renaming for postgreSQL to fix some build issues. Should be ready to merge.


Render pure anchor page links. Resolves gollum#1236

Issue: https://github.com/gollum/gollum/issues/1236
This PR resolves the issue by catching the anchor-only edge case in the tag filter. Additionally, an exception had to be made to the sanitization rules: the sanitizer currently prefixes 'wiki-' to all href elements that start with '#'. I think this is in order for gollum's css to apply to elements generated in the filter chain, and the exception should thus not pose a security risk -- but please see if that makes sense.
Flow control was a little complicated, so please let me know if you see better options.

See my comment in the main conversation about this.

@bartkamphorst did I miss this comment? Or was this just about adding internal anchor to the CSS? Another way to go would be to rename the class to internal page (as in, the link target is internal to the wiki, and to be more precise, it's on the same page).

I've tried playing around with the CSS to get the desired results when using the class internal anchor, but I can't figure it out. The classes are cumulative, so I can't easily negate the results of the anchor class is a neat way (I can set every property that's set in the anchor class to it's default for normal links, but that doesn't feel very clean). What shall we do?

I can set every property that's set in the anchor class to it's default for normal links, but that doesn't feel very clean

Overriding the parent class is the standard way to do this though. However, looking at it again, I've changed my mind and think internal-anchor works! So leave it as is. 😌

As an alternative, you could also use internal anchorlink.

Remaining test failure seems to be due to the placing of href and id attributes being reversed in nokogiri on the latest jruby on Travis. Not sure how we can make the test more lenient.


Adding uBeac's component library

There were an issue with the preview deployment, which have been solved.
Can you rebase your branch ?


Fix: handle SecurityError around window.sessionStorage

Changes

Updates web-storage-proxy to fallback to an object literal for storage if cookies aren't available.

Testing

Go to Preferences > Show Advanced Settings > Privacy > Content settings... > Cookies and disable them:

Go to beta.consumerfinance.gov and open the console. Note SecurityError with web storage and beta banner does not work.
Go to this PR and open localhost.
Note that beta banner works, but on reload does not remember its state.

Review

@sebworks
@KimberlyMunoz
@jimmynotjim

Part of DFJR-1095

This looks good to me.


soc: nordic: common: mram_latency: Add option to auto request no latency

Add CONFIG_MRAM_LATENCY_AUTO_REQ. When option is enabled then module requests no latency during the initialization. This option might be useful for cases where we want to achieve maximum performance and want to avoid controlling MRAM in the code.
Extension to #81381.

@masz-nordic, @anangl can you take a look?


"Not found any '*.sln' file."

I get the above whenever I run a fakesharper command. There is no sln file in my workspace only csproj files
Any way around this? Not a fan of sln files if I can get away with it

I am taking this issue

I got same error when I try to run it in a Angular component file.

+1
i could not find any info on creating .sln files


HBASE-28949 Remove the netty 3 dependency management section

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 26s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 13s

master passed

+1 :green_heart:
compile
7m 59s

master passed

+1 :green_heart:
spotless
0m 47s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  7s

the patch passed

+1 :green_heart:
compile
8m  2s

the patch passed

+1 :green_heart:
javac
8m  2s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
xmllint
0m  0s

No new issues.

+1 :green_heart:
hadoopcheck
12m 13s

Patch does not cause any errors with Hadoop 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 48s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 12s

The patch does not generate ASF License warnings.

44m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6460/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6460

Optional Tests
dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile

uname
Linux 67f2cd77eb81 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 22cff9ded251be901067e2bf64ae73354cf766cd

Default Java
Eclipse Adoptium-17.0.11+9

Max. process+thread count
192 (vs. ulimit of 30000)

modules
C: . U: .

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
2m  6s

the patch passed

+1 :green_heart:
javac
2m  6s

the patch passed

+1 :green_heart:
javadoc
2m  5s

the patch passed

+1 :green_heart:
shadedjars
5m 19s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
254m 20s
/patch-unit-root.txt
root in the patch failed.

285m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6460/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6460

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux dc3402430242 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 22cff9ded251be901067e2bf64ae73354cf766cd

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6460/1/testReport/

Max. process+thread count
6004 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6460/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Merge Container-Stack

Merging in the container stack config.  Config is in /sca/container-stack

AB#42932


How to use CKeditor

Help me use CKeditor plugin. thanks all

@bmaland @erichard @jjtykkyl  help me check issue

For using smileys you need to make sure, you database supports it.

help me add plugin editer (CkEditer or Summernote)


setFilters method no longer working in v1.1.1

When trying to add nodes to a WebAudio graph using the setFilters method in version 1.1.1, I get the following error:

Uncaught TypeError: Failed to execute 'connect' on 'AudioNode': No function was found that matched the signature provided.

The error is in reference to this line of the setFilters method, which was changed in PR#689.
I'm not doing anything fancy - just mixing three separate mono waveforms into stereo, with one of them panned center and the others panned left and right. The relevant code for one of them (called waveLeft) looks like this:
var centerGain = 0.3;

var pannerLeft = waveLeft.backend.ac.createStereoPanner();
pannerLeft.pan.value = -1;

var gainL = waveLeft.backend.ac.createGain();
gainL.gain.value = 1 - centerGain;

waveLeft.backend.setFilters([pannerLeft, gainL]);

It was still working as of v1.1.0:
http://fiddle.jshell.net/nathansnider/qqtjko16/
but produces the error (and does not add any panner and gain nodes) in v1.1.1:
http://fiddle.jshell.net/nathansnider/Lty0kfdq/

The regression seems to be introduced in #689. @whenov could you take a look?

The error goes away if setFilters is executed in the ready event handler of wavesurfer:
waveLeft.on('ready', function() {
	var pannerLeft = waveLeft.backend.ac.createStereoPanner();
	pannerLeft.pan.value = -1;
	var gainL = waveLeft.backend.ac.createGain();
	gainL.gain.value = 1 - centerGain;
	waveLeft.backend.setFilters([pannerLeft, gainL]);
})

Because WaveSurfer.load is an asynchronous function, the setFilters in your code is called after WaveSurfer object is created and before load ends its execution.
In 1.1.0, setFilters will connect your last filter in the list to WaveSurfer.backend.gainNode, which is created in the creation of WaveSurfer. But in 1.1.1, your last filter will be connected to WaveSurfer.backend.splitter, which is created after load, that's the reason of the error.
The splitter can't be created before load is called, because it needs the number of channels of the loaded audio for its creation.

@whenov maybe the splitter can be implemented in terms of setFilter? Then we could insert the splitter on demand in setChannel instead of creating them on load.
Something like this:
setChannel: function (channel) {
    var channels = this.buffer.numberOfChannels;
    var splitter = this.ac.createChannelSplitter(channels);
    var merger = this.ac.createChannelMerger(channels);
    splitter.connect(merger, channel);
    this.setFilters([ splitter, merger ]);
}

@nathansnider I've released a new version 1.1.2. Please check if setFilters is working again.

Well, just revert it then, maybe the setChannel function should be implemented in user code using setFilters anyway. It's better to keep the default filters as simple as possible.

Yes, setFilters is working again in 1.1.2. Thanks, @katspaugh! Looks like we can close this issue, unless you want to keep it open for future work on the splitter-merger.


Idea: Setting for composer --no-dev

I'm using deployer to deploy to dev-environment too, and i need dev-dependencies from composer for that.
My idea is to allow for a setting, something like env("composer.dev", true); which would make the composer task remove the --no-dev value. "composer.dev" would be false by default so there is no BC break.
What do you think? Do you want a PR for this?

I think its better to have something like this:
set('composer_options', '--no-dev --no-interaction ...');

That's a good idea too. Want me to PR that?

ref #287

@Danielss89 will implement myself.

Done.

Nice! thanks.

@Danielss89 you can specify this option server specified (for one, or for all servers):
server(...)
    ->env('composer_options', '...');


Support dynamic algorithm selection

This is a follow-up to #172, which was intended to allow keyfinder to determine the decode key dynamically.  Adding the requirement to specify the algorithm causes a regression here, as the algorithm isn't known ahead of time.
There are a few ways to address this, but I think the simplest is just to allow the algorithm option to contain an array of supported algorithms, and only error if the request algorithm isn't in the list.

@CodeMonkeySteve thanks for the contribution. Can you add a test for that scenario, please?

@CodeMonkeySteve I close this PR. #241 implemented the whole scenario in a better way, IMHO.
Thanks for your contribution.


F821: false negatives when a file has from __future__ import annotations

Ruff currently emits no F821 errors on this .py file, but the lines marked with XXX all fail at runtime due to undefined names:
from __future__ import annotations

from typing import TypeAlias, Optional, Union

MaybeCStr: TypeAlias = Optional[CStr]  # XXX
MaybeCStr2: TypeAlias = Optional["CStr"]  # always okay
CStr: TypeAlias = Union[C, str]  # XXX
CStr2: TypeAlias = Union["C", str]  # always okay

class C: ...

class Leaf: ...
class Tree(list[Tree | Leaf]): ...  # XXX
class Tree2(list["Tree | Leaf"]): ...  # always okay

Note:

Ruff correctly emits three errors on this file when from __future__ import annotations is not included
Ruff correctly emits no errors on this file if it's a .pyi stub file.

The PR fixing this was reverted in #10513


Improve completion API

I added two features:

New completion type for user defined commands shellcmdline. It behaves exactly as :! which expects it first argument to be shellcmd and any subsequent argument to be a file.
New function getcmdcomplpat() which works in the manner of the getcmdcomptype() and exposes current completion pattern from xpc->xp_pattern.

Both features are useful for completion plugins and I can find question about the first one as far as from 2011.
I already added some tests and updated docs.
My first attempt was to contribute into nvim, so there is some discussion and explanation in the issue there.
All the tests except for the seven are ok. The same seven tests failing in the master branch and they are not related to anything I commited, so it's either broken tests or some problems with my local configuration. Would be really thankful for any advice on this matter.

I think it's fine to change the shellcmd completion to behave like the proposed shellcmdline completion. It's very unlikely for someone to rely on the old behavior. See https://github.com/search?q="complete%3Dshellcmd"+language%3A"Vim+Script"&type=code&l=Vim+Script.

Hm, there are 1.1k results. Calling this unlikely is a bit brave. Let's keep the shellcmdline completion type

Note that there are also a few test failures

Yes, I'm trying to setup Windows environment to investigate this. For some reason tab completion works without problems on my Linux machine but breaks on Windows and macos. And only on medium and huge builds. I currently have zero ideas why that happened but I hope I will figure that out soon.

diff --git a/src/testdir/test_cmdline.vim b/src/testdir/test_cmdline.vim
index 7534e081a..47f74237c 100644
--- a/src/testdir/test_cmdline.vim
+++ b/src/testdir/test_cmdline.vim
@@ -3647,9 +3647,11 @@ func Test_cmdline_complete_shellcmdline_argument()

   set wildoptions=fuzzy
   call feedkeys(":MyCmd vim test_cmdline.\<Tab>\<C-B>\"\<CR>", 'xt')
+  sleep 100m
   call assert_equal('"MyCmd vim test_cmdline.vim', @:)
   set wildoptions&
   call feedkeys(":MyCmd vim test_cmdline.\<Tab>\<C-B>\"\<CR>", 'xt')
+  sleep 100m
   call assert_equal('"MyCmd vim test_cmdline.vim', @:)

   delcommand MyCmd

:sleep may help you.
I think the completion seems slow when macOS and Windows.  Because it is from shell command line.

	From test_cmdline.vim:
	Found errors in Test_cmdline_complete_shellcmdline_argument():
	command line..script /Users/runner/work/vim/vim/src/testdir/runtest.vim[607]..function RunTheTest[57]..Test_cmdline_complete_shellcmdline_argument line 5: Expected '"MyCmd vim test_cmdline.vim' but got '"MyCmd vim test_cmdline.'
	command line..script /Users/runner/work/vim/vim/src/testdir/runtest.vim[607]..function RunTheTest[57]..Test_cmdline_complete_shellcmdline_argument line 8: Expected '"MyCmd vim test_cmdline.vim' but got '"MyCmd vim test_cmdline.'

After some fight with MSVC I was able to build it on windows. It seems to be the problem that I put -nargs=1 into my test function. For some reason MS and apparently MacOS version has this behavior that it won't try to complete another argument if it exceeds nargs. Yet this behavior ignored if completion type is set to be shellcmd. I think if I change it to -nargs=+ or something it should pass as expected. I wasn't able to run tests locally so hope they will rerun and pass on another push.
I think it is possible to hack a bit more to achieve the same behavior on completion as shellcmd but for me it looks more like bug on the part of the shellcmd. We do not provide subsequent completions for any completion type if we explicitly set agruments number to be one. Why would we do that for shellcmd?
Also interesting part is why this behavior exists on windows and macos but not on linux builds.

Everything except for one macos test passed. It looks like it flacked. It is not about completion and last time it was ok.
Also is that codecov test mandatory or not? Should I add more tests? For me it looks like I already did all the main scenarios.

It passed but I'm still not sure about codecov.

I am not so worried about codecov, but can you add a few more examples, like some pattern that does not result in any completion result or without any pattern?

Everything passed. I hope it's ok now.

thanks

Thanks you guys! That is my first contribution to vim/nvim and that was a pleasure to work with you.


[StructUtil] add support that the Struct can nest any type to transform

Now, the StructUtil method ToMap can transform any type that is nested in a struct. And I add all unit tests for it.
Please check it and merge this PR, and I will write docs for StructUtil.

Codecov Report
Patch coverage: 70.42% and project coverage change: -0.02 :warning:

Comparison is base (ef1e548) 82.76% compared to head (49e8527) 82.75%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   82.76%   82.75%   -0.02%
==========================================
  Files          52       54       +2
  Lines        4962     5021      +59
==========================================
+ Hits         4107     4155      +48
- Misses        633      641       +8
- Partials      222      225       +3

Impacted Files
Coverage Δ

pointer/pointer.go
0.00% <0.00%> (ø)

structutil/error.go
0.00% <0.00%> (ø)

structutil/struct.go
85.71% <62.50%> (-7.84%)
:arrow_down:

structutil/field.go
88.70% <85.10%> (+25.07%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@m430 cool! will merge this pr.

@m430 Made two small changes in structutil package:
Avoid unused func/variable exported in package level.

Change file name error.go to struct_internal.go, and make errInvalidStruct function un exported.
Made package exported variable DefaultTagName to defaultTagName, and support set tag name in the New function when instance Struct.


Minor enhancements

Refer to this link for build results (access rights to CI server needed):
http://guh.guru:8080/job/guh-webinterface-pull-request/62/


Python module skeleton; More documentation

Codecov Report

Merging #246 into master will decrease coverage by 0.25%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   73.46%   73.22%   -0.24%
==========================================
  Files         150      151       +1
  Lines        9124     9015     -109
  Branches     1443     1414      -29
==========================================
- Hits         6702     6600     -102
- Misses       2058     2059       +1
+ Partials      364      356       -8

Impacted Files
Coverage Δ

src/main/java/org/verdictdb/VerdictGateway.java
0% <0%> (ø)

...in/java/org/verdictdb/jdbc41/VerdictStatement.java
21.32% <0%> (-3.27%)
:arrow_down:

...ictdb/core/querying/QueryExecutionPlanFactory.java
86.21% <0%> (-1.71%)
:arrow_down:

.../org/verdictdb/sqlreader/RelationStandardizer.java
82.23% <0%> (-1.11%)
:arrow_down:

...ictdb/core/querying/ola/AsyncAggExecutionNode.java
69.24% <0%> (-0.97%)
:arrow_down:

.../core/scrambling/FastConvergeScramblingMethod.java
90.37% <0%> (-0.3%)
:arrow_down:

...tdb/core/querying/ola/AsyncQueryExecutionPlan.java
89.16% <0%> (-0.24%)
:arrow_down:

.../verdictdb/coordinator/SelectQueryCoordinator.java
94.32% <0%> (ø)
:arrow_up:

...org/verdictdb/core/sqlobject/OrderbyAttribute.java
100% <0%> (ø)
:arrow_up:

...rying/simplifier/DirectRetrievalExecutionNode.java
91.25% <0%> (ø)
:arrow_up:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 840c526...3acc978. Read the comment docs.


JSON Comments/Suggestions

Congrats Harold.
I saw the updates, send/receive JSON looks straightforward.
You might want to add another key/value pair for speed as well.
Not sure how that would look, but maybe something like this.
{ "dir":"FL","speed":50}
Direction would be Forward Left
Speed would be 50% of maxSpeed
dir values FR = Forward Right, FC=Forward Center, FL=Forward Left
dir values CR = Center Right, CL=Center Left
dir values BR=Backwards Right,BC=Backwards Center,BL=Backwards Left
dir values RR=Rotate Right, RL=Rotate Left
add the key/value pair of timeMs for duration to do the command.
add the key/value pair of claw for position.
example {"claw":"open","claw":"closed"} or {"claw":0} or {"claw:",100} the 0,100 are percent opened. 100=Full Opened

We are gonna have do something more than this.  I am writing up a retro, so that we can do a lessons learned sorta thing and make plans to make both HugoBot and JimBot better.


Fix/get storage at response

Description
Modified getStorageAt RPC method to return the RLP decode value.
Changes include

[x] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

[x] I have assigned this PR to myself
[x] I have added at least 1 reviewer
[x] I have tested this code
[ ] I have updated the README and other relevant documents (guides...)
[ ] I have added sufficient documentation both in code, as well as in the READMEs

Additional comments
TestEth_State_GetStorageAt is also modified to test the new response

Thank you for the PR! I test locally and node returns correct value.
I checked Ethereum json-rpc wiki and result will be padded with zeros so that result is 32 bytes data.
Let's say storage data is 0x4, then result would be 0x00000000000000000000000000000004.
https://eth.wiki/json-rpc/API#eth_getstorageat

@Kourin1996 I have tested with ganache and local geth, both are returning result without padding bits

@Kourin1996 I have tested with ganache and local geth, both are returning result without padding bits
@munna0908 Thank you for checking!

@Vuksan  can i merge this ?


gif API just fetches the same ones every time

to replicate this, open the gif menu and scroll all the way down

https://github.com/ION606/chatJS/commit/ac09b93b9b7306d29857a9410a061de9665989b5


refactor: restructure project to load Sorald as a service using Java SPI

@MartinWitt, thanks for your work, first of all. It is a great milestone toward integrating the Qodana static analyzer and development in general, as the code quality has definitely increased.
Let's work towards merging this now because there is feature request #807 that require a lot of code movement. I feel it is better to start working on top of the changes in this PR to avoid dealing with merge conflicts later. Some things that need to be done before we merge this PR:

[x] Update usage in README #810
[x] What do we do about the docs? Most files are related to sorald and not sorald-parent. Should we move it? I am in favour of letting them be for two reasons: #809

docs should be accessible from the root of the repository
There is no immediate need to do so.

[ ] Your final review of the changes you have made. I hope I have not messed them up during merging from master.

@MartinWitt , please give your opinions about subtasks 2 and 3. Once all of them are resolved, we can proceed to merge. Note that this PR will not be squashed as each commit is an atomic change in itself.

Merging this PR as it is needed to implement some requested features. I have fixed whatever was necessary. I have not tested the deployment of SNAPSHOT version and it may fail, but I don't have access to its credentials as of now. However, @monperrus , @slarse, and I have had a discussion over this. If there is a need to revoke the tokens, I will create an OSSRH account chains-bot with email<EMAIL_ADDRESS>

Thanks for your work, @MartinWitt ! It is an advancement towards the integration of the Qodana static analyzer.

Yes! Thanks @MartinWitt

I will create an OSSRH account chains-bot with email<EMAIL_ADDRESS>
excellent initiative :+1:


Refactoring for #23 and more

Simplified getInstance synchronization
Removed the HashMap<Application,Tracker>, see #23
Each Tracker now has their own preferences based on apiurl+siteid. So in the future we can track one-shot events per different trackers. This might see some further changes when i submit a PR with changes for download tracking. Note: If you would update the library and call trackDownload again, it would send a new event as the old preference file was per piwik instance not per tracker.
api-url and site-id are now final and can only be set when creating the tracker. It was previously already not possible to create a tracker with no api-url, why would you then want to create a tracker with one url and then change it later. This also prevents concurrency issues, what if the api-url/siteid get changed while some other routines are accessing them. TL;DR Enforcing the practice of creating a new Tracker for a new api-url/siteid.
Updated all tests to fit the changes and fixed sharedpreferences not working correctly for testcases.

Some autoformatting and import optimization was done too and each time i change a specific variable i rename it to mVariable. m is for member, while in the end it's personal preference, it's in line with naming in official AOSP classes, i hope no one is annoyed by that.
Tests all pass on my machine and this is the first PR against the new dev branch :+1:

After further thought having different preferences per tracker is something we should leave up to devs and for simple purposes the previous way of one shared preference for Piwik is the best solution.
commit dbe63a3 restored that.
Issues i saw with the reverted approach:

It's no longer possible to change apiurl/siteid without loosing the previous preferences.
It might be more interesting to have global piwik file to deal with "opt out" and other possible tracker settings.
The caveat that using different trackers and the "trackAppDownload" method wouldn't work toegether as it would only fire for the first tracker is not something we should be concerned with now, if someone really needs 3 trackers with different "trackAppDownload" events they could just wrap the "trackNewAppDownload" themself.

@d4rken Could You merge your branch with actual piwik:dev, so I could merge it automatically?

Yeah just saw that, currently fixing the conflicts.

@dotsbb Should be good to go after travis is done :+1:


Chilloutzone: Unable to extract video data

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I remove or skip any mandatory* field

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2023.01.06 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Germany
Provide a description that is worded well enough to be understood
When trying to download a video from chilloutzone.net - e.g. https://www.chilloutzone.net/video/ordentlich-abgeschuettelt.html -  the correct extractor is chosen, but then throws the error "Unable to extract video data" is thrown.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-vU', 'https://www.chilloutzone.net/video/ordentlich-abgeschuettelt.html']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2023.01.06 [6becd25] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19044-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2022-10-13-git-9e8a327e68-full_build-www.gyan.dev (setts), ffprobe 2022-10-13-git-9e8a327e68-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.16.0, brotli-1.0.9, certifi-2022.12.07, mutagen-1.46.0, sqlite3-2.6.0, websockets-10.4
[debug] Proxy map: {}
[debug] Loaded 1760 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2023.01.06, Current version: 2023.01.06
yt-dlp is up to date (2023.01.06)
[Chilloutzone] Extracting URL: https://www.chilloutzone.net/video/ordentlich-abgeschuettelt.html
[Chilloutzone] ordentlich-abgeschuettelt: Downloading webpage
ERROR: [Chilloutzone] ordentlich-abgeschuettelt: Unable to extract video data; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp\extractor\common.py", line 680, in extract
  File "yt_dlp\extractor\chilloutzone.py", line 56, in _real_extract
  File "yt_dlp\extractor\common.py", line 1264, in _html_search_regex
  File "yt_dlp\extractor\common.py", line 1228, in _search_regex

The rest of the code could probably use a good modernizing, but this regex fix will at least get the extractor working again:
diff --git a/yt_dlp/extractor/chilloutzone.py b/yt_dlp/extractor/chilloutzone.py
index 1a2f77c4e..9f3c7db78 100644
--- a/yt_dlp/extractor/chilloutzone.py
+++ b/yt_dlp/extractor/chilloutzone.py
@@ -54,7 +54,7 @@ def _real_extract(self, url):
         webpage = self._download_webpage(url, video_id)

         base64_video_info = self._html_search_regex(
-            r'var cozVidData = "(.+?)";', webpage, 'video data')
+            r'var cozVidData\s*=\s*"([^"]+)"', webpage, 'video data')
         decoded_video_info = compat_b64decode(base64_video_info).decode('utf-8')
         video_info_dict = json.loads(decoded_video_info)


ERROR 404: Not Found with installodbc_redhat.sh

When attempting to install the msphsql drivers, the install script for red hat fails with a 404 error when trying to download msodbcsql-<IP_ADDRESS>.tar.gz.  Below is the log of the install.  Is there another location wher I can get the file?
--2017-02-22 09:17:08--  ftp://ftp.unixodbc.org/pub/unixODBC/unixODBC-2.3.1.tar.gz
=> \u2018/tmp/msodbcrhel/unixODBC-2.3.1.tar.gz\u2019
Resolving ftp.unixodbc.org (ftp.unixodbc.org)... <IP_ADDRESS>
Connecting to ftp.unixodbc.org (ftp.unixodbc.org)|<IP_ADDRESS>|:21... connected.
Logging in as anonymous ...
Length: 1813380 (1.7M) (unauthoritative)
100%[====================================================================================================>] 1,813,380    264KB/s   in 8.9s
2017-02-22 09:17:24 (198 KB/s) - \u2018/tmp/msodbcrhel/unixODBC-2.3.1.tar.gz\u2019 saved [1813380]
Loaded plugins: fastestmirror, langpacks
Repository packages-microsoft-com-prod is listed more than once in the configuration
base                                                                                | 3.6 kB  00:00:00
epel/x86_64/metalink                                                                                |  14 kB  00:00:00
extras                                                                                | 3.4 kB  00:00:00
google-chrome                                                                                |  951 B  00:00:00
packages-microsoft-com-prod                                                                                | 2.9 kB  00:00:00
remi-safe                                                                                | 2.9 kB  00:00:00
updates                                                                                | 3.4 kB  00:00:00
webtatic                                                                                | 3.6 kB  00:00:00
(1/2): updates/7/x86_64/primary_db                                                                                | 2.3 MB  00:00:00
(2/2): remi-safe/primary_db                                                                                | 907 kB  00:00:01
Loading mirror speeds from cached hostfile

base: mirrors.cmich.edu
epel: mirrors.lug.mtu.edu
extras: mirrors.rit.edu
remi-safe: repo1.ash.innoscale.net
updates: mirror.team-cymru.org
webtatic: us-east.repo.webtatic.com
Package gcc-4.8.5-11.el7.x86_64 already installed and latest version
Nothing to do
Succesfuly installed Yum Dependencies
Installing unixODBC 2.3.1
Successfuly installed unixODBC 2.3.1
--2017-02-22 09:18:22--  https://download.microsoft.com/download/B/C/D/BCDD264C-7517-4B7D-8159-C99FC5535680/msodbcsql-<IP_ADDRESS>.tar.gz
Resolving download.microsoft.com (download.microsoft.com)... <IP_ADDRESS>, 2600:1417:4:187::e59, 2600:1417:4:196::e59
Connecting to download.microsoft.com (download.microsoft.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-02-22 09:18:24 ERROR 404: Not Found.

Unable to get Microsfot ODBC Driver from download center.
sudo: unable to resolve current working directory

Hi @mikelecours  msodbcsql-<IP_ADDRESS>.tar.gz is old. Please follow the instructions on readme
To verify that ODBC driver is registered successfully, do the following:
odbcinst -q -d -n "ODBC Driver 13 for SQL Server"
You should see an output like this
[ODBC Driver 13 for SQL Server]
Description=Microsoft ODBC Driver 13 for SQL Server
Driver=/opt/microsoft/msodbcsql/lib64/libmsodbcsql-13.1.so.1.0
UsageCount=1

Hope this helps.

That's the output I got.  Thanks.  I then followed the README instructions.  Everything seemed to install OK.  But when I tried the test php script in the readme I got the error:
Error information:
SQLSTATE: IMSSP
Code: -14
Message: An invalid parameter was passed to sqlsrv_query.
I've attached the testsql.php file for your review
testsql.php.txt
Just to be sure, I tried the connection string in sqlcmd and it worked just fine
[root@nagios ~]# sqlcmd -S <IP_ADDRESS> -d nagiosdb -U nagios -P
1> select * from dbo.testtable;
2> go
testdata
mydata
(1 rows affected)

Here's the new error messages
Error information:
SQLSTATE: HYT00
Code: 0
Message: [unixODBC][Microsoft][ODBC Driver 13 for SQL Server]Login timeout expired
SQLSTATE: 08001
Code: 10013
Message: [unixODBC][Microsoft][ODBC Driver 13 for SQL Server]TCP Provider: Error code 0x271D
SQLSTATE: 08001
Code: 10013
Message: [unixODBC][Microsoft][ODBC Driver 13 for SQL Server]A network-related or instance-specific error has occurred while establishing a connection to SQL Server. Server is not found or not accessible. Check if instance name is correct and if SQL Server is configured to allow remote connections. For more information see SQL Server Books Online.

@mikelecours Code 10013 means "Permission Denied". It might be firewall or related issues. In addition, you ran sqlcmd as root user (I assume the password was chopped off when you pasted).
Please try the followings:

run sqlcmd NOT as root
try connecting to another SQL Server using sqlsrv

Also, what version of SQL Server are you using? On which Windows version?
#190 might be a related issue.

I've confirmed I can connect as a regular user:
[nagios@nagios ~]$ sqlcmd -S <IP_ADDRESS> -d nagiosdb -U nagios -P nagios
1> select * from dbo.testtable;
2> go
testdata
mydata
(1 rows affected)
The instance I'm connecting to is Microsoft SQL Server Express (64-bit) 13.0.4001.0 running on Window 10.  I don't have another SQL Server instance to try connecting to.   I'm connecting from Centos 7.
I looked at incident 190 but I don't think it related.  It's not the firewall as I connect through SQLCMD.  It's not the ports since I'm using the default and connect with or without the port specified.  Just can't connect using the ms php drivers.
With the port specified.
[nagios@nagios ~]$ sqlcmd -S <IP_ADDRESS>,1433 -d nagiosdb -U nagios -P nagios
1> select * from dbo.testtable;
2> go
testdata
mydata
(1 rows affected)

Thanks @mikelecours for the details. What output do you get when running odbcinst -q -d -n "ODBC Driver 13 for SQL Server"?
Also, to help us troubleshoot the connection issues, please go through the section Troubleshooting Connection Problems on this page.
For example, when you run yum list unixODBC, what do you see? Thank you for your patience.

Here's the result of the driver query
[nagios@nagios ~]$ odbcinst -q -d -n "ODBC Driver 13 for SQL Server"
[ODBC Driver 13 for SQL Server]
Description=Microsoft ODBC Driver 13 for SQL Server
Driver=/opt/microsoft/msodbcsql/lib64/libmsodbcsql-13.1.so.4.0
UsageCount=1
Here's the result of the yum list command
Installed Packages
unixODBC.x86_64                        2.3.1-11.el7                        @base
Available Packages
unixODBC.i686                          2.3.1-11.el7                        base
I'll try working through the trouble shooting document and report back the results

I ran through the troubleshooting steps.  The results are attached below.  If I'm interpreting them correctly, the most common issue of more than one driver manager installed is false.  It seems that the odbc drives themselves are working correctly.  It seems that php is just not talking to them.
I don't know if this helps, but what I'm try to do is monitor a SQL Server instance with Nagios.  It uses php to connect.  Here's the error message I get from Nagios.  It has different error messages that might help.
[nagios@nagios ~]$ check_mssql -H <IP_ADDRESS> -U nagio -P nagios -w 2 -c 5
PHP Warning:  PHP Startup: Unable to load dynamic library '/usr/lib64/php/modules/pdo_sqlsrv.so' - /usr/lib64/php/modules/pdo_sqlsrv.so: undefined symbol: php_pdo_register_driver in Unknown on line 0
PHP Warning:  Module 'sqlsrv' already loaded in Unknown on line 0
UNKNOWN: MSSQL/DBLIB support is not installed on this server. pdo_dblib must be usable.
mssqlphp.txt

@mikelecours your new error messages definitely gave us a clue. Please do the followings:

run php -m (this will display a list of php modules, and see if you can find sqlsrv or pdo_sqlsrv amongst them)
run php --ini (you might get similar warnings above) and locate where your php.ini file is

Then edit this php.ini file and look for extension=sqlsrv.so and extension=pdo_sqlsrv.so
If you find more than two instances of each, please delete the extra lines and only keep one line each. In short, you should only find one set of
extension=sqlsrv.so
extension=pdo_sqlsrv.so

Meanwhile I'll take a look at your attached logs.

Interesting.  The php --ini showed me the ini file that was loaded /etc/php.ini .  The two extension statement were in there.  I put them in per the install instructions.  There were no duplicates.  I looked up the PHP Warning: Module 'sqlsrv' already loaded in Unknown on line 0 part of the error and found a site that said to take out the extension statements if sqlsrv and pdo_sqlsrv were listed in the php -m statement because they are already compiled.  http://www.somacon.com/p520.php
So, I rem'd them out to see what would happen.  Now my app just returns UNKNOWN: MSSQL/DBLIB support is not installed on this server. pdo_dblib must be usable.  The other part of the error is gone.  No change with the testsql.php.  Still the same errors.  Attached are the lists from php -m and php --ini before the rem out.  They both showed the Unknown line 0 error.  That went away after I rem'd out the extension statement.  So php 7 doesn't like those statements.
php listing.txt
We changed the error message.  That's progress, right?

First of all, @mikelecours you're right, that for CentOS we shouldn't have the extensions in php.ini file. Instead, please read Step 5 of readme and you will find that RedHat / CentOS is handled differently from others. The main reason is that we have to ensure the extension PDO is loaded first.
Now that the lines have been commented out, you don't get those warning messages again, correct?
When you run php -m you should find pdo_sqlsrv and sqlsrv because they are supposed to be in separate ini files.
/etc/php.d/pdo_sqlsrv.ini,
/etc/php.d/sqlsrv.ini

What do you get when you run php --ri sqlsrv or the equivalent for pdo_sqlsrv?
Lastly, mssql pdo_dblib is not our extension.

Yeah, I'm not sure why Nagios is complaining about that.  But I mention it just to show the other error message is gone.
I verified that php -m shows both sqlsrv and pdo_sqlsrv.   I review step 5 of the readme and verified the entries in their ini files:
[nagios@nagios ~]$ grep sqlsrv.so /etc/php.d/sqlsrv.ini
extension= /usr/lib64/php/modules/sqlsrv.so
[nagios@nagios ~]$ grep sqlsrv.so /etc/php.d/pdo_sqlsrv.ini
extension= /usr/lib64/php/modules/pdo_sqlsrv.so
Here is the results of the php --ri sqlsrv
[nagios@nagios ~]$ php --ri sqlsrv
sqlsrv
sqlsrv support => enabled
ExtensionVer => <IP_ADDRESS>
Directive => Local Value => Master Value
sqlsrv.WarningsReturnAsErrors => On => On
sqlsrv.LogSeverity => 0 => 0
sqlsrv.LogSubsystems => 0 => 0
sqlsrv.ClientBufferMaxKBSize => 10240 => 10240
Everything seems to say the drivers are OK, sqlcmd can use them, why can't php?

Good question @mikelecours :) I believe it's something to do with your environment, so let's take a couple of steps back and run odbc trace again. Previously, you said your testsql.php did not write anything to the log. Is it still the case?
Do you have a clean CentOS vm for testing purposes?
Also, I wonder why it complains about pdo_dblib. Please check if the extension is listed in your php.ini

You're not going to believe this but I found the problem.  It's SELinux.  I set it to permissive to test another problem and suddenly the testphp page works - connect to my database just fine.  Set it SELinux back to enforcing - doesn't work.  Back to permissive, works great.  Since I can't leave it in permissive, any guidance on what needs to be set to allow php to keep using the drivers?

Glad to hear that you found a solution to this, @mikelecours. However, SELinux seems to have troubles with Apache + PHP (see this page for example).
Just for a quick test, can you run a simple script like this:
<?php
	phpinfo();
?>

Yes, it returns the versioning information.  I'll look at the page you sent me to see if I can solve the SELinux problem

Just so you know, we've confirmed that once SELinux is set to Enforcing, the php script won't run on Apache (even though running the same script from a terminal php /var/www/html/testsql.php works). This link might be able to help you, and it seems workarounds are possible. Good luck, @mikelecours.

Thanks for all your help and prompt attention . It was very much appreciated.

Hi @mikelecours ,
Can you post output of the following command?
getsebool -a | grep httpd

If, httpd_can_network_connect_db --> off, you need to allow Apache to connect to remote database through SELinux. Please try:
setsebool httpd_can_network_connect_db 1

That did the trick!  Thanks!

We are glad to hear that suggestion @ulvii works, @mikelecours !
I also found out setsebool -P httpd_can_network_connect 1 also fixed the issue.
However, we would like to know, from an end user's point of view, which setting is preferred. Looking forward to hearing from you.

For this application, httpd_can_network_connect_db is preferred.  According to the man page for httpd_selinux, httpd_can_network_connect_db only allow connection to known database ports where as httpd_can_network_connect allow connect to any port.  Below is the allowed ports from the man page for connect_db
allow httpd_t postgresql_port_t : tcp_socket { recv_msg send_msg name_connect } ;
allow httpd_t mssql_port_t : tcp_socket name_connect ;
allow httpd_t oracle_port_t : tcp_socket name_connect ;
allow httpd_t mysqld_port_t : tcp_socket { recv_msg send_msg name_connect } ;
allow httpd_t gds_db_port_t : tcp_socket name_connect ;

Thank you for your contributions, @mikelecours . We will update our documentation accordingly.


ARTEMIS-1420 limit non-ssl connection hangs up exceeding client(s)

Can you elaborate on the use case where this is required?  The broker already has functionality to close dead connections.  By implementing this feature you are hard-coding a 30 timeout for all clients regardless of how they've configured their heart-beats.

@stanlyDoge, can you modify this in the following ways:

Remove the ReadTimeoutHandler from the pipeline when the handshake is complete so it doesn't interfere with the other connection monitoring logic.
Change the test so it only tests the handshake bit.

I've already pushed removing ReadTimeoutHandler here but i am not sure if it is enough. Also i have to adapt test as you say.

@mtaylor Thanks, changed.

"Connection readTimeout has occurred.",
NETTY_READ_TIMEOUT = "read-timeout-seconds";
private int readTimeout;

Would a more descriptive name be better here for the configuration etc, something that conveys its a one-time protocol header timeout at connection startup? Using simply 'read timeout' seems like it could be confused with being related to other more general ongoing TCP read timeout handling and heartbeating etc, whereas it actually wont have effect beyond the first 8 bytes. Maybe 'protocol-header-timeout' or something like that?
The test was added in the amqp test package as opposed to somewhere more general, which would seem nicer given it is entirely protocol-agnostic behaviour under test. Overlooking that though it was added to "AmqpSendReceiveTest" which seems odd given it obviously doesn't establish an AMQP connection and send or receive anything. Adding it there also means the test had to start->stop->reconfigure->restart the broker to perform the checking. Adding a new test class would be nicer, preferably outside the amqp package, but even if shoehorning into an existing amqp test there are perhaps better options like AmqpProtocolHeaderHandlingTest where it could be taken as a 'doesnt send header' test.


SSLError while running the basic example

Hello,
I was trying to run the basic example provided in the github page:
import webhose

webhose.config(token="MYTOKENWASHERE")
for post in webhose.search("string i searched"):
    print(post.title)

I am keeping receiving the following error:
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 559, in urlopen
    body=body, headers=headers)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 345, in _make_request
    self._validate_conn(conn)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 784, in _validate_conn
    conn.connect()
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/connection.py", line 252, in connect
    ssl_version=resolved_ssl_version)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/util/ssl_.py", line 305, in ssl_wrap_socket
    return context.wrap_socket(sock, server_hostname=server_hostname)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/ssl.py", line 376, in wrap_socket
    _context=self)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/ssl.py", line 747, in __init__
    self.do_handshake()
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/ssl.py", line 983, in do_handshake
    self._sslobj.do_handshake()
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/ssl.py", line 628, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:645)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/adapters.py", line 376, in send
    timeout=timeout
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py", line 588, in urlopen
    raise SSLError(e)
requests.packages.urllib3.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:645)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Applications/PyCharm CE.app/helpers/pydev/pydevd.py", line 1733, in <module>
    debugger.run(setup['file'], None, None)
  File "/Applications/PyCharm CE.app/helpers/pydev/pydevd.py", line 1226, in run
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/Applications/PyCharm CE.app/helpers/pydev/_pydev_execfile.py", line 38, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc) #execute the script
  File "/Users/aliselmanaydin/PyCharmProjects/SentimentAnalysis/sentiment.py", line 27, in <module>
    for post in webhose.search("string i searched"):
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/webhose/__init__.py", line 180, in search
    return __session.search(query, token)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/webhose/__init__.py", line 161, in search
    response = self.session.get("https://webhose.io/search", params=params)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/sessions.py", line 480, in get
    return self.request('GET', url, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/sessions.py", line 468, in request
    resp = self.send(prep, **send_kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/sessions.py", line 576, in send
    r = adapter.send(request, **kwargs)
  File "/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/requests/adapters.py", line 447, in send
    raise SSLError(e, request=request)
requests.exceptions.SSLError: EOF occurred in violation of protocol (_ssl.c:645)

I tried all solutions proposed on the internet, but none of them worked. Tried both with Python 2 and Python 3.
Any comments/suggestions on this?

What version of Python 2 did you use? It should work on python to 2.7.11
Did you try the suggested solution on this SO thread?
http://stackoverflow.com/questions/29153271/sending-tls-1-2-request-in-python-2-6

Use http://webhose.io/search as an enpoint instead of https - will solve the TLS issue :)

Oh I totally forgot about this. Sorry, and thanks for the solution. I'm sure it will help many people.


Fix: don't warn on useless conversions when the count value is already a usize

nit: fix doc comment that applied to use and not module
fix: don't warn on useless conversions when the value is already a usize

Example code to reproduce the issue: (run cargo clippy)
const LEN: usize = 42;

#[derive(binrw::BinRead)]
struct Data {
    #[br(count = LEN)]
    data: Vec<u8>,
}

Thank you for your PR, and sorry for the delay! I modified your patch slightly to add the example code as a test so this will not regress later, and to make the summary fit the convention used by this project. This will be fixed in the next release.


Can not get the results in the paper

Hello, I am trying to run your code in QuickDraw dataset, but I find the results look a little weird. Like the "a_simple_drawing_of_an_apple", there are some extra lines that don't match the apple, so if I should reduce the stroke numbers?

Here are my input and output, I use the default setting, with 16 strokes, 5 segments, and 1001 iterations.

The above input is wrong, here is my real input.

@jiayeleng The Stable Diffusion model is better at complementing sketches than polishing sketches. And most QuickDraw sketches are too abstract and may not work well as the conditions of ControlNet. Could you use some other examples (incomplete sketches) with larger stroke widths? It seems to me that your input is already a complete apple.


Add known names to the PII JSON files

Type of Change

[X] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Some known column names where not picked up by the command as a known PII column name.
Approach
By adding the known names to the pii-knownnames.json file the command was able to categorize those fields as supposed to.
Commands to test
Invoke-DbaDbPiiScan
Screenshots

Learning
The command Invoke-DbaDbPiiScan has an option to supply your own known names JSON file. If for any reason the default known names does not have the right columns for your situation, you can create your own and execute the command.
By doing that you increase the amount of patterns to make the command return a better result.

excellent, thanks sander!


Build time improvements

npm run build takes 6 full seconds and even in npm run watch it takes 2+ seconds for any change.
It would be great to bring this time down, maybe with https://github.com/Realytics/fork-ts-checker-webpack-plugin or the new --incremental flag, if it works

IssueHunt Summary

Sponsors (Total: $40.00)

 issuehunt ($40.00)

Become a sponsor now!
Or submit a pull request to get the deposits!
Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

@issuehunt has funded $40.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.


possible to run PowerShellOnTargetMachines.ps1 from powershell to troubleshoot?

Hi,
The line "$environment = Register-Environment -Enviro........." in PowerShellOnTargetMachines.ps1 fails when running for our Powershell on Target Machines task.
Trying to debug this by running PowerShellOnTargetMachines.ps1 manually in powershell. However it fails because the  $distributedTaskContext parameter is null when it's run manually. Is there anyway to set this without running it in a build?
Cheers

Hi folks,
The workaround we are doing now is to run a local powershell task step (instead of a remote powershell task) and have that local powershell script call the powershell scripts to run on the remote servers. It works but ideally we would like to use "Powershell on Target Machines" directly.
The fact that we can run remote powershell scripts from a local powershell script means we are confident all the security etc is set up correctly. It's a tricky one to figure out how to troubleshoot why "Powershell on Target Machines" task is failing.
Many thanks

@ github-man
Hi ,
What error you are getting for "$environment = Register-Environment..." ? Is it possible for you to share the agent logs ?
You can also mail the details to - RM_Customer_Queries at Microsoft dot com
Thanks

@ github-man
Hi ,
As of now you will not able to debug 'PowerShellOnTargetMachines.ps1' . It will work only with agent context .
If you have any other issue you may mail to RM_Customer_Queries at Microsoft dot com.
Thanks


cnameStrategy: Follow with SAN

Describe the bug:

Create a cluster issuer with the cnameStrategy set to Follow.
apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: letsencrypt
spec:
  acme:
    email<EMAIL_ADDRESS>    privateKeySecretRef:
      name: letsencrypt
    server: https://acme-v02.api.letsencrypt.org/directory
    solvers:
    - dns01:
        cnameStrategy: Follow
        route53:
          region: cn-nortwest-1
          secretAccessKeySecretRef:
            name: ""
      selector:
        dnsZones:
        - example.org
        - example.com

A CNAME record is then created as
_acme-challenge.api.example.com	IN	CNAME	_acme-challenge.example.org.

The DNS01 challenge could be successfully verified with the following certificate request:
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: api.example.com
  namespace: cert-manager
spec:
  dnsNames:
  - api.example.com
  issuerRef:
    kind: ClusterIssuer
    name: letsencrypt
  secretName: api.example.com-tls

Everything works fine so far. But things change if subjectAltNames comes in.
Create a certificate as
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: api.example.com
  namespace: cert-manager
spec:
  dnsNames:
  - api.example.com
  - api.prd.example.com
  issuerRef:
    kind: ClusterIssuer
    name: letsencrypt
  secretName: api.example.com-tls

Now cert-manager creates a TXT record for _acme-challenge.api.prd.example.com in the zone of .example.com.. Since we have a split-horizon dns configuration, cert-manager just keeps complaining 'dns record not yet propagated'. If we create the CNAME record:
_acme-challenge.api.prd.example.com	IN	CNAME	_acme-challenge.example.org.

cert-manager complains otherwise: RRSet of type TXT with DNS name _acme-challenge.api.prd.example.com. is not permitted because a conflicting RRSet of type CNAME with the same DNS name already exists in zone example.com.
It seems that the subjectAltNames doesn't respect cnameStrategy: Follow.
Expected behaviour:

cnameStrategy: Follow should work with SAN.
Steps to reproduce the bug:

Anything else we need to know?:
Environment details::

Kubernetes version: v1.23.5+k0s
Cloud-provider/provisioner: AWS route53
cert-manager version:  v1.8.0
Install method: pulumi helm release

/kind bug

btw. my company stumbled upon this aswell and actually it worked in the past


PLC1901 false positive in __bool__ methods

class X:
    val: str

    def __bool__(self) -> bool:
        return self.val != ""

$ ruff check test.py --select=PLC1901
test.py:5:28: PLC1901 `self.val != ""` can be simplified to `self.val` as an empty string is falsey
Found 1 error.

Trying to correct this to self.val will lead to an error:
TypeError: __bool__ should return bool, returned str

Yeah, The "safe" fix for this rule should probably be bool(self.val). But even that is not entirely safe, because it now no longer reads self.val, which could have side effects.

In one case I specifically need the comparison :)

This rule is fundamentally incorrect for assertions or assignments, since None != "" - unless it can infer that the variable is a string.
a = 1

def test_sth() -> None:
    assert a == ""

Command: ruff --isolated --select PLC1901 a.py
Output:
a.py:4:17: PLC1901 `a == ""` can be simplified to `not a` as an empty string is falsey
Found 1 error.

$ ruff --version
ruff 0.0.274

Yes, Pylint's implementation has the same problem:
❯ pylint --load-plugins=pylint.extensions.emptystring foo.py
************* Module foo
foo.py:1:0: C0114: Missing module docstring (missing-module-docstring)
foo.py:1:0: C0104: Disallowed name "foo" (disallowed-name)
foo.py:1:0: C0103: Constant name "a" doesn't conform to UPPER_CASE naming style (invalid-name)
foo.py:3:0: C0116: Missing function or method docstring (missing-function-docstring)
foo.py:4:11: C1901: "a == ''" can be simplified to "not a" as an empty string is falsey (compare-to-empty-string)

I'm going to move this rule to the nursery so that it's explicitly opt-in.

Looks like the rule was renamed/revisited:
https://pylint.pycqa.org/en/latest/user_guide/messages/convention/use-implicit-booleaness-not-comparison-to-string.html

Here's another example where this rule creates false positives with numpy:
import numpy as np

array = np.array(("X", "", "X"), dtype=str)
indices = array == ""
print(indices)

print(not array)

At least in this case, not array raises a ValueError, so incorrect fixes become obvious (at least at runtime).


Column filtering - multiple selection

[x] Question

Current filterOptions offers filterDropdownItems selection array which is mutually exclusive.
Is there a option or workaround to have a mutually inclusive offering multiple in the selection dropdown.
Here's an image to help highlight the use case.
Thanks

@ChaStPierre, unfortunately, mult-select is not currently possible for filters. I'll chalk this up as an enhancement.

Great. This would be a beautiful and powerful enhancement. There aren't many libraries that offer this feature. Combination of multiple column selective filtering would offers limitless views and would greatly help overall UX.  Looking forward to it !
Cheers

@xaksis do you have an idea if this might be part of the roadmap anytime soon?
Thanks

I believe that if you could customize the sorting and allow developers to access Filter fields slots. This shall add one awesome capability to this amazing masterpiece. { Date range selector, multichoice } and so many examples.

Hi, any progress on this?

Any updates on this?


No Haptic feedback?

I was so excited to find a working T9 keyboard, I installed it, and loved how easy it was to use. But my dreams were annihilated as I immediately realised there was no haptic feedback (rumble) on key press. will this be added? I can't use the keyboard without haptic feedback, so I have uninstalled until it is added, or I find a replacement

The virtual keypad is still a bit incomplete, but I didn't realize how important this was.
I am going to do it in #240. Stay tuned and follow #240 for updates.

Thanks!


[PE-D] Contact in tasks list

I think this is more of a personal design preference. It seems like the sole purpose of contacts under task is for users to reference when doing assignments.
Expected:
only tasks in task tab
Actual:
contacts again in task tab
My personal feeling:
TabView might be a poor choice.

Labels: type.FunctionalityBug severity.VeryLow
original: CrownKira/ped#6

Resolved by #289