Extremely high compilation time for production build on v5

Current behavior
We are about to release Quasar Framework CLI v2 (@quasar/app), and really want to integrate fork-ts-checker new version.
We are testing it on real world (private) projects and I noticed an extreme (talking about some minutes, 18s vs 183s) slowdown of production compilation in a particular scenario, for which I cannot pin-point the cause.
I could use some guidance, because the behaviour I'm experiencing is pretty random and don't know how do debug it further.
Right now my instinct tells me there is something wrong with our configuration of v5 and the tsconfig.json file, probably because we add and configure the plugin into @quasar/app and not into a webpack config file into the project root.
~Or some kind of incompatibility with @typescript-eslint pre v3~
EDIT: nope, upgraded to v3 and problem persist. Also, clean test project didn't had problems with pre v3
Enabling typescript.profile using the only configuration which avoids the slowdown (see below) produce no output.
Enabling typescript.profile when the problem is present I got this
Parse Configuration:          0.03 s
Create Watch Compiler Host:   0.00 s
I/O Read:                     0.13 s
Parse:                        0.93 s
ResolveTypeReference:         0.04 s
ResolveModule:                0.90 s
Program:                      2.12 s
Bind:                         0.84 s
Check:                        0.90 s
transformTime:              143.05 s

Reverting to v4.1.6 fixes the problem, so I'm fairly sure the problem is in the new major version (or our configuration).
This is how we internally enable TS support into the Quasar webpack chain: https://github.com/quasarframework/quasar/blob/9133883bb3f2a3764b697bad8ffc5e313502c4ea/app/lib/webpack/create-chain.js#L154-L182
Notice we always include vue ts support into the options via webpack chain as
typescript: {
  extensions: {
    vue: true
  }
}

In Quasar configuration we allow the user to customize your plugin options like
supportTS: {
  tsCheckerConfig: {
     // ts-checker options
  }
},

Into our starter kit we automatically setup the configuration depending on initial user choices: https://github.com/quasarframework/quasar-starter-kit/blob/19bd2ec30086d1086b7e44929bed71273d3d41a4/template/quasar.conf.js#L26-L33
Experiments till now
supportTS: true

With no eslint configuration, the problem persist

supportTS: {
  tsCheckerConfig: {
     eslint: {
          enabled: true,
          files: ['./src/**/*.ts', './src/**/*.js', './src/**/*.vue']
        }
  }
},

With eslint enabled and this eslint.files glob patterns the problem is solved but I get the error below error, no lint error is displayed for Vue and TS files and typescript.profile output is not shown.
All this stuff makes me think nothing is actually being processed and that's why there's no slowdown.
Error: No files matching '/home/----/src/**/*.js' were found.
Error: No files matching '/home/----/src/**/*.js' were found.
    at FileEnumerator.iterateFiles (/home/----/node_modules/eslint/lib/cli-engine/file-enumerator.js:272:27)
    at iterateFiles.next (<anonymous>)
    at CLIEngine.executeOnFiles (/home/----/node_modules/eslint/lib/cli-engine/cli-engine.js:761:48)
    at /home/----/node_modules/fork-ts-checker-webpack-plugin/lib/eslint-reporter/reporter/EsLintReporter.js:36:41
    at Generator.next (<anonymous>)
    at /home/----/node_modules/fork-ts-checker-webpack-plugin/lib/eslint-reporter/reporter/EsLintReporter.js:8:71

supportTS: {
  tsCheckerConfig: {
     eslint: {
          enabled: true,
          files: './src/**/*'
        }
  }
},

With eslint enabled and this eslint.files glob patterns the problem persist and I get an error for any extension @typescript-eslint cannot process and for all Vue files.
This last bit is strange, because Vue files are marked to be processed.
One more point on the "there's something strange with tsconfig.json" path.
Ex.
src/assets/icons/my-icon.svg
[unknown]: Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: src/assets/icons/my-icon.svg.
The extension for the file (.svg) is non-standard. It should be added to your existing "parserOptions.extraFileExtensions".
src/components/_fullscreen-dialog.scss
[unknown]: Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: src/components/_fullscreen-dialog.scss.
The extension for the file (.scss) is non-standard. It should be added to your existing "parserOptions.extraFileExtensions".
src/components/my-component.vue
[unknown]: Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: src/components/my-component.vue.
The file must be included in at least one of the projects provided.

supportTS: {
  tsCheckerConfig: {
     eslint: {
          enabled: true,
          files: ['./src/**/*.ts', './src/**/*.vue']
        }
  }
},

With eslint enabled and this eslint.files glob patterns the problem persist.
Miscellaneous info
The project tsconfig is in the project root folder and extends the preset provided by Quasar (https://github.com/quasarframework/quasar/blob/dev/app/tsconfig-preset.json)
{
  "extends": "@quasar/app/tsconfig-preset",
  "compilerOptions": {
    "baseUrl": "."
  }
}

I'm using Vue Composition API package (v0.5 right now), but the clean Quasar project I created uses it too and doesn't seems to be affected.
Expected behavior
Avoid slowdown.
Steps to reproduce the issue
I'm not able to replicate the problem with a fresh Quasar project using latest unreleased packages and starter kit.
Environment

fork-ts-checker-webpack-plugin: 5.0.1
typescript: 3.9.5
eslint: 6.8.0
webpack: 4.43
os: Ubuntu 18.04

Thank you for reporting this issue.
I hope this explanation will help you with debugging:
Starting from version 5, eslint has its own process, separate from typescript checker. It means that eslint configuration should not affect typescript check time (except IO as the file system is shared) and vice versa. It can slow down the time to show issues as it uses Promise.all but not the check itself.
Currently, we don't have implemented profiling for vue extension and for eslint. I can add it - maybe it would help you to find the issue.
Also, I think there is lack of documentation on how to set up eslint for .vue files. By default, the plugin sets:
  options: {
      extensions: ['.ts', '.tsx', '.js', '.jsx'],
  }

which doesn't include .vue files. You can overwrite this by passing it as eslint.options.extensions

Consider that the problem isn't probably related to ESLint.
As I specified, the problem comes up even when linting isn't even enabled.
That let a part, I think I tried the linter with Vue files and I seem to recall that it worked anyway (probably because it got up the eslint configuration).
After a lot of trial and errors, I noticed that removing some ts aliases solved the issues.
In particular components, pages and layouts.
Gonna study a bit what's happening there and what do they have in common

Cool, thanks for digging into this 👏  I would like to help, but it's hard without a reproduction repository.
You can clone the plugin repository and add performance.markStart and performance.markEnd in the vue extension to check if it's a bottleneck. The example usage is in the TypeScriptReporter. Then you can build it (yarn build) and link it to your project (using yarn link).
I have to admit that we don't have end-to-end tests for .vue linting. The assumption is that eslint linter should be capable of doing everything that eslint command is capable of. I'm not a Vue.js developer, so I'm not familiar with the eslint support for .vue files. Is it something that eslint command handles well, but the plugin doesn't?

I added a new edit on previous message: seems like I was doing something wrong in tsconfig, Vue linting works as expected even without the extension options you mentioned.
Right now, I managed to make my project work (and it's blazing fast!) with this configuration:
{
  "extends": "@quasar/app/tsconfig-preset",
  "compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "src/*": ["src/*"],
      "app/*": ["*"],
      // "components/*": ["src/components/*"],
      // "layouts/*": ["src/layouts/*"],
      // "pages/*": ["src/pages/*"],
      "assets/*": ["src/assets/*"],
      "boot/*": ["src/boot/*"]
    }
  }
}

We're gonna release q/app v2 (which will support this package both v4 and v5) and try to gather more examples on the wild to pinpoint the issue.
Also, it will be easier for us to provide some repro when v2 is officially out.
Gonna try what you suggested next week.
If this could ring some bell to you, our current investigative trail (lol) brought us to vue-router files and it's dynamic import syntax for layouts and pages. Components could be affected indirectly because loaded by layouts an pages? Maybe it's something not working related to dynamic imports and dependencies of files retrieved in that way?
Example:
const routes: RouteConfig[] = [
  {
    path: '/',
    redirect: () => ({ name: isAuthenticated() ? 'home' : 'login' })
  },
  {
    path: '/',
    component: () => import('layouts/guest.vue'),
    beforeEnter: redirectIfAuthenticated,
    children: [
      {
        path: 'login',
        name: 'login',
        component: () => import('pages/login.vue')
      },
      {
        path: 'forgot-credentials',
        name: 'forgot-credentials',
        component: () => import('pages/forgot-credentials.vue')
      }
    ]
  },
  {
    path: '/',
    component: () => import('layouts/authenticated.vue'),
    beforeEnter: redirectIfGuest,
    children: [
      { path: 'home', name: 'home', component: () => import('pages/home.vue') },
      {
        path: 'statistics',
        name: 'statistics',
        component: () => import('pages/statistics.vue')
      },
      {
        path: 'registry',
        name: 'registry',
        component: () => import('pages/registry.vue')
      },
      {
        path: 'administration',
        name: 'administration',
        component: () => import('pages/administration.vue'),
        beforeEnter(to, from, next) {
          if (!isAdmin()) {
            next(false);
          } else {
            next();
          }
        }
      }
    ]
  }
];

Hmm... Hard to tell if dynamic imports can be an issue. We use standard TypeScript API, with a custom fileExists and readFile functions which interpret src/some-file.vue.ts as src/some-file.vue (because TypeScript doesn't support custom extensions and import 'src/some-file.vue'; can be resolved only to src/some-file.vue.ts, src/some-file.vue.tsx, or src/some-file.vue.js). I've opened https://github.com/microsoft/TypeScript/issues/38736 proposal to allow compiler plugins for better Vue.js support, so you can give a 👍  there to let know TypeScript team that this is a desired feature.
"app/*": ["*"], looks suspicious for me - maybe it makes other aliases hard to resolve in the TypeScript?

Liked the proposal :+1:
Will let you know next week if I discover something more.
I don't think it's about "app/*": ["*"], the problem was still there when I disabled everything except the 3 paths I mentioned yesterday. Also, it's a pretty popular path alias, even if you usually find it as ~/* or @/* instead

@piotr-oles

Also, I think there is lack of documentation on how to set up eslint for .vue files. By default, the plugin sets:
  options: {
      extensions: ['.ts', '.tsx', '.js', '.jsx'],
  }

which doesn't include .vue files. You can overwrite this by passing it as eslint.options.extensions

I'm hijacking this issue but wanted to say: this ☝
Just randomly noticed my vue files aren't linted and was trying to figure out why. Glad I found this.
It would be nice to add a note in the Vue section of the readme, or even better, add .vue automatically to the default extensions when Vue support is enabled.

It would be nice to add a note in the Vue section of the readme,

Would you like to submit a PR?

Finally got little time to come back at this.  The stats should contain Create Solution Builder Host instead of Create Watch Compiler Host and there are missing other measures. Are you sure that the plugin was configured in the build: true mode?

Some comments on DX:

yarn link give some problems (mostly about "I cannot find module X, Y and Z"), got better luck with yarn add
by using "@semantic-release", it's not possible to extract the version of your code when using the project locally: both package.json > version and the exported version const are placeholders. Not a major problem, but it could cause confusion during development of tools (as Quasar) which tries to detect the version of the package

I tried to add a Vue-related performance measurements, but seems like I'm missing something obvious:

creating a new performance instance into https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/blob/65ab0cc994b627648fb872a8ced33de33808efc3/src/typescript-reporter/extension/vue/TypeScriptVueExtension.ts#L20 didn't work
wrapping https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/blob/65ab0cc994b627648fb872a8ced33de33808efc3/src/typescript-reporter/reporter/TypeScriptReporter.ts#L37 into a markStart and markEnd calls didn't work (random guess, those calls are considered only when a performance.enable() has been called before?)
I cannot understand exactly where those extensions are actually being executed (the previous line only adds it to the extension array)

Meanwhile I enabled all diagnostic options like this
        typescript: {
          extensions: {
            vue: true
          },
          diagnosticOptions: {
            syntactic: true,
            semantic: true,
            declaration: true,
            global: true
          },
          profile: true
        },
        eslint: {
          files: './**/*.{ts,js,vue}'
        },
        logger: {
          infrastructure: 'console'
        }

and got
Parse Configuration:                  0.06 s
Create Watch Compiler Host:           0.00 s
I/O Read:                             0.14 s
Parse:                                2.49 s
ResolveTypeReference:                 0.06 s
ResolveModule:                        1.14 s
Program:                              4.02 s
Bind:                                 2.67 s
Syntactic Diagnostics:                0.23 s
Global Diagnostics:                   0.01 s
Check:                                7.81 s
transformTime:                      307.87 s
Emit:                               155.59 s
Semantic Diagnostics:               163.66 s

I cannot find some marks name in the codebase (transformTime, Emit, etc) so I guess those comes directly from TS via getDiagnosticsOfBuilderProgram method calls.
Notice that Declaration Diagnostics isn't present even if should. Dunno what does this means.
Any idea on how to proceed further?

I'm exploring TS perf issues world, seems there are quite a bit slowdown problems around.
First two I found:

https://github.com/microsoft/TypeScript/issues/35729
https://github.com/microsoft/TypeScript/issues/34119

It may be something related to Quasar types? Does this ring any bell?
Dunno why the problem appears only on v5 and not v4 tho

Fascinating - I hadn't heard of "Quasar types"

I mean, Quasar Framework typings:

https://github.com/quasarframework/quasar/tree/dev/app/types
https://github.com/quasarframework/quasar/tree/dev/ui/types

(Or was it some pun I didn't get :thinking: )

More specific question: any idea on how I can start profiling TS stuff while is being processed by you (or before, or after, anything), both in v4 and v5?

Although it's primitive - simply hacking in console.log statements will get you a long way. It's surprisingly effective even if you feel that "there must be a better way"

Hi team,
+1 on the compilation time (but there is so much involved I'm not sure where it comes from).
Once thing I share with the initial issue is that it reports error for .scss which really should not be parsed by eslint as the default extensions suggest.
I suspect some glob is too greedy.
  new ForkTsCheckerWebpackPlugin({
        typescript: {
          enabled: true,
          configFile: 'tsconfig.json',
          build: true,
          mode: 'readonly',
          diagnosticsOptions: false,
          compilerOptions: {
            skipLibCheck: true,
          }
        },
        eslint: {
          enabled: production ? false : true,
          files: './src/**/*',
        },
      })

[...100s of...]
ERROR in src/views/[...]/index.scss
[unknown]: Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: src/views/[...]/index.scss.
The extension for the file (.scss) is non-standard. You should add "parserOptions.extraFileExtensions" to your config.

On Quasar framework part, we decided to wait a bit to see if someone else bump into this, as I'm just running in circles when trying to debug this problem and we must focus on some other features.
Will come back to this problem in some months and start debugging again!

Just wanted to chime in and bump this.
Also running into ridiculous compile times with latest version & v4 of this.
This plugin seemed fine on 5.2.0 for a while till the project grew, and then some kind of threshold occurred and it exploded in compile time.
tsc builds in under 12s, while this plugin takes ~30minutes now. Been banging the wall for a while now and will just start eating the 10sec recompile times from ts-loader instead of this till theres some fixes. Incremental has no noticable effect on times as well, curiously.
I suspect it may be due to complex circular types, but why the massive discrepancy?
Tried using the latest<EMAIL_ADDRESS>with tsc --generateTrace. Nothing useful from what I can see tsc takes 12sec.
Perhaps if this plugin can support TS 4.1.0's tracing outputs we can delve deeper.
I suspect it may be related to baseUrl being defined, and perhaps some kind of filesystem thing (on an archlinux VM) but refactoring path usage out will take ages.

We use the same API as the tsc --watch so it seems to be a source of the problem

We use the same API as the tsc --watch so it seems to be a source of the problem

@piotr-oles have you looked into supporting https://github.com/microsoft/TypeScript/issues/40124 4.1.0's new profiling outputs?
More info here https://github.com/microsoft/TypeScript/pull/40063
A projects file paths could be mapped to the types.json/trace.json output, then rendered as a ordered list or tree based on costs.
Might even make sense to have a warning threshold for type resolution time to help people understand when a new dependency has a large impact dev-experience wise...

@nfour I've added a support for "generateTrace" in 6.0.0-alpha.2 :)

Good! We're working on Quasar v2 (with Vue3 support) which means we'll have to migrate to 5+ version of fork-ts-checker.
I'll probably have to come back on this problem in next couple months and check if I can finally find the root cause, any additional tracing tool could be useful!

@nfour I've added a support for "generateTrace" in 6.0.0-alpha.2 :)

https://github.com/nfour/ts-rank whipped this up to quickly parse generateTrace and show some useful numbers. Still early tho but I've used it to fix some perf issues already.

For my setup this slow down seems to mainly come from eslint, I guess it doesn't work fine with webpack 5's cache.

Initial build
    Second build

Entire plugin disabled
	54689 ms
	6217 ms

eslint.enabled: false
54045 ms
	16519 ms

eslint.enabled: true
114185 ms
	112230 ms

@IlCallo The newest TypeScript Beta version contains a fix that could potentially address some of these performance issues. Could you test it?

Hey there, you mean TS 4.3 beta? What fix in particular should be useful in our case?
Also, with are in the verge of releasing Quasar v2 (and @quasar/app v3) based on Vue3 and we updated to this package v6 directly.
The project I used for this issue reproduction unluckily still have some blockers while migrating to Quasar v2 so I cannot test it right now.
Since we released Quasar v2 beta, only a person reported this same problem, but he too could not pin-point the problem.
Will try to finish my project migration to Quasar v2 and try it out again

The fix: https://github.com/microsoft/TypeScript/pull/43314 :)

@piotr-oles @johnnyreilly , is the latest version of fork-ts-checker-webpack-plugin compatible with webpack 5 ?

yes, we have e2e tests that uses webpack 5

I believe that this is related https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/issues/612


[Bug]: np.float_ was removed in the NumPy 2.0 release. Use np.float64 instead

What happened?
After switching to a new node pool we started encountering this issue. When using the 0.4.20 version we also see SyntaxWarning: "is" with a literal. Did you mean "=="?. However, when I change the image tag to 0.5.0 I can only see the numpy error.
I can see the second issue is fixed here:

https://github.com/chroma-core/chroma/commit/47447b6f9846fb63cc17d3f458df405387f46127

But I don't find anything related to the numpy issue.
ChromaDB Version
0.4.3
Kubernetes Version
1.27.x
Environment details
AKS
Logs, Kubectl output, Manifests, etc.
Collecting chroma-hnswlib
  Downloading chroma_hnswlib-0.7.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (252 bytes)
Collecting numpy (from chroma-hnswlib)
  Downloading numpy-2.0.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (60 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 60.9/60.9 kB 3.9 MB/s eta 0:00:00
Downloading chroma_hnswlib-0.7.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (2.4 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.4/2.4 MB 115.1 MB/s eta 0:00:00
Downloading numpy-2.0.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (19.3 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 19.3/19.3 MB 103.2 MB/s eta 0:00:00
Installing collected packages: numpy, chroma-hnswlib
  Attempting uninstall: numpy
    Found existing installation: numpy 1.26.4
    Uninstalling numpy-1.26.4:
      Successfully uninstalled numpy-1.26.4
  Attempting uninstall: chroma-hnswlib
    Found existing installation: chroma-hnswlib 0.7.3
    Uninstalling chroma-hnswlib-0.7.3:
      Successfully uninstalled chroma-hnswlib-0.7.3
Successfully installed chroma-hnswlib-0.7.3 numpy-2.0.0
/chroma/./chromadb/utils/embedding_functions.py:584: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if self._task_type is "RETRIEVAL_DOCUMENT":
Traceback (most recent call last):
  File "/chroma/venv/bin/uvicorn", line 8, in <module>
    sys.exit(main())
  File "/chroma/venv/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/chroma/venv/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/chroma/venv/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/chroma/venv/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/chroma/venv/lib/python3.10/site-packages/uvicorn/main.py", line 408, in main
    run(
  File "/chroma/venv/lib/python3.10/site-packages/uvicorn/main.py", line 576, in run
    server.run()
  File "/chroma/venv/lib/python3.10/site-packages/uvicorn/server.py", line 60, in run
    return asyncio.run(self.serve(sockets=sockets))
  File "/usr/local/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "uvloop/loop.pyx", line 1517, in uvloop.loop.Loop.run_until_complete
  File "/chroma/venv/lib/python3.10/site-packages/uvicorn/server.py", line 67, in serve
    config.load()
  File "/chroma/venv/lib/python3.10/site-packages/uvicorn/config.py", line 479, in load
    self.loaded_app = import_from_string(self.app)
  File "/chroma/venv/lib/python3.10/site-packages/uvicorn/importer.py", line 21, in import_from_string
    module = importlib.import_module(module_str)
  File "/usr/local/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/chroma/./chromadb/__init__.py", line 3, in <module>
    from chromadb.api.client import Client as ClientCreator
  File "/chroma/./chromadb/api/__init__.py", line 7, in <module>
    from chromadb.api.models.Collection import Collection
  File "/chroma/./chromadb/api/models/Collection.py", line 7, in <module>
    import chromadb.utils.embedding_functions as ef
  File "/chroma/./chromadb/utils/embedding_functions.py", line 3, in <module>
    from chromadb.api.types import (
  File "/chroma/./chromadb/api/types.py", line 101, in <module>
    ImageDType = Union[np.uint, np.int_, np.float_]
  File "/chroma/venv/lib/python3.10/site-packages/numpy/__init__.py", line 397, in __getattr__
    raise AttributeError(
AttributeError: `np.float_` was removed in the NumPy 2.0 release. Use `np.float64` instead.. Did you mean: 'float16'?

workaround to put in docker_entrypoint.sh
pip install --force-reinstall --no-cache-dir chroma-hnswlib numpy==1.26.4
chroma-hnswlib has badly specified dependencies and new release of numpy 2.0 blown up chroma-hnswlib
Probably more libraries suffer now :)

@glowskir, chroma core package 0.5.1 just released. I'll add the images for that in the chart.

waiting for the release.

fixing with 0.1.20. Sorry for the delay. The issue was the docker entrypoint which reinstalled chroma-hnswlib thus bumping numpy to 2.x


Implement new design for Rancher DevKit landing page

Implement new design as per the XD design by Manuele:
https://xd.adobe.com/view/e891509e-55df-4e11-b6f3-0abad25dae69-bdc2/

Awaiting finalized design from @manuelecarlini


thank you for this plugin

Hello,
little message to thank you for this super useful plugin, just what I needed to correct my focusing errors.
It works with my canon EOS 70D and Lightroom 6.10.1

Hi, Thank you for taking your time to write and send a message of gratitude. I appreciate it. Enjoy the software. Cheers


Add a rosdep key for python-can

This will add a rosdep key to install python-can via pip,
a Python module that provides a suite of utilities for interfacing
with Controller Area Network (CAN) buses.
Documentation: https://python-can.readthedocs.io/en/2.2.0/index.html

I've switched it to use the package manager versions for distros where they're available.

For what it's worth, I'm using this on xenial, for which there isn't a package manager version, so the pip version is the only one that really matters to me. :-)  There are several other instances of keys that have both package manager & pip packages in them, so I was assuming that's acceptable.  I'll go ahead and add arch as well.

Anything else that needs to be done for this?

@tfoote How do you feel about not adding EOL distros here like we've done in a couple other places ?
It would make this set of rule much easier to read.
The resulting set of rules would look like:
python-can:
  alpine:
    pip:
      packages: [python-can]
  arch:
    pip:
      packages: [python-can]
  debian: [python-can]
  fedora:
    pip:
      packages: [python-can]
  osx:
    pip:
      packages: [python-can]
  ubuntu:
    '*': [python-can]
    trusty:
      pip:
        packages: [python-can]
    xenial:
      pip:
        packages: [python-can]

@tfoote - there is no Fedora/EPEL package. I'll put it on my list, though.

@mikaelarguedas  Sorry I missed your comment. I think the extra lines are fine.

Sounds good, if we're ok with providing new rules for EOL distros, I think we should use the apt rule for Zesty instead of the pip one

Sounds good, if we're ok with providing new rules for EOL distros, I think we should use the apt rule for Zesty instead of the pip one

https://github.com/ros/rosdistro/pull/19137/commits/194dc30146ae13566d6e6eae9b998e5c8ea4e46a


generated sw ends with export default require_sw(); and cannot be used

I am using a custom service worker and as soon as I import a custom library in it, the generated sw file ends with
export default require_sw();
It basically wrap my entire code in a module it seems. As a result the navigator cannot understand the export token.
Is it a current limitation of the library ?

@mbret we've this behavior when we use some ancient library on the sw, you can configure rollupFormat: 'iief' on injectManifest pwa option and should fix it: https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/types.ts#L12
I need to add a few new features to the docs...

Completely missed this config and it did solve the problem. Thanks a lot, I should have asked sooner instead of wasting my entire day ^^


Bug fixes, optional cloudflare, almost free lnaddress (1 sat)

Hi! Thanks for this contribution. Please provide a thorough description of your PR.

@callebtc Sorry, first PR here. The PR contains the followings:

Bug fix: cannot send to lnaddresses with subdomains<EMAIL_ADDRESS>but only to<EMAIL_ADDRESS>(same fix as PR #914 that is not yet merged)
Improvement: Do not require Cloudflare to manage an lnaddress domain and make clouflare token and zone_id optional. Updated documentation to describe how to setup DNS without cloudflare
Bug fix: cannot make lnaddress free because of this (#549). So the minimum amount of an invoice is 1 sat.
Bug fix: fixed refactoring done in this merge request because it broke lnaddresses (Bug report #1048)

Feel free to ask if you need more information.

Thanks that's awesome!
However, we need to fix those things in separate PRs so we can be sure to know the cause if something breaks. It's better to work atomically, issue by issue. Would you be up for that and submit new PRs with the individual fixes separated from each other?

Sure, sorry. I'll do it now. I'll not open a PR for the same change as #914 as it's already there.

@skrafft sorry I got this extension now. We can reopen it but there are a few things that I would change.

Please make sure to run make format once before pushing again.

@callebtc I just pushed the necessary changes (including make format)

@skrafft regarding:

Bug fix: cannot make lnaddress free because of this (https://github.com/lnbits/lnbits/issues/549). So the minimum amount of an invoice is 1 sat.

there is a validation error when trying to create a "free" address

for public LNbits servers, how can we prevent that any user create any address?

a regular user could create a legend.lnbits.com domain, map it to its own wallet and start selling/giving away @legend.lnbits.com addresses. Is there anything in place preventing this?

@motorina0 While thinking of a solution for this: "for public LNbits servers, how can we prevent that any user create any address?", I noticed that this plugin allows anyone to create any domain even if it already exists and is in use by another wallet. I therefore suggests 2 things:

Check if a domain is currently in use and validated when creating/updating domains
Use an env variable LNADDRESS_RESTRICTED_DOMAINS that would contain a list of restricted domains for public servers like this<EMAIL_ADDRESS>
Do you think that's enough ?

@motorina0 I just pushed the code for my previous comment. Feel free to tell me if something else is needed

@motorina0, @callebtc I know you have a lot to do, if you need more changes to merge this PR, just ask and I'll do it.

@motorina0, @callebtc I know you have a lot to do, if you need more changes to merge this PR, just ask and I'll do it.

Thanks, no changes required so far, but I plan to add some commits on top of this PR.

The issues around having a solution based on list of public domains in .env far outweighs any drawbacks of just sticking with Cloudflare

@arcbtc Sorry, I'm not english native, I'm not sure I understand the meaning of this sentence. Is the solution bad ?

Bad. Its better to just use Cloudflare

@arcbtc Except not everyone actually wants to use Cloudflare. Do you think it would be better if we added another method to check that you own the domain based on DNS TXT record. We could use dnspython to check a _lnbits.exampledomain.com TXT record which would contain: sha256(wallet_id + domain_name).

@arcbtc Sorry, I'm not english native, I'm not sure I understand the meaning of this sentence. Is the .env solution good or bad ?

@skrafft

we are trying to keep to a minimum the number of configurations that a user has to make in order for spin-up an LNbits instance safely
even if the suggested solution looks simple in the context of this PR, it would slowly make the .env file very large if we take this path, therefore it is not optimal and will not be used
one option discussed here https://github.com/lnbits/lnbits/issues/1035#issuecomment-1321828639 is to allow admin users to manually add addresses. This works fine for small instances that don't use CloudFlare.

@motorina0 No problem, totally understandable. Manually adding addresses would definitely work for small instances. I have some spare time at the moment, tell me if there's anything I can do to help.

Great idea @motorina0, and thanks for R&Ding this @skrafft. We have some "admin only" functionality in satspay extension now, perhaps this is a good excuse to do the same for lnaddress. Am admin could also potentially allow an automated lnaddress for their users. A bit like how WoS does, issue a random lnaddress to users.

So admin toggles on "free lnaddress for all users" (in lnaddress as an admin feature), and when a user open lnaddress they get a free random lnaddress they can make use of

I think @motorina0 's suggestion is a good option for lightning addresses in LNbits on a limited use. I hope that the admin only option will be accessible through the API.
If developers need more flexibliity, they can just simply use the API from lnurlp and build out their own LNaddress capability for multiple domains. (This is what we currently do on https://github.com/bitkarrot/laiseebot. Its ugly but it works)

* one option discussed here [[Feature proposal] Lightning Address for LNURLp/wallet #1035 (comment)](https://github.com/lnbits/lnbits/issues/1035#issuecomment-1321828639) is to allow `admin` users to manually add `addresses`. This works fine for small instances that don't use CloudFlare.

Hi there, what's the status on this PR?

Please remove package-lock.json from the PR :)

Closing this PR since bugs have been fixed and addresses can now be created directly for free by admin. I'll open another PR for the lnaddress module to fix bugs I just found.


Updated the QDK version to 0.18.2109.162713

The tag and the branch created based on that tag are based on a too early commit in history, that is why this PR conflicts with main. Closing in favor of #550.


Add srsly serialization to sections and context graph

If you ask me how it works - the answer is I have no idea. This was one of the worst debug experiences I had but it works. The downside is - after serialization sections don't have the .doc property so I had to refactor the repr you can still access everything else

Tackles #125

Closing to un-do all the format changes and move fixes over to a clean branch


Have Volafile Ripping implemented, question about dependencies...

Alright, so for the past two days I've been basically teaching myself java specifically for the purpose of implementing Volafile.io ripping capability to Ripme.
The problem with enabling Volafile ripping is that it uses javascript to dynamically populate the data in the file column. This means that Ripme's built-in HTTP grabber doesn't work for volafile, because it can't see the javascript generated content.
So, I implemented Selenium and PhantomJS, to open the page, wait until the javascript has loaded the content, then output the page source to a variable and parse it as normal.
I now have it up and working, grabbing all the links and downloading them successfully. Here's the rub:
Because this method requires PhantomJS, all of the users will require PhantomJS to be on their computers in the 'standard' location (Usually on the C drive, in Program Files).
I'm ready to put this up on my fork and submit a pull request, but how can I package PhantomJS with the project so that people don't have to follow a tutorial to get PhantomJS 'installed' and available to be used? Is there a way to have Java download and unpack the PhantomJS Executable in a location relative to the ripme.jar?

A much better option would be to integrate JavaScript into RipMe.

Perhaps so. Right now Ripme uses Jsoup, which is used for page parsing, but it does not support javascript. Selenium's 'HTMLUnitDriver' does support javascript, but it was throwing errors and I couldn't figure them out.  I'm doing the best I can with what I've got...

Maybe they could be fixed together.

Is there any way to get the list of files directly via the json (or otherwise) endpoints that the page downloads to populate the page dynamically?

I agree that adding Selenium and PhantomJS to ripme is overkill. Volafile uses WebSockets as a data exchange. WS will be a challenge in itself to implement, but this approach would be lightweight in comparison.
The below WS address should be established:
wss://volafile.io/api/?rn=xxxxxxxxxx&EIO=3&transport=websocket&t=xxxxxxx

There are four query parameters in the exchange to establish a connection to the WS:

rn - As far as I can tell, this is just a random ten character string matching the regex /[A-Za-z0-9]/. Probably to prevent caching or bots.
EIO - Static value.
transport - Static value.
t - This is definitely increasing sequentially, i'm just not sure how its being calculated. I assume its based on milliseconds. I'm not convinced this value is actually important either though. I think this can be any random value as long as its unique. I'd be curious to see if just returning the time in milliseconds would be enough.

Lfyns51
LfynsgD
LfyntBZ
LfynthI
Lfynu6D
LfynuTF
LfynuTF
LfynvFD

Once the WS session is established, we need to make a request to the WS which will require the following (again, as far as i can tell looking pretty quick):

Room ID - Parsed from URI, no problem.
Checksum #1 - This requires Checksum #2 first. After thats parsed, a request can be made to https://volafile.io/static/js/main.js?c=<CHECKSUM #2>, in the JS file there is a {config.checksum="xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"} value that will need to be parsed as well.
Checksum #2 - This can easily be pared from the HTML on the initial page load - See [A]

[A]
window.config={
            file_max_size:<PHONE_NUMBER>0,
            max_room_name_length: 27,
            chat_max_alias_length: 12,
            chat_max_message_length: 300,
            chat_max_history: 300,
            file_time_to_live: 172800,
            session_lifetime: 604800,
            download_cookie_lifetime: 259200,
            round_up_threshold: 0.2,
            max_concurrent_uploads: 1,
            ui_tooltip_show_delay: 200,
            ui_enable_gallery: true,
            disabled: false,
            private: true,
            name: "xxxxxxxx",
            owner: "xxxxxxxx",
            motd: "xxxxxxxx",
            adult: false,
        checksum2: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx",
        room_id: "xxxxxx",
        title_append: " - Volafile.io ",
        domain: "volafile.io",
        cdn_domain: "volafile.net"
    }


Constraints of type MathOptInterface.ScalarNonlinearFunction-in-MathOptInterface.EqualTo{Float64} are not supported by the solver.

This happens with the new non-linear JuMP modelling, seems to work with the old one
(but the docs say the two can not be combined, and other stuff does not work with the old one)
I'm not sure if this is a JuMP's or SCIP's issue...
using JuMP, SCIP

a = 3
b = 1

model = Model(SCIP.Optimizer)

@variable(model, c[1:b], Int)

@expression(model, d[i=1:b,j=1:a], j <= c[i])

@variable(model, e[i=1:b,j=1:a], Bin)

@constraint(model, [i=1:b,j=1:a], e[i,j] == d[i,j])

print(model)

Constraints of type MathOptInterface.ScalarNonlinearFunction-in-MathOptInterface.EqualTo{Float64} are not supported by the solver.

If you expected the solver to support your problem, you may have an error in your formulation. Otherwise, consider using a different solver.

The list of available solvers, along with the problem types they support, is available at https://jump.dev/JuMP.jl/stable/installation/#Supported-solvers.

 Is a bridge f(x) == b to  b <= f(x) <= b potentially missing?

Isn't this just that SCIP does not support MOI.ScalarNonlinearFunction yet?
But also, @LebedevRI is using the wrong syntax for indicator constraints. It must be:
model = Model()
@variable(model, e[i=1:b,j=1:a], Bin)
@constraint(model, [i=1:b,j=1:a], e[i,j] --> {j <= c[i]})

Isn't this just that SCIP does not support MOI.ScalarNonlinearFunction yet?

FWIW i did indeed have another "snippet" where MOI.ScalarNonlinearFunction support
was the culprit as per stacktrace, but did not manage to reproduce that yet so that i could file an issue.

But also, @LebedevRI is using the wrong syntax for indicator constraints. It must be:

I'm using what is said in the docs:
https://jump.dev/JuMP.jl/stable/manual/constraints/#Indicator-constraints
https://jump.dev/JuMP.jl/stable/tutorials/linear/tips_and_tricks/#Indicator-constraints
... nowhere did i see the --> syntax, although i very much agree that it looks better than =>.

I'm using what is said in the docs:

Suggestions for how to make it clearer then? It says:
Indicator constraints consist of a binary variable and a linear constraint.
The constraint holds when the binary variable takes | the value 1. The
constraint may or may not hold when the binary variable takes the
value 0.

I guess we need to add "You cannot use an expression for the left-hand side.

nowhere did i see the --> syntax, although i very much agree that it looks better than =>.

--> and => are the same thing. No difference. I thought I updated the documentation, but perhaps I didn't.

Isn't this just that SCIP does not support MOI.ScalarNonlinearFunction yet?

Ah my bad I should add this, I wasn't sure if an additional step was needed to make solvers work with the new JuMP nonlinear

I'm using what is said in the docs:

Suggestions for how to make it clearer then? It says:
Indicator constraints consist of a binary variable and a linear constraint.
The constraint holds when the binary variable takes | the value 1. The
constraint may or may not hold when the binary variable takes the
value 0.

I guess we need to add "You cannot use an expression for the left-hand side.

nowhere did i see the --> syntax, although i very much agree that it looks better than =>.

--> and => are the same thing. No difference. I thought I updated the documentation, but perhaps I didn't.

Right. I was more talking about the syntax side of question, but clarifying that
the LHS really must be a variable and not an expression could be clarified a bit.
Though, would an automatic rewrite (to introduce the variable) be a bad thing there?
Thank you for looking into this! I think MOI.ScalarNonlinearFunction support would be awesome.

Just to calibrate expectations, is there any kind of an aspirational timeframe
as to when this kind of functionality might be implemented in this solver?

So i've tried to take a stab at this, but it is not yet apparent to me how this would look like in SCIP.j
(as compared to the Ipopt.jl implementation). If there are any suggestions on how to approach this,
i could try again, but this really could use someone already familiar with the codebase...


Volcano api adapts to the k8s v1.30

cherry-pick from：https://github.com/volcano-sh/apis/pull/126
The volcano api need to adapts to the k8s v1.29。
The pr of volcano adapts to the k8s v1.29: https://github.com/volcano-sh/volcano/pull/3556

/lgtm


Windows version to check on plex server local host

Is your feature request related to a problem? Please describe.
Windows version of Varken to pull data from a windows PMS not running in docker
Describe the solution you'd like
Varken Windows client to push PMS data to Influxdb server for grafana dashboard
Describe alternatives you've considered
Setting up a ubuntu mashine to run varken, but due pms not running in a docker but bare on windows i could not get info.
Additional context
Plex running bare on the windows os instead of in a docker due to a dedicated quadro GPU for 4k transcodes.
therefore varken in linux has issues with pulling data from the windows host, and i request a windows varken client that i can run on the same host to pull the data.

Please read our documentation. Tautulli is required to pull data related to,Plex. Varken does not speak to Plex directly. If you have further issues please use discord.


feat(browsers): generate new image with version node16.17.1-chrome105…

…-ff104-edge

Can you resolve these conflicts?

@jordanpowell88 Resolved - but still has issue with config.yml


Added code coverage.

Description
Adds code coverage (hopefully). I am not seeing file lists, but maybe that takes time? I also added CODECOV_TOKEN from https://app.codecov.io/gh/opensearch-project/opensearch-sdk-py/new to the repo secrets.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I don’t think the token is needed any more for public repos.

I don’t think the token is needed any more for public repos.

I did what their UX told me to do, but you're probably right.


Where are the Kotlin source files found?

Sorry for this rudimentary question but where can I find Kotlin source files (implementations). Like for HTreeMap for example.

Hi,
I found Kotlin sources on specific branches, like branch release-3.0
Regards,
Ionut Mesaros


Declarative Reactive transactions in Firestore

Implement @Transactional support for reactive template and repositories.

I looked at spring-data-mongodb but I'm not sure how exactly it supports declarative transactions.
In https://github.com/spring-projects/spring-data-mongodb/blob/master/spring-data-mongodb/src/test/java/org/springframework/data/mongodb/ReactiveTransactionIntegrationTests.java
I see this:
		@Transactional
		public Flux<Person> declarativeSavePerson(Person person) {

			TransactionalOperator transactionalOperator = TransactionalOperator.create(manager,
					new DefaultTransactionDefinition());

			return transactionalOperator.execute(reactiveTransaction -> {
				return operations.save(person);
			});
		}

Do you have to use TransactionalOperator even if the method is annotated with @Transactional?
I wasn't able to find any cases where @Transactional is used without TransactionalOperator.
@mp911de do you have any recommendations? Also, could you point me to the code that handles declarative transactions? thanks

Once a ReactiveTransactionManager bean is available, you don't have anything to do to make reactive @Transasctional work.

Do you have to use TransactionalOperator even if the method is annotated with @Transactional?

Not in the first place. You could start the transaction via TransactionalOperator and then you call somewhere in the call chain a @Transactional method to propagate the transaction to another method that wants to participate in the same transaction (or open a new one).
Regular Spring transaction propagation apply for reactive transactions as well.

Thanks @mp911de! This great. It means we just need to document the usage.


Update function.rst

When I test the hook function example function in django-river-v3.2.0, it will raise following execption:
'TransitionApprovalMeta' object has no attribute 'source_state'
Traceback (most recent call last):
  ...
    self.callback_function.get()(context)
  File "<string>", line 46, in _wrapper
  File "<string>", line 39, in handle
  File "<string>", line 10, in _handle_my_transitions
AttributeError: 'TransitionApprovalMeta' object has no attribute 'source_state'

I think maybe some api have changed and document have not updated in time. Please check it, thank you.

Coverage remained the same at 80.92% when pulling 085a97b63ed00503ab8ed73f62fa0352451cf9c8 on AngelLiang:patch-1 into f58df9fa931339be6afc7dd99db58590ae27b4c2 on javrasya:master.

Coverage remained the same at 80.92% when pulling 085a97b63ed00503ab8ed73f62fa0352451cf9c8 on AngelLiang:patch-1 into f58df9fa931339be6afc7dd99db58590ae27b4c2 on javrasya:master.

Coverage remained the same at 80.92% when pulling 085a97b63ed00503ab8ed73f62fa0352451cf9c8 on AngelLiang:patch-1 into f58df9fa931339be6afc7dd99db58590ae27b4c2 on javrasya:master.

Coverage remained the same at 80.92% when pulling 085a97b63ed00503ab8ed73f62fa0352451cf9c8 on AngelLiang:patch-1 into f58df9fa931339be6afc7dd99db58590ae27b4c2 on javrasya:master.

Coverage remained the same at 80.92% when pulling 085a97b63ed00503ab8ed73f62fa0352451cf9c8 on AngelLiang:patch-1 into f58df9fa931339be6afc7dd99db58590ae27b4c2 on javrasya:master.

Coverage remained the same at 80.92% when pulling 085a97b63ed00503ab8ed73f62fa0352451cf9c8 on AngelLiang:patch-1 into f58df9fa931339be6afc7dd99db58590ae27b4c2 on javrasya:master.

Hi @AngelLiang ,
It is a very good catch. Thank you for your contribution. Our practice is usually to reproduce this in a test that shows it breaks then fix it. I will try to provide a test in your branch and then merge it.


expose total_changes()

the total_changes() function allows to count all modified rows including those executed as part of triggers (changes() return 0 for triggers).
simply compare total_changes() before and after the query.
This is the easiest way to check whether "instead of triggers" have actually modified rows.

https://sqlite.org/c3ref/total_changes.html

Changes to a view that are intercepted by INSTEAD OF triggers are not counted.


beeper-bridge-manager: 0.12.2 -> 0.13.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/beeper/bridge-manager/releases.
meta.description for beeper-bridge-manager is: Tool for running self-hosted bridges with the Beeper Matrix server.
meta.homepage for beeper-bridge-manager is: https://github.com/beeper/bridge-manager
meta.changelog for beeper-bridge-manager is: https://github.com/beeper/bridge-manager/releases/tag/v0.13.0
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.13.0 with grep in /nix/store/43vaxszrrkqsr5cqn5a811sqkllr1ks5-bbctl-0.13.0
found 0.13.0 in filename of file in /nix/store/43vaxszrrkqsr5cqn5a811sqkllr1ks5-bbctl-0.13.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

beeper-bridge-manager

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/43vaxszrrkqsr5cqn5a811sqkllr1ks5-bbctl-0.13.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A beeper-bridge-manager https://github.com/r-ryantm/nixpkgs/archive/eb2c93bdcb7feec3a7acf98bb89ec423343f88c9.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/eb2c93bdcb7feec3a7acf98bb89ec423343f88c9#beeper-bridge-manager

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/43vaxszrrkqsr5cqn5a811sqkllr1ks5-bbctl-0.13.0
ls -la /nix/store/43vaxszrrkqsr5cqn5a811sqkllr1ks5-bbctl-0.13.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

beeper-bridge-manager

Maintainer pings
cc @heywoodlh for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Working for me:
❯ nix run "github:nixos/nixpkgs/eb2c93bdcb7feec3a7acf98bb89ec423343f88c9#beeper-bridge-manager" -- --version
bbctl version v0.13.0+dev.unknown

@NixOS/nixpkgs-merge-bot merge


Model Timestamp

Should the model also get a timestamp, not just the weights?

Could you elaborate the use case for the timestamp of a model? You mean the time when the model architecture is developed?

No, the timestamp when the model specification was created. Just as additional information, similar to the timestamp of the weights. Or does the weights timestamp has a more concrete use case?

The timestamp was proposed to sort models when we have multiple models (e.g. snapshots) in the same file and we want to use the time stamp to sort them. With the new config format, the timestamp becomes a bit obsolete.
Since the weights are the same set of numbers in different formats, it might make more sense to take the timestamp key out of the weights and add to the models. And we can define it as when the training was done (which might be more important than when the spec was created?). Having a timestamp for each format, which would mean when did we convert the model format, is not very useful.
What do you think?
@constantinpape @FynnBe

I agree, the timestamp is not really necessary any more, we can remove it to simplify the weight definition.

I like @oeway idea of adding it to root as the training time (It doesn't realy matter when weights were converted to a different format). We still can use it for sorting when grouping models (independent of how exactly we group).

This was fixed by #47.


Add unique id to layer on add (to identify which was edited/removed)

Haven't looked too much into the code and all, but I'm hoping there's a way.
I have a list of circles which include pre-loaded and newly added circles. Is there a way to add an identifier to the layer so when removing/editing the layer(s), I can appropriately remove it from my list and perform any additional logic, such as making an API call.

Since this library takes a lot from leaflet.draw, here's a base demo in it to go off of for now:
jsFiddle
I can try and replicate the demo in leaflet.pm. Probably in a couple days.

You can add whatever you want to any layer. It is a regular leaflet layer and adding necessary properties for your own logic is something you can do.
You can do layer.myId = 'lalala' or you use the leaflet ID that is generated by leaflet for each layer layer._leaflet_id.

Thanks Sumit! That worked!
Here's a working demo (open console): jsFiddle


[WIP] Add range extensions for String

🚀
I can't believe we don't have these. They're essential for every project I've worked on...
Checklist

[x] I checked the Contributing Guidelines before creating this request.
[x] New extensions are written in Swift 5.0.
[x] New extensions support iOS 10.0+ / tvOS 9.0+ / macOS 10.10+ / watchOS 2.0+, or use @available if not.
[ ] I have added tests for new extensions, and they passed.
[x] All extensions have a clear comments explaining their functionality, all parameters and return type in English.
[x] All extensions are declared as public.
[ ] I have added a changelog entry describing my changes.

          3 Warnings

:warning:
Consider adding tests for new extensions or updating existing tests for a modified SwifterSwift extension

:warning:
The source files have been modified. Please consider adding a CHANGELOG entry if necessary.

:warning:
This pull request is marked as Work in Progress. DO NOT MERGE!

          4 Messages

:book:
Thank you for submitting a pull request to SwifterSwift. The team will review your submission as soon as possible.

:book:
iOS: Executed 700 tests, with 0 failures (0 unexpected) in 21.239 (22.726) seconds

:book:
tvOS: Executed 663 tests, with 0 failures (0 unexpected) in 4.537 (5.053) seconds

:book:
macOS: Executed 514 tests, with 0 failures (0 unexpected) in 4.617 (4.927) seconds

  Generated by :no_entry_sign: Danger


Add crwlrsoft packages to repos config

There are not a lot of issues in my projects yet, but I'd love to see them on findapr.io when there are some 🙂

Sweet, thanks! 😄


Better autoprefixer

We're using Glamor's one which is fine but requires us to mangle our css-properties into { cssProperties } and back, as well as track mutations in the object and inject more postCSS nodes. What I'd like is to translate the rules that Glamor uses (which itself is vendored from https://www.npmjs.com/package/auto-prefixer) or, preferably, inline-style-prefixer/static into simple PostCSS instructions.
For the record, if there was a way to cut down postcss/autoprefixer to be small enough to include as part of Styled Components, that'd be fine too.

This would mean we're not introducing bugs like #108 (which required the fix in #110)

For the record, if there was a way to cut down postcss/autoprefixer to be small enough to include as part of Styled Components, that'd be fine too.

Note that this mainly means not shipping the huge caniuse database. Maybe @ai has an idea how we could make it tiny and browser compatible?

Because working inside browser is different task, it will be much better to write a new tool for it, in my opinion.
A lot of parts of PostCSS and Autoprefixer can be removed in this case.
But in other hand, with in-browser tool you will not be able to work in prerender case, when you don’t know a browser.
So it is a good question about best architecture in this case.

Radium has you pass the user-agent for out-of-browser auto prefixing

Radium has you pass the user-agent for out-of-browser auto prefixing

Tbh, I'm not too fussed about just adding all reasonable prefixes no matter the browser. Sure, it doesn't help, but instead of having three hundred lines of logic to determine which prefixes to add based on a user agent string I'd much rather just inject thirty lines of unnecessary CSS.

@mxstbr fair enough argument. I made the same argument in Radium when they were looking at it https://github.com/FormidableLabs/radium/issues/201#issuecomment-146044392
For inline styles it made more sense because styles could be repeated much more frequently. They did mention other issues I wasn't aware of at the time that might be worth reading in that thread.

I'm also +1 for adding all prefixes rather than doing something UA-based. inline-style-prefixer/static is great, highly recommended.

The issue with both inline-style-prefixer and glamors autoprefixer.js (what we use at the moment) is that they auto-prefix objects. So what we're doing at the moment is converting our CSS to JS objects just to autoprefix it and then converting it back – pretty useless and unnecessary step. So what we really need is a tool that'll add prefixes to strings of CSS!

Hello,
I have been looking into a better way of prefixing and I feel like using document.body.style might be a good solution.
Here is what document.body.style looks like on Chrome OS X
At runtime, we could export all the keys that start with 'webkit', 'Moz', convert them to kebab-case, extract the un prefixed value and build a substitution table we can use to auto prefix.
Of course this is only theoretical :) But it would avoid UA detection in favor of feature detection.
Any thoughts ?

Huh that sounds very interesting @fdidron, do you want to take a stab at building a replacement?

@mxstbr challenge accepted :)

Here is a first stab at it https://github.com/fdidron/styled-components/commit/54bcb86d4ad41ee043aee2910862311503db312f
Disclaimer, it's only tested on Chrome and Safari on Mac OS X and not united tested (yet :) )

This looks really promising @fdidron! This won't prefix things like ::-placeholder though, right?
Maybe @ai has some insights how we could verify this works for most cases?

Yup would love some insight on this. Right now it doesn't support Opera's old prefix, but we can fix that easily.
Another issue is SSR, I think it would need to fallback on autoprefixer for that.

FWIW, (related I guess), I just notice that filter: grayscale(100%); isn't being properly prefixed as -webkit-filter: grayscale(100%);

No unfortunately, and it's not working with Opera's old prefix but this
could be easily fixed.
On Sat, Oct 22, 2016, 7:28 PM Max Stoiber<EMAIL_ADDRESS>wrote:

This looks really promising @fdidron https://github.com/fdidron! This
won't prefix things like ::-placeholder though, right?
Maybe @ai https://github.com/ai has some insights how we could verify
this works for most cases?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/111#issuecomment-255520572,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABw10tv-Zhjt3w_q9garIl-8nI4AWoOfks5q2eVHgaJpZM4KZi8O
.

--
Kind regards,
Florian Didron
Nakabayashi bldg 2F, 2-11 Kandatacho, Chiyoda-ku,
Tokyo 101-0046, Japan http://www.111studio.jp
Tel: +81-(0)50-5830-7183 Fax: +81(0)50-3488-7768

As per #158
position: sticky;

should be prefixed in Safari as:
position: sticky:
position: -webkit-sticky;

http://caniuse.com/#feat=css-sticky

We now use inline-style-prefixer (as of #208 being merged, not yet released), can we close this @geelen?

https://github.com/rofrischmann/inline-style-prefixer/issues/103

Sorry for asking, but how do I get this to work? styled-components doesn't solve it automatically …

It does solve it automatically, eveyrthing is automatically previxed @emilbruckner. If something isn't that's a bug, please open a new issue!


Apollo not working on vue 3.0.0-rc.13

Hello i install nuxt/apollo and i add modules to nuxt.config.ts but when i configure apollo i have this error.

How can fix it?

@drucinsky I suspect that may just be due to the pertinent types for the module not being generated as yet. Are there errors logged to the console when you start the development server?

I had the same problem and fixed it by first generating the types by starting the dev server and then restarting the typescript language server.

Restart TS server working, thanks!


Take in Secrets Manager Secret ARN for wr.db.get_engine parameters

Is your idea related to a problem? Please describe.
The awswrangler.db.get_engine function creates a SQLAlchemy Engine for the given host, port, user, password, etc. My code gets these parameters by reading a secret (specified by ARN). It would be nice if I could just pass a secret ARN to awswrangler, instead of having to get it myself and unpack all the values for the get_engine function.
Describe the solution you'd like
Be able to pass a secret ARN to the get_engine function. It would extract default values for the db_type, host, port, database, user, and password arguments from it. If any of the arguments are specified, they would override the values from the secret.

Hey @kinghuang, thanks for reaching out!
Well, what about store your connections attributes into the Glue Catalog Connections? Then you can use wr.catalog.get_engine() like in this tutorial.
You can keep your connection stored there even when it will be used outside glue jobs. We prefer the glue catalog than secret manager in this case because we don't need to rely in an arbitrary attribute structure like an json stringfied. In addition to that the Glue Catalog will also give you the option to test tour connections directly from there, it is quite useful.

Well, what about store your connections attributes into the Glue Catalog Connections? Then you can use wr.catalog.get_engine() like in this tutorial.

Just to clarify, should the connection information be stored as JDBC credentials?
I'm pretty sure that's the case, but I didn't find that explicitly stated in the docs, and it's a little counterintuitive (JDBC != python).
On a related note, would the glue catalog approach work for RDS proxy connections?

We have some connection info in the Glue catalog, too. However, RDS, Redshift, and DocumentDB credentials stored in AWS Secrets Manager get automatic password rotation. There's a defined format for the data that includes details like the engine, host, port, username, password, etc.
I tend to have all the master credentials stored in the AWS Secrets Manager. It wouldn't make sense to place them in Glue.

Quick note about our fresh new version 2.0.0:
Breaking changes

sqlalchemy and psycopg2 dependencies replaced by redshift_connector and pg8000
All wr.db.* functions was distributed into wr.redshift.*, wr.postgresql.* and wr.mysql.* (Tutorial)
Redshift COPY and UNLOAD function was refactored into wr.redshift.* (Tutorial)
wr.catalog.get_engine() was replaced by wr.redshift.connect(), wr.postgresql.connect(), wr.mysql.connect() (Tutorial)

@kinghuang let's address that in the version 2.1.0.
What format do you prefer store the connection properties inside secret manager? Regular JSON?

The secrets manager has a setup wizards for RDS instances and arbitrary non-RDS database instances

This is the format that is generated if you store a password for an existing RDS instance via the secrets manager GUI

This is the format if you store credentials for a non-rds database:

I'm having a little trouble finding the docs page for this. But, @fitzoh shows it in the screenshots!

It is already in a development branch. Could you guys give it a try?
pip install git+https://github.com/awslabs/aws-data-wrangler.git@feature/secrets-manager

e.g.
 con = wr.redshift.connect(secret_id="aws-data-wrangler/redshift", dbname=dbname)
 df = wr.redshift.read_sql_query("SELECT 1", con=con)
 con.close()

p.s. Also has similar support for wr.postgresql.connect() and wr.mysql.connect()

p.p.s Also added support for the dbname argument to overwrite the stored one.

Released on version 2.1.0


Cardinalities of LM and compression model don't match

I'm trying to test training from scratch, using 48khz stereo audio, and I'm hitting the error:
AssertionError: ("Cardinalities of the LM and compression model don't match: ", 'LM cardinality is 2048 vs ', 'compression model cardinality is 1024')
Where (or how) can I set the LM cardinality?

Okay, I found it in a yaml:
transformer_lm:
  n_q: 4
  card: 1024       # <-- Here!

Fixing this got me to a new error about number of codebooks which, digging around further, was connected to n_q.
I fixed that and moved on to a new error:
File "/home/james/src/somms/audiocraft/audiocraft/modules/codebooks_patterns.py", line 334, in __init__
    assert len(self.delays) == self.n_q
AssertionError

I see this is connected to codebooks_patterns.py, but I'm not sure how to set this. More generally, does anybody know how to get an LM that will work with 48khz stereo from Facebook/encodec_48khz?

Okay, this seems to be solved with:
codebooks_pattern:
  modeling: parallel
  delays: 16

New error: ValueError: The input length is not properly padded for batched chunked decoding. Make sure to pad the input correctly.
Is padding handled by the data provider or in the LM?

Okay, my audio is in ~44s segments, and it gets me one step (maybe) further using:
dataset:
  batch_size: 12  # 2 GPUs
  sample_on_weight: false  # Uniform sampling all the way
  sample_on_duration: false  # Uniform sampling all the way
  segment_duration: 1.0          # <--- this
  min_audio_duration: 1.0.      # <-- and this

but... new error: AssertionError: Scaled compression model not supported with LM.

I think the model you are trying to use won't work (I'm guessing the public stereo EnCodec model?)
Regarding this message: "The input length is not properly padded for batched chunked decoding" it is a bit strange, can you provide a more complete traceback ?

Yes, I've been informed that the likely reason is because it uses a "scaled" EnCodec model, where each token also has a normalization factor. So you can't just grab the sequence of tokens, but also need the normalizations, which the LM isn't learning.
Regarding the padding error, it's related to the overlapping of chunks in the 48khz encodec model. I noticed the 32khz model doesn't have any overlaps. Printing the input_length, chunk_length, and stride from encodec I get:
input_length: 960000, chunk_length: 960000, stride: 960000
Whereas from the 48khz model I get:
input_length: 1440000, chunk_length: 48000, stride: 47520, with no way (I can find) of manually setting the chunk_length and stride. Of course, I'm assuming I wouldn't want to anyway, since it's obviously set that way for a reason (the 48khz model uses an overlap, whereas the 32khz does not).


Move Email File Activity and Email URL Activity to Application category

(spun off from #905)
Email Activity are much more based on the Application layer. The focal point of those logs are not the network transaction, but what the overarching applications are actually doing.
We are proposing to move these classes under the 'Application' category, which they are more appropriately suited.
Note: Doing so in a non-breaking manner will require class deprecation.

We deprecated both of these in #1259


atlas update

About the PR

add a drain to the freezer, fixes #28482
give atmos canisters lmao

bruh

@Emisse


Release omero 5.6.6

Add entry for 5.6.6
Added link to the new property so the documentation will need to be released before so the linkcheck can be green

Lots of doc failures in the linkchecker, are we still syncing versions to docs.openmicroscopy.org or should these be adjusted to point to omero.readthedocs.io ?

External link https://www.springernature.com/gp/authors/research-data-policy/repositories/12327124 failed (status code 404)

From https://web.archive.org/web/20170729172856/https://www.springernature.com/gp/authors/research-data-policy/repositories, it looks this content has been migrated to https://www.springernature.com/gp/authors/research-data-policy/repositories-bio/12327160

Build is green, merging


In Barchart, options doesn't allow stacking over y-axis.

Here is my code,
let chartData = {     labels: ["January", "February", "March", "April", "May", "June", "July"],     datasets: [         {             label: "My First dataset",             fillColor: "rgba(220,220,220,0.2)",             strokeColor: "rgba(220,220,220,1)",             pointColor: "rgba(220,220,220,1)",             pointStrokeColor: "#fff",             pointHighlightFill: "#fff",             pointHighlightStroke: "rgba(220,220,220,1)",             data: [12, 19, 3, 5, 2, 3]         },         {             label: "My Second dataset",             fillColor: "rgba(151,187,205,0.2)",             strokeColor: "rgba(151,187,205,1)",             pointColor: "rgba(151,187,205,1)",             pointStrokeColor: "#fff",             pointHighlightFill: "#fff",             pointHighlightStroke: "rgba(151,187,205,1)",             data: [1, 10, 2, 9, 2, 13]         }     ]   }; ![imageedit_2_2139895953](https://cloud.githubusercontent.com/assets/7542464/20626418/96a64246-b33f-11e6-91ba-eecf12673fa9.png) ![imageedit_2_2139895953](https://cloud.githubusercontent.com/assets/7542464/20626430/a300865a-b33f-11e6-8d2f-daaf65173289.png)
var chartOptions = { 			enabled:true, 			scales: { 			       xAxes: [{ 			       		 stacked: true 			       }], 			       yAxes: [{ 			           	stacked: true 			       }] 			   }   		}
And here is how I'm implementing JSX.
<Bar data={this.state.chartData} options={chartOptions} width="600" height="250" redraw/>
Issue is even though we set yAxes' stacked to true, it still shows bar groups. I want each dataset to stack over one another for a given interval in my case.

+1

The same problem

Solved #160

Thanks @PashaKoval!


Revert "STOR-1065: Rework sidecar bindings to bind common ClusterRoles"

Reverts openshift/azure-disk-csi-driver-operator#84

/lgtm

Based on feedback from @jsafrane we believe it's best to revert all changes related to this jira that went into the affected payloads.
/override ci/prow/e2e-azure
/override ci/prow/e2e-azure-csi-extended
/override ci/prow/e2e-azurestack-csi
/label approved

/label jira/valid-bug


System Configs - Creating a  template is cumbersome

Creating a system config template is currently a little cumbersome. Current process:
# Track file, but  need to set the hostname to what you want the template to be called
# otherwise when creating template you get an empty repo
system_configs track --hostname <template_name> <file>

# Create template using install (which is semantically confusing)
# Need to set hostname so gets correct files
system_configs install --template <git-relative-url> --hostname <template_name>

# Sync with hostname set to template name
system_configs sync --hostname <template_name>

A few potential avenues for improvement:

Create a template sub-command with its own sub-commands to do anything to do with templates (install, create, etc.):

system_configs template install <arguments>
system_configs template create <arguments>

Create a create template sub-command specifically for dealing with template creating: system_configs create_template <arguments>

Making these improvements could be done alongside #20

@DasGuna for your reference

@Timothy-Morris if you are looking for something to do during "downtime" feel free to check out this issue and #20 as well. #20 is first primarily a discussion, but could become a day or two worth of work.


Reference predefined variables in custom variables

I have a variable TAG, which content is predefined variable: $(Build.RequestedForId).
variables:
- name: TAG
  value: $(Build.RequestedForId)

In commands, TAG could be correctly converted to the final value (i.e. the value of the predefined variable).
However, in displayName, it couldn't.
E.g.
steps:
- bash: docker build -t test:$(TAG) -f Dockerfile .
  displayName: 'docker build test:$(TAG)'
  workingDirectory: $(Build.SourcesDirectory)

The scripts running in bash is correct:
docker build -t test:xxx -f Dockerfile .
But the display name of the step is wrong:
docker build test:$(Build.RequestedForId)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9ffebdc8-521c-44b5-cde4-4abdc1bd6f18
Version Independent ID: dc0effda-6d93-62aa-64c5-4e6f283b0826
Content: Predefined variables - Azure Pipelines
Content Source: docs/pipelines/build/variables.md
Product: devops
Technology: devops-cicd
GitHub Login: @andyjlewis
Microsoft Alias: alewis

In addition, not only the nested variables will not be expanded in displayName, but the dynamic variables set by logging command cannot be expanded in displayName either.


Some names in contributors.html are not in accordance to the style.

Can I fix this ?

Please attach label bug and hacktoberfest

I'll work on this

Fixed with #906

Great work


Adding 1-25 BR to release-0.14 branch

Issue #, if available:
Description of changes:
Auto-cherrypick didnt work so these are the same changes from this PR: https://github.com/aws/eks-anywhere-build-tooling/pull/1798 minus the ami release version since that isn't in 0.14 bundles
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


Initial screen shows nothing

The initial screen shows nothing. My guess is the view hasn't been created yet and thus even if we try to get the drawing cache, it will just give us nothing.

Last commit should fix this issue.


Create abs, absDot and Corerct functions for Vector2d

Abs() => Get the absolute value of the vector
AbsDot() => The absolute dot product
Correct() => Corrects any nan values

Create unit test for all functions.
Did all checks and tests.
These functions intend to solve issue #71
Signed-off-by: Felipe Ximenes<EMAIL_ADDRESS>

After creating the pull request the following CI checks does not passed:
Ticket opened / Add ticket to inbox (pull_request)
Action:   opened
sha:      d641c46767ef7b5c23c60ce4562043eed42fba1c
ref:      refs/pull/143/merge
Labels:
owner:    ignitionrobotics
repo:     ign-math

Dump context
Dump Payload
==================================================

Error: Input required and not supplied: GITHUB_TOKEN
    at Object.getInput (/home/runner/work/_actions/technote-space/create-project-card-action/v1/node_modules/@actions/core/lib/core.js:78:15)
    at Object.exports.getAccessToken (/home/runner/work/_actions/technote-space/create-project-card-action/v1/node_modules/@technote-space/github-action-helper/dist/utils.js:66:47)
    at Object.exports.getOctokit (/home/runner/work/_actions/technote-space/create-project-card-action/v1/node_modules/@technote-space/github-action-helper/dist/utils.js:67:106)
    at /home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:27:66
    at Generator.next (<anonymous>)
    at /home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:8:71
    at new Promise (<anonymous>)
    at __awaiter (/home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:4:12)
    at run (/home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:19:19)
    at Object.<anonymous> (/home/runner/work/_actions/technote-space/create-project-card-action/v1/lib/main.js:29:1)
##[error]Input required and not supplied: GITHUB_TOKEN

Ubuntu Bionic CI / Ubuntu Bionic CI (pull_request)
Unexpected input(s) 'script-after-make', valid inputs are ['entryPoint', 'args', 'github_token', 'apt-dependencies', 'codecov-token', 'cmake-args']
Looking the errors messages, I can't found the reason why the checks failed.

I can't found the reason why the checks failed.

That's a problem with our infrastructure, don't worry about it.


Canonical form

feel free to close PR or request changes, but here as a PR in case it's helpful

Thanks for the tests.  If it's OK, I'll move some code around to match what I was trying to describe.

yep!  And I'll take note and try to learn from you! :)
On Wed, Feb 28, 2018 at 2:42 PM, Keith Alcock<EMAIL_ADDRESS>wrote:

Thanks for the tests. If it's OK, I'll move some code around to match what
I was trying to describe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/143#issuecomment-369393192, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFIniVeZCyJGJ8zMiWHmhUENLCvh2EDNks5tZchYgaJpZM4SXYYx
.

Usually I would wait a day before messing with people's stuff, but we're in a hurry...  Common functionality remains in the base class and custom functionality is pushed down to derived classes, which obviates the need for the case statement.  You're welcome to change protected back to private.  I'm in the "private is premature pessimization" school, but it probably won't be important here.  Still, I could not resist.

Thanks Keith!!
On Wed, Feb 28, 2018 at 3:23 PM Keith Alcock<EMAIL_ADDRESS>wrote:

@kwalcock approved this pull request.
It still passes, but adjust my adjustments as needed. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/clulab/eidos/pull/143#pullrequestreview-100252856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFIniZm88cr1hSqIbJqnhyaiyzUEI7yJks5tZdHPgaJpZM4SXYYx
.


Fix incorrect stack tops with hidden/unhidden descendent chains and colour mismatches

Fixes an issue where colours were sometimes coming out slightly wrong, for one of two reasons:

The analysis pre-calculation mishandling multiple hidden filters
Flamegraph colour calculations using a static value for the heat of the hottest frame which wasn't updated on exclusion changes

This also reduces the number of times the stackTop calculation is called, updating a property once each time the relevant data changes in a new dataTree.update() method, then having everything just look up this property, not re-calculating.
To illustrate, before, particularly after changing exclude filters, we could have big mismatches between the stack bar colours and flamegraph colours, and frames with the same amount of apparent stack top having slightly different colours and visa versa:

After, they're consistent:

The "Review changes" commit is following an in-person review by @jasnell

Last screenshot showed how sometimes it's possible for the sort order to end up out of sync after a change to the exclude set; this last commit fixes that:


🐛 Bug: Dummy Park and Ride Bus Routes Distort First Wait Time Estimates

Describe the bug
To simulate parking capacity constraint at rail stations in TM2.2.1, dummy bus routes are used to move passengers from an access node to the rail station. One short-coming of this approach is that the first wait time for park and ride movements is recorded as the wait time on the dummy bus route, rather than the rail station. Because the wait time of the dummy bus route is intended to serve as a proxy for the time needed to search for a parking space, this time is generally much lower than the first wait time for riding the rail service. While the resulting paths are represented accurately, the first wait and transfer wait skims are not recorded accurately. Specifically, the first wait time is that of the dummy bus route, rather than the first rail service, and the wait time for the rail service is recorded in the transfer wait time skim. (The number of boardings is recorded directly, as boardings on the dummy bus route are removed from the boardings tally).
Progress:

[x] Sufficient information provided
[x] Cause identified/found
[x] Test developed/identified
[x] Approach determined
[ ] Test passes

To Reproduce
Examine a debug path trace for a trip that goes from an infrequent rail station, say Gilroy, to a destination on the rail line, say 4th and King. The resulting skim will show a very low first wait time and a reasonable transfer wait time, even though the path only records a single boarding.
Failing tests

[ ] No applicable test failed, need to create.
[ ] other...specify

Triggering line of code
N/A
Thoughts on resolution
If possible, the skims should record the first wait time, the second wait time, the third wait time, and all other wait time in separate skims. We can then replace the first wait time with the second wait time for outbound park and ride paths, and then calculate correct first wait time and transfer wait time skims for these paths.
Full stack trace
N/A
Environment
N/A
fyi @i-am-sijia, @yueshuaing, @AshishKuls, @arashasadabadi, @lmz

Addressed in https://github.com/BayAreaMetro/travel-model-two/pull/63/commits/f203ce856a1ba0a0a0b6adc2b37ad7d82bb5a8f1. For now, we decided to use half the transfer wait time as first wait in the small number of cases when transfers are present on park and ride paths. Additional QA/QC of the UEC changes will be added here. FYI @arashasadabadi


E713 Settings should be Setting

E713 Settings should be Setting.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 60025def-004a-97b9-be6e-a2678e0b4461
Version Independent ID: 51e386c5-e9cf-f900-ba27-1479709f8186
Content: Segoe MDL2 icon guidelines - UWP applications
Content Source: windows-apps-src/design/style/segoe-ui-symbol-font.md
Product: uwp
Technology: design
GitHub Login: @hickeys
Microsoft Alias: hickeys

This says Setting. Likely someone else changed it between the time this issue was opened and now. Thank you for the report.


Add Interface names to type inspection status line

This is a small change that causes :EnInspectType to display all of the types the inspected type extends/ implements.

Nice, LGTM!


Windows: cannot run notebook

I ran into a problem which has similar traceback as conda/conda#8171 . Despite that issue being marked as resolved and that I am using the latest release of conda 4.6.14, it still happened.
Tried some other things I found on the Internet like uninstalling and re-installing pyzmq and jupyter with either conda or pip. Didn't help.
In my case, the activate command gave some warnings about not able to find vc/vcvarsall.bat, which might or might not be related, as I could still use the environment.
At this point, I have wasted enough time on this, and thus my workaround is to re-create the tutorial enviroment without jupyter, jupyterlab, and nodejs, but add ipython to the YML, then run the examples inside a good ol' IPython session.

Oh my, I'm sorry you had to encounter this, @pllim. Yes, IPython should work. Should you decide that you'd like to use Jupyter again, I hope Binder serves as a feasible option for you.
I'm going to close this issue for now, but please feel free to re-open again if needed.

No problem. I opened this issue mainly so other Windows users can come here for group therapy. :smile:

Also having this issue now all of a sudden after a windows reboot


Add Warp

https://www.warp.dev/privacy

Telemetry
When Warp comes out of beta, telemetry will be opt-in and anonymous.
But for our beta phase, we do send telemetry by default and we do associate it with the logged in user because it makes it much easier to reach out and get feedback when something goes wrong.

https://docs.warp.dev/getting-started/privacy

Telemetry: What usage data are you collecting and why?
For our public beta, we collect usage data (only metadata never console input or output) to measure feature usage, discover product friction, and improve Warp by guiding what we prioritize. See below for an exhaustive list of the metadata we collect.
When Warp comes out of beta and enters General Availability, telemetry will be opt-in and anonymous.

Uses Segment.io : https://github.com/warpdotdev/Warp/issues/1346


Updates azdataGraph package version to 0.0.20

This PR updates the azdataGraph package version from 0.0.19 to 0.0.20
This update truncates long vertex labels, so they don't overlap with other labels

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.329%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27596

Relevant Lines:
60940

💛  - Coveralls


Change AWW => KWS

I changed the directory names, #defines, and variables from audio_wake_words / aww to keyword_spotting / kws.

@jeremy-syn there are a number of changes to anomaly_detection files here. Can you pull from master and resolve those issues first? Thanks!


jQuery change event not working on dateTime input

So, the following 2 lines were working with version 3, but when I upgraded to version 4, all events attached to dateTime input gets ignored.
			startDateInput.change(function () { alert('working'); }); 			startDateInput.change();
Under the hood I'm delegating dp.change event to trigger change, but input doesn't respond anymore.

I've commented one line in .js file line 1270 and started to work again. I'm not sure what are the consequences of leaving this line commented out.
            change = function (e) {                 var val = $(e.target).val().trim(),                     parsedDate = val ? parseInputDate(val) : null;                 setValue(parsedDate);                 //e.stopImmediatePropagation();                 return false;             },

Right now, I see what happens. If text is edited by hand (not picked from list), on leave - change event is triggered two times: by dp.show -> change & manually added change.
It seems to work correctly if I stop change propagation only when it was originally initiated by dp event.
				if (e.originalEvent != null) { 					e.stopImmediatePropagation(); 					return false; 				}


move to go 1.13 + upgrade golangci-lint version used

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   20.83%   20.83%
=======================================
  Files          20       20
  Lines        1262     1262
=======================================
  Hits          263      263
  Misses        997      997
  Partials        2        2

Flag
Coverage Δ

#go
20.83% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e6c0ea...d0b3f4a. Read the comment docs.


[Proposal] Add helper Array Flatten Keeping Keys

This would keep the keys but format them as dot notations.
I basically needed this and if it already exist then 🤷♂
If it does not exist then the test shows some of the goals
tests/Support/SupportArrTest.php:210
All of this from https://stackoverflow.com/questions/9546181/flatten-multidimensional-array-concatenating-keys/9546215#9546215
btw one minor test fix to origin tests here

No plans to add to core. Free to add to your own application though!

worth a try, thanks


lncli: Use EOF as a terminator instead of the newline in lncli unlock --stdin command

Change Description
Replaces #5638
Closes #5584
Steps to Test

Password with new lines at the end: Warning Printed since echo prints a new line by default at the end of the echoed string.

ubuntu@carol:~/lnd$ echo "test" | lncli unlock --stdin
WARNING: Password contains leading ortrailing newline characters and they will not be trimmed.
[lncli] rpc error: code = Unknown desc = invalid passphrase for master public key

Password with new lines at the beginning: Warning Printed.

ubuntu@carol:~/lnd$ echo "\ntest" | lncli unlock --stdin
WARNING: Password contains leading ortrailing newline characters and they will not be trimmed.
[lncli] rpc error: code = Unknown desc = invalid passphrase for master public key

Valid Password with no new lines at the beginning/end: No Warning Printed.

ubuntu@carol:~/lnd$ echo -n "test" | lncli unlock --stdin
lnd successfully unlocked!

Approach
graph TD;
    A[Is password given from stdin?] -->|true| B[Copy password from stdin];
    B --> C[Create buffer];
    C --> D[Copy stdin to buffer];
    D --> E{Error during copy?};
    E -->|yes| F[Return error];
    E -->|no| G{EOF encountered?};
    G -->|yes| I[Trim buffer from carriage returns];
    I --> J[Check for leading or trailing newline];
    J -->|yes| K[Issue warning];
    J -->|no| L[Continue];
    K --> L;
    L --> M[Finish];

Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

This PR review has been inactive for a while. It seems that the issue it addresses is controversial and may have potential side effects. I will close the PR for now, but we can reopen it if there is renewed interest.


Fix markdown editor UI issues

This PR fixes an issue with the Markdown Editor when on responsive style it hides the editor from the view.
This also hides the Scroll Sync checkbox when the Split Editor is not showing both the Editor and Preview.
Original:

Changes:

:tada: This PR is included in version 3.3.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Documentation: "ACT Log Line" regexes do not match for types with hex A-F

Referencing this documentation:
https://github.com/quisquous/cactbot/blob/main/docs/LogGuide.md#line-30-0x1e-networkbuffremove
When type contains an A-F hex character (e.g. NetworkBuffRemove=0x1e), the regex has it as lower case, but ACT emits it as upper case in the log, so the regex doesn't match.
I noticed the doc said pull requests accepted, but reviewing the history made me think that the regexes are machine generated not hand-written, so I hesitated to submit a PR with hand-tweaked changes.
You could potentially protect yourself from ACT changes by making the type field case insensitive, e.g. (?<type>(?i:1e)).

[01:40:12.325] StatusRemove 1E:4D7:Ermutigen:0.00:106B2E4F:NAME NAME:106B2E4F:NAME NAME:00:77984:77984
This is from latest beta where the IDs where capitalized


[QUESTION] Where is the code of tgtd with bs_type longhorn ?

Question
Hi,
It seems you extend tgtd with new backend type 'longhorn'.
where is the code of tgtd with that extension?

Hi @cocalele
Here is https://github.com/rancher/tgt/blob/longhorn_oct2019/usr/bs_longhorn.c
We have our repo for developing tgt.


Dont include all of DifferentialEquations.jl

DifferentialEquations is a kitchen sink package, and blows out load and compilation time be a few minutes.
We should instead include just the packages directly needed here.

Done


I want to get and set a PFS service URL provided via an URL parameter

User Story
As Chris I want to get and set a PFS service URL provided via an URL parameter, so that I do not need to search for a PFS manually
Acceptance criteria

Parameter could also be transferred to the SDK
PFS Service get's stored for each token network

Tasks

[ ] Research best way to fetch PFS service URLs

Closing as I don't see a reason right now why Chris would want that after we have implemented reading the PFS from the service registry ;)


basic status page

fixes #201
Just dumping the data for now.

I don't envision its state being needed anywhere else and it will be non-interactive.
Perhaps we can keep it this way for MVP and move it later if we feel the need to?  For components that are fully standalone, I like keeping it modular.

we can display some numbers on home page user_players, tracked_players, matches_last_day, parsed_matches_last_day

We could, but that would come with some additional cost (having to make a /api/status call).  If we wanted that data, we should probably instead return it in the /api/metadata call that we are already making.


[Bug] List widget selection

Description
Can't open property pane of list widget because padding around list items are too small

To solve this, I am now opening the property pane of the list on clicking the container inside the list widget.


How is Dropzone coming along

Just curious, as I see some new dates on Dropzone. Is it almost ready for primetime? Anything I can do to help out here? I am looking to upload a file directly to S3. Nothing too crazy!

Hey, it's mostly done. I plan to tweak few things and release it with v0.8.0 later this week.


It is hard to figure out how to read a text file using docs

Description:
I want to read a text file in to a string. Search BBE and API docs for file didn't find any example on how to read a file. Then tried using the io package but it only gives a binary output. later on got to know that you have to use Charactor I/O.
May be it will help to rename BBE Charactor I/O guide to reading and writing to files. And to provide a high level API to read and write files.
Affected Versions:
ballerina-1.0.0-beta-SNAPSHOT

Fixed via [1].
[1] https://github.com/ballerina-platform/ballerina-lang/pull/19618


Refactor and clean up System APIs

As we are moving closer to 1.0 release, organization and cleaning up the APIs as follows:
Changing the API endpoint as follows:

Previous Endpoint
New Endpoint

api/v1
Removed

api/v1/services
Removed

api/v1/util/entities/count
api/v1/system/entities/count

api/v1/util/services/count
api/v1/system/services/count

api/v1/settings
api/v1/system/settings

api/v1/config
api/v1/system/config

Swagger oganization

APIs spread out across catalog, settings, and config sections is now available under system section.

Code changes:

UtilResource, UtilRepository, UtilDAO are all renamed as SystemResource, SystemRepository, SystemDAO
SettingsResource is merged with SystemResource
SettingsRepository is merged with SystemRepository
SettingsDAO is merged with SystemDAO

[ ] Organize system APIs for 1.0


Typescript compilation failure when trying to upgrade to 0.21.0 from 0.20.3

When trying to run typescript compilation on @google-cloud/profiler when upgrading  @google-cloud/common to 0.21.0, typescript compilation fails with:
ts/src/index.ts:17:9 - error TS2305: Module '"/home/node/project/node_modules/@google-cloud/common/build/src/index"' has no exported member 'Logger'.

17 import {Logger, util} from '@google-cloud/common';

Is the expected?

Greetings!  This is entirely expected.  @ofrobots what did we do with the logging stuff in the other diagnostic modules?

Looks like it got fixed. Thanks @nolanmar511 !


Add maven-central badge

Add maven-central badge in order to simplify the search for the latest version of the library.

Thanks for the contribution!


Marshar assigned tasks

I completed my constraints part
Best,
Thandar Htwe

Hello Marshar,
It seems that several md_formatting checks have failed. Here are the key issues and how to address them:
Line Length Error: This can be resolved by breaking your paragraph into shorter lines. This won't affect how it looks but will resolve the error.
No-Multiple-Blanks Error: This happens when there are multiple consecutive blank lines. You can fix it by ensuring there is only one blank line where needed.
There's some vs code extensions like "markdownlint" which will show all these errors as a warning while you edit it.
Additionally, please name branches based on the file or feature you're working on. For this branch, it should be named "constraints."
Let me know if you need any assistance!


[TACHYON-1321] Enable EqualsHashCode rule in Checkstyle

https://tachyon.atlassian.net/browse/TACHYON-1320

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/6974/
Test PASSed.

LGTM

LGTM