Token generation

Dear All,
I am not able to generate oauth token with site24x7 to be able to connect via Terraform, can you please provide any advise ?
Thank you in advance

Hi @krdawid,
For fetching SITE24X7_CLIENT_ID, SITE24X7_CLIENT_SECRET and SITE24X7_REFRESH_TOKEN, visit https://api-console.zoho.com/ and choose the self client option. Copy the Client ID, Client Secret and paste them in the below command. Please give Site24x7.account.All,Site24x7.admin.All,Site24x7.reports.All,Site24x7.operations.All,Site24x7.msp.All,Site24x7.bu.All in the scope field and click the "Create" button. Copy the generated code, paste it in the below command and execute the same.
curl https://accounts.zoho.com/oauth/v2/token
-X POST
-d "client_id=<CLIENT_ID>"
-d "client_secret=<CLIENT_SECRET>"
-d "code=<GENERATED_CODE>"
-d "grant_type=authorization_code" --insecure
Command output will be similar to the one below
{"access_token":"1000.sdfsdf.sdfsdf","refresh_token":"1000.asdqwewqe.qweqwe","api_domain":"https://www.zohoapis.com","token_type":"Bearer","expires_in":3600}
In your terraform file, please configure the client ID, client secret and refresh token in the above command output.
Please let us know if you face any issues.
Note: Domain names vary based on your data center

United States - https://accounts.zoho.com and https://api-console.zoho.com

Europe - https://accounts.zoho.eu and https://api-console.zoho.eu

China - https://accounts.zoho.com.cn and https://api-console.zoho.com.cn

India - https://accounts.zoho.in and https://api-console.zoho.in

Australia - https://accounts.zoho.com.au and https://api-console.zoho.com.au

Thanks & Regards,
Jim

hey Jim ,
I have go thru it but still getting an error
Error: POST /notification_profiles: giving up after 5 attempts due to: Post "/notification_profiles": unsupported protocol scheme ""

Hi @krdawid,
Can you enable debugging and then run "terraform apply". Please copy and send us your command prompt output to<EMAIL_ADDRESS>along with your terraform file.
To enable debugging, execute the below command.

export TF_LOG=trace

Thanks & Regards,
Jim

Hey Jim , that is debug
Enter a value: yes
2022-07-04T13:48:28.631+0300 [INFO]  backend/local: apply calling Apply
2022-07-04T13:48:28.631+0300 [DEBUG] Building and walking apply graph for NormalMode plan
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.ConfigTransformer
2022-07-04T13:48:28.631+0300 [TRACE] ConfigTransformer: Starting for path:
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.ConfigTransformer with new graph:
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.RootVariableTransformer
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.RootVariableTransformer (no changes)
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.ModuleVariableTransformer
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.ModuleVariableTransformer (no changes)
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.LocalTransformer
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.LocalTransformer (no changes)
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.OutputTransformer
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.OutputTransformer (no changes)
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.DiffTransformer
2022-07-04T13:48:28.631+0300 [TRACE] DiffTransformer starting
2022-07-04T13:48:28.631+0300 [TRACE] DiffTransformer: found Create change for site24x7_website_monitor.example
2022-07-04T13:48:28.631+0300 [TRACE] DiffTransformer: site24x7_website_monitor.example will be represented by site24x7_website_monitor.example
2022-07-04T13:48:28.631+0300 [TRACE] DiffTransformer complete
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.DiffTransformer with new graph:
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.AttachStateTransformer
2022-07-04T13:48:28.631+0300 [DEBUG] Resource state not found for node "site24x7_website_monitor.example", instance site24x7_website_monitor.example
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.AttachStateTransformer (no changes)
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.OrphanOutputTransformer
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.OrphanOutputTransformer (no changes)
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.AttachResourceConfigTransformer
2022-07-04T13:48:28.631+0300 [TRACE] AttachResourceConfigTransformer: attaching to "site24x7_website_monitor.example (expand)" (*terraform.nodeExpandApplyableResource) config from main.tf:32,1-46
2022-07-04T13:48:28.631+0300 [TRACE] AttachResourceConfigTransformer: attaching provider meta configs to site24x7_website_monitor.example (expand)
2022-07-04T13:48:28.631+0300 [TRACE] AttachResourceConfigTransformer: attaching to "site24x7_website_monitor.example" (*terraform.NodeApplyableResourceInstance) config from main.tf:32,1-46
2022-07-04T13:48:28.631+0300 [TRACE] AttachResourceConfigTransformer: attaching provider meta configs to site24x7_website_monitor.example
2022-07-04T13:48:28.631+0300 [TRACE] Completed graph transform *terraform.AttachResourceConfigTransformer (no changes)
2022-07-04T13:48:28.631+0300 [TRACE] Executing graph transform *terraform.graphTransformerMulti
2022-07-04T13:48:28.631+0300 [TRACE] (graphTransformerMulti) Executing graph transform *terraform.ProviderConfigTransformer
2022-07-04T13:48:28.631+0300 [TRACE] ProviderConfigTransformer: attaching to "provider["registry.terraform.io/site24x7/site24x7"]" provider configuration from main.tf:13,1-20
2022-07-04T13:48:28.631+0300 [TRACE] (graphTransformerMulti) Completed graph transform *terraform.ProviderConfigTransformer with new graph:
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
2022-07-04T13:48:28.631+0300 [TRACE] (graphTransformerMulti) Executing graph transform *terraform.MissingProviderTransformer
2022-07-04T13:48:28.631+0300 [TRACE] (graphTransformerMulti) Completed graph transform *terraform.MissingProviderTransformer (no changes)
2022-07-04T13:48:28.631+0300 [TRACE] (graphTransformerMulti) Executing graph transform *terraform.ProviderTransformer
2022-07-04T13:48:28.631+0300 [TRACE] ProviderTransformer: exact match for provider["registry.terraform.io/site24x7/site24x7"] serving site24x7_website_monitor.example (expand)
2022-07-04T13:48:28.631+0300 [DEBUG] ProviderTransformer: "site24x7_website_monitor.example (expand)" (*terraform.nodeExpandApplyableResource) needs provider["registry.terraform.io/site24x7/site24x7"]
2022-07-04T13:48:28.631+0300 [TRACE] ProviderTransformer: exact match for provider["registry.terraform.io/site24x7/site24x7"] serving site24x7_website_monitor.example
2022-07-04T13:48:28.631+0300 [DEBUG] ProviderTransformer: "site24x7_website_monitor.example" (*terraform.NodeApplyableResourceInstance) needs provider["registry.terraform.io/site24x7/site24x7"]
2022-07-04T13:48:28.632+0300 [TRACE] (graphTransformerMulti) Completed graph transform *terraform.ProviderTransformer with new graph:
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
2022-07-04T13:48:28.632+0300 [TRACE] (graphTransformerMulti) Executing graph transform *terraform.PruneProviderTransformer
2022-07-04T13:48:28.632+0300 [TRACE] (graphTransformerMulti) Completed graph transform *terraform.PruneProviderTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.graphTransformerMulti with new graph:
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.RemovedModuleTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.RemovedModuleTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.AttachSchemaTransformer
2022-07-04T13:48:28.632+0300 [TRACE] AttachSchemaTransformer: attaching resource schema to site24x7_website_monitor.example (expand)
2022-07-04T13:48:28.632+0300 [TRACE] AttachSchemaTransformer: attaching resource schema to site24x7_website_monitor.example
2022-07-04T13:48:28.632+0300 [TRACE] AttachSchemaTransformer: attaching provider config schema to provider["registry.terraform.io/site24x7/site24x7"]
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.AttachSchemaTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.ModuleExpansionTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.ModuleExpansionTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.ReferenceTransformer
2022-07-04T13:48:28.632+0300 [DEBUG] ReferenceTransformer: "provider["registry.terraform.io/site24x7/site24x7"]" references: []
2022-07-04T13:48:28.632+0300 [DEBUG] ReferenceTransformer: "site24x7_website_monitor.example (expand)" references: []
2022-07-04T13:48:28.632+0300 [DEBUG] ReferenceTransformer: "site24x7_website_monitor.example" references: []
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.ReferenceTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.AttachDependenciesTransformer
2022-07-04T13:48:28.632+0300 [TRACE] AttachDependenciesTransformer: site24x7_website_monitor.example depends on []
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.AttachDependenciesTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.ForcedCBDTransformer
2022-07-04T13:48:28.632+0300 [TRACE] ForcedCBDTransformer: "site24x7_website_monitor.example" (*terraform.NodeApplyableResourceInstance) has no CBD descendent, so skipping
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.ForcedCBDTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.DestroyEdgeTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.DestroyEdgeTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.CBDEdgeTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.CBDEdgeTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.pruneUnusedNodesTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.pruneUnusedNodesTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.TargetsTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.TargetsTransformer (no changes)
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.CloseProviderTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.CloseProviderTransformer with new graph:
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
provider["registry.terraform.io/site24x7/site24x7"] (close) - *terraform.graphNodeCloseProvider
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.CloseRootModuleTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.CloseRootModuleTransformer with new graph:
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
provider["registry.terraform.io/site24x7/site24x7"] (close) - *terraform.graphNodeCloseProvider
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
root - *terraform.nodeCloseModule
provider["registry.terraform.io/site24x7/site24x7"] (close) - *terraform.graphNodeCloseProvider
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
2022-07-04T13:48:28.632+0300 [TRACE] Executing graph transform *terraform.TransitiveReductionTransformer
2022-07-04T13:48:28.632+0300 [TRACE] Completed graph transform *terraform.TransitiveReductionTransformer with new graph:
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
provider["registry.terraform.io/site24x7/site24x7"] (close) - *terraform.graphNodeCloseProvider
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
root - *terraform.nodeCloseModule
provider["registry.terraform.io/site24x7/site24x7"] (close) - *terraform.graphNodeCloseProvider
site24x7_website_monitor.example - *terraform.NodeApplyableResourceInstance
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
site24x7_website_monitor.example (expand) - *terraform.nodeExpandApplyableResource
provider["registry.terraform.io/site24x7/site24x7"] - *terraform.NodeApplyableProvider
2022-07-04T13:48:28.632+0300 [DEBUG] Starting graph walk: walkApply
2022-07-04T13:48:28.632+0300 [TRACE] vertex "provider["registry.terraform.io/site24x7/site24x7"]": starting visit (*terraform.NodeApplyableProvider)
2022-07-04T13:48:28.633+0300 [DEBUG] created provider logger: level=trace
2022-07-04T13:48:28.633+0300 [INFO]  provider: configuring client automatic mTLS
2022-07-04T13:48:28.651+0300 [DEBUG] provider: starting plugin: path=.terraform/providers/registry.terraform.io/site24x7/site24x7/1.0.17/darwin_arm64/terraform-provider-site24x7_v1.0.17 args=[.terraform/providers/registry.terraform.io/site24x7/site24x7/1.0.17/darwin_arm64/terraform-provider-site24x7_v1.0.17]
2022-07-04T13:48:28.654+0300 [DEBUG] provider: plugin started: path=.terraform/providers/registry.terraform.io/site24x7/site24x7/1.0.17/darwin_arm64/terraform-provider-site24x7_v1.0.17 pid=46501
2022-07-04T13:48:28.654+0300 [DEBUG] provider: waiting for RPC address: path=.terraform/providers/registry.terraform.io/site24x7/site24x7/1.0.17/darwin_arm64/terraform-provider-site24x7_v1.0.17
2022-07-04T13:48:28.666+0300 [INFO]  provider.terraform-provider-site24x7_v1.0.17: configuring server automatic mTLS: timestamp=2022-07-04T13:48:28.666+0300
2022-07-04T13:48:28.694+0300 [DEBUG] provider: using plugin: version=5
2022-07-04T13:48:28.694+0300 [DEBUG] provider.terraform-provider-site24x7_v1.0.17: plugin address: address=/var/folders/p9/n3c1cxxn3pz2_h03txcm722h0000gn/T/plugin538075456 network=unix timestamp=2022-07-04T13:48:28.694+0300
2022-07-04T13:48:28.715+0300 [TRACE] provider.stdio: waiting for stdio data
2022-07-04T13:48:28.715+0300 [TRACE] BuiltinEvalContext: Initialized "provider["registry.terraform.io/site24x7/site24x7"]" provider for provider["registry.terraform.io/site24x7/site24x7"]
2022-07-04T13:48:28.716+0300 [TRACE] NodeApplyableProvider: configuring provider["registry.terraform.io/site24x7/site24x7"]
2022-07-04T13:48:28.716+0300 [TRACE] buildProviderConfig for provider["registry.terraform.io/site24x7/site24x7"]: using explicit config only
2022-07-04T13:48:28.716+0300 [TRACE] GRPCProvider: GetProviderSchema
2022-07-04T13:48:28.716+0300 [DEBUG] provider.stdio: received EOF, stopping recv loop: err="rpc error: code = Unimplemented desc = unknown service plugin.GRPCStdio"
2022-07-04T13:48:28.716+0300 [DEBUG] No provider meta schema returned
2022-07-04T13:48:28.717+0300 [TRACE] GRPCProvider: ValidateProviderConfig
2022-07-04T13:48:28.719+0300 [TRACE] GRPCProvider: ConfigureProvider
2022-07-04T13:48:28.719+0300 [DEBUG] provider.terraform-provider-site24x7_v1.0.17: time="2022-07-04T13:48:28+03:00" level=info msg="GetAPIBaseURL :  "
2022-07-04T13:48:28.719+0300 [DEBUG] provider.terraform-provider-site24x7_v1.0.17: time="2022-07-04T13:48:28+03:00" level=info msg="GetTokenURL :  "
2022-07-04T13:48:28.719+0300 [TRACE] vertex "provider["registry.terraform.io/site24x7/site24x7"]": visit complete
2022-07-04T13:48:28.719+0300 [TRACE] vertex "site24x7_website_monitor.example (expand)": starting visit (*terraform.nodeExpandApplyableResource)
2022-07-04T13:48:28.719+0300 [TRACE] vertex "site24x7_website_monitor.example (expand)": expanding dynamic subgraph
2022-07-04T13:48:28.719+0300 [TRACE] vertex "site24x7_website_monitor.example (expand)": entering dynamic subgraph
2022-07-04T13:48:28.719+0300 [TRACE] vertex "site24x7_website_monitor.example": starting visit (*terraform.NodeApplyableResource)
2022-07-04T13:48:28.719+0300 [TRACE] vertex "site24x7_website_monitor.example": visit complete
2022-07-04T13:48:28.719+0300 [TRACE] vertex "site24x7_website_monitor.example (expand)": dynamic subgraph completed successfully
2022-07-04T13:48:28.719+0300 [TRACE] vertex "site24x7_website_monitor.example (expand)": visit complete
2022-07-04T13:48:28.719+0300 [TRACE] vertex "site24x7_website_monitor.example": starting visit (*terraform.NodeApplyableResourceInstance)
2022-07-04T13:48:28.719+0300 [TRACE] readDiff: Read Create change from plan for site24x7_website_monitor.example
2022-07-04T13:48:28.719+0300 [TRACE] readResourceInstanceState: reading state for site24x7_website_monitor.example
2022-07-04T13:48:28.719+0300 [TRACE] readResourceInstanceState: no state present for site24x7_website_monitor.example
2022-07-04T13:48:28.719+0300 [TRACE] readDiff: Read Create change from plan for site24x7_website_monitor.example
2022-07-04T13:48:28.719+0300 [TRACE] Re-validating config for "site24x7_website_monitor.example"
2022-07-04T13:48:28.719+0300 [TRACE] GRPCProvider: ValidateResourceConfig
2022-07-04T13:48:28.720+0300 [TRACE] GRPCProvider: PlanResourceChange
2022-07-04T13:48:28.721+0300 [WARN]  Provider "registry.terraform.io/site24x7/site24x7" produced an invalid plan for site24x7_website_monitor.example, but we are tolerating it because it is using the legacy plugin SDK.
The following problems may be the cause of any confusing errors from downstream operations:
- .timeout: planned value cty.NumberIntVal(10) for a non-computed attribute
- .response_headers_severity: planned value cty.NumberIntVal(2) for a non-computed attribute
- .use_name_server: planned value cty.True for a non-computed attribute
- .matching_keyword_severity: planned value cty.NumberIntVal(2) for a non-computed attribute
- .match_regex_severity: planned value cty.NumberIntVal(2) for a non-computed attribute
- .unmatching_keyword_severity: planned value cty.NumberIntVal(2) for a non-computed attribute
- .http_method: planned value cty.StringVal("G") for a non-computed attribute
2022-07-04T13:48:28.721+0300 [TRACE] checkPlannedChange: Verifying that actual change (action Create) matches planned change (action Create)
site24x7_website_monitor.example: Creating...
2022-07-04T13:48:28.721+0300 [INFO]  Starting apply for site24x7_website_monitor.example
2022-07-04T13:48:28.721+0300 [DEBUG] site24x7_website_monitor.example: applying the planned Create change
2022-07-04T13:48:28.721+0300 [TRACE] GRPCProvider: ApplyResourceChange
2022-07-04T13:48:28.721+0300 [DEBUG] provider.terraform-provider-site24x7_v1.0.17: 2022/07/04 13:48:28 [DEBUG] setting computed for "tag_ids" from ComputedKeys
2022-07-04T13:48:28.721+0300 [DEBUG] provider.terraform-provider-site24x7_v1.0.17: 2022/07/04 13:48:28 [DEBUG] setting computed for "user_group_ids" from ComputedKeys
2022-07-04T13:48:28.721+0300 [DEBUG] provider.terraform-provider-site24x7_v1.0.17: time="2022-07-04T13:48:28+03:00" level=debug msg="<== GET /location_profiles application/json; version=2.1: "
2022-07-04T13:48:33.633+0300 [TRACE] dag/walk: vertex "root" is waiting for "provider["registry.terraform.io/site24x7/site24x7"] (close)"
2022-07-04T13:48:33.633+0300 [TRACE] dag/walk: vertex "provider["registry.terraform.io/site24x7/site24x7"] (close)" is waiting for "site24x7_website_monitor.example"
2022-07-04T13:48:38.634+0300 [TRACE] dag/walk: vertex "provider["registry.terraform.io/site24x7/site24x7"] (close)" is waiting for "site24x7_website_monitor.example"
2022-07-04T13:48:38.634+0300 [TRACE] dag/walk: vertex "root" is waiting for "provider["registry.terraform.io/site24x7/site24x7"] (close)"
site24x7_website_monitor.example: Still creating... [10s elapsed]
2022-07-04T13:48:43.635+0300 [TRACE] dag/walk: vertex "root" is waiting for "provider["registry.terraform.io/site24x7/site24x7"] (close)"
2022-07-04T13:48:43.635+0300 [TRACE] dag/walk: vertex "provider["registry.terraform.io/site24x7/site24x7"] (close)" is waiting for "site24x7_website_monitor.example"
2022-07-04T13:48:44.459+0300 [TRACE] maybeTainted: site24x7_website_monitor.example encountered an error during creation, so it is now marked as tainted
2022-07-04T13:48:44.459+0300 [TRACE] NodeAbstractResouceInstance.writeResourceInstanceState to workingState for site24x7_website_monitor.example
2022-07-04T13:48:44.459+0300 [TRACE] NodeAbstractResouceInstance.writeResourceInstanceState: removing state object for site24x7_website_monitor.example
2022-07-04T13:48:44.459+0300 [TRACE] evalApplyProvisioners: site24x7_website_monitor.example is tainted, so skipping provisioning
2022-07-04T13:48:44.459+0300 [TRACE] maybeTainted: site24x7_website_monitor.example was already tainted, so nothing to do
2022-07-04T13:48:44.459+0300 [TRACE] NodeAbstractResouceInstance.writeResourceInstanceState to workingState for site24x7_website_monitor.example
2022-07-04T13:48:44.459+0300 [TRACE] NodeAbstractResouceInstance.writeResourceInstanceState: removing state object for site24x7_website_monitor.example
2022-07-04T13:48:44.459+0300 [TRACE] statemgr.Filesystem: not making a backup, because the new snapshot is identical to the old
2022-07-04T13:48:44.460+0300 [TRACE] statemgr.Filesystem: no state changes since last snapshot
2022-07-04T13:48:44.460+0300 [TRACE] statemgr.Filesystem: writing snapshot at terraform.tfstate
2022-07-04T13:48:44.481+0300 [ERROR] vertex "site24x7_website_monitor.example" error: GET /location_profiles: giving up after 5 attempts due to: Get "/location_profiles": unsupported protocol scheme ""
2022-07-04T13:48:44.482+0300 [TRACE] vertex "site24x7_website_monitor.example": visit complete, with errors
2022-07-04T13:48:44.482+0300 [TRACE] dag/walk: upstream of "provider["registry.terraform.io/site24x7/site24x7"] (close)" errored, so skipping
2022-07-04T13:48:44.482+0300 [TRACE] dag/walk: upstream of "root" errored, so skipping
2022-07-04T13:48:44.482+0300 [TRACE] statemgr.Filesystem: not making a backup, because the new snapshot is identical to the old
2022-07-04T13:48:44.482+0300 [TRACE] statemgr.Filesystem: no state changes since last snapshot
2022-07-04T13:48:44.482+0300 [TRACE] statemgr.Filesystem: writing snapshot at terraform.tfstate
╷
│ Error: GET /location_profiles: giving up after 5 attempts due to: Get "/location_profiles": unsupported protocol scheme ""
│
│   with site24x7_website_monitor.example,
│   on main.tf line 32, in resource "site24x7_website_monitor" "example":
│   32: resource "site24x7_website_monitor" "example" {
│
╵
2022-07-04T13:48:44.503+0300 [TRACE] statemgr.Filesystem: removing lock metadata file .terraform.tfstate.lock.info
2022-07-04T13:48:44.504+0300 [TRACE] statemgr.Filesystem: unlocking terraform.tfstate using fcntl flock
2022-07-04T13:48:44.508+0300 [DEBUG] provider: plugin process exited: path=.terraform/providers/registry.terraform.io/site24x7/site24x7/1.0.17/darwin_arm64/terraform-provider-site24x7_v1.0.17 pid=46501
2022-07-04T13:48:44.508+0300 [DEBUG] provider: plugin exited
and that is main.tf file
terraform {
required_version = ">= 0.15"
required_providers {
site24x7 = {
source  = "site24x7/site24x7"
version = "1.0.17"
}
}
}
provider "site24x7" {
data_center    = "Europe"
retry_min_wait = 1
retry_max_wait = 10
max_retries    = 4
oauth2_client_id = "my id "
oauth2_client_secret = "my secret"
oauth2_refresh_token = "my code"
}
resource "site24x7_website_monitor" "example" {
display_name          = "Example Monitor"
website               = "https://www.example.com"
check_frequency       = "1"
location_profile_name = "Europe"
}

Can you please change data_center = "Europe" to data_center = "EU"

yes I have changed it to EU - now i am getting the error below
Error: GET https://www.site24x7.eu/api/location_profiles: giving up after 5 attempts due to: Get "https://www.site24x7.eu/api/location_profiles": oauth2: server response missing access_token
│
should I access token be also part of main.tf ?

Hey Jim,
once new resources are trying to be deployed I am getting the following error :
Error: GET /location_profiles: giving up after 5 attempts due to: Get "/location_profiles": unsupported protocol scheme ""
have you ever met with such a case ?
thank you in advance,


AttributeError: 'list' object has no attribute 'device'

when I run 'example 1', I encounter a problem.
File "/home/ghx/anaconda3/envs/rllab3/lib/python3.5/runpy.py", line 184, in _run_module_as_main
"main", mod_spec)
File "/home/ghx/anaconda3/envs/rllab3/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/home/ghx/baselines/baselines/run.py", line 250, in
main(sys.argv)
File "/home/ghx/baselines/baselines/run.py", line 216, in main
model, env = train(args, extra_args)
File "/home/ghx/baselines/baselines/run.py", line 64, in train
env = build_env(args)
File "/home/ghx/baselines/baselines/run.py", line 116, in build_env
env = VecNormalize(env, use_tf=True)
File "/home/ghx/baselines/baselines/common/vec_env/vec_normalize.py", line 14, in init
self.ob_rms = TfRunningMeanStd(shape=self.observation_space.shape, scope='ob_rms') if ob else None
File "/home/ghx/baselines/baselines/common/running_mean_std.py", line 58, in init
self._count.assign(self._new_count)
File "/home/ghx/anaconda3/envs/rllab3/lib/python3.5/site-packages/tensorflow/python/ops/control_flow_ops.py", line 2940, in group
dev = inp.device
AttributeError: 'list' object has no attribute 'device'
Is this my computer problem?

Could you provide an example script that reproduces this issue?  The error makes me think that there's a list where there should be a tensor.

Could you provide an example script that reproduces this issue? The error makes me think that there's a list where there should be a tensor.

Similar problem encountered when using read_folders_and_files function in example 1. The code is
site_url = "https://cl.sharepoint.com/sites/test" ctx_auth = AuthenticationContext(url=site_url) username = "my_username" password = "my_password" if ctx_auth.acquire_token_for_user(username=username, password=password):     ctx = ClientContext(site_url, ctx_auth)     read_folder_and_files(ctx, "Shared Documents/Test")
The error shown is AttributeError: 'List' object has no attribute 'rootFolder'. and is triggered by https://github.com/vgrem/Office365-REST-Python-Client/blob/19f9ce84bec22fe2e6792d4c02fe9ca87a6a3c47/examples/sharepoint/file_operations.py#L26.


feat(config): add pipe suport to config:pull

Fixes deis/deis#4697

I tested this locally and it works as advertised. Thanks @Joshua-Anderson!


Task :react-native-pager-view:compileReleaseKotlin FAILED

I installed the new architecture version  react-native-pager-view@newarch and I am trying to generate a release APK with the new architecture and I am using the latest react-native-pager-view it causes an issue.
The command I am using for the APK release is: ./gradlew assembleRelease -PnewArchEnabled=true
I tried ./gradlew clean and it succeed and every time I try to generate an APK I get the same error:
Task :react-native-pager-view:compileReleaseKotlin FAILED

@okwasniewski
"react": "18.1.0",
"react-native": "0.70.3",

Hey @AdhamMahmoud98,
Thanks for providing the versions. Can you try first cleaning the build folder with git clean -fdx android, then generating codegen files using ./gradlew generateCodegenArtifactsFromSchema and then building with the same command that you used.


Create Auth0 tenant for user

User Priya Basker needs an auth0 tenant to develop passwordless SSO on their application.
AC:

New auth0 tenant for User
User has access to tenant
Process to get Auth0 tenant documented

Email sent to<EMAIL_ADDRESS>asking for a new tenant, created this ticket to track


refactor(layouts): margin changes for toolbar sub divs

PR fixes #740.

Added margin-top for immediate descendant selectors from .pf-l-toolbar. Visually this added spacing between content when viewed on mobile devices.
For .pf-l-toolbar__item, if parent selector is .pf-l-toolbar__group, default margin units are set to zero unit.

Deploy preview for pf-next ready!
Built with commit<PHONE_NUMBER>64dbb2eebe285b6841b200b110e714
https://deploy-preview-754--pf-next.netlify.com


⚠ Jenkins Plugins Artifactory has degraded performance

In 46b2d35, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1233 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 7d39052 after 33 minutes.


Facing Error "Illegal character in authority at index" When Sending Parameter String Password with Bracket

Expected behavior
Body Data should accept bracket as String, when it is inside of the String
{"email":"${__P(username, ******)}", "password":"${__P(password, example)4444)}"}
Actual behavior
Body Data should`nt accept bracket as String, when it is inside of the String
Steps to reproduce the problem
1- Create HTTPS Request with Body Data
2- Write inside of body data bracket punctuation as Parameter as String
3- Run the HTTPS Request
4- Facing Error "Illegal character in authority at index"
Note: Delimiter added delimiter to the bracket, ), and that time the Property reference was processed well, but delimiter was not removed from the output value.
Note: Tried this,
{"email":"${__P(username, ******)}", "password":"${__P(password, example)4444)}"}
and this was ok, property understood it as password, but the the delimiter was not removed.
if the password is example)4444 we shoudl write in the property like this: example\)4444

Last backslash for saving the brancket, 2 backslash to set \ character as part of the pwassord string

JMeter Version
5.5
Java Version
java version "11.0.18" 2023-01-17 LTS
OS Version
10.0.19044 Builde 19044

To boil it down a bit, you would like to change the behaviour of the __P function to un-escape special characters so that
")" == "${__P(somevar,\))}" would be true.
Have you tried to use the __unescape function? For example $__P(password,${__unescape(example\)444)})}

Hi FSchumacher, We tried backslash escape character in __P, and while JMeter could understand the payload well, __P left backslash it in the password therefore it induced another problem. We did not know this __unescape function, so we haven't tried it, but we'll do it soon. Thanks for your fast reply.

Thanks for comments, Fixed!


Tooltip on server icon interferes with clickability

The tooltip makes it hard to click the server icon -- only the top half of the icon is actually clickable.

This should be fixed with the latest UI updates. I turned off the pointer events for the tooltip so it should not interfere with the click target.


Configurations

Would be nice to be able to save some configuration things:

font-size
background color
shortcuts?

I am thinking to do that in the ~/.web-term.json file and maybe later to have a visual way to edit that.

we could make the entire 256 color palette configurable via stylesheet,  with .bg-*** and .fg-*** classes, and just add .underline, .bold, etc

if you pass Terminal an array of 10 or 18 colors, it'll set foreground and background based on that:
            var tab = term.tab = Terminal.call(term, {
                cols: win.cols,
                rows: win.rows,
                colors: [ // from ethanschoonover.com/solarized
                    '#073642', //$base02
                    '#dc322f', //$red
                    '#859900', //$green
                    '#b58900', //$yellow
                    '#268bd2', //$blue
                    '#d33682', //$magenta
                    '#2aa198', //$cyan
                    '#eee8d5', //$base2

                    '#002b36', //$base03
                    '#cb4b16', //$orange
                    '#586e75', //$base01
                    '#657b83', //$base00
                    '#93a1a1', //$base1
                    '#6c71c4', //$violet
                    '#839496', //$base0
                    '#fdf6e3', //$base3
                    '#002b36',  //$base03 and background
                    '#839496' //$base0 and foreground
                ]

@michaeljosephrosenthal Ohhh, that's really, really, really nice! :smile: Thanks for pointing that out. That means we could support color themes (maybe even supporting xml formats that existing terminals use) for web-term.
Again, thanks for that! First I was thinking to hack it only on the client side (with some CSS), but this is much better the good way. :+1:

yeah, that was part of the original tty.js options. My current colors are
colors: [
    '#073642', //$base02
    '#dc322f', //$red
    '#859900', //$green
    '#b58900', //$yellow
    '#268bd2', //$blue
    '#d33682', //$magenta
    '#2aa198', //$cyan
    '#eee8d5', //$base2

    '#002b36', //$base03
    '#cb4b16', //$orange
    '#586e75', //$base01
    '#657b83', //$base00
    '#93a1a1', //$base1
    '#6c71c4', //$violet
    '#839496', //$base0
    '#fdf6e3', //$base3

    '#002b36', '#839496'
]

I also commented out
  // See: XTerm*boldColors
  //if (fg < 8) fg += 8;

in the bolding code, which was making bolds into :sparkles: brights :sparkles: as a compatibility thing.

@michaeljosephrosenthal Played with this in #36. Check it out. :sparkle:


fix(android): workaround streaming URLs returning 403

Related: https://github.com/iv-org/invidious/issues/3771, https://github.com/unixfox/invidious-custom/issues/60, https://github.com/microg/GmsCore/issues/1870, https://github.com/TeamNewPipe/NewPipe/issues/9038

Thank you really appreciate.

It worked on microg?


add in option to generate biaxial plots

useful for assessing accuracy of segmentation, can do log/log plots of marker intensity per cell to get a sense of overlap of distinct markers and co-expression of related markers

These much older issues caught my eye tonight. Is this is a task that we can mark as a good first issue, or has the project changed enough to necessitate something much different here?

Agreed, this would be a good first issue
On Wed, Sep 30, 2020 at 11:29 PM alex-l-kong<EMAIL_ADDRESS>wrote:

These much older issues caught my eye tonight. Is this is a task that we
can mark as a good first issue, or has the project changed enough to
necessitate something much different here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/angelolab/ark-analysis/issues/10#issuecomment-701917735,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJB47NBVTWXFMDMCOPCIRTSIQOVBANCNFSM4I2HW5NA
.


Delete mask on form submit

Hi !
I have an issue, I use this plugin for in a form and I also uses the Mask option to be sure the date is on format 0000-00-00 00:00:00. The problem is that when doing nothing or chosing no dates the form only display the mask __-- :: and send it with the form. I would like to leave the field empty if nothing is entered.
Also is it possible using the validateOnBlur to true but not display the current datetime if validation failes ? Just leave it empty.
Thanks

I'd like to comment only on the part about leaving mask on submit. Could you please explain why you won't fix it?

How can we avoid submitting mask when the input is empty?

You can use lazyInit which won't pre-populate fields with an input mask.  It'll show up on focus, and then disappear on blur if they didn't select a value.  So empty fields will remain empty and won't post back with any values.
$('.datetimepicker').datetimepicker({
  lazyInit: true,
});


Rename docblocks in Routes utilities classes

Description
Extensions in Visual Studio Code do not have access yet to advanced doc blocks like class-string, list, T, causing type error hints when files are opened. I suggest changing them into the conventional formats.
However, for SA, phpstan uderstands them so I just swapped them to the compatible tags (like @phpstan-return).
Checklist:

[x] Securely signed commits
[x] Component(s) with PHPDoc blocks, only if necessary or adds value
[ ] Unit testing, with >80% coverage
[ ] User guide updated
[ ] Conforms to style guide

Elegant solution. How does this affect CS Fixer?

php-cs-fixer can still process these, with the different phpdoc_** rules.

Just a feeling, but could we maybe provide a list of "fully" compatible IDEs for development? It seems to me that some adjustments for editors in recent time
cause more trouble than they resolve (see the phpstorm auto-completion issue) or make workarounds necessary, just because some IDE does not (yet) fully support all docblock Features.
This is not meant against the changes here, they look reasonable, just a general idea 😄


Error while installing on MacOS Monterrey pip3 python v3.8.x

hugobarbosa@Hugos-Air ~ % pip install pyaudio
DEPRECATION: Configuring installation scheme with distutils config files is deprecated and will no longer work in the near future. If you are using a Homebrew or Linuxbrew Python, please see discussion at https://github.com/Homebrew/homebrew-core/issues/76621
Collecting pyaudio
Using cached PyAudio-0.2.11.tar.gz (37 kB)
Preparing metadata (setup.py) ... done
Building wheels for collected packages: pyaudio
Building wheel for pyaudio (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py bdist_wheel did not run successfully.
│ exit code: 1
╰─> [16 lines of output]
running bdist_wheel
running build
running build_py
creating build
creating build/lib.macosx-12-x86_64-cpython-39
copying src/pyaudio.py -> build/lib.macosx-12-x86_64-cpython-39
running build_ext
building '_portaudio' extension
creating build/temp.macosx-12-x86_64-cpython-39
creating build/temp.macosx-12-x86_64-cpython-39/src
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -DMACOSX=1<EMAIL_ADDRESS>-c src/_portaudiomodule.c -o build/temp.macosx-12-x86_64-cpython-39/src/_portaudiomodule.o
src/_portaudiomodule.c:29:10: fatal error: 'portaudio.h' file not found
#include "portaudio.h"
^~~~~~~~~~~~~
1 error generated.
error: command '/usr/bin/clang' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for pyaudio
Running setup.py clean for pyaudio
Failed to build pyaudio
Installing collected packages: pyaudio
DEPRECATION: Configuring installation scheme with distutils config files is deprecated and will no longer work in the near future. If you are using a Homebrew or Linuxbrew Python, please see discussion at https://github.com/Homebrew/homebrew-core/issues/76621
Running setup.py install for pyaudio ... error
error: subprocess-exited-with-error
× Running setup.py install for pyaudio did not run successfully.
│ exit code: 1
╰─> [18 lines of output]
running install
/usr/local/lib/python3.9/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_py
creating build
creating build/lib.macosx-12-x86_64-cpython-39
copying src/pyaudio.py -> build/lib.macosx-12-x86_64-cpython-39
running build_ext
building '_portaudio' extension
creating build/temp.macosx-12-x86_64-cpython-39
creating build/temp.macosx-12-x86_64-cpython-39/src
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -DMACOSX=1<EMAIL_ADDRESS>-c src/_portaudiomodule.c -o build/temp.macosx-12-x86_64-cpython-39/src/_portaudiomodule.o
src/_portaudiomodule.c:29:10: fatal error: 'portaudio.h' file not found
#include "portaudio.h"
^~~~~~~~~~~~~
1 error generated.
error: command '/usr/bin/clang' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure
× Encountered error while trying to install package.
╰─> pyaudio
note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

It seems, you are missing portaudio installation on your machine, you have to first install portaudio if you have homebrew just use brew install portaudio to install portaudio then try pip again.

It shows as installed already v. 19.7.0  ... I'll give it a try once more and let you know the outcome. Thanks @friday-code


Inconsistent subscription updates

When useSubscription calls setState that immediate re-renders the component. This means that in situations where we have nested components, we can end up rendering inconsistent data and also doing unnecessary renders. Consider:
function A(rep) {
  const data = useSubscribe(rep, ...);
  return <B rep={rep} data={data} onClick={() => rep.mutate.foo()}/>;
}

function B(rep, data) {
  const otherData = useSubscribe(rep, ...);
  return ...
}

If rep.mutate.foo() causes the subscription in A to fire, there will be two problems:

The data rendered by A will be momentarily inconsistent with the data rendered by B.  This can cause bad UI or exceptions if developers aren't careful to defend against it.
B will get rendered twice: once as part of the parent, and again on its own.

Both these have the same underlying problem that setState() can often force rendering to happen synchronously. This blog post describes the problem clearly: https://blog.logrocket.com/simplifying-state-management-in-react-apps-with-batched-updates/. See also discussion on Discord: https://discord.com/channels/830183651022471199/880130574629605388/880130592463814737.
It seems we can fix this at least two ways. One by using unstable_batchedUpdates as described in the blog post, or another by exposing an API compatible with useSubscription: https://github.com/facebook/react/tree/main/packages/use-subscription
It seems like the latter approach might be better for compat with upcoming React changes.

@arv can you prioritize this one. Totally forgot about it since it's in a different repo :-/.

It seems like we should not depend on unstable_batchedUpdates since it only works with ReactDOM but I guess that is a problem we could deal with later if there is ever a need to support React Native.
For the useSubscription, it seems we could just wrap the react one but I'm not sure what the intended use is? I guess I just need to play with it.


Update containers/image

Pulls in changes to containers/image for two useful (but breaking) changes:

Removal of dependency on github.com/docker/distribution/reference
Pluggable transports

@runcom

LGTM

Lgtm


Register-Passkey Error

Invoke-MgGraphRequest: GET https://graph.microsoft.com/beta/users//authentication/fido2Methods/creationOptions?challengeTimeoutInMinutes=5 HTTP/2.0 405 Method Not Allowed Vary: Accept-Encoding Strict-Transport-Security: max-age=31536000 request-id: 1686c46f-9635-41e3-b911-43748b60bd98
client-request-id: 3bc06849-4266-4b48-9a73-b1e8bfd5e7a8 x-ms-ags-diagnostic: {"ServerInfo":{"DataCenter":"East US","Slice":"E","Ring":"5","ScaleUnit":"008","RoleInstance":"BL02EPF0001B4CE"}} Link:
https://developer.microsoft-tst.com/en-us/graph/changes?$filterby=beta,PrivatePreview:copilotExportAPI&from=2024-07-01&to=2024-08-01;rel="deprecation";type="text/html" deprecation: Tue, 02 Jul 2024 23:59:59 GMT sunset: Thu, 02 Jul 2026 23:59:59 GMT Date: Mon, 12 Aug 2024 15:39:14
GMT Content-Type: application/json Content-Encoding: gzip  {"error":{"code":"methodNotAllowed","message":"The method is not supported for this URL.","innerError":{"message":"The method is not supported for this
URL.","date":"2024-08-12T15:39:14","request-id":"1686c46f-9635-41e3-b911-43748b60bd98","client-request-id":"3bc06849-4266-4b48-9a73-b1e8bfd5e7a8"}}}
*i pulled my UPN out of the error.

The operation is not supported for SELF, maybe that is the reason of the error.


Fix workspace avatar for invoice chat is missing background

Details

The WS bg in invoice chat is missing.
Fixed Issues

$ https://github.com/Expensify/App/issues/43125
PROPOSAL: https://github.com/Expensify/App/issues/43125#issuecomment-2150437440
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

As user B, send an invoice to user A from a workspace that user A is not a member
As user A, open the invoice chat
Press the chat header
Press the workspace avatar
Verify the workspace avatar has a background

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/50919443/81198410-fceb-4aa4-9eb6-3df9ed595ef7

Android: mWeb Chrome

https://github.com/Expensify/App/assets/50919443/f8521028-ce93-4bbb-ae8f-f50c82c7b98d

iOS: Native

https://github.com/Expensify/App/assets/50919443/e6b1b6af-3998-451c-9cef-d3fc115e0c23

iOS: mWeb Safari

https://github.com/Expensify/App/assets/50919443/c6d609ba-6592-4786-aef7-209a02e19e6c

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/50919443/6f863b95-3b5c-4dd4-8d13-bd0d87305380

MacOS: Desktop

https://github.com/Expensify/App/assets/50919443/6bbaf06a-76d4-443f-85ac-5b404b2fd77a

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.81-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Problems with saved passwords

I haven't tested this extensively, cause I don't have all the browsers on me now, but here's the deal - if you use placeholder text for password/username fields, the results sometimes become unpredictable when the users choose to save their passwords.
All tests performed with a simplified demo.html - removed all fields but the text and password, and gave the text field name="username" (to trigger saving passwords). To trigger the "save password?" on Chrome, demo must submit to a different location (not to self).
Steps to reproduce in most cases:

Load the page
Enter u/p
Submit
Save the password
Close the tab
Open the page again

Results:
O10.63@Ubuntu, O11a@W2K8: the "password" field doesn't have the indicator (yellow inside border) - not a biggie. Hitting ctrl+enter to fill in the form fills in the details, but "placeholder" class is not removed - not a biggie.
IE8@W7, IE9@W2K8: focus into username field, select username from autocomplete dropdown - the password placeholder text still displays, as if the password wasn't filled in. Focus into the password field - the saved password is retrieved OK. Not a biggie - pretty much like Opera.
FF3.6.12@Ubuntu, FF3.6.12@W2K8: for some reason, the "saved username" contains the placeholder of the password (is it because of the unnamed fake password field?) - problematic - could be a bug in FF itself, but the users don't know that, right?...
FF4b7@W2K8, Cr7@W2K8, Cr8@Ubuntu: support placeholder natively.
I didn't test it right now, but the problem becomes even worse if you have multiple usernames/passwords saved for the same form - also, not sure how common that is in real life.
I'm afraid I can't really offer a solution for this - especially considering that some browsers don't report the value for autocompleted password fields (if I remember correctly, having had these issues in a similar implementation a while back).
In practice, I've so far avoided using placeholders for password fields.
Side issue: there may be issues with IE6/7 (I think) maintaining the focus of the fields after hitting "Back" (or was it F5?) - the field is focused, but the focus event is never fired, so the placeholder is inserted. Probably also worth testing this with "autofocus" (where supported).

Maybe something like:
Iterate through each input/textarea element setting focus to it. On focus check if input has a text value already, if it does don't apply placeholder text.


Implement Groups CreateChild

Reference: https://api.slack.com/methods/groups.createChild
Acceptance Criteria:

[ ] Spring Slack Client is extended with given method
[ ] Spring Slack Test Client is extended with given method
[ ] JavaDoc/KDoc is added

closed by #297


Manually setting a room to 'Off' should reflect in the climate mode

Current Behaviour:
Given a room has been manually set to off (in the Wunda app),
the target temperature correctly pulls through to the climate sensor as 0,
however the climate mode is set to 'heat'
Expected Behaviour:
Given a room has been manually set to off (in the Wunda app),
the target temperature should pull through to the climate sensor as 0,
and the climate mode should be set to 'off'

@mutasim could you confirm what the tp/temp_pre flags are showing as for you in this state please? I'd expect it to be 4 when manually set to off

Never mind, I see the problem I think :)

@mutasim this commit should fix it, let me know how you get on.

Working as per the reported issue above. 👍
I've spotted that the hvac_action can appear out of sync from the mode, will raise it as a separate issue though

@mutasim re hvac_action being different from hvac_mode, that's expected (but may be a limitation of my knowledge of what these things are supposed to represent in ha,
Here's the bit of code that sets both:
                # tp appears to be the following flags:
                # - 00000001 (0x01) indicates a manual override is set until the next manual override
                # - 00000100 (0x04) indicates the set point temperature has been set to 'off'
                # - 00010000 (0x10) indicates a manual override has been set
                # - 00100000 (0x20) indicates heating demand
                # - 10000000 (0x80) indicates the adaptive start mode is active
                flags = int(state["temp_pre"])
                self._attr_hvac_mode = (
                    HVACMode.OFF if flags & (0x10 | 0x4) == (0x10 | 0x4)  # manually set to off
                    else HVACMode.HEAT if (flags & (0x10 | 0x80)) == 0x10  # manually set to heat
                    else HVACMode.AUTO
                )
                self._attr_hvac_action = (
                    HVACAction.PREHEATING if ((flags & (0x80 | 0x20)) == (0x80 | 0x20))
                    else HVACAction.HEATING if flags & 0x20
                    else HVACAction.OFF
                )

hvac_action is only set to heating if there is currently heating demand, whereas hvac_mode will indicate heat if the heating's been manually turned on (which may not result in demand if the set temperature is already above the requested temperature).
If you know how these things are supposed to be used, or can point me to some docs, I can update this logic.

I've had a go at articulating my take on the issue at #3. I think it's a case of checking the 'hvac_action' value when mode is changed.


EmailConfig: Use CanonicalMIMEHeaderKey instead of TitleCasing for headers

Fixes #3064.

@simonpasquier how and when do commits get tagged as releases? Is there's a process that we can help with? I'd like to import this change into some downstream projects.

@joeblubaugh we have no fixed schedule for releases but I'm planning on preparing a 0.25 release candidate soon-ish.

Great, thank you.


test: add an example about building math application with agent

Summary by CodeRabbit

New Features

Introduced a Jupyter notebook for building a custom Math application using AI models, complete with tools for calculations and reasoning.
Added a new chatbot application notebook capable of solving logic-based questions, performing arithmetic calculations, and searching Wikipedia for interactive user engagement.
Included dependencies in the requirements.txt file for the new features.

Can you add a streamlit or gradio demo for it?

Add a streamlit chatbot app suitable for display.

lgtm


upgrade to sbt 0.13.13

@dwijnand @eed3si9n before 0.13.13 final is released, should we a run a community build using 0.13.13-RC3, to help ensure that the new version isn't breaking people's builds?

Yes please, I was going to do that today then it slipped my mind.
If you don't get round to it today your time I'll take a shot at doing it tomorrow my time.

(I wouldn't get to it until after #280)

#354 on 2.12.x was a success
#358 testing on the 2.11.x build projects

Ok looks like 0.13.13-RC3 is good.

https://github.com/scala/community-builds/pull/371

BTW I was keeping this open for the final 0.13.13 upgrade.

it's all yours :-)


change the per-platform repo naming convention?

(@breerly)
Per https://github.com/opentracing/api-go/issues/34, should we name the PlatformX repo opentracing-platformx rather than api-platformx?
This makes forks friendlier from a naming standpoint and is a convention adopted by other polyglot github orgs. On the other hand, it adds some stuttering... e.g., in Go,
import "github.com/opentracing/opentracing-go/opentracing"

:)

I'm ok with renaming.  I wonder if we need to keep the last opentracing part in Go. Many Go projects put the core files in the root directory, so the path in the import would be opentracing-go, but the package name will be opentracing. Not sure if it'd work...

+1 for opentracing-platformx and keeping it consistent across all languages.

I agree with @yurishkuro -- lets change the Go import path to:
import "github.com/opentracing/opentracing-go"

Package name does not need to match final path element, and in my (very large) experience often does not.

in favor of "opentracing-java" as api is an implied minimum publication of
that repo.

done.. https://github.com/opentracing/opentracing-java/issues/3

Great, thank you! I will handle s/api-go/opentracing-go/g

Done -- thanks, all.
https://github.com/opentracing/opentracing-python/commit/786f4485c820a230512332ea00007a2ebdd9dc1c
https://github.com/opentracing/opentracing-java/commit/9765e07aced2ba7769de9b0e3866e6afc5cf7824


[1210] Fix Find URL on courses table

Now that the environment variable is defined, we can update the URL.

 Courses table in manage-courses-frontend

@heidar done, also have added .to_s so that it doesn't blow up on the way into the link_to. :)


Add 'Extensions List' page to the documentation

Which issue does this PR close?
Related to https://github.com/apache/datafusion/issues/12357
Rationale for this change
Inspired by @phillipleblanc and @jonahgao comments on https://github.com/apache/datafusion/issues/12357 let's try and make it easier to find other features such as table providers rather than necessarily trying to add them to the core of DataFusion itself.
What changes are included in this PR?

Add "Extensions List" page with a table of projects
Move datafusion-contrib content to the new page

Are these changes tested?
CI doc tests. I also rendered it locally:

Are there any user-facing changes?

I also wonder if we need some criteria for "graduating" an extension to be an official Apache DataFusion sub-project (i.e. similar to ballista/python bindings)? I realize that doesn't really solve the "maintainers being stretched thin" problem since it just means now more repos to monitor.

Maybe the criteria is "if there are a subset of DataFusion committers that vote to maintain it longterm" ?

Yes for sure -- @phillipleblanc  we are actually doing this in term https://github.com/sqlparser-rs/sqlparser-rs/issues/1294 -- the procedural method is that we do a binding community vote.


Street View: Add value to BusinessStatus

The most minor of all minor fixes, seems there is one more value here. Found a place that opens in the future at the time of me looking up the pano, but it was in the nearby places anyway. Didn't seem to have the opening date or any details like that.

Thanks 👍


App template requires a bunch of config I don't have or care about

rollbar, librato, yubi, etc

Also privacy policy URL!

You probably shouldn't be running this yourself right now.


Species Feasibility Tab

Firstly a rename of the species suitability tab. We are using Feasibility for our modelling work which accounts for climate/site factors only. The term Suitability is used for the Chief Foresters ratings and are focused on ratings for timber production.

[ ] Add in all colours for legend feasibility ratings
[x] Bold tree species code part of Species label
[x] Rename "predicted suitability" to "Predicted Feasibility"
[x] Add in the 5th time period to Predicted Feasibility.  The ratings in the baseline tables (1961-1991) are "Historic", the 1991-2019 period is "Current" and then the three future time periods
[ ] Include all time period for all species for any species even where there is no feasibility occurrence
[ ] Instead of 10, 25, 50 choices of species to report. Either "feasible only " or "all". The first category would include any species that is either in the Chief Foresters Suitability or is predicted feasible. The second choice would show species that have a some predicted feasibility in any time period. Ordered by feasibility rating first, species code second
[ ] The Chief Foresters Suitability rating should be taken from the Silviculture Tables. Use an "X" where a species is not listed

@whmacken Thanks a lot for the feedback
What do you mean all colours? How many colours do you expect.

Include all time period for all species for any species even where there is no feasibility occurrence

Do you also mean all known BC species should appear in the table even if they are not in the site series? Or just the time period.

Instead of 10, 25, 50 choices of species to report. Either "feasible only " or "all". The first category would include any species that is either in the Chief Foresters Suitability or is predicted feasible. The second choice would show species that have a some predicted feasibility in any time period. Ordered by feasibility rating first, species code second

Just to make sure, "all" would not include species that have no feasibility in all time period?

The Chief Foresters Suitability rating should be taken from the Silviculture Tables. Use an "X" where a species is not listed
Great, I was wondering where that came from.

I am only seeing this

.

For the "all" option. It would be species that show suitability in any time period. Only species where there is no suitability in any model or time period would be excluded.

I will make viewing test across browsers. Great input.

All items now in main


Update version after Tables release

@bsiegel This should be automated for you, once you release an Increment PR is automatically triggered for that package.

Closing in favor of #15060


The color scheme of yaml code in the document makes it difficult to read

📚 Documentation

The black background and the dark blue text makes the code really difficult to read.
cc @borda

cc: @adamjkuhn

@Borda Sure, https://lightning.ai/docs/pytorch/stable/cli/lightning_cli_advanced_3.html
But it seems all pages with yaml code block have this problem.


Build Issues with CMake 3.14.4

Expected Behavior
CMake should be able to build HPX without needing PkgConfig
Actual Behavior
Received this error when building HPX in Visual Studio on Windows:

Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
CMake Error at tests/unit/resource/CMakeLists.txt:19 (if):
if given arguments:
"GREATER" "11"

Unknown arguments specified
Configuring incomplete, errors occurred!

Configuration:
-DCMAKE_RELEASE_TYPE=Debug
-DCMAKE_TOOLCHAIN_FILE=C:\path_to_my_vc\vcpkg.cmake
-HPX_WITH_DOCUMENTATION=On
Specifications
... Please describe your environment

HPX Version: Master
Platform (compiler, OS): Windows

Excellent catch, thanks @aserio! I think pkgconfig is a red herring. HPX_CXX_STANDARD is not set on Windows when the standard is auto-detected. I think I'll simply disable that test on Windows for now as it doesn't seem to be quite right anyway. After the release the C++ standard check will go away anyway and we can enable it cleanly again.

@aserio would you mind trying out #3279?

@msimberg I have good news and I have bad news :D
Good news: CMmake configures and generates without errors!
Bad news: When building core I get these errors:

------ Build started: Project: hpx, Configuration: Debug x64 ------
1>throw_exception.cpp
1>parcelhandler.cpp
1>c:\users\adria\git\hpx\src\throw_exception.cpp(54): error C2440: '': cannot convert from 'boost::system::error_code' to 'hpx::exception'
1>c:\users\adria\git\hpx\src\throw_exception.cpp(54): note: No constructor could take the source type, or constructor overload resolution was ambiguous
1>The use of BOOST_ENDIAN and BOOST_BYTE_ORDER is deprecated. Please include <boost/predef/other/endian.h> and use BOOST_ENDIAN_BYTE instead
1>c:\users\adria\git\hpx\src\runtime\parcelset\parcelhandler.cpp(721): error C2440: '': cannot convert from 'const boost::system::error_code' to 'hpx::exception'
1>c:\users\adria\git\hpx\src\runtime\parcelset\parcelhandler.cpp(721): note: No constructor could take the source type, or constructor overload resolution was ambiguous
1>Done building project "hpx.vcxproj" -- FAILED.
2>------ Build started: Project: unordered_component, Configuration: Debug x64 ------
3>------ Build started: Project: iostreams_component, Configuration: Debug x64 ------
4>------ Build started: Project: memory_component, Configuration: Debug x64 ------
5>------ Build started: Project: parcel_coalescing_lib, Configuration: Debug x64 ------
2>LINK : fatal error LNK1104: cannot open file '........\Debug\lib\hpxd.lib'
2>Done building project "unordered_component.vcxproj" -- FAILED.
6>------ Build started: Project: component_storage_component, Configuration: Debug x64 ------
3>LINK : fatal error LNK1104: cannot open file '......\Debug\lib\hpxd.lib'
6>LINK : fatal error LNK1104: cannot open file '......\Debug\lib\hpx_unorderedd.lib'
6>Done building project "component_storage_component.vcxproj" -- FAILED.
3>Done building project "iostreams_component.vcxproj" -- FAILED.
7>------ Build started: Project: partitioned_vector_component, Configuration: Debug x64 ------
8>------ Build started: Project: process_component, Configuration: Debug x64 ------
4>LINK : fatal error LNK1104: cannot open file '........\Debug\lib\hpxd.lib'
4>Done building project "memory_component.vcxproj" -- FAILED.
7>LINK : fatal error LNK1104: cannot open file '........\Debug\lib\hpxd.lib'
8>LINK : fatal error LNK1104: cannot open file '......\Debug\lib\hpxd.lib'
8>Done building project "process_component.vcxproj" -- FAILED.
7>Done building project "partitioned_vector_component.vcxproj" -- FAILED.
5>LINK : fatal error LNK1104: cannot open file 'Debug\lib\hpxd.lib'
5>Done building project "parcel_coalescing_lib.vcxproj" -- FAILED.
========== Build: 0 succeeded, 8 failed, 2 up-to-date, 0 skipped ==========

Should I create a separate ticket?

@aserio yes please!

Created new ticket Issue #4282 to address compilation issues. Closing this ticket as the CMake issue has been resolved on the release branch with PR #4279

I'm sorry @msimberg I screwed this up. I did not properly set up the release branch on my machine. I am still seeing the error on release. I have attached the full error below:

Selecting Windows SDK version 10.0.16299.0 to target Windows 10.0.18362.
CMake version: 3.14.4
HPX version: 1.4.0
No vectorization library configured
Native TLS is enabled.
Nice threadlevel is disabled.
Stack traces are enabled.
Compiling with the native toolset
C++ mode used: C++
Performing Test HPX_WITH_CXX11_ALIAS_TEMPLATES - pre-set to TRUE
Performing Test HPX_WITH_CXX11_ALIGNAS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_AUTO - pre-set to TRUE
Performing Test HPX_WITH_CXX11_CONSTEXPR - pre-set to TRUE
Performing Test HPX_WITH_CXX11_DECLTYPE - pre-set to TRUE
Performing Test HPX_WITH_CXX11_SFINAE_EXPRESSION - pre-set to TRUE
Performing Test HPX_WITH_CXX11_DEFAULTED_FUNCTIONS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_DELETED_FUNCTIONS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_EXPLICIT_CONVERSION_OPERATORS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_EXPLICIT_VARIADIC_TEMPLATES - pre-set to TRUE
Performing Test HPX_WITH_CXX11_EXTENDED_FRIEND_DECLARATIONS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_FUNCTION_TEMPLATE_DEFAULT_ARGS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_INLINE_NAMESPACES - pre-set to TRUE
Performing Test HPX_WITH_CXX11_LAMBDAS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_NOEXCEPT - pre-set to TRUE
Performing Test HPX_WITH_CXX11_NULLPTR - pre-set to TRUE
Performing Test HPX_WITH_CXX11_NSDMI - pre-set to TRUE
Performing Test HPX_WITH_CXX11_RANGE_BASED_FOR - pre-set to TRUE
Performing Test HPX_WITH_CXX11_RVALUE_REFERENCES - pre-set to TRUE
Performing Test HPX_WITH_CXX11_SCOPED_ENUMS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_STATIC_ASSERT - pre-set to TRUE
Performing Test HPX_WITH_CXX11_VARIADIC_MACROS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_VARIADIC_TEMPLATES - pre-set to TRUE
Performing Test HPX_WITH_CXX11_OVERRIDE - pre-set to TRUE
Performing Test HPX_WITH_CXX11_ARRAY - pre-set to TRUE
Performing Test HPX_WITH_CXX11_ATOMIC - pre-set to TRUE
Performing Test HPX_WITH_CXX11_ATOMIC_128BIT - pre-set to TRUE
Performing Test HPX_WITH_CXX11_CHRONO - pre-set to TRUE
Performing Test HPX_WITH_CXX11_CSTDINT - pre-set to TRUE
Performing Test HPX_WITH_CXX11_EXCEPTION_PTR - pre-set to TRUE
Performing Test HPX_WITH_CXX11_FORWARD_LIST - pre-set to TRUE
Performing Test HPX_WITH_CXX11_STD_INITIALIZER_LIST - pre-set to TRUE
Performing Test HPX_WITH_CXX11_IS_BIND_EXPRESSION - pre-set to TRUE
Performing Test HPX_WITH_CXX11_IS_PLACEHOLDER - pre-set to TRUE
Performing Test HPX_WITH_CXX11_IS_TRIVIALLY_COPYABLE - pre-set to TRUE
Performing Test HPX_WITH_CXX11_LOCK_GUARD - pre-set to TRUE
Performing Test HPX_WITH_CXX11_STD_QUICK_EXIT - pre-set to TRUE
Performing Test HPX_WITH_CXX11_RANDOM - pre-set to TRUE
Performing Test HPX_WITH_CXX11_RANGE_ACCESS - pre-set to TRUE
Performing Test HPX_WITH_CXX11_REFERENCE_WRAPPER - pre-set to TRUE
Performing Test HPX_WITH_CXX11_REGEX - pre-set to TRUE
Performing Test HPX_WITH_CXX11_SHARED_PTR - pre-set to TRUE
Performing Test HPX_WITH_CXX11_SHARED_PTR_LWG3018 - pre-set to TRUE
Performing Test HPX_WITH_CXX11_SHUFFLE - pre-set to TRUE
Performing Test HPX_WITH_CXX11_THREAD - pre-set to TRUE
Performing Test HPX_WITH_CXX11_TO_STRING - pre-set to TRUE
Performing Test HPX_WITH_CXX11_UNIQUE_LOCK - pre-set to TRUE
Performing Test HPX_WITH_CXX11_UNIQUE_PTR - pre-set to TRUE
Performing Test HPX_WITH_CXX11_UNORDERED_MAP - pre-set to TRUE
Performing Test HPX_WITH_CXX11_UNORDERED_SET - pre-set to TRUE
Performing Test HPX_WITH_CXX11_THREAD_LOCAL - pre-set to TRUE
Performing Test HPX_WITH_CXX11_NORETURN_ATTRIBUTE - Failed
Performing Test HPX_WITH_CXX17_NOEXCEPT_FUNCTIONS_AS_NONTYPE_TEMPLATE_ARGUMENTS - Failed
Performing Test HPX_WITH_MM_PREFETCH - pre-set to TRUE
Performing Test HPX_WITH_STABLE_INPLACE_MERGE - pre-set to TRUE
Performing Test HPX_WITH_UNISTD_H - Failed
Architecture detected: x86_64
Boost version: 1.70.0
Boost version: 1.70.0
Using system allocator.
GIT commit is 7112d99df945d57919ccc5507ee981b0efe9e18f.

Configuring modules:
Module configuration summary (affinity):
HPX_AFFINITY_WITH_COMPATIBILITY_HEADERS=ON
HPX_AFFINITY_WITH_DEPRECATION_WARNINGS=ON
HPX_AFFINITY_WITH_TESTS=ON
Module configuration summary (algorithms):
HPX_ALGORITHMS_WITH_DEPRECATION_WARNINGS=OFF
HPX_ALGORITHMS_WITH_TESTS=ON
Module configuration summary (allocator_support):
HPX_ALLOCATOR_SUPPORT_WITH_COMPATIBILITY_HEADERS=ON
HPX_ALLOCATOR_SUPPORT_WITH_DEPRECATION_WARNINGS=ON
HPX_ALLOCATOR_SUPPORT_WITH_TESTS=ON
Module configuration summary (assertion):
HPX_ASSERTION_WITH_COMPATIBILITY_HEADERS=ON
HPX_ASSERTION_WITH_DEPRECATION_WARNINGS=ON
HPX_ASSERTION_WITH_TESTS=ON
Module configuration summary (basic_execution):
HPX_BASIC_EXECUTION_WITH_COMPATIBILITY_HEADERS=ON
HPX_BASIC_EXECUTION_WITH_DEPRECATION_WARNINGS=ON
HPX_BASIC_EXECUTION_WITH_TESTS=ON
Module configuration summary (batch_environments):
HPX_BATCH_ENVIRONMENTS_WITH_COMPATIBILITY_HEADERS=ON
HPX_BATCH_ENVIRONMENTS_WITH_DEPRECATION_WARNINGS=ON
HPX_BATCH_ENVIRONMENTS_WITH_TESTS=ON
Module configuration summary (cache):
HPX_CACHE_WITH_COMPATIBILITY_HEADERS=ON
HPX_CACHE_WITH_DEPRECATION_WARNINGS=ON
HPX_CACHE_WITH_TESTS=ON
Module configuration summary (checkpoint):
HPX_CHECKPOINT_WITH_COMPATIBILITY_HEADERS=ON
HPX_CHECKPOINT_WITH_DEPRECATION_WARNINGS=ON
HPX_CHECKPOINT_WITH_TESTS=ON
Module configuration summary (collectives):
HPX_COLLECTIVES_WITH_COMPATIBILITY_HEADERS=ON
HPX_COLLECTIVES_WITH_DEPRECATION_WARNINGS=ON
HPX_COLLECTIVES_WITH_TESTS=ON
Module configuration summary (compute):
HPX_COMPUTE_WITH_DEPRECATION_WARNINGS=OFF
HPX_COMPUTE_WITH_TESTS=ON
Module configuration summary (compute_cuda):
HPX_COMPUTE_CUDA_WITH_DEPRECATION_WARNINGS=OFF
HPX_COMPUTE_CUDA_WITH_TESTS=ON
Module configuration summary (compute_cuda):
HPX_COMPUTE_CUDA_WITH_DEPRECATION_WARNINGS=OFF
HPX_COMPUTE_CUDA_WITH_TESTS=ON
Module configuration summary (concepts):
HPX_CONCEPTS_WITH_COMPATIBILITY_HEADERS=ON
HPX_CONCEPTS_WITH_DEPRECATION_WARNINGS=ON
HPX_CONCEPTS_WITH_TESTS=ON
Module configuration summary (concurrency):
HPX_CONCURRENCY_WITH_COMPATIBILITY_HEADERS=ON
HPX_CONCURRENCY_WITH_DEPRECATION_WARNINGS=ON
HPX_CONCURRENCY_WITH_TESTS=ON
Module configuration summary (config):
HPX_CONFIG_WITH_COMPATIBILITY_HEADERS=OFF
HPX_CONFIG_WITH_DEPRECATION_WARNINGS=OFF
HPX_CONFIG_WITH_TESTS=ON
Module configuration summary (coroutines):
HPX_COROUTINES_WITH_COMPATIBILITY_HEADERS=ON
HPX_COROUTINES_WITH_DEPRECATION_WARNINGS=ON
HPX_COROUTINES_WITH_TESTS=ON
Module configuration summary (datastructures):
HPX_DATASTRUCTURES_WITH_ADAPT_STD_TUPLE=ON
HPX_DATASTRUCTURES_WITH_COMPATIBILITY_HEADERS=ON
HPX_DATASTRUCTURES_WITH_DEPRECATION_WARNINGS=ON
HPX_DATASTRUCTURES_WITH_TESTS=ON
Module configuration summary (debugging):
HPX_DEBUGGING_WITH_COMPATIBILITY_HEADERS=ON
HPX_DEBUGGING_WITH_DEPRECATION_WARNINGS=ON
HPX_DEBUGGING_WITH_TESTS=ON
Module configuration summary (errors):
HPX_ERRORS_WITH_COMPATIBILITY_HEADERS=ON
HPX_ERRORS_WITH_DEPRECATION_WARNINGS=ON
HPX_ERRORS_WITH_TESTS=ON
Module configuration summary (execution):
HPX_EXECUTION_WITH_DEPRECATION_WARNINGS=OFF
HPX_EXECUTION_WITH_TESTS=ON
Module configuration summary (filesystem):
HPX_FILESYSTEM_WITH_BOOST_FILESYSTEM_COMPATIBILITY=ON
HPX_FILESYSTEM_WITH_DEPRECATION_WARNINGS=OFF
HPX_FILESYSTEM_WITH_TESTS=ON
Module configuration summary (format):
HPX_FORMAT_WITH_COMPATIBILITY_HEADERS=ON
HPX_FORMAT_WITH_DEPRECATION_WARNINGS=ON
HPX_FORMAT_WITH_TESTS=ON
Module configuration summary (functional):
HPX_FUNCTIONAL_WITH_COMPATIBILITY_HEADERS=ON
HPX_FUNCTIONAL_WITH_DEPRECATION_WARNINGS=ON
HPX_FUNCTIONAL_WITH_TESTS=ON
Module configuration summary (hardware):
HPX_HARDWARE_WITH_COMPATIBILITY_HEADERS=ON
HPX_HARDWARE_WITH_DEPRECATION_WARNINGS=ON
HPX_HARDWARE_WITH_TESTS=ON
Module configuration summary (hashing):
HPX_HASHING_WITH_COMPATIBILITY_HEADERS=ON
HPX_HASHING_WITH_DEPRECATION_WARNINGS=ON
HPX_HASHING_WITH_TESTS=ON
Module configuration summary (iterator_support):
HPX_ITERATOR_SUPPORT_WITH_COMPATIBILITY_HEADERS=ON
HPX_ITERATOR_SUPPORT_WITH_DEPRECATION_WARNINGS=ON
HPX_ITERATOR_SUPPORT_WITH_TESTS=ON
Module configuration summary (local_lcos):
HPX_LOCAL_LCOS_WITH_COMPATIBILITY_HEADERS=ON
HPX_LOCAL_LCOS_WITH_DEPRECATION_WARNINGS=ON
HPX_LOCAL_LCOS_WITH_TESTS=ON
Module configuration summary (logging):
HPX_LOGGING_WITH_COMPATIBILITY_HEADERS=ON
HPX_LOGGING_WITH_DEPRECATION_WARNINGS=ON
HPX_LOGGING_WITH_TESTS=ON
Module configuration summary (memory):
HPX_MEMORY_WITH_DEPRECATION_WARNINGS=OFF
HPX_MEMORY_WITH_TESTS=ON
Module configuration summary (plugin):
HPX_PLUGIN_WITH_COMPATIBILITY_HEADERS=ON
HPX_PLUGIN_WITH_DEPRECATION_WARNINGS=ON
HPX_PLUGIN_WITH_TESTS=ON
Module configuration summary (preprocessor):
HPX_PREPROCESSOR_WITH_COMPATIBILITY_HEADERS=ON
HPX_PREPROCESSOR_WITH_DEPRECATION_WARNINGS=ON
HPX_PREPROCESSOR_WITH_TESTS=ON
Module configuration summary (program_options):
HPX_PROGRAM_OPTIONS_WITH_BOOST_PROGRAM_OPTIONS_COMPATIBILITY=ON
HPX_PROGRAM_OPTIONS_WITH_DEPRECATION_WARNINGS=OFF
HPX_PROGRAM_OPTIONS_WITH_TESTS=ON
Module configuration summary (resiliency):
HPX_RESILIENCY_WITH_DEPRECATION_WARNINGS=OFF
HPX_RESILIENCY_WITH_TESTS=ON
Module configuration summary (resource_partitioner):
HPX_RESOURCE_PARTITIONER_WITH_COMPATIBILITY_HEADERS=ON
HPX_RESOURCE_PARTITIONER_WITH_DEPRECATION_WARNINGS=ON
HPX_RESOURCE_PARTITIONER_WITH_TESTS=ON
Module configuration summary (segmented_algorithms):
HPX_SEGMENTED_ALGORITHMS_WITH_DEPRECATION_WARNINGS=OFF
HPX_SEGMENTED_ALGORITHMS_WITH_TESTS=ON
Module configuration summary (serialization):
HPX_SERIALIZATION_WITH_BOOST_TYPES=ON
HPX_SERIALIZATION_WITH_COMPATIBILITY_HEADERS=ON
HPX_SERIALIZATION_WITH_DEPRECATION_WARNINGS=ON
HPX_SERIALIZATION_WITH_TESTS=ON
Module configuration summary (static_reinit):
HPX_STATIC_REINIT_WITH_COMPATIBILITY_HEADERS=ON
HPX_STATIC_REINIT_WITH_DEPRECATION_WARNINGS=ON
HPX_STATIC_REINIT_WITH_TESTS=ON
Module configuration summary (statistics):
HPX_STATISTICS_WITH_COMPATIBILITY_HEADERS=ON
HPX_STATISTICS_WITH_DEPRECATION_WARNINGS=ON
HPX_STATISTICS_WITH_TESTS=ON
Module configuration summary (synchronization):
HPX_SYNCHRONIZATION_WITH_COMPATIBILITY_HEADERS=ON
HPX_SYNCHRONIZATION_WITH_DEPRECATION_WARNINGS=ON
HPX_SYNCHRONIZATION_WITH_TESTS=ON
Module configuration summary (testing):
HPX_TESTING_WITH_COMPATIBILITY_HEADERS=ON
HPX_TESTING_WITH_DEPRECATION_WARNINGS=ON
HPX_TESTING_WITH_TESTS=ON
Module configuration summary (thread_support):
HPX_THREAD_SUPPORT_WITH_COMPATIBILITY_HEADERS=ON
HPX_THREAD_SUPPORT_WITH_DEPRECATION_WARNINGS=ON
HPX_THREAD_SUPPORT_WITH_TESTS=ON
Module configuration summary (threadmanager):
HPX_THREADMANAGER_WITH_COMPATIBILITY_HEADERS=ON
HPX_THREADMANAGER_WITH_DEPRECATION_WARNINGS=ON
HPX_THREADMANAGER_WITH_TESTS=ON
Module configuration summary (timing):
HPX_TIMING_WITH_COMPATIBILITY_HEADERS=ON
HPX_TIMING_WITH_DEPRECATION_WARNINGS=ON
HPX_TIMING_WITH_TESTS=ON
Module configuration summary (topology):
HPX_TOPOLOGY_WITH_COMPATIBILITY_HEADERS=ON
HPX_TOPOLOGY_WITH_DEPRECATION_WARNINGS=ON
HPX_TOPOLOGY_WITH_TESTS=ON
Module configuration summary (type_support):
HPX_TYPE_SUPPORT_WITH_COMPATIBILITY_HEADERS=ON
HPX_TYPE_SUPPORT_WITH_DEPRECATION_WARNINGS=ON
HPX_TYPE_SUPPORT_WITH_TESTS=ON
Module configuration summary (util):
HPX_UTIL_WITH_COMPATIBILITY_HEADERS=ON
HPX_UTIL_WITH_DEPRECATION_WARNINGS=ON
HPX_UTIL_WITH_TESTS=ON
Configuring components:
component_storage
containers
iostreams
performance_counters
process
Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
CMake Error at tests/unit/resource/CMakeLists.txt:21 (if):
if given arguments:
"NOT" "MSVC" "AND" "GREATER" "11"

Unknown arguments specified
Configuring incomplete, errors occurred!
See also "C:/Users/adria/Git/hpx/build-release/CMakeFiles/CMakeOutput.log".
See also "C:/Users/adria/Git/hpx/build-release/CMakeFiles/CMakeError.log".

Ah, my bad. I've just pushed to a commit to the release branch that hopefully fixes it. Could you give it a try again?

@msimberg  your changes work! Interesting thing to note, it still reports that it cannot find PkgConfig but it now does not interrupt the build:

Configuring components:
component_storage
containers
iostreams
performance_counters
process
Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
Creating Doxyfile: C:/Users/adria/Git/hpx/build-release/docs/hpx_autodoc.doxy

Complies and runs hello_world as well.
Thanks.

We always try to find pkgconfig but don't require it, so the warning is harmless. However, if it's never needed (or available) on Windows we could just not look for it there.

@msimberg pkgconfig is never needed on Windows when using the native toolchain (MSVC).


chore(release): publish packages

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I honestly couldn't test the change of #1374 on my emulator because I'm traveling right now, it was all a theoretical thing. I totally rely on the CI (which does not check the actual sound output) or other developers 😅

@lukepighetti @OlegNovosad can you do us a favor and test this before release?
dependency_overrides:
  audioplayers:
    git:
      url: https://github.com/bluefireteam/audioplayers.git
      path: 'packages/audioplayers'
      ref: '1499a51037e900b7a41ef3514803db8472ed767f'
  audioplayers_platform_interface:
    git:
      url: https://github.com/bluefireteam/audioplayers.git
      path: 'packages/audioplayers_platform_interface'
      ref: '1499a51037e900b7a41ef3514803db8472ed767f'
  audioplayers_darwin:
    git:
      url: https://github.com/bluefireteam/audioplayers.git
      path: 'packages/audioplayers_darwin'
      ref: '1499a51037e900b7a41ef3514803db8472ed767f'

Would be a great help!

I honestly couldn't test the change of #1374 on my emulator because I'm traveling right now, it was all a theoretical thing. I totally rely on the CI (which does not check the actual sound output) or other developers 😅

It should™  be the same as the change they tried on the issue, so I'm pretty confident that it will work. 😄


Add python.pip_install option

Allows users to specify that pip install . should be used instead of setup.py install.
closes #2011
Feel free to close if this should be moved to the new readthedocs-build.

This looks great. It won't be put into the YAML unless there's a patch to rtd-build, as you mentioned. That could be added here: https://github.com/rtfd/readthedocs-build/blob/master/readthedocs_build/config/config.py#L204

Thanks for the pointer. I believe I have added the user config in rtfd/readthedocs-build#11.


Does not works for Arabic

Both English (en) and Persian (fa) switching works properly but when I try to set language to Arabic, app displays default language strings and maked LTR, also when I get language value, it returns ar!

Sorry for my bad English :)

I've fixed this issue by adding the following line to defaultConfig block in app/build.gradle:
resConfigs "fa", "ar"


Update docker image to use 1.17 Golang

What changed?
Update docker image to use 1.17 golang
remove bzr as it's no long exists in alpine image. Turns out Cadence image doesn't need it.

Why?
for https://github.com/uber/cadence/issues/4582

How did you test it?
Local test

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 63cbda58-2b2e-400a-bf81-5f1035d09d58

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 6 files lost coverage.
Overall coverage increased (+0.07%) to 56.885%

Files with Coverage Reduction
New Missed Lines
%

service/history/execution/mutable_state_task_refresher.go
1
73.82%

service/history/queue/timer_queue_processor_base.go
1
78.6%

common/task/parallelTaskProcessor.go
2
92.75%

service/history/queue/timer_queue_processor.go
2
58.8%

service/matching/taskListManager.go
2
74.66%

common/task/fifoTaskScheduler.go
3
82.47%

Totals

Change from base Build df78c522-cd18-4d5f-b9b8-38c0062dc6e8:
0.07%

Covered Lines:
82354

Relevant Lines:
144773

💛  - Coveralls


Implement constructor tearoffs support in DDC

This issue tracks support of the constructor tearoffs feature.  See the enclosing meta-issue for details.
The implementation issues for this feature are needed in order to have a reference when approving test failures. Further information will be added here when the implementation work starts.

Implemented in 5ea90ee.


Groups addMultiple does not add all children

https://github.com/photonstorm/phaser/blob/dev/src/core/Group.js#L376
When adding children from another group, only half of them are added. This happens because the children are removed from the group they came from, while added to the other, ie the for loop adds to i while removing from the children.length.
I'm guessing this is quite a normal scenario, but since the array could also be something else than the children of a group, A check for child parent is relevant?

Hmm first time anyone has ever reported this! So I'm guessing it's not that common. However it should work, so the recent changes I've just made to the dev branch should cover it.

Haha, yeah, maybe not very common. Thanks for the update :)


Bugfix 5 3 4 against issue #176

Overall Review
tasks/main.yml was altered to handle the user not being found in /etc/shadow.
The grep has been changed.

(grep {{ ansible_env.SUDO_USER }} /etc/shadow || echo 'not found:not found') | awk -F: '{print $2}'

In the event that the user is not found in /etc/shadow then the response "not found:not found" is given. This is then picked up by the following block to skip the password checking. A debug message is used to alert the user that this is happening.
An additional check is now being made for local accounts to check that the account has not been locked. This is achieved by checking for a single "!" at the beginning of the password hash.
Also updated dictionary in 6.1.11 to convert vars to dictionary to avoid deprecation warning.
Issue Fixes:
Fixes #176: Using an AD account to connect to host incorrectly fails rule 5.3.4
Enhancements:
Fixes #168 DEPRECATION WARNING is generating when play task 6.1.11 | AUDIT | Ensure no ungrouped files or directories exist
How has this been tested?:
Tested against a minimally configured Alma Linux 9 VM.

Created a new user with an unset password.

Local account check passes. Unset password is then detected and play fails.

Add a password to new user.

Local account check passes. Password check then passes and play continues.

Lock the account. Password hash now starts with "!"

Second password check is triggered and play fails.

Updated VM to join AD realm. Use AD account.

The first local account check returns not found. Local password checks are skipped and play continues.

Addendum:
6.1.11 Deprecation warning during audit. Updated vars to dictionary and deprecation warning avoided.
More details on testing are available if required.

hi @RoboPickle
This is a great update, thank you for taking the time, could you possibly add the empty line before each named task just for consistency.
You will find the vars deprecation should have already nbeen picked up as well in and earlier PR.
Many thanks
uk-bolly

Hi,
You are most welcome. I've added the blank lines which actually makes a real difference with the readability.
I missed that the deprecation was already handled by another PR!
Thanks
John
Sent from Proton Mail mobile
-------- Original Message --------
On 19 Feb 2024, 11:50, uk-bolly wrote:

hi @.***(https://github.com/RoboPickle)
This is a great update, thank you for taking the time, could you possibly add the empty line before each named task just for consistency.
You will find the vars deprecation should have already nbeen picked up as well in and earlier PR.
Many thanks
uk-bolly
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


Fix sign extension of immediates for LBU/LHU instructions

Ran into this bug with newlib's strlen implementation, using gcc from https://github.com/stnolting/riscv-gcc-prebuilt
Bit of a hairpulling debugging session to track this one down, anyway, the root cause is:
https://github.com/AnthonyMichaelTDM/RISC-V_emulator/blob/817b2f5e3703da68f281df570e4bda0f15c90675/src/emulator/decode.rs#L90-L92
Which incorrectly masks off 16 bits instead of 12 bits.
and
https://github.com/AnthonyMichaelTDM/RISC-V_emulator/blob/817b2f5e3703da68f281df570e4bda0f15c90675/src/emulator/decode.rs#L137-L143
The instruction decoder was not sign-extending immediates for LBU and LHU
instructions, causing them to treat address offsets as large positive values
instead of small negative ones. This caused out-of-bounds memory access when
these instructions were used with negative offsets.

To fix this you need to make 2 changes:
e.g.
                let mut imm: i32 =
                    // extract the lowest 12 bits of the immediate from the machine code
                    (machine_code >> 20) & 0xFFF;

...

                // if the instruction is not one of the unsigned instructions, sign extend the immediate
                if !matches!(
                    operation,
                    /*ITypeOperation::Lbu | ITypeOperation::Lhu |*/ ITypeOperation::Sltiu
                ) {
                    imm = imm << 20 >> 20;
                }

Aside from that, really useful code, and I'm slowly verifying all the instructions work correctly.
I noticed you haven't explicitly licensed this code, are you happy for me to use it under the terms of the MIT or Apache-2.0 licenses (with copyright attribution of course).

Great catch, thank you!
I'll push a commit including a license, but yes, MIT/Apache-2.0 with attribution is acceptable

This issue is fixed by the most recent commits, specifically  72c77767da39a136bf6962504b3f39577638b863, I probably should've done a PR, but I was feeling lazy

feel free to reopen if necessary

Awesome :+1:  Have a happy new year.
Will ping you when the thing I'm hacking on is in a better state, or if I find more problems.

Sounds great! I'm very curious about what you're using this repo for and would love to hear more. Happy new year to you as well.


Add --credits in CLI

Hi, I have a little doubt and a request, I know that the main author of arara is Paulo, but, in the description (README.md) you can read that there is a whole team behind this great work.
Currently arara --help shows the following lines:
arara 4.0 (revision 2)
Copyright (c) 2012-2019, Paulo Roberto Massa Cereda
All rights reserved

maybe it'll be nicer:
arara 4.0 (revision 2)
Copyright (c) 2012-2020, The arara team.
All rights reserved

and the option --credits is added and the original author and team members are named.
Just as an idea.
Saludos

We will ship the first part in arara v5.0 before the DANTE Frühjahrtstagung end of the month. But currently, the team does not see the need for such an extensive credits option (listing dependencies and their dependencies is something we do not want to keep and listing only the team might be an enhancement to the version flag in future releases).


[Bug] parse the output number of MaxPool incorrectly

For the following ONNX model, ONNXConverter will mistakenly parse the output number and thus triggered an assertion failure.
The ONNX structure:

You can download the model by this link:  https://github.com/jikechao/onnx_models/blob/main/model.onnx
Crash message:
Traceback (most recent call last):
...
    irmod, params = relay.frontend.from_onnx(predict_model, shape_dict, freeze_params=True)
  File "/workplace/software/tvm/tvm/python/tvm/relay/frontend/onnx.py", line 7346, in from_onnx
    mod, params = g.from_onnx(graph, opset)
  File "/workplace/software/tvm/tvm/python/tvm/relay/frontend/onnx.py", line 6963, in from_onnx
    self._construct_nodes(graph)
  File "/workplace/software/tvm/tvm/python/tvm/relay/frontend/onnx.py", line 7120, in _construct_nodes
    len(node_output), outputs_num, op_name
AssertionError: Number of output mismatch 2 vs 1 in MaxPool.

reproducible script:
import onnx
from tvm import relay

onnx_model_path = "model.onnx"
model = onnx.load(onnx_model_path)
irmod, params = relay.frontend.from_onnx(model, {'x': (1, 1, 5, 5)}, freeze_params=True)

@masahi @jwfromm @vvchernov Could you help me check this crash? Thanks a lot!

Hello @jikechao! It is simply not supported on ONNX front-end of TVM. The implementation of MaxPool (AveragePool as well) was done for onnx opset = 1, but optional second output (Indices) appeared only since opset = 8. It needs to extend implementation for the op, if you do it, it will be good

@vvchernov Thanks for your comments! Indeed, This crash was caused by Indices appearing since opset=8. However, this feature existing more than 5 years. Thus, Supporting Indices to avoid this crash may not be trivial. Thus, I'll try to fix it.

Hello @jikechao! Some nits may be help you to fix. There can be problems with optional output and indices calculation, in both cases you can see how it was implemented for scatter_elements (ScatterElements class)


Fix linking content_shell

Fixes #2393 according to feedback. This is slightly hacky as we have to override a few assertions to convince the build system to link content_shell_lib with chrome/common.

I wonder why this didn't hit anyone else.

This should be fine, but I'll be out this weekend and won't be able to test the changes until afterwards.
In the long run it might probably be better to move code somewhere else (again 😅).

Sure, I'll rebase the other PR in a bit.

Thanks everyone. Debian Chromium 114.0.5735.198-1 + u-c master now builds for me without issue.


Only setup Docker Buildx when deploying

Coverage: 93.734%. Remained the same when pulling 467a5dfb22cb590de7fd381e81a82c355e848412 on cody-docker-buildx into f27125758211987310fd4c1863ac313af9743cf5 on main.