Roadmap #1

The state of the code is becoming more and more complex, and I need to simplify the design for my sanity. At the same time, I have written so many classes and functions that docs have become important, even if for no other reason than for my own personal use. Here are a couple of things I need to do, and I'm pretty sure it should be in this order.

[x] re-structure the submodules. objects is getting huge, and I think it would be better to move object type, e.g. Ball along with its child classes BallRender, BallHistory, etc., into their own submodules. engine may be better called system, and all algorithm stuff may be best put in a shot_algorithm submodule that contains a class that can select whichever algorithm to use based on keyword.
[x] Re-implement game state using Epihaius's amazing class: https://discourse.panda3d.org/t/accept-watches-for-a-toggle-pause-message-but-condition-is-met-over-multiple-frames/27077/7

objects has been decomposed into cue.py, ball.py, and table.py

engine has been decomposed into system and evolution. Inside evolution, support for multiple shot evolution algorithms has been implemented. A naive discrete time integrator has been implemented

Mission accomplished


semigroupoids 5.2

semigroupoids-5.2 is out of bounds for:

[ ] active-<IP_ADDRESS> (>=1.2 && < 5.2). Brent Yorgey<EMAIL_ADDRESS>@byorgey. @bergey @byorgey @fryguybob @jeffreyrosenbluth. Used by: library, test-suite
[ ] insert-ordered-containers-<IP_ADDRESS> (>=4.3 && < 5.2). Oleg Grenrus<EMAIL_ADDRESS>@phadej. @phadej. Used by: library, test-suite
[ ] monoid-extras-0.4.2 (>=4.0 && < 5.2). Brent Yorgey<EMAIL_ADDRESS>@byorgey. @bergey @byorgey @fryguybob @jeffreyrosenbluth. Used by: library
[ ] servant-client-0.10 (>=4.3 && < 5.2). Haskell Servant<EMAIL_ADDRESS>@SoenkeHahn @jkarni @phadej. Used by: library
[ ] tdigest-0.1 (==5.1.*). Oleg Grenrus<EMAIL_ADDRESS>@phadej. @futurice. Used by: library
[ ] tdigest-Chart-0 (==5.1.*). Oleg Grenrus<EMAIL_ADDRESS>@phadej. @futurice. Used by: library
[ ] these-0.7.3 (>=1.0 && < 5.2). Oleg Grenrus<EMAIL_ADDRESS>@phadej. @isomorphism. Used by: library

Revised semigroupoid upper bounds for active and monoid-extras on Hackage.

@RyanGlScott are you planning a cascade of major releases for Edwards packages? If e.g. profunctors and free etc will be getting major releases soon, it might be less work to wait until kmettverse is updated?

@phadej, I do hope to push new releases of all the packages listed in https://github.com/ekmett/lens/issues/709 sometime soon, yes. The thing that's the limiting factor right now is getting push access from @ekmett for those repos :)
However, profunctors and free aren't on that list, so you needn't worry about those (at least from my end).

my packages updated.

Woops. That is on me. Let me see what I can do.

Okay, Ryan. You now have access to everything on that list on both hackage and github.

Fantastic, thanks @ekmett!

https://www.stackage.org/nightly-2017-04-26/package/semigroupoids-5.2


eng-2888-investigate-resource-edit-bug

Describe your changes and why you are making these changes
Can edit Postgres integration name now.
The issue is that none of the Config models have an exec_state field and we do not allow extra fields so pydantic throws an error when trying to convert the json.
Not sure who has context regarding why there is an exec_state field. Once we have more information, we can update this PR so that we can either remove that field from the spec or update the model to expect it (not optional field).
Related issue number (if any)
ENG 2888
ENG 2864
Checklist before requesting a review

[x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[x] I have performed a self-review of my code.
[N/A] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[N/A] If this is a new feature, I have added unit tests and integration tests.
[N/A] I have run the integration tests locally and they are passing.
[x] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[x] All features on the UI continue to work correctly.
[x] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@eunice-chan can you also add the workflow_dispatch trigger to this job?


Plz see the new update, it adds many pre-calculated results to make it seems smarter :D

Cool design.
Seem much better now :D


refactor [Packagist] service

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @Prouser123!

  Generated by :no_entry_sign: dangerJS against cd17b48bcac3c65b16391e6a670e5f1792788e49

This pull request introduces 1 alert when merging cd17b48bcac3c65b16391e6a670e5f1792788e49 into 6bfa9b1b41915ac07a4b6dfa304436a97197d115 - view on LGTM.com
new alerts:

1 for Useless assignment to local variable

Comment posted by LGTM.com

Hey @Prouser123, would you have a moment to respond to these comments?

I'm a little caught up with other (school) work right now, but when I have some free time I'll gladly take a look! 😃

Hi! Do you have a moment to wrap this up? If not, I or one of the other maintainers could do it. 😁

Interesting error to note before force-push:
https://circleci.com/gh/badges/shields/46763

Interesting error to note before force-push:
https://circleci.com/gh/badges/shields/46763

Spurious error, no worries!

https://shields-staging-pr-3004.herokuapp.com/

@calebcartwright Good to go?

@paulmelnikow yup - 🚀


Jetpack activation error

When trying to connect Jetpack to a WordPress.com account, an error is produced in the Heroku logs and Jetpack complains the site is inaccessible or returned an error: transport error - HTTP status code was not 200 (502) [-32300]. The error log shows:
2016-12-23T15:43:39.349647+00:00 app[web.1]: 2016/12/23 15:43:39 [error] 134#0: *93 upstream sent too big header while reading response header from upstream, client: <IP_ADDRESS>, server: localhost, request: "POST /xmlrpc.php?for=jetpack HTTP/1.1", upstream: "fastcgi://unix:/tmp/heroku.fcgi.13937.sock:", host: "pjb-heroku-wp.herokuapp.com", referrer: "https://pjb-heroku-wp.herokuapp.com/xmlrpc.php?for=jetpack"
I've reproduced this by cloning the repository, initializing a new Heroku app, activating Jetpack, and then connecting to WordPress.com.

Modifying the Nginx proxy buffer settings eliminates the above error but simultaneously introduces a new one.
I added the following to the support/nginx.inc.conf file:
proxy_buffer_size 128k; proxy_buffers 4 256k; proxy_busy_buffers_size 256k;
The error log shows:
...[error] 125#0: *12 recv() failed (104: Connection reset by peer) while reading response header from upstream, client: <IP_ADDRESS>, server: localhost, request: "POST /xmlrpc.php?for=jetpack&token=l%5EzPuIvuDWf%25%5EUnVm65Nsgx%26u82qa%29tT%3A1%3A0&timestamp=1482527583&nonce=uinHML6GwN&body-hash=lrmKnCA6pjrU%2FJugP4U8pWyAZQI%3D&signature=rjpA4i0KPDWQaV52ndMMQ2rtgWQ%3D HTTP/1.1", upstream: "fastcgi://unix:/tmp/heroku.fcgi.13937.sock:", host: "pjb-heroku-wp.herokuapp.com", referrer: "https://pjb-heroku-wp.herokuapp.com/xmlrpc.php?...

It turns out the only change necessary to address this issue was to revert to PHP 7.0.x (from 7.1.x). In my testing, the Nginx proxy buffer settings did not need to be modified. Jetpack is activated and working properly for me now.

Fixed by #75, thanks for the PR!

Thanks @xyu !

I have the latest release of this repo and I'm still receiving this same error. My heroku install log shows:
remote: -----> Installing platform packages...
remote:        - php (7.0.15)
remote:        - ext-gd (bundled with php)
remote:        - apache (2.4.20)
remote:        - nginx (1.8.1)
remote: -----> Installing dependencies...
remote:        Composer version 1.2.4 2016-12-06 22:00:51
remote:        Loading composer repositories with package information
remote:        Installing dependencies from lock file
remote:          - Installing composer/installers (v1.2.0)
remote:            Loading from cache
remote:
remote:          - Installing wordpress/wordpress (4.7.2)
remote:            Loading from cache


Problem parsing SASS if function

What version of Sass Lint are you using?

1.9.1

What did you do? Please include the actual source code causing the issue.
.form__input {
    background-color: white if(not $css-reset, !important, unquote(""));
}

What did you expect to happen?

No errors or warnings

What actually happened? Please include any error messages given to you by Sass Lint.

"error  Please check validity of the block starting from line ..."

Potential use case: http://stackoverflow.com/questions/39167183/scss-if-function-without-false-else-clause/

Hi @sathomas This is an issue with Gonzales-pe the AST we use to parse your code. Would you mind reporting this there please?
https://github.com/tonyganch/gonzales-pe/issues
Thanks!

This is fixed in the newly released version v1.11.0. Please let me know if you still have issues. Thanks!


live stream

Hi David,
Thank your for your tutorials, they are really helpful. Not sure if this is the right place but maybe other will also find this question relevant.
I am trying to stream live content, instead of serving a video file with a known size. Ideally the video could be from a webcam or some other sort of camera. I want the video to stream potentially forever (days or weeks or even months). How can I make this work?
Thanks!

I didn't do this but If I had to do I'd try the following
Option 1

save the incoming image from whatever in to a open end file
in nodeJS you open that file as read only, the dat will pile up there

when you get a request from the browser you discard the range the video player wants and give it what you have.
Option 2
See if there is a npm module to handle webcams. then check what option do they give you to store the video, ideally you'd want this stream to be saved in memory in to a Buffer (pointless to store it on a drive first), and read the video that from that buffer, while discarding again the range of the Video player.
Option 3
Check if the video player have a "live" mode, where it dose not send the range, and will accept any amount of dat you'll send to it.
I hope this ideas will help, and if you come up with a good solution don't hesitate to share it :)


Purge Data from the UI

What do you think about a button in the UI to purge the data?
Maybe "ALL Data" is good enough.
bin/console messenger:monitor:purge --older-than all
https://github.com/zenstruck/messenger-monitor-bundle#messengermonitorpurge-command

Good idea. Thinking a Purge button in the toolbar that deletes messages for the current filter.

Think we'd also need another configurable role for this operation.


update OpenCL Driver 16.1 > 18.1

Intel® CPU Runtime for OpenCL™ Applications 18.1 for Linux* OS (64bit only)
https://software.intel.com/content/www/us/en/develop/articles/opencl-drivers.html#cpu-section

I will install this and test to see if the version upgrade breaks anything

please resolve the merge conflict

I was able to resolve the conflict, thanks for the PR!


markdown-it-checkbox Integration

I am trying to use this plugin: https://github.com/mcecot/markdown-it-checkbox for the a checkbox in the messages. Somebody can give me some help. After I have installed the plugin and then declared the new markdown. How can I make it work?

Just like that :
import Markdown from "react-native-markdown-renderer"
import markdownItCheckbox from "markdown-it-checkbox"

import MarkdownIt from "markdown-it"

const md = MarkdownIt().use(markdownItCheckbox)

const App = () => (
  <View style={styles.container}>
    <Markdown markdownit={md}>
      {copy}
    </Markdown>
  </View>
)

export default App


Spooky Log Warning

This warning in log:
[Server thread/WARN]: Couldn't create template entity of biomemakeover:adjudicator (class net.minecraft.class_1297)... Defaulting to empty
[Server thread/WARN]: java.lang.IllegalStateException: Should always be able to create a chunk!
Full Log: https://paste.ee/p/0ZBus

you are correct, that is spooky.


Disable OpenShift tests, which are broken in Quarkus 3.2.0.Final

Summary

https://github.com/quarkusio/quarkus/issues/34645

Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[x] Refactoring
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[x] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

Please create follow-up PR.

@michalvavrik that is correct, it looks like 3.2.0 has changes, which broke our format checks.
But I would prefer to run some tests on Openshift before merging this one :)

But I would prefer to run some tests on Openshift before merging this one :)

I didn't run OCP tests because this PR only disables them, I can't imagine how it can break anything. Give me a hint and I shall be smarter next time.


Display AI dialogue in text box

The text that is sent into the OpenAIDictate function is now displayed in the dialogue box for the NPC. The dialogue is only displayed when the NPC is ready to talk. Until then "I'm thinking" is displayed. This is to allow the user to read the answer from the AI in addition to hearing it spoken verbally
Issue Number: #309

Great job! Works really nicely.


Switch to emulator mode whenever you pass development credentials

We didn't like to be forced to use an environment to switch to emulator mode, specifically because we have multiple instances that don't all connect to the emulator. This PR changes the behaviour a bit so that, when you don't use an environment variable, you can switch to emulator mode simply by providing the emulator credentials. Much simpler!

This is a good change, but we're not going to merge it since we in fact just made it in a slightly different way. :) This will be merged into the dev branch in a few days and come out in our next big release. Now rather than even using the environment variable or even emulator credentials you can just set a flag when you instantiate such as TableService(is_emulated=True).


gradio: clean-up

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Side note for @samdroid-apps:
Gradio development was abandoned, and in the same Git repo the complete rewrite in Rust started - the ShortWave. Also main repo was moved to GNOME GitLab. Main dev said to me about the stable release that "Don't expect anything soon, but you will know when the first version is released :)".
So you probably want to support future stable releases of the ShortWave.


Support tap-dbt-artifacts

I think a really interesting use case for Meltano users would be to pair dbt_artifacts with https://github.com/prratek/tap-dbt-artifacts
Just from eyeballing the staging models in dbt_artifacts and comparing them with the the schemas generated by tap-dbt-artifacts, it looks like it should be pretty easy to get these two talking to each other; I can imagine a few potential approaches but would might be to create staging tables that shape the tap-dbt-artifacts generated tables into the form expected by the sources defined at https://github.com/brooklyn-data/dbt_artifacts/blob/main/models/staging/sources.yml
I'm interested in taking a stab at this but would be curious for feedback on best approach from the perspective of this package's maintainers.

Hey @andrewcstewart this is a great idea. I can see this package being configurable with a variable like 'artifact_source' which could take on values along the lines of:

'single_artifact_table' (We call this the V1 upload method)
'flattened_artifact_tables' (We call this the V2 upload method)
'tap-dbt-artifacts' (This new thing)

The staging models would then be compiled differently depending on this variable to match the source data. What do you think?

Hi @NiallRees - Yeah that sounds like a good way to handle multiple sources.
I just noticed that this plugin is primarily angled towards Snowflake - I'm wondering (w/o having yet scoured the SQL dialect of the package models) if that is primarily due to the current upload method being Snowflake specific?  For example, would tap-dbt-artifacts open up the possibility of using different adapters?

The reason it's currently only Snowflake compatible is that the org it was originally built for were using Snowflake, the artifact upload method using PUT came later. Additional loading techniques absolutely opens up the possibility of adding compatibility with other warehouses though!

We've been busy reimplementing the package, opening up this package to be compatible with more adapters (adding databricks compatibility out of the gate). We'd love any feedback you have: https://github.com/brooklyn-data/dbt_artifacts/releases/tag/1.0.0b1


Publish documentation changes needed to use Adobe I/O Events.

Also added a sample NodeJS webhook app.

👍


Is there a way to delete things you have added?

I spawned some things that just get in the way now and sorry for that.  I guess it's a way for me to learn.
Now I need to know how to fix this by deleting those mistakes and start  over and make it right.

You can learn by reading the documentation, especially the Command reference. There is a command called makill to delete an addon.

I went and read the documation and for the life of me I can't figure out how to delete or kill those spawned items like the market place.  I even tried using /tls to move them.  All  that happened then was I sank into the ground and got booted for a hack 200.  And since I own the server I don't understand how I got booted.  Was glad I make a back up  or I would have been locked out of my own server.

Since you didn't say you were able to solve the issue, I will re-iterate from my previous message that the makill command will delete the addon/entity you are looking at.
The reason you got moved while using telekinesis is probably that the marketplace entity was really close to you, so when you moved your camera view to move the object, the object pushed into you and moved your player, which subsequently moved the marketplace again to maintain within range of your character. This created a cycle where you were continuously pushed very quickly.
Closing this issue as the solution has been stated twice.


Expose resource control to provide QoS for performance sensitive workloads

/kind enhancement
Summary
Dividing physical CPUs into vCPUs is one solution system admins use in large cloud environments to maximize cpu usage and limit cpu idle time.    Breaking CPUs into smaller units means workloads are sharing physical resources.
When bringing performance sensitive or high priority VMs to the cloud, they can be negatively affected by the shared CPU resources. A few years ago, the Linux kernel team created resource control (resctl) to provide find-grained control of these "shared" resources.  The solution allows for admins to control the shared L3 cache, Memory Bandwidth Allocation (MBA), ect..., in order to preserve workload QoS.  LibVirt also exposes these controls for Virtual Machines - https://libvirt.org/formatdomain.html#cpu-tuning.
KubeVirt can extend the existing cpu controls to expose resource control settings for VirtualMachineInstances.  Example vCPU pinning:
  <cputune>
    <vcpupin vcpu='0' cpuset='3'/>
    <vcpupin vcpu='1' cpuset='4'/>
    <vcpupin vcpu='2' cpuset='11'/>
    <vcpupin vcpu='3' cpuset='12'/>
  </cputune>

Example domain xml using Memory Bandwidth Allocation (MBA) and cache monitoring with pinned vCPUs:
  <cputune>
    <vcpupin vcpu='0' cpuset='3'/>
    <vcpupin vcpu='1' cpuset='4'/>
    <vcpupin vcpu='2' cpuset='11'/>
    <vcpupin vcpu='3' cpuset='12'/>
    <cachetune vcpus='0-3'>
      <cache id='0' level='3' type='both' size='3' unit='MiB'/>
      <cache id='1' level='3' type='both' size='3' unit='MiB'/>
      <monitor level='3' vcpus='1'/>
      <monitor level='3' vcpus='0-3'/>
    </cachetune>
    <memorytune vcpus='0-3'>
      <node id='0' bandwidth='60'/>
    </memorytune>
  </cputune>

Use Cases
Noisy Neighbors
In a multi-tenant cloud environment, workloads running on the same server can interfere with each other.  Workloads may share the same physical CPU or if they run on different physical CPU cores, they can share the same L3 cache, memory controller, ect.... So when a workloads starts to consume a disproportionately large amount of resources, another application, or tenant, will be affected.
Latency-Critical Workloads
With many performance sensitive workloads sharing a cloud environment, high priority applications need a way to get reliable and predictable performance.
Assumption
The Kubernetes CPU manager would still be responsible for resource allocation and KubeVirt's role is still to expose the VM to the resources it was allocated by Kubernetes.

@jeniferh @rmohr

How are these typically exposed in the pod spec, as another resource quantity and then Kubernetes hands the pod the info on the correct resctl topology, so Kuebvirt only needs to map the *tune vcpu lists based on how they are pinned to host cpus?

Yes exactly.  This feature is similar to exposing cpus on the VMI spec, so that the virt-launcher can pickup the cpus that were allocated to the pod and add them to VM's domain spec.

cc @vladikr

@rthallisey would you see kubevirt responsible for creating this or do you want to expose it? For instance I would expect that kubevirt would model the l3 cache to match the specification of the node sockets automatically. Taking

The Kubernetes CPU manager would still be responsible for resource allocation and KubeVirt's role is still to expose the VM to the resources it was allocated by Kubernetes.

it sounds like this is your assumption too?

Wouldn't guaranteed CPUs with a static policy achieve a similar level of isolation?

@rmohr yes, that's my assumption. This is very similar, almost identical, technically to adding vcpu support in kubevirt.   KubeVirt exposes the vcpu field on its APIs and wires it up to the guest.  The CPU Manager or some other plugin would handle communication with the kube-scheduler.
Hey @fabiand.  For some use cases, the guaranteed CPU policy works fine.  For instance, it exposes cpu sets which is great if I want my VMI to be the exclusive owner of a whole CPU.  The guaranteed CPU policy will take a CPU out of the shared pool and allocate it to a pod.  But if I want to pin the VM to a CPU and still allow other processes on that CPU, then guaranteed policy is too strict.  The latter use-case is what I'd like to solve with this enhancement because it allows admins to more tightly pack VMs.

But if I want to pin the VM to a CPU and still allow other processes on that CPU, then guaranteed policy is too strict. The latter use-case is what I'd like to solve with this enhancement because it allows admins to more tightly pack VMs.

@rthallisey the two use-cases you have mentioned are in serious conflict with this statement.
When you allow vCPUs to be pinned to a physical CPU that is shared with other processes - this is a way to invite a noisy neighbor, not to isolate it.
This is even worse for latency-critical applications, the second use-case you have mentioned, these applications would require exclusive access to a physical CPU.

@rmohr yes, that's my assumption. This is very similar, almost identical, technically to adding vcpu support in kubevirt. KubeVirt exposes the vcpu field on its APIs and wires it up to the guest. The CPU Manager or some other plugin would handle communication with the kube-scheduler.

Could you please provide an example of an API you are thinking about?

KubeVirt already supports the pinning of guests' vCPUs to physical CPUs allocated to the vmipod by the CPU manager. [1]
It also supports the mapping of the hosts' NUMA topology to the guest [2] - this works best for large VMs that take the whole node resources.
We have also recently added support for running real-time workloads [3]
All of these methods pin vCPUs on physical CPUs and rely on the CPU manager to allocate exclusive physical CPUs.
[1] https://kubevirt.io/user-guide/virtual_machines/dedicated_cpu_resources/
[2] https://kubevirt.io/user-guide/virtual_machines/numa
[3] https://kubevirt.io/user-guide/virtual_machines/numa/#running-real-time-workloads

As for the cachetune and memtune, these would require libvirt to have access to hosts' resctrl. Virt-launcher pod is unprivileged and I doubt it would have access.
However, it seems that libcontainer has support for Intel RDT features [1], so probably this can be controlled on the pod level - however, I have never tried.
[1] https://github.com/opencontainers/runc/blob/master/libcontainer/intelrdt/intelrdt.go

@rthallisey the two use-cases you have mentioned are in serious conflict with this statement.

The two use-cases I described are legitimate use-cases for the enhancement - L3 QoS.  However, I agree with you that in general resctl isn't the only way to solve the problem.  Fabian's suggestion is one way, but I illustrated why it doesn't go far enough.

When you allow vCPUs to be pinned to a physical CPU that is shared with other processes - this is a way to invite a noisy neighbor, not to isolate it.
This is even worse for latency-critical applications, the second use-case you have mentioned, these applications would require exclusive access to a physical CPU.

That's correct - I'm inviting the noisy neighbor problem with non exclusive CPUs.  However, I'm saying that I want to control that problem with resctrl.
Also I want to point out that this doesn't have to be a "resctl" solution.  What I'm acknowledging is that there are shared resources at the CPU level and they aren't exposed today.  In other words, I'd like to give the admin something like:
spec:
  domain:
    cpu:
      llc: 30%  # last level cache (Shared L3 cache)

Could you please provide an example of an API you are thinking about?

https://github.com/kubevirt/kubevirt/pull/638

@rthallisey the two use-cases you have mentioned are in serious conflict with this statement.

The two use-cases I described are legitimate use-cases for the enhancement - L3 QoS. However, I agree with you that in general resctl isn't the only way to solve the problem. Fabian's suggestion is one way, but I illustrated why it doesn't go far enough.

When you allow vCPUs to be pinned to a physical CPU that is shared with other processes - this is a way to invite a noisy neighbor, not to isolate it.
This is even worse for latency-critical applications, the second use-case you have mentioned, these applications would require exclusive access to a physical CPU.

That's correct - I'm inviting the noisy neighbor problem with non exclusive CPUs. However, I'm saying that I want to control that problem with resctrl.

Intel RDT may only be a supplementary measure... Even if it allows to somehow to control the L3 cache allocation that all CPUs in a given socket use, it is worth nothing if there is another vCPU (or any other thread/process) that steals cputime. If CPUs are not exclusive, personally I don't understand how RDT can help.
Just my 2c

Also I want to point out that this doesn't have to be a "resctl" solution. What I'm acknowledging is that there are shared resources at the CPU level and they aren't exposed today. In other words, I'd like to give the admin something like:
spec:
  domain:
    cpu:
      llc: 30%  # last level cache (Shared L3 cache)

FWIW, QEMU exposes (by default) Virtual L3 cache to guests. That's the reason why we don't have a tunable in our API.

So, let me ask this differently. :)
Is this ticket about us properly supporting Intel RDT (CAT and MBA)?

I can just second what Vladik says: We really try to push things where they belong. Getting better shared resource handling is something we'd want to see in Kubernetes in order to do the right thing. Or is there a reason why this would not apply to containers?
However, did somebody think about some hook mechanism (existing or something new) to support you until work like thislands in Kube?

Right, L3 cache tunables are not in K8s today.  That was my assumption too.   The enhancement I'm interested in from KubeVirt is creating some hooks that will expose L3 cache tunables while this work is pushed into K8s.
I can think of a few ideas for how this would look:

Make the virt-launcher privileged, mount the resctrl pseudo filesystem and let virt-launcher or a prestart hook assign resctrl settings.  This option would need to be behind a flag since it changes the existing privilege model.
Add tunables to the VMI spec.  Virt-handler will let CPU Manger assign CPUs to the pod, then gather tunables from the VMI spec and apply the resctrl settings.
Add tunables to the VMI spec.  Assume the CPU Manager or some other solution will handle all the resctl settings by reading the VMI spec or some annotations that get added to the virt-launcher pod.

@rthallisey the entire discussion reminded me to a talk I watch at KubeCon 2021 about Smarter runtime.
I don't know how far they got with this effort

@rthallisey my worry is just that we are adding to much kubevirt specific tunables into the core of kubevirt. I'd like ot avoid this in order to rather inherit from Kubernetes in general. For several reasons, like consistent experience between containers and VMs, ensuring to create synergies, less maintenance burden, etc.
OTOH we want to see use-cases like this enabled, at best by using a strong plugin mechanism (extend what we have).

In a community meeting a few weeks ago, I agreed to go over a POC of 1) in a future community meeting (I still plan to do that).  I'm hoping that will provide clarity on a direction, whether that's a plugin mechanism, one of the options I listed, or something else.

/remove-lifecycle stale

Haven't had a chance to get back to this.  Going to make as closed
/close


[Playlist] Easy way to access

I discover I can add songs to playlist but how I can launch playlist, in the main window, it will be great to have a place to display the playlist, I don't see anything about playlist in the Wiki.

Press the number 5 it will jump to the playlist area.

Thank you! I find out it was written in the wiki: https://github.com/clangen/musikcube/wiki/user-guide, but it's curious it's not accessible via main link on the app. Thank you !!

@githubdevuser any reason this can't be closed?


Prohibit changing the email (which is involved in user registration) and password.

It's enough to change open-api spec and UpdateUser model

The task was already completed.


Data size

Is there any way the 1.25MB file with emojis. that is loaded into memory, could be made WAY smaller?

Hi @ivanjaros.
I'm not sure how we can reduce the emoji's variable size. Do you have any ideas about that? And why is 1.25 MB critical for you?

My current use case is that I want to filter out emojis and so having to keep over 1meg of data for it in memory is extreme. So I was wondering if there is a way the dataset can be compressed somehow? If not, no worries, I got recommendation for a solution in uniseg library that won't require entire dataset. I tried to do it manually by defining the unicode ranges but it was not working due to those multiple runes issue that you're using uniseg for.


Review some types and casts

As you suggested here I reviewed some types and casts in rres-raylib.h. (only the most obvious things)
I have seen the use in some places of uint8_t while all the rest of the code uses unsigned char, should this be corrected for consistency or is it a personal choice?

@Bigfoot71 thank you very much! way better! 👍🙂


Not always working with Smart cables from Applied Energistics 2

I try to connect a side with a smart cable from Applied Energistics and inside the machine add an interface block which should provide some blocks for the machine to work with. I got it to work one time, but now i can't get it to work again. I'm running the mod through Modsauce, might it be something with the pack?

You have given very little information for me to be able to help you. It should work and it does work when I test it.
Please provide the steps necessary to reproduce this in a newly created world.

Sorry, i'm using compactmachines-1.7.10-1.13 and appliedenergistics2-rv2-beta-7. It seems to work when i restarted the server. What more info would you like?

You are using a very outdated version. Several AE2 issues have been fixed since 1.13
Please update and try again.


v0.8 API takes some params for homestore init.

Codecov Report

Merging #29 (107ab2c) into main (f49e03b) will decrease coverage by 0.45%.
The diff coverage is 86.36%.

:exclamation: Current head 107ab2c differs from pull request most recent head c6a673b. Consider uploading reports for the commit c6a673b to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   89.29%   88.85%   -0.45%
==========================================
  Files          17       17
  Lines         299      314      +15
  Branches       28       28
==========================================
+ Hits          267      279      +12
- Misses         16       19       +3
  Partials       16       16

Files Changed
Coverage Δ

src/mocks/tests/BlobManagerTest.cpp
96.66% <83.33%> (-3.34%)
:arrow_down:

src/mocks/tests/PGManagerTest.cpp
97.36% <83.33%> (-2.64%)
:arrow_down:

src/mocks/tests/ShardManagerTest.cpp
97.50% <83.33%> (-2.50%)
:arrow_down:

src/include/homeobject/homeobject.hpp
100.00% <100.00%> (ø)

src/lib/homeobject_impl.cpp
100.00% <100.00%> (ø)

src/lib/homeobject_impl.hpp
100.00% <100.00%> (ø)

src/mocks/mock_homeobject.cpp
100.00% <100.00%> (ø)

Codecov Report

Merging #29 (ef5639f) into main (f49e03b) will decrease coverage by 7.54%.
The diff coverage is 81.63%.

:exclamation: Current head ef5639f differs from pull request most recent head 1bd98bd. Consider uploading reports for the commit 1bd98bd to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   89.29%   81.76%   -7.54%
==========================================
  Files          17       14       -3
  Lines         299      170     -129
  Branches       28       23       -5
==========================================
- Hits          267      139     -128
  Misses         16       16
+ Partials       16       15       -1

Files Changed
Coverage Δ

src/include/homeobject/blob_manager.hpp
0.00% <ø> (ø)

src/mocks/mock_homeobject.hpp
100.00% <ø> (ø)

src/mocks/mock_blob_manager.cpp
78.57% <76.00%> (-6.85%)
:arrow_down:

src/mocks/mock_shard_manager.cpp
80.55% <78.57%> (-6.24%)
:arrow_down:

src/include/homeobject/homeobject.hpp
100.00% <100.00%> (ø)

src/lib/blob_manager.cpp
100.00% <100.00%> (ø)

src/lib/homeobject_impl.cpp
100.00% <100.00%> (ø)

src/lib/homeobject_impl.hpp
100.00% <100.00%> (ø)

src/mocks/mock_homeobject.cpp
100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


🔧 Update pre-commit, autoflake version, black version

Thanks! This was handled in https://github.com/tiangolo/typer/pull/549. Given that, I'll close this one. :cake:


[7.1.0] iOS crash when using Angular animations

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):

CLI: 5.1.0
Cross-platform modules:
Android Runtime: 5.1.0
iOS Runtime: 5.1.0
Plugin(s):

"nativescript-angular": "^7.1.0",
    "nativescript-feedback": "^1.3.3",
    "nativescript-iqkeyboardmanager": "^1.3.0",
    "nativescript-orientation": "^2.2.1",
    "nativescript-plugin-firebase": "file:../nativescript-plugin-firebase/publish/package/nativescript-plugin-firebase-7.4.3.tgz",
    "nativescript-theme-core": "~1.0.4",
    "nativescript-ui-sidedrawer": "~5.0.1",
    "nativescript-webview-interface": "^1.4.2",

NativeScript-Angular: 7.1.0
Angular: 7.1.3

Describe the bug
We're the following error on iOS, when using Angular's built in animation support.
***** Fatal JavaScript exception - application has been terminated. *****
Native stack trace:
nw_endpoint_flow_protocol_connected [C6.1 IPv4#dd7d11d1:443 in_progress channel-flow (satisfied)] Transport protocol connected
TIC TLS Event [6:0x28254e100]: 1, Pending(0)
TIC TLS Event [6:0x28254e100]: 2, Pending(0)
1   0x102637f84 NativeScript::reportFatalErrorBeforeShutdown(JSC::ExecState*, JSC::Exception*, bool, bool)
2   0x102664fdc NativeScript::FFICallback<NativeScript::ObjCMethodCallback>::ffiClosureCallback(ffi_cif*, void*, void**, void*)
3   0x10313d578 ffi_closure_SYSV_inner
4   0x1031401b4 .Ldo_closure
5   0x1d695b5fc __NSFireTimer
6   0x1d5e39bf0 <redacted>
7   0x1d5e39920 <redacted>
8   0x1d5e39154 <redacted>
9   0x1d5e34030 <redacted>
10  0x1d5e335b8 CFRunLoopRunSpecific
11  0x1d80a7584 GSEventRunModal
12  0x2029f0bc8 UIApplicationMain
13  0x103140044 ffi_call_SYSV
14  0x10313cc8c ffi_call_int
TIC TLS Event [6:0x28254e100]: 2, Pending(0)
TIC TLS Event [6:0x28254e100]: 11, Pending(0)
TIC TLS Event [6:0x28254e100]: 14, Pending(0)
15  0x10313c750 ffi_call
16  0x102605740 NativeScript::FFICall::call(JSC::ExecState*)
17  0x10313b80c llint_entry
18  0x10313abd0 llint_entry
19  0x10313abd0 llint_entry
20  0x10313abd0 llint_entry
21  0x10313abd0 llint_entry
22  0x10313abd0 llint_entry
23  0x10313abd0 llint_entry
24  0x10313abd0 llint_entry
25  0x10313abd0 llint_entry
26  0x10313abd0 llint_entry
27  0x10313abd0 llint_entry
28  0x103133870 vmEntryToJavaScript
29  0x102f298d8 JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
30  0x102ef5940 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)
31  0x1030c8c6c JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&, WTF::NakedPtr<JSC::Exception>&)
System Trust Evaluation yielded status(0)
TIC TLS Trust Result [6:0x28254e100]: 0
JavaScript stack trace:
1   _getNativeAnimationArguments@file:///app/vendor.js:104325:43
2   @file:///app/vendor.js:104291:62
3   play@file:///app/vendor.js:104260:35
4   animate@file:///app/vendor.js:104810:27
5   @file:///app/vendor.js:104783:58
6   runTask@file:///app/vendor.js:66908:57
7   invokeTask@file:///app/vendor.js:67216:41
8   timer@file:///app/vendor.js:68281:34
9   invoke@file:///app/vendor.js:102880:53
10  runGuarded@file:///app/vendor.js:66871:53
11  tick@file:///app/vendor.js:102845:26
12  UIApplicationMain@[native code]
13  start@file:///app/vendor.js:93502:26
14  run@file:///app/vendor.js:93530:10
15  bootstrapNativeScriptApp@file:///app/vendor.js:63627:26
16  bootstrapApp@file:///app/vendor.js:63545:38
17  bootstrapModuleFactory@file:///app/vendor.js:63516:26
18  ./main.ts@file:///app/bundle.js:15965:115
19  __webpack_require__@file:///app/bundle.js:76:34
20  checkDeferredModules@file:///app/bundle.js:45:42
21  @file:///app/bundle.js:166:38
22  anonymous@file:///app/bundle.js:167:12
23  evaluate@[native <\M-b\M^@\M-&>
JavaScript error:
file:///app/vendor.js:104325:43: JS ERROR TypeError: undefined is not an object (evaluating 'nativeView.layer')

To Reproduce
Create 2 sibling views like this:
<GridLayout @routerInAnimation>
   <Label text="Hello World"></Label>
</GridLayout>

The ts files have the animations line in their @Component() declaration:
@Component({
  moduleId: module.id,
  templateUrl: './hello.component.html',
  changeDetection: ChangeDetectionStrategy.OnPush,
  animations: [routerInAnimation],
})

The routerInAnimation looks like this:
export const routerInAnimation =
  trigger('routerInAnimation', [
    // route 'enter' transition
    transition(':enter', [

      // styles at start of transition
      style({ opacity: 0 }),

      // animation and styles at end of transition
      animate('1s ease-in', style({ opacity: 1 })),
    ]),
  ]);

Then route between the 2 views, to trigger the animation.
Note: If you comment out the animate line, it stops crashing, so it seems related.
Sample project
If you can't reproduce it, we'll supply one.
Additional context

Hi @larssn,
I have tested the described scenario with the animations, however, was unable to recreate the issue. For your convenience, I am attaching a sample project. Please review it and make the needed changes, which will allow us to recreate the problem.
Archive.zip

We'll look at it immediately

So we tried to reproduce it in the sample, but weren't able to.
We then tried slowly removing code from our app, until the problem disappeared.
The result was inconclusive, and our working theory is that the problem is CPU related (meaning a race condition). We came to this conclusion based on removing certain pieces of code that were entirely isolated from the animation logic, that somehow caused the animation to work as intended. The more processing we added to that particular component, the more likely the problem was to occur. So my guess is that there is some async logic somewhere, that isn't allowed to complete, but sometimes does complete, hence the race condition.
So we've had little choice but to scrap Angular animations for now.
Ps. As I mentioned, when our component was stripped bare bones (no data being read etc, basically only the animation), the following tiny code block would cause the problem to reappear:
ngOnInit() {
  for (let i = 0; i < 10; i++) {
    setTimeout(() => { this.changeDetectorRef.markForCheck(); }, i);
  }
}

Not much to go by :(
I'm available if you have any questions.

Hi @larssn,
Thank you for your further research on the issue, however, without any stable steps to recreate the problem it is hard to investigate further the case. Can you please send us the project as a private message via our community slack? My nickname is nikts. With its help, we will be able to check what exactly is causing this animation issue.

Sure, when I have time, I'll send a stripped down version of the app that only contains the problem.
Thank you


Add helper to transform file name from source <> build

Original Discussion: https://github.com/snowpackjs/snowpack/discussions/2260#discussioncomment-280307
/cc @Rich-Harris
Our file build system has gotten more powerful, but also more complex. As a result, it would help consumers of Snowpack to have a transform function that can transform file names from source name to final built name (and vice-versa).
We already have helper functions for getting the full hosted URL of a source file, so this would just be a simpler version of that. Those functions probably already have this logic in them already, so it would just be an exercise in pulling it out and refactoring a bit.

Hey I'm happy to take a look at this :+1:


Accept and passthrough donator token

When the consent process is initiated from within the batea extension options page, it will be using a link with a GET variable like so:
https://batea.docgraph.org/consent/?token=abc123
The consent form needs to pass that token along to the saveSettings API call at the very end along with the results of the survey form.

I am currently using a config.js file for testing with
CONFIG = {
postUrl: "https://bateaapi.docgraph.org/API/Donator/nnnnn144656064895000005187/saveSettings"
};
But this file should just be:
CONFIG = {
postUrl: "https://bateaapi.docgraph.org/"
}
And the rest of the url should be calculated by code... based on the token that was supplied with the initial GET...

Hi Fred:
I'm not sure I fully understand this requirement. the token in your example is "API/Donator/nnnnn144656064895000005187/saveSettings" ?

This was addressed by appending all GET params to the JSON document that is submitted, therefore a custom URL does not need to be created for each form submission.


deprecate suite-params option over params

We have reverted this change - https://github.com/elastic/synthetics/pull/379 for the time being to make 7.15 work, But we added patch to the 7.x branch to add params support in HB and now that we are at the 7.16 release timeline, we can safely remove this from Synthetics side.

:broken_heart: Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-11-03T04:32:15.558+0000

Duration: 8 min 5 sec

Commit: 56567cc596caf8f2f6658884c7cd6cafc369f566

Test stats :test_tube:

Test
Results

Failed
1

Passed
137

Skipped
0

Total
138

Test errors
Expand to view the tests failures
Test / CLI screenshots with device emulation – CLI screenshots with device emulation

no error details
Expand to view the stacktrace
 Error: Failed: "Error SyntaxError: Unexpected end of JSON input could not parse data '{\"type\":\"screenshot/block\",\"_id\":\"71bb77ed1acf85f13f1e8a2ab3cf3401850f7b9d\",\"@timestamp\":1635914390993924.5,\"root_fields\":{\"os\":{\"platform\":\"linux\"},\"package\":{\"name\":\"@elastic/synthetics\",\"version\":\"1.0.0-beta.16\"}},\"blob\":\"/9j/2wBDAAYEBQYFBAYGBQYHBwYIChAKCgkJChQODwwQFxQYGBcUFhYaHSUfGhsjHBYWICwgIyYnKSopGR8tMC0oMCUoKSj/2wBDAQcHBwoIChMKChMoGhYaKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCj/wAARCAFyALQDASIAAhEBAxEB/8QAFQABAQAAAAAAAAAAAAAAAAAAAAj/xAAUEAEAAAAAAAAAAAAAAAAAAAAA/8QAFAEBAAAAAAAAAAAAAAAAAAAAAP/EABQRAQAAAAAAAAAAAAAAAAAAAAD/2gAMAwEAAhEDEQA/AKpAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'"
    at Env.it (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:95:24)
    at it (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:100:21)
    at Suite.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/__tests__/cli.test.ts:146:3)
    at addSpecsToSuite (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmine/Env.js:444:51)
    at Env.describe (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmine/Env.js:414:11)
    at describe (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/node_modules/jest-jasmine2/build/jasmine/jasmineLight.js:88:18)
    at Object.<anonymous> (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/__tests__/cli.test.ts:31:1)
    at Runtime._execModule (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/var/lib/jenkins/workspace/nt-rum_elastic-synthetics_PR-406/src/github.com/elastic/synthetics/node_modules/jest-runtime/build/index.js:746:10)

Steps errors
Expand to view the steps failures

Runs the tests

Took 1 min 58 sec . View more details here
Description: ./node_modules/.bin/jest --ci --reporters=default --reporters=jest-junit

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


Lose parameters when writing xgboost model in R and loading in Spark bridge

Description
I trained a xgboost model with R (0.80.1) and I want to load it and infer in Spark 2.3 with xgboost4j-spark 0.80.6. When loading the file like this:
package ml

import ml.dmlc.xgboost4j.scala.XGBoost
import ml.dmlc.xgboost4j.scala.spark.XGBoostClassificationModel

import scala.collection.mutable

/**
  * XGBoostClassificationModel factory to load a pre-trained XGBoostClassificationModel model
  */
object ExternalXgboostModelLoader {
  val numClasses = 2
  val modelCache = mutable.Map.empty[String, XGBoostClassificationModel]

  ///////////////////////////////// PROBLEM HERE ? /////////////////////////////////
  private def buildModel(path:String):XGBoostClassificationModel = {
    val booster = XGBoost.loadModel(path)
    new XGBoostClassificationModel(path, numClasses, booster)
  }
  ///////////////////////////////// PROBLEM HERE ? /////////////////////////////////

  /**
    * Load a pre-trained xgboost model from S3 or HDFS. The path has been
    * obtained by
    *
    * ```
    * sc.addFile(s3Path)
    * val localPath = SparkFiles.get("{model_file_name}")
    * ```
    *
    * @param localPath local path to the pre-trained model
    * @return load pre-trained model
    */
  def apply(localPath: String): XGBoostClassificationModel = {
    modelCache.getOrElseUpdate(localPath, buildModel(localPath))
  }
}

... all the parameters from my original model trained in R are reset to default:
val modelPath = "s3://xxx"
sc.addFile(modelPath) // Add model file (S3, HDFS, local)
val fileName = Paths.get(modelPath).getFileName.toString
val localPath = SparkFiles.get(fileName)
val model = ExternalXgboostModelLoader(localPath)

model.getEta  // 0.3 instead of 0.03
model.getAlpha // 0.0 instead of 0.01
model.getColsampleBytree // 1.0 instead of 0.7
model.getNumRound // 1 instead of ~950

Any idea?
Config

I am using xgboost 0.80.1 in R, and xgboost4j-spark 0.80.6
Spark 2.3.1

explanations are

those parameters from R are from XGBoost domain

the parameters returned by getEta/getAlpha, etc. is from Spark domain

you can save a Spark pipeline for XGBoost with parameters and load it back with the previously set values (since all you do is within Spark domain)

you cannot save a XGBoost model and load it back from Spark with the expectation to get parameters from XGBoost domain, though you can still do the prediction

the only way to connect these two domains (at least for now) is to construct the trainers by passing parameters.....

@borisclemencon This is limitation of current model serialization format: all training parameters are lost, and only the final tree outputs are preserved.

@CodingCat The JSON serialization proposal includes a way to preserve the state of every object (credit to @trivialfis). Would it help in this case?


Refactor one-time completion observables to Promises

There are a few places where we use an Observable for something that only ever "completes" (dialog and snackbar off the top of my head). We should use promises instead so that those APIs work with await TS 2.1.

Another way to go about it would be to embrace the Observables and only ever use them. For instance, the http service only uses observables and I find it quite useful.

Actually going to close this because at this point it's too much of a breaking change.


regression-new/kprove-smt-lemma: compatibility with Java backend

Is this test run on the java backend as well?  If not, could you please make it run on both backends?  Thanks!

Thanks, but could you please reorg the directory to follow the existing standard, like https://github.com/kframework/k/tree/62f28a66d89f936e630704b1f7f7b8aa6c6d70fd/k-distribution/tests/regression-new/rat/defined ?

@daejunpark done


Making a field optional in a derived dataclass

Discussed in https://github.com/samuelcolvin/pydantic/discussions/3813

Originally posted by dimaqq February 14, 2022
Here's what I have so far (trimmed down to MRE):
from pydantic.dataclasses import dataclass

@dataclass
class Thing:
    id: int
    dog: bool

@dataclass
class NewThing(Thing):
    id: str | None = None

Which fails at import time with:
> python3.10 x.py
Traceback (most recent call last):
  File "/.../x.py", line 11, in <module>
    class NewThing(Thing):
  File "pydantic/dataclasses.py", line 255, in pydantic.dataclasses.dataclass
    'default',
  File "pydantic/dataclasses.py", line 250, in pydantic.dataclasses.dataclass.wrap
    # When cls._FIELDS is filled in with a list of Field objects, the name
  File "pydantic/dataclasses.py", line 159, in pydantic.dataclasses._process_class
    #    |
  File "/usr/lib/python3.10/dataclasses.py", line 1185, in dataclass
    return wrap(cls)
  File "/usr/lib/python3.10/dataclasses.py", line 1176, in wrap
    return _process_class(cls, init, repr, eq, order, unsafe_hash,
  File "/usr/lib/python3.10/dataclasses.py", line 1025, in _process_class
    _init_fn(all_init_fields,
  File "/usr/lib/python3.10/dataclasses.py", line 546, in _init_fn
    raise TypeError(f'non-default argument {f.name!r} '
TypeError: non-default argument 'dog' follows default argument
```</div>

This is already working on V2. 🙏
We have no plans to fix it on V1.


Feat: Navigation and home page design ,footer

Describe the feature
Navigation is not display:
i able to create navigation and whole home page with footer as well as functionality
i can create as it is like flipkart cwebsite ,i m expert on this
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@arghadipmanna101
I've undertaken numerous projects involving HTML, CSS, Tailwind CSS, JavaScript, and React.js, showcasing my proficiency in frontend development. Additionally, I'm presently engaged in a MERN stack project, demonstrating my capability across the entire web development spectrum.
Given my expertise, I'm confident in resolving the navigation display issue. You can review my experience and projects on my LinkedIn profile https://www.linkedin.com/in/prajna-paul-117086256/ and my GitHub account https://github.com/prajna321/.
Please assign me the task, and I'll ensure it's promptly addressed.
Thank you!

I would like to work on this project . please assign it to me.

hey i'm proficient with tailwind, i can resolve the issue in minutes, it would be great to work on this site, pls assign it to me...

Describe the feature
Navigation is not display:
i able to create navigation and whole home page with footer as well as functionality
i can create as it is like flipkart cwebsite ,i m expert on this
Add ScreenShots

Record

[x]  I agree to follow this project's Code of Conduct
[x]  I'm a GSSOC'24 contributor
[x]  I want to work on this issue

Go ahead @Varsani2520

merged it and close the issue

@arghadipmanna101  I added the Navigation and Home Page Design ,Footer
Check the PR and merged It.

Hey @arghadipmanna101 ,
as a  mentor it's your responsibility to give response
check this pr and merge it
#159


Adding support for Loki with multi tenancy

Adding support to the default Loki+Grafana multi tenancy mode as this is the default.
What this basically means is adding support for passing a custom header to the LokiRequest class.
# This doesn't work
curl -v -H "Content-Type: application/json" -H "X-Scope-OrgID: tenant1" -XPOST -s "http://localhost:3100/loki/api/v1/push" --data-raw \
  '{"streams": [{ "stream": { "foo": "bar2" }, "values": [ [ "1707418238000000000", "fizzbuzz" ] ] }]}'

# This works, note the `-H "X-Scope-OrgID: tenant1"`
curl -v -H "Content-Type: application/json" -H "X-Scope-OrgID: tenant1" -XPOST -s "http://localhost:3100/loki/api/v1/push" --data-raw \
  '{"streams": [{ "stream": { "foo": "bar2" }, "values": [ [ "1707418238000000000", "fizzbuzz" ] ] }]}'

Great,
Can you add this option in the readme please?


Add flag to enable/disable rotations in registration to template

As rotations around the S-I axis are not regularized, large local rotation can occur.
Solution: develop a more accurate method to calculate the Z-rotation of the spine, that is regularized in the S-I direction.
Meanwhile, a flog to enable/disable the rotation in sct_register_to_template is a good quick solution for users.
Proposition for the name of the flag: -rotation 0/1 (default 1). Any other idea?

In which cases we would not want to regularize in the SI axis (rotation =1)?

@benjamindeleener I though from Falk's email that the issue was rotation during straightening. If the issue is in fact during register_to_template, then there is already the possibility to not have rotations.
Default param is: step=1,algo=centermassrot, and the user can use instead: step=1,algo=centermass.

Sorry I wasn't precise enough and you are right. The rotation that is currently calculated during the registration to the template is regularized by default with a polynomial function of degree 5 and can produce local errors.
I actually run sct_register_to_template on sct_testing and it produces large rotation errors.
A movie with the error here (MUST SEE!): https://www.dropbox.com/s/buejsn2kt1g8jhh/sct_testing_rotation_errors.mov?dl=0
I would like to change the default method from step=1,algo=centermassrot to step=1,algo=centermass until we find a better regularization and/or rotation detection method. What do you think?
@jcohenadad There is no rotation involved in the straightening. All rotations are in sct_registration_to_template.

geeze... scary video. A bit too late for halloween now...
ok for setting default value to algo=centermass


Create wallet upon first start

Upon first start of the app a wallet needs to be generated utilizing the Bip39 standard. This may be implemented using a combination of the bitcoindevkit and the lightningdevkit
Acceptance Criterias

lightning wallet (on & off chain) is initialized and ready to use (exposed through the flutter_rust_bridge)
a simple view showing the current balance - demonstrating that the wallet can be accessed from the view.

This issue is not intended to make the wallet already 100% usable, but get to a point where we feel comfortable of making it usable. Follow up issues may be required!

@holzeis I've noticed we're both assigned to it - how would you like to split the work? would you like to pair on this?

I thought I'd share some insights:
rust-lightning is very modular, meaning, we will need to implement various things. Among others, rust-lightning does not take care of an on-chain wallet for you but asks you to perform certain tasks and hand over the signed transactions to the ldk.
This means, we can implement an on-chain wallet using BDK as we are used to.
Sample code: here they use bitcoind's wallet:
https://github.com/lightningdevkit/ldk-sample/blob/8984205acf1d328837d0f33798e89e479aea1882/src/main.rs#L147-L165

thanks for the input. I will have a look..

@holzeis do you think we can close it? on-chain wallet is initialised, balance is displayed, and the off-chain wallet is covered by #82

@holzeis do you think we can close it? on-chain wallet is initialised, balance is displayed, and the off-chain wallet is covered by #82

yes.


fix: line-chart & progress-chart wrong width calculation

For some reason, the paddingRight value was set to perfectly match width / data.datasets[0].data.length with the amount of dots showed in the example app, resulting in a net of 0.
Without changing the chart width, if you change the amount of elements, currently, the line chart looks like this:

Note that the chat's width is greater than the screen width, so it is impossible to see the rounded borders on the right side of the chart.
However, using my fix, it looks like this:

Note that the rounded borders are visible, the whole chart is being shown.
Furthermore, the current version does not take into account the margin or marginRight coming from the style prop to calculate the chart's width.

Cool, this is now available in v4.0.0 👍
Thank you for taking the time to explain this :D


Expose necessary methods

No reason to make it hard on developers if they want to override core thorax behavior.  We currently have a lot of behavior that is private and we need to at least assume that someone might want to reference those private methods even if we don't think they will override their behavior.

Have you tested this?

The methods were not made part of the API for good reason, Joe can you post some examples of where and how Thorax is being inflexible?

Added populate and serialize events to master with docs.


SipMask_VIS:when I using the pertrained model to test the youtube dataset, the result of model is None?

Maybe the scores were too low and filtered, but I tried the YouTubeVIS valid datasets and the model detected nothing

@sally1913105 Can you provide more details.


Fix Alpha.71 crashes

Fixed use of GetInstance() and memory_pointer class use inside cdecl naked function causing exception
Removed GetInstance() in favor of just using CleoInstance.

Fix the crash .
Stop making millions of changes


suggestion - pickup money on shift

you can add option in confg to must "shift" click to pickup the money?

Added

Added


fix: stx transfer test

Try out this version of Leather — download extension builds.

This should intercept the request so we can test it, but it doesn't actually broadcast the transaction.

Merging because I want these changes


Allow override default messages

Adding multiple validated fields across multi-lang application requires many repetitions of
@NotEmpty(messageResId = R.string.error_empty)
private EditText firstnameView;
@NotEmpty(messageResId = R.string.error_empty)
private EditText lastnameView;
@NotEmpty(messageResId = R.string.error_empty)
private EditText addressView;
// and so on...

Without specifying messageResId Saripaar uses default message defined in annotation, in this case
public String message()     default "This field is required";

Maybe default messages could be moved into strings.xml and specified in annotation as, in this case:
public int messageResId()   default R.string.saripaar_msg_required;
public String message()     default "";

message would be used only if it wouldn't be empty, in other case resource specified by messageResId would be used.
And then, according to http://developer.android.com/tools/projects/index.html#considerations

Since the tools merge the resources of a library module with those of a dependent application module, a given resource ID might be defined in both modules. In this case, the tools select the resource from the application, or the library with highest priority, and discard the other resource. As you develop your applications, be aware that common resource IDs are likely to be defined in more than one project and will be merged, with the resource from the application or highest-priority library taking precedence.

So in app using Saripaar it could be possible to override default messages in own strings.xml file.
If this enhancement would be accepted I can try to develop it.

@m-radzikowski This is a really interesting idea. If we adopt this, we have to switch from offering JARs to AARs. That is one thing, it would certainly break compatibility with users who are still using Eclipse. I have planned a couple of features for 2.1.0. Once I'm done with that, we can proceed with this idea.
So, post 2.1.0, we'll offer AARs and break compatibility with Eclipse. Users would have to switch to Android Studio & Gradle to use Saripaar 2.1.0+

The 2.1.0 would have at least the following,

DSL for creating dynamic messages
@Or and @Optional Annotations

I think, it would be nice to have these features available for users who are still using Eclipse. After implementing these, we'll add this ability to override default messages. In fact, a DSL is required to implement this feature because the generated resource IDs are not final in a library project. And annotations can ONLY accept final variables for it's attributes.


avoid same rendering (data binding) when opening the app on many navigators !

Suppose I want to host that app on a node js server, when many users access that app, will they have the same rendering ? because when I try to open that quick-start project on different navigators I'm having that issue, when typing on input : some text, the other input on the other navigator get the same text in it, thought because we are sending the data binding to node js, should we do it otherwise ?
Please Help !

The quickstart is served via https://github.com/johnpapa/lite-server, which in turn uses https://github.com/BrowserSync/browser-sync.
When hosting the application on your server, you would not use lite-server because it is a dev-only server. You would use a production server instead and thus not have this issue.

Thank's, is there a way to run node js in prod mode with that lite server (a parameter in command line or file configuration) ??

I'm afraid not. It's a dev only server by nature, there is no production setting.

Okey then, so I should not worry about this, I should keep developing my app and and hots in a prod server after

Absolutely correct :D

Thanks a lot and forgive my silly question :p

Hello I uploaded sample code of node application of angular 2 quickstart. Instance is not running in Aws server as well as Ibm bluemix. can any one tell whats the issue.
And I want configure angular 2 in html with php or java ..

@AttilaZz not silly at all, it's a very reasonable concern and I'm glad you asked, because other people might have it as well and find an answer here.
@maddela I can't begin to guess what the issue is, there are many things that could have gone wrong in your deployment. This repository is about the quickstart though and doesn't really propose any specific deployment procedure, so I don't think this repo is the right place to ask.
Perhaps try asking someone very knowledgeable in AWS/IBM Bluemix? They might be able to help you in the transition from a local setup to a deployed setup.


Use conventional meta-item syntax for attributes

Disclaimers

I apologize for the diff size. The meaningful changes are in crates/macro-support - the other files are changed to avoid any commits that won't build.
This introduces a potentially-divisive change, using quotation marks for most key-value meta items. This has some advantages (such as working with rustfmt), but I know there are those in the community who really dislike the extra quotation marks. If wasm-bindgen has already decided not to use them, I'll close out this PR.
This is a major breaking change; almost all key-value meta items need updates. If people are receptive to this direction but concerned about a huge breaking change, I am happy to explore ways to temporarily support both formats.
I'm the author of darling, the attribute-parsing library this uses. There's probably a way to do this without darling, but it's surprisingly difficult to maintain the level of error quality without it.

Commit message
Using the conventional form for attributes, which is compatible with rustfmt and syn's meta-item parsing. This change is breaking and substantial, but the necessary edits are largely mechanical.
With meta-items, it becomes possible to offload attribute parsing and validation to darling. This offload fixes #2874, as darling will automatically generate errors for unexpected meta-item names. This also makes it easier for people who are new to the codebase to understand how to add new options.

Thanks for the PR here, but unfortunately this project isn't really in a place to manage or merge large breaking changes. I don't think that there's going to be a viable way to land this, even if the repo is fully updated, any time soon.

Makes sense: Getting that feedback was part of why I posted after 5 hours of work so I wouldn't be too deeply invested. A couple follow-up questions:

Is the change to having dedicated options structs per input-item-type interesting, if it can be done without changing the outward attribute API?
Is a non-breaking version of the API change - adding support for the quoted format alongside the current format interesting, or would you prefer to stick to the generally-unquoted syntax long-term?

Sorry this is a big change I don't have the time to review, but overall making the proc-macro more readable or easier to understand/modify seems reasonable to me. Whether that could be achieved with the struct-per-input-item-type I'm not sure.
Personally I would prefer just one syntax. I'm not wed to with or without quotes, but I'd rather not have both.

Sorry this is a big change I don't have the time to review

If I take out the diff parts caused by the breaking change, the new size is +554/-578; is that more tractable?

Whether that could be achieved with the struct-per-input-item-type I'm not sure.

I have two ideas for this. Both of them start by adding macro_support::Meta, which is equivalent to syn::Meta except that it doesn't insist on the things to the right of = being valid literals.
Option 1

Do low-level parsing using syn::Parse to turn the attr TokenStream into a macro_support::Meta.
(Somehow) convert each macro_support::Meta into a syn::Meta by wrapping values right of = in LitStr, preserving spans while doing so.
Pass these newly-created syn::Meta items to the derived FromMeta impls.

Option 2
Create a proc-macro crate macro-support-gen, which exposes a derive-macro that's analogous to darling::FromMeta but operates on the macro_support::Meta type above. Then recreate some amount of darling's meta-parsing loop in the macro-support-gen crate.

Option 1 is much easier and more maintainable, at the expense of traversing the attribute twice and sometimes doing more allocations.

Option 1 actually works! I'm going to update the review shortly.

I'm closing this in favor of #2880.


End-to-end test of the RemoteRealm authentication flow

Adds a file and two basic tests for the end-to-end flow from user perspective.

Merged, thanks @mateuszmandera! @amanagr FYI.


Add icmpvsresponse parameter when creating new virtual servers

The icmpvsresponse parameter allows you to set whether the the ICMP response is ACTIVE or PASSIVE.  Setting it to ACTIVE means that if the virtual server is down, the Netscaler will not respond to a ping request.  By default this is set to PASSIVE.
I have a patch for this for which I'll raise a pull request shortly.
Current Behavior
No parameters are available to set this so the Netscaler defaults to all created Virtual Servers having a PASSIVE setting.
Possible Solution
Add parameter to allow the setting to be customised by the user.  By default set it to PASSIVE to match what the Netscaler does.
Context
In my configuration each virtual server has a unique IP address and when they are down I need the Netscaler to not respond to a ping request.

This looks good to me. Thanks for the add!


enable travis hook

please enable travis hook http://about.travis-ci.org/docs/user/getting-started/ so tests will be run on every push and merged pull request: http://travis-ci.org/#!/kennethreitz/autoenv
here is example output from my profile: http://travis-ci.org/#!/mpapis/autoenv
and you can add the build status image to README http://about.travis-ci.org/docs/user/status-images/

any progress ? thais should take only minute or two.


Failed to Solve on Boxing-like dataset

Hello, I was trying to repeat Boxing using a live camera. It failed to seperate fist from face.
cliped_filter_depth:

reference_phong:

live_phone:

You might try to modify the re-init parameter.

@xiaotaw how did you do this, with live camera? just modify the fetch image interface?


Missing publication for Bag Distance similarity measure

The documentation provides information about how to use the bag distance measure, but the explanation refers to a dead link. Could you please update the documentation with the title and author of the original paper? Thank you in advance!

Thank you for bringing this to our attention. We are working on fixing this issue, but for now, here is a working link to correct paper.

We have fixed the documentation to include a working link to the correct paper.


LNK4042: object specified more than once; extras ignored

This warning is not documented.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f351badb-0958-c6a9-9830-134f9247017f
Version Independent ID: 3e4eb760-6c7d-279a-9833-36e6f1ad1221
Content: Linker tools errors and warnings
Content Source: docs/error-messages/tool-errors/linker-tools-errors-and-warnings.md
Product: visual-cpp
Technology: cpp-diagnostics
GitHub Login: @corob-msft
Microsoft Alias: corob

@LegalizeAdulthood
Thanks for the report. Quite a few diagnostics are not documented; we get to them gradually as we have time and as customers express interest (read: complain). LNK4042 essentially means your linker command line has two or more .obj files that have the same name. The warning tells you that only the first one gets linked. There are several ways you can wind up with duplicate object file names, but generally, the solution is to manage your source code and build paths so there's only one object file with a given name in the link. For example, make sure you're not compiling both a header file and a source file with the same base name as if both were source files. Or, make sure you don't have both the retail and debug intermediate directories as part of your build path at the same time. This issue is one that requires some investigation, since the cause is unique to each build.
I've added this request on the backlog. I'll update the issue when it's completed.

We are in the process of moving away from GitHub issues for C++ documentation (we still accept pull requests). For details, please see Announcing a new way to give feedback on Microsoft Learn This issue will be closed after it is copied to an internal tracking system.


Feat request: add ability to pass custom headers

Add the ability to pass custom headers to the client.
This is useful for LLM telemetry tools like OpenPipe or ObserveAPI.
OpenAI & Anthropic clients already support this.

I agree we really need this :)

Thanks for the suggestions. This is implemented. Please see more details here: https://github.com/mistralai/client-python/blob/main/README.md#custom-http-client


Changelog on website does not match one in source.

Is the change log on the website generated automatically?
http://rspec-puppet.com/changelog/
It only shows version 1.0.1.
Could it be change to just point to the git hub one?

This is all done in https://github.com/rodjek/rspec-puppet/tree/gh-pages . It'd be awesome if anyone could have a go at this and update all the 2.x stuff into those pages.


[Ionic 4.0.0, beta 11]  nested ion-content does not render!

Bug Report
Ionic Info
Ionic Framework : @ionic/angular 4.0.0-beta.11
@angular-devkit/core : 0.7.2
@angular-devkit/schematics : 0.7.2
@angular/cli : 6.0.8
@ionic/ng-toolkit : 1.0.0
@ionic/schematics-angular : 1.0.1
Describe the Bug
If you have a ion-content within an ion-content, the nested ion-content does not render.  For example, ion-content can contain a custom component that has its own ion-content.  The custom component will not render correctly.
Steps to Reproduce
Steps to reproduce the behavior:

Create a tabs project from the iconic v4 templates
On the Home tab replace

<ion-content padding>     The world is your oyster.
If you get lost, the docs will be       your guide.
 </ion-content>
WITH
<ion-content padding>   <ion-content>     The world is your oyster.
If you get lost, the docs will be       your guide.
   </ion-content> </ion-content>
Expected Behavior
All nested content rendered correctly.
Additional Context
This worked with earlier builds of the beta.

Possibly related to https://github.com/ionic-team/ionic/issues/15677
cc @manucorporat


Uniform generator for time series and histograms

Generator code for TimeSeries and TimeHist objects, starting with just a uniform event rate over a given span.
One can create a TimeSeries or TimeHist using the NewTimeSeries or NewTimeHist generator.  Uniform then adds to the object.  One can then string together further generators to add to the objects.
We'll need to add some more utilities, like setting new start times and adding objects together, to make this fully functional.  This would be an alternative to creating a bunch of objects in the data['gen'], with a Combine at the end, which was getting a bit clumsy.

Need to pull this on top of master for it to work, because renderers/init.py refers to PickleOutput now

I see that for the pickle implementation (still looking at it), you have come back to old ".py" config files instead of csv:
snewpdag/data/test-pickle-in.py
Shouldn't it be also a csv?

Sometimes I find the old .py form easier for simple graphs.  But happy to make csv versions in a new PR!

Some comments:

NewTimeHist: I would replace time_span by an end_time
NewTimeSeries: why it one returns the start_time instead of all event times? I think I don't get the idea of this script
TimeHist: I would not use default bins to zero to a non-zero value, as indeed it throws and error, and I think by default it should run for an arbitrary number of bins
TimeSeries and TimeHist : I don't like the idea of having times as an array of (s,ns) times, it is just a factor 1000 and will be a lot more of data (and tuple structure) to handle
Question:
I don't reallysee how this connect to snewpdag/plugins/gen/TimeSeries.py after all

I agree with that, I was just not seeing that "an amount of time after that" in the script that is defined/recorded
You're right in theory for the experiment continuous data taking, there is no start and end for the event times (time series). However, for the practical case of a CCSN trigger, the experiment will define a start an an end that they will send to SNEWS as "the window the the supernova happens", and not hours or days of data. So I think we will get a start an end from experiments data first and last event they send.
Yep, just a default value different from zero.
(s,ns): I see, in any case yes, I think the amount of information lost is minimal (as in reality we won't achieve ns recision on the deltat or the T0). Also, experiments like IceCube and KM3NeT won't have a ns timing of events.
Yes, indeed, I see that the values.TimeSeries is defining a TimeSeries class, not really doing the "generator" part by randomising as in gen.TimeSeries

Good point about the duration - I'll add it to values.TimeSeries.  And possibly call it "duration" rather than "time_span".
Also will try to add the non-zero default nbins value - though I now recall why I didn't, which is that I had allowed the nbins parameter to override (i.e., shorten) the length of the data array in determining how many bins the histogram was to have.  Having a non-zero default value makes it impossible to specify "I want my histogram to have 100 bins, so truncate my array which happens to have 110 bins".  On the other hand, there are other ways to specify that outside of the arguments, but in any case it'll change the semantics of the nbins vs data.
Finally, I remembered that we automatically lose precision in the timestamp, so we may need to keep (s,ns) for anything which could be a full timestamp.  The reason is that the usual Unix-epoch timestamp uses nearly its full 32 bits - if I remember correctly, it turns over in the 2030's, possibly a bigger "Y2K" problem than the one in 1/1/2000.  A 64-bit float has 53 significant binary digits, so we're down to about 21 bits left for the fraction.  This only gets us down to microsecond granularity.
The detectors probably won't get down to ns timing granularity, but they do go below microseconds.  The main SNO+ trigger window, for instance, is 400ns, so if we cut the timestamp off at the microsecond level, it's possible to have two events with the same timestamp.  That could be a problem if we have to do some elementary data reduction within snewpdag.
Anyway, I'll see if I can reduce the number of ways one must use (s,ns), or indeed nanoseconds.  For instance, by adding methods which take floats instead of long ints.
That will be another PR, because I tangled up the git history a little and need to merge to straighten it out...


Generalise NeighborhoodSearch

Generalises NeighborhoodSearch to work with a non-Minkowski metric by using a BallTree.
Fixes JuliaEarth/GeoStats.jl#140.

Codecov Report

Merging #69 (b37dda7) into master (149117a) will decrease coverage by 22.14%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #69       +/-   ##
===========================================
- Coverage   91.58%   69.43%   -22.15%
===========================================
  Files         105      105
  Lines        1865     1865
===========================================
- Hits         1708     1295      -413
- Misses        157      570      +413

Impacted Files
Coverage Δ

src/GeoStatsBase.jl
100.00% <ø> (ø)

src/neighborsearch/neighborhood.jl
29.62% <100.00%> (ø)

src/plotrecipes/distplot2D.jl
0.00% <0.00%> (-97.73%)
:arrow_down:

src/plotrecipes/domains/structured_grid.jl
0.00% <0.00%> (-97.15%)
:arrow_down:

src/plotrecipes/distplot1D.jl
0.00% <0.00%> (-96.00%)
:arrow_down:

src/plotrecipes/hscatter.jl
0.00% <0.00%> (-95.24%)
:arrow_down:

src/plotrecipes/solutions/simulation.jl
0.00% <0.00%> (-95.24%)
:arrow_down:

src/plotrecipes/cornerplot.jl
0.00% <0.00%> (-94.45%)
:arrow_down:

src/plotrecipes/problems/learning.jl
0.00% <0.00%> (-94.12%)
:arrow_down:

src/plotrecipes/domains/point_set.jl
0.00% <0.00%> (-93.94%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149117a...b37dda7. Read the comment docs.

Done!

Thanks for the contribution! 😊


test kxcdev/ocaml-general-gha#3

adopt new v2-future features
test kxcdev/ocaml-general-gha#3 - prepare bumping to v3

test concluded, thus closing


distributed setup guide page not found

Hi distributed setup guide page https://asl-r.github.io/distributed_service/config.html in readme is not found. Cound anyone fix it?

It has been fixed. Thanks for your reminder.


Create nv

@Bequester Please rename lib/domains/net/ccsd/nv to lib/domains/net/ccsd/nv.txt
Thank you.

@Bequester You might miss my previous comment. Please react.

@Bequester Pull request merged. Thank you! However you did not name the file in the request correctly, thus I'll do it for you in about two hours. Please wait at least two hours after this message is sent, before start requesting the licenses at https://jetbrains.com/student.


update API docs to specify how to set content encoding

closes #32
let me know if you need me to change/add anything :)

Hey @intldds, thanks for the PR! This has an error if you check the linter; see the CI errors. You can fix that problem by putting contentEncoding in a new encoding section, like:
      application/octet-stream:
        schema:
          description: "SSZ serialized request. Use content type header to indicate that SSZ data is contained in the request body."
        encoding:
          contentEncoding: gzip

But then there's another error which I don't really understand. Not sure how to fix:
 51:28  error  oas3-schema  "contentEncoding" property type must be object.  post.requestBody.content.application/octet-stream.encoding.contentEncoding

Thanks for the reply @jtraglia! I've tried following the examples provided here (https://spec.openapis.org/oas/latest.html#considerations-for-file-uploads) and I've tried different combinations to place contentEncoding.
In all of them, when I ran spectral lint relay-oapi.yaml I always received "Property "contentEncoding" is not expected to be here" -- feel free to reject the PR in this case.

I can't figure it out either 😭 let's just remove the encoding sections and keep the bullet point.


I think the implementation would be:
{{{
def go_back(self):
"""
Simulates the user clicking the "back" button on their browser.
"""
return self._selenium.go_back()
}}}
I will be happy to own this but I'd like someone with more knowledge of the
library to code-review it.

Originally submitted to Google Code by @pekkaklarck on 4 Feb 2010

This can definitely be added but, as I also commented  issue 86 , the new keyword
requires also tests.

Originally submitted to Google Code by @yanne on 10 Feb 2010

Added tests in r338 and implementation in r339


chore(blockifier): split builtin gas costs from base gas costs

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2514  👈 (View in Graphite)
#2359 : 1 other dependent PR (#2501 )
#2327
#2247
#2188
#2067
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

crates/blockifier/src/versioned_constants.rs line 662 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Let's remove the builtin from every builtin that has it because it is inconsistent and unnecessary now that they are under the builtin section.

Agree.
Specifically for keccak though, it might be confusing, because we also have the price of the syscall (it's name is just "keccak")

crates/blockifier/src/versioned_constants.rs line 753 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Are not all the keys in the base now? We should aim to remove this constant, but this is outside of this PR scope.

no, all the keys that are in BaseGasCosts are not here.
Actually the number of fields that are now in this list is much larger then the number of those that are not in the list. Might be cleaner to replace this list with a list of the ones that we don't want to skip

crates/blockifier/src/versioned_constants.rs line 765 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Here, the way to make sure you have the builtins before you need to calculate the syscall is to call the builtin parse before you call the syscall parse, right?

yes

crates/blockifier/src/versioned_constants.rs line 961 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
I think it is easier to read this way

Done.

crates/blockifier/src/versioned_constants.rs line 719 at r4 (raw file):

    // List of additinal os constants, beside the gas cost and validate rounding constants, that are
    // not used by the blockifier but included for transparency. These constanst will be ignored
    // during the creation of the struct containing the gas costs.

Done.


[SPARK-10259] [ML] Add @since annotation to ml.classification

Add @since annotation to ml.classification

Can one of the admins verify this patch?

@taishi-oss these were already in spark prior to 1.6, please see the parent JIRA for how to track down the correct version number to use in the @since annotations.

Sorry for being late.
I modified @since annotations.

I only pointed out the issues in the first few files, do you mind fixing them in all the files?

I'm sorry for taking your time.
I modified the code that was pointed out.

@taishi-oss no worries, thank you for your help! reviewing now

Not all methods in a file were introduced in the same version (e.g. see my comment about DecisionTreeClassifer.copy). Can you make sure that the annotation versions are correct? the jira has directions on how to identify the version a particular method was introduced.

Sorry, I misunderstood.
I check when all methods were introduced and modify it.
(use SPARK-7751 as a reference.)
If it is not my mistake, DecisionTreeClassifer.copy was introduced in 1.4.1.
And Should I add @Since annotation to val?

I believe the copy overrides were added by this commit which went in to 1.5, not 1.4.1. SPARK-7751 has detailed directions on how to use the git history to identify the correct version numbers. You could also look at git blames and histories to figure out the exact commit that introduced it.
you should add annotations to all public methods and constructor parameters (i.e. to vals if they are parameters in a public constructor).

I think that commit is right.
but "git show" command results as follows.
I also think this is right.
[takahashi@phi spark]$ git show v1.4.0:mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala | grep "override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra)"
[takahashi@phi spark]$ git show v1.4.1:mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala | grep "override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra)"
  override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra)
[takahashi@phi spark]$ git show v1.5.0:mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala | grep "override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra)"
  override def copy(extra: ParamMap): DecisionTreeClassifier = defaultCopy(extra)

Which should I believe?

Hmm I actually don't know the answer to that, maybe @mengxr can help

@mengxr Could you take a look?
Now, I'm adding Since annotation to ml.classification.
I think DecisionTreeClassifer.copy is introduced in this commit (v.1.5.0).
but, "git show" command shows that DecisionTreeClassifer.copy is introduce in v1.4.1.
(Please see above.)
Which version should I add Since annotation to this method?

I think DecisionTreeClassifer.copy is introduced in v1.5.0.
but, This method is brought into v.1.4.1 using "git-cherry-pick".
So "git blames" says v.1.5.0 but "git show" says v.1.4.1.
I compare "git show" commnad's results with "git blames"'s results in ml.classification, and then there are some differnces as desribed above.

@hiross thank you for your contribution. Could you update this PR? After that, I could review it.

Jenkins, test this please.

Sorry for being late.
I rebased this branch.

@taishi-oss thanks for rebaseing master. Could you add @Since to all public variables?

ping @taishi-oss

@yu-iskw Sorry for being late, I'm do right now.

I modified the code that was pointed out.

@taishi-oss thank you for the udpate! LGTM
@jkbradley could you take a look at PR?

@jkbradley could you run tests for this PR? This is the fist PR for @taishi-oss.

test this please

ok to test.

I've left some comments, otherwise it's LGTM but It's good if @jkbradley or @mengxr can take a look at.

Jenkins, test this please.

Test build #47152 has started for PR 8534 at commit 4e0a925.

Test build #47153 has started for PR 8534 at commit 4e0a925.

Test build #47152 has finished for PR 8534 at commit 4e0a925.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeClassifier (\n  * final class GBTClassifier(\n  * class LogisticRegression(\n  * class MultilayerPerceptronClassifier(\n  * class NaiveBayes(\n  * final class OneVsRest(\n  * final class RandomForestClassifier(\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47152/
Test PASSed.

Test build #47153 has finished for PR 8534 at commit 4e0a925.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeClassifier (\n  * final class GBTClassifier(\n  * class LogisticRegression(\n  * class MultilayerPerceptronClassifier(\n  * class NaiveBayes(\n  * final class OneVsRest(\n  * final class RandomForestClassifier(\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47153/
Test PASSed.

Thank you for reviewing.
I'm modifying.

Test build #47196 has started for PR 8534 at commit 3743123.

@sarutak thank you for your help!

Test build #47196 has finished for PR 8534 at commit 3743123.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeClassifier (\n  * final class GBTClassifier(\n  * class LogisticRegression(\n  * class MultilayerPerceptronClassifier(\n  * class NaiveBayes(\n  * final class OneVsRest(\n  * final class RandomForestClassifier(\n

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47196/
Test PASSed.

Test build #47260 has started for PR 8534 at commit 6831e7a.

I modified the code that was pointed out.
@sarutak @yu-iskw Thank you for reviewing!

Test build #47260 has finished for PR 8534 at commit 6831e7a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):\n  * final class DecisionTreeClassifier @Since(\"1.4.0\") (\n  * final class GBTClassifier @Since(\"1.4.0\") (\n  * class LogisticRegression @Since(\"1.2.0\") (\n  * class MultilayerPerceptronClassifier @Since(\"1.5.0\") (\n  * class NaiveBayes @Since(\"1.5.0\") (\n  * final class OneVsRest @Since(\"1.4.0\") (\n  * final class RandomForestClassifier @Since(\"1.4.0\") (\n  *  public abstract static class PrefixComputer\n

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47260/
Test PASSed.

Merged build finished. Test PASSed.

Merged into master and branch-1.6. Thanks!

Thank you for merging!


Proposal to implement Maven CycloneDX Property Taxonomy

Hi,
This is a proposal to add a new Namespace for Maven under cdx namespace.
For example something like cdx:maven similar to npm.
With this a property to specify the scope of the dependency  scope. i.e https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope
which can be repreented as cdx:maven:package:scope

@mr-zepol @stevespringett

@hboutemy what is you opinion here?

would somebody draft a pullrequest for the new namespace?
See the existing ones for examples: https://github.com/CycloneDX/cyclonedx-property-taxonomy/tree/main/cdx
we then could discuss changes and additions in the opened pulrequest.

We already have created a few properties in previous cyclonedx-maven-plugin without making them formal: I'll need to formalize existing ones
and new ones need to be created immediately in the official taxonomy
I'll have a look next week, I'm busy for now...

Great. Looking forward to merging your pullrequest. :D

see discussion here: https://github.com/CycloneDX/cyclonedx-property-taxonomy/pull/69

I'll close this, as i see the original request being solved - a cdx:maven exists and can be improved - https://github.com/CycloneDX/cyclonedx-property-taxonomy/blob/main/cdx/maven.md
Thank you all for your work.


Make mp4 parsing faster & reduce memory overhead

What

Part of https://github.com/rerun-io/rerun/issues/7481
Depends on https://github.com/rerun-io/re_mp4/pull/12

Some rough numbers:
main@de4c389   297.43   µs
this branch      3.8957 µs

Measured on Big_Buck_Bunny_1080_10s_av1.mp4 from our test assets (downloaded via tests/assets/download_test_assets.py)
Total Rerun memory usage for a 297 MiB video (the entire Sintel movie):
main@de4c389   573 MiB
this branch    325 MiB

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!
[x] If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

PR Build Summary
Recent benchmark results
Wasm size tracking

To run all checks from main, comment on the PR with @rerun-bot full-check.

We still copy each sample when we enqueue a chunk, which feels like it should not be necessary. It would be nice to have direct access to the video data arrow buffer in decoders, so that we can index into it there, but I wasn't 100% sure how to make that work here so I left it out.

(trying to measure this by adding a benchmark)

Some rough numbers:
main@de4c389   297.43   µs
this branch      3.8957 µs

Measured on Big_Buck_Bunny_1080_10s_av1.mp4 from our test assets (downloaded via tests/assets/download_test_assets.py)

Running a nightly build to check if the bench works: https://github.com/rerun-io/rerun/actions/runs/11461677788

Bench was missing nasm for the build, maybe it works now: https://github.com/rerun-io/rerun/actions/runs/11461814078


Inconsistent Credential Rendering between verifier and holder view

Related to ticket #1778 & #560.
Acceptance criteria

Ensure credential issuer is visible
credential name is consistent
formats are consistent

The verifier sees:

The holder sees:

Credentials names are consistent. Issuer names appear even when credential is not available, dates are consistent.