HDDS-8166. [Snapshot] Add a config to enable or disable Ozone snapshot feature on OM

What changes were proposed in this pull request?
Add an option to control whether Ozone filesystem snapshot feature is enabled or not on the OM side.

Add this new OM config.
Enable Ozone (filesystem) snapshot feature by default to avoid disruption with on-going dev work.
When disabled:
a) All snapshot related OM background tasks shall not run
b) Snapshot requests (CreateSnapshot / DeleteSnapshot) are gracefully rejected (OMException with FEATURE_NOT_ENABLED), achieved by a new AspectJ annotation implementation.
All existing and upcoming integration tests, UTs and acceptance tests related to Ozone snapshot feature would have a line to explicitly enable the snapshot feature for testing so those tests would still run and pass even when the default is switched to false.

There is a follow-up JIRA to refactor OmSnapshotManager constructor to further reduce the initialization done when snapshot feature is disabled: HDDS-8529.
TODO

[x] Remove extra omSnapshotManager null checks added in this PR now that we can't really not initialize it.

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8166
How was this patch tested?

[x] All existing tests shall pass.
[x] All existing tests shall pass even when default is set to false

https://github.com/smengcl/hadoop-ozone/commits/HDDS-8166-snapshot-config-false-4

[x] Add new UT to test the AspectJ annotation.
[x] Add a simple integration test to validate that client indeed get FEATURE_NOT_FOUND when the snapshot feature is disabled. Similar idea to HDDS-7772 but not quite the same implementation.

LGTM. @smengcl @prashantpogde can you file a follow up jira to define the long term story around this config flag? We need to decide if moving it from on to off and back to on is supported, and add corresponding tests or docs for whatever decision is made.

Thanks @errose28 . I filed HDDS-8555 as a follow-up.

Thanks @hemantk-12 @prashantpogde @errose28 for reviewing this.

We may not want to invest too much time in a long-term story, this flag is just for short-term use until the snapshot feature is fully ready and stable.


snapshot are getting updated without update flag

Thanks for reporting an issue to us! We're glad you are using and invested in Enzyme.
Before submitting, please read over our commonly reported issues to prevent duplicates!
All common issues

common issues

Notoriously common issues

Webpack build issues
Cannot find module 'react-dom/lib/ReactTestUtils'
Query Selector fails
Testing third party libraries

If you haven't found any duplicated issues, please report it with your environment!
Current behavior
npm run test is updating the snapshot without update flag.
div className={classNames(styles.hello, 'x y')} changed it to following
div className={classNames(styles.hello, 'x')}
and then I ran npm run test (which is not using update flag) but it updated the snapshot and hence build gets passed.
Expected behavior

first of all it should not update the snapshot if we do not pass the update flag

Your environment
enzyme: 3.2.0
karma: 1.7.1
API

[ ] shallow
[ ] mount
[ ] render

Version

library
version

enzyme
3.2.0

react
16.4.1

react-dom
16.4.1

react-test-renderer

adapter (below)

Adapter

[x] enzyme-adapter-react-16.1.1

closing as this issue is related to enzyme-to-json

enzyme does not support or encourage snapshot testing; the closest we offer is .debug().
I'll close this, but am happy to reopen if you're seeing an issue there.

enzyme does not support or encourage snapshot testing

Could you elaborate a bit on this? The word 'snapshot' is missing from the official documentation, which I interpret as more agnostic than specifically not encouraging/supporting the testing methodology. Is the thought here that a well-designed React application shouldn't need snapshot testing, as explicit assertions should be simple enough with the combination of a well-componentized application and enzyme tooling?

@c3chong the lack of a mention is a discouragement :-)
Snapshot testing is inherently brittle. What happens in practice is that developers rubber-stamp snapshot diffs without fully understanding why they've changed, and the false sense of confidence given causes developers to not thoroughly review the code. The only time snapshots are valuable is when you're doing a "no observable changes" refactor, which is rare, and in most cases, you don't actually care about the rendering hierarchy - you care about specific components being rendered, specific content being rendered, etc - which is what explicit tests address.
In addition, a snapshot contains so much noise that there's no way to know what pieces are important, and which can be ignored, and it's not practical to review every snapshot change and assume they're all important.

@ljharb thank you! All that being said, should I expect inconsistent, incorrect, or untested behaviour when using snapshots with enzyme? I'm trying to discern whether, given the right use case, if it's safe to rely on snapshot tests when using the enzyme wrapper?

@c3chong you should expect all snapshot behavior to come from whatever non-enzyme tool you're using to work with them - jest, enzyme-to-json, etc. The closest thing enzyme provides and supports is .debug(). So how "safe" it is depends on how reliable those projects are - in my experience, snapshots aren't safe.


feat(configprovider): support classprefix replace for all components

🤔 这个 PR 的性质是？

[ ] 日常 bug 修复
[x] 新特性提交
[ ] 文档改进
[ ] 演示代码改进
[ ] 组件样式/交互改进
[ ] CI/CD 改进
[ ] 重构
[ ] 代码风格优化
[ ] 测试用例
[ ] 分支合并
[ ] 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

fix(组件名称): 处理问题或特性描述 ...

[ ] 本条 PR 不需要纳入 Changelog

☑ 请求合并前的自查清单
⚠ 请自检并全部勾选全部选项。⚠

[x] 文档已补充或无须补充
[x] 代码演示已提供或无须提供
[x] TypeScript 定义已补充或无须补充
[x] Changelog 已提供或无须提供

Codecov Report

Merging #1287 (d19bc4b) into develop (492d477) will increase coverage by 0.19%.
The diff coverage is 50.80%.

@@             Coverage Diff             @@
##           develop    #1287      +/-   ##
===========================================
+ Coverage    57.94%   58.14%   +0.19%
===========================================
  Files          407      407
  Lines        15371    15280      -91
  Branches      2931     2890      -41
===========================================
- Hits          8907     8884      -23
+ Misses        6187     6120      -67
+ Partials       277      276       -1

Impacted Files
Coverage Δ

src/calendar/const.ts
100.00% <ø> (ø)

src/cascader/cascader.tsx
64.00% <ø> (ø)

src/color-picker/color-picker.tsx
81.25% <ø> (ø)

src/date-picker/DatePicker.tsx
26.74% <ø> (ø)

src/date-picker/DateRangePicker.tsx
15.82% <ø> (ø)

src/date-picker/base/Header.tsx
7.57% <0.00%> (-0.37%)
:arrow_down:

src/date-picker/date-picker-panel-props.ts
100.00% <ø> (+90.00%)
:arrow_up:

src/date-picker/date-range-picker-panel-props.ts
100.00% <ø> (+90.90%)
:arrow_up:

src/date-picker/date-range-picker-props.ts
42.85% <0.00%> (-11.69%)
:arrow_down:

src/date-picker/hooks/useRange.ts
35.89% <ø> (ø)

... and 78 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fxing mising env details on mail report body

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- Ginger/GingerCoreNET/Run/RunSetActions/RunSetActionHTMLReportSendEmail.cs  2

See the complete overview on Codacy


Fix EventServiceStream

Closes #<ISSUE_NUMBER>

This PR:

This PR does not:

Key places to review:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

39 of 46 (84.78%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+1.7%) to 73.61%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

crates/shared/src/utils.rs
39
46
84.78%

Files with Coverage Reduction
New Missed Lines
%

crates/legacy/src/builder_state.rs
1
83.46%

Totals

Change from base Build<PHONE_NUMBER>1:
1.7%

Covered Lines:
2463

Relevant Lines:
3346

💛  - Coveralls


Create above and beyond modpack, Machine Operator Crash loop

I was setting up the machine operator spirit to link to my storage actuator and was going to see how it moves stuff and went to put an item in its inventory with Shift Click, this instantly crashed my game and now the world crashes whenever i load it.
To Reproduce

tier 1 dimensional storage settup, nearly full
summon machine operator
place item in machine operators hand while linked to the storage actuator

Expected behavior
It would move the item to the storage inventory
System (please complete the following information):
occultism-1.16.5-1.20.1.jar
windows 11

Minecraft Version: 1.16.5
Modpack Link and Version, or list of mods:
https://www.curseforge.com/minecraft/modpacks/create-above-and-beyond latest release

Additional context
crash-2023-08-09_16.22.38-server.txt
thanks in advanced for any help! Love this mod a lot, top 3 for me!

@Mogwr Sadly I cannot fix this as 1.16.5 is no longer supported, and C: A&B makes a lot of changes and adds a lot of mods with mixins that may interfere with occultism.
I can only say that this bug is not a known one, so its possible that there is a way around it.
Looking at the changelog of the latest A&B version (1.3) it has occultism 1.16.6-1.23.1 which is higher than yours, so you could try that one (https://www.curseforge.com/minecraft/modpacks/create-above-and-beyond/files/3567550)


[DOCFIX] Update ALLUXIO_MASTER_VERSION_SHORT in _config.yml

In order for the docs to be rendered properly on alluxio.org, the ALLUXIO_MASTER_VERSION_SHORT must be set to the name of the branch (e.g., master, branch-1.3, etc.).
This PR updates the variable to master on the master branch.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12926/
Test PASSed.

LGTM


regression from 1.4.3 to 1.5.1

After upgrading to 1.5.1, I began seeing the following error in tests that used to pass:
TypeError: Uncaught error: Cannot call method 'test' of undefined
    at /Users/z/n/newww/node_modules/marky-markdown/node_modules/sanitize-html/index.js:132:46

I worked around it by adding span: [] to the allowedAttributes map:
https://github.com/npm/marky-markdown/blob/f6c7dbc6c6d2d583badde66c4982481d9f8ab435/lib/sanitize.js#L49
I think there needs be a check to ensure allowedAttributesGlobMap[name] is a string before calling test().
Thanks for creating this package, by the way. It's got a nice intuitive API. We're now using it on https://www.npmjs.com/ to sanitize READMEs.

Good catch, this is fixed. Glad you're finding it useful on npmjs.com!


Add support for groupby

For reference, the python client returns groups as
{"groupValue" : Group, ...} where each group is
@dataclass
class _GroupByResult(Generic[P]):
    name: str
    min_distance: float
    max_distance: float
    number_of_objects: int
    objects: List[_Object[P]]  <= contains all objects that belong to a group

Introduced in https://github.com/weaviate/weaviate-python-client/pull/535


FetchPickAndPlace-v1

Hello! I'm sorry to bother you again. I created a sub optimal policy when running ' mpirun -oversubscribe -np 16 python -u train.py --env-name='FetchPickAndPlace-v1' 2>&1 | tee pick.log'. When the success rate reaches 0.9, it will not increase. Can you analyze the reason? Thank you very much! I'm sorry to bother you again!

@quyouyuan No worries! In actually, that is the problem of HER itself. The performance of HER on the PickAndPlace task is only around 0.9, please refer to Fig.3 in https://arxiv.org/pdf/1802.09464.pdf (this is the OpenAI's report of HER).

请问环境呢
我怎么找不到环境


[Documentation Improvement] Missing dependency

When I tried to run NetShare in a Docker container, I realized it had an implicit dependency on libpcap. I used this command to install pcap2csv.so:
sudo apt install libpcap-dev

Maybe it would be helpful to add this dependency line in the README file?

Thanks, Han. Hope all is well :)
I added a quick section to README regarding the libpcap installation.


Characters misbehaving due to CLI response encoding

Issue with CLI response character encoding
When using Git Bash in Windows it now prints out some characters (usually underlines or separators) as strange strings.
Steps To Reproduce:

Install Git Bash from https://gitforwindows.org/
i.e. run sfdx force:org:list --all  in the Git Bash terminal

SFDX CLI Version(to find the version of the CLI engine run sfdx --version): sfdx-cli/7.72.0-697e9faee2 win32-x64 node-v12.18.3
SFDX plugin Version(to find the version of the CLI plugin run sfdx plugins --core): salesforcedx 49.6.1
OS and version: Windows 10 Enterprise 1909 Build 18363.1016

The issue is not coming from the CLI response since it is working just fine in VS code.

Closing this issue as it is a Terminal error.


Wrinkles classifier

Pull Request for DL-Simplified 💡
Issue Title : wrinkles classifier

Info about the related issue (Aim of the project) : To crate a deep learning code for classifying wrinkles on face
Name: Nikhil gautam
GitHub ID: https://github.com/Nikhil1601
Email ID<EMAIL_ADDRESS>Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) SWOCS3

Closes: #178
Describe the add-ons or changes you've made 📃
Created deep neural network program to classify wrinkles
Give a clear description of what have you added or modifications made
I have created a CNN network to work upon a dataset to classify wrinkles into present or not.
Type of change ☑
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested? ⚙
Yes i have tested it using Precision, Recall, BinaryAccuracy provided by keras
Describe how it has been tested
Describe how have you verified the changes made
Checklist: ☑

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly wherever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[x] I have added things that prove my fix is effective or that my feature works.
[x] Any dependent changes have been merged and published in downstream modules.

Due to some issue need to create new pull request please check this out


ZEPPELIN-60 Document angular display system. and more

This PR adds / modify website

[x] Add documentation for Angular display system
[x] Add how to contribute to website
[x] Restructure documentation : list all interpreters and display systems.

I think it's ready. Please review this.

+1

Merging if there're no more discussions


T03.01-Exercise-RecyclerViewLayout GreenAdapter.java

In T03.01-Exercise-RecyclerViewLayout... GreenAdapter.java
There are references to:
R.layout.number_list_item
and
R.id.tv_item_number
that not exists in layout file.

@johnshea I have checked and it seems that you deleted the file by mistake in your last commit. Need to be added back again. I do not have permissions to do it myself.
@AndreaLombardo In the meantime you can add it manually to your project: https://github.com/udacity/ud851-Exercises/blob/05cc7c2f3a6475297a1e69f8ba7862ec83e2337e/Lesson03-Green-Recycler-View/T03.01-Exercise-RecyclerViewLayout/app/src/main/res/layout/number_list_item.xml


Stop for debugging does not seem to actually stop for debugging

[2022-10-18 06:33:15,327 - ERROR - proc_hpguppi.py:124] Timeout of 600 seconds exceeded
[2022-10-18 06:33:15,327 - ERROR - proc_hpguppi.py:74] Timed out, processing has not started.
[2022-10-18 06:33:15,327 - ERROR - automator.py:432] hpguppi_proc timed out. Stopping automator for debugging.
[2022-10-18 06:33:16,417 - INFO - automator.py:113] Starting Automator:
Redis endpoint: <IP_ADDRESS>:6379
Processing script: /home/obs/bin/processing_example.sh

[2022-10-18 06:34:29,844 - INFO - automator.py:198] New state: configure
[2022-10-18 06:34:29,844 - INFO - automator.py:264] Ignoring irrelevant state for array_1
[2022-10-18 06:35:31,356 - INFO - automator.py:198] New state: conf_complete
[2022-10-18 06:35:31,357 - INFO - subarray.py:38] New subarray object for array_1
[2022-10-18 06:35:31,357 - INFO - automator.py:249] Initialised new subarray object: array_1 in state conf_complete

Maybe circus is restarting it? I also wonder whether we should be ignoring the conf_complete state, it doesn't appear like we currently do anything with that at all.

Changed to go into "pause" mode which just does nothing in response to new messages, so circus won't restart it. https://github.com/UCBerkeleySETI/commensal-automator/commit/524a9cd1f7e545c4f7aacc4a51bbe5b0f7a91b91


Auto remove wont fix on reopen

Summary
Removes the won't fix label from an issue when reopened

Holy smokes that was fast. Thanks Andy!

Holy smokes that was fast. Thanks Andy!

@gewarren @IEvangelist but does it work!?! Let's see...

@gewarren @IEvangelist but does it work!?! Let's see...


SPARKC-29: Improve error message when SparkContext is null in CassandraR...

...DD after deserialization and the user wants to transform it.

LGTM

Merged into b1.1 and master as well.


Apply Codecov ignore patterns

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f1e2d19) 27.04% compared to head (1b13961) 64.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #137       +/-   ##
===========================================
+ Coverage   27.04%   64.80%   +37.75%
===========================================
  Files          41       12       -29
  Lines        1638      537     -1101
===========================================
- Hits          443      348       -95
+ Misses       1138      161      -977
+ Partials       57       28       -29

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Pagination in Blog Page

Is this page going to display all blog posts or latest few?
There is a SlicePipe which is set to 10 and the paginator doesn't working with the posts. So if it only shows latest posts SlicePipe is enough I think. Paginator can be removed.

Is this page going to display all blog posts or latest few?
There is a SlicePipe which is set to 10 and the paginator doesn't working with the posts. So if it only shows latest posts SlicePipe is enough I think. Paginator can be removed.

actually this is not closed. Is any issue of this?


Feature: Folders can now be opened in secondary pane with Keyboard Accelerator (Ctrl+Shift+Enter)

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #10907

What has been done

Made the process to open a folder in the dual pane into a method inside NavigationHelpers.
Added the keyboard accelerator to both Grid View and Details View. (Not in Column View).
Added a null check in FileList_PreviewKeyDown for each view.
Fixed the missing icon on the flyout menu to open in dual pane option. (Used the one from the Settings)

Validation
How did you test these changes?

[x] Built and ran the app
[x] Tested the changes for accessibility

Screenshots
With icon:

Without icon:

Aside from that LGTM

Aside from that LGTM and works for me

Aside from? I suppose your review did not get through.

Does it not appear?

Wouldn't it be better to rename the function to OpenInSecondaryPane for consistency?


DISCUSSION: logspout > AWS CloudWatch Logs

How about logspout -> syslogd -> CloudWatch Log Agent, that is merging in a single container:

https://github.com/gliderlabs/logspout
https://blogs.aws.amazon.com/application-management/post/TxFRDMTMILAA8X/Send-ECS-Container-Logs-to-CloudWatch-Logs-for-Centralized-Monitoring

Has anyone tried it?
Is there any better alternative?

Main thing is that logspout is never going to write logs to disk. The way I'd like to see CloudWatch Logs integration is if the logs can be published directly... either if the cloudwatch agent accepts syslog (which I don't believe it does) or if somebody write an adapter that publishes to the API directly.
Alternatively, if somebody wanted to make an rsyslog container that wrote to disk, then logspout could forward to that agent, which could then also run the cloudwatch agent.

If my understanding is correct, your 2nd paragraph describes https://blogs.aws.amazon.com/application-management/post/TxFRDMTMILAA8X/Send-ECS-Container-Logs-to-CloudWatch-Logs-for-Centralized-Monitoring

There you go.

Thanks.
For your information AWS API is a dead end because of ThrottleException.
Coming from https://github.com/nearform/docker-cloudwatch/issues/2

I wouldn't call that a dead end. It just requires batching.
On Mon, Jun 8, 2015 at 10:11 AM, Jacques L. Chereau <
<EMAIL_ADDRESS>wrote:

Thanks.
For your information AWS API is a dead end because of ThrottleException.
Coming from nearform/docker-cloudwatch#2
https://github.com/nearform/docker-cloudwatch/issues/2
—
Reply to this email directly or view it on GitHub
https://github.com/gliderlabs/logspout/issues/110#issuecomment-110032656
.

--
Jeff Lindsay
http://progrium.com

@jlchereau From what I can tell, the second paragraph in the blog post you linked isn't exactly what you're looking for. It appears they are using supervisord to run both the CloudWatch agent and rsyslog inside a container. While you could pipe logs from the Docker socket -> Logspout -> Syslog + Agent, it seems simpler to go straight through the API. The API documentation make it seem like it should be pretty straight forward to perform in-memory batching of log events before sending them to the API. I'm going to try taking a stab at this tomorrow.

That would be great. It's on my list to do myself, but it's unlikely I'll
get to it soon.
On Wed, Jul 8, 2015 at 2:50 PM, Brad Gignac<EMAIL_ADDRESS>wrote:

@jlchereau https://github.com/jlchereau From what I can tell, the
second paragraph in the blog post you linked isn't exactly what you're
looking for. It appears they are using supervisord to run both the
CloudWatch agent and rsyslog inside a container. While you could pipe logs
from the Docker socket -> Logspout -> Syslog + Agent, it seems simpler to
go straight through the API. The API documentation make it seem like it
should be pretty straight forward to perform in-memory batching of log
events before sending them to the API. I'm going to try taking a stab at
this tomorrow.
—
Reply to this email directly or view it on GitHub
https://github.com/gliderlabs/logspout/issues/110#issuecomment-119711719
.

--
Jeff Lindsay
http://progrium.com

I have tried batch sizes of 10, 20, 50, 100 and 150 without success: always get a ThrottleException from AWS API.

@jlchereau I started playing with this when I had a few spare minutes, and while I'm not done, I have made progress. The trick is that you can't just run batches based on the number of log messages. Based on the CloudWatch docs, my batching strategy is:

Start buffering logs in memory.
Flush logs when buffer reaches 10,000 messages.
Flush logs when buffer reaches 1,048,576 bytes.
Flush logs if no logs have been received in 1 second and the buffer is not empty.

@bradgignac thank you. I am not confident with this batching strategy because if the container crashes (or is simply restarted because it is bound to other containers within the same AWS ECS service and ECS decides to restart them because one is unhealthy), thousands of log messages might get lost. Unless I have missed something, I would not consider relying on a logging strategy that might dismiss messages before a crash. Therefore it seems that building a reliable logging infrastructure with logspout + AWS cloudwatch might require more development than I intend to commit considering other possible options.

@jlchereau Worth noting that these options could be tuned. The message limit and byte limit are just the maximum values allowed by the API.

Also, I think if the container crashes, your biggest concern would not be the in-memory buffer. It would be the logs you miss while the container is down.

This has been implemented at https://github.com/bradgignac/logspout-cloudwatch. It's still early -- I need to add CI and better documentation, but we're using it in production at Rackspace.

Awesome!

@jlchereau did you find a solution to post logs to cloudwatch? Or did you opt for another solution?
@bradgignac seems abandoned, correct?

No need for logspout. Simply printing to stdout in docker containers and redirecting the stdout to cloudwatch.

But you aren't you loosing the ability of seeing docker logs and docker service logs with it?

@damianobarbati Correct. I no longer use logspout so my implementation is no longer maintained.


Swarmkit v2

- What I did
Swarmkit v2
- How I did it
https://github.com/icholy/gomajor
- How to test it
🤷
- Description for the changelog

Looks like protobuf validation isn't happy (perhaps it's somewhere still referencing the old name)

Also some warning (not the cause of the failure); circleci looks to be running an ancient ubuntu version

I got further, but the generated .pb.go files still have import declarations for "github.com/docker/swarmkit/protobuf/plugin". I'm out of my depth here; any ideas @dperny?

In Protobuild.toml, there is a [packages] section. At the bottom of that section, add a line:
"github.com/docker/swarmkit/protobuf/plugin/plugin.proto" = "github.com/moby/swarmkit/v2/protobuf/plugin"

This makes the import path correct.


$scraper->user->video() sometimes returns false;

Hello again Robert :)
Thank you for the Exceptions issue response and fix btw :)
Another thing I've noticed is, when you search an exiting video, with $scraper->user->video("@psg",<PHONE_NUMBER>221741317) , for example, sometimes it returns false, but if I run the script again, I catch it, so it doesn't return false anymore....
It happens to me sometimes, it returns a https 0 code, non existing host, and the host is https://www.tiktok.com/@psg/video/6848259790221741317 , and it exists...
Sometimes, I can run the script like 5 times and only catch it on the 6th try...
I don't know what's happening, if it is the curl request, some kind of timeout, I don't know :/
You have any ideia of what might be causing this issue?

Hey @AdrianoRamalho21 -- Very interesting issue you're having.
I've been looking into this using the exact same video data you've provided here. The hard part for me personally is that I've tried it in 3 different environments now (Also 3 different IPs).
One being my local machine, one being on a VPS, and another being on a completely separate VPS with and without a proxy.
All of these have returned 10/10 results. Is there a chance they might be limiting your IP? I haven't personally ran in to any limiting issues, but that's also because I always run a proxy rotator out of the gate anymore when it comes to this kind of thing, which is why I implemented the proxy configuration early on in the scraper.
I would attempt a proxy to see if it gives you better results, you can do so by setting the following configuration:
'proxy' => [
    'protocol' => 'http',
    'address' => '<IP_ADDRESS>:8080',
    'auth' => 'username:password'
]

If the problem still persists, I will investigate more time into it.


Potential mistake in two cost functions

When working on PR #83 I noticed a possible mistake in the implementation of two of the (operator-specific) cost metrics, namely the one about number of RDF terms shipped in responses and number of variables shipped in responses. These implementations are now in the classes CFRNumberOfTermsShippedInResponses and CFRNumberOfVarsShippedInResponses, respectively. The mistake that I mean is described in the TODO comment in lines 66-68 and lines 64-66, respectively.
@chengsijin0817 can you please take a look at this and check whether my suspicion is right. In this case, maybe you also have to change the corresponding part in the paper?

When working on PR #83 I noticed a possible mistake in the implementation of two of the (operator-specific) cost metrics, namely the one about number of RDF terms shipped in responses and number of variables shipped in responses. These implementations are now in the classes CFRNumberOfTermsShippedInResponses and CFRNumberOfVarsShippedInResponses, respectively. The mistake that I mean is described in the TODO comment in lines 66-68 and lines 64-66, respectively.
@chengsijin0817 can you please take a look at this and check whether my suspicion is right. In this case, maybe you also have to change the corresponding part in the paper?

Hi, I have revised these two cost functions.
To take care of the different types of graph patterns in SPARQL requests, I also added a method in QueryPatternUtils: getVariablesInPattern(final SPARQLGraphPattern queryPattern). Please check them.
The corresponding part in the paper was defined in terms of the type of federation member.

See my comments in the PR, and thanks also for checking the corresponding part in the paper. Good to know that it was correct there!


Updating velero_image doesn't bounce restic pods

When the MigrationController is updated with a new velero_image, the operator updates the velero deployment and the restic daemonset. The deployment update causes openshift to bounce the velero pod. The daemonset update does not cause the restic pods to bounce. The pods need to be deleted when updating the restic daemonset so that they will be restarted with the right configuration.

We can probably use a handler so that if we see we changed the daemon set we can delete the pods.
We already know how to find and delete the pods for cleanup when we remove the daemonset because deleting the daemonset also doesn't remove them.

https://github.com/fusor/mig-operator/blob/master/roles/migrationcontroller/tasks/main.yml#L459-L473

I'll work on this in a bit.


Enforce memory limit in phpunit.xml

This will help highlight memory regressions, make it easier for newcomers to get started with the codebase w/o editing php.ini defaults (128M), and also keep things consistent between local and travis runs.

Test failure is unrelated to this change, and should pass after #322 is merged.


⚡ 0.30 RELEASE 🚀

⚠ This is will work in progress 🏗

Libp2p Connection Manager overhaul

🗺 What's left for release
TODO
🔦 Highlights
📉 Decaying tags in the Connection Manager
TODO
🚪 Connection gating
TODO
...
🏗 API Changes
TODO
✅ Release Checklist

Robustness and quality

[ ] Ensure that all tests are passing, this includes:

[ ] unit

[ ] Publish a release candidate to npm# Minor prerelease (e.g. 0.24.1 -> 0.25.0-rc.0)
$ npx aegir release --type preminor -t node -t browser --preid rc --dist-tag next

# Increment prerelease (e.g. 0.25.0-rc.0 -> 0.25.0-rc.1)
$ npx aegir release --type prerelease -t node -t browser --preid rc --dist-tag next

[ ] Run tests of the following projects with the new release:

[ ] js-ipfs

Documentation

[ ] Ensure that README.md is up to date
[ ] Ensure that all the examples run

Communication

[ ] Create the release issue
[ ] Take a snapshot between of everyone that has contributed to this release (including its subdeps in IPFS, libp2p, IPLD and multiformats) using name-your-contributors. Generate a nice markdown list with this script
[ ] Announcements (both pre-release and post-release)

[ ] Twitter
[ ] IRC
[ ] Reddit
[ ] discuss.libp2p.io

[ ] Blog post
[ ] Copy release notes to the GitHub Release description

❤ Huge thank you to everyone that made this release possible
In alphabetical order, here are all the humans that contributed to the release:

...

🙌🏽 Want to contribute?
Would you like to contribute to the libp2p project and don't know how? Well, there are a few places you can get started:

Check the issues with the help wanted label in the libp2p repo
Join an IPFS All Hands, introduce yourself and let us know where you would like to contribute - https://github.com/ipfs/team-mgmt#all-hands-call
Hack with IPFS and show us what you made! The All Hands call is also the perfect venue for demos, join in and show us what you built
Join the discussion at http://discuss.libp2p.io/ and help users finding their answers.
Join the ⚡libp2p Weekly Sync 🙌🏽 and be part of the Sprint action!

⁉ Do you have questions?
The best place to ask your questions about libp2p, how it works and what you can do with it is at discuss.libp2p.io. We are also available at the #libp2p channel on Freenode.

Related to connection gating: https://github.com/libp2p/js-libp2p/issues/175


PF-1525 GWM - Planned Specimens Instantiator fails with Object not set to an instance of an object

Incorrect logic ... just needed to be turned around

Complete


Support check-boxes for reporters in flyout

The flyout should allow blocks to have a check-box property. If this is set, the block is shown with a checkbox to the left of it. When the checkbox is checked or unchecked, a UI event is generated so Scratch can show/hide a value monitor. The check-box should have state on initiation (some projects will have this checked in the saved state).

Is this also expected to work in horizontal mode?

Horizontal flyout, I'm assuming (not horizontal blocks, which I think should be irrelevant),
Not clear if we'll ever be using horizontal flyout on the vertical blocks. If it's easy enough to place the checkbox above the block in "top" mode and below the block in "bottom" mode, I think that would be nice :). But definitely not the highest priority.

The checkbox should also update if any drop down within the block on the flyout changes - Scratch 2 is flawed in this regard (with the checkbox checked state getting out of sync with the reporters that are actually currently displayed).
This is easiest seen in Scratch 2 with the 'current minute/month/date' etc. block - check the box and then change the drop down to a different type - the checkbox does not update as it should on the parameter change.

Perhaps let's have the state of the checkbox flow from the VM. When you click it trigger a UI event. And have a some method the VM can use to check/uncheck the checkbox?


Rework embedded forms

Summary
Add needed types, and example to hello app.
Ticket Link
Redux: Soon
Webapp: https://github.com/mattermost/mattermost-webapp/pull/7423

Codecov Report

Merging #56 (b5f7cdb) into master (831d203) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   21.51%   21.51%
=======================================
  Files          25       25
  Lines         674      674
=======================================
  Hits          145      145
  Misses        520      520
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831d203...b5f7cdb. Read the comment docs.

Codecov Report

Merging #56 (b5f7cdb) into master (831d203) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   21.51%   21.51%
=======================================
  Files          25       25
  Lines         674      674
=======================================
  Hits          145      145
  Misses        520      520
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 831d203...b5f7cdb. Read the comment docs.

After coming back and forth in my head, I ended up leaving the whole "attachment" as a binding. We already use this structure "for everything", so if we need to redo the structure to support new stuff "only for embedded bindings" we can add them to this struct (or consider dividing this struct later).
CC @levb


Make commit clickable on the application list page

What would you like to be added:

Why is this needed:

fixed on PR #3441


Disable the JSRefactor Menu based on context

@swmitra for review
+@narayani28

Are we intending to disable only context menus, not from the menu bar?

There are few issues here: Until now we used to provide features for JS only, in which case it worked to have these shortcuts and triggers be a part of JS. But we're planning to incorporate other languages now, so the question is - what would happen when we want to provide refactoring for PHP or even TS.
These features should be handled centrally and the extension should only work as a provider.
So we might need to move these to the core.
As for menu bar, that is actually a bit complex. We do have capture event for the context menu but not the menu bar since that is shell based. I'll see what I can do.

Sounds good 👍  Agreed this should be handled centrally. Maybe we can also think of removing these menus from menus bar as after adding these menus Edit looks really odd.


Add user account and extract personal IDs from generic Nix config

Small step of #294
This is not a complete solution as I want...

https://github.com/nix-community/home-manager/blob/4ee704cb13a5a7645436f400b9acc89a67b9c08a/docs/manual/faq/multiple-users-machines.md?plain=1


Replace NIOSSHSendable with Sendable and remove it

We now require Swift 5.5.2 which includes Sendable so we no longer require the NIOSSHSendable workaround.
NIOSSHSendable is now no longer used and we can therefore remove it completely. This is would be a major change but we have not yet released a 1.x.x version of swift-nio-ssh. I expect none of our users to relies on NIOSSHSendable conformance instead of Sendable so I hope this doesn't actually break any of our users.

You might need to take a look at that 5.5 build failure.

5.5 did catch a mistake! SSHChannelData is actually not Sendable because IOData is not Sendable. This produces only a warning in 5.5 because we have imported NIOCore with @preconcurrency in Swift 5.6+ and IOData was not marked explicitly non-Sendable. IOData and some other types will soon be marked explicitly non-Sendable: https://github.com/apple/swift-nio/pull/2290


Fix compatibility with PostGIS 3.0

In https://github.com/omniscale/imposm3/commit/e29be21f51bff9228585ff753c912f48e6663d3e, calling populateGeometryColumn was limited to PostGIS versions != 2.
It seems that the initial intention was to limit this call to all PostGIS versions < 2, the only versions where it's necessary.
So this PR suggests to update the condition to get the same behavior with PostGIS 2.x and 3.0.

Note that some tests are failing in https://github.com/omniscale/imposm3/blob/master/import_/state_test.go (including on "master").
This is probably because the sequence numbers used in the tests are no longer consistent with osm.org

Thanks! And yes, the tests are failing because maintenance work on the planet server shifted the sequence numbers. I just pushed a fix.


Config changes dont apply to new Admin-UI

Describe the bug
When editing /etc/listproviders/event.upload.asset.options.properties the changes dont show up in the new Admin-UI (admin-ui). In the old UI (admin-ng) it works fine.
To Reproduce
Steps to reproduce the behavior:

Make some changes to /etc/listproviders/event.upload.asset.options.properties, e.g. remove a track
restart OC
Check in new admin-ui
Check in old admin-ng

Expected behavior
Should apply to new admin-ui
Screenshots
New admin-ui:

Old admin-ng:

The file:
######################################################
# The eventUploadAssetOptions list provides manual source, catalogs, and attachment uploads options for the Admin UI.
#
# IMPORTANT: Read the docs "admin" > "configuration" > "Manually Upload Assets" before changing this file.
#
# EVENTS.EVENTS.NEW.UPLOAD_ASSET.OPTION.*
# - Non source asset uploads (tracks, attachments and catalogs)
#
# EVENTS.EVENTS.NEW.SOURCE.UPLOAD.*
# - Source related uploads (processable media tracks)
#
# The asset option property key is internationalized for display in the Admin UI.
#
# The configuration value is in JSON format.
# - Attribute "id" starts with a prefix "attachment", "catalog", or "track" followed by underbar "_" (see doc for details).
# - Attributes "flavorType" and "flavorSubType" are used in workflow processing and in presentation pages.
# - Attribute "type" is the mediapackage element type.
# - - Catalog assets are expected to be in XML format.
# - - Attachment assets can be any format.
# - - Tracks mime type formats are varied, but not infinite.
# - Attribute boolean "multiple" is for uploading multiple source track files to the same flavor
# - Attribute "tags" adds one or multiple tags to the uploaded asset
# - - Multiple tags are delimited by "," (no whitespace)
#
# EVENTS.EVENTS.NEW.UPLOAD_ASSET.WORKFLOWDEFID
# - The workflow used when uploading assets to an existing mediapackage
#
######################################################

list.name=eventUploadAssetOptions

# The 'multiple' attribute determines if multiple elements with the same flavor are allowed or not. Default is false i.e. existing elements with same flavor are overwritten.

# Asset upload options are for new and existing events.
# EVENTS.EVENTS.NEW.UPLOAD_ASSET.OPTION.CLASS_HANDOUT_NOTES={"id": "attachment_class_handout_notes", "type": "attachment", "flavorType": "attachment", "flavorSubType": "notes", "displayOrder":1}
# EVENTS.EVENTS.NEW.UPLOAD_ASSET.OPTION.PREVIEW_IMAGE={"id":"attachment_preview_image", "type":"attachment", "flavorType": "presenter","flavorSubType": "search+preview", "displayOrder":2, "accept": ".bmp,.gif,.jpeg,.jpg,.png,.tif,.tiff"}
# EVENTS.EVENTS.NEW.UPLOAD_ASSET.OPTION.SUBTITLES={"id": "track_subtitles_option", "type":"track", "flavorType": "captions","flavorSubType": "source", "tags": "generator:unknown", "displayOrder":3, "accept": ".vtt"}
EVENTS.EVENTS.NEW.UPLOAD_ASSET.WORKFLOWDEFID=publish-uploaded-assets

# The video source track upload options are only for new events.
EVENTS.EVENTS.NEW.SOURCE.UPLOAD.NON_SEGMENTABLE={"id": "track_presenter","type":"track", "flavorType": "presenter","flavorSubType": "source", "multiple":false, "displayOrder":1, "accept": ".avi,.flv,.m4v,.mkv,.mov,.mp4,.mpeg,.mpg,.ogv,.webm,.wmv,.flac,.m4a,.mp3,.ogg,.wav,.wma,.f4v"}
# LUH 2023/11/13: Das Hochladen eines zweiten Tracks deaktiviert
#EVENTS.EVENTS.NEW.SOURCE.UPLOAD.SEGMENTABLE={"id": "track_presentation","type":"track", "flavorType": "presentation","flavorSubType": "source", "multiple":false, "displayOrder":2, "accept": ".avi,.flv,.m4v,.mkv,.mov,.mp4,.mpeg,.mpg,.ogv,.webm,.wmv,.flac,.m4a,.mp3,.ogg,.wav,.wma,.f4v"}
EVENTS.EVENTS.NEW.SOURCE.UPLOAD.SUBTITLES={"id": "track_subtitles", "type":"track", "flavorType": "captions", "flavorSubType": "source", "tags": "generator:unknown", "displayOrder":3, "accept": ".vtt"}
# The MULTIPLE_PARTS example shows how to enable choosing multiple source files for a single flavor. In this case, a fictional "multipart/part+source".
# EVENTS.EVENTS.NEW.SOURCE.UPLOAD.MULTIPLE_PARTS={"id": "track_parts","type":"track", "flavorType": "multipart","flavorSubType": "part+source", "multiple":true, "displayOrder":4, "accept": ".avi,.flv,.m4v,.mkv,.mov,.mp4,.mpeg,.mpg,.ogv,.webm,.wmv,.flac,.m4a,.mp3,.ogg,.wav,.wma"}
# EVENTS.EVENTS.NEW.SOURCE.UPLOAD.AUDIO_ONLY={"id": "track_audio","type":"track", "flavorType": "presenter-audio", "flavorSubType": "source", "multiple":false, "displayOrder":5, "accept": ".flac,.m4a,.mp3,.ogg,.wav,.wma"}
# Presenter and Presentation tracks uploaded in a single container
# EVENTS.EVENTS.NEW.SOURCE.UPLOAD.MULTIPLE_TRACKS={"id": "track_multi","type":"track", "flavorType": "multitrack","flavorSubType": "source", "multiple":false, "displayOrder":6, "accept": ".avi,.flv,.m4v,.mkv,.mov,.mp4,.mpeg,.mpg,.ogv,.webm,.wmv,.flac,.m4a,.mp3,.ogg,.wav,.wma"}

Thanks for the report. I could reproduce this, it's likely an issue with new ui. I could fix it by, in my browser, clearing all cookie and website data for the new admin interface and then immediately reloading the page.
Since this isn't the first time users had issues that could only be resolved by hard-reloading a page, I created a PR that removes the culprit redux-persist over at https://github.com/opencast/opencast-admin-interface/pull/270

Thanks a lot, solved the issue.


CleanupDuplicateBindings blocks rancher startup

Rancher 2.5.8
The call to https://github.com/rancher/rancher/blob/master/pkg/multiclustermanager/app.go#L217 needs to be done in a goroutine. In a setup that has thousands of duplicates this is a blocking call and stops rancher startup from completing until the cleanup is done.
gz#16062

On rancher HA version v2.4.15
@prachidamle can you let me know how to reproduce the issue. I've tried the following scenario:

Create 4 standard users
Create 5 clusters on the rancher version mentioned. Once the clusters are active, restart the rancher pods multiple times.
From the duplicate detection script found the number of duplicates created were 1114

I couldn't find the logs mentioned in the issue from kubectl logs after I upgrade to the latest master-d7528a261111d2ea2129a8b1547fd22974fbc67c-head
Some logs in the rancher pods and seeing some errors.

2021/06/01 01:44:32 [INFO] Starting rbac.authorization.k8s.io/v1, Kind=RoleBinding controller
2021/06/01 01:44:32 [INFO] Starting cluster.cattle.io/v3, Kind=ClusterUserAttribute controller
2021/06/01 01:44:32 [INFO] Starting apps/v1, Kind=StatefulSet controller
2021/06/01 01:44:32 [INFO] Starting /v1, Kind=Event controller
2021/06/01 01:44:32 [INFO] Starting /v1, Kind=Endpoints controller
2021/06/01 01:44:32 [INFO] Starting extensions/v1beta1, Kind=Ingress controller
2021/06/01 01:44:32 [INFO] Starting rbac.authorization.k8s.io/v1, Kind=ClusterRoleBinding controller
2021/06/01 01:44:32 [INFO] Starting /v1, Kind=Node controller
2021/06/01 01:44:32 [INFO] Starting batch/v1beta1, Kind=CronJob controller
2021/06/01 01:44:32 [INFO] Starting /v1, Kind=ReplicationController controller
2021/06/01 01:44:32 [INFO] Starting batch/v1, Kind=Job controller
2021/06/01 01:44:32 [INFO] Starting rbac.authorization.k8s.io/v1, Kind=ClusterRole controller
2021/06/01 01:44:32 [INFO] Starting /v1, Kind=ServiceAccount controller
2021/06/01 01:44:32 [INFO] Starting /v1, Kind=Secret controller
2021/06/01 01:44:33 [ERROR] error syncing 'p-gnkpl/cluster-istio': handler istio-app-handler: waiting for the app cluster-istio to be installed, requeuing
2021/06/01 01:44:33 [INFO] deploy istio metric expression into CLuster c-2qf5s successfully
2021/06/01 01:44:33 [INFO] deploy istio metric expression into CLuster c-2qf5s successfully
2021/06/01 01:44:34 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:35 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:36 [ERROR] error syncing 'p-gnkpl/cluster-istio': handler istio-app-handler: waiting for the app cluster-istio to be installed, requeuing
2021/06/01 01:44:38 [INFO] Adding peer wss://<IP_ADDRESS>/v3/connect, <IP_ADDRESS>
2021/06/01 01:44:40 [INFO] Handling backend connection request [<IP_ADDRESS>]
2021/06/01 01:44:41 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:43 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:44 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:45 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:45 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:45 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:46 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:46 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:46 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:47 [ERROR] VerifySHA256Hash failed with error: hash format invalid
2021/06/01 01:44:47 [ERROR] VerifySHA256Hash failed with error: hash format invalid
E0601 01:45:02.679844       8 gvks.go:69] failed to sync schemas: unable to retrieve the complete list of server APIs: rke-machine.cattle.io/v1: the server could not find the requested resource
2021/06/01 01:45:06 [ERROR] error syncing 'p-gnkpl/cluster-istio': handler istio-app-handler: waiting for the app cluster-istio to be installed, requeuing
2021/06/01 01:45:08 [INFO] Creating clusterRoleBinding User u-ksuqkzfibv Role cluster-owner
2021/06/01 01:45:09 [INFO] Creating clusterRoleBinding User u-r2lgfy4kj3 Role cluster-owner
2021/06/01 01:45:11 [INFO] Creating clusterRoleBinding User u-vtoi2sddxm Role cluster-owner
2021/06/01 01:45:11 [INFO] Creating clusterRoleBinding User u-mo773yttt4 Role cluster-owner
2021/06/01 01:45:11 [INFO] Creating clusterRoleBinding User u-mo773yttt4 Role cluster-owner
2021/06/01 01:45:11 [INFO] Creating clusterRoleBinding User u-7kyp7mxmuo Role cluster-owner

Validated as part of 2.5.9. Since it was just moving a routine to a go routine. Validated that the code was updated in master.


Multiple short codes not rendering properly

Steps to Reproduce

View https://ocw-draft-qa.global.ssl.fastly.net/courses/5-111sc-principles-of-chemical-science-fall-2014/pages/unit-i-the-atom/lecture-1/ built from the source at https://github.mit.edu/ocw-content-rc/5.111sc-fall-2014/blob/main/content/pages/unit-i-the-atom/lecture-1.md

Expected Behavior

no visible shortcodes. Many (all?) of these should be transformed into <a> tags.

Screenshot or Screencast

Not sure what was going on here, but it appears to have been corrected.


fix: fix push filter through outer join in ReorderJoinRule.

Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.05 seconds
load time: 521 seconds
storage size:<PHONE_NUMBER>9 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221209055148_clickbench_pr_60709.html


Automated cherry pick of #2838: fix: fail to delete orphane VM in esxi https://kb.vmware.com/s/article/1003742

Cherry pick of #2838 on release/2.12.
#2838: fix: fail to delete orphane VM in esxi https://kb.vmware.com/s/article/1003742

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@e77f2cf). Click here to learn what that means.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             release/2.12   #2841   +/-   ##
==============================================
  Coverage                ?   7.18%
==============================================
  Files                   ?     474
  Lines                   ?   75007
  Branches                ?       0
==============================================
  Hits                    ?    5388
  Misses                  ?   69167
  Partials                ?     452

Flag
Coverage Δ

#aFlag
7.18% <0%> (?)

Impacted Files
Coverage Δ

pkg/multicloud/esxi/storage.go
0% <0%> (ø)

pkg/multicloud/esxi/virtualmachine.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77f2cf...9eeba52. Read the comment docs.

/approve
/lgtm


Story Mode and Free Play not working

Describe your bug here.
Hello, I use Psych Engine Windows 64 or 0.2.5h but when I added the mario 85 mod, the story mode and free play would glitch and exit me out of the application. Is there anything I added that might have caused this. Like a bad script?
P.S: I do not use source code.
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Only in mods

Please fix I make a lot of FNF covers on psych engine.

If the error (which you didn't describe or show) started after you added a mod then that's an issue with the mod, likely with a week file

https://user-images.githubusercontent.com/107650676/174196894-b614f35c-ba86-43b5-8f6f-876d576fb779.mp4
This is what I mean.

That doesn't really tell me anything

sorry my recorder is terrible


Make squash-merge the only option to merge PRs

Description
Make squash-merge the default option or even the only option to merge PRs.
Reasons
To keep the main branch tidy.
Attachments

kyma-project/test-infra#7469


Improve to_display_text for errors

Issues like https://github.com/enso-org/enso/issues/10750 are horrible to debug with a plain error atom name, e.g. No_Such_Method.

Reviewed the No_Such_Method type. It has the to_display_text properly set up.
I'm guessing it is an issue in engine/runtime/src/main/java/org/enso/interpreter/runtime/error/PanicException.java as to why the Java Exception is not showing the display text.
It looks like computeMessage will attempt to call the to_display_text via the InteropLibrary and fall back to the type name if it doesn't exist.

How exactly do we plan to tackle this issue?

it is an issue in engine/runtime/src/main/java/org/enso/interpreter/runtime/error/PanicException.java as to why the Java Exception is not showing the display text.
computeMessage will attempt to call the to_display_text via the InteropLibrary and fall back to the type name if it doesn't exist.

Are we supposed to dump more info when such a situation happens?


REST Version

Hi,
I'm seeking for this kind of boilerplate with REST API ready. Is there any?
Thank you

Not that I know of. The closest thing is a project generated by http://megaboilerplate.com/ when you choose React or Angular framework.

@asifsaho To be honest, most of this boilerplate wouldn't really apply in such a scenario. You'd be just as productive building from scratch and just incrementally adding what you need to build your REST API. Personally, I highly recommend FeathersJS for building a backend API; REST or Websockets - having an easy to use realtime backend for your SPA is quite awesome. :)

Closing as non-issue.


Fix operator endpoint

Correct me if I'm wrong but shouldn't it be http to match deployment manifest?
https://github.com/coreos/prometheus-operator/blob/master/helm/prometheus-operator/templates/deployment.yaml#L32

lgtm


Updating browser tests to better handle the warning toast

Description
In trying to migrating the staging to deployment to seattle-uat/civiform-deploy I kept getting timeout failures of browser tests. The warning message toast may or may not exist in the DOM. When code tries to click the [x] to dismiss the toast and it isn't there the click timeout default is 30 seconds.
There are two options to address the clicking of element
Option 1: Add a timeout to the click event
await page.click('#warning-message-dismiss', { timeout: 500 })

Option 2: Use a selector to find the element, and call the click method if the element was found
var element = await page.$('#warning-message-dismiss')

if (element !== null){
  await element.click()
}

I've tried both options and they work locally and against staging. I'm liking Option 2 better since it doesn't rely on hard coding a timeout value.
The changes in the admin_predicates.test.ts is an example of what I'm proposing I go do to all the test files.

which tests are the issue? i guess i'm fine with ignoring the toast if the goal of the tests is for something else and if we have something that confirms the toast works and is dismissible

It's a good number of files, most appear to be around admin pages. I can go through the log and pull out the full list. Because the fixed warning "Do not enter actual or personal data in this demo site" is in the way it needs to be dismissed in order to click on some links.
I'm thinking to have the tests automatically go and dismiss that toast right after the initial start of each test to get it out of the way. I've seen some tests perform an action and save and check for a success toast as part of their asserts, I'll have to check to see if there is a test specific to toasts.


React-MD UI toolkit doesn't work with Next.js

I am trying to use different UI toolkits and so far I haven't succeeded with any. Material-UI issue is already reported as #119, but React-MD raises another error, so I thought it should be reported separately.
Here is the pages/index.js:
import React from 'react'
import Head from 'next/head'
import { RaisedButton } from 'react-md/lib/Buttons'

export default class App extends React.Component {
  handleClick() {
    console.log("clicked!")
  }
  render() {
    return

        <link rel="stylesheet" href="https://npmcdn.com/react-md/dist/react-md.css" />
        <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500" />
        <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Material+Icons" />

        <RaisedButton label="Hello, World!" onClick={this.handleClick} />

  }
}

Here are the npm dependencies:
$ npm install --save next react-md react-addons-transition-group react-addons-pure-render-mixin react-addons-css-transition-group

On page load I see the following warnings:
Warning: getDefaultProps is only used on classic React.createClass definitions. Use a static property named `defaultProps` instead.
Warning: getInitialState was defined on ReactTransitionGroup, a plain JavaScript class. This is only supported for classes created using React.createClass. Did you mean to define a state property instead?

The first warning points to this line: https://github.com/mlaursen/react-md/blob/bec6b087eb0a6af38f0a0613d25d8a17f6c7b0a6/src/js/Inks/injectInk.js#L243. However, I couldn't locate the real source of the second warning.
And here is what I get on a button click:
Uncaught Error: addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's `render` method, or you have multiple copies of React loaded
Uncaught TypeError: Cannot read property 'componentWillLeave' of undefined

The line of code where the error occurs is inside React: https://github.com/facebook/react/blob/c78464f8ea9a5b00ec80252d20a71a1482210e57/src/addons/transitions/ReactTransitionGroup.js#L194
I do get clicked! logged, but the "bubble" animation doesn't work.
It seems that something magical happens and it feels like there are two Reacts are loaded somehow, so the ref keys are not registered.

I am closing this in favor of a more specific #204 bug report.


astUtils.addComponentToModule is not a function

Please provide us with the following information:

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)
El Capitan

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.11-webpack.8
node: 5.11.0
os: darwin x64

Angular Version 2.0.0

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.
ng g component my-component

The log given by the failure. Normally this include a stack trace and some
more information.

astUtils.addComponentToModule is not a function
TypeError: astUtils.addComponentToModule is not a function
    at Class.module.exports.files.fileList.afterInstall.options [as afterInstall] (/Projects/WebApp/node_modules/angular-cli/addon/ng2/blueprints/component/index.js:125:18)
    at tryCatch (/Projects/WebApp/node_modules/rsvp/dist/lib/rsvp/-internal.js:215:12)
    at invokeCallback (/Projects/WebApp/node_modules/rsvp/dist/lib/rsvp/-internal.js:230:13)
    at publish (/Projects/WebApp/node_modules/rsvp/dist/lib/rsvp/-internal.js:198:7)
    at flush (/Projects/WebApp/node_modules/rsvp/dist/lib/rsvp/asap.js:82:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Mention any other details that might be useful.
Component is created but it is not added in app.module.s file.

Fixed in beta.14+.

This also fixed the same error that was occurring in Fedora 24


Support ESP32S3 on Arduino

Is your feature request related to a problem? Please describe.
@marchingband attempted to compile usb_midi_host_example.ino
and got the error Compilation error: #error "Please Select USB Stack: Adafruit TinyUSB Host"
Describe the solution you'd like
The example should also work with the Espressif ESP32S3 Dev Module + MAX3421E host shield. The other TinyUSB dual role examples work.
Describe alternatives you've considered
See discussion here
Additional context
See discussion here

Just want to be clear that I am not using any shield, or additional parts, the ESP32S3 supports usb host natively.

@marchingband According to the TinyUSB website, TinyUSB does not support USB Host natively for the ESP32S3. I looked at the repository for the espressif branch of tinyusb and under tinyusb/src/portable/espressif/esp32sx and found a dcd_esp32sx.c for USB device but no corresponding hcd_esp32sx.c for the host side. The esp-idf repo has a host controller interface, but my project is an extension of TinyUSB, not the esp-idf. This driver relies on TinyUSB support for host bulk and control endpoints and implements the MIDI spec on top of it. I can probably make this driver work with the MAX3421E host shield.
Unless you or someone else adds TinyUSB support for ESP32 host hardware, this driver is not the path to Arduino support for native USB host MIDI on ESP32. Should I close this issue?

Hmm, ok yah, that was my instinct, and now I think about it, that's why I opened it in the Adafruit repo initially.
I don't know a lot about tinyUSB, but I am certain it is tinyUSB (a port of it) that runs in esp-idf.
Like I said earlier, I have a working USB MIDI Host code, running right now on my esp32s3, under esp-idf.
It is not very complex, and if it's helpful, I can certainly share it with you.
I opened a feature request with esp-idf last year, and they added MIDI USB Host to their driver.

here is their port
https://github.com/espressif/tinyusb

Sorry to hear that, thanks for looking into it!

Would it be worth asking at tinyUSB to add host support? I know so little about usb I'm unclear if that's a reasonable request or not.

@marchingband Up to you. I will leave this issue open here. If others want me to support the MAX3421E host shield in this driver,
I will get to it. If no one responds in a few months, I will close it due to lack of interest.
BTW, I do understand that the ESP32 is a popular ecosystem, and I see the potential benefits of it for MIDI. Nevertheless, my attraction to the RP2040 and the Pico board in particular is you can implement a USB MIDI host and a USB MIDI device at the same time with only two added resistors and a USB connector on a 4 US dollar board. For 2 dollars more, you can buy a Pico W board that adds WiFi and Bluetooth support. There are enough other I/O pins to implement UARTs for UART MIDI too.

I certainly see the power of rp2040, although I havnt yet tried it. ESP32S3 makes a great audio target because of i2s and eMMC/SD peripherals, and the 8MB octal PSRAM available at $5, the newer P4 (out soon) has a 400mhz clock and will be even better at audio.
I am not sure if you've seen this repo, and I'm not sure if it uses tinyUSB, but I believe it works for S3 under Arduino https://github.com/touchgadget/esp32-usb-host-demos/blob/main/examples/usbhmidi/usbhmidi.ino
Maybe it helps.
In case you are curious here is my project, I am working on v2 currently.
https://www.sparkfun.com/products/21307

https://github.com/hathach/tinyusb/issues/2634

I certainly see the power of rp2040, although I havnt yet tried it. ESP32S3 makes a great audio target because of i2s and eMMC/SD peripherals, and the 8MB octal PSRAM available at $5, the newer P4 (out soon) has a 400mhz clock and will be even better at audio.
I am not sure if you've seen this repo, and I'm not sure if it uses tinyUSB, but I believe it works for S3 under Arduino https://github.com/touchgadget/esp32-usb-host-demos/blob/main/examples/usbhmidi/usbhmidi.ino
Maybe it helps.
In case you are curious here is my project, I am working on v2 currently.
https://www.sparkfun.com/products/21307

I tried that usbhmidi.ino and it didn't seem to do anything. I flashed that on an S3 dev kit clone (with "verbose" on) and it didn't show up in DAW and didn't print anything to the serial monitor in Arduino IDE either. The TX light on the board came on and stayed on, but that was seemingly all it did.
How to make that function?

@01GOD GitHub is not a good place for beginners to look for help. Please try the Arduino forum, or Reddit, or similar. This just spams the library maintainers who are very busy.

@marchingband In general, that is good advice. In my projects, I like to try to help beginners and people who may be advanced
coders but just have trouble describing the problem. Sometimes, they stumble across bugs in documentation or code that more
advanced users cannot be bothered to report.
@01GOD Please give me details on your hardware. If you are trying to get this project to work on ESP32S3, please look at this whole issue text. Right now, TinyUSB does not support the ESP32 USB host mode directly. This driver relies on TinyUSB for
hardware-level support, so I would expect nothing to work in this case.
If you are using a MAX3421E USB Host shield with your ESP32S3 board, then this is a good issue to report but it is not this bug.  Please open a new issue and carefully describe your issue using the bug template.
If your hardware is something else, please open a new issue and carefully describe your issue using the bug template.

@marchingband In general, that is good advice. In my projects, I like to try to help beginners and people who may be advanced coders but just have trouble describing the problem. Sometimes, they stumble across bugs in documentation or code that more advanced users cannot be bothered to report.
@01GOD Please give me details on your hardware. If you are trying to get this project to work on ESP32S3, please look at this whole issue text. Right now, TinyUSB does not support the ESP32 USB host mode directly. This driver relies on TinyUSB for hardware-level support, so I would expect nothing to work in this case.
If you are using a MAX3421E USB Host shield with your ESP32S3 board, then this is a good issue to report but it is not this bug. Please open a new issue and carefully describe your issue using the bug template.
If your hardware is something else, please open a new issue and carefully describe your issue using the bug template.

Thanks for the considerate reply. Yesterday I tried it on a known good commercial ESP32-S3 dev kit clone board (not the S3 PCB that I designed and mentioned earlier).
Yesterday I tried this Arduino IDE compatible code for USB MIDI from ESP32 to a laptop DAW (macOS), and it DOES function (although TinyUSB mode has to be enabled in Tools menu):
https://github.com/esp32beans/ESP32USBMIDI/blob/main/examples/ESP32USBMIDI/ESP32USBMIDI.ino
Today I plan to hopefully make that do bi-directional MIDI (somehow adapt it to receive MIDI from a laptop DAW on ESP32-S3).
Guidance (and code example(s) that are known to definitely function on S3) on how to accomplish MIDI from a laptop DAW to an S3 are certainly welcome.
I assume this repo is primarily for plugging a USB MIDI controller into an MCU board and thanks for posting it and maintaining it! I met eben at the maker faire in Shenzhen (I'm not chinese, mainly prototyping there) about 7 calendar months or so ago and I am open to adding an rp2040, but I am really trying to minimize PCB (and code) complexity by using an ESP32 for all of the functionality of a cap touchscreen synth. If eben is a friend, say "Hi" for Me.

@01GOD Your response to @marchingband was unacceptable in any working technical forum. @marchingband did not insult you; your question talked about connecting a USB Host to a DAW, so assuming you are a beginner was not totally unfounded. Remember, just because you are an expert in one software area does not mean you are not a beginner in other areas. @marchingband's response was, in general, helpful to a beginner. If you post like that to any of my projects again, I will ban you.
The TinyUSB example you tried is for USB Device mode. TinyUSB supports ESP32 in USB device mode. If you need help with USB device mode MIDI on ESP32, then this is not the project for you. Please seek help in a project with a more relevant example.
If you need a MIDI USB Host mode driver on ESP32, I will repeat what I said earlier in this issue.
TinyUSB does not provide the low level host controller driver support to run the ESP32's native USB hardware in USB Host mode. This project relies on TinyUSB's host-controller driver.
If you are adding MAX3421E hardware to support USB host, TinyUSB claims to support that. I have never tried it. If you try it and it does not work, please file a new issue.
And do not post again to this issue. I am closing it.


Fix checkstyle issues for Form Recognizer

Ref https://github.com/Azure/azure-sdk-for-java/issues/36588

API change check
API changes are not detected in this pull request.


Merge Sort implementation in Python

🚀 Feature
( Merge Sort is a Divide and Conquer algorithm. It divides the input array into two halves, calls itself for the two halves, and then merges the two sorted halves.)
Have you read the Contributing Guidelines on Pull Requests?
(I want to contribute to the implementation of Merge Sort  in Python.)
Motivation
(I am new to the Data Structure and Algorithm world. I am implementing all the Data Structure and Algorithm in Python these days.)
Pitch
(Going through the codebase of NeoAlgo I found that there was no implementation for Merge Sort  in Python section.)

@msbuddhu Assigned. All the best 👍

@siddharth25pandey I have created a PR for issue #2248. Please have a look.

@msbuddhu Plagiarized PR


[Annotation] Add a div containing the text of a FreeText annotation (bug 1780375)

An annotation doesn't have to be in the text flow, hence it's likely a bad idea
to insert its text in the text layer. But the text must be visible from a screen
reader point of view so it must somewhere in the DOM.
So with this patch, the text from a FreeText annotation is extracted and added in
a div in its HTML counterpart, and with the patch #15237 the text should be visible
and positioned relatively to the text flow.

/botio test

My test is not ideal... There isn't enough transparency, I'll fix.

My test is not ideal... There isn't enough transparency, I'll fix.

In fact it isn't just a matter of taste but then rendering on the canvas was broken.
I had to add:
https://github.com/mozilla/pdf.js/pull/15267/files#diff-a7e409abd3d3209d32d3adc8457c5e23feb4c06113a2e065b0c6a9322a3a3369R984
in order to have a correct rendering.

In fact it isn't just a matter of taste but then rendering on the canvas was broken. I had to add: https://github.com/mozilla/pdf.js/pull/15267/files#diff-a7e409abd3d3209d32d3adc8457c5e23feb4c06113a2e065b0c6a9322a3a3369R984
in order to have a correct rendering.

Oh, that makes a lot of sense!

What happened to the test/test_manifest.json file?

/botio test

/botio test

/botio makeref


Solidity-Cheatsheet

What does this PR do?
CheatSheet to learn Solidity faster.
For resources
Description
PDF documented file
Why is this valuable (or not)?
It is a Complete Beginner Friendly Cheatsheet.
How do we know it's really free?
Its a pdf
For book lists, is it a book? For course lists, is it a course? etc.
It is a PDF.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Can u give me permission to merge my pull request??

Please read docs/CONTRIBUTING.md guidelines!

I have made the pull request
Now I think you have to merge the pull request.
On Sat, 15 Oct 2022, 07:39 Eric Hellman, @.***> wrote:

Closed #8351
https://github.com/EbookFoundation/free-programming-books/pull/8351.
—
Reply to this email directly, view it on GitHub
https://github.com/EbookFoundation/free-programming-books/pull/8351#event-7594272858,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWSKG3QNQGKZGZ6X74SEMO3WDIG5LANCNFSM6AAAAAARFRZDEA
.
You are receiving this because you authored the thread.Message ID:
<EbookFoundation/free-programming-books/pull/8351/issue_event/7594272858@
github.com>


403 forbidden if a user does not have access to a route

Looks good but I don't have merge rights @pcross616


⚠ Bofrost.be has degraded performance

In e268e0c, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 939 ms

Resolved: Bofrost.be performance has improved in c703a85 after 21 minutes.


Fixed Downsampling process; Fixed runutil.CloseAndCaptureErr

Fixes https://github.com/improbable-eng/thanos/issues/1065
Root cause:

runutil defered capture error function was not returning error properly so unit tests were passing, even though there was bug
streamed block write index cache requires index file which was not closed (saved) properly yet. Closers need to be closed to perform this.

PTAL @xjewer @shivas
@shivas included your PR https://github.com/improbable-eng/thanos/pull/1068/files here.
Signed-off-by: Bartek Plotka<EMAIL_ADDRESS>

Closers need to be closed to perform this.

right, missed this dependency 😞

@xjewer No worries, the main problem is our capture function for closers was not propagating error properly so our unit tests missed this. Now we should be able to catch those error early :+1:


Please update, to support the latest features of LVGL

I'm missing the dynamic font loading, so please update to micropython 1.13.

closed !

How did you load another fonts?
I got stuck at this.

Currently in progress

I have updated micropython and lvgl to the latest versions. You can see it in the 1.13 branch.


Support 500 throwing while others retry

I have not clue who I need to get permissions from, or if there's any tests or anything to verify how this works, but the purpose is simply that by passing in an option statusCodesToIgnore, that withRetry, we still can throw errors on the client side
Also fixes CI types

Not sure how to fix this right now:

Hi @ayroblu,
Thank you for the PR!
I think that there should be a way to tell which errors to retry, but I don't think that this should go with a statusCodesToIgnore property on the BackoffOptions type.  I would definitely support, however, the addition of a shouldRetry predicate as an attribute of Service.withRetry, and as a consequence on retryStream and RetryingStream.
The shouldRetry would be passed an Error object and synchronously returns a boolean (true: retry, false: fail immediately). The default behavior could look at the RpcErrorType (and not the http status, which is an implementation details of the grpc_web protocol) and retry in every situation but: 'invalidArgument', 'notFound', 'alreadyExists', 'permissionDenied', 'failedPrecondition', 'unimplemented', 'internal', 'unauthenticated'.
Notice that in development mode it can be useful to keep retrying even if there is an internal server error, that can shorten the dev cycle in some circumstances.

I also took a look at your proposals for fixing the CI (it broke following merging dependabot's PRs), wrote a PR out of it and merged it to master.

This has been closed in favor of https://github.com/aiden/rpc_ts/pull/25, following the reasoning above.


Upgrade Linux Kernel for flatcar-3510 from 5.15.108 to 5.15.111

Subject says it all.

We need to first release the next Stable with Kernel 5.15.108, https://github.com/flatcar/scripts/pull/729, not this one.
Added on-hold.

See instead https://github.com/flatcar/scripts/pull/826


fix DPO data collator

Fix problems described in this issue 907.
Testing code: https://github.com/nrailg/trl-dpo-alpaca-farm-demo
@kashif @lvwerra

Looks great, thanks! I left one suggestion that can be propagated across some lines below, what do you think? Also let's wait to hear from @kashif to see if this fix is the right fix

Upgraded.

@kashif Hello, I'll be regretful if you could spare some time and review this PR.

@nrailg thanks! having a look now... so would a user need to create the DPO type dataset differently due to this?

@nrailg thanks! having a look now... so would a user need to create the DPO type dataset differently due to this?

NO.

@nrailg  yes this looks great and brings the tokenization more in line with what is done so thank you! I am currently refactoring the DPO collator so i would potentially need to add these changes to that, if you want, I can add you as a collaborator if you want to add it there since I have made helper function for the tokenization, for which we can also add tests? what do you think?

@nrailg  are your tests passing?

@nrailg are your tests passing? i think for the gpt2 tokenizer i am using the tests will not pass for you

I ran the stackllama2 demo, and finished training my own demo.
I didn't find any test case related to DPO data collator by grep "DPODataCollator", so I didn't run make test.

@nrailg yes this looks great and brings the tokenization more in line with what is done so thank you! I am currently refactoring the DPO collator so i would potentially need to add these changes to that, if you want, I can add you as a collaborator if you want to add it there since I have made helper function for the tokenization, for which we can also add tests? what do you think? see #885

Glad to help. Give me sometime to figuring out what you changed.

I am still testing on my side, @nrailg, and I am getting an issue where in my eval dataset I get an error in the embedding layer... still trying to figure out why... can you kindly test on your side? we fixed some edge cases not covered by your original PR here too

I am still testing on my side, @nrailg, and I am getting an issue where in my eval dataset I get an error in the embedding layer... still trying to figure out why... can you kindly test on your side? we fixed some edge cases not covered by your original PR here too

we fixed some edge cases not covered by your original PR here too
Thank you so much. I'll try figuring out how to run make test in my company's weird gpu cluster.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


[API] Cluster Templates - Member is able to reduce Access Type of other users on a cluster template

Version: master-head (7/23/19)
What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create a cluster template, share it with another user, make them a member.
Share it with another member, make them an owner.
Log in as the member user, edit the cluster template.
Notice, we can successfully change permissions on the owner user. We can limit their access to just Read-Only or remove them if we want.
View in API - it indeed affected the clustertempalterevision.

Result:
Member can elevate access and change membership for any user including those with higher access.

@davidnuzik @deniseschannon @alena1108 I don't think this is a bug. If the user was given "member" access type, they have the "update" permission on the clusterTemplate resource. So they can update the Members list on the clusterTemplate resource too. Only "read-only" members won't be able to change the access type of other members.

@mrajashree After discussing, we have agreed that this is the permission logic for members:
Ability to update templates, but explicitly exclude the ability to update membership of the template as that would provide potential privilege escalation (able to assign yourself owner permissions).

After further discussion, we have decided that the "member" role in cluster templates doesn't make sense. We will be removing this role and keep the following 2 roles:

Owner - Able to CRUD templates/revisions and share CT to other people (Note: a CT owner will also need to have the global Create Cluster Template role in order for it to make sense, and only admins can assign this role.)
Read-Only - People who will be dedicated to use the cluster templates. For better UX, the UI will be updated to User for when assigning this role. https://github.com/rancher/rancher/issues/22200

Version: master-head (v2.3) (8/19/19)
I can confirm now that we only have two access types to chose from in the UI when we are sharing a cluster template:

I confirmed that the Owner member is able to create, read, update, delete the cluster template (assuming has the required Create Cluster Template global permission to create).
I confirmed that the User member is NOT able to create, update, or delete the cluster template (they can only read and leverage a cluster template to create a cluster).
I confirmed that if the User (Read-Only) member has the Create Cluster Template permission they still can't make changes to the CT that was shared with them as "User" Access Type. (They can only create their own cluster templates, as expected).


Fixes #261: Global lockout possibility in 2.3.3

See #261
Happens when AXES_ONLY_USER_FAILURES or LOCK_OUT_BY_COMBINATION_USER_AND_IP is set to True and someone reaches the lockout limit by passing an empty username in the login form.

Coverage increased (+0.2%) to 91.862% when pulling a872474a7c5910427eead1d1b7a82147943062e8 on maykinmedia:fix-global-lockout into 87731d180eba7c401c69e318c57c4dbb88d4d170 on jazzband:master.

Thank you. I had to write them because of the big changes recently made.


resolve Rhea mappings for 'methylamine dehydrogenase (amicyanin) activity' GO:0052876, 'amine dehydrogenase activity' GO:0030058

methylamine dehydrogenase (amicyanin) activity EquivalentTo EC:<IP_ADDRESS>	(most probable)	0.8
amine dehydrogenase activity EquivalentTo METACYC:AMINE-DEHYDROGENASE-RXN	(most probable)	0.8
H2O + methylamine + 2 oxidized [amicyanin] = formaldehyde + 2 H(+) + NH4(+) + 2 reduced [amicyanin] EquivalentTo EC:<IP_ADDRESS>	(most probable)	0.75
A + an aliphatic amine + H2O = AH2 + an aldehyde + NH4(+) EquivalentTo METACYC:AMINE-DEHYDROGENASE-RXN	(most probable)	0.75
H2O + methylamine + 2 oxidized [amicyanin] => formaldehyde + 2 H(+) + NH4(+) + 2 reduced [amicyanin] EquivalentTo METACYC:RXN-2841	(most probable)	0.75
amine dehydrogenase activity ProperSubClassOf EC:<IP_ADDRESS>		0.08
2 [Fe(III)cytochrome c550] + an aliphatic amine + H2O <=> 2 [Fe(II)cytochrome c550] + an aldehyde + 2 H(+) + NH4(+) ProperSubClassOf METACYC:AMINE-DEHYDROGENASE-RXN		0.1
amine dehydrogenase activity ProperSubClassOf H2O + methylamine + 2 oxidized [amicyanin] = formaldehyde + 2 H(+) + NH4(+) + 2 reduced [amicyanin]		0.08

@amorgat @kaxelsen
Is RHEA:30207 a more specific form of RHEA:51128?
Thanks, Pascale

I have made some updates to Rhea so now:
RHEA:30207 is a RHEA:51128
RHEA:21916 is a RHEA:51128
RHEA:21917 has a cross reference to MetaCyc AMINE-DEHYDROGENASE-RXN
RHEA:51128 does not have an x-ref to MetaCyc.

[x] Removed 'MetaCyc:AMINE-DEHYDROGENASE-RXN' as a xref to GO:0030058 amine dehydrogenase activity, since this describes a different reaction (RHEA:21919), despite its name
[x] Added RHEA:30207 to GO:0052876  methylamine dehydrogenase (amicyanin) activity
[x] Added RHEA:51128 to GO:0030058 amine dehydrogenase activity (more general activity)
[x] Removed EC:<IP_ADDRESS> from GO:0030058 amine dehydrogenase activity, as it describes a copper-dependent activity, and GO:0030058 does not.


be_delayed without expected_arguments never matches

From what I can see, this is due to how the jobs are found:
        def find_job(method, arguments, &block)
          job = (::Sidekiq::Extensions::DelayedClass.jobs + ::Sidekiq::Extensions::DelayedModel.jobs + ::Sidekiq::Extensions::DelayedMailer.jobs).find do |job|
            yaml = YAML.load(job['args'].first)
            @expected_method_receiver == yaml[0] && @expected_method.name == yaml[1] && (@expected_arguments <=> yaml[2]) == 0
          end

          yield job if block && job
        end

If no expected arguments are given, (@expected_arguments <=> yaml[2]) == 0 will always be false (for jobs that have been enqueued with arguments).
(Also, I'm not sure why there is a spaceship operator here instead of a simple ==, and why method and arguments are passed to find_job but never used, but that's another topic).
In short, this comparison should be performed only if expected_arguments are given.
That is, if you want this to be coherent with the rest of rspec. Otherwise, you can dismiss this issue :shrug:

To complete this issue, the most problematic / counter-intuitive seems :
# foo.rb
class Foo
  def call
    self.delay_for(1.minute).bar("hello")
  end

  def self.bar(arg)
     puts arg
  end
end

# foo_spec.rb
describe Foo do
  it "should not delay :bar" do
     expect(Foo.method :bar).to_not be_delayed
     Foo.new.call  # this will pass
  end
end

This is pretty misleading. I see two possible fix for that :

Make be_delayed ignore the arguments check if no argument is passed to it (it will match the related job whatever the arguments). But I am not sure of the potential impacts.
Allow at least to do something like be_delayed(any_args) using the capabilities of rspec-mock.

@packrat386 @coding-bunny what do you think ?

Yeah, this feels misleading to me, as based on the code snippet, the test is supposed to fail since we are delaying for 1 minute.
The initial idea to only perform the argument check if arguments are actually passed feels good to me.
Just not 100% sure if it is true in all cases, but I suppose testing/usage will reveal that.

Hi @coding-bunny, I've submitted a PR to fix this issue. I've went with ignoring the argument check if non are passed as the solution.

cc @philostler @packrat386


chore(package): update kronos-service to version 4.7.0

Coverage remained the same at 92.308% when pulling 9396c76e038fe6c40514f055d74e7c1a358a4c72 on greenkeeper/kronos-service-4.7.0 into 58c207ddf3bc3e20fd364f6efb2b425dc9ab4a65 on master.


bitsync fail on backup

since yesterday, bitsync fails to backup my local folders. I get the following error
Saving current state and backing up files (if needed)
| Root dir: /home/yotam/Sync
sh: 5: Syntax error: "fi" unexpected (expecting "then")
fatal: command failed BACKUP

The message first appeared when I was working on my server machine, but I was working the previous day as well and there weren't any issues then.

Sorry it's not working. Can you share some version information about your bitpocket? Perhaps git rev-parse HEAD? Or maybe when you downloaded it?

Hi. Thank you for the reply. Here is the HEAD you asked for:
 git rev-parse HEAD
<PHONE_NUMBER>dc932524eb240f6e856fd69e7f6a0f

In the meantime, how can reactivate the sync?

@yotama9 I think you should download and replace the original script. Looks like it was likely corrupted.
https://github.com/sickill/bitpocket/raw/7854553182dc932524eb240f6e856fd69e7f6a0f/bin/bitpocket

I updated the git repository of bitpocket and things work now.Thanks.


Geometry not visible on imported FBX files, both 3.3 and 4.0

Godot version:
3.3 and 4.0 (updated from a week ago)
OS/device including version:
Linux Mint, RX 5500 XT with open source drivers.
Issue description:
If I export a model from Blender (tried both 2.82 and 2.90) only the armature is visible, the geometry is there (a meshInstance) but it is not visible.
Steps to reproduce:
geometrybug.zip
Minimal reproduction project:
Any project will do, just export the attached blend file.

cc @RevoluPowered

This is probably fixed with the new FBX importer using FBX2glTF.
You can test it in Godot 4.0 alpha 6: https://godotengine.org/article/dev-snapshot-godot-4-0-alpha-6
This new importer might also be backported for the 3.x branch eventually.
If you still find issues with these models using the new importer, we suggest opening a new issue with details about the problems in Godot 4.0 alpha 6 or later.


Add Nova snippets extension to resources and tools page

I've created some Nunjucks macro snippets (aka "clips") for Nova code editor. @querkmachine raised an issue on my repo suggesting I submit here to be added to the resources and tools page.
The snippets are published to the Nova extension library: https://extensions.panic.com/extensions/ca/ca.GOVUKDesignSystemSnippets/
The code is published to a GitHub repo: https://github.com/chrisadesign/GOV.UK-Design-System-Nova-snippets

Hey Chris,
Thanks for submitting your extension. Someone from the team will review soon(ish!) it to make sure it meets our contribution criteria.

Hi @chrisadesign,
Sorry it's taken a while to get back to you on this. It ended up falling between the cushions of the proverbial couch.
We'll be happy to add this to our list of community resources with some additions to documentation. Specifically:

The GitHub readme should include installation instructions for the extension. In this case, a link to the Nova extensions library page will probably suffice.
Please include which version of GOV.UK Frontend the extension is updated for. This makes it easier for end users to see if and when the extension has been updated for new releases of Frontend, so they know they're receiving the right snippets for the version they're using.

On a more general note, I noticed that the extension includes various snippets that are specific to code in the GOV.UK Prototype Kit, such as Express routing JavaScript and the Task List pattern.
These are not strictly part of the Design System, and I'm concerned it could be confusing to some users if they try to use these outside of the Prototype Kit. It might be helpful to rename these snippets to make this distinction clearer? "GOV.UK Route" might be renamed "GOV.UK Prototype Kit Route", for example.
Also note that as of version 13 of the Prototype Kit, the Task List pattern is no longer bundled with the Kit and must be installed as a separate plugin. I don't know if this warrants changing its inclusion in the extension.
We'll get this listed as soon as those changes have been made. Thank you for contributing to the ecosystem! 😊

Hey @querkmachine, thanks for getting back to me.
Updates:

added installation instructions and Frontend version to README
appended the routes snippets with "(Prototyping)"
added new Summary Card

I've left the Task List as is for now, if that's alright, I'll update when the component is added to the Design System.

@chrisadesign Thanks for making those updates!
Regarding the task list, I think that's your prerogative. It's currently a separate thing to both GOV.UK Frontend an the Prototype Kit, needing to be installed separately by anyone wanting to use it, and that might need messaging to a user somehow. If or how you do that is up to you, though!
The task list's code is now hosted here: https://github.com/alphagov/govuk-prototype-kit-task-list
And is released through npm here: https://www.npmjs.com/package/@govuk-prototype-kit/task-list

Screw it, I've taken it out


Adding aria-label to Dismiss button

Adding aria-label to the dismiss button to support accessibility.

Would love to see this simple change merged in for screen readers.

Would love to see this simple change merged in for screen readers.

I think there are a lot of pull requests we should care about it too, like my pull request 😅


Adding GitLens

Would you be open to me adding GitLens to the list of plugins? I find it very useful.

Thank you for your request.
I really like this extension and I'm using it for a long time now, but I want to focus this extension pack on directly with Rust related extensions.
I just want to cover:

writing
testing
debugging

and I don't want to bloat it up with other (useful) extensions which don't fit here.
GitLens is more of a productivity extension and not needed to develop and maintain Rust applications.


Set geometry type for vector layers

In order to validate that a layer is able to perform population exposure analysis, a geometry type  needs to be included within its configuration options. Also, there needs to be a check in order to remove vector layers for common analysis.

I believe you're working on something similar here @DanielJDufour ?

closed via https://github.com/WFP-VAM/prism-frontend/pull/192


Quaternion input does not accept vector equation as second argument

When trying to input a quaternion into the command line, the following unexpected output is produced:
vecmath>r = [1, (1, 1, 1) * 5]
r = [5.000000 ,(5.000000 , 5.000000 , 5.000000 )]

The expected output would instead be just multiplying the imaginary part by 5 (as the input to the imaginary part is (1, 1, 1) * 5), instead of the entire quaternion.

This is indeed not as it should, thanks for submitting this bug.