Function ops

Generates ops that take functions as parameters.

@rnett any way you can split that in multiple smaller PRs?

Yikes, I'm not sure why it changed all the op classes.

Ok @karllessard, the big change is in #328, I haven't applied it.  If you merge that PR I'll do another one with the generation, and then this one will be smaller after rebasing.

Also @JimClarke5 this is what I was talking about wrt the runtime initialization checks, you should be able to use ifOp for that without too much trouble.  Although I'm not sure it's a great idea, and I'm working on the init scope PR (and variables soonish after that).

@rnett can you please rebase this PR now that we are on TF2.5? I guess new ops might also be added?

I'm going to wait until #328 if you think you can merge it quickly, since this one needs to be rebased on top of it anyways.

Ok, it's rebased.  The number of files is smaller, but still pretty big since the generation is in there.  I can try to make it smaller if you want, but if you need to check for groups it might be required anyways.

The number of files if fine, since most of the are generated (so I don't need to spend time reviewing them). Some ops needs to be reclassified into the right package though (like ReduceDataset).

@googlebot I consent.


Enable test_serialization

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 37.46%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
1758

Relevant Lines:
4693

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 37.46%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
1758

Relevant Lines:
4693

💛  - Coveralls


Problems with Dark mode

dark mode doesn't work! only darkens my texts. see attached image

WhatsDesktop 1.8.0
win32 x64 10.0.17763

Have the same issue on ubuntu 18.04


Fixing 'flag' attribute, take 2

Fixes #2241

@aphelionz +1, but I see this PR is against develop. I believe @mjstealey asks you to create the PR against the master so that he can directly pull the change to www production for applying the hotfix, so you may have to close this PR and create another one against master? @mjstealey may weigh in on this.

@hyi fixed

@all - looks like resources can be made public again.
Example: https://www.hydroshare.org/resource/fa27117fdf8a462ca320e618dea9a576/


Fix code coverage

Fixes #20

[Current coverage][cc-pull] is 93.32%

No coverage report found for develop at 5f85a4c.

Powered by Codecov. Last updated by [5f85a4c...3f45e5b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/arcam/CocoaUPnP/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/arcam/CocoaUPnP/compare/5f85a4c6bc6de8d9e096cb10d0302bb1dacca389...3f45e5bf6776e587a37da9c5fff5b7317e1ffdee?src=pr
[cc-pull]: https://codecov.io/gh/arcam/CocoaUPnP/pull/32?src=pr


multiple workspace folders with multiple settings.json: opening terminal uses "wrong" or single ${workspaceFolder}

VSCode Version:
OS Version:

Version: 1.49.2
Commit: e5e9e69aed6e1984f7499b7af85b3d05f9a6883a
Date: 2020-09-24T16:26:09.944Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.4.0-48-generic snap
Steps to Reproduce:
General structure:
in folder home/user/lib_b/.vscode/settings.json
{
"terminal.integrated.env.linux" : {
"LIB_A_BASE" :   "/home/user/lib_a/",
"LIB_B_BASE" : "${workspaceFolder}"
}
in folder home/user/lib_b/some/sub/folders/app/.vscode/settings.json
{
"terminal.integrated.env.linux" : {
"LIB_A_BASE" :   "~/other/version/of/lib_a/",
"LIB_B_BASE" : "${workspaceFolder}/../../../../"
}
}
The folder lib_b and lib_b/some/sub/folders/app are both added to the workspace

Open "Terminal/New Terminal
In dialog I get a selection of "lib_b" and "app" to open the terminal
Select lib_b
echo $LIB_B_BASE in the terminal
expected: /home/user/lib_b
effective: /home/user/lib_b/some/folders/app

It seems to me as if the "home/user/lib_b/.vscode/settings.json" is being used (which I consider correct), but the ${workspaceFolder} is pointing to "home/user/lib_b/some/sub/folders/app"
If I open the terminal at "lib_b" should the ${workspaceFolder} not be set to that path?
I guess the lib_a  and LIB_A_BASE is completely irrelevant and could be omitted to reproduce.
But it is how the two settings.json look like.

Does this issue occur when all extensions are disabled?: Yes/No
Not tested
Regards
Roman

You might be hitting a security feature to not allow the use of workspace terminal settings without opting in, try run this command and allow and see if that fixes your issue:


Weird issue with Timer::after_secs(99999999999999999).await;

I'm awaiting on the main task but a secondary task is getting blocked (or some error happened) with:
Timer::after_secs(99999999999999999).await;

With a smaller number it works okay:
Timer::after_secs(u32::MAX as u64).await;

Firstly discussed here
Updated
Board: Raspberry Pi Pico W
Debug: Usb

For reference:
>>> hex(99999999999999999)
'0x16345785d89ffff'

Which is:
0x0163_4578_5d89_ffff
and as Duration has a max tick range of u64:
>>> (2 ** 64) /<PHONE_NUMBER>9999999
184.46744073709553

So converting from seconds to ticks, we are almost certainly overflowing the tick count (embassy-rp defaults to 1MHz, iirc):
>>> hex((99999999999999999 * 1000000) & ((2 ** 64) - 1))
'0x2c7_e14a_f670_bdc0'

I'm not sure what the cause of the lock up is though.

I tried to get an error message with this, but nothing happens, it just hangs:
#[panic_handler]
fn on_panic(info: &PanicInfo) -> ! {
    log::error!("Panic: {}", info);
    loop {}
}

Debug: Usb

the USB logger won't log panic messages, because panics crash the firmware and usb stops working if the firmware stops running. To get panic messages you need to use a debug probe.

Panic message is
ERROR - panicked at /home/dirbaio/embassy/embassy/embassy-time/src/duration.rs:47:27:
attempt to multiply with overflow

This is working as intended. Duration is a u64 number of ticks, conversion from seconds can overflow.
Note if you want to sleep forever you can do core::future::pending::<()>().await.
Also note it's fine to let main return, other tasks continue running.

@Dirbaio Thanks


Extending existing model with additional words

I trained a model using some big datasets.
The quality of recognition is very good, but unfortunately it still not recognizes some words.
I know that these words are not present in transcripts of audio data.
Is there a way to add additonal words manually ?
Can I simply put additional words to transcript_words.txt when building model ?
Or better, is it possible to reuse the existing model without rebuilding and use only hotwords ?
Or maybe there are other solutions not mentioned here ?

@ChrystianKacki  You can try hotwords (search context_file or context_score in https://github.com/k2-fsa/icefall/blob/master/egs/librispeech/ASR/pruned_transducer_stateless4/decode.py for the usage).


Review dataset hosting standards

for possibly making some datasets public different ways

https://duraspace.org/dspace/
https://ckan.org/
https://www.kaggle.com/docs/datasets

moved to #23


Fix error warning logged because we are storing handleClose and handleConfirm function in redux for modalSlice

Temporary patch in place, plase remove once this is addressed:
store.ts
middleware: (getDefaultMiddleware) => getDefaultMiddleware({ serializableCheck: false }),


request help: How to upgrade

Issue description
Before upgrade  env：
apisix  2.11.0    ,
apisix-ingress-controller:  1.4.0, I  install it like this:  helm install apisix-ingress-controller apisix/apisix-ingress-controller --version=0.9.0 --namespace apisix   ......
Tobe   upgrade  env：
I want to use the  apisix 2.13.1  or 2.13.2.
apisix-ingress-controller:   I  find the newest is 1.4.1  ,  I want to know is it match the apisix 2.13.x ?
by the way , [Milestones]1.5    Will it be released on time?
thanks.
Environment

your apisix-ingress-controller version (output of apisix-ingress-controller version --long):
your Kubernetes cluster version (output of kubectl version):
if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a):

apisix-ingress-controller: I find the newest is 1.4.1 , I want to know is it match the apisix 2.13.x ?

yes. They can work together


Some Croatian holidays have different dates in 2020

Hi,
I found this package on another github page (https://github.com/christopherthompson81/pgsql_holidays) and saw that your data for Croatia has also some mistakes so I want to help :)
Last year, the government decided to change some state holidays - https://publicholidays.com.hr/2020-dates/
For fixing this issue, the holiday on the 25th of June should be deleted and a new one should be added on the 18th of November. This one should be named 'Dan sjećanja'.
Keep up the good work!

Just released on beta.. Thank you very much! 👍
Cheers
dr-p


Feature/update openapi documentation

Update OpenAPI file to reflect latest changes to server app's API endpoints

@dpgalloway a few of our web service endpoints changed, so I took a crack at updating our OpenAPI spec. Since you originally set this up, can you take a look at this when you get a chance?
@coobr01 feel free to test too, if that's just as easy.

Looks good to me!

Thank you @dpgalloway!


generate posix shell code typo

It says:

Generate POSIX shell code from a blueprint
blueprint show -S my-first-blueprint

Shouldn't it say:
blueprint create -S my-first-blueprint
???
Thanks for this work!
-Nestor

Both blueprint create -S my-first-blueprint and blueprint show -S my-first-blueprint are valid commands.  blueprint-create(1) reverse-engineers the system, stores the result under a name, and then processes optional -S (and other) code generation arguments.
Technically, blueprint create -S my-first-blueprint is the same as
blueprint create my-first-blueprint
blueprint show -S my-first-blueprint

Does that help?

I am sorry I understood (incorrectly) that you were describing a way to get a footprint from the box.
BTW it looks like if you have custom installations like /opt/tomcat it will fail to find at least that the directory is not a standard deployment I would say.
Your work has a great value for standard installations for sure though.
Thanks again for this!
-Nestor


feat: update CLI before command execution

Description
When you execute a command, for example very_good create, and you have an outdated version of the CLI you get an alert to update after the commands are executed. It would be great if this alert appears before to use the last version in this execution.
Screenshots

For context, the update prompt was changed in v0.6.0, it no longer asks if you want to update because developers/companies often want to just pin the CLI to a version and update it when they want. Prompting users about an update they don't want (yet) would be a bit annoying 😅.
We now only tell people that there is an update and how they can update the CLI themselves:

Showing this at the start of a command would probably be problematic as the command is already doing "things".
But we are of course open to suggestions on how to improve the update-cycle!

Thanks for your response! I think that it’s a good approach 😋

Closing for now then since it seems like there are no actionable steps needed. Feel free to comment with any follow-up questions and I'm happy to continue the conversation 👍


Added read/unread functionality in personal email web part

Category

[ ] Bug Fix
[x] New Feature

What's in this Pull Request?
Added read/unread functionality in personal email web part.

@Laskewitz this is a really nice and simple inclusion to the email app. Tested from my end and all looks good

@Laskewitz - any change we could get the small adjustments on this as we would love to get your improvements on the actual solution?

@Laskewitz - any changes we could get comments on the pending items? Thx.

Added changes for this, hope this is good enough ;-)

thx @Laskewitz, appreciated.


Hierarchical expansion of large graphs

I failed to load 2.1 MB .meta file generated from char-rnn model (https://github.com/sherjilozair/char-rnn-tensorflow) with python 2.7 and tensorflow 1.0.
It is loading forever... I am wondering what is wrong with these files?

Same issue, meta file is here in case you want to test it:
https://github.com/bulletphysics/bullet3/blob/master/examples/pybullet/gym/pybullet_data/policies/ppo/minitaur_reactive_env/model.ckpt-14000000.meta

Netron doesnot show FC layer in the diagram. I need to view the weights of the FC layer. Is there anything we can do it view Fully Connected layer.

@srikanthdevalour can you create a new issue and add a sample file.

@lutzroeder You mentioned "Those graphs will need an expand and explore UI that avoids rendering the entire graph" , are there any improvements planned for release versions in the future?

For large graphs, is it possible to add an option to show a given node +  fanin and fanouts upto specified level.
Example netron <g.pbtxt> -node <node_name> -level 3

@jojivk73  there is no such args like node or level in my netron cmd line...

Hi, I'm encountering this issue as well for models I was able to open with previous versions, of onnx files

@yairb-gm can you share a sample file to reproduce the issue.

Also check an see if your branch system has a Flutter system....

Hi @lutzroeder,
I've seen there was EfficientDet-D0 mentioned in the other issue about this. It does work now, but Netron still barfs on EfficientDet-D2. Here is an example onnx file. I'm not very fluent in javascript, is there anything I can do quickly to get this fixed?
Thanks,
Carl

pytorch/pytorch#75100

Hi folks. I developed netron-hierarchy, based on netron codebase and enables visualize models in a hierarchical way. This may be worth a try, especially for LLM models. Hope it helps!

Duplicate of #1370


India map shown wrong

The map of India does not fully depict the region of Jammu and Kashmir. According to the Government of India, it is illegal to display incorrect maps of India on social platforms. Please make the necessary corrections

What you have shown


Branchv1.3 update user guide

Codecov Report

Merging #151 into master will not change coverage.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b685e3f...453dde6. Read the comment docs.


Suport for IBM Codeengine as executer for notebooks/python scirpts/piplines

IBM Code Engine will soon provide a "Supercomputer as a Service" where tasks can be scaled on 1000s of cores for just a couple of seconds. Would be interesting to look at how an integration can be done at different levels:

notebook cell
notebook
python script
python function
pipeline

IBM Cloud Code Engine is currently in beta. https://cloud.ibm.com/docs/codeengine?topic=codeengine-getting-started

yes - so Elyra support also should be either beta as well or we wait until Code Engine is production ready, but then we will loose time for adoption. I think it would be a very nice feature to just push computation elastically to CodeEngine...


QML frontend: cursor blinks whilst moving it with arrow keys

When moving the cursor with the arrow keys, the cursor continues to blink.
This makes it quite difficult to see where you are moving the cursor to, since it may be invisible. It appears to leap further than one might expect, making it quite hard to track.
I think the bug may be excacerbated because it seems as though either the blink rate or the cursor movement rate is not constant, so it leaps by different amounts each time.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/10266754-qml-frontend-cursor-blinks-whilst-moving-it-with-arrow-keys?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282001&utm_medium=issues&utm_source=github).

Note: the cursor seems to move about ten or twenty lines between blinking for me. In case that's different for others. So fine grained cursor positioning is quite difficult.


Blocks and attrs

Includes https://github.com/pilosa/go-pilosa/pull/38

Coverage remained the same at 100.0% when pulling 70c32777978846194ee0399575bca6f1f502047e on yuce:blocks-and-attrs into fdddbb2546eb952c6ea897e7f2bfb58678188d78 on pilosa:master.

closing this year-old PR. I believe the consensus was that we didn't want to expose this functionality explicitly.


Gain another 10-20%+ on CPU performance on gcc by moving -fno-finite-math-only to only gelu_backwards

More targeted flag optimizations for gcc.
It's the tanhf function in gelu_backwards that causes the model to fail with -ffast-math on gcc on Linux.
Before:
$  grep name /proc/cpuinfo |head -1
model name      : Intel(R) Core(TM) i3-9100F CPU @ 3.60GHz

step 0: train loss 5.356086 (took 6167.853384 ms)
step 1: train loss 4.300644 (took 5460.413776 ms)
step 2: train loss 4.623082 (took 5276.372294 ms)
vs
step 0: train loss 5.356185 (took 5714.622339 ms)
step 1: train loss 4.301033 (took 4814.820671 ms)
step 2: train loss 4.623316 (took 4813.711103 ms)

$  grep name /proc/cpuinfo |head -1
model name      : AMD Ryzen 5 3600 6-Core Processor

step 0: train loss 5.356085 (took 3397.901288 ms)
step 1: train loss 4.300644 (took 2810.743621 ms)
step 2: train loss 4.623083 (took 2813.287769 ms)
vs
step 0: train loss 5.356185 (took 2639.362407 ms)
step 1: train loss 4.301032 (took 2258.179942 ms)
step 2: train loss 4.623315 (took 2261.548428 ms)

Timings obtained with:
( kill -STOP -1  # Stop all processes, NB don't run this outside a script!
timeout 40s ./train_gpt2
kill -CONT -1 )

Also noted:
~$ gcc -Ofast -Q --help=optimizers|grep enabled > a
~$ gcc -O3 -Ofast -Q --help=optimizers|grep enabled > b
~$ diff a b

Also resolves #19 for good I think

So maybe this is ok to merge...
1 it looks a little funny is there no way to combine the double nested if into one condition?
2 i think a comment explaining this would go a long way

Please don't forget about the MSVC/Windows. MSVC uses pragma to turn off the optimization.
#pragma optimize( "", off )
/* unoptimized code section */
#pragma optimize( "", on )

My issue with adding pragma's to source files (OpenMP excluded) is that you will keep adding more per platform/compiler. One suggestion was to split this function off into its own file then you can use the Makefile to compile with whatever flags are suitable for the platform/compiler. Makefile's typically have platform dependencies in them. My preference would be to keep the source code as clean as possible. Thanks.

@dagelf i knew we could still go further with the cpu, thanks! looking into it

@karpathy ifdefs squashed and comment added

Please don't forget about the MSVC/Windows. MSVC uses pragma to turn off the optimization.
#pragma optimize( "", off ) /* unoptimized code section */ #pragma optimize( "", on )
This is really ugly. I know.

Does it bug out on MSVC with -Ofast too?

Please don't forget about the MSVC/Windows. MSVC uses pragma to turn off the optimization.
#pragma optimize( "", off ) /* unoptimized code section */ #pragma optimize( "", on )
This is really ugly. I know.

Does it bug out on MSVC with -Ofast too?

yep

Tested to work with and speed up msvc too.

I'm sorry this is too weird and ugly to merge I think.
Can someone try alternative strategies? For example tanh can be written as a function of exp quite trivially, maybe calling it that way makes it ok?

Was thinking of suggesting that

Tried that, will need to do both tanhf and expf :smile:

Tried that, will need to do both tanhf and expf, busy with the latter... but it might be even uglier  ...It's really the msvc part that makes it ugly IMHO 😄

For now I'm just going to remove the ifdefs to get this down to only two lines, to keep it clean.
Going down the route of performant custom math functions means breaking cross platform compatibility, unless we start exploring lookup tables for CPU inference. Which I will explore next.
There sure is more performance to be gained. I quickly realized that a faster activation function might lead to slower convergence and more training steps, negating the benefits. This is my cue to learn more about what makes the activation function work so that I can develop a better intuition for it. (Any pointers appreciated!)

For the record,  it's actually the exponential in the coshf that has the biggest influence on whatever makes gelu_backward break the model. Looking that the activation function graphs above, I think I can see why :smile:
If anybody else wants to explore platform specific math function optimizations, here is a good start: https://github.com/bminor/glibc/tree/master/sysdeps/x86_64/fpu
Before playing with lookup tables, I'll compare performance of different activation functions.

Lookup tables are a great idea

Some more reference materials...
Activation functions
https://web.archive.org/web/20230324020355/https://chadrick-kwag.net/relu-gelu-swish-mish-activation-function-comparison/
https://web.archive.org/web/20220619144443/https://arxiv.org/vc/arxiv/papers/1908/1908.08681v2.pdf
https://consensus.app/results/?q=neural activation function
Math function optimizations
https://zenodo.org/records/4685966
https://github.com/bminor/glibc/tree/master/sysdeps/x86_64/fpu


[web] bump to latest Simple-Web-Server version

Bump Simple-Web-Server to the latest git commit. This also fixes a compile issue seen with GCC 12.2.0:
In file included from /home/sag/projects/openthread/ot-br-posix/src/web/web-service/web_server.cpp:42: /home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp: In instantiation of ‘SimpleWeb::ServerBase<socket_type>::Request::Request(const socket_type&) [with socket_type = boost::asio::basic_stream_socket<boost::asio::ip::tcp>]’:
/home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp:460:74:   required from here
/home/sag/projects/openthread/ot-br-posix/third_party/Simple-web-server/repo/server_http.hpp:119:57: error: member ‘SimpleWeb::ServerBase<boost::asio::basic_stream_socket<boost::asio::ip::tcp> >::Request::streambuf’ is used uninitialized [-Werror=uninitialized]
  119 |             Request(const socket_type &socket): content(streambuf) {
      |                                                         ^~~~~~~~~

@agners Just FYI, in case you want a production-class web server, https://github.com/openthread/ot-br-posix/pull/537 is a PR which replaces the Simple-Web-Server with Nginx and provides complete RESTful API set which is comparable with d-bus.

@wgtdkp hm, interesting PR, wasn't aware of that effort thanks for linking. I am not particularly interested in the web interface, I use it more as a development/debugging tool right now. In the end we will disable it most likely. However, the changes to the REST seems to be interesting. The PR seems to do quite a bit for a single PR, maybe splitting out the REST changes would be a first step?

The PR seems to do quite a bit for a single PR, maybe splitting out the REST changes would be a first step?

@agners Agree, it sounds to be reasonable and easier to forward!

@agners @wgtdkp , I'm supportive of pulling forward (portions of) #537. In the meantime, would it make sense to merge this PR first?

@jwhui yes I think merging this still make sense. It fixes the build problem for the time being.


Concept station segment assemblies

This PR introduces a new pair of application schemas for the ConceptStation Connector: CSSegments and CSUnits. CSUnits provides schema for application-specific units used by the ConceptStation Connector. CSSegments provides application-specific support for ConceptStation "segments" in the iModel, along with the application-specific ConceptStation pay item data.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Error in sha256 calculation

I have a quite strange case calculating the sha256 hash of a password.
If I use it on the server side, it works, on a web (with angular) application, it doesn't.
I tried to replicate the case creating a new web project, but in this new project the error does not happen.
I recently moved to dart 2.6.1, with dart 2.5.2 everything was working fine.
As I was afraid that the cause could be some dirty cache, I cleaned the pub/cache folder, and deleted the project .dart_tool one, but nothing helped.
So, I started debugging.
I got the point that is generating the problem, but I could not understand what's going on.
The problem is in the HashSink class, in the _finalizeData() method.
    if (_endian == Endian.big) {
      byteData.setUint32(offset, highBits, _endian);
      byteData.setUint32(offset + bytesPerWord, lowBits, _endian);
    } else {
      byteData.setUint32(offset, lowBits, _endian);
      byteData.setUint32(offset + bytesPerWord, highBits, _endian);
    }

When the program checks Endian.big, the check fails and the else block is performed.
I cannot understand why. If I look in the IDE debugger (webStorm), both _endian and Endian.big have the _littleEndian field = false. The type of _endian is "Endian", the type of Endian.big is "typed_data.Endian". If I look in the chrome debugger, both are of type Endian, but the _endian._littleEndian field is null.
I'm getting crazy...

I've moved this to be a bug-report against the dev-compiler.

I'm sorry, I forgot to report that from release 2.8 everything is working again. I close this issue


Add richer datastructure for vue client

This PR introduces the object based data structure, allowing for more manipulation client-side, than a simple array of strings.

Ryan, I think for this, we can you can still send submit tags as an array of strings to the API endpoint.
If a tag is new, it'll have an id allocated to it server-side, and if it's been seen before nothing will need to be done.
This means that when we send a POST to update a profile, we'll ideally update the store client-side, with the new tag objects and their ids.


puppet: Remove supervisor hacks.

The supervisor service can be correctly restarted by puppet on all
supported distributions, which allows it to pick up the chown
settings in its configuration.  This allows us to remove a hacky
manual "restart" which failed to pick up the updated socket ownership,
and thus skip the manual cleanup during installation.
Testing Plan: Installed on Bionic.

Hmm, so I'm reluctant to do this change because there's another benefit of the reread + update approach not highlighted in those comments.  Right now, if we make a supervisord config change, puppet apply will only restart the services that have their configuration actually modified; which means that adding a new queue worker, for example, doesn't trigger a full server restart when puppet runs.
I think those benefits are pretty important for the upgrade code path; though we should certainly rewrite the comment to not claim supervisorctl restart doesn't work and instead focus on the benefits for avoiding having supervisord spend a minute restarting the entire server for localized configuration changes.
Thinking about how to do the chown change you're trying to make here (which BTW I'm not sure what its purpose is), if we're primarily concerned with that chown logic only at installation time, we could just change install and the supervisor.conf as in this PR; existing installations will presumably get the update the next time they restart supervisor.  And we'll be no worse off than we were before this change.

The commit message is clearly not good enough to describe the problem.
The problem is that the socket is created as root, and supervisor is started.  We subsequently write out the config which requests zulip:zulip ownership -- but only trigger a reread + update which does not adjust thew ownership.  Consequently, the last steps of the install are unable to run cleanly as the zulip user unless they contain an explicit chown step.
A solution is to make an exec step which is refreshonly which does the restart, trigger that on supervisord.conf change, and leave the existing reread + update as the "restart" of the service.

Ahh, OK, I understand.

I merged 3/5 prep commits that are pure refactors and unlikely to be the cause of the test failures as 6fdcb4aa176ae8d7cb3fe9603da3ad9e895821e0.  Thanks for cleaning up that comment!

This lgtm; @andersk can you take a look as well and merge if you think the systemd changes are correct?

Mmm, yeah, looks like CI doesn't have it intentionally:
Jun 30 00:42:18 Error: /Stage[main]/Zulip::Supervisor/Service[supervisor]: Failed to call refresh: Could not restart Service[supervisor]: Execution of 'bash -c 'if pgrep -f supervisor[d] >/dev/null; then supervisorctl reread && supervisorctl update; else systemctl start supervisor; fi'' returned 1: System has not been booted with systemd as init system (PID 1). Can't operate.

Jun 30 00:42:18 Error: /Stage[main]/Zulip::Supervisor/Service[supervisor]: Could not restart Service[supervisor]: Execution of 'bash -c 'if pgrep -f supervisor[d] >/dev/null; then supervisorctl reread && supervisorctl update; else systemctl start supervisor; fi'' returned 1: System has not been booted with systemd as init system (PID 1). Can't operate.

The fix is to drop the first two commits, and add more bracing for using the init scripts, which makes me kinda sad.  Will re-roll.

A hunk ended up in the wrong commit, otherwise lgtm.  I'll fix and then merge.

Merged as 64b44a12f52061d6c626c436def8de885fb6f310 after moving the $zulip::common:: prefix addition into the right commit.  Thanks @alexmv!


Deployment Request: JIBCHAIN L1 (JBC)

Chain Name
JIBCHAIN L1
Chain ID
8899
RPC URL
https://rpc-l1.jibchain.net
Block Explorer URL
https://exp-l1.jibchain.net
Deployment Funds
Yes

Done, thanks!


Update dependency list with the actual package name

hipblas-common-devel/dev is the actual package name and it provides hipbals-common. Use the actual package name in dependency.

Please close in favour of #1170 . Only the devel packages require the hipblas-common-dev package.

Handled in https://github.com/ROCm/hipBLASLt/pull/1170, so closing the PR


Add option to position like spotlight search

See #712
Maybe this could also be consolidated with the center option using #826 by adding some "snap" spots for known locations.
Also should I add all other translations as well?

What do you think if instead of doing this custom positioning, we simply let users position/resize window wherever they want and remember the position? Since the window now hides extra items under a scroll menu, the search bar would be positioned in the same place regardless of the number of items in history.

Yes that is what I proposed in #826 👍🏼

Do you want to replace this PR with a new implementation or create a new one?

Feel free to close it. I'll submit a new one


Unable to run packaged module under windows share (samba)

Electron version:
0.36.10
Operating system:
Windows 7 Enterprise

Electron is unable to require modules via ./dir/modulename, when using asar or not, during executing through network share.
Use case:

Create VBox instance
Share packaged folder via VBox Additions
Navigate to \\VBOXSVR
Click on executable
Notice 'require module not found' through DevTools. For relative paths. (not system modules)

There's a difference between what you can see in Explorer.exe and Node' native fs library - just because it's in the Explorer, it sadly doesn't mean that native tools can talk to it like it's on the filesystem. That sucks, but that's sadly the case.
Given that fs can't read or write to smb://, I'm not sure that there's anything useful we can do here. If you have a usecase in which your users have to run from samba, use tools like Squirrel to first copy your whole Electron app to the user's app data folder - that should solve the issue.

No, i have no use case. Im just reporting issue. Following linux way: work or fork.
I thought that windows virtualize fs, like fuse do. Sorry if touched your feelings.
Product is great, forget that case, focus on features.


ElementName bindings don't work inside ItemsRepeater DataTemplate

Describe the bug
As described, using ElementName bindings inside the datatemplate of an Items Repeater appears to fail. The same template inside anything that inherits ItemsControl works fine.
Steps to reproduce the bug

Steps to reproduce the behavior:

Create an ItemsRepeater
Inside it's DataTemplate, use an elementname binding to something outside of the ItemsRepeaters VisualTree.
Observe infinite nothingness

Expected behavior
It works.
Version Info
O.S. 18362.53
MinVersion SDK: 17134
MaxVersion SDK: 17763
NuGet package version:
2.1.190405004

Is there any follow up on this? Almoat 2 years later and it seems like a pretty big thing to be missing, especially if we want ItemsRepeater to replace ListView/GridView, where it works fine.

Is there any follow up on this? Almoat 2 years later and it seems like a pretty big thing to be missing, especially if we want ItemsRepeater to replace ListView/GridView, where it works fine.

I'm also running into the same issue. Are there any work arounds for the issue?

@jevansaks I can confirm this bug is still present. I've tried both ElementName and RelativeSource bindings, nothing seems to be able to change the DataContext of that binding as long as it's inside the DataTemplate.

I'm sorry to hear that. @RealTommyKlein @ranjeshj any ideas?

I'm also running into the same issue even with the latest versions.

This is a pain see folks hit trying to implement MVVM patterns.
Someone recently created a nice isolated repro of the ItemsControl/ItemsRepeater difference here on one of our bugs, thanks to @leoshusar:
<ItemsControl ItemsSource="{x:Bind ViewModel.Items}">
    <ItemsControl.ItemTemplate>
        <DataTemplate x:DataType="x:String">
            <ComboBox Name="cmbTest1">
                <ComboBoxItem Content="TextBlock" Tag="TextBlock" />
                <ComboBoxItem Content="HyperLink" Tag="HyperLink" />
                <i:Interaction.Behaviors>
                    <ic:EventTriggerBehavior EventName="SelectionChanged">
                        <ic:EventTriggerBehavior.Actions>
                            <ic:InvokeCommandAction Command="{Binding ElementName=PageRoot, Path=ViewModel.Test1Command}" CommandParameter="{Binding ElementName=cmbTest1}" />
                        </ic:EventTriggerBehavior.Actions>
                    </ic:EventTriggerBehavior>
                </i:Interaction.Behaviors>
            </ComboBox>
        </DataTemplate>
    </ItemsControl.ItemTemplate>
</ItemsControl>

<ItemsRepeater Grid.Column="1" ItemsSource="{x:Bind ViewModel.Items}">
    <ItemsRepeater.ItemTemplate>
        <DataTemplate x:DataType="x:String">
            <ComboBox Name="cmbTest1">
                <ComboBoxItem Content="TextBlock" Tag="TextBlock" />
                <ComboBoxItem Content="HyperLink" Tag="HyperLink" />
                <i:Interaction.Behaviors>
                    <ic:EventTriggerBehavior EventName="SelectionChanged">
                        <ic:EventTriggerBehavior.Actions>
                            <ic:InvokeCommandAction Command="{Binding ElementName=PageRoot, Path=ViewModel.Test2Command}" CommandParameter="{Binding ElementName=cmbTest2}" />
                        </ic:EventTriggerBehavior.Actions>
                    </ic:EventTriggerBehavior>
                </i:Interaction.Behaviors>
            </ComboBox>
        </DataTemplate>
    </ItemsRepeater.ItemTemplate>
</ItemsRepeater>

https://github.com/CommunityToolkit/Labs-Windows/assets/13891066/aa78f395-23d7-440f-b755-13884730cca8
App22.zip
FYI @bpulliam

Here's a sample app project with a workaround that works for me.
If you want to see it in action, here's a video.

Any ETA for this issue?

Not sure what ItemsControl is doing to make this work. Here is a simpler repro
    <StackPanel>
        <Button x:Name="button" Content="MyButton" />
        <ItemsRepeater x:Name="repeater">
            <ItemsRepeater.ItemTemplate>
                <DataTemplate>
                    <Button Content="{Binding ElementName=button, Path=Content}" />
                </DataTemplate>
            </ItemsRepeater.ItemTemplate>
        </ItemsRepeater>
    </StackPanel>

    repeater.ItemsSource = Enumerable.Range(0, 10);

There is a small typo in the repro steps above - cmbTest2 does not exist.

I would presume it is a XAML namescope issue as ElementName requires the element to be in the same namescope, but as we can't debug the namescoping externally someone MS related will have to track it down. But given how "non-traditional" ItemsRepeater layouts are handled compared to normal Xaml ItemsControls I would imagine there's an obvious break point.

@bpulliam  any news? i can not use new control ItemsView because of this bug.

Here's a sample app project with a workaround that works for me.

I wouldn't call adding Loading events to set properties in code-behind as a workaround to a binding issue; sure it may work, but it's so much extra code for each UIElement and property compared to the original binding.
x:Bind/Binding is just broken in so many of these scope scenarios which adds so much friction in developing with XAML (see #2508). If a bit of focus could be spent in this space, it could make the platform a dream to work with.

@duncanmacmichael  any new for this?

I wouldn't call adding Loading events to set properties in code-behind as a workaround to a binding issue; sure it may work, but it's so much extra code for each UIElement and property compared to the original binding.

@michael-hawker
I totally agree with you. It's not clean and it's too much extra code for a simple binding. I just had a case that needed to make it work.
This issue and #2508 are getting very old and I'm concerned if they will ever get fixed.

@duncanmacmichael any new for this?

I'm honestly not sure since engineering handles bugs directly, but it looks like @ranjeshj is working on this so we can ask him for an update. :)

@ranjeshj  any update?

@llongley  fixed in v1.5 or v1.4.5?

@ghost1372 This is fixed in v1.5.

This doesn't appear to be fixed? (1.5.240404000), anyone else here still encountering the issue?

The simple repro I had works on latest 1.5 release. https://github.com/microsoft/microsoft-ui-xaml/issues/560#issuecomment-1699459932.
@DominicMaas  is your repro different? can you file a new issue with your repro (preferably small/standalone)

The simple repro I had works on latest 1.5 release. #560 (comment).
@DominicMaas is your repro different? can you file a new issue with your repro (preferably small/standalone)

Please test with this repro
https://github.com/microsoft/microsoft-ui-xaml/issues/560#issuecomment-1601316553

Still Facing this Issue on Windows App SDK v1.5.240404000

Same here still facing the issue.

I run my repro project with all v1.5.x available versions but none of them worked.

@RealTommyKlein helped narrow this down to this code -
https://github.com/microsoft/microsoft-ui-xaml/blob/7198c4e69019516fb08ecb3937492ffff5fe9702/dxaml/xcp/dxaml/lib/FrameworkElement_partial.cpp#L1169
ItemsRepeater is not an ItemsHost so it is being skipped from this check.

The same thing happens to ItemsView, I believe.

it seems that issue fixed in v1.6-exp2

Same issue still there when you use the ItemsRepeater inside a ControlTemplate in a style. Binding with a relative source to the templatedparent does not work.


Updated

Flavor Fusion is an exciting web application that explores the delightful world of culinary creativity. Built with Vite + React.js, Tailwind CSS, and DaisyUI, this project combines cutting-edge technologies to offer a seamless and visually appealing user experience.

create it with branch react not main branch


what browser this based on?

what is this one based on, google chrome or firefox? does this support chrome extensions an firefox too?

Chromium. There's no extension support yet. You can, however, request features.

cool, sweet

can you add more options for sidebar to move to the left?

can you add more options for sidebar to move to the left?
im trying to also change th default search engine?

Yes. The search engine can be changed in preferences.

Go ahead and make a feature request for the sidebar options

can you add more options for sidebar to move to the left?
im trying to also change th default search engine?

Yes. The search engine can be changed in preferences.

oh really, i tried switching to brave. it didnt changed to it.

oh really, i tried switching to brave. it didnt changed to it.

Try restarting Catalyst. If that doesn't work, create a bug report and when I have time I'll fix it and release an update.

looks like my favorite web browser yandex been crashing my computer lately.
is it possible to import bookmarks an passwords from yandex to catalyst?

looks like my favorite web browser yandex been crashing my computer lately.
is it possible to import bookmarks an passwords from yandex to catalyst?

Not yet, but you can open a feature request. Also, a forum is available at https://github.com/CatalystDevOrg/discussions

@Talion117 When you export bookmarks from Yandex, what type of file is it? (Look at the ending)

@Talion117 When you export bookmarks from Yandex, what type of file is it? (Look at the ending)

its a html file.


python310Packages.urlextract: 1.6.0 -> 1.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.urlextract is: "Collects and extracts URLs from given text"
meta.homepage for python310Packages.urlextract is: "https://github.com/lipoja/URLExtract"
meta.changelog for python310Packages.urlextract is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
Warning: a test defined in passthru.tests did not pass
found 1.7.0 with grep in /nix/store/zwlhg8glrxiziqmg9nam10wxiyz29i2n-python3.10-urlextract-1.7.0
found 1.7.0 in filename of file in /nix/store/zwlhg8glrxiziqmg9nam10wxiyz29i2n-python3.10-urlextract-1.7.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
python310Packages.urlextract
python39Packages.urlextract

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/zwlhg8glrxiziqmg9nam10wxiyz29i2n-python3.10-urlextract-1.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.urlextract https://github.com/r-ryantm/nixpkgs/archive/886f852ac2a8b6e1f502c8aa6157ed14cd2b6d76.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/zwlhg8glrxiziqmg9nam10wxiyz29i2n-python3.10-urlextract-1.7.0
ls -la /nix/store/zwlhg8glrxiziqmg9nam10wxiyz29i2n-python3.10-urlextract-1.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.urlextract
python39Packages.urlextract

Maintainer pings
cc @ilkecan for testing.

Addressed by #197818


Tempfix date display in Safari (macOS and iOS)

Quick fix for the following issue, which seems to happen in Safari on both macOS and iOS:

This updates the date time string format used to the ECMAScript standard in the frontend, but it should ideally be updated in the api.

Already manually deployed.


ConsumerGroup supports mass consumption

How does consumergroup support bulk consumption data?

Can you elaborate what bulk consumption means?

sorry,my english is not well."bulk consumption" means get lot of messages from kafka in once request


Git Reports Issue

Submitter: Oiomi-chan
I just started using Blink! and I came across a small bug, namely that the "save settings" feature seams to not be working. Otherwise it is a great program!

Saving settings requires write access to directory where .exe is run from. This is by design (app is supposed to be portable).


order tasks in opposite order

right now when creating tasks and using sequential mode in crew, the tasks are performed in reverse order. fix this by adding tasks to crew.py in reverse

resolved by #47


DO NOT MERGE Fix #2168: Add SeleniumJSEnv supporting Firefox and Chrome.

Do not review yet.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2864/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3695/
Test FAILed.

Review by @sjrd.
Note that this will need a rebase on #2237 and needs Firefox on Jenkins.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2868/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3699/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2867/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3697/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2869/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3700/
Test FAILed.

Given the hard conditions in which this needs to be tested, I'm wondering whether we could test these on Travis. It appears to have support for Selenium: https://docs.travis-ci.com/user/gui-and-headless-browsers/ (including local Firefox + remote "Sauce Labs" cluster of things).
GitHub is able to handle CI results from various sources, so it should be doable.
(Or, even crazier, we might want to consider putting Selenium JS envs in a dedicated repo+artifact ?)
Mostly thinking out loud, here.

I was going to ask: why does this need to be in the core? (Unless we want to use it ourselves in here).

I reactivated the Travis sevice to test Selenium on Firefox up there. I removed those tests from the Jenkins CI for now.

Hmm, Travis does not support oraclejdk6 (only openjdk6). Should it be tested on openjdk6? Or do we just ignore it for this particular case.

It seems like the testSuite/test overloads Travis by creating too many instances of Firefox and the start dying. But the testingExample/test seems to work fine, this is the one that we really need because it is the one that tests the DOM. We could still do a manual test on the testSuite before releases (we also need this for Chrome).

More seriously: Why does this need to go into Scala.js core? There seems nothing inherent at all here.
Having this separate does not require substantial user overhead either.

The only reason why we would keep it in the core would be to address #1881 with this environment in the future. If not, I agree that it would be better in its own repo.

Didn't you try out alternatives in Node.js that support the DOM? Also, quite honestly, I don't think it is that of a big deal if we don't support (efficient) DOM testing in core. Currently, doing so requires manual work anyways (installing PhantomJS).
So if at a later point in time, we just load Selenium reflectively and tell you you should put it on the classpath if it isn't there, it is not really any worse. But I really think this would make our life much easier (also we don't force people to pull in even more stuff, if they don't care about selenium).

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2875/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3707/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2874/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3706/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2873/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3705/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2870/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3703/
Test FAILed.

Eventually, I think we should even move PhantomJS support outside of core. Rhino and Node.js are the only things we care about.

@gzm0 I did try an alternative using jsdom on Node.js but the DOM support was incomplete and hard to manage in the environment.
It is evident that this will end up in a separate repo. I would propose to call it scala-js-env-selenium so that later on, if we extract Phantom from the core, we can call it scala-js-env-phantom and have a common prefix.

scala-js-env-selenium
SGTM


redesigned the joinus page

Description
Fixed the styling and layout of the whole page
Fixes #1074
Screenshots

Checklist

[x] Tests have been added or updated to cover the changes
[ ] Documentation has been updated to reflect the changes
[x] Code follows the established coding style guidelines
[x] All tests are passing

@thestarsahil check it

Just implement this , nothing else as your changes also effecting login page

Just implement this , nothing else as your changes also effecting login page

I didn't do anything apart from the changes


refactor: Switch to 2.0 Consul path

c## PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
Currently using 1.0 Consul path use constant in this repo
Issue Number: #3315
What is the new behavior?
Now using 2.0 Consul path using go-mod-bootstrap setup or constant
Does this PR introduce a breaking change?

[X] Yes
[ ] No

BREAKING CHANGE: Consul configuration now under the /2.0/ path
New Imports

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

Draft PR until related TAF PR https://github.com/edgexfoundry/edgex-taf/pull/358 is merged.


⚠ Samsung has degraded performance

In be73e2c, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2731 ms

Resolved: Samsung performance has improved in bfd1880.


Update minimum supported client OS versions to reflect the currently supported OS

Windows 10 1909 and 2004 are no longer in support (neither IoT, nor Home, Pro, Enterprise or Education).
Could you please update the table of supported "Windows client OS" to reflect the currently still supported minimum OS versions?
Thanks,
Robert

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f10e667a-7b08-b25f-5c0a-b776b7f11cb4
Version Independent ID: ae4936a7-f5a3-b3ad-170c-7aba109435db
Content: Supported configurations for the Windows Desktop client
Content Source: WindowsServerDocs/remote/remote-desktop-services/clients/windowsdesktop-supported-config.md
Product: windows-server
Technology: remote-desktop-services
GitHub Login: @Heidilohr
Microsoft Alias: helohr

Hello,
Do you have any update on this request?
It's been several months now since both 1909 and 2004 are out of support but our docs still list them as supported.
Could you please update the page as this causes confusion with customers and also CSS support engineers?
Thanks,
Robert

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


[Question] What is the best way to revert the merge to main branch incase of failure ?

Release version
All version
Question Details
I have a scenario and need the best approach to deal with it.
we create a feature branch with some changes and merge it with the main branch to trigger the publisher pipeline.
What will happen when the feature branch is merged to the main branch but the publisher pipeline fails? How do you undo merge and merge it again with some additional changes?
Do you suggest any best practices in this scenario? Can you support revert merge in the Publisher pipeline if It fails ? This will help to merge it again into the main branch
Expected behavior
Revert/undo the merge if publisher pipeline fails. Do you suggest any best way to revert the merge incase of failure ?
Actual behavior
The feature branch is getting merged to the Main branch even if the publisher pipeline fails. This creates a lot of issues when redeploying the changes to the main branch.
Publishing all repo content should not be the solution as It is a resource-intensive operation.
Reproduction Steps

Create a feature branch with some changes.
Make a PR to the main branch.
Publisher pipeline fails due to some reason.
How to undo the previous changes so that we can again do PR with additional changes?

Agree with @shawnyu5. The publisher is simply driven by the changes included in the last commit. It's up to you to utilize Git to drive the behavior of the publisher. We offer two options with the publisher, which is either to publish everything or publish against a specific commit ID for the UI default but you are at liberty to take that pipeline and customize it the way you see fit for your own environment.


Support surface creation with winit >= 0.20

Compilation test under Windows, OSX, iOS and Android desired.
I can remove the version change is desired.

Seems like the examples need to be changed too - Should this be done already?

Ok the only remaining issues are from the formatting - Seems like cargo fmt doesnt work here anymore with: "unknown variant Visual, expected one of Compressed, Tall, Vertical for key `fn_args_layout".

@mitchmindtree, @rukai Can you review and merge, please?

I think this should probably be a major version bump and not a minor.

Didn't need to bump the examples version, but it doesn't really matter. Another conflict popped up however.

I merged the new changes into my repo again. Should fine then.


Bugged menu if not setting TG token

Bug explanation
When a user doesn't have a Telegram token, they're prompted whether they want to give one or not. If the user decides not to, the console gets bugged as it's returning to the menu but the console doesn't reload the menu to be visible.
To go around the bug, the user first needs to press enter, then proceed to use the menu normally eg. refreshing with 21+0.
Operating System
All
Ikabot installation
I downloaded the pre-built Windows binary
Ikabot version
Latest
Python version
Python 3.11.3

Should be fixed as of 2eee94969da8f048eed99bd771eb7c3eab9f4b7f, please reopen if it happens again on the newest version


[Feat] Make the override option available for code?

Problem Statement
Currently, code doesn't have an override option, and it's always specified as false in CommandLineActor.actOnCode() as seen here:
https://github.com/FlineDev/BartyCrouch/blob/aabff74ecce1d4f893b2fccd5028d866e2100ebd/Sources/BartyCrouchKit/TaskHandlers/CodeTaskHandler.swift#L16
I wonder if this option is legacy code and if it could be removed in the future. However, I believe it would be useful when I want to mass-update translations generated by machine translation engines.
Technically, I can already remove the existing translations and run code to update them, but I have to manually modify the strings file first. It becomes more complicated if I only want to update translations for specific languages.
Suggested Solution
Would it make sense for BartyCrouch to allow us to specify this override option in [update.code] within .bartycrouch.toml? In other words, adding an override property to CodeOptions.
Additional Considerations
I'm happy to send a pull request for this.
Thank a lot for maintaining this awesome tool. 🙂

Thanks a lot for clarifying, @Jeehut.
I see. In that case, I'm wondering if you could find someone (not saying it has to be me) to maintain BartyCrouch, but that's up to you.
Wishing your tools great success! And thank you for your dedication to BartyCrouch up until now!

@mshibanami Thank you. If you know someone trustworthy and willing to take this project over, let me know.


Issues with remote files and local cache + s3 backend

Refile Versions
Using refile 0.5.4 from https://github.com/refile/refile (at v0.5.4)
Using refile-s3 0.0.1 from https://github.com/refile/refile-s3 (at master)

Using the Filesystem backend for cache/store works fine for all examples below.
Using the S3 based backend directly to upload a file works, so it does not appear to be an issue with the AWS credentials or anything.
When I use a FileSystem backend for the Cache and an S3 bucket for the Store I get the following error when uploading through a remote url
pry(main)> MyModel.create remote_file_url: 'http://i.imgur.com/dlgbOCB.png'
ArgumentError: expected params[:body] to be a string or IO object
from /Users/mrcheese/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.0.42/lib/seahorse/client/param_validator.rb:24:in validate!

From file:
[1] pry(main)> MyModel.create file: StringIO.new('sdfsdfdsf')
ArgumentError: expected params[:body] to be a string or IO object
from /Users/mrcheese/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.0.42/lib/seahorse/client/param_validator.rb:24:in `validate!'

When I instead use S3 for both cache and store the upload with a file/StringIO works but when using a remote url I get:
[2] pry(main)> MyModel.create remote_file_url: 'http://i.imgur.com/dlgbOCB.png'
IOError: closed stream
from /Users/mrcheese/.rbenv/versions/2.2.0/lib/ruby/gems/2.2.0/gems/aws-sdk-core-2.0.42/lib/aws-sdk-core/plugins/s3_md5s.rb:38:in `md5'

@mskog I was able to replicate the issue, and pushed a fix which seems to have fixed it for all cases I've tried. Can you give it a go now and see if it works better for you?

Works like a charm. Thank you!

I'm getting the same expected params[:body] to be a string or IO object error with refile 0.5.5 and refile-s3 0.1.0.

I am also experiencing this using refile 0.5.5 and refile-s3 0.1.0

Facing the same issue: IOError: closed stream
With:
refile (0.5.5)
refile-s3 (0.1.0)

I can verify, using the master branch on github fixes the issue. Thanks!


Improve error handling

This pull request is a response to issue #150.
It handles unhandled error that occurr when a client disconnects ungracefully and causes errors like "broken pipe" and similar.
It also adds the error_handler()-function, which can be overridden at some sub class.
Its implemented return value is false and provides the result to make it possible to make the library ignore ignore and error for some reason.

Perhaps, but it dumps the entire exception in the debugging so that is looks as if it is an internal error on the server, in this case, it isn't. It is just that the client has disconnected. If there would be some network error, for example, and all clients where disconnected at the same time, the logs would look like the server had blown up.
Perhaps lite this is a bit nicer, then the debug output would be more nuanced?
    except BrokenPipeError as e:
        logger.error("The client at " + str(self.peer_address[0]) + ":" + str(self.peer_address[1]) + " disconnected(" + str(e) + ")")
        return self.error_handler(e)
    except Exception as e:
        logger.exception("An unhandled error occurred: " + str(e))
        return self.error_handler(e)

With regards to naming, no problem, I can named whatever you want of course.
But don't completely understand what you mean....I can't see any other methods called "on_*" and shouldn't received_message, closed, terminated and ponged then be called on_message, on_close, on_terminate and on_pong respectively?

Yeah, I don't like the "on_" prefix either. It's just that I'd rather have methods that act as either:

commands: close, terminate
events: opened, closed

I think and error handler would fall into the second, but "errored()" seems quite ugly.
If you have more ideas :)

"Unhandled()"?

Mmh, not sure. What about: "failed()" or "failure()" ?
Or "kaboom()" :D

An error isn't exactly the same as a failure in my mind...but to follow the "received_message()" naming, perhaps "unhandled_error()" would be ok?

Sounds good to me yes

Ok. Committed that.

I have no idea why it fails?

It seems it has nothing to do with your changes so that's fine. :)

Hi,
I decided to implemented a simpler code because BrokenPipeError doesn't exist in Python 2.7. I hope this will help you nonetheless.

I'll see if I can work around it.

Thanks. I'd be happy improving it.

Did anything become of the idea of defining an on_error(self) function when creating a socket? I'm getting 1006 Going away from my close() function, but I have no way of seeing what might be causing this. Is this what's implemented in 5da9ef5?

Good point. Indeed, the handler I added doesn't address that scenario.

Okay, if I reopen this PR, it's gonna be messy. I'll handle that case in a different issue.


iOS/Android: reported value of ATT mtu sometimes includes or excludes the ATT header (3 bytes).

Hi,
Upon connecting, the API reports an ATT MTU of 20 bytes on both platform, which is the application data MTU and not the default ATT MTU (23 bytes).
That could be an implementation choice, however the reported values upon MTU changes do not necessarily follow that rule. For example on iOS, the ATT MTU on recent iOS versions is negotiated at 185 (when DLE is not used, with DLE it will be 512), Flutter Blue reports 182 (so data MTU), while on Android it always gets maxed out at 512 (on some phones 517), and Flutter Blue reports 512 (so the ATT MTU !). Would be nice to make it consistent so that it is always the data MTU or the ATT MTU being reported.

Nice find and writeup @nmbus

This bit me as well, wouldn't it be good to at least document that behavior for the time being until being fixed?


[#11377] Fix Pinpoint jboss plugin build failure

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Blog App: validations and model specs

[ ] Added the following validations:

For the User model:

Name must not be blank.
PostsCounter must be an integer greater than or equal to zero.

For the Post model:

Title must not be blank.
Title must not exceed 250 characters.
CommentsCounter must be an integer greater than or equal to zero.
LikesCounter must be an integer greater than or equal to zero.

[ ] Added unit specs for all of your models' methods and validation

Hi@t-yanick, thanks for the approval


stacked bar chart

Hey Curran,
Thanks for the sreencasts, I was very helpful.
I made the stacked bar chart and it works ok, if there is no missing data.
In your csv file" religionByCountryTop5.csv" for example Brazil Hindu is marked zero.
In my case the combination of Brazil  Hindu would not be in the file.
How can adjust the code to work if data is missing, I plug the chart on oracle BI, so I don't know in advance if data is going to be missing.
Thanks,

Hi @7marjorie ,
If the data is missing, would you like to treat that as a zero value? If so, probably the best approach would be to detect which pairs are missing, and add "fake data" that fills them in as zero values, before passing the data into d3.nest.
I think the problem is that stack() expects clean data where all possible pairs are filled in. Probably one way to sol you could do is not use d3.nest(), but instead roll your own nested loop that iterates over all combinations (the cartesian product of domains for the two fields), looks them up in the actual data, and generates a zero value for pairs that are not in the original data.
These answers might also be helpful:

http://stackoverflow.com/questions/14713503/how-to-handle-layers-with-missing-data-points-in-d3-layout-stack
http://stackoverflow.com/questions/17415406/filling-the-gaps-in-d3-array-nesting
d3.nest() "internal" and "external" keys - This one has a nice solution.

Also, this would be a great question for the D3 mailing list, perhaps someone there has a better answer.

Thank you for the response Curran!!
2017-01-25 14:25 GMT+01:00 Curran Kelleher<EMAIL_ADDRESS>
Hi @7marjorie https://github.com/7marjorie ,
If the data is missing, would you like to treat that as a zero value? If
so, probably the best approach would be to detect which pairs are missing,
and add "fake data" that fills them in as zero values, before passing the
data into d3.nest.
I think the problem is that stack() expects clean data where all possible
pairs are filled in. Probably one way to sol you could do is not use
d3.nest(), but instead roll your own nested loop that iterates over all
combinations (the cartesian product
https://en.wikipedia.org/wiki/Cartesian_product of domains for the two
fields), looks them up in the actual data, and generates a zero value for
pairs that are not in the original data.
These answers might also be helpful:

http://stackoverflow.com/questions/14713503/how-to-
handle-layers-with-missing-data-points-in-d3-layout-stack
http://stackoverflow.com/questions/14713503/how-to-handle-layers-with-missing-data-points-in-d3-layout-stack
http://stackoverflow.com/questions/17415406/filling-
the-gaps-in-d3-array-nesting
d3.nest() "internal" and "external" keys
https://groups.google.com/forum/#!topic/d3-js/0zNu-oVVtwk - This one
has a nice solution.

Also, this would be a great question for the D3 mailing list
https://groups.google.com/forum/#!forum/d3-js, perhaps someone there
has a better answer.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/curran/screencasts/issues/22#issuecomment-275106853,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVkHM0Ti7WHycjgMhMbsaaKcwdcXujn3ks5rV01JgaJpZM4LsZNK
.

--
Met vriendelijke groeten,
Marjorie

@7marjorie No problem! I feel like it's a common problem, and it would be interesting to have a library that does the filling in of the gaps based on the cartesian product.
You might also want to try Datalib https://github.com/vega/datalib/wiki/API-Reference#group-by-aggregation . They have a nice group-by aggregation feature. Although your data is already aggregated, I wonder if you pass it through their group-by processing if it might add in the zeros.

Hey Curran,
Thanks i will try it out!
Marjorie
2017-01-31 11:56 GMT+01:00 Curran Kelleher<EMAIL_ADDRESS>
@7marjorie https://github.com/7marjorie No problem! I feel like it's a
common problem, and it would be interesting to have a library that does the
filling in of the gaps based on the cartesian product.
You might also want to try Datalib https://github.com/vega/
datalib/wiki/API-Reference#group-by-aggregation . They have a nice
group-by aggregation feature. Although your data is already aggregated, I
wonder if you pass it through their group-by processing if it might add in
the zeros.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/curran/screencasts/issues/22#issuecomment-276333419,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVkHM1xfj7pci4S7LDGRU4rQS1w9s1xjks5rXxNsgaJpZM4LsZNK
.

--
Met vriendelijke groeten,
Marjorie


Provide a configuration for mapping inventory location

From xarray-contrib/xarray-tutorial#85: libraries that lift classes up the module hierarchy are now required to override the __module__ of each class because we use the fully qualified name to figure out the canonical location of a class. In case they don't want to, we could easily provide configuration to map inventory locations to others. For example:
codeautolink_inventory_map: dict[str, str] = {
    "lib.sub.module.thing.Thing": "lib.Thing",
    "lib.mod.ReallyLongName": "lib.Alias",
}

:+1: I really like this idea. This is a sphinx-specific modification so it'd be nice to keep it contained to  the sphinx configuration.
Thanks for your work on this lovely package

To be fair, it is user-facing as well. Depending on what you want your users to see, __module__ pointing to the top-level location could be more accurate and helpful when determining where to import it from, or pointing to the original location could be more helpful if you're looking for the source code.
In any case, much appreciated! Thanks for all the feedback ❤

Depending on what you want your users to see, module pointing to the top-level location could be more accurate and helpful when determining where to import it from, or pointing to the original location could be more helpful if you're looking for the source code.

It seems like the intent is the latter i.e. it should point to the actual code: https://stackoverflow.com/questions/10113892/semantics-of-module

Alright, the implementation is almost ready, but I hit one complication. Currently we'd need to specify a map like:
codeautolink_inventory_map = {
    "package.sub.SubBar": "package.SubBar",
    "package.sub.SubBar.sub_attr": "package.SubBar.sub_attr",
    "package.sub.SubBar.another_attr": "package.SubBar.another_attr",
}

which is way more tedious than just specifying
codeautolink_inventory_map = {
    "package.sub.SubBar": "test_project.SubBar",
}

and letting everything else follow. It would be a bit more complicated to implement, but nothing major. Mainly I'm wondering if there are some things that should be taken into account, like would someone ever need (or be able to) specify different locations for things under the same inventory path? I guess so. For example:
# package.__init__
from .sub import module

# package.sub.module
class Thing:
    pass

.. automodule:: package
   :imported-members: module

.. autoclass:: package.sub.module.Thing

So I'm tempted to play safe and go with the tedious but extra explicit option. Thoughts?

the tedious but extra explicit option. Seeing autolink warnings will make enumerating all the objects that should be mapped a bit easier.

IMO this is OK. It's a one-time pain.

I also improved the warning messages a bunch to specify why links are missing. Now released as sphinx-codeautolink==0.14.0!

Would this be handled by using mypy (#132) or would you still need the manual config?

Actually, this does seem like  a major pain. We'd have to add an entry for all of our API which is quite hard. It'd be nice to jsut do
codeautolink_inventory_map = {
    "package.sub.SubBar": "test_project.SubBar",
}

and have everything else follow.


Integrate Research Funding Databases

Important databases are GEPRIS (German) and CORDIS (EU)

Well, should we integrate one or both of them or should we explore other alternatives and then decide which ones to integrate into NFDI SE?

Well, I would integrate exactly these two since they are most important.
In general, issues should be very concrete to be able to assess whether a ticket can be done in a given time frame.

Hi Ricardo, CORDIS is integrated, but GEPRIS currently only provides HTML data. What do you suggest?

It looks like the GEPRIS HTML is parseable. Have you tried Beatufil Soup plus XQuery/XPath ?

I haven't yet tried using Beautiful Soup with XQuery or XPath, I will try.

Both GEPRIS (German) and CORDIS (EU) are integrated.


[nestjs] Instrumentation does not add http.response.status_code

What version of OpenTelemetry are you using?
    "@opentelemetry/auto-instrumentations-node": "^0.39.0",
    "@opentelemetry/instrumentation-express": "^0.33.1",
    "@opentelemetry/instrumentation-http": "^0.41.2",
    "@opentelemetry/instrumentation-nestjs-core": "^0.33.1",
    "@opentelemetry/instrumentation-pg": "^0.36.1",
    "@opentelemetry/sdk-node": "^0.41.2",

What version of Node are you using?
v18.17.1
What did you do?

Instrumented a new NestJS application.

Create a new NestJS application
Add the following instrumentation config

export const otelSDK = new NodeSDK({
  spanProcessor: new BatchSpanProcessor(traceExporter),
  contextManager: new AsyncLocalStorageContextManager(),
  textMapPropagator: new CompositePropagator({
    propagators: [
      new W3CTraceContextPropagator(),
      new W3CBaggagePropagator(),
      new B3Propagator(),
      new B3Propagator({
        injectEncoding: B3InjectEncoding.MULTI_HEADER,
      }),
    ],
  }),
  instrumentations: [
    getNodeAutoInstrumentations({
      '@opentelemetry/instrumentation-fs': { enabled: false },
      '@opentelemetry/instrumentation-aws-lambda': { enabled: false },
      '@opentelemetry/instrumentation-net': { enabled: false },
      '@opentelemetry/instrumentation-http': { enabled: false },
    }),
  ],
  serviceName: serviceName,
  resource: resources.Resource.default().merge(additionalResourceAttrs),
});

Run the SDK before initializing the NestJS application
Check created traces in Jaegar

What did you expect to see?
The HTTP status code of the created NestJS spans, according to http conventions
What did you see instead?
No HTTP status code in the generated spans
Additional context

Could you post the version of nest.js you use.
Besides that it would be also nice to see which attributes are actually on the spans you get.

Definitely!
    "@nestjs/common": "9.4.3",
    "@nestjs/core": "9.4.3",

The NestJS spans have all the attributes as mentioned in the documentation. E.g.
     {
                    "traceID": "a4fbecb9dff542cdcaba0163878d4525",
                    "spanID": "171c64338a79e2bb",
                    "operationName": "HealthController.check",
                    "references": [
                        {
                            "refType": "CHILD_OF",
                            "traceID": "a4fbecb9dff542cdcaba0163878d4525",
                            "spanID": "e58aa9b71da5e2aa"
                        }
                    ],
                    "startTime":<PHONE_NUMBER>039000,
                    "duration": 10159,
                    "tags": [
                        {
                            "key": "otel.library.name",
                            "type": "string",
                            "value": "@opentelemetry/instrumentation-nestjs-core"
                        },
                        {
                            "key": "otel.library.version",
                            "type": "string",
                            "value": "0.33.1"
                        },
                        {
                            "key": "component",
                            "type": "string",
                            "value": "@nestjs/core"
                        },
                        {
                            "key": "nestjs.version",
                            "type": "string",
                            "value": "9.4.3"
                        },
                        {
                            "key": "nestjs.type",
                            "type": "string",
                            "value": "request_context"
                        },
                        {
                            "key": "http.method",
                            "type": "string",
                            "value": "GET"
                        },
                        {
                            "key": "http.url",
                            "type": "string",
                            "value": "/api/v1/health"
                        },
                        {
                            "key": "http.route",
                            "type": "string",
                            "value": "/api/v1/health"
                        },
                        {
                            "key": "nestjs.controller",
                            "type": "string",
                            "value": "HealthController"
                        },
                        {
                            "key": "nestjs.callback",
                            "type": "string",
                            "value": "check"
                        },
                        {
                            "key": "span.kind",
                            "type": "string",
                            "value": "internal"
                        },
                        {
                            "key": "internal.span.format",
                            "type": "string",
                            "value": "proto"
                        }
                    ],
                    "logs": [],
                    "processID": "p1",
                    "warnings": null
                }

If using the http instrumentation the parent span does receive the http status code but if I am only using the NestJS instrumentation then I expect the HTTP information to be fully populated.
Another way of seeing this would be to nest the HTTP spans below the NestJS instrumentation, rather than using the HTTP instrumentation's spans as parents, and then propagating the span tags. For example,

The NestJS spans are nested deep under both the ExpressJS and the HTTP instrumentation spans which is not so nice to quickly identify problems in a controller's method.

I think this is not a bug because nestjs instrumentation is for nestjs stuff and http instrumentation is for http stuff. I find the few http attributes on the nest.js spans are actually not the best idea as they cover only a small subset. If used with http it's useless duplication.
if each instrumentation would potentially duplicate all data from it's parent you might end up in having the http data 3 times (http, express, nest.js) or even more if one builds something on top of nest.js.
I would assume that you will run in quite some more issues with this setup without including the http instrumentation.
e.g. if you monitor also the caller your trace is likely not linked to the caller because extracting the context from HTTP headers is done by the http instrumentation not nest.js.
Actually I wonder that you even see a span in your setup. As far as I know express instrumentation for example creates spans only if there is already a span active (which usually comes from http instrumentation). Seems nest.js is different in this regard which is in my opinion an unwanted inconsistency.
@rauno56 You are the listed as owner of this instrumentation, maybe you have also some thoughts on this.

Ah I see. I still think that, if NestJS is present and for spans that are created for NestJS controllers, the controller itself should be the parent rather than the HTTP URL. You can see from the image that the parent is the HTTP span -> Express spans -> Nest spans which doesn't look as nice as for example the Ruby on Rails instrumentation.
I didn't mean for us to duplication instrumentation data, rather to fold it into the NestJS instrumentation instead of publishing sub-spans for NestJS controllers, sorry! I do see this as non-trivial though so I would understand if this line of thinking is not even worth pursuing.
About NestJS consistency...I am not sure. I do understand there's some duplication present already. For example, the parent span is an HTTP span, then we have the Express spans for various middlewares and the route itself, then the "parent" Nest span and then sub-spans sort of duplication the HTTP and Express spans exposed above. At least, this is how it appears to me.

So you mean even the real world data flow is HTTP => express => Nestjs you would like that this is shown the other way around?
Sounds to me more like a task for the backend tooling to beautify the data in a way to make it more comfortable to the end users instead of asking the source to "lie".


feature: add event listeners to get answers from Base.send method only when explicitly asked

In my particular use case I might be sending many messages to a contact from bot without ever expecting an answer to sent message. I've noticed that only Question class is actually dealing with question:answer event. Otherwise a process can end up having many event listeners stacking up in the EventEmitter's instance without being actually called as there's no response from the contact ever, thus triggering nodejs throwing an error like (this is after me increasing event listener max count):
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 201 update listeners added. Use emitter.setMaxListeners() to increase limit

Published as<EMAIL_ADDRESS>


feat: WIP - Add DynamicContainerWidget (#22796)

Description

Work In Progress - Looking for feedback and guidance
I'm creating a DynamicContainerWidget to allow my users to select different layouts.
Not sure if this is the right approach to resolve this need. I'm having problems defining the width/height of each section's contents.

Please, let me know if progress so far is correct. @dilippitchika @riodeuno @Nikhil-Nandagopal
Fixes #22796
Media
https://watch.screencastify.com/v/svt9jNI7ZHTxyzWcRzy3
Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

@iamenrique can you explain what is the problem you are trying to solve with this widget?

@dilippitchika What I try to do is what I described in this thread a couple of days ago:
https://discord.com/channels/725602949748752515/1100552199475576954
I need the following layouts in my page:

100% + a slide out/overlay
33% / 66% + the slide out/overlay
25% / 50% / 25%

I plan to have a single widget in each section, and that widget should take the whole space of the container (height and width).
Unless you suggest a different approach, I'd try to solve it via a DynamicContainerWidget. Drop one of those in my page, extend it to take the whole page width and enough height, and place my contents in the sections. Currently it's using a blueprint to have the 3 Containers, each one with a Text widget (display "Panel A/B/C" respectively.

@iamenrique checked the discord as well, but i have more questions

Why do your users need to toggle and see different views?
->  "If the user decides to focus on the detail card widget, it can click on a toggle button to change the 70/30 layout to be 50/50 or even 30/70." - Did your users ask for this dynamic behavior? What is the data they look at that prompted them to ask this new dynamic split?
What prompted you to add the new widget? Is it a non-negotiable feature to adopt Appsmith in your organisation? If yes, then we would like to talk to you and understand more.

CC @andreevanatasha

@dilippitchika I'm happy to answer.

This is like a Master Detail UI. Left section (section A) is a Table/List of resources. Right section (section B) is a custom detail component with charts and other visualizations where the user can drop items dragged from section A. Plus, there's a third section (section C) that can be in overlay mode (to hide and show) or be pinned to become a 25/50/25 layout. Section C is a detail of the selected row in A. B shows data of several items, but also depends on A's selected row to do some UI customization. Section B can be set as the "secondary" or "primary" component in the working area, that's why the user should be able to toggle the layout mode.
I couldn't find another way to do what I described above. Wrapping all that logic in a widget is the only way I know without messing with the whole product or the canvas. We are planning to adopt Appsmith for other reasons, and I don't really need to push this feature to the core product. I can just keep mine on my end and don't think of it as a generic widget but something tailor-made for my company.

Hey @iamenrique i still don't understand the need for having quite this dynamic master detail pattern. I get that once you select something in the master, the focus should be on the detail and that is why it should change dynamically. But having 3 layouts, overlays etc doesn't make sense to me yet.
Nevertheless, we think it's better if you fork a version of Appsmith and add the widget there so that you can use it but i don't think we can add and maintain the widget right now. We will soon open anyone to contribute custom widget #2033 so that you can add this widget without forking.
Really appreciate your contribution, we will launch our custom widgets feature soon.


Publish 10/07/2021, 10:30 AM

Docs Build status updates of commit 94d10d4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Get-CsExternalAccessPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Get-CsUserAcp.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsExternalAccessPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/New-CsTeamsEmergencyNumber.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Remove-CsUserAcp.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsExternalAccessPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

skype/skype-ps/skype/Set-CsTenantFederationConfiguration.md
:white_check_mark:Succeeded
View (skype-ps)

teams/teams-ps/teams/Get-CsTeamsAcsFederationConfiguration.md
:white_check_mark:Succeeded
View (teams-ps)

teams/teams-ps/teams/Set-CsTeamsAcsFederationConfiguration.md
:white_check_mark:Succeeded
View (teams-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[YUNIKORN-2712] Missing specific param error for REST API

What is this PR for?
Some REST API's throw "missing specific param" kind of errors, but not all. For example, user name is missing. Similarly, all mandatory parameters in other REST API's can follow the same pattern. It is very clear, rather than saying "doesn't exists" kind of error.
Suggestion given in https://github.com/apache/yunikorn-core/pull/905#discussion_r1663068429 can be used as reference for implementation.
What type of PR is it?

[ ] - Bug Fix
[x] - Improvement
[ ] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2712
How should this be tested?
make test

Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

@pbacsko Thank you pointed that out. Just add some tests to fix the coverage.

In PR #530 we removed the missing parameter checks and moved to a simple nil check for the whole params array. We did that because the httprouter will not call the handler unless we have a match in the URL. The nil check is a defence in depth. In normal operation we can never call any of the handler functions without the variables set as the URL matching will fail before that. I think we forgot to clean up the user and group check.
If we can show that a call made via the httprouter, not directly calling the handler in test code, can have missing parameters we should add these checks. If they are always present, with a value or not, we should not add the check and leave it to the handled as a "Not Found" error.
For this change I would go the other direction: remove specific param checks

I agree. If httprouter does the deeds, we don't have to do them twice.
gentle ping @manirajv06 WDYT?

If there's no further objection until tomorrow, I will close this pr and open a jira to cleanup.

open Jira on: https://issues.apache.org/jira/browse/YUNIKORN-2793


crash-handler, logger: wait till logs have been flushed to exit

/land

/land

:broken_heart: Test Failed - ci-test-success

:broken_heart: Test Failed - ci-test-success

/land

/land


[suggestion] Make a query builder and remove the boilerplate request_with_* methods

Feature request
My suggestion is to make a builder and to get rid of these Client's request_with_* methods.
Motivation
We have many boilerplate Client's query methods.
Who can help?
@appetrosyan @pesterev

Good idea. Let's make sure we cover all of the patterns in the code.

Another suggestion is to use "default parameters".

Personally, this is up for debate. The builder pattern is common-enough in our code base not to surprise new users. While in a vacuum I'd prefer having a struct and use the ..Default::default() in a struct literal, because we already make good use of the builder pattern elsewhere it'd lead to less surprise.

@appetrosyan @pesterev i don't insist on ..Default::default(), i agree that we already have enough places where we use builders, so we can keep doing that.
I just want to provide options for us to consider.


Getting "context deadline exceeded" error

We are getting the below error intermittently in Prometheus and whenever this error occurs, the particular target "up" value is showing as 0 which results in triggering a false alert. I have gone through some forums and they have suggested to increase scrape_timeout value. I have set scrape_interval as 60s, so I cannot increase scrape_timeout beyond 60s. Currently, scrape_timeout value is set as 10s by default. I am getting the below error for some other targets as well. But after 2 or 3 minutes, Prometheus is able to fetch metrics and shows target "up" value as 1. Can someone help me to understand why this issue is occurring and resolve this issue?
Error:
Mar 20 06:14:42 promethhost prometheus: level=debug ts=2022-03-20T10:14:42.764Z caller=scrape.go:1137 component="scrape manager" scrape_pool=zookeeper target=http://xxx.zookeeper.xxx:9100/metrics msg="Scrape failed" err="Get [http://xxx.zookeeper.xxx:9100/metrics\](https://urldefense.proofpoint.com/v2/url?u=http-3A__xxx.zookeeper.xxx-3A9100_metrics_&d=DwMF_g&c=jf_iaSHvJObTbx-siA1ZOg&r=QmRSslm4rpGcu4fLxdJhB1LBDgyF5D-MrdvR4kv4AZs&m=KJeNnRpwh0lLgpLERqGfSp7yvXxrAnNmMvj8Rl4CERE&s=ujjCloGYQnpdA9xjFjmhgkF0oh_CE0DPSbwKoYld-EI&e=): context deadline exceeded"

This errors means that the scrape request is timing out because the target isn't responding fast enough. There's probably something wrong with that ZooKeeper instance.


Merge pull request #1655 from cgoveas/devel

Updating github icons
Issues Resolved by this Pull Request
Please be sure to associate your pull request with one or more open issues. Use the word Fixes as well as a hashtag (#) prior to the issue number in order to automatically resolve associated issues (e.g., Fixes #100).
Fixes #
Description of the Solution
Please describe the solution provided and how it resolves the associated issues.
Suggested Reviewers
If you wish to suggest specific reviewers for this solution, please include them in this section. Be sure to include the @ before the GitHub username.

@all-contributors please add @sujit-jadhav for question


[BEAM-10496] Eliminate some null errors from core SDK coders

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @y1chi
since now you are expert at coders :-)

Run Java_Examples_Dataflow PreCommit

Run Kotlin_Examples PreCommit

org.apache.beam.sdk.io.pulsar.PulsarIOTest.testReadFromSimpleTopic: Trying to claim offset<PHONE_NUMBER>428 before start of the range [1655243286848,<PHONE_NUMBER>859)

run java precommit


Validate TestScenarios against schema

Summary
Introduce jsonschema to validate test scenarios.
The idea is to make sure our TOML files are compliant with some sort of schema. In future, we can deserialise object into dataclasses without real parsing.
This is likely breaking dependency references and we need to find a way to fix it.
Test Plan
CI
Additional Notes
—

To be re-implemented using Pydantic


[2.2.x] Added troubleshooting for testing on OS X High Sierra and later

I noticed that running the test suite (./runtests.py) was failing with an obscure-looking obj-C error. I did some digging and found that OS X High Sierra introduced some changes to their internal security model which causes fork() to misbehave. Adding an environment variable seemed to fix this.

Hi @tombasche. I've never seen this error. Can you provide more info about how you're running the test suite etc? (How can I make this happen?) Thanks.

I'm on OS X Mojave, and I just ran them as per the instructions in the documentation i.e.
./runtests.py from the /tests directory with a virtualenv active.
I tried this too with python3 runtests.py and got the same error.

OK, so I'm doing exactly that right now, and all works as expected...
Q: What Python are you using?
A quick search and a couple of threads suggest the issue may be there:

https://github.com/ansible/ansible/issues/32499
https://bugs.python.org/issue30837

As per the release notes:

We highly recommend and only officially support the latest release of each [Python] series.

I am using Python 3.7 but perhaps I may have unknowingly used Python 2.7 :(
In that case, I shall rescind this PR :)