Add firstone extension

Description

Screencast

Checklist

[ ] I read the extension guidelines
[ ] I read the documentation about publishing
[ ] I ran npm run build and tested this distribution build in Raycast
[ ] I checked that files in the assets folder are used by the extension itself
[ ] I checked that assets used by the README are placed outside of the metadata folder

Hi @zenmushie 👋
It looks like you just published one of our examples to the queue. Is that on purpose, or did you forget to add files?

Sorry! I was trying to make an organization, and messed that up. I got it working though. Apologies!
Sent with Shortwave https://www.shortwave.com?utm_medium=email&utm_content=signature&utm_source=ZGFuQHplbm11Lmlv
On Wed Feb 21, 2024, 07:32 AM GMT, Per Nielsen Tikær @.***> wrote:

Hi @zenmushie https://github.com/zenmushie 👋
It looks like you just published one of our examples to the queue. Is that on purpose, or did you forget to add files?
—
Reply to this email directly, view it on GitHub https://github.com/raycast/extensions/pull/10851#issuecomment-1956046714, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6JAUE6INQGHQDXFSUN7EZDYUWPINAVCNFSM6AAAAABDSGFU4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJWGA2DMNZRGQ.
You are receiving this because you were mentioned.Message ID: @.***>

Closing 🙂


docs: escape dot to prevent parsing of title as url

Closes #617.
Another solution would be to wrap the heading in a  span. But this would alter the DOM. Using h4 directly does not work.

Interesting that this only happens for .web :)


Full Height buttons

Hey guys.
I have the following structure:
<Grid>
  <Row size={50}>
    <Col>
      <Image .../>
    </Col>
  </Row>
  <Row size={50}>
    <Col>
      <Row size={50}>
        <Col size={50}>
          <Button large .../>
        </Col>
        <Col size={50}>
          <Button large .../>
        </Col>
      </Row>
      <Row size={50}>
        <Col size={50}>
          <Button large .../>
        </Col>
        <Col size={50}>
          <Button large .../>
        </Col>
      </Row>
    </Col>
  </Row>
</Grid>

The grid structure is pretty straightforward, but I have an issue with the buttons. I need them to get the entire height of the closer Row.
What seems to happen is that the Row fits to the Button height. I need the parent Rows to take the full screen height and the buttons to follow the same behavior.

In the example image I need the buttons to fill the entire marked space.
Is there any way to do that?
Thank you.

Can you please try using style flex: 1 with the rows and buttons and check?

Nope. flex: 1 does nothing. Another tip?

Fixed. I was able to do by using the default Views and setting the flex-box sizes according to my grid structure.


Add API docs tooling

@nedbat @regisb -- Here's my stab at pulling the API doc tools out of edx-platform and into a shared repository. I settled on edx-drf-extensions because it's our canonical "REST API tooling" library and is already installed into most edX IDAs.
This PR creates a new folder called edx_api_doc_tools that exposes a toolkit of utilities through its __init__.py. It also has a silly "edX Hedgehog API" under edx_api_doc_tools/example that demonstrates how to use the doc tools. Finally, edx_api_doc_tools/tests does some baseline testing by looking at the JSON generated by from the example API.
There are a few TODOs scattered throughout this PR (hence its DRAFT status), but I wanted to solicit feedback early in case there are any major changes I need to make.
I haven't included Sphinx doc generation in this PR; I'm thinking that it could merge separately, while applying this PR's changes to edx-platform could be done in parallel.
Lastly, @regis and @nedbat , I plan on giving you both co-authorship on this final commit(s), as you wrote much of the original code; let me know if you have any qualms with that :)

Hey @kdmccormick! Good job working on this. The tests did not exist before in edx-platform, right? I can see that a lot of effort has gone into this.
I have qualms about the integration with the edx-drf-extensions repo:

The large number of changes made to the requirements files show that the edx_api_doc_tools don't have much in common with the rest of this repo.
Unless I'm mistaken, edx_api_doc_tools does not depend on the rest of the code in the repo. Coalescing both repos would introduce an unnecessary dependency.
This PR adds 1k+ lines of code to a repo that has just 2.3k lines of code (roughly). This seems disproportionate.

Also, we should try to make it as easy as possible to use the API documentation tools. For that, we need to provide some documentation on how to use it. It would be great if we could have a guide on how to use the documentation tools as well as a reference of the various APIs. An additional benefit of this guide is that it would inform us of non backward-compatible changes.

@regisb We are definitely planning to thoroughly document the process of documenting APIs.  I guess @kdmccormick and I didn't let you know, but we have an ad-hoc to-do list in the old repo: https://github.com/edx/api-doc-tools/issues
I hear what you are saying about the api tooling perhaps being better in a separate repo.  I think the reasoning was that most repos that need edx-drf-extensions will also need the doc tooling, and vice-versa. Putting it all in one repo reduces the maintenance chores in the repos.  So it's a pragmatic choice rather than a philosophical one.  I could be swayed in the other direction.

I guess @kdmccormick and I didn't let you know, but we have an ad-hoc to-do list in the old repo: https://github.com/edx/api-doc-tools/issues

This is really cool! I wasn't aware that there was a dedicated repo.

I think the reasoning was that most repos that need edx-drf-extensions will also need the doc tooling, and vice-versa.

The rub lies in the "most". If there is ever a non DRF-based API that comes out, it will have to install DRF nonetheless in order to document its API.

Putting it all in one repo reduces the maintenance chores in the repos.

I disagree with this. For instance: if a repo depends on a feature included in release X+1 of api-doc-tools, but is not yet compatible with release X of edx-drf-extensions, then it will have to upgrade before it can start using the new feature.

So it's a pragmatic choice rather than a philosophical one. I could be swayed in the other direction.

I'll do my best to convince you with practical arguments :)

@nedbat @regisb Thanks for all the feedback!
@nedbat I've applied some of your suggested changes; I'll apply the next week.
@regisb Re: api-doc-tools vs. edx-drf-extensions: You make good points. I hemmed and hawed between the two locations for a while. Within the walls of 141 Portland there seems to be a sentiment of "we have too many repositories", and every current edx.org IDA that needs API documentations also needs DRF extensions. However, I understand those two thing aren't necessarily true in the Open edX community. I'll stew on this and update you with my thoughts when I come back to this PR next week.
As a point of pedantry, the API tools are powered by drf-yasg which required DRF anyway.
Finally, regarding documentation on how to use these tools: that is absolutely part of the plan! My bad for omitting that from the description.

@regisb @nedbat Keeping this out of DRFX and making use of https://github.com/edx/api-doc-tools sounds good to me. I'll post a similar PR to that repo this week.

Weren't we going to finish the tweaks here before moving to the other repo?

@nedbat Right; that was the plan.

Keeping this out of DRFX and making use of https://github.com/edx/api-doc-tools sounds good to me. I'll post a similar PR to that repo this week.

Thanks! I understand the practical issues around the management of many different repos, and I appreciate the effort.

@nedbat @regisb I finished addressing the comments on this PR, and will be working off of https://github.com/edx/api-doc-tools/pull/13 from now on. I'll ping you both when I'm ready for another round of review.


Suggestion: Consider minimum values when determining a value's "y"

I see the code calculates the maximum value and uses that when calculating the "y" when plotting a point.  I suggest that the algorithm should also consider the minimum values as well, to keep negative values from going below the chart.
For example, [ -1, 0, 1] should show an increasing line starting at the bottom left going to the top right.  In the current code, however, the line starts on the second point (0) and the first value is hidden.

I second this but for a different reason, I'm trying to display some sensor data. The data is a temperature reading.
Because all the readings are between lets say, 72-76 it barely moves the line. Ideally I'd want the y minimum considered so this shows the changes better.

@csharpengineer
I fixed this issue for my own use anyways. Should work for yours.
Using the same method as in the source I calculate the minimum and maximum values.
function defaultFetch(entry) { 	return entry.y; } const fetch = defaultFetch; var values = valuesArray.map(entry => fetch(entry)); const max = Math.max(...values); const min = Math.min(...values);
Then when you calculate your array to send I create 2 values.
A tooltipValue which is the one to display, and a value, which is calculated by the input minus the minimum.
For my purposed where all the numbers are close together but not near zero this made the graphs actually use the full range.
I may put this into a pull request

I basically did what you did.  I calculated the minimum value of all the points, then adjusted each point using that value.

Something like this is also required if your data happens to be all negative - it's not safe to assume it's all positive and above zero. All zeros crash the height calculation. Add one negative point into the mix and then you hit this issue.

@Craigzyc Can you please publish your whole code? I would like to use fetch option.
Thanks.

@happytm
I created a codepen using the example adding in my code
Its using the BTC price which isn't a great example of data that doesn't work but you can see the slight difference in the fixed vs unfixed sparkline
https://codepen.io/craigzyc/pen/QWpprqB

@happytm
After doing that I decided to make another pen that actually showed the issue better. As you can see in this one the line is almost flat when you're looking at something like a room temperature without the fix
https://codepen.io/craigzyc/pen/abJJGaO

@Craigzyc Thank you for giving you time. It is clear now.

Here's a branch-PR that normalises and then displays sparklines with support for positive and negative values.
https://github.com/robshep/sparkline-subzero/


how do i use embedly with this?

The ReadMe states that ruby-oembed supports embedly to get a long list of additional providers, but I don't see any documentation on how to do this. Once I've bundled and required the 'embedly' gem, do I need to register somehow with the embedly library?
do I just do OEmbed::Providers.register(OEmbed::Providers::Foo) for the providers I need?

You actually don't even need the official embedly gem to get embedly result with the oembed gem. Here's some sample code:
# first, add your embedly API key
# to the included embedly provider.
OEmbed::Providers::Embedly.endpoint += "?key=#{my_embedly_key}"
# Then you have two options
# Option 1. If you want to get results only from embedly,
# use that provider directly.
response = OEmbed::Providers::Embedly.get(url)
# Option 2. If you want to use embedly as a fallback
# in the case that the given URL
# doesn't match any other provider
# Step 1. Register embedly as a fallback
OEmbed::Providers.register_all
OEmbed::Providers.register_fallback(OEmbed::Providers::Embedly)
# Step 2. Get the resource
resource = OEmbed::Providers.get(url)

Let me know how that works out for you!
Disclaimer: I typed this whole answer (including code) in my phone. It is untested & may well contain typos :smiley:


IGAPP-289: Deactivate nearby city feature

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword IGAPP.

Merge in main :)


Cannot change Admin of the Admin portal after deployment

We are trying to figure out (based on documentation etc) that post-deployment, after admin of SaaS acc. left company, how can the Azure global admin recover the access and add additional users to the SaaS accelerator admin portal?
I cannot find the users in the config file, is it in the database?

Hi @rgaborgithub1 , yes please see the database

Closing this for now, Please re-open for any followup.


How well does PCL perform on Atari?

Have you tested PCL on Atari Environments?

No, I haven't. I would appreciate it if anyone could try that and report the results.


multibranch releases convert semver version to pep440 version

Hello, i use multibranch releases to create alpha python packages, here my pyproject.toml config:
[tool.semantic_release]
logging_use_named_masks = true
tag_format = "v{version}"
commit_parser = "angular"
commit_message = "chore(release): release v{version} [skip ci]"
remove_dist = true

[tool.semantic_release.remote]
domain = "dev.azure.com"

[tool.semantic_release.changelog]
exclude_commit_patterns = [
    "^wip :.*",
    "^Merged PR.*",

]

[tool.semantic_release.branches.main]
match = "main"
prerelease = false

[tool.semantic_release.branches.develop]
match = "develop"
prerelease = true
prerelease_token="rc"

[tool.semantic_release.branches.feature]
match = "^feature/.*$"
prerelease = true
prerelease_token = "alpha"

[build-system]
requires = ["pdm-backend"]
build-backend = "pdm.backend"

dynamic = ["version"]
[tool.pdm.version]
source = "scm"

When i'm on a feature branch i use : semantic-release -vv version --push --no-vcs-release --no-changelog --build-metadata $(git branch --show-current) to generate my feature alpha version in order to avoid conflict with other developer who start from the same version as i , however when i push the generated wheel to artifact it convert  v0.1.2-alpha1+abcd to  0.1.2.a1 , so another developer who create his branch starting from the same version v0.1.1 would have the same python package version as i and can't deploy his package to artifact since the version already exists
Is there any solution to avoid this conflict , i tried to insert the version package in the pyproject.toml file using version params but the generated version does not respect pep440 format (0.1.2.a1+abcd), so the current version will point at it which is no good for production purpose
the idea is when building the python package it will convert v0.1.2-alpha1+abcd to 0.1.2.a1.devabcd or something like this

@intex46, thank you for posting your question and rationale. I have been doing some research on the request and should have an answer for you shortly.

@intex46, first thing to note is that both the wheel builder and PSR are adhering to PEP440 format.
The version scheme you describe falls under the category of Local Version Identifiers. Local identifiers allow for build metadata to be appended to the version via a +.  This is what PSR is doing when it stamps the version into pyproject.toml. Given the intent of build metadata, this is the correct behavior of PSR.
Since the build metadata is not allowed in Public Version Identifiers, the wheel build drops it upon build. This is also correct behavior.
There isn't anything you can change inside of PSR, but to still accomplish your workflow, I would recommend modifying the build command that you supply PSR to call an internal script or sed command that will convert the + to a . in the version number field of pyproject.toml. This script would enable PSR to stamp the version in and then next prior to the wheel build, change the version number to a public version identifier, which the wheel build will maintain.


Domain activation is Failed - Blocking redirect setup

App Id: d4mj1ixh7pviq
Region: us-east-1
Step: Domain activation
Status: Failed
Issue/question
My website with custom domain is up on AWS Amplify. I am now trying to configure my redirects so that I can route my SPA using Reach Router. The flavors of redirects I have tried without success are:

200 rewrite in "Redirects for Single Page Web Apps (SPA)"
previous original & target address w/ 302 Redirect permanent
previous original & target address w/ 302 Redirect temporary
previous original & target address w/ 404 Rewrite
previous original & target address w/ 404 Redirect
also tried each of the previous but placed above the OOTB custom domain -> www redirect

Amplify is telling me one or more of my CNAME's is already in use. And failing custom domain setup on stage 3: "Domain activation". This is confusing because like I mentioned above, my website is available at my custom domain and I can even push new changes that show up after CD.
Can someone help me troubleshoot this issue so that domain activation succeeds and I can configure my redirects properly?
Error message
One or more of the CNAMEs you provided are already associated with a different resource.
Additional information
Yes, I've clicked the "Retry" button a billion times.

@jknapp25 thanks for reporting, we have an issue with the retry button (#512) so the only way to retry for now is to delete the custom domain, wait a few minutes and recreate.
Just making sure that the 200 rewrite you mentioned you tried was the 200 rewrite rule mentioned under the section "Redirects for Single Page Web Apps (SPA)" in the docs?
Regardless, setting up redirects/rewrites is a different process than setting up the custom domain. It looks like you successfully setup www.yourdomain.com as well as the alias record to redirect your apex to www, it looks like something might have happened on our end that's causing that Domain Activation error to show so we'll investigate that. You can likely ignore the Domain Activation error or if it's not too disruptive, delete the custom domain, wait at least 10 minutes, and recreate it.
Let us know if the SPA rewrite suggestion above doesn't help.

I deleted custom domain, waited 30min, then re-added. Domain activation failed again.

@jknapp25 I just noticed you already have an Amplify app in us-east-2 using the domain which is what's causing the exception.

Really? I only see one app in the Amplify console...

@kahdojay are you still available to help on this issue?

@jknapp25 I believe you may be looking in us-east-1, but the other Amplify app is in us-east-2.  Change your region and let us know if you see the app there.

YES!!! Removing the domain on the app located on us-east-2 worked! Thank you so much!

And now my client side routing is working as well!


Integrated Oscilloscope in TNC640

Hi,
Commenting on that quoted part in one of your replies:

first, regarding your comment with connection to the TNC640: I was referring to the TNCopt software. I used it to connect to a programming station while capturing the TCP packages. Up to a certain point I could follow the data but then some encrypted password was used. This is similar/the same as when recoding the connection between TNCscope and a TNC640. Until we manage to reverse the encryption I don't see any way to make it work.

Did you find any way to decrypt the data in TNC640?
Could you try any AI assistance like Chatgpt, google bard, or Microsoft Bing AI?
Probably one of them may help.

@Md-aliy7 no, I haven't been able to make any progress in decoding the data. I will try your recommendation but I don't have any experience in using these LLM's. Still, it is worth a shot.
Will let you know if I make any progress.

I am also trying to figure out how it was encrypted.
Here I share some packets for specific values (3000 & -3000) mm/min
and (5000 & -5000) mm/min.
The highlighted parts include these specific values:
-specific_numbers.pdf

From what I could notice,
each value reading consists from 16 bytes like (0xdc, 0x05, 0x00, 0x00, 0x00, 0x70,
0xa7, 0x40).
The last two bytes represent the sign of the readings:
If it's positive, they become 0x40
If it's negative, they become 0xc0

Investigation.zip
This capturing is good for diverse situations of two variables (position and velocity in x axis).
It shows when one of them is fixed or changes, how the other changes.

The SDK file among what I have sent to you before, I noticed this if it can help:

From Chatgpt:
In the context of password encryption using PWEncryptionKey, the interpretation can be as follows:
peer0_33 (R_CI): This could represent a command or signal from the client (peer0) to the server (peer1) to initiate a client interaction. The string "R_CI" might stand for "Request Client Interaction."
peer1_33 (S_CI): This could be a response or acknowledgment from the server (peer1) to the client (peer0) regarding the client interaction request. The string "S_CI" might stand for "Signal Client Interaction."
peer0_34 (C_OP): This could represent a command or signal from the client (peer0) to the server (peer1) to perform an operation. The string "C_OP" might stand for "Client Operation."
peer1_34 (T_OK): This could be a response or acknowledgment from the server (peer1) to the client (peer0) indicating that the operation was successful. The string "T_OK" might stand for "Transaction Successful" or simply "OK."
peer0_35 (R_O ): This could represent a response or acknowledgment from the client (peer0) to the server (peer1) regarding an operation. The string "R_O" might stand for "Response Operation." The additional characters after "R_O" could be encrypted password data.
peer1_35 (S_O mm ): This could be a command or signal from the server (peer1) to the client (peer0) to perform an operation. The string "S_O" might stand for "Server Operation." The additional characters "mm" could represent encrypted password data or some parameter related to the operation.
peer0_36 (C_OP): This could represent a command or signal from the client (peer0) to the server (peer1) to perform an operation. The string "C_OP" might stand for "Client Operation."
peer1_36 (T_OK): This could be a response or acknowledgment

In typical connection between TNC640 & TNCscope:

Thanks for the data and your research so far. I also found some of the relations you mentioned.
From what I found, the encryption uses the key number, the current date and the random value read from the control. What I haven't been able to determine how these values are mixed together.
At least the encrypted data isn't compressed or anything. The package header (S_OD in this case) isn't encrypted and the length of the data also matches what is expected. The data on the other hand is encrypted.

A professional will probably have more success than us poking around in the dark. You might also add that one part of the key is the date as well as a secret key sent by the control.
One thing that makes me a bit worried is the current story between Nintendo and the folks of the dolphin emulator. I don't want to get into any trouble with Heidenhain for including the encryption stuff directly into pyLSV2. I am trying to think of a way on how the actually en/decryption code is part of the user application while the library only offers some way to plug in these functions. I will think about how this might be achievable...


Optimize website load time

Describe the bug
The website experiences slow load times, particularly on pages with numerous images and JavaScript files. This leads to delayed content display, causing a subpar user experience.
To Reproduce
Steps to reproduce the behavior:

Go to the homepage or any content-heavy page .
Inspect load times in the browser's Developer Tools under the "Network" tab.
Observe the sequential loading of large images and unoptimized scripts, leading to increased load time.
Notice that the page takes several seconds to display content fully.

Expected behavior

Minify HTML, CSS, and JavaScript to reduce file sizes.
Implement Lazy Loading for images and videos to load content as needed.
Defer Non-Critical JavaScript using defer or async attributes.
Preload Critical Resources to prioritize loading key assets.

Screenshots
Additional context
The website does not currently implement browser caching, lazy loading, or script deferral, all of which could significantly reduce load time.

hey @ANSHIKA-26 isnt it level-2 ?

@ANSHIKA-26  is it possible to add level 2 ?


Manual examples for unit tests

Unit testing in this repo is made using randomized testing. This procedure has been great so far, being able to catch a number of cases at least I would never consider doing manually. However it has the drawback of disabling something useful about unit tests, which is its ability to explain what a function does "by example", by reading the unit tests .
This PR tries to enable this here, by adding some explicit test cases in addition to the randomized unit tests. The test cases happened to be found by randomized unit testing, but that is irrelevant.
Note that this orthogonal to the existing e2e tests, since here we still test one "unit" at a time.
For some reason I can't recall, there is a small refactoring of the order.index, previously an integer, to an order.id which is now an hash.

Can you explain your approach to the unit testing? I can't follow.
I see how you are generating "inputs" for the different functions, but then how is the output checked? Is the "output" just a fail or non-fail?
At least for the handcrafted inputs, I would expect also a hand-crafted output. Or is this solely left to e2e tests?

Sure, sorry I didn't made it clear in the first place.
Take for example the file  tests/unit/amount_test.py which tests the function that executes a set of orders of a token pair given a known xrate. There is a function in the test file that receives as parameters an instance, calls the function being tested, and does a series of assertions about the solution. The test fails if these assertions fail (they are done inside the "validate" function).
The instance that is tested may be generated randomly, or it can be one of the "explicit" instances in  the file  tests/unit/amount_test_examples.py. These "explicit" instances were carefully chosen so that they will fail the assertions in case some important funcionality is missing, such as handling the minimum tradable amount constraint.
Makes sense?

and, most importantly, the expected outcome for a certain function

Yes, I thought about it, but I arrived at the conclusion that is complex enough that we can't validate the output of the function "by hand", unless the examples are so simple that they really do not test anything.

One drawback that I see with your testing is that: your functions could return trivial solutions and then all the validation tests pass easily.

That is a good observation. While I don't know how to do this for the function that tests the amount execution given a fixed rate directly, I have some local tests that I intend to push later that test if the best xrate found is indeed the optimal, by searching numerically for better xrates using a brute force algorithm. Since that function uses the one that executes orders, the bug that always sends the trivial solution  would be catched. Of course, this is no longer "strict" unit testing :)


Add more platforms to MediaQueryData.alwaysUse24HourFormat's documentation

Currently alwaysUse24HourFormat's documentation only discusses what happens on iOS and Android. This should also include desktop platforms (Windows, macOS, Linux) as well as whatever happens on Web. Looking through the engine code for the web, it seems like it's always set to false unless I'm missing something.
For reference, here is the current documentation:

Whether to use 24-hour format when formatting time.
The behavior of this flag is different across platforms:

On Android this flag is reported directly from the user settings called "Use 24-hour format". It applies to any locale used by the application, whether it is the system-wide locale, or the custom locale set by the application.
On iOS this flag is set to true when the user setting called "24-Hour Time" is set or the system-wide locale's default uses 24-hour formatting.

Here's the link, for future reference: https://main-api.flutter.dev/flutter/widgets/MediaQueryData/alwaysUse24HourFormat.html


Default to the new Amazon NTP service on our AMIs

As of today, AWS automatically provides NTP over the unroutable <IP_ADDRESS> address, so I think we should just default our NTP settings to point there for our AMIs.
@edolstra any objections?

Note this won't work (yet) on C5 or M5 instance types.


KOGITO-6170 Remove forced maven dependencies for Codestart

https://issues.redhat.com/browse/KOGITO-6170
follow-up of:

https://github.com/kiegroup/kogito-runtimes/pull/1668#issuecomment-948478908
https://github.com/quarkusio/quarkus/pull/20933

with

https://github.com/kiegroup/kogito-runtimes/pull/1446

now available,
these versions can be removed; showing local test:

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

Run all builds
Please add comment: Jenkins retest this

Run (or rerun) specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] tests

Quarkus LTS checks
Please add comment: Jenkins run LTS

Run (or rerun) LTS specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] LTS

Native checks
Please add comment: Jenkins run native

Run (or rerun) native specific test(s)
Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] native

Full Kogito testing (with cloud images and operator BDD testing)
Please add comment: Jenkins run BDD
This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

GHA are green, Jenkins are not.
🤷
Jenkins retest this

All green (except GHA kogito-apps, unrelated). Merging.


Implement/derive Debug for public types

Is your feature request related to a problem? Please describe.
It is convenient to expose a Debug method on all types that are public in order to make interaction with the outside easier. Some repository types like TestSequencer
https://github.com/dojoengine/dojo/blob/89a5b9eb31a32e58a0429b7d17151361cb09f746/crates/dojo-test-utils/src/sequencer.rs#L29-L35
for example do not have this implementation provided.
Describe the solution you'd like
I think we should enforce the Debug implementation for all types made public. To facilitate this and be sure of the long-term continuation of this good practice, we could add the following lint https://doc.rust-lang.org/stable/nightly-rustc/rustc_lint/builtin/static.MISSING_DEBUG_IMPLEMENTATIONS.html to the Clippy script so that a rule violation is automatically detected by the CI.

hello @tcoratger, i would love to work  on this

hello @tcoratger, i would love to work on this

Do you have any question @g4titanx before starting on this?

[ ] add the clip check.
[ ] derive Debug on public type. You may try to add a commit for each crate to ensure easier revision.

yeah, can you elaborate the clip check issue

clippy check sorry, just reworded it. As mentioned by @tcoratger the idea is to ensure the linting step of the CI can detect a missing Debug on a public type.

yeah, can you elaborate the clip check issue

clippy check sorry, just reworded it. As mentioned by @tcoratger the idea is to ensure the linting step of the CI can detect a missing Debug on a public type.

@g4titanx Yes, this check does this job for example: https://github.com/paradigmxyz/reth/blob/bd4757b3b53022f871872790c27aa571d2ec2fdb/Cargo.toml#L96

yeah, can you elaborate the clip check issue

clippy check sorry, just reworded it. As mentioned by @tcoratger the idea is to ensure the linting step of the CI can detect a missing Debug on a public type.

okay, great!
i would reach out to you if I need more explanation

yeah, can you elaborate the clip check issue

clippy check sorry, just reworded it. As mentioned by @tcoratger the idea is to ensure the linting step of the CI can detect a missing Debug on a public type.

@g4titanx Yes, this check does this job for example: https://github.com/paradigmxyz/reth/blob/bd4757b3b53022f871872790c27aa571d2ec2fdb/Cargo.toml#L96

yeah, I would used this as a reference

oh by the way, do you mean to implement #[derive(Debug)] for all pub types in the project or just in dojo/crates/dojo-test-utils/src/sequencer.rs

yeah, can you elaborate the clip check issue

clippy check sorry, just reworded it. As mentioned by @tcoratger the idea is to ensure the linting step of the CI can detect a missing Debug on a public type.

@g4titanx Yes, this check does this job for example: https://github.com/paradigmxyz/reth/blob/bd4757b3b53022f871872790c27aa571d2ec2fdb/Cargo.toml#L96

yeah, I would use this as a reference

I would say, if possible, this is better to apply this rule for the entire project.

okay, great!

hey man! i have fixed this issue on my PC but I am having issue compiling as I am using a low ram computer. you can unassign me as I have tried every means to make this. i used a devcontainer too

hey man! i have fixed this issue on my PC but I am having issue compiling as I am using a low ram computer. you can unassign me as I have tried every means to make this. i used a devcontainer too

Arg.. sorry to hear. You can specify a package if you want to limit ram consumption using the -p option while using cargo build or cargo run.
Also, do not hesitate to open the PR, this will help anyway. Appreciate your time and effort on this.

@glihm you know, i thought of writing a script to find all pub types and automatically add #[derive(Debug)].
found out that would save a lot of time but I couldn't even compile the code properly because of the size
I created a PR tho: https://github.com/dojoengine/dojo/pull/2016
I was having trouble making some pub types impl the debug trait


enableSched setting defined as "enablesched" in savedsearches.conf

Hi team,
Just noticed that when running contentctl build, the enableSched setting in savedsearches.conf gets copied as "enablesched" in the resulting app. Splunk appears to ignore this setting and detections don't get scheduled. What's weird is that the template file for this file appears to have the setting correctly cased, but it is still created incorrectly as part of the build process.

My apologies - this is an issue I introduced myself with a post-build Python script using the configparser module. I was able to validate that this doesn't occur just by running the contentctl build command. Closing issue.


SimpleDialog doesn't clip on rounded corners

Steps to Reproduce

Use SimpleDialog
As shape:put RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(50))),

and you'll see the simpleDialog doesn't clip/cut the rounded corners. Not even clipping it manually as shown in the min repro code works.
Expected results:
Title's first four letters Titl should be cut according to the cut corner. So should the last items (Item 43 - Item 45).
Actual results:

Min Repro Code

import 'package:flutter/material.dart';
import 'dart:ui';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Container(
        child: Center(
          child: RaisedButton(
            onPressed: () => buildShowDialog(context),
            child: Text('click to show dialog'),
          ),
        ),
      ),
    );
  }

  Future buildShowDialog(BuildContext context) {
    return showDialog(
      barrierColor: Colors.pink.withOpacity(0.8),
      context: context,
      builder: (context) => BackdropFilter(
        filter: ImageFilter.blur(sigmaX: 20, sigmaY: 20),
        child: ClipRRect(
          borderRadius: BorderRadius.vertical(bottom: Radius.circular(100)),
          child: Container(
            decoration: BoxDecoration(
              color: Colors.orange,
              borderRadius: BorderRadius.all(Radius.circular(30)),
            ),
            child: SimpleDialog(
              titlePadding: EdgeInsets.zero,
              contentPadding: EdgeInsets.zero,
              backgroundColor: Colors.white,
              title: Text('title'),
              shape: RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(50))),
              children: List.generate(80, (index) => Text('Item $index')),
            ),
          ),
        ),
      ),
    );
  }
}

Flutter doctor -v

[✓] Flutter (Channel beta, 1.25.0-8.3.pre, on macOS 11.1 20C69 darwin-x64, locale es-ES)
    • Flutter version 1.25.0-8.3.pre at /Users/tomas/code/flutter
    • Framework revision 5d36f2e7f5 (7 days ago), 2021-01-14 15:57:49 -0800
    • Engine revision 7a8f8ca02c
    • Dart version 2.12.0 (build 2.12.0-133.7.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tomas/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.10.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (2 available)
    • iPhone 12 Pro Max (mobile) • 8C220755-03E5-4DF9-A15E-841FEAC7D52F • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

CC @shihaohong

CC @shihaohong

This issue has NOT been fixed.

 flutter doctor -v
```
[✓] Flutter (Channel beta, 2.0.1, on macOS 11.1 20C69 darwin-x64, locale es-ES)
    • Flutter version 2.0.1 at /Users/tomas/code/flutter
    • Framework revision c5a4b4029c (12 days ago), 2021-03-04 09:47:48 -0800
    • Engine revision 40441def69
    • Dart version 2.12.0
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at /Users/tomas/Library/Android/sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.3, Build version 12C33
• CocoaPods version 1.10.0
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] VS Code (version 1.54.3)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.20.0
[✓] Connected device (2 available)
• iPhone 12 mini (mobile) • 7BBA6B7C-8A33-48B1-9EEC-49BEA3273F00 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
• Chrome (web)            • chrome                               • web-javascript • Google Chrome 89.0.4389.82
• No issues found!

</details>

My mistake. It IS fixed. clipBehavior must NOT be set to default none — and it will work :)
Cheers!


Initial implementation of QIR Runtime

Please see readme.md in src/QirRuntime folder for details on the structure of the project and how to build/test it.
Using a non-feature branch for this review to allow for quick turnaround on PR feedback. When done with the PR we can switch the branch to become a feature branch, subject to the corresponding policies.
@bettinaheim, please add other reviewers as appropriate.

One more idea I forgot to include in the review: might it be worth renaming the code in the experimental folder to something other than Ionq*? I know that was the inspiration, but especially if we decide to align that with the new target packages, it can just be a sample of a generic target implementation and does not have to be tied to a specific provider. Food for thought, and not something that I imagine has to be decided on/address as part of this PR.

There are a few elements that I have questions on and/or would like to have follow up conversation regarding, but I really like the structure and design overall. Thanks for all this work; I'm exciting to see it get in and continue to develop/iterate!

Thank you for the review! Please feel free to reactivate any of the comments if you'd like to follow up on any of them. For design decisions without immediate solutions, I can either add a corresponding section to the readme or, maybe, log issues?

For design decisions without immediate solutions, I can either add a corresponding section to the readme or, maybe, log issues?
That's a good question... I think logging issues for design discussion/integration work is probably the way to go, though they will be a little tricky to capture as an issue since they are not a bug with current functionality nor a discrete feature request for new behavior in the product. I leave it to your judgement how you want to summarize for the issue, but the main thing I know I'm interested in tracking is the opportunities for continued revision of this API along with the target packages and the code generation @alan-geller is working on. Each of those pieces is trying to define a view of the same concept: what are the native capabilities of this target (hardware or simulator) and how does Q# call into them? Getting those to line up well will make all of this work nicely together, I'm just not sure yet which adjustments need to be made to which pieces yet!

CodeFlow for GitHub does not download executable files. If you trust this file and would like to run it, please download it yourself through GitHub.

these files should not be committed and should be generated as part of the build.
if you do want to keep these files please add a README.md explaining why they are here and how to update them.

Refers to: src/QirRuntime/externals/QuantumSimulator/libMicrosoft.Quantum.Simulator.Runtime.dylib:1 in 7eb68d5. [](commit_id = 7eb68d53fefc50b49b68fa7b8544eb1ec6a3d08d, deletion_comment = False)


Adds labelling to the underlying gateway instances.

Adds a variable for instance labels now that the MIG module supports labels on its Instance Templates.

@prodriguezdefino I want to merge your changes.
I was trying to rebase your branch and somehow closed the PR on accident. Can you re-push the commit to reopen this PR?

Also, I have your change on my branch here: https://github.com/danisla/terraform-google-nat-gateway/tree/add-instance-labels
In general, it's easier to merge changes if you do them on a branch rather than on your master.
I can just merge my branch if you want as well.

just merge your branch, thanks for adding this!

No problem, thanks so much for the contribution!


rpi-basic rpi-firewall: workaround aports RPi build breakage

The aports change in commit 9a78244 seems to have broken the mkimg.sh builds for Raspberry Pi profiles, at least under arch-chroot-install.
After that commit, see this error in our builds:
bootstrap/armv7/enter-chroot -u imagebuilder \
        /home/brad/projects/infra/alpine-homelab-bootstrap/bootstrap/shared/aports/scripts/mkimage.sh \
        --arch armv7 \
        --profile rpi_basic \
        --outdir /home/brad/projects/infra/alpine-homelab-bootstrap/bootstrap/shared \
        --repository https://dl-cdn.alpinelinux.org/alpine/v3.15/main \
        --extra-repository https://dl-cdn.alpinelinux.org/alpine/v3.15/community
OK: 0 MiB in 0 packages
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/main/armv7/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.15/community/armv7/APKINDEX.tar.gz
v3.15.0-258-gd5d32e35cf [https://dl-cdn.alpinelinux.org/alpine/v3.15/main]
v3.15.0-256-g047dab5823 [https://dl-cdn.alpinelinux.org/alpine/v3.15/community]
OK: 15419 distinct packages available
>>> mkimage-armv7: Building rpi_basic
>>> mkimage-armv7: --> rpi_config efccd2fd6481f8406afef352868b4480ae4b6652
>>> mkimage-armv7: --> rpi_blobs
gzip: invalid magic
/bin/tar: Child returned status 1
/bin/tar: Error is not recoverable: exiting now

First failing build was on Feb 5.  Previous build, on Jan 15, completed without issue.

bors r+

bors r+

bors r+


Update cloud version yaml

config yaml was out of date since 23.1 made it to cloud

not sure why all those links are broken :/

@gemma-shay Taking a look now!


Hystrix filter built with RouteLocatorBuilder breaks Spring Cloud Gateway

I am new to Spring Cloud Gateway and started with some basic examples using 2.1.0.RELEASE. They were working well until I tried adding a Hystrix filter and all my routes failed to be registered in the DispatcherHandler. The issue was repeatable. I even started over from scratch and easily recreated the issue.
Here is the code that broke the gateway. The code works without the filter and nothing works with the filter.
    @Bean
    public RouteLocator customRouteLocator(RouteLocatorBuilder builder) {
        return builder.routes()
                .route("path_route", r -> r.path("/get")
                        .uri("http://httpbin.org"))
                .route("host_route", r -> r.host("*.myhost.org")
                        .filters(filter -> filter.hystrix(c -> c.setName("slow-command")))
                        .uri(uri))
                .build();
    }

I checked my code into Git Hub with a more detailed description in the README, wstrater/spring-cloud-sample. Hope that is alright but I figured having the full description with the code would be the most helpful.
Thanks, Wes.

For Boot 2.1.0.RELEASE please use Greenwich.BUILD-SNAPSHOT

Thanks. Got it working and pushed my changes.


Delete duplicate dependencies from package.json and aligned Gruntfile

Coverage remained the same at 90.526% when pulling bc578c1ff15cbde07ac67efb825c797a2b7207b2 on cleaning into 111149f2b29d79c49527256677840acf714e2f94 on master.


GraphQL Support?

Issue summary
What happened to GraphQL support in version 10? There used to be a rake task for downloading the latest schema, but that seems to have disappeared.

shopify_api version: 10.x
Ruby version: any
Operating system: any

Expected behavior
This stuff should be documented.
Actual behavior
This stuff is not documented.
Steps to reproduce the problem

Try to upgrade an existing app from v9 to v10.
You're gonna have a bad time.

not stale

Hi @jagthedrummer,
We have removed our dependency to GraphQL client, so you no longer have to download schemas to download the schema to use GraphQL with our Admin API. The GraphQL references on shopify.dev would be your best resource on our admin GraphQL schema, with examples and documentation.
We recently added more detail to our documentation, and here are some quick links to our references:

Breaking change notice for version 10

This includes what's new, a more comprehensive upgrade guide and usage documentation

Making GraphQL API calls

Making API calls with GraphQL Admin Client

Custom Apps

Small guide on how to construct a session object to be used for making authenticated API calls for custom apps if you already have an API key.

You can see a list of all documentation we recently modified

Closing this ticket now that there are improvements made to the docs. Feel free to open other tickets for specific issues you encounter and we'll try our best to answer your questions. Thanks everyone!


New package: Causal v1.0.0

Registering package: Causal
Repository: https://github.com/zekeriyasari/Causal.jl
Created by: @zekeriyasari
Version: v1.0.0
Commit: b10a9b494ee4e33d01e67396742ee4f2c1804b43
Reviewed by: @zekeriyasari
Reference: https://github.com/zekeriyasari/Causal.jl/issues/37#issuecomment-678625970

yes


Update Saxon version to <IP_ADDRESS>

This fixes #107.

(FYI I created a Huginn agent to inform me about updates in the future.)


Expose collector ports in docker images

Which problem is this PR solving?
Resolved #4808
Description of the changes

Expose OTLP gRPC and HTTP Collector ports in all-in-one Docker image.
Expose all collector ports in collector Docker image

How was this change tested?

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[x] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

do you want to fix cmd/collector/Dockerfile too? It's missing most ports

Shall I expose all collector ports in the collector docker file as part of this PR?

do you want to fix cmd/collector/Dockerfile too? It's missing most ports

done

thanks 🎉


Card not displaying dropdown

Hi!
The card is not displaying the drop down to select the device. I did try adding the deviceID and device_name without success.

In your HA 'Devices & Services' page, do you see your iParcelBox as a discovered device?  If not, please can you check your logs when HA starts to see if there are any errors showing? You may need to turn on debugging for the iParcelBox-HA integration first (I'm assuming you've already installed that from https://github.com/gadget-man/iparcelboxHA)

The integration is ok, I can see the device and control it

Strange. Your card seems to be missing the dropdown to select the device from a list.  Please can you try a full restart of HA and check the logs both during start and when you add the card to see if anything shows up?

I will try a few things as I running a beta version of HA and I'll check the logs.
I installed it on another instance I have running and it works as expected so I'll close this.
Sorry for wasting your time!


Even more keyboard control!

This PR addresses this issue.
I couldn't wait to do it, so I did...
I implemented all the things I suggested, except for the triple click one.
I also added listeners for left/right arrow keys, clicking on those will move between network details tabs.

This is cool. 👍

Closing as stale


ARM64 build: it would be good at least to be buildable

Hi!
I've tried to just build on Raspberry PI 4b, on Ubuntu 20.04
$ uname -a
Linux ubuntu 5.4.0-1032-raspi #35-Ubuntu SMP PREEMPT Fri Mar 19 20:52:40 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux

$ gcc --version
gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0
Copyright (C) 2019 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ cat /proc/cpuinfo
processor	: 0
BogoMIPS	: 108.00
Features	: fp asimd evtstrm crc32 cpuid
CPU implementer	: 0x41
CPU architecture: 8
CPU variant	: 0x0
CPU part	: 0xd08
CPU revision	: 3
...

Hardware	: BCM2835
Revision	: c03112
Serial		: 100000007c08a3a6
Model		: Raspberry Pi 4 Model B Rev 1.2

with simple make build && cd build && cmake .. then make
That tiny naive try immediately failed with absence of 'immintrin.h'
I've tried a little digg and replaced line from 'common.h' about immitrin.h to
//#include <immintrin.h>
#  if defined(__ARM_NEON)
#    include <arm_neon.h>
#  elif defined(__WINDOWS__) || defined(__WINRT__)
/* Visual Studio doesn't define __ARM_ARCH, but _M_ARM (if set, always 7), and _M_ARM64 (if set, always 1). */
#    if defined(_M_ARM)
#      include <armintr.h>
#      include <arm_neon.h>
#      define __ARM_NEON 1 /* Set __ARM_NEON so that it can be used elsewhere, at compile time */
#    endif
#    if defined (_M_ARM64)
#      include <arm64intr.h>
#      include <arm64_neon.h>
#      define __ARM_NEON 1 /* Set __ARM_NEON so that it can be used elsewhere, at compile time */
#    endif
#  endif

it also fails with huge bunch of errors about non-declared '_mm_storeu_si128', '_mm_loadu_si128', '__m128i', and many others.
So, there are some obvious questions from it:

Is it possible to build on that platform? (AFAIK that is not only RPi, but new Mac on M1 also might be targeted, that is more serious!)
If it is possible - is any instructions available?
If it is not possible with hardware intrinsic - is any legacy way possible - let it works not so fast at all, as a pure 'stub', but at least would be buildable, so that consumers of the lib can also be usable?

Under "Hardware Requirements", we have 'We require an x64 platform.'
A port to ARM would be great. Pull request invited.


We should include the oldIE fix in the D-ib rule

The tool output this for D-ib:
#atomic .D-ib {
  display: inline-block;
}

instead of:
#atomic .D-ib {
  display: inline-block;
  *display: inline;
  zoom: 1;
}

Closed in favor of issue #80


Links containing hash anchor tags in URL not supported

Aurelia router does not seem to allow a URL that has a link location suffix like http://localhost:3000/products#middle.  Note I assumed it was mandatory to implemented pushState (http://aurelia.io/docs.html#configuring-push-state), which eliminated the starting # in the URL.  Below are some cases that indicate the #middle is confusing the router.
Experiments
(PASS) Enter browser URL http://localhost:3000/products then add #middle
-Probably because router is not re-invoked for #middle addition.
(FAIL) Follow a anchor href link to http://localhost:3000/products#middle
Chrome console: ERROR [app-router] Error: Route not found: /products#middle(…)
-Primary issue which prevents building links for say a "Table of Contents".
(FAIL) Enter browser URL http://localhost:3000/products#middle
-Brings up products page correctly, but at the top of the document.  This is probably related to asynchronous page load.  Perhaps a javascript LoadDone function will have to search for hash and then scroll to anchor.  It would be nice if Aurelia magically made this work as well.

I think what we should do for this is pass the hash as a separate property to the route handler so it can be exposed to activated modules as needed. We need to be able to provide an object to the route handler anyways for #243.

+1

+1

+1

👍

I'm trying to deep link to Bootstrap tabs in my page. Tried taking the tab name hash tag as an optional parameter to my route:
route: ["view", "view/:tab"]

But the router doesn't give me the tab parameter value in the activate() method of my component if I deep link to a tab like:
/view/#details

Would be good to fix this issue.

We're trying to handle a successful OpenID Connect authentication response. Is this bug also responsible for preventing the Aurelia Router from handling the following?
  HTTP/1.1 302 Found
  Location: https://client.example.org/callback/#
    access_token=SlAV32hkKG
    &token_type=bearer
    &id_token=eyJ0 ... NiJ9.eyJ1c ... I6IjIifX0.DeWt4Qu ... ZXso
    &expires_in=3600
    &state=af0ifjsldkj

following configuration works but without pushState:
Buttons

Buttons

the test url is #/home/controls and the anchor is /buttons'. Works both when clicking the link and when /buttons' added in address bar: http://localhost:9000/#/home/controls/buttons

How should hash anchor links generelly work with pushState and a base-tag?
A simple anchor link in /app/view1 like
...

will never work with the suggested pushState approach because this approach also requires a <base> tag in the head.
For this anchor to work, it needs to be prefixed with the current path, i.e. /app/view1#anchor1. Does Aurelia provide any facilities to rewrite such anchor links correctly? What is the best practice to deal with anchor links?

@bryanrsmith do you happen to know if there's a work around in place for the issue @Mobe91 is describing?

So @Mobe91 I ended up doing the following, though I'm not sure it'll work for your case it worked well for me.
In my viewmodel I added this funciton
scrollToElement(elementId){
document.getElementById(elementId).scrollIntoView();
}
In the view I removed my href and replaced it with this.
click.delegate="scrollToElement('app-highlights')"
Hope this helps someone
--Steve

wow, this has been open for 5.5 years  :-)


Add documention for injected 'args' param option

(Describe the goal of this PR. Mention any related Issue numbers)
Category

[X] slack_bolt.App and/or its core components
[x] slack_bolt.async_app.AsyncApp and/or its core components
[ ] Adapters in slack_bolt.adapter
[ ] Document pages under /docs
[ ] Others

Requirements

[X] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[X] I've read and agree to the Code of Conduct.

This pull request adds to the docstrings of the Args class the fact that you can use a parameter named 'args' to receive an instance of the Args class (linking to all the other arguments), as an alternative to naming each of the requested arguments one at a time.
This functionality is already implemented in line 97 of the build_required_kwargs method in both sync and async but is not presently documented anywhere I could find. The docs themselves just link to this docstring for more info on possible injectable params, and the docstring only mentions injecting its children but not itself.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Yaakov Saxon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Is the lack of documentation intentional?
kwarg injection allows the best practice of YAGNI so that you can choose exactly which arguments are needed in each use case rather than always having a bunch of args that are (potentially; often) never used.
Similarly, a function that calls out its arguments is more clear and follows the Python zen that Explicit is better than implicit as well as Readability counts.
I'm just not sure the documentation should "promote" a less "zen" type of usage, which is why I wondered if the omission was intentional.

Hi, @YSaxon! Thanks so much for your PR! Also thank you @eddyg for posing that question - on seeing this PR, I was wondering the same thing. Since I lack the context about whether this is an intentional omission of the documentation or not, I will surface this internally to my team and then update as soon as I hear back!

(I just added a couple of commits to fix the functionality itself, after realizing it was hitting a subtle error)

I would just note that this functionality is clearly already deliberately in the code so it might as well be documented.
As to whether it's good or bad:

It isn't making the code any less efficient, as all the arguments are already being gathered into the all_available_args dict regardless of whether that is passed or not.
It can be quite useful, most notably in cases where you want to delegate the handling of a request to another method to allow more complicated request handling logic. Presently you need to do something like

def handler_1(ack, body, **unused_kwargs):
  ack()
  #handling logic

def handler_2(ack, action, context, **unused_kwargs):
  ack()
  #handling logic

@app.action(re.compile("dynamic_handler_.*"))
def delegate_to_handler(ack,body,action,client,say,respond,context):
  selected_handler=complex_logic_to_decide_which_handler_to_use(action, context)
  selected_handler(ack=ack,body=body,action=action,client=client,say=say,
                   respond=respond,context=context)

There also isn't any good way to specify a valid handler if you have some method to register them dynamically and if you forget to add the **unused_kwargs parameter to one of them, it will receive extra parameters and die.
Whereas if you use the args approach, you can do this:
def handler_1(args:Args):
  args.ack()
  #handling logic

def handler_2(args:Args):
  args.ack()
  #handling logic

@app.action(re.compile("dynamic_handler_.*"))
def delegate_to_handler(args:Args):
  selected_handler=complex_logic_to_decide_which_handler_to_use(args.action, args.context)
  selected_handler(args)

And then to specify a legal handler is very simple, it's just a Callable[[Args],...]

Thanks for providing the example use case! 👍
This definitely makes it more clear why knowing that this functionality is available would be a useful addition to the docs.

@YSaxon The pull request alreay looks great to me. Can you check @CLAassistant's mesage above? It seems that you're not using the email adress associated with your GitHub user account for the commits. git configure user.email (your email here), git reset HEAD~3, git add ., git commit -m"your comment", and then git push your-fork main -f should resolve the issue. If you have never signed the CLA, you can sign in with your GItHub account.

The CI build failure with codecov is not caused by this PR. I will look into it.

Thanks for the precise instructions on how to fix the username issue

By the way, while I have you devs here, there's another issue that's been bothering me forever which I would love to submit a pull request for, but it's in the closed-source backend code, so maybe you can do it for me.
I wrote it up in some detail here
Essentially there is a problem with the text field returned with command or message events. It is inherently not a good representation of the plaintext of what a user saw when they hit enter. And whereas in message events, at least you could parse out the true plaintext from the blocks field, the blocks field is omitted entirely from a command payload (where if anything it is needed more), making it impossible to perfectly recover the plaintext.
Some suggested fixes:

Fix the text so it correctly reflects the true plaintext.
Add a true_plaintext field, if you are concerned about breaking existing programs
Just put the blocks field into the command payload, and I'll parse the true plaintext out myself

@seratch ^

@YSaxon Thanks for sharing this! I hear you and actually we've received similar feedback many times in the past. I can escalate you feedback this time, however, I don't anticipate the backend engineering teams can prioritize this kind of enhancements at least in the short term, due to priorities and other circumstances. So sorry for the inconvenience.

Ok, but please do pass to them my third suggestion in particular, putting the blocks field into the command payload, as I very strongly suspect that this can be done in seven characters on a single line of code somewhere (adding blocks, to the list of fields being sent) with no side effects anywhere else.

Hi @YSaxon, we apologize for the inconvenience, but we kindly ask that you sign our new CLA: https://cla.salesforce.com/status/slackapi/bolt-python/pull/893
As it is not fully compatible with the previous agreement you signed for this PR, we need your signature once again. Your cooperation and prompt response would be greatly appreciated.


efr-pk-pbj-manager

query filter packinglist transfer stock

Coverage increased (+0.001%) to 34.594% when pulling e1061b48e7ae5a49c578a7a167510690592f72f8 on andibateeq:dev into 96e827bfd4098ce55071bd2a6fa921edcfff2e9b on danliris:dev.


store methods do not call back on db error

error handler should cb?

I am noticing this as well. I'm using unique indexes to prevent duplicates. I can't catch the "MongoError: E11000 duplicate key error". After a few seconds I get a timeout.

I just added the missing callback call in my pull request. The unit tests still have to be extended to cover error scenarios.


ingress.class is being ignored

Just gave 0.6 a whirl and it appears that ingress.class support is broken, I've updated the cmdline to ---ingress-class=argo-tunnel  and the controller is attempting to build tunnels for other ingresses that do not match its ingress.class, this is a log entry for my Jenkins ingress, which does not have a kubernetes.io/ingress.class defined and should be untouched by the argo controller:
time="2018-11-29T17:33:06Z" level=error msg="link exited with error (*errors.errorString) 'Server error: Failed to update CNAME', repairing ..." hostname=jenkins.<MYDOMAIN> origin="jenkins-web.jenkins:80"

interesting!

@cbuckley01 I've tagged a new release and updated the helm charts.


Display an incorrect toolbar on the original file share tab if delete snapshots from its split tab

Storage Explorer Version: 1.33.0-dev (96)
Build Number: 20240104.6
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.2(Apple M1 Pro)
Architecture: x64/x64/x64
How Found: From running test cases
Regression From: Previous release (1.31.2)
Steps to Reproduce

Expand one storage account -> File Shares.
Create a file share -> Right click the file share -> Click 'Create Snapshot'.
Switch the context view to (read-only snapshot) -> Split the tab.
Click 'View Share Snapshots' on the split tab -> Select the file share snapshot -> Delete it.
Close the split tab -> Observe the toolbar on the original tab.
Check whether displays a correct toolbar.

Expected Experience
Display a correct toolbar.

Actual Experience
Display an incorrect toolbar.

Verified this issue on the main build 20240109.2. Fixed. So, we are going to close it.


add ability to control output module settings via nexrender

Being able to set up various output modules without need to open a freshly installed after effects
https://blogs.adobe.com/creativecloud/new-changed-after-effects-cc-2014/?segment=dva

We would help with this issue, but I do not have an inkling how to go about it. Can you give a scribble of how you think this could work?

Yea, so probably the easiest way would be to use the job.settings struct to set up some values.
And in tasks/script.js probably some handler that would take those arguments, and turn them into instructions of such kind:

(taken from the example in the link)

var my_renderSettings = {
"Color Depth":"32 bits per channel",
"Quality":"Best",
"Effects":"All On",
"Time Span Duration":"1.0",
"Time Span Start":"2.0"
};
app.project.renderQueue.item(1).setSettings( my_renderSettings );

So, you are thinking about a new part in the job file renderSettings or similar?
Sounds good! I guess the possible settings can maybe somehow be scraped from here?
http://docs.aenhancers.com/renderqueue/renderqueue/
Do you know if we could influence the output format this way? Our use case was to render a single image (via employing PNG Sequence) and not a video.

I don't really know, however, I think it might be possible. Since we have access to the scripting env we can try out different new possibilities.
And something related to actual output module:
http://docs.aenhancers.com/renderqueue/omcollection/
http://docs.aenhancers.com/renderqueue/outputmodule/?highlight=setSettings
This method might be interesting:
OutputModule.saveAsTemplate()
As far as I can see quite a recent feature, and not much documentation is available online.


Require of files from other workspaces

How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Windows
What is the issue affecting?
Completion
Expected Behaviour
In VSCode with multiple workspaces, it is not possible to require files from other workspaces within a specific workspace.
Example:

From workspace/F.lua, no other Lua file (except the default ones) can be required.
Actual Behaviour
In workspaces whose names are the start of the names of other workspaces, files from the other workspaces can be required if they return something.
Example:

The name of workspace w is the start of the workspaces w1, w2, w3, w35, and workspace. Therefore, all files from these workspaces can be required (because all files return 5).

Within the workspace w3 whose name is the start of the workspace w35, w35/G.lua can be required.
Reproduction steps

Open a new folder within VSCode.
Add a new folder to VSCode to create a new VSCode workspace. The name of this second folder must be <name of the first folder><some characters>.
Create a new Lua file within the second folder which returns something, e.g., a number, string or table.
Create a new Lua file within the first folder, and type require(' within this file. The name of the file from the second folder should appear in the code completion.

Additional Notes
No response
Log File
No response

Each workspace has its own private environment.
You need use Lua.workspace.library.

In the screenshots, every directory corresponds to one LSP workspace, and the directory called workspace has its own environment as I cannot require the files from the other directories. However, in the directories w and w3, I can require files from certain other directories although it should not be possible as I did not set the Lua.workspace.library setting and want to keep the files of the directories separate. It seems that it is possible in a directory/workspace to require files from other directories/workspaces whose names equal the name of the former directory/workspace appended by a suffix. In the example, from directory/workspace w3, the files in the directory/workspace w35 can be required.


Enable universal wheels Fixes #72

Enable universal wheels Fixes #72

This has been done in https://github.com/tox-dev/py-filelock/pull/87, thanks for the contribution :+1:

This has been done in #87, thanks for the contribution 👍

Awesome thanks!


DEVENGAGE-1176: Upgraded to the latest version of the go sdk

Hey Ronan,
Here is my PR upgrading to v72 of the GO Sdk.  As you can see a number of things changed including a couple of key APIs.  Can you tell me if this looks good?  If this does not pass the smell test(like something changed with the new GO SDK), please reject the PR and open up a ticket with Michael.
Thanks,
John

Yeah, that's fine. I see one change on parameter ordering but that's an acceptable change with the openapi-generator.


Use dictation devices for audio input when available

On the client side (Electron/browser) our WebHID lib supports various dictation microphones.
When one of these devices is available as an audio source we should enforce/select usage of it for audio input.
Because we initialize the lib early and know if we have a supported device we can probably use that supported device type to select the audio source device (or even just regex match SpeechMike or PowerMic).

A poor-man's approach to this, which would support more devices, would be to allow for listening to the mic full-time, and only enabling transcription when a certain volume threshold is reached.  Maybe this is already supported by default - I think the trick would be having a timeout where after some configurable timeout (1 second)? willow would segment the recording.
The reason I call this a "poor man's dictation microphone" is that many mics have a Mute button which should drop the noise floor darn close to zero.  In that case, this could be used as a proxy for the Enable button on a "real" dictation microphone.
Apologies if my suggestion lacks context - I'm brand new to the project and still brushing up on its capabilities.  I'm very excited about this project!

This issue is intended for specific applications where users already have dedicated dictation microphones from Philips, Nuance, etc.
We have an internal desktop application that binds to a global hotkey in the OS for (basically) push to talk on any hardware. I'm not sure when (or if) we'll ever release it but one of our devs worked on it for another project and it is powered by the WebRTC support in WIS.


Fix RenderImage for Bounds not starting at 0,0

Fixes #35
When the img.Bounds() did not start at 0,0, some renderer had issues drawing the image.
Affected (and fixed) renderers: pdf, rasterizer, htmlcanvas
( svg was not affected and eps and tex do not support image rendering)

Seems to work: https://github.com/tdewolff/canvas/issues/35#issuecomment-613509185


prebuild-install bindings-v8.0.7 get 404 result

Summary of Problem
(Please answer all 3)

What are you trying to do?
trying to build win64 app in macOS

What happens?

What should have happened?
get this error

 prebuild-install http 404 https://github.com/serialport/node-serialport/releases/download/<EMAIL_ADDRESS>    prebuild-install WARN install No prebuilt binaries found (target=8.2.0 runtime=electron arch=x64 libc= platform=linux)

Versions, Operating System and Hardware

<EMAIL_ADDRESS>Node.js v10.15.3
<EMAIL_ADDRESS>Mac

It's a duplicate of #2031 - still unresolved :(

any progression in this issue?

@JesseWeb look at https://github.com/serialport/node-serialport/issues/2031. The issue is resolved now.

@JesseWeb look at https://github.com/serialport/node-serialport/issues/2031. The issue is resolved now.

Glad to hear that!


Let eclipse-wtp replace default facet versions

Fixes #945
Context
Eclipse IDE uses facets to configure the Java EE or Jakarta EE specifications a war project (or a ear project or an ejb project) targets.
The eclipse-wtp plugin populates these facets with default values (eg jst.web with version 2.4 for a Java EE web project or jst.ear with version 5.0 for ear projects).  However these default facets are often not the one many users want.
The pull request lets users replace the default facets populated by the plugin with new ones, letting Eclipse IDE know which Java EE or Jakarta EE specifications gradle projects really target.
For example in a war project, the code bellow will now replace the default 'jst.web' facet (with version '2.4') with the new one, letting eclipse know that you're targeting the servlet spec 4.0.
apply plugin: 'war'
apply plugin: 'eclipse-wtp'

eclipse.wtp.facet {
  facet name: 'jst.web', version: '4.0'
}

Relevant issues: #945 #1334
Relevant forum discussions:

Be able to easily customize the eclipse-wtp facet version
Configure ear project in eclipse
Eclipse-wtp facet creates duplicates

Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[x] Verify design and implementation
[x] Verify test coverage and CI build status
[x] Verify documentation
[x] Recognize contributor in release notes

@bot-gradle test rFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.

Pre-tested commit build failed.

@bot-gradle test rFM

OK, I've already triggered ReadyForMerge build for you.

@bot-gradle test rFM


Upgrade yarn packages to latest

Since this is the demo program that shows best practices, is there any reason not to update to the latest packages?  In particular, Webpack and stimulus.
@symfony/stimulus-bridge      2.1.0   -> 3.2.1
@symfony/webpack-encore       1.4.0 ->  2.1.0
stimulus                      2.0.0  ->  3.0.1

I'm happy to do a PR, but wanted to see if there was any particular reason to keep these older versions in the branch that works with 6.1.

There's no reason to keep the old versions, so please submit a PR to update this. Thanks!

@javiereguiluz great news, yes and as explain I got some conflict/problem trying to recompile new assets before versioning them :s
anyways, nice that this project is up to date now :)


Error Transcoding File

Can't seem to get this work (Windows 10, Julia 1.1.1)
MWE:
using CodecLz4, CodecZlib

function gz2lz4mwe(infile::String, outfile::String)

  @assert isfile(infile)

  indata = open(infile, "r")
  outdata = open(outfile, "w")

  s = GzipDecompressorStream(LZ4CompressorStream(outdata))

  write(s, indata)
  close(s)
end

gz2lz4mwe("data\\CS-A.csv.gz", "data\\CS-A.csv.lz4")

Error:
LoadError: LZ4F_compressUpdate: ERROR_dstMaxSize_tooSmall
in expression starting at C:\[...]\qfactors\QFactorScripts.jl:25
changemode!(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::Symbol) at stream.jl:710
callprocess(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::TranscodingStreams.Buffer, ::TranscodingStreams.Buffer) at stream.jl:641
flushbuffer(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::Bool) at stream.jl:594
flushbufferall at stream.jl:601 [inlined]
writedata!(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::TranscodingStreams.Buffer) at stream.jl:679
flushbuffer(::TranscodingStreams.TranscodingStream{GzipDecompressor,TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}}, ::Bool) at stream.jl:593
flushbuffer at stream.jl:584 [inlined]
unsafe_write(::TranscodingStreams.TranscodingStream{GzipDecompressor,TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}}, ::Ptr{UInt8}, ::UInt64) at stream.jl:458
unsafe_write at io.jl:509 [inlined]
macro expansion at gcutils.jl:87 [inlined]
write at io.jl:532 [inlined]
write(::TranscodingStreams.TranscodingStream{GzipDecompressor,TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}}, ::IOStream) at io.jl:579
gz2lz4mwe(::String, ::String) at QFactorScripts.jl:21
top-level scope at none:0

It looks like the LZ4 code isn't allocating a large enough buffer. I'll take a look into this in the next week or so.
Does this happen when using LZ4 alone, or is it only when using it with the GzipDecompressor?

Thanks- yes it seems to happen using LZ4 alone. Here is another example without using another codec:
using DataFrames, CodecLz4, Serialization

if  pwd() ∉ LOAD_PATH
  push!(LOAD_PATH,pwd())
end

function lz4mwe(infile::String, outfile::String)
  @assert isfile(infile)
  df = deserialize(infile)
  println("size after read: $(size(df))")
  outdata = open(outfile, "w")

  s = LZ4CompressorStream(outdata)

  serialize(s, df)
  close(s)
end

lz4mwe("data\\CRSP-M.jls", "data\\CRSP-M.csv.lz4")

Output:
LoadError: LZ4F_compressUpdate: ERROR_dstMaxSize_tooSmall
in expression starting at C:\Users\...\qfactors\code\test.jl:112
changemode!(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::Symbol) at stream.jl:710
callprocess(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::TranscodingStreams.Buffer, ::TranscodingStreams.Buffer) at stream.jl:641
flushbuffer(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::Bool) at stream.jl:594
flushbuffer at stream.jl:584 [inlined]
unsafe_write(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::Ptr{UInt8}, ::UInt64) at stream.jl:458
unsafe_write at io.jl:509 [inlined]
macro expansion at gcutils.jl:87 [inlined]
write at io.jl:532 [inlined]
serialize_array_data at Serialization.jl:246 [inlined]
serialize(::Serializer{TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}}, ::Array{Int64,1}) at Serialization.jl:263
serialize(::Serializer{TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}}, ::Array{AbstractArray{T,1} where T,1}) at Serialization.jl:268
serialize_any(::Serializer{TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}}, ::Any) at Serialization.jl:638
serialize at Serialization.jl:617 [inlined]
serialize(::TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}, ::DataFrame) at Serialization.jl:694
lz4mwe(::String, ::String) at test.jl:108
top-level scope at none:0

Seems like the compressor buffer is never flushed. Trying to write CodecLz4.BUF_SIZE-CodecLz4.LZ4_FOOTER_SIZE bytes works:
> s = open("/tmp/test1.lz4", "w")
IOStream(<file /tmp/test1.lz4>)
> comp = LZ4CompressorStream(s)
TranscodingStreams.TranscodingStream{LZ4Compressor,IOStream}(<mode=idle>)
> for i in 1:CodecLz4.BUF_SIZE-CodecLz4.LZ4_FOOTER_SIZE write(comp, UInt8(i % 256)) end
> close(comp)

while writing CodecLz4.BUF_SIZE-CodecLz4.LZ4_FOOTER_SIZE+1 fails to close the compressor with:
ERROR: LZ4F_compressEnd: ERROR_dstMaxSize_tooSmall

Actually, doing:
write(stream, TranscodingStreams.TOKEN_END)

flushes the compressor buffer and avoids the error. What is missing for the above to happen automatically?

I think I found the problem. It looks like the buffer was being allocated from the minoutsize rather than the expectedsize. Changing the minimum size to be generated by LZ4F_compressBound should fix the problem.
Would you mind giving https://github.com/invenia/CodecLz4.jl/pull/23 a try to see if that fixes your problems?

Works like a charm.
This is going to save me many many many hours working with large files relative to gzip- thanks

Thank you  @dm3 @morris25 @nicoleepp @omus


Add-DbaAgDatabase - Fix -Database parameter in Backup-DbaDatabase call

The call to backup the database to NUL got the database object
instead of the database name as -Database parameter.
This generated the following warning:
WARNING: [18:47:27][Backup-DbaDatabase] No databases match the request for backups
This fixes issue #6611

Type of Change

[x] Bug fix (non-breaking change, fixes #6611 )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

awesome, thank you so much! sorry for the delay in reviewing the PR, just moved to a whole new country 😅


bower.json should be updated

The file bower.json should be update to use the lastest version of AngularJS 1.4.*.
"dependencies": {
    "angular": "~1.2.21"
  },
  "devDependencies": {
    "angular-mocks": "~1.2.21",
    "angular-scenario": "~1.2.21"
  }

I tested without the dependencies with the lastest version of AngularJS, works like a charm.

@mpgn — The bower configuration should currently use the latest 1.x version of AngularJS.
The tilde indicates to take any subsequent minor-level or patch-level changes greater than 1.2.21, including 1.3, 1.4, 1.4.x, but not 2.x.
Are you seeing a different result?
Thanks!

Bower will ask you if you want to use the dependancy to angular 1.2.* when you have 1.4.* every time (bower update, bower install). Of course you choose to use the 1.4.* and it's all fine.
Example, every time i use bower update bower will ask me
Unable to find a suitable version for angular, please choose one:
    1) angular#~1.2.21 which resolved to 1.2.29 and is required by angular-update-meta#1.7.0
    2) angular#>=1.2.0 <1.5.0 which resolved to 1.2.29 and is required by angular-moment#0.10.3
    3) angular#>=1.0.0 <1.5.0 which resolved to 1.2.29 and is required by angular-gravatar#0.4.1
    4) angular#^1.2.6 which resolved to 1.2.29 and is required by angular-socket-io#0.7.0
    5) angular#>= 1.0.8 which resolved to 1.2.29 and is required by angular-ui-router#0.2.15
    6) angular#>=1.2 < 1.5 which resolved to 1.2.29 and is required by angular-audio#1.7.1
    7) angular#>= 1.0.8 which resolved to 1.4.8 and is required by angular-ui-router#0.2.15

The problem ? the other package are also resolved to 1.2.29  due to angular-update-meta.
Now take a look at bower.json file of angular-ui-router https://github.com/angular-ui/ui-router/blob/master/bower.json
  "dependencies": {
    "angular": ">= 1.0.8"
  },

And now bower.json from angular-update-meta :
  "dependencies": {
    "angular": "~1.2.21"
  },

You can see the difference : >= and ~.
In the doc we can have an example : https://github.com/npm/node-semver
~1.2.3 := >=1.2.3 <1.(2+1).0 := >=1.2.3 <1.3.0

Adapted to your bower.json
~1.2.21 := >=1.2.21 <1.(2+1).0 := >=1.2.21 <1.3.0

And angulars 1.4.* is not taken into account.
I propose you update your bower.json to :
  "dependencies": {
    "angular": ">=1.2.21 < 1.5"
  },

I just came here and wanted to open an issue, until I saw this one. Can confirm, that Angular 1.4.* must be selected manually.
Anyway: Great software and many thanks for it!

@mpgn — You are right!
I have corrected the version to support any version larger than 1.2.x (and below 2.x.x) and released it as v1.7.1.
Can you please verify if all is okay now?
Thanks for reporting!
/cc @marcoraddatz

waiting for the released 1.7.1 https://github.com/jvandemo/angular-update-meta/releases

@mpgn — Should be there now. Can you try again? Thanks!

I can confirm, all fine with bower update :+1:

Many thanks! Works like a charm!

@mpgn, @marcoraddatz — Awesome, thank you both for the confirmation!


Only Show the Info for Legal Name in Host Section if Legal Name is not set

This was initially reported at https://opencollective.slack.com/archives/G46PNRCGP/p1632132442330400?thread_ts=1631881231.305700&cid=G46PNRCGP.
It seems that the legal name warning message when configuring hosts is displayed even if the legal name is set. We should make sure this info box is only shown if the legal name is not set. 🤔

By the way, the message is wrong in this case (Self Hosted), there is no "Host".


Formatting corrections and improvements

I found an incomplete html comment tag. Corrected this. Not sure if this is going to break something.

Hi @royfrancis , have you tested locally? I will merge it if it works with you.
Also, we are going to suspend the NBIS Rshiny service as mentioned in the NBIS meeting and the newsletter. The current Apps will be moved to the Data Center, although for some reason it takes exceptionally long time for the Data Center to deploy these Apps. At this transition period, we will just keep the server https://rshiny.nbis.se as it is. Any hosting requirement for the new Apps should be sent to the Data Center.

Yes, tested locally. The page looks fine.

OK. Then I will merge it.


Add progress bar option to config generator

Thinking about this more, there is already a clear pathway to enable adding a progress bar. I think instead of explicitly adding this feature, it makes more sense to provide an example of how to do this. Given that generate_configs takes an Iterable[HookProvider], there is nothing stopping someone from wrapping that iterable in something (like tqdm) to provide a progress bar. For example:
import tqdm

generate_configs(
    hook_providers=tqdm.tqdm(hook_provider), # provides progress bar
    hook_objects=[Cfe, Pet],
    file_writer=file_writer,
)


UndefinedError: 'dict object' has no attribute 'entity_id' for input_select.select_option

Home Assistant release with the issue: 0.82.0

Last working Home Assistant release (if known): 0.81.4
Operating environment (Hass.io/Docker/Windows/etc.): MacOS Mojave

Component/platform: https://www.home-assistant.io/components/input_select/

Description of problem:
From an automation I'm seeing the following error reported:
2018-11-13 11:11:31 ERROR (MainThread) [homeassistant.helpers.service] Error rendering data template for input_select.select_option: UndefinedError: 'dict object' has no attribute 'entity_id'
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
- alias: "Harmony_Update_Status"
  hide_entity: true
  initial_state: on
  trigger:
    - platform: state
      entity_id: remote.family_room
    - platform: state
      entity_id: remote.master_bedroom
    - platform: homeassistant
      event: start
  action:
    service: input_select.select_option
    data_template:
      entity_id: >
        {% set entity = trigger.entity_id.split(".")[1] %}
        {% set room = entity.split("_")[0] + "_" + entity.split("_")[1] %}
        input_select.{{ room }}_tv
      option: >
          {{ state_attr(trigger.entity_id,'current_activity') }}

Following, more simple, which I had for quite a while now is also reporting the error:
- alias: "Harmony_Update_Status"
  hide_entity: true
  trigger:
    - platform: state
      entity_id: remote.family_room
  action:
    service: input_select.select_option
    data_template:
      entity_id: input_select.family_room_tv
      option: >
          {{ state_attr('remote.family_room','current_activity') }}

Traceback (if applicable):

Additional information:

User error.


chore: spring-jenkins-x-demo to 0.0.1

chore: Promote spring-jenkins-x-demo to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


DNS/TLS for Workbench

The Workbench service now at http://www.terraref.ndslabs.org needs a wildcard TLS cert.  The ndslabs.org domain is a temporary testing domain and is not intended to host services.
Completion criteria:

[ ] Get access to terraref.org DNS or possibly transfer ownership to NCSA
[ ] Add *.workbench.terraref.org wildcard DNS to terraref.org
[ ] Wildcard TLS certificate for workbench.terraref.org

Have access to account. Opened ticket with NCSA security to see if they will issue the cert or if we need to move ownership.

For NCSA to provide the certificate - you will need to move the domain registration and coordinate with NCSA NetEng
You can also get wild card domain certs from a commercial provider.
https://www.digicert.com/wildcard-ssl-certificates.htm

Opened ticket with NCSA+NetEng about moving the domain.

From neteng:
"Yes the domain can be transferred. I think it costs usually around $12 and some
change (basically the cost of an additional year of renewal). The admin contact
is [ ], so he'll need to provide NCSA with the Authorization
Code which you can retrieve from inside your Registrar portal. NCSA will then
make the request for transfer with that Code, and the Admin contact  will
get an email which he'll need to ok. Usually takes about a week.
What point of complex, looks like your using ARPLUS.NET has your DNS provider.
When you make the switch to NCSA we'll need to have all of your DNS records
ported over to our system to prevent much disruption. So that will be something
else you will need to provide, probably before we start the transfer.

From neteng:
"I've created terraref.org on NCSA DNS servers, and setup an A record to point
to the IP you provided. You can log into your registrar now and change the name
servers to NCSA DNS server. So replace: ns1.aplus.net ns2.aplus.net with dns1.ncsa.illinois.edu
dns2.ncsa.illinois.edu."
I've done this via aplus.net interface.

Received message from NCSA neteng that transfer failed because it was not approved.   Will re-initiate transfer.

Re-initiated transfer to NCSA.  This will likely be done next week.

Transfer complete!  Next steps are to request the new workbench domain and TLS certificates.
@dlebauer My plan is to use workbench.terraref.org, unless you have another suggestion?

@craig-willis I think workbench.terraref.org is fine but can we have terraref.ndslabs.org redirect here at least for a few months so we can update links in documentation?
At some point it would be nice to point, e.g., bety to traits.terraref.org and clowder to sensors.terraref.org - is that difficult to do?

DNS request for *.workbench.terraref.org submitted. Will address the bety/traits and clowder/sensors requests in a separate ticket. (It should be possible, but in discussions with Rob there are configuration changes for Clowder/Bety).

Workbench DNS entry in place.  Will need to update the instance configuration and add the redirect from terraref.ndslabs.org

Requested wildcard SSL cert.

Update from NCSA CA group -- apparently they have to submit to InCommon to allow NCSA to sign certs for terraref.org. This is still being processed.

NCSA is now able to sign SSL certificates for terraref.org. In the future, we can request new certificates by emailing<EMAIL_ADDRESS> I have the wildcard certs for Workbench now and need to install and add a redirect entry from the old URL.

Need to discuss strategy for storing keys (i.e., Last Pass)

Use lastpass for sharing, that is what NCSA supports. I already have an account there for some information.

@dlebauer
I need to schedule downtime for workbench to install the SSL certificates.  I'll need <1 hour, but will need to shutdown your running applications.  I'd like to get this done this week, if possible.  Let me know if there are any good/bad times to do this.

I don't see any bad times this week. If anyone is using it please send an email warning in advance.

@dlebauer You are the only person running with active containers at the moment.
I'll likely take it down tonight to take care of several maintenance tasks: install SSL certs, mount the ROGER users directory, resize the storage volume.


[fit] Add higher degree polynomials

Higher degree polynomials should be added to the list of functions and/or backgrounds. Ideally one should be able to just configure the degree of the polynomial. If that is not possible, a very simple solution would be to offer up to 5th order polynomials.

closed by #528


Cow: Watch todaybanglanews.com

Cow requests the watch of the watch_keyword todaybanglanews\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

todaybanglanews\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


List of solved theorems?

Hi,
Thanks for sharing this project! Fantastic results. 🥇 I wanted to check the full list of MiniF2F theorems that LEGO solved, as a way to understand the difficulty of different theorems. I looked in the files in data/full_data. But they are just the placeholder proofs from MiniF2F, right? Not the LEGO-generated ones?
Thanks!

Hi @darabos, thank you for your attention to our project! We haven't released the full list of LEGO-generated proof since it requires further processing and some company routine before release. I am quite occupied currently but we guarantee to release all the LEGO-generated proof and the skill library in the near future!

Apologies for the extended wait; the results are now available. I am proceeding to close the issues.

Thank you! There's lots of interesting details in the results file. It's awesome!


Add termiantion endpoint for consumer

This PR resolves #72 and changes description of http codes for unauthorized clients and not existing negotiations

The PR adds the description for the POST consumer endpoint negotiations/:id/termination under chapter 3.5 and improves the text.


Unhelpful e2e output when there are no failed tests

Is this a BUG REPORT or FEATURE REQUEST?:
Feature Request
What happened:
I ran sonobuoy e2e results.tar.gz and i got
test salazar:tmp cha$ sonobuoy e2e<PHONE_NUMBER>19_sonobuoy_5ccc8263-716d-462e-a8a3-eb971b183d35.tar.gz
failed tests

What you expected to happen:
I expected it to tell me that i had no failed tests or told me at least how many ran and how many failed
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Sonobuoy tarball (which contains * below)
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):

Bumping this because it's come up in #sonobuoy at least once

Definitely a bug that should be fixed. Maybe a great place for a more useful side tool outside of sonobuoy as well. However, since we're talking about investigating the tar file itself (which sonobuoy generates) and not just the raw junit results, it makes sense for sonobuoy to do some of this work. For the time being some patch should go in to fix this though.