Reducing the PR approval count to 2

What is the areas you experience the issue in?
Notation CLI
What is not working as expected?
To increase the velocity of the development, we would like to reduce the PR approval count to 2. The justification is the following: with the current count of 3 approvals we have 4 people who need to be involved in the PR. Our initial goal was to have min 3. By reducing to 2 approvals required we still have 3 people including the original submitter.
What did you expect to happen?
Reduce PR approvals to 2
How can we reproduce it?
N/A
Describe your environment
N/A
What is the version of your Notation CLI or Notation Library?
N/A

We can keep the original count of 3 approvals for notation-core-go since it is a crypto critical library.

Close this issue. We keep 3 approvals as @shizhMSFT explained


Badger 2040 - Click button trigger GPIO

I would like to to connect the Badger 2040 to my RPI. Basic idea: Clicking in some Badger 2040 button would trigger an action in the RPI. Is this possible?

Using MicroPython I'd hook it up via USB and do this over serial using Python/pyserial - https://pyserial.readthedocs.io/en/latest/pyserial_api.html
You then just need to make pressing a button print something, watch for that over serial and act accordingly.
CircuitPython could pretend to be a keyboard and send whole USB HID macros, but how useful those are depends on what you want to achieve.

I was thinking over GPIO, not serial as a keyboard.

@Gadgetoid Would be possible to connect the badger to a stepper motor driver (GPIO)?

Closing this as it looks like the original question was answered, and the follow-up question was raised and answered separately https://github.com/pimoroni/pimoroni-pico/issues/323


Automated crossbar test is failing

Travis is failing.

I found a request path issue with the version of guzzle that ratchets requires (which is outdated).  Updating to guzzle/guzzle fixes that issue.
There's a secondary issue with crossbar throwing an error when we announce the subscriber_metaevents feature from the subscriber:
WAMP Internal Error (__init__() got an unexpected keyword argument 'subscriber_metaevents')

Looking at the spec, it looks like we're suppose to be announcing that meta event.
https://github.com/tavendo/WAMP/blob/master/spec/advanced.md#subscriber-meta-events
I'll dig into it a bit more and maybe open an issue with crossbar.

Resolved with https://github.com/voryx/Thruway/commit/912671b49db5e2034e1ebb29cae6e26ea425619a


Send a single-page pdf.
Tap on the PDF preview to open it.
Verify it is displayed centered in the middle.

Offline tests

Go to any chat.
Send a single-page pdf.
Tap on the PDF preview to open it.
Verify it is displayed centered in the middle.

QA Steps

[X] Verify that no errors appear in the JS console

Go to any chat.
Send a single-page pdf.
Tap on the PDF preview to open it.
Verify it is displayed centered in the middle.

PR Author Checklist

[X] I linked the correct issue in the ### Fixed Issues section above
[X] I wrote clear testing steps that cover the changes made in this PR

[X] I added steps for local testing in the Tests section
[X] I added steps for the expected offline behavior in the Offline steps section
[X] I added steps for Staging and/or Production testing in the QA steps section
[X] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[X] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[X] I included screenshots or videos for tests on all platforms
[X] I ran the tests on all platforms & verified they passed on:

[X] Android: Native
[X] Android: mWeb Chrome
[X] iOS: Native
[X] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[X] MacOS: Desktop

[X] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[X] I followed proper code patterns (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[X] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[X] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I followed the guidelines as stated in the Review Guidelines
[X] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] I verified that if a function's arguments changed that all usages have also been updated correctly
[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[X] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[X] I verified that all the inputs inside a form are aligned with each other.
[X] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

got a few merge conflicts 😬

Whoops I miss the conflict. @abzokhattab Could you fix it? Thanks!

it looks like theWebPDFDocument  and the WebPDFPageRenderer  were removed in this PR  https://github.com/Expensify/App/pull/33434/files. and now we use a new library to view the PDF react-fast-pdf  although the issue is still there, will check today on how to fix the styling in the new setup.

okay it seems that we have moved all that logic in a new npm library that handles the pdf preview.. i made the same changes there in this PR .. i think we can close this one in favor of the other.

Ooh into the new library repo? I like this plan - @mollfpr can you test that or do you not have access to that repo?

@Beamanator Sorry for the delay 🙏

I like this plan - @mollfpr can you test that or do you not have access to that repo?

Yes, I can review and the PR there!

Thanks @mollfpr ! Also do you mind commenting in that other PR or something so I can assign the review to you, then we can continue the convo there and close this one out?

Merged 👍  @abzokhattab looks like you've got conflicts


Android Basics: Activities and intents

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-activities-intents?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-3-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-activities-intents#5
In which task and step of the codelab can this issue be found?
Task: Activities and Intents
Step: 6) Setup Detail Activity
Describe the problem
"Remember when you performed the implicit intent in the WordAdapter, you passed in part of the URL to perform a Google search?"
The above lines are from step 6 of activities and intents lesson. We learn about implicit intent in step 7 and has not yet set up an implicit intent as mentioned in the above lines.
Additional information

@amaljoe
Thank you so much for reporting this issue. This is fixed and will be published soon.

@amaljoe
Thank you so much for reporting this issue. This is fixed and will be published soon.


Update people-picker-and-claims-providers-overview.md

Issue #1060 - This article applies to 2013, 2016, and 2019. So removed the references to 2013 and "APPLIES TO" section has been updated.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.


fixed typos in command for submission

@ryukzak check please,
Artem Lysenko P33312

@ryukzak would you like to merge it? becuase you approved it

Yes. I make the review from the phone, so don't have access to your registry.


[TW#25824] Segfault when running mconf

Environment

Development Kit:      ESP32-DevKit
Kit version (for WroverKit/PicoKit/DevKitC): v1
Core (if using chip or module): ESP-WROOM-32
IDF version (git rev-parse --short HEAD to get the commit id.): 020ade65
Development Env:		Make
Operating System:		Linux (Mageia 6)
Power Supply:         USB

Problem Description
Segfault when running mconf
This happens when I run 'make menuconfig' for the hello_world example.
Expected Behavior
Expect to see the config menu.
Actual Behavior
MENUCONFIG
^[[?1049h^[[1;24r^[(B^[[m^[[4l^[[?7h^[[39;49m^[[?1h^[=/bin/sh: line 1:  5011     Segmentation fault    (core dumped)
Steps to repropduce

make clean
make menuconfig

Code to reproduce this issue
n/a
Debug Logs
$ gdb /home/billr/esp/esp-idf/tools/kconfig/mconf
(gdb) run /home/billr/esp/esp-idf/Kconfig
Program received signal SIGSEGV, Segmentation fault.
                                                    0x00007ffff7bbd992 in waddch_literal (ch=<optimized out>, win=0x73f470)
    at ../../ncurses/base/lib_addch.c:389
389	    line->text[x++] = ch;
(gdb) bt
#0  0x00007ffff7bbd992 in waddch_literal (ch=<optimized out>, win=0x73f470)
    at ../../ncurses/base/lib_addch.c:389
#1  waddch_nosync (ch=32, win=0x73f470) at ../../ncurses/base/lib_addch.c:441
#2  waddch (win=0x73f470, ch=32) at ../../ncurses/base/lib_addch.c:547
#3  0x0000000000415a7a in attr_clear ()
#4  0x0000000000415b33 in dialog_clear ()
#5  0x0000000000415e99 in init_dialog ()
#6  0x000000000040422b in main ()
(gdb)  l
384	    });
385
386	    /*
387	     * Single-column characters.
388	     */
389	    line->text[x++] = ch;
390	    /*
391	     * This label is used only for wide-characters.
392	     */
393	    if_WIDEC(
(gdb) q

$ ldd /home/billr/esp/esp-idf/tools/kconfig/mconf
	linux-vdso.so.1 (0x00007ffcf1283000)
	libncurses.so.6 => /lib64/libncurses.so.6 (0x00007f3ac90f5000)
	libtinfo.so.6 => /lib64/libtinfo.so.6 (0x00007f3ac8ebb000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f3ac8b08000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f3ac8904000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f3ac931f000)

$ rpm -qa |grep ncurses
lib64ncurses6-6.0-8.3.mga6
lib64ncurses-devel-6.0-8.3.mga6
...

Other items if possible

[ ] sdkconfig file (attach the sdkconfig file from your project folder)
[ ] elf file in the build folder (note this may contain all the code details and symbols of your project.)
[ ] coredump (This provides stacks of tasks.)

Other programs built with the same ncurses library (such as the Linux kernel version of mconf) work fine.

Hi @billr1,
Thanks for providing all this detail.
Just to check one possibility, menuconfig has never worked on this system? Otherwise a "make clean", "make menuconfig" might rebuild the mconf binary successfully if something significant changed in the system library config.
Otherwise, I'm not familiar with Mageia or Mandriva Linux, so this may be the wrong thing to look at, but I'm surprised that it's linking ncurses not ncursesw. Are these equivalent on your system?
Does Mageia use pkgconfig? If you run
pkg-config --libs ncurses
pkg-config --libs ncursesw

... do you see different libraries?
Similarly, if you run
$IDF_PATH/tools/kconfiglxdialog/check-lxdialog.sh -ldflags

What does this print?
What LOCALE is set, normally? If you use LOCALE=C make menuconfig, does this work?
Angus

Mageia is a fork of the old MandrIva, nee Mandrake Linux. It is an rpm-based distro, and yes, uses pkg-confg. Here's the answers to the info you requested.
The esp-idf menuconfig has never worked. I did a 'make clean; make' several times and it builds without complaints.
$ pkg-config --libs ncurses
-lncurses -ltinfo
$ pkg-config --libs ncursesw
Package ncursesw was not found in the pkg-config search path.
$ urpmq -y ncursesw  <-- Mageia's equivalent of 'dnf search' on Fedora
lib64ncurses-devel
lib64ncurses5
lib64ncurses6
lib64ncursesw-devel
lib64ncursesw5
lib64ncursesw6
...
So, I installed the lib64ncursesw-devel and lib64ncurses6 packages, did a make clean; make menuconfig - and it worked!
So, I guess it turns out the be user error, not having the version of ncurses installed. Thank you so much for your help. This issue can be closed now.


Adds extension: Rabbit r1 | Rabbit Hole Journal Extension

Description
This is a new extension for the Rabbit r1 to access my journal entries through Raycast; making your data more accessible outside of the Rabbit ecosystem.
This extension allows you to query all of the entries in your journal from the Rabbit r1. This includes notes, recordings, computer vision, image generation, web searches, ai chats, and photos from the camera.
Screencast
https://github.com/raycast/extensions/assets/1895120/a6c6d9ea-ba87-40a8-a03c-9bb23a840a3c
Screenshots

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Hi!
Thank you for your contribution! My name is Milena and I will be reviewing it today.
Sorry for the delay answering your PR. My concern here is about how useful would it be if the key needs to be refreshed every 24h. And, as I don't have access to Rabbit, I would need a screencast of empty states and error states, just to check if everything is okay.
Also, we would need, on your README, a disclaimer waiving Raycast from any involvement on the extension building and telling the user that they are responsible for the use of this extension.

Hi @mil3na! No worries in the delay in the PR.
I hear your concerns over how useful this would be as a long-term plugin. My hopes with this extension is to use this as a case study for why they should open up API keys as part of their ecosystem so users can get more use out of their Rabbit's. Hopefully the 24 hour token expiration won't be an issue for long.
I'm unsure how to get your a screencast of empty states and error states. Do you mean like if the user sets it up for the first time, with no data?
Here is what it looks like when you sign up for the first time:

Here is what it looks like if you have no entries in your journal:

There should be checks and conditions in ts that prevent other empty states from showing up.
I have added the following into the README:

Disclaimer
This extension is a third-party contribution and is not officially affiliated with or endorsed by Raycast. The developers of this extension are solely responsible for its functionality and maintenance. Users of this extension do so at their own risk, and Raycast bears no responsibility for its use or any consequences thereof. By installing and using this extension, you acknowledge that you are responsible for your use of this extension and any actions taken through it.

Missed this getting merged in! Very cool, thank you @mil3na. I've published a topic on the official Rabbit r1 forums. Fingers crossed!


Variable modifications

Change currentCenterCell to open var;
Change currentCenterCellIndex to open var;

@cs-joao-souza - I am thinking about this a bit more. The reason you want them open is because you want to mock them?

@superpeteblaze  To stub methods in unit testing in Swift, if you don't have a protocol that define that functionality so you need to override it and fake your method call. The reason to do that, is that i don't want to test your class, because i know that it works so i just want to verify if your method is called, or just stub some methods.

@cs-joao-souza Yes, I understand that a protocol would be needed to stub, and it would be preferable to overriding. I don't think it really makes sense to change the access level of these properties, so I suggest another idea:

How about you create a protocol in your codebase, and in that protocol, you declare two properties with the same signature as currentCenterCell and currentCenterCellIndex. The protocol you create can contain whatever ScalingCarouselView properties/methods you want to stub. You could then create an extension on ScalingCarouselView to conform to this protocol, and this would enable you to stub it.

The reason I say do this locally in your codebase, is that it doesn't really make sense for ScalingCarousel to be based off a protocol.

@superpeteblaze There is a rule haha. If you want to test more, just let your variables public or open. Im kidding, just a joke. But talking seriously imagine if i need to do this for every class that has a function that i need to stub? My project will become a bag of protocols with no sense, because it won't be reused, so it is a protocol with no sense. What i'm thinking is about the open closed principle. Classes should be opened for extension but closed for modifications. If theses variables keep being only public, you won't let me inherit your class, i do need to create a new one. Furthermore, theses variables is just a get i can't even set any variable to this. What you think?

Yes, the open closed principle is valid, and correct. However, the rule is not intended to mean that types should always be open for extension.
I agree on the protocol approach, it's not feasible.
But looking at it again, as the entire class is open, perhaps it's not a problem to make these two properties open also.
Also, yes, if you want to make them get only, that would be fine.

So, what is your answer? ;)

As I said above, keeping them open is fine, and if you want to update them to be get only, then awesome

These variables are already get only haha. So are you going to accept my PR?

Ah yes, I forget they were computed properties. Sure, I will accept it

Thanks. And don't forget to update the Pods. =D

Done.

On 8 Nov 2017, at 13:57, cs-joao-souza<EMAIL_ADDRESS>wrote:
Thanks. And don't forget to update the Pods. =D
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/superpeteblaze/ScalingCarousel/pull/19#issuecomment-342824735, or mute the thread https://github.com/notifications/unsubscribe-auth/AFCK6WX1Y-ux7-jSGI6DcbWP3JUoVqXAks5s0bNLgaJpZM4QTcGs.


These instructions don't work

After installing VS Tools for Unity 22, Unity Hub doesn't have an option to install the 2022 editor package with a new project (just the already installed 2019). Also, VS22 doesn't show up in available editors in Unity and after adding the devenv.exe manually VS complains that the project files were not made with Tools for Unity, it's also not possible to debug as it complains that a project of type class library cannot be run. To top things off the Visual Studio Editor package in Unity is not available anywhere to be downloaded, Unity documentation on that package links to this page.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a35176f2-ca94-7bb8-08a5-9e415d364ef3
Version Independent ID: a9f184a6-78b9-315b-4a02-1c93bd4c3940
Content: Quickstart: Install & configure Visual Studio Tools for Unity
Content Source: gamedev/unity/get-started/getting-started-with-visual-studio-tools-for-unity.md
Product: visual-studio-dev16
Technology: vs-unity-tools
GitHub Login: @therealjohn
Microsoft Alias: johmil

@cybercritic -- thank you for your feedback.  Please consider these resources:

Visual Studio on Microsoft Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@therealjohn -- please look into this potential documentation issue.

@cybercritic Can you outline the steps you took?
Unity Hub hasn't been updated to offer VS 2022, but you already have it installed anyway. The Editor package is added in the Unity Editor using the Window > Package Manager window. It's automatically added for new projects when using modern versions of the Unity Editor - so no additional steps should be required.
Something else odd is going on that is preventing Unity Editor from recognizing VS. The best thing to do is to use VS > Help > Send Feedback > Report a Problem. This will help you create a bug where our team can help investigate.

I already had Unity HUB and Unity Tools installed for VS 2019. I installed the Tools for Unity 22 in VS setup app and because it was not showing in the editor list in Unity I added the devenv.exe manually. The project opens from Unity in VS22 but debugging doesn't work, and the Unity project does not have the Visual Studio Editor package at all and there is no ability to add it (I also could not find it anywhere to download manually). This was on an existing project (2019.4 which is supported). Then I was going to make a new project, just to see if the installation is working, but in the install new instance menu Unity Editor 19 is the only available option.


MongoDB 4.2.10 starts to emit warnings about slaveOk() being deprecated, which breaks the module

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 6.18.0
Distribution: Debian Buster
Module version: 3.1.0

How to reproduce (e.g Puppet code you use)
Increase MongoDB version from 4.2.9 to 4.2.10.
What are you seeing
Puppet agent runs start failing with an error:
Info: Applying configuration version '1602075392'
Error: Could not prefetch mongodb_database provider 'mongodb': 765: unexpected token at 'WARNING: ) is deprecated and may be removed in the next major release. Please use secondaryOk( instead.

Unfortunately, Puppet cuts off some bits of the message, but I assume the real warning is this:
slaveOk() is deprecated and may be removed in the next major release. Please use secondaryOk() instead.

And indeed, if I change all occurrences of slaveOk() to secondaryOk() it starts working again.
What behaviour did you expect instead
A simple warning shouldn't break the module.
Output log
See above.

Fixed in #594

Any chance we get this released any time soon?

Any chance this gets released any time soon?

Same here.
Any chance that there might be a release? Is there something stopping a possible release?

I think mostly that someone has to step up and do the work. Anyone can create a PR with the changelog and bump the version. https://voxpupuli.org/docs/releasing_version/ describes the steps.

I think mostly that someone has to step up and do the work. Anyone can create a PR with the changelog and bump the version. https://voxpupuli.org/docs/releasing_version/ describes the steps.

That's really bad practice, isn't it? This should IMHO be a task for a maintainer of the project, not for the average user.

Voxpupuli is a collective. To quote voxpupuli.org:

We are a collective of Puppet module, tooling and documentation authors all working together to ensure continued development on the code we maintain.

However, it is volunteer driven. My past few months have been crazy busy so I had no time for it. However, anyone can join the project. We rely on users actually maintaining modules. I've always liked open source because it gave me the ability to fix my own problems. Here it's the same thing: you have a problem and there is a clear opportunity to fix your problem.

I think mostly that someone has to step up and do the work. Anyone can create a PR with the changelog and bump the version. https://voxpupuli.org/docs/releasing_version/ describes the steps.

I can live with this "policy" - I was under the impression that this needs to be done by a maintainer. Let's see ...

Question: why is it closed?
I understand that we, as community, should fix the issue but the issue in itself is still open right? 3.1.0 has still the problem
(reproduced with puppet 4.10 and CentOS 7.9 . I think also puppet 5.5 has the same problem)

Question: why is it closed?
I understand that we, as community, should fix the issue but the issue in itself is still open right? 3.1.0 has still the problem
(reproduced with puppet 4.10 and CentOS 7.9 . I think also puppet 5.5 has the same problem)

Issues are closed when it has been fixed in master.

Issues are closed when it has been fixed in master.

Ah ok so it is not yet released. Thank you!

Ah ok so it is not yet released. Thank you!

Hi,
any change to get this fix released soon ? Last release of the module is 1 year old.
I need this fix because currently the module doesn't works anymore on our mongodb up-to-date nodes.
Thanks you !

I can only speak for myself, but we just merged the last patches to get rid of MongoDB completely in our infra. That means I no longer have an interest in this module. https://voxpupuli.org/docs/about_vox_pupuli/ isn't very clear on how to join, but I'd encourage anyone who depends on this module to step up and become a maintainer.

So effectively this module is at the moment without a main maintainer?

Looking at who merged patches in the past time, I think it's fair to say that this module needs a maintainer. Vox Pupuli is designed as an organization that easily allows a new maintainer to step in though.


After Successful Pin, Pinterest can not redirect to my (Requested) App

Hi,
I have integrated iOS PDK in my app (by following your documentation) and trying to Pin an image by using [PDKPin pinWithImageURL: ]. When I click on PinIt button in my app, PDK behaves as mentioned below.
Case 1 : If Pinterest App Not Installed in My Device
PinterestSDK will authenticate user through Safari browser & even I provide valid credentials it's displaying authentication failed and also getting below error in my console. But Image has been Pinned in my Pinterest board. May I know why it's going to FailureBlock & returns like that?

Case 2 : If Pinterest App Already Installed in My Device
PinterestSDK will authenticate user via Pinterest app & in this case also even I provide valid credentials it's displaying authentication failed and I am not getting above error here. But Image has been Pinned in my Pinterest board. May I know why it's going to FailureBlock & returns like that?
In both of above 2 cases, after image has been Pinned to my selected board, the request not came back to my app (from which we have requested) and but it's displaying success message.
I have followed your documentation with out fail anything.
So please help me on this issue and looking forward for your response.
Thanks,
Kayasiri.

What version of the pod are you using? This sounds like it could be an issue we fixed recently. Make sure to point your pod to the latest commit.

@rcancro
Hi Ricky,
I am not using any pod in this project and I recently downloaded (on Nov 02nd 2015) your pdk again from Github and I have added all dependency & required classes / files to my project and there is no any build errors. I thought the downloaded pdk may contains your latest commit also. I checked my system and pod version is 0.39.0. Is it mandatory the use of pod in order to integrate your iOS PDK in my project?
As you said in ticket #10, your latest commit (pod 'PinterestSDK', :git => 'git@github.com:pinterest/ios-pdk.git', :commit => '9cc111bc728a7c6dd9f1c77df01b18191685b62a')  will resolve only invalid client_id issue.
My doubt is, why I am getting this error -canOpenURL: failed for URL: "pinterestsdk.v1://oauth/?app_name=Pinterest&permissions=read_public%2Cwrite_public%2Cread_private%2Cwrite_private%2Cread_relationships%2Cwrite_relationships&client_id=4792222935410545828" - error: "(null)" If I am not having Pinterest app on my device and why it's not came if I have Pinterest app on my device. I think it's not mandatory all devices should have Pinterest app.
But in both of the cases(with or with out Pinterest app on my device), I am able to Pin an image to my board and request can not coming back to my app and also it's always going to failureBlock even though I am giving valid credentials. May I know why it's happening like this?
FYI, Your example app also behaves same as above.
I already added below one to my plist file.
  <key>LSApplicationQueriesSchemes</key>
<array>
	<string>pinterestsdk.v1</string>
</array>
<key>NSAppTransportSecurity</key>
<dict>
	<key>NSAllowsArbitraryLoads</key>
	<true/>
	<key>NSExceptionDomains</key>
	<dict>
		<key>pinimg.com</key>
		<dict>
			<key>NSIncludesSubdomains</key>
			<true/>
			<key>NSThirdPartyExceptionAllowsInsecureHTTPLoads</key>
			<true/>
			<key>NSThirdPartyExceptionRequiresForwardSecrecy</key>
			<false/>
		</dict>
		<key>pinit</key>
		<dict>
			<key>NSIncludesSubdomains</key>
			<true/>
			<key>NSThirdPartyExceptionRequiresForwardSecrecy</key>
			<false/>
		</dict>
	</dict>
</dict>

I have also defined redirect URI as pdk4792222935410545828 in my app.
Please help me on this issue and looking forward for your response.
Thanks,
Kayasiri.

Hey @kayasiri,
I guess @rcancro means commit 21d1a4c on master. Does this solves your problem?
FWIW: We currently although experience authentication errors with Safari and the Pinterest App on some devices.

If I am trying to integrate iOS-pdk in a new project using pod (version 0.39.0) by following your [documentation] (https://developers.pinterest.com/docs/sdks/ios/), But I am getting below error.

Below is my Podfile

So I saw #1 , changed my Podfile as below and now I am able to integrate iOS-pdk in my new project using pod.

But there is no use because same errors (like oauth nil error if there is no Pinterest app on my device, no redirection to my app weather Pinterest app available or not) I am getting even now.
@mkalmes I have updated my Podfile to point to the [commit 21d1a4c] (https://github.com/pinterest/ios-pdk/commit/21d1a4c8cdbb47046ef0d6e2568b9027ef2e1f5f) as you suggested, but this is also not resolved my problem i.e. request not coming back to my app after successful Pin.
While performing authentication the request coming back to my app (weather it's success or failure, actually it's returning failure for valid credentials also),  then why request not coming back to my app for successful Pin also, just it's displaying success message as a Toast as shown in below image (at bottom left).

FYI, I am using Xcode 7.1 & iPad with iOS 9.1

Hi Team,
Any response on this,  please give your comments on this in order to resolve this issue.
Thanks,
Kayasri.

Hi Team,
Any response on this?
Thanks,
Kayasiri.

@kayasiri  Double check to make sure your Bundle IDs match in your app and in your Pinterest App Developer page. For some reason found mine didn't match, I fixed it, and now my redirect works great.

Hi @parkerdonat
Thank you for your response.
I have checked my Bundle IDs and I am maintaining same at my app and my Pinterest App Developer page.
I have checked my app, now authentication working properly with out any issues in both cases (weather Pinterest app installed or not on my device) and redirecting to my authentication success block.
But still request not coming back after successful Pin if user is not having Pinterest app on device, could you please resolve this issue also.
Note: I have made all configurations at my app side as per your  [PinterestSDK for iOS Guide] ( https://developers.pinterest.com/docs/sdks/ios/)
Also you have to resolve #35 issue also.
Thanks & Regards,
Kayasiri.

@kayasiri  Oh! I see your issue. Mine doesn't work either. I am sure they are working on a fix. They have been good at fixing issues. On the bright side, a lot of people have the Pinterest app installed already.

Thank you @parkerdonat for your response. I will be waiting for your fix.
If possible, could you please update this issue status once it will be fixed.
Thanks & Regards,
Kayasiri.

Is there is anyway to remove/hide third party login options (Facebook,Twitter,Google) from pinterest Oauth login screen. Currently I am having redirection issues with thridparty login services in IOS CNA browser. After the authentication pinterest API not redirecting back to the callback url. Sometimes it redirecting back to pinterest homepage and sometimes its got keep looping.

Seems like this issue with redirecting back from Safari still not fixed. @rcancro could you please ping other teams (Front-end/MobileWeb/etc.) about it? Redirecting works ok from native application, but if it's not installed redirect is broken. Page just closed in Safari and do nothing. For our business goals when App used in Kiosk mode we would not like have Pinterest app installed on that devices.
WebPage popup option with clear cookies like FB does will be the best option though, let me know if you're working on something similar to Facebook modal UIWebView pop up.
And please, fix this redirect issue, it should be pretty easy. As I see from https://github.com/pinterest/ios-pdk/blob/master/Pod/Classes/PDKPin.m#L116 you did not send AppID to web page, that might be an issue.

I can confirm that this is not working properly right now. We will redirect to Safari, but at that point we are using mobile web to pin, and it has no knowledge how we got there. I will have to talk with someone on the backend to see if they can provide this. I can't give a timeline as my guess is that it won't be a very high priority for anyone.
With the move to SarfariViewController, the interaction on iOS9 is now a modal web VC opens in the client app, with a done button at the top left the user can tap when they have finished pinning. While this isn't ideal, it is probably the best solution that we will have for some time.

I have also same issues came. Can you please suggest me. If any one fix this issues means update me. Follow the same tutorial but can not redirect to my app..


Fix typo, empy -> empty

Found via codespell -H
Change Summary

PR Checklist

[x] I have read and signed the Contributor License Agreement.

:partying_face: :partying_face: :partying_face: :partying_face: :partying_face:


Style Guide

Code for America has a brilliant style guide https://style.codeforamerica.org
However as a branding element, my understanding is it should only be used for the main CFA site.
As this project is multi-brigade and under CFA, would it make sense to maintain the visual identity on the map site and any landing sites, or a more unique look?
Currently the map site uses bulma.io for default styling with a few overrides.

Decided on no style guide but we are using the colors from that guide


Make the Velcom logo/title link to Home

...because I always try clicking on it

It does tempt you to click on it...
If we turn the logo into a second home button, so to say, should clicking on it also refresh the page (referring to issue #148)?

Ah, yes, it probably should :)


YARN-10005. Code improvements in MutableCSConfigurationProvider

Description of PR
Code improvements in MutableCSConfigurationProvider class:

Created ConfUpdateAssembler class to contain logic for ConfUpdate map creation from mutation info
Eliminated duplicated code block (9 lines) in init / formatConfigurationInStore methods
Changed method "getConfStore" to package-private

How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 57s

trunk passed

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m  5s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  8s

trunk passed

+1 :green_heart:
mvnsite
1m 10s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 14s

trunk passed

+1 :green_heart:
shadedclient
22m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
1m  2s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  2s

the patch passed

+1 :green_heart:
compile
0m 55s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 55s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 44s

the patch passed

+1 :green_heart:
mvnsite
0m 56s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 59s

the patch passed

+1 :green_heart:
shadedclient
21m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
99m  3s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
asflicense
0m 46s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

201m  3s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5115

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b4cb5f9d1268 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c12e9b829c110d675d8895470560800b6313e5ec

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/1/testReport/

Max. process+thread count
990 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m  8s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m  4s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 13s

trunk passed

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 52s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 14s

trunk passed

+1 :green_heart:
shadedclient
22m  5s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
1m  1s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  1s

the patch passed

+1 :green_heart:
compile
0m 52s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 52s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 47s

the patch passed

+1 :green_heart:
mvnsite
0m 58s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 59s

the patch passed

+1 :green_heart:
shadedclient
21m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
103m  4s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-server-resourcemanager in the patch passed.

-1 :x:
asflicense
0m 45s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

203m 36s

Reason
Tests

Failed junit tests
hadoop.yarn.server.resourcemanager.webapp.TestRMWebServices

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5115

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux f0a9d8ec130a 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 398f88e5a5cee57e56bfaff5bfce0dc08dee9de8

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/2/testReport/

Max. process+thread count
973 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m  1s

trunk passed

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m  6s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  3s

trunk passed

+1 :green_heart:
mvnsite
1m 12s

trunk passed

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 16s

trunk passed

+1 :green_heart:
shadedclient
21m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
1m  0s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  0s

the patch passed

+1 :green_heart:
compile
0m 58s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 49s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
mvnsite
1m  3s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  4s

the patch passed

+1 :green_heart:
shadedclient
21m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
99m  5s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

199m 49s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5115

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b92795902d53 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bc59203a11fb19851d6215050c15818c509151ad

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/3/testReport/

Max. process+thread count
961 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 25s

trunk passed

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 12s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 22s

trunk passed

+1 :green_heart:
shadedclient
22m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
1m  3s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  3s

the patch passed

+1 :green_heart:
compile
0m 57s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 57s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 48s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 57s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  2s

the patch passed

+1 :green_heart:
shadedclient
21m 18s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
99m  5s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

201m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5115

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6547d975e2d1 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 04bc57facbeedf7e3894664ff98ea103a74e4793

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/4/testReport/

Max. process+thread count
976 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 37s

trunk passed

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m  5s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 12s

trunk passed

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 17s

trunk passed

+1 :green_heart:
shadedclient
22m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  1s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 42s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 14 new + 0 unchanged - 0 fixed = 14 total (was 0)

+1 :green_heart:
mvnsite
0m 56s

the patch passed

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  1s

the patch passed

+1 :green_heart:
shadedclient
21m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
99m  5s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

201m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5115

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux bf5ac2257347 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2f8482501597bf9303d65cc261ac87be97851787

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/5/testReport/

Max. process+thread count
941 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 13s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 42s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m  9s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 17s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 24s

trunk passed

+1 :green_heart:
shadedclient
24m  1s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
24m 26s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  3s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
compile
1m  0s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m  0s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 46s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
1m  0s

the patch passed

+1 :green_heart:
javadoc
0m 44s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 14s

the patch passed

+1 :green_heart:
shadedclient
23m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
105m 16s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

212m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5115

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e1ab0ebf7e22 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cad2edcafa9387977f69b726454f44356331f442

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/7/testReport/

Max. process+thread count
949 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m  8s

trunk passed

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  2s

trunk passed

+1 :green_heart:
mvnsite
1m 14s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 20s

trunk passed

+1 :green_heart:
shadedclient
22m 50s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m 11s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
1m  1s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  1s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 42s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
1m  0s

the patch passed

+1 :green_heart:
javadoc
0m 42s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 40s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  3s

the patch passed

+1 :green_heart:
shadedclient
22m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 17s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

205m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5115

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 1525e7f89d59 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ca8333e02e16d3e51986ef938253588d8569429e

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/8/testReport/

Max. process+thread count
939 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 11s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m 35s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m  8s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 59s

trunk passed

+1 :green_heart:
mvnsite
1m 10s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 18s

trunk passed

+1 :green_heart:
shadedclient
22m 39s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
23m  5s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 56s

the patch passed

+1 :green_heart:
compile
1m  0s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m  0s

the patch passed

+1 :green_heart:
compile
0m 54s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 54s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 42s

the patch passed

+1 :green_heart:
mvnsite
0m 59s

the patch passed

+1 :green_heart:
javadoc
0m 43s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 47s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  6s

the patch passed

+1 :green_heart:
shadedclient
22m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
102m 44s

hadoop-yarn-server-resourcemanager in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

205m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5115

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 108b034dd35e 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4b8d134e6ad5ab96e2c149a839ec920ddec23ac6

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/9/testReport/

Max. process+thread count
950 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5115/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @p-szucs this seems good to me :)

Thanks @p-szucs for working on this.
Code LGTM, committed to trunk.


Implement subscription "draft" feature

Currently, subscriptions can only be set up by designated admins. Other users cannot make specialized subscriptions for their own DM notifications for example.
Main feature:

We can allow all users to create a draft of a subscription, and have them approved by an admin
Any further change to the subscription will need to be approved as well.
Non-admin users should only be able to see their own created subscriptions whenever they open the subscriptions modal.
Non-admin users should only be able to view, delete, or edit the draft for their own subscriptions. This should be enforced on the backend.
The same rules that apply to creating subscriptions (user must be a member of the given Jira project for example), should apply to creating/editing drafts. The admin approving must also have these same permissions to approve the subscription.
The same subscription modal can be used, but in "draft" mode.

Extras:
/jira subscribe list should indicate which subscriptions were drafted by non-admins, and any that have pending drafts. A non-admin user should only see their own subscriptions/drafts when they run this command.
We can also include the subscription id in the /jira subscribe list output. Then create a new command /jira subscribe edit (instance ID) to open up the modal for the subscription. The admin should be able to edit and/or approve any pending drafts.

@mickmister I would caution against this complexity... I think a user with this much subscription needs could make a channel specifically for this.
If they want to watch their own set of chosen notifications, I think we should consider adding notifications on "Watched" items in Jira for a user and notifying them via the bot.  I realize this isn't exactly the same as the ticket description. Customers have mentioned that sort of feature before, but not for creating all sorts of personal custom subscriptions.  Also, having the admin review them is really unappetizing to the admin...

@aaronrothschild

I think we should consider adding notifications on "Watched" items in Jira for a user and notifying them via the bot

Claimed HW ticket for this https://github.com/mattermost/mattermost-plugin-jira/issues/507
I think having custom subscriptions in your own DM would be immensely powerful and provide so much value. The subscriptions feature is likely very under-utilized in this regard. Users could have their own tailored notifications. If the admin doesn't want the feature on their server, they can disable it 🙂

Closing issues due to inactivity. This issue can be re-opened with more interest from our community.


Docker Build Support for Proxies

Simple conditional chain for passing environment proxies to docker build.
Additional support for anyone that has to alias go='http_proxy=<IP_ADDRESS>:8080 go' but also will not affect the general user.
Verified all cases work as expected :) Mostly this makes my automation life easier

Thank you for this


The name property of the Unit System is deprecated

As per https://github.com/home-assistant/core/pull/80257
The name of a unit system should never be used for checking its type. Instance checks should be used instead:
Correct:
if hass.config.units is IMPERIAL_SYSTEM:
    pass

if hass.config.units is METRIC_SYSTEM:
    pass

Incorrect:
if hass.config.units.name == CONF_UNIT_SYSTEM_IMPERIAL:
    pass

if hass.config.units.name == CONF_UNIT_SYSTEM_METRIC:
    pass

Note: the name property of the IMPERIAL_SYSTEM is likely to get adjusted as soon as 2022.11 so this is an advance warning

Fixed thanks @epenet 👍


All robot dimensions are wrong!

Description
Hi @hariharan20 @PabloEspejeLS , I did dig into the packages and I found that all the diminutions of the robot are wrong and does not represent the real robot that is hunter 2. so basically I did measure the diminutions on blender and found them less than the real robot, further more the wheel size is wrong as well!!
Action: you do not need to do anything as I have fixed that and pushed the changes, but I though to bring this up to avoid it in future.
Another note: I have reduced the model size by reducing the number of meshes, so the wheel file size has been reduced to 305.7 kB instead of 3 MB!! and the chassis from 7MB to 1.5 MB.

@hariharan20 I have updated the model to hunter 2


Fix typo

Well, it WAS bothering me. I don't want to be credited for this, of course, but at least fix it yourself when you have the chance, please.

Alright, I appreciate your reaction to this, no hard feelings eh.
I see lots of people try to gain "power" in oss projects by doing stuff like this.

I understand :)
I should've probably written a comment instead.


Enter code -> submit -> don't agree and close shows wrong screen

After submitting a successful code if the user doesn't agree on the next screen and instead closes the menu via sliding the menu(s) / pages down or via the cancel button the wrong page is displayed
Steps to reproduce
Enter a code + submit
Either slide down the menu or press cancel

The "in behind page" is the Daily share content.
https://github.com/cds-snc/covid-shield-mobile/issues/93

This is the correct behavior. What happens is that the OneTimeCode can only be claimed once. After entering the code, the app sends to server immediately to validate and generate private / public key for next step. When user is on consent screen, they have option to cancel it which should not navigate user back to OneTimeCode screen again. If user decides to accept the consent later, they won't be asked for the code again. However, there are some action items we could do here https://github.com/CovidShield/mobile/issues/149


Autonotify not working for webpack projects with codesplitting

Good afternoon all,
I'm getting the [Bugsnag] Ignoring cross-domain or eval script error. for all errors that are being thrown in my company's large React project.
Every error that I try to manually generate ends up being a Script error, and because of code splitting the errors always occur on line 0.

Is there a better way to detect whether or not an error is a CORS error? In the mean time I'm likely going to fork this repository and remove the CORS check.

Are you by any chance using eval or some derivation of that for your webpack "devtool" config option?

Currently we have devtool set to false

No, that should be ok. I just know that code generated from eval (as is the case with that webpack devtool setting) is a common source of this problem. We'll have to dig into this and see if there is some problem associated with code splitting specifically. Does the problem go away if you disable code splitting.
Also if you are hosting the assets on a different domain from the web server, have you followed these steps? https://docs.bugsnag.com/platforms/browsers/cors/

Hey @wordofchristian, did you get the chance to dig into this at all?
@mboperator did you get any further with the issue and/or did you have an answer to either of Christian's questions above?
Cheers!

Thanks for looking into this @bengourley, no I hadn't gotten a chance to dig into it.
Cheers

Closing due to inactivity. Feel free to open up if there is still an issue or there is more info to add.

Just confirmed that it is still an issue and I am not using devtool: eval on webpack and cross origin is set up properly, please reopen.

Hi @andrewjaanuu
Can you confirm you've followed the guidance here?
https://docs.bugsnag.com/platforms/javascript/cors/
Are you able to share an example project with steps to reproduce the issue, either here or by contacting us directly at<EMAIL_ADDRESS>


Fixed a bug when multiple entries existed for images with same day but different versions. It picks the latest saved image from the list

👍


Valid model is "is not ready"

First of all, Great Work!
When using this valid model, to classify bananas:
https://teachablemachine.withgoogle.com/models/38NDc7ERE/
the debugger says: "model is not ready"
(in the flow it's: "model not loaded").
Is it fixable? here's my flow:
[{"id":"c66a85b7.e30d58","type":"tab","label":"Flow 1","disabled":false,"info":""},{"id":"c4b4bcdf.7a551","type":"teachable machine","z":"c66a85b7.e30d58","name":"","modelUrl":"teachablemachine.withgoogle.com/models/38NDc7ERE/","output":"all","x":610,"y":260,"wires":[["7c484b9f.b58544"]]},{"id":"a9c665cb.3d9dc8","type":"image","z":"c66a85b7.e30d58","name":"","width":160,"data":"payload","dataType":"msg","thumbnail":false,"active":true,"x":600,"y":420,"wires":[]},{"id":"cc300434.61c488","type":"fileinject","z":"c66a85b7.e30d58","name":"","x":360,"y":320,"wires":[["c4b4bcdf.7a551","a9c665cb.3d9dc8"]]},{"id":"7c484b9f.b58544","type":"debug","z":"c66a85b7.e30d58","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","x":850,"y":340,"wires":[]}]

Thanks!

Be aware to put https:// at the begining of your URL, it works for me when changed to.

I will make a patch that will enable the URL to work with or without https://
Thanks!


Database header under Setup changed from 'Database' to 'Database log'

This is from versions 10.0.4 and a couple of versions earlier

:white_check_mark: Organization membership check passed
Requester is not a member of the MicrosoftDocs organization.


/backtests/read/portfolio returns BacktestResponse Model instead of BacktestPortfolioReponse

Expected Behavior
/backtests/read/portfolio endpoint returns BacktestPortfolioResponse Model
Actual Behavior
/backtests/read/portfolio endpoint returns BacktestResponse Model
Potential Solution
Fix RESTful API of /backtests/read/portfolio returning Holding as documented at https://www.quantconnect.com/docs/v2/cloud-platform/api-reference/backtest-management/read-backtest/portfolio
Reproducing the Problem
Needs API token, project_id and backtest_id to reproduce ...
https://www.quantconnect.com/docs/v2/cloud-platform/api-reference/backtest-management/read-backtest/portfolio
import base64
import hashlib
import time
import json
import requests

api_base = 'https://www.quantconnect.com/api/v2'
credentials = {
    "user-id": "<user-id>",
    "api-token": "<api-token>"
}

def auth_header():
    # Get timestamp
    timestamp = str(int(time.time()))
    time_stamped_token = credentials['api-token'] + ':' + timestamp

    # Get hased API token
    hashed_token = hashlib.sha256(time_stamped_token.encode('utf-8')).hexdigest()
    authentication = "{}:{}".format(credentials['user-id'], hashed_token)
    api_token = base64.b64encode(authentication.encode('utf-8')).decode('ascii')

    # Create headers dictionary.
    return {
        'Authorization': 'Basic %s' % api_token,
        'Timestamp': timestamp
    }

def get(payload, endpoint):
    # Create POST Request with headers (optional: Json Content as data argument).
    response = requests.post(api_base + endpoint,
                             data=payload,
                             headers=auth_header())
    if response.status_code == 200:
        return json.loads(response.text)
    else:
        print(response.content)
        raise Exception(response.status_code)

def pull_backtest(backtest_id, project_id):
    payload = {
        "projectId": project_id,
        "backtestId": backtest_id
    }
    backtest = get(payload, "/backtests/read")
    # returns same as above
    portfolio = get(payload, "/backtests/read/portfolio")
    print('backtest' in portfolio)  # shouldnt contain that key
    assert backtest['backtest'] != portfolio['backtest']  # Fails ... Same data

if __name__ == '__main__':
    pull_backtest(backtest_id="<your backtest id>", project_id=portfolio_id)

System Information
https://www.quantconnect.com/api/v2   on 2023-03-04
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues
[x] I have provided detailed steps to reproduce the issue

Presumably to be moved to a private repo handling QC public endpoints....


Ideation Hacks

RPG Game Progress

This is where I will track my progress for my RPG game.

-Created a RPG file in assets/js/

Add the background. js, gamecontrol.js, gameenv.js, and player.js within that file

Config.yml

Added references navigation/RPG.md for navigation

RPG.md: This allows you to keep all the code for your RPG game all in one place for easy access. This makes changes and updates easier and more efficient. You are able to see and comprehend the code much easier.
GameControl.js: Defines data for assets in the game and starts the game.
GameEnv.js: Uses a classic Java static class pattern that manages the game environment.
Background.js: Creates the background.
Player.js: Creates the player.


Support for readonly $ref

readonly $ref is not supported properly even though there are ways to define it in OpenAPI
Context

I have a model for an id, which I want to reference as readonly in other schemas.
Current Behavior

I tried the pre 3.1 way:
properties:
  id:
    readonly: true
    allOf:
      - $ref: ./Id.yaml
  createdOn:
    type: string
    format: date-time
    readOnly: true
  lastModifiedOn:
    type: string
    format: date-time
    readOnly: true

As well as the post 3.1 way:
properties:
  id:
    readonly: true
    $ref: ./Id.yaml
  createdOn:
    type: string
    format: date-time
    readOnly: true
  lastModifiedOn:
    type: string
    format: date-time
    readOnly: true

Expected Behavior

Out of curisoity does it help if you use readOnly: true instead of readonly: true?


[FEATURE] Add codepen

Description

add this to linkfree
Screenshots
No response
Additional information
No response

Kindly close this for the same reason as the pr


[Draft - Test] Add macOS 12 regression

Description of changes:
Testing the addition of a macOS 12 regression job. I cannot reproduce the failure in #1402 locally so I want to test with CI.
Resolved issues:
Related to #1402
Call-outs:

Testing:

How is this change tested? CI.

Is this a refactor change? No.

Checklist

[ ] Each commit message has a non-empty body, explaining why the change was made
[ ] Methods or procedures are documented
[ ] Regression or unit tests are included, or existing tests cover the modified code
[ ] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Closing this as it was just intended to test the regression on macOS 12 runners.


Newlines in text aren't being rendered

I'm experiencing the weirdest problem right now and I'm not sure where to start debugging it.
I used this package (https://github.com/AndreKR/multiface) to construct a font.Face that can fall back to other fonts in case of an unsupported character and I'm trying to use it to render text that contains newlines, but for some reason, they're not being rendered.
What makes this weird is that in an older build of my program, it worked. Here's the string that was rendered and a screenshot of the newlines working:
const testText = "You are already dead.\nお前はもう死んでいる。\nLots of stuff going on here"

Now, a few days later, I of course changed a few things in the program, but to my knowledge none of these things should affect the text rendering. And yet:

This is the entirety of my main.go:
https://gist.github.com/SamusAranX/630eb50fb4b67da19dd3cc92cb7827ee
What could cause this?

Linebreaking was introduced recently https://github.com/hajimehoshi/ebiten/commit/bb60818e8d363f731717629f325c0d4414ef5b89#diff-779a691a4ced9509e0436d663a60db2e
You need to use Ebiten 1.11.* if you want to use this feature.

That would explain it! 😅
Between the first and the second screenshot, I created a go.mod file and it defaulted to 1.10.5, as that's the last proper release. Going with the latest commit fixed the problem.

OK, thank you for confriming!


Add $GLIDE_SKIP_INSTALL

Sometimes a user needs to skip the glide install step, setting
$GLIDE_SKIP_INSTALL to true skips the step.

Luv this, thanks! 👍


[Question/Documentation] How to use with MDX?

How to include stories defined in a x.stories.svelte in a MDX file?
import Stories from "./Component.stories.svelte"

The following methods all include the first story defined in the stories file:
<Canvas />
<Story />

I don't know what to set the of property to (Stories.Name doesn't work).

Update: apparently I was using import Stories instead of the one I should use: import * as Stories.
With the latter it works to use <Story of={Stories.Primary} /> (or any named story), although the IDE is giving me "Unresolved variable" warnings.


User Campaign - First open or click event time

Please provide your name and company
Justin - Fundrise
Link the issue/feature request which this PR is meant to address
https://github.com/fivetran/dbt_iterable/issues/48
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
This PR adds the new field first_open_or_click_event_at to help identify the first time someone interacted with a campaign.
How did you validate the changes introduced within this PR?
Local run.
Which warehouse did you use to develop these changes?
Snowflake
Did you update the CHANGELOG?

[x] Yes

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

[x] Yes

Typically there are additional maintenance changes required before this will be ready for an upcoming release. Are you comfortable with the Fivetran team making a few commits directly to your branch?

[x] Yes
[ ] No

If you had to summarize this PR in an emoji, which would it be?

🕚
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template

Community Pull Request Template (default)

Maintainer Pull Request Template (to be used by maintainers)

Thank you @justin-fundrise for opening this! We will be merging this into our release branch.


Include in Software Engineering Chapter

Description
Talking with industry, they would like to see a section included in the software engineering chapter around MVP, Minimum Viable Product.
This would work well for students to develop an understanding of within their courses as it means that they don't get bogged down by the huge nature of a project through the year. What can be developed, made and tested and then have the sprint cards created to add in the next features/release?
Checklist
Change the space in the box to an x for those you have completed. You can also fill these out after creating the issue.

[ ] I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number).

If this is a code related issue, please include the following in your description:

[ ] Steps to reproduce the behavior
[ ] The platform(s)/software you are encountering the issue on
[ ] The behavior you expect to see, and the actual behavior

This is a really good idea, and would be teaching students a valuable skill for industry. Dealing with scope creep is a big challenge!

MVP is mentioned in the UX section but it could definitely be expanded


docker for cpu: version too old

the mxnet version on docker hub seems way too old, hope that you can update the docker image together with the code base.
Environment
Operating System: Ubuntu 16.04 LTS with docker
MXNet version: Python
Steps to reproduce
1.docker pull dmlc/mxnet
2.docker run dmlc/mxnet python /mxnet/example/image-classification/train_mnist.py
3.404 not found

@mli

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!