Refinements to address accessibility issues

The changes are focused on improvements in the following browser / screen reader combinations:

Internet Explorer and JAWS
Firefox and NVDA
Safari and VoiceOver
iOS Safari and VoiceOver

..although we've also considered the NVDA and JAWS readers with each combination of Firefox, IE, and Chrome.
The changes are in part refinements to the markup of the component (type and placement of ARIA attributes), and in part changes to the detail and timing of ARIA live region updates ('status' updates in the terminology of the component).
Summary of refinements:

Ensure immediate announcement of hint/status text when field receives focus..
- Previously 'Select your country edit blank"
- Now 'Select your country combobox collapsed editable blank. Type in 2 or more characters for results."

On typing in a field with a 2 character minimum configuration (optional configuration)
- Previously typing  'a' .. the typing echo reads 'a', and nothing else
- Now reads 'a' .. then reads 'type in 2 or more characters for results'

On finding no search results..
- Previously, reads 'No search results dot' .. multiple times (up to 7 in NVDA)
- Now, reads 'No search results' a single time, and nothing else.

On finding search results
 - Previously typing a few characters e.g. 'as' .. reads '8 results are available' multiple times.
    Selecting one of the search results then reads "8 results are available, UK, 1 of 8 is selected dot" - multiple times
 - Now, reads '8 results are available' a single time
    Selecting one of the search results reads '8 results are available, UK, 1 of 8 is selected' once. (period removed)

Form fields are now visible in overview (NVDA Insert + F7 , rotor in VoiceOver)

(Related to the above) Form fields can now be selected directly using relevant form navigation key (e.g. key 'F' in NVDA)

Generally - no longer reads 'comma' or 'dot' on aria announce
(Refined the previous 'comma' approach  https://github.com/alphagov/accessible-autocomplete/issues/200#issuecomment-316755847
Now using a pair of aria live regions and flip-flopping between to work around React virtual DOM behaviour, which can otherwise trigger repeated, duplicate announcements)

Reduced overly verbose selection announce in JAWS on IE, by refining use of role=alert

Simplified aria live region 'div' elements (removed inner span element). Improves situation in JAWS on IE where aria live content would not otherwise be announced without first disabling 'virtual PC cursor' mode (which is on by default).

Introduced a general event debounce on status update (aria live region update). This delays and limits frequency of aria live updates, and has the following benefits:
 - Improves situation on Mac Safari / VoiceOver where typing echo can otherwise interrupt announcement of the aria live content.

 - Improves the rapid typing situation in IE + JAWS, where fast user input can sometimes fail to trigger announcement.

 - Improves a situation in NVDA where stale results are sometimes announced.
    e.g. when arriving at an initial result list and then filtering further by typing more characters, a situation can arise where the screen reader announces stale count information, e.g.
    '8 results are available, UK, 1 of 8 is selected' ..then ..
    'UK, 1 of 23'
    ..where the '23' relates to the size of initial result list.

Will re-open PR after our DAC evaluation and any other refinements or recommends that result :)

@markhunter27 thanks a lot Mark, we appreciate it!

Hi @nickcolley , I'm about to reopen  / recreate this PR. Would you prefer I squash my commits down into just three or four, with summarising comments within?
If you'd like to discuss before I raise another PR -  feel free to give me a shout.
You can hit the amended version with the latest set of changes here
Thanks :)

Hi @nickcolley
DAC have responded positively to our latest changes, so I've created a new PR. Unfortunately I can't re-open this one as I've since done some git rebase to tidy some of my commit history - sorry about that :)
There are a few extra changes in the new PR - a few extra refinements that were the result of further, more detailed testing, and from the DAC feedback.


how to build a navbar?

i want a navbar like home, about us, contact us, i want to customize it's style and also click on each of those and change current url
and if it's possible use reactive changing urls in SPA
i know one way is using lists, but i don't see nav element in stippleUI, also i don't know how tab component works or tapgroup because i don't know how to use target url there

Good point, thanks for raising this. Let us take a look and see what we can do. @AbhimanyuAryan @PGimenez

That's, in principal, possible with the QToolbar.
If you work with StippleUI this element is available via toolbar() and a first example is given in the doc string (?toolbar).
However, if it comes to SPA, you will probably want to use the Vue router, which we currently do not support. But you can build several apps which all use the same navbar. Or you can use the same model with different UIs for different routes.


Increase service quota under root account to cater for all students

Requested these quota

Service Quota
Required quota
Comment

ml.t3.medium
30 (already fulfilled)
1 per student + 2 instructors + buffer

ml.p3.2xlarge for training job usage
30 (requested)
1 per student + 2 instructors + buffer

ml.g4dn.xlarge for endpoint usage
30 (requested)
1 per student + 2 instructors + buffer

ml.g5.2xlarge for endpoint usage
56 (requested)
2 per student + 2 instructors + buffer

ml.g5.4xlarge for notebook instance usage
30 (requested)
1 per student + 2 instructors + buffer

ml.g5.12xlarge for training job usage
30 (requested)
1 per student + 2 instructors + buffer


Config flow could not be loaded: 500 Internal Server Error Server got itself in trouble

Describe the bug
Config flow could not be loaded: 500 Internal Server Error Server got itself in trouble
On initial setup of the integration
To Reproduce
Steps to reproduce the behavior:

Install Via HACs or Manually
Integrations > Add
"Config flow could not be loaded: 500 Internal Server Error Server got itself in trouble"

Expected behavior
Options to login via Hon?
Screenshots
.
Environment (please complete the following information):

Home Assistant Version: 2023.7.2
hOn Integration Version [e.g. 0.8.1, can be found in HACS or device log]
pyhOn Version 1.4.0

Additional context
n/a
Home Assistant Logs
n/a
Device Log
n/a
Data Archive
n/a

Hey, this looks strange, I didn't see anything like this before :thinking:
Can you see something in the home assistant logs?

It's fine now. I initially used HACS but tried manual and it worked   might
have been a hiccup on the download
On Mon, 24 Jul 2023, 20:36 Andre Basche, @.***> wrote:

Hey, this looks strange, I didn't see anything like this before 🤔
Can you see something in the home assistant logs?
—
Reply to this email directly, view it on GitHub
https://github.com/Andre0512/hon/issues/101#issuecomment-1648497248, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEVPI2UQSDQ72KPJKTL2VI3XR3FCFANCNFSM6AAAAAA2VJQH4Q
.
You are receiving this because you authored the thread.Message ID:
@.***>


i18n(fr): update tutorials/add-view-transitions.mdx

Description (required)

Add updates made to tutorials/add-view-transitions.mdx in #8707
Replace page "About" with page "À propos" (since the other ones are translated)
Translate a missing Update to Astro v4.x comment
Add a space before colon inside comments written in French
Remove some extra indent on new lines (it was messing with syntax highlighting)

Related issues & labels (optional)

Suggested label: i18n

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

fr
tutorials/add-view-transitions.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Hello @ArmandPhilippot Thanks for your update. There are two commits also need to update.

https://github.com/withastro/docs/pull/8723
https://github.com/withastro/docs/pull/7677

Thanks @liruifengv, I just added those two changes.


Computed properties should return null value by default

This issue needs to be merged into master before work on https://github.com/softlayer/sl-ember-components/issues/596 begins.  If it cannot be then work on it needs to be delayed until the release of v0.10.0


UI filter panel - first pass

This is a draft PR for v1 of the UI filter panel.
Features:

Filter types:

Typeahead filter for string columns. (Exact match or Starts with). The first option that is displayed in the list of suggestions is the starts with filter -- represented by whatever the user has typed followed by '...' (see pic below)
Range filter for number columns

Multiselect filters:

Apply any amount of exact-match filters per column
Up to one starts with filter per column.

Highlight columns that are being filtered: In the column selection dropdown, columns that have filter(s) applied are highlighted in blue
Reset filters: A "Clear" button that resets all filters

Note that the filter panel currently uses HTML elements and custom Icons instead of the existing salt components. These should be converted to salt components for a more unified look.

UPDATE:
Since I created this draft PR, I've done some refactoring on this.
I got rid of a lot of fluff and made the code more concise overall.
The TypeaheadFilter component could probably do with being broken down into smaller components as it is quite big, but I've left that with JJ.


Error while running tests: No library 'oxygen.OxygenLibrary' found.

When running tests I get the following error:
[ ERROR ] Calling method 'end_test' of listener 'oxygen.listener' failed: No library 'oxygen.OxygenLibrary' found.

@niecore can you share your test case how you are using the library? You can also refer to example provided

I found out, that the library needs to be imported for every file that contains test when the listener is active.
Even when there are no Keywords used from the oxygen library.
You can simply reproduce this by calling robotframework with the oxygen listener on a test suite that does not import the library.

Ah yes, that is correct and by design, as Oxygen will check every test case if it uses the library or not.
Will clarify this in documentation.

@niecore just to let you know, we managed to fix this completely in version 0.2 which was released yesterday :)

@Tattoo Thank you :)


[ci:component:github.com/gardener/hvpa-controller:v0.12.0->v0.13.0]

Release Notes:
Updated go to 1.19.9

A small golang bump from 1.19.7 to 1.19.9 - ref https://github.com/gardener/hvpa-controller/compare/v0.12.0..v0.13.0. Seems safe to include in the v1.70 milestone
/milestone v1.70

/lgtm
/approve

/retest-required


Misc updates to find_device(), wizard, and repr(device)

The way find_device() returned a tuple didn't sit right with me, so I made it return a dict instead.  This will also allow expanding the info returned in the future without breaking anything.  I screwed up and forgot to submit a PR for this before 1.7.1 dropped, but hopefully it's recent enough that this breaking change won't be too bad.
Wizard now detects more cloud errors, namely wrong Regions and Device IDs.  Fixes #195
I also updated repr to include a bit more information and what type of device it is.  Still not perfect and is missing some info (such as nodelay), but it's a lot better.

Awesome @uzlonewolf !  I love the wizard enhancement/fix and expanding repr!  On the find_device() API updates, I agree on your approach. I'll increment to 1.8.0 to keep with our versioning convention and note the minor breaking change form 1.7.1 in the release notes.  Thank you! 🙏


it is an error when select excel in mac systerm

@wcycxp thanks for report this issue.by the way,in native mode, you can use the system's file selection box
from nicegui import app, ui

async def choose_file():
    files = await app.native.main_window.create_file_dialog(allow_multiple=True)
    for file in files:
        ui.notify(file)

ui.button('choose file', on_click=choose_file)

ui.run(native=True)


[Android] Chiptool app on Xiaomi tab 5 is crashing while pairing with Thread devices

Reproduction steps
ChipTool app is crashing while pairing with thread device, only on Xiaomi Tab 5 android device. On all other devices it seems that commissioning works fine
Issue is detected on official <IP_ADDRESS> release and in latest pull from master on date 05.04.2024

reset Thread device
In chiptool app click "PROVISION CHIP DEVICE WITH THREAD"
Scan QR code from device
Observe

2024-04-05 11:22:50.076 19285-19285 chip.BluetoothManager   com.google.chip.chiptool             I  Starting Bluetooth scan
2024-04-05 11:22:50.076 19285-19285 BluetoothAdapter        com.google.chip.chiptool             D  isLeEnabled(): ON
2024-04-05 11:22:50.089 19285-24398 BluetoothLeScanner      com.google.chip.chiptool             D  onScannerRegistered() - status=0 scannerId=9 mScannerId=0
2024-04-05 11:22:50.102  2152-3205  AppOps                  system_server                        E  Bad call made by uid 1002. Package "com.google.chip.chiptool" does not belong to uid 1002.
2024-04-05 11:22:50.250 19285-24981 NsdManager...ceResolver com.google.chip.chiptool             I  service F70C8E279278876C-000000000001B669(chip.platform.NsdManagerServiceResolver$2@445e5cb) onServiceUnregistered
2024-04-05 11:22:50.683 19285-19285 chip.BluetoothManager   com.google.chip.chiptool             I  Bluetooth Device Scanned Addr: F0:82:C0:56:F2:26, Name Matter-539
2024-04-05 11:22:50.727 19285-19285 BluetoothAdapter        com.google.chip.chiptool             D  isLeEnabled(): ON
2024-04-05 11:22:50.746 19285-19285 DeviceProv...ngFragment com.google.chip.chiptool             I  showMessage:Connecting to Matter-539
2024-04-05 11:22:50.750 19285-19285 chip.BluetoothManager   com.google.chip.chiptool             I  Connecting
2024-04-05 11:22:50.752 19285-19285 BluetoothGatt           com.google.chip.chiptool             D  connect() - device: F0:82:C0:56:F2:26, auto: false, eattSupport: false
2024-04-05 11:22:50.752 19285-19285 BluetoothGatt           com.google.chip.chiptool             D  registerApp()
2024-04-05 11:22:50.752 19285-19285 BluetoothGatt           com.google.chip.chiptool             D  registerApp() - UUID=c1b2c0ee-2f5e-4aaa-80be-2b804f07cf16
2024-04-05 11:22:50.772 19285-24398 BluetoothGatt           com.google.chip.chiptool             D  onClientRegistered() - status=0 clientIf=9
2024-04-05 11:22:51.060 19285-24981 NsdManager...ceResolver com.google.chip.chiptool             I  service F70C8E279278876C-000000000001B669(chip.platform.NsdManagerServiceResolver$2@13974c1) onServiceRegistered
2024-04-05 11:22:51.076 19285-24398 BluetoothGatt           com.google.chip.chiptool             D  onClientConnectionState() - status=0 clientIf=9 device=F0:82:C0:56:F2:26
2024-04-05 11:22:51.091 19285-24398 chip.BluetoothManager   com.google.chip.chiptool             I  Matter-539.onConnectionStateChange status = 0, newState=2
2024-04-05 11:22:51.091 19285-24398 chip.Bluet...tateChange com.google.chip.chiptool             I  Discovering Services...
2024-04-05 11:22:51.092 19285-24398 BluetoothGatt           com.google.chip.chiptool             D  discoverServices() - device: F0:82:C0:56:F2:26
2024-04-05 11:22:51.099 19285-24398 BluetoothGatt           com.google.chip.chiptool             D  onConfigureMTU() - Device=F0:82:C0:56:F2:26 mtu=247 status=0
2024-04-05 11:22:51.102 19285-24398 chip.BluetoothManager   com.google.chip.chiptool             D  Matter-539.onMtuChanged: connecting to CHIP device
2024-04-05 11:22:51.103 19285-19285 DeviceProv...ngFragment com.google.chip.chiptool             I  showMessage:Pairing
2024-04-05 11:22:51.118 19285-19285 CTL                     com.google.chip.chiptool             D  setDeviceAttestationDelegate() called
2024-04-05 11:22:51.118 19285-19285 ChipDeviceController    com.google.chip.chiptool             D  Bluetooth connection added with ID: 1
2024-04-05 11:22:51.118 19285-19285 ChipDeviceController    com.google.chip.chiptool             D  Pairing device with ID: 6
2024-04-05 11:22:51.118 19285-19285 CTL                     com.google.chip.chiptool             D  pairDevice() called with device ID, connection object, and pincode
2024-04-05 11:22:51.118 19285-19285 IN                      com.google.chip.chiptool             D  BleConnectionComplete: endPoint 0x72ce9b74b8
2024-04-05 11:22:51.118 19285-19285 DL                      com.google.chip.chiptool             D  Received GetMTU
2024-04-05 11:22:51.118 19285-19285 AndroidBleManager       com.google.chip.chiptool             D  Android Manufacturer: (Xiaomi)
2024-04-05 11:22:51.118 19285-19285 AndroidBleManager       com.google.chip.chiptool             D  Android Model: (21051182G)
2024-04-05 11:22:51.118 19285-19285 DL                      com.google.chip.chiptool             D  Received SendWriteRequest
2024-04-05 11:22:51.118 19285-19285 AndroidBleManager       com.google.chip.chiptool             E  Bad service
2024-04-05 11:22:51.118 19285-19285 IN                      com.google.chip.chiptool             E  Failed to establish BLE connection: src/ble/BLEEndPoint.cpp:132: Ble Error 0x00000407: GATT write characteristic operation failed
2024-04-05 11:22:51.118 19285-19285 IN                      com.google.chip.chiptool             D  Clearing BLE pending packets.
2024-04-05 11:22:51.118 19285-19285 BLE                     com.google.chip.chiptool             D  Auto-closing end point's BLE connection.
2024-04-05 11:22:51.118 19285-19285 DL                      com.google.chip.chiptool             D  Received CloseConnection
2024-04-05 11:22:51.118 19285-19285 BluetoothGatt           com.google.chip.chiptool             D  close()
2024-04-05 11:22:51.118 19285-19285 BluetoothGatt           com.google.chip.chiptool             D  unregisterApp() - mClientIf=9
2024-04-05 11:22:51.120 19285-19285 chip.BluetoothManager   com.google.chip.chiptool             D  onCloseBleComplete
2024-04-05 11:22:51.120 19285-19285 IN                      com.google.chip.chiptool             E  Failed to setup BLE endPoint: src/ble/BLEEndPoint.cpp:132: Ble Error 0x00000407: GATT write characteristic operation failed
2024-04-05 11:22:51.120 19285-19285 IN                      com.google.chip.chiptool             D  SecureSession[0xb4000072f507b480]: Allocated Type:1 LSID:56512
2024-04-05 11:22:51.120 19285-19285 SC                      com.google.chip.chiptool             D  Assigned local session key ID 56512
2024-04-05 11:22:51.120 19285-19285 EM                      com.google.chip.chiptool             D  <<< [E:20950i S:0 M:194076920] (U) Msg TX to 0:0000000000000000 [0000] [BLE] --- Type 0000:20 (SecureChannel:PBKDFParamRequest)
2024-04-05 11:22:51.120 19285-19285 IN                      com.google.chip.chiptool             E  SendMessage() to BLE failed: src/transport/raw/BLE.cpp:102: CHIP Error 0x00000003: Incorrect state
2024-04-05 11:22:51.120 19285-19285 IN                      com.google.chip.chiptool             D  SecureSession[0xb4000072f507b480]: Released - Type:1 LSID:56512
2024-04-05 11:22:51.120 19285-19285 DIS                     com.google.chip.chiptool             D  Closing all BLE connections
2024-04-05 11:22:51.120 19285-19285 CTL                     com.google.chip.chiptool             E  Failed to pair the device.
2024-04-05 11:22:51.133 19285-19285 AndroidRuntime          com.google.chip.chiptool             E  FATAL EXCEPTION: main
                                                                                Process: com.google.chip.chiptool, PID: 19285
                                                                                chip.devicecontroller.ChipDeviceControllerException: src/transport/raw/BLE.cpp:102: CHIP Error 0x00000003: Incorrect state
                                                                                at chip.devicecontroller.ChipDeviceController.pairDevice(Native Method)
                                                                                at chip.devicecontroller.ChipDeviceController.pairDevice(ChipDeviceController.java:223)
                                                                                at chip.devicecontroller.ChipDeviceController.pairDevice(ChipDeviceController.java:165)
                                                                                at com.google.chip.chiptool.provisioning.DeviceProvisioningFragment$startConnectingToDevice$1.invokeSuspend(DeviceProvisioningFragment.kt:229)
                                                                                at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                                                                                at kotlinx.coroutines.DispatchedTask.run(Dispatched.kt:241)
                                                                                at android.os.Handler.handleCallback(Handler.java:942)
                                                                                at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                at android.os.Looper.loopOnce(Looper.java:211)
                                                                                at android.os.Looper.loop(Looper.java:300)
                                                                                at android.app.ActivityThread.main(ActivityThread.java:8503)
                                                                                at java.lang.reflect.Method.invoke(Native Method)
                                                                                at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:561)
                                                                                at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:954

xiaomi crash.txt
Platform
android
Platform Version(s)
v<IP_ADDRESS>
Type
Manually tested with SDK
(Optional) If manually tested please explain why this is only manually tested
No response
Anything else?
No response

Any updates? or information is this issue affecting more then this device (is it SoC, manufacturer etc issue?)

Hi, @igor90ns
It seems to me we can suppress ChipDeviceControllerException when invoking pairing API for android, but the root cause is related to BLE Gatt Service,  you may check whether svcId is null or not with your debugging build.
You mention "On all other devices it seems that commissioning works fine", I assume this fails with the particular thread device, which seems to soemthing wrong on its BLE configuration. with that thread device
https://github.com/project-chip/connectedhomeip/blob/90732b256ee1b405d7461f69eb8e25abe700c805/src/platform/android/java/chip/platform/AndroidBleManager.java#L357
UUID svcUUID = convertBytesToUUID(svcId);
BluetoothGattService sendSvc = bluetoothGatt.getService(svcUUID);
if (sendSvc == null) {
  Log.e(TAG, "Bad service");
  return false;
}

@igor90ns
I also found a similar issue. (LG Valvet in Android 12 version.)
Can you check if it is modified with the PR I uploaded?

@igor90ns feel free to reopen or create a new issue if it is still problematic


[Bots][Addedinlineimagesection][1466405]

Added Fetching inline images from message section with code and changed basic example C# code and added image and hyperlink. Please review.

Docs Build status updates of commit 0589087:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/bots/inline-image.png
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/bots-filesv4.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0589087:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/bots/inline-image.png
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/bots-filesv4.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 2bd3fe9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/bots/inline-image.png
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/bots-filesv4.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 91129ef:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/bots/how-to/bots-filesv4.md
:warning:Warning
View
Details

msteams-platform/resources/bot-v3/bots-text-formats.md
:warning:Warning
View
Details

msteams-platform/assets/images/bots/inline-image.png
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/bots-filesv4.md

Line 308, Column 40: [Warning-bookmark-not-found] Cannot find bookmark '#code-sample' in 'bots/how-to/conversations/conversation-basics.md'.

msteams-platform/resources/bot-v3/bots-text-formats.md

Line 82, Column 26: [Warning-insecure-link] Link 'http://aka.ms/Fo983c' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 9862113:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/resources/bot-v3/bots-text-formats.md
:warning:Warning
View
Details

msteams-platform/assets/images/bots/inline-image.png
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/bots-filesv4.md
:white_check_mark:Succeeded
View

msteams-platform/resources/bot-v3/bots-text-formats.md

Line 82, Column 26: [Warning-insecure-link] Link 'http://aka.ms/Fo983c' is insecure. Links to Microsoft sites must use 'https' instead of 'http'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7ab76d6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/bots/inline-image.png
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/bots-filesv4.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8162d4b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/bots/inline-image.png
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/bots-filesv4.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@Wajeed-msft - kindly review / approve the PR. Thank you.


Citation

Hi, we are immensely grateful for the release of the codebase, which enabled us to fine-tune LLaMA in JAX. Is there a standardized way to cite this repo in a paper?

I'm glad to hear that you find it useful for your research. You can use the following bibtex:
@software{geng2023easylm,
  author = {Geng, Xinyang},
  title = {EasyLM: A Simple And Scalable Training Framework for Large Language Models},
  month = March,
  year = 2023,
  url = {https://github.com/young-geng/EasyLM}
}


anki-bin: 2.1.36 -> 2.1.38

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

/marvin opt-in
/status needs_reviewer

Result of nixpkgs-review pr 107867 run on x86_64-linux 1

1 package built:

anki-bin

Result of nixpkgs-review pr 107867 run on x86_64-darwin 1

1 package built:

anki-bin

Thanks!


Empty content in Rich Text

Hey community!
We are now considering some changes in handling default empty value in Rich Text element. For now the empty value returned by Kontent Delivery equals to empty paragraph (

). How Java SDK will be affected if the empty value would be empty string? Could this be the breaking change for the SDK?

@aweigold - could you take a quick look?

I would recommend adding a test to DeliveryClientTest.java witch mocked empty rich text element as was done i.e. in PHP Kontent delivery SDK: https://github.com/Kentico/kontent-delivery-sdk-php/pull/88


[Help wanted] Custom event view not rendering on IE11

So my issue is that I created a custom event component and it works well under Chrome but not displayed on IE11. You can see a basic test code under. Please help if you had this issue before THX!
`const CustomEvent = (event) => {
return (

test

);
};
<BigCalendar
components={{ event: CustomEvent }}
culture="hu"
defaultView="month"
endAccessor="ends_on"
events={this.props.events}
onSelectEvent={(event) => {
this.showModal(event);
}}
popup
selectable
startAccessor="starts_on"
titleAccessor="name"
views={{ month: true }}
/>`

The problem was with the date format same as here: https://github.com/intljusticemission/react-big-calendar/issues/123


Add fullWidth for large size screen display

Signed-off-by: Junqiu Lei<EMAIL_ADDRESS>Description
Add fullWidth property to some components to make sure layout okay at large size screen(e.g. 32 inch screen) .
Before:

After:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #182 (576a81a) into main (7eb646e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   87.64%   87.64%
=======================================
  Files           6        6
  Lines         178      178
  Branches       24       24
=======================================
  Hits          156      156
  Misses         16       16
  Partials        6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Adding support for Doubao API

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Add support for Doubao API.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:

[ ] Pre-commit or other linting tools are used to fix the potential lint issues.
[ ] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[ ] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[ ] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
[ ] CLA has been signed and all committers have signed the CLA in this PR.

@LeavittLang  Please fix the lint issue with pre-commit

@LeavittLang Please fix the lint issue with pre-commit

fixed


Candles

http://<IP_ADDRESS>/api/products/BTC-USDT/candles?granularity=60 is returning  candles of interval 1, or 60 seconds? Your granularity parameter is in seconds? I believe this is typically expressed as 1 (for 1 minute) 15 (for 15 minutes) 30, 60,120,240, 1440 (a day). I can resample the candles from one minute but I will have to query the candle maker every 6 hours and store the candles in a separate database.
As such the return of 1000 rows typically won't even cover a whole day and isn't very usefull on candle charts. At 1 hour intervals  this will be less than 24 candles, which is not very usefull as "historical" data.

The unit of granularity is seconds, because the API interface format of gitbitex references CoinbasePro. You can modify the code of ProductController.java to make adjustments.
@GetMapping("/api/products/{productId}/candles")
    public List<List<Object>> getProductCandles(@PathVariable String productId, @RequestParam int granularity,
                                                @RequestParam(defaultValue = "1000") int limit) {
        PagedList<Candle> candlePage = candleRepository.findAll(productId, granularity / 60, 1, limit);

        //[
        //    [ time, low, high, open, close, volume ],
        //    [<PHONE_NUMBER>, 0.32, 4.2, 0.35, 4.2, 12.3 ],
        //]
        List<List<Object>> lines = new ArrayList<>();
        candlePage.getItems().forEach(x -> {
            List<Object> line = new ArrayList<>();
            line.add(x.getTime());
            line.add(x.getLow().stripTrailingZeros());
            line.add(x.getHigh().stripTrailingZeros());
            line.add(x.getOpen().stripTrailingZeros());
            line.add(x.getClose().stripTrailingZeros());
            line.add(x.getVolume().stripTrailingZeros());
            lines.add(line);
        });
        return lines;
    }


Resolve links to Java and JavaFX Javadocs

This will improve the Javadocs.

Thanks, merged. I also uploaded the updated Javadocs.


Plugin Health Check Failed

I always get the error "Plugin Health Check Failed" with my own CSV file as well as with your example file from the other case

Hm. I'll look into this, but it sounds like it could be a network issue then? Could you open the browser DevTools to get more information about the failing request?

But the File is on the same machine and I tried with IP and localhost. Could it be a problem with ARM or Encoding? I‘m using Grafana 7.3.4 on Raspberry Pi. What do I have to look for in DevTools?

Status of GET 	http://IP:3000/api/datasources/3/health is 500 Internal Server Error
updated to grafana 7.3.5, same Result

Unfortunately, the plugin doesn't yet support local files. I'll make sure to add it to the README for clarification. I've also created an issue to discuss local file support.

The file is on the same device but is not accessed locally but is published via Apache. Does this not work?

Hm. That should work. I'll be able to debug this more the coming week. I think I have enough information to reproduce this. Thanks!

I've just published v0.2.0 which adds initial support for local CSV files, in case you can't get it to work with Apache.

I've just published v0.2.0 which adds initial support for local CSV files, in case you can't get it to work with Apache.

Thx for the plugin :)
Tested v0.2.0
Always end up in "Plugin health check failed"
Using it then with local
POST https://foobar:3000/api/ds/query 500 (Internal Server Error)
the format for the file is
/my/path/to.file
Thats right format? Unix permission granted to all...
Same Error for the test file ime_series_covid19_confirmed_global.csv - seems there is something odd access the DS?

Thx for the plugin :)
Tested v0.2.0
Always end up in "Plugin health check failed"
Using it then with local
POST https://foobar:3000/api/ds/query 500 (Internal Server Error)
the format for the file is
/my/path/to.file
Thats right format? Unix permission granted to all...
Same Error for the test file ime_series_covid19_confirmed_global.csv - seems there is something odd access the DS?

with version 0.3.0 it works, thanks

with version 0.3.0 it works, thanks

looks good with 0.3.0 thanks!

looks good with 0.3.0 thanks!

It doesn't work for me (version 0.3.3). Should a simple absolute file path like /path/to/file.csv work ? With grafana debug logging enabled, I see:
t=2021-02-17T15:39:22-0800 lvl=dbug msg="Received command to update data source" logger=datasources url=/path/to/file.csv
t=2021-02-17T15:39:22-0800 lvl=dbug msg="Applying default URL parsing for this data source type" logger=datasource type=marcusolsson-csv-datasource url=/path/to/file.csv
t=2021-02-17T15:39:22-0800 lvl=dbug msg="Data source URL doesn't specify protocol, so prepending it with http:// in order to make it unambiguous" logger=datasource type=marcusolsson-csv-datasource url=/path/to/file.csv
t=2021-02-17T15:39:22-0800 lvl=dbug msg="Not adding CSP header to response since it's disabled" logger=http.server
t=2021-02-17T15:39:22-0800 lvl=dbug msg="Not adding CSP header to response since it's disabled" logger=http.server
t=2021-02-17T15:39:22-0800 lvl=dbug msg="Not adding CSP header to response since it's disabled" logger=http.server
t=2021-02-17T15:39:22-0800 lvl=dbug msg="Querying for data source via SQL store" logger=datasources id=1 orgId=1
t=2021-02-17T15:39:22-0800 lvl=eror msg="Plugin health check failed" logger=context userId=1 orgId=1 uname=admin error="failed to check plugin health: health check failed" remote_addr=[::1]

If I add file://, I see:
t=2021-02-17T15:39:57-0800 lvl=dbug msg="Received command to update data source" logger=datasources url=file://path/to/file.csv
t=2021-02-17T15:39:57-0800 lvl=dbug msg="Applying default URL parsing for this data source type" logger=datasource type=marcusolsson-csv-datasource url=file://path/to/file.csv
t=2021-02-17T15:39:57-0800 lvl=dbug msg="Not adding CSP header to response since it's disabled" logger=http.server
t=2021-02-17T15:39:57-0800 lvl=dbug msg="Not adding CSP header to response since it's disabled" logger=http.server
t=2021-02-17T15:39:57-0800 lvl=dbug msg="Not adding CSP header to response since it's disabled" logger=http.server
t=2021-02-17T15:39:57-0800 lvl=dbug msg="Querying for data source via SQL store" logger=datasources id=1 orgId=1
t=2021-02-17T15:39:57-0800 lvl=eror msg="Plugin health check failed" logger=context userId=1 orgId=1 uname=admin error="failed to check plugin health: health check failed" remote_addr=[::1]

(Neither the http: nor file: urls works in Safari, are they required to ?)

@simonmichael Another user has run into the same issue it seems, I've created https://github.com/marcusolsson/grafana-csv-datasource/issues/37 where we can try tracking this down.


Storing PipelineRun and TaskRun deletion metadata

Earlier, data coming during deletion like timestamp weren't stored. This PR fixes that.

Changes

Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[ ] Tested your changes locally (if this is a code change)
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/cherry-pick @release-v0.12.x

/test pull-tekton-results-unit-tests

/cherry-pick release-v0.12.x


[TF 2.0 API Docs] tf.identity

URL(s) with the issue:
https://www.tensorflow.org/versions/master/api_docs/python/tf/identity
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/array_ops.py
Description of issue (what needs changing):
Raises listed and defined
Raises are not listed and defined
Usage example
No usage example provided
Submit a pull request?
Yes
https://github.com/tensorflow/tensorflow/pull/29316

Closing this issue since its resolved. Thanks!
https://www.tensorflow.org/api_docs/python/tf/identity?version=stable


Problem by padding and trim in Text

See http://embed.plnkr.co/hgf5Tb/
Display to Text instances and those rectangles.
t1, t2, t3 is OK, but t4 is not OK.
I fixed it.
(Trimmed texture has been reduced padding, don't reduce padding more)
Sorry for my poor english.

Thanks @ayamada!


can't connect to the databricks with grafana 9.0

Hi mullerpeter,
I couldn't connect to the databricks after I configured it as required. My grafana version is 9.0. Viewing the grafana documentation  shows that the interface is deprecated.
logs：msg="Request Completed" method=GET path=/api/datasources/236/health status=400

fixed 😊.


fix(models): add VanityUrl uses

The VanityUrl model used for the response from /guilds/{guild.id}/vanity-url is missing the uses field.
Despite what the aforementioned docs say, the code will not be null if the vanity url is not set, instead, you get a 403 response, so I did not make any additional changes beyond adding the uses field.

We just tested that, and have found out that code can be null.

We just tested that, and have found out that code can be null.

Well, the PR was just to add the uses, would you like me to open another PR for code, or just include that in this one?  Modifying the code field is a bit out of scope.

We just tested that, and have found out that code can be null.

Well, the PR was just to add the uses, would you like me to open another PR for code, or just include that in this one? Modifying the code field is a bit out of scope.

Yes, another PR fixing this would be ideal.


Upgrade volcano.sh/apis to 1.10.0-alpha.0 or above

What happened?

[ yes ] ✋ I have searched the open/closed issues and my issue is not listed.

Reproduction Code
Spark operator code works as expected but there is a critical vulnerability https://github.com/advisories/GHSA-5g3x-8g2v-r8x8 reported 9.3/10
Insecure permissions in volcano v1.8.2 allows attackers to access sensitive data and escalate privileges by obtaining the service account's token.
Expected behavior
There should not be any vulnerability . Upgrade  volcano.sh/apis to 1.10.0-alpha.0 or higher
Actual behavior
a critical vulnerability https://github.com/advisories/GHSA-5g3x-8g2v-r8x8 reported 9.3/10
Environment & Versions

Kubernetes Version: 1.16+
Spark Operator Version: v2.0.x/v1beta2-1.3.x-3.1.1 any other version
Apache Spark Version: 3.1.1 +  /3.5.2 +

Additional context
As ANCHOR report identifies a https://github.com/advisories/GHSA-5g3x-8g2v-r8x8 which is a Critical vulnerability,  volcano.sh/apis needs to be upgraded to 1.10.0-alpha.0 or above
Impacted by this bug?
Give it a 👍 We prioritize the issues with most 👍

@jacobsalway I see this is in master, but can you tell me in which release it will be updated?

@ChenYi015 we should probably do another release soon given it's been nearly 2 months since the last one.

I will release v2.1.0 ASAP.


Release: hotfix/vaultSSL

Release: hotfix/vaultSSL

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.araarum seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Annotations

Would it be possible to add in the annotations that Brandon has on his site? I'd love to read those alongside the books right from my ereader.
https://www.brandonsanderson.com/brandon-sanderson-online-library/#annotations

I've read most of thee on the website, but this sounds doable. I'll get to it someday.
Since switching between 2 ebooks won't really be the best way, do you have any suggestions on how to approach this better?

The eBook versions of Warbreaker (at least from Google Play and Amazon) handle it by putting all the annotations at the end and putting a link to the annotations for each chapter at the start and end of each chapter, and a link back at the start and end of every annotation. But I don't know if that's something that'd be a pain to automatically (or worse manually) do for the books, don't really know enough of how this sort of thing works.

This does sound doable, however the problem becomes complicated because you need to supply the ebook yourselves, which makes it hard to get right. So far what this project does:
[Content on the internet] -> [this project] -> ebooks :tada:
But in this case, we need to do:
[original book] + [annotations from the internet] -> [annotated ebooks]
This project can't provide the original book (for obvious copyright reasons), but making sure that the code works with all ebooks across multiple publishers+editions without breaking formatting etc is going to be tough.
But it would be sooo cool to read!

Yeah not sure how to do it, myself. Zero promises, but I might take a look at it, because I've been trying to get back into coding and this seems like something not too crazy. But then, I've never touched Ruby, so anything I make might be kinda ugly lol.

I just added annotation support to the Rhythm of War serialization. The annotations are picked from the reddit thread, which means I'll need to do a commit every week.
Please test and give feedback if this looks good?

I've got a hastily-written thing set up to add annotations to the EPUB version of Elantris, but since I haven't used Ruby before, some things are horribly ugly (surely there's a way to append the Hash s I need to append without 7 (!) nested merge statements?), so I'll need to neaten it up a bit (or a lot) before uploading it.
Unfortunately, it will likely only work with specific EPUBs, and will need some tweaking to work on other books. But it's progress!

Neat-o! :1st_place_medal:
Happy to merge this as an experimental feature whenever you're ready, and maybe work on making it more generic...

Opened the PR earlier today at #32
Not really sure how to have it pass a file or anything, so currently it requires downloading the repo and running the script, since I don't think you can add a file to the Docker folder easily. But otherwise it works well, and I've neatened it up somewhat so it's not as horrendus.
Over the next few days I'll look into modifying it to work for the Mistborn books probably.

Hmm. Just looked into adding annotations for the Mistborn books, but I just realized I only own the collections of 3 books rather than the individual eBooks, and so might not be able to do it. Sorry.


Camera.getSensorsData returns invalid data in SensorsData

Preliminary Checks

[X] This issue is not a duplicate. Before opening a new issue, please search existing issues.
[X] This issue is not a question, feature request, or anything other than a bug report directly related to this project.

Description
I tested SDK tutorial 7, and I get invalid data from the sensors.
On this line:
https://github.com/stereolabs/zed-sdk/blob/b30caa96b443ac0d4e77bf67eb7c8023d2b96bb5/tutorials/tutorial 7 - sensor data/cpp/main.cpp#L123
sensors_data looks like this:

Barometer timestamp looks OK (current timestamp starts with 0x17D46), other timestamps and numbers looks invalid. Booleans are also incorrect (> 1).
Sensors are working OK in ZED Sensor Viewer.
Steps to Reproduce

Run tutorial example 7: https://github.com/stereolabs/zed-sdk/tree/master/tutorials/tutorial 7 - sensor data/cpp
Use Windows 10, VS 2022 and latest SDK 4.1.2
Check returned data in SensorsData

Expected Result
Correct data and timestamps returned by getSensorsData
Actual Result
Incorrect data and timestamps returned by getSensorsData
ZED Camera model
ZED2i
Environment
OS: Windows 10 22H2
Visual Studio 2022 17.9.2, target: x64 debug
CMake 3.29.3
CUDA: v12.1
ZED SDK: v4.1.2

Anything else?
Might be related to https://github.com/stereolabs/zed-sdk/issues/567
I suspect offsets or struct padding inside SensorsData in Camera.hpp are incorrect or getSensorsData writes to invalid offsets. If whole struct is dumped, I can see 3 valid timestamps inside:
00007FF72826F701
>17D461C831AD56C8<
BD3BBC7247BDFE86
00007FF741296AA5
0000025C05D21030
0000000000000004
00007FF72812EB01
>17D461C8332B49B0<
3FE80000BFA00000
BEF4A60EBEE00000
3EC553BB3F451360
00000000425205B0
4121D31A3F7C1089
00000086696FE701
>17D461C833A55250<
BCDC301D3F7FE84B
369260003A84EC00
3F7FE6823CDC1EA9
BA1EB86A3BF51AF6
BBF41FACBA9F38EA
37CAF8003F7FFE23
0000000000000000
3F80000000000000
0000000000000000
0000000000000000
B0A351DC3377B30C
B0A351DCAECE79DC
B0063842337AE753
B0063843AECE79DE
00007FF7337885BD
0000000000000000
0000000000000000
BB833DC0BEEF18E7
BE610EE73E93E78D
BD942889C11CEF45
3D7A0000BF3B8000
BE4695AD3EABE000
3E4695ADC11A6A9B
00000000361D9204
0000000000000000
0000000036073880
0000000000000000
00000000360AD5C1
0000000000000000
0000000000000000

Any update about this?


Bug: P3.0.3 breaks UI layout

With the Polestar OTA Update to P3.0.3 a lot of UI elements got broken:

Most glaring:

Switch centers the On/Off label on the entire view, not on the switch itself
ImageButton and EditText got large default paddings and stretch the layout or make text invisible if defined to small
color_control_activates now provides a dark gray with poor contrast instead of orange or blue in case of Volvo

By now I have implemented a series of workarounds to make the app look as before the update. They will be released soon. Though I think this is unwanted behaviour by the OS and Polestar has to fix it.

Released with v0.26.2


Inv Tweaks sorting issue

Issue description:
Sorting inventory while in inventory that is not Crafting Grid sorts the hotbar.
https://dbot.serealia.ca/sharex/2017/08/302dfb22e9_%25pn_-2017-08-19_20-45-07.webm

Please report this on the InvTweaks tracker.

Has been reported, let me quote here:
"[...]it's their fault if they aren't correctly marking what slots correspond to what parts of the inventory."

I'm not sure what he means by that.


Adding bigint disclaimer

Please refer to https://github.com/moneyphp/money/issues/328

This is only acceptable with theoretical proof of the security limits. You did not provide any proof before. Only examples of vulnerabilities in libraries that provide unlimited integers usage. That is, however, not a proof of concept and therefore there is no ground to accept this PR.

I just posted this:
The Least Privilege Principle Applied to PHP Bigints
On the other hand, please refer to:
When must arbitrary precision arithmetic functions be used in PHP?
IMO, a disclaimer should be added informing users that in order for Money to work OK, your server needs to rely on special libraries for running precision arithmetic functions, and the attack surface of your app may be affected because of that.

@programarivm read your post and the discussion on the other thread.
I think there has been some misunderstanding, specifically about BIGINT != bigint and assuming that gmp/bcmath are mandatory.
The library uses string as the numeric representation, which allows, but does not enforce using BIGINT as the data type in your database.
The maximum numeric value which you can represent with Money is much bigger than PHP_MAX_INT thanks to this, but yeah, know your limits and use whichever data type makes sense in your persistence layer.

in order for Money to work OK, your server needs to rely on special libraries for running precision arithmetic functions

this is not correct. those are completely optional, you don't have to use them if you don't want to.
generally I agree with the principle, but I don't agree with all your reasoning:

What is a realistic max limit for money in my app?

Does my app need to use currencies?

These questions should probably be asked in the context of an application. However, this is a generic purpose library which chose to use currencies and tries not to limit the maximum amount you can represent with it. We found that this is the way we can provide a library for the most common use cases, but it might not fit for everyone for whatever reasons and that's perfectly fine.
TBH I am not against adding a note to the documentation, but I think that it should already be obvious to choose the appropriate data type for your application.

Doctrine and database is not the responsibility of this library. And that BC math and GMP would open a window of opportunity for security vulnerabilities is just speculation. I did not read any proof for that statement.
Maybe - and I hope he does not care that I drag him into this thread - @paragonie-scott could give his opinion on this statement.

OK @frederikbosch  please don't merge yet the exact phrase originally suggested as it is written right now in this PR. Let's elaborate on it a bit further.
@sagikazarmark to my understanding the current Money library induce developers to infere that everything is OK with thinking in terms of BIGINT always -- because PHP is limited? -- and this could lead them to activate the BC and GMP functions.
Would you accept the above as an example of how violating the least privilage principle makes an app prone to human error? :)
Don't get me wrong, your idea is great, and it is OK to include BC and GMP functions if you know what you're doing, but I think the Money library is silently evangelizing a bad practice among the developers community by not raising awareness about how things work behind the scenes actually.

I don't agree with the following:

However, this is a generic purpose library which chose to use currencies and tries not to limit the maximum amount you can represent with it.

IMO, Money should not be addressed to the general public including GMP and BC functions out of the box. But no problem. If it turns out that you want to manage huge numbers, knowing what you're doing, then extend the library with the GMP and BC features.

not raising awareness about how things work behind the scenes.

I can accept this point if you say that the documentation does not give enough explanation how the Calculator logic works under the hood. But I think it is:
http://moneyphp.org/en/latest/concept.html#integer-limit

my understanding the current Money library induce developers to infere that everything is OK with thinking in terms of BIGINT always

Can you please point me to the docs or a single source which you think  encourages developers to ALWAYS think in terms of BIGINT? The possibility is given, the tools are given, that's it.
Or is it the problem that Money internally picks BC/GMP by default if it detects it?

Exactly, the magic shouldn't be like this:

BC Math (requires bcmath extension)
GMP (requires gmp extension)
Plain integer

According to the least privilege principle, we should simply have:

Plain integer

That's it.
Then, in order to run advanced, arbitrary precision arithmetic features, the API user would explicitly set the mode they wish to operate on -- GMP or BC Math. This way, if they decided to use GMP (explicitly) but it turns out that for whatever reason is off, the code will not run.
Does this makes any sense?

Well, if you want to enforce that principle in the first place, you shouldn't install or enable those extensions.
Although there may be a slight performance penalty when having them enabled, but not using their capabilities, I don't think there is any more risk in having this convenience layer.
Last, but not least: changing this now would affect behaviour => BC break which would require a new major version.
Honestly, I am not really convinced by the points you raised. If you don't want to use GMP/BC then don't enable the extension. If you enabled the extension, but don't want to use it, you can still explicitly registering the integer calculator as the first one. This may change in the future, but I don't think it requires any actions from us now.
Thanks for raising these points anyway.

Thanks for letting me suggest how to make the library better.

If you don't want to use GMP/BC then don't enable the extension.

That was the point, it is you (Money's conceptual framework) actually encouraging to enable gmp and bcmath as shown in the following example.

Different values in two servers with same php

Can I address one question? I am really curious to know why we'd run arbitrary precision functions in common web apps. Where did this idea originate?

There was need a for unlimited integers in one of the issues. I decided to implement it using bc math and gmp, depending on the available extensions. And that is the final word to it. Case closed.


Bump to 1.2.0 and add a History section

Coverage remained the same at 48.118% when pulling d507493bacb88f2c579f2682c690ab6594a48f1d on fahhem-patch-1 into 4db08f7ee2e4b11b28e4570c21839c8343d311ba on master.


Termination of membership on non-payment of standing order

The rule currently states:
"When a member stops paying their standing order, they will become an Ex-Member."
Some clarification of what this means, and the timescales involved would be good. E.g.
How long it is before it is decided a member has not paid their standing order?
Is a member given a chance to correct this before their membership is terminated (i.e. before RFID access is cancelled?)
Maybe a link to a full description of the "termination process" is needed.

I agree. Trustees, are there already policies on these matters that James raises? If not, we can make proposals here. It could be dealt with in only a sentence or two I think.

Yes, but would prefer @dpslwk to elaborate.  His Internet is a bit dodgy where he is for Christmas, so that will be in the new year I expect

Currently I do a manual members audit around the start of each month.
Any one who has not paid during the last two full months is marked as an ex member
But I'm working on automating this in HMS and having audits ran at least once a week (Wednesday @4am) and depending on the PHP Date math this might mean people are ex members after 60days or 2 months from there last payment,
the HMS automation will also be adding a warning email to members if we have not seen a payment in the last 1 month and 14 days, at least thats the plan


[Feature] highlight all occurrence in result list

Hi,
do you know if it's possible to add highlight (set pattern search bold in result list) on all occurrence of the pattern in each line string ?
example :

user search for 'es'
in list we have : 'test', 'test test'
Each 'es'  are highlighted

Regards,
S0r4

What you are describing is the default behavior. Probably I'm not understanding the issue?. Have you checked the highlightAttributes property?.

oh may be I missed something, I'm new in swift development ^^"
When I tried to look in your code I found the method filter witch use the highlightAttributes with titleFilterRange. But the titleFilterRange var only had one location and range, and isn't on a loop on each occurrence.
And on my screen I only saw the first occurrence in bold, that's why I created this ticket
I will try to check it again.
And thanks for your quick answer :)

Probably you want to share your code and a screenshot so I can help you?

Of course, sorry for not doing it sooner.
I have a SearchTextField in an UIView declared like that :
@IBOutlet weak var test: SearchTextField!
and declare in viewDidLoad :
test.filterStrings(["test", "testtest", "test test"])
When I search "es" I have the following result (only first "es" for each item is highlighted, not all occurences of it) :

I did nothing more than that, I didn't have time to look at highlightAttributes property for now.


CSRF Update 0.17.x

Update 0.17x branch relative to 0.18x logic #1546

Oops, I jumped Travis on that one. 😊


The consumption performance index cannot be obtained, and the obtaine…

Fixes:#8023
Motivation
The consumption performance index cannot be obtained, and the obtained value is all 0
Modifications
Add code to collect the indicators of stats.rateOut and stats.throughputOut in the getTopicStats method of the NamespaceStatsAggregator class
Verifying this change
Make sure that the change passes the CI checks.
This change added tests
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
•Dependencies (does it add or upgrade a dependency): (no)
•The public API: (no)
•The schema: (no)
•The default values of configurations: (no)
•The wire protocol: (no)
•The rest endpoints: (no)
•The admin cli options: (no)
•Anything that affects deployment: (don't know)
Documentation
•Does this pull request introduce a new feature? (no)

/pulsarbot run-failure-checks

move to milestone 2.8.0

Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant.


Load split models from huggingface's cache

There might be some other fixes (or latent bugs) that crept in here too, as I'm somewhat groggy.
This is an attempt to add hugging face cache support to the concept of loading split models.
With this addition, the following works.
pygen = transformers.pipeline('text-generation', 'NovelAI/genji-python-6B-split/model', tokenizer='EleutherAI/gpt-neo-2.7B', device=0)

print(pygen('def print_hello_world_literal('))

It relies on a fudge that detects '-split' in the model name to load it as split.  Alternatively, "is_split": true and "subfolder": "model"  can now be set in the model configuration to specify those parameters directly.

Thanks, makes things much easier.


move window_mask calculation to after configuration

Fixes incorrect decompression when deferring configuration. Addresses #17

Codecov Report

Merging #18 (3b092f7) into main (096636f) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   93.19%   93.19%
=======================================
  Files           4        4
  Lines         382      382
  Branches       59       59
=======================================
  Hits          356      356
  Misses         18       18
  Partials        8        8

Flag
Coverage Δ

unittests
93.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Game Crashes when inject DLL

[=] Unreal Mappings Dumper created by OutTheShade
[=] Detected Unreal Engine version 5.300000
[=] Detected game HalfSwordUE5-Win64-Shipping.exe
And dosent generate .usmap

Same problem in fanmade Black Myth Wukong


Complete diff-match-patch port (closes #25)

This branch has a completed port of the match and patch algorithms, with the necessary test coverage.
It actually doesn't include the delta code, because I think the delta format sucks and it's worth improving.
Another major change is Unicode awareness: this branch will not cut into Unicode codepoints.  This may conceivably come with some performance penalty for ASCII code, if so, the logic is isolated to a few functions and can be feature-gated accordingly.  I expect the damage to be minor, perhaps unnoticeable, once I finish performance tuning the algorithms.
A diff which truncates code point sequences is not inherently incorrect, in that it will still apply properly and give a correct before-and-after value.  It can result in patches which are invalid UTF-8, which is undesirable, but the patchAddContext logic could prevent this at the boundary.
However, correct code point handling is essential for a change I haven't yet implemented: making the diffLineMode function work with a useful number of lines. A reasonable median for number of lines in a text file is 1000 (made up number), and the current diffLineMode gives up after a round one-quarter of those lines, meaning that the effort spent iterating and hashing may, or may not, be made up for by the amount it speeds up a diff. Line mode pays off more for longer files, so this is worth correcting.
Because this library is UTF-8 native, we don't have to take a shortcut of ignoring surrogate pairs, and therefore, the approach I intend to take here will allow for 1,112,034 lines of text to be compared.  Engineering a test which will actually trigger the "give up" condition is going to be difficult enough that I suggest that we comptime-limit the amount of lines severely in test mode, in order to cover that case.
I've focused on compatibility with the existing library, as the useful default for a port, but I don't think we should let that hold us back here.  For the (notional) sake of compatibility, perhaps some of the functionality I'm interested in improving could be offered in a compatibility mode, but there are several least-common-denominator aspects to the design which I'd like to liberate this library from. I expect very few uses will cross over into some other language, and it's not difficult to provide for that use case while offering a better alternative for the Zig ecosystem.
This isn't ready for merge yet, so I'd appreciate if detailed critique waits until it is, at which point it is welcome. As a bit of self-critique, I'm not satisfied that there are at least three copies of the Unicode-breaking algorithm, which differ in the specifics. I think I can get it down to two: an adjustForward and an adjustBackward, and call/inline them in the places where they get used.
Directional/design feedback, any bugs spotted while kicking the tires, and any additional test coverage that one of you might spot a need for and want to contribute, are all immediately welcomed. Please let me know what you think.

I see that a Python script I eventually want to use for generating a large test data corpus snuck into this branch by accident.  I'll leave it there for now, it's not intended to be part of the merge however.  The Roadmap.md is also intended to be temporary, but that I did intend to include so that others can read it.

That's gotten rid of all the hacks, and isolated the truncation-avoidance logic into two very simple functions.
I don't expect the change to have noticeable impact on performance when the library is used on all-ASCII code, or in an internal way where splitting up code unit sequences is ok.  If that turns out not to be the case, then a compile-time option can just replace it with a null function that returns the offset it's given, and ignores the string.  That will compile away completely.
But that flag would also have to disable line-based diffing entirely, because that won't work without proper codepoint handling.

That completes the port of line mode to use UTF-8 code unit sequences, along with the tests which already exist for those functions.
Coverage is fairly good at 99%, the standout being that the max-line condition isn't being triggered in line mode.  I'll circle back and add a test for that, the function (wisely) takes a maximum as a parameter, so triggering it artificially should be straightforward.
There are some other missing code branches here and there, mainly one liners, and some untriggered errdefer statements. Some of those appear to be unreachables, a few are error conditions which aren't being triggered (such as most cases of error.BadPatchString in patchFromText).
As a design note, I separated line iteration into an iterator struct, and rewrote diffLinesToCharsMunge to create that iterator and call diffIteratorToCharsMunge with the iterator as an anytype.
This separation of concerns is intended to empower future changes to use "munge based" diffing by consuming any iterator, such as one which segments based on words.  Or, what I think is particularly interesting, based on tokens.
I have some notion of future support for an interface which doesn't automatically refine diffs from 'munge mode', so that diffz can produce line-based diffs for tools which use those. With a separate patchAddContext and a different patchToText, diffz can support the Unidiff format used throughout Unix these days (I don't think classic patch is worth supporting any longer, but if someone wanted to add it, it's pretty straightforward stuff).
As I mentioned, I didn't port the delta code, because I think it sucks, but it would be fairly easy to add if someone is interested in having it.  I think deltas are an important use-case to support, but the format in the original Google library may easily be improved upon.  The same is true of the textual patch format, for similar reasons: there's no reason to squeeze text through URI encoding like so much toothpaste, data formats with no unique header (including a version!) are sinful, and so forth (but mostly those two things).
I intend to cover those last lines soonish, and will update the PR when that's done.

The work on this branch is now complete.
I think it would be good to have some larger tests for diffLineMode, and that broadly speaking more tests for this library would be a good goal.  Line coverage is at 99.6%, that includes one errdefer in diffCompute which it should be possible to trigger (but I haven't figured out how, and given how many checkAllAllocationFailures blocks it appears in, that might be wrong), and a branch in diffCleanupSemantic which the ported tests don't hit.  There's also an @panic which I left in diffCommonOverlap, for now, although I'm fairly sure that, by construction, it will not be triggered except by a bug elsewhere in the code.  The rest of the non-covered lines are spurious, they show up in test code which is 100% getting called, that might be a comptime artifact but the reasons are unclear.
Full line coverage, however, doesn't mean that it all works correctly, and it would be good to supplement that with some integration tests which do non-trivial diffing.  Also worth checking if the Unicode-aware code causes any performance regression on ASCII text, my guess is that this would be minor, if visible at all, but it's worth having an actual answer.
I know the previous branch isn't merged in yet, so no special hurry with this one. I'm using it in another application, and pointing that at this repo at such time as it all gets merged in will very easy.  But it's ready for detailed review when you have time and inclination to do so.

Just pulled latest zls and this branch in order to test drive.  But this branch doesn't build:
~/.../zig/zls $ zig build -Doptimize=ReleaseSafe
install
└─ install zls
   └─ zig build-exe zls ReleaseSafe native 1 errors
src/diff.zig:26:19: error: expected type 'error{OutOfMemory}', found 'error{OutOfMemory,BadPatchString}'
    const diffs = try dmp.diff(arena.allocator(), before, after, true);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/diff.zig:26:19: note: 'error.BadPatchString' not a member of destination error set

My local zls changes
diff --git a/build.zig.zon b/build.zig.zon
index e4ce16d..6809a60 100644
--- a/build.zig.zon
+++ b/build.zig.zon
@@ -15,9 +15,12 @@
             .url = "https://github.com/ziglibs/known-folders/archive/47076c6b11214a218e9244471d8762310820911a.tar.gz",
             .hash = "12209d2738a2e1dbd3781c2e5f01a2ea877dcfeea53efdfa1913247297d328e6b207",
         },
         .diffz = .{
-            .url = "https://github.com/ziglibs/diffz/archive/ef45c00d655e5e40faf35afbbde81a1fa5ed7ffb.tar.gz",
-            .hash = "1220102cb2c669d82184fb1dc5380193d37d68b54e8d75b76b2d155b9af7d7e2e76d",
+              .path = "../diffz",
         },
         .@"lsp-codegen" = .{
             .url = "https://github.com/zigtools/zig-lsp-codegen/archive/13d1d9e44e1c602953437438b163950298ff8d85.tar.gz",

Is this branch meant to be used in zls or just #23?

If it is meant to be used in zls, here is a potential zls patch.  I'm not sure whether InvalidRequest is the correct error mapping though:
error.BadPatchString => @intFromEnum(types.ErrorCodes.InvalidRequest),

~/.../zig/zls $ gd master
diff --git a/build.zig.zon b/build.zig.zon
index e4ce16d..84e8706 100644
--- a/build.zig.zon
+++ b/build.zig.zon
@@ -16,8 +16,10 @@
             .hash = "12209d2738a2e1dbd3781c2e5f01a2ea877dcfeea53efdfa1913247297d328e6b207",
         },
         .diffz = .{
-            .url = "https://github.com/ziglibs/diffz/archive/ef45c00d655e5e40faf35afbbde81a1fa5ed7ffb.tar.gz",
-            .hash = "1220102cb2c669d82184fb1dc5380193d37d68b54e8d75b76b2d155b9af7d7e2e76d",
+            //.url = "https://github.com/ziglibs/diffz/archive/ef45c00d655e5e40faf35afbbde81a1fa5ed7ffb.tar.gz",
+            // TODO change back to ziglibs once this is merged
+            .url = "https://github.com/mnemnion/diffz/archive/bb9a1ae4e7220e5360024df61c369d51516c6860.tar.gz",
+            .hash = "12205c450ca56247e78753a09784f74cb45a6d372c48653e21f64acdc07d5dc40b38",
         },
         .@"lsp-codegen" = .{
             .url = "https://github.com/zigtools/zig-lsp-codegen/archive/13d1d9e44e1c602953437438b163950298ff8d85.tar.gz",
diff --git a/src/Server.zig b/src/Server.zig
index f8c4a22..82bc647 100644
--- a/src/Server.zig
+++ b/src/Server.zig
@@ -138,7 +138,7 @@ pub const Error = error{
     /// The client has canceled a request and a server as detected
     /// the cancel.
     RequestCancelled,
-};
+} || diff.Error;

 pub const Status = enum {
     /// the server has not received a `initialize` request
@@ -1945,6 +1945,7 @@ fn processMessageReportError(server: *Server, message: Message) ?[]const u8 {
             .request => |request| return server.sendToClientResponseError(request.id, lsp.JsonRPCMessage.Response.Error{
                 .code = @enumFromInt(switch (err) {
                     error.OutOfMemory => @intFromEnum(types.ErrorCodes.InternalError),
+                    error.BadPatchString => @intFromEnum(types.ErrorCodes.InvalidRequest),
                     error.ParseError => @intFromEnum(types.ErrorCodes.ParseError),
                     error.InvalidRequest => @intFromEnum(types.ErrorCodes.InvalidRequest),
                     error.MethodNotFound => @intFromEnum(types.ErrorCodes.MethodNotFound),
diff --git a/src/diff.zig b/src/diff.zig
index a3e602f..ecdf577 100644
--- a/src/diff.zig
+++ b/src/diff.zig
@@ -10,7 +10,7 @@ const dmp = DiffMatchPatch{
     .diff_timeout = 250,
 };

-pub const Error = error{OutOfMemory};
+pub const Error = error{OutOfMemory} || DiffMatchPatch.DiffError;

 pub fn edits(
     allocator: std.mem.Allocator,

I'm test driving this patch now in zls with the the diff above.  I have been test driving #23 for the past 2 weeks or so and didn't notice any issues.  However I haven't written much zig during this time so this might not be saying much.

Hmm. So the BadPatchString error is for, well, a bad/malformed patch. There are a lot of ways that a patch can be wrong, and just the one way that it can be right.
But it's actually isolated to one public function, so it doesn't have to be a part of the signature for the others.  But then we have a DiffError error set which doesn't cover all the errors in the library, which seems like the nomenclature is incorrect.
I think the move here is to keep both errors in the DiffError set, but define the functions which only return OutOfMemory as only returning OutOfMemory.  That way, the DiffError set answers the question "what errors does the entire library throw" and the part of it which ZLS uses will stay compatible with the original interface.
It also seems better with specifically OutOfMemory, if functions which only throw that one error aren't defined as part of a wider error set.

It does occur to me that code calling diffz should, in general, add the DiffError set to error sets for functions which call it. But I'm still going to slim the interface down so that the functions which can't return BadPatchString won't be in that error set, because I don't think it makes sense for functions which will only receive OutOfMemory to have to handle all the possible errors in the library.

Done, that was relatively painless.
Kinda makes me think that DiffError should be PatchError, since those are the only functions which use it. But that's a cosmetic change which could be made instantly, so I'll defer on that for now.

Thanks! With that last commit, zls no longer requires any changes to build with this PR.

I'm test driving this patch now in zls with the the diff above.

Update: I've been writing more zig this week and haven't noticed any issues.

That reminded me that I had gotten ZLS to build earlier in the week, but hadn't patched in the branch.
So I did that. So far so good! I removed the arena, and tossed in dmp.diffCleanupEfficiency for good measure.  I had had some notion of using the patch mechanism to apply the diff, but a closer look at the source makes it clear that it's getting transmogrified into JSON and sent elsewhere, makes sense though.
No idea if the overhead of making an arena for each diff covers the overhead of freeing things individually, I suspect it's a wash though.

I found a crashing case in Unicode handling, I should get a chance to debug it soon.

Fixed. The Unicode-aware diffBisectSplit logic would sometimes create a before or after pair with empty strings.  Since this doesn't reduce the problem space for half of the code, it would happen again, until stack overflow.
Now it doesn't do that. If one of the pairs is empty, that means the other pair is a single insert/delete diff.

How far is this from being merged in? I've been following for a while and from what I remember it was pretty close to functional. Do you need any help getting over the finish line?

I've been running ZLS with it patched in since August with no problems. But that doesn't actually touch the new code.
The work on this branch is done, although now that it's on my mind again I wouldn't mind doing a linting pass.  It's been working in ohsnap for awhile, which some folks are starting to use.
What it could use is a test which handles a large-ish amount of diffed text in multibyte Unicode, using the line-oriented optimization.   The bug fixed on 5 August turned up using ohsnap to diff RuneSet tests, which have a lot of multibyte sequences, and that code is original, the other systems use UTF-16-LE and this version uses UTF-8.
So if you wanted to hit up a source like the Wikipedia database, and work up a couple of 1-5kB diff tests using, say, Greek for two-byte and Chinese for three, that would be the last thing I've thought of to add here.  The branch itself is done, and I think I got kcov to 100% line coverage, it was at least two nines.


Fix the ToWKB for empty points

The WKB spec does not allow empty points. Some reads:
https://github.com/Toblerity/Shapely/issues/742
https://trac.osgeo.org/postgis/ticket/3181
If I'm correct (needs checking), we should serialize it to POINT (NaN, NaN), and deserialize back to POINT EMPTY.

Duplicates #134

Upon further consideration, I think this is something to be solved upstream in GEOS. There is already a ticket for it: https://trac.osgeo.org/geos/ticket/1005

@caspervdw since this does not have an immediate fix in pygeos it would be best to leave this out of the 0.8 milestone.
Other than tracking GEOS for updates - which looks perhaps a bit unlikely given the history of the related issues there - what changes are necessary in pygeos?  Should we instead develop a pygeos specific work-around?

If this is a simple workaround with pygoes, I would advise this option, as GEOS issues tend to take a while to get noticed and fixed. (I have made some attempts to patch this, but my lack of C++ know-how is holding me back in completing this).

There seems to be some movement in GEOS! (https://trac.osgeo.org/geos/ticket/1005, at least it is commented that JTS applied this fix, so I think GEOS can/will follow suite if someone contributes the fix).
Now, given that we support multiple versions of GEOS, I think it would still be useful to also add the special case here, to ensure consistent behaviour across GEOS versions.

This is now fixed in https://github.com/libgeos/geos/commit/466cff135c8e504632ae38b79a1348dbadb390f1 for version 3.9.0 (thanks @pramsey !)


⚠ Grafana has degraded performance

In 17b03cd, Grafana (https://grafana.hydeos.fr) experienced degraded performance:

HTTP code: 200
Response time: 2330 ms

Resolved: Grafana performance has improved in ceb984c after 9 minutes.


Tests for clear event logic, model, storage

Issue #129 resolved
Issue #130 partially resolved

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
see 11 files with indirect coverage changes

lgtm


Godot 4.3: AssetLib image previews are broken

Apologies if this is already known, but the asset library's preview images seem to be broken. This is on 4.3.

Hi Jonathan, thank you very much for reporting this! I broke this when I reorganized the manual and forgot to update the links in the asset library. I have submitted new links to the asset library, once this gets approved the images should show again.


Render an image of the sequence in each tweet

It would be cool if the code generated an image (e.g. pixel art) of the bases that were being listed in each tweet, and uploaded it as media for the tweet.
Landscape/ horizontal layout would probably fit nicely, although you could go vertical if you really wanna hog the feed.
Even better, you could then make/ find an unroll-bot that concatenates images from successive tweets and makes one giant genome image...

I like the suggestion! At the moment, at least for the current implementation, I am saving every precious POST request for the genome itself, lest I be rate-limited. I like the idea for a separate bot that reply-tweets with a visualisation of each segment of the genome.


'CorsairLightingProtocolHID' does not name a type  CorsairLightingProtocolHID cHID(&cLP);

Hi there,
while compiling various example sketches (Lighting Node Pro and TinyUSB) i get the error message
LightingNodePRO.ino:31:1: error: 'CorsairLightingProtocolHID' does not name a type
CorsairLightingProtocolHID cHID(&cLP);
tried reinstalling library, different sketches and so on. Anyone has a clue?

Did you followed the guide and installed and selected the correct CLP boards before compiling?

Thanks for the quick response!!
Yes, i actually tried the Uno guide and die guide for Raspi pico.
Got the same issue during compiling...
Nevertheless, i would like to focus on the issue on the raspi pico, since there are less steps for getting it to run.
I used the Rasperry Pi Pico/RP2040 Boardmanager form Earle F. Philhower Version 2.5.2
FastLED by Daniel Garcia Version 3.5.0
Corsair Lighting Protocol Version 0.15.0
Arduino IDE 2.0.0
Raspi Pico from 2020(guess V 1.2)

You also need to install the Adafruit TinyUSB library. After that make sure that Raspberry Pi Pico board is selected under Tools. Then under the Tools -> USB Stack, select Adafruit TinyUSB instead of the Pico SDK.

Okay, thanks for the answer again!
Unfortunately, i don't have enough time at the moment, to fiddle with it...
Anyway, with my freshly ordered Pro Micro everything runs smoothly, so the problem must be on my side.
Thank you for your help!!!

Okay... even though i do not have the time, i tried something else...
uploading as Raspberry Pi Pico does not work somehow... As "Generic RP2040" everything runs smoothly, and it gets detected by OpenRGB with both channels.
Selected USB Stack "Adafruit TinyUSB" with the above mentioned soft- and hardware...
I did not try with the leds connected, but i guess the important part is done. Many thanks for your help @xyberred and @Legion2 !!
I love the project!


Error "setup-envtest: command not found" when running 'make test'

Describe the bug
make test cmd assumes setup-envtest utility would be pre-installed and doesn't install it if its missing.
To Reproduce
Steps to reproduce the behavior:

Check if setup-envtest utlity is already installed on your system using which setup-envtest.
If it does then delete the existing setup-envtest utlity.
Now run make test
make test would print error /bin/sh: setup-envtest: command not found

Expected behavior
make test cmd should install the setup-envtest utility if its not already installed.
Environment (please complete the following information):

OS: Mac OS

@ckadner

Thanks @vaibhavjainwiz -- I will take a look


WriteMem BunnyHop

You say BunnyHop doesn't write game's memory.... But, it isn't the case ... 🫣

I didn't notice in the README it was still saying bhop does not write to memory, already removed and will commit on the next update.


docs: hide the Run on Apify button on mobile devices

Related: https://apifier.slack.com/archives/C0L33UM7Z/p1701939473623589

Yeah, my thinking here was that the Apify Console is an absolute mess on mobile, so we don't really want to send mobile users there.
768px is a fairly standard breakpoint for screen size in responsive design, I didn't think of it twice... It's your call, I would rather not show the button (reason above), but I don't really have a strong opinion here.

Yeah, agree the console is not very mobile-friendly.


pk: implement class ECDHNaive

Add enum _pk.MBEDTLS_ECP_DP_CURVE448 pk.Curve.CURVE448.
Add class pk.ECDHNaive to do key exchange with CURVE25519 or CURVE448.
Exposed mbedtls_ecdh_gen_public, mbedtls_ecdh_compute_shared, as
mbedtls/programs/pkey/ecdh_curve25519.c.

Still have some doubts on this pr

Is the naming ok?
curve448 enum
mbedtls had supported curve448 for years. This should works fine but some systems such as debian stretch (debian9, current stable) do ship an ancient version of libmbedtls which do not support curve448. In similar scenario, cython would fail to build.
generate, import_peer interface and endianness
Currently a bytes object large enough is used to store public keys with _mpi.mbedtls_mpi_read_binary and _mpi.mbedtls_mpi_write_binary. While mbedtls mpi library "natively" read and write in big endian,
should some glue code be added to support little endian, or use mpi.MPI instead?
Should the methods to read private key and public key refactored to ECDHBase?

First of all, thank you for your contribution. You are my first contributor for this project!
I will have to review the PR later but for now:

import_peer() could be import_peer_public() or import_peers_public()? I am not sure either.
I have started creating manylinux1 wheels to the project in 0.14.0 to get around the problem of Linux distributions shipping old versions of libmbedtls. My long term goal is to update the wheel to distribute the next long term support version of libmbedtls (2.16.x) and also add ChaCha/Poly. So your contribution with Curve 448 fits very well!
Using mpi.MPI() could be a better solution. I am not sure that python-mbedtls handles endianness correctly everywhere, however. So you may as well leave it.
property(_private_key()) and property(_public_key()) should definitely be in ECDHBase. However, I think that _public_key() should return an ECPoint.

Generally, could you add tests in test_pk.py that test every new method at least once? Also, could you add a short sentence in the ChangeLog?

Perfect! thank you again.


rollup issue with undeclared variable process

Short description of the problem:
When I import the aws-sdk, rollup complains that there is an illegal assignment of the variable process. When I use rollup independently with the aws-sdk, there is no issue.
What behavior are you expecting?
I am expecting the information in the AWS object that is imported to be logged out, and for the build to succeed
Steps to reproduce:

npm install aws-sdk
import AWS from aws-sdk in any .ts file within a new ionic v2 project
ionic build and the error message will be revealed to you

Which @ionic/app-scripts version are you using?
@ionic/app-scripts version 0.0.30
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
the code I am using to produce this error is
import AWS from 'aws-sdk';
console.log(AWS);

and that gives the following build error
Error: Illegal reassignment to import 'process'
    at error (/Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5404:12)
    at disallowIllegalReassignment (/Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5429:4)
    at AssignmentExpression.bind (/Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5492:3)
    at /Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5149:50
    at ExpressionStatement.eachChild (/Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5166:5)
    at ExpressionStatement.bind (/Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5149:7)
    at BlockStatement.bind (/Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5615:9)
    at /Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5149:50
    at IfStatement.eachChild (/Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5166:5)
    at IfStatement.bind (/Users/evan/Documents/dev/dn/flashtastic-ionic/node_modules/rollup/dist/rollup.js:5149:7)

I have tracked this down to a particular block in aws-sdk/lib/browser_loader.js, which if removed alleviates the build error (but causes an application error)
if (typeof process === 'undefined') {
  process = {
    browser: true
  };
}

it is also worth noting that the process variable is not declared with var anywhere in that file. If I add the var declaration, the build error goes away, but the application error returns.

forgot to mention, aws-sdk version is 2.6.7

@whtevn,
We won't be able to rollup this library at this time. I have created an issue for you on the aws-sdk repo.
https://github.com/aws/aws-sdk-js/issues/1175
For now, the bet best will be to download the .js file from here and store it somewhere in the src/assets directory. I would then create an entry in the index.html file for the <script> tag.
Everything will be copied to www and should just work.
Check out this doc (at the very bottom, sorry, we're improving these as we speak) with how to use a lib via a script tag.  Basically, throw this at the top of where you want to use the library:
declare const jQuery:any;

Substitute jQuery with the variable off of window that you'd use to access the lib.
Sorry about this. I wish it would work with Rollup. Please let me know if you have any questions.
Thanks,
Dan

Ahh! Actually, I was able to get it working by overriding the rollup config and removing globals from the plugins as seen here.
https://github.com/driftyco/ionic-app-scripts/blob/master/config/rollup.config.js#L48
May be worth a shot.
Thanks,
Dan

First of all, thanks so much for your help so far. I was able to remove the globals() call in that config file I copied from the file you linked, and that seemed to have the same effect as removing the block of code or adding the variable. The build error goes away, but an application error comes in its place.
main.js:62101Uncaught TypeError: Cannot read property 'memoizedProperty' of undefined

which comes from...
import AWS from 'aws-sdk';
console.log(AWS);     // <------- a result of this line in particular

which I am currently looking into, but so far not having a lot of luck. I am new to TS, so there is a fine chance I'm missing something obvious.
I tried to confirm the issue by putting globals() back in place in the rollup config, removing the aws-sdk npm package, and addressing a locally saved copy of the SDK in a <script> tag, but I'm apparently not getting something.
declare const AWS:any;

console.log(window.AWS);  // BUILD FAILS - ngc: Error: Error at /Users/evan/Documents/dev/dn/flashtastic-ionic/.tmp/app/app.component.ts:8:20: Property 'AWS' does not exist on type 'Window'.

console.log(AWS);                // APP FAILS - Uncaught ReferenceError: AWS is not defined

sorry for the additional questions, but I'm really hoping that I can get this working. I am looking into the memoizedProperty TypeError mentioned above. If you have any advice or direction, I would really appreciate it. Thanks again for taking the time to do this.

ignore me. I had added the AWS <script> after the main.js inclusion. dumb. thank you for all of your help.


Emmet not working for Jade

Hi Sergeche,
At first I would like to thank you for the awesome plugin!
Emmet working perfect for all file extensions in my Brackets 1.9
But sadly its nor working for Jade. Its simply not expanding even my correct Jade syntax when I hit tab.
PS: I have checked and Emmet is enabled.
Can you please help?
Many thanks,
Touhid R.

I guess it’s because Jade is now Pug, e.g. another name for syntax. Try to use Ctrl-E shortcut to expand abbreviations in unsupported syntaxes.
Pug support will be added later