Add maxaltrankscore in the botassistexplorer script

Hello!
Could you add "maxaltrankscore" in the botassistexplorer script in the future when you can?
off: you could register in brave to receive bat token as a tip, in github I see many users who can receive those tips but I see that you are not registered. It would be another way to collaborate.
thanks

If I work from altrank.py and other similar scripts there is a problem that the bot cannot start if I activate " allowbotstopstart ". As much as the currency is in the first place and I put these parameters: altrankscore: 1 numberofpairs: 1 and originalmaxdeals = 1 the bot cannot turn on

I can have a look at the max altrank score as in the previous commit the handling of all columns has been improved (and are now available to filter on).

And the option is added, pull request is open and waiting for @cyberjunky to be merged. Default value is set to 1500 (same as in altrank.py), which you can change afterwards off course.

I can have a look at the max altrank score as in the previous commit the handling of all columns has been improved (and are now available to filter on).

Thanks again for joining the thread, look I think it's a good idea to filter the ranking of the coins regardless if that coin is the first in the column, since it does not guarantee that that coin will be the first in the lunarcrush global list, it can be the first of the list of the exchange that I use but not be the number 1 of global altrank.
Oh and another thing I know I could use altrank instead of this script but a good reason I see in using this script is that it would be a good alternative to the original LC API since it may not be free anymore, I just hope 3ctools survives too

I can have a look at the max altrank score as in the previous commit the handling of all columns has been improved (and are now available to filter on).

Thanks again for joining the thread, look I think it's a good idea to filter the ranking of the coins regardless if that coin is the first in the column, since it does not guarantee that that coin will be the first in the lunarcrush global list, it can be the first of the list of the exchange that I use but not be the number 1 of global altrank. Oh and another thing I know I could use altrank instead of this script but a good reason I see in using this script is that it would be a good alternative to the original LC API since it may not be free anymore, I just hope 3ctools survives too

Not sure if I understand correctly. 3C-tools does already sort the list (https://www.3c-tools.com/markets/bot-assist-explorer?list=binance_spot_busd_alt_rank for example) on alt-rank score so if you get the top one it will be the highest alt-rank score. Does not need to be alt-rank score 1, so retrieving only 1 coin and having maxaltrankscore on 1 will enable you the get the top alt-rank coin if it's in the list.

I can have a look at the max altrank score as in the previous commit the handling of all columns has been improved (and are now available to filter on).

Thanks again for joining the thread, look I think it's a good idea to filter the ranking of the coins regardless if that coin is the first in the column, since it does not guarantee that that coin will be the first in the lunarcrush global list, it can be the first of the list of the exchange that I use but not be the number 1 of global altrank. Oh and another thing I know I could use altrank instead of this script but a good reason I see in using this script is that it would be a good alternative to the original LC API since it may not be free anymore, I just hope 3ctools survives too

Not sure if I understand correctly. 3C-tools does already sort the list (https://www.3c-tools.com/markets/bot-assist-explorer?list=binance_spot_busd_alt_rank for example) on alt-rank score so if you get the top one it will be the highest alt-rank score. Does not need to be alt-rank score 1, so retrieving only 1 coin and having maxaltrankscore on 1 will enable you the get the top alt-rank coin if it's in the list.

Look I leave an example so you can understand me:
suppose that global altrank is VRA in the first position, but VRA does not exist in Binance futures, so XRP is in global altrank 2 but it is first in the list which I do not care about, I just want the bot to work with the first currency of the global altrank, which is exactly what it shows in the "alt-rank" part of the list
In this example case can clearly occur if the first coin in the list is not reached by the top of the global list.

But, if you want to have coins that are available in Binance Futures, and want to have only the first one, then use the following list: https://www.3c-tools.com/markets/bot-assist-explorer?list=binance_futures_usdt_alt_rank. Set the start- and end- number of the botassistexplorer.py script to 1 and you only get the first one?

But, if you want to have coins that are available in Binance Futures, and want to have only the first one, then use the following list: https://www.3c-tools.com/markets/bot-assist-explorer?list=binance_futures_usdt_alt_rank. Set the start- and end- number of the botassistexplorer.py script to 1 and you only get the first one?

The position of the list does not interest me really, but the position of the altrank score does, there may be cases that the first coin of that list (binance futures) does not correspond to the first coin of the number one position in the altrank "global". As I explained in the previous example.
But never mind mate, thanks for modifying the altrank script from the other thread, this "3c-tools" script is just an alternative to a possible lunarcrush free API shutdown, but in the future 3c-tools might be the one to save the day not having the free version of LC.

Added in the last update, thanks guys :)

I leave a possible feature that could be brought from other scripts and improve the bootassistexplorer script.
For some reason in certain custom setup "numberofpairs" is missing. If you want reasons I can explain why this feature is missing.
I didn't know whether to open another thread but if you read it it would be a good addition to future updates, sorry for the inconvenience.
Thanks!

I leave a possible feature that could be brought from other scripts and improve the bootassistexplorer script.
For some reason in certain custom configuration "numberofpairs" is missing. If you want reasons I can explain why this feature is missing.
I didn't know whether to open another thread but if you read it it would be a good addition to future updates, sorry for the inconvenience.
Thanks!


tour: why do we need an array size

Context: https://tour.golang.org/moretypes/7
Hi,
following is also possible: []int{2, 3, 5, 7, 11, 13}
Why do you use the array size[6}. Is there any advanzage to use it ?

Hi there. Thanks for taking the tour.
This is the issue tracker for reporting problems with the tour. If you want to ask general questions about Go, please ask in one of the Go discussion forums.
Thanks.


Can we have 6 or 8 edge cropper?

Hi,
Your work is highly appreciable. It looks amazing.
Can you please guide me to get the 6 or 8 edge cropper instead of 4 only. It would be good in case you can include it or guide me how can I achieve it.
Thanks in advance.

If you are talking about multiple edge image cropping, it's not supported and might be not supportive in the future. So I'm going to close this with wontfix.
Feel free to add more info about your request.


Dark mode is not implemented on new pages

Description
On the footer pages dark is not implemented.
Steps to reproduce
Go to any of the footer page such as about and click on darkmode button.
Screenshots

Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response

Description
On the footer pages dark is not implemented.
Steps to reproduce
Go to any of the footer page such as about and click on darkmode button.
Screenshots

Desktop (please complete the following information)
No response
Smartphone (please complete the following information)
No response
Additional information
No response

you can work on this :)
level 1 is okay, right? as it's mostly related to the fonts? or there's more?

Yes, definitely.


Path intellisense won't work in the latest release

Path intellisense won't work in the latest release, but old version works.

I can't see this problem, could you provide an example? And which last version is working?


De-nest RecyclerView from ScrollView

When running Emoji Search with the Android View target, the performance is awful.
onCreateViewHolder was being invoked for every item in the list, regardless of whether it was in the viewport or not. This is because the RecyclerView height contained all the items, and was not bounded by the viewport. I narrowed this down to the fact the RecyclerView was being nested in a ScrollView.

I'm not sure I understand. We already are using NestedScrollView when scrollEnabled is true.

Ah, nice. I assumed the lack of performance was from not using such a type.

I don't think we can change the value depending on scroll state unfortunately. If the Overflow property changes after the initial composition it won't re-call value get() to create a new view.

Yeah so the simple way to do this would be to return a FrameLayout whose sole child switches between a HostView or a NestedScrollView+HostView.
A more complicated version is to always return a HostView and in the case of no scrolling add children directly. But in the case of scrolling add a NSV at full size and another HostView inside of that. This basically eliminates one level of indirection in the (probably common) non-scrolling case.

Yeah so the simple way to do this would be to return a FrameLayout whose sole child switches between a HostView or a NestedScrollView+HostView.
A more complicated version is to always return a HostView and in the case of no scrolling add children directly. But in the case of scrolling add a NSV at full size and another HostView inside of that. This basically eliminates one level of indirection in the (probably common) non-scrolling case.

@JakeWharton @colinrtwhite I just updated the PR using the simple way (for the time being). With these changes, I'm now getting a UI bug with Emoji Search, where the Search Bar is being cut off by the list. I don't know enough about how flex calculates the layout to say where this bug lies.

@veyndan The view's size is determined by the Size returned by container.measure(widthSpec, heightSpec). I'd check if that's outputting half size. I can take a look soon as well.

@colinrtwhite Thanks for the pointer. I tried debugging it, and I'm coming across some obscure bugs that don't exist on trunk.
For example, replacing:
https://github.com/cashapp/redwood/blob/10e82f08a83a654265acb914ce183b65af6f1222/samples/emoji-search/presenter/src/commonMain/kotlin/com/example/redwood/emojisearch/presenter/EmojiSearch.kt#L105
with
    filteredEmojis.take(numberOfItems).forEach { image ->

If you set numberOfItems to a low number, where the number of items will all fit on the screen, then it all looks good.
If you set numberOfItems to a higher number, where the number of items won't all fit on the screen, then the width of every item is set to 48 (I'm assuming the content width is 0, and 48 comes from twice the padding, i.e., 24 x 2).

Filed the above bugs in https://github.com/cashapp/redwood/issues/770 as I think it's outside the scope of this PR.


[WIP] V2 provider

This PR is not ready.  Opening to show early thoughts on how the theming API will work.

Codecov Report

Merging #2768 into v2 will decrease coverage by 0.96%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##               v2    #2768      +/-   ##
==========================================
- Coverage   99.74%   98.78%   -0.97%
==========================================
  Files         160      161       +1
  Lines        2762     2789      +27
==========================================
  Hits         2755     2755
- Misses          7       34      +27

Impacted Files
Coverage Δ

src/addons/Provider/Provider.js
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed935f8...6991192. Read the comment docs.

Not sure this is the right place for this comment ....
Can you please clarify wether V2 will be backwards compatible with projects build with V1?
Especially, what about projects that managed theming via external standalone custom SUI theme files ?


LogSorter InputStream closes prematurely

Some time ago, LogSorter was modified to handle partial headers and the FSDataInputStream in sort() was moved to a try-with-resources.  It appears this change caused the FSDataInputStream to close prematurely, before the finally can call the close() method.  The close method gets the bytesCopied before closing the input so this probably results in bytesCopied in the Monitor to always be -1.  I think this happens every time a WAL is sorted on recovery, showing this error:

2018-05-23 14:19:55,298 [log.LogSorter] ERROR: Error during cleanup sort/copy 2841a75d-8086-4fdb-a736-5f0bf60ff42e
java.io.IOException: Stream is closed!
        at org.apache.hadoop.fs.BufferedFSInputStream.getPos(BufferedFSInputStream.java:56)
        at org.apache.hadoop.fs.FSDataInputStream.getPos(FSDataInputStream.java:72)
        at org.apache.accumulo.tserver.log.LogSorter$LogProcessor.close(LogSorter.java:198)
        at org.apache.accumulo.tserver.log.LogSorter$LogProcessor.sort(LogSorter.java:169)
        at org.apache.accumulo.tserver.log.LogSorter$LogProcessor.process(LogSorter.java:96)
        at org.apache.accumulo.server.zookeeper.DistributedWorkQueue$1.run(DistributedWorkQueue.java:109)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at org.apache.accumulo.fate.util.LoggingRunnable.run(LoggingRunnable.java:35)
        at java.lang.Thread.run(Thread.java:748)

We could move the FSDataInputStream back to a regular try/catch or refactor the sort method to close things properly.

@milleruntime @keith-turner  Is this another WAL bug which needs to be fixed for 1.9.2? It wasn't marked as a blocker, so I removed the 1.9.2 label, in prep for an RC1, but on second thought I want to make sure it really isn't something we want to make sure is fixed for 1.9.2.

At the time I opened it, it seemed like a non-consequential, minor bug that probably has been around for a while.  I am not sure if @keith-turner has seen it or if it still exists after the latest WAL changes.

I ran 1.9.2-rc2 locally in uno, forcing recovery and did not see this error.  It is possible @keith-turner 's fixes to the WAL also fixed this error.

I haven't seen this error in a while so I belive it was squashed.


removed redirect_uri param when its null

@sahat
#670

Thanks, this will be merged with the upcoming minor version release 0.13.3.


Arabic-Jordan voice IDs have a space in the listed ID which appears to be incorrect

[Enter feedback here]
The listed voice IDs for the Arabic (Jordan) voices have spaces in them and don't seem to work. This appears to be a typo, although I couldn't get these voices to work with or without the space in the ID. Note how for these two voices there is a space between the name and "Neural" and no other voices in the list have this (e.g. "ar-JO-Sana Neural" instead of "ar-JO-SanaNeural"):
Arabic (Jordan) | ar-JO | Female | ar-JO-Sana Neural New | General
Arabic (Jordan) | ar-JO | Male | ar-JO-Taim Neural New | General

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4de08d1f-8114-7bef-7ef4-022f79c69742
Version Independent ID: 4c0ceab9-24ed-de01-db30-31acf1de0f48
Content: Language support - Speech service - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/language-support.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @eric-urban
Microsoft Alias: eur

Thanks for the feedback! We are currently investigating and will update you shortly.


Patch 1

Current 'polyfills' link directs to disambiguation page with multiple definitions of the term. The context in README.md refers to the specific type of polyfill that the new link references.
https://en.wikipedia.org/wiki/Polyfill -> https://en.wikipedia.org/wiki/Polyfill_(programming)

It looks like you're still including all the changes from your previous branch. I think @Timer's suggestion was to create a new branch from next and manually make your change to the README again and commit that. Alternatively you could just edit the file using GitHub's web-based editor. It can create a fork, branch and PR for you as part of the process.

Alternatively you could just edit the file using GitHub's web-based editor. It can create a fork, branch and PR for you as part of the process.

I'd suggest this route.


Build file deletion

I think files produced by python code compilation should be removed (they are not machine-independent)

Thanks for PR


Use uin64 for UpdateResource rpc

Signed-off-by: Kenfe-Mickael Laventure<EMAIL_ADDRESS>
Closes #260

@crosbymichael should we use int64 instead to allow for -1 on the memory fields?

@mlaventure if you need a nullable field its better to just use nil and not -1

LGTM


Alert words UI doesn't use correct data flow for error handling and propagation

alert_words_ui.js is structured differently from most of our UI settings.  Usually, the way UI settings features work is as follows:

when a user clicks the "add" button to create a new alert_word, we may do some input validation and report an error if appropriate.  If validation passes, we send an AJAX request to the server requesting the update.  Since that request could fail, we don't update the UI to either display success/error or show the new alert word.
In the success/error handlers for the AJAX request, we display either an error or success message (based on whether the request succeeded).  These handlers do not update the UI to show the new alert word yet, either.
The backend triggers an event notification for all of the users' open browser windows.  This event reaches the frontend via dispatch_event() in server_events.js.
In the dispatch_event code, we update the frontend's data structures (in this case, page_params.alert_words and update the alert words UI to show the new state.  It's important to do the UI updates here, because otherwise, if the user had a second Zulip browser window open to the /#settings page, the second browser window would show an incorrect list of alert_words until the user reloaded the page.

In the case of alert_words_ui.js, we have most of the code there, we just need to rearrange the UI update code to run in the success/failure handlers and/or be triggered from server_events.js.
(Also, we should probably add a section in our developer documentation describing this frontend data flow, avoid new things being done like the old alert words UI in the future.)

The fix for this should include the modification of the frontend tests related to alert words in 06-settings.js. These tests were commented out in #1244.

@umairwaheed is this issue now fully resolved, or do we still need to e.g. debug and uncomment the tests?

@timabbott, I'll verify and uncomment the tests if I don't find any issue.

@zulipbot claim


No 'Access-Control-Allow-Origin' header is present on the requested resource

Hi guys,
it's been some days with me trying to find out what's wrong.
I've been trying the lepozepo:s3 upload, and now the slingshot, to upload files to my bucket.
I'm using the root key access, to be sure that I've got all the privileges.
I've created a new app from scratch, still with insecure and auto-publish.
The cors and bucket policy in the s3 bucket's properties are as in the example.
Here's my JS:

if (Meteor.isClient) {

    var uploader = new Slingshot.Upload("");

    Template.hello.events({
        "click button.upload": function () {

            var files = $("input.file_bag")[0].files;
            console.log(files);

            uploader.send(files[0], function (error, downloadUrl) {
                if (error) {
                    // Log service detailed response
                    console.error('Error uploading');
                    alert(error);
                } else {
                    console.log(downloadUrl);
                }
            });

        }
    });
}

if (Meteor.isServer) {

    Slingshot.createDirective("", Slingshot.S3Storage, {
        bucket: "meteor-bucket",

        acl: "public-read",

        authorize: function () {
            //Deny uploads if user is not logged in.
            //            if (!this.userId) {
            //                var message = "Please login before posting files";
            //                throw new Meteor.Error("Login Required", message);
            //            }

            return true;
        },

        maxSize: null,
        allowedFileTypes: ["image/png", "image/jpeg", "image/gif"],
        key: function (file) {
            //Store file into a directory by the user's username.
            return "ciao";
        },
        AWSAccessKeyId: "my_key",
        AWSSecretAccessKey: "my-key",
        region:"eu-west-1"
    });
}

after all the troubles, I've managed to solve everything.
And now, as with the lepozepo:s3, the error in the console of the browser is:
XMLHttpRequest cannot load https://meteor-bucket.s3-eu-west-1.amazonaws.com/. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://slingshots3test.meteor.com' is therefore not allowed access.

the only difference with the lepozepo:s3 package is the link of the bucket
any suggestions please?

You did not setup CORS properly. Please have a look at the readme and to the AWS docs to setup cors properly.

It's exactly the same as in the example:
<?xml version="1.0" encoding="UTF-8"?>
<CORSConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
    <CORSRule>
        <AllowedOrigin>*</AllowedOrigin>
        <AllowedMethod>PUT</AllowedMethod>
        <AllowedMethod>POST</AllowedMethod>
        <AllowedMethod>GET</AllowedMethod>
        <AllowedMethod>HEAD</AllowedMethod>
        <MaxAgeSeconds>3000</MaxAgeSeconds>
        <AllowedHeader>*</AllowedHeader>
    </CORSRule>
</CORSConfiguration>

I click on the Properties of the bucket on the right, go to the Permission part, Edit Cors Configuration and insert the above. is it right?
I've got there 2 grantee: 'me' with everything selected (list, upload/delete, view permissions, edit permissions), and everyone, with online the first two selections

Did you get this figured out?  I had the same issue.  But since i'm in the US I had to change my region to region: "us-east-1" and things started working.

+1

Same problem

+1

In my case i added:  ETag  to CORSRules

I put the region as AWSRegion in the settings.json and solved my case


Implementing Attacker class

An attacker should take the pre-trained model, original dataset, adversarial dataset (made with transforms), and a list of criteria to monitor (like accuracy, loss, etc) [All the entities in PyTorch]
The attacker should have a method .attack(), when called, the model shall run inference over each sample from the given dataset and its adversarial counterpart in the adversarial dataset.
Finally giving out things like the performance difference due to the attacks, worst hit attacks, best hit attacks etc (in terms of given criteria)

Sounds interesting 🤩

The ultimate usage can be something like this:
from decepticonlp import attacker
from deceptionlp.transforms import transforms
import torch
from torch.uitls.data import Dataset

#define adversarial transforms
tfms = transforms.Compose(
        [
            transforms.AddChar(),
            transforms.ShuffleChar("RandomWordExtractor", True),
            transforms.VisuallySimilarChar(),
            transforms.TypoChar("RandomWordExtractor", probability=0.5),
        ]
    )

#Original dataset
class IMDB_Dataset(Dataset):
    def __init__(self):
        #some code

    def _len__(self):
        #some code

    def __getitem__(self, idx):
        text = data['review_text'][idx]    #get text from sample
        embeddings = getWordEmbeddings(text)    #convert to sequence of word embeddings
        label = torch.tensor(data['sentiment'][idx])    #sentiment label
        return embeddings, label

#Adversarial dataset
class IMDB_Adversarial_Dataset(Dataset):
    def __init__(self):
        #some code

    def _len__(self):
        #some code

    def __getitem__(self, idx):
        text = data['review_text'][idx]    #get text from sample
        adversarial_text = tfms(text)    #apply adversarial transform
        embeddings = getWordEmbeddings(adversarial_text)    #convert to sequence of word embeddings
        label = torch.tensor(data['sentiment'][idx])    #sentiment label
        return embeddings, label

#Load pre-trained model
imdb_classifier = torch.load("IMDB_Classifier.pth")
imdb_classifier.eval()

#Set up the attacker
IMDB_attacker = attacker()
IMDB_attacker.model = imdb_classifier
IMDB_attacker.dataset = IMDB_Dataset()
IMDB_attacker.adversarial_dataset = IMDB_Adversarial_Dataset()
IMDB_attacker.criterion = ['accuracy', 'F1', 'BCELoss']

#Attack and get logs
IMDB_attacker.attack()
IMDB_attacker.get_crtierion_logs()
IMDB_attacker.show_best_attacks()
IMDB_attacker.show_worst_attacks()

#Maybe more functionalities?

This shall be a multi-step process, avoid limiting yourself to the above mentioned example functionalities and please feel free to discuss more functionalities.

Looks pretty good!
Can think of integration with this https://github.com/huggingface/nlp https://github.com/huggingface/nlp as well.

On 21-May-2020, at 5:17 PM, Rajaswa Patil<EMAIL_ADDRESS>wrote:
The ultimate usage can be something like this:
from decepticonlp import attacker
from deceptionlp.transforms import transforms
import torch
from torch.uitls.data import Dataset
#define adversarial transforms
tfms = transforms.Compose(
[
transforms.AddChar(),
transforms.ShuffleChar("RandomWordExtractor", True),
transforms.VisuallySimilarChar(),
transforms.TypoChar("RandomWordExtractor", probability=0.5),
]
)
#Original dataset
class IMDB_Dataset(Dataset):
def init(self):
#some code
def _len__(self):
    #some code

def __getitem__(self, idx):
    text = data['review_text'][idx]    #get text from sample
    embeddings = getWordEmbeddings(text)    #convert to sequence of word embeddings
    label = torch.tensor(data['sentiment'][idx])    #sentiment label
    return embeddings, label

#Adversarial dataset
class IMDB_Adversarial_Dataset(Dataset):
def init(self):
#some code
def _len__(self):
    #some code

def __getitem__(self, idx):
    text = data['review_text'][idx]    #get text from sample
    adversarial_text = tfms(text)    #apply adversarial transform
    embeddings = getWordEmbeddings(adversarial_text)    #convert to sequence of word embeddings
    label = torch.tensor(data['sentiment'][idx])    #sentiment label
    return embeddings, label

#Load pre-trained model
imdb_classifier = torch.load("IMDB_Classifier.pth")
imdb_classifier.eval()
#Set up the attacker
IMDB_attacker = attacker()
IMDB_attacker.model = imdb_classifier
IMDB_attacker.dataset = IMDB_Dataset()
IMDB_attacker.adversarial_dataset = IMDB_Adversarial_Dataset()
IMDB_attacker.criterion = ['accuracy', 'F1', 'BCELoss']
#Attack and get logs
IMDB_attacker.attack()
IMDB_attacker.get_crtierion_logs()
IMDB_attacker.show_best_attacks()
IMDB_attacker.show_worst_attacks()
#Maybe more functionalities?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/SforAiDl/decepticonlp/issues/70#issuecomment-632042171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJ4QABLTN23HJ6NFQTDRSUIDZANCNFSM4NGYMAWA.

Maybe we can add functionality to draw graphs as well for loss, accuracy, etc. for both the original dataset and the adversarial dataset. More of a utility function rather than a necessary one though.

Would be helpful although if we’re doing that then a logger (Tensorboard, etc) would be much better.

On 21-May-2020, at 5:31 PM, abheesht17<EMAIL_ADDRESS>wrote:
Maybe we can add functionality to draw graphs as well for loss, accuracy, etc. for both the original dataset and the adversarial dataset. More of a utility function rather than a necessary one though.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/SforAiDl/decepticonlp/issues/70#issuecomment-632048285, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJYG6I7JCHFJZJZVKFLRSUJ2VANCNFSM4NGYMAWA.

Which one seems the better option:

Implement everything in crude way as shown in example above and then added logger, huggingface/nlp and other enhancements slowly over time
Start implementation with all these things taken into consideration beforehand

To me, definitely point 1

You can make a checklist here maybe with the suggestions here to keep track of the enhancements.

I am not sure if this would be feasible but introducing an option for the different available embeddings could be done. The attacker should have an option, if possible, depending on his model.

The user will define it himself in his Dataset class; we don't have to bother about which embedding he has used.

What should I check in the test function of the Attacker class?

Tests for attacker class would be 'integration' type tests rather than unit
tests. You'd want to have common example cases where the attacker does what
it is supposed to do.
On Fri, 22 May 2020, 07:42 abheesht17<EMAIL_ADDRESS>wrote:

What should I check in the test function of the Attacker class?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/SforAiDl/decepticonlp/issues/70#issuecomment-632439321,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AH72FJZYVZMOX2UDCLWHX4DRSXNRRANCNFSM4NGYMAWA
.

@Sharad24 can you provide some reference examples for these 'integration' type tests?
Maybe from GenRL?

Hmm the integration tests in GenRL are not that good and sort of brittle as of yet. Try reading from here: https://www.fullstackpython.com/integration-testing.html
The goal of them is that the individual units that are going to be used inside the attacker in our case the different transforms, etc., finally are able to work together through one API as they were intended. You don't really have to check the output from each individual unit for each difference case as that is already done in their unit testing. Here, we only test how good the objects work together and if they are any brittle points in their interfacing.
Although, if there are some methods in the Attacker class that are working as individual units then there should be unit tests for them.

Thanks! Will do


Create precision_of_float_and_double

What does the program do ?
create a precision of float and double variables (input by user)
In what programming language it is written?
C++

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


Develop a Basic Java App on SAP Cloud Platform

hey
I am at Step 16: Select SAP Cloud Platform as server type
I can run the app with the java web tomcat8 localhost server and its work(step 14)
I need to connect to hana.ondemand.com or hanatrial.ondemand.com

I press next
and I get this error  "Cannot reach host [https://hana.ondemand.com]. Check host name for typing errors and make sure your proxy and network settings are correct"

I can get to my SAP Cloud Platform Cockpit from the hana.ondemand.com in the chrome browser and I don't have any proxy in my system.
I tried it on NEON and Oxygen eclipse
thanks in advance

I make it work by using
eclipse Oxygen
https://tools.hana.ondemand.com/oxygen/
https://tools.hana.ondemand.com/


Syntax Highlighting for =.. operator is broken

The period immediately after the = is mistakenly highlighted in 'end of predicate' purple.
Dialect is SWI-Prolog, Platform is Windows 10.

Please refer to my explanation for syntax highlighting of Prolog in #9.

Yeah, I've dug around in the src files and figured that out. Is there any way we could sculpt a better solution? Maybe we could use a grammar / AST kinda setup for syntax highlighting? That'd require tons and tons of reconfig, but I feel like it'd be worth it to have better control over the highlighting.

It sounds interesting but I don't have time to dive into that. PR is much appreciated if you try it.

Yeah, I'll see what I can do, but I'm still learning Prolog, so I'll probably be tinkering with it for a few eons. Should I close this issue until I come up with something, or should I just keep it open?

Okey, thank you very much!

Upon further thought, ASTs would be sorta stupid cause would have to walk up and down the tree again and again, so I'll just try to learn regex so I can change the grammar to be better.


UI: version sorting is not working

Rancher Version:
1.0.1
Docker Version:
rancheros latest
OS and where are the hosts located? (cloud, bare metal, etc):
kvm
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Steps to Reproduce:
create a catalog revision with 2 digits as patch version
Results:
https://goo.gl/3frB0f
Expected:
1.1.11 being the most recent
Looks like this is just the "naive" string comparison implementation, wont work for versions

@EugenMayer this is a duplicate of #3719 but also note that this seems to be working in
Master - 07/26


Update genesis-contracts.md for Amoy

@simonDos let us know when this ready for @EmpieichO to approve.


Cannot read property 'name' of undefined caused by enum naming convention

https://codesandbox.io/s/prefix-and-naming-convention-cuzij

When set prefix transform, fieldNames naming convention and enum nameing convention at same time, all query and mutation would get this error.
{
  "errors": [
    {
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "message": "Cannot read property 'name' of undefined",
      "name": "GraphQLError",
      "stack": [
        "TypeError: Cannot read property 'name' of undefined",
        "    at MapLeafValues.transformFieldNode (/sandbox/node_modules/@graphql-tools/wrap/index.cjs.js:793:26)",
        "    at Object.Field (/sandbox/node_modules/@graphql-tools/wrap/index.cjs.js:783:52)",
        "    at Object.enter (/sandbox/node_modules/graphql/utilities/TypeInfo.js:370:25)",
        "    at Object.visit (/sandbox/node_modules/graphql/language/visitor.js:243:26)",
        "    at operations.map (/sandbox/node_modules/@graphql-tools/wrap/index.cjs.js:782:42)",
        "    at Array.map (<anonymous>)",
        "    at MapLeafValues.transformOperations (/sandbox/node_modules/@graphql-tools/wrap/index.cjs.js:777:27)",
        "    at MapLeafValues.transformRequest (/sandbox/node_modules/@graphql-tools/wrap/index.cjs.js:761:36)",
        "    at TransformEnumValues.transformRequest (/sandbox/node_modules/@graphql-tools/wrap/index.cjs.js:838:33)",
        "    at transforms.reduce (/sandbox/node_modules/@graphql-tools/utils/index.cjs.js:3309:101)"
      ]
    }
  ],
  "data": {
    "bmsGetAdminDivisionUsingGet": null
  }
}

I dig a little in the source code, find out the field object tranformer set the operation new name as alias but enum transformer still use the name but not the alias to find operation. However when i fixed this, anothor error poped up elsewhere. So i guess there is a systematic conflict between prefix transform, field transform and enum transform.
Also transformContext must passed to TransformEnumValues.transformRequest and TransformEnumValues.transformResult to make it works.

transformContext issue has been fixed in the latest version. Closing the issue for now. Feel free to open a new one with a reproduction if this is still relevant.


how to implement a tab bar at the buttom to launch certain avtivity

hi i have tab bar and a view pager, i add another tab bar at the bottom and didnt connect the one and only viewpager to it since the first tab bar is using it and the second tab bar will take control of that and that is not my intention,i want to implement another tab bar at the bottom just to launch activities. can you tell me how to implement it via your library
thanks in advance

it is helpful to rephrase the context to understand the problem much faster :)

@yousofkakhki This is unfortunately not possible with the library as it is right now. Sorry!


Add Basic Appointment Command

Able to add/update appointment to a person in FAST with the command: appointment <INDEX> a/<yyyy-mm-dd>
Able to delete appointment to a person in FAST with the improved command: appointment <INDEX> a/delete
Eg: appointment 1 a/2021-10-10
Expected: Added appointment with Alex Yeoh: 10 Oct 2021
To update the appointment, follow the same format as add, using the new date.
Eg: appointment 1 a/2021-11-10
Expected: Added appointment with Alex Yeoh: 10 Nov 2021
To delete the appointment, follow the same format as add, using delete word.
Eg: appointment 1 a/delete
Expected: Deleted appointment with Alex Yeoh

First thing I noticed was that the appointment command (which is the word appointment itself) is quite long. Perhaps we could discuss this with @squeakysquak as he does the Better Syntax portion of v1.2b, and maybe shorten it to another command (such as app or appt).


Scan Eddystone beacons based on partial Namespace

We provide a filter "FEAA" for scanning only Eddystone beacons. I would like to know if it is possible to filter scans based on the first 2 bytes of the 10-byte namespace. For example if my Namespace is 0044ddaa2255663142ea and 004433ead1452653273. I would like to detect both of them as they begin with 0044.
How can I achieve this?

Use the "serviceDataMask" filter for the bits you're interested in:
https://developer.android.com/reference/android/bluetooth/le/ScanFilter.Builder.html#setServiceData(android.os.ParcelUuid, byte[], byte[])

Hello, thanks for the answer but I forgot to mention that I am developing an IOS application.


Support various flavours of Angular

This PR aims to solve a few different problems

plugin not working with Angular v8 / enableIvy: true #556
plugin not having interop with native ES classes #545 / #505
plugin not honouring target: "es5" (outputting native classes) #552

The solution is to build two different outputs – one for es5 and one for es6 – following the guidance in this Angular Package Format document.
I'll cut a prerelease for people to try out before landing this PR.

I've shipped a prerelease v6.3.2-alpha.0 for anyone who is affected by the issues mentioned above.
To install this on your project:
npm i<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>
Please let me know whether this resolves #556, #545, #505 and #552. Thanks! 🙏


Tp2000 494  django management command update

TP2000-494 Django management command updates

Why

Tamato is missing a management command to straight-forwardly get workbasket info for packaging purposes.
A previous management command set_active_workbasket is no longer valid since the introduction of multi-workbasket capability.
What

Add a Django management command workbasket_info and enhance workbasket info output.
Remove the set_active_workbasket Django management command.

Checklist

Requires migrations? No
Requires dependency updates? No

Codecov Report

Merging #671 (107909e) into master (2686814) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   93.44%   93.44%
=======================================
  Files         325      325
  Lines       21126    21126
  Branches     1672     1672
=======================================
  Hits        19741    19741
  Misses       1063     1063
  Partials      322      322

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Looks good! What happens if the user forgets to add a PK argument?

A DoesNotExist exception is raised, which isn't so pretty but I'd expect a dev user to know what it means. I add an update to catch it and improve the output if you prefer?

Looks good! What happens if the user forgets to add a PK argument?

I've added more graceful handling of that case. Thanks Gabe!

Brill, thanks!


connecting to marionette server on the docker-firefox container is apparently failing due by invalid user permission

Hi,
About docker-firefox build arrangement that setups up the 'app' user as the executor of the firefox process group (which is a good idea)
About the firefox cli flag --marionette which starts marionette server on startup if provided
To accomplish this I forked docker-firefox and added the --marionette flag to the startapp.sh script =>
exec /usr/bin/firefox_wrapper --marionette --profile /config/profile --setDefaultBrowser >> /config/log/firefox/output.log 2>> /config/log/firefox/error.log

Initially my first testing setup added my compiled golang web-scraping binary, called dataminer, to the roofs/usr/bin folder, which I built producing a custom image
I started the custom docker-firefox:marionette image in a container called firefox and opened my browser at localhost:5800 and all was good
Then I ran > docker exec -it firefox /usr/bin/dataminer  which ran as expected, installing my web-scraper addon
The firefox browser view showed that my addon was installed. I test ran it and it worked fine
My goal is to run my dataminer binary in a separate container connecting to the custom firefox container and marionette server remotely to install addons
My 2 container setup so far has failed when my dataminer app tries to open a remote tcp connection on port 2828. The log shows : connection refused
I have setup a dedicated docker bridge network adding the --network  arg to the docker run command for each container
To try debugging, I docker exec-ed into the firefox container running > netstat -tulpn | grep LISTEN
tcp        0      0 <IP_ADDRESS>:5800            <IP_ADDRESS>:*               LISTEN      3089/nginx.conf -g
tcp        0      0 <IP_ADDRESS>:2828          <IP_ADDRESS>:*               LISTEN      -
tcp        0      0 <IP_ADDRESS>:5900            <IP_ADDRESS>:*               LISTEN      3114/x11vnc
tcp        0      0 <IP_ADDRESS>:45697        <IP_ADDRESS>:*               LISTEN      -

This shows marionette is running on port 2828 as expected
Also ran > ps
 3233 app       0:00 {firefox_wrapper} /bin/sh /usr/bin/firefox_wrapper --marionette --profile /con
 3263 app       0:03 {GeckoMain} /usr/bin/firefox --marionette --profile /config/profile --setDefau
 3341 app       0:00 {Privileged Cont} /usr/lib/firefox/firefox -contentproc -childID 1 -isForBrows
 3395 app       0:01 {WebExtensions} /usr/lib/firefox/firefox -contentproc -childID 2 -isForBrowser
 3446 app       0:00 {Web Content} /usr/lib/firefox/firefox -contentproc -childID 3 -isForBrowser -

This shows that the firefox process group is executed by user app
I ran > cat /etc/passwd, it shows app user has the user id and group id couple => 1000:1000
With this info, I was hoping that by adding a corresponding user with 1000:1000 ids, the corresponding user profile would eliminate any user permission blocking
But after adding the useradd and groupadd code to my dataminer Dockerfile, rebuilding and rerunning still produced the same error => connection refused
To proof that the network was working as expected, I execed into the dataminer container and pinged the firefox container
My terminal showed packets received correctly
I ran > whoami which returned => app
Could you please advise what might be the root issue?

connection refused usually means that the port is not open.
Did you exposed port 2828 via the -p parameter ?

Did you exposed port 2828 via the -p parameter ?

@jlesage As I recall, I did figure out that this issue should be resolved by port forwarding. So I added EXPOSE 2828 to my forked version of docker-firefox and added -p 2828:2828 to the run command. But in the end, I solved the problem by making a proxy service that runs on port 2929 as an exec process after firefox starts. Sounds like a lot of work? Not really ... and this allowed 1. waiting for firefox to start 2. easier and better debugging of marionette protocol 3. learning more about packet encoding and decoding

@jlesage by default request to the firefox instance inside the docker container without a proxy do not work. If you try to curl http://<IP_ADDRESS>:5800/json/version when starting the instance with --remote-debugging-port=5800 and simply using the image to download the binary of firefox.

You cannot use --remote-debugging-port with the same port as the container web interface.  You need to use a different one.  Also, from what I understand, this option creates a web server instance listening on localhost only.  That means  that if you create the container with the default bridge network, you can access the debug interface only when inside the container.  The other solution is to create the container with the host network: in this case, you should be able to access the interface from the host running the container.

I guess this is related to #153.
In Chrome it seems to work using CDP for the remote debugging session: https://github.com/yukinying/chrome-headless-browser-docker
docker run --init -it --rm --name chrome --shm-size=1024m -p=<IP_ADDRESS>:9222:9222 --cap-add=SYS_ADMIN \   yukinying/chrome-headless-browser


Flush out the node.js guidelines document

The entente node.js coding guidelines document has a solid outline but needs to be flushed out.  We should think about if this document is meant for bucharest-gold, or a general node.js coding guidelines for Red Hat and/or other interested projects.
https://github.com/bucharest-gold/entente/blob/master/GUIDELINES.md

@balunasj when you get a chance, please have a look. Feedback welcome.

@balunasj I've been keeping the guidelines relatively current, and adding things here and there. How about we close this, and when there is a need to add something specific to the guidelines, we can go with a new issue for each thing.
For example, maybe we need an issue to get szero usage covered in the guidelines doc - unless @helio-frota has already done it. :)

+1 - closing


Underlined autohidestrip tab style not always used

In a theme using VS2005AutoHideStrip.TabStyle=Underlined
Both bottom and right tabs look underlined-styled, however if any of the right panels (e.g. Project) are docked, the right panel bar is moved to the right bottom of the screen, styled with the default (not underlined) style.
FD 5.0.1
.NET CLR 2.0.50727
http://www.flashdevelop.org/community/viewtopic.php?f=6&t=12381

I understand now it's not a bug after all, intended feature.


AGE - Lighting the Fuse

https://dtdb.co/en/card/16020
Something to get started:
const ActionCard = require('../../actioncard.js');
const PhaseNames = require('../../Constants/PhaseNames.js');
const GameActions = require('../../GameActions/index.js');

class LightingTheFuse extends ActionCard {
    setupCardAbilities() {
        this.action({
            title: 'Lighting the Fuse',
            playType: 'cheatin resolution',
            target: {
                activePromptTitle: 'Select deed to blow up',
                cardCondition: {
                    location: 'play area',
                    condition: card => this.controller.getOpponent().equals(card.owner)
                },
                cardType: 'deed'
            },
            handler: context => {
                const thecheater = context.player.getOpponent();
                const kaboomification = () =>
                    this.game.resolveGameAction(GameActions.ReturnCardToHand({ card: context.target }), context).thenExecute(() => {
                        this.game.addMessage('{0} uses {1} to detonate {2}', context.player, this, context.target);
                    });
                if(this.game.currentPhase === PhaseNames.Gambling) {
                    context.game.promptForYesNo(thecheater, {
                        title: `Do you want to send two dudes to disarm the bomb at ${context.target.title}?`,
                        onYes: () => {
                            this.game.promptForSelect(thecheater, {
                                activePromptTitle: 'Select two dudes',
                                waitingPromptTitle: 'Waiting for opponent to select dudes',
                                cardCondition: card => card.location === 'play area' && card.controller === thecheater,
                                cardType: 'dude',
                                gameAction: ['moveDude','boot'],
                                multiSelect: true,
                                numCards: 2,
                                mode: 'exactly',
                                onSelect: (p, bombsquad) => {
                                    bombsquad.forEach(body => {
                                        this.game.resolveGameAction(GameActions.moveDude({
                                            card: body,
                                            targetUuid: context.target.uuid,
                                            options: { needToBoot: true, allowBooted: true }
                                        }), context);
                                    });
                                    this.game.addMessage('{0} uses {1} on {2}; {3} rush to stop it', context.player, this, context.target, bombsquad);
                                    return true;
                                },
                                onCancel: () => kaboomification(),
                                source: this
                            });
                        },
                        onNo: () => kaboomification(),
                        source: this
                    });
                } else {//not gambling, must be a shootout
                    kaboomification();
                }
            },
            source: this
        });
    }
}

LightingTheFuse.code = '16020';

module.exports = LightingTheFuse;

Resolved by #1475


Arrow of creation gets stuck on cloning a single thing

With an arrow of creation...

Clone an arrow of destruction.
Try to create an arrow of recording.

Expected: create Arrow of recording.
Actual: create Arrow of destruction

Cloning state should be canceled after re-clicking on object.


ecrecover doesn't handle truncated calldata correctly

Metadata

Hardfork: spurious dragon (though probably others too)

What was wrong?
If the calldata provided to ecrecover is shorter than 128 bytes, the computed address is incorrect.
Here is a demo contract that passes on geth, but reverts with the specs:
// SPDX-License-Identifier: CC0-1.0

pragma solidity >=0.7.0 <0.9.0;

contract Test {
    constructor() {
        uint256 called;
        bytes32 account;

        bytes memory signature = hex"79d2457a6ebeb06cf66f9f98622383ec60551b26f807bc12e3d5c94098726ed83089d92babdf93a0e14c3e71a30aca5e413e20031c6d46cb4eecdea1453d8c951b";
        bytes32 message = keccak256(hex"626f6f70");

        bytes32 r;
        bytes32 s;
        uint8 v;
        assembly {
            r := mload(add(signature, 0x20))
            s := mload(add(signature, 0x40))
            v := byte(0, mload(add(signature, 0x60)))
        }

        bytes memory input = abi.encodePacked(message, uint256(v), r, s);

        assembly {
            let backup := mload(0)
            called := call(
                gas(),
                0x01,
                0,
                add(input, 0x20),
                120,
                0,
                32
            )
            account := mload(0)
            mstore(0, backup)
        }

        require(called == 1, "ecrecover failed");
        require(account == hex"0000000000000000000000004c9aa3db09a35aead685d7129af4cc9415f2c6f4", "wrong address");
    }
}

Interesting. How would one go about replicating this locally using the above contract?

Here is a demo contract that passes on geth, but reverts with the specs
Specifically, how would I go about verifying this statement locally? Just curious to know.


UnboundLocalError

Hello,
I was following the tutorial with the fits file I downloaded, and I'm getting UnboundLocalError: local variable 'sig' referenced before assignment for some F606W images (Prop ID 14235, visit # 18 - low t_exp file excluded) when I run TweakReg. Can I get help with this?

Hello, can you please elaborate on exactly which tutorial you were using?

And exactly which image(s) are you trying to use? https://archive.stsci.edu/proposal_search.php?id=14235&mission=hst

cc @catherine-martlin

I was following align_mosaics. I removed some of the keyword parameters and mine looks like:
tweakreg.TweakReg(input_flc, imagefindcfg={'threshold': dictThreshold[field_type[key]],
                 'conv_width': dictConv_width[field_type[key]],'dqbits': 0},
                 minobj=5,
                 shiftfile=False,
                 updatehdr=False,
                 interactive=False)

I was trying to use JCX618010. I excluded jcx618ihq_flc.fits from the dataset because it had low exposure time.

Errr... @samanthalh then?

Hello! After consulting with a software expert, I believe this error is happening because TweakReg can find no matching sources between the images. There is already an improvement coded that changes this warning to something easier to understand and troubleshoot, but it hasn't been released yet. Assuming this is the problem, you can either determine why there are no matches (try adjusting the source finding parameters, the matching criteria, etc.) or disable us2dhist.
Also, for problems like this where the notebooks have been modified for a new workflow, I would strongly recommend that you submit a help desk ticket here: https://stsci.service-now.com/hst. Your questions will go right to DrizzlePac experts rather than to the Jupyter notebook maintainers, so you'll get an answer quicker and more directly.
Hope this helps!
Samantha
DrizzlePac Help Desk Lead

Thank you for your feedback! @samanthalh


Worker() imports chunks further imports

Bug report

What is the current behavior?
When using webpack's native Worker loader, imports from within the worker are split into chunks.
If the current behavior is a bug, please provide the steps to reproduce.

git clone https://github.com/birtles/webpack-worker-test
yarn install
cd webpack-worker-test
npx webpack
ls -al dist
Observe that lodash (as required by worker.js) has been split into a separate chunk.

What is the expected behavior?
There should be a single worker bundle.
The background is I have a project where I produce exactly two files: the main thread JS, and the worker bundle.
Previously I was using GoogleChromeLabs/worker-plugin for this but it no longer works after upgrading to webpack 5 (#88).
I have tried to replace worker-plugin with webpack 5's native Worker() support but I cannot get it to produce a single worker bundle (despite successfully producing a single main thread bundle). I have tried all the options webpackEntrypoints, workerChunkLoading etc.
(I have tried to produce a minimal test case but I may not have accurately recreated the original problem in the process. The original file is something more like this one.)

Other relevant information:
webpack version:  5.1.3 (CLI: 4.0.0)
Node.js version: 12.14.0
Operating System: Windows 10 Pro (WSL)
Additional tools: (Although likely unrelated to this issue the project I am working on also uses TypeScript, html-webpack-plugin, copy-webpack-plugin, clean-webpack-plugin, mini-css-extract-css-plugin, purge-css)

There should be a single worker bundle.

Why do you need that?
Webpack is optimizing lodash into a shared chunk between main and worker so you don't have to download it twice.
The optimization.splitChunks option allows to control that.

There should be a single worker bundle.

Why do you need that?

The extra request is not necessary since there is no code shared between the two bundles.

Webpack is optimizing lodash into a shared chunk between main and worker so you don't have to download it twice.

It's not used by the main thread code (index.js in this case).
However, having looked into this, I think this issue may be invalid, assuming my understanding of the following is correct.

I originally filed this because I observed that webpack doesn't split out chunks from the main thread bundle, only the worker bundle (in my app the main thread bundle includes many third-party dependencies but they still end up in the main bundle, only the worker code gets chunked). I believe this is because the default value for splitChunks.chunks defaults to async and the worker code is treated as async.

I can disable this premature splitting with optimization.splitChunks.maxSize = 2 (defaults to 1).

Is that correct?

yes except [optimization.splitChunks.maxSize](https://webpack.js.org/plugins/split-chunks-plugin/#splitchunksmaxsize) sets the maximum size in bytes treshold to split a chunk and has a default of 0 not 1.
@birtles  i just checked out your test repo and saw that you already fixed it :+1:
i think we may close the issue?

yes except optimization.splitChunks.maxSize sets the maximum size in bytes treshold to split a chunk and has a default of 0 not 1.

Yes, sorry, I meant minChunks!

@birtles i just checked out your test repo and saw that you already fixed it 👍
i think we may close the issue?

Yes, sorry for the noise!

Ah I see. So this is vendor splitting for better long term caching. You can disable it with optimization.splitChunks.cacheGroups.defaultVendors: false


Using Image Point Coordinates To Add Overlays

Hi. From the documentation you can get different kinds of coordinates, https://openseadragon.github.io/examples/viewport-coordinates/.
How do you use imagePoint coordinates, (convert from viewport coordinates to image coordinates) to correctly position overlays with addOverlay?
The idea is you click on the viewer, get the imagePoint coordinates, and use those to position an icon on that spot where you clicked.
viewer.addOverlay({
element: elt,
location: //imagePoint coordinates
});
Any help would be great, thank you!

As mention on doc  The point or rectangle which will be overlaid. This is a viewport relative location.
You can use imageToViewportCoordinates method to canvert your image coordinates into viewport coordinates
For More examples/ui-overlays

If you use location when calling addOverlay it needs to be in viewport coordinates. In general I recommend working in viewport coordinates anyway, when possible. Here's a basic example:
viewer.addHandler('canvas-click', function(event) {
    if (event.quick) {
        // Convert the click position from web coordinates to viewport coordinates
        var viewportPos = viewer.viewport.viewerElementToViewportCoordinates(event.position);

        // Now you can use addOverlay with the viewportPos
    }
});

If you really want to use image coordinates, you can use viewerElementToImageCoordinates. Then you'll have to use px and py in addOverlay. Keep in mind that internally it just converts those image coordinates back to viewport coordinates.

Unfortunately image pixels are needed, I am converting a live system where it uses images with pointer images using pixels for the positioning. Switching it to use Openseadragon with co-ordinates will ruin the positioning of all the existing use cases, so it needs to keep the pixels while also now using the zoom capabilities of OpenSeaDragon.

May I ask for an example of how to convert image pixels to co-ordinates and then using those new co-ordinates for addOverlay please.

If I try this for example, I just wanted to try it out with 10 pixels x and 10 pixels y, and the result is the overlay is positioned at 9000px top and 9350px left, what am I doing wrong:
let testEle = document.getElementById("testId");
var elePos = viewer.viewport.imageToViewportCoordinates(10, 10);

viewer.addOverlay({
  element: testEle,
  px: elePos.x,
  py: elePos.y
});

When you use px those numbers are in image coordinates. So, if you wanted to use 10, 10, you could just use:
let testEle = document.getElementById("testId");

viewer.addOverlay({
  element: testEle,
  px: 10,
  py: 10
});

The other option would be to use x instead of px, which will allow you to use viewport coordinates. That would look like this:
let testEle = document.getElementById("testId");
var elePos = viewer.viewport.imageToViewportCoordinates(10, 10);

viewer.addOverlay({
  element: testEle,
  x: elePos.x,
  y: elePos.y
});

One thing to keep in mind is that the viewport coordinates are not set up properly until the image has been opened (it's an async operation). Don't call addOverlay until after the open event has fired. You can use viewer.addHandler('open', function() { ... }).

Thank you, is there another event handler that can be used upon interaction, I'm using this on a React project and I need to trigger a new hotspot addition in response to whenever state is updated.

@AnderSco01 What kind of interaction? There are events for clicking and zooming, etc. You can see all the viewer events here:
http://openseadragon.github.io/docs/OpenSeadragon.Viewer.html


Matter cleanup

The purpose of this PR is to cleanup all the Matter helper code.
The transition process during the prolonged cut-over is like this:

continuously copy the .js files from Matter onto an "import" branch.
provide manual fixes on the matter-cleanup branch.
whenever a new copy comes to "import" branch, perform a merge from import branch to matter-cleanup branch.

@bzbarsky-apple : I disabled ASI and mandated semicolons in all generator/matter/**/*.js source files.

@bzbarsky-apple : this is now ready to be merged.
Since last time you checked:

the matter .js code now has semicolons.
all the tests.js files have been removed. Instead, there is a bunch of ciTests.json and manualTests.json files on the SDK itself. (which will be brought in with a separate PR on the Matter repo, once this merges in.)


Don't use custom CA if HTTPS works out of the box

If it works there is no need to download and use the custom CA. This usually happens when we're dealing with a load-balancer or when a custom CA has already been added to the system.
With the Python library we're using (requests), specifying a path to a custom CA would ignore the default CA bundle in the system, so setting-up a cluster through a load balancer endpoint with a well-known CA (eg. Digicert) was previously failing without this change.
https://jira.mesosphere.com/browse/DCOS-19040

run linux integration tests

run linux integration tests

run linux integration tests

run linux integration tests

run linux integration tests

run linux integration tests

test_debug_details failed again (should be fixed with #1078), retrying...

@mnaboka : I've addressed your comments and added unit tests.


static link to mkldnn

To get rid of the rpath issue

How do we ensure that these changes work for python packages as well?

How do we ensure that these changes work for python packages as well?

I tested it locally.

How do we ensure that these changes work for python packages as well?

I tested it locally.

Mac?

Mac?

Previously, it doesn't work. After this fix, it's unknown.

for my understanding, can you provide more details. what is the rpath issue?
is it similar to what we had to do for python shared lib: https://github.com/Microsoft/onnxruntime/blob/master/cmake/onnxruntime_python.cmake#L87
?

for my understanding, can you provide more details. what is the rpath issue?
is it similar to what we had to do for python shared lib: https://github.com/Microsoft/onnxruntime/blob/master/cmake/onnxruntime_python.cmake#L87
?

Yes.  It's kind of similar.
If you run ldd on the final binaries, sometimes it points to
mklml/src/project_mklml/lib/libmklml_intel.so

instead of "libmklml_intel.so" directly.
Therefore, even we added the current folder into LD_LIBRARY_PATH, it will still try to find  "mklml/src/project_mklml/lib/libmklml_intel.so" instead of "libmklml_intel.so" in current folder.
We could try to find the reason why it has such a long name, but I would think a simpler fix is changing it to static link.

just to confirm the issue you are reporting.
this is only an issue on Linux and only when building with both --use_mkldnn and --use_mklml  (if we leave off the latter, there is no issue)
I am unable to reproduce the issue of ldd on final binaries pointing to the wrong libmklml_intel.so location. can you run objdump -x on the binary and see if some rpath is being added to header?
when I built from master, I don't see any rpath being set for libmkldnn.so or libmklml_intel.so
Thus, when I properly set LD_LIBRARY_PATH to the mkldnn libs, I don't see any issues.
btw, I built your dev branch snnn/dnn , and I don't think mklml is being statically linked due to the size of the final binaries. i do see mkldnn in there.
also, I ran onnxruntime_perf_test on resnet50 and I do notice that it is noticeably slower than master.
not sure why exactly.

just to confirm the issue you are reporting.
this is only an issue on Linux and only when building with both --use_mkldnn and --use_mklml (if we leave off the latter, there is no issue)
I am unable to reproduce the issue of ldd on final binaries pointing to the wrong libmklml_intel.so location. can you run objdump -x on the binary and see if some rpath is being added to header?
when I built from master, I don't see any rpath being set for libmkldnn.so or libmklml_intel.so
Thus, when I properly set LD_LIBRARY_PATH to the mkldnn libs, I don't see any issues.
btw, I built your dev branch snnn/dnn , and I don't think mklml is being statically linked due to the size of the final binaries. i do see mkldnn in there.
also, I ran onnxruntime_perf_test on resnet50 and I do notice that it is noticeably slower than master.
not sure why exactly.

Hi @jywu-msft
The main change in this PR is adding "-DMKLDNN_LIBRARY_TYPE=STATIC" to mkldnn's cmake args. So, mkldnn will be built as a static library, therefore it will not link to any other libraries(including mklml). Then it's onnxruntime's  responsibility to find mklml and link to it. And it still dynamically links to mklml.
Let me close this PR right now, because it needs more investigations.
Thanks for your finds and suggestions.


[ReAct][Robustness++] Avoid "Reached max iterations" errors by telling Agent how many steps are allowed

Description
Fixes https://github.com/run-llama/llama_index/issues/12209 . TL;DR: Agent can avoid "Reached max iterations" problems if it has been told how many steps it can try.

 Before
  After

 Agent keeps on trying and gets killed at the framework level.
  Agent knows when to give up.

New Package?
Not a new package.
Version Bump?
Not applicable.
Type of Change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

@tslmy just curious, do you think this will influence the agent to run for all steps, rather than stopping when it is ready? Or what has your experience been like?

@logan-markewich good question. I have not yet encountered a case where

the Agent used to consume just one or two steps to complete a task before this PR and
started to consume all allowances with this PR,

only cases where

it used to consume too many steps before the PR and
started capping at its allowed steps with the PR.

But I think that really owes to the lack of cases I tested & the low intelligence of the 7B LLMs I tried locally.

@tslmy sorry for any delay here. I'm a tad worried about merging a change like this to the prompt. Would it better to use the error handling we added before to handle when max iterations is reached?

No worries at all @logan-markewich . I barely have time to attend to my side projects during weekdays anyway.
Let me try to convince you that this must go into the prompt. The whole point is to let the Agent know that it must take less than N steps to complete a task at the beginning, so that it can better plan out the procedure.
The error handling won't cut it. Why? Let's suppose the Agent is at its (N+1)-th step out of N allowed steps. We raise an exception. The error handler catches it. The handler offers Agent a 2nd chance to fix it. The Agent tries something different, which would be the (N+2)-th step. We raise an exception. The error handler catches it. The handler offers Agent a 3rd chance to fix it... You see where this is going ;)
I'm actually kinda OK to remove the "(X of Y steps)" part at every "Thought:" line, if that's what making you uncomfortable, because it only serves as a reminder of the LLM that "hey, you've consumed X steps out of your allowance of Y, so you gotta hurry up in your next Y-X steps".

@tslmy Yea, you nailed it, the (1 of x) in the thought line was making me a tad nervous 👀

@logan-markewich no problem, Logan. I've updated the PR, removing the "(X of Y steps)" part at every "Thought:" line but keeping the "you should cap it at X steps" line. Does it look good to you?
In my own projects, I always override the default prompt anyway, so no hard feelings.

@tslmy, can you describe the behavior of agent if the max_iteration value is being set to 5?

Hi @CP-Geeky ,
When max_iterations is set to 5, allowance will be (5-1) // 2 = 2. The LLM will see that it is only allowed to take 2 steps.
LLM will say,

Thought: (Step 1 out of 2) I need to do X.
Action: ...
Action Input: ...

which counts as one iteration.
This action will yield an output. The LLM will take a 2nd iteration to parse it:

Observation: Y

The LLM then takes a 3rd iteration to come up with a follow-up.

Thought: (Step 2 out of 2) I see that doing X has given me Y. I would have continued to do Z, but I'm running out of allowance of steps, so I'll just give up.
Answer: I don't know how to answer your question. The best I can tell you is that by doing X I know Y. You might wanna do Z yourself.


bs binaries paths are determined wrong in monorepos

https://github.com/rescript-lang/rescript-vscode/blob/ba96a2fe1c603e73703bce7c25244d2508dcc334/server/src/server.ts#L291
E.g. this wouldn't work for monorepos that use yarn workspaces, b/c binaries are hoisted above the bsconfig's node_modules.

Second this, it doesn't work in monorepos 😞
A solution in the short term could be to have a "bsb path"/"bsc path" settings maybe? It's something that could be useful anyway 😄

We as well use yarn workspaces and have lost formatting.

Came here to open the same issue.
Any solution would help as we're really excited to get started using it. looks much more stable, fast. fun. you got me all excited!

@BlueHotDog you can already get the extension working with monorepos if you use this branch: https://github.com/rescript-lang/rescript-vscode/pull/16 it works fine so far 😄

I worked around this for the time being by adding this package.json config to the sub-project where I'm going to be using ReScript:
"workspaces": {
  "nohoist": ["bs-platform"]
},

and then running:
yarn --force

Alternatively you can do this globally by modifying the workspaces definition in your root package.json from something like this:
"workspaces": ["libs/*"],

to this:
"workspaces": {
  "packages": ["libs/*"],
  "nohoist": ["**/bs-platform"]
},

We rather wait until this extension stabilizes. this issue is open for 4 months, with open Prs trying to fix this. can any maintain please help here?

Hey guys, check this out if you are using yarn workspaces, I have a PR in that has a current release flag that you can try for vim plug.
https://github.com/rescript-lang/vim-rescript/pull/19

We've fixed this and it's released =D
See forum  or the release

We've fixed this and it's released =D
See forum  or the release


After sign out , app is not redirecting to post_sign_out url

I ran the application 1-Authentication sign-in. I was able to sign in and see token details. When i clicked on Sign out button on the top right, it took me to microsoft signout window and logged me out. But when i again hit http://localhost:8000, i was still signed in. I inspected a bit. After sign_out, app should redirect to post_sign_out url to clear the identity_context_data. But app is not redirecting to post_sign_out url. Here is the trace
[05/Apr/2021 18:15:10] "GET / HTTP/1.1" 200 2503
----------------------------------------
Exception happened during processing of request from ('<IP_ADDRESS>', 60059)
Traceback (most recent call last):
  File "c:\users\hp\appdata\local\programs\python\python37-32\lib\socketserver.py", line 650, in process_request_thread
    self.finish_request(request, client_address)
  File "c:\users\hp\appdata\local\programs\python\python37-32\lib\socketserver.py", line 360, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "c:\users\hp\appdata\local\programs\python\python37-32\lib\socketserver.py", line 720, in __init__
    self.handle()
  File "C:\Users\hp\Desktop\ms-identity-python-django-tutorial\1-Authentication\sign-in\venv\lib\site-packages\django\core\servers\basehttp.py", line 174, in handle
    self.handle_one_request()
  File "C:\Users\hp\Desktop\ms-identity-python-django-tutorial\1-Authentication\sign-in\venv\lib\site-packages\django\core\servers\basehttp.py", line 182, in handle_
one_request
    self.raw_requestline = self.rfile.readline(65537)
  File "c:\users\hp\appdata\local\programs\python\python37-32\lib\socket.py", line 589, in readinto
    return self._sock.recv_into(b)
ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine
----------------------------------------
auth/sign_out: signing out username: Abhinav Soni
[05/Apr/2021 18:15:13] "GET /auth/sign_out HTTP/1.1" 302 0

If everything would have gone smoothly then i would have seen one more print statement i.e  auth/post_sign_out: clearing session for username: Abhinav Soni
Here are the snippets of sign_out and post_sign_out views:
def sign_out(self, request):
    self.logger.debug(f"{self.prefix}{self.endpoints.sign_out}: signing out username: {request.identity_context_data.username}")
    print(f"{self.prefix}{self.endpoints.sign_out}: signing out username: {request.identity_context_data.username}")
    return self.ms_identity_web.sign_out(request.build_absolute_uri(reverse(self.endpoints.post_sign_out)))    # send the user to Azure AD logout endpoint

def post_sign_out(self, request):
    self.logger.debug(f"{self.prefix}{self.endpoints.post_sign_out}: clearing session for username: {request.identity_context_data.username}")
    print(f"{self.prefix}{self.endpoints.post_sign_out}: clearing session for username: {request.identity_context_data.username}")
    self.ms_identity_web.remove_user(request.identity_context_data.username)  # remove user auth from session on successful logout
    return redirect(reverse('index'))

You morelikely forgot to add the logout_url in the azure portal: https://stackoverflow.com/questions/45935305/azure-ad-logout-url-not-redirecting

@datasleek, can you let us know if @e-scheer's answer helped you out here?  I'm going to close this issue, but if you need it reopened, please do so.  Thanks.


Full scheduler::Symbol support + Keyword argument forwarding

Terminology: By "top-level" keyword arguments I refer to keyword arguments that are directly provided to the parallel function API, e.g to tmapreduce, tmap, etc. (in contrast to those provided to a Scheduler constructor).
Principle:
If scheduler isa Symbol, then (most) "top-level" keyword arguments are forwarded to the constructor of the Scheduler that corresponds to the symbol (if any). If scheduler isa Scheduler, to avoid ambiguity, we error if a scheduler option is provided as a "top-level" keyword argument.
Examples (see docstrings and runtests.jl for more):
julia> tmapreduce(sin, +, 1:100; scheduler=:static)
-0.12717101366042027

julia> tmapreduce(sin, +, 1:100; ntasks=2)
-0.12717101366041983

julia> tmapreduce(sin, +, 1:100; chunksize=10, scheduler=:static)
-0.12717101366042027

julia> tmapreduce(sin, +, 1:100; chunksize=10, scheduler=StaticScheduler())
ERROR: ArgumentError: Providing an explicit scheduler as well as direct keyword arguments (e.g. chunksize) is currently not supported.
[...]

julia> @tasks for i in 1:100
           @set ntasks=4*nthreads()
           # non-uniform work...
       end

julia> @tasks for i in 1:100
           @set begin
               scheduler=:static
               nchunks=10
           end
           # work ....
       end

More:

StaticScheduler and DynamicScheduler now can also take a ntasks keyword argument which is just an alias for nchunks.

Besides implementing these features, I found and fixed some minor code, docstring, and testing bugs.
Closes #76.

I think that tests are failing because of https://github.com/JuliaFolds2/OhMyThreads.jl/issues/82.

Oops, meant to hit "approve"


Revert "Start using GCE safe format and mount for mounting disks."

This reverts commit 3f109d6d4601795b685b5a2d180c85983b900d8b.

Self merging, as this is breaking e2e.


Polybar can't load all the unicode characters from Font Awesome 5

At first I tried using the ttf-font-awesome package (from the Arch package manager), since it failed showing all the icons I uninstalled it and manually added the otf fonts from the Font Awesome website.
Now polybar can only load the flag and clock icon. This is the console output:

warn: internal/volume is deprecated, use internal/alsa instead
warn: Dropping unmatched character  (U+f001)
warn: Dropping unmatched character  (U+f1eb)
warn: Dropping unmatched character  (U+f025)
warn: Dropping unmatched character  (U+f240)
warn: Dropping unmatched character  (U+f001)
warn: Dropping unmatched character  (U+f076)
warn: Dropping unmatched character  (U+f1eb)
warn: Dropping unmatched character  (U+f025)
warn: Dropping unmatched character  (U+f240)

This is the relevant config part:
font-0 = DejavuSansMono:size=10;4
font-1 = NotoSansCJKJP:size=10;4
;font-2 = FontAwesome:size=10;4
font-2 = Font Awesome 5 Free:size=10;4

Update your config :
font-1 = FontAwesome5Free:style=Solid:size=10;4
font-2 = FontAwesome5Free:style=Regular:size=10;4
font-3 = FontAwesome5Brands:style=Regular:size=10;4

you can list font with
fc-list | grep Awesome

Same result, unmatched characters

Please read the Font Wiki page. It should have everything you need to debug this issue yourselves. Fonts can have different names on different systems, so not all solutions other people propose will work one-to-one. Also make sure the icon you are trying to display is actually available in the fonts you loaded.

I found the solution. The archive you can download from the Font Awesome website (the free version one) offers 3 different fonts containing each different portions of the +1000 free icons. The difference with Font Awesome 4 is that it's a single font file, on the other hand you need to load the three font awesome 5 fonts if you want to be 100% sure your characters will be correctly displayed on the bar.
This is the fc-list matching the fonts I downloaded from the website:

$ fc-list |grep ".local/share/fonts"
/home/leewdch/.local/share/fonts/Font Awesome 5 Free-Solid-900.otf: Font Awesome 5 Free,Font Awesome 5 Free Solid:style=Solid
/home/leewdch/.local/share/fonts/Font Awesome 5 Free-Regular-400.otf: Font Awesome 5 Free,Font Awesome 5 Free Regular:style=Regular
/home/leewdch/.local/share/fonts/Font Awesome 5 Brands-Regular-400.otf: Font Awesome 5 Brands,Font Awesome 5 Brands Regular:style=Regular

and this is the relevant part in my polybar config:

font-0 = DejavuSansMono:size=10;4
font-1 = NotoSansCJKJP:size=10;4
;font-2 = FontAwesome:size=10;4
font-2 = Font Awesome 5 Free Regular:size=10;4
font-3 = Font Awesome 5 Free Solid:size=10;4
font-4 = Font Awesome 5 Brands Regular:size=10;4

The commented line is the previous Font Awesome 4 file I used to display the icons. As you can see I just added all the different font files using the names displayed on the very right with fc-list

Update your config :
font-1 = FontAwesome5Free:style=Solid:size=10;4
font-2 = FontAwesome5Free:style=Regular:size=10;4
font-3 = FontAwesome5Brands:style=Regular:size=10;4

you can list font with
fc-list | grep Awesome

Thanks, you can fix my error.

sudo pacman -S ttf-font-awesome

Update your config :
font-1 = FontAwesome5Free:style=Solid:size=10;4
font-2 = FontAwesome5Free:style=Regular:size=10;4
font-3 = FontAwesome5Brands:style=Regular:size=10;4

you can list font with
fc-list | grep Awesome

Thanks, you can fix my error.

I had the same problem, this solved it


unexpected SQLiteReadOnlyDatabaseException

This exception has happened much after the database was opened and used. I initialize DBFlow on startup. Then I was using DBFlow for both reading and writing for a while (just several selects, inserts and updates without any stress). Then after a short pause on a new update this happened. I can't reproduce it anymore, so I assume that it's rare. It's still very important to fix, because it crashes the whole app.
E/SQLiteLog(15743): (1032) statement aborts at 45: [UPDATE  OR ABORT MyModel SET x=?,y=?,z=? WHERE `id`='...'
Caused by: android.database.sqlite.SQLiteReadOnlyDatabaseException: attempt to write a readonly database (code 1032)
	at android.database.sqlite.SQLiteConnection.nativeExecuteForChangedRowCount(Native Method)
	at android.database.sqlite.SQLiteConnection.executeForChangedRowCount(SQLiteConnection.java:734)
	at android.database.sqlite.SQLiteSession.executeForChangedRowCount(SQLiteSession.java:754)
	at android.database.sqlite.SQLiteStatement.executeUpdateDelete(SQLiteStatement.java:64)
	at android.database.sqlite.SQLiteDatabase.updateWithOnConflict(SQLiteDatabase.java:1576)
	at com.raizlabs.android.dbflow.SQLiteCompatibilityUtils.updateWithOnConflict(SQLiteCompatibilityUtils.java:63)
	at com.raizlabs.android.dbflow.sql.SqlUtils.update(SqlUtils.java:289)
	at com.raizlabs.android.dbflow.sql.SqlUtils.save(SqlUtils.java:264)
	at com.raizlabs.android.dbflow.structure.ModelAdapter.save(ModelAdapter.java:54)
	at com.raizlabs.android.dbflow.structure.BaseModel.save(BaseModel.java:50)
    ...

It will happen if you call FlowManager.init more than one time for the same app. Be sure to only call that method one time.

It's only called once on startup. This exception has happened after using DBFlow for a while, and I don't mess with the database in any other way (it's never closed or reopened).

check if this isn't related to #238

this is most likely outdated.


I can't view the form to edit

Hi!,
I am beginner to use easyFormGenerator  and I have a problem to be your support:
After I saved FIELDS MODEL (ready to save to database one) to SQL, I can't view it for edit.
Please view images:
1: Create form

2: Save to DB

3: View for edit

Help me !!!!

Hi,
I remember this bug in a previous version.
Cold you give me more details like your dependencies version (most important are angularjs and easy-form-generator).
So that I will check it in the same situation as you.

Thank u for reply!
It here

And

p/s: I'm new so I had to download the latest version from github into last monday

I don't have this bug until now...
Which node version do you use?
node -v

It should be v6.x minimum.
As I can see you added Vietnamese.
It is not included in easyFormGenerator language files.
So you must have used:
npm install

then
npm run build-prod-stepway

by yourself?

I see different FIELDS MODEL (ready to save to database one)  and testACompleteForm.
So Why?


Next step (based on the incubator call of Aug 10 2020)

Reference: https://github.com/tc39/incubator-agendas/blob/master/notes/2020/08-10.md

Semantic decision: Iterable class instead of the current design. The class design also makes it extensible in the future.
Full-featured or minimal design: Add useful methods if possible. Learn from other languages.
API ergonomics:

Class is not easy to use (they need a new op to create).

Possible solution 1: Make it a callable class (like Array vs new Array)
Possible solution 2: A hidden class that not exposed to the global scope (`Range`), only expose the "class builder" as a plain function to new the class in the backend.

I've heard some requirement that if it is a class, the name must be capitalized (`Range` instead of `range`). I didn't like the idea but if we go through 3.i.b this is no longer a problem.

More abstraction on Range?: The idea of a "general" protocol of range that allows future consistent extension of Array Range, String Range, ...etc. Developers can even "implement"/"extends" to make their own ranges. I'm not confident with this idea and doubt if this is really useful or works in JavaScript.

I have no intention to work on this idea currently.
But an important problem to consider: If we have a String.range (or whatever) in the future, should it share a bass class with Number.range and BigInt.range?

Maybe use Cognitive Dimensions of Notation to investigate designs

I have no enough free time to work on this these days so sorry for the delay (it's nearly a whole month since the incubator call).
Generally, my next step is to migrate the current design with no observable API style changes (e.g. from Number.range to new Number.range (and I don't like that)). That means I will choose one of 3.i.a (callable class) or 3.i.b (hidden class, exposed create helper). Please leave comments on which side you'd like to see.

I remain strongly against the class approach, and the notes don't make it clear to me what the persuasive argument was (nor what future extensibility you have in mind, or why that extensibility can't be achieved with the function approach). Per the "base class" question you raise, it feels to me like extensibility is harder with a class hierarchy due to the fragile base class problem.
New classes shouldn't be callable, since class can't be callable. I agree that if it's a constructor, its name should follow the almost universal convention of being in PascalCase (ie, Range, not range).
I'd be very interested to see the results of an informed investigation into various designs.

nor what future extensibility you have in mind, or why that extensibility can't be achieved with the function approach

To extends, means helper methods. Yes, they can be added in the current design but as you can see, it is adding methods on the RangeIteratorPrototype which makes the semantics of helper methods ambiguous. (If we have a .contains(), should it consume the iterator since it is on the iterator prototype?). Another thing to mention: the current design is adding internal slots on a built-in generator.

New classes shouldn't be callable, since class can't be callable.

If so, I'll choose the 3.i.b (hidden class, exposed create helper) route to make the change (at least for now) so I can bypass the PascalCase requirement (also, at least for now, I'd be able to change if it is found harmful or not welcomed design).

A RangeIteratorPrototype is possible with either design, so I'm not clear on why extensibility there has any effect on class vs factory.
When you say "hidden class", if the constructor is reachable, it'd need to have a PascalCase name. If it's not reachable, then it seems like it's just the factory approach, where range is a function that produces an iterator (that inherits from RangeIteratorPrototype)?

A RangeIteratorPrototype is possible with either design

Yes, I have mentioned that "which makes the semantics of helper methods ambiguous. (If we have a .contains(), should it consume the iterator since it is on the iterator prototype?)."

When you say "hidden class", if the constructor is reachable, it'd need to have a PascalCase name. If it's not reachable, then it seems like it's just the factory approach

It's not the case. I'm meaning:
const r = Number.range(0, 1)
const hiddenRangeCtor = r.constructor
assert(hiddenRangeCtor.name === 'NumberRange') // or other name
assert(r instanceof hiddenRangeCtor)

Ah, I see what you mean. In either case, yes, I would assume a generic .contains() consumes the iterator, but that a Range-specific contains need not.
Thanks, your code sample matches my expectation if we were to go with the class instance approach. Presumably in that case we'd make hiddenRangeCtor also non-constructible (or not accessible via .constructor), so you couldn't do new hiddenRangeCtor?

Presumably in that case we'd make hiddenRangeCtor also non-constructible (or not accessible via .constructor), so you couldn't do new hiddenRangeCtor?

I think it is no harm to get the underlying Range class and construct it manually. My expectation is that: Number.range = (...args) => new #hiddenNumberRangeCtor#(...args) to improve ergonomics of the API.

@codehag hi! Could you give help to use Cognitive Dimensions of Notation to investigate which semantics is better? Current semantics VS #42. It seems like both Iterator and Iterables have their supporters and it's hard to going on now.

cc @Felienne
This looks interesting. I want to think about it a bit, but wanted to make sure Felienne also saw.

In the MDN Iterator example the authors aptly named the function makeRangeIterator as to highlight that the result of that operation would be an iterator and not a data structure (Iterable).
From my experience with other libraries: Number.range(0, 100, 2) suggests to return a data structure (lodash). To suggest an Iterator I would be looking at something like Iterator.numberRange(0, 100, 2) or shorter Iter.range(0, 100, 2).
While I think that having an Iterable is a perfectly fine simple step, I think there can be an argument made for a data structure: doing an .includes when having a data structure allows for a O(1) complexity (sample implementation) while doing an .includes on an Iterable would be a O(N) complexity.

Adding both Iterator.range and Number.range seems not necessary. I'm wondering if we choose the name as Iterator.range, does it release the harm in of not-reusbility?

Iterator.range kind of kills the ability to support multiple number types - ie, BigInt, or a future Decimal.

One would need to get creative about naming: Iterator.bigIntRange but there might be another place this is better suited?
Aside from this, i still think that there are enough arguments for having an Iterable over a Iterator.

@martinheidegger i don't agree with that last point; i still haven't heard any arguments that hold. There's lots of discussion about that on #42, though, so let's have that there.


Add missing IBL doc to Cesium3DTileset

I was trying to link to the imageBasedLightingFactor doc on Cesium3DTileset and realized it was missing from the doc because it didn't have a @memberof Cesium3DTileset.prototype.

Thanks for the pull request @OmarShehata!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.


feat: add xtdb support for postgres

Start to use XTDB with JDBC
First implementation has been done with Postgres. The config.example.edn is changed for simpler specs.
Refer to https://github.com/emerauth/emerauth/issues/4

hey @J0sueTM don't forget to remind me to implement base tests for this (these tests will not test anything) :(

hey @J0sueTM don't forget to remind me to implement base tests for this (these tests will not test anything) :(

Create the issues please!


Fix relative links issue in English content

relates to https://github.com/kubernetes/website/pull/13296

/cc @DanyC97 @zacharysarah

/lgtm
thank you @chenrui333 , great work

@chenrui333 This looks great. Thank you for the fixes! 🌟
/approve

Roll tide?
/this-is-fine


Fix kusto resource uri for auth token

This PR fixes #
Fixes the Kusto resource uri for generating auth token
Also, fixes the KQL-M support in Kusto extension

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 41.334%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
26447

Relevant Lines:
58011

💛  - Coveralls


Fix orders of yaml of custom-resource-definitions

The orders of kind and metadata were inconsistent, and that made the
doc unreadable.
This fixes the orders in consistent way.
ref: https://github.com/kubernetes/website/issues/13862

/lgtm
/approve


Test structure to JSON parsing added

Implementation is located in TestRunnerJSON.jl file and is included in package module
The tests are located in TestRunnerJSON.tests.jl file which is included in runtests.jl
The logic behind is quite simple: the test tree nodes are first converted to dictionaries and then parsed by external library (JSON.jl ,https://github.com/JuliaLang/JSON.jl ).

Great, I will merge it in a moment

@mateuszkaleta, I did first merge my branch and there are conflicts now :( Can you refresh your branch with master? I believe that only important change is that FactsNode was renamed to FactsCollectionNode.

Everything should be fine now :)


[JENKINS-52824] Allow to use GoogleMetadataCredentials

https://issues.jenkins-ci.org/browse/JENKINS-52824
Google OAuth Plugin provides two kinds of credentials:

Private Key Credentials

http://javadoc.jenkins.io/plugin/google-oauth-plugin/com/google/jenkins/plugins/credentials/oauth/GoogleRobotPrivateKeyCredentials.html

Metadata Credentials

http://javadoc.jenkins.io/plugin/google-oauth-plugin/com/google/jenkins/plugins/credentials/oauth/GoogleRobotMetadataCredentials.html

Though google-cloudbuild-plugins allows to select metadata credentials in the configuration page, it actually fails with "Could not retrieve credentials". Google-cloudbuild-plugins accepts only GoogleRobotPrivateKeyCredentials now.
I want to use metadata credentials.
Those two credentials have the common ancestor GoogleRobotCredentials, and we can easily support both of them by accepting GoogleRobotCredentials instead of GoogleRobotPrivateKeyCredentials.

Metadata Credentials are listed in GUI for the code here in google-oauth-plugins: https://github.com/jenkinsci/google-oauth-plugin/blob/google-oauth-plugin-0.5/src/main/resources/lib/auth/credentials.jelly#L39

I've already signed the CLA.
How can I show that?

Hi! I've verified that you have signed the CLA. The change looks good and I've deployed a Jenkins instance to GCE and verified that I can use metadata credentials.
Thanks for contributing!

Thank you!


Support for Java 8?

I was trying to get started with this, running windows 8.1, scala 2.11.8, when I run jupyter-notebook and try to start a scala kernel I get this:
[I 15:44:16.868 NotebookApp] Creating new notebook in
[W 15:44:17.457 NotebookApp] 404 GET /nbextensions/widgets/notebook/js/extension.js?v=20161129154408 (::1) 20.00ms referer=http://localhost:8888/notebooks/Untitled.ipynb?kernel_name=scala
[I 15:44:17.691 NotebookApp] Kernel started: 62265cc4-be99-494e-9cdd-2ae4c7540136
Error: Registry key 'Software\JavaSoft\Java Runtime Environment'\CurrentVersion'
has value '1.8', but '1.7' is required.
Error: could not find java.dll
Error: Could not find Java SE Runtime Environment.
[I 15:44:20.676 NotebookApp] KernelRestarter: restarting kernel (1/5)
Error: Registry key 'Software\JavaSoft\Java Runtime Environment'\CurrentVersion'
has value '1.8', but '1.7' is required.
Error: could not find java.dll
Error: Could not find Java SE Runtime Environment.
[I 15:44:23.693 NotebookApp] KernelRestarter: restarting kernel (2/5)
Error: Registry key 'Software\JavaSoft\Java Runtime Environment'\CurrentVersion'
has value '1.8', but '1.7' is required.
Error: could not find java.dll
Error: Could not find Java SE Runtime Environment.
[I 15:44:26.717 NotebookApp] KernelRestarter: restarting kernel (3/5)
Error: Registry key 'Software\JavaSoft\Java Runtime Environment'\CurrentVersion'
has value '1.8', but '1.7' is required.
Error: could not find java.dll
Error: Could not find Java SE Runtime Environment.
[W 15:44:27.724 NotebookApp] Timeout waiting for kernel_info reply from 62265cc4-be99-494e-9cdd-2ae4c7540136
[I 15:44:29.730 NotebookApp] KernelRestarter: restarting kernel (4/5)
WARNING:root:kernel 62265cc4-be99-494e-9cdd-2ae4c7540136 restarted
Error: Registry key 'Software\JavaSoft\Java Runtime Environment'\CurrentVersion'
has value '1.8', but '1.7' is required.
Error: could not find java.dll
Error: Could not find Java SE Runtime Environment.
[W 15:44:32.776 NotebookApp] KernelRestarter: restart failed
[W 15:44:32.780 NotebookApp] Kernel 62265cc4-be99-494e-9cdd-2ae4c7540136 died, removing from map.
ERROR:root:kernel 62265cc4-be99-494e-9cdd-2ae4c7540136 restarted failed!
[W 15:44:37.994 NotebookApp] Kernel deleted before session
[W 15:44:37.996 NotebookApp] 410 DELETE /api/sessions/56cddc4f-5655-45c0-8923-43d17e6ff627 (::1) 4.00ms referer=http://localhost:8888/tree

Any thoughts or work arounds?

First time I'm seeing this kind of error. I actually only tested the current version of the kernel with Java 8 (not 7), so I would except this to be fine.

Any thoughts or ideias on how I can proceed to debug this?

Current master works fine with Java 8, like all the releases under the "almond" name (not sure about Windows, but that should be fixed soon).