Does Globalize.formatMessage() support passing a variable as path parameter?

The following code works well.
const Globalize = require('globalize'); Globalize.formatMessage('my.path');
But the following code did not work. That is to say Globalize.formatMessage() only access a string as parameter,if passing a variable as parameter, it doesn't work. I got error "ReferenceError: path is not defined"
Is it the design? if yes, how can I pass a variable to Globalize.formatMessage()?
const Globalize = require('globalize'); const path = 'my.path'; Globalize.formatMessage(path);

Any luck with this? Having the same issue.

I'm facing the same issue. It happend during build. I'm using globalize-webpack to build.
Please take a look on below log.
\node_modules\globalize-webpack-plugin\GlobalizeCompilerHelper.js:77
        throw e;
        ^

ReferenceError: variable is not defined
    at eval (eval at extractor (\node_modules\globalize-compiler\lib\extract.js:65:9), <anonymous>:16:3)
    at \node_modules\globalize-compiler\lib\compile-extracts.js:70:23
    at Array.reduce (<anonymous>)
    at Object.compileExtracts (\node_modules\globalize-compiler\lib\compile-extracts.js:69:49)
    at GlobalizeCompilerHelper.compile (\node_modules\globalize-webpack-plugin\GlobalizeCompilerHelper.js:68:35)
    at chunk.mapModules (\node_modules\globalize-webpack-plugin\ProductionModePlugin.js:251:53)
    at Function.from (native)
    at Chunk.mapModules (\node_modules\webpack\lib\Chunk.js:163:16)
    at compilation.chunks.filter.forEach (\node_modules\globalize-webpack-plugin\ProductionModePlugin.js:246:38)
    at Array.forEach (<anonymous>)
    at Compilation.compilation.plugin (\node_modules\globalize-webpack-plugin\ProductionModePlugin.js:232:12)
    at Compilation.applyPlugins1 (\node_modules\tapable\lib\Tapable.js:75:14)
    at sealPart2 (\node_modules\webpack\lib\Compilation.js:626:9)
    at next (\node_modules\tapable\lib\Tapable.js:202:11)
    at \node_modules\extract-text-webpack-plugin\dist\index.js:244:13
    at \node_modules\async\dist\async.js:473:16


Updated the link to mozilla.org

They changed the header in the article, so the hash part wasn't correct anymore. Although I just noticed that if you open the link, it doesn't scroll to the header anyway, so maybe this change is useless.

I accidentally created a PR in my own repo, when I meant to create a PR in the upstream repo. So I'll close this one.


Documentation improvement

Hi everyone :)
In the description of the MainLoop method, it mentions that the "quit" command should be sent when we are done. I think it would be beneficial to include this information in the README.md. If it was there, it would save me a lot of time, because I had a lot of issues with engine not working when used with react-navigation. But, when "quit" command is sent, everything works more than perfectly.
Thanks!
Dawid

Hi ! Did you try rather to call shutDownStockfish, as in the snippet in the README ?
Because this call send quit to the engine.


Slides doc demo - Images not being loaded

Ionic version:  (check one with "x")
[ ] 1.x
[ ] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
The Loading the Slides API doc demo, the images are not loaded, throwing error 404 in console.
Expected behavior:
The images in the Slides API doc demo should be loaded correctly.
Steps to reproduce:
Open the Slides API doc page on a desktop to show the demo Phone.
(Page is http://ionicframework.com/docs/api/components/slides/Slides/)
Result: The images inside the slides are not loaded.
Related code:
NA
Other information:
Seems that the images were moved to be in the ./assets directory.
I previously submitted Pull request (#11314) with a quick correction, by modifying the Images src.
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
NA

This issue was moved to driftyco/ionic-site#1066


is valid date

add check to see if object is a js date object
fixex #1011

Coverage decreased (-0.04%) to 77.317% when pulling 525ade3c03e71133532be459ee23784ca9a6c04a on native-finance:bugfix/issue-1011-date-in-cell into e8aa5135a5f0f24d58cb5415e30eaa7293ff86e9 on gregnb:master.

I don't think we'll need this anymore, as I've changed to a console error in cases where an object is being used. Can you confirm?
Also, when the ability to use objects is prevented (to fix other issues), this will be a wontfix.


ci: relayer container build

Towards #465. Here we define a container image that wraps the upstream cosmos/relayer image with the custom scripting for bootstrapping clients on the Penumbra testnet and preview networks. No other chain configs are part of this container image as of yet. The container image will be publicly available as ghcr.io/penumbra-zone/relayer. It isn't yet deployed to the cluster: that'll come next.

The build action for the new relayer container was initially failing. Turns out there was a conflicting package with the same name in our GH, due to our fork of the relayer repository, and its automatic use of the repo name in its package creation: https://github.com/penumbra-zone/relayer/blob/9c7e897777d5d7843dfad2ba169cedff2eff775a/.github/workflows/docker-publish.yaml#L12
To resolve, I downgraded that repo's privileges on the GH package to "read", and elevated this repo's privs to "admin." On a subsequent rerun, the build worked, and I'm able to pull it locally now:
❯ docker pull ghcr.io/penumbra-zone/relayer:main
Emulate Docker CLI using podman. Create /etc/containers/nodocker to quiet msg.
Trying to pull ghcr.io/penumbra-zone/relayer:main...
Getting image source signatures
Copying blob bd9c25980e10 done
Copying blob 4ed5f2fb37e2 skipped: already exists
Copying blob 86b39e51d0be done
Copying blob f97a99d8b7c1 done
Copying blob bd355b9fa562 done
Copying blob ab56602a6b2b done
Copying blob 4f4fb700ef54 skipped: already exists
Copying blob 48ec50bfcec3 done
Copying config 79257117ba done
Writing manifest to image destination
Storing signatures
79257117ba783f5819e51dd771ad623356add186e31b0914f67ce7d76abd8f45


add font8x8 rbg565 support for cfb on rt1050

enable customer font test in font 8x8
enable cfb, cfb shell with font 8x8
Signed-off-by: Hake Huang<EMAIL_ADDRESS>

@jfischer-phytec-iot DroidSansMono is ugly in 16 bit panel. as the OFL font is not allow, I will try to find Apache license font.

@hakehuang

DroidSansMono is ugly in 16 bit panel.

Can you please explain what is ugly? How ugliness in this case depends on panel type or pixel format?

as the OFL font is not allow, I will try to find Apache license font.

I do not mean it is not allowed, you have to find out whether OFL and derived work are compatible with Apache License.

@jfischer-phytec-iot  I try to convert the DroidSansMono font to 8x8 format, and it looks not good, for example for '2' the font matrix is like something '=', I find another font with Apache license, please check

See comments and also address codeowner and git lint issue

updated

@hakehuang in general the PR looks good to me can you fix the remaining Shippable failure

not addressed

@jfischer-phytec-iot Can you identify what was not addressed?  I'd like to see this merged, so I can rebase #17541 if necessary and get that merged too.
The close and reopen about to happen is because the shippable failure should be resolved by ff0b76ea4ac7bc24f2e016a872f501f0e87e1cc9 which was merged directly to master.

reopening to see if shippable passes.

Please also add CONFIG_CHARACTER_FRAMEBUFFER_DISPLAY_DEV_NAME="SDL_DISPLAY" to samples/display/cfb/boards/native_posix_64.conf

done. Thanks for letting me know the new board

@hakehuang Can you verify that it build and works?

@hakehuang Can you verify that it build and works?

@jfischer-phytec-iot

sample cfb is ok on frdm_k64f and mimxrt1050_evk, but fails on real_board, which seems not related to my change.

sample cfb_customer_font works for mimxrt1050_evk, but fails on real_board with the same reason

sample cfb_shell works for frdmk64f and mimxrt1050_evk, but fails on real_board with the same reason

please see below build log
logs.txt

@hakehuang

* sample cfb is ok on frdm_k64f and mimxrt1050_evk, but fails on real_board, which seems not related to my change.

Latest master works fine on reel board, just verified.

@hakehuang

* sample cfb is ok on frdm_k64f and mimxrt1050_evk, but fails on real_board, which seems not related to my change.

Latest master works fine on reel board, just verified. You probably have to call west update

@jfischer-phytec-iot thanks a lot. it works at my side also.

@jfischer-phytec-iot do you have time to review this pull request? I have updated all according to your change requests

samples/display/cfb_custom_font works fine on the reel_board, but doesn't seem to work on mimxrt1050_evk:

samples/display/cfb_custom_font works fine on the reel_board, but doesn't seem to work on mimxrt1050_evk:

Hi @MaureenHelm ,
this is because the font that original used for customer sample is defines as below
generate_cfb_font_for_target(app fonts/dice.png ${gen_dir}/cfb_font_dice.h 8 8 --first 49 --last 54)
as I set the default font support to 8x8 so it is very hard to see, take below as an example
static const u8_t cfb_font_custom_88[6][8] = {
/* 49 (1) */
{
0x00,
0xc0,
0xf0,
0xf8,
0xfc,
0xfc,
0xfe,
0xfe,
},
which is
00000000
11000000
11110000
11111000
11111100
11111100
11111110
11111110
looks like the convert script can only translate the image without resize, so use to create an 8x8 dice by myself, but this can not pass the review, so I keep the dice.png for now.

Need to get CHARACTER_FRAMEBUFFER_DISPLAY_DEV_NAME from DT and not Kconfig.

@galak if you have no objection, I am going to resolve your change request as is.

Hello guys!
What is the status of this pull-request? Will it be marged? I have some extension for CFB which is based on those changes.

@jskarzynski we are in the middle of a code freeze for 2.1 so I would say at earliest next year.

Probably it would be better to move f80d951 and 1647d15 in special PR as we have other RGB565 display drivers in the tree.

Probably it would be better to move f80d951 and 1647d15 in special PR as we have other RGB565 display drivers in the tree.

@jfischer-phytec-iot  not sure I unstand your request, do you mean split this pr into 2? or drop the #6cb778ef4202f24ece0ba4dbc745133093f23ebb and #e9c1bfbe287cb0aaf2d013540497e511b9faefa7

@hakehuang what is the status of this PR? if it is not relevant anymore, would you be so kind as to close it?

@hakehuang what is the status of this PR? if it is not relevant anymore, would you be so kind as to close it?

@aescolar , yes, I have another PR


Dashboard is appending the path from "launchUrl" on launch profile to endpoints that weren't added from the launch profile

If I add a custom HTTP endpoint to a project resource in addition to the default endpoints discovered from the launch profile, and the launch profile has a path set on the "launchUrl" property, the dashboard includes that path on the hyperlink rendered for the custom endpoints. The path from the launch profile should only be appended to the endpoint addresses from the launch profile.
var apiService = builder.AddProject<Projects.HealthChecksUI_ApiService>("apiservice")
    .WithHttpEndpoint(name: "healthchecks");

This happens in the app model currently. We don't know where endpoints come from today.
cc @BrennanConroy

https://github.com/dotnet/aspire/blob/525c59ad9d58de54c71071e248b060061dfecd56/src/Aspire.Hosting/Dashboard/DcpDataSource.cs#L446-L468
I can take a look at fixing this.


make AtomicAggregate can_be_optional false as stated in RFC4271

see https://datatracker.ietf.org/doc/html/rfc4271#section-5.1.6

ATOMIC_AGGREGATE is a well-known discretionary attribute.
because it is well-known the optional flag is set to 0 even though the attribute is not mandatory

see https://datatracker.ietf.org/doc/html/rfc4271#section-5 for the difference between mandatory/discretionary and well-known/optional

Thank you @mxyns  for spotting this


refactor collect-files to be a little more simple

...a bit more "functional"

Coverage decreased (-0.006%) to 94.061% when pulling ee91e1215044ab26b4630b18d8b1218389608fd0 on boneskull/refactor/collect-files into 185cada8149c4dcac1896769c2b7732e9dbe971f on master.


yarn test:unit --watch outputs a configuration error while yarn test:unit & yarn test:unit --watchAll don't

Version
3.0.1
Reproduction link
https://github.com/Hebilicious/jest-watchbug
Node and OS info
Node: 10.5.0 / yarn 1.9.4 / Ubuntu 18.04.1 LTS
Steps to reproduce
You might have to modify App.vue if you get this message "No tests found related to files changed since last commit."
yarn
yarn test:unit
yarn test:unit --watch

What is expected?
Jest --watch mode should not issue errors if the test suite passes.
What is actually happening?
The output is the following error :
Configuration error:

Could not locate module @/assets/${this.logo} mapped as:
/home/hebilicious/jest-watchbug/src/assets/${this.logo}

Please check your configuration for these entries:
{
  "moduleNameMapper": {
    "/^@\/(.*)$/": "/home/hebilicious/Code/jest-watchbug/src/$1"
  },
  "resolver": null
}

yarn test:unit --watchAll works for some reasons, so this is not urgent... still I do not know if the 'bug' comes from vue-cli, vue-jest, babel-jest, or jest itself.

+1

+1, same problem --watch fails, but --watchAll works

You can workaround it with changing the regexp in jest config to
moduleNameMapper: {     '^@/([A-z0-9/.]*)$': '<rootDir>/src/$1'   },

+1

Anybody has found a solution?
Thanks!

Actual in 2021, work only with --watchAll...

Actual in 2022, work only with --watchAll...


make GraphicsOutput.query_mode(...) public

This Pull Request makes the method query_mode of GraphicsOutput public, likely due to a typo as the documentation is there.

Thanks!


Bash !! and other commands don't work

The screenshot in the README claims that when you type !, it will show an autocomplete. But for some reason not only does this not show up, the !! alias also simply doesn't work.

Seen on Ubuntu 16.04 64-bit

Thanks for reporting bugs, @Leva7! It used to work but then somehow broke along the way. I'll try to fix this soon.

It seems like I removed history expansion at some point. So we'll need to add support for it from scratch.

Closing in favor of https://github.com/railsware/upterm/issues/1009


Missing overflow-hidden in simple article link

Describe the bug
The image corner goes out of bounds in simple article links:

Seems fixed adding  overflow-hidden on line 5 of simple.html:
{{ $articleClasses = delimit (slice $articleClasses "border border-neutral-200 dark:border-neutral-700 border-2 rounded-md backdrop-blur overflow-hidden") " " }}

Thanks @JVimes merging the fix will be in next release


[core-http] Require TLS 1.2 or later in HTTPS connections

This change follows on from @southpolesteve's PR #6761 to configure all core-http clients to use TLS 1.2 at a minimum for all HTTPS connections.  No tests have been added (yet) because we don't currently have a reliable way to test proxy functionality.
@southpolesteve do you have a proxy environment (or recommended configuration) I could use to test this and ensure that TLS 1.2 is actually being used?

I don't have a good test env for this. I ran our tests against a live endpoint just to verify they worked as expected

I think this change is fine, however I want to be sure we should actually do it. As far as I'm aware, the TLS 1.2 requirement is a requirement for services, not so much client libraries. As long as clients negotiate the highest available TLS version by default, and as long as services offer TLS >= 1.2, we should be meeting this guideline.
I think unless we hear that our libraries should prevent users from talking to services running TLS 1.1, I am not sure this change is worth taking.
/cc @xirzec (security czar), @joshfree

I like the change itself, but I also agree it may not be necessary.

Everything I'm hearing suggests this isn't necessary. We'll negotiate the highest available version, and services should offer TLS 1.2. Going to close this for now. @daviwil thanks for proving this out! 😀


Design QA - Sign Up

Styles are not accurate:

Betting doesn't use border on modals
Sign Up / Sign in button style is incorrect.
Size is different.
Login created icon color incorrect.
Missing space:

Steps

Please double check steps, cause we don't use the dots approach on Betting:

Buttons

Text size is incorrect:

this is getting reworked closing this one...will need redesign and new ticket later


Is the Pandas dependency necessary for all engines?

Super cool work - very exciting project between this and Ibis I'm so excited about the future of composable, flexible systems where syntax is decoupled from execution.
I noticed in your setup.py that pandas is a required dependency for every back-end. Thinking out loud - I get why you need this to match the Spark API 1:1.
It's no a massive footprint these days, I think the risk is more for older brownfield projects that have complicated existing dependencies. Part of the appeal for this project is that existing Spark codebases can migrate to say duckdb without any pain, this may crop up over time.
pip-compile on pandas with no extras returns the following, the footprint doesn't look super risky, but conflicts may crop up:
❯ uv pip compile requirements.txt
Resolved 6 packages in 9ms
# This file was autogenerated by uv via the following command:
#    uv pip compile requirements.txt
numpy==1.26.4
    # via pandas
pandas==2.2.2
python-dateutil==2.9.0.post0
    # via pandas
pytz==2024.1
    # via pandas
six==1.16.0
    # via python-dateutil
tzdata==2024.1
    # via pandas

Yeah only some operations actually require pandas. So I could localize those imports and then tell the user to install pandas to use those functions. Obviously that introduces some friction though. So it is a tradeoff here between the gain of minimizing the required dependencies and lowering friction for users.

Yeah it's not something that you need to worry about today, but it would be great later down the line. Thanks again for the fantastic work I'm already 90% of the way done building a Kedro dataset for it sqlframe 💪

In case you're interested here is my Kedro implementation
https://github.com/kedro-org/kedro-plugins/pull/694

Very cool thanks for sharing! 🙌


Fix definition of g in very first example in docs

I'm trying to get my head around Parsl, but the first example in the documentation already lost me.  I believe the example was broken by #3428.  CC: @WardLT
Description
g was defined as a single-argument function, but called with two.
Changed Behaviour
First example in the documentation now actually works.  With this change, the example is now consistent with the README (also changed in #3428): https://github.com/Parsl/parsl/blob/2fc20d8da76198db13145bd4341d8ad9db1c6a37/README.rst#L24-L26
Fixes
N/A
Type of change
Choose which options apply, and delete the ones which do not apply.

Update to human readable text: Documentation/error messages/comments

looks good - thanks!

Unrelated to this PR, I wonder if this example should give more visual feedback that the app ran successfully, without the user having to check the exit code.  As a first example, running some code which seemingly does nothing is a bit underwhelming.

Thanks for this! What a glaring mistake on the first page! 🤦🏼
Would print statement or something fix the problem?

Would print statement or something fix the problem about feedback?

Yeah, probably.


Cannot install the module

Foundry Version 10 - Build 291
Every time I try to install the module, I get the following error:
setup.js:292 Error: Unable to load valid module manifest data from "https://raw.githubusercontent.com/svenwerlen/moulinette-imagesearch/master/module.json"
The requested manifest at "https://raw.githubusercontent.com/svenwerlen/moulinette-imagesearch/master/module.json" did not provide module manifest data.
    at Module.installPackage (file:///home/ubuntu/foundry/resources/app/dist/packages/views.mjs:1:1634)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async SetupView.handlePost (file:///home/ubuntu/foundry/resources/app/dist/server/views/setup.mjs:1:1980)

Hosting on Oracle Cloud.

Sorry for my late answer. It might have been one specific version which didn't have a working JSON file.
I wasn't able to clearly identify the issue but since nobody reported this issue, I assume that it's fixed.


Adding Notifications for New Chat Messages When Chat is Closed

Currently, when the chat is closed, there is no way for users to know if there are new messages without opening the chat. To improve the user experience, it would be helpful to add notifications or indicators that there are new messages in the chat when it is closed.
Expected Result:
When there are new messages in the chat and the chat window is closed, a notification or indicator should be displayed to let users know that there are new messages.

This ticket can't be implemented until we fix the following bug: https://github.com/montevideo-tech/hybrid-meetup-platform/issues/252


jmap no -heap option

I would like to use jmap to create a heap summary (using jmap -heap). This is a standard utility that comes with the jdk and this is a standard feature. However, when I use the alpine:3.9 image and add the jdk (using apk add openjdk8), the version of jmap doesn't support the -heap option.
I originally posted this question here https://github.com/docker-library/openjdk/issues/286 but I think this is the correct place to raise the issue.
Any idea why the -heap option is not supported on alpine openjdk?
Thanks,
Allen

https://github.com/docker-library/openjdk/issues/286#issuecomment-471867368


run fast-gateway on https

Is it possible to run fast-gateway on https? I have an Angular 12 frontend with ssl certificate as well as microservices running as https but i get issues when an https request is sent from the frontend to the api gateway. How do i go about this?
My frontend is setup as:
 "ssl": true,
 "sslKey": "../../servers/certificates/key.key",
  "sslCert": "../../servers/certificates/cert.crt"

My microservices are setup as:
  if (NODE_ENV === 'prod') {
    const options = {
      key: fs.readFileSync('../certificates/key.key'),
      cert: fs.readFileSync('../certificates/cert.crt')
    };

    https.createServer(options, app).listen(config.port, (error) => {
      if (error) {
        return console.log(chalk.red(error));
      }
      return console.log(
        chalk.green(`Running ${config.api_title} on ${config.hostname}:${config.port}`)
      );
    });
  }

Hi @codezilla91 , thanks for reaching out. fast-gateway uses https://www.npmjs.com/package/fast-proxy-lite by default to connect with origin servers using HTTP or HTTPS. The proxy library will automatically switch to https Agent when the target starts with "https:// ...".
In case you need to support self-signed certs, you can use rejectUnauthorized = false in proxyConfig of your route. Please see: https://fgw.21no.de/#/?id=configuration-options-explained
Best Regards


Many remote materials don't allow being used in a iframe

This is an old problem which stems from some unfortunate the security design of the iframe system.   A security threat (a form of click fishing by a malicious embedding site) was fixed by recommending that web publishers is iframe HTTP headers to block their material being used by different origins.   At a stroke, this made the web a whole lot less useful and compostable.
Sites which do work include:

Solid servers
Google docs
Medium

Sites which do not include:

this github issue web page
Altassian  Jira tools
eff.org

One solution, in Chrome, is to use <webview> which seems specifically designed to solve this problem. See  https://developer.chrome.com/apps/tags/webview
A longer term solution is to push for changes in the browsers ...

Additionally, both Firefox and Safari are now w


Applications

Thank you for sharing.
Could you please tell me, if we can use it for anti-spoofing detection on a mobile device?

Thank you for sharing.
Could you please tell me, if we can use it for anti-spoofing detection on a mobile device?

Unknown


Fix a couple bugs.

When no adapter is configured for a particular call to Check, Mixer now returns a
ValidUseCount of 10000 and a ValidDuration of 1 minute. This allows the proxy to cache
in this case.

We were losing error during instance creation. They were being overwritten in some situations
by later error codes. They are now plumbed through the whole way.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
29bb0b6ab808d582bb71dccbfbe301a55c48f6ab
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

mixer/OWNERS [geeknoid,mandarjog]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
29bb0b6ab808d582bb71dccbfbe301a55c48f6ab
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
f86370e3c53806328c204b2eb665aa81573c099c
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geeknoid: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
f86370e3c53806328c204b2eb665aa81573c099c
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e.sh
f86370e3c53806328c204b2eb665aa81573c099c
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm


Cannot find plugin 'liblto_plugin.so'

I'm trying out the make of FooProject, and I'm not sure where this bug report belongs to.
This is on a Raspberry Pi/Raspbian.
The last few lines of the error are:
/usr/bin/avr-gcc-ar: Cannot find plugin 'liblto_plugin.so'
/home/pi/w/ar/proj/MyArduinoProject/Arduino-Makefile/Arduino.mk:1476: recipe for target '/home/pi/w/ar/proj/MyArduinoProject/bin/FooProject/uno/libcore.a' failed
make: *** [/home/pi/w/ar/proj/MyArduinoProject/bin/FooProject/uno/libcore.a] Error 1

I found someone with a similar error at https://www.raspberrypi.org/forums/viewtopic.php?f=33&t=68789, which references https://github.com/raspberrypi/tools/issues/12.  The bug report on that latter link indicates that the bug (files were in the wrong directory) has been fixed.
I see that the code here hasn't been updated in a few years, so I'm thinking something along the lines of "The RPI guys fixed this in 2014, and the files on the Bare-Arduino-Project were last updated around then too, so maybe there was an update that needs to happen here?"
So if you think that this bug should be reported back over at the RPI guys, I'd gladly do this.  I'm just trying to figure out where this bug report should go.

Heh, well, it wasn't THIS that needed to be updated, but rather my setup.  Things work as advertised now :)


Add log level support

We've found that recordError is a useful replacement for custom client error logging. However to completely replace what we have now we'd need support for other log levels, e.g. info, warn.
This could be provided by a recordLog or recordEvent command that supports arbitrary logging. Is this something that would be considered in scope for the rum client?

Hi @Anntoin thanks for raising this (and sorry taking so long to respond)! I agree these are important use cases.
For both recordLog and recordEvent, the CloudWatch RUM service must first support these application-specific event types. Currently, it only supports a fixed set of events.
For example, it is currently possible to use the CloudWatch RUM web client (by creating a plugin) or the CloudWatch RUM SDK to send arbitrary events to CloudWatch RUM, however only those events which conform to an accepted schema will be ingested (the rest will be dropped).
We will update this thread when CloudWatch RUM has added support, but I can't provide an ETA.

I am going to see if it is possible to add a recordEvent method to go according to the RUM schema here: https://docs.aws.amazon.com/cloudwatchrum/latest/APIReference/API_PutRumEvents.html

@Anntoin see https://github.com/aws-observability/aws-rum-web/pull/185 for possible solution :-)

That's awesome 🎉 thanks for following up!
This should cover our use case. I'm on vacation at the moment but looking
forward to checking it out when I get back.
This makes RUM a one-stop shop for all our client-side visibility needs!
On Tue 26 Jul 2022, 19:53 Naftali Lubin, @.***> wrote:

@Anntoin https://github.com/Anntoin see #185
https://github.com/aws-observability/aws-rum-web/pull/185 for possible
solution :-)
—
Reply to this email directly, view it on GitHub
https://github.com/aws-observability/aws-rum-web/issues/139#issuecomment-1195860574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZC7QZCV2QBN4EO22RSBPLVWAXZPANCNFSM5USNF4LA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fixes error in credentials example

Thank you for this. You would need to run the make git to make it generate the html but I will be looking at it.


Fix | Fix Roslyn Analyzer warning.

This PR Fixes Roslyn Analyzer warning on SNIHandle.cs.

Hi @arellegue, this should be for release/4.0


[api]Download shapefile template (MRXN23-164)

Downloading shapefile template
New endpoint for downloading a template shapefile for the project and refactor of the cache table.
New endpoint within api projects module to download shapefile template.
Refactoring of the entity and repository of cache table (cost surfce in libs) - to a more abstract Artifact cache.
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets

Checklist before submitting

[ ] Meaningful commits and code rebased on develop.
[ ] If this PR adds feature that should be tested for regressions when
deploying to staging/production, please add brief testing instructions
to the deploy checklist (docs/deployment-checklist.md)
[ ] Update CHANGELOG file

@yulia-bel let's merge? your changes after our joint review yesterday are ok - I don't think we should do anything else here, or are you thinking to differentiate between the two kinds of artifacts?

ok, maybe if not differentiating between the two kinds of artifacts, let's add a comment about this (maybe in the entity?), and then merge. If you are going to actually use the two kinds of artifacts, then that's ok too. As long as it ends up being a quick change 😏


Compatibility with NeoVim

I'm using tern_for_vim with NeoVim.
When I try to save a coffeescript file I get the following error:
Error detected while processing function provider#python#Call:
line    1:
NvimError('Vim:E121: Undefined variable: b:ternBufferSentAt',)

You need to talk about this issue developers of neovim.

I agree with @myshov . I'm already way out of my comfort zone testing on regular Vim -- I don't volunteer to also start debugging issues in NeoVim.


fix(docs): fixed naming in Accordion module

[x] Bug fix
[x] There is an open issue which this change addresses. Fixed issue #2420
[x] I have read the CONTRIBUTING document.
[x] My commits follow the Git Commit Guidelines
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.

[x] I have updated the documentation accordingly.

[x] All new and existing tests passed.

resolve #2420

Great thanks!


Apply the tag build plugin to the root project

So we do not need to use -b to run a separate .gradle file and can
re-use the daemon.
When this is merged, we can update the CI configuration and then remove gradle/buildTagging.gradle and gradle/settings.gradle.

When we update the CI configuration, does this need to be on release too?
otherwise LGTM

Merged into release.


refactor: Remove lifetime from Context, ResponseFuture, InterceptorFuture

This PR will fix #403
The benchmark seems can't reflect the actual improvement. (I guess the test case(64K) is not suitable to measure the different between an Arc::new)
Before:
download 64K: isahc     time:   [201.80 ms 204.40 ms 207.00 ms]

After
download 64K: isahc     time:   [200.32 ms 203.57 ms 206.90 ms]

Hi, @sagebind, can you take a look into this PR? Thanks!


New rule: no bitwise operators on non integers

I came across an error in my code where I typed 'string' | b instead of 'string' || b.
These bitwise operators only make sense on integers and a rule to catch this would have saved me a bit of time!
What are thoughts around a rule that disallows any string or object literal symbols in these scenarios?

@feross Your thoughts on this?

I've created a PR for this here: https://github.com/standard/eslint-config-standard/pull/119

Reposting the comment I wrote on the PR for this issue:
@tom-sherman I appreciate the idea behind this PR, but I don't think we should disallow bitwise operators when used with numbers or in the case that @LinusU mentioned:
fs.access(path.join(TMP, name), fs.R_OK | fs.W_OK, function (err) {

If you can add an exception to ESLint that scopes this rule sufficiently down to the cases we actually want to target, then I'm happy to consider this change!
In the meantime, I'm going to close this issue since we can't enable this rule without an upstream change from ESLint. Please open a new issue when this rule is ready to use.


[Question] Is there any risk by using the same address for toadress and feeaddress in omni_funded_send/omni_funded_sendall API?

Is there any risk by using the same address for toadress and feeaddress in omni_funded_send/omni_funded_sendall API?
Thanks.

Hi, there is no risk.


Full Code Overhaul

Fully optimized whole code, increased speed for both inference and training.
Features:

Completely rewrote the code for infer-web.py to be more optimized.
Added minor optimizations in my_utils.py.
Due to all that, inferencing works up to 25% faster, training works up to 20-30% faster.
The launch speed is increased due to lazy importing heavy modules and libraries.
Revoked from using SQL databases back to CSV data storage for less trouble on colab.

This branch was not rebased/kept up to date with mainline. We made a new branch to solve this.


using home assistant temperature sensor.

I am trying to figure out how to use a home assistant temperature sensor entity. Which file should that be placed in?

The template YAML file has this line:
temperature_sensor_entity_id: sensor.my_sensor # XXX

Here you should put the entity id of the Home Assistant temperature sensor you want the controller to use.
If you want to use a template sensor, you can put those in Home Assistant's configuration file. I have mine in configuration.yaml.

Okay that is what I have. For some reason it is reading 95 F when the temperature is 73.89. Could this be an issue of the temp being in F instead of C?

Okay that is what I have. For some reason it is reading 95 F when the temperature is 73.89. Could this be an issue of the temp being in F instead of C?

Oh right, Fahrenheit isn't well supported atm. See also issue #27

I made some changes to better support Fahrenheit. You can set the Fahrenheit option to "true" in the template yaml file with the latest version. Please let me know if this works better now.

Closing because the new Fahrenheit mode fixes this.


File Not Found Using targetSdkVersion 24 (Android Nougat)

Since changing my app's targetSdkVersion to > 23, I'm not able to transcode anymore. I've modified my code to use FileProvider, however when I attempt to transcode, I receive the exception:
file:/storage/emulated/0/DCIM/Camera/VIDEO_20170523_080806775651908.mp4: open failed: ENOENT (No such file or directory)
Before updating the targetSdkVersion, I was able to transcode properly, but when I change SDK and update the code using FileProvider, I can't transcode anymore. Is there any plan in the near future for this library to target SDK 24 and above?

From sdk version 23 it is required for developers to check some permissions at runtime, rather than just declaring them in the manifest.
You can have a look at this document (https://developer.android.com/training/permissions/requesting.html) to get a sense of how to do this. You'll need to request Manifest.permission.WRITE_EXTERNAL_STORAGE, and Manifest.permission.READ_EXTERNAL_STORAGE to be able to write to and read from the SD card.

Yes I have the required runtime permission checks for reading and writing external storage. The code works perfect when I have the SDK version set to 23, but when I go to 24 or 25 that's when the issue occurs. SDK 23 does require the runtime permission checks and works, just later SDKs don't work.

Awesome, thanks for sharing your solution!


sdist command packages the setup.py wrapper

For packages that use insert_setuptools, starforge sdist causes the sdist to contain the setup.py wrapper rather than the distribution's setup.py. This resulted in some invalid tarballs on wheels.galaxyproject.org (see #180).
Rather than mess with files, we might be able to just:
$ python -c 'import setuptools; __file__ = "setup.py"; exec(compile(open("setup.py").read(), "setup.py", "exec"))' bdist_wheel

I tested this by hand with the upstream Markdown 2.6.3 sdist and it works. More complex setup scripts might have issues.
Once working, there would probably be no harm in running all sdist and wheel builds this way by default. This would be easily done by changing the implicit default of insert_setuptools from false to true, and running a traditional python setup.py bdist_wheel if insert_setuptools is explicitly set to false for a particular wheel.

xref https://github.com/galaxyproject/starforge/pull/171


Support BBC News (bbc.com/news)

bbc.com/news uses the same mediaselector format, but a different mediaselector url, and inlined json + xml playlist.sxml methods for obtaining video ids.
_download_media_selector is mostly redundant except for the hardcoded url; perhaps it should be made a third argument?

I would also prefer placing both extractors to a single source file and finally renaming it to bbc.py.

This says it has merge conflicts but it merges fine?

Thanks, merged.


Add a requirements.txt

There are still some missing here - I think it was soapysdr.
Might not be available for macOS. Also this requirements.txt doesn't do optional dependencies yet - I think there might be a way.

done


vscode continuous high CPU load after broken remote DISPLAY connection

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.73.1
OS Version: Ubuntu 22.04, CentOS7 (both local and remote machine)
Installed Extensions: none

Steps to Reproduce:

ssh -X remote-machine
/path/to/VSCode/bin/code       # starts detached
Terminate/Kill terminal where ssh was executed    (or CTRL-D + CTRL-C the ssh shell ) - sometimes accidentally done by users
GUI disappears (as expected), but on the remote machine one or more permanent 100% or 200% CPU load processes  remain forever

local and remote computer could be the same (but via ssh -X  channel)
remaining high CPU load processes of type: local/VSCode-linux-x64/code --type=gpu-process --enable-crashpad --crashpad-handler-pid=6523 --enable-crash-reporter=XXXXX,no_channel ...
also happens in previous releases of 2022, does not happen e.g. using version 1.61.2
option --wait does not help

We are working in multi-user environments and  this issue cannot be easily caught; we often see  detached high CPU load processes that we need to kill manually.

After some further debugging I found that the issues does not occur when "just" starting
$VSCODE_PATH/code ...  without the argument $VSCODE_PATH/resources/app/out/cli.js
So it is not a workaround but probably it could help to find the root cause.
It would be interesting if the behavior can be reproduced on your side...

Any reason you are not using the remote extension https://code.visualstudio.com/docs/remote/ssh which could be a better alternative to avoid the above issue ?
This seems like an issue with the runtimes' GPU process, does the issue repro when you start with --disable-gpu ?

Thanks a lot for looking into this.
Using --disable-gpu did not help. I see the same effect.
The ssh remote extension sounds interesting. However, in our case we cannot use it as we work in different UNIX environments defined by specific user UNIX groups and permissions and environment variables - which is only available on the remote servers. This would make the ssh based setup quite complicated.

Please check if this is still an issue with latest stable 1.85

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


RabiWidth giving a fatal cache controller error

Compiling a pulse with
RabiWidth(q1, 1e-9*np.linspace(0, 1e3, 101), showPlot=True)

Leads to a red L2 on the APS producing the measurement pulse.

What happens if you power cycle?  Are you still using a 5 us pulse and 19 MHz SSB?

We're having trouble reproducing this issue.  What firmware version are these APS2's running?

If these are ones we programmed successfully the first time they should be flashed with v2.24 that came with the zipped v0.5 release.  The one we had to redo is running a slightly newer version... v2.27 I think.  My guess is 2.24.  Is that right Caleb?

Power cycle revives the unit, problem happens again when we try to run the experiment. L1 flashes as normal, and then we get a solid green L1 and solid red L2. Still using a 5us pulse with a 19MHz SSB.
This one is running the v2.24 that Matt and I flashed, we haven't used the v2.27 one yet.

v2.27 has a bug so stick with v2.24 for now.  I think you might be exceeding the waveform cache (128k samples) because the 19MHz autodyne frequency is not a nice multiple of 10ns.  As an aside for measurement channels, the physical channel SSB frequency should be zero and the frequency should be set on the logical measurement channel.
Could you try a couple different approaches:

reduce the measurement pulse width to 1us
change the autodyne frequency to a multiple of 10MHz to be a nice multiple of the 10ns step.

Hi, Thanks for this suggestion. The RabiWidth sequence runs fine with a 10 MHz autodyne freq. However, we still have to set this freq under the SSB freq in the Physical tab of Channels. Setting the autodyne freq to 10 MHz in the logical tab and the SSB freq to zero leads to a baseband measurement pulse when I compile the sequence. I tried restarting the GUI as well as iphython and that had no effect.

Ok, so changing autodyne freq does work now. Not sure what I did wrong the first few times.
Thanks.

Do you remember what you did?  I've seen this issue before where the autodyne frequency doesn't seem to have an effect.

Autodyne frequency is one of these ones that doesn't automagically update from the GUI to the notebook. There is work in progress to fix this.

This will be fixed with the PREFETCH command but for now sequences must fit inside a single waveform cache of 128k samples.  Error added in 3e9c74d07793c93d5df8788e3064f6ce68bec897


Add Android to profiles list.

I would like it if the profiles list included the android profile for ease of access.

Should I add it, considering it's quite slow? React with 👍 if I should add it and with 👎 otherwise.

Should I add it, considering it's quite slow? React with 👍 if I should add it and with 👎 otherwise.

#575 ?

Should I add it, considering it's quite slow? React with 👍 if I should add it and with 👎 otherwise.

5 likes

Done!

Done!

Yay!

@copy Did you change something to make it load faster?

It now starts in 8 minutes.


do not vendor packmol

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Fixes #61

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin, please rerender

We need packmol for PPC first, pending in https://github.com/conda-forge/packmol-feedstock/pull/8.

Superseded by #60


A corruption is possible in a shared config DB on NFS

sqlite code does not seem to use NFS-friendly locking (whatever it means)
We saw on NFS (on vSphere) that a transaction can be reported as committed and still overridden (and date deleted) with a non-related transaction from a different host.
We need to either change sqlite3.c to do proper locking on NFS ( lockf() seems to work fine) , or introduce our own .lock file for the duration of DB usage, on NFS datastores only

Seems a serious issue that we need to figure out.


Sometime navigation buttons are not visible

ios7, device, in code

Closing this issue. Please refer to this https://github.com/andreamazz/AMScrollingNavbar/issues/146


US 02.02.01

As a doer, I want a habit event to have an optional comment of up to 20 characters.
Completion Requirements:
-UI for entering habit events should enable the user to enter a comment, but visually and technically enforce/encourage a character limit of 20 characters
-Requires that habit events are creatable prior to being completable (and thus habits and users as well)
Halfway Checkpoint Completion:
-This story point should be completed by the halfway checkpoint
Potential Test Cases
-Test whether the character limit is displayed.
-Test whether the user is alerted when the character limit is reached.

Due to time constraints and the relatively small scale of this issue, this issue has been moved to after the halfway checkpoint.  No major functionality is lost by this change, and it permits more time to focus on more immediate concerns.

Working and verified.  Closing.


ResetEnable trait methods require ownership

The ResetEnable trait is implemented for Peripheral Reset Enable Control (PREC) ZSTs. However, its methods require self, so it cannot be used when we only have a &mut- reference to the PREC.
Proposal:
Change the ResetEnable trait to implement these methods for &mut self instead.
Advantages:

Usability, see https://github.com/stm32-rs/stm32h7xx-hal/pull/116

Downsides:

Allows the PREC to be reset/enabled when we only hold a &mut- reference to it. Currently if the PREC is part of a struct, we can be sure the peripheral will not be reset / disabled until that struct's destructor.

I would not feel good about dropping this guarantee for all peripherals just because of FMC.
having the ResetEnable trait provide an  unsafe method that takes &mut and internally makes a self + explicitly discouraging use of that method without a very good reason seems like a better solution for this.
While the guarantee is of course not provided anymore for FMC then, we would at least ensure no developer in the future accidentally invalidates the guarantee while in reality we could still provide it if the API was (self) instead of (&mut self)
Alternatively we could have a fully separate trait (since this will be done on a peripheral to peripheral difference) like UnsafeResetEnable which has the same method for &mut self. This would have the added advantage, that in docs.rs the user can see whether the peripheral is ResetEnable (i.e. has the destructor guarantee) or UnsafeResetEnable (i.e. does not have the guarantee) -> greater transparency for the consumer of the HAL regarding the guarantees it provides + the difference is obvious inside the type system already
Personally I'd favour the separate trait approach, what I really would not like is that we just drop this nice guarantee for all peripherals just because of one black sheep.

I agree; a separate trait like UnsafeResetEnable seems much safer and more transparent.
The ResetEnable trait could even have an into_shared or into_mut method that consumes self and provides an UnsafeResetEnable equivalent, so it's easy to work with perpetual libraries that require either one.

@hargoniX

I would not feel good about dropping this guarantee for all peripherals just because of FMC.

When you refer to "this guarantee", I'm assuming you are referring to

Downsides:

Allows the PREC to be reset/enabled when we only hold a &mut- reference to it. Currently if the PREC is part of a struct, we can be sure the peripheral will not be reset / disabled until that struct's destructor.

Is the intent that the the PREC explicitly cannot be used when a member of a struct? E.g. the PREC must be moved into some peripheral before it can be used to reset/enable a peripheral? That seems sound to me, and the FMC can actually employ special Option wrapping of the PREC to workaround the ownership issue - I don't know if we need a fully separate trait just for a single use case yet.

I'd imagine that if the FMC requires us to do this with an &mut API instead of our current one there might be other peripherals showing up in the future that would require us to do it like that, I'd just prefer to be prepared in that case already.


Any plan to continue cutlass (re)implementation of flash attention

I am currently studying cutlass and saw you started to (re)implement this project with cutlass abstractions.
My understanding is that today it's partially done, and I am wondering if you met some blocker because somehow you absolutely need lowest level CUDA code (if yes, would it be possible for you to share those?) or still plan to finish this task.
Thank you for this project, it's super interesting!

Yes, it's partially done, and I plan to finish it. I just haven't had as much time / bandwidth as I would like.
My understanding is that Cutclass should not bring any overhead (many of the matrix multiply operations in cuBLAS actually call Cutlass).
Currently the warp matrix multiply instruction is done by calling Cutlass. The next step is to rewrite the shared memory reading/writing to use Cutlass iterators.

Thanks for your fast answer!

You can check out the cutlass branch where we've rewritten the forward pass to use cutlass.

thank you for the notification.
May I ask you how you found your experience with cutlass library? (compared to Cuda and Triton if you use the 2nd one)
My team had a hard time with the many templates and concepts from cutlass, on the other side we learned quite a lot about some optimizations by reading the code...

There's quite a bit of a learning curve for sure. Took me a while to figure out which classes to use (I'm still not sure if I'm using exactly the right thing).
The cutlass devs are quite responsive to questions on github so that helps.
Cutlass abstracts away some of the trickiest bits (e.g., reading/writing to shared memory) so for me it was worth it to invest the time.
I haven't played with Triton too much. My impression is that under the hood the Triton compiler implements similar shared memory reading/writing. You're just programming at a different level of abstraction where these details are hidden away.
Cutlass might be more mature and battle-tested (e.g., some of the cuBLAS gemm calls dispatch to Cutlass kernels).

Thank you for your answer. It's very insightful.
FWIW, regarding Triton, we are playing with it, it's super productive compared to cuda / cutlass, but sometimes (rarely) you need some crazy workaround that doesn't make any sense (like in Flash attention implementation, it writes to GM to force the compiler to add instructions to redistribute work among threads), so definitely less mature. My understanding is that, like any tech, things are gonna improve soon :-)


We're planning to switch to Furo as a base theme, which will provide a dark mode.

We're planning to switch to Furo as a base theme, which will provide a dark mode.

Originally posted by @davidism in https://github.com/pallets/pallets-sphinx-themes/issues/48#issuecomment-1582583448
Any news? / why has the conversation of #48 been closed and locked as resolved?

Still the plan.

@davidism thanks for feedback .. sorry if I'm annoying :) the fact that PR #48 was closed leaves the impression that either the feature request has been fulfilled or is not planned. Wouldn't it be better to mark the feature request as such and leave it open?  ATM the request is "closed and locked as resolved" .. which forced me to have to open a (superfluous) new issue for a status query.


Add varbinary column switch case branch

calcite considered bytes as VARBINARY. so adding the case branch to the switch

Codecov Report

Merging #9313 (3c5a56f) into master (1c9528c) will decrease coverage by 44.90%.
The diff coverage is n/a.

:exclamation: Current head 3c5a56f differs from pull request most recent head 0f3fa16. Consider uploading reports for the commit 0f3fa16 to get more accurate results

@@              Coverage Diff              @@
##             master    #9313       +/-   ##
=============================================
- Coverage     69.73%   24.83%   -44.91%
+ Complexity     5017       53     -4964
=============================================
  Files          1873     1861       -12
  Lines         99598    99245      -353
  Branches      15163    15125       -38
=============================================
- Hits          69453    24644    -44809
- Misses        25217    72116    +46899
+ Partials       4928     2485     -2443

Flag
Coverage Δ

integration1
?

integration2
24.83% <ø> (+0.03%)
:arrow_up:

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

 Learn more


Fatal error: No observable object of type NavigationStack.Type found (iOS 13.0)

Hello there!
First of all, thank you for this amazing library which fixed many problems we had while implementing a navigation stack on our own, e.g. when using conditional navigation via switch-case-statements.
While this library is working completely fine on iOS 13.1, 13.2.2 and 13.3, it leads to the following crash during app start on iOS 13.0:
Fatal error: No observable object of type NavigationStack.Type found. A View.environmentObject(_:) for NavigationStack.Type may be missing as an ancestor of this view.: file /BuildRoot/Library/Caches/com.apple.xbs/Sources/Monoceros_Sim/Monoceros-24.4/Core/EnvironmentObject.swift, line 161 Fatal error: No observable object of type NavigationStack.Type found. A View.environmentObject(_:) for NavigationStack.Type may be missing as an ancestor of this view.: file /BuildRoot/Library/Caches/com.apple.xbs/Sources/Monoceros_Sim/Monoceros-24.4/Core/EnvironmentObject.swift, line 161 (lldb)
There seems to be a problem with attaching NavigationStack as an EnvironmentObject. We were able to fix this issue by setting it as an EnvironmentObject by our own. This though is not possible with the library as it is, since its initializes is internal and therefor not accessible.
My question is now how to fix this issue on iOS 13.0. If there is no solution, maybe you could provide a public initializer as a workaround, so we can add the EnvironmentObject by our own.
Thanks in advance and best regards,
Philipp

Hi @Faltenreich, thanks for your support. I've just managed to try the NavigationStackView on iOS 13.0 and I can't manage to reproduce your issue. I tried with this minimum example:
import SwiftUI
import NavigationStack

struct ContentView : View {
    var body: some View {
        NavigationStackView {
            View1()
        }
    }
}

struct View1: View {
    var body: some View {
        ZStack {
            Color.green.edgesIgnoringSafeArea(.all)

            PushView(destination: View2()) {
                Text("PUSH")
            }
        }
    }
}

struct View2: View {
    @EnvironmentObject var navStack: NavigationStack

    var body: some View {
        ZStack {
            Color.yellow.edgesIgnoringSafeArea(.all)

            Button(action: {
                self.navStack.pop()
            }, label: {
                Text("POP")
            })
        }
    }
}

struct ContentView_Previews: PreviewProvider {
    static var previews: some View {
        ContentView()
    }
}

The example exploits both a PushView and a programmatic transition to trigger a pop operation. And it works as expected:

Can you provide me with a minimum viable example that causes the problem in order for me to help you debugging this issue? Thank you again.
Matteo

Hi @Faltenreich, any updates on this issue? Thanks for your help.

Hi @matteopuc, thank you for your quick response!
Our code looks something like that:
`
import SwiftUI
import NavigationStack
struct ContentView: View {
@EnvironmentObject private var navigationStack: NavigationStack
var body: some View {
NavigationStackView(transitionType: .none) {
// some dynamic View that is conditionally instantiated
}
}
}
`
The ContentView itself is nested within some more Views. It contains one dynamic View as you can see in the comment, and other Views are pushed via the NavigationStack.push() method which is accessed via the EnvironmentObject.
Sadly I am not able to give you a full minimum viable example, since I am currently not at work and have no Apple hardware on my own in order to test it thoroughly.

Hi @Faltenreich, thanks for replying and for posting this snippet that shows the issue. The problem is that: in SwiftUI you can access an @EnvironmentObject property only within the view hierarchy where the environment object has been injected. In this case you are trying to access the navigation stack
@EnvironmentObject private var navigationStack: NavigationStack
outside the navigation stack hierarchy, which begins with:
NavigationStackView(transitionType: .none) {
    viewModel.getContentView()
        .frame(minWidth: .zero, maxWidth: .infinity, minHeight: .zero, maxHeight: .infinity)
        .transition(.slide)
    }

You just cannot access the navigation stack outside the hierarchy created by the NavigationStackView. You need to wrap your content view in a NavigationStackView, something like:
struct MyRootView: View {
    var body: some View {
        NavigationStackView {
            ContentView()
        }
    }
}

struct ContentView : View {
    @EnvironmentObject private var navigationStack: NavigationStack
    @ObservedObject private var viewModel = ContentViewModel()

    var body: some View {
        viewModel.getContentView()
            .frame(minWidth: .zero, maxWidth: .infinity, minHeight: .zero, maxHeight: .infinity)
            .transition(.slide)
    }
}

Now in your content view you can access the navigation stack.
If you want you can even use the NavigationStackView as your very root just changing a little bit the SceneDelegate file:
func scene(_ scene: UIScene, willConnectTo session: UISceneSession, options connectionOptions: UIScene.ConnectionOptions) {

        // Use this method to optionally configure and attach the UIWindow `window` to the provided UIWindowScene `scene`.
        // If using a storyboard, the `window` property will automatically be initialized and attached to the scene.
        // This delegate does not imply the connecting scene or session are new (see `application:configurationForConnectingSceneSession` instead).

        // Create the SwiftUI view that provides the window contents.
        let contentView = NavigationStackView {
            ContentView()
        }

        // Use a UIHostingController as window root view controller.
        if let windowScene = scene as? UIWindowScene {
            let window = UIWindow(windowScene: windowScene)
            window.rootViewController = UIHostingController(rootView: contentView)
            self.window = window
            window.makeKeyAndVisible()
        }
    }

Hi @matteopuc,
you are absolutely right: this seems like a bug on our side. The EnvironmentObject within the ContentView even seems a bit useless, since it is not used at all. Does the declaration itself lead to this crash - and why only on iOS 13.0 and not on 13.1+?
Either way, I will close this issue and thank you for your engagement. Your library is highly appreciated! :)


Separate functional and unit tests

Addresses issue #265.
(still need to check if unit tests really need sim_telarray installation)

Codecov Report

Merging #266 (e45f4f6) into master (bf7a724) will decrease coverage by 8.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   85.15%   76.38%   -8.78%
==========================================
  Files          75       66       -9
  Lines        6233     5784     -449
==========================================
- Hits         5308     4418     -890
- Misses        925     1366     +441

Impacted Files
Coverage Δ

simtools/tests/test_ray_tracing.py
100.00% <ø> (ø)

simtools/camera_efficiency.py
16.36% <0.00%> (-71.82%)
:arrow_down:

simtools/model/camera.py
14.06% <0.00%> (-70.71%)
:arrow_down:

simtools/util/model.py
42.37% <0.00%> (-32.21%)
:arrow_down:

simtools/visualize.py
62.19% <0.00%> (-25.61%)
:arrow_down:

simtools/config.py
75.55% <0.00%> (-12.23%)
:arrow_down:

simtools/util/legend_handlers.py
44.04% <0.00%> (-9.53%)
:arrow_down:

simtools/util/names.py
80.21% <0.00%> (-6.96%)
:arrow_down:

simtools/model/telescope_model.py
74.66% <0.00%> (-6.23%)
:arrow_down:

simtools/shower_simulator.py
78.12% <0.00%> (-3.13%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7a724...e45f4f6. Read the comment docs.

@orelgueta - reviewed your comments and committed changes. Please review and resolve the conversations.

Thanks a lot for the review - that took probably some time!
(and sorry for the broken integration test - I had to leave office and didn't wait for them to finish)

Because I added some code to this branch which required understanding it, it was easier. Otherwise yes, it would have taken a long time to review.


Prepare 1.0.5 release

Codecov Report

Merging #23 (47b785f) into main (7cb55ca) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           40        40
  Branches        11        11
=========================================
  Hits            40        40

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb55ca...47b785f. Read the comment docs.


fix(vls): show initial error overlay

Codecov Report

Merging #25 (64a2914) into main (93a36e7) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   31.73%   31.73%
=======================================
  Files          11       11
  Lines         416      416
  Branches       84       84
=======================================
  Hits          132      132
  Misses        284      284

Impacted Files
Coverage Δ

packages/checker-vls/src/commands/diagnostics.ts
14.92% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a36e7...64a2914. Read the comment docs.


profile edit: show medialinks on this site an remove additional link

http://guides.rubyonrails.org/layouts_and_rendering.html

https://github.com/plataformatec/simple_form
https://stackoverflow.com/questions/4598876/simple-form-error-undefined-method-model-name-for-activerecordrelationcla


Modified loadSignature to only check local name and not namespace name

Loading the signature for XML documents that specify the signature namespace 'http://www.w3.org/2000/09/xmldsig#' on the root element of the document doesn't work because loadSignature only has the signature node (as XML), and therefore doesn't have reference to it's namespace.
For example:
<root xmlns:ns1="http://www.w3.org/2000/09/xmldsig#">
...
  <ns1:Signature>

This will effectively find the Signature element, but then break finding any Reference elements inside of the loadSignature function.
The other way to handle this is to change loadSignature to accept an XML DOM Node that has reference to the document instead of just a string, however this is obviously a big breaking change.
I'm no XML expert so I could be missing something, but the scenario where the NS for signature is defined on the root element is happening to me when working with a few SAML implementations.

i think loadSignature should accept a xml DOM Node, or at least let specify the namespace of the signature as another parameter (or maybe a options object?).
@yaronn could you explain why loadSignature can not take the whole xml and search for the signature node?

@bjrmatos I think you are probably right. Take the following example:
sig.loadSignature(xmlString)
//at this point, sig.signatureXmlDoc doesn't have reference to the namespaces declared on the root element
sig.checkSignature(xmlString)
//now we will see a failure in validateSignatureValue because getCanonXml can't find the root namespace.

See https://github.com/yaronn/xml-crypto/commit/f0d4b4549ec14e1cfb2535e60c3e9e285f4f86da for an implementation that passes a node object (and still accepts string).

Thanks @brianhartsock, I've pushed it to npm.
@bjrmatos - initially the concept was that xml-crypto should be xml library agnostic, so I did not want to rely on any specific xmldom objects. Maybe it was a mistake since it cause a performance hit and also some semantic issues like this.

maybe we can make this more fun :)
this is my proposal:
maybe we can get rid of sig.loadSignature (at least from the public API) and only use sig.checkSignature -> sig.checkSignature(xmlDocument, [externalSignatureXmlDocument])
we will always search for an enveloped signature in xmlDocument, with this we can bring it back the condition: //*[local-name(.)='SignedInfo']/*[local-name(.)='Reference' and namespace-uri(.)='http://www.w3.org/2000/09/xmldsig#'] for ensure a well formed xml document, and it will be ok since we have all the information that we need (namespaces) because we have the whole xml document.
we will only use the last parameter (externalSignatureXmlDocument) when the xmlDocument does not have the signature inside it (external xml signature), i think both xmlDocument and externalSignatureXmlDocument can accept a xml string or a xml node.
what do you think? i can send a PR :)

obviously, this will be a breaking change

it's a good idea though will break a lot of code, tests and documentation. if you have time you can try it and see if it is risky or not.

@bjrmatos I am obviously a fan of sending objects that somehow have reference to the entire XML document, otherwise it is easy to accidentally lose XML NS info as this PR solved.
The issue I have is that it is unclear clear what is signed when passing the xml document in. An XML document can have numerous signatures on different nodes. If that's the case, what does checkSignature actually check? Which parts of the document are signed and can be trusted, what parts aren't?

@yaronn I can open a PR for https://github.com/yaronn/xml-crypto/commit/f0d4b4549ec14e1cfb2535e60c3e9e285f4f86da if you think that approach is right.

right now, i think checkSignature is designed to handle only one signature, via loadSignature.
the API is not designed for a document with multilpe <Signature /> nodes, we should fix that :(
with my proposal sig.checkSignature(xmlDocument, [externalSignatureXmlDocument]) i think this will be easy to resolve.. first we need to update checkSignature to find all instances of  <Signature />, by default it will search inside the document -> xmlDocument param, if externalSignatureXmlDocument is specified it will search inside the external document.
For all instances of  we'll call the internal process of loadSignature and validate all the instances accordingly.
obviously we must refactor the function a little bit to handle the case, but this is the general idea :)

@brianhartsock @bjrmatos
if I understand correctly you are raising two issues:

checkSignature receives a string rather than xml, which is a problem when there are ambient namespaces (and possibly performance and aesthetic problem as well.)
checkSignature will not work when there are multiple signatures

currently issue 1 is solved with this PR (with a risk that some unrelated Signature node will be captured) and issue 2 requires end user to iterate over the signatures and validate each one.
I'm ok with adding checkSignature support for xmldom inputs as long as it does not break current api (e.g. string inputs should also be accepted).
I agree the current API does not fit multiple signatures since you need to explicitly load a single signature and validate it. Changing this behavior for checkSignature might cause unknown regressions. But we can add a new API function checkAllSignatures to do it.

i really think loadSignature must be deprecated in favor of a new  checkSignature behaviour. This will be a breaking change but with a more compact API and new features.
Maybe this is a good excuse for a 1.0 version, i think we should define milestones and see how it goes.
New Proposal:

deprecate loadSignature, it will require some work but i think it will be for a good reason.

letting the user to specify the signature manually is risky (possibly lost namespaces, it requires the user to parse the xml document and search for the signature which affects performance), maybe we can deprecate that and let xml-crypto to do this work.

checkSignature will search and validate only the first signature found (i dont know if you would like to support letting the user to validate a specific signature, we can do it vía a xmlPath expression).

checkAllSignatures will validate all signatures found, the behavior would be the same as described in my previous comment. (by default it will search inside the document for all instances of <Signature /> and validate all instances accordingly. if externalSignatureXmlDocument is specified it will search inside the external document).

both checkSignature and checkAllSignatures must support the externalSignatureXmlDocument param for external signatures. -> checkSignature(xmlDocument,[externalSignatureXmlDocument]) and checkAllSignatures(xmlDocument,[externalSignatureXmlDocument])

the user wont need to specify the signature manually, xml-cryto will do it and will support multiple signature validation.

@bjrmatos - I like it. this sounds like a great a candidate for version 1.0.0. Is this something you have the time to start implementing?
the only concern is about exposing xmldom as a direct api type (rather than string). maybe if someone is using other xml parsers it would seem strange we force them to use our parser. but maybe in the future we can be parser agnostic or support a string overload, so not a big issue.

yes i can start this :)
maybe i was not clear enough, but my idea is that both checkSignature and checkAllSignatures only accept strings representing the xml documents, checkSignature(String: xmlDocument, [String: externalSignatureXmlDocument]), since xml-crypto will do the work of search for the signatures, it won't require the user to pass a DOM node, the user only has to pass the xml document and optionally the signature xml documento for external signatures if is the case.
Also, do you like the idea to letting the user to validate a specific signature?, as i mentioned we can do it vía a xmlPath expression so it won't require the user to parse anything :)

got it, sounds good.
will loadSignature still work and output a deprecation message or will it throw an exception and not work at all?
letting validate a specific signature is nice to have but not a must for the first release. users that wish that can strip out manually the other signatures.

since the target of these changes is a 1.0 version i think we should just deprecate the method and remove it from the public API (it will be used internally).
is a major version change, i think we won't break anyone's codebase.. only people installing the module with xml-crypto: *, which is a bad practice at all in the node.js comunity.
i will work on this very soon :)
thnks for your time!

:+1: sounds good!

@bjrmatos how would you know what parts of the xml document are signed? That's my concern. Take the following:
<root>
  <node1>
     <Signature>...</Signature
     <data>...</data>
  </node1>
  <node2>
    <data>...</data>
  </node2>
</root>

In this scenario, the caller would know what parts of the document are signed and should be trusted vs. what parts should be ignored. In the case of SAML, this could be incredibly dangerous, as a signed assertion should be trusted and an unsigned one shouldn't be. A caller could easily call checkSignature thinking it validates the whole document, which isn't necessarily true.
Maybe I don't understand your plans for externalSignatureDocument

how would you know what parts of the xml document are signed? That's my concern. Take the following

A <Signature> contains <Reference> node(s) which points to the parts of the document that was signed via its URI attribute -> <Reference URI="#myInfo">. As the digital signature specification says, if a URI with an empty value is found -> URI="" it means that the whole document was signed.
externalSignatureDocument is there to support external signatures (when the signature is not present in the original xml document that was signed), when externalSignatureDocument is specified xml-crypto will search <Signature> nodes inside the external document. checkSignature will validate only the first signature found (maybe with the possibility to pass a xpath expression referencing to a specific signature to validate), and checkAllSignatures will validate all signatures found.


Backdrop with delay does not work

When using backdrop with a delay, backdrop is "blinking" ..

Should be fixed by c3d142c95b146170491a12c56a6d3f8e2c9978ea.


Add unescape (and unit tests)

By default i18next eacapes the values to mitigate XSS attacks:
https://www.i18next.com/translation-function/interpolation#unescape.
As per the above documentation,
there are 3 ways to turn unescape on:

at init (not recommended, as it will relax the default everywhere)
per single value: "keyUnescaped": "dangerous {{- myVar}}"
at i18next.t time:

i18next.t('keyEscaped', { myVar: '<img />', interpolation: { escapeValue: false } });

We add option 3 to the pair of functions using i18next.t
UPDATE: added also missing unit tests

Linked to https://github.com/companieshouse/ci-pipelines/pull/3800 which activates unit-tests task in Concourse


Allow servers to translate/alter the kick message for players without the mod

I think some servers would appreciate a (serverside) config option to translate this message:
https://github.com/Aizistral-Studios/No-Chat-Reports/blob/ae263f13f7cb506c08b12acfecff61c5454bbc8e/src/main/java/com/aizistral/nochatreports/NoChatReports.java#L39
My ideas would be to either add that message to the lang files and let the server choose which one to use or to allow them to configure a custom message through the config, like plugins often do, which offers far more customization.
You could also have one config option which can be used for both:
If it is, for example, set to "en_en", the default translation is used, if no lang file with that String was found (or the format is not xx_xx), the String itself will be the message. That'll only work as long as there aren't multiple serverside messages, of course.
This suggestion is based on #45.

If it can be configured that joining the server requires installation of the mod, why is this a required feature?
They do operate differently, but ultimately achieve the same thing, unless I am missing something?

Servers don't have localizations without LanguageHack which I haven't updated to 1.19 yet

I see. The (serverside) config should still be a good and viable option, however.
@otta8634 Sorry, I missed your comment. I don't quite understand what you mean, afaik that message is shown to clients without NCR if the server does have NCR installed and requires clients to do so, too. So I'm not sure what you think is "achieving the same thing"?


pubsub error after new ipfs + libp2p upgrade

I think it's mostly related to the new ipfs + libp2p upgrade. I also faced the same issue, did the same workaround. I am also having trouble using the orbit api with pubsub now:

Uncaught TypeError: Cannot read properties of undefined (reading '0')
    at IPFSPubsub._handleMessage (/home/ratik/Zero/zChain/node_modules/orbit-db-pubsub/src/ipfs-pubsub.js:100:31)

cc: @tabcat

Originally posted by @ratik21 in https://github.com/orbitdb/orbit-db/issues/1004#issuecomment-1154642841

Believe this was closed by #1004


Skype bot error

Skype for Business could not reach the bot. Please contact admin of the bot for help.

@angeluskinyua I'm closing this as there really isn't enough data here for the team to debug or to provide assistance.  Additionally, this repo is not intended for framework bugs.  We ask that you open bugs in the specific language repos, or if you are looking for specific help, we have an active community on StackOverflow.com
Here are a list of all the language specific repos that might be helpful
https://github.com/Microsoft/botbuilder/blob/master/README.md


Implement Fuseki metadata store

This pull request implements a metadata cache implementation based on Apache Jena Fuseki to supplement the existing SleepyCat and SQLite implementations.
Fuseki can be run as a separate service to Gutenberg, e.g. via Docker, which makes setup of the library much easier: no more need to install bsddb3! This means that going forward we can move bsddb3 into an optional dependency. Additionally, Fuseki can be run on a separate machine from Gutenberg so it enables use-cases where multiple users may want to share a single metadata cache.

@hugovk @MasterOdin @sethwoodworth Could someone take a look at the PR and let me know if you have any objections to the change? Thanks in advance!

@MasterOdin Addressed your comments. Are you okay for this to be merged now or do you have any further questions/concerns?


Failing test with PHPUnit 7.2

Hi,
In Debian, since the recent upload of PHPUnit 7.2, we noticed that the following fDOMDocument internal test now fails:
1) TheSeer\fDOM\Tests\XPathQueryTest::testFindingKeysInQueryWorks
TheSeer\fDOM\fDOMException: parsing string failed

/usr/share/php/TheSeer/fDOMDocument/fDOMDocument.php:171
/tmp/autopkgtest-lxc._7z7siya/downtmp/build.TCp/src/tests/XPathQuery.test.php:53

https://ci.debian.net/data/packages/unstable/amd64/p/php-fdomdocument/latest-autopkgtest/log.gz
Please note that the following internal phpDox test also fails, which might be related:
1) TheSeer\phpDox\GlobalConfigTest::testTryingToLoadInvalidConfigThrowsException
Failed asserting that exception of type "TheSeer\fDOM\fDOMException" matches expected exception "\TheSeer\phpDox\ConfigException". Message was: "loading file '/tmp/autopkgtest-lxc.dv7ktfvx/downtmp/build.6e0/src/tests/data/config/broken.xml' failed." at
/usr/share/php/TheSeer/fDOMDocument/fDOMDocument.php:147
/tmp/autopkgtest-lxc.dv7ktfvx/downtmp/build.6e0/src/tests/Unit/config/GlobalConfigTest.php:82
/tmp/autopkgtest-lxc.dv7ktfvx/downtmp/build.6e0/src/tests/Unit/config/GlobalConfigTest.php:92

https://ci.debian.net/data/packages/unstable/amd64/p/phpdox/latest-autopkgtest/log.gz
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902008

Interesting.
No code has been changed for quite a while and tests run fine up to PHPUnit 7.1.5.
Starting with PHPUnit 7.2.0, this one test fails.
Investigating.

This is a bug in PHPUnit. One I'm afraid even I caused.
I'll open a bug and provide a PR.

While I consider the broken test a side effect of an unclean behavior within PHPUnit, fDOM itself also should clear the libxml error buffer before looking for errors. Global state for the win ;)
Thanks for finding this.
When https://github.com/sebastianbergmann/phpunit/pull/3190 the problem should be fixed.
I'll leave this  open so I can fix the behavior in fDOMDocument as well.

When sebastianbergmann/phpunit#3190 got merged, the problem should be fixed.

Confirmed. I just rebuilt phpunit with your fix and ran the tests on both fDOMDocument and phpDox. Thanks a lot for your quick response!
Regards
David

I'll leave this open so I can fix the behavior in fDOMDocument as well.

PHPUnit was fixed quite a while ago but this repo still "needs" a fix :-)

As this project is to be Archived, I'll close this issue. Sorry for not addressing this.


vLLM model serving server hangs when GPU KV cache usage reaches 10%

Hello everybody,
The server hangs when the GPU KV cache usage reaches 10%.
Issue in Detail
I attempted to serve the Llama2 7B Hugging Face model via vLLM on GPU by following the API Server Quickstart guide. In some instances, the model serving works correctly, processing the input prompt request successfully and returning a response. However, there are times when the model serving server accepts the input prompt request but becomes unresponsive and fails to provide any response to our request.
Upon debugging, I identified that the issue is related to the GPU Key-Value cache usage. The model operates as expected when the GPU Key-Value cache usage is at 0.8%, but the server becomes unresponsive when it reaches 10%.

The first image illustrates a successful case where the input prompt request works as expected, and the GPU KV cache usage is 0.8% (highlighted in yellow)

The second image depicts a non-successful case where the model serving server accepts an input prompt request, but the server becomes unresponsive, providing no response. This occurs when the GPU KV cache usage is at 10% (highlighted in yellow).
Details

GPU: NVIDIA Tesla T4 (16GB vRAM)
CUDA Version: 12.0
Driver Version: 525.85.12
vLLM version: 0.2.1.post1
Hugginface model: meta-llama/Llama-2-7b-hf

Steps to the replicate the error

Open a Terminal (terminal 1)
Login into Huggingface using its CLI: huggingface-cli login --token <your-token>
In terminal 1, execute the following command: python -m vllm.entrypoints.api_server --model meta-llama/Llama-2-7b-hf
Open another Terminal (terminal 2)
In terminal 2, execute the following command: curl http://localhost:8000/generate -d '{"prompt": "San Francisco is a", "use_beam_search": true, "n": 4, "temperature": 0}'

Please ensure that you have the respective vLLM package and the CUDA toolkit.

I believe this is similar to #1879. While T4 can run a 7B model, the throughput will be very very low and vLLM will likely perform a lot of eviction and recomputing to deal with the little memory available left for computation. For 16G device memory, the model itself takes 14G which leaves very little for computation and KV cache.

Also happens on vLLM 0.2.4, 0.2.5 and main while running any model tensor-parallel on 2x 4090 (2x4090). Once the VRAM KV cache is full vLLM hangs, it just stops running any processing on the GPU. It does not even try to swap anything out to the CPU KV cache.
Last log lines before the freeze:
INFO 12-16 00:57:56 llm_engine.py:649] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 316.4 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 84.9%, CPU KV cache usage: 0.0%
INFO 12-16 00:58:01 llm_engine.py:649] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 311.9 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 91.5%, CPU KV cache usage: 0.0%
INFO 12-16 00:58:06 llm_engine.py:649] Avg prompt throughput: 0.0 tokens/s, Avg generation throughput: 311.1 tokens/s, Running: 1 reqs, Swapped: 0 reqs, Pending: 0 reqs, GPU KV cache usage: 97.3%, CPU KV cache usage: 0.0%

On killing it with SIGTERM (or Ctrl-C):
^CINFO:     Shutting down
INFO:     Waiting for background tasks to complete. (CTRL+C to force quit)

Then it continues to hang.

At present, we have found a workaround and set the swap space directly to 0. This way, we will not call the CPU swap space and will not report any errors. However, the CPU blocks will also become 0, which may slow down the speed a bit, but at least it will not hang and die.


ADDING 'CONTACT US' FORM

### ADDING 'CONTACT US' FORM
Incorporating a contact form into your webpage is an essential step for enhancing user engagement and accessibility. It provides visitors with a simple and efficient way to reach out for inquiries, feedback, or support, ensuring open communication channels between your business and its audience. This not only improves communication but also boosts user trust and professionalism.
Here’s how it can be highly beneficial:
Improves User Experience: A well-placed contact form allows users to easily connect without having to search for contact details or email addresses.
Collects Structured Data: By using input validation and specific fields, you gather accurate and organized information that can streamline follow-up processes.
Enhances Lead Generation: Contact forms can serve as a key tool for gathering potential leads, making it easier to build relationships and drive conversions.
Ensures Privacy and Security: A form offers a more secure way for users to submit personal information compared to email, safeguarding their privacy.
Adds a Professional Touch: A well-designed contact form demonstrates attention to detail and adds professionalism to the overall website experience.

Could you please assign this issue to me? I believe I can provide a solution.

@dnyanesh99borse if you making this contact form, make it a separate project and don't add it to home page

OK SURE SIR I WILL DO LIKE WISE YOU TOLD.

SIR SO WHERE SHOULD I HAVE TO ADD THIS FUNCTIONALITY OR  THE SECTION:

I CAN ADD THE CONTACT US BUTTON TO THE HOME PAGE AND THEN AFTER CLICKING ON THAT THE USER WILL REDIRECT TO THE CONTACT US FORM PAGE SEPARATELY

OR WE CAN DIRECTLY PROVIDE THE CONTACT US SECTION DIRECTLY IN THE APPS SECTION OF THE HOME PAGE.

SO WHICH ONE I SHOULD HAVE  TO PROCEED WITH


Exposing Prometheus over nginx ingress fanout approach

Proposal
Use case. Why is this important?
Leveraging one IP to expose all apps related to operations using ingress fanout routing
“Nice to have” is not a good use case. :)
Bug Report
What did you do?
Trying to add Prometheus which is installed to existing ingress controller using ingress fanout routing.
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: ops-ingress
  annotations:
    nginx.ingress.kubernetes.io/rewrite-target: /$2
spec:
  rules:
  - http:
      paths:
      - path: /prometheus(/|$)(.*)
        backend:
          serviceName: prometheus-server
          servicePort: 80

What did you expect to see?
expecting to see Prometheus web frontend exposed on ingress controller using fanout approach
What did you see instead? Under which circumstances?
Receiving 404 error, with above ingress definition in place, url “http://<>/prometheus/ getting redirected to http://<>/graph/ and then 404 error page getting rendered. When url adjusted to http://<>/prometheus/graph some of webcontrols gets rendered with lots of errors on browser console.
Environment
Azure Kubernetes Service, Kubernetes version 1.13.12

System information: Linux 4.15.0-1060-azure x86_64

Prometheus version: 2.13.1

Alertmanager version: Not enabled

Prometheus configuration file:

# my global config
global:
  scrape_interval:     15s # Set the scrape interval to every 15 seconds. Default is every 1 minute.
  evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute.
  # scrape_timeout is set to the global default (10s).

# Alertmanager configuration
alerting:
  alertmanagers:
  - static_configs:
    - targets:
      # - alertmanager:9093

# Load rules once and periodically evaluate them according to the global 'evaluation_interval'.
rule_files:
  # - "first_rules.yml"
  # - "second_rules.yml"

# A scrape configuration containing exactly one endpoint to scrape:
# Here it's Prometheus itself.
scrape_configs:
  # The job name is added as a label `job=<job_name>` to any timeseries scraped from this config.
  - job_name: 'prometheus'

    # metrics_path defaults to '/metrics'
    # scheme defaults to 'http'.

    static_configs:
    - targets: ['localhost:9090']

Alertmanager configuration file:

Logs:

^ completely disagree brian. github issues are indexed by google and are therefore way more easy to find than some boomer mailing list.

@gopurx were you able to find a solution for this? I would also prefer to using a route for this instead of subdomain

The mailing list is searcheable. https://groups.google.com/forum/#!searchin/prometheus-users/nginx$20fanout|sort:date/prometheus-users/Sn_NWW4bi7E/xrt1vcSXCwAJ

Got the same issue trying to isntall prometheus in my k8s cluster. Doesn't matter what I use for ingress path, it gets redirected to (non existent) /graph

Got the same issue. Tried to change https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus/values.yaml#L636 and https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus/values.yaml#L640 but still no luck. @smirnov-mi Have you managed to fix it?


Port more algorithms

[ ] FNV-1 (64 bits)
[ ] FNV-1 (32 bits)
[ ] FNV-1a (32 bits)

you can close this 😉

Yep, thanks again for the contribution here :+1:


ACL support for zookeeper backend

Is there any plan to ACL support for zookeeper backend ?

I have the same problem


Problem each time I when I press deploy in node-red

Hi
I am getting the following on my ssh window each time I press deploy in node-red after I modify my flows :+1:
pi@raspberrypi ~ $ (node) warning: possible EventEmitter memory leak detected. 11 connect listeners added.
Use emitter.setMaxListeners() to increase limit.
Trace
at addListener (events.js:179:15)
at setupStatusEvents (/home/pi/.node-red/node_modules/node-red-contrib-blynk /blynk.js:14:24)
at new BlynkWriteNode (/home/pi/.node-red/node_modules/node-red-contrib-blynk/blynk.js:83:3)
at createNode (/usr/lib/node_modules/node-red/red/nodes/Flow.js:35:18)
at Flow.start (/usr/lib/node_modules/node-red/red/nodes/Flow.js:392:44)
at Object.module.exports.startFlows (/usr/lib/node_modules/node-red/red/nodes/flows.js:141:24)
at /usr/lib/node_modules/node-red/red/nodes/flows.js:121:77
at tryCatchReject (/usr/lib/node_modules/node-red/node_modules/when/lib/makePromise.js:845:30)
at runContinuation1 (/usr/lib/node_modules/node-red/node_modules/when/lib/makePromise.js:804:4)
at Fulfilled.when (/usr/lib/node_modules/node-red/node_modules/when/lib/makePromise.js:592:4)
(node) warning: possible EventEmitter memory leak detected. 11 disconnect listeners added.
Use emitter.setMaxListeners() to increase limit.
The guys over at node-red suggest the problem could be :
Possibly "not closing down the event listeners properly during the redeploy. Should be using the on close method to clean up."
Toshi

hi, are you deploying fully, or one of the other 'just changes' methods?
do you you have more than 10 blynk nodes?

i looked into this and it seems directly connected with the number of blynk nodes deployed.
they are being cleaned on close connection
this.on("close", function() {
			console.log('blynk server close', this.key);
			//TODO: cleanup
			//blynkConnection.disconnect();
			this.blynk.disconnect();
			this.blynk.removeAllListeners();
			this.pins = [];
			this.blynk = null;
		});

but if there are more than 10 nodes it adds more than 10 event listeners to check for status (connected/disconnected) updates. I am not sure if there is a better way of updating statuses than this.

pushed a new version with a higher value in max event listeners...
not sure if it s the proper way of handling this yet


Dynamic generation of table

This is not an issue with the code, just a question:
I am attempting to generate a table that is dynamic, meaning that the column names can't be hardcoded because they are based on a collection that changes keys in the documents.  When I try to hard code it, it works perfectly, here's a simple example:
TabularTables.SourceData = new Tabular.Table({
    name: "SourceData",
    collection: Collections.SourceData,
    columns:[ { data: '_id', title: '_id' },
        { data: 'ID', title: 'ID' },
        { data: 'FirstName', title: 'FirstName' },
        { data: 'LastName', title: 'LastName' },
        { data: 'fileId', title: 'fileId' } ]
});

But this dynamic version, which is trying to create the same exact table is coming up blank:
// pull the first document in the collection
// and put each key into the columns array
var dataRecord = Collections.SourceData.findOne()
var dataColumns = [];

for (var key in dataRecord) {
    dataColumns.push({data: key,title: key});
}

var myTable = {
        name: "SourceData",
        collection: Collections.SourceData,
        columns:dataColumns
    };

TabularTables.SourceData = new Tabular.Table(myTable);

Any suggestions for what I'm doing wrong?
Thanks!
--Ivan

I don't see an issue, but maybe you could put it into a simple example repo to replicate the issue.


Install CCM latest, not master

@jkni to review

http://cassci.datastax.com/view/Dev/view/ptnapoleon/job/ptnapoleon-test-ccm-dtest/1/

+1 if CI looks good.