Refactoring to use default keyword, and other minor changes, for Source/Foundation/Math

Feel free to request changes.

The compiler should only be initializing them once, based on which constructor is chosen.
I think the standard indicates that this initialization to zero is happening whether or not we explicitly provide a default value of zero.
I believe that floats are always "value-initialized" unless provided a value for "brace-or-equal-initializer", so this these floats are always initialized to 0.0f by default.
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/n4659.pdf
Page 221
8 To value-initialize an object of type T means:
(8.1) — if T is a (possibly cv-qualified) class type (Clause 12) with either no default constructor (15.1) or a default constructor that is user-provided or deleted, then the object is default-initialized;
(8.2) — if T is a (possibly cv-qualified) class type without a user-provided or deleted default constructor, then the object is zero-initialized and the semantic constraints for default-initialization are checked, and if T has a non-trivial default constructor, the object is default-initialized;
(8.3) — if T is an array type, then each element is value-initialized;
(8.4) — otherwise, the object is zero-initialized

Have you had a chance to compare the assembly of the Quaternion classes on https://godbolt.org/ ?

Some more discussion here: https://stackoverflow.com/questions/3803153/what-are-primitive-types-default-initialized-to-in-c

I'm not sure if we understand each other. I meant, no initialization at all (leave them at their undefined values). This way the compiler can completely skip calling the constructor and initializing. Same if I just mallocd the memory.

You can check what I mean here: https://godbolt.org/g/RTM8J9 . Try removing the in-class initialization to zero in the Quaternion class, for all four members.

If you change to O2, the constructor is eliminated as well: https://godbolt.org/g/Y5pGic
I have to admit that I don't see how the constructor isn't being called to value-initialize the floats. How is that permitted? Do you know why clang isn't emitting a call to the default constructor?

Bizarrely, adding brace-initilization changes the assembly output. Wtf? https://godbolt.org/g/ZYPo3J
Though, that's a bit off-topic.

If the source of setValues() is available (e.g. eligible for inlining, not in another translation unit), at O2, the compiler will directly initialize to the values from setValues()
https://godbolt.org/g/KTzeBd

By default floats/ints are not value-initialized. They are not initialized at all. So the constructor does nothing unless you explictly default initialize, or initialize them to some value.
Regarding brace init, I'm guessing this is happening:

If the number of initializer clauses is less than the number of members or initializer list is completely empty, the remaining members are value-initialized. If a member of a reference type is one of these remaining members, the program is ill-formed.

But I'm hardly well versed in the standard.

It's not just going to be a problem in -O1. Just using an array is enough to foil the compiler, even at -O2:
https://godbolt.org/g/NzMXRd

In that example, GCCs producing some pretty disgusting assembly...
Clang handles that scenario beautifully though.
https://godbolt.org/g/eiEZdy

And https://godbolt.org/g/1wubJT, for when we provide default values.

Here's with gcc : https://godbolt.org/g/fTXypA

Increasing the array size to 1024, where the only other difference is that one is initialized to 0, the other isn't given a value, has vastly different behavior for gcc vs clang.
https://godbolt.org/g/oCKZif
Gcc inserts a call to memset for the code that initializes the floats to zero, but clang's assembly actually shrinks significantly. Looks like it's just adding up all the values and returning them statically.

I'm too tired to read all this assembly :) But indeed, some really weird results.
I think my main concern with initialization for these types were cases where there are many of those objects being allocated, thousands or more, in some low-level high performance code, and then passed along to something the compiler might not be able to inline.

To be honest here, my biggest concern was that we wouldn't be able to construct the Quaternion in constexpr contexts.
I should have started the discussion with that.
However, apparently I was misremembering the rules, and it's perfectly fine to do this (as just an example):
struct Quaternion
{
float x;// = 0.0f;
float y;// = 0.0f;
float z;// = 0.0f;
float w;// = 0.0f;
Quaternion() = default;
constexpr Quaternion(float)
: x(0.0f)
, y(0.0f)
, z(0.0f)
, w(0.0f)
{}
};
So, best of both worlds.
"no-initialization" for arrays and such.
Constexpr zero-initialization when asked for.
Everyone wins.
Lets leave it how you have it.


add a project roadmap

separating this from issue #70

I think a project roadmap should take place in a fresh project when we decide to refactor all the things.


Wire up main view page scene

The main/search interface should list available scenes in the sidebar and footprints in the map:

only query scenes endpoint at higher zoom levels
list should include all scenes in viewport on the map
when a user clicks on a scene a detail view for the scene comes up in the sidebar

For the detail view, one thing we need to make sure is that the URL gets updated so it is shareable (e.g. /map/images/<uuid> or something)


5.3 tag is broken. Reality: php version is 5.6

Hi,
just fyi , your image with 5.3 tag is broken.
It's PHP inside is 5.6 (probably because FROM ubuntu:precise )...

Verified. The images with PHP 5.3 runs success.
docker run --name app -d -p 8080:80 romeoz/docker-nginx-php:5.3 or docker run --name app -d romeoz/docker-phpfpm:5.3
Verified: docker exec -it app php -v
Profit:

In Ubuntu 12.04 (Precise) PHP 5.3  is out of the box (official repository of Ubuntu)


Modular Vuex store

Can we use this library with modules?
For example, here is a standard Vuex code:
@ store.ts
import Vue from 'vue' ;
import Vuex from 'vuex' ;

import users from './store/users' ;

Vue.use(Vuex) ;

const store = new Vuex.Store
(
    {

        modules:
        {
            users
        }

    }
) ;

export default store ;

@ store/users.ts
export default
{

    namespaced: true,

    state:
    {
        users: {}
    },

    getters:
    {
        users: aState => aState.users
    },

    mutations:
    {

        ADD_USER (aState, aUser)
        {
            Vue.set(aState.users, aUser.id, aUser) ;
        }

    },

    actions:
    {

        getUsers (aContext)
        {
            ...
        }

    }

} ;

What would be a vuex-class equivalent?
Thanks!

As this library is for binding Vuex store and Vue component, it does not change how you define Vuex modules. And I would not add such feature which changes how define Vuex store in the future.


WOR-1458 - Pact Test Fixes

https://broadworkbench.atlassian.net/browse/WOR-1458

Re-enable can-i-deploy for consumer contract tests (now that https://broadworkbench.atlassian.net/browse/WOR-890 is finished)
publish all pacts in output directory to the broker

Can you provide a link to the pact broker showing where these got published? I'm just looking to understand more about how we know this is actually working.


Distinguish explicity thrown WASM errors  in JS

Explicitly thrown errors uses a tag to distinguish them.
For example for,

integer overflow:
(throw $overflow)
bad casting:
(throw $bad-casting)

But the error message emitted in the JS does not contain this tag thus it cannot distinguish between explicitly thrown errors
https://github.com/WebAssembly/exception-handling/blob/main/proposals/exception-handling/Exceptions.md

It is possible to do this by,

Exporting the tags from the WASM module
If an exception is thrown and check if it is of type WebAssembly.Exception.
If so pass the exported tags one by one to the err.is(tag)  function in WebAssembly.Exception class. Function returns true when a matching tag is found


Fix default config dicts

If an existing config does not have anything on FSDP (as will be the case for most users since the future just went out) there is currently an error in the launcher that the config has a None fsdp_config. This PR takes care of this by making sure all dicts attributes of the config are initialized in the post_init.
cc @pacman100 for information.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


New format extension on iOS - Interleaved2of5

New format extension on iOS - Interleaved2of5

Does that work for you? Searched for an Interleaved2of5-barcode on the internet an tried to scan it, but doesn't work. Normal barcode does work.
Why only on ios?

Yes, it works. We need it to read brazilian bank slip, written in this format. I am attaching a print of it working and a high resolution example. In android, this barcode is read as a normal itf, however in iOS it looks like there is a separation  between itf14 and  interleaved2of5.


Terminal plus

This package seems to not be working. I had to rebuild it because it was built for a previous version of atom and when I open it the cursor just blinks even the "insert text" doesn't seem to work.

I'm having the same issues as well.
I just re-installed this now via apm, and reloaded my atom window.
Unfortunately the icon to open up the terminal-plus is no longer displayed.
This may be due to a change in the API on atom

The creator of this project has not been active for quite a while now. Try the terminal-plus fork platformio-atom-ide-terminal, which is actively being maintained.


Add optional progress bar support

Hello! Based on your suggestion, I added the detailed progress bar as an optional feature. In the demix_track() and demix_track_demucs() functions, I added an optional parameter pbar=False at the end to control whether the detailed progress bar is displayed. Additionally, I added the --detailed_pbar option in the parser of inference.py to control whether the detailed progress bar is shown (if you think adding this option is unnecessary, I can remove it). Below are some screenshots. Thank you again!
Process with detailed pbar:

Looks great. I think we can show detailed progress bar without flag. And make flag to disable detailed progress bar.

I will approve PR later today.

Looks great. I think we can show detailed progress bar without flag. And make flag to disable detailed progress bar.

Yeah! I did it in the newest commit.


Multiple terms

This PR adds the capability of search for multiple terms keeping the correspondent highlight

Thanks for the time and effort. I'll be taking a look at it anytime soon.

I won't be able to accept this PR for 3 reasons:

Files that are not source code have been commited:
Only source files must be changed in a PR. In our case, the only source file available for change is "bootstrap-4-autocomplete.ts". All other files will be automatically generated on a release.

No code documentation given
All code submitted needs at least some sort of explanation of how it works.

Bugs
Some tests revealed faulty behaviour, in most cases not highlighting one or more of the searched terms.

If you find the time, please fix these and create a new PR.


Information Architecture (IA): 2021 assessment, proposal and rework

Provide an assessment of the current website's IA, and propose updates.

[x] #963

[x] #970

[x] #895

[x] #894
[x] #901

[x] Publish spec under /reference: #852
[x] #845

Related:

#964
#1001
Top:

@cartermp's OpenTelemetry docs scorecard -- thanks for this! /cc @theletterf
#154
#265

Other:

#814
#865

Also see some of the other issues that were tagged and are now listed (by GH) below

The major items have been completed. Closing. For the remaining changes, see #1268.


Gdscript2 enum fixes

This PR aims to fix many issues with ENUMs reported:
godotengine/godot#45558
godotengine/godot#49357
godotengine/godot#50293

If you could add some test cases for this (see GDScript test docs to confirm the issues are fixed it would be great.

@MarianoGnu Will you be able to add some test cases as requested? Or should this be merged and test cases added in a follow up PR?

Thanks!

Welp, even without new tests, this should have been rebased to pass the GDScript test suite. It's failing: https://github.com/godotengine/godot/runs/3758512075?check_suite_focus=true

I reverted commit<PHONE_NUMBER>6fb99fb7fe014522c44ae83f87dc4d which caused the regression (but kept the other two commits merged). See d2b8560d7a871a7bab27e68835f86e69e47e79ad.


Feat: setup generators

Just a small minor improvement that could be made : it would be great if we could build the nx key in the package.json in order to properly setup caching for the generated library. I'll merge this as is and open an issue for later.


Test suite fails: ImportError: No module named tests

# python setup.py test
<...skipped...>
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 58, in <module>
    'Topic :: Utilities',
  File "/usr/local/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/local/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/local/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/usr/local/lib/python2.7/site-packages/setuptools/command/test.py", line 159, in run
    self.with_project_on_sys_path(self.run_tests)
  File "/usr/local/lib/python2.7/site-packages/setuptools/command/test.py", line 140, in with_project_on_sys_path
    func()
  File "/usr/local/lib/python2.7/site-packages/setuptools/command/test.py", line 180, in run_tests
    testRunner=self._resolve_as_ep(self.test_runner),
  File "/usr/local/lib/python2.7/unittest/main.py", line 94, in __init__
    self.parseArgs(argv)
  File "/usr/local/lib/python2.7/unittest/main.py", line 149, in parseArgs
    self.createTests()
  File "/usr/local/lib/python2.7/unittest/main.py", line 158, in createTests
    self.module)
  File "/usr/local/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/local/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName
    module = __import__('.'.join(parts_copy))
ImportError: No module named tests

I have seen this kind of problem before. It doesn't happen in my normal dev environment, but I have managed to produce an error that is similar in a new environment. I have a suspicion that it involves the PYTHONPATH variable. Could you post a copy of the PYTHONPATH variable from your environment?

PYTHONPATH is empty. I am building it as a FreeBSD port, and FreeBSD ports python framework never sets PYTHONPATH.

Hmm... that does not seem to be the issue. This is a mechanism that has been unreliable for a while. I am going to use a workaround that will make it less susceptible (hopefully) to difference in environment.

I believe this should work now, but if you have any  more problems just reopen the issue.

The issue is resolved. Thanks!


Use parallel gzip (pigz) whenever possible

With this, ConcatVCF (with tool=='haplotypecaller') on genomic VCFs is down to
3h30m from previously 3h50m.

I'll update the container to fix the build

ConcatVCF is now working, the build should finish around 20 min


software_spec: handle renamed optional formulae.

In this case: create not just the Option automatically (with the correct, new name) but also a DeprecatedOption to map from the old name.

This can't really work as expected 😭


REFERENCE is under the ADD context menu

Adding a reference to the project from the test project requires to click on ADD, then REFERENCE

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 107f3c03-dac2-0226-d5c1-f2f49daa413d
Version Independent ID: aaf80310-28eb-462b-d4f1-6b97a8abe260
Content: Get started with unit testing - Visual Studio
Content Source: docs/test/getting-started-with-unit-testing.md
Product: visual-studio-windows
Technology: vs-ide-test
GitHub Login: @gewarren
Microsoft Alias: gewarren

Also, default VS Console app is created without any public members, so it can't be referenced in HelloWorldTests code, out of the box


Code Folding Occasionally Breaks

Description
What steps will reproduce the problem?

The problem is that, occasionally, the arrow for code folding collapse and expansion disappears. This renders the code there inaccessible from the editor. The editor still grays out the function name, but it will not be expandable. The arrow only seems to disappear after collapsing a code block/function/class. This doesn't happen everytime that I collapse the code block. I don't know the exact order of clicks and where those clicks take place that make this issue manifest.
 Thanks!

@ccordoba12 @andfoy a gif of the error (it involves the use of the option to move a line up in the Editor):

it involves the use of the option to move a line up in the Editor

This is really cool to know. Thanks a lot @dalthviz!

Hi I am also facing problems with code fold.
I would like to know how can I disable this option.
Every time we remove line it does not follow the command that could demand code folding.


gradle ability to declare resources filtering in a generic way

Fix #9405

After the review and merge here, I can implement the gradle spring-boot-local-profile support in a new PR, WDYT?

LGTM :-)

LGTM :-)

Awesome!!! Thanks 😁 😊 🫂


Rotate issue on iOS only

I have an app that is  by design always limited to DeviceOrientation.portraitUp. We don't allow any other orientations except for one screen, which is used as PDF or Image viewer, I want to allow ONLY this view to rotate freely. It works fine on Android but not on iOS.
I have added this in initState:
     SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp, DeviceOrientation.landscapeRight, DeviceOrientation.landscapeLeft]);
in that case, all good on Android, but no effect on iOS it's like it has only DeviceOrientation.portraitUp
if I do:
if (Platform.isIOS) {
      SystemChrome.setPreferredOrientations([DeviceOrientation.landscapeRight, DeviceOrientation.landscapeLeft]);
    }

That allows landscape rotations but I cannot do portrait...
Any ideas?
Not mentioned but I do do:
void dispose() {
    SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]);
    super.dispose();
  }

Hello @SwiftyFlow. Thank you for filing this issue. Can you please provide the following information?

A complete and minimal, reproducible example. Ideally, a single main.dart file that can be run directly.
The output of flutter doctor -v
The output of flutter run -v

Please provide the information in the form of text. See how to make collapsible sections with Markdown here.

flutter doctor -v
[✓] Flutter (Channel master, 3.6.0-12.0.pre, on macOS 12.6 21G115 darwin-x64, locale en-AU)
• Flutter version 3.6.0-12.0.pre on channel master at /Users/flowpottevin/Desktop/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 02de12947a (8 days ago), 2022-11-29 22:57:31 -0500
• Engine revision d5690468da
• Dart version 2.19.0 (build 2.19.0-443.0.dev)
• DevTools version 2.20.0
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc1)
• Android SDK at /Users/flowpottevin/Library/Android/sdk
• Platform android-33, build-tools 33.0.0-rc1
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14B47b
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
[✓] VS Code (version 1.74.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.54.0
[✓] Connected device (2 available)
• iPhone 14 Pro (mobile) • 3E76B56C-2A9E-4FD3-82AF-865D9EBB286A • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
• Chrome (web)           • chrome                               • web-javascript • Google Chrome 108.0.5359.94
[✓] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!

CLICK ME

flutter run -v:
Not allowed to give private company data

Please provide a code sample as mentioned in https://github.com/flutter/flutter/issues/116711#issuecomment-1342633418

@SwiftyFlow The code you provided is long and complex. Please try to simplify the example you are providing to have the minimal code to reproduce this issue

If I don't give the full logic how can we spot the error?

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:google_fonts/google_fonts.dart';

void main() {
  WidgetsFlutterBinding.ensureInitialized();

  SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]).then((_) {
    runApp(const MyApp());
  });
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        appBarTheme: const AppBarTheme(systemOverlayStyle: SystemUiOverlayStyle.light),
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
      routes: {
        SecondScreen.routeName: (ctx) => const SecondScreen(),
      },
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text(widget.title),
        ),
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              const Padding(
                padding: EdgeInsets.all(20),
                child: Text(
                  'This screen should not rotate. Notice some kind of glitch when coming back from second screen in landscape. And also if coming back in portrait but then tries to rotate in landscape here.',
                  textAlign: TextAlign.center,
                ),
              ),
              ElevatedButton(
                onPressed: () {
                  Navigator.of(context).pushNamed(SecondScreen.routeName);
                },
                child: const Text('Go to second screen'),
              )
            ],
          ),
        ));
  }
}

class SecondScreen extends StatefulWidget {
  static const routeName = '/second-screen';

  const SecondScreen({Key? key}) : super(key: key);

  @override
  State<SecondScreen> createState() => _SecondScreenState();
}

class _SecondScreenState extends State<SecondScreen> {
  @override
  void initState() {
    super.initState();

    SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp, DeviceOrientation.landscapeRight, DeviceOrientation.landscapeLeft]);
  }

  @override
  void dispose() {
    SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]);

    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Second Screen'),
      ),
      body: const Center(
        child: Padding(
          padding: EdgeInsets.symmetric(horizontal: 20),
          child: Text(
            'Only this screen should be able to rotate but it only does the very first time it shows. Never after...\n\nOnly fix: fully restart the app.',
            textAlign: TextAlign.center,
          ),
        ),
      ),
    );
  }
}

Colours removed that's all I can do

Triage report
I can reproduce this issue on Master (3.7.0-5.0.pre.26) on iOS only

Code Sample (Same as OP)
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() {
  WidgetsFlutterBinding.ensureInitialized();

  SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]).then((_) {
    runApp(const MyApp());
  });
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        appBarTheme: const AppBarTheme(systemOverlayStyle: SystemUiOverlayStyle.light),
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
      routes: {
        SecondScreen.routeName: (ctx) => const SecondScreen(),
      },
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text(widget.title),
        ),
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: <Widget>[
              const Padding(
                padding: EdgeInsets.all(20),
                child: Text(
                  'This screen should not rotate. Notice some kind of glitch when coming back from second screen in landscape. And also if coming back in portrait but then tries to rotate in landscape here.',
                  textAlign: TextAlign.center,
                ),
              ),
              ElevatedButton(
                onPressed: () {
                  Navigator.of(context).pushNamed(SecondScreen.routeName);
                },
                child: const Text('Go to second screen'),
              )
            ],
          ),
        ));
  }
}

class SecondScreen extends StatefulWidget {
  static const routeName = '/second-screen';

  const SecondScreen({Key? key}) : super(key: key);

  @override
  State<SecondScreen> createState() => _SecondScreenState();
}

class _SecondScreenState extends State<SecondScreen> {
  @override
  void initState() {
    super.initState();

    SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp, DeviceOrientation.landscapeRight, DeviceOrientation.landscapeLeft]);
  }

  @override
  void dispose() {
    SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]);

    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Second Screen'),
      ),
      body: const Center(
        child: Padding(
          padding: EdgeInsets.symmetric(horizontal: 20),
          child: Text(
            'Only this screen should be able to rotate but it only does the very first time it shows. Never after...\n\nOnly fix: fully restart the app.',
            textAlign: TextAlign.center,
          ),
        ),
      ),
    );
  }
}

Related to flutter/engine#36874

I don't really get what I need to do...

@SwiftyFlow thank you for the detailed report, you made it easy to track down!  The fix has merged at https://github.com/flutter/engine/pull/38230, and you can follow the instructions at https://github.com/flutter/flutter/wiki/Where's-my-Commit%3F#finding-the-framework-commit-that-contains-engine-commit-x to monitor when it will be available in Flutter.  If you validate the fix, let us know here, otherwise there's nothing more for you to do. 🙂

On Flutter 3.7.3 still there is an issue with this


ICRC-2 Expiration Inconsistencies & long-term unused approval allowance build-up

Scenario:

At time t, principal-A calls icrc2_approve(spender: principal-B, amount: 10, expiration: t+4).
At time t+2, principal-A calls icrc2_approve(spender: principal-B, amount: 20, expiration: t+9).
At time t+3, icrc2_allowance(account: principal-A, spender: principal-B) -> { allowance: 30; expires_at: t+9; }.
At time t+5, icrc2_allowance(account: principal-A, spender: principal-B) -> { allowance: 30; expires_at: t+9; }.
At time t+6, principal-B calls icrc2_transfer_from(from: principal-A, to: principal-B, amount: 17);
At time t+7, icrc2_allowance(account: principal-A, spender: principal-B) -> { allowance: 13; expires_at: t+9; }.

In this scenario, the first approval made at time t never got transferred (because principal-B didn't need it, or principal-B's auction/sale sold-out/finished). Most of the second approval was transferred at time t+6. At time t+7, principal-B still has the allowance of the first approval even after the first approval's expiration-time of t+4.
Since most unused approval allowances will not be reset because there is a fee to lower an allowance or to reset an allowance to 0 and because why make the extra call and because most will expect the ledger to expire an approval allowance at the set expiration time, the above scenarios can add up in the long term where spenders have huge allowances from built-up unused approvals because the expirations carried over to the latest approvals.
Possible Solutions:
a: Remove the expiration option from an approval. This will remove the expiration inconsistencies but is still susceptible to spenders building up huge allowances from unused approvals.
b: Honor each approval's expiration by separating the allowances of each approval. To transfer_from an account, a spender must tell the ledger the block-height/id of the approval.
changes:

type TransferFromArgs = record {
    from : Account;
    to : Account;
    // new field
    approval_id: nat;
    amount : nat;
    fee : opt nat;
    memo : opt blob;
    created_at_time : opt nat64;
};

type AllowanceArgs = record {
    account : Account;
    spender : principal;
    approval_id: nat; // new field
};

In the ledger:
type ApprovalId = BlockHeight;

static APPROVALS: Map<(Account,Spender,ApprovalId), Approval>;

struct Approval {
    remaining_allowance: u64,
    expires_at: u64,
}

Let's go through the scenario above with this solution in place.

At time t, principal-A calls icrc2_approve(spender: principal-B, amount: 10, expiration: t+4), the ledger adds a new entry in the APPROVALS map: APPROVALS.insert((principal-A-account, principal-B-spender, block_height_1), Approval { available_allowance: 10, expires_at: t+4 }).
At time t+2, principal-A calls icrc2_approve(spender: principal-B, amount: 20, expiration: t+9), the ledger adds a new entry in the APPROVALS map: APPROVALS.insert((principal-A-account, principal-B-spender, block_height_2), Approval { available_allowance: 20, expires_at: t+9 }).
At time t+3, icrc2_allowance(account: principal-A, spender: principal-B, approval_id: block_height_1) -> { allowance: 10; expires_at: t+4; }. icrc2_allowance(account: principal-A, spender: principal-B, approval_id: block_height_2) -> { allowance: 20; expires_at: t+9; }.
At time t+5, icrc2_allowance(account: principal-A, spender: principal-B, approval_id: block_height_1) -> { allowance: 0; expires_at: null; }. icrc2_allowance(account: principal-A, spender: principal-B, approval_id: block_height_2) -> { allowance: 20; expires_at: t+9; }.
At time t+6, principal-B calls icrc2_transfer_from(approval_id: block_height_2, from: principal-A, to: principal-B, amount: 17); transfer_from success.
At time t+7, icrc2_allowance(account: principal-A, spender: principal-B, approval_id: block_height_1) -> { allowance: 0; expires_at: null; }. icrc2_allowance(account: principal-A, spender: principal-B, approval_id: block_height_2) -> { allowance: 3; expires_at: t+9; }.

Separating each approval by its id, and requiring a spender to specify the approval-id when calling transfer_from, lets the ledger honor the expiration of an approval allowance, and stops a build-up of unused approval allowances.

Is solution-b the best way to stop a build-up of unused approval-allowances?
Within solution-b, Is it a good idea to have a maximum expiration time (30-days, 1-year, ...) on approvals?

Would a periodic "clean-up" action by the user (or her wallet) to reduce the superfluous approvals not be able to achieve the same, while keeping the much easier-to-implement expiration semantics?

https://github.com/dfinity/ICRC-1/pull/101

https://github.com/dfinity/ICRC-1/pull/109 solves for this scenario by overwriting the approval allowance with the approval amount in the call instead of adding onto it.


3D only mag fusion: use declination calculated from magnetic field states

When using 3D mag fusion only I noticed that the magnetic declination was not calculated from the actual magnetic field states. So basically the code would never step into this if statement:
https://github.com/PX4/ecl/blob/master/EKF/ekf_helper.cpp#L756
I realized that this was because the _flt_mag_align_complete flag was never set when using 3D mag fusion only.

@priseborough will provide a log, thanks!

@RomanBapst Looking forward to the matching Firmware PR!


GUVNOR-2540: Guided Decision Table Editor: LockManager: Expose the ability to programmatically acquire a lock

See https://issues.jboss.org/browse/GUVNOR-2540

+1, thanks. (I just altered some JavaDocs (my own) that were related to this).

master: 3728def577a0d7c339f57d907bb69cfd12918bbe

@csadilek Merged into master (with modificiations). This PR can be closed.


Add auto merge

@conda-forge-admin, please add bot automerge

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added bot automerge in conda-forge/rich-feedstock#3.


Cache CNI CNS without Windows update

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.313%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2285

Relevant Lines:
2881

💛  - Coveralls

Closing as Windows test in other PR was flaky -- I merged the other one


garage: 0.8.1 -> 0.8.2

Description of changes
https://git.deuxfleurs.fr/Deuxfleurs/garage/releases/tag/v0.8.2
Remove workaround for failing tests, upstream fixed them in https://git.deuxfleurs.fr/Deuxfleurs/garage/issues/526

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

This is failing eval because garage_0_8_1 has been removed

Thanks, fixed it


feat: Integrate ant d table component into DatasetPanel

SUMMARY

Integrates a re-usable antd based Table into the DatasetPanel for new Dataset creation workflow
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

https://user-images.githubusercontent.com/5614266/198159322-a365fe76-8e89-497b-9329-c3e1d6b0b627.mov
TESTING INSTRUCTIONS

Checkout this PR
run Superset and navigate to: http://localhost:9000/dataset/add/?testing
Select a database, schema, then table
You should see table columns appear in table

You can also interact with the DatasetPanel in isolation via storybook:

Checkout this PR
run: npm run storybook
navigate to http://localhost:6006/?path=/docs/supset-app-views-crud-data-dataset-datasetpanel--basic

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[X] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

/testenv up


chore: Create custom CodeQL configuration

Motivation
The basic minimal GitHub config, requiring a custom config
Modifications
Add codeql.yml
Result
TBD
Related Issues
N/A

Removed the c-ccp build for exllamav2_kernels as it needs a custom build configuration. Python works out of the box, so, closing this PR.


Gitbook Relative Links Broken

https://github.com/GitbookIO/gitbook/issues/1684
I have been trying to do this with https://github.com/shakacode/react_on_rails, and the created links point to a markdown file and the gitbook site renders the file as raw text.
Please see the following:

https://github.com/shakacode/react_on_rails  - github source

Search for "Code Splitting" which points to https://github.com/shakacode/react_on_rails/blob/master/docs/additional-reading/code-splitting.md

Now try on the gitbook https://shakacode.gitbooks.io/react-on-rails/content/

Search for "Code Splitting" which points to: https://shakacode.gitbooks.io/react-on-rails/content/docs/additional-reading/code-splitting.md

The gitbook case is suboptimal compared to just using github.com.
CC: @Judahmeek

Looks to me like the gitbook is out of date. Both the Code Splitting and the AngularJS links are missing from the side bar.

Seems fixed @Judahmeek!


Tweaks for ease of use

Updated Dockerfiles to use lambci/lambda:build-nodejs8.10
Updated CFN Template to allow usage of existing ACM Certificate
Resolves #8

Will re-open when I fully address the login fix.

Using the dependencies from the upstream https://github.com/thumbsup/lambda-cloudfront-cookies resolved my login issues.

Thanks!


Client: Add metrics to product output UI

Display the metrics from the estimate method on the layerManager controller.  The call should occur anytime the AOI changes, or the min/max levels are modified

The UI is now displaying the metrics for the cuts.  I added two new tabs to the product output modal to display the information.


Third level category internal server error

Bug report
Title
Third level category internal server error
Issue Description
Error 500 at creation of a third level category
https://demo.bagisto.com/bagisto-common/admin/catalog/categories/create
Preconditions
Please provide as detailed information about your environment as possible.
1. framework master Version.

Steps to reproduce
1. Enter as admin
2. Go in "Catalog"
3. Go in "Category"
4. Create a new third level category inside a node secondary level(i.e. Yoga)

Expected result
A visible third level category
Actual result
500 | Server Error

@nicobi83
this issue exists in demo, please check the same in your local instance.
In case you're getting the same on your local instance, please let me know.

Few days ago I had added a new third level category and I didn't have any issue.
In my local environment I wanted test if it was fixed bug #4183 after last pull done yesterday.

@nicobi83
are you testing on bagisto latest version or from master branch??
as the third level category is working fine with latest version.

From master branch.
What is the latest version? 1.2.0?

@nicobi83
Yes latest version is 1.2.0
once this PR https://github.com/bagisto/bagisto/pull/4183 will get merge then, you check retest the category issue again.
Thanks

Ok, the pull request #4183 was not merged.
Can I solve #4183 ?

@nicobi83
The PR is already opened by @devansh-webkul and soon it will be merged.
You may freely work on any other issue.
Thanks

@nicobi83
Closing this as we are not getting any internal server error on third level category.
Hope this is fix at your end.

I keep getting this error...image size doesn't seem to be a factor

nodejs wasn't installed 🤣


[FEATURE]: Add Arktype extension for validation

Describe what you want
I would like to request the addition of an Arktype extension to the Drizzle repository. Arktype is a new validation library that offers a similar approach to Zod, Valibot, and Typebox, but with unique features and great potential.
Links:

GitHub: Arktype Repository
Website: Arktype

The creator of this amazing library is @ssalbdivad.
Given that Drizzle already supports Zod, Valibot, and Typebox, adding support for Arktype would be a valuable enhancement. Arktype's capabilities and new approach to validation could provide users with additional options and flexibility.
I want to clarify that this proposal is only because I like the library, as well as Drizzle, and I believe that both will make a great tandem.
Thank you for considering this request!

I would be happy to assist whoever is interested in tackling this!
The timing is good as I'm preparing to roll out 2.0. There is also a parallel issue in the ArkType repo:
https://github.com/arktypeio/arktype/issues/982


GUI Concept

draft implementation with empty connection to IVCT services

draft version shall not be integrated into Master branch


useForm invalidates: false does still result in refetch after submit

Describe the bug
Using below code to handle a form submission. After successful submission, the form query make a refetche even though invalidates: false is set (same behaviour is seen with invalidates: ["list"] and any other value)
We are using a custom GraphQL live provider using Apollo client.
Every mutation return the created/updated object it our application, so we want this to update the query data directly and skip this unwanted refetch.
Steps To Reproduce

Add a form using useForm hook:

const formProps = useForm<ICompany>({
        refineCoreProps: {
            meta: {
                fields: companyFields,
                environmentId: environment?.id
            },
            action: "edit",
            resource: resourceName,
            id: id,
            redirect: false,
            mutationMode: "pessimistic",
            invalidates: false as any
        },
        mode: "onChange",
        defaultValues: { id: id, ...defaultValues },
        resolver: ajvResolver(schema, undefined, { language: currentLocale })
    });

Submit form
See that query data is refetched in DevTools, after mutation is complete.

Expected behavior
In step 3, no refetch was expected after submission success.
Screenshot
No response
Desktop
Windows 11, Chrome
Refine v4
Mobile
No response
Additional Context
No response

Hello @JEkedorff, I guess you have liveMode: auto, which invalidates query when it receives live event. You can change it to manual if you want to disable refetching.
We want to improve this flow and update query cache instead of triggering refetch in the future.

Hello again @JEkedorff,
We've discussed this one internally with core team and agreed that there is no consistent way to update query cache with live event data. We could append it to the end of the list but for example, your result might be in the middle of the list (you may have some server side custom order). So we can't guess which position to insert data coming from live provider.
I agree that passing invalidates: false gives a feeling that this shouldn't be invalidated, but it only prevents invalidate in useForm context.
These invalidation happens at the other side of the stack in the live provider.
We are creating some feature requests internally to explore options:

Maybe disable invalidates on resource level.
Also provide users a way to update their cache as they wish by giving user query cache and live provider event. So users can choose how to handle it.

Closing the issue as it's not a bug, we'll release improvements as a feature in the coming weeks.


Move "about" from build-docs to contribution

Move the "about" content files from the build-docs repo to this repo and then bring that content back into the build by reference

Could you review and close, @AnthonyYates ?


"Translate this page" feature fails to position  tags correctly.

Original

It looks like this when translated into Turkish.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3ffcaf54-ce86-1b30-e947-540bf07a54c3
Version Independent ID: 81267e97-e284-ff00-b081-476934538326
Content: Microsoft Edge release notes for Stable Channel
Content Source: edgeenterprise/microsoft-edge-relnote-stable-channel.md
Product: microsoft-edge
GitHub Login: @AndreaLBarr
Microsoft Alias: aguta

@niyazikeklik Hello!  Are the screenshots from the Microsoft Edge Enterprise Documentation site (https://docs.microsoft.com/en-us/DeployEdge/)?
If you are having an issue with "Translate this page" on a different site,  please submit feedback and diagnostic data through the browser? ("..." menu > Help and feedback > Send feedback).  Thanks!

@niyazikeklik Closing issue.


Added Guard pickpocket entry swap

edit: jagex compliances... Swapped talk-to with pickpocket for H.A.M. guards, should be 69% compliant in the current format. Once Npc attack option is disabled via ingame options, left click pickpocketing should work.

From https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features:

####Menu Entry Swapping

Pickpocket on non-H.A.M. members: Not supported by other 3rd party clients, and absurdly powerful when blackjacking

It's supposed to be swapping the talk-to option, not attack.
Wouldn't it be better to just do if (config.swapPickpocket() && target.contains("h.a.m.") || target.contains("guard") ?

My bad, wasn't fully familiar with Jagex compliances. Thanks for pointing that out.

What is the left-click option for HAM guards when NPC attack option is hidden? The reason this feature was previously limited to HAM members is because they were the only NPC which were frequently pickpocketed and did not have a talk-to option which became the left-click when NPC attack options were disabled. (eg. It became a convenience feature to not require changing NPC attack options rather than a feature which provided something unattainable in the vanilla client)

If you hide attack, left click on ham guards becomes talk-to
I don't think extending the functionality to ham guards would be that overpowered, the main concern was with blackjacking

Still, kinda would love the left click pickpocket for H.A.M. guards tho.

Sounds good to me. Got an elegant implementation under that furcout of yours? I know very little of runelite api, so yeah...

Correct me if im wrong but there are only 2 types of H.A.M. npc's with pickpocket option, rendering your (target.contains("h.a.m.") part pointless under if (option.equals("attack")) statement returning us back to square one :^

I mean change that line instead of the change you made to the file, cause the option is to swap talk-to with pickpocket, not attack with pickpocket

My misunderstanding. Thanks for pointing those things out, perhaps this solution will please mod ash

Pickpocket swapping is iffy since it impacts (afk?) exp rates. So far we have only swapped what other clients swap. I probably do not want to swap anything else pickpocket related.

You can get left-click pickpockets with HAM members by changing attack settings.

You actually can't. That's why we have it in the plugin in the first place. In the vanilla client it's not possible to left click pickpocket ham members

Would be nice to have this feature

This should be closed as it falls under Modifies menu options for pickpocketing, such as swapping 'Pickpocket' and 'Talk-to'  here https://secure.runescape.com/m=news/another-message-about-unofficial-clients?oldschool=1


{CI} Refine GitHub issue template

Delete the old GitHub issue template
Disable blank issue template
Use new issue template

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

CI


Update and enhance README.md

Task:

[ ] Ask to be assigned to the issue
[ ]  Get Assigned to the issue
[ ] Review the project.
[ ]  Update the README.md
[ ] Readme has info about the python script add info about frontend as well.
[ ]  Create a pull request after fixing the issue
[ ]  Be patient while we review

Strictly do not create a pull request if you are not assigned.

Please do assign me this issue.

Please do assign me this issue.

@ppap1771 Kindly assign me to this issue.

@Te-ne  we assign issues on first come first serve basis so the the assignee doesn't respond it will be assigned to you.

@ppap1771 Okay

@ppap1771 can you assign me to this issue.

@Pakhi-v  as you have not responded to this issue i quite a while I am obliged to hand the issue to the next person. If you are working on it then just let me know.

So sorry I was not able to respond you and work on this issue due to some urgent work I am going through. You can assign to someone.
So sorry again

please fix the typo in the readme pip3 install -r requirements.txt but the name of the file is requirement.txt @Te-ne

Please do assign me this issue @ppap1771


Sample yaml doesn't work k8s.io/docs/tasks/configure-pod-container/extended-resource/

Problem:
Using the following tutorial:
https://kubernetes.io/docs/tasks/configure-pod-container/extended-resource/
Run
kubectl apply -f https://k8s.io/examples/pods/resource/extended-resource-pod.yaml
The pod does not start due to:
Insufficient example.com/dongle
Proposed Solution:
I don't know
Page to Update:
https://kubernetes.io/docs/tasks/configure-pod-container/extended-resource/
Kubectl Version: 1.18.5
Minikube Version: 1.11.0
OS:
Ubuntu 18.04

Did you complete the precondition?
https://kubernetes.io/docs/tasks/administer-cluster/extended-resource-node/

/triage support

Did you complete the precondition?
https://kubernetes.io/docs/tasks/administer-cluster/extended-resource-node/

No

If there is no update, I will close it.
/close


Sort is slow with Fulltext index

Regards,
The case is: collection with 65000 docs with fulltext index in 'name' field. Filtering using 'text' is fast (about 40ms) but using sorting is slow (about 3secs in the MacPro). And also we are limiting results to 500.
Is it normal or can it be a bug or are we missing something?
code:
Nitrite.builder().compressed().filePath("xxx.db").openOrCreate("user","pwd")
createIndex("name", IndexOptions.indexOptions(IndexType.Fulltext))
insert(document)
find(FindOptions.sort(field, SortOrder.Ascending).thenLimit(0, 500))
Thanks a lot.

@aespelt what you are getting is normal and the timing for sort does not depend on the limits.


How to send values ?

Hello , thank you for this ha integration.
I am having a small problem understanding how to setup the cmi to recieve values from home assistant.
i setup a sensor from my heating system to send to heat on to the cmi and then to the uvr16x2 to start or stop pumping.
but i dont understand where i should configere the data in the cmi for the expected data off the sensor to be recieved.
I can recieve the values from the uvr16x2 verry nice thanks again.
hope some one can guide me a litle bit.
Regards marco van oort

If you have configured the sensor in the integration for sending, you can simply read in the value as CAN input as described here: https://github.com/DeerMaximum/Technische-Alternative-CoE/issues/42#issuecomment-1883439359
If you need more help I am happy to give you more information

Hi, after some fidling adding both the node id from my uvr16x2 nr1 and cmi nr56 and coe server nr25 i noticed that a new can node pupped up in the cmi nr25.
Right after i started the coe server that made me realize it is a virtual coe device.
And that i dont have to setup the cmi as i had to do using the modbus.
i then linked the analog input from the uvr16x2 to the virual node 25 and network port 1 and lord and behold the value is recieved.
But i do get error message displayed when clicking in the cmi on the virtual node.
And coe server complains about a nummer must be below 75?

Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/aiohttp/web_protocol.py", line 433, in _handle_request
resp = await request_handler(request)
File "/usr/lib/python3.9/site-packages/aiohttp/web_app.py", line 504, in _handle
resp = await handler(request)
File "/usr/lib/python3.9/site-packages/aiohttp_pydantic/view.py", line 36, in _iter
return await getattr(self, method_name.lower())()
File "/usr/lib/python3.9/site-packages/aiohttp_pydantic/view.py", line 132, in wrapped_handler
return await handler(self, *args, **kwargs)
File "/opt/ta-coe/ta_coe/httpserver.py", line 112, in get
analog=[
File "/opt/ta-coe/ta_coe/httpserver.py", line 113, in
ValueTypeModel(value=x["value"], unit=x["unit"])
File "/usr/lib/python3.9/site-packages/pydantic/main.py", line 341, in init
raise validation_error
pydantic.error_wrappers.ValidationError: 1 validation error for ValueTypeModel
unit
ensure this value is less than or equal to 75 (type=value_error.number.not_le; limit_value=75)
Dont know what that means.
Thank you for your response if i can assist in any way i will try.
regards marco

That you get an error message when you press the CoE Can node is normal.
For the error that the number cannot be greater than 75, I need the debug logs from the CoE server addon when the CoE value is sent.
If you could send me these I can fix the error.

Hello okay,
Thank you.
But i start to think it not really an error but mis configuration on my side.
Because i am do not totally understand how it works ore should work.
I tryed to get the log from homeassistant.
But when i try to download the log nothing happens.
So need to figure out whats the problem with that.
Marco van Oort
Directeur
G.E.N.M Schoonmaak & Bedrijfsdiensten
Braamsluiper 31
3435 BB Nieuwegein
www.genmschoonmaak.nlhttp://www.genmschoonmaak.nl/
<EMAIL_ADDRESS>tel:<PHONE_NUMBER>tel:030 259 1921
Op 24 feb 2024 om 17:26 heeft DeerMaximum @.***> het volgende geschreven:

That you get an error message when you press the CoE Can node is normal.
For the error that the number cannot be greater than 75, I need the debug logs from the CoE server addon when the CoE value is sent.
If you could send me these I can fix the error.
—
Reply to this email directly, view it on GitHubhttps://github.com/DeerMaximum/Technische-Alternative-CoE/issues/57#issuecomment-1962415590, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOGCO4MKPX4PJCICAL7K2H3YVIID3AVCNFSM6AAAAABDRPROMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGQYTKNJZGA.
You are receiving this because you authored the thread.Message ID: @.***>

CoE Installation.pdf
Hello,
it is just a special way of thinking, when working with ha and UVR.
Some weeks ago i had a similar problem. Together with a user from sweden, we created this 0.9 Version of a manual for dummies.
Have fun with it!
RT

@romeocontrol
Hi, Thanks for the "manual for dummies". It is very usefull.
If i understand correct, the description is for receiving data from the UVR/cmi.
The topic was regarding sending data.
Right now i get all data via  the  other great integration from DeerMaximum.
But sending data would be very usefull.
is there a newer version of the file which includes also sending data ?
thanks in advance

Of course. But it does also need a bit tricky thinking.

set it up in UVR, not in CMI.
set it up in TA-COE Integration in homeassistant.
Be sure to install the COE Integration AND COE Add-on
Take care of the correct NodeNumbers and Numbers of Input.
There ist no easy way to re-arrange the inputs in the integration, you have to delete one and set it up again. Take care of the number of input.
Greetings RT

@thefox69 The integration and TA should be able to handle decimal numbers. But you'll probably need to use a point as separator.

@DeerMaximum At first great integrations (using both of them)
Tried  to change the decimal setting in my user profile (found only this option in HA),
but seems it will not have an imapct (as expected).
On System level i haven`t found an option to change the separator.
Could try to use a text helper, but not sure if the integration can handle text data.
Do you have any hint, how i can handle decimals (i guess Germans  should have the same problem like me in Austria) ?

@thefox69 I took a quick look and tried it myself. The values in the CoE Status page don't display any decimals, but when you use the value in a device the decimal is there. You can use the sensor from Home Assistant as it is.

@DeerMaximum Unfortunatelly on my old UVR1611 the figures are similar to the COE Status, no decimals

Seems my rooms will stay cold when the UVR mesasures 194°C ;-)

@thefox69 With CoE version do you use? If you use V2 it may be worth trying to switch to V1. If you already using V1 I think then you could try to make a template to multiply the value by 0,1 or so to try to correct the value.

@thefox69 I don't know if your UVR supports this, but my UVR16x2 supports to add functions. So you could process the wrong CoE values and correct to something like 19° (from 194) by multiply by 0,1.

@DeerMaximum Thanks for Workarrounds.
The old UVR1611 do not support math functions. Im Using COE V1, therefore tried your proposal with a template to multiply with 0.1. I get now in the correct Value in CMI & UVR. Both without digits. But better than complete wrong data


Should add inlineDynamicImports: true for UMD builds

Describe the bug
UMD doesn't support lazy loading and dynamic imports, but ES and CJS do. However, since I can't specify different rollupOptions for different formats, I can't build them (es, cjs, umd) all at once.
If I build them at once and don't include inlineDynamicImports: true in my rollupOptions, UMD will fail to build. However, if include inlineDynamicImports: true, the dynamic imports in the es and cjs targets will be removed as well.
Not Including inlineDynamicImports:
vite v4.0.3 building for production...
✓ 1559 modules transformed.
dist/style.css                     36.83 kB │ gzip:  10.64 kB
dist/tg-blog.es.js                  0.34 kB │ gzip:   0.23 kB
dist/marker-shadow-eea80fe0.js      0.89 kB │ gzip:   0.73 kB
dist/marker-icon-b2ca459f.js        2.02 kB │ gzip:   1.58 kB
dist/marker-icon-2x-b9d2094a.js     3.35 kB │ gzip:   2.55 kB
dist/leaflet-src.esm-12ebbbc8.js  187.71 kB │ gzip:  47.08 kB
dist/Location-aed7870c.js         225.23 kB │ gzip:  53.13 kB
dist/index-43d9e905.js            397.98 kB │ gzip: 120.11 kB
...
[vite:esbuild-transpile] Transform failed with 1 error:
tg-blog.umd.js:672:11: ERROR: Expected ";" but found "."

Expected ";" but found "."
670|    };
671|
672|    var index.commonjsGlobal = typeof globalThis !== 'undefined' ? globalThis : typeof window !== 'undefined' ? window : typeof global !== 'undefined' ? global : typeof self !== 'undefined' ? self : {};
   |             ^
673|
674|    function getAugmentedNamespace(n) {

error during build:
Error: Transform failed with 1 error:
tg-blog.umd.js:672:11: ERROR: Expected ";" but found "."
    at failureErrorWithLog (/Volumes/macWorkspace/Web/tg-blog/node_modules/esbuild/lib/main.js:1596:15)
    at /Volumes/macWorkspace/Web/tg-blog/node_modules/esbuild/lib/main.js:833:29
    at responseCallbacks.<computed> (/Volumes/macWorkspace/Web/tg-blog/node_modules/esbuild/lib/main.js:697:9)
    at handleIncomingPacket (/Volumes/macWorkspace/Web/tg-blog/node_modules/esbuild/lib/main.js:752:9)
    at Socket.readFromStdout (/Volumes/macWorkspace/Web/tg-blog/node_modules/esbuild/lib/main.js:673:7)
    at Socket.emit (node:events:513:28)
    at addChunk (node:internal/streams/readable:324:12)
    at readableAddChunk (node:internal/streams/readable:297:9)
    at Readable.push (node:internal/streams/readable:234:10)
    at Pipe.onStreamRead (node:internal/stream_base_commons:190:23)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Including inlineDynamicImports:
vite v4.0.3 building for production...
✓ 1559 modules transformed.
dist/style.css       36.83 kB │ gzip:  10.64 kB
dist/tg-blog.es.js  818.84 kB │ gzip: 225.87 kB
dist/tg-blog.cjs.js  627.70 kB │ gzip: 205.63 kB
dist/tg-blog.umd.js  627.79 kB │ gzip: 205.59 kB
vite v4.0.3 building for production...

My current workaround is to add an environment variable UMD, change vite config according to the environment variable, and build twice. (vite build && UMD=1 vite build) This works but it runs module transformation twice, which takes a lot of time.
Part of vite.config.ts
const umd = !!process.env.UMD
const demo = !!process.env.BUILD_DEMO

const cfg: UserConfigExport = {
  ...
  build: demo ? {} : {
    lib: {
      entry: path.resolve(src, 'index.ts'),
      name: 'TgBlog',
      formats: umd ? ['umd'] : ['es', 'cjs'],
      fileName: (format) => `tg-blog.${format}.js`,
    },
    rollupOptions: {
      // external modules won't be bundled into your library
      external: ['vue'],
      output: {
        // disable warning on src/index.ts using both default and named export
        exports: 'named',
        // Provide global variables to use in the UMD build
        globals: {
          vue: 'Vue',
        },
        inlineDynamicImports: umd,
      },
    },
    emptyOutDir: false, // to retain the es, cjs build
  },
}

Successful Build Log
> yarn build
yarn run v1.22.19
$ rimraf dist && vue-tsc && vite build && UMD=1 vite build
vite v4.0.3 building for production...
✓ 1559 modules transformed.
dist/style.css                     36.83 kB │ gzip:  10.64 kB
dist/tg-blog.es.js                  0.34 kB │ gzip:   0.23 kB
dist/marker-shadow-eea80fe0.js      0.89 kB │ gzip:   0.73 kB
dist/marker-icon-b2ca459f.js        2.02 kB │ gzip:   1.58 kB
dist/marker-icon-2x-b9d2094a.js     3.35 kB │ gzip:   2.55 kB
dist/leaflet-src.esm-12ebbbc8.js  187.71 kB │ gzip:  47.08 kB
dist/Location-aed7870c.js         225.23 kB │ gzip:  53.13 kB
dist/index-43d9e905.js            397.98 kB │ gzip: 120.11 kB
dist/tg-blog.cjs.js                  0.49 kB │ gzip:   0.28 kB
dist/marker-shadow-8f64c412.cjs      0.96 kB │ gzip:   0.79 kB
dist/marker-icon-ea2516b7.cjs        2.09 kB │ gzip:   1.64 kB
dist/marker-icon-2x-c96d03d7.cjs     3.42 kB │ gzip:   2.61 kB
dist/leaflet-src.esm-28c838de.cjs  148.98 kB │ gzip:  42.90 kB
dist/Location-c3500fca.cjs         161.68 kB │ gzip:  47.21 kB
dist/index-d3664e93.cjs            310.05 kB │ gzip: 110.19 kB
vite v4.0.3 building for production...
✓ 1559 modules transformed.
dist/style.css        36.83 kB │ gzip:  10.64 kB
dist/tg-blog.umd.js  627.79 kB │ gzip: 205.59 kB
✨  Done in 37.81s.

Reproduction
https://github.com/one-among-us/tg-blog
System Info
System:
    OS: macOS 13.0.1
    CPU: (36) x64 Intel(R) Xeon(R) CPU E5-2696 v3 @ 2.30GHz
    Memory: 13.60 GB / 128.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.3.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.2.0 - /usr/local/bin/npm
  Browsers:
    Firefox: 107.0.1
    Safari: 16.1
  npmPackages:
    @vitejs/plugin-vue: ^4.0.0 => 4.0.0
    vite: ^4.0.3 => 4.0.3

Used Package Manager
yarn
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I think it's unnecessary to add inlineDynamicImports explicitly as Vite will set it false when the format is umd and iife
https://github.com/vitejs/vite/blob/13ac37df8e135fe6b4990fac6f149a36a19e5409/packages/vite/src/node/build.ts#L590-L594
I tried to reproduce the https://github.com/one-among-us/tg-blog with a little tweak and I can't re-produce the issue.

change formats to formats: ['umd', 'es', 'cjs'],
delete inlineDynamicImports

Did I miss something? 🤔

Hmm weird, it happened to me on my macOS system but not on Linux. On Linux, UMD can build but dynamic imports don't split, maybe it's because inlineDynamicImports defaulted to true instead of false on macOS.

^ You can see that, with the same defineAsyncComponent(() => import("./Location.vue")) code, Location.cjs wasn't split to a separate file.

I tried to reproduce the https://github.com/one-among-us/tg-blog with a little tweak and I can't re-produce the issue.

I'm doing the same and it's still giving me the same error... weird. Can you show your logs and system information?

The previously working workaround for this is adding multiple rollupOptions as well: https://github.com/vitejs/vite/issues/2982
Can we just change the default for umd so that people in the future won't run into this?

Can we just change the default for umd so that people in the future won't run into this?

Vite already does that as @fi3ework said.

I'm doing the same and it's still giving me the same error... weird. Can you show your logs and system information?

I wasn't able to reproduce that error.
https://stackblitz.com/edit/github-xok5pw?file=vite.config.ts,package.json


feat(android): enable logging (llama.cpp, log.h) on debug mode

Currently the logs always pipe to /dev/null on Android, and it's difficult to change it depending on the device, so I use a patch to simply change the logs by use android/log.h.

Simply tested with tinystories model.


BUG: scipy.sparse.spmatrix lost most of its methods

Upon releasing 1.11.0 in conda-forge, we got a regression report from cvxpy pretty much right away:
>>> import scipy
>>> scipy.__version__
'1.11.0'
>>> import cvxpy
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/ubuntu/miniconda3/envs/algoenv/lib/python3.11/site-packages/cvxpy/__init__.py", line 18, in <module>
    import cvxpy.interface.scipy_wrapper
  File "/home/ubuntu/miniconda3/envs/algoenv/lib/python3.11/site-packages/cvxpy/interface/scipy_wrapper.py", line 37, in <module>
    method = getattr(spmatrix, method_name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: type object 'spmatrix' has no attribute '__div__'. Did you mean: '__dir__'?```

cvxpy does from scipy.sparse import spmatrix, and then tries to look for the following methods:
BIN_OPS = ["__div__", "__mul__", "__add__", "__sub__",
           "__le__", "__eq__", "__lt__", "__gt__"]

However, that class was renamed between 1.10.1 and 1.11.0, first to _sparray, then to _spbase, with the explicit caveat:

This class provides a base class for all sparse arrays.  It cannot be instantiated.  Most of the work is provided by subclasses.

The class spmatrix is still present in the scipy.sparse namespace, but it too now says:

This class provides a base class for all sparse matrix classes. It cannot be instantiated.  Most of the work is provided by subclasses.

I cannot tell if this was intentional, but it seem that spmatrix lost most of its methods.
Could you please take a look? @perimosocordiae @dschult @rossbar
CC @rgommers @noamgat

From looking at the code, it looks like cvxpy is monkey patching the spmatrix base class to overload operations on sparse matrices and your class?
https://github.com/cvxpy/cvxpy/blob/v1.3.1/cvxpy/interface/scipy_wrapper.py#L17
I'm not sure if this is exactly a bug in scipy, as I don't think inheritance or usage of the dunder methods of spmatrix is a documented feature of the class. I would note that this code also breaks (though not at import time) if any of the subclasses overrode the binary operators.

  Example
class A:
    def __init__(self, x):
        self.x = x

    def __add__(self, y):
        return self.x + y

class B(A):

    def __add__(self, y):
        return self.x + y + 1

BIN_OPS = ["__add__"]

def wrap_bin_op(method):
    """Factory for wrapping binary operators.
    """
    def new_method(self, other):
        print("new method!")
        return method(self, other)
    return new_method

for method_name in BIN_OPS:
    method = getattr(A, method_name)
    new_method = wrap_bin_op(method)
    setattr(A, method_name, new_method)

In [2]: A(1) + 1
new method!
Out[2]: 2

In [3]: B(1) + 1
Out[3]: 3

I would suggest that a more foolproof way for cvxpy to achieve this monkey patching would be to overload the actual instantiable classes themselves. Something like:
from scipy import sparse

from cvxpy.expressions import expression as exp

SPARSE_MATRIX_CLASSES = [
    sparse.csc_matrix,
    sparse.csr_matrix,
    sparse.coo_matrix,
    sparse.bsr_matrix,
    sparse.lil_matrix,
    sparse.dia_matrix
]
BIN_OPS = ["__div__", "__mul__", "__add__", "__sub__",
           "__le__", "__eq__", "__lt__", "__gt__"]

def wrap_bin_op(method):
    """Factory for wrapping binary operators.
    """
    def new_method(self, other):
        if isinstance(other, exp.Expression):
            return NotImplemented
        else:
            return method(self, other)
    return new_method

for cls in SPARSE_MATRIX_CLASSES:
    for method_name in BIN_OPS:
        method = getattr(cls, method_name)
        new_method = wrap_bin_op(method)
        setattr(cls, method_name, new_method)

So just adding another loop over the overload

However, that class was renamed between 1.10.1 and 1.11.0, first to _sparray, then to _spbase, with the explicit caveat:

I believe that caveat has been there for a while, and wasn't added recently.
https://github.com/scipy/scipy/blob/33e29d756153434d1c78f667c5b22f0a6413a956/scipy/sparse/base.py#L36-L39

Sorry about the breakage! It seems that the cvxpy issue has now been fixed. Do we need any action on the scipy side?

Do we need any action on the scipy side?

It's a bit of a grey area, arguably cvxpy were doing something that's not supported, though we try to explicitly deprecate any behaviour change before pulling the trigger (I appreciate that this can be hard in the depths of some class hierarchy, etc.).
Given that cvxpy has promptly fixed their end and is backporting this to their various stable releases, I think we could let this one go under "you need to break some eggs to make an omelette". ;-)
So I'm OK with closing this, but would suggest to leave it open for a few more days, so people can comment (esp. if they disagree), resp. for ease of discoverability if other users encounter the same issue.

I think I agree with @h-vetinari's take here. If no other complaints surface, we can close it.


Add support to disable parts of reportdata and other modules

In munkireport v2 i managed to disable parts of the module  "report data" and other modules that had parts i didnt want/need becuase of privacy concerns, but i v3 when i use the same method it causes a problem that clients cant connect.
Q: What are you trying to accomplish?
A: Not getting unwanted or not needed information into MunkiReport because of privacy concerns.
The way i used to do it in v2 was this way but that stopped working i v3 :confused: can i disable them in the config.php file?
// $this->rs['console_user'] = '';
// $this->rs['long_username'] = '';
// $this->rs['remote_ip'] = '';
A user named tuxedo gave me this solution, but a supported solution built into MunkiReport-PHP would be better.
// Remove serial_number from mylist, use the cleaned serial that was provided in the constructor.
unset($mylist['serial_number']);
    unset($mylist['console_user']);
    unset($mylist['long_username']);
    unset($mylist['remote_ip']);

I think the best way to handle this is to prevent the uploading of sensitive data on the client. To accomplish that, a filtering function could be build into the process method inreportcommon.
This would require that the admin puts filtering config on the clients that need it.

yes that would probably be even better since no unwanted or sensetive data ever leaves the client machine

Something changed in version 4.3.x so now the  "unset($mylist['console_user']);" dont work anymore is it possible to add exceptions to what you want imported in the .env file or do you have to change it in the vendor --> MunkiReport --> Machine --> machine_model.php file like before ?
I cant seem to figure out how to to it at least but i wanted to log less info them it set by default.

You could hack the submit script and set console_user and long_username to an empty string:
https://github.com/munkireport/munkireport-php/blob/master/public/assets/client_installer/submit.preflight#L45-L46

I have tried doing that with
Original
report_info['console_user'] = "%s" % osutils.getconsoleuser()
report_info['long_username'] = reportcommon.get_long_username(report_info['console_user'])
Modified:
report_info['console_user'] = ""
report_info['long_username'] = ""
But i must be doing something wrong or not doing it in the correct places.
The modules i am using is munkiinfo, munkireport, managedinstalls and the defualts modules that might always be active.
I looked in the folder munkireport-php/vendor/munkireport/machine and the sub files to see if i could understand what file i might need to modifie.
I also looked into https://github.com/munkireport/munkireport-php/tree/master/public/assets/client_installer - Postflight, preflight and submit.preflight without any luck with getting the information i want completely removed to be removed.

If you change the sources, you need to send a new package to your clients with the modified code. Or you could just send a patched file to your clients with Munki (which may be easier to do)


Some project redirect links are either not redirecting to the correct folder or are returning a 404 Error.

What happened?
There are a few projects in this README.md file. However, when we click on them, instead of redirecting to the respective folder under Project-Guidance, they are directed to a different folder.
How can we reproduce this bug?
"Please check this project. When you click on the following link, you will be redirected to the appropriate folder: Online Gaming Portal Template, located under Kushal997-das/Project-Guidance/Intermediate.
Desktop Information (Optional)
No response
Urgency (Optional)
Medium priority

@Kushal997-das please assign me this issue, I am GSSoC'24 Contributor

@n-keerthi-gayathri Go ahead!

I would like to work on this issue. Can you assign it to me

I would like to work on this issue. Please assign me this task for GSSoC'24. @Kushal997-das

I would like to work on this issue , i am confident that i can fix the issue . please assign this issue to me.


Time Duration

How can I set a custom time duration.

Time duration set for both date(horizontal) and time(vertical) are not finished yet.
It might be added in the future but not sure when it can be finished.
Thanks

Hi, my friend.
This feature is finally added (only for horizontal direction), could you just simply try it in the branch limitedDateRange.
I haven't finished the example, comments and it might have some other issues.
If you have any suggestions, let me know.
You can just simply change the scrollable startDate and endDate in
LongPressViewController.swift line 41
Thanks

Thanks alot for your contribution. I haven't tried it yet, i'll try it later. I suggest you one thing is that user could be able to make timesheet by selecting/tapping on any two times or can make multiple time slot  in a single day for example a user create his/her schedule on monday for coffee from 14:00 to 14:30 and for dinner from 20:00 to 21:00 (creating schedule by drag and drop gesture could be good for UX).
Second thing is user should be able to tap on an event/schedule so that he/she can update later.
Thank you once again for your contribution you did a great job man outstanding work 👍👍👍

Hi,
I can fully understand what you need.
However, It is really hard for me to do those too detailed stuff, I don't have enough time to achieve everyone's requirements. For some of them, if it is reasonable and quite restricted to the structure of this project, I will try to do it, like this limited scroll duration. For the one you mentioned above, I am afraid that I cannot finish it in the near future.
I will finish the limited one and tell you soon.
Thanks


Update configuration.smk

This should at least catch some of in #253

This gives an error btw xD

no error, but Test DAG and Test Downloading keep returning
Possible unintended interpolation of @2 in string at<EMAIL_ADDRESS>line 260.

How does this work when people just downloaded it (not through git)?

And not sure what causes the warming. Did you check which of the two commands causes it?

It's working!

Hooray :tada:


Retrieving data synchronously

How can I convert asynchronous mode to synchronous? Just by Subscribing? I am getting data from Firebase using Firebase API's and displaying them in my app but due to asynchronous mode, the display event occurs before the data is retrieved. I am shifting to using AngularFire but not sure if AngularFire by default uses asynchronous. I want to wait for the data before my program moves to executing next steps.
I am using Ionic2, have a provider which connects to Firebase, fetches data, stores in a local array in the provider with the ".then" method. The display page injects the provider and stores Firebase array data locally again in the display page, And then use the local variable in the html (ion-item) to display it. Basically, I want the data to be refreshed with any changes to Firebase data by any user.

@dkkishor please use StackOverflow for these types of general questions. Github is typically reserved for feature requests and bug reports.

Sure, Thanks.


Registrar util unit tests

Added some unit tests for the registrar_util functions

As a note, the behavior for production datasets goes into relative paths of the form
production/production/my/path
This is because user gets replaced with "production". Do we want the production twice, we could remove the duplication?


Trim StoreInteger value

@freva Should this one be merged or closed ?

I'm looking into this, the issue this fixes has only been observed once and I haven't been able to reproduce it yet, so maybe this wont be needed.


update

Hallo. (Thanks for the plugin and apparently alllllot of nodebb work.) Few minor updates. You mention not to outright trust your implementation in prod but I'm not sure there's even much room for error to begin with. The login prompt on home page was annoying, so I added a check for the actual web3 login page-- couldn't figure out how to add a prettier page for the POST login though. Added a redirect back to the home page as well after login, which naturally, worked until it didn't for no reason at all until I had to add a workaround for plausibly no reason. Very helpful that you already adding the "associate to account", I was worried I might have to add that. Thanks again for all the work.
Didn't need to change any of the admin settings. Or haven't, yet.
But yeah, should be good for live. I'll be using it as such soon, so, one way to find out.

Well done! Thank you. You should add yourself to the readme and I’m happy to give you access rights if you’d like to continue on this project. I’m happy to see someone work on this, thank you again.

Oh. Right. I can delete this fork now. cough I too have no idea what I'm doing. I made a change to the url in the plugin.json file not understanding what happens after actually doing a mythical pull request... (you might want to change that, or I can again sigh). I don't expect to need to make any changes again myself soon but if it helps, sure.
My project is 18+ hahaa but I wouldn't mind adding it ;)

Maybe not just for the sake of this project being used by hopefully as many as possible haha. I have no qualms either way but best of luck with your site! Yeah I noticed the plugin.json change but I’m not at a computer atm so I was thinking I’ll fix that next time. But if you don’t mind, I’d appreciate it. Thanks either way

It’s not a big deal because it’s not published on npm. So no worries btw

Hahaaa... yeah. I will figure out how to do the thing again. First pull request.


Follow up introduction doc

The concern I had in previous PR is it's  too long for a single page introduction doc.
So I tried to shrink the content as I can. Please kindly review and ensure the original messages are conveyed properly.

defer to @Fei-Guo

Per offline discussion, the second paragraph still need some revises to reflect current implementation. Will amend the commit.

I took a quick pass on the first two paragraphs, mostly just typo/grammar/style.

On Oct 31, 2020, at 2:46 PM, Lei Zhang (Harry<EMAIL_ADDRESS>wrote:
Per offline discussion, the second paragraph still need some revises to reflect current implementation. Will amend the commit.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/oam-dev/kubevela/pull/487#issuecomment-719893931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AODXOHA5K5CAAMH6UK5JD3DSNOXFJANCNFSM4TFVKEQA.

@ryanzhang-oss @Fei-Guo Just updated the PR per all your review comments. PTAL. thank you!


Wrong level_stats calculation

Expected Behavior
at any level, level_stats should show (like the app):
XP earned at the current level / XP to pass next level
Actual Behavior
in fact, level_apps shows (XP previous level + XP earned at the current level) / (XP previous level + XP to pass next level)
Ex: Level 16 is 20.000 and level 17 also, so when it starts, it shows 50% where it should show 0%
Level 16 (20,095 / 40,000, 50%)
Your FULL config.json (remove your username, password, gmapkey and any other private info)
http://pastebin.com/XzFy46Tv
Output when issue occurred
2016-08-22 14:57:34,214 [UpdateLiveStats] [INFO] [log_stats] XXX | Uptime : 0:19:01 | Earned 2,200 Stardust | +4,500 XP | 14,200 XP/h | Visited 15 stops | Level 16 (20,095 / 40,000, 50%)
Other Information
OS: OSX Capitan
Branch: dev
Git Commit: 4f2e976764242a69e4ed7551ceae805d19f3a55c
Python Version: Python 2.7.12

The code uses prev_level_xp, but it should use the current_level_xp
For example, if player is at level 11, which is 55,000 reaching level 12 which is 65,000
it should use (experience - 55,000) / (65,000 - 55,000)
where in fact it uses level 9 value 45,000 and calculates (experience - 45,000) / (65,000 - 45,000)

Sorry, I do not. We could easily hardcore those values - I don't expect them to change much.

@mjmadsen Yes, I'm doing it. Will provide a pull request

Merged! If there is a problem with the merge. please create a new issue.


Support Intel Skylake by Haswell kernels.

Ref #632
This makes OpenBLAS compiles and also recognize my computer as Haswell instead of Prescott. I didn't find a complete list of CPUID's for skylake processors and only adding the model/family numbers for 6700K so there's almost certainly missing ones.

And this is the Julia versioninfo() showing that OpenBLAS recognize the CPU as Haswell instead of Prescott now....
julia> versioninfo()
Julia Version 0.4.0-pre+7407
Commit fc936a0* (2015-09-09 08:12 UTC)
Platform Info:
  System: Linux (x86_64-unknown-linux-gnu)
  CPU: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
  WORD_SIZE: 64
  BLAS: libopenblas (DYNAMIC_ARCH NO_AFFINITY Haswell)
  LAPACK: libopenblas
  LIBM: libm
  LLVM: libLLVM-3.6.2

Thank you for the patch


unexpected keyword argument 'delete'

Hi, i am trying import wp xml file, but getting error.
Wagtail ID: 5, About, updated
Wagtail ID: 6, Call for Members, updated
Wagtail ID: 7, Contact, updated
Wagtail ID: 8, Constitution, updated
Wagtail ID: 9, Open Data, updated
Wagtail ID: 10, Members, updated
Wagtail ID: 11, INSPIRE Hack 2017, updated
Exception ignored in: <function TemporaryFile.__del__ at 0x000002142879B010>
Traceback (most recent call last):
  File "C:\w\wp\env\lib\site-packages\django\core\files\temp.py", line 61, in __del__
    self.close()
  File "C:\w\wp\env\lib\site-packages\django\core\files\temp.py", line 49, in close
    if not self.close_called:
AttributeError: 'TemporaryFile' object has no attribute 'close_called'
Traceback (most recent call last):
  File "C:\w\wp\manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "C:\w\wp\env\lib\site-packages\django\core\management\__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "C:\w\wp\env\lib\site-packages\django\core\management\__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "C:\w\wp\env\lib\site-packages\django\core\management\base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "C:\w\wp\env\lib\site-packages\django\core\management\base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "C:\w\wp\env\lib\site-packages\wagtail_wordpress_import\management\commands\import_xml.py", line 70, in handle
    importer.run(
  File "C:\w\wp\env\lib\site-packages\wagtail_wordpress_import\importers\wordpress.py", line 113, in run
    wp_post_id=wordpress_item.cleaned_data.get("wp_post_id")
  File "C:\p\Python310\lib\functools.py", line 981, in __get__
    val = self.func(instance)
  File "C:\w\wp\env\lib\site-packages\wagtail_wordpress_import\importers\wordpress.py", line 518, in cleaned_data
    "body": self.body_stream_field(self.prefilter_content(self.raw_body)),
  File "C:\w\wp\env\lib\site-packages\wagtail_wordpress_import\importers\wordpress.py", line 437, in body_stream_field
    blocks_dict = builder.build()
  File "C:\w\wp\env\lib\site-packages\wagtail_wordpress_import\block_builder.py", line 123, in build
    cached_fallback_value = cached_fallback_function(
  File "C:\w\wp\env\lib\site-packages\wagtail_wordpress_import\block_builder_defaults.py", line 284, in build_richtext_block_content
    html = image_linker(html)
  File "C:\w\wp\env\lib\site-packages\wagtail_wordpress_import\block_builder_defaults.py", line 92, in image_linker
    saved_image = get_or_save_image(image_src)
  File "C:\w\wp\env\lib\site-packages\wagtail_wordpress_import\block_builder_defaults.py", line 124, in get_or_save_image
    temp_image = NamedTemporaryFile(delete=True)
TypeError: TemporaryFile.__init__() got an unexpected keyword argument 'delete'

Not seen that error before.
Can you tell me about your Python, Django and Wagtail versions in use?

Python 3.10.2
Django 3.2.13
Wagtail 2.16.2
CodeRedCms 0.23.0

Looks like you are using windows and virtual env which shouldn't be an issue.
Can you try this test setup with your XML file, it runs in docker and on gitpod.io https://gitpod.io/#github.com/nickmoreton/wwi-docker-develop
You can copy in your XML file and run the import on it.

CodeRedCms 0.23.0

We haven't tried is on CoderedCms but I don't think that would be the cause.

temp_image = NamedTemporaryFile(delete=True) is used when an image is been imported. I'd check the XML for that particular import to see if there are any clues there.

Python 3.10.2

Is not tested on the released package but: https://github.com/torchbox/wagtail-wordpress-import/pull/157 is soon to be released for Wagtail 3.0+ and includes Python 3.10

I uploaded xml to gitpod.
cms/plan4all.xml
But unable to try import:
python manage.py import_xml plan4all.xml 1
Traceback (most recent call last):
File "manage.py", line 8, in
from django.core.management import execute_from_command_line
ModuleNotFoundError: No module named 'django'

Try:
fab sh
cd cms
./manage.py delete_imported_pages pages PostPage
./manage.py import_xml ../xml/your_xml_file.xml 3

fab sh: gets you into the container whcih is where you need to run the commands from, thats why you are seeing ModuleNotFoundError: No module named 'django'
You could put your xml file anywhere and use the path to it's location.
The page id 3 is the default home page

xml.sax._exceptions.SAXParseException: :36839:1152: not well-formed (invalid token)

I suspect the XML is problematic at line 36839
I did a search for it: xml.sax._exceptions.SAXParseException: :36839:1152: not well-formed (invalid token) that could help you.

Reduce XML command could help, it removes the comments, that could be where the above is introduced. Of course if you need the comments that won't help 😞

Might I suggest: https://wagtailcms.slack.com/archives/C02NB3SJDL3 where other people could help.

I looked into this a bit myself, since I was experiencing the same issue. It seems that the Django implementation of NamedTemporaryFile has special logic on windows only. Part of this special logic is that it does not accept the Delete keyword: https://github.com/django/django/blob/4bf4222010fd8e413963c6c873e4088614332ef9/django/core/files/temp.py#L34


[#128843567] Add countersignature details to framework table

This pull request adds the countersignerName key to Framework.framework_agreement_details, and then returns it in the serialize() method if it finds it.
Planning to add just a string that says "Dan Saxby" to G8 in all environments once this is merged and deployed.

👍  💯

Will merge once functional tests are green.


Fix composer installed check: needs sudo

Installation is done using root, therefore the check needs to be done also using root.

This PR is a : Bugfix

[x] Changelog was updated

A question: what's the difference between test and tests? I don't recognize the tests command.. is that something ansible somehow provides?

There's no reason to use sudo to test if a file exists. However there's indeed a bug here, the command should be test, not tests. If you can remove the become and provide more detailed info in the changelog (like Composer role: don't reinstall composer on every provisioning) I'd be happy to merge it. Thanks!

@sephii well spotted. I thought it's because of not using sudo but actually was the command which was wrong. Fixed :)

Thanks! :sake:


Add authentiaction endpoint, using cookies

Self assigning, need to be done in the earliest stages of development


Improve preview and exception handling in AnomalyResultTransportAction

Signed-off-by: Kaituo Li<EMAIL_ADDRESS>Description
This PR commits changes from the following PRs:
https://github.com/kaituo/anomaly-detection-1/pull/11
https://github.com/kaituo/anomaly-detection-1/pull/12
Issues Resolved
https://github.com/opensearch-project/anomaly-detection/issues/129
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #128 (b81dced) into main (ea22d59) will increase coverage by 0.17%.
The diff coverage is 44.73%.

:exclamation: Current head b81dced differs from pull request most recent head 8a2c465. Consider uploading reports for the commit 8a2c465 to get more accurate results

@@             Coverage Diff              @@
##               main     #128      +/-   ##
============================================
+ Coverage     75.97%   76.15%   +0.17%
- Complexity     2886     2898      +12
============================================
  Files           264      263       -1
  Lines         12435    12488      +53
  Branches       1222     1224       +2
============================================
+ Hits           9448     9510      +62
+ Misses         2478     2471       -7
+ Partials        509      507       -2

Flag
Coverage Δ

plugin
76.15% <44.73%> (+0.17%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../java/org/opensearch/ad/AnomalyDetectorPlugin.java
95.91% <ø> (ø)

...rg/opensearch/ad/constant/CommonErrorMessages.java
90.90% <ø> (ø)

.../org/opensearch/ad/feature/CompositeRetriever.java
71.02% <ø> (+0.59%)
:arrow_up:

...va/org/opensearch/ad/feature/SearchFeatureDao.java
61.80% <4.54%> (-6.82%)
:arrow_down:

...a/org/opensearch/ad/feature/AbstractRetriever.java
89.28% <62.50%> (-10.72%)
:arrow_down:

...rch/ad/transport/AnomalyResultTransportAction.java
78.52% <73.33%> (+0.07%)
:arrow_up:

...ansport/PreviewAnomalyDetectorTransportAction.java
79.34% <79.31%> (-3.32%)
:arrow_down:

...pensearch/ad/settings/AnomalyDetectorSettings.java
100.00% <100.00%> (ø)

...java/org/opensearch/ad/task/ADBatchTaskRunner.java
88.69% <0.00%> (ø)

... and 5 more


Fix source url

tldr-pages/tldr-{cpp => c}-client

Thanks for the PR @bl-ue! I can't merge this PR myself but I'll mention it in the Gitter chat so hopefully a maintainer who can will do it.

Oh, the Travis build errored. Is that a problem?

@sbrl I don't think it is.  I didn't make any real source code changes.


Add support for image-pull-secrets for all component images

Needed to be able to pull images from private registries.

Closed due to merge errors. Recreating separately.


Renew Lets Encrypt Certificates

How can the lets encrypt certificates be renewed? For web and mail purposes.
Any help will highly be appreciated

@GyunerZeki , was just wondering if this is fixed and updated yet. Thanks

@Kiewiet1024 still not updated, but I have a solution, can you contact me at me[ at ]gzeki.com and I will be happy to share the solution thanks.


How to deal with challenge required?

I try to request the followers of a user like this:
    instagram.profile().getFollowers("user1")
            .setOnCompleteCallback(call ->
            {
                if (call.isSuccessful)
                {
                    List<String> followers = call.result;
                    for (String follower : followers)
                    {
                        Print.e(follower);
                    }
                }
            });

But I get the error challenge_required. How to deal with this error?

It is worth noting that I got this error the second time I tried to make a request, so it's not that I spammed.

A big problem nowadays. Looks like instagram is improving their security algorithm day by day. They are somehow detection that we are using their API in wrong way.
To avoid these challenge, you can :-

Use cache instead of logging in everytime
Add human interpreted gap between every request
Do not use new accounts. accounts which are not older then 90 days suffer this problem the most. Instagram keep tracks of new account.

I will update it as soon as I get the fix

A big problem nowadays. Looks like instagram is improving their security algorithm day by day. They are somehow detection that we are using their API in unauthenticated way
To avoid these challenge, you can :-
* Use cache instead of logging everytime

* Add human interpreted gap between every request

* Do not use new accounts. accounts which are not older then 90 days suffer this problem the most. Instagram keep tracks of new account.

I will update it as soon as I get the fix

Maybe we can avoid it by updating APP_VERSION in instagram4j IGConstants and using new IGAndroidDevice`s ???

A big problem nowadays. Looks like instagram is improving their security algorithm day by day. They are somehow detection that we are using their API in unauthenticated way
To avoid these challenge, you can :-
* Use cache instead of logging everytime

* Add human interpreted gap between every request

* Do not use new accounts. accounts which are not older then 90 days suffer this problem the most. Instagram keep tracks of new account.

I will update it as soon as I get the fix

Maybe we can avoid it by updating APP_VERSION in instagram4j IGConstants and using new IGAndroidDevice`s ???

Yeah, this is one of the crucial factor which is causing this problem. But instead of fixing that, we are again reverse engineering Instagram API with all the factors and constants taking in account. This one will be using Web API where as old instagran4j was using mobile version API.
So instead of contributing to instagram4j, you can contribute in making of this new API