Convert static html pages to Jekyll

First of all, I really like this idea to encourage people to contribute to open source.
I saw that it was mentioned to make this site a Jekyll site.
So I thought I could create a small pull request that does this.
It could probably split up the files even more, but at least it's a start :)

Move the outer tags to default.html-layout.
Move the footer content to a included file.
Add some variables to _config.yml.

If something is unclear I can explain more :)

Hey @andeersg! Thank you so much for the effort you've made, I hope it was fun. I will go through this soon, but I see no reason why I won't merge this.
I think all that needs to be done now is to write instructions on how to run this locally, and how to work with it: but I am happy to do this myself when I get the time.
Have a great day ☀

So nice that you liked it :smile:
That sounds great, I can add a small section to the readme about running Jekyll locally at least.

Can we have this merged?

@matheussampaio Hi there. I am very busy right now, so I will be reviewing this and merging this when I have the time. Sorry.

Rather than relying on a globally installed version of Jekyll, it would be preferable to use a Gemfile and Bundler to lock the version of Jekyll for this project. This is because the globally-installed version of Jekyll that somebody has installed may be different from the version that GitHub uses to deploy pages and from other people who develop work on the site. This could lead to unexpected behaviour where somebody could claim "it works for me locally" but the site does not build on GitHub as that person's version of Jekyll is different.
Fortunately GitHub provides a gem that details what version of Jekyll they use so that people can be sure what they're developing locally shall work on GitHub pages. The Gemfile would end up looking like:
source 'https://rubygems.org'
gem 'github-pages'

And the installation instructions would be:
Run bundle install to install all dependancies.
Run bundle exec jekyll serve to run the server.
The first time you run bundle install after creating the Gemfile it shall also create a Gemfile.lock, which should also be committed as part of this PR.

Hi, I'm not that familiar with Ruby, so I forgot that part, but I will add it :)

Cheers @BPScott!

Not a problem @andeersg :) I appreciate that getting started with a new ecosystem is almost always a sheer cliff rather than a learning curve. Thank you for taking the time to look into Ruby and contribute.

Nice work converting the site to Jekyll!
@Charlotteis Would a co-review of the PR be helpful to take some workload off of you?
If yes: LGTM from my side – I just reviewed and all looks good to me.
Here’s what I did in detail:

Checked out the branch
:white_check_mark: Followed the README instructions to get the site running locally with jekyll. Worked great, instructions are clear and beginner-friendly.
:white_check_mark: Reviewed the site in the browser, compared to the master branch, all looks like expected.
:white_check_mark: Reviewed all commits separately for typos / unintended copy changes / broken links… looks all good!

Only suggestion from my end would be to add a sentence to the README for people who are absolutely new to jekyll, explaining what it is and where to learn more (e.g. http://jekyllrb.com/).
cc @andeersg

Thank you @Kriesse, this is extremely kind of you. I am so sorry I haven't gotten to this STILL, this is entirely my fault as my workload is immense right now. Good news is I have some time off this week! This will b much easier to review now that I have had a review from Kriesse as well. :bow:

Hi @andeersg. Once again, I am truly sorry this took so long. Who knew life could get in the way so much? I should have given this attention from the outset, because THIS.IS.GREAT.
THANK YOU.
Merging. :shipit:

:+1: :+1:


PHOENIX-5296 : refCount leak checks

4.x backport PR of #1096

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 55s
4.x passed

+1 :green_heart:
compile
1m 41s
4.x passed

+1 :green_heart:
checkstyle
0m 33s
4.x passed

+1 :green_heart:
javadoc
1m 25s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 15s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m  1s
the patch passed

+1 :green_heart:
compile
1m 42s
the patch passed

+1 :green_heart:
javac
1m 42s
the patch passed

-1 :x:
checkstyle
0m 34s
root: The patch generated 10 new + 12 unchanged - 0 fixed = 22 total (was 12)

-1 :x:
whitespace
0m  0s
The patch 31 line(s) with tabs.

+1 :green_heart:
javadoc
1m 24s
the patch passed

+1 :green_heart:
spotbugs
5m 19s
the patch passed

_ Other Tests _

-1 :x:
unit
178m 41s
root in the patch failed.

+1 :green_heart:
asflicense
2m  5s
The patch does not generate ASF License warnings.

226m 17s

Reason
Tests

Failed junit tests
phoenix.end2end.SystemTablesCreationOnConnectionIT

phoenix.tx.TxCheckpointIT

phoenix.end2end.OrphanViewToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 2bd20ca36f53 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 6fe6052

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/testReport/

Max. process+thread count
5470 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 55s
4.x passed

+1 :green_heart:
compile
1m 41s
4.x passed

+1 :green_heart:
checkstyle
0m 33s
4.x passed

+1 :green_heart:
javadoc
1m 25s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 15s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m  1s
the patch passed

+1 :green_heart:
compile
1m 42s
the patch passed

+1 :green_heart:
javac
1m 42s
the patch passed

-1 :x:
checkstyle
0m 34s
root: The patch generated 10 new + 12 unchanged - 0 fixed = 22 total (was 12)

-1 :x:
whitespace
0m  0s
The patch 31 line(s) with tabs.

+1 :green_heart:
javadoc
1m 24s
the patch passed

+1 :green_heart:
spotbugs
5m 19s
the patch passed

_ Other Tests _

-1 :x:
unit
178m 41s
root in the patch failed.

+1 :green_heart:
asflicense
2m  5s
The patch does not generate ASF License warnings.

226m 17s

Reason
Tests

Failed junit tests
phoenix.end2end.SystemTablesCreationOnConnectionIT

phoenix.tx.TxCheckpointIT

phoenix.end2end.OrphanViewToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux 2bd20ca36f53 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 6fe6052

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/whitespace-tabs.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/testReport/

Max. process+thread count
5470 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Once changes are finalized in #1096 , will get them here together.

Once changes are finalized in #1096 , will get them here together.

Sure, I am on it.

Sure, I am on it.

Looks good, let's wait for the Yetus checks.

Looks good, let's wait for the Yetus checks.

Build#2 is aborted, let's see how build#3 goes, it was lined up.

Build#2 is aborted, let's see how build#3 goes, it was lined up.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  0s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m  0s
4.x passed

+1 :green_heart:
compile
1m 33s
4.x passed

+1 :green_heart:
checkstyle
0m 34s
4.x passed

+1 :green_heart:
javadoc
1m 27s
4.x passed

+0 :ok:
spotbugs
0m 30s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 26s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 55s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 53s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

-1 :x:
checkstyle
0m 32s
root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 24s
the patch passed

+1 :green_heart:
spotbugs
5m  6s
the patch passed

_ Other Tests _

-1 :x:
unit
133m 51s
root in the patch failed.

+1 :green_heart:
asflicense
2m 33s
The patch does not generate ASF License warnings.

178m 28s

Reason
Tests

Failed junit tests
phoenix.end2end.SystemTablesCreationOnConnectionIT

phoenix.end2end.salted.SaltedTableUpsertSelectIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux 6438e13c5354 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 14e69c3

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/testReport/

Max. process+thread count
5923 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  0s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m  0s
4.x passed

+1 :green_heart:
compile
1m 33s
4.x passed

+1 :green_heart:
checkstyle
0m 34s
4.x passed

+1 :green_heart:
javadoc
1m 27s
4.x passed

+0 :ok:
spotbugs
0m 30s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 26s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 55s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 53s
the patch passed

+1 :green_heart:
compile
1m 34s
the patch passed

+1 :green_heart:
javac
1m 34s
the patch passed

-1 :x:
checkstyle
0m 32s
root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 24s
the patch passed

+1 :green_heart:
spotbugs
5m  6s
the patch passed

_ Other Tests _

-1 :x:
unit
133m 51s
root in the patch failed.

+1 :green_heart:
asflicense
2m 33s
The patch does not generate ASF License warnings.

178m 28s

Reason
Tests

Failed junit tests
phoenix.end2end.SystemTablesCreationOnConnectionIT

phoenix.end2end.salted.SaltedTableUpsertSelectIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux 6438e13c5354 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 14e69c3

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/testReport/

Max. process+thread count
5923 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/7/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty For 4.x, a couple more patch results are available on Jira. But master patch builds are still taking time. What do you suggest?

@stoty For 4.x, a couple more patch results are available on Jira. But master patch builds are still taking time. What do you suggest?

Can you start one more for each branch ?
I'll probably merge it tomorrow morning-

Can you start one more for each branch ?
I'll probably merge it tomorrow morning-

PR-1097#8 build timed out after 9 hr and PR-1097#9 is in progress. In the meanwhile, we have below build results available from precommit Jira (QA results available on Jira):
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/367/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/368/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/369/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/370/
While precommit PR builds are serial, precommit Jira builds can run in parallel (consuming more resources?)

PR-1097#8 build timed out after 9 hr and PR-1097#9 is in progress. In the meanwhile, we have below build results available from precommit Jira (QA results available on Jira):
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/367/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/368/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/369/
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/370/
While precommit PR builds are serial, precommit Jira builds can run in parallel (consuming more resources?)

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 54s
4.x passed

+1 :green_heart:
compile
1m 44s
4.x passed

+1 :green_heart:
checkstyle
0m 34s
4.x passed

+1 :green_heart:
javadoc
1m 26s
4.x passed

+0 :ok:
spotbugs
0m 28s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 26s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 12s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m  9s
the patch passed

+1 :green_heart:
compile
1m 41s
the patch passed

+1 :green_heart:
javac
1m 41s
the patch passed

-1 :x:
checkstyle
0m 35s
root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 25s
the patch passed

+1 :green_heart:
spotbugs
5m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
196m 15s
root in the patch failed.

+1 :green_heart:
asflicense
2m  3s
The patch does not generate ASF License warnings.

247m 38s

Reason
Tests

Failed junit tests
phoenix.end2end.OrphanViewToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux d5ba4f42526d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 14e69c3

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/testReport/

Max. process+thread count
4691 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 54s
4.x passed

+1 :green_heart:
compile
1m 44s
4.x passed

+1 :green_heart:
checkstyle
0m 34s
4.x passed

+1 :green_heart:
javadoc
1m 26s
4.x passed

+0 :ok:
spotbugs
0m 28s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 26s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 12s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 11s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m  9s
the patch passed

+1 :green_heart:
compile
1m 41s
the patch passed

+1 :green_heart:
javac
1m 41s
the patch passed

-1 :x:
checkstyle
0m 35s
root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 25s
the patch passed

+1 :green_heart:
spotbugs
5m 22s
the patch passed

_ Other Tests _

-1 :x:
unit
196m 15s
root in the patch failed.

+1 :green_heart:
asflicense
2m  3s
The patch does not generate ASF License warnings.

247m 38s

Reason
Tests

Failed junit tests
phoenix.end2end.OrphanViewToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux d5ba4f42526d 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 14e69c3

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/testReport/

Max. process+thread count
4691 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/11/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  3s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m 49s
4.x passed

+1 :green_heart:
compile
1m 54s
4.x passed

+1 :green_heart:
checkstyle
0m 39s
4.x passed

+1 :green_heart:
javadoc
1m 43s
4.x passed

+0 :ok:
spotbugs
0m 32s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 30s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 27s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 37s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 14s
the patch passed

+1 :green_heart:
compile
1m 52s
the patch passed

+1 :green_heart:
javac
1m 52s
the patch passed

-1 :x:
checkstyle
0m 40s
root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 39s
the patch passed

+1 :green_heart:
spotbugs
6m 21s
the patch passed

_ Other Tests _

-1 :x:
unit
192m 30s
root in the patch failed.

+1 :green_heart:
asflicense
2m  7s
The patch does not generate ASF License warnings.

244m 16s

Reason
Tests

Failed junit tests
phoenix.end2end.IndexScrutinyToolIT

phoenix.end2end.AlterTableIT

phoenix.end2end.OrphanViewToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux bb0bc265377b 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / d33f782

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/testReport/

Max. process+thread count
5130 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  3s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m 49s
4.x passed

+1 :green_heart:
compile
1m 54s
4.x passed

+1 :green_heart:
checkstyle
0m 39s
4.x passed

+1 :green_heart:
javadoc
1m 43s
4.x passed

+0 :ok:
spotbugs
0m 32s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 30s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 27s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 37s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
7m 14s
the patch passed

+1 :green_heart:
compile
1m 52s
the patch passed

+1 :green_heart:
javac
1m 52s
the patch passed

-1 :x:
checkstyle
0m 40s
root: The patch generated 10 new + 36 unchanged - 0 fixed = 46 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 39s
the patch passed

+1 :green_heart:
spotbugs
6m 21s
the patch passed

_ Other Tests _

-1 :x:
unit
192m 30s
root in the patch failed.

+1 :green_heart:
asflicense
2m  7s
The patch does not generate ASF License warnings.

244m 16s

Reason
Tests

Failed junit tests
phoenix.end2end.IndexScrutinyToolIT

phoenix.end2end.AlterTableIT

phoenix.end2end.OrphanViewToolIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux bb0bc265377b 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / d33f782

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/testReport/

Max. process+thread count
5130 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/12/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Just removed changes in OrphanViewToolIT from refCount check for now. Will try to add it later as separate Jira.

Just removed changes in OrphanViewToolIT from refCount check for now. Will try to add it later as separate Jira.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
4m 58s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
9m 58s
4.x passed

+1 :green_heart:
compile
1m 34s
4.x passed

+1 :green_heart:
checkstyle
0m 34s
4.x passed

+1 :green_heart:
javadoc
1m 25s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 57s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 25s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

-1 :x:
checkstyle
0m 35s
root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 25s
the patch passed

-1 :x:
spotbugs
0m 42s
phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

_ Other Tests _

-1 :x:
unit
151m  9s
root in the patch failed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

192m 44s

Reason
Tests

FindBugs
module:phoenix-hbase-compat-1.5.0

org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held  At CompatUtil.java:lock held  At CompatUtil.java:[line 61]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux a7764916236d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / a175cc0

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/testReport/

Max. process+thread count
5683 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
4m 58s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
9m 58s
4.x passed

+1 :green_heart:
compile
1m 34s
4.x passed

+1 :green_heart:
checkstyle
0m 34s
4.x passed

+1 :green_heart:
javadoc
1m 25s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 57s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 25s
the patch passed

+1 :green_heart:
compile
1m 35s
the patch passed

+1 :green_heart:
javac
1m 35s
the patch passed

-1 :x:
checkstyle
0m 35s
root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 25s
the patch passed

-1 :x:
spotbugs
0m 42s
phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

_ Other Tests _

-1 :x:
unit
151m  9s
root in the patch failed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

192m 44s

Reason
Tests

FindBugs
module:phoenix-hbase-compat-1.5.0

org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held  At CompatUtil.java:lock held  At CompatUtil.java:[line 61]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux a7764916236d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / a175cc0

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/testReport/

Max. process+thread count
5683 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/15/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  4s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 10s
4.x passed

+1 :green_heart:
compile
1m 40s
4.x passed

+1 :green_heart:
checkstyle
0m 35s
4.x passed

+1 :green_heart:
javadoc
1m 23s
4.x passed

+0 :ok:
spotbugs
0m 30s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 56s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 46s
the patch passed

+1 :green_heart:
compile
1m 31s
the patch passed

+1 :green_heart:
javac
1m 31s
the patch passed

-1 :x:
checkstyle
0m 34s
root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36)

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 24s
the patch passed

-1 :x:
spotbugs
0m 41s
phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

_ Other Tests _

-1 :x:
unit
200m 39s
root in the patch failed.

+1 :green_heart:
asflicense
2m 56s
The patch does not generate ASF License warnings.

249m 17s

Reason
Tests

FindBugs
module:phoenix-hbase-compat-1.5.0

org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held  At CompatUtil.java:lock held  At CompatUtil.java:[line 61]

Failed junit tests
phoenix.end2end.index.IndexMetadataIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux 928f3c781126 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / a175cc0

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/testReport/

Max. process+thread count
4807 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 53s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  4s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
12m 10s
4.x passed

+1 :green_heart:
compile
1m 40s
4.x passed

+1 :green_heart:
checkstyle
0m 35s
4.x passed

+1 :green_heart:
javadoc
1m 23s
4.x passed

+0 :ok:
spotbugs
0m 30s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 56s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 46s
the patch passed

+1 :green_heart:
compile
1m 31s
the patch passed

+1 :green_heart:
javac
1m 31s
the patch passed

-1 :x:
checkstyle
0m 34s
root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36)

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 24s
the patch passed

-1 :x:
spotbugs
0m 41s
phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

_ Other Tests _

-1 :x:
unit
200m 39s
root in the patch failed.

+1 :green_heart:
asflicense
2m 56s
The patch does not generate ASF License warnings.

249m 17s

Reason
Tests

FindBugs
module:phoenix-hbase-compat-1.5.0

org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held  At CompatUtil.java:lock held  At CompatUtil.java:[line 61]

Failed junit tests
phoenix.end2end.index.IndexMetadataIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux 928f3c781126 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / a175cc0

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/testReport/

Max. process+thread count
4807 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/16/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  8s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
9m 54s
4.x passed

+1 :green_heart:
compile
1m 33s
4.x passed

+1 :green_heart:
checkstyle
0m 33s
4.x passed

+1 :green_heart:
javadoc
1m 27s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 27s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 55s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 59s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

-1 :x:
checkstyle
0m 33s
root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 22s
the patch passed

-1 :x:
spotbugs
0m 41s
phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

_ Other Tests _

-1 :x:
unit
140m 17s
root in the patch failed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

181m  9s

Reason
Tests

FindBugs
module:phoenix-hbase-compat-1.5.0

org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held  At CompatUtil.java:lock held  At CompatUtil.java:[line 61]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux d6b4ce08ea2c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 88f4362

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/testReport/

Max. process+thread count
5766 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  8s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
9m 54s
4.x passed

+1 :green_heart:
compile
1m 33s
4.x passed

+1 :green_heart:
checkstyle
0m 33s
4.x passed

+1 :green_heart:
javadoc
1m 27s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 27s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 24s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
2m 55s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 59s
the patch passed

+1 :green_heart:
compile
1m 33s
the patch passed

+1 :green_heart:
javac
1m 33s
the patch passed

-1 :x:
checkstyle
0m 33s
root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 22s
the patch passed

-1 :x:
spotbugs
0m 41s
phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

_ Other Tests _

-1 :x:
unit
140m 17s
root in the patch failed.

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

181m  9s

Reason
Tests

FindBugs
module:phoenix-hbase-compat-1.5.0

org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held  At CompatUtil.java:lock held  At CompatUtil.java:[line 61]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux d6b4ce08ea2c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 88f4362

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/testReport/

Max. process+thread count
5766 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/18/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  2s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 56s
4.x passed

+1 :green_heart:
compile
1m 39s
4.x passed

+1 :green_heart:
checkstyle
0m 35s
4.x passed

+1 :green_heart:
javadoc
1m 25s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 14s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 52s
the patch passed

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

-1 :x:
checkstyle
0m 33s
root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 25s
the patch passed

-1 :x:
spotbugs
0m 40s
phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

_ Other Tests _

-1 :x:
unit
196m  6s
root in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

239m 55s

Reason
Tests

FindBugs
module:phoenix-hbase-compat-1.5.0

org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held  At CompatUtil.java:lock held  At CompatUtil.java:[line 61]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux<PHONE_NUMBER>e6 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 51715b3

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/testReport/

Max. process+thread count
4888 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  5s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ 4.x Compile Tests _

+0 :ok:
mvndep
5m  2s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 56s
4.x passed

+1 :green_heart:
compile
1m 39s
4.x passed

+1 :green_heart:
checkstyle
0m 35s
4.x passed

+1 :green_heart:
javadoc
1m 25s
4.x passed

+0 :ok:
spotbugs
0m 29s
phoenix-hbase-compat-1.5.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.4.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
0m 25s
phoenix-hbase-compat-1.3.0 in 4.x has 3 extant spotbugs warnings.

+0 :ok:
spotbugs
3m 14s
phoenix-core in 4.x has 945 extant spotbugs warnings.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
6m 52s
the patch passed

+1 :green_heart:
compile
1m 39s
the patch passed

+1 :green_heart:
javac
1m 39s
the patch passed

-1 :x:
checkstyle
0m 33s
root: The patch generated 14 new + 36 unchanged - 0 fixed = 50 total (was 36)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 25s
the patch passed

-1 :x:
spotbugs
0m 40s
phoenix-hbase-compat-1.5.0 generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)

_ Other Tests _

-1 :x:
unit
196m  6s
root in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

239m 55s

Reason
Tests

FindBugs
module:phoenix-hbase-compat-1.5.0

org.apache.phoenix.compat.hbase.CompatUtil.isAnyStoreRefCountLeaked(HMaster) calls Thread.sleep() with a lock held  At CompatUtil.java:lock held  At CompatUtil.java:[line 61]

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1097

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile xml

uname
Linux<PHONE_NUMBER>e6 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 51715b3

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/diff-checkstyle-root.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/new-spotbugs-phoenix-hbase-compat-1.5.0.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/testReport/

Max. process+thread count
4888 (vs. ulimit of 30000)

modules
C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0 phoenix-hbase-compat-1.3.0 phoenix-core U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1097/21/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Comitted with updated commit message.

Comitted with updated commit message.


Add memory profiler to prover

Add a very lightweight memory profiler to the prover or SDK to measure peak memory usage.
Prometheus metrics may be a good candidate.

@jonathanpwang @yi-sun I can take care of this! Would you mind assigning it to me?

Assigned!

@prsabahrami this may help: https://docs.rs/metrics-process/latest/metrics_process/ It is what reth uses.

@jonathanpwang Thanks!!


startActivity not working properly

Hello
I have used google codebase sample example.
When i tried to called new activity then new activity called more than twice.
public void onChanged(@Nullable Integer value) {
                if (value != null) {

                            Intent intent = new Intent(getActivity(),com.example.android.lifecycles.step5.Activity_step5.class);
                            startActivity(intent);

                }
            }

@ViramP, do you have a more comprehensive example. What is onChanged activated by? Could be that it is fired twice.

I have called on Login API and which setValue(status_code).
So from onChanged i called StartActivity method.
Here not getting idea why onChanged called more than twice.
Here i need to do any extra effort for this ?

onChanged is a Lifecycle event. When you start the new activity you are also changing life-cycle state of the old one.

Can you give details what need to do for that ?

Which example did you base it on?

ViramP, I'm sorry but I cannot determine from what you have shown so far what it is you are trying to achieve. If I had more information I would gladly help.

I have used Google Codelabs example and add StartActivity from my end.
https://codelabs.developers.google.com/codelabs/android-persistence/#0

@andre-artus
My complete all flow should be like below:
Implement Basic Login Page with Web API calling.
On success of Login move to Home screen.
Home screen have another Web API which return some list.
I want to display that list with RecycleView.

Have you looked at the LoginActivity started app?

not getting your question.

You are trying to stat a new activity on changes to the life cycle, that is not recommended. When you go to create a new activity in android Studio there is an option called "Login Activity" this serves as a good example of how to check the credentials off the UI thread, and taking a different course of action based on the result.
 protected void onPostExecute(final Boolean success)

You would of course replace the section between the // TODO:  comments with your actual login check.
        protected Boolean doInBackground(Void... params) {
            // TODO: attempt authentication against a network service. replace this block with your own code

            try {
                // Simulate network access.
                Thread.sleep(2000);
            } catch (InterruptedException e) {
                return false;
            }

            for (String credential : DUMMY_CREDENTIALS) {
                String[] pieces = credential.split(":");
                if (pieces[0].equals(mEmail)) {
                    // Account exists, return true if the password matches.
                    return pieces[1].equals(mPassword);
                }
            }

            // TODO: register the new account here.
            return true;
        }

Yes
I have idea about of above Login Template of Android Activity.
But i want to Perform some action from OnChanged which called from LoginAPI success response.
Please find my complete code so you can get more idea for same.
LoginActivity:
 loginViewModel.loadIssues("20",password,uname,"51").observe
                            (LoginActivity.this,
                                    new Observer<ApiResponse>() {
                                        @Override
                                        public void onChanged(@Nullable ApiResponse apiResponse) {
                                            if(apiResponse.error != null){

                                            }else{
                                                Login login = apiResponse.login;
                                                login_progress.setVisibility(View.GONE);
                                                if(login.getData() != null){
                                                    Toast.makeText(LoginActivity.this,
                                                            ""+login.getData().getEmployeeEnglishName(), Toast.LENGTH_SHORT).show();
                                                }
                                               username.setText("");
                                               mPasswordView.setText("");
                                                startActivity(new Intent(LoginActivity.this,MainActivity.class));
                                            }

                                        }

                                    });

LoginViewModel:
private MediatorLiveData<ApiResponse> mApiResponse;

public LiveData<ApiResponse> loadIssues(@NonNull String IMEI, String password,String username, String VersionCode) {
     mApiResponse.addSource(
             responseRepository.getLoginDetails(IMEI, password, username, VersionCode),
             new Observer<ApiResponse>() {
                 @Override
                 public void onChanged(@Nullable ApiResponse apiResponse) {
                     mApiResponse.postValue(apiResponse);

                 }
             }
     );
     return mApiResponse;
 }

Here,to achieve this functionality which changes need to do with above.

I'll look at it after work.

Ok
Thanks

@ViramP ,
Sorry to take so long but my area has been plagued by power cuts necessitating that I spend the time I had available on my own projects.
Which sample did you base your project on? I've looked though all of them and I cannot find one that uses the libraries in the way you have done.  I've even looked through the "googlesamples/android-architecture" repository. In fact everything I've read would indicate to me that this is something you should not do.
The ViewModel and LiveData classes are there to keep your data and display (activity/fragment/view) in sync with each other, and I'm getting the idea that you are trying to use iot for background processing, when there are better ways of doing that.
If I had the following requirements:

A Login screen that initiates an online authentication check, and
processes in the background, and
shows a progress/busy indicator. and
starts a new activity on success, OR
shows an error state and prompts the user to retry.

I would do this:

The authentication check would happen on a background worker/ async task.
The communication (and only that) between the login activity and the authentication check would be done via ViewModel+LiveData (e.g show progress, disable.enable views, etc.).
The authentication worker will be responsible for initiating any secondary activities (likely through a navigation controller).


Amazon AutoScaling Groups plugin

This PR adds the ability to monitor AWS Auto Scaling groups. This could have been incorporated into the EC2 module, but have left it as a separate plugin, feel free to use it if / how you want.

+1, would like this functionality


Don't recursively merge props

Can be reproduced by running generator-generator using the interactive CLI (e.g. just yo).
Fixes yeoman/generator-generator#192.

Coverage remained the same at 100.0% when pulling a3b2142e5573d987c4af2f6b427fa8bd23bf0ab7 on kevva:fix-props into 3cd06e3e6987bcb403cacffac937bcfbc8970f41 on SBoudrias:master.

Thanks


Unusual matching behaviour for case and nocase modifiers

Affected Version
All 4.x, possibly others?
Description
Expected:
// Assuming there is a player with FirstName -> Samuel
Player->get()-filter('FirstName:nocase', 'sa%m_el'); // This should not match the user with the FirstName of Samuel

Player->get()-filter('FirstName:case', 'Sa%m_el'); // This should not match the user with the FirstName of Samuel

Observed:
// Assuming there is a player with FirstName -> Samuel
Player->get()-filter('FirstName:nocase', 'sa%m_el'); // This matches the user with the FirstName of Samuel

Player->get()-filter('FirstName:case', 'Sa%m_el'); // This matches the user with the FirstName of Samuel

Steps to Reproduce
As above ^
Explanation
I initially struck this behaviour in the context of the silverstripe-memberprofiles module, but after submitting a pull request to alter the way that the module did case insensitive matches on email addresses there, a contributor on that repo suggested this was an issue that was in the Silverstripe framework itself.
I've had a look at where the ExactMatchFilter uses the nocase/case modifiers and found it seems to be in the comparisonClause.
I'm unsure what the best approach is here, the code for comparisonClause appears to use direct equality/inequality only if a modifier is not provided, defaulting to the database default (probably case insensitive for MySQL, as long as no-one has set a binary collation), then uses LIKE and LIKE BINARY to manage case sensitivity if nocase or case are used.
One aproach would be to ensure wildcard characters in the value provided to the filter were escaped in the case where the LIKE comparison was used, by replacing all % and _ chars with \% or \_.
However, that makes assumptions about what the escape character is set as in the DB, and there may be a better approach to this.
I think that escaping the wildcard characters is the right approach for both ExactMatchFilter and PartialMatchFilter, but this feels like a possibly breaking change that needs some thought by someone who knows the framework well. I'd hope that people aren't explicitly using _ in ExactMatch filters, but possibly some are.

Looks like this behaviour was introduced in https://github.com/silverstripe/silverstripe-framework/pull/1012

Can confirm this still affects framework in v5.2.22


🐛 Bug Report: app fails to start if Native Instruments dir exists with no Traktor config

📜 Description
When open app at first time it asks to access Documents folder and also firewall triggers that it trying to access some host, but then it exit before even some gui appears. There is now app icon in dock or anything.
When trying to run executable from .app contents it fails with [1466] Failed to execute script 'nppyi' due to unhandled exception! message, see full log.
Both result for Intel and ARM version.
Mac OS 13.2.1, M1 Pro.
tabacyclone@mbp14apreeel ~ % /Applications/NowPlaying.app/Contents/MacOS/NowPlaying ; exit;
Traceback (most recent call last):
  File "nppyi.py", line 14, in <module>
  File "nowplaying/__main__.py", line 77, in main
  File "nowplaying/__main__.py", line 63, in actualmain
  File "nowplaying/config.py", line 83, in __init__
  File "nowplaying/config.py", line 207, in defaults
  File "nowplaying/config.py", line 231, in _defaults_plugins
  File "nowplaying/inputs/traktor.py", line 177, in __init__
  File "nowplaying/inputs/icecast.py", line 154, in __init__
  File "nowplaying/inputs/__init__.py", line 18, in __init__
  File "nowplaying/inputs/traktor.py", line 204, in defaults
IndexError: list index out of range
[1466] Failed to execute script 'nppyi' due to unhandled exception!

Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
Deleting expired sessions...       2 completed.

[Process completed]

👟 Reproduction steps
Run the app.
Or run the NowPlaying executable from NowPlaying.app/Contents/MacOS/ for terminal log output.
👍 Expected behavior
I was expected to see some GUI.
👎 Actual Behavior
But it even won't start.
💻 Operating system
MacOS
💻 Chipset/CPU
Apple M1
💻 Input source
Serato
🧱 Your Environment
No response

Hmm. Weird. I actually run all the time on M1, so I wonder if it is something else. Thanks for the bug report! I'll take a look.

By chance, do you have a Traktor directory on your system?

d No, Traktor was never installed, so I suppose there is no Traktor directory.
I goggled where it should be and there is no any Traktor directories.

After renaming NI directory app runs with next message:
Configured source None is not supported. Reconfiguring.
Then i got this:

Then it closes.
Also it generates some log files:
2023-03-02T16:09:52+0100 4255 MainProcess/MainThread __main__:run_bootstrap:34 INFO starting up v4.0.0 2023-03-02T16:09:52+0100 4255 MainProcess/MainThread upgrade:upgrade:456 DEBUG Called upgrade 2023-03-02T16:09:52+0100 4255 MainProcess/MainThread connectionpool:_new_conn:1003 DEBUG Starting new HTTPS connection (1): api.github.com:443 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread connectionpool:_make_request:456 DEBUG https://api.github.com:443 "GET /repos/whatsnowplaying/whats-now-playing/releases HTTP/1.1" 200 9831 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread trackrequests:setupdb:98 DEBUG Setting up the database /Users/tabacyclone/Library/Caches/whatsnowplaying/NowPlaying/requests/request.db 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:backup_config:234 INFO Making a backup of config prior to upgrade: /Users/tabacyclone/Documents/NowPlaying/configbackup 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:292 INFO Upgrading config from 4.0.0 to 4.0.0 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:303 DEBUG processing acoustidmb/emailaddress - musicbrainz/emailaddress 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:324 DEBUG acoustidmb/emailaddress does not exist 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:303 DEBUG processing acoustidmb/enabled - musicbrainz/enabled 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:324 DEBUG acoustidmb/enabled does not exist 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:303 DEBUG processing twitchbot/enabled - twitchbot/chat 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:324 DEBUG twitchbot/enabled does not exist 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:303 DEBUG processing twitchbot/token - twitchbot/chattoken 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread upgrade:upgrade:324 DEBUG twitchbot/token does not exist 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread __main__:run_bootstrap:37 DEBUG ending upgrade 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread db:setupsql:265 INFO Clearing cache file /Users/tabacyclone/Library/Caches/whatsnowplaying/NowPlaying/metadb/npsql.db 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread db:setupsql:276 DEBUG Cache db file created 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread config:__init__:57 INFO Logpath: /Users/tabacyclone/Documents/NowPlaying/logs 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread config:__init__:58 INFO Templates: /Users/tabacyclone/Documents/NowPlaying/templates 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread config:__init__:59 INFO Bundle: /Applications/NowPlaying.app/Contents/MacOS 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread config:__init__:60 DEBUG SSL_CERT_FILE=/Applications/NowPlaying.app/Contents/MacOS/certifi/cacert.pem 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread config:__init__:61 DEBUG SSL CA FILE=/Applications/NowPlaying.app/Contents/MacOS/certifi/cacert.pem 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread config:__init__:71 INFO configuration: /Users/tabacyclone/Library/Preferences/com.whatsnowplaying.NowPlaying.plist 2023-03-02T16:09:53+0100 4255 MainProcess/MainThread config:defaults:139 DEBUG set defaults
After renaming NI directory back to it's original name behavior returns to what i described earlier. It fails to run and provide similar log output.

Does it close or does it keep running in the system tray? It should stay up in the system tray.

As I can see with Activity Monitor the process quits.
There is tray icon, but I can't access setting from here.

Chances are, if you relaunch without the NI directory again it will boot as normal now that it has a config.  But that's obviously not ideal.  Let me play around with a new install and see if I can duplicate.  I have a hunch I know what the problem is but will need some time to verify.
Thanks for all the bug info!

Actually, after Basic Configuration, you should be getting the Settings window popped up, but it might be hidden by other windows.  Menu will be disabled during this initial install.

OK, i've tracked down the issue. Very subtle bug!
The usual flow should be:

Run binary.
Software attempts to figure out what is running.
Flashes up the 'Basic Configuration' window you got above.
Pops up the Settings window so you can make adjustments

There's an unrelated crash in the middle of 3 and 4 due to a recent change where the UI code isn't fully loaded yet.  It looks like another simple fix.  Gotta love these x.0.0 releases. Sigh.

After a lot more digging, it is very clear that I broke fresh installs a few revs back and no one caught it. Sigh.

Just published 4.0.1 which should fixed all of the above issues.  🤞

It runs successfully!
Thank you so much. I'm gonna go figure out how it works for now. 🫶🏻

Awesome! Thanks for sticking with it while we debugged. 😄   I'm going to close this one out.  If something new pops up, feel free to file some issues.


Handling SNS message fails if SNS message contains only numeric values

https://github.com/Miserlou/Zappa/blob/d1170b49c03d3ddccb6aeec9ead192d6a49b57ac/zappa/handler.py#L298
I sent a message to SNS which consisted simply of the number 1:
sns = boto3.resource('sns')
topic = sns.Topic('arn:aws:sns:us-west-2:foo:bar')
topic.publish(Message='1')

This caused the following failure:
[1522557727786] 'int' object has no attribute 'get': AttributeError
Traceback (most recent call last):
  File "/var/task/handler.py", line 509, in lambda_handler
  return LambdaHandler.lambda_handler(event, context)
  File "/var/task/handler.py", line 240, in lambda_handler
  return handler.handler(event, context)
  File "/var/task/handler.py", line 384, in handler
  whole_function = self.get_function_for_aws_event(records[0])
  File "/var/task/handler.py", line 293, in get_function_for_aws_event
  if message.get('command'):
AttributeError: 'int' object has no attribute 'get'

Addressing this is not urgent, since it's very easy to avoid this by making my SNS messages contain non-integers.


Add language: Hindi

NOTE: this form is for you to share your language settings with other new users.  If you're a GitHub user, it would be super if you could instead create a Pull Request with your language settings, using the files in this repo's lute/db/demo/language and /stories as references.  Thanks!
If your language settings are working well for you, please share them with other new users by providing the following data:

name: Hindi1
dict_1: https://www.boltidictionary.com/en/search?s=###
dict_2: https://www.bing.com/translator/?from=hi&to=en&text=###
sentence_translation: https://www.bing.com/translator/?from=hi&to=en&text=###
show_romanization: true
right_to_left: false
parser_type: spacedel
split_sentences: .!?|
split_sentence_exceptions: Mr.|Mrs.|Dr.|[A-Z].|Vd.|Vds.
word_chars:a-zA-Z\u0900-\u097F
character_substitutions: ´='|`='|’='|‘='|...=…|..=‥

It's good to have a short demonstration story available as well.  Please paste a family-friendly (!) story below:
Title: Wikipedia Hindi article sample text (from UN Universal Declaration of Human Rights)
Source: https://en.wikipedia.org/wiki/Hindi

अनुच्छेद १(एक): सभी मनुष्य जन्म से स्वतन्त्र तथा मर्यादा और अधिकारों में समान होते हैं। वे तर्क और विवेक से सम्पन्न हैं तथा उन्हें भ्रातृत्व की भावना से परस्पर के प्रति कार्य करना चाहिए।

Actually this has some issues.  The word_chars field should skip \u0964 and \u0965 (DANDA and DOUBLE DANDA), which should be added to split_sentences.
Second, it doesn't seem like the split_sentences field accepts Unicode escape sequences, so they have to be copied directly.
Third, the dict_2 bing URL doesn't see to work, for some reason the application includes the application URL and makes the substitution in the wrong place, e.g. http://localhost:5000/bing/search/12/और/https://www.bing.com/translator/%3Ffrom=hi&to=en&text=%23%23%23, which looks like a combination of image lookup and dict_2 lookup with the ### (%23%23%23) not modified in the dict_2 url.

Addressed by PR #76, thank you!


cilium/cmd, test/runtime: convert test loading invalid policy JSON to unit test

Instead of invoking the per-node cilium command to validate that loading
an invalid policy JSON file fails, convert it to a unit test.

/test-runtime

/test-runtime


Write classes' javadoc

WIP
This should help new users understand how this project works.

All that's left is document is...

Navigator
MinDistanceTo
VirtualFlowHit

This is essentially finished (some methods in Navigator aren't documented, but I think people can understand how it works based on the class' javadoc and the methods that do have documentation). MinDistanceTo isn't documented, but I think the name speaks for itself when taken with Navigator's javadoc and the other implementations of TargetPosition


jsk permtrace bug

Summary
This happens when guild.owner returns None
Reproduction steps
jsk permtrace @ownerofaguild
this has to be done with minimal default intents
Expected results
This should give "ownerofaguild owns the server"
Actual results
It generates an error
Traceback (most recent call last):
permissions[key] = (True, f"{channel.guild.owner.mention} owns the server")
AttributeError: 'NoneType' object has no attribute 'mention'
Checklist

[ ] I have updated discord.py and jishaku to the latest available versions and have confirmed that this issue is still present
[ ] I have searched the open issues for duplicates
[ ] I have shown the entire traceback, if possible
[ ] I have removed my token from display, if visible

System information

This should be replaced with owner_id mention<EMAIL_ADDRESS>


Should NavigationExperimental reducers accept 'reset' as one of default action types?

I want to reset navigationState tree completely into initialState when user logs out.
By looking at the source, default reducers currently do not support 'reset' action.
Could it be a good idea to implement standard 'reset' support for every reducer?
So they will simply return initialState when they receive an action with type 'reset'?

@joonhocho you should probably follow this

@joonhocho NavigationExperimental has no intention to deal with hierarchical navigation states, @807726bcb47ef5b17860c5969a661bee1f8fc651.
🍺

This looks like a "wontfix" so I am going to close this issue. You might want to check out ExNavigation, FWIW.


sigROISignal not emitted in silx 0.10.1?

I have an application which relies on the ROI widget in an instance of a PlotWindow subclass emitting a sigROISignal. In silx 0.10.1 this signal isn't received any more. I've accessed the signal as follows (where self.spectrumis the PlotWindowsubclass instance).
self.spectrum.getCurvesRoiDockWidget().sigROISignal.connect(self.updateMap)

and now also tried
self.spectrum.getCurvesRoiWidget().sigROISignal.connect(self.updateMap)

but no luck. The docs say that this signal is deprecated, but what signal am I supposed to look for instead? The docs refer to CurvesRoiWidget.sigRoiSignal but that doesn't seem to exist.

OK I see that this is raised already in  #2468

Or  #427

Yes, it is fixed in 0.10.2. And already packaged in pypi.

but no luck. The docs say that this signal is deprecated, but what signal am I supposed to look for instead? The docs refer to CurvesRoiWidget.sigRoiSignal but that doesn't seem to exist.

There is a typo on the documentation. The one to be used is the one from CurvesROIWidget. So your second option.

OK I see that this is raised already in #2468

Yes it was missing in some cases (when changing ROI) but it has been fixed for the 0.10.1 so the issue has been fixed and closed (so in 0.10.1).
I just try the simple code (which seems close to yours):

def test():
    app = qt.QApplication([])
    plot = Plot1D()
    plot.addCurve(x=range(10), y=range(10))
    q_obj = TestObj()
    plot.getCurvesRoiWidget().sigROISignal.connect(q_obj.updateMap)

    plot.show()
    app.exec_()

class TestObj(qt.QObject):
    def updateMap(self, *arg, **kwargs):
        print('call back activated')

test()

This seems to work with my configuration. Can you tell us a little bit more about your use case ? When are you expecting signals ? Can you try the code bellow and confirm that you are receiving some signals ?

Thanks. Yes, the example code works. In fact I get 3 signals when I open the ROI widget, 2 signals when I add or delete a ROI, and 3 signals every time I change the limits of a ROI. Is it supposed to work like that and do I have to filter it myself?
I built this on silx 0.3.0 or so and it almost hasn't broken until now so that's OK. Now I also had to change the way I access the ROIs, but the new API (maybe that changed a few releases back) is cleaner.
The application is here,
https://github.com/alexbjorling/nanomax-analysis-utils/tree/master/apps/scanViewer

For information: current behavior on my computer:
when delete a new ROI: 2 signals
When add a new ROI: 2 signals
When the widget is open: 3 signals
When changing ROI limits: I only get one
With 0.9:
When the widget is open: no signals
When I change the active ROI: one signal.
When I had a new ROI: no signals, but I guess the active ROI is not changing (even if the line is selected)
When I delete a ROI: no signals (even if was the active ROI)
Of course we have to check on this and filter it on our side

the PR #2537 should fix the problem.
@alexbjorling would you have time to test this PR and make sure it work with your program ?

Thanks, but I still get 3 signals both with my program and with the toy example above. Did you run the code above?

thanks for the feedback.
When do you have those three signals ? When the widget appears ?
Because now I only have one (with the example above).
Because we create the ICR roi on the fly.
This is a different behavior compare to 0.9 but it make sense from my point of view but can be discuss.

did you reinstall from the 'fix_2527' pull request branch.
something like upstream/pr/2537 if upstream is the silx 'master' repository
so it might be origin/pr/2537 if you cloned directly from the original silx repository

I got three signals when changing the limits of existing ROIs.
I did
git clone https://github.com/payno/silx.git
cd silx
git checkout fix_2527
pip install . --user

Yes it does, both in the above example and in my application. Thanks for acting on this!


resize with different parameters for  specific folder from storage

Step 2: storage-resize-images
This feature request is for extension: storage-resize-images.
What feature would you like to see?
Maybe this is a question, there is a way to apply differents parameters for specific folders ?
ex.
I have 2 folders:
/profile --> I want 40x40 and 180x180
/Images --> I want 200x300, etc.
How would you use it?
Well I want to avoid extra billing from Images that I don't want.

@Ehesp sorry for bothering but can you reopen this?

@Ehesp The solution above does not work as @anthowm says. Can we add this functionality please?
To do this we could do the following:

Add a config value to config.js
imageDir: process.env.IMG_DIR,

Add a new logging method

export const imagePathInvalid = () => {
  console.log("Image path does not match, no processing is required")
};

Check for a match between the value we extract here
const fileDir = path.dirname(filePath);
and config.imageDir.
To also take into consideration glob matching we could utilise minimatch, or equivalent to allow config to be say
<somedirectory>/*/<imageDirectory>

What do you think?


refactoring opportunity - duplicated code

Duplicated onscroll event code for Nearby and Explore map viewers, could be refactored to remove duplication.
ExploreMapFragment

NearbyParentFragment

Thanks for spotting this! Linking an older issue for anyone planning to take this one up as previous attempts to remove redundant code didn't turn out as intended: https://github.com/commons-app/apps-android-commons/issues/5256.

the code between Explore and Nearby has diverged now so the duplicate code displayed no longer exists

@tristan81 has the code diverged recently? If the changes can benefit both nearby and explore, then it would still make sense to de-duplicate. 🙂

The changes to refresh Nearby OnScroll without any distance thresholds mean this example of duplication no longer exists in the code.

The changes to refresh Nearby OnScroll without any distance thresholds, should ideally be implemented in all maps of the app.
Deduplicating would allow all maps to benefit from such improvements. 🙂


Url with params (:id) doesn't work

We get redirected if we use :token for example

Should work again!


soda_scan_execute improvements: Accepting Environment Variables,  Dict-based scan results

Updating the  soda_scan_execute task with options to pass environmental variables to the shell task running the Soda command and to save and return the dictionary-based scan results.

Summary

As discussed at https://github.com/sodadata/prefect-soda-core/issues/16, this PR :

Gives the user the option to receive more detailed scan results of the soda scan tasks.
The same option, would result in the same scan results being saved on the disk. The user can (but does not have to) pass a custom path to store the JSON file.
Gives the user the option to pass environment variables to be passed to the shell task. This could be helpful to pass database credentials to the task. In my flow, I retrieve a standard snowflake-credential block, build a dictionary of database credentials and pass it to this task.
Handles the RuntimeError exception that is raised when the check runs successfully but does not pass. It is not the cleanest way to handle this but in my tests, this was the only way to handle this exception when the soda_scan_execute using map.  However, I'm open to suggestions if you have a better way of handling this issue.

Relevant Issue(s)

https://github.com/sodadata/prefect-soda-core/issues/16
Checklist

[x] Summarized PR's changes in CHANGELOG.md

Hey @fakhavan 👋
Would it make sense to return the content of the scan result file as a JSON/Dict for the soda_scan_execute task?

@fakhavan with regard to the Static analysis failure, you should be able to fix it by changing isort version to 5.12.0 in .pre-commit-config.yaml

Hey @AlessandroLollo
I pushed some more changes including the option to retrieve the dictionary-based scan results. I have updated the PR description if you want some visibility on what has changed.
Most of these changes are the result of making the task work in my flow.
Drilling down on the exception issue, when the task is used in mapped mode, one task (scan's) failure would cause the whole flow (including other scans) to fail. I tried return_state=True as it's the main way of handling failures but seems like this option does not work in the mapped mode.
I also could not find a way to handle this with the underlying shell task. So I resorted to using manual exception catching. However, I might have missed something so I'm looking forward to your suggestions.
Cheers

Hey @AlessandroLollo I pushed some more changes including the option to retrieve the dictionary-based scan results. I have updated the PR description if you want some visibility on what has changed. Most of these changes are the result of making the task work in my flow.
Drilling down on the exception issue, when the task is used in mapped mode, one task (scan's) failure would cause the whole flow (including other scans) to fail. I tried return_state=True as it's the main way of handling failures but seems like this option does not work in the mapped mode. I also could not find a way to handle this with the underlying shell task. So I resorted to using manual exception catching. However, I might have missed something so I'm looking forward to your suggestions.
Cheers

Hey @fakhavan 👋
With regards to the issues with mapped mode, I suggest you to ask in the Prefect community!


Add support for non-UTF8 encoded databases

I was trying to parse some .mdb file and I noticed that it is incorrectly decoding text from non-UTF8 encoded databases. In my case, ISO-8859-2 encoded.
I found this note in mdbtools HACKING.md

In Jet3, the encoding of text depends on the machine on which it was created. So for databases created on U.S. English systems, it can be expected that text is encoded in CP1252. This is the default used by mdbtools. If you know that another encoding has been used, you can override the default by setting the environment variable MDB_JET3_CHARSET. To find out what encodings will work on your system, run 'iconv -l'.
(https://github.com/mdbtools/mdbtools/blob/master/HACKING.md#text-data-type)

So I added a configuration option to change the default "utf-8" charset. There was no config before, so let me know if you think that it should be passed differently.

Thanks for the pull request!
I think that adding a configuration is a bit of an overkill in this case. A cleaner solution is to:

Add the "encoding" variable to AccessParser init with a default value of "utf-8"
Set self.encoding to the "encoding" parameter
Pass self.encoding to the parse_type function
Add the encoding options(utf-8 / ISO-8859-2) to the class documentation

Add the encoding options(utf-8 / ISO-8859-2) to the class documentation

What class documentation?

Hi, Thanks again it looks good. One last thing i think we should change is saving the encoding to the AccessTable class. This way you son't need to pass encoding as a variable everywhere, you could just use self.encoding where you need it.

My approach was that the coding in JET3 is not contained in the database, so it should not be in the object representing the table.


StickyHeaders for GridLayoutManager

How to categorize StickyHeaders for GridLayoutManager? So the header will be match parent and content span count will be 3
Result:

Expected:

And is it possible to combine sticky header and fast scroller with this library?

@hendrawd as noted the StickyHeadeR is a external library. I do not think they have support currently for grids.

And yes it is possible to combine the two

Yes actually https://github.com/timehop/sticky-headers-recyclerview/pull/106 has fix for gridview, i am trying it now

Ok great :)

@hendrawd I'm having the same issue, what was your workaround for this?

@ClarkXP To be honest my attempt to fix that failed, and I changed to https://github.com/FutureMind/recycler-fast-scroll and implement https://github.com/FutureMind/recycler-fast-scroll/blob/master/fastscroll/src/main/java/com/futuremind/recyclerviewfastscroll/SectionTitleProvider.java , but the library is not active(last update 2 years ago), you might want to consider that.

@hendrawd I did successfully implement stickyheader with fastadapter, My workaround was fill the grid with empty items after section's end.


Added solution to array-sum in Python using Recursion.

Yup. Thanks @IronVenom and sorry for the delay.


Initialize community pool with funds

In order to do this, have to update the supply in the genesis file, i.e:
      "supply": [
        { "amount": "10000000000000", "denom": "uatom" },
        { "amount": "10010000000000000", "denom": "ucredits" },
        { "amount": "10031000000000000", "denom": "ustarx" }
      ],

and also the community pool:
      "fee_pool": {
        "community_pool": [
            { "amount": "21000000000000", "denom": "ustarx" }
          ]
      },


Add support for Rarar Geocoding

Hello @JustinCanton , I saw various enhancements about adding new providers, so if I can suggest one, I would suggest Radar. They have well-written APIs, which works pretty well, and a free tier of 100.000 calls a month.
Cheers

Hi @ollie10, thank you for the suggestion! They look like a good provider with clear documentation. I will add them into the roadmap and hopefully have support for them soon.