[Feature] Enable Unbounded Rolling Secondary Calculation

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature
For the Rolling Secondary Calculation, I propose interval can be optionally None which would default the window frame of the function to rows between unbounded preceding and current row. In this scenario, the aliased metric name would simply be rolling_[metric_name].
Describe alternatives you've considered
I'm currently overriding the macro(s) to enable unbounded to be injected rather than interval - 1 to enable this. I considered injecting a larger integer, but Snowflake limits the window frame to 1000 rows when it's specified. I also considered doing this via the BI layer, but that would require including all metric data in the view (i.e. can't be filtered) and would be difficult to maintain.
Who will this benefit?
For many metrics, a complete cumulative view over time is incredibly valuable (ex. subscriber count).
Are you interested in contributing this feature?
Yes, I can contribute to complete this
Anything else?
From what I can tell, updates would be needed:

[ ] Readme Documentation
[ ] Actual Rolling Calculation Generation
[ ] Configuration Validation
[ ] Alias Generation

The Configuration Validation could use updating since it's using the incorrect terminology for the existing error message (it says period_over_period rather than rolling).

@andresrecalde just getting around to this after Coalesce - I think this is definitely something we'd consider for a future release! If you're still interested in contributing to this, I'd love to help provide you direction to get it merged for a future patch version.
I think you've got a pretty good handle of all then work that would need to be done. All the areas you laid out are exactly where I would have pointed you otherwise!

Thanks @callum-mcdata! I'm happy to contribute here; let me know how to proceed!

Lovely! Apologies if you're familiar with contributing to dbt Labs repos but I'll lay out all the steps just in case you're not.

Create a fork of this repo in your github account.
Create a branch in that fork with whatever name is relevant to the feature you're adding
Add all the code that you need to accomplish it (more on this below)
Add a pytest file to confirm that this behavior matches what you expect (I can walk you through this as well!)
Open a PR from your forked branch into the main branch of this repo!
Wait for me to review 🚀

For the actual code changes, I think you had a pretty good handle in all of the files that you raised in your initial issue. I think the changes you suggested to those line up with what we'd be looking for and I could offer any guidance if you run into blockers!
Does that sound good to you?

@andresrecalde just checking in to see if you've been able to make any progress in this area!

@andresrecalde I hope you don't mind but I had some time this week allocated to the metrics package and decided this was a good thing to work on! I've got an open PR here #186 that should merge in today and be in tomorrow's release.
Hopefully the excitement over the release is bigger than the bummer of not contributing on this! If you're interested in contributing on any other area I'm more than happy to work with you and set up a project. The reason I picked this is because it was one I'd heard requested by some other community members so I figured sooner was better!

Hey @callum-mcdata, so sorry I missed these messages; it's been a hectic few weeks! I haven't had a second to work on this, so very excited it's making it in!

No need to apologize, I totally understand! This PR should be merged in by midday and then be part of the 1.3.2 release later today! The TLDR is that interval is now an optional input and if no interval is provided then it defaults to an unbounded rolling calc.


Add MainQueue and PreferenceQueue

Pull Request Test Coverage Report for Build 124

10 of 13 (76.92%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.7%) to 89.012%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/seedu/address/model/patientqueue/PreferenceQueue.java
0
3
0.0%

Totals

Change from base Build 109:
-1.7%

Covered Lines:
1612

Relevant Lines:
1811

💛  - Coveralls

Work in progress.


Improve warning when SQS queue resolving fails no access GetQueueUrl

Before this commit the following message is provided "Ignoring queue with name 'queue name' as it does not exist.". This can be misleading when the queue does exist, but there is no permission provided to perform "sqs:GetQueueUrl".  The AWS SDK's QueueDoesNotExistException message is different when the potentially there is no access to perform GetQueueUrl: "The specified queue does not exist or you do not have access to it.". To make it clear exactly what is failing (GetQueueUrl) a custom message is provided.

@JulienRentrop Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@JulienRentrop Thank you for signing the Contributor License Agreement!


Make get_random_privkey return a PrivateKey

As requested in https://github.com/raiden-network/raiden-services/pull/800.

Not strictly related, but maybe we want to fix those while we're at it:
➜  raiden-contracts git:(privkey-type) rg "key: str"
raiden_contracts/utils/token_ops.py
137:    private_key: str,
156:    private_key: str,
176:    private_key: str,

raiden_contracts/tests/deprecation_switch_testnet.py
37:    private_key: str,

raiden_contracts/tests/test_print_gas.py
397:    def concat_iou_data(ious: List[Dict], key: str) -> List:

raiden_contracts/tests/test_deploy_script.py
756:def deploy_token_arguments(privkey: str) -> List[str]:
815:    privkey: str,
961:    privkey: str,

raiden_contracts/deploy/__main__.py
97:    private_key: str,
197:    private_key: str,
315:    private_key: str,
395:    private_key: str,
456:    private_key: str,

Those are not private keys, but private key file names, which just have this variable name to make the cli param and variable name match up.


Organization fields not saving on account creation

Steps to Reproduce
Create a new account including organization information.
Expected Behavior
The account should be created attached to an organization.
Actual Behavior
The account is not created with the given organization.
Any additional comments?
No response

https://github.com/hydroserver2/hydroserver-api-services/pull/207


Missing ... menu in GameMode

Hi
I've just installed a clean version of the bazzite-gnome-deck image using the 2.0.2 installer on an all AMD PC and updated to the latest stable version.
But in the GameMode I'm not able to access the performance settings or anything under the ... menu.
The GUI doesn't show the ... button at all and pressing xbox+a on the controller doesn't do anything either.
Am I missing some packages or configuration?

Got the same thing, try xbox then a instead of xbox+a
Work for me

Thanks @Mitchou that actually works!
But I'd still argue that the current behaviour is a bug though. There's no indication that the menu is actually available when in GameMode.

Thanks @Mitchou that actually works!
But I'd still argue that the current behaviour is a bug though. There's no indication that the menu is actually available when in GameMode.

it is an issue with the xinput driver in linux and it affects multiple linux systems (including stock steamOS last time i checked)
It does not affect playstation controllers and switch controllers
The fact that there is no indication that the menu is available is a Steam issue, bazzite has no control over that sadly

I see, then we can only wait.
Thanks for clarifying!

no problem :smile:

when I'm using a tv-style remote for keyboard/mouse (i.e. pepper job remote), the missing ... at the bottom means I can't click on it to open the menu and I have to actually connect the xbox controller to do xbox+a. We need the ... for controllers without a guide/nexus button like the pepper jobs remote

This is not something we can add to steam, only valve can do it.
You can open the right menu with CTRL+2 however that does not work when an application/game is running, this is something that valve will have to fix.


Resolves #1407

The cell will no longer display route information if there is no route information in the bookmark.

Travis failed due to a Carthage error.
Close and reopened pr to trigger a new build per https://github.com/travis-ci/travis-ci/issues/576#issuecomment-65317915_.


Running readme-md-generator with -y flag breaks author website

Describe the bug
Running readme-md-generator with -y flag outputs incorrect author website. It prints the default function of the author-website question instead of its value.
To Reproduce
npx readme-md-generator -y
Screenshots

It should execute the function if default property is a function in utils.getDefaultAnswers. Are you interested in working on this @anku255 ?

It should execute the function if default property is a function in utils.getDefaultAnswers. Are you interested in working on this @anku255 ?

Yeah, I would love to take a shot at this. 😃


[New Feature]: Add Theme Switcher Button to Change Background Video

🎮 feature Request
The feature adds a theme switcher button to the website, allowing users to choose between different background videos. When the user clicks the theme switcher button, a dropdown with theme options appears. Selecting a theme changes the background video to the corresponding choice.
This feature will add more background theme for the user such as waterfall, nature, etc. This will help in improving user experience by providing the user options for customizing the background of the website.
I will add a background folder to the project directory, which will contain all the background videos. This folder will be referenced in the code to dynamically switch between different video backgrounds based on the selected theme.
Point down the features
Theme Switcher Button: A button labeled "Change Theme" to allow users to access different background themes.
Theme Options Dropdown: A dropdown menu with multiple theme options that change the background video when selected.
Background Video Switching: Different background videos are loaded and played based on the selected theme.
Overlay Container: An overlay container with a semi-transparent background to ensure content visibility over the background videos.
Enhanced Readability: Improved text color and visibility for better contrast and readability against varying background videos.
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

This is a nice suggestion 👍

Hey, can you please assign me this issue if it is not solved? This is my first time making an open-source contribution, and I really want to showcase my skills. I am very familiar with languages like Java, HTML, CSS, and JS. Apart from coding, I'm an ux/ui freelancer as well.

Hi @Siddhi561
Can you take a look at other issues? This has just been assigned. I recently created a simple issue that might interest you, Do take a look


Add "sideEffects": false to package.json

More details on "sideEffects": false

Added in 074c69522acf34febf7b5baddb66f96346ff9b63 (forgot to reference in commit message).


Retry button is not clickable

The retry button is clickable in the original game.

@taneltm thanks for the report. This is indeed a bug. I have made a fix and published it. Will close this issue once you confirmed that the issue has been fixed.

Confirmed, it's now fixed.


Update rack-cors

See: title.

Coverage remained the same at 96.09% when pulling a3710c211814cfa2655bff7fff56db75a18193ab on RickCarlino:august_security into 9d397560361af5f6e95115deef0c6d45b57f7182 on openfarmcc:master.


dsn_patch_3

reason to reject @slysnivy PR - updated music files in their location and updated dsn_class.py to detect all the audio files as well
dsn_class.py

song track list got updated including all the new songs available

Uploaded files

Image files have been deleted due to non-use
Audio files have been renamed

@shoc71 Also remember to change the individual commit name for dsn py scripts to keep track of their version number!

@slysnivy Oh thanks for the reminder, I thought it would show up on the commit correctly but it didn't.


Newsessions

completed the sessions feature, with security checks for teacher ownership, add, edit, and delete features
wrote tests for all of the session.py functions
cleaned up css

I need to fix the session view if a teacher doesn't own the course, the flex display does some weird stuff without the buttons, lol
i'll look into it later. it works, so i'm happy! lol


feat: add git hooks

Description
This pull request provides an pre-push hook.
The hook checks for changes to .yaml files and Chart.yaml files.
If a change is detected or the branch has no upstream, then it will check the changed files (all files if no upstream) and fail if there are any errors.
Fixes #710
Type of change

[X] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

How Has This Been Tested?
No upstream check
I executed the hook before pushing this change.
File change check
I changed and committed local files, then run the hook
Correctness test
The correctness of test results rely on external tools (helm & yamllint ) and can not easily be verified by me.
Test Configuration:

Python Version: 3.9.7
Helm Version: v3.7.0

Checklist:

[x] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[X] I have checked that my issue complies with the Contributing guidelines

This will generate lots of warnings and errors if merged to staging, because our yaml files where never checked before

If it causes a lot of errors, can we still work and commit then?

If it causes a lot of errors, can we still work and commit then?

Yes, you can either simply not enable the githooks (by not following the CONTRIBUTING.md) or by using the --no-verify flag when pushing.
Also it will only check yaml files if there are changes or if there is no upstream.


host: Update containerinit stream logging

This is to help debug https://github.com/flynn/flynn/issues/907

LGTM


vendor: update dependencies

This updates all the dependencies, but in particular fixes a dep for go-digest so it and containers/image can coexist.

Looks good to me @erikh

I don’t think vendoring any version in skopeo can fix the vendor-caused type mismatch breaking #240.
We do need to figure out how to keep containers/image and skopeo’s vendor.conf in sync (and how to make sure they don’t stagnate on years-old versions), but that’s not quite the same thing I guess.

part of the big problem is that we're not using SHAs and instead tracking master. This causes trouble because we can't look back and see what master was (easily, at least) based on a revision history because it's been wiped out by vndr.
Another option here would be to eliminate the vendor directory before running skopeo tests; this might  eliminate some problems, but not all.
I think the better solution is -- like you said -- to keep vendor.conf in sync. I wonder if we could source it from a gist or something?

Seems pretty ghetto but it'd work! :D

part of the big problem is that we're not using SHAs and instead tracking master. This causes trouble because we can't look back and see what master was (easily, at least) based on a revision history because it's been wiped out by vndr.

We already have #304 for the digests vs. master discussion, let’s not duplicate it here please.

Another option here would be to eliminate the vendor directory before running skopeo tests; this might  eliminate some problems, but not all.

Like, test skopeo against whatever happens to be in $GOPATH? I am probably misunderstanding.

I think the better solution is -- like you said -- to keep vendor.conf in sync. I wonder if we could source it from a gist or something?

Repeating myself from above, I don’t think that using the exact same version of go-digest fixes the mismatched type names between containers/image and skopeo. That can only be fixed by containers/image, when used in skopeo, not having its own vendored copy of go-digest, of any version of go-digest.

I can confirm this patch fixes it. Can you provide an alternative if you
are unhappy with this patch? Both skopeo and image are broken right now.
On Wed, Feb 22, 2017 at 11:43 AM, Miloslav Trmač<EMAIL_ADDRESS>wrote:

part of the big problem is that we're not using SHAs and instead tracking
master. This causes trouble because we can't look back and see what master
was (easily, at least) based on a revision history because it's been wiped
out by vndr.
We already have #304 https://github.com/projectatomic/skopeo/issues/304
for the digests vs. master discussion, let’s not duplicate it here please.
Another option here would be to eliminate the vendor directory before
running skopeo tests; this might eliminate some problems, but not all.
Like, test skopeo against whatever happens to be in $GOPATH? I am probably
misunderstanding.
I think the better solution is -- like you said -- to keep vendor.conf in
sync. I wonder if we could source it from a gist or something?
Repeating myself from above, I don’t think that using the exact same
version of go-digest fixes the mismatched type names between
containers/image and skopeo. That can only be fixed by containers/image,
when used in skopeo, not having its own vendored copy of go-digest, of
any version of go-digest.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/projectatomic/skopeo/pull/312#issuecomment-281780265,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABJ6z3jlsLfihxUDc3LD70XRyDkS7ABks5rfI_egaJpZM4MHO_M
.

I can confirm this patch fixes it.

To be clear, fixes what? I am referring to the recent failure in https://github.com/containers/image/pull/240 :
cmd/skopeo/inspect.go:86: cannot assign "github.com/projectatomic/skopeo/vendor/github.com/containers/image/vendor/github.com/opencontainers/go-digest".Digest to outputData.Digest (type "github.com/projectatomic/skopeo/vendor/github.com/opencontainers/go-digest".Digest) in multiple assignment

This is a simple type Digest string in both packages / versions, this is not an interface mismatch which can be solved by bumping either of the dependencies; the issue is that the type command has created a named type incompatible with any other named type, and both projects having independent vendoring causes them to create two different named types.
And I have posted the suggestion twice in https://github.com/containers/image/pull/240:

When test-skopeo copies containers/image into skopeo’s vendor subdirectory, it must not copy containers/image/vendor in there as well.

I think this is resolved; do we need to keep this one around?

If this was intended to fix the digest.Digest type mismatches in #240, I think #240 has fixed it the right way and this is not necessary. Or was this intended to fix something else?

Will close for now, we can always re-open if necessary.


feat: manga demon

🎉
Checklist:

[x] Set appropriate nsfw value
[x] Tested the modifications by running it on the simulator or a test device

Looks like they changed their domain within the last week, I'll pr an update soon™


Release support for cross-os caching as opt-in feature

Add documentation for cross-os caching

Description

Make new release for support of cross-os caching as opt-in feature and add documentation around cross-os caching.
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation (add or update README or docs)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

https://commons.m.wikimedia.org/wiki/Archive
https://commons.m.wikimedia.org/wiki/Archive
El vie., 6 de enero de 2023 3:51 a. m., Sampark Sharma <
@.***> escribió:

Add documentation for cross-os caching
Description
Make new release for support of cross-os caching as opt-in feature and add
documentation around cross-os caching.
Motivation and Context How Has This Been Tested? Screenshots (if
appropriate): Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing
functionality to change)
Documentation (add or update README or docs)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

You can view, comment on, or merge this pull request online at:
https://github.com/actions/cache/pull/1060
Commit Summary

192d0bc
https://github.com/actions/cache/pull/1060/commits/192d0bc0f92940ab6f6ed716a64e590a94305aae
Release support for cross-os caching as opt-in feature

File Changes
(5 files https://github.com/actions/cache/pull/1060/files)

M README.md
https://github.com/actions/cache/pull/1060/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5
(4)
M RELEASES.md
https://github.com/actions/cache/pull/1060/files#diff-4a00447b47c36ebd3ded77321deff288e424f4605496ee1199fc9953a20f4473
(6)
M package-lock.json
https://github.com/actions/cache/pull/1060/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
(4)
M package.json
https://github.com/actions/cache/pull/1060/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
(2)
M tips-and-workarounds.md
https://github.com/actions/cache/pull/1060/files#diff-f3ffff2cc49274fbccd1d379ca2b1d4165a9bc3534d03ddfdf291a6760ee20e3
(22)

Patch Links:

https://github.com/actions/cache/pull/1060.patch
https://github.com/actions/cache/pull/1060.diff

—
Reply to this email directly, view it on GitHub
https://github.com/actions/cache/pull/1060, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZUNEUOZOLANE2SHFUIMKMLWQ7TK3ANCNFSM6AAAAAATS44V3Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

8
El vie., 6 de enero de 2023 4:05 a. m., Lovepreet Singh <
@.***> escribió:

@.**** commented on this pull request.
Minor comments.
In tips-and-workarounds.md
https://github.com/actions/cache/pull/1060#discussion_r1063293637:

-To improve cache restore performance, we can re-enable zstd as the compression algorithm using the following workaround. Add the following step to your workflow before the cache step:

-```yaml

if: ${{ runner.os == 'Windows' }}

 name: Use GNU tar

 shell: cmd

 run: |

   echo "Adding GNU tar to PATH"

   echo C:\Program Files\Git\usr\bin>>"%GITHUB_PATH%"

-```

-The cache action will use GNU tar instead of bsd tar on Windows. This should work on all Github Hosted runners as it is. For self-hosted runners, please ensure you have GNU tar and zstd installed.

-The above workaround is also needed if you wish to use cross-os caching since difference of compression algorithms will result in different cache versions for the same cache key. So the above workaround will ensure zstd is used for caching on all platforms thus resulting in the same cache version for the same cache key.
+## Cross OS cache
+From v3.2.3 cache is cross os compatible when enableCrossOsArchive input is passed as true. This means that a cache created on ubuntu-latest can be used by windows-latest provided the workflow which runs on windows-latest have input enableCrossOsArchive as true. This is useful when you want to cache dependencies which are available on different the OSs. This will help reduce the consumption of the cache quota. Things to keep in mind while using this feature:
Need to also add the enableCrossOsArchive to the inputs section in the
README otherwise discoverability will be low.
In tips-and-workarounds.md
https://github.com/actions/cache/pull/1060#discussion_r1063295380:

-To improve cache restore performance, we can re-enable zstd as the compression algorithm using the following workaround. Add the following step to your workflow before the cache step:

-```yaml

if: ${{ runner.os == 'Windows' }}

 name: Use GNU tar

 shell: cmd

 run: |

   echo "Adding GNU tar to PATH"

   echo C:\Program Files\Git\usr\bin>>"%GITHUB_PATH%"

-```

-The cache action will use GNU tar instead of bsd tar on Windows. This should work on all Github Hosted runners as it is. For self-hosted runners, please ensure you have GNU tar and zstd installed.

-The above workaround is also needed if you wish to use cross-os caching since difference of compression algorithms will result in different cache versions for the same cache key. So the above workaround will ensure zstd is used for caching on all platforms thus resulting in the same cache version for the same cache key.
+## Cross OS cache
+From v3.2.3 cache is cross os compatible when enableCrossOsArchive input is passed as true. This means that a cache created on ubuntu-latest can be used by windows-latest provided the workflow which runs on windows-latest have input enableCrossOsArchive as true. This is useful when you want to cache dependencies which are available on different the OSs. This will help reduce the consumption of the cache quota. Things to keep in mind while using this feature:
⬇ Suggested change
-From v3.2.3 cache is cross os compatible when enableCrossOsArchive input is passed as true. This means that a cache created on ubuntu-latest can be used by windows-latest provided the workflow which runs on windows-latest have input enableCrossOsArchive as true. This is useful when you want to cache dependencies which are available on different the OSs. This will help reduce the consumption of the cache quota. Things to keep in mind while using this feature:
+From v3.2.3 cache is cross-os compatible when enableCrossOsArchive input is passed as true. This means that a cache created on ubuntu-latest or mac-latest can be used by windows-latest and vice versa, provided the workflow which runs on windows-latest have input enableCrossOsArchive as true. This is useful to cache dependencies which are independent of the runner platform. This will help reduce the consumption of the cache quota and help build for multiple platforms from the same cache. Things to keep in mind while using this feature:

In tips-and-workarounds.md
https://github.com/actions/cache/pull/1060#discussion_r1063296579:

if: ${{ runner.os == 'Windows' }}

 name: Use GNU tar

 shell: cmd

 run: |

   echo "Adding GNU tar to PATH"

   echo C:\Program Files\Git\usr\bin>>"%GITHUB_PATH%"

-```

-The cache action will use GNU tar instead of bsd tar on Windows. This should work on all Github Hosted runners as it is. For self-hosted runners, please ensure you have GNU tar and zstd installed.

-The above workaround is also needed if you wish to use cross-os caching since difference of compression algorithms will result in different cache versions for the same cache key. So the above workaround will ensure zstd is used for caching on all platforms thus resulting in the same cache version for the same cache key.
+## Cross OS cache
+From v3.2.3 cache is cross os compatible when enableCrossOsArchive input is passed as true. This means that a cache created on ubuntu-latest can be used by windows-latest provided the workflow which runs on windows-latest have input enableCrossOsArchive as true. This is useful when you want to cache dependencies which are available on different the OSs. This will help reduce the consumption of the cache quota. Things to keep in mind while using this feature:
+- Only cache those files which are compatible across OSs.
+- Caching symlinks might cause issues while restoration as they work differently on different OSs.
+- Put runner OS in the cache key if that cache is not meant to be used across OSs to prevent cross-os.
Should not have this recommendation here as it might confuse the user with
the usage of enableCrossOsArchive input. IMO, this could go in the
recipes or common use cases @kotewar https://github.com/kotewar is
working on.
—
Reply to this email directly, view it on GitHub
https://github.com/actions/cache/pull/1060#pullrequestreview-1238612197,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZUNEUP4BT4V5CW77BZBBIDWQ7U47ANCNFSM6AAAAAATS44V3Q
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Added Contributor's Page

Description
Added Contributor's Page that matches with the overall theme of website.
It fetches the data directly from the repo. It is easy to navigate to the contributor's profile.
Related Issues

Closes  #453

Screenshots / videos (if applicable)
https://github.com/user-attachments/assets/68d6ad8f-2170-4f80-88cf-5313c617725f
Checklist
[X] I have gone through the contributing guide
[X]  I have updated my branch and synced it with project main branch before making this PR
[X]  I have performed a self-review of my code
[X]  I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

@Anjaliavv51 , Please review this PR and Can you please label it with level 3 for my work.
Thank You!!

@TBorundia place contributor.ccs file in css folder.

@Anjaliavv51 , Please review this PR and Can you please label it with level 3 for my work. Thank You!!

only level three will be approvbed!


Milking mooshrooms

*Description of issue:
Milking mooshrooms (with a bowl) doesn't give money. Milking normal cows does.
EDIT : also tried with Mooshroom, Mushroom Cow and MushroomCow
CONFIG SECTION (DELETE IF NOT RELEVANT):
Milk:
      Mushroom_Cow:
        income: 0.65
        experience: 1.5

Server Type (Spigot/Paperspigot/etc):
PaperSpigot
Server Version (using /ver):
Paper 1.15.2 version 155

How you can milk cows with bowl? Are you using a mod?

I'm milking normal cows with a bucket, but right-clicking mooshrooms with a bowl gives 1 soup.
So is the "Milk" jobs action only applying to milking normal cows (with a bucket) ? If so, is there another way to use mooshrooms' milking (with a bowl) ?
Thanks

How you can milk cows with bowl? Are you using a mod?

This is actually a vanilla feature of minecraft. You can milk mooshorooms with a bowl to get mushroom stew.


Add support for different file extensions for tech with respect for real order

Please refer https://github.com/enb-make/enb-stylus/issues/47 for an example.
Idea is to introduce new syntax like .useFileList('css || styl') for such cases.

Hello, @tadatuta.
Let's not introduce new non obvious syntaxes. I would suggest one of the following approaches:

To add another method useXxx for this case.
To add options for useFileList like this useFileList(['css', 'styl'], {reorder: true}) or something like this.

The last approach (with an option) allows further usage of options in public tech API.

@mdevils both variants solve the issue :+1:

There is another option when part of suffixes need to be processed with reorder: true, and some with reorder: false.
For example, if one suffix is alias: useFileList(['vanilla.js', 'browser.js || js']).
How to express it using the reorder option?

May be you can add the aliases option?
useFileList(['vanilla.js', 'browser.js'], {
    reorder: true,
    aliases: { 'browser.js': 'js' }
});

But how to override this with sourceSuffixes?
{
    sourceSuffixes: ['vanilla.js', 'browser.js'],
    sourceSuffixesOptions: {
        reorder: true,
        aliases: { 'browser.js': 'js' }
    }
});

For example, if one suffix is alias: useFileList(['vanilla.js', 'browser.js || js']).
How to express it using the reorder option?

At which point do you really need it?

At which point do you really need it?

in bem-core we have scheme when order should be just like @andrewblond described: vanilla.js should always go first and browser.js and js should respect level order as they are just synonyms.

@andrewblond if you introduce alias option, you don't need the reorder option I guess.

if you introduce alias option, you don't need the reorder option I guess.

sure
@mdevils is alias name appropriate for the case with styl and css?

@andrewblond I'm not sure. Try to choose more appropriate name.

I think the group or groups name is suitable for all cases.
For stylus:
// in `build-flow`
useFileList(['styl'], {
    group: { 'styl': ['css', 'styl'] }
});

// in tech options
{
    sourceSuffixes: ['styl'],
    sourceSuffixesGroup: { 'styl': ['css', 'styl'] }
}

For browser.js:
// in `build-flow`
useFileList(['vanilla.js', 'browser.js'], {
    group: { 'browser.js': ['js', 'browser.js'] }
});

// in tech options
{
    sourceSuffixes: ['vanilla.js', 'browser.js'],
    sourceSuffixesGroup: { 'browser.js': ['js', 'browser.js'] }
}

I think that if we fix #232 then this issue does not need to do.

agree


Automatically focus search input when switching catalog

I often find myself typing a search query and then realising I have the wrong button selected (Library instead of Apple Music or vice versa). Clicking to change loses focus, which means you have to click back in the input to then hit return and search.

Would it be worthwhile to have it automatically run the search again rather than also having to click enter?

Yup, I think that makes sense. Updated.

Thanks.
I tested out the latest version. It seems that the event handling for running a new search isn't working right. I did:

Do a search while on the "Apple Music"
Switch to "Library". Observe that nothing seems to change
Switch back to "Apple Music". Notice now that the output is for your Library and not Apple Music

I get the same behaviour in Safari, Chrome and Firefox on macOS.
Some searching shows that v-on:change can get called before the model is updated. Suggestion is to use a $watch instead.

Switched to the input event, which is triggered after the model updates.

Looks good now. Thanks!


Some segments are too long

On a larger file you can expect to get warnings like the following
Token indices sequence length is longer than the specified maximum sequence length
for this model (814 > 512). Running this sequence through the model will result in
indexing errors

The code tends to hang on those longer segments. Add some code to split segments that are too long.
On a different note, there seem to be no memory issues and there seems to be no slowdown on longer segments. Processing speed per token is consistently between 0.02 and 0.1 seconds per token, actually being slower on shorter segments. This was tested for segments up to 200 tokens.

Decreased the maximum pause between segments and added a requirement that segments cannot be longer than 256 tokens.


Allow overriding the CMake target name

Allow overriding the CMake target name. This may be needed if two components add the library via add_subdirectory or FetchContent. CMake targets are globally unique and unless one the components renames it, there will be a clash

Pull request checklist
Read the Contribution Guidelines for detailed information.

[x]  Changes are described in the pull request, or an existing issue is referenced.
[x]  The test suite compiles and runs without error.
[x]  Code coverage is 100%. Test cases can be added by editing the test suite.
[x]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

coverage: 100.0%. remained the same
when pulling 7ae3ff6ed67f7db4d5534aded6153ca03bd83138 on alpaca-core:override-cmake-target-name
into<PHONE_NUMBER>1b3dd96dd171e5a5ad5aa915834c35 on nlohmann:develop.

Thanks!


Alphabetized distro entries in index.md

Entries in index.md were not listed in alphabetical order, or order of even of the rankings on distrowatch.
Created additional entries for two of the most popular distros and listed them all in alphabetic order.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Entries in index.md were not listed in alphabetical order, or order of even of the rankings on distrowatch.
Created additional entries for two of the most popular distros and listed them all in alphabetic order.


When connecting to a non existing FTP server from the Client doesn't give any error

Description:
Executing the following code doesn't give any error even though I haven't started an FTP server.
import ballerina/io;

// Define FTP client configuration
ftp:ClientEndpointConfig ftpConfig = {
    protocol: ftp:FTP,
    host: "localhost",
    port: 9090
};

public function main() {
    ftp:Client ftpClient = new(ftpConfig);
    ftp:Error? mkdirResponse = ftpClient->mkdir("Users/bhashinee/Documents/Development/examples");
    if (mkdirResponse is ftp:Error) {
        io:println(mkdirResponse.message());
    } else {
        io:println("mkdir successful");
    }
}

This should result in a connection refused error.
Affected Versions:
Ballerina Beta1 release

This is fixed from: https://github.com/ballerina-platform/module-ballerina-ftp/pull/300 and https://github.com/ballerina-platform/module-ballerina-ftp/pull/297


SIM-Config providers and models in settings screen

@cristiam86 could you please provide a small description of what's expected here? thanks!

maybe related to / blocked by #359

Add new provider/model modal
Add list of providers/models in the settings + udpate/delete/add


Fix 'PHP_EXTNAME_SHARED' is undefined

I tried to build the extension on Windows for PHP 7.3.0 and get this error C:\php-sdk\php-7.3.0\vc15\x64\php-7.3.0-src\configure.js(6120, 3) Microsoft JScript runtime error: 'PHP_EXTNAME_SHARED' is undefined when running configure --disable-all --enable-cli --with-vips.
It seems the same issue is causing pecl.php.net not being able build the Windows binaries:
https://windows.php.net/downloads/pecl/releases/vips/1.0.9/logs/php_vips-1.0.9-7.2-ts-vc15-x64-logs.zip  -> configure-php_vips-1.0.9-7.2-ts-vc15-x64.txt
https://windows.php.net/downloads/pecl/releases/vips/1.0.9/
I have not been able to find the docs describing what the third argument for the EXTENSION function in the config.w32 files does but looking at official extensions they pass PHP_ extension name _SHARED.
Changing the variable name from:
EXTENSION("vips", "vips.c", PHP_EXTNAME_SHARED, "/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1");

to:
EXTENSION("vips", "vips.c", PHP_VIPS_SHARED, "/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1");

fixes the issue and now executes configure --disable-all --enable-cli --with-vips without error.

That's great, thank you! I've never tried building it on Windows, so it's good to hear it works.
Do all tests pass?

I've made a 1.0.10 including this change, would you be able to test it before I upload to pecl?

Hi, I got statically compiled working with two additional changes.
config.w32:
// $Id$
// vim:ft=javascript

ARG_WITH("vips", "VIPS support", "no");

if (PHP_VIPS != "no") {
	if (CHECK_HEADER_ADD_INCLUDE("vips.h", "CFLAGS_VIPS", PHP_VIPS+ ";" + PHP_PHP_BUILD + "\\include\\vips") &&
		CHECK_HEADER_ADD_INCLUDE("glib.h", "CFLAGS_VIPS", PHP_VIPS+ ";" + PHP_PHP_BUILD + "\\include\\glib-2.0") &&
		CHECK_LIB("libvips.lib", "vips", PHP_VIPS) && CHECK_LIB("glib-2.0.lib", "vips", PHP_VIPS) && CHECK_LIB("gobject-2.0.lib", "vips", PHP_VIPS) ) {
		EXTENSION("vips", "vips.c", PHP_VIPS_SHARED, "/DZEND_ENABLE_STATIC_TSRMLS_CACHE=1");
		AC_DEFINE('HAVE_VIPS', 1, 'Have vips library');
	} else {
		WARNING("vips not enabled; libraries and headers not found");
	}
}

vips.c
PHP_MINIT_FUNCTION(vips)
{
if (strcmp(sapi_module.name, "apache2handler") == 0) {
........
........
........
........
........
#if defined(VIPS_SONAME) && !defined(PHP_WIN32) /*Unix*/
		if (!dlopen(VIPS_SONAME, RTLD_LAZY | RTLD_NODELETE))
#elif !defined(PHP_WIN32) /*Unix & !VIPS_SONAME*/
		if (!dlopen("libvips.so.42", RTLD_LAZY | RTLD_NODELETE))
#elif defined(VIPS_SONAME) && defined(PHP_WIN32) /*PHP_WIN32*/
		if (!LoadLibrary("VIPS_SONAME"))
#else /*PHP_WIN32 & !VIPS_SONAME*/
		if (!LoadLibrary("libvips-42.dll"))
#endif

At the moment I can not get the tests to pass since PHP craches before reaching the tests. I am working on an appveyor setup to automate the testing and test different PHP versions. Currently I am only doing 7.3.0 which might be the issue.

Hey, great progress! OK, I'll hold off on 1.0.10 and hope to get your PR in.


Backtesting

Hello, really interesting project (I'll try it soon).
Reading the documentation I haven't found anything regarding backtesting, I think it's a fundamental feature to test strategies with past data. I think it should be considered in the roadmap.
Is there the chance to make paper trading? For gdax, for example, we just need to use their sandbox?
Thanks

Closing. No progress made. Can be resurrected if needed :-)


MINOR: Optimise performance of Topic.validate()

I included a JMH benchmark and the results follow. The
implementation in this PR takes no more than 1/10th
of the time when compared to trunk. I also included
results for an alternative implementation that is a little
slower than the one in the PR.

When you reference "trunk", do you mean a ProducerRecord that has the regex-based validation? Also, did you ever do micro-benchmarking for ProducerRecord with no topic validation?

I think in https://github.com/apache/kafka/pull/3223 you mentioned verifying the impact of adding topic validation in ProducerRecord through ProducerPerformance. Is that still going to happen, or are you instead going to just look at the results you provided above from TopicBenchmark?
This PR looks fine, but if somehow ProducerPerformance shows the impact is negligible, then that could influence the benefit of checking in this PR.

@onurkaraman if you produce 1 million small messages per second (say 100 bytes per message), then you only have 1000 ns per message. So, 630 ns just to validate the topic name is clearly too much. I was suggesting doing the ProducerPerformance with this change included to figure out if the optimised version is quick enough for us to afford the check.
The next question is whether we should bother with this optimisation if we don't use it in ProducerRecord. I think it is because cheap validation makes it applicable in more places, but I'd be interested in other opinions.

retest this please

The change lgtm. Even if it is not yet used in critical code paths I think it is still beneficial to merge it.
Regarding whether we should add it in the critical path of ProducerRecord: since we have disabled auto topic creation by default so only admin clients can create them which is already covered by validation, I'm less concerned if a mis-named topic would be created.

I agree with @guozhangwang regarding whether topic validation should exist in ProducerRecord. It sort of seems putting a topic validation check in the ProducerRecord is excessive, especially given that we're moving away from auto topic creation.

LGTM

Merged to trunk.


godep save inconsistent between platforms

I have some code (closed source :crying_cat_face:) that has a dependency using the // +build construct to variably include some of their source files. This leads to dependencies in those files from being excluded if godep save is ran on a platform that does not require those files.
If I godep save on Mac, it'll build and run perfectly fine on Mac, but if I take that codebase and try and build it on Linux, the Godeps directory will be missing dependencies and will fail to compile. I'm currently resolving this by only doing godep save/godep update on Linux, but it is not a long-term solution as all of our developers are primarily working on Mac.

I've been playing with ways to address this. It's possible to pass -tags to the "go list" command, so you could pass the tags "darwin linux". That works ok as long as nothing uses the ! syntax. So if you had a !linux, it would not include it even though you'd want it. That's causing me trouble on Windows because some things in the standard library are defined as !windows rather than an explicit list of everything else.
The other option is to run LoadPackages once for each desired tag and then merge the results. That's probably the way it needs to work, but the code is more complicated.

Sorry that I didn't post this earlier: the workaround that we've been using is to just use GOOS=linux go get -d ./... for getting dependencies.

Hey folks, we just switched to Godep over in hashicorp/terraform and we're running into this problem.
We build Terraform for several platforms and we're running into problems trying to vendor the superset of dependencies without constantly fighting diffs or manually editing metadata.

The other option is to run LoadPackages once for each desired tag and then merge the results. That's probably the way it needs to work, but the code is more complicated.

We might investigate this as a PR if it sounds like a valid approach to everybody.

What version of godep are you using? At this point godep no longer uses go list to resolve any dependencies and processes files/deps for all files except those that include the appengine or ignore build tags.

Hi @freeformz - thanks for the tip! Looks like we were indeed running an older version of godep.
Did a fresh go get -u and this seems to be resolved w/ the newer version.
https://github.com/hashicorp/terraform/pull/4957 looks to have the proper superset dependency list
Since everything seems to be working I believe this (and the linked #174) can be closed. :+1:

Great! Thanks. Closing. For anyone else on this ticket please re-open / post a follow up if, after updating, things aren't working for you.

@freeformz, I've encountered a similar issue on v52 when recently vendoring. I need to double check to see if it is also caused by +build or something else, but I did not have all the proper dependencies.

@jzelinskie If so please file that as a separate issue unless someone else has already done so. ;-)


Menu item for deep directory sort is missing

The extension works in my installation of VS Code (V1.21.1 on Mac OS X) but the menu item for deep directory sort is missing in the context menu for directories.
See this screenshot:

Hmm. I have the minimum version of vscode set to 1.28.0. Maybe that is the reason.
"engines": {
     "vscode": "^1.28.0"
}

Would you be able to check if the import sorter plugin is active ?
If you do command search, do you see the following?

closing as no activity here


[Request] Secret helper advancement

I think, it would be nice for noobs, to see the secrets card text by hovering.

"duplicate" of #339


docs: use toggles to display better examples of encoding

In the docs, all the examples are one after the other, making the code snippets very long and big.

Sort them between toggles that can be opened, so that it is easier to find the relevant example for the developer.
Improve subheadings so that examples can be more easily found from the sidebar

super cool !


Add catmath unit tests

Coverage increased (+4.6%) to 41.379% when pulling c709abdc569be7b5990d98ca50ffaa4a32f85515 on ryatesdw:tutorial_wip into cad3d2ba400a71b24a6aee9b7ecf44938b97fa0a on keeppythonweird:master.

woot


code executing in webgui

Fixes #144

still a bit to go. I've added the config settings and some sample. Not really sure how to get the url, type of object etc to continue from here.
Any help @marcellourbani ?

@uxkjaer
Thanks a lot for the contribution
There are a few things who don't work for me though:

boolean parameters don't work, there should be a 3 option dropdown going like:

SAPGUI(default)
webgui in  browser
webgui in vscode

no need for a case statement. Transaction  SADT_START_WB_URI used by  showInGui does any object type
the code to handle the browser goes in function runInSapGui, in sapgui.ts around line 44
I will bump version  when I publish the next release

Should look more or less like this:

Thank you
Marcello

The SADT_START_WB_URI transaction only loads the program, it doesn't execute it. My intention was to execute the program directly so we don't have to "run" it in the webgui.
What do you think?

I think we need a new command to open&run to provide what you're after.
I also think the code above should stay more or less as it is, is the command  which should be different for running.
Sorry I got confused, the fact is we are talking about 2 different features:

use the webgui in place of sapgui
run instead of open

So please also add a new command for this. Changes are pretty trivial:

new command constant, say executeImmediately
@command entry in its main method
matching command in package.json

Would also consider calling this execute and renaming the old command from execute to openingui or similar, but might break stuff

i've implemented the code to execute and then changed the existing to openingui. I can't really figure out how to define the command in the command pallette. Do i need to add it to the package.json file. I just see other commands in there that aren't present either.
I do have one issue for executing on class. the file.object.name contains both the classname and method. I can't figure out where that is added. When I debug the AbapObjectBase it looks correct. Do you have an idea?

They're defined in package.json:

and in structure AbapFsCommands

Yup, that's sorted now. Last issue is that of the class name having the method on it as well.

You can get the object from the url. Plenty of examples around

Yeah it's just that all other objects works with the name. But I'll change it to the url.

@uxkjaer
I planned to go through this on the weekend but was too lazy :(
Merged, but plan to do a couple minor changes before releasing it, probably early this week
Marcello

Sounds great. Let me know if there is anything I can help with.

@uxkjaer I'm working on it, found a few issues and a few things I'd like to change even if not strictly issues (i.e. I restored the previous F5 binding for backwards compatibility).
I will probably push my WIP so you can have a look


Unable to add define browsers.json in docker-compose file

Can you please provide docker-compose sample file with defining custom browsers.json file ?
In latest release, we are getting issue in finding browsers.json file and exiting.

Let's modify documentation to reflect changes in latest release.

@gsureshbabu updated Docker Compose example in docs.


Fix circular import introduced by #322.

Fixes: #343

This is cannot reproduced with unit tests. The unit tests did not catch this issue. This adds a InterfaceConnectionsListView .get_queryset() method to emulate the built-in Django generic view API that is unfortunately not implemented in the Nautobot core that we inherited from NetBox. So this also adds an __init__ method to the view to call self.get_queryset() on init. Short of refactoring all of the base generic views, this is the cleanest fix I could think of for now.
I did attempt to convert InterfaceConnectionsListView.queryset to a property, and while that did alleviate the issue initially, it resulted in many tests failing because nautobot.utilities.views.ObjectPermissionRequiredMixin.has_permission wants to replace self.queryset with self.queryset.restrict(user, action) on line 77.

Do we just need to add an invoke migrate to scripts/cibuild.sh?

@glennmatthews I just tested and it appears that would have caught the issue. Would that be a simple enough addition like you said to scripts/cibuild.sh?

I believe @nniehoff has something already in the works that would catch this.

Do we just need to add an invoke migrate to scripts/cibuild.sh?

showmigrations would be better because it still tries to build the dependencies to inspect the schema, without actually trying to apply them.

Fix looks good, but it's very concerning that #343 wasn't caught by or reproducible by the CI tests. From the issue description it sounds like it should be caught quite easily. Do you have any analysis why the tests aren't encountering it?

I am still looking into it, but my educated guess is that the test runner uses the same mechanism to apply the migrations to the test database that the migration operations code uses: Constructing the models in memory vs. reading them directly from the source.


feat(api): add ivr.proto

Signed-off-by: seeflood<EMAIL_ADDRESS>
What this PR does:
add ivr.proto
Which issue(s) this PR fixes:

Fixes #726
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

ivr is confusing  :-)

ivr is confusing :-)

Well, I can change it to PhoneCall

ivr is confusing :-)

@ZLBer fixed. Please review again


updated the read me to include setting up admin

I updated the read me to include some guides on setting up the app for the surveys

hey @codiebeulaine I updated the read me to include some information that I found useful for setting up

@sewagodimo when working with RST, using the $ symbol is used to indicate commands to run or code. It's better to structure your instructions as normally formatted text.

@nathanbegbie I added the changes you requested. Thank you.

Thanks for adding this @sewagodimo 🍰
Just a few comments but looks good

👍 🍰

@nathanbegbie  and @codiebeulaine I made the changes. Thank you guys for the reviews


用单跳键编码方式来代替Graphormer中的多跳边编码方式

在论文中提到了这样一个创新点：用单跳键编码方式来代替Graphormer中的多跳边编码方式，具体体现在代码的哪个部分呢，原谅我学术不精不太了解这个地方。

Our method is purely based on 3D structure and does not incorporate molecular graph information. May I ask which part of the paper did you see this statement.


Running artisan up without w permission doesn't display an error message

Laravel Version: 5.8
PHP Version: PHP 7.2.19-0ubuntu<IP_ADDRESS>
Database Driver & Version: NA

Description:
Running ./artisan down with incorrect permissions fails with an error message. However running ./artisan up does not, but instead indicates it did exit maintenance mode but it does not remove the app from maintenance mode.
Steps To Reproduce:
cd into your app directory (in which your current user doesn't have w permission)
./artisan down
Verify you get an error message on the console
Verify your site is not in maintenance mode
sudo ./artisan down
Verify your site is in maintenance mode
./artisan up
Verify you didn't get any error message on the console, but instead a success message ("Application is now live.")
Verify your site is still in maintenance mode

Which 5.8 release are you on? This PR #28765 landed in 5.8.22

Sorry about that. It's 5.8.19


Using jsc.paths strips import extensions

Describe the bug
When using TypeScript paths in .swcrc, the extensions of imports (kept for an ESM output) are stripped, but only if there is at least one item in the jsc.paths object (not if it's empty).
Reproduction repository:
https://github.com/franky47/swc-paths-extensions
Note: the Playground does not show this behaviour: imports always keep their extensions there.
Input code
No response
Config
{
  "jsc": {
    "baseUrl": "./src",
    "paths": {
      "@modules/*": ["./modules/*"]
    },
    "target": "es2020",
    "parser": {
      "syntax": "typescript"
    }
  },
  "module": {
    "type": "es6"
  }
}

Playground link
https://play.swc.rs/?version=1.2.140&code=H4sIAAAAAAAAA0WMPQvCMBiE9%2FyK25pCSdDRSRBHpw7d1bcaTfKGfKAg%2FndTAzrccHfPndaYCHeigHwlqFsCPTP5ZNhj5oj9eOBzsZQGHEvGOO3wMNYi5WgCTN4I4wLHjBfcAjLemCM7dFvXhrrl9br7s6m4H6h0dd9anNgntqQsX2SbydrJ1YB1v6gXH2e1V1CxAAAA&config=H4sIAAAAAAAAA0XMMQ7CMAyF4bu8EVW06sCQiUswIYYQXAgKJbJdiajK3YnLwGj%2F%2FrziKQFuxdULnTjBYd8LB3TIXh9i6fh635ZE0u%2Fgzi3%2Fx0vtoJ7vpM2RjMM4bJCF2KSUWf2nNS2ZJHDMitrM74NdWNjsAbaPc5wK3OSTUP0C5p3eqJwAAAA%3D
Expected behavior
Extensions should not be stripped when using the jsc.paths configuration, so that an ESModule output has a chance to run in Node.js.
Actual behavior
Import paths have their .js extension stripped, resulting in import resolution failure in Node.js.
Version
1.2.140
Additional context
No response

Yeah, you are correct and I think it should be fixed by checking if the original module specifier has an extension.

Any workaround/eta for this?

There is always a bug with the file extension, the compiled file import .ts files instead of .js, for example:
"use strict";
var _moduloJs = require("./modules/modulo.ts");
var _sumJs = require("./sum.ts");
console.log((0, _moduloJs).modulo((0, _sumJs).sum(1, 2), 2));

I fork the @franky47 repo as an example here (using commonjs module type) .
Thank you for your support.

You're not supposed to use .ts as file extensions though, as recommended by the TypeScript compiler (error 2691).
I know it's super confusing when writing TypeScript, that the imported file has a .ts extension, but the final running code will be JavaScript, and import a JavaScript file, which will have a .js extension.

Yes, of course, in the src/main.ts file this is actually an import of a .js file, but in the complied code it transforms the extension to .ts.

Sorry I misunderstood your comment, that is an issue indeed.

@sgarnotel Filed #4585


fix(css): vite can't handle images in css correctly

Description

The scene where the problem occurs during the following demo:
click me

Run npm run build, vite prompts that the package is successful but the images in the css are not processed
After deleting the postcss plugin of the demo, run npm run build again, the packaging is normal

Additional context
The reason for the problem is

Currently vite-url-plugin is executed after the user-defined component

// https://github.com/wkstudy/vite/blob/4194cce60f7d9a5664ef9aea279f1f69631cdc84/packages/vite/src/node/plugins/css.ts#L695

postcssPlugins.push(
    UrlRewritePostcssPlugin({
      replacer: urlReplacer
    }) as Postcss.Plugin
  )

vite-url-plugin relies on the input.file property to change the resource path

// https://github.com/wkstudy/vite/blob/4194cce60f7d9a5664ef9aea279f1f69631cdc84/packages/vite/src/node/plugins/css.ts#L865
 const importer = declaration.source?.input.file

input.file must have opts to generate, otherwise it will disappear

// https://github.com/postcss/postcss/blob/d533f80b3cb4ef394cc7b523f675828ef7ec8466/lib/parse.js#L8
...
function parse(css, opts) {
  const input = new Input(css, opts)
}

...
// https://github.com/postcss/postcss/blob/d533f80b3cb4ef394cc7b523f675828ef7ec8466/lib/input.js#L36
...
if (opts.from) {
  if (!pathAvailable || /^\w+:\/\//.test(opts.from) || isAbsolute(opts.from)) {
    this.file = opts.from
  } else {
    this.file = resolve(opts.from)
  }
}
...

The postcss-px2rem-excludeplugin is called in my demo, and the postcss.parse method is called here, but the opts object is not passed, causing the subsequent css astobj to lose the input.file attribute

// https://github.com/saionjisekai/px2rem-postcss/blob/1edc6763ad2fe8288ac6a8bda482319f006d8bb6/lib/index.js#L15
    result.root = postcss.parse(newCssText)

The final input.file value is undefined, the vite package is successful but the url in the css is not processed
My understanding is that there is no problem with vite and postcss plugins, but it is best to call the plugin inside vite first, and then call the user-defined plugin

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Patak

Just chiming in that the issue seems clear and the fix seems reasonable. Patak mentioned this issue to me, which is why I’m leaving this review.

Thanks, keep learning from you guys

Shouldn't this be fixed in postcss-px2rem? You've linked https://github.com/saionjisekai/px2rem-postcss/blob/1edc6763ad2fe8288ac6a8bda482319f006d8bb6/lib/index.js#L15 in no4, where the opts isn't passed. But checking the types for .parse
export interface ProcessOptions {
  /**
   * The path of the CSS source file. You should always set `from`,
   * because it is used in source map generation and syntax error messages.
   */
  from?: string

  /**
   * Source map options
   */
  map?: SourceMapOptions | boolean
}

from is encouraged to be set but it's not. I think making this change is breaking too which could affect plugins that alters the url, so I think this should be fixed in userland (if possible).

Thanks for doing a review @jonathantneal, @bluwy's comment is in line with what I'm also worried about in this PR. I imagine a plugin injecting a URL or modifying it isn't uncommon, no?

Shouldn't this be fixed in postcss-px2rem? You've linked https://github.com/saionjisekai/px2rem-postcss/blob/1edc6763ad2fe8288ac6a8bda482319f006d8bb6/lib/index.js#L15 in no4, where the opts isn't passed. But checking the types for .parse
export interface ProcessOptions {
  /**
   * The path of the CSS source file. You should always set `from`,
   * because it is used in source map generation and syntax error messages.
   */
  from?: string

  /**
   * Source map options
   */
  map?: SourceMapOptions | boolean
}

from is encouraged to be set but it's not. I think making this change is breaking too which could affect plugins that alters the url, so I think this should be fixed in userland (if possible).

it works, thanks a lot. And I have some other ideas

In the existing postcss ecosystem, there may be some plugins that will destroy the ast structure of css just like postcss-px2rem, causing the vite-url-plugin plugin that strongly depends on the input.file property to fail. This may be rare. But if something goes wrong, I think it's more difficult to find the reason.
As for whether the execution order of vite-url-plugin is changed, will it affect other url plugins? I think there is a certain chance, but even if there is a problem here, it is easier for me to accept it. Because this is a plug-in sequence problem, it is relatively common and the developer knows how to solve it, but the above problem is too hidden, and it gives the developer the feeling that "there is a problem with vite, and my image cannot be loaded", although this is not the case .

All in all, I think that as long as vite can provide developers with a normal postcss structure, users can accept and find a solution even if there is a sequence problem, but if the user's input affects the normal operation of vite, it may not be reasonable.
In the end, this is actually a relatively small issue, thank you for your attention

@wkstudy Does https://github.com/vitejs/vite/pull/8183 help in this case? It should report a warning when there's a postcss plugin that doesn't pass the field.

@wkstudy Does #8183 help in this case? It should report a warning when there's a postcss plugin that doesn't pass the field.

Reasonable

@wkstudy let's close this PR in favor of #8183. Please get back to us in case postcss-px2rem-exclude decides they want to accept the PR to fix the issue upstream and they give a good reason. @jonathantneal thanks again for checking the issue, if you have more info about the number of PostCSS plugins that may start to provoke the warning in #8183 please let us know. Maybe it is more common than what we're assuming. This solution isn't set in stone, let's see how users react to the warning and we can re-evaluate before releasing v3 stable


Table.drop() does not work with KueryMySQL

Hello,
I'm trying to drop an MySQL-table with the example structure and Kuery MySQL 0.13:
class Grades: Table {     let tableName = "Grades"     let id = Column("id", Int16.self, length: 6, primaryKey: true)     let course = Column("course", Varchar.self, length: 50)     let grade = Column("grade", Int16.self, check: "grade >= 0") }
When I'm tryping to drop the table now, I'm getting an wrong query
let grades = Grades(); Log.verbose( "Dropping old table with \(grades.drop().query)" );
grades.drop().query should return DROP TABLE Grades but returns DROP TABLE.
I have a workaround with
let dropGradesTableSQL: String = "DROP TABLE \(grades.tableName)";

Log.verbose( "Dropping old table with \(dropGradesTableSQL)" );

// Trying to drop the old table
connection.execute( dropGradesTableSQL )
{

    result in

    guard result.success else
    {

        Log.error( "Failed to drop table: \(result.asError!) with \(dropGradesTableSQL)" );

        return;

    }

}

grades.drop() returns a Raw query that has two fields query and tables. query in this case is DROP TABLE,  and tables is [grades].
To execute the drop query you can use grades.drop().execute(connection).

Thanks for the reply. It makes sense and work with grades.drop().execute(connection).


In some cases, detection works strange

For example, core-js. In some cases, it's not detected

or reported an incorrect version

The version of extension - the latest published (6.9.14), some of such problems I saw before, but on these sites it was detected properly.

Fixed in fb7eee340c57934ab33f2a348a65ea75594f7cce, thanks!

@AliasIO hey, in the actual version (6.10.15), the second case still is not fixed.


Prevent mixing different types of definitions

You won't get Intellisense for .Stage() in a variable block

Covered in #18


Colorful guide lines

Hi,
I found your plugin yesterday and really like it, but what I was really looking for is a feature I've found in a Visual Studio plugin and that's having a different color for each indent level.
I've come up with some less code that will do almost that and I figured I'd share it with you, maybe you can tweak it so it uses a base color and works well with all kinds of themes, I only tried it with Seti and I'm happy with it.
Here's an example:

Thanks for the first pull request!
Colorizing guides is a good idea.  However, they appear to be less distinguishable for me.
You can change the style yourself with your own stylesheet.  If it is impossible, please tell me or pull request again.


added FAQ for oracle DB

I had to add   characters for proper spacing/formatting on the markdown. If anyone knows a better way let me know.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6760be348996fdc11b39eb26--harness-developer.netlify.app


Environments window extensibility

Adds extensibility point to allow other VS extensions to provide panes in the environments list.
This may be used to provide conda or other package-related extensions independently of PTVS, simply by exposing a MEF component for IEnvironmentViewExtensionProvider.

:+1:


How to move picture uploader to center position?

Hi Everyone,
With the picture uploader,  how can I change the component to center? Like described below.

I did it through adding another div outside existing one,  in baPictureUploader.html

 <====== added new

    ....

in the corresponding barPictureUploader.scss

.picture-frame {
    width: 100%;
    text-align: center;
}

with the above alone, it does not work, I don't understand why.  but adding the following trick did it
.picture-group {
  border: 1px dashed #b8b8b8;
  width: 202px;
  height: 202px;
  position: relative;
  cursor: pointer;
  margin:auto;  <========== added new

That might not be an elegant solution, welcome any better answers.


Bypass proxy for local URLs

I'd like a feature where you can add exemptions for the proxy settings.
Example from macOS proxy settings:

My suggestion would be adding a select option directly under the proxy settings in abapGit, so that wildcards and multiple entries are supported in native SAP style:

I've already implemented the user exit and it's working well, but I think this makes sense as a standard feature.
CLASS zcl_abapgit_user_exit DEFINITION PUBLIC FINAL CREATE PUBLIC.
  PUBLIC SECTION.
    INTERFACES:
      zif_abapgit_exit.
  PROTECTED SECTION.
  PRIVATE SECTION.
    DATA:
      mr_proxy_bypass_hosts TYPE RANGE OF string.
    METHODS:
      is_proxy_necessary IMPORTING iv_repo_url TYPE string
                         RETURNING VALUE(rv)   TYPE abap_bool.
ENDCLASS.

CLASS zcl_abapgit_user_exit IMPLEMENTATION.

  METHOD is_proxy_necessary.
* ---------------------------------------------------------------------
    IF mr_proxy_bypass_hosts IS INITIAL.
      SELECT sign, opti AS option, low, high
      FROM tvarvc
      WHERE name = 'ZABAPGIT_BYPASS_PROXY'
      AND   type = 'S'
      INTO CORRESPONDING FIELDS OF TABLE @mr_proxy_bypass_hosts.
    ENDIF.
    IF iv_repo_url NOT IN mr_proxy_bypass_hosts.
      rv = abap_true.
    ENDIF.

* ---------------------------------------------------------------------
  ENDMETHOD.

  METHOD zif_abapgit_exit~change_proxy_port.
* ---------------------------------------------------------------------
    IF NOT is_proxy_necessary( iv_repo_url ).
      CLEAR cv_proxy_port.
    ENDIF.

* ---------------------------------------------------------------------
  ENDMETHOD.

  METHOD zif_abapgit_exit~change_proxy_url.
* ---------------------------------------------------------------------
    IF NOT is_proxy_necessary( iv_repo_url ).
      CLEAR cv_proxy_url.
    ENDIF.

* ---------------------------------------------------------------------
  ENDMETHOD.

ENDCLASS.

Is the table tvarvc available everywhere?

It is:

But it should be included in the abapGit settings xml in db table ZABAPGIT.

there is a lot of framework in abapGit to store the values, suggest using that

there is a lot of framework in abapGit to store the values, suggest using that

I agree

I've forked the abapGit repo and created a Branch and made some changes. It works on my local system, but the sapevent in the settings page of my added button does not work on my companies citrix machine.
Any idea why it isn't working? My PC is running Win10 with IE11 and the citrix terminal server is on Win Server 2008 with IE11.
This is how I've added the button:
ro_html->add( || ).
ro_html->add( |<button name="proxy_bypass" type="button" class="grey-set">Maintain</button>| ).
ro_html->add( || ).


Update to 1.19.3 and 1.19.4

The aquatic torch item is now found in the functional block tags right after the redstone torch. This version works for both Minecraft 1.19.3 and Minecraft 1.19.4.

Thank you!


Add nightly Notification to PR Test GitHub Action

Description

Will send out nightly test result to Webhook link set in secret.

How was this PR tested?

https://github.com/Yuqing-cat/feathr/actions/runs/3329525770

Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to clarify your proposed changes.

Thanks for this PR, I couldn't gather from the PR where we are sending the test results too, our email addresses?

Thanks for this PR, I couldn't gather from the PR where we are sending the test results too, our email addresses?

Will be sent to secrets.TEAMS_WEBHOOK, which @blrchen  will help to set as the webhook of Teams Channel "Feathr Contributor => Daily Test Notification".


El Capitan

Ever thought of revisiting this code?  I'd love to be able to swap out the Apple logo in the menu bar for my own icon, but it looks like the bin file has changed and this tool no longer works.

You can do that using ThemeEngine with Assets.car.


Changed ONNX importer to convert Convolution operation to V1 ops

With these changes, i was able to verify that Convolution biases are getting fused into Convolution

@arogowie-intel we do not use nGraph transformations just because they are based on opset0 ops except ConstantFolding pass that we asked to update with opset1 support.


AttributeError: module 'tensorboard' has no attribute 'lazy'

I've been trying to import tensorflow, downloading Anaconda 3, creating virtual environment, use pip install tensorflow, pip install keras and when I try to import tensorflow an error occured  "Failed to load the native TensorFlow runtime." then I tried to resolve it by downloading cygwin to update the gcc. After that, another error occured
2020-01-21 16:18:17.197417: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cudart64_101.dll'; dlerror: cudart64_101.dll not found
2020-01-21 16:18:17.197832: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.

Tried to solve it by downloading CUDA 10.1 version and now the problem is
2020-03-09 14:17:07.528838: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library cudart64_101.dll

This is a problem because after that all process finished with exit code 1 and print('test') cannot even be processed after this.
System information:
Anaconda 3
Windows 10
Tensorflow 2.1
Inteil Core I5
Gtx 1050 ti
CUDA version 10.1
python version 3.6.1
Describe the problem
Describe the problem clearly here. Be sure to convey here why it's a bug in TensorFlow or a feature request.
The errors when I try to import tensorflow:
2020-03-09 14:17:07.528838: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library cudart64_101.dll
Traceback (most recent call last):
  File "C:/Users/User/PycharmProjects/tensortest/test.py", line 1, in <module>
    import tensorflow
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow\__init__.py", line 101, in <module>
    from tensorflow_core import *
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\__init__.py", line 46, in <module>
    from . _api.v2 import compat
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\__init__.py", line 39, in <module>
    from . import v1
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v1\__init__.py", line 32, in <module>
    from . import compat
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v1\compat\__init__.py", line 39, in <module>
    from . import v1
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v1\compat\v1\__init__.py", line 29, in <module>
    from tensorflow._api.v2.compat.v1 import app
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\__init__.py", line 39, in <module>
    from . import v1
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v1\__init__.py", line 32, in <module>
    from . import compat
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v1\compat\__init__.py", line 40, in <module>
    from . import v2
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v1\compat\v2\__init__.py", line 30, in <module>
    from tensorflow._api.v2.compat.v2 import audio
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v2\__init__.py", line 33, in <module>
    from . import compat
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v2\compat\__init__.py", line 40, in <module>
    from . import v2
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorflow_core\_api\v2\compat\v2\compat\v2\__init__.py", line 320, in <module>
    from tensorboard.summary._tf import summary
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorboard\summary\__init__.py", line 31, in <module>
    from tensorboard.summary import v2
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorboard\summary\v2.py", line 24, in <module>
    from tensorboard.plugins.audio.summary_v2 import audio
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorboard\plugins\audio\summary_v2.py", line 30, in <module>
    from tensorboard.compat import tf2 as tf
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorboard\compat\__init__.py", line 28, in <module>
    import tensorboard.lazy as _lazy
AttributeError: module 'tensorboard' has no attribute 'lazy'

Process finished with exit code 1

@PreVizsla, Did you install cuDNN? If not install cuDNN >=7.6 version.
Please take a look at the Tensorflow doc. Thanks

yes, followed this https://www.easy-tensorflow.com/tf-tutorials/install/cuda-cudnn
and downloaded the 7.6 cuDNN and still same error

Will installing an older version of tensorflow helps the problem? Since I have no idea what kind of problem makes this error

i have like this problem and i checked cudnn version but i have still this problem how i can fix ?

I also have this problem

Hi, did anyone find a solution to this? I am having the same trouble.

trying to run :
from keras.preprocessing.image import load_img, img_to_array
and getting the same error

same thing here, any one has any solutions?

I am facing the same thing, can anyone please help!

Yep facing same issues, installed it and worked before in the past but with this fresh install I'm running into the same problems others are having.

There is more than just errors printed to stderr. The log format is
date time: FEWID message

where FEWID is one of F (fatal error, program stops), E (error, program continues but with different behavior), W (warning), I (info), D (debug). The last 3 steps are useful for understanding behavior but are NOT errors
Thus:
2020-01-21 16:18:17.197417: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cudart64_101.dll'; dlerror: cudart64_101.dll not found
2020-01-21 16:18:17.197832: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.

Doesn't mean that you need to install CUDA to use TF. You can use TF without having CUDA, it will just use CPU.
Also,
2020-03-09 14:17:07.528838: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library cudart64_101.dll

only means that the CUDA library was loaded. It is not an error.
The real error is
...
  File "C:\Users\User\Anaconda3\envs\tensortest\lib\site-packages\tensorboard\compat\__init__.py", line 28, in <module>
    import tensorboard.lazy as _lazy
AttributeError: module 'tensorboard' has no attribute 'lazy'

Process finished with exit code 1

which makes me think you have an mismatched version of tensorboard and tensorflow. What does pip list print?

Update your 'NVIDIA Graphics Driver' with latest and compatible version for your PC.
Download Driver: https://www.nvidia.com/Download/index.aspx#
To find out required driver: https://youtu.be/a6ZdiNBPCC8

please give the solution., I am also facing same issue
please.....

import tensorflow
2020-05-20 17:55:45.825216: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library cudart64_101.dll
Traceback (most recent call last):
File "", line 1, in
File "C:\Users\dipta\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow_init_.py", line 41, in
from tensorflow.python.tools import module_util as module_util
File "C:\Users\dipta\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python_init.py", line 84, in
from tensorflow.python import keras
File "C:\Users\dipta\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\keras_init_.py", line 27, in
from tensorflow.python.keras import models
File "C:\Users\dipta\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\keras\models.py", line 23, in
from tensorflow.python.keras import backend as K
File "C:\Users\dipta\AppData\Local\Programs\Python\Python37\lib\site-packages\tensorflow\python\keras\backend.py", line 5948, in
assert _image_data_format in {'channels_last', 'channels_first'}
AssertionError

@nfelt could you take a look?
We suspect this is due to a mismatched TF/tensorboard version, but could not confirm.

Had the same problem with anaconda with a fresh installation of Tensorflow 2.1.
Somehow fixed it by uninstalling tensorboard with pip and re-installing it:
pip uninstall tensorflow-tensorboard and then pip install tensorboard

I'm getting the same error:
2020-06-10 20:15:45.369670: W tensorflow/stream_executor/platform/default/dso_loader.cc:

actually I can now use the older version of tensor flow with no problem, I am using tensorflow 1.7 right now. But I haven't try to use the 2.0 version again.

@johnLIC You should use the same versions for TF, estimator and tensorboard
@brandonssmith that's a warning, not an error
@PreVizsla yes, you can use any released TF but if you encounter a bug in a version we no longer support we won't be able to help you. And we won't issue security updates and patches to old versions.

@mihaimaruseac how to check tensorboard verison? And do we need the exact same version for both TF and tensorboard?

Surprisingly, After creating new conda virtual environment and downloading tensorflow and keras, I am able to run tensorflow 2.1 in pycharm with 20 Info notice in the console, but the script and tf works fine.

holy crap I forgot how pedantic programmers can be

@mihaimaruseac If it keeps me from progressing it's an error, I could care less how it is classified.

@brandonssmith What @mihaimaruseac meant was that message will not block your progress. There must be another issue that is blocking your progress. If you need help, please file a new issue providing all the details in the template.
Also, please make sure to abide by our community guidelines in your comments (referring to your deleted comment).

@PreVizsla sorry, was away. pip list should display the version of all installed pip packages.
Installing in a new environment ensures that all dependencies are installed at a corresponding version

I have a similar issue in google colab:

tensorflow version 2.2.0
tensorboard version 2.2.2

%tensorboard --logdir drive/...

gives AttributeError: module 'tensorboard' has no attribute 'lazy'

@irinawetransfer can you please post output of pip list and pip debug --verbose? Also, if possible, a minimal code that reproduces the issue?

I have the same problem.
the output of pip list:

Package                  Version

absl-py                  0.9.0
astunparse               1.6.3
cachetools               4.1.0
certifi                  2020.6.20
chardet                  3.0.4
gast                     0.3.3
google-auth              1.18.0
google-auth-oauthlib     0.4.1
google-pasta             0.2.0
grpcio                   1.30.0
h5py                     2.10.0
idna                     2.9
Keras-Preprocessing      1.1.2
Markdown                 3.2.2
numpy                    1.19.0
oauthlib                 3.1.0
opt-einsum               3.2.1
pip                      19.2.3
protobuf                 3.12.2
pyasn1                   0.4.8
pyasn1-modules           0.2.8
requests                 2.24.0
requests-oauthlib        1.3.0
rsa                      4.6
scipy                    1.4.1
setuptools               41.2.0
six                      1.15.0
tensorboard              2.2.2
tensorboard-plugin-wit   1.6.0.post3
tensorflow-gpu           2.2.0
tensorflow-gpu-estimator 2.2.0
termcolor                1.1.0
urllib3                  1.25.9
Werkzeug                 1.0.1
wheel                    0.34.2
wrapt                    1.12.1

the output of pip debug --verbose:

pip version: pip 19.2.3 from c:\users\ghassen\downloads\lisadetection\lisadetection\venv2\lib\site-packages\pip (python 3.8)
sys.version: 3.8.3 (tags/v3.8.3:6f8c832, May 13 2020, 22:37:02) [MSC v.1924 64 bit (AMD64)]
sys.executable: c:\users\ghassen\downloads\lisadetection\lisadetection\venv2\scripts\python.exe
sys.getdefaultencoding: utf-8
sys.getfilesystemencoding: utf-8
locale.getpreferredencoding: cp1252
sys.platform: win32
sys.implementation:
name: cpython
Config variable 'Py_DEBUG' is unset, Python ABI tag may be incorrect
Compatible tags: 15
cp38-cp38-win_amd64
cp38-none-win_amd64
py3-none-win_amd64
cp38-none-any
cp3-none-any
py38-none-any
py3-none-any
py37-none-any
py36-none-any
py35-none-any
py34-none-any
py33-none-any
py32-none-any
py31-none-any
py30-none-any

the code that  produce that:
import tensorflow as tf
this is the output:

2020-06-24 14:50:11.230153: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cudart64_101.dll'; dlerror: cudart64_101.dll not found
2020-06-24 14:50:11.236957: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.

and for this code:
tf.test.is_gpu_available()
this is the output:

WARNING:tensorflow:From :1: is_gpu_available (from tensorflow.python.framework.test_util) is deprecated and will be removed in a future version.
Instructions for updating:
Use tf.config.list_physical_devices('GPU') instead.
2020-06-24 14:51:00.146205: I tensorflow/core/platform/cpu_feature_guard.cc:143] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2
2020-06-24 14:51:00.171655: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x21868deee70 initialized for platform Host (this does not guarantee that XLA will be used). Devices:
2020-06-24 14:51:00.182635: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): Host, Default Version
2020-06-24 14:51:00.190956: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library nvcuda.dll
2020-06-24 14:51:01.031439: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1561] Found device 0 with properties:
pciBusID: 0000:01:00.0 name: GeForce GTX 960M computeCapability: 5.0
coreClock: 1.176GHz coreCount: 5 deviceMemorySize: 4.00GiB deviceMemoryBandwidth: 74.65GiB/s
2020-06-24 14:51:01.045344: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cudart64_101.dll'; dlerror: cudart64_101.dll not found
2020-06-24 14:51:01.051842: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cublas64_10.dll'; dlerror: cublas64_10.dll not found
2020-06-24 14:51:01.058515: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cufft64_10.dll'; dlerror: cufft64_10.dll not found
2020-06-24 14:51:01.065241: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'curand64_10.dll'; dlerror: curand64_10.dll not found
2020-06-24 14:51:01.072266: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cusolver64_10.dll'; dlerror: cusolver64_10.dll not found
2020-06-24 14:51:01.080353: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cusparse64_10.dll'; dlerror: cusparse64_10.dll not found
2020-06-24 14:51:01.087954: W tensorflow/stream_executor/platform/default/dso_loader.cc:55] Could not load dynamic library 'cudnn64_7.dll'; dlerror: cudnn64_7.dll not found
2020-06-24 14:51:01.095638: W tensorflow/core/common_runtime/gpu/gpu_device.cc:1598] Cannot dlopen some GPU libraries. Please make sure the missing libraries mentioned above are installed properly if you would like to use GPU. Follow the guide at https://www.tensorflow.org/install/gpu for how to download and setup the required libraries for your platform.
Skipping registering GPU devices...
2020-06-24 14:51:01.186835: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1102] Device interconnect StreamExecutor with strength 1 edge matrix:
2020-06-24 14:51:01.194906: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1108]      0
2020-06-24 14:51:01.198498: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1121] 0:   N
2020-06-24 14:51:01.206694: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x21876e35be0 initialized for platform CUDA (this does not guarantee that XLA will be used). Devices:
2020-06-24 14:51:01.214517: I tensorflow/compiler/xla/service/service.cc:176]   StreamExecutor device (0): GeForce GTX 960M, Compute Capability 5.0
False

@GhassenBenMakhlouf I don't see the AttributeError: module 'tensorboard' has no attribute 'lazy' error in your post. All I see are warning and information logs, not errors. The other log messages can be safely ignored, they are there to provide you with context about what is happening and to help debugging.

@mihaimaruseac the problem is that I can not use GPU because this error: Could not load dynamic library 'cudart64_101.dll'
I know it is an information log or warning because the program can still use the CPU.
But I want to use GPU, please help me solve this issue. please refer me to another issue if you have the solution somewhere.

That is not the same problem and it should actually be opened as a new issue. Let's keep this issue to the AttributeError: module 'tensorboard' has no attribute 'lazy' error

That is not the same problem and it should actually be opened as a new issue. Let's keep this issue to the AttributeError: module 'tensorboard' has no attribute 'lazy' error
here you are:
https://github.com/tensorflow/tensorflow/issues/40804

For more context please refer comment


Use custom descriptor to coerce fields to Enum type on assignment.

https://github.com/bckohan/django-enum/commit/5388ff9b12ca3cc94c8ad9540bde9f5d4a940bb5


DeprecationWarning for some dependencies

the next command line npx mongodb-rest returns:
body-parser deprecated bodyParser: use individual json/urlencoded middlewares node_modules/mongodb-rest/server.js:102:35
body-parser deprecated undefined extended: provide extended option node_modules/body-parser/index.js:105:29
js-bson: Failed to load c++ bson extension, using pure JS version
(node:10239) [DEP0025] DeprecationWarning: sys is deprecated. Use util instead.

I've got the same issue.

I started mongo-rest and got this. any one had sucess  working around this


advantage of LUNA?

hello authors,
I chanced across LUNA and thought it could be quite useful. the code seems quite well written too. however, I am aware of several other repos that can be used for analysing interactions within protein-ligand complexes, e.g. ProLIF or PLIP. So, I'm not sure what's the advantage of using LUNA over those alternatives, since all can be used to filter residue-ligand interactions or visualise them. Or perhaps is there a pre-print or paper that outlines LUNA's unique features?
Thanks,
Min Htoo

thanks for the kind thoughts @linminhtoo

Or perhaps is there a pre-print or paper that outlines LUNA's unique features?

a timely question! the paper just came out last week:

JCIM - Prioritizing Virtual Screening with Interpretable Interaction Fingerprints
biorxiv preprint

I'll leave it to @alexandrefassio for anything further he'd like to add

Hi, @linminhtoo!!!
Thanks for your interest in using LUNA and for your kind words.
So let me try to answer your question on top of what @mjke already brought up.
LUNA is fully object-oriented. That means its modularity allows one to provide their own functions to calculate molecular interactions, ease customization of interaction and pharmacophoric properties, and disable specific unwanted parameters, which modify LUNA's behavior on the fly. That helps users to control every processing step during the analysis of a drug discovery campaign in a custom way and share configuration files with colleagues for reproducibility.
It's also important to mention that LUNA's core was built based on a thorough literature research, evaluation, and implementation of molecular interactions that make physicochemical sense. We represent interactions as graphs and calculate them on basis of atoms, groups of atoms, and functional groups. Currently, LUNA identifies 24 main groups of interactions, totalizing 44 different interaction labels, which properly account for geometric and atom groups combination.
LUNA also encodes molecular interfaces into three new hashed interaction fingerprints: EIFP, FIFP, and HIFP. Our fingerprints are RDKit-compatible. They encode the whole binding site interactions and contacts as binary or count fingerprints, implying that any protein residues, water molecules, or other compounds are considered during the featurization process. Moreover, one of the most promising features of our IFPs is their interpretability. Unlike other "black-box" hashed fingerprints in which one has to design the methods to interpret what each bit represents, LUNA already provides several functionalities to make the analysis straightforward.
Besides, LUNA has other several remarkable features: a) accepting any molecular complex type, including protein-ligand and protein-protein; b) accepting multiple file formats, including PDB, PDBx/mmCIF, PDBML/XML, MMTF, MOL, and MOL2; c) providing several pre- and post-processing filters to control how interactions are calculated or to select interactions matching specific geometric constraints or binding modes; d) providing several functions to summarize, characterize, and visualize molecular interactions and physicochemical properties; and e) allowing users to export their calculated interactions into a Pymol session.
Hope this answers your question :)
If you have any other doubts or want to further discuss some specific topic, just let me know.
bests


Integrate a logging service with Cocoon's flutter app

Currently issues with Cocoon's frontend have to be manually reported, and there is no way of monitoring deployment issues on the frontend side. We should integrate a logging service that can be used to let us know if there are issues with new deployments automatically.
There are print statements throughout the codebase that could be swapped to use something similar to firebase's logging that integrate with the existing GCP infrastructure.

Just to copy over from the PR review comments:
print statements were done due to
(1) the short time frame of the original release of the Flutter build dashboard (4 months)
(2) monitoring not being a high priority of the initial implementation

Marking obsolete. The frontend has a robust test suite which has helped reduce the need for monitoring.

Reopening. We've recently installed the app on Android TVs and are noticing it occasionally crash after a few days. Adding crashlytics will help us figure out where the bug is.


fix kmesh.ko location

What type of PR is this?

What this PR does / why we need it:
In the startup script in the kmesh image, the location of the copied kmesh.ko is incorrect and cannot be loaded later. Fix and adjust the location of kmesh.ko.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm
/approve


fix typo in "migration" page in docs

Fixes a small typo in the "migration" page in the docs, from "Buttton" to "Button"

#33855


Filter avro schema for tokenizeColumns using glob expressions

Functions to search an avro schema for a subset of fields matching a set of glob expressions
Example usage:
import avro.schema
from pseudorules import find_filtered_fields

avro_schema = avro.schema.parse(open("some-avro-schema.avsc", "rb").read())
tokenize_columns = find_filtered_fields(avro_schema, ["**/opprettetDato", "**/hendelse/**])
print(tokenize_columns)

Looks good. But this is actually a generic glob expression matcher for avro-schemas, right? So maybe the file should be called glob_matcher or something (instead of pseudorules).
Also, private/local functions should be prefixed by undescore

Added tests and fixed prefixes