Pilot process takes > 10 minutes to exit unless there is a corresponding Pilot resource

I noticed this in #157 and then again when I tried to write integration tests for Pilots.
I think the problem is that on receiving SIGTERM, the process polls for 10 minutes, waiting for the shutdown hooks to run.  But they never run because there isn't a Pilot resource to trigger the sync and reconcileHooks methods.
/kind bug

/assign

Some random thoughts copied from Slack conversations:

There's something funky about how the generic pilot shuts down.
It gets stuck (it seems to me) while wait.Poll ing for postStop hooks to complete.
Also note that Cassandra images use dumb-init which we bypass by making /pilot the entrypoint.
Our pilot may not be doing a good job as pid1
If you could prevent the database container from being signalled directly, and if the pilot could share the process namespace of the database container, the pilot wouldn't have to be concerned with starting the database.
I'd also like to consider whether the pilot could detect and use the original entrypoint of the image where it's been injected. (But not sure if that's going to work if the image already uses dumbinit.)
It saw what I thought was a case of the pilot not even responding to SIGKILL. The E2E tests fail because the ES namespace failed to delete within 5min. https://github.com/jetstack/navigator/pull/168#issuecomment-351103506 . I went searching through the kubelet source code yesterday and it looks like the deletionGracePeriod is used properly. I found https://github.com/moby/moby/issues/22802 which seems to suggest that SIGKILL has no effect if the process is in state uninterruptible sleep.
But when I tested the ES pilot and ES image with docker stop, the process seemed to exit upon kill -9. I couldn't see it ever get into uninterruptible sleep (so that's probably a red herring)


manage a gogs installation on docker

i'm new to docker, also new to gogs
however, i followed this tutorial https://github.com/gogits/gogs/blob/master/docker/README.md
and managed to install it with data volume container
all worked perfectly fine until i reboot the host server, i started the container, but without luck i couldn't make gogs to work
[docker@dkr root]$ docker exec -it gogs0 ps aux
PID   USER     TIME   COMMAND
    1 root       0:00 /bin/s6-svscan /app/gogs/docker/s6/
   19 root       0:00 s6-supervise openssh
   20 root       0:00 s6-supervise crond
   21 root       0:03 s6-supervise gogs
   22 root       0:00 s6-supervise syslogd
   23 root       0:00 /usr/sbin/sshd -D -f /app/gogs/docker/sshd_config
   24 root       0:00 /sbin/syslogd -nS -O-
10947 git        0:00 /app/gogs/gogs web
10959 root       0:00 ps aux

2e237494c25a        gogs/gogs           "/app/gogs/docker/..."   2 hours ago         Up 2 hours               <IP_ADDRESS>:10022->22/tcp, <IP_ADDRESS>:10080->3000/tcp   gogs0

when i try to connect to host:10080, i get connection refused
any idea ?
how can i restart the service ( without stopping the container )
were are the logs ?

docker ps will tell you what containers are running and what ports they are forwarding.

have you spotted my last line ?
**```
2e237494c25a        gogs/gogs           "/app/gogs/docker/..."   2 hours ago         Up 2 hours               <IP_ADDRESS>:10022->22/tcp, <IP_ADDRESS>:10080->3000/tcp   gogs0

also, i just realized that i cannot connect from outside
from host if i $curl it works
also, iptables are flushed ... i don't know what to do ...

Sorry I was clearly blind when I read your post...
The behavior you are discussing points directly to a firewall issue. That issue could be on the host machine or elsewhere on the network. Where is your host machine? Is it on your local network? On a VM on the internet?

is a VPS from vultr ( i don't know how much it matters ) but anyway
before updating the server with newer kernel and rebooted, i couldn't connect to any container ...
like i said. iptables are flushed, no ufw or firewalld installed ...
don't know what do do 😕

the host is CentOS7

Can you post the output of the following commands:
docker version
docker info
netstat -tulpn

[root@dkr ~]# docker version
Client:
 Version:      17.03.1-ce
 API version:  1.27
 Go version:   go1.7.5
 Git commit:   c6d412e
 Built:        Mon Mar 27 17:05:44 2017
 OS/Arch:      linux/amd64

Server:
 Version:      17.03.1-ce
 API version:  1.27 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   c6d412e
 Built:        Mon Mar 27 17:05:44 2017
 OS/Arch:      linux/amd64
 Experimental: false
[root@dkr ~]# docker info
Containers: 3
 Running: 3
 Paused: 0
 Stopped: 0
Images: 3
Server Version: 17.03.1-ce
Storage Driver: overlay
 Backing Filesystem: extfs
 Supports d_type: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 4ab9917febca54791c5f071a9d1f404867857fcc
runc version: 54296cf40ad8143b62dbcaa1d90e520a2136ddfe
init version: 949e6fa
Security Options:
 seccomp
  Profile: default
Kernel Version: 3.10.0-514.16.1.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 992.6 MiB
Name: dkr.xdns.ro
ID: XNIY:OIO6:KJYE:J56E:PQIA:JI7N:PHKW:ZTOF:GT37:XSWT:TWKH:HCJE
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false
[root@dkr ~]# netstat -tulpn
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State                                                                                PID/Program name
tcp        0      0 <IP_ADDRESS>:22              <IP_ADDRESS>:*               LISTEN                                                                                386/sshd
tcp        0      0 <IP_ADDRESS>:25            <IP_ADDRESS>:*               LISTEN                                                                                575/master
tcp6       0      0 :::8080                 :::*                    LISTEN                                                                                12373/docker-proxy
tcp6       0      0 :::22                   :::*                    LISTEN                                                                                386/sshd
tcp6       0      0 ::1:25                  :::*                    LISTEN                                                                                575/master
tcp6       0      0 :::10080                :::*                    LISTEN                                                                                9203/docker-proxy
tcp6       0      0 :::10022                :::*                    LISTEN                                                                                9213/docker-proxy
udp        0      0 <IP_ADDRESS>:53979           <IP_ADDRESS>:*                                                                                931/dhclient
udp        0      0 <IP_ADDRESS>:323           <IP_ADDRESS>:*                                                                                393/chronyd
udp        0      0 <IP_ADDRESS>:68              <IP_ADDRESS>:*                                                                                931/dhclient
udp6       0      0 ::1:323                 :::*                                                                                393/chronyd
udp6       0      0 :::22193                :::*                                                                                931/dhclient

pulled latest gogs docker image, started. No browser connection to the 10080 which is definitely present at netstat. When trying manually got:
telnet some.server.com 10080
Trying xxx.xxx.xxx.xx...
Connected to some.server.com.
Escape character is '^]'.
GET /
HTTP/1.1 400 Bad Request
Content-Type: text/plain; charset=utf-8
Connection: close

400 Bad RequestConnection closed by foreign host.

Gog is just throwing the code 400. How to debug further ?

docker logs should tell you what is going on in theory. There is also a log file in the container.
Sorry, I totally spaced out this issue...
@cybernet it seems like part of the problem might be that the default docker binding is connecting to the IPv6 addresses and that the IPv4 port forwarding is not working. There is a way to force docker to bind to the IPv4 address... let me look it up in a bit.

The logs should be printed to stdout as the container launched directly from the console:
docker run --rm --name=gogs -p 10022:22 -p 10080:3000 -v /var/gogs:/data gogs/gogs

But nothing is outputing to the console. I've checked the network by exiting from the container and launching the netcat app by 'nc -l 10080' - network is ok. Can you tell why (or when) the gogs throwing 400 response ?

So I'm seeing strange Chrome/FF behaviour - the http://some.server.com:10080 URL changes to https with SSL error just after trying to access the gogs.

And according to pure telnet test - it is definitely binding to IPv4 and you can get the response (400)

Got the valid response and some gogs log output with the following command:
wget some.server.com:10080 -O-

Seems like gogs is just screwed by some modern browser header...

Checked with konqueror - all is working (got the install page) ! So the issue is related to modern browsers.

@Sfinx your issue is likely HSTS key pinning which Chrome added some time ago. You can remove sites from the key pin by following the instructions on this page. https://linux-audit.com/delete-a-hsts-key-pin-in-chrome/

@cardonator

as I was told - such behavior is 100% reproduced as in chrome as in FF
I've deleted the domain from HSTS without any luck
I do not think that gogs docker web endpoint named http://some.host:10080 is using SSL

@cardonator You was right - is was HSTS chrome feature. It is appeared that all subsequent domains must be deleted from HSTS database - not only some.server.com but the server.com too. This is why it was not worked first time. Thanks !

Thanks @cardonator for all the help! :smile:


Pane closing slow / buggy

Describe the bug
Clicking in the "x" to close a pane takes several seconds to respond, and when it does, other panes are displaying the wrong data.
To Reproduce
Steps to reproduce the behavior:

start at https://s3.amazonaws.com/vitessce-data/demos/2021-02-11/c4c86af/index.html?dataset=linnarsson-2018&theme=dark
click the "x" to close the "Data Set" pane in the upper left.
after several seconds, the pane does close... but note that the t-SNE pane is showing PCA data

Screenshots

Environment:

Release or git hash: 2021-02-11/c4c86af
Browser: FF 84.0.2
Browser version:

This likely has to do with using an array index as a key for React here https://github.com/vitessce/vitessce/blob/123ca8a/src/app/vitessce-grid-layout/VitessceGridLayout.js#L82 https://robinpokorny.medium.com/index-as-a-key-is-an-anti-pattern-e0349aece318


Can start-chroot but startx or startxfce4 or init cause black screen and reboot

Please paste the output of the following command here: sudo edit-chroot -all

crosh> shell
chronos@localhost / $ sudo edit-chroot -all
name: xenial
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/xenial...
crouton: version 1-20171230152552~master:de1361af
release: xenial
architecture: arm64
xmethod: xorg
targets: xfce-desktop
host: version 9901.77.0 (Official Build) stable-channel bob
kernel: Linux localhost 4.4.79-11654-g7e0f59a105a1 #1 SMP PREEMPT Mon Nov 13 16:30:12 PST 2017 aarch64 aarch64 aarch64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...
chronos@localhost / $

#### Please describe your issue:

Asus C101 Flip - ARM

Put it into dev mode
Downloaded script and ran as xfce4
I can start-chroot and use as terminal

startx
startxfce4
initx

All cause black screen instantly, pause for around 1 minute and then reboot.
Also tried kde install and restore from rescue media

Help!!!

#### If known, describe the steps to reproduce the issue:

Seems this issue has been around for quite a while now and is related to video-armsoc drivers.
Take a look at this comment for a little more info.: https://github.com/dnschneid/crouton/issues/3611
For a couple of workarounds, see this comment: https://github.com/dnschneid/crouton/issues/3291#issuecomment-309564813
Hope this helps,
-DennisLfromGA


String representation of the Request

I expect implementations of the Request interface will be able convert itself to a loggable string but they don't have this feature

@yegor256 please pay attention to this issue

@dmzaytsev we'll implement toString in all of them

@dmzaytsev milestone set to 1.0 (correct me if I am wrong)

@adko-pl this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here
Task's budget is 30 mins (see this for explanation)

@dmzaytsev thanks for this report, I added 15 mins to your account, in transaction 59387637

@dmzaytsev The requested feature was already implemented in RqPrint, please take a look.


about the code

I have one question about the code, I think in main.py line 49, it should be model.forward(image). can you give me some explanation? many thanks.

Thanks for the comment. The output from  model.forward(image) and model(image) will be the same. However, to ensure that all hooks and other functionalities provided by PyTorch are properly utilized, it's safer to stick with model(images).

very thankful， I want to know when I want to evaluate the performance. Should I use backbone(image) or model(image)? Do I need mlp head when testing?

In most methods, the purpose is to pre-train the backbone, thus model.backbone(image) is the proper way. However, SimCLRv2 makes use of a part of the MLP as well. As a result, call model.eval() before calling model.backbone(image)

Thank you for your prompt reply！

One thing I don't understand is that in Dino's work, your self.lamda is a fixed value. Is it better to update according to the cosine schedule?

Indeed, in the original paper, it is updated with a cosine scheduler. However, I have not find a way to do it inside the class, thus it must be done manually in the training loop.


Engine::_json why not $this->response(), but $this->response(false)？I want add header before send json

Fixed in commit b9dfda3fd692421832b650744343b4fce6fe27d6.


upgrade kb and controller-runtime dep version

Description of the change:

Upgrade kb commit from f7a3b65dd250 to c993a2a221fe
Upgrade controller-runtime version from v0.6.2 to v0.6.3. More info: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.6.3

Motivation for the change:

Address bugfix in the deps
Solve tech-debts
Keep the projects aligned.

Checklist
If the pull request includes user-facing changes, extra documentation is required:

[x] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[ ] Add or update relevant sections of the docs website in website/content/en/docs

Hi @joelanford,

I generally agree with @estroz, but I would propose a perhaps reasonable middle ground: If we make a dependency bump that will have user-facing changes, we have a simple changelog entry that says something along the lines of

Bumped dependency A to vX.Y.Z. See  for details.

Where  is a link to the github release or changelog notes or whatever other doc documents that release.

We cannot do that currently because we still bumping the commits which indeed is my motivation here. Note that after we do a kb release and start to have more actively releases from there we will be able to achieve the goal in this way.

Ah I see. Since we're currently pinning to a random commit on master, there isn't a pretty release page or changelog. Could we link instead to a commit range? I think GitHub handles that nicely.

@camilamacedo86 It looks like you ran make bindata, which caused unnecessary/unrelated changes to internal/bindata/olm/manifests-0.15.1.go. Can you revert that change? I think running make fix will resolve it since it looks like a go fmt issue.
Also @varshaprasad96 @estroz we may want to use this fork: https://github.com/kevinburke/go-bindata
It seems to have more frequent maintenance, is the fork used for brew install go-bindata, and has binary releases which would enable us to consolidate the download and version checks in the new tools/scripts/fetch script.
One of the improvements is that it automatically go fmts the output it produces which I think would have resolved the error that @camilamacedo86 has with the changes to this file in this PR.

Hi @joelanford,

@camilamacedo86 It looks like you ran make bindata, which caused unnecessary/unrelated changes to internal/bindata/olm/manifests-0.15.1.go. Can you revert that change? I think running make fix will resolve it since it looks like a go fmt issue.

We cannot use the go fmt in the bindata. See: https://travis-ci.org/github/operator-framework/operator-sdk/jobs/737366995#L1335-L1342. IHMO the make generate cannot call the target to gen the bindata.

@camilamacedo86 Why does this PR have any changes to internal/bindata/olm/manifests-0.15.1.go?
Neither make generate nor make test-sanity call make bindata and make bindata is not called in CI.

@joelanford since our discussions here were only over the fragment and all suggestions made were addressed it shows fine to get merged. if you wish, we can change some word in a follow up as well.


Mention base64 encoding in protocol specification

Until I actually encountered errors in the code, I hadn't realized that base64 encoding was needed, partially because I don't use things that actually enforce unicode strings all that often. Since the string "base64" wasn't mentioned anywhere in the docs, at least bring it up to remind people that this is relevant.
I imagine other people might have similar questions.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jtbandes @jhurliman what's the latest thinking here? Do we want to include this or do we want to say this is outside of the core spec. Do we want to add an appendix where we cover various supported items.
Practically what is supported by this protocol is specific to what studio supports since this protocol exists to bridge systems to Studio.

I'm going to go ahead and close this PR since I believe we already state the relevant base64-encoding requirements on this docs page, which is linked from the schema field description in the spec.


Windows version could not load dynamic library 'DirectMLba106a7c621ea741d2159d8708ee581c11918380.dll'

Hi all,
I just installed windows version and running the test from here, but TF complains that Could not load dynamic library 'DirectMLba106a7c621ea741d2159d8708ee581c11918380.dll'.
The first time when I was installing tensorflow-directml, I got an error message
ERROR: Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: 'C:\\Users\\Username\\AppData\\Local\\Packages\\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\\LocalCache\\local-packages\\Python37\\site-packages\\tensorflow_estimator\\python\\estimator\\canned\\linear_optimizer\\python\\utils\\__pycache__\\sharded_mutable_dense_hashtable.cpython-37.pyc'

which didn't show up when I tried to do pip install again. I'm not sure if this error is related to the library issue.
The full input & output is
>>> import tensorflow.compat.v1 as tf
>>> tf.enable_eager_execution(tf.ConfigProto(log_device_placement=True))
>>> print(tf.add([1.0, 2.0], [3.0, 4.0]))
2020-08-16 22:42:06.778056: I tensorflow/core/common_runtime/dml/dml_device_factory.cc:45] DirectML device enumeration: found 1 compatible adapters.
2020-08-16 22:42:06.778504: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2
2020-08-16 22:42:06.780186: I tensorflow/core/common_runtime/dml/dml_device_factory.cc:32] DirectML: creating device on adapter 0 (Radeon RX Vega)
2020-08-16 22:42:06.854914: W tensorflow/stream_executor/platform/default/dso_loader.cc:71] Could not load dynamic library 'DirectMLba106a7c621ea741d2159d8708ee581c11918380.dll'; dlerror: DirectMLba106a7c621ea741d2159d8708ee581c11918380.dll not found

I tried to force-reinstall tensorflow-directml, but it didn't work.
Here is some additional information which could be useful.
Python version: 3.7.8 (it's standalone installation from the store, not conda)
Windows version: 19042.450
GPU: Vega 56
Driver version: 20.7.1

Hi,
I wonder if your version of Python is running into a file path length limit. The path C:\\Users\\Username\\AppData\\Local\\Packages\\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\\LocalCache\\local-packages\\Python37\\site-packages\\tensorflow_estimator\\python\\estimator\\canned\\linear_optimizer\\python\\utils\\__pycache__\\sharded_mutable_dense_hashtable.cpython-37.pyc is over 260 characters long, which may be causing an error during package install.
Could you try installing a standalone version of Python 3.7 from python.org and try again? I'd recommend installing it to a location with a shorter path, e.g. C:\python. Let us know how this goes.

Hi,
I wonder if your version of Python is running into a file path length limit. The path C:\\Users\\Username\\AppData\\Local\\Packages\\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\\LocalCache\\local-packages\\Python37\\site-packages\\tensorflow_estimator\\python\\estimator\\canned\\linear_optimizer\\python\\utils\\__pycache__\\sharded_mutable_dense_hashtable.cpython-37.pyc is over 260 characters long, which may be causing an error during package install.
Could you try installing a standalone version of Python 3.7 from python.org and try again? I'd recommend installing it to a location with a shorter path, e.g. C:\python. Let us know how this goes.

That's a good point. I tested with a maunally installed python and it indeed works.
Then I compared the two site-pakcages of both instllation. They are identical.
DirectMLba106a7c621ea741d2159d8708ee581c11918380.dll exists in the following path C:\Users\Username\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\_solib_directml\ and somehow the Windows Store version just couldn't find it.


Implement solr search

See #204 for background.

Having implemented an initial version, I have been testing performance on the staging box. The tests have been by doing:

Change solr/postgres backend setting;
Restart Ckan;
Clear Nginx caches;
Load initial grid page, but ignore results (As we've just restarted ckan, there will be overheads that are not linked to the database backend);
Click five times on the grid's 'next page' button, measure the time taken by the datastore_search API call  and average it out.

These are simply to get some overview of performance at this stage - the results will not necessarily translate to production environment. Also note that I haven't implemented 'unique' value filtering in solr yet (not needed for the test cases below, but needed for the field auto completion)

Search
Number of records
Request time with Postgres (ms)
Request time with Solr (ms)

None
2741761
2960
241.2

fts: diadema
941
1122
800 (first time I tried), 239 (subsequent times)

fts: plant
345527
8902.2
259.4

fts: specimen
2741761
timeout (60000+ ms), tried multiple times
355.4

family: Indridae
338
174 (right after indexing it)
614 (first time I tried), 158 (subsequent times)

We can see results vary, probably depending on which indexes are in memory and which are not. For the full text search of 'diadema' even the slow initial run in solr did better than Postgres - with subsequent runs being much faster. For the field search on 'Indridae', Postgresql had just indexed the field and we can see it performed pretty well - while the first run in solr was much slower (though subsequent solr calls were faster than the fast postgres one).
It is clear that, even if under some circumstances Postgres provides better performance, Solr is clearly doing much better at providing an acceptable performance under all tested scenarios.

I've realised that the results are not ordered. Even though I provide them to Postgres in the order I want, I get them back in whatever order Postgres thinks is more efficient.
So results above only apply to non-ordered results, though in practice this is not really meaningful because we always want them ordered on the primary key, to avoid page gaps and overlaps.

So having got ordered results from solr, we need to re-order them when we get them in Postgres. We can do this in two places:

Postgres itself, by adding an Order by clause to the query (at a glance, it doesn't seem other tricks will improve performance);
Order them back in Python.

The latter is tempting, because the whole result set gets processed in Python anyway. This is because CKAN applies a convert function to every single value - so the whole result set is scanned row by row, field by field to apply a convert function.
We might as well do that in the order we know we want the rows.

Tests on my development box show adding the order by adds about 10ms to 15ms on a 30ms query (for 5,000 rows). For 5,000 rows is also needs a 2M work mem to happen in memory.
A naive python implementation is actually a bit slower. It can probably be implemented faster, but this is not the low hanging fruit at the moment, so we'll go for the order by approach.


AWS -  Cloudformation fargate Selenoid configurations

I am trying to run the selenium automated scripts in AWS Cloudformation - Fargate - Selenoid. However I didn't know the configurations which we need to pass in .yml or json file. Can you please help with this.

@vinothvasu5300 we personally have no experience with Fargate. Don't use Selenoid with Fargate EKS: https://aerokube.com/selenoid/latest/#_selenoid_in_kubernetes Probably it will work with Fargate ECS.

Thanks for the response @vania-pooh


🚧 Client v2

[x] Drop support for python v2
[x] Remove six
[x] Migrate to poetry
[x] Get rid of deprecated functions/features
[x] pandas v1
[ ] Rebase once #180 is merged

Testable using the release candidate using pip install craft-ai==2.0.0rc2

@yleprincecraft @sperretcraft @PaulineMCraft @juliencraftai please test and give feedback ! It's also the right time to make big changes.


Document the operation canceling

Our APIs return Operation (aka UIOperation) but it's not documented.
Add simple documentation to it.

Also, verify how canceling is implemented and write tests for it


Add plugin support

I am currently writing a tree-sitter grammar for a DSL (domain specific language), and would like to add Difftastic support to it as well. This DSL won't be super useful to the general Difftastic user, though, from what I can tell, the only way to add a new parser is to merge the code in here, or fork it and add it to the fork.
I propose that we allow for a "plugin" system of sorts: Basically, you create a .so file which contains:

The TreeSitterConfig data (which calls tree_sitter_xyz())
A guess function which returns true/false if the passed file should use this new plugin

And then you run difft like so:
$ difft --load plugin.so old.dsl new.dsl

At least, that's how I would go about it (from what I can see from briefly looking at the code). Would this be something you would be interested in? If we decide it is worthwhile I would totally be willing to implement it, though I will say I am somewhat new to Rust.

I would like to add that there's a growing number of tools that support Tree-Sitter grammars in one way or another and it would be nice to be able to install those grammars in a single place on OS and have tools pick them up dynamically somehow, with all tools having same (or mostly overlapping) set of supported languages.
Currently each tool solves this slightly differently - some, like difftastic embed languages at compile time, while others (Neovim for example), supports some sort of dynamic loading and even compilation of language definitions.
It would be nice for the tools to agree on some sort of shared common ground and plug-in system for sharing grammar definitions.

@luolong Here is some tools I found which use tree-sitter, all of which have their own way about doing module loading:

Zee Editor: Loaded from ~/.config/zee/grammars
Diffsitter: Uses config file which points to .so files
Semantic (used on GitHub): Manual source integration, no plugins from what I can tell

And then of course a plethora of libraries which solely rely on tree-sitter itself to provide the grammars (and thus don't support modular loading of grammars). I feel like every program has their own way of doing it because tree-sitter itself does not provide it. Although we could talk to every program author that uses tree-sitter and see if we can come to some sort of consensus, I feel like a better (and more sustainable long term) solution is to start a conversation with the tree-sitter devs themselves, and see how they would approach this.
The only issue though is that we have additional code we need to run for each grammar, so we still need a way to dynamically load the code for that, in addition to the tree-sitter provided grammar.

https://crates.io/crates/tree-sitter-loader looks very relevant here.


How to remove this app

Hi,
I tried to install this on my fedora but then I found another app for gnome shell...
How could I remove this app please ?
Thanks for your help.

Hi Paul
Just remove the folder where you put it :)
/S
On Fri, Apr 3, 2020 at 2:32 PM paul-onof<EMAIL_ADDRESS>wrote:

Hi,
I tried to install this on my fedora but then I found another app for
gnome shell...
How could I remove this app please ?
Thanks for your help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bluppfisk/coinprice-indicator/issues/66, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLVKNFXLQBCW3LJGB3O4P3RKXJPFANCNFSM4L36C4HQ
.

What about the icon created by the system? can we remove it?

Hello Paul
remove /usr/share/applications/coindicator.desktop
It will probably take a little while for this to take effect as it is
cached.
Best regards,
--
Sander Van de Moortel
Communication and IT
NL - EN - SV - FR - DE - ZH
+32 473 888 408 (Belgium)
skype: sandervdm
On Wed, Nov 10, 2021 at 12:13 AM RichterGB @.***> wrote:

What about the icon created by the system? can we remove it?
[image: image]
https://user-images.githubusercontent.com/88848954/141020503-447c582c-e083-439b-8a8a-1447f5f3f216.png
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bluppfisk/coinprice-indicator/issues/66#issuecomment-964629708,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLVKNEWTTFENEIPHAQBSN3ULGTLHANCNFSM4L36C4HQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


MLAi library link

Can you provide the link to the library mentioned in your website? https://mlstruct.ppizarror.com/#home

Hi, this library is private by now! Once we debug many things, it will become public, I expect, in about a year. Thanks for your interest,
Pablo


Fix displaying error message

Codecov Report
Patch coverage: 11.11% and project coverage change: -0.11% :warning:

Comparison is base (5c690b9) 68.43% compared to head (07d4e7e) 68.33%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   68.43%   68.33%   -0.11%
==========================================
  Files          21       21
  Lines        4084     4090       +6
==========================================
  Hits         2795     2795
- Misses       1289     1295       +6

Files Changed
Coverage Δ

src/graphql/export.rs
15.66% <0.00%> (-0.28%)
:arrow_down:

src/graphql.rs
74.59% <50.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Mediapipe becomes the industry GAME standards for Mocap by providing first class support for  .NET wrapper

MediaPipe Solution (you are using)
Latest
Programming language
.NET
Are you willing to contribute it
Yes
Describe the feature and the current behaviour/state
Current state

VS2019 and VS2022 (up to 17.2.3) Windows build solution is provided by a community user: @@andrechen

Since 2020

Small addition (e.g. extern "c") of mediapipe c++ for consumption by .NET and the corresponding MediaPipe .NET wrappers have been in use "Officially" by .NET Game  (Unity) developers

Will this change the current API? How?
NO
By incorporating the export extern "C" done in MediaPipeUnityPlugin, there is a minimum change to the existing API
Who will benefit from this feature?
If this project would provide first-class support, there will be a FASTER turnaround of mediapipe support for .NET Game (Unity) Community
This will be "SUPER" Exciting for the .NET Game developers.
Previously, for the .NET Unity Game developers, there are many other alternatives.
Please specify the use cases for this feature
Mediapipe as industry standards for Mocap starting version <IP_ADDRESS>
Starting mediapipe v<IP_ADDRESS>, with the integration of BlendShape support, other alternatives become less attractive. Mediapipe now become the Game .NET industry standards for Mocap
Any Other info
No response

@ayushgdev
I close it as I assume it may not align with mediapipe vision. What do you think?


Issue with Git push permissions in generate project pages script

Problem Description
The git push action in the Generate Project Pages action is not working because of authentication issues. The push command from GitPython does not use the credentials supplied earlier in the file.
See https://github.com/creativecommons/ccos-scripts/runs/550457801?check_suite_focus=true for example.
Solution Description
origin.push() should use the credentials that the repo was initialized with earlier in the file.
Additional context

GitPython documentation

@sp35 are you interested in working on this?

@kgodey Interested!

@sp35 thank you!

@kgodey Although, it's obvious that it's lacking credentials at https://github.com/creativecommons/ccos-scripts/runs/550457801?check_suite_focus=true
However, I couldn't replicate it, when testing on my fork https://github.com/sp35/creativecommons.github.io-source/commits/master
Possibly we can try the equivalent of
git push --repo <GITHUB_REPO_URL_WITH_CREDENTIALS>
maybe repo.git.push(repo=GITHUB_REPO_URL_WITH_CREDENTIALS)

@kgodey Please check if there is an issue with the secret ADMIN_GITHUB_TOKEN. Was the token changed recently and unchanged in the secrets of this repository?
I tested it against the fork of my repo and I was able to push after setting up the secret.
Please do let me know if the problem persists.

@sp35 what permissions did you use when you set up your secret?

Access to public repo only.
FYI I had to skip the part where we collect data from all repositories of CC as I was testing on my fork (my name isn't an org), which is justified as there was an issue with the push command, which worked!

I've verified that the token has access to push to all public and private repos. It's also the same token used for the normalize repos script, which updates repo information fine (and that's working correctly).

There is still an authentication error: https://github.com/creativecommons/ccos-scripts/actions/runs/72019007

This wasn't expected. I'll look into it.

Just a single change, i.e. the organization, the code works. https://github.com/sp35/ccos-scripts/commit/e2d148d03bb289a15bc384f5833aa9677e502765
Tests ok - https://github.com/sp35/ccos-scripts/runs/568573407?check_suite_focus=true
Pushed commit - https://github.com/sp35/creativecommons.github.io-source/commit/43473392f3571633a4a99be365213569a679cd33?diff=split
Sad that I still couldn't figure it out, but it's all about git now.
Why is git push <URL_with_token> master giving error 128, auth failed, if @kgodey has confirmed that there isn't an issue with the pat/secret; given it works on my fork?
The best I could do was to bring the problem to the git level from the gitpython one; which brings in the questions, is push actually allowed, what's interfering?

That's very odd. I'll do some tests with the token when I have some time.

It appears I had the wrong token set up, updating the token seemed to fix it. I am still not sure why the token didn't work, but I'll worry about that if it comes up again.

@kgodey Please check if there is an issue with the secret ADMIN_GITHUB_TOKEN.
The first thing that I had suspected!
Ended up looking at a lot of similar errors but learned something, so nvm!

Yeah, I had tried switching the token then and nothing changed. :(


Support for showing uses of a definition?

Hi,
A nice feature would be to show the uses of a definition.
E.g. if the cursor is on a function definition, a keybinding shows all the call sites.
Similarly for variable names etc.
Thanks

Something like qstrahl/vim-matchmaker?

It's not really the same. That looks textual, whereas I would like semantic.

IMHO phildawes/racer is the better place to ask for none trivial features. Finding variables requires knowledge of the scope level, hence parsing etc pp. deoplete-rust provides merely a wrapper to racer.


Make it possible to create GUI mode applications in Windows

Feature Request

Is your feature request related to a problem? Please describe clearly and concisely what is it.
Right now, every crystal program on Windows creates console window. It is fine for experimenting, but for polished programs (GUI, games, headless servers, etc) there should be a way to build without showing console window.

Describe the feature you would like, optionally illustrated by examples, and how it will solve the above problem.
I've tried adding @[Link(ldflags: "/subsystem:windows")] - application just silently closes after start.
I think the problem is in https://github.com/crystal-lang/crystal/blob/master/src/crystal/system/win32/wmain.cr so tried to change it in different ways (change entry point to fun wWinMain(ptr1 : Void*, ptr2 : Void*, argc : Int32, argv : UInt16**) : Int32, change flags) but no luck - application still closes at start.

Minimal example:

@[Link(ldflags: "/subsystem:windows")] # it works (but show console window) if this line is commented
@[Link("user32")]
lib WinAPI
    fun message_box = MessageBoxA(hWnd : Void*, lpText : UInt8*, lpCaption : UInt8*,  uType : UInt32)
end

WinAPI.message_box(Pointer(Void).null, "Hello", "World", 0)

At the minimum you will need the following monkey-patch, because otherwise the Crystal runtime will attempt to configure a non-existent console:
module Crystal::System::FileDescriptor
  def self.from_stdio(fd)
    console_handle = false
    handle = LibC._get_osfhandle(fd)
    if handle != -1 && handle != -2
      handle = LibC::HANDLE.new(handle)
      # TODO: use `out old_mode` after implementing interpreter out closured var
      old_mode = uninitialized LibC::DWORD
      if LibC.GetConsoleMode(handle, pointerof(old_mode)) != 0
        console_handle = true
        if fd == 1 || fd == 2 # STDOUT or STDERR
          if LibC.SetConsoleMode(handle, old_mode | LibC::ENABLE_VIRTUAL_TERMINAL_PROCESSING) != 0
            at_exit { LibC.SetConsoleMode(handle, old_mode) }
          end
        end
      end
    end

    io = IO::FileDescriptor.new(fd, blocking: true)
    # Set sync or flush_on_newline as described in STDOUT and STDERR docs.
    # See https://crystal-lang.org/api/toplevel.html#STDERR
    if console_handle
      io.sync = true
    else
      io.flush_on_newline = true
    end
    io
  end
end

Strictly speaking, you don't need a different entry point to be able to display any GUI, but one can be provided nonetheless:
@[Link(ldflags: "/ENTRY:wWinMainCRTStartup")]
@[Link(ldflags: "/SUBSYSTEM:WINDOWS")]
lib LibCrystalMain
end

fun wWinMain(
  hInstance : LibC::HINSTANCE,
  hPrevInstance : LibC::HINSTANCE,
  pCmdLine : LibC::LPWSTR,
  nCmdShow : LibC::Int,
) : LibC::Int
  LibC.CommandLineToArgvW(pCmdLine, out argc)
  wmain(argc, argv)
ensure
  LibC.LocalFree(argv) if argv
end

This is still not enough for production use because a lot of the places in Crystal's runtime still assume the presence of the standard streams (e.g. unhandled exceptions always go to STDERR).

The parameters in the alternative entrypoint can be retrieved as follows:
lib LibC
  # libloaderapi.h
  fun GetModuleHandleW(lpModuleName : LPWSTR) : HMODULE

  # processenv.h
  fun GetCommandLineW : LPWSTR

  # processthreadsapi.h
  fun GetStartupInfoW(lpStartupInfo : STARTUPINFOW*)
end

# if `wWinMain` is invoked, then we are not building a DLL,
# so the following always works
hInstance = LibC.GetModuleHandleW(nil)

# this parameter exists for compatibility only
hPrevInstance = LibC::HINSTANCE.null

# the raw command line string, rarely needed when `ARGV` exists
pCmdLine = LibC.GetCommandLineW

# usually this is `SW_SHOW = 1`
# one way to customize this value is by creating a Windows shortcut to the program,
# then changing Shortcut -> Run in the shortcut properties dialog, which could produce
# `SW_MAXIMIZE = 3` or `SW_SHOWMINNOACTIVE = 7`
# the other way is by calling `LibC.CreateProcessW` directly
LibC.GetStartupInfoW(out startup_info)
nCmdShow = startup_info.wShowWindow

So while wWinMain is a convenience, I don't think it is ever necessary for writing Windows GUI applications, not even in C. Passing --link-flags=/SUBSYSTEM:WINDOWS during compilation should be sufficient now that the monkeypatch above is merged.
If #13330 is implemented, it becomes the responsibility of user code to redefine Crystal.fatal as appropriate. An unhandled exception may very well attempt to write the message to a file rather than showing a modal dialog, and it is not the standard library's job to decide. So that should leave nothing actionable that is exclusive to this issue.


Can you integrate with Shiro? Are there any examples?

This library implements integration with Java CAS client. Has nothing to do with Shiro. You might be interested in this: https://shiro.apache.org/spring-boot.html


Feature/e2e tests

Related Issues

closes https://github.com/DivanteLtd/next/issues/411
Short Description and Why It's Useful
E2e tests on critical paths for VSF Next
Screenshots of Visual Changes before/after (if There Are Any)

Which Environment This Relates To
Check your case. In case of any doubts please read about Release Cycle

[ ] Test version (https://test.storefrontcloud.io) - this is a new feature or improvement for Vue Storefront. I've created branch from develop branch and want to merge it back to develop
[ ] RC version (https://next.storefrontcloud.io) - this is a stabilisation fix for Release Candidate of Vue Storefront. I've created branch from release branch and want to merge it back to release
[ ] Stable version (https://demo.storefrontcloud.io) - this is an important fix for current stable version. I've created branch from hotfix or master branch and want to merge it back to hotfix

Upgrade Notes and Changelog

[x] No upgrade steps required (100% backward compatibility and no breaking changes)
[ ] I've updated the Upgrade notes and Changelog on how to port existing Vue Storefront sites with this new feature

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change
Contribution and Currently Important Rules Acceptance

[ ] I read and followed contribution rules

@alinadivante any progress here after @gibkigonzo feedback?

@filrak I will try to go back to it today, improve it and push it :)

https://travis-ci.org/github/DivanteLtd/vue-storefront/jobs/695986338 please resolve those linting issues before I can merge ;)


Migrate to GHA

Adds deploy, test, and enforcer workflows. Updates dependencies. Removes Travis file.

Going to force merge despite the check branch failing. Accidentally opened this PR against base first, and that's why it's failing.


Clear entire playlist

admins should be able to clear an entire playlist without having to remove tracks one at a time

/clearall as an admin now does this


chore: fix lint-staged eslint CI errors due to wrong eslint config being used

We need a lint-staged setup for every monorepo package. Otherwise, lint-staged will run eslint for that file FROM the monorepo root, which is incorrect, as that makes eslint use the root eslint config for that file, not the package-specific one.
Here is a CI run that failed due to that: https://github.com/payloadcms/payload/actions/runs/10023457252/job/27704395086?pr=7224 . Any configs added by a sub-eslint config are currently not respected, leading to eslint errors you wouldn't see in local development. Adding lint-staged to the test package.json fixed it for that specific PR.
This PR adds it to all the other remaining packages. This is also recommended by lint-staged in a monorepo setup: https://github.com/lint-staged/lint-staged#how-to-use-lint-staged-in-a-multi-package-monorepo (while they recommend a .lintstagedrc.json, the package.json lint-stages object works and is respected by lint-staged just as well. I'd rather have that than one additional file for every single package)

While it does look like they recommend this, it just seems very backwards. Why would a monorepo package have to have a lint-staged pattern for templates/website/**/*?
We should look deeply for a different solution.


Allow explicit configuration of which files to run

We should have a dialog that pops up with all the tests in the directory and let users uncheck the ones they want to ignore.

This is partially fixed with #22 ... you can now specify the root of where your tests are... but users may still want this feature so I'll leave it opened and if enough people want it, then it can be added.


Unknown argument: generate-fragments

Things were going well until the last line:
npm i -g graphql-cli graphql-cli-generate-fragments
graphql init
graphql get-schema
graphql generate-fragments

Get the usage help with the last line saying: Uknown argument: generate-fragments
Versions:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Windows 10

@zbyte64 can you share your .graphqlconfig.yml?

.graphqlconfig::
{
  "projects": {
    "topflavorfarms": {
      "schemaPath": "schema.graphql",
      "extensions": {
        "endpoints": {
          "default": "http://localhost:8000/graphql/"
        }
      },
      "generate-fragments" {
        "output": "planter/src/graphql/app.fragments.js"
        "generator": "js"
    }
  }
}

Can you try graphqlconfig.yml rather than json?


Render save charities on User Portfolio component

Render charities data on card based on logged user in Portfolio component


Fix docs for proper location of fixture

This also deletes an initial_data fixture that is no longer needed (and
the use of which is deprecated in Django 1.9), and fixes tests that used the outdated fixture. tried mightily to ditch initial_data but it's the only method travis will accept.

Coverage decreased (-0.2%) to 99.151% when pulling 5df16a7be73736c41a8b6ac1d4ee100cb81a5b9e on fix-docs into 4e671d459342f1a0740d33468d00f9781f2a08b6 on master.

Coverage decreased (-0.1%) to 99.203% when pulling 6126642b84c6a1cf7124142df7958b9ac7fdcc2e on fix-docs into 4e671d459342f1a0740d33468d00f9781f2a08b6 on master.

@willbarton I think I earned enough git miles to qualify for the platinum Squash Commits button.

Coverage decreased (-0.1%) to 99.2% when pulling 9cd532e1ded7e920c30308cebfeb53e8ec720528 on fix-docs into 4e671d459342f1a0740d33468d00f9781f2a08b6 on master.


Default specification name

When I "export specification" (Exportovat specifikaci) the file is named "output.zip", it would be nice to include the name of the package.
For example for package name "2024-11-04 DCAT Test" the specification could be "2024-11-04 DCAT Test.zip" or similar.
Any suggestion for a better name @jakubklimek ?

I agree


Pick random port for integration tests.

Kokoro and Jenkins do not run in a container, so the port used for the emulator might be used by another application, or another instance of the tests. We should select those ports at random, or pick an unused port using 0 (but the emulator would need to print the selected port and we would need to parse that).

Fixed.


[BUG] Not showing png in VS Code

[x] I have searched for existing issues that already reported this problem and found none
[ ] The bug is present in REPL

Describe the bug
Not showing image in VS code
To Reproduce
Use below code and preview in VS Code, i have downloaded favicon.png from tryout (also tried with my own png)
Begin of the code
Blocks
console.log('hello, JavaScript')

Products
Price

Apple
4

Banana
2

End of the code
Expected behavior
The preview should show png image
Actual behavior
It did not show png image, but others working fine
Environment:
Version: 1.89.1 (user setup)
Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685
Date: 2024-05-07T05:13:33.891Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.19045
Additional context
N/A

Reported to wrong git


cleaning up and fixing links

This PR makes the format of the links consistent to the prevailing style in the docs and fixes a few broken external links.
Using .md in link text rather than .html causes Docusarus to convert the links into absolute links rather than using relative links, making the docs easier to port to other contexts.
Also updating a few broken external links.

Thanks @suneet-s.  I didn't use a script, no. I found these by search & replace, since each one required manual confirmation. I think it may be possible to automate, if we could come up with a clever enough regex, but I didn't get there while making these changes. Maybe be worth looking into.

Thanks for the contribution @sthetland !


Closes #26 - Add Exact Posting Time

Added helper function for HH:mm:ss, LL format. (21:40:54, November 10, 2015)

Awesome! Thanks! :+1:

It's live :smile:


Image enhancements - Supports full-screen display

This function solves the problem (这个功能解决的问题)
Supports full-screen display、Display Caption
Expected API (期望的 API)
A named slot extra is provided for users to customize additional content in the footer.

I think this is not necessary, too limited style, low reuse rate, in fact, position: absolute can be done


Content Wrong in page https://learn.microsoft.com/en-us/certifications/exams/ai-900/?tab=tab-learning-paths

When the user clicks on "Journey To Certification" link, they are taken to AI 102 exam details instead of AI 900 content. Kindly look into this.
Link - https://learn.microsoft.com/en-us/certifications/exams/ai-900/?tab=tab-learning-paths
New page  - https://query.prod.cms.rt.microsoft.com/cms/api/am/binary/RE4ARlg

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 70fbb1c8-1435-e762-8824-78cf96faed84
Version Independent ID: 062879b5-72cf-2353-63f2-d862fe1b40ba
Content: Microsoft Learn documentation contributor guide overview - Contributor guide
Content Source: Contribute/index.md
Product: non-product-specific
GitHub Login: @carlyrevier
Microsoft Alias: cahublou

@bipach Is this something that you can assist with? Thank you.

@sumibabu1511 Thank you for opening this issue! While we don't specifically work on the page you linked to, we were able to find the contact who is responsible for that page, and they've updated the link. Thanks again!


Help Needed with pokemon.json

#Other than asking if there's a updated pokemon.json, if anyone is reading this, if you have the time, please help us. I have check and done up to pokemon: 018, download the file below and load it into http://www.jsoneditoronline.org/ use the arrow key to load the file to editor and edit from there.
https://www.dropbox.com/s/91na4xcbwkhc2tg/pokemon.json?dl=0
Compare data with https://thesilphroad.com/catalog and make the changes. Take note especially to fast moves and special attacks, the base attack, defense and stamina, the candies need for evolution for new pokemons. If stones are needed for upgrade, don't add in first, bot cant handle yet.
Any changes to moves, please do an INSERT instead of changing the values.
Thank you. If you can't finish it, save it to your own dropbox/iCloud/or any sharing services and leave  the link here and ask next person to continue. Or you can leave a comment here telling people you will be doing from which pokemon to which. Someone else can do a different set so that there will be no overlapping of work.
Once we are sure the file is good to go and all agreed it's good, I'll do a PR for it.
Thank you so much for helping. Any errors, we can amend it later.
If you need the updated moves and item list, download below:
https://www.dropbox.com/s/eqevifg4xay6cp3/items.json?dl=0
https://www.dropbox.com/s/lkbbhli6zzbgapt/charged_moves.json?dl=0
https://www.dropbox.com/s/415jxv7curblr9q/fast_moves.json?dl=0
Update: with the help of @rubyShell and @zyrix the Pokemon.json is ready.i will do a PR with some changes to some function of the bot together with these new files later. For now, you can download it here:
Update 2: Realised Gen 1 old moves are removed. Download link has been removed until I fix it again.
Update 3: Finally, here's the updated pokemon.json Will need to have some more changes. But for now, it should solve most of the error message about missing moves. Use together with 3 other files posted above.
https://www.dropbox.com/s/91na4xcbwkhc2tg/pokemon.json?dl=0

I can try to help. Going to jump on #19 but I see it's fairly updated already. I'll put a note on how far I get by comparing the catalog

@rubyShell Thank you. The changes will start mostly from gen 2. But gen 1 will also have some slight changes. Just make sure you add in new moves and not edit the old ones.

@MerlionRock You got it. Going to go as far as I can confirming the Gen1 pokemon and then trying to start with Gen2.

Up to #026. Sorry for the lag. Kids driving me crazy at home lol

https://www.dropbox.com/s/ovalxjqrf9govzu/pokemon.json.updated_026?dl=0

I can help you by adding the new moves from Gen2.

@Zyrix Thanks! I'm on #64 for Gen1

#92 for now. Going to charge my laptop and finish up in about an hour. I should have Gen1 done soon enough. @Zyrix is working on Gen2. Thanks

If we consider https://thesilphroad.com/catalog as trustworthy, later today (my day just started) I will write a tool which will update the Pokémon.json and create a new one (it will have two modes).
Also it will be nice to have a web source for just moves and items, as it has been described here :
https://github.com/PokemonGoF/PokemonGo-Bot/issues/5914#issuecomment-280611681

@pogarek excellent. I'm almost done with Gen1 and I think @Zyrix is handling Gen2. Definitely will be good to look for mistakes we made manually (if any).

Damn . https://thesilphroad.com/catalog Is missing evolution data.. So I will need to fetch this from another website.. Anyway - we will see what we will have in a few hours .

@rubyshell @zyrix @pogarek thank-you guys. Understand there might be some overlapping of work especially when scripting can do this quite efficiently.
I went ahead with manual as I can't find one trustworthy source with all information in. Once again thaNk you guys.

Welcome!
Gen1 pokemon.json is completed.
Here is the link
https://www.dropbox.com/s/tzaizjw29xk5mpj/pokemon.json.gen1?dl=0
I'm going to bed. I'm in California so it's getting late for me. :)

Ok. Gen1 done. Here's the link. I ran it and caught a few typos but cleaned them up.
https://www.dropbox.com/s/byi11vipcz00kda/pokemon.json.gen1?dl=0
Hope this helps!

@rubyshell, thank-you so much.
@pogark the evolution should be there? Or not available for Gen 2?
Possible to use two sources?
@zyrix let us know your progress so we'll know how to progress from here. Script should be able to fill in existing missing info.

Yeah, I will need to combine at least two sources.

I'm finished with Gen2

@zyrix thank you so much. Did you run the bot with it? Any errors?
Post the link. I'm currently running a live production, can't do any thing. @pogarek you want to combine them?

I ran a semi automatic script and checked manually for errors.
https://www.dropbox.com/s/4hdvyu9iywq1o6o/pokemon.json?dl=0

My script will take any pokemon.json (in structure for bot), then it will create a new one an updated one , based on sliproad and another website (for data missing on sliphroad). Then you can compare new files with these one , than you done manually , so we will know how to proceed from there
Get Outlook for iOS
On Sat, Feb 18, 2017 at 10:24 AM +0100, "Philipp Brandl"<EMAIL_ADDRESS>wrote:
I ran a semi automatic script and checked manually for errors.
https://www.dropbox.com/s/4hdvyu9iywq1o6o/pokemon.json?dl=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Okay. Wait for you.

Starting to code now. I'll be back when I'll done / have something to share.

ok, so it seems that https://thesilphroad.com/catalog has a lot of data already in the code : it has pokemondata variable , in json, as script value.
Attaching a file with these json data. I'll use it for further parsing, but this is a good start.

This is the pokemon.json I am using at the moment
https://dl.dropboxusercontent.com/u/9125175/pokemon.json
No errors so far!

@camnomis I just did the PR with the changes we did :)

@MerlionRock No worries, I run my bot on a VM so can roll back any changes when a new build is out :)

Golbat is missing next evolution data: https://fevgames.net/pokedex/042-golbat/
Requirements are not added there, I'll assume 100.

Is there anything else to do than to replace the pokemon.json?  Bot isn't working.
With the default pokemon.json, the bot is working. Only some errors while bot is running:
[ERROR] Unexpected moveset
Example:
KeyError: 'Unknown fast attack: "Hex"'

try the attached file (rename it to pokemon.json) and let me know. we still testing
pokemon-appended.txt

Traceback (most recent call last):
  File "pokecli.py", line 51, in <module>
    from pokemongo_bot import PokemonGoBot, TreeConfigBuilder
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/__init__.py", line 23, in <module>
    from . import cell_workers
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/cell_workers/__init__.py", line 4, in <module>
    from .evolve_pokemon import EvolvePokemon
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/cell_workers/evolve_pokemon.py", line 2, in <module>
    from pokemongo_bot import inventory
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/inventory.py", line 1405, in <module>
    Pokemons()  # init Pokemons
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/inventory.py", line 55, in __init__
    super(_BaseInventoryComponent, self).__init__()
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/inventory.py", line 34, in __init__
    self.init_static_data()
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/inventory.py", line 40, in init_static_data
    json.load(open(cls.STATIC_DATA_FILE)))
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/inventory.py", line 406, in process_static_data
    data = [PokemonInfo(d) for d in data]
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/inventory.py", line 794, in __init__
    self.fast_attacks = self._process_attacks()
  File "/Users/andre/dev/PokemonGo-Bot/pokemongo_bot/inventory.py", line 924, in _process_attacks
    'charged' if charged else 'fast', name))
KeyError: 'Unknown fast attack: "Fire Spin"'
Sa 18 Feb 2017 22:21:48 CET Pokebot  Stopped.
Press any button or wait 20 seconds to continue.

ok, it seems that haven't updated another files. Replace all .json files (you can make a copy if you wish) by these ones from commit: https://github.com/PokemonGoF/PokemonGo-Bot/pull/5918/files

Now I've some other errors! I'm trying to find it myself

Two corrections
Unexpected moveset [Scratch, Sand Tomb] for #27 Sandshrew, please update info in pokemon.json and create issue/PR
[2017-02-18 21:51:59] [   Pokemon] [ERROR] Unexpected moveset [Tackle, Flamethrower] for #156 Quilava, please upd

Guys, PR has been made. Get files from https://github.com/PokemonGoF/PokemonGo-Bot/pull/5918/files and check again .

@pogarek In my case I get this error:
UnicodeDecodeError: 'ascii' codec can't decode byte 0x9c in position 1: ordinal not in range(128)
[2017-02-18 23:26:08] [sentry.errors.uncaught] [ERROR] [u"KeyError: u'captcha_url'", u'  File "pokecli.py", line 865, in <module>', u'  File "pokecli.py", line 195, in main', u'  File "pokecli.py", line 147, in start_bot', u'  File "pokemongo_bot/__init__.py", line 153, in start', u'  File "pokemongo_bot/__init__.py", line 1076, in _setup_api', u'  File "pokemongo_bot/__init__.py", line 996, in login', u'  File "pokemongo_bot/event_manager.py", line 73, in emit']
Sa 18 Feb 2017 23:26:08 CET Pokebot  Stopped.

Couldn't figure out why.

looks like config error..Not related to this issue.

Applying the changes in this PR worked for me!

@svaj there will still be changes. Some moves are still incorrect

@MerlionRock how we looking? Just debugging moveset errors? Just wondering how else I can help here. I have a few hours to spare at the moment :)

@rubyShell : let me summarize:

pokemon.json is, done. (attaching the latest one,
pokemon.json.txt ; done with https://github.com/pogarek/PokemonDataImporter )
fast_moves.json and charged_moves.json are updated, but might be incorrect : energy is/was negative in some cases, which causes tests to fail. However negative value in some move make evolve in pokemonOptimizer failed, for one of my tests bots..

So I would say, that test it out. I could generate moves automatically (like it has been done for pokemon.json) , if someone help me with #5921

@pogarek I'll test it out and see what I can do about #5921 Let me give it a try :)

Have been running for a few hours one a single account with latest pokemon.json from pogarek. No moveset errors, but did get several times "Possibly searching too often, take a rest",  and once "Server is throttling"

[2017-02-20 13:52:31] [   Pokemon] [ERROR] Unexpected moveset [Scratch, Aqua Jet] for #158 Totodile, please update info in pokemon.json and create issue/PR
[2017-02-20 13:52:31] [   Pokemon] [ERROR] Unexpected moveset [Peck, Drill Peck] for #198 Murkrow, please update info in pokemon.json and create issue/PR
how can i fix?
i already  git pull & ./setup.sh -r
and git status is master branch

I think there is an error in the automatically generated pokemon.json
For generation II every pokemon has tackle as fast attack and struggle as charged attack.
IIRC these were just placeholders.

@ais1406 That's because when you did that, the PR wasn't merged. Try again with ./setup -u

Issue closed as PR merged.


Added Russian and Ukrainian languages & link sync

Added Ukrainian lang & link sync

protect me

protect me

??


Add documentation for defining policy_class instance method

I encountered a use case which required me to to define policy_class for instances of a class and had to do a little digging to make sure that I was able to do so. I thought it would be useful for other users of Pundit to see this feature via the documentation.

I ... didn't know that this works. I'm not 100% sure we actually want to advertise this as a feature, since the fact that it works is a bit coincidental.

Fair enough @jnicklas, I discovered reading this line. Shall I go ahead and close the PR?


(PA-4700) Update github actions to account for 7.x branch

Puppet 6.x will be end of life on February 28, 2023 and Puppet 7.x will become the long term support (LTS) branch. In preparation for this, a new Puppet 7.x branch will be created and Puppet's GitHub Actions & protection rules must be updated. This PR updates Puppet's GitHub Actions to account for 7.x being the new LTS branch.

Puppet 7.x branch has been and the branch protection rules for 7.x have been created

@AriaXLi looks good, could you change the commit summary to (maint) ...


Add Composer MPT to FasterTransformer Conversion Script

Directly convert a Composer MPT model to the FasterTransformer format, without an intermediate conversion to HuggingFace.
Associated task: CO-2277
The amount of CPU RAM required to run this script is approximately equal to the size of the MPT checkpoint.pt file.
Example:
Command:python convert_composer_mpt_to_ft.py --composer_path=<folder> --ft_save_dir='ft' --infer_gpu_num=1 --output_precision='fp16'
Output:
=============== Argument ===============
composer_path: <folder>
local_checkpoint_save_location: None
ft_save_dir: ft
infer_gpu_num: 1
force: False
output_precision: fp16
========================================
Downloading checkpoint from <folder> -> /tmp/<folder>/local-composer-checkpoint.pt
Loading checkpoint into CPU RAM...
##############################
Extracting HF Tokenizer...
##############################
Saving FasterTransformer config...
##############################
Converting weights to FasterTransformer format...
Working on parameter transformer.blocks.0.attn.Wqkv.weight ...
zero bias for weight: layers.0.attention.query_key_value.weight
...<Many lines of logs>...
Working on parameter transformer.wte.weight ...
##############################
FasterTransformer checkpoint folder successfully created at ft/1-gpu.
Done.
##############################

<TODO: Add image of output comparison>

@nik-mosaic want to merge?


finish Solr and GitHub integration

Initial implementation for auth and installation of the bot/app

https://docs.microsoft.com/en-us/bot-framework/channel-connect-slack

It will be Slack App. We need to implement a website

https://github.com/vcu-swim-lab/HelpMeCode/commit/df27be37408676c8544e154b48bf9055801a2424 takes care of most of this
what has been done:

registered api endpoints and processes for oauth registration of slack and github apps
implemented github/slack services
slack and github 3rd party apps have been created and client ids/secrets prepared on their websites
incoming index page has been created

whats left:

we need to host it somewhere so that we can test integration with slack/github
implement functionality behind slash commands
refactor GitAuth library to integrate with how we obtain access_token through our api
update our index page with information about KnowHows/this slack bot

Here is where are are as of https://github.com/vcu-swim-lab/KnowHows/commit/9485da0d16f72dc11f4e2221f5ecf320756c7be7.
Whats done:

Users can now authorize a channel to index their repositories from their GitHub on a per-channel basis
Once a user has authenticated with GitHub, their repository list is obtained

Whats left:

Need to change GitHub OAuth scope so that we require as little permissions as possible (https://github.com/vcu-swim-lab/KnowHows/blob/master/Website/Controllers/GitHubController.cs#L20)
Discuss user story for deciding which repositories you want indexed in a channel, searching, etc.

add another web page after the GH authentication to select repos

Finished as of https://github.com/vcu-swim-lab/KnowHows/commit/f1aba4ab51e5a75690e4ea6205ff85d8c5c13130


Fix redirection of stdout stream to stderr when using show

When you use show, we want to ensure that nothing goes to stdout except the JSON result of the task shown, so it can easily be piped and parsed and handled by external programs. This was likely broken in https://github.com/com-lihaoyi/mill/pull/2428 which caused the stdout redirection to break, and this PR fixes it (and fixes https://github.com/com-lihaoyi/mill/issues/2680)
The basic problem is that PrintLogger and PrefixLogger are different types, with only PrintLogger supporting withOutputStream but it quickly gets wrapped in PrefixLogger when passed around inside Mill, meaning MainModule.show0 sees that it's not an instance of PrintLogger and skips with withOutputStream.
This fix in this PR is to move withOutputStream to ColorLogger, and implement it in PrefixLogger as well.
Tested manually by via the patch and command below. On main, log.txt contains the COMPILING line in addition to the JSON blob (the bug above), and most of the Scala compiler output just disappears (which is also a bug!), and most of stdout goes to stderr (another bug!). On this PR, the Scala compiler output and COMPILING are both properly shown in the console, while the log.txt file contains only the JSON dictionary {"analysisFile": "...", "classes": "..."} and nothing else
--- a/example/basic/1-simple-scala/build.sc
+++ b/example/basic/1-simple-scala/build.sc
@@ -8,6 +8,11 @@ object foo extends RootModule with ScalaModule {
     ivy"com.lihaoyi::mainargs:0.4.0"
   )

+  def compile = T{
+    println("COMPILING")
+    super.compile()
+  }
+
   object test extends ScalaTests {
     def ivyDeps = Agg(ivy"com.lihaoyi::utest:0.7.11")
     def testFramework = "utest.runner.Framework"

echo // >> example/basic/1-simple-scala/src/Foo.scala && ./mill -i dev.run example/basic/1-simple-scala -i show compile > log.txt

Also updated the unit tests in mill.main.MainModuleTests to assert separately on the contents of stdout and stderr after running show, to ensure that exactly the right things end up in each place. mill.integration.WatchSourceInputTests also needed to be updated to properly assert on the expected stdout/stderr when show is given
There's probably more cleanup we can do w.r.t. ColorLogger/PrintLogger/PrefixLogger, but this PR just fixes the immediate problems for now and leaves better structuring of the Logger class hierarchy for later

The failures in mill.integration.WatchSourceInputTests look like flakes, and these tests are known to be flaky on windows, but they seem pretty stubborn this time. I'm going to disable them


fix: do not return status 200 on server info request when unreachable

When proxying info requests to apm server we're loggin an error if the server is unreachable.
The ErrorHandler should also write a status code back to avoid returning a Status 200.
Add ModifyResponse to log a debug message with the body on unexpected responses and let the ErrorHandler proxy the status code back to the agent.
A StatusBadGateway is returned for generic errors.

/test

Sorry for the late reply. This has been updated!

/test

/test


Waterline or sails-mongo does not catch some MongoDB exceptions

Node version: 16.18.1
Sails version (sails): 1.5.2
ORM hook version (sails-hook-orm): 4.0.1
Sockets hook version (sails-hook-sockets): 2.0.1
Organics hook version (sails-hook-organics): N/A
Grunt hook version (sails-hook-grunt): 5.0.0
Uploads hook version (sails-hook-uploads): N/A
DB adapter & version (e.g. sails-mysql@5.55.5<EMAIL_ADDRESS>Skipper adapter & version (e.g. skipper-s3@5.55.5): N/A

I received the below error message:
You have triggered an unhandledRejection, you may have forgotten to catch a Promise rejection:
AdapterError: Unexpected error from database adapter: not master and slaveOk=false
    at Deferred._.extend._WLModel [as _handleExec] (/home/usera/service-a/source/node_modules/waterline/lib/waterline/methods/update-one.js:161:15)
    at Deferred.exec (/home/usera/service-a/source/node_modules/parley/lib/private/Deferred.js:286:10)
    at Deferred.tryCatcher (/home/usera/service-a/source/node_modules/bluebird/js/release/util.js:11:23)
    at ret (eval at makeNodePromisifiedEval (/home/usera/service-a/source/node_modules/bluebird/js/release/promisify.js:184:12), <anonymous>:14:23)
    at Deferred.toPromise (/home/usera/service-a/source/node_modules/parley/lib/private/Deferred.js:572:19)
    at Deferred.then (/home/usera/service-a/source/node_modules/parley/lib/private/Deferred.js:431:22)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
You have triggered an unhandledRejection, you may have forgotten to catch a Promise rejection:
AdapterError: Unexpected error from database adapter: Primary stepped down while waiting for replication
    at _afterCounting (/home/usera/service-a/source/node_modules/waterline/lib/waterline/methods/update-one.js:191:17)
    at _afterTalkingToAdapter (/home/usera/service-a/source/node_modules/waterline/lib/waterline/methods/count.js:227:16)
    at Object.success (/home/usera/service-a/source/node_modules/sails-mongo/lib/private/do-with-connection.js:254:18)
    at /home/usera/service-a/source/node_modules/machine/lib/private/help-build-machine.js:1517:30
    at proceedToFinalAfterExecLC (/home/usera/service-a/source/node_modules/parley/lib/private/Deferred.js:1185:16)
    at proceedToInterceptsAndChecks (/home/usera/service-a/source/node_modules/parley/lib/private/Deferred.js:913:12)
    at proceedToAfterExecSpinlocks (/home/usera/service-a/source/node_modules/parley/lib/private/Deferred.js:845:10)
    at /home/usera/service-a/source/node_modules/parley/lib/private/Deferred.js:303:7
    at /home/usera/service-a/source/node_modules/machine/lib/private/help-build-machine.js:954:24
    at Function.handlerCbs.success (/home/usera/service-a/source/node_modules/machine/lib/private/help-build-machine.js:814:26)
    at Object.fn (/home/usera/service-a/source/node_modules/sails-mongo/lib/private/machines/release-connection.js:77:18)
    at wrapper (/home/usera/service-a/source/node_modules/@sailshq/lodash/lib/index.js:3282:19)
    at Deferred.parley.retry [as _handleExec] (/home/usera/service-a/source/node_modules/machine/lib/private/help-build-machine.js:1076:19)
    at Deferred.exec (/home/usera/service-a/source/node_modules/parley/lib/private/Deferred.js:286:10)
    at Deferred.switch (/home/usera/service-a/source/node_modules/machine/lib/private/help-build-machine.js:1469:16)
    at /home/usera/service-a/source/node_modules/sails-mongo/lib/private/do-with-connection.js:242:92

Waterline or sails-mongo seems not to catch this exception. So I should wait timeout in this request.
Could you fix it, please?

Hi @anselmo-coolstay, would you be able to share an example of the code where you're seeing this issue?

Sorry, it was my mistake.
My code was like below:
try {
  Inventory.findOrCreate({ date }, inputs).exec(async (err, result, wasCreated) => {
    if (err) {
      ...
    } else if (wasCreated) {
      return exits.success(result);
    }

    return await Inventory.updateOne({ id: result?.id }).set(clonedInputs);
  });
} catch (ex) {
  return exits.error(ex);
}

try - catch statement should be placed inside of findOrCreate callback function, but I placed it outside of findOrCreate function.


update command: progress bar

It would be cool if t2 update showed a progress bar while downloading files.

from https://github.com/tessel/cli/blob/master/bin/tessel-update.js
        var holdUp = setInterval(function(){
          logs.info("...");
        }, 2000);

I was thinking more of something like this: https://github.com/tj/node-progress

yeah, that's even better :P

https://github.com/tessel/t2-cli/pull/281


CSS in the dev vs prod builds

Why doesn't the dev build extract the css in a separate file but the prod does? Just curious.

Well, I just found out the ExtractTextPlugin does not allow Hot Module Replacement, so this answers my question. Sorry!

Bingo. :)

If I try something like:
import 'font-awesome/css/font-awesome.css'

It works fine in dev, however, building in production results to:
ERROR in ./~/font-awesome/css/font-awesome.css
Module parse failed: /Users/../../../node_modules/font-awesome/css/font-awesome.css Unexpected character '@' (7:0)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected character '@' (7:0)
    at Parser.pp.raise (/Users/../../../node_modules/webpack/node_modules/acorn/dist/acorn.js:920:13)
    at Parser.pp.getTokenFromCode (/Users/../../../node_modules/webpack/node_modules/acorn/dist/acorn.js:2813:8)
    at Parser.pp.readToken (/Users/../../../node_modules/webpack/node_modules/acorn/dist/acorn.js:2508:15)
    at Parser.pp.nextToken (/Users/../../../node_modules/webpack/node_modules/acorn/dist/acorn.js:2500:71)
    at Parser.parse (/Users/../../../node_modules/webpack/node_modules/acorn/dist/acorn.js:1615:10)
    at Object.parse (/Users/../../../node_modules/webpack/node_modules/acorn/dist/acorn.js:882:44)
    at Parser.parse (/Users/../../../node_modules/webpack/lib/Parser.js:902:15)
    at DependenciesBlock.<anonymous> (/Users/../../../node_modules/webpack/lib/NormalModule.js:104:16)
    at DependenciesBlock.onModuleBuild (/Users/../../../node_modules/webpack-core/lib/NormalModuleMixin.js:310:10)
    at nextLoader (/Users/../../../node_modules/webpack-core/lib/NormalModuleMixin.js:275:25)
 @ ./src/index.js 19:0-60
Child extract-text-webpack-plugin:
    chunk    {0} extract-text-webpack-plugin-output-filename 178 kB [rendered]
        [0] ./~/css-loader?sourceMap!./~/sass-loader?sourceMap!./src/styles/styles.sass 177 kB {0} [built]
        [1] ./~/css-loader/lib/css-base.js 1.51 kB {0} [built]

I'm not sure what ExtractTextPlugin configuration that makes it work.

@mcchrish Can you please share your repo so I can try to reproduce this?

Hi @coryhouse
Here is the repo: https://github.com/gwillws/react-slingshot/tree/master. It's actually a modified fork from a react-slingshot version a couple months ago so it might not be updated.
On the other hand, using the latest slingshot with font-awesome added, I get this problem:
ERROR in ./~/font-awesome/fonts/fontawesome-webfont.woff?v=4.6.3
Module parse failed: /Users/mcchrish/test/react-slingshot/node_modules/font-awesome/fonts/fontawesome-webfont.woff?v=4.6.3 Unexpected character '' (1:4)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected character '' (1:4)

I can do @import 'font-awesome/css/font-awesome.css'; in src/index.js or @import '~font-awesome/scss/font-awesome.scss'; via scss in styles.scss, it will result to the same error, both dev and prod.
The repo for the above is this https://github.com/mcchrish/react-slingshot/tree/font-awesome

@mcchrish - Get latest. I just committed an update that works with font awesome.

Awesome, it works now 😄
Thanks @coryhouse


[BUG, GoodID, PROD] Loading of claim-page is broken

[BUG, GoodID, PROD] Loading of claim-page is broken
The Claim-page is broken after the second navigation back.
Steps:

navigate to the claim page
go back to the main page
navigate to the claim page again

Actual result:
The endless spinner is shown
https://github.com/user-attachments/assets/3c09935c-d130-4cc5-9b99-e6e752b35c5b

verified on prod


sequentialize + apiThrottler causes errors to slip through and kill the Node process

Hello!
Today, I've encountered a weird behavior when sequentialize is used alongside the apiThrottler.
Run the code below and start to click on the provided menu button as fast as possible. When the requests will start to run very fast the API error (400: Bad Request: message is not modified) will slip through the catch handler and will kill the Node process.
import { Menu } from '@grammyjs/menu';
import { Bot, GrammyError, HttpError } from 'grammy';
import { run, sequentialize } from '@grammyjs/runner';
import { apiThrottler } from '@grammyjs/transformer-throttler';

void (async function main() {

  const bot = new Bot('<token>');

  bot.use(sequentialize(
    context => String(context.chat.id)
  ));

  bot.api.config.use(apiThrottler());

  const menu = (new Menu('my-menu-identifier')
    .text('A', (ctx) => ctx.editMessageText(
      'You pressed A!', { reply_markup: menu })
    )
  );

  bot.use(menu);

  bot.command('start', async (ctx) => {
    // Send the menu:
    await ctx.reply('Check out this menu:', { reply_markup: menu });
  });

  bot.catch((err) => {
    const ctx = err.ctx;
    console.error(`Error while handling update ${ctx.update.update_id}:`);
    const e = err.error;
    if (e instanceof GrammyError) {
      console.error('Error in request:', e.description);
    } else if (e instanceof HttpError) {
      console.error('Could not contact Telegram:', e);
    } else {
      console.error('Unknown error:', e);
    }
  });

  run(bot);

})();

All the code blocks are taken mostly from the documentation directly.

My intuition is that one of the two plugins (probably sequentialize) does not handle errors correctly, and the other one (probably transformer-throttler) causes the issue to appear.

@slavafomin can you also reproduce this without the menu plugin?

My intuition is that one of the two plugins (probably sequentialize) does not handle errors correctly, and the other one (probably transformer-throttler) causes the issue to appear.

Your intuition is correct. The error is reproducible without @grammyjs/transformer-throttler. The offending line appears to be https://github.com/grammyjs/runner/blob/main/src/sequentialize.ts#L68, and it does not seem like transformer-throttler helps or hinders the issue here.
In this line, p.chain could be task from a previous ctx object, and thus, can potentially be rejected/thrown. Attaching a .catch here, resolves the issue.

it does not seem like transformer-throttler helps or hinders the issue here

Strangely, I can reproduce the error only when both plugins are present.

it does not seem like transformer-throttler helps or hinders the issue here

Strangely, I can reproduce the error only when both plugins are present.

import { Menu } from '@grammyjs/menu';
import { Bot, GrammyError, HttpError } from 'grammy';
import { run, sequentialize } from '@grammyjs/runner';

void (async function main() {

  const bot = new Bot('<token>');

  bot.use(sequentialize(
    context => String(context.chat!.id)
  ));

  const menu: any = (new Menu('my-menu-identifier')
    .text('A', (ctx) => ctx.editMessageText(
      'You pressed A!', { reply_markup: menu })
    )
  );

  bot.use(menu);

  bot.command('start', async (ctx) => {
    // Send the menu:
    await ctx.reply('Check out this menu:', { reply_markup: menu });
  });

  bot.catch((err) => {
    const ctx = err.ctx;
    console.error(`Error while handling update ${ctx.update.update_id}:`);
    const e = err.error;
    if (e instanceof GrammyError) {
      console.error('Error in request:', e.description);
    } else if (e instanceof HttpError) {
      console.error('Could not contact Telegram:', e);
    } else {
      console.error('Unknown error:', e);
    }
  });

  run(bot);

})();

✨  Done in 1.56s.
Error while handling update 908291894:
Error in request: Bad Request: message is not modified: specified new message content and reply markup are exactly the same as a current content and reply markup of the message
node:internal/process/promises:246
          triggerUncaughtException(err, true /* fromPromise */);
          ^

GrammyError: Call to 'editMessageText' failed! (400: Bad Request: message is not modified: specified new message content and reply markup are exactly the same as a current content and reply markup of the message)
    at ApiClient.callApi (/grammyjs/grammy-test/node_modules/grammy/out/core/client.js:110:19)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async /grammyjs/grammy-test/node_modules/grammy/out/composer.js:71:13
    at async /grammyjs/grammy-test/node_modules/@grammyjs/menu/out/menu.js:553:17
    at async /grammyjs/grammy-test/node_modules/grammy/out/composer.js:66:9
    at async /grammyjs/grammy-test/node_modules/grammy/out/composer.js:71:13
    at async Promise.all (index 0)
    at async /grammyjs/grammy-test/node_modules/grammy/out/composer.js:71:13
    at async /grammyjs/grammy-test/node_modules/grammy/out/composer.js:66:9
    at async /grammyjs/grammy-test/node_modules/grammy/out/composer.js:66:9 {
  method: 'editMessageText',
  payload: {
    chat_id: 41284431,
    message_id: 4583,
    text: 'You pressed A!',
    reply_markup: {
      inline_keyboard: [
        [
          {
            callback_data: 'my-menu-identifier/0/0//\x00\r)l',
            text: 'A'
          }
        ]
      ]
    }
  },
  ok: false,
  error_code: 400,
  description: 'Bad Request: message is not modified: specified new message content and reply markup are exactly the same as a current content and reply markup of the message',
  parameters: {}
}


cmd/compile,types2: Stack overflow when type parameter and constraint names are the same

What version of Go are you using (go version)?

$ go version
go version go1.18beta1 linux/amd64

Does this issue reproduce with the latest release?
No
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOHOSTARCH="amd64"
GOHOSTOS="linux"

What did you do?
Run go run main.go with the following contents:
package main

type Job interface{}

type Handler[Job Job] struct {}

What did you expect to see?
An error announcing invalid type parameter declaration (?)

This seems to have been fixed on master:
./baz.go:5:18: cannot use a type parameter as constraint

Specifically this was fixed by 7a3a2b18ff3b8591eba18b730da7f84751bbfdc5.


truffle migration doesn't work

I got an error :
Error: No Network specified. can not determine current network.

➤ Dalton L Brady commented:
Also receiving this error, I'll let you know if I solve it.

➤ Dalton L Brady commented:
Alright, I've figured out how to get migrations to function properly. Not sure why the rpc in the truffle.js configuration file was not working properly. But I've commented it out and included a networks reference in it's place here's a link to the my version of the file ( https://gist.github.com/headygains/fd578fdcedc4c33e25a6776025d6e3ab ). Here's the truffle documentation I used to fix the issue ( http://truffleframework.com/tutorials/upgrading-from-truffle-2-to-3#first-things-first-configuration ).
EDIT: run the migration from the project source directory using // truffle migrate --network development
development is what i named my network in the truffle.js configuration file referenced in the Gist above.


Move status-updater logic to controller webhook

Closes #344
Overview

move status-updater argo workflow into the controller-manager
rename the run completion event trigger (client side) from GrpcTrigger to RunCompletionEventTrigger
rename the UpstreamService interface to RunCompletionEventHandler

rename the call function to handle

have the new StatusUpdater implement handle
adjust the RunCompletionFeed constructor to accomodate RunCompletionEventTrigger and StatusUpdater

There are no functional changes introduced.
Tasks

[x] Documentation updated

does this need some integration tests?


removed unneeded "ocp_cloud_dashboard.*" i18n keys

Removed unused -18n keys from "ocp_cloud_dashboard"

Codecov Report

Merging #1748 (7ad2b6f) into master (856486e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1748   +/-   ##
=======================================
  Coverage   77.42%   77.42%
=======================================
  Files         274      274
  Lines        4416     4416
  Branches      859      859
=======================================
  Hits         3419     3419
  Misses        906      906
  Partials       91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856486e...7ad2b6f. Read the comment docs.


Unable to start gazebo

Hi
After installing ASLAN, i pressed 'SD Twizy model' to start the simulation. Gazebo doesn't come up and i get the errors captured in the following images. Could you please help me to resolve the issue? Thanks

Hi Qian,
Please have a look at the vehicle_model package readme here. You are working with Gazebo 7.0 but this model has been tested and is working with Gazebo 7.16.0 for Ubuntu 16.04 and ROS Kinetic. Run gazebo --version to make sure you have the correct version installed.
To update to Gazebo 7.16.0, do:
sudo sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-stable.list'
wget http://packages.osrfoundation.org/gazebo.key -O - | sudo apt-key add -
sudo apt update && sudo apt upgrade


Add some more information around wrapPagesHTML

Motivation
Mention wrapPagesHTML in the section about adding static pages.
Test Plan
Visual
Related PRs
N/A

I am going to merge this in, on the assumption it is correct :)
If not, that's what revert is for :P


Proguard exclusion is too broad

src - https://github.com/openid/OpenYOLO-Android/blob/master/api/proguard-rules.txt
isn't this too broad?
-keep class org.hamcrest.** { *; }

It is, but we also only depend on hamcrest-core rather than the full library, so the impact is fairly small. If you have a suggestion for a narrower keep rule we'd be happy to accept a PR.

This repo is being archived. Closing issue.


chore(main): release 1.7.0

:robot: I have created a release beep boop
1.7.0 (2024-05-09)
Miscellaneous Chores

release 1.7.0 (21ccb2e)
add 2.2 assets (c429d0b)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/X3ne/hsrpc/releases/tag/v1.7.0 :sunflower:


Porting the App to use React?

Wouldn't the app be more robust, easy to scale, and maintainable if we port the current implementation to React? I'll be happy to contribute or formulate a migration plan.

That would be a complete redesign, We need to think about it.

That would be a complete redesign, We need to think about it.


Added on_focus & on_blur callbacks on widget

Allows a user to set widget._on_focus and widget._on_blur for handling those events.

Coverage decreased (-0.05%) to 96.349% when pulling 724e47605a2f1b7d9f09d8c7aeae425bedf2e2c0 on dylanjsa:v1.8 into ce9a7bbd6343e6e8dbed5476b0807b484372edb3 on peterbrittain:master.

Exactly the implemenration I had in mind.  Thanks.  Any chance you could add a test that proves the callbacks work?

Cool! Yep for sure, got some reading to do though.

Thanks.  If you're looking for a quick start on mocking out a Frame with a couple of widgets in it, test_password is a good template.  You can then use the process_keys or process_mouse methods to inject input to make the focus move.

Thanks again for the help, I've created the test case (apologies if the implementation isn't what you expected, I couldn't think of a different way to do it).
It seems to have a conflict. I bet this is because I was working on the v1.8 branch, I had to do this because the master branch wasn't working. (my _on_change callbacks in master were never running).

OK - I've had a go at tidying this up for you.  I've had to create a new pull request in the process.  Have a look at https://github.com/peterbrittain/asciimatics/pull/99 instead of this PR now.

thanks peter


Add option to download all logs from the container

Adding dropdown with 2 options: Download visible logs and Download all logs. Download all logs option will request container logs without any sinceTime or tailLine attributes which allows to download file with the logs from the start.

https://user-images.githubusercontent.com/9607060/182360081-e187df45-9ad5-4d09-92e9-02fa403c6b5d.mov
Fixes https://github.com/lensapp/lens/issues/4803

Made changes to the PR, please review again.
https://user-images.githubusercontent.com/9607060/184640287-6ccb80f7-b3b8-4085-8a06-128155e1f930.mov

Hi!
Don't work on windows 10 machine
when try download - get error
{
"error": {
"kind": "Status",
"apiVersion": "v1",
"metadata": {},
"status": "Failure",
"message": "a container name must be specified for pod 7fb6d7fbfc-lz6mk, choose one of: [A B C]",
"reason": "BadRequest",
"code": 400
},
"messages": [
"a container name must be specified for pod 7fb6d7fbfc-lz6mk, choose one of: [A B C]"
],
"isUsedForNotification": false
}
using latest version


Autogen latency v2 [do not merge]

🔍 Review Summary
Purpose:
Streamline module loading and improve HTTP request performance.
Key Changes:

Enhancement: Relocated autogen check within initialization process for streamlined module loading.
Enhancement: Implemented connection pooling in HTTP client to optimize request performance.
New Feature: Added format_duration function for duration calculation and formatting.
New Feature: Added /autogen_completion endpoint to server with detailed logging and time tracking.

Impact:
Improves system efficiency and functionality by reducing request time, optimizing module loading, and providing detailed logging and time tracking for session operations.
Original Description
No existing description found

Closing until I get this under control


Add topic highlightjs

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

There are over 180 repositories with this topic.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Question: I am hoping to be approved for a repository for my highlight.js grammar. If that were accepted, I would become a maintainer of that specific grammar. As that is not currently the case, I feel ok checking that box. However, if I were to become a maintainer of that grammar, would that prevent me from being able to curate this topic?


[apps/movex-docs] Update the Website Description

Where
apps/movex-docs/theme.config.tsx
What
Change the description in the screenshot below

to: Serverless real-time data sharing infrastructure for front-end developers. Server Authoritative. Secret State. Real Time Multiplayer State Synchronization.
Why
It tells the story a bit better

@GabrielCTroia  Please assign this to me


kubectl fails to show BackupStorageLocation on new velero release

Hi,
I just installed the new Velero v0.11.0
Backups are working, restore is working.  But I noticed I cant get the BackupStorageLocation.  With Ark 0.10.2  I could run the following command and would see the default BackupStorageLocation.  In the Velero release it comes back empty.
You can see the backupstoragelocation is configured and working with #velero backup get.
[root@qtor-kmb01 ~]# kubectl -n velero get BackupStorageLocation
No resources found.
[root@qtor-kmb01 ~]# velero backup get
NAME                           STATUS      CREATED                         EXPIRES   STORAGE LOCATION   SELECTOR
qtor-kmb-full-20190306150033   Completed   2019-03-06 10:00:33 -0500 EST   2d        default
The YAML for the BackupStorageLocation looks like this. (using Swift S3 Bucket)
apiVersion: velero.io/v1
kind: BackupStorageLocation
metadata:
name: default
namespace: velero
spec:
provider: aws
objectStorage:
bucket: qtor-kmb
config:
region: qa
s3ForcePathStyle: "true"
s3Url: https://qa-objectstorage.dev.lprnd.net

Have you removed the old Ark CRD definitions? What do the following show:
kubectl -n velero get backupstoragelocations.velero.io
kubectl get crds

Hi Skriss and thanks for your help.  I've solved the issue based on your advice.  The ark crds were in fact still around.  I removed the ark crds and after a short time the velero backupstoragelocation started showing up in kubectl command.
kubectl -n velero get backupstoragelocations
No resources found.
kubectl -n velero get backupstoragelocations.velero.io
NAME      AGE
default   17h
#kubectl get crds | grep ark
backups.ark.heptio.com                   2019-02-18T14:31:32Z
backupstoragelocations.ark.heptio.com    2019-02-18T14:31:32Z
deletebackuprequests.ark.heptio.com      2019-02-18T14:31:32Z
downloadrequests.ark.heptio.com          2019-02-18T14:31:32Z
podvolumebackups.ark.heptio.com          2019-02-18T14:31:32Z
podvolumerestores.ark.heptio.com         2019-02-18T14:31:32Z
resticrepositories.ark.heptio.com        2019-02-18T14:31:32Z
restores.ark.heptio.com                  2019-02-18T14:31:32Z
schedules.ark.heptio.com                 2019-02-18T14:31:32Z
volumesnapshotlocations.ark.heptio.com   2019-02-18T14:31:32Z
#kubectl get crds | grep ark | awk '{print "kubectl delete crds "$1}'
kubectl delete crds backups.ark.heptio.com
kubectl delete crds backupstoragelocations.ark.heptio.com
kubectl delete crds deletebackuprequests.ark.heptio.com
kubectl delete crds downloadrequests.ark.heptio.com
kubectl delete crds podvolumebackups.ark.heptio.com
kubectl delete crds podvolumerestores.ark.heptio.com
kubectl delete crds resticrepositories.ark.heptio.com
kubectl delete crds restores.ark.heptio.com
kubectl delete crds schedules.ark.heptio.com
kubectl delete crds volumesnapshotlocations.ark.heptio.com
And now I can see it.
kubectl -n velero get backupstoragelocations
NAME      AGE
default   18h


feat: update .env.local based on blog.config.js

if you want to set some env vars, just uncomment them. It will be easier to import to the vercel to use .env file.
But after v4,  just editing the config in the notion maybe a better way.

Thank you for your contribution; it's much appreciated. It's indeed necessary to be able to add configurations promptly in Notion. However, for many crucial configurations that need to be read during the compilation phase, it's still preferable to set them in the code or as environment variables beforehand. Your submission is valuable in addressing this aspect.