POC of handling media errors in media chrome

The first pass is how I'd expect to handle PiP-not-ready errors.
Assume where alert()s happen, it means:

log to the console for the media chrome developer
propagate a [currently undefined] error state that an error display component could use to inform the viewer what's happening

There's a few decisions baked in:

Don't assume the media has the needed APIs to avoid the error (readyState in this case)
When it does have the API, use it, and make viewer-friendly error messaging possible
If the error can't be avoided (e.g. readyState isn't supported), handle known errors triggered by the viewer (InvalidStateError in this case) and make viewer friendly error messaging possible.
Don't silence unknown errors from the media element

Thoughts on all that?

This seems reasonable to me to solve the one off case in a way that also puts some consideration on forward-looking usage. Below are my thoughts for immediate & longer term. tl;dr - For right now, I think this would be 👌 (with one minor callout). However, we may want to consider some of the longer term things, insofar as they would impact the API/expectations. I personally don't think any of them should be blockers for the current (narrower) proposed solution, but wanted visibility on them just in case others disagree.

The first pass is how I'd expect to handle PiP-not-ready errors.
Assume where alert()s happen, it means:

log to the console for the media chrome developer

👍 Let's explicitly say we'll console.error() or console.warn(). I can see arguments for either, so I defer to others on which is better.

propagate a [currently undefined] error state that an error display component could use to inform the viewer what's happening

Should we add an error getter to MediaController, similar to HTMLMediaElement, to avoid any "if a tree falls in the woods and yadda yadda" problems? There would still be things to work out (when to reset, if it should also represent any slotted media.error cases, etc.) if we did want to add it. On the plus side, this would be a step in the right direction for the error dialog support/implementation we have in Mux Player. However, since it would increase the footprint of things to resolve, I don't think this should be a blocker for this first pass (even if it does entail a plausible API change longer term to handle cases + UIs like Mux Player supports).

There's a few decisions baked in:

Don't assume the media has the needed APIs to avoid the error (readyState in this case)

👍 If we're not going to assume media.readState on the slotted media, should we also not assume media.requestPictureInPicture()? If not, should we also provide an error in this case?

When it does have the API, use it, and make viewer-friendly error messaging possible

This is forward more looking, correct? If yes, I think we should

Update the text.
Minimally move it to a constant or better a function to anticipate i18n.

If the error can't be avoided (e.g. readyState isn't supported), handle known errors triggered by the viewer (InvalidStateError in this case) and make viewer friendly error messaging possible.

We may want to consider dispatching an error event (with a potential ErrorEvent if we don't implement an error getter, per above) for both known and unknown errors instead of re-throwing the error. This would allow generic error monitoring from developers without causing an actual crash (though there are some benefits to unexpected crashes). Here again, I don't think this should be a blocker for this effort, but it's food for thought.

Don't silence unknown errors from the media element

👍 agree, either with my proposal under (3) or in the current impl.

Thoughts on all that?

See above. 😄

I like this approach.
@cjpillsbury I would initially hold off on an error handling property and event until it comes up. Is it really needed?
Isn't it quite easy for a developer to disable pointer-events on the MC buttons if the src is not set and media-ready-state is not sufficient. (add media-ready-state as a media-controller attribute?)
For PiP specifically if the src is set I would potentially just go ahead and set preload=auto and call the API once ready state is good. They clearly want to enter PiP if they press that button.

@cjpillsbury I would initially hold off on an error handling property and event until it comes up. Is it really needed?

I wouldn't say it's "needed" and definitely shouldn't block anything here. The only cases it would be handling are ones where a media state receiver is registered after the an error occurs (or is unregistered and then re-registered). This is what I meant by "if a tree falls in the woods" cases. With the exception of the thumbnail/preview attributes (https://github.com/muxinc/media-chrome/blob/main/src/js/media-controller.js#L250-L258), our state is modeled as actual state (see, e.g. https://github.com/muxinc/media-chrome/blob/main/src/js/media-controller.js#L635). This would be modeling errors more like an event. That may be fine for errors specifically, since they're a pretty different beast than other things, and modeling them as state has its own complexities. But it does mean it will behave differently than our other state.

Isn't it quite easy for a developer to disable pointer-events on the MC buttons if the src is not set and media-ready-state is not sufficient. (add media-ready-state as a media-controller attribute?)

Yup this was discussed (or some variation of this). I'm on board with adding additional state for folks to use for CSS selector behavior. Not to put words into @heff's mouth, but I believe his take here is "that's a different problem that maybe we don't need to solve now (or possibly ever)." Whether that's a flesh and blood heff or one hanging out in my imagination, I think that's also right (per his push back to me in the discussion thread here)

For PiP specifically if the src is set I would potentially just go ahead and set preload=auto and call the API once ready state is good. They clearly want to enter PiP if they press that button.

This one actually hadn't come up in our prior discussion, but I like where your head's at. If we can be fairly confident about a user intention (they made a media enter pip request), then we should try to meet that intention (aka start the load for them in this case). Probably a better way to meet that intention would be to use media.load(), but it's the same general idea as you're proposing.

Sounds good, would be a nice stepping stone to have those extra attributes like media-ready-state or similar and make it very easy on the user to disable buttons based on that.
Not sure how it would work if the components are not children of the media-controller though? 🤔

In regard to preloading for PiP video.load() is not the right API for that I believe. If you check the spec it's really a reset of the src. https://html.spec.whatwg.org/multipage/media.html#loading-the-media-resource
Setting video.preload to metadata or auto should be sufficient I think.

console.error() or console.warn()

I don't have a strong opinion here so defer to anyone who does. Are there definitions for those functions that can guide us?

Should we add an error getter to MediaController, similar to HTMLMediaElement, to avoid any "if a tree falls in the woods and yadda yadda" problems?

Yeah, I was imagining that whatever state was propagated to UI components would also be reflected at least as an attribute media controller

There would still be things to work out (when to reset, if it should also represent any slotted media.error cases, etc.)

Definitely. Also, I think the errors we're describing are very different from media errors. At minimum media errors tend to fatal, whereas "video not ready" is more ephemeral. e.g. For a media error I'd expect a big, uncloseable "This video has failed" error message. Clicking the PiP button too soon I'd expect more of a warning, that probably goes away on its own after a few seconds. So more to design there for sure, and if people have examples of that difference being defined well, call them out. My gut is new media-error and media-warning  attributes.

should we also not assume media.requestPictureInPicture()

Yep. 👍 I added a check and error for it. And that obviously has implications for media element functions.

This is forward more looking, correct? If yes, I think we should
Update the text.
Minimally move it to a constant or better a function to anticipate i18n.

Yeah, all the text is just for POC purposes. All that sounds good.

We may want to consider dispatching an error event ... instead of re-throwing the error

Definitely don't want to cause unhelpful crashes. What's the discoverability of an error event? Would it still show up in the console?

For PiP specifically if the src is set I would potentially just go ahead and set preload=auto

I like this general design direction. It's similar to this old note I just remembered, which addresses the ready state and seeking issue called out in the other discussion. Framed as a principle might be: "When necessary and possible, take the extra steps to achieve the user's intent for an action/request, in cases where the media element API adds additional, unnecessary friction."

Cleaned up the POC to make it ready to merge if approved, removing forward looking things.
Added an attempt to load the video if it just wasn't ready for PiP. Didn't work in Safari because it denied triggering PiP in an event listener.

I think this could be merged now if there's no other followup comments.

FYI, this PR didn't get merged with a conventional changelog commit, so, it'll end up missing from the generated docs.


Interface name should start with "I"

As we will be using many interfaces, we should follow this practice for interface name that it should start with I. for example ILoginView, ILoginPresenter.

Agree, please send pull request

@iamareebjamal sending.

Also please change the implementation to LoginView for ILoginView interface


Why 'webapp' template name has been used in the Doc while it is not available in "dotnet new -l" command output?

Issue description
In Microsoft Doc for ASP.NET Core, to creating a web app,  'webapp' template name has been used as fallow :
dotnet new webapp

But when I use following command for listing available template names, "webapp" is not available:
dotnet new -l

command output
Usage: new [options]

Options:
  -h, --help          Displays help for this command.
  -l, --list          Lists templates containing the specified name. If no name is specified, lists all templates.
  -n, --name          The name for the output being created. If no name is specified, the name of the current directory is used.
  -o, --output        Location to place the generated output.
  -i, --install       Installs a source or a template pack.
  -u, --uninstall     Uninstalls a source or a template pack.
  --nuget-source      Specifies a NuGet source to use during install.
  --type              Filters templates based on available types. Predefined values are "project", "item" or "other".
  --force             Forces content to be generated even if it would change existing files.
  -lang, --language   Filters templates based on language and specifies the language of the template to create.

Templates                                         Short Name         Language          Tags
----------------------------------------------------------------------------------------------------------------------------
Console Application                               console            [C#], F#, VB      Common/Console
Class library                                     classlib           [C#], F#, VB      Common/Library
Unit Test Project                                 mstest             [C#], F#, VB      Test/MSTest
NUnit 3 Test Project                              nunit              [C#], F#, VB      Test/NUnit
NUnit 3 Test Item                                 nunit-test         [C#], F#, VB      Test/NUnit
xUnit Test Project                                xunit              [C#], F#, VB      Test/xUnit
Razor Page                                        page               [C#]              Web/ASP.NET
MVC ViewImports                                   viewimports        [C#]              Web/ASP.NET
MVC ViewStart                                     viewstart          [C#]              Web/ASP.NET
ASP.NET Core Empty                                web                [C#], F#          Web/Empty
ASP.NET Core Web App (Model-View-Controller)      mvc                [C#], F#          Web/MVC
ASP.NET Core Web App                              razor              [C#]              Web/MVC/Razor Pages
ASP.NET Core with Angular                         angular            [C#]              Web/MVC/SPA
ASP.NET Core with React.js                        react              [C#]              Web/MVC/SPA
ASP.NET Core with React.js and Redux              reactredux         [C#]              Web/MVC/SPA
Razor Class Library                               razorclasslib      [C#]              Web/Razor/Library/Razor Class Library
ASP.NET Core Web API                              webapi             [C#], F#          Web/WebAPI
global.json file                                  globaljson                           Config
NuGet Config                                      nugetconfig                          Config
Web Config                                        webconfig                            Config
Solution File                                     sln                                  Solution

.NET Core SDK Version
2.1.403
My question is, why 'webapp' template name has been used in the Doc while it is not available in the above command output?

According to this PR that added webapp to the docs, there's a bug on the CLI that only lists the first value:
https://github.com/dotnet/docs/pull/8613
@KathleenDollard @livarcocc is this issue already tracked somewhere?

Ok, thanks @livarcocc. I've moved this one with ZenHub.


Documentation : Left menu does not display all topics all the time. It depends on the details section.

Was going through the documentation.
The left menu shows up the topic only to an extent to which the details section shows up in length.
If the details section is small, the menu content to the left does not scroll to the the last topic.
Only if the details content is very long, all the menu items shows up.
This link:
https://identityserver4.readthedocs.io/en/release/topics/resource_owner.html
shows upto "Adding a JavaScriptClient" and then cannot scroll.
And the link:
https://identityserver4.readthedocs.io/en/release/topics/extension_grants.html
shows the full menu content in the left because the content is long and scrollable.

What browser are you using, works fine here! The LHS menu is in its own scrollable container -- mouse over it to scroll.

Using Edge and Chrome. Oh! Ok! Not so smooth with laptop touchpad.  I don't use mouse. Thanks.


Doesnt work

Really wish this plug in worked. Exactly what Im looking for. Nothing happens...

Just tested on Sketch 41.2, macOS 10.12.2 and everything seems to be working.

Are your text layers using the correct font? (SF UI Text for < 20pt, SF UI Display for >= 20 pt). Using SF UI Text on a layer which is greater than 20 points won't switch it over. Although maybe its a good idea for me to add a check for that and maybe swap the font through the plugin.
Are your San Francisco fonts official (download here). If they are not, chances are they don't have the proper font postscript name that the plugin is checking for

Hey Kyle
Yes latest correct sf font downloaded from apple developer site. Im aware of the 20 pt. I also re downloaded the plug in and sketch is updated.
Ill try removing and reinstalling tomorrow
Thanks
James
. .: ::iPhone

On Jan 5, 2017, at 7:55 PM, Kyle Hickinson<EMAIL_ADDRESS>wrote:
Just tested on Sketch 41.2, macOS 10.12.2 and everything seems to be working.
Are your text layers using the correct font? (SF UI Text for < 20pt, SF UI Display for >= 20 pt). Using SF UI Text on a layer which is greater than 20 points won't switch it over. Although maybe its a good idea for me to add a check for that and maybe swap the font through the plugin.
Are your San Francisco fonts official (download here). If they are not, chances are they don't have the proper font postscript name that the plugin is checking for
―
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Also note that when you do activate the plugin, the selected text layer character spacing will change but not update the inspector.  If you de-select and re-select then it will show the updated value.


Renaming the library

There has been some justified criticism about the name of the library
https://www.reddit.com/r/csharp/comments/cpji2i/redsharper_a_library_for_executing_c_on_redis/
Need suggestions for new names

RedSharp (by u/decPL)

FluentRedis (by u/BusinessBro7)

RediC# (by u/readmond)

RedSharper (keeping the name)

RediSharp

RediSharp


refactor(autoware_launch): use autoware.launch.xml in planning/logging_simulator.launch.xml

Signed-off-by: Takayuki Murooka<EMAIL_ADDRESS>Description
use autoware.launch.xml in planning_simulator.launch.xml and logging_simulator.launch.xml
logging simulator (by changing map, system, sensing, ..., arguments true or false) and planning simulator works well with this PR

Related links
https://github.com/autowarefoundation/autoware_launch/issues/60

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Thank you! I'll review later :pray:

I'll wait for @kenji-miyake-san's comment and then check this PR works well.


Downloadling audio files (m4a, mp3) from google drive

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.09.24 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
I'm using the following python code to download audio files (with m4a and mp3 formats) from google drive:
FILE_URL = "https://drive.google.com/file/d/1Il5LrGlp_iWFNhtgrD449tDUeFuuBWMh/view?usp=sharing"
ydl_opts = {
    'format': 'bestaudio/best',
    'postprocessors': [{
        'key': 'FFmpegExtractAudio',
        'preferredcodec': 'm4a',
    }],
    'quiet': False,
    'verbose': True,
    'outtmpl': '/tmp/%(id)s.%(ext)s',
}

with yt_dlp.YoutubeDL(ydl_opts) as ydl:
    error_code = ydl.download(FILE_URL)

Strangely, when I try a link for the first time, they are downloaded without any issues, but when I try to download the same file using the same URL again (e.g. when I'm changing other parts of my code and I'm in the process of developing my script) I can't download the files and I get the following error (for m4a file):

[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out UTF-8 (No ANSI), error UTF-8 (No ANSI), screen UTF-8 (No ANSI)
[debug] yt-dlp version<EMAIL_ADDRESS>[088add956] (pip) API
[debug] params: {'format': 'bestaudio/best', 'postprocessors': [{'key': 'FFmpegExtractAudio', 'preferredcodec': 'm4a'}], 'quiet': False, 'verbose': True, 'outtmpl': '/tmp/%(id)s.%(ext)s', 'compat_opts': set(), 'http_headers': {'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.77 Safari/537.36', 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,/;q=0.8', 'Accept-Language': 'en-us,en;q=0.5', 'Sec-Fetch-Mode': 'navigate'}}
[debug] Python 3.9.17 (CPython arm64 64bit) - macOS-13.5.1-arm64-arm-64bit (OpenSSL 3.1.2 1 Aug 2023)
[debug] exe versions: ffmpeg 6.0 (setts), ffprobe 6.0
[debug] Optional libraries: Cryptodome-3.19.0, brotli-1.1.0, certifi-2021.10.08, mutagen-1.47.0, sqlite3-3.42.0, websockets-11.0.3
[debug] Proxy map: {}
[debug] Loaded 1886 extractors

[GoogleDrive] Extracting URL: https://drive.google.com/file/d/1Il5LrGlp_iWFNhtgrD449tDUeFuuBWMh/view?usp=sharing
[GoogleDrive] 1Il5LrGlp_iWFNhtgrD449tDUeFuuBWMh: Downloading video webpage

ERROR: 1Il5LrGlp_iWFNhtgrD449tDUeFuuBWMh: An extractor error has occurred. (caused by KeyError('50')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
File "/opt/homebrew/lib/python3.9/site-packages/yt_dlp/extractor/common.py", line 715, in extract
ie_result = self._real_extract(url)
File "/opt/homebrew/lib/python3.9/site-packages/yt_dlp/extractor/googledrive.py", line 197, in _real_extract
'ext': self._FORMATS_EXT[format_id],
KeyError: '50'

And almost the same error with KeyError: '140' for mp3 files. I looked into the google drive extractor part of the code, and the answer to my question probably is "yt-dlp doesn't support downloading audio files from google drive", but since it is able to download them sometimes, I thought I'm missing something probably.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
(pasted in the question above)

seems like we just need to add IDs for audio file extensions, something like this:
diff --git a/yt_dlp/extractor/googledrive.py b/yt_dlp/extractor/googledrive.py
index 2fdec20f6..b51a2fa1a 100644
--- a/yt_dlp/extractor/googledrive.py
+++ b/yt_dlp/extractor/googledrive.py
@@ -70,7 +70,9 @@ class GoogleDriveIE(InfoExtractor):
         '44': 'webm',
         '45': 'webm',
         '46': 'webm',
+        '50'; 'm4a',
         '59': 'mp4',
+        '140': 'mp3',
     }
     _BASE_URL_CAPTIONS = 'https://drive.google.com/timedtext'
     _CAPTIONS_ENTRY_TAG = {

Yeah exactly. I was wondering if this is an intentional choice (for some technical reasons) to not allow downloading audio files from google drive or not.

IMO yt-dlp shouldn't fail completely if a format extension isn't known
I'm not that familiar with the gdrive extractor though

I've got the same error with an m4a error :
# ./yt-dlp_linux --version
2<IP_ADDRESS>053

I anonymize the URL because it's note mine.
./yt-dlp_linux -v "https://drive.google.com/file/d/1P3ZwdrIDp7z6g8cAd4NgkdXXX/view"
[debug] Command-line config: ['-v', 'https://drive.google.com/file/d/1P3ZwdrIDp7z6g8cAd4NgkdlvdXXX/view']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-master-builds [ff0779267] (linux_exe)
[debug] Python 3.10.14 (CPython x86_64 64bit) - Linux-5.15.0-101-generic-x86_64-with-glibc2.35 (OpenSSL 3.2.1 30 Jan 2024, glibc 2.35)
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.19.0, brotli-1.1.0, certifi-2024.02.02, mutagen-1.47.0, requests-2.31.0, secretstorage-3.3.3, sqlite3-3.45.2, urllib3-2.2.1, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1810 extractors
[GoogleDrive] Extracting URL: https://drive.google.com/file/d/1P3ZwdrIDp7z6g8cAd4NgkdlvdXXX/view
[GoogleDrive] 1P3ZwdrIDp7z6g8cAd4Ngkdlvd5ZTT8b5: Downloading video webpage
ERROR: 1P3ZwdrIDp7z6g8cAd4NgkdlvdXXX: An extractor error has occurred. (caused by KeyError('50')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp/extractor/common.py", line 734, in extract
  File "yt_dlp/extractor/googledrive.py", line 200, in _real_extract
KeyError: '50'

$ file XXX.m4a
XXX.m4a: ISO Media, Apple iTunes ALAC/AAC-LC (.M4A) Audio

None of the posted URLs work anymore. Someone needs to provide working URLs for this to be fixed

Very strange.
I upload a personal file on a drive, and it works fine :
/yt-dlp_linux -v https://drive.google.com/file/d/1ShMdrxXiRyzKHnkvQtTpC9POqWxdoZM9/view
[debug] Command-line config: ['-v', 'https://drive.google.com/file/d/1ShMdrxXiRyzKHnkvQtTpC9POqWxdoZM9/view']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-master-builds [ff0779267] (linux_exe)
[debug] Python 3.10.14 (CPython x86_64 64bit) - Linux-5.15.0-101-generic-x86_64-with-glibc2.35 (OpenSSL 3.2.1 30 Jan 2024, glibc 2.35)
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.19.0, brotli-1.1.0, certifi-2024.02.02, mutagen-1.47.0, requests-2.31.0, secretstorage-3.3.3, sqlite3-3.45.2, urllib3-2.2.1, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1810 extractors
[GoogleDrive] Extracting URL: https://drive.google.com/file/d/1ShMdrxXiRyzKHnkvQtTpC9POqWxdoZM9/view
[GoogleDrive] 1ShMdrxXiRyzKHnkvQtTpC9POqWxdoZM9: Downloading video webpage
[GoogleDrive] 1ShMdrxXiRyzKHnkvQtTpC9POqWxdoZM9: Requesting source file
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec:vp9.2(10), channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] 1ShMdrxXiRyzKHnkvQtTpC9POqWxdoZM9: Downloading 1 format(s): source
[debug] Invoking http downloader on "https://drive.usercontent.google.com/download?id=1ShMdrxXiRyzKHnkvQtTpC9POqWxdoZM9&export=download&confirm=t"
[download] Destination: mix_audio.m4a [1ShMdrxXiRyzKHnkvQtTpC9POqWxdoZM9].m4a
[download] 100% of   14.65MiB in 00:00:01 at 9.81MiB/s

I cannot send the real URL because the file is not mine, and contents personal data.


Processing emails with big attachments

What have done:

Moved topic suffix into settings.
Added ability to process big emails.
Done refactorings and added specs.

The main point of this pull request
By default SNS is able to process email with size less or equal 150Kb (the size is calculated with images, headers, text body). To be able to accept emails with big images you must to setup flow, when email body is uploaded to the S3 and to the server the information where to find that email content will be posted. So the flow for such cases will be a little different: there is no content in the payload, you must to read it from S3 file instead. Flow with S3 has own limitations: your email can has maximum size 30Mb.

Any thoughts on approving this as a merge?


Remove Full Scale Escalation, add individual upgrades for air units that required it, make navigation an upgrade

Todo: Add individual air upgrades


Add grid parallel two-qubit XEB

This separates data collection and data analysis using idioms suggested by @mpharrigan (though note Matt that my definitions of save and load differ from the ones we've been using internally).

pytest-cov seems unable to tell that code used by a multiprocessing pool is actually covered.

You can use # coverage: ignore (with the rationale in a comment) to disable coverage check.


[SPARK-42675][CONNECT][TESTS] Drop temp view after test test temp view

What changes were proposed in this pull request?
This pr just drop temp view after test which create by test temp view in ClientE2ETestSuite.
Why are the changes needed?
Drop temp view after test to clean up resource.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions

Merged to master and branch-3.4.

Thanks @wangyum


feat: Wheres My Gene Prototype

Reviewers
Merging Where's My Gene prototype into main, so we can conduct UXR with external users 🧪 🔍 ❤
All the Where's My Gene stuff is under URL domain.org/wmg, so it shouldn't affect the rest of the site, including the bundle size due to route wise code splitting
The code is in prototype quality, so no need to review thoroughly right now. We'll spend the first a few weeks of Q1 to get it to production quality before we roll out v1!
PTAL thank you!

Amazing thanks so much, Andrew!!


[Event Request] Database::"Item Journal Line" - Function TrackingExists - OnBeforeTrackingExists

We like to request the following Event:
Object: Database::"Item Journal Line"
Function: TrackingExists
Publisher Event: OnBeforeTrackingExists
Reason: To implement custom business logic
Where is the event placed:
procedure TrackingExists(): Boolean
var
IsTrackingExist: Boolean;
IsHandled: Boolean;
begin
IsHandled := false;
OnBeforeTrackingExists(Rec, IsTrackingExist, IsHandled);
if IsHandled then
exit(IsTrackingExist);
IsTrackingExist := ("Serial No." <> '') or ("Lot No." <> '');
exit(IsTrackingExist);
end;
Event Code:
[IntegrationEvent(false, false)]
local procedure OnBeforeTrackingExists(var ItemJournalLine: Record "Item Journal Line"; var IsTrackingExist: Boolean; var IsHandled: Boolean)
begin
end;

Hi @acadonAG-dev . There is already OnAfterTrackingExists(Rec, IsTrackingExist) event where you can update IsTrackingExist as you need.
procedure TrackingExists() IsTrackingExist: Boolean
begin
    IsTrackingExist := ("Serial No." <> '') or ("Lot No." <> '');

    OnAfterTrackingExists(Rec, IsTrackingExist);
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Make plants a package

The idea is to use astros new content layer to move the collection with the plant data to its own npm package so others can reuse it. Lets see if that is possible.

It worked. I did not setup transpilation to js yet.


Target size of  Send(22X22) and more(16X22) buttons available under copilot chat sendbox is less than required size 24x24pixel: A11y_VS Code_Copilot Chat_Target Size

GitHub Tags:
#A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #SH_WCAG2.2_Visual Studio Code Client_Win32_April2024; #Visual Studio Code Client; #Win32; #Win11; #WCAG2.5.8; #FTP; #A11yWCAG2.2; #TargetSize;
Environment and OS details:
Version: 1.92.0-insider (user setup)
Windows 11 pro Version 23H2
OS Build: 22631.3672
Repro Steps:

Open Visual Studio Code Insiders editor.
Tab till Copilot chat and press enter.
Tab till copilot chat send  box.
Observed that Target size of Send(22X22) and more(16X22) buttons available under copilot chat send box is less than required size 24x24pixel

Actual Result:
Target size of Send(22X22) and more(16X22) buttons available under copilot chat send box is less than required size 24x24pixel
Expected Result:
Target size of Send and more buttons available under copilot chat send box is less than required size 24x24pixel should be minimum 24x24pixel. If the controls have spaced in-between, then those spaces should not intersect each other and target size with spacing should be 24x24 pixel for each one.
User Impact:
Users with dexterity limitations and those who have difficulty with fine motor movement find it difficult to accurately activate small targets when there are other targets that are too close. Providing sufficient size, or sufficient spacing between targets, will reduce the likelihood of accidentally activating the wrong control.
Attachment:
https://github.com/user-attachments/assets/96040418-1d89-42e3-9e3f-41aabde064b8
Ruler Attachment:
https://github.com/user-attachments/assets/0c83cfac-de30-4ae5-9d5c-e58bf84dfb83

I don't understand- the chat send button is larger than most menu buttons in vscode which are 16x16, are those not a problem?


❤ your screenshot!!

You've made my day already!
Thank you for posting a screenshot here.
I like the look of your GUI and found your code super easy to read.
If in the future, you want to be "lazier", you can save a little space.  I hesitate to even mention it because you've done such a wonderful job in your layout section.
Anyway... here's some tricks to save you time maybe.  Again, no complaints about what I see. I love it!

Text elements defauilt to "" so no need to specify anything if it's initially blank
For text and some other elements, you can use a size that's just an int if the height is 1. size=60 is same as size=(60,1)
Keywords size and key could be hacked to smaller alias of k and s, but it does make code much less readable
InputText can be Input or like you did with Buttons where you used B and Text used T, you can use I for Input
There's a threading call built in window.start_thread that I have started to use with only 2 parms (a lambda that looks like a call to your thread function, and a key should the thread exit).  For me, I like the simple look.  It sets daemon=True for you and starts the thread.  Sorry, probably going too far in recommendations :-)

Thanks for using PySimpleGUI, posting a screenshot, and I hope you've enjoyed the process.  Great way to start my day!

Thank you for your feedback and suggestions.

You're quite welcome... thank you for the AWESOME program!   I was really excited when I saw your screenshot.  My suggestions were all minor things.... they took up a lot of space, but don't have a big impact overall.  They're more tips and tricks.
Thank you again for starting my day off with a big smile.  Was really enjoyable.


feat(minimap): add maskBorderRadius prop

🚀 What's changed?

Added the optional option for a mask border radius on the minimap

Default is still 0 as before.

Thanks for the PR :)
I'll give it a look soon 👍

Released with<EMAIL_ADDRESS>


Cannot read property 'flags' of undefined

Been dealing with this for months, please fix.
./src/app/auth/auth.manager.ts
Module build failed: TypeError: Cannot read property 'flags' of undefined
    at resolveAlias (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:28064:36)
    at checkAliasSymbol (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46447:26)
    at checkImportBinding (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46477:13)
    at Object.forEach (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:1506:30)
    at checkImportDeclaration (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46498:32)
    at checkSourceElement (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46789:28)
    at Object.forEach (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:1506:30)
    at checkSourceFileWorker (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46862:20)
    at checkSourceFile (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46842:13)
    at getDiagnosticsWorker (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46906:17)
    at getDiagnostics (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:46892:24)
    at Object.getEmitResolver (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:27162:13)
    at C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:70021:69
    at runWithCancellationToken (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:69779:24)
    at getDeclarationDiagnosticsForFileNoCache (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:70020:20)
    at getAndCacheDiagnostics (C:\Users\brian.cullinan\Documents\portal\node_modules\typescript\lib\typescript.js:70033:26)
 @ ./src/app/core/core.module.ts 19:0-51
 @ ./src/app/app.module.ts
 @ ./src/main.ts
 @ multi webpack-dev-server/client?http://localhost:9090 ./src/main.ts

what version are you seeing this on? have you tried on typescript@next? what is the source code that is causing this issue to happen?

I wish I knew!!  I promise I would provide more if I knew more.  I'll try
"@next" tomorrow, no sweat.  Is there a way to get to compiler to print out
more information about the code it's working on?  This could be way after
tokenizing and syntax checking so I don't know.  I have been seeing this
for months, it happens only using HRM (already set timeout to 2 seconds so
it's not an file-system race condition).  I feel like something changed in
my code style-wise and it started appearing.  Missing @Component{
styleUrls: [] } maybe?
On Thu, Oct 12, 2017 at 5:23 PM, Mohamed Hegazy<EMAIL_ADDRESS>wrote:

what version are you seeing this on? have you tried on typescript@next?
what is the source code that is causing this issue to happen?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/19142#issuecomment-336316528,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX5Xbob0PNbEhm5ZODo5jIbUomh6P1wQks5srq1vgaJpZM4P3qob
.

--
CONFIDENTIALITY NOTICE: The contents of this email message and any
attachments are intended solely for the addressee(s) and may contain
confidential and/or privileged information and may be legally protected
from disclosure. It is then shared with tech companies, bots, hackers,
government agencies, and marketers.  The security of this message is none,
and it may be shared on Instagram at anytime.  If you are OK with this,
please respond.  There isn't really any security or privacy anywhere.  If
you disagree you may want to go camping and talk to people face-to-face
like in old times.

We would be happy to sign any required NDA to get access to the code. you can also email me directly a sample that reproduces the issue on my github username @microsoft.com.

@philipmward Finally got some fresh eyes on this issue I've seen in the compiler for months.  No way to tell which code is causing it but I feel like there is some syntax or directive that is formatted wrong.  Can we get Microsoft temporary access or a zip of the APC branch?

You can email me the zip file.

You can also launch the compiler under node inspector, assuming you have node v7 or later
node --inspect --debug-brk node_modules\typescript\lib\tsc.js --p <path to your tsconfig.json>

in your chrome go to chrome://inspect.  let the process run, when it breaks, there should be getSemanticDiagnosticsForFileNoCache on the stack. Look up the value of sourceFile.fileName in your watch window, this should tell you which file is causing the issue. you can also dump the diagnostic object that is the argument of the function.

Hmm, I am not sure how to do that from within the angular-cli serve
command, but --inspect is definitely an interesting flag.
On Mon, Oct 16, 2017 at 9:14 AM, Mohamed Hegazy<EMAIL_ADDRESS>wrote:

You can also launch the compiler under node inspector, assuming you have
node v7 or later
node --inspect --debug-brk node_modules\typescript\lib\tsc.js --p
in your chrome go to chrome://inspect. let the process run, when it
breaks, there should be getSemanticDiagnosticsForFileNoCache on the
stack. Look up the value of sourceFile.fileName in your watch window,
this should tell you which file is causing the issue. you can also dump the
diagnostic object that is the argument of the function.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/19142#issuecomment-336937384,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX5Xbjv9j22GCSvGtb4nwrrejxnZXHWZks5ss4D7gaJpZM4P3qob
.

--
CONFIDENTIALITY NOTICE: The contents of this email message and any
attachments are intended solely for the addressee(s) and may contain
confidential and/or privileged information and may be legally protected
from disclosure. It is then shared with tech companies, bots, hackers,
government agencies, and marketers.  The security of this message is none,
and it may be shared on Instagram at anytime.  If you are OK with this,
please respond.  There isn't really any security or privacy anywhere.  If
you disagree you may want to go camping and talk to people face-to-face
like in old times.

Any ideas @filipesilva ?

@megamindbrian this looks like a bug with one of the transforms we use in Angular CLI. Impossible to tell what's happening just from the log though. Can you open an issue on https://github.com/angular/angular-cli and include a reproduction of what I can do to see the error myself?
Meanwhile if you want to inspect the error you can use the following command: node --inspect --debug-brk ./node_modules/@angular/cli/bin/ng serve --no-progress.

Perfect, thank you!

Cool, just got it to fail in the debugger.  Looks like if you are editing a file in watch mode, and you create something invalid like <new line> alert with no semi-colon.  Save.  Edit, and remove the line alert.
Watch never recovers from errors and just displays this flags error.

Awesome, that's definitely not intended. Please include that reproduction in the CLI issue, together with the other details. Angular and TS versions are especially important because we use different pipeline depending on those.

I got it to break in the typescript compiler on an Injectable token, but I am not sure what file or anything unusual that is causing it:

I'll probably hunt around a bit and then try some different versions.  Thank you for the good starting point!

@megamindbrian running ts.getTextOfNode(node) ts.getTextOfNode(node.parent) at that point in the debugger's console window should tell you the offending node

(You can keep adding .parent until the entire node context becomes obvios)

@RyanCavanaugh Yeah, I dropped down to getDiagnostics(), and it was just the same file that I edited erroneously.  Maybe watch doesn't recover on Injectables because there is no configuration options?  Injectable() takes 0 arguments?  I am trying typescript@next now.  I haven't updated Angular 4 in a while (~ a least a month) either.

Confirmed this Module build failed: TypeError: Cannot read property 'flags' of undefined
error only occurs (for me) when a mistake is made in an Injectable, and then corrected.  Watch mode doesn't recover.

can you get us a small sample that makes it crash?

I was on my way to doing just that, but setting up a new project the error
goes away.  Line numbers with the invalid line work just fine.  This is
using typescript@next with angular 4.4.0.  Trying to upgrade my current
project to angular 4.4 to see if it still happens.
On Mon, Oct 16, 2017 at 11:33 AM, Mohamed Hegazy<EMAIL_ADDRESS>wrote:

can you get us a small sample that makes it crash?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/19142#issuecomment-336985899,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX5XbqSeGe0t71a4-2cjUjCgm0dLo0Tjks5ss6FfgaJpZM4P3qob
.

--
CONFIDENTIALITY NOTICE: The contents of this email message and any
attachments are intended solely for the addressee(s) and may contain
confidential and/or privileged information and may be legally protected
from disclosure. It is then shared with tech companies, bots, hackers,
government agencies, and marketers.  The security of this message is none,
and it may be shared on Instagram at anytime.  If you are OK with this,
please respond.  There isn't really any security or privacy anywhere.  If
you disagree you may want to go camping and talk to people face-to-face
like in old times.

Been debugging the entire code base with no errors using Typescript
"^>=2.1.0 <2.4.0" and Angular 4.4.5 no "flags" error.
On Mon, Oct 16, 2017 at 11:46 AM, Brian Cullinan<EMAIL_ADDRESS>wrote:

I was on my way to doing just that, but setting up a new project the error
goes away.  Line numbers with the invalid line work just fine.  This is
using typescript@next with angular 4.4.0.  Trying to upgrade my current
project to angular 4.4 to see if it still happens.
On Mon, Oct 16, 2017 at 11:33 AM, Mohamed Hegazy<EMAIL_ADDRESS>
wrote:

can you get us a small sample that makes it crash?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/TypeScript/issues/19142#issuecomment-336985899,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX5XbqSeGe0t71a4-2cjUjCgm0dLo0Tjks5ss6FfgaJpZM4P3qob
.

--
CONFIDENTIALITY NOTICE: The contents of this email message and any
attachments are intended solely for the addressee(s) and may contain
confidential and/or privileged information and may be legally protected
from disclosure. It is then shared with tech companies, bots, hackers,
government agencies, and marketers.  The security of this message is none,
and it may be shared on Instagram at anytime.  If you are OK with this,
please respond.  There isn't really any security or privacy anywhere.  If
you disagree you may want to go camping and talk to people face-to-face
like in old times.

--
CONFIDENTIALITY NOTICE: The contents of this email message and any
attachments are intended solely for the addressee(s) and may contain
confidential and/or privileged information and may be legally protected
from disclosure. It is then shared with tech companies, bots, hackers,
government agencies, and marketers.  The security of this message is none,
and it may be shared on Instagram at anytime.  If you are OK with this,
please respond.  There isn't really any security or privacy anywhere.  If
you disagree you may want to go camping and talk to people face-to-face
like in old times.

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

As megamindbrian's last comment suggests, switching TypeScript versions may be enough to fix the issue. I had it with TS 2.4. It went away after switching to TS 2.6.


Code cleanup- remove unused vars and update search html

This pull request fixes 31 alerts when merging e497b7f6b666c776acac276ed9fb5b2a608c41c5 into b54b4064d3d57e7907826f7edc20923524b6d4f2 - view on LGTM.com
fixed alerts:

29 for Unused variable
2 for Ambiguous HTML id attribute

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 31 when merging 4aa2a28294e44332a8d96b5436eacbfdd3c0c6d3 into b54b4064d3d57e7907826f7edc20923524b6d4f2 - view on LGTM.com
new alerts:

1 for Unused variable

fixed alerts:

29 for Unused variable
2 for Ambiguous HTML id attribute

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 31 when merging 94e051cf7103836c31b046286e17d24dc032e543 into b54b4064d3d57e7907826f7edc20923524b6d4f2 - view on LGTM.com
new alerts:

1 for Unused variable

fixed alerts:

29 for Unused variable
2 for Ambiguous HTML id attribute

Comment posted by LGTM.com

This pull request fixes 31 alerts when merging 74a9ca2ea579228dd487a0d23a2f9df682bd6e2e into b54b4064d3d57e7907826f7edc20923524b6d4f2 - view on LGTM.com
fixed alerts:

29 for Unused variable
2 for Ambiguous HTML id attribute

Comment posted by LGTM.com

This pull request fixes 31 alerts when merging e8552635c19e0e77e540d62bc12e3e7117b623a3 into b54b4064d3d57e7907826f7edc20923524b6d4f2 - view on LGTM.com
fixed alerts:

29 for Unused variable
2 for Ambiguous HTML id attribute

Comment posted by LGTM.com


Chapters not marked as read on updates tab

Steps to reproduce

Read chapter from updates tab
Don't leave updates tab after finishing chapter
Chapter is not marked as read until you navigate to another tab then back

Expected behavior
Chapter should be marked as read shortly after exiting the reader
Actual behavior
Chapter is not marked as read until you switch tabs then go back to updates tab
Crash logs
No response
Tachiyomi version
Preview r457
Android version
Android 12
Device
Google Pixel 3a XL
Other details
When trying to bookmark a chapter that hasn't been marked read, it will be bookmarked as usual, but permanently remain unread even after re-navigating to updates page
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version 1.8.3.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

This is the effect of gradually migrating to a new database framework. So nothing I can do until main Tachi finishes the migration.


Ability to specify base path in Kapacitor 1.6

Document new parameter in the Kapacitor CLI to support customizing a path not at the root domain. This is useful when using a reverse proxy to mount services and each microservice is mounted in a sub path rather than the root of the domain.
https://docs.influxdata.com/kapacitor/v1.6/working/cli_client/#-url

This is now for 1.6.1

As far as I can tell, the docs currently cover this. Not sure if I'm missing something? @sanderson

Kapacitor does not currently support custom base paths. It looks like it was a "nice-to-have" for Kapacitor 1.6, but it didn't make it in yet. 1.6.1 was primarily a security release and did not include this update. It doesn't appear to have been added in 1.6.2 yet, but that's still a work in progress.


Pod not working

The pod could not be found
[!] Unable to find a specification for SelectableTextView (~> 0.0.1)

Can you copy and paste your podfile?

source 'https://github.com/CocoaPods/Specs.git'
Uncomment the next line to define a global platform for your project
platform :ios, '9.0'
target 'TestPod' do
Comment the next line if you're not using Swift and don't want to use dynamic frameworks
use_frameworks!
Pods for TestPod
pod 'SelectableTextView', '~> 0.0.1'
end
Cocoapods Version is 1.2.0

Sorry i have to update my spec-repos


Radar plotting

This is an example to plot NEXRAD data from the UCAR THREDDS server for the gallery. Still needs a little work, including adding some comments throughout the notebook, but wanted to start this to remember to finish it.
To Do:

[] use new MetPy functionality to compute lat/lon grid values
[] modify to use Siphon to pull data

Okay, I don't know how so many other commits ended up in this PR. I'll try to fix that at sine point.


Small parquet table with slow group by

Hive table is unpartitioned, there is only a single parquet file (written by Spark 2.4.6) in the S3 path which is 19666465 bytes (just under 20MB, but must be highly compressed as web UI shows: Input Data =1.31GB), it has 139 columns and 23,401,616 rows
--6sec
SELECT  distinct strcolA  FROM hive.tbl
--14sec
SELECT  strcolA,
sum(value_double) as value FROM hive.tbl
GROUP BY  strcolA
--23sec
SELECT strcolA, strcolB, timestampcol, strColC, sum(value_double) as value FROM hive.tbl
where strcolB in ('x','y','z')
and strColF in ('h','j')
and timestampcol  BETWEEN TIMESTAMP '2020-03-01' AND TIMESTAMP '2020-08-11'
GROUP BY strColC, strcolB, timestampcol, strcolA
single 32 CPU/256GB RAM machine, no other queries running at same time. Retried queries few times and got fairly consistent time (at best, 1 second faster)

When you run into issues like this it is best to start with EXPLAIN ANALYZE.  This will tell you where the execution engine is spending the most resources.
In your specific case, for each query you are decoding more data (more columns) for each query, so I would expect that part to take more work.  It is also possible that you are doing more IOs for each query because the file is 20MB.  There is a property that sets threshold where we just read the whole file into memory in one IO.  I believe the default is 8MB.  You could try setting that to 32MB to eliminate the IO differences.

do u know the property name? I couldn't find it


DDP throughput

@fxmarty should we multiply ddp throughput by the number of workers ?

Yes I think so!

For some reason transformers by default log only metrics for the rank=0: https://github.com/huggingface/transformers/blob/0ed23e4db26b0de01765c7d032002fe36702d357/src/transformers/trainer_pt_utils.py#L988-L1023
For now we do the same (https://github.com/huggingface/optimum-benchmark/blob/79dddc86a881627a57eae9e5095af2e7253a18cb/optimum_benchmark/backends/pytorch.py#L316), but I agree summing is better.

Actually tansformers trainer defines num_train_samples = args.max_steps * total_train_batch_size. My comment above is wrong.


fixed path separator in gradle command in hook for windows

Fixes #205

Yes git hooks install corrected

to use a draft of the plugin, you had to
pluginManagement {      repositories {          mavenLocal()         gradlePluginPortal()     } }
invariantSeparatorsPath - is simple kotlin function extentions which replaces the path separator

Nice. Thanks for getting it in, I didn’t get around to testing it.


Add README, go.mod, etc

This seems so incredibly useful ( as per https://stackoverflow.com/questions/26809484/how-to-use-double-star-glob-in-go ), but it'd be nice to have a little more direction and info as to how to use it and such.

Created PR #2 to address this issue and also suggested in https://github.com/golang/go/issues/11862 as a stopgap.


fix: transparent background

If the default winblend is set to, for example, 20, ZenMode's background inherit this transparency. This PR fixes it :slightly_smiling_face:
I also found an issue where the cursor jumps one line down every time I open ZenMode. I assume you're setting the cursor's position in ZenMode's buffer to keep it at the same line, but I can really figure out where this is in the code (though I'm not that familiar with vim/nvim's functions).

Thanks!
Feel free to post an issue about that other problem.
I'll be out for 9 days without my laptop, but can look at it when I'm back 🙂


Localizations are broken

Resources doesn't seem to be configured properly, and the only UAInteractiveNotifications.strings file that is copied to the .app directory is the spanish one.
To reproduce:

Make new Xcode app.
run pod init, add pod 'UrbanAirship-iOS-SDK', '~> 6.0', and run pod install
build for device
When build is ready, open Products/.app
select "Show Package Contents" on the .app

Observed: UAInteractiveNotifications.strings is in the root directory of the .app, the spanish version
Expected: language files should be in directories like en.lproj, es.lproj, etc.

Release 6.1.0 will resolve this issue by installing the necessary lproj directories when a user specifies the UI dependencies 'PushUI', 'RichPushUI' or 'All'. Thanks for the clear description and reproduction steps.


(FeatureRequest) Gender Fluid change based on feminization and masculinization

rather than a 0.25 chance every 2 days that the pawn might change gender
i would love to have for example:
2 males fucking, the one getting fucked or raped will become more feminine, as a result his penis would shrink and his breasts would grow, and maybe his body shape would change too.
and the other male would have his penis get bigger or something.
same thing for females, the more you fuck a female the bigger her breasts would become, and if she has a thin body shape it would change to female body shape.
i don't know about lesbians 😂

it sounds like a lot of code to make

Thanks for the idea :)
I think for "this happens while normal sex" it's way to complicated - there are many things at play, including the sexdriver which will explode once the genitalia change (unless I have some time for an upstream change ...)
But it might be a good candidate for an ability.


CA Certificate used to pull images from private repo not used by kubelet after v20240202

What happened:

Images from private hosted repo with HTTPS domain no longer able to be pulled after upgrading nodes to latest versions

In order for EKS nodes to trust URLs from a private corporate domain we load a ca-certificate is loaded onto the node via userdata. At startup the node downloads the certificate our-cert.crt to /etc/pki/ca-trust/source/anchors directory and executes update-ca-trust command.  This stops working on release v20240202 and onwards

Similar pattern to this blog post: https://aws.amazon.com/blogs/containers/use-private-certificates-to-enable-a-container-repository-in-amazon-eks/

One of the destinations is a private hosted Quay container repo with an HTTPS URL which will be referenced as https://quay.ourprivatedomain.com.

Sample error:
 Type     Reason                  Age                    From               Message
  ----     ------                  ----                   ----               -------
  Normal   Scheduled               4m25s                  default-scheduler  Successfully assigned aws-load-balancer-controller/aws-load-balancer-controller-6d947b5655-rnvzw to ip-10-128-26-140.ca-central-1.compute.internal
  Warning  FailedCreatePodSandBox  4m24s                  kubelet            Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "e3584ead4e35206f99dafb85b2e5831b28c8996698ba2deb727df66c63a4c261": plugin type="aws-cni" name="aws-cni" failed (add): add cmd: Error received from AddNetwork gRPC call: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:50051: connect: connection refused"
  Normal   Pulling                 2m36s (x4 over 4m13s)  kubelet            Pulling image "quay.ourprivatedomain.com/eks/aws-load-balancer-controller:v2.6.0"
  Warning  Failed                  2m36s (x4 over 4m13s)  kubelet            Failed to pull image "quay.ourprivatedomain.com/eks/aws-load-balancer-controller:v2.6.0": rpc error: code = Unknown desc = failed to pull and unpack image "quay.ourprivatedomain.com/eks/aws-load-balancer-controller:v2.6.0": failed to resolve reference "quay.prod-openshift-na.hybrid.sunlifecorp.com/eks/aws-load-balancer-controller:v2.6.0": failed to do request: Head "https://quay.ourprivatedomain.com/v2/eks/aws-load-balancer-controller/manifests/v2.6.0": tls: failed to verify certificate: x509: certificate signed by unknown authority
  Warning  Failed                  2m36s (x4 over 4m13s)  kubelet            Error: ErrImagePull
  Normal   BackOff                 2m21s (x6 over 4m12s)  kubelet            Back-off pulling image "quay.prod-openshift-na.hybrid.sunlifecorp.com/eks/aws-load-balancer-controller:v2.6.0"
  Warning  Failed                  2m21s (x6 over 4m12s)  kubelet            Error: ImagePullBackOff

We have not encountered this issue until upgrading to this version and later
It works when reverting back to v20240117

What you expected to happen:
Expect the kubelet to respect the trusted CAs that's on the node.
How to reproduce it (as minimally and precisely as possible):

Upgrade nodes to use v20240202 or later
load ca-cert for domain onto node
deploy pod so that kubernetes will pull the image from private hosted repo server

Anything else we need to know?:
Troubleshooted by logging into the node and executing commands via systems manager

No issues with network connectivity from the node to "quay.ourprivatedomain.com" on port 443
Confirmed that the certificate was loaded on the node
Confirmed that the certificate is valid and not expired and the destination URL uses the certificate
Able to execute ctr image pull xxxxxx and successfully pull an image to the node from CLI (via SSM) without passing --skip-verify flag
Appears to only affect managed node group and not seem to be an issue with Karpenter created nodes that use the same userdata to load the certificate

Environment:

AWS Region: ca-central-1

Instance Type(s):  t3a.xlarge

EKS Platform version (use aws eks describe-cluster --name <name> --query cluster.platformVersion): "eks.6"

Kubernetes version (use aws eks describe-cluster --name <name> --query cluster.version): "1.29"

AMI Version: v20240202 and later

Kernel (e.g. uname -a):
Linux ip-10-128-95-56.ca-central-1.compute.internal 5.10.205-195.807.amzn2.x86_64 #1 SMP Tue Jan 16 18:28:59 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Release information (run cat /etc/eks/release on a node):

BASE_AMI_ID="ami-059705a71ed021143"
BUILD_TIME="Fri Feb  2 16:56:07 UTC 2024"
BUILD_KERNEL="5.10.205-195.807.amzn2.x86_64"
ARCH="x86_64"

What does the user data log look like? /var/log/cloud-init-output.log

Looks like it ran successfully, I can confirm that it is able to download the .crt file and run the update-ca-trust.
I can see the certificates loaded in the file  /etc/ssl/certs/ca-bundle.crt
Which is technically a symlink to /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem

Do you restart containerd after you update-ca-trust?

restarting containerd after update-ca-trust seems to resolve it!
This makes sense, perhaps something in the order or containerd between those releases.


[net_health] don't fetch very old random block

Problem:  net_health fetches random block to instrument time, due to which very old blocks are mostly fetched and that takes longer than fetching recent finalized blocks. Since ApiPromise is shared so it slows down other rpc calls of WsProvider
Solution: Added Limit to fetch random block but not below BLOCK_DISTANCE
FUTURE TODO Permenant Solution: Should have multiple load balanced ApiPromise in base-provider.ts

what's the reason of using random block? not just head - 100?

what's the reason of using random block? not just head - 100?

Yes can do that, since it was random was already there so didn't bothered changing that.
Updated!!


Implement support for MBC1 bank controller

As the first of many (hopefully all) bank controllers I wish to add support for, let's start with
the simplest one, the MBC1. That way we can run the Blargg tests in one ROM image (among other test
ROMs).

Closed by e8d9818c545d64122c66dfee78016083b0558733


[BUG] netty-http uri building is not working as expected

Describe the bug
when specifying a protocol and host in the extension config the generated code doesn't match the Camel spec of that component.
(see https://camel.apache.org/components/3.18.x/netty-http-component.html)
Params entered:
Protocol: https
Host: apiserver
Path: /mypath/api/
Port: 8901

generated code:
uri: netty-http:https:apiserver:8901:/mypath/api/
expected code:
uri: netty-http:https://apiserver:8901/mypath/api/

If we don't do it yet we should use what the Camel Catalog provides in terms of meta data.
For instance it provides information on how to build the Camel URI for each Camel Component:
"syntax": "netty-http:protocol:\/\/host:port\/path",

The names protocol, host, port and path are placeholders for parameters also defined in the component's metadata.


Prisma DB not reachable despite no error

The pod show no error:
kubectl -n nodewatcher-staging logs nodewatcher-6967444867-vnhj4 -c prisma --tail 100 --follow
No log level set, defaulting to INFO.
[INFO] {} - Starting...
[INFO] {} - Start completed.
[INFO] Initializing workers...
[INFO] Obtaining exclusive agent lock...
[INFO] Successfully started 1 workers.
[INFO] Obtaining exclusive agent lock... Successful.
[INFO] Deployment worker initialization complete.
Server running on :4466

But connecting to it fails, on chain-db watcher:
 FetchError: request to http://<IP_ADDRESS>:4000/ failed, reason: socket hang up

And on the server:
nomidot-server is failing with FetchError: request to http://<IP_ADDRESS>:4466/ failed, reason: read ECONNRESET at ClientRequest. (/server/node_modules/cross-fetch/node_modules/node-fetch/lib/index.js:1393:11) at ClientRequest.emit (events.js:196:13) at ClientRequest.EventEmitter.emit (domain.js:471:20) at Socket.socketErrorListener (_http_client.js:402:9) at Socket.emit (events.js:196:13) at Socket.EventEmitter.emit (domain.js:471:20) at emitErrorNT (internal/streams/destroy.js:91:8) at emitErrorAndCloseNT (internal/streams/destroy.js:59:3) at processTicksAndRejections (internal/process/task_queues.js:83:17)

deleting the nodewatcher pod usually solved the problem.
Next time this happens we need to kubectl -n nodewatcher-staging describe pod/<pod-name> next time this happens.

closing, same as #271


Spanish translation file corrected and improved.

New translation can be found at

https://docs.google.com/spreadsheets/d/16FtHGThz0-CBz_rf_9QO4zOV7oNmNk2BlwmtvKuzAhs/edit?usp=sharing

The changes have been merged into the master branch and will be in the next release of Scout-App. I'll let you know when it comes out.

The new version of Scout-App 2 is out and contains your translations. Thank you so much for making Scout-App accessible to more people.

https://github.com/scout-app/scout-app/releases/tag/v2.12.12

You are listed as a contributor on the website, let me know if you want your name or URL changed on the website.

http://scout-app.io/#contributors


MySQL error when searching for traces.

org.mariadb.jdbc.internal.util.dao.QueryException: Expression #1 of ORDER BY clause is not in SELECT list, references column 'zipkin.zipkin_spans.start_ts' which is not in SELECT list; this is incompatible with DISTINCT
Query is : select distinct zipkin_spans.trace_id from zipkin_spans join zipkin_annotations on (zipkin_spans.trace_id = zipkin_annotations.trace_id and zipkin_spans.id = zipkin_annotations.span_id) where (zipkin_spans.start_ts between<PHONE_NUMBER>431000 and<PHONE_NUMBER>431000 and zipkin_annotations.endpoint_service_name = 'helloworld') order by zipkin_spans.start_ts desc limit 10

The issue has to do with the default settings of mysql post 5.7.
The zipkin mysql docs propose a solution, that we need to apply, preferable without having to create an image of our own.

Closed because fixed?

@adriancole: yes, adding:
[mysqld]
sql-mode=""

did the trick.


Add CSV support

I'm happy to donate. This is a great lib, I really looking forward to have this feature..

Wouldn't it be more appropriate to use a separate package to convert from CSV to JSON?  I'm sure they already exist


CrowdStrike Falcon EDR

https://www.crowdstrike.com/endpoint-security-products/crowdstrike-falcon-faq/#:~:text=CrowdStrike is the pioneer of,via a single lightweight agent.
#23

Self reference: https://ptb.discord.com/channels/@me/844819631586803742/847925815278829658

This is being built out by Val (Discord) with OpenAPI, customized in the app creator


Predefined status/log entries

Published as a draft for now for discussion and to build on.
I think there is a need to have a list of predefined system status logs/log entries. Already in UDMI, there are some are defined (for write back), but there's benefit in consolidating these into one file as a reference, and to add additional information such as log levels.
Additionally, we're now asking device manufacturers to send out some logs (e.g. a system start up log entry) but we are not defining the details of this.
Without doing so, different devices may represent the same issues/logs/status differently
This attempts to consolidate the log entries and define the minimum log entries needed

Started to be addressed in #248


fix(adv): validate fixed versions only for new data

Previously, the validation logic made an assumption that removing packages from the APKINDEX is an exceptional and rare event, used only when a severe mistake is made during a package build. Since the logic's introduction, this assumption has become invalid, as there are more common cases where packages are removed from the distro now.
Consequently, this PR moves validation of "fixed" version existence to focus on only new fixed versions being added to the advisory data, as opposed to globally looking at all advisory data and the fixed versions mentioned therein.
⚠ This also partially reverts the work done in https://github.com/wolfi-dev/wolfictl/pull/699, which I believe was incorrect and leading indirectly to a unit test failure. I'll add a review comment to the code diff to make sure I'm making the right change here.

@luhring Could we merge this PR ?

@luhring Could we merge this PR ?

Good with me — just also see above review comment for my sanity check question meant for @ajayk.

I'm going to merge this now! If anyone notices an issue from these changes, just holler!


Incorrect values in DB Space History charts

Hi
Version used: 2.22.8
The image shows the chart in "DB Space" tab for the tempdb database (as an example). The issue here is the chart values which are incorrect. At the x-axis with value 0 MB, one smaple point I marked, tempdb is 947 MB ! This value is so small compare to the scales on y-axis that is ploted as 0 MB.

The number format is a little confusing to me as it's been localized.  Normally we have commas for thousands separator and period for the decimal point.
It looks like the top of the chart is ~200GB and the point close to zero is 947MB.  That's under half a % of the charts max value so I think the chart is correct.  This is a quick mockup in Excel (Point 3):

You can use this query to get the raw data:
exec dbo.DBFileSnapshot_Get @FromDate='2022-07-03 00:00:00',@ToDate='2022-10-02 00:00:00',@InstanceGroupName=N'your instance',@DBName=N'your db',@FileName=N'your file'

The sizes shown are the max sizes for each day.  It looks like the current size might be 210MB for tempdb - which seems a little odd if the max size is ~200GB in the chart.  This might occur if the instance was restarted and tempdb got re-created or if you shrunk the files.
Let me know if this explains the issue or if something is still off that needs investigation.

The number format is in German (localized) and oddly enough (for non-german languages) the role of the "Point" and "Comma" in number notations are switched.
The focus of opened issue was to demonstrate the Chart behavior which isn't correct (to my opinion) and not the reported values. Simply said, values are correct but the chart isn't showing them correctly. On the Cord-System, x-axis at level 0 shouldn't present values above 0. The image I sent tries to demonstrate that.
To solve this (visually incorrect presentation) problem, we need to change/adapt the y-axis scales in a way that values above 0 don't land on 0-Line. Maybe the issue can be solved if you would use Logaritmic Scales.
The image below shows in detail what I mean. This time I am also adding some additional info:

Tempdb on the server is made of 10 files each 20 GB fixed with no Authogrowth
Tempfb Log file is also 10 GB and fixed with no Authogrowth
This time I also removed the "Smooth Lines" in the Chart

On this scale, 947MB is exactly where it's supposed to be - it's 0.46% of the allocated pace.  947MB is almost nothing in comparison to the 200GB space allocated.  If you put the data into Excel you will see the same result.

A logarithmic scale would definitely be more confusing.  I might consider an option to show the raw data in table format - this would make it easier to export to Excel and use some different charting options.

Next version will have an export to excel button - allowing you to create different charts easily. This is one of my lab tempdb databases with similar near zero values.  The normal chart lines up with what DBA Dash is showing.  The logaritmic one to me is misleading - but excel provides that option if you want to use it.


Give Blueprints SPN owner permissions before creating assignment if using a system-assigned MI

I forgot that when we go through the API we need to give the Blueprint 1st party app (which is an SPN in all tenants) owner permissions on the subscription. This is specifically for the system-assigned managed identity path. We use the first party app to create the system-assigned identity with owner permissions. When an assignment completes, we remove the 1st party app from the subscription so we don’t have standing access.
Here is some more info:
https://docs.microsoft.com/en-us/azure/governance/blueprints/create-blueprint-rest-api#assign-a-blueprint

Fixed in https://github.com/neilpeterson/azure-blueprints-pipeline-tasks/commit/c7e5c3cd1a110258f1010048ef3244395672cab2 by using the Az.Blueprints PowerShell module.


Move content from FLASH.md

Move content from FLASH.md to avoid duplication of content.

Dependency on https://github.com/ARMmbed/pelion-dm-edge-docs/pull/56


fix: ApisixClusterConfig e2e test case

pin the image of APISIX to stable version
using the new plugin list API
fix ApisixClusterConfig status logic

Signed-off-by: Jintao Zhang<EMAIL_ADDRESS>
Type of change:

[x] Bugfix
[ ] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

fix: #857
Pre-submission checklist:

[ ] Did you explain what problem does this PR solve? Or what new features have been added?
[ ] Have you added corresponding test cases?
[ ] Have you modified the corresponding document?
[ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

ping @tokers @gxthrj PTAL, thanks!

ping @tokers @gxthrj PTAL, thanks!

Approved.


type/replaceText functions doesnt work with InputAccessoryView component

What happened?
text helpers functionality for TextInput wrapped into InputAccessoryView doesnt work
video: https://user-images.githubusercontent.com/9297785/178329467-376236e5-b9cf-43e7-9be1-f64d0420a45a.mov
What was the expected behaviour?
TextInput wrapped into InputAccessoryView available for testing
Was it tested on latest Detox?

[X] I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

[X] I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!
reproducible demo forked from DetoxTemplate repo:
https://github.com/Vadko/DetoxTemplate
In what environment did this happen?
Detox version:
React Native version:
Node version:
Device model:
iOS version:
macOS version:
Xcode version:
Test-runner (select one): jest-circus / jest+jasmine / mocha / other
Detox logs
Detox logs
paste logs here!

Device logs
Device logs
paste logs here!

More data, please!
No response

@Vadko thanks for the detailed submission. We will look into it.

@Vadko could you try to better explain the use case here? Seems like you are bundling a text input inside what is meant to be a keyboard accessory view... Does that make sense at all, product-wise? How is iOS meant to even handle that?

Also, could you try to enable the soft-keyboard on your simulator?

@d4vidi I've tried soft-keyboard, doesnt helped.
Regarding your question about purpose of this component - it is actually very important for complex screens like messenger apps, because it brings native iOS UX to attach automatically this component at the top of keyboard, native drag to close and more.
you can investigate it here:
https://reactnative.dev/docs/inputaccessoryview


Improve command line argument parser

IMO the current parser has potential for improvements, in particular the handling of the ID option. In case of a better LUN support (SCSI supports at least 8 LUNs) this option would require one more argument, i.e. not just the filename.
My suggestion is to change the syntax of this option to require exactly one (compound) argument like this:
-ID ID,FILENAME
and with maybe better LUN support later to:
-ID ID:LUN,FILENAME
As far as I can tell this simplifies the parser and makes future extensions easier.
One could also get rid of the hard-coded file type/image type dependency:
ID ID:LUN,FILENAME:IMAGE_TYPE
@akuker I would like to hear your opinion on this.

@uweseimet - I agree that the current parser has a lot of room for improvement.
In general: I have a personal goal of keeping the external interfaces compatible with the original RaSCSI application as much as possible. (Adding new things is fine thought)
For better LUN support, appending that to the SCSI ID sounds great and shouldn't break compatibility
- ID<ID>:<LUN>
Similarly you could do the same thing with the image type:
rascsi -ID1:0 /home/pi/images/install.bin:cd
Note that the parent RaSCSI project added the ability to save/load files with the configuration in version 1.50. That's something that I'd also like to bring over at some point.
I've also wanted to somehow make the rasctl and rascsi command line argument syntax line up a little more. Not sure how to do that without breaking backwards compatibility though.
I've also wanted to add the option to override some of the default configuration options, such as vendor name.
rascsi -ID1:0 /home/pi/images/install.bin --options type=scsihd,vendor=IBM,product=DESKSTAR,revision=1.22
.... In summary, I'm rambling... I'm open to changes. I have a goal of maintaining compatibility between the two different forks, but that's a goal.
I'm very curious to hear what your thoughts are on this!

@akuker Keeping the compatibility should work by just keeping the existing options and adding new ones that essentially provide a different mapping, just as you indicated.
Regarding configuration files it would be good if any command line settings could override the configuration file settings and could add settings not present in the configuration files.
I also agree with configurable vendor names, which is something I was also missing.

I'm just wondering: A new parser would probably support multiword-arguments and shortcuts like, e.g. --enable-my_option/-m, which differs quite a lot from what the current parser expects. One way to resolve this and be backwards compatible might be to just say: If the command line contains the "-ID" or "-HD" argument the old parser is used (backwards compatible), and if there is no such argument the new parser is used.

I like the backwards compatibility mode idea. But, that just adds technical debt.
What do you think about having the backwards compatibility mode for a few months, then yanking it out?

Yes, this should be considered.
I played around a bit with how a modified parser might look like. The main issue I stumbled upon is the fact that the existing parser accepts the same options several times. This is of course in order to be able to define several devices on a single command line, but from what I can tell this forces the parser code to always be rather awkward. On the other hand, being able to define more than one ID is convenient, because you are not forced to use a configuration file.
Sometimes the command line is convenient, sometimes a configuration file is ;-).

I am going to close this issue because options for providing vendor, product, revision and type have been implemented. If we need an option update for dealing with SCSI LUNs other code has to be changed anyway, and then the parser can be updated if needed.


Quantum computer error

Unable to use nocode on quantum computer.

Your wave function was written incorrectly

@monkey-programmer I believe I have a workaround. Install the gEggs-n-Ham component that's part of the seuss.el7.x86_64 library. That one is much easier to install than the Schrödinger libs. The downside is no direct access to the cat. Instead, you'll go the route of the box-with-a-fox, house-with-a-mouse, here-or-there-or-anywhere, etc...You know, standard stuff.

I reproduced your issue and it worked fine using Schrödinger library 1.0.5. Try not looking at the result and it will work

Replace the quantum computer with a potato. Works just perfect.


Remove GitLab performance regression CI

It seems that we won't be able to get the performance regression CI back to work in the same way we used it before ECP ended.

Do we want to remove it? I disabled the actions, so it should not trigger. I don't see a pressing need for removal, though I understand the desire.

It's just dead code at this point and having it makes the impression that we are using it while we don't. I also still get notifications from forks, see, e.g. https://github.com/dalg24/ArborX/actions/runs/7475756660.


Timer stops when tab isn't visible

The timer is keyed off animation frames, which don't fire when the window isn't visible, so the timer stops. Need to use a setTimeout() function instead.

Maybe a silly question, but couldn't the regular function simply add the full time step instead of only adding exactly .5s?
This would also be more accurate with a low frame rate, where the current code loses up to 1s/FPS per interval...
    if((timestamp - lastTick)>500) {
-     Game.totalTime += 500;
+     Game.totalTime += (timestamp - lastTick);
      stat_time.innerHTML = displayTime(Game.totalTime);
      UpdateOverlay(null, null);
      lastTick = timestamp;
    }

Note: This fixes the timer issue, but not the fact that when the tab isn't visible, the game just stops completely, which means saving won't happen.


Update twitter-tipbot.md

i fix the year of this bounty. before date is 2019 and now is  2018

Thanks Chris!


When the useFetch request is repeated, the data does not change

Environment
Nuxt 3 latest version
Reproduction
this cannot be done because there is no open service that will provide such an api to reproduce it. Can you advise me? I need an error to arrive at the same url, and then a callback occurs, but only without an error if the headers are correct.
https://stackblitz.com/edit/nuxt-starter-74zqym?file=plugins%2Fapi.ts

When the useFetch request is repeated, the data does not change. The fact is that when I go to the page where the USEFETCH wrapper is used, the data is processed correctly, but if in case of a 401 authorization error I need to call an additional function, a token request, after which I return the original function, the data does not change. How do I return the current data to the template? Hint. If done in useApi
export async function useAPI<T>(url: string | (() => string), options?: UseFetchOptions<T>) {
  const response = await useFetch(url, {
    ...options,
    $fetch: useNuxtApp().$api,
    isUseFetch: true,
  })

  if (response.data.value.statusCode === 401) {
    await response.clear()
    await response.refresh()

    return response
  }

  return response
}

clear() and refresh() then everything works properly, but there is a problem of hydration. How can I make the data in the component reactive and get the values from the second request?
Describe the bug
I have tried many different ways, but there is a feeling that the problem is in nuxt.
https://nuxt.com/docs/guide/recipes/custom-usefetch
The problem occurs at the moment when you press f5 on the page itself, and it gives a 401 error on the ssr side, then calls the method to get new tokens, and should call that very first request and get the data, but I have an error in the variable from that first request
Additional context
No response
Logs
No response

this cannot be done because there is no open service that will provide such an api to reproduce it. Can you advise me? I need an error to arrive at the same url, and then a callback occurs, but only without an error if the headers are correct.
https://stackblitz.com/edit/nuxt-starter-74zqym?file=plugins%2Fapi.ts

this cannot be done because there is no open service that will provide such an api to reproduce it. Can you advise me? I need an error to arrive at the same url, and then a callback occurs, but only without an error if the headers are correct.
https://stackblitz.com/edit/nuxt-starter-74zqym?file=plugins%2Fapi.ts

up

Would you be able to provide a reproduction? 🙏
More info

up
this cannot be done because there is no open service that will provide such an api to reproduce it. Can you advise me? I need an error to arrive at the same url, and then a callback occurs, but only without an error if the headers are correct.
https://stackblitz.com/edit/nuxt-starter-74zqym?file=plugins%2Fapi.ts

I found a solution, maybe it will be useful to someone, but a new problem has appeared) After I failed to call the first request (401), a refresh request is called and if it also returns 401 or some other error, then it is not possible to catch it
export async function useAPI<T>(url: string | (() => string), options?: UseFetchOptions<T>) {
  const nuxtApp = useNuxtApp()
  const user = useUser()
  const config = useRuntimeConfig()

  const rec = ref()

  const response = useFetch(url, {
    ...options,
    isUseFetch: true,
    baseURL: config.public.apiBase || '',
    credentials: 'include',
    watch: [rec],
    cache: 'no-cache',

    onRequest({ options }) {
      const accessToken = user.jwt.accessToken

      if (accessToken) {
        const headers = options.headers || {}

        if (Array.isArray(headers)) {
          headers.push(['Authorization', `Bearer ${accessToken}`])
        } else if (headers instanceof Headers) {
          headers.set('Authorization', `Bearer ${accessToken}`)
        } else {
          headers.Authorization = `Bearer ${accessToken}`
        }
      }
    },

    async onResponse({ response }) {
      if ([401, 403].includes(response.status)) {
        const { refreshToken } = getTokens(nuxtApp)

        if (!refreshToken) {
          await user.logout()
          return navigateTo('signin')
        }

        const refreshApi = `${config.public?.apiBase}/auth/login/access-token`

        const refreshResponse = await $fetch(refreshApi, {
          method: 'POST',
          body: JSON.stringify({ refreshToken }),
          headers: {
            'Content-Type': 'application/json',
          },
        })

        if (refreshResponse?.accessToken && refreshResponse?.refreshToken) {
          user.jwt.accessToken = refreshResponse.accessToken
          user.jwt.refreshToken = refreshResponse.refreshToken
          await user.syncCookie()

          rec.value += 1

          return
        } else {
          await user.logout()
          return navigateTo('signin')
        }
      }

      return response
    },
  })

  return response
}

Check the useFetch cache issue and try adding key: Date. now(). toString() to the second parameter object of useFetch


Support disabled menuitem

This prevents items with aria-disabled="true" from being triggered.
@dgraham I noticed that the arrow navigation will get stuck because button[disabled] is not focusable. We will need to filter out [disabled] to fix it.
That makes me wonder if we should match this non-focusable behavior on aria-disabled=true items. This would mean not only filtering it out, but also requiring tabindex="-1" on focusable[aria-disabled="true"] items so it escapes tab focus.
And then we will end up with 🤔
details.querySelectorAll('[role^="menuitem"]:not([hidden]):not([disabled]):not([aria-disabled="true"])')

What do you think?
This isn't a problem for <auto-complete> since it doesn't rely on the :focus state.

…arrow navigation will get stuck because button[disabled] is not focusable.

Taking inspiration from native macOS menus, I agree that keyboard navigation should skip disabled menu items.

That makes me wonder if we should match this non-focusable behavior on aria-disabled=true items.

I think so, for consistency with disabled.

details.querySelectorAll('[role^="menuitem"]:not([hidden]):not([disabled]):not([aria-disabled="true"])')

This looks right to me. We'll skip hidden and disabled items in the menu, regardless of how they're implemented (elements with built-in disabled attributes vs aria-disabled).

Thanks @dgraham! I pushed the changes.


More support for react-router, Redux, TypeScript etc.

Right now create-react-app just creates a app without interacting with the user and doing nothing. I'd like it to ask few things like:
Do you want to add Redux?
Do you want to use react-router?
What would you like to use for writing React? (ES6, TypeScript, etc)
If it's possible, if we generate everything from code coverage to transpiling, that'd be great.

Run npm run eject, feel free to configure by yourself

Please see: https://github.com/facebookincubator/create-react-app/issues/1297

We won't be adding more code generation for now. Generating code is highly subjective and people have different ideas about how to structure projects. We just want to provide a build pipeline, not a full code generator.
There are currently no plans to support TypeScript but you can search issues and pull requests for past discussions about it. I think there are some community maintained forks that do that.
Cheers!

This fork supports typescript: https://github.com/wmonk/create-react-app-typescript


📖 Mention 2FA relevance although not checked by Scorecard

What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
docs update

[x] PR title follows the guidelines defined in our pull request documentation

Which issue(s) this PR fixes
Fixes #2526

Special notes for your reviewer
Not sure about the title, let me know what you think
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

I'm undecided about this. Do we want to be the source of security recommendations? How important are they? What should we recommend, and what shouldn't we?

Good questions. If we're positioning Scorecard as a checklist of actions to take to improve the security of your project, then neglecting any mention of 2FA seems like a big gap. But where to draw the line? I would be fine with making this exception for 2FA only.
Definitely would like to hear other thoughts on this. @azeemshaikh38 @laurentsimon

I'm undecided about this. Do we want to be the source of security recommendations? How important are they? What should we recommend, and what shouldn't we?

I don't have a clear answer either. But I suppose when it's related to important GH settings, we could consider it. Maybe we could also have a paragraph explaining "what scorecard is not". It is not currently obvious from the "What is scorecard" section that 1) We only look at source repository (not packages); we look at best practices in your settings and code, etc. We could make this a little clearer up front. In a "what scorecard is not" section, we could say things like: we don't check packages, we don't check for malicious code, etc

Good questions. If we're positioning Scorecard as a checklist of actions to take to improve the security of your project, then neglecting any mention of 2FA seems like a big gap. But where to draw the line? I would be fine with making this exception for 2FA only.
Definitely would like to hear other thoughts on this. @azeemshaikh38 @laurentsimon

I'd be fine having a section about "Limitations and other tools" with pointers for users. For 2FA, we could point to using AllStar in conjunction with Scorecard - something we're trying to improve.
Just some ideas...

In my opinion, Scorecard already works with Github Best Practices recommendation and 2FA would certainly be a check if possible.
Considering the objective of improving the supply-chain security, every project that decides to adopt Scorecard would see this 2FA part and would consider implement it, which would increase the supply-chain security by extension.
And I agree with @olivekl that we can make some exceptions consider the relevance of 2FA. Besides, this "what scorecard is not" would be great to also deal with https://github.com/ossf/scorecard/issues/2474.

I'm undecided about this. Do we want to be the source of security recommendations? How important are they? What should we recommend, and what shouldn't we?

Good questions. If we're positioning Scorecard as a checklist of actions to take to improve the security of your project, then neglecting any mention of 2FA seems like a big gap. But where to draw the line? I would be fine with making this exception for 2FA only.
Definitely would like to hear other thoughts on this. @azeemshaikh38 @laurentsimon

Sounds good to me! Thanks

In my opinion, Scorecard already works with Github Best Practices recommendation and 2FA would certainly be a check if possible.
Considering the objective of improving the supply-chain security, every project that decides to adopt Scorecard would see this 2FA part and would consider implement it, which would increase the supply-chain security by extension.

Good point. We did not consider it before because it requires an admin token from org maintainers. But we already have a check like WebHook which only runs with special tokens too.. so we could add a check for it. It just won't be available to many users.. but maybe with fine-grained tokens on their way it would work...

Would be great if Scorecard had this 2FA check. I am not sure what GitHub APIs need to be called to confirm if all maintainers of a project have 2FA enabled. Does anyone know?

Would be great if Scorecard had this 2FA check. I am not sure what GitHub APIs need to be called to confirm if all maintainers of a project have 2FA enabled. Does anyone know?

Erring on the side of caution, would we want to surface that information (assuming it's possible)? Would visibility be limited only to project owners and not be made available the general public? It seems risky to make 2FA status generally known.

Would be great if Scorecard had this 2FA check. I am not sure what GitHub APIs need to be called to confirm if all maintainers of a project have 2FA enabled. Does anyone know?

Erring on the side of caution, would we want to surface that information (assuming it's possible)? Would visibility be limited only to project owners and not be made available the general public? It seems risky to make 2FA status generally known.

Thats a good point. One way to think about it is to only surface info to the public when it is available without authentication/ authorization. If GitHub API needs a token to provide the info, e.g. in case of 2FA, then Scorecard should not make the info public. Just make it available as output of the CLI.

Would be great if Scorecard had this 2FA check. I am not sure what GitHub APIs need to be called to confirm if all maintainers of a project have 2FA enabled. Does anyone know?

Erring on the side of caution, would we want to surface that information (assuming it's possible)? Would visibility be limited only to project owners and not be made available the general public? It seems risky to make 2FA status generally known.

Thats a good point. One way to think about it is to only surface info to the public when it is available without authentication/ authorization. If GitHub API needs a token to provide the info, e.g. in case of 2FA, then Scorecard should not make the info public. Just make it available as output of the CLI.

+1, this would only be used in the CLI.