Potential bug in ScsiBlockDevice.requestSense()

I was working on EtchDroid and I noticed this exception:
eu.depau.etchdroid.utils.exception.InitException: Initialization failed
    at eu.depau.etchdroid.service.WorkerService$onStartCommand$2.invokeSuspend(WorkerService.kt:310)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
    at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:115)
    at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:103)
    at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)
Caused by: java.lang.IllegalArgumentException: newLimit > capacity: (36 > 18)
    at java.nio.Buffer.createLimitException(Buffer.java:366)
    at java.nio.Buffer.limit(Buffer.java:340)
    at java.nio.ByteBuffer.limit(ByteBuffer.java:863)
    at me.jahnen.libaums.core.driver.scsi.ScsiBlockDevice.transferOneCommand(ScsiBlockDevice.kt:280)
    at me.jahnen.libaums.core.driver.scsi.ScsiBlockDevice.requestSense(ScsiBlockDevice.kt:222)
    at me.jahnen.libaums.core.driver.scsi.ScsiBlockDevice.handleCommandResult(ScsiBlockDevice.kt:207)
    at me.jahnen.libaums.core.driver.scsi.ScsiBlockDevice.transferCommand(ScsiBlockDevice.kt:155)
    at me.jahnen.libaums.core.driver.scsi.ScsiBlockDevice.transferCommandWithoutDataPhase(ScsiBlockDevice.kt:199)
    at me.jahnen.libaums.core.driver.scsi.ScsiBlockDevice.initAttempt(ScsiBlockDevice.kt:115)
    at me.jahnen.libaums.core.driver.scsi.ScsiBlockDevice.init(ScsiBlockDevice.kt:83)
    at eu.depau.etchdroid.massstorage.EtchDroidUsbMassStorageDevice.setupDevice(EtchDroidUsbMassStorageDevice.kt:213)
    at eu.depau.etchdroid.massstorage.EtchDroidUsbMassStorageDevice.init(EtchDroidUsbMassStorageDevice.kt:183)
    at eu.depau.etchdroid.service.WorkerService$onStartCommand$2.invokeSuspend(WorkerService.kt:306)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
    at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:115)
    at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:103)
    at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)

This is not a big deal for EtchDroid since I've implemented failure recovery: it will ask the user to reconnect the USB drive and keep going. However I'm puzzled by what might be going on. I'm not sure how to reproduce this consistently since a command failure needs to happen before the sense data is requested. Maybe we could record a USB communication log, then mock the Android USB API similarly to what libfprint does to implement device tests? Anyway I'm digressing, I'll open another issue to track that.
Anyway, the culprit seems to be in ScsiBlockDevice.kt:222:
    private fun requestSense() {
        val inBuffer = ByteBuffer.allocate(18)
        val sense = ScsiRequestSense(inBuffer.array().size.toByte(), lun = lun)
        when (val status = transferOneCommand(sense, inBuffer)) {
		    // ...

and in ScsiBlockDevice.kt:269:
        var transferLength = command.dCbwDataTransferLength
        inBuffer.limit(inBuffer.position() + transferLength)

AFAIU command.dCbwDataTransferLength should end up being the argument to the ScsiRequestSense ctor, inBuffer.array().size.toByte() which should be 18. That means the only way the result of the expression can be 36 is if inBuffer.position() is somehow == inBuffer.capacity(), which doesn't make a lot of sense since according to the docs a fresh ByteBuffer should have the position set to zero.
Do you have any ideas?

Yeah as you describe it it sounds very weird. Not sure if enlarging the buffer would be a quick fix?
Maybe there is a bug that the val = inBuffer gets alatered somewhere further down the road?

var transferLength = command.dCbwDataTransferLength
inBuffer.limit(inBuffer.position() + transferLength)

var read = 0
if (transferLength > 0) {

    if (command.direction == Direction.IN) {
        do {
            read += usbCommunication.bulkInTransfer(inBuffer)
            if (command.bCbwDynamicSize) {
                transferLength = command.dynamicSizeFromPartialResponse(inBuffer)
                // This line serves what purpose? When I commented it out, the error did not occur
                // inBuffer.limit(inBuffer.position() + transferLength)
            }
        } while (read < transferLength)

        if (read != transferLength) {
            throw IOException("Unexpected command size (" + read + ") on response to "
                    + command)
        }
    } else {
        written = 0
        do {
            written += usbCommunication.bulkOutTransfer(inBuffer)
        } while (written < transferLength)

        if (written != transferLength) {
            throw IOException("Could not write all bytes: $command")
        }
    }
}


Refactor APIProvider to accomodate manual providing, offline dags, and easy mocks

We need a new APIProvider that can provide access to the routing.ContentRouting, blockstore.Blockstore, and ipld.DAGService APIs found in the core.IpfsNode object. Ideally, this refactor would also be easy to mock only the portions needed so that we can avoid tripping up the CI.
ref #375 and #374

Synchronously discussed. The decision is to change APIProvider to NodeProvider:
type NodeProvider func() (*core.IpfsNode, error)


rename the file so that it is clear that s3 list_objects_v2 returns t…

…he first 1000 objects based on name

this file is now behind main - close pull request and delete branch.


'NoneType' object has no attribute 'split'

Hi,
I'm trying to make a connection to the Reporting API from Topdesk, but it doesn't seem to work.
OS: Windows 10 Pro
Python:  3.8.2 (tags/v3.8.2:7b3ab59, Feb 25 2020, 22:45:29) [MSC v.1916 32 bit (Intel)]
certifi | 2019.11.28 | 2019.11.28
chardet | 3.0.4 | 3.0.4
idna | 2.9 | 2.9
lxml | 4.5.0 | 4.5.0
pip | 19.2.3 | 20.0.2
pyodata | 1.3.0 | 1.3.0
requests | 2.23.0 | 2.23.0
setuptools | 41.2.0 | 45.2.0
urllib3 | 1.25.8 | 1.25.8
Code:
import pyodata
import requests
url = 'https://.topdesk.net/services/reporting/v2/odata/'
session = requests.Session()
session.auth = ('','')
client = pyodata.Client(url, session)
Expected:
A new client object
Result:
Traceback (most recent call last):
File "C:/Users//first.py", line 8, in
client = pyodata.Client(url, session)
File "C:\Users<my-user>\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pyodata\client.py", line 59, in new
schema = pyodata.v2.model.MetadataBuilder(resp.content, config=config).build()
File "C:\Users<my-user>\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pyodata\v2\model.py", line 2460, in build
schema = Schema.from_etree(edm_schemas, self._config)
File "C:\Users<my-user>\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pyodata\v2\model.py", line 991, in from_etree
config.err_policy(ParserError.ENTITY_TYPE).resolve(ex)
File "C:\Users<my-user>\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pyodata\v2\model.py", line 59, in resolve
raise ekseption
File "C:\Users<my-user>\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pyodata\v2\model.py", line 989, in from_etree
etype = EntityType.from_etree(entity_type, config)
File "C:\Users<my-user>\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pyodata\v2\model.py", line 1388, in from_etree
navp = NavigationTypeProperty.from_etree(proprty)
File "C:\Users<my-user>\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pyodata\v2\model.py", line 1705, in from_etree
node.get('Name'), node.get('FromRole'), node.get('ToRole'), Identifier.parse(node.get('Relationship')))
File "C:\Users<my-user>\AppData\Local\Programs\Python\Python38-32\lib\site-packages\pyodata\v2\model.py", line 156, in parse
parts = value.split('.')
AttributeError: 'NoneType' object has no attribute 'split'
Note: I'm using PyCharm without any virtual environment
As I think you will understand, I've had to replace some things. As a result you will not be able to reproduce my situation, but I still hope you'll be able to find out if I'm doing something wrong or if there is any bug in the library.
Thank you!

@wesselvrij  Thank you for taking the time to report this issue. Unfortunately, I cannot fix the problem because I have to see the part of $metadata which we failed to parse.
pyodata expects that NavigationProperty definitions to have the attribute Relationship set to an EntityType name. In your case, the attribute was not set at all and I am not sure why.
You can see the expected NavigationProperty definition at:
https://github.com/SAP/python-pyodata/blob/master/tests/metadata.xml#L88
Could you please analyze NavigationProperty definitions in your $metadata and post the excerpt we failed to parse here?
This is URL template:
https://.topdesk.net/services/reporting/v2/odata/$metadata

@filak-sap
Thank you for your response.
I'm pretty new to this, so I don't know how to analyze $metadata. Can you tell me how I can open this? I've looked for some tools, but wasn't able to find a suitable one.

It should be an XML document [0], you can open it your favorite text editor (I bet you can use pycharm).
0: https://www.odata.org/blog/queryable-odata-metadata/

I think didn't state my question properly. I'm sorry. My actual question was how to get this document?

I have the same problem and odata v4
how is this XML defined, is this automatic or is defined manually?

wait, this library only works with v2?


Does not consider improper fractions for input type question

Summary
When we are entering improper fractions as an answer, the whole number is getting truncated and only the decimal form is taken.
example :
Question : If 4 is the whole number, and 2 is the numerator and 7 is the denominator, how can we write the number?
Answer : when we enter answer as 4 2/7 or 30/7 or 3.25 and save it. It changes into 0.25.
Expected Result:
It should accept all these 4 2/7 or 30/7 or 3.25 formats for input answer type.
Cateogry
Select one: BUG
Usage Details

Browser: Chrome Browser
Channel: 5d132ba360b54b2ba9df169ffaa43ccb (test2)
Topic/Content Item: Test2 - Test2 Exercise - select any question.

How to reproduce

Login in CC server.
use this channel.(5d132ba360b54b2ba9df169ffaa43ccb (test2))
Try to input 4 2/7 or 30/7 or 3.25 as answers and save the question.
Refresh the page.
You will notice that 3.25 is saved as 0.25.

Screenshots:
Case 1: Entering answer as 4 2/7

Case 2 : Entering answer as 30/7

Case 3 : Entering answer as 3.25

Hello @swapnil106111! Thank you so much for reporting this bug, I will try to get a fix in as soon as possible.
As for accepting the formats 30/7 and 4 2/7, Kolibri will evaluate the answer based on the value rather than the format (so 4 2/7, 30/7, and 4.286 will still be counted as correct if the answer is 4.286 since they all have the same value). Kolibri Studio will automatically convert it to a decimal to communicate that the curator doesn't have to enter all possible number formats, just the correct value. The only reason a curator would need to add multiple answers is if there are multiple correct values (e.g. "What is the square root of 9?" would be 3 or -3). We are exploring better ways to communicate this concept through the exercise editor, and are open to any suggestions. Sorry for the long-winded explanation, please let us know if you have any questions!

@jayoshih at present we are using the following feature when the question has more than one answer and we want it to be 'Input answer' type.

3.25 -> 0.25 bug fixed: https://github.com/fle-internal/content-curation/pull/474

@jayoshih Thanks this is tested and its working fine now! You can close this now.


Check existing shortcuts and fix where applicable

As a user, I want to use commonly-available keyboard shortcuts, so that I can provide input more efficiently with shortcuts I am accustomed to.

Moved to v1.3b

Existing shortcuts:

ctrl-C: copy text
ctrl-V: paste text
ctrl-X: cut text
ctrl-Z: undo text
ctrl-A: select all text
ctrl/shift/fn + left/right: navigate in text
Other windows shortcuts (windows-up/down: maximise/minimise window, alt-F4: close window)

All these shortcuts are working properly.


Enhance boilerplate codes

I refactored the boilerplate.
flutter_boilerplate
Full boilerplate project for Flutter.

Specification

Localization
Get package navigation settings
Asset-related settings (Image, Icon, Color)
Installed test packages

Folder Structures
├── android
├── build
├── ios
├── lib
│   ├── generated
│   │   ├── intl
│   │   │   ├── messages_all.dart
│   │   │   ├── messages_en.dart
│   │   │   └── messages_ko.dart
│   │   └── l10n.dart
│   ├── l10n
│   │   ├── intl_en.arb
│   │   └── intl_ko.arb
│   ├── main.dart
│   ├── models
│   │   └── sample.dart
│   ├── screens // <- or pages
│   │   └── home.dart
│   ├── utils
│   │   └── asset.dart
│   └── widgets // <- or components
│       └── sample.dart
├── res
│   ├── icons
│   │   └── logo.png
│   ├── images
│   │   └── logo.png
│   ├── fonts // <- If you want, you have to make it here yourself.
├── test
│   └── widget_test.dart
├── analysis_options.yaml
├── flutter_boilerplate.iml
├── pubspec.lock
├── pubspec.yaml
└── README.md

Dependencies
  # dev_dependencies
  test: ^1.17.12
  mockito: ^5.0.17
  build_runner: ^2.1.7
  integration_test: ^0.8.1

  # dependencies
  intl: ^0.17.0
  get: ^4.6.1
  cupertino_icons: ^1.0.2

Running the project
pub get
flutter run ios
flutter run android

Localization
The repository is localizing using the arb recommended on the official Flutter website.
To use it, you need to install the Flutter Intl extension in your VSCode or Android studio.
You can go to the link below for installation.

Visual studio code
Android studio

When Flutter Intl is installed, a dart file is automatically created when modifying the arb file.
For posture information on this, check the document on the download link.
For Korean users, you can check it on this link.
How to use localization
import 'package:intl/intl.dart';
...

Text(Intl.message('appName'))

or
import 'package:flutter_boilerplate/generated/l10n.dart';
...

Text(S.of(context))

Assets

The following related things are called Assets.

How to use asset
To use the image or icon, you can use it as below.
import 'package:flutter_boilerplate/utils/asset.dart' as asset;
...

Image(
  image: asset.Images.logo,
)

@hyochan I think there is a need to change the license of the repository.
Is it okay if I think about it and apply it?

@hyochan I think there is a need to change the license of the repository.
Can I think about it and apply it?

Sure you are the admin of current repo

@hyochan I think there is a need to change the license of the repository.
Can I think about it and apply it?

Sure you are the admin of current repo

Thx :)

good

I'll handle rest

Thx :)


Migration of tests to Jest

@ooflorent Alright, I've done it.
This is with jest:
Test Suites: 1 failed, 65 passed, 66 total
Tests:       1 failed, 126 skipped, 10692 passed, 10819 total
Snapshots:   2 passed, 2 total
Time:        141.898s, estimated 158s
Ran all test suites.

This was before on the same computer with mocha:
  10713 passing (13m)
  127 pending

That's an improvement of almost 6x in terms of speed.
(fewer total number of tests under Mocha, cause I run that test around 4.0-alpha, before merging current master)

```
 FAIL  test/TestCasesDevelopment.test.js (13.204s)
  ● TestCases › development › chunks › runtime › exported tests › should not load a chunk which is included in a already loaded one

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      175 |             __webpack_require__.e(/*! require.ensure */3).then((function(require) {
      176 |                     try {
    > 177 |                             expect(sync).toBe(true);
      178 |                             done();
      179 |                     } catch(e) {
      180 |                             done(e);

      at test/js/development/chunks/runtime/bundle.js:177:18
```

~~~We still need facebook/jest#5673 to ship before we can merge, but this is ready for review.~~~

Ok, couple more issues with exportedTests not being executed. Working on it.

I'm quite busy right now but I'll do my best to review the PR this week!

@ooflorent best to hold off, it would be nice if https://github.com/facebook/jest/pull/5673 ships first. I'm quite ill right now, but I'll try to come back to it as soon I am able.

Alright, I've done it.
This is with jest:
Test Suites: 1 failed, 65 passed, 66 total
Tests:       1 failed, 126 skipped, 10692 passed, 10819 total
Snapshots:   2 passed, 2 total
Time:        141.898s, estimated 158s
Ran all test suites.

This was before on the same computer with mocha:
  10713 passing (13m)
  127 pending

That's an improvement of almost 6x in terms of speed.
(fewer total number of tests under Mocha, cause I run that test around 4.0-alpha, before merging current master)
The one remaining failing test seems like an actual bug in webpack (or in the test), which for whatever reason seems to be passing under mocha:
 FAIL  test/TestCasesDevelopment.test.js (13.204s)
  ● TestCases › development › chunks › runtime › exported tests › should not load a chunk which is included in a already loaded one

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      175 |             __webpack_require__.e(/*! require.ensure */3).then((function(require) {
      176 |                     try {
    > 177 |                             expect(sync).toBe(true);
      178 |                             done();
      179 |                     } catch(e) {
      180 |                             done(e);

      at test/js/development/chunks/runtime/bundle.js:177:18

We still need facebook/jest#5673 to ship before we can merge, but this is ready for review.

Thanks for the review @ooflorent!
I'll get back to the PR as soon as there's some motion with facebook/jest#5673.

I'll merge in changes from master soon.

@niieani You removed the note from the PR title. Does this mean the jest issue is fixed now?

@sokra yes!
I have two unresolved issues though. First one:
 FAIL  test/TestCasesDevelopment.test.js (13.204s)
  ● TestCases › development › chunks › runtime › exported tests › should not load a chunk which is included in a already loaded one

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      175 |             __webpack_require__.e(/*! require.ensure */3).then((function(require) {
      176 |                     try {
    > 177 |                             expect(sync).toBe(true);
      178 |                             done();
      179 |                     } catch(e) {
      180 |                             done(e);

      at test/js/development/chunks/runtime/bundle.js:177:18

In TestCases, only when compiled with the development config, the test: should not load a chunk which is included in a already loaded one fails as shown above.
It seems like a legit bug (either in the assertion or webpack): I'm curious why the test passes in mocha, though? Or does it get skipped for some reason?
Second one is that even with #6678 merged, there's a lag between the saving of events.json and the time it becomes visible to the file-system after being saved by the plugin. The two assertions for ProfilingPlugin that depend on it existing fail on both CIs. But they pass when run locally on my computer. A workaround could be to add a delay and wait for the file. That doesn't sound good though.
Not sure what a proper solution would be.

It seems like a legit bug (either in the assertion or webpack): I'm curious why the test passes in mocha, though? Or does it get skipped for some reason?

It's really a bug see #7063.

But they pass when run locally on my computer. A workaround could be to add a delay and wait for the file.

I would feel fine with a delay. Maybe it's a problem in the ProfilingPlugin, but this PR shouldn't bother with this.

All the tests are now passing and master is merged. The CI is red, cause there's still some issue with Node 6 hanging during the test - does anybody want to help out debugging this, or knows what could be causing the issue? @ooflorent @montogeek?
Thanks!
@sokra by the way, I've solved this:

Maybe it's a problem in the ProfilingPlugin, but this PR shouldn't bother with this.

In the end it was an issue with the directory not existing, thus ProfilingPlugin couldn't create the file before the build. The test only failed the first time (in a clean repository), that's why it didn't work on CI.

@sokra I'll fix the ProfilingPlugin in a separate PR, as you said.
Anyway, this is finally ready - fixed the remaining issues and all the issues from @ooflorent's review.
Test Suites: 66 passed, 66 total
Tests:       127 skipped, 11183 passed, 11310 total

🔥

What’s going on with coverage? Is it a false alarm or is it broken?

@ooflorent I've looked through it, it seems like a false alarm. The way coverage is instrumented has changed, so some of the lines have moved -- hard to say if this is more precise or it used to be more precise in the past. In any case, the difference is IMO negligible.

Looks good, I noticed one small issue. When running jest in watch mode and running the WatchDetection test, sane emits EPERM errors on windows. sane doesn't seem to check the ignore list when directories are added (https://github.com/amasad/sane/blob/master/src/node_watcher.js#L310) and reading the stats from a removed file seem to cause an EPERM error here (https://github.com/amasad/sane/blob/master/src/node_watcher.js#L306). I believe it's an sane issue. Although it would also be great if watcher errors would be catched (via watcher.on("error")) in jest-haste-map. Anyway, it's not super critical.

Awesome thanks

Awesome stuff @niieani !
Thanks @skovhus for https://github.com/skovhus/jest-codemods 🙌
Just throwing it out there:
I had faced some similar issues while transforming test assertions for babel's tests, which had a mix of mocha, chai, assert in https://github.com/babel/babel/issues/7476. I feel I should have noted these down, and regret not reporting them to https://github.com/skovhus/jest-codemods then.
But then I wrote a (seriously) toned down version focusing on assertions that babel's tests required at: https://github.com/devenbansod/jest-expect-codemod

I got this random error in watch mode after changing a file. Can't reproduce...
D:\Repos\webpack\node_modules\jest-runtime\build\index.js:581
    const wrapper = this._environment.runScript(transformedFile.script)[
                                                                       ^

TypeError: Cannot read property 'Object.<anonymous>' of null
    at Runtime._execModule (D:\Repos\webpack\node_modules\jest-runtime\build\index.js:581:72)
    at Runtime.requireModule (D:\Repos\webpack\node_modules\jest-runtime\build\index.js:365:14)
    at Runtime.requireModuleOrMock (D:\Repos\webpack\node_modules\jest-runtime\build\index.js:449:19)
    at readdir (D:\Repos\webpack\node_modules\readdirp\readdirp.js:55:25)
    at FSWatcher.<anonymous> (D:\Repos\webpack\node_modules\chokidar\lib\nodefs-handler.js:356:5)
    at FSWatcher.Object.<anonymous>.NodeFsHandler._handleDir (D:\Repos\webpack\node_modules\chokidar\lib\nodefs-handler.js:407:18)
    at FSWatcher.<anonymous> (D:\Repos\webpack\node_modules\chokidar\lib\nodefs-handler.js:456:19)
    at FSWatcher.<anonymous> (D:\Repos\webpack\node_modules\chokidar\lib\nodefs-handler.js:461:16)
    at D:\Repos\webpack\node_modules\graceful-fs\polyfills.js:287:18
    at FSReqWrap.oncomplete (fs.js:153:5)

@niieani What's the reason for using Math.random().toPrecision(21).slice(2) in the folder name for watch-src tests?

I also ran into this issue https://github.com/facebook/jest/issues/4820 but no blocker

The slashes are also a bit weird here, but not important (windows)

When running jest in watch mode and running the WatchDetection test, sane emits EPERM errors on windows. sane doesn't seem to check the ignore list when directories are added (https://github.com/amasad/sane/blob/master/src/node_watcher.js#L310) and reading the stats from a removed file seem to cause an EPERM error here (https://github.com/amasad/sane/blob/master/src/node_watcher.js#L306). I believe it's an sane issue. Although it would also be great if watcher errors would be catched (via watcher.on("error")) in jest-haste-map. Anyway, it's not super critical.

It's worse than I original estimated. The whole jest watch process crashes.

@sokra Math.random().toPrecision(21).slice(2) is needed to always create a new folder. Jest creates their haste map, I think based on package.json files. When there are duplicates of the same path and the same package name, it can cause issues.
Not sure what to do with the Windows issues, I'm on Mac. :/


Play stops on one torrent when a second torrent is added

What version of WebTorrent Desktop?
Version 0.8.1 (0.95.2)
What operating system and version?
OSX El Capitan
What did you do?

Add a torrent.
Start playing it.
Add a second torrent.

What did you expect to happen?
Second torrent is added and the first one continues playing.
What actually happened?
Second torrent is added but the first stops playing.

Closing as duplicate, please see response to #643. Feel free to discuss this.


GA release

GA release of the Elastic distro of the OTel Java SDK/API/Instrumentations

Don't forget to create the 1.0.0 release and remove the tech preview comment

Also note the List of config options in configure.md that are available from the agent but not the upstream agent needs to be filled out

https://github.com/elastic/elastic-otel-java/releases/tag/v1.0.0


Always show MMA logo in header

This was currently not shown on mobile, William has requested that it's always shown. We have to adjust some margins to make it work.

@xybrnet

:+1:


custom/external formatting toolbar?

Hello!
Great work on ink-mde!
I'm currently integrating it into a React Native project, which loads ink-mde inside of a webview.
Since this will be used on mobile devices, I'd like to create a custom formatting toolbar as an InputAccessoryView on the keyboard.
This makes me wonder: how can/could I externally control formatting options in ink-mde? Is it currently possible to do that?

Hey @tconroy! Thanks so much. I can always export the toolbar as a separate component, but you might need something a bit more custom in the InputAccessoryView doesn't run in the same JS context as the editor itself. Do you know if that's the case?

Hey @davidmyersdev! Yes I believe that is the case.
React native let's you pass messages from the host app to web views via the postMessage API. So I can serialize commands back and forth between the two, as long as they're serializable via strings.
I think what would be most useful for my use case is for the editor to expose callbacks to perform the various editor actions (ie bold, italic, insert list, etc). Then I can just associate each callback to an "event" that my host RN app is sending through postMessage.

In that case, I think you can already do what you are looking to do. The returned instance has a format method on it that formats the current (or given) selection. Hopefully this demo helps. 😄
https://stackblitz.com/edit/davidmyersdev-ink-mde-uyu9gq?file=src%2Fmain.ts,index.html,tsconfig.json


.leaflet-yandex-layer position absolute

<EMAIL_ADDRESS><EMAIL_ADDRESS>Yandex Layer container hide containers of plugins like
https://github.com/w8r/Leaflet.Modal
or
https://github.com/Turbo87/leaflet-sidebar
Example
https://jsfiddle.net/rendrom/v7ctukak/2/
fix
https://jsfiddle.net/rendrom/v7ctukak/3/
.leaflet-yandex-layer {
  position: absolute;
}

No issue after #285
https://jsfiddle.net/johnd0e/9jwf8yeh/

Can be closed since #285 is merged


onReachabilityChanged event never called

I used the adapted sample code but onReachabilityChanged never called...

This project doesn't seems active.

Well this is a dependency for cordova-admob, it's intention was never to be used as itself, but we can take a look on it.

Which platform are you using? Also there was a typo in the example, see https://github.com/appfeel/connectivity-monitor-cordova/pull/7

@miqmago does this library actually work? I have not managed to get an actual event when toggling WiFi on/off

It was working with ios 9, haven't tested in ios 10. Don't have plans to test it in near future. If you can debug it in XCode, contributions are really welcome.

@miqmago I needed something quickly so ended up using a different library, which seems to be working fine.

nothing is working :( this plugin had great potential. none on the market does what it does. too bad it was left like this. the onReachabilityChanged never gets called niether do the success or error functions passed to observeRemote[...] functions. hope it gets resolved soon

As @goliatone said, there is an official plugin from cordova, so this one will no longer be maintained. Please use official one, which does mostly the same


extentions for home assistant persons are not created

extentions for home assistant persons are not created
I can't find any sensor.asterisk_extension_
I have rebooted everything
This my config:
video_support: false
auto_add: true
generate_ssl_cert: false
certfile: fullchain.pem
keyfile: privkey.pem
mailbox: false
mailbox_port: 12345
mailbox_extension: '100'
log_level: notice
ami_password: SECRET

For the sensors you need the Asterisk integration. You can check every extension it creates in /config/asterisk/pjsip_default.conf.

Will close now. Let me know if you are still having this problem.


Videoanalysis settings in UI different than reported via logs

Describe the bug
The only way to set videoanalysis settings is via the UI, where I set the Reset Motion After to 0. However, in the homebridge UI logs, I see that "forceclose" is set to 3m, different from my configuration in the UI (I have confirmed the settings were saved, and when I close an re-open the camera.ui and navigate to the settings, it remains set at 0 on the slider). Additionally, the motion is reset forcibly after 3 minutes of detected motion. I also notice that while I have the sensitivity setting set to 90, its reported as set to 91 in the log.
To Reproduce

Enable Video Analysis
Set the Reset Motion After setting to 0
Set the Sensitivity setting to 90
Save
Restart Homebridge
View the logs from the homebridge UI or elsewhere and see that settings are different

Expected behavior
When I set the Reset Motion After slider to 0, the configuration should mirror that.
When I set the Sensitivity slider to 90, the configuration should mirror that.
Logs
[6/17/2022, 12:58:48 AM] [CameraUI] VIDEOANALYSIS: New message: Data: [{"zone":"region0","percent":10.33506965637207,"sensitivity":91,"dwell":90,"forceClose":3}] - Motion: detected - Camera: Master Bedroom
[6/17/2022, 12:58:48 AM] [CameraUI] Master Bedroom: Motion ON
[6/17/2022, 1:01:48 AM] [CameraUI] VIDEOANALYSIS: New message: Data: {"time":"2022-06-17T01:01:48.640Z","event":"forceClose (3m)"} - Motion: resetted - Camera: Master Bedroom
[6/17/2022, 1:01:48 AM] [CameraUI] Master Bedroom: Motion OFF
[6/17/2022, 1:01:49 AM] [CameraUI]  WARNING  Master Bedroom: The recording process has been running for 3 minutes and is now being forced closed!

Screenshots

Environment

Node.js Version: v16.15.1
Homebridge Version: v1.4.1
Camera UI Version: v5.0.27
Operating System: Centos 8 Stream
Browser: Firefox

@seydx Can you clarify whether the wontfix label is accurate?

@seydx, Any updates for this Issue?

@seydx Any updates?

@seydx ^

I have the same issue

In Camera.Ui Interface i have the motion detection on 85. Reset motion is on 0.
[28/08/2023, 08:16:59] [CameraUI] Auffahrt: Configuring unbridged accessory... [28/08/2023, 08:16:59] [CameraUI] Auffahrt: Setting up accessory... [28/08/2023, 08:16:59] [CameraUI] Eingang: Configuring unbridged accessory... [28/08/2023, 08:16:59] [CameraUI] Eingang: Setting up accessory... [28/08/2023, 08:16:59] [CameraUI] Accessories refreshed and config.json saved! [28/08/2023, 08:16:59] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge 7276) is running on port 51164. [28/08/2023, 08:16:59] Auffahrt 1626 is running on port 33349. [28/08/2023, 08:16:59] Please add [Auffahrt 1626] manually in Home app. Setup Code: 211-28-303 [28/08/2023, 08:16:59] Eingang 3737 is running on port 44457. [28/08/2023, 08:16:59] Please add [Eingang 3737] manually in Home app. Setup Code: 211-28-303 [28/08/2023, 08:17:05] [CameraUI] Auffahrt: Setting up camera, please be patient... [28/08/2023, 08:17:05] [CameraUI] Eingang: Setting up camera, please be patient... [28/08/2023, 08:17:08] [CameraUI] camera.ui v5.0.27 is listening on port 8081 (http) [28/08/2023, 08:17:14] [CameraUI] VIDEOANALYSIS: New message: Data: [{"zone":"region1","percent":19.044605255126953,"sensitivity":82,"dwell":60,"forceClose":3}] - Motion: detected - Camera: Auffahrt [28/08/2023, 08:17:14] [CameraUI] Auffahrt: Motion ON [28/08/2023, 08:17:15] [CameraUI] VIDEOANALYSIS: New message: Data: [{"zone":"region0","percent":19.421545028686523,"sensitivity":82,"dwell":60,"forceClose":3}] - Motion: detected - Camera: Eingang [28/08/2023, 08:17:15] [CameraUI] Eingang: Motion ON [28/08/2023, 08:20:14] [CameraUI] VIDEOANALYSIS: New message: Data: {"time":"2023-08-28T06:20:14.549Z","event":"forceClose (3m)"} - Motion: resetted - Camera: Auffahrt [28/08/2023, 08:20:14] [CameraUI] Auffahrt: Motion OFF [28/08/2023, 08:20:14] [CameraUI] VIDEOANALYSIS: New message: Data: [{"zone":"region0","percent":16.272024154663086,"sensitivity":85,"dwell":60,"forceClose":3},{"zone":"region1","percent":21.248550415039062,"sensitivity":80,"dwell":60,"forceClose":3}] - Motion: detected - Camera: Auffahrt [28/08/2023, 08:20:14] [CameraUI] Auffahrt: Motion ON [28/08/2023, 08:20:14] [CameraUI]  WARNING  Auffahrt: The recording process has been running for 3 minutes and is now being forced closed! [28/08/2023, 08:20:16] [CameraUI] VIDEOANALYSIS: New message: Data: {"time":"2023-08-28T06:20:16.130Z","event":"forceClose (3m)"} - Motion: resetted - Camera: Eingang [28/08/2023, 08:20:16] [CameraUI] Eingang: Motion OFF [28/08/2023, 08:20:16] [CameraUI]  WARNING  Eingang: The recording process has been running for 3 minutes and is now being forced closed! [28/08/2023, 08:20:16] [CameraUI] VIDEOANALYSIS: New message: Data: [{"zone":"region0","percent":18.07600212097168,"sensitivity":83,"dwell":60,"forceClose":3}] - Motion: detected - Camera: Eingang [28/08/2023, 08:20:16] [CameraUI] Eingang: Motion ON [28/08/2023, 08:20:24] [CameraUI] Eingang: Closing recording process [28/08/2023, 08:20:24] [CameraUI] Eingang: Motion OFF [28/08/2023, 08:20:24] [CameraUI] Auffahrt: Closing recording process


setting up testing for both preview and GA API versions for AOAI

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3559610&view=results

/check-enforcer override

/check-enforcer override


NMstate warning update

I'll raise as a PR shortly, but adding here for visibility.
Some attendees didn’t understand/notice the note about the host network (bridge) being pre-created (br-flat) so used a custom name when creating their network attachment definition (or simply had a typo). This leads to a state where the machine can’t start as it can’t find the bridge named on any node (as it does not exist). The current warning is not all that clear to those with intro knowledge to OCP and networking so I'd propose to make it clearer.
OLD:
"Due to time constraints, the host network has already been configured in this lab. If you want to learn more about the host networking, along with how to view and manage the configuration, please use the NMState documentation found here."
PROPOSED:
"A network attachment definition instructs openshift to utilise an existing network device. In our case that device was previously created and is named br-flat. You must use that name or OpenShift won’t be able to place your VM on one of the compute nodes as it must find compute nodes with that specificaly named network device on it.
You use an operator called NMState to create network configurations on OpenShift nodes. You can create interfaces with any naming to suit your needs and network requirements. For more info about NMstate see the documentation or speak with your lab proctors."

PROPOSED:
"A network attachment definition instructs openshift to utilise an existing network device. In our case that device was previously created and is named br-flat. You must use that name or OpenShift won’t be able to place your VM on one of the compute nodes as it must utilise nodes with that specifically named network device on it.
To manage an OpenShift node's network configuration you use a tool, available as an operator, called nmstate to create. With nmstate can create interfaces using Kubernetes constructs on your OpenShift compute nodes. You can do this following any naming that suit your needs and network requirements. For more info about nmstate see the documentation (nmstate) or speak with your lab proctors."

PR has been merged so this issue being closed.


Spark 2 support for arrays of complex objects

Currently test should("handle arrays of generics") is skipped on Spark 2 cause it fails.
Arrays of generics may be useful when working with, for example, JSON data, where deeply nested arrays can be found.
Reproducer test: https://github.com/JetBrains/kotlin-spark-api/blob/21e4fdc4be9959782710c5185d9bf74f2dcb8998/kotlin-spark-api/2.4/src/test/kotlin/org/jetbrains/kotlinx/spark/api/ApiTest.kt#L143-L151

Closing this since we don't support Spark 2 anyways anymore


How to specify SSL options?

Charlie and contributors: keep up the great work 😉
Finally I have an SQL scratchbook that I can share with the colleagues and store in the version control.
This issue is a little bit different but similar to the SSL settings, so I am adding it as a comment.
The Azure SQL connection requires the "encrypt" flag to be set to True. I could not find a way to tell the SQL Notebook connection manager to enforce the "encrypt" flag. This results in following error: Error running command sqlnotebook.connect: Server requires encryption, set 'encrypt' config option to true.. This is likely caused by the extension that contributes sqlnotebook.connect.
Hopefully there is an easy way to add Encrypt=True to the connection string

Thanks @navimondo! Glad you're finding it useful.
I'm working on abstracting the configuration webview form to generic driver configurations so we can solve this problem categorically for all drivers and all configuration options in a clean way. In v0.3.0, you'll have the ability to set encrypt: true through a checkbox when creating new connections.

Implemented a quick and dirty workaround by editing the "driver.js" file
...\.vscode\extensions\cmoog.sqlnotebook-0.2.0\out\extension\driver.js
By changing the encrypt argument to true the driver connects 😮

Thanks for giving us an easy to customize database status dashboard.

The configuration option for mssql is now available in v0.3.0. I've opened a follow-up issue for the remaining drivers #14


Add sample using Spark streaming with Changefeed to copy data of a collection into various targets (another Cosmos collection, parquet files in data lake, Delta table (Databricks), Kusto)

Part of this complete with this sample: https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/cosmos/azure-cosmos-spark_3_2-12/Samples/DatabricksLiveContainerMigration


escape key does not bind on Safari

neither 'escape', or 'esc' work on Safari. However, they work perfectly on Chrome and Firefox. Anyone else seeing this issue?

false alarm, the issue was because I was using Vimium on Safari
https://stackoverflow.com/questions/35352918/key-events-are-not-raised-when-escape-key-is-pressed-on-a-focused-element


local installation: module not found

Hi,
my system:

npm version 6.9.0
node version 10.15.3
node-red version 0.20.5

I installed you package locally, so npm list --depth=0 returned:
/home/TSTinst/node-red +--<EMAIL_ADDRESS>--<EMAIL_ADDRESS>My settings.config:
 adminAuth: require('node-red-contrib-ldap-auth').setup({                 uri:'ldap://ach-dc1.asistim.local',                 base: 'CN=myUser,OU=someOU,DC=someDomain,DC=local',                 filterTemplate: 'CN={{username}}'         }),
Now if I try to run node-red, I get an error that the module was not found:
node --max_old_space_size=512 /home/TSTinst/node-red/node_modules/node-red/red.js --userDir /home/TSTinst/node-red-data/ Error loading settings file: /home/TSTinst/node-red-data/settings.js Error: Cannot find module 'node-red-contrib-ldap-auth'
I thought, that I might need to perform install with --save option, but that's now the default option. Sorry for bothering you, but I'd really prefer to use this package locally instead of global.
Do you have any idea, what I might do wrong?
Thank you and best regards
pate

Found the issue. - Maybe others might have the same problem:
If you set your userDir at a different location, the require's relative path will be the directory, where settings.js is located.
So either use an absolute path or in my case, the following relative path worked:
adminAuth: require('./../node-red/node_modules/node-red-contrib-ldap-auth').setup({
Cheers
pate


[MINOR][PYSPARK][EXAMPLES] Changed examples to use SparkSession.sparkContext instead of _sc

What changes were proposed in this pull request?
Some PySpark examples need a SparkContext and get it by accessing _sc directly from the session.  These examples should use the provided property sparkContext in SparkSession instead.
How was this patch tested?
Ran modified examples

cc @davies , I think it is better for the examples to show users to get the SparkContext through this property, rather than accessing _sc directly.  Do you agree?

Test build #59294 has started for PR 13303 at commit aaeb810.

LGTM

Test build #59294 has finished for PR 13303 at commit aaeb810.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59294/
Test PASSed.

Merged build finished. Test PASSed.

Merging this into master and 2.0, thanks!

wow, you are fast :)
Thanks!


Feature: as un admin, edit step of a request workflow.

After completing a step 2 on a request, one of the fielf was wrong. In the logs:
ERROR 2024-04-26 17:13:40,098 job Error launching job openshift-project-create, response was :{"variables_needed_to_start":["Value None for 'rwx_storage' expected to be an integer."]}

Durring the "admin" review we missed that this field was wrong and approve the request which is placed in failed state direcly

The edit button on top right corner only give access to the "user survey" or the "admin survey". But approval steps survey are not shown and so cannot be edited.

In this code we have this order when getting the form:

First Form (end user provided)
Admin form
Approval Step form

It means that the admin does't have the last word before processing a request.
But we have anyway the "accept" buton that allow to update the final form. But it's not taken in account because of the order.
From what I see we have two solution

Remove the "review button" form the last admin step (and so as an admin if we always want to have the last work we need to always add a last step to each workflow)
Keep the button and change the order of applied field update to have first form --> approval step form --> admin form

Done and available starting version 2.6.0


Using this dataset

Dear sir
May I  use your dataset for classification research?
I may publish a paper, but I will cite your article in the paper.

Yes, you can use the X-SDD dataset.
At 2021-12-24 12:13:31, "zhuangzhuanghao" @.***> wrote:
Dear sir
May I use your dataset for classification research?
I may publish a paper, but I will cite your article in the paper.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Thank you for your permission.
I really appreciate it.


Display logged time instead of static label

It could be nice to have timer button to show logged time (e.g. "2:15") instead of currently static "(Logging)" label.

Good idea, I like it.


improve large tree performance in defaultEquality

This should fix #10 and fix #18, and should address performance issues on larger trees. On my test tree of 3000+ nodes, defaultEquality and angular.copy inside of it were the biggest loads on the CPU in the profiler.
This was especially problematic since we were be making deep copies of the entire object and then throwing away the childrenNodes just to compare the parent - for a top level folder with many nested subfolders, we were doing a lot of work for little gain :(
Angular.copy was changed from 1.2 to 1.3 which may have contributed to this issue.
https://docs.angularjs.org/api/ng/function/angular.copy
https://docs.angularjs.org/guide/migration
https://github.com/angular/angular.js/commit/b59b04f98a0b59eead53f6a53391ce1bbcbe9b57
the code change was found in stidges's fork: https://github.com/stidges/angular-tree-control/blob/23bafaad7a58b76d581f1a02eda48e34e8100b98/angular-tree-control.js#L49

based on your fix, I have implemented another solution using angular shallowCopy which has a significant impact.

awesome, thaaanks!


Deprecate MergePatch and add additionalProperties: true

Deprecate MergePatch in OpenAPI 3.0
Add explicit additionalProperties: true to MergePatch for better code generation

https://github.com/belgif/rest-guide/issues/189

reviewed by WG, OK to merge


environment list issues after user clicks on recent activity item

STR
See attached video
https://drive.google.com/file/d/1k2T9lgv74NMtH4dEK1EGlUI6ay-5dBM1/view?usp=share_link
please download the file and run it
I think that the main issues start because the 2 environment lists are not synced, please consult with @MykolaYaremchuk

looks like combobox is not notified about the clicked env event, this issue can be related to memory leak fix


Adds definition of messaging annotations

Per https://github.com/openzipkin/zipkin/issues/1654
Notably, this also says messaging spans should never share a span ID.
This is in support of the simplified model known as span2 which will
use span.kind=PRODUCER|CONSUMER to accomplish the same. We
are mapping back to annotations because most instrumentation and
storage will need to for a while.
cc @jcarres-mdsol @ImFlog @devinsba @dgrabows @lijunyong @marcingrzejszczak @sslavic @mbogoevici @hammett

here's the corresponding server code work in progress https://github.com/openzipkin/zipkin/pull/1677


ModuleNotFoundError: No module named 'vdf'

Hi, is it just me or for some reason ETS2 Lane Assist doesn't work when I launch it
I tried doing pip install vdf but nothing worked.
OS: Windows 11 22H2 Build 22621.2715
ETS2 Version: 1.49
Lane Assist Version: 1.6.0 7983911
If anyone knows how to fix this and get it working, it would be greatly appreciated. 😄

Hello, If you don't mind joining the discord. We may be able to provide better support there

Thank you for the fast reply. Sure, I'll check it out

Closed as not active


How do I change file location of Chatterbot_corpus data?

Hi, I have developed my own UI for creating Q&A for chatterbot_corpus data. I can test chatterbot responses also. They are working fine.
Now when i create Q&A from my project, the YAML files will be stored in location "C:/Python27/Lib/site-packages/chatterbot_corpus/data/english/". For the simplicity of my project, I want to move it into my project folder so that I don't have to use absolute path, but using relative path instead. Can I do it?

@nanda248 Yes, you could, Read this documentation  will guide you how to configure.
chatterbot.train(
    "./data/greetings_corpus/custom.corpus.json",
    "./data/my_corpus/"
)


CASMTRIAGE-6127: prerequisites.sh: Update csm-config earlier and wait for import to complete

Description
On fanta the csm-config import job failed and worked when I manually retried it. I believe the failure was caused by the gitea postgres pods not being ready at the time when it tried to do the import. This PR moves the csm-config update earlier in the prerequisites script (before any postgres stuff happens), and then wait for the csm-config import job to succeed before proceeding. This job usually finishes quickly (within a few minutes), so this should not introduce a significant delay.
I tested the updated prerequisites.sh script on fanta and validated that it worked as expected.

Checklist

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[X] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[X] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.6 release/1.4 release/1.3

/backport release/1.6


Auto-detect projects configuration

For very simple project structures, it would nice to have digger.yml-less flow. Digger could traverse repo and guess project structure and auto-generate configuration

I think the basic implementation here was implemented in #444 I'm going to close this for the time being


First working TI collection stack (HUB) - a DB that can ingest the DataModel and display it to Human in intellegible way

Initial POC idea to get the data model demo'd by @joseftaha into neo4j using the python library is here: https://github.com/k8sstormcenter/threatintel/commit/e29ee468e258324f615a08452f544032f3e2a2fe


Build breaks on Travis CI because of pub get issue

Tracked upstream at https://github.com/dart-lang/pub/issues/1750. Not much can be done besides manual deployments until this is resolved.

https://github.com/dart-lang/pub/issues/1750 appears to be fixed in the latest 2.0.0-dev.23 SDK version… 😄
Successful build: https://travis-ci.org/4cm4k1/website/jobs/340793368


Improve docs on SpannerWriteResult.

Add a note to SpannerIO javadoc that the output PCollection in SpannerWriteResult will only
work in Batch pipelines...
@chamikaramj
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Thanks. I'll go ahead and merge. But we could deprecate/update the feature as needed. Might make sense to bring this up in Beam dev list.


Boot options

This changeset add boot options to the installation configuration. Also slightly extends the current tests to check back if the parameters was set.
A bit outside of context, adds bundles.JoinImage to join several images into one. this is in the broader context to provide image mutation capabilities.

Codecov Report

Merging #91 (58f82f9) into master (3223a0b) will decrease coverage by 1.51%.
The diff coverage is 25.53%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   41.34%   39.83%   -1.52%
==========================================
  Files           5        6       +1
  Lines         445      472      +27
==========================================
+ Hits          184      188       +4
- Misses        239      258      +19
- Partials       22       26       +4

Impacted Files
Coverage Δ

pkg/config/config.go
53.71% <ø> (ø)

sdk/bundles/bundles.go
35.55% <0.00%> (-1.78%)
:arrow_down:

sdk/bundles/create.go
28.57% <28.57%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Passing tests, merging


Update ospec to ignore hidden directories

Motivation: When using ospec on Cloud9, a difficult-to-diagnose error shows up with "SyntaxError: Unexpected token :"  because ospec is trying to parse metadata about the tests files (like undo information) that is stored under .c9/metadata with the exact same file path and names as the edited files have (e.g. workspace/tests/hello.js).

Meant this for the original repo!


Exact alias match does not appear in search results

I'm trying to look up "KONOSUBA -God's blessing on this wonderful world!", which is the show's official title on Crunchyroll. This title exists as an alternative name on TMDB and it's returned by /shows/konosuba-god-s-blessing-on-this-wonderful-world/aliases.
But searching for this exact title does not return the show.
/search/show?query=KONOSUBA%20-God%27s%20blessing%20on%20this%20wonderful%20world! returns only different shows with low scores (< 2) and I couldn't find the show in the first couple of pages on the website's search.
What's going on? If I search for a title that has an exact match with an alias, shouldn't that show appear at the top of the results?

We bump it to the top if the main title is an exact match. It should still move it higher if an alias is an exact match as well, but seems to not be. I am also wondering if the punctuation -! is preventing the match. Do you have another examples without punctuation? I'm curious if that returns the correct results or not.

It seems the -God is interfering with an exact match, maybe it's interpreted as an exclusion?
Removing the other punctation doesn't have an influence. Removing the dash or adding a space after it returns the correct match.
It seems quoting the title also works. This search returns the correct match.
Do you have more information on how the search works and which patterns it treats differently?
The way things are now, I'd probably have to do a quoted search first and then fall back to regular search and strip out any characters the have a special meaning in the query.

We use Solr for all searching and yeah it looks like - character is what is causing this issue. If the - is the middle of word I don't think it does this behavior, but since there is a space before it in  -God it is treating it as an exclusion.

Prohibits the following term (that is, matches on fields or documents that do not include that term). The - operator is functionally similar to the Boolean operator !. Because it’s used by popular search engines such as Google, it may be more familiar to some user communities.

Thanks for the details!
It seems I need to escape all the special characters:

Solr gives the following characters special meaning when they appear in a query:
+ - && || ! ( ) { } [ ] ^ " ~ * ? : /
To make Solr interpret any of these characters literally, rather as a special character, precede the character with a backslash character \.

It would be great if you could mention this in the API documentation, as it is quite useful to know what the query supports and what we need to watch out for.

Thanks for confirming and yes great idea to add this to the docs. I just updated that.
https://trakt.docs.apiary.io/#reference/search/text-query


Raise exceptions instead of using assertions for control flow

Motivated by https://github.com/huggingface/transformers/issues/12789 in Transformers, one welcoming change would be replacing assertions with proper exceptions. The only type of assertions we should keep are those used as sanity checks.
Currently, there is a total of 87 files with the assert statements (located under datasets and src/datasets), so when working on this, to manage the PR size, only modify 4-5 files at most before submitting a PR.

Adding the remaining tasks for this issue to help new code contributors.
$ cd src/datasets && ack assert -lc

[ ] splits.py:4
[ ] commands/convert.py:1
[ ] arrow_reader.py:3
[ ] load.py:7
[ ] utils/patching.py:1
[ ] utils/py_utils.py:2
[ ] features/features.py:9
[ ] arrow_writer.py:7
[ ] data_files.py:1
[ ] search.py:6
[ ] table.py:1
[ ] metric.py:3
[ ] tasks/image_classification.py:1
[ ] arrow_dataset.py:17
[ ] fingerprint.py:6
[ ] io/json.py:1
[ ] io/csv.py:1

Hi all,
I am interested in taking up fingerprint.py, search.py, arrow_writer.py and metric.py. Will raise a PR soon!

Let me look into arrow_dataset.py, table.py, data_files.py & features.py

All the tasks are completed for this issue. This can be closed.


Type 'T' does not satisfy the constraint '"url"' when using type parameter inside 'Pick'

TypeScript Version:  3.4.0-dev.201xxxxx

Search Terms: Type 'T' does not satisfy the constraint '"url"', Type 'T' does not satisfy the constraint.
Code
interface FormField {
    url: number;
}

// Error `Type 'T' does not satisfy the constraint '"url"'`
interface FormFieldMinMax<T = 'url'> {
    min: Pick<FormField, T>;
}

// No errors
interface FormFieldMinMax {
    min: Pick<FormField, 'url'>;
}

Expected behavior: No errors.
Actual behavior: An error Type 'T' does not satisfy the constraint '"url"' is shown.
Playground Link:  playground.

The constraint it is referring to is that the second argument to Pick must be a subset of the keys of the first argument. In this case your generic type T has no constraints so this would be valid:
FormFieldMinMax<{a:number}>
However you obviously can't pick {a:number} from the fields of FormField since that makes no sense.
You need to constrain T to be a subset of the keys in FormField:
interface FormFieldMinMax<T extends keyof FormField= 'url'> {
    min: Pick<FormField, T>;
}

Yea, it's a weird thing I didn't think about, thanks 👍


Control coordinate name inconsistent in DelayedSaturatedMMM

In DelayedSaturatedMMM, the axis for control variables is named "control_names" (see here). However, in the dims argument it is just referenced as "control" (here, here, and here).
Is this a bug?

Yes I think, it is!

Took the liberty to create a PR if you don't mind 😄

Took the liberty to create a PR if you don't mind smile

Not at all


Segmentation Fault in Darwin (macOS High Sierra 10.13.1)

Hello there!
Somewhere between the 0.5.0 release and the 0.6.0 release, something changed in the pre-built binaries that causes a segmentation fault in macOS. 0.5.0's release works great, but 0.6.0 and 0.6.1 have the same issue. Since it doesn't appear there were any relevant code changes between those releases, I suspect that a supporting package might have changed.
The following could be a red herring, but here's the output of dtruss when the fault occurs:

Click to expand
$ ❯ sudo dtruss -a ~/Downloads/git-commit-atom\ 2 .git/COMMIT_EDITMSG
dtrace: system integrity protection is on, some features will not be available

	PID/THRD  RELATIVE  ELAPSD    CPU SYSCALL(args) 		 = return
dtrace: error on enabled probe ID 2190 (ID 557: syscall::sysctl:return): invalid kernel access in action #11 at DIF offset 40
12825/0x22050f:      1370     909    904 mmap(0xC000000000, 0x8820002000, 0x0, 0x1002, 0xFFFFFFFFFFFFFFFF, 0x0)		 = 0xC000000000 0
12825/0x22050f:      1391       5      1 mmap(0x0, 0x40000, 0x3, 0x1002, 0xFFFFFFFFFFFFFFFF, 0x0)		 = 0x319000 0
12825/0x22050f:      1419       8      5 mmap(0xC820000000, 0x100000, 0x3, 0x1012, 0xFFFFFFFFFFFFFFFF, 0x0)		 = 0xC820000000 0
12825/0x22050f:      1422       4      2 mmap(0xC81FFF8000, 0x8000, 0x3, 0x1012, 0xFFFFFFFFFFFFFFFF, 0x0)		 = 0xC81FFF8000 0
12825/0x22050f:      1424       4      1 mmap(0xC000000000, 0x1000, 0x3, 0x1012, 0xFFFFFFFFFFFFFFFF, 0x0)		 = 0xC000000000 0
12825/0x22050f:      1427       3      1 mmap(0x0, 0x10000, 0x3, 0x1002, 0xFFFFFFFFFFFFFFFF, 0x0)		 = 0x359000 0
12825/0x22050f:      1439       4      0 gettimeofday(0x7FFEEFBFF640, 0x0, 0x2C66E0)		 = 0 0
12825/0x22050f:      1444       4      1 gettimeofday(0x7FFEEFBFF698, 0x0, 0x1)		 = -1 Err#14

CALL                                        COUNT
sysctl                                          1
gettimeofday                                    2
mmap                                            6

I pulled out an old mac and was able to duplicate the segfault. I recompiled the golang script on the mac and was able to run it without a segfault. I just updated the binaries available on the release pages with working copies. Not sure what the issue was (one of the linux binaries I tried worked just fine on my Elementary install) but hopefully this fixes it! Let me know if it works for you.

The updated binary works for me! Thanks for looking into it.


Add 'License.txt' to the METexpress repo

Replace italics below with details for this issue.
Describe the Task
Add 'License.txt' to the METexpress repo to define clearly/consistently define the s/w license we use, as described here...
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository
It's currently defined as Apache-2.0 in our documentation (e.g. https://github.com/dtcenter/MET/blob/main_v11.0/docs/Users_Guide/index.rst), but it might be wise to make it more front and center in the repo.
Existing license info can be found here:
https://met.readthedocs.io/en/latest/Users_Guide/index.html
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1/2 day of work.
Sub-Issues
Consider breaking the task down into sub-issues.

[ ] Add a checkbox for each sub-issue here.

Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
None
Assignee

[x] Select engineer(s) or no engineer required
[ ] Select scientist(s) or no scientist required

Labels

[x] Select component(s)
[x] Select priority
[x] Select requestor(s)

Projects and Milestone

[x] Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
[x] Select Milestone as the next official version or Future Versions

Define Related Issue(s)
Consider the impact to the other METplus components.

[x] METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Task Checklist
See the METplus Workflow for details.

[ ] Complete the issue definition above, including the Time Estimate and Funding Source.
[ ] Fork this repository or create a branch of development.
Branch name: feature_<Issue Number>_<Description>
[ ] Complete the development and test your changes.
[ ] Add/update log messages for easier debugging.
[ ] Add/update unit tests.
[ ] Add/update documentation.
[ ] Push local changes to GitHub.
[ ] Submit a pull request to merge into development.
Pull request: feature <Issue Number> <Description>
[ ] Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
[ ] Iterate until the reviewer(s) accept and merge your changes.
[ ] Delete your fork or branch.
[ ] Close this issue.

No branch was created for this commit.  It was done according to the Adding a License directions: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository


terraform: new CIS AMIs don't pass CIS profile

Signed-off-by: Steven Danna<EMAIL_ADDRESS>

@ryancragun Good call, updated


Wont work on Replit

Made by ♔ Dяεαмү アlαүεя ♔ With ❤
Need help? Join Our Discord
https://discord.gg/CNAJfbs5dn
Proxies
UP: 1
ALIVE: 1
DEAD: 0
[Launching] 200 checks, estimated time: 40m | Jun 9, 2024, 1:27 PM
[AUTO] grabbed 696 proxies.
[ETL] 3s Analyzed 2/200 [0] - continuing 198 codes
[ETL] 3s Analyzed 1/200 [0] - continuing 199 codes
[ETL] 4s Analyzed 3/200 [0] - continuing 197 codes
[ETL] 4s Analyzed 4/200 [0] - continuing 196 codes
And i cant stop the Code and there is "Reconnecting" i think it is a virus!

Replit employs a hot reloading mechanism, where it detects code modifications and restarts the application from the designated entry point (often "main.py" or similar), ensuring your server/app stays active during development. ~not virus~.


Add depedency manager and check for required plugins

See: https://github.com/DevNIX/Vagrant-dependency-manager

Updating documentation on wundertools gh_page is needed.
--skip-dependency-manager needs to be also documented to make clear there is a way t opt out from this behaviour.


Cannot find module<EMAIL_ADDRESS>

Description of the bug
How would you shortly summarise the issue?
I cloned the repo and yarn install.
I got an error in VSCode in apps/ejected/App.tsx : "Cannot find module '@acme/ui' or its corresponding type declarations."
but the code runs fine. Is it a repo problem or could it come from a local VSCode settings ?
Thanks.

Hi @GaspardC! I've seen this one before, it has many possible causes. What happens if you run yarn build at the root of the repository? It should build all files, just as you would submit a simple package to npm (with all files transpiled).

@GaspardC  please read the README at the start of this repo, there is a yarn build step that asks for in order to make packages available as @byCedric said. Worth to mention that maybe this should be only a production build step and in development we can go back to symlinks. Due we usually make changes a lot to packages and expect to trigger re-build when running expo start.

Hi @byCedric thanks for this very detailed explanation.
It was very instructive, wall of text very much appreciated 🙏✨

No problem! We are also drafting some documentation for monorepos in the Expo docs. Glad you found it helpful 😄


boards : nucleof412zg - CAN Internal controller

Signed-off-by: Pietro Bonazzi<EMAIL_ADDRESS>

Thanks for your contribution, please, split into at least 2 commits: one that defines new can device, 2nd for board modifications.
FYI https://static.sched.com/hosted_files/zephyr2022/a3/HOWTO_Get_Your_Zephyr_Patches_Merged_ZDS_2022.pdf

Thank you for your review . I have implemented the changes you requested.

Can you fix the issues reported here:
https://github.com/zephyrproject-rtos/zephyr/runs/6916504029?check_suite_focus=true
Also, check this https://static.sched.com/hosted_files/zephyr2022/a3/HOWTO_Get_Your_Zephyr_Patches_Merged_ZDS_2022.pdf, starting slide 21

Also take this opportunity to add the can2: can@40006800

Continue conversation in #49411


Cant run ionic cordova emulate android

What version of the CLI are you using? Output of ionic --version
3.0.0-beta10
Short description of the problem:
I got this error:
{ Error: Failed to transpile program
    at BuildError.Error (native)
    at new BuildError (/Users/Sam/Documents/BadenfahrtAPP/node_modules/@ionic/app-scripts/dist/util/errors.js:16:28)
    at /Users/Sam/Documents/BadenfahrtAPP/node_modules/@ionic/app-scripts/dist/transpile.js:137:20
    at transpileWorker (/Users/Sam/Documents/BadenfahrtAPP/node_modules/@ionic/app-scripts/dist/transpile.js:103:12)
    at Object.transpile (/Users/Sam/Documents/BadenfahrtAPP/node_modules/@ionic/app-scripts/dist/transpile.js:61:12)
    at buildProject (/Users/Sam/Documents/BadenfahrtAPP/node_modules/@ionic/app-scripts/dist/build.js:97:78)
    at /Users/Sam/Documents/BadenfahrtAPP/node_modules/@ionic/app-scripts/dist/build.js:47:16 hasBeenLogged: false, isFatal: false, name: 'Error' }

What behavior are you expecting?
The Emulator should start
Steps to reproduce:
Update cli
Package.json:
{
  "name": "ionic-app-base",
  "author": "Ionic Framework",
  "homepage": "http://ionicframework.com/",
  "private": true,
  "scripts": {
    "clean": "ionic-app-scripts clean",
    "build": "ionic-app-scripts build",
    "ionic:build": "ionic-app-scripts build",
    "ionic:serve": "ionic-app-scripts serve"
  },
  "dependencies": {
    "@angular/common": "4.0.2",
    "@angular/compiler": "4.0.2",
    "@angular/compiler-cli": "4.0.2",
    "@angular/core": "4.0.2",
    "@angular/forms": "4.0.2",
    "@angular/http": "4.0.2",
    "@angular/platform-browser": "4.0.2",
    "@angular/platform-browser-dynamic": "4.0.2",
    "@angular/platform-server": ">=2.2.1",
    "@ionic-native/core": "^3.6.0",
    "@ionic-native/in-app-browser": ">=3.5.0",
    "@ionic-native/splash-screen": "3.4.2",
    "@ionic-native/status-bar": "3.4.2",
    "@ionic/storage": "2.0.1",
    "angularfire2": ">=2.0.0-beta.5",
    "firebase": ">=3.6.1",
    "ionic-angular": "3.1.0",
    "ionic-native": ">=2.4.1",
    "ionicons": "3.0.0",
    "rxjs": "5.1.1",
    "sw-toolbox": "3.4.0",
    "zone.js": "^0.8.5"
  },
  "devDependencies": {
    "@ionic/app-scripts": "1.3.6",
    "typescript": "~2.2.1",
    "@ionic/cli-plugin-cordova": "^1.0.0-beta1",
    "@ionic/cli-plugin-ionic-angular": "^1.0.0-beta1",
    "@types/jasmine": ">=2.5.38",
    "cordova-plugin-device": ">=1.1.3",
    "cordova-plugin-fcm": ">=1.1.5",
    "cordova-plugin-mauron85-background-geolocation": ">=2.2.5"
  },
  "cordovaPlugins": [
    "cordova-plugin-firebase",
    "cordova-plugin-whitelist",
    "cordova-plugin-statusbar",
    "cordova-plugin-splashscreen",
    "cordova-sqlite-ext",
    "cordova-plugin-background-mode",
    "cordova-plugin-device",
    "cordova-plugin-network-information",
    {
      "locator": "https://github.com/driftyco/cordova-plugin-wkwebview-engine.git",
      "id": "cordova-plugin-wkwebview-engine"
    },
    "cordova-plugin-inappbrowser",
    {
      "locator": "https://github.com/litehelpers/Cordova-sqlite-storage.git",
      "id": "cordova-sqlite-storage"
    },
    "cordova-plugin-dbcopy",
    "com-sarriaroman-photoviewer"
  ],
  "cordovaPlatforms": [
    {
      "platform": "ios",
      "version": "",
      "locator": "ios"
    },
    {
      "platform": "android",
      "version": "",
      "locator": "android"
    }
  ],
  "description": "Badenfahrt 2017"
}

npm (global):
@ionic/cli-utils : 1.0.0-beta1
cordova          : 6.5.0
ionic            : 3.0.0-beta10

npm (local):
@ionic/app-scripts              : 1.3.6
@ionic/cli-plugin-cordova       : 1.0.0-beta1
@ionic/cli-plugin-ionic-angular : 1.0.0-beta1
Ionic Framework                 : ionic-angular 3.1.0

System:
Node       : v6.9.1
OS         : macOS Sierra
Xcode      : Xcode 8.3.2 Build version 8E2002
ios-deploy : 1.9.0
ios-sim    : 5.0.11

Does it work with CLI 2.2.3 or is this a problem with your project?

it was working yesterday with cli 3.0 and this morning it has given some updates and now it is broken this is what i have updated:
npm install --save-dev @ionic/cli-plugin-cordova@beta @ionic/cli-plugin-ionic-angular@beta

Okay the transpile error was because of my.. and now it cant find ionic-native

You have two versions of Ionic Native in your package.json:

"@ionic-native/core": "^3.6.0",

and

"ionic-native": ">=2.4.1",

You probably want to get rif of the older one.

Hmm okay i have edit my package json.. deleted the node modules dir and have run npm install..
after this i have that error: Module not found: Error: Can't resolve 'ionic-native'

Then you haven't updated all your Ionic Native imports to 2.4.1 yet. Look at the current documentation what it should look like.

👍


How do you change theme colors in typescript ?

How do you change theme colors in typescript ? Do you have anything implemented for that yet?

I don't think that there is a native material solution for this, but you can change the css variables that are used in background:
document.documentElement.style.setProperty('--mdc-theme-primary', '#123456');
document.documentElement.style.setProperty('--mdc-theme-primary', '#234567');

But this will only work in Chrome, Firefox and partially in Edge.
Source: https://davidwalsh.name/css-variables-javascript


.mp4 and .webm extensions could be audio or video

Another method should be added to handle these cases.
References:
http://voice.firefallpro.com/2012/03/html5-audio-video-mime-types.html
http://www.iana.org/assignments/media-types/media-types.xhtml

This is true, but this project is primarily a mapping from extension to mime type. It's not possible in this setup to map a single extension to multiple mime types, so the most common is used.
A cross reference mapping of all possible mime types to all possible extensions would be interesting but would lose value for programmatic use.
Happy to accept alternative suggestions though.
Thanks for the input.
Sam

But my issue is related exactly to this primary goal: given the extension .mp4 I currently always get video/mp4, but this extension as a matter of fact could be used for audio/mp4 (as found on Facebook Messenger Platform Webhooks).
I first (naive) suggestion would be to add another method (like GetAllMimeTypes), returning an array of strings.

Usually you use the mapping when sending a stored file to the client in the content-type response header. What would you do with multiple possible mime types?
I'm happy to accommodate if reasonable, but I don't see the follow through to your request working toward your end goal (which I'm assuming.. what exactly are you doing?).
Thanks,
Sam

Sorry by the lack of details. I am integrating with Facebook Messenger Webhook where messages with media are sent with 2 properties only: a type (which could be image, audio, video or file) and an uri.
Previously I was just extracting the extension from this uri and applying to MimeTypeMap.GetMimeType in order to get the mime type for further processing - which is essentially the same scenario you described as the usual mapping situation. But I have received audio files with .mp4 extensions, which at this time return video/mp4 mime type by MimeTypeMap.
If MimeTypeMap could return both types all I will have to do is to check if the return has more than 1 mime type, and if so just match the type part with the one sent on Facebook's webrequest to continue with the correct mime type.
To handle this exceptional case I have added a specific check for mp4 extensions. It works, but it will be much more concise delegating all the mapping to only one place/component.
Regards.

Thanks for explaining. Your situation does make sense in how multiple types would be useful. I don't think it's a very common one that I think would complicate the mime-map dictionary if I tried to accommodate.
I'd suggest implementing something within your own project to handle this specific situation, or create your own fork of this project and make whatever changes are needed to support your needs.
Thanks for following up. Interesting.


Created some fixes for issues I was having with the total DPS.

Can merge if you want :)

I see you found my fork lol. I meant to take some time to work with it a little more and submit a pull request to you but never got to it. I'll close out my fork. Glad you found the addition useful!

Yeah, any help is welcome.
I was also working on swings per attack but it's currently bugged if you check per skill.
Haven't been able to get it working properly yet.
If you have any ideas to get it working let me know.
Or any other additions, I still want to update this but my limited LUA knowledge makes me a bit slow :)


Custom search filtering algorithm

Can we implement a custom search filtering algorithm? I would like to use fuzzy search, however this is not the only possible filtering option.
As far as I understand, changes need to be made here. And apparently we could normalize search.value once.
https://github.com/vueform/multiselect/blob/50ea5dcae01b75b484fbe8a915fa76d8a9479d41/src/composables/useOptions.js#L514-L520

https://github.com/leeoniya/uFuzzy#a-biased-appraisal-of-similar-work

Added searchFilter option to allow customised search algorithm in 2.6.0.

Could you provide example? This doesn't seem to be documented well.

It seems that this is done in the filterOptions function in useOptions composable.
    fo = fo.filter(filter)

Bummer, there's no current value of search input available, so you really have to implement everything yourself. I'll see if I can find some time for a PR. @adamberecz you think it's a good idea or isn't it an appreciated feature?


The Coursier Metals Requirement

Hi,
If possible, I'd like to understand the requirement to install Metals via Coursier.
I managed to get Zed working with Scala briefly and thought the Metals integration was great! It didn't last long though.
Using Coursier is awkward for me because I tend to use Nix for a lot of tooling set up, and it seems the two don't work well together.
I don't want to get into the details of my exact set up (work machine), I'm just wondering if Coursier does something special that we could replicate via other installation methods? Or if the extension could be made more generally compatible?
Thanks!

Downloading arbitrary binaries from the internet, putting them in random places on the system, and executing them is the number 1 security fuck-up since decades. More or less all security incidents start like that. It was one of the worst ideas ever to download and run setup.exe already 30 years ago, and it still is!
Since people started to do the same bullshit on Linux we start to get all the same malware problems they have on macOS and Windows, where it's since inception "normal" to download and run setup.exe fuck-up.
The problem is the JVM ecosystem. They don't care. They made distributing binaries even core to package management, "just trust me bro" style. And Scala being Scala did adopt all of the worst parts from Java. That's the real issue here.
I hope Scala liberates itself at some point from this insanity.
(Nothing about binary packages as such. They make a great cache. At least in case you have in place proper reproducible builds and a fully transparent build pipeline which starts form source).

@davesmith00000 totally missed you message. You should be able to set COURSIER_CACHE per workspace to point to the local workspace (though it will duplicate a lot of jars for a lot of projects) but this would be more in line with how Nix works.
@SlowBrainDude I would try and refrain a bit with the comments, there is plenty of reason why things are working as they are currently and no need to criticise other people's work in this manner.
Building everything from sources and having fully reproducible builds can easily turn into nightmare for people and is not feasible on all possible configurations. Each approach has its issues, though there is no actual security issue here. Jar are not really binaries that can be run on their own, you still need to do that via java. The biggest issue is that caches could break or users might not be fully aware where their artifacts are. Source dependencies would not solve any security problems if users choose to run something themselves.


publish on npm?

not currently on npm. we could improve the packaging exports and all but for starters, maybe bump the minor version and give it a unique name for npm like... "matchmedia-polyfill"?

Absolutely. Do you think shipping it as a UMD would be a good idea to tackle different consumers?

That part I'm not sure about. This script is often inlined so, we'd just want to make sure it can still expose on window object by default as well, without a packager. Agree? Maybe worth another pass for this part...

Absolutely, that's why I suggested the UMD pattern, which gracefully degrades to the global window object if no AMD module load is defined.

cool. might you have any time to work out a PR? If not I'll work on it at
some point here. Thanks!
On Mon, Jan 4, 2016 at 11:18 AM, Kai Dorschner<EMAIL_ADDRESS>wrote:

Absolutely, that's why I suggested the UMD pattern, which gracefully
degrades to the global window object if no AMD module load is defined.
—
Reply to this email directly or view it on GitHub
https://github.com/paulirish/matchMedia.js/issues/66#issuecomment-168721566
.

I'll try my best and implement this stuff with the https://github.com/umdjs/umd/blob/master/templates/commonjsStrict.js template. brb

#68 there you go.

Is skipped the commonJS wrapper for now, since this is mostly used in a Node environment - where matchMedia makes no sense. Or do I sth here?

Thanks @krnlde
Looks nice. I think I'll merge PR 67 since it doesn't change the code any, and leave this open for discussion after that.

Can someone add some install/usage details to the readme? I'm not entirely sure where/how this poly get used.  If I install via npm... .then do I simply...
import 'matchmedia-polyfill' at the first line of my application? what about other dependencies that might need it.
Why does the readme say "Used in: Modernizr" ? I'm including modernizr already..... do I have to include options.mq? Assuming that is where Modernizr is using it?  I've tried including the whole modernizr.min from cdn and still in IE9 if I window.matchmedia I get nothing back

The package.json states that there are no other dependencies.
You should be able to just import 'matchmedia-polyfill' in your repo. Did you try it before writing?

Yes. Still not working.
Either way, the readme docs could still use more detail. Especially considering that they said its used in Moderizr. I mean, I'm using Modernizr already, does that mean I don't need to include this directly? Which is contradicted but the Moderizr docs which make it look like the Modernizr.matchMedia can be polyfilled by including (this yet to be included) polyfill.
So between it not seeming to work in the simple expected way, and the documentation, its easy to loose a few hours to this. Just thought updating the readme might pay it forward.
Any ideas why my personal case is not working?

I "think" I know what the issue is. When I look at exactly what line the browser is complaining about, it appears its coming from a dep of a dep. (enquire.js of react-slick);
So I think enquire.js is is being loaded into a vendor chunk and somehow being loaded before the poly is implemented? Either that or the poly is not being setup properly? When I go into IE9 inspector after everything is loaded... I would expect that running window.matchmedia would return something, however it does not.

I'm not sure what the window object really is in a node environment. Could be that browserify or whatever you use will prevent you from putting something in a non-existing context, i.e. window. In that case matchMedia should be appended to global instead of window object. Could you please try that in the node_modules/ code?

I'm not aware of doing anything special. I'm using webpack to build, with babel for es2015.
My expectation is that this polyfill would still update the window object, no? But as I said, it does not seem to be since IE9 does not have this property off window.
Is there a manual/inline way to include this poly just in a script tag or from a CDN? I feel like I'm missing something really basic here.

Webpack is there for putting npm (node) modules on the browser side. Since there is now window object in node, it is most likely not working.
You could manually add the matchMedia.js before your bundled JS file, like so:
<script src="path/to/matchMedia.js"></script>
<script src="yourWebpackBundle.js"></script>

Might also have something to do with it. However, I did figure out my issue.
Turns out that I was including the poly in with my webpack chunk bundle (vendor) AFTER the react-slick one.  Although, that does not make sense to me why a simple code allocation would cause code to render in an order.  I guess react-slick or dep has got code that runs at inlcude time rather then instantiation.
Either way, problem solved once the poly was moved to the top of the array.
module.exports = {
  entry: {
    app:[path.resolve(__dirname, 'app/app.js')],
    vendor: [
      'matchmedia-polyfill',
      "react",
      "react-dom",
      "react-router/lib/Router",
      "react-router/lib/browserHistory",
      "react-router/lib/Link",
      "react-router/lib/Route",
      "react-router/lib/IndexRedirect",
      "react-router/lib/Redirect",
      "react-bootstrap/lib/Navbar",
      "react-bootstrap/lib/Nav",
      "react-bootstrap/lib/NavItem",
      "react-router-bootstrap",
      "react-addons-transition-group",
      "classnames",
      "animation.gsap",
      "scrollmagic",
      "iscroll",
      "formsy-react",
      "lodash.throttle",
      "radium",
      "react-hammerjs",
      "react-iscroll",
      "react-portal",
      "react-select",
      "react-slick",
      "react-youtube",
      "vivus",
      "react-helmet",
      "modernizr",
      "TweenMax",
      "TimelineMax",
    ],
  },

published 2 yrs ago. https://www.npmjs.com/package/matchmedia-polyfill


[a11y]: Empty state accessibility violations

Package
@carbon/ibm-products
Browser
Firefox
Operating System
Windows
Package version
v2.53.0-rc.0
React version
No response
Automated testing tool and ruleset
Manual testing
Assistive technology
JAWS
Description

[ ] Heading level hierarchy is not maintained
Issue : Heading level hierarchy is not maintained
Recommended Fix : Hope  the "Empty State content block could be a  sub part of a  Main Header , as well as sub part of the Parent page :
Hence , expected to assign the Heading  Level  in accordance  to the  Parent page  Heading level structure .
Generic recommendation  for maintaining the Heading level hierarchy  : Well organised headings helps the user to quickly skim through the
page content and get an overview. Headings should be concise and reflect the content. It is a good practice to arrange headings in an
hierarchical order.
This issue is reported in all Variants of Empty State.

[ ]  Text alternative for the given Image is not meeting the WCAG Requirements
Issue : Text alternative  for the given Image is not meeting the WCAG Requirements
The existing Image - "Search Lense " given with -"Test alt text":
This Graphic not conveying any info - this  observed as "Decorative " Image -  Decorative Images expected to hide from screen reader
detection , which is not done .
Recommended Fix : Please confirm  the given Image is a  Informative /Decorative , and expected to choose the fix accordingly :
1. informative graphics should be given a descriptive alternative text so that the users of assistive technology can understand them.
2. decorative/non informative graphics should be hidden from assistive technology so that they do not distract the user.
This issue is reported in Empty State - with custom illustration

WCAG 2.1 Violation
No response
Reproduction/example
https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-patterns-empty-state-emptystate--default&globals=viewport:basic
Steps to reproduce
Heading level hierarchy Issue is reported in all the variants of Empty State.
Text alternative  for the given Image is not meeting the WCAG Requirements - reported in Empty State - with custom illustration
Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I checked the current issues for duplicate problems

As discussed on sizing, we should treat the images as decorative as we do on the full-page error.


Error: FP8 quantize Integer divide-by-zero

System Info

x86_64
NVIDIA H20
96GB
TensorRT-LLM version: 0.11.0.dev2024051400

Who can help?
@Tracin
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[X] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
Use FP8 to quantize the Mixtral-8x22B-v0.1 model
# Quantize HF Mixtral into FP8 and export trtllm checkpoint
python3 ../examples/quantization/quantize.py --model_dir /workspace/TensorRT-LLM/build/Mixtral-8x22B-v0.1/ \
                                   --dtype float16 \
                                   --qformat fp8 \
                                   --kv_cache_dtype fp8 \
                                   --output_dir /workspace/TensorRT-LLM/build/Mixtral-8x22B-v0.1/tllm_checkpoint_8gpu_tp8_fp8 \
                                   --calib_size 512 \
                                   --tp_size 8 > Mixtral-8x22B-v0.1_convert_tp8_fp8.log 2>&1

Expected behavior
Without any errors.
actual behavior
[198181d05d5a:1195236] *** Process received signal ***
[198181d05d5a:1195236] Signal: Floating point exception (8)
[198181d05d5a:1195236] Signal code: Integer divide-by-zero (1)
[198181d05d5a:1195236] Failing at address: 0x7f0908cff921
[198181d05d5a:1195236] [ 0] /lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7f09a20c0520]
[198181d05d5a:1195236] [ 1] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublasLt.so.12(+0xaff921)[0x7f0908cff921]
[198181d05d5a:1195236] [ 2] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublasLt.so.12(+0x837ee3)[0x7f0908a37ee3]
[198181d05d5a:1195236] [ 3] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublasLt.so.12(+0x6b5132)[0x7f09088b5132]
[198181d05d5a:1195236] [ 4] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublasLt.so.12(+0x78d897)[0x7f090898d897]
[198181d05d5a:1195236] [ 5] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublasLt.so.12(+0x78e8c5)[0x7f090898e8c5]
[198181d05d5a:1195236] [ 6] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublasLt.so.12(+0x78f59e)[0x7f090898f59e]
[198181d05d5a:1195236] [ 7] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublasLt.so.12(cublasLtTSTMatmulAlgoGetHeuristic+0x516)[0x7f09089def56]
[198181d05d5a:1195236] [ 8] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.12(+0x869eba)[0x7f092aa69eba]
[198181d05d5a:1195236] [ 9] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.12(+0x86a96c)[0x7f092aa6a96c]
[198181d05d5a:1195236] [10] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.12(+0x86cba2)[0x7f092aa6cba2]
[198181d05d5a:1195236] [11] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.12(+0x84358f)[0x7f092aa4358f]
[198181d05d5a:1195236] [12] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.12(+0xac7ecf)[0x7f092acc7ecf]
[198181d05d5a:1195236] [13] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.12(+0xac83d8)[0x7f092acc83d8]
[198181d05d5a:1195236] [14] /usr/local/lib/python3.10/dist-packages/torch/lib/../../nvidia/cublas/lib/libcublas.so.12(cublasGemmEx+0x13d)[0x7f092a5e1c7d]
[198181d05d5a:1195236] [15] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cuda.so(+0x333e71f)[0x7f095927871f]
[198181d05d5a:1195236] [16] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cuda.so(+0x3367a06)[0x7f09592a1a06]
[198181d05d5a:1195236] [17] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cuda.so(_ZN2at6native22structured_mm_out_cuda4implERKNS_6TensorES4_S4_+0x4a)[0x7f09592a1f5a]
[198181d05d5a:1195236] [18] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cuda.so(+0x30f52d2)[0x7f095902f2d2]
[198181d05d5a:1195236] [19] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cuda.so(+0x30f5390)[0x7f095902f390]
[198181d05d5a:1195236] [20] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(_ZN2at4_ops2mm10redispatchEN3c1014DispatchKeySetERKNS_6TensorES6_+0x6e)[0x7f098ae18fbe]
[198181d05d5a:1195236] [21] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(+0x45ca504)[0x7f098cb1d504]
[198181d05d5a:1195236] [22] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(+0x45cb0e3)[0x7f098cb1e0e3]
[198181d05d5a:1195236] [23] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(_ZN2at4_ops2mm4callERKNS_6TensorES4_+0x15e)[0x7f098ae68c8e]
[198181d05d5a:1195236] [24] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(+0x1cb55d0)[0x7f098a2085d0]
[198181d05d5a:1195236] [25] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(_ZN2at6native6matmulERKNS_6TensorES3_+0x49)[0x7f098a20fd99]
[198181d05d5a:1195236] [26] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(+0x2ece850)[0x7f098b421850]
[198181d05d5a:1195236] [27] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(_ZN2at4_ops6matmul4callERKNS_6TensorES4_+0x15e)[0x7f098af94a2e]
[198181d05d5a:1195236] [28] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(_ZN2at6native6linearERKNS_6TensorES3_RKSt8optionalIS1_E+0x263)[0x7f098a1f72f3]
[198181d05d5a:1195236] [29] /usr/local/lib/python3.10/dist-packages/torch/lib/libtorch_cpu.so(+0x2ece5e3)[0x7f098b4215e3]
[198181d05d5a:1195236] *** End of error message ***
/usr/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '

additional notes
None

You could update the cuda, GPU drivers and TRT-LLM version.
Duplicated: https://github.com/NVIDIA/TensorRT-LLM/issues/1717

Could you try pip install tensort_llm==0.11.0.dev2024060400?
If the problem is still there, we will deal with it further.

closed, confirmed that it was fixed in 0.11.0.dev2024060400

closed, confirmed that it was fixed in 0.11.0.dev2024060400

Hi @hijkzzz，I meet the same problem for MOE (including 8x22B and 8x7B) fp8 quantization in H20, even after upgrading to 0.11.0.dev2024060400 (neither by v0.12.0.dev2024070900).  However, it is fine for llama-70B fp8 quantization. Here is my environment:
NVIDIA-SMI 550.54.14              Driver Version: 550.54.14      CUDA Version: 12.4
pip list |grep tensor
cutlass_library          3.5.0                /app/tensorrt_llm/3rdparty/cutlass/python
safetensors              0.4.3
tensorrt                 10.0.1
tensorrt_llm             0.11.0.dev2024060400
pip list |grep cuda
cuda-python              12.5.0
nvidia-cuda-cupti-cu12   12.1.105
nvidia-cuda-nvrtc-cu12   12.1.105
nvidia-cuda-runtime-cu12 12.1.105
Any suggestion is appreciated !


connectToNetwork - Connection timeout

The connectToNetwork method returns after the first successful connection, after restarting the app only 'Connection timeout'. Timeout parameter is set to 1000.

What do you mean by restarting the app? why you want to call connectToNetwork if you are already connected to the network?

After closing the app, the connected wifi is disconnected and when restarting the app, there was no reconnection to the wifi, but the 'Connection timeout' error message.
But I had now also noticed that already at the first connection the connection is broken after a few seconds.
I think I need to do more tests with more different Wifi's to be able to better assess.
Sorry for the effort, I would close the issue for now.


Support mime type matching instead of regexes

Some web applications don't always have an extension, I'd like to set expiration header based on the mime type of the query instead of the path.
What would be really awesome is to allow checking any available placeholder (kind of like the rewrite the http.rewrite plugin), but I'm guessing that's much more complex.

Hi, took long enough but I finally took some time to implement it.

Is this already available if I update caddy or do I need to wait for a new release?

It's released on caddyserver.com. I forgot to do the release on github but caddy should use the latest version.

Alright, I tried it but I can't tell how to configure it then.
I tried both of these and it doesn't match any css file.
match_header content-type text/(css|js)(;.*)? 30d
match_header content-type text\/css 30d

The raw content type I'm seeing in my browser is content-type: text/css; charset=utf-8

ok so the .* matching shouldn't but as it is that "normal" since it also matches an empty string.
Could you test with Content-Type ? Maybe your browser normalize to lower case but usually it's capitalized.
The / should not need escaping and just text/css should work. I'll do more tests later but I'm wondering if the mime is set early enough. Are your css files static or served through an application server ?

According to the doc, headers are case insensitive, I tried, as expected, it didn't change anything.
I tested for static files, have not tried it through a proxied connection just yet, if it helps, I can test that later.

Finally had a look into that issue. Unfortunately I don't have good news. While the logic is ok, technically I can't handle headers on static content because Caddy defer to net/http ServeContent then terminate. Nothing happens after the file is served.
match_header will work on anything not static but the only header available for static files is "Server".
I'll have a look at the v2 to see if there's a way to overcome this.


<EMAIL_ADDRESS>hash check failed

> scoop install furmark
Installing 'furmark' (<IP_ADDRESS>) [64bit] from extras bucket
Downloading https://geeks3d.com/dl/get/720#/FurMark_<IP_ADDRESS>_Setup.exe (-1 B)...

Checking hash of FurMark_<IP_ADDRESS>_Setup.exe ... ERROR Hash check failed!
App:         extras/furmark
URL:         https://geeks3d.com/dl/get/720#/FurMark_<IP_ADDRESS>_Setup.exe
First bytes: 3C 21 64 6F 63 74 79 70
Expected:    956925c17c7a5cbea2bdf96690f5cc38
Actual:      5b97f5c6527bb3224ef16a5958961c33

> scoop status
Scoop is up to date.
Everything is ok!

> scoop cache rm furmark
Deleted: 0 files, 0 B

> scoop install furmark
Installing 'furmark' (<IP_ADDRESS>) [64bit] from extras bucket
Downloading https://geeks3d.com/dl/get/720#/FurMark_<IP_ADDRESS>_Setup.exe (-1 B)...

Checking hash of FurMark_<IP_ADDRESS>_Setup.exe ... ERROR Hash check failed!
App:         extras/furmark
URL:         https://geeks3d.com/dl/get/720#/FurMark_<IP_ADDRESS>_Setup.exe
First bytes: 3C 21 64 6F 63 74 79 70
Expected:    956925c17c7a5cbea2bdf96690f5cc38
Actual:      5b97f5c6527bb3224ef16a5958961c33

@CupCakeR How about install it under powershell 7+

@CupCakeR How about install it under powershell 7+

I was indeed using an old version (5.1.22621.1778) and using PowerShell 7 actually fixed the issue. Thank you very much!


[Obsolete] MONDO:0850093 'absence epilepsy'

Mondo term (ID and Label)
MONDO:0850093 'absence epilepsy'
Reason for deprecation
This is a phenotype. Discussed at [epilepsy workshop(https://www.youtube.com/watch?v=W_WC7QZsL0M) around minute 18.
Suggested term to consider
HPO

@nicolevasilevsky the PR is approved and merged. Does this issue also need a tag of 'on the list' or anything else?

yes it does, I added it, thanks!


Pass --quiet from mambabuild to boa

This PR attempts to support conda mambabuild --quiet ... by using the existing suppress_stdout function.

yep, I've now turned off the mamba output.

Thanks though, @duncanmmacleod!

Thanks though, @duncanmmacleod!

No problem, turning off the mamba output works just as well for me!