Block comment is broken.

Running the keybinding on a comment block created by the keybinding or by myself results in more wrapping comments. This happened in every language I've tried.
Check out the gif attached for better demonstration (At the end I'm using ctrl+z to get back)

EDIT: I'm using Atom version 1.32.1

Same happens to me when using Atom version > 1.31.2


Add support caligraphy

I would like to change font of labels. Please add spanneble text support or custom attrs

+++

+1

+1
and how can I use this feature: "Added option to use custom fonts for Labels"

Just add a custom font in your assets folder.
I created a "fonts" folder inside assets, then I added this attribute on FloatingActionMenu: app:menu_labels_customFont="fonts/your-font.ttf" and it works like a charm.

Error:(42) No resource identifier found for attribute 'menu_labels_customFont' in package 'com.example.app'

Add this attribute on FloatingActionMenu:
fab:menu_labels_customFont="fonts/your-font.ttf"


Check if __argv is null

__argv can be null when running unicode programs compiled with msvc

Closing as abandoned. Please let me know if you want to continue working on this PR.


[SDP-926] events/httphandler/data/services: sms invitation event handler

What
This PR moves the scheduler job that sends the invitation SMS to Message Broker events. So, a new event handler to handle this event was added.
Why
We are moving from scheduler jobs to Message Broker events.
Known limitations
N/A
Checklist
PR Structure

[x] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[x] This PR title and description are clear enough for anyone to review it.
[x] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[x] This PR adds tests for the new functionality or fixes.
[x] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[x] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[x] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[x] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[x] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[x] This is not a breaking change.
[ ] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr133.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr133.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr133.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr133.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr133.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr133.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr133.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr133.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr133.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr133.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr133.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr133.previews.kube001.services.stellar-ops.com

@marcelosalloum @marwen-abid I've made the changes you folks suggested. Could you give it another look before we merge?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr133.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr133.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr133.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr133.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr133.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr133.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr133.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr133.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr133.previews.kube001.services.stellar-ops.com


Un-ignoring bower.json so that the bower.json file is available when installing from bower.

Many people rely on the bower.json being included when installing from bower. The bower.json holds a lot of information people rely on when using bower (the version number of the repo, and the main property in particular).
Currently, this file is not available when installing from bower.
Our use case is that we use this gulp build tool to compile all vendor dependencies.  It's nice because you allow the repo owner to control the repo's point of entry.
It is a small change and would help the bower community if you were to accept this pull request. Thanks!

Believe bower issues have been addressed in 2017 - closing as stale.


Unable to download the latest version

Dear all,
I am using Mac M1 processor and it is giving me a hard time updating FASTP without conda.
With conda I am able to update the FASTP however the latest version is 0.19
It will be admirable if you will be able to publish the latest version in conda as well.
Best regards and thank you.

The latest version is already in Conda.
Each new fastp version is in Conda.

Thank you for your email.
However, when running conda install -c bioconda fastp
It's installing version 0.12.4-0
And while running conda install -c bioconda/label/cf201901 fastp
It's installing version 0.19.5
As you can see:
[image: image.png]
Both are not the latest version, and lacking some essential properties for
my work.
I would highly appreciate your help!
Thank you
בתאריך יום א׳, 12 בדצמ׳ 2021 ב-13:01 מאת Shifu Chen <
@.***>:

The latest version is already in Conda.
Each new fastp version is in Conda.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenGene/fastp/issues/383#issuecomment-991876527, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASVRHATUNK2JD6BOMUEXGEDUQR6IBANCNFSM5J4BLNTQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

See https://anaconda.org/bioconda/fastp

I have got exactly the same problem, the link above (despite what it says) does not install 0.23.2

@angusdavison Are you sure you're not seeing a dependency conflict? Fastq requires a newer version of libdeflate, which means that if you have e.g. BWA in your environment, you can't get the latest version of fastp.
Can you install it in an empty environment with nothing else it in?

I dont think that is the issue, though getting somewhat beyond my skills/knowledge. In any case, I installed the binaries via "wget http://opengene.org/fastp/fastp" - that is working fine.  Thanks for your consideration

@angusdavison Are you sure you're not seeing a dependency conflict? Fastq requires a newer version of libdeflate, which means that if you have e.g. BWA in your environment, you can't get the latest version of fastp.
Can you install it in an empty environment with nothing else it in?

What libdeflate version does BWA use?

Looking at it for a bit more, I think the conflict is actually samtools not bwa, which needs htslib, which uses libdeflate 1.6, whereas fastp uses 1.7. But it's hard to know exactly.

Yes, agree there is probably a conflict but I don't know the source - a force install of 0.23.2 produced the following errors. Not sure if this is helpful or not (and I have got fastp working so I am not concerned)
UnsatisfiableError: The following specifications were found to be incompatible with each other:
Output in format: Requested package -> Available versions
Package libgcc-ng conflicts for:
python=3.9 -> libgcc-ng[version='>=7.3.0|>=7.5.0']
python=3.9 -> zlib[version='>=1.2.11,<1.3.0a0'] -> libgcc-ng[version='>=7.2.0']
Package libstdcxx-ng conflicts for:
python=3.9 -> libstdcxx-ng[version='>=7.3.0|>=7.5.0']
fastp=0.23.2 -> libstdcxx-ng[version='>=9.4.0']The following specifications were found to be incompatible with your system:

feature:/linux-64::__glibc==2.17=0
python=3.9 -> libgcc-ng[version='>=7.5.0'] -> __glibc[version='>=2.17']

Your installed version is: 2.17

But fastp dons't declare a dependency on libstdcxx-ng[version='>=9.4.0'].
I checked annocanda, the latest version for libstdcxx-ng is 9.3.0.

Hello. Unfortunately, I am also having some install issues.
"conda install -c bioconda fastp" installs version 0.12.4
"conda install -c bioconda/label/cf201901 fastp" installs version 0.19.5
I would like to use these two arguments: --detect_adapter_for_pe and --cut_tail. However, it looks like --detect_adapter_for_pe isn't in 0.12.4 and --cut_tail isn't in 0.19.5. As an example, I get the message "undefined option: --cut_tail"
I created a new conda environment to ensure there were no conflicts and the problem is still there. I am running conda 4.11.0 on OSX through terminal.
Any guidance would be appreciated. Thanks!

Hello again. Just wanted to provide an update for those looking for a workaround. I was able to install an older version of fastp by downloading the file from conda and running: "conda install fastp-0.20.0-hd9629dc_0.tar.bz2". I was then able to use the two arguments I wanted. Importantly, it wouldn't work on the university cluster for some reason (cannot execute binary file) but it worked on my work macbook. I tried it the same thing with the latest version 0.23.2 but it didn't work (dyld: Library not loaded: @rpath/libisal.2.dylib). Just trialling a few more: version 0.23.0 also didn't work with this method but 0.22.0 did.
Thanks!

I am also having an issue with fastp where it wont write cleaned reads.  I know there are good reads for all the sequences when reading the the json & html outputs; but this is a seperate issue. To solve this, I thought I would try updating it to the latest version since I realized I did not have the latest. However, I cannot install the latest 0.23.# or even 0.22.# versions
conda install -c bioconda/label/cf201901 installs fastp-0.19.5
conda install -c bioconda/label/main installs fastp-0.20.1
conda install -c bioconda fastp installs fastp-0.20.1
I've tried various conda install commands to force install the absolute latest version "fastp=0.23.2". I've used a fresh conda environment with different python versions. At this point I'm not sure what to do.
@Jediworm
I wonder if this workaround is OK if you have sudo permissions. I've tried downloading it to my home dir on the cluster I use and installing from there.
$ fastp -v
fastp: error while loading shared libraries: libisal.so.2: cannot open
shared object file: No such file or directory

From my novice understanding, don't I need to download the tarball to the anaconda package directory? (/local/anaconda3/pkgs/); and then "conda install /local/anaconda3/pkgs/fastp-...." ?

A workaround would be creating a new conda environment and installing the latest fastp.
conda create -n fastp -c bioconda fastp=0.23.2

I have the same issue, solved by setting the environment variable.
export LD_LIBRARY_PATH=" your libdeflate path containing the file libdeflate.so.0"
I wonder this is caused by makefile


xml_escape ALL THE THINGS!

Nice catch. Would you be able to add a quick test (Looking just at post content is probably sufficient for our purposes) to make sure we don't break this going forward?

Would you be able to add a quick test

Yes; give me just a couple days. I will have more time after this week is over.

Closing because #24


Add support for unwrapping outbound google proxy URLs (if they're found)

This has the bonus benefit of not requiring a external request for dereferencing google URLs, so if you're processing a lot of proxied URLl, you don't make a huge pile of requests.
I also changed the urllib.request import to urllib.parse. I wasn't even aware that some of the parsing calls from urllib.parse were also available in urllib.request, but parse_qs() isn't, so that change was cleaner.
Also, a new testcase.

Does your PR #7 have these changes included?

Does your PR #7 have these changes included?

Yeah, I basically just worked in one branch. I more or less just hacked in what I wanted, rather then tried to make up discrete patches (I'm a bad contributor sob).

Alright I will close this one. Thanks.


@include in multiple files

At the moment you can't seem to be able to include a file in multiple files that are themselves also included.
grammar.ne
@include "a.ne"
@include "c.ne"

main -> a | c

a.ne
@include "b.ne"

a -> "a" | b

b.ne
b -> "b"

c.ne
@include "b.ne"

c -> "c" | b

Results in a warning:
WARN	Undefined symbol `b` used.

If c.ne is excluded then there is no warning. It severely limits you in using several files and re-using logic.

No, it works perfectly fine, the issue is with the linter.

Another related issue is that nearleyc get's confused about the directory:
.
├── dir
│   ├── a.ne
│   └── b.ne
└── grammar.ne

grammar.ne
@include "dir/a.ne"

main -> a

a.ne
@include "b.ne"

a -> "a" | b

b.ne
b -> "b"

$ nearleyc grammar.ne -o grammar.js
fs.js:641
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '/tmp/eg/b.ne'
    at Error (native)
    at Object.fs.openSync (fs.js:641:18)
    at Object.fs.readFileSync (fs.js:509:33)
    at Compile (/tmp/eg/node_modules/nearley/lib/compile.js:49:39)
    at Compile (/tmp/eg/node_modules/nearley/lib/compile.js:53:25)
    at StreamWrapper.<anonymous> (/tmp/eg/node_modules/nearley/bin/nearleyc.js:57:17)
    at emitNone (events.js:91:20)
    at StreamWrapper.emit (events.js:185:7)
    at finishMaybe (_stream_writable.js:512:14)
    at endWritable (_stream_writable.js:522:3)


reading directory .: Input/output error with multi containers

Hi:
I am following the marathon ha demo. i am using the openstack cinder as the backend,  i can run one docker container in one node, then write somethine in the docker volume. after i stop the contianer, then i start another container with the same volume, i can get the writted text.
but, if i do not stop the first one container, then the second also can get the text, but the first will throw error"reading directory .: Input/output error"
The result is same in marathon.

Hi @AI-PaaS I need a few more details to help.
What OS are you running?
Are both containers running on the same node?

Also what version of flocker / mesos/ marathon are you using?

What OS are you running?
We use centos 7.0.
Are both containers running on the same node?
No, on two node.
What docker images are you using in your examples?
docker versoin:1.10.3, image:redis:3.0.6
Also what version of flocker / mesos/ marathon are you using?
flocker: 1.10.2, mesos: 0.28.0, marathon: 0.15.3

@AI-PaaS
So flocker volumes are 1:1 when it comes to containers. Meaning that only one container can access them at one time. You are getting an error"reading directory .: Input/output error" on the first container because it no longer has access to the volume because it can only be mounted on one host at a time.
Are you using the Docker containerizer with Mesos?
The expected output of this would be the the second container being deployed on a different node should time out trying to start since the first one is still using it. If thats not the case, then there is likely a bug.

@AI-PaaS yes, this is because there is 1:1 mapping from container:flocker-volume


this.askAndWait causes sprite to say null

I'm not sure when this bug was introduced, but using this.askAndWait() in a sprite causes the sprite to say "null".

Seems to be introduced by https://github.com/leopard-js/leopard/pull/69


Runtime L3L4  Test connect timeout

time="2018-04-07T19:48:22Z" level=debug msg="running command: docker exec -i  app3 curl -s --fail --connect-timeout 5 --max-time 5 http://<IP_ADDRESS>:80/public"
cmd: "docker exec -i  app3 curl -s --fail --connect-timeout 5 --max-time 5 http://<IP_ADDRESS>:80/public" exitCode: 28

It happen here https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/2138/testReport/junit/(root)/runtime/RuntimeValidatedPolicies_L3_L4_Checks/

@aanm this issues is not related with no space left on device, the exit code means connection timeout:
https://curl.haxx.se/libcurl/c/libcurl-errors.html

@eloycoto Exactly but why did we get out of space in the first place?

@aanm where do you see that the server is running out of space?

@eloycoto ah sorry I misread your answer. You're right

@aanm this failure was during a PR run. I see that it failed in your 'race detector' PR. Does this mean we should treat this as a master build?

Updated the description with the logs from the build since we auto-delete builds from Jenkins after some time.
@aanm makes sense. In this case, given that while it was ran in a branch, but that the only delta in the branch from master was running Cilium with race detection, this makes sense to triage.

Never seen again


Spotify wrapper INOP

Testing using a basic "now playing" that can be demo'd here:
https://codepen.io/jmperez/pen/VbvPbR
Will not produce login popup. Probably a renderer issue?

UPDATE
Pop-up works although I log into Spotify using Facebook.
Upon Facebook log-in a message appears- "Your Request Couldn't be Processed".
This method probably needs cookies or something for Facebook to work correctly.

Will not log in using facebook.
Email login works perfectly fine.
If you try to log in without having something playing before hand you'll get an access token issue that shows as a JSON issue.


Closes: #1

Updated validations.py python script.
Fixed the behaviour of validat_user function in validations.py
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

I am happy to complete the course.


The vmlinux built by build-wsl2-kernel is not picked up by WSL

wsl --version
WSL-Version: <IP_ADDRESS>
Kernelversion: <IP_ADDRESS>
WSLg-Version: 1.0.51
MSRDC-Version: 1.2.3770
Direct3D-Version: 1.608.2-61064218
DXCore-Version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows-Version: 10.0.19045.3570

After shutdown, putting .wslconfig in place and Restart-Service LxssManager I still see:

Linux <IP_ADDRESS>-microsoft-standard-WSL2

dmesg:

[    0.000000] Linux version <IP_ADDRESS>-microsoft-standard-WSL2 (oe-user@oe-host) (x86_64-msft-linux-gcc (GCC) 9.3.0, GNU ld (GNU Binutils) <IP_ADDRESS>00220) #1 SMP Fri Jan 27 02:56:13 UTC 2023
[    0.000000] Command line: initrd=\initrd.img WSL_ROOT_INIT=1 panic=-1 nr_cpus=2 bonding.max_bonds=0 dummy.numdummies=0 fb_tunnels=none swiotlb=force earlycon=uart8250,io,0x3f8,115200 console=hvc0 debug pty.legacy_count=0

for uname -sr
Is there any chance to debug this ?

I had a typo in my .wslconfig, \\\ instead of \\ in one place. Now it works.


Prefixes for conditional music generation

Hi, I'm trying to generate conditional music but I can find only one prefix file, which is 'transformer-gan/test/prefix_test.npy'.
Can you provide more prefix files(.npy) for additional trials, please?
Thank you

Found that we can make prefix.npy using midi files with music_encoder.py.
Thanks for sharing the interesting research!


Add custom transformers option

Fixes #502.

Adds functionality to use custom transformers: https://github.com/Microsoft/TypeScript/wiki/Using-the-Compiler-API
Available via getCustomTransformers() option, the idea taken from awesome-typescript-loader.

@ivogabe can you please review?

Thanks @layershifter for the PR! Sorry for the delay, I've been busy with other projects and didn't have time to take a look at this yet. Overall the changes look good, though I was wondering whether it is a large limitation that we don't pass a ts.Program to getCustomTransformers? That seems to be the difference with awesome-typescript-loader. Correct me if I'm wrong, but I assume that we cannot pass the project to the getCustomTransformers as we don't have one when isolatedModules is enabled, as we are then using a file-based compiler.
An alternative would be to change the type to (string | ((program?: ts.Program) => ts.CustomTransformers | undefined)), and only pass the program if isolatedModules is disabled. I assume that you would need the ts.Program if you need some type info of the program and we simply don't have that with isolatedModules enabled. If you need that type info, you should just not use isolatedModules. What do you think about that? If you want to make the change, you should call getCustomTransformers in the FileCompiler and ProjectCompiler and not in checkAndNormalizeSettings.

@ivogabe thanks for feedback!

Correct me if I'm wrong

Nope, you're fully right.

(string | ((program?: ts.Program) => ts.CustomTransformers | undefined))

Looks good to me because I have already thought about this :+1:  I will make these changes tomorrow.

Great! Let me know if you run into any problems.

@ivogabe it seems that I made all requested changes. Can you please take a look? 😄

Thanks Alexander for your work! Changes look good. It will be part of the next release.

I am unable to get this feature working following the example in the docs :(


secret-handshake should test using dec values

The secret-handshake.spec.js file should pass the appropriate dec value to the SecretHandshake constructor, per the prompt:
Given a decimal number, convert it to the appropriate sequence of events for a secret handshake.

Here's a couple of examples:

Given the input 3, the function would return the array ["wink", "double blink"] because 3 is 11 in binary.

Given the input 19, the function would return the array ["double blink", "wink"] because 19 is 10011 in binary. Notice that the addition of 16 (10000 in binary) has caused the array to be reversed.

However, the test file passes a hexadecimal value to the SecretHandshake constructor for each test, for example:
test('binary 11111 (hexadecimal 0x1F) is jump, close your eyes, double blink, and wink', () => {
    const handshake = new SecretHandshake(0x1F);
    expect(handshake.commands()).toEqual(['jump', 'close your eyes', 'double blink', 'wink']);
  });

This creates an issue because two-way conversions from hex <--> bin is not possible in JS:
parseInt(11111, 2).toString(16) === "1f"
parseInt(0x1F, 16).toString(2) === "110001"

The spec file should be modified so that conversions to the expected binary values can occur, like:
test('binary 11111 (decimal 31) is jump, close your eyes, double blink, and wink', () => {
    const handshake = new SecretHandshake(31);
    expect(handshake.commands()).toEqual(['jump', 'close your eyes', 'double blink', 'wink']);
  });

I can open a PR to address this issue, but I thought it would be worthwhile to discuss the spec file here first, in case I'm missing something.

@PSalant726  I don't think there's anything to discuss!  How did this happen?  Not sure, but definitely problem-specifications seeks decimal inputs, not hexadecimal inputs.
Please proceed with your PR, that would be welcome :)


False positive for react/display-name

There seems to be a regression in version 7.30.0. Functions like these are now treated like components and trigger the react/display-name rule:
export const demo = (a?: string) => (b?: string) => {
    if (a == null) return null;
    return b;
}

I understand that it might be hard to separate function components from regular functions, but aren't React components always capitalized? Couldn't that be a way to identify them?
This wasn't a problem in version 7.29.4 of eslint-plugin-react.
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Plus one. You can see the example here. https://github.com/trento-project/web/runs/6502507233

cc @golopot; perhaps some of your refactors broke this?

Yes PR #3276 broke this.

Friendly question: Do you plan to make a new release in the coming days?
cc @golopot @ljharb

@GuillaumeAmat i don't have any specific plans for any release. There will be a release when it's ready.


chore(dep-devs): update e2e templates dependencies

Summary

Update e2e templates' dependencies

Slightly adjust typing in types.ts

Test plan

Green CI
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
N.A.

Pull Request Test Coverage Report for Build 5246

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.849%

Totals

Change from base Build 5245:
0.0%

Covered Lines:
1055

Relevant Lines:
1090

💛  - Coveralls


Change reference to VSTS to Azure DevOps

I shared these instructions with someone who is very new to ~VSTS~ Azure DevOps and was confused by the title of this doc. The naming/branding change will undoubtedly take a while to get through, but hopefully this little bit helps.

This looks good, thanks for the contribution!


Please consider asking questions not related to this module in community forums like this one - https://discuss.hashicorp.com
Answering your question, you have either wrong AWS access credentials or your IAM user is not allowed to perform certain actions (eg, ec2:DescribeImages).
Closing this one.


Add wrapping back into Pool UI

If a user has AETH on Arbitrum, they cant LP without wrapping it.
Please add Wrap/Unwrap back into the Pool UI
We can consider ways of abstracting in the future

Wrap/Unwrap should be greyed out or something else until you switch to the right chain (not hidden from the user)
https://www.awesomescreenshot.com/video/13718149


Add the Gitlab Provider

Requesting that you add the new Gitlab Provider as a new VCS Provider.
See here for the provider details: https://registry.terraform.io/providers/gitlabhq/gitlab/latest

Is this still available to pe picked up and worked on ?

Is this still available to be picked up and worked on ?

I am assuming so. Looks like it hasnt been worked on.

Any update on this?

@SultanSGillani Here's my first trial at implementing this https://github.com/GoogleCloudPlatform/terraformer/pull/1006


Make Zocalo handler deal with different experiment types

Once the data is correct in ispyb, this is just triggered in the same way as grid scan


slack importer: Fix Realm mappings.

Merged, thanks @rheaparekh!  Added a comment above on something we should fix soon.

Thank you for the review!


Is there a best practice for a multi-master setup?

Is there an easy way to split the jobs between four servers?
Or at least prevent a job to be processed twice?

Worker locks job before executing. We run DJ on multiple servers for years. There is no special setup needed.


Publish helm chart

What is the expected enhancement?
Publish the quantum serverless helm chart so that it can be installed without cloning the git repository.

[ ]  Setup helm repository  or find an existing repository
[ ] build and push the helm chart into the repository

Duplicate of https://github.com/Qiskit-Extensions/quantum-serverless/issues/52. Let's pick either one of them and close other

OH, I'll close this.


Difference between shc and hbase-spark connector in HBase codebase

I was looking at different options to connect to HBase from Spark, and I came across 2 solutions that look rather similar. One of them is this project, and the other is the hbase-spark connector that comes with the HBase codebase itself: https://github.com/apache/hbase/tree/master/hbase-spark
The codebases seem rather similar, even with some code literally the same. Compare this to this for example.
What is the difference between these too? Why doesn't Hortonworks contribute to the core HBase code, instead of creating a separate connector with similar code?

Hi @DandyDev
Hortonworks contributed most of SHC code into Apache HBase repo (https://github.com/apache/hbase/tree/master/hbase-spark). Only a few features of SHC are not in Apache HBase repo, for example, the feature of supporting multiple secure Hbase cluster, and the feature of supporting Phoenix coder, etc. The reason why we stopped to merge SHC's code into Apache HBase repo is that the feature of supporting Phoenix coder invokes Phoenix APIs.

There are some discussion about this issue<EMAIL_ADDRESS>

Thanks for the answer, makes sense! Can I conclude from this that SHC is the more mature option of the two?
Thanks for all the great work you're doing!

@DandyDev  It should also be mentioned that spark connector the comes with HBase has only RDD api and does not support DataFrames/sparkSql. However it seems to be a better fit for "low level" maintenance jobs, as it supports bulk load which is missing in shc.


Problem deploying to Heroku

remote: -----> Firefox
remote: geckodriver app detected
remote: /tmp/codon/tmp/buildpacks/768374e866288447126d1d75779462919bfbaab4/bin/compile: line 16: cd: /tmp/codon/tmp/buildpacks/768374e866288447126d1d75779462919bfbaab4/fonts: No such file or directory
remote: /tmp/codon/tmp/buildpacks/768374e866288447126d1d75779462919bfbaab4/bin/compile: line 82: syntax error near unexpected token `;'
remote:  !     Push rejected, failed to compile Firefox
remote: geckodriver app.
remote:
remote:  !     Push failed

i got same problem

It's a small fix: missing semicolon in line 82 of bin/compile

Was this fixed already? I am having the same issue as described above. Thanks

Was this fixed already? I am having the same issue as described above. Thanks


Structure

This is the same as my previous pull request, but the update is made in Master, rather than a new version, per @jondayton
Overview
Version 0.0.2 uses a "pull" method of defining the relationship between devices and zones. I.E. "I'll send out a request for all devices to tell me what zones they are in and I'll find a way to remember all the responses in my own device, so I can make the proper request in the future."
This leads to quite a few possible issues:
*What if not all devices are OpenAg compliant?
*What if not all devices are configured?
*What if not all configurations are accurate?
*How do I store the information once I get it?
A solution to this problem is to create a master configuration file that must be stored on a device on the network capable of responding to an OpenAg API call. (Which device? TBD).
This configuration is an attempt to solve that problem
There are some additional upsides to this configuration file.
*A standard config file would make it easier to describe a facility for future upgrades.
*It would allow for the creation of new tools, like automated generic facility floor plans.
*All of this standardization will make data analysis significantly easier down the road.
*Better data analysis can lead to better cultivation outcomes and efficiency for the market as a whole.
What Changed
Files
*All changes made in master.
*Removed any mention of the structure from the general.md document.
*Removed the plan.md document. This document may need to be re-added. There is no reason a device shouldn't understand where it is in a network and respond to a request for information. Still, the configuration should be updated to be in line with the structure in this branch.
*Added a structure folder.
*Added structure.md. This is a theory document that lays out a new structure theory, discussed in the next section.
*Added nodes.md. This document defines the structure of a configuration file.
*Added facilityStructureExample1.YAML to the examples folder. This document shows how the structure and theory might come together in an example indoor grow.
The Structure Itself.
When putting this together, I attempted to stick as close as possible to the originally defined structure:

I found that there were some peculiarities that required adjustments.
System
I couldn't find a use for the system construct. I can see how it would be theoretically useful to know that an Argus system controls several air sensors and the HVAC system, but this is an attribute of those systems, at best. My assumption is if I ask the HVAC system to turn on with an OpenAg API call, I don't care who is turning it on, so long as I get my 200 code returned from someone. If I need to know the URI of a particular device, that is an attribute of that device. I didn't add "System" as an attribute to device, but we can certainly do that in the future.
Compartment
I couldn't find any reason why "compartment" isn't just a zone with the attribute "type: compartment." Having it separated has a notable weakness: Devices belong in zones. If I have compartment level devices (e.g. HVAC system or CO2 burner), I would have to have a zone underneath a compartment that mirrored the compartment exactly. It is an unnecessary redundancy.
Sensor and Controller
These are both clearly attributes of the device, attributes among many. It is awkward to define some on the document, but not all. They should be required attributes though
Crop Variety
Another attribute, among many (like Crop Stage, for example. Perhaps Crop Strain, Substrain, etc). This would would be an optional attribute.
Location
Location is required in all of the existing documentation. This is a laudable goal, but surely one to fail. Location is an attribute, and realistically, it will need to be optional. I have low expectations of proper thorough setup. Besides, how does one define the XYZ position of a vent sock like this one and does it matter?

Contact
Added the contact node to the structure. It can be useful to know how a device is being controlled on the system. It is a natural place to put a URI and contact/control power requirements as opposed to device power requirements.
Proposed Structure

This is going to need some additional work prior to merging.


Fix bug in CRD creation code.

This was preventing the installer from actually creating clusters.

This change is


Wrapping could break memory soundness

Valida is using a common memory argument, where the prover commits to a log of operations ordered by (address, timestamp). Once we have this ordered log, memory consistency is easily enforced with constraints.
To simplify this discussion, say we're ordering by address only. We verify this ordering by range checking each address delta, asserting that it is within some "small" range like 16 bits.
The circular nature of field elements complicates this; e.g. an address step from p - 1 to 0 would be seen as a small delta of 1. So if a memory log had a sequence of addresses like 0, 2^16, 2 * 2^16, ..., wrapping around beyond p, it could revisit some address a second time, breaking the soundness of our memory argument.
Our initial thought was to avoid this problem by limiting the address space to ~30 bits, creating a ~30 bit "dead zone". Attempting to cross this "dead zone" would result in a failed range check.
However, we currently allow the prover to insert "dummy reads", to break down larger address deltas into smaller ones. It seems like these could also be used to break down a ~30 bit "dead zone" gap into small deltas.
Instead of adding dummy rows in the memory table to break down large deltas, we could just support larger range checks. Say we limit the address space to 29 bits; then any legitimate delta will be < 229. We could do a 29-bit range check by breaking it into say 14- and 15-bit range checks.
It might be worthwhile to also evaluate other memory techniques though. Triton has a unique method of enforcing that the log is grouped (not necessarily ordered) by address. BEGKN92 (section 4.1) offers a different approach, which doesn't involve address grouping at all. I'm not up to speed on Lasso yet, but I think it has another method inspired by BEGKN92.

Draft of notes below:
For the BEGKN92-inspired memory argument, I believe we only need the following 15 columns:
Read columns: address_r, value_r_0, value_r_1, value_r_2, value_r_3, clk_r
Write columns: address_w, value_w_0, value_w_1, value_w_2, value_w_3, clk_w
Other columns: is_read, is_audit, clk
There are two possible state changes in memory:
a. Read: Read (a, v, ts).  Write back (a, v, ts') where ts' = clk+1.
b. Write: Read (a, v, ts). Write back (a, v', ts').
In terms of lookups, there are still only 3 memory channels in the CPU chip (for reading two words, and writing one), except a write now uses a separate bus (i.e. the memory bus is split into a read bus and write bus). The sent column values are unchanged, and still look like (address_r, {byte_values}, clk, is_read). On the receiving end, in the memory chip, we also now have two buses mapping the incoming reads and writes to their respective column fields.
At each row of the memory trace, either a read or write (but not both) is looked up from the bus, so the prover nondeterministically sets the opposing columns. In the case of a read, the memory chip has constraints that ensure the corresponding write timestamp is an increment of the CPU clock, and that the written value remains unchanged. In the case of a write, the prover must set the read columns to valid values in order for the audit check (see below) to pass.
For the audit check (done following all bus read/writes), the prover nondeterministically adds rows (the audit set M) to fix the initial and final address-value pairs. If we assume that all used memory values should start at zero, then for each row the value_w fields should be set to zero, checked by the constraint is_audit * value_w_i = 0. The prover sets the read columns for each row to the final memory value states. Note that it's not necessary to check uniqueness of M, because read and write entries are always added together in our arithmetization (the sets cannot be imbalanced).


New ORT run details page(s)

The run details page needs a complete overhaul. The new structure will probably be:
organizations/{orgId}/products/{productId}/repositories/{repoId}/runs/{runIndex}:

[x] card layout. Example of such is here #706
[x] general run information #706
[ ] issues list, pending on #405
[ ] job details, using a tabbed layout which will be reachable with search parameter .../runs/{runIndex}?job={jobName}
[x] side menu (for example with icons such as in the above example): Overview, Logs, Reports

organizations/{orgId}/products/{productId}/repositories/{repoId}/runs/{runIndex}/logs:

[ ] logs of the run: zipped
[ ] logs of the run: streaming

organizations/{orgId}/products/{productId}/repositories/{repoId}/runs/{runIndex}/reports:

[x] downloadable reports from the run #770

As this will be a big issue, the best way to implement it would be to use a temporary route .../runs2/{runIndex} with its subroutes for the implementation.  This way, we do the implementation as added pages and components and avoid any possible rebasing problems. We could possibly do intermediate smaller PRs to main, to expose the implementation in .../runs2/ for all users to comment, while keeping the server UI otherwise intact (so all links still point to the old details page).

[ ] In the end, the new pages will be migrated into the .../runs route.
[ ] Clicking a traffic light for a run in repository index page should open up the new details page with the corresponding job details tab open, #643

Some ideas I wrote down during the frontend meeting today:

show badge next to menu items, e.g., for vulnerabilities, show the number of vulnerabilities (and mabye by severity, with different badge colors)
move issues to separate page
move job details to separate page (in technical section)

traffic lights in runs list could link to technical section with right tool selected

show only summaries in overview page, like number of issues by severity
show some statistical data in the overview page, e.g. a pie chart with number of projects per package manager
show item next to menu items where data is still being generated, e.g. a spinner if the evaluator job is still running, or another item if it did not even start yet
maybe show traffic lights in overview page, because users know it from the ort runs list

@mnonnenmacher I decided to make a new "improvement" issue for the new results pages, as they become fully visible now, and create the issue in a checklist format. This issue contains ideas from a while back, of which many are now outdated, so I think it would be best to close this with the "runs2" merge and continue tracking on the new issue, where it's easy to even create issues out of the checklist items. I already put the contents of the alignment meeting to the new issue.


Add fact, that migration to 1.5 is only possible from 1.4, to change log as highlighted change

Add a big block of documentation within the 1.5 change log for the minimum requirement of 1.4 running before migrating to 1.5 and the fact that you can not directly upgrade from a version < 1.4
See https://phabricator.mesosphere.com/D338

High on my todo list is writing an extensive changelog for persistence
including warnings about 1.4->1.5. This is already tracked in JIRA too.
On Fri, Dec 16, 2016 at 2:03 AM Johannes Unterstein <
<EMAIL_ADDRESS>wrote:

Add a big block of documentation within the 1.5 change log for the minimum
requirement of 1.4 running before migrating to 1.5 and the fact that you
can not directly upgrade from a version < 1.4
See https://phabricator.mesosphere.com/D338
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mesosphere/marathon/issues/4864, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAweZhuFl3jis0n2JrXl4Nj5wx_pGgowks5rImHhgaJpZM4LPBoQ
.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2447. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-2447. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


Proxy

Hi!
Would it be possible to build in a Proxy funcionality?
I tried to fiddle with Websocket Connection, but didn't work properly.
Maybe you know some solution?

This has been implemented in the 3.0 branch!


[BUG] Improve the shlok page

https://akshitagupta15june.github.io/Moksh/shlok_page/motivation.html
steps to follow
1)Take reference from iskcon page https://akshitagupta15june.github.io/Moksh/Iskcon/event.html, add the same navbar from iskcon to shlok page
2)remove the background picture from shlok page
3) add same footer of iskcon page in shlok page
4) Make sure whole page is responsive
5) Add screenshot in pull request to show responsiveness

Please assign this issue to me

Please assign this issue to me I dont have worked in any level 2 issue yet

ok! Please follow all guideline, responsiveness is very important

@akshitagupta15june Is this alright or do I need to add same navbar content as in events page??

hey can u see this powered by google translate text can be removed
also can u show the page responsiveness and also footer responsiveness


Add traceback to unhandled promise rejections, Fixes: #14631

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Console is filled with meaningless:  Possibly unhandled rejection: {} errors
What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?
I don't think so
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

@gkalpak uhh, are the tests for the unhandled rejection even run? I added these to intentionally fail...

Not sure what you mean. The tests should run (and I am quite sure they do).
(The tests need some fixes, because they are not currently testing what they should be testing, but I that is unrelated.)

@gkalpak https://github.com/angular/angular.js/pull/15527/files#diff-0cfb390955e411a4a5437fa337d52481R2181 should fail on the fixture.type === 'exception' because it doesn't stringify to 'foo'.

@gkalpak are you in IRC?

@graingert, if you want it to fail, then you better [not reject the promise with foo] 😛
(I am rarely (read "never") on IRC these days, but you can find me on gitter.)

@gkalpak oh I am a silly... Fixing...

BTW, it would made our life a tiny bit easier if you followed our commit message guidelines :wink:

@gkalpak will do once I've got the tests working. Also your URL is out of date: you want https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format

Thx! (My URL was fine btw - just intentionally pointing to the supersection of yours 😛)

@gkalpak ah it didn't go to a section for me at all.

@gkalpak and we're green!

@graingert, awesome!  What's wrong with it?

Actual:

fix($q): Add traceback to unhandled promise rejections, Fixes: #14631

Expected something like:

fix($q): add traceback to unhandled promise rejections
Fixes #14631

@graingert Thanks for the PR, this is awesome. 👏
I don't have any remarks apart from the incorrect commit message format.

@gkalpak commit message fixed

Landed, thanks!

@graingert One nit (I fixed it myself): there should be no colon after Fixes in the commit description.


Support running as standalone webapp (specially for mobile)

I was doing that with stackedit for a time now. In chrome: add to home screen and voila.
There is one minor quirk to be aware of: ctrl-f is not possible in most mobile keyboards, so lacking the browser menu a search icon will be handy for the mobile standalone case.

Dear @memeplex,
Thanks for your report!
Just to be sure. Are you requesting a feature that used to be supported by StackEdit but no longer is by Classeur?
Thanks,
~Robert

Just to be sure. Are you requesting a feature that used to be supported
by StackEdit but no longer is by Classeur?

More or less. StackEdit supports running as a standalone chrome app, but it
doesn't provide a search icon, rendering search a virtually unusable
feature.

I see. But please be aware that this repository only concerns Classeur, not StackEdit. The latter is no longer being developed.

I see. But please be aware that this repository only concerns Classeur,
not StackEdit. The latter is no longer being developed.

I know it. The request is for classeur.

Noted, thank you!
Maybe we can add a search icon to the side-panel:

~Robert

That looks great to me. Regarding the chrome app this is what I mean:
https://developer.chrome.com/multidevice/android/installtohomescreen. Seems
pretty easy.
Btw, stackedit works pretty well in android. There are few decent
alternatives: jotterpad, ia writer, writer+. But as a markdown editor
classeur (and stackedit) wins hands down. I think with a minimal effort you
could be a major player in android or mobile in general.

I think with a minimal effort you
could be a major player in android or mobile in general.

Good reasoning. We will see what we can do.
Thank you again!
~Robert


feat(client): adapt openAPI "cloudCallback"

Pull Request Test Coverage Report for Build 978539912

8 of 42 (19.05%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 84.188%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tensorbay/client/segment.py
8
42
19.05%

Totals

Change from base Build 978461080:
-0.4%

Covered Lines:
4957

Relevant Lines:
5888

💛  - Coveralls

You should add integration test to ensure the open api works.


Duplicate metadata record

This funcionality adds a "Duplicate" command in the action menu in Administartion Management page.This allows to duplicate a selected record, so that it can be used as a template when multiple, similar records must be edited.

Merged using command line.


Allow Function Execution return a non-string object

Why are these changes needed?
When a function call being executed, we want to return the original object. Any non-str objects will be cast to str before being appended to messages to avoid any error.
Minor: Fix print: tool calls will return the name twice.

Related issue number

Checks

[ ] I've included any doc changes needed for https://ag2ai.github.io/autogen/. See https://ag2ai.github.io/ag2/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

@yiranwu0 could you update this PR once https://github.com/ag2ai/ag2/pull/47 is merged?

@yiranwu0 could you update this PR once #47 is merged?

Sure!


Array.from() fails when passed a java.util.HashSet

Array.from() should work for array like and iterable arguments according to
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from
HashSet certainly behaves like an iterable object for other operations as shown in the script below.
const HashSet = Java.type('java.util.HashSet');
const mySet = new HashSet();
mySet.add('test');

// works
const myArray1 = [...mySet];

// works
const myArray2 = [];
for (const v of mySet) {
    myArray2.push(v);
}

// fails
const myArray3 = Array.from(mySet);

Exception thrown from Array.from()
Caused by: org.graalvm.polyglot.PolyglotException: TypeError: getArraySize on java.util.HashSet@e0f4db7 failed due to: Message not supported.
	at <js>.:program(testSet.js:15) ~[?:?]
	at org.graalvm.polyglot.Context.eval(Context.java:345) ~[graal-sdk-20.2.0.jar:?]
	at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:405) ~[js-scriptengine-20.2.0.jar:?]
	at com.oracle.truffle.js.scriptengine.GraalJSScriptEngine.eval(GraalJSScriptEngine.java:347) ~[js-scriptengine-20.2.0.jar:?]
	at javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:249) ~[java.scripting:?]

GraalJS version: 20.2.0

Thank you for the report. The root of the problem is that Array.from() (unlike the other constructs that you mentioned) supports both iterable and array-like objects. If the object has Symbol.iterator property then it is considered iterable. It is considered to be an array-like object otherwise. Java objects (like HashSet) do not have Symbol.iterator property. That's why they end up in the array-like branch that is less capable (with respect to Java objects) than the iterable branch would be. I think that we can tweak the implementation of Array.from() to force objects like HashSet to go through the iterable-branch (which would solve your issue).

Thanks for taking a look, yeah I figured it was being treated as array like. Its not a show stopper for us. Thanks!

Fixed by https://github.com/graalvm/graaljs/commit/0d18028696c17f80a1a1dc0941afed706d1099a7


Visual Editor newly saved state is lost when navigating across tabs.

Describe the issue:

$subject
How to reproduce:

Login to console
Create an application
Navigate to edit->sign-in method
Select the visual editor
Add step and authenticator
Update
Navigate to the user attribute section
Navigate back to the sign in-method

Observe that the last saved state is lost.
Expected behavior:

It should preserve the previous state.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Fixed with https://github.com/wso2/identity-apps/pull/4283


Upgrade to pandoc 2.0

Release notes at:
https://github.com/jgm/pandoc/releases/tag/2.0
http://pandoc.org/releases.html#pandoc-2.0-29-oct-2017

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Note that there could be problems with pandoc-2.0-1-amd64.deb (see https://github.com/jgm/pandoc/issues/4006). We should wait for that issue to be resolved before merging.

Sounds good, lets wait for the next release. Rest is lgtm!

Pandoc replaced the linux build with pandoc-2.0-2-amd64.deb to address the issue above. I changed the templated URL for linux to:
https://github.com/jgm/pandoc/releases/download/{{ version }}/pandoc-{{ version }}-2-amd64.deb

Note the incremented build number. So future PRs will likely have to decrease this back to 1. Should we template this to make it clear:
{% set deb_build_version = "1" %}

Perhaps this is overkill since the sha256 sums always need updating and are in the same section.

NOTE to maintainer: consider squash merging this PR so we don't have multiple commits.

Will have to rebase this PR after https://github.com/conda-forge/pandoc-feedstock/pull/20 is merged which performed a conda smithy rerender to fix the failing builds here.

Will have to rebase this PR after https://github.com/conda-forge/pandoc-feedstock/pull/20 is merged which performed a conda smithy rerender to fix the failing builds here.

@dhimmel sorry for not reading this before. Next time you can use https://conda-forge.org/docs/webservice.html instead of opening a new PR.

Pandoc released v<IP_ADDRESS> with some additional bug fixes compared to v2.0. Will it be problematic that the levels of semantic versioning has changed? Should I switch the PR to v<IP_ADDRESS>?

Pandoc released v<IP_ADDRESS> with some additional bug fixes compared to v2.0. Will it be problematic that the number of semantic versioning levels has changed?

Not really.

Should I switch the PR to v<IP_ADDRESS>?

Yes please :grimacing:

CI builds are passing for v<IP_ADDRESS>


SEGV

https://github.com/redis-rb/redis-cluster-client/blob/256c7dfa81f6f68f3cb555a1215e2afc280cd76b/test/redis_client/test_cluster.rb#L209-L213
https://github.com/redis-rb/redis-cluster-client/blob/256c7dfa81f6f68f3cb555a1215e2afc280cd76b/test/redis_client/test_cluster.rb#L262-L271

I tested the following case in redis-client. But no error occured. I think the segmentation fault is related to fiber.
    def test_subscribe_to_multiple_channels
      channels = Array.new(10) { |i| "chan#{i}" }

      @subscription.call("SUBSCRIBE", *channels)
      @redis.pipelined do |pipeline|
        10.times do |i|
          pipeline.call("PUBLISH", channels[i], "event-#{i}")
        end
      end

      events = []
      while event = @subscription.next_event
        events << event
      end
      events.sort_by! { |e| "#{e[0]}#{e[1]}" }

      expected = []
      10.times { |i| expected << ["message", channels[i], "event-#{i}"] }
      10.times { |i| expected << ["subscribe", channels[i], i + 1] }

      assert_equal expected, events
    end

It's a bit flaky.
https://github.com/redis-rb/redis-cluster-client/actions/runs/5837776394/job/15833854138


training on 5m dataset instead of the original 20m

Hi,
I have been trying to train Minkloc3D on the oxford dataset preprocessed such that each training submap covers 5m of car trajectory and are 2.5m apart as compared to the original training submaps that cover 20m of car trajectory and are 10m apart. The results which I am getting after 40 epochs is very inferior in comparison to the results published. The model was trained with the default parameters. Another interesting thing was that the embeddings collapsed when I increased the batch size to 32 instead of the default 16.
Any insight to solve this issue is appreciated.

Submaps constructed by aggregating 2D LiDAR scans during 5m traversal of the car are rather small. I think 5m is too small for localization/place recognition. This covers only a small part of the building, and there may be many similar parts of the building in different places. Visualize your point clouds, and see if they look good enough for place recognition. I think they are too small and the method will not work.
Did you also change thresholds to generate positive and negative elements? Default thresholds (positive elements are at most 10 meters apart and negative more than 50 meters apart) make sense when point clouds cover 20 meter distance. If point clouds cover 5 meter distance, the positive threshold should be much lower than 5 meter, something like 2.5 meter - so there's sufficient overlap between any two positive examples. Otherwise, the training will collapse.
Also negative threshold should be decreased, to something like 10 meter.
What was the reason to create such small submaps? If you want to increase the precision of the localization - if you want to have better results when evaluating the descriptors with a small threshold (i.e. calculate Recall@k with a small threshold like 5m for true positive), the better option is to:

construct point clouds, so they cover 20m of car trajectory (as in my paper), only sample them denser, so they are 2.5m meters apart
decrease positive and negative thresholds - e.g. positive threshold is 5m and the negative threshold is 15 meters (or maybe even small, 10 meters)
The network should learn, that point clouds with large overlap are similar and if the overlap is small or there's not overlap they are dissimilar.

Closed due to inactivity


no date past 08

hi, in cal-heatmap v3.4.0, (using Chrome 38.0.2125.111 and FireFox v28.0) i'm having an issue where no date past day 08 is displayed, even though i'm using the sample code for Month > hour. Is this a known issue ? (see attachment for screenshot).

var calendar = new CalHeatMap();
calendar.init({
data: "datas-years.json",
start: new Date(2000, 0),
id : "graph_f",
domain : "month",
subDomain : "hour",
range : 1,
cellsize: 6,
cellpadding: 1
});

I just checked, and the month domain + hour subdomain is not supported.
Are you sure you want/need to display a heatmap of 800 nodes ?

Fixed in v4


Middleware of one router gets called while accessing path of another router

const app = express();

export const root = Router();
root.get('/', (req, res) => {
     res.send("Hello World");
})
// middleware 1
root.use(accountAuth);
root.post('/product', product);
root.post('/dashboard', operator, dashboard);

export const account = Router();
account.post('/login', login);
account.post('/forgot', forgot);
account.post('/reset-password', reset_password);

//middleware 2
account.use(accountAuth);
account.patch('/', update_info);
account.post('/logout', logout);
account.patch('/password', update_password);

app.use('/', root);
app.use('/account', account);

In the above code, when I'm sending post request to path /account/login. middleware 1 is getting called.

Hi! This is as designed. Your middleware 1 in the code above you have mounted to / and since  /account/login begins with / it will be executed.
The flow to get there is as follows:

GET  /account/login enters app
Check against app.use('/', root); since /account/login begins with /, it enters root.
GET  /account/login enters root
Check against root.get('/', route. The method matches, but the path does not, so continue to next
Check against root.use(accountAuth); by default everything enters into a plain app.use, the request enters into your middleware 1

I hope that helps


Added the discordCommandManager

I have added a command manager to set the application commands globally or by guild, as well as delete commands globally by guild.
Minor modification as made to the bot manager to get the ID and token for the push command.
Setting commands can be done by using msg.commands, e.g.
var pingCommand = new SlashCommandBuilder()
.setName('bloop')
.setDescription('Replies with bloop!');
msg.commands = [ pingCommand ]
msg.action = "set"
Deleting commands can be done by setting the commandId, e.g.
msg.action = "delete"
msg.commandId = "181512451821"
It respects msg.guild, so it can delete/set per guild or globally if msg.guild is not set.

@JuliaSoriaSmith in order to use this approach, will It be needed to have installed the discord.js package, like It has been working until now? Because I has been thinking a lot about it.
The current approach was created as a quick solution, but for future work like you has done now.
I will test it this weekend
thxs

Yes it will need discord.js, it depends upon it similar to other nodes. Do you want to move away from discord.js?

Installing discord.js for function nodes can be lead to mismatching versions between function node  and node-red-contrib-discord-advanced versions.
The suitable options that i was thinking about are:

discord js commands as strings

var pingCommand = "new SlashCommandBuilder().setName(\'bloop\').setDescription(\'Replies with bloop!\');"

A full node  for designing commands, with a nice editor (The best options but it takes some time to code it)

I think we can deploy a npm version with your approach and then, with more time, to improve it.

I have working an example.

After the changes committed, we need to create a entry on wiki to explain how the node works and to add some flows examples

This also works
var pingCommand = {
    name: "bloop",
    description: "Replies with bloop!"
};

msg.commands =  pingCommand;

msg.action = "set";
return msg;

This example is using json format for commands creation
https://discord.com/developers/docs/interactions/application-commands#making-a-global-command


fix: [M3-7055] - Metadata Image select dropdown fixes

Description 📝
We got feedback that the Image Select dropdown is less dense than it used to be, which increases the amount of scrolling needed to find a distribution. It is also alarming to see the cloud-init incompatible icon on most distribution images since they do not support it yet.
This PR addresses the above by making each select item dense again and also swaps the logic in how we display the cloud-init icon so that the icon only displays on compatible images instead.
Major Changes 🔄

Fix select item row height
Cloud-init incompatible icon -> Cloud-init compatible icon

Only show icon for compatible images instead of incompatible images

Preview 📷

Before
After

How to test 🧪
Go to /linodes/create and check the distribution image dropdown

Fair, though wasn't the thought that they were going to support it by the time metadata was released?

@mjac0bs Yeah, that was the original thought but now we don't know when all the distros will be supported


chore: pre-release

#1  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @GoodM4ven and the rest of your teammates on  Graphite


Make description and guidance for "sample linkage" consistent

Description for "sample linkage" appears to ask the user to list an ID. How does the user indicate the relationship of the listed ID  for "sample linkage" to the sample ID of this row?

Suggest that if this term expects an ID, that the same guidance provided for "Globally Unique ID" should also be provided here for formatting guidance.
Additional guidance to the user should be provided for specifying the relationship (e.g. "IGSN:DSJ0284;parent" could mean that IGSN:DSJ0284 is the sample ID of the parent biosample). This likely requires more discussion with the metadata team.

Further, the current guidance for "sample linkage" is inconsistent with the Pattern hint, the Description, and the Examples.

Please review @mslarae13 and identify a path forward before assigning to @turbomam

Agreed the definition vs guidance vs example isn't clear. You're correct in how the cell is meant to be formatted. "e.g. "IGSN:DSJ0284;parent" could mean that IGSN:DSJ0284 is the sample ID of the parent biosample" except for the ;parent part... i expect we would want each sample relationship separated by a ; ... so more like IGSN:DSJ0284,parent; IGSN:DSJ0284,plant
But I'm not sure if that's east to deal with on the compute side.. I'll let @turbomam comment on how we should require this formatting so it's computer friendly.
Examples & pattern need updated however we decide to display.


documentation not clear for 'make setup_dualCni_cilium' command

Spiderpool Version
latest
Bug Type
Installation Issue
Main CNI
cilium
What happened?
Simply running 'make setup_dualCni_cilium' per webpage doc, and got this error:
'docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: open /proc/sys/net/ipv6/conf/all/disable_ipv6: no such file or directory: unknown.'
What did you expect to happen?
The doc should be clear to say if ipv6 is disabled, then use this instead:
E2E_IP_FAMILY=ipv4 make setup_dualCni_cilium
How to reproduce it (as minimally and precisely as possible)

disable ipv6 in linux kernel
run 'make setup_dualCni_cilium'

Additional Context
No response

hi，make setup_dualCni_cilium 将会默认启动 ipv6 设置，可能您遇到是其他问题，比如设置 IPv6 失败？不需要更改文档？
- sudo sysctl -w net.ipv6.conf.all.disable_ipv6=0


CIP-100 | Canonical example is wrong

The canonical form of the example is wrong, for example it misses the hashAlgorithm key

Good spot!
I will get a PR to fix this one shortly.

See #782

It is not intended to include the hashAlgorithm key; see the comment I just left in #782

The example was fixed, thank you


I just edited the README.md

Hey its just a github fork and contribute sample

and you must say "yaa good let's merge this to master branch"


Make it possible to move messages by recency

Fixes #20502

Regardless of the answer to the above, let's just show the time down to the minute, without the seconds. I don't think that level of precision is helpful here.

I think we should drop either "last 7 days" or "last 10 days" as an option; it would be very hard to meaningfully pick between the two in this UI. Let's drop "last 7 days", I guess.

After seeing it, I think we need to rearrange the modal a bit. In particular:

a) Make the heading be: "Move messages from <topic name>.
b) Make the label above the destination just say "Destination:"
c) Make the label for which message to move say: "Move messages since:"
d) Accordingly, change the dropdown labels "Last X hours" -> "X hours ago"; the other labels stay the same.
e) Change the three-dot menu option label "Move topic" -> "Move messages".

"Error: No messages to move." sounds good to me.
Would it be possible to change it to work the other way, i.e. from when the dropdown selection is made? That way we can clearly communicate to the user what's actually going to happen.

5. Yes, exactly, I was thinking we would change the top header. Putting the name fo the topic in it seems pretty consistent with how we do other modals, e.g.:

If the topic name is too long to fit, I think we should just abbreviate it with a "...". Anyway, I think we should give it a try.
Thanks!

Hey @chdinesh1089 , this isn't as important as pushing your other PRs forward, but just a bump here in case you get a chance to address the feedback above.

@chdinesh1089 do you have time to rebase this? I'd like to push on integrating it.

Sure, will rebase during the weekend.

@alya based on your above comments changed the UI to the following

@timabbott I've rebased this. We can merge the backend parts of this if it looks good.
Thanks for the review, @asah!

Thank you for trying the topic name in the header! Looking at your screenshot, the space looks a bit tight, and it might be better to include the stream name too, which would make it even tighter. Maybe we should try something like:
Move messages
Moving messages from #stream > topic.
Destination:

It also looks like there's a failing test -- I don't know if that's expected?


Abandoned?

Has this project been abandoned?

Hey @JaredBanyard, I apologize for the lack of activity here. @siyengar and I have been pretty busy at Facebook over the last few months. We have a plan for things we want to accomplish/improve with regards to Conceal and you should see some love towards this pretty soon. In the meantime, feel free to send in pull requests for features you'd like to add.

Still seems like no progress


⚠ Bofrost.es has degraded performance

In 8c77590, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1635 ms

Resolved: Bofrost.es performance has improved in 47e0ff1 after 19 minutes.


fix: support internal Android runtime ts files during debug

Related to: https://github.com/NativeScript/nativescript-vscode-extension/issues/234

run ci


[Event Request] table 5374 "CRM Synch. Conflict Buffer", OnValidateCRMIDBeforeInitRecordOrigin

We need a new event in table 5374 "CRM Synch. Conflict Buffer" in OnValidate of CRM ID
REASON: We have implemented logic for Work Orders and need custom logic for determining the corresponding CRM table
    [IntegrationEvent(false, false)]
    local procedure OnValidateCRMIDBeforeInitRecordOrigin(TableID: Integer; var CRMSynchConflictBuffer: Record "CRM Synch. Conflict Buffer"; var IsHandled: Boolean)
    begin
    end;

    trigger OnValidate()
    var
        CRMIntegrationRecord: Record "CRM Integration Record";
        IntegrationSynchJobErrors: Record "Integration Synch. Job Errors";
        IntegrationTableMapping: Record "Integration Table Mapping";
        CRMSetupDefaults: Codeunit "CRM Setup Defaults";
        RecRef: RecordRef;
        FieldRef: FieldRef;
        TableID: Integer;
    begin
        if CRMIntegrationRecord.FindByCRMID("CRM ID") then begin
            if CRMIntegrationRecord.GetLatestError(IntegrationSynchJobErrors) then begin
                "Error Message" := IntegrationSynchJobErrors.Message;
                "Failed On" := IntegrationSynchJobErrors."Date/Time";
            end;
            TableID := CRMIntegrationRecord.GetTableID();
//EVENT REQUEST
            OnValidateCRMIDBeforeInitRecordOrigin(TableID, Rec, IsHandled);
            if not IsHandled and (TableID <> 0) then begin
//         if TableID <> 0 then begin
//EVENT REQUEST
                "Int. Table ID" := CRMSetupDefaults.GetCRMTableNo(TableID);
                if CRMIntegrationRecord.GetCRMRecordRef("Int. Table ID", RecRef) then begin
                    FieldRef := RecRef.Field(CRMSetupDefaults.GetNameFieldNo(RecRef.Number));
                    "Int. Record ID" := RecRef.RecordId;
                    "Int. Description" := FieldRef.Value;
                    "Int. Record Exists" := true;

                    IntegrationTableMapping.SetRange(Type, IntegrationTableMapping.Type::Dataverse);
                    IntegrationTableMapping.SetRange("Table ID", "Table ID");
                    if IntegrationTableMapping.FindFirst() then begin
                        FieldRef := RecRef.Field(IntegrationTableMapping."Int. Tbl. Modified On Fld. No.");
                        "Int. Modified On" := FieldRef.Value;
                    end;
                    RecRef.Close();
                end;
            end;
        end;
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 11547.


Missing padding next to > for Exposure notification button (iOS/Android)

both iPhone Xr and Galaxy S8+ (android version 9)
French
Exposure notifications = Off
app Home screen shows the Exposure notification button. the text seems to be overlapping with the > image.

Note that the Android has different font settings on the phone.

@mmiron-HC can you confirm if this is still an issue? Phones have the ability to change font and size, we are hoping to ensure things work properly up to 200% font increase or zoom/magnification.

The text seems to be considerably reduced.

@mmiron-HC could you review please? Thanks!

Thanks @mtropper. The text was changed on this screen to be shorter.

confirmed


Support using LLMs to respond to CritiqueRequests

Currently, we use human workers on a labeler platform such as Surge AI to respond to CritiqueRequests. It would be good if we could also support asking LLMs for critiques.
We would also need to come up with some way for users to configure which backend they want to use for critiques.

Fixed in #1627.


Make an outline for Shape

This should create outlines to the Shapes (Circle, SemiCircle, and Line). My concern is that for outline to behave properly in Line, "preserveAspectRatio" (line#22) that is set to none should be commented out, which might break existing code.
I can change it back if you think it should be that way, but it might need more documentation to show how to achieve the outlines.
References #155 , though this is in addition to trail.

Great! That's it!

I have a little change though that would make it even better:
In circle.js:
In the constructor add another template for outline only at the outer radius:
    this._pathOuterOutlineTemplate =
      'M 50,50 m 0,-{outer_radius}' +
      ' a {outer_radius},{outer_radius} 0 1 1 0,{2outer_radius}' +
      ' a {outer_radius},{outer_radius} 0 1 1 0,-{2outer_radius}';

Use this template if strokeWidth >= 50 in _outlineString():
Circle.prototype._outlineString = function _outlineString(opts){

...
  if(opts.strokeWidth < 50) {
    return utils.render(this._pathOutlineTemplate, {
      inner_radius: inner_r,
      '2inner_radius': inner_r * 2,
      outer_radius: outer_r,
      '2outer_radius': outer_r * 2
    });
  }
  else {
    return utils.render(this._pathOuterOutlineTemplate, {
      outer_radius: outer_r,
      '2outer_radius': outer_r * 2
    });
  }
};

With this change a progress circle with this style is possible:

Without it would look like:

Sure.  Will add that as well. But I'm not sure how consistent that would be. Ppl expecting outlines inside won't know it changes at the 50% mark.  Will need more documentation in that case.

Sorry for the super delayed response. Comments addressed.

Thanks for the really good effort. However I think this is something that doesn't need to be in the core library. It's possible to make custom Shapes because the Shape is also exported. With these pieces you can make a custom CircleWithOutline progress bar.


Fix typo in replace.h

Summary of the Pull Request
Fixed typo.
occurences -> occurrences

References

PR Checklist

[ ] Closes #xxx
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
[ ] Schema updated.
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Huh. This should probably get taken out of dictionary.txt too, since that looks like it's allowing this typo/.
@jsoref as an fyi

Thanks. I keep running into this but hadn't gotten around to looking under the hood. Added to https://github.com/check-spelling/check-spelling/wiki/Archaic-words
I suspect I'll release a slightly condensed dictionary by this summer.

Thanks!


Example for create media

Hi!
Can you give me some example for create media, please ?
I try but not success :(.

I've been struggling with the same; I've managed to get the filename to show up in the wordpress media library but there is no data stored with it.
wp.create_media(headers={'Content-Disposition': 'attachment; filename="1037659601.jpg'}, data=open(filePathToImage).read().encode('base64'))
Any help from the creators would be nice.

Hi @droustchev do you think you can help us?

Hi @AjayAjaal @JonhNathan987456,
Thanks for your feedback. Unfortunately I'm not able to provide support for these issues at the moment. I'm not sure if @droustchev would have time either.
At the time that we wrote this wrapper, the JSON API was a plugin for Wordpress, and we only supported Basic Auth for authentication. Since version 4.7, the plugin was added to core Wordpress, and I don't think Basic Auth works any more. I believe we need to update this lib to work for 4.7, and for that I would need to also support a different form of authentication.
In short, I'm not sure it makes sense for us to troubleshoot these issues until that underlying problem is fixed, which may take some time.

@AjayAjaal, I tried uploading a file via curl, but have the same issue as you. I wasn't able to figure out how the WP API expects file uploads. If you can provide a curl command that works or a link to some documentation from WP, I can see what needs to be changed in the wrapper. Here is what I tried:
curl -v -u {WP_USER}:{WP_PASSWORD} -H "Content-Disposition: attachment; filename=test.jpg" -d {BASE64_ENCODED_FILE} -X POST http://{WP_HOST}/wp-json/wp/v2/media

#17  can help you!

@happyraul any news?

I'll block some time next week to work on this library.


fix: adding web3 to dependencies

What kind of change does this PR introduce (bug fix, feature, docs update, ...)?
Bug fix
What is the current behaviour (you can also link to an open issue here)?
#280
What is the new behaviour (if this is a feature change)?
Other information:
By including web3 module in the dependencies, the library will be included in the npm package, preventing the issue #280 .

Thanks for the PR, to reduce size, let's import from web3-utils rather than adding web3 to the lib, as done here:
https://github.com/ERC725Alliance/erc725.js/pull/282
I will close this PR and merge the one above.


Maya: Use frame range from task attributes

Changelog Description
A bug fix for the issue reported here https://github.com/ynput/ayon-core/pull/323#pullrequestreview-1970044683
Frame Range values should be taken from task level attributes.

Testing notes:

Launch Maya
Reset Frame Range

Would be great to merge this relatively close to this PR https://github.com/ynput/ayon-core/pull/39 so the validator aligns with this as well.


Replace http-browserify with axios

Just curious - what was the reason to switch to this library?

Basically, http-browserify is poorly written browser drop-in replacement for node http module.
It pulls with it a number of other replacement modules for things like buffers and streams not required in browser environment outside supporting compatibility with original http module.
It lacks certain important properties of original module requiring us to hack around them or fork (which we actually did). Also, browser environment has its own specifics (CORS) that are not implemented in original module and has only minimal support in http-browserify. This is the reason we can't distinguish between CORS error and an absence of connection on st2web side.
But any of this problems could have been solved if only https://github.com/substack started merging PR's. This is the last commit in the repo https://github.com/substack/http-browserify/commit/17b2990010ebd39461d1117c1e2c50c25eab869f.

Thanks for the clarification - I'm all for using more supported and maintained library.

LGTM. Axios is nice.

@enykeev Have you compared axios to superagent? I've seen many positive comments about superagent, but haven't had a chance to use it. Never heard about axios, though. Just curious if axios is the modern HTTP client of choice.

@alex-shnayder I definitely tried it, although I don't remember any specifics.
One thing I can say for sure is that superagent has only basic support of promises (it isn't even a promise, literally thenable https://github.com/visionmedia/superagent/blob/1822e9ffbeb6e17b67465bebc1e47b59b2037783/lib/node/index.js#L1034, don't even have catch) while axios always return proper promise (though the version we use treats promise as a part of the language so assume nodejs>=0.11).
Dunno about "the modern HTTP client of choice", there might be better ones, but it looks damn solid to me.


⚠ Bofrost.be has degraded performance

In ca7f0a6, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1134 ms

Resolved: Bofrost.be performance has improved in 97bcba4 after 8 minutes.


Recognize all heap regions in process memory tab

RtlQueryProcessDebugInformation can return information about each heap
memory segment. So we can use that to properly mark heap related memory regions.
This only works for native processes because RtlQueryProcessDebugInformation
doesn't work well for WoW64 processes.
Fixes #1050.

Here is quick comparison with my test application:
Before:

After:


Expose raw fitted GLM model in report

Addresses: https://github.com/JuliaAI/MLJGLMInterface.jl/issues/40
This PR add :raw_glm_model to the list of user-specifiable report items (controlled by the report_keys hyperparameter.
The default keys now includes the new :raw_glm_model key (and all other keys, as presently the case). This means that, by default, the report points to the training data, because raw GLM models do so. I'd suggest we tag this change as breaking for this reason, although technically, adding a keys, doesn't break the API.

I think it would also make sense to not have raw_glm_model enabled by default

Done.

Addresses: #40
This PR add :raw_glm_model to the list of user-specifiable report items (controlled by the report_keys hyperparameter.
The default keys now includes the new :raw_glm_model key (and all other keys, as presently the case). This means that, by default, the report points to the training data, because raw GLM models do so. I'd suggest we tag this change as breaking for this reason, although technically, adding a keys, doesn't break the API.

Maybe we can change the name of :raw_glm_model to glm_object or something else. It's just a suggestion though.

How about glm_model?

Thanks @ablaom and @OkonSamuel!


Update http4s-blaze-client, ... to 0.23.15

Updates

org.http4s:http4s-blaze-client
org.http4s:http4s-blaze-server

from 0.21.34 to 0.23.15.
GitHub Release Notes
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Applied Scalafix Migrations

org.http4s:http4s-.*:0.22.0

github:http4s/http4s/v0_22?sha=series/0.22

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.http4s" }
}]

labels: library-update, early-semver-major, semver-spec-minor, version-scheme:early-semver, scalafix-migrations, commit-count:n:2

Superseded by #529.


Prefixing of favorites with '*' is not a good idea

Very nice script, I tried it on windows with WSL (windows subsystem for linux) and it works quite well.
The only problem is, I had to disable prefixing favorites with '' as this is a wildcard on windows and you cannot create files and folders, which contain '' or '?' on this system.
Maybe you should use '#' instead of '*'

Thanks for your interest and the note about the ''. I like the '' and I'd rather not make this a fully cross-platform script just because of the many limitations of Windows ;-) :-) (there are many more characters forbidden than on macOS; also reserved filenames).
With the flags and paths at the beginning, the users are already expected to edit the script to fit their needs, including the mac-specific icon.
So what if we put the prefix string into a constant at the beginning of the the script, too, and use that in line 120?

Perfect!
I think handling this with a constant is the best approach.


Missing debug profile (compability) with worker projects

I've tried to enable debugging a worker project using the SDK container build, but failed to do so.
Apparently, only the Web SDK supports SDK container style debugging.
It'd be great if the other SDKs would also support the SDK container style debugging like the Web SDK does.
I tried with this project and launch settings:
Worker.csproj
<Project Sdk="Microsoft.NET.Sdk.Worker">

  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <Nullable>enable</Nullable>
    <ImplicitUsings>enable</ImplicitUsings>
    <LangVersion>latest</LangVersion>
  </PropertyGroup>

  <PropertyGroup>
    <IsPublishable>true</IsPublishable>
    <EnableSdkContainerSupport>true</EnableSdkContainerSupport>
    <EnableSdkContainerDebugging>True</EnableSdkContainerDebugging>
    <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
    <ContainerRuntimeIdentifier>linux-x64</ContainerRuntimeIdentifier>
    <ContainerRepository>test-worker</ContainerRepository>
    <ContainerImageTag>latest</ContainerImageTag>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Extensions.Hosting" Version="8.0.0" />
    <PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.20.1" />
  </ItemGroup>
</Project>

launchSettings.json
{
  "profiles": {
    "Container (.NET SDK)": {
      "commandName": "SdkContainer",
      "launchBrowser": false,
      "environmentVariables": {
        "DOTNET_ENVIRONMENT": "Development"
      }
    }
  },
  "$schema": "http://json.schemastore.org/launchsettings.json"
}

Results in Visual Studio 17.9 giving me this error message:

When chaning the project SDK to Microsoft.NET.Sdk.Web, debugging works fine.
Publishing is not affected. This works fine. The debug functionality is missing.

Interesting catch! @danegsta is this something that should be reported in VS developer community for triage on the VS docker tools side?

Broadly speaking in 8.0.100 Worker SDK projects should be able to be debugged in this way, and from 8.0.200 onwards any project with the EnableSdkContainerSupport property set to true should be able to be debugged in this way.

Installed SDK version is 8.0.204.
For me it feels like the Visual Studio tooling is lacking some things, as most of it had to be assembled by hand, taken from the Web SDK. Just reporting here due to the error message.

Sorry @Herdo - you're totally right, my comments were intended for the VS Docker tools team as a guideline for how to think about what project types can be containerized in what SDK versions when updating the VS features. No reflection on you or your report at all.

@Herdo please raise this over at the VS Developer Community portal to get it seen by the appropriate team.


desired_count does not work when using FARGATE capacity provider

Please complete the issue template provided

Nice that you are answering on this but if I would complete the issue there would not be any answer in weeks.
I will figure it out. As you can clearly see the operator in the desired_count it looks like intentionally ignored (Null) when using  FARGATE capacity provider

have you read the provided documentation https://github.com/terraform-aws-modules/terraform-aws-ecs/tree/master/docs#service-1


fix(workflows): implement backoff for timeouts

Changes

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1111  👈
#1105 : 1 other dependent PR (#1106 )
#1104
#1102
#1101
#1100
#1099
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on  Graphite


'package add' from universe

@larioj there is an empty test_experimental.py file in this PR, can it be deleted if you don't plan to add code to it?

@larioj back to you


[files] Not all legacy URLs redirect properly

Task list

[x] Mixed-case GUIDs should redirect to their corresponding lower-case URLs
[x] /project/<pid>/files/download/<filename>/version/<version>/ should redirect to /<guid>/version/<version>/ Examples (should resolve to https://osf.io/3bqw7/version/1/):

[x] https://osf.io/w6fp4/osffiles/Philip_Guo_chapter.pdf/version/1/
[x] https://osf.io/w6fp4/files/download/Philip_Guo_chapter.pdf/version/1/

[x] /project/<pid>/files/download/<filename>/ should redirect to /<guid>/ Examples (should resolve to https://osf.io/3bqw7/):

[x] https://osf.io/w6fp4/osffiles/Philip_Guo_chapter.pdf/
[x] https://osf.io/w6fp4/files/Philip_Guo_chapter.pdf/

This one currently redirects to the download page instead of the preview page

Ruben's original post
I used the OSF as a repo for my complete analyses in a recent submission.
In the first round, the reviewers could not find the necessary files because of UI (cf. #93 ), they would have had to click through from the component dashboard to the full Wiki view, and then either find the direct links to the project files or navigate through the file-folder tree structure.
In the second round, I linked them right to the Wiki homepage, i.e. https://osf.io/wlrzf/wiki/home/
I had to hard-link the HTML reports that I generated using knitr, because non-technical types would not understand that when they click on the link and see HTML syntax (i.e. https://osf.io/wlrzf/osffiles/5-figures.html/ ), that this is not a bug and that they have to click a very small download-file-icon to get to the real deal (i.e. https://osf.io/api/v1/project/wlrzf/osffiles/5-figures.html/version/1/).
Unfortunately sometime between my revision submission and the reviewer checking in, you changed your folder structure.
The search & replace I had to do for my links was:

making my mixed-case project name all lower-case (I think you should be supporting both in the API)
replacing /files/download/ with /osffiles/

This caused some embarrassment for me as it now seemed to the reviewer as if I was unable to maintain a navigable web site in two attempts.
The error messages for missing files are also written in JSON, because this is the file API, I know, but still it probably confused my reviewer a lot reading: {"code": 500, "referrer": null, "message_short": "Unknown error.", "message_long": "Unknown error."} and {"code": 404, "referrer": null, "message_short": "Page not found.", "message_long": "The requested resource could not be found."}.
I'd suggest you implement redirects for old-style links, so that other users don't run into the same issue.
If you prefer users not directly linking to API links because the implementation is not solid yet, then you could (1) change the view for files where simply showing the the code is not particularly user-friendly, such as HTML, e.g. by making them downloadable directly or removing the code from the preview and just putting a huge download button there (2) give a recommendation against using such file types (maybe I could have saved myself the hassle with PDFs?)

The https links now serve the centerforopenscience certificate instead of the openscienceframework one, so my supplement is still broken.

The HTTPS links in Ruben's wiki now resolve to the correct content. @rubenarslan, sorry for the inconvenience, and let us know if you encounter any other issues.

Thanks.

The only remaining item in the original list has also been fixed. In light of that, I'm going to go ahead and close this issue.
@rubenarslan - my apologies that this has been a recurring problem for you. We take the persistence of URLs very seriously and have implemented procedures to help prevent this sort of thing from happening in the future.

@lyndsysimon actually the last remaining item still goes to the direct download. The item says it should go to the preview page.
Thanks for adding tests and being responsive to your users! And next time I'll even be able to submit a PR myself, wasn't possible back then. Progress all around :-)

Following the link seems to go to the view now. Reading this issue I believe it may be resolved? If not am I missing something @rubenarslan?

now it does. great.

this new/temporary? link is now broken though, no idea what that means https://osf.io/3bqw7/version/1/

Ping @chennan47 -- above? ^^

@chrisseto any idea?

Looks like the url is getting parsed incorrect and the file name is being interpreted as <actual filename>/version/1/.

@rubenarslan did https://osf.io/3bqw7/version/1/ ever resolve properly?
It seems that when file GUIDs, the osf.io/<someid>/ format, were introduced support for /version/1/ was dropped and we started specifying versions as query parameters, ?version=1.
The correct url would be https://osf.io/3bqw7/?version=1 or the long/legacy version https://osf.io/<projectid>/osffiles/<filename>/version/1/

Yeah it did, but honestly it was so long ago, I can hardly remember (it was just what one of my legacy URL was supposed to redirect to). Just wanted to point it out, since I created the issue.


fix: Async.File tag fix

tag duplicate/typo fix.
suggestion.
How about helptag check process include CI like vital.vim?

Nice! Thanks!


Allow customization ENABLE_BITCODE and SDKROOT setting.

Description: Allow customization of ENABLE_BITCODE and SDKROOT setting in order to have more precise control over iOS target build settings for Cordova 3.8.0.
Notes: Related to https://github.com/Icenium/BpcTooling/pull/424.

ping @galexandrov @Mitko-Kerezov @mbektchiev

:+1:

:+1:


refactor kitchen tests

What does this PR do?
Refactors kitchen tests.
This is broken down into several components
renaming test files
The kitchen test file names all started with kitchen-azure.  I removed the kitchen because that was not disambiguating at all (they're all kitchen tests), and the azure because those files contained nothing that was azure specfic
Moved the test files to a separate subdirectory because (at least for me) it's easier to tell the test definitions from the test implementations (rspec) from the recipes used to provision the test that way.
Creating invoke task
The script that creates the kitchen tests in CI was already concatenating multiple files into one master kitchen file.
By creating an invoke task, I could separate this out and have a generic way of creating the master kitchen.yml independent of the driver (azure, ec2, etc.)
define test images in a single JSON file
The definition of which image to use to do the test (on a per OS basis) was spread throughout the .gitlab-ci.yml configs.  This was decentralized, and it led to (in some cases) different base OS images used for the same OS version (i.e. different base images for, for example, ubuntu-20-04).  By centralizing in a single platforms.json, then when the image needs to be changed for some reason it needs only to be changed in one place.
This of course does have the downside that if it was intentional using different base images for the same OS, then I've broken that.  It could be handled (by using different keys in the platforms.json, but at this moment that behavior would have regressed.
Motivation
Major motivation was to be able to use the same infrastructure to run kitchen tests across multiple different back-ends.
Using this change, the ci continues to use azure.  however, the invoke task can be used to create a configuration file to do the (right now windows only, but should be easy to add to the platforms.json) tests on ec2.  By supplying different arguments to the invoke task, you'll get a different driver (back-end), but ensured that you're running the same test as is done in CI.
Furthermore, there are drivers that are environment specific (the hyper-v and vagrant drivers).  These drivers depend
on specific locations.  The invoke task allows supplying a local platforms.json so that developers who have local hyper-v or vagrant configurations can still generate kitchen tests that use that environment, and still be assured they use the same test
as ci.
Additional Notes
The result of this PR is that, for example, I can run the upgrade agent 7 tests on ec2 by simply running
inv kitchen.genconfig --platform=windows --provider=ec2 --testfiles=upgrade7-test
and then
aws-vault exec sandbox-account-admin -- kitchen test
Describe your test plan
Write there any instructions and details that should be tested during the QA.

Administrative merge because circle failure is unrelated to change