Add typescript definitions

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/51100

@maykon-oliveira: 😢
new EditorJS({
  ...
  tools: {
    header: Header,
  }
}

Type 'typeof Header' is not assignable to type 'ToolConstructable | ToolSettings<any>'.
  Type 'typeof Header' is not assignable to type 'BlockToolConstructable'.
    Types of property 'sanitize' are incompatible.
      Type '{ level: boolean; text: object; }' is not assignable to type 'SanitizerConfig'.
        Property 'text' is incompatible with index signature.
          Type 'object' is not assignable to type 'TagConfig | ((el: Element) => TagConfig)'.
            Type 'object' is not assignable to type '(el: Element) => TagConfig'.
              Type '{}' provides no match for the signature '(el: Element): TagConfig'.

any hint to solve this?

Seems the definition in https://github.com/maykon-oliveira/DefinitelyTyped/blob/e65fa0cfba7e99fbe7c18cd933477faf78c2cd0e/types/editorjs__header/index.d.ts#L39
boolean | { [attr: string]: boolean | string }
https://github.com/codex-team/editor.js/blob/51d94e1a1103dcf15cf91d8bb9f2596a4c8883e4/types/configs/sanitizer-config.d.ts#L5

I get the same error as in https://github.com/editor-js/header/issues/23#issuecomment-812710580

I believe though, that the whole Header class should implement ToolConstructable (or better, BlockToolConstructable). Then you would also see those errors in IDE without trying to actually compile to use with EditorJS

I think this would be the only and proper solution, right @talyguryn ?

Hi guys!
I have the same problem with my project.
Is there anyone making a port to TS? or may I upload a PR converting this module to TS?

@maykon-oliveira: 😢
Adding to EditorJS like this:
new EditorJS({
  ...
  tools: {
    header: Header,
  }
}

Causes following type error:
Type 'typeof Header' is not assignable to type 'ToolConstructable | ToolSettings<any>'.
  Type 'typeof Header' is not assignable to type 'BlockToolConstructable'.
    Types of property 'sanitize' are incompatible.
      Type '{ level: boolean; text: object; }' is not assignable to type 'SanitizerConfig'.
        Property 'text' is incompatible with index signature.
          Type 'object' is not assignable to type 'TagConfig | ((el: Element) => TagConfig)'.
            Type 'object' is not assignable to type '(el: Element) => TagConfig'.
              Type '{}' provides no match for the signature '(el: Element): TagConfig'.

What happened I want to use inline tools or others feature ? When I tried to use inline tools or other it gives the same error
          header: {
            class: Header,
            inlineToolbar: true,
            config: {
              defaultLevel: 1,
              levels: [1, 2, 3],
            },
          },

Same error here...

this worked for me
import { ]ToolConstructable } from '@editorjs/editorjs';
...
header: {
   class: Header as unknown as ToolConstructable,
   config: {
      defaultLevel: 3,
      levels: [3, 4],
   },
},

same error

same error

// @ts-ignore
import Header from "@editorjs/header"

If you’re still encountering this issue, here’s how I resolved it. I can’t guarantee this is the best practice, as I’m not a TypeScript expert, but it worked for my case.
To fix the error, create a types.d.ts file in your project and add the following code:
declare module '@editorjs/simple-image' {
	import { ToolConstructable, ToolSettings } from '@editorjs/editorjs';

	const SimpleImage: ToolConstructable | ToolSettings;
	export default SimpleImage;
}

declare module '@editorjs/checklist' {
    import { ToolConstructable } from '@editorjs/editorjs';

    const Checklist: ToolConstructable | undefined;
    export default Checklist;
}

declare module '@editorjs/warning' {
    import { ToolConstructable, ToolSettings } from '@editorjs/editorjs';

    const Warning: ToolConstructable | ToolSettings;
    export default Warning;
}

declare module '@editorjs/marker' {
    import { ToolConstructable } from '@editorjs/editorjs';

    const Marker: ToolConstructable | undefined;
    export default Marker;
}

declare module '@editorjs/code' {
    import { ToolConstructable } from '@editorjs/editorjs';

    const Code: ToolConstructable | undefined;
    export default Code;
}

declare module '@editorjs/link' {
    import { ToolConstructable, ToolSettings } from '@editorjs/editorjs';

    const Link: ToolConstructable | ToolSettings;
    export default Link;
}

declare module '@editorjs/embed' {
    import { ToolConstructable, ToolSettings } from '@editorjs/editorjs';

    const Embed: ToolConstructable | ToolSettings;
    export default Embed;
}

declare module '@editorjs/header' {
    import { ToolConstructable } from '@editorjs/editorjs';

    const Header: ToolConstructable | undefined;
    export default Header;
}

declare module '@editorjs/list' {
    import { ToolConstructable } from '@editorjs/editorjs';

    const List: ToolConstructable | undefined;
    export default List;
}

declare module '@editorjs/table' {
    import { ToolConstructable } from '@editorjs/editorjs';

    const Table: ToolConstructable | undefined;
    export default Table;
}

declare module '@editorjs/quote' {
    import { ToolConstructable } from '@editorjs/editorjs';

    const Quote: ToolConstructable | undefined;
    export default Quote;
}

@rogix this seems like the best approach.  thx for posting.

You should use the latest version of this tool where type definitions are added


widgets: time-series: responsive [WIP]

re: https://github.com/CartoDB/cartodb/issues/12470
this will eventually point to master, when https://github.com/CartoDB/deep-insights.js/pull/562 is merged

cartodb PR: https://github.com/CartoDB/cartodb/pull/12543
deep-insights.js PR: https://github.com/CartoDB/deep-insights.js/pull/566
cartodb.js PR: https://github.com/CartoDB/cartodb.js/pull/1709

pulling the changes from time-series aggregations, and timezones, plus:

[x] implemented responsive behaviour for Tablet and Mobile viewports
[x] added timeslider tip to timeslider view, and static tips to time-slider header
[x] added viewport utils
[ ] tests

there's only one thing I'm not specially happy about which is updating the static tips, when dragging the handles, however I couldn't find a better approach using the rangeFilter, as it is only updated on brush end
acceptance

test time-series, animated time-series, AND normal histogram in desktop, tablet, and mobile viewport, selecting range, playing, and updating the timezone and local timezone for timestamps
heights should vary
timestamps should vary, and update on dragging and click interactions
tips should change behaviour

test again with number type column, they should work as expected
check the Invision project for the designs

advanced a bit on the testing front, I feel the lack of specs disturbing

[ ] _updateTriangle
[ ] _updateAxisTip
[ ] _onChangeDragging
[ ] _toggleAxisTip
[ ] _hideAxisTip
[ ] _showAxisTip
[x] _generateChartContent
[ ] _setupBrush
[x] _generateAxisTip
[x] _isTabletViewport
[ ] _generateHandle
[ ] _updateChart
[x] _isMobileViewport
[ ] _generateBars

finished the specs, I didn't test the X position for the tip at the beginning / middle / end of the timeline, just the Y because it could be crazytown (and it wasn't actually the scope of the PR, just for the timeslider tip)

retest this, please

Was this accepted?

Yes, the last changes was just one test failing in Travis, but code review and acceptance were already done.


fix(protocol): Don't reserve memory on packet decoding error

Description
This MR fix https://github.com/Snowiiii/Pumpkin/issues/354 by returning in client poll function to avoid reserving 4096 bytes for each wrong packet

Testing
Using the small program provided in https://github.com/Snowiiii/Pumpkin/issues/354 and see that ram never went up

Checklist
Things need to be done before this Pull Request can be merged.

[x] Code is well-formatted and adheres to project style guidelines: cargo fmt
[x] Code does not produce any clippy warnings: cargo clippy
[x] All unit tests pass: cargo test
[ ] I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

Works 👍
Now there is only rate limiting left (for another pr) so we don't burn the CPU :P
Normal

Spam

Wait, shouldn't it return false ?

Looks good.
Thank you @HookWoods


Too slow to open marksrv server page.

It's very slow to load the page served by markserv server. After check the Chrome developer tools, I found the root cause it that http request to http://sindresorhus.com/github-markdown-css/github-markdown.css failed.
In my network, we can't access the url becase of internet censorship.

Thanks for submitting @m2acgi - I will look into this today. What I might do is bundle this file internally with markserv so it gets packaged in the published tarball on npm.

Should be fixed now in<EMAIL_ADDRESS>- see: https://github.com/F1LT3R/markserv/pull/40
@m2acgi could you npm i -g<EMAIL_ADDRESS>and let me know if things are working for you now?

@F1LT3R
Things are working. But there's another issue, I can't run markserv with the command "markserv -a <IP_ADDRESS> /docs". but put this command to /etc/rc.local, then reboot, it works.

Try putting s period before the slash markserv -a <IP_ADDRESS> ./docs
Using /docs would look for the directory on the root of your drive.

Oh you do have docs in root. That's interesting. If you cd /docs and markserv -a <IP_ADDRESS> ./, what happens?

If I 'cd /docs' and 'markserv -a <IP_ADDRESS> ./', it works.

Thanks for checking this. I will look into it soon. If it works fine the same dir it's most likely a confirmation problem in my code.
Thanks for looking into this :raised_hands:

Let's tackle this bug here: https://github.com/F1LT3R/markserv/issues/46

Do you mind if we close this first bug now @m2acgi ?

@F1LT3R  ok, thank you.


using wanipreg and keyreg as setup name

You can use rustdesk-1.1.9-x64-host=$wanipreg,key=$keyreg.exe to install rustdesk with the desired config.
It would make the toml creation part superfluous because this above "just works".

its the way I have chosen to do it, feel free to do it however you want, I want it all in the powershell script and this way it can be done automatically without renaming anything


pageserver: post-shard-split layer rewrites (2/2)

Problem

After a shard split of a large existing tenant, child tenants can end up with oversized historic layers indefinitely, if those layers are prevented from being GC'd by branchpoints.

This PR follows https://github.com/neondatabase/neon/pull/7531, and adds rewriting of layers that contain a mixture of needed & un-needed contents, in addition to dropping un-needed layers.
Closes: https://github.com/neondatabase/neon/issues/7504
Summary of changes

Add methods to ImageLayer for reading back existing layers
Extend compact_shard_ancestors to rewrite layer files that contain a mixture of keys that we want and keys we do not, if unwanted keys are the majority of those in the file.
Amend initialization code to handle multiple layers with the same LayerName properly
Get rid of of renaming bad layer files to .old since that's now expected on restarts during rewrites.

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

For my understanding: commit pageserver: init should not assume local LayerNames are unique is required for cases where the compaction task panics mid rewrites?

Right: where we have two layers on disk that have the same LayerName but different generation suffixes.


Missing Sampler when running on multiple GPUs using DDP

Based on my understanding we need a sampler that will make sure a batch is not assigned to other GPU so that we dont duplicate the training of the same batch. But I dont see that we use any sampler while using DDP is this a bug or am i missing something ?
https://pytorch.org/docs/stable/data.html#torch.utils.data.distributed.DistributedSampler

dataloader.h is multi-process aware, it iterates in chunks of n_process * B * T and manages the pointers into this memory per process, so  it gives different batches to each process.

@karpathy  thanks for getting back on this but as this is llama2.c project we dont have/use dataloader.h in here ?


want to edit these cards and fix favicon bug

Your cards in the about section are extra vibrant, I want to fix its CSS and will add social media icons.

one more thing, In the last issue, I requested the logo. check yours and mine, ones. (Let me know if you like it.)

Favicon is only visible on home page, but when I redirect to some other pages, its not visible these, so I will edit it

@17rashi The issue related to cards and logo are already present
If you want to work on the favicon issue plz create new issue for that only
Show your support by stargazing the repo 🌟


Support for storing cloud-init userdata in k8s secret

Example: Create a k8s secret with UserData. Reference the secret in the NoCloud disk definition.
First create the secret.
apiVersion: v1
kind: Secret
metadata:
  name: my-vm-secret
type: Opaque
data:
  userdata: I2Nsb3VkLWNvbmZpZwpwYXNzd29yZDogYXRvbWljCnNzaF9wd2F1dGg6IFRydWUKY2hwYXNzd2Q6IHsgZXhwaXJlOiBGYWxzZSB9Cg==

Then reference the secret in the userDataSecretRef field.
metadata:
  name: testvm-nocloud
apiVersion: kubevirt.io/v1alpha1
kind: VM
spec:
  domain:
    devices:
      disks:
      - type: ContainerRegistryDisk:v1alpha
        source:
          name: kubevirt/cirros-registry-disk-demo:devel
        target:
          dev: vda
      - type: file
        target:
          dev: vdb
        cloudinit:
            nocloud:
                userDataSecretRef: my-vm-userdata
      interfaces:
      - source:
          network: default
        type: network
    memory:
      unit: MB
      value: 64
    os:
      type:
        os: hvm
    type: qemu

Multiple VMs can reference the same k8s secret object containing userdata.

oops, forgot to include the new 'make generate' results.

Looks good to me in general. Could you add a functional test which fixes #426 here?

@rmohr I was planning on making that a standalone PR later this week.  I'm currently investigating options for that.
We can roll it into this PR if you want. It will likely take a few days before I can add that part though.

As long as this extra PR is not too far away, it works for me.


[i18n] ja localization of resources-intro shortocde

Suggests an approach to solve and fixes #4783
I don't know if the ja shortcode makes sense, but I gave it a try. I can always pull it out of this PR, and we can merge only the en version tweaks. Or, if we keep it in this PR, then @open-telemetry/docs-ja-approvers can adjust it as necessary in a followup PR.

@svrnm et al: if you agree with this approach I'll add a comment to this effect in the Site localization page in a followup PR (since I have other additions I want to make to the page).

@svrnm et al: if you agree with this approach I'll add a comment to this effect in the Site localization page in a followup PR (since I have other additions I want to make to the page).

This looks good to me.


Provenance on GC edges

This is an edge added by GC:
{'subject': 'NCBIGene:1576', 'object': 'PUBCHEM.COMPOUND:68911', 'predicate': 'biolink:increases_degradation_of', 'attributes': [{'type': 'EDAM:data_0006', 'value': 1, 'name': 'weight'}]}

Note that there is no provenance on this edge.  We need to add that information to the AC redis somehow.

Duplicate of "add provenance to answer coalescer". Closing.


disable iterator test due to manylinux build on cs7

retest gpu-non-pip please

retest gpu-non-pip please

retest gpu-non-pip please

retest gpu-non-pip please

retest gpu-non-pip please


@Nullable field sould be nullable

Summary
The class generation from GraphQL query threats @Nullable types wrongly.
Version
Apollo runtime with maven dependency, ver. 2.5.11
https://mvnrepository.com/artifact/com.apollographql.apollo/apollo-runtime
Description
I need to convert REST APIs into GraphQL ones, so I need to check if a field is null in the REST call body in order to omit in from the GraphQL query.
Since I'm using Sping and @RestClient with @RequestBody, the REST body is automatically parsed into an object with null value for the missing fields.
I'm currently preparing this object for Apollo doing this:
private ElasticSearchRequest prepareElasticSearchRequestForApollo(ElasticSearchRequest request) {
  // non-nullable fields
  Utils.checkNotNull(request.index(), "index == null");
  Utils.checkNotNull(request.text(), "text == null");
  Utils.checkNotNull(request.modelName(), "modelName == null");

  ElasticSearchRequest.Builder requestBuilder = ElasticSearchRequest.builder()
		  .index(request.index())
		  .text(request.text())
		  .modelName(request.modelName());

  // nullable fields
  if (request.from() != null)
	  requestBuilder.from(request.from());
  if (request.size() != null)
	  requestBuilder.size(request.size());
  // ....

  return requestBuilder.build();
}

But this throws an exception when "from" or "size" are null since the generated class is as follows:
public @NotNull String index() {
  return this.index;
}

public @NotNull String text() {
  return this.text;
}

public @NotNull String modelName() {
  return this.modelName;
}

public @Nullable Integer from() {
  return this.from.value;
}

public @Nullable Integer size() {
  return this.size.value;
}

// ....

This way the return from from() and size() will never be null (even is it's tagged with @Nullable so it should be allowed to be null) and, moreover, if the field it's null the application crashes because .value is invoked on a null object.

Hi! 👋
Could you share your ElasticSearchRequest GraphQL query? I'm wondering if the from and size arguments are marked as non nullable (with !) or not.

I don't know if you consider this a bug or if you just (and in that case, it would still be legitimate) pretend that if one uses a class generated by Apollo he must set a field Input.absent() instead of null.

Thank you for sending the Input definitions, and your code/explanation, that helps a lot!
I think I understand now:  using the generated model as a method parameter annotated with Spring's @RequestBody is indeed probably the culprit. I admit I'm not too familiar with Spring or how this annotation works precisely - but I am guessing it will use reflection, and will automatically assign null to ElasticSearchRequest.from whereas the rest of Apollo's logic expect it to never be null (null would be represented not as null but as Input{null, false} or Input{null, true}).
In fact if I understand this correctly, it should also crash when from is not null (trying to assign an Integer to a field of type Input<Integer>?
In that case I recommend using your own intermediary class for this method's parameter, as the generated code really needs to keep Input (which by the way has been renamed to a more understandable name, Optional, in version 3).

Exactly, you got it totally right, the json is parsed via Gson using reflection and yes, it does crash saying "Expected BEGIN_OBJECT but was NUMBER at line 5 column 14 path $.from".
I was already making a custom Spring converter as you suggested.
Thank you for the celerity and clearness, have a good day.


readme: clarify installation instructions

ADB commands directly as Shell snippets
Move Nougat to a separate case, since the KK/L/M procedure doesn't work

This change is

Closing this as #147 seems more relevant, and the project doesn't seem maintained (i'm just cleaning up my Github :P ). Thanks @ale5000-git for credit in your PR ;)


REPL's cdp session doesn't provide access to most domains

Even simple things like cdp.send("Page.enable") don't work.

Closing, will re-address if this becomes an issue for anyone.


Hugging Face Model Hub integration

Allow running arbitrary Hugging Face Model Hub models using the --register-huggingface-models flag.

BTW, is the correct spelling "Hugging Face" or "HuggingFace"? I thought that it was the latter, but I looked around the website and it seems to be the former?

definitely the former

One higher-level question is the use case: when someone should run HELM with HF models in this way?

Some use cases:

Running "small" (<1B) models, which still works run on consumer-grade laptops
Running HELM with inference on a local TPU / GPU

Assuming that the model is not on Together, and you don't want to use Hugging Face Hosted Inference, and you don't want to go through the hassle of setting up a remote inference server

@dlwh pointed out that this could be extended to run checkpoints from local disk without pushing them to Hugging Face Hub, for private or draft checkpoints

(the original use case for this was running helm on levanter models)
On Mon, Jan 30, 2023 at 12:17 PM Yifan Mai @.***> wrote:

One higher-level question is the use case: when someone should run HELM
with HF models in this way?
Some use cases:

Running "small" (<1B) models, which still works run on
consumer-grade laptops
Running HELM with inference on a local TPU / GPU

Assuming that the model is not on Together, and you don't want to
use Hugging Face Hosted Inference, and you don't want to go through the
hassle of setting up a remote inference server

@dlwh https://github.com/dlwh pointed out that this could be
extended to run checkpoints from local disk without pushing them to Hugging
Face Hub, for private or draft checkpoints

—
Reply to this email directly, view it on GitHub
https://github.com/stanford-crfm/helm/pull/1323#issuecomment-1409274314,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACLIL5P4ZLACX4GWB7QXDWVAOWBANCNFSM6AAAAAAUFUCAUY
.
You are receiving this because you were mentioned.Message ID:
@.***>

cc @JoelNiklaus

Updated this PR, please take a look again?


Feature: Menu Rework

PR Checklist

[x] Link to the respective task if one exists: COM-35

@jamesricky is this ready to merge?

@jamesricky is this ready to merge?

No, there are still open sub tasks in COM-35


[RFC] code name support

Support the following
[package]
name = "mbdf"
version = "0.2.0"
edition = "2021"
code_name = "Bailey"

Rendered

To add, there is the metadata field in the version number that can be used for this.

To add, there is the metadata field in the version number that can be used for this.

I wasn't aware of this but you can indeed do 1.0.0+nickname. I couldn't find it mentioned in the Cargo docs but the semver spec has this: https://semver.org/#spec-item-10

Ok, let's close it.
Thanks for all the comments.


chore: release 2.20.0

:robot: I have created a release *beep* *boop*
2.20.0 (2024-12-08)
Features

optionally deploy config in get-bee command (#554) (e2085b9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ethersphere/swarm-cli/releases/tag/v2.20.0 :sunflower:


Can't download subs for some directories

When I run subliminal on some directories especially the ones that contain a lot of movies it crashes with the error below. This is on FreeBSD 10.1.
Thanks!
Traceback (most recent call last):
File "/usr/local/bin/subliminal", line 9, in
load_entry_point('subliminal==0.8.0-dev', 'console_scripts', 'subliminal')()
File "build/bdist.freebsd-10.1-RELEASE-amd64/egg/subliminal/cli.py", line 174, in subliminal
File "build/bdist.freebsd-10.1-RELEASE-amd64/egg/subliminal/video.py", line 316, in scan_videos
File "/usr/local/lib/python2.7/os.py", line 286, in walk
if isdir(join(top, name)):
File "/usr/local/lib/python2.7/posixpath.py", line 80, in join
path += '/' + b
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 13: ordinal not in range(128)

That's an issue with the encoding of your filesystem I think. Try latest stable release.


Adding test for writing new files when directories like docTemplates don't exist throws an error

Please describe the bug

Consume auro library 3.0.1 in any auro component
Delete docTemplates directory
Run npm run build:docs
Observe the error writing the README.md file since docTemplates doesn't exist :(

Reproducing the error
None
Expected behavior
The script should auto-magically create paths for me (assuming permissions allow it) without me needing to think about it at all
What browsers are you seeing the problem on?
No response
Additional context
No response
Exit criteria
No response

:tada: This issue has been resolved in version 3.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Revision of hurdat2-get-started

Various edits and expansions.

Verified everything runs and looks good!


refactor test case

Codecov Report

Merging #69 (5d012a4) into main (691646d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   60.49%   60.45%   -0.04%
==========================================
  Files          12       12
  Lines        1182     1181       -1
==========================================
- Hits          715      714       -1
  Misses        374      374
  Partials       93       93

Impacted Files
Coverage Δ

pkg/kafsar/test_kafsar.go
86.66% <100.00%> (ø)

pkg/test/pulsar.go
55.00% <100.00%> (-0.56%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691646d...5d012a4. Read the comment docs.


Implement OpenID Logins

PyPI allows logging in via OpenID, we need to either implement this or deprecate it and provide a migration path.

Should be fairly trivial with http://velruse.readthedocs.org/en/latest/

I suggest http://peterhudec.github.io/authomatic/ instead - it supports both py 2 and 3, and I've implemented both velruse and authomatic in my applications.
Authomatic supports bigger range of providers over velruse though.
I can provide example implementation if you guys are interested.

The last release from velruse was in 2013 -- does not seem to be really reassuring. If there are no objections from @dstufft I'd give authomatic a try, unless there is a "defacto" solution for pyramid I do not know off…

I've used both velruse and authomatic - both work fine with pyramid - however authomatic supports py3 and way more providers as of today.

Numbers from the past month:

While I think maintaining federated authentication is not a bad idea, it is clearly not used enough to warrant doing any backflips.
pypa/pypi-legacy currently uses Authomatic for both Google and OpenID and I'm a huge fan, it was straightforward to integrate and hasn't caused any fuss since being deployed.


Feature request: Add whitelisting errors list and exit if new error occured

I want to have the ability to provide whitelist patterns and filter them from results,
then if a new issue popped out it will fail on exit code 1.

Great suggestion! It may be a bit difficult to achieve as the host needs to have knowledge of previous runs. We are looking at a local incremental analysis capability which Infer# will only analyze on the changed files/binaries.
Your thoughts on filtering results based on patterns is definitely interesting. We will look into it more. Thank you!

SARIF was added to v1.2.1, which GitHub Advanced Security has very nice support for viewing and managing alerts. You can dismiss an alert, so that next time code scanning runs, the same code won't generate an alert.

Great feature, right now I don't have GitHub Enterprise so that I can't really use it but it might be useful in the future.


Allow Grafana to start without an Internet connection

Changes
Addresses #1627
Merge Requirements
None

With these changes, and disconnected to the Internet, I still get the no healthy upstream error when going to http://localhost/grafana/. The grafana logs show this message:
Error: ✗ Get "https://grafana.com/api/plugins/grafana-opensearch-datasource/versions": dial tcp: lookup grafana.com on <IP_ADDRESS>:53: no such host

I also ask if this is functionality that we should target to support since several of the images needed to run the demo, including Grafana itself, are not even built locally.

I believe the issue here is that the OpenSearch plugin (and perhaps others) is not part of Grafana's core distribution and image. When Grafana starts up, it will download the latest version of the plugin and enable it.

It appears the proposed changes will not work. If you start with an Internet connection, you will see the following Grafana logs:
✔ Downloaded and extracted grafana-opensearch-datasource v2.16.1 zip successfully to /var/lib/grafana/plugins/grafana-opensearch-datasource
logger=plugins.registration t=2024-06-30T12:45:07.602529512Z level=info msg="Plugin registered" pluginId=grafana-opensearch-datasource
logger=provisioning.datasources t=2024-06-30T12:45:07.681012346Z level=info msg="inserting datasource from configuration" name=OpenSearch uid=P9744FCCEAAFBD98F

It seems like one approach to solve this would be to bundle the plugin with the demo releases and mount it on start. Alternatively, state would need to be persisted, at least for Grafana, across restarts. Closing this.


Feature event delay

Coverage decreased (-0.07%) to 76.0% when pulling 4c5b641c260b9616cbe05c615a427c186ae0f04a on carrotandcompany:feature_event_delay into e0f40b6359ca00a48ca5ba903de1e25da27de453 on GaretJax:develop.


brew rm fails with Ruby crash

[X] are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
[X] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[X] ran brew update and can still reproduce the problem?
[ ] ran brew doctor, fixed all issues and can still reproduce the problem?
[X] ran brew config and brew doctor and included their output with your issue?

So, here's an interesting issue. On my 10.13.6 machine, with a bunch of stuff installed and some custom taps, I'm now getting Ruby-level crashes when I try to brew rm anything.
I've run brew doctor, and it complains about several unlinked things, but I can't fix those, because the fix is to brew rm them, and that crashes, too. Also, after a brew prune, brew doctor itself crashes Ruby-level; see below.
Should I give up and nuke my Homebrew installation on this machine, or try to debug it further?
brew config
$ brew config
HOMEBREW_VERSION: 1.7.5-40-g1ff42f9
ORIGIN: https://github.com/Homebrew/brew
HEAD: 1ff42f90586a5f600aa34b9edf8f8e842f2fc461
Last commit: 8 hours ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD:<PHONE_NUMBER>8e2b9d419cf90554835fa6f8e499df
Core tap last commit: 3 hours ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_DEVELOPER: 1
HOMEBREW_GIT: git
HOMEBREW_NO_AUTO_UPDATE: 1
HOMEBREW_SANDBOX: 1
HOMEBREW_VISUAL: subl -w
CPU: octa-core 64-bit skylake
Homebrew Ruby: 2.3.7 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/bin/ruby
Clang: 9.1 build 902
Git: 2.19.0 => /usr/local/bin/git
Curl: 7.54.0 => curl
Java: 10.0.1, 9.0.4, 1.8.0_181, 1.8.0_171, 1.8.0_141, 1.7.0_79
macOS: 10.13.6-x86_64
CLT: <IP_ADDRESS>.1.1535735448
CLT headers: N/A
Xcode: 9.4 => /Applications/Xcode-9.4.app/Contents/Developer
XQuartz: 2.7.11 => /opt/X11

Example crash
$ brew rm bullet
/usr/local/Homebrew/Library/Homebrew/cache_store.rb:30: [BUG] Segmentation fault at 0x0000000104fffffe
ruby 2.3.7p456 (2018-03-28 revision 63024) [universal.x86_64-darwin9.0]

-- Crash Report log information --------------------------------------------
   See Crash Report log file under the one of following:
     * ~/Library/Logs/CrashReporter
     * /Library/Logs/CrashReporter
     * ~/Library/Logs/DiagnosticReports
     * /Library/Logs/DiagnosticReports
   for more details.
Don't forget to include the above Crash Report log file in bug reports.

Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html

[1]    69147 abort      brew rm bullet
[/usr/local/Cellar]
$

brew doctor with crash
[/usr/local/Cellar]
$ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: You have unlinked kegs in your Cellar
Leaving kegs unlinked can lead to build-trouble and cause brews that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  ghostscript
  gnu-tar
  sundials
<EMAIL_ADDRESS>  octave-head
/usr/local/Homebrew/Library/Homebrew/cache_store.rb:30: [BUG] Segmentation fault at 0x00000001057ffffe
ruby 2.3.7p456 (2018-03-28 revision 63024) [universal.x86_64-darwin9.0]

-- Crash Report log information --------------------------------------------
   See Crash Report log file under the one of following:
     * ~/Library/Logs/CrashReporter
     * /Library/Logs/CrashReporter
     * ~/Library/Logs/DiagnosticReports
     * /Library/Logs/DiagnosticReports
   for more details.
Don't forget to include the above Crash Report log file in bug reports.

Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html

[1]    71763 abort      brew doctor
[/usr/local/Cellar]
$

Discussion
Suggestions?

Seems like a duplicate of https://github.com/Homebrew/brew/issues/4923.

Yup, looks the same.


[monitoring] change public metric whitelist to be a constant

Motivation
Make the public metric whitelist to be constant so that it can't be changed during runtime.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Start local network and make sure whitelist works as expected
<EMAIL_ADDRESS>~] curl localhost:33357/metrics
# HELP libra_network_peers Libra network peers counter
# TYPE libra_network_peers gauge
libra_network_peers{role="validator",state="connected"} 3

<EMAIL_ADDRESS>~/libra] curl localhost:43347/json_metrics
{"revision":"995e4df3"}

@bors-libra r+

:pushpin: Commit 1b1dfbd has been approved by bmwill

:hourglass: Testing commit 1b1dfbdb3339eacbbb5a5d4828ddc5b5c89ca9ca with merge e6163ff6a67948182c453f38fa156c781c4b4a86...

@bors-libra r+

:pushpin: Commit 00b83aa has been approved by bmwill

:hourglass: Testing commit 00b83aad413f0f96e6dbbcc3d4a8c7d19198ef1a with merge 2a8bc02a2001a893a1caa1343e06adecee214311...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: bmwill
Pushing 2a8bc02a2001a893a1caa1343e06adecee214311 to master...


s3_settings must be set when engine_name = "s3"

Versions

Module version [Required]: 1.5.1

Terraform version:
0.15.4

Description
I have downloaded the latest modules and referencing it using my local. Everything was working fine, all of a sudden this is happening, I don't know why.
I deployed multiple times, it was working fine like wine. I'm not sure why this error is coming up.
Error: 1 error occurred:* s3_settings must be set when engine_name = "s3"
with module.database_migration_service.aws_dms_endpoint.this["destination_2"],on .terraform/modules/database_migration_service/modules/terraform-aws-dms-master/main.tf
line 160, in resource "aws_dms_endpoint" "this":
Expected behavior
Should not throw any issue. It was working fine previously.
Actual behavior
S3 endpoints should be deployed successfully.

Need some help here, guys?

I am seeing the issue. Seems like something with Dynamic settings. Terraform is not identifying the S3_settings with dynamic settings on loop.

This issue has been resolved in version 1.5.2 :tada:

@harish-nandirajendra / @sivapalaparthi84 can you try using v1.5.2 and let us know if that resolves your issue


new test: java properties and heap size

https://github.com/twosigma/beakerx/blob/master/doc/groovy/JavaArgs.ipynb
should set these in the JVM options panel and then open the test notebook and confirm the values.

also need implement for jupyterlab

#7451


Update state machine

Closes #28

@antaljanosbenjamin I think this is finally ready for review :smile:


Publish docs site for the 1.0

For now, we have links to page https://http4s.org/v1.0/downloads/ that lead to 404 (because of the recent publishing of the website). We need to publish the docs site for 1.0.

It seems that the landing page of the website is returning 404 now 😮
I think that because the website was published for the 0.22 and 0.23 versions and might be because of includeLandingPage = false setting (for 0.22 and 0.23). But not 100% sure.

I think the problem is that series 0.22 and series 0.23 shouldn't be publishing the site at all? As I understand it, we have four laika websites:

the shared/unversioned pages. This includes the landing page.
/v0.22
/v0.23
/v1.0

(1) and (4) are published from the main branch. So series/0.22 and series/0.23 should only create their documentation pages and not the rest of the site.

Also, I've noticed that building the website is failing (what strange for the JDK17 only) https://github.com/http4s/http4s/runs/4457849085?check_suite_focus=true#step:3:32. This reproduces locally on the JDK17 only too. I've made a fix for it in https://github.com/http4s/http4s/pull/5689/commits/4b24833446f1d8d103ad27fd6169b872a03587c2.

Site is back up for now :)

Great! But the publishing of the docs site is still needed.

Also we still need to fix the problem which caused the site to go down.

When I fixed the default JDKs, I made the site build on 17 because it's an "app" and because people were grumpy about old JDKs.  It shouldn't really matter 8, 11, or 17 for that job.

Yeah, I don't think the JDK was specific to the issue. I think it's that each of our branch's builds is configured for its own docs and the shared site, when really only one of builds has that responsibility.

Yep, that division is how it used to work.

The 1(.0) site is now updated.


Tensorflow build from source FAIL

I followed the guide exactly, installed Microsoft Build Tools 2015 Update 3, and also the Microsoft Visual C++ 2015 Redistributable Update 3. Tensorflow version is also the same(1.13)
Now during building from source i got this error (around 30-45 minutes into building). Cant find anything similar on the internet either. Am i the only one having this issue?
Please help! Much appreciated!
This is what i am getting when i run the build command.
(tensorflow-build) C:\tensorflow-build\tensorflow>bazel build --config=opt --define=no_tensorflow_py_deps=true //tensorflow/tools/pip_package:build_pip_package WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files: c:\tensorflow-build\tensorflow/.bazelrc WARNING: Option 'experimental_shortened_obj_file_path' is deprecated INFO: Invocation ID: de236872-b64d-4605-8800-e239ab764a6a WARNING: C:/tensorflow-build/tensorflow/tensorflow/python/BUILD:2990:1: in py_library rule //tensorflow/python:standard_ops: target '//tensorflow/python:standard_ops' depends on deprecated target '//tensorflow/python/ops/distributions:distributions': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.distributions will not receive new features, and will be removed by early 2019. You should update all usage of tf.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/python/BUILD:79:1: in py_library rule //tensorflow/python:no_contrib: target '//tensorflow/python:no_contrib' depends on deprecated target '//tensorflow/python/ops/distributions:distributions': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.distributions will not receive new features, and will be removed by early 2019. You should update all usage of tf.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/gan/BUILD:136:1: in py_library rule //tensorflow/contrib/gan:losses_impl: target '//tensorflow/contrib/gan:losses_impl' depends on deprecated target '//tensorflow/python/ops/distributions:distributions': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.distributions will not receive new features, and will be removed by early 2019. You should update all usage of tf.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/metrics/BUILD:16:1: in py_library rule //tensorflow/contrib/metrics:metrics_py: target '//tensorflow/contrib/metrics:metrics_py' depends on deprecated target '//tensorflow/python/ops/distributions:distributions': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.distributions will not receive new features, and will be removed by early 2019. You should update all usage of tf.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/learn/BUILD:17:1: in py_library rule //tensorflow/contrib/learn:learn: target '//tensorflow/contrib/learn:learn' depends on deprecated target '//tensorflow/contrib/session_bundle:exporter': No longer supported. Switch to SavedModel immediately. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/learn/BUILD:17:1: in py_library rule //tensorflow/contrib/learn:learn: target '//tensorflow/contrib/learn:learn' depends on deprecated target '//tensorflow/contrib/session_bundle:gc': No longer supported. Switch to SavedModel immediately. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/timeseries/python/timeseries/BUILD:356:1: in py_library rule //tensorflow/contrib/timeseries/python/timeseries:ar_model: target '//tensorflow/contrib/timeseries/python/timeseries:ar_model' depends on deprecated target '//tensorflow/contrib/distributions:distributions_py': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.contrib.distributions are unmaintained, unsupported, and will be removed by late 2018. You should update all usage of tf.contrib.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/timeseries/python/timeseries/state_space_models/BUILD:233:1: in py_library rule //tensorflow/contrib/timeseries/python/timeseries/state_space_models:filtering_postprocessor: target '//tensorflow/contrib/timeseries/python/timeseries/state_space_models:filtering_postprocessor' depends on deprecated target '//tensorflow/contrib/distributions:distributions_py': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.contrib.distributions are unmaintained, unsupported, and will be removed by late 2018. You should update all usage of tf.contrib.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/timeseries/python/timeseries/state_space_models/BUILD:76:1: in py_library rule //tensorflow/contrib/timeseries/python/timeseries/state_space_models:kalman_filter: target '//tensorflow/contrib/timeseries/python/timeseries/state_space_models:kalman_filter' depends on deprecated target '//tensorflow/contrib/distributions:distributions_py': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.contrib.distributions are unmaintained, unsupported, and will be removed by late 2018. You should update all usage of tf.contrib.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/bayesflow/BUILD:17:1: in py_library rule //tensorflow/contrib/bayesflow:bayesflow_py: target '//tensorflow/contrib/bayesflow:bayesflow_py' depends on deprecated target '//tensorflow/contrib/distributions:distributions_py': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.contrib.distributions are unmaintained, unsupported, and will be removed by late 2018. You should update all usage of tf.contrib.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/seq2seq/BUILD:23:1: in py_library rule //tensorflow/contrib/seq2seq:seq2seq_py: target '//tensorflow/contrib/seq2seq:seq2seq_py' depends on deprecated target '//tensorflow/contrib/distributions:distributions_py': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.contrib.distributions are unmaintained, unsupported, and will be removed by late 2018. You should update all usage of tf.contrib.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/seq2seq/BUILD:23:1: in py_library rule //tensorflow/contrib/seq2seq:seq2seq_py: target '//tensorflow/contrib/seq2seq:seq2seq_py' depends on deprecated target '//tensorflow/python/ops/distributions:distributions': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.distributions will not receive new features, and will be removed by early 2019. You should update all usage of tf.distributionstotfp.distributions. WARNING: C:/tensorflow-build/tensorflow/tensorflow/contrib/BUILD:13:1: in py_library rule //tensorflow/contrib:contrib_py: target '//tensorflow/contrib:contrib_py' depends on deprecated target '//tensorflow/contrib/distributions:distributions_py': TensorFlow Distributions has migrated to TensorFlow Probability (https://github.com/tensorflow/probability). Deprecated copies remaining in tf.contrib.distributions are unmaintained, unsupported, and will be removed by late 2018. You should update all usage of tf.contrib.distributionstotfp.distributions. INFO: Analysed target //tensorflow/tools/pip_package:build_pip_package (0 packages loaded, 0 targets configured). INFO: Found 1 target... INFO: From Linking tensorflow/python/gen_linalg_ops_py_wrappers_cc.exe:    Creating library bazel-out/x64_windows-opt/bin/tensorflow/python/gen_linalg_ops_py_wrappers_cc.lib and object bazel-out/x64_windows-opt/bin/tensorflow/python/gen_linalg_ops_py_wrappers_cc.exp INFO: From Linking tensorflow/python/gen_array_ops_py_wrappers_cc.exe:    Creating library bazel-out/x64_windows-opt/bin/tensorflow/python/gen_array_ops_py_wrappers_cc.lib and object bazel-out/x64_windows-opt/bin/tensorflow/python/gen_array_ops_py_wrappers_cc.exp ERROR: C:/tensorflow-build/tensorflow/tensorflow/python/BUILD:293:1: C++ compilation of rule '//tensorflow/python:bfloat16_lib' failed (Exit 2): cl.exe failed: error executing command   cd C:/users/omars/_bazel_omars/j7bi4x5j/execroot/org_tensorflow   SET INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE;C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt;C:\Program Files (x86)\Windows Kits\8.1\include\shared;C:\Program Files (x86)\Windows Kits\8.1\include\um;C:\Program Files (x86)\Windows Kits\8.1\include\winrt;     SET PATH=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Windows\Microsoft.NET\Framework64\;C:\Program Files (x86)\Windows Kits\8.1\bin\x64;C:\Program Files (x86)\Windows Kits\8.1\bin\x86;C:\Program Files (x86)\Microsoft SDKs\Windows\v8.1A\bin\NETFX 4.5.1 Tools\x64\;;C:\Windows\system32     SET PWD=/proc/self/cwd     SET PYTHON_BIN_PATH=I:/anaconda3/envs/tensorflow-build/python.exe     SET PYTHON_LIB_PATH=I:/anaconda3/envs/tensorflow-build/lib/site-packages     SET TEMP=C:\Users\omars\AppData\Local\Temp     SET TF_DOWNLOAD_CLANG=0     SET TF_NEED_CUDA=0     SET TF_NEED_OPENCL_SYCL=0     SET TF_NEED_ROCM=0     SET TMP=C:\Users\omars\AppData\Local\Temp   C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe /nologo /DCOMPILER_MSVC /DNOMINMAX /D_WIN32_WINNT=0x0601 /D_CRT_SECURE_NO_DEPRECATE /D_CRT_SECURE_NO_WARNINGS /bigobj /Zm500 /EHsc /wd4351 /wd4291 /wd4250 /wd4996 /I. /Ibazel-out/x64_windows-opt/genfiles /Ibazel-out/x64_windows-opt/bin /Iexternal/com_google_absl /Ibazel-out/x64_windows-opt/genfiles/external/com_google_absl /Ibazel-out/x64_windows-opt/bin/external/com_google_absl /Iexternal/eigen_archive /Ibazel-out/x64_windows-opt/genfiles/external/eigen_archive /Ibazel-out/x64_windows-opt/bin/external/eigen_archive /Iexternal/local_config_sycl /Ibazel-out/x64_windows-opt/genfiles/external/local_config_sycl /Ibazel-out/x64_windows-opt/bin/external/local_config_sycl /Iexternal/nsync /Ibazel-out/x64_windows-opt/genfiles/external/nsync /Ibazel-out/x64_windows-opt/bin/external/nsync /Iexternal/gif_archive /Ibazel-out/x64_windows-opt/genfiles/external/gif_archive /Ibazel-out/x64_windows-opt/bin/external/gif_archive /Iexternal/jpeg /Ibazel-out/x64_windows-opt/genfiles/external/jpeg /Ibazel-out/x64_windows-opt/bin/external/jpeg /Iexternal/protobuf_archive /Ibazel-out/x64_windows-opt/genfiles/external/protobuf_archive /Ibazel-out/x64_windows-opt/bin/external/protobuf_archive /Iexternal/com_googlesource_code_re2 /Ibazel-out/x64_windows-opt/genfiles/external/com_googlesource_code_re2 /Ibazel-out/x64_windows-opt/bin/external/com_googlesource_code_re2 /Iexternal/farmhash_archive /Ibazel-out/x64_windows-opt/genfiles/external/farmhash_archive /Ibazel-out/x64_windows-opt/bin/external/farmhash_archive /Iexternal/fft2d /Ibazel-out/x64_windows-opt/genfiles/external/fft2d /Ibazel-out/x64_windows-opt/bin/external/fft2d /Iexternal/highwayhash /Ibazel-out/x64_windows-opt/genfiles/external/highwayhash /Ibazel-out/x64_windows-opt/bin/external/highwayhash /Iexternal/zlib_archive /Ibazel-out/x64_windows-opt/genfiles/external/zlib_archive /Ibazel-out/x64_windows-opt/bin/external/zlib_archive /Iexternal/double_conversion /Ibazel-out/x64_windows-opt/genfiles/external/double_conversion /Ibazel-out/x64_windows-opt/bin/external/double_conversion /Iexternal/snappy /Ibazel-out/x64_windows-opt/genfiles/external/snappy /Ibazel-out/x64_windows-opt/bin/external/snappy /Iexternal/local_config_python /Ibazel-out/x64_windows-opt/genfiles/external/local_config_python /Ibazel-out/x64_windows-opt/bin/external/local_config_python /Iexternal/local_config_cuda /Ibazel-out/x64_windows-opt/genfiles/external/local_config_cuda /Ibazel-out/x64_windows-opt/bin/external/local_config_cuda /Iexternal/lmdb /Ibazel-out/x64_windows-opt/genfiles/external/lmdb /Ibazel-out/x64_windows-opt/bin/external/lmdb /Iexternal/org_sqlite /Ibazel-out/x64_windows-opt/genfiles/external/org_sqlite /Ibazel-out/x64_windows-opt/bin/external/org_sqlite /Iexternal/png_archive /Ibazel-out/x64_windows-opt/genfiles/external/png_archive /Ibazel-out/x64_windows-opt/bin/external/png_archive /Iexternal/icu /Ibazel-out/x64_windows-opt/genfiles/external/icu /Ibazel-out/x64_windows-opt/bin/external/icu /Iexternal/grpc /Ibazel-out/x64_windows-opt/genfiles/external/grpc /Ibazel-out/x64_windows-opt/bin/external/grpc /Iexternal/com_github_nanopb_nanopb /Ibazel-out/x64_windows-opt/genfiles/external/com_github_nanopb_nanopb /Ibazel-out/x64_windows-opt/bin/external/com_github_nanopb_nanopb /Iexternal/boringssl /Ibazel-out/x64_windows-opt/genfiles/external/boringssl /Ibazel-out/x64_windows-opt/bin/external/boringssl /Iexternal/eigen_archive /Ibazel-out/x64_windows-opt/genfiles/external/eigen_archive /Ibazel-out/x64_windows-opt/bin/external/eigen_archive /Iexternal/nsync/public /Ibazel-out/x64_windows-opt/genfiles/external/nsync/public /Ibazel-out/x64_windows-opt/bin/external/nsync/public /Iexternal/gif_archive/lib /Ibazel-out/x64_windows-opt/genfiles/external/gif_archive/lib /Ibazel-out/x64_windows-opt/bin/external/gif_archive/lib /Iexternal/gif_archive/windows /Ibazel-out/x64_windows-opt/genfiles/external/gif_archive/windows /Ibazel-out/x64_windows-opt/bin/external/gif_archive/windows /Iexternal/protobuf_archive/src /Ibazel-out/x64_windows-opt/genfiles/external/protobuf_archive/src /Ibazel-out/x64_windows-opt/bin/external/protobuf_archive/src /Iexternal/farmhash_archive/src /Ibazel-out/x64_windows-opt/genfiles/external/farmhash_archive/src /Ibazel-out/x64_windows-opt/bin/external/farmhash_archive/src /Iexternal/zlib_archive /Ibazel-out/x64_windows-opt/genfiles/external/zlib_archive /Ibazel-out/x64_windows-opt/bin/external/zlib_archive /Iexternal/double_conversion /Ibazel-out/x64_windows-opt/genfiles/external/double_conversion /Ibazel-out/x64_windows-opt/bin/external/double_conversion /Iexternal/local_config_python/numpy_include /Ibazel-out/x64_windows-opt/genfiles/external/local_config_python/numpy_include /Ibazel-out/x64_windows-opt/bin/external/local_config_python/numpy_include /Iexternal/local_config_python/python_include /Ibazel-out/x64_windows-opt/genfiles/external/local_config_python/python_include /Ibazel-out/x64_windows-opt/bin/external/local_config_python/python_include /Iexternal/local_config_cuda/cuda /Ibazel-out/x64_windows-opt/genfiles/external/local_config_cuda/cuda /Ibazel-out/x64_windows-opt/bin/external/local_config_cuda/cuda /Iexternal/local_config_cuda/cuda/cuda/include /Ibazel-out/x64_windows-opt/genfiles/external/local_config_cuda/cuda/cuda/include /Ibazel-out/x64_windows-opt/bin/external/local_config_cuda/cuda/cuda/include /Iexternal/local_config_cuda/cuda/cuda/include/crt /Ibazel-out/x64_windows-opt/genfiles/external/local_config_cuda/cuda/cuda/include/crt /Ibazel-out/x64_windows-opt/bin/external/local_config_cuda/cuda/cuda/include/crt /Iexternal/png_archive /Ibazel-out/x64_windows-opt/genfiles/external/png_archive /Ibazel-out/x64_windows-opt/bin/external/png_archive /Iexternal/icu/icu4c/source/common /Ibazel-out/x64_windows-opt/genfiles/external/icu/icu4c/source/common /Ibazel-out/x64_windows-opt/bin/external/icu/icu4c/source/common /Iexternal/grpc/include /Ibazel-out/x64_windows-opt/genfiles/external/grpc/include /Ibazel-out/x64_windows-opt/bin/external/grpc/include /Iexternal/grpc/third_party/address_sorting/include /Ibazel-out/x64_windows-opt/genfiles/external/grpc/third_party/address_sorting/include /Ibazel-out/x64_windows-opt/bin/external/grpc/third_party/address_sorting/include /Iexternal/boringssl/src/include /Ibazel-out/x64_windows-opt/genfiles/external/boringssl/src/include /Ibazel-out/x64_windows-opt/bin/external/boringssl/src/include /D__CLANG_SUPPORT_DYN_ANNOTATION__ /DEIGEN_MPL2_ONLY /DEIGEN_MAX_ALIGN_BYTES=64 /DEIGEN_HAS_TYPE_TRAITS=0 /DTF_USE_SNAPPY /DSQLITE_OMIT_DEPRECATED /DGRPC_ARES=0 /DPB_FIELD_32BIT=1 /showIncludes /MD /O2 /Oy- /DNDEBUG /wd4117 -D__DATE__="redacted" -D__TIMESTAMP__="redacted" -D__TIME__="redacted" /Gy /Gw -w /arch:AVX /Fobazel-out/x64_windows-opt/bin/tensorflow/python/_objs/bfloat16_lib/bfloat16.obj /c tensorflow/python/lib/core/bfloat16.cc Execution platform: @bazel_tools//platforms:host_platform tensorflow/python/lib/core/bfloat16.cc(634): error C2664: 'bool tensorflow::anonymous-namespace'::Initialize::<lambda_e0a715906def81bd0cbfc673d4d1e25e>::operator ()(const char *,PyUFuncGenericFunction,const std::array<int,3> &) const': cannot convert argument 2 from 'void (__cdecl *)(char **,npy_intp *,npy_intp *,void *)' to 'PyUFuncGenericFunction'
tensorflow/python/lib/core/bfloat16.cc(634): note: None of the functions with this name in scope match the target type
tensorflow/python/lib/core/bfloat16.cc(638): error C2664: 'bool tensorflow::anonymous-namespace'::Initialize::<lambda_e0a715906def81bd0cbfc673d4d1e25e>::operator ()(const char *,PyUFuncGenericFunction,const std::array<int,3> &) const': cannot convert argument 2 from 'void (__cdecl *)(char **,npy_intp *,npy_intp *,void *)' to 'PyUFuncGenericFunction' tensorflow/python/lib/core/bfloat16.cc(638): note: None of the functions with this name in scope match the target type tensorflow/python/lib/core/bfloat16.cc(641): error C2664: 'bool tensorflow::anonymous-namespace'::Initialize::<lambda_e0a715906def81bd0cbfc673d4d1e25e>::operator ()(const char *,PyUFuncGenericFunction,const std::array<int,3> &) const': cannot convert argument 2 from 'void (__cdecl *)(char **,npy_intp *,npy_intp *,void *)' to 'PyUFuncGenericFunction'
tensorflow/python/lib/core/bfloat16.cc(641): note: None of the functions with this name in scope match the target type
tensorflow/python/lib/core/bfloat16.cc(645): error C2664: 'bool tensorflow::anonymous-namespace'::Initialize::<lambda_e0a715906def81bd0cbfc673d4d1e25e>::operator ()(const char *,PyUFuncGenericFunction,const std::array<int,3> &) const': cannot convert argument 2 from 'void (__cdecl *)(char **,npy_intp *,npy_intp *,void *)' to 'PyUFuncGenericFunction' tensorflow/python/lib/core/bfloat16.cc(645): note: None of the functions with this name in scope match the target type tensorflow/python/lib/core/bfloat16.cc(649): error C2664: 'bool tensorflow::anonymous-namespace'::Initialize::<lambda_e0a715906def81bd0cbfc673d4d1e25e>::operator ()(const char *,PyUFuncGenericFunction,const std::array<int,3> &) const': cannot convert argument 2 from 'void (__cdecl *)(char **,npy_intp *,npy_intp *,void *)' to 'PyUFuncGenericFunction'
tensorflow/python/lib/core/bfloat16.cc(649): note: None of the functions with this name in scope match the target type
tensorflow/python/lib/core/bfloat16.cc(653): error C2664: 'bool tensorflow::anonymous-namespace'::Initialize::<lambda_e0a715906def81bd0cbfc673d4d1e25e>::operator ()(const char *,PyUFuncGenericFunction,const std::array<int,3> &) const': cannot convert argument 2 from 'void (__cdecl *)(char **,npy_intp *,npy_intp *,void *)' to 'PyUFuncGenericFunction' tensorflow/python/lib/core/bfloat16.cc(653): note: None of the functions with this name in scope match the target type Target //tensorflow/tools/pip_package:build_pip_package failed to build INFO: Elapsed time: 7.998s, Critical Path: 5.25s INFO: 4 processes: 4 local. FAILED: Build did NOT complete successfully

I hit the same issue (I posted the same issue in the issues list of this project) but wrote a Colab that could handle the conversion instead.  It worked for me to convert my .pb file into the tflite file.  Let me know if it works for you or if you have any questions:
https://colab.research.google.com/drive/1Px7I6PxeeLhCepyA9Dv22pwz66NuT1JR?usp=sharing


Modern RabbitMQ

Motivation for this change
This series of commits upgrades RabbitMQ to latest stable version and modernizes corresponding NixOS module. Most important changes are:

Proper integration with systemd: socket-activated epmd, startup notifications, sane defaults
Using new configuration file format, which is more automation friendly

Parts of Erlang infrastructure were also touched to make socket-activation real.
Every commit message also contains more detailed description, together with relevant links to RabbitMQ and Erlang/OTP repositories.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Bumped rabbit to recently released 3.7.3, moved elixir version selection to all-packages.nix as suggested.

Since 3.6 is going to be supported until May 2018, I request that an up-to-date 3.6.x is kept in nixpkgs.

@Profpatsch I can easily do this for package itself, but I don't think I can do this in a clean way for NixOS module. If you are OK with that, how'd you prefer the new and the old package named in all-packages?

but I don't think I can do this in a clean way for NixOS module.

I’d to it like this:
For the packages:
let
  majorVersion = 6;
in … {
  version = "${toString majorVersion}.x.x";
  …
  passthrough = { inherit majorVersion; };
}

And then use cfg.package.majorVersion >= 7 to switch in the module.

how'd you prefer the new and the old package named in all-packages?

They should probably be named
rabbitmq-server = rabbitmq-server_3_6;
rabbitmq-server_3_6 = …
rabbitmq-server_3_7 = …

Notice that I changed the (historical) _ to -, that needs to be documented in the release notes under nixos/doc/manual/release-notes/.

fyi: I’ve created a PR to update to 3.6.15, with various improvements to the package. Some of them are probably valid for 3.7 as well and should be merged into the 3.7 derivation as well.
I intend to merge the 3.6 update first, since we should support the latest release of that major release (see above).

While we're at it, can we use erlang_nox instead of regular erlang by default when building rabbitmq? We've been using that for the last 6 months or so without any problems.

I’m for it, I already disable wx for our rabbitmq docker image.
As you can see in that source file, the wx beam files are put in nonetheless, so erlang_nox should probably also throw them out if possible. Rabbitmq itself depends on coreutils because of one command used in a wrapper script, that can probably be patched out as well.

The deprecation for the 3.6 series is coming nearer (May 1st), so we should get this into nixpkgs.
We should still keep 3.6 around (though with a deprecation warning) and remove it with the next release (18.09).

I updated this patch without re-introducing version-selection logic described above, it's already to late.
This depends on:

https://github.com/NixOS/nixpkgs/pull/43817
https://github.com/NixOS/nixpkgs/pull/43812

ps with systemd support is now required because of https://github.com/rabbitmq/rabbitmq-server/blob/7c941aff893c44355e3e892a43b80d20de171ac3/src/rabbit.erl#L415

@Profpatsch All dependencies are in master now, and I've rebased/updated the PR itself.

@GrahamcOfBorg build rabbitmq-server

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)
Attempted: rabbitmq-server
Partial log (click to expand)
/nix/store/qjk2h301faawvbnhv5azhyiaw6vrqalg-builder.sh: fork: retry: Resource temporarily unavailable
/nix/store/qjk2h301faawvbnhv5azhyiaw6vrqalg-builder.sh: fork: retry: Resource temporarily unavailable
copying path '/nix/store/vsi0n294sn2g8r6sndjk3c7fr9pq2r5z-erlang-20.3.8' from 'https://cache.nixos.org'...
/nix/store/qjk2h301faawvbnhv5azhyiaw6vrqalg-builder.sh: fork: retry: Resource temporarily unavailable
/nix/store/qjk2h301faawvbnhv5azhyiaw6vrqalg-builder.sh: fork: retry: Resource temporarily unavailable
copying path '/nix/store/yx1sv0lqzglr4hl0i1fv76nfba285vki-elixir-1.6.6' from 'https://cache.nixos.org'...
/nix/store/qjk2h301faawvbnhv5azhyiaw6vrqalg-builder.sh: fork: Resource temporarily unavailable
builder for '/nix/store/nn45bfclc6fh4ya15axaw6ifijcrq4dq-rabbitmq-server-3.7.8.tar.xz.drv' failed with exit code 254
cannot build derivation '/nix/store/0w5f7jh3xg5jyixf4q52zgsdzxs5lhpx-rabbitmq-server-3.7.8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0w5f7jh3xg5jyixf4q52zgsdzxs5lhpx-rabbitmq-server-3.7.8.drv' failed

Success on x86_64-linux (full log)
Attempted: rabbitmq-server
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/g30cvk3ay8hv56wxfmjk08hn7gzi6q2h-rabbitmq-server-3.7.8-man
gzipping man pages under /nix/store/g30cvk3ay8hv56wxfmjk08hn7gzi6q2h-rabbitmq-server-3.7.8-man/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/g30cvk3ay8hv56wxfmjk08hn7gzi6q2h-rabbitmq-server-3.7.8-man
checking for references to /build in /nix/store/g30cvk3ay8hv56wxfmjk08hn7gzi6q2h-rabbitmq-server-3.7.8-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/76dc97my11vin2d7ymlbnl0s7j74s75s-rabbitmq-server-3.7.8-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/76dc97my11vin2d7ymlbnl0s7j74s75s-rabbitmq-server-3.7.8-doc
checking for references to /build in /nix/store/76dc97my11vin2d7ymlbnl0s7j74s75s-rabbitmq-server-3.7.8-doc...
/nix/store/v35gyq73wpkn8gi7v0lgb759hsskjvla-rabbitmq-server-3.7.8

Failure on aarch64-linux (full log)
Attempted: rabbitmq-server
Partial log (click to expand)
/nix/store/hhhz83blfp8l2n45y8a5sipzvazj017a-erlang-20.3.8/lib/erlang/erts-9.3.3/bin/erl: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/hhhz83blfp8l2n45y8a5sipzvazj017a-erlang-20.3.8/lib/erlang/erts-9.3.3/bin/start_erl.src: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/hhhz83blfp8l2n45y8a5sipzvazj017a-erlang-20.3.8/lib/erlang/erts-9.3.3/bin/start.src: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/hhhz83blfp8l2n45y8a5sipzvazj017a-erlang-20.3.8/lib/erlang/erts-9.3.3/bin/erl.src: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/hhhz83blfp8l2n45y8a5sipzvazj017a-erlang-20.3.8...
wrong ELF type
wrong ELF type
wrong ELF type
cannot build derivation '/nix/store/1kgsv2m4k4zkfsbpab20kbjvaly7bjca-rabbitmq-server-3.7.8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/1kgsv2m4k4zkfsbpab20kbjvaly7bjca-rabbitmq-server-3.7.8.drv' failed

I think the darwin failure is unrelated. Let’s try again.
@GrahamcOfBorg build rabbitmq-server

Success on x86_64-linux (full log)
Attempted: rabbitmq-server
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/g30cvk3ay8hv56wxfmjk08hn7gzi6q2h-rabbitmq-server-3.7.8-man
gzipping man pages under /nix/store/g30cvk3ay8hv56wxfmjk08hn7gzi6q2h-rabbitmq-server-3.7.8-man/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/g30cvk3ay8hv56wxfmjk08hn7gzi6q2h-rabbitmq-server-3.7.8-man
checking for references to /build in /nix/store/g30cvk3ay8hv56wxfmjk08hn7gzi6q2h-rabbitmq-server-3.7.8-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/76dc97my11vin2d7ymlbnl0s7j74s75s-rabbitmq-server-3.7.8-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/76dc97my11vin2d7ymlbnl0s7j74s75s-rabbitmq-server-3.7.8-doc
checking for references to /build in /nix/store/76dc97my11vin2d7ymlbnl0s7j74s75s-rabbitmq-server-3.7.8-doc...
/nix/store/v35gyq73wpkn8gi7v0lgb759hsskjvla-rabbitmq-server-3.7.8

Success on x86_64-darwin (full log)
Attempted: rabbitmq-server
Partial log (click to expand)
/nix/store/pqfpya2v3m44abrkdp101mjhmwi8blv3-rabbitmq-server-3.7.8/escript/rabbitmqctl: interpreter directive changed from " /usr/bin/env escript" to "/nix/store/8imgai416j7ih0yn3ma3mdvc9b8f3a6a-erlang-20.3.8/bin/escript"
/nix/store/pqfpya2v3m44abrkdp101mjhmwi8blv3-rabbitmq-server-3.7.8/escript/rabbitmq-diagnostics: interpreter directive changed from " /usr/bin/env escript" to "/nix/store/8imgai416j7ih0yn3ma3mdvc9b8f3a6a-erlang-20.3.8/bin/escript"
/nix/store/pqfpya2v3m44abrkdp101mjhmwi8blv3-rabbitmq-server-3.7.8/escript/rabbitmq-plugins: interpreter directive changed from " /usr/bin/env escript" to "/nix/store/8imgai416j7ih0yn3ma3mdvc9b8f3a6a-erlang-20.3.8/bin/escript"
moving /nix/store/pqfpya2v3m44abrkdp101mjhmwi8blv3-rabbitmq-server-3.7.8/sbin/* to /nix/store/pqfpya2v3m44abrkdp101mjhmwi8blv3-rabbitmq-server-3.7.8/bin
gzipping man pages under /nix/store/47rkpi7s4hp60qa9rd2gn4n5njmg3mv9-rabbitmq-server-3.7.8-man/share/man/
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/47rkpi7s4hp60qa9rd2gn4n5njmg3mv9-rabbitmq-server-3.7.8-man
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/kllsiq1c0kzhkn7yy9gw23h9h0y8h2ax-rabbitmq-server-3.7.8-doc
/nix/store/pqfpya2v3m44abrkdp101mjhmwi8blv3-rabbitmq-server-3.7.8

Failure on aarch64-linux (full log)
Attempted: rabbitmq-server
Partial log (click to expand)
gzipping man pages under /nix/store/9gbvnjvrbqdrzd5vgrvaqj46wi694lmb-elixir-1.6.6/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9gbvnjvrbqdrzd5vgrvaqj46wi694lmb-elixir-1.6.6/lib  /nix/store/9gbvnjvrbqdrzd5vgrvaqj46wi694lmb-elixir-1.6.6/bin
patching script interpreter paths in /nix/store/9gbvnjvrbqdrzd5vgrvaqj46wi694lmb-elixir-1.6.6
/nix/store/9gbvnjvrbqdrzd5vgrvaqj46wi694lmb-elixir-1.6.6/lib/elixir/bin/iex: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/9gbvnjvrbqdrzd5vgrvaqj46wi694lmb-elixir-1.6.6/lib/elixir/bin/elixirc: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/9gbvnjvrbqdrzd5vgrvaqj46wi694lmb-elixir-1.6.6/lib/elixir/bin/elixir: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/9gbvnjvrbqdrzd5vgrvaqj46wi694lmb-elixir-1.6.6...
cannot build derivation '/nix/store/1kgsv2m4k4zkfsbpab20kbjvaly7bjca-rabbitmq-server-3.7.8.drv': 1 dependencies couldn't be built
error: build of '/nix/store/1kgsv2m4k4zkfsbpab20kbjvaly7bjca-rabbitmq-server-3.7.8.drv' failed


Keys missing handling

There's one particular state the Zashi can end up with and it's currently not handled other than a user gets stuck on a HI splash screen. The debug menu is accessible but hidden gesture is known only internally so this effectively means dead end for a user.

Keys missing state means DB for the wallet is present and accessible but keychain and it's data are not. At this point we don't know why the keychain responds this way because in all cases we expect the wallet to be accessible, there was no external operation that would deleted the keychain data.
We might assume some cases or changes in the API like

it takes time before the keychain is initialized and the API responses, we know this from past and that is why we purposely wait 0.01s before we even try to read the data. Maybe something changed and this time is no longer enough
some other changes we don't know about

All in all if this happens for whatever reason, it's a dead end and terrible UX.
Goal
Ideally we get to know why the API responds this way so we can fix it. If this is not easily possible, other solution could be some retry logic, try to gradually read the data from keychain and don't stop after first failure.
So we can try to read the data in 0.01s like we do currently but failed state trigger another attempt in 0.05s. We can try up to 3 attempts for example and the last one in 0.1s. Then we should be fairly sure the data in the keychain are missing - the state when the app is truly not initialized.

I achieved to reproduce this by letting the app sleep a great deal of time and then calling it to foreground. Probably not the best reproduce steps because it take an important number of hours 🥶

I achieved to reproduce this by letting the app sleep a great deal of time and then calling it to foreground. Probably not the best reproduce steps because it take an important number of hours 🥶

This is great feedback anyway even without reproducing the issue. It only proves that your keys should be still in the keychain but read of it failed for whatever reason.


[Bug]: "FRED ==>"  doubles output in fabric in combination with local ollama

What happened?
Hi, first: thanks for the great work. Love fabric!
Context:

most recent version of fabric on Mac OS 14.6.1 (23G93),
local ollama with various LLMs, example is llama3.1, but the actual model doesn't matter

Not a go developer, not a heavy GitHub user, but I think I've spotted an issue
This is what I did (as an example):
~ matthias$ echo "Paul Auster or Haruki Murakama"|fabric -p ai
* Both authors explore the human condition in their works.
* They often incorporate magical realism and philosophical themes.
* Their writing styles are highly lyrical and poetic, respectively.FRED ==>
* Both authors explore the human condition in their works.
* They often incorporate magical realism and philosophical themes.
* Their writing styles are highly lyrical and poetic, respectively.

please note the duplicate response and the string "FRED ==>" at the end of the first instance of the response (output line3)
fabric-main/vendors/ollama/ollama.go line 94 has something like that, not sure if this is the cause,
        if err = o.client.Chat(ctx, &req, respFunc); err != nil {
                fmt.Printf("FRED --> %s\n", err)
        }
        return

Thanks in advance for checking, Matthias
Version check

[X] Yes I was.

Relevant log output
No response
Relevant screenshots (optional)
No response

for the time being I wrote a shell filter that removes everything starting with "FRED" and the duplicate text, so that I can use fabric at all again...

I've got the same, with no output at all apart from the FRED==>, regardless the model or pattern.


Sync VEF graphic customization and Vanilla Persona Weapons Expanded

This took quite a bit of work and took the last 3 days to make. I've reworked VPWE patch twice, as I wasn't satisfied with how the original versions worked.
Updated graphic customization component from Vanilla Expanded Framework. This includes sync worker for the dialog and a couple of types used by it, syncing confirmation button, and closing the dialog/stopping synced methods if the dialog data is no longer valid.
Vanilla Persona Weapons Expanded was also synced due to being based on graphic customization from VEF. It wasn't as straightforward as graphic customization was. The sync worker for the dialog reuses part of the code from VEF graphic customization one. It also required quite a bit more patches, for example to ensure the letter is not removed too early in MP, as well as some bug fixes for the mod itself (when selecting persona weapons without customization).

The PreSyncAcceptPersonaWeapon is a clever idea


Query regarding limite of four classes of Service

Is the limit of 4 classes of service (COS) on the Intel(R) Xeon(R) processor E5 v3 generation permanent or it limited by the current software implementation and will expand in the future. I ask because the section <IP_ADDRESS> Cache Mask Configuration of the Intel Software Developer's manuals mentions that the range of MSRs reserved for CAT can accommodate up to 256 COS or multiple resources.

Number of classes of service is product dependent and for Intel(R) Xeon(R) processor E5 v3 product family, the number is 4. There are 256 MSR addresses reserved for the classes of service.

MohdAhmad, I hope my comment explains difference between MSR address space described in Intel Software Developer's manual and actual number of classes of service implemented in Intel(R) Xeon(R) E5 v3 processors. If you have more questions then I'll be happy to answer them. I am going to close this issue for now.


Update full_code.py

Add sess.close() to the end.
It's my first time to open a pull request, if any thing I did it's wrong, please tell me. Thx

Cool, make this perfect.

Thank you for the update. But after my consideration, the sess.close() is not necessary code, and to keep it or not may cause some confusions to beginners as these tutorials are indeed just for beginners. So I decide to leave it as simple as it can.

ok, you are the boss.
At first I thought this may cause GPU memory leak. But it seems not. Still, I modified them.
Sent from myMail for iOS
Tuesday, 25 October 2016, 17:24 +0900 from Morvan<EMAIL_ADDRESS>
Thank you for the update. But after my consideration, the sess.close() is not necessary code, and to keep it or not may cause some confusions to beginners as these tutorials are indeed just for beginners. So I decide to leave it as simple as it can.
—
You are receiving this because you authored the thread.
Reply to this email directly,  view it on GitHub , or  mute the thread .

Hi，看了你的一些视频觉得很不错，我现在正在东京大学读研究生，方便加个微信吗？有空来日本玩 ^_^
我的微信是 ishidabaigann
On Tue, Oct 25, 2016 at 5:24 PM, Morvan<EMAIL_ADDRESS>wrote:

Thank you for the update. But after my consideration, the sess.close() is
not necessary code, and to keep it or not may cause some confusions to
beginners as these tutorials are indeed just for beginners. So I decide to
leave it as simple as it can.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MorvanZhou/tutorials/pull/5#issuecomment-255969916,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APLu6W931xTW7p6jj6-vJS-9nDgMGZZCks5q3bysgaJpZM4Kfq3F
.

Hi, James,
我微信就生活圈里能见到面的朋友~ 我想生活和 python 的圈子分开.
不过我们可以加微博,如果你有的话~ 微博的留言也很方便, 而且也会 post 一些生活的东西.
http://www.weibo.com/pythontutorial
谢谢你
Morvan
On 13 November 2016 at 13:24, JamesRaynor<EMAIL_ADDRESS>wrote:

Hi，看了你的一些视频觉得很不错，我现在正在东京大学读研究生，方便加个微信吗？有空来日本玩 ^_^
我的微信是 ishidabaigann
On Tue, Oct 25, 2016 at 5:24 PM, Morvan<EMAIL_ADDRESS>wrote:

Thank you for the update. But after my consideration, the sess.close() is
not necessary code, and to keep it or not may cause some confusions to
beginners as these tutorials are indeed just for beginners. So I decide
to
leave it as simple as it can.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MorvanZhou/tutorials/pull/5#issuecomment-255969916,
or mute the thread
<https://github.com/notifications/unsubscribe-
auth/APLu6W931xTW7p6jj6-vJS-9nDgMGZZCks5q3bysgaJpZM4Kfq3F>
.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/MorvanZhou/tutorials/pull/5#issuecomment-260162308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASgmNBeFhj6mLJoj7WVr8lUveJ1m6xEoks5q9nTngaJpZM4Kfq3F
.


std.variant housekeeping

variant hat some code disabled due to compiler bugs.
Some of these bugs have been fixed.
This re-enables this dead code.
removed some old code

Oops forgot about this pull. LGTM

Auto-merge toggled on


ruby-build 2.7.1 ... installs 2.7.0p0 instead

I originally raised this with asdf (https://github.com/asdf-vm/asdf-ruby/issues/161), which uses ruby-build, but I can reproduce the issue without involving asdf so I'm raising it here instead.
I'm trying to install ruby 2.7.1 on Ubuntu 14.04 (legacy apps :-( ), but the Ruby that gets installed seems to be 2.7.0.
What I did:
$ git clone https://github.com/rbenv/ruby-build.git
Cloning into 'ruby-build'...
remote: Enumerating objects: 86, done.
remote: Counting objects: 100% (86/86), done.
remote: Compressing objects: 100% (71/71), done.
remote: Total 10763 (delta 57), reused 25 (delta 11), pack-reused 10677
Receiving objects: 100% (10763/10763), 2.26 MiB | 1.04 MiB/s, done.
Resolving deltas: 100% (7084/7084), done.

$ sudo PREFIX=/usr/local ./ruby-build/install.sh
[sudo] password for <my name>:

$ LC_ALL=C ruby-build 2.7.1 ~/bin/ruby/ruby-2.7.1
Downloading ruby-2.7.1.tar.bz2...
-> https://cache.ruby-lang.org/pub/ruby/2.7/ruby-2.7.1.tar.bz2
Installing ruby-2.7.1...
ruby-build: using readline from homebrew
Installed ruby-2.7.1 to /home/<my name>/bin/ruby/ruby-2.7.1

$ /home/<my name>/bin/ruby/ruby-2.7.1/bin/ruby --version
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]

What I expected:
A Ruby 2.7.1 version string, like ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]

I've also tried manually unzipping the file https://cache.ruby-lang.org/pub/ruby/2.7/ruby-2.7.1.tar.bz2 and compiling it, which gives me the correct version of Ruby:
$ ruby-2.7.1/ruby --version
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]

I could install this manually as well, but I'd prefer to get it working with a version manager if I can.

I can also reproduce, or, compiling 2.7.1 from scratch installs a bunch of files to "2.7.0" in DESTDIR which seems bizarre.
/src# find . -name '2.7.0'
./releases/2.7.1/usr/local/lib/ruby/site_ruby/2.7.0
./releases/2.7.1/usr/local/lib/ruby/2.7.0
./releases/2.7.1/usr/local/lib/ruby/vendor_ruby/2.7.0
./releases/2.7.1/usr/local/lib/ruby/gems/2.7.0
./releases/2.7.1/usr/local/share/ri/2.7.0

Build log output:
checking for _setjmpex as a macro or function... no
checking for _setjmp as a macro or function... yes
checking for sigsetjmp as a macro or function... no
checking for setjmp type... __builtin_setjmp
checking for prefix of external symbols... NONE
checking pthread.h usability... yes
checking pthread.h presence... yes
checking for pthread.h... yes
checking if make is GNU make... yes
.ext/include/x86_64-linux/ruby/config.h updated
configure: ruby library version = 2.7.0
configure: creating ./config.status
config.status: creating GNUmakefile
config.status: creating Makefile
config.status: creating ruby-2.7.pc

...

./miniruby -I./lib -I. -I.ext/common  ./tool/runruby.rb --extout=.ext  -- --disable-gems -r./x86_64-linux-fake ./tool/rbinstall.rb --make="make" --dest-dir="/src/releases/2.7.1" --extout=".ext" --mflags
="" --make-flags=" -- DESTDIR=/src/releases/2.7.1" --data-mode=0644 --prog-mode=0755 --installed-list .installed.list --mantype="man" --rdoc-output=".ext/rdoc" --html-output=".ext/html"
installing binary commands:         /usr/local/bin
installing base libraries:          /usr/local/lib
installing arch files:              /usr/local/lib/ruby/2.7.0/x86_64-linux
installing pkgconfig data:          /usr/local/lib/pkgconfig
installing extension objects:       /usr/local/lib/ruby/2.7.0/x86_64-linux
installing extension objects:       /usr/local/lib/ruby/site_ruby/2.7.0/x86_64-linux
installing extension objects:       /usr/local/lib/ruby/vendor_ruby/2.7.0/x86_64-linux
installing extension headers:       /usr/local/include/ruby-2.7.0/x86_64-linux
installing extension scripts:       /usr/local/lib/ruby/2.7.0
installing extension scripts:       /usr/local/lib/ruby/site_ruby/2.7.0
installing extension scripts:       /usr/local/lib/ruby/vendor_ruby/2.7.0
installing extension headers:       /usr/local/include/ruby-2.7.0/ruby
installing rdoc:                    /usr/local/share/ri/2.7.0/system
installing html-docs:               /usr/local/share/doc/ruby
installing capi-docs:               /usr/local/share/doc/ruby
installing command scripts:         /usr/local/bin
installing library scripts:         /usr/local/lib/ruby/2.7.0
installing common headers:          /usr/local/include/ruby-2.7.0
installing manpages:                /usr/local/share/man (man1, man5)
installing default gems from lib:   /usr/local/lib/ruby/gems/2.7.0 (build_info, cache, doc, extensions, gems, specifications)

This is the contents of include/ruby/version.h in the downloaded commit
/* API version */
#define RUBY_API_VERSION_MAJOR 2
#define RUBY_API_VERSION_MINOR 7
#define RUBY_API_VERSION_TEENY 0
#define RUBY_API_VERSION_CODE (RUBY_API_VERSION_MAJOR*10000+RUBY_API_VERSION_MINOR*100+RUBY_API_VERSION_TEENY)

@kevinburkemeter It's the expected behavior. Ruby API version is different from Ruby version.

@isikyus You might be running into a similar problem I described over here: https://github.com/rbenv/ruby-build/issues/1387#issuecomment-623193250
You're not running (Linux)Homebrew, but Ubuntu 14.04 or something else in your build environment might be doing something similar. ldd /path/to/bin/ruby should show which libruby if any the ruby binary is loading. readelf -d /path/to/bin/ruby and check for the rpath which is built into the binary. If the rpath looks clean it might be LD_LIBRARY_PATH or other things listed in man 8 ld.so.

I've also tried manually unzipping the file and compiling it

If that was on same system it really sounds like ruby-build defaulting to --enable-shared and your by-hand compile not passing --enable-shared to ./configure. I can confirm for you that if you put a 2.7.0 libruby.so.2.7 in the load path of a --enable-shared 2.7.1 ruby binary, ruby --version will print 2.7.0.

You're not running (Linux)Homebrew, but Ubuntu 14.04 or something else in your build environment might be doing something similar. ldd /path/to/bin/ruby should show which libruby if any the ruby binary is loading. readelf -d /path/to/bin/ruby and check for the rpath which is built into the binary. If the rpath looks clean it might be LD_LIBRARY_PATH or other things listed in man 8 ld.so.

This seems very likely; I am in fact running Homebrew on Linux — I'm not sure how I missed mentioning that earlier.
The rpath does seem to be correct:
$ ~/bin/ruby/ruby-2.7.1/bin/ruby --version
ruby 2.7.0p0 (2019-12-25 revision 647ee6f091) [x86_64-linux]
$ readelf -d ~/bin/ruby/ruby-2.7.1/bin/ruby

Dynamic section at offset 0x2d88 contains 34 entries:
  Tag        Type                         Name/Value
 0x0000000000000001 (NEEDED)             Shared library: [libruby.so.2.7]
 0x0000000000000001 (NEEDED)             Shared library: [libz.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [librt.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libgmp.so.10]
 0x0000000000000001 (NEEDED)             Shared library: [libdl.so.2]
 0x0000000000000001 (NEEDED)             Shared library: [libcrypt.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libm.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
 0x000000000000000f (RPATH)              Library rpath: [/home/linuxbrew/.linuxbrew/lib:/home/edward/bin/ruby/ruby-2.7.1/lib]
 0x000000000000000c (INIT)               0x401000
 0x000000000000000d (FINI)               0x4012b4
 0x0000000000000019 (INIT_ARRAY)         0x403d70
 0x000000000000001b (INIT_ARRAYSZ)       8 (bytes)
 0x000000000000001a (FINI_ARRAY)         0x403d78
 0x000000000000001c (FINI_ARRAYSZ)       8 (bytes)
 0x0000000000000004 (HASH)               0x4002f0
 0x000000006ffffef5 (GNU_HASH)           0x400390
 0x0000000000000005 (STRTAB)             0x4005d8
 0x0000000000000006 (SYMTAB)             0x4003e0
 0x000000000000000a (STRSZ)              411 (bytes)
 0x000000000000000b (SYMENT)             24 (bytes)
 0x0000000000000015 (DEBUG)              0x0
 0x0000000000000003 (PLTGOT)             0x404000
 0x0000000000000002 (PLTRELSZ)           192 (bytes)
 0x0000000000000014 (PLTREL)             RELA
 0x0000000000000017 (JMPREL)             0x4007e8
 0x0000000000000007 (RELA)               0x4007d0
 0x0000000000000008 (RELASZ)             24 (bytes)
 0x0000000000000009 (RELAENT)            24 (bytes)
 0x000000006ffffffe (VERNEED)            0x4007a0
 0x000000006fffffff (VERNEEDNUM)         1
 0x000000006ffffff0 (VERSYM)             0x400774
 0x0000000000000000 (NULL)               0x0

I can't immediately see any overridden LD variables in my environment, but it's possible they're coming from somewhere else; I'll have to look into this in more detail and get back to you.
$ env | grep LD_
$

ldd does show this Ruby will run with a Homebrew-installed libruby:
$ ldd ~/bin/ruby/ruby-2.7.1/bin/ruby
	linux-vdso.so.1 (0x00007fffad38f000)
	libruby.so.2.7 => /home/linuxbrew/.linuxbrew/lib/libruby.so.2.7 (0x00007f788744b000)
	libz.so.1 => /home/linuxbrew/.linuxbrew/lib/libz.so.1 (0x00007f7887236000)
	libpthread.so.0 => /home/linuxbrew/.linuxbrew/lib/libpthread.so.0 (0x00007f7887019000)
	librt.so.1 => /home/linuxbrew/.linuxbrew/lib/librt.so.1 (0x00007f7886e11000)
	libgmp.so.10 => /home/linuxbrew/.linuxbrew/lib/libgmp.so.10 (0x00007f7886b94000)
	libdl.so.2 => /home/linuxbrew/.linuxbrew/lib/libdl.so.2 (0x00007f7886990000)
	libcrypt.so.1 => /home/linuxbrew/.linuxbrew/lib/libcrypt.so.1 (0x00007f7886759000)
	libm.so.6 => /home/linuxbrew/.linuxbrew/lib/libm.so.6 (0x00007f7886455000)
	libc.so.6 => /home/linuxbrew/.linuxbrew/lib/libc.so.6 (0x00007f78860b6000)
	/home/linuxbrew/.linuxbrew/lib/ld.so (0x00007f788799b000)


JobManager Data Structure doc fix

It seems AbstractJobVertex class no longer exists but the doc's link still points to it.

That right, thanks for the fix.
+1 to merge

Merging this...


[DUBBO-3137]: step2 - seperate constants for cluster, common, filter, monitor, and registry

What is the purpose of the change
issue #3137: step 2
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #4020 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #4020      +/-   ##
===========================================
- Coverage     63.44%   63.4%   -0.05%
- Complexity      564     565       +1
===========================================
  Files           751     754       +3
  Lines         32415   32423       +8
  Branches       5145    5145
===========================================
- Hits          20567   20558       -9
- Misses         9489    9508      +19
+ Partials       2359    2357       -2

Impacted Files
Coverage Δ
Complexity Δ

...ache/dubbo/common/constants/RegistryConstants.java
0% <0%> (ø)
0 <0> (?)

...ubbo/common/constants/MetadataReportConstants.java
0% <0%> (ø)
0 <0> (?)

...apache/dubbo/common/constants/CommonConstants.java
0% <0%> (ø)
0 <0> (?)

...ng/exchange/support/header/HeartbeatTimerTask.java
73.68% <0%> (-5.27%)
0% <0%> (ø)

...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java
67.96% <0%> (-3.13%)
0% <0%> (ø)

...pache/dubbo/registry/support/AbstractRegistry.java
78.54% <0%> (-3.07%)
0% <0%> (ø)

...dubbo/remoting/exchange/support/DefaultFuture.java
71.42% <0%> (-2.05%)
0% <0%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c3c2f...2c566fa. Read the comment docs.


Question about region swapping

Hello! I recently imported a small n3ds from Japan. It's brand new and has obviously never connected to the internet before. Would it be possible to region swap this to an USA n3ds and give it eShop access?

region change on New3DS will break eshop. there is no known workaround.

Really? I remember asking this before and someone showed their region swapped 3DS on the eShop.

was it New 3DS? because Old 3DS can access eShop after region change after doing certain steps. https://github.com/Plailect/Guide/wiki/Region-Changing

https://github.com/Plailect/Guide/issues/162
I had to do a little search but I found my old issue thread. He posted a picture if that helps. I can't screenshot it because I can't get it to fit properly with the text on screen and yes it was on a New 3DS

Added this info


Initial: Offchain Workers

Initial version of offchain workers (#1458)

The worker task is started after every block.
All modules by default do nothing in the offchain task, they can implement a behaviour by specifying fn offchain_worker() function in decl_module (alike on_initialise)
Runtime uses Executive module to dispatch the call to all modules.
Offchain tasks run with a different Context of execution, it means that additional externalities are available for those functions (currently only submit_extrinsic).
All inherents produced during execution end up in a very simple InherentsPool and are included as extrinsics (after regular inherents, but before transactions) when new block is created.

Additional work to folllow:

[ ] Implement a concrete example for delegated voting.
[ ] Support async fetch.
[ ] Handle long-running tasks gracefuly.
[ ] Require extrinsics to be included before a particular block
[ ] Use OpaqueTransaction for submit_extrinsic transaction type

Ready for review again, I think all issues have been addressed.
I've also added a flag to control if offchain workers are enabled, by default they are run only when the node is authoring blocks.
I plan to address all the pending issues in subsequent PRs.

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:
https://forum.polkadot.network/t/offchain-workers-design-assumptions-vulnerabilities/2548/1


Add excludePatterns parameter

This is a great tool. Thank you for open-sourcing it.
Using the tool would become easier if there is a way to optionally exclude some notebooks using pattern-based rules.
The simplest implementation, albeit not the most user friendly, would be to use a single regular expression. Using anchoring and disjunction (|) many separate patterns can be handled via a single regex. A more user-friendly way would be to support a list of glob patterns.

Thanks Simeon.  Glad you find the tool useful.    I should have some time in the next few weeks to investigate adding the exclude functionality.    I will keep you updated.


How can i show custom image ?

Hello
I want to show a custom image of how can I achieve  please help me out

Hello @rohitTechStone
How do you want to render the image?
Do you want to change the texture?

hello @andresoviedo
yes I have an image URL I want to render the URL image into the view it is posible

hello @rohitTechStone
if you want to load an image in the OpenGL 3D canvas you can do it by loading a texture using a URI a a parameter.
Then you can bind that texture to the object. The object needs texture coordinates.
You have an example in the app on "menu -> samples -> cube"
Is that what you want to achieve or you want something else?
Regards


[Docs] Website is not responsive

Current State:
Not responsive UI
Desired State:
Responsive and fits in all types of screens

Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

Thank for filing this issue, @diru1100. This is a good goal and something that we should do. If there are specific areas in the docs to make responsive or new approaches to certain challenges (like image sizing), please do itemize them and let’s start knocking them down (implementing). 👍

Thank for filing this issue, @diru1100. This is a good goal and something that we should do. If there are specific areas in the docs to make responsive or new approaches to certain challenges (like image sizing), please do itemize them and let’s start knocking them down (implementing). 👍

@diru1100 would you like to work on this (be assigned this issue)?

@diru1100 would you like to work on this (be assigned this issue)?

@leecalcote I think this issue is more broad and can have mutliple sub issues. I will try to solve some of them.

@leecalcote I think this issue is more broad and can have mutliple sub issues. I will try to solve some of them.


Show users region in top bar

Changes in this PR
We show the user's region at the top of each page
Screenshots of UI changes
Before

After

Release checklist
As part of our continuous deployment strategy we must ensure that this work is
ready to be released at any point. Before merging to main we must first
confirm:
Pre merge checklist

[ ] Have all changes to any dependencies been deployed to both preprod and
production in a backwards compatible way? (This includes our API,
infrastructure, third-party integrations and any secrets or environment variables)
[ ] Has a required data migration been included in this change or been done in
advance?

Post merge checklist
Once we've merged we now need to release this through to production before
considering it done.
Find the build-and-deploy job in CircleCI
and work through the following steps:

[ ] Has the product manager asked to provide approval for this feature?

[ ] Has the product manager approved?

[ ] Manually approve release to preprod
[ ] Verify change released to preprod
[ ] Manually approve release to prod
[ ] Verify change released to production

Should a release fail at any step, you as the author should now lead the work to
fix it as soon as possible.

 Show user's region in top bar

@patrickjfl Ah yeah, that's more obvious in the dev environment as it's a different domain, but 'Manage your details' is outside of our control