corpus_bleu does not match multi-bleu.perl for very poor translations

example:
tokenized reference:
Their tasks include changing a pump on the faulty stokehold .
Likewise , two species that are very similar in morphology were distinguished using genetics .

tokenized hypothesis:
Teo S yb , oe uNb , R , T t , , t
Tue Ar saln S , , 5istsi l , 5oe R ulO sae oR R

with the multi-bleu.perl script the BLEU score is 0:
BLEU = 0.00, 3.4/0.0/0.0/0.0 (BP=1.000, ratio=1.115, hyp_len=29, ref_len=26)

with corpus_bleu the BLUE score is 43.092382, my understanding is that default corpus_bleu settings corresponds to the multi-bleu.perl script.

from nltk.translate.bleu_score import corpus_bleu

references = [
    'Their tasks include changing a pump on the faulty stokehold .',
    'Likewise , two species that are very similar in morphology were distinguished using genetics .'

]

hypothesis = [
    'Teo S yb , oe uNb , R , T t , , t',
    'Tue Ar saln S , , 5istsi l , 5oe R ulO sae oR R'
]

hypothesis_tokens = [line.split(' ') for line in hypothesis]
references_tokens = [[line.split(' ')] for line in references]

# calculate corpus-bleu score
bleu = corpus_bleu(
    references_tokens, hypothesis_tokens
)

print('BLEU: %f' % (bleu * 100)) # 43.092382

If we look at the numbers from multi-bleu.perl, we see unigram matches of 3.4.
BLEU = 0.00, 3.4/0.0/0.0/0.0 (BP=1.000, ratio=1.115, hyp_len=29, ref_len=26)

And the bad thing about multi-bleu.perl is that it throws away this 3.4 and assumes 0 score once it doesn't have a higher order ngram match. This is not an ideal situation.
So to resolve the isse in #1554,  the develop branch of the nltk after #1330 and #1554 produces:
>>> from nltk.translate.bleu_score import corpus_bleu
>>> hyp = "Teo S yb , oe uNb , R , T t , , t Tue Ar saln S , , 5istsi l , 5oe R ulO sae oR R"
>>> ref = "Their tasks include changing a pump on the faulty stokehold . Likewise , two species that are very similar in morphology were distinguished using genetics ."
>>> corpus_bleu([[ref]], [hyp])
0.03794338950850931

If we split the sentences up:
>>> ref1 = "Their tasks include changing a pump on the faulty stokehold ."
>>> ref2 = "Likewise , two species that are very similar in morphology were distinguished using genetics ."
>>> hyp1 = "Teo S yb , oe uNb , R , T t , , t"
>>> hyp2 = "Tue Ar saln S , , 5istsi l , 5oe R ulO sae oR R"
>>> corpus_bleu([[ref1], [ref2]], [hyp1, hyp2])
0.09768267564445479

Why does nltk calculate BLEU differently from multi-bleu.perl?
NLTK version of BLEU is closer to mteval-v13a.pl instead of mutl-bleu.perl, see https://github.com/nltk/nltk/blob/develop/nltk/test/unit/translate/test_bleu.py#L185
Why don't nltk emulate late multi-bleu.perl?
Though multi-bleu.perl has been recently used widely in deep-learning / nlp publications, the canonical scrip that the machine translation community has been using to evaluate MT shared task is mteval-v13.pl.
What's bad about multi-bleu.perl?
Firstly, it threw away the unigram counts that we see in the example above. Beyond that, it produces undesirable outputs when the reference is short and translation is accurate, see  https://gist.github.com/alvations/e5922afa8c91472d25c58b2d712a93e7
There are other issues that multi-bleu.perl produces that we can resolve with new features NLTK's BLEU implementation, e.g. using auto_reweigh or smoothing_function

To use the bleeding edge version of nltk, please do:
pip install -U https://github.com/nltk/nltk.git

But do note that the develop branch of NLTK is under development so it is possible that the code might break for some modules/functions.

Yes, buggy! Sorry previous comment was wrong.

Just like to check, did you see a warning message like this:
>>> from nltk.translate.bleu_score import corpus_bleu
>>> hyp = "Teo S yb , oe uNb , R , T t , , t Tue Ar saln S , , 5istsi l , 5oe R ulO sae oR R"
>>> ref = "Their tasks include changing a pump on the faulty stokehold . Likewise , two species that are very similar in morphology were distinguished using genetics ."
>>> corpus_bleu([[ref.split()]], [hyp.split()])
nltk/translate/bleu_score.py:473: UserWarning:
Corpus/Sentence contains 0 counts of 2-gram overlaps.
BLEU scores might be undesirable; use SmoothingFunction().
  warnings.warn(_msg)
0.43092381945890607

In that case, the issue can be resolved by using SmoothingFunction.method4, e.g.:
>>> from nltk.translate.bleu_score import SmoothingFunction
>>> from nltk.translate.bleu_score import corpus_bleu
>>> hyp = "Teo S yb , oe uNb , R , T t , , t Tue Ar saln S , , 5istsi l , 5oe R ulO sae oR R"
>>> ref = "Their tasks include changing a pump on the faulty stokehold . Likewise , two species that are very similar in morphology were distinguished using genetics ."
>>> chencherry = SmoothingFunction()
>>> corpus_bleu([[ref.split()]], [hyp.split()], smoothing_function=chencherry.method4)
0.17261970532895454

A BLEU score of 17 is still way too high.

0.17 out of 100.0 BLEU ;P

0.17 out of 100.0 BLEU, not 0.17 out of 1.0 BLEU ;P

Are you sure about that? If I set hyp = ref then I get a BLEU score of 1.0 not 100:
>>> from nltk.translate.bleu_score import SmoothingFunction
>>> from nltk.translate.bleu_score import corpus_bleu
>>> ref = "Their tasks include changing a pump on the faulty stokehold . Likewise , two species that are very similar in morphology were distinguished using genetics ."
>>> hyp = ref
>>> chencherry = SmoothingFunction()
>>> corpus_bleu([[ref.split()]], [hyp.split()], smoothing_function=chencherry.method4)
1.0

BTW, did you see the warning? It's important because if the warning isn't there, then we have to make it more prominent by maybe raising an error.

Yes, I did get the warning.

Whoops, my bad. Maybe someone with fresh eyes can take a look at it. I'll be busy in the next 1-2 months =(
Any suggestions on how to fix this?

I'm trying to take a poke at this over the weekend. Any suggestions on how we should approach this?

@AndreasMadsen actually I've worked through the math by hand and 17 BLEU for the example you've given is really similar to the "the the the the the the the" example in the original BLEU paper, see also https://gist.github.com/alvations/e5922afa8c91472d25c58b2d712a93e7
The implementation of the basic BLEU score in NLTK isn't exactly flawed but it has never meant to emulate the effects of multi-bleu.pl because multi-bleu.pl put in a hacked that wasn't considered in the paper, i.e. to return a 0.0 score if any of the 1- to 4- gram returns a 0.0 precision.
To emulate that behavior, I've added some "hack" to set the precision (a fraction/floating point) to the smallest negative value that any system can take and then taking the log of it would have caused it to end up with large negative value and then when the BLEU formula takes the exponential of the modified precision before multiplying it with the brevity penalty, it should set the precision back to the minimal negative value and the final rounding off that's kicked in when emulate_multibleu parameter is set to True would cause the final BLEU value to be clipped at 0, i.e.:
>>> import sys
>>> from math import log, exp
>>> sys.float_info.min
2.2250738585072014e-308
>>> log(sys.float_info.min)
-708.3964185322641
>>> exp(log(sys.float_info.min))
2.2250738585072626e-308
>>> round(exp(log(sys.float_info.min)), 4)
0.0

@alvations I see, thanks for looking into it.


Option to set default profile or default settings per language

For some reason script/Atom.io selects an old PHP 5.5 which is nowhere in my path. So I have to run using a profile which is super inconvenient (extra key comb + select profile + hit enter).
Alternatively add cmd path settings.
(Wondering how command is executed, what is the env/context? I'd say that /bin/env $cmd should give the "correct" version in most cases?)

This would be really useful. Babel now recommends not installing babel-cli globally. This makes running ES2015 code with atom-script require a profile to point it to your local copy of babel-node, and the extra keystrokes can get pretty annoying after a while. I'm guessing this is a pretty common use case.

@shanecav In my ideal situation it would run it relative to npm bin, so it picks up all the babel plugins you have installed locally as dev deps too. Not sure how to carry that out in the context of Atom script though.

+1

Has anyone tried a hack around this? I need to run STATA as a different profile every time to pick up the different flavour (MP vs default)

I tried overriding the grammar -> command mapping in my init script but that didn't work:
script:
  Python:
    "File Based":
      command = "python3"

This worked for me for python. In the /home/.atom/packages/script/lib/grammars.coffee file, under Python, change the default python commands to python3. Although this describes a solution to setting python3 as default, all other language preferences can be edited in that file, too.

I changed /home//.atom/packages/script/lib/grammars/python.coffee from
exports.Python =
  'Selection Based':
    command: 'python'
    args: (context) -> ['-u', '-c', context.getCode()]

  'File Based':
    command: 'python'
    args: ({filepath}) -> ['-u', filepath]

exports.MagicPython = exports.Python

exports.Sage =
  'Selection Based':
    command: 'sage'
    args: (context) -> ['-c', context.getCode()]

  'File Based':
    command: 'sage'
    args: ({filepath}) -> [filepath]

to
exports.Python =
  'Selection Based':
    command: 'python3'
    args: (context) -> ['-u', '-c', context.getCode()]

  'File Based':
    command: 'python3'
    args: ({filepath}) -> ['-u', filepath]

exports.MagicPython = exports.Python

exports.Sage =
  'Selection Based':
    command: 'sage'
    args: (context) -> ['-c', context.getCode()]

  'File Based':
    command: 'sage'
    args: ({filepath}) -> [filepath]


Ticking Entity[BUG]

[Please fill out the form below and delete the sections in square brackets after reading them]
Version of Advanced Rocketry

AdvancedRocketry-1.12.2-2.0.0-250-universal

Why is this important?
Knowing the version of Advanced Rocketry helps us narrow down an offending piece of code faster because we can easily determine what code is added and when.]

Have you verified this is an issue in the latest unstable build

[x] Y

[Why is this important?
If you're not testing with the latest build, you may be encountering a bug that's already been fixed.
Reporting bugs that have already been fixed wastes everyone's time.  (please look in open issues too, somebody else could have already reported it!)]

Version of LibVulpes

LibVulpes-1.12.2-0.4.2-83-universal

Why is this important?
Advanced rocketry depends on a library mod (LibVulpes), some errors can really be in that mod.  So knowing the verison helps us not only start looking for fixes there without you needing to anwer more questions, it also helps us know if you have a version mismatch.]

Version of Minecraft

1.12.2

Why is this important?
Different versions of minecraft have different codebases for Advanced Rocketry.  Knowing the version of minecraft (and thus AR) helps us pinpoint issues quicker!]

Does this occur without other mods installed

[x] Y
[ ]

If Y, what is the MINIMUM set of mods required.
I think, only Advanced Rocketry & LibVulpes,
[Why is this important?
Sometimes interactions between mods cause issues.  While it can be a problem with Advanced Rocketry, sometimes it's not.  When there are a lot of mods, it can take bugtesters HOURS to go through the list to determine the root cause.  When there are a lot of bug reports, that can add DAYS to the time it takes to fix a large set of issues.]

Crash report or log or visualVM (if applicable)
http://pastebin.com is a good place to put them
crash reports that are put in the issue itself are
hard to read

---- Minecraft Crash Report ----

WARNING: coremods are present:
llibrary (llibrary-core-1.0.11-1.12.2.jar)
AdvancedRocketryPlugin (AdvancedRocketry-1.12.2-2.0.0-250-universal.jar)
EnderCorePlugin (EnderCore-1.12.2-0.5.76-core.jar)
CreativePatchingLoader (CreativeCore_v1.10.61_mc1.12.2.jar)
XaeroWorldMapPlugin (XaerosWorldMap_1.14.5_Forge_1.12.jar)
ShutdownPatcher (mcef-1.12.2-1.11-coremod.jar)
MicdoodlePlugin (MicdoodleCore-1.12.2-<IP_ADDRESS>0.jar)
SteveKunGLibPlugin (SteveKunG's-Lib-1.12.2-1.1.10.jar)
iceandfire (iceandfire-1.9.1-1.12.2.jar)
XaeroMinimapPlugin (Xaeros_Minimap_21.12.4_Forge_1.12.jar)
Contact their authors BEFORE contacting forge
// You're mean.
Time: 7/8/21 12:07 PM
Description: Ticking entity
java.lang.NullPointerException: Ticking entity
at zmaster587.advancedRocketry.entity.EntityElevatorCapsule.func_70030_z(EntityElevatorCapsule.java:287)
at net.minecraft.entity.Entity.func_70071_h_(Entity.java:389)
at net.minecraft.world.World.func_72866_a(World.java:1996)
at net.minecraft.world.World.func_72870_g(World.java:1958)
at net.minecraft.world.World.func_72939_s(World.java:1762)
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1847)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1098)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:398)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
A detailed walkthrough of the error, its code path and all known details is as follows:
-- Head --
Thread: Client thread
Stacktrace:
at zmaster587.advancedRocketry.entity.EntityElevatorCapsule.func_70030_z(EntityElevatorCapsule.java:287)
at net.minecraft.entity.Entity.func_70071_h_(Entity.java:389)
at net.minecraft.world.World.func_72866_a(World.java:1996)
at net.minecraft.world.World.func_72870_g(World.java:1958)
-- Entity being ticked --
Details:
Entity Type: advancedrocketry:arspaceelevatorcapsule (zmaster587.advancedRocketry.entity.EntityElevatorCapsule)
Entity ID: 171902
Entity Name: entity.ARSpaceElevatorCapsule.name
Entity's Exact location: -1551.50, 117.00, -1537.50
Entity's Block location: World: (-1552,117,-1538), Chunk: (at 0,7,14 in -97,-97; contains blocks -1552,0,-1552 to -1537,255,-1537), Region: (-4,-4; contains chunks -128,-128 to -97,-97, blocks -2048,0,-2048 to -1537,255,-1537)
Entity's Momentum: 0.00, 0.85, 0.00
Entity's Passengers: []
Entity's Vehicle: ERROR NullPointerException: null
Stacktrace:
at net.minecraft.world.World.func_72939_s(World.java:1762)
-- Affected level --
Details:
Level name: MpServer
All players: 1 total; [GCEntityClientPlayerMP['Gaminguide1000'/171898, l='MpServer', x=-1514.50, y=1221.00, z=-1535.50]]
Chunk stats: MultiplayerChunkCache: 441, 441
Level seed: 0
Level generator: ID 09 - Space, ver 0. Features enabled: false
Level generator options:
Level spawn location: World: (104,64,252), Chunk: (at 8,4,12 in 6,15; contains blocks 96,0,240 to 111,255,255), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,0,0 to 511,255,511)
Level time: 18717215 game time, 189234 day time
Level dimension: 0
Level storage version: 0x00000 - Unknown?
Level weather: Rain time: 0 (now: false), thunder time: 0 (now: false)
Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false
Forced entities: 6 total; [GCEntityClientPlayerMP['Gaminguide1000'/171898, l='MpServer', x=-1514.50, y=1221.00, z=-1535.50], EntityLatchedRenderer['unknown'/1, l='MpServer', x=8.50, y=65.00, z=8.50], EntityRocket['Rocket'/171899, l='MpServer', x=-1514.50, y=1000.00, z=-1535.50], EntityElevatorCapsule['entity.ARSpaceElevatorCapsule.name'/171902, l='MpServer', x=-1551.50, y=117.00, z=-1537.50], EntityElevatorCapsule['entity.ARSpaceElevatorCapsule.name'/171900, l='MpServer', x=-1551.50, y=119.85, z=-1538.50], EntityElevatorCapsule['entity.ARSpaceElevatorCapsule.name'/171901, l='MpServer', x=-1551.50, y=120.00, z=-1537.50]]
Retry entities: 1 total; [EntityLatchedRenderer['unknown'/1, l='MpServer', x=8.50, y=65.00, z=8.50]]
Server brand: fml,forge
Server type: Non-integrated multiplayer server
Stacktrace:
at net.minecraft.client.multiplayer.WorldClient.func_72914_a(WorldClient.java:532)
at net.minecraft.client.Minecraft.func_71396_d(Minecraft.java:2741)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:419)
at net.minecraft.client.main.Main.main(SourceFile:123)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
-- System Details --
Details:
Minecraft Version: 1.12.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_51, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory:<PHONE_NUMBER> bytes (5178 MB) /<PHONE_NUMBER> bytes (8286 MB) up to<PHONE_NUMBER>4 bytes (16384 MB)
JVM Flags: 4 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx18G -Xms1G -XX:PermSize=1G
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP 9.42 Powered by Forge <IP_ADDRESS>55 Optifine OptiFine_1.12.2_HD_U_G6_pre1 98 mods loaded, 98 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
| State  | ID                                | Version            | Source                                               | Signature                                |
|:------ |:--------------------------------- |:------------------ |:---------------------------------------------------- |:---------------------------------------- |
| LCHIJA | minecraft                         | 1.12.2             | minecraft.jar                                        | None                                     |
| LCHIJA | mcp                               | 9.42               | minecraft.jar                                        | None                                     |
| LCHIJA | FML                               | <IP_ADDRESS>          | forge-1.12.2-<IP_ADDRESS>55.jar                        | e3c3d50c7c986df74c645c0ac54639741c90a557 |
| LCHIJA | forge                             | <IP_ADDRESS>55       | forge-1.12.2-<IP_ADDRESS>55.jar                        | e3c3d50c7c986df74c645c0ac54639741c90a557 |
| LCHIJA | advancedrocketrycore              | 1                  | minecraft.jar                                        | None                                     |
| LCHIJA | creativecoredummy                 | 1.0.0              | minecraft.jar                                        | None                                     |
| LCHIJA | micdoodlecore                     |                    | minecraft.jar                                        | None                                     |
| LCHIJA | xaerominimap_core                 | 1.12.2-1.0         | minecraft.jar                                        | None                                     |
| LCHIJA | xaeroworldmap_core                | 1.12.2-1.0         | minecraft.jar                                        | None                                     |
| LCHIJA | securitycraft                     | v<IP_ADDRESS>          | [1.12.2] SecurityCraft v<IP_ADDRESS>.jar                 | None                                     |
| LCHIJA | wolffsmod                         | 2.2                | [1.12.2]-Flan's-Mod-Vehicles-for-Custom-NPCs-2.2.jar | None                                     |
| LCHIJA | libvulpes                         | 0.4.2.-83          | LibVulpes-1.12.2-0.4.2-83-universal.jar              | None                                     |
| LCHIJA | advancedrocketry                  | 2.0.0.-250         | AdvancedRocketry-1.12.2-2.0.0-250-universal.jar      | None                                     |
| LCHIJA | baubles                           | 1.5.2              | Baubles-1.12-1.5.2.jar                               | None                                     |
| LCHIJA | flyringbaublemod                  | 0.3.1_1.12-d4e654e | angelRingToBauble-1.12-<IP_ADDRESS>+d4e654e.jar          | None                                     |
| LCHIJA | flansmod                          | 5.10.0             | Flan's Mod-1.12.2-5.10.0.jar                         | None                                     |
| LCHIJA | flansmodapocalypse                | 1.4.0              | Apocalypse-Content Pack-1.12.2-5.10.0.jar            | None                                     |
| LCHIJA | mantle                            | 1.12-<IP_ADDRESS>      | Mantle-1.12-<IP_ADDRESS>.jar                             | None                                     |
| LCHIJA | endercore                         | 1.12.2-0.5.76      | EnderCore-1.12.2-0.5.76.jar                          | None                                     |
| LCHIJA | jei                               | <IP_ADDRESS>1         | jei_1.12.2-<IP_ADDRESS>1.jar                            | None                                     |
| LCHIJA | thaumcraft                        | 6.1.BETA26         | Thaumcraft-1.12.2-6.1.BETA26.jar                     | None                                     |
| LCHIJA | enderio                           | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderiointegrationtic             | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | twilightforest                    | 3.11.1021          | twilightforest-1.12.2-3.11.1021-universal.jar        | None                                     |
| LCHIJA | tconstruct                        | 1.12.2-<IP_ADDRESS>  | TConstruct-1.12.2-<IP_ADDRESS>.jar                     | None                                     |
| LCHIJA | bhc                               | 2.0.3              | baubley-heart-canisters-1.12.2-2.0.3.jar             | None                                     |
| LCHIJA | biomesoplenty                     | <IP_ADDRESS>4         | BiomesOPlenty-1.12.2-<IP_ADDRESS>4-universal.jar        | None                                     |
| LCHIJA | botania                           | r1.10-364          | Botania r1.10-364.4.jar                              | None                                     |
| LCHIJA | buildcraftlib                     | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | buildcraftcore                    | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | buildcraftbuilders                | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | buildcrafttransport               | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | buildcraftsilicon                 | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | buildcraftcompat                  | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | buildcraftenergy                  | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | buildcraftfactory                 | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | buildcraftrobotics                | <IP_ADDRESS>          | buildcraft-all-<IP_ADDRESS>.jar                         | None                                     |
| LCHIJA | carryon                           | 1.12.3             | carryon-1.12.2-<IP_ADDRESS>.jar                         | fd21553434f4905f2f73ea7838147ac4ea07bd88 |
| LCHIJA | codechickenlib                    | <IP_ADDRESS>8          | CodeChickenLib-1.12.2-<IP_ADDRESS>8-universal.jar        | f1850c39b2516232a2108a7bd84d1cb5df93b261 |
| LCHIJA | chickenchunks                     | <IP_ADDRESS>           | ChickenChunks-1.12.2-<IP_ADDRESS>-universal.jar          | f1850c39b2516232a2108a7bd84d1cb5df93b261 |
| LCHIJA | chiselsandbits                    | 14.33              | chiselsandbits-14.33.jar                             | None                                     |
| LCHIJA | creativecore                      | 1.10.0             | CreativeCore_v1.10.61_mc1.12.2.jar                   | None                                     |
| LCHIJA | cucumber                          | 1.1.3              | Cucumber-1.12.2-1.1.3.jar                            | None                                     |
| LCHIJA | cyberware                         | <IP_ADDRESS>          | cyberware-1.12.2-<IP_ADDRESS>.jar                       | None                                     |
| LCHIJA | divinerpg                         | 1.7.1              | DivineRPG-1.7.1.jar                                  | None                                     |
| LCHIJA | enchantingwiththaumcraft          | 1.3                | enchantingwiththaumcraft-1.3.jar                     | None                                     |
| LCHIJA | enchdesc                          | 1.1.15             | EnchantmentDescriptions-1.12.2-1.1.15.jar            | d476d1b22b218a10d845928d1665d45fce301b27 |
| LCHIJA | enderiobase                       | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderioconduits                   | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderioconduitsappliedenergistics | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderioconduitsopencomputers      | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderioconduitsrefinedstorage     | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderiointegrationforestry        | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderiointegrationticlate         | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderioinvpanel                   | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderiomachines                   | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | enderiopowertools                 | 5.3.70             | EnderIO-1.12.2-5.3.70.jar                            | None                                     |
| LCHIJA | motnt                             | 1.0.1              | EvenMoreTNT-1.0.1.jar                                | None                                     |
| LCHIJA | galacticraftcore                  | <IP_ADDRESS>0          | GalacticraftCore-1.12.2-<IP_ADDRESS>0.jar                | None                                     |
| LCHIJA | galacticraftplanets               | <IP_ADDRESS>0          | Galacticraft-Planets-1.12.2-<IP_ADDRESS>0.jar            | None                                     |
| LCHIJA | gravestone                        | 1.10.3             | gravestone-1.10.3.jar                                | None                                     |
| LCHIJA | ichunutil                         | 7.2.2              | iChunUtil-1.12.2-7.2.2.jar                           | 4db5c2bd1b556f252a5b8b54b256d381b2a0a6b8 |
| LCHIJA | gravitygun                        | 7.1.0              | GravityGun-1.12.2-7.1.0.jar                          | 4db5c2bd1b556f252a5b8b54b256d381b2a0a6b8 |
| LCHIJA | waila                             | 1.8.26             | Hwyla-1.8.26-B41_1.12.2.jar                          | None                                     |
| LCHIJA | llibrary                          | 1.7.20             | llibrary-1.7.20-1.12.2.jar                           | b9f30a813bee3b9dd5652c460310cfcd54f6b7ec |
| LCHIJA | iceandfire                        | 1.9.1              | iceandfire-1.9.1-1.12.2.jar                          | None                                     |
| LCHIJA | ironchest                         | 1.12.2-<IP_ADDRESS>4  | ironchest-1.12.2-<IP_ADDRESS>7.jar                      | None                                     |
| LCHIJA | ironjetpacks                      | 1.1.0              | IronJetpacks-1.12-2-1.1.0.jar                        | None                                     |
| LCHIJA | mcef                              | 1.11               | mcef-1.12.2-1.11.jar                                 | None                                     |
| LCHIJA | mechapartspack                    | 5.7.2              | Mecha Parts-Content Pack-1.12.2-5.7.2.jar            | None                                     |
| LCHIJA | modernweaponspack                 | 5.8.2              | Modern Warfare-Content Pack-1.12.2-5.8.2.jar         | None                                     |
| LCHIJA | stevekung's_lib                   | 1.1.10             | SteveKunG's-Lib-1.12.2-1.1.10.jar                    | None                                     |
| LCHIJA | moreplanets                       | 2.2.1              | More-Planets-1.12.2-2.2.1-GC280.jar                  | None                                     |
| LCHIJA | morph                             | 7.2.0              | Morph-1.12.2-7.2.1.jar                               | 4db5c2bd1b556f252a5b8b54b256d381b2a0a6b8 |
| LCHIJA | morpheus                          | 1.12.2-3.5.106     | Morpheus-1.12.2-3.5.106.jar                          | None                                     |
| LCHIJA | natura                            | 1.12.2-<IP_ADDRESS>    | natura-1.12.2-<IP_ADDRESS>.jar                           | None                                     |
| LCHIJA | neat                              | 1.4-17             | Neat+1.4-17.jar                                      | None                                     |
| LCHIJA | opframe                           | 1.4.0              | OnlinePicFrame_v1.5.0-pre1_mc1.12.2.jar              | None                                     |
| LCHIJA | p455w0rdslib                      | 2.3.161            | p455w0rdslib-1.12.2-2.3.161.jar                      | 186bc454cd122c9c2f1aa4f95611254bcc543363 |
| LCHIJA | portalgun                         | 7.1.0              | PortalGun-1.12.2-7.1.0.jar                           | 4db5c2bd1b556f252a5b8b54b256d381b2a0a6b8 |
| LCHIJA | rild                              | 0.4                | Rild Mod V.1.12.2-0.4.jar                            | None                                     |
| LCHIJA | simplepartspack                   | 5.7.2              | Simple Parts-Content Pack-1.12.2-5.7.2.jar           | None                                     |
| LCHIJA | srparasites                       | 1.8.2              | SRParasites-1.12.2v1.8.2.jar                         | None                                     |
| LCHIJA | tc6aspects4jei                    | 0.0.2a             | tc6aspects4jei-0.0.2a.jar                            | None                                     |
| LCHIJA | thaumcraftnoresearch              | 1.0                | ThaumcraftNoResearch-1.0.jar                         | None                                     |
| LCHIJA | tcinventoryscan                   | 2.0.10             | ThaumicInventoryScanning_1.12.2-2.0.10.jar           | None                                     |
| LCHIJA | thaumicjei                        | 1.6.0              | ThaumicJEI-1.12.2-1.6.0-27.jar                       | None                                     |
| LCHIJA | thaumicwaila                      | 1.12.2-0.0.2       | ThaumicWaila-1.12.2-0.0.2.jar                        | None                                     |
| LCHIJA | titanpack                         | 5.7.2              | Titan-Content Pack-1.12.2-5.7.2.jar                  | None                                     |
| LCHIJA | tntguns                           | 1.0.5              | TNTsGuns1.0.5.jar                                    | None                                     |
| LCHIJA | travelersbackpack                 | 1.0.35             | TravelersBackpack-1.12.2-1.0.35.jar                  | None                                     |
| LCHIJA | wailaharvestability               | 1.1.12             | WailaHarvestability-mc1.12-1.1.12.jar                | None                                     |
| LCHIJA | webdisplays                       | 1.1                | webdisplays-1.12.2-1.1.jar                           | None                                     |
| LCHIJA | ww2pack                           | 5.7.2              | WW2-Content Pack-1.12.2-5.7.2.jar                    | None                                     |
| LCHIJA | xaerominimap                      | 21.12.4            | Xaeros_Minimap_21.12.4_Forge_1.12.jar                | None                                     |
| LCHIJA | xaeroworldmap                     | 1.14.5             | XaerosWorldMap_1.14.5_Forge_1.12.jar                 | None                                     |
| LCHIJA | yeoldepack                        | 5.8.2              | Ye Olde-Content Pack-1.12.2-5.8.2.jar                | None                                     |
| LCHIJA | zombiepack                        | 5.8.5              | Zombie-Content Pack-1.12.2-5.8.5.jar                 | None                                     |

Loaded coremods (and transformers):

llibrary (llibrary-core-1.0.11-1.12.2.jar)
net.ilexiconn.llibrary.server.core.plugin.LLibraryTransformer
net.ilexiconn.llibrary.server.core.patcher.LLibraryRuntimePatcher
AdvancedRocketryPlugin (AdvancedRocketry-1.12.2-2.0.0-250-universal.jar)
zmaster587.advancedRocketry.asm.ClassTransformer
EnderCorePlugin (EnderCore-1.12.2-0.5.76-core.jar)
com.enderio.core.common.transform.EnderCoreTransformer
com.enderio.core.common.transform.SimpleMixinPatcher
CreativePatchingLoader (CreativeCore_v1.10.61_mc1.12.2.jar)
XaeroWorldMapPlugin (XaerosWorldMap_1.14.5_Forge_1.12.jar)
xaero.map.core.transformer.ChunkTransformer
xaero.map.core.transformer.NetHandlerPlayClientTransformer
xaero.map.core.transformer.EntityPlayerTransformer
xaero.map.core.transformer.AbstractClientPlayerTransformer
xaero.map.core.transformer.WorldClientTransformer
xaero.map.core.transformer.PlayerListTransformer
ShutdownPatcher (mcef-1.12.2-1.11-coremod.jar)
net.montoyo.mcef.coremod.ShutdownPatcher
MicdoodlePlugin (MicdoodleCore-1.12.2-<IP_ADDRESS>0.jar)
micdoodle8.mods.miccore.MicdoodleTransformer
SteveKunGLibPlugin (SteveKunG's-Lib-1.12.2-1.1.10.jar)
iceandfire (iceandfire-1.9.1-1.12.2.jar)
com.github.alexthe666.iceandfire.patcher.IceAndFireRuntimePatcher
XaeroMinimapPlugin (Xaeros_Minimap_21.12.4_Forge_1.12.jar)
xaero.common.core.transformer.ChunkTransformer
xaero.common.core.transformer.NetHandlerPlayClientTransformer
xaero.common.core.transformer.EntityPlayerTransformer
xaero.common.core.transformer.AbstractClientPlayerTransformer
xaero.common.core.transformer.WorldClientTransformer
xaero.common.core.transformer.EntityPlayerSPTransformer
xaero.common.core.transformer.PlayerListTransformer
xaero.common.core.transformer.GuiIngameForgeTransformer
xaero.common.core.transformer.GuiBossOverlayTransformer
xaero.common.core.transformer.ModelRendererTransformer
GL info: ' Vendor: 'ATI Technologies Inc.' Version: '4.6.14831 Compatibility Profile Context 21.5.2 27.20.21003.8013' Renderer: 'AMD Radeon RX 6700 XT'
Ender IO: Found the following problem(s) with your installation (That does NOT mean that Ender IO caused the crash or was involved in it in any way. We add this information to help finding common problems, not as an invitation to post any crash you encounter to Ender IO's issue tracker. Always check the stack trace above to see which mod is most likely failing.):
* Optifine is installed. This is NOT supported.
This may (look up the meaning of 'may' in the dictionary if you're not sure what it means) have caused the error. Try reproducing the crash WITHOUT this/these mod(s) before reporting it.
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!You are looking at the diagnostics information, not at the crash.       !!!
!!!Scroll up until you see the line with '---- Minecraft Crash Report ----'!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Pulsar/tconstruct loaded Pulses:
	- TinkerCommons (Enabled/Forced)
	- TinkerWorld (Enabled/Not Forced)
	- TinkerTools (Enabled/Not Forced)
	- TinkerHarvestTools (Enabled/Forced)
	- TinkerMeleeWeapons (Enabled/Forced)
	- TinkerRangedWeapons (Enabled/Forced)
	- TinkerModifiers (Enabled/Forced)
	- TinkerSmeltery (Enabled/Not Forced)
	- TinkerGadgets (Enabled/Not Forced)
	- TinkerOredict (Enabled/Forced)
	- TinkerIntegration (Enabled/Forced)
	- TinkerFluids (Enabled/Forced)
	- TinkerMaterials (Enabled/Forced)
	- TinkerModelRegister (Enabled/Forced)
	- chiselsandbitsIntegration (Enabled/Not Forced)
	- wailaIntegration (Enabled/Not Forced)

Pulsar/natura loaded Pulses:
	- NaturaCommons (Enabled/Forced)
	- NaturaOverworld (Enabled/Not Forced)
	- NaturaNether (Enabled/Not Forced)
	- NaturaDecorative (Enabled/Not Forced)
	- NaturaTools (Enabled/Not Forced)
	- NaturaEntities (Enabled/Not Forced)
	- NaturaOredict (Enabled/Forced)
	- NaturaWorld (Enabled/Not Forced)

Launched Version: forge-<IP_ADDRESS>55
LWJGL: 2.9.4
OpenGL: AMD Radeon RX 6700 XT GL version 4.6.14831 Compatibility Profile Context 21.5.2 27.20.21003.8013, ATI Technologies Inc.
GL Caps: Using GL 1.3 multitexturing.

Using GL 1.3 texture combiners.
Using framebuffer objects because OpenGL 3.0 is supported and separate blending is supported.
Shaders are available because OpenGL 2.1 is supported.
VBOs are available because OpenGL 1.5 is supported.
Using VBOs: Yes
Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Resource Packs:
Current Language: English (US)
Profiler Position: N/A (disabled)
CPU: 24x AMD Ryzen 9 5900X 12-Core Processor
OptiFine Version: OptiFine_1.12.2_HD_U_G6_pre1
OptiFine Build: 20210323-161358
Render Distance Chunks: 16
Mipmaps: 4
Anisotropic Filtering: 1
Antialiasing: 0
Multitexture: false
Shaders: null
OpenGlVersion: 4.6.14831 Compatibility Profile Context 21.5.2 27.20.21003.8013
OpenGlRenderer: AMD Radeon RX 6700 XT
OpenGlVendor: ATI Technologies Inc.
CpuCount: 24

If it's an issue involving lag, please submit a visualVM sampler snapshot.  Mods like lag goggles often do not provide the kind of information needed to debug lag.
For more information on how to create a snapshot, please see "How to Run CPU Sampling" here.  Then export the snapshot as an .nps.  You may have to zip it since github is weird, then please upload it here.

Why is this important?
Full crashlogs contain valuable information like where exactly in the code the error occurred, what other mods may be running and what version of forge you have.  This helps us replicate and diagnose the issue FAR faster.]

Description of the problem

Well i Tried to go to the Space Station, using a ocket (worked fine). Then i built a Space Station Elevator, linked it to another one on the earth, and wqhen i try to go to the earth, using the Elevator, it works. But when i want to go to the Space Station using the Elevator, it just Crashes. When i tried the same with the Rocket, it happend too. When i try to rejoin on the Server, my Minecraft crashes, and crashes ovr an over again. The same happend to my Friend :/

Why is this important?
If we cannot reproduce the problem, we probably cannot fix it at all.]

Format not followed + this is likely multiple different crashes, each of which is I believe fixed in the next update.


diagnostics in rplidar_driver

Adds diagnostic messages to RPLidar Driver.
The KeyValue pair contains counter for how many times driver has encountered failure, timeout and bad health status along with elapsed time since node started.

Related PR

Would be good to have this do more than just a count. From a glance, looking at the count doesn't actually tell whether its bad or good - it could be a count of 5 over the course of 10 days (good) or it could be a count of 5 over the course of 30 mins (bad).

It has elapsed_time also by which we can have idea of frequency of error.

Same problem - still probably not a great indicator if the robots are up for a significant amount of time. Could you make it work over a reasonably sized moving window?

Right! Yeah sure.

You could leave the elapsed time and counters as is, just dump timestamps for each type into a deque, pop them off the front if they get too old and then put that 'rate' in the counter view alongside the old values.

the 'rate of error` is now in.

     _  _(o)_(o)_  _
   ._\`:_ F S M _:' \_,
       / (`---'\ `-.
    ,-`  _)    (_,


Update README.md

remove 'experimental' from Readme.

same as https://github.com/spring-projects/spring-ai/commit/6d3c429e95a6906a1e674ac5bfb1bf5f9b8c37f2


unable to attach to the specified process

Hi,
Device: iPhone 6S;
Jailbreak: checkra1n;
Downloaded: OpenSSH at Cyclia
https://github.com/AloneMonkey/frida-ios-dump -l -> works succesfully
https://github.com/AloneMonkey/frida-ios-dump [package-name] -> doesn't work, turns error:
CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release.
  from cryptography.hazmat.backends import default_backend
Start the target app com.apple.icq
unable to attach to the specified process

goes with every other app.
can anyone help?
ty so much.

+1


How to deploy into VPS? or Heroku?

I tried to do it on vps but it doesnt' work.
should I consider updating source code?
Appreciate your help.

I have managed to deploy this into Heroku.
Ensure to expose the config vars / environment variables.
Use heroku/python buildpack.
Create a Procfile with:
web: uvicorn app.server:app --host=<IP_ADDRESS> --port=$PORT

I used custom llm model so need large cpu and ram
I choose vps
I tried to do with nginx for wss connection but failed.
Please let me know how to tackle this issue.


Fix typo

@alakyadav : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Remove collectd/disk monitor

Description:
This PR removes the deprecated collectd/disk monitor in favor of the disk-io monitor. This component was deprecated 3 years 11 months.
    **This monitor has been deprecated in favor of the `disk-io` monitor.
    Please migrate to that monitor as this collectd-based monitor will be
    removed in a future release of the agent.**  Note that the `disk-io`
    monitor has a different dimension (`disk` instead of `plugin_instance`) to
    specify the disk.

@rmfitzpatrick ok to approve at this time?


[feature request] deployment script for AWS lambda?

@PicoCreator I believe you are referring to creating lambda functions and deploy scripts for the api?

@codehakase : Yup ideally allowing it to be easily deployed in the same way as firebase - https://github.com/uilicious/inboxkitten/tree/master/deploy/firebase
Hopefully it shouldn't need much changes to support (havent used aws lambda personally)


BUGFIX: Enable liveSearchCheckbox with 0 results

The problem:
Some users frequently search GOV.UK by editing the URL and keeping their
choice of organisation filters in place, e.g.
https://www.gov.uk/search?q=Housing&filter_organisations[]=land-registry
However, when no results are returned for a query, the organisation filter
(land registry in the example) is still selected and it's no longer possible
to use the "Remove filters" link to easily clear them, e.g.
https://www.gov.uk/search?q=Immigration+Rules&filter_organisations[]=land-registry
What we found:
The "Remove filter" is driven by the GOVUK.CheckboxFilter JavaScript.
However, when there are no results, the component is not being activated.
The fix:
The bug has been fixed by removing the bounds check within the
GOVUK.search.enableLiveSearchCheckbox.
Story: https://trello.com/c/hQqnoc4R/245-when-a-search-has-a-filter-and-no-results-the-remove-filters-link-doesn-t-work

:+1:


Current conda release does not reflect most recent updates to repository

I am building BioPhi using conda and am getting a previously addressed error: Error: module 'numpy' has no attribute 'int' Issue 42.
I took a look at line 83 under the most up to date version tag (1.0.9)  and it seems to still have the old np.int implementation. It looks like the latest version tag is not up to date with the main branch. Any chance you'd be able to release a new version from the current main branch and subsequently publish to bioconda?
Many thanks!
Originally posted by @eliottpark in https://github.com/Merck/BioPhi/issues/42#issuecomment-2231947709

Thanks for the heads up, fixed in new version 1.0.10, available on bioconda

Thank you!


react-aad-implicitflow auto-login adal

[ X ] Question

Hey,
just wondering if anyone made a solution where the user does not have to "log in" or press "connect" as in this sample, to be able to utilize adal?
The user doesnt seem to be caches, I guess this is because we want a "webpart-specific" authenticationcontext?
If anyone could point me in the right direction I would appreciate it :)
/Simon

Would you like to access the Microsoft Graph or a custom API secured with AAD?

I would like to access the Microsoft Graph, and I'm playing around with the PowerBI API aswell.
And just to be clear, everything works in terms of getting data from the graph etc.
Just the login-part that Im cocerned with :)

Gotcha. There is another way to access resources secured with AAD, but it doesn't offer you an access token, which is why I asked what you are trying to access.
Theoretically you could start the authentication flow automatically. Imagine however, that as a user, you come to the page with such web part, and without doing anything, you're presented with a login popup or being redirected to the AAD sign in page. If that's acceptable for your scenario, then you could definitely do it.

Yeah I dont know.
For instance I would like to have a webpart that presents the current users groups.
From my understanding this endpoint is one way: "https://graph.microsoft.com/v1.0/me/memberOf".
But while logged in i SharePoint online it seems a bit "unnecessary" to login in again just to see my groups.
Thanks for the answers!

Hi waldekmastykarz,
I need implement this: https://developer.microsoft.com/en-us/graph/docs/concepts/auth_v2_service
For this I need get token without login, but acquireToken require login. In node.js, for example there is an function acquireTokenWithClientCredentials where I can send client_secret. There are this in angular-adal?
Thank in advance.

@leilaferradas You can only do implicit flow from the client... you can't use client creds client side, only server side.

Hi Andrew,
And, in this example "implicit flow" How can I login automatically,  without the user press the login button?
Thanks

See these two articles for guidance on calling MS Graph... the story isn't ideal today... it's getting better hopefully:
https://github.com/SharePoint/sp-dev-docs/blob/master/docs/spfx/web-parts/guidance/call-microsoft-graph-from-your-web-part.md
https://github.com/SharePoint/sp-dev-docs/blob/master/docs/spfx/web-parts/guidance/connect-to-api-secured-with-aad.md


Push new version to crates.io

The current version hasn't built on Rust nightly in quite some time.
This may want to wait until the fate of #148 has been decided.

0.0.26 out


Support looking up nodes by name

It'd be nice to be able to look up nodes by their name:
tax.get_nodes_by_name("Bacteria")
[ 629395, 2 ]

Done in #25


Centered content jumps with html overflow-y: scroll

Hi! Does anybody know how to keep content centered and not jumping to the right?
http://jsfiddle.net/wLG85/2/
fixedContentPos: false seems to help but then the content is not fixed anymore ;)

@zerodburn  Solution 1 doesn't work for menus since, they are not inside the popup window.

It' only appears when html/body width is 100%


Let BuildToolPlugin replace default build rules

Description
It would be great if a BuildToolPlugin could specify that it replaces the default build rules for the files it handles.
Specifically, I want to put Metal kernels for Core Image into a package. They need to be compiled with certain compiler and linker flags. I figured I can now use a BuildToolPlugin to create a custom build step for those kernels. I found this example that does something similar. However, as also noted by them, the big annoyance here is that SPM will still process the .metal files with its default build rule, creating a default.metallib for the package.
There is no way of telling SPM to not also compile the .metal files that my plugin already handled. I thought a possible workaround would be to give the CI kernel files a different file extension like .ci, but the Metal compiler doesn't like that. It would be great if a plugin could somehow specify that it handles certain files, so that SPM doesn't need to touch them anymore.
Thanks for the consideration!
Expected behavior
When my BuildToolPlugin compiles the .metal files in my package, SPM should not apply its own build rule to create a default.metallib.
Actual behavior
SPM builds the .metal files too, creating a default.metallib that is unneeded.
Swift Package Manager version/commit hash
5.7

I just want to mention I would love to see this capability myself. I have the same use case in mind as Frank. So, in other words... "me, too". 👍

See also: https://github.com/swiftlang/swift-package-manager/issues/5823


Fix apc_add, apc_store key exception

resolves an issue when apc_store or apc_add is called and $key is supplied an array and $var is null as expected.
$var is not used when $key is supplied as an array only check string type of key

Released 2.0.6 and 1.10.2


chore: bdd-sbhg-1584168172 to 0.0.1

chore: Promote bdd-sbhg-1584168172 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Get data from backend.ai api server

not implemented

after logged in, when I send code session to server, server response nauthorized 401 error

group name wasn't "default" and the api connection was headed to cloud server. fixed.

cuz fixed, this issue will be closed


techmap-ing module with underspecified input port connections creates new undriven signal

Steps to reproduce the issue
read_verilog <<EOT
module sub(input i, output o, input j);
foobar f(i, o, j);
endmodule
EOT
design -stash techmap

read_verilog <<EOT
(* blackbox *)
module sub(input i, output o, input j);
endmodule

(* blackbox *)
module foobar(input i, output o, input j);
endmodule

module top(input i, output o);
sub s0(i, o);
endmodule
EOT

### techmap -map %techmap
hierarchy -check
check -assert

Remove ### to error out on check -assert
Expected behavior
Identical behaviour as with techmap commented out -- no error.
Actual behavior
5. Executing CHECK pass (checking for obvious problems).
checking module top..
Warning: Wire top.\s0.j is used but has no driver.
found and reported 1 problems.

where resulting netlist is:
module \top
  attribute \src "<<EOT:9"
  wire input 1 \i
  attribute \src "<<EOT:9"
  wire output 2 \o
  attribute \src "<<EOT:10|<<EOT:1"
  wire \s0.i
  attribute \src "<<EOT:10|<<EOT:1"
  wire \s0.j
  attribute \src "<<EOT:10|<<EOT:1"
  wire \s0.o
  attribute \module_not_derived 1
  attribute \src "<<EOT:10|<<EOT:2"
  cell \foobar \s0.f
    connect \i \i
    connect \j \s0.j
    connect \o \o
  end
end

All I want to do is to swap a cell's type, preserving everything else...

A fix could be as simple as clearing out any port connections that do not exist on the original cell:
                        for (auto &it2 : c->connections_) {
-                               apply_prefix(cell->name, it2.second, module);
-                               port_signal_map.apply(it2.second);
+                               if (cell->connections_.count(it2.first)) {
+                                       apply_prefix(cell->name, it2.second, module);
+                                       port_signal_map.apply(it2.second);
+                               }
+                               else
+                                       it2.second = SigSpec();

which fixes the above test case.
Question is -- is this the right/better thing to do?

A fix could be as simple as clearing out any port connections that do not exist on the original cell:
...

That doesn't look correct. Consider this test case:
read_verilog <<EOT
module sub(input a, input b, output c);
subsub s1(.b(a), .y(c));
endmodule

module subsub(input b, output y);
assign y = b;
endmodule

module top(input i, output o);
sub s0(.a(i), .c(o));
endmodule
EOT

prep -flatten -top top
opt_clean -purge
dump

Obviously this should produce a result that has o = i, which it does with Yosys master, but with your patch o and i end up not connected.

All I want to do is to swap a cell's type, preserving everything else...

Jfyi, the chtype command does that without the overhead of techmap.

Jfyi, the chtype command does that without the overhead of techmap.

That's just the boiled down motivation, and all you get when you insist on MVCEs! The original techmap pass where this is from does more.

Before I invest more time into the solution, is this (blanking out connections) the right thing to do? We discussed how hierarchy was supposed to fill in those ports to begin with, such that my original test case (without techmap) would also fail check -assert which would void this issue.

I think #1384 fixes this issue. The following change is required in the test script:
module sub(input i, output o, (* techmap_autopurge *) input j);
foobar f(i, o, j);
endmodule


test_cshape fails

Should this test not fail?
#[test]
fn test_cshape(){
        let bytes: [u8; 25] = [
            0 , 99, 99, 99 , 0 , //
            0 , 99, 0 , 89 , 0 , //
            0 , 0 , 0 , 99 , 0 , //
            0 , 99, 0 , 99 , 0 , //
            0 , 99, 99, 99 , 0 , //
        ];
        let buffer = image::GrayImage::from_raw(5,5, bytes.to_vec()).unwrap();
        let image = Image8::new(buffer, 20);  // Image8 is identical to the example
        let blobs =  lutz::<_, Vec<_>>(image);
        let blobs = Vec::from_iter(blobs);
        assert_eq!(1, blobs.len());
}

Beautiful library I would really like continue using.

Sorry, I somehow entirely missed this issue back in May. Yeah, I agree, from a quick look this test should pass. Would you try and send a fix PR?

Looks like the final row is not being ended correctly, if I add another row with all zeroes, then test passes as expected.

Ok I think I fixed it. Hopefully without breaking something else in the process 😅


What is the difference between publish and finish release?

I'm submitting a ...

[ ] bug report
[x] feature request
[ ] puppy => You're not submitting a puppy. I already have one and he's adorable

What is the current behavior?
Unclear what these options do.

Is this a bug? Sorry about that. If so give me explicit details how to reproduce:
This is not a bug

What is the expected behavior?
Clear what these options do.

What is the motivation / use case for changing the behavior?
Users know what these options do

I checked the linked documents on Git Flow but don't see anything mentioned about the difference between publishing and finishing a release. Perhaps a small note in the readme will be useful.

This is more a question on how to use git flow rather than how to use this plugin.
Please see this link:
https://jeffkreeftmeijer.com/git-flow/
In short "finish release" merges the release to both master and develop while "publish release" pushes the local release branch to be available on the remote repo.

@OpherV
how about feature ?
publish vs finish in feature


fix kubecontroller flake in XDS tests

For the kube Controller there is a race between Services being loaded and Endpoints being built. This was causing test flakes, fixes https://github.com/istio/istio/issues/25863.
$ go test -run TestMeshNetworking -count=20 -race
...
PASS
ok      istio.io/istio/pilot/pkg/xds    11.519s

$ go test -run TestMeshNetworking -count=100
...
PASS
ok      istio.io/istio/pilot/pkg/xds    16.917s

This PR is a workaround that waits for the related service before force-syncing the endpoint. Should we look into handling this elsewhere by retrying the endpoint event or attempting to wait for the service? Maybe just on controller init?
https://github.com/istio/istio/blob/78fa9a988acdda70785b0dd5b1ea1b30cb89e1bc/pilot/pkg/serviceregistry/kube/controller/endpointcontroller.go#L96
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2d97d42144fe2315ee302afdeb4705860569f438
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio

@stevenctl: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
2d97d42144fe2315ee302afdeb4705860569f438
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
2d97d42144fe2315ee302afdeb4705860569f438
link
/test unit-tests_istio

integ-security-k8s-tests_istio
a46fd0dff7711c46f9b08e36500a09d7d0cc61a8
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio


Fix Graphs & Configure Infrastructure

Work towards: https://github.com/opendatahub-io/odh-dashboard/issues/1022
Description

Added the Runtime Metrics page & reworked the Inference Metrics page. Added a stacked line chart.
----Queries do not represent data right now----
Global - Inference Metrics

Project - Metrics kebab item added to Runtime:

Project - Runtime Metrics

Project - Inference Metrics

Scale options

Stacked Line Chart (random data):

Things that still need to be done (post this PR):

[ ] ~Improve x-axis to have more desired and static number of items (disable the auto x-axis from Victory)~
[ ] Improve tooltips -- stacked charts should have one tooltip & it should be styled with the x-axis in the tooltip
[ ] Get queries from @VedantMahabaleshwarkar and add them to the utilities

How Has This Been Tested?

KFDef
apiVersion: kfdef.apps.kubeflow.org/v1
kind: KfDef
metadata:
  name: odh-with-modelmesh
  namespace: opendatahub
spec:
  applications:
    # Base -- NB Images, Manifest, NB Controller
    - kustomizeConfig:
        repoRef:
          name: manifests
          path: odh-common
      name: odh-common
    - kustomizeConfig:
        overlays:
          - additional
        repoRef:
          name: manifests
          path: notebook-images
      name: notebook-images
    - kustomizeConfig:
        repoRef:
          name: manifests
          path: odh-notebook-controller
      name: odh-notebook-controller
    # Model Mesh
    - kustomizeConfig:
        overlays:
          - odh-model-controller
        parameters:
          - name: monitoring-namespace
            value: opendatahub
        repoRef:
          name: manifests-modelmesh
          path: manifests/opendatahub
      name: model-mesh
    - kustomizeConfig:
        parameters:
          - name: deployment-namespace
            value: opendatahub
        repoRef:
          name: manifests
          path: modelmesh-monitoring
      name: modelmesh-monitoring
    - kustomizeConfig:
        repoRef:
          name: manifests
          path: prometheus/cluster
      name: prometheus-cluster
    - kustomizeConfig:
        repoRef:
          name: manifests
          path: prometheus/operator
      name: prometheus-operator
  repos:
    - name: manifests
      uri: https://github.com/opendatahub-io/odh-manifests/tarball/master
    - name: manifests-modelmesh
      uri: https://github.com/opendatahub-io/modelmesh-serving/tarball/main

Dashboard steps

Create a project
Create a runtime
Create a model (DM me if you need one, mino used to work, might be able to try that - slack link for setup steps)
Fire requests off to the model's route

Test Impact

At this time, no tests are being done. Will need to look at what we can really test here -- it's all dependant on graph values -- and testing the graphs themselves is more like testing Victory. Not sure we have a Storybook test. Might have unit tests, I'll look to see if any utilities could benefit from it.
Request review criteria:

[x] The commits have meaningful messages (squashes happen on merge by the bot).
[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work
[x] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

A couple small things...
(1) Are the number of requests really (x100)? In other words are the y-axis values the number of requests you're seeing divided by 100? Jeff thought these numbers could be really large and make the y-axis labels look funny so he suggested dividing the number by 100 and adding the "(x100)" to the chart title. But if it's easier to just show the actual number of requests and let Victory handle the y-axis labels, then let's do that.
(2) I see now my mockups aren't consistent (or correct) wrt to breadcrumbs and page titles. Sorry. I think what you've got for the model metric charts looks good, assuming "Sample" is the name of the model. But for the model server metrics  the breadcrumb should be "Data science projects > Andrew's test > ovms metrics", where "ovms" is the model server type. For now it will always be "ovms", but later when we support additional server types, like Watson Core Serving, it'll be whatever the type is. (Eventually, we might end up naming servers and we'll make it the name instead of the type, but that won't be until we support KServe.) Similarly, page title should just be "ovms metrics", or whatever the server type is.

A couple small things...
(1) Are the number of requests really (x100)? In other words are the y-axis values the number of requests you're seeing divided by 100? Jeff thought these numbers could be really large and make the y-axis labels look funny so he suggested dividing the number by 100 and adding the "(x100)" to the chart title. But if it's easier to just show the actual number of requests and let Victory handle the y-axis labels, then let's do that.

Not yet -- but they will be -- I have a TODO in the code to divide them. But without real data for these things, it's hard to test.

(2) I see now my mockups aren't consistent (or correct) wrt to breadcrumbs and page titles. Sorry. I think what you've got for the model metric charts looks good, assuming "Sample" is the name of the model. But for the model server metrics the breadcrumb should be "Data science projects > Andrew's test > ovms metrics", where "ovms" is the model server type. For now it will always be "ovms", but later when we support additional server types, like Watson Core Serving, it'll be whatever the type is. (Eventually, we might end up naming servers and we'll make it the name instead of the type, but that won't be until we support KServe.) Similarly, page title should just be "ovms metrics", or whatever the server type is.

Understood, I'll look to update.

Going to merge this into the feature branch -- we can swing back to the comments pending and the right queries. I've made notes on the ticket so the conversations are not lost.
Adding labels manually so @alexcreasy can work off this refactor work.

Going to merge this into the feature branch -- we can swing back to the comments pending and the right queries. I've made notes on the ticket so the conversations are not lost.
Adding labels manually so @alexcreasy can work off this refactor work.

Going to merge this into the feature branch -- we can swing back to the comments pending and the right queries. I've made notes on the ticket so the conversations are not lost.
Adding labels manually so @alexcreasy can work off this refactor work.


chore: release main

:robot: I have created a release beep boop
autonat: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

bootstrap: 11.0.7
11.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

circuit-relay-v2: 2.1.2
2.1.2 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/peer-collections bumped from ^6.0.6 to ^6.0.7
@libp2p/peer-record bumped from ^8.0.6 to ^8.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

dcutr: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devtools-metrics: 1.1.5
1.1.5 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7

echo: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7

fetch: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7

floodsub: 10.1.5
10.1.5 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/pubsub bumped from ^10.0.6 to ^10.0.7

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5
@libp2p/peer-collections bumped from ^6.0.6 to ^6.0.7

identify: 3.0.7
3.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/peer-record bumped from ^8.0.6 to ^8.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

interface-compliance-tests: 6.1.5
6.1.5 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/peer-collections bumped from ^6.0.6 to ^6.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

interface-internal: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/peer-collections bumped from ^6.0.6 to ^6.0.7

kad-dht: 14.0.0
14.0.0 (2024-10-05)
⚠ BREAKING CHANGES

the routing ping options have been split into "old contact" and "new contact" and renamed according

Features

ping peers before adding to routing table (#2745) (661d658)

Bug Fixes

pass abort signal to stream close (32c176f)
tag kad-close peers with keepalive (#2740) (12bcd86)
track closest peers separately from main routing table (#2748) (27b2fa6)
write correct ping message (35b4802)

Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/peer-collections bumped from ^6.0.6 to ^6.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5
@libp2p/peer-store bumped from ^11.0.6 to ^11.0.7

mdns: 11.0.7
11.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

mplex: 11.0.7
11.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

peer-collections: 6.0.7
6.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/utils bumped from ^6.0.6 to ^6.1.0

peer-record: 8.0.7
8.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/utils bumped from ^6.0.6 to ^6.1.0

peer-store: 11.0.7
11.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/peer-collections bumped from ^6.0.6 to ^6.0.7
@libp2p/peer-record bumped from ^8.0.6 to ^8.0.7

perf: 4.0.7
4.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

ping: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7

plaintext: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

pnet: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

prometheus-metrics: 4.2.1
4.2.1 (2024-10-05)
Dependencies

The following workspace dependencies were updated

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

pubsub: 10.0.7
10.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/peer-collections bumped from ^6.0.6 to ^6.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

tcp: 10.0.8
10.0.8 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

tls: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

upnp-nat: 2.0.7
2.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

utils: 6.1.0
6.1.0 (2024-10-05)
Features

add maxSize to queues (#2742) (116a887)

Bug Fixes

make queue job args non-optional (#2743) (80e798c)

webrtc: 5.0.10
5.0.10 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/circuit-relay-v2 bumped from ^2.1.1 to ^2.1.2
@libp2p/identify bumped from ^3.0.6 to ^3.0.7
@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5
@libp2p/websockets bumped from ^9.0.6 to ^9.0.7
libp2p bumped from ^2.1.5 to ^2.1.6

websockets: 9.0.7
9.0.7 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5

webtransport: 5.0.10
5.0.10 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/ping bumped from ^2.0.6 to ^2.0.7
libp2p bumped from ^2.1.5 to ^2.1.6

libp2p: 2.1.6
2.1.6 (2024-10-05)
Dependencies

The following workspace dependencies were updated

dependencies

@libp2p/interface-internal bumped from ^2.0.6 to ^2.0.7
@libp2p/peer-collections bumped from ^6.0.6 to ^6.0.7
@libp2p/peer-store bumped from ^11.0.6 to ^11.0.7
@libp2p/utils bumped from ^6.0.6 to ^6.1.0

devDependencies

@libp2p/circuit-relay-v2 bumped from ^2.1.1 to ^2.1.2
@libp2p/identify bumped from ^3.0.6 to ^3.0.7
@libp2p/interface-compliance-tests bumped from ^6.1.4 to ^6.1.5
@libp2p/mplex bumped from ^11.0.6 to ^11.0.7
@libp2p/plaintext bumped from ^2.0.6 to ^2.0.7
@libp2p/tcp bumped from ^10.0.7 to ^10.0.8
@libp2p/websockets bumped from ^9.0.6 to ^9.0.7

This PR was generated with Release Please. See documentation.

:robot: Created releases:

plaintext-v2.0.7
tls-v2.0.7
interface-compliance-tests-v6.1.5
interface-internal-v2.0.7
kad-dht-v14.0.0
libp2p-v2.1.6
devtools-metrics-v1.1.5
prometheus-metrics-v4.2.1
peer-collections-v6.0.7
bootstrap-v11.0.7
mdns-v11.0.7
peer-record-v8.0.7
peer-store-v11.0.7
pnet-v2.0.7
autonat-v2.0.7
dcutr-v2.0.7
echo-v2.0.7
fetch-v2.0.7
identify-v3.0.7
perf-v4.0.7
ping-v2.0.7
pubsub-v10.0.7
floodsub-v10.1.5
mplex-v11.0.7
circuit-relay-v2-v2.1.2
tcp-v10.0.8
webrtc-v5.0.10
websockets-v9.0.7
webtransport-v5.0.10
upnp-nat-v2.0.7
utils-v6.1.0
:sunflower:


http instrumentation: url and host attributes are sometime wrong for outgoing requests with ipv6 address

this is an issue found by @Flarna  in this PR
What version of OpenTelemetry are you using?
v0.23.0
What version of Node are you using?
v12.18.3
Please provide the code you used to setup the OpenTelemetry SDK
import express from 'express';
const app = express();
app.use((_req, res) => res.sendStatus(200));
app.listen(8080, '::', () => console.log('server started on port 8080'));

import { NodeTracerProvider } from '@opentelemetry/node';
import { HttpInstrumentation } from '@opentelemetry/instrumentation-http';
import { registerInstrumentations } from '@opentelemetry/instrumentation';
import { ConsoleSpanExporter, SimpleSpanProcessor } from '@opentelemetry/tracing';
const provider = new NodeTracerProvider();
provider.addSpanProcessor( new SimpleSpanProcessor(new ConsoleSpanExporter()));
provider.register();
registerInstrumentations({
    instrumentations: [ new HttpInstrumentation() ],
});

import http from 'http';
http.get({host: '::1', port: 8080}, (res) => {
    res.on('data', () => console.log('got data'));
    res.on('end', () => console.log('res end'));
});

What did you do?
run the above code
If possible, provide a recipe for reproducing the error.
What did you expect to see?
expected attributes for outgoing http span:
"http.url": "http://[::1]:8080/" (or "http://::1:8080", not sure)
"http:host": "[::1]:8080" (or "::1:8080", not sure)
What did you see instead?
{
  traceId: 'cdd140118cdfc23da00059c291a18b7a',
  parentId: undefined,
  name: 'HTTP GET',
  id: '9aeb488a5ff193b6',
  kind: 2,
  timestamp:<PHONE_NUMBER>735352,
  duration: 29152,
  attributes: {
    'http.url': 'http://::1/',
    'http.method': 'GET',
    'http.target': '/',
    'net.peer.name': ':',
    'net.peer.ip': '::1',
    'net.peer.port': 8080,
    'http.host': '::8080',
    'http.response_content_length_uncompressed': 2,
    'http.status_code': 200,
    'http.status_text': 'OK',
    'http.flavor': '1.1',
    'net.transport': 'ip_tcp'
  },
  status: { code: 1 },
  events: []
}

As can be seen, "http.url" is missing the port part, and "http.host" is missing the "1" for "::1" host.
Additional context
This happens as the instrumentation is executing the following code on the host options, which is buggy for ipv6:
optionsParsed.host?.replace(/^(.*)(:[0-9]{1,5})/, '$1')

Thanks @Flarna  for noticing this problem

Part of the issue here is the incorrect RequestOptions parameter for the http.get() function call. The host '::1' is actually just the hostname, changing the get request to :
http.get({hostname: '::1', port: 8080}, (res) => {
  res.on('data', () => console.log('got data'));
  res.on('end', () => console.log('res end'));
});

produces the following:
{
  traceId: '0f55b9a3fd4c2d442af22bb1a07198ef',
  parentId: undefined,
  name: 'HTTP GET',
  id: '8ee9db7b50474589',
  kind: 2,
  timestamp:<PHONE_NUMBER>376919,
  duration: 25447,
  attributes: {
    'http.url': 'http://::1/',
    'http.method': 'GET',
    'http.target': '/',
    'net.peer.name': '::1',
    'net.peer.ip': '::1',
    'net.peer.port': 8080,
    'http.host': '::1:8080',
    'http.response_content_length_uncompressed': 2,
    'http.status_code': 200,
    'http.status_text': 'OK',
    'http.flavor': '1.1',
    'net.transport': 'ip_tcp'
  },
  status: { code: 1 },
  events: []
}

The "http.url" is still incorrect however "http.host" is as expected.
"http.url" does not have the port appended due to the following condition which fails for ipv6 hostnames (https://github.com/open-telemetry/opentelemetry-js/blob/be52259d736d6762f83d89682dc528c2db0ffeaa/experimental/packages/opentelemetry-instrumentation-http/src/utils.ts#L57)
  if (
    (host as string).indexOf(':') === -1 &&
    port &&
    port !== '80' &&
    port !== '443'
  ) {
    host += `:${port}`;
  }

Part of the issue here is the incorrect RequestOptions parameter for the http.get() function call. The host '::1' is actually just the hostname, changing the get request to :

I agree that it's most appropriate to be set on hostname and port. However, user can still use the above options configuration and node's http implementation will work correctly in this case, so I would expect that the instrumentation should work in this case too.
Node documentation is not so clear about it either:
host <string> A domain name or IP address of the server to issue the request to. Default: 'localhost'.
hostname <string> Alias for host. To support url.parse(), hostname will be used if both host and hostname are specified.

From the docs, I can understand that setting hostname (or domain name, or IP address) on the host options is a legitimate and supported way to configure the client.

I was going to suggest that we use the URL class to parse these attributes out but it seems like it would actually fail with that input even though node http library handles it properly:
> new URL({ host: '::1', port: 8080 })
Uncaught TypeError [ERR_INVALID_URL]: Invalid URL: [object Object]
    at new NodeError (internal/errors.js:322:7)
    at onParseError (internal/url.js:270:9)
    at new URL (internal/url.js:346:5)
    at REPL3:1:1
    at Script.runInThisContext (vm.js:134:12)
    at REPLServer.defaultEval (repl.js:566:29)
    at bound (domain.js:421:15)
    at REPLServer.runBound [as eval] (domain.js:432:12)
    at REPLServer.onLine (repl.js:909:10)
    at REPLServer.emit (events.js:412:35) {
  input: '[object Object]',
  code: 'ERR_INVALID_URL


Verify Input in Entry Editor

:tada: This issue has been resolved in version timeclicker_client-v1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update MMM-Growatt.js

received an "undefined" value for Today data. This fixed it

Hi, thanks for your contribution. Interesting that your system is behaving that way -- perhaps we have different firmware in the inverter reporting different data to the server. The data I receive from the API contains a totalData and a deviceData object, with both of them containing an 'eToday' attribute (and  both with the same value). The behaviour on your system implies you're not getting the 'totalData' object:
"devicesData": [ 				{ 					"sn":"XXXX", 					"data": { 						"totalData": { 							"eToday":"1", 							"eTotal":"4047.1", 							"mTotal":"4856.5", 							"mUnitText":"$", 							"mToday":"1.2" 						}, 						"deviceData": { 							"deviceType":"0", 							"ptoStatus":"0", 							"timeServer":"2023-06-24 05:40:41", 							"accountName":"XXXX", 							"timezone":"10", 							"plantId":"XXXX", 							"deviceTypeName":"tlx", 							"nominalPower":"5000", 							"bdcStatus":"0", 							"eToday":"1", 							"eMonth":"609.3", 							"datalogTypeTes":"", 							"eTotal":"4047.1", 							"pac":"2148.3", 							"datalogSn":"XXXX", 							"alias":"XXXX", 							"location":"", 							"deviceModel":"MIN 5000TL-X", 							"sn":"XXXX", 							"plantName":"Inverter", 							"status":"1", 							"lastUpdateTime":"2023-06-24 07:40:41" 						} 					} 				}
Happy to merge the change, given that it will work on both our systems.
Out of curiosity, what is your deviceData.deviceModel value?

Cool and thanks a lot- my first ever contribution to anything on github btw.
My deviceModel value is "SPH 10000TL3 BH-UP". I installed my system just a few days ago so it's most likely a rather new generation.

Mine is also fairly new - installed in February. The SPH model looks like it supports charging batteries whereas I don't think my MIN model does. Maybe that's a reason for the different reporting capabilities.
Anyway, welcome to github and thanks for making this project your first contribution!


Incomplete LICENSE file

Thanks for packaging into a library.
Your LICENSE file does not contain the original author and is considered non-healthy (in other words, it's violating the license agreement at present because the MIT License says The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.)
I'll create a pull request to fix this issue. Please consider merging this so I can use your library in my project. Thank you!

Thank you for bringing this up! I forgot to mention the author in the LICENSE file, only in the Readme. I merged your PR into my repository, so it should be fixed.


Can this package play a youtube video?

No,
But you can use package 'youtube_explode_dart' to get youtube video url first,
And then pass it to video_player_win


v0.2.0

Aggregate PR containing breaking changes in preparation for second "major" beta version.

@o-smirnov pinging you if you want to try this branch out. I think the stimela functionality should now be working.


Suggestions for the taxbrain/file/ page

@talumbau, I have compared aggregate 2020 revenues under current-law and a complex reform whose JSON-reform-file I uploaded to TaxBrain.  The aggregate revenue results are exactly the same on my local computer and on TaxBrain.  So, things seem to be working fine.  Thanks for adding this useful feature to TaxBrain.
But I do have a few suggestions to make the user experience better.
(1) on the file-upload page it says:
Get Started
You are looking at default parameters for 2016.

JSON Input Parameters

Tax Calculator Parameters

Select a file:

There are a number of improvement we can make here.  First, we aren't looking at any parameters.  And second, "JSON Input Parameters" might be better as something like "Reform file" with a link to the right labeled "Examples" or "More information" that goes to the taxcalc/reforms/REFORMS.md file I'm in the process of developing.  And third, I don't see what the "Tax Calculator Parameters" label adds once something like the above suggestions are implemented.  What are your thoughts on this?
(2) Then after TaxBrain does the calculations, the label above the uploaded file is this:
THE FOLLOWING PARAMETERS WERE UPLOADED FOR THIS SIMULATION:

Don't you think something like this would be better?
THE FOLLOWING REFORM FILE WAS UPLOADED FOR THIS SIMULATION:

Thoughts?
(3) When there is a syntax error in the uploaded file, it is difficult to locate the error, which is usually given in terms of line number and column number.  The line number is easy to see, but the column number is difficult because the error message is not being displayed in a fixed-width font.  Can this be changed?  I hope so, because otherwise the error message is not very helpful.
Again, the basic functionality we've been looking for seems to be there.  Thanks again for all your work on making this happen.  Just a few minor enhancements would make it much easier to use.

fixed by #365


[Installation] ISSUE NAME HERE

How to reproduce this bug:

Step one
Step two
Step three

What should happen:
What happened instead:
Browser(s) and Device(s) tested on:
Foundation Version(s) you are using:
Test case link:

CodePen with Foundation 6.3.1, Float Grid and MotionUI

CodePen with Foundation 6.3.1, Float Grid with RTL Direction and MotionUI

CodePen with Foundation 6.3.1, Flexbox grid and MotionUI

CodePen with Foundation 6.4.1, XY Flexbox grid and MotionUI

CodePen with Foundation 6.4.1, XY Flexbox grid with RTL Direction and MotionUI

CodePen with Foundation 6.4.1, XY Flexbox grid with Prototype Mode and MotionUI

CodePen with Foundation 6.4.1, Float Grid and MotionUI

Opened this on accident. Closed.


Single config object instead of separate properties

Michael hi,
After your response I took the liberty to play with the directive from scratch.
Now there is a single 'config' object for the directive, instead of separate properties and watch is on this object. If there is a change in the object, it updates disqus comments. Since 'ready-to-bind' was obsolete, that's gone now.
Directive should be initialized like this;
Html
<dir-disqus config="disqusConfig"></dir-disqus>

And in controller:
$scope.disqusConfig = {
 disqus_shortname: 'Your disqus shortname',
 disqus_identifier: 'Comments identifier',
 disqus_url: 'Comments url'
};

Additional notes:
. 'comments powered by disqus' text was removed
. Shortname, id and url are still mandatory, but if they're falsy, it just returns, instead of throwing an exception
. README.md updated accordingly (removed ready-to-bind section & didn't mention breaking changes)
. I'm using jasmine & chutzpah. Tried to update 'tests' file but couldn't make it run in my environment, so didn't touch that one. If you wish I can try to update it blindly?
. Except this 'config' part, didn't change about 'disqus' implementation. So the rest should work, but I only tested basic properties (shortname, identifier, url, onReady callback).
. Updated & uploaded my test page again, so you can quickly check how it works;
Sync: http://dev.forcrowd.org/dirDisqusFix/home?mode=sync
Async: http://dev.forcrowd.org/dirDisqusFix/home?mode=async
Route: http://dev.forcrowd.org/dirDisqusFix/home?mode=route
Hope this is enough for the moment.
Let me know if you notice any issues and of course if one of the changes is not good or not necessary or may cause any other problem.
Regards,

And of course this would be more than a breaking change but I'd consider of changing the directive's name to 'ngDisqus'? :)

Hi,
Thanks for your work on this. I like your changes - this considerably simplifies things. I think I'm going to leave the directive name as is just because it is well established. The prefix dir is not great - I chose it when all these directives were internal and I had no idea any would become widely used - but is there any particular reason to change?

Okay, good to hear, and I see that you already merged it :+1:
About name change, just wanted to mention it, not important at all, pure marketing concerns :)


feat: Self-signed certificates for REST APIs

Description
Enabled use of self-signed certificates for REST APIs. We're expected to create a datasource for all APIs that need this feature. Addition is non-intrusive to existing actions because of null check and exact value checks.
I've also updated the error handling to always go to the root of the exception since that might help us debug issues more easily. Might want to take up handling different types of errors to give more sensible messages in a separate issue.

https://user-images.githubusercontent.com/5298848/153184897-b5d78a15-3a59-4c53-b128-e826cdf00278.mov
Fixes #4608
Type of change

New feature (non-breaking change which adds functionality)
This change requires a documentation update

How Has This Been Tested?

Manually tested since we haven't mocked out client yet. Should invest in this infra soon

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/self-signed-certs-for-rest

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.01 (0)
36.35 (0.01)
34.69 (0)
55.39 (0)

:red_circle:
app/client/src/pages/Editor/DataSourceEditor/RestAPIDatasourceForm.tsx
24.66 (-0.34)
13.51 (-0.57)
2.56 (-0.14)
27.18 (-0.48)

:red_circle:
app/client/src/transformers/RestAPIDatasourceFormTransformer.ts
14.67 (-0.19)
0 (0)
0 (0)
13.43 (-0.21)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.94 (0.23)
41.67 (0.84)
36.21 (0)
56.99 (0.25)

/ok-to-test sha=bb9a33c

/ok-to-test sha=bb9a33c

/ok-to-test sha=e1e5730

/ok-to-test sha=e1e5730


CDO: 2.0.5 -> 2.2.0

Description of changes
Changelog.
Python3 is a new dependency of CDO.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 240557 run on x86_64-linux 1

1 package built:

cdo

Thank you for your submission.
I have build the package and successfully ran cdo --help and cdo --version.
I would like to suggest the following changes:

Please update the commit message to match guidelines

i.e. cdo: 2.0.5 -> 2.2.0

CDO is licensed under the 3-clause BSD License. Please update metadata field accordingly.

@clerie  is done, thank your for your response.


The user I deleted doesn't disappear from the file.

Hey, I have 3-4 users that are simply undeletable. When I delete them, save and exit, then reopen the file, they are back again. Also, is it possible to delete guilds?

save & exit will be save to _fixed.sav, you didn't rename it.
for delete guild, just delete all user on the guild, and the guild will be delete automate


Hiding the Search Bar on the Login Page

Also going to update the functional tests to account for this.

This change is

:+1:  Very nice!

Reviewed 8 of 8 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

tests/ui/login_page_test.py, line 69 [r1] (raw file):
Done.

Comments from Reviewable

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Could you please sync the etag algorithm with nginx.

https://serverfault.com/questions/690341/algorithm-behind-nginx-etag-generation
1828
1829     etag->value.len = ngx_sprintf(etag->value.data, "\"%xT-%xO\"",
1830                                   r->headers_out.last_modified_time,
1831                                   r->headers_out.content_length_n)
1832                       - etag->value.data;
1833
1834     r->headers_out.etag = etag;
1835
1836     return NGX_OK;

The goal of this module is not to mimic nginx, so there isn't any desire to do this. If you want to see it happen, can you please explain the case and perhaps even share code in some language that we can read (i.e. JavaScript)?

please see pr #23, for details. actually make the weak etag same with ng default output, in that case we can cache the first request when use nginx upstream a node server with etag.

Thanks for the pull request! I left some feedback, but I just found there is already a solution for this on npm: use the following module: https://www.npmjs.com/package/nginx-etag


Add configuration to disable consul update check

Fix https://github.com/edgexfoundry/docker-edgex-consul/issues/30
Signed-off-by: Ginny Guan<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://wiki.edgexfoundry.org/display/FA/Contributor's+Guide
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:
#30
What is the new behavior?
Disables automatic checking for Consul new version releases.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information

DCO check appears hung.  May need to amend commit and force-push in order to get this PR unstuck.

recheck


Update readme: Clarify what "the discord script" is

I have the scripts for both Discord and FetchCord in my path; however, FetchCord is not run when I start Discord. Does the readme refer to a different Discord script?

it's referring to the one in the repo, you can just replace the one you have with that one.

I +1 this, I don't know how to set this up at all from reading the readme.

This script is now removed in favor of making fetchcord a daemon and giving the user the freedom to launch it in whichever way they prefer (like on boot for example). There is a working systemd unit present in the repo which you can see the README instructions for in case you want to test it.

This script is now removed in favor of making fetchcord a daemon and giving the user the freedom to launch it in whichever way they prefer (like on boot for example). There is a working systemd unit present in the repo which you can see the README instructions for in case you want to test it.

Will check it out when I get home,  much appreciated.