ERROR  199 - Error while getting user data. Response 444.

hello
This bot was running for me when I suddenly got this error

2024-09-19 15:59:32 | ERROR    | 445 - Name | Error code 444 While trying to get completed task
Traceback (most recent call last):
  File "/home/Name/software/Cexio-Tap-bot/bot/core/tapper.py", line 642, in run
    for task in self.task:
TypeError: 'NoneType' object is not iterable
2024-09-19 15:59:32 | ERROR    | 720 - Name | Unknown error: 'NoneType' object is not iterable

Update newest version of the bot and try again

Update newest version of the bot and try again

There was an updated, but there was no problem
I deleted the bot and reinstalled it


Validation error with str Enum field and numpy's str_ type

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
I'm having this issue in the API that uses machine learning (numpy+scikit-learn+xgboost) to generate predictions. The predictions are text labels. The ML part returns predictions as numpy-specific strings of type str_.
These values trigger validation error when used in the ENUM fields in pydantic model:
animal
  Input should be 'dog' or 'cat' [type=enum, input_value='cat', input_type=str_]
    For further information visit https://errors.pydantic.dev/2.7/v/enum

Example Code
from enum import Enum
from pydantic import BaseModel, Field
import numpy as np

class Animal(Enum):

    dog = "dog"
    cat = "cat"

class ModelStr(BaseModel):
    animal: str = Field(..., description="A type of animal")

class ModelEnum(BaseModel):
    animal: Animal = Field(..., description="A type of animal")

numpy_array = np.array(["cat", "dog"])

# this works
ModelStr(animal=numpy_array[0])

# this triggers error
ModelEnum(animal=numpy_array[0])

Python, Pydantic & OS Version
pydantic version: 2.7.0
        pydantic-core version: 2.18.1
          pydantic-core build: profile=release pgo=true
                 install path: /home/max/Code/Drax/dev/role-classification/venv/lib/python3.10/site-packages/pydantic
               python version: 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0]
                     platform: Linux-5.15.0-102-generic-x86_64-with-glibc2.35
             related packages: fastapi-0.101.1 typing_extensions-4.8.0
                       commit: unknown

Can you check if this is new in V2.7?

Yes, I could not reproduce this in 2.6.4

@maxsch3,
If you inherit from str in your Animal type, all works as expected:
from enum import Enum
from pydantic import BaseModel, Field
import numpy as np

class Animal(str, Enum):

    dog = "dog"
    cat = "cat"

class ModelStr(BaseModel):
    animal: str = Field(..., description="A type of animal")

class ModelEnum(BaseModel):
    animal: Animal = Field(..., description="A type of animal")

numpy_array = np.array(["cat", "dog"])

# this works
ModelStr(animal=numpy_array[0])

# this works
ModelEnum(animal=numpy_array[0])

This workaround should work for now, but I'll add this to the 2.7 fixes milestone, as I don't think this extra specification should be required

Interesting that this still works, we must be missing a str conversion attempt somewhere:
from enum import Enum
from pydantic import BaseModel, Field

class Animal(Enum):

    dog = "dog"
    cat = "cat"

class ModelEnum(BaseModel):
    animal: Animal = Field(..., description="A type of animal")

# this works
ModelEnum(animal="cat")


Set 'Discontinued routes' to the far right

Its kinda weird to have discontinued right in the middle, when its something that should be less important


Match operations with permission objects with set operators

Correct the operator terms to match what one might expect if they were working with permission objects as an encapsulation of sets of roles.
Test cases enclosed to demonstrate how this compares to working with the sets directly.

This makes much more sense to me, is there a plan of merging this?

This seems to be ready for a merge...

I've created issue #110 and rebased this PR in #111 in hope of getting this merged. Would be nice not to have to maintain our own fork.

Merged folks, thanks @mg-christian-axelsson
If anybody wants to actively contribute, join the Pallets Discord and ping me at appinv


Oracle primary key size based on version

Search first

[X] I searched and no similar issues were found

Description
The OracleDatabase::generatePrimaryKeyName method is always truncating the auto generated primary key name to 30 characters.
It should instead make use of the OracleDatabase::getIdentifierMaximumLength method to get the right lenght for the identifier, something like this:
@Override
public String generatePrimaryKeyName(String tableName) {
	int maximumLength = getIdentifierMaximumLength();
	String primaryKeyName = "PK_" + tableName.toUpperCase(Locale.US);
	if (primaryKeyName.length() > maximumLength) {
		return primaryKeyName.substring(0, maximumLength);
	} else {
		return primaryKeyName;
	}
}

Would it be ok if I raise a PR to address this?
Steps To Reproduce
To reproduce this, you can run liquibase against an Oracle version grater than 12, with a long enough databaseChangeLogLockTableName, something longer than 30 characters.
The primary key name will be truncated to 30 characters.
Expected/Desired Behavior
Having Oracle version grater than 12 and a long enough databaseChangeLogLockTableName, the primary key name should be truncated to 128 characters.
Liquibase Version
No response
Database Vendor & Version
Oracle version grater than 12
Liquibase Integration
No response
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
No response
Additional Context
No response
Are you willing to submit a PR?

[X] I'm willing to submit a PR (Thank you!)

Hi @tati-qalified
Thank you for the feedback, actually this is kind of strange.
Anyway I can replicate the scenario using liquibase 4.25.1
Thanks,
Matteo.

Would you be able to share your changelog file, or at least a snippet of it?  Thanks.

Actually it is not a matter of changelog; this happens whenever I run liquibase update with a custom, long enough databaseChangeLogLockTableName (let's say something like SOME_TABLE_WITH_NAME_LONGER_THAN_30_CHARACTERS).
In this scenario, instead of generating the table with a PK constraint with name PK_SOME_TABLE_WITH_NAME_LONGER_THAN_30_CHARACTERS, liquibase generate the table with the given name, while the constraint name will be PK_SOME_TABLE_WITH_NAME_LONGER.

My bad, I hadn't read the part about the auto-generated PK names. I was testing with manually created names.
I can confirm that all auto-generated PK names are truncated at 30 characters, both for 4.25.1 and for 4.29.0


argo workflow , dapr-sidecar-injector include "service account  system:serviceaccount:argo:argo not on the list of allowed controller accounts"

/area runtime
/area runtime
What version of Dapr?
v1.10.4
Expected Behavior
Sidecar should be created.
Actual Behavior
Sidecar not created, and dapr-sidecar-injector pod say  "service account 'system:serviceaccount:argo:argo' not on the list of allowed controller accounts"
Ask your question here
i need help!!!!!
I encountered a problem with Kubernetes. I added an annotation to start Dapr in a pod launched by an Argo Workflow.
apiVersion: v1
kind: Pod
metadata:
  annotations:
    dapr.io/app-id: watermelon
    dapr.io/enabled: "true"
    dapr.io/log-level: error

the Argo Workflow runs in the argo namespace, serviceaccount is argo
the dapr-sidecar-injector runs in the dapr namespace, serviceaccount is dapr-injector
but the sidecar not created, and dapr-sidecar-injector pod say:
time="2023-03-23T12:52:57.123117756Z" level=error msg="Admission succeeded, but pod was not patched. No sidecar injected for 'watermelon'" instance=dapr-sidecar-injector-775f9c476c-sddgw scope=dapr.injector type=log ver=1.10.4
time="2023-03-23T12:53:07.164119156Z" level=error msg="service account 'system:serviceaccount:argo:argo' not on the list of allowed controller accounts" instance=dapr-sidecar-injector-775f9c476c-sddgw scope=dapr.injector type=log ver=1.10.4

I followed some troubleshooting steps,  create clusterrolebinding and rolebinding
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: dapr-injector
subjects:
- kind: ServiceAccount
  name: argo
  namespace: argo

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: ClusterRole
  name: dapr-injector
subjects:
- kind: ServiceAccount
  name: argo
  namespace: argo

You can enable the service accounts you want the injector to trust: https://github.com/dapr/dapr/tree/release-1.10/charts/dapr#dapr-sidecar-injector-options.
Look a dapr_sidecar_injector.allowedServiceAccounts.

You can enable the service accounts you want the injector to trust: https://github.com/dapr/dapr/tree/release-1.10/charts/dapr#dapr-sidecar-injector-options.
Look a dapr_sidecar_injector.allowedServiceAccounts.

Thank you for your help. With the addition of the Dapr injector options configuration, I was able to start daprd in the pod of my Argo Workflow.
dapr init --set "dapr_sidecar_injector.allowedServiceAccounts=argo:argo" -k --enable-mtls=false -n dapr --wait


Attachment upload

Checklist

[x] mage test passes
[x] unit tests are included and tested
[x] documentation is added or changed

Documentation is auto generated from comments, so I assume that is fulfilled. I needed the ability to upload attachments to a page. Since it uses the special multipart/form-data it needed a whole new function built out. Unit tests added and has been integration tested independently. Works as expected where you can feed it a io reader with whatever data you want. I've tried strings and png files personally.

Looks like the automated build tries to do something with the examples. Those looks to be pretty out of date, should not of been affected by anything I did. I'm not sure how the previous build was passing.

@cseeger-epages Hello?

@supernova2468 sorry for the long delay ill review it

LGTM. Thanks for your great contribution!


feat(launcher): add information about which user launched a study

The front-end part of the issue hasn't been coded yet.
But it can still be merged as it should be use as a basis to solve another issue : https://github.com/AntaresSimulatorTeam/AntaREST/issues/1732

From what I've tested, the alembic script works for Sqlite and for a postgreSQL DB inside a docker container.

See Alembic migration documentation


Deactivate or shutdown a bot on error?

I'm currently running Botkit for Facebook, and host multiple bots on through a single instance. Yesterday, one of the clients we had our bot hooked up to revoked the page token access, so we were getting an error of an OAuth Exception from Facebook. However, this affected all of our other bots running on that instance and causing them to non-responsive.
Is there a way to pragmatically or manually shut down a bot, OR to have that single bot ignored per page_id?

Hello, how you host multiple bots on through a single instance ?
Can you share some codes ?

@kniteshift ^?

I will create a dummy repository.

@peterswimm @ouadie-lahdioui
https://github.com/kniteshift/multitenancy-botkit-demo
Sorry this is a slimmed down version but I can do my best to answer any questions if you have it.

You can surround each bot spcific code with a try-catch bloc to catch all errors and react on that, in this case your main node thread will not stoped.
You can also start a new node child process for each bot to not impact your main thread if a child stoped.


GEODE-3436: Restore reverted GFSH command refactoring

Given that this would restore multiple tickets worth of commits, it was unclear if this PR should squash all commits or if the history would be clearer without one enormous commit.
Precheckin returned green excepting spotless and some other minor adjustments (import ordering correction, etc).  Running another precheckin for due course.

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[n/a] Have you written or updated unit tests to verify your changes? [Existing tests provide coverage for refactored code.]

[n/a] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Precheckin fully green.


Performance and Rust idiomatic improvements

Removed bitvec dependency, wrote a quick BitWriter struct that allows pushing 11 bits onto a Vec<u8> at once.
 This results in some (not all) functions that used to take generic S: Into<String> to take &str, which is more idiomatic although it is a breaking change on the API surface. Functions that need allocated strings (constructors that return owned structs mostly) remained unaffected.
wordlist and wordmap work using &'static str instead of Strings to avoid unnecessary allocations (not very critical).
Replaced Result<T, Error> with custom Result<T> from error_chain.
Bunch of smaller idiomatic changes that I likely can't recall here.
Added benchmarks (rustup run nightly cargo bench). Phrase validation time has been cut to nearly a quarter of original time.

Closing this in favor of another, more extensive PR.


Problems with adding new Homematic IP actors

Hey Guys,
I'm using a Raspi 4B with pivccu3 and HM-MOD-RPI-PCB. Installation seems to work fine. I get following output:
pi@raspberrypi:~ $ sudo pivccu-info piVCCU version: 3.57.5-57 Kernel modules: Available Raw UART dev:   Available Rasp.Pi UART:   Assigned to GPIO pins HMRF Hardware:  HM-MOD-RPI-PCB  Connected via: GPIO (/dev/raw-uart)  Board serial:  OEQ0310424  Radio MAC:     0x584B55 HMIP Hardware:  HM-MOD-RPI-PCB  SGTIN:         3014F711A061A7D7098E2498  Radio MAC:     0xB03ACB State:          RUNNING PID:            945 IP:             <IP_ADDRESS> CPU use:        15.06 seconds BlkIO use:      62.37 MiB Link:           vethpivccu  TX bytes:      17.61 KiB  RX bytes:      35.16 KiB  Total bytes:   52.77 KiB
But I can't add Homematic actors. The actors and HM-MOD-RPI-PCB was already working with Raspi 3B. The actors was many times resetet. What could be the problem?
Thanks a lot!

The Raspi 4B produces a lot of interference at 868MHz, which affects especially HmIP with its Listen-Before-Talk.
You need at least 50cm distance between the HM-MOD-RPI-PCB and the Raspi.

I‘m understandig. But how could I resolve it?

As said, you need at least 50cm distance between the HM-MOD-RPI-PCB and the Raspi, e.g. using GPIO ribbon cable or using a HB-RF-USB-2 pcb.


Translation

Very nice application, I would love to see it translated into my language (French).
Could you set up a translation system like Weblate or something else, I would be happy to participate...

I could try, but you can also do pull requests with the modified translation file.

Nice, I will work on it. Thanks

In the next update that will be today-tomorrow there will be your translation.

Thanks a lot :+1:


Cannot scroll when new element is added in drawer

In the drawer there is a form, but if the booking code is not valid a new element is added making the submit button pushed below the usable viewport
Anything I'm doing wrong here? The correct solution would be that the drawer will auto calculate the height of new element is added?
https://github.com/emilkowalski/vaul/assets/34785917/ed965b5a-3b24-4006-b3e5-95d338bf19fc

same issue here, was able to fix it by making inner content scrollable but it's not usable for input at all and package hasn't been updated for months

@pandas9 but making the inner content scrollable seems a bad UX 😢

+1 Also seeing this issue. I have added an inner content scroll for now. Tried adjusting the height property set on the root overlay but doesnt seem to make a difference.

I have the same issue.
I use form input, when the error messages are displayed, it pushes everything down.
is there a fix without scrolling?
thanks.

I have the same issue.
I use form input, when the error messages are displayed, it pushes everything down.
is there a fix without scrolling?
thanks.

same issue here

I had a different but similar issue, the elements in the drawer are dynamic coming form an array of items that render buttons. When I use the drawer once, it works as expected, a second time none of the buttons are clickable, some confusing inspecting, it seems that the clickable area the content of the drawer before the dynamic elements came in.
This only happens on iOS, Safari, including the iOS simulator but not on desktop or Chrome desktop.


Add Database Seeds

This will help with testing and also can be useful for first time setup for users

I've created factories now for testing. Added a few unit tests as well. I'll be doing TDD from now on. Should have done it in the first place. There's a working seeder for the administrator.


Allow Location Service Status Bar (Blue Bar) for "Always Allow"

I'd like the ability to allow the blue bar to appear when the app is in the background even if "Always Allow" is selected.
Your Environment

Plugin version: 2.3.3
Platform: iOS
OS version: 11.3
Device manufacturer and model: Apple, iPhone 7
Cordova version: 8.0.0
Cordova platform version: ios 4.5.2
Plugin configuration options:
<variable name="GOOGLE_PLAY_SERVICES_VERSION" value="11+" />
 <variable name="ANDROID_SUPPORT_LIBRARY_VERSION" value="23+" />
 <variable name="ICON" value="@mipmap/icon" />
 <variable name="SMALL_ICON" value="@mipmap/icon" />
 <variable name="ACCOUNT_NAME" value="@string/app_name" />
 <variable name="ACCOUNT_LABEL" value="@string/app_name" />
 <variable name="ACCOUNT_TYPE" value="$PACKAGE_NAME.account" />
 <variable name="CONTENT_AUTHORITY" value="$PACKAGE_NAME" />
 <variable name="LOCATION_WHEN_IN_USE_USAGE_DESCRIPTION" value="Required for tracking distance traveled during workouts." />

Context

I'm developing a workout tracker app. It's important that the blue bar for iOS show when the app is in the background so that it's easy to identify that the app is still running. This works fine when the permissions are set to "Only When in Use", but when set to "Always Allow" there is no blue bar.
Expected Behavior

Blue bar needs to show.
Actual Behavior

The app continues to record locations properly, but there's no indication that the app is still running.
Possible Fix

I've read in Apple's developer library that this bar can be shown by setting the showsBackgroundLocationIndicator property to "Yes". I'm not exactly sure where to insert this in the code to make this happen. Can you offer some guidance for this issue please?

Do you know where I might be able to add in a temporary fix to this issue until this is implemented as an official enhancement in your plugin? We're hoping to launch our app later this month, and I'm worried this issue may confuse some of our iOS users.


Latest key addition didn't include updating included keyring release-keys/gpg/pubring.kbx

Error excerpt from Dockerfile performing signature validation:
Step 11/23 : RUN gpgv --keyring nodejs-release-keys/gpg/pubring.kbx SHASUMS256.txt.sig SHASUMS256.txt &&     /usr/bin/sha256sum -c --ignore-missing SHASUMS256.txt &&     mkdir ./nodejs && tar -xvf node-v16.18.0-linux-x64.tar.gz -C ./nodejs
 ---> Running in 378ab3472bc1
gpgv: Signature made Wed Oct 12 14:48:44 2022 UTC
gpgv:                using RSA key 61FC681DFB92A079F1685E77973F295594EC4689
gpgv: Can't check signature: No public key

https://github.com/nodejs/release-keys/pull/15 didn't include an update to the keyring release-keys/gpg/pubring.kbx and so anyone relying on that to perform a gpgv check won't work for release 16.18.0.
Would someone please update the public keyring with Juan's key?

cc @juanarbol

Bump on this. Any way to push this @juanarbol ?

Looks like #20 took care of this, confirmed that our CI validation now succeeds


[server], [controller], [router] Make advertised addresses configurable (K8S support)

Summary, imperative, start upper case, don't end with a period
Allow to configure Router, Controller and Server hostnames. In K8S you don't want to use InetAddress.getLocalhost().getHostname() as it doesn't return the FQDN. This change makes the addresses configurable, this way the infrastructure (K8S/Helm) can inject the values
The core of the change is about changing the signature of this method:
 public static String getHelixNodeIdentifier(int port) {
to:
 public static String getHelixNodeIdentifier(String hostname, int port) {
How was this PR tested?
Current tests should pass.
I have added a small additional case in the Utils tests.
Many tests have been changed in order to explicitly pass the hostname to getNodeIdentifier
Does this PR introduce any user-facing changes?
The default behaviour is preserved.
Now users can configure admin.hostname and listener.hostname in order to customize the hostname advertised on Helix for the Router, the Server and the Controller.

I confirm that with this patch I am able to successfully run Venice on K8S


Still failed to install extensions on linux behind proxy after half one year

I confirm my http_proxy / https_proxy settings works for system and other application but VSCODE on linux.
About half one year ago, I upgrade VSCODE on linux in our company using proxy, and then it failed to install/upgrade extensions.  So I checked issuse list and wait for fixing in next release, after and after, again and again.
Untill now, IT STILL NOT WORKS!
AND I SEE THERE ARE MANY MANY PROXY ISSUES CLOSED BUT NOT FIXED ACTUALLY!

@keelung-yang What proxy settings do you have in Chromium?

@chrmarti I'm using KDE Neon, and Chromium is not installed. And no any proxy setting in VSCode.
My proxy settings is a shell script in /etc/profile.d/
export http_proxy=http://user:psw@host:port
export https_proxy=$http_proxy
export ftp_proxy=$http_proxy
export rsync_proxy=$http_proxy
export all_proxy=$http_proxy
export no_proxy="localhost,<IP_ADDRESS>,OUR_LOCAL_HOSTS"

and "Defaults env_keep += "http_proxy https_proxy ftp_proxy rsync_proxy no_proxy" aslo in /etc/sudoers.d/proxy
It works until I upgrade vscode about half one year ago.

@keelung-yang Try starting VS Code with: code --proxy-server= http://user:psw@host:port

Still not work, @chrmarti

@keelung-yang Make sure you don't have a space after = (like my above comment had before I fixed it). It definitely shouldn't open a file with the proxy as its name.

@chrisbenti Thanks. But I tried again after removing space but still not work.
The things make me crazy: Just an error reported, which is too general, but no more details about cause, like error code  and so on. SO I don't kown what's wrong and no place to dig it since other application & system tools work.

I'm using ubuntu and working behind a proxy. I have to put the proxy authentication every time I open vs code , which is really annoying, but I can install extensions. I don't know whats causing you this problem. You do have internet connection on your terminal, right?

@Koushikphy Yeap, The wget, curl,  apt-get work well without setting proxy for each.

@keelung-yang You may try reinstall or VM to zero in on the issue because mine works fine after passing proxy parameters.

@tejasvi I have reinstalled VirtualBox & Ubuntu 18.04.2, it's still doesn't work.
Now, The more important things is showing proxy error in details. It's better than just say

We cannot connect to The Marketplace at this time, Please try again later

-- THIS IS TOO GENENRIC TO INDENTIFY ERROR.
-- THIS IS AN TIP ISSUSE MORE THAN NETWORK PROXY ISSUSE.
My Environment:

Windows 10.0.17134.590
VitualBox 5.2.26
Ubuntu 18.04.2

I have the exact same problem on Ubuntu 16.04:

I'm tried setting the proxy both in the VS Code Settings dialog as shown below:

and also on the command line, by launching using:
$ code --proxy-server=http://<IP_ADDRESS>:3128/

Nothing seems to work.

Does it work with Chromium? (code --proxy-server=http://<IP_ADDRESS>:3128/ should work. Maybe the certificates are an issue.)


Sharing static files with default index.html in subpath

Often websites url calling directories, the webserver does use the standard index.html automatically.
This is implemented for the root directory with commit c92f8d1b8d6728f3fa8f4007cc9989d6cdc7fb8c but it does not work for subdirectories.
I suggest this code change to achieve index.html is used for subdirectories when no file is called.
let url = URL(string: r.path)!
if let file = try? (directoryPath + String.pathSeparator + fileRelativePath.value + (url.hasDirectoryPath ? String.pathSeparator + "index.html" : "") ).openForReading() {

in exchange for
if let file = try? (directoryPath + String.pathSeparator + fileRelativePath.value ).openForReading() {

in Swifter source file Files.swift
It worked in my tests.
Attention: the url function .hasDirectoryPath is available since iOS 9.

It work!!! thanks！

Probably best to add mime type support as well, currently I think swifter only supports serving html and text so all  and  tags won't do what you think

Please, could you post some example code to access index.html file on a root subfolder, because I can access the index.html file that's directly located at root level:
let server = HttpServer()
let documentsUrl = FileManager.default.urls(for: .documentDirectory, in: .userDomainMask)[0]
let indexFile = "index.html"
let htmlTmp = documentsUrl.appendingPathComponent("root")
server["/:path"] = shareFilesFromDirectory(htmlTmp.path, defaults: [indexFile])
try! server.start(9990)
let myRequest = URLRequest(url: URL(string: "http://<IP_ADDRESS>:9990/")!)
webview.load(myRequest)

But can't access if index.html file is on a, for example, root/base/index.html.

yes but can you <link> to a stylesheet or add <script> from local js file from that index.html?

Yes, I think I could do that.

Oh yeah, my bad, I see this is now fixed. When, I wonder.


Carbon v10.25.0 style bug: checkbox

Detailed description
It seems that some of our expressive components are having positioning and spacing issues after applying Carbon v10.25.0. The problems are seen here:
https://percy.io/538fc19a/Carbon-Expressive-Theme/builds/7956640
For the checkbox component seen here:

The label needs to be higher per the design specs

Seems to have been caused by carbon-design-system/carbon#7373, and seems intentional.

Fix must be made in the Expressive Theme


Server Crash on 2.14c

Crash log attached - https://pastebin.com/nxzuXr0w

Upgraded server from 2.13e. Also failed with the original 2.14.
This was added manually to the FTB Rev 2 pack 2.7.0. No other custom mods.

I could not recreate this - I dowloaded FTB Rev, unlocked the profile, added v2.14c and the game loaded fine, as expected really. The server also loaded correctly and I was able to connect. That looks like a very bizarre crash that really shouldn't happen, so something funny's happened somewhere that is beyond my control. Unfortunately I really don't know what would have caused this :\


How to get frames of video according to time as pictures(jpg) ?

thanks

"What can't you do?
Create JPEGs from a movie. No - this is no decoder. The MP4 Parser doesn't know how to do that. Create a movie from JPEGs"
I bet you're trolling right?


🐛 [firebase_ui_auth] "Magic Link" AuthStateChangeAction not being fired

Bug report
Describe the bug
Official example at firebase/flutterfire/packages/firebase_ui_auth/example/main.dart does not work: clicking the link in iPhone 14 Simulator "Safari" application accessing Gmail shows error message, and the callback AuthStateChangeAction not being fired
I am using updated "master" branch today, with all recent changes, but I initially noticed this issue weeks ago. Finally resolved by "workaround" (see below).
Steps to reproduce
Steps to reproduce the behavior:

Go to firebase/flutterfire/packages/firebase_ui_auth/example/main.dart
add debug line 252 `print("successfully signed in");(see screenshot)
run with iPhone 14 Pro iOS 16.2 simulator
try to use "Sign in with magic link"
Open "Safari", access GMail, click the link (see screenshot)
Redirect error message in Safari (see screenshot)

Expected behavior

After clicking Email "magic link" from the mobile device, Example application should automatically open and redirect to  "/" route
AuthStateChangeAction being fired
Android Studio console should show debug message "successfully signed in"

Sample project
Official firebase/flutterfire/packages/firebase_ui_auth/example/main.dart with one-line debug message change (see attached)

Additional context
Note that I was able to fix this issue by workaround:
 FirebaseAuth.instance.authStateChanges().listen((user) {    if (FirebaseAuth.instance.currentUser != null) {       Get.offAllNamed(HomeScreen.routeName);     }   });

and it works just perfect: clicking link from Safari's "GMail" will automatically open my application's "Home" screen.

Note also that example application will be already authenticated, but to find this you need to explicitly close it and open again.
Please provide also step-by-step guide on how to configure IOS and Android to make it work: 	<key>FirebaseDeepLinkPasteboardRetrievalEnabled</key> and etc.; it is not documented at all with the example application, including necessary Firebase "dynamic links", App Store, and other settings. README.md has only 17 lines but we need detailed step-by-step guide.
Thank you!

the problem is that the UniversalScaffold in email_link_sign_in_screen.dart from the library is not wrapped in a FirebaseUIActions Widget like in the other sign-in screens.


Fix do_refer_friend() in zerver/lib/actions.py

It would be great if declaration of variable content is styled properly. Presently, it looks like this.
def do_refer_friend(user_profile, email):
    # type: (UserProfile, text_type) -> None
    content = """Referrer: "%s" <%s>
Realm: %s
Referred: %s""" % (user_profile.full_name, user_profile.email, user_profile.realm.domain, email)
    subject = "Zulip referral: %s" % (email,)
    from_email = '"%s" <%s>' % (user_profile.full_name<EMAIL_ADDRESS>    to_email = '"Zulip Referrals"<EMAIL_ADDRESS>

@timabbott, @krtkmj Does the PR #1169 Make sense ?

@kritkaran94 I was talking about variable content. Other variable header and msg looks okay and doesn't need any change.

@krtkmj any suggestions as to how u feel it can be improved ?

I guess it would be more readable this way.
def do_refer_friend(user_profile, email):
    # type: (UserProfile, text_type) -> None
    content = """Referrer: "%s" <%s>
                 Realm: %s
                 Referred: %s""" % (user_profile.full_name, user_profile.email,
                     user_profile.realm.domain, email)

@timabbott

Ya It looks good this way.


Added Queso Geyser stage separation

Stages:

Cork Collecting
Pressure Building
Tiny Eruption
Small Eruption
Medium Eruption
Large Eruption
Epic Eruption

The stage names are a simple truncation of the mouse group names, which are Cork Collector and Pressure Builder. I'll ask around on Discord to get an idea for what users would prefer - Cork / Pressure or Collecting / Corked or even Uncorked / Corked. Regardless, if a stage name turns out to be unpopular later on it can always be adjusted.

Re: nest claim logic, I think it would be best to handle that in a separate recordNestLoot function, similar to recordConvertible, except have it check for a request to managers/ajax/environment/queso_geyser.php instead.
Here's a sample JSON response from a Small Eruption in which I armed Mild Queso all the way.
"queso_geyser_nest_loot": {
    "mice": [
      {
        "name": "Sizzle Pup",
        "display_order": 21,
        "large": "https://www.mousehuntgame.com/images/mice/large/b104d385f0830d2c2fd98fb28cf027b9.jpg?cv=240",
        "mouse_id": 978,
        "items": [
          {
            "type": "rubber_crafting_item",
            "quantity": 17,
            "is_jackpot": null,
            "is_wildtonic": null
          },
          {
            "type": "amber_queso_stat_item",
            "quantity": 3,
            "is_jackpot": null,
            "is_wildtonic": null
          }
        ],
        "wild_tonic_items": [],
        "type": "geyser_eruption_dragon_small",
        "has_jackpot": true,
        "merged_items": [
          {
            "type": "rubber_crafting_item",
            "quantity": 17,
            "is_jackpot": null,
            "is_wildtonic": null,
            "name": "Congealed Rubber",
            "thumb": "https://www.mousehuntgame.com/images/items/crafting_items/thumbnails/88fb12e07d6d63e738241bc9a531700b.gif?cv=240",
            "quantity_formatted": 17,
            "quantity_abbreviated": 17
          },
          {
            "type": "amber_queso_stat_item",
            "quantity": 3,
            "is_jackpot": null,
            "is_wildtonic": null,
            "name": "Solidified Amber Queso",
            "thumb": "https://www.mousehuntgame.com/images/items/stats/a8397e0218a4762602a429f4f4826690.gif?cv=240",
            "quantity_formatted": 3,
            "quantity_abbreviated": 3
          }
        ],
        "caught": 3,
        "num_items": 2,
        "num_wild_tonic_items": 0,
        "num_all_items": 2,
        "css_class": "half"
      },
      {
        "name": "Mild Spicekin",
        "display_order": 20,
        "large": "https://www.mousehuntgame.com/images/mice/large/de5d82dfb71d83d599ad48f9e33ceab0.jpg?cv=240",
        "mouse_id": 977,
        "items": [
          {
            "type": "medium_spice_crafting_item",
            "quantity": 20,
            "is_jackpot": null,
            "is_wildtonic": null
          },
          {
            "type": "bland_queso_cheese",
            "quantity": 40,
            "is_jackpot": null,
            "is_wildtonic": null
          }
        ],
        "wild_tonic_items": [],
        "type": "geyser_eruption_dragon_mild",
        "has_jackpot": true,
        "merged_items": [
          {
            "type": "medium_spice_crafting_item",
            "quantity": 20,
            "is_jackpot": null,
            "is_wildtonic": null,
            "name": "Medium Spice Leaf",
            "thumb": "https://www.mousehuntgame.com/images/items/crafting_items/thumbnails/c697a753288aa6f8b0c343a9cc4bfddb.gif?cv=240",
            "quantity_formatted": 20,
            "quantity_abbreviated": 20
          },
          {
            "type": "bland_queso_cheese",
            "quantity": 40,
            "is_jackpot": null,
            "is_wildtonic": null,
            "name": "Bland Queso",
            "thumb": "https://www.mousehuntgame.com/images/items/bait/4752dbfdce202c0d7ad60ce0bacbebae.gif?cv=240",
            "quantity_formatted": 40,
            "quantity_abbreviated": 40
          }
        ],
        "caught": 5,
        "num_items": 2,
        "num_wild_tonic_items": 0,
        "num_all_items": 2,
        "css_class": "half"
      }
    ],
    "dusted": [],
    "has_dusted": null,
    "jackpot_items": [
      "hydro_geyser_trap_stat_item",
      "tactical_geyser_trap_stat_item",
      "physical_geyser_trap_stat_item",
      "draconic_geyser_trap_crafting_item",
      "ultimate_trinket"
    ],
    "dusted_loot_preview": [
      {
        "name": "Congealed Rubber",
        "thumb": "https://www.mousehuntgame.com/images/items/crafting_items/thumbnails/88fb12e07d6d63e738241bc9a531700b.gif?cv=240",
        "type": "rubber_crafting_item",
        "slot": "cork_mat"
      },
      {
        "name": "Solidified Amber Queso",
        "thumb": "https://www.mousehuntgame.com/images/items/stats/a8397e0218a4762602a429f4f4826690.gif?cv=240",
        "type": "amber_queso_stat_item",
        "slot": "amber"
      },
      {
        "name": "Bland Queso",
        "thumb": "https://www.mousehuntgame.com/images/items/bait/4752dbfdce202c0d7ad60ce0bacbebae.gif?cv=240",
        "type": "bland_queso_cheese",
        "slot": "bland"
      },
      {
        "name": "Medium Spice Leaf",
        "thumb": "https://www.mousehuntgame.com/images/items/crafting_items/thumbnails/c697a753288aa6f8b0c343a9cc4bfddb.gif?cv=240",
        "type": "medium_spice_crafting_item",
        "slot": "spice"
      }
    ],
    "share_journal_id": 19426
  }

Having trouble pushing again to this branch... PM'd Jack on Discord the error I've been getting:
remote: error: GH006: Protected branch update failed for refs/heads/queso-geyser-stages.
remote: error: At least 1 approving review is required by reviewers with write access.
To https://github.com/DevJackSmith/mh-helper-extension.git
 ! [remote rejected] queso-geyser-stages -> queso-geyser-stages (protected branch hook declined)
error: failed to push some refs to 'https://github.com/DevJackSmith/mh-helper-extension.git'

Yeah that can happen when all branches are protected instead of just a handful. Solution is to open the branch on your fork and not the remote you're merging to.

fixed to protect only 3 branches (master, chrome-ff-opera and ms-edge)


[Feature]:  AS - Enable truncation support in vLLM

Current vLLM doesn't support truncation.
Future work: Truncation support is needed to test reusing the pre-rotary KV cache.

vLLM has introduced "truncate_prompt_tokens" but it does not support offline inference (located in vllm/entrypoints/llm.py) and only supports OpenAI entry points (found in vllm/entrypoints/openai/serving_engine.py).

Relevant but incomplete implementations and issues have been found in the Vllm community, and I've already asked the developers for more information:  https://github.com/vllm-project/vllm/pull/4598#issuecomment-2418962075

@thesues Could you help move all positional encoding issues to the repo of Infinistore? Thanks.


Generating executable from HAL code

I'm trying to execute a HAL mlir similar to the one in this link (https://github.com/google/iree/blob/825cb4a68cec89d9bc17cf33f9be47c7c043b15e/iree/compiler/Conversion/LinalgToLLVM/test/materialize_launch_configuration.mlir). I tried to translate the linked mlir down to bytecode with the following command:
./build/iree/tools/iree-translate -split-input-file --iree-hal-target-backends=dylib-llvm-aot -iree-mlir-to-vm-bytecode-module ./iree/compiler/Conversion/LinalgToLLVM/test/materialize_launch_configuration.mlir

but I get segfault while trying to do so.
How can I successfully generate an executable from HAL code? Thanks!

I was able to generate the binary with the following passes:
./build/iree/tools/iree-opt --iree-convert-hal-to-vm ./iree/compiler/Conversion/LinalgToLLVM/test/materialize_launch_configuration.mlir | ./build/iree/tools/iree-translate --iree-vm-ir-to-bytecode-module -o tmp.vmfb

I've been working with the following conv (mhlo) example:
func @conv_244_112_3x3_3x32() -> tensor<1x112x112x32xf32> attributes { iree.module.export } {
    %input = iree.unfoldable_constant dense<1.0> : tensor<1x224x224x3xf32>
    %filter = iree.unfoldable_constant dense<1.0> : tensor<3x3x3x32xf32>
    %0 = "mhlo.convolution"(%input, %filter) {
        batch_group_count = 1 : i64,
        dimension_numbers = {
            input_batch_dimension = 0 : i64,
            input_feature_dimension = 3 : i64,
            input_spatial_dimensions = dense<[1, 2]> : tensor<2xi64>,
            kernel_input_feature_dimension = 2 : i64,
            kernel_output_feature_dimension = 3 : i64,
            kernel_spatial_dimensions = dense<[0, 1]> : tensor<2xi64>,
            output_batch_dimension = 0 : i64,
            output_feature_dimension = 3 : i64,
            output_spatial_dimensions = dense<[1, 2]> : tensor<2xi64>
        },
        feature_group_count = 1 : i64,
        padding = dense<[[0, 1], [0, 1]]> : tensor<2x2xi64>,
        rhs_dilation = dense<1> : tensor<2xi64>,
        window_strides = dense<2> : tensor<2xi64>
    } : (tensor<1x224x224x3xf32>, tensor<3x3x3x32xf32>) -> tensor<1x112x112x32xf32>
    return %0 : tensor<1x112x112x32xf32>
}

I lowered it down to hal by the following passes:
./iree-opt -iree-flow-hlo-to-hlo-preprocessing -iree-flow-extract-pad-from-conv --iree-codegen-hlo-to-linalg-on-tensors conv1.mlir | ./iree-opt -iree-flow-dispatch-linalg-on-tensors-pass -canonicalize -cse | ./iree-opt -iree-hal-target-backends=dylib-llvm-aot -iree-flow-outline-dispatch-regions2 -iree-hal-materialize-interfaces2

Now when I try to lower it down to vm IR I get the following error: error: 'flow.dispatch' op operand #0 must be index, but got 'i32'.
I believe this is due to some extraneous information that's present at the end of HAL IR:
  func @conv_244_112_3x3_3x32() -> tensor<1x112x112x32xf32> attributes {iree.module.export} {
    %c32 = constant 32 : index
    %c112 = constant 112 : index
    %c3 = constant 3 : index
    %c225 = constant 225 : index
    %cst = constant dense<1.000000e+00> : tensor<1x224x224x3xf32>
    %cst_0 = constant dense<1.000000e+00> : tensor<3x3x3x32xf32>
    %0 = iree.do_not_optimize(%cst) : tensor<1x224x224x3xf32>
    %1 = iree.do_not_optimize(%cst_0) : tensor<3x3x3x32xf32>
    %2 = flow.dispatch @conv_244_112_3x3_3x32_dispatch_0::@conv_244_112_3x3_3x32_dispatch_0[%c3, %c225, %c225](%0) {hal.bindings = [#hal.ex.operand_buffer<"s0b0_ro_external", 0 : index>, #hal.ex.result_buffer<"s0b1_xw_external", 0 : index>]} : (tensor<1x224x224x3xf32>) -> tensor<1x225x225x3xf32>
    %3 = flow.dispatch @conv_244_112_3x3_3x32_dispatch_1::@conv_244_112_3x3_3x32_dispatch_1[%c32, %c112, %c112](%2, %1) {hal.bindings = [#hal.ex.operand_buffer<"s0b0_ro_external", 0 : index>, #hal.ex.operand_buffer<"s0b1_ro_external", 1 : index>, #hal.ex.result_buffer<"s0b2_xw_external", 0 : index>]} : (tensor<1x225x225x3xf32>, tensor<3x3x3x32xf32>) -> tensor<1x112x112x32xf32>
    return %3 : tensor<1x112x112x32xf32>
  }

Is my assumption that this is extra information right? Is there a pass that can remove it? Thanks!

I was able to generate bytecode using iree-translate from flow dialect instead of using iree-opt


feat: Convert Artworks In Series rail to V3

The type of this PR is: Feature

This PR resolves CX-1818
Description
Convert Artworks In Series rail to V3.
PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[ ] I have tested my changes on iOS and Android.
[ ] I have added tests/stories for my changes, or my changes don't require testing/stories, or I have included a link to a separate Jira ticket covering the tests.
[ ] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added an app state migration, or my changes do not require one. (What are migrations?)
[ ] I have added a changelog entry below or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Warnings

:warning:

❌ An error occurred while validating your changelog, please make sure you provided a valid changelog.

  Generated by :no_entry_sign: dangerJS against 93ab06ce91d5536ff62edc12571282e007a893a9

Thanks for these changes Ole, sorry for the late review


Session Cookies Not Being Set When Using nest in Axum

Hi Max, thanks for the great library, I am trying to migrate from axum-sessions to tower session but running into a bit of hiccup,
Description
When using tower-sessions with Axum's Router, I've found that session cookies are not being set as expected when using nest to define a nested router. Cookies work fine without nesting, but seem to fail when used in a nested scope. Even when I try to use it inside the nested router directly it doesn't set the cookie for some reason.
Steps to reproduce

Set up an Axum server with tower_sessions for session management.
Create a main route and a nested route using nest.
Add SessionManagerLayer middleware to handle cookies.
Observe that cookies are not being set for the nested route.

Expected Behavior
Session cookies should be set and retrievable, regardless of whether the route is nested.
Actual Behavior
Session cookies are not being set when using nested routes.
Code Sample
use std::net::SocketAddr;

use axum::{
    error_handling::HandleErrorLayer, response::IntoResponse, routing::get, BoxError, Router,
};
use http::StatusCode;
use serde::{Deserialize, Serialize};
use tower::ServiceBuilder;
use tower_sessions::{
    cookie::time::Duration, fred::prelude::*, RedisStore, Session, SessionManagerLayer,
};

const COUNTER_KEY: &str = "counter";

#[derive(Clone)]
struct AppState {
    session_store: RedisStore,
}

#[derive(Serialize, Deserialize, Default)]
struct Counter(usize);

#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
    let client = RedisClient::default();

    let redis_conn = client.connect();
    client.wait_for_connect().await?;

    let session_store = RedisStore::new(client);

    let state = AppState {
        session_store: session_store.clone(),
    };

    let session_service = ServiceBuilder::new()
        .layer(HandleErrorLayer::new(|_: BoxError| async {
            StatusCode::BAD_REQUEST
        }))
        .layer(
            SessionManagerLayer::new(session_store)
                .with_secure(false)
                .with_max_age(Duration::seconds(10)),
        );

    // Working fine without nest??
    // let app = Router::new()
    //     .route("/", get(handler))
    //     .layer(session_service)
    //     .with_state(state.clone());

    // Not working why cookie is not being set??
    let app = Router::new()
        .nest("/api", another_route(state.clone()))
        .layer(session_service)
        .with_state(state.clone());

    let addr = SocketAddr::from(([127, 0, 0, 1], 3000));
    axum::Server::bind(&addr)
        .serve(app.into_make_service())
        .await?;

    redis_conn.await??;

    Ok(())
}

async fn handler(session: Session) -> impl IntoResponse {
    let counter: Counter = session
        .get(COUNTER_KEY)
        .expect("Could not deserialize.")
        .unwrap_or_default();

    session
        .insert(COUNTER_KEY, counter.0 + 1)
        .expect("Could not serialize.");

    format!("Current count: {}", counter.0)
}

// fn another_route(app_state: AppState) -> Router<AppState> {
//     let session_service = ServiceBuilder::new()
//         .layer(HandleErrorLayer::new(|_: BoxError| async {
//             StatusCode::BAD_REQUEST
//         }))
//         .layer(
//             SessionManagerLayer::new(app_state.session_store)
//                 .with_secure(false)
//                 .with_max_age(Duration::seconds(10)),
//         );

//     Router::new()
//         .route("/test", get(handler_test))
//         .layer(session_service)
// }

fn another_route(app_state: AppState) -> Router<AppState> {
    Router::new().route("/test", get(handler_test))
}

async fn handler_test() -> impl IntoResponse {
    format!("Hello world!")
}

Environment:

Rust version: rustc 1.71.0 (8ede3aae2 2023-07-12)
Tower Sessions:  version: { version = "0.3.3", features = ["redis-store"] }
Axum version: 0.6.20
OS: Linux linux 6.5.8-zen1-1-zen #1 ZEN SMP PREEMPT_DYNAMIC Thu, 19 Oct 2023 22:51:49 +0000 x86_64 GNU/Linux

Additional Context
I am not sure why it's happening I tried debugging it and I can see that the cookie config is being set and all but it's not being sent.
I tested it with Insomnia and the browser itself in this case (Firefox).

Hi, thanks for providing a detailed description and code sample. In the sample you provided, it doesn't look like the counter handler is used in a route. I'm guessing that was an oversight, so if you could update the example and confirm you're still running into this problem that would be helpful.

Hi,
Thank you for pointing out the missing counter handler in the route. You're correct; it was an oversight on my part. I've been refactoring my code for hours and completely forgot to insert the session in my Login route, I tested it with the handler inside the nested route and works perfectly fine so it should work as well for my own code. Thanks again.
I will go ahead and close this issue.


Using slots for collecting parameter to be passed through rendering

Feature request
It'd be great if slots could be used to only collect arguments and let the component decide how to use them, alongside their current behaviour of automatically rendering components to strings. This allow these arguments to be forwarded to slots of internal components.
Motivation
As an example, I'm trying to build a navigation menu with nested navigation items. I'd like to provide the following API:
<%= render NavigationMenuComponent do |menu| %>
  <% menu.item(label: 'Item 1', href: '') %>
  <% menu.item(label: 'Item 2', href: '') do |item| %>
  	<% item.child(label: 'Child 1', href: '') %>
  	<% item.child(label: 'Child 2', href: '') %>
  <% end %>
<% end %>

The first level is achieved with the current version of SlotsV2 through:
class NavigationMenuComponent < ViewComponent::Base
  include ViewComponent::SlotableV2

  renders_many :items, NavigationItemComponent
end

The nested items however need to be rendered withing their own NavigationMenuComponent, rendered in the NavigationItemComponent's template. But the API I'd like to provide is a renders_many :children rather than a renders_one :submenu, NavigationMenuComponent.
I've been able to work around it using:
class NavItemComponent < ViewComponent::Base

  include ViewComponent::SlotableV2

  renders_many :children, -> (**attributes) do
    attributes
  end
end

and within the template
<% if children.any? %>
  <%= render NavMenuComponent.new do |menu| %>
    <% children.each do |child| %>
      <% menu.item(**child.instance_variable_get(:@_content)) %>
    <% end %>
  <% end %>
<% end %>

It'd be great if there was an abstraction over that, maybe only a public accessor for the @_content instance variable. But maybe I've missed something in the documentation about it?

I think you have two options. First just render the sub nav as the content of the item:
<%= render NavigationMenuComponent do |menu| %>
  <% menu.item(label: 'Item 1', href: '') %>
  <% menu.item(label: 'Item 2', href: '') do |item| %>
    <%= render NavigationMenuComponent do |sub_menu| %>
  	<% sub_menu.item(label: 'Child 1', href: '') %>
  	<% sub_menu.item(label: 'Child 2', href: '') %>
    <% end %>
  <% end %>
<% end %>

I'm not sure you even need a NavigationItemComponent at this point but either way you can just use content in the template.
My other thought would be do you need slots at all? Unless you need view helpers for the content of the nav you could just pass it all as data. I've built this as:
# in controller logic
@nav_items = [
  { label: 'Item1', href: ''},
  {
    label: 'Item1',
    href: '',
    children: [
      { label: 'Child1', href: ''},
      { label: 'Child2', href: ''},
    ]
  }
]

and in the view
<%= render NavigationMenuComponent(items: @items) %>

With this approach you likely get infinite levels of nav nesting too as your NavigationMenuComponent template is just recursive. ie somewhere in the template you do
<% if children.any? %>
  <%= render NavMenuComponent.new(items: children) %>
<% end %>

Cheers, I completely hadn't thought of passing the children to the NavMenuComponent through an items attribute. That made everything much tidier.

I agree with @jonspalmer's response 👍🏻

I'll go ahead and close this issue. Feel free to reply if you want to add something!


Update Stop Loss after grid sell

Is your proposal related to a problem?
NO
Describe the solution you'd like
add an option to update stop loss to a higher value after successful grid sell
example :
Stop lose is set to 0.8
Grid 1 1.04
Grid 2 1.05
Grid 3 1.06
after Grid 1 fulfilled update Stop loss to last buy price or to a configurable percentage X% where it will keep updating with every grid sale
this can assure no loss for the coin
Describe alternatives you've considered

Additional context

Interesting. So you would like to set stop loss per grid trade for selling?

you can have multiple options here ,
option 1 :
adding the stop loss configuration to the grid parameters
example
Grid 1 :
Trigger 1:04
Stop Loss : 0.9 from last sell price ( similar to the existing stop loss configuration but using last sell price not last buy price )
Grid 2 :
Trigger 1:06
Stop Loss : 0.85 from last sell price ( similar to the existing stop loss configuration but using last sell price not last buy price )
... etc

option 2 :
change stop loss to have option to use last sell price after successful sell
STOP LOSS : 0.8
Use last sell price : YES / NO
IF No keep the current setup
If Yes bot to update either the percentage to a higher value or store the last sell price from the grid and keep the same percentage

I prefer to configure than automatically update.
Grid 1 :
Trigger 1:04
Stop Loss : 0.9 from last sell price ( similar to the existing stop loss configuration but using last sell price not last buy price )

Grid 1 would not have the last sell price, so it will be something like this.
adding the stop loss configuration to the grid parameters
example

Sell Grid 1 :

Trigger 1.04
Stop Loss: 0.9 from last buy price

Sell Grid 2 :

Trigger 1.06
Stop Loss: 0.85 from last sell price
... etc

Right?

yes exactly

I will put it in the TODO list.
Thanks for suggestions @Elmoftakis

Can I ask for a recommended configuration for grid trading?
I've never used grid trading before, but I'm interested.
And in the grid sell configuration, the "add new grid trade" button is greyed out, how can I configure grid sell?
I'm currently using v0.0.77


Application crash

Identified app crash for certain conditions.
Steps to reproduce:
Open the share dialog and click on back(device's back button).
Again open the dialog and click on back.
At second time(when back button is pressed), application getting crashed.
Platform: Android

@rohankangale2011 can you try again on master branch?


Add pallet map & add updatePallets script & refactor updateAssets script

In summary, this PR adds a script that connects to every supported node, checks all available compatible pallets and saves them to a JSON file. For retrieving values from the map, the following public functions were added: getDefaultPallet(), getSupportedPallets().
Changes:

Update @polkadot/apps-config library to version v0.123.1
Add pnpm updatePallets script which automatically fetches all available pallets for every node from polkadot.js api and saves the result to a pallets.json file
Add 2 public unit tested functions for working with pallets (Described later in more detail)
Add exported constant SUPPORTED_PALLETS to define all possible values for type TPallet
Remove old nodeToPallet map because it's being replaced by pallets.json file
Extract common functionality from updateAssets.ts and updatePallets.ts script to file scriptUtils.ts to avoid duplicates in code
Add prettier code formatter for consistent code formatting. By running pnpm format:check developers can check for formatting errors and pnpm format:write checks and fixes formatting errors.
Remove function getNodeParaId() from utils.ts because it's already defined in assets.ts and does the same thing
Remove file renovate.json because renovate bot is not used
Update variable names in file assets.ts to be more cleaner

Added public functions
getDefaultPallet(node: TNode): TPallet
Returns default pallet for specific parachain node.
Example:
import { getDefaultPallet } from '@paraspell/sdk'

const pallet = getDefaultPallet('Acala')
console.log(pallet)
// prints 'XTokens'

getSupportedPallets(node: TNode): TPallet[]
Returns an array of supported pallets for specific parachain node.
Example:
import { getSupportedPallets } from '@paraspell/sdk'

const pallets = getSupportedPallets('Acala')
console.log(pallets)
// prints ['XTokens', 'PolkadotXcm']

Print all possible values for for type TPallet:
import { SUPPORTED_PALLETS } from '@paraspell/sdk'

console.log(SUPPORTED_PALLETS)
// prints ['XTokens', 'OrmlXTokens', 'PolkadotXcm', 'RelayerXcm']

This PR will close following issue https://github.com/paraspell/xcm-sdk/issues/5

This PR will close following issue https://github.com/paraspell/xcm-sdk/issues/5

Good to know for future issues, thanks @vikiival !


Mondo master: SignalR Mvc MvcPrecompilation and Razor

@ryanbrandenburg Make sure the gradlew file is executable https://github.com/aspnet/AspNetCore/pull/4275


add badge

resolves #10
Also updated the readme to include a badge section and usage section similar to http://github.com/feross/standard

Thanks!

:angel:


[FLINK-12443][table-planner-blink] Replace InternalType with LogicalType in blink

What is the purpose of the change
Use new LogicalType in blink planner.
NOTE: Use only LogicalType to override the previous InternalType functionality. Not implementing the new functionality of LogicalType.
LogicalType and InternalType:
1.LogicalType have nullable, so it has no singleton object.
2.YearMonthIntervalType and DayTimeIntervalType is an independent type.
3.MultisetType is not a MapType.
Verifying this change
ut
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

I try to start reviewing from runtime package, and noticed that the old internal types haven't yet deleted, do you want to delete them in this PR or as a follow up issue?

I prefer delete InternalTypes in follow up PR, If we delete InternalType, we need to have a conversion of LogicalType and TypeInformation.

I can't really comment too much, also because I think this is probably too big to have a sensible review.
One thing I noticed, though, is that this adds conversion logic in the Blink Planner code. @twalthr recently added code for that (https://github.com/apache/flink/blob/master/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/TypeConversions.java) and I think more conversion code is coming up. We shouldn't have code duplication here.
Another thing I noticed (you're probably already aware of this), is that in some places you convert logical types to TypeInformation only to then convert this back to logical types. For example AggFunctionFactory.scala has:
case DECIMAL =>
  val d = argTypes(0).asInstanceOf[DecimalType]
  val decimalTypeInfo = DecimalTypeInfo.of(d.getPrecision, d.getScale)
  new AvgAggFunction.DecimalAvgAggFunction(decimalTypeInfo)

and then DecimalAvgAggFunction converts this back:
@Override
public DataType getResultType() {
	DecimalType t = FlinkTypeSystem.inferAggAvgType(type.scale());
	return DataTypes.DECIMAL(t.getPrecision(), t.getScale());
}

This is already in the existing code, not introduced in this PR. I just noticed it now, though.

Hi @aljoscha

I can't really comment too much, also because I think this is probably too big to have a sensible review.

Sorry to be such a big PR. I tried to split it up, but it brought a lot of transformations of InternalType and LogicalType to ensure that every commit was compiled and passed, and finally I chose one PR.

One thing I noticed, though, is that this adds conversion logic in the Blink Planner code. @twalthr recently added code for that (https://github.com/apache/flink/blob/master/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/TypeConversions.java) and I think more conversion code is coming up. We shouldn't have code duplication here.

Thank you for reminding me about the TypeConvertions. I took a quick look to it, But I think it's different from Blink's conversion right now.
1.Blink should deal with not nullable. (TypeConvertions now just deal with nullable true)
2.Blink's conversion will lose some information. Just like PojoTypeInfo, Blink just convert it to RowType, but TypeConvertions use LegacyTypeInformationType to support it.
Yeah, we shouldn't have code duplication here. I will reuse TypeConvertions, but in order to avoid further enlarged changes, I need to make some additional convertions based on it.

Another thing I noticed (you're probably already aware of this), is that in some places you convert logical types to TypeInformation only to then convert this back to logical types. For example AggFunctionFactory.scala has:

Good catch, there are still many places where we shouldn't use TypeInformation, and I should change them all to use LogicalType in follow up PRs.

I would suggest to make this PR as clean as possible, by making the relationship with TypeInformation, LogicalType and calcite's RelDataType clean. I also observed issues similar with aljoscha's comment, and from my experience, it's very unlikely to be cleaned up in the future if we let this PR slip into master.

I would suggest to make this PR as clean as possible, by making the relationship with TypeInformation, LogicalType and calcite's RelDataType clean. I also observed issues similar with aljoscha's comment, and from my experience, it's very unlikely to be cleaned up in the future if we let this PR slip into master.

Agree, we can track them from LogicalTypeConverters, but a lot of TypeInformation still block by Expression and TableEnv and Udx.

@flinkbot attention @KurtYoung
Fixed comments and rebase. Please take a look.

Some tests failed


pm grant com.tribalfs.pixels android.permission.WRITE_SECURE_SETTINGS

pm grant com.tribalfs.pixels android.permission.WRITE_SECURE_SETTINGS

pm grant com.tribalfs.pixels android.permission.WRITE_SECURE_SETTINGS


replace the twitter old logo

Hey, I would like to work on replacing the old Twitter logo with new log.
can you please assign me this issue?

Where do you want to change it? @chaursiyasanjeet Please attach a screenshot whenever to you to mention any kind of changes, it would be more easier for others to understand the issue.

Here

Ok, so you want this to be replaced with new "X'' logo? Right?

Hey @chaursiyasanjeet! Thank you for reaching out. Unfortunately the corresponding assets are not in this repository and the other one is not connected to hacktoberfest, also we don't plan to add it.
Thanks again for the notice, closing the issue.

You are welcome @nandor-magyar, if any improvement needed in the frontend then you can reach me


Add requirements.txt describing Python requirements of test scripts

The recommended way to run our tests is to use the nix environment. However, not everybody wants to use this, nor should be forced to. It's thus important to make sure that the build system and tests work 'out of the box' as much as possible.
To support this, we should provide a requirements.txt that lists the requirements of our test scripts, esp. scripts/tests.

Fixed by https://github.com/pq-code-package/mlkem-c-aarch64/pull/243


Refactoring : Add generic type to ResourceFlowUnit.

Issue #, if available:
Description of changes:
Add generic type to ResourceFlowUnit and now we can specify the type of summary within each flowunit.
This will help us to remove the instanceof when fetching summary from flowunit.
Tests:
tested on docker
Code coverage percentage for this patch:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

LGTM


Support kadira:flow-router

flow-router is now (> v2.0) served by kadira

Thanks for the effort :+1:
Please change the order so it tries kadira:flow-router first.
Then we need to add kadira:flow-router to the list of weak dependencies in package.js and update the tests to mock kadira:flow-router too.

Closing this as I've fixed this. Tracking in #36. Just gonna have a stab at #35 before release.


ReadMe badges

Add badges:

PyPI version
PyPI status (alpha, beta, etc.)
Test coverage
Current GitHub Actions status
Supported Python versions (from PyPI)
YAPF Code style format

Test coverage badge is working with codecov, so I added codecov job to GitHub Actions.
Supported Python versions badge is working with PyPI, so I updated supported Python versions in PyPI.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cbbff0c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage          ?   78.23%
=========================================
  Files             ?        2
  Lines             ?      147
  Branches          ?        0
=========================================
  Hits              ?      115
  Misses            ?       32
  Partials          ?        0

Flag
Coverage Δ

unittests
78.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbff0c...d5c5cb2. Read the comment docs.


Add documentation for "Video" component

https://ons-design-system.netlify.app/components/video/
Comment:
JB - Should this be moved to styles alongside images?

https://service-manual.ons.gov.uk/design-system/components/video


Customize the layout of entities through a TypeScript @View annotation

Overview of the feature request
Similar with the existing OpenXava's Java @view annotation
https://www.openxava.org/OpenXavaDoc/docs/view_en.html
JHipser generates a default user interface from the model.
In many simple cases this is enough, but sometimes it is necessary to model with precision the format of the user interface or view.
The TypeScript @view annotation could be used in an entity or embeddable class in order to define the layout of its members in the user interface.
Motivation for or Use Case
Users could quickly achieve a great deal of UI customization throws a simple @view annotation in TypeScript. Being in Typescript (client side) user would be allowed to quickly prototype / change the UI without recompiling all the application (only the client side would be automatically recompiled when the view is modified). The philosophy is also similar with the existing JDL.
From implementation standpoint maybe it is possible to transpile the existing OpenXava Java @View annotation in JS using a tool like http://www.gwtproject.org or Java to Kotlin conversion - https://try.kotlinlang.org/#/Kotlin Koans/Introduction/Java to Kotlin conversion/Task.kt (and then Kotlin has support to generate JS code)
Related issues or PR
I did not find a similar feature request.

[X ] Checking this box is mandatory (this is just to show you read everything)

Hi, I don't understand what you want. I see possible solutions, but not the actual need here

Currently, even for simple UI layout customizations it is required to modify the generated HTML code.
A solution similar with the above @View annotation (in OpenXava it is implemented in Java but I believe it is more appropriate to implement this in TypeScript) would allow doing complex enough UI customizations only by providing a few UI "hints" in the TypeScript @View annotation. In this case people will need to touch the generated HTML only for very complex UI screens - for all the other UI customizations they'll be able to provide few UI layout "hints" in TypeScript. Basically, for doing UI changes, instead of changing lots of the (HTML) generated code people will instead provide few lines of UI "hints" in the TypeScript code.
By checking this documentation you can get a good idea of how complex UI layouts can be achieved using this approach.
https://www.openxava.org/OpenXavaDoc/docs/view_en.html

How is this related to something in the JDL?

I don't want this to be done via an annotation in the JDL: that would bloat it.

I also believe that this should not be implemented in JDL but rather as a TypeScript annotation which optionally should be available to be used in the "client-side" TypeScript. I know that Angular is typescript and I believe Vue can be used with typescript and I'm not sure about React.
The use case which I imagine is like this - first people will generate the app starting from JDL. Once generated people will need to modify the app as per their need.
JHipster side-by-side in practice by David Steiman - https://www.youtube.com/watch?v=Gg5CYoBdpVo
Following the ideas presented in the above video users will "extend" one of the generated client side TypeScript classes in order to implement their custom logic on the client side. Normally at that time will also come the need to "customize" the UI. At that moment, instead of forking the generated HTML code as they are doing now, for most of the situations people would be allowed (but not forced) to use the new @View typescript annotation and give "hints" of how the entity layout should look. Once the @View annotation is used (found) there will be some kind of mechanism which will parse the @View and generate the UI as per the user's instructions. That way, for most of the situations, people will be allowed to render the entities as per their own need without having to fork the HTML code also. For very complex UI needs people will still have the option to fork the generated HTML code. The typescript annotation will be optional, people who choose to ignore the annotation can continue to do everything by modifying the generated HTML code, the same way they are doing now.

The comparison with JDL was very loose in the sense that JDL can be seen as a DSL for describing the app (and app entities) and this annotation (if implemented) can be seen as a small DSL to describe the layout of entities.

Alright, I think I got it. Thanks. This issue is better suited for discussion in the generator-jhipster repo. Transferring it.


[Bug] token: parameter not set

This bug was introduced in commit 297daf745e467b39d4bbdc74f63801249e867230
A pull request is being created to fix this.

Well...
Fine...

Sorry, I didn't mean to slight you. I fixed this before your issue was made :')


linux kernel: prefer zstd where possible

Description of changes
Closes #302291
Closes #301536
The following things have changed:

For 5.11+: ZRAM compressor uses zstd now.
For 5.13+: kernel modules are compressed with zstd instead of xz.
For 5.19+: support zstd-compressed firmware.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Going to rebuild my infra on my Hydra and boot into that kernel to see if this has some unexpected side-effects.

First breakage I found is that images from make-disk-image.nix are broken, seeing stuff like this in the buildlog:
[    0.255498] Invalid ELF header magic: != ELF
[    0.256614] Invalid ELF header magic: != ELF
insmod: can't insert '/nix/store/aq5nbyxd3zsi51z1bahfq2ja07ssivqx-linux-6.1.84-shrunk/lib/module[    0.258685] Invalid ELF header magic: != ELF
s/6.1.84/kernel/[    0.259465] Invalid ELF header magic: != ELF

Taking a look.

Taking a look.

Have a fix locally now, but I'm too tired now to push, will try to get to it tomorrow.

Has the impact on the size been measured for the kernel modules? The "comparable" compression ratio of zstd (as compared to LZMA) can be quite a bit worse (double digit percentage) depending on the levels and specifics of the uncompressed data. (This concern should not apply to the other two points; zram changes from a worse compressor and for the firmware it's only adding support.)

Has the impact on the size been measured for the kernel modules

fwiw the stage1 modules-shrunk is 7.6M (xz) vs 9.4M (zstd) on my laptop.
the kernel-modules path of the same machine is 305M (xz) vs 339M (zstd).
Currently preparing a patch that provides zstd compression of the firmware. Here we have 492.6M (zstd) vs 440.3M (xz) though I'm playing around with different levels here.
Will probably document the exact impact in the commit message and perhaps also in the release notes.

Pushed an improved version of the original patch that fixes the VM image builder. Pushed another commit which actually uses zstd to compress firmware.
Will rebuild my infra once again with these two patches to see if I find more problems and how well it works out.
There's a ~11% increase (440M -> 490M) in linux firmware now. Perhaps we want to make the behavior configurable here?
I played around a bit with the flags for zstd, but with a very high compression level (15) I only got it down to 483M.
Will write something to the release notes later.
Also cc @fpletz.

I'd personally be more worried about the modules, since some of them go into the initrd. If I understand correctly, this is where you observed the increase from 7.6MB to 9.4MB, which seems quite bad.

Pushed an improved version of the original patch that fixes the VM image builder. Pushed another commit which actually uses zstd to compress firmware.
Will rebuild my infra once again with these two patches to see if I find more problems and how well it works out.
There's a ~11% increase (440M -> 490M) in linux firmware now. Perhaps we want to make the behavior configurable here? I played around a bit with the flags for zstd, but with a very high compression level (15) I only got it down to 483M.
Will write something to the release notes later.
Also cc @fpletz.

You could try the --long option, which should work.

Personally, I'ld love to see zstd support. But as others mentioned xz generally seems to have a better compression ratio than zstd. I hope the suggestions from @aviallon can make a difference.
The hit on the firmware is IMHO pretty bad since most people running on hardware will need at least one binary blog from the standard linux nonfree firmware package.
I was thinking about splitting it because some of the bigger blobs from unpopular vendors are used very rarely anyway:
[…]
   1.86 MiB result/lib/firmware/libertas
   2.15 MiB result/lib/firmware/ueagle-atm
   2.32 MiB result/lib/firmware/iwlwifi-8000C-36.ucode
   2.32 MiB result/lib/firmware/iwlwifi-8265-36.ucode
   2.33 MiB result/lib/firmware/iwlwifi-8265-34.ucode
   2.34 MiB result/lib/firmware/iwlwifi-8000C-34.ucode
   2.36 MiB result/lib/firmware/qca
   2.41 MiB result/lib/firmware/iwlwifi-9000-pu-b0-jf-b0-38.ucode
   2.41 MiB result/lib/firmware/iwlwifi-9260-th-b0-jf-b0-38.ucode
   2.55 MiB result/lib/firmware/iwlwifi-9000-pu-b0-jf-b0-34.ucode
   2.55 MiB result/lib/firmware/iwlwifi-9260-th-b0-jf-b0-34.ucode
   2.58 MiB result/lib/firmware/bnx2x
   3.94 MiB result/lib/firmware/radeon
   4.57 MiB result/lib/firmware/cxgb4
   4.80 MiB result/lib/firmware/liquidio
   6.08 MiB result/lib/firmware/cypress
   6.20 MiB result/lib/firmware/cirrus
   6.52 MiB result/lib/firmware/ath12k
   7.58 MiB result/lib/firmware/rtw89
   8.67 MiB result/lib/firmware/ti-connectivity
  11.99 MiB result/lib/firmware/brcm
  14.74 MiB result/lib/firmware/dpaa2
  19.44 MiB result/lib/firmware/ath10k
  20.43 MiB result/lib/firmware/qed
  25.87 MiB result/lib/firmware/i915
  34.94 MiB result/lib/firmware/mediatek
  43.37 MiB result/lib/firmware/ath11k
  58.95 MiB result/lib/firmware/intel
  60.94 MiB result/lib/firmware/amdgpu
  64.19 MiB result/lib/firmware/nvidia
  80.99 MiB result/lib/firmware/mrvl
  81.63 MiB result/lib/firmware/mellanox
 140.34 MiB result/lib/firmware/netronome
 151.34 MiB result/lib/firmware/qcom
   1.05 GiB total

For instance, we could split it loosely based on how Debian is currently doing it: https://packages.debian.org/search?suite=sid&searchon=names&keywords=firmware

I was thinking about splitting it because some of the bigger blobs from unpopular vendors are used very rarely anyway:

fwiw that works pretty well. I use a thinclient with 4GB emmc as bluetooth/pulse/librespot-connected speaker which is why I didn't want to install linux-firmware on it. Instead, I built a derivation that only copies the relevant bluetooth parts over and called it a day.

Personally, I'ld love to see zstd support. But as others mentioned xz generally seems to have a better compression ratio than zstd. I hope the suggestions from @aviallon can make a difference.

Agreed.
I hope I'll get to it some time this week :)

Perhaps I misremembered something: I somehow had in mind that high compression levels also affect decompression performance in zstd which is why I stopped after -15. However, -19 --long may slow down the build-time significantly (though I don't care much about that), but its decompression speed is still way faster (with a naïve timing measurement from pkgs.time at least I got 0.02s wallclock time for zstd vs. 0.27s for xz for a 13M blob with 125% (zstd) CPU vs 99% CPU (xz)). I can live with these stats.
The total difference between xz and zstd compressed firmware is now 440M vs 460M, i.e. a size increase of 4.5% (vs 11% before).

So, with -19 --long for kernel modules (messed around in the relevant makefile fromt he kernel sourcetree) I got 10% increase of linuxKernel.kernels.linux_6_1.
Then I compressed the .ko files manually with a dictionary trained on these files before. Then I got it down to a 4% increase (though I'll need to dig a bit into it why it's not even less). That being said, I'll need to understand how the kernel does zstd decompression actually and how we can inject a dictionary into it.

It's a pity there is no Kconfig option for setting compressor's parameters. Perhaps I could try to tease upstream about that (though I have a feeling it'll get rejected).
In any case, thank you very much @Ma27 for your work 😃

So, I need a bit of feedback on how to resume here:
zram/zswap
ZRAM_MULTI_COMP was enabled in https://github.com/NixOS/nixpkgs/pull/303821#event-12457866752, so we need Z3FOLD here and are done with it.
firmware
I think we're good with 4.4% increase. If nobody disagrees, I think this can go to master (along woth the zram/zswap stuff).
kernel modules
I think we all agree that the state I have pushed here isn't really acceptable (almost 30% increase of linuxKernel.kernels.linux_6_1). There are three options forward:

Accept 11% increase we get by patching in -19 --long (as we do it for firmware blobs) via        substituteInPlace scripts/Makefile.modinst \
        --replace-fail '$(ZSTD) -T0' '$(ZSTD) -T0 -19 --long'

That'd be the by far quickest solution, but also the dirtiest.
Let zstd train a dictionary on build that's used to decompress kernel modules. I'm not sure if there's a reasonable way for third-party modules to benefit from that though. However, the zstd implementation of the Linux kernel appears to support dictionaries, it's not used for the module loader however. If we consider this a viable way forward I'd probably try to write a kernel patch for that.
(Caution: I talk about zstd not in the context of .ko files, but in the context of NARs): zstd provides seekable frames (i.e. the ability to decompress portions of a file without decompressing all of it). That could be used under the assumption that between most kernel releases a lot of bytes inside the packages don't change and as a result, Nix could be patched to only fetch ranges of a zstd-compressed NAR that have changed (e.g. by exchanging the hashes of ranges and determining what needs to be re-fetched). That would address the concerns about amount of stuff to download, storage of a binary cache, however it won't account for the disk space of a system.
(credits to @RaitoBezarius how pointed me towards this idea)

I need a few more opinions from other people because I'm not sure what's the best option to proceed.
Opinions?
cc @lheckemann @k900 @alyssais @RaitoBezarius @fpletz @aviallon @alois31

I don't think adding delta updates to Nix is realistic at least in the short term. I also think the size increase shouldn't be a huge deal.

@k900 this is correct, I hoped I made it clear that this will take a long time to land (zstd seekable frames for NARs)

To shed some light on the other side here: Has anyone checked if we gain any measurable advantages by using zstd? I.e. is compression or decompression significantly quicker? If there are no real advantages, increasing the closure size is IMHO pointless.

I see https://bugs.archlinux.org/task/78892 from the Archlinux folks, some numbers are in there and compare xz. I understood this PR as a way to avoid the xz dependency, due to the recent events.
zstd has the (security?) advantage of being maintained by a large company.

zstd has the (security?) advantage of being maintained by a large company.

I agree it is better maintained than xz, but I have reservation about that general opinion. I'm not surprised by a company claiming they "forced to make data accessible by gov to satisfy a local law endorsement", though it's unlikely to do so in a data formet.

but its decompression speed is still way faster

The main issue with the really high compression levels isn't speed, but memory usage -- including for decompression -- as far as I understand the manpage.
That aside, I like this!

I didn't mean to merge the make-modules-30%-bigger change, reverted in #310110. The rest should be fine IMO, it's an improvement overall and leaves less open WIP.

Could we reopen this since the change was reverted?

done.


animations loading twice?

some content slides in twice in some places and once in others. im only using css no javascript. this is not happening on all elements and appears quite unpredictable.

Hello.
Could you please detail the issue? Also, providing a reduced case on codepen will make it easier to help you.

Try adding
visibility: hidden;
to your animated element.

@laurencefass please provide us a codepen version so we can check your issue and solve it. Thank you!

The animation is not actually happening twice. The problem arises trying to assign classes in JQuery and does not appear when I hard-code classes into html elements. Also it also only noticeable to the first element on the page.
I think this is a limitation with jquery not an issue with animate.css (though it does effect it) and there appears no way (I can find) to assign classes BEFORE the page is rendered.
My workaround is to fadeIn the entire body element slower than the animate.css effects so the user can't see the first element swap happening.

Hi, @laurencefass since it is a jquery related issue and you already said affecting it with our animate.css then it's not totally an issue to animate.css that's why we are going to remove the jquery as a way to use with animate.css we've discussed this earlier, we have decided to replace all jquery samples and demo with vanilla JS. Please refer to this issue #835 Have a good day!
Anyway, thanks for your workaround it might be helpful to others in the future. ;) can we close this now?

thanks for your help ill reissue if i see further problems but i think this is a known problem with jquery.


Feature #329: Search also through ancestors for default transfer account

Using the suggested approach.

:+1:
Thanks. I will also make some modifications so that it stops immediately a transfer account is found. That way, the immediate parent's setting will be preferred, not an ancestor account.

Great, thanks. I believe that I covered that.
It should traverse from current account to the root account.
The loop should terminate on first sight of possible transfer account (search while defaultTransferAccountID == 0) or gets to the root account without finding anything.

 That should work just fine.


Bug in 1.3.2/1.3.3

The regex's in item 1.3.2 and 1.3.3 conflict with each other.  By running the role in step mode, you can verify that
"Defaults    use_pty" in /etc/sudoers is present after 1.3.2, and then immediately replaced by
"Defaults    logfile="/var/log/sudo.log"" in task 1.3.3, because the regex for both tasks is:
"^Defaults"
I suggest changing the regex for task 1.3.2 to '^Defaults    (?!(logfile="{{ rhel8cis_varlog_location }}")).*'
and the regex for task 1.3.3 to '^Defaults    (?!(use_pty)).*'
In the above two regex, there are 4 spaces between "Defaults" and the rest of the regex, but I can't get that to format correctly here.

Thanks for  reporting the issue. This will be addressed in the next release. We are working on a goss framework audit, similar to the RHEL7-CIS/STIG and I discovered this issue and a few others. The hope is to have that release in the next couple of weeks.


CSS Modules issue or misunderstanding

Love this project!
I'm quite new to CCS Modules, so my issue might be due to lack of experience in reasoning about this new paradigm.  We had a designer develop some styles for a new React based site that we're putting together.  These would be base global styles, so I would assume that by putting them into core.scss under the :global {} scope identifier, this would be the appropriate course of action.
:global {
  @import 'base';
  @import 'vendor/styles';
}

However, after compilation I receive this error:
Module build failed: CssSyntaxError: postcss-modules-local-by-default: /Users/pbaker/Projects/React/src/styles/core.scss:1:0: Missing whitespace before :global :global {
If I hoist the @import outside the global identifier it works, but my understanding is that everything is local by default.  Can someone point me in the right direction here?
Thanks!

I believe it has something to do with whatever is being imported in vendor/styles. I'm not a CSS modules expert at all, though I've seen this error before. I'd suggest doing some digging in the css-modules and css-loader (and maybe postcss-loader) repo and see what you can uncover, and I will do the same. Just for reproduction, what are you importing in vendor/styles?.

I boiled it down to this.
SCSS
$color-white: #fff;
$color-primary: #6d5cae;
$color-black: #000;
$mix-percentage-dark: 81%;

@mixin button($text-color, $background-color, $border-color) {
  .open .dropdown-toggle#{&} {
    background-color: mix($background-color, $color-black, $mix-percentage-dark);
    border-color: mix($background-color, $color-black, $mix-percentage-dark);
    color: $text-color;
  }
}

.btn-primary {
  @include button($color-white, $color-primary, $color-primary);
}

Which compiles to:
.btn-primary .open .dropdown-toggle.btn-primary {
  background-color: #584b8d;
  border-color: #584b8d;
  color: #fff;
}

Anyways, if that example SCSS is placed into the :global {} it fails to compile.  I'm not sure why though.

@davezuko I went down a bit of a rabbit hole and I wasn't able to figure it out.  I'm a bit new to webpack, so I'm not sure how to really debug it.  I believe the issue is occurring somewhere in the css-leader though.  For now, I will just disable css modules.

Ok, going to close this for now then... I don't believe this is an issue directly related to the starter kit, but may stem from something unique to the sass -> postcss -> css modules -> css compilation process. If I can't find anything related to this issue in any of those repos I will re-open.

Same error here. In my situation. I've installed the foundation-apps npm package and imported it into core.scss. When it try to compile throwns me this error.
`ERROR in ./~/cs
tcss-loader!./~
Module build fa
oundation-apps\
a > & {    `

@kabala, @davezuko: Experiencing the same exact issue when trying to import Bulma. Any fix ever found for this?

@davezuko Same issue when trying to import bootstrap-sass.

Same issue with bootstrap-less

I had this issue with something like:
:global {
  h1, h2, h3, h4, h5, h6 {
    & + & {
      margin-top: 1em;
    }
  }
}

This produced output like :global h1 + :global h1, :global h2 + :global h1.
You have to have output that's like :global h1 + h2.


[Obsolete] MONDO:0008807 'apnea, central sleep'

Mondo term (ID and Label)
MONDO:0008807 'apnea, central sleep'
Reason for deprecation
@ahamosh is this a historic disease or is it still valid? The records are quite old:
https://omim.org/entry/207720
https://omim.org/entry/107640
Suggested term to consider
MONDO:0004731 'central sleep apnea syndrome'

Added to the list of terms to obsolete for October release.
However, we should get answer from @ahamosh before going ahead with the obsoletion.

@ahamosh :eyes: - see question above

These aren't really free-standing disease and they certainly aren't monogenic, except for central hypoventilation syndrome which is its own entity.

thanks @ahamosh!


Test that plan generation scales to very large workloads

Changes the output_blocks function to an iterable so that the entire list of chunk coordinates isn't materialized during planning. Without this change the test wouldn't complete in any reasonable time; with the change it takes a couple of seconds.
Of course, these huge jobs won't run since currently the entire iterable is materialized before being submitted to the backend. See #239.

BTW @TomNicholas and @keewis this should fix the problem with saw with generating a plan for large workloads from the meeting on Monday.


economic-order-quantity.ipynb

[x] Postpone bibliographic notes rather than having them at the top?
[x] Typo: "incorrectly cited ince 1931"
[x] Add the URL for Ziegler paper, that is https://www.sciencedirect.com/science/article/abs/pii/016763778290030X
[x] Unclear sentence: "The problem is to find the size of a that minimizes the cost of maintaining that item in an inventory". In the book I rephrased it as "The problem consists of finding the order quantity that minimizes the cost of maintaining a specific item in inventory"
[x] Typo: "given given"
[x] Typo: "where $x$ is the...?"
[x] Typo: "is define"
[x] Unclear sentence "As the following diagrams the solution to this optimization problem."
[x] Remove label/description on top of the 2nd figure (but maybe only when @gromicho gets here with figure regeneration)
[x] Typo: "...the hyperbola described by the constraint $x y \leq 1$" should be $x y \geq 1$?
[x] Too much white space around the Lorentz cone picture, needs to be trimmed (but maybe only when @gromicho gets here with figure regeneration)
[x] "Note the improvement in accuracy of this calculation compared to the analytical solution." --> compared to the previous implementations?

Thanks for the careful read. Much improved!


wip: allow user to add hostAliases

Description of the change

Existing or Associated Issue(s)

Additional Information

Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[ ] Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
[ ] JSON Schema generated.
[ ] List tests pass for Chart using the Chart Testing tool and the ct lint command.

Hi @tuananh
Apologies for the late response, you'll need to rebase your branch and do some of the helm-docs steps to ensure the README.md includes the new hostAliases value.


Can't create site: The scale operation is not allowed for this subscription in this region.

Not sure if this is a restriction with internal subs, but I'm getting this, no-matter which method I use to try to create the site/deploy the script:
STATUS Unauthorized
STATUS MESSAGE {
"Code": "Unauthorized",
"Message": "The scale operation is not allowed for this subscription in this region. Try selecting different region or scale option.",
"Target": null,
"Details": [
{
"Message": "The scale operation is not allowed for this subscription in this region. Try selecting different region or scale option."
},
{
"Code": "Unauthorized"
},
{
"ErrorEntity": {
"ExtendedCode": "52020",
"MessageTemplate": "The scale operation is not allowed for this subscription in this region. Try selecting different region or scale option.",
"Parameters": [
"default"
],
"Code": "Unauthorized",
"Message": "The scale operation is not allowed for this subscription in this region. Try selecting different region or scale option."
}
}
],
"Innererror": null
}
PROVISIONING STATE Failed
TIMESTAMP 28/06/2019, 17:07:15
DURATION 6 seconds
TYPE Microsoft.Web/serverfarms
RESOURCE ID /subscriptions/...removed../resourceGroups/BlobEventSubscription/providers/Microsoft.Web/serverfarms/viewerhostjota
RESOURCE viewerhostjota

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b250ca39-0ba3-20dc-179b-c5a0d80fba9f
Version Independent ID: 5f1d000e-c731-4b98-8eb7-55836829ca47
Content: Send Blob storage events to web endpoint - portal
Content Source: articles/event-grid/blob-event-quickstart-portal.md
Service: event-grid
GitHub Login: @spelluru
Microsoft Alias: spelluru

Hi @lokijota Thank you for your feedback! We will review and update as appropriate.

@lokijota This could likely have been an issue between your subscription type & region you're attempting to deploy to, i.e.: this SO post. If you're still encountering this issue, please consider opening a support case and we'd be happy to help.
Note: If your subscription doesn't carry a support plan, you may reach out to us via email at azcommunity at microsoft dotcom and we'll enable a one-time free support case for your subscription. Be sure to include the URL of this issue as well as your subscription ID in your email.
We will now proceed to close this thread for now. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Support namespace change from std.os to std.posix

Ah my apologies, I didn't do my due diligence to notice #80 . Please feel free to close this in favor of the earlier PR.


spring-boot-crud example has some minor issues

The spring-boot-crud example project has some minor issues with compilation . the package paths aren't there and there is a duplicate annotation definition of the main class.

Thanks @vsk2017. I'll get this fixed.

This has been fixed.


Pass though file_url from extended data attrs so synology chat bot ca…

Description:
Pass through file_url to the Synology chat API so that it can send attachments in Synology Chat.
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7100
Example entry for configuration.yaml (if applicable):
notify:
  - platform: synology_chat
    name: hass_synchat_name
    resource: https://synology.example.com/webapi/entry.cgi?api=SYNO.Chat.External&method=incoming&version=1&token=foobar

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

I don't know why this is stuck as WIP but I have removed that

This has now broken in 0.83.x. Messages with file_url: in code do not get sent at all. Was working great in 0.82.x

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels
Merged PRs should not be used for support or bug reports. Thanks!


Import-Certificate: fix ps example set-location

https://docs.microsoft.com/en-us/powershell/module/pkiclient/import-certificate
Import-Certificate: fix ps example set-location

Docs Build status updates of commit f2dd7cd:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit f2dd7cd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/windows/pkiclient/Import-Certificate.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


learning the generative model of periodical process

I've applied the WGAN algorithm implemented in torchsde/example/sde_gap.py  to sine function (deterministic with fixed initial conditions). After 30000 learning epochs we can see that algorithm struggles to capture the periodic structure of the signal:

The sine function was implemented as:
class PeriodicSDE(torch.nn.Module):
sde_type='ito'
noise_type='diagonal'
    def __init__(self):
        super().__init__()
    def f(self,t,y):
        x1, x2 = torch.split(y, split_size_or_sections=(1, 1), dim=1)
        f1 = -x2/3
        f2 = x1/3
        return torch.cat([f1, f2,], dim=1)
    def g(self,t,y):
        return 0*torch.ones_like(y)

ou_sde = PeriodicSDE().to(device)
y0= torch.ones([dataset_size,2],device=device)*2 - 1
norm= (torch.sqrt(torch.sum(y0**2,dim=1))).unsqueeze(1)
y0=y0/norm

In my opinion, the reason of low efficiency is caused by vanishing/exploding gradients in discriminator network due to weight clipping. The histograms of weights for input and output layers of "f" function of NCDE discriminator:

Most weights are stucked on the limits imposed by clipping, and effectively the learning process for discriminator network stops once this happens. Is it possible to fix through gradient penalty?

This sounds like an open research question :)


singleSelection cannot be deselected

If the selection limit is set to something greater than 1, you can deselect each option where the dropdown (it becomes optional), but once you change the selection limit to 1, you cannot deselect your item (it becomes mandatory) to select at least one option once you click on one.
You might say to might as well use a normal drop-down menu in this case, but what if I need a dynamic multselection where the selection limit changes based on previous selections?

Currently working