[Bug]: "TimeoutError: Navigation timeout of 30000 ms exceeded" in Firefox using protocol: 'cdp'

Minimal, reproducible example
const puppeteer = require('puppeteer');

(async () => {
const browser = await puppeteer.launch({
    defaultViewport: null,
    browser: 'firefox',
    protocol: 'cdp',
    headless: false,
    executablePath: 'C:\\Program Files\\Mozilla Firefox\\firefox.exe'
});

  const page = (await browser.pages())[0];
  await page.goto('https://google.com');

})();

Background
No response
Expectation
Navigate to a site without errors
Reality
When trying to open a site in Firefox using the protocol: 'cdp' I always get the error TimeoutError: Navigation timeout of 30000 ms exceeded.
Although a site is fully loaded.
There is no such problem using the protocol: 'webDriverBiDi'
Puppeteer configuration file (if used)
No response
Puppeteer version
23.2.0
Node version
22.3.0
Package manager
npm
Package manager version
10.8.3
Operating system
Windows

The CDP support for Firefox is deprecated and won't get updates or fixes. Please use webDriverBiDi for this, thanks! cc @whimboo in case you want to investigate on the Firefox side.

Thanks for informing but as @OrKoN said CDP support is deprecated and we do not want to spent more time on it.

The CDP support for Firefox is deprecated and won't get updates or fixes. Please use webDriverBiDi for this, thanks! cc @whimboo in case you want to investigate on the Firefox side.

Is there a way to connect to an already running Firefox  browser when the webDriver BiDi protocol is used?

The CDP support for Firefox is deprecated and won't get updates or fixes. Please use webDriverBiDi for this, thanks! cc @whimboo in case you want to investigate on the Firefox side.

Is there a way to connect to an already running Firefox browser when the webDriver BiDi protocol is used?

yes, it should work the same way as with CDP by providing the websocket endpoint URL to the connect options. Although you might need to launch Firefox with WebDriver BiDi enabled (@whimboo is there a documentation how to launch Firefox for BiDi without Puppeteer?).

There is no difference for BiDi. Just use the --remote-debugging-port %port argument and the Remote Agent will be started which handles both WebDriver BiDi and the now deprecated CDP protocol.


360° Nodes | 全方向節點

It's still really hard to build straight lines or slopes that are not parallel to the x and z axes
Add a new type of node which just make a straight line connecting each other when linked by a rail.
MTR支持的軌道傾斜角度還是太少，修建一部分斜着的軌道有些困難。可以加入一種新的節點，當連接它們時直接創建一條筆直的鐵軌。
Sincerely hope that the modder team can add this because it's pretty necessary.

The main issue here is a seamless transition between the usual system of nodes and this kind of node. You would essentially have to get some weird system that gets the angle of connections between this node and the next and use that as the base of the gradual slope.

The main issue here is a seamless transition between the usual system of nodes and this kind of node. You would essentially have to get some weird system that gets the angle of connections between this node and the next and use that as the base of the gradual slope.

in fact, control the calculation of bezier curve(like rtm done) can do this in a very easy-control way(but it also needs you to learn a lot about maths)

Since it wias not 360 Node

Duplicate of #332


Please document configuration options

According to the CONFIG page, I should run "start-chronos.bash --config" to see what configuration options are available. However, I've installed the chronos RPM on CentOS and that bash script doesn't exist.
If I run /usr/local/bin/chronos --help I get:
USAGE: chronos-framework (--jar <chronos.jar>)? <option>*

...

The other text in the help says to configure chronos by using /etc/chronos/conf or passing command-line arguments, which of course I don't know.

Looking through the source,
$ grep opt src/main/scala/org/apache/mesos/chronos/scheduler/config/SchedulerConfiguration.scala | cut -d'"' -f2 | sort
here are the available options:

cluster_name
disable_after_failures
failover_timeout
failure_retry
hostname
leader_max_idle_time
mail_from
mail_password
mail_server
mail_ssl
mail_user
master
mesos_checkpoint
mesos_framework_name
mesos_role
mesos_task_cpu
mesos_task_disk
mesos_task_mem
raven_dsn
reconciliation_interval
schedule_horizon
slack_channel
slack_token
slack_url
task_epsilon
user
zk_hosts
zk_path
zk_timeout

+1

+1

+1

+1

+1

/usr/bin/chronos run_jar --help

Is what you want probably?

+1

The configuration flags have been added to the configuration.md file.
The documentation site will be updated once we release the next version.


Customise Play/Pause button's Drawable and OnClickListener

Usecases include custom Analytics tracking on play/pause click, so on.
Thanks for the lovely lib!

Issue #281 has been closed, a few components have been refactored out of DefaultPlayerUIController. They will be available starting from version 10.0.0 in the upcoming days :)

thank you so much!


train.json

Hey, can you please explain how you obtained head, pos, and deprel in JSON files? In the raw file of SemEval, there is no such information, but in your code, you already have these attributes, which were not created in the code itself.
As I understood, these attributes should be created based on the LAL parser, but in the DualGCN code, this parser is used only to obtain the adjacency matrix and syntree.

您好，我想问一下，您运行出来结果了吗？
我运行出来的结果和论文中差了2%左右，而且 parser.add_argument('--losstype', default=None, type=str, help="['doubleloss', 'orthogonalloss', 'differentiatedloss']")这一句将损失类型改成doubleloss之后更低了是为什么呢？不知道您有没有遇到这个问题，期待您的回复，谢谢！


Use Stream-Style Serialization in azure-data-appconfiguration

Description
Converts azure-data-appconfiguration from using Jackson for serialization to using azure-json for serialization.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-data-appconfiguration

/azp run java - appconfiguration - tests

/azp run java - appconfiguration - tests

/azp run java - appconfiguration - ci


walking on snow from a regular block doesnt show a difference on the screen

shouldn't it since it's a difference in height?

if its only 1 layer, snow doesnt have a bounding box, check vanilla

if its only 1 layer, snow doesnt have a bounding box, check vanilla

nevermind thats right, but should the outline be shown for the whole block if its not a full block

This has nothing to do with snow, all blocks have the same cursor shape, the prerequist is to extract the interaction bounding box https://github.com/PrismarineJS/prismarine-web-client/issues/96


apollo.sh experimental_multi_threaded_digest

enable bazel's feature to compute md5 checksums in parallel.
docker/scripts/dev_start.sh brings in over a GB of map data. Then, the maps are globbed and turned into a file_group in https://github.com/ApolloAuto/apollo/blob/master/modules/map/BUILD#L3. bazel server will compute the md5 sums and keep it in memory the first time bazel build or bazel test runs on modules/map. Digesting these files takes longer as file sizes grow.
Running in parallel is much faster and doesn't seem to cause any problems.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[GHSA-m2qf-hxjv-5gpq] Flask vulnerable to possible disclosure of permanent session cookie due to missing Vary: Cookie header

Updates

Affected products
CVSS v3
CVSS v4
Description
Severity

Comments
My (@Satoramy) first succefully update from/with @GitHub so that we can work and rescue together.
@GitHub Zitat:
Improve: "Flask vulnerable to possible disclosure of permanent session cookie due to missing Vary: Cookie header"
Submitting improvements to this security advisory will create a pull request for the GitHub curation team to review and track.

Hi there @davidism! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

We try to Code with GitHub

This change appears to be invalid.


fix(ui): Backend integration for compliance reporting

Description

This PR includes some tweaks to the Compliance Reporting code to make things work. The backend fixes are still in progress so the filters don't 100% work yet. The completedAt time is still null too. Hoping backend fixes those soon, but the UI is in place.
User-facing documentation

[ ] CHANGELOG is updated OR update is not needed
[x] documentation PR is created and is linked above OR is not needed

Testing and quality

[ ] the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
[x] CI results are inspected

Automated testing

[ ] added unit tests
[ ] added e2e tests
[ ] added regression tests
[ ] added compatibility tests
[ ] modified existing tests
[x] no changes

How I validated my change

https://github.com/user-attachments/assets/d6895a96-15ac-4699-bf73-f14129796ffa

TODO: Fix unit test


Challenger Coin - Change name to avoid confusion with Challenge The Spire

As much as I like make references to "HERE COMES A NEW CHALLENGER!", Challenge The Spire exists, and I don't want people talking with the aldriedger about problems in that potion, they should be my responsability, not his annoyance.

Great, but which is the new name?

New Challenger. Sounds dumb, but it increases the chance of people recognizing the phrase and not associating it to Challenge The Spire.


Optimize VS Code when screen reader detected

Simial to how we will hide tabs when we detect a screen reader we could do other optimizations. For example:

Do not open Settings UI, but settings.json

I actually don't think opening settings.json instead of the settings pane is a good idea. While many items are self-explanatory, others might have more or better verbiage in the actual settings pane. Also, the Settings pane allows for better searching. That would be an "optimization" I would not be happy with. :-)

@MarcoZehe that is perfectly fair. Then I think we should probably improve some of the accessibility issues that the Settings pane faces today
fyi @roblourens

Do not open Settings UI, but settings.json

absolutely against it. I use json presentation myself, but this should remain a conscious choice.
The settings interface has certain accessibility issues, and they really should be fixed.

+1. settings.json by default is not a good thing. Also I am generally against forcing settings to be set in a certain way when accessibility is enabled, like some form of optout should be allowed in my opinion, even if defaults are explicitly customized because of screenreader being detected.

The example of this is folding. I believe I've heard/read somewhere that some time ago folding was disabled when screenreader was detected. I am not sure whether this is true because even enabled folding doesn't autofold without extensions it seems. I know it works now, but what I meant is, that you couldn't override that choice. Of course you can report each such case, but then you need to wait till the case is resolved.

Any change we due to optmise it will be possible to go back to the previous behavior.
But getting your feedback: we will not change the behavior of settings.
So for now will only disable tabs (which can of course be brought back via settings). Will let you know if I have more ideas

nice.

ok i don't know whether it’s necessary to create yet another issue but it would be great if the indicator about accessibility in the status bar could be turned off.

@alex19EP makes perfect sense, José already filed this issue so let's tackle that there https://github.com/microsoft/vscode/issues/96210

Thanks @isidorn For not forcing the settings.json upon screen reader detection. It would be amazing if the issues with accessibility pane will be fixed.

Thanks a lot for feedback. Due to the above we will not do any changes, except maybe the one for tabs which is captured via this item https://github.com/microsoft/vscode/issues/95682
Thus closing this.


cargo fails if if can't find optional dependencies, even if corresponding feature not enabled

I have a directory registry containing all the crate sources needed to build an application crate (for instance, ripgrep), and a $CARGO_HOME/config file that looks like this:
[source.crates-io]
replace-with = "dh-cargo-registry"

[source.dh-cargo-registry]
directory = "/usr/share/cargo/registry/"

When I attempt to build ripgrep via "cargo install ripgrep" from that directory registry, I get this error:
error: failed to compile `ripgrep v0.3.1`, intermediate artifacts can be found at `/tmp/cargo-install.rmKApOw9BwAL`

Caused by:
  no matching package named `simd` found (required by `bytecount`)
location searched: registry https://github.com/rust-lang/crates.io-index
version required: ^0.1.1

The directory registry indeed does not contain "simd"; however, bytecount doesn't require simd.  It has an optional dependency on simd, and nothing enables the feature that requires that dependency.
Placing the simd crate sources into the directory registry allows ripgrep to build; the resulting build does not actually build the simd crate.
I can reproduce this by just trying to build the "bytecount" crate directly, using the same $CARGO_HOME:
error: no matching package named `simd` found (required by `bytecount`)
location searched: registry https://github.com/rust-lang/crates.io-index
version required: = 0.1.1

(Incidentally, that "version required" seems wrong: bytecount has an optional dependency on simd ^0.1.1, not =0.1.1.)
However, this doesn't seem consistent with other crates in the same dependency tree.  For instance, ripgrep also depends on clap, and clap has an optional dependency on yaml-rust, yet cargo does not complain about the missing yaml-rust.
I'd guess that the difference occurs because ripgrep has an optional feature simd-accel that depends on bytecount/simd-accel, so cargo wants to compute what packages it needs for that case too, even when building without that feature. (Similar to #3233.)
However, this makes it impossible to build a package while installing only the packaged dependencies for the enabled features.  Could cargo install ignore any dependencies not actually required by the enabled feature?  (That behavior would make no sense for "cargo build", which builds a Cargo.lock file that should remain consistent regardless of enabled features, but it makes sense for "cargo install cratename", which doesn't build a Cargo.lock file.)

I have a patch written for this. I'll upload it as soon as I can test it more thoroughly, which will happen after the fix for #3368.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

The attached pull request implements this.

Hm this doesn't quite feel like the right fix to me, but I'll have to think about this. Basically all the code around resolve is extremely carefully sequenced and removing assertions like assert!(prev.is_none()) makes me quite wary.
In the meantime can you be sure to add a test case as well for this?

Ok so thinking through this a bit. This'll definitely cause problems with path overrides in play currently, unfortunately. The assumption behind path overrides is that there's always an existing locked dependency graph, and if not weird errors will start getting emitted. I believe we can fix this though by just not adding overrides during a cargo install, which makes sense to me at least that cargo install may not want to respect path overrides.
Other than that though I think this should work, and I definitely think it's worthwhile to fix!

:umbrella: The latest upstream changes (presumably #3221) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton Just updated this to latest Cargo, and expanded it to avoid adding overrides as you suggested.  Much easier in current Cargo with the changes to the resolve API; I kept it self-contained in the resolver without leaking out into cargo_compile.rs.
I also added three new tests: one for the simple case of cargo install from a directory registry, one for the simple failure case, and one for this case of an unavailable optional dependency.

Fixed matches of paths in output to pass on Windows.

I believe that the is_ephemeral returns true in two instances today, one during cargo package and one during cargo install. I therefore as-written this PR will introduce a regression where you can publish a crate (even if validation is enabled) with missing optional dependencies?

@alexcrichton Even if you had the optional dependencies, AFAICT cargo package doesn't do the test build with --all-features, so it already doesn't build-test with them.
However, if you consider that a problem, I can probably find a way to distinguish these cases.  (It might involve passing down some new parameter in the workspace.)

@alexcrichton The additional patch I just pushed distinguishes between "cargo install" and "cargo package", and only allows missing optional dependencies for "cargo install".  If that looks reasonable to you, I can squash it in.

@joshtriplett yeah that looks great to me, thanks! Want to squash it up?

@alexcrichton Done.

@bors: r+

:pushpin: Commit db71d87 has been approved by alexcrichton

:hourglass: Testing commit db71d87 with merge 1389b33...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 1389b33772b6f7e414ddb44485292e3a286527a2 to master...

Thanks!


An obvious typo.

Running the test without the fix results in:
>python p508.py
Traceback (most recent call last):
  File "p508.py", line 163, in <module>
    parsed = compiled(test).specification()
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\parsley.py", line 85, in invokeRule
    ret, err = self._grammar.apply(name, *args)
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 462, in apply
    val, err = self._apply(r, ruleName, args)
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1079, in rule_specification
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 598, in _or
    ret, err = f()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1071, in _G_or_376
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 1006, in rule_url_req
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 859, in rule_name
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 495, in _apply
    [rule(), self.input])
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 850, in rule_identifier
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 676, in consumedby
    _, e = expr()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 847, in _G_consumedby_294
  File "c:\Users\gabi\_envs\extra_test\lib\site-packages\ometa\runtime.py", line 554, in many
    v, _ = fn()
  File "/pymeta_generated_code/pymeta_grammar__Grammar.py", line 844, in _G_many_296
AttributeError: 'Grammar' object has no attribute 'rule_identifier_end'

This change is

I have used this commit in https://github.com/python/peps/pull/851. That repository now seems to be the canonical home of this PEP - does a copy still belong here? @dstufft ...?

This repo isn't used for anything any more, since the main PEPs repo migrated to GitHub.
I've filed https://github.com/pypa/interoperability-peps/issues/71 to discuss actually archiving it, to make it clear there's no need for anyone to keep it up to date.

Great, thanks

pep-0459-standard-metadata-extensions.rst


Hello in Tamil Language

What does the program do ?
Just a web page program to say Hello in the Tamil language.
In what programming language it is written?
HTML & CSS

Thank you for participating  in hacktoberfest ❣ if you liked working on this repo you can share it with friends and star this project for helping others


Only generate translated strings

When I generate the iOS Localizable.strings files for a language like german that has 50% translated strings I still get the default developer language (english) as the translated string in the resulting file. So when I upload the resulting file to a tool like OneSkyApp it thinks I have a 100% translation.
Is it possible to generate a Localizable.strings with only the strings that are actually translated?
File:
[[iOS]]
[Matches & News]
en = Matches & News
Resulting de language file:
/**

Apple Strings File
Generated by Twine 0.4.0
Language: de
*/

/********** iOS **********/
"Matches & News" = "Matches & News";

This has been implemented for Android with the --include-untranslated option and would be available to all formatters with #87.

@scelis close, pls


Repository no longer maintained - Alternatives to Mr data converter

This repository seems to no longer be maintained. Unfortunately or fortunately, the name "Mr data converter" comes to my mind and google very easily, and I'm often wasting a lot of time looking for the other good alternatives that exist out there.
Here is my favourite (works with fields containing quotes, commas, semicolons, line breaks, etc)

https://www.convertcsv.com/csv-to-json.htm

Feel free to comment following this post to add your favourite alternatives as a memento.

Our favourite is:

https://www.joecullin.com/data_converter/

We only use this tool to export from SQLDeveloper or spreadsheets to Redmine tables, and we find the interface very friendly to users.

There are several github forks of shancarter's version that were updated to get some of unresolved PRs merged and other features added, e.g.
https://github.com/thdoan/mr-data-converter

🚀 Hey there, Check Out My Universal Data Converter Web App! 🚀
Are you tired of wrestling with data in different formats? I've got just the solution for you! Introducing my brand-new web app, the Universal Data Converter.
What's In It For You?
🌐 Seamless Data Conversion: Say goodbye to format headaches.  Quickly convert your files hassle-free.
Ready to give it a spin? Just click here: Universal Data Converter 🌟
Don't miss out on this all-in-one data conversion and exploration tool. Give it a whirl and feel free to drop me a line with any questions or feedback. Happy converting! 🚀


version updates

removing 2.5 info from url names since this is evergreen content for all versions.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

docs/about-the-open-xml-sdk.md
:white_check_mark:Succeeded

docs/how-to-create-a-presentation-document-by-providing-a-file-name.md
:white_check_mark:Succeeded

docs/index.md
:white_check_mark:Succeeded

docs/open-xml-sdk-design-considerations.md
:white_check_mark:Succeeded

docs/open-xml-sdk.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/what-s-new-in-the-open-xml-sdk.md
:white_check_mark:Succeeded

docs/working-with-animation.md
:white_check_mark:Succeeded

docs/working-with-comments.md
:white_check_mark:Succeeded

docs/working-with-handout-master-slides.md
:white_check_mark:Succeeded

docs/working-with-notes-slides.md
:white_check_mark:Succeeded

docs/working-with-paragraphs.md
:white_check_mark:Succeeded

docs/working-with-presentation-slides.md
:white_check_mark:Succeeded

docs/working-with-presentations.md
:white_check_mark:Succeeded

docs/working-with-runs.md
:white_check_mark:Succeeded

docs/working-with-slide-layouts.md
:white_check_mark:Succeeded

docs/working-with-slide-masters.md
:white_check_mark:Succeeded

docs/working-with-wordprocessingml-tables.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


vscode: 1.78.0 -> 1.78.2

Motivation for this change
Upgrades vscode from 1.78.0 to 1.78.2
This PR was automatically generated by nixpkgs-upkeep.

CI workflow that created this PR.
Internal tag: 0aaee10fa7d767871255c1bd20cb01cf.

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

There should be https://github.com/NixOS/nixpkgs/pull/232280 which should done the vscodium bump as well :wink:

gotcha, closing!


Bug: Single Highlight Dialog Close Button not Working in new Browser Tab

Describe the bug
When clicking a single highlight link from an external webpage, the close button within the dialog does not respond as expected to the close action. The issue can be traced back to a specific code block within the repository:
Link to the Code Block
This problem appears to stem from the routing behaviour of the application. When the router attempts to route to a specific page, it fails to do so when the page is opened in a new tab. This is because there are no browsing history entries to navigate back to in the new tab instance.
Proposed Solution
To address this issue, we need to consider the routing behaviour when allowing the dialog to close and route to the /feed page. The current condition for closing the dialog may need to be modified to account for scenarios where the page was opened in a new tab. By factoring in this behaviour, we can ensure that the dialog behaves as expected even when accessed through external highlight links.
Steps to reproduce
https://github.com/open-sauced/insights/assets/106407013/b9051be5-2694-4265-abd6-90f2a6daed7c
Browsers
Chrome
Additional context (Is this in dev or production?)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

Hey @RitaDee
Thank you for picking this one out, I worked on a PR that introduced that part to the code base, this is some case I would've sworn was already addressed in the routing conditions.
Thank you once again for pointing this out, I will patch a fix for it.
.take


Not finding dependency

You need to update your mod to look for Tesla's new mod ID, which is tesla in all lowercase. Right now, it can't find it, since Force mod IDs are case-sensitive.

I am also having this issue.

Fixed, download Tesla Coils version <IP_ADDRESS>


ProcessProposal: avoid calls when we know one correct process has already accepted it

In the current implementation of ProcessProposal (and spec?), it is called just after doing Comet-level validations on the received proposal block.
However, there are some cases where the local node can conclude that the received proposal has already been processed and accepted by another correct node's ProcessProposal.
Since ProcessProposal's main goal is to detect and drop bad proposals from byzantine validators, calling ProcessProposal on a proposal that we know has passed ProcessProposal elsewhere is, at minimum, suboptimal.
These are the cases where we know ProcessProposal has already accepted the proposal at some correct node:

If the proposal's POLRound is -1 and the proposed block matches the one locally locked (part of line 23 of the arXiv algorithm)
If the proposal's POLRound is not -1 and less than the current round, and

we have received 2f+1 (worth of voting power) valid prevotes for the proposed block in POLRound, and

either POLRound is greater than or `LockedRound?
or the proposed block matches the one locally locked
(line 29 of the arXiv algorithm)

If the proposed block matches our ValidBlock

In the arXiv algorithm, this is equivalent to removing $valid(v)$ from line 29, and changing line 23 as follows:
if $(lockedRound_p = −1 ∧ valid(v)) ∨ lockedValue_p = v$ then.
Also, we assume that $valid(v)$ does not include ProcessProposal in lines 36 and 50 (do we really need to call $valid(v)$ at all there?).
This is a similar reasoning to the one followed to minimize calls to timely in the Proposer-Based Timestamp (PBTS) specification.
@hvanz @lasarojc @BrendanChou

We can go even further than proposed. The minimal condition would be receiving $f+1$ (worth of voting power) valid prevotes messages from different validators for the proposed block. They can even be from different rounds because, from the perspective of the ABCI, ProcessProposal for the same block should always return the same result no matter the round. This is true because due to the determinism requirements, the output of ProcessProposal should exclusively depend on a) the state of the app at the beginning of the current height and
b) the data passed in the ABCI call. Consequently, as we do not pass round information in ProcessProposal and we talk about the same height, the output needs to be the same.
Since all proposed cases satisfy the minimal condition presented here, they are safe.

If the proposed block matches our ValidBlock

In terms of the pseudo-code, the final version of lines 23 and 29 would be:
23: if $(lockedRound_p = −1 ∧ valid(v)) ∨ lockedValue_p = v ∨ validValue_p = v$ then
and
29: if $lockedRound_p ≤ vr ∨ lockedValue_p = v ∨ validValue_p = v$ then
Is it correct?

Seems correct. But to make it explicit the short-circuiting that should take place, maybe we should 23 as
23: if validValuep=v ∨ (lockedRoundp=−1∧valid(v)) ∨ lockedValuep=v then
This will avoid the check if lockedRound = -1 but valid is already set to v.

Is it correct?

Thanks, I realise my intitial pseudocode didn't account for $validValue$. I think it's not 100% correct, because $validValue$ should only affect the execution of $valid(9v)$ not what we end up prevoting.

23: if (lockedRoundp=−1 && (valid(v) || validValuep=v)) &&  lockedValuep=v then

We can go even further than proposed. The minimal condition would be receiving f+1 (worth of voting power) valid prevotes messages from different validators for the proposed block. They can even be from different rounds because, from the perspective of the ABCI, ProcessProposal for the same block should always return the same result no matter the round. This is true because due to the determinism requirements, the output of ProcessProposal should exclusively depend on a) the state of the app at the beginning of the current height and b) the data passed in the ABCI call. Consequently, as we do not pass round information in ProcessProposal and we talk about the same height, the output needs to be the same.
Since all proposed cases satisfy the minimal condition presented here, they are safe.

Thanks for your comment, @nenadmilosevic95
We agree with you that the condition might be simplified, with implications in lines 23, 29, 36, and 50.
However, since stronger conditions are already required in lines 28, 36, and 49, there would be no gains there, unless these conditions are also weakened, which would require really changing the algorithm and is out of the scope of this PR.
There could be gains in line 23, but that would require more involved changes and would also help only in the uncommon case of needing multiple rounds to decide. Hence we need to further discuss this change as well, possibly in the context of porting PBTS. It is non-blocking for this PR.
Also, I would like to note that even if ProcessProposal is non-deterministic, your proposal would be valid. The reason is validator don't reject invalid proposals, but simply abstain from voting on them. So as long as votes grow across rounds, at some point the value will be considered valid without querying the app, but this should also be further discussed in the context of porting PBTS and closing #1174


Log home files reorganization

This is for OWLS-97329 to provide option to organize the files in logHome differently.  By default, in this PR, files are organized by server name similar to on premise structures (servers/server name/logs/),  A logHomeLayout provides a way to set it back to current ways where all files are at the top level.
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10225/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10281/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10282/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10283/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10292/

Are ItIstioCrossClusters and ItIstioCrossClustersSetup are added as new files although they exist already?  Is this right?  Can't see its relationship to log home layout.


online learing support？

this work very smart,  support many algorithm and data formate，
in the actual work ，training data may be millions data and millions samples，
can this supoort algorithm for online learning?

Thank you.
I had thought about online learning algos, but this would require many of the algorithms to be re-written . The short answer is I don't plan to do this,  but if there is demand for it I could consider it.

Just a note to say that vowpal wabbit (that supports online learning) has now been added. Although the training happens online, StackNet will still require to put data into memory. In any case, it should use less memory than other methods.


Create ModularArithmetic.cpp

issue -  #399
Performing operations on larger input constraints of 10^50000, with given mod value, coded by GSSoC2021 participant.

"Also provide the link of your code in the appropriate folder", can u plz help with this?

@tarun26091999 plz check again.

@OjusWiZard Completed the requested changes, please review this again.

When will my PR get merge @OjusWiZard ?


[FLINK-19265][FLINK-20049][core] Source API final adjustments

Purpose / Brief change log
This adds convenience methods for the common actions around split requesting, rather than requiring every source to implement the event handling themselves.

To simplify split requests, this adds SplitReaderContext.sendSplitRequest() and SplitEnumerator.handleSplitRequest().
To simplify dealing with a finite amount of bounded splits (all batch use cases), this add SplitEnumeratorContext.signalNoMoreSplits() and SourceReader.notifyNoMoreSplits().
The PR removes the RequestSplitEvent and NoMoreSplitsEvent.

Verifying this change
This change is API rework and covered by existing tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no (only API extensions)
If yes, how is the feature documented? JavaDocs

@rmetzger and @dianfu This is not a new feature, but a conclusion of an API polishing / evolution.
Getting this into 1.12 would mean we don't have to break the API again in 1.13.
Does this qualify for an exception to be merged after feature freeze?

@StephanEwen I tend to think that we should get this into 1.12 to avoid breaking the API again in 1.13. +1 from my side.

I'm also fine, since the source API is still marked as beta

Manually merged in 0e281f75386fad5fb2c0c3b10e246b37d02e432d


Wrong suggestion

Here it should not suggest anything because module N is in scope.

Mhm this is interesting. Here the compiler is emitting 2 different errors. First the FS0039 for module N and then FS0599 ("Missing qualification after .") at the .
Tbh I think the FS00039 itself is not correct and the suggestion is just an aftereffect.

@vasily-kirichenko can this be closed now that #2218 is merged?

I confirm the bug has been fixed.


maf2maf for VarScan tab delimited output

Would it be possible to make maf2maf work for the standard tab delimited varscan output? VarScan output is not the same as MAF, but it's similar, as it's tab delimited. Positions are the same as in the VCF format. I can share a sample file if that helps.
Floris

At this link you'll find a sample minimalist MAF file that maf2maf accepts. And for comparison, this link lists the fields in VarScan output. For the most part, it looks like you'll simply need to change the column names to get maf2maf to work. To have maf2maf to parse out allele-counts, you can set --nrm-rad-col normal_reads1, --nrm-vad-col normal_reads2, --tum-rad-col tumor_reads1, etc.

The biggest issue I think is the difference in start/end/ref/var reported in MAF compared to VCF and VarScan output. The VarScan output is more similar to VCF (the positions reported are the same) but there are still some major differences. I use the following R-code to convert the VarScan output to MAF(lite):
signs = substr(f$alt_allele,1,1)
vartype = sapply(signs, function(sign) {
if(sign == '+')
return('INS')
else if (sign == '-')
return('DEL')
else if (length(sign) > 0)
return('SNP')
else
stop("No sign")
})
idx = which(vartype == 'INS')
f$start[idx] = f$start[idx]
f$end[idx] = f$start[idx] + 1
f$ref_allele[idx] = "-"
f$alt_allele[idx] = substr(f$alt_allele[idx],2,nchar(as.character(f$alt_allele[idx])))
idx = which(vartype == 'DEL')
f$start[idx] = f$start[idx] + 1
f$ref_allele[idx] = substr(f$alt_allele[idx],2,nchar(as.character(f$alt_allele[idx])))
f$alt_allele[idx] = "-"
f$end[idx] = f$start[idx] + nchar(f$ref_allele[idx]) - 1

Is there a reason you don't want to use the VarScan VCF format output? I can help you troubleshoot whatever that reason may be. Otherwise, this is a feature request, which will take time.

It's not a big issue. I've solved this issue for my own use using scripts in between but I'm guessing other people might be running into the same issue. VarScan post-processing modules are designed better to deal with native input than VCF input and don't always have the option to output VCF.

A lot of VarScan's downstream false-positive filtering steps have been implemented in this script which supports VCFs. Also lookup bcftools annotate and bcftools filter which are much more powerful for merging and post-processing VCFs.

Varscan still has problems with its VCF format as of v2.4.2.

@tedtoal As described above, only MAF-like or VCF-like allele representations are supported. If you still think there's a problem, please open a new issue, with a sample input file to help reproduce it.


Thank You

I just wanted to extend my gratitude for this setup, it inspired me to move my neovim implementation into nix and it is a very wonderful setup (https://github.com/lecoqjacob/andromeda-neovim)! I really wanted to figure a way to use lazy.nvim for plugin management and I think i found a nice system to pull from local nix plugins and only fetch git plugins if needed. Anyway thanks :) I was struggling for a while on the best setup

Oh wow! I'm going to have to check this out! Thanks for telling me about neoconf btw. I added it cause it was in the fork you made. You really made it your own though and that makes me happy.

Also I added your repo to the readme :)

Probably shoulda asked if that was ok with you first idk but, it seemed like a thing to do.


Issue with react-native-safe-area-context

After upgrading my react native version to 0.67.3, i got this error
dependencies
"react": "17.0.2",
"react-native": "0.67.3",
"rn-wave-bottom-bar": "^2.1.1"
"react-native-safe-area-context": "^4.1.2",
"@react-navigation/bottom-tabs": "^6.2.0",

It's working now but i had to downgrade "react-native-safe-area-context" to ^3.4.1"
latest version (^4.1.2) causes the error above

Thank you for the report, will give a check very soon

We are facing same issue


Review settle functionality

I have created a new branch for multi-auctions with an updated Justice.sol + tests. The biggest changes are (i) passing in uint256 auctionId to createBid() and settledAuction() and (ii) an additional uint256 auctionId being emitted in the AuctionCreated event.
This shouldn't be too much work to integrate (though it is some, because it necessitates updating our subgraphs too).
However, there is a severe trade-off at work here: https://github.com/PrisonArt/restore/blob/multi-auctions/packages/hardhat-ts/contracts/Justice.sol#L111
We have to make createBid() more expensive in terms of gas because we're no longer able to work with the latest auction simply in memory... I will look at trying to estimate gas so that I can report more exact numbers here.
For this reason, I'm kinda against doing it, though it does provide us flexibility and gives us the chance to run many auctions all at once, without needing to settle before beginning anew. That said, it is possible to simply deploy this version of Justice.sol, point Restore.sol at it instead, and update the frontend code when/if it ever becomes necessary (though I am also aware that not doing it now and trying to remember everything and pick up the context we now have in our on RAM will be difficult if this is something we only return to in a few years

OK, gas reporter works well. For multi-auctions, with use of storage:
·----------------------------------------------------|----------------------------|-------------|-----------------------------·
|                Solc version: 0.8.7                 ·  Optimizer enabled: false  ·  Runs: 200  ·  Block limit: 30000000 gas  │
·····················································|····························|·············|······························
|  Methods                                                                                │
····················|································|··············|·············|·············|···············|··············
|  Contract         ·  Method                        ·  Min         ·  Max        ·  Avg        ·  # calls      ·  usd (avg)  │
····················|································|··············|·············|·············|···············|··············
|  Justice          ·  createAuction                 ·      158860  ·     175960  ·     174645  ·           13  ·          -  │
····················|································|··············|·············|·············|···············|··············
|  Justice          ·  createBid                     ·       58918  ·     135589  ·      90721  ·           12  ·          -  │
····················|································|··············|·············|·············|···············|··············
|  Justice          ·  settleAuction                 ·       65837  ·     125535  ·     101656  ·            5  ·          -  │

For auctions as they currently are, only in memory:
·---------------------------------------|----------------------------|-------------|-----------------------------·
|          Solc version: 0.8.7          ·  Optimizer enabled: false  ·  Runs: 200  ·  Block limit: 30000000 gas  │
········································|····························|·············|······························
|  Methods                                                                                │
····················|···················|·············|··············|·············|···············|··············
|  Contract         ·  Method           ·  Min        ·  Max         ·  Avg        ·  # calls      ·  usd (avg)  │
····················|···················|·············|··············|·············|···············|··············
|  Justice          ·  createAuction    ·      80015  ·      153215  ·     147584  ·           13  ·          -  │
····················|···················|·············|··············|·············|···············|··············
|  Justice          ·  createBid        ·      65699  ·      142371  ·      96888  ·           13  ·          -  │
····················|···················|·············|··············|·············|···············|··············
|  Justice          ·  settleAuction    ·      63385  ·      105983  ·      88944  ·            5  ·          -  │


Does Kong cluster have an virtual IP?

I have setup Kong cluster 2 node successfully. Does Kong cluster have an virtual IP, so I can point the DNS record to that IP? If 1 node die, another node will handle that virtual IP.
Or I must use HAProxy to load balancing between 2 nodes?

Kong just listens on the local port you configure, that's it. You have to create your own setup to spread your incoming traffic over the Kong nodes you have running.


Docs

I'm trying to set up a plausible instance and I would like to manage it via Dokku.
Is this plugin already working? If so, are there documentation or a blog post to check?
Happy to help if you need a hand.

I changed my approach (dokku app instead of dokku plugin) and added setup guide.
I successfully deployed it on my dokku instance and started using it. (Everything work fine)
So feel free to follow the guide and ask for clarification or improvements by creating issue in case of problem or missing elements.

thanks for sharing the setup guide @D1ceWard I will give it a try.


"SQLite3::SQLException: row value misused" because of nested parenthesis

I have a relation as follows:
            gateway.create_table(:case_journal) do
              primary_key :id
              column      :severity,     Integer,  index: true
              column      :type,         String,   index: true
              #...
            end

With something as simple as this:
  types = %w[OPERATIONAL TECHNICAL]
  severities = [1,2,3]
  case_journal.where(type: types).where { severity.in severities }.count

I get:
SQLite3::SQLException: row value misused: SELECT count(*) AS 'count' FROM `case_journal` WHERE ((`type` IN ('OPERATIONAL', 'TECHNICAL')) AND (`case_journal`.`severity` IN ((1, 2, 3)))) LIMIT 1

The problem is the ((1, 2, 3)) part of the SQL query. SQLite3 does not like nested parenthesis.

Ruby version: ruby 2.6.5p114 (2019-10-01 revision 67812) [x86_64-linux]
OS: Ubuntu 18.04

Sorry, my mistake. The values have to be splat: where { severity.in(*severities) }
Doc: https://www.rubydoc.info/github/rom-rb/rom-sql/ROM%2FSQL%2FAttribute:in


[don't merge] Checking if --disable-hang-monitor helps

/botio-linux test

/botio-linux test

/botio-linux test

/botio-linux test

/botio-linux test

/botio-windows test

/botio test

/botio test

It looks like Windows and Chrome might work together again. It's strange that Linux and Chrome have an intermittent issue, but if we can switch Chrome testing to Windows (and open a tracking issue for the Linux bot), then I think we can at least continue for now.