Jade problem with Express+Angular

Hi,
I'm a new learner, and recently I'm trying to do something with MEAN(mongodb, express, angular, node)
For the template, I used Jade. And I found a problem with angular+express+jade:
As I can't send jade to browser, I write like this in Angular's route.js
angular.module('myApp')
.config([$routeProvider, $locationProvider,function($routeProvider, $locationProvider){
$routeProvider.when('/', {templateUrl: '/', controller: 'indexCtrl'})
.when('/errror', {templateUrl: '/error', controller: 'errorCtrl'})
...
well, templateUrl in angular's route.js is matched with express router.
and I write an ajax method in errorpage, I just wanna try the ajax communication with angular and express.
I write like this in express' route.js
var express = require('express');
var router = express.Router();
...
router.get('/error', function(req, res, next) {
res.render('error.jade');
});
router.post('/error', function(req, res, next){
console.log('I have recieved ajax request.');
res.json({ state: 'success' });
});
...
And I just found that , when i jump to error page, the ajax request send automaticlly although I haven't call the ajax method !!!
I really wanna know what problems in it.
And I don't think my angular route.js is a good design. But I haven't found another solution when using jade.
So, 2 questions:

how to solve that problem?   (ajax req  send auto)
Any better solution when using jade in angular?

I really hope for any replies.

I have a button in index.jade, and it will jump to error page
I just name the page error, not truly error, I just wanna test the ajax communication and routing.

The templateUrl is meant to be the path to the file where the template resides. You should specify a html template file that you are using. Alternatively you can use template and specify the template inline. The inline solution is only used when you are doing something short like <ui-view> as your template.
Read: https://www.amazon.co.uk/MEAN-Web-Development-Amos-Haviv/dp/1783983280
Jade will only compile the stuff that you tell it to. Usually you'll use something like gulp/grunt/npm to trigger jade and supply the the paths to be compiled.
If you're compiling your angular templates using jade, you'll need to tell angular the path to the complied output.
It will short you out (without Jade). You should be able to put Jade into the mix once you have this as a foundation.


VS Code update issue

Type: Performance Issue
currently i am facing this issue, whenever i want to update my vs code its not updating
VS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T15:06:02.407Z)
OS version: Windows_NT x64 10.0.22000
Modes:

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

/needsMoreInfo
Please describe steps you take, actual and expected results.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Is https://github.com/microsoft/vscode/issues/190221#issuecomment-1674221246 relevant?


Add Kubernetes style label selector for annotation based filtering

Closes #49
This PR is similar to #85, it filters the resources using a Kubernetes style label selector, against the resource annotations.
It has a breaking change on the short command -a, now this will be used for the annotation filtering instead of the type filtering.
This breaking change force us releasing v2.x

Codecov Report

Merging #86 into master will increase coverage by 0.14%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   77.07%   77.21%   +0.14%
==========================================
  Files          20       20
  Lines         842      856      +14
==========================================
+ Hits          649      661      +12
- Misses        147      148       +1
- Partials       46       47       +1

Impacted Files
Coverage Δ

internal/resource/process/kubemeta.go
88.23% <87.50%> (-0.66%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea1e78...c221bc3. Read the comment docs.


Use Vercel Build Output API in GitHub actions

Is your feature request related to a problem? Please describe.
It's pretty annoying to wait for build of the project in GitHub Actions and wait again to make the same build in Vercel (usually stuck in queue due to lack of parallel builds).
Describe the solution you'd like
We could use the newly announced Vercel Build Output API and vercel deploy --prebuilt comamnd to push the build artefacts from Next.js created in GitHub Actions directly to Vercel
Describe alternatives you've considered
Don't build the app in GitHub actions, as it's already done by Vercel (fail would be visible in PR).  However this doesn't help with builds stuck in queue.

I think we still need to build apps in GitHub Actions so that we can run other checks: tsc, eslint and paths


Quantum RPG: Error on death after entering the hole

enter hole
You feel your entire existence dissolve into errors
as you are pulled apart into static and random bitstrings.
Traceback (most recent call last):
File "./unitary/examples/quantum_rpg/main_loop.py", line 140, in loop
msg = action(self.game_state, self.world)
File "/home/cantwellc/projects/unitary/env/lib/python3.7/site-packages/unitary/examples/quantum_rpg/final_state_preparation/classical_frontier.py", line 106, in _hole
"You feel your entire existence dissolve into errors\n"
unitary.examples.quantum_rpg.exceptions.UntimelyDeathException: You feel your entire existence dissolve into errors
as you are pulled apart into static and random bitstrings.

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "./unitary/examples/quantum_rpg/main_loop.py", line 236, in
main(game_state.GameState(party=[]))
File "./unitary/examples/quantum_rpg/main_loop.py", line 232, in main
main_loop.loop()
File "./unitary/examples/quantum_rpg/main_loop.py", line 179, in loop
print(ascii_art.RIP_TOP, file=self.file)
AttributeError: module 'unitary.examples.quantum_rpg.ascii_art' has no attribute 'RIP_TOP'

Hmm... is your installation okay?  I cannot reproduce it.  This variable exists:
https://github.com/quantumlib/unitary/blob/main/unitary/examples/quantum_rpg/ascii_art.py#L88
Can you pull main and see if this still exists?

I just saw the same error when slimes killed me. I see RIP_TOP in ascii_art.py

I suspect that it could be an issue with your environment.  How are you running it?  Is it possible you have an older branch or some sort of conflicting python path?
I can't reproduce it with a virtualenv on main or with the colab.

I forked the unitary repo to my personal. My fork is up to date, and my local is up to date with my github fork.
Running in Windows subsystem linux, in a virtualenv with python 3.7.5
It is very possible it could be a conflicting python path. I don't use python very often, maybe I set it up wrong

I don't recall seeing these errors when I died yesterday

Also, I'm trying to load this save and it isn't working.              ValueError: invalid literal for int() with base 10: ''
classical12;2;Q#Analyst#3#X0.250000,1#Z0.125000,2#Z0.250000,1#X0.375000,2#H1.000000,1#Z0.125000,2;Zed#Engineer#2#Z0.125000,1#X0.250000,2#X0.250000,
So I have to start over. Do you have a different save string I can try to quickly test?

It looks like the cut and paste missed the last character.  Try this:
classical12;2;Q#Analyst#3#X0.250000,1#Z0.125000,2#Z0.250000,1#X0.375000,2#H1.000000,1#Z0.125000,2;Zed#Engineer#2#Z0.125000,1#X0.250000,2#X0.250000,2

That works, thanks. My game has no problem with the other things in ascii_art.py, so it seems odd to me that RIP_TOP is a problem

I tried a fresh install and it works now.

Great!  Thanks for all the detailed testing and issue filing!  It is very helpful in making the game more robust!


Exporting STL from web app produces file unreadable by orcaslicer

[Add a title above and insert a description of the issue here]

I exported this model as an STL file, but when I try to import it to orcaslicer, I get an error saying the file doesn't contain any geometry data.  However, if I export as a STEP file, it works fine.

Core Dump
coredump-d5ad8c5b-6329-4d5c-aef2-b5935776885c.json
Reference ID: d5ad8c5b-6329-4d5c-aef2-b5935776885c

I think this is the dupliocate file execution bug

can you paste the code please?

const holeFudge = 0.4
const frontBarD = 5.0
const yBarD = 6.7
const lowerBlockHoleD = frontBarD + holeFudge
const upperBlockHoleD = yBarD + holeFudge
const tubeClr = 1.5
const lowerBlockH = lowerBlockHoleD + 2 * tubeClr
const upperBlockH = upperBlockHoleD + 2 * tubeClr
const elevateH = 20
const upperBlockL = 25
const lowerBlockL = 35
const length002 = upperBlockL
const blockSz = max(upperBlockH, lowerBlockH)
const sketch001 = startSketchOn('XZ')
  |> startProfileAt([0, 0], %)
  |> xLine(upperBlockL, %, $edge1)
  |> yLine(-(elevateH + blockSz), %, $edge2)
  |> xLine(lowerBlockL - blockSz, %, $edge3)
  |> yLine(-blockSz, %, $edge4)
  |> xLine(-lowerBlockL, %, $edge5)
  |> yLine(blockSz + elevateH, %, $edge6)
  |> xLine(-(upperBlockL - blockSz), %, $edge7)
  |> lineTo([profileStartX(%), profileStartY(%)], %, $seg01)
  |> close(%)
  |> hole(circle([
       upperBlockL + lowerBlockL - blockSz - (lowerBlockHoleD / 2) - tubeClr,
       -(blockSz + elevateH + blockSz / 2)
     ], lowerBlockHoleD / 2, %), %)
const rad = 3
const extrude001 = extrude(blockSz, sketch001)
  |> fillet({
       radius: rad,
       tags: [
         getNextAdjacentEdge(edge2),
         getNextAdjacentEdge(edge3),
         getNextAdjacentEdge(edge4),
         getNextAdjacentEdge(edge5),
         getNextAdjacentEdge(edge6)
       ]
     }, %)

const sketch002 = startSketchOn(extrude001, seg01)
  |> startProfileAt([0, 0], %)
  |> circle([blockSz / 2, blockSz / 2], upperBlockHoleD / 2, %)
const extrude2 = extrude(-upperBlockL, sketch002)

okay whoa this helps this is def an export bug, cc @alteous

@yeroca , thanks for reporting! This was a fun one to debug. :smile:
I was able to reproduce the issue and found both a workaround and a solution. The workaround is to export binary STL instead, which does work. There is an option for this in the export tool:

I believe the issue is with OrcaSlicer's ASCII STL importer which is built on top of an older library called admesh. Specifically, it has an upper limit on the number of digits for components in a normal vector:
char normal_buf[3][32];
...
fscanf(fp, " facet normal %31s %31s %31s", normal_buf[0], normal_buf[1], normal_buf[2]);

For compatibility with admesh, we could truncate our normals to 10 decimal places. That should be more than enough precision anyway. This allowed the file to load when I tried locally.

For future reference, the offending line was:
facet normal -1 0.0000000000000000000000553211 0.00000000000000017587692

Interesting!  Thanks for the info.  So much for being precise! (in ASCII at least)
Checking my existing STL files produced by OpenSCAD, I see they are all binary.  I never bothered to look inside them before.

we will get the fix pushed by tomorrow AM!

fix is deploying!

I just tried it and it is now fixed thanks @alteous and thanks for letting us know @yeroca !


Search - Blue border on the group expense is cut off when the expense is selected

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:

Go to staging.new.expensify.com
Submit two expenses to any user.
Go to Search > Outstanding.
Use keyboard to navigate to the group expense in Step 2.
Select an expense via checkbox.

Expected Result:
The blue border on the group expense will not be cut off when the expense is selected.
Actual Result:
The blue border on the group expense will not be cut off when the expense is selected.
Workaround:
Unknown
Platforms:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/ae5b29f6-a5e0-4b14-a38e-23d25770ecbf

View all open jobs on GitHub

We think that this bug might be related to #wave-control

@OfstadC  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal
Please re-state the problem that we are trying to solve in this issue.
The blue border is cut off when the expense is selected.
What is the root cause of that problem?
The outline is using an inset box shadow.

The problem here is that the children, that is the expense item, have the same width as the report container, and when selected apply a background color that covers the box shadow of the parent.

It's different with the single expense item where the background color is applied to the button itself, instead of its children.

What changes do you think we should make in order to solve the problem?

Add at least 1px horizontal padding for the outline.
https://github.com/Expensify/App/blob/6d8e739f7b1c286ae65565a6689b27b5983fe48a/src/components/SelectionList/Search/ReportListItem.tsx#L84-L87

Is this open to apply?

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0157329c1f227d8320

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~0157329c1f227d8320

Proposal
Please re-state the problem that we are trying to solve in this issue.
Search - Blue border on the group expense is cut off when the expense is selected
What is the root cause of that problem?
We use inset position  for shadow so the child elements cover the shadow. See here.
What changes do you think we should make in order to solve the problem?
We can just use outset shadow instead of inset from shadow . To do that we can remove the word inset from here.  This option will help us solve problems on a global scale, as we may encounter such behavior in other places as well.
What alternative solutions did you explore? (Optional)
If we don't want to change the shadow position globally, we can use outset for this element only.

Proposal
Updated Added details of alternative solution. @rayane-djouah could you check please

I will create PR Tomorrow

@rayane-djouah Please complete the BZ checklist by the payment date. Thanks! 😃

All paid out!


Added "contains" scaling mode.

Scaling.contain was missing from the scaling options. It basically functions like Scaling.fit if the image is too big to fit in the defined space, but will act like Scaling.none if it does fit. This means it will only scale the image down and never up. Useful for icons that are usually all the same size but also allowing you to use icons that are oversized without having to worry about the image spilling over into the rest of the UI.

@Emperorlou thank you for you contribution.
Before one can dig deeper into the code, can you fix the style? So it is easier to review?

To be honest I don't know how. I even tried editing the file directly in
GitHub and pasting in only the changed lines and it still did this
nonsense. I assume it's a line ending issue..
On Fri., Oct. 30, 2020, 11:14 p.m. Yuri Pourre<EMAIL_ADDRESS>wrote:

@Emperorlou https://github.com/Emperorlou thank you for you
contribution.
Before one can dig deeper into the code, can you fix the style? So it is
easier to review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/6257#issuecomment-719891187, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACM6HE4FMSPNDOP63JI2EDSNOTN5ANCNFSM4TFG35QA
.

I tried fixing them for you, but unfortunately you don't have _Allow edits and access to secrets by maintainers
_ enabled

It is the old crlf problem, it is fine for me. You can set GH to ignore whitespaces to see the real changes.
I like the addition, and it is missing. The only thing that could be improved is naming and JavaDoc. I know the JavaDoc goes conform with the other ones, but I always have to read twice to understand.
I checked, Android names the same scaling approach "centerInside" with the following doc:

Scale the image uniformly (maintain the image's aspect ratio) so that both dimensions (width and height) of the image will be equal to or less than the corresponding dimension of the view (minus padding). The image is then centered in the view.

Ah that's too bad about the naming convention because Android's variant
isn't as sussinct imo. Contain is used in CSS for the background-size
attribute, which also includes fit and cover iirc.
As for javadoc, I'm not sure where that lives.
On Sat., Oct. 31, 2020, 4:03 a.m. Benjamin Schulte, <
<EMAIL_ADDRESS>wrote:

It is the old crlf problem, it is fine for me. You can set GH to ignore
whitespaces to see the real changes.
I like the addition, and it is missing. The only thing that could be
improved is naming and JavaDoc. I know the JavaDoc goes conform with the
other ones, but I always have to read twice to understand.
I checked, Android names the same scaling approach "centerInside" with the
following doc:
Scale the image uniformly (maintain the image's aspect ratio) so that both
dimensions (width and height) of the image will be equal to or less than
the corresponding dimension of the view (minus padding). The image is then
centered in the view.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/6257#issuecomment-719918394, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACM6HDDXRXSGWTW55CTJYDSNPVIJANCNFSM4TFG35QA
.


Brave Talk icon on Chrome Web Store should be transparent

Summary:
Brave Talk icon on Chrome Web Store should be transparent
Steps:

new profile
launch Brave
load https://chrome.google.com/webstore/detail/brave-talk-for-google-cal/nimfmkdcckklbkhjjkmbjfcpaiifgamg
open brave://settings/appearance
choose Dark
back on the Google Chrome Store, click on Add to Brave
look at the resulting Brave Talk icon

Actual Results:

Expected Results:
Should have transparency, so there's no white-on-black-background in the icon.
cc @rebron @bradleyrichter @mrose17 @tackley

it appears to be an issue on the chrome store itself. i'm having difficulty uploading now, but, in dark mode, go to https://chrome.google.com/webstore/detail/save-to-google-drive/gmbmikajjgmnabiglmofipeabaddhgne and click on "Add to Brave" and you'll see the google drive icon show up with a white square underneath. i've seen this on other extensions.

This is a "can't-fix". the issue appears to be with the google chrome store itself, here's an example of what you see with an extension written by google themselves...

Note that we experimented with a couple of PNGs known to have a transparent background, and still no luck.


Applies to section doesn't list Server

Servicing Stack Updates are required for doing updates on recent versions of Windows Server, as well. Either add them to the applies to list or link to an article targeting Server OS.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b706f0af-d504-a8ca-7c38-b8bb9283bfad
Version Independent ID: 14f31acf-9f47-59a6-269f-62ab249fe560
Content: Servicing stack updates - Windows Deployment
Content Source: windows/deployment/update/servicing-stack-updates.md
Product: w10
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

@npherson Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/windows-itpro-docs/pull/10990
Once the author approves, the changes will be live.
Thanks
Sri


add yajl dependency

Background:
User tries to save invalid JSON
Error:
$ EDITOR=vim knife solo data bag edit apps app_1
ERROR: knife encountered an unexpected error
This may be a bug in the 'solo data bag edit' knife command or plugin
Please collect the output of this command with the `-VV` option before filing a bug report.
Exception: NameError: uninitialized constant Yajl

👍
Had this problem too, this fix lets the JSON parser error through (pesky newlines). 😉

Thanks for the PR and sorry for the late response. I believe that the problem you were having was solved in 7f3912116d.
Closing for now. If you believe there is still an issue, feel free to reopen.


Move tracing package under core

Move tracing plugin package under core like other netty, http packages
Move samples from tracing package to their respective client folders.
Sort out the dependencies between core and the package

Requesting that tracing should only depend on azure-core.  Thus releasing tracing should not be blocked by other projects except  azure-core.


Cardano Explorer. Highlighting effect for Social Media Icons

Cardano Explorer. Highlighting effect for Social Media Icons

no no no
it should be 50% from the beginning and 100% on hover

no no no
it should be 50% from the beginning and 100% on hover

Fixed

In future @DeeJayElly, please highlight any additional changes in the PR description. In this case it's worth noting the link fix for the IOHK icon


fix: setting global config when using db config provider

Problem
Setting global config when using db config provider allows creating the same config name over and over again. e.g.
❯ ftl config set KEY "OKAY1" --db

❯ ftl config get KEY
"OKAY1"

❯ ftl config set KEY "OKAY2" --db

❯ ftlprod config get KEY
"OKAY1"

running ftl config list reveals the problem:
❯ ftlprod config list
KEY
KEY

This problem occurs because of the compound unique constraint here.
In PostgreSQL, NULL values are treated as distinct, so when you have a unique constraint on multiple columns where one of the columns can be NULL, each NULL is treated as a different value. This means that multiple rows can have NULL in the module column and the same value in the name column without violating the unique constraint.
Fix
This PR proposes treating a NULL module value as '' when creating the unique compound constraint

[!NOTE]
I believe the following would also work

ALTER TABLE module_configuration
    ALTER COLUMN module SET DEFAULT '';

[!NOTE]
I went with '' to prevent colliding with potential module names and i chose not to default module to '' to prevent application code from treating '' as a not nil value though go does treat '' as the zero value for a string but im not sure how that works with optional.Option.

[!WARNING]
I wasn't able to write a unit or integration test for this because i'm not entirely sure how to hook up a db provider when running locally. after looking at ftl-controller/main.go looks like a lot of other stuff has to get set up.

@deniseli i went ahead and refactored the DAL Configuration tests to isolate each individual test run. The way they were previously written led to side effects from previous tests causing subsequent test failures. I believe i've captured all of the test cases you previously had. definitely feel free to add any that i may have missed!

@mistermoe fantastic, thanks for doing that!

@deniseli i went ahead and applied this fix for secrets as well because the same problem existed there as well

I wonder if it would make sense in a future PR to make the global vs. module more explicit instead of relying on this COALESCE? Maybe another column with an enum of global and module or something? Eventually it could be like realm maybe as well... 🤔


pod: Fetch pod network only from createPod()

We don't want to fetch the pod network from the filesystem every
time we need information about it. Instead, the network is related
to the pod, that's why the pod should hold this information in-memory
through a new field into its structure.
Fixes #628
Signed-off-by: Sebastien Boeuf<EMAIL_ADDRESS>

LGTM


Embedding of linked items in Rich Text Fields limited to img only

DXA has a nice method to 'embed' linked items in Rich Text fields, by expanding the linked item into a separate RTF fragment containing full linked entity JSON. This allows for custom handling of the embedded item within the web application (for example to render a fancy video player, or responsive images). For the moment it is limited to content which is linked using an <img> element, however I have a couple of use cases where I would like an embedded linked item, which is not an image:

Downloads - we want to enrich RTF links to downloads (PDFs etc.) with the file size and icon for file type
Tooltips - we want to be able to create links to tooltip components (a normal component containing help text), which show help text in a tooltip on the page when the link is clicked.

As the logic to embed already exists, it would be great if this was made more generic and configurable, so for example you could specify a TBB parameter with a list of schema names for which linked RTF content should be embedded.
https://github.com/sdl/dxa-content-management/blob/25873210b246ab397dfc8efd0b63f30e1c5243f1/Sdl.Web.Tridion.Templates.R2/Data/DataModelBuilder.cs#L290

I'm working on a Pull Request for this, but unfortunately it seems like there is also a bug in the Java web application which means that embedded entities in Rich Text (including images) just don't work. Will add an issue and hopefully a fix this too in the next days!

This also needs to be fixed: https://github.com/sdl/dxa-web-application-java/issues/93

Here is the code change for the .NET web application
https://github.com/sdl/dxa-web-application-dotnet/issues/65
These 3 PRs related to these issues together constitute resolution for this issue on CM + Web Java + Web .NET

Internal ID (for tracking purposes): CRQ-12781

Incorporated in DXA 2.2


Unable to format or mount Exfat on any version of sdk

Update for anyone looking at my previous two issues, which are still issues, You can use 6a4d89bfeb6d8237da3e63ac66a6207c8af1c7bf to run them still (if you wana clone read https://stackoverflow.com/questions/3489173/how-to-clone-git-repository-with-specific-revision-changeset)
Ok, so because 6a4d89bfeb6d8237da3e63ac66a6207c8af1c7bf is the latest really working one, I need help, I am not sure if I can ask here as it is not a real issue as right now only a outdated version works, so technically it coulda been fixed....
I cannot use exfat because of error 19:
LEAVE_MKFS(FR_INVALID_PARAMETER); /* no-FAT? */
on
https://github.com/bouffalolab/bouffalo_sdk/blob/96533598ec949647be9a74d22ed5851604265957/components/fs/fatfs/ff.c#L6727
gets called with config:
#define FF_FS_CONTINUOUS 1
#define FF_FS_READONLY 0
#define FF_FS_MINIMIZE 0
#define FF_USE_FIND 1
#define FF_USE_MKFS 1
#define FF_USE_FASTSEEK 1
#define FF_USE_EXPAND 0
#define FF_USE_CHMOD 0
#define FF_USE_LABEL 0
#define FF_USE_FORWARD 0
#define FF_USE_STRFUNC 0
#define FF_PRINT_LLI   1
#define FF_PRINT_FLOAT 1
#define FF_STRF_ENCODE 3
#define FF_CODE_PAGE 437
#define FF_USE_LFN 2
#define FF_MAX_LFN 255
#define FF_LFN_UNICODE 1
#define FF_LFN_BUF 255
#define FF_SFN_BUF 12
#define FF_FS_RPATH 0
#define FF_VOLUMES 5
#define FF_STR_VOLUME_ID 2
#define FF_VOLUME_STRS   "ram", "flash", "sd", "sd2", "usb"
#define FF_MULTI_PARTITION 0
#define FF_MIN_SS 512
#define FF_MAX_SS 512
#define FF_LBA64 1
#define FF_MIN_GPT 0x10000000
#define FF_USE_TRIM 0
#define FF_FS_TINY 0
#define FF_FS_EXFAT 1
#define FF_FS_NORTC   1
#define FF_NORTC_MON  1
#define FF_NORTC_MDAY 1
#define FF_NORTC_YEAR 2022
#define FF_FS_NOFSINFO 0
#define FF_FS_LOCK 0
#define FF_FS_REENTRANT 0
#define FF_FS_TIMEOUT   1000

---- above has comments explaining each option but I removed them with a regex :)
and only modified main.c to use the commented out FM_EXFAT
I cant format to exfat or mount to exfat as it just returns errors, thanks for anyone who can help, and just so you know im more active on the pine discord.
This is a problem with a partitioning and mounting and I cant see why right now, please help!
Thanks, and please fix your repo

UPDATE: I FIXED IT, this was a complex one, and this sucks; ok, so you have to modify the exfat in the main file in the components also, use the old version for support (or fix the broken parts (I think it might be loading the unicode option makes it too big and is now set by default after v2.0 but not testing rn)) then use in main the correct fs type, and add it to be 512*256 for it to work (above 128 and I didnt know what to put so deal with it)
THANK bro, and please fix this or add comments about what dose what, and add the if statement in the main config for EXFAT support not just everything relating to it.....
I will add a merge request if I figure out github eventualy :)

nvm I was too quick, it formated and can write and read but gparted still has seek errors now :))))))

ok, did more testing and diffed the files betwine versions, NOTHING SEAMED TO CHANGE, did yall even test this, because this partition table is invalid!
thanks, gonna now read the spec on how exfat works and gpt partition tables see ya later

cool, so its not gpt good to know!
https://en.wikipedia.org/wiki/GUID_Partition_Table

Offset | Length | Contents
-- | -- | --
0 (0x00) | 8 bytes | Signature ("EFI PART", 45h 46h 49h 20h 50h 41h 52h 54h or 0x5452415020494645ULL[a] on little-endian machines)
8 (0x08) | 4 bytes | Revision 1.0 (00h 00h 01h 00h) for UEFI 2.8

Offset	Length	Contents
0 (0x00)	8 bytes	Signature ("EFI PART", 45h 46h 49h 20h 50h 41h 52h 54h or 0x5452415020494645ULL[[a]](https://en.wikipedia.org/wiki/GUID_Partition_Table#cite_note-13) on [little-endian](https://en.wikipedia.org/wiki/Little-endian) machines)
8 (0x08)	4 bytes	Revision 1.0 (00h 00h 01h 00h) for UEFI 2.8

vs my first few:
00000000  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
000001c0  02 00 ee fe ff 00 01 00  00 00 ff ff ff ff 00 00  |................|
000001d0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
000001f0  00 00 00 00 00 00 00 00  00 00 00 00 00 00 55 aa  |..............U.|
00000200  45 46 49 20 50 41 52 54  00 00 01 00 5c 00 00 00  |EFI PART....\...|
00000210  74 01 fa 70 00 00 00 00  01 00 00 00 00 00 00 00  |t..p............|


Indexing RefSeq transcriptome failure

From the salmon indexing log:
[2023-10-09 14:17:03.726] [puff::index::jointLog] [error] In FixFasta, two references with the same name but different sequences: intronic_G530011O06Rik. We require that all input records have a unique name up to the first whitespace (or user-provided separator) character.

After inspecting the GCF_000001635.27_GRCm39_genomic.gtf:
$ grep -E G530011O06Rik /db/nibrgenome/NG00017.0/taxa/mouse/GRCm39/RefSeq/gtf/GCF_000001635.27_GRCm39_genomic.gtf
NC_000086.8     BestRefSeq      gene    168758039       168761913       .       -       .       gene_id "G530011O06Rik"; transcript_id ""; db_xref "GeneID:654820"; db_xref "MGI:MGI:3603513"; description "RIKEN cDNA G530011O06 gene"; gbkey "Gene"; gene "G530011O06Rik"; gene_biotype "lncRNA";
NC_000086.8     BestRefSeq      exon    168761282       168761913       .       -       .       gene_id "G530011O06Rik"; transcript_id "NR_029457.1"; db_xref "GeneID:654820"; gbkey "ncRNA"; gene "G530011O06Rik"; product "RIKEN cDNA G530011O06 gene, transcript variant 1"; exon_number "1";
NC_000086.8     BestRefSeq      exon    168758039       168759786       .       -       .       gene_id "G530011O06Rik"; transcript_id "NR_029457.1"; db_xref "GeneID:654820"; gbkey "ncRNA"; gene "G530011O06Rik"; product "RIKEN cDNA G530011O06 gene, transcript variant 1"; exon_number "2";
NC_000087.8     BestRefSeq      gene    90762409        90766319        .       -       .       gene_id "G530011O06Rik_1"; transcript_id ""; db_xref "GeneID:654820"; db_xref "MGI:MGI:3603513"; description "RIKEN cDNA G530011O06 gene"; gbkey "Gene"; gene "G530011O06Rik"; gene_biotype "lncRNA";
NC_000087.8     BestRefSeq      exon    90765690        90766319        .       -       .       gene_id "G530011O06Rik_1"; transcript_id "NR_137283.1"; db_xref "GeneID:654820"; gbkey "ncRNA"; gene "G530011O06Rik"; product "RIKEN cDNA G530011O06 gene, transcript variant 1"; exon_number "1";
NC_000087.8     BestRefSeq      exon    90762409        90764192        .       -       .       gene_id "G530011O06Rik_1"; transcript_id "NR_137283.1"; db_xref "GeneID:654820"; gbkey "ncRNA"; gene "G530011O06Rik"; product "RIKEN cDNA G530011O06 gene, transcript variant 1"; exon_number "2";

gene_id is unique, but these Riken genes have duplicate gene symbols (gene tag). Pisces should use the gene_id for intronic sequences as these should always be unique keys in the GTF.

Tested fix is working.


Set Placement of Text Box on Page

Feature Description
Newly added text should always be left aligned to the page.
Figma

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

After clicking on + icon to add new text element. Add element paragraph element 40px from the left edge and center vertically.
User can add the following text preset to the page (H1, H2, H3, paragraph, caption, overline)
When adding text presets consecutively(ie I click on heading then subheading then body text or heading then body text or body text and heading etc), try to add body text below subheading and subheading below the heading.

Implementation Brief

Testing Instructions
I

Add different text presets consecutively.
Verify that if presets are added right after each other, the next preset is positioned below the previous.
Verify that the preset doesn't go out of the bottom of the page, staggering starts from the default position (vertically centered) if the room ends up in the bottom of the page.
Verify that if any change is made between adding the presets, the preset is added to the default position (the consecutiveness counts only if the presets are added right after each other).

Hey @miina is this all covered in #1204? Should I close this one as a dupe?

@jauyong Nope, this issue is still relevant, thanks for checking!

@samitron7 to review AC and feature description

Figma
Let me know if there are any additional questions.

@samitron7 One additional clarification:
Does "adding text presets consecutively" mean adding the text presets right after each other without making any changes meanwhile? E.g. if the user adds "Heading 1", changes the text of it and then clicks "Heading 2" -- is that not considered consecutively anymore since the user changed the text meanwhile?

Verified in QA

To @miina's comment (6 days ago) - we chatted offline and yes, any changes since adding the previous preset, it's not considered consecutive.


Request support for IoT Curtain 3M

Device matches loonas_curtain with quality of 57%. DPS: {"updated_at":<PHONE_NUMBER>.3765116, "1": "stop", "2": 0, "3": 0, "5": "forward", "7": "closing", "11": "fully_open", "102": true}

{
"result": {
"model": "{"modelId":"0000026bet","services":[{"actions":[],"code":"","description":"","events":[],"name":"默认服务","properties":[{"abilityId":1,"accessMode":"rw","code":"control","description":"【必选项】用于控制电机的开启、暂停、关闭。该DP点枚举值参数不允许修改，不允许增减。","extensions":{"iconName":"icon-dp_power2"},"name":"控制","typeSpec":{"range":["open","stop","close"],"type":"enum","typeDefaultValue":"open"}},{"abilityId":2,"accessMode":"rw","code":"percent_control","description":"如果窗帘电机可以监控窗帘目前的所处位置，例如窗帘现在开了一半，也就是50%，那么可以通过该DP点进行窗帘位置的自定义控制。控制使用该DP点，如果选择了该DP点，必选选择“”开启百分比状态显示“”，该DP点数值范围值参数不允许修改，不允许增减。","name":"开启百分比控制","typeSpec":{"max":100,"min":0,"scale":0,"step":1,"type":"value","typeDefaultValue":0,"unit":"%"}},{"abilityId":3,"accessMode":"ro","code":"percent_state","description":"该DP点与“”开启百分比状态控制“”配套使用。改DP点用于显示实际窗帘所处位置。该DP点数值范围值参数不允许修改，不允许增减。","name":"开启百分比状态","typeSpec":{"max":100,"min":0,"scale":0,"step":1,"type":"value","typeDefaultValue":0,"unit":"%"}},{"abilityId":5,"accessMode":"rw","code":"control_back","description":"用于设置电机转向，顺时针，或者逆时针，forward代表顺时针，back代表逆时针","name":"电机反向","typeSpec":{"range":["forward","back"],"type":"enum","typeDefaultValue":"forward"}},{"abilityId":7,"accessMode":"ro","code":"work_state","description":"【必选项】用于显示电机的当前工作状态。该DP点枚举值参数不允许修改，不允许增减。如需要修改在APP面板中显示的内容，可以前往第四步的拓展中心，多语言管理修改代表值，新增的枚举值所代表的的内容也是在多语言中修改代表值。","name":"工作状态","typeSpec":{"range":["opening","closing"],"type":"enum","typeDefaultValue":"opening"}},{"abilityId":11,"accessMode":"ro","code":"situation_set","description":"上报该DP点枚举值，以告知APP，该窗帘，100%对应的是全开，还是全关。不上报或者不选择改DP点，则默认100%为全关。","name":"百分比含义","typeSpec":{"range":["fully_open","fully_close"],"type":"enum","typeDefaultValue":"fully_open"}},{"abilityId":12,"accessMode":"ro","code":"fault","description":"【必选】设备上报故障值，该DP点枚举值可增减，但不可修改枚举值名称，例如可以删除motor_fault，可以增加其他值，未选则不展示该功能。 如需要修改在APP面板中显示的内容，可以前往第四步的拓展中心，多语言管理修改代表值，新增的枚举值所代表的的内容也是在多语言中修改代表值。","name":"故障告警","typeSpec":{"label":["motor_fault"],"maxlen":1,"type":"bitmap","typeDefaultValue":0}},{"abilityId":102,"accessMode":"rw","code":"Handpulled","description":"","name":"手拉启动","typeSpec":{"type":"bool","typeDefaultValue":false}}]}]}"
},
"success": true,
"t":<PHONE_NUMBER>624,
"tid": "4c4a1cd081ad11eea3b2361f03176748"
}

https://hiper-power.com/catalog/umnyy-dom/umnaya-tekhnika/umnyy-elektrokarniz-dlya-shtor-curtain-3m/

{
"result": [
{
"active_time":<PHONE_NUMBER>,
"category": "cl",
"create_time":<PHONE_NUMBER>,
"custom_name": "шторы зал",
"icon": "smart/icon/ay1541662398752zwSuU/8f65af3fa065bce2581652506da778b6.jpg",
"id": "",
"ip": "",
"is_online": true,
"lat": "56.3302",
"local_key": "",
"lon": "43.9301",
"model": " IoT Curtain 3M ",
"name": "IoT Curtain 3M",
"product_id": "qxzxmhkdvqexpwqx",
"product_name": " IoT Curtain 3M ",
"sub": false,
"time_zone": "+03:00",
"update_time":<PHONE_NUMBER>,
"uuid": "1114010224a16028d6bf"
}
],
"success": true,
"t":<PHONE_NUMBER>512,
"tid": "fcbac0e981ad11eeb1a19a6f3bbb8890"
}

Do you need any more information? It has been hanging in the issue for 4 months

I am unable to find this for sale anywhere outside of Russia.  Currently Russia is engaged in a war of aggression against a neighboring country, so I do not wish to spend my time on work that will exclusively benefit Russia at this time.

absolutely all countries have waged wars, it's just that it's so overblown around Russia, the United States only lives in wars, but somehow I haven't heard that they would be condemned... regarding the sale exclusively in Russia, on the contrary, this company left the Russian market and I bought them on the American website... lol


Combine ProtocolState and ProtocolBridge

They're 1:1 with each other and there's little utility in keeping them independent.

I’m gonna address the feedback in a follow-up PR!


dynamic analysis via TTD traces

we can process WinDbg Time Travel Debugging (TTD) traces and extract API calls, string/data references, and other features and analyze them in a dynamic context, like @yelhamer has done with the CAPE sandbox. in a sense, we'd be using TTD as a sandbox.
there would be a good amount of code needed to recognize the interesting cursor locations to pause at (API calls) and the techniques to extract arguments, data references, etc.
we should attempt this after the initial CAPE backend has landed so that capa has all the necessary machinery for dynamic analysis.
i think once this is implemented, we'd be able to do some really cool things around TTD trace visualization, like "here's an interesting point in the program execution, do you want to jump to it in IDA or Binary Ninja?".

unfortunately TTD is Windows-only today, since all the current solutions rely on the TTD.dll distributed with WinDbg. while im tempted to try to reverse engineer and re-implement the DLL, i understand it implements an optimized CPU emulator. that would be quite difficult to reproduce.
maybe we could find a way to emulate the TTD.dll on linux/macos. or, naturally, just support the backend on Windows.

unfortunately TTD is Windows-only today, since all the current solutions rely on the TTD.dll distributed with WinDbg. while im tempted to try to reverse engineer and re-implement the DLL, i understand it implements an optimized CPU emulator. that would be quite difficult to reproduce.
maybe we could find a way to emulate the TTD.dll on linux/macos. or, naturally, just support the backend on Windows.

Maybe you can try dumping (exporting) the trace to a file and then read it back when needed. The dumping process is Windows only but the dumped file can be accessed on any platform. This would not be a silver bullet since it is still a quite challenging task, e.g., you need to decided how much information you wish to keep in the trace. Nevertheless, this would at least make it possible to move forward.


Allow building of latest TFM in VS if using startvs script

Summary
If the startvs.cmd script is used to launch Visual Studio, then the latest TFM can be built because the SDK from the repository will be used by Visual Studio instead of the SDK from the global installation location.

Release Notes Entry

/backport to release/7.x

/backport to release/6.x


Add default to map filter if attribute is not defined

It would be great if the map filter would return an optional default value if the attribute is not defined.
Example:
list_of_dicts|map(attribute='version', default='5.6')

+1

Can anyone review my PR please? :)

any reason why this issue and PR hasn't been progressed ?

Yeah @davidism, please finally merge this.

Hi @DanyC97 and @Yannik thanks for raising this! :) it's been so long that the MR has conflicts. I will try to solve them asap

The following is not a statement about the issue or PR itself, and I do not want to give the impression that your comments had a positive effect on our future actions with it.
Please recognize that Jinja is one of multiple packages maintained by a few people in their spare time. We are under no timeline nor obligation to merge pull requests. While this may not have been your intention, posting comments that contain no content relevant to the issue but just prod us to take action are not welcome. Please do not do that here or elsewhere in the open source community.

@Yannik @DanyC97 The following is not a statement about the issue or PR itself, and I do not want to give the impression that your comments had a positive effect on our future actions with it.
Please recognize that Jinja is one of multiple packages maintained by a few people in their spare time. We are under no obligation to close issues on any specific timeline, although we do try to address things as we can. While this may not have been your intention, posting comments that contain no content relevant to the issue but just prod us to take action are not welcome. Please do not do that here or elsewhere in the open source community.

Is somebody still loooking into this? I reaaaally could have used this right now...

Are there any news regarding this feature? Why was the pulled request closed? Should someone else take over or is this just undesired?

I closed the pull request myself as I do not have any further interest pursuing it. Please feel free to contribute with another PR.

I would love to see this implemented

+1

Working on this in Pycon 2019 Sprints

#1018

Is it a good idea to add 'default' param to the 'attr' filter as well?


Tarif TGVmax non pris en compte

trainline version: 0.0.8

Hey,
First of all, very nice and usefull code !!
I have an issue when I specify my TGVmax id card, I get all the train of my period except all of them which are set at 0.0€.
Do you know how to list even a train with a price set to 0.0€ ? Which are them I looking for.
I tried to modify the min_price and the filter loop, but can't find a solution.
Thanks a lot,
Regards.

Hi @sebbastien
Thanks for the feedback. Strange issue :/
Unfortunately, without a valid TGVmax id, I cannot reproduce it or investigate.
@baptiste-mnh Can you have a look at it?

Hi!
I think i found the issue but will investigate it asap.
Can you try to set the max_price in the search method to 1 ?

Hi, I set the max_price equal to 1 in line 568 or/and line 815 but for both case no result are found and nothing is printed except the first line: 'departure_date;arrival_date;duration;number_of_segments;price;currency;transportation_mean;bicycle_reservation'
Let me know if you want I try something else.

First check here if a tgvmax is available and then search the train at the same date if the train is available or not from the this API.
Furthermore, do not modify the code to modify the max_price, it's already set in search function parameters.
If it still don't work I'll have a closer look on the issue.

For example, I look for Paris->Marseille on the 12/06/2019. On https://simulateur.tgvmax.fr/VSC/#/1 the 18h37 and 20h19 are available. And also available on Trainline.fr.
Below you can look at the results when I ran trainline python with my TGVmax id card and no change in the code:

python3 main.py Paris Marseille '12/06/2019 14:00' '12/06/2019 23:59'
departure_date;arrival_date;duration;number_of_segments;price;currency;transportation_mean;bicycle_reservation
12/06/2019 14:30;13/06/2019 18:30;04h00;1;55,0;EUR;coach;unavailable
12/06/2019 14:37;12/06/2019 17:55;03h18;1;45,0;EUR;train;unavailable
12/06/2019 15:07;12/06/2019 18:16;03h09;1;98,0;EUR;train;unavailable
12/06/2019 15:07;12/06/2019 18:16;03h09;1;149,0;EUR;train;unavailable
12/06/2019 15:07;12/06/2019 18:16;03h09;1;160,0;EUR;train;unavailable
12/06/2019 15:37;12/06/2019 18:55;03h18;1;116,0;EUR;train;unavailable
12/06/2019 15:37;12/06/2019 18:55;03h18;1;135,0;EUR;train;unavailable
12/06/2019 15:37;12/06/2019 18:55;03h18;1;160,0;EUR;train;unavailable
12/06/2019 16:15;12/06/2019 19:20;03h05;1;160,0;EUR;train;unavailable
12/06/2019 16:15;12/06/2019 19:20;03h05;1;113,0;EUR;train;unavailable
12/06/2019 16:15;12/06/2019 19:20;03h05;1;89,0;EUR;train;unavailable
12/06/2019 16:37;12/06/2019 19:56;03h19;1;156,0;EUR;train;unavailable
12/06/2019 16:37;12/06/2019 19:56;03h19;1;89,0;EUR;train;unavailable
12/06/2019 16:37;12/06/2019 19:56;03h19;1;160,0;EUR;train;unavailable
12/06/2019 17:37;12/06/2019 20:55;03h18;1;122,0;EUR;train;unavailable
12/06/2019 17:37;12/06/2019 20:55;03h18;1;98,0;EUR;train;unavailable
12/06/2019 17:37;12/06/2019 20:55;03h18;1;160,0;EUR;train;unavailable
12/06/2019 23:20;13/06/2019 11:30;12h10;1;19,98;EUR;coach;unavailable
12/06/2019 23:20;13/06/2019 08:14;08h54;2;62,99;EUR;train+coach;unavailable
12/06/2019 23:20;13/06/2019 08:14;08h54;2;66,99;EUR;train+coach;unavailable
12/06/2019 23:20;13/06/2019 08:55;09h35;2;30,99;EUR;train+coach;unavailable

And here it's the result when I ran with max_price=1 in main.py:

python3 main.py Paris Marseille '12/06/2019 14:00' '12/06/2019 23:59'
departure_date;arrival_date;duration;number_of_segments;price;currency;transportation_mean;bicycle_reservation

So still the same issue... Sorry.

Can you try this way?
user = trainline.Passenger(birthdate="01/01/1996", cards=[trainline.JEUNE])
user.add_special_card(trainline.TGVMAX, "YOUR_CARD_ID")

results = trainline.search(
passengers=[user],
departure_station="Paris",
arrival_station="Paris",
from_date="01/05/2019 05:00",
to_date="01/05/2019 9:00",
max_price=0.0)

print(results.csv())

Instead of using your lines I used these ones in main.py (I changed the date:
user = trainline.Passenger(birthdate="01/01/1996", cards=[trainline.JEUNE])
user.add_special_card(trainline.TGVMAX, "HC000XXXXXX")

results = trainline.search(
passengers=[user],
departure_station="Paris",
arrival_station="Marseille",
from_date="12/06/2019 14:00",
to_date="12/06/2019 23:59",
max_price=0.0)

print(results.csv())

Then run the command:
python3 main.py Paris Marseille '12/06/2019 14:00' '12/06/2019 23:59'

It gives the following output:
departure_date;arrival_date;duration;number_of_segments;price;currency;transportation_mean;bicycle_reservation
So still no change. Is there a way to print all the outputs from the API? Maybe the API do not show tgvmax tickets, but if tgvmax tickets are printed out, it means that the error comes from post processing.

Ok, weird... I will check.

When looking for a large timeframe, (such as from_date="12/06/2019 14:00", to_date="12/06/2019 23:59") it does not work. However when testing with something like from_date="12/06/2019 20:00", to_date="12/06/2019 23:59", it works well. With this smaller timeframe it displays:
12/06/2019 20:19;12/06/2019 23:42;03h23;1;0,0;EUR;train;unavailable

So there may be an issue with the requests may to cover the full timeframe?

Hey !
Just to let you know that I tried it this morning, and it worked perfectly fine.
index.py (in the project's root) :
# -*- coding: utf-8 -*-
import trainline
from trainline import Trainline, Trip, Passenger, Segment, ComfortClass, Folder

user = trainline.Passenger(birthdate="01/08/1994")
user.add_special_card(trainline.TGVMAX, "HC00XXXXXXX")

from_date = "01/10/2019 07:00"
to_date = "01/10/2019 20:00"
departure_station = "paris"
arrival_station = "lyon part-dieu"

results = trainline.search(
    passengers=[user],
    departure_station=departure_station,
    arrival_station=arrival_station,
    from_date=from_date,
    to_date=to_date,
    max_price=0.0)

print(results.csv())

Then run :
python3 index.py > file.csv

As you can see the timeframe is large, and I got all the trains that have a TGVmax seat available (I backtested with the oui.sncf app 👌 ).

Thank you to the people who made this package ! 👏  😊

Thanks for the feedback @benoitdemaegdt


Default value of 'cache_ttl_error' & 'val-bogus-ttl'

In case that cache_ttl_error in encrypted-dns.toml is the same as val-bogus-ttl of Unbound, there are two different default values:

cache_ttl_error = 600

val-bogus-ttl: 60

Maybe the two settings should use the same value?

ping @jedisct1

Sounds like a good idea!
Thanks!


disable openvpn tls renegotiation hourly in favour of every 1GB

Connects to #1023
Change-Type: minor

Contributor checklist

[ ] Changes have been tested
[x] Change-type present on at least one commit
[ ] Signed-off-by is present
[x] The PR complies with the Open Embedded Commit Patch Message Guidelines

Reviewer Guidelines

When submitting a review, please pick:

'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Can one of the admins verify this patch?

Thanks @agherzan, updated.

add to whitelist

ok to test

@wrboyce Doesn't this PR fix the #1024 issue? If so, can we replace in the description connected to by Fixes?


New-User without success?

 New-User -firstName "Peter" -userName "Test" -password "Test123454566" -LastName "Meier"
Does not return an error or anything, but does not work. Have the same problem, when i try to do it in C#, so i think this is a change from Snipeit?
PS C:\Users\014nr9999> New-User
Cmdlet New-User an der Befehlspipelineposition 1
Geben Sie Werte für die folgenden Parameter an:
firstName: A
lastName: B
userName: D

no success ...

More information: New-User needs an password_confirmation field in the Snipeit API. I think, thats the error ...

Its being set if ldap is not set to true
Can you try force setting ldap_user to $false and see if that makes any difference?
if ($ldap_user -eq $false) {
$ldap = @{
password    = $password
password_confirmation = $password
ldap_import = 0
}
}

Still no success with
New-User -firstName "Peter" -userName "Test" -LastName "Meier" -ldap_user 0

Current develop branch have no this this issue. It will roll out to powershell gallery soon. Please reopen new issue if needed.


Chrome Blocks Dev Build Download

Ugh.

Somewhere in here is the info to fix it https://support.google.com/webmasters/answer/3258249

This has something to do with the Azure CDN domain (az777550.vo.msecnd.net). @felixrieseberg we'll need to do some CNAME pointing from storageexplorer.com to the cdn which I think will fix the issue. (We can just use the direct storage account link in the mean time)


MM-47193 Migrate utils/youtube.js to typescript

Summary
Migrate utils/youtube.js to typescript
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/21166
JIRA: https://mattermost.atlassian.net/browse/MM-47193
Related Pull Requests
None
Screenshots
None
Release Note
Migrate utils/youtube.js to typescript

Hello @AbhinavVihan,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/release-note-none


Adding rocSOLVER support for LAPACK domain with hip backend

Adding  rocSOLVER support for LAPACK
Description
Raising PR with initial code base to provide rocSOLVER support for LAPACK  domain with the HIP backend
Checklist
All Submissions

[x] Do all unit tests pass locally? test_all_log.txt
[x] Have you formatted the code using clang-format?

@ericlars and @sknepper, I've updated the PR with the test cases. Can you please review and share your suggestions.

Mistakenly merged before other approvers could take a look, if any issues please comment and we can revert.


Trying to send multipart

Hi,
I am building an API Client at the moment and I am trying to send a POST request with multipart data.
The data I am trying to send looks like the following.
array:1 [▼
  "multipart" => array:2 [▼
    0 => array:2 [▼
      "name" => "file"
      "contents" => stream resource @135 ▶} // contents is fopen($file, 'r')
    ]
    1 => array:2 [▼
      "name" => "apikey"
      "contents" => "mysecretapikey"
    ]
  ]
]

Using Guzzle 6 Standalone I would do it like this and this works just fine.
$guzzle = new \GuzzleHttp\Client($options);

$response = $guzzle->request('POST', $uri, ['multipart' => $body]);

dump($response->getBody()->getContents());

Now when trying to use the adapter I came up with this.
$guzzle = new \GuzzleHttp\Client($options);

$adapter = new \Http\Adapter\Guzzle6\Client($guzzle);

// For form_params I could do ...
// $body = \GuzzleHttp\Psr7\stream_for(http_build_query($params));
// but how am I going to add multipart data to a request?
$request = new \GuzzleHttp\Psr7\Request($method, $uri, $headers, $body);

$pluginClient = new HttpMethodsClient(
    new PluginClient($adapter, $this->plugins),
    $this->messageFactory
);

$response = $adapter->sendRequest($request);

Sending the request with the adapter always results in a 403 Forbidden because the multipart data gets useless after building it with stream_for. So how do I send a multipartrequest with this adapter since there is no request method?

@faustbrian You can take a look at the MultipartStreamBuilder from the php-http/multipart-stream-builder package.

Thanks, that also led me to finding this solution if you want to leverage Guzzle itself.
$stream = new \GuzzleHttp\Psr7\MultipartStream($body, uniqid());

$response = $pluginClient->send($method, $uri, $headers, $stream);


Fix stats filter by specify VMs for different types of listeners

Attempts to fix https://github.com/istio/istio/issues/17811

@bianpengyuan can you also update proxy version in the Same pr?
That way we know if it really fixes the issue.

@bianpengyuan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
6e59f95a65cedcfb7ababb9943cbb7b46d85e7e1
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
6e59f95a65cedcfb7ababb9943cbb7b46d85e7e1
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
6e59f95a65cedcfb7ababb9943cbb7b46d85e7e1
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
6e59f95a65cedcfb7ababb9943cbb7b46d85e7e1
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
6e59f95a65cedcfb7ababb9943cbb7b46d85e7e1
link
/test integ-telemetry-k8s-tests_istio

e2e-mixer-no_auth_istio
6617b22948323a93fa35877e617602fc79c995c5
link
/test e2e-mixer-no_auth_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
6e59f95a65cedcfb7ababb9943cbb7b46d85e7e1
link
/test integ-pilot-k8s-tests_istio

e2e-mixer-no_auth_istio
6617b22948323a93fa35877e617602fc79c995c5
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
6617b22948323a93fa35877e617602fc79c995c5
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-mixer-no_auth_istio
6617b22948323a93fa35877e617602fc79c995c5
link
/test e2e-mixer-no_auth_istio

integ-telemetry-k8s-tests_istio
6617b22948323a93fa35877e617602fc79c995c5
link
/test integ-telemetry-k8s-tests_istio

integ-new-install-k8s-tests_istio
6617b22948323a93fa35877e617602fc79c995c5
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
6617b22948323a93fa35877e617602fc79c995c5
link
/test integ-new-install-k8s-tests_istio

integ-telemetry-k8s-tests_istio
883e2f779f0dcedd36f8024eee8d7321dcc2f61d
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-telemetry-k8s-tests_istio
883e2f779f0dcedd36f8024eee8d7321dcc2f61d
link
/test integ-telemetry-k8s-tests_istio

integ-new-install-k8s-tests_istio
883e2f779f0dcedd36f8024eee8d7321dcc2f61d
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog This does not work as both vm_id (memory isolation) and root_id (ambient environment isolation) need to be specified, and root_id is required to be specified at initialization:
https://github.com/envoyproxy/envoy-wasm/blob/53bad248587086df4919d5209fe537aab29bace0/source/extensions/common/wasm/null/null_plugin.h#L130

Close as this won't work.


Minimize data consumption

Question

Hello,
I want to use the node-telegram-bot-api on a mobile router (2G/3G/4G) and it is important to minimize the data consumption. When I use the default polling option it takes some megabytes per day and this is too much. On my iPhone the telegram app take only some megabytes per month.
How is it possible to reduce the data consumption?
Thanks!

Thank you. I will try this


Phishtank is returning XML instead of JSON

Hi,
this is probably dead project, but I am playing with a PhishTank API and I have a problem, that responses are coming only in XML, even when format='json' is in request parameters. Then I've found your project and saw, that you are parsing JSON a returning a response.
Does this work for you? When I downloaded a debugged your code, the response is obtained in XML despite the fact that you want a JSON.
I am suspecting that they have changed the API/disabled JSON format, but I'd like to know if it's been working in the past.
Thanks!

@astaruch Yes, you are correct. It's returning XML right now. You found any other way to get the JSON response. Please yes please share it here


UI doesn't show up in latest Mac version

Using the latest version of HSTracker for Mac. Downloaded and installed according to instructions, but when I launch it, it doesn't show anything. I click on the tracker in my dock and nothing happens. Using OSX El Capitan Version 10.11.1(latest versino). Here is my console output when launching the tracker:
11/2/15 3:57:49.692 PM HSTracker[2749]: CoreData: Failed to load optimized model at path '/Applications/HSTracker.app/Contents/Resources/hstracker.momd/0010 hearthstats date.omo'
11/2/15 3:57:49.723 PM HSTracker[2749]: Failed to connect (colorGridView) outlet from (NSApplication) to (NSColorPickerGridView): missing setter or instance variable
11/2/15 3:57:49.724 PM HSTracker[2749]: Failed to connect (view) outlet from (NSApplication) to (NSColorPickerGridView): missing setter or instance variable

Same here. Installed yesterday and worked fine but not anymore today. Didn't update anything (OS X 10.11.1).
12-3-15 21:01:18,701 HSTracker[1689]: Failed to connect (colorGridView) outlet from (NSApplication) to (NSColorPickerGridView): missing setter or instance variable
12-3-15 21:01:18,701 HSTracker[1689]: Failed to connect (view) outlet from (NSApplication) to (NSColorPickerGridView): missing setter or instance variable


Inconsistent quad interface compared to Gurobi.jl

The methods to build a quadratic objective function are somewhat confusing, it is not clear when one must pass the matrix coefficients or the "term" coefficients.
Even more confusing when you consider that the convention used in CPLEX.jl is different from what is used in Gurobi.jl: add_qpterms() expects "term" coefficients in Gurobi.jl, while it expects "matrix" coefficients in CPLEX.jl.
This is probably the cause why the test qp_01.jl gives "wrong" results in CPLEX.jl compared to what is expected (the results are not  actually checked in the tests) -- it was probably copied & pasted from GUROBI.jl, that uses a different convention.
Not saying that the two interfaces have to be identical -- they don't, but I found it somewhat confusing.
[Also, the MPB tests do not pass, updatemodel() doesn't exist for CPLEX.]

I don't have a strong preference; if I remember correctly, we chose to mirror closely how CPLEX wanted the data at this level, and then used a middle-level fallback in MathProgBase to convert the "terms" form to the "matrix" form.
Agreed that the interface is confusing; that's because this was developed as an "internal" library for JuMP (meaning that the user should never have to touch the CPLEX.jl functions/objects themselves). Perhaps it's time to clean this up and standardize the interface. PRs or suggestions welcome.
Regarding updatemodel, I think we've moved away from forcing solvers to implement methods that aren't necessary like this, so the MPB tests should be changed to reflect this.

Closing since we won't be fixing this. In the future, we will be re-writing the underlying C API, but we're aiming to reflect the C API, rather than align with Gurobi.


AM/PM Merged, Updated, Fixed

Adding AM/PM feature to time picker and datetime picker
https://github.com/dylanwuzh/flutter-cupertino-date-picker/issues/35
Used code from PR https://github.com/dylanwuzh/flutter-cupertino-date-picker/pull/49
Retested, Added missing features and fixed some bugs with datetime picker

@dylanwuzh can we get this merged? 👍

@rdev-software I'm seeing an issue where when I attempt to scroll any of the wheels, the hours disappear. See video here: https://share.getcloudapp.com/nOumbNvl
Here's the code I'm using:
DatePicker.showDatePicker(
          context,
          initialDateTime: initialValue,
          dateFormat: 'MMM dd, yyyy|hh|mm|a',
          minDateTime: DateTime.now(),
          pickerMode: DateTimePickerMode.datetime,
          onConfirm: (v, _) {
            selectedDateTime = v;
            controller.text = formatDateTime(v);
            Vibrate.feedback(FeedbackType.success);
          },
        );

Are you experiencing this?

If I change the dateFormat to use 24 hour (HH), it works as expected.

Would love to see this merged and available soon. Thanks for the enhancement!

@dylanwuzh Can this get merged?

Hi is this implemented in the production?


Update font choices

I'd like to propose swapping the font choices, so Libre Baskerville is used in body copy and Open Sans is used in titles

Here is a list of possible candidates: http://design-research.be/by-womxn/

@pamela-drouin commented on another issue with a little font audit.
I think that other issue is a dupe and should be closed.


router-view is functional component which should not be used with keep-alive

Version
3.5.3
Reproduction link
github.com
Steps to reproduce
According to keepAlive official doc

keep-alive does not work with functional components because they do not have instances to be cached.

However, according to router-view doc, RounterView is a functional component.
this results in issue which can be reproduced in https://github.com/vuejs/core/issues/5207
What is expected?
RounterView should work correctly with keep-alive
What is actually happening?
RounterView  does not work correctly with keep-alive

You are in the wrong repository. VueRouter 4 lives art https://github/vuejs/router
You have read the wrong docs, which until very soon still live at next.router.vuejs.org
The quote from the docs talks about KeepAlive wrapping a functional component directly. It does not mean any nested child

Please open a new issue in https://github.com/vuejs/router if you still think this needs to be adressed in the router.


Setting locale to Locale.ROOT while using String.format to ensure that UTs doesn't fail when validating the exception messages

Description
Setting locale to Locale.ROOT while using String.format to ensure that UTs doesn't fail when validating the exception messages.
So the idea here is whenever we use String.format we should ensure that we are using the Locale.ROOT to set the locale of the string, otherwise if you are validating the exception messages then the string comparison can fail and lead to flaky tests.
To reproduce the issue run the below command on the main branch of K-NN plugin.
./gradlew ':test' --tests "org.opensearch.knn.index.query.KNNQueryBuilderInvalidParamsTests" -Dtests.seed=EF1B1919EE6D650B  -Dtests.locale=ar-IQ -Dtests.timezone=America/Managua

Issues Resolved
NA
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The fix for BWC is present in this PR: https://github.com/opensearch-project/k-NN/pull/1811


requireNativeComponent: "RNCWebView" was not found in the UIManager

Hi,
I got the above error after installed everything.
Kindly guide me
Thanks Inadvance

Please make sure you have react-native-webview installed.
If you have latest RN, please make sure the webview has been linked correctly, else please link it by updating the settings.gradle, app/build.gradle and MainApplication.java manually. Or you can use command react-native link react-native-webview


Use semantic versioning

Please use (and update) actual version numbers in the pom.xml file for this project. The current version, canary, hasn't been updated since 2017 and makes it hard to find the source of issues like this. Naming versions elsewhere such as release documentation would be just fine, of course.

When NamelessMC v2 is released, the API will become stable and I will also look into pushing builds to maven central


Detroit - Favorites saving issues

QA NOTES
navigate to https://detroit-public-dev.netlify.app/
log in as a user (with no listings favorited is best, but if listings are favorited thats okay)

favorite a few listings and refresh the page. Favorited listings should now still show as favorited

favorite a few listings, navigate to a different page (the About page for example) then navigate back. The listings that were favorited should show as favorited

LGTM


allowed column with numeric width value to stretch

column with numeric width should allow to stretch

Fixes #1592


add example to insert on conflict

Closes #2378

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d13ac2692b73dc7dce828b74ab78e9150c3d9736/

I can make the final edits, @m-schneider.

I've updated the files.

Review status: 0 of 2 files reviewed at latest revision, 4 unresolved discussions.

v1.1/insert.md, line 47 at r1 (raw file):
Previously, jseldess wrote…
Let's change this intro a little:

All of the examples below assume you've already created a table accounts:

Done.

v1.1/insert.md, line 51 at r1 (raw file):
Previously, jseldess wrote…
The SHOW output below shows the id column using unique_rowid() as the default value. Can you add that to this CREATE TABLE?

Done.

v2.0/insert.md, line 48 at r1 (raw file):
Previously, jseldess wrote…
Let's change this intro a little:

All of the examples below assume you've already created a table accounts:

Done.

v2.0/insert.md, line 52 at r1 (raw file):
Previously, jseldess wrote…
The SHOW output below shows the id column using unique_rowid() as the default value. Can you add that to this CREATE TABLE?

Done.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4c371d6db0071d0f69d25e16a72643ddff2bc379/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c9a73c67d7f8aac6d6706668d9b4a587cb738781/

Review status: 0 of 2 files reviewed at latest revision, 6 unresolved discussions, some commit checks pending.

v1.1/insert.md, line 47 at r2 (raw file):
Previously, jseldess wrote…
Also in other versions of the page.

Done.

v2.0/insert.md, line 14 at r2 (raw file):
Previously, jseldess wrote…
Not sure why the line is wrapping mid-word. While you're editing this page, can you fix that. Also, it'd be great if you could replace the html for Markdown:
The experimental [`IMPORT`](import.html) statement performs better than `INSERT` when inserting into a new table.

I also changed it down below.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6019e08b413fd8fe853e448007a46fa3f84a327d/

Thanks, @m-schneider.


Add support for the until date in SearchTimeline.

LGTM. Thank you for your contribution. This should be included in our next release.

Again thank you for your contribution. Happy coding. See: https://github.com/twitter/twitter-kit-android/commit/af4869e2e1b9752d6f6ed392b5b5f3b4b7f1235c


Make commands configurable

I'd like to replace find command used in fzy-file-widget with something else, for example rg --files. Same would apply for fzy-cd-widget.
This would allow me to ignore certain files and folders, for example I never want to look for files inside .git directory.

This is a good idea, I think adding a couple of options settable with zstyle will be the way to go, e.g.:
zstyle :fzy:file command <string>
zstyle :fzy:cd   command <string>

where <string> can be any command that produces a list of elements on standard output, one per line. In particular I think it is important to allow using shell functions, to allow any complex behavior. Silly example:
function list-files-for-fzy {
    rg --files | rg -vF '/old/'
}

zstyle :fzy:file command list-files-for-fzy

On top of allowing for more customization, this would also allow to wrap the commands currently being used inside functions to easily reuse them as defaults.

This is powerful, just to confirm, would it always be necessary to define a function, or something like this would work too?
zstyle :fzy:file command 'rg --files'

@maximbaz Defining a function will be optional. Your configuration using the command string directly should work as well.

@maximbaz The needed changes are now in master, please update, and let me know if you find any problem with the new feature. Note that the zstyle settings are arrays, and you will need to use the following:
zstyle :fzy:file command rg --files  # No quoting needed.

Works very well, thanks a lot!


[SMALLFIX] Java 8 Improvement: replace lambda with method reference

Java 8 Improvement: replace lambda with method reference in alluxio.server.ft.journal.JournalBackupIntegrationTest#backupRestoreTest

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/820/
Test FAILed.

Jenkins, test this please


cranelift: Only set VReg type once

We know the type of each VReg at the moment when we allocate it, so we never need to set the type again. That also means we don't need to deduplicate reftyped VRegs as we go, although it's still possible to have duplicates after aliases are resolved.
This PR and #8469 remove the only two uses of FxHashSet in vcode.rs, so whichever one lands second needs to also delete the use item for that type or it'll introduce a new unused-import warning.

Since #8469 landed I've rebased this PR.


Use TickedLedger for updateConsensusState

The documentation for updateConsensusState said that it would be given the validated ledger view. That is not correct: it is passed the ticked ledger view. We didn't make that clear in the types though; now we do. Similarly, the leader check was done using a ticked ledger view, but this was also not clear from the types.

I'm also not really sure what the semantics really are meant to be of a "ticked" ledger view? E.g there is a comment saying "forecasting is equivalent to ticking", which is true.. but it's not clear what slot it should be ticked to here - is this a view from a ticked ledger state, or a ticked view (I guess, a view for a specific slot?)

Not sure I follow this. It's the ledger view protected forward to a particular slot, which by that lemma is equivalent to what the chain tick is doing? The slot is clear no? It's the slot we protected to... should I rephrase this somehow?

@nc6 Pushed a commit that renames the type to Ticked as we discussed, and also attempts to improve the docstring.

bors merge

bors retry


[ie/youtube] Raise if n function returns input value

Template
Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[x] I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)

@Zulu-1540 please stop spamming unrelated, incoherent comments or I will have to block you from the repository. If you have a problem or a question, please open a new dedicated issue.


iRODS federation for expanded storage

Make sure the capability for institutions to add their own storage capacity and to federate with HydroShare using iRODS works as designed. Document this functionality so that third party institutions can easily follow along to add their own storage capacity as part of HydroShare resource storage.

@dtarb @alvacouch @rayi113 @mjstealey I have tested with NFIE zone on www as a test case for third party external federated zone since NFIE zone is federated with www. Everything works as expected by design. I will do the same test after release 1.10 is deployed just to make sure external federation still works as expected with our new file system implementation code base. Another related to-do item is to add help page for this third-party expanded storage functionality. @alvacouch I think you are the best person to draft the help page for this given your CUAHSI role and your understanding to the codebase. You can refer to descriptions in our paper if needed since the codebase behaves exactly as we described in the paper, and works as expected based on my testing so far. Let me know what you think.

@dtarb @alvacouch @rayi113 @mjstealey I believe this works as expected. See my comments above for details. I am closing this issue, but feel free to reopen it if you find any issues related to this.

Thanks.  Can you point me to the document that describes "this functionality so that third party institutions can easily follow along to add their own storage capacity as part of HydroShare resource storage." as indicated in the issue description.


Fix exit code

Right now I can't use this in my CI system without parsing the output.
This PR updates the exit logic to exit 0 if vulnerabilities are not found and/or --suppressExitError isn't used, otherwise exit 1

Looking at your pull request (and a similar one sent by another kind soul) reminded me that there DID used to be a non-zero exit code when vulnerabilities were found. I looked through the history and found the commit where I somehow removed the functionality. I re-added in the original code.
It differs from both of your fixes in that instead of returning 1 it returns the number of vulnerabilities found, which means any vulnerabilities found result in a non-zero return.
I have pushed a new release to npm and to master. Hopefully this solution is sufficient. Please do let me know if there is a problem in my thinking.
Thanks for the help!
I am always interested in pull requests, so definitely please feel free to submit any fixes and ideas you might have.

Awesome thanks for that!

FYI, if you do plan on submitting PRs, in order to directly use your contribution Sonatype requests that you sign a CLA (Contributor License Agreement) which more or less grants Sonatype permission to use the code. The agreement is reasonably short.
If you do have any PRs you would like to submit the document is here (http://www.sonatype.org/SonatypeCLA.pdf) and would need to be emailed to (jhesse@sonatype.com).
I definitely understand if this makes you uncomfortable, so if this is a problem I am still more than interested in having features requests which I will try and resolve as soon as possible.


Ethiopia's emblem

Ethiopia's Flag 🇪🇹
[Emblem ☆] (https://en.wikipedia.org/wiki/Ethiopia#/media/File:Coat_of_arms_of_Ethiopia.svg)
i don't know if it's pixelated or not but i see ✡ instead of ☆

Thanx for noticing! :+1: Fixed now.
However it has to be very simplified since it's for super small usage.


Question about cora and cora_full.

Thanks for sharing the code and datasets! I have some question about cora:
as answer of you in https://github.com/CurryTang/Graph-LLM/issues/7
In cora dataset, I find only title but no content for some entries.
Later, I found that you shared cora_full file in your Google Cloud Drive. I then wanted to use cora_full instead of cora.
But I found that your cora_full file only contains Data(raw_texts=[28402], edge_index=[2, 97230], y=[28402]) and no features. I thought about loading cora_full myself corresponding to the text file you provided. But I realized that the number of nodes doesn't correspond either. You have 28402 here, but the general cora_full is 19793.
May I ask how you got your cora_full.pt file? Or can you provide more full information?

Hi, you may access Cora-full dataset here https://people.cs.umass.edu/~mccallum/data.html

Hi, thanks for your sharing! Does the attribute x in the cora_fixed_tfidf.pt file match the attribute x in the official pyg cora dataset?

Hi, thanks for your sharing! Does the attribute x in the cora_fixed_tfidf.pt file match the attribute x in the official pyg Cora dataset? BTW, I've noticed that there are 10 different sets of train/valid/test masks included in the Cora Data, which one is the main set you used in your experiments?

Hi, thanks for your sharing! Does the attribute x in the cora_fixed_tfidf.pt file match the attribute x in the official pyg Cora dataset? BTW, I've noticed that there are 10 different sets of train/valid/test masks included in the Cora Data, which one is the main set you used in your experiments?

It's not aligned since the original one is anonymous


Make it work with Android

It looks like there is finally a proper version of python for Android called QPython:
http://qpython.com/

Closing this for now as the project is deprecated.


LabelMe 3.0 format not correct

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

I am using the develop branch of cvat. When I dumped a dataset in the format of LabelMe 3.0, I found the format was not correct.
Expected Behaviour

The label file of "a.jpg" should be "a.xml"
The label file of "b.jpg" should be "b.xml"
......
Current Behaviour

The label file of "a.jpg" is "item_000000000.xml"
The label file of "b.jpg" is "item_000000001.xml"
......
Steps to Reproduce (for bugs)

create a task
label images
select Menu->Export as dataset -> LabelMe 3.0

This behaviour is intended, check https://github.com/openvinotoolkit/datumaro/issues/17. TL;DR: the reason is support of relative image paths in a dataset.

@Once88, if you have experience with this format, could you advice on the following question:
If a task has image paths like:
./c.jpeg
./a/b/c.jpg
./a/b/c.png
./a/b/d.jpg

How the resulting dataset should look like? What would you expect as a result?

@zhiltsov-max, I don't have a perfect solution to the question you mentioned.
But some open source projects or existing projects read annotation files by the name of relative image filename with a different suffix, without reading the <filename> field inside the XML. So we need to do a lot of work to convert the annotation filenames.
Make importing more convenient or exporting more convenient? I think there is a trade-off here.

Thanks for sharing your point. How do you think, if we exported a dataset above like this:
./c.jpeg
./c.xml
./a/b/c.jpg
./a/b/c.xml
./a/b/c.png
./a/b/c.png.xml
./a/b/d.jpg
./a/b/d.xml

Would such solution be satisfying?


Authorization Fix for DM & PCs (Bug #208)

The password functions have been split from authMiddleware to authMiddlewareDM & authMiddlewarePC. A challenge screen will only show if the corresponding environment variable has been set from command line.
process.env.PC_PASSWORD
process.env.DM_PASSWORD

Closes #208

@n1ru4l no problem, glad it's working again!


Resolve vulnerabilities in dependencies

Bumped shelljs to 0.8.5
adm-zip to 0.5.9
fixed tests (due to changes in methods shelljs)

Tested only with mocha tests

@AndreyIvanov42 where are ensureStarted and ensureTool methods affected - could you please double-check that you've tested scenarios in which these methods are being used?

@anatolybolshakov
I double-checked ensureStarted and ensureTool methods. They are used only in tests.
But since many methods of this library are wrappers over shelljs methods, I need to make sure that backward compatibility is not broken.

Please bump package/package-lock versions

@AndreyIvanov42 When are we going to have 3.2.0 as the latest version to download? It looks like shelljs vulnerability was fixed in this PR #815 when version was updated to 0.8.5 from 8.4.

@kriti218
New version is available


Include the config-loader again

After talking with @lance, we decided it might be better to have the config loader integrated back into this library.
I think if no config is passed, then it just does the default stuff(calls config-loader), but if a config is passed in, then it will use that instead
I think i was trying to be to smart with this https://github.com/bucharest-gold/openshift-rest-client/issues/5

This will change the method signature from func(config, settings) to just func(settings)
if you still want to pass in a custom config object,  add it to settings.config, likewise, if you need to override something in the config loader, pass that in with settings.openshiftConfigLoader
Once this change is in, we will probably bump to 1.0.0 since it is a breaking change

@tavogel wanted to give you a heads up

Thanks. This will be breaking as we don't use local configuration but as long as we can still override it should be ok

@tavogel yea,  you can override using settings.config = {...}

@tavogel if you wanted to give the new version a try, i created a "canary" version as 0.12.0-0


Support for Netgear 16 Port Switch

Have been using the project for a Netgear 8 port switch - works great,  Would like to inquire into support of the 16 port version of this switch

As discussed, please join the Slack channel, so we can streamline the development.
https://join.slack.com/t/nitram509/shared_invite/zt-2qvxx4kur-FvIOJH7WW9MBK_iheWVyGw
PS: this link is only valid for 7 days.


style: improve visualizePath style

Description
Updating the style of the path/trajectory display plugin
Related links

Youtube video demo

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

Could you add the following parameter:
Parameter name: fade_out_distance
Description: The length from the path’s end where it gradually becomes transparent.
We can discuss the implementation once it is set from rviz

I think this is ready for review.
@KhalilSelyan could you test the last version?

Videos
https://www.youtube.com/playlist?list=PL97OXOB9UA-gSyZWr3VVn4dNnBtt0lqTp


Add video playback

If we can put the video inside, it will be perfect.  Come on!

Feature request on the way
Just some small adjustments still

This commit added support.
Already available on pub.dev


Feature Request: Give an example / Documentation

Hi! Thanks a lot for the great work you are doing!
I am pretty new to Home Assistant and I found it a little bit confusing to start work with. Can you, please, add an example configuration on how to invoke the API you are providing from the integration? For example, a simple card with a live stream and motion controls.
Thanks a lot!

As an example it could be something like:
`type: picture-glance
title: Tapo C200 (Eye)
camera_image: camera.eye_hd
camera_view: live
entities:

entity: camera.eye_hd
icon: 'mdi:arrow-left-drop-circle-outline'
tap_action:
action: call-service
service: tapo_control.ptz
service_data:
entity_id: camera.eye_hd
pan: LEFT
entity: camera.eye_hd
icon: 'mdi:arrow-up-drop-circle-outline'
tap_action:
action: call-service
service: tapo_control.ptz
service_data:
entity_id: camera.eye_hd
tilt: UP
entity: camera.eye_hd
icon: 'mdi:arrow-down-drop-circle-outline'
tap_action:
action: call-service
service: tapo_control.ptz
service_data:
entity_id: camera.eye_hd
tilt: DOWN
entity: camera.eye_hd
icon: 'mdi:arrow-right-drop-circle-outline'
tap_action:
action: call-service
service: tapo_control.ptz
service_data:
entity_id: camera.eye_hd
pan: RIGHT
entity: camera.eye_hd
icon: 'mdi:eye-outline'
tap_action:
action: call-service
service: tapo_control.set_privacy_mode
service_data:
entity_id: camera.eye_hd
privacy_mode: 'off'
entity: camera.eye_hd
icon: 'mdi:eye-off-outline'
tap_action:
action: call-service
service: tapo_control.set_privacy_mode
service_data:
entity_id: camera.eye_hd
privacy_mode: 'off'
entity: camera.eye_hd
icon: 'mdi:power'
tap_action:
action: call-service
service: tapo_control.reboot
hold_action:
action: more-info
`

Hey @ic2hrmk
Thank you for your example. It looks really great!
If you would like to, please go ahead, create a new folder called docs and file for example EXAMPLES.md and put in your examples, then just create a PR 👍

Hi @JurajNyiri , I created a short page with examples but I'm not able to push my branch to this repository. Can you please review the repo access policy?

Hello @ic2hrmk you need to fork this repository, clone your fork, push it there and then create a Pull Request from there to here.
More info: https://opensource.com/article/19/7/create-pull-request-github

Anyone please kind enough to help how to implent the above?
Of course I have installed the Tapo cameras integration and I can see live camera in HA but with default card.
I try to edit the card inside HA and insert the above code and I get this:
Visual editor is not supported for this configuration:
Key 'entities' is not expected or not supported by the visual editor.
You can still edit your config in YAML.

It is done.
https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/blob/main/examples/EXAMPLES_LOVELACE.md
https://github.com/JurajNyiri/HomeAssistant-Tapo-Control/blob/main/examples/EXAMPLES_ENTITIES.md
If you are having trouble with picture glance card, read the official documentation.
If you are still having issues, reach out for help in community forums.


WIP feat: add some optimizations

@basil-wolf
Hello, I have rewritten and optimized the plugin.
I still have to update the examples and demos.
If you want to re-read the code or have any suggestions, that would be much appreciated :blush:
Have a nice day.

Hi @bgrand-ch , thanks a lot for updating the plugin. It works fine on iOS as I can test it right now. Amazing work!

Hello @basil-wolf
Thanks a lot for your tests on iOS and for re-motivating me for this plugin.
Have a nice day.

 Thank you so much!


Execute asynchronously and allow adding extra arguments

I wanted to run one instance of Vim and switch between both editors without having to close Vim every time.
To achieve this I've added the synchronous checkbox to use exec instead of execSync and the extraArgs field to add --servername vscode --remote-silent to the parameters so only one instance of Vim is used.
I've just tested it with MacVim but seems to work nicely.

This looks nice! Thanks for figuring out the sync/async thing. I can confirm it works on linux with gvim too.
I have some reservation about the Extra Args option since it would open up a new class of hard-to-debug user problems. Examples:  what happens when the user puts " characters in there, or a simple alphanumeric string, which vim sees as a file to open. The error reporting for these problems is very lacking. What kind of use cases does Extra Args benefit?

What kind of use cases does Extra Args benefit?

The only other useful options I see for Extra Args are:

-u/-U to load a different vimrc/gvimrc when running from this plugin
--cmd to run an arbitrary command
Maybe also -S to load a session file (I'm not sure about this one since I'm not a session files user)

Further improvements may include being able to add some variables to the text field to run an instance of Vim per project with something like --servername ${projectPath} --remote-silent.
Nonetheless I understand your concerns and if you prefer to keep it more controlled I can remove the text field and add another checkbox for Single instance, but in that case we should remind users that checking it also requires to uncheck the synchronous one.

There are two separate features in this PR, and I'm not sure which @huyz is referring to.
It seems that this PR doesn't currently work. When I run it locally and don't set the Extra Args setting, it interpolates null into a string for shell execution.

I was referring to the async part.

It seems that this PR doesn't currently work. When I run it locally and don't set the Extra Args setting, it interpolates null into a string for shell execution.

My bad, this last commit should fix this issue


Create MissingH1.md

:warning: Validation status: warnings

File
Status
Preview URL
Details

azure-docs-cli-python/MissingH1.md
:warning:Warning
View
Details

azure-docs-cli-python/MissingH1.md

[Warning] H1 is required. Use a single hash (#) followed by a space to create your top-level heading. See http://aka.ms/MarkdownHeadings for more information.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat(wash-cli): add CLI styling to wash

Feature or Problem

Adopt styling similar to cargo for wash CLI commands. This doesn't change our overridden help-text, but it does affect commands individually. We might want to consider changing/updating our overridden help/maybe not overriding it as well (or colorizing it ourselves).
Before

After

Related Issues

Release Information

Consumer Impact

Testing

Unit Test(s)

Acceptance or Integration

Manual Verification

Yeah I figure we can address that in a follow up! The decision there isn't quite so straight forward

Here's that follow up issue: https://github.com/wasmCloud/wasmCloud/issues/2873


Increase max line length in flake config to 100

with indentation and the names of namespace being long, 79 chars more often than not is insufficient.
Note: PyCharm has a default of 120 chars

Can one of the admins verify this patch?

@aakarshg thoughts?

with indentation and the names of namespace being long, 79 chars more often than not is insufficient.
Note: PyCharm has a default of 120 chars

You can add a #noqa to the lines that are long, to avoid the issue. This stackoverflow question and answers help with understanding why it's the way it is and why and when one cna propose a change...  One of the main reasons is following:
Keeping your code human readable not just machine readable. A lot of devices still can only show 80 characters at a time. Also it makes it easier for people with larger screens to multi-task by being able to set up multiple windows to be side by side.

Readability is also one of the reasons for enforced line indentation.

I don't have a strong opinion about this PR and given that i'm not a big contributor, it'll make the most sense to have significant contributors/maintainers to decide this.

I think we need at least 90-100 characters in each line. With many conditional statements, each line in the inner block has to be split into multiple lines.

I agree with @aakarshg comment that we need to keep our code human readable not just machine readable but 79 chars seem to be too low and is causing issues when there are multiple inner blocks making it hard to code/read like @mohit-sheth and @yashashreesuresh mentioned. Increasing it to 100 should be okay IMHO.


Don't subscribe to pointer capture events on unsupported Android devices

Closes #5030.
All the other events in AndroidMouseHandler have been added prior to API 21 and as such do not require their own guards.
@Susko3 please test that this doesn't regress any mouse capture functionality from #4989 as I lack the requisite hardware.

Works as expected here.


Can I dial in the meeting from PSTN(desktop phone)

Greeting。Can I dial in the meeting from my desktop phone,   when my PC has some problem (hardware/network),  I want to use my desktop phone call a telephone number  to join the meeting.
Thank you.

out of scope for this project

dogegarden-telephone incoming


Computing MRO

Hi @pawamoy,
I've had time to start working on pydocspec again.
Here is the code I used to compute the MRO. The algorithm is encapsulated in a generic class such that we can use that with any kind of objects representing a class.
https://github.com/tristanlatr/pydocspec/blob/main/pydocspec/mro.py
The concrete class: https://github.com/tristanlatr/pydocspec/blob/fd25e4eaf47de6fca6706283296316a6ae515955/pydocspec/processor.py#L117
Here are the tests: https://github.com/tristanlatr/pydocspec/blob/main/pydocspec/test/test_mro.py
Hope this helps.
PS: there is a lot of overlap between griffe and pydocspec.. maybe there is something to do about it?

Hi @tristanlatr :slightly_smiling_face:

I've had time to start working on pydocspec again.

Nice, I already looked a bit what you recently committed (quite of lot of code!), I'll try pydocspec again soon :+1:
Thanks for the links to your code for computing the MRO, that will be helpful indeed.

PS: there is a lot of overlap between griffe and pydocspec.. maybe there is something to do about it?

Yeah I was not a really good team player here... doing things on my own... I guess I really needed to scratch that itch.
It's true that there is overlap, but I'm sure there are significant differences as well. And goals.
I did not entirely followed the spec from docspec, but I can totally try to come closer to it (it's not that far already), if it fits the requirements I have for mkdocstrings.
Maybe you had something else in mind?

Done in #170. Thank you so much again for your help @tristanlatr :rocket:


Add New feature Flag to Emoji

Add New feature - Flag to Emoji

Usage
   detailLabel.text = flag.emoji // 🇸🇪

Limitation
Some regional flag like califonia in USA(US-CA) not supported currently because depending on OS's supporting unicode
However almost 99% flags used in FlagKit covered added unit tests

This one is cool!

I made a library flag extension

Flag to Emoji
Flag Emoji to UIImage

https://github.com/cruisediary/Flags :)