Plugin doesn't work anymore after Zabbix/Grafana Upgrade to v6.4.2 and v9.5.1

Describe the bug
I no longer receive any data from localhost Zabbix Server. Grafana Zabbix-Plugin Connection test says it's ok ("Zabbix API version: 6.4.2, DB connector type: postgres").
I updated Zabbix from 6.4.1 to 6.4.2, Grafana from 9.5.0 to 9.5.1 and the plugin from 4.3.0 to 4.3.1 (I downgraded again to 4.3.0. but still the same problem, so i think zabbix server breaking changes oder grafana breaking changes?)
When i directly explore the postgre connection in Grafana i receive data normally. But the grafana-zabbix plugin does not seem to use this connection properly. (But what speaks against the suspicion of an error on the part of Zabbix or Grafana?)
Software versions

Grafana
Zabbix
Grafana-Zabbix Plugin

9.5.1
6.4.2
4.3.1

For what it's worth: I have the same problems than mentioned in this ticket. (+ the missing dashboard from another ticket)
Installed on newly created Debian 11 VM:

Zabbix 6.4.2
Grafana 9.5.1
Grafana-Zabbix plugin 4.3.1
PostgresQL 15.2-1 with TimeScaleDB 2.10.3

Less important, but still: In plugin configuration the "Dashboard" tab does not work. Files do not seem to exist on disk ?

Blocking issue: Plugin does not get data from Zabbix. Tested with and without direct DB connection in plugin.
Plugin Test works:

I can also access the tables from PostgreSQL data source. But Zabbix datasource stays empty, without any errors.
I once got the host groups to show up, but host was always empty. After server restart i was no more able to even get the host groups populated.

Same thing here, I just deployed Zabbix in docker earlier in the week and it was working fine. What's confusing me is that nothing should have updated, Zabbix is on V 6.4.2 but it has always been so why did it stop working all of a sudden?

I know it doesnt solve the problem, but you can point to a specific item ID, and it will show the graph for that. So there is some kind of connection...

Is this problem still ongoing? Has anyone discovered a workaround?
Thanks in advance!

Same here, Plugin test works but in the query doesn't show anything like groups etc.
Zabbix : 6.4
Grafana : v10.2.2
Plugin : 4.4.4

Hi all,
We had the same issue in our Zabbix-Grafana implementation. The problem was that our grafana user account in Zabbix didn't have permissions to the host groups. Once we configured the grafana user account within Zabbix to have permissions on the host groups, it then worked.


"Help > Report Issue" goes to a broken link if not logged into GitHub

Spyder>Help>Report Issue... loads a page with "Ooops!!! 500" error.
I think because I was not logged into GitHub.
After i logged into GitHub Help>Report Issue... started working and brought me here.
To a beginner trying to report a problem (me) solution was not obvious/disconcerting.
The URL was:
https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fspyder-ide%2Fspyder%2Fissues%2Fnew%3Fbody%3D%253C%2521---%2520%252A%252APLEASE%2520READ%253A%252A%252A%2520Before%2520submitting%2520here%252C%2520please%2520carefully%2520consult%2520our%2520%252ATroubleshooting%2520Guide%252A%253A%2520https%253A%2F%2Fgithub.com%2Fspyder-ide%2Fspyder%2Fwiki%2FTroubleshooting-Guide-and-FAQ%2520and%2520search%2520the%2520issues%2520page%2520for%2520your%2520error%2Fproblem%252C%2520as%2520most%2520posted%2520bugs%2520are%2520duplicates%2520or%2520easy%2520fixes.%250A%250AIf%2520you%2520don%2527t%2520find%2520anything%252C%2520please%2520provide%2520a%2520detailed%2520step-by-step%2520description%2520%2528in%2520English%2529%2520of%2520the%2520problem%2520and%2520what%2520led%2520up%2520to%2520it%2520below.%2520Issue%2520reports%2520without%2520a%2520clear%2520way%2520to%2520reproduce%2520them%2520will%2520be%2520closed.%2520Thanks%2521%2520---%253E%250A%250A%2523%2523%2520Problem%2520Description%250A%250A%2523%2523%2523%2520What%2520steps%2520will%2520reproduce%2520the%2520problem%253F%250A%250A%250A%250A%2523%2523%2520Package%2520Versions%250A%250A%252A%2520Spyder%2520version%253A%25203.2.8%2520%250A%252A%2520Python%2520version%253A%25203.6.4%250A%252A%2520Qt%2520version%253A%25205.6.2%250A%252A%2520PyQt5%2520version%253A%25205.6%250A%252A%2520Operating%2520system%253A%2520Windows%25207%250A%250A%2523%2523%2523%2520Dependencies%250A%250A%2560%2560%2560%250Apyflakes%2520%253E%253D0.6.0%2520%253A%2520%25201.6.0%2520%2528OK%2529%250D%250Apycodestyle%2520%253E%253D2.3%253A%2520%25202.3.1%2520%2528OK%2529%250D%250Apygments%2520%253E%253D2.0%2520%2520%2520%253A%2520%25202.2.0%2520%2528OK%2529%250D%250Apandas%2520%253E%253D0.13.1%2520%2520%253A%2520%25200.22.0%2520%2528OK%2529%250D%250Anumpy%2520%253E%253D1.7%2520%2520%2520%2520%2520%2520%253A%2520%25201.14.0%2520%2528OK%2529%250D%250Asphinx%2520%253E%253D0.6.6%2520%2520%2520%253A%2520%25201.6.6%2520%2528OK%2529%250D%250Arope%2520%253E%253D0.9.4%2520%2520%2520%2520%2520%253A%2520%25200.10.7%2520%2528OK%2529%250D%250Ajedi%2520%253E%253D0.9.0%2520%2520%2520%2520%2520%253A%2520%25200.11.1%2520%2528OK%2529%250D%250Anbconvert%2520%253E%253D4.0%2520%2520%253A%2520%25205.3.1%2520%2528OK%2529%250D%250Asympy%2520%253E%253D0.7.3%2520%2520%2520%2520%253A%2520%25201.1.1%2520%2528OK%2529%250D%250Acython%2520%253E%253D0.21%2520%2520%2520%2520%253A%2520%25200.27.3%2520%2528OK%2529%250D%250Aqtconsole%2520%253E%253D4.2.0%253A%2520%25204.3.1%2520%2528OK%2529%250D%250AIPython%2520%253E%253D4.0%2520%2520%2520%2520%253A%2520%25206.2.1%2520%2528OK%2529%250D%250Apylint%2520%253E%253D0.25%2520%2520%2520%2520%253A%2520%25201.8.2%2520%2528OK%2529%250D%250A%2560%2560%2560%250A
Package Versions

Spyder version: 3.2.8
Python version: 3.6.4
Qt version: 5.6.2
PyQt5 version: 5.6
Operating system: Windows 7

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.22.0 (OK)
numpy >=1.7      :  1.14.0 (OK)
sphinx >=0.6.6   :  1.6.6 (OK)
rope >=0.9.4     :  0.10.7 (OK)
jedi >=0.9.0     :  0.11.1 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.27.3 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.2.1 (OK)
pylint >=0.25    :  1.8.2 (OK)

Thanks for reporting. We're in the process of improving how users report issues to Github, so we'll fix this as part of that.

@ccordoba12 The trouble here is that due to having to pass the full URL as a parameter, even more things are percent encoded, making the length even longer, in addition to the marginal additional length of the actual URL content.
The solutions here are basically what I outlined in #6870 . The best way to really make a big dent in the length is to greatly cut down on the spaces and special characters in the deps section (e.g. min versions, since with the OK they are redundant, extra spaces before and after : , parens around OK, etc.) and cut any deps if possible that have never posed a troubleshooting issue and are unlikely to (psutil on macOS/Linux, sympy? nbconvert? pygments ?). This will have far more bang for the buck in cutting down on characters than removing any more from the existing text, which has already been cut to the bone (though any more we can remove won't hurt); just doing the above suggestions will cut down the total length by around 1/3 while sacrificing little to no valuable information.
The alternative is making the menu option use the new error report dialog as well, but that adds extra complexity and time for the user which can likely be avoided.

Yeah, my idea is to use the new report error dialog to handle the Report issue... action too.


Merge way nodes

Fixes #3774
There is an ability to merge way endpoints

This looks pretty good - I have some questions..

It looks like it only merges end nodes.  I know that matches with the description in #3774, but I think it would be useful to merge any nodes (for example to merge one end node with one internal node to make a 'T' junction).
What does it do with tagged nodes? - it should probably merge all the tags too.
Can you add a test for this new action under test/spec/actions/ ?

@bhousel You are right. I didn't pay attention. I'll work on it.

@bhousel can you check it pls?

Thanks for feedback @Nakaner . Agree with you. I'll work on it

Deleting such ways as @Nakaner has mentioned can also be a problem.

Valueable features might get lost and the user wouln't always be aware, for example if turn lane was tagged on the two-node way.
Some features/properties of such a way might need to be transfered to the merged node, e.g a highway=platform.
Relations might be broken, e.g. when deleting from or to members of a turn restriction. via membership needs to be transfered to the merged node if no other via member is left. Multipolygons might become invalid because inner members get connected to outer members.

Just a quick update - the work I just did to close #4921 is relevant here.  We now have some pretty good checks to prevent node merges from breaking relations and turn restrictions.  I'm going to try to get this merged after releasing iD v2.8

Ok I rewrote some of the code to reuse actionConnect which already handles all of the cases in the comments above.   Merging!


Proper BLEU evaluation

thank you, this would be really useful, I was thinking it would be an issue for token tokenization but mose's fine. I did not remember if mose support Chinese tho.

@colmantse: there is a Chinese-tokenization version of BLEU (used in recent WMT) https://github.com/mjpost/sacreBLEU/blob/b38690e1537cd4719c3517ef77c8255c5a107cc8/sacrebleu.py#L414-L528
and a related improvement https://github.com/mjpost/sacreBLEU/issues/5
It could be easily added here, but it's a question whether it would not be better to integrate sacreBLEU as a dependency to prevent code duplication - but I don't have time for this.
My current plan is to fix the failing Travis tests (update the bleu_hook test so it takes into account the smoothing) and also add an option to wait for new checkpoints being created.

WMT17 homepage references the same chinese character n-gram here: http://www.statmt.org/wmt17/tokenizeChinese.py

Hello,
I worry the bleu-hook is not division-by-zero-proof:
Traceback (most recent call last):
  File "t2t-bleu", line 242, in <module>
    tf.app.run()
  File "/lnet/spec/work/people/machacek/t2t-second/p3-t2t-gpu-fork/lib/python3.4/site-packages/tensorflow/python/platform/app.py", line 48, in run
    _sys.exit(main(_sys.argv[:1] + flags_passthrough))
  File "t2t-bleu", line 232, in main
    count_bleu(FLAGS.reference, out_file, ptag="")
  File "t2t-bleu", line 225, in count_bleu
    bleu = 100 * bleu_hook.bleu_wrapper(FLAGS.reference, out_file, case_sensitive=False)
  File "/lnet/spec/work/people/machacek/t2t-second/p3-t2t-gpu-fork/lib/python3.4/site-packages/tensor2tensor-1.2.9-py3.4.egg/tensor2tensor/utils/bleu_hook.py", line 197, in bleu_wrapper
    return compute_bleu(ref_tokens, hyp_tokens)
  File "/lnet/spec/work/people/machacek/t2t-second/p3-t2t-gpu-fork/lib/python3.4/site-packages/tensor2tensor-1.2.9-py3.4.egg/tensor2tensor/utils/bleu_hook.py", line 117, in compute_bleu
    bp = math.exp(1 - 1. / ratio) if ratio < 1.0 else 1.0
ZeroDivisionError: float division by zero

@Gldkslfmsd thanks for bug report, but I believe this is not related to this PR (although we could fix it here) - I have not changed the way brevity penalty is computed.
I believe this can happen only if the translation_length is zero, i.e. no translation was produced for the whole corpus. Can you confirm this is the case?
I agree the script should not fail, but produce BLEU=0 and also a warning.

I believe this can happen only if the translation_length is zero, i.e. no translation was produced for the whole corpus. Can you confirm this is the case?

Yes. And maybe it can happen if the reference file is empty.

I agree the script should not fail, but produce BLEU=0 and also a warning.

+1

@Gldkslfmsd: your error was because of empty translation. Empty reference would fail elsewhere.
Either way, I changed my mind and I think this is very suspicious, so we should fail with a clear error
rather than return bleu=0. Thus I have added two assertions.

It happened because I was making my own extension to this code and I was
debugging it on a one-line source file. Some models translated it as a
blank file, but it was a valid translation. So I would vote for no crash in
this case.
2017-11-30 20:41 GMT+01:00 Martin Popel<EMAIL_ADDRESS>
@Gldkslfmsd https://github.com/gldkslfmsd: your error was because of
empty translation. Empty reference would fail elsewhere.
Either way, I changed my mind and I think this is very suspicious, so we
should fail with a clear error
rather than return bleu=0. Thus I have added two assertions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensor2tensor/pull/436#issuecomment-348298244,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFEYXev9snMyS5QlMv63-dclmdeVlYG7ks5s7wT3gaJpZM4QngOp
.

FYI:
https://github.com/Gldkslfmsd/tensor2tensor/commit/697e50679b385ebd4829abd35b7aa8911d31b21f


Add managed combinator to Fiber

Closes #628.

Makes sense, I’ll adjust that.

On Mar 13, 2019, at 8:59 PM, Itamar Ravid<EMAIL_ADDRESS>wrote:
@iravid commented on this pull request.
Thanks for working on this!
Joining in the acquisition means that there’s no reason to interrupt on the way out.
The more useful thing to do is just to provide the fiber itself in the acquisition.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@iravid added a sample test. Unfortunately, I seem to be lacking knowledge of internals in order to verify fiber is interrupted during release, therefore, the test is merely one example of using "fiber as managed".

@iravid Since you've overseen this one, can you do final signoff? Thanks!


[Doc Improvement][Add links in see also shared channels]

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/build-and-test/shared-channels.md
93
6
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 2ac65a7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/concepts/build-and-test/shared-channels.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


New behavior

In order to make my project running correctly, I had to to modify the behavior of your provider.
I needed the locale var in each of my urls.
So your example will change as follow :
/test - url for default locale without prefix
/hu/teszt - url with prefix and translated
/ua/test - url with prefix
/en/test - url for default locale without prefix
/hu/teszt - url with prefix and translated
/ua/test - url with prefix
I think this feature will affect so much the initial provider, so I can fork your code and make a new one.
What do you think?

Finally I created my own provider without translation service.

Also look at umpirsky/I18nRoutingServiceProvider it seems  not supported anymore but do what you want


my position on the SH map is no longer good

Hello, since the latest updates of sondehub, my position on the map is completely shifted, I have the right coordinates, but each time I open SH I find myself located 450 km from my position saved in SH, I haven't touched anything in the config, everything worked perfectly about 15 days ago, I have exactly the same problem on my 4 PCs, I redid the detection of my position, deleted the history, set my default position, etc. but nothing to do it always locates me at the same position (see screenshot), and this since the latest updates of SH.
thank you

interestingly this seems to go wrong every second time using this url https://testing.v2.sondehub.org/#!mt=Mapnik&mz=7&qm=3h&mc=48.01198,4.61426 for me on safari

Hello, exactly that and if I close the window immediately the position will be correct, but if I open it 5 minutes later, the position is in the center east of France, and when I click on my coordinates in the blue banner, it locates me perfectly, my Firefox bookmark is saved with my coordinates, but it changes when SH starts to other coordinates, I deleted, redid, modified etc etc, always the same problem, this problem appeared about 8 days ago, with the last updates of SH, and before that everything worked perfectly.


Does not work for education account

Unfortunately this great feature does not work with the free O365 (M365) version. It is not allowed to create ressources. You should give a hint. This saves hours of searching where the problem arises from.
Hardy

Hi HardyKrause.  Apologies for the difficulty.  Can you be specific about where you ran into a problem with deployment?  Reflect does require an Azure account capable of creating new Resources.  I believe this is possible with the free Azure trial but will confirm that and update with a notice if that is not the case.


Add support for Carthage

Hi.
could you please add support for https://github.com/Carthage/Carthage?

+1

+lots
We simply need a framework target, and uses of [NSBundle mainBundle] should be replaced with [NSBundle bundleForClass:] to correctly reference its resources (this is considered good practice anyway).

+∞

+1

For carthage support, you can checkout https://github.com/hemantasapkota/mixpanel-swift.
It adds the mixpanel-iphone project as a git subtreee module and wraps it with a Swift framework with Carthage support.
Thanks

@hemantasapkota Thanks for that, but obviously it is better for all concerned if Carthage support is provided by the repo owner.
PR #252 should make this possible (thanks to @simX)

Yep, I agree. This is meant as a temporary solution.

Carthage support is added now with #252. You can build from carthage from master now.

Hi,
Carthage does not seem to be working anymore (either updating for all platforms or only for iOS).
Can you help please?
Thanks,
Axel

Hey @alpennec this is definitely an issue. Looking at it now.

Thanks @samgreen. Any idea when this is going to be resolved? Thanks!

@alpennec: A quick workaround is to set the version to 2.9.1 by writing this in your Cartfile:
github "mixpanel/mixpanel-iphone" == 2.9.1

I created an issue for this btw, found here: https://github.com/mixpanel/mixpanel-iphone/issues/427


Add support SWIG 4.1.0, drop support for < 4.0.2

https://bugs.gentoo.org/878587

Unsure how this affects Ubuntu, but Ubuntu 20.04 LTS which has End of Standard Support (ESS) on April 2025 and End of Life (EOL) on April 2030 still has Swig 4.0.1.
# apt show swig4.0
Package: swig4.0
Version: 4.0.1-5build1

Yeah, I've updated the number in CMakeLists to 4.0.1, because Ubuntu 20.04 is used in our CI.
I'm increasing this number only because I can't test what happens with older versions, and there's an easy escape hatch anyway, when using tarballs.
I just didn't update the title of the PR


Confirmation controllers are racy

Issue
There is currently an issue with Confirmation controllers - due to the way a Dial is marked :answer, it's somewhat easy for multiple confirmation controllers to complete if the pre_join or actual joining of two calls takes an appreciable amount of time.
The issue is in this function: https://github.com/adhearsion/adhearsion/blob/b8692af19b40a91a28d487746a72921bdd0d5a7d/lib/adhearsion/call_controller/dial.rb#L171-L183
We're currently not calling status.answer! until L179, after all the joins are completed.
Any Confirmation Controller that completes while Adhearsion is processing  lines 172-178 will attempt to join, which at least on Rayo results in a fatal error multiple joined calls not supported that hangs up all legs.
Possible Solutions

Move @call.answer && status.answer! to line 173 and mark the call as answered immediately upon Confirmation completion.
Since the tasks are pre_join, we're still executing them in the correct context. But does this change the meaning of what an :answered call is for some people? IMHO it doesn't, as the call was answered (FS/Asterisk will send a 200 OK and a person did pick up), even if the join fails. People can check the join_status on the resulting call if there are further problems.

Set up a queue of calls that have completed Confirmation and are awaiting joining. Once one successfully joins, the others are released.

Something else?

Perhaps we could rescue the exception and then deal with the failed legs properly?


Play the audio file loop. and It is useful.

It's possible right now through editing the queue but I've received a couple requests for this so I'll look into making a solution within the library

The issue #124 is about play loops

Hey! Added looping in the library accessible through SAPlayer.Features.Loop.enable() and SAPlayer.Features.Loop.disable(): https://github.com/tanhakabir/SwiftAudioPlayer/blob/98dc7cfa3cbf8102d7f191d17ad85e89fbd37af6/Source/SAPlayerFeatures.swift#L135-L156


Export displayName

Fixes React Styleguidist 5 compatibility.

Hi @pvasek
Can you please run a release? :)
Im awaiting this change into my latest version for my components/props to work :) (they do not display currently - which is due to an parser error)
Best

Lucas

@Dechowmedia Of course, sorry, it's not automatic yet. You should be able to get version 0.0.4 from npm now.

Thank you so much @pvasek <3 - That concludes my issue and I can close the feature request on my end


Add MIT license

looks good :+1:

Commits:
https://github.com/nerthus-margonem/nerthusaddon/commit/49e82aa794618e19746c9b3cb90c21f53e50b5d9
https://github.com/nerthus-margonem/nerthusaddon/commit/022ccf98a8c55e5eed3a60b0eb6d623aa5dfdfc4
are also subject to this license.


ResNet152 ONNX model inference on MXNet with EIA

Adding example for showing resnet152 model from ONNX model zoo to run inference on EIA

@laurenyu Can you please review/merge this PR?

@laurenyu Thanks for reviewing. Addressed all comments. Can you take a look again?


Limit creation of root data store to be possible only in detached container

We do not have good tools to resolve race conditions that would happen from calling this API in attached container from two clients.
Various experimentations (like "aliasing" proposal) make it possible, but are not ideal (adding more concepts that are hard to use),
Instead we should push developers to not create root data stores after container is attached, and improving tooling in other areas. For example, today developers can use Consensus Registry Collection to resolve conflicts like that, but that requires extra DDS and keeping handles to data stores in another DDS (usually, that's left to root map in DataObject).
We should see if making it more streamlined (maybe having this functionality in the form of atomic compare-and-swap on a map key). Also as we advance our understanding and tooling for merging (including 3-way merge capabilities), it's possible other tools would materialize that would make it non-issue.

I don't think we can migrate to this today. Our collection component creations still happen after container attach (lazily created for whenever a collection instance is inserted) and I have not convinced myself I can migrate this capability fully to root component because that means that others extending base-container will not automatically get collection component management which is mandatory for using lot of our ecosystem like date/atmentions/any other component who might want to implement themselves via the collection managed create pattern.


boards: dts: nrf: Remove SoC compatible in top-level compatible

The SoC node has compatibles for the specific SoC in place, having the
same compatible at the top level is technically a conflict and the
top-level one should really just be about the board.  Remove the SoC
related compatibles at the top-level.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

I love (not) when stuff that touches a bunch of files gets fast-tracked and merged with input from a small subset of those affected.  First I saw of this was https://github.com/zephyrproject-rtos/zephyr/pull/24769#pullrequestreview-402724143 and it was already too late.
This removed compatibles at the root that are not present anywhere else: e.g. there's no longer a visible compatible to identify a particle,feather which is the generic of particle,xenon.
It's not that it's a big deal, but I put that there for a reason, and now I need another solution.

I misread what this changed (it conflicted with a local change during rebase).  Sorry, looks like this wasn't the cause of my problem.


Upgrade will start container even through not set

In this Rancher and in earlier versions the issue exists, that when you try to upgrade a service and the service is stopped, the containers go through the following states:
stopped => started => stopped => new ones created => new ones started

expected:
new ones created => new ones started

And yep, the checkbox in the upgrade dialog is not ticked:

Best regards
Max

Useful
Info

Versions
Rancher v1.6.15 Cattle: v0.183.45 UI: v1.6.42

Access
localauth admin

Orchestration
Cattle

Route
stacks.index

@mxschmitt Hi, did you find a workaround for this issue?

@guewen Nope, I tried to reproduce it in the current release (1.6.20) and the same issue is reproduceable.
The states are when you try to upgrade a stopped container:

stopped (initial state)
started
stopped
new one created
new one started

it should be:

new one created
new one started

Best regards
Max

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Pin x264 dependency

This is the more proper resolution of x264-feedstock issue 16, according to isuruf on slack who guided me through this change

Checklist

[ ] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

How feasible would it be to update older ffmpeg versions with this fix?

@pgunn I have rebased to a more informative message + squashed and updated the PR.
Building this locally, I get a concrete pin like >=20180501,<20180502.0a0. Is that what we want? If so, this LGTM and I think we should merge as soon as possible.
@hajapy That is a good question...

Thanks a million @pgunn

@sdvillal The credit really goes to isuruf (on your chat) for the solution; I didn't do a lot more than notice the issue.

We should have probably waited for this before merging: https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/51 (?)

Sure, I understand it's a bad and urgent situation, I'm not criticizing 😉.
I'm quite a beginner in this pinning stuff, but in my understanding now we are left with a (temporary?) divergence between x264 version pattern and pinning pattern. Moreover, I have no idea of how conda will deal with the comparison between 20180502.0a0 and something like 20180713.

Also a pinning newbie here. I think that once x264 gets pinned in CF, we just need to bump the build number to get a correct pin spec.
I think the current pin means that 20180713 could not be selected. So at worst we are left with a too strict pin for this version of the package. Is that the case?
I do not think there is anything in conda-forge depending on x264 other than ffmpeg, and it has been a bit too audacious to update x264 without the pins and downstream being well fixed.

I do not think there is anything in conda-forge depending on x264 other than ffmpeg, and it has been a bit too audacious to update x264 without the pins and downstream being well fixed.

I agree.
Looks like opencv is also broken https://github.com/conda-forge/x264-feedstock/issues/16. We should probably rebuild it with the new pinned ffmpeg, right?

AFAICT no, opencv gets to depend ononly  x264 via ffmpeg.

What we might need to do is to also pin x264 in older versions of the ffmpeg package.

So why is it broken then? AFAIU If the reporter updated x264, then it will break.

What we might need to do is to also pin x264 in older versions of the ffmpeg package.

yup, and....how do we do that? do we need to open a branch for each old version and pin the package?

That is the question @hajapy asked. I do not know if conda-forge contemplates this case. I fear we might need to open these branches (for example, checkout the immediate pre 4.0 commit, create a branch from it, pin x264, push). PITA.
I will ask in the x264 pinning what they recommend us to do.

Might it make sense to withdraw the new x264 until this is all prepared?

So we need to decide:

If we fix this in some older versions or instead we ask people to either update their environments or explicitly restrict the x264 version in their environment should anyone else find a broken environment.

If we decide to also fix this on some older versions, which ones. In the CF channel we have currently published 4.0, 3.4.2, 3.4.1, 3.2.4 and 2.8.6.

My recommendation would be to rebuild opencv with newer pinnings (including newer ffmpeg).

Rebuilding opencv with a pin to ffmpeg release blah? I do not think it is better. I actually think it is worse. If we have users that value environment stability, they won't like to see their ffmpeg being bumped. Also, there are other downstream dependencies for ffmpeg (pyav, for example).

@sdvillal I think we need to embrace the PITA and pin the old ffmpeg versions, if this is feasible.

Agree @carlodri, it is not so much work. Will try during the weekend.

That's actually how we handle pinnings generally though. We periodically rebuild things with newer versions. PR ( https://github.com/conda-forge/opencv-feedstock/pull/113 ) is already lined up to do this. Just needs some small fixes.
So I understand the desire of having reproducible environments. Though I may not understand your use cases well. Is there any reason to update the environment at all? If not, this issue can be avoided by using a spec file.
Also we should mark the ffmpeg packages without x264 pinning as broken so they don't get pulled in. If you have time, help generating a list of such packages would be very useful.

Hi, this diff didn't actually seem to fix the issue (either that, or a new version didn't make it out).

In theory, this should have fixed ffmpeg 4.0 (at least it does in pristine environments). I'm waiting for either https://github.com/conda-forge/x264-feedstock/pull/18 or https://github.com/conda-forge/x264-feedstock/pull/19 to be acepted and then to have some spare time to proceed and fix the other ffmpeg releases, that in turn should not only fix older ffmpeg versions but also would fix downstream packages that pins them (opencv, pyav).
If it takes long for one of these PRs to be merged, we could though also proceed without these modifications in the x264 packages and just pin x264 to 2013XXXX in older ffmpeg versions; that should fix them regardless on how we move forward with the x264 package.

@pgunn Please give a concrete and reproducible example.

then to have some spare time to proceed and fix the other ffmpeg releases

@sdvillal if you give me a couple of hints on the process, I'm happy to help (and learn!).

@carlodri basically I think the best way we can solve this is to pin x264 in old ffmpeg packages. My idea would be to 1) find the last commit for each version 2) create a new branch for the version 3) apply whatever fix we decide to. It can easily be done manually.
I went all the way for the fun and automated it with some code I had around. This script finds each candidate commit, branches it out, applies a fix, commits it and pushes the new branch. The script is quite ugly, as I have not used git porcelain and created a class that is not needed, but hopefully it conveys the idea. It actually works - see my ffmpeg-feedstock fork.
Whether this approach is appropriate or CF has a better way to deal with these kind of hotfixes, I do not know. But I believe it should work without more work (except new problems that might appear when creating these packages in the CI). Maybe there is a better way to do this  - there is lots of code for manipulating feedstocks I'm not aware of.

@183amir conda create -n failx264 python=3.6 opencv ; source activate failx264 ; python
and then "import cv2".
@sdvillal If this is going to take more than one more day to land and become effective, IMO it'd still make sense to blacklist the x264 to unbreak the world as a stopgap.

Current and past opencvs pin ffmpeg to <=3.2.something, which are not fixed yet.
Sorry that this is getting long. The solution here should be ready to go, so it should be the enhancement in the x264 package versioning. I would love to just get them in, but we are a bit lost bureaucracy.
To unbreak environments in the meantime, pin x264 to 20131218 in them.

@sdvillal sorry for the late feedback, and thanks for the interesting code, I'm yet to discover scripting git repo operations!
I think that the ffmpeg conda recipe  has undergone a lot of restructuring and improvements lately (including, but not limited to, the new compiler syntax stuff), so maybe it could be wiser to branch the current master and in the new branch modify the version-related stuff (version number, sha, build number) and pin x264. In this way, we would take the opportunity to "backport" improvements to the recipe. Obviously, it's more work than simply running a script, but maybe it's nicer... What do you think?

I have pushed a final update to the script (we needed to explicitly disable openssl for 3.4.x and windows for 2.8.6). All CI jobs have now successfully completed and fixed packages are uploaded. The exception is the mac build for oldie 2.8.6 that fails only on the final upload phase - if that is ever needed I suggest retrying the build at a later time.
Please, open a new issue if anything fails.

@sdvillal thanks for the great work.

@183amir It has been done already.

should happen soon; 2) that is a nice writeup; 3) we did this by creating a branch per package and applying pertinent pins (another question is whether conda solver will always pick the newer builds).

This was an emergency intervention under the premise that old packages should not be broken because their dependencies get new releases.


added a test for nested routes

This is following #1574. The test you added was passing in beta3 so I added a test case which fails. Note that it's now passing against master (which is nice)! It's just to make sure we cover all cases.
This is against beta3

And this is against current master

If you want to test against beta3 the code needs to be adapted a bit
describe('at a route with special characters', function () {
  it('does not double escape', function(done) {
    // https://github.com/rackt/react-router/issues/1574
    let MyComponent = React.createClass({
      render () { return
{this.props.params.some_token}
 }
    })

    React.render((
      <Router history={new MemoryHistory('/point/aaa%2Bbbb')}>
        <Route path="point/:some_token" component={MyComponent} />
      </Router>
    ), div, function () {
      expect(div.textContent.trim()).toEqual('aaa+bbb');
      done();
    });
  });

  it('does not double escape when nested', function(done) {
    // https://github.com/rackt/react-router/issues/1574
    let MyWrapperComponent = React.createClass({
      render () { return this.props.children; }
    });
    let MyComponent = React.createClass({
      render () { return
{this.props.params.some_token}
 }
    });

    React.render((
      <Router history={new MemoryHistory('/point/aaa%2Bbbb')}>
        <Route component={MyWrapperComponent}>
          <Route path="point/:some_token" component={MyComponent} />
        </Route>
      </Router>
    ), div, function () {
      expect(div.textContent.trim()).toEqual('aaa+bbb');
      done();
    });
  });
});

thansk :)


Reduces stimpack price to 4 TC

About the PR

Reduced the uplink price for the stimpack to 4 TC from 8 TC
Why / Balance

https://discord.com/channels/310555209753690112/1195158411306868847
The stimpack price is currently 8 TC, for that amount of tc you can buy so much utility. Currently stimpack is a "noobtrap" according to the linked thread.
Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Stimpack price has been reduced to 4 TC

But... Stimkit?

it has triple the reagents so its "balanced" and usually a nukie buy anyway for the team

The stimkit gives you 6 micro-injectors(15u) totalling 90u of stimulants for 12 tc.
This new change makes the 30u stim injectors cost 4 TC so also 12 tc for 90u of stimulants.


Move system conf files out of genie-web to top level

Right now the configuration install files are buried in genie-web. Would be clearer if they were at top level somewhere.

Will impact #131

Will also impact #130


[Updated] Get the expected type for a given ST node position

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes https://github.com/ballerina-platform/ballerina-lang/issues/36539
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Addressed in PR : https://github.com/ballerina-platform/ballerina-lang/pull/38416


Implementation of User Profile Page on Devhub

Problem Statement
Devhub currently lacks a user profile page, hindering the ability of users to view and manage Devhub-specific information in one consolidated location.
User Stories

As a Devhub user, I want a profile page to manage and view all my Devhub-related activities and information.
As a Devhub user, I want to view the KYC/KYB status associated with my account to ensure transparency and trust. Reference ticket.
As a Devhub user, I want to conveniently access and review all my posts made on Devhub from my profile.
As a Devhub user, I want to showcase my achievements on Devhub by viewing and displaying badges I've earned.

Acceptance Criteria

[ ] A distinct profile page should exist for each Devhub user and be readily accessible via the navigation bar.
[ ] The profile page should prominently showcase the KYC/KYB status of the user, ensuring clarity and transparency.
[ ] All posts made by the user on Devhub should be chronologically listed on the profile page, providing an at-a-glance view of user activity.
[ ] The profile page should feature a section dedicated to displaying all the badges the user has earned on Devhub.

Assets
Design Mockup: Figma Link

A similar ticket was raised earlier as well. Closing #63 for now. Will keep track of the development in only this ticket.

Hi @jaswinder6991 – the original ticket had the GitHub element, which is super important to help us establish reputation and understanding of a person's contributions. Can we please keep that ticket / incorporate it into here?

Hi @jaswinder6991 – the original ticket had the GitHub element, which is super important to help us establish reputation and understanding of a person's contributions. Can we please keep that ticket / incorporate it into here?

Hi Ori, thank you. Updated the ticket with the Github activity feature.

Hey @jaswinder6991 – thanks so much for outlining this ticket. It feels more like an epic with several parts that we can tackle independently, some of which already are in progress. I created a milestone called User Profile and broke down the scope into placeholder tickets. I left some comments with product questions/things we need to figure out. Let's regroup in our next call to determine if we still need this ticket.

Hi @frol – cleaning our backlog and wanted to circle back on this ticket. Should we move this to blocked / transfer this work to somebody on the team? Thank you!


Implement move assignment for the bonb::blob type

Pull request for issue #934. The tests are probably overkill, I can remove them if you want. But they showed that
blob& operator=(blob&& that) = default;
would copy the internal buffer instead of moving it, so I chose the swap implementation.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: volka sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Can you give more details on why  you think =default does not work?

@volka can you also rebase this change on top of the latest master branch. Your commit should be after 587bf3865fe271fc3ca758ac31e6f6544a98f478 and right now it is after an almost year old commit<PHONE_NUMBER>086a013ef064387fae1606c4718e39. This is why we are getting conflicting files.

My guess is that =default is less desired, since it will leave the raw pointer unchanged and will behave different from what move constructor already does.

Yes I looked into it and its not correct that it does a copy - the default moves the _buffer but leaves the _content pointer to point to the original storage. That's not wrong but might cause some surprising bugs if someone actually tried to reuse a moved-from blob. I like the swap solution that also swaps _content better. What do you think?
I'll also try to rebase the patch, let's see if that works.

Yeah, the swap is better and move assignment must behave same way as the move constructor.

CI is showing an error on line 2217 of the log https://ci.appveyor.com/project/MicrosoftBond/bond/build/1.0.1653/job/jsdywfk10asoxqij#L2217

Here you go, the AppVeyor problem seems to be the old compiler not wanting to print nullptrs, I hope my workaround fixes that.
I cleaned up the code and testcases as requested, is this better?

Ok here is another patch, I simplified the tests and made the move assignment behave exactly like the move construction.

Ok, next try, addresses review feedback

Yes that makes sense, corrected.

It would be better to send new commits rather than overwriting the previous one. It makes it harder to review this way.

@volka thank you for your first PR to Bond :+1:

Nice, thanks for merging it :smile:


Provide health-check endpoint for gateway

Similarly to the relay, anyone running the gateway will want an HTTP endpoint for health-checks.
We also want OLTP metrics and traces exported, JSON logs, similarly to relay.

@conectado is this one hard to do? It will help a lot debugging connectivity with IPv6 on prod to have it run within the gateway itself

Now a customer ask

Now a customer ask

Just the health-check or also the OTLP metrics and JSON logs as mentioned in the original ticket?

Let's make this issue about the healthcheck and split the OTEL stuff into another issue


ORC-825: Use Empty Array For Collections toArray

What changes were proposed in this pull request?
For Java, use Empty Array For Collections toArray
Why are the changes needed?
JDK recommended, faster, less code.

https://docs.oracle.com/javase/8/docs/api/java/util/Collection.html#toArray-T:A-

How was this patch tested?
Existing unit test

This is merged already via https://github.com/apache/orc/commit/5d8c7a20567f50bbcbe39e482e3194ec92933a76 .


getting ruby-build usage example when trying to run rbenv install

hello,
I am getting the ruby-build man-page when I try to run rbenv install 2.1.5
2.1.5 is in the list and I get the same error message for other builds as well.
It seems like it is passing incorrect arguments to ruby-build.
Ubuntu 14.04.1 LTS
rbenv 0.4.0-129-g7e0e85b
ruby-build 20141225-9-g73988db
thanks,
Mark

Hi Mark, sorry you're having trouble. Is rbenv install 2.1.5 literally the exact command you're trying to run? Are you getting this help text as a result?
ruby-build 20141225-9-g73988db

Usage: ruby-build [-kvp] <definition> <prefix>
       ruby-build --definitions

  -k/--keep        Do not remove source tree after installation
  -v/--verbose     Verbose mode: print compilation status to stdout
  -p/--patch       Apply a patch from stdin before building
  --definitions    List all built-in definitions

Do you have any rbenv plugins? ls `rbenv root`/plugins

yes that is the exact command and no other plugins. here is a cut/paste:
$ rbenv install 2.1.5
Usage: ruby-build [-kvp]
ruby-build --definitions
-k/--keep        Do not remove source tree after installation
-v/--verbose     Verbose mode: print compilation status to stdout
-p/--patch       Apply a patch from stdin before building
--definitions    List all built-in definitions

That is really bizarre. I'll try to reproduce, but in the meantime, try pasting me the output of rbenv --debug install 2.1.5. Use Gist if the output is very long.

Hello,
Thanks for looking into this.
~/.rbenv/plugins/ruby-build(master)$ rbenv --debug install 2.1.5
rbenv: no such command `--debug'
~/.rbenv(master)$ rbenv --debug install 2.1.5
rbenv: no such command `--debug'
I moved the dir and cloned both the ruby-build and rbenv repos again to see
if I would get anything different. Seems the same.
For some context, all was fine until I tried to upgrade to 2.1.5. It wasn't
in the list, so I did a pull on both repos and then I started getting the
man page for ruby-build.
Thanks,
Mark
On Sat, Jan 10, 2015 at 10:46 PM, Mislav Marohnić<EMAIL_ADDRESS>wrote:

That is really bizarre. I'll try to reproduce, but in the meantime, try
pasting me the output of rbenv --debug install 2.1.5. Use Gist if the
output is very long.
—
Reply to this email directly or view it on GitHub
https://github.com/sstephenson/ruby-build/issues/701#issuecomment-69485570
.

If you cloned rbenv from master branch then you should have the latest version and the --debug flag should be effective. Since it's not, it seems like when you run rbenv it's not the master version, but the last 0.4.0 release.
Try RBENV_DEBUG=1 rbenv install 2.1.5 instead.

Here is the output:
https://gist.github.com/mark-rightscale/4834c5c3b3eff1dfc27a
I installed a couple plugins this morning - rbenv-bundle-exec and
rbenv-gem-rehash.
They weren't there before.
the rbenv version is rbenv 0.4.0-129-g7e0e85b, I am on the master branch
and just did a git pull.
Thanks again,
Mark
On Mon, Jan 12, 2015 at 9:51 AM, Mislav Marohnić<EMAIL_ADDRESS>wrote:

If you cloned rbenv from master branch then you should have the latest
version and the --debug flag should be effective. Since it's not, it
seems like when you run rbenv it's not the master version, but the last
0.4.0 release.
Try RBENV_DEBUG=1 rbenv install 2.1.5 instead.
—
Reply to this email directly or view it on GitHub
https://github.com/sstephenson/ruby-build/issues/701#issuecomment-69612529
.

You seem to have an outdated installation of both rbenv and rbenv-install in /usr/lib/rbenv/libexec. Please first investigate how that got there.
If you have installed rbenv from master in ~/.rbenv, then which -a rbenv should show /home/mark/.rbenv/bin/rbenv and not /usr/bin/rbenv.

yeah, which -a gives me /usr/bin/rbenv
I'll figure that out. Thanks!
On Mon, Jan 12, 2015 at 1:44 PM, Mislav Marohnić<EMAIL_ADDRESS>wrote:

You seem to have an outdated installation of both rbenv and rbenv-install
in /usr/lib/rbenv/libexec. Please first investigate how that got there.
If you have installed rbenv from master in ~/.rbenv, then which -a rbenv
should show /home/mark/.rbenv/bin/rbenv and not /usr/bin/rbenv.
—
Reply to this email directly or view it on GitHub
https://github.com/sstephenson/ruby-build/issues/701#issuecomment-69651967
.

Thank you! Back in bidness.
On Mon, Jan 12, 2015 at 1:49 PM, Mark Brown<EMAIL_ADDRESS>wrote:

yeah, which -a gives me /usr/bin/rbenv
I'll figure that out. Thanks!
On Mon, Jan 12, 2015 at 1:44 PM, Mislav Marohnić<EMAIL_ADDRESS>
wrote:

You seem to have an outdated installation of both rbenv and rbenv-install
in /usr/lib/rbenv/libexec. Please first investigate how that got there.
If you have installed rbenv from master in ~/.rbenv, then which -a rbenv
should show /home/mark/.rbenv/bin/rbenv and not /usr/bin/rbenv.
—
Reply to this email directly or view it on GitHub
https://github.com/sstephenson/ruby-build/issues/701#issuecomment-69651967
.

You didn't tell us how you ended up with /usr/bin/rbenv in the first place. Manual install or some package manager?

It must have been through ubuntu software center.
I had help setting it up a year ago when I began ruby development, so I
forget the details.
It must have been fine until I hit a version not on the list for the older
repo which ubuntu is using and then I messed it up by cloning the repo and
trying to get that to install the new version.
Thanks again for your help.
On Mon, Jan 12, 2015 at 2:52 PM, Mislav Marohnić<EMAIL_ADDRESS>wrote:

You didn't tell us how you ended up with /usr/bin/rbenv in the first
place. Manual install or some package manager?
—
Reply to this email directly or view it on GitHub
https://github.com/sstephenson/ruby-build/issues/701#issuecomment-69663191
.

Glad you solved it! :space_invader:


Feat/create non existent account groups

Pull Request: Update Category Handling in CashCtrlClient
Summary
This pull request introduces several updates and improvements to the CashCtrlClient class, particularly focusing on the handling of category updates. It includes new tests to validate these changes, ensuring robustness and correctness.
Changes
New Test Cases

test_update_account_categories_with_list

Ensures that updating account categories with a list type raises a ValueError.

test_update_file_categories_with_dict

Ensures that updating file categories with a dictionary type raises a ValueError.

test_account_category_update

Tests the full cycle of updating account categories and restoring the initial state.

Code Updates

Handling Parent ID for Account Categories
elif resource == 'account':
    params['parentId'] = categories.get(parent_path, 1)
if isinstance(target, dict) and target[category]:
    params['number'] = target[category]

Updating Account Category Numbers
if resource == 'account':
    dict_df = pd.DataFrame(list(target.items()), columns=['path', 'new_number'])
    merged = category_list.merge(dict_df, on='path', how='inner')
    merged.dropna(subset=['number', 'new_number'], inplace=True)
    update = merged[merged['number'] != merged['new_number']]
    for row in update.to_dict('records'):
        params = {
            'id': row['id'],
            'name': row['path'],
            'number': row['new_number'],
            'parentId': row['parentId']
        }
        self.post('account/category/update.json', params=params)

Target Type Validation
if resource == 'account' and not isinstance(target, dict):
    raise ValueError('Accounts target should be a dict of groups and associated account numbers')
elif resource != 'account' and isinstance(target, dict):
    raise ValueError('Target categories should be a list for this resource')

Update Categories Method Signature
def update_categories(self, resource: str, target: List[str] | dict, delete: bool = False):

Adding Number Column for Account Categories
if resource == 'account':
    accounts = pd.DataFrame(self.get("account/list.json")['data'])
    accounts = accounts.groupby('categoryId', as_index=False).agg({'number': 'min'})
    df.drop(columns=['number'], inplace=True)
    df = pd.merge(df, accounts, how='left', left_on='id', right_on='categoryId')

Enforcing Data Types
df = enforce_dtypes(df, CATEGORY_COLUMNS, optional={'number': 'Int64'})

Path Handling
path = f"{parent_path}/{node['text'].replace('/', '\\/')}"

Conclusion
@lasuk Please review the changes and provide feedback or approval for merging.
There are not so many changes, so you can point to any part of code that you see we can improve

Thanks for the modifications. I've added further modifications as fdabbe8.
@AlexTheWizardL: Please shout if you disagree.

Your changes look good to me

The code looks good to me and passes all tests.
However, the result does not correspond to what I would expect.
After running the unit tests up to L94, I see below category tree in the gui, where new nodes are attached under 'Assets'.
However, the 'Assets' node was not part of our specification:
account_categories = {
    '/Anlagevermögen/hello': 1000,
    '/Anlagevermögen/world/how/are/you/?': 1010,
    '/Anlagevermögen/feeling/kind/of/warm': 1020,
    '/Anlagevermögen/are': 1020,
    '/Anlagevermögen/you?': 1020,
    '/Anlagevermögen/Finanzanlagen': 6000,
}


Unresolvable dependency resolving [Parameter #0 [  string $method ]] in class RoachPHP\Http\Request

Illuminate\Contracts\Container\BindingResolutionException
Unresolvable dependency resolving [Parameter #0 [  string $method ]] in class RoachPHP\Http\Request
i face this error when i just install a fresh Laravel project and roach-php / Laravel
this is my code
namespace App\Http\Controllers;
use RoachPHP\Http\Response;
use RoachPHP\Spider\BasicSpider;
class RoachDocsSpider extends BasicSpider
{
/**
* @var string[]
*/
public array $startUrls = [
'https://roach-php.dev/docs/spiders'
];
public function parse(Response $response): \Generator
{
    $title = $response->filter('h1')->text();

    $subtitle = $response
        ->filter('main > div:nth-child(2) p:first-of-type')
        ->text();

    yield $this->item([
        'title' => $title,
        'subtitle' => $subtitle,
    ]);
}

}
i tried to install  also roach-php / core but the same error i follow the guide from doc, with initialRequests also, without succeed.
environment :
"laravel/framework": "^8.75",
"nyholm/psr7": "^1.5",
"roach-php/laravel": "^0.3.1"

Can you post the entire strack trace? It’s unclear when this error occurs

@ksassnowski here we go brother

Hello everyone  is there any fix for this case i'm still stuck
Thanks in advance any help is welcome

Can you maybe set up a small repository that reproduces this error? Because I still can't tell what is going wrong. There was a similar bug that occurred when you didn't publish the package config although that should have been fixed in 0.3.1

hello @ksassnowski , sorry for late : here is an example :

Ok, I see what's wrong. You're using your spider like a controller, which is not how you're supposed to do it. To start a spider, you call Roach::startSpider(SpiderClass::class). See https://roach-php.dev/docs/spiders#running-spiders


Fixed crash on API 19

Fixed crash on API 19 #4
Updated gradle version

@fython please release a new version of the library with this fix, thanks!

@AcoustickSan Sorry for publishing release so lately. Now I am waiting for JitPack.io to compile out the new package: https://jitpack.io/#moe.feng/BreadcrumbsView/0.2.1


Content fix on prepare-to-back-up-and-restore.md

A paragraph contains an incomprehensible context.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@MikePlumleyMSFT
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@TroyStarr can you confirm - can you use a backup created in one version to upgrade to a higher version?

@tseward do you happen to know the answer to this one?

@MikePlumleyMSFT in the context of using backup from Central Admin or Backup-SPFarm, that is correct, you cannot backup and restore to a new version of SharePoint, one needs to go through the upgrade process.

Thanks, @tseward.


Add reminders to event model

Add reminders to event model. Adds ability to set different reminder overrides or use the defaults.
Fixes issue #239

Codecov Report

Merging #240 (6479df5) into main (8063244) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   96.96%   97.01%   +0.05%
==========================================
  Files           9        9
  Lines         891      906      +15
==========================================
+ Hits          864      879      +15
  Misses         27       27

Impacted Files
Coverage Δ

gcal_sync/model.py
97.47% <100.00%> (+0.11%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Controller object has no attribute advertising times [extended advertisement branch]

When running the bumble controller.py of branch gbg/controller-extended-advertising I get the following error when connecting to my Zephyr virtual bluetooth device:
ERROR:bumble.transport.common:!!! Exception in on_packet: 'Controller' object has no attribute 'advertising_times'
Traceback (most recent call last):
  File "C:\Users\user\AppData\Local\Programs\Python\Python311\Lib\site-packages\bumble\transport\common.py", line 152, in feed_data
    self.sink.on_packet(bytes(self.packet))
  File "C:\Users\user\AppData\Local\Programs\Python\Python311\Lib\site-packages\bumble\controller.py", line 575, in on_packet
    self.on_hci_packet(HCI_Packet.from_bytes(packet))
  File "C:\Users\user\AppData\Local\Programs\Python\Python311\Lib\site-packages\bumble\controller.py", line 585, in on_hci_packet
    self.on_hci_command_packet(packet)
  File "C:\Users\user\AppData\Local\Programs\Python\Python311\Lib\site-packages\bumble\controller.py", line 596, in on_hci_command_packet
    result = handler(command)
             ^^^^^^^^^^^^^^^^
  File "C:\Users\user\AppData\Local\Programs\Python\Python311\Lib\site-packages\bumble\controller.py", line 1364, in on_hci_le_set_advertising_enable_command
    self.schedule_advertiser(self.legacy_advertiser, time.time())
  File "C:\Users\user\AppData\Local\Programs\Python\Python311\Lib\site-packages\bumble\controller.py", line 1026, in schedule_advertiser
    heapq.heappush(self.advertising_times, (when, advertiser))
                   ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Controller' object has no attribute 'advertising_times'

I think it has to do that the variable is not initialized here
https://github.com/google/bumble/blob/07270240e34715d1b56a0cad995d664544bc3aad/bumble/controller.py#L515

Thanks for reporting this issue. I'll fix it ASAP.


[Thread 1.3.x] related OT PRs and Thread JIRAs.

Created this issue to track OT PRs and related Thread Technical Committee JIRAs.

[x] SPEC-1136 Context ID Reuse Delay

https://github.com/openthread/openthread/pull/8876
https://github.com/openthread/openthread/pull/8870
https://github.com/openthread/openthread/pull/8896

[x] SPEC-983 leader weight based on device config

https://github.com/openthread/openthread/pull/8670

[x] SPEC-1046 Child supervision

https://github.com/openthread/openthread/pull/7993

[x] ~SPEC-1061 Delay TLV for query (pending)~
[x] SPEC-1002 Mode change FTD/MTD

https://github.com/openthread/openthread/pull/8484
https://github.com/openthread/openthread/pull/8498

[x] SPEC-1131 Child to router upgrade

https://github.com/openthread/openthread/pull/8307
https://github.com/openthread/openthread/pull/9154

[x] SPEC-1120 and SPEC-1130

https://github.com/openthread/openthread/pull/9042
https://github.com/openthread/openthread/pull/8986
https://github.com/openthread/openthread/pull/8381
https://github.com/openthread/openthread/pull/8395
https://github.com/openthread/openthread/pull/8827
https://github.com/openthread/openthread/pull/8901

[x] SPEC-1128

https://github.com/openthread/openthread/pull/8398

[x] SPEC-1136

https://github.com/openthread/openthread/pull/7869

[x] SPEC-1126 (RIO preference based on BR role in mesh)

https://github.com/openthread/openthread/pull/8574

[x] SPEC-1145 - REED/FED to track cost towards all routers using parent's cost

https://github.com/openthread/openthread/pull/8956

[x] SPEC-1190
https://github.com/openthread/openthread/pull/9080
[ ] SPEC-1140 - leader override
https://github.com/openthread/openthread/pull/9073
https://github.com/openthread/openthread/pull/9106
https://github.com/openthread/openthread/pull/9186
[x] SPEC-1195 - delay security policy TLV

https://github.com/openthread/openthread/pull/9187

[x] SPEC-1180 - AP flag

https://github.com/openthread/openthread/pull/9274

[x] SPEC-1181 - DNS resolver PTR include additional data only if one match. (optional enhc)

https://github.com/openthread/openthread/pull/9281

[x] SPEC-1167

https://github.com/openthread/openthread/pull/9307

IETF SRP Replication

https://github.com/openthread/openthread/pull/8403

Note: Access to the Thread JIRA links requires Thread membership and Thread group login/account.
This is follow-up to https://github.com/openthread/openthread/issues/7460 for new changes after 1.3.0 (for 1.3.x)

@abtink Does this represent the latest remaining work for 1.3.1 on GitHub? Or are there any items missing?

Does this represent the latest remaining work for 1.3.1 on GitHub? Or are there any items missing?

That's the intention behind this.

Thank you @abtink ! I was going to ask you about the network diagnostics work item so thank you for pointing me to that. Also I know the TCAT/BBTC PR is currently open and yet to be merged so will that count as another 1.3.x item to be added to this list?

This tracks everything for 1.3.x (not just 1.3.1). I created and use this issue to track stuff that I did or plan to work on myself (to have a place with all the links to SPEC JIRAs and PRs).
Feel free to create a new issues to track other items if you want (or you can add them here)
BTW, SRP replication is not part of 1.3.1 and DNS Push is not supported in OT(can be supported by platform if desired).

@abtink Seeing that all issues we wanted to do, that were listed here, are addressed, we can probably close this issue? See #9930 for the open issue on remaining items for 1.4.

SGTM.


Changes following review

Main changes include dropping a lot of the generics to simplify everything, removing some default implementations to force people to implement them (i.e. on Capabilities), and some changes to improve the developer experience.

This closes #1


Closes Codeception/CodeceptJS#9 , add the test folder to the codecept.json object

Add the test folder pass in argument to the init command to the resulted created json file.

Thanks


Add delete button to files in a PR

Very often people include files I don't want in PRs. Like package-lock.json or editor-specific config. I would like a quick way to remove such files.

(From https://github.com/sindresorhus/broccoli-svgo/pull/1/files#diff-32607347f8126e6534ebc7ebaec4853d)
Unless the PR submitter has unchecked the "Allow maintainers to edit" checkbox, we are allowed to delete it if we go directly to the file, like here: https://github.com/jaswilli/broccoli-svgo/delete/update/package-lock.json
So the implementation could be to find the branch and then go to:
https://github.com/<username>/<repo>/delete/<branch>/<filename>

Hi there! I’m a first-time contributor and was hoping to help out with this issue. I noticed nobody was assigned to it, but if there’s already a solution in progress I’m happy to try helping out elsewhere. Thanks!

@JackLaird0 No one is working on this. Go ahead 😀


Improve regexp parsing logic

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #39445
Fixes #39438
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Seems stringTemplateStartsWithDollar is failing. :( Changes LGTM though.
stringTemplateStartsWithDollar FAILED
    java.lang.AssertionError: expected [$$$$ A 8 B] but found [$$$$A 8 B]


http_monitor resource drifting based on rule-based tags

Describe the bug
I have about 20 http_monitors defined in terraform and everytime there is a plan it triggers a change to remove a rule_based tag.
This tag is set by a tagging rule and not on the http_monitor itself so there's nothing that can be done about this from the http monitor end and I would like to keep the autotag rule in place.
To Reproduce
Steps to reproduce the behavior:

Create an HTTP monitor via Terraform
Create an autotagging rule that applies to the http monitor
Run an empty plan and you should see that the plan is trying to remove the autotag

Expected behavior
I would like the provider to ignore rule_based tags on http_monitors
Screenshots

Hello @ggreen05, thanks for reporting this issue. It will be fixed with the next release.

Awesome thanks for all the hard work!


Css/tagsinput switch

resolves #1895
resolves #1896
resolves #1897
resolves #1898
resolves #1899

I'll take a look at this. Why are there old, unrelated commits in this new branch?


Expired machine image version of worker is not forcefully updated

How to categorize this issue?

/area quality
/kind bug
/priority normal
What happened:
Currently expired machine image version of worker is not forcefully updated when Shoot has other workers with non-expired machine image versions.
What you expected to happen:
Expired machine image version of worker to be forcefully updated.
How to reproduce it (as minimally and precisely as possible):

Ensure that you have a Shoot with 1 worker that has expired machine image version (requires forceful update) and 1 worker which machine image version is for example supported.

apiVersion: core.gardener.cloud/v1beta1
kind: Shoot
metadata:
  name: crazy-botany
  namespace: garden-dev
spec:
  cloudProfileName: aws
  provider:
    type: aws
# ...
    workers:
    - name: worker1
      machine:
        image:
          name: suse-jeos
          version: 15.1.20200220
# ...
    - name: worker2
      machine:
        image:
          name: coreos
          version: 2512.3.0
# ...

The corresponding CloudProfile looks like:
apiVersion: core.gardener.cloud/v1beta1
kind: CloudProfile
metadata:
  name: aws
spec:
# ...
  machineImages:
  - name: coreos
    versions:
    - classification: supported
      version: 2512.3.0
  - name: suse-jeos
    versions:
    - classification: deprecated
      expirationDate: "2020-07-15T23:59:59Z"
      version: 15.1.20200220
    - classification: deprecated
      version: 15.1.20200406
# ...

Maintain the Shoot and ensure that worker1 won't be forcefully updated to non-expired version.

$ k -n garden-dev annotate shoot crazy-botany gardener.cloud/operation=maintain
$ k -n garden-dev describe shoot crazy-botany

Events:
  Type    Reason             Age                From                         Message
  ----    ------             ----               ----                         -------

  Normal  MaintenanceDone    15m                gardener-controller-manager  No action required.
  Normal  Reconciled         13m                gardenlet                    Reconciled Shoot cluster state

Anything else we need to know?:
Environment:

Gardener version: v1.7.2
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

/assign @vpnachev @danielfoehrKn


Don't use BaseException.message @equalsraf #152

This patch helps show the underlying error in #152
BaseException.message was only available in Python 2.5:
https://www.python.org/dev/peps/pep-0352/#retracted-ideas
This was patch was proposed in neovim/neovim #4253 by @equalsraf :
https://github.com/neovim/neovim/issues/4253#issuecomment-184437483
Without the change calling BaseException.message hides any errors behind an AttributeError:
AttributeError: 'OSError' object has no attribute 'message'

This works in both python 2 and 3 right?

That's absolutely right, I have tested on 64 bit Windows 7 with Python 3.4.3 on 2.7.11.
Both BaseException.message and BaseException.args are available on Python 2.7 but only BaseException.args is available on Python 3. Some background is available on python-dev.

Ok, makes sense, thanks.


docs: Add documentation on how to run tests

Hi,
I'm not quite sure on if this is the preferred way for you to run/install tox, and/or if you even want the CONTRIBUTING.md file to be included.
Maybe tox should be included as a dev dependency somehow.
Personally I've switched 100% to poetry. I have not tested it with tox yet. I use GitHub actions matrix builds for testing different OSes and python versions. See https://github.com/hawkaa/pygeojson .
Let me know what you think!

Ah, tox should perhaps be installed globally? It says that it also can be installed in a virtualenv: https://tox.readthedocs.io/en/latest/install.html
Let me have another go.

@drewbo how does it look like now?
It is probably more than good enough the way it is. If you want to do some more tinkering on this, I recommend pipenv or poetry which is slightly better at encapsulating environments and python versions.


Correct the words for new PMC

The old one is not complete.

Codecov Report

Merging #4468 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4468   +/-   ##
=======================================
  Coverage   24.97%   24.97%
=======================================
  Files        1231     1231
  Lines       28496    28496
  Branches     3905     3905
=======================================
  Hits         7118     7118
  Misses      20719    20719
  Partials      659      659

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0385ff...4fe07ec. Read the comment docs.


#140 adding the basics for user selectable offline map sources

#140 adding the basics for user selectable offline map sources instead of everything that's available offline and online

can we get this merged at some point?

ping


Fix formatting errors in Developer Guide

GFMD for User Stories and NFRs
Table was not rendering properly, reformatted table.
Standardise (use case end) position in use case.

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (6222cb4) compared to base (25ec6b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Implement AsRawHandle for serial Connection

Standard library provides the std::os::windows::io::AsRawHandle trait to obtain a windows handle from a IO device. Then such handle can be used to perform low level actions.
It would be great if Connection also implements such trait. I kindly request you to apply this patch to your codebase and release a new version of the crate.
Many thanks for this crate and your time!

Thanks for your contribution!


Fixed lookup registration for ForeignObject

Two issues:

Fields derived from ForeignObject are currently unable to register custom lookups and transforms.
By not using class_lookups, it's not really possible to introspect the lookups available for an FK.

_get_lookup() is copied from RegisterLookupMixin, with the addition of breaking out of the mro loop once ForeignObject is reached.

buildbot, add to whitelist.

Thanks for the patch. All non-trivial pull requests also require a Trac ticket.

will do - should I just edit the PR once the Trac ticket is open?

Yep

done

Any ideas about this, @akaariai or @jarshwah?

Looks mostly good to me. I'm not very familiar with ForeignObject though so I might have missed something obvious. Was there a particular lookup you were trying to create that led you to fixing this? The test case you've got (Exactly) shows the feature working, but not really why the changed needed to be made.

Hi all - I've recapped the PR in the description. Is there anything I can do to help move the PR forward?

The blank lines have been removed.
My thoughts on updating the docs would be if get_lookups() was to be considered as public API or not.

I can't think of any docs that are needed.

You can squash commits when updating also. Thanks!

Copying here since the diff is outdated:

Could it be useful to use @functools.lru_cache() or @cached_property rather than implementing your own caching?

The caching here is based on the same idea as class_lookups, just a bit more complicated because of the cache busting. I didn't try @cached_property (no way to bust the cached value, and it doesn't work w/ classmethods, right?), but lru_cache worked just fine. That said, it is about 50% slower.

current implementation at 100k runs takes ~.28s on average.
lru_cache at 100k runs takes ~.42s on average.

50% is a significant percentage, but we're talking about lookup resolution taking .0000042 seconds vs .0000028 seconds. ¯\_(ツ)_/¯
Either way, I've squashed the existing commits into one, and added the lru changes separately. Thoughts on the performance vs code clarity?

I don't have a sense as to whether or not those performance differences would have any real-world impact.
If we keep the changes, I think you can drop maxsize=None since the methods don't have any arguments, the size shouldn't be larger than 1, right?

I don't have a sense as to whether or not those performance differences would have any real-world impact.

Yeah. With my laptop, it take 700,000 lookups to use one additional second of CPU time. I feel like this is probably fine. Went ahead and squashed the commits.

If we keep the changes, I think you can drop maxsize=None since the methods don't have any arguments, the size shouldn't be larger than 1, right?

No - it should be caching per field class. eg, the datetime lookups vs the standard lookups.


WIP: support the new unixfs-engine balanced builder

Changes in tests reflecting the new results from the new default balanced builder in unixfs-engine.
Depends on merging https://github.com/ipfs/js-ipfs-unixfs-engine/pull/118

I've run these changes with js-ipfs-api against go-ipfs and since the expected hashes changed, the tests fail, they both should yield the same hashes for the same files
I checked to see if it could have been the change from raw to file (that could had happen in the other direction), but it seems that unixfs-engine is good with regards to that.

Nevermind, I hadn't realised that the test files were relatively small.
By the way, the difference with go-ipfs is that, for a file that is only one chunk, go-ipfs does not put a single link parent in front of it (going against what it does when recursing).
Tests against https://github.com/ipfs/js-ipfs-unixfs-engine/pull/118 should be passing now.


Custom 404 Error Page

A custom 404 error page both the HTML and the Flask route needs to be created

Has been completed and merged


How do I configure dmg to support drag and drop to Application

As the title suggests.

In your gon-sign.json add app_drop_link which specifies the coordinates for the Application icon
  "dmg": {
    "output_path": "./build/bin/xxx.dmg",
    "volume_name": "xxx",
    "app_drop_link": [200, 20]
  }


chore(deps): reject auto upgrade of prettier

<EMAIL_ADDRESS>is now enforcing Allman brace styles, while the code
base uses 1tbs (one true brace style).
In fact, the latter has been explicitly configured in eslint.
There does not seem to be a way to configure prettier to switch styles.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Isn't it possible to configure prettier accordingly?

It looks related to this change which only applies to classes with multiline extends/inherits https://prettier.io/blog/2021/05/09/2.3.0.html
We likely could make eslint ignore this and just let prettier handle it (thats what eslint-config-prettier is for but maybe it hasn't caught up?).
At the top of that same release notes page it recommends not using a ^ version of prettier though so this seems good anyway.

Isn't it possible to configure prettier accordingly?

@eladb - I could not find such an option. I believe this is because of prettier's philosophy

We likely could make eslint ignore this and just let prettier handle it

@MrArnoldPalmer - Here's how that would look - https://github.com/aws/jsii/pull/2835/. Is that a better change?

@nija-at yeah lets take that. I think just letting Prettier handle everything it does and using Eslint only for non-formatting related stuff is our preferred experience. TY for that!


Fix scroll width calculation when longest line is folded

With the presenter we started clipping screen positions prior to translating them to pixel positions. This interacts with the current clipping behavior on folded lines (which should change) where the cursor is always clipped to 0. So when the longest line was also folded we were miscalculating the width. :see_no_evil:!
The removal of clipping also causes us to calculate the width based on the trailing whitespace of soft-wrapped lines, which I actually think is an improvement but it is slightly different.
Fixes #6562

This has an issue where we scroll horizontally a tiny bit when the text is soft wrapped because we're not clipping back to the end of the actual content. May need to explore a better path.

Forced push a change that preserves the original clipping behavior on soft-wrapped lines. Seems to cover both cases well. I tried disabling clipping of folded lines but there are too many implications to take that on at this moment. After the document model work is finished we can revisit it.

Didn't get time to try this branch before 0.195 was released. Trying it now, with no problems so far.


add Tree.findDepthFirst and Tree.findBreadthFirst and Tree.filter

Add some utility functions to Tree module.

Hi @gcanti !
I put lots of effort into the PR I submitted and I would really appreciate it if you can take a look and give me some suggestions on the code if you have any. Thanks!

This would be really helpful for me too.
One thing to consider would be whether the find and filter should be operating on the tree node, or the value of the node.
I think your approach (the tree node) is the better one as it is more flexible (and similar to operations I've built). Maybe it's worth implementing both (findNodeDepthFirst, findDepthFirst, or similar naming convention)?
When it comes to filter (which is really useful to me), it would probably be worth having both a depth first and breadth first option if we're operating on the node, as when filtering an element your predicate may care about how many filtered children remain, for example.
What do you think? I'm happy to help get this across the line.

Maybe it's worth implementing both (findNodeDepthFirst, findDepthFirst, or similar naming convention)?

Yes, It's valuable.

When it comes to filter (which is really useful to me), it would probably be worth having both a depth first and breadth first option.

I am confused.
Are you mean:
When filter on a tree, there should be two ways to traverse the tree:

Apply the predicate to the forest of the node, and then the node's own value.
Apply the predicate to the node's own value, if the result is true, then filter the forest of the node recursively. (current implementation)


AVRO-2545: Add Ruby support for aliases

Jira

[x] My PR addresses the following Avro Jira issues and references them in the PR title:

https://issues.apache.org/jira/browse/AVRO-2545

Tests

[X] My PR adds the following unit tests:

test_aliased
test_to_avro_includes_aliases
test_validate_field_aliases
test_validate_same_alias_multiple_fields
test_validate_repeated_aliases
test_validate_record_aliases
test_validate_enum_aliases
test_validate_fixed_aliases
test_aliased_field
test_crossed_aliases
test_compatible_reader_writer_pairs (additional test cases)
test_incompatible_reader_writer_pairs (additional test cases)

Commits

[x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it.

N/A

@nandorKollar you reviewed https://github.com/apache/avro/pull/628. Could you also look at this pull request? Thanks

Thanks @RyanSkraba!


Changed order of color picker colors

Changed order of color picker colors to blue, cyan, green, yellow, red, magenta, and white.

https://github.com/glencoesoftware/v2-project/issues/878


Different status text for email

Can't seem to get this done with the most recent version.
We need to set a different text value when a user is sharing with email. This string contains html and other stuff, but for shares via Facebook/Twitter etc, we need another text.
Is this possible? Maybe an eventlistener when clicking an share icon so we can set a custom value for it?

I've tried the new "emailIsHTML" feature but doesn't seems to work.
If it is set to True, the email dialog shows HTML text properly but SMS, Twitter, Facebook text are empty.
If the property is False, email again shows properly but the others shows HTML tags =/
Let me know if you found something, tks

I've created something today @skoften, take a look
https://github.com/viezel/TiSocial.Framework/issues/143


Implement Delegation

Add example: assign task to multiple mailbox owners, update task, check who has completed it.

Task delegation is not as easy as I thought initially. Seems that we should take a look at Delegate access and EWS in Exchange in general. Next release.

In Exchange, you can enable users to access other users’ mailboxes in one of three ways:

By adding delegates and specifying permissions for each delegate.
By modifying folder permissions directly.
By using impersonation.

This ticket is about Delegation.
TODO items:

Read https://msdn.microsoft.com/en-us/library/office/dn641957(v=exchg.150).aspx.
Read Delegate Access p41.
Read Task Delegation and Exhange Web Services p458.
Implement.
Add example for task delegation with two distinct mailboxes.
Implement EWS JS API + example for EWS JS API.

WIP in this branch here: https://github.com/bkircher/ews-cpp/tree/delegation.

AddDelegate, GetDelegate, RemoveDelegate operations should be working with 946545a5f84302939b8a2364dce8fd1ff90516e0. Integrated into master.

Should be done in master with 51a585d2e288d449019f45e0414abd9a6465c384.
Following examples related to EWS Delegation have been added:

add_delegate.cpp - Shows how to add a delegate for a user
get_delegates.cpp - Shows how to retrieve all delegates for a user and their folder permissions
remove_delegate.cpp - Show how to remove them again
create_calendar_item_with_delegate_access.cpp - Create an appointment in someone else's calendar
create_task_with_delegate_access.cpp - Create, update, and delete a task in someone else's Tasks folder


Origin "keep_inventory" item not kept on death

I did a look around first and saw that there was one other thread about this a long time ago, but it seems the issue requester didn't get back about it working or not before the thread was closed with some kind of fix.
MC Version: 1.20.1
YIGD Version: 2.0.10
I'm using an origin in a datapack that has one item meant to be kept on death. It has NBT data. It works without YIGD, tested using the /kill feature. With this gravestone mod however, the item is tossed into a grave and I have to go grab it. I don't understand what the issue could be since there's origin compatibility, but messing with origin items being kept instead of being put into the grave didn't do anything. If needed I can provide the txt file for the power so it can be checked out.

There should be compat in place for entire inventories that should or shouldn't be kept on death, but I didn't know there was rulings about specific items to be kept on death for some powers. I'd be happy to take a look at this origin power and see what I can do to fix this too.

There should be compat in place for entire inventories that should or shouldn't be kept on death, but I didn't know there was rulings about specific items to be kept on death for some powers. I'd be happy to take a look at this origin power and see what I can do to fix this too.

Here's the txt file :>
crafters_thorn.json

Thank you! I've managed to get it working in my development environment, and it will be included in the next update (should be just a few days away, since I still have other things to fix and implement before I release it)

Thank you! I've managed to get it working in my development environment, and it will be included in the next update (should be just a few days away, since I still have other things to fix and implement before I release it)

Thank you so much for the fix! :D I wish you luck with other issues!


[Feature request] 1.18.2 changes

Hello there, i know that 1.18.2 is not released yet, but is it possible to update this repo for that version? Or at least is there an ETA?
Honestly this is probably the only legit/good source for adding new structures to the game, if person does not have any experience with that, at least for me personally this repo is a gamechanger.

Thank you, this was very helpful, i got it working with jsons all right for now while keeping my generate conditions in the code. I have one last question, is it somehow possible to override just spacing and separation values for the structure_set or do i need to make legit class for that and dont use json for this part?

You need the entire json file for structure_set. It doesn’t allow for overriding only parts of the json. You can name that json file whatever you want tho as the game is mainly concerned with what structures is put inside it in order to know how to apply the json’s settings to those structures

Tutorial is now updated to 1.18.2


Basic SmartObjects helpers

Small pull request to include helpers to build objects to be send to the ingestion API.

When this is merged, I'll release 1.0.27


Correct the message of pause and unpause a non-running container

Signed-off-by: Lei Jitang<EMAIL_ADDRESS>We should check if the container is running or not then check
if the container is paused or not, because a not running container
is definitely  not paused. Or else if we unpause a not running container,
the error message will show Container is not paused this is misleading.
BTW I remove the so what  in the error message of container is not paused,
I don't know if we have a so what here is good or not since english is not my first
language. :)(

update the PR to also check if container is running or not first on pause container. Because
a not running container is not paused.

@coolljt0725 why do you think trying to docker unpause'ing a not running (and not paused) container is not an error? just wondering..

@runcom  Mostly, I think no one will docker unpause a not running (and not puased) container, it's an error to do this. But if we have a lot of running containers and the containers name are alike, we can't assume people will not type the wrong name...and some situation like this...:)

This makes sense.. I think the error messages for !running should be updated to make it clear that they came from pause and unpause actions:
Cannot pause a non-running container
Cannot unpause a non-running container
Removing the "so what" was correct :) Not sure what that was about.. :)

ping @estesp  any new for this ?:)

Hey @coolljt0725, what did you think of my recommendation on slight word changes for the error messages (https://github.com/docker/docker/pull/13547#issuecomment-106320454)
Other than that, I think this is good

@estesp  That's make the message more clear, I'll update this PR. thanks :)

ping @estesp updated

Thanks @coolljt0725
LGTM

LGTM


Support dataset version in handler

Codecov Report
Base: 14.63% // Head: 14.63% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (9f951ce) compared to base (129f3bb).
Patch coverage: 1.33% of modified lines in pull request are covered.

:exclamation: Current head 9f951ce differs from pull request most recent head 98323f4.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

First round, I will go through the rest later.


Who Disclaimer

Briefly describe the feature or bug that this PR addresses.
Adds WHO logo and disclaimer to explore tab on desktop and mobile
Please link the Airtable ticket associated with this PR.

No ticket ATM

Mobile View:

Desktop View:

Thanks, Brett! A couple of quick questions here:

Have we added the WHO Logo to our about page at all? Would be great to see what that looks like as well.
I noticed that the sidebar text on mobile and desktop doesn't appear to be consistent, with the desktop being the most recent. Is three any way to ensure that these are consistent?

Of course, we should hold of on merging here until we have final approval from WHO. I've just emailed them to ask they re-review.


Couldn't parse bundle asset "vendors~typeahead.chunk.min.js". Analyzer will use module sizes from stats file.

Plugin version 1.2.4
webpack 4
This only happens in production when setting  sourceMap: false, when set to true, it runs fine!
 new UglifyJsPlugin({
            sourceMap: false, // <-- using false here, generates the error above
            uglifyOptions: {
                ecma: 5,
                warnings: true
            }
        })

Here the complete Log-file:
2018-03-16T16_31_25_817Z-debug.log

@Legends can you provide more detailed log, because log above contain only npm stacktrace

npm run prod
here it is: --> uglify-sourcemap-false-production.log

@Legends problem in source-map package. It is hard debug without source :disappointed: Need reproducible test repo

Moved the issue to source-maps repo.

Here is the repo which replicates the error.
I have opened a new issue here

@Legends I will investigate this in near future :+1:

I think the issue arises because I have set
module.exports = {
    devtool: 'source-map',

but in the UglifyJS-Plugin I set it to false:
new UglifyJsPlugin({
            sourceMap: false,

Perhaps an error message would be nice, that explains the issue or the plugin overrides devtool setting by default.
The problem is created in UglifyJS-webpack-plugin:
var _asset$sourceAndMap = asset.sourceAndMap(),
                  source = _asset$sourceAndMap.source,
                  map = _asset$sourceAndMap.map;  // <--- returns null

              input = source;
              inputSourceMap = map; // inputSourceMap  is now null

              sourceMap = new _sourceMap.SourceMapConsumer(inputSourceMap); // fails

@pbrain19 has the same error msg, but he uses a different configuration here

@evilebottnawi What needs to be done here? Can I help somehow?

@Legends no, WIP :+1:

@Legends bug, work on PR. Thanks!

Fixed in https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/268


PLSI can't run with make 3.81

EDIT: When I ran make syn-verilog with my own core-generator definition based on rules.mk, vars.mk in counter with empty simulation testbench and macro verilog files, it ran nothing.
Make version: 3.81.

I omit macro json in my source directory. Probably need to error it.

Often the issue can be debugged by using something along the lines of "make syn-verilog -d &> log.txt" and then examining log.txt to see what files are missing.


Needs to create the whisper and captions labels when you clone the repo

Right now new template repo copies do not have those labels, which means the system does not work correctly.

I'll try doing this with a ensure_labels.yml action.

I tested this by creating a new repo from the template and confirmed that it works.

Wrote this up as a TIL: https://til.simonwillison.net/github-actions/ensure-labels


Hotfix/licensepicker text

Add template for License Picker
Add link to side bar on Getting Started page.

You can add a license to your project to allow others to copy, distribute, and make use of the data while allowing you to retain copyright. From the Project Overview page, click on the "License" line below the project's description. There you can chose from a selection of license types or upload your own.

Suggested edit:

On a project's Overview page, you can add a license by clicking the "No license" text below the project's description.

I like it


refactor(minifier): binary operations use ConstantEvaluation

#6700  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


Tournament Simulation for in-progress tournaments

A lot of work has been done. Missing:

Probable matches with player pin
Relative participation strength of the draw section (in blocks of 8 players)
Automation of draw fetching

Completed


got warning when building with xcode 8.3.1

'M_PI' is deprecated: Please use 'Double.pi' or '.pi' to get the value of correct type and avoid casting.

Fixed in the next build.


Update the document with best practice for vscode

By default, vscode cannot add type recognition to a guest when creating a risczero application. This documentation supplements this and allows guest to be recognized as well.

@pdg744 @sashaaldrick


FIX: Use correct trait for display

The current implementation incorrectly delegates Display on Guard to the Debug implementation. It should instead delegate to the underlying Display implementation.

Thank you for spotting this!
However, the problem is, this is technically a API-breaking change ‒ code that compiled previously could stop compiling. On the other hand, if people actually used this, they would have noticed, likely, like you did, so I'm inclined to just release it with the patch version update only. What do you think is the better way forward? Or, do you know of an easy way to run an update on all reverse dependencies and see if they compile and pass tests?

I think that depends on how you see this. Yes, this would be a breaking change, but it is due to a bug in the API. I took a look at the list of crates that depend on arc-swap versions 0.4, and none of those listed attempt to use Display on an ArcSwap, so none seem to exercise this particular bug. I can certainly see incrementing the minor version to 0.5, but I figured this is a bug fix, which is why my change initially marks for 0.4.3. I'm happy to change it to 0.5 if you prefer.

Thank you for the research, I think this confirms my suspicion this is fine to go ahead with the patch version :-).


req.headers['x-forwarded-host'] is undefined on netlify deployment

This issue is exactly the same issue statued here #40 but with x-forwarded-host header.

thanks for pointing this out! there's an internal netlify PR open as of 7 hours ago to address the original issues you referenced (regarding req.headers.host) and my hope is the internal PR can cover x-forwarded-host as well. will keep you updated!

update: it seems like x-forwarded-host is the same as host so i'm not sure this needs to be added
https://vercel.com/docs/edge-network/headers#x-forwarded-host

@lindsaylevine the documentation you posted is about Vercel. x-forwarded-host is used mainly in proxies which is the case I am in now.

@abdelhamid-attaby gotcha, i hear you! i linked the vercel docs primarily as an example. it's the same on netlify. for good measure i synced back with the team and internally we don't want to make the x-forwarded-host change because you should be able to use host. if you can demonstrate a specific need for x-forwarded-host that host does not resolve, i'd be happy to explore further for you! :)

@lindsaylevine thanks for taking this seriously. Mainly our setup now as following: caddyserver (as a proxy and ssl certificates manager) -> Netlify . So, in order for Netlify to understand the website, caddy should put the host header to be the upstream address (which is the Netlify address in this case). However, in the application itself, we need to know the original host the user asked for (which should be in x-forwarded-host).

@abdelhamid-attaby of course! and i hear you. are you comfortable opening a PR? swamped with other priorities at the moment, but if this is a blocker/priority for you, that's probably the best way to get it addressed asap :)

Might be able to just fix it doing something like the following. It seems like you removed the code from issue #40 tho
  if(!event.multiValueHeaders.hasOwnProperty('x-forwarded-host')) {
    event.multiValueHeaders['x-forwarded-host'] = [event.headers['host']]
  }

@brenelz yeah we took it out because it was only in next-on-netlify as a temporary patch. host is now provided on multiValueHeaders by netlify internally. however, whenever i've synced with the internal team who made that change, they insist host should suffice for x-forwarded-host and don't want to make that specific change internally.
are you experiencing this issue too @brenelz?

no not experiencing the issue... was just trying to help out. Happend to just try out the next-on-netlify package though and its pretty slick. Keep up the good work!

yk what there's really no harm in adding it. will open a PR now since i have a minute! cc @abdelhamid-attaby
thanks for the kind words @brenelz <3 it's all @FinnWoelm

Thanks, @lindsaylevine, really appreciated your help. I am sorry I was so busy opening this PR.