Test: encoding auto detection

Refs: https://github.com/Microsoft/vscode/issues/5388

[x] Windows - @gregvanl
[x] Linux - @roblourens
[x] Mac - @joaomoreno

We are now using the jschardet library to try to guess the encoding from the contents of a file. As a preparation for testing, try to get some text files in the supported encodings. There is a shift-jis file checked in that is known to work but other encodings would also be interesting.

From @joaomoreno

I've created this repository with several encoding samples:
https://github.com/joaomoreno/encodings

There are two scenarios to test:
From the new files.autoGuessEncoding setting:

verify that the files.encoding setting is still being used as long as files.autoGuessEncoding is not enabled
verify that encoding is detected from the file if possible once files.autoGuessEncoding is enabled and you try with files that use a specific encoding not set as configured workspace encoding (e.g. shift-jis)
verify that the configured encoding is used (or utf8 by default) if the detection is not returning any more specialized encoding (in particular, opening an ASCII file should show you utf8)

From the encoding selector picker:

we now guess the encoding from the currently active file as soon as you open the encoding picker (either when chosing "Reopen with encoding" or "Save with encoding")
verify that when the encoding is detected and it differs from the configured encoding, you see it showing up first
verify that you do not see the hint about the guessed encoding when the configured encoding matches the detected one (e.g. you set files.encoding to shift-jis)
verify you do not end up with duplicate encodings (guessed, and from the list)

I've created this repository with several encoding samples:
https://github.com/joaomoreno/encodings

@bpasero Please put a complexity on your test plan items in the future, this is quite big. cc @isidorn

Will these changes also address https://github.com/Microsoft/vscode/issues/21146? Or is there still more to be done to get this into the diff editor?

There is still a persistent issue where VSCode will ignore the current file encoding in favor of the files.encoding setting or the guess when opening an existing file, even when the files.encoding setting isn't the right file encoding.
Example: I create a new shift-jis encoded file with corresponding characters.  Save it with Shift-JS encoding. Close it. Open it. VSCode opens the file as UTF-8.  It happens with other encodings as well, such as Latin-1 (ISO-8895-1). When I reopen an encoded file, it will sometimes pick the wrong encoding instead of using the existing encoding.
Here is a gif of the bug in action:

You can see how the files are encoded as Shift-JIS and ISO-8895-1, but when I reopen the files, they are opened as Windows 1252 and UTF-8 encoding respectively, and this breaks some characters. If I then save the file, the encoding is saved wrong and the characters will remain broken.

@duanehutchins separate bug with all the details please

Hopefully it isn't a problem that this doesn't apply to search. files.encoding is but it doesn't autodetect anything besides utf-16.

Some  jcharset сharset names  do not correspond with vscode charset aliases
For example:
jcharset: IBM866
vscode: CP 866

Autodetection does not work on search
Fix will likely on searchworker.ts:

private readlinesAsync(filename: string, perLineCallback: (line: string, lineNumber: number) => void, options: ReadLinesOptions): TPromise<void> {
...
...
							// Check for BOM offset
							switch (mimeAndEncoding.encoding) {
								case UTF8:
									pos = i = bomLength(UTF8);
									options.encoding = UTF8;
									break;
								case UTF16be:
									pos = i = bomLength(UTF16be);
									options.encoding = UTF16be;
									break;
								case UTF16le:
									pos = i = bomLength(UTF16le);
									options.encoding = UTF16le;
									break;
// here the fix
								default:
									if (mimeAndEncoding.encoding) {
										pos = i = 1;
										options.encoding = mimeAndEncoding.encoding;
									}
									break;
							}

@buzzzzer I fixed that case with CP866, if there are more cases, let me know.
Encoding detection is only for files, not for search right now.

@bpasero

Encoding detection is only for files, not for search right now.

It's a pity.
Fix is simple, and it will take another year to wait (

Sometimes simple things need years to get right.

@buzzzzer Search is provided by ripgrep in 1.11, not searchWorker.ts, and ripgrep only does encoding autodetection for utf-8/16. You can still set files.encoding to search in those files.

@roblourens so to be clear, ripgrep allows to set the encoding, but only for all files it goes through, not per particular file/folder?

Yes, pre-ripgrep search worked the same way

@joaomoreno

You can still set files.encoding to search in those files.

And what should set to files.encoding ?
If in one workspace i have 4 different encoding (cp866, windows1251, utf8 & utf16)

@roblourens, @bpasero

Yes, pre-ripgrep search worked the same way
pre-ripgrep  search (searchworker) with autodetect I have been using for about 4 months, and that WFM

Any planned to support autoguessencoding with ripgrep search?
pre-ripgrep will be retained or deleted in future versions?

Encoding autodetect has only existed for less than a month, and doesn't apply to non-ripgrep search, so I'm not sure how that was any different for you.
I think it's unlikely that ripgrep would get fancier encoding detection since that will slow it down, and their focus is entirely on speed.
I'll keep it in the short term. If there is a usecase that just can't be handled by ripgrep, I might keep it longer.

@roblourens

Encoding autodetect has only existed for less than a month, and doesn't apply to non-ripgrep search, so I'm not sure how that was any different for you.

I build vscode from the sources with modified https://github.com/Microsoft/vscode/pull/10013 every stable build.
Now I do not know how I should be after ripgrep integrate

Auto-detection doesn't seem to work for "windows1251" encoding. It thinks that it is UTF-8...


fixing typo: directives => providers

Fixing issue described in #594

I signed it!

closing to update branch with correct author info.


Unstable operation of the miner on Windows 11 (64-bit)

The miner of the latest version, alas, is unstable with rx 580 video cards, on AMD chips, the problem occurs on the Windows 11 64-bit platform, the version of the video card drivers is the latest of the current ones!

What errors are you experiencing? Can you provide logs or screenshots?


returning > Error! Validation Failed

No explanation, don't know what's going on

the issue is that Github does not allow create topics with uppercase.


Onboarding - Onboarding video does not have an audio

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/40688
Action Performed:

Navigate to staging.new.expensify.com
Sign in with a new Gmail account
On the Onboarding select "Track business spend for taxes" as a purpose and click on continue
Input first name and last name and click on continue
Input a business name and click on continue
When the Welcome to Expensify modal opens up click on the unmute button to check the audio and notice it works fine
Open Concierge chat and wait for the backend to send attachment
Once the attachment loads play the video and unmute it

Expected Result:
Audio works fine and can be heard
Actual Result:
There is no audio for the video
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/9aafbf48-375b-40ce-ad72-7feea2d65985
View all open jobs on GitHub

@jasperhuangg  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

This is a new feature so not a blocker, discussing here if the videos should have sounds, I did not have the sounds when testing it before

this is expected now, not a problem with the videos

I believe @dubielzyk-expensify Will handle this one, assigning and making weekly

I'll get this done. Basically just need TCW to export new videos with songs. It's not a huge priority, but I'll update once I've done it

Update: Asked TCW for them but mentioned it was low priority, but will let y'all know when we get the final files

We have the final videos here now with video, but I would require help in compressing and replacing them. Last time we got @francoisl 's help, so I'd love to get his help again 😇

Yeah I can help. Can you double-check that Dropbox URL and make sure I have read access to it please? I'm getting a The folder ‘Expensify/Design/Product GIFs/01_MP4’ doesn’t exist. error.

No idea why this happens. Thought everyone had access to it. Shared with you directly regardless 😄

Sorry @dubielzyk-expensify the link https://www.dropbox.com/home/Expensify/Design/Product GIFs/01_MP4 still doesn't work, however I can access https://www.dropbox.com/home/01_MP4. To confirm, the new videos we need to compress are the ones whose name ends with -sound.mp4, right?

To confirm, the new videos we need to compress are the ones whose name ends with -sound.mp4, right?
Correct.

No idea why this happens. cc @Expensify/design

Dang no idea on that either. The permissions for that folder (and all the ones above it) look correct? That's odd.

But yeah, in the meantime, maybe we put these on Drive for Francois or something.

No worries, I'm still able to see the new videos. Thanks guys!
I'll send a PR shortly to use the new videos. I also wrote the command I use to rescale videos in Stackoverflow https://stackoverflowteams.com/c/expensify/questions/19224/19225#19225

PR approved, waiting for design feedback about the default sound settings

We've left sound off by default, but I believe that PR has been merged, so are we good to close this one?

yeah, nothing to pay


Build(deps): Bump @patternfly/react-styles from 4.92.3 to 4.92.6 (#4638)

Pull request opened by the merge tool on behalf of #4638

Merged in fc2e0f58c89c450eeb7fb813df46c70e6fe3f1fe


Cannot see files

Basic information

My operating system: MacOS 12.7.4
My mzmine version: 4.0.8

What happened
When I try importing a .raw datafile is says the task has been finished, but I can't see the files. Latest version of mzmine is not compatible with my Mac.

Hi, are you trying to import Waters or Thermo .raw?

I think it's thermo... How can I check that?


Generating all subsets iteratively

Have you read the [Contributing Guidelines on Pull Requests]
Yes
Description
closes #3067. Algorithm for generating all subsets iteratively added with time and space complexity.
Checklist

[ Yes] I've read the contribution guidelines.
[ Yes] I've checked the issue list before deciding what to submit.
[ Yes] I've edited the README.md and link to my code.

@HarshCasper  I made the requested changes kindly review.

/assign


Service Request by [DONRIE PURCELL] related to a bug in the measures download

[ ] Qualtrics Service Request Form was received from User
[ ] e-mail acknowledging that User's Qualtrics Service Request Form was sent
[ ] Problem NOT RESOLVED
[ ] Problem PARTIALLY RESOLVED
[ ] Problem FULLY RESOLVED and Issue is Closed
[ ] Qualtrics Post-Service Request Survey was sent to User

Use comments feature (below) to document:

A clear and concise description of the solution.

A clear and concise description of any alternative solutions or features you've considered.

Any additional context, such as screenshots about the problem.

Hi Jeff
I am doing some reconciliation with two tables using the strategies download and the measures download. I have noticed that there is a B1 code/strategy code  attached the Putnam County in the download  which is not consistent wit what is actually in Putnam county.
Please  can you take a look at it, and let me know if and why there may be a reason for the discrepancy.
Regards
Donrie

Not sure, Donrie. I cannot duplicate this issue and there isn't a B1 strategy in the database for this county/ipa. The download I just ran did not have this errant strategy included.

OK, that's great !

I am going ti re-run the entire data sheet because  I ran into another issue  with the download relating to issue # 47
Jeff I am going to add the screen shots here and in issue # 47 so they are placed in the correct spots

Can this issue be closed?

Yes! Thanks Jeff!


Add SOE to tooltip

@Ptrhnk Also tooltip should be revised, i.e. for what entity types we should show SOE relations. Can you add some explanatory remarks to
E classes tooltip
E classes detail
E classes Detail inversed
in the gdoc, so that I re-understand what they mean and can suggest? Basically I think it is such an important relation that it should be visible in tooltip, if non-empty, for all entity types allowing SOE.

@Ptrhnk Yes, add SOE in the tooltip for all entity types which can have SOE. SOE is a fundamental relation.

@davidzbiral
I tested behavior of tooltip on staging and SOE is visible for all required classes, so can you please reflect this behavior in the gdoc. (check all columns of SOE)


BREAKING: Introducing ValuePriorityQueue

This adds a new ref struct to the project, Lucene.Net.Util.ValuePriorityQueue<T>. This struct contains the most of the same API and business logic as PriorityQueue<T>, but allows the memory used to be allocated elsewhere as Span<T> and passed in.
The amount to allocate can be calculated by calling PriorityQueue.GetArrayHeapSize(maxSize), where maxSize is the external size of the PriorityQueue (representing the same value that is passed into the constructor of the current PriorityQueue<T>). The actual allocation amount is 1 greater than the priority queue size because it is 1-based rather than 0-based.
We get around the issue with structs not being inheritable by introducing a new IPriorityComparer<T> interface with a single bool LessThan(T a, T b) method. This signature makes converting existing subclasses of PriorityQueue<T> to IPriorityComparer<T> straightforward, as there are no business logic changes to make. This comparer is a required constructor argument of ValuePriorityQueue<T>.
This also modifies SingleTaxonomyFacets, Int32TaxonomyFacets, TopDocs merge and FST pack to use ValuePriorityQueue<T> and converts the item types they deal with from class to struct so they can be stack allocated if the size is below Constants.MaxStackByteLimit, which is set using the system property maxStackByteLimit.
Closes #774. Thanks @eladmarg for the suggestion.
There are a few more places in the codebase where this type can be useful, but unfortunately the types they use don't convert easily into structs so although we can eliminate the heap allocation of the priority queue itself, we will need some configuration and/or logic to decide whether to allocate the array directly or use an array pool.

fantastic!
sometimes the priority queue size is so small, no need even to rent and allocate on the stack is much faster.
by the way, net 7 finally introduce PriorityQueue implementation, however this one seems to be more specific and faster.


Switching cache get function to a future, adding concurrency

Based on this blog post - http://labs.strava.com/blog/futures-in-golang/

:accept:


Copy attributes back post de-serializing array

Fixes #450

nit

        for (const [key, value] of Object.entries(instance)) {

@jeremymeng, @xirzec Do we have a similar issue in @azure/core-http or the newer Azure Core packages?

@jeremymeng, @xirzec Do we have a similar issue in @azure/core-http or the newer Azure Core packages?

I am looking into it.

@deyaaeldeen @xirzec are you good with the fix?


Issue 331 Extend token validity to infinite

Since crc cluster is for development purpose, better to not expire
the token when it generated.

Does that mean we can avoid in crc to call authentication service to get a token and use one generated at snc build time ?

Does that mean we can avoid in crc to call authentication service to get a token and use one generated at snc build time ?

@guillaumerose we are not generating as part of snc (because we are using system:admin end to end)  but even it is generated the auth service need to be running to make use of it.

Yes sure but I would like to avoid crc to vendor part of openshift/oc code to do the login.
If I can take 2 predefined tokens from the bundle, it would help a lot.

Yes sure but I would like to avoid crc to vendor part of openshift/oc code to do the login.
If I can take 2 predefined tokens from the bundle, it would help a lot.

What we can do in that case create a new kubeconfig_user which have token for kube:admin and developer user and ship it as part of the bundle?

Yes sure but I would like to avoid crc to vendor part of openshift/oc code to do the login.
If I can take 2 predefined tokens from the bundle, it would help a lot.

The kubeadmin password is the same for all clusters, it's not regenerated each time we recreate a cluster, is it? Reason I'm asking is that we were asked to recreate ssh keys each time we recreate a new cluster, rather than using one created at bundle generation time. I was about to write that the tokens should be handled in a similar way, but then I realized the kubeadmin password is the same for all instances?
Next question would be if that's a good thing or not :)

First, this PR is I think a good thing for the user. Let's fix the security issue in a follow-up.
/lgtm
New issue to discuss: https://github.com/code-ready/snc/issues/333

The kubeadmin password is the same for all clusters, it's not regenerated each time we recreate a cluster, is it?

This is from an earlier discussion again... Let's follow up on #333 for this. This was also part of a security analysis that concluded this wasn't ideal.

First, this PR is I think a good thing for the user. Let's fix the security issue in a follow-up.

Yup, I was reacting to your suggestion to move all of this to snc, which might not be a good thing. But this PR does not make things worse  from that perspective.


create a conditional that renders an error message when a user submits an unknown query

If a user sends a message that is unknown in the database (such as on google) an error message will return.
Create an ErrorHandling Component and include it in the Myth Component to create your conditional.

ErrorHandling Folder is now created with MissingQuery.js as the present file to render this error message once called.

offer suggestions to user like:
'Did you mean...."
instead of displaying error message


fix: ensure cosign client can be sent between threads

After d9b198ae4530a63932d8d674b1dd033fc08b0dfe got merged, the Sync and Send supertraits got removed from the ClientCapabilities trait. This was done to ensure the code could build when the wasm32 target is used.
Unfortunately, this makes impossible to send the cosign client between threads. This causes an error like the following one:
error: future cannot be sent between threads safely
the trait `Send` is not implemented for `(dyn sigstore::registry::ClientCapabilities + 'static)`

This commit fixes the issue by introducing conditional compilation checks.

Once this is merged I would like to tag the v0.7.1 release

Hey I love this PR. Before we have to create a temporary runtime to handle this


Needs to define QueryBuild type when dynamically building query in Typescript

Environment
Knex version: 0.20.13
Database + version: Postgres
OS: Pop OS 19.10
Bug

The following code gives me a TS2322:

let floorplanBuilder = knex('floorplan');
  if (newDisplayName) {
    floorplanBuilder = floorplanBuilder.update('display_name', newDisplayName);
  }

TS2322: Type 'QueryBuilder<any, number>' is not assignable to type 'QueryBuilder<any, DeferredKeySelection<any, never, false, {}, false, {}, never>[]>'.
  Types of property 'as' are incompatible.
    Type 'As<any, number>' is not assignable to type 'As<any, DeferredKeySelection<any, never, false, {}, false, {}, never>[]>'.
      Type 'number' is not assignable to type 'DeferredKeySelection<any, never, false, {}, false, {}, never>[]'.

Specifying the variable type makes the code ok. When changing code to the following fixes the issue:

let floorplanBuilder: Knex.QueryBuilder = knex('floorplan');
  if (newDisplayName) {
    floorplanBuilder = floorplanBuilder.update('display_name', newDisplayName);
  }

This works in 0.20.10. Versions 0.20.11-0.20.13 gives the error.
@lorefnon

Hello!
Can you try to explicitly define table type at start?
knex<{display_name: string, ...}>('floorplan');

This is not expected to happen. I'll take care of this.

I have not been able to reproduce this either in current master or 0.20.13. Can you please also share:

Version of TypeScript & tsconfig.json
Whether you have @types/knex installed as well

Interesting choice of OS btw :)

I have not been able to reproduce this either in current master or 0.20.13. Can you please also share:

Version of TypeScript & tsconfig.json
Whether you have @types/knex installed as well

"typescript": "^3.7.5",
{
  "compilerOptions": {
    "experimentalDecorators": true,
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": false,
    "noUnusedLocals": true,
    "noUnusedParameters": false,
    "sourceMap": true,
    "outDir": "lib"
  },
  "include": ["src/**/*.ts"],
  "exclude": ["node_modules", "__test__", "src/**/*.test.ts"]
}

I don't have @types/knex installed

Interesting choice of OS btw :)

Heard lots of great things about it, and in the six months of use I have not been let down :smile:

@fiLLLip Unfortunately we (atleast I) won't be able to resolve this.
Knex API was not originally designed with type safety in mind, and so our typings are best-effort. Knex QueryBuilder resolves to different things based on internal state making it hard to type the return value. Our typings pretend that different methods of fluent chain return values of different types which makes reassignments problematic.
In order to fix this we will need to fall back to any return type for most common operations, which makes the typings much less useful.

That's ok. We will use let floorplanBuilder: Knex.QueryBuilder = ... as this works :) Great work, btw. I can imagine these typings are not easy to manage. Feel free to close this if you don't want it open

@lorefnon Now that #3765 was released with 0.20.14, is this issue still relevant?

Umm ... so that PR solves a related issue but it doesn't fix the problem here.

In order to fix this [completely] we will need to fall back to any return type for most common operations, which makes the typings much less useful.

This still holds true, and so I don't think this is practically fixable.


Docs: README update #60

Description

Update the documentation before releasing.
Related Issue

Summary by CodeRabbit

New Features

Enhanced documentation across multiple packages, including installation instructions and API details.
Introduced new sections in READMEs for improved clarity and usability.

Bug Fixes

Updated project status indication in the README to better communicate readiness.

Documentation

Added comprehensive guides and examples for using packages, improving user onboarding and understanding.

Refactor

Minor adjustments made to existing documentation for consistency and clarity.

Additional context

Checklist

/fast-forward


Corresponds to authorization code grant flow.

Relevant Issue: https://github.com/personium/personium-core/issues/213

Released in v1.4.12.


Weird behavior of rename

Describe the issue:
In our project, we rename columns in pandas DataFrames and dask DataFrames. However, dask DataFrames behave different, if a dict is passed to rename, in which a value corresponds to a column name in the DataFrame. Is this intended?
Minimal Complete Verifiable Example:
import dask.dataframe as ddf
import pandas as pd

columns_ab = {"a": "b"}
columns_bb = {"b": "b"}
columns_ba = {"b": "a"}

df = pd.DataFrame({"a": [15.0]})

# Works as intended
df.rename(columns=columns_ab)["b"]
df.rename(columns=columns_bb)["a"]
df.rename(columns=columns_ba)["a"]

# KeyError in the last line
df_dff = ddf.from_pandas(df.copy())
df_dff.rename(columns=columns_ab)["b"].compute()
df_dff.rename(columns=columns_bb)["a"].compute()
df_dff.rename(columns=columns_ba)["a"].compute() # fails with KeyError: 'a'

Anything else we need to know?:
Environment:

Dask version: 2024.4.0
Python version: 3.9.19
Operating System: MacOS
Install method (conda, pip, source): conda

Thx for the report. The new optimiser messes things up here. I've put up a PR and we will cut a release soon

Perfect, works now, thanks a lot!


Added location, type, and privacy to completed-docs

Also adds interfaces, enums, types, and a few other doc-able contructs.
Fixes #1713.
Lays the groundwork for #1921.

I think you need to rebase

Rebase should be good to go.

I think this may be considered a breaking change if someone already specifies "all" because they'll see new errors. Thoughts?

Agreed. Changed it to use the current default, so that the new locations are opt-in. For the next TSLint release we could consider expanding default coverage.

:running_shirt_with_sash: when it will be released?

@FDiskas it's available since v4.5. you can find out by yourself by clicking through to the squashed commit:

and look at the tags list:

what's the status? I still can't get it work

@viktor-bredihin what is your tslint.json config, and what are you trying to lint? Can you post a minimum reproduction we can take a look at? What problems are you seeing?

@JoshuaKGoldberg
I'm trying to make this rule work '"completed-docs": true', it's not showing any errors in webstorm, however works fine when I use tslint in the console

Ah - that's not an issue with this rule. That's an issue with the Webstorm TSLint extension.
completed-docs is a "type checked" rule (link to docs). That means it uses more expensive APIs from TypeScript. Many extensions don't support this kind of rule for performance reasons.


Support flashing to board on nexys_video platform / check flash addresses

First of all, thanks for the awesome project! This has been a real joy to tinker with, and I've learnt a huge amount doing so.
I'm currently trying to build and flash the firmware on my Nexys Video board, which builds and runs the firmware and gateware perfectly fine (I'm lagging behind master, FWIW, but the relevant code is the same), and runs nicely in temporary mode. Likewise, flashing the gateware via make gateware-flash-py works perfectly, however make firmware-flash-py results in the following error:
Traceback (most recent call last):
  File "flash.py", line 76, in <module>
    main()
  File "flash.py", line 69, in main
    address_end - address_start, file_size)
AssertionError: File is too big!
-32768 file doesn't fit in 68020 space.

This error is thrown by an assertion in flash.py, which compares file_end = address_start + file_size to address_end to guard against overflows, which makes total sense (to me).
However, further up in flash.py, where the values are defined for the firmware, looks weird:
address_start = platform.gateware_size + make.BIOS_SIZE
address_end = platform.gateware_size

Because make.BIOS_SIZE on my system is 32768, the result of subtracting address_end - address_start is negative that.
There are a few things that seem strange here:

The BIOS_SIZE looks like it should be added to both address_start and address_end in line 43, and an additional value should be added onto address_end. Or, because the firmware comes last on the chip, it might be that line 44 should be address_end = platform.spiflash_total_size
In the assertion in line 63, it seems that the positions of address_end - address_start and file_size should be replaced. The error message above should read 68020 file doesn't fit in -32768 space. instead of the other way around.

Ok, I hope this helps, sorry for the wall of text! I'd be happy to help this get fixed, if you can confirm how this is supposed to work, I'll gladly put together a pull request.

I believe https://github.com/timvideos/HDMI2USB-litex-firmware/pull/426 should fix this.

I believe it does, thanks a lot! I've added a minor comment to line 47.


Added the PictureFill polyfill for the Picture element

Hi
This is a pull request to add support for the Picture element in unsupported browsers using the Polyfill service
Thanks
Jonathan

Thanks Jonathan.  Aside from the minor issues above, are there any tests that can be added?  We like to have a test for at least the main core use cases, so that our test framework can check browser compatibility.

Also, it would be good to have an update task.  This is a new feature that enables third party polyfills to be kept up to date automatically.  I've just pushed some documentation for how to create an update task in https://github.com/Financial-Times/polyfill-service/commit/d7cc2cd0a2a1d7afbad6b706d77172502080433d.
There's a good example of an existing task in https://github.com/Financial-Times/polyfill-service/blob/master/polyfills/Intl/update.task.js

Update task has been added

Implemented in #448


Specifying multiple host groups in one run of Ansible with unique hosts in each group

I want an inventory file that looks like this
[controller]
<IP_ADDRESS>
[infra]
<IP_ADDRESS>

Because I have a playbook task that looks like this:
---
# loop through each backend supporting the cinder api proxy
# to ensure they are up.
- name: checking cinder api haproxy backend
  haproxy:
    state: enabled
    host: "controller{{ item[0] }}"
    backend: cinder_api
    wait: yes
    wait_interval: 1
  delegate_to: "{{ item[1] }}"
  with_nested:
    - "{{ range(groups['controller'] | length) | list }}"
    - "{{ groups['infra'] }}"

Notice the task references both controller and infra host group.
So I tried something like this:
resource "openstack_compute_instance_v2" "infra" {
    name = "infra"
    image_name = "ubuntu-18.04"

    network {
        name = "public"
    }
}

resource "openstack_compute_instance_v2" "controller" {
    name = "controller-${random_string.unique.result}"
    image_name = "ubuntu-18.04"

    network {
        name = "public"
    }
}

resource "null_resource" "openstack-playbook" {

    provisioner "ansible" {
        connection {
            user = "ubuntu"
            private_key = "${var.ssh_private_key}"
        }
        plays  {
             groups = ["infra"]
             hosts = ["${openstack_compute_instance_v2.infra.access_ip_v4}"]
             playbook {
                 file_path = "../playbook.yml"
             }
        }
        plays  {
             groups = ["controller"]
             hosts = ["${openstack_compute_instance_v2.controller.access_ip_v4}"]
             playbook {
                 file_path = "../playbook.yml"
             }
        }
    }
}

But this fails with Error: Local mode requires a connection with username and host
It appears each provisioner run instance will only connect to a single Ansible host, regardless how many plays.hosts are specified.

This issue is now almost 2 years old. Does there happen to be any progress in this matter?
My use case is that I need to have a single ansible inventory with all hosts in it because my playbook tasks iterate over all hosts in a specific group to set up a database cluster...


⚠ ClamAV has degraded performance

In d47d1f4, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 744 ms

Resolved: ClamAV performance has improved in 7e94eb0.


Error: function crashed out of request scope Function invocation was interrupted.

Is there a limit on how many documents it can retrieve? I am getting this error in the middle of retrieving documents:
Error: function crashed out of request scope Function invocation was interrupted.

closing. It was a problem with my cloud function, I just had to return the promise.

@jloosli this problem is back. Do you have any idea what's going on? it crashes in the middle of retrieving users data.

Not really....I know that the API has some rate limiting on it, so when the code hits some rate limit errors, it tries to wait before getting more items, but maybe there are other places where I should place the waiting code.

@jloosli I think there are places in the code that needs to return promises, because it consistently crashes in the middle of retrieving the documents. Would you able to check on this issue please? I'd really appreciate it!


Refactored JCloud Tiered Storage

Motivation
In order to facilitate the support of additional JClouds-supported providers, we first needed to clean up the existing code, as there were a lot of if/then/else constructs throughout the code that were based on the assumption that we either supported AWS S3 or Google Cloud Storage. I didn't want to keep adding else if's to these code blocks for every new provider we add, so I decided to refactor the code to make it a bit cleaner
Modifications
in addition to being home for most of the aforementioned if/then/else blocks, the BlobStoreManagedLedgerOffloader class had multiple responsibilities in addition to providing an implementation for the LedgerOffloader interface. My goal was to simplify this class such that its only responsibility was to implement the LedgerOffloader interface.
The other major change was the addition of the JCloudBlobStoreProvider enum, which implements 3 interfaces that allow for it to handle the provider specific logic for things such as acquiring the credentials, validating the configuration, and creating a provider-specific instance of BlobStore.
Result
After this change, we will be able to easily add support for additional JClouds-supported providers by simply adding new elements to the JCloudBlobStoreProvider Enums since the other logic has been isolated and is not vendor specific.
See https://github.com/apache/pulsar/pull/2865 for more details

Any update on this?

@david-streamlio sorry for the late response. @jiazhai @codelipenghui and @gaoran10 can you guys review this pull request? @david-streamlio is waiting for a review.

move to 2.7.0 first.

Anything needed from me on this?

@gaoran10 @codelipenghui can you review this change again?

@david-streamlio Would you please help resolve the conflicts with master branch?

I will work on this conflicts shortly.

@congbobo184 @gaoran10 Would you please help review this PR?

LGTM, that's so cool.
I added an issue to track the problem with the namespace level offload feature, we could complete this PR first and repair that problem. @david-streamlio Hi, could you make a rebase for this PR? Thanks.

Code has been rebased.

/pulsarbot run-failure-checks

@david-streamlio Hi, the update files are so many, is there any way that only retain files related to this PR. Maybe we could rebase with apache/master and submit a force push.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@david-streamlio Would you please help take a look of the "ci / tieredJcloud test" and "license check" failures?

The error with the license check is network related....  Could not transfer artifact org.apache.maven:maven-model-builder:jar:3.3.9 from/to central (https://repo.maven.apache.org/maven2): Connection timed out (Read failed) -> [Help 1]

/pulsarbot run-failure-checks

@david-streamlio Hi, may I help you to to finish this task, you could give me permission for your repo and I'll fix the ci test.

I have rebased this branch to master and re-submitted.

@david-streamlio Hi, there are still some problems in this PR, I made some changes for it based on your work, could you have a look and add these changes to this PR.

/pulsarbot run-failure-checks

Would like to merge this first.

Move this change to 2.6.2, because the #8310 depends on it.


TeachingTip throws error "System.AccessViolationException"

Describe the bug

TeachingTip throws error "System.AccessViolationException" when creating in .cs code.
Steps to reproduce the bug

Steps to reproduce the behavior:
<Button x:Name="SaveButton" Content="Save" Tapped="Button_Tapped"/>
        private void Button_Tapped(object sender, Windows.UI.Xaml.Input.TappedRoutedEventArgs e)
        {
            MUXC.TeachingTip tip = new MUXC.TeachingTip();
            tip.Title = "Error";
            tip.Subtitle = "It seems you are not connected to the Internet :(";
            tip.CloseButtonContent = "OK";
            tip.IsLightDismissEnabled = true;
            tip.IsOpen = true;
        }

Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Version Info

NuGet package version:
Microsoft.UI.Xaml 2.1.190405004.2

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2019 Update (18362)

October 2018 Update (17763)
Yes

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Anniversary Update (14393)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

Duplicate of #349 , fix should go out in the prerelease this week. Sorry for the delay!

Got it. Thanks, @jevansaks


Scroll begin and Scroll end notifications are not sent

Godot version
v4.2.beta2.official [f8818f85e]
System information
Windows 10
Issue description
The NOTIFICATION_SCROLL_BEGIN and NOTIFICTION_SCROLL_END notifications are not propagated to child nodes of ScrollContainer.
Steps to reproduce
The MPR has a main scene with a ScrollContainer, a VBoxContainer and a bunch of Labels so it is tall enough to scroll. The first label has this script:
func _notification(what):
	if what == NOTIFICATION_SCROLL_BEGIN:
		print("scroll begin") #never happens
	elif what == NOTIFICATION_SCROLL_END:
		print("scroll end") #never happens

Scrolling in the ScrollContainer should trigger this notification, but it does not.
Minimal reproduction project
scroll notification.zip

Related to:

https://github.com/godotengine/godot/issues/81512


Can't get it running

Hello!
Unfortunately I can't get it to run in Docker. The Docker container is running, but when I go to http://host:8086 I get a blank page. If I then try to upload a note, it first does something (longer than if no connection) and then says error uploading. Can someone help me?
Best regards

Find this error:
File "/usr/local/lib/python3.11/site-packages/flask_cors/extension.py", line 194, in wrapped_function
return cors_after_request(app.make_response(f(*args, **kwargs)))
^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/flask/app.py", line 880, in full_dispatch_request
rv = self.dispatch_request()
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/flask/app.py", line 865, in dispatch_request
return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)  # type: ignore[no-any-return]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/sharenote-py/main.py", line 175, in create_note
title = data['template']['title']
~~~~~~~~~~~~~~~~^^^^^^^^^
KeyError: 'title'

Can you confirm that encryption is disabled in the Share Note plugin settings?

Can you open the Obsidian command palate (ctrl+p) and type "force" and force reupload of all data?
If that doesn't work, can you show me if there's any errors in your browser's network inspector?

This didn't work. Here:

Ah, maybe I know the problem. Everywhere in the code is localhost, also in Obsidian it generates a localhost link. This could be the problem.

I can't seem to reproduce. Can you show me what's in your static/ folder?
It should work fine on localhost:

Yeah, but it's on a other Server, not on my pc. I think the problem is, he tries to download the files (picture, etc.) from localhost, and this is not possible.
But here is the static folder:

You'll need to use the server's IP or a domain and set in your settings.py

Yes it's already set:


[GHSA-qppj-fm5r-hxr3] swift-nio-http2 vulnerable to HTTP/2 Stream Cancellation Attack

Updates

Affected products
CVSS
Severity

Comments
This advisory is co-opting the public CVE-2023-44487 found referenced everywhere on github now.
Those references should point to something like https://nvd.nist.gov/vuln/detail/CVE-2023-44487, not this Advisory.
Also, the CVSS score for the public CVE https://nvd.nist.gov/vuln/detail/CVE-2023-44487 is 7.5 High - CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H  (not the low number on this advisory)
To make the rest of the github sane, please remove the CVE id from this advisory, or make this advisory have it's own unique CVE id.

Hi there @Lukasa! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

This advisory is co-opting the public CVE-2023-44487 found referenced everywhere on github now.

Can you expand on what you mean there?

This advisory is co-opting the public CVE-2023-44487 found referenced everywhere on github now.

Can you expand on what you mean there?

CVE-2023-4487 is a public CVE, not assigned to any specific product or project.
The swift-nio-http2 group did not request a new CVE, but manually attached this global (spec level) CVE to advisory their advisory https://github.com/advisories/GHSA-qppj-fm5r-hxr3
What this means, is that every reference to CVE-2023-4487 on github (as text, not as a link) is now linking to this swift-nio-http2 advisory. (this is wrong)
(Even this Comment on this PR is doing it!)
Examples in Discussions:

https://github.com/Azure/api-management-self-hosted-gateway/discussions/255

Examples in Release Notes:

https://github.com/jetty/jetty.project/releases/tag/jetty-12.0.2

Examples in Issues:

https://github.com/linkedin/cruise-control/issues/2070

Examples in PRs:

https://github.com/jetty/jetty.project/pull/10682
https://github.com/openshift/lvm-operator/pull/452
https://github.com/opendatahub-io/rest-proxy/pull/20
https://github.com/apache/httpd-site/pull/10

We can generalize the text to read more generically if that's what you're asking for, but they do seem to be affected by this CVE. I don't see how this is co-opting. If the CVE/GHSA auto linking is the concern then starting a discussion or issue in this repo is probably a better approach.

The process at github for advisories is an overall good thing.
The fact that this advisory can exist, and reference the CVE-2023-4487, to have these impacted packages on swift-nio-http update on the top level CVE is also a good thing!

I don't see how this is co-opting.

co-opting is probably a poor word choice.
I can't find a better short phrase / word.
It's really "confusing the daylights out of other users" is what's going on.

If the CVE/GHSA auto linking is the concern then starting a discussion or issue in this repo is probably a better approach.

This repo? as in https://github.com/github/advisory-database ?  Will do.
Probably going to suggest some kind of "disambiguation" or "search results" style of linking instead of directly to the most recent advisory.

Filed as Issue #2869

Yeah, to clarify here we liaised with CloudFlare who specifically asked that affected implementations should use this CVE number, so we did. I think this suggests that GitHub may want to slightly tweak the implementation story, but if we hear feedback from CloudFlare that they'd like us to use a different number, we can of course do so.

@Lukasa that's correct, your advisory here is meant to update the top level CVE-2023-44487 by adding the details from this Advisory to the "Known Affected Software Configurations".
Which it has btw, see https://nvd.nist.gov/vuln/detail/CVE-2023-44487 (you appear to be Configuration 10 on that list a the time of this comment)
I represent Eclipse Jetty, and we are Configuration 5.  (We got our configuration into the CVE at the beginning, back on Oct 10th)
What isn't correct, is that this specific advisory is representing itself all over github as CVE-2023-44487.
I started this PR as a change to this specific advisory to quit representing itself as CVE-2023-44487.
@darakian has indicated that the behavior isn't meant to be corrected by modifying this advisory, but rather as a more general Issue. So I submitted Issue #2869 to hopefully get it corrected.

@joakime apologies for the delay. We can still make changes to this advisory to make it read more generically, but ya the root cause is unlikely to be fixed quickly. Do you want to close this PR out and follow up on the other issue or would generalizing this advisory also help?

@darakian if you feel that issue #2869 is the more appropriate way to handle this, then this PR can be closed in favor of working that more general solution.

@joakime. I think that might be a better place to start. We can always reopen this if need be, but I'll close this PR for now 😃


could not build module 'tflite'     #import <tflite/TflitePlugin.h>

Hi. I have this error after import tflite: ^1.1.1 Flutter version stable 1.17.3.
Please help me :(
While building module 'tflite' imported from /Users/thong_vo/AndroidStudioProjects/person/measure/ios/Runner/GeneratedPluginRegistrant.m:74:
In file included from :1:
In file included from /Users/thong_vo/AndroidStudioProjects/person/measure/build/ios/Debug-iphonesimulator/tflite/tflite.framework/Headers/tflite-umbrella.h:13:
/Users/thong_vo/AndroidStudioProjects/person/measure/build/ios/Debug-iphonesimulator/tflite/tflite.framework/Headers/ios_image_load.h:1:10: fatal error: 'vector' file not found
#include
^~~~~~~~
1 error generated.
/Users/thong_vo/AndroidStudioProjects/person/measure/ios/Runner/GeneratedPluginRegistrant.m:74:9: fatal error: could not build module 'tflite'
#import <tflite/TflitePlugin.h>

Please try the following:
Open ios/Runner.xcworkspace in Xcode, click Runner > Tagets > Runner > Build Settings, search Compile Sources As, change the value to Objective-C++.

Please try the following:
Open ios/Runner.xcworkspace in Xcode, click Runner > Tagets > Runner > Build Settings, search Compile Sources As, change the value to Objective-C++.

Thanks it work <3

Is there other workarounds for this? why is this not in the readme? other plugins in my project fail if I make this change


Feature Request : Support for disabling auto proxy creation

It would be beneficial to create and option to

Disable proxy via labels
Disable proxy creation globally (and create individually)

415f169f4894e0558d895c95e8aed3e49868b098


Unable to install plugin

Hi there,
I have the source version of UE4 (4.24.1) - and I have downloaded your plugin.
I am using the latest AWS Server SDK (3.3.0) and the client CPP SDK is v.1.7.251 - the latest as per their GitHub.
When I initially dragged the ClientSDK files into the Plugins/ folder of my project, I was getting UE4 warnings that the plugin would not work even though it had compiled and UE4 was launching - there is a similar issue for this already.
I then updated the AWS Core, Cognito Identity & GameLift libraries and DLLs, and edited the uPlugin file to use the latest version of AWS as instructed in your README.
However, when I try to launch UE4 and recompile - it fails and asks me to recompile from source.  When I do this, I am met with many errors and the plugin will not build.
Do you know if there are any issues supporting UE4 4.24.1 or the latest version of AWS SDK?
If so, what resources did you use to create this plugin?  I am quite happy to investigate either fixing your plugin or creating a new one from scratch (depending on the complexity) - however I have no idea how the SDK works and the AWS documentation online is lackluster at best.
Kind Regards,
Luke J

Last time I checked AWS Server SDK (3.3.0) only supports upto UE 4.21 at the moment. They are quite behind.


I can see the datas in the browser  of my phone, but can not in my computer

I can see the datas in the browser  of my phone, but can not in my computer. with the same url.
is any trouble with my wifi?   I use the company's wifi

I guess your computer would be connected with LAN and your phone is actually connected to WiFi, please make sure that they both are in same network.

Yeah, you are right.
Actually,  when i make two phones in the same WIFI, I can get it in both phones.
But,  in the office,  I can not make my computer connect with the same wifi, which is only can be connected with the LAN.
Thus, I think I also need Android-Debug-Database supported with the USB.
A useful project

To be added in new release https://github.com/amitshekhariitbhu/Android-Debug-Database/issues/4


feat(core): add permissions query

here we have read and write: https://github.com/GaloyMoney/galoy/blob/main/apps/dashboard/app/api/auth/[...nextauth]/route.ts#L29


Caching authenticated users

Hi, is there a way to cache the authenticated users?
Because currently whats happening is, when user goes to our page, you will be prompt to sign the mesage (Which is the authenticate function of moralis), now they are connected, then if they refresh the page, they need to sign the message again to login. Is there a way in the authenticate function that if the user is still connected, we bypass the signing of message? Thanks

This is currently already the case.
If you refresh the page then the user is retrieved from the active session. You can check this via
const {user} = useMoralis()

That should be set when you reload the app after an authentication.
You would still need to call Moralis.enableWeb3(), to enableWeb3 and connect to metamas/walletconnect to do on-chain functionalities.

Closing due to inactivity, for more support please check forum.moralis.io


HtmlReport error in rule: NestedBlockDepth

I found an error in the html report:

Rule: NestedBlockDepth
detekt version: 1.23.4"}
Stacktrace:

java.lang.StringIndexOutOfBoundsException: Range [0, 83) out of bounds for length 14
	at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
	at java.base/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
	at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
	at java.base/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)

How to reproduce it: not sure.

I'm sorry but this isn't enough to investigate - we'll need a full stack trace if you can't provide a reproducer, but a reproducer will be much more helpful.

This issue is waiting for authors feedback since 30 days. Please comment providing the requested feedback or this issue will be closed in 7 days.


Do away with unlist_dfs

I have found a better solution for this which doesn't require writing a custom function.
A = data.frame(letter = letters[1:5], number = 1:5)
B = data.frame(letter = letters[6:10], number = 6:10)
C = data.frame(letter = letters[11:15], number = 11:15)

l = list(A, B, C)

do.call(rbind, l)

[x] Do a global search for unlist_dfs and replace it with the do.call(rbind, list) syntax
[x] Remove mention of unlist_dfs from the code documentation file
[x] Rebuild/document package

Closed in #153.


treemap绑定mouseover事件bug

Version
4.3.0
Reproduction link
https://gallery.echartsjs.com/editor.html?c=xn-fVoTPq_&v=1
Steps to reproduce
鼠标连续多次移入同一个children块
What is expected?
每次移入都要触发mouseover事件
What is actually happening?
只有第一次移入触发了mouseover事件

This seems to be a bug. @huluwa123 Thanks for reporting!

Is this issue fixed? The example above looks like function normally.


Updated dependencies to latest versions and rebuild lib

Thanks for taking time to do this!

You are welcome ;)


js-soroban-sdk: Write docs, and get them building for this repo.

It would be good to have js-docs written/building/published for this client library. @tomerweller did some work on getting them building, but afaik none are written so far.
Primarily https://github.com/stellar/js-soroban-client/blob/main/src/server.ts, would be good to have some docs. Could be based on the soroban-rpc api docs.
Acceptance Criteria:
Document all the source code in js-soroban-client/src, and add auto-generating documentation from source code.

Doc framework is in place, first time publish. Follow formatting for js docs, javascript sdk
Review: tyler, discord community
Separate: document examples and json api.


Tests from iconv-lite are not passing

I did an experiment where I let all tests from iconv-lite run against this webpacked version. Here are the steps:

copy the test folder of iconv-lite into the root of this project
copy all devDependencies of iconv-lite into the package.json of this project
copy the "test": "mocha --reporter spec --grep ." over into the scripts section of the package.json of this project
remove the UTF-32/UTF-7 exclusions from webpack.config.js
ensure you are not webpacking with target: "node" but the default (web)
run yarn test

The result is a couple of test failures:
1) Full DBCS encoding tests Encode DBCS encoding 'shiftjis':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  2) Full DBCS encoding tests Encode DBCS encoding 'eucjp':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  3) Full DBCS encoding tests Encode DBCS encoding 'gb18030':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  4) Full DBCS encoding tests Encode DBCS encoding 'cp950':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  5) Full DBCS encoding tests Encode DBCS encoding 'big5hkscs':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  6) Generic UTF8-UCS2 tests Return values are of correct types:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(Buffer.isBuffer(iconv.encode(testString, "utf8")))

      + expected - actual

      -false
      +true

      at Context.<anonymous> (test/main-test.js:13:16)
      at processImmediate (internal/timers.js:456:21)

  7) Generic UTF8-UCS2 tests Convert to string, not buffer (utf8 used):

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(Buffer.isBuffer(res))

      + expected - actual

      -false
      +true

      at Context.<anonymous> (test/main-test.js:43:16)
      at processImmediate (internal/timers.js:456:21)

  8) UTF-16 decoder handles very short buffers nice:

      AssertionError [ERR_ASSERTION]: '\u0000' == ''
      + expected - actual

      -�

      at Context.<anonymous> (test/utf16-test.js:45:16)
      at processImmediate (internal/timers.js:456:21)

@gyzerok @ashtuchkin this worries me a bit. Some notes:

all tests run green when using target: "node" (not to any surprise)
I am seeing the same test errors when I try<EMAIL_ADDRESS>
I would appreciate some help in fixing these issues as they would probably block the July release where I would like to go back to the webpacked version that does not target node. Thanks.

@bpasero did you also try 0.6.2?

@gyzerok yes I am seeing the same result with either 0.6.1 or 0.6.2. Especially Error: Bad argument worries me because I thought any Buffer usage is removed in 0.6.2, the line that throws this is:
function convert(conv, input, context) {
  if (!Buffer.isBuffer(input) && input !== FLUSH) {
    throw new Error('Bad argument.');  // Not a buffer or a string.
  }

The object that is checked, when using JSON.stringify seems to be: {"type":"Buffer","data":[63]}

@bpasero I see.
No worries. I've decided to take a small break. Was using most of my free time before to make everything work 😄  But I am confident we can fix everything for July release. I will get back to it this weekend then.

Sounds good, thanks.

@ashtuchkin if there are no objections, I wonder if we should simply copy the tests folder from iconv-lite over into this repo to be able to run them? Let me know if you have a better idea...

No objections from me, I think that might be the best we can do until I
support UMD natively.
Alexander Shtuchkin
On Wed, Jul 8, 2020 at 11:25 AM Benjamin Pasero<EMAIL_ADDRESS>wrote:

@ashtuchkin https://github.com/ashtuchkin if there are no objections, I
wonder if we should simply copy the tests folder from iconv-lite over
into this repo to be able to run them? Let me know if you have a better
idea...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/iconv-lite-umd/issues/7#issuecomment-655588576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEZKHPDLWD6DGA6UI2PMOTR2SFVDANCNFSM4OUHVAQA
.

I pushed the tests to this repo so that they can be run via yarn test. Here is the result:
  244 passing (19s)
  33 pending
  8 failing

  1) Full DBCS encoding tests Encode DBCS encoding 'shiftjis':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  2) Full DBCS encoding tests Encode DBCS encoding 'eucjp':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  3) Full DBCS encoding tests Encode DBCS encoding 'gb18030':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  4) Full DBCS encoding tests Encode DBCS encoding 'cp950':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  5) Full DBCS encoding tests Encode DBCS encoding 'big5hkscs':
     Error: Bad argument.
      at convert (node_modules/iconv/lib/iconv.js:103:11)
      at Iconv.convert (node_modules/iconv/lib/iconv.js:64:12)
      at convertWithDefault (test/dbcs-test.js:44:26)
      at Context.<anonymous> (test/dbcs-test.js:230:32)
      at processImmediate (internal/timers.js:456:21)

  6) Generic UTF8-UCS2 tests Return values are of correct types:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(Buffer.isBuffer(iconv.encode(testString, "utf8")))

      + expected - actual

      -false
      +true

      at Context.<anonymous> (test/main-test.js:13:16)
      at processImmediate (internal/timers.js:456:21)

  7) Generic UTF8-UCS2 tests Convert to string, not buffer (utf8 used):

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(Buffer.isBuffer(res))

      + expected - actual

      -false
      +true

      at Context.<anonymous> (test/main-test.js:43:16)
      at processImmediate (internal/timers.js:456:21)

  8) UTF-16 decoder handles very short buffers nice:

      AssertionError [ERR_ASSERTION]: '\u0000' == ''
      + expected - actual

      -�

      at Context.<anonymous> (test/utf16-test.js:45:16)
      at processImmediate (internal/timers.js:456:21)

Hello @bpasero! I've looked into this as promised.

Especially Error: Bad argument worries me because I thought any Buffer usage is removed in 0.6.2

It's not exactly like that. In 0.6.2 what changed is that iconv-lite won't expect input to be a Buffer. So it won't use any Buffer specific methods on the input (like Buffer.concat) for example. This makes it safe for us to pass in Uint8Array. However internally Buffer is still used.
With most errors you are seeing the problem is not with the library itself or with our webpack build, but with the fact that tests are written without any expectation that they could be run against umd build where Buffer is shimmed.
So the library creates and returns buffers using it's shimmed Buffer, but tests are expecting it to be Node Buffer. These are not compatible and that's why everywhere Buffer.isBuffer is used the problem arises.
After reading this you might start wondering if it means same problem for VSCode when running in Electron. And according to my understanding it is not the case, because we don't expect Buffer as an output, but simply Uint8Array, which means that we won't be using any Buffer specific methods on the output and thus won't have these errors.
Now the only error here which concerns me personally is
  8) UTF-16 decoder handles very short buffers nice:

      AssertionError [ERR_ASSERTION]: '\u0000' == ''
      + expected - actual

      -�

      at Context.<anonymous> (test/utf16-test.js:45:16)
      at processImmediate (internal/timers.js:456:21)

I will look into it. And here is my suggestion: I don't think VSCode nor iconv-lite benefit from tests extracted and modified here. For VSCode team it means additional maintenance burden and for iconv-lite it means that nothing gets improved. To avoid this I will try to contribute to the iconv-lite tests directly and hopefully help to move more of them in the browser. Does this make sense?

I have identified the source of the last error.
// Node
Buffer.from([0x61]).toString('utf16le') == ''
// feross/buffer
Buffer.from([0x61]).toString('utf16le') == '\u0000'

Will see what I can do about it.

Sounds good, thanks. And agree, ideally tests would remain in iconv-lite and run in a mode that tests the web scenario 👍


fix compile error where _mm256_set_m128i doesn't exist, fixes #5

Solution as per https://stackoverflow.com/a/32630658/149138

Excellent!


Fix security

and switch to package-lock

Why switching to package-lock? npm failed me so many times with their dependency resolution bugs so I do not trust in that lock file anymore. I'm fine with keeping both lock files if you going to maintain the npm version.

I really don't think we need any lock file on this project, except to avoid the security alert from dependabot.
If you don't trust/want the one from npm, please go ahead and update the one from yarn to avoid the security warning :)
However, any user not using yarn (like me) will not benefit from yarn.lock, while the contrary seems to work (yarn seems to understand package-lock.json

Gotcha, I bumped minimist in yarn.lock in #105
Feel free to add package-lock.json if you need it and plan to maintain it.


How can I determine if the auto update database is working? [question]

I am running HassOS 3.11 on a Raspberry Pi, Supervisor 207 with Add-on Zwave2MQTT 0.5.0
Is there a way via the UI to determine if the Auto Update Database switch is working? Where can I go to verify the updates are current?
Thank you!

Check logs on startup, OZW will check for new updates and download them

Thank you!

I don't know how that container is installed, usually if you use docker-compose I use docker-compose log command

This is all I was able to find, just in case others were wondering: 'ha addons log a0d7b954_zwave2mqtt'
But it shows the same as what is in the HA UI


[build] Test multiple django and python versions

Added Support for python 3.7
Dropped Support for django 1.11
Fixes https://github.com/openwisp/django-loci/issues/24

Coverage remained the same at 100.0% when pulling bb884f4b9f5e48558ddc812677a36abac5e8528c on Weirdo914:python into af8544ab15a0042ecfe1e122b71156e85bfca980 on openwisp:master.


How to overwrite ASPNETCORE_ENVIRONMENT when running in Docker?

I have a bunch of appsetting json files for different environments, like for instance appsettings.local.json. I'm loading the environment specific file like this:
config.AddJsonFile($"appsettings.{hostingContext.HostingEnvironment.EnvironmentName}.json", optional: false, reloadOnChange: true);
In my yaml file I set
name: MyServices
services:
  - name: SomeApi
    project: SomeApi/SomeApi.csproj
    env:
      - name: ASPNETCORE_ENVIRONMENT
        value: "local"

When running tye run this is fine, but using --docker seems to overwrite the env variable with "Development". I can see this in the logs as wel, where I can see -e "ASPNETCORE_ENVIRONMENT=Development" being passed on container initialization.
How can I set ASPNETCORE_ENVIRONMENT to the value I want?

@davidfowl looks like it indeed. How can I help?

Send a pull request?

@davidfowl something like this https://github.com/dotnet/tye/pull/1480?


[Question]: How to use MilvusVectorStore with text_key and additional metadata?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
I'm a bit confused about the metadata generation of MilvusVectorStore.query.
My actual problem is that I want to specify a text field and some fields that are added to the metadata without adding the text itself to the metadata. If I only set the output_fields in the MilvusVectorStore constructor, I need to include the text field (or it won't be queried at all), but that also adds it to the metadata.
The output_fields parameter passed to the milvus client can either be ['*'], query.output_fields or self.output_fields base.py L415. When the metadata is generated, it always uses self.output_fields base.py L464.
Does that mean that I could set the output_fields in the constructor to only the metadata fields and then somehow set query.output_fields to the metadata fields plus the text field? I'm new to llamaindex so I don't know if this is the correct behavior but wouldn't it make sense to always exclude the text field from the metadata if it is configured? And shouldn't the metadata always use the output_fields that are actually passed to the milvus client?

In this setup:
* `text_key` is set to `"your_text_key"`, which is the key where the text is stored.

* `output_fields` is set to `["metadata_field1", "metadata_field2"]`, which includes only the metadata fields you want to retrieve, excluding the text itself [[1]](https://github.com/run-llama/llama_index/blob/main/llama-index-integrations/vector_stores/llama-index-vector-stores-milvus/llama_index/vector_stores/milvus/base.py).

This is the behaviour I expected, but - unless I'm doing something wrong - this will always fail because line 456 requires the text_key to be included in the output_fields. If I try this, the text is not queried at all and creating the text node fails.


AutoCompleteExtender OnClientItemSelected not firing in Chrome

AutoComplete list fills as expected, but upon selection the OnClientItemSelected event does not fire.
The target box fills with selected text, but the hidden text box for the value does not due to the event not firing.
Web service is returning AjaxControlToolkit.AutoCompleteExtender.CreateAutoCompleteItem list.
Using AjaxControlToolkit version 16.1, asp.net 4.5.
No errors are generated, the event just isn't firing. Put a simple js alert which fires from IE--nothing from Chrome.
Any ideas how I can get the event to fire in Chrome?

Found event is firing however the target has onchange event to clear the hidden field populated by OnclientItemSelected.
In IE the onchange fires first and OnClientItemSelected Fires second. It is the reverse in Chrome.
was attempting to clear the hidden key when the user changed the target text without selecting from the auto complete list.
Not sure why the events fire in different order between browsers...


Add target label support to mux plugin

Replicate new "--set-label" and "--reset-label" options from "remap/duplicate" to the "mux" plugin.

Hi @lelegard ,
I hope you don't find it redundant. This simplifies the muxing process a lot!

Merged. And similar feature added to plugin merge.

Merged. And similar feature added to plugin merge.

Great! :+1:


Renaming

Rename the following constants
IdP -> PathP
Id -> Path
glue -> Glue
glueElem -> glue
unglueElem -> unglue
in order to better match what is in the paper.

I've done this now. I also renamed visible to transparent in order to match what is in Coq.


Using negative prompt brakes SDXL txt2img

Steps to reproduce:

Set SDXL txt2img, use Euler A, prompt with negative prompt
Make image
Error happens:

[2023-12-14 19:14:50,365] WARNING: onnx-web worker: directml MainThread onnx_web.diffusers.load: error while enabling auto attention slicing: 'ORTStableDiffusionXLPipeline' object has no attribute 'enable_attention_slicing'
[2023-12-14 19:14:52,756] ERROR: onnx-web worker: directml MainThread onnx_web.chain.pipeline: error while running stage pipeline, 1 retries left
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 227, in __call__
    stage_result = stage_pipe.run(
  File<EMAIL_ADDRESS>line 144, in run
    result = pipe(
  File<EMAIL_ADDRESS>line 590, in __call__
    return StableDiffusionXLPipelineMixin.__call__(self, *args, **kwargs)
  File<EMAIL_ADDRESS>line 434, in __call__
    prompt_embeds = np.concatenate((negative_prompt_embeds, prompt_embeds), axis=0)
  File "<__array_function__ internals>", line 180, in concatenate
ValueError: all the input arrays must have same number of dimensions, but the array at index 0 has 2 dimension(s) and the array at index 1 has 3 dimension(s)

You will get same error even after removing negative prompt, restarting API helps to resolve error

I tested this with Euler A and a few other schedulers, but I'm not able to reproduce it:

{
  "input_size": {
    "width": 1024,
    "height": 1024
  },
  "outputs": "txt2img_2045114381_b759c25db9a9fba9815472c4be2bc8e8eb29c2a9f0241fd66f4e30c9e049798b_1702606569_0.png",
  "params": {
    "model": "diffusion-sdxl-cotton-candy-3d",
    "pipeline": "txt2img-sdxl",
    "scheduler": "euler-a",
    "prompt": "a cute puppy dog",
    "negative_prompt": "cat, cows, sheep, fish, zebras",
    "cfg": 4.0,
    "seed":<PHONE_NUMBER>, "steps": 50, "eta": 0.0, "batch": 1, "control": "", "input_prompt": "a cute puppy dog", "input_negative_prompt": "cat, cows, sheep, fish, zebras", "loopback": 0, "tiled_vae": false, "unet_overlap": 0.75, "unet_tile": 1024, "vae_overlap": 0.25, "vae_tile": 512, "denoise": 3}, "highres": {"enabled": false, "iterations": 1, "method": "bilinear", "scale": 1, "steps": 1, "strength": 0.1}, "upscale": {"upscale_model": "upscaling-swinir-real-x2", "correction_model": "correction-codeformer", "denoise": 0.5, "faces": false, "face_outscale": 1, "face_strength": 0.5, "format": "onnx", "outscale": 1, "pre_pad": 0, "scale": 1, "tile_pad": 10, "upscale_order": "correction-first"}, "size": {"width": 1024, "height": 1024}}

I do recall pushing a fix for a similar issue to optimum a while back (https://github.com/huggingface/optimum/pull/1339), so it's possible something is out of date, possibly. I've updated the base requirements with the latest versions of diffusers and optimum, which are working well for me. Can you try updating to those versions and see if this is still happening?

@ssube
The conflict is caused by:
    The user requested huggingface-hub==0.16.4
    accelerate 0.25.0 depends on huggingface-hub
    controlnet-aux 0.0.2 depends on huggingface-hub
    datasets 2.15.0 depends on huggingface-hub>=0.18.0

Went smooth with huggingface-hub==0.19.4, problem fixed

I thought I had included huggingface-hub in the pip upgrade, but I'll bump that version as well before the release.


ViroVideo playing camera recorded video by rotating -90 degree

Camera recorded uploaded video are playing on -90 degree rotated in ViroVideo.  While the whatsapp or other videos after uploading played in right orientation in ViroVideo.
Original video - https://firebasestorage.googleapis.com/v0/b/odoori-de298.appspot.com/o/Videos%2F2_1543406095775.mp4?alt=media&token=9a642bc9-7c17-4bb6-ba9a-5a7324f30700
ViroVideo (-90 degree) - https://drive.google.com/file/d/1ZGjfZkj39zGLx_N_i6cbyEZh118kkPuT/view
My code is in the example https://github.com/viromedia/viro/issues/473

@VikAdvani @dthian    Could you guys please have a look in the issue.
Some downloaded videos working fine. See
https://drive.google.com/file/d/1YgzsrUBDL18GWVyW-r2g-NrW5iu9owD2/view
But camera recored videos are not playing in right orientation.

Hi @krishanjangir,
What device are you using to record these videos?
You're right in that most videos seem to work just fine, but your video is somehow presented whiled rotated 90 degrees. We've not seen this issue before and we suspect it's something to do with how that video may be encoded?
For example, this video, shot on a S8 doesn't have the issue: https://s3-us-west-2.amazonaws.com/viro/2018_11_07_11_40_35.mp4
Thanks,

@achuvm
No the issue is not with the video encoded.
I have created the video using camera
https://drive.google.com/open?id=170Fj_rFCnIfzdrMU0jg69ZPycuDHIfs-
and uploaded it on firebase direct (so no encoded) and played it in single ViroVideo, still there is an issue.
https://drive.google.com/open?id=1jWsI-CVZpkNTORaLeU9j6SN_Lv1n5iNO
The same is happening on iPhone also.
Please help me resolve the issue.

@achuvm  to confirm is codec is wrong or right.
i have created a video from iPhone and uploaded it on firebase.
https://firebasestorage.googleapis.com/v0/b/odoori-de298.appspot.com/o/Videos%2FIMG_2650.MOV?alt=media&token=5390f002-30e3-45ae-96e4-d4d6baf21b79
But the video is still played -90.
https://drive.google.com/open?id=1iYTfqJ7c0HF1s_NDonAAvxLhsSZqjMnd
If i am doing rotation={[0,0,-90]} this is wrong for other videos.
Please help me resolve it asap. I have a release on this Monday.

Hello @achuvm
I am using device default camera to create video.
i am using below devices
Moto 5s Plus (Android 8.1.0)
iPhone 6 (IOS 11)
As i am using device default camera so there is no encoding on my side in video's.
These videos should play in right orientation.
As i have a major release so when i can expect solution from ViroMedia for this issue.

Hi @krishanjangir,
That's interesting that you see this by default on those devices. We don't see it on the iPhone 6 that we have.
This'll be fixed in our next release, however we don't have a timeline for that just yet.
Thanks,

@krishanjangir  this issue is still appear in v2.14.0. Look like they didn't fix it.

@krishanjangir can provide your code for reference?


Support for @import ?

Hello again. This is going to be a bit tricky to explain but I will give it a go in a reduced test case form...
someSnippet.js
var express = require('express');
var minify  = require('express-minify');

var app = express();

/*
 * Bunch of other express specific intialization and then...
 */
express.static.mime.define({
  'text/less': ['less']
});

/*
 * Use minify
 */
app.use(minify());

someSnippet.html
<link rel="stylesheet/less" type="text/css" href="/source1.less">

source1.less
@import 'source2.less';

body {
  background-color: @my-color;
}

source2.less
@my-color: #ABC123;

Produces the following output at our http://localhost:8080/source1.less:
{"type":"File","filename":"input","index":0,"line":1,"callLine":null,"column":0,"extract":[null,"@import 'source2.less';",""],"message":"'source2.less' wasn't found. Tried - source2.less,source2.less"}

... instead of the expected ...
body{background-color:#abc123}

Did I do something incorrectly with express-minify initialization?
Do you support the @import statement? Currently we are using the less-middleware package to achieve support.
If you do support the @import statement we are going to need some exposure to the paths option in less too probably similar to #15 e.g. we currently pick through a series of .less files at different paths in our project tree and import them into our own .less from a different path.

As long as we don't use the @import statement and keep all variables and mixins in the same file express-minify works with less parsing and compiling... however splitting them out doesn't seem to.
Any help would be greatly appreciated.

Actually this is a hard problem, cause we don't know what is the FileSystem location only based on req. Any ideas?

New ideas: allowing users to specify a LESS instance so that he/she can get control with the working directory configurations.

You can specify LESS options now.


Material Design specs

The sample app UI is quite crude, and parts of it does not follow the MD specs.
e.g. the Add icon used in the FAB is using the wrong size
e.g. paddings of text
Are there any plans to touch up the UI? or a mock that i can follow for a PR

Yes, there are plans to add Material design.  Would you like to take a pass at it?
A good first PR for MD would be simply adding the dependency and changing the theme: https://material.io/develop/android/docs/getting-started/

sure, i'll add in the dependency, Theme.MaterialComponent, and some minor xml UI tweaks

You might run into issues with implementing this.  Material Design Components require AndroidX, and there is currently an issue with AndroidX and Navigation.

Temporarily we can use com.android.support:design:28.0.0-alpha3 since its the same as com.google.android.material:material.
but doing so will increase the ext {supportLibraryVersion = '28.0.0-alpha3'}. are you fine with this?
To fully migrate to androidx, i think it should be a commit on its own.

There are a few things that require more touch up.

The spacing of the text between image and text in list item. they seems a little far, may be confusing due to the text might related to the top or the bottom image without reading the text.
suggestion 1: put the text on the image to inline it. text may need to be shorter to fit nicer
suggestion 2: have more space between the text and the next item (32dp), doing this will probably have to write a SpaceItemDecorator that applies top margin on 2nd item onwards
https://material.io/design/components/image-lists.html#anatomy

The image size should be in ratio. the recommended ratios are 16:9, 3:2, 4:3. the garden fragment items can be taller to support more text (e.g. 4:3 ?) while plant list can be 3:2.
https://material.io/design/layout/spacing-methods.html#containers-aspect-ratios

Doing transition animation to detail activity via the hero image

the text padding/margin in detail activity. 16dp instead of 8dp

The navigation drawer should close first (if open) onBackPressed. Right now, the drawer is left open while fragment transactions going in the back.

@ankuranurag2 thanks for reporting that.  Can you create a new issue to track the bug separately from the this general MDC redesign issue?

@tiembo i think we should close this thread and open individual issues instead of delaying v0.1.3.
since MD improvements is never complete, this issue will never close .

@andhie sounds good.  Closing this issue to release v0.1.3.  Mind creating new issues for the four topics you mentioned?


Question about mac

Hello
I download the dgm on my mac but it failed to be settled down. My computer alarmed me a popup as this dgm was broken. So I am wondering would u mind tell me what I should do?
Thank u.

You can try to download it again, maybe the dmg file was not downloaded completely.

No it still does not work. You may see this picture here

Is that anything damaged from this dmg? I just downloaded the dmg in the file only. Should I download the sources package?

I guess the problem only exists in 5.0 dmg, as I tried 4.11 it can be opened

If I employed 4.11
19:54:37,145 - INFO - Using Sci-Hub URL: https://sci-hub.se
2021-09-14 19:54:37,146 - INFO - Query type: DOI
2021-09-14 19:54:37,146 - INFO - Fetching PDF URL ...
2021-09-14 19:54:38,480 - ERROR - Failed to get PDF URL!
2021-09-14 19:54:38,480 - ERROR - No valid !
2021-09-14 19:54:38,480 - INFO - You may need handle it manually.
2021-09-14 19:54:38,480 - INFO - Request URL: https://sci-hub.se/10.1016/j.pubrev.2011.04.002
2021-09-14 19:54:38,480 - INFO - Response URL: https://sci-hub.se/10.1016/j.pubrev

https://sci-hub.se site is down. Try another one. Also, app use GET method to fetch pdf, but the sci-hub website has changed. Need some time to fix this problem.

https://sci-hub.se site is down. Try another one. Also, app use GET method to fetch pdf, but the sci-hub website has changed. Need some time to fix this problem.

Yes. Sadly, I found they changed another link.
Hope u can work out! Pls notify me if you have done that successful. Thank u.

Please download the latest release to fix this problem.


Fix the overlap the line by a few pixels (#139311)

Replace clientWidth and clientHeight with offsetWidth and offsetHeight，to solve overlap the line

This PR fixes #139311
fix the overlap the line by a few pixels, current use clientHeight value calculations, the borderWidth is ignored when calculating the offset, his value is 1, resulting in less subtraction and some pixels are overlap

Thank you!


fix(database): block built-in databases when auto-sync databases to project

What type of PR is this?
type-bug
module-database management
What this PR does / why we need it:
When a datasource is bound to a project, then these built-in database such as oceanbase, mysql, information_schema, test, SYS are inculded when auto-sync databases to project. But these database are usually not used by DEVELOPER.
In this PR, I make these databases defaultly not auto-sync. And user themselves can config it by alter metaDB.
Which issue(s) this PR fixes:
Fixes #955
Special notes for your reviewer:
Self-test passed
Additional documentation e.g., usage docs, etc.:

lgtm, @MarkPotato777 may see this


VS Code flagging { and } within  tags as problems in some cases

Issue Type: Bug
VS Code is flagging some { and }  characters embedded in  tags as invalid characters. I have several examples of TypeScript, JavaScript, and ASP.NET MVC code where I need to display curly braces. Angular/TypeScript chokes if I include those characters as { and }, so I'm using HTML encoding for those characters. Angular/TypeScript is happy with the encoded characters, but for some reason VS Code flags some of those with "Expression expected" and "Invalid character" errors. They're showing up as problems in the code.
Here's an example. VS Code is happy with all of these except for the 2 in the "LogOutDialogButtonPressed" function.
        <pre ngNonBindable>

using (Html.JhaHeader())
{
using (Html.JhaHeaderLeft())
{
<a href="/Main/Home">
@Html.JhaHeaderTitle("Sample App");
</a>
}
using (Html.JhaHeaderRight())
{
if (SampleAppDataAccess.GetLoggedIn())
{
@Html.JhaHeaderButton(Icons.Palette, "Theme", "/Main/Theme",
active: SampleAppDataAccess.GetActivePage() == "Theme");
@Html.JhaHeaderButton(Icons.GoTo, "Log Out", clickJS: "$('#logOutDialog').modal()");
}
}
@Html.JhaMessageBox("logOutDialog", "Do you wish to log out?",
MessageBoxButtonListTypes.YesNo, "", "LogOutDialogButtonPressed");

}
VS Code version: Code 1.22.1 (950b8b0d37a9b7061b6f0d291837ccc4015f5ecd, 2018-04-06T02:26:57.615Z)
OS version: Windows_NT x64 10.0.15063

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz (4 x 2904)

Memory (System)
15.88GB (8.94GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

vscode-npm-script
eg2
0.3.3

vscode-tfs
iva
0.6.0

code-beautifier
mic
2.0.3

csharp
ms-
1.14.0

team
ms-
1.122.0

debugger-for-chrome
msj
4.3.0

(4 theme extensions excluded)


fix: included max_age in sign in args

Closes/fixes #976
Checklist

[x] This PR makes changes to the public API
[x] I have included links for closing relevant issue numbers

thanks for the contribution!


Don't pointlessly install PhantomJS on Travis

The gemified version of Jasmine uses the gemified version of PhantomJS which auto-installs it if it can't find your installation in ~/.phantomjs. Travis already has a version of PhantomJS installed in a different location, so the gem will auto-install even if it's pointless.
Also, the gemified PhantomJS hardcodes install URLs from BitBucket which times out
and causes failed builds:

Phantomjs does not appear to be installed in
/home/travis/.phantomjs/2.1.1/x86_64-linux/bin/phantomjs, installing!
% Total    % Received % Xferd  Average Speed   Time    Time     Time
Current
Dload  Upload   Total   Spent    Left
Speed
0     0    0     0    0     0
0      0 --:--:-- --:--:-- --:--:--
0
0     0    0   333    0     0
2955      0 --:--:-- --:--:--
--:--:--  2955
bunzip2: phantomjs-2.1.1-linux-x86_64.tar.bz2 is not a bzip2 file.
tar: phantomjs-2.1.1-linux-x86_64.tar: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now rake aborted!
TypeError: no implicit conversion of nil into String
/home/travis/build/ManageIQ/manageiq/vendor/bundle/ruby/2.3.0/gems/phantomjs-<IP_ADDRESS>/lib/phantomjs/platform.rb:72:in 'block in install!'

TLDR: Don't install auto-install PhantomJS on CI. In Travis we trust.
Links

https://github.com/travis-ci/travis-ci/issues/3225
https://github.com/ariya/phantomjs/issues/13953

Ugh. This workaround might only exist in the npm distribution from Medium, not the Jasmine gem. Work in progress.

Ran this change in Travis 3-4 times, hasn't failed yet (and is faster, as we're not installing PhantomJS needlessly...) Calling it good.
cc/ @chessbyte @dclarizio @himdel

So much yes with this!  I can't believe that the jasmine gem did this, nice catch!

:+1: LGTM

I guess what I didn't realize (which was a great link to include in this PR, thanks Chris) is that we would be using an older version of Phantom.js (1.9.8 I believe)

Yup, CI will run an older version of Phantom than what's installed on the gem. As long as the tests pass I see no problems for now. There are other ways you can manually install v2 on Travis but we might as well wait and see, if ever, Travis just eventually makes v2 available.

Euwe Backport details:
$ git log -1
commit 6ed2876fbed142011c730a6fcc71abf3d789bd5e
Author: Brandon Dunne<EMAIL_ADDRESS>Date:   Fri Oct 14 17:53:28 2016 -0400

    Merge pull request #11929 from chrisarcand/alternate-phantomjs-cdn

    Don't pointlessly install PhantomJS on Travis
    (cherry picked from commit 284fd0a5e6d268de4b3619acd050ddc02abb953b)


[BugFix] When forwarding SQL to leader, forward all modified session variable as well

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/StarRocksTest/issues/753
Problem Summary(Required) ：

Store modified session variables to ConnectContext.
Add a SetStmt SQL to LeaderOpRequest to set all modified session variables
Leader will apply all session variables before executing the forwarded SQL.

[FE PR Coverage Check]
:disappointed: fail : 20 / 32 (62.50%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/LeaderOpExecutor.java
0
3
00.00%
[136, 137, 138]

:large_blue_circle:
com/starrocks/qe/StmtExecutor.java
0
1
00.00%
[315]

:large_blue_circle:
com/starrocks/qe/ConnectProcessor.java
0
3
00.00%
[565, 566, 567]

:large_blue_circle:
com/starrocks/qe/VariableMgr.java
0
1
00.00%
[556]

:large_blue_circle:
com/starrocks/qe/SetExecutor.java
1
2
50.00%
[81]

:large_blue_circle:
com/starrocks/qe/ConnectContext.java
5
8
62.50%
[278, 279, 281]

:large_blue_circle:
com/starrocks/scheduler/TaskRun.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
12
12
100.00%
[]

run all

run starrocks_fe_unittest

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 25 / 31 (80.65%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/LeaderOpExecutor.java
0
3
00.00%
[136, 137, 138]

:large_blue_circle:
com/starrocks/qe/ConnectProcessor.java
0
3
00.00%
[565, 566, 567]

:large_blue_circle:
com/starrocks/qe/ConnectContext.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/qe/SetExecutor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/scheduler/TaskRun.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
12
12
100.00%
[]

:large_blue_circle:
com/starrocks/qe/VariableMgr.java
1
1
100.00%
[]

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_admit_test

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 25 / 31 (80.65%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/LeaderOpExecutor.java
0
3
00.00%
[136, 137, 138]

:large_blue_circle:
com/starrocks/qe/ConnectProcessor.java
0
3
00.00%
[565, 566, 567]

:large_blue_circle:
com/starrocks/qe/ConnectContext.java
9
9
100.00%
[]

:large_blue_circle:
com/starrocks/qe/SetExecutor.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/scheduler/TaskRun.java
2
2
100.00%
[]

:large_blue_circle:
com/starrocks/sql/analyzer/AST2SQL.java
12
12
100.00%
[]

:large_blue_circle:
com/starrocks/qe/VariableMgr.java
1
1
100.00%
[]

@mergify backport branch-2.2 branch-2.3 branch-2.4 branch-2.5


Add tenant range migration option for IS 5.4.0 and IS 5.5.0 migration clients.

This will add the capability to migrate the selected tenant by specifying following in the "migration-config.yaml"
migrateTenantRange: "true"
migrationStartingTenantID: "100"
migrationEndingTenantID: "200"
Note: This fix is only for the IS 5.4.0 and IS 5.5.0 migration clients.

Do we need to implement this range option to other clients as well?


Can't run opa module on a private GKE Cluster

With @ralgozino we found out that we can't run opa module on a private GKE Cluster (e.g. the one created by the furyctl provisoner).
"By default, firewall rules restrict the cluster master communication to nodes only on ports 443 (HTTPS) and 10250 (kubelet). Although Gatekeeper exposes its service on port 443, GKE by default enables --enable-aggregator-routing option, which makes the master to bypass the service and communicate straight to the POD on port 8443."
From: https://open-policy-agent.github.io/gatekeeper/website/docs/vendor-specific/#running-on-private-gke-cluster-nodes
This results in the following timeout:
$kubectl create ns fury

Error from server (InternalError): Internal error occurred: failed calling webhook "check-ignore-label.gatekeeper.sh": Post https://gatekeeper-webhook-service.gatekeeper-system.svc:443/v1/admitlabel?timeout=3s: dial tcp <IP_ADDRESS>:8443: i/o timeout

Solutions (again from the Gatekeeper documentation):

create a new firewall rule from master to private nodes to open port 8443 (or any other custom port)
make the pod run on privileged port 443 (need to run the pod as root)

Another option would be running the webhook on TCP/10250, this way you can still run it as a non-root user.

We actually tested adding the FW rule with @nikever and it worked as expected. I think is the right way to do it™, it's the cleanest option and will keep everything aligned with upstream and between all the cloud providers.

We actually tested adding the FW rule with @nikever and it worked as expected. I think is the right way to do it™, it's the cleanest option and will keep everything aligned with upstream and between all the cloud providers.

Im with Rambo


Async event enrichment

This PR aims to improve the concurrency of event-enrichment.
Today when a batch of events is received from the token connector, each event is processed synchronously. In the case of an NFT transfer event, processing that event involves a call to getTokenURI() which requires communication with the chain via the blockchain connector. These calls can be made in parallel so long as the original order of the events is maintained when the batch is sent on to FireFly core.

This looks great, although I left a few potential cleanup suggestions. Please also check npm run lint to be sure there aren't any lint issues.
Are you planning to port these changes to ERC1155, or can you open a tracking issue there if it's not on your immediate backlog?

Thanks for the comments @awrichar I'll address them today and get it merged. Yeah I was aware of the message array issue you mentioned for the 1155 connector so I'll raise a PR to port these changes to the 1155 connector and change to an array of messages in that repo.


Slider import from react native resolved

Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.

Here is the diff that solved my problem:
diff --git a/node_modules/react-native-color-picker/dist/HoloColorPicker.d.ts b/node_modules/react-native-color-picker/dist/HoloColorPicker.d.ts
index e4a4a10..3df2476 100644
--- a/node_modules/react-native-color-picker/dist/HoloColorPicker.d.ts
+++ b/node_modules/react-native-color-picker/dist/HoloColorPicker.d.ts
@@ -1,5 +1,5 @@
 import React from "react";
-import { Slider } from "react-native";
+import Slider from '@react-native-community/slider';
 import { HsvColor, IPickerProps, Point2D } from "./typeHelpers";
 declare type SliderProps = {
     onValueChange?: (value: number) => void;
diff --git a/node_modules/react-native-color-picker/dist/HoloColorPicker.js b/node_modules/react-native-color-picker/dist/HoloColorPicker.js
index a177142..95280a3 100644
--- a/node_modules/react-native-color-picker/dist/HoloColorPicker.js
+++ b/node_modules/react-native-color-picker/dist/HoloColorPicker.js
@@ -12,7 +12,8 @@ var __extends = (this && this.__extends) || (function () {
     };
 })();
 import React from "react";
-import { I18nManager, Image, InteractionManager, Slider, StyleSheet, TouchableOpacity, View, } from "react-native";
+import { I18nManager, Image, InteractionManager, StyleSheet, TouchableOpacity, View, } from "react-native";
+import Slider from '@react-native-community/slider';
 import tinycolor from "tinycolor2";
 import { createPanResponder } from "./utils";
 var HoloColorPicker = /** @class */ (function (_super) {
diff --git a/node_modules/react-native-color-picker/src/HoloColorPicker.tsx b/node_modules/react-native-color-picker/src/HoloColorPicker.tsx
index 51a7bcc..6707587 100644
--- a/node_modules/react-native-color-picker/src/HoloColorPicker.tsx
+++ b/node_modules/react-native-color-picker/src/HoloColorPicker.tsx
@@ -4,13 +4,12 @@ import {
   Image,
   InteractionManager,
   PanResponderInstance,
-  Slider,
   StyleSheet,
   TouchableOpacity,
   View,
 } from "react-native"
 import tinycolor from "tinycolor2"
-
+import Slider from '@react-native-community/slider';
 import { HsvColor, IPickerProps, Point2D } from "./typeHelpers"
 import { createPanResponder } from "./utils"

This issue body was partially generated by patch-package.

Thanks man.

Did you guys are using expo ?
Seems that I can create a developement client build with a patched package ... I still have the error on mounting the component 😢

@seba9999 Same here !


changed license to MIT

In response to Issue: #23

I made the change yesterday but forgot to push it.


Seneye USB timeouts

In some cases this error is thrown. I've updated the code to open and close the USB device in the update statement, which works fine when the device is only reading every 30 mins but is overkill for when light readings are implemented. Leaving here for tracking, for when that change is introduced.
usb.core.USBError: [Errno 19] No such device (it may have been disconnected)
2019-02-25 11:16:13 ERROR (MainThread) [homeassistant.helpers.entity] Update for sensor.seneye_temperature fails
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 221, in async_update_ha_state
await self.async_device_update()
File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 347, in async_device_update
await self.async_update()
File "/config/custom_components/sensor/seneye.py", line 144, in async_update
await self._data.async_update()
File "/config/custom_components/sensor/seneye.py", line 161, in _async_update
resp = self._device.action(Action.SENSOR_READING)
File "/config/deps/lib/python3.6/site-packages/pyseneye/sud.py", line 584, in action
self._write(cdef.cmd_str)
File "/config/deps/lib/python3.6/site-packages/pyseneye/sud.py", line 557, in _write
return self._instance.write(self._ep_out, msg)
File "/config/deps/lib/python3.6/site-packages/usb/core.py", line 948, in write
self.__get_timeout(timeout)
File "/config/deps/lib/python3.6/site-packages/usb/backend/libusb1.py", line 842, in intr_write
timeout)
File "/config/deps/lib/python3.6/site-packages/usb/backend/libusb1.py", line 920, in __write
_check(retval)
File "/config/deps/lib/python3.6/site-packages/usb/backend/libusb1.py", line 595, in _check
raise USBError(_strerror(ret), ret, _libusb_errno[ret])
usb.core.USBError: [Errno 19] No such device (it may have been disconnected)

I think the issue is in the underlying implementation, so I'm opening the issue there. https://github.com/mcclown/pyseneye/issues/4