feat: ACIR integration tests in Bb

This adds a GoogleTest suite for running the ACIR tests generated through Noir. They currently run with GUH arithmetization but they could easily be extended.
To handle a linker error (and because WASM compilation required this through an implicit dependency not compiling) I move some function definitions from a header to a source file and take the opportunity to reduce the header size as well.

Benchmark results
Metrics with a significant change:

app_circuit_proving_time_in_ms (Test:emit_nullifier): 1,653 (-72%)
app_circuit_proving_time_in_ms (FPC:fee_entrypoint_public): 9,235 (-24%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-reset-small): 2,447 (+19%)
protocol_circuit_witness_generation_time_in_ms (public-kernel-teardown): 203 (-34%)
protocol_circuit_witness_generation_time_in_ms (merge-rollup): 38.6 (-77%)
protocol_circuit_size_in_gates (public-kernel-tail): 512 (+100%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256
5,694
1,549
710
756 (-3%)
769 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
772
772
772

l1_rollup_calldata_gas
6,868
6,868
6,880

l1_rollup_execution_gas
587,408
587,408
587,420

l2_block_processing_time_in_ms
1,370 (+1%)
5,117
10,249 (+1%)

l2_block_building_time_in_ms
32,436 (-1%)
128,684
256,334

l2_block_rollup_simulation_time_in_ms
32,264 (-1%)
128,035
255,057

l2_block_public_tx_process_time_in_ms
16,850 (-1%)
69,981
143,259

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,249 (+1%)
28,524 (+1%)

node_database_size_in_bytes
21,229,648
37,871,696

pxe_database_size_in_bytes
29,868
12,535

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.1 (+1%)
18.0
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.643 (+1%)
0.552
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
52.0
81.4
264
503
997
1,982 (+1%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.532
0.502
0.479
0.470
0.471
0.473 (+1%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
62.0
120 (+1%)
380
740
1,482
2,970 (+1%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.540
0.539 (+1%)
0.516 (+1%)
0.509
0.512
0.516 (+1%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.4

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
108

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.591

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
84,613
664,966

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
29,119 (-2%)
4,273 (+1%)
134,623 (+1%)

Metric
0 public data writes
1 public data writes
2 public data writes
3 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
1,298 (-3%)
2,240 (+1%)
1,491
3,965 (+1%)
1,656 (-1%)
1,951 (-2%)

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256
5,688
1,549 (+3%)
709
743 (-2%)
769 (+1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
1,412
1,412
1,412

l1_rollup_calldata_gas
9,464
9,452
9,452

l1_rollup_execution_gas
616,105
616,093
616,093

l2_block_processing_time_in_ms
1,354 (-1%)
5,076 (-1%)
10,067

l2_block_building_time_in_ms
46,585
184,914
368,487

l2_block_rollup_simulation_time_in_ms
46,419
184,281
367,237

l2_block_public_tx_process_time_in_ms
24,852
104,052
212,186

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
10,096 (+1%)
15,289

node_database_size_in_bytes
14,516,304
21,352,528

pxe_database_size_in_bytes
18,071
29,868

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit
protocol_circuit_simulation_time_in_ms
protocol_circuit_witness_generation_time_in_ms
protocol_circuit_proving_time_in_ms
protocol_circuit_input_size_in_bytes
protocol_circuit_output_size_in_bytes
protocol_circuit_proof_size_in_bytes
protocol_circuit_num_public_inputs
protocol_circuit_size_in_gates

private-kernel-init
160
3,627
22,150
19,990
61,798
86,720
2,643
1,048,576

private-kernel-inner
608 (+1%)
4,193
48,854
88,862
61,798
86,720
2,643
2,097,152

private-kernel-tail
533 (+1%)
2,829
35,258
86,653
76,438
10,624
265
2,097,152

base-parity
6.51 (-1%)
1,339 (+8%)
2,903
128
64.0
2,208
2.00
131,072

root-parity
49.8
52.0 (-22%)
43,773
27,084
64.0
2,720
18.0
2,097,152

base-rollup
756
2,320 (+1%)
74,211
119,578
756
3,648
47.0
4,194,304

root-rollup
115 (+1%)
66.6 (-1%)
19,090 (-2%)
25,297
620
3,456
41.0
1,048,576

public-kernel-app-logic
525
2,847 (-1%)
47,617
103,405
84,766
116,832
3,584
2,097,152

public-kernel-tail
1,192
26,120 (+9%)
154,306 (-1%)
393,850
7,490
10,624
265
8,388,608

private-kernel-reset-small
583 (+1%)
2,311 (+2%)
24,584 (-1%)
118,173
61,798
86,720
2,643
1,048,576

merge-rollup
29.3 (+2%)
N/A
N/A
16,534
756
N/A
N/A
N/A

public-kernel-setup
628 (-1%)
N/A
N/A
103,405
84,766
N/A
N/A
N/A

public-kernel-teardown
530 (-1%)
N/A
N/A
103,405
84,766
N/A
N/A
N/A

private-kernel-tail-to-public
N/A
9,521 (-3%)
81,374
N/A
N/A
116,832
3,584
4,194,304

Stats on running time collected for app circuits

Function
app_circuit_proof_size_in_bytes
app_circuit_proving_time_in_ms
app_circuit_size_in_gates
app_circuit_num_public_inputs

SchnorrAccount:entrypoint
16,128
45,925
2,097,152
437

Token:transfer
16,128
42,720 (-1%)
2,097,152
437

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
11.3
18.5 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.658
0.567 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
52.4 (-1%)
80.7 (-1%)
261
505
987 (-1%)
1,953
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.534
0.498 (-1%)
0.474
0.472
0.468
0.467
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
62.5
119
377 (-1%)
743
1,470 (-1%)
2,922
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.543
0.535
0.512
0.511
0.509 (-1%)
0.508
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.0

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
107

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.594

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
82,705
664,768

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
11,095
4,299 (+2%)
69,697

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
3,217
2,129
6,072 (-1%)
2,307 (-1%)
2,605


Make generic run-scripts

There are lots of runscripts that are almost identical. Work on a more data driven approach.
Also, the config file in this project should be split up into two:
One which is about real configuration - i.e. things that don't change often such as MyTimeStep or Cellsize or quantities.
Another one which is 'per run' and 'per user'

Yes that sounds like a really good idea. Even the storms durations and
blockage do not change. So a script that just looks to see what is
available and then processes whats there and skips what's not there.
On Mon, 24 May 2021, 10:14 Ole Nielsen, @.***> wrote:

There are lots of runscripts that are almost identical. Work on a more
data driven approach.
Also, the config file in this project should be split up into two:
One which is about real configuration - i.e. things that don't change
often such as MyTimeStep or Cellsize or quantities.
Another one which is 'per run' and 'per user'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/uniomni/PyARR/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AETRNNQSMMESDC4K6TECJBTTPGK65ANCNFSM45MHFKKA
.

I have some ideas of how to implement this... lets chat.... (As once a full generic script is completed... the ability to run ANUGA through things like QGIS become far easier to manage I think)...


Calling out usage limitations

RepositionThemeTransition is not supported in ListView, it was designed for use with non virtualizing panels like StackPanel.
ListView relies on AddDeleteThemeTransition for not only add (fade in) and delete (fade out) but also reposition of items when they move due to a collection change. It's expected they clash when both are used together.

@micahl,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


package development updates

@jennybc I'd appreciate any feedback or guidance, or if you want to tag anyone else in.
This is a very rough draft of changes. So far what's been changed from the original:
-discussed adding more of a Package Structure/Overview/Workflow section and then breaking off into the specific components of a package
-made sure usethis vs devtools functions are correctly labeled
-I started updating workflows based on the book, but I know the book is also in progress
Also, on the repo for the book I saw the Big Picture issue. Is there anything that's not yet in the book to try to add? For example I mention pkgdown under documentation and I added a link to happygitwithr.com but should that be done differently? I also saw something about README and NEWS.
(I messed something up in making this pull request and so data-import is also in the files changed, sorry about that, please ignore, I'll fix all of this once there's a more final draft)

I'm going to do my usual incremental review. Warning: some of this feedback is rather high-level and won't be immediately easy to act on. But if we're going to update this cheat sheet, we shouldn't restrict ourselves to small tweaks if bigger changes are necessary.

How to talk about devtools vs. usethis. The party line is that we really want people to focus on devtools as the "storefront" of this functionality for interactive use (even though devtools is now exposing functionality that is maintained in other packages):
https://r-pkgs.org/setup.html#setup-usage
Therefore, I'm not sure that usethis should be featured so prominently. We definitely don't want people to fixate on whether a function is in devtools or usethis (or pkgload or whatever)! devtools depends on usethis, which means attaching devtools also attaches usethis. After library(devtools), every exported function in usethis can be called directly.
Some ideas:

The devtools hex should remain the most prominent and maybe it gets surround by mini-hexes, suggesting other  packages? Are those just anonymous hexes or mini versions of the other packages' real hexes? Or maybe usethis's hex is there, smaller than devtools, but bigger than the others?
library(devtools) should be featured early and then, if possible, no other calls are namespaced. It would be interesting / nice to not burden the reader with devtools::this() vs usethis::that(). After library(devtools), you can just call this() or that().

I'm back at this today. It occurs to me this cheatsheet might need more extensive changes than others, so it might make sense for you to work on it by first working up various "bits", without constantly forcing everything to fit neatly into 2 pages, to explore new ideas. Then whittle it back down after more decisions have been made.

I'm very keen on the idea of talking about setup and initialization vs. workflow and maintenance. Let's help people figure out which things you do once per package (e.g., create_package(), use_testthat()) vs. periodically during development (e.g., use_package(), use_import_from()) vs. every few minutes or hours (e.g. load_all(), document()).
I propose this be an underlying principle of the cheatsheet. Not sure how explicit it will or can be for a user, but I think it's a helpful mindset while selecting and presenting content.

setup and initialization vs. workflow and maintenance

Keenly following this convo, and I think this is a clutch separation, esp. because I think the former is where folks (including me) use a lot of usethis for non-package projects.

I also think parallelism will be a helpful guiding principle, especially combined with the point above re: initialization vs. maintenance.
Currently there are quite a few instances of non-parallel things appearing together in a way that could be confusing. For example document() is not similar to use_testthat() (in the CREATE A PACKAGE section). document() gets run repeatedly, whereas use_testthat() is executed once.

Proposal for how to tackle this one:
I suggest stepping away from a 2-page, aesthetically pleasing Keynote file and working in .Rmd for a while, which is much easier to collaborate on.
Create a major heading for the 7 most significant parts of a package. Then give each of them a parallel treatment. Something like:

Name of file or directory (DESCRIPTION, R/, tests/, etc.)
Tagline (SETUP, WRITE CODE, TEST, etc)
Description: a sentence or two with more detail about this package part.
How initial setup works.
How periodic maintenance happens.
How daily workflow looks.
Other info (an example, a table, a list, links to external resources, etc.).

Not every bullet point will be relevant to each part, nor does this structure work equally well for each part. But I think it's a useful way to marshal relevant content and organize the revision. Populate the .Rmd to start by transferring what's in the existing cheatsheet. Then reflect on that, start to fill gaps, etc.
I see lots of little tweaks that need to be made, i.e. where outdated advice is being given, but it makes no sense to start pointing these out now, nor to do so with respect to a Keynote doc or PDF.
If you take my suggestion, I realize this might mean this cheatsheet doesn't get finished before you internship ends, but you could lay the foundation for the revision. Maybe discuss this approach with @mine-cetinkaya-rundel and/or @garrettgman.

@jennybc How up to date are most of the workflows in the book draft that's up now? Is it worth trying to go through and add to sections with info from the book? Or focus on moving the current cheat sheet info into an .Rmd file and working from there?
I can start working on an .Rmd file now and put it up here as a pull request if that works for feedback.

I recommend on first transferring current info from cheatsheet to the working .Rmd.
Basically the first "part" of R Packages has been revised, whereas most individual chapters about, e.g. testing, man/help, NAMESPACE, etc. have not yet been revised.

I made an .Rmd file and moved it to #188, thank you again for your feedback!


Fix Git version code

🚀 Description
The SemVer library treats Git hashes as valid semantic versions when the short hash only contains digits. This is wrong for this plugin. The version is now checked against official regex
Bumped

SemVer 1.1.1 -> 1.2.0
jGit <IP_ADDRESS>209071007-r -> <IP_ADDRESS>211300538-r

📦 Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

✅ Checklist

[x] My code follows the code style and naming conventions of this project.
[x] I have updated the documentation (if appropriate).
[x] I have updated the changelog accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

:+1:


Fix travis config file and fix incorrect js bundle path

Travis is still wrongly configured. Replace the deprecated phantomjs with phantomjs-prebuilt first before submitting a new pull request.


Form feed replacement is making our JSON invalid and causing a 422 error

When sending this HTML email using the latest version of this library, the API will consistently return a 422 Unprocessable Entity error response:
<!DOCTYPE html>
<html>
    <head>
        <style>
            .foo {
                content: "\f00c";
                font-family: "Font Awesome 5 Pro";
            }
        </style>
    </head>
    <body>
        bar
    </body>
</html>

It seems the JSON is being garbled by a string replace in the library, just before it's sent to the SparkPost API.
// Valid JSON, before string modification
{"content":{"from":{"name":"Foo Bar","email":"foo@bar.com"},"subject":"Test email","html":"<!DOCTYPE html>\n<html>\n    <head>\n        <style>\n            .foo {\n                content: \"\\f00c\";\n                font-family: \"Font Awesome 5 Pro\";\n            }\n        <\/style>\n    <\/head>\n    <body>\n        bar\n    <\/body>\n<\/html>","text":"Test subject","headers":null},"options":{"open_tracking":true,"click_tracking":true,"transactional":true,"ip_pool":"medium"},"recipients":[{"address":{"name":"Foo Bar","email":"foo@bar.com"}}],"metadata":null}

// Invalid JSON, after string modification
{"content":{"from":{"name":"Foo Bar","email":"foo@bar.com"},"subject":"Test email","html":"<!DOCTYPE html>\n<html>\n    <head>\n        <style>\n            .foo {\n                content: \"\00c\";\n                font-family: \"Font Awesome 5 Pro\";\n            }\n        <\/style>\n    <\/head>\n    <body>\n        bar\n    <\/body>\n<\/html>","text":"Test subject","headers":null},"options":{"open_tracking":true,"click_tracking":true,"transactional":true,"ip_pool":"medium"},"recipients":[{"address":{"name":"Foo Bar","email":"foo@bar.com"}}],"metadata":null}

If we remove the string replace the email goes through OK. I understand that this is in place to protect against form feeds from being sent to the SparkPost API, but in our case this is valid HTML (not a form feed character) and the SparkPost API has no issue with it. In our case, the library is replacing good JSON with bad.

Hi @jonathanbull I've been looking at this to try and help you on my own initiative, but am struggling to get even a simple app to run in order to verify the change.
The standard README install instructions gave dependency errors on Guzzle6, so based on a comment here I'm using
composer require php-http/guzzle6-adapter "^1.1"
composer require guzzlehttp/guzzle "^6.0"
composer require sparkpost/sparkpost

and can build a simple mail sending app to reproduce what you're seeing. Unfortunately this runs, creates the SparkPost object, then gives
Exception has occurred.
Http\Discovery\Exception\PuliUnavailableException: Puli Factory is not available

Can you please share more info on your setup? As you can see, this library is not getting regular maintenance.

Glad you were able to figure out those Guzzle issues @tuck1s. We've been doing some more testing on our end and came to the conclusion as you – the SparkPost API seems to accept form feed characters just fine!

Thanks! Just waiting for reviewers to OK, then I'll merge #198. There are a few other issues in the repo (Travis CI etc) which we should fix but in a separate PR.

Merged. 2.2.1 release done.

Thank you for the quick turnaround @tuck1s


Highlight rectangle in the About dialog is not clipped outside the ItemList

Operating system or device - Godot version: v3.0.alpha.custom_build a7d1c90
Issue description:

If you select a section in the about window in the editor it gets highlighted. If you scroll up or down then that highlight does not respect the window boundaries.

Steps to reproduce:
Open about window, select a section and scroll around 😄

cc @Noshyaar

I think it's the bug with ScrollContainer not clipping highlight correctly. I've tried to replicate the scene in CanvasItemEditor and the issue is there. It probably affects every controls with highlight, not only ItemList.

This is the lines that cause the issue:
https://github.com/godotengine/godot/blob/master/scene/gui/rich_text_label.cpp#L647
https://github.com/godotengine/godot/blob/master/scene/gui/item_list.cpp#L775
https://github.com/godotengine/godot/blob/master/scene/gui/tree.cpp#L2816
Deleting it works for 3.0 editor theme and About dialog, but not for default project theme. (control's own clip makes the rectangle too thin)

Reopening as the PR was reverted.

This is "Fixed" in EditorAbout by not showing the outline at all, but the issue still exists.

Too difficult to work around, kicking to 3.2 since most of this code will be re-written

I've been hit with this issue too and, yes, a good fix is too difficult. The main issue is that when you enable clip_contents (and ItemList enables it by default) anything outside of the control's size will be clipped. This affects the whole control including the applied StyleBoxes that can add an extra margin around them. The only solution I can think of is to have 2 rects, one keeping the size of the control and the other keeping the size of the styleboxes and draw the control first with the stlyeboxes without clipping and then the content with it clipped to the control size. I don't know how could we do this.
In the meantime, because this is a bigger issue that affects all controls (well, CanvasItems because they are the one in charge of drawing the styleboxes), I think we can remove the exception in the ItemList for now because it's making it unusable right now if you apply any focused StyleBox to it and it gets clipped by another control.

This issues seem to have reappeared a lot more prominently in master, as I think it's the same as https://github.com/godotengine/godot/issues/36164.

Duplicate of #36164 indeed.


environmentAdmin role does not work

Rancher versions:
rancher/server: 1.5.9
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Create a stack with:
version: '2'
services:
  hello:
    image: tutum/hello-world
    labels:
      io.rancher.container.agent.role: environmentAdmin
      io.rancher.container.create_agent: 'true'

Log in to the container and use the CATTLE_AGENT_INSTANCE_AUTH:
$ curl -s -H "Authorization: ${CATTLE_AGENT_INSTANCE_AUTH}" "${CATTLE_CONFIG_U
RL}/certificates"

Results:
The API returns "not found":
{"id":"eb303c48-70c1-4928-8241-47b706b76a05","type":"error","links":{},"actions"
:{},"status":404,"code":"Not Found","message":"Not Found","detail":null,"baseTyp
e":"error"}

Note: the environment role provides working keys, but no access to certificate private keys, which is what we want.

From reading https://github.com/rancher/cattle/blob/master/code/iaas/agent-instance/src/main/java/io/cattle/platform/agent/instance/factory/impl/AgentInstanceFactoryImpl.java#L171, it appears that the container must either be in a system stack or be a load balancer.
Indeed, setting the stack as system does solve that issue. Could this be documented somewhere maybe?

The link above is broken. What do you mean, "set stack as system". Is this in an option in rancher? I don't see it. Were you ever able to get the cert private key in your container from the rancher cert store?


Remove duplicate annotation for multi-transcript genes

When an annotation is the same on more than one transcript only display it once.
Moved from #1613 and pombase/canto#2495

The duplicates annotations are now hidden.  Now that's done I'm working on #1797


mpd: big delays when updating

After changing MPD status, Waybar updates the module only after 1-2 seconds. This is not a problem with MPD because mpc idleloop gives information without any delays. Logs don't show anything.
Waybar version: freshly built from git, but also reproduces on 0.9.4-5 from Arch repos

Just as a note, this bug bisects to 8f961ac3976048d7a389d77737d9694f26fe863d

I would like to add to this: If for whatever reason the mpd server is not available waybar goes unresponsive. I was trying to wrap my head around why it lagged so badly, maybe lowering the connection attempts would help.

I would like to add to this: If for whatever reason the mpd server is not available waybar goes unresponsive.

I'm not sure why that would happen, on cf5db8f6631e4d165d52479a153e3792108edef7 it seems to work fine when the server is not available. I haven't tried later versions


[Help Wanted] SQLite3 version and .Net requirement.

I was wondering if someone could answer the following questions for me, as I haven't been able to find the information elsewhere;
What version of sqlite is 1.5.231 built against?
Can I isolate a previous (stable) release of sqlite-net that only requires .NET 3.5? i.e. Prior to the introduction of the Tuple and TypeInfo classes, as well as the null propagating operator.
Would I be able to find out what version of sqlite like the above release was built against?
I might not be understanding the relationship between sqlite-net and the sqlite libraries, so please correct me if i'm asking the wrong questions here.

From what I can gather, SQLite-Net (this library) uses SQLitePCL.Raw as provider for platform-specific SQLite. If you use default batteries (DLLs that work with SQLitePCL.raw) from SQLitePCLRaw.bundle_green, you get e_sqlite3 on .NET Framework 3.5.
If you want to reference SQLite-Net code-only (without referencing any implicit provider), you can NuGet SQLite-Net-Base. You might want to do this when experimenting/debugging with different providers, or writing a .NET Standard library for multiple platforms. However without referencing a provider in the final app (and adding necessary *Init()*s), your app will likely crash due to some DLLNotFound exception.

I'm afraid that the meaning for the original question wasn't meant to dig too deep. Unfortunately I had forgotten about the post due to no getting any answers.
In the end I used LibVersionNumber to find the SQLite library version number.


Skip the uploadtwice02 test on non-Windows systems

Since os.unlink() is non-blocking on Linux and macOS, uploadtwice02 may hinder contributions from developers on non-Windows platforms.

Would it make more sense to fix the test instead of skipping it? There must be a reason the test_uploadtwice02_upload_a_file_twice_with_error exists in the first place.  I did not understand the os.unlink() reference. Did you mean that reserve_file_for_while does not reserve the file on linux? Or something else?
And I fully support making contributions easier. As I just commented on the another PR, I feel that setting up the dev env is a bit difficult. If we can make the instructions easier to follow, that would be great!

Hi @mapix , I took another look. Now I see why there was such a test in the first place. I did some changes and pushed them to a separate PR https://github.com/fohrloop/dash-uploader/pull/140. Closing this one.


Backport link integrity improvements and References and Links menu to 16.x

/cc @plone/volto-team I will merge this in the upcoming days. If someone has any problem with it, please state it so we can discuss it. Please notice that this do not backport the relations control panel. This will remain to be a Volto > 16 feature.
Ordinarily, the current policy is not to backport to LTS any feature, but this one proved to be important enough to make it there. In fact, it was already implemented with a feature flag, so we could backport it to 16 at some point. It didn't happen until now. The feature flag will be opt-in in 16 so no disruption in sites will happen.

@davisagli done.


please ionic5 update

not working ionic 5 :( gesture problem

private initSwipeGesture(): void {
    this._swipeGesture = new Gesture(this.el.nativeElement, {
        recognizers: [
            [Hammer.Swipe, {direction: Hammer.DIRECTION_VERTICAL}]
        ]
    });
    this._swipeGesture.listen();
    this._swipeGesture.on('swipedown', e => this.onSwipe(e));
}

new Gesture error

sir please :(


Fix for Notabene's selfie mode

Purpose
Fixing an issue where the "live broadcasting" camera mode was dismissing the "Onfido/Notabene" selfie frame.
Changes
Toggled the settings below of IdentityProviderWebViewViewController 's WebView .

Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG.

Tested in CCD app 1.2.31, iPhone11, iOS 15.1.

NB: Live mode with oval works; id is issued successfully. Tested with passport and driver's license.
NB: Switch to basic mode works; id is issued successfully. Tested with passport.
DTS: Flow unchanged, id issued successfully. Tested with passport.


Questions about adjusting camera intrinsics in data augmentation

Thanks for the implementation of your awesome work.
I have a question about why the camera intrinsics of center crop is designed in this way.
In your code, I think you only adjusted the focal length according to the size change by cropping, but why not consider the change in principal points and the scaling factor by rescale?

See #58. Also note that the Gaussian Splatting rasterizer only supports principal points at image centers.


Virtual sound card  has a little noise

I installed the virtual machine sound card in the virtual machine equipped with windows7 system, and used the IVSHMEM  to conduct sound test. Everything was normal, but occasionally there was a little noise.This is a real headache. I wonder what all about.
Thank you so much.

Is it crackling/popping noises?

I try to find the source of the noise. Finally, I recognized the noise coming from the motherboard. The background noise is stable and not relative to the volume. When nothing input, the ALSA turns hardware output off, and the background noise disappears. Any input with volume equals 0 will turn hardware output on, and the electronic background noise appears.
Here I recorded the output of ALSA with two cases. Case 1: scream or any input with volume equals 0. Case 2: no input and  only recording. In case2, the noises only appeared when the recording existed.


Create Template - no automatic reload

As a User
I want see the added templates right away
so that I can see what I've added
Acceptance Criteria
Scenario 1:
GIVEN Template tab is open and I filled in Tab's all required fileds
WHEN I pressed 'Add' Button
THEN see the new created template in the grid
Current view for a newly added template "Test Template" - need to manually reload to see it
Private Zenhub Image

this bug is still active. I get the notification that a template has been added, but it's still not appearing in the list.
Is there a way to just force a reload of the grid component?


Real Life Time Value

What is your question?
Is there a possible way I can get the real time in the current time zone I am in?
What is your Psych Engine version?
0.6.3
What Is This Going To Be Used For?
Custom Text Value During Every Song.

os.date

os.date

Like I Meant In Hours:Minutes AM/PM, and in LUA script

os.date

Like I Meant In Hours:Minutes AM/PM, and in LUA script

Nvm Figured It Out On The Wiki Thx


#expect does not show output for try expression

Description
Motivation
The original logic is a 3 step computation.
However I'd like to test multi instance and name the instance with number make me sad. So I compress the steps into one throwing function.
But then the #expect macro won't show the output for the left expression with try.
let instance1 = step1(1)
let instance1Data = try step2(instance1)
let instance1String = step3(instance1Data)
#expect(instance1String == "1")

let instance2 = step1(2)
let instance2Data = try step2(instance2)
let instance2String = step3(instance2Data)
#expect(instance2String == "2")

...

⬇
func helper(_ input: Int) throws -> String {
  let instance = step1(input)
  let data = try step2(instance)
  return step3(data)
}

#expect(try helper(1) == "1")
#expect(try helper(2) == "2")
...

Reproduce
A simplified version to demonstrate the issue
enum MultiError: Error {
    case invalidInput
}

func multi(_ a: Int, _ b: Int) throws -> Int {
    guard a > 0, b > 0 else {
        throw MultiError.invalidInput
    }
    return a * b
}

func multiWithoutThrow(_ a: Int, _ b: Int) -> Int {
    return a * b
}

@Test func example() async throws {
    #expect(try multi(1, 2) == 3)
    #expect(multiWithoutThrow(1, 2) == 3)
}

Expected behavior
Expectation failed: (try multi(1, 2) → 2) == 3
Expectation failed: (multiWithoutThrow(1, 2) → 2) == 3

Actual behavior
Expectation failed: try multi(1, 2) == 3
Expectation failed: (multiWithoutThrow(1, 2) → 2) == 3

Steps to reproduce
See code snippet above
swift-testing version/commit hash
Xcode 16.0
Swift & OS version (output of swift --version ; uname -a)
No response

A temporary workaround is change it from #expect(try multi(1, 2) == 3) to #expect((try multi(1, 2)) == 3)
Then we'll get the expected result.
Expectation failed: ((try multi(1, 2)) → 2) == 3

Duplicate of #162


Wallet_Story

Users and Roles tables created

Role to be used for future filter of endpoints

Constraints validation added via Spring Security

UserRegistrationDTO added for future login page implementation

Login page of Spring Security disabled in Main method

MapperUtil class added for mapping between single Entity or List and DTO

config.DataInitializer class added for test purposes

Docker Postgress connection added to application.yml, that needs to be unified since its my personal settings

Added Wallet table

Added User, Role, Wallet DAO and service layers

Added User and Wallet endpoints

User and Wallets delete strategy -> Soft Delete

Wallet Endpoints:

get all wallets of userId

get wallet by walletId (as of now - there is no list of transactions for selected wallet, just wallet details itself)

delete wallet by walletId

If deleted wallet is default -> user is asked to choose another default before deletion

PUT - create new wallet or update (e.g. change name or "default" status).

If new created wallet is "default", previous default wallet is marked default=false
-- if this is first wallet for user -> it is marked as default=true despite the selection made by user

Remarks:

Should the wallet name be unique for each user? I think different users can have same name for the wallets (in general, if we are talking about the whole program), but within the same user each wallet name should be unique
Didnt touch transactions within the wallet, should we wait for "categories and transactions story"?
Didn't touch (page 2, table "Details", paragraph 4 Currency) >>"Lazy loading currency when user select the option “show more”<<, kindly advise if any specific implementation is required

no longer applicable, must be re-done


[BUG] Enchanter: No xp consumed on shift-click

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
If a user shift-click's on the enchanted book, no levels are removed from the player.
Expected Behavior
When grabbing the enchanted book, a users xp should decrease by the required enchant amount.
Steps To Reproduce

Open the enchanter and perform a recipe as usual
When grabbing the final enchanted product, use shift + left-click to grab the enchanted book
No levels should have been consumed from the player

Environment
- Client OS: Windows 11
- Server OS: Ubuntu 22.04.2 LTS
- Client Java version: 8 update 241
- Server Java version: 17.0.7+7
- Minecraft version: 1.20.1
- Forge version: 1.20.1-47.1.3
- Version: 6.0.7-alpha

Anything else?
This was done a multiplayer self-hosted server

Steps to reproduce: put ingredients into Ender IO Enchanter. Shift-click the book from the output slot. You get the book but the ingredients are not consumed nor is the required xp. Removing and replacing the book and quill allows this to be repeated very quickly

https://github.com/AllTheMods/ATM-9/issues/119

https://github.com/AllTheMods/ATM-9/issues/163

Taking a look at this now


Enhance sigstore Docs Tasks List

Description

As I get familiar with the sigstore project and its community, I am keeping a friction log of any obstacles, challenges, or inconsistencies I encounter. This log will help me identify pain points in the onboarding process and suggest improvements.

[ ] Improve the About section of sigstore subprojects

Add a documentation website link in the Website field of sigstore subprojects
Outcome: This will make the project documentation easily accessible
Update description
Outcome: This will let people who are looking at the project for the first time get a quick idea of the purpose of the project
Add topics
Outcome: This will improve the discovery of the project on github
Repositories to update:

https://github.com/sigstore/cosign
https://github.com/sigstore/fulcio
https://github.com/sigstore/rekor
https://github.com/sigstore/policy-controller

[ ]  Update How sigstore works in Docs
Looking from the perspective of a new user at the project: How sigstore works is explained in a better way in https://www.sigstore.dev/how-it-works with diagrams and considering different user perspectives than in https://docs.sigstore.dev/#how-sigstore-works
We can link to it on the documentation website under How Sigstore works and remove the duplicate information from https://docs.sigstore.dev/#how-sigstore-works

[ ] Use consistent naming to refer to sigstore
I see multiple instances where sigstore is capitalised, though it is instructed otherwise in https://docs.sigstore.dev/contributing/#website-content. Identify and update all pages to use the same nomenclature.

[ ] Improve visibility about the project Sigstore and Programming Language Communities and Resources for Learning More

Move this information from  History and Research to https://docs.sigstore.dev/ for better visibility to new users
Add Securing Your Software Supply Chain with Sigstore Course to Resources for Learning More

[ ] Reorganize the docs into the four categories to make them more organized and discoverable for beginners and experienced users, namely:

Tutorials

How-Tos

Reference Guide

Explanations

Ref: https://documentation.divio.com/

I am willing to help the community in improving the consistency and readability of documentation and work on the aforementioned points. I would highly appreciate any thoughts and feedback from @ltagliaferri and other community members on this.

I'll give feedback on each task

Improve the About section of sigstore subprojects — you can go ahead with this
Update How sigstore works in Docs — the docs are more developer-oriented than the marketing website (more general public oriented). I would not change this at this time, but we can add policy-controller
Use consistent naming to refer to sigstore — we are using "Sigstore" now (we need updated style guides), so there can be consistency towards the title case
Improve visibility about the project Sigstore and Programming Language Communities and Resources for Learning More — I don't think we should move history and research to the home page, if that's what you meant? The Linux Foundation course is not considered part of the Sigstore community so I would avoid including that here right now.
Reorganize the docs into the four categories to make them more organized and discoverable for beginners and experienced users, namely: — Let's not reorganize based on genre of doc, the organization based on project makes sense to me

@ltagliaferri sorry if I could not get my point across. Only the organisation owners have permission to edit the About section of a repository (indicated by a gear icon around beside About around the top right corner of a repository), so I am unable to do that on behalf of Sigstore.

we are using "Sigstore" now (we need updated style guides), so there can be consistency towards the title case

I'll make a PR to update the outdated style guide on branded terms.


Fix error when serializing objects with circular referencing

When trying to serialize an object like this
const subObject: { sub1: string, sub2: any } = { sub1: 'subObjectValue', sub2: undefined }
const givenObject = { root1: 'some value', root2: subObject };
subObject.sub2 = givenObject;

one will get an error like this
    TypeError: Converting circular structure to JSON
        --> starting at object with constructor 'Object'
        |     property 'b' -> object with constructor 'Object'
        --- property 'd' closes the circle
        at JSON.stringify (<anonymous>)

This PR fixes this behavior. A "flattened" output can be seen in the added unit test.

Hey thank you for opening the PR!
Sorry to ask for this change, but since recently this was addressed on React Native, could you also use the way it was solved on React Native?
Basically copy the normalise to util/normalise
https://github.com/getsentry/sentry-react-native/blob/9ee4637908664fd8c5c34d592589352f6112e102/src/js/utils/normalize.ts
and instead of calling JSON.stringify(value);
Additionally, we could also add the tests that were used here:
https://github.com/getsentry/sentry-react-native/blob/9ee4637908664fd8c5c34d592589352f6112e102/test/utils/normalize.test.ts

@lucas-zimerman Not entirely sure if i covered all areas. But I have updated it accordingly to the RN solution


Controlling operation drop down in Datadog APM

Related Problems?
Reference: https://github.com/open-telemetry/opentelemetry-rust-contrib/blob/main/opentelemetry-datadog/src/exporter/mod.rs#L312C14-L312C35
I'm unsure if this is a feature request or lack of documentation/examples that show this, but I'm trying to control the operation that's passed on Datadog APM. It appears that this value is always static and not configurable, but it is a field that's meant to be configurable from a Datadog APM perspective. As an example, if you auto instrument a Java webservice with the trace agent you'll end up with multiple operations, some examples are servlet.request, redis, grpc.client, etc. I'm interested in configuring something similar to that from this rust library.
What component are you working with?
opentelemetry-datadog
Describe the solution you'd like:
Controllable, or instructions on how to control, the operation field.
Considered Alternatives
No response
Additional Context
No response

Hi
It's tricky, because require deep dive into source code and docs of tracing, tracing_subscriber, tracing_opentelemetry and  opentelemetry crates. For my case tracing -> tracing_subscriber -> tracing_opentelemetry -> opentelemetry -> opentelemetry_datadog I use traces like this:
tracing::info_span!("any name", operation = "kafka.consume", otel.name = "my.awesome.topic", span.kind = "consumer", ...);

and overrides for operation name in builder:
    .with_name_mapping(|span, _| {
        span
            .attributes
            .iter()
            .find(|k| k.key.as_str() == "operation")
            .and_then(|kv| match &kv.value {
                Value::String(v) => Some(v.as_str()),
                _ => None,
            })
            .unwrap_or("fallback_operation_name")
    })

and overrides for resource name:
    .with_resource_mapping(|span, _| &span.name)

In result I have traces in APM with operation - kafka.consume, kind - CONSUMER and resource name - my.awesome.topic.
You also may pass error status and message: https://docs.rs/tracing-opentelemetry/latest/tracing_opentelemetry/

Thank you! I'll try to make use of this and test the results.


Agents, Deployments and Models API and initial data seeder

Agents, Deployments and Models API implementation and initial data seeder
AI Description

This PR introduces a new deployment feature and makes changes to the agent and model management.
Summary

Added new database tables for deployments, models, and agent-deployment associations.
Implemented CRUD operations for deployments and models.
Updated agent management to include deployment and model associations.
Added new API endpoints for managing deployments and models.
Modified existing code to utilize the new deployment and model features.

Changes

Database Models:

Added new database models for Deployment, Model, and AgentDeploymentModelAssociation.
Modified the Agent model to include relationships with deployments and models.

CRUD Operations:

Added new functions for creating, updating, retrieving, and deleting deployments and models.

Agent Management:

Updated the agent creation and update functions to include deployment and model associations.
Added functions to assign and retrieve deployment and model associations for agents.

API Endpoints:

Created new API endpoints for managing deployments and models.
Modified existing API endpoints to include deployment and model information.

Code Modifications:

Updated existing code to utilize the new deployment and model features.
Modified the Agent model to include deployment and model information.

Codecov Report
Attention: Patch coverage is 92.45902% with 92 lines in your changes missing coverage. Please review.

Project coverage is 82.75%. Comparing base (9125660) to head (0157a4c).
Report is 19 commits behind head on main.

Files
Patch %
Lines

src/backend/routers/agent.py
63.93%
22 Missing :warning:

src/backend/database_models/tool.py
0.00%
15 Missing :warning:

src/backend/database_models/agent.py
79.48%
8 Missing :warning:

src/backend/routers/deployment.py
79.48%
8 Missing :warning:

.../database_models/seeders/deplyments_models_seed.py
84.44%
7 Missing :warning:

src/backend/alembic/versions/3db4a6321b7a_.py
71.42%
6 Missing :warning:

src/backend/services/request_validators.py
87.23%
6 Missing :warning:

src/backend/services/chat.py
66.66%
5 Missing :warning:

src/backend/tests/routers/test_agent.py
91.66%
4 Missing :warning:

src/backend/tests/conftest.py
84.21%
3 Missing :warning:

... and 5 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   86.46%   82.75%   -3.72%
==========================================
  Files         178      214      +36
  Lines        6873     9225    +2352
==========================================
+ Hits         5943     7634    +1691
- Misses        930     1591     +661

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

will the deployment_config dictionary in assign_model_deployment_to_agent be directly stored without any sanitization or a TODO?

Deployment config validation is implemented in the router using validate_deployment_config

validate_deployment_config

here? apologies if i am missing something here

No, deployment config validation is here and here


Sync from codesandbox adoring-smoke

ts.config aliases updated

Same as https://github.com/vercel/next-learn/pull/742


(InvitingGuests) - Activity feedback

'Has invited you to share ...' sounds a bit strange to me. I've been invited to the content item, but I haven't been invited to share it.
"Nicolaas Matthijs has accepted an invitation to add the file "i hate everything.gif" to their library" is currently showing the picture of the user that invited you. However, per the regular activity feed, this should show the content item preview.
We should have a "You" version of invitation accept activities that is used when you are the actor in the activity (i.e. You have accepted Branden Visser's invitation to the group Wiggle). In the main activity feed, we have "You" version as well.

'Has invited you to share ...' sounds a bit strange to me. I've been invited to the content item, but I haven't been invited to share it.

I thought it was strange too, but interpreted it as the user who invited them, was inviting them in order to share with them.
What would you recommend?

We should have a "You" version of invitation accept activities that is used when you are the actor in the activity (i.e. You have accepted Branden Visser's invitation to the group Wiggle). In the main activity feed, we have "You" version as well.

I'll do this for both actor and object. So we would have both:
You have accepted Branden Visser's invitation to the group Wiggle; and
Nicolaas Matthijs has accepted your invitation to the group Wiggle

+1

Fixed in 83227d2..b2e1f3c


Correctly track line numbers for multi-line code blocks

Up till now, exceptions in <% … %> or <%!  … %> code blocks would have their errors reported in the opening line when formatting a stack trace.  With these changes, every line of a code block gets an entry in the line map, which allows attributing them correctly.
Exceptions in <%! … %> blocks which get raised while loading the module are still not reported correctly.  At that time, the metadata infrastructure for exception reporting does not exist yet, so the stack trace will reference to the raw generated code and not get rewritten.

hiya -
this is very interesting.    Please note I haven't looked at Mako's line map stuff in many years, but I appreciate your taking the time to understand it.    Let's see if this PR works in the CI system (more that I don't know when the last time I had a Mako PR, not the PR itself) and see if we can look into this.

New Gerrit review created for change 5832484f2db6fb74005cc45e64380c344dc35a42: https://gerrit.sqlalchemy.org/#/c/sqlalchemy/mako/+/1336

pep8 things.  can you review the pep8 failures and force-push a new commit on top of this one?  I can re-run it then.

Took moe a bit to find the actual output in Gerrit, but eventually I did and fixed issues. Sorry for the round-trip.

Patchset 60ad749604f8de0a9b8133430995045a93d0939c added to existing Gerrit review https://gerrit.sqlalchemy.org/#/c/sqlalchemy/mako/+/1336

this is a great patch thanks for figuring this out!

mike bayer (zzzeek) wrote:
Code-Review+2 Workflow+1

Gerrit review https://gerrit.sqlalchemy.org/1336 has been merged. Congratulations! :)

i can release now since I almost never push anything to mako


add PharmGKB mappings for genes, diseases, variants, and chemicals

To incorporate the PharmGKB API as described in https://github.com/biothings/BioThings_Explorer_TRAPI/issues/556, we need node normalizer to resolve PharmGKB identifiers for genes, diseases, variants, and chemicals. Examples of each:
Gene: BRAF - https://www.pharmgkb.org/gene/PA25408
Disease: leukemia - https://www.pharmgkb.org/disease/PA444750
Variant: rs113488022 - https://www.pharmgkb.org/variant/PA166157522
Chemical: imatinib - https://www.pharmgkb.org/chemical/PA10804
Mappings can be found in the "Primary Data" section of https://www.pharmgkb.org/downloads
Related issue to add prefixes to biolink model: https://github.com/biolink/biolink-model/issues/1236

Note that the prefixes have now been added to Biolink model in https://github.com/biolink/biolink-model/issues/1236, which was probably a prerequisite for this issue.


Enable multi-threading tests (MPI+OpenMP) under CI

I think we are currently we running pure MPI tests under CI. We should run MPI+OpenMP tests to catch any threading errors.

In the CI we build CoreNeuron SoA with OpenMP enabled https://github.com/BlueBrain/CoreNeuron/blob/76026e0b9820d96524ea3dc0e5c1d9f738e1f55a/tests/jenkins/install_coreneuron.sh#L57 and we run the SoA tests with https://github.com/BlueBrain/CoreNeuron/blob/76026e0b9820d96524ea3dc0e5c1d9f738e1f55a/tests/jenkins/run_corenrn.sh#L17. I see though that for some reason when CoreNeuron runs it prints num_omp_thread=1 even if the OMP_NUM_THREADS is set to 2. Maybe that's because we don't run it with --threading? I need to investigate

@iomaganaris : IMO we need a test with more concurrency (more than ring). e.g. If we are using 36 cores on Jenkis CI, using 6 MPI ranks each with 6 threads. This can help to detect race condition. We can discuss this what should/can do.

We have CI builds that enable OpenMP (host) threading: https://github.com/BlueBrain/CoreNeuron/blob/d6507e20ffdcf652b07e231347174f8f9c89e32a/.gitlab-ci.yml#L89 and tests that use multiple threads https://github.com/neuronsimulator/nrn/blob/1b76917231a00281e17bac760d013f9a5c13cd95/test/external/ringtest/CMakeLists.txt#L90-L100, but I'm not sure if this is enough.


OEA_py SALT

I was wondering should we have a function below get_secret in OEA() that gets the SALT from key vault? Something like:
 def getSALT(self):
        self.SALT = self.get_secret('kv-oea-SALT')

Thanks for the suggestion. This issue has been addressed in v0.7 release of the OEA framework. the OEA_py notebook in v0.7 generates a salt value that can be modified if you want to use a specific salt.


Support application cookie stickiness policy for AWS ALB

AWS Application Load Balancers support Application Cookie Stickiness, based on cookie generated by application, instead of auto-generated cookie injected by ALB.
This feature is supported in Terraform provider, but not in pulumi-aws for NodeJS

Affected feature
LoadBalancerCookieStickinessPolicy resource as well as ApplicationTargetGroup stickiness args should support this feature

Isn't this available in Pulumi as https://github.com/pulumi/pulumi-aws/blob/ba7e89d629a5fef8a7ba53ebc013b1b5073807fa/sdk/nodejs/elb/appCookieStickinessPolicy.ts ? Or am I misunderstanding your request?

Sorry for misleading you.
I was referring to do it via alb.createTargetGroup() using ApplicationTargetGroupArgs
In TargetGroupStickiness interface I don't see such option


updated libjav8.so binaries.

updated libjav8.so binaries.  These should eliminate a crash when trying
to resolve double vs. float arguments to methods.
GearVRf-DCO-1.0-Signed-off-by: Tom Flynn
<EMAIL_ADDRESS>

this is for the 3.x maint branch


Fix dev container kinit failed

[dev@dbaf7d0152d0 elliott]$ kinit shiywang
kinit: Invalid UID in persistent keyring name while getting default ccache

@shiywang I can't reproduce with the latest version. Can you check if https://github.com/openshift/elliott/pull/95 fix this?

This is fixed by https://github.com/openshift/elliott/pull/95


ISO 123 query returning 1985 or 1974 version

Instead of latest 2001 version. Need to determine if am weeding out the 2001 version incorrectly.
If we can't guarantee the results prioritise the latest current version, we are in trouble. But the results do seem to be in that order.

Not happening in independent doc, only in rspec.

Oh, crap.
     def fetch_pages(s, n)
        workers = WorkersPool.new n
        workers.worker(&:fetch)
        s.each { |hit| workers << hit }
        workers.end
        workers.result
      end

This isn't preserving the ordering of s, is it.

... Ugh. I'm going to align workers to s above by injecting the hit.title into the generated IsoBibItem::IsoBibliographicItem serialisation. Which should be in there anyway:
[<Isobib::Hit:0x007fbc1ab9e2a8 @text="ISO 123" @fullIdentifier="" @matchedWords=["iso", "123"] @category="standard" @title="ISO 123:2001 Rubber latex -- Sampling">,
 <Isobib::Hit:0x007fbc1ab9e140 @text="ISO 123" @fullIdentifier="" @matchedWords=["iso", "123"] @category="standard" @title="ISO 123:1985 Rubber latex -- Sampling">,
 <Isobib::Hit:0x007fbc1ab9e118 @text="ISO 123" @fullIdentifier="" @matchedWords=["iso", "123"] @category="standard" @title="ISO 123:1974 Rubber latex -- Sampling">]

The full title ISO 123:1974 Rubber latex -- Sampling will be how the HitCollection and the search results are aligned.

No, just putting an ordinal into the worker pool.


Inconsistencies when moving between text fields with TAB

Godot version
4.0 beta1 mono
System information
macOS Monterey 12.4
Issue description
When moving between text fields with TAB the text in the text field is not always editable (focus moves but the cursor doesn't).
Steps to reproduce

Create a new object with Transform, for example Node3D.
Select a text field in the Inspector with mouse, in this example Position's x-field. Note that the focus is in the first field (blue line around it) and the cursor is no visible and it is possible to change the value by using keyboard.
Press TAB.

Expected: The focus should move to the next field, in this example Position's y-field and the cursor should be visible and value editable.
Actual: The focus moves to correct field but the cursor is not visible and it is not possible to edit the value. User has to click the field with mouse to make it editable.
Note: Sometimes the focus (blue line around the field) is moved to the next field but the cursor stays in the first field and it is not possible to move forward to the third field. The behaviour is slightly different depending where the cursor and the focus are when starting the reproduce sequence.
Minimal reproduction project
No response

Duplicate of #37723


The TXT record name needs to be _dnsauth.subdomain instead of subdomain in order to transfer an existing subdomain without downtime

Step 6 of this section says the following about the name of the TXT record to add:
"@ for root domain, or enter the subdomain"
However, if there is already a CNAME record whose name is the subdomain (as is commonly the case when you are trying to transfer an existing subdomain without downtime), this will fail due to the RFC1034 section 3.6.2 which says “If a CNAME RR is present at a node, no other data should be present;”.
We got confirmation from Digicert and verified through testing that the correct name to use for the TXT record is _dnsauth.subdomain , where subdomain is the subdomain (for example, www).
Note: The underscore at the beginning of _dnsauth is correct.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 190b1ed3-0712-2f19-4e8f-a2a8519d136e
Version Independent ID: b02adbf4-d2a8-6c84-e70a-ff59fb3cbb7b
Content: Set up a custom domain in Azure Static Web Apps
Content Source: articles/static-web-apps/custom-domain.md
Service: static-web-apps
GitHub Login: @burkeholland
Microsoft Alias: buhollan

@gabesmsft, Thanks for the feedback! We are taking a look into this and will get back to you soon.

I hit this as well and raised https://github.com/MicrosoftDocs/azure-docs/issues/78957.
Also have verified the fix myself

gabesmsft,  timja , The PR is merged and the document reflects the changes. We will close this thread. Thanks for taking time to share your valuable feedback.

@AjayKumar-MSFT shouldn't https://docs.microsoft.com/en-us/azure/static-web-apps/media/custom-domain/azure-dns-txt.png also be updated as well?


services/horizon: Allow starting Horizon with minimal configuration

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
services/friendbot, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.
[ ] I've updated any docs (developer docs, .md
files, etc... affected by this change). Take a look in the docs folder for a given service,
like this one.

Release planning

[ ] I've updated the relevant CHANGELOG (here for Horizon) if
needed with deprecations, added features, breaking changes, and DB schema changes.
[ ] I've decided if this PR requires a new major/minor version according to
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.

What
This commit adds multiple changes to config parameters:

--ingest is set to true by default,
--captive-core-config-path is generated with default values based on the network passphrase.

If the pubnet Horizon is started without custom config, it will be stopped with an error message after one hour.
Close #3719.
Why
We want to make the time from Horizon installation to execution to be minimal. With less config values and reasonable defaults developers can start Horizon instance faster.
Known limitations
Quorum set default values for public network should be changed to to organisations developer really trust so Horizon will be stopped after one hour if an admin does not provide custom config. However, service managers like systemd may restart the service making it worth permanently.

@jacekn what is your opinion on this:

Quorum set default values for public network should be changed to to organisations developer really trust so Horizon will be stopped after one hour if an admin does not provide custom config. However, service managers like systemd may restart the service making it worth permanently.

@jacekn what is your opinion on this?

Quorum set default values for public network should be changed to to organisations developer really trust so Horizon will be stopped after one hour if an admin does not provide custom config. However, service managers like systemd may restart the service making it worth permanently.

I think having hidden 1h delay after which horizon will stop will be confusing and, like you say, systemd might even hide it from operators making it worse. Personally I have never seen similar behaviour in linux software so I think it would be best to avoid it.
Horizon binary is likely wrong place to store default quorumset too. ubuntu packages we build ship with default configs already so I think it would be better to leverage that mechanism instead. We can do the same with docker images and we'll achieve the same goal. The benefit of doing that using package manager is that it's consistent with other linux software and operators should be familiar with the process. It also means that if quorumset changes are needed there no need to compile and rollout new horizon binary.

I think there's one misconception regarding this property. This is really for development only to allow devs to start Horizon for the first time quickly. Creating a custom captive core config is actually a huge barrier of entry especially for people new to Stellar and we want to mimic the behaviour of stellar/quickstart in which you only define which network you want to start. In production devs should switch to custom config and 1h restarts are there to make sure they notice that something is not working properly.

I think having hidden 1h delay after which horizon will stop will be confusing and, like you say, systemd might even hide it from operators making it worse. Personally I have never seen similar behaviour in linux software so I think it would be best to avoid it.

I agree that maybe it's not visible enough but I didn't want it to be hidden - we print level=error message on startup and after 1h right before terminating.

Horizon binary is likely wrong place to store default quorumset too. ubuntu packages we build ship with default configs already so I think it would be better to leverage that mechanism instead. We can do the same with docker images and we'll achieve the same goal. The benefit of doing that using package manager is that it's consistent with other linux software and operators should be familiar with the process. It also means that if quorumset changes are needed there no need to compile and rollout new horizon binary.

As explained in the first paragraph, feature is mostly for devs (often not using Linux) who download the binary from GH and want to start development quickly. Both ubuntu packages and docker images already have the default config (and the one here is actually copied from stellar/quickstart).
@stellar/horizon-committers let me know what you think about terminating Horizon with default config after 1h.

I think there's one misconception regarding this property. This is really for development only to allow devs to start Horizon for the first time quickly. Creating a custom captive core config is actually a huge barrier of entry especially for people new to Stellar and we want to mimic the behaviour of stellar/quickstart in which you only define which network you want to start. In production devs should switch to custom config and 1h restarts are there to make sure they notice that something is not working properly.

I see. Maybe there is a middle ground that could work for both use cases? Having hardcoded testnet config feels like less or a problem, especially if we don't stop after 1h.
With regards to pubnet maybe there is a good way to make it easy to generate the config for developers? Maybe an error message saying something similar to "Pubnet quorumset missing. You can download latest recommended config curl https://github.com/stellar/go/xxx" ? If we make the process simple and clear enough I think maybe it will be acceptable?

Regarding pubnet I also proposed this: https://github.com/stellar/go/pull/3783#discussion_r679053721.

A comfortable middle ground (gentler nudging of the user) could be to do something like Warn() about default config use every hour.

@tamirms I can't see the release branch yet so please merge if you feel you'll be able to add it to the next release. If not, I'll merge it next week.


Dev branch merge into Main.

Added Angular frontend Client and Spring Boot backend Server.

Review done.


Quota Exceeded Error

 Uncaught Google\ApiCore\ApiException: { "message": "Quota exceeded for quota metric 'speech.googleapis.com\/default_requests' and limit 'DefaultRequestsPerMinutePerProject' of service 'speech.googleapis.com' for consumer 'project_number:764086051850'.", "code": 8, "status": "RESOURCE_EXHAUSTED", "details": [ { "@type": 0, "data": "type.googleapis.com\/google.rpc.Help" }, { "@type": 0, "data": [ { "description": "Google developer console API key", "url": "https:\/\/console.developers.google.com\/project\/764086051850\/apiui\/credential" } ] } ] }

I got this error when i'm executing
# [START speech_quickstart]
# Includes the autoloader for libraries installed with composer
require __DIR__ . '/vendor/autoload.php';
# Imports the Google Cloud client library
use Google\Cloud\Speech\V1\SpeechClient;
use Google\Cloud\Speech\V1\RecognitionAudio;
use Google\Cloud\Speech\V1\RecognitionConfig;
use Google\Cloud\Speech\V1\RecognitionConfig\AudioEncoding;
# The name of the audio file to transcribe
$audioFile = 'C:/xampp/htdocs/speech_google/Rec1.mp3';
# get contents of a file into a string
$content = file_get_contents($audioFile);
# set string as audio content
$audio = (new RecognitionAudio())
    ->setContent($content);
# The audio file's encoding, sample rate and language
$config = new RecognitionConfig([
    'encoding' => AudioEncoding::LINEAR16,
    'sample_rate_hertz' => 32000,
    'language_code' => 'en-US'
]);
# Instantiates a client
$client = new SpeechClient();
# Detects speech in the audio file
$response = $client->recognize($config, $audio);
# Print most likely transcription
foreach ($response->getResults() as $result) {
    $alternatives = $result->getAlternatives();
    $mostLikely = $alternatives[0];
    $transcript = $mostLikely->getTranscript();
    printf('Transcript: %s' . PHP_EOL, $transcript);
}
$client->close();
# [END speech_quickstart]

please help me to come out of this issue

Hi @shrutiakki,
I've moved this issue to the proper repository. Let's continue the conversation here: https://github.com/googleapis/google-cloud-php/issues/1976


Updated the tutorial to include tenantId parameter

Added TenantId parameter options for Connect-AzureAD cmdlet as per customer suggestion for scenarios where they may have different tenant for test/Devops .

@shashishailaj : Thanks for your contribution! The author, @priyamohanram, has been notified to review your proposed change.

Looks good to me.


feat: add iOS

I also renamed the getter from root to isRooted, so it will not be flagged by linters.

Thanks! Can you change the Android part, it's isRouted now 😉
And remove the ds_store files

WHoops!


add instance profile ARN to .env.default and use it when creating EC2 instance

name: Pull Request
about: Open a PR for p0tion
Description
On our own deployed infra, when verifying a large circuit using the VM verification method, the EC2 instance fails to start due to invalid instance profile arn. This PR fixes the issue by requiring the developer to provide the instance profile ARN (one of the values emitted by the current terraform script) in .env and then using in createEC2Instance.
Checklist:

[X] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules
[X] I reviewed the code of conduct and contributors' guide

Oh I see it appears we don't use AWS_ROLE_ARN anymore. I can replace


Broken links

The links of the installer for Linux are broken on https://buttercup.pw/ and the link to receive a donation is broken too https://opencollective.com/buttercup-desktop/donate

Originally by @regoremor on buttercup/buttercup-desktop#372

Thanks @regoremor!


main

Update the queries file so test works
Add some very basic tests
Fix some of the imports, expand on the tests, remove pragma (which purescript thankfully doesn't have)

lgtm


Split the identifiers field to take advantage of the type system

Finishing off an idea from yesterday, and building on something mentioned this morning.
We have an "identifiers" field in the API that should contain all the identifiers on a Work/Item/Agent, including the one we stick in the "sourceIdentifier" field of the internal model – but there’s nothing that enforces we actually put the source identifier there. We have to remember to duplicate the information (to which: yuck).
This PR replaces the "identifiers" field with:

an "otherIdentifiers" field, which is populated with any extra identifiers we want to add
an "identifiers" property, which contains both the sourceIdentifier and the extra identifiers

This means we are guaranteed to include the source identifier in the "identifiers" field in the API, even if we forget to set it (which it turns out we do in a bunch of tests).
This is not the new mergeCandidates field – that will come separately.

This will need a reindex, so I’d like to hold merging this until I’m ready to do a deploy and a reindex.


Add MinReadySeconds to 5 in StatefulSets to prevent sudden double res…

What this PR does:
Adds a MinReadySeconds check for the StatefulSet.
Which issue(s) this PR fixes:
Fixes #648
Fixes #382
Checklist

[ ] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CHANGELOG.md updated (not required for documentation PRs)
[x] CLA Signed:  DataStax CLA

Thanks @burmanm & @adejanovski for these experiments after our exchange in https://github.com/k8ssandra/k8ssandra/issues/1432 : we were about to submit a Pull Request ;)
I believe the ability to configure MinReadySeconds is still valuable even if it doesn't solve our issue, but maybe default it to 0 (the k8s default if not specified) instead of 5s ?
Concerning the issue, we first tried to workaround it by disabling Reaper & Medusa on our clusters before a K8ssandra Operator/Cass Operator upgrade (Helm-chart based) to minimize the sources of changes for the StatefulSet, and we enable them again after the rollout... but it's not bulletproof.
Interestingly, I noticed our other k8s stateful workloads use different strategies than the one used by cass-operator (StatefulSet + spec.updateStrategy.type = RollingUpdate), so I wonder if they didn't face similar issues :

Hashicorp Vault uses spec.updateStrategy.type = OnDelete and leaves to the user the action to delete the old pods : see here
Strimzi uses a custom resource named StrimziPodSet to manage its Kafka pods by itself : https://github.com/strimzi/proposals/blob/main/031-statefulset-removal.md

Maybe a way to solve this issue would be for cass-operator to switch to spec.updateStrategy.type = OnDelete and control the rollout completely ?

Well, there are two (three) things here. First of all, preventing a single StatefulSet (per rack - not per cluster / dc, those should be guarded by cass-operator, see below) from restarting multiple ones is relatively simple PR:
diff --git a/pkg/reconciliation/construct_statefulset.go b/pkg/reconciliation/construct_statefulset.go
index e48f3ce..a5443a7 100644
--- a/pkg/reconciliation/construct_statefulset.go
+++ b/pkg/reconciliation/construct_statefulset.go
@@ -142,7 +142,7 @@ func newStatefulSetForCassandraDatacenter(
                        },
                        Replicas:             &replicaCountInt32,
                        ServiceName:          dc.GetAllPodsServiceName(),
-                       PodManagementPolicy:  appsv1.ParallelPodManagement,
+                       PodManagementPolicy:  appsv1.OrderedReadyPodManagement,
                        Template:             *template,
                        VolumeClaimTemplates: volumeClaimTemplates,
                },

The bigger issue is that how is this happening in the first place when not editing StatefulSets directly (as no one should). I haven't been able to trigger this issue (and the reproducer by @adejanovski does neither) with just CassandraDatacenter changes. Editing StS directly bypasses the reconcile logic in cass-operator which makes it odd. MinReadySeconds itself should have prevented that since the controller-runtime cache would not be updated instantly in any case and we should be requeueing when an update happens. I don't think MinReadySeconds = 0 is necessarily even a good setting since all of these can cause small concurrency issues.
And to be fair, I don't even know if MinReadySeconds does not stop this behavior. Perhaps it works correctly in this case and the "reproducer" is simply wrong (since it's not testing real behavior but something else). Sort of like we can't stop user from deleting all the pods at the same time if they really want to.
The third problem is our use PodDisruptionPolicy, which does not know about the replication factors or availability requirements, so it can't actually enforce a sane cluster structure. If it knew things are always quorum for example, it could enforce that. Also, it only targets the cluster wide labeling, not for example per-rack settings. That's a much more complex issue to solve.

Hi !
About the first point :

Well, there are two (three) things here. First of all, preventing a single StatefulSet (per rack - not per cluster / dc, those should be guarded by cass-operator, see below) from restarting multiple ones is relatively simple PR:

I believe that .spec.podManagementPolicy = Parallel affects only scaling operations, not the updates as documented here.
However, there seems to be .spec.updateStrategy.rollingUpdate.maxUnavailable in alpha since k8s 1.24, but I imagine it's equal to 1 by default if not set or if the feature gate is not enabled :man_shrugging:

The bigger issue is that how is this happening in the first place when not editing StatefulSets directly (as no one should). I haven't been able to trigger this issue (and the reproducer by @adejanovski does neither) with just CassandraDatacenter changes. Editing StS directly bypasses the reconcile logic in cass-operator which makes it odd. MinReadySeconds itself should have prevented that since the controller-runtime cache would not be updated instantly in any case and we should be requeueing when an update happens. I don't think MinReadySeconds = 0 is necessarily even a good setting since all of these can cause small concurrency issues.

And to be fair, I don't even know if MinReadySeconds does not stop this behavior. Perhaps it works correctly in this case and the "reproducer" is simply wrong (since it's not testing real behavior but something else). Sort of like we can't stop user from deleting all the pods at the same time if they really want to.

Maybe a good test would be to set MinReadySeconds to a ridiculously long delay to ensure when all events/webhooks are treated (almost) sequentially, the issue doesn't appear anymore ?
We could test it here with our own clusters which have been often hit by the issue, so that's why I was suggesting to set it to 0 by default (which is also the k8s default if not set), so you can merge the PR without any breaking change for the community, but allowing us to test more our assumptions ;)

The third problem is our use PodDisruptionPolicy, which does not know about the replication factors or availability requirements, so it can't actually enforce a sane cluster structure. If it knew things are always quorum for example, it could enforce that. Also, it only targets the cluster wide labeling, not for example per-rack settings. That's a much more complex issue to solve.

Just to state it, we encounter the issue with our single dc/single rack clusters, RF 3 which are always requested with quorum CL :/

I believe that .spec.podManagementPolicy = Parallel affects only scaling operations, not the updates as documented here.

Well, that's what the documentation says, but when I tested it I got different behavior.

However, there seems to be .spec.updateStrategy.rollingUpdate.maxUnavailable in alpha since k8s 1.24, but I imagine it's equal to 1 by default if not set or if the feature gate is not enabled 🤷♂

The documentation says in this one that it requires a feature flag to be enabled (it defaults to false) thus making it kinda useless.

Just to state it, we encounter the issue with our single dc/single rack clusters, RF 3 which are always requested with quorum CL :/

The current setup is only setting minAvailable.

In case you still wanted to test this PR, the easiest way is to use gh pr checkout.
So gh pr checkout 647 and then depending on the target cluster, make docker-build docker-logger-build and push the images somewhere (running from our source requires build of system-logger image also), or with kind: make docker-kind docker-logger-kind to get the correct images.
And then make deploy will deploy the cass-operator to cass-operator namespace in a namespace scope (I should probably make this cluster-scope for testing purposes, but in this PR it's still namespace scope for testing).

There is an issue opened & a PR opened on the k8s repo
Statefulset with podManagementPolicy=Parallel ignores minReadySeconds on statefulset rollout update
https://github.com/kubernetes/kubernetes/issues/119234
https://github.com/kubernetes/kubernetes/pull/123975

Awesome, so I wasn't going crazy when reading the statefulset controller code. In that case, my latest commit should hopefully prevent the double change from happening. There's also updates for the k8ssandra-operator upgrade process in here that would further block any accidental restarts:
https://github.com/k8ssandra/k8ssandra-operator/pull/1298

Nice ! I'll try to find some time this week to test all these changes :)

Yeah, I'll need to fix some more tomorrow, I made a mistake with the canary upgrade process braking these rules. So I need to find another way for the StS prevention.
As for OrderedReady, I didn't feel like it adds a lot of extra time to expanding clusters (seconds per node and not more than that, so irrelevant). I'll probably investigate it more to see if we should also apply that, since if there's no real downside, then we could prevent the behavior on the StS level also.

I've moved other than the MinReadySeconds / OrderedPodManagement change to another PR: https://github.com/k8ssandra/cass-operator/pull/654


Update Dockerfile.test to build from experimental

This PR updates the old Dockerfile.test file to build from experimental.docker.com instead of test.docker.io. This may address the request in #1045, though I think a boot2docker/boot2docker:experimental tag on Docker Hub would be needed to completely address that issue. Unfortunately, Docker Hub doesn't yet support named Dockerfiles, nor does it support building dependent Docker images reliably from a single git push.

Also, I think that curl -f should be used for most of the curl commands in these Dockerfiles, but I didn't make that change in this PR.

LGTM

(also, +1 to -f!)


example R: make the main example build and run

This change is

@janekmi @osalyk @grom72 please review


[TA] Add Extractive summarization feature

Added extractive summarization feature back to TA
Waiting to have PPE endpoint and then testing this PR.
Will add the bespoke methods in the next Beta.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-textanalytics


Use a swagger Java client for DOS plugin

The plugin should be easily maintainable when updates are made to the DOS schema using some automation.
┆Issue is synchronized with this JIRA Story
┆Issue Number: DOCK-31
┆Epic: Improve DOS File Provisioner

➤ Charles Overbeck commented:
I think we are good with the current approach, as it is leaner… Going to close for now, can revisit later.


Image splasher

Title and Issue number

Image Splasher #1627
Close #1627

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md

Inactive


[Event Hubs] Integrate logging into the Event Processor Client and associated types

As a library, it is important to provide a means for developers using it to understand its activities and the sequence of operations that comprise them, in order to assist in development and debugging efforts.
The focus of these changes is to implement logging for EventProcessorClient.

@christothes I hadn't seen your feedback before writing mine, so we might have one similar comment or two. Thank you again for your engagement!

@christothes Thank you so much for your valuable feedback. It was super helpful.

I think you addressed basically everything I pointed out. Just wanted to wait a bit for Jesse's opinion on Informational and Verbose stuff because that's an important matter.

Yeah, that was tagged as "outdated" and folded when I reviewed.   Sorry that I missed it.   All answered up now.

I'd like to see us make a call on the testing surface and adjust either way before this closes.

/azp run net - eventhub - ci


get_request_args Exception

When the API request parameters are missing and request.json() fails to parse, proper error handling should be implemented.

            body_data = await request.body()
            if body_data:
                try:
                    json_data = await request.json()
                    args.update(json_data)
                except Exception as e:
                    log.exception(e)
                    args.update({'body': body_data.decode('utf-8')})

This processing will cause the data encryption to fail. What is the specific case where the json() parsing fails?

Missing required parameters result in an error. For example, when making a request to the login API, if only the username and password are provided without the captcha, an error will be thrown.
{
  "code": 422,
  "msg": "请求参数非法: captcha field required.",
  "data": null
}

The password will be encrypted, but the code will not match.
In the operation log, the code is shown as 200, but it should actually be 422.

But this doesn't seem to be an error in request.json(), I don't think request.json() seems to throw an exception here because the data validation is triggered earlier

execute_request() seems to catch only explicit exceptions, i.e. internal errors that are printed on the console, and fastapi handles data validation as 422 request success instead of triggering an exception

fastapi internally calls an exception handler before the request is sent
https://github.com/tiangolo/fastapi/blob/49bc3e0873c8e89edbffdd3a41b1c2c56f15c823/fastapi/applications.py#L142C12-L148
After the exception handling is triggered, return JSONResponse() is called directly, so execute_request() does not catch the exception

Test Pass.


Fix generation of legacy privacy group IDs

Fix generation of legacy privacy group IDs to be calculated using the contents of the address not the memory address.
Existing legacy privacy group IDs will need to be migrated to the new generation.

Not sure this is worth doing but need to either capture this information in comments or documentation so we're not caught by it at some stage in the future.

this was fixed in EthSigner. Find the code and link here.

This is the code in Besu https://github.com/hyperledger/besu/blob/a93d06f1827f3bd346c42add45e32c57a27440d3/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/privacy/PrivacyGroupUtil.java

And in Orion https://github.com/ConsenSys/orion/blob/05759341ec1a216e6837df91e421207c8294ad2a/src/main/java/net/consensys/orion/enclave/sodium/SodiumEnclave.java

generation code was removed from EthSigner - it gets the id from besu/orion


Fix: Improve error messages from server

Describe your changes:
We have changed these errors message:
InvalidServiceConnectionException for service [MySql] due to [Failed to encrypt connection instance of MySql]

For more descriptive ones:
Failed to encrypt 'Mysql' connection before storing in DB due to an unrecognized field: 'username1'

Type of change:

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
[x] I have added tests around the new logic.
[ ] For connector/ingestion changes: I updated the documentation.

will merge this post 1.0 release


Live preview doesn't work on frameworks

Live previews doesn't work when you are using frameworks like Laravel. Example: In Laravel your pages are in a different folder called "resources/views". So lets say you have a PHP file located at: "resources/views/index.blade.php", live preview would redirect you to this file, however this file is visitable by any route you supplied. You must set a route and show the view on that route. Example, if you have the routing "home", the page is actually visitable at "(yoursite)/public/home" instead of "(yoursite)/resources/views/index.blade.php".
I hope it's clear enough for people that don't know what Laravel is.

@youssefdetovernickr This issue is tracked on our feature backlog, here: Make Live Development Work For Router-Based Server Technologies.  Please upvote it to help raise the priority -- I'll close this bug to avoid duplication.


Personal additions

Hey, @KennethLuczko. Love the app!
I wanted to add some things I thought would be helpful for planning my own routes and I got a bit carried away.
If you would like me to cherry pick any of these additions, I can pull them out and add them to individual branches for prs. I usually work as a solo dev, so my branch etiquette is lacking.
Here is a list of the additions:

Add Step Number indicator
Add Region icons
Add Sticky Stats calculator
Update Card layout to make room for buttons
Add color picker for highlighting tasks
Add "Quick Insert Custom" button. (This adds a new custom task to below the current task, so you don't have to drag it up from the bottom of the list.)
Add Search bar to "Your Route" (I also added one to "Available Tasks" before I saw you added your own already 😅)

There are some various other CSS tweaks to account for the new buttons and icons.
The colors save to the JSON and should work with any existing exported routes.
If a task has a color applied, it will have a single property added to the JSON.
E.G: "color": "blue"
The branch with the full commit history can be found here.

Hi @SilasCundiff this is fantastic! Let's add all of these to the main app. Can you open a pull request with all of these features? I'll review and merge asap.


"...encountered an error during the load_registries event phase" for 1.15.2

Error occurs for both "immersive-portals-0.10(forMc1.15withForge)" and the newer .11 version. I get the error even with the mod loaded by itself.
latest.txt

Did you install MixinBootstrap?


experimental_sx doesn't work in pseudo-classes

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/naughty-wildflower-f7h30d?file=/demo.tsx
If I remove sx function, the style will work.
Current behavior 😯
No response
Expected behavior 🤔
No response
Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Thanks for the feedback. This is not intended usage, the sx helper should be used at the top level when defining the styles. What was the motivation to use this only in the pseudo selector?


[BUG FIX] Fixed import error in api_wrapper

An import was missing.
Should I make a unit test for this ?

@DayBr3ak
I wish we had unit tests that we could add for this. Unfortunately, this project is lacking in the automated tests side of things. If that is something you are interested in contributing to the project, I can't even express how happy that would make us.

@TheSavior I would love to try. I'll get started later today.


RepositoryItemWriter not inserting on execution

Hi, when using this library every time I execute a job using a RepositoryItemWriter it does not generate the inserts in database.
I'm using jpa, hibernate with oracle. On enabling "spring.jpa.show-sql=true" property I can see the are no insert being executed by hibernate.
After just removing the spring-boot-starter-batch-web 1.4.0.RELEASE dependency from my pom, and re-executing the Job, the inserts are there.
Is this any configuration issue? How can I fix it?

I have the exact same problem, is there any news on this? Does anybody know what causes the problem?

In the meantime we managed to solve it. The problem seems to be that spring-boot-starter-batch-web defines a DataSourceTransactionManager which doesn't work properly with JPA. We managed to solve it by defining a JpaTransactionManager in our configuration which implements the BatchConfigurer interface.

This is how it should be done: https://github.com/codecentric/spring-boot-starter-batch-web/issues/48#issuecomment-351400224


output inconsistency for masked vs compressed model [structured pruning]

Describe the issue:
Model compression in NNI breaks numerical consistency when I use it for structured pruned model.
Environment:

NNI version: 2.8
Client OS: MacOS

How to reproduce it?:
import torch.nn as nn
from nni.compression.pytorch.pruning import FPGMPruner, L1NormPruner, LevelPruner
from nni.compression.pytorch.speedup import ModelSpeedup

m = nn.Sequential(
    nn.Linear(5, 7),
)
_ = torch.nn.init.kaiming_normal_(m[0].weight)
m_input = torch.randn(20, 5)

print(m(m_input).sum())

config_list = [{
    'sparsity_per_layer': 0.5,
    'op_types': ['Linear']
}]
pruner = L1NormPruner(m, config_list)
masked_m, masks = pruner.compress()
pruner._unwrap_model()

print(m(m_input).sum())
print(masked_m(m_input).sum())
ModelSpeedup(m, m_input, masks, 20).speedup_model()

print(m(m_input).sum())
print(masked_m(m_input).sum())

example output (see printed lines of models output)
tensor(17.3238, grad_fn=<SumBackward0>)  # usual
tensor(13.3754, grad_fn=<SumBackward0>)  # masked
tensor(13.3754, grad_fn=<SumBackward0>)  # masked
[2022-08-29 17:38:18] start to speedup the model
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compressor | start to speedup the model
2022-08-29 17:38:18 | INFO | FixMaskConflict | {}
2022-08-29 17:38:18 | WARNING | FixMaskConflict | no multi-dimension masks found.
2022-08-29 17:38:18 | INFO | FixMaskConflict | Dectected conv prune dim" 0
[2022-08-29 17:38:18] infer module masks...
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compressor | infer module masks...
[2022-08-29 17:38:18] Update mask for 0
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compressor | Update mask for 0
[2022-08-29 17:38:18] Update the indirect sparsity for the 0
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compressor | Update the indirect sparsity for the 0
[2022-08-29 17:38:18] resolve the mask conflict
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compressor | resolve the mask conflict
[2022-08-29 17:38:18] replace compressed modules...
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compressor | replace compressed modules...
[2022-08-29 17:38:18] replace module (name: 0, op_type: Linear)
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compressor | replace module (name: 0, op_type: Linear)
[2022-08-29 17:38:18] replace linear with new in_features: 5, out_features: 4
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compress_modules | replace linear with new in_features: 5, out_features: 4
[2022-08-29 17:38:18] speedup done
2022-08-29 17:38:18 | INFO | nni.compression.pytorch.speedup.compressor | speedup done
tensor(0.6746, grad_fn=<SumBackward0>)  # compressed
tensor(0.6746, grad_fn=<SumBackward0>)  # compressed

nice catch, this because during pruner.compress(), bias_mask is not generated, we have fixed it in nni 2.9, you could have a try on 2.9alpha.
pip install --extra-index-url https://test.pypi.org/simple/ nni==2.9a2

Closing as the problem has been fixed in 2.9.
If there are further inquiries, please reopen.


Error: spawn flake8 ENOENT

I am using Atom on the Beta channel on a Ubuntu 16.04 machine:
$ uname -a
Linux e6320 4.4.0-24-generic #43-Ubuntu SMP Wed Jun 8 19:27:37 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

$ atom-beta -v
Atom    : 1.9.0-beta0
Electron: 0.37.8
Chrome  : 49.0.2623.75
Node    : 5.10.0

I have a virtualenv in which I use pip to install flake8. If I open Atom using the Unity Launcher, Atom gives an error message that says:
Error: spawn flake8 ENOENT
    at exports._errnoException (util.js:890:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:182:32)
    at onErrorNT (internal/child_process.js:348:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

On the other hand, if I open Atom from the terminal by running atom-beta, Atom does not give the error message above and linter-flake8 works as expected. It may be useful to note that other linters that I have such as linter-markdown works as expected regardless of whether I open Atom from the Unity Launcher or the terminal, so I think the error message is caused by linter-flake8 rather than the base linter package.

The error message is actually caused by virtualenv and Unity 😛.
Unity has no idea what your environment in the terminal is right then, so it uses a default one. Depending on how your virtualenv is set up you probably just need to set a path to flake8 based on the project path in your linter-flake8 settings.

@Arcanemagus Ah, you are probably right. :smile:
The README.md says "Then activate your virtualenv from the command line before starting Atom, and you're good to go!", which gives me the impression linter-flake8 would work regardless of whether I can start Atom from Unity or the command line.

That was probably written with the assumption of running Atom with atom . from within the terminal.


Allow package title reuse after package soft-deletion

Fix #3456.
A package title should be available for reuse by another package if the title is not otherwise in use by any non-deleted package.  Before this change, a soft-deleted package's title was still reserved.
Added a few unit tests.  Verified the new experience from both the command line (nuget.exe) and from the gallery web site.

Hi @dtivel, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


Update prod elasticsearch to 17.7

Currently the prod elasticsearch is still on version 7.15 and this version will soon no longer be supported internally. All other elasticsearchs are already at version 7.17.
Describe the solution you'd like

Upgrade prod elasticsearch to 7.17.
Describe alternatives you've considered

Acceptance Criteria

[ ] All elasticsearch servers are at version 7.17
[ ] Optimize prod running without problems

Additional context

Auftrag läuft: RITM0725013
Sollte am 26.4.24 um 15 Uhr durchgeführt werden.