[0.15] Things we need to get in for 0.15

Main thing to do: Cut the 0.15-stable branch, ideally Friday 6/11.
You need to make sure everything works on master (especially the "Getting started" flow on iOS and Android). If something's broken, fix it or chase people to fix it. Once master is in good state, cut the branch. Start testing everything on Thursday morning so you have a buffer and cut the branch on Friday.
Publishing is then easy, I'll be on messenger and can help with publishing to Maven Central.
cc @ide, @vjeux, @foghina

Here are the steps for cutting the branch:

Make sure iOS and Android Getting Started flow works on master.
Edit ReactAndroid/gradle.properties
git checkout -b 0.15-stable
In package.json, set version to e.g. 0.15.0-rc.
In React.podspec, set version to e.g. 0.15.0-rc.
In local-cli/generator-android/templates/src/app/build.gradle update the dependency to e.g. com.facebook.react:react-native:0.15.+
git commit -m "[0.15] Bump versions"
git push origin 0.15-stable

Publishing to Maven Central (I'm happy to do that):

Edit ReactAndroid/release.gradle and uncomment Javadoc generation
./gradlew :ReactAndroid:installArchives (java -version should print 1.7 which is currently needed for Javadoc generation). This creates artifacts in ~/.m2/repository.
Log into Sonatype and go to Staging upload: https://oss.sonatype.org/#staging-upload
Select Artifact(s) with a POM (to publish to a local Maven repo for testing run ./gradlew :ReactAndroid:installArchives)
Add all files: .aar, sources jar, javadoc jar, .asc for everything (including the POM file)

@mkonicek is 0.15 going to be published this week?

@mkonicek closing this since 0.15 is already released. I think we should document the "steps for cutting the branch"


[style]: improve the main page

What's the style idea?
We need to improve...the main post page by placing the posts in the center, the profile picture on top left is under the navbar, will fix it as well and fix the  footer links on the bottom left corner
Add screenshots
Add screenshots here
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I have read the Contributing Guidelines
[X] I agree to follow this project's Code of Conduct
[ ] I'm a GSSoC'23 contributor
[X] I want to work on this issue

Please assign this issue to me if this project is still actve

What's the style idea?
We need to improve...the main post page by placing the posts in the center, the profile picture on top left is under the navbar, will fix it as well and fix the footer links on the bottom left corner
Add screenshots
Add screenshots here
Code of Conduct

[x]  I agree to follow this project's Code of Conduct
[x]  I have read the Contributing Guidelines
[x]  I agree to follow this project's Code of Conduct
[ ]  I'm a GSSoC'23 contributor
[x]  I want to work on this issue

Hi @karthiknadar1204 posts in main page are already centred, can you elaborate more? Also, can you send screenshot where there's an issue with profile picture?  Also, the footer links are correct as well, can you check again?

@narayan954

@narayan954

Hi @karthiknadar1204 I can't reproduce this error and I have checked on Chrome and Edge. Can you please check in other browser and please verify it's a general issue or some browser specific issue. What's your browser? edge, right?

Will check and get back


Can't install VSIX into VS Code Insiders

VSCode Version: 1.6.0-insider
OS Version: Win10

Steps to Reproduce:

Download latest C# extension beta release: https://github.com/OmniSharp/omnisharp-vscode/releases/download/v1.5-beta2/csharp-1.5.0-beta2.vsix
In VS Code, use File->Open to open the VSIX.

Expected Result: Extension installs
Actual Result:

This means of installing a VS Code extension is deprecated. There is a new Extension View command "Install from VSIX..." to install an extension from a .vsix.
There is also the command line "--install-extension" switch.

Thanks @gregvanl! A bit of feedback -- I found the "Install from VSIX..." command pretty difficult to find. I actually looked around for it for quite awhile, even after you mentioned it.

@DustinCampbell Agreed, I just entered https://github.com/Microsoft/vscode/issues/13174 to make sure it is in the Command Palette.
I'm also in the process of updating the docs.

Thanks!

I'm going to reopen this issue so it gets more visibility. I'm not sure of the reasons to deprecate the File > Open. Adding "Install from VSIX..." is nice but removing the previous way can be confusing.
It would be better to deprecate File > Open at a later release after warning users.

Let's not go back.
I will make sure #13174 is done asap, so people can still find it.


Do Not Merge: debug logs for flaky functional tests

PR Type

CI FIx

Working on https://github.com/ansible/molecule/issues/1799.
We probably want no_log:False on your debug logs anyway for Docker tests (no creds anywhere).

Aha!
    --> Scenario: 'default'
    --> Action: 'prepare'
    Skipping, prepare playbook not configured.
    --> Scenario: 'default'
    --> Action: 'converge'

        PLAY [Converge] ****************************************************************

        TASK [Gathering Facts] *********************************************************
        ok: [instance]

        TASK [timezone : Include OS-specific variables.] *******************************
        ok: [instance]

        TASK [timezone : Ensure NTP-related packages are installed.] *******************
        fatal: [instance]: FAILED! => {"changed": false, "msg": "Failure talking to yum: Cannot find a valid baseurl for repo: base/7/x86_64"}

        PLAY RECAP *********************************************************************
        instance                   : ok=2    changed=0    unreachable=0    failed=1

"msg": "Failure talking to yum: Cannot find a valid baseurl for repo: base/7/x86_64"

OK, got what I needed.


unknown-function-variation test case

That was from my configuration.nix file. Not sure how to call the test case.
Output:
Unknown function variation { config, pkgs, ... }:

Oh, it's a rest argument or whatever it's called in nixlang. Woudl be good to see the output of this to see what is up

My first message in this issue has the output. Unless you mean from those output files when we run npm test.

right, with the output. it would also be good to make this a valid expression rather than a partial one

I just pushed a new commit which I think is a valid expression.
Here's the relevant part of output.nix:
(expression (function (formals (formal (identifier)) (formal (identifier))) (ellipses) (attrset (bind (attrpath (identifier) (identifier)) (string)))))
Unknown function variation { config, pkgs, ... }:

{
  system.stateVersion = "19.09";
}

Cool, thanks

This might be fixed by updating tree-sitter-nix https://github.com/cstrahan/tree-sitter-nix/commit/c885d29d567d5d99c0774da7ee20a575a0b733f4


Fix updateDeveloperProduct & addDeveloperProduct

Same issue as addDeveloperProduct, which has already been fixed.

i need this fixed...

i need this fixed...

If it's already fixed for one method, why not open a pull request? That's the point of open source.
Is the fix you are referring to #751 ?

Ah I see on your other issue you say you don't know JavaScript. Great place to learn. Going to merge both into this issue

i need this fixed...

If it's already fixed for one method, why not open a pull request? That's the point of open source.
Is the fix you are referring to #751 ?

no bro, im talking about updateDeveloperProduct which uses an old roblox api. its not addDeveloerProduct, it is this one https://github.com/noblox/noblox.js/blob/master/lib/games/updateDeveloperProduct.js

Presumably fixed by #814 and #778


[LIBCLOUD-604] Add 'ex_list_subnets' to OpenStack provider

Added ability to list subnets for libcloud OpenStack driver by fetching them from the OpenStack API and parsing them to a list of OpenStackSubnet class.
This has been tested with a local devstack environment setup on my local machine.
Reference to the OpenStack API here.

Thanks.
Can you please also add a corresponding test case?

Yeah sure!

So does the Openstack test cases use rackspace driver in the backend? Because in my test case for the above code, I call the driver.ex_list_subnets function which throws an error saying this function is undefined in RackspaceFirstGenNodeDriver .
I agree that Rackspace runs on OpenStack, but shouldn't these tests be performed on a running devstack instance?

@hannanabdul55 All the tests right right now are unit tests where we use mock provider responses (we don't test against a live environment).
Right now OpenStack tests inherit from Rackspace oned and not vice versa and that's something which we eventually need to clean up.
I'll have a look at what could be causing the issue and let you know (we do some "weird" test inheritance which might be causing the issue).

Yeah sure. I have the unit tests for the same ready anyways. But it breaks the testing, hence, should I withhold the commit for the test cases as of now?

@hannanabdul55 Can you gist the tests / diff somewhere? And I will have a look.

I have lost that local repository. I will gist it in a while after recovering it.

Sorry for the delay.
Added some comments.

Yeah sure. I will do this and commit!


ResizableLimits can't represent the maximum memory32 heap size of 4GB

Cf https://github.com/bytecodealliance/wasm-tools/blob/main/crates/wasmparser/src/primitives.rs#L196.  The maximum heap size for memory32 is 4GB (64K pages of 64K bytes each), but as this structure uses a u32 for the maximum field, and this field appears to represent a number of bytes and not the largest valid index, the maximum size cannot be represented.  The structure should probably use u64 fields.
(Firefox is changing to support 4GB heaps, and we use wasmparser.)

I think the ResizableLimits just stores the raw u32 we read from the wasm binary itself (pages, not bytes), so I think this should be handled already? Although I could be missing a spot where we try to translate that to bytes by accident. I believe the intention is that it's always listed in pages.

Cranelift bug, then - it treats this as bytes.  I'll fix locally.


Add auto approvers

About
Add auto_approvers parameter.
Example
If auto_approvers is na-ga :

Actor abematv-backend is rejected by branch protection because it is not included in auto_approvers
Actor na-ga is approve & merge because it is included in auto_approvers

This approach works as expected when Require approvals for branch protection is 1, but has problems when it is 2 or more. Therefore, it was discussed with @0daryo that it would be better to use the method of specifying merger and not requiring approvals as a workaround.


Documented render_variable function in prompt.py

Another bit of documentation. This is the first time I've ever touched this module!

Current coverage is 100.00%

Merging #678 into master will not affect coverage as of b8f369c

@@            master    #678   diff @@
======================================
  Files           13      13
  Stmts          577     577
  Branches         0       0
  Methods          0       0
======================================
  Hit            577     577
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of b8f369c

Uncovered Suggestions

+0.35% via ...ookiecutter/utils.py#27...28

Powered by Codecov. Updated on successful CI builds.

:bell: @pydanny

Resolved the flake8 issue and adapted the docs for one of the parameters. 😄


Proposal: Let Verilator generate its own main function

I was surprised to learn that Verilator 5.000+ (which we require) has an option to generate its own C++ main function and associated code to drive a design. As the Verilator changelog says:

For designs where C++ was only used to make a simple no-I/O testbench, we recommend abandoning that C++, and instead letting Verilator build it with --binary (or --main).

The implication is that Verilator can now be used much more like Icarus Verilog; the HDL program to execute is self-contained and needs no special C++ to go along with it. (It runs until the harness does a Verilog $finish.) This PR attempts to take the above advice. It drops our C++ testbench wrapper that was used for Verilator and replaces it with the existing tb.sv SystemVerilog wrapper that we also use for Icarus simulation. Hopefully this makes things a little easier to maintain.
There are some possibly-entertaining diversions in the commit logs. This is a draft because I would love feedback about whether this looks like a terrible idea. There are also two weird loose ends:

I had to disable Verilator's inlining pass. See the relevant commit message for an error message that arises when inlining is enabled.
We should probably move tb.sv out of the fud/icarus directory because it is no longer Icarus-specific.

Annoyingly, I think the CI is failing only because the fud configuration in the Docker container is out of date. As of #1322, fud now complains:
[fud] ERROR: Unknown configuration option `top_module' for stage `verilog'. Known options: data, exec, round_float_to_fixed, vcd-target, cycle_limit, file_extensions

I did indeed remove that config option, since it is no longer feasible to support. But the only reason this is an error is that the Docker container was built when that config option existed. :shrug: Maybe the CI commands should delete the fud config? Or @rachitnigam, what do you think about making the above message into a warning instead of a crasher? Extra, meaningless config options in your config file aren't really harming anybody, after all.

Woo! Love the change and the removal of C++ TB.

I'm kinda curious where this error message even comes from because you already removed the use of ["stages", self.name, "top_module"].
Worth considering what we should do when a user provides a different "toplevel" module than main to the compiler since we can't simulate anything other than main now.
We can move the tb.sv file to the same location where the C++ testbench was. We'd need to update the icarus fud stage to point to that location as well

About item 1: I think the error message is a consequence of #1322, which produces an error if your TOML configuration file provides a setting that the stage doesn't declare in its known_opts. And our Docker image has a pre-baked TOML file from an old version. (So of course rebuilding the Docker image would suffice, but it's a little annoying to do whenever we change configuration stuff.) That's what's behind my vague suggestion to turn this into a warning instead of a hard error.
About 2: It's true that this removes the ability to execute programs with top-level components not named main. The underlying reason is that the main name is hard-coded in tb.sv:
https://github.com/cucapra/calyx/blob/a057dd6337fb5df8430f1a94b109463c6f524814/fud/icarus/tb.sv#L5
…which means, of course, that this was already not possible with Icarus simulation. In fact, it is not entirely clear to me whether this ever even worked with Verilator simulation, because the C++ harness hard-codes the name Vmain (which I believe comes from the Verilator component name):
https://github.com/cucapra/calyx/blob/a057dd6337fb5df8430f1a94b109463c6f524814/fud/sim/testbench.cpp#L39
AFACIT, this facility was never triggered in an "automated" way, i.e., it did not pick up on a @toplevel attribute and you had to manually configure it. So my suspicion is that we are not really using this ability and it is probably safe to remove.

Okay, both of these items make sense! Downgrading the error to a warning seems totally fine too!

@sampsyo I've downgraded the error to a warning. However, for some reason this PR also dramatically increases the cycle count for a bunch of tests. Not clear why.

Yay yay; thanks!!!
Pretty weird about the increase in cycle counts. I'll take a closer look!

A possible clue: most of the examples with increased cycle count are the synchronization ones. Perhaps something changed when we switched to the Verilator-based harness generation? One sanity test is to see if running the program through icarus generates similar cycle counts. This would indicate that the change is caused due to difference in the harness code and is probably benign but maybe worth investigating.

This also break the --to vcd mode for Verilator

With these changes, there is massive overlap in the code for icarus and verilator. The only difference is the compile comand. We should probably define a new generic stage for simulator and inherit from it

Still a couple of bonafide failures in this and some sort of off-by-one error which is reducing the cycle count for many tests by 1, seemingly anything that uses a static FSM. Might be related to the done condition generation somehow? Remaining failures are from the warning generated because of the unknown flag.

Thanks for finishing this up to merge it!!!! It looks like the fix to the off-by-one problem you mentioned (or at least a partial fix?) was a change to the condition for $finish in the testbench? Interesting if so!
Cool that Icarus and Verilator are so similar in their Python stage implementations now. They were clearly copied-n-pasted before, but their diff was nontrivial (for obvious reasons). Now that they are similar again, we do have an opportunity to collapse the shared machinery…

Yeah, there is one test that immediately asserts its done condition which the test bench really doesn't like and gives a cycle count of 0. I couldn't figure out how to fix it so gave up for now.


No error when trying to connect pyfora 0.2 to 0.1 backend

It looks like pyfora.connect just hangs.

In 0.2 we added a handshake to the protocol and, when talking to an 0.1 server, the client was just sitting there waiting for a handshake response that never comes.
Added a timeout to pyfora.connect() with a default value of 30 seconds.


MudDialog: Avoid using aria-hidden on a focused element or its ancestor

Description

Resolves #9541. I don't have any more details but it's clearly causing an issue.
How Has This Been Tested?

none
Type of Changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

I don't know how MudFocusTrap works but clearly it sets focus to that specific element when DefaultFocus.Element is set, so we can't have aria-hidden on it :(

Focus trap keeps the focus in a specific region (i.e. an open dialog) by adding a focusable element at the start and the end and whenever these elements hit focus it cycles it forward to the next focusable element in the allowed region. This way, the focus can not escape the open dialog and the user can't tab through the UI behind the dialog overlay.


Disclaimer notices

What disclaimers are needed on the site?
Is it enough to have just the FAQ page? Should we be linking to the FAQ in specific places on the site?

@adborden I'm thinking we use some of the text from the FAQ in the About text and the home page. I'll review Monday and make some suggestions.


upgrade

strange failure is node 6 + ember-default scenario, but unable to replicate locally..
env EMBER_TRY_SCENARIO=ember-default yarn test

guess i need to dive in more... 😢


🐛 Bug Report: FilterRow component is not working

📜 Description
So I want to customized the Filter to meet our Figma design, So i try to override the filter component using FilterRow but its not updating instead its just showing the default filter
this is my code

 {
          const { columns, onFilterChanged } = rowProps;
          return (
            <>

                {columns.map((col) => {
                  if (col.field) {
                    return (

                        <input
                          placeholder="custom filter"
                          id={col.field}
                          onChange={(e) => {
                            onFilterChanged(col.tableData.id, e.target.value);
                          }}
                        />

                    );
                  }
                })}

            </>
          );
        },
      }}
    />

👍 Expected behavior
It should update the UI on the filter
👎 Actual Behavior with Screenshots
It actually just display the default UI
👟 Reproduction steps
Its Component Issue
📃 Provide the context for the Bug.
No response
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
None

As far as I know you also need to enable filtering for the filter row to show up, try adding options={{ filtering: true }} to the table component.

Yeah I did try that, but its not showing the custom components on the left side of the table instead its only showing above each column, So its not possible to customized the Backstage Table filter right?

@goodryanboy Ah yeah no you can't customize the ones to the left

Thanks for confirming @Rugvip


Disable Sinatra public_folder

It defaults to ./public which is not what we want.

Ah, we're using Sinatra::Base which doesn't do any of this nonsense.


fix kubeconfig playbook

Signed-off-by: hang.jiang<EMAIL_ADDRESS>
What type of PR is this?

/kind bug
What this PR does / why we need it:

add check for kubeconfig.yml

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm

/lgtm


Testing pair programming

Hello Microverse In this PR the following is done in contribution to my partner @Jolak5 :

Write unit tests with React Testing Library.
Write unit tests with snapshots with Jest.

@GedeonTS Thank you I resubmitted with the correct one


Feature like the migration but showing duplicated entries

Describe your suggested feature
Group all duplicated entries together & allow to migrate/merge them
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 1.10.5.
[X] I will fill out all of the requested information in this form.

https://github.com/komikku-app/komikku/issues/203
https://github.com/Suwayomi/Suwayomi-WebUI/issues/751
https://github.com/Suwayomi/Suwayomi-WebUI/commit/6e1a204c29b3dad7674396ba56e08cfe8e71da9f
https://github.com/Suwayomi/Suwayomi-WebUI/commit/cc0a332f028589ec5c3d54a2cad5c523326d9ba2
https://github.com/Suwayomi/Suwayomi-WebUI/commit/b9b105c2366830bb342ca0e682759b48dace49d8
https://github.com/Suwayomi/Suwayomi-WebUI/commit/df66e180d88d5fb7bcf5a1290624dd26d539984e
https://github.com/Suwayomi/Suwayomi-WebUI/commit/f66051d39824ab0a7992d4426ac7538d34b180bb


update green-hill scene

update green-hill scene file
Added waterfall and sea to the scene
https://user-images.githubusercontent.com/60634884/166186286-931a0d81-2479-4e63-bcc1-d088053e68d6.mp4

Looks Good.


AWS provider no longer compatible with latest version of terraform

Hi,
The provider constraints within this project version = "~> 1.35" unfortunately is no longer compatible with the later versions of terraform.
Error given:
terraform init

Initializing the backend...

Initializing provider plugins...
- Checking for available provider plugins...

Provider {"aws"} v1.60.0 is not compatible with Terraform 0.12.9.

Provider version 2.7.0 is the earliest compatible version. Select it with
the following version constraint:

	version = "~> 2.7"

Terraform checked all of the plugin versions matching the given constraint:
    ~> 1.35

Consult the documentation for this provider for more information on
compatibility between provider and Terraform versions.

Error: incompatible provider version

Changing the version number to "~> 2.0" seems to work however.

Thanks for highlighting this @Maelstromeous , at the moment terraform v0.11 would be required to run the setup.

Resolved by https://github.com/CircleCI-Public/circleci-demo-aws-ecs-ecr/pull/8

Reopened as the issue still exists in the orbs and without_orbs branches.


Highlighting bug?

VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:46:00.226Z)
OS Version: Darwin x64 16.1.0

Any idea why there seems to be a strange block highlight in the editor? I've tried reinstalling it, changing the theme and I've removed all the extensions, but I'm still experiencing this issue.

@zachbpd Do you see this non empty files as well?

Yes and even if there's this one point in the code where it's not obvious the left margin (where the search and extension library icons are) still contains on extra shade of grey.

https://github.com/Microsoft/vscode/issues/12473


Queries with Fixed Length

https://www.hackerrank.com/challenges/queries-with-fixed-length/problem
Queue question

Can I do it in python

May i do it in cpp .PLease assign this to me.

@vikhyatsingh123 Complete all others first

Can I do it in python?

I'll do this one in JAVA

@verma-shivani go for it in cpp

@yashasvimisra2798 go for it in python

@Aarushi11H go for it in java

@vikhyatsingh123 Please complete all other previous issues assigned to u first

I completed all my previous task. Please Assign me this one.

Hey this problem had been added in both Queues and Heaps grid in the Readme.md file. It must be added to the Queues folder as its a queue problem (even acc to hackerrank)

@Aarushi11H Please fix this issue.

Can I work on cpp solution?


added fly.json

The Pull Request resolves Issue #[Issue-Number]
Description:
A brief description about the addition or edits made.
Notes: Delete all the text including this!

The #[Issue-Number] should be replaced with the specific Issue being referenced.

added fly.json file

Hey @kelumsampath
Fly is already included in Fly_noun.json and Fly_verb.json
Please contribute to other open issues. I'm closing this Pull Request.
Thanks for contributing.

okey! thank you!
On Mon, Oct 8, 2018 at 11:16 AM Showndarya<EMAIL_ADDRESS>wrote:

Closed #368 https://github.com/Showndarya/Hacktoberfest/pull/368.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Showndarya/Hacktoberfest/pull/368#event-1889434757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AiUozC5Dw4nDH3u9y_P4t_p-3wTL2a1Fks5uiubBgaJpZM4XMSFm
.


Parsing a OSCMessage

Hello there,
I'm having trouble to get to the data of any OSCMessage I'm getting. The example does not appear to compile with Swift 4.2.1
class OSCHandler: OSCServerDelegate {

    func didReceive(_ message: OSCMessage){
        if let integer = message.arguments[0] as Int {
            print("Received int \(integer)"
        } else {
            print(message)
        }
    }
}
server.delegate =  OSCHandler()

I'm getting the following: "'OSCType?' is not convertible to 'Int'; did you mean to use 'as!' to force downcast?" (and the typo with the missing ")" in the print statement).
I have to say I'm a complete beginner with Swift and this might be obvious for experts, but would you mind providing a working example where you go from didReceive to extracting for example a Int and a String? (And maybe do type checking?)

Yeah you have to cast it. Probably a slightly different syntax with Swift 4.2.1. I’m working on an updated version.
In the meantime you can use as! If you’re confident nothing else but an Int is but it’s saver to use as?.
You can see an example in the example project https://github.com/devinroth/SwiftOSC/blob/master/Examples/macOS/OSCMonitor/OSCMonitor/TableData.swift https://github.com/devinroth/SwiftOSC/blob/master/Examples/macOS/OSCMonitor/OSCMonitor/TableData.swift

On Dec 19, 2018, at 9:13 PM, Alexis Andre<EMAIL_ADDRESS>wrote:
Hello there,
I'm having trouble to get to the data of any OSCMessage I'm getting. The example does not appear to compile with Swift 4.2.1
class OSCHandler: OSCServerDelegate {
func didReceive(_ message: OSCMessage){
    if let integer = message.arguments[0] as Int {
        print("Received int \(integer)"
    } else {
        print(message)
    }
}

}
server.delegate =  OSCHandler()
I'm getting the following: "'OSCType?' is not convertible to 'Int'; did you mean to use 'as!' to force downcast?" (and the typo with the missing ")" in the print statement).
I have to say I'm a complete beginner with Swift and this might be obvious for experts, but would you mind providing a working example where you go from didReceive to extracting for example a Int and a String? (And maybe do type checking?)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/devinroth/SwiftOSC/issues/30, or mute the thread https://github.com/notifications/unsubscribe-auth/AMaIEWPJU-krxiDWdC5_7JmL_9WhZM-dks5u6xxggaJpZM4ZbhjW.

Thanks!
This compiles and works with 4.2.1:
if let iid = data[0] as? Int{
  //do stuff
}

Seems obvious after reading more about optionals, apologies.


ReplicationStatus.complete should be completed

See https://github.com/noppoMan/aws-sdk-swift/blob/ae8b82371280086cf81c4525331c9b69e860f403/Sources/AWSSDKSwift/Services/s3/S3_Shapes.swift#L1516
But AWS docs uses COMPLETED: https://docs.aws.amazon.com/AmazonS3/latest/dev/crr-status.html
Hence under the current code, you can't get objects from any replicated buckets. Doing so will result in a DecodingError.

We need to update Models to recent one. Just moment please.

I see. I think even the official Amazon SDK got it wrong (complete vs. completed). Need to find somewhere to file a bug report.


Revert "Revert "Allow robots to crawl the site""

Reverts EasyDynamics/oscal-react-library#120 which reverted #119 which stemmed from #115. Let's have an actual conversation around whether we're ready to be crawled before moving forward with this PR.

I have been reading through a few articles as well for this issue. It seems like the most benefit we would receive from the addition of bots would be their help in achieving a high rank in searches - making our project easier to be found and searched for. I was curious, is there anything we would want to consider limiting crawler bots from crawling on? I think for the most part our project emphasizes good crawlability (see below for more details) and I don't think we have too much content that would cause bots to overtax the environment.
What is Crawlability? - Codesquad

is there anything we would want to consider limiting crawler bots from crawling on?

@rgauss would know better than us, but I can not think of something obvious that needs to be limited. Even if there were some pages we wanted to limit, adding those rules are trivial and wouldn't prevent us allowing bots to crawl the other pages.

We could just allow the Google robots with :
User-agent: Google
Disallow:

User-agent: *
Disallow: /

If we do want to allow any sort of crawling, we need to add certain meta tags to our index.html file
https://developers.google.com/search/docs/advanced/crawling/special-tags
We are using the default create-react-app meta tags, we need to update these to reflect OSCAL Viewer

If we do want to allow any sort of crawling, we need to add certain meta tags to our index.html file

Would that be within scope of this PR? If we agree on allowing bots, I can work on adding the meta tags.

I can no longer work on this issue. @rgauss or @kylelaker does allowing robots make sense?

I have no issue with allowing crawling of our sandbox deployment of the viewer app.
However, I'm not sure we want crawling enabled by default for others deploying the viewer app.
As such I think we can close this particular PR and if we have a strong desire to enable crawling for the sandbox environment we can revisit that in a PR to our infrastructure/pipeline repo.


Add a specific CODE_OF_CONDUCT.md file

Having a specific CODE_OF_CONDUCT.md file will allow GitHub to mention it at various places, ensuring people have more chances to be familiar with it.
Example of how GitHub takes benefit of the file:

Since, according to CONTRIBUTING.md, we are following Facebook's Code of Conduct, the same line repeated in the CODE_OF_CONDUCT.md file should be enough.
## Code of Conduct

Please refer to the **[Code of Conduct](https://engineering.fb.com/codeofconduct/)** adopted by Facebook to understand what kind of behaviour will and not be tolerated when contributing to this project

This can either be a Community default file as indicated by steps here, OR a repo specific file by adding it to docs/CODE_OF_CONDUCT.md alongside the CONTRIBUTING.md file.

@Amorpheuz thanks for pointing out! This issue has been resolved by @bhadreshpsavani


Certain props are rendered as much smaller than their preview

The preview of these props is the correct size the tile should render as, however when rendering the level these props will appear much smaller in the final product. Not all props are affected by this issue, however I am yet to find what the common trait between these small props is.
Correctly sized editor preview vs. significantly smaller ingame rendered prop:

this might be a drizzle problem.
try to render this level with official editor and drizzle, then compare them

Just tested rendering the same level using the official Downpour editor, props are still small.

does they small on preview as well or they same size?

Yes, the props are small in the downpour editor preview.

found issue, something wrong with both rendering and placing system
trying to fix

here is table of why props have x4 decreased size and the reason is buffertiles
will be fixed in next release

fixed with commit


Cli fails to list repo plugins

Please fill out the issue checklist below and provide ALL the requested information.

[x] I reviewed open and closed github issues that may be related to my problem.
[x] I tried updating to the latest version of the CF CLI to see if it fixed my problem.
[x] I attempted to run the command with CF_TRACE=1 to help debug the issue.
[x] I am reporting a bug that others will be able to reproduce.

Describe the bug and the command you saw an issue with
I am trying to execute cf repo-plugins -r CF-Community but fails with
Getting plugins from repository 'CF-Community' ... Logged errors: Invalid json data from 'CF-Community' - invalid character '<' looking for beginning of value
list of configured plugins repo urls:
cf list-plugin-repos
OK

Repo Name      URL
CF-Community   https://plugins.cloudfoundry.org

https://plugins.cloudfoundry.org is accessible through web browser
With set env CF_TRACE=1 doesn't show any additional details
Expected behavior
It supposed to return list of available plugins for installation.
Exact Steps To Reproduce
Steps to reproduce the behavior; include the exact CLI commands and verbose output:

cf list-plugin-repos
cf repo-plugins -r CF-Community

Provide more context

platform and shell details - MacOS Ventura 13.6, iTerm2
version of the CLI you are running - cf version 8.7.3+efd1d03.2023-09-12
version of the CC API Release you are on - 3.147.0

Still having these issues on cf version 8.7.7+583a09a.2023-12-26, using WSL / Ubuntu 22.04.3.
Any updates as to what is causing this? We're effectively blocked.

whoops forgot to link the prs here
https://github.com/cloudfoundry/cli/pull/2722
https://github.com/cloudfoundry/cli/pull/2731
https://github.com/cloudfoundry/cli/pull/2732

Appreciate the links - any idea when these would be released?

Bumping again...any updates on a release for this fix?

@theghost5800 Confirmed - appreciate the insights. Our build script stopped at a list check and we assumed all other repo operations were disrupted as well. Thank you!


chromedriver 75 - coypu failing to start a driver

with new version of chromdedriver v75 coypu fail to start browser, multiple acceptance test are failing

Funnily enough, I got hit with the #205 issue today and cracked open Coypu again to do an update pass. All tests happily pass on ChromeDriver 75 for me with no startup issues.

thanks for info, that simplifies release of new coypu version. Probably early next week.


shabka CLI

Implement the CLI described in #282
Closes #246
Closes #281
EDIT(2020-01-06 01:00:00 UTC):
TODO:

[ ] get dotshabka from default path
[ ] get shabka from default path or channel
[ ] shabka diff-host (maybe)
[ ] shabka help

I found a few issues, I'll list them here in a task list

[ ] Building with my master version of my dotshabka, I get an error, expected when the uname file is missing, but the command kept going. I think the release should be enforced. See log number 0 below.
[ ] I noticed that the uname now has the value NixOS. NixOS is not really a uname. We should keep uname set to Linux or Darwin and/or introduce a new file to signify the distribution.
[ ] I'm seeing the trace output of your function getConfigPath. I tracked that down to this. You should probably call getConfigPath outside the subshell to avoid the trace output of our own script. See log number 1.
[ ] I'm not able to run the check command. I'm getting the error nixos-rebuild: unknown option check'`. See the end of log number 1.
[ ] Related the one above. The check command was not found, but shabka still reported a success. See the end of log number 1.

log number 0
[INFO] Executing rebuild check on host hades
[ERR] Required file does not exist: /yl/code/personal/base/src/github.com/kalbasit/dotshabka/hosts/hades/uname
building '/nix/store/sqalr271si9fhyd0v614slyhm4l55blp-nixpkgs-release-19-09-eab4ee0c27c5c6f622aa0ca55091c394a9e33edd.drv'...
unpacking sources
unpacking source archive /nix/store/awfmbaljbaf2j14h6v9ny3zylfbv0x1s-source
^C
error: interrupted by the user

log number 1
 pure  λ  ./bin/shabka check
[INFO] Executing rebuild check on host hades
building '/nix/store/sqalr271si9fhyd0v614slyhm4l55blp-nixpkgs-release-19-09-eab4ee0c27c5c6f622aa0ca55091c394a9e33edd.drv'...
unpacking sources
unpacking source archive /nix/store/awfmbaljbaf2j14h6v9ny3zylfbv0x1s-source
source root is source
patching sources
applying patch /nix/store/n1yp1phc9ha6hddhl3qr7lyk6jxrsig6-fix-nvim-terraform-plugin.patch
patching file pkgs/misc/vim-plugins/overrides.nix
Hunk #1 succeeded at 390 (offset -12 lines).
patching file pkgs/misc/vim-plugins/vim-terraform-fix-event.patch
applying patch /nix/store/d250x6p2pzk92vj1bc0l7bywnmk83d21-76926-vim-direnv-hardcode-direnv-path.patch
patching file pkgs/misc/vim-plugins/overrides.nix
Hunk #1 succeeded at 14 with fuzz 2 (offset -3 lines).
Hunk #2 succeeded at 111 (offset 8 lines).
configuring
no configure script, doing nothing
building
installing
post-installation fixup
++ getConfigPath hades
++ desc='Get the configuration.nix path for a host.
        Usage: getConfigPath <host>
        Requires dotshabka_path to be set.'
++ declare -r host=hades
++ shift 1
++ declare -r config_path=/yl/code/personal/stories/shabka_cli/src/github.com/kalbasit/dotshabka/hosts/hades/configuration.nix
++ [[ -r /yl/code/personal/stories/shabka_cli/src/github.com/kalbasit/dotshabka/hosts/hades/configuration.nix ]]
++ echo /yl/code/personal/stories/shabka_cli/src/github.com/kalbasit/dotshabka/hosts/hades/configuration.nix
++ echoDebug1 config_path=/yl/code/personal/stories/shabka_cli/src/github.com/kalbasit/dotshabka/hosts/hades/configuration.nix
++ [[ 0 -lt 1 ]]
++ return
+ RELEASE=release-19-09
+ nixos-rebuild -I nixos-config=/yl/code/personal/stories/shabka_cli/src/github.com/kalbasit/dotshabka/hosts/hades/configuration.nix check
/run/current-system/sw/bin/nixos-rebuild: unknown option `check'
[SUCCESS] Finished rebuild check for host hades.

* [ ]  Building with my master [version of my dotshabka](https://github.com/kalbasit/dotshabka), I get an error, expected when the `uname` file is missing, but the command kept going. I think the `release` should be enforced. See log number 0 below.

I guess you mean that uname should be enforced, instead of release?
This is due to my use of subshells. Any idea how to fix this?

* [ ]  I noticed that the `uname` now has the value `NixOS`. `NixOS` is not really a uname. We should keep `uname` set to `Linux` or `Darwin` and/or introduce a new file to signify the distribution.

How do you feel about replacing the uname file with a distrib file?

* [ ]  I'm seeing the trace output of your function `getConfigPath`. I tracked that down to [this](https://github.com/kalbasit/shabka/blob/07fa8c436bd19853c7cd8ee26f0dc11a304df13c/bin/shabka#L243). You should probably call `getConfigPath` outside the subshell to avoid the trace output of our own script. See **log number 1**.

Fixed that.

* [ ]  I'm not able to run the `check` command. I'm getting the error `nixos-rebuild: unknown option `check'`. See the end of **log number 1**.

This command is only supposed to work on Darwin hosts.

* [ ]  Related the one above. The `check` command was not found, but shabka still reported a success. See the end of **log number 1**.

Same problem as before, subshells.

Usage: shabka [OPTION]... [COMMAND]... [ARGUMENTS]

Commands switch, activate and check
        shabka [-h host] [-r release] { switch | activate | check } [darwin-rebuild arguments and options]

Command build
        shabka [-h host] [-r release] build [nix-build arguments and options]

Command push-to-cachix
        shabka push-to-cachix <cache-name> [host1] [host2] [...]
If no host is specified, it defaults to all hosts defined in your .shabka folder.

By default the host is your current hostname. The release is the one defined in the host, if defined, else shabka's default release.
For more informations about the switch, boot, test, dry-build, dry-activate, activate and check commands, see nixos-rebuild(8) and darwin-rebuild(8).

In the Commands section. [darwin-rebuild arguments and options] is misleading on a NixOS machine.
Also, check is Darwin-only. Should we show check only on Darwin machines?

Also make no longer works. The Makefile is useful to avoid typing
	sudo --preserve-env=DOTSHABKA_PATH ./bin/shabka switch --show-trace

We can probably get rid of it once we have a default path to dotshabka.

Usage: shabka [OPTION]... [COMMAND]... [ARGUMENTS]

Commands switch, activate and check
        shabka [-h host] [-r release] { switch | activate | check } [darwin-rebuild arguments and options]

Command build
        shabka [-h host] [-r release] build [nix-build arguments and options]

Command push-to-cachix
        shabka push-to-cachix <cache-name> [host1] [host2] [...]
If no host is specified, it defaults to all hosts defined in your .shabka folder.

By default the host is your current hostname. The release is the one defined in the host, if defined, else shabka's default release.
For more informations about the switch, boot, test, dry-build, dry-activate, activate and check commands, see nixos-rebuild(8) and darwin-rebuild(8).

In the Commands section. [darwin-rebuild arguments and options] is misleading on a NixOS machine.
Also, check is Darwin-only. Should we show check only on Darwin machines?

If you look in the code, it actually only shows the right commands depending on the distribution (Linux non-Nixos not supported yet)

duck might fail because of https://github.com/kalbasit/shabka/pull/301


RenderTexture not working

I'm... trying, but it's not working. )

Hello, This workflow have been fixed with the latest release: https://github.com/alelievr/HDRP-UI-Camera-Stacking/releases/tag/1.1.0
You need to enable the "Render In Camera Buffer" option in the HDCameraUI component to make it work


feat: Validate images with help of mini_magick

Proof of concept that ensures that uploaded image is valid image.
Every blob is by default marked as validated: false and checked by background job which ensures that image is truly image. Checking itself is done with:
blob.update! validated: MiniMagick::Image.new(tempfile.path).valid?

Till image is validated, API returns null for picture fields --> I guess that FE will use some placeholder in this case.
Testing instructions
Testing is a bit tricky till there is no way how to run background jobs, but basically it can be done with:

create or update picture of project developer via swagger doc
check that null is returned because image is not validated yet
open console and manually run  ActiveStorage::ValidateImageJob.perform_now(YOUR_BLOB)
check that project developer info returned by API contains picture urls now

Tracking
https://vizzuality.atlassian.net/browse/LET-226

Hey @martintomas I was thinking that maybe we don't need to add anything extra and use default or add another analyzer. https://edgeapi.rubyonrails.org/classes/ActiveStorage/Blob/Analyzable.html

We could return placeholder until blob is analyzed?

I think when we have no dimensions after rails image analysis, then the image could be incorrect, or just not supported. https://github.com/rails/rails/blob/de53ba56cab69fb9707785a397a59ac4aaee9d6f/activestorage/lib/active_storage/analyzer/image_analyzer/image_magick.rb#L12

Hmm, that is actually good idea. I know that you have mentioned similar approach, but I have not connected all dots till now :). I will try to use your proposal --> correct image should have dimensions after analyzer is done. Looks better then have extra job for checking this. Could you be a bit more specific about We could return placeholder until blob @tsubik ? I think there are several approaches how to return placeholder:

return null and FE deals with the placeholder --> this way FE know that picture needs to be replaced by placeholder and can do some other stuff (like not make image clickable, or whatever)
save image at public folder
save image at Rails assets --> we will have just one variant of placeholder image
attach placeholder image as ActiveStorage blob --> allows us to have blob variants, but not sure how to do it :)

Ok. I think return null as you suggested is the easiest option.

I have refactored code based on your feedback @tsubik and I am using ActiveStorage::AnalyzeJob now. Looks so simple now ;)

Ahh, one thing that is missing. Please add imagemagick \ in Dockerfile


CHEF-3694 is back in Chef 15

Description
In some sophisticated cases there is possible to return back Chef-3694 bug in Chef 15 and probably on 16!
Tested on Chef 14, everything is fine, on 15.4.27 bug exist.
Replication Case
On any CentOS instance with Chef 15:
> chef-shell

recipe_mode
yum_package 'vim' do
  allow_downgrade false
end

package 'vim'

run_chef
chef_run.collection.each{|r| puts r.allow_downgrade}

false
true

Expected false/false in the end, on Chef 14 works as expected.

This is the expected behavior.  The first resource has allow_downgrade false, the second resource does not copy that setting (no resource cloning) from the first.
The difference in behavior is also likely due to the difference in the default values of allow_downgrade in 15 which was flipped to being true by default.

@lamont-granquist

the second resource does not copy that setting (no resource cloning) from the first.

It should, because package 'vim' during chef-run became yum_package 'vim', so its the same resource.


Create ATSOS::restartScheduler()

Create method to restart the ATSOS scheduler:
void ATSOS::restartScheduler();

This issue was resolved.


Add hyperlinks

What?
Adds PDFPage.drawLink() so users can add hyperlinks easily.
Why?
I personally needed to add several hyperlinks to a PDF. I added createPageLinkAnnotation per the suggestion in #555, got it working in our project, and then generalised it for broader use.
See also: #555, #691 , #980
How?
This follows @Hopding 's suggestion in #555.
I dug into the PDF Specification to double-check the possible setting for Border and Colour.
I have not provided all possible options; I wanted something simple and working before adding extra options.
Testing?
Added basic Unit test in PDFPage.spec.ts.
New Dependencies?
No.
Screenshots

Suggested Reading?
Yes, read the PDF Spec.
Anything Else?
Nope.
Checklist

[x] I read CONTRIBUTING.md.
[x] I read MAINTAINERSHIP.md#pull-requests.
[x] I added/updated unit tests for my changes.
[] I added/updated integration tests for my changes.
[] I ran the integration tests.
[x] I tested my changes in Node, Deno, and the browser.
[x] I viewed documents produced with my changes in Adobe Acrobat, Foxit Reader, Firefox, and Chrome.
[ ] I added/updated doc comments for any new/modified public APIs.
[x] My changes work for both new and existing PDF files.
[x] I ran the linter on my changes.

PS: the CircleCI build seems to be broken.


[lint] Demote licence warning in AscentLint parser

This should avoid spurious CI failures caused by the kokoro AscentLint instance warning that the licence will expire soon.

Looks like this change causes the following dvsim error, which crashes dvsim before it can run, causing the report to never be generated.

Overall, I like the idea of filtering out this warning to get things green again though :)

Huh, that's odd. It turns out that the list of buckets in the Python code in LintParser.py must match the list of buckets in the config file common_lint_cfg.hjson. I didn't realise this: oops!
I suspect the code could be refactored to be a little less spaghetti-ish, but maybe that's a problem for another day.

I've just force-pushed yet again, because it turns out that the license expiry message wasn't appearing in the HTML at all. Oops! I'm hoping that the most recent version will work properly. I've updated the commit message to describe how this all works. This is what it says about the changes we needed:

Modify LintParser so that if there are matches for two different
patterns that both start at the same character then we only
attach a match to the first matching bucket.

Tweak common_lint_cfg so that it knows about a new "info"
severity.

Tweak common_lint_cfg so that it knows about a new bucket
for the "flow" category, with "info" severity.

Declare this new "flow_info" bucket in LintParser.py

Add a "license will expire" pattern in
ascentlint-report-parser.py and assign matches to the new
"flow_info" severity.

This was... much harder than I expected! But I hope it will work now.

Latest force-push avoids accidentally sticking the entire tool log in the output (it turns out that if m is a Match object, then m.string gives you the string that it was matching on, rather than the match itself: oops! group(0) seems to give the thing we actually wanted).


setLifecycleHandler does not exist

Your QuickStart has the following
return Tracker.init(new Tracker.TrackerBuilder(emitter, "your-namespace", "your-appid", context)             .subject(subject) // Optional             .build()         ).setLifecycleHandler(activity);
But when I call setLifecycleHandler() in code I get an unresolved reference
I've found this commit, but it does not exist in the current code
Does the QuickStart need to be updated or has this been removed?

The docs do need to get updated - setLifecycleHandler was removed in a previous release. Omitting that method call should make it work. Let me know if that fixes things.

Closing for inactivity.


Add MetricsSystem case for Plugin type

What changes are proposed in this pull request?
Allows a Plugin process type to be launched w/ an associated metric registry name.
ref https://github.com/Alluxio/alluxio/pull/15314
Why are the changes needed?
See above.
Does this PR introduce any user facing changes?
No

alluxio-bot, merge this please


Plots not rendering in JupyterLab (Javascript Error: Cannot set property '1257' of undefined)

Just finished setting up everything by following the doc

Tried a very simple example in Chrome, but nothing seems to render in Jupyterlab

Am I missing something?

HoloViews 1.10.4 is pretty old at this point, could you try updating to 1.11.0 using:
conda install -c pyviz holoviews

# or
pip install holoviews

Unfortunately, the problem exists.

Btw, pip can only find 1.10.7 now.

Even when you clear the notebook and then reload the page?

I reinstalled the extensions by running the following:
jupyter labextension install @pyviz/jupyterlab_pyviz
It is working now. Thanks!
Btw, nteract also have some weird behaviors. Should I open a new issue?

I think a discussion about nteract is worth having. We should at least see how hard it would be to get that working so an issue would be appreciated.

I'm experiencing the same issue ("Javascript Error: Cannot set property '1005' of undefined", where the number changes each time.)  I'm on holoviews 1.11.3, bokeh 1.0.4, jupyterlab_bokeh 0.6.3, jupyterlab_pyviz 0.7.0 (see https://gist.github.com/keflavich/a9f23e2f21e3ca9e74e78f9a6e8dafae for the complete MWE + version list).  Is there still something wrong with my installation?

I was literally just encountering the same issue, I'll investigate and get back to you.

@keflavich Could you do me a favor, could you go into your browser developer console while in the JupyterLab and print the output of window.PyViz? I think there is a horrible bug in pyviz_comms that results in the variable being accidentally set to any DOM nodes of headers containing the words PyViz or HoloViews.

I'm not too familiar with the dev console; is this deep enough?
{kernels: {…}, init_slider: ƒ, init_dropdown: ƒ, comm_manager: JupyterCommManager}
comm_manager
:
JupyterCommManager
__proto__
:
Object
init_dropdown
:
ƒ init_dropdown(id, plot_id, dim, vals, value, next_vals, labels, next_dim, dim_idx, dynamic)
arguments
:
(...)
caller
:
(...)
length
:
10
name
:
"init_dropdown"
prototype
:
{constructor: ƒ}
__proto__
:
ƒ ()
[[FunctionLocation]]
:
widgets.js:133
[[Scopes]]
:
Scopes[2]
init_slider
:
ƒ init_slider(id, plot_id, dim, values, next_vals, labels, dynamic, step, value, next_dim, dim_idx, delay)
arguments
:
(...)
caller
:
(...)
length
:
12
name
:
"init_slider"
prototype
:
{constructor: ƒ}
__proto__
:
ƒ ()
[[FunctionLocation]]
:
widgets.js:36
[[Scopes]]
:
Scopes[2]
kernels
:
__proto__
:
Object
__proto__
:
constructor
:
ƒ Object()
hasOwnProperty
:
ƒ hasOwnProperty()
isPrototypeOf
:
ƒ isPrototypeOf()
propertyIsEnumerable
:
ƒ propertyIsEnumerable()
toLocaleString
:
ƒ toLocaleString()
toString
:
ƒ toString()
valueOf
:
ƒ valueOf()
__defineGetter__
:
ƒ __defineGetter__()
__defineSetter__
:
ƒ __defineSetter__()
__lookupGetter__
:
ƒ __lookupGetter__()
__lookupSetter__
:
ƒ __lookupSetter__()
get __proto__
:
ƒ __proto__()
set __proto__
:
ƒ __proto__()

... that formatted badly so here's a screenshot too:

That's perfect thanks, looks like we're not seeing the same issue then. While you're in the developer console can you rerun a plot and take a screenshot of the full error stack that shows up in the console?

I reloaded my browser window to get a clean error log (previously I had ~450 errors?), and suddenly the plot appeared.  I guess that suggests that this is some browser-related problem that maybe can be solved by refreshing?  I'm trying a more complicated example too, but for now, it looks like this problem resolved itself.

Glad to hear it! I recall having the same issue once or twice and it resolving itself. The next time it happens I'll investigate further.


Add node-sass filter support

Added the node-sass filter and tests.

Any news on this? Thanks.

any update on this? bootstrap 4 is around the corner, it's using sass by default... and there are people who would like to avoid installing ruby... :D

This MR is a must have, please review! :D
BTW @gremo, travis is failing. Could you please check?

@Soullivaneuh It seems something related composer not downloading form cssmin url:
[Composer\Downloader\TransportException]
Your configuration does not allow connections to http://cssmin.googlecode.c
om/files/cssmin-v3.0.1.php. See https://getcomposer.org/doc/06-config.md#se
cure-http for details.

Something I can't change. If you need to refactor or change the SASS filter code, just ask!

@gremo , you should use natxet/cssmin package (as Assetic is doing for tests), which is a clone from Google Code.

@aik099 @Soullivaneuh after rebasing the cssmin filter error is gone. Any help solving the remaining would be appreciated!

@gremo Seems to be unrelated failing test, I'll try to take a look.

@gremo please see https://github.com/kriswallsmith/assetic/pull/846

Just tested your filter @gremo, works great! :+1:

+1 it would be very useful this filter

Is there something I can do? Ping @Soullivaneuh

And... still waiting, after 10 months. Can we please check what needs to be done in order to get this merged, thanks?

Is there something I can do? Ping @Soullivaneuh

Unfortunately I'm not a maintainer of this project. cc @kriswallsmith

I ended up creating a new repository https://github.com/gremo/assetic-extra please contribute! Cheers!

Closing this PR as It will never be merged. Help me here: https://github.com/gremo/assetic-extra


[Feature]: Integrate External Credential Providers for Secure Datasource Configuration

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
I would like to request the integration of external credential providers, such as AWS Secret Manager and HashiCorp Vault, into Appsmith. This feature would allow users to supply datasource credentials directly through these secure external services without having to manually enter sensitive information into the Appsmith UI.
Use Case
Currently, entering credentials for datasources within Appsmith requires inputting sensitive information directly into the platform. By integrating with these services, Appsmith can enhance security by:

Minimizing the exposure of sensitive credentials.
Leveraging industry-standard secret management tools that are already in use within organizations.
Automating credential rotation and management.

Possible Implementation
The implementation could involve:

Adding support in the Appsmith backend to fetch credentials from specified secret managers.
Extending the UI to allow users to configure the connection to these external services, specifying which secret manager to use and the necessary access details.
Dynamic fetching of credentials at runtime, ensuring that datasource configurations are always up to date with the latest credentials as managed by the secret managers.

Why should this be worked on?
This feature would significantly increase the security posture of applications built on Appsmith by ensuring that sensitive credentials are not exposed within the platform and are managed through a centralized, secure mechanism. It would also make Appsmith a more attractive option for enterprise environments where strict security compliance standards are necessary.
Additional Context
Many organizations already use tools like AWS Secret Manager and HashiCorp Vault for their internal applications and would benefit from seamless integration with Appsmith for managing application configurations and credentials.

Related issues:

#33362
#28414

@LagunaElectric We already have this feature open so I don't see you ar opening a new one.

@Nikhil-Nandagopal The other two requests are for specific platforms, and I created this after the Hashicorp request because I think it would be better to support external providers in general. I think this issue is more robust because it would pave the way to allow any external provider we choose to support such as Doppler, Cyberark, Azure Key Vault, etc. In my mind I imagined this issue as an Epic with those two existing feature requests as the first two integrations.
I can imagine a checkbox or toggle during datasource configuration to decide wether to enter credentials manually or use an external provider. If they choose to use a provider they would be able to select one from a dropdown and configure it with their datasource. Maybe they can connect to their secrets managers at the workspace level, and then reference those connections in their datasource configurations.

We have a general request here #7454 so there isn't a need for a new one. I think we're covered and we'll figure out the right solution


AmbiguousMatchException-The request matched multiple endpoints in Dotnet Core 3.0 Web API

version 1.0 controller:
using Microsoft.AspNetCore.Mvc;

namespace Web.API.VersioningTest1.Controllers
{
    [ApiVersion("1.0")]
    [Route("monkeys")]

    public class MonkeysController : ControllerBase
    {
        [HttpGet]
        public IActionResult Get()
        {
            var monkey = new { Id = 1, Name = "Forest Monkey" , version = "1.0" };
            return Ok(monkey);
        }
    }
}

Version 2.0 Controller
using Microsoft.AspNetCore.Mvc;

namespace Web.API.VersioningTest1.Controllers
{
    [ApiVersion("2.0")]
    [Route("monkeys")]
    public class MonkeysV2Controller : ControllerBase
    {
        [HttpGet]
        public IActionResult Get()
        {
            var monkey = new { Id = 1, Name = "Forest Monkey", version = "2.0" };
            return Ok(monkey);
        }
    }
}

version configuration in Startup.cs
 services.AddApiVersioning(options => {
                options.AssumeDefaultVersionWhenUnspecified = true;
                options.ReportApiVersions = true;
            });

my test url's:
https://localhost:44306/monkeys?api-version=1.0
https://localhost:44306/monkeys?api-version=2.0
Results:

AmbiguousMatchException: The request matched multiple endpoints. Matches: Web.API.VersioningTest1.Controllers.MonkeysController.Get (Web.API.VersioningTest1) Web.API.VersioningTest1.Controllers.MonkeysV2Controller.Get2 (Web.API.VersioningTest1)

This is because your controllers do not have [ApiController] applied to them. A controller is a controller in ASP.NET Core, which means there isn't a clear way to disambiguate between a UI controller and an API controller controller. Furthermore, there are no requirements on base class (e.g. ControllerBase). Some people mix UI controllers and API controllers in the same project, but don't want to enforce versioning semantics on UI controllers (for good reason). ASP.NET Core introduced the concept of API Conventions and behaviors back in 2.x. API Versioning uses this information to apply a convention for versioning. If a controller does not include [ApiController] it will be excluded from versioning by default. This behavior can be changed in a couple of ways. You can set options.UseApiBehavior = false (which has defaulted to true since 3.0) or you can replace the default filtering conventions with your own.

Adding [ApiController] fixed the versioning issue
Thanks


Update ProductsController.cs

@wadepickett  this is the correct controller.

That and a bunch of unneeded includes

That and a bunch of unneeded includes

I was following what was in the previously approved version, but should not have.  I can either leave in the default includes or instruct to remove them so the user understands the change.  I will make sure I always remove.  Thanks.


Refactor dataset updates but dont support private datasets

This PR contains the refactoring needed for supporting the private datasets (https://github.com/huggingface/datasets-server/pull/2224), saving the support for private datasets itself.
The most important part is that we now control a dataset only with:

operations.update()
operations.delete()
It's where we check if a dataset is supported (blocked, private, viewer is disabled, etc)

Once a job has been created, we consider the dataset as supported, and we don't check it anymore in the next steps.
Also:

refactor the tests a bit to speed up the e2e tests, and to reduce complexity
remove two unused (I think) admin endpoints: /backfill-plan and /backfill (and remove them from admin UI)
delete the assets and cached_assets from a dataset when we call operations.delete_dataset, which removes the need to run a cron job to delete obsolete assets
the backfill job is different: it only checks the current entries in the database to complete them if needed, or delete them if they are not supported anymore. It does not allow anymore to add a dataset that was not in the database. Anyway, if a dataset page is loaded, and the dataset is missing from the cache, a new job will be created immediately, so... not so important, I think.
more tests

It makes me wonder if there is an opportunity to make the BackFillPlan run faster (couldn't check on Grafana how much time it takes though)

Maybe... do you have an idea?

thanks both for the review!


💄 Add snazzy theme

I couldn't find the original source so I set the link to bubbletint docs.

Thanks for the pull request!
I'm actually adding the options which has a theme selector. All 280 tints will be available.


Mess with shell when length is more than one line

Windows 10 Version 10.0.17763.864
Terminus V 0.97
When I connect through SSH and the length of username-path-command excedes one line then the shell becomes messy and characters get written on each other, sometime the active line becomes invisible, or a new line appears but can't really be used. This happens also if you restrict the window manually, I think the problem is connected with a missing return line somewhere.

Not related to Terminus


Upgrade django-taggit to 1.x

django-taggit 1.x drops Python 2.x support and thus the dependency on django.utils.six; this is a prerequisite for supporting Django 3.0.
The signature of TaggableManager.value_from_object has changed to return a list of Tags (previously it was a QuerySet of TaggedItems) and so search indexing and comparison need to be updated accordingly. There is a corresponding fix to ClusterTaggableManager in django-modelcluster 5.0.

Tested locally, tags work as expected after upgrade, thanks @gasman
Note: I did not add anything to the upgrade considerations in the release notes for this.
merged in via https://github.com/wagtail/wagtail/commit/34c1b4ccbe4a143492ae534e95bf61a160104a9f


Fixed highlights service

We needed to use the IDocumentHighlightsService from CodeAnalysis.DocumentHighlighting as the one from CodeAnalysis.Editor is gone.

For reference, this is the commit in Roslyn going into 15.8: https://github.com/dotnet/roslyn/commit/877537101920994db0cbb7fd3bcf25bb391860eb


Add support for Exasol

CATEGORY
Choose one

[ ] Bug Fix
[✓] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY
Exasol describes itself as a "high-performance, cloud-first analytics database", which could be a good addition to Superset's arsenal of databases. sqlalchemy_exasol (https://github.com/blue-yonder/sqlalchemy_exasol), which uses ODBC, is the sqlalchemy dialect that we used. A change in the SupersetDataFrame class is necessary to get access to data via the SQL Lab.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[✓] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS

I tried starting the exasol dev container from here: https://github.com/exasol/docker-db, installed the exasol 6.2.1 driver (MacOS) and the blue-yonder sqlalchemy connector, but was not able to connect Superset to it. Any idea what the odbc.ini file should look like on MacOS? Not sure where the .so file goes.. Anyway, this is the error I'm getting on Superset:

Many thanks for taking the time to replicate the issue.
I'm also on Mac and set up superset with http://superset.incubator.apache.org/installation.html#start-with-docker. Inside the container I created odbc.ini with the config_odbc tool (which, together with the driver can be downloaded from https://docs.exasol.com/connect_exasol/drivers/odbc/odbc_linux.htm). After running the above script, odbcinst -j should list USER DATA SOURCES..: /root/.odbc.ini. As a final step the contents of odbc.ini should be manually changed (after variables are changed accordingly) to
root@307bbaccb9d6:/home/superset# cat /root/.odbc.ini
[EXAODBC]
DRIVER = /root/.driver/EXASOL_ODBC-6.1.5/lib/linux/x86_64/libexaodbc-uo2214lv2.so
EXAHOST = host.docker.internal:8563
EXASCHEMA = schema

Then in Python's REPL I can query with:
>>> from sqlalchemy import create_engine
>>> e = create_engine("exa+pyodbc://user:password@EXAODBC")
>>> e.connect()
>>> e.execute("select * from table LIMIT 1").fetchall()

I added the _time_grain_functions and implemented a try/except solution which at least is driver independent. I understand that this less than ideal, so happy to hear your thoughts.

Codecov Report

Merging #8343 into master will decrease coverage by 0.16%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #8343      +/-   ##
==========================================
- Coverage   67.69%   67.53%   -0.17%
==========================================
  Files         447      448       +1
  Lines       22653    22529     -124
  Branches     2363     2363
==========================================
- Hits        15336    15216     -120
+ Misses       7179     7175       -4
  Partials      138      138

Impacted Files
Coverage Δ

superset/db_engine_specs/exasol.py
66.66% <66.66%> (ø)

superset/db_engine_specs/sqlite.py
54.83% <0%> (-16.13%)
:arrow_down:

superset/db_engine_specs/presto.py
64.91% <0%> (-5.07%)
:arrow_down:

superset/assets/src/SqlLab/reducers/sqlLab.js
42.85% <0%> (-0.84%)
:arrow_down:

superset/dataframe.py
93.7% <0%> (-0.79%)
:arrow_down:

superset/assets/src/SqlLab/actions/sqlLab.js
60.45% <0%> (-0.32%)
:arrow_down:

superset/db_engine_specs/hive.py
40.18% <0%> (-0.19%)
:arrow_down:

superset/utils/core.py
88.41% <0%> (-0.17%)
:arrow_down:

superset/db_engine_specs/clickhouse.py
60% <0%> (ø)
:arrow_up:

superset/db_engine_specs/druid.py
100% <0%> (ø)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9596935...9e92ad5. Read the comment docs.


experimental doc service route guessing

Motivation:

#4482

Modifications:
Add cfg.route() of the DocService to the ServiceSpecification as an optional value.
Result:
Example URL: http://<IP_ADDRESS>:9000/proxy/docs/#/methods/armeria.grpc.testing.TestService/UnaryCallWithAllDifferentParameterTypes/POST
Previously it sent requests to http://<IP_ADDRESS>:9000/test/armeria.grpc.testing.TestService/UnaryCallWithAllDifferentParameterTypes
but in reality it should be
URL: http://<IP_ADDRESS>:9000/proxy/test/armeria.grpc.testing.TestService/UnaryCallWithAllDifferentParameterTypes
Because DocService is bound under /docs not /proxy/docs.
To emulate, you can create the following proxy service:
    sb
        .virtualHost(9000)
        .serviceUnder("/proxy/", ProxyService())

// Under ProxyService

class ProxyService(val config: ProxyConfiguration) : HttpService {
    override fun serve(ctx: ServiceRequestContext, req: HttpRequest): HttpResponse {
        val r2 = req.mapHeaders { headers -> headers.toBuilder().path(req.path().replace("/proxy", "")).build() }
        return client.execute(r2) // WebClient
    }
}

ditto,
I have a 3 day weekend, have some time to finalize my PRs.

Hey folks, I want to merge this if possible. We can't still use doc service for our staging services in my company so with this change I can promote usage of Doc service 🙂

Hey folks, I want to merge this if possible. We can't still use doc service for our staging services in my company so with this change I can promote usage of Doc service 🙂

Thanks for the reminder. Will try to get review/get this merged in the next release.

Sorry I must have missed that 😓
I'll get into it tomorrow 👍

Gentle ping @jrhee17 @minwoox

@minwoox finally had some time to address the issues while waiting in the airport 😄 Let me know what you think, excited to have this feature in the next release 😄


MicroPython Firmware none existant

the link to the micropython firmware leads nowhere

"setup is a breeze"....
It would be if the uf2 file was anywhere to be found.
The broken link to no file appears on github and your pico product pages, please fix asap.
For the experts this won't be a show-stopper, but for people wanting a nice, simple plug and play experience with a pico explorer or rgb base, it's not good at all.

"setup is a breeze"....
It would be if the uf2 file was anywhere to be found.
The broken link to no file appears on github and your pico product pages, please fix asap.
For the experts this won't be a show-stopper, but for people wanting a nice, simple plug and play experience with a pico explorer or rgb base, it's not good at all.

The SDK and MicroPython port were in constant flux prior to release and even now have bugs and issues. Pico is going to have a rocky start I’m afraid. The product pages may be a touch optimistic. We’ll get there.
Yes the alpha release - and future releases - supplied in the release section of this GitHub repository are the firmware you should be using.

The SDK and MicroPython port were in constant flux prior to release and even now have bugs and issues. Pico is going to have a rocky start I’m afraid. The product pages may be a touch optimistic. We’ll get there.
Yes the alpha release - and future releases - supplied in the release section of this GitHub repository are the firmware you should be using.

You can find the releases section here which also includes links to download pre-compiled (.uf2 files) of our MicroPython firmware: https://github.com/pimoroni/pimoroni-pico/releases

You can find the releases section here which also includes links to download pre-compiled (.uf2 files) of our MicroPython firmware: https://github.com/pimoroni/pimoroni-pico/releases


⚠ DesiTorrents has degraded performance

In 8b84b11, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 2708 ms

Resolved: DesiTorrents performance has improved in 64840da.


Run the upgrade and downgrade tests in the upgrade prow job

Fixes #310
Proposed Changes

This PR adds the execution of upgrade and downgrade tests into the operator prow job.
This PR refactors the e2e-common script, to accommodate the changes in upgrade tests.
This PR adds the deployment verification for Knative in operator's upgrade tests.

Release Note

@houshengbo any instructions to run this test locally? I couldn't on Minikube and on OpenShift

@aliok this is good question, but it seems to me that running the tests against GKE is the ONLY way to verify the tests.

but it seems to me that running the tests against GKE is the ONLY way to verify the tests.

then it lgtm as things pass on GKE. I created https://github.com/knative/serving-operator/issues/317 so that I don't forget it and hopefully make things working later.
/lgtm


Set up telemetry dashboard

@imatiach-msft  -- what do you think is the estimated effort for setting up the telemetry dashboard for interpret-text-contrib similar to the one for interpret-community?

@minthigpen I think it should be a couple of days of dev work - the pypi download statistics and runs on amlcompute

@imatiach-msft and @wamartin-aml  had this covered earlier this year.


Heap Sort

🚀 Feature
Heap Sort Implementation
-Heap sort is a comparison based sorting technique based on Binary Heap data structure. It is similar to selection sort where we first find the maximum element and place the maximum element at the end. We repeat the same process for remaining element.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
Heap sort is one of the basic sorting algorithm.  Its time complexity is O(nlogn).
Pitch
Heap sort algorithm has limited uses because Quicksort and Mergesort are better in practice. Nevertheless, the Heap data structure itself is enormously used. Heap sort can be used in problems like where we need to sort almost sorted array and so on.
Languages Supported:

C [@rgrupesh]
CPP [@bagladivyang03]
Python [@avinashkranjan]
Java
JavaScript
C#
GO

I would like to do in c++ pls assign @atarax665

@bagladivyang03 You can start working on this in C++.
Happy Coding!

I want to work in C.

I would like to work on this issue in python @atarax665

@rgrupesh You can start working in C.
@avinashkranjan You can work on this issue in Python.
Go through the contribution guidelines if you haven't yet. #398
Happy Coding!

@atarax665 you already have a heap_sort.py in NeoAlgo/Python/sort/.. Do you still me to push my verison of code??

@atarax665 is this included for Contributor's Hack? I would like to do this in Java
Also please put CH20 tag if it is being considered for it.

@atarax665 you already have a heap_sort.py in NeoAlgo/Python/sort/.. Do you still me to push my verison of code??

@avinashkranjan I want you to modify the existing heap_sort.py file as the existing code doesn't have driver code, proper documentation and functions need to be refactored.

@siddharth25pandey could you also put a difficulty tag on this issue? It will help all the assigned contributors to keep track of their progress.

I would like to work on this issue in C @atarax665

@atarax665 @iamrajiv please add a difficulty label to this issue.


Codespaces default image missing libbz2-dev

Hi,
I'm currently testing the new codespaces feature for a Python project and encountered the following error:
After having installed pandas via pypi and trying to import (import pandas as pd) it, I get the error message:
error: ModuleNotFoundError: No module named '_bz2'
Installing libbz2-dev via a sudo apt-get followed by copying /usr/lib/python3.8/lib-dynload/_bz2.cpython-38-x86_64-linux-gnu.so to the /workspaces/$PROJECTNAME/.venv/lib/python3.8/site-packages/ folder helped.
I see that in https://github.com/microsoft/vscode-dev-containers/blob/main/containers/codespaces-linux/.devcontainer/library-scripts/python-debian.sh libbz2 gets installed if Python is installed from source, but otherwise I wonder why it's missing when installing from PPA.

VSCode Version: latest codespaces version
Local OS Version: Win 10 Version 21H1 (should not matter)
Reproduces in: Codespaces
Name of Dev Container Definition with Issue:

Steps to Reproduce:

Open Python repository
Create new workspace from repository
Wait for automated setup & installs
Enter virtualenv (not sure why the default terminal does not have the venv activated by default..)
Open python
Try import pandas as pd

Maybe someone has an idea, would be much appreciated. A quick fix would be to create my own image or define a non-PPA Python version in my config file I guess.
Best,
cl1ent

@cl1ent Is this in the default codespaces image? (A PPA is not used to install there is why I ask.)
//cc: @joshspicer

@Chuxel yes, I have not selected a specific version or have a devcontainer.json file. do you have a way to confirm this within codespaces? CTRL+Shift+P and running "Codespaces: Details" does not reveal much information on the used image etc.

You can open a terminal and type devcontainer-info to get details about what you are using. Given what you describe, I'm assuming the Definition ID field will say codespaces-linux.

Yes, indeed
Development container image information

- Image version: 1.6.3
- Definition ID: codespaces-linux
- Source code repository: https://github.com/microsoft/vscode-dev-containers/
- Source code release/branch: v0.191.1
- Timestamp: Fri, 13 Aug 2021 23:23:36 GMT

+1 on the hit count. Another Codespaces user contacted GitHub Support with this same issue.

able to repro:

Hi. I hit the same problem. For me specifically, this prevents the default container's (default) Python from importing package dvc when installed globally with pip.

@jorgeorpinel - are you sourcing the virtual environment that gets created, or the python install from the .python folder?
eg (with no (venv) in the prompt):
codespace ➜ /workspaces/almost-empty (main ✗) $ which python
/home/codespace/.python/current/bin/python
codespace ➜ /workspaces/almost-empty (main ✗) $

Interestingly, missing some different module when running outside the virtual env (after installing deps).

issue repros from the source oryx image

Expand for details
vscode ➜ /workspaces/docker-from-docker (main) $ docker run --rm -it mcr.microsoft.com/oryx/build:vso-focal-20210902.1

root@0ba1d0e7d57f:/vscode-remote-try-python# l
LICENSE  README.md  app.py  disabled.dcont/  requirements.txt  static/
root@0ba1d0e7d57f:/vscode-remote-try-python# git branch
* (HEAD detached at origin/universal-img)
  main
root@0ba1d0e7d57f:/vscode-remote-try-python# oryx build -p virtualenv_name=.venv --log-file /tmp/oryx-build.log --manifest-dir /tmp
Operation performed by Microsoft Oryx, https://github.com/Microsoft/Oryx
You can report issues at https://github.com/Microsoft/Oryx/issues

Oryx Version: 0.2.20210902.1, Commit: a72ec250bb229f96c55cae8df7800337738fa178, ReleaseTagName: 20210902.1

Build Operation ID: |fIJAPnCTypw=.43209bb8_
Repository Commit : 5bb4d0ddd6c87470130bfd1937128e20839d7845

Detecting platforms...
Detected following platforms:
  python: 3.8.6

Source directory     : /vscode-remote-try-python
Destination directory: /vscode-remote-try-python

Python Version: /opt/python/3.8.6/bin/python3.8
Creating directory for command manifest file if it doesnot exist
Removing existing manifest file
Python Virtual Environment: .venv
Creating virtual environment...
Activating virtual environment...
Running pip install...
[16:10:22+0000] Collecting flask
[16:10:22+0000]   Downloading Flask-2.0.1-py3-none-any.whl (94 kB)
[16:10:23+0000] Collecting pandas
[16:10:23+0000]   Downloading pandas-1.3.3-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (11.5 MB)
[16:10:23+0000] Collecting Werkzeug>=2.0
[16:10:23+0000]   Downloading Werkzeug-2.0.1-py3-none-any.whl (288 kB)
[16:10:23+0000] Collecting Jinja2>=3.0
[16:10:23+0000]   Downloading Jinja2-3.0.1-py3-none-any.whl (133 kB)
[16:10:23+0000] Collecting itsdangerous>=2.0
[16:10:23+0000]   Downloading itsdangerous-2.0.1-py3-none-any.whl (18 kB)
[16:10:23+0000] Collecting click>=7.1.2
[16:10:23+0000]   Downloading click-8.0.1-py3-none-any.whl (97 kB)
[16:10:23+0000] Collecting pytz>=2017.3
[16:10:23+0000]   Downloading pytz-2021.1-py2.py3-none-any.whl (510 kB)
[16:10:24+0000] Collecting numpy>=1.17.3
[16:10:24+0000]   Downloading numpy-1.21.2-cp38-cp38-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (15.8 MB)
[16:10:24+0000] Collecting python-dateutil>=2.7.3
[16:10:24+0000]   Downloading python_dateutil-2.8.2-py2.py3-none-any.whl (247 kB)
[16:10:24+0000] Collecting MarkupSafe>=2.0
[16:10:24+0000]   Downloading MarkupSafe-2.0.1-cp38-cp38-manylinux2010_x86_64.whl (30 kB)
[16:10:24+0000] Collecting six>=1.5
[16:10:24+0000]   Downloading six-1.16.0-py2.py3-none-any.whl (11 kB)
[16:10:24+0000] Installing collected packages: Werkzeug, MarkupSafe, Jinja2, itsdangerous, click, flask, pytz, numpy, six, python-dateutil, pandas
[16:10:30+0000] Successfully installed Jinja2-3.0.1 MarkupSafe-2.0.1 Werkzeug-2.0.1 click-8.0.1 flask-2.0.1 itsdangerous-2.0.1 numpy-1.21.2 pandas-1.3.3 python-dateutil-2.8.2 pytz-2021.1 six-1.16.0
WARNING: You are using pip version 20.2.1; however, version 21.2.4 is available.
You should consider upgrading via the '/vscode-remote-try-python/.venv/bin/python -m pip install --upgrade pip' command.
vso-focal
PlatformWithVersion=Python 3.8.6
BuildCommands=/opt/python/3.8.6/bin/python3.8 -m venv .venv --copies --system-site-packages
 ,  , python -m pip install --cache-dir /usr/local/share/pip-cache --prefer-binary -r requirements.txt | ts [%T%z]
Removing existing manifest file
Creating a manifest file...
Manifest file created.

Done in 12 sec(s).
root@0ba1d0e7d57f:/vscode-remote-try-python# source .venv/
bin/        include/    lib/        lib64/      pyvenv.cfg
root@0ba1d0e7d57f:/vscode-remote-try-python# source .venv/bin/activate
(.venv) root@0ba1d0e7d57f:/vscode-remote-try-python# ls
LICENSE  README.md  app.py  disabled.dcont  requirements.txt  static
(.venv) root@0ba1d0e7d57f:/vscode-remote-try-python# python app.py
Traceback (most recent call last):
  File "app.py", line 7, in <module>
    import pandas as pd
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/__init__.py", line 50, in <module>
    from pandas.core.api import (
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/core/api.py", line 48, in <module>
    from pandas.core.groupby import (
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/core/groupby/__init__.py", line 1, in <module>
    from pandas.core.groupby.generic import (
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/core/groupby/generic.py", line 73, in <module>
    from pandas.core.frame import DataFrame
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/core/frame.py", line 129, in <module>
    from pandas.core import (
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/core/generic.py", line 122, in <module>
    from pandas.core.describe import describe_ndframe
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/core/describe.py", line 39, in <module>
    from pandas.io.formats.format import format_percentiles
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/io/formats/format.py", line 99, in <module>
    from pandas.io.common import stringify_path
  File "/vscode-remote-try-python/.venv/lib/python3.8/site-packages/pandas/io/common.py", line 4, in <module>
    import bz2
  File "/opt/python/3.8.6/lib/python3.8/bz2.py", line 19, in <module>
    from _bz2 import BZ2Compressor, BZ2Decompressor
ModuleNotFoundError: No module named '_bz2'
(.venv) root@0ba1d0e7d57f:/vscode-remote-try-python#

Messaging the oryx team for their opinion
cc/ @arroyc

Change is in PR: https://github.com/microsoft/Oryx/pull/1117/files#diff-e6fb817bdfbad97c81ad38f4f4da12cc1e73ca0eb0f2c47100663d7d020d8b00R28
Pair programmed with Arjun a bit and he walked me through the process for a change like this.  A change to the SDKs that oryx pulls as part of a dynamic installation does NOT require an image bump in our kitchensink image.
@arroyc will give me the magic signal once the SDK update is live so I can validate.

Oryx's SDK updates fix specific issue with pandas.

This will get picked up automatically as this is part of the dynamic installation bit of Oryx.
@jorgeorpinel - please let me know if you're still hitting your problem. As a workaround now you (may) be able to source the dynamically created virtual environment


LSNBLDR-585; return message uses page title

I don't know much about the technical parameters involved in making and merging PRs. While we like to give developers credit for work, and it can help to track regressions that occur as a result of contributions, we also need to be mindful of efficiency and putting too much work on core developers. Plus, in general, more work may mean more chance for errors to be made?
Probably needs a Sakai core team discussion.

Yes. According to the documentation I’ve seen, the only way to change the author of a commit is to rewrite history back to that point. The documentation warns that this shouldn’t be done lightly. For 585 I did a new commit that made formatting changes to all lines, showing the right author. So “git blame” will show him as author of all the lines, and the log will show him as the last committer.
That’s not a quick process, and in my view any change to code requires at least some level of testing. So I’ll do it for others if they ask, but not otherwise.
In the future I’m going to do two separate commits for PR’s, one with the original PR and one with changes I make to it. Because normally I don’t want the unmodified PR to go up on servers, that means fetching the PR, committing it with —author and then doing my commit.
You know my feelings about the overcomplexity of git. This just makes it worse. I really, really prefer svn, where I can commit a set of files and know exactly what’s going to happen.
On Apr 29, 2016, at 9:20:46 AM, Neal Caidin <notifications<EMAIL_ADDRESS>wrote:
I don't know much about the technical parameters involved in making and merging PRs. While we like to give developers credit for work, and it can help to track regressions that occur as a result of contributions, we also need to be mindful of efficiency and putting too much work on core developers. Plus, in general, more work may mean more chance for errors to be made?
Probably needs a Sakai core team discussion.
—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHubhttps://github.com/sakaiproject/sakai/pull/2371#issuecomment-215709039