[SPARK-29888][SQL] new interval string parser shall handle numeric with on fractional part

What changes were proposed in this pull request?

Current string to interval cast logic does not support i.e. cast('.111 second' as interval) which will fail in SIGN state and return null, actually, it is 00:00:00.111.
-- !query 63
select interval '.111 seconds'
-- !query 63 schema
struct<0.111 seconds:interval>
-- !query 63 output
0.111 seconds

-- !query 64
select cast('.111 seconds' as interval)
-- !query 64 schema
struct<CAST(.111 seconds AS INTERVAL):interval>
-- !query 64 output
NULL

Why are the changes needed?

bug fix.
Does this PR introduce any user-facing change?

no
How was this patch tested?

add ut

cc @cloud-fan @MaxGekk, thanks in advance. this pr is raised via comment @ https://github.com/apache/spark/pull/26491#discussion_r346151299

Test build #113760 has started for PR 26514 at commit 74f8435.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18635/
Test PASSed.

Test build #113761 has started for PR 26514 at commit 314829d.

Test build #113760 has finished for PR 26514 at commit 74f8435.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #113761 has finished for PR 26514 at commit 314829d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113761/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113760/
Test FAILed.

retest this please

Test build #113765 has started for PR 26514 at commit 314829d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18638/
Test PASSed.

Test build #113765 has finished for PR 26514 at commit 314829d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113765/
Test PASSed.

Test build #113792 has started for PR 26514 at commit 76ba7ef.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/18664/
Test PASSed.

Test build #113792 has finished for PR 26514 at commit 76ba7ef.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/113792/
Test PASSed.

thanks, merging to master!

thanks for merging


Fixes #5 and some updates to the general look of the UI

Mostly applies the revisions to the previous pr
Also make the UI automatically update with the user changes

This should probably only be merged after the admin CRUD pr is

Merged this as I believe the action failures are due to the branch being in a fork.


[MINOR] add console-producer and basic test

Noticed that we didn't have a way of producing arbitrary messages so I added a wrapper service around the kafka_console_producer.sh script.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

The main reason I found this class useful was that VerifiableProducer does not support producing arbitrary messages - it'll always use incrementing integer values. This may be useful for some tests that use some defined schema for a topic.
Another reason this class seems useful is that it gives us the ability to ad-hoc produce (rather than produce N messages, then exit). So you can produce a single message, test for consumption, then produce another.
I'm assuming these reasons align with why we maintain both the kafka-console-producer.sh and kafka-verifiable-producer.sh shell scripts.

I agree with some of the motivation, but seems that even then we'd probably want to have a strong case to introduce and maintain a separate class for these features. As the verifiable producer states:
https://github.com/apache/kafka/blob/trunk/tests/kafkatest/services/verifiable_producer.py#L34
this type of classes are treated as public interface, so the commitment is a bit higher than other internal classes.
W/r/t arbitrary messages, I can imagine this to be useful for benchmarking but maybe not so much for testing certain expectations, in which case troubleshooting could be harder because of the randomness factor.


ShirukaWorldBorder.java:190:...

The puzzle 1-ab39edc6 from #1 has to be resolved:
https://github.com/shiruka/shiruka/blob/2d4fd18edd89ca67db88ccfe8c4a55ac9bb4690f/src/main/java/io/github/shiruka/shiruka/world/options/ShirukaWorldBorder.java#L190-L190
The puzzle was created by Hasan Demirtaş on 27-Dec-20.
Estimate: 60 minutes,  role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 1-ab39edc6 has disappeared from the source code, that's why I closed this issue.

The puzzle 1-ab39edc6 has disappeared from the source code, that's why I closed this issue.


[Bug] Output flag only accepts relative paths and not absolute

When passing the output flag an absolute path, it will always be insterpreted as relative

Thanks for reporting @AZMCode .
Could you show me the result of executing the command when passing the output flag an absolute path?

I noticed I could not replicate when building from source, only from latest release.
When passing in an absolute path like /tmp/hello it would attempt to save to $PWD/tmp/hello

I forgot to release a new version after fixing this issue. Thanks!


fuzzing

summary
adds a starting point for fuzzing with cargo-fuzz following from #15
this is runnable as cargo fuzz run streams with libfuzzer assuming the subcommand is installed

@Ralith I've moved PR from draft to ready for review -- if I should rebase and squash please let me know, otherwise I will leave with you.

A rebase and squash would be great!

Thanks for working on this!


Fix centos aws cli again

The code tests if help of awscli is accessible and if that fails it removes the package awscli and installs it via pip.
Fix centos 7.6 aws cli, download it through pip if it's not working

/lgtm
/approve


Migrate Scrolling Ad to Lit

[x] Convert JS to Lit
[x] Convert CSS to be extendable
[x] Create description page

Implemented in https://github.com/YuraVolk/Js-Library/commit/5ccdeed9d15945a1e7af3d901888f45ea5c721aa


param mismatch on LOGIN path of auth_base

on second thought, perhaps the best approach would be to add the connection param to the auth_base implementation in case anyone is already successfully overriding with connection.

Yeah that would be a better fix. Want to update the pull request?

This appears as though 2 commits now have the correct cumulative diff, but please double check.  Beware my Github newb status.

Yup. Looks ok. Merging.


[Feature] Customize the background image

Description of the feature
Thanks for building such a cool dashboard :)
I would love the ability to set a custom background image.
Additional context
No response

Yeah, that should be doable! Good idea!


Intro slides + video link

could close this one if we merge https://github.com/JuliaOcean/MarineEcosystemsJuliaCon2021.jl/pull/20


Add ability to specify pod labels to all deployments and upgrade Dex chart dependency to 0.16.0

This adds the ability to specify additional pod labels for all the deployment resources. I've also included an update to the latest Dex chart as since https://github.com/dexidp/helm-charts/commit/52138d5f05a992b0fbbeb2c1df1ec80a3c0eb22f it's also been possible to specify pod labels as part of that chart as well.
I wasn't sure whether I was supposed to increment the chart version or if this is done via some other process, so please shout if this part needs reverting.

Thank you for your contribution @dcopestake


<EMAIL_ADDRESS>download fail (Cannot find module 'nopt')

Hey!
I have a problem installing SqLite3.
I specify that I'm under a vps with ubuntu 16.04, with nodejs v12.16.3 and npm v6.14.4
Here are the logs + screen of the error
2020-05-19T17_09_50_272Z-debug.log

Could somebody help me please?
@Dragory

Hey dude ,
Open Powershell - As admin
Execute these 2 commands -
npm install --global --production --vs2015 --add-python-to-path windows-build-tools
npm install --global --production --add-python-to-path windows-build-tools node-gyp
Checkout my Bot

@rayd3on Since they're on Ubuntu, windows-build-tools are unlikely to resolve their issue.
@WhiteSkyAngel Can you verify your Node.js version with node -v? Are you trying to set up the newest version of the bot?
Sidenote, better-sqlite3 (which you tried to install in the image there) is not used in the bot and installing it won't fix any issues you might be having when setting up the bot.


Can't publish my smart-contract on localnet.

Hi There, Today I created a basic smart-contract on local Net and then I compiled it and generates its abi. Then I tried to publish contract using "Set contract " command I got this error.
``
870444ms thread-0   http_plugin.cpp:405           handle_exception     ] FC Exception encountered while processing chain.push_transaction
870444ms thread-0   http_plugin.cpp:406           handle_exception     ] Exception Details: 10 assert_exception: Assert Exception
!"unresolvable": `env._ZN4user5helloEy`
    {"module":"env","export":"_ZN4user5helloEy"}
    thread-0  wasm_interface.hpp:41 resolve

    {"mod_name":"env","export_name":"_ZN4user5helloEy"}
    thread-0  wasm_interface.hpp:43 resolve

    {"_pending_console_output.str()":""}
    thread-0  apply_context.cpp:62 exec_one

I also tried to publish contract from different accounts , but the same error was thrown.

Do you import a library outside eos/contracts/ folder in your contract?

Don't know this error was pretty strange and it was showing on most of the contracts.
But today, when I tried to publish contract again , it got published without any errors.
As for now I am closing this issue.
Thanks for the support.


update HTML for range field in props form

Idea is to make the range selection searchable with options getting reduce as you type matching/showing relevant

This is implemented by now.


Allow native post and put and patch form submissions

Problem to solve
There is no way to do a native post request to the server using the Form component. It would be cool to have all the state management and validation that comes with the Form with a native post at the end of it.
Proposal
Allow the onSubmit prop to take a string of 'post' | 'put' | 'patch' along with the callback function that you can pass in now. If a string is passed in, then the method attribute on the form will be populated.
Then when the form is submitted it will be validated and then only when valid the form will be submitted.
We should probably also add a new prop for the action that allows us to submit the form to a different URL
Links / References

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#attr-method
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form#attr-action

There is currently a workaround by accessing the event.target from the onSubmit callback.
https://react-form-sandy.vercel.app/submit
const onSubmit = ({ event }) => {
  event.target.method = "POST";
  event.target.submit();
}


upgrade go.mod dependencies

Signed-off-by: Mukundan Sundararajan<EMAIL_ADDRESS>Description
Upgrade dependencies in go.mod to later versions.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: Routine maintenance.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

K8s 1.21 removed as part of https://github.com/dapr/cli/pull/1109


Reproduce matrix-org/synapse#11506

Leaving this as a draft until I fix the issue in Synapse. Sticking up a PR for now to see what Dendrite does.
Also note:  fd3a555  is cherry-picked from #237

Fails on Dendrite:
 PUT hs1/_matrix/client/v3/user/@alice:hs1/account_data/m.ignored_user_list => 404 Not Found (722.71µs)

Guessing this isn't implemented in Dendrite yet: if so, suggest blacklisting this test.

You can do that yourself by adding runtime.SkipIf(t, runtime.Dendrite) to the start of the test, fwiw

Guessing this isn't implemented in Dendrite yet: if so, suggest blacklisting this test.

matrix-org/dendrite#600

You can do that yourself by adding runtime.SkipIf(t, runtime.Dendrite) to the start of the test, fwiw

My understanding is that build constraints are the done thing here, as in https://github.com/matrix-org/complement/pull/267/commits/0b453d965a052c8ed146c825ddfe6bdd54f8da91

Maybe, but more recently, skipping specific tests were introduced, these are triggered on *_blacklist in the same way.

I requested review from @kegsay since I believe he has thoughts about the generic infrastructure of complement.

Using r0 means that we PUT the account data, but the ignored invite isn't still ignored. I'd forgotten that  matrix-org/dendrite#600 was a thing.


add simple-memory-storage link

https://github.com/bouzuya/cookie-storage/commit/00093aac28067a71ea84f45caccf6c23a0ccd1ac


look over utils for attribution

note to self, make sure none of the attribution banners were stripped when the "modularize" plugin was run. If I recall, there were a couple of methods from mout, like forEach and isArguments

this isArguments is strange. How you pass second argument to kind-of when it dont support second argument? lol
module.exports = typeOf(arguments, 'arguments')

here is the code coverage. I'm still working to get everything on that list covered.

yep I see, I made some docs and more test, but cant generate readme, because the verb ^^
im going to trick the bugs, haha

yeah I was having issues with the apitoc helper earlier too. you can see that in the current readme here: https://github.com/jonschlinkert/utils#code-links. It didn't output anything.
Part of the problem is that I'm trying to refactor verb, and to do it right I need to using the new verb as much as possible to keep testing it in real usage. But then I have to switch back to the current verb. it just is bound to create inconsistencies for a little bit while it's in transition. sorry for the issues

Yea, okey. But how to make PR in this case, I'm curios?

oh, sorry just remove that helper. it's not necessary. I don't ever want to hold up actual progress with code just because of a readme issue. in the future, if you want to add docs for code in a pr and verb has a problem, just add the docs to the pr comment or something. I usually don't give people a hard time about that stuff, I mainly care about the code quality.

thanks for asking, I appreciate it

and btw, verb is pretty much the most amazing project I've created. There is no denying that.  :)


Chore - v2.1.2 release prep

This PR preps for release by updating the "Changelog" and "Upgrade Guide" documentation.

Release time!!


HIVE-27566: Fix some yarn cluster options for tests

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

Is the change a dependency upgrade?

How was this patch tested?

why?

please find description and repro in jira

@ayushtkn : could this be merged?


Occasional weirdness in DOM updates

To reproduce:
https://github.com/KadekM/outwatch-playground/blob/master/src/main/scala/Outwatchplayground.scala
It seems to reuse the same observable (not attach new one), which seems to cause mentioned problems...

I've just started wrapping my head around Outwatch's internals, but I think a possible reason for this is that Outwatch creates the subscription in snabbdom's insert hook, which fires only when a new DOM element is created (not when a new VNode is created). So if snabbdom chooses to reuse the same DOM node, which is probably the case here, the insert hook will not fire. Same for destroy hook. And as you said, we're left with the old subscription.

I have the same or similar problem:
children <-- Observable.from(Future(uiEntity.parameterEdit()))
uiEntity.parameterEdit() creates a Seq of VNodes. The uiEntity changes, but in the UI the parent element shows still the first VNodes, that were shown the first time (when loading).
Btw: this is the only way I saw to add a Seq of VNodes. Why is something like
children := uiEntity.parameterEdit() not possible?

Hey @pme123, yes, that is indeed confusing. However it is possible. Instead of doing children := ... you can expand a Seq into varargs by annotating them with : _*. So something like div(uiEntity.parameterEdit(): _*)

thanx, that was exactly what I was looking for. (BTW: great project!)


Chaprice issue: comparaison proposed even though charger not referenced in chargeprice, and goingelectric saying it is free

Location: Camping Le Grand Gravelot, Calais (FR)

This specific charger does not have a network/operator listed on GoingElectric, I think that is why it doesn't appear at Chargeprice. So this is a duplicate of #248 and will be fixed with d52ec0c.
There may still be some chargers that GoingElectric shows as free that still have a price comparison button (if all other necessary information such as plug details and network are available). That is to make sure that you can still use the price comparison, e.g.,

if there is a specific method to activate the charger for free (e.g. during the opening hours of a business), but it also accepts roaming RFID cards/apps for paid charging, or
in case the GE data is outdated (e.g. the charger has recently changed from free to paid)

Oh sorry for the duplicate!


Increase mothroach crate price

About the PR

This PR increases the mothroach crate price purchasable at cargo to 5000 spesos, for 4 mothroaches.
People spam mothroach crates and they either end up everywhere around the station or dead everywhere around the station which can be easily abusable, and while i love mothroaches I don't think this is great. After all, these are bought for pets; not for mindless murder (like monkey cubes for example). If I can at least help it a little, I will.
Though some people may not like this change, so its up for heavy discussion.
Changelog
:cl: Ubaser

tweak: Mothroach crates are now twice as expensive

Every round I played last night on Leviathan there were at least 10 mothroaches walking around and all heads of staff were wearing one on their head. It's way too easy for cargo to flood the station with them.

It was introduced 1 day ago, people are overbuying them for the novelty factor. Give it some time

i am sorry about this
:+1:

Can you also please fix how it says six mothroaches in the locale file even though it's 4 while you're at it?

sure ill do that in a second

sounds fair, i hate seeing mothroach flooding the station every time atmos turn in frezon tank


Improve error handling, remove non-needed files, refactor for code conventions

Hello,
Great package. This PR aims to improve error handling by calling requests.exceptions and raising as necessary. It also removes non-needed files/directories. For convention reasons, the comparisons ==boolean and ==type are also removed.
Please review and let me know what you think.
Thank you,
NelsonGon

Hey,
Thanks for spending the time to make this changes! I appreciate it.
Merging your PR now!
Sara


ol.format.GeoJSON.writeFeatureObject adds a Style property which prevent JSON export

ol.format.GeoJSON.writeFeatureObject sometimes adds a Style property when trying to get it as a GEOJson object which prevents the export of the features to JSON because of cyclic references. The problem occurs when I import a KML file in the map. If I try to use writeFeature, I get a stackoverflow error instead.
Here is the code I use.
var source = layer.getSource();
var features = source.getFeatures();
var geojsonFormat = new ol.format.GeoJSON();

for (var i = 0, ii = features.length; i < ii; ++i) {
    var feature = features[i];
    var geojsonFeature = geojsonFormat.writeFeatureObject(feature);

    // Remove style property to avoid problem when converting to JSON
    if (geojsonFeature.hasOwnProperty('properties') &&
            geojsonFeature.properties &&
            geojsonFeature.properties.hasOwnProperty('Style')) {
      delete geojsonFeature.properties.Style;
    }
}

I think it shouldn't behave this way and always allow the export to JSON. This is the behavior I expect after reading the documentation.
Tested with OpenLayers 3.6.0
Problem originally submitted to https://github.com/camptocamp/ngeo/pull/239

Could you please copy&paste the exact error you get when serializing to JSON/GeoJSON?

Here it is:
"Error: cyclic object value
toJson@http://geoportal.disney.interne/lib/angular.js:1036:10
$HttpProvider/this.defaults.transformRequest<@http://geoportal.disney.interne/lib/angular.js:8626:56
transformData/<@http://geoportal.disney.interne/lib/angular.js:8574:12
forEach@http://geoportal.disney.interne/lib/angular.js:322:11
transformData@http://geoportal.disney.interne/lib/angular.js:8573:3
$http/serverRequest@http://geoportal.disney.interne/lib/angular.js:9239:23
processQueue@http://geoportal.disney.interne/lib/angular.js:13075:27
scheduleProcessQueue/<@http://geoportal.disney.interne/lib/angular.js:13091:27
$RootScopeProvider/this.$get</Scope.prototype.$eval@http://geoportal.disney.interne/lib/angular.js:14291:16
$RootScopeProvider/this.$get</Scope.prototype.$digest@http://geoportal.disney.interne/lib/angular.js:14107:15
$RootScopeProvider/this.$get</Scope.prototype.$apply@http://geoportal.disney.interne/lib/angular.js:14395:13
ngEventHandler/<@http://geoportal.disney.interne/lib/angular.js:22827:17
jQuery.event.dispatch@http://geoportal.disney.interne/lib/jquery-2.0.3.js:4675:15
jQuery.event.add/elemData.handle@http://geoportal.disney.interne/lib/jquery-2.0.3.js:4360:6
"

Note: my frontend is adapted from https://github.com/geoadmin/mf-geoadmin3

@Jenselme, are you able to test if my kmlformat branch fixes the problem?

@elemoine Just tested. It fixes the problem.

Thanks for testing. I'll try to turn this into a PR.

Did you create the PR? I am not able to find it.

No, I did not. Are you able to do it (and add tests)? Thanks.

what happens with GeoJSON features which have a style property?

@probins The style property cannot be serialized, because its value is a complex object.
Another (simpler) solution to this problem would be to simply check goog.isNumber(property) || goog.isString(property) before serializing.

but a GeoJSON feature may have a style property that has nothing to do with OL3 style: "style":"modern" for example. I think the number/string check is the better solution.

@Jenselme, can you please test if #3903 also fixes your problem?


Dynamic yaxis max value

Hi!
In my chart, I have some data that represents sales during a given time. I put the labels on top of each bar. But, for the max value, it is cutted off and doesn't show the label.
Here, my max value is 5 and the label for the corresponding bar is outside. Is it possible to add dynamically +1 to the max value?
I have tried with several tests but none have worked out yet.
Thanks for your help!

Try this
var max = 0;
var data = [4, 3, 5, 2];

data.map(d => {
  max = Math.max(max, d)
})

options: {
  yaxis: {
    max: max + 1
  }
}

@junedchhipa I'v managed to add my +1 to the maximum value after my axios request. But now I'm struggling to apply it to my max yaxis value. I've tried with the computed data but without success..
After my axios request, I do this:
    this.max = Math.max(...response.data.totals) + 1

This sets the "max" value to 6 in my case.
In my computed properties, I try this:
        computed: {
            series: function() {
                return [{
                    name: 'Ventes',
                    data: this.count
                }]
            },
            max: function() {
                return options.yaxis.max = this.max
            }
        },

I've based my approach on the other computed properties above.

@junedchhipa But I got a whole other stuffs in my options object.. I've tried to put all of it in the computed part but then I got this "object expected but array given" error..

The spread operator will help to update nested property.
this.chartOptions = {...this.chartOptions, ...{
    yaxis: {
        max: max
    }
}};

@junedchhipa But where do I put this?

You may put in computed or call a function in mounted()

@junedchhipa I cannot make it work. Nothing that I do changes the value.. Is it not easier to have something like a formatter? For the dataLabels, there's something like this:
                dataLabels: {
                    enabled: true,
                    formatter: function (val) {
                        return val + " sales"; // Here you would have val + 1 for the yaxis max value
                    }
                }

I will test if changing yaxis max value works or not. This was an issue faced by a couple of users, so let me look into it.

Here is a working example of changing yaxis.max dynamically in Vue.js
<div class="example">
    <apexcharts
      width="500"
      height="350"
      type="bar"
      :options="chartOptions"
      :series="series"
    ></apexcharts>
</div>

export default {
  name: "Chart",
  data: function() {
    return {
      series: [
        {
          data: [3, 5, 10, 15, 20, 30, 45]
        }
      ]
    };
  },
  computed: {
    chartOptions: function() {
      return {
        yaxis: {
          max: Math.max(...this.series[0].data) + 10
        }
      };
    }
  }
};

Edit on Codesandbox

@junedchhipa The problem with my code is that I have other properties for the "options" value. I've updated the code here to fetch exactly my situation: https://codesandbox.io/s/my53x17n9
As you can see, I get this error: The computed property "options" is already defined in data.

Updated your example - https://codesandbox.io/s/2p2x0zwpqn
It is not valid to have the same prop in data and computed. So, I move the whole options object to computed.

Yes It worked! Gosh that was long. Thank you so much!

On button click..I want to get xaxis node.
I am using this but not able to get xaxis value.
click: function(event, chartContext, config) { }


no support for latest version

I tried to downgrade but then the other mods required didn't work because they had already updated to the latest version

accidently closed the issue.


Update PolicyFile Details section and add Policy Group Section

THE PR IS NOT READY FOR REVIEW
:nut_and_bolt: Description: What code changed, and why?
The Chef Infra Server page has been updated with the following sections:

Policyfiles Details
Cookbook Dependencies Button (under Policyfiles)
Policy Group Section

:chains: Related Resources
The reffered PRs are:

https://github.com/chef/automate/pull/5398
https://github.com/chef/automate/pull/5461
https://github.com/chef/automate/pull/5484
https://github.com/chef/automate/pull/5409
https://github.com/chef/automate/pull/5431
https://github.com/chef/automate/pull/5457
https://github.com/chef/automate/pull/5485

:+1: Definition of Done
:athletic_shoe: How to Build and Test the Change
:white_check_mark: Checklist
All PRs must tick these:

[x] I have read the CONTRIBUTING document.
[x] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[x] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[x] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[x] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[x] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[x] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[x] Tests added/updated? (all new code needs new tests)
[x] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

@dishanktiwari2501 This PR needs to pass Netlify which is failing with the following error:
Start building sites …
1:28:20 PM: Total in 1393 ms
1:28:20 PM: Error: Error building site: "/opt/build/repo/components/docs-chef-io/chef-web-docs/_vendor/github.com/chef/automate/components/docs-chef-io/content/automate/chef_infra_server.md:166:112": failed to extract shortcode: template for shortcode "fontawesome" not found
1:28:20 PM: Makefile:10: recipe for target 'preview_netlify' failed
1:28:20 PM: make: *** [preview_netlify] Error 255


Consider removing HTML Imports

Firefox have said they will not implement this (related to the overlap with ES6 Modules): https://developer.mozilla.org/en-US/docs/Web/Web_Components/HTML_Imports
I don't think the actual spec has been deprecated though.
Could possibly add ES6 Modules instead, but I'm not sure if that is testable as it isn't included in Kangax's table (or maybe just because it isn't ready), or just put the points towards some of the bigger Web * specs coming out like Web Payments and Web Authentication (formally Fido 2.0)
@NielsLeenheer

HTML Imports has been deprecated. It is no longer worth any points, but it is still visible. Might be removed completely in the next version.


Core Component interface methods should not throw UnsupportedOperationException by default

with the new version 1.1.0 of the core componts all interface methods where enhances with a default implementation throwing and "UnsupportedOperationException" by default.
this seems quite useless to me and dangerous regarding semantic versioning. i assume this was introduced to support interface changes in the future when new methods added to @ConsumerType-annotated classes would lead to a major version increase of the package version, requiring all code that uses it to recompile or relax their osgi import instructions.
but adding a new interface method throwing an UnsupportedOperationException by default "solves" the problem with the baseline check of the maven-bundle-plugin - but in a bad way. but it just moves the potential problem from compile time to run time - where it is much harder to detect. code relying on the latest version of the interface may call one of the new methods and just getting an unexpected exception because the implementation was compiled against the old interface version.
my proposal is:

for the existing interfaces, remove all default implementations throwing UnsupportedOperationException
if a new interface methods is added add a default implementation that really makes sense - e.g. calculation the result form the other interface methods, or returning null if the result is optional and this makes sense for existing implementation
if this is not possible for a new interface methods, we need to update the package version to signal all users and implementors of the interface that they have to recompile and recheck their code against the new contract

Hi Stefan,
The models defined by the Core Components are intended to be consumed from the rendering scripts. We expect people to maybe provide their own implementation as an extension. Having said that, we had two scenarios that we wanted to cover:
1. You start developing siteA with version 1.x of the Core Components. After that is launched you begin to develop siteB on the same AEM infrastructure. By that time version 2.x of the Core Components is available and you would like to use that. We wanted to enable you to replace version 1x of the Core Components with version 2.x, without having to touch siteA. That's why we decided to add default methods.
Being able to have multiple versions of the Core Components running simultaneously and sharing the same models was one of the design goals.
2. Suppose you start extending one of the Core Components and override the rendering script and the model implementation. In case you want to simplify things, you might only implement a few of the methods in the model interface, those that are being used by your script. If someone revisits the script and tries to make use of an unimplemented method, they should get an error when they call that method. That's why by default we throw UnsupportedOperationException.
As a side note, the rendering scripts are using HTL which uses reflection to resolve use-object methods so any missing method would only be discovered at runtime anyway. We believe having the default methods return something meaningful (or at least harmless) would make mismatches between model implementation and rendering scripts less obvious.
We presented this pattern at adaptTo() 2017 and was a bit surprised it didn't stir much controversy. Maybe I went over it too quickly or it got lost in the huge sea of information available during the conference. It was also used in the development branch for some time already.
This is the best compromise we managed to come up with, so far. We are very interested in any ideas on how we can improve this pattern while also keeping the aforementioned scenarios valid.

i see your points - but still, from an OSGi perspective this feels "wrong" for me.

In case you want to simplify things, you might only implement a few of the methods in the model interface, those that are being used by your script
in this case you are still effectively breaking the contract the interface defines, but making it silent so neither the compiler nor the baseline plugin complains. if you decide you need only a subset, drop the interface at all and create a custom component with it's own model class.

why are the model interface are not versioned in the package name as well? so you can switch within the script from v1 core component interface to v2 core component interface. and you can still neatly deploy core components v1 and v2 on the same instance, and choose in each application (to be precise in each component of each application) which version to use.

While in a purely OSGi context this would be an anti-pattern (for the reasons mentioned by @stefanseifert above), for the Core Components this is a pattern that would allow developers to seamlessly upgrade to the latest version of the Core Component project without affecting pre-existing projects relying on Core Components deployed on the same AEM instance. I agree that this could also be solved with versioning Java packages (e.g. com.adobe.cq.wcm.core.components.models.v1...com.adobe.cq.wcm.core.components.models.vN), but something like this would lead to exporting too many API packages, with artificial API versions (1.x.y).
Maintaining multiple API packages would also lead to code duplication, since a new API version for a model might still keep some of the old methods.
By using the default methods approach an UnsupportedOperationException would only be thrown if a developer tries to use new API in a script relying on a custom implementation that hasn't been adapted to use the new API: this is a highly unlikely case.
Let's also not forget that if a custom implementation for a Core Components Sling Model exists, it's bound to a specific resource type (the proxy component used by the project), so an upgrade of the Core Components bundle would not affect the implementation resolution.


Fix #131 and #102

This is my fix for #131, and, to test it, I added some examples to the repository, thus also fixing #102. Presently, it doesn't have any easy-mode interface, but I think that that's acceptable because one of the examples that I provided gives copy/pasteable code that accomplishes the same thing, and the set of functions that GTK's C api exposes is more complete than what I would do for that part.

It looks like Travis caught some sort of problem, but I can't find any message that explains what that problem is.

With regard to the examples, I can't guarantee that they're free of error, but I'm a lot more confident with the main API than I am with subclassing (and the examples work), so I don't think that a detailed review of that part is vital to merge this PR, in case no one wants to do it. Of course, it is better to have one if someone is willing to.

Somehow rustc didn't catch that error when I was working on my code, and it kept building, but once I cleaned and rebuilt from scratch it did on my computer. I'm not sure how to fix it though.

It's fixed... sorry about that.

No worries. Looks good to me now, the subclassing part. @GuillaumeGomez what do you think about the example?

I'd prefer if the example was added into the examples repository (in the pending branch!).

@GuillaumeGomez My only concern with having it there and only there is that there's no test coverage in this repository then. With the examples where I put them, this repository has all that it needs to test (albeit manually, but that is how things are for GUIs in most cases that I've seen). If you really want, I'll move them from this PR and PR them there, but I think that it's important to address why I put them here in the first place.

@GuillaumeGomez I think having the examples here is ok. As this is not a core GNOME library, it probably shouldn't have the example in the examples repository, especially considering that you were planning to merge all the core libraries into the same repository (which then should also put the examples into the same repository).

This is a good point.
@john01dav: Then please add a check for your newly added examples folder (in .travis.yml file). Also, please add comments explaining what your example do.

Then please add a check for your newly added examples folder (in .travis.yml file).

They're build automatically by cargo if you add --examples

It still remains something to be added, no? Or did I miss something?

Yes, just explaining what has to be done :)


Update servers list to use irc.twitch.tv

ips listed by dig +all irc.twitch.tv as of a few minutes ago.
did a minor version bump; needs an npm publish.

just tested all the ips with telnet, they all connect fine

also, this should probably be replaced with a call to a dns lib to grab the A records for irc.twitch.tv.
i would create an issue, but deprecation 'n all.


Move configmap to separate files

Note that changes in Jenkisfile are not reflected in the build. It's because jenkins does not trust forks. The solution is to open a PR from the branch in this repository.
@kevinearls promised to look into this issue. Here are some references https://issues.jenkins-ci.org/browse/JENKINS-37931 https://github.com/jenkinsci/ghprb-plugin/issues/507#issue-221474652


Update functions documentation

The documentation for special functions (e.g. gamma, erf, etc) leave something to be desired

done


fuse: fix mount.fuse -o setuid=...

Motivation for this change
mount.fuse foo bar -o setuid= fails with
/bin/sh: su: command not found
To test:
$  sudo env -i result/bin/mount.fuse "$(which fuseiso)#/path/to.iso" /tmp/mnt -o setuid=$(id -u)

cc @primeos as maintainer.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I wrote a lenghty commit message.


FCL Wallet Discovery -- Filtering

Not all wallets will work for all situations. FCLs wallet discovery should default to the most open and general purpose wallets, limited utility wallets (supports a specific subset of general purpose transactions) should be opt-in as a group, while restricted wallets should be opt-in individually.
Specifying the above configuration should be done via FCLs config mechanism. Maybe something like this:
fcl.config()
  .put("discovery.wallet", "https://....")
  .put("discovery.wallet.includeLimited", true)
  .put("discovery.wallet.includeRestricted", ["restrictedWalletKey", "restrictedWalletKey", "restrictedWalletKey"])

@chasefleming Discussed adding this filtering based on self-assigned capabilities


Cancel duplicated workflows

[x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. NO
[x] Update the CHANGES log.

New native GHA features to cancel duplicated jobs https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/

New native GHA features to cancel duplicated jobs https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/

Is this for canceling or blocking duplicated tasks? From my read, this seems like blocking multiple commits CI tasks?

New native GHA features to cancel duplicated jobs https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/

Is this for canceling or blocking duplicated tasks? From my read, this seems like blocking multiple commits CI tasks?

Read more in the links of what I posted.
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#example-using-concurrency-to-cancel-any-in-progress-job-or-run

Should we cancel my personal GHA about canceling?

I’ll disable it.


Bug: mini program sdk doesn‘t work，when network failure happens

What happened?
When the mini program application logs in to the server, if there is a network problem or disconnection, SDK will only retry the connection once. Afterwards, if the application is not restarted, any OpenIM sdk methods will be unable to be called and all will get stuck
What did you expect to happen?
1, fix sdk connect retry count;
2, when network failure happens, sdk could throw exception to application. so that , the application can do something.
How can we reproduce it (as minimally and precisely as possible)?
1, login successful with sdk;
2, broke the network ,or open airplane mode;
3, wait for sdk automatic reconnect fail, almost 20 seconds;
4, call some api with sdk, then you are stacked;
Anything else we need to know?
No response
version
open-im-sdk: 3.4.1
Cloud provider

OS version

```console
# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here
# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here
```

Install tools

我也是同样的问题。


cannot upload with php5.2

This file 'system/libraries/Upload.php' in this method "_file_mime_type"
if web server using php 5.2, the mime_content_type will be used.
it return wrong value for mime type in  .zip, .others
if i comment mime_content_type out, the code works fine.
please do not use mime_content_type because it cannot detect other file except image and text files.
... and more error.
--
Severity: Warning
Message: finfo_open() [function.finfo-open]: Failed to load magic database at '/usr/share/misc/magic'.
Filename: libraries/Upload.php
Line Number: 1035
--
Severity: Warning
Message: escapeshellarg() has been disabled for security reasons
Filename: libraries/Upload.php
Line Number: 1066

server info.
Codeigniter 2.1.1
php 5.2.17
Linux server

Thank you .......!


First go at a library for anonymizing IP addresses.

It is likely that our understanding of the right way to do this will change over time, so we should make a single library used by all our tools.

This change is

Pull Request Test Coverage Report for Build 553

31 of 31 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.6%) to 81.665%

Totals

Change from base Build 551:
0.6%

Covered Lines:
775

Relevant Lines:
949

💛  - Coveralls

First go at https://github.com/m-lab/dev-tracker/issues/443


URL's with a query string do not render correctly server side using React Router.

When we attempt to render a url with a query string e.g. /example?test=123 on the server side the location is changed to /example before it gets to React Router and we get the wrong component.  This is an issue since we render a different component based on the query string value i.e.  /example would render ComponentExample and /example?test=123 would render ComponentQueryExample.  We are using React Engine version 3.0.0, React Router 1.0.3, Express 4.13.3 and the issue seems to be corrected if I comment out line 35 in react-engine/lib/expressView.js without any immediate side effects.  Is there an option I am missing in React Engine to preserve query strings that would fix this issue differently?  I am not finding anything in the document that talks about query string or in the code either.
The code example below is a React Router route which represents my example using code.
{
  path: '/example',
  getComponent: (location, cb) => {
    const ComponentExample = require('components/ComponentExample')
    const ComponentQueryExample = require('components/ComponentQueryExample')
    cb(null, (props) => {
      const query = props.location.query
      if (query.fullplayer == 123) {
        return (<ComponentQueryExample {...props} />)
      }
      return (<ComponentQueryExample {...props} />)
    })
  }
}

Here is an example express route.
app.use('/', (req, res) => {
  app.engine('.jsx', engine)
  return res.render(req.originalUrl, {
    hydrate: {}
  })
})

I have figured out that the answer to this question existed in a closed issue and was fixed in 3.1.0.  I have submitted a PR with the fix back ported to 3.0.0 from 3.1.0.


Final case object

Throughout the book there are code examples like the following
sealed trait IntList
final case object End extends IntList
final case class Pair(head: Int, tail: IntList) extends IntList

While I agree it is good practice to declare everything that should/can final as final. I am unsure if I understand why it is used for object. You can not subclass an object, so it is redundant here(?). Am I missing something?

Thanks for the issue! No, you're not missing anything -- the keyword is redundant, as you say. I've removed it in 3a8b67e.


MS Edge user should be able to create a hardware account

From Slack (https://liftedinit.slack.com/archives/C02C91EMFDK/p1669833507384309):

Hey Lifted team! I have an Alberto wallet-specific question...not sure where to put it so putting it in #general I'm currently helping node owners create their wallet with HSMs...but one NP is having trouble getting his windows laptop to recognize the ledger device during the Alberto account creation process...nothing happens at this point and the request times out. (we've DL'ed FIDO U2F)

OS: Windows
Browser: Edge (?)

Update: a second user with a Ledger and Windows machine cannot get past the external security key prompt in creating an account on Alberto.

Current wallet setup instructions:
Lifted Node Program_ Wallet Setup.pdf

I was able to create an account using MS Edge with my Trezor. Looking for someone with a Ledger who can take over this bug since I can’t reproduce.

I'm setting up Parallels today and will test Windows -> Edge with Ledger Nano S Plus

I have successfully restore my wallet in both Edge and Chrome browsers on Windows 11 v22H2 (osbuild 22621.525)

I was able to create an account using Microsoft Edge, Firefox, and Chrome on Windows 11 with a Ledger Nano X.
The behavior of timing out did occur if I did not click my Fido U2F app on my Ledger and then click again to "Register Unknown". It could be that the described issues are occurring for users if they are not clicking their Ledger to authenticate when presented with the prompt to connect.

I'm going to mark this as complete, since we were unable to replicate the behavior.  I would suggest we add screen recording as a feature, or at least have any LIfted rep working with a customer having an issue try and get screen captures or recordings.  There are pop-ups on windows that are not modal and that quickly get hidden under window stacks.  This happen to me a few times as the USB acceptance was buried, but once I saw that and approved everything worked as expected.


automotive_autonomy_msgs: 2.0.2-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository automotive_autonomy_msgs to 2.0.2-0:

upstream repository: https://github.com/astuff/automotive_autonomy_msgs.git
release repository: https://github.com/astuff/automotive_autonomy_msgs-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.6.6
previous version for package: null

automotive_autonomy_msgs
* Changed metapackage name to automotive_autonomy_msgs.
* Moving perception_msgs to astuff_sensor_msgs.
* Moving radar_msgs to astuff_sensor_msgs.
* Fixing license in package.xml.
* Updating package.xml to format 2.
* Standardizing package.xml files.
* Version bump and minor formatting clean-up.
* Major package reorganization. See README for new package definitions.
* Adding HMI Messages.
* Updating metapackage.
* Name changes for consistency. Updating all other packages to match.
* Contributors: Daniel Stanek, Joe Buckner, Joshua Whitley, Sam Rustan

automotive_navigation_msgs
* Reorganized messages into renamed packages.
* Changed package name from module_comm_msgs to automotive_navigation_msgs.
* add RouteArray message to handle roads with more than one lane
* Fixing license in package.xml.
* Add ACC max distance in meters so that it can be displayed on shuttle GUI instead of just the 0 to 100% value on the existing highway autopilot GUI
* Add more lane styles to lane boundary message to support double lines
* Add lane boundary messages
* Add new message for velocity and acceleration that includes a calculated covariance
* Add Direction message from marti_localization_msgs
* Add ROS service to request map images
* Updating package.xml to format 2.
* Standardizing package.xml files.
* Version bump and minor formatting clean-up.
* Adding headers to some files that were missing them.
* Moving VelocityAccel to module_comm_msgs.
* Major package reorganization. See README for new package definitions.
* Contributors: Daniel Stanek, Joshua Whitley

automotive_platform_msgs
* Reorganized messages under new package names.
* Changed package name from platform_comm_msgs to automotive_platform_msgs.
* Fixing license in package.xml.
* Updating package.xml to format 2.
* Standardizing package.xml files.
* Version bump and minor formatting clean-up.
* Moving VelocityAccel to module_comm_msgs.
* Major package reorganization. See README for new package definitions.
* Contributors: Daniel Stanek, Joshua Whitley

Holding for pending sync


undefined symbol

configure and make worked fine, after doing make install I get these kind of errors:
man: symbol lookup error: /usr/lib/man-db/libman-2.6.2.so: undefined symbol: gzclose
apt-get: symbol lookup error: /usr/lib/x86_64-linux-gnu/libapt-pkg.so.4.12: undefined symbol: gzdopen
Linux 3.2.0-4-amd64 #1 SMP Debian 3.2.68-1+deb7u1 x86_64 GNU/Linux

Use:
./configure --zlib-compat
Also, beware that this is not production ready and will break some applications that dont actually call the init functions (some allocate memory based on assumptions about memory needs).


autotag creations with "case_sensitive = false" fails

Hi,
like in #3 the modfying or creating a autotag ressource fails if the case_sensitive attribute is false (if the string comparison operator is "BEGINS_WITH)"
Sample Ressource
resource "dynatrace_autotag" "stage" {
	rules {
		conditions {
			string_comparison {
				negate = false
				type = "STRING"
				operator = "BEGINS_WITH"
				value = "p"
				case_sensitive = false
			}
			base_condition_key {
				attribute = "HOST_GROUP_NAME"
			}
		}
		enabled = true
		propagation_types = [ "PROCESS_GROUP_TO_HOST", "PROCESS_GROUP_TO_SERVICE" ]
		type = "PROCESS_GROUP"
		value_format = "p"
	}
	name = "Stage"
}

Output on Create:
dynatrace_autotag.stage: Creating...

Error: rpc error: code = Unavailable desc = transport is closing

Output on Modify:
dynatrace_autotag.stage: Modifying... [id=74af98f9-5067-404b-be11-696a8b16b462]

Error: {
  "code": 400,
  "message": "Constraints violated.",
  "constraintViolations": [
    {
      "parameterLocation": "PAYLOAD_BODY",
      "location": "",
      "message": "caseSensitive must be null if the operator 'EXISTS' is specified, for any other operator it must be set.",
      "path": "rules[0].conditions[0].comparisonInfo.caseSensitive"
    }
  ]
}

Thanks and best regards,
Alex

Seems to have the same root cause as #3.
The OpenAPI Spec of the Config REST API declares caseSensitive as optional, while there are payloads where it isn't.
We've already filed a bug report to Dynatrace R&D for the flawed OpenAPI Spec.
Nevertheless we'll introduce the same workaraound as the one in #3 with v1.0.5.
Thanks!

Fixed with v1.0.5


Help: unsure how to export Glyphs from FontLab

So, I am looking into adding small capitals and old-style figures to googlefonts/lexend. I downloaded the FontLab 8 trial (since I'm on Windows), opened the .glyphs file, duplicated the glyphs, used actions to transform them across all instances universally, added the features, and all seemed to be fine. When I export it to a Variable TT file using FontLab, all is fine, and the font works as expected.
However, when I export it to a Glyphs file and use it with gftools, I get a bunch of Glyphs named '<glyph>' have different number of segments errors, even for glyphs that I never touched. Is there any kind of export setting I need to change to have my files be compatible with gftools?
I have already tried:

[x] Setting the export settings such that all curves are converted to TrueType curves
[x] Setting the export settings such that it decomposes all/transformed composite glyphs
[x] I had a look at VFB2UFO3, but for the life of me couldn't understand how to use it
[x] Exporting as Designspace or UBO files, the same problem persists

I'm quite new and at a loss here, so any kind of help would be much appreciated. Thanks!

Do you have the same problem if you import the original .glyphs file into FontLab and export it without making changes?
If so, you can start with a clean file and copy your changes over, testing with gftools as you go.
Just getting a Mac and Glyphs might save you a lot of time.

FontLab may apply magic to the font that breaks compilation, or not apply magic during export, also breaking compilation. It may be best to ask over in the FontLab support forum for how to achieve a proper export to .glyphs.

@mahtaran

am looking into adding small capitals and old-style figures to googlefonts/lexend

Is this just for your own use, or for submission to GF?
If for yourself, I'd just export from Fontlab and call it a day.
If for GF, we are working on a new version that has a lot of changes, so I'd postpone working on this until after that round of development is done.

Hi @davelab6! Any news on when we can expect that new version?


Refactor flask configuration

This pull request modifies the configuration of the flask app to allow dynamic configuration at runtime based on an configuration file passed by environment variable at runtime.
This is follows from the flask documentation on how to use file based configuration in a deployment environment.
This change is necessary to support cleaner deploys of the platform. Currently the PR only pulls out the mongodb settings, because these are most important for a deployment, however this mechanism should be used for many of the other configurations that are expected to vary per deployment.

Yes, this is a long needed change. I noticed that you upgrade pymongo from 2.x to 3.x. I've had issues in the past with backwards compatibility between major versions. Did you encounter any of that?

Seems to be a smooth upgrade. The current staging infrastructure is running mongodb 3.X, and aside from the changes related to adding client authentication I haven't seen any issues.
This PR also runs just fine on the current picoCTF-platform configuration, which is still using 2.X (with the updated 3.X pymongo).  I hope to finish porting over the platform configuration to picoCTF-deploy (private at the moment) then being able to make a PR to platform that standardizes the configuration for local dev (Vagrant + ansible) and remote deploy (terraform + ansible).
If you don't see any major issues with this, I'll refactor out most of the rest of the run time dependencies we might want to modify based on environment.  This doesn't touch any of the the configs that get loaded/updated in the web-management or db. Will probably leave those baked in.

For what it's worth I need to look into why Travis is failing, I don't believe it is related to this specific PR, but rather some to the testing harness itself.


Fixed Modern Warfare definition linking to beta

Simple change. Modern Warfare definition was just pointing to odin_beta rather than odin.

Don't you need the correct game ID as well?


模板列显示异常

可能是因为html？
还有多数据库应该搞个区分

其实我觉得直接把属性面板的扒下来最简单也不怎么需要维护

另外我测试是只对文档起效吗？

Can you please write in english? I can of course try to translate using DeepL, but it's not always easy. Let me first check if I have understood you correctly.

还有多数据库应该搞个区分
And there should be a distinction between multiple databases
How can a document belong to multiple databases? I don't see how that is possible.

其实我觉得直接把属性面板的扒下来最简单也不怎么需要维护
Actually, I think it's easiest and less maintenance to just strip down the attribute panel's
That's what I did already, I have mostly reused the existing attribute panel code.

另外我测试是只对文档起效吗？
Also is my test only working on documents?
What other types are there which could have this panel beside documents?

in siyuan, a document can indeed be added to multiple database,  which enabling document reuse. This counts as a feature. So  you should  show the database title in attribute panel.

Wow, I didn't know that. Thank you for sharing 🙇♂
I'll keep this feature about html/template columns and create a new issue for supporting multiple databases.


Problem with C++ failing to use stub in multiple places

I believe this is related to https://github.com/grpc/grpc-go/pull/505
We have a bi-directional stream setup in C++ on a server as per usual. No issues on this.
We then have the following C++ client code:
this->m_pChannel = CreateChannel(clientAddr, grpc::InsecureChannelCredentials());
this->m_pStub = clientcommunicatorstream::CommunicatorService::NewStub(this->m_pChannel);

We then start off our bi-directional stream with the server and leave it running forever in a loop.
We then use the same stub to send different messages on a regular RPC call (no streams).
After exactly 1 minute the RPC single calls begin to fail. This seems to be an issue with the C++ client code. The error is as follows:
[ERROR] [GRPCClient::ProcessCommunication] GRPC Failed: 14 - {"created":"@1492762861.182000000","description":"Endpoint read failed","file":"C:\path\to\code\thirdparty\grpc\src\core\ext\transport\chttp2\transport\chttp2_transport.c","file_line":1851,"grpc_status":14,"occurred_during_write":0,"referenced_errors":[{"created":"@1492762861.182000000","description":"The I/O operation has been aborted because of either a thread exit or an application request.\r\n","file":"C:\path\to\code\thirdparty\grpc\src\core\lib\iomgr\tcp_windows.c","file_line":176}]}

I tested the same setup with a Python client (using a single stub for both) and had 0 issues. This seems to be a specific issue once again with the C++ client in GRPC. Making two different stubs providers a workaround, leaving the stream one to just handle the stream and then doing one time requests on the second stub.
I believe we are on 1.12 for the GRPC version. This is also a Windows application.
Not sure if this was already resolved or not.

We are cleaning up the gRPC issue backlog and are unable to address this issue with the current information. If you are still experiencing this issue, please re-open the issue with information on how to reproduce.


Publish 10/20/2022 3:30 PM PT

Learn Build status updates of commit a15a13a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/docs-conceptual/connect-to-exchange-online-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/connect-to-exchange-online-protection-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/docs-conceptual/connect-to-scc-powershell.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Connect-ExchangeOnline.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Connect-IPPSSession.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-DlpCompliancePolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

exchange/exchange-ps/exchange/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Handle multiple processes (processings + inversions) [24hr]

Processes are getting queued up - ali will look at the poltergust parallelisation code

Ali tried implementing from reading the docs on the poltergust repo, but it didn't work.
He is working here: https://github.com/emerald-geomodelling/poltergust/tree/parallelisation
But needs a deeper dive to try and figure out why its not working

Call luigi.build([RunTask(...)]) inside requirements() of RunTasks instead of yielding them should do the trick.

[ ] Ali will test this week


Cannot undo delete cell

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

Accidentally deleted multiple cells by double clicking the garbage can icon in the top right corner of the cell.
Attempted to recover cell by pressing Z.

Actual behavior

No effect after pressing Z, so pressed again.
Entire notebook reverted to the state it was a week ago, causing internal user meltdown.
Shift-Z recovered notebook minus the recently deleted cells, meltdown halted, but ~two hours of work remains deleted.

Note: I am not using VSCode until this has been solved. It's insane that a double click can delete hours of work permanently.
Expected behavior

Z should recover recently deleted cells
Z should undo cell changes one change at a time, not an entire week's worth of changes

Your Jupyter and/or Python environment
Please provide as much info as you readily know

Jupyter server running:  [Local] | Remote | N/A
Extension version: 2020.7.96456-xxx
VS Code version: 1.47.3
Setting python.jediEnabled: true | false (True? couldn't find it explicitly in settings)
Setting python.languageServer: [Jedi] | Microsoft | None
Python and/or Anaconda version: #.#.#
OS: Windows | [Mac] | Linux (distro):
Virtual environment: conda | [venv] | virtualenv | N/A | ...

Developer Tools Console Output

Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

Hi @nklick, sorry for the trouble and thank you for reporting this issue. This sounds like the undo stack got corrupted, but it seems like it might be difficult to repro, as I just tried undoing cell deletions locally and 'z' currently works for me. Would you mind providing more details about how this bug occurred? Did you have the cell selected when you were pressing 'z' (i.e. the side of the cell was highlighted in blue) without effect? Had you left the notebook open in a VS Code session for a week and recently come back to it?

Also, I noticed that you filed a related bug on the VSCode repo https://github.com/microsoft/vscode/issues/103854. You can  create a copy of a notebook by selecting the file in the file explorer pane and hitting cmd+c and cmd+v. Please let me know if that doesn't work for you.


Use open jdk

Don't use the oracle jdk. Closed source with extra restrictions.
No thanks.
In addition this will remove one layer.

This change is

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


make it so the avatar moves with the cursor

so basically i just added some javascript that makes it so the avatar in the corner moves with the mouse cursor

Thank you but I don't think this is necessary.


"Confirmation" option for tap_action

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

I'm looking to use tap_action to reset the date a battery was last charged in Grocy. To avoid unintented clicks, it would be great if this card supported "confirmation" under "tap_action" like the default does for HA (see https://www.home-assistant.io/dashboards/actions/#options-for-confirmation).
Additional context

Thanks for the suggestion. Yes definitely it make sense

Closing as this will be covered by #691


loglevel print duplicate log in React component

Hi, I try to use loglevel in React, and seeing it print duplicate lines.
The project is freshly created with create-react-app and I just added two lines of loglevel.log and console.log in the App.tsx. As you can see in chrome console, console.log printed one time and loglevel.log printed twice.
I'm not sure if this is expected or I'm doing it wrong. Couldn't find any similar topic by just googling.

Great, thanks for the update @gaearon!


implement SingletonObject to solve #2349

Impact

[ x] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Fix issue #2349  by changing DatabaseFactory to implement SingletonObject

@filipelautert This is quite urgent for us since it's blocking taking latest version of liquibase-core that is free from security vulnerabilities.

Initial/Pre-Review Thoughts
Change makes sense to me
Questions I have:

None

Potential risks:

None

What could make the full review difficult:

Nothing

@nvoxland can you replace filipe as review so we can merge this please?

@filipelautert can we bypass the need to rebase from master? that reset your safe to build flag. and I see master gets update quite quickly.
how can we progress with a merge here?

Hello @yairogen, thanks for the PR! Nathan prioritized this yesterday and we are going to move it fast to have it in our next release. Master was being updated as I came back online yesterday and merged a lot of stuff that was waiting for me, now it must calm down for a while. Could you please rebase it one more time now? Then I will trigger the build again and QA people can review it, thanks!

Hello @yairogen, thanks for the PR! Nathan prioritized this yesterday and we are going to move it fast to have it in our next release. Master was being updated as I came back online yesterday and merged a lot of stuff that was waiting for me, now it must calm down for a while. Could you please rebase it one more time now? Then I will trigger the build again and QA people can review it, thanks!

rebased. thanks for prompt response

@filipelautert once merged - when is the next planned release? I need to give dates to our security team.

@filipelautert once merged - when is the next planned release? I need to give dates to our security team.

@yairogen we have a tentative date of ~Jan 19th, it will be confirmed on the next days.

perfect. can we re-run tests and merge?

@XDelphiGrl can you please approve so we can merge this?

Can someone merge this please?


More validation of the multi-select question type

Description
Questions that allow multiple selections (e.g. checkbox) presently allow configuration of the minimum / maximum number of selectable choices where:

Negative inputs are allowed
Minimum number of selections can be greater than the maximum number of selections
Minimum / maximum selections can be greater than the number of choices

This adds additional error validation / tests for this and makes a few additional improvements I noticed while testing the issue:

Toasts with the validation errors were disappearing after 3 seconds (the default behavior). Now we show it indefinitely (but still dismissable) under the assumption that the admin will dismiss the toast after fixing the errors or resubmitting the form.
When a validation error occurred, any newly added choices for the multi-select were lost. This would have been frustrating if the admin had added many new choices and had to retype them all again if, for instance, a single blank value was accidentally added during configuration. Added a unit test for this.

Perhaps for a separate PR: When a toast is shown with multiple validation errors, they're shown as a series of sentences. An alternative may be to display them as a  so it's easier to see that they're distinct errors. If desirable, I'm happy to file a separate issue for this.
Checklist

[X] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
Fixes #1890

@clouser2 great improvements!

Perhaps for a separate PR: When a toast is shown with multiple validation errors, they're shown as a series of sentences. An alternative may be to display them as a so it's easier to see that they're distinct errors. If desirable, I'm happy to file a separate issue for this.

I recommend a separate issue for this.

An alternative may be to display them as a so it's easier to see that they're distinct errors.

Created issue #2347 for this.


I want to show validation when only i click on submit button right now by default when i click on input and i click on another input required validation fired can any one help me about this?

I want to show validation when only i click on submit button right now by default when i click on input and i click on another input required validation fired can any one help me about this?

$('form[data-toggle="validator"]')
  .off('input.bs.validator change.bs.validator focusout.bs.validator')


codelite build: PIC error.

On Ubuntu 18.04.4, using codelite 10.0.0
Building an example:
relocation R_X86_64_32S against symbol `_ZN5eastl23gpDefaultAllocatorForgeE' can not be used when making a PIE object; recompile with -fPIC

This goes away if I manually set the project to use clang, not gcc.
Not sure why codelite defaulted to gcc, at first launch, I pointed it to clang.


Skip option in Welcome Screen

Description
Fixes #1239
Added Skip option in Welcome Screen
Description
Fixes #1239
Added Skip option in Welcome Screen
Screenshot

Codecov Report

Merging #1251 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1251      +/-   ##
=========================================
- Coverage    3.78%   3.78%   -0.01%
=========================================
  Files         125     125
  Lines        5861    5863       +2
  Branches      578     578
=========================================
  Hits          222     222
- Misses       5624    5626       +2
  Partials       15      15

Impacted Files
Coverage Δ

.../java/fr/free/nrw/commons/WelcomePagerAdapter.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c3513b...bcccac5. Read the comment docs.

@tanvidadu Please attach a screenshot.

You know, if the "Skip" button was in a different location on the screen - say, styled as a text link at the top right of the layout - you wouldnt need to put it on every page of the view pager.  Then you would avoid duplication plus it would be a little more subtle.  How about something like this -

Looks good ! I will change it accordingly 👍

New mockups

It works fine on beta builds. The option is visible even on prodDebug builds and clicking it does nothing. @tanvidadu you will need to fix that before this can be merged.

@maskaravivek @misaochan @psh  I have fixed the above problem.

@maskaravivek I have fixed those error. Thanks :)

Tested on both beta and prod builds. Works as expected. Thanks for the contribution @tanvidadu. Surely all commons app devs will use this feature everytime they do a fresh install. :D


Revise xlsx parsing

__isConditionBlock function in XLSXHandler wont be true for conditions containing only one context variable, e.g "$variable_name"
conditions like "@entity_name_1 & @entity_name_2" will be catched by https://github.com/IBM/watson-assistant-workbench/blob/devel/scripts/XLSXHandler.py#L142

Still not affecting users - postponing it Sprint 21.

Due to an another project moving this to the next sprint.

Due to vacations postponing this to the next sprint.

Within replanning this was moved to the Sprint 26


Sql tool cardinality distinct

Description: This adds functionality to the SQLDatabaseToolkit agent_toolkit to address a shortcoming in the agent's capability to better understand and utilize the data in the database for filtering when required. Previously, the model would hallucinate filter values or just hard code exactly what a user asks for, which often times would return no results. This Loop was fine for users used to working with data who could iteratively prompt to get distinct values and subsequently ask another question to filter, but not as useful for users who are not experienced with working with databases and SQL. This change makes the natural language agent a bit more autonomous and self healing by being better able to gain an understanding of the data it's working with.
Issue: N/A,
Dependencies: none,
Tag maintainer: @hinthornw (changing a tool/toolkit/agent), @hwchase17, @baskaryan (changing a prompt), also made a tweak to the makefile for lint_diff (should a check for only changed files not follow imports?)
Twitter handle: @bpafoshizle

Unit Test
Example notebook
Passed format, lint (without following imports), and tests (including test I added).

@bpafoshizle Hi , could you, please, resolve the merging issues? After that ping me and I push this PR for the review. Thanks!

@baskaryan Please review this PR. TNX

@leo-gan caught up with main again. Not sure what to make of the failing tests, since the failures are not related to code being pushed in this branch

@baskaryan Please review this PR. TNX

@baskaryan and @leo-gan I've rebased and resolved outstanding conflicts, if you could please take a look at your convenience.

@baskaryan @leo-gan please check if you can.

Apologies for the slow review! Pr has a number of merge conflicts, happy to re-review if you'd like to resolve

@baskaryan thanks for pinging back. I've resolved conflicts if you can re-review.

looks like there's still some linting issues. to check for these locally you can run
cd libs/community
poetry install --with test,lint,typing
make format
make lint

Closing but will re-open if there's desire to keep iterating on this.


Mnist example minor revision

Minor revision to make the mninst example easier to follow. Had to add "./" path qualifier to locate the .so located in the example directory.

@tungld introduced the same image in the python interface example as the one used in the C++ interface, as requested.

Jenkins Linux s390x Build #3264 [push] Mnist example minor revi... started at 16:15

Jenkins Linux amd64 Build #3272 [push] Mnist example minor revi... started at 15:15

Jenkins Linux ppc64le Build #2380 [push] Mnist example minor revi... started at 16:20

Jenkins Linux ppc64le Build #2380 [push] Mnist example minor revi... passed after 1 hr 1 min

Jenkins Linux s390x Build #3264 [push] Mnist example minor revi... passed after 1 hr 10 min

Jenkins Linux amd64 Build #3272 [push] Mnist example minor revi... passed after 1 hr 17 min


Client-Side Compression / Encryption Support

For your consideration - a pull request to implement client-side compression and encryption.
Since requests are cached as serialized bytes objects, it's reasonably simple to do bytes things with them. Like gzip compression, or encryption. While several backends natively support these features (like MongoDB's compression-by-default and field-level encryption), it is easy enough to enable these features as options for all backends by modifying the serialize and deserialize methods.
This would especially be useful for highly-compressible response bodies, like XML data. When used in patent-client, the cache file can swell to hundreds of megabytes. This should keep the growth more moderate. Further, this is also useful if you want to add an extra level of security to the response contents by encrypting them.
This also includes a few modifications to the test suite to use pytest's builtin "tmpdir" fixture. For some reason, the test suite would fail on Windows if you create the database file as a NamedTemporaryFile, because it would look like an invalid database file to sqlite3.

Tests are likely to fail due to the absence of the cryptography package as a build dependency. I've modified the relevant github workflow, but I suspect a security setting prevents me from arbitrarily monkeying about in there. May need some assistance to get crypto added. Should pass at that point.
(It's a classic "it works on my machine" kind of situation)

Nice, thanks for putting this together! Compression is something I was already thinking of after adding the filesystem backend, so I'm glad you added that.

Bad news: I'm currently about 80% done with overhauling serialization in #275, which unfortunately conflicts with these changes.
Good news: That PR will make it easier to extend and customize serialization behavior.

I think what I can do is merge your PR first, rebase mine on top of it, and make these features fit with the new serializer structure.
A few thoughts:

Ideally I'd like to do that by making separate serializer classes for compression and encryption, alongside the other serializers I have so far. Usage would then look like:session = CachedSession(serializer='compressed_pickle')  # Also accepts a class or object, same as backends

Do you think there will be a need to use both compression and encryption at the same time? I feel like that will be more difficult to test and maintain in the long run. The number of major corner cases for storage formats would be the cross product of backends X serializers X compression on/off X encryption on/off, rather than just backends X serializers.
We can still allow users to use different combinations of these features by making a custom serializer class (WIP example here).
Could we reuse the existing secret_key parameter instead of reading from an environment variable? I do like that as a generic way to pass creds and other config to your application, but I think that's best handled in client code, since that's one of a few different options you may want to use depending on the environment. See the Security section for some examples.

Sorry to complicate things, and I really do appreciate the contributions!

Happy to help!
On your thoughts:

Love the idea of factoring out serializers into its own class. Would make this feature super-easy to implement. And the API you suggest sounds great!
I think there would be a need to both encrypt and compress. I view them as solving two separate, and non-overlapping problems. I will probably use both on patent_client when the time comes. That said, one way to avoid the testing hassle would be to factor out the serializer class, and then leave both compression and encryption as a user exercise. Once there's a hook to mess with the bytes that come out of the serializer, wrapping that with fernet.encrypt/decrypt, gzip.compress/decompress or whatever else is trivial. That also solves how to handle encryption keys - leave it up to the user.
We could re-use secret_key but we'd need to do some work to reconcile the fact that cryptography.fernet.Fernet looks for a string of exactly 96 bytes. So we would need to derive key material from the secret_key, which can be done, but is pretty far afield from the caching features of this library.

On the whole, I honestly think it makes more sense to factor out the serializers (if that hasn't been done already), and then not merge this PR. Maybe we can use crypto / compression as examples/recipies in the docs about how to use the serializers rather than baking it into the library.
As they say, a focused library is a solid library, and deleted code is debugged code!

We could re-use secret_key but we'd need to do some work to reconcile the fact that cryptography.fernet.Fernet looks for a string of exactly 96 bytes.

Ah, that's what I was missing. That makes sense.

On the whole, I honestly think it makes more sense to factor out the serializers (if that hasn't been done already), and then not merge this PR. Maybe we can use crypto / compression as examples/recipies in the docs about how to use the serializers rather than baking it into the library.

Thanks for being flexible! I don't necessarily want to drop the idea just yet, let me mull that over a bit more. There may be a reasonable compromise that's just not coming to me right now because it's Friday and my brain is fried.

On the whole, I honestly think it makes more sense to factor out the serializers (if that hasn't been done already), and then not merge this PR. Maybe we can use crypto / compression as examples/recipies in the docs about how to use the serializers rather than baking it into the library.

Thanks for being flexible! I don't necessarily want to drop the idea just yet, let me mull that over a bit more. There may be a reasonable compromise that's just not coming to me right now because it's Friday and my brain is fried.

I'm happy to write up the docs with the recipes if that's the way you want to go! And sorry for harassing you on a Friday! But now that I've invested the time in seeing how this library works under the hood, it just got me thinking. Not to mention - a caching layer on Requests is just so darn useful. And don't worry - I won't take offense at dropping this PR!

FYI - Revisited this idea and now am strongly in favor of rejecting this PR. I can accomplish compression as easy as this with the pending serializer refactor:

import gzip
import requests_cache
from requests_cache.serializers import PickleSerializer

class GzipSerializer(PickleSerializer):
  def dumps(self, response):
    return gzip.compress(super().dumps(response))

  def loads(self, obj):
    return super().loads(gzip.decompress(obj))

session = CachedSession(serializer=GzipSerializer())

In fact, I might be able to make composable mixins for compression / encryption functionality. At the end of the day, each step of compression / encryption is just a pipeline stage between the library's native Response representation and storage, and there are OOP constructs for baking in that kind of thing to an inheritance structure.  But that digs a bit more beyond my knowledge of Python's multiple inheritance internals.

Funny, I was just thinking the exact same thing. I think mixins would be the way to go here. If we distinguish "pre-serialization" mixins from serializers, then users could arrange those in whatever combination they want. Cache signing with itsdangerous would also fall under that category.
A mixin would look the same as your GzipSerializer example except it would inherit from object instead of BaseSerializer. The order of operations would just be the reverse of the inheritance order, for example:
class CustomSerializer(EncryptionMixin, GzipMixin, PickleSerializer):
    """Pickle - > compress -> encrypt"""

Session = CachedSession(serializer=CustomSerializer())

Or:
class CustomSerializer(ItsDangerousMixin, GzipMixin, JSONSerializer):
    """JSON - > compress -> sign with secret key"""

Session = CachedSession(serializer=CustomSerializer())

I'm going to close this PR , and maybe suggest some docs about how to use this with Gzip and any other possible pipeline stage with the serializer refactor. No need to bake this into the codebase.

@parkerhancock Thanks! This brought up some helpful ideas, and I made #283 as follow-up.
#275 is getting close to finished, but may take a bit longer to get some quirks worked out with a couple of the backends.


Fix workbox-broadcast-update link

R: @jeffposnick @philipwalton
Current URL 404s.

Hmmm, I think the fix for the problem here is our docs site needs to be updated. Specifically the file name of this file as well as some of its titles. @abraham if you're able to make that update and cc me, I can approve and merge.
We also have a TODO to update some of the content there in line with v5 changes: https://github.com/GoogleChrome/workbox/issues/2122

Hmm, probably makes sense to also add a redirect in this file: https://github.com/google/WebFundamentals/blob/c3570fd9de43d40f91fcf9b3b22e7e64d227538b/src/content/en/tools/_redirects.yaml

Coverage remained the same at 79.314% when pulling 3f8cce360dcc759f08f73aab21054621eddd8495 on abraham:patch-1 into ae80e3958c79cb93f4c21bca63cd6e81f7878536 on GoogleChrome:master.

https://github.com/google/WebFundamentals/pull/8069

I've published the demos, and the page on developers.google.com/web/ should be updated too, so everything should work now. Thanks!


Fix the newline with object literals bug

From comment https://github.com/yannickcr/eslint-plugin-react/issues/857#issuecomment-299698993:

Found another bug:
<App foo={
{ bar: true, baz: true }
} />;

This would get 2 errors using the default settings: There should be no space after '{' and There should be no space before '}'.
This is because conditions for the object literal spacing were written so that the second one was never reached:
          if (sourceCode.isSpaceBetweenTokens(first, second)) {
            reportNoBeginningSpace(node, first);
          } else if (!config.allowMultiline && isMultiline(first, second)) {
            reportNoBeginningNewline(node, first, config);
          }

If the first condition fails, isMultiline will return false - there is no newline.
Will fix this and add appropriate tests.

I've rebased this. There's only the unresolved problem of the duplicate test left.


Check need_auto_run= method is defined also

To prevent errors such as:
undefined method `need_auto_run=' for Test::Unit::AutoRunner:Class (NoMethodError)
/Users/orien/src/marketplace/.bundle/ruby/2.1.0/gems/rspec-rails-3.2.1/lib/rspec/rails/adapters.rb:65:in `<module:Rails>'
/Users/orien/src/marketplace/.bundle/ruby/2.1.0/gems/rspec-rails-3.2.1/lib/rspec/rails/adapters.rb:7:in `<module:RSpec>'
/Users/orien/src/marketplace/.bundle/ruby/2.1.0/gems/rspec-rails-3.2.1/lib/rspec/rails/adapters.rb:6:in `<top (required)>'

So why wouldn't this exist if Test::Unit::AutoRunner exists, if the method has been renamed across versions we should attempt to pick its replacement (if one exists) instead?

This version from the Ruby codebase doesn't have that method. It has no alternative that I can see. Compare to the test-unit gem version.

So do we just need this check on line 65? As the first one should be guaranteed to use the gem?

@cupakromer Actually, that's the line I experienced the error.
FYI: in an app running Ruby v2.1.5 and Rails v3.2.21.

@orien Good question. I think it was being defensive for changes in the future. In which case, your check is actually better. It seems the method was introduced sometime between the test-unit 2.4.0 and 2.4.9 gems. :+1:

we should attempt to pick its replacement (if one exists) instead?

@JonRowe I didn't see a clean replacement for the Ruby version. The gem version seems like it has an alternative in: Test::Unit.run=. We would need to set it to true. However, several of the gems with the newer version also have this method, but have simply deprecated it. So we would need to check for it after the newer method.

@orien if you want to add the 2nd fallback for run= I think this will be good. Given we now have an additional check I think we should move the logic into a helper. Something like disable_testunit_autorun!. We can then call it from both sections of the code and let it handle all the checks.

@cupakromer I used a non bang version of that method name. As per http://dablog.rubypal.com/2007/8/15/bang-methods-or-danger-will-rubyist

This looks good to me :)

Thanks for this @orien :blue_heart:


Oracle IPv6 problem

I installed Debian to my Oracle ARM VM and followed this guide.
ip a output:
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 02:00:17:00:aa:2b brd ff:ff:ff:ff:ff:ff
    altname enp0s3
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic eth0
       valid_lft 86388sec preferred_lft 86388sec
    inet6 fe80::17ff:fe00:aa2b/64 scope link
       valid_lft forever preferred_lft forever

I found a workaround. I manually installed the dhclient and run the command from the terminal.
dhclient -6 eth0
How can I solve this issue?

It's weird. My current network file is:
[Match]
Name = eth0

[Network]
DHCP = ipv4
NTP = <IP_ADDRESS>

[DHCPv4]
UseHostname = false

It's working at least for me.
Maybe you don't have to use systemd-networkd, but just stick to to old ifup & /etc/interfaces
You can refer to https://github.com/bohanyang/debi/discussions/81

I manually installed the dhclient

Usually dhclient should be pre-installed and it's used by ifupdown & /etc/interfaces
In my guide, I purged it since systemd-networkd can do DHCP by itself.

I did a clean Debian 12 install.
Create a new file /etc/systemd/network/10-eth0.network with the following content.
[Match]
Name = eth0

[Network]
DHCP = ipv4
NTP = <IP_ADDRESS>

[DHCPv4]
UseHostname = false

Run this command:
systemctl stop networking && systemctl stop ifup@eth0 && systemctl start systemd-networkd
then this:
systemctl enable systemd-networkd
apt purge -y --auto-remove ifupdown isc-dhcp-client

After the reboot I don't have IPv6 connection

seam, kernel version: 6.1.0-9-amd64, use bbr fq_pie

All IPv6 in my Oracle VMs are down suddenly.

All IPv6 in my Oracle VMs are down suddenly.

My config still works.

Yeah, so maybe there's an issue of Oracle's DHCP / IPv6 auto config.


ChatMemberUpdated.invite_link missing when joining public groups

Hi. I did some testing and it looks like the invite_link field of the ChatMemberUpdated class is present only when joining private groups. For public groups, the field is missing even when the user does join via a link and not via the username of the group.
I expect that the added value of the invite link is smaller for public groups as they can be found by anyone, but this behavior is was unexpected as the documentation does not suggest it. If you could document this behavior or if the behavior could be updated, I'd be grateful.

It works however when people join when pressing on a chat folder invite link.

Another insight: Apparently the link is there for groups that are newly created today …

For public groups, the field is missing even when the user does join via a link and not via the username of the group.

This is not true. If the user joins the group via an invite link, the field invite_link is present. If the group is public, then users are free to join it directly, even the group was opened via an invite link. And this is exactly the behavior of most apps when user press "Join" button on the chat history screen.

Thanks for the quick reply! Your explanation about the "Join" button hiding away the invite_link does sound understandable. However, joining a newly created group via invite link + join button does give the invite_link attribute (just double checked again). So it seems to me that either the behavior is different for groups greated after some date or it is just inconsistent :/

The behavior depends on the used app. The official Android app is known to use direct join instead of invite link for public chats.

I do not believe it is an app issue only.
I can use Telethon to join a chat with the same invite link with different accounts, in one chat member update it has the link, one doesn't

I tested this again multiple times and each time the invite_link field is present if the user joins the chat using the invite link. I've never managed to reproduce the issue if the chat is joined using the method messages.importChatInvite, and apps don't use the method to join public chats and join them directly, hence absence of the field invite_link is expected.


devenv causing issues when running phx.new

Describe the bug
Following the phoenix example tailwindcss lsp in phx new --install . should work the same as phx new --install hello && cd hello
See issue created in the phoenix repo: https://github.com/phoenixframework/phoenix/issues/5967
To reproduce
Try creating a blank phoenix project using
https://github.com/multivac61/phx_devenv
with a) the direnv devshell and b) nix shell nixpkgs#elixir. The latter one works fine.
Version
Paste the output of $ devenv version here or tell us if you're using flakes.
using flakes, devenv: 1.3.1

Ugh, this turned out to be an implementation detail of direnv: https://github.com/direnv/direnv/wiki/Customizing-cache-location

Ah.. it also doesn't like having the .devenv/ folder there either...

The issue is circumvented by setting
enterShell = "export DEVENV_DOTFILE=$(mktemp -d)";

or by setting devenv.dotfile = "/tmp/devenv-" + baseNameOf ./.; in the flake.nix

Got around to testing this. I think it's duplicate of #1569. The PR causing issues was reverted in #1576.

Confirm it works with revert.

Resolved by #1576.


sqllab can not load

hi @qinzl1, Please fill in the issue template to provide more problem description.

@zhaoyongjie
Probable cause

@qinzl1
Can it be reproduced in the latest version of Superset. The latest version is now 0.38


Add external regressors (both continuous and categorical variables)

Add external regressors (both continuous and categorical variables) in MMM API, see https://github.com/pymc-labs/pymmmc/pull/49

Would this have been addressed @juanitorduz ?

Closed with addition of control_columns


Up numpy to 1.11 and use django_chartit2 to fix runtime issues.

There was a conversation about this on slack (which I cannot seem to find now).  Were you able to get this resolved with virtualenv?

Not sure what to do with this one.  Is anyone else having the issues described in https://github.com/owocki/pytrader/issues/57 ?

Yes, I get the same django-chartit error. The fix is to directly change django-chartit code, which is not acceptable. Django-chartit2 should have that resolved. Moreover, we need django-chartit2 to solve the created_on_str problem. I wrote about this on Slack.

I'm good with merge here.  Can you please rebase this branch on the latest master?

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.1 ETH (69.21 USD @ $692.1/ETH) attached to it.

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
Questions? Checkout Gitcoin Help or the Gitcoin Slack
$0 more funded OSS Work available on the Gitcoin Issue Explorer


[MRG] Enable multiple discrete targets per recording

-base datasets now accept a list of strings as target name
-as a result base datasets and window datasets will return multiple values as y in __getitem__
-added tests to verify this
-added an example to demonstrate how to get from instantiation of a dataset class to pytorch dataloader

Open points:

One has to see whether this breaks skorch when using a multitarget dataset with EEGClassifier
It is unclear to me how this would work with an event dataset. There one has to pass the multiplte targets through mne objects like Annotation

This idea was also mentioned in https://github.com/braindecode/braindecode/issues/257#issue-926197775.

Conflicts to be merged apparently @gemeinl .. see also comment above for examples

a-m-a-z-i-n-g