Renderer consumes CPU after update to latest Insiders version

VSCode Version: 1.23.0-insiders x64 commit 7c62e560a2e494a1b0b4d39561dc5c1d837a5263
OS Version: Windows 8.1 x64

After update to latest version window is empty (only main menu bar is visible).
Renderer process consumes 16-20% CPU but nothing is changing.

Does this issue occur when all extensions are disabled?: Yes

@kirusyaga can you run "code --verbose" from the command line and see if any output is printed?

@bpasero The output is here:
Error: Failed opening file C:\Users\%username%\AppData\Roaming\Code - Insiders\logs\20180416T115148\main.log for writing: No such file or directory
    at RotatingLogger (C:\Program Files\Microsoft VS Code Insiders\resources\app\node_modules.asar\spdlog\index.js:16:3)
    at Object.t.createSpdLogService (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:218:588)
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:492:254
    at Object.v [as _notify] (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:82:572)
    at Object.enter (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:85:924)
    at n.Class.derive._oncancel._run (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:87:719)
    at n.Class.derive._oncancel._completed (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:87:160)
    at Server.<anonymous> (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:161:996)
    at Object.onceWrapper (events.js:293:19)
    at emitNone (events.js:86:13)
    at Server.emit (events.js:188:7)
    at emitListeningNT (net.js:1290:10)
    at _combinedTickCallback (internal/process/next_tick.js:77:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)
[main 11:51:48] Starting VS Code
[main 11:51:48] from: c:\Program Files\Microsoft VS Code Insiders\resources\app
[main 11:51:48] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  add: false,
  a: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  'open-url': false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false,
  issue: false,
  'skip-getting-started': false,
  'skip-release-notes': false,
  'sticky-quickopen': false,
  'disable-restore-windows': false,
  'disable-telemetry': false,
  'disable-updates': false,
  'disable-crash-reporter': false,
  'skip-add-to-recently-opened': false,
  status: false,
  s: false,
  'file-write': false,
  'file-chmod': false }
[main 11:51:48] Resolving machine identifier...
[main 11:51:48] Resolved machine identifier: 9731b3fdb2c4ff69a63f12589d5e6bfa83aafc07a1ac452f1fd5cd90f74d5cbb
[main 11:51:48] update#setState idle
[main 11:51:50] windowsService#whenSharedProcessReady
[main 11:52:18] update#checkForUpdates, state =  idle
[main 11:52:18] update#setState checking for updates
[main 11:52:18] RequestService#request https://vscode-update.azurewebsites.net/api/update/win32-x64/insider/7c62e560a2e494a1b0b4d39561dc5c1d837a5263
[main 11:52:20] update#setState downloading
[main 11:52:20] RequestService#request https://az764295.vo.msecnd.net/insider/dfeffb55b62cc2c1dde5cc1e25e98632eeb7744b/VSCodeSetup-x64-1.23.0-insider.exe

adding @joaomoreno for the (maybe unrelated) spdylog stacktrace that shows up.
@kirusyaga can you share a screenshot how VSCode looks after it started like this?

@bpasero

@kirusyaga does it make any difference if you run with "code --disable-gpu" from the command line?

Error: Failed opening file C:\Users\%username%\AppData\Roaming\Code - Insiders\logs\20180416T115148\main.log for writing: No such file or directory
That %username% is weird. It looks like the user has a problem in one of his variables, possibly HOMEPATH.
@kirusyaga Whats the value of your HOMEPATH variable?

@bpasero Visually nothing is changed. In console also nothing.
@joaomoreno HOMEPATH is not presented. Username is kirusyaga, but profile folder named as Александр.

@kirusyaga does it make any difference if you run "code-insiders --user-data-dir <some new/empty folder>" from the command line?

@bpasero Yes. Window is opening like normal new profile. My profile is broken. Nice.

So, trouble is Cyrillic symbols in path to profile folder.

@kirusyaga to verify that can you use the --user-data-dir argument with a folder that has the Cyrillic characters and see if you get the same results?

@bpasero Yes. Launch with Cyrillic characters in path give same result.
default

@kirusyaga it would be easier for me to reproduce if you could post the exact Cyrillic letters that you are using in here as text so that I can copy it.

@bpasero Here it is: абырвалг.

@joaomoreno I can reproduce and the reason the workbench is not coming up is due to spdylog crashing very early. To reproduce run "code --user-data-dir C:\Users\<name>\ абырвалг"
  ERR Failed opening file c:\Users\bpasero\Desktop\абырвалг\logs\20180420T163901\output_1_20180420T163909\tasks.log for writing: No such file or directory: Error: Failed opening file c:\Users\bpasero\Desktop\абырвалг\logs\20180420T163901\output_1_20180420T163909\tasks.log for writing: No such file or directory
    at new RotatingLogger (C:\GitDevelopment\monaco\node_modules\spdlog\index.js:16:3)
    at OutputChannelBackedByFile [as constructor] (file:///C:/GitDevelopment/monaco/out/vs/workbench/parts/output/electron-browser/outputServices.js:186:34)
    at create (file:///C:/GitDevelopment/monaco/out/vs/base/common/types.js:164:14)
    at InstantiationService._createInstance (file:///C:/GitDevelopment/monaco/out/vs/platform/instantiation/common/instantiationService.js:106:35)
    at InstantiationService.createInstance (file:///C:/GitDevelopment/monaco/out/vs/platform/instantiation/common/instantiationService.js:67:29)
    at OutputService.instantiateChannel (file:///C:/GitDevelopment/monaco/out/vs/workbench/parts/output/electron-browser/outputServices.js:499:45)
    at OutputService.createChannel (file:///C:/GitDevelopment/monaco/out/vs/workbench/parts/output/electron-browser/outputServices.js:465:32)
    at OutputService.onDidRegisterChannel (file:///C:/GitDevelopment/monaco/out/vs/workbench/parts/output/electron-browser/outputServices.js:439:32)
    at OutputService [as constructor] (file:///C:/GitDevelopment/monaco/out/vs/workbench/parts/output/electron-browser/outputServices.js:391:23)
    at create (file:///C:/GitDevelopment/monaco/out/vs/base/common/types.js:164:14)
    at InstantiationService._createInstance (file:///C:/GitDevelopment/monaco/out/vs/platform/instantiation/common/instantiationService.js:106:35)
    at InstantiationService._createAndCacheServiceInstance (file:///C:/GitDevelopment/monaco/out/vs/platform/instantiation/common/instantiationService.js:163:41)
    at InstantiationService._getOrCreateServiceInstance (file:///C:/GitDevelopment/monaco/out/vs/platform/instantiation/common/instantiationService.js:111:29)
    at InstantiationService._createInstance (file:///C:/GitDevelopment/monaco/out/vs/platform/instantiation/common/instantiationService.js:78:36)
    at InstantiationService.createInstance (file:///C:/GitDevelopment/monaco/out/vs/platform/instantiation/common/instantiationService.js:67:29)
    at ActionBarRegistry.createActionBarContributor (file:///C:/GitDevelopment/monaco/out/vs/workbench/browser/actions.js:219:54)
    at ActionBarRegistry.setInstantiationService (file:///C:/GitDevelopment/monaco/out/vs/workbench/browser/actions.js:215:22)
    at Workbench.initServices (file:///C:/GitDevelopment/monaco/out/vs/workbench/electron-browser/workbench.js:384:68)
    at Workbench.startup (file:///C:/GitDevelopment/monaco/out/vs/workbench/electron-browser/workbench.js:95:18)
    at WorkbenchShell.createWorkbench (file:///C:/GitDevelopment/monaco/out/vs/workbench/electron-browser/shell.js:58:27)
    at WorkbenchShell.createContents (file:///C:/GitDevelopment/monaco/out/vs/workbench/electron-browser/shell.js:39:35)
    at WorkbenchShell.open (file:///C:/GitDevelopment/monaco/out/vs/workbench/electron-browser/shell.js:326:43)
    at file:///C:/GitDevelopment/monaco/out/vs/workbench/electron-browser/main.js:46:23
    at Object.notifySuccess [as _notify] (file:///C:/GitDevelopment/monaco/out/vs/base/common/winjs.base.js:1185:59)
    at Object.enter (file:///C:/GitDevelopment/monaco/out/vs/base/common/winjs.base.js:867:30)
    at Promise_ctor._run (file:///C:/GitDevelopment/monaco/out/vs/base/common/winjs.base.js:1083:29)
    at Promise_ctor._completed (file:///C:/GitDevelopment/monaco/out/vs/base/common/winjs.base.js:1051:18)
    at runCallback (timers.js:789:20)
    at tryOnImmediate (timers.js:751:5)
    at processImmediate [as _immediateCallback] (timers.js:722:5)

@bpasero Just to confirm, you could reproduce by using cyrilic in a path provided to --user-data-dir?

@joaomoreno yes

I can confirm I have an identical problem. My username contains the character 'ø', which now makes the insiders build fail to start. Changing the --user-data-dir to a path which does not contain that character fixes the issue.
The stable release (1.22.2) works as expected.

I pushed a workaround for now to not crash so badly when we fail to instantiate the spdylog writer. Turns out we already had code in place to protect from failing loads thanks to Alex, but the output channel was failing very early on.
@sandy081 fyi maybe you want to quickly check my changes via https://github.com/Microsoft/vscode/commit/594b8b8debc41caed0fb9a07a2c43dff7ceef2fd

@bpasero This will break Output channels when not writing into file. When user switches between output channels, they will become empty as there is no way to retrieve content now

I was falling back to old way of writing into channels if spdlog fails. I removed this fallback this milestone 1e5c0c3e4e11af82e82d7761d7875646d1c6336b. You can get that back. But I would really want to remove this fallback because for further enhancements to output channel which depends on spdlog.

@sandy081 this is not a real fix, I would expect some regressions. Previously VS Code would not start at all without my workaround. Do you think the current behaviour with my fix is worse than before? I think its clear that we will work on a fix for May.

@bpasero IMO The better workaround would be to bring back my fallback 1e5c0c3e4e11af82e82d7761d7875646d1c6336b. I was doing the same as you except that I fallback to old way of writing into Output channels. This will not have any regressions as it was there in last milestone.
When we fix it in May, we can remove the workaround.

@bpasero Pushed the previous workaround I was using. As said, this will not break output channels if there is an issue creating spdlog logger.

@sandy081 I don't see issues running dev with a user-data-dir containing a non-ascii character (eg ø) any more. I do not understand if this is because of your workaround or if the new spdlog version actually fixed the issue. Moving it to you in order to check if the issue is fixed already, since I don't understand how to repro.

I too do not see any issues after removing the workaround I added before for the crash.
Hence removed the workaround.
To verify:

Open VS Code using an user directory that has non-ascii character (eg ø)
Verify that VS Code starts normally and the output channels are properly written
Verify that there is no crash

Reopening this as the crash from spdlog is not fixed.

@joaomoreno I still see following error in the console with our log files
Error: Failed opening file C:\Work\abcd├╕\logs\20180906T081642\main.log for writing: No such file or direc
    at new RotatingLogger (C:\Work\vscode\node_modules\spdlog\index.js:16:3)
    at Object.createSpdLogService (C:\Work\vscode\out\vs\platform\log\node\spdlogService.js:24:26)
    at C:\Work\vscode\out\vs\code\electron-main\main.js:301:59
    at Object.notifySuccess [as _notify] (C:\Work\vscode\out\vs\base\common\winjs.base.js:1191:59)
    at Object.enter (C:\Work\vscode\out\vs\base\common\winjs.base.js:867:30)
    at Promise_ctor._run (C:\Work\vscode\out\vs\base\common\winjs.base.js:1089:29)
    at Promise_ctor._completed (C:\Work\vscode\out\vs\base\common\winjs.base.js:1057:18)
    at Server.<anonymous> (C:\Work\vscode\out\vs\base\parts\ipc\node\ipc.net.js:228:17)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:106:13)
    at Server.emit (events.js:208:7)
    at emitListeningNT (net.js:1378:10)
    at _combinedTickCallback (internal/process/next_tick.js:135:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

Updated node-spdlog library to support w_char in file names. Thanks to @gnaggnoyil for hinting it.
With this crash no longer occurs with non ascii or special characters (tested with all reported characters). Added a smoke test to launch VS Code with special characters in user data dir.


GCP Hosted ML Pipelines Mailing List - Address Not Found

The link to apply for Alpha access to GCP Hosted ML pipelines at https://www.kubeflow.org/docs/pipelines/installation/overview/#gcp-hosted-ml-pipelines returns:
550 5.1.1 The email account that you tried to reach does not exist. Please try double-checking the recipient's email address for typos or unnecessary spaces. Learn more at https://support.google.com/mail/?p=NoSuchUser w11si699990wmk.0 - gsmtp
This is prevent users from apply for alpha access and occurrences of this have been reported to the kubeflow-discuss mailing list: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/kubeflow-discuss/etUgxdXvF_A/TJ_hcbqxAgAJ

@sarahmaddox @joeliedtke - as per Sarahs Slack message I have opened this ticket. It would seem that I'm unable to assign the ticket to Joe directly however. (https://kubeflow.slack.com/archives/CA4M298LD/p1581285707007400)

/assign @joeliedtke

I see that this PR addresses the issue of the mailing list: https://github.com/kubeflow/website/pull/1628

This also affects us. We also want to request access to this Alpha release :)

Thank you for raising this issue, this has been corrected in kubeflow/website pull #1628. Changes to the Kubeflow website are currently being published to master.kubeflow.org, here is the updated Installation options page. The correct email address to request access to the alpha is<EMAIL_ADDRESS>


Can't find the data to run main_test_avatarposer.py

Thank you for your work!
When running main_test_avatarposer.py the following error occurs:
KeyError: Caught KeyError in DataLoader worker process 0.
Original Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/_utils/worker.py", line 302, in _worker_loop
    data = fetcher.fetch(index)
  File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/_utils/fetch.py", line 58, in fetch
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/usr/local/lib/python3.8/dist-packages/torch/utils/data/_utils/fetch.py", line 58, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/content/AvatarPoser/data/dataset_amass.py", line 66, in __getitem__
    rotation_local_full_gt_list = data['rotation_local_full_gt_list']
  File "/usr/local/lib/python3.8/dist-packages/numpy/lib/npyio.py", line 260, in __getitem__
    raise KeyError("%s is not a file in the archive" % key)
KeyError: 'rotation_local_full_gt_list is not a file in the archive'

KeyError: 'rotation_local_full_gt_list is not a file in the archive'..
Downloaded BMLrub and HDM05 datasets and placed some of the files into AvatarPoser/data_cameraready_fps60/dataset1/test. And when I tried to load these .npz files separately they seem to have different keys.
There were ['trans', 'gender', 'mocap_framerate', 'betas', 'dmpls', 'poses'] keys, but no 'rotation_local_full_gt_list'.
Can you help me, please, to find the right data to test?

Hi, thanks for your interest in our work! You should firstly run prepare_data.py to preprocess the original data.


helm init with TLS getting "Error: could not ping Tiller: context deadline exceeded"

Issue
I am trying to install helm in an AWS eks cluster, with TLS enabled. To do this, I have followed the steps outlined in this blog post:

using openssl to generate

tiller.cert.pem
tiller.key.pem
ca.cert.pem

run the following commands to initialise helm and tiller:

    kubectl -n kube-system create sa tiller

    kubectl create clusterrolebinding tiller-cluster-rule \
        --clusterrole=cluster-admin \
        --serviceaccount=kube-system:tiller

    helm init \
      --service-account tiller \
      --tiller-image gcr.io/kubernetes-helm/tiller:v2.14.3 \
      --tiller-tls --tiller-tls-cert ./tiller.cert.pem \
      --tiller-tls-key ./tiller.key.pem \
      --tiller-tls-verify --tls-ca-cert ca.cert.pem \
      --upgrade \
      --wait

The cluster role binding and service account are both created, but on running helm init... the command hangs for a while then I receive the response (when running with the --debug flag):
[debug] Created tunnel using local port: '7381'

[debug] SERVER: "<IP_ADDRESS>:7381"

[debug] Host="", Key="./tiller.key.pem", Cert="./tiller.cert.pem", CA="ca.cert.pem"

Error: could not ping Tiller: context deadline exceeded

Looking inside the cluster, a tiller-deploy pod has been created, and logging it I get:
[main] 2019/12/05 10:53:32 Starting Tiller v2.14.3 (tls=true)
[main] 2019/12/05 10:53:32 GRPC listening on :44134
[main] 2019/12/05 10:53:32 Probes listening on :44135
[main] 2019/12/05 10:53:32 Storage driver is ConfigMap
[main] 2019/12/05 10:53:32 Max history per release is 0

There are also a tiller deployment and service  in the kube-system namespace. When trying to run any helm commands with the certificates, for example:
helm ls --tls
    --tls-ca-cert ca.cert.pem
    --tls-cert helm.cert.pem
    --tls-key helm.key.pem

the request times out with the response Error: context deadline exceeded. I have also tried adding the certificate to my helm home and running helm ls --tls, but get the same response. With the --debug flag, I get this output:
[debug] Created tunnel using local port: '8050'

[debug] SERVER: "<IP_ADDRESS>:8050"

[debug] Host="", Key="C:\\Users\\ruaridh\\.helm\\key.pem", Cert="C:\\Users\\ruaridh\\.helm\\cert.pem", CA="C:\\Users\\ruaridh\\.helm\\ca.pem"

Error: context deadline exceeded

When I initialise helm without TLS on the same cluster (after cleaning the cluster), it works as expected.

Other info
Output of helm version:
Client: &version.Version{SemVer:"v2.14.3", GitCommit:"0e7f3b6637f7af8fcfddb3d2941fcc7cbebb0085", GitTreeState:"clean"}
Server: Times out before retrieving
Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.8", GitCommit:"211047e9a1922595eaa3a1127ed365e9299a6c23", GitTreeState:"clean", BuildDate:"2019-10-15T12:11:03Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"windows/amd64"} Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.8-eks-b8860f", GitCommit:"b8860f6c40640897e52c143f1b9f011a503d6e46", GitTreeState:"clean", BuildDate:"2019-11-25T00:55:38Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform: AWS
Result of kubectl logs tiller-deploy-xxxxxxxxx-yyyyyy -n kube-system:
Name:               tiller-deploy-xxxxxxxxx-yyyyyy
Namespace:          kube-system
Priority:           0
PriorityClassName:  <none>
Node:               ip-xx-x-xx-xxx.eu-west-2.compute.internal/xx.x.xx.xxx
Start Time:         Thu, 05 Dec 2019 10:53:31 +0000
Labels:             app=helm
                    name=tiller
                    pod-template-hash=xxxxxxxxx
Annotations:        kubernetes.io/psp: eks.privileged
Status:             Running
IP:                 xx.x.x.xxx
Controlled By:      ReplicaSet/tiller-deploy-xxxxxxxxx
Containers:
  tiller:
    Container ID:   docker://68690e701655b92341541b01653bb03675bdd211f72f67fb6b32ff3a32022058
    Image:          gcr.io/kubernetes-helm/tiller:v2.14.3
    Image ID:       docker-pullable://gcr.io/kubernetes-helm/tiller@sha256:c09393087c4be55023f86be979a9dfe486c728703eba996344adc9783f261baa
    Ports:          44134/TCP, 44135/TCP
    Host Ports:     0/TCP, 0/TCP
    State:          Running
      Started:      Thu, 05 Dec 2019 10:53:32 +0000
    Ready:          True
    Restart Count:  0
    Liveness:       http-get http://:44135/liveness delay=1s timeout=1s period=10s #success=1 #failure=3
    Readiness:      http-get http://:44135/readiness delay=1s timeout=1s period=10s #success=1 #failure=3
    Environment:
      TILLER_NAMESPACE:    kube-system
      TILLER_HISTORY_MAX:  0
      TILLER_TLS_VERIFY:   1
      TILLER_TLS_ENABLE:   1
      TILLER_TLS_CERTS:    /etc/certs
    Mounts:
      /etc/certs from tiller-certs (ro)
      /var/run/secrets/kubernetes.io/serviceaccount from tiller-token-xxxxx (ro)
Conditions:
  Type              Status
  Initialized       True
  Ready             True
  ContainersReady   True
  PodScheduled      True
Volumes:
  tiller-certs:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  tiller-secret
    Optional:    false
  tiller-token-xxxxx:
    Type:        Secret (a volume populated by a Secret)
    SecretName:  tiller-token-xxxxx
    Optional:    false
QoS Class:       BestEffort
Node-Selectors:  <none>
Tolerations:     node.kubernetes.io/not-ready:NoExecute for 300s
                 node.kubernetes.io/unreachable:NoExecute for 300s
Events:
  Type    Reason     Age   From                                                Message
  ----    ------     ----  ----                                                -------
  Normal  Scheduled  22m   default-scheduler                                   Successfully assigned kube-system/tiller-deploy-xxxxxxxxx-yyyyyy to ip-xx-x-xx-xxx.eu-west-2.compute.internal
  Normal  Pulled     22m   kubelet, ip-xx-x-xx-xxx.eu-west-2.compute.internal  Container image "gcr.io/kubernetes-helm/tiller:v2.14.3" already present on machine
  Normal  Created    22m   kubelet, ip-xx-x-xx-xxx.eu-west-2.compute.internal  Created container tiller
  Normal  Started    22m   kubelet, ip-xx-x-xx-xxx.eu-west-2.compute.internal  Started container tiller

For anyone who is stuck on the same issue, I ended up following the flux documentation and using cfssl to create the certificates.
I ran this command to initialize helm:
  helm init --upgrade --service-account tiller --history-max 10 \
      --override 'spec.template.spec.containers[0].command'='{/tiller,--storage=secret}' \
      --tiller-tls \
      --tiller-tls-cert ./tls/server.pem \
      --tiller-tls-key ./tls/server-key.pem \
      --tiller-tls-verify \
      --tls-ca-cert ./tls/ca.pem \

and it installed it correctly. If I ran the above command with the --wait flag, I had the same issue as before with it timing out. It looks like the --wait flag doesnt use the correct tls certificates, and I couldn't find a way to apply them manually. Instead I used the command:
kubectl wait --for=condition=Ready pods --all -n kube-system
to wait for the tiller pod to be ready.

thanks for the resolution @ruaridhnewman. Closing!


"Mark as unread" button broken?

Is it just me or is that button in issues/pr's (right sidebar) not working?
If I hit it, it'll pop-in and grey out, but nothing happens:

Reloading shows the fresh and clickable Mark as unread button again...
Running version <IP_ADDRESS>2 in Firefox 58.0

Are you reloading the same page for which you marked the notification as unread, then it is the expected behavior.

Sure, that makes sense.
Here are some more details:
I have 5 unread notifications, I hit Mark as unread on two more issues.
If I then go to the github main page my addons to track GitHub notifications  (Advanced GitHub Notifier & Notifications Preview for GitHub) show still 5 notifications. Also, waiting 5-10min doesn't change something.
If I go to https://github.com/notifications I also have a weird result:

It correctly shows 7 unread, but only 4+1 on a repo basis.

It correctly shows 7 unread, but only the old 4+1 on a repo basis.

Unread / Participating include the "mark as unread" conversations; the repo counts and Notifications Preview for GitHub don't

Hmm, it also doesn't mark issues/pr's in their lists as unread again.
There is no such indication displayed again:

Other apps on mobile to track GitHub notifications don't pick them up either.
Most of such addons/apps seem to work the same then and only consider the other count.
Is the Mark as unread feature useful then at all?
Too me it looks more confusing than helpful... 😕

Hmm, it also doesn't mark issues/pr's in their lists as unread again.

It should. Pre-existing conversations are brought up.

There is no such indication displayed again:

That indicator has nothing to do with read status.

Other apps on mobile to track GitHub notifications don't pick them up either.

Yes, Mark as Unread is local, it doesn't actually mark them as unread on GitHub

Is the Mark as unread feature useful then at all?

No it's not useful

Closing this as it's hardly reproducible. If you can find a way to reproduce it please post it or send a PR.


Ludwig reports that validation loss improved while it shows it to increase - confusing

Describe the bug
@w4nderlust
I am training a tagger like in here. I also specify class weights to force it to be more aggressive in assigning the class X. (to be honest I am not sure, if it takes effect)
(...)
   loss:
      type: softmax_cross_entropy
      class_weights:
        X: 1.
        O: 0.02

What confuses me is that in the reports ludwig prints out I see the validation loss increase but ludwig reports that the loss improved (which I would assume would mean for it to decrese), saves the model and continues training. Does ludwig make the comparison on some different value than it prints out?
#  loss is in first numeric column

Epoch   8
────────────────┼──────────────┼─────────────────┤
│ vali              │ 0.0885 │     0.3998 │           0.9671 │          0.9530 │       1.0925 │          0.0347 │
├───────────────────┼────────┼────────────┼──────────────────┼
Validation loss on combined improved, model saved

Epoch   9
─────────────────┼──────────────┼─────────────────┤
│ vali              │ 0.0990 │     0.4143 │           0.9654 │          0.9542 │       1.1041 │          0.0363 │
├───────────────────┼────────┼────────────┼──────────────────┼
 Validation loss on combined improved, model saved

To Reproduce
I cannot provide the data I train on, but I observed it frequently, so maybe it can be seen on some other dataset you test on. I may try to provide synthetic data in the future, but maybe the problem can be diagnosed without it just looking at the code.
Expected behavior
Save the model and report improvement only when the validation loss truly decreses and it can be noticed in the console report.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: [e.g. iOS]
Centos7
Version [e.g. 22]
Python version
3.6.8
Ludwig version
current master

Additional context
Add any other context about the problem here.

A bunch of things here:

the weighting on the classes should work, I can doublecheck to be sure, will look into it. In the mean time you can try using "sampled_softmax_cross_entropy" as loss where it should also make a difference.
the improvement is calculated on a "combined" output feature by default. The loss of "combined" is the sum of the losses of the individual output features plus regularization. Becuase I believe you have only one class what i suspect is happening is that you also added regularization or other parts of the loss that make the value of the loss of "combined" different from the value of the loss of your output feature. I can't be sure without doublechecking with a reproducible example thoug. One thing you can do to check for this hypothesys is to set the training validation_field to "tags" (which I believe is the name of your output feature) and there should be no misalignment. i see how this could be confusing as it is probably not clearly explained in the docs, I will think about revising the description accordingly and also probably print the value of combined (it is printed when there's more than one feature and hidden when there's only one at the moment, but if you look at the output training statistics you'll find it there).
If you can reproduce the issue with synthetic data that would be of great help for me to go and fix the probem if there is one.

I did add regularization in my settings so this may be the case. I think printing the combined loss even if one feature is present would probably do it. Thank you.

Good, so after looking at the combined loss in the training_statistics.json file, can you confirm that the early stopping was performed at the right time?
Just to be sure there is not any logic issue, it's ont a reporting issue.

We fixed thsi and changed the logic, improved prints and now it should work fine. Let me know if you still have problems.


Does this tool support hiding the left rooms sidebar using a params called show-rooms(Boolean)

I wanna  vue-advanded-chat provide only one room for the user to use such as ChatGPT. So there is no need to load the left room sidebar.
I am curious that if this tool can provide a param that controls to show or hide the left room sidebar. And I recommend to call id show-rooms

The red rectangle should be deleted when set show-rooms="false"
Thanks!

Sorry, I have found rooms-list-opened params. But I am still confused that the left-top button could been disabled?

You can use single-room param instead:

single-room can be used if you never want to show the rooms list on the left. You still need to pass the rooms prop as an array with a single element.

You can use single-room param instead:

When using single room, we miss typing indicator, as it is shown only in the rooms list.
When using single-room mode, typing should be shown in the chat or in the chat header.


Razor LSP support

cshtml support, that'd be nice. thank you.

cshtml seems to be handled by "Razor". It's an additional plugin that needs to be downloaded: https://github.com/OmniSharp/omnisharp-vscode/blob/6608b739146123e920f410da5f29b9abfa8309eb/src/omnisharp/server.ts#L322-L326

more info here https://github.com/OmniSharp/omnisharp-vim/issues/546


Link to Sandbox Guide

Need a link to this guide https://github.com/microsoft/AzStackHCISandbox on this page at the end, as it is currently the best one out there, with minimal issues. Tried the Private Forest guide and the HCI Eval guide, both of those guides have blocking issues right now.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e58cb678-2c81-b3c2-cfce-9ff96c0e18cc
Version Independent ID: b34bb724-ea12-7063-8d9c-0ff0ae6db190
Content: Nested virtualization in Azure Stack HCI - Azure Stack HCI
Content Source: azure-stack/hci/concepts/nested-virtualization.md
Service: azure-stack
Sub-service: azure-stack-hci
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

@jkingdon-ms
Thanks for your feedback! We will investigate and update as appropriate.

Thanks! I had made a pull request to add this, but looks like you beat me to it. :) https://github.com/MicrosoftDocs/azure-stack-docs-pr/pull/10439

Thanks Marilee!

Looks like I don't have access to re-open the issue though @MarileeTurscak-MSFT


Where did all these focus outlines come from?

Help with managing focus outlines
For some reason, in my development environment I get a persistent focused state for any component I interact with: buttons, checkboxes, etc. This behavior isn't seen when interacting with the same components on either the official documentation or the official Storybook.
Usually, my projects follow the helpful hack outlined here, so that users interact with things focus-free by default but a single tab will restore it:
body:not(.user-is-tabbing) button:focus,
body:not(.user-is-tabbing) input:focus,
body:not(.user-is-tabbing) select:focus,
body:not(.user-is-tabbing) {
  outline: none;
}

However, nothing I've tried works for removing the focus outline from Carbon's checkbox, radio, etc. I must be missing something fundamental, since I don't see this issue with any published implementation.
Has anyone else encountered this issue and found a fix?

Hi 👋 our checkbox/radio UI is achieved by a pseudo element in <label>, etc. instead of <input> itself. You can see it by inspecting the DOM. Hope it helps!


ch 6 : there is a line dropped in the blueprints

in the final blueprint of ch 6 the line of reading csv file{df= pd.read_csv(file) } is missed which causes errors

Thanks for identifying the bug and sorry that it was missed out.
It's fixed now and would be great if you could confirm @ahmed-shiha

it works now. Thanks a lot for your reply and for this great book in general 😃


Question: how to add ngrx/store, etc to the seed?

I've seen advanced seed but I don't need all of its features, so I'm trying to add ngrx myself. From what I see, I need to add '@ngrx/core' and '@ngrx/store' to NPM_DEPENDENCIES array:
  /**
   * The list of NPM dependcies to be injected in the `index.html`.
   * @type {InjectableDependency[]}
   */
  NPM_DEPENDENCIES: InjectableDependency[] = [
    { src: 'core-js/client/shim.min.js', inject: 'shims' },
    { src: 'zone.js/dist/zone.js', inject: 'libs' },
    { src: 'zone.js/dist/long-stack-trace-zone.js', inject: 'libs', buildType: BUILD_TYPES.DEVELOPMENT },
    { src: 'intl/dist/Intl.min.js', inject: 'shims' },
    { src: 'systemjs/dist/system.src.js', inject: 'shims', buildType: BUILD_TYPES.DEVELOPMENT },
    // Temporary fix. See https://github.com/angular/angular/issues/9359
    { src: '.tmp/Rx.min.js', inject: 'libs', buildType: BUILD_TYPES.DEVELOPMENT },
    { src<EMAIL_ADDRESS>inject: "libs", buildType: BUILD_TYPES.DEVELOPMENT },
    { src<EMAIL_ADDRESS>inject: "libs", buildType: BUILD_TYPES.DEVELOPMENT },
    { src<EMAIL_ADDRESS>inject: "libs", buildType: BUILD_TYPES.DEVELOPMENT }
  ];

But when I 'npm start' I get these errors:

core.min.umd.js?1486120453962:1 Uncaught TypeError: Cannot read property 'Observable' of undefined
at core.min.umd.js?1486120453962:1
at core.min.umd.js?1486120453962:1
(anonymous) @ core.min.umd.js?1486120453962:1
(anonymous) @ core.min.umd.js?1486120453962:1
store.min.umd.js?1486120453962:1 Uncaught TypeError: Cannot read property 'core' of undefined
at store.min.umd.js?1486120453962:1
at store.min.umd.js?1486120453962:1

So, how can I added it?

Here are a couple of issues related to your problem. You don't have to use script injection but the module loader instead.


Update project and specs to use .NET 5.0

Once all the other issues have been resolved and released as a Nuget package, upgrade the csproj and fsproj to use .NET 5.0 and release that as it's own Nuget package.

Resolved in #15


Gamepad events refactor

Objective

Remove redundant gamepad events
Simplify consuming gamepad events.
Refactor: Separate handling of gamepad events into multiple systems.

Solution

Removed GamepadEventRaw, and GamepadEventType.
Added bespoke GamepadConnectionEvent, GamepadAxisChangedEvent, and GamepadButtonChangedEvent.
Refactored gamepad_event_system.
Added gamepad_button_event_system, gamepad_axis_event_system, and gamepad_connection_system, which update the Input and Axis resources using their corresponding event type.

Gamepad events are now handled in their own systems and have their own types.
This allows for querying for gamepad events without having to match on GamepadEventType and makes creating handlers for specific gamepad event types, like a GamepadConnectionEvent or GamepadButtonChangedEvent possible.
We remove GamepadEventRaw by filtering the gamepad events, using GamepadSettings, at the source, in bevy_gilrs. This way we can create GamepadEvents directly and avoid creating GamepadEventRaw which do not pass the user defined filters.
We expose ordered GamepadEvents and we can respond to individual gamepad event types.
Migration Guide

Replace GamepadEvent and GamepadEventRaw types with their specific gamepad event type.

@bzm3r @Shatur I'd like your opinions on this :)

Because we have the Input<GamepadButton> resource having a GamepadButtonEvent for indicating button presses seems redundant. I would definitely consider removing it altogether.

I think this is analogous to the KeyboardInput event and Input<KeyCode>. Input<T> is convenient, and I think it makes sense as a default but shouldn't preclude a bespoke accounting of input events. Aside from the overhead of multiple HashMaps, Input<T> isn't suited for only recording a subset of possible inputs.

I haven't used a gamepad with Bevy yet, so I don't have a clear opinion on this, sorry :)

I think this is analogous to the KeyboardInput event and Input<KeyCode>. Input<T> is convenient, and I think it makes sense as a default but shouldn't preclude a bespoke accounting of input events.

The distinction here is that KeyboardInput is used to update Input<KeyCode> and Input<ScanCode>, whereas GamepadButtonEvent (previously GamepadEvent { event_type: GamepadEventType::ButtonChanged(..), ... }) is created after Input<GamepadButton> has been updated. What KeyboardInput and the GamepadButtonEvent event do provide though is between-frame event ordering, which could become a mute point when/if event ordering is added to the Input resource https://github.com/bevyengine/bevy/issues/5984.

ping

Valid! I'll prioritize this on Monday.

Note that in your changelog you called it RawGamepadEvent: this is wrong and should be fixed to improve searchability.

Updated!

See the updated description https://github.com/bevyengine/bevy/pull/6965#issue-1499420672.

bors r+


fix(tags): fixed the reorder-tags component example

Closes #248
Description
This fixes the ts error below:
Property 'label' is missing in type '{ children: Element; key: string; value: string; w: "fit-content"; }' but required in type 'ReorderItemOptions'.ts(2741)

Is this a breaking change (Yes/No):
No

@taroj1205
This error can be resolved by installing 1.4.2 of @yamada-ui/react.


[Feature request] Create a VSCode plugin

Clear and concise description of the problem
The development experience of vitepress website could be better in vscode the markdown-it extensions were handled by the markdown preview.
Suggested solution
It looks like vscode supports markdown-it plugins, so it might be quite easy to add a VitePress powered preview.
Alternative
Use vscode simpleBrowser.api.open command to show the development server.
Additional context
No response

Yeah, that might be possible, but should be out of the scope of this project. VitePress also has its own extra extensions for markdown-it. This project only holds some basic ones.


Unable to call unbound::local_zone class anymore

Since PR #153 unbound::local_zone class does not exists anymore.
Unfortunately, my puppet code was heavily using this feature to configure different local zones regarding of host type, eg :
ensure_resource('unbound::local_zone', '.', { 'type' => 'refuse' })
if( $zone1) { ensure_resource('unbound::local_zone', 'my.zone1.net', { 'type' => 'transparent' }) }
if( $zone2) { ensure_resource('unbound::local_zone', 'my.zone2.net', { 'type' => 'transparent' }) }

How can I use this feature again ?
Merging all local zones a in single hash and pass it as a ::unbound class parameter seems kind of hard because of puppet immutable variable design

I use unbound::local_zone as a resolver whitelist on my hosts :

Set resolver to localhost only
Disable all zones resolving ({ '.' => 'refuse' })
Add custom zones using multiple unbound::local_zone calls in separate puppet profiles

Your code above is working, but hard to implement in my case because ::unbound::local_zone class is called from multiple puppet manifests.

@b4ldr I assume then that the unbound class would then contain a create_resources('unbound::local', $local_zone...) or are you thinking something different?
@jlutran Would storing all of the local_zone data in the same hiera data object be enough for you?  I'm curious to learn more about why local_zone is in multiple manifests on the same node.  I assume just for organization purposes.  Is that right?

@b4ldr I assume then that the unbound class would then contain a create_resources('unbound::local', $local_zone...) or are you thinking something different?

yes, it would mean going back to the old way of doing it.

Bringing back the local_zone class while also supporting a parameter on the unbound class that, if defined, is passed to create_resources seems like the best of both worlds.  I'm speculating here, as I don't use the feature, but users would be able to define the resources centrally in hiera, or scattered throughout the manifest.

@jlutran Would storing all of the local_zone data in the same hiera data object be enough for you? I'm curious to learn more about why local_zone is in multiple manifests on the same node. I assume just for organization purposes. Is that right?

I use a default unbound profile, and then set some local zones on custom roles. For example :
class profiles::unbound(
    $default_nameservers = hiera('public_nameservers', []),
    $proxy_endpoint = hiera('proxy', undef),
    $git_endpoint = hiera('git_source', undef),
) {
    unbound::forward { '.': address => $default_nameservers }
    ensure_resource('unbound::local_zone', '.', { 'type' => 'refuse' })
    ensure_resource('unbound::local_zone', $default_sync_server, { 'type' => 'transparent' })

    if( $proxy_endpoint ) {
        $proxy_domain = regsubst($proxy_endpoint, '^http[s]?://([^:/]+).*$', '\1')
        ensure_resource('unbound::local_zone', $proxy_domain, { 'type' => 'transparent' })
    }
    if( $git_endpoint ) {
        $git_domain = regsubst($git_endpoint, '^http[s]?://([^:/]+).*$', '\1')
        ensure_resource('unbound::local_zone', $git_domain, { 'type' => 'transparent' })
    }
}

class profiles::custom_role($metrics_endpoint) {
    ensure_resource('unbound::local_zone', $metrics_endpoint, { 'type' => 'transparent' })
}

And so on...

#182 has been merged to resolve this.  Apologies for the trouble.


The value reset icon for scale and rotation does not appear.

Godot version:

3.2.3 RC5 mono
OS/device including version:

win10 64 home
nvidia gt440
Issue description:

The value reset icon for scale and rotation does not appear.
If you change the values like scale or rotation of a sprite node (for example) and later want to reset the size or angle to its original value, you will have to use the keyboard and enter the values.

Steps to reproduce:
Just add a sprite node, assign a chart to it, and change its scale or rotation.
You will notice that the reset icon does not appear.
Minimal reproduction project:

It is not necessary.

Here you can see that in a node of type "RichTextLabel" the icon does appear.

Steps to reproduce:
Just add a sprite node, assign a chart to it, and change its scale or rotation.

I don't know what you mean by "chart". I tried adding an image to the sprite node and I can't reproduce the issue in 3.2.3 rc5 mono:

Minimal reproduction project:
It is not necessary.

It is necessary.

It was mistranslated, I meant image.
I use translator to create my reports, although I check it, sometimes this happens, I don't have a high level of English.
Ok, now they do appear, I don't know why that could happen.
I will be attentive and if it happens again I will see what causes it.

Is that still relevant then? If the issue no longer exist, possibly it can be closed, @akien-mga ?

I can't say, it happened to me that time but it hasn't happened again.

Well, without reproducible project, and confirmation from the others - it's hard to track in that matter :/

I can't reproduce either. The issue does seem valid given the GIF in the original post, so there might be cases where it happens. But until we can narrow it down, nothing can be done to solve it, so we might as well close it, and reopen if a way to reproduce it is found.


update the API to return the detail of the newly created function

the createFunction api is returning Promise right now: https://github.com/microsoft/vscode-azurefunctions/blob/main/src/vscode-azurefunctions.api.d.ts#L11
I am from Azure Data team, we need the information of newly created function and project (if no project exists) so that we can process the new function file.

What information are you specifically looking for? Also can you describe a bit of your scenario?

path to the newly created file containing the function
if a new project is created, please also include the path to the newly created project. (this is no needed if I can assume the new file is already in the same directory as the project file)
the options user provided in the wizard, e.g. language, template, auth type, class name, namespace name...

Per offline discussion, you need this information because you're creating an http trigger and then modifying it after-the-fact to be a sql trigger. Instead, I would prefer if you created a new .net template just for sql (see https://github.com/Azure/azure-functions-templates - the Cosmos one might be the most relevant example). A few of the benefits:

You can make the prompts specific to your scenario. For example the default name could be SQLTrigger instead of HTTPTrigger. You can also add extra prompts that may not apply for http triggers
The template can also be used outside the scope of VS Code (aka through VS, the func cli, or the dotnet cli)
It also just simplifies your logic because .NET templates have built-in ways to support things like adding a nuget reference to the csproj at the same time the template is created

We try to keep our API as minimal as possible so that we can avoid the possibility of causing breaking changes in the future. I think a .NET template is the way you want to go and I would rather not add this information to our API until you investigate that option first. Once we add this info, we can't really change or remove it without a lot of headaches

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

This feature request is now a candidate for our backlog. The community has 240 days to upvote the issue. If it receives 5 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Making "Send Message" button responsive for Mobile divces

Description
Currently Send Message button looks perfect for Desktop view, but not for mobile.
This button should be responsive inorder to look great on mobile devices.
(In order to work on this issue firstly setup project on your local machine, and register/login to look for "Send Message" button on the profile page of other users.

Screenshots
Mobile View

Desktop View

Hey @Mayuresh-22 ! I'm interested in fixing this issue.
Please assign this issue to me.

I would like to fix this issue. Please assign it to me under hacktoberfest.

@Mayuresh-22 I can fix this issue. I have experience fixing various css responsiveness issues for various websites. So please assign it to me

Hey @Mayuresh-22 ! I'm interested in fixing this issue. Please assign this issue to me.

Hey, I am assigning this issue to you @saffi-786

I would like to fix this issue. Please assign it to me under hacktoberfest.

Hey @Ahnaf-codes, I'll surely create new issues in this repo and will assign it to you. I guarantee you that you'll not find short of quality issues in this repo.

I would like to fix this issue. Please assign it to me under hacktoberfest.

Hey @yashi-15 , I'll surely create new issues in this repo and will assign it to you. I guarantee you that you'll not find short of quality issues in this repo for Hacktoberfest 2023

@Mayuresh-22 thank you for assigning the issue to me.

@Mayuresh-22 can you plz help solving this as I don't have much knowledge of PHP or MySQL. I have to access the account page to modify the CSS

styling of the button.

@Mayuresh-22 can you plz help solving this as I don't have much knowledge of PHP or MySQL. I have to access the account page to modify the CSS styling of the send message button

@Mayuresh-22 can you plz help solving this as I don't have much knowledge of PHP or MySQL. I have to access the account page to modify the CSS styling of the send message button

Hey @saffi-786, the error you are facing is because of the misconfiguration between password mentioned in the connection.php file and the password of MySQL.
But have downloaded and installed the XAMPP server?

Yes, Sir, I have downloaded and installed the XAMPP server, and it's showing the same error on the browser when I enter a username on the search field in the accounts.php
Do I need first to register to view all the pages?

Yes, Sir, I have downloaded and installed the XAMPP server, and it's showing the same error on the browser when I enter a username on the search field in the accounts.php Do I need first to register to view all the pages?

Ohkay,
Changing File content

Open your connection.php file from db folder.
Change the $user variable value to root (in string double quotes)
Change the $pswd variable value to "" (Empty string)
Start your xampp server and start Apache and MySQL (every time you work on this project)

Creating Database

Go to http://localhost/phpmyadmin/ and click on "new" option from left side bar.
Enter minglr and press create
Press import option from top bar and chose the .sql file from the db folder and click Import

Now you are done option project in the browser create a new account and you are done.
I know these steps are a bit tricky but even if you face any issue I am there for you.

It's showing this error.

It's showing this error.

Start MySQL in XAMPP

I'm getting this error when I'm starting the MySQL

Have you previously installed any MySQL server on your machine?

Yes I installed MySQL on my system some days back

Yes, it's causing the issue because MySQL by default works on port 3306.
So I suggest you change the port number of MySQL in XAMPP (which will not affect other MySQL servers)
Follow these steps to change the MySQL server port in XAMPP:

Open your XAMPP server

Click on the "Config" option of the MySQL module & click on my.ini (Shown below)

Open with any text editor, now wherever you see 3306 change it with a new port number (here, 3307) throughout the file.

And you are done hopefully, this will solve your issue.
(I suggest you update the git repo that you have cloned on your machine because different changes were made to the repo)

I changed the MySQL port.
Now MySQL is running, but it is still denying access on http://localhost/phpmyadmin/

Hey @saffi-786, I guess I missed one step, change the port 3306 also in php.ini file. (Shown below)

(Change throughout the file)

Followed the above steps
Still the same error

You can try removing the previously installed MySQL server.

Anyone working on this?

hey bro, I was looking at your project and found it very interesting.

if the task is not completed, could you please assign it to me

hey bro, I was looking at your project and found it very interesting.

Thank You so much for your words @abneribeiro

I would be interested to resolve the issue incase nobody has been assigned.

I am ready to solve this issue  if the issue has not been assigned or solved yet

Hey @KhushiAgarwal-01, SWOC hasn't started yet and will be starting from the 1st of Jan but still, you can get familiar with the codebase and I am sure you'll get something to work on.

@pankhuri92 I am assigning this issue to you, start working on it.

Thanks a lot @Mayuresh-22 ! Will keep you updated.

@Mayuresh-22, I would like to bring in to ur info that there isn't any send message button any more as I went through the site. So  I might have to add the send button there.

Okay @pankhuri92, I'll check that out.

This issue has been successfully solved by @pankhuri92 under SWOC S4 2024


Identity server 4 does not hit front channel logout url every time when client log out.

I have deployed an identity server 4 app on IIS which is running on this url http://identity.colaraz.net and i am running a .net mvc core app on localhost using code flow. I have registered a frontchannel logout url for this mvc client. Now when i logout from my mvc client app, front channel logout got hit some time and some time not. This only happens when i deploy identity server 4 on server but when i run both identity server 4 and mvc client app on localhost then this works ok. I am unable to understand why this is happening please help

I have registered a frontchannel logout url for this mvc client.

One guess -- your IdentityServer is https, and the local app on localhost is http. Check your browser console window for errors.

both identity server and localhost are http.

Maybe it is a "third party cookie in iframe" problem.
IOW - browsers are making it harder to use front-channel logout these days. I don't know if your problem is related to that - but my advice would be to switch to back-channel logout anyways.

hey @leastprivilege  thanks for your response i will test backchannel , let suppose that it is due to browser but i hvae implemented DefaultUserSession, IUserSession interface to check logged in clients and before logging out i get the logged in clients and then print it on the loggedOut view to check the clients which were logged in but this also some time give me logged in clients and some time not why this happens on server and on localhost it works fine.

Yes that’s absolutely possible.

but i am also having problem in single sing on, it works some time and some time not why the
behavior is uncertain


[BUG] Events Manager not sending notification

Describe the bug
Events manager notification feature is not working. After creating an event, on clicking the blue "Notification" button, filling out the title and message in the pop up and clicking the orange "send message" button, all Illinois app users who have "starred"/"favourited" the event, should have received a push notification. However, the users are not getting a push notification.
To Reproduce
Steps to reproduce the behavior:

Set the Illinois App privacy settings to 5.
Create an event from web browser events manager and publish
In the illinois app, go to the event and "star" the event.
From events manager, go to the event and send notification.
See that no push notification is received by the Illinois App user.
Able to reproduce this issue in both DEV and PROD instances.

Found this open issue. Is this related?
I do not see an endpoint for /event/eventID/devicetokens in notificationsBB. So not sure how utilizing notificationsBB would be beneficial.
Expected behavior
A user with a "starred" event is able to get push notifications.
Debugging
The tokens required for the push notification https://github.com/rokwire/events-manager/blob/develop/user_events.py#L767 as of now tries to get from the form / pop up box. However, it should have been from /event/eventID/devicetokens end point here .
I see that for notification here https://github.com/rokwire/events-manager/blob/develop/user_events.py#L771 it just returns a 200 status. I also do not see any logs in eventsBB and events manager dev instance in AWS . I thought the logger.info would have some info logged in AWS.
Would connecting the tokens with '/event/<id>/devicetokens', methods=['GET'] request work?
Additional context
Add any other context about the problem here.

@bingzhang appreciate your input in this issue.

Ok. sounds good.
@vburgett please see the description and comments above.. The feature of sending notifications is not supported by Events Manager now.


Create mini genes.gtf.gz for RNA-seq test outputs

This PR adds a mini-GTF for use alongside the rna-seq test data.

@pinin4fjords still needed?

Probably not, since I'd forgotten about this- I'll close.


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2023-09-18)
Features

🚀 增加了常用的 Scrcpy 高级配置 (ac52df2)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/viarotel-org/escrcpy/releases/tag/v1.1.0 :sunflower:


Outdated documentation

Looks like recent versions of Lumigo has changed lumigo.init from a function call to an actual function. This section in README should be updated accordingly to avoid confusion.

Hi, we had a wrong type for lumigo.init in our code. the documentation was correct and we fixed the type.
you can see the PR here

Hi, we had a wrong type for lumigo.init in our code. the documentation was correct and we fixed the type.
you can see the PR here


Testnet

Is there a testnet available?
I cant find any information on this regard.
Thx

Hi, at the moment no.
Mooniswap is only available on the mainnet.


Add g_chatReplayMaxMessageAge

Can be set to > 0 to make chat replay messages expire. Any chat message older than current time - g_chatReplayMaxMessageAge <minutes> will be excluded from chat replay. The chat is still included in the replay file, it just won't be sent to clients. Off by default (messages don't expire).
refs #1335

Side note: we might be able to restore message timestamps now, but I will take a look at that in the future.


Call to undefined method WP_CLI\I18n\MakePotCommand::get_file_data_from_string() (wp i18n make-pot)

@swissspidy:

[x] Yes, I reviewed the contribution guidelines.
[x] Yes, more specifically, I reviewed the guidelines on how to write clear bug reports.

Describe the current, buggy behavior
wp i18n make-pot . ./resources/lang/sage.pot --include="app,resources"
Theme stylesheet detected.
PHP Fatal error:  Uncaught Error: Call to undefined method WP_CLI\I18n\MakePotCommand::get_file_data_from_string() in phar:///usr/local/bin/wp/vendor/wp-cli/i18n-command/src/IterableCodeExtractor.php:58

Remember to provide some context to make sure we're all on the same page when reasoning about this.
Describe how other contributors can replicate this bug

Ensure there is a directory that contains PHP files (files that just contain <?php with a php file extension are sufficient).
Invoke this command so that directory is scanned:
wp i18n make-pot . ./resources/lang/sage.pot --include=\"app,resources\"
Note the fatal error:

Theme stylesheet detected.
PHP Fatal error:  Uncaught Error: Call to undefined method WP_CLI\I18n\MakePotCommand::get_file_data_from_string() in phar:///usr/local/bin/wp/vendor/wp-cli/i18n-command/src/IterableCodeExtractor.php:58

Describe what you would expect as the correct outcome
No PHP fatal errors, a POT file is generated from the scanned source files.
Let us know what environment you are running this on
Error with PHP 8.1:
OS:     Linux <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Wed Mar 2 00:30:59 UTC 2022 x86_64
Shell:  /bin/bash
PHP binary:     /usr/bin/php8.1
PHP version:    8.1.8
php.ini used:   /etc/php/8.1/cli/php.ini
MySQL binary:   /usr/bin/mysql
MySQL version:  mysql  Ver 8.0.30-0ubuntu<IP_ADDRESS> for Linux on x86_64 ((Ubuntu))
SQL modes:
WP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:      phar://wp-cli.phar/vendor
WP_CLI phar path:       /home/build/src/example.com/site/web/app/themes/sage
WP-CLI packages dir:    /home/build/.wp-cli/packages/
WP-CLI global config:
WP-CLI project config:  /home/build/src/example.com/site/wp-cli.yml
WP-CLI version: 2.6.0

Same error with PHP 7.4:
OS:     Linux <IP_ADDRESS>-microsoft-standard-WSL2 #1 SMP Wed Mar 2 00:30:59 UTC 2022 x86_64
Shell:  /bin/bash
PHP binary:     /usr/bin/php7.4
PHP version:    7.4.30
php.ini used:   /etc/php/7.4/cli/php.ini
MySQL binary:   /usr/bin/mysql
MySQL version:  mysql  Ver 8.0.30-0ubuntu<IP_ADDRESS> for Linux on x86_64 ((Ubuntu))
SQL modes:
WP-CLI root dir:        phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:      phar://wp-cli.phar/vendor
WP_CLI phar path:       /home/build/src/example.com/site/web/app/themes/example
WP-CLI packages dir:    /home/build/.wp-cli/packages/
WP-CLI global config:
WP-CLI project config:  /home/build/src/example.com/site/wp-cli.yml
WP-CLI version: 2.6.0

Provide a possible solution
A similar issue points to a missing PHP extension, but this extension is installed for the used PHP versions (8.1; 7.4):
https://github.com/wp-cli/i18n-command/issues/138
This issue occurs with wp i18n installed using wp package install wp-cli/i18n-command:dev-main.
The issue doesn't occur when using wp i18n from cloned repository.

This issue occurs with wp i18n installed using wp package install wp-cli/i18n-command:dev-main.

It sounds like you're using an old version. Have you tried wp package update?
Alternatively, uninstall the package and update to WP-CLI nightly which has the latest version of the package.

Have you tried wp package update?
Yes, wp package update did something, I ran it multiple times. But the issue persists.

Alternatively, uninstall the package and update to WP-CLI nightly which has the latest version of the package.
Yes, this fixed the issue. No package uninstallation was necessary by the way. I just ran wp cli update --nightly (as root/sudo) and after the successful update the same wp i18n make-pot command worked just fine.

@swissspidy: It would be great if a new release could be published, so the fixes are also in the stable version.


Feature: The Card should Contain more info about user profile

what more info

social links ,some short descriptions something like that

I think we can skip this, anyhow when the user click on profile it will take to github where they have social links there.
I will be adding more issue


Fix automatic screenshots behaviour

This PR contains two fixes for automatic screenshots behaviour:

when continueAfterFailure is set to true screenshots are not taken on failures
step expressions can be strings which are not appropriate for file names, so they now are not use an attachement name

Can someone please take a look at this?

@kerrmarin its' determined by XCTest frameworks. Sometimes it's "Screenshot of main screen (ID 1)_UUID", sometimes its "Screenshot_UUID". But reports have them grouped under activities so they are still easily distinguishable.

Sounds good to me 👍Thanks for this!


refactor: bl-tag should create own CE namespace for Input

Current behavior

We are directly importing Input which is registered as bl-input. This behaviour will produce errors for consumers of both tag/index-with-deps.js button/index-with-deps.js because it will try to register bl-button twice.
Expected behavior

We have to namespace our Input with custom name scoped to tag package

@davidrus please also make sure to add dependency on Input and use import as @blaze-elements/input.


Toots with pictures are not posted on twitter.

When I post a toot with a picture on mastodon, it's not posted on twitter. Toots without pictures are working.

Can you send me links to the toot and tweet with the problem? Images are cross-posting OK for others as far as I know.

This is the last toot with a picture that worked on May, 23:
https://social.tchncs.de/@DerMario/102145808347105427
https://twitter.com/DerMario/status/1131567142975881216
The next toots with pictures didn't work:
https://social.tchncs.de/@DerMario/102211881733059400
https://social.tchncs.de/@DerMario/102220284097628133
https://social.tchncs.de/@DerMario/102234588257727146

Can you send me links to the toot and tweet with the problem? Images are cross-posting OK for others as far as I know.

I think it's recent, I also have this problem.

this was due to a recent change I made to support larger videos on twitter.

Thank you for fixing. :)


Fix 'OpenVirtualDiskParameters' BOOL fields

While reworking the vhd package I'd mistakingly replaced some of the fields
in the OpenVersion2 structure with the incorrect types. They're defined as
Windows BOOLS which is just a type alias for an int, and I'd put their type as
go bools.
As the type is already passed into some functions, to avoid a breaking change just
convert the incorrect type to a new structure with the correct definition internally.
Truthfully this turns out a bit better as supplying a bool makes more sense and is
more go friendly.
Signed-off-by: Daniel Canter<EMAIL_ADDRESS>

@katiewasnothere PTAL


Readme issues

Doesn't mention how to get an API key
Confusing part in Browser section "[TODO] I think this is ok as we the AT.send if clients want to do anything based on the DOM, e.g."

Doesnt mention dependencies such as jQuery, it is obvious from the snippet but still a nice to have.

The API url is outdated, decided against divshot, update to cloudfront url.

Readme mentions the need to register with an "Advocay analyst" but doesn't say how or why

Typo in Automatic section of Implementation. Reads "... In order to send metadata about these Touchpoints and Sharepoints you should defined a global advocate_things_data variable, e.g."

The snippet needs to have a uniform way of showing variables to be replaced by the client.

Anything that binds to a DOM element should be represented within a jQuery(document).ready(function{ ... }) in the snippets. Makes it more obvious and easier to implement i think

NB the Advocate Things

Document the latest AT JSON spec e.g sharepoint_name => sharepointName

Data Object Spec:
The optional parameters should have a comment of //Optional so someone could first try to implement with the bare minimum to make it just work.

This readme is gonna get really long, maybe have an  index on top to easily navigate through the readme

Add documentation about how to retrieve the shareId at any point and any other usefull methods provided by the sdk

Should document callback and event listener arguments etc.

@nbrl I am guessing all this is done due to the documentation rewrite?

All addressed by rewrite.


No events on app_mention

app_mention is not listening to the events,
app_mention | Subscribe to only the message events that mention your app or bot | app_mentions:read
We had to add message.channles to makeit work (all messages) but need to filter too much of data and extra traffic.
message.channels | A message was posted to a channel | channels:history |
Please check and help if we are missing anything on this.

@seratch We have added app to the channel and subscribed bot event "app_mentions:read"
Still no luck.

Just in case, I've verified with a brand-new app, and it works for me. Could you follow the following steps? It should work for you if your app is correctly configured.

Run /invite @your-bot-user in the channel
Post a message @your-bot-user hello in the channel

I'm happy to be of help to you but I'd like to keep this place as the tracker for bug reports/questions about slackclient PyPI package. When you have general questions about the Slack platform, could you send questions to our platform support agents from https://my.slack.com/help/requests/new (or via /feedback in your Slack workspace) instead?  It'd be greatly appreciated if you could understand this.

As I've already provided an answer to this question, let me close this issue now.


contributing guidelines

emphasize that Hank implementations can be completely different from Ink internals, and that the goal is not to stay apace with new Ink features.
One thing that would be great is folx writing more examples that test deliberately for edge cases. The current example suite is light on that.

maybe if there are ever people wanting to contribute


harmonize logging

no log messages in exceptions (use standard exception)
no message level explicitly in log text (handled by spdlog)

at some point i'll remove spdlog, right now it's mainly useful for debugging


FastAPI and SQLModel problem with session and basic filtering with exec

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
# -----------------------------------------------------------------------
# db/db.py
from sqlalchemy.ext.asyncio import AsyncSession, create_async_engine
from sqlalchemy.orm import sessionmaker

def get_engine():
    from app.core.settings import settings
    return create_async_engine(settings.db_url, echo=settings.db_echo, future=True)

async def get_session() -> AsyncSession:
    async_session = sessionmaker(
        get_engine(), class_=AsyncSession, expire_on_commit=False
    )
    async with async_session() as session:
        yield session

# -----------------------------------------------------------------------
# controllers/shop.py
from db.db import get_session
from db.models.shop import Shop
from fastapi import Depends
from sqlalchemy import select
from sqlmodel import Session

class ShopController:
    def search(self, shop_name, db_session: Session = Depends(get_session)):
        query = select(Shop).where(Shop.name == shop_name)
        results = db_session.exec(query)
        return results

shop_controller = ShopController()

# -----------------------------------------------------------------------
# routes.py
from controllers.shop import shop_controller
from fastapi import APIRouter

router = APIRouter()

@router.get("/callback/")
async def search(shop_name: str):
    return shop_controller.search(shop_name=shop_name)

Description
I am trying to use SQLModel with FastAPI and I created basic example to filter by shop name, but I am getting error:
*** AttributeError: 'Depends' object has no attribute 'exec'

at file controllers/shop.py on line results = db_session.exec(query).
I also tried with execute but the same thing.
How can I manage to do this? What am I doing wrong here?
Operating System
macOS
Operating System Details
No response
FastAPI Version
0.70.0
Python Version
3.9.2
Additional Context
No response

You're assuming the dependency will be resolved on the search function.
# -----------------------------------------------------------------------
# db/db.py
from sqlalchemy.ext.asyncio import AsyncSession, create_async_engine
from sqlalchemy.orm import sessionmaker

def get_engine():
    from app.core.settings import settings
    return create_async_engine(settings.db_url, echo=settings.db_echo, future=True)

async def get_session() -> AsyncSession:
    async_session = sessionmaker(
        get_engine(), class_=AsyncSession, expire_on_commit=False
    )
    async with async_session() as session:
        yield session

# -----------------------------------------------------------------------
# controllers/shop.py
from db.db import get_session
from db.models.shop import Shop
from fastapi import Depends
from sqlalchemy import select
from sqlmodel import Session

class ShopController:
    def search(self, shop_name: str, db_session: Session = Depends(get_session)):
        query = select(Shop).where(Shop.name == shop_name)
        results = db_session.exec(query)
        return results

shop_controller = ShopController()

# -----------------------------------------------------------------------
# routes.py
from controllers.shop import shop_controller
from fastapi import APIRouter

router = APIRouter()

@router.get("/callback/")
async def search(results = Depends(shop_controller.search)):
    return results

@Kludex what would be the solution if I want to use search and one more method from ShopController? There is probably a better solution how to use it?

class ShopController:
    def search(self, session: Session, shop_name: str):
        query = select(Shop).where(Shop.name == shop_name)
        results = session.exec(query)
        return results

shop_controller = ShopController()

# -----------------------------------------------------------------------
# routes.py

@router.get("/callback/")
async def search(shop_name: str, session: Session = Depends(get_session)):
    return shop_controller.search(session, shop_name=shop_name)

Makes sense, but now I am getting different error:
*** AttributeError: 'AsyncSession' object has no attribute 'exec'

AttributeError: 'Depends' object has no attribute 'exec'
AttributeError: 'AsyncSession' object has no attribute 'exec'
How are those the same?
    def search(self, session: AsyncSession, shop_name: str):
        query = select(Shop).where(Shop.name == shop_name)
        results = await session.execute(query)
        return results.scalar().all()

I'll not further comment here.


Toolbar button is inserted after url bar in Firefox Developer Edition

Steps to reproduce

Install and launch Firefox Developer Edition
Install Copy Urls Expert and restart

Expected result
CUE toolbar button is appended at the rightmost position in the toolbar
Actual result
CUE toolbar button is appended after the url bar by default

This is by design. If the button has to be added, it should be visible immediately after install. If the user has a few buttons in toolbar already, the button will hide in menu panel. (Think about a user installing the extension for first time, they would "complain" there is no toolbar button as claimed on AMO page)

I can change it so it appears after the search bar. Thoughts?

Hmm, if I install CUE in Firefox Nightly, the button is added to the end of the toolbar correctly like all other add-ons... but in Developer Edition it's only added after the url bar. Maybe there's a discrepancy somewhere in the versions?
If the user's display isn't wide enough to show all buttons, it gets added to a panel with all extra buttons, this could easily be explained with a simple comment or in the add-on description, if someone doesn't know that.
Adding it after the search bar would be an improvement, but I'm not sure how it would work if the search bar has been removed by the user beforehand. I don't think it's ideal.


Custom CSS replaces existing one instead of enhancing it.

Calling below:
(swap! config/!resource->url assoc "/css/viewer.css" "notebooks/custom.css")
works as (probably) intended. However I don't think anyone wishes to build complete CSS for Clerk from the scratch. I think typical use case would be just to add/replace some (small) CSS subset. A couple of classes/ids.
What do you think?

Actually, replacing the full stylesheet is actually the intended usage. Clerk currently uses tailwind 3's play cdn. This is a javascript script that generates the used classes on-demand (using a mutation observer on the dom). This is primarily intended as a dev affordance.
When publishing in production, tailwind recommends to compile a custom stylesheet containing only the used classes.  So we have this abstraction as a way for a user to override the stylesheet, compile it with a different tailwind config or user-appended styles (that can again include the viewer.css) but after going down that road we realized we don't want to be in the business of running a css pipeline for folks.
Also note that you can add inline styles using the html viewer like so:
^{:nextjournal.clerk/visibility :hide-ns}
(ns newlines
  (:require [nextjournal.clerk :as clerk]))

^{::clerk/viewer :html ::clerk/visibility :hide}
[:style ".my-custom-class { color: blue; background-color: red; border-radius: 5px;}"]

(clerk/html [:div.my-custom-class.p-2 [:h1 "Hello 👋"]])

Please let me know if that works for you.

Thank you, above solution sounds as a reasonable one. I think this is exactly what I need (inline CSS for a couple of custom classes). Need to try that still (be back soon with conclusions).

Works!


Fix create project from database dialog if user doesn't have access to master db

This PR fixes #15162
For contained databases, the user doesn't have permission to access master, hence listDatabases doesn't produce any result. In this case, we should use the database provided in the connection profile.

Resolved the conflict, but facing issues with Authentication failure while pushing the code changes. Working on getting it fixed.

Pull Request Test Coverage Report for Build 903805531

3 of 5 (60.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0004%) to 43.427%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/sql-database-projects/src/dialogs/createProjectFromDatabaseDialog.ts
3
5
60.0%

Totals

Change from base Build 901159617:
-0.0004%

Covered Lines:
26575

Relevant Lines:
55612

💛  - Coveralls


[DO NOT MERGE] Deep-embed graph

Hi all! Thank you for initiating this extremely exciting project.
This PR is my attempt to simplify & give more principled approach to maintain the implication graph.
[Syntactic data]
Each axiom (equation) is now has a concrete, syntactic term, named Equation type. A graph, Graph type, is defined as Equation -> Equation -> Status where Status denotes the current state for the corresponding edge. For example, a concrete instance for the subgraph of our interest is given as a term subgraph: Graph.
[Semantic interpretation]
The validity of this graph object is enforced with Graph.valid definition - e.g., subgraph_valid would be the final theorem for the subgraph. The Graph.valid requires corresponding semantic proof for each syntactic edges. Notably, Edge is defined with typeclass and has few benefits below.
Benefits are as follows:

Compared to doing metaprogramming (with Python script or lean) to (re)construct the graph from the Lean code, deep-embedding the graph from the first place should be more direct, less error-prone, and robust.
Smaller TCB: the final theorem like subgraph_valid ensures the correctness of the whole graph (that is to be extracted and processed by tools like image-generators later) inside Lean.
Simplification: (1) the repeated (G: Type*) [Magma G] for each theorem is now omitted, and (2) we don't have to give explicit names to theorems thanks to typeclass mechanism. (e.g., instance : (Edge true .e2 .e4) where instead of theorem Equation2_implies_Equation4 (G: Type*) [Magma G] (h: Equation2 G) : Equation4 G :=)
Edge Synthesis: see Edge.trans_true, Edge.abduct_false0 and Edge.abduct_false1: the typeclass mechanism allows us to nicely derive some facts from existing facts. This is tested in the code.

One caveat would be performance scalability issue, especially for the final theorem (like subgraph_valid). If typeclass resolution mechanism takes O(n) (where n is the number of instances), it would take prohibitively long. If it takes O(log n), it should (I think) compile in time.
If you find this useful, I can make it a mergeable state quickly.

I like this idea but it needs to be coordinated with #36 , perhaps one can discuss it on the Lean Zulip thread https://leanprover.zulipchat.com/#narrow/stream/458659-Equational/topic/Syntax ?


Kotlin 2.1.0 Compatibility issue

Failed to build when upgrading to Kotlin 2.1.0.
https://github.com/hantsy/spring-r2dbc-sample/actions/runs/12061917240/job/33634757623

Thank you for the report. Could you show me the error message?

Apologies. I was able to review the error message. This issue will be resolved in #1460.

Please try Komapper v5.0.0.
https://github.com/komapper/komapper/releases/tag/v5.0.0

Verified, works as always. Thanks for your quick fix.


[FEATURE REQ] Include documentation and/or default implementation for ICustomWebUi

Is your feature request related to a problem? Please describe.
When using the KeyVaultClient to get Secrets with impersonated authentication the developer must first use the AuthenticationContext to AcquireTokenAsync. When building a public client application the impersonation scenario is important to bypass the need to embed secrets in an application that is public. This results in using the AcquireTokenAsync(string resource, string clientId, Uri redirectUri, IPlatformParameters parameters); method.
This method expects an IPlatformParameters object which is platform specific. To construct this object from .Net core you must provide an implementation of ICustomWebUi in order to build a new PlatformParameters object. There seem to be no docs that describe how to implement this but a related and unlinked blog post shows this can be done.
Describe the solution you'd like
Update documentation to include a direct reference explaining how to implement the ICustomWebUi.
Describe alternatives you've considered
I also considered that it would be nice to have the recommended implementation available in a separate package.
Additional context
One of the other challenges with working in this area is understanding that the PlatformParameters object takes a different shape per platform. This results in confusing developers as they search for support on reference articles (e.g. stackoverflow) and find what appears to be broken/incomplete code suggestions. It would also be desirable to include documentation for why this changes shape from the ADAL docs. e.g. of docs from MSAL
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[x] Description Added
[x] Expected solution specified

I think we can close this issue @loarabia, I followed up with the Azure AD team and they're planning to invest in additional documentation around this scenario.

what is the conclustion,have same problem.

@irwang, if you're looking for an implementation of the ICustomWebUi for Wpf applications it can be found at https://github.com/runceel/dotnet-core-wpf-adal-sample/blob/d92f4c1e647f8bad9ee59e190af9b9bacce6a45d/AdalForDotnetWpfSample/MainWindow.xaml.cs
There are two other auth flows that may be useful to know depending on your scenario.

InteractiveBrowserCredential
Calling Key Vault with a shared PublicClientApplication

@irwang, if you're looking for an implementation of the ICustomWebUi for Wpf applications it can be found at https://github.com/runceel/dotnet-core-wpf-adal-sample/blob/d92f4c1e647f8bad9ee59e190af9b9bacce6a45d/AdalForDotnetWpfSample/MainWindow.xaml.cs
There are two other auth flows that may be useful to know depending on your scenario.

InteractiveBrowserCredential
Calling Key Vault with a shared PublicClientApplication

I just with a Console application and change the target to .net core, so wondering why there is no default ICustomerWebUi implementation i can use, instead of create customized customer web ui instance.

Hi @irwang,
The CustomWebUI is an extensibility point specifically created for developers to provide their own UI.
For .Net Core there are other options to build an app that leverages built-in authentication prompts such as the InteractiveBrowserCredential. For more reading, please see this doc about acquiring tokens interactively for ADAL and this doc about .NET Core and auth ux when using MSAL.


Flaky test: RTP12b (untilAttach) - Presence__history__supports_the_param_untilAttach__should_retrieve_members_prior_to_the_moment_that_the_channel_was_attached

Sometimes we get this on Travis:
[09:38:14]: ▸     ✗ Presence__history__supports_the_param_untilAttach__should_retrieve_members_prior_to_the_moment_that_the_channel_was_attached, expected to have Array<ARTPresenceMessage> with count 25, got 1
[09:38:14]: ▸     ✗ Presence__history__supports_the_param_untilAttach__should_retrieve_members_prior_to_the_moment_that_the_channel_was_attached, expected to equal <user1>, got <user25>

┆Issue is synchronized with this Jira Bug by Unito

Closing outdated issue. The codebase changed drastically since then and all skipped tests were unskipped, see PRs for https://github.com/ably/ably-cocoa/issues/1406 and https://github.com/ably/ably-cocoa/issues/1848
If you encounter frequently failing test again, please create a new issue with a best guess why it might be happening.


Small docs clarification

Purpose is simply a minor clarification in the docs.

Coverage remained the same at 99.897% when pulling 886995a7576f580cce919c7586254d1fe098aa69 on ghachey:develop into af88d3c6b5a132e4f1ca092a501f2e7c24840cf2 on Fantomas42:develop.

Hello,
thank you for your contribution,
but I have seen a typo on the word 'defalt'.
Please correct it and I will merge.
Regards

Sorry, I think the typo is fixed now

Coverage remained the same at 99.897% when pulling 7fc0b7b476fc1b8f5c428359f5484c9a64234c62 on ghachey:develop into af88d3c6b5a132e4f1ca092a501f2e7c24840cf2 on Fantomas42:develop.


Element in Pong and Adventure shaking in IE

The entire element appears to shake in Internet Explorer (Windows 8) when pressing the keyboard to move the player in the examples:

http://elm-lang.org/examples/pong
http://elm-lang.org/examples/adventure

I think it only happens to examples where the element container is set as middle from what I've seen so far
I recorded an example of what I encounter in Adventure:

I have reduced it down to this bouncing A. Pressing the keyboard arrows randomly bounces the element in IE.
import Graphics.Element exposing (Element, container, middle)
import Keyboard
import Markdown
import Window

view : (Int,Int) -> { x : Int, y : Int } -> Element
view (w,h) _ =
    container w h middle <| Markdown.toElement "A"

main : Signal Element
main =
  Signal.map2 view Window.dimensions Keyboard.arrows

What version of IE is this exactly?

Internet Explorer 11

Okay, the shaking thing is "resolved" in the sense that window just works totally different now. Thanks for hunting this down and making a really small example though!


Prevent blinding error

This PR adds hack to prevent blinding error with Fuji coins funded by a lightning swap
@tiero please review

Is this still needed?

Not needed anymore, closing it.

Not needed anymore


Introduce Travis support

This PR adds support for testing installer functions on Travis. This is achieved through downloading official ev3dev docker OS containers and running installer inside them. I then fixed bugs that prevented the builds from working correctly.
Tests are done for the following configurations:

jessie ev3 image with ev3 installer platform
jessie rpi2 image with brickpi3 installer platform
stretch ev3 image with ev3 installer platform
stretch rpi2 image with brickpi3 installer platform

Reviewing logs:
https://as.com/deporteyvida/2018/12/08/portada/1544256835_676534.html?id_externo_noti=depyvida_mod_port
Note: Amazing job!

Maybe, in the file test.sh, we should add a new tests for the scenario about reinstall java:
https://github.com/ev3dev-lang-java/installer/pull/40/files#diff-63ab6decfd52638355f6a527c3c6dee2R24
What do you think?

I pushed an attempt to do it.
Nore: to enable Travis on this repo, you will need to enable it, because I'm not an owner of this repository. Travis build status should start appearing even for this PR then.

Yup, installing twice works too: https://travis-ci.org/JakubVanek/elj-install/builds/465721089


how to abort message processing if another message recieved?

what I am trying to achieve:
user sends message to my bot -> bot process message and replies
user sends 5 messages really fast -> I want my bot to stop processing 1-4 messages(it least not reply to them) and reply only to message 5
but i still want to save session changes from all messages

This is a contradiction. If you want to save the session data from each update, then you have to process the messages in sequence.
If you want to cancel the update processing of one update while processing another update, then these updates have to be processed concurrently.
So in summary, you want to process updates both sequentially and not sequentially at the some time, which does not make sense.

@KnorpelSenf maybe I explained it wrong, my use case is very simple. I have gpt like bot, when user sends message my bot generates response, all messages I save in history in session. what i want to do is if users sends 2 messages fast, i want to cancel response to first message and reply to second message only, but i still want to keep first message in context in history object in session.

You just repeated the same contradiction.
The solution is not to use sessions. Use a database instead. This will give you control over when data is read and written, which should make it easy to implement the behaviour you're looking for.
Also note that you cannot store the entire message history in your session anyway due to performance issues.
Check out the docs on when to use sessions: https://grammy.dev/plugins/session#when-to-use-sessions


Move all the interfaces to a single file

Purpose

The purpose of this PR is to fix #182

Goals

Maintaining a single type file to store the interfaces

Approach

Created the types.ts file
Moved all the interfaces to the types file except prop types

Checklist

[x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[x] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

Looks good
Nice job @anjula-sack, did you test this out?

yeah I did but I'm gonna do it again after that I'll let you know

Looks good
Nice job @anjula-sack, did you test this out?

yeah I did but I'm gonna do it again after that I'll let you know

Cool

Looks good
Nice job @anjula-sack, did you test this out?

yeah I did but I'm gonna do it again after that I'll let you know

Cool

Ready to be merged


api: lock down 1.0 API descriptors

Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

Codecov Report

Merging #1885 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1885   +/-   ##
=======================================
  Coverage   47.29%   47.29%
=======================================
  Files          89       89
  Lines        8830     8830
=======================================
  Hits         4176     4176
  Misses       3968     3968
  Partials      686      686

Flag
Coverage Δ

#linux
50.66% <ø> (ø)
:arrow_up:

#windows
42.24% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89623f2...c5fe021. Read the comment docs.

LGTM


feedback implementation

Coverage increased (+4.7%) to 100.0% when pulling 5d618ec5329b004ba2cdfcb6dd6b8af3e44b3a02 on staging into 90965f2b1e073f5bb7a1a0d71b7c100eb2f30caf on master.

Coverage increased (+4.7%) to 100.0% when pulling 5d618ec5329b004ba2cdfcb6dd6b8af3e44b3a02 on staging into 90965f2b1e073f5bb7a1a0d71b7c100eb2f30caf on master.

Coverage increased (+4.7%) to 100.0% when pulling 529850b1c5707d5509975d60aad468d91aa03020 on staging into 90965f2b1e073f5bb7a1a0d71b7c100eb2f30caf on master.

Coverage increased (+4.7%) to 100.0% when pulling 529850b1c5707d5509975d60aad468d91aa03020 on staging into 90965f2b1e073f5bb7a1a0d71b7c100eb2f30caf on master.


Elixir support

What
Adds support for the elixir programming language
Checklist

[x] Recorded tests for the new language
[x] Used "change" / "clear" instead of "take" for selection tests to make recorded tests easier to read
[ ] Added a few specific tests that use "chuck" instead of "change" to test removal behaviour when it's interesting, especially:

[ ] "chuck arg" with single argument in list
[ ] "chuck arg" with multiple arguments in list
[ ] "chuck item" with single argument in list
[ ] "chuck item" with multiple arguments in list

[x] Added @textFragment captures. Usually you want to put these on comment and string nodes. This enables "take round" to work within comments and strings.
[ ] Added a test for "change round" inside a string, eg "hello (there)"
[/] Supported "type" both for type annotations (eg foo: string) and declarations (eg interface Foo {}) (and added tests for this behaviour 😊)
[ ] Supported "item" both for map pairs and list entries (with tests of course)
[ ] Add support for "name"

This is great! I'm about to be doing some elixir work. What's left to this? Can I help?

@jaresty help would be great! I haven't had a chance to do any more on this since Sept. The biggest outstanding thing is drink/pour in lists/maps (see Pokey's last comment, I haven't made it to a meetup since).
I don't remember what else is outstanding, but I think its mergable if we get just that working

@r-tae I'd love to help! Could we maybe find some time where you could introduce me to the work?

"call"

⬆ I'm a bit surprised that a module definition is considered a call

⬆ It's also surprising that a function definition is considered a call

"funk"

Are these not function definitions?

"key"

doesn't look right to me; should just be a and b

"value"

Looks like nested values are missing here (ie "Jane" and<EMAIL_ADDRESS>

Ok I kicked the ball down the field a bit; see my changes @jaresty I'm happy to get you up to speed on this PR in a meet-up if you want to carry it to the finish line; not too much left

Thank you for that @pokey - I'm unexpectedly in a job search so it may be some time before I can get back to this.

ok @r-tae if you wanna bring this home go for it. Otherwise I may take a pass again in the future

@r-tae wanted to let you know that community now has an elixir language mode 😄


vendor<EMAIL_ADDRESS>

Ignore ro mount options in btrfs and windows drivers

Signed-off-by: Valentin Rothberg<EMAIL_ADDRESS>

LGTM

/lgtm
/hold

/lgtm

LGTM

/hold cancel


Missing: RAnchor.position

Hi, first time poster! :)
Hopefully this is the correct way to report bugs and issues?

Happ to finally get a response after more than a year @benkiel. ;)
But why remove this kind of attribute that makes the transition from RoboFab to FontParts harder than necessary? Is it so bad to have multiple attributes to access the same data?

Thinking about this some more. We are deathly afraid of the mess that RoboFab became, but perhaps we are being too cautious here.

Ok, we're going to add position to anything that has an x,y.

Referenced in #112

Fixed in https://github.com/robofab-developers/fontParts/commit/02fde94a26c800c15a138c4e8357cd32bbee8de7
Thanks @andyclymer!


Cannot open Electrum Win File

I had the electrum wallet holding ZCL. I have tried to download and open the electrum windows file for BTCP. The file downloads to my computer and when I choose "run" there is a flash across my screen for a second and then nothing. Have tried restarting, redownloading. The file tries to open in internet explorer.
Please advise.
Thank you!

having the same issue

@marleygra I got a 7-zip extractor and was able to open the file. Try that


esmBot says image is over 25MB when it is not

Describe the bug
Sometimes, posting an image under 25MB says it is over 25MB. I do not know what causes this exactly, if it's reading the filesize wrong or what.
Steps to reproduce

Post this GIF.
Attempt to use a command on it.
esmBot should say the image is over 25MB, when it is actually 14.1MB.

Expected behavior
esmBot proceeds as normal, because the image is less than 25MB,
Screenshots

Self-hosted instance?
No
Additional context
No response

The bot gets images through Discord's media proxy instead of the sites themselves (mainly for security/consistency reasons), which means that Discord's encoder is partially to blame here, since it seems to inflate the GIF by a considerable amount:

The GIF handling in lilliput (Discord's image resizer) seems to have many issues in general (here's a notable one), so it could probably be worth making an issue over there as well.


MPU 9250 - Week progress

Tasks :

Obtain accelerometer data.
Simulate the hand movement putting the MPU in a test glove and study the data of the gyroscope and accelerometer.
Meet with Alex to share the progress of the electronics devices.

During that week, I welded again the connections of the IMU device and now I can't reestablish the I2C communication. Jordi left me another device to know what is failing.

Having again communication with MPU-9250 (new one).
Data :

Angular position (PRY)

Work progress 12/04/2021
Done :

First glove prototype with a flex sensor and MPU (test glove).

To do :

Prepare the first oficial prototype with a standard glove and put all the electronical parts.
-Establish the communication between a python program and arduino using the Serial communication.
Find the problem with the YAW rotation. We are receiving incorrect data.
Create a solid code about the RPY rotations (interruption+sum(10values)+sending data).

Aleix :
Working on absolute position of Pitch and Roll of each hand movement, especially those that have the same form and the unique difference is on the IMU perception.
Ibrahim :
Programming the main structure that will identify each hand movement