Bug: Slow performance using with git bash for windows

Bug report
The performance is quite slow. Initializing takes a few seconds, but here is a particularly egregious example:
$ time sdk current

No candidates are in use

real    0m26.581s
user    0m1.809s
sys     0m10.314s

To reproduce
Install sdkman 5.16.0. All configurations are set to default.
System info

OS is Windows 10 Enterprise 21H2 19044.2130 Windows Feature Experience Pack 120.2212.4180.0

$ uname -a
MINGW64_NT-10.0-19044 J09WLN3 3.1.7-340.x86_64 2021-03-26 22:17 UTC x86_64 Msys

Shell version output:

 bash --version
GNU bash, version 4.4.23(1)-release (x86_64-pc-msys)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

The output of sdk version

time sdk current

No candidates are in use

real    0m28.902s
user    0m2.040s
sys     0m10.975s

Ignore this for now - it's now back to a still long time (3.6 seconds) to run the above sdk current java command but not so unreasonable.
I'm not sure why it was so high but it might have to do with some sort of security software running in the background.


Change container image location

Pull Request Test Coverage Report for Build 786870289

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 37.077%

Totals

Change from base Build 786859203:
0.0%

Covered Lines:
340

Relevant Lines:
917

💛  - Coveralls


text inside squares?

I wanted to do a diagram on LTI systems, and this tool was almost perfect but, how can I make it do squares like

(Or if this is the wrong tool, what tool should I use instead?)

This tool is specifically designed to create tikzcd diagrams, specifically creating commutative diagrams. I do not know which tool to use to create a diagram on LTI systems.

oh ok :(


DCOS-21464: fix(serviceform): fix 0 gpu runtime block

This fixes an issue which blocked the user from switching from Mesos runtime to docker runtime if
they provided a 0 gpu setting.
Close DCOS-21464
Testing
To test this:

go to: /#/services/overview/create
Select Single Container
In the General Section click More Settings
Select Universal Contianer Runtime (UCR)
Go to GPUs and enter a value bigger as 0
The Docker Runtime should get disabled here
Change the value of GPUs to 0
Select Docker Runtime

Trade-offs
This solution will have the trade of that in the case of a 0 gpu value the gpus in the JSON will be 0 which is mostly a cosmetic drawback as Marathon will accept it anyways.

Screenshots

LGTM - thanks for the testing instructions!!

2x ✅ => 🏁

@juliangieseke I disagree there. @nLight made an observation about how the code could be a little better and I wanted to give @Poltergeist the chance to decide if he thinks changing this might be worth his time.
If there are comments like this I would like us to not merge PRs after a second approval, but read them first. There is no rush to get this in, it doesn't matter if it would be merged now or two hours later.

approve == ok to merge, 2x approve == merge.
if you dont want it to be merged, either dont approve or add hold merge label - how'd you tell a bot not to merge in such a situation?

We have no bot, so I told it in the message of my approval. Let's not behave like bots please.

I cant see anything that states "pleas dont merge yet" 🤔

Feel free to change it or not, I don't mind :)

How can you change after a merge? I mean opening a second PR blows this out of proportion

:tada: This PR is included in version 2.19.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Does cdk-local with with python based CDK projects

Before getting into cdklocal I wanted to confirm it will work with cdk projects that are using python. -Thanks

Hi @rgoodwin , thanks for the question. The cdklocal script is really just a tiny wrapper over the cdk command line - so yes, it should also work with CDK projects using Python. Can you perhaps share a few details about your use case, or a small sample, so we can take a closer look and verify that it deploys properly? Thanks!

To answer the original question (again): Yes it should work with python :+1:  There's now also a GitHub action that verifies this


PipelineGWAS.py

Hi @MikeDMorgan
Should I move PipelineGWAS.py from the scripts repository:
https://github.com/CGATOxford/cgat/blob/master/CGAT/PipelineGWAS.py
to the pipelines repository?
https://github.com/CGATOxford/CGATPipelines/tree/master/CGATPipelines
Best regards,
Sebastian

Hi Sebastian,
This module file started life as the pipeline module library, but it quickly evolved into a library for more generic analyses/handling large-scale genetic data.  It should be renamed to just GWAS.py, but I never got around to it.

Solved in https://github.com/CGATOxford/cgat/pull/354


[cloudsql] Error 403: The client is not authorized to make this request., notAuthorized with Project > Editor role

I've attempting to perform a sample WordPress deployment using Google Cloud SQL by following [1].
The original documentation I've followed is [2]. The doc states that even if I don't possess Cloud SQL > Cloud SQL Client role, alternatively I could use the Editor role to perform this deployment [3]. I assume the Editor role when checked in IAM.
Yet, I am experiencing the following error which has already been pointed out previously in [4].
Any help or suggestions are appreciated.
2018/05/12 14:45:34 couldn't connect to "<connectionName>": ensure that the account has access to "<connectionName>" (and make sure there's no typo in that name). Error during createEphemeral for <connectionName>: googleapi: Error 403: The client is not authorized to make this request., notAuthorized

[1]: Using Google Cloud SQL from a WordPress Deployment

[2]: Connecting from Kubernetes Engine
[3]: Create a service account
[4]: [cloudsql] Error 403: The client is not authorized to make this request., notAuthorized

@chirangaalwis it might be good to paste your Kubernetes YAML manifest files. I am able to follow the tutorial at [2] and succeed just fine. Also you should not be needing "Editor" role (I filed a bug internally to remove this statement).

@ahmetb thanks for the quick response.
The truth is I have simply deployed the Kubernetes manifest file provided at [1].
It seems I don't have permissions to set the Cloud SQL > Cloud SQL Client role
.
Yet as I have mentioned earlier, I assume an Editor role and based on the documentation [2] I expected to use this role alternatively, to perform the task. But as you have suggested since, the Editor role has nothing to do with it, I assume we must assume Cloud SQL > Cloud SQL Client role to perform the task, successfully.
Please correct me if I am wrong.
[1]: Using Google Cloud SQL from a WordPress Deployment
[2]: Connecting from Kubernetes Engine

@robsonpeixoto solved my problem!! Perhaps this should be added to the docs?

There is a better solution that doesn't require a new service account creation.

Here's what worked for me -- I didn't need to create a service account:
gcloud auth application-default login
For some reason it changes how the login is handled.

Source from @sventech https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/issues/10#issuecomment-380945047


http2: server sent GOAWAY and closed the connection; LastStreamID=1999, ErrCode=NO_ERROR, debug=""

<EMAIL_ADDRESS>verifying module<EMAIL_ADDRESS>reading https://goproxy.io/sumdb/sum.golang.org/tile/8/0/x003/099: http2: server sent GOAWAY and closed the connection; LastStreamID=1999, ErrCode=NO_ERROR, debug=""
I got the error when I run go mod download.

same issue

same issue


Requiring from /modules instead of /dist for two dependencies

We use a Webpack DLL plugin to build dependencies. It fails in two places, because of the spread operator:
route-node
path-parser
It seems that, instead of being imported from /dist, RouteNode and Path are imported from /modules. I cannot seem to find where this happens.
Fixed it locally by including some babel-loader plugins for spread operators.
Ps. really digging route5 so far! Great work. react-router v4 is a mess, and v3 is misusing session storage to the point of exceptions. Very nice alternative so far 😄

Hey @aksel, I think the issue has to do with jsnext:main pointing to the modules directory rather than a compiled version with ES2015 import and export statements. Will fix later today.
Thanks for your kind words 👍

It has been fixed


[Bug]: Editing Job when there are similar named configs can cause issue

Version of the software
0.1.21
Operating system
Microsoft Windows NT 6.2.9200.0 | Server 2012 DC
Browser
Chrome 91 / Opera 77.0.4054.203
What happened?
Not sure whats triggering this but when you have multiple configs with similar names i.e. Site, Site API, etc and your job is set to Site API it will change the config when you goto edit the job to make adjustments to wordlist, proxies, etc.
This has happened a few times to me where the config has been switched to an older config without me changing it.
I also deleted the old config to try and prevent this but the last time I went to change the wordlist it straight up removed the config from the job.
Its not a game breaking bug but more of a nuisance but can cause issue if the user is not paying attention requiring rerunning jobs.
Relevant LoliCode if needed
No response

Is this still happening? Are you able to find a way to reliably reproduce the issue?

Closing stale issue


v1 is not compilable in go 1.14

Running go get gopkg.in/src-d/go-queue.v1 with go 1.14 results in this error message:
# gopkg.in/src-d/go-queue.v1
/Users/mhek/go/pkg/mod/gopkg.in/src-d/go-queue.v1@v1.0.6/job.go:50:9: assignment mismatch: 2 variables but uuid.NewV4 returns 1 values

I created a pull-request for this instead, see #21


'grid-template-columns' is not supported by Internet Explorer. Add '-ms-grid-columns' to support Internet Explorer 10+.

Environment (please complete the following information):

OS (e.g., Windows 10): Windows 10
Extension version (e.g., 1.2.3): v1.4.1

Describe the bug:
When using a grid layout with grid-template-columns in a CSS file, the extension suggests to use -ms-grid-columns. When added, the error does not disappear.

Repro steps:
Write CSS
  display: -ms-grid;
  display: grid;
  -ms-grid-columns: 1fr 1fr 1fr;
  grid-template-columns: 1fr 1fr 1fr;
}

Expected behavior:
Do not show an error anymore

Additional context:

Good catch, this seems to be a webhint issue.

Not sure of the status of work to fix. Another has indicated that the extension is almost unusable as corrected "errors" regarding CSS generate another error actually regarding the correction (errors that contradict each other in how code is used).
I would suggest that the extension add a setting/option in VS Code also to suppress all errors and warning related to Internet Explorer-compatible CSS styling, since the use of Internet Explorer except perhaps for very strictly controlled intranets is now a security issue.

Hello there,
we have a new issues preset being rolled out soon that should be in the next version of the extension that will only report issues in the two latest versions of browsers and help with more detail filtering what you want to see.
For now if the experience is too annoying to you, you can disable the automatic check in the setttings:

@antross  this might be interesting for the bug sprint, too.

@mavigozler FYI if you also want to just turn off feedback for Internet Explorer, you can update your target browsers either in your package.json or .hintrc file.
E.g. this package.json will do the trick
{
  "browserslist": "defaults, not IE 11"
}

@codepo8 I dug into this a bit more on the webhint side and the issue for the persistent error when pairing grid-template-columns with -ms-grid-columns is that webhint is able to find -ms-grid-columns as an "alternate name" in the MDN browser-compat-data for grid-template-columns (to make the suggestion) but no reverse lookup currently exists (to resolve the error).
Unfortunately, this isn't likely to be a trivial fix given how the lookup routine in webhint currently works, but the fix will need to be somewhere in the walk routine for de-duping vendor-prefixed CSS properties: https://github.com/webhintio/hint/blob/0717f6afc9687d22a993436d958c7c5b86e8b4c7/packages/hint-compat-api/src/css.ts#L187

Well, fixing might be hard, but allowing a wildcard filter of things not to report could be an option?

Yes, the .hintrc can be configured to ignore reports for specific CSS properties (and we have a set of defaults we can add to). But that would fully eliminate the report in all cases. Webhint doesn't currently have a mechanism to filter reports by message.

So to help this user and close the bug, giving a proper hintrc configuration is the best move right now.

I assume they picked up the suggested .hintrc to exclude IE earlier in the thread. We'll be making this better for all users shortly by excluding IE by default in webhint: https://github.com/webhintio/hint/pull/5136
But we I think we should still track a (albeit non-trivial) fix to webhint's handling of "alternate names" as this isn't the only case where such a setup is used in the MDN data. Whether that is this issue or a separate one I'll leave up to you.


Disconnected when app is in background

As soon as app goes in background and gets back to foreground it gets disconnected immediately.
Demo[13494:3342831] [connection] nw_read_request_report [C1] Receive failed with error "Software caused connection abort"
Demo[13494:3342828] Info: Remote: disconnect
Demo[13494:3342835] Error: Remote: Connection Error: receive data error - The operation couldn’t be completed.

One note. It's not application, it's Demo example.

One note. It's not application, it's Demo example.

do you have solution for this issue ?


conformance: initial commit for references test

Based off of 01_pull_test.go
Fixes #370
Signed-off-by: Ramkumar Chinchani<EMAIL_ADDRESS>

      you have skipped this test; if this is an error, check your environment variable settings:
        OCI_TEST_CONTENT_DISCOVERY=0
        OCI_TEST_CONTENT_MANAGEMENT=1
        OCI_REFERRERS=1
        OCI_TEST_PULL=0
        OCI_TEST_PUSH=0

      /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/setup.go:408
------------------------------
•••••••••••••••••••••••HTML report was created: /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/report.html
JUnit report was created: /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/junit.xml

Ran 23 of 78 Specs in 0.085 seconds
SUCCESS! -- 23 Passed | 0 Failed | 0 Pending | 55 Skipped

can you rebase?

@jdolitsky @sudo-bmitch @sajayantony
Some eyes on this pls.
FYI, top of zot/main passes.

Couple minor updates. Does Zot still pass after the latest changes?

Yes.
      /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/setup.go:491
------------------------------
••••••••••••••••••••••••••••••••••HTML report was created: /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/report.html
JUnit report was created: /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/junit.xml

Ran 81 of 86 Specs in 0.152 seconds
SUCCESS! -- 81 Passed | 0 Failed | 0 Pending | 5 Skipped

bin/zot-linux-amd64 serve examples/config-conformance.json
^ to test
Made the warning code/output a little "nicer"

As a data point, top of zot/main passes
••••••••••••••••••••••••••••••••••HTML report was created: /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/report.html
JUnit report was created: /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/junit.xml
Ran 81 of 86 Specs in 0.255 seconds
SUCCESS! -- 81 Passed | 0 Failed | 0 Pending | 5 Skipped

Instrumented zot warns like so,
  /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/setup.go:490

••••••••••••••••••••••••••••
WARNING: filtering by artifact-type is not implemented                                                                                /local/rchincha/go/src/github.com/opencontainers/distribution-spec/conformance/05_referrers.go:240

https://github.com/opencontainers/image-spec/pull/1077
^ tests for this in a separate PR after it lands


False Positive: NoOpOverride

The following code gives a false positive:
  abstract class Printer {
    def print(message: String): Unit = println(message)
  }

  class FriendlyPrinter extends Printer {
    // NoOpOverride: below code gives a false positive
    override def print(message: String): Unit =
      super.print(s"Hello, $message!")
  }

This inspector only compare method name and the number of parameters.
This format print super.print(s"Hello, $message!") in Scala AST is regard as ONE parameter, equal to parent class print.
I write a new inspector to suit this case, and add your false positive code in test.
See [here].(https://github.com/Azard/Lickitung/commit/4c7b669b0910f52a85bc85b4e641cde28964785d)
But it still false positive when
override def print(message: String): Unit =
      super.print("abc")

In order to detect such pattern, must compare to parent class's AST, it's hard to realize.
Write static analyse tool to find Scala bug pattern is my homework, thank you for your inspiration.


Fast inserts with copy data

💡 Idea: Make a lightweight prepare statement as a lib that we can use copy_data directly from PG.
Upvote if you think it would be useful.

@santiagodoldan would love to hear your thoughts.

I just tried bulk_insert gem and it's just do the work 🎉


build: test iojs v1.2.0 on travis-ci

Update pacakge.json to match, please.

You mean "engines" field? I'm trying to understand what's current convention to indicate versions for both node and iojs. Heroku, for example, suggests using { "engines": { "iojs": "1.0.x" } }. Also all 1.0.x and 1.1.x versions wok just fine. Do we want to test them on travis? If not, should we indicate that they are not supported? ( we don't test against all node patch version anyway)

Also all 1.0.x and 1.1.x versions wok just fine. Do we want to test them on travis?

Yes, if we want to support them.

we don't test against all node patch version anyway

correct, but we do test against all minor node.js versions we support and 1.0 and 1.1 and 1.2 are different minor versions (I'm not suggesting testing against all patch versions, though sometimes we probably should, but eh).

You mean "engines" field? I'm trying to understand what's current convention to indicate versions for both node and iojs. Heroku, for example, suggests using { "engines": { "iojs": "1.0.x" } }.

Yes, something. Right now, the engines.node will make npm display a warning to people if they install it on the wrong Node.js (or even just refuse to install if they set that option in their npm). I'm not sure what io.js/npm does.

It's also important to note that I've seen written over and over again on io.js's site that they pledge that io.js is "backward-compatible" with Node.js, where in they say that as long as a library supports Node.js 0.12, then it should be able to automatically run on io.js. This library would fall under that promise, since we won't be using any non-Node.js 0.12 APIs (i.e. nothing io.js-only).

ok, I'll leave this open for now until I investigate behaviour of different npm versions re engines:node/iojs
Even with the promise of that io.js is "backward-compatible" it's good to have extra check that tests do actually run on iojs

it's good to have extra check that tests do actually run on iojs

I agree, but it's hard to make a promise, at least in the current state (for example, as a Windows user io.js is basically useless because of node-gyp issues, etc.). We could certainly test on io.js and add it to the matrix to just allow it to fail, so we'd know if there is something to look into, but it won't force us to look into it.


Small fix for debug builds in SharePlugin.gdip file. - Godot v4.2.2.stable

While testing the plugin in Godot v4.2.2.stable. the config File SharePlugin.gdip has the value of  binary to binary="SharePlugin.release.a" which causes link Error on Debug builds:
Undefined symbols for architecture arm64: ClassDB::bind_methodfi(unsigned int, MethodBind*, bool, char const*, Variant const**, int)
Setting the value of binary to binary="SharePlugin.a" instead, let the Engine export SharePlugin.debug.a if the build is debug or SharePlugin.release.a if Export With Debug is uncheck. Which fixes this bug.
Just letting you know to see if this fix is Godot version specific or it's an actual bug in your implementation. Thank you :)

Hi @TheOathMan, I did not know that the engine did that.  I was managing it manually.  Thanks!


Use type state pattern

I'm coming from the Go yamux so I understand how the Go library works, however, I'm wondering if it makes sense given the Rust type system to prevent server-side connections from being able to call client-only methods. Right now, the API will let me call client-only methods like open_stream even though I'm working with a server connection. It seems like Rust's type system can better express the distinction between a server and client connection. I'm not a Rust expert, so I don't know how to pull this off, but it does feel like the API could be better.

Both sides in yamux can open streams, that is an explicit goal, see "Features": https://github.com/hashicorp/yamux
The API could still be a lot better and I am currently working on that (see #142).

There will be type states to reflect the actual connection state: Active, Closing, etc.

Oh, interesting, I was not aware of that. I'm sorry, pardon my ignorance then!

Oh, interesting, I was not aware of that. I'm sorry, pardon my ignorance then!

No worries :)
Closing here as completed then!


Accept explicit created_at & updated_at values in Protostore's methods

Modified ProtoStore's methods that accept metadata from consumers explicitly so that they do not ignore CreatedAt & UpdatedAt values.
Testing done:

All unit tests pass
Added new/modified existing unit test(s) so that they checks that:

ProtoStore's InsertWithMetadata, UpdateWithmetadata, and UpsertWithMetadata use created_at/updated_at field if a non-zero one is passed
ProtoStore's Update & Upsert methods always use current timestamps for updated_at column

Codecov Report

Merging #39 (39f6200) into main (f3fb32e) will increase coverage by 0.47%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   70.85%   71.32%   +0.47%
==========================================
  Files          12       12
  Lines        1393     1416      +23
==========================================
+ Hits          987     1010      +23
  Misses        321      321
  Partials       85       85

Flag
Coverage Δ

unit-tests
71.32% <100.00%> (+0.47%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/protostore/protostore.go
68.72% <ø> (ø)

pkg/datastore/database.go
58.27% <100.00%> (+1.77%)
:arrow_up:

pkg/datastore/sql_struct.go
91.16% <100.00%> (+0.19%)
:arrow_up:


release: v0.6.0

Description
Releasing the OpenTelemetry metrics changes. The first commit is mostly some whitespace changes, license headers, and reordering of things as a consequence of how this change had to be integrated into the generator.
References
Generated from https://github.com/openfga/sdk-generator/pull/383
Review Checklist

[x] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.48%. Comparing base (1a6bffb) to head (093f938).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   83.48%   83.48%
=======================================
  Files          19       19
  Lines        1005     1005
  Branches      176      230   +54
=======================================
  Hits          839      839
  Misses         78       78
  Partials       88       88

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@rhamzeh, ah yeah I shoulda thought of that. I'll add it in this PR a it'll then be on the npm docs too

@rhamzeh Added some docs in 847c456fbe20e5800ae53eee1867bb1f579b75ed, pushing the SDK generator changes momentarily.


Create a DI in Razor Pages doc

Create a DI in Razor Pages doc

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08d2cf2e-55fb-33a4-b1d4-c97b2d531741
Version Independent ID: f9a790d8-f25b-0e1d-eb63-c8ed3ac518cf
Content: Dependency injection into controllers in ASP.NET Core
Content Source: aspnetcore/mvc/controllers/dependency-injection.md
Product: aspnet-core
GitHub Login: @ardalis
Microsoft Alias: riande

@dougbu  @danroth27  should we create a DI for RP like this DI for controllers/views?

What is a "DI"?

/cc @pranavkm @mkArtakMSFT

@Rick-Anderson that seems reasonable. I'd focus it on PageModel and not on injecting things in to the Razor Page.


Could not find com.firebase:geofire:2.0.0

Error:Could not find com.firebase:geofire:2.0.0.
Required by:
MAKOnWay:app:unspecified
Search in build.gradle files

GeoFire for Java 2.0.0 has not been released yet. Tracked in #24.

Cross-post: http://stackoverflow.com/questions/38055305/errorcould-not-find-com-firebasegeofire2-0-0


Fix terrascan

Terrascan is failing tests on MacOS nightly and Windows but not on Linux. They haven't released an update in a while, so this is likely a slight regression due to our PATH changes. Nevertheless, this is the only linter that's having a problem, and since terrascan appears to need to be git aware, we simply will add the SYSTEM path here.

Missed the mark on this. Even adding a prepare_run for terrascan init does not fix it (or using a tools install). Seems to be their issue, +1'd the bug report.


Change docs to reflect cupy_backends

#3386 decoupled the cuda wrapping code from cupy.
We have to modify docs accordingly

Related: https://github.com/cupy/cupy/issues/3597

As the discussion in #3597 (splitting cuda_backends as a separate library) is ongoing, I think it's better not to change the user-facing interface immediately.


Default display is bootstrap

Hi,
using october for first time, i discover that class col-md-6 is hardcoded in account/default.html
So i have to override if i do not use bootstrap ? Is it correct ? And then, which is the best pratcie to override it in my theme ?
thanks

Check documentation for Overriding Partials

Thanks @bhargavy


Fix typos

Should be non-semantic.
Uses https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines to find likely typos, with https://github.com/bwignall/typochecker to help automate the checking.

Thanks for spotting that, @scoder . I have pushed a fix for your find; please let me know if you would like me to squash the commits.


Icons (thumbnails) should be the same size.

The Carbon for IBM.com and Carbon icons are not on the same scale. Not sure which one is the intended size so will let @kingtraceyj and @jeanservaas chime in with specs.
current

it should be 24px:

redlines: https://ibm.box.com/s/vxi7hpszhg51bn668ocxukcrbz3uroy7

Confirmed this is a bug. Looks like we need to ensure that our custom sponsor SVGs render at 24px here.

Hey team! Please add your planning poker estimate with ZenHub @alisonjoseph @andreancardona @francinelucca @jdharvey-ibm


does not remove comments after empty string

Hi friend. I got in trouble.
'use strict';
const strip = require('strip-comments');
// its ok if different quotes
const str = strip("var s1= '';//empty quotes not the same with the next quotes\nvar s2= \"\";");
console.log(str);
// not ok
const str2 = strip("var s3= \"\";//empty quotes same with the next quotes\nvar s4= \"\";");
console.log(str2);

Output console
var s1= '';
var s2= "";
var s3= "";//empty quotes same with the next quotes
var s4= "";

Here I changed
https://github.com/jonschlinkert/strip-comments/blob/8b2680975598e705b2c11e89afd70deec2c5cafc/lib/parse.js#L8
to
QUOTED_STRING_REGEX: /^(['"`])((?:\\.|[^\1])*?)(\1)/,

Here is an example https://regex101.com/r/bIK3CU/1/
But it’s not for nothing that you wrote so in the first place, what’s the catch?
Thanks

I have same problem https://github.com/jonschlinkert/strip-comments/issues/53

I have the same issue.
Minimal reproduction code-block:
console.log("Test1:", strip(`
myVar1 = "";
//myVar2 = "anything";`));

Output:
Test1:
myVar1 = "";
//myVar2 = "anything";

As can be seen, when an empty string is encountered, comment-stripping seems to fail for the next comment.

For now I'm fixing it by adding a custom regex to replace any missing single-line comments that remain:
function StripComments_Fixed(str: string) {
	let result = strip(str);

	// fix for issue: https://github.com/jonschlinkert/strip-comments/issues/48
	result = result.replace(/^(\s*)\/\/(.*)$/gm, "");

	return result;
}


[Question] How to get Tweets over a range of dates?

Command Ran
I am running this directly in a python environment and here are my two attempts.
import twint
c = twint.Config()
c.Limit = 10000
c.Lang = 'ja'
c.Store_csv = True
c.Output = 'Overnight.csv'
c.Since = "2014-12-31"
c.Until = "2019-1-1"
twint.run.Search(c)
This just gives me a whole bunch of tweets from 2015-1-1, which is the first date that meets this condition. I also tried this with c.Timedelta = 1 and that didn't change anything.
My second attempt was just making a loop and trying to force twint to search each individual day. I tried initializing twint.Config both inside and outside the loop, but the result is the same.
After the loop runs once, the program terminates, giving me 100 tweets from 2015-1-1. I suspect that this is because there is some sort of break in the twint search itself, but I'm not positive on that.
import twint
import datetime
current_date = datetime.datetime(2014,12,31)
current_end_date = current_date + datetime.timedelta(days=1)
end_date = datetime.datetime(2019,1,1)
while (current_date != end_date):
c = twint.Config()
c.Limit = 100
c.Lang = 'ja'
c.Store_csv = True
c.Output = 'Overnight.csv'
c.Since = current_date.strftime("%Y-%m-%d")
c.Until = current_end_date.strftime("%Y-%m-%d")
twint.run.Search(c)
current_date = current_end_date
current_end_date += datetime.timedelta(days=1)
print(current_date != end_date)
Description of Issue
I am trying to get an even distribution of tweets over a timespan. For example, I want ten tweets from each day from 2017-1-1 to 2018-1-1,
Environment Details

Windows 10 in Jupyter Notebook

If you want an even distribution in a given range, get all the tweets in the range of interest, chose the lowest number of tweets per day, iterate over the tweets and for every day save in a new list the first n tweets (or the latest, or pick-up random tweets, as you may prefer)

Thanks for the reply.
The problem with this method is that there are millions of tweets per day over the timeframe that I'm looking at, since I'm not looking for a particular type of tweet.

I tested the loop (second set of code) in Eclipse IDE and it seems like it works perfectly now, so there could be some strange interaction with jupyter notebook. I'll keep investigating if there's some strange interaction between the notebook and the event loop, but for now, this particular issue is resolved.
Thanks again

Hi, I am trying to use a loop over single data range(one step is one day ) in order to keep the connection. It works for the first 3/4 days then it downloads only 20, 40 and often 0 tweets for a specific date. How can I address this? and why it does this thing ?


npm now broken: TypeError: Cannot read property 'current' of undefined

Hi guys!
Just started a new project with micro and now.
I've installed node v7.5.0 and set up a basic micro function from the micro github page.
Everything works fine on localhost.
I'm on the point to use now (as I did in several previous projects) but I receive this error when checking the version:
bartdeslagmulder:~/workspace (master) $ now -v
/home/ubuntu/workspace/node_modules/now/bin/now.js:34
  let message = `Update available! ${chalk.red(update.current)} → ${chalk.green(update.latest)} \n`
                                                     ^

TypeError: Cannot read property 'current' of undefined
    at Object.<anonymous> (/home/ubuntu/workspace/node_modules/now/bin/now.js:34:54)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.runMain (module.js:605:10)
    at run (bootstrap_node.js:418:7)
    at startup (bootstrap_node.js:139:9)
    at bootstrap_node.js:533:3

Installing<EMAIL_ADDRESS>is working fine for me.
Package.json contents:
{
  "name": "xxx",
  "version": "1.0.1",
  "description": "",
  "main": "src/index.js",
  "scripts": {
    "deploy": "npm version patch && now --alias",
    "dev": "nodemon --exec npm start",
    "start": "micro -p 8080",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "dependencies": {
    "micro": "^6.2.1",
    "now": "^4.1.0"
  },
  "devDependencies": {
    "nodemon": "^1.11.0"
  }
}

Already tried removing the node_modules folder and downgrading to Node.js v7.4.0 without success.

Should be fixed! 😊 https://github.com/zeit/now-cli/releases/tag/4.1.1


webpack: load modules from NODE_PATH too

support:
$ NODE_PATH=/my_node_modules next

# need to set NODE_PATH on both `build` and `start`
$ NODE_PATH=/my_node_modules next build
$ NODE_PATH=/my_node_modules next start

Looks good to me @nkzawa

fixed!


Associate correct compiler metadata for the containerized apps

Sometimes we associate the 'not so accurate' compiler metadata for the containerized applications, especially when no information regarding the compiler is available. Below is the output of jps showing the java applications running on the system.
vaishali@pop-os:~$ sudo jps
298407 spring-two-0.0.2-SNAPSHOT.jar
298719 Jps
246237 spring-0.0.1-SNAPSHOT.jar

Screenshots of what parca-agent shows for both applications:

For the process running on the host

For the application running in a docker container(check cgroup_name)

In the case of Java, it'll be fixed with the ongoing work as part of #1306. But this might be happening for other processes. Opening this so that I don't forget to check and fix it later.

Discussed this with @brancz . One idea is to not call the label compiler to avoid confusion for users as this can also be the case for the applications that are statically linking the runtimes of other languages.
In the case of Java, we'll go for having a separate label that says Java=yes.

I would suggest using java=true, but I think that's a formality (it's just what's widely used in the Prometheus ecosystem and we want things to feel as familiar as possible). Overall agreed. 💯

Fixed by #2580


changed query_iterator to work with C++17

In C++17 (and previous) versions it is not necessary to use std::iterator as base class when doing a new iterator.

Sorry botched up my previous pull request, haven't done anything in github before so it took some fiddling but now I know how.
cheers.

I didn't follow the changes in c++17 yet. Can you explain what's the issue of using std::iterator as base class is? Is this change okay with pre c++17?

Hi,
When I turn on C++17 in Visual Studio and compile your code I get a warning ST4015 that says that deriving using std::iterator is no longer allowed.
See e.g. https://github.com/Tencent/rapidjson/issues/1452
[https://avatars2.githubusercontent.com/u/3337419?s=400&v=4]https://github.com/Tencent/rapidjson/issues/1452
warning STL4015: The std::iterator class template (used as a base class to provide typedefs) is deprecated in C++17. · Issue #1452 · Tencent/rapidjsonhttps://github.com/Tencent/rapidjson/issues/1452
In Visual Studio 2019, Preview 2 I get: C:\SDKs\vcpkg\installed\x64-windows\include\rapidjson\document.h(110): warning C4996: 'std::iterator<std::random_access_iterator_tag,internal::MaybeAd...
github.com
So I changed the code in order to no longer use std::iterator as base class and instead just declare an iterator and exposing a few property like value_type. I hope I fixed in a proper way, but as far I could see from my testing it seems to work.
BTW I like your code very much as I was looking for something to make the sqlite3 a bit more C++. Thanks for that.
I have not update the boost version of the code since I don't have boost and don't want fiddle with that at the moment, mainly because our company does not allow us to use boost (license reasons). Maybe it is an easy change there as well.
Best regards
Anders.
https://twitter.com/JABKarlsson
https://twitter.com/JABKarlsson---
αη∂єяѕ кαяℓѕѕσηhttps://twitter.com/JABKarlsson (@JABKarlssonhttps://twitter.com/JABKarlsson)

From: Wongoo Lee<EMAIL_ADDRESS>Sent: Friday, March 8, 2019 20:08
To: iwongu/sqlite3pp
Cc: cyberspock; Author
Subject: Re: [iwongu/sqlite3pp] changed query_iterator to work with C++17 (#59)
I didn't follow the changes in c++17 yet. Can you explain what's the issue of using std::iterator as base class is? Is this change okay with pre c++17?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fiwongu%2Fsqlite3pp%2Fpull%2F59%23issuecomment-471040918&data=02|01||dcc8c0d069c54009f3ca08d6a3f9653d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636876688865509510&sdata=6A3t1spUzy4WBwFRWFyAk65ccFyhkif%2FbMo4dfiZ78Y%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAbDhl_R4lCojJe8XlETRdGa0aqE5QPGks5vUrUVgaJpZM4bl1Jw&data=02|01||dcc8c0d069c54009f3ca08d6a3f9653d|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636876688865519527&sdata=8hJxMBZfjsT29E0mq5X0A2UEqX%2BlRa64V4Jfmw0QpO0%3D&reserved=0.

so i left it as
      using value_type = rows;
      using difference_type = rows&;

If I were to change value_type to rows* some tweaking needs to be done elsewhere as well.

I think there is more to it, I will close this request. thanks.


Improve Kotlin Codegen Spring Data Interop

Spring Data tries to access a field using reflection. Make it available by @JvmField

when will there be a release including this?

I literally spent an entire day reaching this issue. Is there a version that includes this fix?


JAV-104 excluded conflicting javax ws dependency

Coverage increased (+0.008%) to 81.618% when pulling 4246adff8684d82c27542310efc257c8388eb63c on JAV-104_conflicting_javaxws into 2e3caa57f1f89ed28e0115d82efa8ff4aafb4221 on master.


[Azure AD OAuth] Single-tenant app registrations not supported

Currently, the OAuth for Azure AD that Chainlit supports is only for Azure App registrations that are setup with the multi-tenant account type. For App Registrations that are setup as Single-tenant, the OAuth process fails.

This happens because the URLs for authorisation and getting the token are different for each setup:

For multitenant apps are:

https://login.microsoftonline.com/common/oauth2/v2.0/authorize
https://login.microsoftonline.com/common/oauth2/v2.0/token

For singe tenant apps are:

https://login.microsoftonline.com/{tenantId}/oauth2/v2.0/authorize
https://login.microsoftonline.com/{tenantId}/oauth2/v2.0/token

Resources:
https://learn.microsoft.com/en-us/azure/active-directory/develop/quickstart-register-app
https://learn.microsoft.com/en-us/azure/active-directory/develop/v2-app-types
Additional info:
I have created a commit in my forked repo that via an extra env variable supports both types. you can take a look:
https://github.com/triantafillos/chainlit/commit/f31e7ce66f9de85ec14d46230c60c77fe871982a

Thanks a lot @triantafillos! Can you take a look @tpatel ?

hello @triantafillos , after setting account type as "Multitenant", I got the following error. ,I did set proxy in my env, are there any special requirements about the proxy setting in chainlit, any clue about this ?
infos = await self._loop.getaddrinfo(
  File "/usr/lib/python3.10/asyncio/base_events.py", line 863, in getaddrinfo
    return await self.run_in_executor(
  File "/usr/lib/python3.10/asyncio/futures.py", line 285, in __await__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.10/asyncio/tasks.py", line 304, in __wakeup
    future.result()
  File "/usr/lib/python3.10/asyncio/futures.py", line 201, in result
    raise self._exception.with_traceback(self._exception_tb)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/socket.py", line 955, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -5] No address associated with hostname

hello @wxp16, while testing Azure AD OAuth with a multi tenant application I faced no issues. I did nothing extra concerning proxies. You only have to setup the env variables that are described in the documentation.
Still, the current issue is about adding support also for single tenant apps. So I think, what you are describing is irrelevant to the current issue.

hello @triantafillos , after setting account type as "Multitenant", I got the following error. ,I did set proxy in my env, are there any special requirements about the proxy setting in chainlit, any clue about this ?
infos = await self._loop.getaddrinfo(
  File "/usr/lib/python3.10/asyncio/base_events.py", line 863, in getaddrinfo
    return await self.run_in_executor(
  File "/usr/lib/python3.10/asyncio/futures.py", line 285, in __await__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.10/asyncio/tasks.py", line 304, in __wakeup
    future.result()
  File "/usr/lib/python3.10/asyncio/futures.py", line 201, in result
    raise self._exception.with_traceback(self._exception_tb)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/socket.py", line 955, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -5] No address associated with hostname

Can you share a minimal reproducible code (without your secrets obviously)? Also your OS and python version?

hello @triantafillos , after setting account type as "Multitenant", I got the following error. ,I did set proxy in my env, are there any special requirements about the proxy setting in chainlit, any clue about this ?
infos = await self._loop.getaddrinfo(
  File "/usr/lib/python3.10/asyncio/base_events.py", line 863, in getaddrinfo
    return await self.run_in_executor(
  File "/usr/lib/python3.10/asyncio/futures.py", line 285, in __await__
    yield self  # This tells Task to wait for completion.
  File "/usr/lib/python3.10/asyncio/tasks.py", line 304, in __wakeup
    future.result()
  File "/usr/lib/python3.10/asyncio/futures.py", line 201, in result
    raise self._exception.with_traceback(self._exception_tb)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/socket.py", line 955, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -5] No address associated with hostname

Can you share a minimal reproducible code (without your secrets obviously)? Also your OS and python version?

yeah, in window wsl2 env with a poetry managed virtual environment, below is the auth callback method:
@cl.oauth_callback
def oauth_callback(
    provider_id: str,
    token: str,
    raw_user_data: Dict[str, str],
    default_app_user: cl.AppUser,
) -> Optional[cl.AppUser]:
    return default_app_user

If you remove the auth callback your chainlit app functions as expected I imagine?

If you remove the auth callback your chainlit app functions as expected I imagine?

yes. it works as expected.

y

yes.. don't know how to fix. BTW, for chainlit, how to install from src code, rather than pip. I found some bugs, I can test in my local env

@willydouhard maybe it would be better if @wxp16 opened another issue? The current issue is about Azure AD single tenant apps, while @wxp16 seems to have problems with the proxy conf and now we are taking the conversation towards how to run from source. BTW @wxp16 you can try the contributing guidelines

@triantafillos it should be fixed with #443 and we have updated the documentation to cover single-tenant applications. Can you confirm that it's working on your end?

Thanks a lot @clementsirieix I can confirm that it works as expected!
Two notes from my side regarding #443:

In case of single-tenant app, the tenant param in the authorize_params is redundant, as it is passed from the URL of the API call.
The os.environ.get("OAUTH_AZURE_AD_ENABLE_SINGLE_TENANT") is called multiple times, so as an optimization it could be saved as a class attribute


Use the terraform moved feature when refactoring future module versions.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description
When upgrading from 5.0.0-beta.2 to 5.0.0-beta.3 I noticed a lot of resources moved.  In the future it would be nice to use the moved feature in terrraform.
New or Affected Resource(s)
See the terraform config for some of the affected resources.
Potential Terraform Configuration

Here an example of some of the resources that I was able to move.
moved {
  from = module.oke.module.network.oci_core_subnet.workers
  to   = module.oke.module.network.oci_core_subnet.oke["workers"]
}

moved {
  from = module.oke.module.oke.oci_containerengine_node_pool.nodepools["np1"]
  to   = module.oke.module.workers[0].oci_containerengine_node_pool.workers["np1"]
}

moved {
  from = module.oke.module.oke.oci_containerengine_node_pool.nodepools["np2"]
  to   = module.oke.module.workers[0].oci_containerengine_node_pool.workers["np2"]
}

moved {
  from = module.oke.module.oke.oci_containerengine_cluster.k8s_cluster
  to   = module.oke.module.cluster[0].oci_containerengine_cluster.k8s_cluster
}

moved {
  from = module.oke.module.network.oci_core_subnet.cp
  to   = module.oke.module.network.oci_core_subnet.oke["cp"]
}

moved {
  from = module.oke.module.bastion[0].oci_core_subnet.bastion
  to   = module.oke.module.network.oci_core_subnet.oke["bastion"]
}

moved {
  from = module.oke.module.operator[0].oci_core_subnet.operator
  to   = module.oke.module.network.oci_core_subnet.oke["operator"]
}

moved {
  from = module.oke.module.network.oci_core_subnet.pub_lb[0]
  to   = module.oke.module.network.oci_core_subnet.oke["pub_lb"]
}

References

If you're testing 5.x take a look at https://github.com/oracle-terraform-modules/terraform-oci-oke/discussions/718 .
I did a full test as well and reported this exact issue, among others.

I agree - adding these moved blocks before 5.x is released will help support migration of existing clusters from 4.x like you've noted, and we do intend to document/validate this further ahead of time. There was an expectation of breaking changes initially with these beta releases, though I wouldn't expect module paths to be changing now - let's add them.

The moved blocks here have been added, and we'll be continuing to review the migration path from 4.x. We'll also be continuing to support the previous versions; no pressure to upgrade.
I'm going to close this issue for now, but please do open others if you see more opportunities to make this easier.


The bundle size is large

Is there a way we can reduce the size on disk of tsiclient?
Indicators that the size is large include:

tsiclient on npm is ~9MB
tsiclient is 30% of my app's bundle

Options we could explore are:

optimization in the webpack build to reduce size of the /dist/ dir
removing some dependencies

yeahhh tsiclient is def getting massive now, i hear ya.  makes me sad too because i hate taking dependencies on giant libraries, and now i work on one haha!
probably only getting bigger since we added a reference to the azure maps SDK as well for a new component.  we do have some plans to improve support for typings, module loading etc etc, we can take a swing at reducing the size of the library as well as part of that.
open to any ideas for low hanging fruit that you have as well, apologies!

i got @ccrowley96 taking a look.  for context, highcharts is 43MB, but probably has better module loading/tree shaking fanciness that means it doesnt all go in your bundle, we gotta think about how to do that, but i know its what the people probably want

Running webpack-bundle-analyzer on /dist/ produces these warnings:
    "configuration\nThe 'mode' option has not been set, webpack will fallback to 'production' for this value. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.\nYou can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/",
    "asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).\nThis can impact web performance.\nAssets: \n  tsiclient.css (560 KiB)\n  tsiclient.js (2.16 MiB)",
    "entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.\nEntrypoints:\n  main (2.71 MiB)\n      tsiclient.css\n      tsiclient.js\n",
    "webpack performance recommendations: \nYou can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.\nFor more info visit https://webpack.js.org/guides/code-splitting/"

I also used Bundle Phobia to compare highcharts to tsiclient, and tsiclient is actually significantly larger (~260kB, ~2.2mB)

a small PR to add bundle analyser so we have at least 1 common method of looking at the size
https://github.com/microsoft/tsiclient/pull/268

touche, shows that i have no idea what the difference between "unpacked size" and "amount that this increases the size of my bundle" is.  clearly a blind spot for me and this package right now haha!
appreciate you checking this out and keepin us honest here!  will check out the PR

@darsney I'm on a real-life crash course learning how bundle size affects load time and build time!
webpack does magic and I'm scared to look inside the black box 🤯

@xtellurian thanks for the feedback.  I'll be looking into this over the next couple of days.
I checked out the BundleAnalyzerPlugin you referenced in your PR.  Pretty cool stuff.  Here's the output.  It looks like the maps dependency is pretty heavy.  Stay tuned.

@xtellurian Checkout the rollup branch.
I set up a new build system which does the following:

Generates tsiclient.umd.js bundle for commonjs / browser script tag consumption
Generates components.js bundle targeting es modules to allow: import { LineChart } from 'tsiclient/components'
Generates tsiclient.js bundle targeting es modules to support current import syntax: import TsiClient from 'tsiclient' (imports all of tsiclient)

We're still working on testing this, but the module bundling seems to be working.  I set up a create-react-app to test the library.  The bundles work, but I didn't see any file size reduction via tree shaking.  Looking into that now.  Ideally, applications that consume this library, using webpack / rollup, would be able to tree shake dependencies and use only what was imported.
If that doesn't work, I'll look into separating everything depending on azure-maps-control into a different entry point.

@ccrowley96 looking pretty good! I haven't used rollup before, but it seems like a good solution.
2 questions:

There's a commit in there about dynamic loading atlas, but I don't see it in the PR... what's going on there? I know the atlas lib also has some weird module loading-ness

Could you publish this as a pre-release version to npm so I can test it?

The dynamic loading commit was an attempt to asynchronously load atlas only if a component depending on it was called.  It's a cool technique, but what webpack calls 'dynamic code splitting' is meant for applications not libraries.  It runs into problems if the library code is bundled again by the application consuming it.
We're not ready to publish yet, but you're welcome to test a local npm build in your app.
To build:

Check out the user/cocrowle/optimize-rollup branch
npm run build
npm run pack
Copy the file path to the tarball generated in dist/tsiclient.tar.gz
npm install [paste path here] in your test application directory
import { LineChart } from 'tsiclient/components' should now work

pack is a cool command I found recently that will create a local version of what npm publishes (perfect for testing)
Let me know if you have any questions!

We just published a beta with types and modules!!!  This should tree-shake and ensure your bundle size isn't exploded if you don't use all the components.  The package dependencies are also appropriately handled to ensure you don't double load things like the Azure Maps SDK or D3 if you already use them
Just run "npm install tsiclient@beta" to try it out.
The branch for these changes is here...
https://github.com/microsoft/tsiclient/tree/user/cocrowle/optimize-rollup
npm package is here...
https://www.npmjs.com/package/tsiclient/v/1.4.0-beta.0
Usage is hopefully how you'd expect...

Please let us know if you hit issues, this should roll out as 1.4.0 this week!

We just published a beta with types and modules! This should tree-shake and ensure your bundle size isn't exploded if you don't use all the components. The package dependencies are also appropriately handled to ensure you don't double load things like the Azure Maps SDK or D3 if you already use them
Just run npm install tsiclient@beta to try it out.
The branch for these changes is here...
https://github.com/microsoft/tsiclient/tree/user/cocrowle/optimize-rollup
#271
npm package is here...
https://www.npmjs.com/package/tsiclient/v/1.4.0-beta.0
Usage is hopefully how you'd expect...

Please let us know if you hit issues, this should roll out as 1.4.0 this week!


Fix race condition in kill test leading to hang

When you open a FIFO for reading, but there's no writer, you hang.
This is just one of those obscure UNIXisms we all know but just
forget all too often.
My last PR was guilty of introducing such a condition; I caught
it by accident while testing other stuff. In short, the signal
container was doing 'echo DONE' as its last step, and we (BATS)
were reading the FIFO to check for it; but if the container
exited before we opened the FIFO for read, the open would hang.
This is not a hang that we can catch in the test: it would hang
the entire job forever.
Solution: there's no need for the DONE. Just remove it and
the check. (For future reference, another option would be
to 'exec 5<$fifo' immediately after spawning the log reader,
and using 'read -u 5' instead of 'read <$fifo', but that's
unwieldy and hard to maintain.)
Signed-off-by: Ed Santiago<EMAIL_ADDRESS>

This approach is imperfect: if podman/runc/crun/alpine signal handling were ever to break, we still have a risk of a hang. Closing in favor of #4756 which is slightly more complex but produces much better diagnostics.


s3_to_hive: Move init of hooks to execute method

@artwr @krishnabhupatiraju
Otherwise the hooks and clients get created every time the DAGs are parsed.

It makes sense. :)


Blog bug fix

just the import and rename of trigger bucket name

Can you rebase dev? Your branch contains old commits that's already in dev


chore: fixes deprecation issues

This PR:

removes the labels from dropdowns to as that's being deprecated
fixes the icon size to use the new syntax for setting size
update to package-lock.json file 😄

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@LizBaker all set.


[release-1.7] remove all injected volumes when running remove-from-mesh/uninject

This is an automated cherry-pick of #26782

@googlebot I consent.

Is there a reason I have to consent every time I cherrypick a PR to release branches?

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio_release-1.7
4114d316ddee58296f033400a9ad564820e5129c
link
/test integ-multicluster-k8s-tests_istio_release-1.7

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-multicluster-k8s-tests_istio_release-1.7


Created 2 Different Apps Using This Framework. One replaces the other on installation.

Hi,
Thanks a ton to you for making such a wonderful framework. However, when i created 2 different apps using this, the moment i install the second app, it is replacing the first app that i had created.
I want to make 2 different apps but even though i am changing the directories, creating a new project, yet it is doing the same.
Cannot figure out how. Please help.

You've to change the build package name; directory design or name has nothing to do with uniqueness of the application.
File > Project Structure > Modules > Default config > Application ID

Keep both apps' Application ID separate/unique and both will work fine.


CLIMATE-685 - Update the examples using Evaluation Objects

most of the examples have been updated and all examples are tested except the esgf_integration_example.py
CLIMATE-686 should be addressed for running some examples

Merged build triggered. Test Failed.

Merged build started. Test Failed.

Merged build finished. Test Passed.


IGListCollectionViewLayout lacks support for UICollectionElementKindSectionFooter

IGListCollectionViewLayout does not have support for UICollectionElementKindSectionFooter
Initially I thought this might be a bug, I assumed that since the layout was using the same symbol (UICollectionElementKindSectionHeader) from UIcollectionViewFlowLayout that the other supplementary kind would be supported.
After producing a small reproducible case reproducible case it looks as though this may have been a deliberate choice. Is there a rational for leaving it out? Is this an enhancement we might see in the future? Would you accept contributions for this feature?
New issue checklist

[X ] I have reviewed the README and documentation
[X ] I have searched existing issues and this is not a duplicate

General information

IGListKit version: 3.0.0
iOS version(s): 10.0
CocoaPods/Carthage version: 1.2.1
Xcode version: 9.3.3
Devices/Simulators affected: All
Reproducible in the demo project? (Yes/No): Yes
Related issues:

Debug information
IGListAdapter 0x60800015dd20:
  Updater type: IGListAdapterUpdater
  Data source: <IGListKitFooter_Issue.ViewController: 0x7fddc6f04da0>
  Collection view delegate: (null)
  Scroll view delegate: (null)
  Is in update block: No
  View controller: <IGListKitFooter_Issue.ViewController: 0x7fddc6f04da0>
  Is prefetching enabled: Yes
  Registered cell classes:
  {(
    UICollectionViewCell
)}
  Registered supplementary view identifiers:
  {(
    "UICollectionElementKindSectionHeaderIGListKitFooter_Issue.TestHeaderFooter"
)}
  IGListAdapterUpdater instance 0x6000000cbde0:
    Moves as deletes+inserts: No
    Allows background reloading: Yes
    Has queued reload data: No
    Queued update is animated: Yes
    State: Idle
  Section map details:
    Object and section controller at section: 0:
      <IGListKitFooter_Issue.DiffableObject: 0x610000003460>
      <IGListKitFooter_Issue.TestSectionController: 0x6100000fa080>
  Collection view details:
    Class: UICollectionView, instance: 0x7fddc8013000
    Data source: <IGListAdapter: 0x60800015dd20>
    Delegate: <IGListAdapter: 0x60800015dd20>
    Layout: <IGListCollectionViewLayout: 0x7fddc6f06250>
    Frame: {{0, 0}, {375, 667}}, bounds: {{0, 0}, {375, 667}}
    Number of sections: 1
      1 items in section 0
    Visible cell details:
      Visible cell at section 0, item 0:
      <UICollectionViewCell: 0x7fddcaa05040; frame = (0 60; 320 20); layer = <CALayer: 0x60000002f9c0>>

@tapi you're absolutely correct, we didn't support footers intentionally mostly b/c we wanted to get this layout out-the-door quickly, and we don't use footers at Instagram.
I'm very open to community help in adding support! It's doubtful we will prioritize this anytime soon internally since there isn't a need for it (yet).

@rnystrom Hi! There're progress for this enhancement? In my project I use IGListCollectionViewLayout and need footers :D
I can do it and make PR, if you are doesn't have a time for that feature

@vasilenkoigor we’d very much accept a PR with footer support! It’s not on my roadmap at the moment.
Sent with GitHawk

@rnystrom Thanks for response! Well, I'll try to do it today or before the end of this week.

@tapi welcome to test enhancement 🕺


Brackets doesn't show the text if the text is mixed utf8 and utf16

Prerequisites

[x ] Can you reproduce the problem with Debug -> Reload Without Extensions?
[ x] Did you perform a cursory search to see if your bug or enhancement is already reported?
[ x] Did you read the Troubleshooting guide?

Steps to Reproduce
I'm a software developer. My app writes session logs. Those can contain a diagnosis for a database. I never noticed that I had mixed utf8 and utf16 data because I was always using TextEdit for macOS which can show the text fine. Now on macOS BS such a text made TextEdit crash. Brackets with the same text file doesn't crash. But it doesn't show any text beyond the BOM for the utf16 text.
Expected behavior: Show all text.
Actual behavior: Only beginning of text in utf8 shown.
Versions
macOS BS beta 2
Brackets: Release 1.13 Build 1.13.0-17696 (release 49d29a8bc)
Session_Log_2020-07-17_18-15-48_0.txt

Brackets does not currently support UTF-16 encoding.


Add a --no-open flag

This flag will not run opn(url)

Was this added? I created a script called "dash" that executes webdash --port 8089 --no-open
But when I run "npm run dash" it always opens the window :/
Also, it is not using the webdash.json configuration.
Any idea what I may be doing wrong?

Hey @felipenmoura
This hasn't been published yet as a stable release but you can already grab it with npm install webdash@next
Let me know if it works for you!

Hey @felipenmoura
This is not in stable v1.5.0


added test for reset in bottleneck env

Pull Request Test Coverage Report for Build 2026

25 of 25 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.4%) to 85.089%

Files with Coverage Reduction
New Missed Lines
%

flow/envs/bay_bridge/base.py
1
64.96%

Totals

Change from base Build 2008:
0.4%

Covered Lines:
6808

Relevant Lines:
8001

💛  - Coveralls


Font sizes passed to Zui constructor prevent unicode glyphs rendering for text at those sizes

As originally discussed here:
http://forum.kode.tech/topic/122/how-to-draw-unicode-characters
I've encountered an issue whereby it seems that the font sizes passed into the Zui constructor somehow prevent those particular font sizes from rendering unicode glyphs via g2.drawString calls.
I've put together a small example program here:
https://github.com/thoughton/kha-InputThing
In particular, see this code on line 20 of Project.hx in that example:
// Issue:
//  The font sizes passed to Zui here cause the unicode glyphs to fail to render when g.drawString is called for text of either of these sizes.
//  Changing these sizes changes the size of unicode glyphs that fail to draw.
//  Commenting out or removing this Zui instatiation will re-enable unicode glyph rendering at all font sizes.
m_zui = new Zui(Assets.fonts.NDS12, 24, 12, 0, 1.0, 1.0);

Here's an image of the output using the above snippet of code:

Fixed in https://github.com/armory3d/zui/commit/b310dab635bde1ebc8cb684d7ee5db04d1f1106b. The issue was zui touching the font file to retrieve its height before the glyphs were added.


future.playground

Is your feature request related to a problem?
We are iterating on the UX experience and want to show updates for future releases (e.g. 3.0). We'd like to have future.playground.opensearch.org setup to take mainline changes.
Domain Name: future.playground.opensearch.org
This should be available to the public so they can get sneak peaks.

future.playground already online


Kani throws a python exception if there is an error in the program

I tried this code:

fn main() {
    assert!(x);
}

using the following command line invocation:
kani triv.rs

with Kani version: 6dc03c2eb53
I expected to see this happen:
error[E0425]: cannot find value `x` in this scope
 --> triv.rs:2:13
  |
2 |     assert!(x);
  |             ^ not found in this scope

Instead, this happened:
$ kani triv.rs
Traceback (most recent call last):
  File "/home/ubuntu/git/kani/scripts/kani.py", line 197, in run_cmd
    returncode = cbmc_json_parser.transform_cbmc_output(stdout, output_style)
  File "/home/ubuntu/git/kani/scripts/cbmc_json_parser.py", line 121, in transform_cbmc_output
    raise Exception("CBMC Crashed - Unable to present Result")
Exception: CBMC Crashed - Unable to present Result

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/git/kani/scripts/kani", line 201, in <module>
    sys.exit(main())
  File "/home/ubuntu/git/kani/scripts/kani", line 59, in main
    if EXIT_CODE_SUCCESS != kani.compile_single_rust_file(args.input, base, symbol_table_json_filename, args):
  File "/home/ubuntu/git/kani/scripts/kani.py", line 261, in compile_single_rust_file
    return run_cmd(
  File "/home/ubuntu/git/kani/scripts/kani.py", line 199, in run_cmd
    raise Exception("JSON Parsing Error")
Exception: JSON Parsing Error

The CBMC json parser script should not be invoked if there was an error in compilation.

Kani also doesn't print the compile error even if the old format is specified:
$ kani --output-format old triv.rs
Traceback (most recent call last):
  File "/home/ubuntu/git/kani/scripts/kani.py", line 197, in run_cmd
    returncode = cbmc_json_parser.transform_cbmc_output(stdout, output_style)
  File "/home/ubuntu/git/kani/scripts/cbmc_json_parser.py", line 121, in transform_cbmc_output
    raise Exception("CBMC Crashed - Unable to present Result")
Exception: CBMC Crashed - Unable to present Result

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/git/kani/scripts/kani", line 201, in <module>
    sys.exit(main())
  File "/home/ubuntu/git/kani/scripts/kani", line 59, in main
    if EXIT_CODE_SUCCESS != kani.compile_single_rust_file(args.input, base, symbol_table_json_filename, args):
  File "/home/ubuntu/git/kani/scripts/kani.py", line 261, in compile_single_rust_file
    return run_cmd(
  File "/home/ubuntu/git/kani/scripts/kani.py", line 199, in run_cmd
    raise Exception("JSON Parsing Error")
Exception: JSON Parsing Error


[DatePicker] The text of month is overflow in English

ElementUI version
1.1.6
OS/Browers version
all
Vue version
2.0

Sep. may better

Same problem in portuguese (Brazil).

The word "Ano" make no sense here. "2016 Dezembro" or, more formaly, "Dezembro de 2016" sounds better.

@stefanosandes Ano will be removed in the next release.


chore: improve CSP add base uri restriction

SUMMARY
Improves our current default CSP policy by adding base-uri to self. base-uri directive restricts the URLs which can be used in a document's  element.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@rusackas do we have any front-end logging enabled by default? This might affect any telemetry we might have recently added

@rusackas do we have any front-end logging enabled by default? This might affect any telemetry we might have recently added

I think we'll be OK with the telemetry. The PR is still open until I sort out the tests, but the only change to the CSP change there just pokes a couple holes in the img-src setting.


[Trademarks] MicroProfile Brand HandBook

https://github.com/eclipse/microprofile-marketing/issues/404
Drive

@rstjames,
the word document contains the example from the Jakarta EE handbook.
The MPWG doesn't have to be a replica to that document.
We have completed and exported most of the MP work into the website already, lets use the document for a nice follow-up.
Using google slides is ideal but any other format is also welcomed. Just keep everything in the Trademark drive that will provide public edit to anyone who wants to help.
Next week fun work :) Let's do this!

With @rstjames, we are going to start the work using the same format used as with Lars' MP White Paper. Doing so will welcomed feedback early and often while making it easier for Ryan to make great designs. :) Thanks Ryan for the thoughtful feedback and reminder to drop google slides.

@rstjames,
https://indd.adobe.com/view/c3d13bf2-e849-41ea-8c4e-bf47775826b7  bringing the crude draft on the book to this ticket.

Here is the first draft of the MP branding manual. Please go to this link and leave your feedback.
https://assets.adobe.com/id/urn:aaid:sc:US:52d9e7d5-c15b-4470-9837-923f42038dca?view=published

Hi everyone. Here is the latest draft. Updated a couple of comments from people. Did not see many. https://documentcloud.adobe.com/link/review?uri=urn:aaid:scds:US:36dbb40b-eb90-49a7-80c6-1ca8074a0dc3

@rstjames,
The draft is a good start. I notice that it has not brought in components found in the Jakarta EE branding handbook.
Can you please go into that document and notice what is missing from the draft.
I have submitted a few comments but I have stopped until you have time to review the reference example added on the task.

Version 2 is ready to review:
https://documentcloud.adobe.com/link/review?uri=urn:aaid:scds:US:fa67622d-ca1f-48f2-bd13-5e5ac59efb94

@rstjames fantastic improvements in version 2, thank you!
You added brightness and more detail to the handbook.
I added further comments. I will create a word document where writing the history of the Mark is possible, that part is missing in the introduction of the book. Or if you want to own it, please go at it.  Happy to review your writing.

latest updates for review:
https://documentcloud.adobe.com/link/review?uri=urn:aaid:scds:US:dc9ffa1d-b03a-446f-9e1f-a24558b82057

@aeiras I do not have time to write up the "history" of the logo. Let's push it out and we can add it later. I honestly couldn't tell you when I made the logo...  only that the community voted for it and there were a couple of other submissions.

Ok, I will look into the community threads bc we used open brainstorming back when. 🥰
been almost 😅 5 yrs so totally ok to not remember stuff. Like you said, we can add it later if not found during this work period.

I will review the latest version today.

MicroProfile logo history:
In 201X the community came together and submitted a wide range of logo options that they felt could represent MicroProfile. When the submission deadline ended the community voted for which logo would represent MicroProfile.
The winning logo was created by Ryan St. James (Tomitribe)
@aeiras also what legal line do we need? (copywriter)

The formal (legal) transfer from TT to EF on the MP logo took place on Sept 2017 @rstjames.
Community thread: https://groups.google.com/g/microprofile/c/WtI2G1IWFC0/m/4370bcI_AgAJ
The logo has been in use formally since then in all MP content, swag, website, conference sessions, etc.
Logo submissions and selection took place in May & June 2017 via the community forum, many threads but will list 1 for reference
This memory lane reminds me of the level of care and many of those conversations... it has been so long. :)
-- your wording is great. Let's add the exact month of usage alongside the dates provided in the tracing and done.
So much fun!

Latest version:
https://documentcloud.adobe.com/link/review?uri=urn:aaid:scds:US:c8481386-828c-4fd8-8a13-119355efd724

Thank you, Ryan!
Please expect my review on version 4 early next week.
For history work and tracing, please drop the 3 versions in the folder
Abrazos,

@rstjames,
pretty an excellent version 4. I submitted what I believe are the final adjustments for v5.
V5 will await the Compatible logo (1 slide) to be included as a mark, and then we can call the document final.
Thank you for being very detailed in adding previews feedback in each version. It shows care!
Thank you for adding the 4 versions to the drive: https://drive.google.com/drive/u/0/folders/1zXwNllUjw3ftjsNdUVE7shmLe9UOuErc

versions added to the drive and updated link
https://documentcloud.adobe.com/link/review?uri=urn:aaid:scds:US:93178459-2bbd-44cd-bf30-eee3cf808715

Ryan,
I have no further comments on the document 💯
Thank you for adding version 5 to the drive.
I cannot save nor add version 1 through 4 to the drive. Can you please also add those versions?
Looking forward to the Compatible logo usage examples (from submitted logos) update you will show & tell on Monday.
Ideally, you can use the tickets in advance to help with show and tell. Do pull me in via respective tickets if there is anything blocking you on that.

Completed. It will be imported into the Website.
It has been integrated into the MP Trademark Guidelines.
@rstjames please see ticket 612. Thanks!

Please open a new Issue to request the Eclipse Foundation Marketing Team review and approve the Guidelines.
This will need to be updated to the Eclipse Foundation artwork page in compliance with the Eclipse Foundation Trademark Policy upon the Eclipse Marketing Team's approval.
Regards,
Sharon
cc @paulbuck


Uncaught TypeError: Cannot read property 'point' of undefined     at HTMLDivElement.g (app.js:50865)

Hello, Guys!
I just started to develop my own project using cornerstone libraries on top of Laravel 5.6 + Vue.
The image element init, but when I try to apply any filter from cornerstoneTools I get this errorUncaught TypeError: Cannot read property 'point' of undefined     at HTMLDivElement.g (app.js:50865)
Here is my source code:

Disable
Enable
Activate
Deactivate
Default Strategy
Osirix Strategy

did you fixed it?

Do you have a repository or codesandbox you can share that produces this error? Also, your code formatting is a bit off. Can you edit your question to make it easier to read?

@dannyrb Could you check my repo?
https://github.com/ofleaf/webpacs-proto

This component? I'll take a peak on Monday:

https://github.com/ofleaf/webpacs-proto/blob/master/src/components/worklist/WorkList.vue

We're using Cornerstone + Vue in production, so it shouldn't be too hard to see what we're doing differently.

@dannyrb Yes, the WorkList.vue component. Could you tell me which part is causing the problem?

It's a little bit easier to see when you use the unminified version of cornerstone-tools for development. You can do that by changing your import:
minified (default):
import * as cornerstoneTools from 'cornerstone-tools';
unminified:
import * as cornerstoneTools from 'cornerstone-tools/dist/cornerstoneTools.js';

The error I'm seeing shows that you didn't setup cornerstoneMath as an external dependency. It's likely used by one of the tools for help calculating something.

@dannyrb Thanks for reply. I fixed it.
cornerstoneTools.external.cornerstoneMath = cornerstoneMath


Can't use corerun and DOTNET_ROOT on Linux.

Description
I'm trying to run tests with my locally built runtime build on WSL (although this appears to be a general Linux issue) and vstest always fails on Linux.  Windows & macOS are fine.
Looking at the diagnostic log, I believe the issue is in https://github.com/microsoft/vstest/blob/2d656fe2133f89248825419fb8ffac5505486906/src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetHostHelper.cs#L446
There is no if statement to handle linux.  This leads to IsValidArchitectureMuxer returning false, which then leads to https://github.com/microsoft/vstest/blob/2d656fe2133f89248825419fb8ffac5505486906/src/Microsoft.TestPlatform.CoreUtilities/Helpers/DotnetHostHelper.cs#L203, which then leads to https://github.com/microsoft/vstest/blob/992a7c4ec7f25308d0fed594895699bf89787545/src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs#L445 which is the error message I'm seeing.
At least, that is my theory based on this section of the diagnostic log.  I could be wrong, I didn't attach and debug what is actually happening.
TpTrace Verbose: 0 : 27646, 5, 2023/03/24, 09:51:30.158,<PHONE_NUMBER>99990, vstest.console.dll, DotnetTestHostmanager: Searching muxer for the architecture 'X64', OS 'Unix' framework '.NETCoreApp,Version=v7.0' SDK platform architecture 'X64'
TpTrace Verbose: 0 : 27646, 5, 2023/03/24, 09:51:30.160,<PHONE_NUMBER>27832, vstest.console.dll, DotnetHostHelper.TryGetDotnetPathByArchitecture: Target architecture is the same as the current process architecture 'X64', but the current process is not a muxer: '/home/mike/dev/unity-runtime-1/artifacts/bin/testhost/net7.0-Linux-Release-x64/shared/Microsoft.NETCore.App/7.0.0/corerun'
TpTrace Verbose: 0 : 27646, 5, 2023/03/24, 09:51:30.160,<PHONE_NUMBER>63278, vstest.console.dll, DotnetHostHelper.TryGetDotnetPathByArchitecture: Searching for muxer named 'dotnet'
TpTrace Verbose: 0 : 27646, 5, 2023/03/24, 09:51:30.160,<PHONE_NUMBER>68075, vstest.console.dll, DotnetHostHelper.IsValidArchitectureMuxer: Incompatible architecture muxer, target architecture 'X64', actual ''
TpTrace Verbose: 0 : 27646, 5, 2023/03/24, 09:51:30.160,<PHONE_NUMBER>09512, vstest.console.dll, DotnetHostHelper: Invalid muxer resolved using env var key 'DOTNET_ROOT_X64' in '/home/mike/dev/unity-runtime-1/artifacts/bin/testhost/net7.0-Linux-Release-x64/'
TpTrace Error: 0 : 27646, 5, 2023/03/24, 09:51:30.160,<PHONE_NUMBER>12122, vstest.console.dll, Could not find 'dotnet' host for the 'X64' architecture.

Steps to reproduce
I have the following env vars set
CORE_LIBRARIES=/home/mike/dev/unity-runtime-1/artifacts/bin/testhost/net7.0-Linux-Release-x64/shared/Microsoft.NETCore.App/7.0.
DOTNET_ROOT_X64=/home/mike/dev/unity-runtime-1/artifacts/bin/testhost/net7.0-Linux-Release-x64/
DOTNET_ROOT=/home/mike/dev/unity-runtime-1/artifacts/bin/testhost/net7.0-Linux-Release-x64/

Then I run
artifacts/bin/testhost/net7.0-Linux-Release-x64/shared/Microsoft.NETCore.App/7.0.0/corerun .dotnet/sdk/7.0.100-preview.5.22307.18/vstest.console.dll /home/mike/dev/unity-runtime-1/unity/UnityEmbedHost.Tests/bin/Release/net7.0/UnityEmbedHost.Tests.dll

Expected behavior
My tests should run.  This works on Windows and macOS.
Actual behavior
Microsoft (R) Test Execution Command Line Tool Version 17.3.0-preview-20220523-03 (x64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
Logging Vstest Diagnostics in file: /home/mike/dev/unity-runtime-1/vstestdiag.txt
A total of 1 test files matched the specified pattern.
Could not find 'dotnet' host for the 'X64' architecture.

You can resolve the problem by installing the 'X64' .NET.

The specified framework can be found at:
  - https://aka.ms/dotnet-download

Test Run Aborted.

Diagnostic logs
vstestdiag.txt
Environment
This happens on Linux.  I'm using WSL, but I saw the same issue on our linux CI machine.

@MarcoRossignoli You have most experience with this part of the code, does it seem to be something missing in our logic?

@mrvoorhe why are you using corerun to test?
If I recall well it's a lite muxer version inside the dotnet/runtime repo and we didn't take into consideration that usage when we developer the code you pointed out(--arch  switch).
In the specific case the code take that path because we check if the current process is dotnet.exe and the architecture is the expected one, if so we simply use "this process" as runner. In your case we find out that the process is not dotnet.exe so we believe that the code needs to "switch" to another architecture and that feature on Linux is not supported at the moment.
@vitek-karas from runtime maybe has got some more thoughts on it.

I was able to get dotnet working for our use case https://github.com/Unity-Technologies/runtime/blob/1052054a7c3e8bc53d963546dab1dfa7cfdc88f5/unity/CITools/BuildDriver/EmbeddingHost.cs#L54
Initially I tried to use dotnet from artifacts/bin/testhost/net7.0-Linux-Release-x64 but hit issues.   I stumbled on https://github.com/Unity-Technologies/runtime/blob/unity-main/docs/workflow/testing/using-corerun-and-coreroot.md so I thought I'd give corerun a try.  I had corerun working on windows and mac.  That led me to dig into vstest.  Looking at the code, it looked like it was trying to handle this scenario on mac & windows.  It seemed like there was no logic to handle linux so I thought I'd file an issue.
I later figured out how to get dotnet from artifacts/bin/testhost/net7.0-Linux-Release-x64 working.   I think something was setting DOTNET_ROOT_X64 and clearing that fixed the issue I had of vstest switching back over to the system installed dotnet.
Long story short, I don't need anything changed.  I was just filing an issue because something that worked on mac & windows did not work on linux.


Strip unneeded symbols from minsizerel binaries

I use vscode to debug via attach to process, I imagine stripping symbols from the exe may require vscode to be provided the .pdb path now. No worries on this - just thinking out loud.

Refers to: common/cmake/do-build-helpers.cmake:138 in 284d3fa. [](commit_id = 284d3fa4671f907a57d9a597b9f5d06140c7de41, deletion_comment = False)

vscode uses gdb and all I had to do for gdb is to ensure that the .dbg file was in the same directory as the binary.

In reply to: 860969043

Refers to: common/cmake/do-build-helpers.cmake:138 in 284d3fa. [](commit_id = 284d3fa4671f907a57d9a597b9f5d06140c7de41, deletion_comment = False)


Tests fail on sqlite3 wrong version for ActiveRecord

The test suite currently fails with a complaint about sqlite3 exact version not matching expectations in ActiveRecord:
# Gem::LoadError:
#   can't activate sqlite3 (~> 1.3.6), already activated sqlite3-1.4.0. Make sure all dependencies are added to Gemfile.
#   /home/travis/.rvm/gems/ruby-2.2.9/gems/bundler-1.17.3/lib/bundler/rubygems_integration.rb:408:in `block (2 levels) in replace_gem'

Explanation: This SO answer explains well

It is not supposed to be an issue, since it was an Active Record issue, and its already fixed there since Rails 5.2.3


State Management Optimizations Part 2

@ohmygirth is this covered by this PR: https://github.com/OlympusDAO/olympus-frontend/pull/381

august was a different codebase at this point kek. issue no longer relevant


Setup isn't working here

Describe the bug
I downloaded the latest installer (ViGEmBus_Setup_1.16.115.exe) and tried to run it. Absolutely nothing happens. I already tried as admin and through powershell, nothing is printed either. I found out that GloSC wasn't working because the driver wasn't installed, so I tried to install it manually.
To Reproduce

Download the setup file
Try to run it (double-click)
Nothing opens

Expected behavior
The driver to be installed.
System details (please complete the following information):

OS: Windows 10 Pro 1909 x64
Feeder software: GloSC
Driver Version: 1.16.115

Are there any flags I can pass to the installer to make it verbose and give me any clues on what is happening?

Hello!
Please try to run it from the command line with the following argument: /exenoupdates
See if that helps, cheers!

Powershell x64 as admin:
PS C:\users\bolaum\Downloads> .\ViGEmBus_Setup_1.16.115.exe /exenoupdates
PS C:\users\bolaum\Downloads>

Still nothing happens =/
There's no verbose flag?
If I build it locally, will it generate the installer binary? Will the unsigned version work the same way?

You need Advanced Installer with an Enterprise license to create the setup, so the build won't provide it for you and driver signing has no relevance to the setup not starting. You could also try this.

This is so weird, no log is generated. It is as if the executable was never run.
PS C:\users\bolaum\Downloads\tmp> .\ViGEmBus_Setup_1.16.115.exe /L*V .\install.log
PS C:\users\bolaum\Downloads\tmp> ls

    Directory: C:\users\bolaum\Downloads\tmp

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        12/3/2019  10:46 PM       14310704 ViGEmBus_Setup_1.16.115.exe

PS C:\users\bolaum\Downloads\tmp>

Same result with /exenoupdates. I'm a programmer, but Windows isn't really my thing.
About the signing, I wasn't implying it was the problem. I just wanted to know if Windows will allow an unsigned version to be installed, but it seems you generate it with an external tool.

Is there something equivalent do strace or ptrace for Windows / PS?

Do any of these work? Is there anything generated in Windows Event Log when you try to run it?

Nothing in the Event Viewer. Same results with other params.
I ran the executable with IDA and it seems to be breaking after loading SysWOW64\ntdll.dll:
WOW64 process has been detected (pid=5652)
E0000: process C:\Users\bolaum\Downloads\tmp\ViGEmBus_Setup_1.16.115.exe has started (pid=5652)
2B8000: created segment ViGEmBus_Setup_1.16.115.exe, end: 2F3000
300000: created segment debug001, end: 320000
320000: created segment debug002, end: 323000
330000: created segment debug003, end: 34B000
385000: created segment debug004, end: 388000
388000: created segment debug005, end: 390000
390000: created segment debug006, end: 394000
3A0000: created segment debug007, end: 3A3000
3B0000: created segment debug008, end: 3B2000
498000: created segment TIB[0000097C], end: 49D000
6FD000: created segment debug009, end: 6FF000
6FF000: created segment debug010, end: 700000
77520000: created segment ntdll.dll, end: 77521000
77521000: created segment ntdll.dll, end: 7763B000
7763B000: created segment ntdll.dll, end: 77641000
77641000: created segment ntdll.dll, end: 77642000
77642000: created segment ntdll.dll, end: 77644000
77644000: created segment ntdll.dll, end: 776BA000
7FFE0000: created segment debug011, end: 7FFE1000
7FFE8000: created segment debug012, end: 7FFE9000
FF740000: created segment debug013, end: FF741000
FF750000: created segment debug014, end: FF773000
7FFC250E0000: created segment ntdll.dll, end: 7FFC250E1000
7FFC250E1000: created segment ntdll.dll, end: 7FFC251F8000
7FFC251F8000: created segment ntdll.dll, end: 7FFC2523F000
7FFC2523F000: created segment ntdll.dll, end: 7FFC25245000
7FFC25245000: created segment ntdll.dll, end: 7FFC25246000
7FFC25246000: created segment ntdll.dll, end: 7FFC2524B000
7FFC2524B000: created segment ntdll.dll, end: 7FFC2525A000
7FFC2525A000: created segment ntdll.dll, end: 7FFC2525B000
7FFC2525B000: created segment ntdll.dll, end: 7FFC2525E000
7FFC2525E000: created segment ntdll.dll, end: 7FFC252D0000
7FFC250E0000: loaded C:\Windows\System32\ntdll.dll
7763E000: created segment ntdll.dll, end: 77641000
7763B000: updated segment ntdll.dll, end: 7763E000
7763F000: created segment ntdll.dll, end: 77641000
7763E000: updated segment ntdll.dll, end: 7763F000
77520000: loaded C:\Windows\SysWOW64\ntdll.dll
PDBSRC: loading symbols for 'C:\Windows\SysWOW64\ntdll.dll'...
PDB: using load address 77520000
Debugger: process has exited (exit code 0)

Is the installer x32?

Very odd. The installer is multi-arch, the setup is just a bootstrapper around the actual embedded MSIs... Since it's not my product (Advanced Installer) I could try to get support involved, IDK at this stage what to recommend honestly...

No worries! Could you make the install scripts and raw msi files available?
Since you are paying for it, you sure are entitled for some support =D maybe they've seen this elsewhere. I can provide all info you need.

We could experiment with alternative builds of the setup together "in private" on my Discord for example, usually it has worked best in the past if those issues are tracked down together, maybe also involving a remote session. There's been a couple of oddities in the past I simply could never replicate on my machines 😁

Hello. I just had this problem here. After formatting my PC  the installation was successful.
Using Windows 8.1 here.

Hello. I just had this problem here. After formatting my PC the installation was successful.
Using Windows 8.1 here.

Soooo... You nuked your Windows installation which had the problem and now with a fresh one you don't have the problem anymore? Thanks for sharing but that effectively nuked any chance to properly diagnose and fix as well 🤷♀

Sorry. I remember that I used the PS3 controler with the ScpDriver here. Maybe that was the problem.

Very unlikely, at this stage of the setup no driver shenanigans is involved at all.

Hi, got the same problem here... I managed to generate a logfile (combining the log command AND the exenoupdates), but i have no idea what anything of that means, gonna upload the log file, hope it helps.
Trying to install to use with DS4.
OS: Windows 10 Pro 1903 x64
Driver Version: 1.16.115
install.log

Hi, i have the same issue but i wasn't able to generate a log file through the command line.
Is there anything else i could do to help solve this?

grumpy Advanced Installer noises

There's not much i can do i guess?

Stay tuned...

Hehe

@bolaum @AsuraMazda @henriquel1997 I've published a pre-release addressing the issues, please test and report, thank you!

Seems to be working fine here!

@nefarius wow! Much installer, very working!
Dude, please tell me what you did. I'm professionally curious =D

@bolaum nothing too exciting I'm afraid, I removed the pre-setup update check and re-built the setup with latest Advanced Installer and there we have it 😅

Alright, I think we are good to go 😄

This is still a problem.
OS Name:                   Microsoft Windows 10 Home
OS Version:                10.0.18363 N/A Build 18363
ViGEmBus_Setup_1.16.116.exe /exenoupdates
This page in the forums is full of dead links and the repository does not seem to work.
https://forums.vigem.org/topic/39/new-vigem-installer

@HughWish the installation methods referenced on that post don't exist anymore for like a year now.


Bringing the module to 2023

Hello, I've forked the module upgraded all dependencies and implemented a few changes:

Now it is possible to have async event emitters, this is really handy when working with serverless (AWS Lambdas) and you need to await for the event to be emitted to SNS, SQS or EventBridge for example otherwise the Lambda stops the execution without sending the event;
Promises events is optional and the fallback is still the EventEmitter implementation from node.js;
I renamed the classes from event to events it feels more concise for me;
I've added TESTS :)

If this PR is approved it would be great, anyways I will be publishing another lib to npmjs with this new implementation to start using it already, soon I'll update here with the npmjs handle for the new implementation.

the new package is published as nest-events


Prevent a line of text that starts with a glyph with negative side bearing from clipping

Hi, thanks for the great crate! I am very new to embedded programming in Rust, just started working on a custom font implementation in this repo.
Some glyphs in the font may have negative offsets, to ensure visually pleasing spacing between the glyphs and a nice shape of the text. Such glyphs, like the letter "j", may shift the bounding box to the left from the initial text position:
let style = TextStyle::new(BinaryColor::On);
let metrics = style.measure_string("just testing", Point::zero(), Baseline::Top);
assert_eq!(metrics.bounding_box.top_left, Point::new(-2, 0));  // the letter "j" has a negative left side bearing
assert_eq!(metrics.next_position, Point::new(42, 0));

Unfortunately, such hanging elements are getting cropped by the TextBox bounds. On the screenshot, the leading "j" is not fully rendered:

I tried looking into the plugin system, but there is no way to change the layout or rendering functionality. I wonder what would be the best way to address this use case and if you think this should be addressed at all. Similarly to CSS, perhaps we could add a setting for overflow: hidden / visible and padding to the TextBoxStyle. I would be happy to contribute such feature.
When rendered with embedded_graphics::text::Text, this doesn't happen. But then obviously I am not getting all the nice text layout functionality provided by the embedded-text crate.

Hi, thanks for reporting this issue. Your font looks really cool and it also looks like a quite good edge case for some of the functionality here :) I haven't been working on the crate for a while. The most straight-forward fix would be to force the first character to x=0, although I'll be honest, I don't know how correct/desired that would be. I'll have to try and implement this and I guess we can then decided, although I don't know when I'll have the energy to do so.
Overflow would slightly defeat the purpose of a box in my opinion, and I suspect it would be quite costly in terms of the generated binary's size.

@bugadani thanks for the fast reply! I actually wanted the stem of "j" to align with the letters below, but I am not too hard on this requirement. That's why I thought that maybe padding could make it work (it would offset where the text starts, but keep the rendering area a bit larger for such hanging elements).
Also, no rush on this at all! I'm actually thinking myself, that maybe I could instead use the kerning table to bring j closer to other glyphs, and set the left side bearing to -1 instead of -2. In this case only one pixel of the "j" is going to be cropped and it would still look ok.
By the way, I've checked how this is done on the web (in the Safari browser). This is a textarea with the green padding. You can see how the letter "j" is bleeding into the padding area, and would be totally cropped by the textarea if the padding didn't exist.

What's funny, is that when I type a spacebar in front of "j", this artefact is left on the screen.

I'm not entirely sure that following the example of extremely complex browsers is what I want to do in a small(uh... ish)-and-dirty embedded library, although it's fun to see how Safari got things wrong there. Although admittedly I don't exactly have text rendering experience, so maybe that artifact, as well as clipping into the cursor is the correct and expected behaviour, who knows :)

So for now I changed the left side bearing of letter "j" to be -1 instead of -2, so only 1 pixel is cropped and the word space in front of the second "j" is 1 pixel wider in case of left aligned text. I think it is probably fine:

Yeah I think you're right and the complexity is not worth it. If you are up for a contribution, I can implement your idea: push the line forward to make the letters fit in the TextBox bounds, if the measurement starts with a negative offset.

If you are up for a contribution, I can implement your idea: push the line forward to make the letters fit in the TextBox bounds, if the measurement starts with a negative offset.

That would be wonderful!

Closed via #167


fix(app): include timeout time for application health verification warning message

Current coverage is 83.33%

Merging #602 into master will decrease coverage by -0.03% as of 52a93b5

@@            master    #602   diff @@
======================================
  Files           36      36
  Stmts         2417    2418     +1
  Branches       350     350
  Methods          0       0
======================================
  Hit           2015    2015
  Partial        116     116
- Missed         286     287     +1

Review entire Coverage Diff as of 52a93b5

Powered by Codecov. Updated on successful CI builds.


Add home page

This PR ballooned a bit:

Add a home page

Use Formik for the player names form
Use bumbag UI components

Add some devops stuff

Install various eslint plugins
Install lint-staged and husky
Test and lint in CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a218c08). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   78.07%
=========================================
  Files             ?       13
  Lines             ?      114
  Branches          ?       18
=========================================
  Hits              ?       89
  Misses            ?       25
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a218c08...f14f613. Read the comment docs.


Update ag-grid from 20.1 -> 20.2

Signed-off-by: shravnk<EMAIL_ADDRESS>

Need yarn.lock in this PR as well - please run yarn install and push the changes there too!
Glad no other changes appear to be required.

My bad - updated PR with lock file

I think this yarn.lock diff is bigger than it needs to be because your older version of yarn (<1.9?) is removing the integrity flag

Thanks, had to upgrade yarn