Add TypeScript types for Pino logger

This PR adds TypeScript types for Pino logger.

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #82 opened

Reason: The PR is not allowed to run in the CI yet

Start Time: 2021-06-15T15:12:56.687+0000

Duration: 3 min 4 sec

Commit: 364136cf9ed0c687b7dc4db6a10a0762ce5f40cf

Trends :test_tube:

Steps errors
Expand to view the steps failures

Load a resource file from a shared library

Took 0 min 0 sec . View more details on here
Description: approval-list/elastic/ecs-logging-nodejs.yml

Error signal

Took 0 min 0 sec . View more details on here
Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)

Log output
Expand to view the last 100 lines of log output

[2021-06-15T15:15:40.218Z] Commit message: "Add TypeScript types for Pino logger"
[2021-06-15T15:15:40.218Z] First time build. Skipping changelog.
[2021-06-15T15:15:40.218Z] Cleaning workspace
[2021-06-15T15:15:40.276Z]  > git --version # timeout=10
[2021-06-15T15:15:40.282Z]  > git --version # 'git version 2.17.1'
[2021-06-15T15:15:40.288Z] fatal: bad object bbed8ab717206e63fa6cc1cef7d35f4a13f717ab
[2021-06-15T15:15:40.219Z]  > git rev-parse --verify HEAD # timeout=10
[2021-06-15T15:15:40.231Z] Resetting working tree
[2021-06-15T15:15:40.231Z]  > git reset --hard # timeout=10
[2021-06-15T15:15:40.240Z]  > git clean -fdx # timeout=10
[2021-06-15T15:15:41.081Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2021-06-15T15:15:41.134Z] Timeout set to expire in 1 hr 0 min
[2021-06-15T15:15:41.156Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2021-06-15T15:15:41.419Z] [INFO] Number of builds to be searched 10
[2021-06-15T15:15:41.545Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2021-06-15T15:15:41.563Z] Running in /var/lib/jenkins/workspace/ejs_ecs-logging-nodejs-mbp_PR-82/src/go.elastic.co/apm/ecs-logging-nodejs
[2021-06-15T15:15:41.600Z] [INFO] gitCheckout: Checkout SCM PR-82 with default customisation from the Item.
[2021-06-15T15:15:41.639Z] [INFO] Override default checkout
[2021-06-15T15:15:41.696Z] Sleeping for 10 sec
[2021-06-15T15:15:51.766Z] The recommended git tool is: NONE
[2021-06-15T15:15:51.888Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2021-06-15T15:15:51.899Z] Wiping out workspace first.
[2021-06-15T15:15:51.909Z] Cloning the remote Git repository
[2021-06-15T15:15:51.909Z] Using shallow clone with depth 3
[2021-06-15T15:15:51.909Z] Avoid fetching tags
[2021-06-15T15:15:52.675Z] Cleaning workspace
[2021-06-15T15:15:52.696Z] Using shallow fetch with depth 3
[2021-06-15T15:15:52.696Z] Pruning obsolete local branches
[2021-06-15T15:15:51.926Z] Cloning repository git@github.com:elastic/ecs-logging-nodejs.git
[2021-06-15T15:15:51.954Z]  > git init /var/lib/jenkins/workspace/ejs_ecs-logging-nodejs-mbp_PR-82/src/go.elastic.co/apm/ecs-logging-nodejs # timeout=10
[2021-06-15T15:15:51.960Z] Fetching upstream changes from git@github.com:elastic/ecs-logging-nodejs.git
[2021-06-15T15:15:51.960Z]  > git --version # timeout=10
[2021-06-15T15:15:51.971Z]  > git --version # 'git version 2.17.1'
[2021-06-15T15:15:51.971Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-06-15T15:15:51.976Z]  > git fetch --no-tags --progress -- git@github.com:elastic/ecs-logging-nodejs.git +refs/heads/*:refs/remotes/origin/* # timeout=15
[2021-06-15T15:15:52.651Z]  > git config remote.origin.url git@github.com:elastic/ecs-logging-nodejs.git # timeout=10
[2021-06-15T15:15:52.654Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2021-06-15T15:15:52.668Z]  > git config remote.origin.url git@github.com:elastic/ecs-logging-nodejs.git # timeout=10
[2021-06-15T15:15:52.677Z]  > git rev-parse --verify HEAD # timeout=10
[2021-06-15T15:15:52.683Z] No valid HEAD. Skipping the resetting
[2021-06-15T15:15:52.683Z]  > git clean -fdx # timeout=10
[2021-06-15T15:15:52.698Z] Fetching upstream changes from git@github.com:elastic/ecs-logging-nodejs.git
[2021-06-15T15:15:52.698Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-06-15T15:15:52.703Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/ecs-logging-nodejs.git +refs/pull/82/head:refs/remotes/origin/PR-82 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2021-06-15T15:15:53.257Z] Merging remotes/origin/master commit 0c749edb289d5c54ef3b80c7275278842caf65e0 into PR head commit 364136cf9ed0c687b7dc4db6a10a0762ce5f40cf
[2021-06-15T15:15:53.320Z] Merge succeeded, producing 364136cf9ed0c687b7dc4db6a10a0762ce5f40cf
[2021-06-15T15:15:53.320Z] Checking out Revision 364136cf9ed0c687b7dc4db6a10a0762ce5f40cf (PR-82)
[2021-06-15T15:15:53.352Z] Commit message: "Add TypeScript types for Pino logger"
[2021-06-15T15:15:53.353Z] Cleaning workspace
[2021-06-15T15:15:53.402Z]  > git --version # timeout=10
[2021-06-15T15:15:53.405Z]  > git --version # 'git version 2.17.1'
[2021-06-15T15:15:53.414Z] fatal: bad object bbed8ab717206e63fa6cc1cef7d35f4a13f717ab
[2021-06-15T15:15:53.259Z]  > git config core.sparsecheckout # timeout=10
[2021-06-15T15:15:53.263Z]  > git checkout -f 364136cf9ed0c687b7dc4db6a10a0762ce5f40cf # timeout=15
[2021-06-15T15:15:53.287Z]  > git remote # timeout=10
[2021-06-15T15:15:53.291Z]  > git config --get remote.origin.url # timeout=10
[2021-06-15T15:15:53.298Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2021-06-15T15:15:53.302Z]  > git merge 0c749edb289d5c54ef3b80c7275278842caf65e0 # timeout=10
[2021-06-15T15:15:53.314Z]  > git rev-parse HEAD^{commit} # timeout=10
[2021-06-15T15:15:53.323Z]  > git config core.sparsecheckout # timeout=10
[2021-06-15T15:15:53.331Z]  > git checkout -f 364136cf9ed0c687b7dc4db6a10a0762ce5f40cf # timeout=15
[2021-06-15T15:15:53.354Z]  > git rev-parse --verify HEAD # timeout=10
[2021-06-15T15:15:53.363Z] Resetting working tree
[2021-06-15T15:15:53.363Z]  > git reset --hard # timeout=10
[2021-06-15T15:15:53.376Z]  > git clean -fdx # timeout=10
[2021-06-15T15:15:54.170Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2021-06-15T15:15:54.834Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2021-06-15T15:15:55.168Z] Running in /var/lib/jenkins/workspace/ejs_ecs-logging-nodejs-mbp_PR-82/src/go.elastic.co/apm/ecs-logging-nodejs/.git
[2021-06-15T15:15:55.254Z] Archiving artifacts
[2021-06-15T15:15:55.915Z] + git rev-parse HEAD
[2021-06-15T15:15:56.278Z] + git rev-parse HEAD
[2021-06-15T15:15:56.602Z] + git rev-parse origin/pr/82
[2021-06-15T15:15:56.660Z] [INFO] githubEnv: Found Git Build Cause: pr
[2021-06-15T15:15:56.907Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-06-15T15:15:57.856Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/ecs-logging-nodejs/pulls/82/reviews return 0 elements
[2021-06-15T15:15:57.910Z] [INFO] githubPrCheckApproved: Title: Add TypeScript types for Pino logger - User: akselinurmio - Author Association: FIRST_TIME_CONTRIBUTOR
[2021-06-15T15:15:58.225Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2021-06-15T15:15:58.225Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2021-06-15T15:15:58.299Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2021-06-15T15:15:58.322Z] Sleeping for 5 sec
[2021-06-15T15:15:59.484Z] Stage "Parallel" skipped due to earlier failure(s)
[2021-06-15T15:15:59.608Z] Stage "Test - Node.js v10" skipped due to earlier failure(s)
[2021-06-15T15:15:59.619Z] Stage "Test - Node.js v12" skipped due to earlier failure(s)
[2021-06-15T15:15:59.631Z] Stage "Test - Node.js v14" skipped due to earlier failure(s)
[2021-06-15T15:15:59.643Z] Stage "Test - Node.js v15" skipped due to earlier failure(s)
[2021-06-15T15:15:59.747Z] Failed in branch Test - Node.js v10
[2021-06-15T15:15:59.755Z] Failed in branch Test - Node.js v12
[2021-06-15T15:15:59.763Z] Failed in branch Test - Node.js v14
[2021-06-15T15:15:59.772Z] Failed in branch Test - Node.js v15
[2021-06-15T15:16:00.103Z] Running on Jenkins in /var/lib/jenkins/workspace/ejs_ecs-logging-nodejs-mbp_PR-82
[2021-06-15T15:16:00.219Z] [INFO] getVaultSecret: Getting secrets
[2021-06-15T15:16:00.270Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-06-15T15:16:01.068Z] + chmod 755 generate-build-data.sh
[2021-06-15T15:16:01.068Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-82/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-82/runs/1 ABORTED 184106
[2021-06-15T15:16:01.068Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-82/runs/1/steps/?limit=10000 -o steps-info.json
[2021-06-15T15:16:01.068Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-82/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-06-15T15:16:01.068Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-06-15T15:16:02.411Z] Retry 2/3 exited 22, retrying in 2 seconds...
[2021-06-15T15:16:04.273Z] Retry 3/3 exited 22, no more retries left.
[2021-06-15T15:16:04.273Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/ecs-logging-nodejs-mbp/PR-82/runs/1/log/ -o pipeline-log.txt

@akselinurmio This looks great!  Please help me with some TypeScript types ignorance of mine. You've added @types/pino to "dependencies". This ends up increasing the install size of a user-installed @elastic/ecs-pino-format by 1MB because @types/node is large. Can @types/* be added to devDependencies instead and still have the same utility to users? I notice that https://github.com/DefinitelyTyped/DefinitelyTyped#npm suggests npm install --save-dev ... and that, for example, the fastify project puts its @types/* deps in devDependencies: https://github.com/fastify/fastify/blob/main/package.json#L120-L125

@trentm I'm not entirely sure whether adding it to devDependencies works the same here, but I'll try to verify as soon as possible.

^ By the way, those test failures are not due to your changes, but rather due to the recent<EMAIL_ADDRESS>release. I am looking into it.

^ By the way, those test failures are not due to your changes, but rather due to the recent<EMAIL_ADDRESS>release. I am looking into it.

https://github.com/elastic/ecs-logging-nodejs/pull/83 fixes this.
@akselinurmio If you merge in changes from the master branch, tests should pass for your PR now.

@trentm Based on a quick test, in this case the @types/pino needs to be located in the "dependencies" array. This is because when the package is published to NPM and used as a dependency by another package (say A), dependencies listed in devDependencies are not installed. This means that this package's function type is left with an any type as return type (see screenshot).

(I'm still learning/playing here.)
I was reading https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html which suggests:

If your types are generated by your source code, publish the types with your source code. Both TypeScript and JavaScript projects can generate types via --declaration.
Otherwise, we recommend submitting the types to DefinitelyTyped, which will publish them to the @types organization on npm.

Looking briefly at the former (https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html provides some docs), that seems like a no-go:
[13:48:37 trentm@pink:~/el/ecs-logging-nodejs3/loggers/pino (git:master)]
% cat tsconfig.json
{
  "include": ["index.js"],
  "compilerOptions": {
    "allowJs": true,
    "declaration": true,
    "emitDeclarationOnly": true
  }
}
[13:48:40 trentm@pink:~/el/ecs-logging-nodejs3/loggers/pino (git:master)]
% tsc
node_modules/elastic-apm-node/index.d.ts:1:23 - error TS2688: Cannot find type definition file for 'node'.

1 /// <reference types="node" />
                        ~~~~

node_modules/elastic-apm-node/index.d.ts:3:49 - error TS2307: Cannot find module 'http' or its corresponding type declarations.

3 import { IncomingMessage, ServerResponse } from 'http';
                                                  ~~~~~~

Found 2 errors.

The latter recommends submitting instead to DefinitelyTyped. I know many projects do that, but unfortunately the recommendations here don't mention why this recommendation?

Is it to avoid this need for largish @types/... "dependencies"?
Is it to separate package and types authors? (The main value being that a JS package author doesn't yet need to learn about TypeScript, DTS, et al.)

I see the value of shipping the types with the package: version mismatches, changes in API can get reflected in the types in the same change.

So here is a test of mine... which I think shows that @types/pino need not be installed by npm install @elastic/ecs-pino-format users to get types working. I'm not entirely confident, however.
setup
I have a clean "q" directory for a node project. It has the latest pino and @elastic/ecs-pino-format installed:
[14:47:48 trentm@pink:~/tmp/q]
% cat package.json
{
  "name": "q",
  "version": "1.0.0",
  "main": "index.js",
  "license": "ISC",
  "dependencies": {
    "@elastic/ecs-pino-format": "^1.1.2",
    "pino": "^6.11.3"
  }
}
[14:47:56 trentm@pink:~/tmp/q]
% npm ls
<EMAIL_ADDRESS>/Users/trentm/tmp/q
├─┬<EMAIL_ADDRESS>│ └─┬<EMAIL_ADDRESS>│   └─┬<EMAIL_ADDRESS>│     ├─┬<EMAIL_ADDRESS>│     │ ├──<EMAIL_ADDRESS>│     │ ├──<EMAIL_ADDRESS>│     │ ├──<EMAIL_ADDRESS>│     │ └─┬<EMAIL_ADDRESS>│     │   └──<EMAIL_ADDRESS>│     ├──<EMAIL_ADDRESS>│     ├──<EMAIL_ADDRESS>│     └──<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  ├──<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    ├──<EMAIL_ADDRESS>    └──<EMAIL_ADDRESS>deduped

I manually copied your index.d.ts into the ecs-pino-format install:
% ls<EMAIL_ADDRESS><EMAIL_ADDRESS>
which simulates adding your PR but without @types/pino in "dependencies".
types in VS Code for .js, .mjs, and .ts files
% cat foo.js
const ecsFormat = require('@elastic/ecs-pino-format')
const pino = require('pino')
const fmt = ecsFormat()
const log = pino(fmt)
log.info('Hello world')

% cat bar.mjs
import pino from 'pino'
import ecsFormat from '@elastic/ecs-pino-format'
const fmt = ecsFormat()
const log = pino(fmt)
log.info('hi')

% cat baz.ts
import pino from 'pino'
import ecsFormat from '@elastic/ecs-pino-format'
const fmt = ecsFormat()
const log = pino(fmt)
log.info('hi')

I created these files to test types in VS Code for each of CommonJS-style JS, ESM-style JS, and TypeScript files using these two packages.
foo.js
VS Code knows the types for fmt and log:

bar.mjs
Likewise, VS Code knows the types for fmt and log:

baz.ts
VS Code knows (at least I think it does) the type for fmt, but not for log:

I'm not sure if I'm showing my ignorance with TypeScript here to know why VS Code does not resolve the type for pino.
conclusions
I'm not sure why my test shows a different result (no any) to your quick test comment above:

Hi @trentm, and sorry about the delay. And thank you for taking such a thorough look into this. I think we should go with pino's type package in the devDependencies as that seems to be working fine, based on your tests.
I have now made said changes to the PR. The CI seems not to be running tests on the PR (see screenshot below). If there's something for me to do, I'd be happy to help.

<EMAIL_ADDRESS>finally published with this.


Fix deadlock when connection fails

Wraps sqlite3.connect() in try/except
and stores the exception to raise it in check_raise_error()
Fixes #90

There seems to be a race-condition, still deadlocking sometimes. I'll check tomorrow.

@mpenkov Also this PR is worth merging if still relevant.
In my fork I patched sqlitedict with both this and #97

@mpenkov Also this PR is worth merging if still relevant.
In my fork I patched sqlitedict with both this and #97


user_base_settings: Change web_home_view default to inbox view.

It would probably provide a better introduction to Zulip than Recent conversations.
discussion: https://chat.zulip.org/#narrow/stream/101-design/topic/default.20home.20view/near/1688746

Nice catch!

Merged, thanks @amanagr!


Explore self-hosting so I can use CSP nonces

The only way I can see to use CSP nonces is to self-host an NGINX server. Found a way to protect the replacement value:

https://www.11ty.dev/docs/data-js/#example-exposing-environment-variables
https://scotthelme.co.uk/csp-nonce-support-in-nginx/
https://krvtz.net/posts/easy-nonce-based-content-security-policy-with-nginx.html

Solved this using Cloudflare Workers!


[CWS] Skip empty strings when parsing args/envs

What does this PR do?
This PR makes it so that empty strings are skipped when parsing arguments and environment variables.
Prior to this change, an empty string would cause the following arguments and environment variables to be truncated.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge

/merge


Consumer may continue work after changing a cache

Consumer may continue work after changing cache because  startTime InterruptConsumptionExtension  will be updated after reset of container
https://github.com/oroinc/platform/blob/b4821887197ff38705fa0d51b5a51a008fabe4be/src/Oro/Bundle/MessageQueueBundle/Consumption/Extension/InterruptConsumptionExtension.php#L34-L43

Hello, @vtsykun. Could you provide cases when container reset will happened earlier than cache update. So we can reproduce this bug and create ticket with issue.

If cache will update during messages processing (it's interval<PHONE_NUMBER>.9854-1508774531.9907 in my timeline visualization) then the consumer continue works
1508774526.944: Call InterruptConsumptionExtension::__construct
1508774526.944: Call InterruptConsumptionOro\Bundle\MessageQueueBundle\Consumption\Extension\InterruptConsumptionExtension::onStart
1508774526.9462: ------------CHECK_CACHE---------- startTime<PHONE_NUMBER>
1508774526.9702: Call InterruptConsumptionOro\Bundle\MessageQueueBundle\Consumption\Extension\InterruptConsumptionExtension::onPreReceived
1508774526.9854: Process message Okvpn\Bundle\DemoDataBundle\Async\SearchVacuumProcessor::process
1508774531.9907: Reset container Oro\Bundle\MessageQueueBundle\Consumption\Extension\ContainerResetExtension::onPostReceived
1508774532.0437: Call InterruptConsumptionExtension::__construct
1508774532.0437: Call InterruptConsumptionOro\Bundle\MessageQueueBundle\Consumption\Extension\InterruptConsumptionExtension::onPostReceived
1508774532.0439: ------------CHECK_CACHE---------- startTime<PHONE_NUMBER>

Maybe it extension more not needs because, after reset of container a updated cache will be used:) but I am not sure

Thank you for your report.
Created an internal task for the problem (id: BAP-15801).


(#530) Simplify architecture selection

Use the default functionality of Chocolatey to select the correct file
to download and extract.
Fixes #530

@isaacrlevin let me know if you have any questions about this change, but I believe that it will result in the same installation choices that are made in the package today.

LGTM!


COTR and Quadtree

Hi, thanks for posting this great code
Please add COTR and Quadtree as well
Thank you very much

+1

COTR added! https://github.com/Vincentqyw/image-matching-webui/commit/38fd4391904837cb5a36776ba742e11405f553c1


Added codegen_lib target

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Ping. We need this imported ASAP.
@ctiller @yang-g

Comments addressed. PTAL :)

This PR is ready to be re-reviewed. Note the addition of the new codegen_test target.

Sanity is failing

It needs build system changes to allow for transitive dependencies.


Bump version to 3.5.0

Added

@RickvdStaaij: Add ability to trigger events directly from the API (#137)
@RickvdStaaij: Add ability to trigger modules directly from the API (#140)

Fixed

@RickvdStaaij: Use date strings for internal statuses so Firebase can save them (#142)

Improved

@eXistenZNL: Add Husky and lint-staged for better codestyle checks on commit (#136)
@eXistenZNL: Dependency upgrades (#143)

@eXistenZNL ping


Add apiKey.js script to add API keys to database and update usage count.

Add tools/apiKey.js
Modified database/index.js
Modified database/types.js

Description
This PR fixes #28
Notes for Reviewers
Hopefully this is what you want. One function for adding api key to database and another for updating the usage count. Let me know if changes need to be made.
Signed commits

[x] Yes, I signed my commits.

In that case should functions return status codes like this?
if ( keyQuery.length == 0){
        await tbl.add([{api_key: key, usage: MAX_USAGE}]);
        return res.status(200).send(`Data with values: api_key: ${key}, usage: ${usage}, successfully added to table`)
    }
    else {
        return res.status(406).send("Attempted to add existing key to table");
    }

Or should that be handled differently?

In that case should functions return status codes like this?
if ( keyQuery.length == 0){
        await tbl.add([{api_key: key, usage: MAX_USAGE}]);
        return res.status(200).send(`Data with values: api_key: ${key}, usage: ${usage}, successfully added to table`)
    }
    else {
        return res.status(406).send("Attempted to add existing key to table");
    }

Or should that be handled differently?

no, i think this should be handled by functions in /actions/*.js files, they are specifically for req/res related actions.

👍 Got it. Thanks.


add MCP server badge

This PR adds a badge for the MCP NPX Fetch server listing in Glama MCP server directory.

Glama performs regular codebase and documentation scans to:

Confirm that the MCP server is working as expected
Confirm that there are no obvious security issues with dependencies of the server
Extract server characteristics such as tools, resources, prompts, and required parameters.

This badge helps your users to quickly asses that the MCP server is safe, server capabilities, and instructions for installing the server.

Summary by CodeRabbit

New Features

Added a new badge in the README linking to the MCP Fetch service for improved user engagement.

Documentation

Enhanced visual representation of the project with the new badge.

realized the project is missing a license
https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-license-to-a-repository
Would you mind adding one?
We will automatically pick up the change (we scan every repo every 6 hours)

can do !


Pass resolved promise value in web test suite back to parent Node.js runner

The microsoft/vscode#167808 ticket appears to be blocked for now..
But I really want to be able to use some kind of file system access.
This would be possible if the runTests call accepted a callback or script path for handling message payloads from ./test/suite/**.ts.
Alternatively, could I resolve the promise here with a global array of file payloads to write?
https://github.com/microsoft/vscode-test-web/blob/577c16f65e39ef182063d9e40778fc95d113070b/sample/src/web/test/suite/index.ts#L22
That could be wired up to the resolved value of runTests in:
https://github.com/microsoft/vscode-test-web/blob/577c16f65e39ef182063d9e40778fc95d113070b/sample/src/web/test/runTest.ts#L19-L25
From there I would have access to the Node fs module so I could write JSON outputs for data testing

This seems quite the challenge ...
https://github.com/microsoft/vscode/blob/2b54ca810fe289f2cabcba75521b004a021b0a79/src/vs/workbench/api/common/extHostExtensionService.ts#L709-L747
Currently it exits with 1 (🛑) or 0 (🆗) but to transfer other information the passed object would need to become a mutable vscode.*Event interface - an object with a status key that extends a global namespace from inside the worker.
Then we would need to track down each usage and switch it from event: number to event.status as number.
Can this issue be moved to microsoft/vscode to start with, @connor4312?

the passed object would need to become a mutable vscode.*Event interface - an object with a status key that extends a global namespace from inside the worker.

I don't know which object you're referring to

This would be possible if the runTests call accepted a callback or script path for handling message payloads from ./test/suite/**.ts.

What is a "message payload"?

What is a "message payload"?
Currently webviews allow cross window communication using webview.postMessage.
The "payload" there is the posted state object. Same thing here for test result.

I don't know which object you're referring to

I'm suggesting that the run function can resolve to a arbitrary variable.
Then the core app and test package can pass it back to the result of await runTests.

It sounds like the first ask is for 'ipc' with the running extension. I don't have much interest in doing this at the moment. An extension could already stand up a websocket server pretty easily when running tests and do its communicate through there. That is probably what we'd end up doing under the hood anyway.

can resolve to a arbitrary variable.

This seems separate from your ask for ipc -- what purpose are you envisioning that this would serve?

From there I would have access to the Node fs module so I could write JSON outputs for data testing

I will wire something up with IPC I guess..


Generate JSON-Schema

Does this support generating a JSON-Schema by inspecting an object and extracting its attributes as properties within a schema?
I.e. could I take an object, emit both a JSON representation of the object's value and a JSON-Schema representation of the object's structure, and use one to validate the other?

At one point I had tried this, but I was having trouble with some types, like dictionaries.  I'm open to exploring this again.  It may be a while as I'm working over at the schema spec repo and some serialization performance enhancements.

@mikemol what features do you need for this?  For example, do you expect it to place value restrictions (like min/max) on the properties?
I'm thinking that the client (you) could place attributes from the System.ComponentModel.DataAnnotations namespace.  I already use DisplayAttribute for enum serialization, so I don't have to add a reference.
Thoughts?

These attributes don't cover all of the possibilities for schema.  For example, there's no way to specify that a minimum is exclusive vs. inclusive.
May have to create a set of attributes for this.

Just thinking out loud:
An argument against this feature might be that the schema types were designed to be easily created in code.
The response to this is that it creates duplication and maintenance of the model and the requirements in a multiple places.  Whereas if I place attributes directly on my model and then generate the schema from that, I have all of my validation and model in one place.

We use that approach in our Web API's via Swagger.Net. We generate a Swagger definition via convention+attributes and then use that to generate compatible clients.
Likewise if we had a convention+attribute model to generate schemas we could: (a) rapidly create schemas for existing models, and (b) extend our web services to publish their REST model schemas.

I think I'm going to need to have the client provide a serializer for this.  There are mechanics that the serializer is already set up to address:

property name transforms
enumeration serialization (both number and named, and considering the Display attribute)
property selection (read-only vs read/write vs write-only)

See branch feature/issue-121-schema-generation

I'll give it a go. Might take a bit. Had a hardware failure last night...

I have made some additional improvements.  I'm working on extracting common schemas into the root definitions collection.

@mikemol I have a question about your preference for the output schema.  The way I see it there are a couple options:
Repetition
Schemas for properties are simply defined at that property.  If there is a property that has exactly the same type and restrictions, the schema is simply repeated for that property.
{
  "properties" : {
    "int1": { "type" : "integer", "maximum": 20 },
    "int2": { "type" : "integer", "maximum": 20 }
  }
}

Consolidation
The final schema is scanned for duplicates.  The duplicates are then collected to be stored in the root's definitions collection and any usages are replaced by $refs.
{
  "definitions" : {
    "integer_max_20" : { "type" : "integer", "maximum": 20 }
  },
  "properties" : {
    "int1": { "$ref" : "#/definitions/integer_max_20" },
    "int2": { "$ref" : "#/definitions/integer_max_20" },
    "int3": { "type" : "integer", "minimum" : 10 }
  }
}

I've been using the branch in my test setup, and had to make one change for it to work with our performance enhancements:
@@ -126,1 126,1 @@ Manatee.Json/Schema/Generation/SchemaGenerator.cs
-								  .Select(v => new EnumSchemaValue(((JsonValue)serializerMethod.Invoke(serializer, new[]{v})).String))
+								  .Select(v => new EnumSchemaValue(((JsonValue)serializerMethod.Invoke(serializer, v)).String))

It appears to work well for my needs (fairly simple).

I'd also enjoy a JsonSchemaFactory method to call GenerateFor using the default schema format.

@sixlettervariables I'm building it with draft 7 for now. I'll update to support all drafts once I nail down the logic.
I'm not sure what you mean by "events" in this context. Can you elaborate?

@gregsdennis just an example of how we're using JsonSchema in our application (i.e. part of a distributed events system).

@mikemol @sixlettervariables any additional thoughts on this?  It's a good feature.  I don't want to see it stall out, but I think we need to nail down the desired behavior.

Okay.... It's been a long time, but I think I need to get this done.  I've also since rebuilt the schema implementation, and I failed to keep this branch up-to-date.  That means that I have a lot of work to redo. 😢

Okay.... It's been a long time, but I think I need to get this done. I've also since rebuilt the schema implementation, and I failed to keep this branch up-to-date. That means that I have a lot of work to redo. 😢

Does the current library support generating json schema from c# object?

Sadly no.  I never got the chance to rewrite this.  Life happens, you know.  If there's enough interest, I might be able to find some time.

@gregsdennis Thanks for your effort  for other features. @fgajtanovski  you can use https://github.com/RicoSuter/NJsonSchema/wiki/JsonSchema for this requirement.

@gregsdennis Thanks for your effort for other features. @fgajtanovski you can use https://github.com/RicoSuter/NJsonSchema/wiki/JsonSchema for this requirement.

Hi @glikoz isn't that requires a commercial licence? I know https://www.newtonsoft.com/store/jsonschema do.

No it does not. It is not related with Newtonsoft. It is another nuget package https://github.com/RicoSuter/NJsonSchema

I would have loved this feature for a current project, but had to resort to doing schemas manually and just manipulating them with this lib.
One thing that I think could be really beneficial is that if you load your C# models with data in them and then generate the schema, it will actually take that into account and add for example oneOf/anyOf or similar for the data that is loaded, and it could be specified with an attribute.


fix: Deployment CPU request is wrong format [2]

:hankey: Broke the build via #100.. sigh

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please ask for approval from tumido after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

self-approving
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: tumido
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [tumido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add uuid to rides as a unique id

As a developer, I want to add a unique UUID to each ride record, so that each ride has a reliable, globally unique identifier.
Acceptance Criteria:
Each new ride document should have a unique _id field generated using UUIDs.
The system should use _id as the primary identifier for each ride, improving reliability and reducing ambiguity in record lookups.
Existing routes relying on _source_destination should transition to using _id for consistency.

Used uuid instead of source and destination point of the ride which could mislead if there are 2 rides with the same start and end point.
Please find the commit attached here


Ignore ".only" by config

What do you think about an option to ignore ".only" by config. This can be useful if a developer forget and commit such code, but in build we want to execute all tests.

Happen to be wondering about almost the same thing. In our use case, we want to raise an error on the build machine if ppl accidentally check in code with exclusive tests
Found a hack as follows
  var mocha = require('mocha')
  var original_loadFiles = mocha.prototype.loadFiles
  mocha.prototype.loadFiles = function (fn) {
    this.suite.on('pre-require', function (context, file, self) {
      context.describe.only = function () {
        throw new Error('Exclusive test suite is not allowed(remove "describe.only" in file ' + file + ').')
      }
      context.it.only = function () {
        throw new Error('Exclusive test case is not allowed(remove "it.only" in file ' + file + ').')
      }
    })
    original_loadFiles.call(this, fn)
  }

There is prob a better way to do it and you might not want the same thing. You could also try using a custom interface based on interfaces/bdd.js or something like that. However, I think it ll be nice if mocha provides a way to toggle different behaviors around this.

@amiram I personally prefer to fail the build if a .only is committed, unless you want to start having a bunch of .onlys in your tests. And then you would start having builds that pass locally (because some tests are omitted because of the .only), but don't pass in CI (because all tests are ran).
You can use this package for your hooks and CI: https://github.com/dasilvacontin/dot-only-hunter.

@jiangyang your code looks good enough for me. @dasilvacontin you're probably right.

Closing since I feel like the proposal – ignoring .only – is not really wanted (probs looking for #1935).
Let us know otherwise! :)

I would say ignoring only as a flag would be ideal

I actually found this because I'm looking for a way to use two terminals, both with mocha --watch, one running with the .only on new tests that I'm adding while the other runs all my tests as I make major modifications.  That would allow me to focus on just the new tests, while also ensuring that the rest of the tests are still fine.


Fix typo in /examples/seq2seq/README.md

Fix typo in /examples/seq2seq/README.md :D

pfnCI, test this pease.

LGTM! Waiting for CI finish.

pfnCI, test this pease.


Dynamic routes break when deploying built nuxt 3 app (boiler plate)

Environment

Operating System: Windows_NT
Node Version:     v16.17.0
Nuxt Version:     3.0.0-rc.11
Nitro Version:    0.5.4
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
I created a boiler plate nuxt 3 project like so:
npx nuxi init test-build
cd test-build
npm i
I then made a few small changes. In nuxt.config.js, I added:
ssr: false
I also added a pages folder, with a structure like so:
pages/products/[id].vue
Inside that file, I put:
<template>

hello world

</template>

Finally, in app.vue, I changed it to:
<template>

    <NuxtLayout>
      <NuxtPage />
    </NuxtLayout>

</template>

Now, do an "npm run build". I took the contents of the build (public output directory) and deployed it to an Azure static website (since ssr = false this should work). When navigating to a dynamic route like /products/123, you get a 404 even though the page shows "hello world" when running "npm run dev".
Describe the bug
Dynamic routes show a 404 when deployed. I should note that non-dynamic routes (pages in the top level of the pages directory) load just fine.
Additional context
No response
Logs
No response

@danielroe i Think need to add the right fallback example for caddyserver


Workflow

Hey,
It's just a question, because I get blocked many chips. I seeing the worflow in API
https://github.com/mgp25/Chat-API/wiki/WhatsAPI-Documentation#whatsapp-workflow
and not find the difference in first and others logins in your code. Other point is the [Done automatically by the API] comment in this link.
I'm doing a new script that does me online/offline and after online create a cron to getAllMessages and pollMessage or not, depends, and on offline stop that cron.
Using this client MGP (with old script) every time I doing login after minimun 10sec (sleeping the cron) and call offline on destruct. My old script run in 1:30 hour before blocking, 30min with no messages to receive/send. The log not working, the folder is empty. So, I wont see what happens. In this old script I do a sync proccess: getNewMessages(),pollMessages()[depending], sleep(min 10 sec.), do again.

You're right. This wrapper needs some mechanism to detect first and other logins. Let me get another SIMs to test. Any suggestions?

No one valid. You can done in registration after registerCode, but my code (for example) can create a number with the register process or put password manually (before registered with other application). In this case, you never known if is the first login or not, but if the number pass to your register process you known that is the first and can simulate  a first login inside that process! others situation,
In others situation, user may use the gateway to make custom logics.

You can provide this method in MGP, for personal and almost usages:
     /**
     * Set connected property
     *
     * @param boolean $b
     * @return void
     */
    public function setConnected($b){
        $this->connected = $b;
    }

With this, we can use gateway() without send connectAndLogin again. I'm triggering the online/offline in a button manually.

Maybe what you need is a Queue Handler to make work only one instance of the whatsapi instance without request multiple login and logout in the process


(disallow|require)SpacesInFunctionDeclaration: coverage

Waiting for Esprima 2.x branch

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/14881369-disallow-require-spacesinfunctiondeclaration-coverage?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F281640&utm_medium=issues&utm_source=github).

Can close this now


[Hub Generated] Review request for Microsoft.IoTCentral to add version stable/2018-09-01

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

@kawayiboy Hi. Is this PR ready for review?

Can one of the admins verify this patch?


[core] URISyntaxException when run test on windows

Purpose
Linked issue: close #3803
Tests
API and Format
Documentation

Sorry, we don't have windows system to valid this PR.


feat: add toJSON

Same reasoning as for valueOf, not sure how to update README tho

ok, because I've seen this only now, I might land the change with README update and everything but I'd like to brainstorm a bit here ... wouldn't be better if toJSON() returns {value: this.peek()} instead? That looks like a more explicit representation about the fact the value was a signal to me, but maybe others already do the normal toJSON dance and that's just the value indeed? 🤔

@qwelias uhm ... actually that's not symmetric on parse(stringify(signal)) so maybe mine is not a good idea ... thoughts?

I've went ahead and added toJSON s you suggested, it's published now.


New generic inline editor FormField (similar to WidgetAreaEditor)

Shows the edit forms in collapsible panels
Should be GridField based (useful in other contexts as well, e.g. quick edit in ModelAdmin)
Has enough extension hooks to allow stuff like flagging a row as “changed”, or indicate workflow states
Example implementation: https://github.com/smindel/silverstripe-GridFieldAddOns/blob/master/docs/en/GridFieldExpandableForm.md

And Richer overview on GridField rows

Invision files for inline editing designs: https://invis.io/EQGL9JRJFYV

cc @newleeland

Relies on React Gridfield work possibly. Related https://github.com/silverstripe/silverstripe-admin/issues/463

We're working on this at the moment with the React elemental editor rewrite, progress can be tracked on the numerous issues floating around at the moment


Changed max hub sites number

https://www.microsoft.com/en-us/microsoft-365/roadmap?filters=&searchterms=51933
https://github.com/MicrosoftDocs/office-docs-powershell/issues/3915

Docs Build status updates of commit 74577a1:
:clock10: Full build: the average full build time is 11 min(s) 51 sec(s), this is based on the last 948 build(s) for this repository.

Docs Build status updates of commit 74577a1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Register-SPOHubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit c339af6:
:clock10: Full build: the average full build time is 11 min(s) 50 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit c339af6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-online/Register-SPOHubSite.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


x/tools/gopls: experimentalWorkspaceModule does not work for the standard library

Reminder issue: the experimentalWorkspaceModule setting does not behave correctly for std and cmd. We should (1) document this, and (2) investigate.
Moving this to v0.7.3 for at least improving the documentation.
CC @stamblerre

Dupe of https://golang.org/issue/45890?

Yep, closing and moving the other issue to v0.7.3 milestone.


Updated with new file name for Simplified Chinese Translation

For testing purpose, using zh_Hans as file name

I think the format problem is cause by using Weblate and I am following the format it showed me. Anyway, cn.yml and format is fixed though I don't have a local testing machine now for testing so I don't know if it will work.

Hm, might need to drop that Hans file..

Right, after talking on forum and with few other translator I found out that the code that will determines what language flarum should use is actually in the composer.json, under "flarum-locale". That which means no easy way to do it unless our lead devs decide to enforce more unity. As far as I concern, I might just do a full translation by my own. So feel free to do whatever you want ( change to zh.yml or something else).


Basic export in Mermaid format

This exports in Mermaid flowchart format, with all the same features as the D2 export, but does not attempt to export links or other enhancements available in Mermaid.

Wow, thanks @kcaswick
Also, your PR discloses I have not configured GitHub actions correctly for external PRs


Make session a true Ember.Service

I think this is a sensible refactor that would provide more consistency for developers.

@tim-evans There are many things we can improve :-p Torii pre-dates many things we now consider idiomatic, the addon/ and app/ addon layout for instance. Making the torii and session services into Ember.Service objects is definitely reasonable.

Haha, yeah. It's a bit of a mad scramble / constant refactor to keep things feeling svelte.

Just going to reference https://github.com/Vestorly/torii/pull/214 so this can be closed whenever that gets merged in.

@razor-x #214 was already merges. This should already be completed in the latest release. The service is named whatever your configuration names it.


Add documentation for authentication in Next.js using SAWO

Currently, I've added the steps to create Next.js app, generate SAWO API key and how to integrate it.
I'll be adding the video tutorial and repo link in a day or two.
Closes #7

Thanks @irsayvid


Evaluate on validation dataset and do checkpoint every N batch

Hi,
May I ask is there anyway to do evaluation on validation dataset every N batch and do checkpoint?

mx.io.resizeiter

Thank you so much!

Internal reset should be disabled in order to continuing the training on the rest of data:
test_res = mx.io.ResizeIter(test, num_batches, reset_internal = False)

@piiswrong
Just to add, it seems that using ResizeIter will reset the data iterator every time it does the evaluation instead of continuing training the rest data.
Following the below issue will solve the problem.
https://github.com/dmlc/mxnet/issues/1593


[terra-date-picker] minDate maxDate are not string format

Proptype checks fail here because minDate and maxDate need to be of string format. This is causing our jest tests to fail.
https://github.com/cerner/terra-framework/blob/e631d877bf6dcb3798f62bd980f8d45b02daaeb5/packages/terra-date-picker/src/DatePicker.jsx#L500C17-L500C24

@dp21g  I would like to work on this issue!


Diagnostics: CompositeTask adds by ref, not owned.

Adding to a CompositeTask via owned tasks means the same task cannot be added to a composite that can be added to an updater. Also seems to prevent adding something (like a FrequencyStatus) which is owned by an Arc, as Arc<FrequencyStatus> does not impl Task AFAICT.

There really is no need for taking ownership here, correct.


Update GitHub-pages dependencies

This PR updates jekyll and other gems to the latest versions as specified here. The webrick gem was added to the Gemfile in order to run it locally with Ruby 3.0.0.

Many thanks @doerners 👍


0.3.11 build 1 (downpin OFF toolkit)

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@mattwthompson Thanks for rerender - This is ready for review when you have a moment!

@conda-forge-admin, please rerender

Should pymbar be constrained as well? I'm using 68c9e37699044a78d51084708028aa2b286af4e5 / #10 as a reference, and the relevant diff (git checkout jeff/main && git diff 68c9e37699044a78d51084708028aa2b286af4e) is
diff --git a/recipe/meta.yaml b/recipe/meta.yaml
index b5e3d19..34ef0a1 100644
--- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -7,10 +7,10 @@ package:

 source:
   url: https://github.com/openforcefield/{{ name }}/archive/v{{ version }}.tar.gz
-  sha256: bad05e7460286548ea1f38c1da9b01ea8b030fe5f67a4699ce75302cead267dc
+  sha256: a17c2878778e27374a07fb3f16a014fec112af2918fa70769359ab63e99d701f

 build:
-  number: 0
+  number: 1

 outputs:
   - name: {{ name|lower }}-base
@@ -24,15 +24,14 @@ outputs:
         - pip
       run:
         - python >=3.6
-        - openff-toolkit-base >=0.10.6
+        - openff-toolkit-base >=0.10.6,<0.11
         - openff-units >=0.1.4
         - numpy
         - pandas
-        - openmm
+        - openmm >=7.6
         - networkx
-        - pint
         - packmol
-        - pymbar >=3.0.5
+        - pymbar >=4.0.0
         - mdtraj >=1.9.3
         - dask >=2.7.0
         - distributed >=2.7.0
@@ -44,7 +43,8 @@ outputs:
         - rdkit
         - cmiles-base
         - python-dateutil
-        - pydantic
+        - pydantic <2.0.0a0
+

     test:
       imports:
@@ -81,3 +81,4 @@ about:
 extra:
   recipe-maintainers:
     - simonboothroyd
+    - mattwthompson

I'm pretty sure the existing 0.3.11 release will not work with pymbar >=4, going by chronology alone, and I don't have plans to make a 0.3.12 that fixes this. I think Pint should also be added back? The other constraints look good to me.

Actually, I can see Pint in the logs since openff-units is snuck in somewhere. I can take or leave that change.

Pint is pulled in by openff-units, so I think that's in good shape.

Should pymbar be constrained as well?

Ah, good call, I'll pin that.

I don't have plans to make a 0.3.12 that fixes this

Agreed, no need to make that.

Thanks!

Oh - I can't merge because I'm not a maintainer 🤦 Could you do it? I've also added myself to the maintainers to avoid this problem in the future.

Instead of the simple solution, I've added you as a maintainer separately (https://github.com/conda-forge/openff-evaluator-feedstock/commit/c29187bf1cc72ca8c95bcebbbffddbda5b4caab5) - you should be able to merge now?

Nice - Thanks!


⚠ Minecraft has degraded performance

In 8a5ed02, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1266 ms

Resolved: Minecraft performance has improved in 2b711c7.


rename spark.url to resource manager url and log exception stack tree

rename spark.url to resource manager url and log exception stack tree

LGTM.

rename spark to resource manager is a good proposal, but rm always remind me the remove command, maybe we need to use full name as 'resource.manager', that makes things  clear.
@jasonliaoxiaoge  what do you think?

Done, change to yarn url

hi Jason,
Thanks, that makes sense.
William


Temporary band-aid fix for mzTab-M import throwing NPEs when raw files are unavailable.

Prevents unsolicited NullPointerExceptions to propagate all the way up to the error modal dialog handler.
Band-aid for https://github.com/mzmine/mzmine3/issues/803

Merge the latest and drop the changes to the version file and the conflict is resolved

@robinschmid Closing this PR since it will be superseded by Olena's PR.


Configure CodeQL

@barthalion I am unfamiliar with this, looked at the action logs but could not find anything that seemed like a "result".
I noticed this btw:
Warning: We were unable to install your python dependencies. You can call this action with 'setup-python-dependencies: false' to disable this process.

Just leaving it here for now so I don't forget it exists, this is the default job as configured by GH so I did not expect it to work.


Allow for user-provided schema version storage and retrivial

Reading the documentation, the migration table is hardcoded to _sqlx_migrations with an implementation defined schema.
Since I'm already going to have a small table for unique key-value pairs, I'd like to store the version schema in that table. If possible, I think an interface like this would be ideal:
let current_schema_version: i64; // User code to fetch the current version.
let new_schema_version = migrate_from!(current_version).await?;
// User code that saves the new version somewhere.

Otherwise if reusing the Migrator struct is preferable:
let current_schema_version: i64; // User code to fetch the current version.
let new_schema_version = migrate!()
    .with_current(current_version)
    .run(&pool)
    .await?;
// User code that saves the new version somewhere.

Describe alternatives you've considered
Right now the Migrator object seem to offer a way for the user to define their own migration source with the MigrationSource trait, but it doesn't seem to offer an API to load and retrieve the current version.

If you want to get the current applied version, you can call Migrate::list_applied_migrations() on a connection and look at the last migration in the list.


Python from Windows App Store not supported

Hi, I followed the guide to install Nuitka, however I installed Python 3.8.2.
If I write python --version everything works correctly. Also gcc --version works. I also installed nuitka with pip install nuitka, but if I write nuitka it tells me
"" C: \ Users \ xxx \ AppData \ Local \ Packages \ PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0 \ LocalCache \ local-packages \ P
ython38 \ Scripts \ python "" is not recognized as an internal or external command,
 an executable program or batch file.
But writing python -m nuitka the help page appears.
However if I try to compile any .py file I get several errors:
Traceback (most recent call last):
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka_main_.py", line 182, in
main()
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka_main_.py", line 173, in main
from nuitka import MainControl # isort:skip
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka\MainControl.py", line 33, in
from nuitka.freezer.Standalone import copyDataFiles
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka\freezer\Standalone.py", line 45, in
from nuitka.nodes.ModuleNodes import PythonShlibModule, makeUncompiledPythonModule
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka\nodes\ModuleNodes.py", line 31, in
from nuitka.optimizations.TraceCollections import TraceCollectionModule
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka\optimizations\TraceCollections.py", line 33, in
from nuitka.nodes.NodeMakingHelpers import getComputationResult
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka\nodes\NodeMakingHelpers.py", line 31, in
from nuitka.Builtins import builtin_names
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka\Builtins.py", line 190, in
builtin_anon_names, builtin_anon_codes = _getAnonBuiltins()
File "C:\Users\xxx\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.8_qbz5n2kfra8p0\LocalCache\local-pack
ages\Python38\site-packages\nuitka\Builtins.py", line 145, in _getAnonBuiltins
with open(sys.executable) as any_file:
OSError: [Errno 22] Invalid argument: ’C:\Users\xxx\AppData\Local\Microsoft\WindowsApps\PythonSoftwareFounda
tion.Python.3.8_qbz5n2kfra8p0\python.exe’
Thank you if you want to give me an indication.
Ambro

That's very strange, I am also confused as to the directory name, never seen those kind of names, but then again, I always choose where to install Python myself. I am upgrading to 3.8.2 just to see if there is anything that changed.

Hi, I noticed that the error occurs if you install Python from the Microsoft Store, as I had done. For this there were these strange folders. Installing Python normally from python.org works correctly, even with version 3.8.2.

Ok, that's unsupported I guess, but I will try have a look at the difference. Very strange looking one though.

Not being allowed to open sys.executable for reading is very probably a security thing for Windows apps, and limits our ability to work with this very severely. I will add a check for it, or an exception handler, that catches this, and explains it.
I also added something to user manual that you probably didn't read, as it already says what is only supported.

Thanks a lot. Congratulations on this beautiful project.

The check is now in the latest pre-release, and will soon be released.

The release 0.6.8 was just made and contains the correction.


Clippy

This PR addresses comment https://github.com/cryspen/bertie/pull/24#discussion_r892725473.
Type of change

[ ] Bug fix
[ ] New feature
[ ] Breaking change
[ ] Documentation
[x] Automation (?)

Motivation and Context
Clippy is generally useful and warnings should only be ignored consciously. This reduces some noice and cleans up the code.
Changes
Apply some of the changes introduced by cargo clippy --fix.
Checklist

[x] I have linked an issue to this PR (?)
[x] I have described the changes
[x] I have read and understood the code of conduct, contribution guidelines, and contributor license agreement
[x] I have added tests for all changes
[x] I have tested that all tests pass locally and all checks pass
[x] I have updated documentation if necessary

Nice PR template! "Type of change" doesn't fit here super well and there is no issue I could reference. Maybe that should be optional.

I can either silence or resolve the "this is a decimal constant" warnings by removing the leading 0. This would make Clippy almost happy.


brew install guumaster/tap/hostctl  does not work on Apple M1

Error: Invalid formula: /opt/homebrew/Library/Taps/guumaster/homebrew-tap/hostctl.rb
formulae require at least a URL
Error: Cannot tap guumaster/tap: invalid syntax in tap!

Hi @yaohuangguan thanks for reporting this. The publication as a homebrew formula is handled by goreleaser.
It looks like this is a goreleaser issue only addressing CPU.intel.
The formulae is updated with the latest release here: https://github.com/guumaster/homebrew-tap/blob/master/hostctl.rb.
I'll check on goreleaser docs/issues to see if they've addressed this.

what should i do in this case to work properly?

@yaohuangguan actually this is an issue with the tool to release versions, so no much you can do unless you know something about goreleaser. It'll take some days until I get time to investigate further.
In the meantime, you can try the binary that are generated here: https://github.com/guumaster/hostctl/releases/tag/v1.1.0

@guumaster The above mentioned command does not work, but the binary does! Thanks for the fix and great work on this project! 👍🏻

I added a PR to the guumaster/homebrew-tap repo that will add the ARM release to macos. This should make hostctl installable with homebrew on M1 macs.

I've merged it, but I'm afraid that file is automatically updated by go-releaser GitHub action though

Just want to chime in to say that the current macOS release still does not work on Apple Silicon without Rosetta installed.
Apple Silicon support has only landed in Go 1.16: https://go.dev/doc/go1.16#darwin
Bumping Go version to 1.16 from the current 1.14 should build a correct darwin arm64 binary file.


Update "ort" to version "1.16.3"

I was unable to cargo add rmbg to a project of mine and have it properly compile: I would consistently get errors while at the step to build ort.
Consequently, I updated to rmbg's version of ort to match the latest on crates.io, and reworked functionality in lib.rs to match the new styles: most notably, using an ort::Environment.
The other portion of this is features. The feature flags for ort are different in this version (most notably no ndarray), and so I personally saw it fit to tackle the topic of features. Specifically speaking, despite the way that the README described the adding of rmbg, there are no feature flags used by rmbg. The README seems to be describing the (now different) feature flags of ort, but those are not directly accessible. As far as I'm aware, in its current state, adding features to one's cargo.toml for rmbg would do nothing. Work could be done to pass flags given to rmbg into ort, but for now, it does not. Considering this, I think that rmbg must include all the default of ort, as otherwise the end user would not be able to get full functionality without pulling and modifying rmbg themselves. That all being said, I could be misunderstanding some of the reasoning here, and this portion could be reverted. As my note, I respect the concept of debloating by default, but then the feature passing is a must-have functionality.
The only other change I did was to the README. I removed the installation portion in regards to features, as per my comments above. I also like to have the base example be as easy to pull up as possible, so I sacrificed a little bit of safety by replacing ? with .unwrap() which allowed the removal of the anyhow crate being needed: image is still being needed, but a note was added.

After thinking about it more, I decided that this PR was unfinished without actually tackling the feature issues that I touched on.
Now, rmbg has the feature flag download-binaries which acts as a pass-through to activate ort's download-binaries. For ort, the other two default features are copy-dylibs and half, so I included those as implicit inclusions, regardless of feature flags set on rmbg.
I also decided to have download-binaries be a default feature for rmbg. This means that one can actually startup a project without issues with a simple cargo add rmbg, which I personally value rather highly. The bloat concern (and mild security concerns presented in ort docs) are completely fair, though, of course. All this should mean is making sure to disable default features for rmbg, since that would disable the download-binaries feature flag of rmbg, which would mean not enabling the download-binaries feature flag of ort. Either with default-features = false in the cargo.toml directly, or a --no-default-features flag on one's terminal cargo add rmbg.
I updated the README to reflect these changes.


Cannot start service mosquitto: Ports are not available: listen tcp <IP_ADDRESS>:1883: bind: An attempt was made to access a socket in a way forbidden by its access permissions.

I'm doing the simple Docker install and cannot get mosquitto to run. I get the following error every time.
PS C:\Users\peter> docker-compose up -d
Creating network "peter_default" with the default driver
Creating peter_teslamate_1 ...
Creating peter_mosquitto_1 ... error                                                                                Creating peter_grafana_1   ...
Creating peter_teslamate_1 ... done
Creating peter_grafana_1   ... done                                                                                Creating peter_database_1  ... done
ERROR: for mosquitto  Cannot start service mosquitto: Ports are not available: listen tcp <IP_ADDRESS>:1883: bind: An attempt was made to access a socket in a way forbidden by its access permissions.
ERROR: Encountered errors while bringing up the project.
Operating environment

TeslaMate Version: 1.18.1
Type of installation: Docker
OS: Windows 10 Pro

I just googled the error message and found this thread that might be helpful to you: https://github.com/docker/for-win/issues/3171
Closing this since it is apparently a know Docker-for-Windows/Hyper-V problem and not specific to TeslaMate.


"Lost" the usage graphs atop the main window

Describe the bug
Not sure if it's an actual bug or just a pebcak but I lost the usage graphs at the top of the main PH window and cannot find how to restore them.  Have been through the settings/options many times and cannot find.  Right clicked everywhere I could think of, cannot find.  At a loss here.
Screencap attached.
Thanks
Desktop (please complete the following information):

OS: Windows
Version Win 10 1903

Did you try to enable that from the View -> Toolbar -> CPU history option?

I lost the usage graphs at the top of the main PH window

Did you disable the toolbar?

Feel free to reopen if you're still having issues 👍

Hey now, sorry for delayed reaction.  Missed the email notify.

Did you try to enable that from the View -> Toolbar -> CPU history option?
I don't have that option in my menus

I lost the usage graphs at the top of the main PH window

Did you disable the toolbar?

Or disable the ToolStatus plugin?

I'm not sure how far behind I am.  I'm on 2.39 (which I thought was the current stable ver) and my options gui doesn't look ANYTHING like that.  Also, I have zero installed plugins.

Thanks.  Help much appreciated.
J.

All your plugins are missing... You will either need to reinstall the latest stable or install the latest nightly.

Also make sure you haven't accidently disabled plugins from the options window:

Ok.  Idk how that could've happened.  I know for sure I didn't disable or delete these myself.
I wonder if my AV could have smth to do with this..

Just want to update.  Reinstalling (well, unzipping the portable) package restored everything and works now.  Definitely my AV clobbered.
For reference that's BitDefender's GravityZone endpoint.
Not sure why it keeps flagging you.  Maybe you can submit to them so they recognize you as legit?
Anyway, I'm sorted for now.  Thanks for all the help.

BitDefender's GravityZone endpoint

Why just the plugins and not the whole project?

Not sure why it keeps flagging you. Maybe you can submit to them so they recognize you as legit?

Some grifter at Microsoft decided to blame the project for every last ransomware attack last year in their Defence Report:

Microsoft’s Detection and Response Team (DART) has observed that ransomware continues to be the most common reason behind our incident response engagements from October 2019 through July 2020. More threat actors are using open-source tools like ProcessHacker to initiate the attack that ultimately delivers ransomware payload.

Vendors are using that statement as a pretext to target and block the project. #454

BitDefender's GravityZone endpoint

Why just the plugins and not the whole project?

Assumedly I had the main process excepted in the AV (I don't actually remember it would have been done a good while ago) and not the plugins.  And then further assumption, a recent-ish update in the AV made it yet more aggressive so it ate the plugins (perhaps based on some new EDR features added to our account - not sure on the timing, kinda guessing)

Not sure why it keeps flagging you. Maybe you can submit to them so they recognize you as legit?

Some grifter at Microsoft decided to blame the project for every last ransomware attack last year in their Defence Report:

Microsoft’s Detection and Response Team (DART) has observed that ransomware continues to be the most common reason behind our incident response engagements from October 2019 through July 2020. More threat actors are using open-source tools like ProcessHacker to initiate the attack that ultimately delivers ransomware payload.

Vendors are using that statement as a pretext to target and block the project. #454

That kinda sucks.  They should be more diligent.  Perhaps work with you to check via hash or smth that the main .exe and/or other parts aren't compromised but I'm sure that's easier said than thought up.
Either way I've added more explicit, detailed exceptions.  For the main folder, the plugins folder, kprocess.sys, peview.exe and ofc the ph exe.   Hopefully that's sufficient to keep it from attacking ph and at least if it happens again I'll know wtf to look for.
And hopefully this now shows up in searches in case anyone else gets painted into the same corner.
thx.


adtag problems

Добрый день!
При попытке запуска в докере с указанием adtag в лог валится ошибка:
{"level":"error","ts":1549551762.0736535,"logger":"main","msg":"Cannot initialize server connection","connection_id":"0da214ef-e6db-40d9-a66c-f22152d2f272","error":"Cannot handshake telegram: Cannot read RPC handshake response: Cannot read frame padding: Cannot read from socket: EOF","errorVerbose":"EOF\ngithub.com/9seconds/mtg/wrappers/blockcipher.go:37: Cannot read from socket\ngithub.com/9seconds/mtg/wrappers/mtproto_frame.go:52: Cannot read frame padding\ngithub.com/9seconds/mtg/telegram/middle.go:100: Cannot read RPC handshake response\ngithub.com/9seconds/mtg/proxy/proxy.go:118: Cannot handshake telegram"}
Клиенты при этом не подключаются.
Запускать пытался вот так:
docker run --name mtg-latest --restart=unless-stopped -p 8888:3128 -p 3129:3129 -d nineseconds/mtg:latest -s <ddsecret> <adtag>
При запуске без adtag все прекрасно работает. Пробовал на stable и latest.
Может быть опять какие-то изменения в API, как этом issue?

yup , i have same problem .
it happens even when it's not with docker .

Cannot handshake telegram - please check that time on your machine does not drift, this is important for "adtag" protocol since Telegram checks it on the server side. If you have log messages like "NTP time drift", this is the problem.

Cannot handshake telegram - please check that time on your machine does not drift, this is important for "adtag" protocol since Telegram checks it on the server side. If you have log messages like "NTP time drift", this is the problem.

in my case There is NO ERROR about time drift !
level":"info","ts":1549872711.2822554,"msg":"Use middle proxy connection to Telegram"}
{"level":"info","ts":1549872712.0225432,"msg":"Telegram middle proxy data has been updated"}
{"level":"info","ts":1549872712.6344993,"logger":"main","msg":"Client connected","connection_id":"5407c897-2ed7-482a-a8db-2579c4588743","addr":"ip:51576"}
{"level":"error","ts":1549872712.6389215,"logger":"main","msg":"Cannot initialize client connection","connection_id":"5407c897-2ed7-482a-a8db-2579c4588743","error":"Cannot parse obfuscated frame: Unknown protocol: Unknown handshake protocol","errorVerbose":"/home/vagrant/safe/go/src/github.com/9seconds/mtg/mtproto/connection_options.go:86: Unknown handshake protocol\n/home/vagrant/safe/go/src/github.com/9seconds/mtg/obfuscated2/obfuscated2.go:40: Unknown protocol\n/home/vagrant/safe/go/src/github.com/9seconds/mtg/client/direct.go:43: Cannot parse obfuscated frame"}
{"level":"info","ts":1549872713.1616642,"logger":"main","msg":"Client connected","connection_id":"8435b841-2a99-423f-83b8-ef2ee62c84fc","addr":"ip:51578"}
{"level":"error","ts":1549872713.1711507,"logger":"main","msg":"Cannot initialize client connection","connection_id":"8435b841-2a99-423f-83b8-ef2ee62c84fc","error":"Cannot parse obfuscated frame: Unknown protocol: Unknown handshake protocol","errorVerbose":"/home/vagrant/safe/go/src/github.com/9seconds/mtg/mtproto/connection_options.go:86: Unknown handshake protocol\n/home/vagrant/safe/go/src/github.com/9seconds/mtg/obfuscated2/obfuscated2.go:40: Unknown protocol\n/home/vagrant/safe/go/src/github.com/9seconds/mtg/client/direct.go:43: Cannot parse obfuscated frame"}
{"level":"info","ts":1549872713.8796258,"logger":"main","msg":"Client connected","connection_id":"fba38be9-2ebb-4001-a1d9-55cf46a75c4f","addr":"ip:51580"}
{"level":"error","ts":1549872713.880114,"logger":"main","msg":"Cannot initialize client connection","connection_id":"fba38be9-2ebb-4001-a1d9-55cf46a75c4f","error":"Cannot parse obfuscated frame: Unknown protocol: Unknown handshake protocol","errorVerbose":"/home/vagrant/safe/go/src/github.com/9seconds/mtg/mtproto/connection_options.go:86: Unknown handshake protocol\n/home/vagrant/safe/go/src/github.com/9seconds/mtg/obfuscated2/obfuscated2.go:40: Unknown protocol\n/home/vagrant/safe/go/src/github.com/9seconds/mtg/client/direct.go:43: Cannot parse obfuscated frame"}
{"level":"info","ts":1549872714.4234707,"logger":"main","msg":"Client connected","connection_id":"6d367d30-e89a-47be-8775-b7b233d69a35","addr":"ip:51582"}
{"level":"error","ts":1549872714.4267185,"logger":"main","msg":"Cannot initialize client connection","connection_id":"6d367d30-e89a-47be-8775-b7b233d69a35","error":"Cannot parse obfuscated frame: Unknown protocol: Unknown handshake protocol","errorVerbose":"/home/vagrant/safe/go/src/github.com/9seconds/mtg/mtproto/connection_options.go:86: Unknown handshake protocol\n/home/vagrant/safe/go/src/github.com/9seconds/mtg/obfuscated2/obfuscated2.go:40: Unknown protocol\n/home/vagrant/safe/go/src/github.com/9seconds/mtg/client/direct.go:43: Cannot parse obfuscated frame"}

@someone99119 you have another problem: mismatch of the secret. The secret on client and server are different.

@someone99119 you have another problem: mismatch of the secret. The secret on client and server are different.

Its working before adding ad-tag .
it detects ad-tag properly but user can't connect

The user cannot connect because proxy cannot decrypt its packets. It happens because of the different secrets on both user and client. At that moment connection to Telegram is not established yet, proxy failed to decrypt user traffic.

Cannot handshake telegram - please check that time on your machine does not drift, this is important for "adtag" protocol since Telegram checks it on the server side. If you have log messages like "NTP time drift", this is the problem.

I've checked it out. System time is synced by NTP and there's not any NTP errors in the log. It works perfectly without ad-tag with the same secret.

The user cannot connect because proxy cannot decrypt its packets. It happens because of the different secrets on both user and client. At that moment connection to Telegram is not established yet, proxy failed to decrypt user traffic.

Thanks .
i was adding ad-tag first parameter and secret after it ...
after adding secret and ad-tag after that everything is ok .
sorry !

@snetesa could you please share full log somewhere on pastebin?

@someone99119 great it works now :)

Sure: https://pastebin.com/iiXTNj9i
There is one repeating error it the log. IP and secret were changed to "My_IP_here" and "secret123" respectively. The proxy's located behind NAT - can it be the reason?

This is quite weird, it seems that telegram aborts connection at the very beginning when proxy sends predefined request. Can you please check if you have connectivity to telegram hosts from these nodes (curl https://core.telegram.org/getProxyConfig and try to access host/port pairs from the response). If the issue still exists, I would like to ask you to run mtg without docker (if you run docker) with debug mode.

@snetesa do you have any news?


Slim lut

Ready to go now, depends on #9 and #6 .
This reduces memory usage, when running on a CPB from .py (not .mpy) by 1328 bytes, so that's something :) I also have a bunch of docs improvements in here too.

Specifically here's the error on the cpb:
code.py output:
Traceback (most recent call last):
  File "code.py", line 17, in <module>
  File "/lib/adafruit_emc2101_new/emc2101_lut.py", line 81, in __setitem__
  File "/lib/adafruit_emc2101_new/emc2101_lut.py", line 134, in _set_lut
  File "adafruit_register/i2c_struct.py", line 48, in __set__
  File "adafruit_register/i2c_struct.py", line 48, in __set__
  File "adafruit_bus_device/i2c_device.py", line 84, in write
OSError: [Errno 5] Input/output error

Turns out this chip only likes 1-byte reads and writes. Ready for review.


feat: dynamic file imports

closes https://github.com/denoland/fresh/issues/1405
supersedes https://github.com/denoland/fresh/pull/1893
Trying this one again, since it seems pretty cool. Sadly there seems to be an issue with tests/fixture_layouts on my computer. I'm getting sporadic errors like this:
deno run -A main.ts
error: Top-level await promise never resolved
    "./routes/dynamic/[tenant]/index.tsx": await import(
                                           ^
    at <anonymous> (file:///Users/reed/code/denoland/fresh/tests/fixture_layouts/fresh.gen.ts:26:44)

But changing the deno runtime via deno upgrade causes it to go away before returning. Sometimes clearing the cache also seems to help.

It's interesting that island in dynamic route test => ./tests/layouts_test.ts:163:6 consistently fails on windows and mac, and seems to be passing on linux.

@iuioiua, perhaps you want to close your old one and we can go from here? This time I've hit all the manifests via deno task manifests (which I don't think existed when you last tried this).

When I'm in fresh/tests/fixture_layouts and run deno run -A main.ts it always fails with:
error: Top-level await promise never resolved
    "./routes/dynamic/[tenant]/index.tsx": await import(
                                           ^
    at <anonymous> (file:///Users/reed/code/denoland/fresh/tests/fixture_layouts/fresh.gen.ts:26:44)

but when I run deno run -A dev.ts it always starts just fine.

Observation: when the ./routes/dynamic/[tenant]/index.tsx route is moved to be the first entry within the manifest.routes object, this issue does not occur. It seems we're encountering some race condition.


feat:

Feature Request
Describe the Feature Request

Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[x] Yes
[ ] No

Feature Request
Describe the Feature Request

Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[x] Yes
[ ] No


Import - items from external tools still have checkbox, show up when "hide items with no changes" is selected

During import, there is a non-selectable checkbox appearing for items originating from external tools. We should probably remove these checkboxes.
Additionally, these items show up when the "hide items with no changes" toggle is selected. These should get hidden.

Confirmed.
Unchecked:

Checked:


Pull conn.sendName(...) logic out of NewConnection()

Timeout for 1st round is 15 seconds. This change allows bots written in
go to take advantage of that extra time.

@Sydriax @truell20 Ready for your review.

This changes the public facing api for the go developer package. As it takes the name param out of the NewConnection method.

lgtm

One other thing to note if you're looking to take advantage of the 15 second startup time with a Go bot. Currently Go bots do not get compiled ahead of time but instead are compiled during the startup time at the beginning of each game with a go run MyBot.go command.
So you might want to look at getting the correct commands into compiler.py to compile the bot ahead of time.

^ This is true.

Relevant code section is here: https://github.com/HaliteChallenge/Halite/blob/master/worker/compiler.py#L334

Thanks guys!


Package maintenance

Landed in https://github.com/metarhia/metawatch/commit/928b8500a212b16749aacf1a717e61f6ae3fa0a4, https://github.com/metarhia/metawatch/commit/d390846b33a1df61bf52746eed317f876f6dda15, and https://github.com/metarhia/metawatch/commit/c140c61315a6d4b9c8b75228ecd08b870d369b6d


nose and coverage should probably be test_requires

Hi,
I noticed that nose and coverage were listed in the set of install_requires, should they actually be tests_require? as they're only needed when running the unittest?
Perhaps something like this:
--- a/setup.py
+++ b/setup.py
@@ -27,5 +27,6 @@
         packages=find_packages(exclude="tests"),
         include_package_data=True,
         zip_safe=False,
-        install_requires=['vobject', 'lxml', 'nose', 'coverage', 'requests', 'six'],
+        install_requires=['vobject', 'lxml', 'requests', 'six'],
+        tests_require=['nose', 'coverage']
     )

(apparently the actual setup() attribute is tests_require)
https://setuptools.readthedocs.io/en/latest/setuptools.html?highlight=tests_require
tests_require
If your project’s tests need one or more additional packages besides those needed to install it, you can use this option to specify them. It should be a string or list of strings specifying what other distributions need to be present for the package’s tests to run. When you run the test command, setuptools will attempt to obtain these (even going so far as to download them using EasyInstall). Note that these required projects will not be installed on the system where the tests are run, but only downloaded to the project’s setup directory if they’re not already installed locally.

Thanks.

You're welcome.


[BUG] Error fetching contributors data

Description of the bug

Please assign me this issue.
Please add screenshots (if applicable)
No response
Add any other context about the problem here
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Varghab are you still facing this issue?


kpt fn eval swallow functionConfig in output

To reproduce:
kpt fn eval -o stdout -i gcr.io/kpt-fn/set-labels:v0.1.5 --fn-config /path/to/fn/config.yaml

Got:
apiVersion: config.kubernetes.io/v1
kind: ResourceList
items:
  ...

Expected:
apiVersion: config.kubernetes.io/v1
kind: ResourceList
items:
  ...
functionConfig:
  ...

This issue exists in the latest kpt release (beta16).

was it there at the beginning? i tried checking out old releases but it seems it's not in the output as well (using --include-meta-resources). i just want to see how it was before.

To reply to @tuananh
Just to clarify Mengqi's previous comment. The issue exists at the beginning and is not fixed yet (current 1.0.0-beta.24).
As a comparison, kpt fn source gives the right output with the functionConfig content shown in a dedicated functionConfig field.


Extract userinfo into one var for InsertDataJdbc#insertIntoRequestAcl

Minimize amount of requests to database

in theory there should not be any functional issue with that since it is only read operation
2 same read operations should return same value


Better rule-based comments for too-wide table

The feedback should specify the index or column labels that are too long

Commit: 03dc2ff4874463f42343f68b47f26ab508cce804


undefined data type in PostProcess method

the undefined data type are located at wiki/Writing custom shaders

Thanks. Fixed

Fixed. Thanks!


Benchmark Suite and Automated PR Regression Testing.

Motivation and Context
Why is this change required? What problem does it solve?:
Added benchmark suite to main repo, added github actions to test for regressions.
Description
Describe your changes in detail:
Results will still be kept in https://github.com/tensorwerk/hangar-benchmarks, and the suite itself must be kept in sync with the main copy here. This repo also serves webview at https://tensorwerk.com/hangar-benchmarks.
Need to add documentation on how to run locally before this merges (will also increase scope of tests).
Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Documentation update
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

[ ] Ready for review
[x] Work in progress

How Has This Been Tested?
Put an x in the boxes that apply:

[x] Current tests cover modifications made
[x] New tests have been added to the test suite
[ ] Modifications were made to existing tests to support these changes
[ ] Tests may be needed, but they are not included when the PR was proposed
[ ] I don't know. Help!

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have signed (or will sign when prompted) the tensorwork CLA.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

closing because to enable a workflow the PR needs to be made from a branch in the repo


Crash when hiding a panel from a NOTIFICATION_MOUSE_ENTER notification

Godot version
v4.2.rc.custom_build [702227129]
System information
Godot v4.2.rc (702227129) - Debian GNU/Linux trixie/sid trixie - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (nvidia) - AMD Ryzen 5 1600 Six-Core Processor (12 Threads)
Issue description
Found a consistent crash when calling hide() from _notification().
It does not happen if the call is deferred.
Steps to reproduce
The hide_test.gd script has a boolean cause_crash. If it is true, hovering the mouse over the label crashes without an error in the Godot Editor Console. If it's false it hides the label as expected.
Minimal reproduction project
hide_crash.zip

I confirm the crash, and it's a regression in 4.2.
Up to 4.2-dev2 included, the MRP works fine, like in 4.1.3-stable.
From 4.2-dev3 to 4.2-beta5, the MRP doesn't crash, but the label isn't hidden. The NOTIFICATION_MOUSE_ENTER isn't received on enter.
From 4.2-beta6 onward, it's crashing as described in the OP, with this backtrace:
================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.2.rc.custom_build (bb63963486a389d4417ba13249a40219f3774df0)
Dumping the backtrace. Please include this when reporting the bug to the project developer.

-- END OF BACKTRACE --
================================================================

The regression timings are consistent with this being a consequence of #67791 (which regressed on the signal emission) and #84547 (which fixed the regression, but now we get a crash instead).
CC @Sauermann @kitbdev

A related crash can still happen on mouse exit when hiding a grandparent.
Here's an MRP:
hide_crash2.zip
In this case an index goes out of bounds in Viewport::_drop_mouse_over() line 3273 .
ERROR: FATAL: Index p_index = 0 is out of bounds (count = 0).
   at: LocalVector<class Control *,unsigned int,0,0>::operator [] (C:\Projects\godotsrc\godot\core/templates/local_vector.h:161)
C:\Projects\godotsrc\godot\core/templates/local_vector.h:161 - FATAL: Index p_index = 0 is out of bounds (count = 0).

We should either have a flag to prevent _drop_mouse_over from being called within itself or we can check if the gui.mouse_over_hierarchy has a different size than expected and we can return out.
It's also possible it happens in Viewport::_gui_update_mouse_over() line 2517 so we should check that loop as well.
Also Mouse enter and exit notifications may trigger strangely if hide() is called from them.

Here is an updated mrp that shows the crash happening in Viewport::_gui_update_mouse_over() using set mouse filter.
filter_crash.zip
Run filter_crash.tscn, move the mouse over the panel and hit space. Make sure to not mouse over the top left corner, some invisible Controls are there. Also make sure not to mouse exit the panel before hitting space.
Hitting space will change the panels filter from pass to stop, which sends mouse exit notifications to its parents.
When the panel's parent receives mouse exit, it modifies the mouse over hierarchy by setting another Control's mouse filter to ignore.
Changing the mouse over hierarchy like this during an exit notification causes index out of bounds.
Setting top_level to true instead of changing the mouse filter will also trigger the crash, since they use the same code.
BTW, This won't happen for mouse enter notification because a list of Controls is used instead of a list of indexes, so it can't go out of bounds.


Update to version 0.7.0

MNT: Re-rendered with conda-build 3.21.9, conda-smithy 3.21.0, and conda-forge-pinning 2<IP_ADDRESS>.35.29

Checklist

[x] Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Thank you. It is preferred to rely on the PyPi source package whenever possible. It also allows the conda-forge bot to automatically detect any new versions.
Do you mind asking the @cmacmackin if he can upload that to pypi?
Also ping @conda-forge/help-python: is that ok to merge or do we want to wait for the pypi package?

The bot can detect updates from GH and PyPI without much difference. However, the bot is down at the moment, so the new PyPI release is not detected.

Ok thanks


Publish to live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

README.md
:white_check_mark:Succeeded

docs/design/using-office-ui-fabric-react.md
:white_check_mark:Succeeded

docs/develop/add-ins-with-angular2.md
:white_check_mark:Succeeded

docs/develop/convert-javascript-to-typescript.md
:white_check_mark:Succeeded

docs/develop/create-and-debug-office-add-ins-in-visual-studio.md
:white_check_mark:Succeeded

docs/develop/develop-office-add-ins-for-the-ipad.md
:white_check_mark:Succeeded

docs/develop/get-javascript-intellisense-in-visual-studio.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-get-started-angular.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-get-started-jquery.md
:white_check_mark:Succeeded

docs/excel/excel-add-ins-get-started-react.md
:white_check_mark:Succeeded

docs/images/excel-quickstart-addin-2b.png
:white_check_mark:Succeeded

docs/images/powerpoint_quickstart_addin_1b.png
:white_check_mark:Succeeded

docs/images/powerpoint_quickstart_addin_2b.png
:white_check_mark:Succeeded

docs/images/powerpoint_quickstart_addin_3b.png
:white_check_mark:Succeeded

docs/images/word-quickstart-addin-1.png
:white_check_mark:Succeeded

docs/images/word-quickstart-addin-1b.png
:white_check_mark:Succeeded

docs/images/word-quickstart-addin-2.png
:white_check_mark:Succeeded

docs/images/yo-office-onenote-jquery.png
:white_check_mark:Succeeded

docs/images/yo-office-word-jquery.png
:white_check_mark:Succeeded

docs/includes/file-get-started-excel-jquery.md
:white_check_mark:Succeeded

docs/includes/file-get-started-excel-react.md
:white_check_mark:Succeeded

docs/includes/file-get-started-onenote.md
:white_check_mark:Succeeded

docs/includes/file-get-started-powerpoint.md
:white_check_mark:Succeeded

docs/includes/file-get-started-project.md
:white_check_mark:Succeeded

docs/includes/file-get-started-word.md
:white_check_mark:Succeeded

docs/includes/file-get-the-whole-document-from-an-add-in-for-powerpoint-or-word.md
:white_check_mark:Succeeded

docs/includes/quickstart-yo-start-server.md
:white_check_mark:Succeeded

docs/index.yml
:white_check_mark:Succeeded

docs/onenote/onenote-add-ins-getting-started.md
:white_check_mark:Succeeded

docs/overview/office-add-ins.md
:white_check_mark:Succeeded

docs/powerpoint/powerpoint-add-ins-get-started.md
:white_check_mark:Succeeded

docs/project/project-add-ins-get-started.md
:white_check_mark:Succeeded

docs/quickstarts/excel-quickstart-angular.md
:white_check_mark:Succeeded

docs/quickstarts/excel-quickstart-jquery.md
:white_check_mark:Succeeded

docs/quickstarts/excel-quickstart-react.md
:white_check_mark:Succeeded

docs/quickstarts/onenote-quickstart.md
:white_check_mark:Succeeded

docs/quickstarts/powerpoint-quickstart.md
:white_check_mark:Succeeded

docs/quickstarts/project-quickstart.md
:white_check_mark:Succeeded

docs/quickstarts/word-quickstart.md
:white_check_mark:Succeeded

docs/testing/attach-debugger-from-task-pane.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/create-an-office-add-in-using-any-editor.md
:white_check_mark:Succeeded

docs/word/word-add-ins-programming-overview.md
:white_check_mark:Succeeded

docs/word/word-add-ins.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feat line geometry

Checklist

[x] npm test passes
[x] feat geometry, factory, element
[x] commit message follows commit guidelines

Description of change

Pull Request Test Coverage Report for Build 956464967

174 of 205 (84.88%)  changed or added relevant lines in 10 files are covered.
122 unchanged lines in 7 files lost coverage.
Overall coverage increased (+7.3%) to 61.361%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/util/attribute.ts
2
3
66.67%

src/geometry/element.ts
17
27
62.96%

src/geometry/geometry.ts
114
134
85.07%

Files with Coverage Reduction
New Missed Lines
%

src/geometry/element.ts
1
65.96%

src/geometry/factory.ts
1
51.85%

src/types/geometry.ts
1
0%

src/util/coordinate.ts
1
60.0%

src/util/attribute.ts
2
60.0%

src/geometry/geometry.ts
41
72.62%

src/util/path.ts
75
4.76%

Totals

Change from base Build 920609553:
7.3%

Covered Lines:
891

Relevant Lines:
1362

💛  - Coveralls

@pearmini 一些问题：

scale 单侧不通过，因为时区问题
ScaleDef 构造参数（第一个参数是 field）
ScalePool 的单测（单测体现出不同 scale 的创建、销毁、同步，便于后面在集成 ScalePool 的时候出现理解二义）


Add in-game chatlog output for TB actions that are not readily apparent to the user

Is your feature request related to a problem? Please describe.
Users may not always know when/if they have toggled a setting, or if pressing a button took effect:
Murder Hobo
Lobotomize Enemies
Reroll Perception
Set Perception 40
etc
It's possible to bump a key or forget if you had something toggled on or off, or just be unsure if pressing the button "did the thing".
Describe the solution you'd like
I think a simple message in the in-game chatlog would be more than adequate to make it easily visible to users the result of actions they take with keybinds, or just provide some peace of mind that the button did indeed do what they expected.
Describe alternatives you've considered
Alternative is just to open TB and check to see what state something is in. Though for reroll perception and similar you'd just press it again 'just to be safe' and assume it's working as intended.
Additional context
Seemed like a nice little QoL thing but not something that'd be worth investing a lot of energy into if for some reason it turned out to be a PITA :)

Implemented in 1.5.0


Html tag option

html tag option, to decide between using span or i

What are the issues with using span?

I'll check locally, since we're using material design icons, all the examples uses i but i'll check if default styles really uses it.

we're migrating from 1.5.4 to the latest version so keeping i was easier during migration :)

i cleaned up our css to not use i . i'll close this pull request :)


Is there any reason why the fields are not fully included in graph_models attributes?

I'm trying to make a custom theme for the graph_models command, and the data available is very limited.
Is there a reason why this is so limited (https://github.com/django-extensions/django-extensions/blob/master/django_extensions/management/modelviz.py#L133-L141)?
Why would you think about adding the field itself (something like that https://github.com/Gagaro/django-extensions/commit/cb62f43fe81bcc377d5c3e25af437d00fe84533f)?
Thanks

I don't think there is a particular reason :-)
It's a bit messy (in the code) but I don't seen any reason from the top of my head not to include it.
Basically this gives you more information to work with during templating the dot file right ?
I would say make a PR for it :-)

Basically this gives you more information to work with during templating the dot file right ?
Yes that's exactly that.

I would say make a PR for it :-)
Will do, thanks for the fast reply.


PMT: Fix case mismatch issue with elevate onboarding config

Updates the case of the elevate config to match what we are actually receiving from the system
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

**lurch attach: W-041519


Javascript references fail in Cognito

module '../../node_modules/buffer/index.js' does not provide an export named 'Buffer'
However - 1) it does appear 2) when export is moved to the function vs. the alias at the top it is recognized  3) Other libraries follow similar and looser syntax that fixing this one instance leads to finding similar import issues in other instances
Steps to Reproduce
Example:  Using polymer startup kit anywhere, add:  import {Buffer} from 'buffer'

Note:  One of the following AWS modules likely added the reference when adding to npm:  amazon-cognito-identity-js or amazon-cognito-auth-js

Call it from somewhere on load ( a reducer in my case ):  Buffer.isBuffer({})
During the load it will fail with the message mentioned above.  If you change the style of the import and move it to the function it works.  Though I manually fixed this instance, then I got another export error for a different library.  Is there a way to enable Polymer to enable recognizing this other style on libraries that are imported/ not written by the project?
Expected Results
No error is thrown
Actual Results
Error thrown in the console while trying to access -->  module '../../node_modules/buffer/index.js' does not provide an export named 'Buffer'
Browsers Affected

[ X] Chrome  (only testing here)
[ ] Firefox
[ ] Edge
[ ] Safari 11
[ ] Safari 10
[ ] IE 11

Versions
:~/localdev/nodespace/ui$ npm polymer -version
3.5.2

To clarify, above reproduce is a simpler way to reproduce.  The way I discovered was not trying to use the library directly but using AWS Cognito libraries like this:          new CognitoUserAttribute(dataEmail);
which in turn refer to the Buffer library that fails

Are you building your application with webpack?  The AWS Javascript Library uses ES6 imports and the Buffer library uses older module exports.