[Feature Request]: BIP351 Private Payments Support

Private Payments (BIP351) is a stealth address system for Bitcoin that allows the user to post a static code and receive payments to a separate address space for each sender.
There are multiple use cases for Private Payments, but the static donation code seems to be the most compelling. A user wishing so solicit donations from the public may safely associate a payment code with her identity and receive funds in a relatively private manner.
The user story is similar to BIP47:

Receiver posts their payment code
Sender creates a notification payload and either posts it to the chain as an OP_RETURN or to some other bulletin board system
Receiver scans the chain for these notification payloads and upon finding one, generates the chain of stealth addresses

Improvements over BIP47:

Supports multiple address types
Better notification payload privacy
Smaller notification payloads

For more context, check out privatepayments.org and the Rust reference implementation.
This would not replace the existing BIP47 support, as the protocols are not mutually exclusive.

Private payments (BIP351) is not light client compatible, and therefore not a good fit for Sparrow or any other light client wallet (which is essentially all except for full node implementations like Bitcoin Core). The same problem is shared by Silent Payments, and IMO not sufficiently discussed as a disadvantage when compared to BIP47 in either proposal.
The workaround described in Appendix B (Potential OP_RETURN services) is not available in any sufficiently decentralised form to be a workable alternative, and in addition adds further complication for the user, requiring a UI for configuring these services, considering privacy etc.
For these reasons I don't think this approach is currently a practical alternative to BIP47, so I'm closing this off for now.

I've opened a related issue in ElectrumX to support an OP_RETURN index, which would enable more light client support.


feat(bb): working msan preset

This creates a working memory sanitizer preset, but woe be to those who try and use it outside of this docker script, as it requires very fiddly building of LLVM.
Shoutout to this json_struct project for the magic incantations: https://github.com/jorgen/json_struct/blob/89ca33179790d1e82ecb95092cd469f96c3ff06e/docker/ubuntu22.04/Dockerfile#L23 (bullish on searching github for dockerfiles)
To use:
./scripts/docker_interactive.sh msan.ubuntu
After initial setup, this will run instantly, and you will be in a setup with LLVM MSAN set up. Only then will:
cmake --preset msan && cmake --build --preset msan will work.
Currently not everything builds, and some stuff uncovers issues, but I will decouple that.

Nice. LGTM.

Benchmark results
Metrics with a significant change:

note_successful_decrypting_time_in_ms (8): 314 (-27%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit e63f0226 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,956
181,604
724,196

l1_rollup_calldata_gas
227,120
888,548
3,535,676

l1_rollup_execution_gas
320,311
1,006,996
3,756,054

l2_block_processing_time_in_ms
1,195
4,500 (+1%)
17,680

note_successful_decrypting_time_in_ms
:warning: 314 (-27%)
977
3,627

note_trial_decrypting_time_in_ms
26.8 (-36%)
114 (+9%)
167 (-5%)

l2_block_building_time_in_ms
18,253
72,190
289,561

l2_block_rollup_simulation_time_in_ms
13,506
53,392
214,790

l2_block_public_tx_process_time_in_ms
4,721 (+1%)
18,720 (+1%)
74,515 (+1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
15,305 (-4%)
29,761 (-2%)

note_history_successful_decrypting_time_in_ms
2,527 (+10%)
4,737 (+2%)

note_history_trial_decrypting_time_in_ms
101 (+15%)
211 (-15%)

node_database_size_in_bytes
17,301,584
33,198,160

pxe_database_size_in_bytes
29,923
59,478

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
328
44,568
25,313

private-kernel-ordering
196
43,633
16,193

base-rollup
1,455
129,774
933

root-rollup
83.4 (+1%)
4,192
729

private-kernel-inner
431 (-1%)
70,859
25,313

public-kernel-private-input
243 (+1%)
33,703
26,945

public-kernel-non-first-iteration
242 (+2%)
33,745
26,945

merge-rollup
7.81
2,712
933

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
2 leaves
8 leaves
16 leaves
32 leaves
128 leaves
64 leaves
512 leaves
1024 leaves
2048 leaves
8192 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.3 (-1%)
11.2 (+1%)
13.4 (+5%)
16.8 (-3%)
23.1 (+1%)
63.6 (-1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.9
17.5
23.0
31.6
47.0
143
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.595 (-1%)
0.620 (+1%)
0.569 (+5%)
0.518 (-3%)
0.481 (+1%)
0.439 (-1%)
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
N/A
N/A
N/A
75.1 (-1%)
47.8 (-1%)
244 (+2%)
462 (-1%)
917 (+2%)
3,533 (-1%)

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
N/A
N/A
N/A
159
96.0
543
1,055
2,079
8,223

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.463 (-1%)
0.490 (-1%)
0.446 (+2%)
0.431 (-2%)
0.435 (+2%)
0.426

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
N/A
N/A
N/A
105 (+1%)
56.9
351 (-1%)
692 (-1%)
1,367
5,422

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
N/A
N/A
N/A
197
104
691
1,363
2,707
10,771

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
0.497 (+1%)
0.497
0.474 (-1%)
0.473 (-1%)
0.473
0.471

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
57.0
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
94.1
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
0.578
N/A
N/A
N/A
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
16,859
35,536

Transaction processing duration by data writes.

Metric
0 new commitments
1 new commitments

tx_pxe_processing_time_ms
627 (+13%)
1,448 (+1%)

Metric
0 public data writes
1 public data writes

tx_sequencer_processing_time_ms
0.521 (+3%)
582 (+1%)


zabbix.agent2: create a symlink which is compatible with the zabbixAg…

…ent module

Motivation for this change
After updating to 21.05 I noticed there was an issue with the zabbix.agent2 package when combined with our services.zabbixAgent module.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 125266 at 99e37419 run on x86_64-linux 1

1 package built successfully:

zabbix.agent2 (zabbix50.agent2)

2 suggestions:

warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild.
Near pkgs/development/go-modules/generic/default.nix:145:5:
    |
145 |     buildPhase = args.buildPhase or ''
    |     ^

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/development/go-modules/generic/default.nix:220:5:
    |
220 |     installPhase = args.installPhase or ''
    |     ^


Added Mouse Scrolling/Keyboard Implementation

Added Keyboard/Mouse hook to server's RDP form to access mouse data (scroll wheel) and implemented keyboard handling

Only thing left to do for keyboard handling is forwarding ALT and Windows key presses to client by setting hotkeys, setting an image for the btnKeyboard (I don't have the images), registering and unregistering hotkeys when form is in focus/loses focus

You mean, when pressing the windows key or alt, it's processed on both computers, but we only need it on the client. So we are registering an hotkey for it in the Server Remote Desktop Window, right?

@MaxXor, Basically, the form needs to be in focus to send input to the client machine, so if you want to send for example Windows key + R to open a run dialog, we don't want our start menu to come up on the host machine so it will only send it to the client.  Alt + tab as well :D.  I've found a better way other than registering the hotkey.    I will send another pull request when I've cleaned up a bit :)

@d3agle Okay, I understand. Hehe thanks man!


[SUBS] Add support for more export types

Problem

Right now we only support "visit hosted URL" at the end of the checkout flow
We should also support a simple option to export a simple button (pay with Superfluid)
This button should be provided as copyable & editable code

Design
TBD

Should we add the "Export payment button" as a separate option?


Plugin Not Showing Up

Export Layers shows up in GIMP 2.8, running python 2.7.2.
Then I installed GIMP 2.10, export layers didn't show and the python functionality wasn't working (python-fu console didn't open)
Changed to samj's portable 2.10, and python functionality returned but export layers still didn't show up on the file menu, plugin explorer etc. I know the files ('export_layers.py' and folder 'export_layers') are in the correct directory, python is operational and I am running the latest version:
What is the problem???
Version of Export Layers: 3.1
Version of GIMP:  both regular 2.10 and samj 2.10
Operating system: Windows 10, 64 bit

I found out you can make the plug-in work by moving the export_layers folder to [GIMP installation folder]\lib\python2.7\site-packages. This works for both the regular and the portable version.
For some reason, the Windows installer for 2.10 on the official GIMP page was modified not long ago, relocating the path to Python within GIMP.
The reason why the plug-in no longer works is because the export_layers.py file assumes that export_layers subdirectory is are the same directory. This may be the reason why also the Python-Fu console does not show up.
Regardless, I am going to fix this for the next release, but in the meantime, you can use the workaround mentioned above.

Great, thanks for the help!
It's working fine now.

In Windows 8.1 , I'm not even able to find the export_layers folder to do this work around.
Filter effects to not apply after it shows modifying progress.

@WilsonBradley What version of Export Layers are you using?
What directory was the plug-in installed in? Is it one of the listed directories in the GIMP menu "Edit → Preferences → Folders → Plug-Ins"? If so, check the log files in the directory - error.log or export_layers_error.log. If they are not empty, paste their contents here so I could pin down the problem (hopefully).

I could only get it to run if I disabled my virus scanner. I use Comodo.

Closing this due to the issue being stale.


Chore: remove unused run code & hard code sleep

Sleep is there only for debug purposes, which I will be solving separately this week.

Do you want me to wait to make a JS equivalent PR?

Do you want me to wait to make a JS equivalent PR?

Yessir; just note that the UI will need a fallback for 1 day, if the DEBUG code is removed from the JS-SDK.

@kenrick Note that we will need to gracefully handle a fallback. Do we have any thoughts on a general verbiage for it?


Spacing around trace ID in nova footer is uneven

Trace ID got removed with 4.x upgrade. Needs to be re-added.

Trace ID has not been super useful on the member UI so I don't think we need to put it back in Nova. There are other ways to grab it if needed.


about mounting efivars

This is more of a question than a bug, hopefully.
I'm trying to understand why, on my laptop runnig void linux, with booster as initram generator, I get
$ mount | grep efi
efivarfs on /sys/firmware/efi/efivars type efivarfs (rw,nosuid,nodev,noexec,relatime)

even though I do not mount efivars anywhere that I'm aware of, not in /etc/fstab,
and the init (runit) only mounts /sys, see https://github.com/void-linux/void-runit/blob/master/core-services/00-pseudofs.sh
mountpoint -q /sys || mount -o nosuid,noexec,nodev -t sysfs sys /sys
but not efivars (there's actually a PR there to do just this in void).
Could booster be affecting any of this?
The laptop is a thinkpad, and I also wonder whether Lenovo's uefi implementation has any role here,
since on another Dell machine with quite similar setup efivars are not mounted.
Thanks.

It is indeed the result of booster bootup.
It mount a number of fs - /run /dev /proc /sys and then moves it userspace.  It also mounts efivarfs just in case it is needed for partition autodiscovery, but it never unmounts it.
I am fine to unmount it in case it is not desirable to have it in user-space.

Thanks, afaik it seems fine.
Is it correct that runit then picks up efivarfs when it mounts /sys?

I guess the other machine, still running older booster-0.5_1, does not have efivars mounted as this feature was introduced later on in booster?

Thanks for the prompt response.
I now understand how this works, and it seems totally fine to me.


flowchart has FETCH, but should use ENDFETCH

https://seedlink.readthedocs.io/en/draft/protocol.html#handshaking-flowchart
In dial-up mode, change FETCH to DATA and END to ENDFETCH

Fixed.
Also changed "GETCAPABILITIES" to "INFO CAPABILITIES" as suggested in #14.

+1 on proposed change.


chore: add cleanup CI for staled image

AsIs
Since we have not implemented CI to clean up old image, the consumptions of storage will be increased with every time we update container image.
ToDo

[x] add scheduled CI for clean up image in GHCR

(Optional) Acceptance criteria
Confirm image have been cleared.
(Optional) Additional contexts
Issue(s): #41

Confirmed that all the revisions have been removed except latest 3 images, which had defined by keep-at-least inputs of Cleanup CI.


remove jakarta annotation api dependency

Signed-off-by: Bogdan Sava<EMAIL_ADDRESS>Description
The dependency is used only for @PostConstruct annotation, while we are using initialisation bean anyway.

Good news if we can remove it. Better than updating


Material Theme Builder does not work with Figma Free plans

Dark modes fail to update on Figma free plans

I did not know it was linked to the free plan but I think I am experiencing the same thing. I cloned the MD3 kit figma file and tried to run the plugin in it. It did not change the dark palette at all

We've kept generation of styles on in order to keep working with the free plan.


Extend and organize testing modules for node tests

[ ] Create tests for:

[ ] packages/addons
[ ] packages/bower
[ ] utils/messaging
[ ] files

[ ] Simplify code between packages


Ability to auto rotate drive while controlling translation via joystick

Currently the drive has ability to auto rotate to a defined position and to hold its last heading automatically.
As a next step we want the ability to auto rotate while the driver continues to control the XY translation via the joysticks

#9

Made some further changes (commit f77eaf149e65e1aa5e9b5c5a9d1a8ed3719994f5)


Helper e() not behaving properly

e() calls this:
return htmlentities($value, ENT_QUOTES, 'UTF-8', false);
I think 4th argument should be TRUE (which is the default for htmlentities)
Currently with false: < is shown as <
With true: < displays as <
Can someone please inform if I am missing the reason why it is set to false?
Is it preference?
I noticed Facebook chat displays < displays as <
but GitHub displays < is shown as <

<

It's just a preference. Feel free to use a different function if you would like. Feel free to discuss on forums/slack.

It should definitely be TRUE. Unfortunately other packages use this function, which breaks normal HTML.
@AdamEsterle Github uses Markdown, which supports HTML, so < is correctly displayed as <. For a function that encodes HTML, this is definitely wrong. If this option is neccesary, there's double encoding in other places. Ths is just lazy.


Reference(s) for the Autoencoder implementation

Hi,
All (or most) of the algorithms have reference papers associated with them. Can you provide some references for the AutoEncoder implementation?
Thank you for creating such a cool library!

Glad you find it useful! The AutoEncoder was an experiment that @sergeyf and I cooked up at NIPS last year and I don't think it's ever been that successful. I'm considering getting rid of it to lighten the dependencies. Thoughts?

I vote for ditching it. Neural networks are too fragile.

Cool, on it!

What about the MatrixFactorization with DownHill? It's pretty slow, not sure if it's useful.

Yeah, good question. There are probably good alternatives for this out there? It's just SVD with SGD, right?

BTW, the latest master of scikit-learn has linear models that can produce posteriors, but we can't require that until the next version actually comes out. Then the code will be even cleaner

Awesome. That was your addition, right?
If we are happy with just a few imputation methods, we could probably just
move everything over to sklearn.
On Fri, Feb 10, 2017 at 7:04 PM, Sergey Feldman<EMAIL_ADDRESS>wrote:

BTW, the latest master of scikit-learn has linear models that can produce
posteriors, but we can't require that until the next version actually comes
out. Then the code will be even cleaner
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/hammerlab/fancyimpute/issues/23#issuecomment-279099909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAC9OdLYJOi8eEeGqX2Tygzy4rwody8Nks5rbPsjgaJpZM4L1AkI
.

Yes that was me.
That's probably best for "society". I was a little daunted by all the style and documentation requirements. Other than that I already have a pull request of basic MICE for sklearn ready, but have been putting off finishing it.

I'm using the MatrixFactorization with Downhill and find it to be the best (among the methods implemented in fancyimpute) for some applications, but perhaps faster options are available elsewhere? The stochastic optimization algorithm seems a bit overkill for my use and I would rather have faster convergence.


Collect log to diagnose CVMFS issues

Is your feature request related to a problem? Please describe.
CVMFS allows to collect information when something goes wrong:
attr -g logbuffer /cvmfs/<repo>|tail -50

This can collect info on what went wrong. To run after the Glidein tests if they failed, and after the job if it failed because of CVMFS
Describe the solution you'd like
This would allow us to collect logs. Glideins could send them to the Factory for troubleshooting
Describe alternatives you've considered
NA
Info (please complete the following information):

Priority: medium
Stakeholders:
Components: glidein

Additional context
Dave suggested this. Fermilab will add it to the Jobsub wrapper

Regarding the additional context: this is the (currently open) PR in the jobsub project to collect CVMFS logs: https://github.com/fermitools/jobsub_lite/pull/489


DefaultsError: warnings is not a supported option

Operating System: Mac OS
Node Version: 10.15.0
NPM Version: 6.4.1
webpack Version: 4.30.0
uglifyjs-webpack-plugin Version: 2.1.2

Expected Behavior
webpack can build the js correctly
Actual Behavior
report a error:
DefaultsError: warnings is not a supported option
at DefaultsError.get (eval at  (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglify-js@3.5.10@uglify-js/tools/node.js:20:1), :71:23)
at Function.buildError (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/index.js:103:54)
at results.forEach (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/index.js:256:52)
at Array.forEach ()
at taskRunner.run (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/index.js:231:17)
at step (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/TaskRunner.js:83:9)
at done (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/TaskRunner.js:94:30)
at boundWorkers (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/TaskRunner.js:99:13)
at TaskRunner.boundWorkers (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/TaskRunner.js:68:11)
at enqueue (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/TaskRunner.js:89:14)
at tasks.forEach (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/TaskRunner.js:109:9)
at Array.forEach ()
at TaskRunner.run (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/TaskRunner.js:87:11)
at UglifyJsPlugin.optimizeFn (/Users/zxa/IdeaProjects/lzdtp/node_modules/_uglifyjs-webpack-plugin@2.1.2@uglifyjs-webpack-plugin/dist/index.js:225:18)
at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/zxa/IdeaProjects/lzdtp/node_modules/_tapable@1.1.3@tapable/lib/HookCodeFactory.js:33:10), :21:1)
at AsyncSeriesHook.lazyCompileHook (/Users/zxa/IdeaProjects/lzdtp/node_modules/_tapable@1.1.3@tapable/lib/Hook.js:154:20)
Code
  // webpack.config.js
 optimization: {
    minimizer: [
      new UglifyJsPlugin({
        uglifyOptions: {
          compress: {
            warnings: false
          },
        },
        sourceMap: true
      }),
      new OptimizeCSSPlugin({
        cssProcessorOptions: {
          safe: true
        }
      })
    ],

Description

about 20 days ago, all things are right. today when I update my local node_modules, the error happened! I find the warning option is ok in the uglifyjs document. But now it doesn't work. I think some update on the webpack or some module lead to this error.

compress option doesn't consist of warning option in fact. But I don't know why it could pass build before.

Some package released new version a few day, I still haven't found which one is

FWIW, i've seen this issue when using the terser-webpack-plugin - reverting it appears to be the winner for me.

compress option doesn't consist of warning option in fact. But I don't know why it could pass build before

hello！ Have you solved the problem？

Hi I am also facing this error in my source recently.
one week before it works fine.
In local it is working fine  -<EMAIL_ADDRESS>But while running in jenkins it throws below error:

ERROR in vendors.bundle.js from UglifyJs
DefaultsError: warnings is not a supported option
at DefaultsError.get (eval at  (/jenkins/workspace/grid-angular-samples_master-KGZGHS6RTY6XLQXUQWQ55ECXCFTEAMXT7SLUT7R6DKIUWVH6ZW4Q/node_modules/uglifyjs-webpack-plugin/node_modules/uglify-js/tools/node.js:20:1), :71:23)
at Function.buildError (/jenkins/workspace/grid-angular-samples_master-KGZGHS6RTY6XLQXUQWQ55ECXCFTEAMXT7SLUT7R6DKIUWVH6ZW4Q/node_modules/uglifyjs-webpack-plugin/dist/index.js:103:54)
at results.forEach (/jenkins/workspace/grid-angular-samples_master-KGZGHS6RTY6XLQXUQWQ55ECXCFTEAMXT7SLUT7R6DKIUWVH6ZW4Q/node_modules/uglifyjs-webpack-plugin/dist/index.js:256:52)
at Array.forEach ()

PLease provide any solution for me, this breaks my app

THis not a problem with uglifyjs plugin, due to webpack-cli latest update this issue occurs
https://github.com/webpack/webpack-cli/issues/881

hi, @kejiacheng , @kobe990  , it seems caused by upgrade of Uglify-js,
check this https://stackoverflow.com/a/55998303/10139109

hi, @kejiacheng , @kobe990 , it seems caused by upgrade of Uglify-js,
check this https://stackoverflow.com/a/55998303/10139109

thanks

THis not a problem with uglifyjs plugin, due to webpack-cli latest update this issue occurs
webpack/webpack-cli#881
It has worked as expected.

compress option doesn't consist of warning option in fact. But I don't know why it could pass build before.

Hi! Have you solved the problem?


Raml parser: support parsing fragments as the root node

Trying to spilt my big PR into smaller PR in the hope I can get something merged
Actually, this led to a much bigger PR, but dont worry, it is mostly a find replace renaming of RootNode...
For now, only datatype is introduced (actual implementation will be in the data type PR)
raml1.0 introduces possibility to split your REST api def into several parts
Interresting side effect of this is that you can use raml as a data-validator library.
a raml datatype file can be used for the same means as:
json schema
http://cerberus.readthedocs.org
https://pypi.python.org/pypi/yamltypes

Current coverage is 97.07%

Branch #83 has no coverage reports uploaded yet.

Powered by Codecov. Updated on successful CI builds.

Hmm I'm not sure how this passed - when I check it out locally I get a syntax error:
ramlfications git:(916e523) py.test tests/test_parser.py
====================================================================================== test session starts ======================================================================================
platform darwin -- Python 2.7.9, pytest-2.8.2, py-1.4.31, pluggy-0.3.1
rootdir: /Users/lynn/Dev/spotify/ramlfications, inifile:
plugins: cov-2.2.0, localserver-0.3.4, mock-0.4.3
collected 0 items / 1 errors

============================================================================================ ERRORS =============================================================================================
_____________________________________________________________________________ ERROR collecting tests/test_parser.py _____________________________________________________________________________
../../../.pyenv/versions/raml-27/lib/python2.7/site-packages/_pytest/python.py:591: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
../../../.pyenv/versions/raml-27/lib/python2.7/site-packages/py/_path/local.py:650: in pyimport
    __import__(modname)
../../../.pyenv/versions/raml-27/lib/python2.7/site-packages/_pytest/assertion/rewrite.py:171: in load_module
    py.builtin.exec_(co, mod.__dict__)
tests/test_parser.py:10: in <module>
    from ramlfications import parser as pw
ramlfications/__init__.py:7: in <module>
    from ramlfications.parser import parse_raml
ramlfications/parser/__init__.py:12: in <module>
    from .main import (
ramlfications/parser/main.py:15: in <module>
    from ramlfications.raml import (
ramlfications/raml.py:93: in <module>
    class RootNodeAPI08(RootNodeAPIBase):
../../../.pyenv/versions/raml-27/lib/python2.7/site-packages/attr/_make.py:194: in attributes
    return wrap(maybe_cl)
../../../.pyenv/versions/raml-27/lib/python2.7/site-packages/attr/_make.py:186: in wrap
    cl = _add_init(cl)
../../../.pyenv/versions/raml-27/lib/python2.7/site-packages/attr/_make.py:340: in _add_init
    bytecode = compile(script, unique_filename, "exec")
E   SyntaxError: duplicate argument 'raw' in function definition (<attrs generated init c1f77a313351c8b26088d0619b6349e525c10434>, line 1)

The PR otherwise makes sense to me.

I think this is because you have an old pyc of a unit test added by #80
The code is actually untested in #83, and I fixed the issue in #80

after double check, I can see all tests pass on that branch, and on the same commit as you tested :-/

(ramlfications/sandbox)  ~/dev/bb/ramlfications git:(ramlfragments)
0 % git lol |head
* 916e523 (HEAD, origin/ramlfragments, ramlfragments) Raml parser: support parsing fragments as the root node
* 86e3dc1 (spotify/v0.2.0-dev) remove unneeded commented-out code
* c595839 remove random notes file that was not meant to be commited
* 3e3b7db uncommented out forgotten but working tests
*   ab37dab Merge pull request #82 from spotify/lynn/fix-uri-params
|\
| * d3a58a7 (spotify/lynn/fix-uri-params) fixed order of uri/base uri params; create undeclared uri params
|/
* e319dec add travis config
* 9f73631 forgot to commit a test raml
(ramlfications/sandbox)  ~/dev/bb/ramlfications git:(ramlfragments)
0 % py.test --looponfail tests --ignore tests/integration
============================= test session starts ==============================
platform darwin -- Python 2.7.10 -- py-1.4.31 -- pytest-2.6.4
plugins: cov, localserver, mock, xdist, xdist, xdist
collected 225 items
collected 225 items

tests/test_config.py ...
tests/test_helpers.py ...
tests/test_init.py .......
tests/test_loader.py ...........................
tests/test_main.py .....
tests/test_parameter_tags.py ..
tests/test_parameters.py .
tests/test_parser.py .........................................................................
tests/test_tree.py ...sss
tests/test_utils.py ............
tests/test_validate.py ...................................
tests/raml10tests/test_basic.py .
tests/v020tests/test_inherited_resource_types.py ..
tests/v020tests/test_inherited_traits.py ..
tests/v020tests/test_resource_types.py ..............
tests/v020tests/test_resources.py .................
tests/v020tests/test_root_node.py .
tests/v020tests/test_security_schemes.py ......
tests/v020tests/test_traits.py ........

==================== 222 passed, 3 skipped in 8.87 seconds =====================

@tardyp wat?! so weird!  I did a fresh clone, fetched your particular PR branch (commit # 916e5230abaa1cac34b374aa4a034b78802e1e89) and ran py.test tests/test_parser.py and I'm still getting the same issues.

ahhh nevermind @tardyp ! I figured it out - I had an old attrs in my virtualenv. This is because I'm on my travel computer, not my work computer. phew okay glad that problem is solved!


feat(js): ES6 styles

Bumping because I'd like to see this implemented

Ok, this seems LGTM. 👍
@coopermaruyama thanks + @Vivalldi for the bump.


Entity Graph UI

Someone suggested that a (dynamic) Entity Graph UI could be interesting.
There are many JS frameworks to do this kind of thing; e.g. https://networkx.org, among others.
My personal primary interest is #76 more than this, but still creating an issue about it for future discussion.

https://docs.enola.dev/concepts/other/#graph

Dupe of #502!


Questions about evaluation graphs

In the 'A wait-free queue as fast as fetch-and-add paper', it shows the performances nearly 100 mops/seconds. But, the benchmark in this repo. shows 10 msgs/seconds (in case of XEON).
I know the environments are differ each others. But, why are they making differences?

what is the major difference between AtomicQueue and OptimistAtomicQueue regarding to performance? It has a little change in the code, but it shows the performance large gap.

Did you check the performance comparison with LRCQ?

LRCQ: Fast Concurrent Queues for x86 Processors, PPOPP '13

 -- figure in wait-free queue paper
Thanks...
Junghan

Hi Junghan,

The queues are based on ideas from the paper, but the implementation doesn't follow the paper.

OptimistAtomicQueue busy-waits in pop and push  when empty or full, whereas AtomicQueue try_pop and try_push return false in such cases. That extra empty or full condition is handled by a CAS loop, rather than FAA.

I didn't.

I got curious, downloaded LCRQ source code from http://mcg.cs.tau.ac.il/projects/lcrq/ and had a look into it.
Their benchmark is different. They measure the time of N threads each doing enque/deque pair of operations. Which means that in 1-thread case it is only 1 thread doing both enque/deque and that eliminates any contention and cache effects between different CPU cores. I do not think that is a reasonable usage scenario, in a 1-thread scenario a concurrent queue is never necessary. In multi-threaded scenario there is a chance that enque/deque operations often deque values enqued by this very thread.
I don't think such a benchmark represents realistic concurrent queue usage. The realistic usage, IMO, is when one thread is never both a producer and a consumer of the same queue object, rather a queue is a communication/distribution mechanism between different threads.


remove spaces from build string

The embedded spaces in the build string make it very difficult to use u-root, as the shells tend to
lose the quoting at some point. It's difficult to do triple-level quoting across every version of Make.

Given that this is u-root specific, and that we are asking the u-root example to be on a separate repository than this one, we won't be applying this change as it can be overridden elsewhere.


Invalid Links

Describe the bug
After the move to this new repository, the links to the docs are no longer valid.
It seems that also some pages of the docs have invalid links.
Steps to reproduce the behavior:

Visit the repository on GitHub and click the links

@nelimee I'm not sure if the permissions for this repo are set up correctly. I cannot assign myself nor any labels.

I just sent you an invitation to the tqec organization. Once accepted, you should be able to do such things. If not, please tell me :)

About this issue, it will be fixed at the first PR merged. I will see if I can trigger a re-generation of the documentation.

I think it's still not possible to assign anything

I think it's still not possible to assign anything

Hi Philipp, I have changed the base permission for the tqec members from read to write. Could you try again?

It's working now. Should people outside of the organization also be able to self-assign issues (as in #399)

It's working now. Should people outside of the organization also be able to self-assign issues (as in https://github.com/tqec/tqec/issues/399)

I don't think there is a setting for this?

I'm also not sure. In #400, I get a permission error when triggering the pipeline:
  /usr/bin/git push origin gh-pages
  remote: Permission to tqec/tqec.git denied to github-actions[bot].
  fatal: unable to access 'https://github.com/tqec/tqec.git/': The requested URL returned error: 403
  Error: Action failed with "The process '/usr/bin/git' failed with exit code 128"

and
Run marocchino/sticky-pull-request-comment@v2
Error: Resource not accessible by integration

As explained in #400 this is due to security issues with granting write access to the repository to anyone from the outside via GitHub actions. I will take a little bit of time to double-check the organisation/repository permissions, and try to fix this GitHub action problem.

Thanks! I was confused; the checks on #381 are complete, so I wondered if the issues stem from me triggering the pipeline.

About this issue, it will be fixed at the first PR merged. I will see if I can trigger a re-generation of the documentation.
This is still not the case after the last merge, I hope this will work once #381 is merged.

All the links are now valid thanks to #381. Closing.


login: Support logging out of an account (take 2)

These are the three last commits from #948, following up on the just-merged #1007 to replace #948: https://github.com/zulip/zulip-flutter/pull/948#pullrequestreview-2376668035
The screenshots in #948's description still match this code. As I said on #948, there might be some improvements to make to the UI, perhaps as a followup: https://github.com/zulip/zulip-flutter/pull/948#issuecomment-2423253936
Fixes: #463

app: Update three-dots button to use new M3 MenuAnchor widget

Thanks for the review! Revision pushed, this time with a bunch of tests. 🙂

Thanks! Revision pushed, and here's that screenshot of the new confirmation dialog:

Thanks! Looks good; merging.


Feature#3 UML UseCase diagram implementation

Full diagram:  https://app.creately.com/diagram/GRTCxJeeX3s/view

Add order-admin connection, guest permissions

closes #3


Can't View Certificates even though I accepted Academic Privacy Policy

Describe your problem and - if possible - how to reproduce it
I am trying to view my certificates and when I click the "Show Certification" button, a red bar appears at the top of the screen telling me "rperry99 has not yet agreed to our Academic Honesty Pledge." On my settings page, it shows that I have accepted the Academic Honesty Policy.
Add a Link to the page with the problem
https://www.freecodecamp.org/rperry99
Tell us about your browser and operating system

Browser Name: Google Chrome
Browser Version: 67.0.3396.99
Operating System: Windows

If possible, add a screenshot here

@rperry99 are you still experiencing this issue?

Sorry I didn't reply to this sooner. For some reason, it was telling me I couldn't. Anyway, No, I am not experiencing this anymore. I was able to get my certificates. I completely forgot I posted here or I would have updated it.
I am not sure what I did to fix it. I think it was an issue with the way I connected the website to github or something.

@rperry99 In that case, please close the issue


Registration Form

Registration Form
As a Pulani stakeholder i was tasked with creation of  a registration form
Acceptance Criteria

Wireframe (sketch) with these fields:

Names, phone number, gender, job, location, marital status.

Clearly state the required fields (fields with stars mean they are required. its meant to be if the user hovers on the start a pop message of a required field is shown

i forgot the sex like male or female but am fixing that. i designed a mockup i guess it can work better than a wireframe

thats another one

https://github.com/BuildForSDG/PulaniFront/issues/3#issuecomment-629162063, this is simple enough (IMO).

https://github.com/BuildForSDG/PulaniFront/issues/3#issuecomment-629189244, this is on point. Except that the background has a little bit too much but we'll discuss that @BryanCI


Add toggle to prevent pixel color data split across two artnet universes to support certain ArtNet Controller

Feature request

What problem does this feature solve?
Support for Artnet to SPI/DMX pixel light controller in the family of the BC-204.
Currently, the RGB data format in the HyperHDR software splits pixel color data across two universes which can look as follows:
508:R
509:G
510:B
511:R
512:G
001:B
002:R
003:G
004:B

However, for some ArtNet controllers, the expected formatting requires pixel data to always start at the beginning of a universe which should look like:
508:R
509:G
510:B
511:X not used
512:X not used
001:R
002:G
003:B
004:R
005:G
006:B

This discrepancy can cause issues with compatibility and expected behavior for specific ArtNet controllers.
Adding a toggle in the GUI to switch between the two data formats would address this problem.
What does the proposed API look like?
A new boolean toggle in the GUI named something like "Prevent Pixel Data Splitting Across Universes" or similar.
How should this be implemented in your opinion?
Add a new boolean toggle in the GUI settings for the ArtNet Controller.
This toggle should be linked to the backend logic that determines the data format for the ArtNet packet.
When the toggle is active, ensure that the data does not split across two universes, following the desired format.
The following code snippet supports the new behavior:  (LedDeviceUdpArtNet.cpp)

for (unsigned int ledIdx = 0; ledIdx < _ledRGBCount; ledIdx++)
{
	if (_restartColorIndexAtUniverseIncrement)
	{
		// Check if there's enough space in the current universe for all channels of the next LED
    	if (dmxIdx + _artnet_channelsPerFixture > DMX_MAX)
    	{
        	// Prepare and send the current universe
        	prepare(thisUniverse, _artnet_seq, dmxIdx);
        	retVal &= writeBytes(18 + qMin(dmxIdx, DMX_MAX), artnet_packet.raw);

        	// Move to the next universe and reset the DMX index
        	memset(artnet_packet.raw, 0, sizeof(artnet_packet.raw));
        	thisUniverse++;
        	dmxIdx = 0;
    	}
	}
}

Are you willing to work on this yourself?
Yes,
I would need some insight on how to link the bool logic to the gui and also help to name the variable
btw, amazing software :)

Hi
Can you test this build? https://github.com/awawa-dev/HyperHDR/actions/runs/6801157923 (branch: artnet ). Please ignore the incorrect new option label in the Artnet driver details, as this will be addressed later in the HyperHDR cumulative patch together with other resources, if this solution works properly.

That works! :)
edt_prevent_pixel_data_splitting_across_universes does solve this issues
Tests succeeded:
sending 171 pixels  from HyperHDR  udpartnet and using QLCplus as artnet monitor
Expected data on the second artnet universe:
when false, 1 data point
when true, 3 data points (1 pixel)
sending 342 pixels  from HyperHDR  udpartnet and using QLCplus as monitor
Expected data on third universe
when false, 2 data points
when true, 6 data points (2 pixels)
Feel free to close this issues


Provide a mechanism to gather prereq packages required to run smoke-tests offline

The smoke-tests do not support running offline as they have a set of prereq packages.  The source-build infrastructure should provide a mechanism to gather these packages so that the tests can be run offline.
The prep script script feels like the natural place for this to happen as it's primary responsibility is to gather the prereqs necessary to build.

During development of https://github.com/dotnet/installer/pull/16359, it became clear that versions of dependent packages are being updated frequently enough that makes the maintenance of a baseline file unsustainable.
For that reason, a different approach needs to be taken. Rather than relying on the prep script that would need to be run to gather the smoke test prereqs, the proposal is that a tarball containining these prereqs is provided as part of the release assets. This tarball would contain all the necessary packages for building and running the smoke tests offline. It would need to consolidate all of the restored packages from the various architectures of build legs since there are architecture-specific packages included in the mix.

@omajid / @mirespace - Please read the new approach I've described in https://github.com/dotnet/source-build/issues/3386#issuecomment-1583120095 and let me know your thoughts. Feel free to respond here if further clarification is needed.
Fundamentally, this isn't much different than what we do today for partner hand-off. This will just be automated as part of our release process. And the tarball that is produced will only include packages that are consumed by the smoke tests. Previously, we had been including some additional packages that weren't necessarily consumed by our smoke tests; those will no longer be included if the tests don't need them.

Hi @mthalman 👋🏻, we (Canonical) currently do not run the included smoke-tests automatically and as a consequence do not use the smoke test prereqs tarball either. But getting them working is on our Roadmap; I will put this issue on my TODO for next week.
The approach you proposed sounds good to me 👍🏻, if it should be more convenient for MS, I can also try Red Hat's approach and consume the NuGet feed directly.

Use of the NuGet feed is more tricky because it requires knowing which packages the tests require. More packages exist in the feed than are actually used by the tests. That's one of the reasons why we're going with this tarball approach.


Confluent Kafka operator on on-prem Kubernetes

Hi
Can we use Confluent kafka operator over a self-managed on-prem Kubernetes cluster (v1.13)?
I found a list of providers supported by confluent operator-
https://docs.confluent.io/current/installation/operator/index.html#co-long
According to this list It's not supported but I was going through a blog from @kaiwaehner
https://dzone.com/articles/kafka-operator-for-kubernetes-confluent-operator-t
I am little confused on this.

First of all, Confluent Operator is not related to this project here (Open Source Confluent Helm Charts).
You can use Confluent Operator with any Kubernetes distribution (including self-managed vanilla K8s).
However, as the Confluent Operator docs say, you need to run Kubernetes 1.9+ (I think 1.3 did not support the required concepts / features).

Thanks @kaiwaehner.
Does this operator require any license and comes with commercial version only?

Yes. Confluent Operator is a commercial product. Only 30 day trial and single node laptop version is free.

Thanks @kaiwaehner
Will contact sales team for the cost.


Distribute workers evenly across nodes

Hi there I am testing with cluster that starts with 100 nodes and with 200 workers. I noticed the workers do not evenly distribute across the nodes so I made change below to work deployment's template.spec. What do you think about incorporating this change as a parameter like worker.topologySpreadConstraints.enabled with default value false?
worker-deployment.yaml
spec:
  template:
    spec:
      topologySpreadConstraints:
        - maxSkew: 1
          topologyKey: kubernetes.io/hostname
          whenUnsatisfiable: ScheduleAnyway
          labelSelector:
            matchLabels:
              type: worker

Sure but it should be disabled by default I think. i.e. make no changes to existing deployments, doesn't include any changes. You can just copy the approach taken here:

https://github.com/deliveryhero/helm-charts/blob/master/stable/locust/templates/master-ingress.yaml#L20-L23
https://github.com/deliveryhero/helm-charts/blob/master/stable/locust/values.yaml#L141


Soft Filter Does Very Little

Describe the bug
I have added a call to k4a_device_enable_soft_filter in the hopes that it would filter depth less aggressively than the previous version of the SDK.  That does not seem to be the case.  I fail to see a significant difference between the depth image with Soft Filter True and Soft Filter False.
Here is a surface normal image with it set false:

Here it is set true:

To Reproduce
Add the end of the code that opens the cameras, call ::k4a_device_enable_soft_filter(device, false); or  ::k4a_device_enable_soft_filter(device, true);
Expected behavior
Some notable difference in the depth images.  Hopefully less aggressive filtering than the default.
Desktop (please complete the following information):

OS with Version: Windows 11
SDK Version: 1.9.3

Currently using default parameters, we are considering adding corresponding coordination parameters to the interface in the future
Current expected output:
Depth resolution: 1024*1024

Depth resolution: 640*576

Depth resolution: 512*512

Depth resolution: 320*288

Interesting!  Is it on or off by default?  Do you have info on how fast the soft filter is?


BML example

do you have a bml webpage example?

Sorry to be late ... I sold my PC and I don't have access anymore to my HDD backups.
I had a DTT captured TS file from Japan with one example inside a DSMCC objet.
If you know somebody in Japan with a digital tuner to capture the Digital Terrestrial Television, it might help.
I am not really sure that it is still used nowadays as the standard is now quite old.
You can find more documentation on those structures (page 224) in this PDF file from the ARIB standard:
https://www.arib.or.jp/english/html/overview/doc/6-STD-B24v5_2-2p3-1-E1.pdf
If you have a TS file with such example, you can extract those sources using free OpenCaster tool or TSduck one.
It seems that you can also use TS Data Extractor + BTBViewer like someone in Japan did describe in his article:
https://translate.google.com/translate?sl=auto&tl=en&u=https%3A%2F%2Fqiita.com%2Fkujira-desu%2Fitems%2Fd98587c10fb44d668f8f
Have a nice reading.

Hi,
Hope this message finds you well.
I managed to find an example TS from Japan (https://tsduck.io/streams/?name=japan-dttv) and we were able to extract the dsm-cc contents. Upon checking we are getting raw binary data inside modules (DDB folder). How we can inject this in the hbbtv viewer? thanks!

Hello Artemies,
Thank you for the link and I didn't know that TSduck is providing streams.
After your DSMCC carousel's extraction, you can host those directories and files under a local HTTP server like
NGINX or Apache where you have to associate the main entry page to this specific mime type "text/X-arib-bml".
(it can be defined locally in such server or globally inside /etc/mime.types if you are under Linux)
Under your browser, when you will request this local BML web page, then the installed browser extension
will detect the page holding such HTTP header mimetype and will change it to be displayed inside your browser.
Oipf & Hbbtv methods will then be injected inside this page and you can add more missing BML methods if needed
by modifying the extension source code.
Raw binary files will be also hosted and must be translated to something understandable by the main entry page.
I had some thought about doing an external Chrome app but the filesystem and network API are limited.
In the future, I am looking forward to WASM (aka WebAssembly) which will provide those APIs and
it will be easier to read a raw TS stream (even stream them) and extract it on the fly to provide it inside the web extension.
We just have to wait for such functionality (which are inside the Wasm/Wasi roadmap)
I hope it will help you.

Hi Karl,
Thanks for the info. In the meantime, we need to figure out how to recover the bml files from the raw binary data from DDB folder.

Hi Karl,
Upon demux of sample transport stream from Japan, we found that the DSMCC is empty but the DDB folder has some raw/binary files. I think ISDB-T Japan implements data carousel only (instead of object carousel). I attached the sample DDB files.
You mentioned before that you were able to extract BML from DSMCC object, if you can recall how you were able to extract this it will be a great help.
Thanks!
sample DDB.zip

Hello Artemies,
I see and I did remember that I modified ts2sec on OpenCaster but also dsmcc-receive in order to be able to extract things.
I don't have those patches at hand and they are somewhere backupped on one of my old disks. Moreover I sold my desktop PC too and therefore it will be not be easy to plugin those disks on my every day RPi4 computer (no SATA by default).
You can try to modify this tiny code here: https://github.com/aventuri/opencaster/tree/master/code/tools/dsmcc-receive
Or maybe if you retrieve the Ocean Blue DTVKit, they might handled it: https://www.dtvkit.org/wiki/doku.php?id=dsm-cc
Good luck.

Hi Karl,
Thank you for your prompt response. Will try this out.


[iOS] startInLoadingState with useWebKit breaks initial position on website

Using startinLoadingState used together with useWebKit currently breaks the initial position of a loaded website on iOS:
Expected and actual screenshots both reflect the initial state after loading.
Expected

Actual

Steps to reproduce

Use WebView with startInLoadingState and useWebKit both set to true
Set any website as source
Notice website is initially scrolled down a bit when loaded

Simple demo to reproduce
/**
 * @format
 * @flow
 */

import React, { Component } from 'react';
import { View } from 'react-native';
import { WebView } from 'react-native-webview';

type Props = {}

export default class App extends Component<Props> {
    render() {
        return (
            <WebView
                source={{uri: 'https://facebook.github.io/react-native/'}}
                startInLoadingState={true}
                useWebKit={true}
            />
        );
    }
}

Turning off either makes it work like expected.
Environmnent
<EMAIL_ADDRESS><EMAIL_ADDRESS>Verified bug on

iOS Simulator iPhone X - iOS 12.2
iOS Simulator iPhone 4s - iOS 9.0
Device iPhone X - iOS 12.2

Probably related to http://www.openradar.me/22855188.
Putting a breakpoint in RNCWKWebView.m shows the frame to be zero. Loading content while offscreen might trigger the bug. I'm just wondering why this does not happen when startInLoadingState is false, as there is no relation at all.
In RNCWKWebView.m:
- (void)didMoveToWindow
...
    CGRect test = self.bounds; // <- added for easier debugging
    _webView = [[WKWebView alloc] initWithFrame:self.bounds configuration: wkWebViewConfig];
    _webView.scrollView.delegate = self;
    _webView.UIDelegate = self;
    _webView.navigationDelegate = self;
    _webView.scrollView.scrollEnabled = _scrollEnabled;
    _webView.scrollView.pagingEnabled = _pagingEnabled;

Works when commenting out the line with UIScrollViewContentInsetAdjustmentNever (L151 in RNCWKWebView.m).
That was or is probably needed as a workaround for something else like mentioned in the radar report from above comments.
But
In https://stackoverflow.com/a/46466883/844907 the Apple Engineer smileyborg mentiones regarding the UIScrollViewContentInsetAdjustmentNever hotfix:

This issue was caused by a bug in iOS 11 where the safeAreaInsets of the view controller's view were set incorrectly during the navigation transition, which should be fixed in iOS 11.2. Setting the  contentInsetAdjustmentBehavior to .never isn't a great workaround because it will likely have other undesirable side effects. If you do use a workaround you should make sure to remove it for iOS versions >= 11.2
-mentioned by smileyborg (Software Engineer at Apple)

Emphasis mine.
Probably the define check needs adjustment. __IPHONE_OS_VERSION_MAX_ALLOWED just checks for the SDK compiled against. That line would always be included for SDK 11+, while it should probably be disabled for anything after SDK 11.2.
Note: I am not aware of a check that is able to do this as a compiler macro.

Addendum: Same error when using webView.reload(). Seem it is related to the implementation of the loading activity view.

@winkelsdorf feel free to submit a PR

@Titozzz Would love to, but I'm an iOS (Swift) Developer and have no clue where to start with such bugs in RN components.

Well the part broken is in the iOS code it seems so you should be able to update it :)

@Titozzz Sorry, looks like it's not that easy. That needs some help of a component aware RN/iOS developer. That's why I stopped after several hours of debugging and reported this issue.
E.g. the handling of _shouldStartLoadLock and the unusual construction of WKWebView in didMoveToWindow need explanation. Whats the reason for those, as in the wrapped UIWebView the usual constructor is used.
There has to be an undocumented reason that somebody did this? If I start changing things without knowing about the, I would likely break other things.
If anyone is willing to explain, join discussion or contribute, let me know.

As said it's not that easy. Spent 4 hours already, current observations:

The initial frame of the superView and _webView is 0,0,0,0 (origin x, y, width, height)
A size of 0,0,375,0 follows - so we have a non-null rect with zero height
Finally the size is correct with 0,0,375,641 (size for an iPhone X with TabBar)

As the frame of the _webView is always set to superView size in layoutSubviews several things are misaligned:

Initial scroll position when using startInLoadingState
Reload makes scroll position jump down a bit with each reload (till end of page is reached)

Ignoring zero rects with CGRectIsNull or empty ones with CGRectIsEmpty does not solve all problems (reload works when checking for CGRectIsEmpty but breaks initial position, too).
I am currently missing the link between the loading view on RN side and the frame bounds in the objc side.

I've thought about this many times. I could try to do that. I'll make a branch you can test

@Titozzz Great idea!
As this would also fix the issues with the Android Error Page, feel free to close this issue and put it on a roadmap. On the other hand I'm going to sort some smaller issues out with the native implementation (e.g. unneeded forced enum casting) and try to understand the old logic and do a bit of a rewrite for the iOS Part.
As RN support iOS 9+ only, some of the keyboard handler fixes might be removed as well.
Thanks for your help 👍

should be fixed

@Titozzz Thanks for the update!
Initial position works as expected now.
The overlay is working, too - but the Android Error page still flashes shortly.

Hi guys is there any actual fix for this? I am rendering my own error component, but when you navigate to another page, the error page does indeed shortly flash, which makes it look like a bug


Huh?

All I get is this???

it should be working now

So the purpose of this is to compare two cartoons?
Where are the images from the other processors?

it should be there, i just checked it

I deleted it and recloned it it's the same. I assume all I have to do is open index.html in a bowser.
There are no tif images.

Do you have python installed ?

If yes run the command python -m http.server 8080 in the project folder and open localhost:8080 in your web browser

That makes it work. Might want to mention that in the read me.
BTW you need to use python3 for that to work. On mac python runs 2 and python3 runs 3.
python3 -m http.server 8080

Why don't you just put this on a web site? It would be great for all to see.

So still some issues.

where are you uploading images to?

I pasted them in. That worked the first time.

You need to let it finish uploading when you paste.

i really dont feel like you have to paste anything,

Only Aukerman seems to work. You need to try more combinations in your testing.
Another odd thing is the on the left selection, if you pick ODM 2.1.1 it pops back to ODM 0.9.9

opendronemap.github.io/uavarena/

The pasting refer to the images in my message here not in your app.
If you paste an image into an issue you need to let it finish uploading.

just view it on github pages if thats all you want to do

How do I do that?

click here

No better:

give it a day, ive generated a pull request for it, its yet to be merged into master

I just went to you repo and cloned your fork.
Works better, but you still can't select ODM 2.1.1 on the left side.

Anyway thanks for all your help much appreciated. It's worth while to show that ODM is just as good.

Looks like this has been resolved :+1:
@jimdgit if some instructions are missing, please consider contributing to our README to add notes that have been useful to you, which might be useful to others in the future.


Distributor token service integration

What
Distributor token service integration.
Why
Apps would like to do silent sign-on, where they can detect the entitlements from the device's account.
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist

[ ] I have self-reviewed this PR
[ ] I have added tests that prove the feature works or the fix is effective

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: bsenth200:x: Brindha SenthilBrindha Senthil seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Update Mac build configuration

Could you please verify that this affect the Windows build.  I'm getting a Windows machine setup in the meantime.


drawingBufferWidth

drawingBufferWidth

Thanks for the pull request @jinjun1994!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

why checks have failed

why checks have failed

This error is not related to the PR you submitted.

Thanks for the fix @jinjun1994! I restarted the CI checks, and all passed.


abstracting pkcs11 package and adding another vendor besides yubikey

Issue Description
The only hardware that notary supports as trustmanager is Yubikey. We would like to extend notary to support other devices that work according to PKCS#11 -- and for our case add support for devices that are used through the opencryptoki library. Our suggestion is to split this up into two steps:

Create an abstraction for pkcs11 (and move Yubikey in there).
add opencryptoki support

So essentially this results in a file structure like the following:
├─trustmanager
│     ├─pkcs11
│     │   ├─yubikey
│     │   └─ opencryptoki

Other PKCS#11 exploiters can hook in at the level below PKCS#11. To keep enablement of other PKCS#11 trustmanagers simple in general, we think it would make sense, to abstract some of the yubikey files and code pieces to reuse them.
The abstraction could go that far, that just the following yubikeystore functions have to stay hardware specific, everything else could be reused by opencryptoki and other pkcs11 implementations:

getECDSAKey(),
addECDSAKey(),
yubiRemoveKey(),
Sign(),
hardwareListKey(),
listObjects(),
SetupHSMEnv()

PR Description
This PR addresses #1289

First commit abstracts the yubikey package into a hardwareindependent pcks11 package and a hardwarespecific yubikey package.
Second commit adds opencryptoki as another hardware implementation.

Can one of the admins verify this patch?

As I'm leaving the team, developing the code leading to this PR, https://github.com/jschintag will continue development


_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 11s

the patch passed

+1 :green_heart:
compile
2m 25s

the patch passed

+1 :green_heart:
javac
2m 25s

the patch passed

+1 :green_heart:
javadoc
1m 25s

the patch passed

+1 :green_heart:
shadedjars
6m 27s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m 57s

hbase-client in the patch passed.

-1 :x:
unit
253m 46s
/patch-unit-hbase-server.txt
hbase-server in the patch failed.

+1 :green_heart:
unit
24m  8s

hbase-mapreduce in the patch passed.

310m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6286/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6286

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux d13f6c8821b4 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 5fe310989a439d70033b6a71c801a826b8814a54

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6286/1/testReport/

Max. process+thread count
5320 (vs. ulimit of 30000)

modules
C: hbase-client hbase-server hbase-mapreduce U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6286/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

the test failures are existing issues and not related to this PR

ScanMetrics is IA.Public, so we can not hide the public fields without deprecation cycle...


Console rendering bug when displaying VT on HDPI

In RS2 / Creators Update (15063.138)
The console sometimes displays extra spaces in strings containing ANSI/VT colors when displayed at another DPI scaling than 100%. It happens a lot at 125% and 175% and a bit less but still common at 150%.
Testing the following in a console with the default Consolas font at 20 pixels high (default settings in latin script regions), on a system set to 150% (default on a Surface Pro device). ClearType is enabled, as that can change the rendered text width.
echo -e "\u2592##"
Displays a medium shade block followed by two # characters, 3 columns total.
echo -e "\E[41m\u2592#\E[49m#"
Should display the same characters, but showing the shade block and the first # over a red background.
Instead, it inserts an extra space of exactly 1 column width between the two # characters.
This is a bug in conhost and affects any console app, not just WSL. Confirmed in Win32 as well.
The console seems to output text in chunks of characters using identical attributes. If a color is changed, it computes the x location for the next chunk and starts displaying from that column. It seems to work fine when the display DPI is set to a 100% scaling, but it is regularly off by one when another system scaling ratio is used. This inserts spaces in colored text, breaking alignment.
It depends on previously displayed characters, but the shading blocks aren't the only ones affected. It seems the console computes the starting column of the next chunk based on the pixels width of the previous chunks instead of simply by counting the displayable characters, and probably rounds up some width that overflows a bit into the next column in some fonts and smoothing modes when rendered at some DPI scaling zoom.
This breaks many ANSI-art effects and complex text-based UI layouts.
Related: Parsing bug in 24bit VT colors (https://github.com/Microsoft/BashOnWindows/issues/1681)
These should probably be handled together, as they both exhibit a problem with how the console stores and render colored text.

Just adding some of my own investigation. This appears to vary based on a combination of font AND size, not just the font alone. The first console in this image has (Consolas, 16), the second is (Consolas, 20), and the third shows what happens when you output [(Courier New 20), (Consolas, 20), (Lucidia Console, 20)].
Consolas 16 doesn't have this problem, but Consolas 20 does.
@miniksa for more investigation. I opened MSFT:11641556 to track this.

The problem here is that \u2592 is an ambiguous width character as defined in Unicode: http://www.unicode.org/Public/UCD/latest/ucd/EastAsianWidth.txt
That means I have no idea if it's going to be a single column or two columns wide. So the heuristic we use is how many pixels is it going to consume versus a '0' in the currently selected font. Apparently in Consolas 16, that shaded box character consumes less than a '0' and in Consolas 20, it consumes more pixels than a '0' which is what is causing this rendering snafu. Adding High DPI to the mix makes this worse because now there's a MulDiv calculation with rounding potential to make the shaded box have more or less pixels than a '0'.
If you have any ideas on how to more reliably detect whether it will take 1 or 2 columns in GDI, I'm all ears. This is just a very sensitive code path because drawing to the screen takes about 80% of our CPU time (because we still use GDI and it's done on the CPU) so I'm hesitant to make some wildly complicated mechanism here that might significantly impact the CPU usage/time. I think the correct solution is to just capture this problem in the scope of the work required to move to a modern renderer like DirectWrite on DirectX. Unfortunately that means no quick fix.

Some tests showing how chunks of colored text aligns using a proportional font. This is an unsupported scenario as the console is only for monospace fonts, but it shows how it renders ANSI blocks of identical attributes.

Language is JavaScript with the console available through the object model, should be self-explanatory.
ActiveScript Shell (AXSH) is available on Win10 Store if you want to use it for testing. Repro commands:
with (console.font) { name="Arial"; size=20 }
echo("\33[41m\u2592#\33[49m#")
echo("\33[41mi#\33[49m#")
echo("\33[41mm#\33[49m#")
echo(fun.RainbowCat)
show(console.font)

@miniksa I had good results with the following code to determine the columns used by a string:

ansi.getDisplayWidth uses GetStringTypeW(CT_CTYPE3, bstrText, cchLine, rgType), skips escape sequences, then simply check each character width as follow:
if (rgType[i] & (C3_HIRAGANA | C3_KATAKANA | C3_FULLWIDTH | C3_IDEOGRAPH)) // FullWidth catches fw-katakana and fw-romaji
{
// Full-width katakana with " or ° gives 0x8012 (C3_ALPHA|C3_KATAKANA|C3_DIACRITIC)
// so we check if it's a wide character family, and then if it isn't explicitly half-width variant
if (rgType[i] & C3_HALFWIDTH)
displaylength += 1;
else
displaylength += 2;
}
else
displaylength++;
You can completely ignore the non-spacing diactitics (C3_NONSPACING) as the console shows them as individual spacing characters anyway.

@miniksa If you really want to check the actual GDI width of the character in the specific font, asian glyphs are very consistent with double-width always taking a full square. So I would change the test from (chrPixelWidth > pixelWidth('0')) to (charPixelWidth > pixelWidth('0')*1.5), which should still catch all full-width without false-positives on half-width that bleeds a bit outside a single column.

Good ideas indeed. I still have to think it through a bit further though because things like the selection highlight are still going to be messed up if something takes 9 pixels when a '0' (or whatever metric we use like perhaps your suggestion above instead) takes 8 pixels. The characters will jump on redraw or the selection rectangle won't be drawn on top of the right spot.
The only way I can think to fix that is to draw each character individually and chop it down to force it to fit inside its rectangle (or to leave enough space before drawing the next one) instead of drawing each row as a run like we do right now. The problem is, we draw runs because the performance is already terrible to call draw 25 times to draw 25 lines on the screen. I can't imagine how bad it would be to call to draw 80x25 individual characters on the screen (or more). Maybe some trade-off where it only draws individually when detecting an ambiguous character? Or maybe there's some GDI trickery I haven't figured out yet...

@zadjii-msft Moving here from #1936
Hmm. If I have a choice between prioritizing support for 3rd-party consoles (which should also cover things like embedded terminals, e.g. VS code, right?) and making the default console awesome, I'll pick the first, since a third-party console doesn't have to care about compatibility and it takes the pressure off you guys to support everything perfectly now without breaking anything 😉
That said, this looks like a curly one. It sounds like you're currently using DrawText(), could switching to ExtTextOut() for the lpDx parameter be a decent workaround for now?

@miniksa You wrote:

I think the correct solution is to just capture this problem in the scope of the work required to move to a modern renderer like DirectWrite on DirectX. Unfortunately that means no quick fix.

So do you folks actually have plans to make a new Terminal? There are so many excellent terminal's included with Linux, seems like porting one of those to Windows would be the easiest path... And how great to have forks of the terminal code to add things like image support, higher range of colors...
ConEmu seems to be the least painful option for now, but still a long ways from the native Linux terminals...

@ryanerwin #111 seems to be, despite the obsolete title, the closest thing to an issue tracking "make the console api public", but basically all the label:console issues are "make a new terminal", in the sense of "fix everything in the current terminal: conhost.exe"

@ryanerwin Considering the console performance is directly linked to its text rendering calls, making a cross-platform console with some abstraction in the text rendering isn't the right way to go. Abstraction always comes at a cost.
A modern console using DirectWrite is the best way to go for a console on Windows and since the performance would impact all text-based apps, the effort to write a good console taking advantage of the DirectX platform is justified.

@miniksa Taking another approach here.
The problem is basically linked to how some fonts render at different sizes and mostly to how block elements and line (box) drawing characters render imperfectly at the pixel level.
This issue is a font-hinting issue first, and even if your conhost code could work around it, it would still display glitches at the pixel level for ANSI-art and ASCII-based boxes, such as shading blocks not joined to a uniform shade (non-uniform checkerboard), or background colored lines showing a bit on full-blocks cells.
So how about you push this problem to the Typography team and get them to fix the fonts that are now used for the console, mainly Consolas, to be better hinted and generate pixel-perfect blocks and lines glyphs at all DPI and font sizes supported by conhost?
This would mitigate the current issue by making the characters that currently exhibit these issues fit their cells perfectly. And it wouldn't be wasted work on a temporary fix as it would make the rendering with the standard fonts more precise and better looking even on a future DirectWrite-based console.
Even better, updating TTF files is probably easier to push in a monthly update than a new build of conhost, so this could fix many scenarios on a patch Tuesday.

@miniksa
Most of this seems fixed in 1709, but I do have some bad news...
I didn't notice this bug before the release of 1709 because it only happens in some rare cases, and I must admit I'm still unable to build a simple project that reproduces the issue.
But there is a problem with how "\x1B[7m" and "\x1B[27m" are handled. The first sets reverse mode, the second returns to normal mode. Most of the time it works fine, but sometimes, the second one gets ignored, and reverse mode continues until some other in-band control changes the console internal state again.

This is very erratic, it seems to be linked to font size again, but even at the same font size, a call to SetConsoleMode, or showing and OK'ing the console properties dialog (which I assume calls the same API) usually clears the error forever in that console window.
Very very weird thing.
It doesn't seem to affect current LXSS shells, so I assume it is highly dependent on calls to SetConsoleMode for that conhost instance.
Any idea ?

@zadjii-msft have you seen anything with the 7m and 27m states recently that might explain this?

Nope, this looks new to me. Might be related to the reflowing thing, but I don't think that code path would be hit here.
I've filed a bug to look into this later this cycle.

@zadjii-msft
As usual, writing to explain about it to someone else makes my brain think about it from another perspective and other cases.
And... good news, I just had a guess and found how to replicate the issue !
I couldn't replicate it because I was focusing my sample code on the \x1B[7m and \x1B[27m codes, but it only happens if you've set 24-bit VT colors earlier.
I suppose calls to SetConsoleMode or OK'ing the console properties dialog resets some conhost internal state about the current color.
So it's very easy to replicate :
#include <windows.h>
#ifndef ENABLE_VIRTUAL_TERMINAL_PROCESSING
#define ENABLE_VIRTUAL_TERMINAL_PROCESSING 0x0004
#endif
int main()
{
HANDLE hOutput = GetStdHandle(STD_OUTPUT_HANDLE);
DWORD dwMode = 0;
GetConsoleMode(hOutput, &dwMode);
dwMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
SetConsoleMode(hOutput, dwMode);

LPWSTR pszTestString = TEXT("\x1B[7m Reversed \x1B[27m Normal \x1B[38;2;128;5;255m Set 24-bit foreColor \x1B[7m Reversed \x1B[27m Normal \r\n");
WriteConsole(hOutput, pszTestString, _tcslen(pszTestString), NULL, NULL);

getchar();
return 0;

}

And now with that understood, I can replicate in Ubuntu on 1709 RTW:
echo -e "\e[7m Reversed \e[27m Normal \e[38;2;250;20;40m 24-bit VT color \e[7m Reversed \e[27m Normal "

@zadjii-msft
Since it doesn't seem, after all, to be linked to font sizes, should I leave this in this thread or close this one and post this info clean in a new issue thread?

@PhMajerus Awesome! thanks for the super simple repro steps. I'd say that it's unlikely I fixed the reverse sequence to work with RGB color. That shouldn't be too hard to fix though. Thanks for investigating!
I'd say it's best to keep the threads separate, so if you could file a new issue that'd be great.

@zadjii-msft
Be careful it's not only when the current fore or back color is 24-bit, you have a state that lingers in conhost even if the color has been reset:
echo -e "\e[7m Reversed \e[27m Normal \e[38;2;250;20;40m 24-bit VT color \e[39m reset color \e[ 7m Reversed \e[27m Normal "

So it's not just in your \x1B[27m handler code path that handles if current fore or back is 24-bit, as in this sample it isn't anymore. There is something else that makes it stop working even if the color is back to a base console color.

Closing this issue as characters width dependent on font-size issue is fixed.
VT "\x1B[7m" and "\x1B[27m" issue moved to its own thread: #2583
Thanks again for your hard work @zadjii-msft and @miniksa !


Discrepancy in documentation and mdi icon set

Hi, it is mentioned in the documentation https://github.com/userquin/vuetify-nuxt-module/blob/e402bf8118616e335061dbc59f8a85a9d9d92fa0/docs/guide/index.md?plain=1#L279 that the default mdi icon used is loaded from CDN and will use the @latest. But in fact, it's using the @5.x version. https://github.com/userquin/vuetify-nuxt-module/blob/e402bf8118616e335061dbc59f8a85a9d9d92fa0/src/utils/icons.ts#L36
Would it be possible to change it so that it uses latest instead?
Thanks!

Check https://vuetifyjs.com/en/features/icon-fonts/#mdi-css (using icons.ts link).
You can change the cdn entry to use latest version, check https://vuetify-nuxt-module.netlify.app/guide/icons/font-icons.html.
I need to update the types.ts module and the md file in the docs, mdi icon font link in the page using 5.x

Thanks for the quick response!

@userquin
So I tried but it doesn't work.  The  generated file vuetify-icons-configuration contains twice the mdi import. Looks like the sets are not merged.
import {aliases,mdi} from "/_nuxt/node_modules/.pnpm/vuetify@3.5.7_typescript@5.4.5_vite-plugin-vuetify@2.0.3_vue@3.4.23/node_modules/vuetify/lib/iconsets/mdi.mjs?v=5640749c"
import {aliases,mdi} from "/_nuxt/node_modules/.pnpm/vuetify@3.5.7_typescript@5.4.5_vite-plugin-vuetify@2.0.3_vue@3.4.23/node_modules/vuetify/lib/iconsets/mdi.mjs?v=5640749c"
export const enabled = true
export const isDev = true
export function iconsConfiguration() {

  return {
    defaultSet: 'mdi',
    aliases,
    sets: { mdi,mdi }
  }
}

@trc-mathieu I cannot reproduce it, it is working in the playground in the repo...

check if you have the mdi icon set added twice in the config file

I'm using it from a layer, might be something related to this. I'll investigate more...


[SPARK-19851][SQL] Add support for EVERY and ANY (SOME) aggregates

What changes were proposed in this pull request?
Implements Every, Some, Any aggregates in SQL. These new aggregate expressions are analyzed in normal way and rewritten to equivalent existing aggregate expressions in the optimizer.
Every(x) => Min(x)  where x is boolean.
Some(x) => Max(x) where x is boolean.
Any is a synonym for Some.
SQL
explain extended select every(v) from test_agg group by k;

Plan :
== Parsed Logical Plan ==
'Aggregate ['k], [unresolvedalias('every('v), None)]
+- 'UnresolvedRelation `test_agg`

== Analyzed Logical Plan ==
every(v): boolean
Aggregate [k#0], [every(v#1) AS every(v)#5]
+- SubqueryAlias `test_agg`
   +- Project [k#0, v#1]
      +- SubqueryAlias `test_agg`
         +- LocalRelation [k#0, v#1]

== Optimized Logical Plan ==
Aggregate [k#0], [min(v#1) AS every(v)#5]
+- LocalRelation [k#0, v#1]

== Physical Plan ==
*(2) HashAggregate(keys=[k#0], functions=[min(v#1)], output=[every(v)#5])
+- Exchange hashpartitioning(k#0, 200)
   +- *(1) HashAggregate(keys=[k#0], functions=[partial_min(v#1)], output=[k#0, min#7])
      +- LocalTableScan [k#0, v#1]
Time taken: 0.512 seconds, Fetched 1 row(s)

How was this patch tested?
Added tests in SQLQueryTestSuite, DataframeAggregateSuite

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4408/
Test PASSed.

Test build #97930 has started for PR 22809 at commit b793d06.

Test build #97930 has finished for PR 22809 at commit b793d06.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
trait UnevaluableAggrgate extends DeclarativeAggregate
abstract class AnyAggBase(arg: Expression)
case class AnyAgg(arg: Expression) extends AnyAggBase(arg)
case class SomeAgg(arg: Expression) extends AnyAggBase(arg)
case class EveryAgg(arg: Expression)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97930/
Test PASSed.

cc @cloud-fan @gatorsmile

Can we use these functions in window with this approach?

@cloud-fan Yeah.. I have some tests in group-by.sql. Please take a look.

Test build #97986 has started for PR 22809 at commit 9e194b5.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4449/
Test PASSed.

Test build #97986 has finished for PR 22809 at commit 9e194b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97986/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4461/
Test PASSed.

Test build #97999 has started for PR 22809 at commit 6abf844.

Test build #97999 has finished for PR 22809 at commit 6abf844.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97999/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4490/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4492/
Test PASSed.

Test build #98035 has started for PR 22809 at commit 2bc9965.

Test build #98035 has finished for PR 22809 at commit 2bc9965.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98033/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98035/
Test PASSed.

@cloud-fan @mgaido91 I have incorporated the comments. Could we please check if things look okay now ?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4560/
Test PASSed.

Test build #98139 has started for PR 22809 at commit 07205de.

LGTM

Test build #98139 has finished for PR 22809 at commit 07205de.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98139/
Test PASSed.

thanks, merging to master!

Thanks a lot @cloud-fan @mgaido91


[FLINK-23420][table-runtime] LinkedListSerializer now checks for null elements in the list

(This PR is cherry-picked from #16699)
What is the purpose of the change
LinkedListSerializer in the table runtime module currently is not aware of the null elements in the list. This will cause NPE in some functions like the LAG aggregation function.
This PR fixes this issue and at the mean time keep the compatibility of the states.
Brief change log

LinkedListSerializer now checks for null elements in the list

Verifying this change
This change added tests and can be verified by running the added tests.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: YES
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@flinkbot run azure


More SwiftUI uses?

This isn't an issue just a request. Is it possible to recreate the AppKit demo in SwiftUI? I've been unsuccessful in my attempts, not sure if this is possible yet? Adding more SwiftUI examples would be greatly appreciated. I'd really enjoy adding this to my application to give it the pizazz it needs but haven't successfully found a use just yet.

Hey — I could probably add a SwiftUI version of the Picture-in-Picture example, which is a good use-case for Wave.

@jtrivedi Thank you for the reply! That’d be greatly appreciated 👍


For multidimensional models, fixing only parameters of certain dimensions?

A question on interacting with models:
Given a multidimensional model:
ker = GPy.kern.StdPeriodic(input_dim=2, ARD1=True)
In this example, it is possible to fix both wavelength parameters:
ker.wavelengths.fix((2,5))
Also, it is possible to unfix them:
ker.wavelengths.unfix()
Now, is it also possible to fix only one wavelength parameter?
Is there a difference between the fix() and the constrain_fixed() methods?
Thanks a lot, best,
Elke

1.) Yes you just select the exact wavelength you want to fix:
ker.wavelengths[0, [0]].fix()
2.) fix is a proxy for constrain_fixed

Am 08.02.2016 um 17:07 schrieb Elke Schaper<EMAIL_ADDRESS>A question on interacting with models:
Given a multidimensional model:
ker = GPykernStdPeriodic(input_dim=2, ARD1=True)
In this example, it is possible to fix both wavelength parameters:
kerwavelengthsfix((2,5))
Also, it is possible to unfix them:
kerwavelengthsunfix()
Now, is it also possible to fix only one wavelength parameter?
Is there a difference between the fix() and the constrain_fixed() methods?
Thanks a lot, best,
Elke
—
Reply to this email directly or view it on GitHub.

1.) Yes you just select the exact wavelength you want to fix:
ker.wavelengths[0, [0]].fix()

This does not seem to work for me:

ker = GPy.kern.StdPeriodic(input_dim=2, ARD1=True)
ker.wavelengths[0, [0]].fix()
Traceback (most recent call last):
File "", line 1, in
File “/my/path/to/python3.5/site-packages/paramz/param.py", line 164, in getitem
new_arr = super(Param, self).getitem(s, *args, **kwargs)
IndexError: too many indices for array

My Environment:
paramz==0.1.2
GPy==0.9.6
Python=3.5.0
Perhaps a Python3 issue?
Or syntax problems?

2.) fix is a proxy for constrain_fixed

Thank you for clarification!

You need to select the one wavelength you want exactly. Now the params are Numpy arrays, so you need to use the right indexing for the selection, as: if you just choose one wavelength directly you get back a float. Thus, you want to use advanced indexing (see numpy advanced indexing) in order to keep one dimension. That is why there is two brackets [[]]. Now it depends on the dimensions of the wavelengths of how to slect them. I somehow assumed they are two dimensional, which does not make sense...
You'll figure it out from here, just select the one lengthscale you want and try printing it. If it prints the Param object (nice printing with constraints and so on) it is right. You can call any of the constraints methods on Param and Parameterized objects.
Best

Am 09.02.2016 um 13:00 schrieb Elke Schaper<EMAIL_ADDRESS>
1.) Yes you just select the exact wavelength you want to fix:
ker.wavelengths[0, [0]].fix()

This does not seem to work for me:

ker = GPy.kern.StdPeriodic(input_dim=2, ARD1=True)
ker.wavelengths[0, [0]].fix()
Traceback (most recent call last):
File "", line 1, in
File “/my/path/to/python3.5/site-packages/paramz/param.py", line 164, in getitem
new_arr = super(Param, self).getitem(s, *args, **kwargs)
IndexError: too many indices for array

My Environment:
paramz==0.1.2
GPy==0.9.6
Python=3.5.0
Perhaps a Python3 issue?
Or syntax problems?

2.) fix is a proxy for constrain_fixed

Thank you for clarification!
—
Reply to this email directly or view it on GitHub.

Thank for the helpful explanation, Max!
Here’s an example where the wavelength parameter for the 3rd input dimension is fixed to 42:
ker = GPy.kern.StdPeriodic(input_dim=3, ARD1=True)
ker.wavelengths[2] = 42
ker.wavelengths[[2]].fix()
print(ker.wavelengths)

On Feb 9, 2016, at 2:17 PM, Max Zwiessele<EMAIL_ADDRESS>wrote:
You need to select the one wavelength you want exactly. Now the params are Numpy arrays, so you need to use the right indexing for the selection, as: if you just choose one wavelength directly you get back a float. Thus, you want to use advanced indexing (see numpy advanced indexing) in order to keep one dimension. That is why there is two brackets [[]]. Now it depends on the dimensions of the wavelengths of how to slect them. I somehow assumed they are two dimensional, which does not make sense...
You'll figure it out from here, just select the one lengthscale you want and try printing it. If it prints the Param object (nice printing with constraints and so on) it is right. You can call any of the constraints methods on Param and Parameterized objects.
Best

Am 09.02.2016 um 13:00 schrieb Elke Schaper<EMAIL_ADDRESS>
1.) Yes you just select the exact wavelength you want to fix:
ker.wavelengths[0, [0]].fix()

This does not seem to work for me:

ker = GPy.kern.StdPeriodic(input_dim=2, ARD1=True)
ker.wavelengths[0, [0]].fix()
Traceback (most recent call last):
File "", line 1, in
File “/my/path/to/python3.5/site-packages/paramz/param.py", line 164, in getitem
new_arr = super(Param, self).getitem(s, *args, **kwargs)
IndexError: too many indices for array

My Environment:
paramz==0.1.2
GPy==0.9.6
Python=3.5.0
Perhaps a Python3 issue?
Or syntax problems?

2.) fix is a proxy for constrain_fixed

Thank you for clarification!
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub https://github.com/SheffieldML/GPy/issues/299#issuecomment-181859309.


Fix Beego_test and add fiberEngine Test.

Revised PR. To add new feature to support fiber engine. (https://github.com/gofiber)
Original PR: https://github.com/appleboy/gofight/pull/83

I remove the fiber package since fiber doesn't support ServeHTTP.


Think about adding an examples folder

As discussed in #11, we might might want to consider adding an examples folder as is common in Rust, which helps people to get up to speed quickly.
It would make sense to remove the bin folder and replace it with an examples folder. That can then be run via cargo run --example EXAMPLE_NAME.
Preferably, we would add an examples folder and also keep the existing example in the README.md without code duplication.

This is an old ticket and can be closed now.

This is an old ticket and can be closed now.


allow multiple annotation refs with the same name

this should unblock the policy work.
i did explore couple more options:

make it part of the annotation declaration, whether multiple refs are allowed (it would be false in many cases, like ttl for example).
keep the AnnotationRef single, instead make the params dictionaries an array. It might be safer, as in you can't just ignore the second annotations with the same name, but it inconsistent with the manifest language...
WDYT?

make it part of the annotation declaration, whether multiple refs are allowed (it would be false in many cases, like ttl for example).

I like this idea!


youtube-dl doesn't download "best" resolution

I am using youtube-dl "address" which should download the best video and audio by default. I checked my video with youtube-dl -F "address" but it doesn't match what I downloaded. It should be webm 640x360 vorbis@128k. Instead it's webm 400x270 vorbis@96k. Those settings are identical to the mp4 format download. I am on the latest version of youtube-dl.

Carefully read new issue template and provide all requested information.


Flaky JsonRpcHttpServiceTest.getBlockByNumberForLatest test

Following https://github.com/hyperledger/besu/commit/27fd97f6b578d94fb06fcdde779596dd90bd0738, org.hyperledger.besu.ethereum.api.jsonrpc.JsonRpcHttpServiceTest.getBlockByNumberForLatest is flaky

Will leave open for a couple of days to make sure test is no longer flaky


Add GV and Good Vibes

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

Automerge failed because our website isn't hosted yet. However, that will be the web address for our website up a in a few days. Would love for this to be added, but if not I'm happy to re-request after the website is running.


Use gogo proto

Shift to gogo protobuf: https://github.com/gogo/protobuf

This change is

Coverage remained the same at 61.149% when pulling a4e8c2e370577e6faf4856601510b4ac4e69ce0f on feature/gogoproto into f61b23d7bc513a204e4a9c6f6112169cad8d69cb on develop.

Also, update the command in .proto file to generate the .pb.go file. Do we need to vendor in this library?

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Updated the comments. No, we dont have to. Just need to do go get github.com/gogo/protobuf/protoc-gen-gofast before compiling the proto files.

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

Coverage remained the same at 61.149% when pulling 6d9a8ea8931c157b199d33e86a30feae3252d79d on feature/gogoproto into f61b23d7bc513a204e4a9c6f6112169cad8d69cb on develop.

Do one more thing add this as a comment. That before running the command, we need to go get library. Imagine someone new to the project, they wouldn't know about this. Otherwise

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Coverage remained the same at 61.149% when pulling 5c39abf6759759a97517176de1cbef8da531ad46 on feature/gogoproto into f61b23d7bc513a204e4a9c6f6112169cad8d69cb on develop.

Merged.


fix(tailscale/tailscale): add tailscaled on Linux

#26715
Follow up #26714
I forgot to add tailscaled.

This is great, thank you!