predictions_by_input not working

@client = GooglePlaces::Client.new(API_KEY)

@client.predictions_by_input(
    'San F',
    lat: 0.0,
    lng: 0.0,
    radius: 20000000,
    types: 'geocode',
    language: I18n.locale,
)

undefined method `predictions_by_input' for #GooglePlaces::Client:0x0000000625bcb8

I tried using the code from master branch and it worked.
Is there any release planned for this change ?

Master branch is v0.34.2 that's live on RubyGems now - https://rubygems.org/gems/google_places/
I just tried installing this gem fresh from RubyGems and running the code you pasted above, and it works fine.
In your directory with the broken GooglePlaces app, mind running gem list | grep google_places to see which version you've got installed?

I didn't specify any version while installing this. Just added gem 'google_places' into my gem file.
Found out that version 0.21.0 is installed. I had to manually specify gem 'google_places', '~> 0.34.2' for it to work

Hmm - might be a problem with local cached version of rubygems, but if you do a clean install, rubygems should install the latest version of any published gem.

yea, maybe. You can close the issue, sorry for the noise. Might be helpful for someone googling this.

All good - thanks!


Class BinaryShardedJedis does not have method "public String set(final byte[] key, final byte[] value, final byte[] nxxx, final byte[] expx, final long time)"

As you see, could not find the method, is there a reason for this?

@auhig we probably missed it. Do you mind crafting a PR to fix it?


RequireJS / AMD Support

Thanks for writing a great plugin that's been super helpful so far. One issue I just ran into is that the plugin does not work when used in a require JS / AMD environment.  Below is the require block in require_config:
define('moment',['moment/2.24.0/moment.min', 'moment/plugins/business-days/plugin'],function (moment) {     window.moment = moment;     return moment; });
I get a moment is not defined error. If I throw in a require call or a timer that waits for the moment variable in the plugin file it all works. Would it be possible to add amd support to the code?

Is there any resource on how to develop a proper module, especially a moment plugin? This plugin was developed by @kalmecak a while ago i think, back then there weren't well defined formats I think. On a personal level I would be quite interested in this specification

You can just add a shim to your requirejs config. This solution assumes you already have momentjs added as an AMD module. If you don't you'll need to add a path for it to your requirejs config.
config = {
    paths: {
        "moment-business-days": "path/to/moment-business-days/index"
    },
    // Add moment-business-days methods to moment.js (https://github.com/kalmecak/moment-business-days)
    shim: {
        "moment-business-days": ['moment']
    }
}


[Ostrava] Lesson 3

Update the part about the images.
The materials are already on naucse, however I don't see the tasks updated yet, this could help with that.
Cc. @frenzymadness

Thank you!


Feature request: Add guide how to communicate launch tcp server and connect to it

Language server
No response
Requested feature
Hi there!
We spent a lot of time building an Lsp server for Solidity and now I'd like to add its configuration for Nvim users! The issue is, I can't get it to work myself.
I am editing my server_configurations directory directly to ensure there's no gotchas. It seems like the default_config.cmd function has to do something like return vim.lsp.rpc.connect('<IP_ADDRESS>', port_num).
Everything works fine when I launch the lsp (woke --debug lsp --port 65433 for example) and just connect to it. However, I cannot get it work by adding a
os.execute('woke lsp --port ' .. port_str .. ' &')

in the aforementioned function (the & at the end should presumably launch it as a background process). Are there any examples/guides how to do this? 🙂 It seems like there is just one tcp server (gdscript.lua) and that connects to an ex-ante-launched process
Other clients which have this feature
No response

os.execute('woke lsp --port ' .. port_str .. ' &')

in the aforementioned function (the & at the end should presumably launch it as a background process).

Using & is a shell trick. Using os.execute plus shell tricks is fragile and platform-specific. In Nvim 0.10 you can using vim.spawn, in older Nvim you can use jobstart() to start a background process.
The title of this issue requests a "guide" for this specific thing, that's out of scope for nvim-lspconfig which is just a collection of configs.

Actually jobstart does work. I'll send over a PR in the coming days

I think the tricky part is you need to await for the jobstarted process to finish setting up before you launch nc or vim.lsp.rpc.connect. I don't think async is baked into nvim-lspconfig and it probably doesn't make sense to block the thread either. The most tractable way to set up such an LSP might be to do it without lspconfig, just call vim.lsp.start() in ftplugin: https://f1sty.github.io/neovim/nvim/lsp/language-server/config/dotfiles/completion/2023/09/10/simple-nvim-lsp-setup.html


Fix: repeatedly dereference pom variables

Previously, if there was more than one layer of variable indirection in the pom property (propert A says it has the same value as property B, property B says it has the same value as property C), then Syft would only dereference one layer. Add a loop to dereference variables until either dereferencing fails, or until the variable is completely dereferenced back to a literal.
Fixes https://github.com/anchore/syft/issues/2776
Manual testing on repro example from that issue:
❯ diff <(syft -q dir:spring-boot-empty-project | awk '{print $1 " "  $2 " " $3}') <(/tmp/syft -q dir:spring-boot-empty-project | awk '{print $1 " " $2 " " $3}')
9c9
< spring-boot-starter-actuator ${project.parent.version} java-archive
---
> spring-boot-starter-actuator 3.2.4 java-archive
11,15c11,15
< spring-boot-starter-data-mongodb ${project.parent.version} java-archive
< spring-boot-starter-security ${project.parent.version} java-archive
< spring-boot-starter-test ${project.parent.version} java-archive
< spring-boot-starter-validation ${project.parent.version} java-archive
< spring-boot-starter-web ${project.parent.version} java-archive
---
> spring-boot-starter-data-mongodb 3.2.4 java-archive
> spring-boot-starter-security 3.2.4 java-archive
> spring-boot-starter-test 3.2.4 java-archive
> spring-boot-starter-validation 3.2.4 java-archive
> spring-boot-starter-web 3.2.4 java-archive

@kzantow I changed to a recursive implementation and added more test cases to guard against degenerate pom files that have cyclic or unending variable definitions. Looking for a re-review when you have a moment. Thanks!


TypeScript import says EISDIR

I have a local project closely resembling the example code from this repo. But when I add an import statement, the builder errors with a EISDIR status. I know this means I'm pointing to a dir while I should point to anything but a dir. Any idea why this happens? If you need code, please ask and I will supply. Thanks!

A few questions:

Can you provide the config.js and tell me what you are importing.
What version of jspm are you running?
Are you type-checking and if so does the error happen when typeCheck is set to false?

After some search it turned out its the same issue as #33. Fixed it by changing some filenames.

great, thanks


Cannot Extract Maps

When I try to download the maps, I am being asked for a password for any of the Ladder or Melee Maps. I was, however, able to download the mini games with no Issue.

I cant read. they gave the password.


Sessile organisms need to produce goods to survive

See design doc for notes on how this should work.

Completed in #422.


Fix Windows CI

I had to disable Windows CI because I got failures trying to compile some shims for the LLVM C API. The problem appears to be that we should manually specify what libraries to link in Package.swift. See https://github.com/val-lang/Swifty-LLVM/actions/runs/4873453734
@C-BJ, maybe you'd like to take a look?

OK

Had to disable Windows CI again. See https://github.com/val-lang/Swifty-LLVM/actions/runs/5437320662/jobs/9887843023

Latest problem is:
Run xcopy c:\llvm-15.0.6-windows-x86-msvc17-msvcrt\include\*.* c:\program" "files\microsoft" "visual" "studio\2022\enterprise\vc\tools\msvc\14.34.31933\include /s /h
Does C:\program files\microsoft visual studio\2022\enterprise\vc\tools\msvc\14.34.31933\include specify a file name
or directory name on the target
(F = file, D = directory)?
Does C:\program files\microsoft visual studio\2022\enterprise\vc\tools\msvc\14.34.31933\include specify a file name
or directory name on the target
(F = file, D = directory)?
Error: Process completed with exit code 1.

I will fix it. And if you run into problems again, please @C-BJ . Or I'll miss it

@kyouko-taiga this issue should be closed

Thanks!
Please don't @-me on every issue and PR. I watch the all repos in the organization so I will get notified anyway.


Clean up point

This cleans up some lingering style issues with the point object.

Use one map to generate the other, to ensure a bijection.
Fail in the case of errors in unit tests.
Clean up the SGF conversion to use more-idiomatic Go-style

Fixes: #93

@mhoak @KiloLimaFoxtrot -- can you take a look and approve if it looks good?


Fixes usage of zf hydrators

Since this package is using zend/hydrator to load hydrators the interfaces
should be used from that package and not from the legacy stdlib hydrators.
This should be an hotfix on version 1.1.1 I'm no sure how this should be accomplished. I cannot create a PR to the right version.

Isn't this still a blocker for this fix?
https://github.com/doctrine/DoctrineModule/issues/546

currently 1.1.1 is broken when using the latest version of apiglity.
We are using zend\hydrator in our projects so I think this is right. Since the newer versions of the stdlib are backwards compatible by using the same interfaces. The other way around won't work.
I'm not sure if the issue you are mentioning is a blocking issue. It seems to work this way for us.

Maybe you need to read this: https://github.com/doctrine/DoctrineModule/pull/558#issuecomment-207212246
A 2.0 version of DoctrineModule is needed.

@jaapio I checked version 1.1.0. With this version I have got installed zend-stdlib 2.6 so without zend-hydrator. In version 2.1.0 we are using classes/interfaces from zend-hydrator and all seems to be fine. Therefore I am marking this issue as invalid.


expose OutputFormatEnum instead of ResultFormat to user

Resolves #447 by changing the enum that is given to the user to be the one used by Pydantic to validate user input, instead of the one that defines interactions with the backend

nice.will this break Api?

Yes. However it would only ever have worked for someone who used parquet (since by definition root was broken) and I don't think it's actually documented anywhere in our user guide (!)


fix: remove test-report.yml build pipeline

Remove the test-report.yml build pipeline as it is no longer compatible with actions/upload-artifact v4.

The actions/upload-artifact was updated to v4 with #436.


Code Editor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description
So, here I have tried to create a code editor for HTML CSS, and JS using codemirror
Fixes # (issue)
#453
Type of change
Please delete options that are not relevant.

[ ✔] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
So, it has been tested by me but there is a problem with duplicating  editors it is a kind of a bug I have already told about this to @atapas it would be great if anyone can help to resolve this bug
It is working totally fine the only problem is this extra editor 🔽

Checklist:

[ ✔] I have performed a self-review of my own code
[✔ ] I have commented my code, particularly in hard-to-understand areas
[ ✔] I have made corresponding changes to the documentation
[✔ ] My changes generate no new warnings
[ ✔] I have added tests that prove my fix is effective or that my feature works
[ ✔] New and existing unit tests pass locally with my changes
[✔ ] Any dependent changes have been merged and published in downstream modules

@yung-coder I have noticed that the build is not going through for this branch. Could you please check what's different?
Here is the build error:
4/4] Building fresh packages...
12:34:30.884 | success Saved lockfile.
12:34:30.889 | Done in 84.21s.
12:34:31.442 |
12:34:31.442 | ><EMAIL_ADDRESS>build
12:34:31.442 | > npx create-react-play -p && react-scripts build
12:34:31.442 |
12:34:33.417 | /usr/bin/env: node : No such file or directory
12:34:33.431 | Error! Command "CI= npm run build && npm run snap" exited with 127

@yung-coder the build is passing now as you have removed the package.

Okay i will change the cover image give a minute 🕜

@koustov is 30 kb enough..?

Hey @atapas i have made the changes but after that i had merge the main branch so do i have to npm new packages...?

@atapas any further modifications..?

@atapas any further modifications..?

Code wise all good. A few modification can be done to improve the look and feel. Except comments today.

@yung-coder
I have a few questions regarding the code editor

Will the JavaScript output come in the output section? Like if I do a console log? Or will it appear in the browser's console? If so, better to provide a note about it when someone is in the JavaScript Tab.
Isn't it good to clear the output area when user switch between the tabs?
The above question may not be valid if we expect the user to try HTML, CSS, and JS to type in each section and it together outputs it. Please let me know what's the expectation.
How to see the CSS output?

@atapas
No javascript output will not come in the output section but we can manipulate things through it as usual and about clearing tabs on switching is not possible as it together gives the output css output is also visible in the output section as  we try to make style changes....!
Hope i answered all your questions
if you want to know more or to make any modifications please let me know..!

@yung-coder is it ready for the final review?

Yes i have added the modal please check it if any changes to make or some content changes....!

Hey the how to play is still shows in black color to me and does not appear like a link. Also can we change the text as “How To Use?”

@atapas in which color to change it ...

Hey @atapas  so I have made the necessary changes and I think it's all good now ....


Avoid PurgeCSS to remove added classes

Classes and formats defined in stie.css or classes used in the md files

I had to do this to make it work.  For your consideration, if it is useful to you.  Regards.  Thanks for sharing this repo.

Hey, @rolojf I'm not sure I understand this PR. Are you adding classes to your MD files? Might be an edge case.

Well, yes. It is typically what tailwindcss is for. Doesn't it?
To use the utility classes to modify css during content (html) creation I mean.
I agree that sometimes, classes are going to be stated in templates in the layout folder. But some other times, be used as needed during content creation in md files.
On the other hand, custom base styles will typically be defined with @apply and they are going to be on the site.css file.  And it has to be scaned for classes that are used.
At least is what I think.

If you are using css classes in your md-files it is probably better to implement shortcodes instead. I understand what you are trying to do, but imagine on a big site, it would not be very good to have to search through all the content files on build time.


psa-crypto-sys test fail on i686

One of the tests fails when run on i686:

failures:
---- psa_crypto_binding::bindgen_test_layout_max_align_t stdout ----
thread 'psa_crypto_binding::bindgen_test_layout_max_align_t' panicked at 'assertion failed: `(left == right)`
  left: `16`,
 right: `24`: Size of: max_align_t', /builddir/build/BUILD/psa-crypto-sys-0.3.0/target/release/build/psa-crypto-sys-59266dd2c6e5c562/out/shim_bindings.rs:3:22153
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
    psa_crypto_binding::bindgen_test_layout_max_align_t
test result: FAILED. 52 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

Hello!
Thanks for reporting this! This seems to be a test generated by bindgen, after a quick google I have found a similar case here where they blocklisted the type.
I guess we could it as well as we do not need it?

It passes on aarch64/x86_64/ppc64le/armv7. If the functionality isn't used I suspect blocking it is likely the best option.

@joechrisellis fixed this, it should work now 💯

Would you like us to do a patch release?


Access to Colorado's system (SSH and github)

[x] @suryatechie
[ ] @TsungChinHanKen
[ ] @oropezaev
[ ] @taeil

Working directory: /scratch/crguest/hpt
Data folder: /scratch/crguest
Data resisc45: /scratch/crguest/data/resisc45
Total of 1.3TB free disk is available.
Processor Info:
processor       : 5
vendor_id       : GenuineIntel
cpu family      : 6
model           : 45
model name      : Intel(R) Xeon(R) CPU E5-2620 0 @ 2.00GHz
GPU status
[0] Tesla K40c       | 36'C,   0 % |     0 / 11441 MB |
[1] Tesla K40c       | 35'C,   0 % |     0 / 11441 MB |
[2] Tesla K40c       | 33'C,   0 % |     0 / 11441 MB |
[3] Quadro K6000     | 31'C,   0 % |     0 / 12205 MB |


Pipelines' created_at field actually contains the time of last update

In 1.4 pipelines have consistent IDs across updates making an original "created" (vs "updated") time particularly meaningful.
Proposal: created_at contains original creation time of a pipeline; updated_at contains the time of last update (ie what is currently in the created_at field)
Presumably both these fields should be reset if a pipeline is deleted and deployed again (as the id would change, and version would be reset to 1)

stale


Change copyright notices

Replace wordy boilerplate with SPDX license identifier and link to full license.
This is a common practice nowadays, and is a much sleeker appearance IMHO.

LGTM!


Pest + Dusk + Sail

I am trying to get this setup with a new Laravel App.
I am using Laravel sail to develop in docker and I have Pest and Laravel Dusk setup and working. (php artisan dusk --pest --without-percy works perfectly)
Now I wanted to add this but when I run php artisan dusk --pest I receive this error message:
[percy] Config file not found
[percy] created build #3: https://percy.io/1e6dcf4c/esg-radar/builds/12960345
    Error: Failed to launch the browser process!
    /var/www/html/node_modules/puppeteer/.local-chromium/linux-818858/chrome-linux/chrome: error while loading shared libraries: libnss3.so: cannot open shared object file: No such file or directory

    TROUBLESHOOTING: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md

It seems that percy does not know anything about the remote selenium instance nor how to use it.
Do you see a way we could get this working? Or is this a lost cause?

I don't know offhand. I don't use sail personally (still happy with valet) and I haven't used Pest much either. I'd happily take a PR if someone is able to troubleshoot this and provide a solution, but it's not something I'm likely to get to anytime soon.

I think we can close this, unless anyone else wants this to stay open.
I realized that there is not really the need to execute percy locally as this makes more sense on a ci.
And with github actions, after some trial and error it works perfectly now.

That's great to hear. 👍


Added 2023-12-01 preview API for Azure Load Testing Control Plane

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[X] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[X] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[X] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information
This moves the 2023-12-01-preview API version that was added in private repo to the public repository using Typespec. The changes were already reviewed and merged in this PR.
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Please remove ARMChangesRequested tag for further review after addressing comments.

/pr RequestMerge


Fix neg primitive

v0.9.8 alpha

Bug fix for power primitive triggered by https://github.com/ridgeworks/clpBNR/issues/11
Bug fix to simplify to avoid spurious unification failure debug messages.
Minor cleanups to user guide.

Fixed in v0.9.9


update podspecs version

Could you update the version in your podspec file so we can get the latest version ? (1.0.1)

1.0.1 didn't have any changes for CP users, so I didn't bother making a release. But 1.0.2 did, so I did that this morning: https://cocoapods.org/pods/Expecta#changelog


Fix text in Light Green mode

md, what have you made me do??????

You made me merge the WHOLE bettermeower repo

i'm just going to leave meower now

i'm just going to leave meower now

Bruh dont

i'm just going to leave meower now

I fixed the mistake, just try not to make it happen again


⚠ Bofrost.be has degraded performance

In 2eea442, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1046 ms

Resolved: Bofrost.be performance has improved in 672de6e after 42 minutes.


[silgen_cleanup] Add simplifications for destructures/tuple round trips and Rvalue tuple martialling

This is a pattern that comes up often when emitting code for homogeneous tuples. This just eliminates the pattern really early after SILGen to clean up/simplify the IR. All 4 transforms are tied very closely to SILGen so we do a lot of checks to restrict it to the relevant patterns. I outline the four cases below. NOTE: I split the commits into two based off of whether I was pattern matching the tuple or a destructure just since it made it easier to put it into CanonicalizeInstruction.
Case 1:

  hat(%x) = destructure_tuple(%x)
  %x2 = tuple(hat(%x))
    ->
  %x2 = %x

Case 2:

  %x = tuple(hat(%x))
  hat(%x2) = destructure_tuple x
    ->
  %x2 = %x

Case 3:

  %alloc = alloc_stack $(Klass, Klass)
  ...
  %t0 = tuple_element_addr %alloc, 0
  %t1 = tuple_element_addr %alloc, 1
  (%0, %1) = destructure_tuple %x
  ...
  store %0 to %t0
  store %1 to %t1
    ->
  %alloc = alloc_stack $(Klass, Klass)
  ...
  store %x to %alloc

Case 4:

  %alloc = alloc_stack $(Klass, Klass)
  ...
  (%0, %1) = destructure_tuple %x
  ...
  %t0 = tuple_element_addr %alloc, 0
  store %0 to %t0
  %t1 = tuple_element_addr %alloc, 1
  store %1 to %t1
    ->
  %alloc = alloc_stack $(Klass, Klass)
  ...
  store %x to %alloc

Build failed
Swift Test Linux Platform
Git Sha - 23681b063b2089c9ce015d9f35f21e5d922c3404

Failure was due to named tuple elements. I just put in some logic to skip that.

@swift-ci benchmark

@swift-ci test

Build failed
Swift Test OS X Platform
Git Sha - 5d971d488957faadb6ea656d477b71cbdeec0b33

@mikeash I am trying to reproduce the weak stress test failure on Linux 16.04 and I am not doing so. Do you have any thoughts on why this is happening? (Maybe I need to try to ssh into one of the bots). Is the test flaky in some way? Specifically the issue is:
PASS: Swift(linux-x86_64) :: Runtime/weak-reference-racetests.swift (2 of 2)

I reviewed the review comments and feel like pointing out that bootstrapping/incomplete optimizations are fine as long as they don't break SIL invariants that we want to rely on elsewhere. Namely

debug information can't affect -O output

In OSSA, all multi-value calls should be used by a single destructure. That destructure should not be removed at least until OSSA lowering. It would be nice if this were part of the SIL verifier. With true multi-value calls, the destructure just goes away and everything else remains the same. We can check a DestructureInstruction::expandsCallResults API wherever the optimizers handles destructures. Introducing a separate opcode would probably interfere with analysis in several places.


New names for the new data packs

Contenders:
drop-xp

Current: Drop XP
Always Drop XP

respawn-hunger

Current: Respawn Hunger
Respawn Sickness
Death Sickness

Names are decided. Drop XP will keep its name, Respawn Hunger will be renamed to Respawn Sickness.


Add Hebrew Locale

includes special support for "couple of years/months/days/hours" as they are different words in Hebrew.

Please fix the test case. https://travis-ci.org/crsmithdev/arrow/jobs/48505452

Thanks @andrewelkins. Good thing I had that test :smile:
https://travis-ci.org/crsmithdev/arrow/jobs/48513357

@doodyparizada Excellent :+1:

It would be better if unicode string literalls would be used in those places where Hebrew strings are present.
What do you guys think?

:+1:

:+1:

@thedrow they actually are unicode literals. If you look at the imports at the top of the file you'll see unicode_literals is imported which makes all strings in the module unicode instead of str.
In [1]: type("בדיקה")
Out[1]: str

In [2]: from __future__ import unicode_literals

In [3]: type("בדיקה")
Out[3]: unicode

@doodyparizada Oh right. Well done then :)


Too early evaluation?

What version of CUE are you using (cue version)?

$ cue version
cue version 0.4.0-beta.1 darwin/amd64

Does this issue reproduce with the latest release?
Yes
What did you do?

I am trying to circumvent the problem reported in issue 951 by avoiding dijunctions of structs, opting for optional fields, but requiring exactly one of them to be provided.
The code I come up with is shown in file test.cue below.
However, when executing cue export test.cue I get the error reported below.

-- test.cue --
#T: {
  a?: int
  b?: int

  _A: a != _|_
  _B: b != _|_

  _valid: ((!_A && _B) || (_A && !_B)) & true
}

d: #T & {a: 56}

What did you expect to see?

{
  "d": {
     "a": 56
  }
}

What did you see instead?

#T._valid: conflicting values true and false:
    ./test.cue:8:12
    ./test.cue:8:42

It looks like field _valid is evaluated very early, resulting in bottom, provoking the error message.
However, if instead of the above code I use the following (removed unification with true in _valid):

-- test.cue --
#T: {
  a?: int
  b?: int

  _A: a != _|_
  _B: b != _|_

  _valid: ((!_A && _B) || (_A && !_B))

}

d: #T & {a: 56, _valid: _, _valid2: _valid & true}

Then I get the expected result above. I.e, _valid is not computed early...

This issue has been migrated to https://github.com/cue-lang/cue/issues/955.
For more details about CUE's migration to a new home, please see https://github.com/cue-lang/cue/issues/1078.


Support armv7-linux-androideabi && aarch64-linux-android targets

Fixes:

Linker error on Servo using armv7-linux-androideabi target
Compilation error on Servo using aarch64-linux-android target

This change is

@bors-servo: r+

:pushpin: Commit 437ce48 has been approved by jdm

:hourglass: Testing commit 437ce48a9fa130e20c3064ebfbcba9917a235503 with merge 5ea83dea57a8d76efedc392e2c9ac53eac9709e7...

:sunny: Test successful - status-travis
Approved by: jdm
Pushing 5ea83dea57a8d76efedc392e2c9ac53eac9709e7 to master...


non-strict dependencies between packages

I think it's a bad idea to set non-strict dependencies between your packages. I used react-router-dom: "4.0.0-beta.4" since you've broken<EMAIL_ADDRESS>And now my react-router-dom: "4.0.0-beta.4" installed react-router: "4.0.0-beta.6" so I've got an error.

Yep, we should be doing this. A PR for this would be great (and really easy)!
Is this perhaps something Lerna can manage for us? I'll open up an issue over there to discuss.

Ah wait, I think Lerna does do this. Maybe.
@mjackson Did you do 83f3459 with just lerna publish or was that by hand?

lerna automatically manages the dependency versions for us and uses the ^. I'm going to revert 59513c9caeb31779d0d335560b254c18488771f9

But you see why that's a problem, right?

Yes, there's just not much we can do about it w/out altering lerna (unless there's some lerna flag I'm missing...). In the next release, the ^ is going to be back anyway.

@mjackson  I think the flag you're looking for is --exact
From the lerna doc

$ lerna publish --exact
When run with this flag, publish will specify updated dependencies in updated packages exactly (with no punctuation), instead of as semver compatible (with a ^).

Oh thank you! That's exactly what I was looking for.

Be aware that flag was introduced in v2.0.0-beta.33, I would have made a PR to upgrade lerna, but I saw that @mjackson reverted to v2.0.0-beta.32 for some reason.


How to do gitops with calico NetworkPolicy

Hi! We're using fluxcd in our cluster to do all the k8s deployment and configuration from git.
I want to update our configuration for use with calico network policies, and I prefer to use the calico api versions as the extension on the k8s security policies is very nice to use for larger rule bases.
How to do this? Flux doesn't know how to deal with calicoctl and having the network policies manually applied on a cluster with 10k of pods sounds very error prone and pretty much like a big pain in the neck.
I don't want to resort to additional shell scripts, ansible, terraform and other mechanisms that need to be applied straight after our cd pipeline has run as this is an outage waiting to happen and is extremely error prone as it requires manual interaction.  (And besides, using git with fluxcd works very well for everything else in the k8s landscape just not for calico).
Is there a generic way to do this without having to use calicoctl? Is there any documentation of how to avoid using calicoctl?

Hey @fliphess, thanks for raising this!
The ability to use kubectl directly to apply Calico resources is an enhancement request that we're already tracking here: https://github.com/projectcalico/calico/issues/2923
It's something I'd really like to do, but there are some subtleties that we need to work out in order to implement it. Would love if you could chime in on that issue.
I'm going to close this issue for now so we can keep discussion in one place. Thanks!


Update README

Update README with

Description
Build and Install
Usage
Contributing etc

ref

/kind good-first-issue

/assign


Apparent read socket hang on windows

When running the RsrSocketStressTest>>test1MBytes test, the test timed out with data available on the read socket. Signalling the read socket allowed the test to resume but it hung again in the same state.

Appears to be fixed by 2115ab8e6fccd545c58b7d70a567919cd23a6a17


Creating your own dataset

Hi , I am trying to train the model on my own dataset.
In what format should I  prepare my dataset?

This is described in Tutorial #09. Please watch the video and read the comments in the source-code, which describes the format.

Hi , I tried running the Tutorial 9 code for my own dataset.
It did not create a test set for any of the image folders.
I have a folder with multiple hand gestures that I want to use to train the VGG16 image segmentation  to detect hands in images.
This is the network I am using :
https://github.com/MarvinTeichmann/tensorflow-fcn/blob/master/fcn16_vgg.py

The dir-structure is described here:
https://github.com/Hvass-Labs/TensorFlow-Tutorials/blob/master/dataset.py#L59-L92
It is also discussed in the video for Tutorial #09 (I get the impression that you haven't seen it?)
https://www.youtube.com/watch?v=9sYBC2_AVfA
I'm afraid I can't help you with the VGG16 model.

Hey , yeah figured it out. I had errors because my labels were binary
images.
Thanks again ,
Looking forward to your tutorials.
Best ,
Yasha
On 25 Oct 2016 2:10 a.m., "Hvass-Labs"<EMAIL_ADDRESS>wrote:

The dir-structure is described here:
https://github.com/Hvass-Labs/TensorFlow-Tutorials/blob/
master/dataset.py#L59-L92
It is also discussed in the video for Tutorial #09 (I get the impression
that you haven't seen it?)
https://www.youtube.com/watch?v=9sYBC2_AVfA
I'm afraid I can't help you with the VGG16 model.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Hvass-Labs/TensorFlow-Tutorials/issues/3#issuecomment-255945428,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APD0U0AspzyOCFgHnW5B4_SkKLL57K_Kks5q3Z1KgaJpZM4Kd-Dz
.

Hi dear DR Pedersen
I am new in tensorflow and i wanna to creat my dataset(Logo32 filickr)4240 photos.I have 32 classes and 32 folders.I was wondering if you could help me to creat lable for my dataset. I mean a txt file for label that include like this:
img1 1(class1)
img2  2
..
Kind regard

Hi, I am new to Tensorflow : installation is done it also giving sample hardcode reply but i want intigrate this with botkit can anybody know the flow how we can do that ????
Thanks in Advance!

Hello, I am new to Tensorflow. I would like to train an image dataset for image recognition in Tensorflow. I could nt get how to train an image ourself. Please respond to this question as soon as possible because many were asking the same question

@Hvass-Labs I have watched the videos and would still like to learn how to label my own data set properly. Whether it be in a one hot encoding my own labels for my input image data set? Thank you!

Manually tagging the data is not more a hurdle. Check this out,
https://www.youtube.com/watch?v=tYqnsp-OcLQ
https://www.youtube.com/watch?v=xkSEnDIlvhI
you can quickly create your own image and video segmentation data in no time!!
Neurala’s Brain Builder Tool: https://hubs.ly/H0dkvRK0


Open getaddrinfo for public use

Open the getaddrinfo for public use. It is a beneficial function which can look up IP address from the hostname.

Thanks, @garethsb, we want it to be opened, so it is not for test code. I was thinking the same, but not sure whether to bring it into service_discovery or some other class. Okay let's do it in service_discovery, will do an update shortly.

@lo-simon depending on use case, would host_addresses be sufficient?
https://github.com/sony/nmos-cpp/blob/f7bd2f7317358123cb0685ef121ed3606c632952/Development/cpprest/host_utils.cpp#L313

@lo-simon depending on use case, would host_addresses be sufficient?
https://github.com/sony/nmos-cpp/blob/f7bd2f7317358123cb0685ef121ed3606c632952/Development/cpprest/host_utils.cpp#L313

Using the host_addresses will not be making the hostname resolution via the DNS server specified in resolv.conf configured on the device. Therefore opening up the getaddrinfo is necessary.

Hmm, that is surprising,  I thought it should use the system resolver that would use resolv.conf if configured correctly.

As discussed earlier today, it would be good to have a clear, demonstrated, use case, where using DNSServiceGetAddrInfo produces the required result but POSIX getaddrinfo (which does use nnswitch.conf and resolv.conf on Linux) via Boost.Asio via our host_addresses function doesn't.
If that is the case, this revised PR looks nice. Just a couple of questions:

can the DNSServiceGetAddrInfo callback be called multiple times to return more than one address, i.e. should the result be vector-of-address_result like the results of resolve and browse are vectors of their respective types?
is it OK to require internet access in the test code (resolving Google DNS to <IP_ADDRESS>)?

can the DNSServiceGetAddrInfo callback be called multiple times to return more than one address, i.e. should the result be vector-of-address_result like the results of resolve and browse are vectors of their respective types?

The function wrapped the mdns_details::getaddrinfo, which executes the DNSServiceRefDeallocate after receiving the 1st addrinfo to prevent any more DNSServiceGetAddrInfo callback. But the wrapped function should also be returning a vector of results as in case no mDNSResponder is used, host_addresses will be used which will be returning a list of ipaddresses.

is it OK to require internet access in the test code (resolving Google DNS to <IP_ADDRESS>)?

As it is already passing the testDnsGetAddrInfo unit test, the runner must be able to access the internet.


Example for local server Gpt4All

Hello,
thank you for great work!
My contribution is a demo to use  Gpt4All. This is a LLM that can be installed locally as a server: https://github.com/nomic-ai/gpt4all
I have modified a bit two units to compile under Delphi XE2: OpenApiJson.pas, OpenApiIndy.pas. Also added a conditional symbol INDY in OpenApiRest.pas to switch from System.Net to Indy.
Attached all files.
gpt4all.zip
units.zip

Hi @gidesa,
Thank you for the contribution. However, we have actually internally already added support for Indy for older Delphi versions.
I will push the changes and then, would you mind to review your changes to see if they still apply?
In either case, also to include gpt4all files (and maybe still modification for OpenApiJson and others, could you please open a pull request?

Commit a6d22604835929d317256c7ea46f49ec45097f4e now pushed and include changes for older Delphi versions.

Hello, thank you for fast answer.
The commit is fine, except for two things (I am using Delphi XE2, maybe not valid for others):

in OpenApiJson the "$IF compilerversion" requires "$ifend", with "$endif" there is a compilation error:
{$IF CompilerVersion < 28}
{$DEFINE USEDBX}
{$IFEND}
in OpenApiIndy, my version of Indy (10.5.8) doesn't support Http options hoNoProtocolErrorException, hoWantProtocolErrorContent.

I open a pull request on that, plus the Gpt4all example.

Thank you. Pull request merged.


Operator dropdowns are inconsistent

Type of issue

[x] Bug
[ ] New feature
[ ] Enhancement

Description
Some operator drop downs have the symbol and text. Some have just the symbol.
Consider creating a shared operator dropdown component and then use it everywhere.

I did not make a single operator drop down control because the backend values for the operators differ between ASA-Manager and Telemetry.  I did make them use the same display values.


Add Class.name

Class.name comes in handy when outputting exceptions.

solved by #2470

Suggest adding this to 1.3 notes: #3140


Custom HTML on error element

Subject of the issue
I'm trying to write very specific HTML for our validation error messages, in this specific case it's a few nested spans tags.
Your environment

jQuery Validation Plugin v1.17.0
The browser does not really matter

Steps to reproduce
This is the HTML I'm trying to achieve:

        Error
        This field is required

Can I do this with jQuery Validation? I've been trying with errorPlacement, and showErrors, but I wasn't able to make it work.
Because errorPlacement is only called once ( the first time the element is validated ), and from that point on, it just replaces the value.
For now I solved it, by simple putting the HTML around the error message, which for me isn't a very pretty solution.
If you would like, I could try to make a PR for this, creating a new option called template, which will be used to build the HTML for the error.
Thanks and best regards.

Can I do this with jQuery Validation? I've been trying with errorPlacement, and showErrors, but I wasn't able to make it work.

Yes! you can use errorPlacement as you said. You can build your custom HTML inside it and insert it after your validated element. Example:
$("form_selector").validate({
  // ...
  errorPlacement: function(error, element) {
    var customError = $([
      '',
      '  ',
      '    Error',
      '  ',
      ''
    ].join(""));

    // Add `form-error-message` class to the error element
    error.addClass("form-error-message");

    // Insert it inside the span that has `mb-0` class
    error.appendTo(customError.find("span.mb-0"));

    // Insert your custom error
    customError.insertAfter( element );
  },
  // ...
});

Hello, @Arkni !
I am facing the same problem as @TioLancaster .
I usded the code sample that you provided.
It shows an error fine, but it fails to remove/hide custom error element.
(please see the screenshot: 1 = an eror message, 2 = part of an error still stays behind)

Addapted the code a little bit (but things are essentialy as in your example)
export function validationLocale()
{
    let $app_locale = $('html')[0].lang;

    jQuery.validator.setDefaults(
    {
        lang: $app_locale,
        errorElement: 'span',
        errorPlacement: function(error, element)
        {
            let customError = $([
                '',
                '  ',
                '    Error',
                '  ',
                ''
            ].join(""));

            // Add `form-error-message` class to the error element
            error.addClass("form-error-message");

            // Insert it inside the span that has `mb-0` class
            error.appendTo(customError.find('.error-box'));

            // Insert your custom error
            customError.insertBefore(element);
        },
        highlight: function (element, errorClass, validClass)
        {
            $(element).addClass('is-invalid');
            $(element).closest('.invalid-feedback').toggle();
        },
        unhighlight: function (element, errorClass, validClass)
        {
            $(element).removeClass('is-invalid');
            $(element).closest('.invalid-feedback').toggle();
        }
    });
}

https://jsfiddle.net/onrc9de1/36/
Created jsfiddle that shows te problem.
Check by writing a name that is less than 3 or more than 25 long.

Created a question on StackOverflow

Sorry, had an error in my modifications.

Hello, @Arkni, @TioLancaster ! I am facing the same problem. I used the provided code sample. It shows an error fine, but it fails to remove/hide custom error element. (please see the screenshot: 1 = an eror message, 2 = part of an error still stays behind)

Addapted the code a little bit (but things are essentialy as in example above)
export function validationLocale()
{
    let $app_locale = $('html')[0].lang;

    jQuery.validator.setDefaults(
    {
        lang: $app_locale,
        errorElement: 'span',
        errorPlacement: function(error, element)
        {
            let customError = $([
                '',
                '  ',
                '    Error',
                '  ',
                ''
            ].join(""));

            // Add `form-error-message` class to the error element
            error.addClass("form-error-message");

            // Insert it inside the span that has `mb-0` class
            error.appendTo(customError.find('.error-box'));

            // Insert your custom error
            customError.insertBefore(element);
        },
        highlight: function (element, errorClass, validClass)
        {
            $(element).addClass('is-invalid');
            $(element).closest('.invalid-feedback').toggle();
        },
        unhighlight: function (element, errorClass, validClass)
        {
            $(element).removeClass('is-invalid');
            $(element).closest('.invalid-feedback').toggle();
        }
    });
}

Hello, @Arkni, @TioLancaster ! I am facing the same problem. I used the provided code sample. It shows an error fine, but it fails to remove/hide custom error element. (please see the screenshot: 1 = an eror message, 2 = part of an error still stays behind)

Addapted the code a little bit (but things are essentialy as in example above)
export function validationLocale()
{
    let $app_locale = $('html')[0].lang;

    jQuery.validator.setDefaults(
    {
        lang: $app_locale,
        errorElement: 'span',
        errorPlacement: function(error, element)
        {
            let customError = $([
                '',
                '  ',
                '    Error',
                '  ',
                ''
            ].join(""));

            // Add `form-error-message` class to the error element
            error.addClass("form-error-message");

            // Insert it inside the span that has `mb-0` class
            error.appendTo(customError.find('.error-box'));

            // Insert your custom error
            customError.insertBefore(element);
        },
        highlight: function (element, errorClass, validClass)
        {
            $(element).addClass('is-invalid');
            $(element).closest('.invalid-feedback').toggle();
        },
        unhighlight: function (element, errorClass, validClass)
        {
            $(element).removeClass('is-invalid');
            $(element).closest('.invalid-feedback').toggle();
        }
    });
}

hello @Rikijs excus me can you example to custom validate in under input or everywhere
you can?

@Rikijs actualy default in jquery validate in under input text no  top input text can some example in under input text?


Move React codebase to 'react' branch

Move the current main branch to react branch. We will start clean with Next.js and plain CSS for the actual development.

New ReactDev has been created to keep the old codebase as a safe checkpoint.
Also i have submitted an pull request for the new TestNextJS branch, if everything looks good, we can merge the branch to the main branch.

@tu2-atmanand great
I think we can merge Sanjay's fork into the TestNextJS version then, and keep it all under one repo for now.


Nightly creating rollback regardless if it's outdated

https://github.com/MordechaiHadad/bob/commit/a518c175235ce8547f73ff5b34ba83c652f850e1 fixed


"Crucea" is listed in the drop-down menu

Description:
"Crucea" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Crucea" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Crucea, SUCEAVA".


[opencascade] Fix feature dependence

Fix https://github.com/microsoft/vcpkg/issues/27896

Note: Change the dependency of features to the find_package() method provided by vcpkg.

[x] Changes comply with the maintainer guide
[ ] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

@FrankXie05  Please reactivate this PR once it is ready for review.

@FrankXie05 Thanks for your effort in addressing new OCCT releases and providing fixes. When is this draft ready? Also, meanwhile OCCT released v7.7.1

@paulbuechner I will complete it immediately.

@paulbuechner I will complete it immediately.

Hey, are there any updates?

Duplicate of https://github.com/microsoft/vcpkg/pull/33376


Remove CircleCI status badge

I've removed the CircleCI status badge from README.
I'm considering switching to the GitHub Actions.

Oops! Don't search who koyanagi-abby is.


Ignore build and dist folders created by pip install

Nothing too big, but helps in live pip install environments.

:+1:


Commit merges config from image, not container.

Background
#1141 reported that docker commit drops the entire config in the resulting image. Specifically, the wording was “the configuration the image had is not kept.”
#4000 landed in v0.9.1, which uses the container config as the base config for docker commit, and merges in any additional config passed by docker commit --run=….
Problem
Any command specified on the docker run command line will clobber the default command configured in the original image (config.Cmd). For example, given $image built with CMD /bin/true, running docker run $image touch /hello and then docker commit $container new_image, the resulting image will have touch /hello instead of /bin/true.
Proposal
The image created by docker commit $container $image should have its config based on $container's image, not on $container's own config.
This is more in line with the original request, to keep the config that “the image had”. It also makes it more useful for preserving Cmd, which is a prime use-case for the config-merge.
If a user wants config changes introduced by the docker run command to land in the committed image, they can pass them to docker commit --run=…. It's preferable to have to do this, compared to Dockerfile-declared configuration being clobbered.
Example
#!/bin/bash -e

docker --version

echo "Building 'clock' image with CMD /bin/date"
cat >Dockerfile <<END
FROM busybox:latest
CMD /bin/date
END
docker build --tag=clock . &>/dev/null

echo "Committing 'clock_committed' as result of 'docker run clock touch /hello'"
if [ -e cid ]; then rm cid; fi
docker run --cidfile=cid clock touch /hello
docker commit $(cat cid) clock_committed >/dev/null

echo -n "Cmd in 'clock build':  "
docker inspect --format='{{json .config.Cmd}}' clock

echo -n "Cmd in 'clock_committed': "
docker inspect --format='{{json .config.Cmd}}' clock_committed

Output (before this PR):
Docker version 0.9.1, build 3600720
Building 'clock' image with CMD /bin/date
Committing 'clock_committed' as result of 'docker run clock touch /hello'
Cmd in 'clock build':  ["/bin/sh","-c","/bin/date"]
Cmd in 'clock_committed': ["touch","/hello"]

Output (after this PR):
Docker version 0.9.1-dev, build 7767e78
Building 'clock' image with CMD /bin/date
Committing 'clock_committed' as result of 'docker run clock touch /hello'
Cmd in 'clock build':  ["/bin/sh","-c","/bin/date"]
Cmd in 'clock_committed': ["/bin/sh","-c","/bin/date"]

TODO

[x] Ensure unit tests pass.
[ ] Ensure TestMergeConfigOnCommit in integration/server_test.go reflects this change.
[ ] Ensure integration tests pass.

@vieux  It looks like this issue is still present in 1.4.1. Here is an example of CMD getting clobbered:
With this base Dockerfile
From busybox

RUN echo "foo" > /foo

CMD cat /foo

I do:
$ docker build .
Sending build context to Docker daemon 2.048 kB
Sending build context to Docker daemon
Step 0 : FROM busybox
 ---> 4986bf8c1536
Step 1 : RUN echo "foo" > /foo
 ---> Running in 7b566904f416
 ---> 76d9809edb1c
Removing intermediate container 7b566904f416
Step 2 : CMD cat /foo
 ---> Running in b61d93f8359a
 ---> 492f5228fd2e
Removing intermediate container b61d93f8359a
Successfully built 492f5228fd2e

$ docker run 492f5228fd2e
foo

Now I want to modify the file system by running some commands (real example could be updating source, building assets, changing config)
$ docker run 492f5228fd2e sh -c 'echo "bar" > /foo'
$ docker ps -a | head
CONTAINER ID        IMAGE                                       COMMAND                CREATED              STATUS                      PORTS                      NAMES
01591b73f3c5        492f5228fd2e                                "\"sh -c 'echo \"bar   17 seconds ago       Exited (0) 16 seconds ago                              elated_galileo
05d5273d2bc2        492f5228fd2e                                "/bin/sh -c 'cat /fo   About a minute ago   Exited (0) 59 seconds ago                              goofy_pasteur4

$ docker commit 01591b73f3c5
c266702eca21aadec2b2a58677be416cb4bb766eaae53515ab6f643b157a9f28

$ docker run c266702eca21aadec2b2a58677be416cb4bb766eaae53515ab6f643b157a9f28

# WHAAAT??

$ docker inspect --format '{{js .Config.Cmd}}' c266702eca21aadec2b2a58677be416cb4bb766eaae53515ab6f643b157a9f28
[sh -c echo \"bar\" \x3E /foo]

I would have expected the output of that last run to be bar, but as you can see the CMD of the new container is echo.

Yes, this makes docker somewhat useless for a fairly simple build process.
It seemed easy enough: Build a base image.  Run a command in a container to update the sources.  Commit that container to a deployable image, and push it to your repository as the latest version of the production container.
Only - when you commit, you get the command that was passed in as part of your build process, not the command in the base image that was missing sources.
Example:
# Dockerfile
FROM nginx

ADD ./nginx/nginx.conf /etc/nginx/
ADD ./nginx/sites-enabled /etc/nginx/sites-enabled/

#build-script
... setting variables...
container_name="build-$RANDOM-"`date +%s`
docker run --name $container_name -v $built_sources_dir:/mnt/app $base_runtime_image mkdir -p /app && cp -R /mnt/app/* /app

docker commit $container_name $built_image_name

docker rm -f $container_name

When I run the image with $built_image_name, it runs "mkdir -p /app" and exits.
It doesn't really make sense to create a new Dockerfile with an ADD statement here, since I want to be able to build images from multiple base images (i.e. staging/server, stable/server, etc) and have the rest of the process be the same - so we can test out upgrades before pushing to our production images.


Fixes #2489. Create new ScrollBar based on a new Scroll and remove ScrollBarView/ScrollView

Fixes

Fixes #2489

Proposed Changes/Todos

[x] Add Scroll class and unit tests
[x] Add ScrollSlider class and unit tests
[x] Add ScrolBar class and unit tests
[x] Add ScrollButton class
[x] Add @tig View.ScrollBars
[ ] Remove ScrollBarView
[ ] Remove ScrollView

Pull Request checklist:

[x] I've named my PR in the form of "Fixes #issue. Terse description."
[x] My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
[x] My code follows the Terminal.Gui library design guidelines
[x] I ran dotnet test before commit
[x] I have made corresponding changes to the API documentation (using /// style comments)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any poor grammar or misspellings
[x] I conducted basic QA to assure all features are working

I would appreciate the Scroll class being reviewed before moving forward with the ScollBar class. Thanks.

Ooooh! I'm super excited to review this! Will do asap.

The width/height of the Scroll is not limited to 1 but only to what the user wants.

@tig how about you creating a new Content or Viewport box in the AdornmentsEditor to set the foreground and background colors. Instead of using Top, Right, Bottom and Left, it can use the Axis, ContentSize or whatever. What do you think?

@tig how about you creating a new Content or Viewport box in the AdornmentsEditor to set the foreground and background colors. Instead of using Top, Right, Bottom and Left, it can use the Axis, ContentSize or whatever. What do you think?

You mean being able to set the Normal.Background/Forground color for the View itself? Like the colorpicker in Content Scrolling does?

@tig did you reorganize by placing the backfields before the properties by hand, or through some automatic system? I normally use R#'s Ctrl+E+C and it's not reformatting that way.

@tig did you reorganize by placing the backfields before the properties by hand, or through some automatic system? I normally use R#'s Ctrl+E+C and it's not reformatting that way.

By hand. It's still broken.

You mean being able to set the Normal.Background/Forground color for the View itself? Like the colorpicker in Content Scrolling does?

Yes or for the view passed on the ViewToEdit property. That's more or less the idea.

Greet idea. I'll do it as part of #3376 where I've already completely re-done AdornmentEditor. I'm going to rename it to ViewEditor as well. I also want to integrate ViewEditor into AllViewsTester because I use that a lot to audit view behaviors and being able to tweak settings live is super useful.

I just submitted another PR with quesitons / comments inline.

IMO, View sub-classes should not have the word "View" in them as a general principle. `
ScrollBarView should be ScrollBar.

IMO, View sub-classes should not have the word "View" in them as a general principle. `
ScrollBarView should be ScrollBar.

I agree, but ScrollBarView is still the old one. When the new one is created it will just be called ScrollBar.

I have to find out why if I move the scroll with the mouse one line the position changes from 0 to 9. However, returning the position to 0 with the mouse and then clicking on the Position button requires the position to reach 10 for the scroll move 1 line. It's strange, I think it should be the same value in both cases, 9 or 10, don't you think?

Also, line 11 of Scroll.cs is dangerous and we either need to seal the class or not access that property in that way in that spot.
A derived class that has overridden that member will be set by that line, and the consumer can't tell it not to without completely hiding the member, which has a completely different set of consequences.
If the implementation depends on that behavior, then the class needs to be sealed.
If the implementation will be ok as long as a derived class doesn't hide the member (which is not our problem), then it should be handled by setting the backing field - not from a virtual member accessor.

There's also an important implication of using the Size struct the way it is in View, as a Nullable<Size>, but that's for addressing elsewhere, as it's not directly related to this specific PR.
@dodexahedron (tagging so it shows up via an easy search in my queue for later performance pass consideration)

Not the fault of this PR, but as I said I would do when we got further along, a while back, I'm now giving a closer look to things like I started talking about in my review.
That stuff, when traced through just a little, ultimately reveals opportunities in the position and size code to avoid a non-trivial amount of heft from things like copies (both implicit and explicit) and possible boxing, as well as to at least somewhat mitigate potential concurrency problems. Most of that would be via ref returns and such, for internal code especially, but potentially also could be exposed to the consumer, as well.
I think it's best for that to be done separately from here, though, because of scope.

I added highlight effect in the slider. I didn't used the HighlightStyle enum because the hover isn't working.
https://github.com/gui-cs/Terminal.Gui/assets/13117724/17107090-f122-45f1-9bc9-8b5a6c5f088b
PS:
I need a ColorSchemeChanged event to intercept the change before DrawContent.

PS: I need a ColorSchemeChanged event to intercept the change before DrawContent.

Not needed I just override the GetNormalColor. Thanks @tig.

This is looking really nice!!!
Have you noticed that if you click and drag outside of the scroll bar's superview, mouse tracking gets lost? See this vid for what I mean.

This doesn't feel right to me.
Slider does this correctly:

This is looking really nice!!!

Thanks.

Have you noticed that if you click and drag outside of the scroll bar's superview, mouse tracking gets lost? See this vid for what I mean.

Yes I did.

This doesn't feel right to me.

I think this is correct. The scroll does not scroll because the X axis of the outer frame is smaller than the X axis of the scroll frame. That's why you don't see it move to the right.

Slider does this correctly:

The slider you see moves vertically because you are dealing with the Y axis and not the X axis.

I think this is correct. The scroll does not scroll because the X axis of the outer frame is smaller than the X axis of the scroll frame. That's why you don't see it move to the right.

I'm not explaining myself well.
If you move the mouse really fast outside of the view that hosts the scroll bar, mouse tracking within the scroll bar stops.

I'm not explaining myself well.
If you move the mouse really fast outside of the view that hosts the scroll bar, mouse tracking within the scroll bar stops.

Ah maybe because the MouseGrabView become null and loses the mouse tracking? I'll see that later. I cannot test that now. Can you please test the same with the vertical scroll orientation? Thanks.

I think this is correct. The scroll does not scroll because the X axis of the outer frame is smaller than the X axis of the scroll frame. That's why you don't see it move to the right.

I'm not explaining myself well.
If you move the mouse really fast outside of the view that hosts the scroll bar, mouse tracking within the scroll bar stops.

Good catch.
Man, it would be awesome if we had some automated UI testing to add this sort of thing to. Sucks only having 24 hours in a day, huh? 😅

I'm not explaining myself well.
If you move the mouse really fast outside of the view that hosts the scroll bar, mouse tracking within the scroll bar stops.

@tig this is already fixed in this commit https://github.com/gui-cs/Terminal.Gui/pull/3498/commits/9b896573ece09018ffe7502157209395b046ed7d.

I'm not explaining myself well.
If you move the mouse really fast outside of the view that hosts the scroll bar, mouse tracking within the scroll bar stops.

@tig this is already fixed in this commit 9b89657.

The only issue is when the mouse go outside of the top stopping responding. This is only happens with WT. With conhost works well. I already opened an issue in https://github.com/microsoft/terminal/issues/17744.

@tig when you have time can you please starting review this before I continue further. Thanks.

@tig do you remember any change that may cause unit test failing on macOS?

@tig do you remember any change that may cause unit test failing on macOS? It's also failing in the v2_develop branch.
[xUnit.net 00:01:26.21]     UICatalog.Tests.ScenarioTests.All_Scenarios_Quit_And_Init_Shutdown_Properly(scenarioType: typeof(UICatalog.Scenarios.DatePickers)) [FAIL]
[xUnit.net 00:01:26.21]       'Date Picker' failed to Quit with Esc after 1500ms and 0 iterations. Force quit.
[xUnit.net 00:01:26.21]       Stack Trace:
[xUnit.net 00:01:26.21]         /Users/runner/work/Terminal.Gui/Terminal.Gui/UnitTests/UICatalog/ScenarioTests.cs(109,0): at UICatalog.Tests.ScenarioTests.<>c__DisplayClass3_0.<All_Scenarios_Quit_And_Init_Shutdown_Properly>g__ForceCloseCallback|1()
[xUnit.net 00:01:26.21]         /Users/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Application/MainLoop.cs(379,0): at Terminal.Gui.MainLoop.RunTimers()
[xUnit.net 00:01:26.21]         /Users/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Application/MainLoop.cs(269,0): at Terminal.Gui.MainLoop.RunIteration()
[xUnit.net 00:01:26.21]         /Users/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Application/Application.Run.cs(587,0): at Terminal.Gui.Application.RunIteration(RunState& state, Boolean& firstIteration)
[xUnit.net 00:01:26.21]         /Users/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Application/Application.Run.cs(561,0): at Terminal.Gui.Application.RunLoop(RunState state)
[xUnit.net 00:01:26.21]         /Users/runner/work/Terminal.Gui/Terminal.Gui/Terminal.Gui/Application/Application.Run.cs(439,0): at Terminal.Gui.Application.Run(Toplevel view, Func`2 errorHandler)
[xUnit.net 00:01:26.21]         /Users/runner/work/Terminal.Gui/Terminal.Gui/UICatalog/Scenarios/DatePickers.cs(23,0): at UICatalog.Scenarios.DatePickers.Main()
[xUnit.net 00:01:26.21]         /Users/runner/work/Terminal.Gui/Terminal.Gui/UnitTests/UICatalog/ScenarioTests.cs(48,0): at UICatalog.Tests.ScenarioTests.All_Scenarios_Quit_And_Init_Shutdown_Properly(Type scenarioType)
[xUnit.net 00:01:26.21]            at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
[xUnit.net 00:01:26.21]            at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
[xUnit.net 00:01:26.21]       Output:
[xUnit.net 00:01:26.21]         Running Scenario 'UICatalog.Scenarios.DatePickers'
[xUnit.net 00:01:26.21]         Initialized 'Terminal.Gui.CursesDriver'
[xUnit.net 00:01:26.22]   Finished:    UnitTests
[xUnit.net 00:01:26.22] Canceling due to test failure..

Seems ok now?

Seems ok now?

Yes, did you do something to fix it?

Seems ok now?

Yes, did you do something to fix it?

I don't think so

I already merged your PR #3728. Thanks for the great and good changes.

@tig I think the scroll bar in the CharacterMap is a good pretext for you think better about the mouse click captured when you are moving the slider with the mouse and then release, by selecting the object where the mouse was released. In my opinion this is a bad behavior because it's doing something that we didn't intent to do it.

@tig do you understand why this strange behavior happens? The slider grabbed the mouse and is scrolling down but the decrease button is getting the OnMouseEnter and it shouldn't.

@tig this is how I pretend to implement the scroll bars into the View.

@tig this is how I pretend to implement the scroll bars into the View.

Damn, I committed without run the unit tests and now I see that instantiate the scroll bars on the initialization of the View will increase the number of view not yet disposed. Do you know the best way to workaround this?

@tig this is how I pretend to implement the scroll bars into the View.

Damn, I committed without run the unit tests and now I see that instantiate the scroll bars on the initialization of the View will increase the number of view not yet disposed. Do you know the best way to workaround this?

Haha! I was literally working on same thing this morning. I was up late last night thinking about this ;-).
See how I used Lazy<T> in my PR....

I think it's working much better now. When you have time please test it. Thanks.

I would like to maintaining the ShowScrollIndicator property because it will indicates that the visibility is false due the AutoHideScrollBar is true (visible if size is greater than the content size or invisible otherwise) and thus this check get => _showScrollIndicator && Visible; is crucial to to get the real state if the scroll visibility. If you don't agree please let me know.

I think ShowScrollIndicator is misnamed. "Indicator" should be "Bar", and "Show" is a verb, not a noun, so it's very confusing.
I do think you're correct that we need something more than just using Visible as I did in my prototype.
Here's a suggestion:
Add to ViewportSettings:
public enum ViewportSettings
{
...
    /// <summary>
    ///     If set, the vertical scroll bar (see <see cref="View.HorizontalScrollBar"/>) will be enabled and automatically made visible
    ///     when the dimension of the <see cref="View.Viewport"/> is smaller than the dimension of <see cref="View.GetContentSize()"/>.
    /// </summary>
    EnableHorizontalScrollBar = 64,

    /// <summary>
    ///     If set, the vertical scroll bar (see <see cref="View.VerticalScrollBar"/>) will be enabled and automatically made visible
    ///     when the dimension of the <see cref="View.Viewport"/> is smaller than the dimension of <see cref="View.GetContentSize()"/>.
    /// </summary>
    EnableVerticalScrollBar = 128,

    /// <summary>
    ///     If set, the horizontal and vertical scroll bars (see cref="View.HorizontalScrollBar"/> and <see cref="View.VerticalScrollBar"/>)
    ///     will be enabled and automatically made visible when the dimension of the <see cref="View.Viewport"/> is smaller than the
    ///     dimension of <see cref="View.GetContentSize()"/>.
    /// </summary>
    EnableScrollBars = EnableHorizontalScrollBar | EnableVerticalScrollBar

This moves the automatic behavior out of ScrollBar and into View and encapsulates that logic in View.ScrollBars.cs and consolodates content scrolling functionality.
If these flags are NOT set, then the developer can use view.Horizontal/VerticalScrollbar = true/false to manage visibility themselves.
What do you think of this idea?

Can I just say how much I love the work @BDisp is doing in this PR? Love. Love. Love.

@BDisp see my comment here:

https://github.com/gui-cs/Terminal.Gui/issues/464

When you nuke the old ScrollView etc..., can you please take care of IsOverriden too?

@BDisp what's the status of this PR?
In #3761 I'm fighting with the old hackyScrollView and ScrollBarView code that does a lot of unnatural things w.r.t. drawing and layout. Instead of spending time & energy fixing those things (and views that depend on them), i'd much rather have us spend time getting the new classes working well.
Thanks.

@BDisp what's the status of this PR?
In #3761 I'm fighting with the old hackyScrollView and ScrollBarView code that does a lot of unnatural things w.r.t. drawing and layout. Instead of spending time & energy fixing those things (and views that depend on them), i'd much rather have us spend time getting the new classes working well.
Thanks.

Sorry, I never worked on it again. I'm busy with some other stuff. But I'll get back to it as soon as I can.

@BDisp what's the status of this PR?
In #3761 I'm fighting with the old hackyScrollView and ScrollBarView code that does a lot of unnatural things w.r.t. drawing and layout. Instead of spending time & energy fixing those things (and views that depend on them), i'd much rather have us spend time getting the new classes working well.
Thanks.

Sorry, I never worked on it again. I'm busy with some other stuff. But I'll get back to it as soon as I can.

No problem. I'm working on it right now on top of the branch I'm using for #3798 .

No problem. I'm working on it right now on top of the branch I'm using for #3798 .

Thanks for the help. Then I'll focused on others things, ok?

Yep. Love the driver work you're doing!

I've a branch where I already removed the old scroll bars and starting the implementation with the views that were use them. But a long time ago I already have done that before and I had some tedious working on this again. But I'll see if I can reanime again to work with it.

New PR based on this great work: #3811.
Closing this one.


  Attaching a screenshot.
Feeling pretty dumb for updating to Xcode 7.3 (now that building yo works on Xcode 7.1), sorry for the bug report!

Oh, and the only thing I did was replace the icon (per the instructions in the ReadMe).

@flammable I was about to post the same thing

Yeehaw! Swift 2.2! I guess this is the fun that you experience when dealing with an actively developed language.
yo uses the CommandLine swift project to provide, you guessed it, commandline parsing. This dependency is wearing on me, however, so at some point I may rewrite it to just parse the commandline in yo itself. It was expedient at the time, but it does mean having to keep updating the included code (especially because I can never seem to get it to work as just a bundled Framework).
Anyway-give it a go now and let me know if it doesn't work. I only just installed Xcode 7.3 yesterday!

It works!  Thank you so much!
This is awesome! :trophy:


Net Exception

If I connect to two cameras simultaneously I get the error:
[ofxIPVideoGrabber:error] Exception : [bob]: Net Exception: Net subsystem not intitilized.
The first setup camera will succeed but the second (bob) will produce this error.  Do you know where in the code IpVideoGrabber might be throwing this error?
It should be noted that this doesn't actually break the functionality, it's just an error printed to the console every time the app launches.
Thanks!

Closing this as 0.9.0 is the minimum supported.


Documentation

There needs to be documentation, mainly because it's not a python package without it, but also because it's needed

Gonna be using MKdocs

It's not finished, I still need to do some proper testing

After successfully building the documentation, I will be removing the documentation branch from registering in the versions dropdown, and closing this issue


Smoke test for multi root

Fixes https://github.com/Microsoft/vscode/issues/29570
@michelkaporin fyi my first attempt to have a smoke test for multi root with a generated workspace file. This test seems to not run properly on macOS or Linux, probably due to the "-" in the file name to open. For now I am only running the test on Windows where it seems to work just fine.

Does the test fail when running on Mac OS/Linux? Does it leave any processes behind once terminated?
It would be good to have it working on all platforms with the same behaviour.

@michelkaporin let's talk later in the office


shaded.org.apache.http.conn.HttpHostConnectException: Connect to <IP_ADDRESS>:6789 [/<IP_ADDRESS>] failed: Connection refused (Connection refused)

Description
I installed jenkins 2.32.2 version and docker on Ubuntu(AWS). While configure Docker-plugin, i updated docker url as tcp://<IP_ADDRESS>:6789. This IP details i received output of ifconfig(eth0) from my machine.
I got the below mentioned error in the time of test connection. Could you please any one help to resolve this error?

already i verified many blog, i updated proeprly DOCKER_OPTS details, done export DOCKER_HOST also.

Error :
shaded.org.apache.http.conn.HttpHostConnectException: Connect to <IP_ADDRESS>:6789 [/<IP_ADDRESS>] failed: Connection refused (Connection refused)
javax.ws.rs.ProcessingException: shaded.org.apache.http.conn.HttpHostConnectException: Connect to <IP_ADDRESS>:6789 [/<IP_ADDRESS>] failed: Connection refused (Connection refused)
at org.glassfish.jersey.apache.connector.ApacheConnector.apply(ApacheConnector.java:481)
at org.glassfish.jersey.client.ClientRuntime.invoke(ClientRuntime.java:252)
at org.glassfish.jersey.client.JerseyInvocation$2.call(JerseyInvocation.java:701)
at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
at org.glassfish.jersey.internal.Errors.process(Errors.java:228)
at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:444)
at org.glassfish.jersey.client.JerseyInvocation.invoke(JerseyInvocation.java:697)
at org.glassfish.jersey.client.JerseyInvocation$Builder.method(JerseyInvocation.java:420)
at org.glassfish.jersey.client.JerseyInvocation$Builder.get(JerseyInvocation.java:316)
at com.github.dockerjava.jaxrs.VersionCmdExec.execute(VersionCmdExec.java:26)
at com.github.dockerjava.jaxrs.VersionCmdExec.execute(VersionCmdExec.java:13)
at com.github.dockerjava.jaxrs.AbstrSyncDockerCmdExec.exec(AbstrSyncDockerCmdExec.java:23)
at com.github.dockerjava.core.command.AbstrDockerCmd.exec(AbstrDockerCmd.java:35)
at ......

Are you sure there is a docker daemon running on <IP_ADDRESS>:6789? 6789 doesn't sound like a default port.
Do you get output when you run docker -H $yourIp ps? e.g.
domaster!tugboat $> docker -H <IP_ADDRESS>:2189 ps
Cannot connect to the Docker daemon at tcp://<IP_ADDRESS>:2189. Is the docker daemon running?
master!tugboat $> docker -H /var/run/docker.sock -H ps
Please specify only one -H
master!tugboat $> docker -H /var/run/docker.sock ps
Cannot connect to the Docker daemon at tcp://localhost:2375/var/run/docker.sock. Is the docker daemon running?
master!tugboat $> ls /var/run/docker.sock
master!tugboat $> docker -H unix:///var/run/docker.sock ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES

Closing due to inactivity.


dkms install fails

I have an issue when trying to install the kernel module:
root@proxmox01:~# dkms install -m nvidia -v 525.85.07
Kernel preparation unnecessary for this kernel.  Skipping...
Building module:
cleaning build area...
'make' -j24 NV_EXCLUDE_BUILD_MODULES='' KERNEL_UNAME=5.15.83-1-pve modules......(bad exit status: 2)
Error! Bad return status for module build on kernel: 5.15.83-1-pve (x86_64)
Consult /var/lib/dkms/nvidia/525.85.07/build/make.log for more information.
If I look at the log referenced above, I see a lot of errors in the form of:
...
/root/vgpu_unlock/vgpu_unlock_hooks.c:589:4: note: (near initialization for ‘vgpu_unlock_vgpu[155].num_blocks’)
  589 |  { (10 + 2 * strlen(name) + 15) / 16, /* num_blocks */     \
      |    ^
/root/vgpu_unlock/vgpu_unlock_hooks.c:770:2: note: in expansion of macro ‘VGPU’
  770 |  VGPU(0x2230, 0x151a, "NVIDIA RTXA6000-48C"),
      |  ^~~~
/root/vgpu_unlock/vgpu_unlock_hooks.c:590:4: error: initializer element is not constant
  590 |    strlen(name),                      /* name1_len */      \
      |    ^~~~~~
/root/vgpu_unlock/vgpu_unlock_hooks.c:770:2: note: in expansion of macro ‘VGPU’
  770 |  VGPU(0x2230, 0x151a, "NVIDIA RTXA6000-48C"),
      |  ^~~~
...
Is this caused by anything I screwed up?

The issue is due to the library call of 'strlen' in the helper macro.
I was able to fix it locally by adding a 'len' field in the macro for the string length, then replace strlen(name) with 'len' within the helper macro.  Then manually editing each entry with the proper length value.
So basically the VGU macro looks like this:
#define VGPU(dev_id, subsys_id, name, len) \
        { (10 + 2 * len + 15) / 16,          /* num_blocks */     \
          len,                               /* name1_len */      \
          len,                               /* name2_len */      \
          (dev_id),                          /* dev_id */         \
          0,                                 /* vend_id */        \
          (subsys_id),                       /* subsys_id */      \
          0,                                 /* subsys_vend_id */ \
          { name name } }                    /* name1_2 */

and the initializer looks like this:
static vgpu_unlock_vgpu_t vgpu_unlock_vgpu[] =
{
        /* Tesla M10 (Maxwell) */
        VGPU(0x13bd, 0x11cc, "GRID M10-0B",11),
        VGPU(0x13bd, 0x11cd, "GRID M10-1B",11),
        VGPU(0x13bd, 0x1339, "GRID M10-1B4",12),
        VGPU(0x13bd, 0x1286, "GRID M10-2B",11),
        VGPU(0x13bd, 0x12ee, "GRID M10-2B4",12),
...

That initializer is pretty long, you have to do every entry.  It took a while to edit every entry it in nano... but it worked :)

Hello, I tried to make it work according to your instructions, but I encounter another error. Do you know where the problem could be?
In file included from /var/lib/dkms/nvidia/525.105.14/build/nvidia/os-interface.c:25:
/root/vgpu_unlock/vgpu_unlock_hooks.c:790:17: warning: ‘vgpu_unlock_bar3_end’ defined but not used [-Wunused-variable]
  790 | static uint64_t vgpu_unlock_bar3_end;
      |                 ^~~~~~~~~~~~~~~~~~~~
/root/vgpu_unlock/vgpu_unlock_hooks.c:789:17: warning: ‘vgpu_unlock_bar3_beg’ defined but not used [-Wunused-variable]
  789 | static uint64_t vgpu_unlock_bar3_beg;
      |                 ^~~~~~~~~~~~~~~~~~~~
/root/vgpu_unlock/vgpu_unlock_hooks.c:788:13: warning: ‘vgpu_unlock_bar3_mapped’ defined but not used [-Wunused-variable]
  788 | static bool vgpu_unlock_bar3_mapped = FALSE;
      |             ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:297: /var/lib/dkms/nvidia/525.105.14/build/nvidia/os-interface.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1909: /var/lib/dkms/nvidia/525.105.14/build] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.15.107-2-pve'
make: *** [Makefile:82: modules] Error 2

Log file:
make.log

The issue is due to the library call of 'strlen' in the helper macro.
I was able to fix it locally by adding a 'len' field in the macro for the string length, then replace strlen(name) with sizeof(name) -1 within the helper macro. Then manually editing each entry with the proper length value.
So basically the VGU macro looks like this:
/* Helper macro to initialize the structure above. */ #define VGPU(dev_id, subsys_id, name) \ 	{ (10 + 2 * (sizeof(name) - 1) + 15) / 16, /* num_blocks */     \ 	  sizeof(name) - 1,                      /* name1_len */      \ 	  sizeof(name) - 1,                      /* name2_len */      \ 	  (dev_id),                          /* dev_id */         \ 	  0,                                 /* vend_id */        \ 	  (subsys_id),                       /* subsys_id */      \ 	  0,                                 /* subsys_vend_id */ \ 	  { name name } }                    /* name1_2 */
It worked :)
My English is poor. So I copied the answer of @eebrains . Thanks for his answer template.XD


[flah_ctrl/dv] Two small fixes regarding flash back-door access

Hi,
Two fixes featured in this PR:

Made the env config_db::set of mem_bkdr_util to be independent of implementation. Work well for partner env too.
Following Michael's response on closed PR #6770, made sure the simulation will do full words (64 bits) initializations even though the flash_ctrl transactions are in fact of 32 bits only.

Signed-off-by: Eitan Shapira<EMAIL_ADDRESS>

@eshapira, I will go ahead and merge this PR - I am unfortunately running into a private CI failure on one of my PRs that needs this fix.

Thanks!


Support for Kotlin Script Gradle files

Using this step with a build.gradle.kts produces the following output:
* What went wrong:
Script compilation error:
  Line 31:         versionCode 440
                               ^ Unexpected tokens (use ';' to separate expressions on the same line)
1 error

In kts files, the versionCode should look like this:
versionCode = 440

I can work around this for now, but it would be a good feature for the step!

Hi @weverb2,
That makes perfect sense! As a small suggestion, I'd say you should create a feature request about this on our Discuss! The reason is that people can vote for it there and we regularly check it, so there's a lot higher chance of us implementing this sooner :)

Same problem here

Hey @thomasflad, @weverb2 !
This release should fix this problem, please check and let us know if it is fixed: https://github.com/bitrise-steplib/steps-change-android-versioncode-and-versionname/releases/tag/1.2.0
🚀

I am having issues also. After migrating to Kotlin-DSL (gradle files), it says change-versioncode-and-versionname failed

Hi @mirsaidoff! Can you please send an URL about this failing build our way?


Client Allocation Request for: Hengli

Client Allocation Questions
Core Information

Name: Hengli
Website / Social Media: http://www.baacebattery.com/en/
Region: Asia excl. Greater China
DataCap Requested: 5TiB
Addresses to be Notarized: f1i7l42sbxdbiisql3pzvaz6zuncs6dd66r33jgoq
Notary Requested: rayshitou

@Esmer1 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

@Esmer1 Thanks for your application. Please answer the following questions to let me know you and your company.
1.What's your name and your position in your company?What's your company's business?
2.Could you show me your company's business license? And please show me your company searching consequence in the local business license searching website.
3.Have you/your company ever used cloud? Which platform do you use? What's your usage volume and frequency?Could you please show me your cloud usage evidence?

Hi,rayshitou
1.What's your name and your position in your company?What's your company's business?
Sorry for taking so long to reply to you，I work at Hengli as the Director of Innovative Technology Development, you can call me Nguyễn Xuân Đường(Harris)
Our company is called JIANGXI HENGLI TECHNOLOGY BATTERY CO., LTD. Our office is a branch in Vietnam. As you can see our company is a professional battery research and development to produce manufacturing.Our batteries not only are sold in more than 30 provinces and cities in China, but also exported to the Europe, USA, Japan, South Asia and other countries which has a high reputation amount our clients.
The innovation department I work in is mainly to explore some new technologies to lay the foundation for the diversification of the company,Filecoin is also one of our research projects.
2.Could you show me your company's business license? And please show me your company searching consequence in the local business license searching website.
Yes, I will send the above information to you by Email later.
3.Have you/your company ever used cloud? Which platform do you use? What's your usage volume and frequency?Could you please show me your cloud usage evidence?
We are mainly some self-built clouds, it is not convenient to send you the evidence.

It's ok.
1.What kind of data do you want to store and how much?
2.Could you please send me some demos of your data?
3.Do you agree to use the DataCap to only store data that abides by local regulations and in compliance with the recipient miner's terms of service?

Hi,rayshitou
1.What kind of data do you want to store and how much?
We wanted to store some information about our products, including videos of factory manufacturing and outdoor use, in order to better test the performance of our products
2.Could you please send me some demos of your data?
Okay I will send it to you by email.
3.Do you agree to use the DataCap to only store data that abides by local regulations and in compliance with the recipient miner's terms of service?
Yes I agree to comply

Sorry, i have not recived your company's business license and searching consequence, could you please confirm it had been sent right.
BTW, about the allocation of DataCap, i also want to know that:
1.How many miners do you want to store your data to? How much data for each miner?
2.What method/tool will you use to insperct miners? Which aspect of miners will you inspect?
3.Will you record your allocation decision in public? Which platform will you use?
4.Have you ever allocated before? If yes, how did you do when you were questioned? Any links?

Hi,rayshitou
There may have been some technical problems before, I have resent the email
1.We think 4-5 is appropriate.The maximum amount allocated to each miner will not exceed 30%.
2.We will look for a miner with a good reputation and consider the size of their storage capacity.
3.Yes,we will record our allocation decision in public,mainly Github.
4.Not yet.

Good. Finally, could you please check the business license you sent to me is right? The company has a different name.

Hi,rayshitou
Yes I checked, this is a branch in Vietnam

Hi,rayshitou
What should I do next?

I have resent it to you.

thanks, it's the one.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzacecxfys55th5fhtlvatjghqpbwg7ydq3m2gxzbt4apmcdq5vudmxgo

Address

f1i7l42sbxdbiisql3pzvaz6zuncs6dd66r33jgoq

Datacap Allocated

NaNB

Signer Address

f136bz32l2hlyad4npmfg5dngcdw3jk3tpcpoz2ja

You can check the status of the message here: https://filfox.info/en/message/bafy2bzacecxfys55th5fhtlvatjghqpbwg7ydq3m2gxzbt4apmcdq5vudmxgo


Test Section in the Feature's Pages

I've ran through your First tutorial on Coordination Numbers and Sphere's for the xyz. While the output is nice and I have a general idea of what's going on I want to also know how you tested this feature right there.
What I do for gitbook applications is split the features into three sections:

Theory
Implementation
Test

So when someone looks at this feature they know how you tested it. It doesn't have to be verbose but just a "nice to have" to give me more confidence.
If you would like I can provide a link to my unreleased gitbook to show you that.

An additional note, is this is great but what can I do with these numbers now? Which I feel will come into later applications but a good ending section for where this is used would be nice!

Hi @Sulstice,
do you think a deeper description of the atomic features is necessary? Otherwise, I'll add an additional example after publishing the application paper.

deeper description of the atomic features is necessary?

Looking back at it, no. I think you are fine. I can understand it and I'm not so much an expert in the specific area but I get what you are up too and why this is pertinent.
This isn't really a requirement, but rather a strong opinion of mine haha. I like to read through folks units tests for things so I can improve the robustness of my own - merge tests. I'm reading through your unit tests:
        f.write("Pyridine" + s)
        f.write("C 1.3603 0.0256 0.0000" + s)
        f.write("C 0.6971 -1.2020 0.0000" + s)
        f.write("C -0.6944 -1.2184 0.0000" + s)
        f.write("C -1.3895 -0.0129 0.0000" + s)
        f.write("C -0.6712 1.1834 0.0000" + s)
        f.write("N 0.6816 1.1960 0.0000" + s)
        f.write("H 2.4530 0.1083 0.0000" + s)
        f.write("H 1.2665 -2.1365 0.0000" + s)
        f.write("H -1.2365 -2.1696 0.0000" + s)
        f.write("H -2.4837 0.0011 0.0000" + s)
        f.write("H -1.1569 2.1657 0.0000" + s)

If I read your docs, as a cheminformatician, this is just a "nice to have" tiny detail and it might or might not prove useful to me.
For my stuff, I usually, have a list of compounds of varying complexity and try to guess what the user might input to test the robustness of my code - but I've built these test systems mimicking off RDKit, design stuff from last gig, biopandas and so on which help validate my own claims. Gives my software some backing. Does that make sense?
validation that a CN really represents the count of covalent bonds for an atom in a molecule

This part would come from the scientific community, I think, as they use your package after publication.

Yes, there is an application paper on the way where we use the features to predict several properties like chemical reactivity or retention times for chromatography applications

Awesome! don't forget to update these docs when that comes out haha. I bet a lot of future users would appreciate it.

Hi @Sulstice,

If I read your docs, as a cheminformatician, this is just a "nice to have" tiny detail and it might or might not prove useful to me.
For my stuff, I usually, have a list of compounds of varying complexity and try to guess what the user might input to test the robustness of my code - but I've built these test systems mimicking off RDKit, design stuff from last gig, biopandas and so on which help validate my own claims. Gives my software some backing. Does that make sense?

It does and it is always useful to add tests depending on wrong or erroneous user input. I'll expand the unit test according to such inputs, however, this takes some time and I guess the publication of the software as it is at the moment shouldn't be postponed due to the missing tests, shouldn't it? :)

validation that a CN really represents the count of covalent bonds for an atom in a molecule

This part would come from the scientific community, I think, as they use your package after publication.

From the scientific part, it has been shown in earlier works that the CN actually represent the covalent count within a molecule (see, e.g., Grimme2010 or  Caldeweyher2019).

Yes, there is an application paper on the way where we use the features to predict several properties like chemical reactivity or retention times for chromatography applications.

Awesome! don't forget to update these docs when that comes out haha. I bet a lot of future users would appreciate it.

Sure, as soon as the paper appears I'll update the docs and list some "real-life" use-cases ;)

Ya I can get behind that. Thanks for the references - helps me understand it a lot better.
Yeah, I wouldn't postpone publication of the software for your current tests now. They are good enough for the first pass and will naturally develop over time :) I'm actually more happy you wrote some good starting tests.
Alrighty, I think I am satisfied haha and will approve for publication.


Flaky test in Project Euler Problem 73

Describe the Issue
I've seen CI failing with the following error multiple times:

The error can be seen here: https://github.com/freeCodeCamp/freeCodeCamp/actions/runs/6767753123/job/18391337467?pr=52236#step:9:2571.
Affected Page
I'm not sure if this is also an issue in /learn, but here is the link to the challenge: https://www.freecodecamp.org/learn/project-euler/project-euler-problems-1-to-100/problem-73-counting-fractions-in-a-range.
Link to the code: https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/18-project-euler/project-euler-problems-1-to-100/problem-73-counting-fractions-in-a-range.md.
Steps to Reproduce
I haven't tried reproducing the issue locally, but I think running test:curriculum multiple times on that challenge would surface it.
Expected behavior
The test should always pass.

When it's a random failure like this, it means that the loop-protect timeout has been exceeded. Unless the solution algorithm is obviously terrible (and it isn't to me), then I think it's fine to delete the offending test.

At one point there was @jeremylt trying to go through the various solutions and optimize them, maybe he can take a look here too? Or just let do without that test.

I fixed up the ones with prime numbers. I can take a look at this one and see if a better algorithm is out there