Remove kubeVersion argument to bundle reader

It wasn't being used anywhere anyway.
Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Both kubeVersion and cliVersion are required to bootstrap eks-anywhere release binary. Please reference this:
https://github.com/aws/eks-anywhere/blob/d0a42e7dd823206683983f29049eaaaecaa7f81d/pkg/dependencies/factory.go#L847

I respectfully disagree, and here's why:
Excluding tests, the method you've referenced is called only once:
func NewDependenciesForPackages(ctx context.Context, opts ...PackageOpt) (*dependencies.Dependencies, error) {
	config := New(opts...)
	return dependencies.NewFactory().
		WithExecutableMountDirs(config.mountPaths...).
		WithExecutableBuilder().
		WithManifestReader().
		WithKubectl().
		WithHelmInsecure().
		WithCuratedPackagesRegistry(config.registryName, config.kubeVersion, version.Get()).
		Build(ctx)
}

One can see that the call doesn't use cliVersion from the BundleReader, but rather calls version.Get() directly. Likewise, the kubeVersion is not pulled from BundleReader, but rather it uses the value passed on the command-line directly.
Can you think of other places these might be used? I haven't been able to find any.

Both kubeVersion and cliVersion are required to bootstrap eks-anywhere release binary. Please reference this:
https://github.com/aws/eks-anywhere/blob/d0a42e7dd823206683983f29049eaaaecaa7f81d/pkg/dependencies/factory.go#L847

I respectfully disagree, and here's why:
Excluding tests, the method you've referenced is called only once:
func NewDependenciesForPackages(ctx context.Context, opts ...PackageOpt) (*dependencies.Dependencies, error) {
	config := New(opts...)
	return dependencies.NewFactory().
		WithExecutableMountDirs(config.mountPaths...).
		WithExecutableBuilder().
		WithManifestReader().
		WithKubectl().
		WithHelmInsecure().
		WithCuratedPackagesRegistry(config.registryName, config.kubeVersion, version.Get()).
		Build(ctx)
}

One can see that the call doesn't use cliVersion from the BundleReader, but rather calls version.Get() directly. Likewise, the kubeVersion is not pulled from BundleReader, but rather it uses the value passed on the command-line directly.
Can you think of other places these might be used? I haven't been able to find any.

Here is a reference to the usage: https://github.com/aws/eks-anywhere/blob/dd1d7227035041fbf8cc041947a8143b979717c2/pkg/curatedpackages/defaultregistry.go#L25

Both kubeVersion and cliVersion are required to bootstrap eks-anywhere release binary. Please reference this:
https://github.com/aws/eks-anywhere/blob/d0a42e7dd823206683983f29049eaaaecaa7f81d/pkg/dependencies/factory.go#L847

I respectfully disagree, and here's why:
Excluding tests, the method you've referenced is called only once:
func NewDependenciesForPackages(ctx context.Context, opts ...PackageOpt) (*dependencies.Dependencies, error) {
	config := New(opts...)
	return dependencies.NewFactory().
		WithExecutableMountDirs(config.mountPaths...).
		WithExecutableBuilder().
		WithManifestReader().
		WithKubectl().
		WithHelmInsecure().
		WithCuratedPackagesRegistry(config.registryName, config.kubeVersion, version.Get()).
		Build(ctx)
}

One can see that the call doesn't use cliVersion from the BundleReader, but rather calls version.Get() directly. Likewise, the kubeVersion is not pulled from BundleReader, but rather it uses the value passed on the command-line directly.
Can you think of other places these might be used? I haven't been able to find any.

Here is a reference to the usage:
https://github.com/aws/eks-anywhere/blob/dd1d7227035041fbf8cc041947a8143b979717c2/pkg/curatedpackages/defaultregistry.go#L25

I don't see anything related to BundleReader in that reference. Can you explain your reasoning? All the changes in this PR affect BundleReader only.
That reference does appear to be use pkg/manifests/reader.go's Reader which has similar, but distinct, functionality.
Or am I misunderstanding something?

Apparently removing code somehow lowers our test coverage?!? I call shenanigans (aka rounding error?) @g-gaston do you know anything about this? I can probably figure out a way to add a test, but I shouldn't have to for this, should I?


Updated the Library to correctly show the GetTerminal method

That first commit went wonky when I pulled so I had to do the second commit to even update it. not sure why it posted to the Github
The Library now properly contains the required "GetTerminal" method

Looks good


It is not disabling enaugh services

So im willing to add more services for it to disable.

Fixed in 1.3 BETA


fixes bug 1292686 - download transcripts

Coverage decreased (-0.005%) to 86.083% when pulling 96c7afe46ad72bf79665793883021dd69c3cfed1 on peterbe:bug-1292686-download-transcripts into d5c1cff2e15d6f61e84c9eea83133079bf7acf92 on mozilla:master.


Instalation issue on ubuntu

I'm getting the error on first step ie Setup repository
Err:8 https://dist.crystal-lang.org/apt crystal InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 09617FD37CC06B54

Do you use 18.04? When I try to install Crystal with 18.04, I get this error too. You should try 16.04. For me everything works in 16.04.

No! I'm using 17.10. I tried to follow manual steps but facing issue in that
Unpacking crystal (0.27.0-1) ...
dpkg: error processing archive /tmp/apt-dpkg-install-tR5b15/6-crystal_0.27.0-1_amd64.deb (--unpack):
 unable to open '/usr/share/doc/crystal/api/index.json.dpkg-new': Operation not permitted
Errors were encountered while processing:
 /tmp/apt-dpkg-install-tR5b15/6-crystal_0.27.0-1_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

@amitguptagwl So the first error came from running the setup script https://dist.crystal-lang.org/apt/setup.sh? Unfortunately that one's different from the manual steps in that it refers to a key hosted on keys.gnupg.net which has already caused some issues. Not sure if that's related.
The second error looks like a hiccup in the apt installer. It seems that the key validation has succeeded at least.
Try apt purge crystal && apt install crystal to reinstall the package.

Sorry it didn't work
$ sudo apt install crystal
Reading package lists... Done
Building dependency tree
Reading state information... Done
Suggested packages:
  libxml2-dev libgmp-dev libyaml-dev libreadline-dev
The following NEW packages will be installed:
  crystal
0 upgraded, 1 newly installed, 0 to remove and 5 not upgraded.
Need to get 0 B/38.0 MB of archives.
After this operation, 176 MB of additional disk space will be used.
(Reading database ... 348764 files and directories currently installed.)
Preparing to unpack .../crystal_0.27.0-1_amd64.deb ...
Unpacking crystal (0.27.0-1) ...
dpkg: error processing archive /var/cache/apt/archives/crystal_0.27.0-1_amd64.deb (--unpack):
 unable to open '/usr/share/doc/crystal/api/search-index.js.dpkg-new': Operation not permitted
Errors were encountered while processing:
 /var/cache/apt/archives/crystal_0.27.0-1_amd64.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)

$ ll -h /var/cache/apt/archives/crystal_0.27.0-1_amd64.deb
-rw-r--r-- 1 root root 37M Nov  2 20:50 /var/cache/apt/archives/crystal_0.27.0-1_amd64.deb

$ sudo gdebi /var/cache/apt/archives/crystal_0.27.0-1_amd64.deb
Reading package lists... Done
Building dependency tree
Reading state information... Done
Reading state information... Done

no description given
Do you want to install the software package? [y/N]:y
(Reading database ... 348764 files and directories currently installed.)
Preparing to unpack .../crystal_0.27.0-1_amd64.deb ...
Unpacking crystal (0.27.0-1) ...
dpkg: error processing archive /var/cache/apt/archives/crystal_0.27.0-1_amd64.deb (--install):
 unable to open '/usr/share/doc/crystal/api/index.json.dpkg-new': Operation not permitted
Processing triggers for man-db (<IP_ADDRESS>-2) ...
Errors were encountered while processing:
 /var/cache/apt/archives/crystal_0.27.0-1_amd64.deb

I've also tried chmod +655

Any insight on what might be causing this error in /usr/share/doc/crystal/api? I'd like to think this is some apt/dpkg issue and not necessarily caused by the Crystal package. Might be wrong though.
FYI you can also install the binary directly without apt: https://crystal-lang.org/docs/installation/from_a_targz.html

i just setup a new wsl instance and am unable to install crystal on it;
rishav@rishav-sbook:/mnt/c/Users/risharan$ curl -sSL https://dist.crystal-lang.org/apt/setup.sh | sudo bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  6896  100  6896    0     0   4932      0  0:00:01  0:00:01 --:--:--  4936
gpg: can't connect to the agent: IPC connect call failed
Hit:1 http://archive.ubuntu.com/ubuntu focal InRelease
Hit:2 http://archive.ubuntu.com/ubuntu focal-updates InRelease
Hit:3 http://security.ubuntu.com/ubuntu focal-security InRelease
Hit:4 http://archive.ubuntu.com/ubuntu focal-backports InRelease
Get:5 https://dist.crystal-lang.org/apt crystal InRelease [2496 B]
Err:5 https://dist.crystal-lang.org/apt crystal InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 09617FD37CC06B54
Reading package lists... Done
W: GPG error: https://dist.crystal-lang.org/apt crystal InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 09617FD37CC06B54
E: The repository 'https://dist.crystal-lang.org/apt crystal InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
rishav@rishav-sbook:/mnt/c/Users/risharan$ sudo apt install crystal
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package crystal
rishav@rishav-sbook:/mnt/c/Users/risharan$

Manually adding the key also doesnt works;
rishav@rishav-sbook:/mnt/c/Users/risharan$ curl -sL "https://keybase.io/crystal/pgp_keys.asc" | sudo apt-key add -
gpg: can't connect to the agent: IPC connect call failed

This seems to be a gpg issue. Which gpg package are you using? Make sure to remove gpg/gpg1 and use gpg2.

After some investigation, I think this is the issue; https://github.com/microsoft/WSL/issues/5125
I installed ubuntu 20.04 on wsl1 which is not supported.
I will try to get on wsl2 tomorrow and see if everything works fine there


Remove foreground notification if related unfulfilled incoming payment has been removed from db

Fixed in https://github.com/btcontract/wallet/commit/b8d77771b2447b273f7fbf3509b1b7cf1fe264ac.

This needs more careful handling since foreground notification will also be there when we have active routed payments, we don't want to occasionally remove it by deleting a payment card.


Is v5 planned for this package?

Is v5 planned for this package or should I look for other solutions?

+1

+1

Is v5 planned for this package or should I look for other solutions?

I'm was rewritten the alpha version for Adonis v5 TypeScript. You can try this
https://www.npmjs.com/package/adonis-bumblebee-ts

Is there any update on this? Is this project abandoned, or is there another solution for v5?

It is not abandoned. But I probably won't update it for Adonis 5 since I don't have any projects with v5. I wound not be able to support it.

It is not abandoned. But I probably won't update it for Adonis 5 since I don't have any projects with v5. I wound not be able to support it.

Would a PR be fine? I can work on porting the project to V5 and raise a PR if you're okay with it

The problem isn't porting it to v5, but providing proper support. Since I'm not using v5, I won't be able to really test it, ensure good developer experience, and quickly react to a bug.
I think it depends on how much work is required to support v5. If the interface remains largely the same and just a few changes are required for compatibility I'm fine with merging a PR. But if it requires basically a complete rewrite I don't think it wound be a good idea.
I'm open for input.

Is v5 planned for this package or should I look for other solutions?

I'm was rewritten the alpha version for Adonis v5 TypeScript. You can try this
https://www.npmjs.com/package/adonis-bumblebee-ts

will check on this one.  I used bumblebee for v4 and was amazing.


close() is file descriptor specific so use end() instead.

Thanks @sfescape, can you add a test that fails before and passes after this change?

LGTM!   Thanks @sfescape


--not queries are broken

http://stackoverflow.com/questions/31011624/media-queries-composing-not-with-or
Also: they straight up don't work.

ah well.


Powershell: Write-Host throws an error

If I do this: Write-Host "hello", I get this error:
Write-Host : A command that prompts the user failed because the host program or the command type does not support user interaction. Try a host program that supports user interaction, such as the Windows PowerShell Console or Windows PowerShell ISE, and remove prompt-related commands from command types that do not support user interaction, such as Windows PowerShell workflows. at run.ps1: line 1

I assume you're trying to write some debug output to logs, not to an output binding? @tohling what is the right way to do that?

Correct -- just trying to write out to the logs. I can get around it by just using a string by itself "hello" but thought others may be using Write-Host, especially if they're trying to re-use existing scripts.

You mean to write a console entry, you just put a string "hello" on a single line?

Yeah -- here's my script that logs:
for($i=1; $i -le 10; $i++)
{
    "powershell running " + $i
    Start-Sleep -s 1
}

Probably by design, but we'll let Ling confirm

Yes, you will not be able to use Write-Host as Functions operate in a multi-tenant environment and PowerShell commands will not be able to interact directly with the host.  Use Write-Output instead.

Close by design

Why do I find this AFTER I spend 2 hours bashing my head :'(
Let's put that in the documentation.

@johnnliu, yes we will provide a more comprehensive set of documentation soon.  Thank you for your patience.


On-device-training fails using Tflite_runtime: Node number 54 (FlexReluGrad) failed to prepare.

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Custom embedded Linux distribution (Kernel 5.15)
Mobile device: Raspberry Pi 4B
TensorFlow installed from (source or binary): Source (Building on Tflite_runtime using pip_package scripts)
TensorFlow version (use command below): 2.7.0
Python version: 3.8
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): 9.3 (OpenEmbedded GNU Toolchain)
CUDA/cuDNN version: N/A
GPU model and memory: N/A

Describe the current behavior
I am following the tutorial on how to do on-device-training. The first step was to create and train the Fashion_mnist model on google Colab which was successful since I managed to download as an output the tflite model after converting (I made sure to mention all the necessary signatures while saving the model). The documentation is providing an example only on Java for android Apps, but I'm trying to explore whether this is feasible with tflite_runtime wheel.
I sent then the tflite model to the target (raspberry pi) where the Tflite_runtime has been installed using this article and I'm trying to run the training function by feeding my neural network with arrays of zeros just to prove that it is working. This is the code snippet I'm running on my target.
import numpy as np
import struct as st
import tflite_runtime.interpreter as tflr
nImg = 10000
nR = 28
nC =28
images_array = np.zeros((1, 28, 28), dtype="float32")
labels_array = np.zeros((1,10), dtype="float32")
modelpath="fashion_mnist_model.tflite"
interpreter = tflr.Interpreter(modelpath)
signatures = interpreter.get_signature_list()

print('Signature:', signatures)
>>> Signature: {'infer': {'inputs': ['x'], 'outputs': ['logits', 'output']}, 'restore': {'inputs': ['checkpoint_path'], 'outputs': ['dense_1/bias:0', 'dense_1/kernel:0', 'dense_2/bias:0', 'dense_2/kernel:0']}, 'save': {'inputs': ['checkpoint_path'], 'outputs': ['checkpoint_path']}, 'train': {'inputs': ['x', 'y'], 'outputs': ['loss']}}

train = interpreter.get_signature_runner('train')
infer = interpreter.get_signature_runner('infer')
train(x=images_array, y=labels_array)

The script fails at the train function call and return the following traces:
`RuntimeError: Select TensorFlow op(s), included in the given model, is(are) not supported by this interpreter.
Make sure you apply/link the Flex delegate before inference. For the Android, it can be resolved by adding "org.tensorflow:tensorflow-lite-select-tf-ops" dependency.
See instructions: https://www.tensorflow.org/lite/guide/ops_select
Node number 54 (FlexReluGrad) failed to prepare.`

Describe the expected behavior
The expected behavior is to get a complete and functional training on target.
Any help would be appreciated, thank you in advance.

Another (probably helpful) and relevant information, delegate/flex sources seems to integrated in the  _pywrap_tensorflow_interpreter_wrapper.so as it can be shown below:
root@rpi:~# nm -a /usr/lib/python3.8/site-packages/tflite_runtime/_pywrap_tensorflow_interpreter_wrapper.so   | grep -i "Flex"
001552c8 W _ZN11flexbuffers10KeyCompareIhEEiPKvS2_
001552d8 W _ZN11flexbuffers10KeyCompareIjEEiPKvS2_
001552d0 W _ZN11flexbuffers10KeyCompareItEEiPKvS2_
001552c0 W _ZN11flexbuffers10KeyCompareIyEEiPKvS2_
0011a360 W _ZN6tflite19AcquireFlexDelegateEv
00123a74 T _ZN6tflite8IsFlexOpEPKc
002c3194 r _ZN6tfliteL21kFlexCustomCodePrefixE
001557b0 W _ZNK11flexbuffers9Reference7AsInt64Ev
001f4300 W _ZNK11flexbuffers9Reference8AsDoubleEv
002c4860 u _ZZN11flexbuffers3Map8EmptyMapEvE9empty_map
0011a1bc t _ZZN6tflite19AcquireFlexDelegateEvENUlP14TfLiteDelegateE_4_FUNES1_

@ahlzouao ,
I was facing different error while executing the code.Please find the gist of it here.Please provide the complete code and dependencies to reproduce the issue.Thanks!

@tilakrayal ,
Thank your for your answer, I have prepared a a gist here with the whole code.
Unfortunately, it is working just fine in the google colab environment and the train function returns the expected value, so that's not really the way to go. If you want to reproduce exactly the same issue, I would suggest you run the code on target by doing the following:

Run the notebook in the link I sent you,
then from Files section download the fashion_mnist_model.tflite file.
Send this model file to your board (Raspberry Pi for example) via scp or any other file transfer protocol.
From your board's terminal, run the following command.
BOARD$ pip3 install tflite-runtime
Then you will need to open a Python prompt
BOARD$ python3
Type the following instructions:

import numpy as np
import struct as st
import tflite_runtime.interpreter as tflr
images_array = np.zeros((1, 28, 28), dtype="float32")
labels_array = np.zeros((1,10), dtype="float32")
modelpath="fashion_mnist_model.tflite"
interpreter = tflr.Interpreter(modelpath)
signatures = interpreter.get_signature_list()
print('Signature:', signatures)
train = interpreter.get_signature_runner('train')
infer = interpreter.get_signature_runner('infer')
train(x=images_array, y=labels_array)

That's the output showing the error:
`RuntimeError: Select TensorFlow op(s), included in the given model, is(are) not supported by this interpreter.
Make sure you apply/link the Flex delegate before inference. For the Android, it can be resolved by adding "org.tensorflow:tensorflow-lite-select-tf-ops" dependency. See instructions: https://www.tensorflow.org/lite/guide/ops_selectNode number 54 (FlexReluGrad) failed to prepare.`

@ahlzouao ,
I was using colab to reproduce the issue.Can you please provide the  tf-lite file along with the code which you are facing issue.It helps to debug the issue.Thanks!

@tilakrayal ,
The issue is not reproduceable on google colab, it will work as expected with no errors. You will need to run it on an armv7 or aarch64 architecture target to reproduce the issue, since the goal of this is to do on-device-training. Here is a link to the tf-lite file.

@sachinprasadhs ,
I was able to execute the code in colab without any issues.Please find the gist of it here.

@tilakrayal @sachinprasadhs
I already mentioned that the code will run without any issues on Google Colab and the issue is not reproduce-able on its environement, I'm actually facing the issue while running the code on device (on a raspberry Pi aarch64 architecture). The bug might be in the tflite-runtime python wheel of aarch64.

Hello @sachinprasadhs ,
Have you been able to reproduce the issue on some device ? I can confirm you that it is reproduce-able on both armv8 and armv7 architectures.
Thank you in advance,

Hello @MeghnaNatraj , @sachinprasadhs
I'm doubting this is isn't a bug but more of a missing feature. I have tried an interesting experimentation, I tried running the same script on my x86 host machine with no tensorflow package installed, only the tflite-runtime Python pip_package installed, this reproduces the same issue. After installing Tensorflow package, the error traces disappear. This made me think about some operation features missing in the interpreter I build using CMake.
I was trying to add debug some traces into the tensorflow source code to be able to figure it out. I have reached some conclusions:

The traces I added were mainly near the intepreter function and allowed me to notice that the FlexReluGrad had no prepare function as you may notice below:

[DEBUG][PrepareOpsStartingAt]:[1003]: Node index: 54
[DEBUG][OpPrepare][957]:Entering function ...
[DEBUG][OpPrepare][959]:Op having a null prepare function
[DEBUG][OpPrepare][962]:Unresolved custom op ...

Based on the documentation, in order to do on-device-training, it is necessary to add the Flex Delegate to the interpreter during the build and select some tensorflow ops so the FlexOps could be understood by the interpreter (Hence the error, I'm getting each time : Node number 54 (FlexReluGrad) failed to prepare.
By getting a closer look inside the libtensorflow-lite.a generated by  CMake, I can see that none of the flex delegate function has been integrated in the build since the variable TFLITE_DELEGATES_FLEX_SRCS is empty.
By digging deeper inside the Bazel BUILD scripts, I was trying to duplicate the same build dependencies and sources to build using CMake. I have also noticed that many dependencies from tensorflow/core/framework are used.

=> To make it short, I'm trying to build a shared library containing the flex delegates with the with_select_tf_ops=true but using Cmake instead of Bazel since it's not an option for me. This may be pushed as a new feature in the tensorflow/lite/CMakeList.txt  upon completion, so I'm looking for some guidance on the dependencies and sources to build for that purpose.

@haozha111 triaging for on-device related issues.

Hi,
Sorry for the late reply. ReluGrad isn't a supported built-in op of TF Lite. So you will need to link in the Flex delegate to make it able to run on-device.

Hello @haozha111,
First of all, thank you for your reply.
That's what I figured out, then I tried to build a new libtensorflow-lite-flex.so library with the Flex Delegates and the necessary TF Ops kernels (ReluOp, SaveOp and RestoreOp in this case) using SELECTIVE_REGISTRATION Mode, but the build does not seem to be working properly for aarch64 as stated in this issue.
Also, do you have a clearer example on how to link the flex delegate to my interpreter ? I tried doing this :
//Building the FlexDelegate instance
       auto delegate = tflite::FlexDelegate::Create();

       //Building the interpreter
       std::unique_ptr<tflite::Interpreter> interpreter;
       builder(&interpreter);

       // Modifying the graph with the FlexDelegate instance
       if(delegate){
            interpreter->ModifyGraphWithDelegate(std::move(delegate));
      }

For now, I cannot tell if it is working properly or not because I still don't have a properly working shared library libtensorflow-lite-flex.so to link against.
Thank you for your support,
Othmane

Will https://github.com/tensorflow/tensorflow/issues/52018 help you resolve the build issue?

Hello @haozha111,
Sorry, I was mistaken in the link of the issue. The one I mentioned was actually closed and the #52018 did help, hence it was closed. The issue I'm facing during the build is related to some dependency "icu". A ticket has been opened in here but no answers so far.
Thank you again for your support,


Status doesn't apply on orders of out of stock products

Expected behavior
In Prestashop, when you have out of stock products (with 0 quantity in stock), you can still sell them with a native option called "Allow ordering of out-of-stock products".
With this option enabled, when you sell an out of stock product, the transaction will first be registered the the status "Payment accepted", then directly after, a new status is apply called : "Awaiting replenishment".
The transaction should be registered like that in the back-office.
Actual behavior
After a successful payement of an out of stock product, the order is in the back-office but without status on it.
I tested on a new fresh Prestashop in <IP_ADDRESS> and I still have the problem.

The problem appear only on orders of products which have 0 quantity in stock (or less).
Steps to reproduce the behavior
Purchase a product with 0 quantity in stock with the native Prestashop option enabled that allows you to do that.
I think you plugin doesn't support the native functionality which allow customer to purchase out of stock products.
It is here: Preferences > Products > Allow ordering of out-of-stock products
Environment

PrestaShop version: <IP_ADDRESS>
Mollie module version: 3.4.5

PHP version: 7.1.26

Its supported but the problem is that PS 1.6.0.* versions have different logic and statuses for out of stock products. We will see what we can do to fix this issue for PS1.6.0.* versions. For now only way to fix is to upgrade to PS1.6.1 version.

Thank you for you reply. We unfortunately can't upgrade to 1.6.1 right now.
We are waiting for news from your part.

We found a work around. For legacy PrestaShop versions which do not have 'On backorder (Paid)' or 'On backorder (Not paid)' order statuses, the module will create and use them.
We created a new zip for you, please try it and let us know if it works. Please delete the old module version before installing because the module update will not create new statuses.
molliePreRelease.zip

Thank you. The plugin seems to work properly.

In the native Prestashop, first it apply the status "Payment accepted", then few seconds after, if the product is out of stock, the status "On backorder". Could you do the same?
It is important because, we send an e-mail via the Payment accepted status and we hide the backorder one.

Why do you create new status (instead of using the native ones? Could you use the native ones?
The Prestashop <IP_ADDRESS> has a native backorder status (that you can't delete).

Thanks for your work.
Ps : I attach you a screen of a backorder.

We changed it to use only native statuses like you suggested. Please check if everything is alright and lets us know.
molliePreRelease.zip

Well done @margud and to all your team! Working perfectly!


Auto generate memory.x

This PR adds ld feature, which enables the memory.x generation and prevent issues like #215.

I was thinking about maybe adding the ld feature to the default features, as well as the rt feature. This should be much more user friendly initially and experienced user can turn of default features anyways.
But I think, this is a discussion for later. Let's first release a version with memory.x auto-generation and wait for feedback. Just a note for the future.


Docker check-mk 2.2 fails to pre-compile after mkp install of pure 1.4.5

The error message reads:
Error precompiling checks for host PURE.STORAGE.HOST: Cannot find check file agent_pure needed for check type agent_pure.
So I went into the checks directory and found pure_agent but not agent_pure. I just renamed it and then it worked.
$ cd /omd/sites/cmk/local/share/check_mk/checks
$ mv pure_agent agent_put

Is fixed in 1.4.7, can you check if that breaks something? In your case, you may need to remove your agent_pure you created with mv because that can cause a conflict.


Access Code Table, Model, and Validation Endpoint

Description
This PR introduces the initial work of the Golden Ticket technical epic that Team Roci will be completing. This technical epic is focused on creating "golden tickets" (known in product land), or access codes. These access codes will be distributed to service members onboarding to the MilMove platform. These access codes will be used to keep track how many moves are currently ongoing at any time.
This PR specifically accomplishes:

Creates the migration that will create the Postgres RDS table.
Creates the model file that describes the model and its attributes.
Creates the /accesscode/valid?code={code}, where code="PPM-223423", to validate the access code.

Reviewer Notes
Inline comments
Setup

make db_test_reset
make db_test_migrate
Run Tests

make server_test will run all the tests

Code Review Verification Steps

[x] Code follows the guidelines for Logging
[x] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[x] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)

[x] Request review from a member of a different team.
[x] Have the Pivotal acceptance criteria been met for this change?

References

Pivotal story for this change

Thanks for the comments, requested changes, and sketching up that diagram @mkrump! I think you meant to say this PR deals with #2 above, just wanted to clarify! Thx again!


Starting out with attrs, adding some basic types and docs. (@Schalk1e)

Description
Modernising some aspects or rdw-ingestion-tools. Adding attrs and typing and starting some semi-decent docstrings.

TODO: (So I don't forget) Ditch httpx_close in wrapper class and use context manager instead.

There's some discussion (mostly around the async case) here: https://github.com/encode/httpx/discussions/1552

We have a slight issue with implementing the httpx client in a context manager.
We're instantiating client in __init__ .py and importing the instantiated client in main.py. It is then passed to the individual endpoints as Inbounds(session), FAQMatches(session) etc. If we use the client in a context manager inside get_paginated, it means we'd have to re-instantiate by re-importing for consecutive API calls. For instance:

Reimporting won't rerun the top-level module code, so that won't get you a new client. However, the examples in the discussion I linked imply that it's safe to use a single client as a context manager multiple times (assuming that applies to the sync case as well, which I expect it does). Have you seen evidence to the contrary?
Also, the maintainer says that using a single client instance for the lifetime of the app is also fine (and is, in fact, preferred in most circumstances) so maybe we can just not close it at all and let the destructor handle that at shutdown?


Neither collection or item deposits are completing

I tested creating a new collection this morning and creating a new item in an existing collection and neither one of these processes is completing.

The item deposit produced a honeybadger error.

Here's the honeybadger report from the email (I'm not seeing a ticket that was generated from this):
Error detected in: happy-heron (stage)
Full report at https://app.honeybadger.io/projects/77112/faults/78457297
RuntimeError: There was an error with your request: {"id":"bad_request","message":"{"accession"=>true, "type"=>"http://cocina.sul.stanford.edu/models/object.jsonld\", "label"=>"Amy's test data deposit", "version"=>1, "access"=>{"access"=>"world", "download"=>"world"}, "administrative"=>{"hasAdminPolicy"=>"druid:zw306xn5593", "partOfProject"=>"H2"}, "description"=>{"title"=>[{"value"=>"Amy's test data deposit"}], "contributor"=>[], "event"=>[{"type"=>"creation", "date"=>[{"value"=>"2019/2020", "encoding"=>{"code"=>"edtf"}}]}], "form"=>[{"structuredValue"=>[{"value"=>"Data", "type"=>"type"}, {"value"=>"Tabular data", "type"=>"subtype"}], "type"=>"resource type", "source"=>{"value"=>"Stanford self-deposit resource types"}}, {"value"=>"Data sets", "type"=>"genre", "uri"=>"https://id.loc.gov/authorities/genreForms/gf2018026119\", "source"=>{"code"=>"lcgft"}}, {"value"=>"dataset", "type"=>"genre", "source"=>{"code"=>"local"}}, {"value"=>"Tables (data)", "type"=>"genre", "uri"=>"http://id.loc.gov/authorities/genreForms/gf2014026186\", "source"=>{"code"=>"lcgft"}}, {"value"=>"MODS resource types", "type"=>"resource type", "source"=>nil}, {"value"=>"text", "type"=>"resource type", "source"=>{"value"=>"MODS resource types"}}], "note"=>[{"value"=>"This is an abstract", "type"=>"summary"}, {"value"=>"Hodge, A. (2021). Amy's test data deposit. Stanford Digital Repository. Available at :link:", "type"=>"preferred citation"}<EMAIL_ADDRESS>"type"=>"contact", "displayLabel"=>"Contact"}], "subject"=>[{"value"=>"keyword", "type"=>"topic"}, {"value"=>"another keyword", "type"=>"topic"}], "relatedResource"=>[]}, "identification"=>{"sourceId"=>"hydrus:object-13253"}, "structural"=>{"contains"=>[{"type"=>"http://cocina.sul.stanford.edu/models/resources/file.jsonld\", "label"=>"This is my data file", "version"=>1, "structural"=>{"contains"=>[{"type"=>"http://cocina.sul.stanford.edu/models/file.jsonld\", "label"=>"This is my data file", "filename"=>"test.txt", "size"=>11, "version"=>1, "hasMimeType"=>"text/plain", "externalIdentifier"=>"eyJfcmFpbHMiOnsibWVzc2FnZSI6IkJBaHBBOTh0Snc9PSIsImV4cCI6bnVsbCwicHVyIjoiYmxvYl9pZCJ9fQ==--e250905a777b0c94ed830798485e2b3ac8c19d2c", "hasMessageDigests"=>[{"type"=>"md5", "digest"=>"63b8812b0c05722a9d6c51cbd2bfb54b"}, {"type"=>"sha1", "digest"=>"5d39343e4bb48abd97f759828282f5ebbac56c5e"}], "access"=>{"access"=>"world", "download"=>"world"}, "administrative"=>{"publish"=>true, "sdrPreserve"=>true, "shelve"=>true}}]}}], "isMemberOf"=>["druid:rm901qm7678"]}} isn't one of in #/paths/~1v1~1resources/post/requestBody/content/application~1json/schema"}
Summary
Trace

@hannahfrost FYI for beta testing.

we've disabled the descriptive metadata roundtrip validation flag, which fixes this issue in the short term and allows beta testing to proceed.
as follow on work, we'll

add a specific flag for disabling roundtrip validation only for H2 (to allow stricter checking for everything else sooner, see sul-dlss/dor-services-app#2583)
enable roundtrip validation in DSA for everything besides H2
fix the bad H2 descriptive metadata mappings
re-enable roundtrip checking for H2


[jvm-packages] eta parsing error

Operating System: Ubuntu 16.04
Compiler: g++
Package used:  jvm-package specifically xgboost4j and python-package
xgboost version used: 0.7
gcc version:  gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
Issue:
I ran an experiment using the data 'dermatology.data' in the folder demo/multiclass_classification. I created an script on java that make the same that  /demo/multiclass_classification/train.py. When I compare the results using as error logloss when the objective function was multi:sofmax on each language were:
Java:
[0]	test-mlogloss:1.791759	train-mlogloss:1.791759
[1]	test-mlogloss:1.791759	train-mlogloss:1.791759
[2]	test-mlogloss:1.791759	train-mlogloss:1.791759
[3]	test-mlogloss:1.791759	train-mlogloss:1.791759
[4]	test-mlogloss:1.791759	train-mlogloss:1.791759
Python:
[0]	train-mlogloss:1.54662	test-mlogloss:1.57447
[1]	train-mlogloss:1.35498	test-mlogloss:1.39797
[2]	train-mlogloss:1.19883	test-mlogloss:1.25218
[3]	train-mlogloss:1.06734	test-mlogloss:1.13098
[4]	train-mlogloss:0.955641	test-mlogloss:1.03268
In this experiment the eta is equal to 0.1 but the results of the logloss in java are the same than when the eta is equal to 0.
what I discovered is that the locale of my operating system was setting up to use ',' as the separator between the integer part and the decimal part of a real number insted of '.' and that cause that the parser of the params in the c++ code truncate the eta from 0.1 to 0 and in general truncated any value x.y to x.
So I did a quick fix setting up the locale to en_US.UTF-8 in xgboost4j.cpp to obligate c++ to use that locate to identify '.' as the separator of the integer and decimal part of a real number. That fix worked for me but I think that is better if you can do something in the parsing code of the parameters to improve the library and it can take in account this type of discrepancies.
Thanks

I think this is a similar issue: https://github.com/dmlc/mxnet/issues/5056. It's related with std::stof and std::stod.

I'm experiencing the same isssue

@manfredcalvo  Where in the code did you perform your locale edit? Would it be enough to just change a environment variable?

@bnoreus I changed the locale to en_US.UTF-8 in the environment variables (e.g. LC_NUMERIC, LC_MONETARY...) and that worked. But I think it shouldn't depend on the environment, there should be locale-independent parsing functions to do that since Java will always convert a float to a string with dot as the decimal separator and that can cause unwanted exceptions.

@manfredcalvo  Thank's a lot! This probably saved me so many hours of work. I got it to work for me by setting this in my .bashrc
LANG=en_US.UTF-8
LANGUAGE=en_US.UTF-8
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=en_US.UTF-8
But I agree with you. This should be fixed. I also think there are installation errors related to this problem.  Instead I ended up with this problem)


Improved UX of the theme switcher

So I was looking at the page on my mobile and wasn't able to switch the theme initially. First I thought there were some event handlers missing, but it turned out that hit area of the switcher was limited to one small circle-button, which required very precise aiming.
Then I looked at it on my desktop and got a similar bad experience. Here the circle-button, to switch the theme, actually moves away from the cursor when trying to hit it. So you end up in a second click, hunting for the "right" circle. With "right" I mean the circle which will indeed change the theme the other state. The other circle is deactivated, which leaves you with an additional task to understand the logic behind it.
Since all you want to do is to change the theme from dark to light or vice versa, the answer to this broader UX/UI problem is, that we are actually having a toggle/switch element here.
The switch should have:

a large hit area
the click event switches between the dual state

no matter where you hit it

So I changed the UX behaviour of this custom element to behave like a switch. Which solves the problems on mobile & desktop and improves the common user experience.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: cpietsch sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Great improvement! I also had a problem clicking the small circle 😄
Deployed here: https://join-dev-design-mkphqdalvv.now.sh

Thank you! Nice improvement.

U welcome


Add optional timeout to tests?

Does it seem useful to have a timeout option on tests? For example, a third parameter to it:
it("should do something", [&](){
      AssertThat(something, IsTrue());
}, 10);

where this indicates a timeout of 10 seconds (or whatever). By default, there could be no timeout, or a user can set a default timeout via a command line parameter.
I'm imagining a use case where bandit is part of CI tests, and we don't want infinite looping tests.

(or should this be something that's handled at a higher level, such as in the CI tool, or in the command running the tests?)

I think this would add complexity to bandit without enough gain to be warranted. My suggestion is to either handle this in your build system or in your tests.


Bonelab Crashes on XR loading

When using this software, Bonelab crashes. Log file tells you what happened.
XR_APILAYER_NOVENDOR_nis_scaler.log
Is it because I need to download it in the drive that has the game?

NIS scaler is no longer maintained.
Use https://mbucchia.github.io/OpenXR-Toolkit/ instead. It works great with Bonelab.


I can't use autoload.php in composer

I use composer to install this program, but I can't use it directly. I got following error:
Fatal error: Class 'Dir' not found in /var/www/html/index_csl.php on line 24

Hi, you need to add the required use statement at the top of your php file use Lead\Dir\Dir; to be able to use it.

You need to add it

Hi, you need to add the required use statement at the top of your php file use Lead\Dir\Dir; to be able to use it.

You need to add this in README. Because it's not obvious. Thanks


When using copy API for multiple commit runs, cannot persist to volume in image

Description
sorry for the poor title; but basically, if you do this:
Dockerfile (we call this image 'broken' below):
FROM debian
VOLUME /var/tmp

docker create --name cont broken
docker cp foo cont:/var/tmp
docker commit cont broken
docker run -it broken ls /var/tmp

No output because the file is not there; it was saved in the volume created by the image directions.

Steps to reproduce the issue:

See above
Test example
Watch in wonder

Additional information you deem important (e.g. issue happens only occasionally):
I'm happy to write a patch for this, but it seems like it could go a few ways:

patch to docker build to implement the old NOVOLUME or VOLUME [] suggestions to clear volumes from the list, and an equivalent API to do so (I would really prefer this method)
Changes to docker cp or docker commit to manage the volume reference in a persistent way
Changes to docker create to explicitly ignore mounting volumes (this is the most elegant, but less practical than the build solution IMO)

Output of docker version:
1.12.3

alternatively, we could just have a way to manipulate runconfig in a way that did it. that would allow both #1 and #3.

like, set nil on the volumes map to inherit, and an empty map should not inherit. any other data is an overwrite.
I hope that's sensible.

This was proposed/attempted before, see https://github.com/docker/docker/pull/11183, https://github.com/docker/docker/pull/8803, and https://github.com/docker/docker/pull/7133
I'm not sure this could still be changed, and am afraid we're stuck with the current behavior; some users actually use this as a "feature" to exclude files from the final image
/cc @cpuguy83

This is all pretty stanky, but I agree having this on create is going to be required (in hostconfig), I think.

Yeah. I presumed retaining the original behavior / provide a flag for the new behavior. Sorry if I wasn't clear on that.
From a pure API perspective, I think this is the runconfig (which is docker/engine-api/types/container.Config now right? it's been a long time, sorry) which would of course cascade into the hostconfig on create.
As for the API itself, would you prefer:

a new struct member to toggle this behavior
an empty array in the Volumes runconfig could trigger this behavior too. a nil could mean inherit. Easier to write, for sure. Not sure if it's more elegant or not, but it plays on the behavior of the volumes config already, at least as I understand how it works.

As for the question of whether the behavior is necessary or not, it's hard to make build tooling for docker without this. I literally have code that looks like this in the latest release:
for _, volume := range Volumes {
  if strings.HasPrefix(mypath, volume) {
    return fmt.Errorf("can't touch this")
  }
}

Which I hope we can agree is unacceptable. :)

dun dun dun dun

I know it's the holidays, just wanted to ping and hope for the best. :)


About the default root password

The root user password for anbernic stock OS defaults to root

thx I tried that and it didn't work for me, maybe my ssh config was still not ok. will test and adapt

Thank you for your excellent work


csi-node-driver ImagePullBackOff missing imagePullSecrets

Im using below link to use a private registry, however it seems the imagePullSecrets is not set for the daemonSet csi-node-driver.
https://projectcalico.docs.tigera.io/maintenance/image-options/alternate-registry
Other calico pods is up and running and get imagePullSecrets  in the deployments and daemonSet.
kubernetes v1.24.4
calico version 3.24.1

@Josh-Tigera could you take a look at this one? Sounds like perhaps we're missing logic to include pull secrets for this daemonset?
Double check we don't need docs updates in that linked doc as well.

Sure yeah, likely just an oversight on my part when implementing this.


New package: PredictMDFull v0.7.0

Registering package: PredictMDFull
Repository: https://github.com/bcbi/PredictMDFull.jl
Created by: @DilumAluthge
Git reference: register/PredictMDFull/v0.7.0
Version: v0.7.0
Commit: e44d5af913997a500a8974f85ef9bf99d58caab2
Reviewed by: @DilumAluthge
Reference: https://github.com/bcbi/PredictMDFull.jl/commit/e44d5af913997a500a8974f85ef9bf99d58caab2#commitcomment-33571784

Bump.
The 3 day cool down period has completed. Could someone please merge?


Need update from Microsoft.CodeAnalysis.VisualBasic.Workspaces 2.9.0 to 2.10.0

Nuget gives error when installing Buildalizer.WorkSpaces.
A reference to VisualBasic.Workspaces 2.9.0 is fixed and it would by necessary to update to 2.10.0.
(Or create two separate packages... one for CSharp and another to VB)

I'm not sure I understand. Why is the reference to Microsoft.CodeAnalysis.VisualBasic.Workspaces version 2.9.0 causing problems? Do you already have version 2.10.0 installed and NuGet is complaining that installing Buildalyzer would downgrade? Any chance you could post the NuGet install log with the error?

@daveaglick I just hit the same issue, it's because we use Microsoft.CodeAnalysis.CSharp ourselves. We resolved it as suggested by visual studio, by explicitly installing Microsoft.CodeAnalysis.Common in our project:

I forgot to comment but there is too big a difference in signatures for Microsoft.CodeAnalysis.Common 3.4 to be compatible with Microsoft.CodeAnalysis.CSharp.Workspaces 2.9 so I actually never did fix the problem.
Because we use Microsoft.CodeAnalysis.CSharp with an up-to-date version we are unable to use Buildalyzer.Workspaces. I would very much like to be able to use it.

Fixed by #124


Structure stuff

Mostly new structure generation stuff. Some javadocs on hard-to-comprehend areas. Closes #2725.

I was mapping this exact thing 🤦🏼 See https://github.com/apple502j/yarn/tree/21w39a-structure for my WIP stuff
One thing, I believe StructurePiecesHolder's javadoc ("holder of generated structure pieces") is incorrect now (unless it means "naturally-generated structures"). From what I can tell class_6626 implements Holder and that class is definitely doing generation stuff (e.g. changing bounding box). class_6624 is the class that holds already-generated pieces.

@apple502j ah, that's unfortunate! Feel free to nitpick my pr, pointing out bad names (and feel free to suggest better ones if you have any!)

Mojang refactored method_37896 a bit in 21w44a. It now takes a ChunkPos instead of two ints.

Interesting, but unfortunately I am still quite busy recently and this will stay outdated and wip for a while

Updated to 1.18-pre1 and fixed some stuff: https://github.com/apple502j/yarn/tree/pr-2729-structure

Updated to 1.18-pre1 and fixed some stuff: https://github.com/apple502j/yarn/tree/pr-2729-structure

feel free to open a pr either to here or me.


Rust IDE Issues (VSCode, Atom)

Hello.
I can't get VSCode or Atom to work with Rust properly (in a productive way). This seems to be a very widespread issue:

Latest VSCode
Rust Beta (rustc 1.41.0-beta.1 (eb3f7c2d3 2019-12-17)) Same issue with other versions
rls 1.41.0 (8f1c275 2019-12-10)
Rust extension: Rust (rls)
Script running extension: Code Runner

Basically cargo run works just fine and runs the project. But VSCode can't figure out where crates are:
Code:
use rand::Rng;

fn main() {
    let rnd_num = rand::thread_rng().gen_range(1, 100);
    println!("Random number: {}", rnd_num);
}

cargo run from terminal:
[jurisl@JurisLinuxPC game]$ cargo run
    Finished dev [unoptimized + debuginfo] target(s) in 0.01s
     Running `target/debug/game`
Random number: 54

Errors when running from code editor:
error[E0432]: unresolved import `rand`
 --> main.rs:1:5
  |
1 | use rand::Rng;
  |     ^^^^ maybe a missing crate `rand`?

error[E0433]: failed to resolve: use of undeclared type or module `rand`
 --> main.rs:4:19
  |
4 |     let rnd_num = rand::thread_rng().gen_range(1, 100);
  |                   ^^^^ use of undeclared type or module `rand`

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0432, E0433.
For more information about an error, try `rustc --explain E0432`.

Adding extern crate rand; results in the same error:
error[E0463]: can't find crate for `rand`
 --> main.rs:1:1
  |
1 | extern crate rand;
  | ^^^^^^^^^^^^^^^^^^ can't find crate

error: aborting due to previous error

For more information about this error, try `rustc --explain E0463`.

Changing edition = "2018" - Does not help.
Restarting RLS/VSCode - Does not help.
NOTE:

The exact same issue is present in Atom editor.
Autocomplete almost does not work:

Basically, out of two editors (VSCode and Atom), that have Debugging capabilities, unlike Intellij Rust, both don't work for me and I just can't code in Rust as tools are literally broken/not mature enough for productive work. Please let me know if I am wrong and it is just a case of one little flag, that everyone forgets to mention, is missing in some config.

@RebelCoderRU for better autocomplete you probably want to use https://github.com/rust-lang/rls-vscode instead (or https://rust-analyzer.github.io/ if you are adventurous)
See https://github.com/editor-rs/vscode-rust/issues/391 for details.


Bug: Blank B glitch in Region Shuffle when riding OOT Epona into a shuffled loading zone

What it says in the title. If you ride Epona into a shuffled loading zone in the overworld, the next time you come back to OOT, all of your equipment and items will be unequipped from Link.  You still "have" it but it's not actually there on your B button. Making the seed unbeatable.
This is a critical issue as it can lead to seeds being unintentionally unbeatable if someone doesn't know about this.

Fixed by 0c43c0b and 7fe562


Do not add loading class if in error

Codecov Report

Merging #719 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
+ Coverage   99.72%   99.72%   +<.01%
==========================================
  Files         264      264
  Lines        6795     6796       +1
  Branches     1583     1584       +1
==========================================
+ Hits         6776     6777       +1
  Misses         19       19

Impacted Files
Coverage Δ

src/components/tables/Table.tsx
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6db96...5b9079b. Read the comment docs.


support add prefix to files

Thanks for grunt-manifest, its super convenient :)
In case I did not put .appcache file in the root folder, for example:
I have a grunt config looks like
manifest: {
      generate: {
        options: {
          basePath: "../",
          preferOnline: false,
          verbose: true,
          timestamp: true
        },
        src: [
            "public/osx/*.html"
        ],
        dest: "public/osx/manifest.appcache"
      }
    }

The generated appcache file looks like
CACHE MANIFEST
# This manifest was generated by grunt-manifest HTML5 Cache Manifest Generator
# Time: Thu Mar 14 2013 21:52:50 GMT+0800 (CST)

CACHE:
public/osx/index.html

the offline cache will try to fetch wrong public/osx/public/osx/index.html instead of  correct /public/osx/index.html.
but what I really want is to have CACHE files with / as prefix.
/public/osx/index.html

instead of
public/osx/index.html

to prevent some miss reference issue.

Closing for #31


Add cleanBounds to highs_wrapper

Ref issue #306:

... presolve gives machine precision inconsistency in bounds of 0.4 so that LB>UB (by 5.551e-17).
Added method cleanBounds to remove such minor inconsistencies [less then primal feasibility tolerance] in bounds after presolve and return error if large.

Additions to Highs.cpp and HighsLpUtils.h that should be reflected in HighsLpUtils.pxd and highs_wrapper.pyx.

No changes required for cython wrappers


No component matched warning for non-pin type fuel

When using non-pin type fuel, the user is warned on "No component matched" for Flags.WIRE and Flags.CLAD. It is not clear where the warning is originating from or what can be done to fix it.
This is occurring in a non-standard fast reactor benchmark (BFS-73-1), where there are no pins/clad defined and the core uses a stack up of "disks" or "plates".
[info] Will expand CR, FE, H, NI, SI, TI, O, NA, AL, MN elementals to have natural isotopics
[info] Constructing assembly `Inner Fuel 0 Rods`
[warn] No component matched Flags.WIRE in <Homogenized UO2 Aluminum Can Reflector Pellet: 0 SS Bars block-bol-000 at ExCore XS: B BU GP: A>. Returning None
[warn] No component matched Flags.CLAD in <Homogenized UO2 Aluminum Can Reflector Pellet: 0 SS Bars block-bol-000 at ExCore XS: B BU GP: A>. Returning None
[info] Constructing assembly `Inner Fuel 1 Rods`
[info] Constructing assembly `Inner Fuel 2 Rods`

Oof sorry about that. That is most likely coming from a residual call to b.getSmearDensity, probably at armi/reactor/blocks.py:813:40:            self.p.smearDensity = self.getSmearDensity().
We've modeled BFS-73-1 before too and surely got the same warning. That shouldn't happen at the framework level so I'll see what we can do to move that call into a more specific pin-type fuel plugin.
For the time being, I can at least assure you that you can safely ignore the warning. The code just won't have a meaningful value set to the block-level smearDensity param.
Thanks for the report.

I wonder if these types of reports for calculating design-specific information, like smear density, should be the responsibility of the reports plugin where the API could expose certain functions to call based on the design(s) being analyzed.
Things like smear density, hydraulic diameter, wetted perimeter, etc. are design type specific but also depend on user modeling choices. Providing a warning indicates that there is a problem with the input, but maybe this is a choice by the user to not model a grid for a block and just to treat it as a homogenized blob.
I think we should discern between real warnings and input suggestions in the logging. This is somewhat related to how we handle the settings validation too. It's probably worth considering a separate log for this information rather than the stdout log or a different message verbosity (i.e., note) especially since warnings can be easily overlooked if there are too many that don't have actionable feedback to the user.

I had never seen this ticket before, so sorry I'm late to the party.
First off, Nick was correct, the error happens in Block.completeInitialLoading() on this line:
https://github.com/terrapower/armi/blob/15e313850c6f71d47f3fde5ec1d047a9fadb7c43/armi/reactor/blocks.py#L790
The real problem here is that this is a method on the Block base class that assumes the Block is pinned. As @drewj-tp recently pointed out, there should be another layer of abstraction here, like PinnedBlock that could have the pin logic here moved into it.
A stop-gap measure would be to insert a check in getSmearDensity() to see if the Block in question is pinned:
if self.getNumPins() == 0:
    return 0.0


Sync workers with global lock

compare to my last pull request
1, use global sync lock instand of lock_counter and release_counter in tensorflow. speed up counter access and prevent not zero problem.
2, fix a sync bug. Clipped_ppo_agent for example
if int(batch.size / self.ap.network_wrappers['main'].batch_size) is different between each workers, some worker will be in acting phase and other workers will be block in wait_for_all_workers_barrier

is this replacing #347?

Yes for my prj


OAuth Scopes Issues

Trying to set up Google OAuth login it seems KafkaCenter is not setting scope parameter properly.
Config value:
generic.scopes=https://www.googleapis.com/auth/userinfo.profile https://www.googleapis.com/auth/userinfo.email

Google returns:
Error 400: invalid_request
Missing required parameter: scope

not support google OAuth

Do you plan on supporting Google OAuth any time soon?

This non-core feature, so the open source version will not be developed


Getting DDoS errors

I'm following the tutorial for ASP.Net Core 3.1 and getting DDoS errors for the responseString coming back from http://mywebapi/WeatherForecast.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7aee46f8-9db1-33ef-b637-fc8e8881fab9
Version Independent ID: 6c469f9f-9751-669f-3dd4-c4fb49c9ae19
Content: Multicontainer tutorial using Docker Compose & ASP.NET Core - Visual Studio
Content Source: docs/containers/tutorial-multicontainer.md
Product: visual-studio-windows
Technology: vs-azure
GitHub Login: @ghogen
Microsoft Alias: ghogen

@derekgreer -- Derek, thank you for your feedback.  It looks like you're having an issue with the product itself, rather than an issue with the documentation. Here are a few options you might consider:

https://social.msdn.microsoft.com/Forums/vstudio
https://www.stackoverflow.com
https://www.reddit.com/r/VisualStudio/

You are also welcome to use the Report a Problem tool to report the issue.
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.


Please describe any compilattion flags needed to build MIR on different platforms

Hi,
I am using a CMake build to make MIR - and I  kind of reverse engineered what was needed from MIR Makefile, but this was a while back. I think it would be useful if there was some description of the build flags needed to compile MIR on various platforms.
Thanks and Regards
Dibyendu

Currently, MIR support 4 targets (x86_64, aarch64, ppc64be/le, s390x).  There are no target specific flags.  The target specific code is chosen through target specific macros of host compiler (GCC/Clang).
The project code uses C11 features.  Therefore it needs -std=c11.  C2MIR code assumes that char is signed.  Therefore it needs -fsigned-char.
There are additional options -fno-tree-sra and -fno-ipa-cp-clone for GCC because some GCC versions have bugs in the corresponding optimizations affecting MIR code.
Plus MacOSX needs the additional include directories $(shell xcrun --show-sdk-path)/usr/include.

Okay thank you.
How about flags like MIR_NO_IO, MIR_NO_SCAN, etc.?
Regards

How about flags like MIR_NO_IO, MIR_NO_SCAN, etc.?

I would say they are internal macros now.  They might become public for some specific applications (very constrained by code size).

Okay thank you


BatchCancelContracts fails with large number of contracts

Describe the bug
when using the tfchain go-client BatchCancelContract on devnet with large number of contracts it fails with failed to cancel contracts: failed to submit extrinsic: Invalid Transaction. I tried with 1578 and it fails while 1000 works.
To Reproduce

Create 1500+ contract.
Cancel with BatchCancelContract. (tfcmd might be helpful)

Expected
To cancel the given contracts or return an error describing what the problem with the number of contracts.

The error message transaction invalid returned from the rpc client indicates that the pool rejected the transaction as invalid. This can happen for multiple reasons, as described in the Substrate documentation (transaction-lifecycle).
In this case, the rejection is likely related to the allowed block weight. Weights are used to manage the time it takes to validate a block and to characterize the time it takes to execute the calls in the body of a block. If you try to submit a huge extrinsic, it will fail during the check phase without applying the extrinsic to avoid making the chain stuck.
I can dedicate more time to researching this if there are strict requirements to do so. However, please keep in mind that we have configured a block time of 6 seconds, and some percentage of that time is reserved for operational tasks. I cannot guarantee how much improvement can be made, if any.

In this case, the rejection is likely related to the allowed block weight.

I agree with this diagnosis, should be because of the weight of this composed transaction compared to block weight.
And it will be the case for any composed transaction depending on the number of considered repetitions.
So not sure it is an issue because of the large number used here, not sure we will have this case in practice.
If it is working for canceling 1000 contracts it should be enough.

It's unrealistic indeed to have more than 1000 contract batched at the same time so we can limit it to 1000 per batch for now. But thanks for your comments. Will close the issue now.


added utility function to calculate degree heating days

Could go either way. Think we'll be calling these apis from within this function?


Visibility Certification Testing for ArcMap 10.7.1

Prerequisites
Visibility (ArcMap)
Install the Visibility Add-In
Install Visibility.esriAddIn by clicking on the Add-In

[x] On the Esri ArcGIS Add-in Installation Utility, check the following:

Name, Author, Description
Version
Digital Signature(s)

[x] Click "Install Add-In" and the Add-In successfully installs.
[x] Launch ArcMap, verify the Military Tools Toolbar is automatically added to ArcMap.
[x] Add the Open Visibility button to the toolbar.
[x] On the ArcMap Add-in Manager, verify the add-in information for the Military Tools add-in.

Visibility Add-in
Visibility Add-in Prerequisites:
To test the Visibility Add-in, you will need the following types of data:

Local raster elevation/surface data
Local mosaic dataset with elevation data
Remote elevation service (See: Note 2)

Some important caveats/limitations for using this data in the add-in to perform visibility analysis:

The elevation data must be in a projected coordinate system
The spatial reference of the the map and the elevation data must be the same

Notes:

Sample elevation data is available at: https://github.com/Esri/military-tools-geoprocessing-toolbox/tree/dev/testdata/Elevation
Currently the elevation service must be a local area of interest (not country or world-wide) - see Issue: https://github.com/Esri/visibility-addin-dotnet/issues/175

Visibility Add-in Pane

[x] From the ArcMap Customize Menu, select Customize Mode and locate the visibility button under Commands | Add-in Controls
[x] Add the visibility button to an existing toolbar, click the button
[x] Visibility pane will open
[x] LLOS, RLOS tabs are shown

Test with Several Elevation Types
Run the test procedures below on several different elevation data types including:

[x] Local elevation/surface data
[ ] Local mosaic dataset with elevation data
[ ] Remote elevation service

Visibility Test Procedures for each Elevation Data Type
Linear Line of Sight(LLOS)
Run linear line of sight tool with each elevation data type. Set multiple:

Observer points
Target points
Offset values
Measurement Units

Verify

[ ] LLOS runs properly
[ ] LLOS observer and target points symbolize properly
[ ] LLOS sight lines symbolize properly
[ ] LLOS takes into account offsets set (ex. by comparing resulting sight lines with/without offsets)
[ ] Measurement units are correct (compare with Measurement Tool)

Run Radial Line of Sight(RLOS)
Run the radial line of sight tool with each elevation data type. Set multiple:

Observer points
Offset values
Minimum and Maximum Ranges
Minimum and Maximum Horizontal and Vertical Fields of View
"Symbolize Non-Visible Data" set to true/false
Measurement Units

[ ] RLOS runs properly
[ ] RLOS visible areas symbolize properly
[ ] RLOS non-visible areas symbolized if checkbox checked
[ ] RLOS takes into account offsets set
[ ] RLOS minimum and maximum ranges and fields of view show correctly in output
[ ] Measurement units are correct (compare with Measurement Tool)

Issue 114 Check
https://github.com/Esri/visibility-addin-dotnet/issues/114

[ ] Enter The following coordinate in the Observer Points box: 116.948W 34.73N

Press Enter

[ ] Enter The following coordinate in the Target Points box: 36.73N 118.948W

Press Enter
Results should show a line with visible and non visible sections (green and red)

Final Checks

[ ] Issue updated with any steps or actions that were taken during the certification
[ ] Bugs found and logged with appropriate labels (i.e. add the G-documentation label if it affects documentation)
[ ] Issues addressed/fixed during certification
[ ] If fixes were made to the solution, open an issue in the solutions-defense repo to update the solution and add for inclusion in the next Release.

Closing. Duplicate issue in solutions-defense test repo


Pip hash error during GitHub CI

During unit testing with GitHub actions, we've started getting errors during the pip install environment set up:
ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.

So far I've seen this with torch and tensorflow only.
See example logs here: https://github.com/tom-andersson/deepsensor/actions/runs/5347960540/jobs/9697196051

@JimCircadian have you ever come across Pip errors like this?

It seems the root cause is the GitHub Action worker running out of memory while installing the large DL libraries (TF/PT), which cancels the download and produces the hash error somehow. Now printing the memory specs of the machine within the CI workflow to monitor that: https://github.com/tom-andersson/deepsensor/blob/292655cdaeb63ac9a026db370e33df34fba1a3e9/.github/workflows/tests.yml#L21-L22
I'm not seeing this error anymore and tests are passing so will close for now.


Help

How do i get this to work? Can you explain or make a video showing how to do it?

Please read through the README on the main page of the project and then reply with any specific questions/issues you might still have.

In the demo video, you had an application open, how do i open that?

In Windows 10, click Start->Settings->Personalization->Colors to open the accent color settings. UniLight's job is to synchronize your RGB LEDs with whatever color you've manually or automatically configured via this settings menu.


[Question] I made it run on the Model 2B, are you interested in the changes ?

First, thanks for this awesome software !
I made it run on the Model 2B, are you interested in the changes ? My use case was to get a headless IP camera from the old hardware i had lying around. The code can be found here:
https://github.com/szpeter80/picamera2-WebUI/tree/szpeter-dev
Some key points in random order:

Used the "Raspberry Pi OS Lite" image and created a script to install all OS dependency packages
Created a script to create and enable the systemd unit, as far as i see it works fine. By merging, help about making it run from systemd can be reduced and less error possiblity for the not so experienced.
I found a 'turbo' version of  the libjpeg package. idk if this does the magic, but the Model2B with NoIR (probably v1) it can do 1296x972 (no crop in this mode) and stream it over a cheap wifi plug (wpa2), python process is about 85-90% (so nearly use up 1 from the 4 core), rest of the system uses less than 10% of a core, and from the 1G RAM with swap disabled, ~230MB used.  So it seems that this is useful software even on a such old board.
Created a script to create a .venv as such to include the system packages and i made a requirements.txt and the packages specified gets installed to the venv as well
Created a startup script which looks for the .venv, and if it is found it activates, then deactivate after the app finishes

If you are interested in some or all of the above changes please let me know. I can do proper, per-feature PR.
with best regards,
Peter

I don't understand. This just works on the 2B v1.1. No changes.
I also used picamera2 with my own scripts on 1B and zero W, so might even work on these, if the overhead is not too much with the webserver.

Sorry, probably bad wording... it is rather 2 part, a statement of the project is usable on the model 2b (it is listed as a unsure on the compat list), and a real question, that are my changes (addititons of scripts etc) anything of interest for this project?
I'm asking because the stuff "worksforme" and probably my first and last raspicam project, so i wont put too much effort to structure the changes if they are not relevant for other people's use case.
I hope i was able to better phrase my intent this time.


feat: Added ability to add tar options

Description of the Change
Added the ability to pass options to tar CLI to impact tar archive creation options
Screenshot or Gif
N/A
Applicable Issues
N/A

Hi @Th3S4mur41
I found this action very helpful. I need to have the possibility to add tar options for my private project pipelines. I don't have experience in contributing to open-source. Would be glad if you could assist if you see some concerns about my suggestion.
Thanks

@dhammma Thanks for your contribution...
I'll have a look as soon as possible.
I also noticed that your first PR was closed as invalid by the CI.
I'll make sure to improve our CI to handle those kind of CI better in the future.

@dhammma what kind of options are you looking to set?
I'm trying to figure out if maybe there is a better and more secure way to do it and if download-artifact would be impacted too

@Th3S4mur41 I want to use option -C, an example of how I want to use it:
tar -cf simple-app.tar -C project-components/backend/simple-app .

I initially thought about adding the specific option name for this tar flag, but I've struggled to choose the understandable name for input

And, also I thought that probably someone else would desire to add more options

Ok, you'd like to set the current working directory to something different than .
In that case I would rather suggest to add a new cwd input to set it.
This would match the naming in node for a similar attribute.
This would also be safer

@Th3S4mur41 it is not convenient for me because in this case tar is created in the wrong place for me

Just to make it clear, the cwd was just a name proposal, it would still do the exact same thing you intend.
Alternatively, we could name the input directory which is the long name for the same function in the tar tool itself

[!NOTE]
-C, --directory=DIR
Change to DIR before performing any operations.  This
option is order-sensitive, i.e. it affects all options
that follow.

Feature added as discussed in https://github.com/eviden-actions/upload-artifact/pull/131


Inheriting from enum throws UnresolvedReferenceError stack

I accidentally inherited from an enum type instead of my abstract type, which threw the following stacktrace.
❯ edgedb create-migration
ERROR: InternalServerError: reference to an undefined item default::AnEnum in default::SubType
  Hint: This is most likely a bug in EdgeDB. Please consider opening an issue ticket at https://github.com/edgedb/edgedb/issues/new?template=bug_report.md
  Server traceback:
      Traceback (most recent call last):
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/server/compiler_pool/worker.py", line 312, in worker
          res = meth(*args)
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/server/compiler_pool/worker.py", line 173, in compile
          units, cstate = COMPILER.compile(
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/server/compiler/compiler.py", line 1986, in compile
          units = self._compile(ctx=ctx, source=source)
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/server/compiler/compiler.py", line 1565, in _compile
          return self._try_compile(ctx=ctx, source=source)
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/server/compiler/compiler.py", line 1618, in _try_compile
          comp, capabilities = self._compile_dispatch_ql(ctx, stmt)
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/server/compiler/compiler.py", line 1501, in _compile_dispatch_ql
          query = self._compile_ql_migration(ctx, ql)
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/server/compiler/compiler.py", line 915, in _compile_ql_migration
          target_schema = s_ddl.apply_sdl(
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/schema/ddl.py", line 479, in apply_sdl
          ddl_stmts = s_decl.sdl_to_ddl(current_schema, documents)
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/edgeql/declarative.py", line 337, in sdl_to_ddl
          topological.normalize(
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/common/topological.py", line 210, in normalize
          for name, item in sort_ex(graph):
        File "/Library/Frameworks/EdgeDB.framework/Versions/1-beta2/lib/edgedb-server-1-beta2/lib/python3.9/site-packages/edb/common/topological.py", line 106, in sort_ex
          raise UnresolvedReferenceError(
      edb.common.topological.UnresolvedReferenceError: reference to an undefined item default::AnEnum in default::SubType
edgedb error: cannot proceed until .esdl files are fixed

EdgeDB Version: 1.0b2+ga7130d5c7.cv202104290000
OS Version: macOS Big Sur (11.3.1)

Steps to Reproduce:

Add schema
create-migration

Schema:
scalar type AnEnum extending enum<TEST>;
type SubType extending AnEnum {}

There's also a similar issue in DDL: #1425.

Thanks @elprans - in almost all cases the error messages are very helpful! Documenting here any I find in the hopes it helps someone else.
Another one - accidentally using id as a link.
Schema:
module default {

    abstract type Identifer {
        required property value -> str;
        constraint exclusive on ( .value );
    }

    type AccountId extending Identifer {}

    type Account {
        required link id -> AccountId;
    }
}

Running migrate gives:
ERROR: InvalidReferenceError: schema object UUID('436c6a9c-bcf9-11eb-87d6-59a58b286906') exists, but is not link

^ This may be hard to find in a larger migration


No face detected in Sign up

On Clicking sign up button, camera opens but no bounding box is shown. No face is detected.

how to fix? no face detected in sign up?


Image Slider Widget:  Implement a toggle for target =_blank property in external links

Currently all external links are set to create a new tab with the property target=_blank.  This feature request would add a new toggle to the layout properties so that this property can be removed by users.

This could be done by modifying system/Packages/perc.widget.imageSlider/sys__UserDependency--rxconfig/Widgets/percImageSlider.xml and adding a layout property (maybe an enum) for the link target.
The link target (search on target=) is in 3 places that would need to be updated to read the new layout property.  The default value for the new property would need to be _blank so as not to cause upgrade issues.

@mario-percussion I think all that is left on this is updating the version info for the widget so it updates correctly on upgrade.

Tested all target=_ options for internal and external links, also tested the "Images are links" checkbox in the image slider layout properties.  All of these are working.


Add authentication for Safekeeper

Based on #2730

Would be good to update https://github.com/neondatabase/neon/blob/main/docs/authentication.md, to follow current state of things better.
IIUC, we currently have 3 storage services operating with Neon JWT:

compute
safekeeper
pageserver

I'd like to have documentation on what tokens are placed in the config of these services, and whether they're optional or not.
In safekeeper and pageserver we have libpq and http interfaces, and we accept queries with tokens on these interfaces. Clarification on what tokens we should use for these interfaces will be also nice.
This is not strictly related to this PR, but you seem to have context for these things which is needed to write a good doc :)
This doc will also make reviewing this PR a little easier.

@arssher @petuhovskiy Would you mind checking if the updated authentication.md makes sense? It looks very similar to a file describing data flow in Neon, if we have one.

Great doc, thanks @yeputons! Will review the code after the rebase, but it looks mostly ok.

Follow-up PRs and TODOs:

[ ] ZENITH_AUTH_TOKEN --> NEON_AUTH_TOKEN
[ ] Move move public key inside SafekeeperConf/PageserverConf and load it on start instead of passing a separate argument through chains of calls (auth_validation_public_key_path --> auth_validation_public_key).
[ ] Claims: make it more structured. E.g. make Scope::Tenant, tenant_id=None impossible.
[ ] Think about generating tokens for debug purposes when SSHed to a staging machine. E.g. curl http://localhost:12345/some-pageserver-api is useful

Waiting for #2863 to be reviewed, approved, and merged before this.

Rebased on top of #2863 (which is to be merged as soon as tests pass), no big conflicts with either main or the other PR.
Will merge this right PR after #2863, if there are no objections.


Register OrgFormation as Resource Provider in AWS

It would be very nice to have the Organization Formation as a resource provider. This way we can have this as part of a stack to roll out or back anytime in CloudFormation service.
A side note, AWS has a AWS::Organizations in the CloudFormation Roadmap that can probably be leveraged as well in the future.

A new private resource provider can be used as a starting point and it can be added to the CloudFormation registry during account creation. For now OC::Organizations::PasswordPolicy has been implemented here: https://github.com/eduardomourar/aws-resource-provider-passwordpolicy

You can also check the CloudFormation Resource Provider Typescript plugin that is being developed here:  https://github.com/eduardomourar/cloudformation-cli-typescript-plugin

A new version of both typescript plugin and the password policy resource provider have been released. It allows the usage of the callback pattern from CloudFormation service itself. This will be quite useful in order to migrate each process (even long running ones) from the org-formation CLI.

We are paving the road to get OrgFormation more and more integrated with the new resource types in this repository: https://github.com/org-formation/aws-resource-providers
I will keep this open until we release v1.


ReplaceItemAsync no longer throws exception when document does not exist

It looks like when you try to replace a document that does not exist it no longer throws an exception like it did with v2. Is this the desired behavior?

Hi @mpaul31 ,
This is by design in v3 SDK. It was decided to not throw on 404 Not Found responses for the following reasons:

Improved performance. Throwing and catching exceptions consumes a lot of resources.
Improved user code. Most workflows consider not finding an item part of the normal workflow. This allows users to simply check for null rather than coding a try catch.

gotcha makes sense however not sure most would expect a call to ReplaceItemAsync to work this was when the intent is the resource is already there. Either way easy work around.

On Apr 22, 2019, at 11:32 AM, j82w<EMAIL_ADDRESS>wrote:
Hi @mpaul31 ,
This is by design in v3 SDK. It was decided to not throw on 404 Not Found responses for the following reasons:
Improved performance. Throwing and catching exceptions consumes a lot of resources.
Improved user code. Most workflows consider not finding an item part of the normal workflow. This allows users to simply check for null rather than coding a try catch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

This was changed to throw in the GA version.


GTX1650 Not Actually Processing

Hi there. I'm running Windows 11 with a GTX1650 card and IW3 discovers it without a problem. However, the end video is SBS, there is no 3D effect. If I run the same settings with CPU processing only, the video comes out great with full 3D effects. Although, the processing is slow as molasses.  This leads me to believe it is GPU related. I looked through and changed a few things in the GeForce set up to no avail. Any help would be appreciated.

I got it to work. Deselecting FP16 has solved the problem as well as speeded things up by 2.5X.

That's good to hear.
GTX1650 does not have Tensor Cores, so FP16 has no advantage.
Maybe it is a problem with fp16 and flash attention.
I have GTX 1050Ti which is even older than GTX1650, so I will check it later.

I tried combinations of FP16, FP32, ZoeDepth, DepthAnything on my GTX1050Ti and all worked fine.
Maybe you need to update GPU driver
Either way FP16 on older GPUs is not recommended, though.

Here are the settings that caused the non-processed result, except for the FP16 not been ticked. It appears to work until you play back the outputted file.

It is possible that Flicker Reduction=0.99 is the cause.
Flicker reduction=0.99 has the known problem that the 3D effect is lost for several seconds when the scene changes.

Thank you for the help. Issue closed.

I added a note to the README about older GPUs and FP16.


feat: Add Minikube extension

Copied from

https://github.com/containers/podman-desktop/pull/2646

Restored .gitconfig, to avoid adding "node_modules" etc
1c1,5
<
---
> node_modules
> .DS_Store
> dist
> .eslintcache
> **/coverage

Most of this is just piggy-backing on the already existing "kind" extension
I can make some attempt to merge, and maybe you can help from there

@afbjorklund I fixed issues, PR checks are passing now


Remove create_index() on all VectorStoreDrivers

[x] I have read and agree to the contributing guidelines.

only a subset of VectorStoreDrivers have a create_index(). this should be deprecated and removed from existing drivers and removed from the docs.

Based on an internal conversation we landed on not implementing these kinds of calls in Drivers. We only want to work with data APIs, not infrastructure APIs.
I think this issue should be repurposed to remove the create_index calls from Drivers that do have it.

done


slurm currently does not support shared caching

Hi all -- this extracts the caching discussion from #918 (cc'ing @arkal) and provides more details so that PR can focus on Slurm.
Running cwltoil with Slurm using:
cwltoil --batchSystem slurm --jobStore $JOBSTORE --logFile $LOGFILE --workDir $WORKDIR --preserve-environment PATH HOME --no-container run_info-cwl-workflow/main-run_info-cwl.cwl run_info-cwl-workflow/main-run_info-cwl-samples.json

(The CWL is from https://s3.amazonaws.com/bcbio/cwl/test_bcbio_cwl.tar.gz but not sure this has anything to do with CWL versus toil cache usage).
After applying the fix from #910 (which masks the real error), we see:
node04: 2016-06-03 10:43:16,323 INFO: toil.lib.bioio: Logging set at level: INFO
node04: 2016-06-03 10:43:16,323 INFO: toil.lib.bioio: Logging to file: cwltoil.log
node04: 2016-06-03 10:43:57,411 INFO: toil.lib.bioio: Logging set at level: INFO
node04: 2016-06-03 10:43:57,412 INFO: toil.lib.bioio: Logging to file: cwltoil.log
node04: 2016-06-03 10:43:57,476 INFO: toil.jobStores.fileJobStore: Jobstore directory is: /scratch/bchapman/cwl_testing/test_bcbio_cwl/cwltoil_jobstore
node04: 2016-06-03 10:43:57,477 INFO: toil.jobStores.abstractJobStore: The workflow ID is: 'e93d192a-a3ab-4027-9902-44db0f0837ad'
node04: 2016-06-03 10:43:57,685 INFO: toil.jobStores.abstractJobStore: Unable to import 'toil.jobStores.azureJobStore'
Traceback (most recent call last):
  File "/scratch/bchapman/cwl_testing/test_bcbio_cwl/../anaconda/bin/cwltoil", line 9, in <module>
    load_entry_point('toil==3.2.0a2', 'console_scripts', 'cwltoil')()
  File "/scratch/bchapman/cwl_testing/anaconda/lib/python2.7/site-packages/toil-3.2.0a2-py2.7.egg/toil/cwl/cwltoil.py", line 595, in main
    outobj = toil.start(wf1)
  File "/scratch/bchapman/cwl_testing/anaconda/lib/python2.7/site-packages/toil-3.2.0a2-py2.7.egg/toil/common.py", line 527, in start
    userScript=rootJob.getUserScript())
  File "/scratch/bchapman/cwl_testing/anaconda/lib/python2.7/site-packages/toil-3.2.0a2-py2.7.egg/toil/common.py", line 664, in createBatchSystem
    raise RuntimeError('%s currently does not support shared caching.' % config.batchSystem)
RuntimeError: slurm currently does not support shared caching.

I used --disableSharedCache to work around the problem, but don't know if that's the best fix or what the underlying incompatibility with caching it. Happy for any suggestions. Thanks much.

so i'm not too familiar with slurm but looking at this, i can tell you why it's failing. With caching, what happens is Toil creates a directory toil- under --workDir or in the $TMPDIR and that contains the job wrapper temp dirs, and the cache. If you don't have a way of cleaning up the directory on each node,  in your batch system shutdown method, you might need to set one up since that's the only way the cache dir will get cleaned up.
To overcome the caching issue, add this to the SlurmBatchSystem Class
    @classmethod
    def supportsWorkerCleanup(cls):
        return True```

Arjun;
Thanks for the details, this helps a lot. It looks like supportsWorkerCleanup is also set to false on the SGE integration as well, which is likely the origin of this in the SLURM implementation so we're going to run into this with other batch systems. If workDir (or tempDir, I'm not sure which it uses) is on a shared filesystem, then we should be able to use caching -- is that right? If so, is there any flag or method to tell Toil that we're good to go with a shared cache because it can cleanup on the shared filesystem? It sounds like using shared cache is a good idea, so this seems like the best approach to support it. Thanks again for the discussion.

@arkal, we might need to disable caching automatically if the batch system does not support worker clean-up. I thought we had that already implemented?

Either we automatically disable caching on those batch systems, or we mention in the exception message to rerun with --disableSharedCaching.

@chapmanb

After applying the fix from #910 (which masks the real error), we see:

Please file a ticket about that specific issue. I agree that there is problem but disagree with your fix (I think the try: needs to be moved down one line).

Hey Brad,
Really, shared caching works on all batch systems. The reason we've set supportsWorkerCleanup to False on SGE is because we couldn't think of a way to cleanup node-specific local work dirs in the SGE environment (because Toil doesn't track which nodes were touched during the run). You can see how we handled single machine and Mesos in their shutdown methods.
@hannes-ucsc , I remember a discussion where we decided not to directly disable caching. I'll add the "please use the --disableSharedCaching flag to run toil" line to the error message

Really, shared caching works on all batch systems

Then why do we raise the exception?

Arjun and Hannes;
Thanks for the discussion. From reading the code, it seems like we could use the standard worker cleanup:
https://github.com/BD2KGenomics/toil/blob/616aade0da9754011ac98bc8c493a988a369cf4f/src/toil/batchSystems/abstractBatchSystem.py#L283
as long as workDir is on a shared filesystem since all the nodes will write there. Do you have any thoughts how to best specify if we're using a shared filesystem (and can use cleanup) versus local (and we don't know how to cleanup)? That seems like the cleanest way to go, rather than turning off caching entirely for all SLURM runs.

I don't think we can assume that SLURM is used in conjunction with a shared file system. More importantly, the work dir should reside on fast, locally attached storage.
The best solution I can think of is to track inside the batchsystem which nodes commands were sent to, and then at shutdown schedule individual clean-up commands to those nodes.

Hannes;
That makes sense, although seems like a lot to implement and is probably non-ideal on busy shared cluster systems where users are likely to be unhappy with having to wait for more queued jobs to start up for cluster cleanup.
Can you describe what shared caching does and why it's useful? I don't mind disabling it, but trying to understand the tradeoffs. All I got from the code was:A cache-enabled version of Filestore. Basically FileStore on Adderall(R) I guess it's avoiding copying files multiple times to the same machine if used more than once?

http://toil.readthedocs.io/en/latest/architecture.html#caching

Hannes;
Thanks for the pointer -- sorry I missed this. What do you think about having http://toil.readthedocs.io point to http://toil.readthedocs.io/en/latest/ instead of 3.1.x? I missed a lot of useful documentation not realizing that wasn't the latest.
I'll close this now and use --disableSharedCaching for SLURM/SGE/local scheduler jobs. It seems like the value of caching is not as high on shared batch systems where your per-node re-use may not be great and they won't be fans of keeping around large files cached into local temporary storage. I can definitely see the value on Amazon to avoid transferring from S3 multiple times. Thanks again for the help.


Missing support for apply_filters_ref_array()

First: I love what you've done with this repo. It's gotten us very close to a solution. This issue is one of the missing pieces.
The parser misses these functions for some reason: https://developer.wordpress.org/reference/functions/apply_filters_ref_array/
Any thoughts?

Sorry, this was user error. There's a small issue where the template doesn't have support for showing apply_filters_ref_array() and do_action_ref_array() in title, but that's minor.

Thanks for your notice. Yeah, currently the output only supports apply_filters instead of using the original callee (e.g. apply_filters_ref_array). Reopening, but I cannot promise any ETA. PRs welcome. 😊

We at Pronamic were also looking for a way to document the WordPress filters and actions in our WordPress plugins, themes and libraries. In our search we came across a number of solutions, for our research see the following issue: https://github.com/wp-pay/core/issues/45. In the end we developed a solution ourselves: https://github.com/pronamic/wp-documentor. It can find all WordPress actions and filters in a codebase, including: apply_filters_ref_array filters. The result can be converted to a markdown file for in your Github repository or GitHub Pages. See for example: https://github.com/pronamic/wp-documentor/blob/main/tests/docs/hooks.md. Unfortunately there is not yet the possibility to generate a separate page for each hook like WordPress HookDoc does:

https://10up.github.io/distributor/
http://10up.github.io/ElasticPress/

The advantages of https://github.com/pronamic/wp-documentor are that you do not have to add the @hook tag or put the types between curly brackets (for example:{int},{string}, etc.). But https://github.com/pronamic/wp-documentor will also have its limitations, maybe we can work together on a nice solution for generating hooks documentation. I will keep an eye on the developments of this project, thanks for the good work!


LinuxContainerSecurityContext is optional

LinuxContainerSecurityContext is optional.  The code in crio requires it and therefore fails when  a config does not include it.

We probably should fix this before we release 1.0.

Has there been a PR on this one?

we're now using getters from grpc methods, closing


replaced various images

Can't add placeholders on add-text-plugin.png
all images under http://docs.django-cms.org/en/latest/user/index.html replaced

check https://github.com/vxsx/django-cms/pull/1#issuecomment-146078451

I'll work on the text for this.

:+1:

:+1:

docs/images/page-basic-settings.png and save-and-continue have wrong settings button sizes

and button colors for that matter

Gentian, can you rebase this with latest develop so tests will pass?

Changes Unknown when pulling dcb69a68ae9cbed04770f1b0f55d265651863033 on genti94:replace-images into ** on divio:develop**.


Ring sounds

Add config under ring module for soundType: Normal (hourglass funnel sound), Accretion (violent reentry sound), or default None.

Implemented in https://github.com/xen-42/outer-wilds-new-horizons/commit/2460bbafb76eb88b73ccf2140c4c15ad106899aa rings can either be CLOUD, WATER, SAND, PLASMA, or NONE.


Remove ImproveOSM

Closes #10302

(Please note the last comment in https://github.com/openstreetmap/iD/issues/10302)


Packages for non x86 platforms

Hello,
I would like to use sensu on non-intel platforms.  However the installation guidelines are heavily distribution specific, and there is no armhf platform in the repositories.
rabbitmq creates binary independent packages - for example http://www.rabbitmq.com/debian/dists/testing/main/

We can research what it will take to add support for other architectures to the pipeline.

This issue is related to https://github.com/sensu/sensu-build

Thanks.  Since logging the defect, I've since found sensu-build.  I could follow most of the instructions at http://blog.cloudpack.jp/2014/11/17/run-sensu-client-on-raspberry-pi/  including building a dpkg.    The primary gaps seem to be around runit tests and generation of a correct architecture on armhf.
Note that I do agree that this defect should be against sensu-build.
I will self-close.


First pull request

Add new functionality to a page, issue #2
Please review and if ok , merge to master.
You can assign @ShayLevy to it

OK, approved


Accessing Secret Values via REST API

The docs say

Only the secret names are mapped to the variable group, not the secret values. The latest version of the value of each secret is fetched from the vault and used in the pipeline linked to the variable group during the run.

Does this mean for variable groups that are linked to an Azure Key Vault there is no way to access it via the REST API and get the secret values? Are the secret values only accessible in a AzD pipeline?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4827aa99-ae62-bd63-6f2f-a87a4065ed27
Version Independent ID: c9e461ee-7f42-3503-9460-18fa3a807bbb
Content: Variable groups for Azure Pipelines and TFS - Azure Pipelines
Content Source: docs/pipelines/library/variable-groups.md
Product: devops
Technology: devops-cicd-library
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

@winstonhenke Thank you for the question.
Unfortunately, secret variables cannot be accessed through the REST API, see this post.
To revisit this issue, please start a thread with the product team here.


vm: * The 'ansible_local' provisioner could not be found. Error

I am getting
vm:

The 'ansible_local' provisioner could not be found.

What is the solution...?

Hi,
Where did you encounter this error?

Hi william, thanks for replying...
I reinstalled 'Vagrant' its working fine


Fix monoT5 pytorch arguments

Actually, I was looking at my logs and I was never able to reproduce the results on pytorch+GPU using the same hyperparameters used finetuned on TF+TPUs. The best ones I found were the ones already in the repo.


AddressAuthorizationRequiredError from UI

This is an error that is related to calls that may be happening when the UI tries a couple of calls before the auth window opens; it doesn't hurt anything but it's a little noisy in the logs and indicates that some useless calls are being generated by the UI that may need to be revised so that they don't fire if the user auth flow will need to be initiated first.
Steps to reproduce:
In an environment where the env var AUTH_CHECK is true (such as current Production env):

Login
Hit refresh
You will be prompted to login again in UI
In logs (or new relic) you will observe a handful of AuthorizationRequiredError:

This is not the the expected behavior. This issue #1136 addressed this and this PR #1145 was merged into dev to fix it. The issue was that these calls were being attempted in the UI without a Bearer token attached to the headers yet, which caused the backend to refuse them because "AUTH_CHECK" is true. This in-turn resulted in the UI logging out the user.
The fix in #1145 was to make sure that the calls happen in right sequence, with the bearer token present in headers. To observe that this is fixed, AUTH_CHECK has been turned on in the dev environment. Now when visiting UpGrade, if one clicks refresh, one will no be forced to re-login, and as a consequence, this error will not be observed in the logs.

@bcb37 I added some elaboration on this issue so it can be QA'd

This now works as expected. QA'ed!