Use Django decorator pattern to define view configurations

Description
Currently, each Django view requires custom configuration for file upload validation. This process involves modifying the settings.py file to set various parameters for each upload type, like file size limits, whitelists, and others. This approach, while functional, can become cumbersome for developers, especially when dealing with multiple views and file types.
To streamline this process, I propose the implementation of decorators that can be applied directly to Django views. Decorators would allow developers to easily configure file upload validations on a per-view basis without the need to alter the settings.py file for each case. This would lead to cleaner, more maintainable code and a more straightforward implementation process.
Here's an example of how such a decorator could be used: ()
from django_middleware_fileuploadvalidation.decorators import file_upload_validator

@file_upload_validator(file_size_limit=2000000, keep_original_filename=True, whitelist=["application/pdf"])
def upload_pdf_view(request):
    # View logic for uploading PDF files
    ...

@file_upload_validator(whitelist_name="IMAGES_ALL")
def upload_image_view(request):
    # View logic for uploading images
    ...

In this example, the file_upload_validator decorator is used to define upload constraints directly above the view functions. This would override the default configurations set in the settings.py file for these specific views.
The benefits of this approach include:

Improved clarity: Decorators make it explicit what configurations apply to which views.
Enhanced flexibility: Developers can easily customize file upload constraints for individual views.
Reduced boilerplate: Less need to repetitively define configurations in settings.py.

I believe this feature would greatly enhance the usability of the django-middleware-fileuploadvalidation project and I am eager to hear thoughts and suggestions from the community on this proposal.

can you please explain more ??

can you please explain more ??

Sure! I updated the initial issue description.


Count https video URLs in the results

In Debian we are currently applying the following patch to
get-flash-videos.
We thought you might be interested in it too.
From ad36427136f759d3f7be85a074a4f8bafe5a42a9 Mon Sep 17 00:00:00 2001
From: Niko Tyni<EMAIL_ADDRESS>Date: Wed, 14 Oct 2015 10:06:31 +0300
Subject: [PATCH] Count https video URLs in the results

Some video URLs on the Google video site now start
with https, making the test fail.

The patch is tracked in our Git repository at
https://anonscm.debian.org/cgit/pkg-perl/packages/get-flash-videos.git/plain/debian/patches/Count-https-video-URLs-in-the-results.patch
Thanks for considering,
Damyan Ivanov,
Debian Perl Group

Merged thanks for the change. Thanks.


[QA] Set Via Filter : When both the options from this filter is selected it does not show the result

Describe the bug
I have noticed that theSet Via filter does not work as expected when filter is applied using both JS and HTTP
To Reproduce
Steps to reproduce the behavior:

Open any website
Open DevTools Panel > Privacy Sandbox
Click on Filters icon
This will open filters categories
Select Set Via Filter
Now, check with either of the option selected and it will show the correct result.
However, if both the options are selected then it does not show any result.

Expected behavior
Upon selecting both filters it should show the result from both the filter values.
Screenshots
https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/15173772/fee9829a-8219-4d66-ba11-1d33106e5d00
Test Environment:

Chrome Version 120.0.6099.109 (Official Build) (arm64)
PSAT Extension V0.3.2

@ayushnirwal Please check my comment below.
The added fix only works as expected when the cookie from the selected filter is present and filter is applied.
This is breaking the existing functionality flow as mentioned below:

filter disappears once you click on the filter option for which the cookie is not present
filter icon gets disabled
clearing the filter option from top bar, retains the filter but the selected options does nor come up

Please refer to the screencast below.
https://github.com/GoogleChromeLabs/ps-analysis-tool/assets/15173772/c5a93043-c7dc-42f0-a0c9-f6ea02212f86

Closing this issue as it is addressed in V0.4.0 release


Files with more than one period are ignored

Originally my gruntfile.js had this section:
compress: {
  main: {
    options: {
      mode: 'gzip',
    },
    files: [
      { expand: true, src: ['build/<%= pkg.version %>/js/*.js'], ext: '.js.gz' },
      { expand: true, src: ['build/<%= pkg.version %>/js/libs/*.*.js'], ext: '.js.gz' },
    ]
  }
},

But then I noticed that certain files weren't getting gzipped.  In this case, jquery.emojipicker.a.js.  So I changed my compress files section to add this:
 { expand: true, src: ['build/<%= pkg.version %>/js/jquery.emojipicker.a.js'], ext: '.js.gz' },

But it's still being ignored.

extDot: last
see http://gruntjs.com/configuring-tasks#building-the-files-object-dynamically

Works great, thank you. Can the docs be updated to reflect that?

+1 please update README to include this


Unable on install Appium

"convertfrom-json: Invalid JSON primitive: ." error message shown for installing appium. Please refer the screenshot for the same. I also have tried to install Maven for a check which got installed successfully. Could you please look into it. Please refer the screenshot for the same.

You need to use raw URL

@Ash258 Thank you for the response.I am new for this stuff. Detailed information would help me to resolve it.

https://raw.githubusercontent.com/lukesampson/scoop-extras/master/bucket/appium.json


Add metadata option to open_parquet_file

This is a follow-up to #806 (where a new fsspec.parquet module was added). The most important changes in this PR are the following:

Adds a new metadata argument to open_parquet_file
Expands the row_group argument of open_parquet_file so that the user may optionally pass in a list of distinct engine-specific row-group metadata (rather than a list of row-group indices).
Adds a strict option to KnownPartsOfAFile (defaulting to True). When strict=False, reads that extend beyond the boundary of a known part will be zero-buffered. When strict=True, the missing range will be explicitly fetched from the remote source. Note that the strict logic only applies to reads that begin within a known part. It seems that Fastparquet will often seek to an offset within a known part, but then read slightly beyond the end of the buffer/file. I experimented with various ways to deal with this, but using strict=False (within open_parquet_file) seems to be the simplest way to avoid constant errors/warnings and unnecessary data transfer. Note that the user can always set strict=True for debugging purposes.

The primary purpose of this PR is to make it possible to utilize open_parquet_file within Dask for better remote-file perfomance in dask.dataframe.read_parquet.  Without these changes, only the "pyarrow" engine can benefit from the new optimization.
Note that these chnges do not (yet) add support for pyarrow-based metadata input. I will target that feature in a separate PR.

Fastparquet will often seek to an offset within a known part, but then read slightly beyond the end of the buffer/file.

I suspect this must be thrift's internal buffering at work. https://github.com/dask/fastparquet/pull/633 would not behave like this, should I ever get around to merging it.

To add a bit of "performance motivation" here, I just ran a fresh "fastparquet" test from GCS storage:
from fsspec.core import get_fs_token_paths
from  fsspec.parquet import open_parquet_file
import fastparquet as fp
from functools import partial

path = "gs://my-bucket/criteo-parquet/day_0.parquet"
columns = ["I10"]
engine = "fastparquet"

fs = get_fs_token_paths(path, storage_options=...)[0]
pf = fp.ParquetFile(paths[0], open_with=fs.open)

%%time
df = pf.to_pandas(columns=columns)

CPU times: user 8.34 s, sys: 2.08 s, total: 10.4 s
Wall time: 45.2 s

%%time
pf.open = partial(
    open_parquet_file,
    fs=fs,
    metadata=pf,
    columns=columns,
)
df = pf.to_pandas(columns=columns)

CPU times: user 3.39 s, sys: 431 ms, total: 3.83 s
Wall time: 3.94 s

@martindurant - Any thoughts on how likely this is to get in before the next fsspec release? I think the PR is in pretty-good shape and is ready for final review, but I certainly have tunnel vision here (as I often do) :)

Okay - I think the more-critical review comments have been addressed. I still want to clean up the general approach to engine handling, but I'd prefer to do that work separately.

Woohoo - Thanks for the prompt and valuable review here @martindurant !


Top navigation Icon flickers to repositions itself during hydration

Summary of the bug
Top navigation Icon flickers to repositions itself during hydration
🪜 How to reproduce
Tell us the steps to reproduce the problem:

Go to the ICDS homepage
Refresh
Watch the ICDS logo in top navigation initially position itself at the top, then reposition to the middle.

Additional info
Unclear if this is component based or website related, or possibly even guidance for use of Icons.

See my comment on another FOUC-related ticket


CBCB: Did you consider only Carbon Beta atom while predicting distance map ?

Hello,
While predicting the distance map, Did you consider only the Carbon Beta atom while predicting distance map ? What does it mean by CBCB? Or did u consider all backbone atoms like N, Carbon Alpha, C, and Carbon Beta?

CBCB means the distance between Carbon Beta atoms of residue pair. Other atoms are not considered.

Thank you for your quick response!
OFF TOPIC: As one of your lab works has extended or used Copulanet output ( predicted distance map) as input for SASA-NET, so is that also mean that the input distance map of SASA-NET is also the distance between carbon beta atoms only? I would appreciate the response or please let me know how to contact with SASA-NET team. I have opened two questions in SASA-NET Github but did not receive any response yet.

Hi, what did you consider for Glysin? As if I can remember, Glycine does not have a β-carbon.


HTML Import

Hello Ryan, we already had MJML import thanks to you..
Is there any way to import as HTML?
reference ( useImportTemplate ) =>

Maybe you should try Text block.  Import  html code as Text block content
https://documentation.mjml.io/#ending-tags
<mjml>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-text font-family="Helvetica" color="#F45E43">

Title

Paragraph

Another paragraph

        </mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

Thanks, Ryan


chore: add TestRun test helper for testing Run integrations

decided to go another way, going to hold off on this for the moment


Lootbox no token id bugfix

as per https://linear.app/pooltogether/issue/POOL-1140/subgraph-lootbox-bug

Merging into v3.3.1 and closing. Fix ported to v3.3.8.


Add Legal Information to Footer

Description
Is your feature request related to a problem? Please describe.
I want to integrate a section in the footer that includes links to the privacy policy, terms of service, and other necessary legal information, ensuring they are clearly visible and accessible.
Describe the solution you'd like
I would like to add a section to the footer that includes links to the privacy policy, terms of service, and other relevant legal information. The section should be clearly visible and integrated into the existing footer design.
Describe alternatives you've considered
I have considered placing legal information in a separate dedicated page, but adding it directly to the footer ensures easy and immediate access for users.
Additional Information
Context
Adding legal information to the footer ensures compliance with legal standards and provides users with easy access to important details.
Screenshots or Mockups (optional)

I want to work on this issue. Also, please add the label SSOC and the level that you find appropriate for this issue. thank you!


Fixes recent people flag size

@timgraham This fixes the flag size for recent people on the homepage.

Thanks but if we can't solve the issue of missing flags (such as "an.svg") then I think we'll have to revert the switch to svg. Did you look into that issue?

Hi Tim, The country code AN was never assigned. Interesting history here: https://en.wikipedia.org/wiki/Netherlands_Antilles. So for now I will copy the Dutch Caribbean flag (bq.svg) to an.svg
Could you please let me know if there are other missing flags? I will try to resolve them too.

Thanks, I pushed out the an logo -- that's the only missing one I've seen.
The svg size change doesn't seem to work on the home page because the "vCard" CSS class is missing. Maybe an HTML change is also required?


License in metadata.json doesn't match the dual licensing documented in the README.

metadata.json says 'Apache-2.0' but the README says part of the code (stuff derived from https://github.com/evolvingweb/puppet-apt/??) is MIT.

Apparently this was relicensed when the company took over maintainership (see https://github.com/puppetlabs/puppetlabs-apt/commit/245b2b178378c3783cf31348e24034b8d195a68f and https://github.com/puppetlabs/puppetlabs-apt/commit/08c1283437e2a7072e788f489f1de73dbc9a6c5d).

Is this still an active issue? Does metadata.json even allow specifying a dual license?

@ekohl It doesn't.

Then given the current description I think the status is good enough but IANAL.

okay, let's just live with this until a copyright holder actually complains.


Improvements on new EPMC pipeline output

Including here for discussion and future reference.
 Since our grounding is based on dictionaries, we don't see a value on having 2 dictionary-based steps. All checks we performed so far indicate good results with ML + dictionary grounding.

The current section field contains the title of the section. We suggest renaming it to sectionTitle and could be null if we don't have access to the text.
>>>epmc.select(explode(col("sentences.section")).alias("section")).distinct().show(5, truncate = False)
+------------------------------------------------+
|section                                         |
+------------------------------------------------+
|Amplification and sequencing analysis of pfmsp-3|
|Outside/in stresses and serum cTnI and cTnT     |
|Histological study                              |
|Postresuscitation Management                    |
|Lopinavir–ritonavir                             |
+------------------------------------------------+
only showing top 5 rows

However, we are missing information as the field is not abstracting which section of the manuscript the sentence is (e.g. introduction, results, etc.). We will need this information for the scoring. Would it be possible to have a section field containing an enum similar to the options the old pipeline produced. See next:

>>> oldEvd.filter(col("sourceID") == "europepmc").select(explode(col("evidence.literature_ref.mined_sentences")).alias("sentence")).select(col("sentence.section").alias("section")).groupBy("section").count().show(truncate = False)
+---------------------------+-------+
|section                    |count  |
+---------------------------+-------+
|case_study                 |17837  |
|title                      |1184291|
|table                      |258976 |
|conclusion_and_future_work |173492 |
|other                      |2530869|
|figure                     |406341 |
|appendix                   |6860   |
|discussion                 |2078112|
|introduction_and_background|1093167|
|results                    |1474558|
|abstract                   |7132481|
+---------------------------+-------+

evidence_score won't be necessary. A single evidence in the platform is formed by the aggregation of all sentences mentioning same target and same disease in the same paper. Since this requires grounding, we will do this on our side. However, we will need the logic of the old scoring scheme, in order to move it to a downstream process. Could EPMC team please share this with us?. We will need this information in order to phase out the old pipeline, but we expect the scoring to be improved in the future.

pubDate not sure what's the specification of this field but it contains dates in the future. For example,  https://pubmed.ncbi.nlm.nih.gov/32265214/  is dated in 2022-04-06, which seems to be when the article will be accessible for open access. We need a more realistic date around when the manuscript was made public.

pmid currently contains PMC ids. Is it possible to have a field containing PMIDs (integer values) named pmid and another named pmcid containing the PMC ids when available?
>>> epmc.select("pmid").show(5)
+----------+
|      pmid|
+----------+
|PMC7235531|
|PMC7235532|
|PMC7235536|
|PMC7235537|
|PMC7235538|
+----------+
only showing top 5 rows

It would be ok if the field text is not available for matches, .

Thank you @d0choa
Here is what I have gathered from your analysis.
1, 2, 4, 6 are straightforward and 3, 5 can be accommodated after some unit testing.
1. ML output
2. section => sectionTitle (nullable)
3. sectionTitles to reflect one of the following:
case_study
title
table
conclusion_and_future_work
other
figure
appendix
discussion
introduction_and_background
results
abstract

4. No need for evidence scoring
5. pubDate fixing
6. pmid to be renamed to pmcid for FT articles

hi @tsantosh7! we have 3 other (hopefully) simple comments that came out as part of re-implementation of the old pipeline scoring. @DSuveges can provide more details if necessary.

The fields sectionEnd and sectionStart refer to the position where the sentence start/end within the section. At the moment, it's nested inside matches, when in fact it would make more sense to specify it only once per sentence. Could you move this field at that level to avoid unnecessary repetitions?

The fields sectionStart and sectionEnd are sometimes present and sometimes absent. Could you remind us if there is a reason for this?

Could we add another field named sectionLength at the sentence level that specifies the total length of the current section. This way, we can know that if sectionEnd == sectionTotal we are in the last sentence of the section.

@d0choa I will look into this and come back to you by next working day.

Hi @tsantosh7, I'm wondering how things are going? We now have the script ready to generate target/disease evidence strings for the platform based on the new cooccurrences file, but the only thing is missing is the scoring. To implement that on our side we'll need the bits on @d0choa's above comments. The 21.04 release is going to be special as this will be the first release when we are migrating to the new evidence schema, that's whey we are very keen to make sure everything works and want to put everything in place well in time to have chance to fix unforeseeable bug that might occur.

Hi @DSuveges. We will start preprocessing the work this Monday. It might take a week to process all the articles. So we are ideally looking at March 21 earliest to submit you the new annotations.

@d0choa @DSuveges
The fields sectionEnd and sectionStart refer to the position where the sentence start/end within the section. At the moment, it's nested inside matches, when in fact it would make more sense to specify it only once per sentence. Could you move this field at that level to avoid unnecessary repetitions?
Sure, I can move this up to a higher level (sentence level).
The fields sectionStart and sectionEnd are sometimes present and sometimes absent. Could you remind us if there is a reason for this?
If the sentences come from an abstract section then only we would use these otherwise they are nullable.
Could we add another field named sectionLength at the sentence level that specifies the total length of the current section. This way, we can know that if sectionEnd == sectionTotal we are in the last sentence of the section.
Ofcourse we could add this.

There was an issue with the publication PMC5654964: the identified  target entity was ( I noticed when I was checking the evidences I created based on the cooccurrence file.
@mkarmona took a look and told that publication even breaks grep on the command line. His suspicion is that there might be an escaping issue. Could you please take a look at it: NMP_Annot_PMC5652480_PMC5667274_split_3.json in this file he found the issue.

@d0choa : On your comment 'Could we add another field named sectionLength at the sentence level that specifies the total length of the current section. This way, we can know that if sectionEnd == sectionTotal we are in the last sentence of the section.' May I ask you why you want to check that conditions, please?
@DSuveges : I am taking care of some of these requests. Do you want me to do the Target-Disease-PMID level evidence score for you? It will be fairly easy for me to implement.

There was an issue with the publication PMC5654964: the identified target entity was ( I noticed when I was checking the evidences I created based on the cooccurrence file.
@mkarmona took a look and told that publication even breaks grep on the command line. His suspicion is that there might be an escaping issue. Could you please take a look at it: NMP_Annot_PMC5652480_PMC5667274_split_3.json in this file he found the issue.

I will look into that and fix the bug if any.

@saha-shyamasree

May I ask you why you want to check that conditions, please?

So we would like to reproduce the scoring described in Kafkas et al. That method takes into consideration where the identified sentence is located within a section. Specifically, it matters if a sentence is in the first, second or the last sentence of an abstract. At the moment we have no means to infer this. That’s the point of this request.

Do you want me to do the Target-Disease-PMID level evidence score for you? It will be fairly easy for me to implement.

Also yes, please keep adding the evidence score.

Publication date has been fixed.
I propose we keep both the PMC and the PMID when available to facilitate filtering out abstracts of the full text articles from the abstract set.
Section titles are now sorted and is in the format of previous version.
I am working on the target-disease-pmid/pmcid score and moving the sectionStart and sectionEnd to the upper level.

@saha-shyamasree, having both PMC and PMID is good, but could you please add PMID regardless the availability of the full text? We use PMID to generate link on our frontend and having a PMC id breaks the validation. Thank you so much!

@saha-shyamasree, having both PMC and PMID is good, but could you please add PMID regardless the availability of the full text? We use PMID to generate link on our frontend and having a PMC id breaks the validation. Thank you so much!

done now

sectionStart and sectionEnd is now at a higher level.

@DSuveges , @d0choa : I just occured to me that without the normalizing the entity terms to a db id we can not correctly compute the score. So yes it has to happen at your end. Although, if I assume you output the same json format from your normalization script/code, and add the 'db_id' under the 'matches', I can easily compute the score. Does that work for you guys? Please et me know ASAP as everything else is done.

These were our questions sent over on 24th May. Based on @saha-shyamasree's response some of the items are already fixed:

[x]  Currently publication date (pubDate) is not standard/consistent. Something like yyyy-MM-dd would be great. Also do you think there’s anything you can do about publications, which date to the future?

[x]  At the moment PMCID or PMID are exclusive in the submitted dataset. When papers have both PMID and PMCID, we would like to have both.

[x]  Due to the nestedness of the directories in the google bucket, ingesting the input files is quite problematic at the moment. Ideally, directories should contain directories or files, but not both mixed together.

[ ]   Duplications causes issues (e.g. when data is processed through full text and abstract). We propose to drop the publications from abstract when there is a full text available. Later on, we can evaluate if this causes any issues.

@saha-shyamasree 's comment:
I am thinking if it will be better to do it on your side, as you are doing a pass on the data during normalizing the terms to a DB id. Plus, you will access to the whole thing, if you find excluding those abstracts create issue, you can revert to existing system.

[ ]   We were wondering if you could improve the sentensizer to reduce the number of overly long sentences.

[ ]   Under #1367 - There was an issue with the publication PMC5654964, we were wondering if you could take a look at that.

@saha-shyamasree 's comment:
I will check the publication next week and let you know.

There is a systematic problem with encodings in the processing of full-text articles.
The next is just an example:
## Full text
❯ gsutil cat gs://otar025-epmc/21.04/epmc-08-04-2021/NMP_SEC_PMC3900032_PMC3909995.jsonl | jq 'select(.pmcid == "PMC3902282")' | jq '.sentences[] | select(.section == "title") | .text'
"Habenular expression of rare missense variants of the Î24 nicotinic receptor subunit alters nicotine consumption"

## Medline
❯ gsutil cat gs://otar025-epmc/21.04/epmc-08-04-2021/ML/NMP_Annot_medline.24477000.jsonl  | jq 'select(.pmid == "24478678")' | jq '.sentences[] | select(.section == "title") | .text'
"Habenular expression of rare missense variants of the β4 nicotinic receptor subunit alters nicotine consumption."

To give a sense of the magnitude of the problem, we found 57,798 matches of Alzheimer's disease in 30,410 different publications that we couldn't normalise because of the wrong encoding of the ' symbol.

Apart from the very long sentence problem reported by @DSuveges due to incorrect sentence splitting, @mkarmona also reported this can create artificial labels:
-RECORD 0-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 pmid            | 32497751
 pmcid           | PMC7832808
 pubDate         | 01/07/2020
 date            | 2020-07-01
 year            | 2020
 month           | 7
 day             | 1
 organisms       | [virus, coronavirus, human]
 section         | other
 text            | If complex reconstructive procedures are required to preserve patient's functioning and long-term survival, considerations regarding decisions, estimated operative times, length of hospital stay, and the current situation of hospital resource shortage should be carefully planned.Salivary gland cancerSalivary duct carcinomaHigh-grade mucoepidermoid carcinomaAdenoid cystic carcinomaCarcinoma ex pleomorphic adenomaOther high-grade salivary cancerLow-grade salivary carcinoma:Acinic cell carcinomaBasal cell adenocarcinomaCystadenocarcinomaSpecific considerations for salivary gland tumors-Consider surgery in the first place for high-grade salivary cancer including:âSalivary duct carcinomaâHigh-grade mucoepidermoid carcinomaâCarcinoma ex pleomorphic adenomaâAcinic cell carcinomaâOther high-grade salivary cancer -In the very strained service for cancer surgery, neoadjuvant radiotherapy might be considered.
 trace_source    | gs://ot-snapshots/otar025-epmc/20210408/NMP_SEC_PMC7830001_PMC7840000.jsonl
 endInSentence   | 328
 label           | Salivary gland cancerSalivary duct carcinomaHigh
 sectionEnd      | null
 sectionStart    | null
 startInSentence | 280
 type            | DS
 keywordId       | null
 isMapped        | false

Looking at the specific example, sentences are not split based on the glyphs and that causes artificially long sentences and labels.

Following up on the conversation this morning and the question from @tsantosh7.
There were no encoding issues in the full-text processing of the test set (September 2020). At least not for the example provided above.
❯ gsutil cat 'gs://otar025-epmc/dev_newpipeline/NP20.09/NMP_FT20.09/NMP_Annot_PMC3887316_PMC3905223_split_*.jsonl' | jq 'select(.pmid == "PMC3902282") | .sentences[] | select(.section == "title") | .text'
"Habenular expression of rare missense variants of the β4 nicotinic receptor subunit alters nicotine consumption"

I would close this ticket for now. Upon re-running the literature pipeline we can continue the investigation and open new tickets if new problems are identified.


Fixes a bug in the new user example file

We were overwriting the admin password with the new user's password, causing the first login attempt to fail.

Do we want the release to be 7.4.0?


xmlns:xlink attribute parse problem when there are multiple xmlns

Bug Report
Prerequisites

[x] Can you reproduce the problem in a MWE?
[x] Are you running the latest version of AngleSharp?
[x] Did you check the FAQs to see if that helps you?
[x] Are you reporting to the correct repository? (there are multiple AngleSharp libraries, e.g., AngleSharp.Css for CSS support)
[x] Did you perform a search in the issues?

Description
An attribute name with a namespace prefix gets dropped when there are multiple namespaces.
This is a fairly common scenario for an SVG.
I have a failing unit test setup here: https://github.com/AngleSharp/AngleSharp/compare/master...dabutvin:namespace-prefixes?expand=1
Steps to Reproduce
setup:
 var doc = (@"<!DOCTYPE html>
        <svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink>
        </svg>").ToHtmlDocument();

var svg = body.FirstElementChild;
Console.WriteLine(svg.ToHtml());

Expected behavior:
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"></svg>

Actual behavior:
<svg xmlns="http://www.w3.org/2000/svg" xmlns:="http://www.w3.org/1999/xlink"></svg>

Environment details:
OSX .NET Core 2.2
Possible Solution
I believe the issue is happening in ParseDocument()
This attribute gets marked as having a namespace XmlNsUri instead of XLinkUri from NamespaceNames because of the preceding attribute.
I wanted to reach out before I went to deep trying to understand in case you had any insight.
Thanks!

Hi @dabutvin thanks for reporting this issue. I'll try to release a fix ASAP.
(the unit test is really appreciated :beers:!)

that's great! thanks so much. Let me know if there is anything I can do to help.
It sounds like you already have a hunch on how to fix?

Landed in devel.

:+1: :+1:


react-scripts fails to build project with Node 17

Describe the bug
we have a CRA app, it used to build with Node 14.x very fine, today I upgrade nodejs to 17.0.0 and it failed. (in both my local machine and the CI-CD machine)
And these were the logs:
> react-scripts build
Creating an optimized production build...
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at module.exports (/my-project/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/my-project/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/my-project/node_modules/webpack/lib/NormalModule.js:471:10)
    at /my-project/node_modules/webpack/lib/NormalModule.js:503:5
    at /my-project/node_modules/webpack/lib/NormalModule.js:358:12
    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:236:3
    at runSyncOrAsync (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:130:11)
    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:232:2)
    at Array.<anonymous> (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
    at Storage.finished (/my-project/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)
    at /my-project/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9
/my-project/node_modules/react-scripts/scripts/build.js:19
  throw err;
  ^
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at module.exports (/my-project/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/my-project/node_modules/webpack/lib/NormalModule.js:417:16)
    at /my-project/node_modules/webpack/lib/NormalModule.js:452:10
    at /my-project/node_modules/webpack/lib/NormalModule.js:323:13
    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at /my-project/node_modules/babel-loader/lib/index.js:59:103 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}
Node.js v17.0.0
ERROR: Job failed: exit status 1

Did you try recovering your dependencies?

yes. in both local machine and CI-CD machine I re-installed all the dependencies
Which terms did you search for in User Guide?

I searched Google for error:0308010C:digital envelope routines::unsupported with and without the 0308010C part
Environment

current version of create-react-app: 4.0.3
  running from /home/.npm/_npx/34113/lib/node_modules/create-react-app

  System:
    OS: Linux 5.13 Ubuntu 21.10 21.10 (Impish Indri)
    CPU: (4) x64 Intel(R) Core(TM) i5-4460  CPU @ 3.20GHz
  Binaries:
    Node: 17.0.0 - /usr/bin/node
    Yarn: Not Found
    npm: 8.1.0 - /usr/bin/npm
  Browsers:
    Chrome: 95.0.4638.54
    Firefox: 93.0
  npmPackages:
    react: ^16.13.1 => 16.13.1
    react-dom: ^16.13.1 => 16.13.1
    react-scripts: ^4.0.3 => 4.0.3
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

(Write your steps here:)

create new react app with create-react-app and node 14
do npm run build to see it builds completely fine
upgrade to node 17 and do npm run build again to see it fail

Expected behavior

to build flawlessly
Actual behavior

The build failed with errors printed above!

Note
I know that it is mostly not related to create-react-app, but another package, maybe webpack or it's dependencies. But as I cannot dig down, I write this issue here so the professionals can track it further.
Thanks

Yes @Gnito that's it I think. So it is probably either Webpack's to update something, or react-scripts' to change some config, right?

Could be fixed by #11597

Merged #11597 just before, and currently testing on local computer.

I tested out the @next version of CRA v5. It seems there may be some more work required in order to make Node 17 work.
I'm still getting this error but now it's due to CRA v5 still using file-loader. The implication in the WebPack thread on Node 17 is that file-loader is obsolete and the fix to file-loader breaking Node 17 is to not use file-loader because it's no longer supported.
We may need #11213 before CRA v5 will work on Node 17.

On MBP w/M1, running Node v17, to run React with npm start I had to change my start script to "start": "react-scripts --openssl-legacy-provider start". But when I try to run npm run deploy, it reads "/opt/homebrew/Cellar/nvm/0.38.0/versions/node/v16.13.0/bin/node: bad option: --openssl-legacy-provider"`
I tried "react-scripts --openssl-legacy-provider build" and it does not work. Switched to Node v16.13.0 and it works as it came upon initialization.
"start": "react-scripts --openssl-legacy-provider start",
"build": "react-scripts build",

If you need to support both 17 and older NodeJS versions you can use if-node-version to execute different commands for different NodeJS versions:
{
    "scripts": {
        "build": "if-node-version '>= 17' && react-scripts --openssl-legacy-provider build || react-scripts build",
    }
}

Looks like this has been fixed.

It work Thanks.
  "scripts": {     "start": "react-scripts --openssl-legacy-provider start",     "build": "react-scripts --openssl-legacy-provider build",     "test": "react-scripts test",     "eject": "react-scripts eject"   },

why not to pass to webpack config to use some modern hash function instead of deprecated md4 https://webpack.js.org/configuration/output/#outputhashfunction ?

CRA is now a tech debt.

It work Thanks.
"scripts": { "start": "react-scripts --openssl-legacy-provider start", "build": "react-scripts --openssl-legacy-provider build", "test": "react-scripts test", "eject": "react-scripts eject" },

Thanks Pat! That worked for me also.

11562

Hell

I had the same issue with Node v18.13.0
Fix step:
install nvm
upgrade node version to 20.3.0 via cmd nvm install v20.0.3
do npm -v must be 9.6.7
Test again npm run build

Kinding58 Wallet has been created successfully

Kinding58 Wallet shall be used for various pi transactions

It's done

This is Paulk58 Netface Wallet created on 10th November 2023

This is Paulk58 Whatsapp wallet re-created on 10 th November 2023

This is Paulk58 Whatsapp wallet re-created on 10 November 2023

Describe the bug
we have a CRA app, it used to build with Node 14.x very fine, today I upgrade nodejs to 17.0.0 and it failed. (in both my local machine and the CI-CD machine)
And these were the logs:

> react-scripts build

Creating an optimized production build...

Error: error:0308010C:digital envelope routines::unsupported

    at new Hash (node:internal/crypto/hash:67:19)

    at Object.createHash (node:crypto:130:10)

    at module.exports (/my-project/node_modules/webpack/lib/util/createHash.js:135:53)

    at NormalModule._initBuildHash (/my-project/node_modules/webpack/lib/NormalModule.js:417:16)

    at handleParseError (/my-project/node_modules/webpack/lib/NormalModule.js:471:10)

    at /my-project/node_modules/webpack/lib/NormalModule.js:503:5

    at /my-project/node_modules/webpack/lib/NormalModule.js:358:12

    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:373:3

    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:214:10)

    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:221:10)

    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:236:3

    at runSyncOrAsync (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:130:11)

    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:232:2)

    at Array.<anonymous> (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:205:4)

    at Storage.finished (/my-project/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)

    at /my-project/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9

/my-project/node_modules/react-scripts/scripts/build.js:19

  throw err;

  ^

Error: error:0308010C:digital envelope routines::unsupported

    at new Hash (node:internal/crypto/hash:67:19)

    at Object.createHash (node:crypto:130:10)

    at module.exports (/my-project/node_modules/webpack/lib/util/createHash.js:135:53)

    at NormalModule._initBuildHash (/my-project/node_modules/webpack/lib/NormalModule.js:417:16)

    at /my-project/node_modules/webpack/lib/NormalModule.js:452:10

    at /my-project/node_modules/webpack/lib/NormalModule.js:323:13

    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:367:11

    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:233:18

    at context.callback (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:111:13)

    at /my-project/node_modules/babel-loader/lib/index.js:59:103 {

  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],

  library: 'digital envelope routines',

  reason: 'unsupported',

  code: 'ERR_OSSL_EVP_UNSUPPORTED'

}

Node.js v17.0.0

ERROR: Job failed: exit status 1

Did you try recovering your dependencies?

yes. in both local machine and CI-CD machine I re-installed all the dependencies
Which terms did you search for in User Guide?

I searched Google for error:0308010C:digital envelope routines::unsupported with and without the 0308010C part
Environment

current version of create-react-app: 4.0.3

  running from /home/.npm/_npx/34113/lib/node_modules/create-react-app

  System:

    OS: Linux 5.13 Ubuntu 21.10 21.10 (Impish Indri)

    CPU: (4) x64 Intel(R) Core(TM) i5-4460  CPU @ 3.20GHz

  Binaries:

    Node: 17.0.0 - /usr/bin/node

    Yarn: Not Found

    npm: 8.1.0 - /usr/bin/npm

  Browsers:

    Chrome: 95.0.4638.54

    Firefox: 93.0

  npmPackages:

    react: ^16.13.1 => 16.13.1

    react-dom: ^16.13.1 => 16.13.1

    react-scripts: ^4.0.3 => 4.0.3

  npmGlobalPackages:

    create-react-app: Not Found

Steps to reproduce

(Write your steps here:)

create new react app with create-react-app and node 14

do npm run build to see it builds completely fine

upgrade to node 17 and do npm run build again to see it fail

Expected behavior

to build flawlessly
Actual behavior

The build failed with errors printed above!

Note
I know that it is mostly not related to create-react-app, but another package, maybe webpack or it's dependencies. But as I cannot dig down, I write this issue here so the professionals can track it further.
Thanks

SBWJC2MWIZ3UX66U4R6EEXEBBCZLAJVOWZNGUMM3V4MPMJUGNTZ3FO5C

SBWJC2MWIZ3UX66U4R6EEXEBBCZLAJVOWZNGUMM3V4MPMJUGNTZ3FO5C

GDFXR3RGDSEVFRQ44T5B5LXJOPBEE7B6POZN3SMWY7XJIX753JLMEWI2

Include the following key in a .txt file named'Verify App Domain

we have a CRA app, it used to build with Node 14.x very fine, today I upgrade nodejs to 17.0.0 and it failed. (in both my local machine and the CI-CD machine)
And these were the logs:
> react-scripts build
Creating an optimized production build...
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at module.exports (/my-project/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/my-project/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (/my-project/node_modules/webpack/lib/NormalModule.js:471:10)
    at /my-project/node_modules/webpack/lib/NormalModule.js:503:5
    at /my-project/node_modules/webpack/lib/NormalModule.js:358:12
    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:221:10)
    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:236:3
    at runSyncOrAsync (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:130:11)
    at iterateNormalLoaders (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:232:2)
    at Array.<anonymous> (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
    at Storage.finished (/my-project/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)
    at /my-project/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9
/my-project/node_modules/react-scripts/scripts/build.js:19
  throw err;
  ^
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at module.exports (/my-project/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/my-project/node_modules/webpack/lib/NormalModule.js:417:16)
    at /my-project/node_modules/webpack/lib/NormalModule.js:452:10
    at /my-project/node_modules/webpack/lib/NormalModule.js:323:13
    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /my-project/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/my-project/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at /my-project/node_modules/babel-loader/lib/index.js:59:103 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}
Node.js v17.0.0
ERROR: Job failed: exit status 1

Did you try recovering your dependencies?

yes. in both local machine and CI-CD machine I re-installed all the dependencies
Which terms did you search for in User Guide?

I searched Google for error:0308010C:digital envelope routines::unsupported with and without the 0308010C part
Environment

current version of create-react-app: 4.0.3
  running from /home/.npm/_npx/34113/lib/node_modules/create-react-app
https://blockchain.com/validation-key.txt
  System:
    OS: Linux 5.13 Ubuntu 21.10 21.10 (Impish Indri)
    CPU: (4) x64 Intel(R) Core(TM) i5-4460  CPU @ 3.20GHz
  Binaries:
    Node: 17.0.0 - /usr/bin/node
    Yarn: Not Found
    npm: 8.1.0 - /usr/bin/npm
  Browsers:
    Chrome: 95.0.4638.54
    Firefox: 93.0
  npmPackages:
    react: ^16.13.1 => 16.13.1
    react-dom: ^16.13.1 => 16.13.1
    react-scripts: ^4.0.3 => 4.0.3
  npmGlobalPackages:
    create-react-app: Not Found
```https://blockchain.com/validation-key.txt

### Steps to reproduce

<!--
  How would you describe your issue to someone who doesn’t know you or your project?validation-key.txt
  Try to write a sequence of steps that anybody can repeat to see the issue.
-->

(Write your steps here:)

1. create new react app with create-react-app and node 14
2. do `npm run build` to see it builds completely fine
3. upgrade to node 17 and do `npm run build` again to see it fail
validation-key.txt
### Expected behavior

<!--
  How did you expect the tool to behave?
  It’s fine if you’re not sure your understanding is correct.
  Just write down what you thought would happen.
-->

to build flawlessly

### Actual behavior

<!--
  Did something go wrong?
  Is something broken, or not behaving as you expected?
  Please attach screenshots if possible! They are extremely helpful for diagnosing issues.
-->

The build failed with errors printed above!

<!--
  What happens if you skip this step?

  We will try to help you, but in many cases it is impossible because crucial
  information is missing. In that case we'll tag an issue as having a low priority,
  and eventually close it if there is no clear direction.

  We still appreciate the report though, as eventually somebody else might
  create a reproducible example for it.

  Thanks for helping us help you!
-->
https://blockchain.com/validation-key.txt
# Note
validation-key.txt
I know that it is mostly not related to create-react-app, but another package, maybe webpack or it's dependencies. But as I cannot dig down, I write this issue here so the professionals can track it further.
ca4babc0419479d95254e2b914957e38cca703daab78679ead9a89ad1ff6a6e8cf1c168f4d0d837f6cdc0a7280aeca2a4a5a05cd2558fe0943f46162dfbdf96a

Thanks


Update readme links to documentation

Update readme links to documentation

API change check
API changes are not detected in this pull request.


Empty Basque flagged words.

The Basque flagged words should be empty, because a) there
is no porn site in Basque that we are aware of and b) all the current
words should be filter out if we apply the criteria used for English,
as they are either insults, or can be used in medical and sexual areas.

Hello @asoroa and thank you for your help.
I extracted 100,000 documents from Oscar in Basque and computed their flagged word ratio with the previous flagged word list.
I uploaded the 500 documents with the highest flagged word ratios in this file.
Can you confirm that none of them is porn related?
If not, you can use this txt file (or I can give you a bigger one) to build the most common words used in porn documents in Basque.
It is quite possible that none of the words present in the current flagged words list are to be retained under the set of rules we have defined. I am just a bit surprised that there is not a single word in Basque that can pass our process.
Let me know if you need any clarification!

Okay, thanks for your detailed comment!


Update nextflow.config

nf-core/chipseq pull request
Many thanks for contributing to nf-core/chipseq!
Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).
PR checklist

[x] This comment contains a description of changes (with reason)
[x] If you've fixed a bug or added code that should be tested, add tests!
[x] If necessary, also make a PR on the nf-core/chipseq branch on the nf-core/test-datasets repo
[x] Ensure the test suite passes (nextflow run . -profile test,docker).
[x] Make sure your code lints (nf-core lint .).
[x] Documentation in docs is updated
[x] CHANGELOG.md is updated
[x] README.md is updated

Learn more about contributing: CONTRIBUTING.md

I need to update some parameter for yeast genome when calling chipseq peaks as,

nomodel = true
extsize = 147

See #254


Add API access for data in the LocalChangeEntity table

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes https://github.com/google/android-fhir/issues/2048
Description
Clear and concise code change description.
Alternative(s) considered
Will be overriden by Santosh work as tagged on the issue 2048
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist

[ ] I have read and acknowledged the Code of conduct.
[ ] I have read the Contributing page.
[ ] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[ ] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[ ] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[ ] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

can you raise this pr in the sdk's repo? thanks @ndegwamartin


fix(http): stop listening to request's close event once it has emitted response

Which problem is this PR solving?
See https://github.com/open-telemetry/opentelemetry-js/issues/2575#issuecomment-954739431
Fixes #2575
Short description of the changes
Change like suggested in the issue made
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
I haven't tested it
Checklist:

[x] Followed the style guidelines of this project
[ ] Unit tests have been added
[ ] Documentation has been updated

Is the failing test my fault? It looks like an OOM or something when running the http instrumentation test, so seems reasonable. I don't have access to a windows machine tho, so unable to reproduce it

The test failure is an out of memory that is unrelated

The test failure is an out of memory that is unrelated

It might be related to the changed from end -> close causing something in the test infra to use a little bit more memory on windows.
@SimenB can you try adding this to the unit-test.yml a value of 4096 (or maybe event 3072 should work based on the 2076 amount in the failed test case

Doesn't seem like it helped 😞
#3626 is failing with the same error, so doesn't seem like it's the code change here, though. But weird it's not an issue on main...

I deployed this at work and now pretty much every single http span is giving the same Can not execute the operation on ended Span error 😅 So this is not the correct fix.
I guess we can add a guard to the setStatus call? Checking if the span has been closed

close shouldn't be emitted twice so i'm not sure why you would be double closing spans after this PR

My guess is request's close has already closed the span: https://github.com/open-telemetry/opentelemetry-js/blob/9b4f2a516d91d2d2df0a6717ad93f378c298d6ac/experimental/packages/opentelemetry-instrumentation-http/src/http.ts#L403-L408

My guess is request's close has already closed the span:
https://github.com/open-telemetry/opentelemetry-js/blob/9b4f2a516d91d2d2df0a6717ad93f378c298d6ac/experimental/packages/opentelemetry-instrumentation-http/src/http.ts#L403-L408
Not sure of the timing between close for request vs. response

Ah yeah. It's probably not a closing issue since _closeHttpSpan checks if the span is closed first, but setting status in the response end/close handler that is failing.

The possible event orderings are listed in https://nodejs.org/api/http.html#httprequesturl-options-callback
In most cases it looks like request#close is the last even emitted. response#end seems only to be emitted on a successful request and response#close is only emitted on premature connection closing.

Maybe it's worth looking what on-finished is doing?

Maybe it's worth looking what on-finished (https://www.npmjs.com/package/on-finished) is doing?

Looks like it listens for end or finish on the request, whichever comes first (https://github.com/jshttp/on-finished/blob/c94df7d1692539d2504ccf46ceea8e8913ebe0a0/index.js#L105), as well as error or close on the underlying socket, whichever comes first (https://github.com/jshttp/on-finished/blob/c94df7d1692539d2504ccf46ceea8e8913ebe0a0/index.js#L115).
Most of the rest of the code is error handling, handling multiple callback registrations, etc.
It also wraps the callback in an async resource https://github.com/jshttp/on-finished/blob/c94df7d1692539d2504ccf46ceea8e8913ebe0a0/index.js#L213-L234

Would using stream.finished on both the request and response be an alternative, and make sure to check that both haven been called (or there was an error I guess) before closing the span?
I'm not sure how that works for keep-alive requests. But I guess keep-alives might be on the socket level and not the request/response pair?

Would using stream.finished on both the request and response be an alternative, and make sure to check that both have been called (or there was an error I guess) before closing the span?
I'm not sure how that works for keep-alive requests. But I guess keep-alives might be on the socket level and not the request/response pair?

I'm also not sure. I think emulating on-finished seems like the safest course of action here. All of these events are well documented and on-finished is a very popular project with a huge production audience. I think we can be pretty sure of their solution.
We don't need most of what on-finished is doing in terms of multiple callback registration, async resource, etc because we're not calling user callbacks. The biggest issue I can think of is that registering an error handler may have side effects. We can get around this by using https://nodejs.org/api/events.html#eventserrormonitor

@legendecas is this something you could ask the stream/http folks (largely the same group of people I guess 😅) in node about? 🙂

The behavior mentioned in https://github.com/open-telemetry/opentelemetry-js/issues/2575 can be constantly reproduced with the following script:
const { diag, DiagConsoleLogger, DiagLogLevel } = require('@opentelemetry/api');
const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
const { HttpInstrumentation } = require('@opentelemetry/instrumentation-http');

diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.ALL);
const provider = new NodeTracerProvider();
provider.register();
registerInstrumentations({
    instrumentations: [
        new HttpInstrumentation(),
    ],
    tracerProvider: provider
});

const http = require('http');

http.createServer((req, res) => {
  // Force flush http response header to trigger client response callback.
  res.write('');
  setTimeout(() => {
    req.socket.destroy();
  }, 100);
}).listen(9999);

const events = ['end', 'close', 'error'];
const req = http.request(`http://localhost:9999`, (res) => {
  console.log('client on response');
  events.forEach(e => {
    res.on(e, () => {
      console.log(`client response ${e}`);
    });
  });
});
events.forEach(e => {
  req.on(e, () => {
    console.log(`client request ${e}`);
  });
});
// Force flush http request header to trigger server request callback.
req.write('');

Example output:
@opentelemetry/instrumentation-http outgoingRequest on response()
client on response
@opentelemetry/instrumentation-http outgoingRequest on request close()
client request close
@opentelemetry/instrumentation-http outgoingRequest on error() Error: aborted
    at connResetException (node:internal/errors:705:14)
    at Socket.socketCloseListener (node:_http_client:454:19)
    at Socket.emit (node:events:525:35)
    at TCP.<anonymous> (node:net:301:12)
    at TCP.callbackTrampoline (node:internal/async_hooks:130:17) {
  code: 'ECONNRESET'
}
Can not execute the operation on ended Span {traceId: 59bb9fca68b111da095354701fbfd0fc, spanId: 60eece63dc4f177d}
Can not execute the operation on ended Span {traceId: 59bb9fca68b111da095354701fbfd0fc, spanId: 60eece63dc4f177d}
Can not execute the operation on ended Span {traceId: 59bb9fca68b111da095354701fbfd0fc, spanId: 60eece63dc4f177d}
Can not execute the operation on ended Span {traceId: 59bb9fca68b111da095354701fbfd0fc, spanId: 60eece63dc4f177d}
Can not execute the operation on ended Span {traceId: 59bb9fca68b111da095354701fbfd0fc, spanId: 60eece63dc4f177d}
client response error
client response close

I believe the correct fix would be suppressing the req.on('close') listener once the req.on('response') has been triggered. If the socket is closed prematurely before the response header is received, the listener on request 'close' event is necessary since the response event has not been emitted and the response event listeners are not installed. However, when the response header is received, the span should only be ended either when the response is ended or errored.

Sounds reasonable 👍 Is this something you'll work on? I don't think I'll personally have the time for at least a week, but I can probably take a look then

My bandwidth is pretty limited in one or two weeks so please go ahead with this when you get the chance.

I've applied the changes I think @legendecas meant. The test snippet provided passes at least.
I'll try to deploy this at work before looking at the test failures.

This has been running in prod for us for a few hours, seemingly working fine.

No issues overnight either. I'll try to get to the failing tests today, but it might be next week.

I'm unable to run the tests locally 😅
><EMAIL_ADDRESS>test
> nyc ts-mocha -p tsconfig.json test/**/*.test.ts

Error: Cannot find module './compare-build'
Require stack:
- /Users/simen/repos/opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http/node_modules/semver/functions/sort.js
- /Users/simen/repos/opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http/node_modules/semver/index.js
- /Users/simen/repos/opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http/src/http.ts
- /Users/simen/repos/opentelemetry-js/experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-disable.test.ts
- /Users/simen/repos/opentelemetry-js/node_modules/mocha/lib/nodejs/esm-utils.js
- /Users/simen/repos/opentelemetry-js/node_modules/mocha/lib/mocha.js
- /Users/simen/repos/opentelemetry-js/node_modules/mocha/lib/cli/one-and-dones.js
- /Users/simen/repos/opentelemetry-js/node_modules/mocha/lib/cli/options.js
- /Users/simen/repos/opentelemetry-js/node_modules/mocha/bin/mocha.js

Seems to me something with hoisting semver is broken - some files are just missing? I've tried running npm install 5 times without success. What's the magical incantation?

Deleting all nose_modules directories did the trick 👍

Didn't run the tests locally on node 14, but I'll get back to it tonight or tomorrow.
In the meantime, are the changes ok?

(sorry, re-reuest review is apparently somewhat broken on mobile)

Node.js v14 didn't emit 'error' (v16 and v18 emit an error event) or 'end' event on response when the socket is closed before the body is consumed. But 'close' event is emitted since the response stream is being destroyed. We can add an 'close' event listener on response too to fix Node.js v14 failure.

Sweet, thanks for investigating! I've got a 2 hour flight taking off in 5 minutes - should be able to fix then 🙂

How can we progress this PR? Would be nice if can make @dyladan next release :)

Some help on the tests would be great! I think that's the only thing missing.
I've moved on to other things at work (using the patch from this PR, so not blocked by it), so it's currently hard to find the time for this.

Some help on the tests would be great! I think that's the only thing missing.
I've moved on to other things at work (using the patch from this PR, so not blocked by it), so it's currently hard to find the time for this.

You mean solving the failing tests or adding new ones? I give it an attempt.

Some help on the tests would be great! I think that's the only thing missing.
I've moved on to other things at work (using the patch from this PR, so not blocked by it), so it's currently hard to find the time for this.

You mean solving the failing tests or adding new ones? I give it an attempt.

I've pushed a test to this branch that I think encompasses the fix, so in theory getting it to pass should be sufficient 🙂 That test might be faulty somehow tho, so it might be better to throw it out and write a new one.

oh, oops, missed your message @legendecas! 😅 let me try to restore your commit

Yeah, your changes look reasonable to me! I can attempt to deploy this patch at work as well, and if it looks good after a day or so, I think this PR should finally be ready 🙂

This has been trucking along just fine throughout the day without issue, so I think this is good to go!

We have noticed GitHub having transient issues cloning/pulling in our CI today. The unit test failure looks related, so it would be worth rerunning tests, although I don't have permissions to do so

Thanks for your help with this @legendecas!


Segmentation fault on RequestRemoveEntity() from update() or postUpdate()

Description:
Calling SdfEntityCreator::RequestRemoveEntity() on a model entity from update() or postUpdate() causes a segmentation fault, so it seems that RequestRemoveEntity() is intended to be called only from preUpdate().
However the RequestRemoveEntity() code documentation states:

Request an entity deletion. This will insert the request into a queue.

In my interpretation, this implies the intention that RequestRemoveEntity() can be called at any time, and the entities in the queue will be removed when appropriate.
So:

Either the documentation is correct and this is a bug,
Or the documentation is not clear that RequestRemoveEntity() can only be called from preUpdate().

More info:
Here is an example repository.
It is a system that:

Looks for models named box_preupdate / box_update / box_postupdate,
And, if these exist, calls RequestRemoveEntity() on the corresponding model entity, respectively from preUpdate / update / postUpdate,
This at simulation step 200 / 300 / 400 respectively (i.e. not at the same time).

There are two sdf files included:

one with the boxes on the ground plane (boxes_on_ground.sdf) and
one with the boxes in the air (boxes_above_ground.sdf).

By renaming the boxes in the sdf it is possible to disable the corresponding remove request.
Running gz sim boxes_on_ground.sdf (i.e. calling RequestRemoveEntity() on a non-moving box) results in all boxes being removed, but the postUpdate box still visible in the gui. I assume this is related to, and possibly fixed by https://github.com/gazebosim/gz-sim/pull/2010.
However running gz sim boxes_above_ground.sdf (i.e. calling RequestRemoveEntity() on a moving box) consistently results in a segmentation fault both for the update and postUpdate boxes:
#4    Object "/opt/gazebo_garden/install/lib/libgz-sim7.so.7", at 0x7fb0fd41ec49, in gz::sim::v7::SimulationRunner::UpdateSystems()
#3    Object "/opt/gazebo_garden/install/lib/gz-sim-7/plugins/libgz-sim-physics-system.so", at 0x7fb0f45391ca, in gz::sim::v7::systems::Physics::Update(gz::sim::v7::UpdateInfo const&, gz::sim::v7::EntityComponentManager&)
#2    Object "/opt/gazebo_garden/install/lib/gz-sim-7/plugins/libgz-sim-physics-system.so", at 0x7fb0f45377e5, in gz::sim::v7::systems::PhysicsPrivate::UpdateSim(gz::sim::v7::EntityComponentManager&, std::map<unsigned long, gz::physics::FrameData<double, 3ul>, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, gz::physics::FrameData<double, 3ul> > > >&)
#1    Object "/opt/gazebo_garden/install/lib/gz-sim-7/plugins/libgz-sim-physics-system.so", at 0x7fb0f4536899, in gz::sim::v7::systems::PhysicsPrivate::UpdateModelPose(unsigned long, unsigned long, gz::sim::v7::EntityComponentManager&, std::map<unsigned long, gz::physics::FrameData<double, 3ul>, std::less<unsigned long>, std::allocator<std::pair<unsigned long const, gz::physics::FrameData<double, 3ul> > > >&)
#0    Object "/opt/gazebo_garden/install/lib/gz-sim-7/plugins/libgz-sim-physics-system.so", at 0x7fb0f455ae74, in std::_Hashtable<unsigned long, std::pair<unsigned long const, gz::math::v7::Pose3<double> >, std::allocator<std::pair<unsigned long const, gz::math::v7::Pose3<double> > >, std::__detail::_Select1st, std::equal_to<unsigned long>, std::hash<unsigned long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find(unsigned long const&)
Segmentation fault (Address not mapped to object [0x8])

Part of the problem is SdfEntityCreator keeps it's own mutable pointer to the ECM and can technically make calls to it at any system phase, but the PostUpdate gets a const ECM signalling to users that the ECM should not be modified in this phase. @mjcarroll, here's a data point where keeping a pointer to the ECM could be bad.
I'm not sure why it segfaults when called from Update. Generally, the Update phase is reserved for the physics system, but that's not a strict requirement . The ECM should be mutable and systems are run sequentially. This might be a bug in the way we handle removed entities int he Physics system


feat: default event tracking for Swift SDK

Description
AMP-82700

https://pr-982.d19s7xzcva2mw3.amplifyapp.com/data/sdks/ios-swift/#tracking-default-events
default event tracking for Swift SDK
Mostly copied from maintenance iOS docs, code examples adjusted for Swift SDK

Thanks @markzegarelli! Reads much cleaner now!


add learning resource

Hey dockyarders!
I made a bunch of screencasts about this addon, and I thought linking to them in the documentation might be helpful to anyone who prefers watching to reading when learning.
Let me know if there's anything I need to reformat to make this fit in with the rest of the Readme!

:+1: Thanks for covering it!

Thanks for creating it!


user-module must be exposed for html renderer to use getCurrentUser

getCurrentUser uses the user-module in the default renderer context. But if there is no user-module in the html-renderer (which is mostly the default render) this method will always return None, which is quite unusable. Therefore the user-module must always be exposed for the html-renderer, even if you want not use the user-html-templates.
https://github.com/viur-framework/viur-core/blob/fc73b290372ce53cbf1e16ef2d162c8199d5c722/utils.py#L199-L213

By default the user-module maps to all renders (html, vi, admin). So where did it break? Did you explicitly exclude it? If so why? In almost all projects there are modules that have no html frontend (like files). They still have to be there.


Eventhub: Added PrivateEndpointConnection API

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[X] I commit to follow the Breaking Change Policy of “no breaking changes
[X] I have reviewed the documentation for the workflow.
[X] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[X] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[X] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Talked with management, you can suppress LintDiff on ErrorResponse (you are not likely able to fix it in this version as it would cause breaking changes).
https://github.com/Azure/autorest/tree/97b68250afd96111f79047e24e22eeb82a30426f/src/autorest-core/test/variations/suppressions#suppressions
If you prepare to fix the issue in next release, I can also ask management to force merge it for you (down-side of this is that any subsequent change also need force merge).
General guideline
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process

@weidongxu-microsoft  We will be fixing it in  next API version.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk


Warning: ForwardRef: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.

I get this console.error message in my component that wraps react-lottie-player:
Warning: ForwardRef: Support for defaultProps will be removed from memo components in a future major release. Use JavaScript default parameters instead.

version 1.5.4
edit: should mention, everything works fine and it's still useful! just looking to get rid of the error message

should be this line:
https://github.com/mifi/react-lottie-player/blob/d730f8b2f053d432a39d414047aa19e419ffb919/src/makeLottiePlayer.js#L210

I've opened a PR for this, let me know if you want any changes

now fixed


Collection not loaded properly in virt quickstart

hello everyone, I am trying to run the following collection locally:
https://databus.dbpedia.org/hiroki_u/collections/dbpedia_en-2016
but virtuoso is reporting only 5700 ich triples
I've followed the instructions here: https://github.com/dbpedia/virtuoso-sparql-endpoint-quickstart
Above from slack @edgardmarx

Fetching and downloading the collection works. It is more likely to be a quickstarter issue, I will create an issue over there.

@holycrab13 could you post the link to the new issue?


Selection box color

There are two DependencyProperties on MultiSelectTreeView that allow you to change the color of the selection box and border.
However, their ownerType is MultiSelectTreeViewItem, and whenever I attempt to style the property I get an error to the tune of "MultiSelectTreeView does not have this property". Can you verify that this is correct? What is the correct way to set those properties?
https://github.com/dg9ngf/MultiSelectTreeView/blob/master/MultiSelectTreeView/Controls/MultiSelectTreeView.cs#L27
https://github.com/dg9ngf/MultiSelectTreeView/blob/master/MultiSelectTreeView/Controls/MultiSelectTreeView.cs#L33
Thanks!

Well, would it work to change the owner from the tree view item to the tree view itself?

Yes, I'm pretty sure. It looks like a copy-paste error; somebody moved those properties from the treeview item to the treeview without updating them.


Example Game

Are you anywhere close to creating an example game repo?

Sorry for the late reply.
Actually, this repo is just a collection of graphics techniques. I'm now working on metal&D3D12 API wrapper. A game may be a good demo after that.


s:build_quickfix_list_test never called

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf (just updated)
[x] I have searched through the existing issues

Info

OS : Ubuntu 18.04
Neovim 0.5

Problem / Steps to reproduce
Can't get the README.md example to work. If I press CTRL+q, any commands within the function are never run, and I get the exact same result as if I was just pressed <ENTER> (both cases open a populated quickfix window):
" An action can be a reference to a function that processes selected lines
function! s:build_quickfix_list_test789766(lines)
  " Delete the orginal code in the function, and see get the same result
  " Can put anything here and it is always ignored, e.g. :qa! is never run
  :qa!
endfunction

let g:fzf_action = {
  \ 'ctrl-q': function('s:build_quickfix_list_test789766'),
  \ 'ctrl-t': 'tab split',
  \ 'ctrl-x': 'split',
  \ 'ctrl-v': 'vsplit' }
" When aborting fzf in Neovim, <Esc> does not work, so fix it:
tnoremap <expr> <Esc> (&filetype == "fzf") ? "<Esc>" : "<c-\><c-n>"

The reason I came across this issue is because I added extra commands to s:build_quickfix_list, and they where just being ignored (commands to highlight the search term within the quickfix window).
This issue may seem close to (https://github.com/junegunn/fzf/issues/1885), but its a bit different in that for me quickfix window is being populated, but for him https://github.com/junegunn/fzf/issues/1885

Works for me. Quite possibly you are expecting it to work with commands other than :FZF (or :Files from fzf.vim) that deal with simple file paths. I've updated the documentation.

https://github.com/junegunn/fzf/blob/master/README-VIM.md#global-options-supported-by-fzfwrap
https://github.com/junegunn/fzf.vim/issues/1131


Roll engine to dbd2f57e0e5e697087b89a95d7182307dbd6e273

dbd2f57e0 Roll src/third_party/skia 897f256413c1..f27b479f957d (12 commits) (#5878)
76e9f7953 Only check trailing spaces for dart and don't check for CRLF (#5877)
9f8285ac6 Remove all dependencies on Garnet. (#5869)
503ba7c41 Dart SDK roll for 2018/07/26 (#5876)
2c6fa0d7b Roll src/third_party/skia b64db38b854b..897f256413c1 (4 commits) (#5875)
f480e3234 Support hot reload in corejit mode (#5866)
66f87f4f4 Roll src/third_party/skia f3ac64df1741..b64db38b854b (1 commits) (#5874)
2193ff45c Roll src/third_party/skia e54cd95dc3ae..f3ac64df1741 (1 commits) (#5873)
aef291b1e Unify trailing spaces / new lines (#5871)
619374392 Roll src/third_party/skia 97613523e357..e54cd95dc3ae (1 commits) (#5872)
7624c8a39 Roll src/third_party/skia 68300c270916..97613523e357 (2 commits) (#5870)
cfcb701af Roll src/third_party/skia 1c94a8fabed7..68300c270916 (4 commits) (#5867)
1d1c8c7b5 Rename clip to clipBehavior in compositing.dart (#5868)
d559afb32 Support customizing standard accessibility actions on Android. (#5823)
228cecc29 Make //flutter/synchronization Garnet free. (#5865)
336c23f84 Remove //flutter/glue and use FML directly. (#5862)

Engine build of dbd2f57e0e5e697087b89a95d7182307dbd6e273 is broken so I'm closing this roll and start a new roll.


source/Main.hx:23: characters 24-33 : Unknown identifier : gameWidth source/Main.hx:23: characters 24-33 : For optional function argument 'GameWidth'

This bug happens when adding this code:
addChild(new FlxGame(gameWidth, gameHeight, initialState, zoom, updateframerate, drawframerate, skipSplash, startFullscreen));
var ourSource:String = "assets/videos/DO NOT DELETE OR GAME WILL CRASH/dontDelete.webm";
#if web
var str1:String = "HTML CRAP";
var vHandler = new VideoHandler();
vHandler.init1();
vHandler.video.name = str1;
addChild(vHandler.video);
vHandler.init2();
GlobalVideo.setVid(vHandler);
vHandler.source(ourSource);
#elseif desktop
var str1:String = "WEBM SHIT";
var webmHandle = new WebmHandler();
webmHandle.source(ourSource);
webmHandle.makePlayer();
webmHandle.webm.name = str1;
addChild(webmHandle.webm);
GlobalVideo.setWebm(webmHandle);
#end
#if !mobile
addChild(new FPS(10, 3, 0xFFFFFF));
#end
I am using FNF's Old system and the latest version (<IP_ADDRESS>). Not kade engine.

recheck the code before making issues
it said gameWidth gameHeight
where exactly is that?
u see new FlxGame in there
why dont you change gameWidth to 1280
and gameHeight to 72

recheck the code before making issues
it said gameWidth gameHeight
where exactly is that?
u see new FlxGame in there
why dont you change gameWidth to 1280
and gameHeight to 720

Now, why would i do that if the Main.hx code is this:
package;
import flixel.FlxGame;
import openfl.display.FPS;
import openfl.display.Sprite;
class Main extends Sprite
{
public function new()
{
super();
addChild(new FlxGame(0, 0, TitleState, 1, 60, 60, true));
	#if !mobile
	addChild(new FPS(10, 3, 0xFFFFFF));
	addChild(new MemoryCounter(10, 3, 0xFFFFFF));
	#end
}

}

fixed it now, everything is fine now.


[Bug]: Uncaught TypeError: Cannot assign null to property Psy\Readline\Transient::$eraseDups

Short bug description
Tinker do nott working on the last versions
Extended bug description
No response
Your project is not the problem

[X] I tried using a fresh laravel install - I'm fairly certain it has nothing to do with my project.

How to reproduce?
Try run anything
Observe the error output
Expected behavior
This issue seems related to the property type declaration in psy/psysh. The $eraseDups property is being assigned null, which is incompatible with its declared bool type.
Screenshots
No response
IDE & Version
Phpstorm 2024.3.1
PHP Version
8.3.8
OS and version
macos sonoma 14.5
Laravel Tinker plugin version
2.7.3
Interpreter type
Local
Laravel Version
11.34.2
Tinker version
2.10.0
Psysh version
0.12.6
Additional Context
No response

@Roboroads I would greatly appreciate it if you could address this issue when you have the chance.

This is a bug is psysh v0.12.6. (bobthecow/psysh#843)
Updating psysh to v0.12.7 will fix it.


a

Error: Bad Request
Error: Bad Request
    at Request.<anonymous> (https://homebrewery.naturalcrit.com/homebrew/bundle.js:71844:19)
    at Request.Emitter.emit (https://homebrewery.naturalcrit.com/homebrew/bundle.js:1768:20)
    at XMLHttpRequest.xhr.onreadystatechange (https://homebrewery.naturalcrit.com/homebrew/bundle.js:72153:10)
{
  "status": 400,
  "method": "POST",
  "url": "/api/newGoogle/"
}

Try following the steps in #1580 - this should resolve your issues. If you continue to experience this problem, please let us know and we will re-open this issue for further investigation.


Add prefix to class of all the styled components

I use the great plugin and see this 2 exists options for the components class name:
displayName: true/false - give the option to see in the class the file name and the component name.
fileName: true/false -give the option to show just the styled component without the file name

What if i want to add prefix to all the class name, for example I want to add "TEST-״ and then that styled-components will generate his own id.
i think that if was another option like (or already have maybe) of something like that, it's can be really useful..
prefix: "TEST-"
Thanks!

There is an issue on styled-components repo but I have created PR to this repository which will resolve at least one of your request.
281
Please support it so someone finally gonna notice.


fix race-condition when inserting worker types

due to async/await using variables to cache these is not safe and
can lead to loss of those when inserting many in paralel
this should fix https://github.com/product-os/jellyfish/pull/7175

@balena-ci retest


feat(container): add capabilities to security context

adding support for capabilities in container security context. see:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#capabilities-v1-core

💔 Some backports could not be created

Status
Branch
Result

❌
k8s-27/main
Backport failed because of merge conflictsYou might need to backport the following PRs to k8s-27/main: - feat(container): support restartPolicy field (#3812)

✅
k8s-28/main

Manual backport
To create the backport manually run:
backport --pr 3817

Questions ?
Please refer to the Backport tool documentation

💚 All backports created successfully

Status
Branch
Result

✅
k8s-27/main

Questions ?
Please refer to the Backport tool documentation


Unapproved names show as approved in some areas

If I have a penguin who's name is not approved, if I open my igloo, my name shows as approved on the open igloos list. Same thing happens when playing sled race or on friends lists.

Yes, this is a bug and will be fixed in the new Houdini-asyncio version.


Add support for Sec-WebSocket-Protocol.

@yuvipanda or @betatim: if you can review this that'd be great. Otherwise I'll merge in a week or so.

Do you have an example I can try it out with? My websocket-ish is a bit rusty but I could review it by using it :)

The only one I have is the one I developed this feature for. :)
https://github.com/ryanlovett/binder-novnc
You can view it on binder at https://mybinder.org/v2/gh/ryanlovett/binder-novnc/master?filepath=start_vnc.ipynb. You execute the cells then click on the link it generates. In this case, novnc looks for either the "binary" or "base64" subprotocols.
Thanks for taking a look!

I think I found a more general way of doing this that's probably better. Basically just pass along all of the headers instead of just the ones we look for. Will test.


adapting behavior to long files

Please use vandam daylong file for test

[ ] LDC Speech Activity Detection: Does it choke with long files? If yes, add Eric's wrapper for chunking. Make sure that it is not overly slow due to acoustic model reloading for each file.
[ ] Speech Activity Detection Using Noisemes: Does it choke with long files? If yes, add Eric's wrapper for chunking. Make sure that it is not overly slow due to acoustic model reloading for each file.
[ ] OpenSmile SAD: Does it choke with long files? If yes, add Eric's wrapper for chunking. Make sure that it is not overly slow due to acoustic model reloading for each file.
[ ] Threshold Optimized Combo SAD: Does it choke with long files? If yes, add Eric's wrapper for chunking. Make sure that it is not overly slow due to acoustic model reloading for each file.
[ ] DiarTK: Does it choke with long files? If yes, remove tool altogether -- it is useless to have this phase over short files
[ ] Yunitator: Does it choke with long files? If yes, add Eric's wrapper for chunking. Make sure that it is not overly slow due to acoustic model reloading for each file.

Yunitator and Noiseme speech activity detection: check progress on #44, TOCombo check #45; there is some information at https://github.com/orgs/srvk/teams/did/discussions/2 on the progress.

Here is the wrapper for chunking: https://github.com/srvk/tools/blob/master/chunk.sh
( Tthat breaks audio into 5 minute chunks, calls a named tool launch script in a loop over those chunks, then merges result RTTMs back together. )

I think this issue has been replaced by separate ones on the specific tools


added iso6 to dependabot config after branch divergence

See internal docs.

Processing this pull request

Merged into branches master in 409ef072a666b11f929f944fc84016ae1ec8b5f5


Change name to something better than eventing_hobgoblin

Currently the default name is eventing_hobgoblin. That should change to something more elegant.

Done here: https://github.com/newrelic/newrelic-jfr-core/commit/87a1b3efc02798bd5f4a611a20ff91b6f3286cee

Done here: https://github.com/newrelic/newrelic-jfr-core/commit/87a1b3efc02798bd5f4a611a20ff91b6f3286cee


Automatically generate certs for secure clusters

roachprod start <cluster> --secure now generates a ca, client and node
cert and distributes these certs to every node in the cluster. The certs
are only created the first time the cluster is started (and require node
1 to be started, but that's required by other bootstrapping stuff too).
  peter-test: checking certs 1/1
  peter-test: initializing certs 1/1
  peter-test: initializing certs 3/3
  peter-test: starting 4/4
  ...

Fixes #85

This change is

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

install/cockroach.go, line 232 at r1 (raw file):

			})
		}
	}

Sort of fugly, but I've tested this on both local and remote clusters.

Comments from Reviewable

I've only skimmed; all seems reasonable. Let me know if you want a more detailed review.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

I've only skimmed; all seems reasonable. Let me know if you want a more detailed review.

Nah, no need for that. There might be some further fallout (e.g. the pgurl --external --secure won't be usable because we don't have a certs dir locally), but I don't think we need to fix that now. This will unblock anyone who wants to create a secure cluster easily.

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Agreed. The sooner this lands the better.

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


Buttons for services control.

Wrapping service control in updateServiceControlUI(), although I’m not sure it’s a good idea to automatically depend on the processing modal dialog. Could be optional or the modal could have an other name

I'm merging this, but it needs an extensive rework for a consistent look and feel with the legacy pages...

Thanks!


Please clarify that thread injection settings in runtimeconfig.json only apply to .Net 6.0+

I love the fact that thread pool injection delay can be configured using e.g. System.Threading.ThreadPool.Blocking.MaxDelayMs to mitigate latency spikes from thread starvation. However, it is apparent to me that these settings are only respected in .Net 6.0 and above. Please clarify this fact in the documentation (maybe using a "Version Introduced" column or equivalent)
My alias is lostromb

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: eb7d6afc-4bab-392d-d19a-6f5b9ee7f374
Version Independent ID: a7717378-7827-0d42-01c8-8a841b0d7b66
Content: Threading config settings - .NET
Content Source: docs/core/run-time-config/threading.md
Product: dotnet-fundamentals
GitHub Login: @gewarren
Microsoft Alias: gewarren

Thank you!


Create docker Ubuntu Saucy image

Trying to fix MoveIt! release issue for ROS Indigo https://github.com/ros-planning/moveit/pull/389
It could be useful to have a Saucy image somewhere online since this issue seems to linger for awhile.

Made a good try :/ https://github.com/osrf/docker_images/pull/42


[Feature] support url_extract_host functions

Fixes #31969
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[x] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 0 / 19 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/string_functions.cpp
0
19
00.00%
[2518, 2519, 2520, 2521, 2522, 2523, 2524, 2527, 2528, 2530, 2531, 2532, 2533, 2535, 2537, 2540, 2541, 2544, 2545]

Why did you use my pr code into your pr without my permission? https://github.com/StarRocks/starrocks/pull/31990

Why did you use my pr code into your pr without my permission? #31990
issue and pr had assgine to me firstly，some good idea you can suggest in the pre pr；you write the same the testcase、doc without comunication with me too @superdiaodiao

Why did you use my pr code into your pr without my permission? #31990

issue and pr had assgine to me firstly，some good idea you can suggest in the pre pr；you write the same the testcase、doc in this pr without comunication with me is not necessary@superdiaodiao

Why did you use my pr code into your pr without my permission? #31990

issue and pr had assgine to me firstly，some good idea you can suggest in the pre pr；you write the same the testcase、doc without comunication with me@superdiaodiao

I don't think the pr only belongs to you, but the way you copy my develop code is nonsence. By the way, the testcase is not the same.

Why did you use my pr code into your pr without my permission? #31990

issue and pr had assgine to me firstly，some good idea you can suggest in the pre pr；you write the same the testcase、doc without comunication with me@superdiaodiao

I don't think the pr only belongs to you, but the way you copy my develop code is nonsence. By the way, the testcase is not the same.

firstly，this is not only you can use the method to resolve the problem，method is same mean copy？

Why did you use my pr code into your pr without my permission? #31990

issue and pr had assgine to me firstly，some good idea you can suggest in the pre pr；you write the same the testcase、doc without comunication with me@superdiaodiao

I don't think the pr only belongs to you, but the way you copy my develop code is nonsence. By the way, the testcase is not the same.

firstly，this is not only you can use the method to resolve the problem，method is same mean copy？

Why did you use the same develop code after me? I think this behavior is inproper.

I

testcase and doc only just  same with the pr nearly after I submit issue and pr，it also means copy without my permission？this behavor is proper？

Why did you use my pr code into your pr without my permission? #31990

issue and pr had assgine to me firstly，some good idea you can suggest in the pre pr；you write the same the testcase、doc without comunication with me@superdiaodiao

I don't think the pr only belongs to you, but the way you copy my develop code is nonsence. By the way, the testcase is not the same.

firstly，this is not only you can use the method to resolve the problem，method is same mean copy？

Why did you use the same develop code after me? I think this behavior is inproper.

testcase and doc only just  same with the pr nearly after I submit issue and pr，it also means copy without my permission？this behavor is proper？

Why did you use my pr code into your pr without my permission? #31990

issue and pr had assgine to me firstly，some good idea you can suggest in the pre pr；you write the same the testcase、doc without comunication with me@superdiaodiao

I don't think the pr only belongs to you, but the way you copy my develop code is nonsence. By the way, the testcase is not the same.

firstly，this is not only you can use the method to resolve the problem，method is same mean copy？

Why did you use the same develop code after me? I think this behavior is inproper.

testcase and doc only just  same with the pr nearly after I submit issue and pr，it also means copy without my permission？this behavor is proper？

Again, testcase and doc is not the same, ok? The develop code is the matter.

Why did you use my pr code into your pr without my permission? #31990

issue and pr had assgine to me firstly，some good idea you can suggest in the pre pr；you write the same the testcase、doc without comunication with me@superdiaodiao

I don't think the pr only belongs to you, but the way you copy my develop code is nonsence. By the way, the testcase is not the same.

firstly，this is not only you can use the method to resolve the problem，method is same mean copy？

Why did you use the same develop code after me? I think this behavior is inproper.

testcase and doc only just  same with the pr nearly after I submit issue and pr，it also means copy without my permission？this behavor is proper？

Again, testcase and doc is not the same, ok? The develop code is the matter.

Everything you said is right，best wish to you

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 2 / 6 (33.33%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/string_functions.cpp
2
6
33.33%
[2520, 2521, 2522, 2523]

@superdiaodiao I think there might be some misunderstanding in this. Can you give me your contact information so we can chat?

@superdiaodiao I think there might be some misunderstanding in this. Can you give me your contact information so we can chat?

Thanks for asking, I have contact you via Slack.
By the way, a few days ago, @alberttwong knew my contribution which means an earlier code version.

close the pr and would submit a testcase pr for it

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:disappointed: fail : 2 / 3 (66.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/string_functions.cpp
2
3
66.67%
[3969]


Fix asymmetry in encode/decode API

Rather than having encode write a single item and decode read a lazy sequence, the semantics should be changed to include encode-all and decode-all methods that operate on sequences. This implies a breaking change to decode such that it always returns a single item.

787d7e94c002739490a2b7a29c2ba87e6ac0c7a3