Minor fix

Reviewer: @sjbarag @shakyShane
Asana: https://app.asana.com/0/1200930669568058/1205672743544250/f
Description
Fixes a specific site and all similar cases in Italian.
Steps to test
Test case added.

Thanks for the easy fix! And for tagging me for the exposure to adding a new test page 😃
xkcd 208

Lol. By the way, here's some docs on how to add these forms test cases: https://github.com/duckduckgo/duckduckgo-autofill/blob/main/docs/real-world-html-tests.md. There are notes for more complex stuff in there, but basically, you just add data-manual-scoring=<inputType> to the fields you want to validate in tests and data-manual-submit to the submit button of the form. You then add the file to index.json and optionally add arrays of expected failures (things we can't fix right now).


License?

I see a LICENSE file in the Java section of the source tree but nothing in the csharp section. Could you clarify that the MIT license applies to the whole repo? Thanks much.

Yes, the MIT license applies to the whole repo.


Upnp-Support

Hmm, why is this needed? I mean there should be no incoming connections…

I would like to stream the tv channels to my media renderer (running with kodi) at home. I could use the share function and send the stream url to BubbleUPNP, however this does not work very reliably.
I use cling to implement this function, but the library is hard to use without reading and understanding the complete upnp spec.

The only available upnp library for android (cling) uses an untrusted repository and cannot be used for fdroid apps. Therefore I'll drop this enhancement.


Duplicate/Edit Fails

Running Mailcow, Nginx command (via docker-compose) is:

If I Duplicate/Edit the container, the command becomes:

Note the missing apostrophes in the last line. It causes an nginx error:

I have to manually replace 'envsubst and 'daemon off;'' to "envsubst and 'daemon off;'"
Using 1.24.1 on Linux

If you are able to try out portainer/portainer-ce i'd be interested to see if you still have this issue as we changed the way CMD and Entrypoint are handled.. NOTE: there are a number of breaking changes in the new version so I advise reading the related release notes https://github.com/portainer/portainer/releases/tag/2.0.0

Using portainer-ce now, and the issue is still there. The Container CMDs are still displayed the same, as in my initial post. However, the formatting of the command has changed in the duplicate/edit "Command" field. I still change: 'envsubst to "envsubst
The end of the command is now: daemon' 'off;' which I change to 'daemon off;'"

OK, this will be added for consideration for Portainer CE 2.1.


Switch from JavaScript to Blocks and lost all my work

Running Arcade on localhost with latest code. I switched from Blocks to JavaScript to expedite the writing of some simple math code. Nothing that could not have been expressed in Blocks. When I switched back to Blocks, the editor was empty! All code lost. This has happened to me a few times recently. I suspect it might be a regression. Could it be related to the blockly update?
There was an error in the dev console:
pxtapp.js:3632 TypeError: Cannot read properties of null (reading 'FULL_BLOCK_FIELDS')
    at FieldTsExpression.applyColour (blb/pxtblockly.js:15867)
    at Blockly.BlockSvg.applyColour (blb/pxtblockly.js:1453)
    at Blockly.BlockSvg.setColour (blb/pxtblockly.js:1461)
    at setHelpResources (blb/pxtblockly.js:8102)
    at Blockly.BlockSvg.init (blb/pxtblockly.js:8694)
    at Blockly.BlockSvg.Blockly.Block (blb/pxtblockly.js:727)
    at new Blockly.BlockSvg (blb/pxtblockly.js:1424)
    at Blockly.WorkspaceSvg.newBlock (blb/pxtblockly.js:1536)
    at Object.Blockly.Xml.domToBlockHeadless_ (blb/pxtblockly.js:204)
    at Object.Blockly.Xml.applyInputTagNodes_ (blb/pxtblockly.js:201)

in pxtblockly.js, FieldTsExpression.applyColour, this.constants is null:

ah, good bug! would you happen to have the specific ts/math code that you were using?

The code I was editing was in a function that I'd defined in Blocks, and it looked something like:
function updateSprite(spr: Sprite) {
    world_x = sprites.readDataNumber(spr, "world_x")
    world_y = sprites.readDataNumber(spr, "world_y")
    world_z = sprites.readDataNumber(spr, "world_z")
    x = world_x / (world_z + near_dist) + screen.width / 2
    y = world_y / (world_z + near_dist) + screen.height / 2
    spr.setPosition(x, y)
}

I went to JavaScript to add the + near_dist part.


[contrib] tool to run Boost Test based C++ unittests in parallel

contrib/testtools/gtest-parallel-bitcoin is a rough adaptation of Google's test sharding wrapper at https://github.com/google/gtest-parallel . The license is Apache 2.0 (see file header).
It has been adapted to use the Boost Test framework's '--list_content' command line parameter, and some Google Test dependencies have been removed.
It can be run by simply giving it the path to the test_bitcoin executable, which it then queries to obtain a list of runnable tests.
This only works if Bitcoin has been compiled against Boost 1.59 or later.
On earlier versions, the executable would unfortunately ignore the '--list_content' option and start running all the tests it knows.
Running with --help provides help about the command line options.
Using --format=raw option provides detailed worker thread output during execution.
The --print_test_times will print a detailed breakdown of all test times.
The parallelization wrapper creates and maintains a score database of test execution times in ~/.gtest-parallel-bitcoin-times .
When it executes tests in repeated runs, it starts them off in order from longest to shortest test to save time. This is different from -r option which can be used for repeating tests within a run.
You can specify the --failed option to run only previously failed and new tests.
The --timeout option can be used to constrain runtime.
Interrupted tests will be listed.
Testing on a desktop machine with sufficient cores shows that the total test execution time when using this parallelization script is is reduced to approximately the running time of the slowest unit test.
This tool is an updated, pep8-formatted version based on my original adaptation at https://github.com/ftrader-bitcoinunlimited/hardfork_prototype_1_mvf-bu/commit/c757a8299e9073910ad5e09e94d14d55a89ee865

Example usage (once build has been completed):
contrib/testtools/gtest-parallel-bitcoin src/test/test_bitcoin

Example output:
$ contrib/testtools/gtest-parallel-bitcoin src/test/test_bitcoin
[13/54] scheduler_tests (21ms)
Test setup error: no test cases matching filter or all test cases were disabled
[13/54] scheduler_tests  returned/aborted with exit code 200 (21 ms)
[54/54] PrevectorTests (54181ms)
FAILED TESTS (1/54):
src/test/test_bitcoin: scheduler_tests

Great, github lost my other review comment;
your new file attributes copyright to "Bitcoin developers". This is not a legal entity (1) and as such can't be used to own copyright.
Please replace them with actual persons names and email addresses. Thanks!

http://thelawdictionary.org/legal-entity

./policy/fees.cpp:2:// Copyright (c) 2009-2015 The Bitcoin developers
./policy/policy.cpp:2:// Copyright (c) 2009-2015 The Bitcoin developers
./policy/fees.h:2:// Copyright (c) 2009-2015 The Bitcoin developers
./policy/policy.h:2:// Copyright (c) 2009-2015 The Bitcoin developers
./memusage.h:1:// Copyright (c) 2015 The Bitcoin developers
./arith_uint256.h:2:// Copyright (c) 2009-2015 The Bitcoin developers
./arith_uint256.cpp:2:// Copyright (c) 2009-2014 The Bitcoin developers
./qt/paymentrequestplus.h:1:// Copyright (c) 2011-2015 The Bitcoin developers
./compat/byteswap.h:1:// Copyright (c) 2014 The Bitcoin developers
./compat/endian.h:1:// Copyright (c) 2014-2015 The Bitcoin developers

Most recent merge featuring such an attribution: policy.h, 877fc13

That merge doesn't add enough copyrightable material to claim.
I am aware that most files in Bitcoin have this problem that they assign copyright to a non-existing entity. Which is a shame, but I can't change the past. I frankly expected you to be happy that you can assign the copyright to yourself instead of an anonymous group like "Bitcoin developers"...  What is the reason you send a reply instead of change your file?

No idea why Boost ignores this silently when running the suite as-is.

The problem is that it doesn't ignore it, the problem is that it fails :)

It is of course due to the only test case being commented out (dead code).

Agreed, that seems like something that should be updated or removed. Its lucky that it caught a bug in the script, though! Would you not agree?
Maybe you can make it so that should there be a suite but not tests, it is not actually ran?
Are you willing to fix the copyright lines at least, please?

For ease of usage, here is the boost output of the unit test as it is run by the python script; test-list-content.txt

Would 'The Bitcoin Classic developers' be a legal entity?

Would 'The Bitcoin Classic developers' be a valid legal entity?

No, it would not be.  "Google Inc" is, My full name is.
Freetrader as a name combined with your email address is (although I prefer a legal name, I understand you like to keep an alias, and thats fine).

Thanks for the clarification. I've adapted the copyright line.
Why I asked about the 'Bitcoin Classic developers':
init.cpp:312:           FormatParagraph(strprintf("Copyright (C) 2016-%i The Bitcoin Classic developers", COPYRIGHT_YEAR)) + "\n" +

The patched scheduler_tests.cpp from BU (changes merged from Core 0.12 I believe) works fine for me btw.

The copyright string in the init.cpp is not a legal statement, it is a user-visible string that helps users understand. It is a little odd as we depend on lots of dependencies which are not included in the copyright claim. In most software you would see the license listed instead.
As you may know, I have spend many years on many open source projects, and Bitcoin as we inherited it has many weird habits. But I don't think changing all at once is healthy either ;)
Thanks for your copyright line fix!
Do you think you can fix the bug in this script failing? I'll fix the unit test, but that will just hide the bug, assuming we never end up with another empty unit test in the future...

I changed the behavior of the program to treat empty test suites as PASS by default.
While I'm not sure this is an entirely sensible default, it can be overridden by specifying --fail_empty_suites which will show up the previous error. I have tested with an without the flag.
With the flag (and the unpatched scheduler_tests.cpp, the script returns exit code 200, as before). Without it, it now declares all 54 unit tests passed and exits with code 0.
I am not a lawyer but I always assumed that if a software shows me an explicit copyright message, then it must be trying to convey some legally significant message through that statement, otherwise why make it. One could as well write on it "brought to you by the fine folks at Bitcoin Classic" or "for details on copyright, read the individual source files". That might actually encourage people to read the source!

I am not a lawyer but I always assumed that if a software shows me an explicit copyright message, then it must be trying to convey some legally significant message through that statement, otherwise why make it. One could as well write on it "brought to you by the fine folks at Bitcoin Classic" or "for details on copyright, read the individual source files". That might actually encourage people to read the source!

I'm certainly not going to disagree with that! :)
If you look at many pieces of open source software, you'll find your thoughts to be in line with their practices. Where a copyright line is shown its for things like the Free Software Foundation or otherwise actually existing legal entities.
This requires copyright assignment and a foundation, neither of which is appropriate for Bitcoin. (more;  https://www.gnu.org/licenses/why-assign.html )
I'm not sure if its politically a good idea to remove the "copyright" line from the splashscreen or from the command line help right now. Its legally completely irrelevant, though.
thanks for the contrib! I merged it :)

The last issue I mentioned in my initial review, I fixed that in 4be660756


VS2015 appears as "Unknown" in stats - client name

Example: https://www.nuget.org/stats/packages/Microsoft.AspNet.Mvc.Core?groupby=Version&groupby=ClientName
All the "Other" downloads appear to be VS2015.

@Daniel15 we looked at this today. That was a cool guess, but not a correct one. Some percentage of the others is indeed VS2015 related restores/installs but not only. We are going to fix the ones that provide us we a proper user-agent and we let the ASP.NET 5 team know through https://github.com/aspnet/dnx/issues/1546. Once that issue is fixed a large portion of downloads will get proper tagging. We don't want to just modify the data, because any generic client that doesn't provide a user-agent falls in that category.
Closing this as duplicate of https://github.com/NuGet/Home/issues/258, as we want to track all issues at home.
@Eilon @csharpfritz


RTX 3090 ALVR panickedMessage error.

Please follow the general troubleshooting steps first:

[x] I carefully followed the instructions in the README and completed successfully the setup wizard.
[x] I read the ALVR Wikis here and here

If your issue is about games not working, please open an issue for every game and list the game in the title.
Bug reports:
Unable to open ALVR error.
Environement
CPU:AMD 3950X
GPU:RTX 3090
WIN10 2004
Features:
Unable to open ALVR error.
ALVR panickedMessage: "Unavailable' Backtrace:0: HmdDriverFactory 1: HmdDriverFactory 2: HmdDriverFactory 3: HmdDriverFactory4: HmdDriverFactory 5: HmdDriverFactory6: HmdDriverFactory7: rust eh personality 8: rust eh_personality 9: HmdDriverFactory0: HmdDriverFactory 11: 12: HmdDriverFactory 13: HmdDriverFactory 14: HmdDriverFactory 15: BaseThreadInitThunk 16: RtlUserThreadStart

This error is inside legacy code and we don't know exactly why it happens. I think you might be able to see what other people have done to try to fix it in the Discord server.

Stopping all Steam-realted processes in Task Manager fixed it for me.


BUG duplicated resfinder fixed

Can you sort the mapping files so that future diffs are more readable?

Just sorted them, is this ok?


Adding 3-legged auth for users getting started.

Addresses final part of #335.
@tseaver Writing Test_get_credentials_from_user_flow.test_succeeds made me feel icky inside. Any suggestions on how to make this less massive?
@silvolu PTAL at the docstrings introduced and the print statements. Should we put this somewhere special in our documentation? We don't have an auth or a getting started section anywhere but I encourage you to clone my repo, check out the add-3LO branch and run
from gcloud import credentials
from gcloud.datastore import SCOPE
credentials = credentials.get_credentials_from_user_flow(SCOPE)

First without a client secrets file present (to test failure modes) and then with one (to test the messages printed, inputs requested).
@craigcitro Also PTAL / see what we could pull into oauth2client.

Coverage remained the same when pulling ca140787b18e6ceffd925ca15022918cb90b29da on dhermes:add-3LO into dcb73d34b74c9be34635dc387bf5afd3da650006 on GoogleCloudPlatform:master.

substituting @anthmgoogle in my place, who has more feelings about 3LO

@dhermes There is a getting started section on the landing page, that is currently explaining how to install the package, maybe we can add it there. Alternatively, we could add it to the " in 10 seconds" expandables of each top-level module (e.g. Cloud Datastore)

Coverage remained the same when pulling d50cc57ee941067f8e3855fcc361b7de7c6c5826 on dhermes:add-3LO into 8a42ef583ad59e467dc2b3ac29c3d4f20e03c537 on GoogleCloudPlatform:master.

Now that I think about it, the process described in the docstring for get_credentials_from_user_flow() is not any simpler than the process required to set up the files / env vars needed for get_credentials() or get_for_service_account_p12().
@silvolu Do we really need / want user 3LO? I can see cases where someone would want to write a CLI application and have users go through a flow, but we support plugging in arbitrary credentials to our Connection classes so this doesn't preclude them. Instead it puts the onus on those users to define their own flow.

I provided some comments on the implementation.
I think a GCloud-specific wrapper for 3LO is relatively low priority, since
there is no user-owned data at stake, so you would typically just use it as
a way to reusing the user's permissions.
One thing that may not be widely known yet is that you can actually now use
the GCloud SDK for this. As of a release in late 2014, the Cloud SDK's
"gcloud auth login" command will also set up the Application Default
Credentials in the well-known-file location and it includes all Cloud API
scopes. This means you can use 3LO with your own credentials as a proxy at
development time, but you don't need to have an any actual 3LO related UI
in you application. We'd love to get feedback about whether this works for
scenarios like this.
That being said, I do belive there is a need for better 3L0 libraries,
primarily for APIs like that DO represent end user data (e.g. Calendar,
GMail). Ultimately I think we should  provide a better wrapped
implementation of 3LO in oauth2client, such that writing code such as that
in this change list bcomes 95% UI logic only a few library calls instead of
needed this embedded auth and serialization logic.
On Wed, Jan 14, 2015 at 1:04 PM, Danny Hermes<EMAIL_ADDRESS>wrote:

Now that I think about it, the process described in the docstring for
get_credentials_from_user_flow() is not any simpler than the process
required to set up the files / env vars needed for get_credentials() or
get_for_service_account_p12().
@silvolu https://github.com/silvolu Do we really need / want user 3LO?
I can see cases where someone would want to write a CLI application and
have users go through a flow, but we support plugging in arbitrary
credentials to our Connection classes so this doesn't preclude them.
Instead it puts the onus on those users to define their own flow.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/gcloud-python/pull/539#issuecomment-69991487
.

@dhermes all I wanted was support for application default credentials :)
@jgeewax you wanted this to make getting started with the demo easier, do you still think that's the case?

@anthmgoogle that hits it exactly on the head! I somehow forgot that GoogleCredentials.get_default_credentials (which we already use) could use the well-known file.
I am going to close this and we can discuss the best way to document it in #335.


polyfill.io is down for me

I apologize, but I wasn't able to find a status page so I'm leaving this here for others. It appears that polyfill.io is down for me right now, serving 503s:

Is there a status page somewhere and/or is there a backup server we could be using?
Thanks!

Same here, it started to happen today.

Same here, happend right now

Same here, only the "basic url works" https://cdn.polyfill.io/v2/polyfill.min.js

Here is a reproduction url: https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en-US&flags=always .

Consistently an issue for me as well
Error 503 Backend is unhealthy
Backend is unhealthy

Guru Mediation:
Details: cache-jfk8137-JFK<PHONE_NUMBER><PHONE_NUMBER>

Varnish cache server

Hi all, I'm looking into this issue. We have made no changes to the production service so I am currently not sure what is causing the issue.

Update, we had a high amount of traffic bypass our CDN layer and overload our servers. I have scaled our servers to meet the large amount of traffic, the amount of errors has reduced completely to 0.

I have now added autoscaling to our backend servers to help avoid this situation happening again in the future. 👍

Thanks @JakeChampion. FWIW, we have been seeing intermittent issues for about 15 days. We know this because we started seeing errors from IE11 that should not be there if it was properly polyfilled from a handful of users.

@JakeChampion we're still seeing occasional errors. They're being reported from user's browsers so I don't actually know how or if the polyfill service is failing to serve a file, but it still is. Is it possible that there are still 503s being served?

Why don't you have origin server protection so only your CDN can talk to your servers?


@jmchilton's GCC Training Homework

Included in this PR:

Tool development using Conda and Bioconda slides. Fixes #231.
Tool development with Containers and BioContainers slides. Fixes #232.
Galaxy Code Architecture slides synchronzied from galaxyproject/galaxy.

I still have a lot I'd like to do but this seems like a workable first draft.
Conda:

[ ] Discussion of merged mulled environments perhaps, more slides about dependency resolution in general?

Containers:

[x] Update all slides for mulled-v2.
[x] Update with information on multi-package-containers repository and monitoring tool repositories for missing containers.
[ ] Singularity information.
[ ] Information on newer container-based deployment options - Kubernetes, Chronos, and Condor Docker universe.

Arch:

[ ] Redo startup slides since they may have changed since last year - especially tool monitoring and stuff.
[ ] Add a section about web hooks.

first part implemented here: xref: https://github.com/galaxyproject/training-material/pull/357

Sorry bad close. Is this still relevant? We have some training on k8s,webhooks, etc.

going to close this since its 5 years old, feel free to re-open or recreate an issue for parts of this if still relevant


Does not work with optionalDependencies

If one module is an optionalDependency of the other (rather than a dependency), then Lerna does not link them together.
Our use-case for this in PouchDB is that sometimes we have native dependencies (e.g. leveldown) that users struggle to install on certain hardware, so we make it optional so it doesn't completely block them.
I'll try to get to this when I get a chance, but filing the issue to make a note of it.

This should just require updating:

https://github.com/kittens/lerna/blob/3f84f9a19c76043441655120b66f65db46883997/src/commands/PublishCommand.js#L240-L243
https://github.com/kittens/lerna/blob/9246f288b57122bbf1121d4b6910c2232baf35c5/src/Package.js#L30-L49

Nice! Probably just a user error on my part.

It's good now?

I'll check when I get a chance, but it sounds like it!

No it's definitely not supported. I was saying that in order to support it those places need to be updated.

If that's it, https://github.com/lerna/lerna/pull/191


Run fail

My OS is win10 64bit，winfsp and osfmount already install，but when i run the tool，it give me an error message like this. Do i miss something？

error message said：This should not be run as administrator. The mount point may not be accessible by your account normally，only by the administrator.

if you’re not manually running as Administrator, UAC is probably disabled.

when i turn off the UAC，it working fine！！thx
by the way，nand cid where i can get it？my b9s console already have otp.bin，boot9.bin，seeddb.bin，nand.bin，except cid file...what's the cid file look like？

do you have essential.exefs? it was generated by GodMode9.

2c6e3b0dd53284ce366b4e5ecfe55c17b13dd49a allows it to work when UAC is off. This was only an issue on Windows 7 I think.

actually，my console already bricked，and i want this tool can help me do something with the bricked nand.bin. lol...so i can‘t get essential.exefs with gm9.

when #7 is implemented, the nand cid shouldn't be needed.

Can I find out nand CID of broken console via Arduino ？

I wouldn't know that

Since the main problem of this issue was solved, this can be closed now

wow, it's a great worked, i will try it soon.

v1.1 worked!!! i provide nand.bin and the otp.bin , driver Z:  was list normal. Big thanks to you!!!
fuse-3ds v1.1 - https://github.com/ihaveamac/fuse-3ds
Attempting to generate Counter for CTR/TWL areas. If errors occur, provide the CID manually.
Counter for CTR area automatically generated.
Counter for TWL area automatically generated.
ncsd idx:0 fstype:1 crypttype:1 offset:00000000 size:0b100000 /twl_full.img
twl  idx:0                      offset:00012e00 size:08fb5200 /twln.img
twl  idx:1                      offset:09011a00 size:020b6600 /twlp.img
ncsd idx:1 fstype:4 crypttype:2 offset:0b100000 size:00030000 /agbsave.bin
ncsd idx:2 fstype:3 crypttype:2 offset:0b130000 size:00400000 /firm0.bin
ncsd idx:3 fstype:3 crypttype:2 offset:0b530000 size:00400000 /firm1.bin
ncsd idx:4 fstype:1 crypttype:2 offset:0b930000 size:2f5d0000 /ctrnand_full.img
ctr  idx:0                      offset:0b95ca00 size:2f3e3600 /ctrnand_fat.img
The service fuse-3ds has been started.


Fix UpdateFromFunc neglecting rate_func

Overview: What does this pull request change?

UpdateFromAlphaFunc animation didn't follow rate_func due to #1678

Motivation and Explanation: Why and how do your changes improve the library?
https://user-images.githubusercontent.com/43041139/131846727-6cb9eb00-6b3f-4e02-9915-4fbd4f8fe315.mp4
https://user-images.githubusercontent.com/43041139/131846705-0d5b1a5e-a714-4b46-b579-8957614346d3.mp4

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Correct me if I'm wrong, but I don't think this is the right way to fix this issue, given that these two animations are wrongly written.
The problem with the current implementation of UpdateFromFunc and UpdateFromAlphaFunc is that they use interpolate_mobject, instead of interpolate_submobject.
The major difference between the two is that interpolate_mobject computes the subalpha ( which is essentially rate_func(alpha)), and only then feeds interpolate_submobject, with the subalpha, not the alpha. Interpolate_mobject compute the subalpha while taking other parameters, such as lag_ratio, etc, and this is not done in your fix (you only compute rate_func(alpha) ). Hence, for example, with a lag_ratio, the animation won't work.
i think the fix should instead look like it (I didn't test it, so it's can be completely wrong !) :
    """
    update_function of the form func(mobject), presumably
    to be used when the state of one mobject is dependent
    on another simultaneously animated mobject
    """

    def __init__(
        self,
        mobject: "Mobject",
        update_function: typing.Callable[["Mobject"], typing.Any],
        suspend_mobject_updating: bool = False,
        **kwargs
    ) -> None:
        self.update_function = update_function
        super().__init__(
            mobject, suspend_mobject_updating=suspend_mobject_updating, **kwargs
        )

    def interpolate_submobject(self, submobject, starting_submobject, alpha: float):
        self.update_function(self.mobject)
    # def interpolate_mobject(self, alpha: float) -> None:
    #     self.update_function(self.mobject)

class UpdateFromAlphaFunc(UpdateFromFunc):
    # def interpolate_mobject(self, alpha: float) -> None:
    #     self.update_function(self.mobject, alpha)
    def interpolate_submobject(self, submobject, starting_submobject, alpha: float):
        self.update_function(self.mobject, alpha)

hmm, before that PR, interpolate_mobjects was fed rate_func(alpha) for animations, but as it was changed, and interpolate_mobjects is simply fed alpha, the animations like Rotating also neglects rate_func

Also, PhaseFlow and MoveAlongPath were fixed using similar approach as in this commit

Do this work when you use a lag_ratio ?

I see the lag_ratio doesn't work (neither it did before #1678), but applying the function to submobjects individually isn't same as applying to whole mobject, and we are not interpolating between initial and final state like transform..
Though I tried something like this, make a current_submobject (that is the copy of our initial mobject) and then interpolate submobjects to the current_submobject which will follow rate_func and lag_ratio
This approach does work,
 v = VGroup(*[Square() for _ in range(2)]).arrange()
 self.play(UpdateFromAlphaFunc(v, lambda m, a: m.move_to(UP * a)), lag_ratio=0.5)

https://user-images.githubusercontent.com/43041139/133144589-d140b7ef-7988-45d9-ab36-7d10fe54818a.mp4
I can play ManimBanner().create() also, but with ManimBanner.expand() it fails coz current_mobject because the fed function removes a submobject at alpha == 1 ig, due to which interpolation for submobjects fail

This has actually been taken care via #2211. Closing.


Not compile RapidsUDF when udf compiler is enabled

To close: https://github.com/NVIDIA/spark-rapids/issues/1712.
Originally, when UDF Compiler is enabled, it will always try to compile the bytecodes for any instance of a ScalaUDF.
This PR detects if a ScalaUDF implements the RapidsUDF interface. If yes, don't compile its bytecode because user has already provided a columnar evaluation method for the function.
Signed-off-by: Allen Xu<EMAIL_ADDRESS>

build

build


Can't download Azure NotificationHub SDK

Is the Azure NotificationHub SDK missing from maven central?
I have multiple spring projects using this SDK and all projects fail to download the dependency.
I get the following error while trying to download the dependency:
[WARNING] The POM for com.windowsazure:Notification-Hubs-java-sdk:jar:0.0.5 is missing, no dependency information available

Can anyone help me understand why I can not download this dependency?

Hi @AlexJuca - you might have more luck asking this question over in this GitHub repo: https://github.com/Azure/azure-notificationhubs-java-backend
I note that they released 0.1.0 back in September 2019, so you may want to consider that also. Here is some more info I found: https://bintray.com/microsoftazuremobile/SDK/Notification-Hubs-Java-Backend-SDK
I'll close this issue for now, but please reopen if you fail to get support - thanks for using Azure SDKs for Java!


How to use the REPL

I'm trying to understand how to use the REPL. I started it and tried to enter either (identifier) @i or ((identifier) @i (#eq? @i "foo")), then it says Capture i> and I enter something but nothing really happens. After that whatever I enter it just stays at the Query> prompt.
Then I tried to close it with exit or quit but didn't work so I closed with <esc>:q. But then if I open the REPL again I get:
E5108: Error executing lua ...te/pack/packer/opt/architext.nvim/lua/architext/repl.lua:91: Vim:E95: Buffer with this name already exists

Sorry for my ignorance but would be happy to hear how to use it properly :)

To be honest, I think I'll deprecate the REPL, and make the command the only way to use the plugin.
Sorry for that, but the REPL was a bad attempt at building this :wink


Update select to suit tabler

Problem
Current selects doesn't match Tabler style
Solution
Try to switch to tabler's select or adapt the current component to look like on tabler

https://github.com/freeats/freeats/issues/114


Replace Ch with ReqCH for ClickHouse integration

This is replacing the Ch package with the newly created ReqCH for the ClickHouse integration.
Tests need to be updated, but I want to know if this direction is good first.
I built this on top of https://github.com/livebook-dev/kino_db/pull/82
Video
https://github.com/user-attachments/assets/fd462715-4035-4bb4-8390-e49d34c1fbf5

Test

@josevalim please take another look. This is linked to https://github.com/livebook-dev/req_ch/pull/6 as well.


Fix bug that discarded some chunks.

The OBJ loader was discarding the first line of a file
or a chunk following one that ends with a newline.
I found this bug when testing with a very small OBJ file and many (32) cores.

Awesome! merged!


Automatic log pattern is not working when using with spring-boot-starter-log4j2

Hi,
I am using spring Cloud with spring-boot-starter-log4j2 and looks like the automatic pattern that includes app name, span id and trace id is not set as the docs are saying.

It's a logback only feature I think (from Spring Boot, so nothing we can fix here anyway).

Maybe adding to the documentation will save others time to understand it.  I finally found the comment in the source code and figured it out.  Thanks anyway

Hi ezraroi,
How did you figure out to this problem with log4j2 ?

+1, how to make it working with log4j2?

@hsj1606 @sdiallo-talend I guess you have to do exactly what is here https://github.com/spring-cloud/spring-cloud-sleuth/blob/master/spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/log/Slf4jSpanLogger.java but using https://logging.apache.org/log4j/2.x/manual/thread-context.html . In other words just write your own implementation of SpanLogger

Did anyone actually test this solution?  From the boot docs they state that logging.pattern.console is logback specific...


MWPW-133443: Fetch gnav placeholders from correct location

Description
Do not 404 for the feds placeholders on localhost on milo consuming projects and fetch global navigation placeholders always from https://main--milo--adobecom.hlx.page rather than localhost.
Resolves: MWPW-133443
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/osahin/gnav-1?martech=off#
After: https://MWPW-133443--milo--mokimo.hlx.page/drafts/osahin/gnav-1?martech=off#

Since this is a trivial change, I'll merge it


Reconcile when managed annotations/ labels are out-of-sync

Previously, the cert-manager.io annotations were just being ignored while checking the annotations in the template.
This PR adds checks that make sure the correct cert-manager.io annotations are present and that they have the correct value.
Same goes for the controller.cert-manager.io/fao label.
eg. Previously, you could remove or overwrite a cert-manager.io/common-name annotation on a Secret. Now, this annotation will be automatically updated to match its expected value after a change is detected.
Kind
/kind cleanup
Release Note
The SecretPostIssuancePolicyChain now also makes sure that the `cert-manager.io/common-name`, `cert-manager.io/alt-names`, ... annotations on Secrets are kept at their correct value.

/retest

I vaguely remember that the fao annotation is intended to be changed by the user.
By default cert-manager will add it to the Secrets that it creates, and it causes cert-manager to cache content (in addition to the metadata) of those Secrets.
But a user with thousands of cert-manager managed TLS Secrets can remove that annotation so as to reduce the memory usage of the cert-manager controller.
(conscious that it will increase the traffic to the K8S API ).
@irbekrm: Am I misremembering?

The other way round. Secrets with fao label are cached in full, for all non-labellled ones metadata only is cached. Users are intended to add labels to secrets that cert-manager does not label, but accesses if they want to reduce the amount of traffic to kube apiserver. I haven't looked at the contents of this PR, but afaik the fao label was always added if it was found missing on issuance controller reconcile (not just when there was issuance in progress) and it would be good to preserve this behaviour to prevent extra requests to kube apiserver during first re-issuance.

an remove that annotation so as to reduce the memory usage of the cert-manager controller

To clarify, this was never an intended user action. The cert secrets are not that big, so I don't think it is needed.

/lgtm
Discussed during standup and I now agree that the post-issuance checks are responsible for all non-re-issuance triggering changes to the Secret.


Fixing links

Accidentally reversed in #64
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-doc-build


Fix a bunch of unsoundness, and clean up some stuff

Closes https://github.com/emberian/evdev/issues/12 and https://github.com/emberian/evdev/issues/14

Clean up quite a bit of unnecessary unsafe code, including direct calls to clock_gettime, open, and read, among others.
Remove macros that hide unsafe. These were difficult to read and audit.
Use std::fs::File to open and retain /dev/event/*. Eliminates the need for a custom Drop impl and improves unwind safety.
Eliminate all use of transmute. Specifically there was a wildly unsafe transmute to the Key enum that resulted in undefined behavior. Replaced with safe calls to num_traits::FromPrimitive. Also removed or replaced transmute used for pointer and slice casts.
raw::eviocgbit and raw::eviocgabs now accept mut slices instead of raw pointers (to match the nix macro-generated other unsafe function signatures in raw). There were several places internally where they were being invoked with number of bits instead of bytes for length, so this change makes those unsafe functions a little less inherently unsafe.
No more casting out to *mut u8 and back to &mut [u8]; as of Rust 1.30 align_to_mut allows a more safe aligned direct cast between slices.
Replace manual struct implementations for things like input_event with imports from the libc crate.
Remove a tests.rs file that contained no tests.

Still working through validating that everything still works.

Sounds good! I'll get a second pair of eyes to look at each of these, and probably look to cut a 0.11.0 release in a couple days after these are merged in.

Specifically there was a wildly unsafe transmute to the Key enum that resulted in undefined behavior. Replaced with safe calls to num_traits::FromPrimitive

Thank you for addressing this long-standing UB!

Apologies for the botched rebases. Should be good for review now.

Looks like this caused a regression in "supported keys" enumeration, I'm working on it still.

Fixed in master 0.11.0-alpha.4


pdns-recursor: 4.3.5 -> 4.4.0

Motivation for this change
Regular version bump
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via nixosTests.pdns-recursor nixosTests.ncdns
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 102001 run on x86_64-linux 1

1 package built:

pdns-recursor


update to 0.1.3

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[Enhancement proposal] debug mode with lifecycle events and action logs

I find my self very often adding console.log when building Stimulus controllers. I use them for many things but mostly

make sure my controller is properly loaded (no spelling mistakes)
log actions to confirm the event is correctly setup and/or inspect the payload
check my target lists etc

Talking with others (ping @ssaunier, @db0sch) we thought in terms of DX it would be nice to have a more generic way of doing this and potentially hook it to log service such as logRocket for debugging
That it something I started to implement for the StimulusUse mixins (example with useDispatch).
I looked whether this could be some kind of useDebug mixin in StimulusUse to optionally enhance Stimulus without bloating the core with it. I think it would be possible but with quite a bit of monkey patching and using non official API before looking into doing something outside I wanted to submit a proposal of API as a core Stimulus feature to discuss.
Draft API
Here is a proposal of what it could look like
Setting
Either
application.debug(process.env.NODE_ENV === 'development')

or
application.start(debug: process.env.NODE_ENV === 'development') // I think this would be a breaking change for the start function

Logs
The following would be logged:

initialize/connect/disconnect lifecycle
in the initialize collapse add the target elements (or simply count)
actions
[bonus] valueChanged

use a groupCollapsed with the lifecycle/action name and some context details in the collapsed zone.
Example:

This should leverage the current Logger class to combine to a single point all error/warning and log activities.
Would this be something that you would be interested to have in terms of core feature ?
At the core feature level it could maybe be as simple as having a hook at the application level for all activities and this hook can then be customized.

Would be great to get debugging, yes. How about it just being a flag that can be toggled:
if (process.env.NODE_ENV === 'development') {
  application.debug = true
}

Then you could even toggle it at runtime if your application object is accessible from the console.

Yes this was exactly my idea with a slightly different syntax (function rather than setter) but both work.

We had a custom logger long ago: https://github.com/stimulusjs/stimulus/pull/12. Don't recall why we removed it, exactly.


DataType SVP9(15)  is converting the value to Decimal(16,0)  instead of Decimal(16,16)

Hi @yruslan
We have a copybook with a field having datatype SVP9(15).   When reading the file with cobrix we are expecting the value to be a decimal value with Decimal(16,16)  but instead we are seeing Decimal(16,0) and also we are not seeing any decimal fields while checking the data.  But our onprem is processing it as decimal fields .
expected Value : 0.123456789131230
but actual value in cobrix output is  getting a INT.
Copybook:
01 TABLE_NAME.
10 random_field1   PIC  X(05)
10 random_field2   PIC SVP9(15)  COMP-3.

Hi @yruslan  Can you help us understand this.

Hi @yruslan ,
yeah we expect to read as 0.0123456789012345  from SVP9(15) .


BuildRun can override Build's Output image, but only the ref (not the secret)

Found while discussing https://github.com/shipwright-io/build/issues/677#issuecomment-802857029
Today, if a BuildRun specifies an output image to override its Build's output, only the ImageURL (ref) field is used, and if the BuildRun specifies credentials, those will always be ignored.
This brings up the question as well of having to decide what to do if the Build specifies credentials and the BuildRun doesn't (should the Build's creds be used instead?), or if the Build doesn't and the BuildRun does, etc.
/kind bug

We had some discussion about what can be override or not in the BuildRun, here is the original ADR:
https://github.com/shipwright-io/build/blob/master/docs/proposals/build-execution-using-build-run.md#deciding-what-should-be-overridden
Because right now, we don't have full build.spec in the buildrun, so we just allow few properties to be override to avoid making config mess.
If we want to change something, let us also discuss or update in the ADR, so that we can have an agreement first.
Thanks!

@zhangtbj thanks, but I still think this is just something we missed. From the proposal, adding the credentials in the BuildRun does not compromise the integrity of the Build, so I think is fine to do.

@sbose78 also asked on this when this override in the BuildRun was introduced, see his comment


theme: cherry cola

Let me know if anything looks amiss! I've attached some theme testing screenshots below 👇
edit: I noticed "Brown" text shows up as the normal font color but haven't been able to resolve that and found it to happen in other themes as well, not sure if that's happening on your end, it's defined on line 53 as the brown used elsewhere.

Thanks for this, will let you know after testing if any changes need to be made. I've found and fixed the brown text issue too.

It feels nice and warm, easy on the eyes. Couple things:

The text in the sidebar/properties seems a bit off. The sepia doesn't really fit the colour scheme.

It would be worth adding a bit of contrast to interactive_hover: it's helpful for visually separating elements and states.

Same thing for the dragarea. Not a lot, but it feels too empty/smooth to have the colours matching.

There are a few new colour-related variables: box-shadow, box-shadow_strong, ui-border and select_input. The last one at least definitely needs a definition.

Oh, and just noticed: the selected colour should be semitransparent + a bit brighter: as is I can't see what I've actually highlighted!

So far everything else is looking great, though.


MMG Validation enhancements

We need to enhance the MMG validator with the following:
~[ ] Code system is the appropriate code system for a field (OBX-3.3) - being validated in value set already.~
~[ ] Description of a coded value matches concept name or preferred concept names against our Value sets. (OBX-3.2: OBX-5.2) - already pulling all the descriptions out of phin vads (pulling all three).~
[ ] OBX-4 (blanket processing!) - ensuring that the group ID is correct for grouped data elements.
see prior ticket #274

2022-12-07: Backlog refinement
Only the OBX-4 work still needs to be done.


[rabit harden] replace hardcopy dmlc-core headers with submodule links

dmlc-core headers was unsync with rabit dmlc headers https://github.com/dmlc/rabit/pull/78 , this cause rabit mpi build errors.
xxx:test cq$ make
cd ..;make;cd -
make[1]: Nothing to be done for `all'.
/Users/cq/xgboost/rabit/test
cd ..;make mpi;cd -
mpicxx -c -O3 -Wall -Wextra -Wno-unused-parameter -Wno-unknown-pragmas -std=c++11 -msse2 -fPIC -o engine_mpi.o src/engine_mpi.cc
In file included from src/engine_mpi.cc:14:
In file included from src/../include/rabit/internal/engine.h:10:
In file included from src/../include/rabit/internal/../serializable.h:12:
src/../include/rabit/internal/../../dmlc/io.h:15:10: fatal error: 'dmlc/base.h' file not found
#include "dmlc/base.h"
         ^~~~~~~~~~~~~
1 error generated.
make[1]: *** [engine_mpi.o] Error 1

https://github.com/chenqin/rabit/commit/ed06e0c6af9444ddf570291bc383fc701b9286b4#diff-bbc45ff15fdaa4016cdcf3cc7447bec5L12 was introduced to address rabit test failures.
At same time, a bug was introduced which cause XGB build with latest rabit master failure, detail can be found https://github.com/dmlc/xgboost/issues/4274
This pr backport latest dmlc-core header files used by rabit, to keep interface definition consistent while building xgb with dmlc and rabit headers. This is important as xgb will includes both rabit and dmlc-core as part of headers definition yet link to dmlc-core lib
Here is verification chenqin/xgboost ci build point to chenqin/rabit
https://travis-ci.org/chenqin/xgboost/builds/508611790

@CodingCat @trivialfis

@chenqin I suppose this is not urgent since rabit submodule is controlled by git submodule.  Let me take a look later see if it's possible to hide some of them into src or maybe just remove them.  I really don't want to copy any code into the interface (headers exposed in include/).

can we simply use submodule to refer to these files....copy files is far away from an elegant solution

can we simply use submodule to refer to these files....copy files is far away from an elegant solution
I like this way better as it helps keep sync and avoid future compile issue for projects using both dmlc-core and rabit, what do you think  @trivialfis ?

Hello @chenqin
I tried checking out your branch. Running make in the base directory seems to be fine, but when I try to build using cmake (which should be the way forward, I do think we should get rid of the makefile) I get the following errors:
[  8%] Building CXX object CMakeFiles/rabit_base.dir/src/allreduce_base.cc.o
[ 16%] Building CXX object CMakeFiles/rabit_empty.dir/src/engine_empty.cc.o
[ 25%] Building CXX object CMakeFiles/rabit_base.dir/src/engine_base.cc.o
[ 33%] Building CXX object CMakeFiles/rabit.dir/src/allreduce_base.cc.o
In file included from /home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/./logging.h:16:0,
                 from /home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/io.h:15,
                 from /home/path/to/rabit/src/./../include/rabit/internal/../serializable.h:12,
                 from /home/path/to/rabit/src/./../include/rabit/internal/engine.h:10,
                 from /home/path/to/rabit/src/./allreduce_base.h:19,
                 from /home/path/to/rabit/src/allreduce_base.cc:14:
/home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/././base.h:271:10: fatal error: dmlc/build_config.h: No such file or directory
 #include <dmlc/build_config.h>
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
In file included from /home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/./logging.h:16:0,
                 from /home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/io.h:15,
                 from /home/path/to/rabit/src/../include/rabit/internal/../serializable.h:12,
                 from /home/path/to/rabit/src/../include/rabit/internal/engine.h:10,
                 from /home/path/to/rabit/src/engine_empty.cc:13:
/home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/././base.h:271:10: fatal error: dmlc/build_config.h: No such file or directory
 #include <dmlc/build_config.h>
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
CMakeFiles/rabit_base.dir/build.make:62: recipe for target 'CMakeFiles/rabit_base.dir/src/allreduce_base.cc.o' failed
make[2]: *** [CMakeFiles/rabit_base.dir/src/allreduce_base.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/rabit_empty.dir/build.make:62: recipe for target 'CMakeFiles/rabit_empty.dir/src/engine_empty.cc.o' failed
make[2]: *** [CMakeFiles/rabit_empty.dir/src/engine_empty.cc.o] Error 1
CMakeFiles/Makefile2:141: recipe for target 'CMakeFiles/rabit_empty.dir/all' failed
make[1]: *** [CMakeFiles/rabit_empty.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 41%] Building CXX object CMakeFiles/rabit.dir/src/allreduce_robust.cc.o
[ 50%] Building CXX object CMakeFiles/rabit.dir/src/engine.cc.o
In file included from /home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/./logging.h:16:0,
                 from /home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/io.h:15,
                 from /home/path/to/rabit/src/./../include/rabit/internal/../serializable.h:12,
                 from /home/path/to/rabit/src/./../include/rabit/internal/engine.h:10,
                 from /home/path/to/rabit/src/./engine.cc:14,
                 from /home/path/to/rabit/src/engine_base.cc:14:
/home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/././base.h:271:10: fatal error: dmlc/build_config.h: No such file or directory
 #include <dmlc/build_config.h>
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
CMakeFiles/rabit_base.dir/build.make:86: recipe for target 'CMakeFiles/rabit_base.dir/src/engine_base.cc.o' failed
make[2]: *** [CMakeFiles/rabit_base.dir/src/engine_base.cc.o] Error 1
CMakeFiles/Makefile2:104: recipe for target 'CMakeFiles/rabit_base.dir/all' failed
make[1]: *** [CMakeFiles/rabit_base.dir/all] Error 2
[ 58%] Building CXX object CMakeFiles/rabit.dir/src/c_api.cc.o
In file included from /home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/./logging.h:16:0,
                 from /home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/io.h:15,
                 from /home/path/to/rabit/src/./../include/rabit/internal/../serializable.h:12,
                 from /home/path/to/rabit/src/./../include/rabit/internal/engine.h:10,
                 from /home/path/to/rabit/src/./allreduce_base.h:19,
                 from /home/path/to/rabit/src/allreduce_base.cc:14:
/home/path/to/rabit/src/./../include/rabit/internal/../../../dmlc-core/include/dmlc/././base.h:271:10: fatal error: dmlc/build_config.h: No such file or directory
 #include <dmlc/build_config.h>
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
CMakeFiles/rabit.dir/build.make:62: recipe for target 'CMakeFiles/rabit.dir/src/allreduce_base.cc.o' failed
make[2]: *** [CMakeFiles/rabit.dir/src/allreduce_base.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/./logging.h:16:0,
                 from /home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/io.h:15,
                 from /home/path/to/rabit/src/../include/rabit/internal/../serializable.h:12,
                 from /home/path/to/rabit/src/../include/rabit/internal/engine.h:10,
                 from /home/path/to/rabit/src/engine.cc:14:
/home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/././base.h:271:10: fatal error: dmlc/build_config.h: No such file or directory
 #include <dmlc/build_config.h>
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
CMakeFiles/rabit.dir/build.make:110: recipe for target 'CMakeFiles/rabit.dir/src/engine.cc.o' failed
make[2]: *** [CMakeFiles/rabit.dir/src/engine.cc.o] Error 1
In file included from /home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/./logging.h:16:0,
                 from /home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/io.h:15,
                 from /home/path/to/rabit/src/../include/rabit/internal/../serializable.h:12,
                 from /home/path/to/rabit/src/../include/rabit/internal/io.h:15,
                 from /home/path/to/rabit/src/allreduce_robust.cc:13:
/home/path/to/rabit/src/../include/rabit/internal/../../../dmlc-core/include/dmlc/././base.h:271:10: fatal error: dmlc/build_config.h: No such file or directory
 #include <dmlc/build_config.h>
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
CMakeFiles/rabit.dir/build.make:86: recipe for target 'CMakeFiles/rabit.dir/src/allreduce_robust.cc.o' failed
make[2]: *** [CMakeFiles/rabit.dir/src/allreduce_robust.cc.o] Error 1
In file included from /home/path/to/rabit/src/../include/rabit/./internal/../../../dmlc-core/include/dmlc/./logging.h:16:0,
                 from /home/path/to/rabit/src/../include/rabit/./internal/../../../dmlc-core/include/dmlc/io.h:15,
                 from /home/path/to/rabit/src/../include/rabit/./internal/../serializable.h:12,
                 from /home/path/to/rabit/src/../include/rabit/./internal/engine.h:10,
                 from /home/path/to/rabit/src/../include/rabit/rabit.h:32,
                 from /home/path/to/rabit/src/c_api.cc:8:
/home/path/to/rabit/src/../include/rabit/./internal/../../../dmlc-core/include/dmlc/././base.h:271:10: fatal error: dmlc/build_config.h: No such file or directory
 #include <dmlc/build_config.h>
          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.
CMakeFiles/rabit.dir/build.make:134: recipe for target 'CMakeFiles/rabit.dir/src/c_api.cc.o' failed
make[2]: *** [CMakeFiles/rabit.dir/src/c_api.cc.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/rabit.dir/all' failed
make[1]: *** [CMakeFiles/rabit.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

@chenqin Let's add cmake build to Travis tests.  Adding dmlc-core will cause XGBoost having 2 copies of this submodule.  Before you merge this, let me try remove the one in XGBoost. ;)

@trivialfis

@chenqin Let's add cmake build to Travis tests. Adding dmlc-core will cause XGBoost having 2 copies of this submodule. Before you merge this, let me try removing the one in XGBoost. ;)
added cmake build travis test. I think the sequence should be

merge this to rabit
update xgb with latest rabit and remove dmlc-core as submodule in xgb

test seems flaky again, pass on my mac and linux, will address in upcoming tests refactor.

@trivialfis @CodingCat

On my end tried out all builds (Makefile and CMake) with GCC 7.3.0 and run all tests on Ubuntu 18.04 with no problems.

can we get this merged if no objection?
Follow up action

fix travis test flaky issue
update xgb and point dmlc-core to rabit submodule

I incline to move forward with other pr in pipeline. Also, it would be great if I can get write option to repo so I can triage issues / assign reviewer as well as merge prs without reviewer objection.
@trivialfis @CodingCat @thvasilo @tqchen

If we found problem in test, we should fix that first, otherwise we are essentially merging more and more broken commits

I think we have the convention to assign write permission to dmlc members (project committers)
To keep the health of project, we should follow it as usual, and when the contributor has brought significant improvement to the project, the current commitee members will start voting to elect a new committer

In response to tests issue, the plain answer is I can’t reproduce issue and Travis sometimes stuck other times not. I am working on breaking down and adding gtests coverage piece by piece. That should give better cleanup out of dated code base. So for this pr, it doesn’t introduce material implementation changes other than house cleaning. I expect meaningful amount of such clean ups taken before I can reason those tests stuck reason.

In response to tests issue, the plain answer is I can’t reproduce issue and Travis sometimes stuck other times not. I am working on breaking down and adding gtests coverage piece by piece. That should give better cleanup out of dated code base. So for this pr, it doesn’t introduce material implementation changes other than house cleaning. I expect meaningful amount of such clean ups taken before I can reason those tests stuck reason.

I agree that cleaner code base would facilitate debugging and for this PR merging it before the bug is fixed maybe do no harm.
On the other side, cleaning code base and adding test coverage to make debugging easier is not necessary to be merged to master given that the commit is broken because of the flaky test
a better way is making everything in your private branch first until the bug is identified and fixed, and then break the huge PR into several smaller ones and merge one by one...in this approach, we can prevent back and forth modification on the same file


+- 1 window

Hi,
Not sure this is the best way to do this so feel free to discard entirely. This allows the "next" and "previous" OTP to be verified.

Note : This project has not been updated since it was created. If you need a PHP OTP library, you should check out the great fork by Spomky-Labs at https://github.com/Spomky-Labs/otphp which has been improved and is currently maintained.


Use platform-specific collections inside Compose protocol

These collections are implementation details and are used at some of the lowest layers of the app. They should be as efficient as possible.
Before JS:
function ProtocolState() {
  this.a3h_1 = _Id___get_value__impl__b6l2oq(Companion_getInstance().r3d_1) + 1 | 0;
  this.b3h_1 = LinkedHashMap_init_$Create$();
  this.c3h_1 = ArrayList_init_$Create$();
  this.d3h_1 = ArrayList_init_$Create$();
  this.e3h_1 = ArrayList_init_$Create$();
  this.f3h_1 = false;
  this.g3h_1 = 8;
}

ProtocolState.prototype.i3h = function (childrenDiff) {
  this.c3h_1.a(childrenDiff);
  this.f3h_1 = true;
};

ProtocolState.prototype.u3g = function () {
  if (!this.f3h_1)
    return null;
  var diff = new Diff(this.c3h_1, this.d3h_1, this.e3h_1);
  this.c3h_1 = ArrayList_init_$Create$();
  this.d3h_1 = ArrayList_init_$Create$();
  this.e3h_1 = ArrayList_init_$Create$();
  return diff;
};

ProtocolState.prototype.o3h = function (id) {
  return this.b3h_1.t2(new Id(id));
};

After JS:
function ProtocolState() {
  this.a3h_1 = _Id___get_value__impl__b6l2oq(Companion_getInstance().r3d_1) + 1 | 0;
  this.b3h_1 = new Map();
  this.c3h_1 = new Array();
  this.d3h_1 = new Array();
  this.e3h_1 = new Array();
  this.f3h_1 = false;
  this.g3h_1 = 8;
}

ProtocolState.prototype.i3h = function (childrenDiff) {
  this.c3h_1.push(childrenDiff);
  this.f3h_1 = true;
};

ProtocolState.prototype.u3g = function () {
  if (!this.f3h_1)
    return null;
  var tmp = new JsArrayList(this.c3h_1);
  var tmp_0 = new JsArrayList(this.d3h_1);
  var tmp$ret$2 = new JsArrayList(this.e3h_1);
  var diff = new Diff(tmp, tmp_0, tmp$ret$2);
  this.c3h_1 = new Array();
  this.d3h_1 = new Array();
  this.e3h_1 = new Array();
  return diff;
};

ProtocolState.prototype.o3h = function (id) {
  return this.b3h_1.get(_Id___get_value__impl__b6l2oq(id));
};

In terms of code size it's a lateral move at best, but by using the raw underlying collections we are not subject to layers of wrappers and indirection for emulating the JVM collection semantics that Kotlin's collection have unfortunately inherited. Additionally, we explicitly unbox Id before it goes into our map to avoid an actual boxing operation that is not needed in JS. On the JVM the Int will still box, but that's fine since it always boxed Id before. When Babel ultimately runs over this code functions like _Id___get_value__impl__b6l2oq will disappear completely as it is an identity function.

It has no released versions (yet), the number of APIs we need is extremely small, and we really only care about specializing JS. Someday it might be worth switching over, such as if we start needing these across multiple modules.


DOM unit testing

Thanks!
It looks good to me, do you have the right to merge this pull request?

@Mogztter I do 🙂 I wanted to make sure it made sense for you, and heading us in the right direction.

Absolutely, using regex was a temporary solution. We can test more accurately with a DOM library :+1:


Update swagger-ui distribution

The swagger-ui distribution shipped with swagger-tools is old and needs to be updated.

Would it be possible to add some sort of hooks that make it easier to customize auth?
Related:

https://github.com/swagger-api/swagger-js/blob/master/README.md#custom-request-signing
https://github.com/swagger-api/swagger-ui/issues/818

Not sure if you are aware but you can use a custom swagger-ui distribution with swagger-tools.  This will let you do whatever you want from a swagger-ui perspective.  To answer your specific questions, I'm using response headers from the server to wire up the API URL for the "Try it now!" feature so I could do something like this for what you're wanting but then we're into the situation where we're putting application specific stuff into swagger-tools, something I don't want to do unless it's consumable by many.
If you've got some proposal about how to do this in a more generic/pluggable way, I can do it but you already have the same mechanisms available (extra routes on your server and a custom loader for swagger-ui).

Why do you have to maintain a copy of swagger-ui within the project? I'm probably missing something obvious here, just curious.
From my point of view I can resolve the issue like this:

Depend on swagger-ui directly.
Copy node_modules/swagger-ui/dist to some place when building
Copy tweaked index.html with API specific changes on top of swagger-ui one when building
Point swagger-tools to use this version.

I guess that's about it. It feels a little bit nasty that the JS is within index.html but that's more of a swagger-ui issue.

I don't have to but the idea was to make it as simple as possible to get swagger-ui deployed.  (You'd be surprised how many people struggle with this.)  I didn't realize I could install swagger-ui as an NPM dependency, I'd much rather do that, but I do have a custom index.html that gets the API URL from the server.  (Like you said, having JavaScript in index.html sucks but that's a swagger-ui mechanism I built on top of.) If I could figure out some way to wire things up without that, I'd love to stop shipping swagger-ui with the project.

I set up an issue for this. See https://github.com/swagger-api/swagger-ui/issues/952 and feel free to chime in if needed.
I think in swagger-tools case you might be get away with by setting swagger-ui as a peer dependency to the project and then documenting basic usage. It is important to avoid a direct dependency as then you could end up in a situation where there is a conflict between project swagger-ui and swagger-tools version. Having it as a peer dependency should help to alleviate this.
You'll need some sort of copy step no matter what given you have customizations in place. On the bright side you could provide multiple customized init files to pick from making it easier to adjust to various API setups.

Ok, apparently they have a milestone for exactly this! See https://github.com/swagger-api/swagger-ui/issues/804 .

I've subscribed to the issue.  In the meantime, I'm going to update swagger-ui as I always have and when that issue allows for it, I will then move the included swagger-ui out of the module and use a dependency to get the bundle in.

Great. That should simplify things. :)

@whitlockjc Looks like they have resolve the issue. See https://github.com/swagger-api/swagger-ui/issues/804#issuecomment-83184929 .

This was fixed in the last release, v0.8.6.

@whitlockjc Any chance you could update the Swagger UI distribution in Swagger Tools? I'd like to take advantage of the multi-line (textarea) input for string array parameters -- available in latest Swagger UI but not in the version that ships with Swagger Tools.

I will be doing that sometime next week.


GoogleSymbols icons are not properly vertically centered by Flutter rendering logic

Summary of the issue:

GoogleSymbols are being rendered in Flutter with incorrect vertical centering. When teams try to migrate from other icon libraries, their layouts break.
After some discussion about whether there's an issue in the symbol font, it seems like the issue is that the way that Flutter determines the center of the symbol isn't compatible with the way this particular symbol library is represented - from @tphinney in b/267281950, flutter "does the centering by using one of the top vertical values (NOT cap height!) from the font, and the baseline, rather than the top and bottom. It is unfortunate; if they had used cap height and baseline, we would have been OK. Their approach will probably work with many symbol fonts, but is not so great in our particular case."
It's difficult to change the values in the symbol font file we ship, because the same font is used across many platforms/products/clients etc and the change would not be backwards compatible. Possibly someone could create a tool that transforms the upstream font to a special Flutter-compatible version, though that seems a little messy and confusing.

Maybe there's some change that could be made to Flutter's rendering logic that would fix rendering for this symbol font without breaking rendering for other fonts? It sounds like maybe there's some ambiguity in the best way to center symbols. Could someone on the Flutter engine team provide an opinion on this? We need a fix or workaround for this issue somewhere in the stack, it's just unclear where the most elegant place for that is.
Example of the bug:

There is a lot of discussion about this floating around in https://github.com/flutter/flutter/issues/102560, https://github.com/google/material-design-icons/issues/1500 and Google bug b/267281950, but I wanted to create an issue specifically for the vertical centering problem seeing as it's starting to create work for Google teams to add a proliferation of workarounds.

Yes, the possible solutions include:

Flutter to change their general logic for how they vertically center text, at least for symbol fonts. Probably not happening because it would break too many existing layouts.
Material Symbols to change their vertical metrics to be compatible with Flutter’s existing logic. Again, probably not happening because it would break existing layouts for that font with pretty much all other apps (including anybody already using Flutter, but also people using other tools).
Flutter could special-case Material Symbols (and the Google-internal version, Google Symbols) and treat it differently. This would break existing layouts too, but at least only those using the Symbols fonts in Flutter.
One could make variant fonts, or make a tool that generates such variant fonts, that have vertical metrics set the way that would work better in Flutter.

You can probably tell from the way I discuss this that I think the first two options, although simple and tempting, are non-starters from a practical impact point of view. I also am not excited by the idea (4) of maintaining extra font versions that are Flutter-specific, seeing as that is megabytes of code instead of just a few lines.
Google itself is not immune to this problem. I am hopeful this external version of the issue can be updated, after decisions are made on how to tackle it internally.

Related to https://github.com/flutter/flutter/issues/98909

NOTE: this applies to both “Google Symbols” (the internal Google version) and “Material Symbols” (the external version that drops some proprietary Google logos and icons). Any special casing of fonts in app code, or special builds of variant fonts, or whatever, would need to cover/handle both.

Adding P0 to align with go/flutter-bugs#github-priority

(from critical triage) cc @jason-simmons @LongCatIsLooong Is this an issue with how the engine renders these symbols?

Is there a minimal repro for this issue? IIRC the vertical alignment depends on whether height of the text is set to a non-null value (which unfortunately is a bit unintuitive).

I tried modifying Flutter's Icon widget to specify a non-null height parameter. It definitely changed the result, but this doesn't seem like a scalable solution.
Here's the symbol rendered in a FAB with height null:

Here's the same rendering with height 1.0:

And finally, here's with height 1.1:

Setting the value to 1.0 doesn't seem to impact regular Icons, but that isn't actually any better for symbols.

I think if a line has only one font then the EM box is vertically centered, even when the font has a negative descent. I download the font (is it https://github.com/google/material-design-icons/blob/master/variablefont/MaterialSymbolsOutlined[FILL%2CGRAD%2Copsz%2Cwght].ttf ?) but it looked fine in a RichText:

The styles used:
  final text = RichText(text: TextSpan(
      text: '\uEF4A',
      style: TextStyle(
        fontFamily: 'Symbols',
        fontSize: 500,
        //height: 1,
        //leadingDistribution: TextLeadingDistribution.even,
      ),
  ));

That is the right font — well, one of them, at least. All of the Material/Google Symbols fonts have the same vertical metrics and are vertically centered on the same point—half the cap height—regardless of the particular instance chosen.

Ahhh I was looking at os2.sTypoDescender that's why the value's negative. So it looks like the glyphs are vertically centered at (1056 - 96) / 2 = 480 in which case Skia got everything right. It's just the Icon widget clipped the glyph at the bottom since it expected a smaller height. This should be an easy and non-breaking fix.

With the fixing of https://github.com/flutter/flutter/issues/138592 with https://github.com/flutter/flutter/pull/138937 then this issue (the same issue) should be fixed as well.
I also confirmed that with #138937 in place the https://pub.dev/packages/material_symbols_icons Symbols icons all render correctly centered without modifying the font metrics of the symbols fonts.  (and that the altered-metrics symbols fonts continue to render correctly as well with #138937 in place).
Going forward it will now be possible to use the material symbols icons fonts unaltered, (but those versions would obviously continue to render incorrectly on previous flutter versions.)  The https://pub.dev/packages/material_symbols_icons package will render correctly on all previous and new flutter versions.
This issue can be closed as fixed by  https://github.com/flutter/flutter/pull/138937


Selecting a Window Based on Image

Is the above possible? If I have two windows open both named "CRAZY WINDOW NAME" one being a program/executable and another being "explorer", is it possible to just target the explorer window and leave the program/executable alone?

You can filter Cmdow's output with FINDSTR and a regular expression:-
for /f %%a in ('cmdow /b ^| findstr "explorer.*CRAZY WINDOW NAME"') do (
  cmdow %%a /act
)

Note the pipe character (|) has been 'escaped' using a carat (^). Adjust the options in the second use of Cmdow to suit your requirements.


feat: specify secret adoption for every secret

This change is part of the following stack:

#704

#714 ◀

Change managed by git-spice.


Bayes3D should run on colab

Here's my first attempt: https://colab.research.google.com/drive/1NVqj160376q94YueHcITzzOfjNJ-Pq7o#scrollTo=4zSG05_KzgGz&uniqifier=1
@horizon-blue has an even better version that persists to gdrive.
Here is a reference on how to do the gdrive persistence: https://colab.research.google.com/drive/1KpMDi9CjImudrzXsyTDAuRjtbahzIVjq
@horizon-blue , I'd love if you could post some notes on how you did it!

Hi @sritchie, this is looking great!
Re Google drive:
I didn't know that we can host a custom package index using GCloud when I wrote the initial Colab notebook, so I made the wheels available in a stupid way, where I uploaded them as files to a wheels folder on my Google drive, and enabled link sharing. Then, on Colab, I used gdown to download the entire wheels folder (which includes the .whl files for genjax and bayes3d), then run pip install wheels/* to install from files.


WIP: Optimized matcher

This is a draft implementation with some new ideas.

Static paths don't need regex match for most cases.
Match don't have to be always linear, it is possible to match only with static paths.

Regex match is 10x slower than simple object access. I still have to run some dynamic matches to not break ordering compatibility.
I still want to integrate it better with current code, I did this implementation to validate the issue and run some benchmarks.

I did a small benchmark script to prove the concept, in my own machine.
https://gist.github.com/iurisilvio/a916ce2de16336ec97aab8db5525f7f9
For 100 static routes, current vue-router takes 14ms average to resolve and my version takes less than 1ms.
Even to resolve the first result, it is 30% slower because it evaluates one regex.

For dynamic paths, it will evaluate only part of the routes, based on first level path. If you have 100 rules but only 5 starting with the same first level path, it will evaluate at most 5 rules.


TOI loses control too quickly

TOI loses control too soon (can't say after how long, about 1-2 hours), resulting in failure of readout, and stopping the observation sequence. Control should last at least 14 hours.

changed to many hours


Support aws-otel-java-instrumentation agent with KMS 1.X SDK

Hi!
I am trying to use aws-otel-java-instrumentation java agent in my project and I see an issue shown below with KMS signing.
I am using KMS SDK 1.x and providing aws credentials via env vars.
I don't see this issue when I use the non-aws otel java agent and KMS SDK 1.x.
I created a sample project here to reproduce this. When using AWS KMS SDK 2.X, app does not throw the exception.
Is 1.X AWS KMS  SDK supported by aws otel java agent? If it is supported, this is a valid issue.
Exception thrown when using AWS OTEL java agent with KMS AWS SDK 1.x:
[otel.javaagent 2022-01-25 17:27:16:006 -0600] [main] INFO io.opentelemetry.javaagent.tooling.VersionLogger - opentelemetry-javaagent - version: 1.10.0-aws

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: begin 0, end -7, length 0
at java.base/java.lang.String.checkBoundsBeginEnd(String.java:3734)
at java.base/java.lang.String.substring(String.java:1903)
at io.opentelemetry.javaagent.shaded.instrumentation.awssdk.v1_11.AwsSdkExperimentalAttributesExtractor$1.computeValue(AwsSdkExperimentalAttributesExtractor.java:34)
at io.opentelemetry.javaagent.shaded.instrumentation.awssdk.v1_11.AwsSdkExperimentalAttributesExtractor$1.computeValue(AwsSdkExperimentalAttributesExtractor.java:30)
at java.base/java.lang.ClassValue.getFromHashMap(ClassValue.java:228)
at java.base/java.lang.ClassValue.getFromBackup(ClassValue.java:210)
at java.base/java.lang.ClassValue.get(ClassValue.java:116)
at io.opentelemetry.javaagent.shaded.instrumentation.awssdk.v1_11.AwsSdkExperimentalAttributesExtractor.extractOperationName(AwsSdkExperimentalAttributesExtractor.java:55)
at io.opentelemetry.javaagent.shaded.instrumentation.awssdk.v1_11.AwsSdkExperimentalAttributesExtractor.onStart(AwsSdkExperimentalAttributesExtractor.java:43)
at io.opentelemetry.javaagent.shaded.instrumentation.awssdk.v1_11.AwsSdkExperimentalAttributesExtractor.onStart(AwsSdkExperimentalAttributesExtractor.java:26)
at io.opentelemetry.javaagent.shaded.instrumentation.api.instrumenter.Instrumenter.start(Instrumenter.java:174)
at io.opentelemetry.javaagent.shaded.instrumentation.awssdk.v1_11.TracingRequestHandler.beforeRequest(TracingRequestHandler.java:41)
at io.opentelemetry.javaagent.instrumentation.awssdk.v1_11.TracingRequestHandler.beforeRequest(TracingRequestHandler.java:45)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.runBeforeRequestHandlers(AmazonHttpClient.java:850)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.doExecute(AmazonHttpClient.java:792)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.executeWithTimer(AmazonHttpClient.java:779)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.execute(AmazonHttpClient.java:753)
at com.amazonaws.http.AmazonHttpClient$RequestExecutor.access$500(AmazonHttpClient.java:713)
at com.amazonaws.http.AmazonHttpClient$RequestExecutionBuilderImpl.execute(AmazonHttpClient.java:695)
at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:559)
at com.amazonaws.http.AmazonHttpClient.execute(AmazonHttpClient.java:539)
at com.amazonaws.services.kms.AWSKMSClient.doInvoke(AWSKMSClient.java:7785)
at com.amazonaws.services.kms.AWSKMSClient.invoke(AWSKMSClient.java:7752)
at com.amazonaws.services.kms.AWSKMSClient.invoke(AWSKMSClient.java:7741)
at com.amazonaws.services.kms.AWSKMSClient.executeSign(AWSKMSClient.java:6631)
at com.amazonaws.services.kms.AWSKMSClient.sign(AWSKMSClient.java:6600)
at Main.main(Main.java:17)

Thanks @gautam-nutalapati - I have filed https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/5229 upstream this does seem to be a bug in the instrumentation. The reason it is showing up in the aws otel agent and not upstream for you is that we default to -Dotel.instrumentation.aws-sdk.experimental-span-attributes=true in this distribution. As a workaround until that is fixed you can try to set that flag to false but may see less information in traces.

@gautam-nutalapati Thanks a lot for the repro app - I notice the issue is because of the {{ implicit subclassing pattern used here
https://github.com/gautam-nutalapati/test-aws-otel-agent/blob/main/src/main/java/Main.java#L10
It's not appropriate for the instrumentation to just crash for code that would otherwise work so I will work on fixing that, but does it work for you to use a more normal pattern calling setters on new SignRequest() without the subclassing?

@anuraaga Thank you for the fix in upstream repo! and also for pointing out the subclassing pattern!
Using setters has solved the issue for me.


Theia sticky sidebar doesn’t work

Hello i need help, theia sticky sidebar doesnt work on my site. It is as before normal sidebar. I tried to follow the instructions but nothing happens still the same. Can you please help me. Thanks

We need more info to determine if it's actually a bug that we should fix.


OpenSSL 1.1.1l: verification problem of expired 'DST Root CA X3' certificate

I have verification problem of expired 'DST Root CA X3' certificate in my C# application on Win7.
If the external certification bundle file is loaded then there is no problem. I have received 3 verification callbacks from openssl.
All 3 certificates are preverified by openssl. No need to verify them via Win store.
Certificate: Issuer:'ISRG Root X1' Subject:'ISRG Root X1'
Certificate: Issuer:'ISRG Root X1' Subject:'R3'
Certificate: Issuer:'R3' Subject:'somedomain.com'
If the external certification bundle file is not loaded then first verification callback is this:
Certificate: Issuer:'DST Root CA X3' Subject:'ISRG Root X1'
Win store reports that certificate is expired.
If I return 0 (as I should) it leeds to handshake failure.
If I ignore the error then I receive next 2 callbacks:
Certificate: Issuer:'ISRG Root X1' Subject:'R3'
Certificate: Issuer:'R3' Subject:'somedomain.com'
Both certificates are properly verified by Win store. So handshake is complete.
Here is the question: I'm doing something wrong during verification of expired 'DST Root CA X3' certificate or there is a bug in Open SSL?

If I understand correctly, the openssl doesn't know the alternative chain path so I have to take a look for another root certificate with the same Subject and PublicKey in Win store and check it in X509Chain.

Yeah, that would work.


Wont compile in ios

Hi, it wont compile in iOS, and without it - udp work nicely in iOS, suggestion : make it just compile and dont do anything, I tried to remove result(true) , it compiled but will hang after calling the function
Thanks

Should be result(false)  in iOS side, and the 'hang' thing is because I havent close the udp


Unable to build as a shared library

Describe the bug
It is not possible to build Adiar as a shared library.
To Reproduce
Try to build the make main target changed such that CMake also is parsed the value -D ADIAR_SHARED = ON. Building the Adiar library itself and also main.cpp works fine, but linking main.cpp to Adiar does not work at all.
[100%] Linking CXX executable adiar_main
/usr/bin/ld: CMakeFiles/adiar_main.dir/main.cpp.o: in function `main':
/home/soelvsten/git/adiar/src/main.cpp:20: undefined reference to `adiar::adiar_init(unsigned long, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)'
/usr/bin/ld: /home/soelvsten/git/adiar/src/main.cpp:30: undefined reference to `adiar::adiar_printstat(std::ostream&)'
/usr/bin/ld: /home/soelvsten/git/adiar/src/main.cpp:32: undefined reference to `adiar::adiar_deinit()'
collect2: error: ld returned 1 exit status
make[4]: *** [src/CMakeFiles/adiar_main.dir/build.make:102: src/adiar_main] Error 1
make[4]: Leaving directory '/home/soelvsten/git/adiar/build'
make[3]: *** [CMakeFiles/Makefile2:257: src/CMakeFiles/adiar_main.dir/all] Error 2
make[3]: Leaving directory '/home/soelvsten/git/adiar/build'
make[2]: *** [CMakeFiles/Makefile2:264: src/CMakeFiles/adiar_main.dir/rule] Error 2
make[2]: Leaving directory '/home/soelvsten/git/adiar/build'
make[1]: *** [Makefile:215: adiar_main] Error 2
make[1]: Leaving directory '/home/soelvsten/git/adiar/build'
make: *** [makefile:68: main] Error 2

Additional context
If we can get Adiar to run as a shared library (with TPIE only inside of it), then the LGPL v3 license of TPIE makes it possible to use this in a closed-source project.

If the user at this point sets ADIAR_SHARED to ON then CMake will crash - there is no reason for it to cryptically fail and have tons of settings that are only related to building it as a shared library.


Ruff fails when a directory ends with .py

Ruff gets confused when a directory is named like a python file (ends with .py):
$ mkdir repro
$ mkdir repro/some_folder.py
$ cargo run --bin ruff -- --no-cache repro
error: Failed to lint repro/some_folder.py: Is a directory (os error 21)
  Caused by: Is a directory (os error 21)
repro/some_folder.py:1:1: E902 Is a directory (os error 21)
  Caused by: Is a directory (os error 21)
Found 1 error.

@konstin is this a good first issue?

(From my perspective, seems like a good issue, will probably require digging into how we collect the "files to lint".)

i've confirmed it's not related to #5611, so yes it's a good first issue

can I work on this?

Is this the part that needs to be fixed?
https://github.com/astral-sh/ruff/blob/f029f8b7840e4477f2f42d8f589c4ac290a249e6/crates/ruff/src/resolver.rs#L332-L350

Testing this change:
diff --git a/crates/ruff/src/resolver.rs b/crates/ruff/src/resolver.rs
index 0ad0fa244..0d851135c 100644
--- a/crates/ruff/src/resolver.rs
+++ b/crates/ruff/src/resolver.rs
@@ -330,9 +330,12 @@ pub fn python_files_in_path(
             }

             if result.as_ref().map_or(true, |entry| {
+                if !(entry.file_type().map_or(false, |ft| ft.is_file())) {
+                    return false;
+                }
                 if entry.depth() == 0 {
                     // Accept all files that are passed-in directly.
-                    entry.file_type().map_or(false, |ft| ft.is_file())
+                    true
                 } else {
                     // Otherwise, check if the file is included.
                     let path = entry.path();

Result:
> tree dir
dir
├── dir.py
│   └── file.py
└── file.py

1 directory, 2 files

> cargo run -p ruff_cli -- check dir --no-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/ruff check dir --no-cache`
dir/dir.py/file.py:1:7: F821 Undefined name `a`
dir/file.py:1:7: F821 Undefined name `a`
Found 2 errors.


Spelling and missing paren

Fixed a missing paren in PacketField.repr().
While I was at it, fixed some obviously misspelled words.  Weird thing is that the following "words" keep reappearing in cleanly-built html, even though they don't appear anywhere in the source files:
converteed
indeces
packats
replacment
Retreive
suports

Thanks so much! I am happy to merge this.

Weird thing is that the following "words" keep reappearing in cleanly-built html, even though they don't appear anywhere in the source files:

The docs pick up on the installed version of the module (in site-packages), not the version of the code in the directory above. Easiest solution is to just run pip install . in the directory above before you build the docs. Let me know if this doesn't work for you.

That works - thanks!


extra # in css

../less/themes/light.less
27 line:
background: ##f1f1f1;
expecting  background: #f1f1f1;

Thanks for spotting this.


Add name fields

This PR:

[x] Closes #412.
[x] Adds and passes relevant tests.
[x] Has well-formatted code and documentation.

Benchmarks on VRPTW
This PR w/ std::string (cbd36cebf38cf29739b37a8486cccbe265e9b863; 10x seeds, 1h; job ID 6975160):
               MEAN      MIN       MAX   COV
      inst
obj   C1    41365.0  41340.2   41406.6   0.0
      C2    16191.6  16188.8   16194.8   0.0
      R1    47279.6  47203.5   47411.3   0.1
      R2    27774.8  27731.4   27801.8   0.1
      RC1   44246.9  44190.2   44283.4   0.1
      RC2   23269.9  23253.1   23282.5   0.0
iters C1    59861.9  49358.3   66563.5   7.6
      C2    97626.2  77936.6  108538.2   9.6
      R1    32440.1  25192.6   36297.7  12.3
      R2    48749.3  35693.8   55939.6  13.1
      RC1   36444.3  26475.0   40933.9  13.5
      RC2   49916.8  37278.9   56831.7  14.3

From #411:
                MEAN      MIN       MAX   COV
      inst
obj   C1     41364.4  41339.2   41406.3   0.0
      C2     16190.8  16188.5   16193.2   0.0
      R1     47258.6  47186.1   47302.3   0.1
      R2     27766.2  27727.2   27796.0   0.1
      RC1    44235.4  44204.8   44253.1   0.0
      RC2    23266.7  23252.5   23302.3   0.1
iters C1     63203.5  47433.9   70698.7  12.6
      C2    106604.0  80918.5  119611.2  12.6
      R1     36559.1  27936.8   41311.5  13.1
      R2     54925.2  42722.3   62756.7  12.3
      RC1    39750.0  30405.4   44036.5  11.7
      RC2    56193.6  43259.6   61123.7  12.0

Notes:

It is essential that you add a test when making code changes.
This keeps the code coverage level up, and helps ensure the changes work as intended.
When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
Docstring additions must render correctly, including escapes and LaTeX.

Yeah that seems to matter a fair bit for overall performance, like 10% fewer iterations. I'll try the char pointer stuff tomorrow.

Yeah, with char const * seems to be faster (higher iterations).

@leonlan could you have a look at this? Once this is in I'll continue to work on writing MDVRPTW solutions.


python312Packages.aiohttp: 3.10.3 -> 3.10.5

https://github.com/aio-libs/aiohttp/blob/v3.10.5/CHANGES.rst
Description of changes
Required for home-assistant 2024.9.0.

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Required for home-assistant 2024.9.0.

Actually required or can we just relax the version constraint?

Relaxing could be fine. The update PRs carry no code changes.


No such file or directory: 'requirements.txt'

Hi, thanks for this project, very cool. the instructions say to install python packages using requirements.txt but looks like that file is missing?

Hey there. You don't need much to get this off the ground.  Copy and run this command from root and you will be all set @goggledefogger
touch requirements.txt & echo "bs4" >> requirements.txt & echo "openai" >> requirements.txt & echo "halo" >> requirements.txt & echo "pyaml" >> requirements.txt & echo "pyPDF2" >> requirements.txt & pip install -r requirements.txt


Compilation issues with oneAPI Base Toolkit 2023.0.0

As reported by @irudkin in #23 users compiling the project with oneAPI Base Toolkit 2023.0.0 and the corresponding SYCL CUDA backend plugin may run into some release-specific compilation issues. Namely:

dpcpp executable is deprecated and replaced with icpx -fsycl
compilation errors and/or warnings described in https://developer.codeplay.com/products/oneapi/nvidia/2023.0.0/guides/troubleshooting

A suggested solution:

Replace dpcpp check in src_sycl/CMakeLists.txt with an icpx check
Link the troubleshooting guide in the README

The first part of this issue has been dealt with in #22 but the second hasn't been addressed


Allow editing of split measure table

The measure table has been split into housemeasure and personalmeasure. Editing for these new tables should be created.

Both the house measure table and the personal measure table can be edited in the admin app now.


Add local directory for users to add pluggable check modules

Add a local directory outside of the perl5 lib path for users to add modules to.
As is, a user would need to contribute their modules to the project, or install them into perl5 lib themselves.  There should be an easier way for them to do it.

b56346f - Add requirement for configuration
5a6aad4 - Parse config for localdir and load into config
8a1605d - Update documentation for localdir config setting
22e0baa - Add happy path test for user_config

merged to 1.0.0.