New Pull Request process

Summary
Previously, the CI/CD workflow was setup to trigger on Pull Requests, causing GitHub to automatically add all jobs in the CI/CD workflow as checks in the Pull Request. This had some disadvantages:

Fork Pull Requests does not have access to secrets and cannot run builds if a license or an insider sas token is required
Fork Pull Requests might contain malicious code which (if not discovered by the person accepting the PR) will run during the workflow
All jobs in the CI/CD workflow are added as checks, also the initialization job etc. - doesn't look good

Intended Outcome
How will it work?
eee

Testing projects


decK sync fails with Kong EE Free version

decK calls GET /mtls-auths since version 1.2.0.
Kong OSS returns 404 for that endpoint while Kong EE Free returns 403 for the same endpoint, resulting in an error when executing the deck sync command.
Here is the example of the deck sync call:
$ deck.1.6.0 sync
Error: mtls-auths: HTTP status 403 (message: "Forbidden")
mtls-auths: HTTP status 403 (message: "Forbidden")

I just pulled the latest version from GitHub and this error doesn't occur. Just to be sure, I checked out tag v1.6.0 from GitHub and an error occurs (as expected).
This issue is already fixed by https://github.com/Kong/deck/pull/321 and will be included in the next release.
Probably this issue should be closed as soon as the new version is released.

This is duplicate of https://github.com/Kong/deck/issues/274.

I found it to be fixed in deck version 1.7.0 :)


Can't stop service with 3.0-RC2

Shutting down the service doesn't stop anything.
"Waiting for shutdown" shows for several seconds before continuing. If I try stopping the service again, it doesn't pause at that point.
➜  ~ sudo service arangodb3 start
 * Starting arango database server arangod
/etc/init.d/arangodb3: 37: ulimit: error setting limit (Invalid argument)
{startup} starting up in daemon mode
changed working directory for child process to '/var/tmp'
                                                                                [ OK ]
➜  ~
➜  ~ sudo service arangodb3 stop
 * Stopping arango database server arangod                                                                                [ OK ]
 * Waiting for shutdown                                                                                [ OK ]
➜  ~ ps ax | grep arango
17758 pts/0    S+     0:00 tail -F /var/log/arangodb3/arangod.log
17905 ?        Ss     0:00 /usr/sbin/arangod --uid arangodb --gid arangodb --pid-file /var/run/arangodb/arangod.pid --temp.path /var/tmp/arangod --log.foreground-t
ty false --supervisor
17906 ?        Sl     0:02 /usr/sbin/arangod --uid arangodb --gid arangodb --pid-file /var/run/arangodb/arangod.pid --temp.path /var/tmp/arangod --log.foreground-t
ty false --supervisor
➜  ~

I tested with a fresh install of Ubuntu 14.04. It did take a little over 10 minutes to shut down a fresh install. I didn't wait that long earlier.

10 minutes seems way too long, provided the instance was (almost) empty and did not do much when the shutdown occurred. But I can't tell if that was the case. Was that instance doing anything (e.g. serving requests, running queries) when the shutdown happened? And was the Ubuntu it ran on providing enough resources in terms of RAM, CPU and disk I/O?

It was a fresh install on a fresh VM so nothing should have been making requests. It's a default Nitrous.IO VM which has 1GB RAM and 1GB of swap. CPU usage is less than 1%. Arango is the only thing using any significant amount of memory at 28.3%.

Do you happen to know if there was any activity (CPU, swapping, requests) during the shutdown phase?

Occasionally, the arangod process would go up to close to 1% CPU usage from 0% but that was about it from what I could see. If you want, I can give you access to the VM. I'm not planning on using it. I just set it up to verify this problem. You can email me (bassburner at gmail dot com) your email for access via Nitrous.IO or an public key for SSH access if you want.

The reason for the service not stopping was the service arangodb3 stop triggers the command
start-stop-daemon --stop --quiet --oknodo --pidfile $PIDFILE --exec $DAEMON, which does not work on the Nitrous VM.
--exec is for matching executables by (absolute) path name, and $DAEMON in this case is /usr/sbin/arangod, which is correct. Still the command fails because it uses the output of /proc/<pid>/exe, which fails on Nitrous. Seems that Nitrous is blocking access to /proc so start-stop-daemon will never find any executables.
It works on all the local Ubuntus (14.04, 15.x and 16.04) we tested, where accessing /proc is allowed.
A workaround for the problem is to not use the --exec option for matching the processes, but we don't want to change the start/stop script at the moment because we don't know if that would have any side effects.


fixup navigation types

@keybase/react-hackers this is ready. fixes all the ts-ignores on navigationOptions

[ ] change base to master


Fix ica.plot_properties with bad data

When plotting ICA component properties, one of the things that gets plotted is the component PSD. This uses the helper function _convert_psds that performs a check on the presense of zeros in the
PSD. When zeros are detected, a warning is printed. To construct the warning message string, it is assumed that the first dimension of the psds array contains channels. However, in the case of ica.plot_properties, the first dimensions contains epochs. Hence, the construction of the warning message string fails with an index out of bounds error.
This PR adds a flag to the _convert_psds helper function to inform it that the first dimension of the psds array contains epochs rather than channels.

It's extremely rare that this happens. I got some data that triggers this condition, but cannot share it freely.

thx @wmvanvliet


Allow image upload when no name provided

Image uploads no longer require the name field and instead use the entry file name as the default value.

resolves #1080

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


eth: stm32h7: use SRAM3 / MPU configuration

Provides a fix for: #29915
Changes are based on these recommendations.
Notes:

Putting the descriptors in a separate MPU region and configuring them as device memory is what actually fixed the issue. I am not sure why ST recommends using SRAM3, perhaps there are performance reasons but maybe also other potential issues.
The Cortex M linker script should not contain STM32 specific definitions. There should be a more generic way to define the required sections.
Same applies for the static MPU configuration. Ideally both could be done in the device tree as proposed by @Nukersson in the issue.
There is already a PR with another approach: #29944

Thank you very much for this very useful PR.
Now my ideas on it:

@emillindq Already provided solution and test with ST's driver fix. My suggestion here would be push it anyway, cause it does only __DSB() after writing eth descriptors and therefore should not have impact on ethernet throughout or driver performance.

2.@reloZid Very elegant fix from you here! But we can't just change linker scripts every time we need specific memory regions configuration. I think here we need memory reallocation and MPU configuration @possibilities in DT
@gmarull @erwango @galak Now we seems to have proper solution for solide big fix with future improvents for the whole Zephyr project. What do you think? Especially, what do you think about MPU configuration and data regions definition in DT?

Thanks for this draft, will be useful to trigger discussions on how to find a proper fix for this problem and also future similar requirements.
I see some other projects have a sort of MPU API, e.g. https://github.com/u-boot/u-boot/blob/master/arch/arm/mach-stm32/soc.c
In Zephyr I think something similar can be done if using CONFIG_CPU_HAS_CUSTOM_FIXED_SOC_MPU_REGIONS (see NXP k6x/k8x for example) and provide a soc level MPU configuration. In this case, as ST recommends SRAM3 for I/O Ethernet/USB:

SRAM3 could be configured entirely for that purpose at soc level, and just provide DT definitions for sram3 together with linker scripts facilities so that Ethernet buffers can easily be placed there. I'm not sure if that's the best approach, though.
I'm not really familiar with Zephyr MPU implementation, it would be good to have input from maintainers @ioannisg @galak @MaureenHelm @stephanosio @carlocaione

We need a possibility to configure MPU and SRAM sections over DT or KConfig for Zephyr. And then we need a possibility to use configured SRAM sections in our code.

dev-review (Dec 3, 2020):
Suggestion to utilize CONFIG_NOCACHE_MEMORY and look at adding one more section for the SRAM specific case in arch/arm/core/aarch32/cortex_m/mpu/arm_core_mpu.c.
@ioannisg would like to see over time cleaning up of the linker script and mpu tables to move into SoC specific code.

dev-review (Dec 3, 2020):
Suggestion to utilize CONFIG_NOCACHE_MEMORY and look at adding one more section for the SRAM specific case in arch/arm/core/aarch32/cortex_m/mpu/arm_core_mpu.c.

I would prefer not to add half-solutions. We can better define amount of work and split it here, providing proper and solid solution.

@ioannisg would like to see over time cleaning up of the linker script and mpu tables to move into SoC specific code.

dev-review (Dec 3, 2020):
Suggestion to utilize CONFIG_NOCACHE_MEMORY and look at adding one more section for the SRAM specific case in arch/arm/core/aarch32/cortex_m/mpu/arm_core_mpu.c.

I would prefer not to add half-solutions. We can better define amount of work and split it here, providing proper and solid solution.

@ioannisg would like to see over time cleaning up of the linker script and mpu tables to move into SoC specific code.

The idea behind the changes is very good. But we need more scalable solution.

@Nukersson, this point was discussed during dev-review meeting. Of course this proposal lacks scalability. Though w/o alternative proposal we find it acceptable for now with few tweaks.
To define a more scalable alternative we'd need more variety of usage examples. A rework of the whole way to instantiate memory partitions from DT is something we'd like to get, but it has a lot of intrications so it was proposed to postpone post LTS (not before 6 monthes).

The idea behind the changes is very good. But we need more scalable solution.

@Nukersson, this point was discussed during dev-review meeting. Of course this proposal lacks scalability. Though w/o alternative proposal we find it acceptable for now with few tweaks.
To define a more scalable alternative we'd need more variety of usage examples. A rework of the whole way to instantiate memory partitions from DT is something we'd like to get, but it has a lot of intrications so it was proposed to postpone post LTS (not before 6 monthes).

Okay. I understand it. But then we need to plan proper solution within the roadmap for next year or two.

@reloZid it might be interested for you to rebase on top of latest master, following the merge of https://github.com/zephyrproject-rtos/zephyr/pull/30530.
Also, please remove the initial commits, so we only have to review the last version of the proposed solution. This should help in the review process

Rebased and adapted to pass all checks. Please note that I only tested the fix manually using the dumb HTTP server sample on a Nucleo H743. And in general I don't know the MPU well enough to tell whether this solution will work in any case.

As a first step towards specific MPU regions for stm32 LGTM.

As a first step towards specific MPU regions for stm32 LGTM.

@erwango In #29915 it is mentioned, that semaphore timeout bug happens only with CONFIG_DEBUG setting. Thus, I would propose to add here mentioned MPU configuration only for debug compiled project. Otherwise it works fine.
My another opinion is, to ask MPU responsible developers, of such setting is meaningful for all regions in debug mode.

@erwango In #29915 it is mentioned, that semaphore timeout bug happens only with CONFIG_DEBUG setting. Thus, I would propose to add here mentioned MPU configuration only for debug compiled project. Otherwise it works fine.
My another opinion is, to ask MPU responsible developers, of such setting is meaningful for all regions in debug mode.

My another opinion is, to ask MPU responsible developers, of such setting is meaningful for all regions in debug mode.

@ioannisg ?

My another opinion is, to ask MPU responsible developers, of such setting is meaningful for all regions in debug mode.

@ioannisg ?

Did some final cleanups:

Included arm_mpu_mem_cfg.h in mpu_regions.c to avoid duplication
Adapted linker sections to reserve exactly 16K of SRAM3 for our Ethernet buffers (minimum MPU region size we need), such that the remaining 16K are free for other uses
Rebased branch onto master

Please note that I could only test the PR manually using the dumb_http_server sample on an Nucleo H743.

Did some final cleanups:

Included arm_mpu_mem_cfg.h in mpu_regions.c to avoid duplication
Adapted linker sections to reserve exactly 16K of SRAM3 for our Ethernet buffers (minimum MPU region size we need), such that the remaining 16K are free for other uses
Rebased branch onto master

Please note that I could only test the PR manually using the dumb_http_server sample on an Nucleo H743.

@erwango and @ioannisg can you please re-review?

@gmarull are you happy with this as-is?

will take another look asap after 2.5.0 is out

I think that for now it is okay. Only change request: please split changes into multiple commits.
It is clear though that Zephyr needs a better way to define custom MPU regions (e.g. see https://github.com/u-boot/u-boot/blob/master/arch/arm/mach-stm32/soc.c) and so get rid of CPU_HAS_CUSTOM_FIXED_SOC_MPU_REGIONS.

@gmarull Splitted the PR into four commits:

Update device tree files
Define SRAM3 linker section
Add REGION_RAM_NOCACHE_ATTR define
Adapt STM32 ETH driver

@reloZid would you mind rebasing ?

@erwango Sorry for the late reaction. I rebased the changes.

@ioannisg can you have a new look ?


Modified MarkupTokenizer, so that escaped markup inside markup is valid

fixes #903

Yes - it was kind of late yesterday, but I wanted to get the code out, so you could pick on it 😁
I'm not really fond of the nesting either - I had a hard time grasping what was going on. Then again, I was never good at writing parsers. 🤷

I've restructured the MarkupTokenizer a bit so that it's hopefully a bit more readable/understandable.
I let the text of the exceptions basically as they were before this PR - I'll start a PR to make the exceptions all have the "same" punctuation as soon as this one's fine.

Thank you for fixing this! Looking forward to a release :)


A11y: Combobox does not behave correctly on screenreader

Current behavior
As we can see in the screenrecording, Combobox items are always read as "selected" by Apple Voiceover. This is not the case with Select component, where all items are read as "not selected" except for the selected one.
One thing to note, is that "Select with combobox" example also has this bug (refer screenshot)
All in all, it is fair to say that this bug surfaces whenever we use ComboboxItem, with or without Select.
https://github.com/ariakit/ariakit/assets/13308108/2af275e8-56bf-47f7-a293-90c59891b331

Steps to reproduce the bug

Open any combobox example on ariakit docs
Turn on voiceover
try to navigate between items
compare the behaviour with WCAG combobox examples, MUI Autocomplete, etc or with Select of Ariakit itself.

You will notice that in ariakit combobox, all items are read as "Selected".
Expected behavior
Only the selected items should be announced as "selected"
Workaround
https://github.com/ariakit/ariakit/issues/2708#issuecomment-1692000653
Possible solutions
I am happy to work on the solution as it is important for my project, but I have no idea what is wrong because data-active-item and aria-selected properties are being applied correctly, and are same between Select and Combobox. If I am helped with identifying the bug I would be happy to help fix it.
Moreover, I would like to explore if it's a good idea to add https://www.guidepup.dev/ or some other tool to add screenreader testing to the components and avoid regressions

@diegohaz thanks a lot! should I submit a PR to change combobox with select code example to reflect the expected behaviour? Given that the “trigger” there is Select and the combobox in inside the dropdown, I would assume the screenreader behaviour has to match Select UX.

I mean this example https://ariakit.org/examples/select-combobox

@diegohaz thanks a lot! should I submit a PR to change combobox with select code example to reflect the expected behaviour? Given that the “trigger” there is Select and the combobox in inside the dropdown, I would assume the screenreader behaviour has to match Select UX.

Yes, I think that makes sense. Feel free to submit a PR. Thank you!

I mean this example https://ariakit.org/examples/select-combobox

Closing as the example has been fixed.


docs(alert): Usage example - close button and content overlap on mobile

Description
Currently, when view the first Alert example on certain mobile screens the CloseButton overlaps the alert description container, which can be visually broken depending on the text supplied at specific sizes.
At 467px wide screen:

Possible Solution
The CloseButton is separate in it's styling from the Alert so it would still need to be directly positioned. Firstly, remove all the styling given in the current example so the button is back within the flow of the other content. At larger screen sizes, we can leverage the flexbox supplied by the alert container and set marginLeft: auto to keep the button flush to the right from the content, and apply alignSelf: flex-start to keep it in the upper corner.
Also with a minor tweak in total spacing, you would get this:
<Alert status='error' gap={1}>
  <AlertIcon />
  <AlertTitle mr={2}>Your browser is outdated!</AlertTitle>
  <AlertDescription>Your Chakra experience may be degraded.</AlertDescription>
  <CloseButton alignSelf="flex-start" marginLeft="auto"/>
</Alert>

However, if you were to view at the smallest common phone width of 375px you'll see this:

Which isn't much different than how the current example looks at this size.
Was the alert ever meant to be styled like this with this small screen size in mind? With the CloseButton used in other components like Modal or Drawer there isn't this issue because the title text is always vertically stacked with the description or content and the CloseButton is always out of the way.

Hey @TylerAPfledderer, this looks like the Alert component has been following another pattern then others using the CloseButton.  It would be a question for the main repo or you could raise a PR to address responsiveness if you like to :)
For the docs I'd go with your solution, which looks pretty decent and way better than overlapping text.

Thank you @noobinthisgame ! I will work on doing both tasks you suggested. 🤘

@noobinthisgame after reviewing the rest of the docs and taking a look at the stories in the package, it is better to simply remove the close button. From what I would gather, it is not considered "basic usage" to include the close button, but rather in a custom composition as it is already shown in the second composition example.
And in that second example, it would be better to show how the close button should close the alert, rather than be shown as a static component.
It seems to me that Alert was meant to be more customizable than the other notification or feedback components like Modal or Alert Dialog.

@TylerAPfledderer Sounds good to me :)


Development Team Strength

We are planning to use Cyphon in Enterprise environment, before making a call on this would like to know the following.

Can we contribute to active development?
2.How many developers are actually working on this Cyphon project now ?
Is there plan to develop it as a SIEM ?

@jabbarsuku Thank you for your interest in Cyphon.

Yes, we encourage users to contribute to the project.
Cyphon is developed by a small team within Dunbar Cybersecurity.  There are four core team members on the project but many of our other staff members contribute to the platform.
We are about to launch a broader search capability in v1.6 that will provide capabilities closer to that of a typical SIEM.  That said, our goal is not to create yet another SIEM product.  We would appreciate the opportunity to gather your feedback on the current features and new capabilities we should consider for the roadmap.


changed package.json main to be dist/EkoPlayer.min.js

today when publishing to npm, when client uses eko-js-sdk package they are not using the bundled version of the sdk.
we want to change this.

I am not sure about removing src folder from package.json files, but i don׳t see why we need it.

@eyal-avital lgtm, merging.

@eyal-avital lgtm, merging.


bug - H-Rider moves and duplicate values between tables.

It's possible that a modification you make in a certain table would end up in another table.
Scenario:

Edit a row on table A, don't click save.
Choose a different table (table B) from the list and edit a row there, to make the save button enabled
Click save - the row you edited in table A would be inserted into table B

The reason is that the changes tracker is not cleared when moving from table to table

fixed


Split packaging job

The packaging step should be split so that each artifact that's packaged can be packaged and verified in isolation. This will allow us to upload artifacts that have passed verification and skip those that fail. This will then allow us to speed up successive rebuilds by skipping repackaging and reverifying artifacts that have previously succeeded.

@kminehart mentioned that if we move this to GitHub Actions it allows us to restart from the failed jobs.


[Feature Request] - Protect Recovery with the PIN

Description
Allow recovery with the secret PIN

This doesn't make sense tbh. If someone forgets their pin to make withdrawals, he needs to reset the app, but how can they, if they has lost their pin?

We can implement a modal instead


Fixes relative custom imports & empty plugins

Description
Given that the changes are fairly small I didn't open an issue; I believe seeing the proposed changes may be easier to understand. There are currently two small fixes I encountered while developing a third-party tool using this project. I've put a comment under each one if you wish to discuss them separately.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Made the changes in the graphql-codegen code within my project, and things worked instead of crashing.
Checklist:

[x] I have followed the CONTRIBUTING doc and the style guidelines of this project
[x] I have performed a self-review of my own code
n/a I have commented my code, particularly in hard-to-understand areas
n/a I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
n/a Any dependent changes have been merged and published in downstream modules

Hi @arcanis ! Thank you for this PR.
@n1ru4l was doing the same thing (in order to support the gql-tag) plugin, so I think we can close it :) See the conflicts, it's actually the same change.
This will be available in upcoming release.

@arcanis I did not see this before, sorry! We now added this preset: https://github.com/dotansimha/graphql-code-generator/tree/master/packages/presets/gql-tag-operations
I know on Twitter you mentioned wanting to have global unique operations and we would appreciate it if you could contribute that by porting it over from your preset/plugin as an opt-in feature (I guess most people will still prefer global unique operation/fragment names)! We fixed some upstream issues with gql-tag-loader that make the API easier to use! See https://github.com/dotansimha/graphql-code-generator/tree/master/dev-test/gql-tag-operations for a code example and https://github.com/dotansimha/graphql-code-generator/blob/3f98977499f4ab014a89deae3b19e669d0e0e103/dev-test/codegen.yml#L391-L394 on the config.

No worry, it's absolutely the best case scenario for me! Thanks for being super-reactive and tackling that! I'll look at contributing extra optional features to the new preset, although I'm a little bit worried that some features I've implemented are perhaps a bit too specialized to my use case (for instance I made it so the id field is always fetched, even if missing from the query). I don't want to bother you if you don't think these would be the right direction for the project!


What design pattern have you followed when starting with this repo?

Hi, I would love to know what kind of design pattern(s) are being followed, or were taken into account when starting with this repository.
Thanks

Hi @omerihtizaz, if you are looking to start with Evidently, here are the two QuickStart tutorials:

Get Started with Tests and Reports https://docs.evidentlyai.com/get-started/tutorial
Get Started with ML monitoring https://docs.evidentlyai.com/get-started/tutorial-monitoring

If you are looking for deployment patterns, you can browse the integrations folder: https://github.com/evidentlyai/evidently/tree/main/examples/integrations

Hello @elenasamuylova ,
I think he is asking more specific to SOILD design principles: https://www.freecodecamp.org/news/solid-design-principles-in-software-development/

Hello @elenasamuylova.
I think @ketangangal is correct, I am looking more specifically to ask around which SOLID design principles did you guys follow when starting with the development of Evidently.
Thanks.


Missing loading style on Button component

Describe the bug
Missing loading style on Button component
To Reproduce
Steps to reproduce the behaviour:

Go to Docs
See error

Expected behaviour
Button has loading style.
Screenshots

Platform

NativeBase version [3.2.0]
Expo sdk version [42]

Additional information
https://github.com/GeekyAnts/NativeBase/blob/723ea5f8aef976c236324684a678e1cae00ad6a3/src/hooks/useThemeProps/propsFlattener.tsx#L35-L37
Maybe is missing isLoading state there.
Unable to get the full props from the theme variants function since v3.2 ...

Thanks @ZHANGYU-AAXIS  for reporting it. We'll fix it int he upcoming patch.


Add experiences to template block

In Visual Studio insert our template from the task to index.html file inside the

 block
git add index.html
git commit -m "Added experiences to template block"
git push origin patch/content/secondary


pkeyutl cannot access keys (private or public) on pkcs11 tokens

Symptoms:
$ openssl version
OpenSSL 1.0.2e 3 Dec 2015
$ openssl pkeyutl -engine pkcs11 -keyform engine -sign -inkey "pkcs11:object=SIGN%20key;object-type=private" -pkeyopt digest:sha384 -out t384.dat.sig -in t384.dat
engine "pkcs11" set.
PKCS#11 token PIN:
Error initializing context
140735278175056:error:260C0065:engine routines:ENGINE_get_pkey_meth:unimplemented public key method:tb_pkmeth.c:128:
140735278175056:error:0609D09C:digital envelope routines:INT_CTX_NEW:unsupported algorithm:pmeth_lib.c:164:
Usage: pkeyutl [options]
-in file        input file
.........

When signature is created by a fixed version of openssl, pkeyutl still fails to access public key:
$ openssl pkeyutl -engine pkcs11 -keyform engine -verify -pubin -inkey "pkcs11:object=SIGN%20pubkey;object-type=public" -sigfile t384.dat.sig -pkeyopt digest:sha384 -in t384.dat
engine "pkcs11" set.
Error initializing context
140735278175056:error:260C0065:engine routines:ENGINE_get_pkey_meth:unimplemented public key method:tb_pkmeth.c:128:
140735278175056:error:0609D09C:digital envelope routines:INT_CTX_NEW:unsupported algorithm:pmeth_lib.c:164:
Usage: pkeyutl [options]
-in file        input file
.........

This issue has been discussed on the openssl-dev mailing list, and Steve Henson suggested a solution<EMAIL_ADDRESS>PR to fix this problem (addressing Steve Henson's concern that this fix should not interfere with other engines<EMAIL_ADDRESS>submitted: https://github.com/openssl/openssl/pull/520
After applying the above fix, the application behaves correctly:
openssl pkeyutl -engine pkcs11 -keyform engine -sign -inkey "pkcs11:object=SIGN%20key;object-type=private" -pkeyopt digest:sha384 -out t384.dat.sig -in t384.dat
engine "pkcs11" set.
PKCS#11 token PIN:
$ dumpasn1 t384.dat.sig
  0 102: SEQUENCE {
  2  49:   INTEGER
       :     00 8B FB 6D 0B E0 1A 29 4F 40 D9 95 74 A2 86 A4
       :     9C FB 77 17 35 FC 65 80 E7 1B E8 04 DB 91 DD CE
       :     1B FE 30 6D 3B 48 59 3D 10 9C 03 CC 70 B6 D8 22
       :     B9
 53  49:   INTEGER
       :     00 8F EB CE 89 1A 0C 12 EF 42 E4 C3 A4 12 D2 01
       :     E4 5F B5 98 EE 41 E1 BA 19 D8 73 69 BB 52 56 87
       :     72 C4 2B 83 5E 4B A9 BE 49 AE 17 EA B0 F9 28 34
       :     30
       :   }

0 warnings, 0 errors.
$ openssl pkeyutl -engine pkcs11 -keyform engine -verify -pubin -inkey "pkcs11:object=SIGN%20pubkey;object-type=public" -sigfile t384.dat.sig -pkeyopt digest:sha384 -in t384.dat
engine "pkcs11" set.
Signature Verified Successfully
$

P.S. The proposed PR also addresses an issue of NULL-pointer access during engine destroy operation.

My concern with the change that #520 offers is the risk of it becoming permanent.  Steve calls the fix a temporary measure in the message you point at.  That's the reason I'm reluctant.
However, in discussing this privately with Steve, he reminded me of the solution in openssl dgst in master, where the engine is only used for loading keys unless you add the option -engine_impl.  I think that would be a cleaner solution that leaves the decision in the hands of the user.
So in essence, I would welcome a solution where the engine parameter to EVP_PKEY_CTX_new is NULL by default.

As I understand it, Steve was concerned of making this fix permanent because he thought that sometimes people may want/need the "old" behavior (passing e rather than NULL).
As I'm observing, there is no way the code can work with pkcs11 engine, unless the engine parameter is NULL, so I think it is safe to always pass NULL if keyform = engine (or peerform = engine), and engine is pkcs11. I admit that I don't know what other engines there are, and whether they'd benefit from the same fix or break on it.
I also don't know (not enough expertise with the internals of openssl) when you do want/need to pass the engine parameter.
This is why I restricted the proposed fix to the case when both are true: (a) the key is on the token (so the engine should access it), and (b) the engine is pkcs11 (as I know that it needs this fix for sure).

I would welcome a solution where the engine parameter to EVP_PKEY_CTX_new is NULL by default.

I can certainly change my proposed fix to do that. But could you clarify: do you want to preserve the option of passing e, and what would be the condition for passing a non-NULL engine parameter? An extra explicit command-line argument -engine_impl? Or when neither keyform nor peerform parameter is provided? I admit being a bit confused here.

My thought is that without -engine_impl, EVP_PKEY_CTX_new would get NULL, with that option, it would get e.
(have a look at dgst.c, see how it does it)

OK, now I understand what what you're asking for. Let me work on that. I hope somebody else would update the documentation (once this PR is submitted and merged).

Submitted https://github.com/openssl/openssl/pull/523.

@levitte any update on the merge? Is anything blocking it now?

@levitte could I ask to merge this one rather sooner than later? Thanks!

Thanks!

I am getting the same error. Would be nice if an example for -engine_impl could be added to the documentation or manpages

Now that OpenSSL v3+ deprecates the engine API altogether. So, you're better off switching to provider API.


Add Grout into 2 seared bricks in kiln

I was thinking that I could add all the furnace recipes to the kiln, and take advantage of the smelter for doubling non-ore common materials. For the moment, though, the doubling is in for the kiln.


[COMPRESS-535] maybe we can add a break here

Hi.
Can we add a break here?
Also, should we try implement a data structure or something for doing this? a loop like this sounds slow.
If you don't mind I will give it a try several hours later (if I still have some time).

Coverage increased (+0.04%) to 87.325% when pulling 204faf58f69386d1b6f8d0410dcf2667d6d08051 on XenoAmess:should_we_add_break_here into f333bc647c860375cc4e9999da10b2c3c8d4d57f on apache:master.

@XenoAmess you don't need to create a JIRA ticket for every PR. I appreciate JIRA for bigger changes, but for a single break, I'm not sure. Oh, and please add a bit more context to the PR's titles :-)
The bzip2 code has been hand optimized with an unrolled loop years ago. It is quite possible this is no longer necessary and the JIT has become smart enough to do things "right". In either case I would not go near changing the implementation without a decent performance test that proves the changed code is at least as fast as the old one used to be. For many of our users speed is more important than elegance.

oh, and thank you, of course

In either case I would not go near changing the implementation without a decent performance test that proves the changed code is at least as fast as the old one used to be.

OK, I will find some time to do the test.
I will also try build a data structure for this question, and test performance for it too.
And, maybe we should not merge this pr until the test result comes?

too late, I've already merged this one :-)
It is very much possible javac has become better in the fifteen years or so since the code has been written. A while ago I started https://github.com/bodewig/commons-compress-benchmarks as a limited JMH based setup to see how things changed over time. It might be a starting point - or not.


Standardise the environment name format

Describe the bug
The environment name is required in different formats for different commands.
To Reproduce
Steps to reproduce the behavior:

Let us say we have feature/abc environment.
To SSH to the environment, you would use lagoon ssh -p project-name -e feature-abc
However, if you want to delete the environment, you will need to use feature/abc:
lagoon delete environment -p project-name -e feature/abc.
If you use feature-abc, you will get Environment "feature-abc" does not exist error.

Expected behavior
I would expect the same format to be used for all commands or at least the expected format should be documented.

This should be an easy fix. SSH is the only command where this is different, I think we just need to execute a get environment command to get the openshiftProjectName for the environment.

@shreddedbacon
this "inconsistency" been a huge pain for a day-to-day environment management. Any chance this can be prioritised please?

in reality, seen how lagooncli is used by devs, it would be cool to support both normal and safe branch names for all commands, so devs would not have to guess which format it is.

Just merged #237 and will release soon, but it adds support for using the normal branch name as the environment name when using SSH commands. This brings it in line with other commands.
Unfortunately, the work to be able to support the "safe" branch name in other commands is not very easy, so the decision was made to just bring SSH in line.


Unable to launch player from recyclerView

I am launching AudioWife when user click on item, when i click on item nothing happens just recyclerview stops scrolling for a while.
I am doing like this in onBindViewHolder:
AudioWife.getInstance().init(context, Uri.parse(consersation.getListMessageData().get(position).text))
.useDefaultUi(mPlayerContainer, getLayoutInflater());
Please help me to resolve this issue.....

just copy all the elements from ax_player.xml to your recycler view item xml.
then find each of them by id like other elements in your ViewHolder.
then set each of them for the AudioWife in the onBindViewHolder() like this:
AudioWife audioWife = new AudioWife();
        myAudioWife.init(context, uri)
                .setPlayView(holder.mPlayerPlayBtn)
                .setPauseView(holder.mPlayerPauseBtn)
                .setSeekBar(holder.mPlayerSeekBar)
                .setTotalTimeView(holder.mTotalTimeTextView);

That worked well! This is a nice library, it shouln't be broken as it is right now


Basic Nix compatibility

This PR extracts 2 changes from https://github.com/helsing-ai/buffrs/pull/172 that should be safe but should help in making Buffrs compatible with Nix.

So as far as I understand your issue originates from buffrs home being non-existent in the nix world?

What's going on with typos?

Thanks @BlowaXD!


Cap.deviceList() Permissions error

Hello - I am trying to run this in a Lambda Container Image (followed the instructions here: https://docs.aws.amazon.com/lambda/latest/dg/images-create.html#images-create-from-base)
When I run locally, there are no issues. However upon pushing to Lambda and calling deviceList() I get the following error:
Can't open raw Bluetooth socket: Operation not permitted

And I also get a similar message when attempting to call open()
I know this is not caused by your library, just wondering if you had any ideas of how I can debug this? e.g can I put libpcap in verbose mode to see which exact operation it is trying to run? thanks!

The libpcap APIs used in cap require CAP_NET_ADMIN and similar OS capabilities, which I doubt Amazon gives to Lambda users.
If you're able to find other instances of libpcap working on Lambda, I would be interested in seeing how those are accomplished. But until then, you're probably out of luck.

Thanks @mscdex I'll keep digging. I've just discovered Lambda uses Firecracker microVMs so I'll play around with that locally to reproduce & hopefully fix the issue. Will let you know if I find anything
The other option for me is to capture packets on a NAT instance, but I've no clue how to correlate packets with their originating Lambda invocation / request ID. If you have any thoughts on this also would appreciate it, thanks again :)


fix: remove failing and unused repository

I don't think it hurts to have it here per se, but it can't be used so can as well be removed.
The repo gives
Error: looks like "https://kubernetes-charts.banzaicloud.com" is not a valid chart repository or cannot be reached: Get "https://kubernetes-charts.banzaicloud.com/index.yaml": x509: certificate has expired or is not yet valid: current time 2022-12-19T08:18:17Z is after 2022-12-19T07:42:55Z

/cc ankitm123 tomhobson babadofar

/retest


After upgrading master, deleted host do not get removed from provider

Version - master 3/22
Steps:

Update master version
Delete DO host (or any host)
Go to DO (to provider website)

Results: The host still exist on the provider side.
Expected: Host should be removed.
Comments from Craig: basically, if you end up moving from gms container A to gms container B, when you go to delete a machine, it will get deleted in rancher but will not get deleted in the cloud provider

totes fixed.

Version - master 3/23
Verified fixed


Only ship the required version of leptonica-1.82.0.dll and tesseract50.dll

Right now, both the x86 and x64 versions are package with all builds.
This add about 2 megs of unneeded binaries to our package files

@glahaye - What's the total size of the package file?

@crickman Around 68 megs.  This change would shave off about 2.  Not the highest priority, but nice to have.

Turns out the nuget package is dynamically including these assets and its problematic to try and exclude them form the project file for two reasons:

Pathing (outside of repo)
Exclusion ignored in anycase

  <ItemGroup>
    <None Remove="C:\Users\crickman\.nuget\packages\tesseract\5.2.0\build\\..\x86\leptonica-1.82.0.dll" />
    <None Remove="C:\Users\crickman\.nuget\packages\tesseract\5.2.0\build\\..\x86\tesseract50.dll" />
  </ItemGroup>

It is possible to exclude assets, but not selectively:
    <PackageReference Include="Tesseract" Version="5.2.0">
      <IncludeAssets>none</IncludeAssets>
    </PackageReference>


Integration with SwiftUI app

is this possible?
Right now I pulled in the files into my SwiftUIapp and I made the LiveChatOverlayController conform to UIViewControllerRepresentable and I also set the LiveChat.windowScene in my Scene Delegate. The view actually loads but it's indefinitely on the spinning loading view. Any way to get this to work?
    func scene(_ scene: UIScene, willConnectTo session: UISceneSession, options connectionOptions: UIScene.ConnectionOptions) {
        // Use this method to optionally configure and attach the UIWindow `window` to the provided UIWindowScene `scene`.
        // If using a storyboard, the `window` property will automatically be initialized and attached to the scene.
        // This delegate does not imply the connecting scene or session are new (see `application:configurationForConnectingSceneSession` instead).

        // Create the SwiftUI view that provides the window contents.
        let mainView = MainView()
        let loginView = LoginView()

        // Use a UIHostingController as window root view controller.
        if let windowScene = scene as? UIWindowScene {
            LiveChat.windowScene = windowScene
            let window = UIWindow(windowScene: windowScene)
            if UserDefaults.standard.string(forKey: "eventId") != nil {
            window.rootViewController = UIHostingController(rootView: mainView)
            }
            else {
                window.rootViewController = UIHostingController(rootView: loginView)
            }
            self.window = window

            window.makeKeyAndVisible()
        }
    }

extension LiveChatOverlayViewController: UIViewControllerRepresentable {
    public typealias UIViewControllerType = LiveChatOverlayViewController

    public func makeUIViewController(context: UIViewControllerRepresentableContext<LiveChatOverlayViewController>) -> LiveChatOverlayViewController {
        return LiveChatOverlayViewController()
    }

    public func updateUIViewController(_ uiViewController: LiveChatOverlayViewController, context: UIViewControllerRepresentableContext<LiveChatOverlayViewController>) {
        //
    }

}

issue was caused by missing license id. fixed.


Got double free or corruption (!prev), when exit.

Qt bug?

It's Qt bug, also affected Qt 5.3.x.
Also seams to Qt 5 have problems with png in Debian, so it's Qt 5 bug, cuz' with Qt 4 all normal.

Figure it out, it's my fault btw. Lack of C++ experience. But new GCC is nice, yeah. I just got full memory dump, when double free happens.


Basic PHP 8 support

Added usage verification of GD image source as GdImage class instance. Ref issue #64

@MatTheCat could you perhaps review this at your earliest convenience? :smiley:

Hey it's been a long time since I came on this repository..!
I believe instanceof does not trigger any error if you test against an undefined class so it would make the condition simpler. 🤔

Hello!
I use simple code for extracting colors from GD resource:
$palette = Palette::fromGD($image);
$colors = $palette->getMostUsedColors($count);

But php 8 throws exception - Image must be a gd resource.
I've add check for instanceof \GdImage, if current php version is 8.0 or higher in my pull request - #67
if (PHP_VERSION_ID >= 80000) {
            if (!(is_resource($image) || $image instanceof \GdImage)) {
                throw new \InvalidArgumentException('Image must be a gd resource');
            }
        } else {
            if (!is_resource($image) || get_resource_type($image) != 'gd') {
                throw new \InvalidArgumentException('Image must be a gd resource');
            }
        }

This code helped me. I tested on php 7.4, this also works fine. I think this might be useful.)

Couldn't you just write
if (!$image instanceof \GDImage && (!is_resource($image) || 'gd' !== get_resource_type($image))) {
    throw...
}

?

Yes, it works, thank you! It's much simplier solution.
if (!$image instanceof \GDImage && (!is_resource($image) || 'gd' !== get_resource_type($image)))
                throw new \InvalidArgumentException('Image must be a gd resource');
            }

Can I add this code into my pull?

Yes go ahead 🙂
Maybe the error message could be changed based on PHP version though?

Maybe, but now it's working fine, thanks))
I made pull request #68

Closing this in favor of #74 since that also comes with working tests to verify the fix.  Appreciate the help here, though!


Selective Feature reduction via cross modal query

How does the model understand which tokens to get rid of for a question like “Describe this video in detail”.
Also what sort of an inpact does an instruction like “Select the best option among (A,B,C,D)” or any other intruction sent along with the question have on this part.

Hi, @insafim
Thanks for raising this concern.
(i) The query dependent token compression is designed for VQA task, which is not effective to question such as "Describe this video in detail". However, the irrelevant frames will not be removed, but reduce to low resolution tokens.
(ii) The impact of candidates options is minimum, but you can also use add special token as a placeholder to identify the question-only tokens and remove the other instruction.


Automate Docker build

So far, the sourcegraph/lsif-java docker container has been manually pushed to Docker Hub. We should automate this step so that a new container is updated on every lsif-java release.

Fixed in #372. Going forward, the Docker container should always be in sync with the latest release of lsif-java on Maven Central.


Enable multi-line entries for string match questions

Pull Request Check List

[ ] Unit Tests & Regression Tests Added (Optional)
[x] Removed Unnecessary Logs/System.Outs/Comments/TODOs
[ ] Peer-Reviewed

Remind me to fix this tomorrow.
Il lun 25 mar 2019, 16:56 James Sharkey<EMAIL_ADDRESS>ha
scritto:

@jsharkey13 requested changes on this pull request.
There's some weird mix of indentations in this file, and the two lines
you've added don't line up :(
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/ucam-cl-dtg/isaac-app/pull/1019#pullrequestreview-218459451,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZHc7mru9_SkVRgpNdLw95nZ-PstFpTks5vaP_XgaJpZM4cHW3e
.


Analysis Server hangs when asking for refactoring

Reproducible with both SDKs 1.13 and 1.14-dev.4.0. Using Windows 8.1, didn't try on Mac/Linux
Simple single-file project:
void main() {
  print("foo");
}

Place caret inside "foo" string, no selection, try to introduce variable. Server gets stuck. No errors in instrumentation-log-file. The last line in log is pasted below, after that server doesn't accept any requests and doesn't send any responses.
Req:{"id"::"10","method"::"edit.getRefactoring","params"::{"kind"::"EXTRACT_LOCAL_VARIABLE","file"::"C::\\dart_projects\\untitled1\\bin\\main.dart","offset"::24,"length"::0,"validateOnly"::true,"options"::{"name"::"name","extractAll"::true}},"clientRequestTime"::1450115425016}

https://codereview.chromium.org/1522193002

https://github.com/dart-lang/sdk/commit/b44ed3e91e208f4066417b7d37bfc7905cc1edf4


dpo qwen2-72b oom，9*8 A800 80G需要怎么设置？

Reminder

[X] I have read the README and searched the existing issues.

System Info
model
model_name_or_path: /mnt/nas/shanzhi/eval_models/Qwen2-7B
model_name_or_path: /mnt/nas/liyadong/sft_models/checkpoint-3945
enable_liger_kernel: true
use_unsloth_gc: true
method
stage: dpo
do_train: true
finetuning_type: full
pref_beta: 0.01
dpo_label_smoothing: 0.05
pref_loss: sigmoid  # choices: [sigmoid (dpo), orpo, simpo]
optim: paged_adamw_32bit
dataset
dataset: ultrafeedback_binarized_train_dpo,multilingual_ultrafeedback_binarized_train_dpo
template: qwen
cutoff_len: 11008
packing: true
max_samples: 1000
overwrite_cache: true
preprocessing_num_workers: 128
output
output_dir: /mnt/nas/liyadong/sft_models/qwen2_72b_dpo_ct_sft_dpo
logging_steps: 10
save_steps: 500
plot_loss: true
overwrite_output_dir: true
train
per_device_train_batch_size: 1
gradient_accumulation_steps: 1
learning_rate: 5.0e-7
num_train_epochs: 3.0
lr_scheduler_type: cosine
warmup_ratio: 0.03
flash_attn: fa2
bf16: true
repetition_penalty: 1.2
neftune_noise_alpha: 5
ddp
deepspeed: examples/deepspeed/ds_z3_config.json
ddp_timeout: 180000000
eval
val_size: 0.1
per_device_eval_batch_size: 1
eval_strategy: steps
eval_steps: 500
Reproduction
torch.OutOfMemoryError: CUDA out of memory. Tried to allocate 8.76 GiB. GPU 6 has a total capacity of 79.35 GiB of which 2.19 MiB is free. Process 1438 has 78.69 GiB memory in use. Of the allocated memory 59.53 GiB is allocated by PyTorch, and 17.67 GiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting PYTORCH_CUDA_ALLOC_CONF=expandable_segments:True to avoid fragmentation.  See documentation for Memory Management  (https://pytorch.org/docs/stable/notes/cuda.html#environment-variables)
Expected behavior
已经开了paged_adamw_32bit，use_unsloth_gc，enable_liger_kernel 而且bs也设置到最小了
Others
No response

试一下 zero3 offload


On windows b2 --help prints wrong text.

On Windows, b2 --help says:
  --prefix=<PREFIX>       Install architecture independent files here.
                          Default: C:\Boost on Windows
                          Default: /usr/local on Unix, Linux, etc.

But if the user calls b2 install, only C:\Boost\include will be installed. The libraries will not be installed into C:\Boost\lib.
Only by calling b2 --prefix=C:\Boost install will both headers and libraries be installed correctly.

The help text is actually correct, it just has been broken for the last few releases.


Polish scraping

[x] add argparse to scrape_negative and offer option to specify number of articles analogous to scrape_positive

[x] scraping with narticles = 0 doesn't terminate in scrape_positive
[x] provide default narticles > 0

[x] print progress updates (positive & negative)
[x] clean / filter data before insertion into positive database

the paragraph \_ has recently appeared in the database, this leads to no words being left after normalization and a topic vector with components nan (nan > 1 → will be the text matcher's favorite text to match)
"copyright", "published on date x", etc paragraphs are undesired

The problem with narticles = 0 comes from the lambda we are using to gather the urls from google news. I think I saw a better way to solve this by using the generator pattern, but I solved it with a quick if block atm.


Execution Workflow: mountainClimber

WHAT
Write execution workflow for mountainClimber. Use the provided small files for testing (running the workflow on real data is a different issue).
CHECKLIST

[ ] Use snakemake template or nextflow template to create your workflow.
[ ] Comment your code
[ ] Run individual rules/processes in either conda envs or docker/singularity containers for reproducibility
[ ] Input:  .bam or .fastq from test_data
[ ] Give feedback about the method

OUTPUTS (see specification):

[ ] Output: Adhere to output specification for Identification challenge

This BED file contains single-nucleotide position of poly(A) sites identified by the tool.
Fields:

chrom - the name of the chromosome
chromStart - the starting position of the feature in the chromosome
chromEnd - the ending position of the feature in the chromosome; as identified PAS are single-nucleotide, the ending position is the same as starting position
name - defines the name of the identified poly(A) site
score - not used, leave as "."
strand - defines the strand; either "." (=no strand) or "+" or "-".

[ ] Output: Adhere to output specification for quantification challenge

This BED file contains positions of unique poly(A) sites with TPM values for each identified site in the score column.

chrom - the name of the chromosome
chromStart - the starting position of the feature in the chromosome
chromEnd - the ending position of the feature in the chromosome; as identified PAS are single-nucleotide, the ending position is the same as starting position
name - defines the name of the identified poly(A) site
score - TPM value for the identified site
strand - defines the strand; either "." (=no strand) or "+" or "-".

[ ] Output: Adhere to output specification for differential usage challenge

This TSV file contains two columns:

gene ID
significance of differential PAS usage

Column names should not be added to the file.

Closed because:
Installation issues

There were just a bunch of Python scripts in a GitHub directory, and a list of required packages from which at least one package was missing (matplotlib). There could be more missing dependencies, only verified functionality by running --help on each script. Also requires Cython, which was not documented.
Additional minor issues:

Scripts use a very unusual shebang, probably a typo and copy/paste artefact: #!/user/bin/python
Scripts are built with Python2, which reached end of life (Jan 1, 2020) almost at the time the paper was published (Sep 18, 2019)
No convenient packaging options available: tool not on Conda & I didn't find a container image

Testing issues

Test data and a relatively detailed tutorial is available describing a workflow how the 10 or so different tools should be run (together with others like STAR, RSEM, BEDTools). IMO the entire method should have been published as a workflow. Didn't try it out yet, so can'tsay exactly how accurate they are. However, I've already found at least one or two things that are ambiguous/unclear. Also, there are 4 issues in the repo, all by users trying to make the tutorial work but facing problems. No reply from the maintainers.

Execution issues

I didn't really try yet as it needs a lot of preparation (run STAR with very specific parameters, run BEDTools etc). It should be possible to get there, eventually, but will take a lot of work.

Misc issues

There's also an issue tracker with 4 open and no closed issues. Maintainers have never replied to any of the questions raised by the community. There's a correspondence email in the paper (as usual). But given the fact that the code repo appears unmaintained and the main developer appears to have left the field, I wouldn't count on getting any help on this anywhere.

Verdict
Bad user experience. Basically, if you want to use mountainClimber, you will first need to build an entire workflow (~15 steps or more) around it. Not sure how many people actually tried that. There are 2 citations, but didn't check if authors just mentioned or actually ran it. 4 open questions on the issue tracker, with no closed issues, no replies from authors or the community lead me to think that few people, if any, actually ever ran this apart from the authors.

If we ever decide to re-open, there's a draft PR at #86, which contains a Dockerfile that (IIRC) packages all of the custom scripts. What's left to do is to write a ~15 step workflow (custom scripts + STAR, RSEM etc.) along the lines of the docs available on the method's GitHub page.


Support for comparing numeric collection types other than int

Hi! First of all, I would like to say a thank you for this awesome library and effort you have put into it.
I have a case where in your test cases, let's say Ingredient class has a new property
public long MinimumQuantity { get; private set; }

Then the following test should succeed
[Fact]
public void can_filter_within_collection_long()
{
    var minQuantityLong = 2L;
    var fakeRecipeOne = new FakeRecipeBuilder().Build();
    fakeRecipeOne.AddIngredient(Ingredient.Create(new IngredientForCreation(){MinimumQuantity =  minQuantityLong}));
    var input = $"Ingredients.MinimumQuantity == {minQuantityLong}";
    var config = new QueryKitConfiguration(settings =>
    {
        settings.Property<Recipe>(x => x.Ingredients.Select(y => y.MinimumQuantity)).PreventSort();
    });
    var filterExpression = FilterParser.ParseFilter<Recipe>(input, config);

    filterExpression.Compile().Invoke(fakeRecipeOne).Should().BeTrue();
}

But it fails with the following exception
The binary operator Equal is not defined for the types 'System.Int64' and 'System.Int32'.

From my understanding in this line, you try to parse int, but you ignore type compatibility.
https://github.com/pdevito3/QueryKit/blob/245ad0d8822d68a68e42ce0cdbe112347c683dfd/QueryKit/FilterParser.cs#L177-L177
A check of the generic type param of the enumerable should be made in order to convert the according constant values to the equivalent type (in our case long instead of int)
I tried the following code to replace that if statement but I have some failing tests
if (targetType.GetGenericArguments().All(arg => arg != typeof(string)))
{
    var propertyType = targetType.GetGenericArguments()[0];
    var converter = TypeDescriptor.GetConverter(propertyType);
    if (converter.CanConvertFrom(typeof(string)))
    {
        var propertyValue = converter.ConvertFromInvariantString(right);
        return Expression.Constant(propertyValue, propertyType);
    }
}

I would appreciate your help in here!
Thanks again!

👋 thanks for the effort and callout here! Yeah this should be doable but not sure exactly what the issue is without digging into it a bit. This looks like the right area are first glance though. Might just need some finer tweaks to make the rest of the flow happy.


overline does not show up for chtml output

Issue Summary
Using<EMAIL_ADDRESS>(using chrome 91 on linux), "\overline" will just no show up (there is no line).
See https://www.jirka.org/badmj.html
However, moving to<EMAIL_ADDRESS>fixes the problem
Steps to Reproduce:

Use tex-chtml.js
Add (\overline{A})
See A without an overline.
Switch to tex-svg.js
See A with an overline.

Technical details:

MathJax Version: 3.1.4
Client OS: Linux PopOS 20.10
Browser: Chrome 91.0.4472.77

Supporting information:

Example: https://www.jirka.org/badmj.html
No errors on the console

I'm not able to reproduce the issue (In MacOS with the same Chrome version).  The line is there, though a bit thin.  Does it change if you zoom the window?
Also, try adding
mjx-stretchy-h.mjx-c2013 mjx-ext mjx-c::before {
  padding-top: .3em ! important
}

to the CSS for the page and see if that helps.

For me on MacOS with Chrome 91, the line on jiri's example disappears at zoom levels 75%, 50%, and 25%. However at 100%, it is present.

Confirming zoom levels from 30% to 300% all show an overline just fine in Firefox 88.0.1 on Ubuntu 20.04, using a test example of my own creation.

@Alex-Jordan, thanks for checking this out.  Were your results with our without the extra CSS that I suggested?
@jirilebl, if you change the CSS to
mjx-stretchy-h.mjx-c2013 mjx-ext mjx-c::before {
  padding-top: .5em ! important;
  color: red;
}

Does that help?  I've added color so that you can tell if the CSS is actually being applied (when you zoom to where it is visible).

I wonder if it is just getting cut off, that is, chrome might be cropping

Yes, that is certainly what is happening.  The character is in the DOM, but Chrome is clipping it.
@rbeezer, thanks for checking Firefox.  I'm pretty sure it is a Chrome issue (with round off; historically Chrome has had a lot of these).  With a thin horizontal line, if it is positioned slightly off vertically, it can fall outside the bounding box that MathJax has set up for it.  Although MathJax doesn't request clipping, it seems that that might be happening anyway.

@dpvc I was just looking at Jiri's example as it was. So I think without the added CSS.

interestingly, adding the color: red does not seem to have any effect.

You have left out the semicolon after "important", so the two rules run together and neither take effect.  When I save your page locally and add the semicolon, I get the overline in red, and visible at all zoom levels.

Doh! :)
OK, so the effect is that the bar, when visible, is red, but otherwise still not visible at 100% zoom.

otherwise still not visible at 100% zoom

Did you try with .5em instead of .3em?  That is large enough that if it is going to show, it should do so.  If that doesn't work try 1em just to be absolutely sure.

Also, can you try turning off hardware acceleration and see if that helps? (Search for "acceleration" in the preferences panel.)

Making it 0.5em does make it show up even at 100%.  Turning off acceleration doesn't seem to change anything.

Thanks for checking; I appreciate the additional information.  I will consider what the best course is to resolve the problem.

@jirilebl, here's something else to try.  Can you peplace the CSS that I suggested above with
mjx-stretchy-h > mjx-ext {
  overflow: clip visible ! important;
}

and see if that helps?

Doesn't help.

@jirilebl, note that the selector has changed.  You have left the old selector, which won't help, as you say.  You need to check the whole selector.  Can you give that another try?  (Sorry to keep pestering you about it.)

Ahhh!  Sorry about that, should have just cut and pasted the whole thing.  I just did it quickly while waiting for my student on a zoom call :)
Anyway.  Yay!  It works.  With that added I see the bar correctly and consistently in all zoom levels.

@jirilebl, thanks for the confirmation.  I think that is the solution I will go with.

This is still an issue in MathJax 3.2.0:

on Firefox in Windows 10 v20H2 and v21H1, underline and overline not visible at 90% or 120%;
on Firefox on Ubuntu 21.10, underline and overline not visible at 80%, 100% (but visible at 110+%)

Is there by chance any update on this issue?
I can confirm that for MathJax 3.2.0 and FF98 on debian unstable the overline is not visible at 60%, 80%, 100%

@CCXXXI, This will break lots of other stretchy characters, like over- and under-braces, for example.  I would not recommend doing that.

@dpvc Is there a CSS selector that selects only \overline?

Yes, mjx-stretchy-h.mjx-c2013 will get you just the various over- and underlines, but note that adding a border will change the height of the result, and so that may throw off MathJax's layout in other ways.  Plus the fact that when the usual overline does show, this will make for an extra thick overline.  I would be cautious about doing this.


What if conflict with AAD settings

Hi,
since this was announced for roll out in the message center (ID: MC218561).
I was wondering what happens if the AAD settings for consent is in conflict with the settings in MS teams. Who rules over the other?
might there be a risk that this is disabled in AAD but allowed in MS teams?
Regards,

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11c68c28-b6d6-ef7e-f8f9-ebebe487378b
Version Independent ID: c5985867-3795-4280-ef0d-1d66ee30da6e
Content: Resource-specific consent in Teams - Teams
Content Source: msteams-platform/graph-api/rsc/resource-specific-consent.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: lajanuar

@xNiklasJern All the RSC permissions defined for your app will be taken from the manifest file only. Azure AD portal cannot be used for RSC permissions.

@Gousia-MSFT yes, but what will prevail of the option in aad is set to that user can't approve application to have access to data in the tenant, but teams has the configuration it can. what will prevail?

@xNiklasJern - There are two different set of permissions we are taking about here:

AAD Permissions: These can be only configured in Azure AD and needs go through either Delegated permission or Application permission flow. To provide user login experience in Microsoft Teams, you need to implement this via Teams authentication flow.
RSC Permissions: This can only be configured in App Manifest (Not available in Graph permission listed in Azure App). To get these permissions, you need to specify all of these in App Manifest. Owner of Team can always consent to these permissions provided that RSC is enabled in your Tenant.

In case of an App which is using both the permissions, installation of App Manifest by team owner grants app permissions listed down in App Manifest (RSC Permissions). In order to get additional permissions (AAD Permissions), you need to show Sign In button and get it approved for additional permissions. Note that not all permissions are supported in RSC, please take a look at the permissions list.

Please re-open if you have any other queries here.


[Java] Upgrade Netty due to security vulnerability, please make a release package.

Describe the bug, including details regarding any error messages, version, and platform.
PR has bean merged:
[Java] Upgrade Netty due to security vulnerability
https://github.com/apache/arrow/pull/36211
this issue leads to unavaliable, please make a release package.
@kou
Component(s)
Java

As described on the PR, we are working on the next release already. The code freeze has passed and we are working on packaging.

As described on the PR, we are working on the next release already. The code freeze has passed and we are working on packaging.

@lidavidm We need to release a software before july 17, which depends on arrow, do you have any idea of the time about the next version?

We will release a new version after July 17 because we need at least 72 hours to verify RC.
See also: https://www.apache.org/legal/release-policy.html#release-approval


Question: Root Query, Pagination and Entity TTL's

Hey @danReynolds,
I'm doing some experimenting and working with an entity (Contact) which has a TTL of 5 seconds (Its only this low value at the moment to make sure I understand how all the underlying functionality works).
The list page will only fetch 25 items at a time and is paginated by a nextToken. If I let the first 25 references TTL expire and then paginate to the next page by scrolling, once the request is returned and the response written to the cache all the existing references from the initial request have their TTL's become active again, I was expecting that these would remain expired given they haven't been rewritten into the cache as they already exists?
https://user-images.githubusercontent.com/406799/175798375-100a0cfd-d83b-4557-9964-92817b4b4762.mov
Note I'm using the fetchMore updateQuery callback to update my root query getContacts, you can see this below:
export const useGetContacts = (filter: any) => {
  const { data: settings } = useQuery(GET_ACCESS_TOKEN);

  const variables = { ...filter, limit: 25 };

  const { data, error, loading, fetchMore, refetch } = useQuery(GET_CONTACTS, {
    context: { accessToken: settings?.accessToken },
    returnPartialData: true,
    variables,
  });

  const items = data?.getContacts?.contacts || [];
  const nextToken = data?.getContacts?.nextToken;

  return {
    error,
    fetchMore: () =>
      fetchMore({
        updateQuery: (previousQueryResult, { fetchMoreResult }) => ({
          getContacts: {
            contacts: [
              ...(previousQueryResult?.getContacts?.contacts || []),
              ...(fetchMoreResult.getContacts.contacts || []),
            ],
            nextToken: fetchMoreResult.getContacts.nextToken,
          },
        }),
        variables: { nextToken },
      }),
    hasMore: Boolean(nextToken),
    items,
    loading,
    refetch,
  };
};

Should the TTL be reset back to active if the reference already exists in the cache and the TTL has already expired?
I'm wondering whether spreading the previous query results causes this problem 🤔 I would have thought that Apollo knows the reference already exists so this doesn't get rewritten but perhaps there is no check here. Note I don't use a custom query type policy merge function here so perhaps if I changed the implementation and used the mergeObjects helper this might work?
If you have any knowledge around this area that would be greatly appreciated.

Yea I think since you spread it then they are now being rewritten and will get their TTL cache time updated. I can look into that more sometime

Hey @danReynolds, thanks, I'll have a deep looker and try merging objects from the type policies to see whether this changed the behaviour.

You can also specify a renewal policy to indicate how cache TTLs should be reset: https://github.com/NerdWalletOSS/apollo-cache-policies#renewal-policies. Setting it to none would solve your issue but you may want it reset if it was being written in other ways. Maybe a renewal policy that only resets it if the object has changed could be a potential new feature, although I'm not the biggest fan of deep equality checks.

Hey @danReynolds, using the fetchMore updateQuery callback is in fact deprecated after doing some further research. After converting this to using a type policy with a custom merge function this now works as expected e.g:
getContacts: {
    merge(existing, incoming, { readField, mergeObjects }) {
      const existingContacts = existing?.contacts || [];
      const incomingContacts = incoming?.contacts || [];

      const mergedContacts: any[] = existingContacts
        ? existingContacts.slice(0)
        : [];

      const idIndex: Record<string, number> = Object.create(null);

      if (existingContacts) {
        existingContacts.forEach((contact: any, index: number) => {
          idIndex[readField<string>("id", contact) as string] = index;
        });
      }

      incomingContacts.forEach((contact: any) => {
        const id = readField<string>("id", contact) as string;
        const index = idIndex[id];
        if (typeof index === "number") {
          // Merge the new contact data with the existing contact data.
          mergedContacts[index] = mergeObjects(
            mergedContacts[index],
            contact
          );
        } else {
          // First time we've seen this contact in this array.
          idIndex[id] = mergedContacts.length;
          mergedContacts.push(contact);
        }
      });

      return {
        ...incoming,
        contacts: mergedContacts,
      };
    },
  },
},

I think this ticket can be closed but please add any finding you may have.

Ah interesting, okay yea I saw close it out then.


Model lp returns

Also we still need to move the final notebook to the vault and remove the other two from the PR

I see how that somehow the pull_request check failed while the push check succeeded, even though they are the same. All tests pass for me locally, so I guess that's a fluke?


Error in profile

We found an error in orthographic profile (git blame says otherwise, but I'm 99% sure it is my fault): μ is mapped to m, but it should be ɳ. Confirmation by the author via Twitter: https://twitter.com/anggarrgoon/status/1496151913284489217
I can make a PR, but I am not sure if it is the right workflow anymore, especially in terms of regenerating the CLDF.

Yep, please make a PR, thanks!


robotiq_gripper_action package

Is this anywhere on the horizon for development? I need it so I can have a functional gripper in MoveIt and Gazebo

http://gazebosim.org/tutorials?tut=drcsim_robotiq_hand&cat=drcsim This has a lot of work done for a controller in simulation.

@TheDash You have not been forgotten! I've developed a gripper action server and will submit a pull request tomorrow morning after I do some testing on the changes I made this weekend. There's also an EtherCAT interface following close on its heels.

The Robotiq C model gripper action server does not seem to work with RTU controller even after I remapped them to the proper controller topics in the launch file, Has the C model gripper action server been tested ?

Hey @arvinasokin, I wrote that action server. Ill find our C model today and we'll try and hunt down the issue.
Sorry for the trouble you are having.

Alright @arvinasokan:
The grippers that I have (and developed/tested with) is the second generation C 85 mm model in Modbus and Ethercat. If you don't have an 85, there is some additional configuration you'll have to set in the launch file for the action server that allows the robot to map from register values to engineering units. Please see here.
I used the test code in the action server to make a first pass, and it seems to function correctly. I am running from the latest version of source off indigo-devel. Please follow these steps and inform me of any errors you encounter, and where you encounter them. Run each command in a new terminal that is sourced to your workspace.

roscore
rosrun robotiq_c_model_control CModelTcpNode.py xxx.xxx.xxx.xxx CModelRobotInput:=/gripper/input CModelRobotOutput:=/gripper/output. You'll need to change CModelTCPNode.py to CModelRtuNode.py and the ip address to whatever your device name is.
roslaunch robotiq_action_server robotiq_c_model_action_server.launch
rosrun robotiq_action_server robotiq_action_server_client_test

Please let me know if/where it fails. Also, curious question, do you know if your gripper and controller box were originally paired?

ping @arvinasokan

Hi,
Sorry, was not able to reply before, got a little bit busy.
Yes I am using the the second generation gripper, but I didn't actually set the "CModelRobotInput:=/gripper/input CModelRobotOutput:=/gripper/output" when I  Rosran the controller.
Also I didn't use the controller box as I was just using their USB to RS485 converter to connect to the gripper and the Force/Torque sensor.
The last time I ran it, the action server was able to get the action goal but it have any way to communicate with the gripper
and I used remap in the launch file and it didn't work the last time.

@arvinasokan Thanks for the feedback. I admit I don't understand the issue: The action server was able to get to the goal, but not the gripper?
The CModelRobotInput:=/gripper/input and CModelRobotOutput:=/gripper/output is just the way remaps get passed to your node on the command line at start-up. It is equivalent to writing <remap from="CModelRobotInput" to="/gripper/input"/> in a launch file bringing up the controller node.
If you could please clarify the issue, I will happily do what I can to support your needs.


feat: Add forgot password feature

Fixes #29
Mails get classified as spam as the issue is being discussed in https://github.com/fossasia/open-event-server/issues/4910

@iamareebjamal @simarsingh24 Please review


Vue Version 2.^2.6.11
vue-tsc = ^0.2.0
When trying to migrate from vue-cli to Vite and using vue-tsc I am getting many issues on the build that I hadn't before. Problemas like

Cannot find name 'field'
The '>' operator cannot be applied to type 'symbol'
Property 'assets' does not exist on type '{}'

Some of those problems come from a bad code, but others can pass without any problems. For example, here is some code.
vue-tsc does not recognize a prop when it is declared at the decorator @Component

<template>
{{field}}
</template>

<script lang="ts">
import { Component, Vue } from 'vue-property-decorator';

@Component({
    props: {
        field: Object,
    }
})
export default class FieldOptions extends Vue {}

// error = error TS2304: Cannot find name 'field'.

{
  "compilerOptions": {
    "strict": true,
    "target": "esnext",
    "module": "esnext",
    "jsx": "preserve",
    "importHelpers": true,
    "moduleResolution": "node",
    "experimentalDecorators": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "noImplicitAny": false,
    "noEmit": true,
    "strictNullChecks": false,
    "allowSyntheticDefaultImports": true,
    "noImplicitAnyForClassMembers": false,
    "sourceMap": true,
    "resolveJsonModule": true,
    "noVarRequires": false,
    "baseUrl": ".",
    "types": [
      "vite/client"
    ],
    "paths": {
      "@/*": [
        "src/*"
      ]
    },
    "lib": [
      "esnext",
      "dom"
    ]
  },
  "include": [
    "src/**/*.ts",
    "src/**/*.tsx",
    "src/**/*.vue",
    "tests/**/*.ts",
    "tests/**/*.tsx"
  ],
  "exclude": [
    "node_modules"
  ]
}

I have found some workaround like use of Vue.extend to declare props. But my project is very big and I would like to find some other solution without change everthing.

See https://github.com/johnsoncodehk/volar/issues/245.
You could use @ts-ignore to ignore some error in specific lines. But in your case, I recommend you just remove vue-tsc to ignore all type-checking on build, because when you give up complete type safety, there is no point in using vue-tsc. And you can still found all vue-tsc's errors in IDE with volar.

Thanks for the tip!
I will keep it at another script directive. Fix type issues in the future.


This browser is not supported or 3rd party cookies and data may be disabled

Unable to authenticate, tried several browsers, all get the same message. At least list what the requirements are?

@mwichmann That's really weird. I've never faced that issue before, or even had someone face this. There are no specific requirements to the app at all. It can be any browser. It must be an error from Firebase itself. Have you tried Signing in as Anonymous? I'll try to get to the bottom of this ASAP :)

anonymous does work (should have mentioned that!), but I'm assuming there's no way to get back to the same "account" that way?

@mwichmann That's true. Could you try it now maybe? I just pushed another update.

It works fine now. Thanks for the rapid reply!

@mwichmann That's awesome :) Thank you so much for sticking through even with the hiccups. Please do let me know if I can do anything to make the experience better for you.


Add a glossary to have a central place for definitions/links

Description
In #1200/#1087, it was noted that there's a variety of technical terms that we sort of have to define  ad-hoc:

graph things like "node", "vertex", "edge", "link", ...
graph ML things like "node classification", "link prediction"
even ML terminology like "inductive"

If we had a central glossary, we can write these done once and link to them.

Potentially a lot of work, save for 1.1


break

Hi
I installed your repo using "npm install --legacy-peer-deps" as without the latter it would break.
It gave an error: "Cannot find module 'prettier' " so I commented out the tslinter lines in webpack.dev.js
//new ESLintPlugin({ extensions: ['js', 'ts'],}),
//new StylelintPlugin(),
I followed your instructions for the backend and created a npm script as suggested in package.json as follows:
""backend": "nodemon --delay 1500ms ./server-dev.js & webpack serve --mode development --config ./scripts/webpack.dev.js"
after adding the proxy it works on port 3000
however there is a new error when running the backend script:
/data/webapps/mixpack/scripts/paths.js:1
import path from 'path';
^^^^^^
SyntaxError: Cannot use import statement outside a module
Is this due to confusion over a folder path having the same name as a module?
After the "Complete!" message it hangs as I would have expected the message that the server is running on port number xyz
I spent days trying to get a webpack 5 site up and runing (with express, pug, routing etc) and tumbled upon expack and then on to yours and it's the best I have seen so far :)
fyi, I created a fresh repo with the same name on my github in case this makes it easier for you to verify my setup.
cheers, Alfred

Hi @ourmaninindia have you tried cloning down the fullstack branch here? https://github.com/waldronmatt/mixpack/tree/fullstack That contains all the code you'll need per the documentation to get set up and should fix the commonjs related errors you are seeing on the paths file. I ran that branch locally and was able to launch the server successfully.
If you run into any issues installing dependencies, try running npm i --force.
Glad to hear you have found use with this template!

Closing issue due to inactivity.


No warning when deleting a page which has foreign keys

I have a page that is linked to a custom model courses which has submissions. On deleting the course page there is no indicator that warns me that the submission wil be lost or that there will be no reference for the future. With debug mode on you get a protected error when you click on delete after you are asked to confirm the deletion of the page. On production this is a 400 error which is not proper if I may say.
Technical details

Python version: Python 3.6.5
Django version: Version: 2.2.10
Wagtail version: Version: 2.8

Hi @jeffagc - thanks for the report. This is covered by the existing issue #1602, and there's work on a fix in progress at #4702.


Update snark client function comments with the current return type order

[x] Forked repo is synced with upstream -> github shows no code delta outside of the desired.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
[x] Tests are passing? https://github.com/microsoft/DeepGNN/blob/main/CONTRIBUTING.md#run-tests
[ ] Changelog and documentation updated.
[ ] PR is labeled using the label menu on the right side. (No write permission)

Previous Behavior
New Behavior
Only comment changes to give better clarity for the snark client code.

I don't have write permission for this repo. Could you merge this PR for me? Thank you.


kernel must be 'precomputed' or callable, is precomputed.

Given the model
model = process.SVC(metric="logeuclid", kernel_fct="precomputed", C=0.1,
                                    shrinking=True, cache_size=1024,
                                    class_weight="balanced")

Then calling
model.fit(X, y)
returns
kernel must be 'precomputed' or callable, is precomputed.
This is due to this piece of code in pyriemann.classification.py:

Which clearly doesn't check where kernel_fct = "precomputed", but only if it's callable or None.

Good catch! This problem will be solved with #272.
In the meantime you can use kernel_fct=None to achieve the same behavior.

Closed with #272


Deprecating Record and RecordMetaData

Signed-off-by: Mohit Saxena<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
Fixes #946
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #954 (304896c) into main (aaae10d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #954   +/-   ##
=========================================
  Coverage     91.40%   91.40%
  Complexity      673      673
=========================================
  Files            83       83
  Lines          1955     1955
  Branches        165      165
=========================================
  Hits           1787     1787
  Misses          129      129
  Partials         39       39

Impacted Files
Coverage Δ

...va/com/amazon/dataprepper/model/record/Record.java
100.00% <ø> (ø)

...mazon/dataprepper/model/record/RecordMetadata.java
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaae10d...304896c. Read the comment docs.


[Question] Why isn't it loading for me?

Sorry for opening an issue for this.
Whenever i reload, there is no mention of the script i wrote at all. Doesn't generate new files, doesn't do anything with contenttweaker at all.
All i'm trying to do is generate a test block.
Under C:\curseforgemods\Instances[my instance name lmao]\scripts\customitems.zs:
#loader contenttweaker

import mods.contenttweaker.block.BlockBuilder;

new BlockBuilder().build("test_block");

There isn't any placeholder textures in the openloader folder at all
Logs:
https://pastebin.com/QtnK0pdp
As you can see, no mention of my customitems script, even though the other script, recipes.zs in the same folder works perfectly
Kinda lost on what to do, any help would be appreciated.
Thanks in advance.

What is your script called?


Installation fails with pipenv install jazzit

Hey! I want to try out this script, but sadly it fails when running pipenv install jazzit with the following message.
Installing jazzit…
Error:  An error occurred while installing jazzit!
Error text: Collecting jazzit
  Using cached jazzit-0.2.0.tar.gz (3.1 MB)
  Installing build dependencies: started
  Installing build dependencies: finished with status 'error'

  ERROR: Command errored out with exit status 1:
   command: /Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/bin/python /Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip install --ignore-installed --no-user --prefix /private/var/folders/2l/wpk3nrwx0fqfb35jyjssgy1w0000gn/T/pip-build-env-c9x3093u/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple --pre -- 'setuptools >= 40.6.0' wheel
       cwd: None
  Complete output (44 lines):
  Traceback (most recent call last):
    File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 193, in _run_module_as_main
      "__main__", mod_spec)
    File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
      exec(code, run_globals)
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/__main__.py", line 26, in <module>
      sys.exit(_main())
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_internal/cli/main.py", line 73, in main
      command = create_command(cmd_name, isolated=("--isolated" in cmd_args))
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_internal/commands/__init__.py", line 104, in create_command
      module = importlib.import_module(module_path)
    File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/importlib/__init__.py", line 127, in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
    File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
    File "<frozen importlib._bootstrap>", line 983, in _find_and_load
    File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
    File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
    File "<frozen importlib._bootstrap_external>", line 728, in exec_module
    File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_internal/commands/install.py", line 24, in <module>
      from pip._internal.cli.req_command import RequirementCommand, with_cleanup
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_internal/cli/req_command.py", line 16, in <module>
      from pip._internal.index.package_finder import PackageFinder
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_internal/index/package_finder.py", line 21, in <module>
      from pip._internal.index.collector import parse_links
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_internal/index/collector.py", line 14, in <module>
      from pip._vendor import html5lib, requests
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_vendor/requests/__init__.py", line 114, in <module>
      from . import utils
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_vendor/requests/utils.py", line 25, in <module>
      from . import certs
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_vendor/requests/certs.py", line 15, in <module>
      from pip._vendor.certifi import where
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_vendor/certifi/__init__.py", line 1, in <module>
      from .core import contents, where
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip/_vendor/certifi/core.py", line 12, in <module>
      from importlib.resources import read_text
    File "/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/importlib/resources.py", line 11, in <module>
      from typing import Iterable, Iterator, Optional, Set, Union   # noqa: F401
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/typing.py", line 1359, in <module>
      class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
    File "/Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/typing.py", line 1007, in __new__
      self._abc_registry = extra._abc_registry
  AttributeError: type object 'Callable' has no attribute '_abc_registry'
  ----------------------------------------
ERROR: Command errored out with exit status 1: /Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/bin/python /Users/mrlubos/.local/share/virtualenvs/api-T1wVW5XM/lib/python3.7/site-packages/pip install --ignore-installed --no-user --prefix /private/var/folders/2l/wpk3nrwx0fqfb35jyjssgy1w0000gn/T/pip-build-env-c9x3093u/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple --pre -- 'setuptools >= 40.6.0' wheel Check the logs for full command output.

✘ Installation Failed

I have also tried putting it in Pipfile and then running pipenv install which produces the following error.
An error occurred while installing jazzit==0.2.0 --hash=sha256:90b6d1d8d06ce2e47eac2d395869352d59f8eb7fcce5d77f3ecf2f9a035a542a! Will try again.
Installing initially failed dependencies…
[InstallError]:   File "/usr/local/Cellar/pipenv/2020.6.2/libexec/lib/python3.8/site-packages/pipenv/cli/command.py", line 232, in install
[InstallError]:       retcode = do_install(
[InstallError]:   File "/usr/local/Cellar/pipenv/2020.6.2/libexec/lib/python3.8/site-packages/pipenv/core.py", line 2051, in do_install
[InstallError]:       do_init(
[InstallError]:   File "/usr/local/Cellar/pipenv/2020.6.2/libexec/lib/python3.8/site-packages/pipenv/core.py", line 1306, in do_init
[InstallError]:       do_install_dependencies(
[InstallError]:   File "/usr/local/Cellar/pipenv/2020.6.2/libexec/lib/python3.8/site-packages/pipenv/core.py", line 900, in do_install_dependencies
[InstallError]:       batch_install(
[InstallError]:   File "/usr/local/Cellar/pipenv/2020.6.2/libexec/lib/python3.8/site-packages/pipenv/core.py", line 796, in batch_install
[InstallError]:       _cleanup_procs(procs, failed_deps_queue, retry=retry)
[InstallError]:   File "/usr/local/Cellar/pipenv/2020.6.2/libexec/lib/python3.8/site-packages/pipenv/core.py", line 703, in _cleanup_procs
[InstallError]:       raise exceptions.InstallError(c.dep.name, extra=err_lines)
[pipenv.exceptions.InstallError]: Collecting jazzit==0.2.0
[pipenv.exceptions.InstallError]:   Using cached jazzit-0.2.0.tar.gz (3.1 MB)
[pipenv.exceptions.InstallError]: ERROR: Disabling PEP 517 processing is invalid: project specifies a build backend of setuptools.build_meta in pyproject.toml
ERROR: Couldn't install package: jazzit

Are you able to advise what am I doing wrong please? The install works with pip from Terminal, but I wanted to add this to an existing project.

The first issue you face seems to be the same as https://github.com/ethereum/eth-abi/issues/131
you could try to pip uninstall typing from your trace I see you are on python3.7 so typing is already in the standard library
The second issue is because of the build-backend, I am guessing adding a flag to your Pipefile might help jazzit = { version="*", pip_options=['--no-use-pep517'] } but I can't really reproduce locally so if this doesn't work it would be golden if you could share your Pipfile and also the versions of your pipenv & pip


Gh actions

Oops! Please disregard; just noodling around with Actions. 🙂

No worries Ri! Hope you like -- feel free to make a PR on actions or
anything since I have left this one dormant for a while :)
Ellie Frymire
650.575.8738
On Wed, May 11, 2022 at 8:53 AM Ri Le @.***> wrote:

Oops! Please disregard; just noodling around with Actions. 🙂 (this is a
great project btw)
—
Reply to this email directly, view it on GitHub
https://github.com/efrymire/nyc-run-covid-testing/pull/2#issuecomment-1123956966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHPIBP7WUAYVQ7CZYDV3A73VJPJXBANCNFSM5VVNGSKA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[BUG] setuptools is not automatically including type stubs by default

setuptools version
setuptools==75.3.0
Python version
Python 3.13
OS
Arch Linux
Additional environment information
No response
Description
According to the setuptools note here,

Added in version v69.0.0: setuptools will attempt to include type information files by default in the distribution (.pyi and py.typed, as specified in PEP 561).
Please note however that this feature is EXPERIMENTAL and may change in the future.
If you have .pyi and py.typed files in your project, but do not wish to distribute them, you can opt out by setting exclude-package-data to remove them.

However, I found that my type stubs (.pyi) are not being packaged unless I specify them in my MANIFEST.in.
Expected behavior
The type stubs should be automatically included in my sdist without having to specify it in MANIFEST.in
How to Reproduce

Create a Cython extension
Add a .pyi file
Ensure that setuptools required by the build system is >=69.0.0
Upload to GitHub
pip install the package
See that everything but the type stubs are in the relevant site-packages folder

Output
N/A

Hi @winstxnhdw, could you please include a complete minimal reproducer, including the source code for the examples. Please have a look at the advice in https://stackoverflow.com/help/minimal-reproducible-example.
If I had to guess, I would say that is because you are adding a top-lelvel single extension module instead of a package. .pyi files may be detected inside of packages, but as a coexisting top level file, probably not (that is not how the autodiscovery works). But yeah, we can only confirm this hypothesis or proceed with the investigation once we have a complete minimal reproducer.

Assuming the hypothesis is confirmed, because this is an experimental feature contributed by a member of the community, we have 2 ways we can go about it:

A member of the community submits an emhancement to handle this use case via PR
We document the existing limitation and accept it as the way the system works.

Would you like to give it a go and propose a PR?

Hey @abravalheri,
It's as you said. setuptools is not detecting the extension module as a package. Simply adding a __init__.py resolves this issue.