Render JSON Feed entries’ content with render_content

See #148.
This isn’t ready yet; I’m only opening a PR so that I can see the CI output.

@snarfed I fixed about half of the tests by just updating them with the app’s new behavior. There are some awkward cases left, though. Consider this error from the test_jsonfeed_to_activity_note test:
- A note. link too
+ A note. link too

Expected value:
{'author': {'displayName': 'Ryan Barrett',
            'image': [{'url': 'http://example.com/ryan/image'}]},
 'content': 'A note. link too',
 'id': 'tag:example.com,2011:blog-post-123',
 'image': [{'url': 'http://example.com/blog-post-123/image'}],
 'objectType': 'note',
 'published': '2012-02-22T20:26:41',
 'summary': 'too cool to summarize',
 'updated': '2013-10-25T10:31:30+00:00',
 'url': 'http://example.com/blog-post-123'}
Actual value:
{'author': {'displayName': 'Ryan Barrett',
            'image': [{'url': 'http://example.com/ryan/image'}]},
 'content': 'A note. link too

',
 'id': 'tag:example.com,2011:blog-post-123',
 'image': [{'url': 'http://example.com/blog-post-123/image'}],
 'objectType': 'note',
 'published': '2012-02-22T20:26:41',
 'summary': 'too cool to summarize',
 'updated': '2013-10-25T10:31:30+00:00',
 'url': 'http://example.com/blog-post-123'}

The Activity Streams object ends up with an img tag in the content field that is redundant with the image field.
In general, given that JSON Feed needs some information (like embedded image URLs) to be included inline in the HTML while other formats carry that information out-of-band, there is going to be awkwardness converting between different formats, and I think it would be get a lot of work to get a transformation like “convert from AS to JSON Feed and then back to AS” to be idempotent, even assuming that the input is in exactly the format that Granary would have emitted. How would you like me to handle this?

hey ben, i'm glad you're getting back to this! thank you!

I think it would be get a lot of work to get a transformation like “convert from AS to JSON Feed and then back to AS” to be idempotent

absolutely right, i agree. i don't actually expect all round trip conversions like that to be idempotent. most of the file sets in testdata/ only have some formats (by extension), not all, and some have special extensions like eg .as-from-feed.json, which test_testdata.py special cases to test only a one way conversion. feel free to use that liberally, and/or rename existing files to it to prevent them from testing a round trip.
also, if the test data approach is just too awkward altogether for testing something specific, feel free to add code-based tests to test_jsonfeed.py instead, or in extreme cases, even move testdata files there. that should hopefully be unlikely though.
thanks again!

This is ready to be reviewed! I changed the tests in a way that made sense to me, but let me know what you think.

looks great. thank you again for sticking with this!

deployed!

Awesome! Glad I could help 😃


exception handling for promise

related conversation https://www.reddit.com/r/javascript/comments/4eqhic/make_a_javascript_function_support_both_promise/d22slpz

Looks okey to me, but I don't think you should check err for null and undefined.

@tunnckoCore what would you check for?

Generally we should not check for nothing - just if (err) reject(err). But i'm using is-typeof-error, because throwing different than error object is bad practice.

so you mean just checking if the value is truthy
Yeah, wasn't sure about that.
but if you call cb(foo) and foo is for some reason 0 or en empty string, I'd still expect the promise to reject

It's just not our job. And that's totally wrong and we should not care about and should not support such things. Community know, community follow conventions and best practices. It's not normal user to expect resolved promise when pass first argument to callback, it's not natural and it's anti-node - we should not support such things. Such user should go back and learn how node (and javascript in general) works and why it works in exactly this way.

It's not normal user to expect resolved promise when pass first argument to callback

I don't think you understood me if the callback is called with a first argument, the promise is rejected

I think I perfectly understood you first time. What you expect when you pass 0 or such values as first argument? Resolved promise with 0 as result? That's totally wrong. And that's what I'm talking about, the all world is driven by conventions and know what the falsey value is and how to use callbacks.

What you expect when you pass 0 or such values as first argument? Resolved promise with 0 as result?

No, if you pass 0 as first value the promise reject with that value

Exactly. What's the problem? What wrong you see? In general case, yea, it's wrong but we should not care and all is conventions. That's why I use and more reasonable check will be err instanceof Error.

So, some thoughts:

The proposal for Node didn't get shut down. It's still going.
The particular dual syntax was "shut down" because of APIs with optional arguments like crypto and other similar APIs, where there is ambiguity - as well as functions with non-conforming callback signatures like fs.exists.
promise returning functions should never throw, only reject. This is what promise users expect - though it becomes a non-issue when async/await lands.

Generally, I am in favor of rejecting on errors rather than throwing. A function should always or never behave asynchronously - throwing/returning values synchronously is a sham - this is also true with callbacks - see http://blog.izs.me/post/59142742143/designing-apis-for-asynchrony.
Note that this PR is not needed and can be safely archived - this is what the promise constructor does anyway... when you do new P and pass a function it converts exceptions to rejections, why? To guard against this very case.
new Promise(() => {
    throw new Error();
}).catch(e) {
    // the error ends up here, although it is synchronous.
});

Note that this PR is not needed and can be safely archived

Indeed, I modified the PR to only includes the tests and removed changes from index.js

LGTM

@benjamingr thanks


Mass index in Elasticsearch with a @Component

I'm currently mass indexing with a @Configuration. This article shows an alternative solution that uses @Component.
The motivation for using @Component and CommandLineRunner seems to be the standard way to perform a task after the service has started.
~One potential benefit of using @Component is that Elasticsearch will be re-indexed after an hot reload of the service, which is not the case when using @Configuration.~
Using @Configuration actually enables re-indexing after hot reload. The @Component solution should support this feature.

Returning to Backlog and adding enhancement tag.


Fixes for demos

The mouseover event didn't work, because Chart.js doesn't fire mouseover events by default. If I understand correctly, mouseover isn't really what we want; that's fired once when the mouse moves over the chart as a whole, but we need to evaluate whether it moves over individual annotation elements.
Change the demo line value from 120 to 10. 120 is usually (always?) outside of the range of the randomly generated data, so it wasn't visible.
Accessing element.chartInstance.chart.canvas failed, but accessing element.chartInstance.canvas works.

These things are also fixed in #239 (among other things)

Thank you.
Other than the fix for the "a another test label" typo in samples/labels.html, it looks like this PR is no longer needed. Would you like for me to close it?

Fixed the label there too.
This might be good against v2 branch though. There are couple of issues there too to fix, before pushing e release.

ok, does not look like it would be worth it to rebase.

Sounds good. Thanks for the quick feedback and for your work to get this plugin updated for Chart.js 3.x.


URL list and describe for odo2 local support

/area devfile
odo url list and odo url describe for local docker containers should works the same as kube cases.

/assign

/kind feature

This items should also cover the json output format for the command

/area url
/area local


Tabs vs. Spaces

VS Code is always changing my tabs to spaces and spaces to tabs. Constantly, it never stops no matter how I setup the app. On every computer it always does the opposite of what I want. I really dont care what we decide to use, but we need to pick one. Either tabs, or spaces.

I think I have discovered what is really bothering me. It is when I paste. If I paste code that uses tabs, it does not matter what my local setting is. I get tabs. Same way vice, versa. I think what I am really looking for is to have paste respect my choice of tabs vs. spaces.

@KidSysco You can use the following settings: "editor.formatOnPaste": true or "editor.autoIndent": "full".


Updated README with a Purpose section

as mentioned in https://github.com/middlewares/request-handler/issues/1#issuecomment-296216346

Good job!
thank you 👍

Awesome, thanks!


I cant scaffold

This is the error I am getting using vscode for ubuntu
There was an error creating a DbContext :(15,53): error CS0053: Inconsistent accessibility: property type 'DbSet' is less accessible than property 'RazorPagesMovieContext.Movie'
at Microsoft.VisualStudio.Web.CodeGeneration.ActionInvoker.b__6_0()

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6719f08e-3bd7-dc1a-71df-f2ef9fbca9d8
Version Independent ID: 7096fdb3-612e-9e00-bd0b-8ea4886a09ce
Content: Part 2, add a model
Content Source: aspnetcore/tutorials/razor-pages/model.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @wadepickett
Microsoft Alias: wpickett

@rolandnii,  Thanks for letting us know your experience.  We appreciate the heads up.
Just a side note: The version of the tutorial you have reported on is for .NET 6.
It sounds like a mismatch between private and public for a property and class.
Given the error, I am assuming Data/RazorPagesMovieContext.cs was created.  Does Data/RazorPagesMovieContext.cs look any different in your project than this following example, as shown in the tutorial?
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.EntityFrameworkCore;
using RazorPagesMovie.Models;

namespace RazorPagesMovie.Data
{
    public class RazorPagesMovieContext : DbContext
    {
        public RazorPagesMovieContext (DbContextOptions<RazorPagesMovieContext> options)
            : base(options)
        {
        }

        public DbSet<RazorPagesMovie.Models.Movie>? Movie { get; set; }
    }
}

I will retest version 6, which is what you are using, with the latest related packages and again with the packages available at the time for version 6.  The tooling changed recently for scaffolding, there could be something up there.  I am currently working through all tutorials and code samples in this series for version 8, I'll check this too.

Closing, was unable to recreate.  More info needed, see questions above.


Fix index out of bounds when installing hidden chart

Issue: https://github.com/rancher/rancher/issues/36332
Problem:
Charts in the old Rancher catalog are deprecated and hidden from the user. When you attempt to install any of them the Rancher cli tries to find the latest version of the chart and panics with an index out of bounds.
Solution:
This PR adds a conditional to recover from the panic gracefully, and provide an error with a description of the problem.

@superseb I updated the error message to provide more information about what the problem is exactly.


Polymer startup appears slow on Nexus 4

 Issue by blois
Originally opened as dart-lang/sdk#20591

Just playing with a trivial paper-styled application and the startup time in content shell appears quite slow (using Dart VM)
One very large chunk is that it looks like it's taking 2.2s to do 'registerWhenReady'.
Application can be found at:
https://github.com/blois/paper_app
Repro steps:
Open in Editor, deploy to mobile. Hit the 'reload' button to refresh.
Attached is a JS profile showing the time in question.

Attachment:
CPU-20140819T135023.cpuprofile (422.28 KB)

 Comment by blois

Added a pure JS version of the app at:
https://github.com/blois/polymer_paper
Runnable at http://blois.github.io/paper_app.html
Total startup time of this app is ~1.4s including network time and takes ~650ms after the document transitions to interactive to whenPolymerReady, on a Nexus 4.

 Comment by dgrove

cc @jmesserly.
Set owner to @sigmundch.
Removed Priority-Unassigned label.
Added Priority-High label.

 Comment by kasperl

Added Accepted label.

 Comment by jmesserly

That number doesn't seem out of line with: https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=android-nexus4&tests=polymer_load.pica%2FTotal&checked=all

 Comment by sigmundch

cc @jakemac53.

 Comment by sigmundch

good to know - thanks for the update Pete!

 Comment by blois

Update- with Dartium 38 the load time has improved somewhat, but I'm still seeing that the main() of Dart is taking ~1.5s.
It also appears that 500-750ms of startup time is spent in Polymer.js code before the Dart main is ever run, so all in all there's about 2s of Polymer startup. The Dart VM adds another 500ms.

main() in the new polymer is under 1s now


Prevent updates on the backlog table

There should be no updates on the backlog table.
We need to create a changefeed to listen to updates in the backlog and if an update occurs revert the change. The tricky part is that several nodes will try to do this a the same and the revert will trigger a new update in itself.

Same problem as #195, I don't think it's merely tricky but actually impossible in the current setup.

Also this is incompatible with #198 since transactions will need to be updated periodically with new assignees and fresh timestamps.

@rhsimplex Can you say a bit about why you think this issue can be closed? Is it because maliciously updated transactions can only become invalid, and therefore will get handled anyhow?

Sorry.  #198 requires updates to backlog. And since Byzantine operations will be stopped by some other preventative measure in the future, these handle delete/update to [table] don't really make a whole lot of sense anymore.  In fact, with #544 we actually have removed the existing functionality.


refactor(build): update rollup shaderChunks

improve glsl processing to compress build sizes by a modest amount.
Described in #5601
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

Karma is a fitting name. I'll look into that.

Yeah, you have to be careful about being overzealous with trimming whitespace in shader chunks. 😄  I believe the old code prevented this.

Running through it now.  I'll update and document.

shaders processing code requires a final new line for each chunk.  doesn't affect the operation of the engine or examples but causes type warnings.  might look at that later.

To quote @willeastcott from another PR:

I have a goal to eliminate as many files and configuration from the root of the repo as possible - this keeps it simple and accessible to contributors

I'm not sure why we're suddenly excited about watering down that position now?

This file is not in the root of the repo.
It is removing a chunk of code from root and moving it to utils.  I feel this follows the spirit of that idea.


clean up code a bit, add php 7.3 and 7.4 to travis, fix deps a bit

Please review :)
This one will cause a new 2.3.x version after merge.


Proposal: kool wait

Waiting for a valid state is a recurring requirements for a lot of tasks, namely containers start synchronisation for example.
Some other tools implement a nice approach which I believe might make sense to bring to kool as well.
kool wait http://other-container:8000  - would wait until getting a valid 200 out of that URL.
kool wait tcp://mysql:3306 - waits until Mysql is accepting connections.
kool wait file:///path/to/some/file - waits until that file exists.

Other than the basics (http(s)/tcp) would be great to have some extra helpers for example:
kool wait  elastic://elastic-container:9200 - which would not only wait for HTTP server to be up, but for a health state as well.
kool wait mysql://mysql:3306 - not only awaits for Mysql accepting connections but also being live for querying.

Yet another level of extras could be generic content checking / status / etc.
kool wait --http-status=302 http://other-container:8000 - waits for a redirect response.
kool wait --timeout=25s --check-interval=2s tcp://ip:1020- changes the timeout for waiting (default to 1 minute?); changes the interval between checks
kool wait --text="Kool" file://path/to/file - waits until the target file contains the content provided "Kool"

For Reference: We already do something like that using https://github.com/jwilder/dockerize wait feature with:
wait-services: kool exec app dockerize -wait tcp://database:3306 -wait tcp://cache:6379 -timeout 30s

A testing tool, that in parts steps on this same feature - used for healthchecks - https://github.com/aelsabbahy/goss
Specially for docker-compose - https://github.com/aelsabbahy/goss/tree/master/extras/dcgoss
We should understand it.

As pointed by Daniel we already use dockerize and there does seem to be much reason or room for improvement to a new implementation of the same tool at the moment. If needed by we can revisit this topic in the future upon a new perspective.


Added scheduling parameters to helm template;

Issue #, if available:
Closes #1038
Description of changes:
This adds affinity, toleration and priorityClassName to the deployment spec as optional parameters.
They default to none, so this will not change any existing functionality.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/ok-to-test

/approve

/lgtm


Does not match GitHub URL pattern. It's not working on enterprise github with two private repos

I tried to config two private keys on enterprise Github.
But something is wrong with it.
Comment for (public) key 'ssh-ed25519 xxxxgit@github.sec.samsung.net:aaaa.git' does not match GitHub URL pattern. Not treating it as a GitHub deploy key.
Comment for (public) key 'ssh-ed25519 xxxxgit@github.sec.samsung.net:bbbb.git' does not match GitHub URL pattern. Not treating it as a GitHub deploy key.

Can we support config Github hostname?
Thanks,
Yu Zhu

This issue is also super similar to https://github.com/webfactory/ssh-agent/issues/123

This issue is also super similar to #123

To my understanding, #123 is about an unnecessary (meaningless) log output line due to a parsing glitch.

Yes. The problem is that we need to recognize the different repo names, set up fake hostnames for them, then map those back to the right ones while specifying the key in the SSH config and finally make git rewrite differnt variants of the original URL to the replacement hosts... 🥴.
If anyone comes up with a good suggestion how to make this work for repo URLs in general (i. e. not limited to the<EMAIL_ADDRESS>pattern), I'd be happy to discuss that!

There are duplicate reports for this. I've created #128 to focus the discussion in one issue.


R XGBoost predict result differs from result using xgb.model.dt.tree

After training an R xgboost model as described below, I would like to calculate the probability
prediction by hand using the tree that is output by xgb.model.dt.tree().
For a test row, I thought that the correct calculation would use the leaves from all 4 trees as shown here:
    Tree Node  ID Feature    Split  Yes   No Missing      Quality    Cover
 1:    0    0 0-0      V8 0.012865  0-1  0-2     0-1 20.127027500 61.50000
 2:    0    1 0-1    Leaf       NA <NA> <NA>    <NA>  0.009677419 30.00000
 3:    0    2 0-2    Leaf       NA <NA> <NA>    <NA>  0.350769252 31.50000
 4:    1    0 1-0     V15 0.625835  1-1  1-2     1-1 19.353305800 60.54989
 5:    1    1 1-1    Leaf       NA <NA> <NA>    <NA> -0.034775745 30.22977
 6:    1    2 1-2    Leaf       NA <NA> <NA>    <NA>  0.300693214 30.32012
 7:    2    0 2-0    Leaf       NA <NA> <NA>    <NA>  0.098971337 59.27218
 8:    3    0 3-0    Leaf       NA <NA> <NA>    <NA>  0.071213789 58.25556

I expected that the probability for the following input:
#       V8      V15
# -0.93597 -0.51685

would be the result of the following calculation:
logfun <- function(x){1/(1 + exp(x))}
logfun(-sum(0.009677419,-0.034775745,0.098971337,0.071213789))
#0.5362082

Where each of the numbers are the leaf values for each of the 4 trees.
However, the predict() function produces the following:
predict(xgbModel,test_row_1)
#0.5184599

The leaf indices returned by predict(xgbModel,test_row_1,predleaf = T) are c(1,1,0), meaning that the last tree is not considered by the predict function.
Is my approach to hand-calculation correct? Should all 4 trees be considered when calculating the probability?
Thank you.

I left my reply at https://discuss.xgboost.ai/t/r-xgboost-predict-result-differs-from-result-using-xgb-model-dt-tree/208/2.


[spk] Introspection tool needs to support multi-stage pipelines

As a: developer/operator
I want: to use the introspection tool with my multi-stage pipeline setup
So that: I can introspect my services, just like with the single stage pipeline setup.
Describe the solution you'd like:
Service creation commands in spk are supporting the creation of a pipeline that combines the source -> ACR and ACR -> HLD in one yaml.

[x] Test how service introspection will work with multi-stage pipelines
document
Write documentation on how a user can setup their pipelines to work with service introspection if they're using multi-stage pipelines.

Does this require updates to documentation?: Yes

Created a sample working example of service introspection in multi-stage here https://dev.azure.com/epicstuff/hellobedrock/_build/results?buildId=6885&view=results

Working introspection with multistage deployment pipeline here: edaena/spartan-app/blob/master/azure-pipelines.yml
The investigation resulted in these new tasks:

spk Dashboard doesn't populate ACR to HLD for multistage pipelines
Spike - Environment specification in multistage pipeline
Multistage pipeline introspection documentation


Shell command with quiet option set to false is still being suppressed

...
- shell:
  -
    command: cat .vscode/extensions.txt | xargs -L 1 echo code --install-extension | bash
    description: Install VSCode extensions
    quiet: false

output of running ./install
All targets have been cleaned
Link exists ~/.bash_profile -> /home/jchi/.dotfiles/bash_profile
Link exists ~/.bashrc -> /home/jchi/.dotfiles/bashrc
Link exists ~/.gitconfig -> /home/jchi/.dotfiles/gitconfig
Link exists ~/.vimrc -> /home/jchi/.dotfiles/vimrc
Link exists ~/.zshrc -> /home/jchi/.dotfiles/zshrc
Link exists ~/.config/nvim/init.vim -> /home/jchi/.dotfiles/init.vim
~/.config/Code/User/keybindings.json already exists but is a regular file or directory
~/.config/Code/User/settings.json already exists but is a regular file or directory
Some links were not successfully set up
Install VSCode extensions [cat .vscode/extensions.txt | xargs -L 1 echo code --install-extension | bash]
All commands have been executed

==> Some tasks were not executed successfully

Some info:

dotbot version: commit * f5e0191 - Work around subprocess.call() issue on Windows
system: Debian GNU/Linux 10 (buster)
config file:

- clean: ['~']

- link:
    ~/.bash_profile: bash_profile
    ~/.bashrc: bashrc
    ~/.gitconfig: gitconfig
    ~/.vimrc: vimrc
    ~/.zshrc: zshrc
    ~/.config/nvim/init.vim: init.vim
    ~/.config/Code/User/keybindings.json: .vscode/keybindings.json
    ~/.config/Code/User/settings.json: .vscode/settings.json

- shell:
    -
        command: cat .vscode/extensions.txt | xargs -L 1 echo code --install-extension | bash
        description: Install VSCode extensions
        quiet: false

This is a "documentation bug".
quiet (default: false) decides whether or not to include the command itself in the Dotbot output. If it's set to true, Dotbot will only output the description. not the command.
- shell:
    command: echo hello world
    description: "Running hello code"

This will show "Running hello code [echo hello world]" by default. If quiet: True is set, it will just show "Running hello code". Note that it will not show the actual "hello world" output from executing echo.
If you want to see the stdout/stderr of running the command, set stdout: True and stderr: True.

Thanks again for reporting this, I updated the documentation in 043373ea74f85ff3c55a9c9f4eeb13ad7d694e71 to try to clarify what's going on here. Now there's a table that describes what the different parameters do, also explaining the difference between quiet and stdout: https://github.com/anishathalye/dotbot#format-2.
Let me know if you have any other questions or feedback.

thanks!


riot-desktop 1.6.0-1 for debian stretch was compiled against glibc 2.27

Debian stretch is on glibc 2.24: https://packages.debian.org/stretch/glibc-source
Riot desktop is segfaulting there, seems like the reason is that it was compiled against GLIBC_2.27:
$ riot-desktop
Fontconfig warning: "/etc/fonts/fonts.conf", line 100: unknown element "blank"
Seshat unexpected error: Error: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /tmp/.org.chromium.Chromium.kU3VUq)
    at process.func (electron/js2c/asar.js:140:31)
    at process.func [as dlopen] (electron/js2c/asar.js:140:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:1016:18)
    at Object.func (electron/js2c/asar.js:140:31)
    at Object.func [as .node] (electron/js2c/asar.js:149:18)
    at Module.load (internal/modules/cjs/loader.js:816:32)
    at Module._load (internal/modules/cjs/loader.js:728:14)
    at Module._load (electron/js2c/asar.js:717:26)
    at Function.Module._load (electron/js2c/asar.js:717:26)
    at Module.require (internal/modules/cjs/loader.js:853:19)
Starting auto update with base URL: https://packages.riot.im/desktop/update/
Auto update not supported on this platform
Segmentation fault

$ apt show riot-desktop
Package: riot-desktop
Version: 1.6.0-1
Priority: extra
Section: net
Maintainer<EMAIL_ADDRESS>Installed-Size: unknown
Provides: riot-web
Depends: libgtk-3-0, libnotify4, libnss3, libxss1, libxtst6, xdg-utils, libatspi2.0-0, libuuid1, libappindicator3-1, libsecret-1-0, libsqlcipher0
Replaces: riot-web
Homepage: https://riot.im/
License: Apache-2.0
Vendor<EMAIL_ADDRESS>Download-Size: 61.4 MB
APT-Manual-Installed: no
APT-Sources: https://riot.im/packages/debian stretch/main amd64 Packages
Description: A feature-rich client for Matrix.org

I'll just switch the VM I'm running riot in to a newer debian release, but possibly there are users who are on stretch and can't simply switch.

Duplicate of https://github.com/vector-im/riot-web/issues/13553


Fix for multiple recipe repos

appstudio bootstrap fail
/test jvm-build-service-in-repo-e2e

/test jvm-build-service-in-repo-with-pruning-e2e

/retest

app studio bootstrap paint
/test jvm-build-service-in-repo-with-pruning-e2e
/test jvm-build-service-e2e


Feature/Issue 660: Implement periodic covariance function

Submission Checklist

[x] Run unit tests: ./runTests.py test/unit
[x] Run cpplint: make cpplint
[x] Declare copyright holder and open-source license: see below

Summary:
Issue #660: Implement periodic covariance function
Intended Effect:
To add support for periodic covariance function
How to Verify:
Unit tests written, however lots of them are only error trivial checks. As the combination of possible argument values/types is quite huge the compilation of test/unit/math/mix/mat/fun/cov_per_test.cpp takes lot of time. Blocks of assertions of similar patterns could be grouped into common functions or macros.
Side Effects:
Only new files added, except for a following header file inclusion in stan/math/prim/mat/fun/distance.hpp:
#include <stan/math/prim/scal/fun/distance.hpp>
This was needed to propagate the distance function for scalar case. Similar approach was already used with in squared_distance.hpp
Documentation:
Added.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

Thanks for the very useful comments!
I will change the function name to cov_periodic as suggested, this is indeed more informative.
About the additional functions and the jitter parameter. These are not hard to introduce, but primarily writing the tests would take much more time. So if there would be some benefit or practical value already in the current version, maybe these developments could be shifted to a future request. Some preliminary tests have at least showed that using the written function instead of directly defining the covariance matrix using the Stan modelling language is faster.
The tests are indeed huge regardless that they are mostly only type and value checks. There are lots of repeating patterns which could be unified to the common functions though. Transparency of the tests then would somewhat reduce, but maybe that's inevitable.
I will go through all the other suggestions as well and create a new pull request when this is finished.

Some preliminary tests have at least showed that using the written function instead of directly defining the covariance matrix using the Stan modelling language is faster.

Cool beans!

These are not hard to introduce, but primarily writing the tests would take much more time.

Agreed, hold on the tests for now. I want to look at this and see if there's a way to simplify them. These tests are grueling, but it's something we want :/. There should be a simpler way.

So if there would be some benefit or practical value already in the current version, maybe these developments could be shifted to a future request.

Agreed, but this is really a function of the tests cause the implementations wouldn't be that hard.
By the way, I think your editor is using tabs. You'll want to disable those and then grep through the files to make sure none got in.
Ubuntu 16.04 and this command worked for me to find some of them: grep -P "\t" stan/math/rev/mat/fun/cov_periodic.hpp
All these Unix tools can be weird though so might haveta search around if you're using something else.

You can look at the mixed tests for arithmetic operators, like operator+ for the general framework.   Then you can look at the mixed tests for any of the vectorized unary operators for the vectorization tests.  Then there are the generated distribution tests.
The tests I have don't deal with multivariate input or output. The general framework has a lot of metaprogramming to convert arguments to vectors to use in functors that can be used for our autodiff functionals.

Is this pull request waiting for something other than a reviewer?  If not, I'd suggest @syclik or @betanalpha or @rtrangucci

@olspert, sorry no one responded to your comment! We prefer to take pull request in digestable chunks, so a separate pull request is better.

This pull request is waiting on a few things:

merging develop back into this branch
@bob-carpenter, please accept the changes or ask for additional changes
@rtrangucci, please accept the changes or ask for additional changes

Hi - looks like bob already approved this, but before the white space/formatting issues are fixed and the branches are merged can you change the function names and file names to the specification here: https://github.com/stan-dev/stan/wiki/Adding-a-Gaussian-Process-Covariance-Function
i.e. cov_periodic to gp_exp_quad_periodic_cov. There is more than one periodic covariance function, so it's good to be specific. Someone might disagree with the long name, though.

I'm dismissing @rtrangucci's review. Looks like @olspert addressed all the issues.
@drezap, are you not able to add a review? If not, those are good points and I can just use them as my review.
@olspert, there are formatting issues. Could you address them?

@syclik thanks for handling the review

This is now failing the cpplint checks. These seem legitimate. See the Jenkins logs for more details

Do I understand correctly that now it is behind cpplint checks of the unit tests. The tests are indeed too long, but the number of lines is twice as long, due to the autoformatting. What would be the suggestions to solve it while avoiding rewriting the tests?

That's right. I'm not the reviewer but I'm a bit surprised at the 25000 line test file. I'd suggest breaking up the functions as cpplint suggests - the limits are arbitrary but they definitely hint at some potential for modularization to me. Others may have other views, go with @syclik's when in doubt.

  The problem is that we don't have a testing framework for multivariate functions that makes that at all easy.
You can take my comments as suggestions and wait for the proper review from @syclik.

@olspert, I looked briefly at the test code. Here are a few comments (they're more general than line-specific comments, which is why I'm putting them here):

I do think the tests should be split apart. What might make sense is to do it based on the instantiation of the function.
For most of the tests for checking errors, I think it's sufficient to only test that one of the inputs is incorrect and throws an error. Right now, it tests all combinations with bad input. At some point, we have to trust that the logic is sound and any one error will trigger an error. Unless there's reason to believe that it won't by inspecting the code.
This is a good place for a test fixture. See googletest doc.
We should be recovering memory after each test is run. Currently, since there isn't a resetting of memory, it just builds within the mix test. It ends up with 477,219 vars on the stack by the end. We hadn't been good about this as we were originally developing the tests, but it's something we should do now. You can either stick stan::math::recover_memory() at the end of the test or put it in the test fixture.

Next step would be to break the long tests apart into groups that are reasonable.

What's the best way to pull from this merge, so I can fix these corrections and get this PR in?
I've tried adding a remote to @olspert's fork but this branch isn't showing up, also trying to pull upstream from dev/this issue, but can't seem to get it to work.

I think the reason "this branch" isn't showing up on olspert's fork is because the branch is develop :P
ideally maybe olspert also grants you write permissions to his fork or pulls your fork's changes so we can keep this same PR with its comments and history

A man of many talents, @seantalts.
@olspert would you mind granting me write permissions to your fork?

@drezap Please check if you have the write access now.

@syclik

Next step would be to break the long tests apart into groups that are reasonable.

I'm just going to go through, remove redundant tests, and then add recover_memory(). I don't see any reason why these tests cases should be 25,000 lines of code.

@olspert got it now thank you!

@drezap great!

@syclik
Looks like all of this is in a pretty good state. recovery_memory() is used and distance tests are separated... does this need anything else?

Do you mean, if rev mode is faster? I'm not sure what you mean by "this way." If there's a way to test for speed that you prefer, I can carry this out from now on. A naive way would be run the same tests for a prim version then a rev version (on a version that actually calls/is specialized by the rev version). If this is what you want, let me know, and I can run some tests.

Yes, exactly. We specialize code for reverse mode for both speed and memory, but mostly for speed.
If this code isn't faster, then it's either not implemented correctly, the native autodiff is fast enough (which seems unlikely with these sorts of operations), or it's only faster after some size (which is useful to know).
I believe Rob Trangucci had some code to benchmark this code, but if you're finding it difficult, let's link up and come up with something to benchmark it easily.

ping @rtrangucci... mind sharing the code with me?

I looked this over and the use of memory complies with the interface requirements---all of the member variables in vari instances are plain old data allocated with memalloc_.

Wonderful, I’m assuming it’s still good to have speed benchmarking?
I can fix the long tests/lint soon

On Jun 1, 2018, at 1:07 AM, Bob Carpenter<EMAIL_ADDRESS>wrote:
I looked this over and the use of memory complies with the interface requirements---all of the member variables in vari instances are plain old data allocated with memalloc_.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I just chopped up the tests for now, for give this folly, but next time I'll use the gtest test fixture/etc so we don't have have to write/ go through this many tests again, this is too cumbersome.

@bob-carpenter what about this PR?
I haven't profiled the code yet, or bench marked it, but it looks like you took a careful look at memory allocation (probably a way better job than I would do).
Does this PR require anything else? Is it also failing because of the synchronization issue? I don't want to keep wasting resources by resetting tests, if the same thing is going to happen.
I will hopefully get to profiling/benchmarking soon, as I should have been doing this the whole time.

I just dropped in some comments and approved because I'm not the reviewer for this PR.
@syclik is the one who needs to change his review status before this one can be merged.

I see we can run different tests in the pipeline here: https://github.com/stan-dev/math/wiki/Developer-Doc
but how can I run upstream tests so I can debug this?

I'm not going to have time to review all of these PRs.  And I'm not that familiar with GPs.  I was just reviewing it for use of memory.
This is still waiting for @syclik's approval, not mine.

I had @olspert send me some of the sims he ran, and numerically it’s fine. From a dev standpoint I’m having to remove ‘instance()’ to get the tests to run/models to compile on 2.17 (or whatever the last release was) so it’s not backward compatable, so probs not good to let this go through. Is there an alternative solution?

Could you say more about what the backward compatibility issue is.  We haven't been trying to maintain deep backward compatibility in the math lib, just at the top level functions.  So if implementation details change under the hood, it's no big deal, even if they're not technically backward compatible.
I see that distance(x[i], x[j]) is continually being recalculated as part of gp_periodic_cov.  Was there a discussion about an interface that took in a (triangular) matrix of pairwise distances?  Those could be computed once in the transformed data block and it would save a lot of arithmetic.

@bob-carpenter back compatability: just what I described the above: I'm using cmdstan 2.17 for testing, and I have to change the call to access the autodiff stack (instead of .instance() use ::memalloc()) for the models to compile. How worried should I be about this?
triangular matrix: not sure, but seems like something I could knock out. I couldn't find an issue in stan/math with some key words. If you throw up an issue with a function signature, I'm happy to implement something.

Thanks for the clarification. That’s one of the things that we shouldn’t
expect to be backwards compatible. But.... there should be 0 places in
CmdStan that call that directly. If it does, then it’d be great to know so
we can fix it.
On Tue, Jun 19 2018 at 12:32 AM<EMAIL_ADDRESS>wrote:

@bob-carpenter https://github.com/bob-carpenter back compatability:
just what I described the above: I'm using cmdstan 2.17 for testing, and I
have to change the call to access the autodiff stack (instead of
.instance() use ::memalloc()) for the models to compile. How worried should
I be about this?
triangular matrix: not sure, but seems like something I could knock out. I
couldn't find an issue in stan/math with some key words. If you throw up an
issue with a function signature, I'm happy to implement something.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/677#issuecomment-398271218, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_F6iNqp9ecRzc98LiLgTa4BaL2jwXks5t-H7agaJpZM4QdeXw
.

@syclik mind taking a look at this? On github it says tests are failing, but it has passed all tests and is only "failing" because doxygen upload is skipped in the pipeline.
Thanks!

Something weird is happening with this one... Could you try merging in develop?

@seantalts I did this earlier. When I just do a commit I'm alway getting propogate false to ignore and it fails upstream tests, but when I go into the old jenkins and "rebuild w parameters" it passes everything..

That's very weird, I'll take a look...
On Mon, Jun 25, 2018 at 11:57 drezap<EMAIL_ADDRESS>wrote:

@seantalts https://github.com/seantalts I did this earlier. When I just
do a commit I'm alway getting propogate false to ignore and it fails
upstream tests, but when I go into the old jenkins and "rebuild w
parameters" it passes everything..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stan-dev/math/pull/677#issuecomment-400003230, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxJ7CHZZtUUNCJOiS4sOdP5lZ-Wd-Itks5uAQhVgaJpZM4QdeXw
.

--
Via smol keyboard

@seantalts thanks! please let me know, I'm going to leave it when I get it to a state where it's passing upstream... daniel agreed to review it. I just want this to go through before other PRs

Hey @drezap, I have like 85% confidence this is due to a bug in Jenkins from around when this PR was first submitted - I think we'd have to close it and open a new PR to get around it, ironically. I would suggest we just manually "Build with parameters" each time we want to test it, assuming it's done or almost done at this point.

@seantalts OK.. I'm going to close and re-open. At least we will know more where the issue is then. I'll include a link to this in the PR for comment history.
At this point I'm just wasting resources, restarting Jenkins test waiting for the small probability the bug doesn't occur.

oh  can't close this... @olspert mind closing this, due to the reasons above? Thank you!


DeleteAll() and ModifyAll() with RunTrigger=true don't use the record instance's global variables

Describe the bug
The title says it all. I set a global boolean in a record variable to true, and then only allow modification in OnModify() if said boolean is true. This works if OnModify() is invoked via calling Modify(true).
It does not work if invoked via calling ModifyAll(SomeField, SomeValue, true). It should, shouldn't it?
N.B. This might affect other *All() methods. Please check and address those too if required.
To Reproduce

Set a global variable in a record instance, to a non-zero/non-default value
Call ModifyAll() with RunTrigger := true
See that when OnModify() fires from ModifyAll(), the global variable has its zero/default value, not the one you set.

tableextension 50100 Customer extends Customer
{
    var
        CanModify: Boolean;

    internal procedure SetCanModify(NewCanModify: Boolean)
    begin
        CanModify := NewCanModify;
    end;

    trigger OnModify()
    var
        Err: Label 'Someone set up us the bomb';
    begin
        if not CanModify then
            Error(Err);
    end;
}

pageextension 50100 CustomerListExt extends "Customer List"
{
    trigger OnOpenPage();
    var
        Customer: Record Customer;
    begin
        Customer.FindFirst();
        Customer.SetCanModify(true);

        Customer.Modify(true); // respects above call to SetCanModify()

        Customer.SetRecFilter();
        Customer.ModifyAll(Name, Customer.Name, true); // does not!!!!!
    end;
}

Expected behavior
I expect that any functions invoked on a particular record variable instance will see the same global variables as each other, set on that instance - not that *All() will somehow end up calling triggers on a different instance with its own, different global variable values.
(Even if this were meant to work like pages, where each record row has its own copy of the set of global variables, that doesn't make sense here for tables, and it can't be the case anyway because as you can see I deliberately call to modify the same customer as I found.)
5. Versions:

AL Language: 6.6.425415
Business Central: GB Business Central 17.4 (Platform 17.0.21485.22555 + Application 17.4.21491.21531)

Does anyone think this is likely to get fixed any time soon? It's a pain and means writing less efficient (in terms of SQL and number of lines) code.
I can now confirm it's broken for DeleteAll() too:
tableextension 50100 Customer extends Customer
{
    var
        CanDelete: Boolean;

    internal procedure SetCanDelete(NewCanDelete: Boolean)
    begin
        CanDelete := NewCanDelete;
    end;

    trigger OnBeforeDelete()
    var
        Err: Label 'Who ya gonna call?!?';
    begin
        if not CanDelete then
            Error(Err);
    end;
}

pageextension 50100 CustomerListExt extends "Customer List"
{
    trigger OnOpenPage();
    var
        Customer: Record Customer;
    begin
        Customer.FindFirst();
        Customer.SetRecFilter();
        Customer.SetCanDelete(true);
        Customer.DeleteAll(true); // bust.
    end;
}

and still as of
Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 7.1.441584
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

It seems this was always a problem: https://dynamicsuser.net/nav/f/developers/11613/global-variables-on-record

pdj over 16 years ago
The problem is use of DELETEALL. It initiates all global variables for each record. Instead you will have to make you own FIND-REPEAT-SetGlobal-DELETE(TRUE)-NEXT loop.

So, is this a bug, or must it be treated as an unfortunate fact of life due to its age? If the latter, can this trap be clearly documented? If the former, can we get an idea of when we might expect global variables to persist through *All() calls?

Hello? Is there anyone from MS out there?

@thloke was very busy here recently ;-)

Yes, we're trying to get through our backlog of issues. (: ...we have a lot to get through, unfortunately. ):
Now looking at this issue specifically - it seems like this is an issue on how triggers are handled in the server runtime rather than something we can address from the compiler side. We'll need someone from the runtime team to look at it. This means:

We'll need them to pass judgement on if it is a bug or not.
I can't give an estimate on when they can fix it.
Technically it's also out of scope of this repository.

Your best bet to get attention for this is to raise a support case or collaborate request. Considering the age of the issue, it almost certainly needs some external action to be addressed.
Sorry that I can't give you a better resolution than "try another avenue". I can raise it with the team internally, but they'll need more input to prioritise an old bug.
As far as documentation goes, that I can do for you. :) ..I will accept this bug on our team with the scope of just fixing the documentation.

I have filed on Partner Center as ticket<PHONE_NUMBER>003329

@dnpb Please keep us updated regarding your support case :-)

Will do! So far I have this:

Thank you for reporting this, and for providing repro. As development suggest in the Github link, I will take it to them for more analysis. I did repro on BC14 as well, using C/AL, so the behaviour is not new, and I suspect that it may be by design, or if not then high risk to change, as it can affect unknown existing installations. But I will get at least some input from development, and then get back to you,

Here's today's reply from Lars at MS:

I have some input from development now. This behaviour dates back at least to 2007. To change it now would be a breaking change with unknown consequences. As a workaroud we can use MODIFY instead. I know that a workaroud for MODIFYALL to not use MODIFYALL is a pretty lousy workaroud, but it is a lesser risk than changing platform behaviour.
Sorry I can't get you a better solution to this but I hope you also understand this view.

and my reply:

I thought that might be the case, and you might not be able to change it without risking unexpected breakage (or fixing? 😊) in other developers’ code.
This should definitely be clearly documented for Record.ModifyAll(), Record.DeleteAll() and RecordRef.DeleteAll() though – to avoid other developers getting confused like me, by knowing in advance that their global variables will be ignored/initialised by said methods.
At https://github.com/microsoft/AL/issues/6515 Thaddeus said they would accept it on that side to fix the docs, so I guess that’s your side done? 😉

It has now been documented as "by design" in the docs:

https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/methods-auto/record/record-deleteall-method#remarks
https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/developer/methods-auto/record/record-modifyall-method#remarks

Great! Thanks all.


Milestone1

Setup And Mobile Version Skeleton -Milestone 1
I received the comments from my code reviewer and mistakenly closed the first pull request and now I realized that I was not supposed to close the pull request, in this pull request I made the below changes.

Changed the color of the menu icon to white as per Figma standard
managed the space  between header and content section
removed extra space in my all files

@aliabbani Sorry for the inconvenience,
I have made the bellow changes in my project.
Changed the color of the menu icon to white as Figma design
manage the space between header and content section

@aliabbani Sorry for the inconvenience, I have made the bellow changes in my project. Changed the color of the menu icon to white as Figma design manage the space between header and content section

Do not worry at all. Good job implementing the changes. Keep it up 🥇


Issues with proxy and Spotify?

I installed Audioband and got my developer app setup all good and have it on the taskbar and using Spotify as a source.
I am behind a proxy so I matched the proxy data in the Spotify settings with the info in the Audioband settings.
I have made sure that I have the http://localhost:80 in my Redirect URLs page, along with others varying the http(s) and other ports (8081, 8381) and set the port accordingly in Audioband
But when Spotify plays, no song info appears on Audioband.  Any ideas how to debug?  How can I check for a good port to use?  Is it something wrong with the proxy?  Not sure where to go on this
Thanks!

Ah, finally found the log file.  This is the issue.  Is it an issue with the proxy server not admitting Audioband?  Or a firewall?
2019-07-10 15:41:18.5322|ERROR|AudioSource(Spotify)|System.Net.Http.HttpRequestException: An error occurred while sending the request. ---> System.Net.WebException: Unable to connect to the remote server ---> System.Net.Sockets.SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond <IP_ADDRESS>:443
at System.Net.Sockets.Socket.InternalEndConnect(IAsyncResult asyncResult)
at System.Net.Sockets.Socket.EndConnect(IAsyncResult asyncResult)
at System.Net.ServicePoint.ConnectSocketInternal(Boolean connectFailure, Socket s4, Socket s6, Socket& socket, IPAddress& address, ConnectSocketState state, IAsyncResult asyncResult, Exception& exception)
--- End of inner exception stack trace ---
at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult)
at System.Net.Http.HttpClientHandler.GetResponseCallback(IAsyncResult ar)
--- End of inner exception stack trace ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at SpotifyAPI.Web.SpotifyWebClient.d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at SpotifyAPI.Web.SpotifyWebClient.d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at SpotifyAPI.Web.SpotifyWebClient.d__131.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at SpotifyAPI.Web.SpotifyWebAPI.<DownloadDataAsync>d__2271.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at SpotifyAudioSource.SpotifyAudioSource.d__90.MoveNext() in d:\a\1\s\src\SpotifyAudioSource\SpotifyAudioSource.cs:line 373
---START OF EXCEPTION---

Sorry about the confusion. Adding proxy settings is an old issue that I kind of forgot about #69. But since you've reminded me, I'll get an update on it.

You are dope. Thanks!

Have you been able to make progress on the proxy issue?

Yep, I was relying on the spotify library to add some required proxy features and the good news is that it has since been added. I just haven't integrated the required changes yet.

The previous update didn't have all the changes needed so I still need to wait for another update.


Meteor version

Dear Andre,
Is it possible to update the meteor package to the latest version of techan
Kind regards
Gerardo C.

Hi @gerardocarrera
I don't use meteor and I also don't see atmosphere as a supported travis deployment provider. What's the general process? Can it be automated?
cheers
andre


Create greetings.yaml

Added for #7

Could you please add the labels to it considering its technicalities.

Please assign this PR to me.


Transformer v2 fails when converting a table with an index on a primaryKey

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm -g
If applicable, what version of Node.js are you using?
14.18.1
Amplify CLI Version
7.6.3
What operating system are you using?
OSX 12
Amplify Categories
api
Amplify Commands
push
Describe the bug
I'm attempting to migrate to Transformer Version 2 (amplify api migrate) in order to perform some other GraphQL updates via amplify push.
Once the new schema has been generated, any amplify push (on a new environment) end up breaking with the following error:
✖ An error occurred when pushing the resources to the cloud
🛑 Could not fetch keySchema for Model.
InvalidDirectiveError: Could not fetch keySchema for Model.
    at AuthTransformer.protectListResolver (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/@aws-amplify/graphql-auth-transformer/src/graphql-auth-transformer.ts:499:13)
    at AuthTransformer.generateResolvers (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/@aws-amplify/graphql-auth-transformer/src/graphql-auth-transformer.ts:326:16)
    at GraphQLTransform.transform (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/@aws-amplify/graphql-transformer-core/src/transformation/transform.ts:252:21)
    at _buildProject (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/graphql-transformer/transform-graphql-schema.ts:564:37)
    at buildAPIProject (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/graphql-transformer/transform-graphql-schema.ts:521:24)
    at transformGraphQLSchema (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/graphql-transformer/transform-graphql-schema.ts:394:29)
    at Object.run (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/push-resources.ts:166:5)
    at async Promise.all (index 0)
    at providersPush (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/extensions/amplify-helpers/push-resources.ts:139:3)
    at AmplifyToolkit.pushResources [as _pushResources] (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/extensions/amplify-helpers/push-resources.ts:96:9)
    at Object.executeAmplifyCommand (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/@aws-amplify/amplify-category-api/src/index.ts:222:5)
    at executePluginModuleCommand (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:204:3)
    at executeCommand (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:30:5)
    at Object.run (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/index.ts:205:5)

Digging into the amplify cli code a bit and performing various console debugs, it looks like an @index has been created on the @primaryKey in the schema, but the @index gets ignored.
Original schema:
type Model
@model
@auth(rules: [
  {allow: public, provider: apiKey}
])
@key(name: "byUser", fields: ["user", "channel"], queryField: "listModelsByUser")
@key(name: "byChannel", fields: ["channel", "user"], queryField: "listModelsByChannel")
@key(fields: ["user", "channel", "token", "secret"])
{
  user: String!
  channel: String!
  token: String!
  secret: String
}

Transformed schema:
type Model @model @auth(rules: [{allow: public, provider: apiKey}]) {
  user: String! @primaryKey(sortKeyFields: ["channel", "token", "secret"]) @index(name: "byUser", queryField: "listModelsByUser", sortKeyFields: ["channel"])
  channel: String! @index(name: "byChannel", queryField: "listModelsByChannel", sortKeyFields: ["user"])
  token: String!
  secret: String!
}

The table.globalSecondaryIndexes only contains the byChannel index and throws the InvalidDirect exception.
Expected behavior
amplify push should succeed, finding all available indexes
Reproduction steps
Create the following table using v1 transformer:
type Model
@model
@auth(rules: [
  {allow: public, provider: apiKey}
])
@key(name: "byUser", fields: ["user", "channel"], queryField: "listModelsByUser")
@key(name: "byChannel", fields: ["channel", "user"], queryField: "listModelsByChannel")
@key(fields: ["user", "channel", "token", "secret"])
{
  user: String!
  channel: String!
  token: String!
  secret: String
}

Run amplify push
Run amplify api migrate
Run amplify push
GraphQL schema(s)

# Put schemas below this line

type Model
@model
@auth(rules: [
  {allow: public, provider: apiKey}
])
@key(name: "byUser", fields: ["user", "channel"], queryField: "listModelsByUser")
@key(name: "byChannel", fields: ["channel", "user"], queryField: "listModelsByChannel")
@key(fields: ["user", "channel", "token", "secret"])
{
  user: String!
  channel: String!
  token: String!
  secret: String
}

Log output

# Put your logs below this line

✖ An error occurred when pushing the resources to the cloud
🛑 Could not fetch keySchema for Model.
InvalidDirectiveError: Could not fetch keySchema for Model.
    at AuthTransformer.protectListResolver (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/@aws-amplify/graphql-auth-transformer/src/graphql-auth-transformer.ts:499:13)
    at AuthTransformer.generateResolvers (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/@aws-amplify/graphql-auth-transformer/src/graphql-auth-transformer.ts:326:16)
    at GraphQLTransform.transform (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/@aws-amplify/graphql-transformer-core/src/transformation/transform.ts:252:21)
    at _buildProject (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/graphql-transformer/transform-graphql-schema.ts:564:37)
    at buildAPIProject (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/graphql-transformer/transform-graphql-schema.ts:521:24)
    at transformGraphQLSchema (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/graphql-transformer/transform-graphql-schema.ts:394:29)
    at Object.run (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/amplify-provider-awscloudformation/src/push-resources.ts:166:5)
    at async Promise.all (index 0)
    at providersPush (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/extensions/amplify-helpers/push-resources.ts:139:3)
    at AmplifyToolkit.pushResources [as _pushResources] (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/extensions/amplify-helpers/push-resources.ts:96:9)
    at Object.executeAmplifyCommand (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/node_modules/@aws-amplify/amplify-category-api/src/index.ts:222:5)
    at executePluginModuleCommand (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:204:3)
    at executeCommand (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/execution-manager.ts:30:5)
    at Object.run (/Users/.nvm/versions/node/v14.18.1/lib/node_modules/@aws-amplify/cli/src/index.ts:205:5)

Additional information
Help me Obi Wan Kenobi ⚔

@alexhouse I'm not able to reproduce the issue. First, I created a new project and deployed the v2 schema you provided. That went through fine.
Next, I created another new project using the v1 schema you provided. There are a couple issues with the provided schema. There is no deviceToken or expoPushToken field in the schema. For the v1 primary key, I used the fields user, channel, and token, since the provided schema was unclear. Once I corrected those errors, I was able to migrate and push the schema just fine.

Hmm.
In my attempt to provide a simple table to reproduce the issue I messed up. I've edited the OP with the correct schemas.
I've just noticed that the byUser key is currently labelled as a local secondary instead of a global secondary within DynamoDB... that may well be the cause of the errors. I have a feeling that the only way of making a local key global is to fully recreate the table, right? Which would then require all data to be upserted somehow (batch operations?)


addBabelPlugin not inserting the plugin

Hello,
the current implementation doesn't insert the plugin (in my case I tried with addBabelPlugin(['emotion'])(config)).
This doesn't match the babel-loader :
Array.isArray(r.use) && r.use.some(u => u.options && u.options.babelrc != void 0)

because the babel-loader doesn't have a use key.
The two characteristics I use to spot the right babel-loader (there are 2 of them) are :

The loader name contains "babel-loader"
It has a "customize" key

function addBabelPlugin(plugin) {
  return function(config) {
    const babelLoader = config.module.rules
      .find(rule => Object.keys(rule).includes('oneOf'))
      .oneOf.find(
        rule =>
          rule.loader &&
          rule.loader.includes('babel-loader') &&
          rule.options.customize
      )

    babelLoader.options.plugins.push(plugin)

    return config
  }
}

the issue might be the declaration here https://github.com/arackaf/customize-cra/commit/57bb094e141b547fcaf0e4f15a46f0b4565ae5be#diff-168726dbe96b3ce427e7fedce31bb0bcR16

I was facing the same issue and I did a little further investigation to understand the problem. Hope that can helps.
I was using the react-scripts version 2.0.3, that was released two days ago (Oct, 1th). There was a PR #5170 merged two days before the release where they removed the thread-loader. That PR changed the shape of the configuration object, removing the use array from the babel loader rule.
That means that the current version of the customize-cra works well for<EMAIL_ADDRESS>versions but it doesn't work for the version 2.0.3.
To avoid a breaking change for the users using versions 2.0.0, I came up with a version of the addBabelPlugin that is able to handle both versions.
function addBabelPlugin(plugin, config, env) {
  const babelLoaderFilter = rule =>
    rule.loader && rule.loader.includes('babel') && rule.options && rule.options.plugins;

  // First, try to find the babel loader inside the oneOf array.
  // This is where we can find it when working with<EMAIL_ADDRESS>  let loaders = config.module.rules.find(rule => Array.isArray(rule.oneOf)).oneOf;

  let babelLoader = loaders.find(babelLoaderFilter);

  // If the loader was not found, try to find it inside of the "use" array, within the rules.
  // This should work when dealing with<EMAIL_ADDRESS>versions.
  if (!babelLoader) {
    loaders = loaders.reduce((ldrs, rule) => ldrs.concat(rule.use || []), []);
    babelLoader = loaders.find(babelLoaderFilter);
  }

  babelLoader.options.plugins.push(plugin);

  return config;
}

That code is not fully tested. I've only done some simple test against the versions 2.0.3 and 2.0.0-next.fb6e6f70 (the lastest 2.0.0.next.* version). Probably more tests would be necessary before using it as the actual implementation.

try to use my fork :
https://github.com/war3k/customize-cra

@war3k Thanks, it works! You should probably send a PR with the changes given.

sure, I already did that :)

Seems Dan Abramov moved my cheese :P
@walmor's fix is updated for the new 0.1.X api, and released under 0.1.0-beta4.


Shaka Player Resolution labels.

I want to change the resolution labels,for example  for 720p I want to keep it "High". Is it possible with shaka-ui?
Please tell me a way how to do it if its possible!

There is no way to customize it, but you can modify it at https://github.com/shaka-project/shaka-player/blob/main/ui/resolution_selection.js#L236 Sorry!


Test: node2 - General bugbash

[ ] any OS @weinand
[x] any OS @sandy081

Effort: 3
There are a ton of little things that changed in the past month and it will be very helpful to do another general pass. Just spend a little time with it doing anything. At this point, basically anything that works in node-debug should also work in node-debug2.
From the previous testplan-item -

There are a million scenarios we need to support, so the most valuable thing you can do is grab any random Node project that you might have debugged with VS Code in the past, change "type" to "node2", and see what happens. If anything happens that isn't the same as "node", is it obvious to figure out what's wrong?
More specific things to try, don't need to do every single one:
Try some things that are checked off at Microsoft/vscode-node-debug2#7
Ensure it kills the process when terminating a launch config, but not an attach
Set breakpoints before launching, and ensure they bind
In the main script, and in scripts that are loaded later
Look in the variables pane at different types and compare it to what you'd expect
Test very large arrays and other stress cases
It might get slow but it shouldn't crash
Test with and without sourcemaps
Attach config with a running process (start with --inspect=9229)

@mousetraps


Server-side rendering with shared vue components in yarn workspace results in "Cannot find module"

Version
v2.11.0
Reproduction link
http://n.a
Steps to reproduce
This is all inside one folder, to reproduce the exact error message it would live at /home/myuser/repos/core

Create a folder structure like common/vue/components/atoms/ with box.vue at the top and a package.json at common/vue defining the name as common-vue
Create a folder structure like example/test containing a nuxt project
Add both as yarn workspaces
In the nuxt project, import the common vue component with import EBox from 'common-vue/components/atoms/box';
Run nuxt dev or build/run commands

What is expected ?
The site works as expected, showing the shared vue component
What is actually happening?
You see a page with a NuxtServerError stating:
Cannot find module 'common-vue/components/atoms/box' from '/home/myuser/repos/core/example/test'
Additional comments?
We tried quite a few things:

Replacing the yarn created symlinks in node_modules with an actual copy of the respective folder
Setting rootDir, modulesDir and webpack's nodeExternals to various combinations, sometimes managing to change the error to Cannot find module 'common-vue/components/atoms/box' from '/home/myuser/repos/core/' (i.e. pointing to where the root level node_modules are)
Setting the bundleRenderer's baseDir

My best guess right now is that it is tied to vue-ssr's externals config that only whitelists css by default as documented here. I sadly can't find whether/where nuxt sets this value and didn't find a way to override it.

Got the same problem when tried to separate our project to multiple packages (mono repository) (with multiple nuxt instances and balancer between them)
Tried to move main dependencies in packages/common and import them from packages/project1 | packages/project2 - and got same error:
Cannot find module 'vue' from '...\packages\project1'

same

same

Hi! I will share a demo repository soon :)

Having the same issue, also using Nuxt TypeScript, but seems to be an issue even without it.
@pi0 did you share a demo repository anywhere, or would you like me to create one?

Here's an example repository (it's using TypeScript & Lerna thought, but I'm pretty sure it's the same underlying issue)
https://github.com/RobinBertilsson/nuxt-lerna-6929
Steps to reproduce

Clone the repository
Run yarn && yarn lerna bootstrap
Open it in your browser
The error should appear
Switch mode inside nuxt.config.ts from universal to spa
The error should NOT appear

Can also confirm that it's still an issue on the latest release, sadly 😢

same issue here, did anyone get any fix for TypeScript & Lerna

Alright, I've made some progress on this issue.
I created a super simple structure following the original reproduce steps.
Folder structure
common
   components/Box.vue
   index.js
   package.json
web
   pages/index.vue
   nuxt.config.js
   package.json
package.json

My initial idea was to export my shared components from the index.js inside the common project, just like this.
import Box from './components/Box.vue'

export {
   Box,
}

And then just import it with import { Box } from 'common'.
But that doesn't quite work, getting another issue with that using JS, and when using TS the compiler complains about not being able to compile TypeScript, even though it's valid...
Anyhow, I found a solution that actually works, simply provide the full path to your "shared" Vue component.
For example:
import Box from 'common-vue/components/Box.vue'

Note, adding ".vue" is the key here, works for both TypeScript and JavaScript.
Not the most perfect solution, but it does work, and will let you use the universal mode.

Last update, because this is probably the solution i'll end up using.
Since Nuxt 2.13 they introduced component autodisovery, meaning you can just reference your package directly.
nuxt.config.js
components: [
   '~/components',
   'common-vue'
]

Just ran into this issue today and spent that last 3-4 hours trying to fix it! 😞
None of the workarounds are remotely ideal. The one I've decided to go with is to define common-vue as an alias that points directly to the project folder:
build: {
  extend(config, ctx) {
    config.resolve.alias = {
      ...config.resolve.alias,
      'common-vue': path.resolve(__dirname, '../common-vue'),
    };

Also, need a similar path mapping in tsconfig.json for TypeScript projects:
{
  "compilerOptions": {
    ...
    "paths": {
      ...

      "common-vue/*": ["../common-vue/*"]
    },

It's important that common-vue isn't symlinked into node_modules. In my case, I actually defined my alias with a different name (e.g. common-vue-alias) so that I don't forget to fix it properly once there's a better solution. Speaking of which…
Anyone know a better solution? Like I said, none of the workarounds are ideal, and having a shared component library in a monorepo must be a common use case. Is it not?

@Merott, I totally agree with you, it's far from an ideal solution.
But in our case, the component discovery works fine meaning we'll go for that one until we have another option.
And thanks for sharing your solution, I just find it a bit more hacky than using the component discovery, which is a feature Nuxt actually serves & maintains. That's basically the only reason I went with that solution.
Component discovery reduce imports is quite nice, they're taking up quite a lot of space in your Vue files, surprises me how well it's actually working.

Hi! I will share a demo repository soon :)

We waiting for your demo still.
please I have issues the type of use component   see issues

About this, I solve solation by some config.
After setup lerna.js and yarn workspace for each package in nuxt.config.js set
  modulesDir: ['../../node_modules']
my directory
├─--packages
│   ├── system-design
│   │  ├── **/*.css
│       ├── package.json
├── public
│   ├── css
│   ├── images
│   ├──nuxt.config.js
│   ├── package.json
├── node_modules
├── package.json
├── yarn-lock.json
└── .gitignore

then for link system design to the public, I run this command to the public directory
lerna add @xx-front/system-design  --scope=@scrop-front/public

finally, import my vue component in public component by
import XComponent from<EMAIL_ADDRESS>
but for short than src you also can add alias in nuxt.config
  alias: {
    '@design-system': resolve(__dirname, '../../node_modules/@xxx-front/design-system'),
  }

I hope usefiule.

We are approaching the Nuxt 2 EOL date (June 30, 2024) - see this article for more information. This is advance warning that I'm going to close this issue then, as it's currently marked as a Nuxt 2 related bug.
If it's a critical or security issue, please do comment and let me know, in case it is possible to address it before the EOL date.
If it's a an issue you think is relevant for Nuxt 3, please feel free to open a fresh issue (or just comment here so I can update labels, etc.). 🙏
Thank you for your understanding and for your contribution to Nuxt. ❤

It's the day, at last. Nuxt 2 is now marked end-of-life.
My apologies we never got round to resolving this bug in the 2.x branch, but we do have to draw a line somewhere. Again, if you think this is still relevant for Nuxt going forward, please feel free to open a fresh issue (or just comment here so I can update labels, etc.). 🙏


Button not working with the latest version of YouTrack

Toggl no longer works with the latest YouTrack version. YouTrack recently updated (a week ago?) and now it is not possible to trigger a Toggl timer from within a YouTrack issue like it used to be possible.

Extension version: 1.11.2

This is now fixed in #1160. @maritoggl


Performing the operation "Drop-Database" on target "database '' on server ''".

Ah, this was regressed by the Get-DbContext. Drop-Database relied on getting the information for the only DbContext when one wasn't specified.

(We changed it to return a list of all the DbContext classes when none was specified)


Fixes for GKE

Fix non-empty plan when spot instances are used
Add cluster_id and recommend its use, as this prevents inconsitencies when only cluster is recreated (with no changes on node pool)

Thanks you !


git repo is hardcoded to devlace/mdw-dataops-clone in CI artifacts pipeline

the git repo is hardcoded to devlace/mdw-dataops-clone in the
https://github.com/Azure-Samples/modern-data-warehouse-dataops/blob/master/e2e_samples/parking_sensors/devops/azure-pipelines-cd-release.yml pipeline

Noticed that this was replaced in the deploy script... sorry for the confusion

Noticed that this was replaced in the deploy script... sorry for the confusion


Add support for Terraform 0.13

also, 0.14 alpha is out...

Hi @bhundven
This module should be compatible with 0.13 (even 0.14-alpha) as we only require a version >= 12.0. Did you run into any incompatibilities during its usage with 0.13?

Huh, I tested this a month ago, and got a version error. Tried again with 0.13.1, works fine now. :shrug:
I'm also looking to make the firewall creation optional. For a project I have, the firewall rules are managed by another deployment. I'll open a issue/PR soon. (same for lb-internal)


[SPARK-19152][SQL][followup] simplify CreateHiveTableAsSelectCommand

What changes were proposed in this pull request?
After https://github.com/apache/spark/pull/16552 , CreateHiveTableAsSelectCommand becomes very similar to CreateDataSourceTableAsSelectCommand, and we can further simplify it by only creating table in the table-not-exist branch.
This PR also adds hive provider checking in DataStream reader/writer, which is missed in #16552
How was this patch tested?
N/A

cc @gatorsmile @windpiger

Test build #71933 has started for PR 16693 at commit db00cf9.

Test build #71933 has finished for PR 16693 at commit db00cf9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71933/
Test PASSed.

LGTM except two minor comments in the error messages.

@gatorsmile thanks for adding comments about why the cleanup is safe!

Test build #72022 has started for PR 16693 at commit f4a9342.

Test build #72022 has finished for PR 16693 at commit f4a9342.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72022/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

retest this please

ok to test

Test build #72109 has started for PR 16693 at commit f4a9342.

Test build #72109 has finished for PR 16693 at commit f4a9342.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72109/
Test PASSed.

Thanks! Merging to master.


ImportError: dlopen: cannot load any more object with static TLS

try import with
python -c "import mmdet3d"

get dlopen error with following error stack
File "<string>", line 1, in <module>
  File "/home/szy/Point-Clound/mmlab/mmdetection3d/mmdet3d/__init__.py", line 2, in <module>
    import mmcv
  File "/home/anaconda3/envs/openmmlab/lib/python3.8/site-packages/mmcv/__init__.py", line 4, in <module>
    from .fileio import *
  File "/home/anaconda3/envs/openmmlab/lib/python3.8/site-packages/mmcv/fileio/__init__.py", line 2, in <module>
    from .file_client import BaseStorageBackend, FileClient
  File "/home/anaconda3/envs/openmmlab/lib/python3.8/site-packages/mmcv/fileio/file_client.py", line 15, in <module>
    from mmcv.utils.misc import has_method
  File "/home/anaconda3/envs/openmmlab/lib/python3.8/site-packages/mmcv/utils/__init__.py", line 41, in <module>
    from .env import collect_env
  File "/home/anaconda3/envs/openmmlab/lib/python3.8/site-packages/mmcv/utils/env.py", line 9, in <module>
    import cv2
  File "/home/anaconda3/envs/openmmlab/lib/python3.8/site-packages/cv2/__init__.py", line 181, in <module>
    bootstrap()
  File "/home/anaconda3/envs/openmmlab/lib/python3.8/site-packages/cv2/__init__.py", line 153, in bootstrap
    native_module = importlib.import_module("cv2")
  File "/home/anaconda3/envs/openmmlab/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ImportError: dlopen: cannot load any more object with static TLS

the question above seems to be an error of importing cv2, however python is ok when executing the following code, which is confusing.
python -c "import cv2"

basic enviorment
centos7
python3.8
pytorch1.9.0+cu102

I have sussessfully run pcd_demo.py before I update glibc to 2.18  for the using of open3D for visualization. However after updating gblic, the above question ocurred.

I'm sorry, this is just a problem lies in the interaction of glibc with "python import mechanisms":

it seems that when python import other packages, it well using multi-threading, however, low-version glibc may restrict the number of threads，which cause the above question.

So for anyone facing samiliar problem. I suggest updating glibc to 2.28.


bug(python):  LanceDB S3 Data Source Index Not Exist Issue for Hybrid Search With Colbert Reranking

LanceDB version
^0.6.10
What happened?
 File "/Users/mohd.javed/Documents/go/GitHub/service/.venv/lib/python3.11/site-packages/lancedb/query.py", line 245, in to_df
    return self.to_pandas()
           ^^^^^^^^^^^^^^^^
  File "/Users/mohd.javed/Documents/go/GitHub/service/.venv/lib/python3.11/site-packages/lancedb/query.py", line 262, in to_pandas
    tbl = self.to_arrow()
          ^^^^^^^^^^^^^^^
  File "/Users/mohd.javed/Documents/go/GitHub/service/.venv/lib/python3.11/site-packages/lancedb/query.py", line 810, in to_arrow
    fts_results = fts_future.result()
                  ^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 456, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 401, in __get_result
    raise self._exception
  File<EMAIL_ADDRESS>line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mohd.javed/Documents/go/GitHub/service/.venv/lib/python3.11/site-packages/lancedb/query.py", line 670, in to_arrow
    raise FileNotFoundError(
FileNotFoundError: Fts index does not exist. Please first call table.create_fts_index(['<field_names>']) to create the fts index.

we connect vectorDB from our s3 bucket like this.
lancedb.connect("s3://bucket_name/path_name")
and then query
self.table.search(query, query_type="hybrid").limit(10).rerank(reranker=self.reranker).to_df()
Our As we are using hybrid search with colbert reranking and it internally uses both FTS and vector search and then normalise to give the best chunks on the basis of relevance score. As it uses FTS search so we need to create a FTS index in the table at the time of its creation and we are already doing this.
Now as we see we already created the FTS index at the time of tables creation but still on searching we are getting the index not exists error.
Root Cause
I checked the internal codebase of hybrid search lancedb and this is how they check if the index exists or not
// get the index path
index_path = self._table._get_fts_index_path()
// check if the index exist
 if not Path(index_path).exists():
            raise FileNotFoundError(
                "Fts index does not exist. "
                "Please first call table.create_fts_index(['<field_names>']) to "
                "create the fts index."
            )

_get_fts_index_path returns s3://bucket_name/path_name/table_name.lance/_indices/tantivy which is fine and this path exists in the s3 bucket as well but the way they check path seems to be a bug in lancedb library.
Path(index_path).exists() works only for checking local system path and not s3 as our lancedb source is S3 bucket.
Are there known steps to reproduce?

Use S3 as data store for lanceDB
Use Hybrid Search With Colbert Reranking.
Run Query.

Hi @mohdjaved99. LanceDB hybrid search relies on there being an full-text search (FTS) index. Unfortunately, FTS indices aren't supported on object stores such as S3 yet. Adding support for this is on our roadmap https://github.com/lancedb/lancedb/issues/1121 for this year though. I hope to have that released sometime around the end of summer.

I've created a fix to make the error clearer: https://github.com/lancedb/lancedb/pull/1273

thanks for the response @wjones127.


Wait to dispose RequestAborted CTS

A redo of https://github.com/aspnet/AspNetCore/pull/4447.
When we tried this PR before, it caused a pretty nasty deadlock between Reset and Cancel in HttpProcotol. This should avoid it by capturing the CTS in a local inside of the lock and then cancelling outside of the lock.
This change will eventually be applied to IIS (and then I'd probably add a helper because the pattern will be the same). However, I want to make sure this change stabilizes on CI and doesn't have flakiness.
If this change works well, we should consider porting it back to 2.2.x.

Fixes https://github.com/aspnet/AspNetCore/issues/4422

🆙 📅 . IMO this change is ready to go :shipit:


add base Tokenizer

Codecov Report

Merging #68 (67f05e0) into main (c7226be) will decrease coverage by 0.75%.
The diff coverage is 55.55%.

:exclamation: Current head 67f05e0 differs from pull request most recent head 5b16583. Consider uploading reports for the commit 5b16583 to get more accurate results

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   94.10%   93.34%   -0.76%
==========================================
  Files          47       48       +1
  Lines        2020     2015       -5
==========================================
- Hits         1901     1881      -20
- Misses        119      134      +15

Impacted Files
Coverage Δ

src/hearth/text/tokenizers.py
55.55% <55.55%> (ø)

src/hearth/vision/ops.py
93.33% <0.00%> (-6.67%)
:arrow_down:

src/hearth/vision/utils.py
93.75% <0.00%> (-6.25%)
:arrow_down:

src/hearth/callbacks/monitors.py
94.59% <0.00%> (-2.71%)
:arrow_down:

src/hearth/callbacks/learning_rate.py
97.61% <0.00%> (-1.22%)
:arrow_down:

src/hearth/_config.py
88.18% <0.00%> (-1.08%)
:arrow_down:

src/hearth/events.py
94.23% <0.00%> (-0.51%)
:arrow_down:

src/hearth/callbacks/history.py
78.18% <0.00%> (-0.39%)
:arrow_down:

src/hearth/loop.py
96.66% <0.00%> (-0.13%)
:arrow_down:

src/hearth/modules/base.py
96.22% <0.00%> (-0.07%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88f6d0b...5b16583. Read the comment docs.


Add REGISTRY_OPENSHIFT_SERVER_ADDR

/cc @gabemontero
Please change the samples rbac.yaml in the same way.

sorry, Cced on the wrong PR


dev-server does not restarts when it crashes

I'm using a monorepo with pnpm. My Epic Stack project has a dependency on another workspace
  // package.json
  "my-react-lib": "workspace:*"

when my-react-lib gets rebuilt, the built artefact gets removed for a sec and the new one replaces it
when this happens, dev-server crashes with an error that looks something like
[vite] Error when evaluating SSR module virtual:remix/server-build: failed to import "app/routes/my-page.tsx"
Error: Failed to load url<EMAIL_ADDRESS>(resolved id<EMAIL_ADDRESS>) in<EMAIL_ADDRESS>Does the file exist?
    at loadAndTransform (file:///monorepo/node_modules/.pnpm/vite@5.1.5_@types+node@20.11.25/node_modules/vite/dist/node/chunks/dep-G-px366b.js:53634:21)
    at instantiateModule (file:///monorepo/node_modules/.pnpm/vite@5.1.5_@types+node@20.11.25/node_modules/vite/dist/node/chunks/dep-G-px366b.js:54656:10)

By it crashes, I mean, when I reload the browser to show my-page, chrome says This site can’t be reached ERR_CONNECTION_REFUSED
workaround: restart the dev-server manually: Ctrl+C, and then npm run dev
I tried to fix this issue by myself but all my attempts have failed so far

I am experiencing similar issues with syntax errors. While editing files and using the vs-code autosave feature, my dev server constantly crashes.
[vite] Internal server error: Transform failed with 1 error
I am wondering if there is a better solution than just turning off the autosave feature. Has anyone found a solution?

It's the same issue as #638, there is a pretty decent solution written there. It's not 100%, but it can work.

Closing this in favor of #638


fix(build-rs): Implicitly report rerun-if-env-changed for input

What does this PR try to resolve?
As we abstract away the env variables, users can't do a good job of
reporting these, so we'll do it ourselves.
How should we test and review this PR?
This isn't the shortest path to this solution because I had originally designed this like more like build_env but in a way to allow users to choose what policies they want (rather than baking in their HOST/TARGET scheme).
I decided to not support a custom env yet to make this more incremental and to see what feedback we get but I left the implementation in a way that would make it easy to support it.
I made is_present part of Env because I was unsure if callers of the API would want to handle that differently for rerun-if-env-changed or other parts.
Additional information
CC @CAD97

Although, I'm not sure it's actually needed for the CARGO_ environment? It depends on how aggressive Cargo is at caching the buildscript and if any of this environment can change without necessarily requiring a recompile.

The only cases I saw us specially handle are
https://github.com/rust-lang/cargo/blob/2f74b541301e676c884cdae1a59d530858b6d657/src/cargo/core/compiler/fingerprint/mod.rs#L852-L865
and
https://github.com/rust-lang/cargo/blob/2f74b541301e676c884cdae1a59d530858b6d657/src/cargo/core/compiler/fingerprint/dep_info.rs#L306-L338
Which makes sense.  We can set a lot and we likely don't want to re-run if all of it has changed.  Some we'll rebuild for anyways because some of the fingerprint has changed but I figure its better to be over aggressive than under aggressive or having to maintain a perfectly curated set of ENVs


Fix script release

Description:
The release script was broken by https://github.com/home-assistant/home-assistant/pull/5079
This fixes it.

Oops, does a command fail then? set -e makes sure that the script stops when a command returns an error code, making it less likely to miss something that went wrong...

Yeah, line 17 checks if a certain text not occurs with grep.


Makefile.shared: fix to allow strings and spaces in passed variables

The previous change for mingw, which now defaults to OPENSSLDIR and
ENGINESDIR definitions that include a space, a long standing issue was
revealed again; our builds for Unix like environment were never very
tolerant of spaces in these definitions, because the quotes were
interpreted along the way.
New analysis of Makefile.shared showed that our use of quotes in there
wasn't quite right.  A lot of double quotes could safely be replaced
with single quotes, thus protecting the diverse values we pass down to
this build file (remember that make variables are expanded before
passing the command to the shell, unconditionally), reserving double
quotes to the places where absolutely needed (to protect the expansion
of shell variables to commands).
CVE-2019-1552

Note that this isn't a security fix in itself, but it fixes a bug to make it possible to build the last security fix (mingw default config directory)

Travis errors don't seem relevant.

Merged
b15a19c148384e73338aa7c5b12652138e35ed28 Makefile.shared: fix to allow strings and spaces in passed variables

Merged
b15a19c148384e73338aa7c5b12652138e35ed28 Makefile.shared: fix to allow strings and spaces in passed variables

Merged
b15a19c148384e73338aa7c5b12652138e35ed28 Makefile.shared: fix to allow strings and spaces in passed variables

Merged
b15a19c148384e73338aa7c5b12652138e35ed28 Makefile.shared: fix to allow strings and spaces in passed variables


Fix byte2int with python 3

There is a pull request (#9) since a couple of months but no one to review and merge it...
Anyone?

Closing this to avoid having duplicate discussions. I've responded to the PR.


Accessibility Issue?

Steps to Reproduce / Scenario:

Go to Windows settings
Click on Default apps by protocol
Scroll down to VSLS
See error- The VS Code icon is not showing up with the background blue color

Screenshots

That is the VS Code icon, which happens to be blue. But actually that icon resource is loaded from our launcher, Live Share for VS Code.exe. We could consider changing that EXE's icon to our purple Live Share icon. @dlebu what do you think? (That VS Code icon is out of date anyway since VS Code updated it recently.)

I think we should fix it. Also, we should somehow differentiate between VSCode stable and VSCode insiders. (either by icon or app name)

Also note that square background depends on your personalized Windows accent color. Regardless, I think the Live Share icon is more correct, and should be less invisible even if you chose a purple accent color.


Make subtitles accessible in mediathek player where possible

Closed because of "fixed" or what?

Yes. It will be released with the next version.


Make fewer HTTP requests

Decreasing the number of components on a page reduces the number of HTTP requests required to render the page, resulting in faster page loads. Some ways to reduce the number of components include: combine files, combine multiple scripts into one script, combine multiple CSS files into one style sheet, and use CSS Sprites and image maps.


[Event Request] Codeunit 99000830 "Create Reserv. Entry" - function CreateRemainingReservEntry

Dear ALAppExtensions Team,
We would like to request the following event publisher in codeunit 99000830 "Create Reserv. Entry" - function CreateRemainingReservEntry
    if (OldReservEntry."Reservation Status" = OldReservEntry."Reservation Status"::Reservation) or
        (OldReservEntry."Reservation Status" = OldReservEntry."Reservation Status"::Tracking)
    then
        if OldReservEntry2.Get(OldReservEntry."Entry No.", not OldReservEntry.Positive) then begin // Get the related entry
            FromTracingSpecification.SetSourceFromReservEntry((OldReservEntry2));
            FromTracingSpecification."Qty. per Unit of Measure" := OldReservEntry2."Qty. per Unit of Measure";
            FromTracingSpecification.CopyTrackingFromReservEntry(OldReservEntry2);
            // DINNL <<
            DINCreateRemainingReservEntryOnBeforeCreateReservEntryFrom(OldReservEntry2);
            // DINNL >>
            CreateReservEntryFrom(FromTracingSpecification);
            InsertReservEntry2."Warranty Date" := OldReservEntry2."Warranty Date";
            InsertReservEntry2."Expiration Date" := OldReservEntry2."Expiration Date";
            OnBeforeCreateRemainingNonSurplusReservEntry(InsertReservEntry2, OldReservEntry2);
        end;

local procedure DINCreateRemainingReservEntryOnBeforeCreateReservEntryFrom(var ReservationEntry: Record "Reservation Entry")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Add a HTTP 200 response on "/" path

In gitlab by @sfalquier on Feb 8, 2018, 11:45
... since Google ingress needs a success on / to consider a service as up and running.

In gitlab by @sfalquier on Feb 8, 2018, 13:53
mentioned in commit 1c98fe519d493d77bbf91bb790f5f841c076c2fa

In gitlab by @sfalquier on Feb 8, 2018, 14:23
mentioned in merge request !140

In gitlab by @sylvaingaudan on Feb 8, 2018, 15:39
closed via commit 9829beed16473c41a542e64f3a9431e71e05326b

In gitlab by @sylvaingaudan on Feb 8, 2018, 15:39
closed via merge request !140


Matching examples / keeping PowerShell examples / binaries compatible with feature release

New cool feature in Container Apps - in this case mounting File Shares from the Environment. Documentation examples points to PowerShell examples - but there are no examples, since it is only possible to configure from the Az CLI (as of now I guess) which is not good enough. CLI is fine until you get used to PowerShell and you never wanna switch back - richer scripting & automating capabilities - as such - we dont want to become second class citizens moving forward by / when choosing Container Apps as our microservices platform in Azure and continue using PowerShell for administration.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: be0f8b60-2b47-c2a1-c17b-10da8ff1c7b6
Version Independent ID: b29e83f0-3b35-2179-fb55-61426073f229
Content: Tutorial: Create an Azure Files storage mount in Azure Container Apps
Content Source: articles/container-apps/storage-mounts-azure-files.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

@larswurm
Thanks for your feedback! We will investigate and update as appropriate.

Thanks for your feedback and your contribution to Azure docs.
Feedback for this repository is moving away from GitHub to a system specific to the Microsoft Learn platform. Issues for this repository will soon be disabled, and additional comments from GitHub will no longer be possible. However, we are now tracking and triaging this issue in the new feedback system.
To learn more about our feedback systems, please see Provide feedback for Microsoft Learn content.
#please-close