docs: Update documentation for 1.24 changes to containerd, ensure examples are functioning as intended

Description

Update documentation to remove previous method for specifying containerd runtime; this is now the default in Kubernetes v1.24 and should not be specified anymore per the AWS docs

Update examples to ensure they are functioning as intended.

It looks like some recent additions to the VPC module for IPv6 have introduced some issues here that are now corrected.
I'm not sure why the KMS key_id stopped working and started throwing an error, but is working as intended again with key_arn
It also looks like the KMS policy used for encrypting the EC2 volumes stopped functioning and caused instances to not launch properly. This has been updated to use the new policy specific to Autoscaling service linked roles and is working again

With support for addon configuration, most of the user data hacks for max pods and containerd runtime are now obsolete so those have been removed in order to not confuse users

Motivation and Context

Ensure that examples are functioning as intended
Align docs with recommended practices for EKS and simplify the user experience
Resolves #2381

Breaking Changes

No

How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[x] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

This PR is included in version 19.8.0 :tada:

Hi @bryantbiggs , does this mean that the solution described in https://github.com/terraform-aws-modules/terraform-aws-eks/issues/2297#issuecomment-1318954103 to set a custom max pods limit is no longer correct?
pre_bootstrap_user_data = <<-EOT
  #!/bin/bash
  set -ex
  cat <<-EOF > /etc/profile.d/bootstrap.sh
  export USE_MAX_PODS=false
  export KUBELET_EXTRA_ARGS="--max-pods=110"
  EOF
  # Source extra environment variables in bootstrap script
  sed -i '/^set -o errexit/a\\nsource /etc/profile.d/bootstrap.sh' /etc/eks/bootstrap.sh
  EOT

This change at https://github.com/bryantbiggs/terraform-aws-eks/blob/ce0ac51c642ac8dae52b208df2d8c43156082bf1/examples/user_data/main.tf#L21-L23 in this PR suggest that overriding max pods should now be something like the following rather than updating the bootstrap script to source an external file:
pre_bootstrap_user_data = <<-EOT
 #!/bin/bash
 set -ex

 export USE_MAX_PODS=false
 export KUBELET_EXTRA_ARGS="--max-pods=110"
 EOT

But I can't find any docs to confirm/deny this -- can you confirm if the above should be possible?

The recommended way to achieve max pods where the EKS managed node group will set the max pods appropriately would be to set the addon configuration values of the VPC CNI. For example, setting the following on an m5.large instance would yield a max pods setting of 110:
  cluster_addons = {
    vpc-cni = {
      # Specify the VPC CNI addon should be deployed before compute to ensure
      # the addon is configured before data plane compute resources are created
      # See README for further details
      before_compute = true
      most_recent    = true # To ensure access to the latest settings provided
      configuration_values = jsonencode({
        env = {
          # Reference docs https://docs.aws.amazon.com/eks/latest/userguide/cni-increase-ip-addresses.html
          ENABLE_PREFIX_DELEGATION = "true"
          WARM_PREFIX_TARGET       = "1"
        }
      })
    }
  }

Hi @bryantbiggs we're not using the VPC CNI, we're using an overlay network

ok

you can with the previous hack
pre_bootstrap_user_data = <<-EOT
  #!/bin/bash
  set -ex
  cat <<-EOF > /etc/profile.d/bootstrap.sh
  export USE_MAX_PODS=false
  export KUBELET_EXTRA_ARGS="--max-pods=110"
  EOF
  # Source extra environment variables in bootstrap script
  sed -i '/^set -o errexit/a\\nsource /etc/profile.d/bootstrap.sh' /etc/eks/bootstrap.sh
  EOT

It still works - its just not what the majority of users need to be concerned with. For the vast majority of users they are using the VPC CNI and to make configuration changes the recommended route is through the addon configuration settings


libftdi1: Fix doc parallelism

Description of changes
Spotted a random build failure while reviewing something unrelated.
[  8%] Generating ../doc/xml/ftdi_8c.xml
[...]
[ 12%] Generating ../doc/xml/ftdi_8c.xml
[...]
[ 14%] Generating ftdi1_doc.i
[...]
Traceback (most recent call last):
  File "/build/libftdi/python/doxy2swig.py", line 457, in <module>
    main()
  File "/build/libftdi/python/doxy2swig.py", line 453, in main
    convert(args[0], args[1], not options.func_def, options.quiet)
  File "/build/libftdi/python/doxy2swig.py", line 430, in convert
    p = Doxy2SWIG(input, include_function_definition, quiet)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/build/libftdi/python/doxy2swig.py", line 74, in __init__
    self.xmldoc = minidom.parse(f).documentElement
                  ^^^^^^^^^^^^^^^^
  File "/nix/store/gd3shnza1i50zn8zs04fa729ribr88m9-python3-3.11.8/lib/python3.11/xml/dom/minidom.py", line 1990, in parse
    return expatbuilder.parse(file)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/gd3shnza1i50zn8zs04fa729ribr88m9-python3-3.11.8/lib/python3.11/xml/dom/expatbuilder.py", line 913, in parse
    result = builder.parseFile(file)
             ^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/gd3shnza1i50zn8zs04fa729ribr88m9-python3-3.11.8/lib/python3.11/xml/dom/expatbuilder.py", line 211, in parseFile
    parser.Parse(b"", True)
xml.parsers.expat.ExpatError: no element found: line 1, column 0
make[2]: *** [python/CMakeFiles/doc_i.dir/build.make:73: python/ftdi1_doc.i] Error 1

add_custom_command OUTPUT generation requires a separate add_custom_target to ensure parallelism-safety, and DEPENDS should use those targets instead of the OUTPUTted files. Otherwise, multiple tasks will each invoke the add_custom_command for their own DEPENDS and overwrite each other's results, leading to issues like this.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Have you tried submitting the patch upstream?

I don't see any obvious spot for doing so. I guess by subscribing to the<EMAIL_ADDRESS>maillist and throwing the patch contents on there?

I don't see any obvious spot for doing so. I guess by subscribing to the<EMAIL_ADDRESS>maillist and throwing the patch contents on there?

Seems so. From https://www.intra2net.com/en/developer/libftdi/index.php:

If you have questions or want to talk to other developers, join the mailing list.


[BUG] search bar text overlaps

Short description explaining the high-level reason for the new issue.
Current behavior

The words in the search bar overlap the magnifying glass icon and the clear button.

Expected behavior

There's more padding so things don't overlap

Steps to replicate behavior

type lots of words into the search bar on the homepage in chrome.

Screenshots
Current

Yeah, something crept into the search CSS in the spring to throw it off, see original PR.

@anselmbradford, looks fine on http://www.consumerfinance.gov/your-story/.

@sebworks oh weird! Looks like the text input is still a little off in tell your story, but the button isn't. Hmmm

I believe /your-story/ might have a different header than the home page/other Wagtail-backed pages -- isn't it a sheer page?

It's a WordPress page.

@Scotchester @anselmbradford , the css should be the same for both pages, right? Sounds like CSS scoping issue.

This is sort of fixed, though it's really tight still:

Still an issue as of 2/13/2018

The clear text will be going away with the CF icons svg update. I've already fixed it on our in-progress cfgov branch but adding a comment here so I hopefully remember to check on non-wagtail pages as well.

This was fixed, possibly in https://github.com/cfpb/cfgov-refresh/pull/4125


fix drf spectacular warnings

python manage.py check --deploy
fix all drf spectacular warnings for API v2

removing from milestone 1.4 as the errors are related to API v1


Creating linked services (e.g. Azure Databricks) can lead to broken linked service definitions in DataFactory

Package Name: azure.mgmt.datafactory
Package Version: 3.1.0
Operating System: Windows / WSL -> VsCode devcontainer
Python Version: 3.10

Describe the bug
When creating a linked service on ADF via DataFactory SDK, there's no type check e.g. for Databricks (AzureDatabricksLinkedService) numerical values, e.g. new_cluster_num_of_worker. Expected would be a string (e.g. "1") but it's also possible to invoke the function with an integer. That ultimately leads to and invalid linked service definition in ADF, which furthermore breaks the ADF UI (see screenshot)
To Reproduce
Steps to reproduce the behavior:

Create a new linked service via SDK (->DataFactoryClient.linked_services.create_or_update) or directly edit a json in ADF linked service and set property "new_cluster_num_of_worker" from string (e.g. "1") to int (e.g. 1).
Save and publish
Try to open the linked service properties via ADF UI, it is not displayed correctly and breaks (needs a reload) if trying to correct it.
(see invalid_config.png for further details.)

Expected behavior

TypeCheck or automatically correct invalid types in the function signature
@ADF: Make a check before posting invalid Json or fix it automatically.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Hi @myrlo123, thank you for opening an issue! I'll tag some folks who should be able to help; we'll get back to you as soon as possible.

Python sdk is generated by swagger definitions. An issue has been opened for a fix.


Document Running Miasma in the Cloud

Configure Traefik Plugin
Enable SSL
DNS records

Actually I think this has less to do with any "Cloud" provider and more to do with just general instructions.
For example, I'd like to run this up in my on-prem private cloud if you will 😅 -- I have a small 22 RU Rack cabinet with 3x 1RU Hypervisor nodes running Proxmox VE.
If we can keep your project miasma "cloud agnostic" it'll be generally useful in more places (not just cloud) 👌

Most of that already exists, I just need to add more docs around the things listed in the issue. Though you're correct, it's less cloud docs and more generic docs.
Let me ask you this. You want to run Miasma on your local network, when you go to the documentation, what do you want to know and in what order?
For example, I had the same use case as you, running apps on my local network, I wrote the docs in order of what I would have wanted to know:

Does this do what I need it to do?
How do I install it?
How do I add nodes?
How do I create apps?
What about routing and DNS for my local network?

What you want to know is probable different than myself, and I'm probably missing steps since I wrote everything myself and don't really need the docs.

I'm very bad at writing in general, so that usually doesn't translate well to large documentation websites. So if you have any recommendations on structure or content, LMK.

I'm pretty bad at docs too 😅 But the list above is a great start!
My general rule of thumb is simple:

If I can't figure out and install something by reading it's README within ~5m you've lost me :D


ws group message incorrect

The WS message (invoice paid) is send to all connected browsers, which should of course not be the case.

remove  @method_decorator(postpone, 'waitinvoice')  for the WorkerConsumer
this works in development (runserver), but is not needed when using something like uwsgi/nginx


ValueError when opening a read-only hdf twice

In [3]: with pd.HDFStore('/tmp/file_I_can_only_read.hdf') as store:
   ...:     store['test'] = pd.Series(range(3))
   ...:

In [4]: os.chmod('/tmp/file_I_can_only_read.hdf', 0o400)

In [5]: store1 = pd.HDFStore('/tmp/file_I_can_only_read.hdf')
Opening /tmp/file_I_can_only_read.hdf in read-only mode

In [6]: store2 = pd.HDFStore('/tmp/file_I_can_only_read.hdf')
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-6-5b173bb4a3e8> in <module>()
----> 1 store2 = pd.HDFStore('/tmp/file_I_can_only_read.hdf')

/home/pietro/nobackup/repo/pandas/pandas/io/pytables.py in __init__(self, path, mode, complevel, complib, fletcher32, **kwargs)
    402         self._fletcher32 = fletcher32
    403         self._filters = None
--> 404         self.open(mode=mode, **kwargs)
    405
    406     @property

/home/pietro/nobackup/repo/pandas/pandas/io/pytables.py in open(self, mode, **kwargs)
    563                             hdf_version=tables.get_hdf5_version()))
    564
--> 565             raise e
    566
    567         except (Exception) as e:

/home/pietro/nobackup/repo/pandas/pandas/io/pytables.py in open(self, mode, **kwargs)
    538
    539         try:
--> 540             self._handle = tables.open_file(self._path, self._mode, **kwargs)
    541         except (IOError) as e:  # pragma: no cover
    542             if 'can not be written' in str(e):

/usr/lib/python3/dist-packages/tables/file.py in open_file(filename, mode, title, root_uep, filters, **kwargs)
    308                     "The file '%s' is already opened, but "
    309                     "in read-only mode.  Please close it before "
--> 310                     "reopening in append mode." % filename)
    311             # 'w' means that we want to destroy existing contents
    312             elif mode == 'w':

ValueError: The file '/tmp/file_I_can_only_read.hdf' is already opened, but in read-only mode.  Please close it before reopening in append mode.

and what is the problem? you need to open with with mode='r'.

It is just incoherent (you don't need mode='r' the first time) and less practical. If you're saying it's not a crucial bug... well, I agree.

still unclear
what exactly is incoherent? it works exactly as intended
you have to be explicit - the default is append

The default on read-only stores is read, but as you prefer.

it's much better to have an explicit error


docs: Add docs on installing Python package and versioning

Signed-off-by: Yuan Tang<EMAIL_ADDRESS>

cc @flaviuvadan


[Doc] remove redundant configuration doc

We split the file administration/Configuration.md into FE and BE configuration docs, but did not remove the original Configuration.md.
This PR adds recent updates to Configuration.md into FE_configuration.md and removes the old file.
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[x] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.2 branch-3.1


In websoon, select tools repository explore, and then select the security tab. How can you not see users, roles, and system roles, as shown in the following figure

In websoon, select tools repository explore, and then select the security tab. How can you not see users, roles, and system roles, as shown in the following figure

This is seen in websoon：


Add timestamps to log output

The log output should include the timestamp to make it easier to debug issues.

While we're at it, should add the possibility to add an (optional) tag as well so that the area from where the log message comes from can be identified easily.


Binning class and PSTH

This pull request contains two components. First we integrate a binning class Binned in the conversion module, that provides a representation of binned (clipped, unclipped) spike trains based on sparse matrices, which is an important feature for large sets of spike trains in combination with fine-grained binning. This binning class therefore acts more as a specialized data type within elephant. The advantage of this class is that it takes care of efficiently handling the sparse matrix management for the user (optionally keeping the “non-sparse” matrices in memory) and handles the clipping, but also keeps the time axis in order (similar to the AnalogSignal class of Neo). Please note: The existing binning function in elephant (conversion.binarize) has intentionally not been touched in this PR.
Second, we added a short function psth to the to statistics module that calculates the peristimulus time histogram (PSTH). It is meant as a very simple example of how to use the binning class in a function (however, more complex functions such as the correlation coefficient can exploit the benefits of the sparse matrix representation offered by the Binning class more dramatically).

Coverage decreased (-0.46%) to 99.07% when pulling 0c0536793d8b9f5c3e49dd6497bdba96786923d8 on alperyeg:binning into 37946e29566210dce1d0b9dd972e23da631f7a21 on NeuralEnsemble:master.

Please split this into two separate pull requests, one for Binned and one for psth.


Set CSI_DISABLE_HOLDER_PODS to true for all clusters 4.17 and onwards

Customers have had one release (4.16) for migration, As planned we are updating this setting.
Signed-off-by: Nitin Goyal<EMAIL_ADDRESS>

@BlaineEXE Do we have a story created in the JIRA to complete this task?

No, and I should verify with PM that we want to take this change for 4.17. Please don't merge this until we are certain.
Currently, all greenfield clusters will have holders disabled, which is the minimum requirement for 4.17+.

/hold

No, and I should verify with PM that we want to take this change for 4.17. Please don't merge this until we are certain.
Currently, all greenfield clusters will have holders disabled, which is the minimum requirement for 4.17+.

Pls do let me know once you have the info.

/unhold


Phoenix 6437: Parent-Child Delete marker should get replicated via SystemCatalogWALEntryFilter

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 12s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
22m 24s
master passed

+0
hbaserecompile
29m 26s
HBase recompiled.

+1 :green_heart:
compile
1m  5s
master passed

+1 :green_heart:
checkstyle
1m 33s
master passed

+1 :green_heart:
javadoc
0m 51s
master passed

+0 :ok:
spotbugs
3m  3s
phoenix-core in master has 959 extant spotbugs warnings.

-0 :warning:
patch
3m 12s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 57s
root in the patch failed.

+0
hbaserecompile
10m 45s
HBase recompiled.

-1 :x:
compile
0m 50s
phoenix-core in the patch failed.

-1 :x:
javac
0m 50s
phoenix-core in the patch failed.

-1 :x:
checkstyle
1m 29s
phoenix-core: The patch generated 17 new + 2400 unchanged - 9 fixed = 2417 total (was 2409)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 51s
the patch passed

-1 :x:
spotbugs
0m 49s
phoenix-core in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 48s
phoenix-core in the patch failed.

-1 :x:
asflicense
0m 16s
The patch generated 1 ASF License warnings.

54m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1221

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux b7d485a77f6e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / e3a1e77

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

mvninstall
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt

javac
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
96 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1221/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


fix(tls): avoid MISSING_BUF panic on stream shutdown; +bonus debug feature

When trying to get a basic HTTPS server to work:

the code
mod rustls_config;

use std::{convert::Infallible, path::Path, sync::Arc};
use compio::{net::TcpListener, tls::TlsAcceptor, driver::{IntoRawFd, FromRawFd}};
use http_body_util::Full;
use hyper::{
    body::{Bytes, Incoming},
    Request, Response,
};

async fn hello(_: Request<Incoming>) -> Result<Response<Full<Bytes>>, Infallible> {
    Ok(Response::new(Full::new(Bytes::from("Hello, World!"))))
}

fn main() -> anyhow::Result<()> {
    compio::rustls::crypto::ring::default_provider()
        .install_default()
        .unwrap();
    let tls_conf = rustls_config::create_rustls_config(
        Path::new("./xxx.crt"),
        Path::new("./xxx.key"),
    )?;
    let tls_acceptor: TlsAcceptor = Arc::new(tls_conf).into();

    // let count = std::thread::available_parallelism()?.get();
    eprintln!("Starting http server on port 8000");

    let rt = compio::runtime::RuntimeBuilder::new().build().unwrap();

    // let (shutdown_tx, mut shutdown_rx) = oneshot::channel();

    let srv = async move {
        let mut sock = socket2::Socket::new(socket2::Domain::IPV6, socket2::Type::STREAM, None).unwrap();
        sock.set_only_v6(false).unwrap();
        sock.set_reuse_port(true).unwrap();
        let address: std::net::SocketAddr = "[::0]:8000".parse().unwrap();
        let address = address.into();
        sock.bind(&address).unwrap();
        sock.listen(128).unwrap();
        let listener = unsafe { compio::net::TcpListener::from_raw_fd(sock.into_raw_fd()) };
        let addr = listener.local_addr().unwrap();
        let builder = hyper_util::server::conn::auto::Builder::new(cyper_core::CompioExecutor);
        // while let Ok(None) = shutdown_rx.try_recv() {
        loop {
            let (stream, _) = listener.accept().await.unwrap();
            let stream = tls_acceptor.accept(stream).await.unwrap();
            if let Err(x) = builder
                .serve_connection(
                    cyper_core::HyperStream::new(stream),
                    hyper::service::service_fn({
                        // let func = hello.clone();
                        move |req| {
                            let fut = hello(req);
                            async move { fut.await }
                        }
                    }),
                )
                .await
            {
                eprintln!("{:?}", x);
            }
        }
    };

    rt.block_on(srv);

    Ok(())
}

a MISSING_BUF panic would happen. I've added a debugging feature to print the backtrace of the first Buffer::take_inner if a second one occurs before the buffer is returned, and got this:
thread 'main' panicked at /home/val/src/github.com/compio-rs/compio/compio-io/src/buffer.rs:205:17:
The buffer was submitted for io and never returned

First taken at:
   0: compio_io::buffer::Buffer::take_inner
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/buffer.rs:207:36
   1: compio_io::buffer::Buffer::with::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/buffer.rs:155:40
   2: compio_io::buffer::Buffer::flush_to::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/buffer.rs:179:18
   3: compio_io::compat::SyncStream<S>::flush_write_buf::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/compat.rs:156:54
   4: <compio_tls::stream::TlsStream<S> as compio_io::write::AsyncWrite>::flush::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-tls/src/stream/mod.rs:165:44
   5: <compio_tls::stream::TlsStream<S> as compio_io::write::AsyncWrite>::shutdown::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-tls/src/stream/mod.rs:170:22
   6: send_wrapper::futures::<impl core::future::future::Future for send_wrapper::SendWrapper<F>>::poll
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/send_wrapper-0.6.0/src/futures.rs:27:3
   7: send_wrapper::futures::<impl core::future::future::Future for send_wrapper::SendWrapper<F>>::poll{{reify.shim}}
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/send_wrapper-0.6.0/src/futures.rs:23:2
   8: <cyper_core::stream::HyperStream<S> as hyper::rt::io::Write>::poll_shutdown
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cyper-core-0.1.0-beta.2/src/stream.rs:336:19
   9: <hyper_util::common::rewind::Rewind<T> as hyper::rt::io::Write>::poll_shutdown
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-util-0.1.3/src/common/rewind.rs:131:9
  10: hyper::proto::h1::conn::Conn<I,B,T>::poll_shutdown
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/conn.rs:765:22
  11: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_inner
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/dispatch.rs:154:24
  12: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_catch
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/dispatch.rs:126:28
  13: <hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T> as core::future::future::Future>::poll
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/dispatch.rs:447:9
  14: <hyper::server::conn::http1::Connection<I,S> as core::future::future::Future>::poll
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/server/conn/http1.rs:215:22
  15: <hyper_util::server::conn::auto::Connection<I,S,E> as core::future::future::Future>::poll
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-util-0.1.3/src/server/conn/auto.rs:351:28
  16: example::main::{{closure}}
             at ./src/main.rs:60:18
  17: compio_runtime::runtime::RuntimeInner::block_on::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:92:68
  18: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /builddir/rust-1.76.0/library/core/src/future/future.rs:124:9
  19: async_task::raw::RawTask<F,T,S,M>::run
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.7.0/src/raw.rs:557:17
  20: async_task::runnable::Runnable<M>::run
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.7.0/src/runnable.rs:781:18
  21: compio_runtime::runtime::RuntimeInner::run
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:83:17
  22: compio_runtime::runtime::RuntimeInner::block_on
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:94:13
  23: compio_runtime::runtime::EnterGuard::block_on
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:496:9
  24: compio_runtime::runtime::Runtime::block_on
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:340:9
  25: example::main
             at ./src/main.rs:68:5
  26: core::ops::function::FnOnce::call_once
             at /builddir/rust-1.76.0/library/core/src/ops/function.rs:250:5
  27: std::sys_common::backtrace::__rust_begin_short_backtrace
             at /builddir/rust-1.76.0/library/std/src/sys_common/backtrace.rs:155:18
  28: std::rt::lang_start::{{closure}}
             at /builddir/rust-1.76.0/library/std/src/rt.rs:166:18
  29: std::rt::lang_start_internal
  30: std::rt::lang_start
             at /builddir/rust-1.76.0/library/std/src/rt.rs:165:17
  31: main

stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: compio_io::buffer::Buffer::take_inner
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/buffer.rs:205:17
   3: compio_io::buffer::Buffer::with::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/buffer.rs:155:40
   4: compio_io::buffer::Buffer::flush_to::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/buffer.rs:179:18
   5: compio_io::compat::SyncStream<S>::flush_write_buf::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/compat.rs:156:54
   6: <compio_tls::stream::TlsStream<S> as compio_io::write::AsyncWrite>::flush::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-tls/src/stream/mod.rs:165:44
   7: compio_io::compat::SyncStream<S>::flush_write_buf::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-io/src/compat.rs:157:24
   8: send_wrapper::futures::<impl core::future::future::Future for send_wrapper::SendWrapper<F>>::poll
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/send_wrapper-0.6.0/src/futures.rs:27:3
   9: send_wrapper::futures::<impl core::future::future::Future for send_wrapper::SendWrapper<F>>::poll{{reify.shim}}
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/send_wrapper-0.6.0/src/futures.rs:23:2
  10: <cyper_core::stream::HyperStream<S> as hyper::rt::io::Write>::poll_flush
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cyper-core-0.1.0-beta.2/src/stream.rs:321:19
  11: <hyper_util::common::rewind::Rewind<T> as hyper::rt::io::Write>::poll_flush
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-util-0.1.3/src/common/rewind.rs:127:9
  12: hyper::proto::h1::io::Buffered<T,B>::poll_flush
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/io.rs:289:13
  13: hyper::proto::h1::conn::Conn<I,B,T>::poll_flush
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/conn.rs:758:16
  14: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_flush
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/dispatch.rs:400:9
  15: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_loop
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/dispatch.rs:172:21
  16: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_inner
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/dispatch.rs:147:16
  17: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_catch
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/dispatch.rs:126:28
  18: <hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T> as core::future::future::Future>::poll
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/proto/h1/dispatch.rs:447:9
  19: <hyper::server::conn::http1::Connection<I,S> as core::future::future::Future>::poll
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-1.2.0/src/server/conn/http1.rs:215:22
  20: <hyper_util::server::conn::auto::Connection<I,S,E> as core::future::future::Future>::poll
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-util-0.1.3/src/server/conn/auto.rs:351:28
  21: example::main::{{closure}}
             at ./src/main.rs:60:18
  22: compio_runtime::runtime::RuntimeInner::block_on::{{closure}}
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:92:68
  23: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /builddir/rust-1.76.0/library/core/src/future/future.rs:124:9
  24: async_task::raw::RawTask<F,T,S,M>::run
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.7.0/src/raw.rs:557:17
  25: async_task::runnable::Runnable<M>::run
             at /home/val/.cargo/registry/src/index.crates.io-6f17d22bba15001f/async-task-4.7.0/src/runnable.rs:781:18
  26: compio_runtime::runtime::RuntimeInner::run
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:83:17
  27: compio_runtime::runtime::RuntimeInner::block_on
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:94:13
  28: compio_runtime::runtime::EnterGuard::block_on
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:496:9
  29: compio_runtime::runtime::Runtime::block_on
             at /home/val/src/github.com/compio-rs/compio/compio-runtime/src/runtime/mod.rs:340:9
  30: example::main
             at ./src/main.rs:68:5
  31: core::ops::function::FnOnce::call_once
             at /builddir/rust-1.76.0/library/core/src/ops/function.rs:250:5

With that I found that removing the shutdown → flush call got rid of the issue. Still that feels odd that it happens!
By the way, that TLS integration via sync stream traits looks a bit odd to me :eyes: I guess that's… fine? in a single-thread runtime…? but is there any reason in particular compio-tls isn't currently using futures-rustls and async-native-tls? (note: by "async-std" support async-native-tls really means futures-util)

Good catch! However, I think it's a cyper bug, and should be fixed in 0.1.0-beta.2: https://github.com/compio-rs/cyper/commit/63dbdfeaf84068a39216482200463306959d8844
This PR is not right. shutdown method should call flush because the inner buffer should be flushed before the socket shutdown. However, if the flush method is still pending, shutdown should be called. That's the bug of HyperStream in the cyper repo, I think.

is there any reason in particular compio-tls isn't currently using futures-rustls and async-native-tls?

Yes. The sockets in compio is dealt very much differently to other crates, especially on Windows (IOCP) and Linux (io-uring).

Oh, I understand. It is caused by a poll_flush call after poll_shutdown. I'll close this PR and open a issue in cyper repo.

Leaving this around in case the debug instrumentation is useful to anyone (:

The sockets in compio is dealt very much differently to other crates, especially on Windows (IOCP) and Linux (io-uring).

hmm, but glommio does implement futures::io traits so futures-rustls does just work…

but glommio does implement futures::io traits so futures-rustls does just work…

It uses a buffer inside the stream.


🚀 [Feature]: sell recurring services (ie: seo for clients)

Feature Description
I'm using gumroad now but its not ideal, they actually don't officially support services only files.
Additional Context (optional)
No response
Code Snippet (optional)
package main

import "fmt"

func main() {
  fmt.Print("hello word")
}

Checklist:

[X] I agree to follow litecart's Code of Conduct.
[X] I have checked for existing issues that describe my suggestion prior to opening this one.
[X] I understand that improperly formatted feature requests may be closed without explanation.

In theory, one can add a product as a service.

Can it be billed recurring though?- Anthony(408) 656-2473https://profullstack.comOn Apr 24, 2024, at 2:46 AM, Shurco @.***> wrote:
In theory, one can add a product as a service.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


Unable to start containers when syslog endpoint unavailable

Output of docker version:
Client:
 Version:      1.11.0
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   4dc5990
 Built:        Wed Apr 13 19:36:04 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.11.0
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   a5315b8
 Built:        Thu Apr 14 10:19:52 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 65
 Running: 10
 Paused: 0
 Stopped: 55
Images: 180
Server Version: 1.11.0
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 687
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 4.4.6
Operating System: Alpine Linux v3.3
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 1.956 GiB
Name: docker
ID: WRRO:GDHQ:2YKH:7VBD:QWM4:ZCIA:LQ7P:QUQX:K5U5:AII7:WZLY:UHL5
Docker Root Dir: /var/lib/docker
Debug mode (client): false
Debug mode (server): true
 File Descriptors: 73
 Goroutines: 118
 System Time: 2016-04-18T21:53:29.71878939Z
 EventsListeners: 1
Username: programmerq
Registry: https://index.docker.io/v1/

Additional environment details (AWS, VirtualBox, physical, etc.):
Docker for Mac Beta (but other environments are affected)
Steps to reproduce the issue:
In some cases, I might start a container that is trying to log against a syslog server that is not resolvable in DNS.
Describe the results you received:
Currently, this results in a failure:
docker run --log-driver=syslog --log-opt syslog-address=udp://mysyslog:5000 -d -P nginx:alpine
Error response from daemon: Cannot start container docker: Error response from daemon: Failed to initialize logging driver: dial udp: lookup mysyslog on <IP_ADDRESS>:53: no such host.

Describe the results you expected:
It would be ideal if the docker daemon could gracefully handle this situation rather than fail with an error.
Additional information you deem important (e.g. issue happens only occasionally):

Do you mean having an option simalar to the one that was added for fluentd in 1.11 via #19439 (i.e. fluentd-async-connect)?
The difference here is that this would have to be implemented on docker side as the library we are using have no support for this kind of behavior.

@mlaventure @programmerq shall we close this one in favor of https://github.com/docker/docker/issues/21966, because it's basically the same issue?

@thaJeztah Happy to close either of them, I actually mis-clicked and didn't close #21966 :)


Issue 13: Reduces application messages to info instead of critical

Coverage remained the same at 98.095% when pulling 70695316a77803d938daa99066b3648af4ac24b8 on ashwini-balnaves:issue-13-critical-to-info into f631352e306cf0e0b252870d8e3fe720cedfae2e on cjrh:master.

Coverage remained the same at 98.095% when pulling 70695316a77803d938daa99066b3648af4ac24b8 on ashwini-balnaves:issue-13-critical-to-info into f631352e306cf0e0b252870d8e3fe720cedfae2e on cjrh:master.

Something's funny on travis for 3.6 on xenial. I think maybe we only do 3.7 on xenial. You can modify the .travis.yml file in this repo, something along the lines of what you see here: https://github.com/farrokhi/dnsdiag/blob/master/.travis.yml

Great work @ashwini-balnaves, this resolves #13 :tada:


Console Report : Language Change - Error Report Sept, 30 , 2018

When i changed my language to English i got some errors telling me to report this

"english" is not a language
"en-US' is
Use .langli to check which languages are available

well i set back to default it lang i should be good


Split up README into multiple pages of documentation

I can use the same tech as https://django-sql-dashboard.datasette.io/en/stable/ - see https://github.com/simonw/django-sql-dashboard/tree/main/docs

[x] Configure Read the Docs
[ ] Split documentation up into pages
[ ] Shrink the README and point it to the new docs
[ ] Add new Contributing page with notes on how docs work (including Cog)
[ ] Add a "recipes" section (with things like https://til.simonwillison.net/github-actions/oxipng)
[ ] Ship a release and check that Read the Docs has a "stable" as well as a "latest"
[ ] Vanity domain - probably shot-scraper.datasette.io

I started by just copying README.md into docs/index.md and configuring MyST and Read the Docs.
This first prototype of the new documentation is now hosted at https://shot-scraper.readthedocs.io/en/latest/
Next steps are in the issue description above ^

For the domain, I'm torn between shot-scraper.datasette.io and registering a domain specifically for shot-scraper.
I'm worried that it's not particularly relevant to Datasette. But I also don't want to have to pay for another domain name for the rest of time.

Configured shot-scraper.datasette.io here - https://readthedocs.org/dashboard/shot-scraper/domains/13242/edit/ - following instructions in https://til.simonwillison.net/readthedocs/custom-subdomain

Got a surprising certificate error in the Read the Docs interface:

SSL certificate status: The requested hostname resolves to a Cloudflare zone that is not owned by you. HTTP domain control validation (DCV) cannot be completed. Update this hostname to resolve to your zone and PATCH to try again.

Maybe because I had only setup the CNAME a few minutes before-hand?
http://shot-scraper.datasette.io/ is showing a Clouflare page:

I'm going to leave this for an hour and try again.

... no wait, I think this is because:

I set it to readthedocs.org but I should have set it to readthedocs.io!

OK, https://shot-scraper.datasette.io/ works now!

New structure is now live on https://shot-scraper.datasette.io/en/latest/

I changed the default version to stable here: https://readthedocs.org/dashboard/shot-scraper/advanced/

https://shot-scraper.datasette.io/en/stable/


How to set parameter?

Ubuntu
master

I want to change the value of the mixer. For this, I use "rosservice call / param_set mixer 1". To which returns: "exists: False". When trying to read this parameter:
exists: False
value: 0.0
So I still do not understand about the value of the mixer. How to define it?

Hi @Dines97. The parameter name is case-sensitive, so use rosservice call /param_set MIXER 1.
I'm not sure if you were asking this, but if you're also wondering where those values are defined they're listed at http://docs.rosflight.org/en/latest/user-guide/hardware-setup/#motor-layouts.
Hope that helps.


Add eslint-plugin-eslint-comments

Before submitting, please confirm you've

[x] read and understood our Contributing Guidelines
[x] completed Mattermost Contributor Agreement
[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
Add eslint-plugin-eslint-comments. It prevents abuse of eslint-disable directive.
See https://mysticatea.github.io/eslint-plugin-eslint-comments/ for detail.
Issue link
N/A
Test Cases
Add unwanted /* eslint-disable */ comments, then execute npm run lint:js. It should report errors.
Additional Notes
N/A

Thanks @yuya-oc is this for v4.2?

@esethna Not only for v4.2. This doesn’t affect application behavior.

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Hey @yuya-oc,
Is this still something we want? If so, would you please merge master into your branch?

@hanzei Thanks for checking. This still would be an improvement for lint in our reviewing. I'll rebase then merge this.


Is ATOM dead? 💀

hello cosmos brothers,
I cant transfer my Atom coins, what happened to the blockchain, is my coins safe? is atom dead?
thanks, dante

@coderrabitai please find out

@coderabitai

Sounds like a user error, not a blockchain problem

@dehvCurtis bro chain was death, what are you talking about? 💀


[FR] Settings API - use KEY as URL identifier

Ref: https://github.com/inventree/InvenTree/pull/2805
Currently, we use the PK (primary key) of the setting instance to determine the API access URL
e.g. /api/settings/1/
However, there are a number of issues here:

No way of accessing a setting object without knowing the PK value
Settings get 'instantiated' on request, so we can't even read out the "default" value until it has a pk

Suggestion
We should change the setting access API to use the unique KEY of the setting as the lookup URL, e.g.

/api/setting/ENABLE_REPORT/
/api/setting/user/SEARCH_RESULTS_COUNT/

This has some other advantages:

Makes writing front-end access code (e.g. js / templates) much easier
We can "create" a setting on request, if it does not exist in the database
We can return an error code if an invalid KEY is requested

@SchrodingersGat sounds like a good idea!


An issue using modern OpenGL and Imgui-SFML ?

Hello,
I tried using your work since I already use a SFML window for my openGL project.
For now it pretty much crashes as soon as I try to display the GUI calling:
ImGui::SFML::Render(window)
Before that I get a lot of errors during my openGL operations
 An internal OpenGL call failed in Texture.cpp(667). Expression:    glMatrixMode(GL_MODELVIEW) Error description:    GL_INVALID_OPERATION    The specified operation is not allowed in the current state.
I'm not sure which "texture.cpp" this is, I have such a class but it is not 667 lines long. But it seems there is some state conflict between my openGL operations and the ones done by IMGUI-SFML.
I know that the othaur of Imgui advised against mixing modern and old openGL and I also noticed that the imgui-sfml.cpp file had the following lines:
`    glMatrixMode(GL_TEXTURE);
glLoadIdentity();
glMatrixMode(GL_PROJECTION);
glLoadIdentity();`

as well as :
        glVertexPointer(2, GL_FLOAT, sizeof(ImDrawVert), (void*)(vtx_buffer + offsetof(ImDrawVert, pos)));         glTexCoordPointer(2, GL_FLOAT, sizeof(ImDrawVert), (void*)(vtx_buffer + offsetof(ImDrawVert, uv)));         glColorPointer(4, GL_UNSIGNED_BYTE, sizeof(ImDrawVert), (void*)(vtx_buffer + offsetof(ImDrawVert, col)));
which look like 1.2 openGL. could it be that your openGL code is at odds with mine? Is there a way around it?
The init of my window and openGL context is this:
`	std::cout << "starting application" << std::endl;
/*
WINDOW OPENGL INIT
*/
const std::string title = "openGL";
sf::ContextSettings settings;
settings.depthBits = 24;
settings.stencilBits = 8;
settings.antialiasingLevel = 2; // Optional
// Request OpenGL version 3.2 (optional but recommended)
settings.majorVersion = 4;
settings.minorVersion = 5;
settings.attributeFlags = sf::ContextSettings::Core;
unsigned width = WIDTH;
unsigned height = HEIGHT;

window.create(sf::VideoMode(width, height), "Tetra Engine", sf::Style::Close, settings);
ImGui::SFML::Init(window);

glEnable(GL_DEPTH_TEST);
glCullFace(GL_BACK);
glewExperimental = GL_TRUE;
glewInit();
//apparently an old implementation bug tends to raise an error on startup. We call geterror to remove it.
glGetError();`

I do the following in my main loop:
`	tetraRender::EventHandler handler(scene);
while (window.isOpen())
{
// check all the window's events that were triggered since the last iteration of the loop
	sf::Event event;
	int time = clock.getElapsedTime().asMilliseconds();
	int frameTime = sf::milliseconds(16).asMilliseconds();
	bool needNewFrame = time >= frameTime;
	//It would seem that without this sync, there is a fall in performance. Not sure why yet. Also the application takes way more resources without it;
	//std::cout << '\r' << std::setw(4) << std::setfill(' ');
	if (needNewFrame)
	{

		//Render time.

		std::cout << '\r' << std::setw(4) << std::setfill(' ') << time;
		clock.restart();

		scene->renderScene();

	}
	if (window.pollEvent(event))
	{

		handler.handle(event);
		// "close requested" event: we close the window
		if (event.type == sf::Event::Closed)
		{
			window.close();

		}
	}
	ImGui::SFML::ProcessEvent(event);
	ImGui::SFML::Update(window, deltaClock.restart());

	if (ImGui::Button("Update window title")) {
		// this code gets if user clicks on the button
		// yes, you could have written if(ImGui::InputText(...))
		// but I do this to show how buttons work :)
	}
	ImGui::End(); // end window

	ImGui::SFML::Render(window);
	window.display();

}`

in scene->renderScene() I do a lot of opengl state calls to render my scenes using multiple framebuffers and shaders using opengl 4.3.
I would like to add that the system crashes during a call to Imgui::End() because g.currentWindow is null. And the many openGL errors appear during the call of window.resetGLStates();

Hello
The "Texture.cpp" is SFML's sf::Texture. Which probably means that you're messing SFML's internal state of OpenGL by calling OpenGL where SFML doesn't expect you to do so. Try calling push/pop/resetGLStates around the code where you use OpenGL. I'm not sure about the order in your case, check out the guide here: https://www.sfml-dev.org/tutorials/2.5/window-opengl.php#using-opengl-together-with-the-graphics-module
You can also try doing this: (You'll also need to remove resetGLStates from ImGui::SFML::Render)
window.pushGLStates();
ImGui::SFML::Render(window);
window.popGLStates();

I would like to add that the system crashes during a call to Imgui::End() because g.currentWindow is null

On what line exactly does it crash?

Hey, so in tinkered around for a while and I tried to remove everything unnecessary to see what was going on.
so when I don't initialize openGL I have this:

To do this I started a RenderWindows WITHOUT settings, leaving them to default I believe.
std::cout << "starting application" << std::endl;
/*
WINDOW OPENGL INIT
*/
const std::string title = "openGL";
sf::ContextSettings settings;
settings.depthBits = 24;
settings.stencilBits = 8;
settings.antialiasingLevel = 2; // Optional
// Request OpenGL version 3.2 (optional but recommended)
settings.majorVersion = 4;
settings.minorVersion = 3;
settings.attributeFlags = sf::ContextSettings::Core;
unsigned width = WIDTH;
unsigned height = HEIGHT;

sf::RenderWindow window(sf::VideoMode(width, height), "Tetra Engine", sf::Style::Default, settings);
window.setFramerateLimit(60);

window.setActive();

glewExperimental = GL_TRUE;
glewInit();
glEnable(GL_DEPTH_TEST);
glCullFace(GL_BACK);
ImGui::CreateContext();
ImGui::SFML::Init(window);

sf::CircleShape shape(100.f);
shape.setFillColor(sf::Color::Green);

sf::Clock deltaClock;
while (window.isOpen()) {
	sf::Event event;
	while (window.pollEvent(event)) {
		ImGui::SFML::ProcessEvent(event);

		if (event.type == sf::Event::Closed) {
			window.close();
		}
	}

	ImGui::SFML::Update(window, deltaClock.restart());

	ImGui::Begin("Hello, world!");
	ImGui::Button("Look at this pretty button");
	ImGui::End();

	window.clear();
	window.draw(shape);
	window.pushGLStates();
	ImGui::SFML::Render(window);
	window.popGLStates();
	window.display();
}

ImGui::SFML::Shutdown();

	return 0;`

So this is pretty much all of my code, and from window.clear() to window.display() it seems each line will raise errors from SFML. And this is pretty much only Imgui code that is beeing executed here, I don't do any openGL code of my own.
I am not sure what is causing this because I removed pretty much all of my code and it is still breaking. So you'll notice that one way for it to work is to remove settings from the constructor but of course it means no openGL context

Thanks! This is close to a minimal reproducible example, so I'll try to reproduce it and see what I can do.

Closing, #159.


Calendar Event Format: description

IS it possible to have another Calendar Event Format added? Would like to use the note section of an event, I guess Google calls is "description".
Is that possible to have integrated?
Thanks!
https://developers.google.com/calendar/api/v3/reference/events

Thanks!
how does it work, Roam updated but cannot get it to work. Thanks!

Roam still needs to approve the change before it's live


[SPARK-25656][SQL][DOC][EXAMPLE] Add a doc and examples about extra data source options

What changes were proposed in this pull request?
Our current doc does not explain how we are passing the data source specific options to the underlying data source. According to the review comment, this PR aims to add more detailed information and examples
How was this patch tested?
Manual.

Test build #97900 has started for PR 22801 at commit 1bd23a4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4390/
Test PASSed.

Test build #97900 has finished for PR 22801 at commit 1bd23a4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97900/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4405/
Test PASSed.

Test build #97926 has started for PR 22801 at commit bf617d3.

Test build #97926 has finished for PR 22801 at commit bf617d3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97926/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4410/
Test PASSed.

Test build #97932 has started for PR 22801 at commit dcdbb8b.

Test build #97932 has finished for PR 22801 at commit dcdbb8b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97932/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4411/
Test PASSed.

Test build #97933 has started for PR 22801 at commit 2462e59.

Test build #97933 has finished for PR 22801 at commit 2462e59.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97933/
Test PASSed.

This LGTM.

Thank you for review, @felixcheung , @dbtsai , @HyukjinKwon .
Merged to master.


It should be possible to edit tasks from the query results

Add a pencil icon at the end that opens the “Edit task” modal.

I would love this enhancement.  So many times I will realize I need to add something to the task or make some comments (that's another enhancement I am hoping you will make, allowing notes to the tasks) and I need to go back to where the original task was located to make the changes.  Thanks.

This works great!!!  Thanks Schemar!


Write privdata files in binary rather than text

Not sure if you monitor old threads in todo from a year ago so here's a pull request. This addresses binary files stored in privData and being able to write them out again.
See https://propellor.branchable.com/todo/bytes_in_privData__63__/

Please submit changes to http://propellor.branchable.com/todo/ instead of using github pull requests, which are not part of my workflow. Just open a todo item there and link to a git repository containing your changes. Did you know, git is a distributed system? The git repository doesn't even need to be on github! Please send any complaints to Github; they don't allow turning off pull requests or redirecting them elsewhere.  -- A robot acting on behalf of Joey Hess

arcticwaters wrote:

Not sure if you monitor old threads in todo from a year ago so here's a pull
request.

Oh, I do. I have followed up to the thread with some questions.
--
see shy jo


Color.toString() for Safari Canvas?

I'm using Color.js (thanks!) and it seems like color.toString() doesn't always work in Safari for Canvas2D, which expects colors to be in "rgb(x, y, z)" — although "color(display-p3 1 0 2)" does work. But colors like "lch(100 50 40)" produce black pixels.
I'm not sure the root cause of this but it appears like it may be a browser bug? Chrome renders fine, and Safari Technology Preview renders fine too (Release 168, Safari 16.4, WebKit 186<IP_ADDRESS>).
Problematic Device/Browser:
MacBook Air M2, 2022, Ventura 13.0 (22A380)
Safari Version 16.1 (186<IP_ADDRESS>.12)
For now I have the following code that I am using before sending the color to context.fillStyle
const supportsP3 =
  window.CSS && CSS.supports("color", "color(display-p3 0 1 0)");
const outputSpaceId = supportsP3 ? "p3" : "srgb";

context.fillStyle = colorToStyle(new Color("lch(100 50 40)"));

export function colorToStyle(color) {
  // re-parse string in case it's out of gamut
  if (typeof color === "string") {
    return colorToStyle(new Color(color));
  }

  // edge case
  if (!color || !color.spaceId) return String(color);

  // operate on a copy
  color = color.clone();

  // convert to output space
  if (!color.spaceId !== outputSpaceId) color = color.to(outputSpaceId);

  // clamp to space's color gamut
  color.toGamut({ space: outputSpaceId });

  return color.toString();
}

In general, it would be nice to have a sort of "toStyle()" or "toHex()" that does something like this, automatically converting the color to a simpler RGB space and then rendering it as a full hex (with alpha if necessary) or old-school RGB string. This would be useful for legacy browsers and environments that don't support the full CSS color spec.
EDIT: Slightly improved my function to support a wider gamut when input color is something like oklch. This issue seems related somewhat to #31

display() does exactly this, though it uses CSS.supports() under the hood, we had not considered that Canvas may not support all the CSS colors supported by the browser. One solution would be to pass in a parameter to indicate the intended usage of the color and use a dummy canvas if target: "canvas" to test if it's supported, however that would be quite slow.

Canvas 2D context can be created with either an sRGB or a display-p3 canvas. However it is color managed, and any CSS color can be specified for drawing (fill, stroke); the color is converted to the canvas color space on input. So this looks like a browser bug on older versions. The 16.4 release notes don't mention anything specific to this bug, and I checked back to 16.0 without finding mention of it either. But I remember that very old Safari versions would only accept either sRGB or display-p3 in CSS; the rest was added later as CSS Color 4 matured and was fully implemented.
As @LeaVerou says, display() does what you want here.


Run tests with Prism 0.25+

The tests are being updated to use Prism 0.25+ from Prism 0.24. Prism 0.25 has fixed many issues, allowing for the execution of tests that were previously skipped due to broken_on: :prism. For future purposes, broken_on: :prism is intentionally left in the spec_helper.rb.
Furthermore, Prism 0.25 appropriately addresses the following syntax as an error:
$ ruby -ve "break"
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin22]
-e:1: Invalid break
break
-e: compile error (SyntaxError)

However, the Parser gem incorrectly parses it:
$ ruby-parse --33 -e "break"
(break)

This issue is expected to be reported to the Parser gem separately.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Would it not be more correct to put the invalid syntax ones in a context where these keywords would be valid syntax? I believe most of these were already invalid code in earlier rubies, just not at parse time:
# test.rb
foo = (yield) ? a : b

$ ruby test.rb
test.rb: --> test.rb
Invalid yield
> 1  foo = yield ? a : b

test.rb:1: Invalid yield (SyntaxError)
foo = yield ? a : b
      ^~~~~

$ rbenv local 3.2.2
$ ruby test.rb
test.rb:1: Invalid yield
test.rb: compile error (SyntaxError)

I tested quite a few and they all gave similar errors on both 3.3 and 3.2 when trying to run.

What does this mean? The following is valid syntax in Ruby 3.2.
Ruby 3.3
$ ruby -cve 'foo = (yield) ? a : b'
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-darwin22]
-e:1: Invalid yield
foo = (yield) ? a : b
-e: compile error (SyntaxError)

Ruby 3.2
$ ruby -cve 'foo = (yield) ? a : b'
ruby 3.2.3 (2024-01-18 revision 52bb2ac0a6) [x86_64-darwin22]
Syntax OK

The parser on 3.2 doesn't complain but when running it throws a SyntaxError error anyways. I'm just saying, the :ruby32, unsupported_on: :prism tests can be modified into code that both versions understand and is actually able to be interpreted. For example, the following code is parser/handled correctly but will not be tested by prism now:
def foo
  foo = (yield) ? a : b
end

Hmm, I'm not quite sure I understand. In Ruby 3.3, foo = (yield) ? a : b is a syntax error at the top level, but not within a method body. This PR makes existing test cases testable with Prism 0.25. Which test case in this PR are you referring to?
Additionally, Prism parses Ruby 3.3 and above. That means syntax parsing for Ruby 3.2 and below is not supported, and such tests should be skipped, which is what has been done.

The PR looks good to me. Thanks!

Which test case in this PR are you referring to?

This here for example: https://github.com/rubocop/rubocop/pull/12822/files#diff-cbedb596a9e288e54ae57df6b0110c55194521811c147de4a0dbb9f6749af655R133-R149
The syntax is always valid on 3.2 on parse but needs to be wrapped in a block in order to parse on 3.3. Only prism honors that behaviour, the parser gem has not support for that like you said. Still, it should not register an offense when wrapped in a block on prism but that is not tested anymore. Similarly, if the parser gem fixes the behaviour and aligns with CRuby it will not be tested that no offense occurs for newer rubies.


net/haproxy: use 'force' prefix for stop/restart actions

fixes #195
From the official HAProxy documentation:

HAProxy supports a graceful and a hard stop. The hard stop is simple, when the
SIGTERM signal is sent to the haproxy process, it immediately quits and all
established connections are closed. The graceful stop is triggered when the
SIGUSR1 signal is sent to the haproxy process. It consists in only unbinding
from listening ports, but continue to process existing connections until they
close. Once the last connection is closed, the process leaves.
The hard stop method is used for the "stop" or "restart" actions of the service
management script. The graceful stop is used for the "reload" action which
tries to seamlessly reload a new configuration in a new process.

The rc.script in the FreeBSD port seems to always use the graceful stop. By introducing the hard stop for stop/restart actions we're actually following the official recommendations. :)

does that still leave the proxy shutdown during reboot / shutdown?
if so, we only run "stop":
https://github.com/opnsense/core/blob/master/src/etc/rc.syshook.d/80-freebsd.stop
If you add a separate file with a single forcestop line with a higher priority that should deal with that, e.g. "50-haproxy.stop", see:
https://github.com/opnsense/core/blob/master/src/etc/rc.syshook.d/10-configd.early

does that still leave the proxy shutdown during reboot / shutdown?

Thanks for the pointer. Just added a syshook to use forcestop during reboot/shutdown.
Still need to test this on the box that shows this issue, though.

if the service stops ok under normal circumstances, it's ok to ship it
there's always opnsense-revert ;)

@fichtner I think there's a bug in the HAProxy's RC script on FreeBSD. It always sends the USR1 signal to HAProxy, even if the force prefix is used (in this case the TERM signal should be used). That's because the $rc_force variable is not available in the context.
The following patch fixes this on my test box:
--- haproxy.orig	2017-08-10 23:07:35.409143996 +0200
+++ haproxy	2017-08-10 23:08:30.901141522 +0200
@@ -32,14 +32,21 @@
 extra_commands="reload configtest"
 reload_cmd="haproxy_reload"
 stop_cmd="haproxy_stop"
+stop_precmd="haproxy_pre_check"
+restart_precmd="haproxy_pre_check"

 : ${haproxy_enable:="NO"}
 : ${haproxy_config:="/usr/local/etc/${name}.conf"}
 pidfile=${haproxy_pidfile:-"/var/run/haproxy.pid"}

-if [ -z "$rc_force" ]; then
-    sig_stop="USR1"
-fi
+# rc_force check can only be done at the run_rc_command
+# time, so we're testing it in the pre* hooks.
+haproxy_pre_check()
+{
+    if [ -z "${rc_force}" ]; then
+        sig_stop="USR1"
+    fi
+}

 load_rc_config $name

@@ -81,6 +88,7 @@
 configtest_cmd="$command -c -f $haproxy_config"
 start_precmd="$command -q -c -f $haproxy_config"
 required_files=$haproxy_config
+sig_stop="${haproxy_sig_stop:-TERM}"

 haproxy_reload()
 {

I plan to submit the patch upstream, but we should probably apply it in our own ports tree for now.

Hi Frank,
SIGUSR1 seems overly nice, why not even SIGINT? The SIGTERM for force seems reasonable, however.
I'm back on Tuesday to pick this up. If you can try to open a bug report in FreeBSD already so there is some review to go on?
Thanks,
Franco

On 10. Aug 2017, at 23:15, Frank Wall<EMAIL_ADDRESS>wrote:
@fichtner I think there's a bug in the HAProxy's RC script on FreeBSD. It always sends the USR1 signal to HAProxy, even if the force prefix is used (in this case the TERM signal should be used). That's because the $rc_force variable is not available in the context.
The following patch fixes this on my test box:
--- haproxy.orig	2017-08-10 23:07:35.409143996 +0200
+++ haproxy	2017-08-10 23:08:30.901141522 +0200
@@ -32,14 +32,21 @@
extra_commands="reload configtest"
reload_cmd="haproxy_reload"
stop_cmd="haproxy_stop"
+stop_precmd="haproxy_pre_check"
+restart_precmd="haproxy_pre_check"
: ${haproxy_enable:="NO"}
: ${haproxy_config:="/usr/local/etc/${name}.conf"}
pidfile=${haproxy_pidfile:-"/var/run/haproxy.pid"}
-if [ -z "$rc_force" ]; then

sig_stop="USR1"
-fi
+# rc_force check can only be done at the run_rc_command
+# time, so we're testing it in the pre* hooks.
+haproxy_pre_check()
+{

if [ -z "${rc_force}" ]; then

   sig_stop="USR1"

fi
+}

load_rc_config $name
@@ -81,6 +88,7 @@
configtest_cmd="$command -c -f $haproxy_config"
start_precmd="$command -q -c -f $haproxy_config"
required_files=$haproxy_config
+sig_stop="${haproxy_sig_stop:-TERM}"
haproxy_reload()
{
I plan to submit the patch upstream, but we should probably apply it in our own ports tree for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

If you can try to open a bug report in FreeBSD already so there is some review to go on?

Done this yesterday and added the link to the description. :)

Pasting link for easy access: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221402

If this works the same without the rc.d script modification, we can merge this already, no?

@fichtner Don't merge it just yet, looks like it will get fixed differently in upstream port. And I want to make this configurable in the GUI, because some user may prefer the graceful stop.

@fichtner It was suggested by upstream to add a new "hardstop" rc command instead. I've provided the required patches in the FreeBSD bug report and waiting for merge.
Besides that I've added a new GUI option to make the stop mode configurable. It defaults to "hard mode", which is a change of the default behaviour. I think this is a good choice for our plugin – it solves the issue where OPNsense would not reboot (or at least tages ages), because HAProxy is blocking it.

@fichtner Please apply this patch to our HAProxy port in time for 17.7.1:
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=185436
This PR is ready to be merged once our port is ready.

@fichtner As discussed on IRC, I've added another commit to address the concers. We need the rc wrapper script, because the upstream RC script does not provide a rc.conf variable to make hard/graceful mode configurable. The syshook.d script for "stop" is required to enforce hard/graceful mode during shutdown/poweroff.


Bold text on active tab causes the tab size to "jiggle" when focused/unfocused

Windows Terminal version
1.13.10336.0
Windows build number
10.0.19044.1526
Other Software
No response
Steps to reproduce

Open 2 or more tabs in Terminal
Repeat Ctrl + Tab

Expected Behavior
Things stay on same position
Actual Behavior
PowerShell vibration
https://user-images.githubusercontent.com/22536104/155642108-3ea58d2b-a9cf-4fc2-8d8b-9172fdbedbbc.mp4

@gabbybilka as an FYI.
I'll link this up to #12400. We'll probably need to track this upstream too. I'm not sure there's immediately any way for us to control the styling of the focused tab such that we can prevent it from getting bolded like that.

I'm gonna tag this up for discussion - honestly, we've been shipping with this for a year now, and there hasn't been an overwhelming amount of complaints. I didn't love it at first, but the bold text does add a little bit more emphasis to help ID the active tab. We may as well just leave this.

Yea our consensus was that if anything, this should be filed upstream over at https://github.com/microsoft/microsoft-ui-xaml.


LVS fails with fake diodes & MAGIC_EXT_USE_GDS

Describe the bug
If LVS is run against the GDS (instead of DEF/LEF) by setting MAGIC_EXT_USE_GDS then LVS will fail if there are fake diodes in the design. Fake diodes are used if DIODE_INSERTION_STRATEGY is set to 5.
To Reproduce
Steps to reproduce the behavior:
add these lines to designs/spm/config.tcl
set ::env(DIODE_INSERTION_STRATEGY) "5"
set ::env(MAGIC_EXT_USE_GDS) "1"
then run the flow:
./flow.tcl -design spm
design will fail with LVS issues
Expected behavior
design should pass LVS.
Desktop (please complete the following information):

OS: Ubuntu 20 LTS
Openlane Version 0.15

-ne skywater-pdk
bb2f842ac8d1b750677ca25bc71fb312859edb82
-ne open_pdks
7e29496eecf3ee8e1766f1b7f9441f97204d4735

@Manarabdelaty :  FYI, the issue can be fixed in sky130A_setup.tcl.  The "fakediode" cell needs to be added to the list of cells to ignore.  I had thought that the "fakediode" cell had a diode in it and just removed the contact, but it appears that the cell has only the pin and no diode.  This causes it to be optimized out by magic's extraction, and then LVS fails because the verilog netlist has fakediode cells but the layout extracted netlist doesn't.
I'm updating sky130A_setup.tcl in open_pdks now to correct the problem there, but it will need to be updated for OpenLane.

@RTimothyEdwards has this been updated?

@donn :  Yes, this was fixed a long time ago.

Guess that’s that then.


Support Additional Downtime options

Downtime has additional options that should be supported by the client:

monitor_tags
timezone

In addition, the following properties come back in the response which should also be supported:

parent_id

https://docs.datadoghq.com/api/?lang=bash#schedule-monitor-downtime

PR #227 was merged => closing this issue.


Roll Flutter Engine from 0b0fab821536 to 8517ab36dff7 (4 revisions)

https://github.com/flutter/engine/compare/0b0fab821536...8517ab36dff7
2023-12-14<EMAIL_ADDRESS>Manual roll of Dart SDK from a677378ae254 to<PHONE_NUMBER>b9 (flutter/engine#49054)
2023-12-14<EMAIL_ADDRESS>Rename font-subset to font_subset. (flutter/engine#49051)
2023-12-14<EMAIL_ADDRESS>Roll Skia from 92935b91193a to 79f23e8d8b5d (1 revision) (flutter/engine#49056)
2023-12-14<EMAIL_ADDRESS>Suppress warning for the new Activity library. (flutter/engine#49046)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

AutoRoller is stopped; closing the active roll.


chore: update scala-library from 2.12.15 to 2.12.19

About this PR
📦 Updates org.scala-lang:scala-library from 2.12.15 to 2.12.19
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.12.15).
You might want to review and update them manually.
.github/workflows/test.yml

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang", artifactId = "scala-library" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #208.


DiskWarrior alias flag complaints

Running DiskWarrior on an impluse-converted volume, it complains about files wrongly having the alias flag set, even though they don't and GetFileInfo confirms that they don't.
If you let DiskWarrior fix the catalog, it does make changes (and does not have any complaints afterward), but I don't know yet exactly what it changed.

Diffing the impluse analyze output between a freshly-converted Mac OS 9.0 CD and a DiskWarriored copy of the same, I notice that the Finder flags haven't changed at all.
What has changed, though, is the node flags:
-    Node flags: 0x0000
+    Node flags: 0x0002

0x0002 is kHFSThreadExistsMask.
Well that's definitely a bug. impluse adds thread records for every file that doesn't already have one, and it's supposed to also set that bit on those files.

Yup, that fixes it. “Alias flag”, huh? I should probably report the bug to Alsoft.
DiskWarrior also complains that folders incorrectly have the custom icon bit set and the volume's creation date is somehow wrong, but I can track those in separate issues.


is there a way to do this?

is there a way to use virgl or turnip instead of llvm while compiling to android
cuz llvm is too slow and it s the cause of most games like haxeflixel's ones

I'm pretty sure both of those are 3D libraries/drivers, meaning they aren't alternatives to LLVM. In fact, LLVM is required by modern versions of the Android NDK. You can use GCC instead of LLVM by switching to NDK r15c or earlier, but that isn't going to help with whatever performance issue you're experiencing.
If VirGL or Turnip replace anything, they might replace OpenGL (or act as a layer on top of it in VirGL's case). There's been talk about potentially replacing OpenGL at some nebulous time in the future, but it isn't currently in the works.

I'm pretty sure both of those are 3D libraries/drivers, meaning they aren't alternatives to LLVM. In fact, LLVM is required by modern versions of the Android NDK. You can use GCC instead of LLVM by switching to NDK r15c or earlier, but that isn't going to help with whatever performance issue you're experiencing.
If VirGL or Turnip replace anything, they might replace OpenGL (or act as a layer on top of it in VirGL's case). There's been talk about potentially replacing OpenGL at some nebulous time in the future, but it isn't currently in the works.

and is there no way to fix performance issue in android?

You'd have to provide more information about the issue. Ideally, build a minimal sample showing the slowdown.

You'd have to provide more information about the issue. Ideally, build a minimal sample showing the slowdown.

idk :(
in android i think the problem is about rendering cuz when i use in haxeflixel a less number of sprites it got fast but it goes slower after adding more

Ah, this is an issue of batching. Doesn't matter whether you use OpenGL, VirGL, Turnip, or anything else. All of them would perform badly with too many unbatched sprites, and all of them can handle thousands (if not hundreds of thousands) of batched sprites.
To get you started, OpenFL offers Tilemap by default, for simple sprite batching. If that's too restrictive, there's also Starling, though I don't know how well Flixel works with it. Also, someone might have made a Flixel-specific solution, so ask around in the Flixel community.


[enhancement]: Web Interface should support Collections for gallery and output location organization

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
Outputs are not easily organized, particularly when accessing the server interface remotely. Some users separate outputs into themes, others cherry-pick favorites out of larger sets, but most would benefit from some sort of sub-folder control on their outputs directly from the interface.
To be fully flexible and accommodate most workflows, collections in the gallery should have the following basic features:

Create new subfolders in outputs with custom names. By default there should be "Favorites" or something similar.
View individual collection subfolders in the gallery panel rather than the base outputs folder.
"Send To Collection" option when right clicking an image in the gallery.
Set a collection as the output folder for the current generation. This should be a separate option from the currently viewed collection.
Batch select/move multiple images to a collection, or option to move the last 'n' outputs to a specified collection.

Alternatives
No response
Aditional Content
No response

See also: https://github.com/invoke-ai/InvokeAI/issues/1270 and https://github.com/invoke-ai/InvokeAI/issues/1889

Implanted in v3


Remove legacy virtual_awg instrument

and 3. done. 2. is not needed, there are many instruments in the snapshot, but they are not used


[MacOS] Godot crashes when trying to create a GDScript

Godot version:
3.1.1 (Standard edition)
OS/device including version:
Mac Os Macbook pro 13 2017 base model
Issue description:
When i try to create/open a gd script an exception is thrown.
For more infos: https://pastebin.com/BdbAnxta

Are you trying to use external text editor? In you are it's probably duplicate of the #17615, check your external editor path is set correctly.

No I just want to use the built-in editor

I solve it. For an unknown reason the external editor option was enabled.


Fund button gets pushed to the right in case of long issue titles

@birkjernstrom How can we seed data in our database in our local development?
Can you share the URL of the page how can we access the page ?


Text area to enter code stops working in firefox after navigating to home page and back.

After clicking the home button to navigate to the main page and then opening a hole, I can no longer interact with the text area for entering code in Firefox until I restart the browser. Opening a new window or tab doesn't help.
I've attached a screenshot. I'm not sure whether the inspector shows anything interesting.

It normally looks like this.

I was trying to drill down into this earlier, from what I gathered, the div with class CodeMirror-sizer get sized by js, but some sort of race condition causes it to get a huge left margin.
Broken:

```

Normal:
```html

 { seems to fix it.

This seems to happen on macOS, but not on Windows.

This seems to happen on macOS, but not on Windows.

I'm getting it on windows also, its just pretty random


Ability to set global tolerations to browsers pods

Please see:
#122

Add Toleration to Browsers List

#284

Ability to set global nodeSelector to browsers pods

Could tolerations functionality be set globally, too?

Any updates? +1

Yes this is available in Moon 2, see: https://aerokube.com/moon/latest/#browsers-set-tolerations


onImageUploadBefore  in suneditor-react

@JiHong88 @LeeJiHong
Hi, first I have to say,
Your editor is really great. Thank you very much
But I want to upload photos, videos, etc. below.
Take the file and upload it (my own way) and then hand over the file address to the editor and he will do the rest.
I actually use a Meteor . And I don't really need to have a upload url. And I can upload my files in the same component.
I'm actually looking for a method that just gives me the file and takes the address and puts it in the editor.
If you give an example, thank you very much

I realized this feature exists . in V 2.30.6
But apparently the later version is not supported in suneditor-react/
@JiHong88  And if you act according to what you say
That is, we act as follows :
onImageUploadBefore(files, info, uploadHandler) {   const response = {..};   uploadHandler(response); }
In this case, the address is correct but the previous photo is not removed. And in fact two photos appear in the editor.

A photo with the server address
Photo with data address  image / jpeg; base64

:( :(

I do not know exactly where the problem is, I only know now that I am using suneditor-react And after executing the following code, two photos with the two addresses I mentioned will be placed in the editor .
onImageUploadBefore(files , info , core ,uploadHandler){

            // Upload image to Server

            const src = UploadToServer(files[0]);

            // result
            const response = {
                // The response must have a "result" array.
                "result": [
                    {
                        "url": src,
                        "name": files[0].name,
                        "size": files[0].size
                    },
            ]}

            uploadHandler(response);
        }

What should we do so that only the image with the server address is included ?

Hi @Saeed-Bahrami Is everything done synchronously?
Try returning false at the end.

@JiHong88
I used the promise, and when the image upload is complete, I resolve onImageUploadBefore.
Like the code below :

return new Promise((resolve, reject) => {
            upload.on('end', function (error, fileObj) {

            // Upload is Ednded

           if (error) {
               reject(error);
           } else {
               // Get link Image
              const src = EditorImg.link(fileObj) ;

              const response = {
                    // The response must have a "result" array.
                   "result": [
                     {
                      "url": src,
                      "name": files[0].name,
                      "size": files[0].size
                      },
               ]}
             // Resolve uploadHandler
                 resolve(uploadHandler(response))
               }
            });
        });```

@Saeeed-B
Using the async function or primise returns a primise object.
Try returning undefined explicitly.
onImageUploadBefore(files , info , core ,uploadHandler) => {
  /*
  ...
  */
  return undefined;
}

Hi @JiHong88!
return underfined;
is not working for me =( Still editor upload two images but with different sources.
Is there something I'm missing?
`const onImageUploadBefore = async (files, info, uploadHandler) => {
try {
for (const file of files) {
            //Do something with image
            const url= await GettingUrl(file);

            let image = {
                "url": url,
                "name": file.name,
                "size": file.size
            }

            images.push(image);
        }

        const response = {
            "result": images
        };
        uploadHandler(response);
    }
    catch (err) {
        uploadHandler(err.toString());
    }

    return undefined;
}`

Hi @Grouft
Do not use async function.
async (files, info, uploadHandler)  -> (files, info, uploadHandler)

Would be nice if this was in the docs 😄  I spent like 3 hours to figure this out 😄

Would be nice if this was in the docs 😄  I spent like 3 hours to figure this out 😄

@CyrusZei There is an explanation in the README and document.
But I admit it's hard to find.
I will improve the demo site.

@CyrusZei There is an explanation in the README and document.
But I admit it's hard to find.
I will improve the demo site.

How to upload a local video using videoFileInput method (i just got the window but its not working as expected) in sunEditor react?

You can use the videoUploadUrl: "http~"

You can use the videoUploadUrl: "http~"

but i want to upload the downloaded video

Um.. Just create an upload server and use the "videoUploadUrl" option to upload your video.

I am using socketio for file uploading, If I use async function then getting two images, if I remove the async function then it's getting loading and loading. Is there are any way to show one image with async function
`onImageUploadBefore={async (files, info, uploadHandler) => {
try {
const src = await SocketFileUploader(files);
console.log(src);
let response;
              response = {
                result: [
                  {
                    url: `https://cdn.ostello.co.in/${src[0].key}`,
                    name: files[0].name,
                    size: files[0].size,
                  },
                ],
              };
              console.log(src, response);
              uploadHandler(response);
            } catch (err) {
              uploadHandler(err.toString());
            }

            return undefined;
          }}`

@Fahad98723 https://github.com/JiHong88/SunEditor/issues/551#issuecomment-725858342

HI,
size in megabytes or with and height 400x200?


Add Aria Alert to the Login Window

On the login window, add an aria-alert to the login validation error messages
Add Aria live to:

Alert is now in live region and screen reader announces the errors


Add normalize option to template generators

Why:
By default, the template/ForceField generators normalize the molecule in terms of atom and residue name. There are use cases where it is preferable to maintain the input names.
I added an option to prevent normalization. The default produces the
current behavior.
This change addresses the need by:

Adding new keyword argument 'normalize' to

generateResidueTemplate
generateForceFieldFromMolecules

Passing this to the normalize flag of the get_charges command.

Looks OK to me.

The build seems to be failing, is that the http/https issue again? I can fix that in a separate PR.

#238 merged and build restarted

Merged the new master into the branch.


Updating GDPR

Docs Build status updates of commit f3829d2:
:clock10: Pending: waiting for processors (23 builds ahead of you)
:warning: Docs Build is busy, currently there are 23 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit f3829d2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

DocsLegal/GDPR.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Error = {"Field or property "ExportMode" does not exist."}

I have tried to convert wiki page with list view from sharepoint 2013 to office 365 using sharepointpnp modernization framework.Its showing ex = {"Field or property "Properties" does not exist."}

Can you explain what's on the wiki page? So assume it's a wiki page in SharePoint Online already containing some web parts and text and then you're trying to convert it? Would be good if you could also get the content from the page list item, specifically the "WikiField" field contains the content I want to look at.

The wiki page contains a list view webpart .The wikifield contains-false,false,1

Just be clear: this only works in SharePoint Online using SharePoint Online CSOM...

So is it possible to convert SharePoint 2013 classic pages to office 35 classic pages (CSOM)?

You need ISV migration tooling to first migrate the pages from your SP2013 to Office 365. Once in Office 365 you can use the page transformation tech to create "modern" pages for these migrated pages.

@jansenbe  Thank you very much for your support.

Hi @jansenbe
Could you please tell where we can change the destination folder `Site Pages´ to any other folder


Update creating-an-issue.md

Why:
Closes #22835

What's being changed (if available, include any code snippets, screenshots, or gifs):
Adding a tip that query parameters also work for custom fields in issue template creation on line 173 just below the query parameters table

Check off the following:

[x] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

@amandamartin-dev Thanks for submitting a PR to fix your issue! 👍
I'll get this triaged for review! :zap:

@amandamartin-dev Awesome, looks good to me! Marking this as ready to merge - thanks again for catching this and opening this PR! ✨