Feedback on BYOS

#design
#enhancement
Really love the idea of managed agent pools in your own subscription. You may already have these in your design, but a couple of things that would be good:

Running the agents on a private VNET.
Allow the customer to provide a set of azure tags that are applied to all of the agents. This allows us to use org codes and cost centers to map to our standard billing recovery processes.

@wsmckenz - thanks so much for the feedback.  We will ensure we consider this feedback in the design phase.

Hey, thanks for the feedback - we're tracking this internally and it should be coming soon. I'm going to close here since the feedback has been propogated internally.

HI @bryanmacfarlane,
Can you tell me if this has been released yet or where it is in your priorities?  Maybe point me to a roadmap item with it?  My organization is very much interested in this.
Running the agents on a private VNET.
Thank you!


React Native

Necolas was hired by Facebook. The future of RNW is a mystery. It is maintained, but still compatible with old RN 0.55. But that's fine, I don't have near-term plans to work on RN version of Este. What's important is RN DOM and CSS model. I believe it's sane future of the browser.

Ha, it's alive and well. Will be updated soon.


IP-27225: Case insensitive search

https://ipricegroup.atlassian.net/browse/IP-27225

closing PR because any changes should be in OctCMS


Zuul proxy swallows exceptions

As a client it's really hard to tell what went wrong if the proxy call fails (e.g. if the eureka registration just isn't there). You can tell from metrics/trace that something happened, but it would be nice for the consumer (e.g. browser to get some more immediate feedback). It might be sufficient just to mimic or re-use the Spring Boot default error page behaviour.

Hey guys.
I have auth zuul filter. Auth logic is written inside filter. I want to break filter chain and return 403 response in case when auth failed. How to achieve this? If I threw exception in the filter, Zuul will swallow it and return 200 ok to client which is not good in my case.


min_number_yrs_per_sim

Where does the global attribute min_number_yrs_per_sim come from? I cannot find it in the CV.

This attribute is a child of attribute <experiment_id>, see https://github.com/WCRP-CMIP/CMIP6_CVs/blob/master/CMIP6_experiment_id.json


Track notifications showing up

I need to handle notification fires I can do easy in iOS
by override ReceivedLocalNotification in AppDelegate
public override void ReceivedLocalNotification(UIApplication application, UILocalNotification notification)
but how can I reach the same with android

[BroadcastReceiver(Enabled = true, Exported = false)]
public class LocalNotificationService : BroadcastReceiver, ILocalNotificationService
{
public static readonly string VERSE_ALARM = "VERSE_ALARM";
public static readonly string TAG = "AlarmReceiver";
    public override void OnReceive(Context context, Intent intent)
    {
        System.Diagnostics.Debug.WriteLine(TAG, "Broadcast Received!");

        ISharedPreferences prefs = PreferenceManager.GetDefaultSharedPreferences(context);
        var verseNotification = prefs.GetBoolean("pref_key_notification_verse", true);

        if (verseNotification)
        {
            if (App.Config.VerseNotificationShowVerse)
            {
                loadVerse(context);
            }
            else
            {
                createVerseNotification(context);
            }

        }
    }

Thanks I will try it


Fixing CVE issues by bumping GO and Text versions.

Issue #, if available:
Internally tracked
Description of changes:
Bumping GO to version 1.18.
Bumping golang.org/x/text to v0.3.7
Testing
Ran 'make test'

aws-xray-daemon % make test
Testing daemon
go test -cover ./...
?   	github.com/aws/aws-xray-daemon/cmd/tracing	[no test files]
ok  	github.com/aws/aws-xray-daemon/pkg/bufferpool	1.313s	coverage: 100.0% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/cfg	5.526s	coverage: 57.6% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/cli	1.031s	coverage: 80.0% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/conn	5.466s	coverage: 67.9% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/logger	2.257s	coverage: 33.3% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/processor	2.698s	coverage: 84.9% of statements
?   	github.com/aws/aws-xray-daemon/pkg/profiler	[no test files]
ok  	github.com/aws/aws-xray-daemon/pkg/proxy	4.521s	coverage: 70.4% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/ringbuffer	5.486s	coverage: 85.7% of statements
?   	github.com/aws/aws-xray-daemon/pkg/socketconn	[no test files]
?   	github.com/aws/aws-xray-daemon/pkg/socketconn/udp	[no test files]
ok  	github.com/aws/aws-xray-daemon/pkg/telemetry	5.376s	coverage: 18.4% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/tracesegment	1.392s	coverage: 88.9% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/util	1.875s	coverage: 96.3% of statements
ok  	github.com/aws/aws-xray-daemon/pkg/util/test	3.383s	coverage: 77.1% of statements
?   	github.com/aws/aws-xray-daemon/pkg/util/timer	[no test files]

Docker runs after upgrading the version.


Allowing to use attesterLauncher with "npm run attest"

This PR allows to use the attesterLauncherConfig npm configuration parameter to specify an attester-launcher configuration file to be used with the npm run attest command, when the --browsers=... switch is used.
Here is a sample command showing how to configure the attesterLauncherConfig parameter:
npm config set ariatemplates:attesterLauncherConfig 'c:\\attesterLauncherConfig.yml'

Then, if that configuration file contains entries for the Chrome and Firefox browsers, it is possible to run test.aria.AriaTest on those 2 browsers with:
npm run attest -- --browsers=Chrome,Firefox test.aria.AriaTest

@divdavem this is a great addition !

@benouat Thank you for your review


Add Python3.12 to Test Matrix

Need to check later on:
Error: Version 3.12 with arch x64 not found
Available versions:

3.10.13 (x64)
3.11.6 (x64)
3.7.17 (x64)
3.8.18 (x64)
3.9.18 (x64)


uORB topics autogeneration

issue https://github.com/PX4/Firmware/issues/2486

New logger works now! File extension changed to .ULG ("micro LoG" / "Uav LoG" / "Universal LoG").
TODO

Topics list (default + user overridable), now hardcoded topics for accel/gyro/mag
Arguments parsing: buffer size, default rate etc.
Files naming using GPS date and time
Console converter tool
FlightPlot already supports new format, will be released soon

Extending genmsg is a bad think - this was broke ros-sitl build. Alternatively you may add second file with this metadata (example - nanopb uses *.option file to specify maximum length + other non-standard options).

I hadn't thought of the .option approach. @againagainst that sounds like a good way to de-conflict things.

:relieved:

I hereby invoke @LorenzMeier and @DrTon to appreciate this PR, and maybe even merge it.

Generation into the Build directory will require declaration by absolute path for generated cpps in the uORB/module.mk, like this:
SRCS	+= $(wildcard $(BUILD_DIR)topics_temporary/*.cpp)
The problem is that in this case *.o files are also compiled by absolute path, into the same directory:
https://github.com/PX4/Firmware/blob/master/makefiles/module.mk#L195
This makes impossible compilation for several platforms.
I may correct the module.mk rules. Does it make sense, if you (as I understood) are going to use CMake anyway?

The problem has been when you do a make clean, these things don't get cleaned and can cause problems when you switch between git branches and try to rebuild. If I have to test one target that uses these and then a cmake target that doesn't, it can break the build because its finding the old generated headers.

@againagainst Could you please start looking at the CI output? You fixed the compilation in 96806b7 just to break it again in 102b4f8. You can click on the symbol to get the CI status and the console output.

@DrTon Nice! What from your original todo list is left now? Did @againagainst provide the automated topic list yet?

Some TODO's still left:

Firmware version logging (very easy)
Topics list (not implemented yet, but maybe we can simply use topic files?)
Files naming using GPS time (would be good to fix RTC problems first)
Precise timestamps (requires timestamps in uORB)
Multi topics logging

BTW parameters now logged with type, so it's possible to restore parameters list from log as txt to open in qgc.

Automated topic list is implemented. Generation of multiline topics is done for all platforms, but ROS-SITL.
The px_generate_uorb_topic_headers.py and px_generate_uorb_topic_sources.py scripts are used for generation, they use genmsg as msg parser, and perform generation by empy.
In ROS-SITL, topics are generated by genmsg through CMake bindings. Since we decided to avoid extending genmsg, the only solution I see is to replace the bindings with a CMake function which calls python scripts for the ROS too. By the way, we already have such CMake function in master, so it's possible to use it inside the ROS's Cmake procedures. @LorenzMeier Please, share you opinion on this solution.

@againagainst Extending CMake sounds fine. Do you need additional hints there? I will review your complete work once all CI systems pass.

I'm experiencing problem with building the ROS-SITL even on master. However, it used to be compilable before merging with cmake build system's branch.
I use the setup-workspace.bash script from https://pixhawk.org/dev/ros/sitl in a clean directory, but it fails with the following error:
CMake Error at Firmware/CMakeLists.txt:156 (include):
  include could not find load file:

    configs/nuttx_px4fmu-v2_default

CMake Error at Firmware/CMakeLists.txt:168 (message):
  configs/nuttx_px4fmu-v2_default must implement px4_os_prebuild_targets

The problem actually caused here: https://github.com/PX4/Firmware/blob/master/CMakeLists.txt#L150 the ${OS} given by catkin's CMake is nuttx
@LorenzMeier, @jgoppert any ideas how to fix it? May be I should update the environment somehow?
This problem blocks me with extending CMake for ROS-SITL (obviously).

@DrTon @againagainst @kd0aij do you want to try and finish this? I squashed everything together into a single commit off of current master and pushed it to uORB_autogeneration_rebase.
https://github.com/PX4/Firmware/compare/uORB_autogeneration_rebase?expand=1
One piece that may need to be rethought is EKF2_REC_RPL. https://github.com/PX4/Firmware/blob/master/ROMFS/px4fmu_common/init.d/rc.logging#L15

The current problem is getting cmake to pickup the generated cpp files in the uORB module.
msg_source_files_out https://github.com/PX4/Firmware/blob/uORB_autogeneration_rebase/cmake/common/px4_base.cmake#L369 needs to be available to https://github.com/PX4/Firmware/blob/uORB_autogeneration_rebase/src/modules/uORB/CMakeLists.txt#L40 at cmake configure time.

@dagar
https://github.com/PX4/Firmware/blob/uORB_autogeneration_rebase/cmake/common/px4_base.cmake#L369 needs to be available to
add_custom_target(${TARGET}
		DEPENDS ${msg_source_files_out} ${msg_multi_files_out} ${msg_files_out})
set_target_proprties(${TARGET}  msg_files ${msg_files})

https://github.com/PX4/Firmware/blob/uORB_autogeneration_rebase/src/modules/uORB/CMakeLists.txt#L40 at cmake configure time.
get_target_property(MSG_FILES msg_gen msg_files)

This works because CMake is scoped, and msg_gen is defined in the root CMakeLists.txt file as a custom target.

Thanks @jgoppert
That's closer, but cmake is still unhappy because the file doesn't exist at configure time.
CMake Error at cmake/common/px4_base.cmake:269 (add_library):
  Cannot find source file:

/home/dagar/git/Firmware/build_posix_sitl_default/topics_sources/vehicle_attitude.cpp

 Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx
Call Stack (most recent call first):
src/modules/uORB/CMakeLists.txt:75 (px4_add_module)

CMake Error: CMake can not determine linker language for target: modules__uORB

I've opened a new pull request https://github.com/PX4/Firmware/pull/4041
Please push changes if you have any ideas.

Included in logger branch, closing, thanks!


Merge lgtm.com into master

This makes sure that the lgtm.com branch is fast-forwardable into master.

This looks pretty similar to https://github.com/Semmle/ql/pull/2314.

Huh, right. I didn't notice that 2314 would merge directly from the lgtm.com branch instead of a frozen SHA, so I thought it would be obsolete now.
Move along, nothing to see here.


docker build异常

卡在npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
很长时间，没有响应

Me too. Have you solved this problem?


ENH: New interface to customise visualisations

Overview
Closes #3266
Draws heavily from work already done by @CloseChoice in #3377 , but with a slightly different proposed interface to modify options following our subsequent discussion.
Discussion
This is a prototype of the "hybrid approach" we discussed here: https://github.com/shap/shap/issues/3266#issuecomment-1833550189
Following that PR, I've taken the "waterfall" plot to start with.
Proposed design
The idea is to have a module-level setting that can be changed at the global level, or used as a context manager:
# Modify global settings
shap.plots.set_style(text_color="green")
shap.plots.waterfall(shap_values)

# Or as a context manager
with shap.plots.style_context(text_color="black"):
    shap.plots.waterfall(shap_values)

This has a few advantages over some of our initial ideas:

Consistency with wider ecosystem (e.g. matplotlib, arviz, seaborn)
Separation of concerns: "setting style options" vs "making plots"
Ability to override the global defaults, e.g. potentially with a stylesheet
Ability to share config settings between different plots (e.g. primary color, secondary color...)

Matplotlib's rcParams is sometimes hard to use, as discussed in https://github.com/shap/shap/issues/3266#issuecomment-1813203451 . So, this PR proposes using type hints to make it easier to discover the set of valid settings.
I've tried to name the parameters in a way that is generalisable to other plots, beyond just the waterfall plot.
Proposed roll-out
I propose adding this as a private module. That means that initially it will not be part of the public API, giving us some time to refine the design and roll it out to all the plots.
Then, when we're ready to make the functionality public, we can expose a selection of functions in the public shap.plots namespace. The public functions could be:
# Set global state
set_style()

# Context manager
style_context()

# Get current state
get_style()

# Get default options
load_default_style()

TODO

[x] Define public methods to modify the global singleton
[x] Use styles in waterfall_plot
[x] Add more mpl_image_compare tests

@thatlittleboy following your comments I updated the API design to focus on changes to a subset of options, rather than passing in an entire set. I'd be grateful for another review.
One implementation detail is probably worth discussing. One key usability issue is providing good type hints for what config options are possible. I think the Unpack type hint is exactly what we need: for example in Jupyter, it allows my IDE to autocomplete the possible style options.
This has two hurdles to implement, which I think are well worth the effort for a better user experience:

The Options need to be provided as a TypedDict, not a dataclass. In fact this is probably a good conceptual separation: the dataclass represents a complete configuration, whereas the dict represents a partial set of updates.
The Unpack hint is new in python 3.11, so requires typing-extensions to backport to previous python versions. This is already a transitive dependency, but I've proposed adding it as a direct dependency.

@thatlittleboy it would be great to have another review if you have time

@CloseChoice @dsgibbons if you have time a code review for this would be great

Thanks both for the very detailed reviews on this one! Your feedback was really helpful, lots of good improvements compared to the first draft.


Move the 'use strict' declaration inside the plugin scope.

+1
Well, #59 suggests using this, so you can go ahead and merge.

Thanks, merged.


fix asm MULADDC for Microblaze in bn_mul.h

Fix MULADDC for Microblaze n bn_mul.h when MBEDTLS_HAVE_ASM is defined
This is a new version of #5578 with a minimal number of changes.
Status
Ready aka "it works on my device"
It fixes #2020
Requires Backporting
Yes, it could be backported in LTS 2.16 branch
Steps to test or reproduce
Run MPI or ECP self test on a Microblaze with MBEDTLS_HAVE_ASM defined.
Without the patch :
[14:27:21:309]   MPI test #1 (mul_mpi): failed
[14:27:21:309] Unexpected error, return code = 00000001
[14:27:21:309]   ECP SW test #1 (constant op_count, base point G): Unexpected error, return code = FFFFB380

With patch :
[14:28:39:658]   MPI test #1 (mul_mpi): passed
[14:28:39:658]   MPI test #2 (div_mpi): passed
[14:28:39:768]   MPI test #3 (exp_mod): passed
[14:28:39:799]   MPI test #4 (inv_mod): passed
[14:28:39:799]   MPI test #5 (simple gcd): passed
[14:28:39:799]   ECP SW test #1 (constant op_count, base point G): passed
[14:28:40:617]   ECP SW test #2 (constant op_count, other point): passed
[14:28:41:961]   ECP Montgomery test (constant op_count): passed

Signed-off-by: Benjamin Silvestre<EMAIL_ADDRESS>

This needs a Changelog entry, and will need a trivial forward-port to development.

Does this version work correctly for either endianness? It seems that this was addressed by the previous version of the PR, but maybe not by this version?

Thanks - have you been able to test this on both endiannesses?

This is fixing the same issue as #4686

Closing as this seems to duplicate the fix made in #4686 .


Dep updates

@aferd It looks like the yarn.lock is not in sync with the package.json. Maybe missing some commits and/or yarn install

Anyhow, after fixing, lets not merge this PR until we are back - Dependencies upgrades might break something :D

yes, i forgot to install after updating the last dep.


Add license

Does this code base have the same license as SWI-Prolog's BSD2 license?

You can safely assume so.  Too busy to check where license statements are missing right now.


Update managed WordPress providers

Add WordPress VIP, WordPress.com, Pressable
Remove Automattic

Automattic's primary business was WordPress.com, and WordPress VIP for enterprise-grade hosting. Since then, their business has expanded into multiple revenue streams and categories, everything from hosting to plugins, they also now own Tumblr. With that in mind, this will add separate detection for WordPress.com and WordPress VIP, and remove Automattic itself as it's not really a platform anymore.
This also adds another managed WordPress provider, Pressable. And ran yarn build to clean up the files for future merging.

Thank you!


Update samples

It's seems it's need to be update sample files with current steam module ver >= 1.0

Keep an eye on https://github.com/RJacksonm1/node-dota2/pull/90 Not much point updating samples when the steam module changed so much. Either don't update your steam dependency or wait for this merge.


Loaded model from file does not consider its action space continuous: error when running in LunarLanderContinuous-v2 environment

I train a model with PPO2 on the LunarLanderContinuous-v2 environment, then save it to a file.
Then I load the file, just like in the example, and run it again with the same environment to render the process, again just like in the example.
But an error occurs which indicates that the loaded/inferred model has as an attribute self.continuous=False or similar.
The equivalent process works just fine without error if env_name='LunarLander-v2'.
MWE of bug:
import gym

from stable_baselines.common.policies import MlpPolicy
from stable_baselines.common.vec_env import DummyVecEnv
from stable_baselines import PPO2

env_name = 'LunarLanderContinuous-v2'
policy = MlpPolicy
rl_alg = PPO2
rl_name = 'ppo2'

env = gym.make(env_name)
env = DummyVecEnv([lambda:env])

model = rl_alg.load(rl_name+"_"+env_name)

obs = env.reset()
while True:
    action, _states = model.predict(obs)
    obs, rewards, dones, info = env.step(action)
    env.render()

Stack trace:
WARN: gym.spaces.Box autodetected dtype as <class 'numpy.float32'>. Please provide explicit dtype.
WARN: gym.spaces.Box autodetected dtype as <class 'numpy.float32'>. Please provide explicit dtype.
Loading a model without an environment, this model cannot be trained until it has a valid environment.

---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
<ipython-input-3-e900d1547adb> in <module>()
     12 while True:
     13     action, _states = model.predict(obs)
---> 14     obs, rewards, dones, info = env.step(action)
     15     env.render()

/usr/local/lib/python3.5/dist-packages/stable_baselines/common/vec_env/base_vec_env.py in step(self, actions)
     92         """
     93         self.step_async(actions)
---> 94         return self.step_wait()
     95
     96     def get_images(self):

/usr/local/lib/python3.5/dist-packages/stable_baselines/common/vec_env/dummy_vec_env.py in step_wait(self)
     45         for env_idx in range(self.num_envs):
     46             obs, self.buf_rews[env_idx], self.buf_dones[env_idx], self.buf_infos[env_idx] =\
---> 47                 self.envs[env_idx].step(self.actions[env_idx])
     48             if self.buf_dones[env_idx]:
     49                 obs = self.envs[env_idx].reset()

/usr/local/lib/python3.5/dist-packages/gym/wrappers/time_limit.py in step(self, action)
     29     def step(self, action):
     30         assert self._episode_started_at is not None, "Cannot call env.step() before calling reset()"
---> 31         observation, reward, done, info = self.env.step(action)
     32         self._elapsed_steps += 1
     33

/usr/local/lib/python3.5/dist-packages/gym/envs/box2d/lunar_lander.py in step(self, action)
    236
    237     def step(self, action):
--> 238         assert self.action_space.contains(action), "%r (%s) invalid " % (action,type(action))
    239
    240         # Engines

AssertionError: array([0.87050533, 1.862139  ], dtype=float32) (<class 'numpy.ndarray'>) invalid

System Info
Model was trained/saved on Python 3.6 and loaded on Python 3.5
Library was installed via pip install stable-baselines
Trained on GPU, loaded and run on CPU only
All packages are up-to-date except I must run Tensorflow 1.5.0
Additional context
The model was trained and saved on a Google Compute Engine instance and run locally on an old Thinkpad laptop.

Hello,
The problem is that you don't clip the action. Cf Documentation:
https://stable-baselines.readthedocs.io/en/master/modules/policies.html

For all algorithms (except DDPG), continuous actions are only clipped during training (to avoid out of bound error). However, you have to manually clip the action when using the predict() method.

An easy solution to your problem is to upgrade your gym version, as they added clipping in LunarLanderContinuous recently ;) (see commit https://github.com/openai/gym/commit/d1146303b070a463e9e81086a0aeff7a2c909311#diff-41ce3ee7821ddd711130ac102a355dec)
(I assume your gym version is <= 0.10.5)

Great, thanks for the detailed answer! For some reason, it seemed like installing stable-baselines from pip encouraged gym 0.10.5 as a dependency. Upgrading gym resolved the issue.

The thing is that gym broke backward compatility with their new version for Multidiscrete action space, making stable baselines tests fails. That s why version 0.10.5 is the one recommended (but in your case, that does not matter)


Added an hash field in the CR status

The hash field will contain an hash of all the (hashed) inputs of the CR.

The idea here is right in that these are the inputs that would need to be hashed so we can determine uniqueness. We then need to use the hashed value to determine if we need to rerun the job that triggers ansible.
When the deploy flag is toggled from false to true on a DataPlane resource, we must create new instances of OpenStackAnsibleEE and force them to execute. Otherwise, the deloyment reconcilation could just find instances of OpenStackAnsibleEE from a previous deploy and assume the deploy is already done. Or, the ansibleee reconciler could find previous job executes and assume they are done. We can generate a unique DeployIdentifier each time the delpoy flag is toggled from the DataPlane controller(s) and include this value as part of the generated hash. That way, even if the inputs to OpenStackAnsibleEE don't change (play/roles/inventory), then this unique identifier would force a hash change and thus force a job re-execution.
We can use lib-common/modules/common/job/job.go for the logic around job re-execution for when hash values change. The other operators are already using that logic to test for things such as if dbsync or bootstrap functions (keystone-bootstrap) need to be re-triggered due to input change.

recheck

FYI @gibizer

[snip]
We can use lib-common/modules/common/job/job.go for the logic around job re-execution for when hash values change. The other operators are already using that logic to test for things such as if dbsync or bootstrap functions (keystone-bootstrap) need to be re-triggered due to input change.

We discussed that over slack that currently lib-common does not support cancelling a running job when the hash of the job changes. It always waits for the old job to finish first, then deletes it, and then creates a new one with the new hash to re-run the job. I agree to push a PR in lib-common to add support for a config flag to the lib-common helper functions to support cancelling running job upon request. Until that PR is not available you can still workaround the situation from the client side by explicitly calling DeleteJob (defined in lib-common/common/job ) on the running old job, then calling DoJob as usual.

recheck

recheck

@slagle @gibizer i started using lib-common functions for jobs in the ansibleee controller. In the status section of the CR now we have an hash field with two values: job generated by lib-common functions (and AFAIK calculated by podTemplate fields) and inputHashes generated by the hashed input values of the CRs (included the deployIdentifier generated when deployStrategy.deploy=true in openstack-k8s-operators/dataplane-operator#174). I still didn't add the code to enable the deletion of the old jobs... should i compare the value of inputHashes on for CRs with the same .metadata.name and then launch job.deleteJob before the "usual" doJob operation?

@rebtoor Sorry for the late response on this. I think ansibleee can work without any job cancellation. So no need to delete the job manually either. The current lib-common code will take care of re-running the job is the hash of the job changes. The only downside of this is that if the hash of the job changes then the new job will only be started after the old job finishes. So it can take more time to run the new job than strictly necessary.

@rebtoor Sorry for the late response on this. I think ansibleee can work without any job cancellation. So no need to delete the job manually either. The current lib-common code will take care of re-running the job is the hash of the job changes. The only downside of this is that if the hash of the job changes then the new job will only be started after the old job finishes. So it can take more time to run the new job than strictly necessary.
So I suggest to do two steps. Switch to the lib-common Job helpers in this PR. Without adding support for cancelling any running Job. Then in a separate step and PR discuss if we really want to cancel running ansible jobs. I heard different people feeling differently about the cancellation. One argument is that an ansible job can be long running so waiting for it to finish could mean waiting for a long time. Another argument is that cancelling a running ansible job is unsafe as we cannot be sure that it does not result in a broken env on the EDPM node that prevents running the next job.

Hey @gibizer , thanks for the reply!
ack about skipping the job cancelling part for another step, makes totally sense.
BTW, I'm using the lib-common code now but I noticed that when the job is completed successfully, the function
if ansibleeeJob.HasChanged() {
		instance.Status.Hash["job"] = ansibleeeJob.GetHash()
		r.Log.Info(fmt.Sprintf("AnsibleEE CR '%s' - Job %s hash added - %s", instance.Name, jobDef.Name, instance.Status.Hash["job"]))
	}

keeps updating the hash in the job even if nothing has changed on the CR. I don't understand why the job keeps updating itself with a new hash even if it's completed. :\
Any hints?
cc @slagle

BTW, I'm using the lib-common code now but I noticed that when the job is completed successfully, the function
if ansibleeeJob.HasChanged() {
		instance.Status.Hash["job"] = ansibleeeJob.GetHash()
		r.Log.Info(fmt.Sprintf("AnsibleEE CR '%s' - Job %s hash added - %s", instance.Name, jobDef.Name, instance.Status.Hash["job"]))
	}

keeps updating the hash in the job even if nothing has changed on the CR. I don't understand why the job keeps updating itself with a new hash even if it's completed. :\

Strange. If the hash changes that means something is changed in the data being hashed. So I would try to debug that what is changing.

BTW, I'm using the lib-common code now but I noticed that when the job is completed successfully, the function
if ansibleeeJob.HasChanged() {
		instance.Status.Hash["job"] = ansibleeeJob.GetHash()
		r.Log.Info(fmt.Sprintf("AnsibleEE CR '%s' - Job %s hash added - %s", instance.Name, jobDef.Name, instance.Status.Hash["job"]))
	}

keeps updating the hash in the job even if nothing has changed on the CR. I don't understand why the job keeps updating itself with a new hash even if it's completed. :\

Strange. If the hash changes that means something is changed in the data being hashed. So I suggest to debug that what is changing.

Before you dig deeper. I suggest too bump the lib-common version of this patch to a newer version. There is a chance that what you see is actually part of the issue fixed by https://github.com/openstack-k8s-operators/lib-common/pull/254

recheck

hey @fao89 can you give a look since i rebased my code due to https://github.com/openstack-k8s-operators/openstack-ansibleee-operator/pull/158 ? Thanks!


About "seg_label":

The new annotation file provided by BDD100K provides the mask map directly, while YOLOP author handles json file——gen_bDD_seglabel.py with different filling values from the mask map generated by the official.I don't have the old annotations, how can I  haddle the AutoDriveDataset.py with mask?
if self.cfg.num_seg_class == 3:
_,seg0 = cv2.threshold(seg_label[:,:,0],128,255,cv2.THRESH_BINARY) # 二值分割
_,seg1 = cv2.threshold(seg_label[:,:,1],1,255,cv2.THRESH_BINARY)
_,seg2 = cv2.threshold(seg_label[:,:,2],1,255,cv2.THRESH_BINARY)
else:
_,seg1 = cv2.threshold(seg_label,1,255,cv2.THRESH_BINARY)
_,seg2 = cv2.threshold(seg_label,1,255,cv2.THRESH_BINARY_INV)
_,lane1 = cv2.threshold(lane_label,1,255,cv2.THRESH_BINARY)
_,lane2 = cv2.threshold(lane_label,1,255,cv2.THRESH_BINARY_INV)
用官方给的mask图做这个分类的时候好像有点问题，作者原来的json处理方式其中一些字段又和现在的json字段不同，处理不成作者需要的那种mask结果，有没有朋友知道怎么处理这一块啊

for seg_label and lane_label, YOLOP code is picking up these from the mask maps already provided. Do you want to create mask maps again ? It is not picking up the masks from the json, only the path is being used from json.


Hugo: Homepage banner

Add simple banner component with 2 columns
Add banner component to homepage + add content & visual

For: https://linear.app/usmedia/issue/CUE-162

Let's wait on this one.

Closed via 9a543c82b9d1252dfef3860cf4dc46c8c1d80b59


How to implement onConnection in RouterHandler?

Hello,
some code:
main.cpp
    std::shared_ptr<RouterService> router = std::make_shared<RouterService>();
    std::shared_ptr<Http::Endpoint> server = std::make_shared<Http::Endpoint>(addr);

    server->init(opts);
    server->setHandler(router->handler());
    server->serveThreaded();

routerService.h
#pragma once

#include <pistache/router.h>

using namespace Pistache;

class RouterService : public Rest::Router {
public:

    RouterService();
    void setupRoutes();
};

routerService.cpp
#include "serializerService.h"
#include "userEndpoint.h"
#include "rootEndpoint.h"
#include "routerService.h"

RouterService::RouterService() {
    setupRoutes();
}

void RouterService::setupRoutes() {
    // Main Routes
    this->addRoute(Http::Method::Get, "/", Rest::Routes::bind(RootEndpoint::doMain));
    this->addRoute(Http::Method::Get, "/first", Rest::Routes::bind(RootEndpoint::doFirst));
    this->addRoute(Http::Method::Get, "/token", Rest::Routes::bind(RootEndpoint::getToken));

//    // User Routes
    this->addRoute(Http::Method::Get, "/user", Rest::Routes::bind(UserEndpoint::getUsers));
    this->addRoute(Http::Method::Get, "/user/:id", Rest::Routes::bind(UserEndpoint::getUser));

    // Admin Routes
}

In which file I should declare onConnection function?

I do not understand your question.
Pistache::Address addr(Pistache::Ipv4::any(), Pistache::Port(rest_port));
httpEndpoint.reset(new Pistache::Http::Endpoint (addr));
auto opts = Pistache::Http::Endpoint::options()
    .threads(num_threads)
    .flags(Pistache::Tcp::Options::ReuseAddr);
httpEndpoint->init(opts);
setup_routes();
httpEndpoint->setHandler(router.handler());
httpEndpoint->serve();	// blocking function

ok, but I'd like to do something onConnection() but RouterHadler implements only onRequest().

OK.  I see.  I only use onRequest I guess.  Perhaps @dennisjenkins75 can comment on this?

Sorry, I do not know.  I do not use this feature of pistache.  I'm only the "guest maintainer", not the author (the author has abandoned the project).
If you would like to add a feature or bug fix, those are welcome.  Please add unit tests to cover the new/changed functionality.  I will review the PR and merge it.

Oh, why author abandoned thisproject?

The development of pistache was subsided by his previous employer; he/they had a need for it.  However, a while ago he changed employers and is busy committing his time to his new employer.  i tracked him down to get commit rights to the repo so that I could merge some PRs that several pistache users wanted (without forking the project).
I'm happy to review and merge PRs, but I also lack time to provide forward-looking development.  I am sorry, but this is the best that I can do right now.

@dennisjenkins75 so, You are trying to say that pistache as framework won't be developed, no new features like session handler, websockets wchich are basics of REST API?

I did not say that there would be no new development. Development will occur because pistache users want features and big fixes and are willing to do that work themselves.  Neither I nor the original author are likely to make major changes (but I will review and merge any reasonable PR).
Pistache is more like a "community garden".  Also "web sockets" is not requires for REST.  REST was first defined in 2000 by Roy Fielding [1], long before modern web sockets [2] (2008, 2010).  Not all REST apis need session handling.
If you want a feature added to pistache, you'll either need to code it yourself (which can seem daunting if you are just starting to learn the C++ language) or find someone who also wants the feature and collaborate with them.  Sadly, pistache does not have a web forum or much of a community / user group.  The original author hangs out on a slack server; others use an IRC server; I've not been on either in months.
[1] https://en.wikipedia.org/wiki/Representational_state_transfer
[2] https://en.wikipedia.org/wiki/WebSocket

This issue also can be close the new feature are welcome by PR


Download manifest button hides with a smaller screen - responsive behaviour

Hi,
I don't know what the policy is for the responsiveness and the manifest buttons, but the buttons are not visible even at relatively decent desktop widths.
I think they should still be visible, because the csv files are fine for downloading, right?
Or even if an action is not possible for a mobile device, the action should be to alert people about their device capabilities when they attempt to do something, but not hide possible actions from users.
Open to thoughts.
Gabs

┆Issue Number: HCAB-314

HI @gabsie thanks for opening this.  I thought we had a ticket for this one but I can't find it. Yes, we need to use the device type and not just the browser window size to decide when to show the buttons vs the message.


Closely track mempool byte total. Add "getmempoolinfo" RPC.

Goal:  Gain live insight into the mempool.  Groundwork for future work
that caps mempool size.

Fee changes related, expect conflicts when merging.

Works as advertised locally. Waiting on at least travis (and maybe we get the fee rate change in too?)

Needs rebase, also should now be able to include the full merge with the fee changes.

Now in #1166 due to misunderstanding. Closing here


Z2-Converter : GetSmartContractState does not return _evm_storage field when callled with evm contract.

If we call GetSmartContractState on evm contract. It doesn't return _evm_storage field but zq1 does return.
--- Viewing difference for GetSmartContractState (0xf42d1058f233329185A36B04B7f96105afa1adD2) ---

Keys present in ZQ1 but missing in ZQ2:
  root['result']['_evm_storage']

In my view, this is an internal implementation detail of ZQ1 that leaks out. If no one objects, let's not do this. This is important for this feature in particular, because some alternative state storage mechanisms we're considering optimise for single-key retrieval from contract storage and would be quite slow at returning a contract's whole state.


Adding odometry_serialcom to documentation index for distro

I'd like odometry_serialcom to be indexed and documented on ros.org

@wlfws friendly ping


perf: let CachedSource work right

Summary

For relevant context, see the pull request at https://github.com/web-infra-dev/rspack-sources/pull/89
Require Documentation?

[x] No
[ ] Yes, the corresponding rspack-website PR is __

!bench


Configs / Info button

Me again 😄
Please consider adding button for info (aka question mark) and configs (aka gear)... or 2 in 1.
IMHO current right-click way is not obvious for new users and I personally only realized there are configs after seeing them in one of the description gifs

It means that gifs do their job well :D,
But indeed, for better UX better is to have things visible.
Button was added, and it will be released in 1.4.0.


[WIP] Initial prototype of from_xml support

This is a continuation of https://github.com/databricks/spark-xml/pull/334/
This implements a from_xml expression that can turn an XML string column into a parsed structured column. It also opens up inferSchema for a Dataset[String] as a necessary support function.
The rest is really mild refactoring.

CC @SpaceRangerWes and @HyukjinKwon for comment.
The only thing I don't quite like is that you have to separately infer the schema for the column, then apply it, but, otherwise pretty fine IMHO.

(Also I'd need to update docs accordingly to describe the new functionality)

@HyukjinKwon thank you - I believe I addressed all your previous comments, and new ones. The only item seems to be what to do about inferring schema. Do you have better ideas there?

Some possible TODOs, which I might pursue in another PR:

A from_xml function that operates on a String, for direct use in a UDF
Expand the support (as in the original PR) to operate on an array of strings, and return an array of structs, if possible. That helps if the XML is in an array of strings

Codecov Report

Merging #429 into master will decrease coverage by 0.39%.
The diff coverage is 91.52%.

@@            Coverage Diff            @@
##           master     #429     +/-   ##
=========================================
- Coverage   88.62%   88.22%   -0.4%
=========================================
  Files          15       17      +2
  Lines         791      807     +16
  Branches       64       68      +4
=========================================
+ Hits          701      712     +11
- Misses         90       95      +5

Impacted Files
Coverage Δ

.../main/scala/com/databricks/spark/xml/package.scala
16.66% <ø> (ø)
:arrow_up:

...la/com/databricks/spark/xml/util/InferSchema.scala
88.43% <100%> (-0.6%)
:arrow_down:

...ain/scala/com/databricks/spark/xml/functions.scala
100% <100%> (ø)

...abricks/spark/xml/parsers/StaxXmlParserUtils.scala
96.55% <100%> (+0.8%)
:arrow_up:

...a/com/databricks/spark/xml/XmlDataToCatalyst.scala
63.63% <63.63%> (ø)

...m/databricks/spark/xml/parsers/StaxXmlParser.scala
96.82% <96.55%> (-0.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d155b1b...57f845b. Read the comment docs.

@HyukjinKwon I moved the methods, but didn't rename. If you like, have another look.

I'll just merge it in and make a followup later if there;s something I find that I want to fix.

OK. I was going to release 0.8.0 maybe next week, unless you spot something critical that shouldn't be left for 0.9.0.

I don't think there would be anything critical so should be fine.


UTC to local time conversion

Hey, @anikfal  i was just curious when we are extracting the data or generating the contour plots from the WRF file can we convert the time zone from UTC to local time?
Another issue is when we are plotting cape_3d the title of the plot is written "Vertical profiles of CIN" please check.

namelist.wrf.docx
Look at the namelist.wrf file


bosh-dns does not work with RHEL

If one is using RHEL stemcell and deploys bosh-dns release on it, it does not work. This is because it uses resolvconf utility which comes with ubuntu but does not come with RHEL.
Please see following log from bosh_dns_resolvconf.stdout.log:
[Cmd Runner] 2018/11/22 10:31:52 DEBUG - Running command 'resolvconf -u'
[NameserverConfigMonitor] 2018/11/22 10:31:52 ERROR - running: Updating nameserver configs: Executing resolvconf: Starting command 'resolvconf -u': exec: "resolvconf": executable file not found in $PATH
Because this error nameserver <IP_ADDRESS> is not added to /etc/resolve.conf and as a result etcd does not come up.
Perhaps using nmcli utility (which is available across all distributions) instead of resolvconf  would help.
~Prasanna

Closing due to inactivity. Please feel free to open again if you'd like to discuss it.


master commit 021a2ed works with sheets_and_friends but 8b9f0c6 doesn't

NMDC uses sheets_and_friends to build a custom LinkML schema based on Google Sheets, and then to make a DataHarmonizer via the data.tsv/data.js route in the master branch.
We're preparing to switch to the linkml datastructure branch
I just updated to commit 8b9f0c6 of the master branch, and the DataHarmonizer built by make_data.py was blank.

I checked out 8b9f0c6 and ran python ../../script/make_data.py when in one of the template folders (canada_covid19) and data.js was generated, and main.html seemed to work fine.   This version did split out some of the template code:
<script src="script/export_utils.js"></script>
<script src="script/validation.js"></script>
<script src="script/file_utils.js"></script>
<script src="script/field_rules.js"></script>
<!-- script src="template/menu.js"></script -->
<script src="script/main.js"></script>

So was it the inclusion of dataharmonizer as an app that failed? If so its probably because export_utils.js etc. now need to be included as well as main.js   If its that make_data.py didn't work somehow, that would be more surprising, but would need an error report to debug.
d.

Is this issue pertinent any more?


Example of using SupplementaryView

Can you provide example how to use SupplementaryView? Will be great if you could apply SupplementaryView to first item in Mixed data example. cc @rawlinxx, @Sherlouk

Definitely think we need to get an example of some sort, been on my to-do list for a while
May take a look this weekend, just waiting for other pull requests to get feedback so I'm not doing  too much at once!

I'm using IGListKit for one of my project and I need to use SupplementaryView. I will be happy see example how to use it.


RMC-14 - The free night vision for marines update

Description
Possible to abuse the way smart gun goggles work to get free night vision and extended vision as marine
Reproduction
Equip SG harness, Equip SG, Equip SG headmount, remove harness, profit.
Screenshots
The goddamn video is too big to upload and I cannot compress it rn, reach out to me on the discord and I can stream it to you.

Would need to fix this by making the goggles drop if your smart gun is dropped, though I think originally I didn't because in 13 it doesn't either, since dropping your smart gun also dropping your goggles would probably get annoying.
This only works for as long as the goggles stay on, right? Like at most you can give someone else the goggles, then keep the rest of the kit yourself, and only 1 person has night vision?

Would need to fix this by making the goggles drop if your smart gun is dropped, though I think originally I didn't because in 13 it doesn't either, since dropping your smart gun also dropping your goggles would probably get annoying. This only works for as long as the goggles stay on, right? Like at most you can give someone else the goggles, then keep the rest of the kit yourself, and only 1 person has night vision?

yes

Would need to fix this by making the goggles drop if your smart gun is dropped, though I think originally I didn't because in 13 it doesn't either, since dropping your smart gun also dropping your goggles would probably get annoying. This only works for as long as the goggles stay on, right? Like at most you can give someone else the goggles, then keep the rest of the kit yourself, and only 1 person has night vision?

Yes, You could probably tie the goggles to the harness rather than the gun, as wearing the harness without the gun itself is a pretty massive disadvantage.


Allow support for aws service endpoint env vars with aws-sdk-v2

AWS has introduced service endpoint env vars
This allows for setting the following env vars when using aws-sdk-v2:

AWS_ENDPOINT_URL_
Specifies a custom endpoint that is used for a specific service, where  is replaced with the AWS service identifier. For example, Amazon DynamoDB has a serviceId of DynamoDB. For this service, the endpoint URL environment variable is AWS_ENDPOINT_URL_DYNAMODB.
For a list of all service-specific environment variables, see List of service-specific identifiers.

Setting the following ENV VARS with aws-sdk-v2 enabled should allow thanos to connect to the respective services:
AWS_ENDPOINT_URL_S3:  https://minio.beaconator-minio-tenant-default.svc.cluster.local:443
AWS_ENDPOINT_URL_STS: https://sts.minio-operator.svc.cluster.local:4223/sts/minio-tenant-default

I have the following PR which bumps the aws-sdk-v2/config package and have tested this successfully locally: https://github.com/thanos-io/objstore/pull/132


Update readme.md

In response to https://github.com/w3f/polkadot-deployer/issues/20 I updated the readme.md

Closes https://github.com/w3f/polkadot-deployer/issues/20


The wording of the below statement is confusing

[Hi Team, the wording of this statements ("We don't support extensions to Windows Admin Center in the Azure portal at this time. If you manually installed Windows Admin Center in the VM to manage multiple systems, installing this VM extension reduces the functionality to managing just the VM in which the extension is installed. Uninstall the extension to get back full functionality.") makes it hard for the reader to fully understand what is being said.
Is there a better way in which this can be worded?]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0af46722-5b7c-eb50-f6fe-ba7ce4552f85
Version Independent ID: b2710445-053e-14fd-1cf9-813cdc628d06
Content: Use Windows Admin Center in the Azure portal to manage a Windows Server VM
Content Source: WindowsServerDocs/manage/windows-admin-center/azure/manage-vm.md
Product: windows-server
Technology: windows-admin-center
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

Fair question, interesting problem as well, at least from a logical and linguistical viewpoint. I will start making some notes here, in case I can come up with some valid phrasing to simplify the text, while still keeping the intended meaning. (https://docs.microsoft.com/en-us/windows-server/manage/windows-admin-center/azure/manage-vm#overview-of-functionality)

Extensions to Windows Admin Center are currently not supported in the Azure portal.
If you installed Windows Admin Center on the virtual machine to manage multiple systems, the functionality of this VM extension will be reduced to managing single VMs only where the extension is installed. Remove the extension to restore your intended functionality.

(Yes, I know, it does not look like it changed much. I translated it to my own language, Norwegian, to see how much I could boil the text down, then translated it back again to English, but it did not make a lot of difference.)

Hello,
I greatly appreciate you taking the time to understand my feedback and the work you are putting out to make these documents even better (I give you great credit for being a non native English speaker and working on documentation as these).
The changes you’ve made so far are a lot clearer and I do look forward to what more can be done to have the documents be as precise as they can be.
Best Regards,
Sephanyah Peters
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Trond B. @.>
Sent: Tuesday, April 27, 2021 01:39 PM
To: @.>
Cc: @.>; @.>
Subject: Re: [MicrosoftDocs/windowsserverdocs] The wording of the below statement is confusing (#5485)
Fair question, interesting problem as well, at least from a logical and linguistical viewpoint. I will start making some notes here, in case I can come up with some valid phrasing to simplify the text, while still keeping the intended meaning. (https://docs.microsoft.com/en-us/windows-server/manage/windows-admin-center/azure/manage-vm#overview-of-functionalityhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fwindows-server%2Fmanage%2Fwindows-admin-center%2Fazure%2Fmanage-vm%23overview-of-functionality&data=04|01||071f1c2640aa4e71182c08d909a36d48|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637551419776347241|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=fNlkzP05iAPXPM0D89qua2XjiNdQq02hP3awZezHTGE%3D&reserved=0)
Extensions to Windows Admin Center are currently not supported in the Azure portal.
If you installed Windows Admin Center on the virtual machine to manage multiple systems, the functionality of this VM extension will be reduced to managing single VMs only where the extension is installed. Remove the extension to restore your intended functionality.
(Yes, I know, it does not look like it changed much. I translated it to my own language, Norwegian, to see how much I could boil the text down, then translated it back again to English, but it did not make a lot of difference.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fwindowsserverdocs%2Fissues%2F5485%23issuecomment-827788388&data=04|01||071f1c2640aa4e71182c08d909a36d48|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637551419776357232|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ID%2FZxWxMkJHb9u8hDh4dv46jooTEucAdUqcpexnrpuA%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHHRWGXU6TYMGP3F5A5A6JLTK3ZFPANCNFSM43VFO4LQ&data=04|01||071f1c2640aa4e71182c08d909a36d48|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637551419776357232|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=BaOm%2B%2Bg9%2BeHuZyoRseLLAOpY95luaBJVNrVBBQ%2Ft8%2FA%3D&reserved=0.

Thanks for the feedback.  I have changed the text to read: "If you manually installed Windows Admin Center in the VM to manage multiple systems, installing this VM extension reduces the functionality to managing just this VM only. Uninstall the extension to get back full functionality."
The change should be visible in a few hours.  If there is any further clarification required, please let me know.
#please-close


build: move server rendering to dist

Verifying that Material works with platform-server now happens in the dist/ folder (instead of the src/ folder)
Adds a gulp task to build the universal application. In the future serving the app will be also part of this

Addressed feedback.


[BUG] k3d create --wait doesn't appear to wait long enough

What did you do?

Create a new cluster with k3d create --wait 360. The command comes back almost immediately with success.
Immediately try to run k3d get-kubeconfig, there is an error (Couldn't copy kubeconfig.yaml from server container).

What did you expect to happen?
I expected the cluster to be operational and to be able to apply yaml to it.
Note: taking a look at how --wait is implemented, I worked around this by running:
grep -m 1 "Successfully registered node" \
    <(docker logs $(docker ps -f "label=cluster=left" -q) -f 2>&1)

Screenshots or terminal output
PORT=$(/Applications/Xcode.app/Contents/Developer/usr/bin/make get-port); k3d create \
		--name left \
		--api-port ${PORT} \
		--publish $((${PORT} + 80)):80 $((${PORT} + 443)):443 \
		--wait 360
INFO[0000] Created cluster network with ID c827ee310266f0d2c4ccea97bfa5b1c25f8a1cfd18145ff60a4eccee7907eb2f
INFO[0000] As of v2.0.0 --port will be used for arbitrary port mapping. Please use --api-port/-a instead for configuring the Api Port
INFO[0000] Created docker volume  k3d-left-images
INFO[0000] Creating cluster [left]
INFO[0000] Creating server using docker.io/rancher/k3s:v0.10.0...
INFO[0000] SUCCESS: created cluster [left]
INFO[0000] You can now use the cluster with:

export KUBECONFIG="$(k3d get-kubeconfig --name='left')"
kubectl cluster-info
KUBECONFIG=$(k3d get-kubeconfig --name='left') && kubectl apply -f k8s
FATA[0000]  Couldn't copy kubeconfig.yaml from server container 2884a6469db07e90395b3beb72b4951813b9b197e8c78edf3d23d8d1daa725d4
Error: No such container:path: 2884a6469db07e90395b3beb72b4951813b9b197e8c78edf3d23d8d1daa725d4:/output/kubeconfig.yaml

Which OS & Architecture?

OSX

Which version of k3d?
k3d version v1.3.4

Which version of docker?
Client: Docker Engine - Community
 Version:           19.03.5
 API version:       1.40
 Go version:        go1.12.12
 Git commit:        633a0ea
 Built:             Wed Nov 13 07:22:34 2019
 OS/Arch:           darwin/amd64
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          19.03.5
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.12
  Git commit:       633a0ea
  Built:            Wed Nov 13 07:29:19 2019
  OS/Arch:          linux/amd64
  Experimental:     true
 containerd:
  Version:          v1.2.10
  GitCommit:        b34a5c8af56e510852c35414db4c1f4fa6172339
 runc:
  Version:          1.0.0-rc8+dev
  GitCommit:        3e425f80a8c931f88e6d94a8c831b9d5aa481657
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

Here's the makefile I'm using (with my workaround) - https://github.com/grampelberg/multi-cluster/blob/master/local/Makefile

You're right! We're not waiting long enough and kubelet might not even be running.
Unfortunately, the log output of k3s changed a bit with newer versions, so I am not sure if we can get to a backwards-compatible solution here. I will have a look to get a solution that supports at least the last few major versions :+1:

Successfully registered node
This log message only shows up in worker nodes and we're pulling the kubeconfig form the server/master node, so we'd need to choose a different one, but this shouldn't be a problem :+1:

BTW: I like your Makefile, especially the port finding part :+1:

I just pushed a change to master (see commit 112ea46).
Verified via k3d --timestamp --verbose create --wait 360 -n test -w 2 -a 6550 --image rancher/k3s:v0.7.0 && export KUBECONFIG="$(k3dv2 get-kubeconfig --name='test')"

Fixed in the latest release. Thanks for pointing this out!

Cool! Thanks for the fix =)


RHIDP 3742-Discover-Correct Book Title

IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s): 1.3, 1.4

Issue: RHIDP-4827

Link to docs preview:

Reviews:

[ ] SME: @
[ ] QE: @ mention assignee
[ ] Docs review: @hmanwani-rh
[ ] Additional review: @mention assignee (by writer)

Additional information:

This PR has also content from https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/663/files, is it a mistake?

/cherrypick release-1.3


Replace ImageAccess::descriptor_layouts()

Changelog
### Breaking changes
- The `buffer_with_range(_array)` constructor of `WriteDescriptorSet` now takes `DescriptorBufferInfo` structs.
- Removed the `descriptor_layouts` method on the `ImageAccess` trait. All images by default now use the `General` layout for storage image descriptors, and `ShaderReadOnlyOptimal` for all other image descriptors.

### Additions
- Added `image_view_with_layout(_array)` and `image_view_with_layout_sampler(_array)` constructors to `WriteDescriptorSet`, which let you control the image layouts used for image views bound to a descriptor.

This gets rid of one of the last methods of ImageAccess, to help with the image unification. The image layout is now included in the WriteDescriptorSet element definitions, and there's new constructors to specify it.

I solved it in the end by making image + sampler a tuple of DescriptorImageViewInfo and Arc<Sampler>.


add NUnit3TestAdapter so the unit tests can be run from visual studio

This enables the integrated Test Explorer:

I don't use that, but look sgood.

thanks

after merging this I get Compiler Warning 1685
The predefined type 'System.Runtime.CompilerServices.ExtensionAttribute' is defined in multiple assemblies in the global alias;

I had to revert for now. Any ideas?

Hm, I can't reproduce the warning with a2596d04dd8b328d226d8a7740392c4d15f25f27.
Also, I can't find the warning in the CI build of this pr: https://ci.appveyor.com/project/SteffenForkmann/paket/build/<IP_ADDRESS>73
Did reverting the PR fix it for you?

yes it did. It only fails to build in VS. It worked in normal build

I did a git clean and then a rebuild in VS but still can't reproduce it:

Ok so I found the cause - nunit defines the attribute ...

I'm not sure why it doesn't fail in VS 2015, this looks like a difference between the native compiler and roslyn.

@forki:
Is there somethign special about the NUnit3TestAdapter package?
When adding the package using NuGet Visual Studio detects all tests as it should.
Once I remove it and add it using paket, Visual Studio is not detecting the tests anymore.
If I only exclude the packages.config from the project and change the NUnit3TestAdapter reference that is added as project import to the files added by paket, it is still working.
Once I completely remove the packages.config, everything breaks again. Do you know of any voodoo that is going on in there?
Thanks for your help.
Kind Regards,
Florian

I assume it's one of the packages that need the following setting: https://fsprojects.github.io/Paket/nuget-dependencies.html#Putting-the-version-number-in-the-path

@forki That seems to be the solution, thanks a lot :)


[Feature Request]: Render returned documents from database

Problem to solve
I would like to easily render my document which is stored in database.
Proposed solution
I'm not sure what the best method would be.
Describe alternatives you've considered
Additional python library?
Additional context
N/A

Hello,
Is the template which is stored in a database?  or the final result?
Rhanks

I believe I can help explain, since I am interested in the same feature. We also store our documents as "blobs" in a database.
Is it possible to pass a buffer to carbone.render, rather than loading the template from the file system?

Hello,
Is the template which is stored in a database? or the final result?
Rhanks

The template would be stored in Database, the final resul can easily be downlanded from the app.

I believe I can help explain, since I am interested in the same feature. We also store our documents as "blobs" in a database.
Is it possible to pass a buffer to carbone.render, rather than loading the template from the file system?

I contacted Carbone Support and they told me it's impossible to pass a Buffer to CarboneJS.

Hello @Marouane, it is not possible for now, we created the issue on our side and we will probably make it in the coming months. I will notify you when we work on it and a beta is available ;)


Evaluate Switching to CLion

Sadly, CLion only supports MinGW compilers at this point, so the inline assembler syntax is different. It does support more of C++11 and the IDE is vastly superiour to Visual Studio. Especially the Git integration.

PS: this is low priority


Configuration setting for Pester path

Could we add a configuration setting PesterModulePath so it can be specified relative to the project path where the Pester module is located, and so Pester Test Adapter does not assume it is in $env:PSModulePath?

I can't say I will make this a priority since you can do it as part of your discovery or test run phase, other than if you want to use a custom version of pester not already on your psmodulepath. I'll put it on the to-do stack though :)

I’m happy you put it on the back log. Thank you. 😊 Wish I could help but don’t know where to start. 😊
Some more information, that you probably already know. The problem is that the Pester Test Adapter adapter do not work unless it has Pester in the PSModulePath, if Pester is not available it will not run discovery since it does this prior to discovery:
https://github.com/pester/vscode-adapter/blob/0bae405e6420020af4c5aed70b758d62f5d5d7d6/Scripts/PesterInterface.ps1#L472
with a configuration option we could import the Pester module from a custom relative path so that a user does not need to install the Pester module in a PSModulePath.
This will help us since our pipeline is using PSDepend that downloads the (Pester module) version specified in a configuration file to a relative path to the local repository root.


python37Packages.django-q: 1.3.3 -> 1.3.4

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.django-q is: "A multiprocessing distributed task queue for Django"
meta.homepage for python37Packages.django-q is: "https://django-q.readthedocs.org"
meta.changelog for python37Packages.django-q is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.3.4 with grep in /nix/store/0v8j1ddgrm09d7cf7qqdpy2k0hg2pia8-python3.7-django-q-1.3.4

directory tree listing: https://gist.github.com/f23301a253a19e26619cbb6a2ac4a62e

du listing: https://gist.github.com/ef77be71dd5e7ca998772b1b2d30ab2e

Rebuild report (if merged into master) (click to expand)

26 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 i686-linux rebuild(s)
5 x86_64-darwin rebuild(s)
7 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
mailman-web
python37Packages.django-q
python37Packages.hyperkitty
python37Packages.mailman-web
python38Packages.django-q
python38Packages.hyperkitty
python38Packages.mailman-web

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0v8j1ddgrm09d7cf7qqdpy2k0hg2pia8-python3.7-django-q-1.3.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.django-q https://github.com/r-ryantm/nixpkgs/archive/850c97575bdd30baae97bc8c11597921da26dea6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0v8j1ddgrm09d7cf7qqdpy2k0hg2pia8-python3.7-django-q-1.3.4
ls -la /nix/store/0v8j1ddgrm09d7cf7qqdpy2k0hg2pia8-python3.7-django-q-1.3.4/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

6 packages built:

mailman-web (python38Packages.mailman-web)
python37Packages.django-q
python37Packages.hyperkitty
python37Packages.mailman-web
python38Packages.django-q
python38Packages.hyperkitty

Maintainer pings

nix-review pr 103326 builds, django-q is found by python3 but I have no idea how to test it.

when nixpkgs-review drops you into a shell, you can looks at the results in the ./results/<pname> directory


Unexpected behavior taking the minimum of an array of np.inf when parallel=True.

Reporting a bug

[x] I am using the latest released version of Numba (most recent is visible in
the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included below a minimal working reproducer (if you are unsure how
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).

When using np.min on an array with all infinite values, I expect np.inf to be returned. This happens correctly when the function is compiled in nopython mode. When parallel=True however, the minimum is returned as the largest float64 value
In the code snippet below the first two assertion pass on my machine but the third fails.
import numba
import numpy as np

@numba.njit()
def min(a):
    return a.min()

@numba.njit(parallel=True)
def pmin(a):
    return a.min()

infs = np.array([np.inf, np.inf])

assert min(infs) == np.inf
assert pmin(infs) == np.finfo(np.float64).max
assert min(infs) == pmin(infs)

@mbattifarano thanks for reporting this, I can reproduce this on the current master 0.50.0dev0-179-g86e600d0ec and this might be a bug related to the parallel accelerator. @DrTodd13 could you have a look?

It's a simple impl bug:
https://github.com/numba/numba/blob/86e600d0ec867402cb4f41100295878586f2a019/numba/parfors/parfor.py#L123-L145

@stuartarchibald how about we initialize val then to inf in the float case? What about the max impl.?

@esc @stuartarchibald It seems like initializing val to inf for float should work.  Can you try that Val?


add the ability to optionally normalize

I'm currently trying to port a python library built on top of scipy/numpy, and the dct function in scipy, has an optional param norm, which when set to "ortho" seems to apply a scaling function depending on the transformation type.
This can be applied after the transformation, I'm currently working on a closure to do so for dct2, but unless I'm misunderstanding what these functions are doing, it seems like its possible to apply this during the first pass through

see the new branch  dct_ortho.
I will eventually update the library on crates.io too

Branch v0.4 has now the option to use custom normalizations.
There is also an example (fft_norm)


Response status code does not indicate success: 414 (Request-URI Too Large)

I don't think anything has changed but we've started getting errors when sending errors to YouTrack for certain errors:
System.Net.Http.HttpRequestException: Response status code does not indicate success: 414 (Request-URI Too Large).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at YouTrackSharp.Issues.IssuesService.<CreateIssue>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Seq.App.YouTrack.YouTrackIssuePoster.<OnAsync>d__6.MoveNext()

I'm not sure what you're sending in the url's payload but the log message doesn't look too unusual: Exception processing Stripe Webhook: Error converting value {null} to type 'System.Int64'. Path 'data.object.status_transitions.paid_at', line 128, position 23.

The JSON log is only 19KB

We are getting this too for some errors.  The error in question was 301 characters.  Not sure if you are using that in some fashion.

The latest is upgraded to YouTrack new API -- please try it now.

Have upgraded but get the following error:
System.IO.FileNotFoundException: Could not load file or assembly 'Serilog.Formatting.Compact.Reader, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=24c2f752a8e58a10' or one of its dependencies. The system cannot find the file specified.
File name: 'Serilog.Formatting.Compact.Reader, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=24c2f752a8e58a10'
   at Seq.Apps.GenericHost.AppHost.ReadSerilogEvent(String clef, String& eventId, UInt32& eventType)
   at Seq.Apps.GenericHost.AppHost.<SendTypedEventAsync>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Seq.Apps.GenericHost.AppHost.<SendAsync>d__16.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Seq.Apps.GenericHost.Program.<Main>d__0.MoveNext()

WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].

Hi Tim; we've seen this one pop up a couple of times - I'm guessing that you're running 5.1.3364?

I'm guessing that you're running 5.1.3364?

That's correct @nblumhardt, is there something we can do about it?

It's a bit of a puzzle; the latest version appears to work for me with a fresh 5.1.3364 install (I have to use a dummy YouTrack URL, but the part of the code shown in the stack trace above is executed successfully).
My current theory is that it's either GAC or Windows Defender-related.

If some other app is adding Serilog.Formatting.Compact.Reader to the GAC, then it should show up under %WINDIR%\Assembly.
If Windows Defender is "quarantining" the DLL, then running the 5.1.3364 installer again, and selecting "Repair", should fix it.

Do either of these shine any light on it?

Didn't appear to no. I can't spot anything in the GAC. Seq is the only thing on this server. I didn't think to try adding the folder to the ignores on Windows Defender but upgrading appears to have resolved the issue.

Okay, thanks for checking it out - the mystery remains :-) but glad you're up and running! 👍

I think I spoke too soon sadly as I've found the last few times I've used it I've been getting this error again
System.Net.Http.HttpRequestException: Response status code does not indicate success: 414 (Request-URI Too Large).
   at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
   at YouTrackSharp.Issues.IssuesService.<CreateIssue>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Seq.App.YouTrack.YouTrackIssuePoster.<OnAsync>d__6.MoveNext()

The log message I'm sending isn't particularly large (a single exception and a dozen properties).
I've anonymised the data but kept the string lengths in case it helps. Here's the JSON
{"@t":"2020-08-04T05:30:18.1662173+01:00","@mt":"Unhandled exception","@m":"Unhandled exception","@i":"3c37575a","@l":"Fatal","@x":"System.InvalidOperationException: There is already an open DataReader associated with this Command which must be closed first.\r\n   at System.Data.SqlClient.SqlInternalConnectionTds.ValidateConnectionForExecute(SqlCommand command)\r\n   at System.Data.SqlClient.SqlConnection.ValidateConnectionForExecute(String method, SqlCommand command)\r\n   at System.Data.SqlClient.SqlCommand.ValidateCommand(String method, Boolean async)\r\n   at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method, TaskCompletionSource`1 completion, Int32 timeout, Task& task, Boolean& usedCache, Boolean asyncWrite, Boolean inRetry)\r\n   at System.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method)\r\n   at System.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior, String method)\r\n   at System.Data.SqlClient.SqlCommand.ExecuteDbDataReader(CommandBehavior behavior)\r\n   at System.Data.Common.DbCommand.ExecuteReader(CommandBehavior behavior)\r\n   at StackExchange.Profiling.Data.ProfiledDbCommand.ExecuteDbDataReader(CommandBehavior behavior) in c:\\Code\\github\\SamSaffron\\MiniProfiler\\StackExchange.Profiling\\Data\\ProfiledDbCommand.cs:line 235\r\n   at System.Data.Common.DbCommand.ExecuteReader()\r\n   at xxxxxxxxxx.DataAccessLayer.Repositories.CategoryRepository.<GetDisplayCategoryTree>b__6_0() in B:\\projects\\xxxxxxxxxxxxxxxx\\src\\xxxxxxxxxxxxxxxx\\xxxxxxxxxx.DataAccessLayer\\Repositories\\CategoryRepository.cs:line 54\r\n   at xxxxxxxxxx.DataAccessLayer.Repositories.CategoryRepository.GetFromCache[T](String objectKey, Func`1 toDoIfNotInCache, Int32 cacheDuration) in B:\\projects\\xxxxxxxxxxxxxxxx\\src\\xxxxxxxxxxxxxxxx\\xxxxxxxxxx.DataAccessLayer\\Repositories\\CategoryRepository.cs:line 39\r\n   at xxxxxxxxxx.DataAccessLayer.Repositories.CategoryRepository.GetDisplayCategoryTree() in B:\\projects\\xxxxxxxxxxxxxxxx\\src\\xxxxxxxxxxxxxxxx\\xxxxxxxxxx.DataAccessLayer\\Repositories\\CategoryRepository.cs:line 49\r\n   at xxxxxxxxxx.Mvc.Indexers.CategoryIndexer.GetCategoryAsDictionary(Category category) in B:\\projects\\xxxxxxxxxxxxxxxx\\src\\xxxxxxxxxxxxxxxx\\xxxxxxxxxx.Mvc\\Indexers\\CategoryIndexer.cs:line 35\r\n   at xxxxxxxxxx.Mvc.Indexers.CategoryIndexer.<GetAllData>d__7.MoveNext() in B:\\projects\\xxxxxxxxxxxxxxxx\\src\\xxxxxxxxxxxxxxxx\\xxxxxxxxxx.Mvc\\Indexers\\CategoryIndexer.cs:line 76\r\n   at Examine.LuceneEngine.Providers.SimpleDataIndexer.PerformIndexAll(String type)\r\n   at Examine.LuceneEngine.Providers.LuceneIndexer.IndexAll(String type)\r\n   at Examine.LuceneEngine.Providers.SimpleDataIndexer.PerformIndexRebuild()\r\n   at Examine.LuceneEngine.Providers.LuceneIndexer.RebuildIndex()\r\n   at xxxxxxxxxx.Mvc.Services.LuceneIndexManager.RecreateIndices() in B:\\projects\\xxxxxxxxxxxxxxxx\\src\\xxxxxxxxxxxxxxxx\\xxxxxxxxxx.Mvc\\Services\\LuceneIndexManager.cs:line 15\r\n   at xxxxxxxxxx.Mvc.Areas.xxxxxxxxxx.Controllers.TasksController.xxxxxxxxxxxxxxxxxx() in B:\\projects\\xxxxxxxxxxxxxxxx\\src\\xxxxxxxxxxxxxxxx\\xxxxxxxxxx.Mvc\\Areas\\xxxxxxxxxx\\Controllers\\TasksController.cs:line 305\r\n   at lambda_method(Closure , ControllerBase , Object[] )\r\n   at System.Web.Mvc.ActionMethodDispatcher.Execute(ControllerBase controller, Object[] parameters)\r\n   at System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary`2 parameters)\r\n   at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary`2 parameters)\r\n   at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass15.<InvokeActionMethodWithFilters>b__12()\r\n   at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func`1 continuation)\r\n   at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass15.<>c__DisplayClass17.<InvokeActionMethodWithFilters>b__14()\r\n   at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func`1 continuation)\r\n   at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass15.<>c__DisplayClass17.<InvokeActionMethodWithFilters>b__14()\r\n   at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodFilter(IActionFilter filter, ActionExecutingContext preContext, Func`1 continuation)\r\n   at System.Web.Mvc.ControllerActionInvoker.<>c__DisplayClass15.<>c__DisplayClass17.<InvokeActionMethodWithFilters>b__14()\r\n   at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethodWithFilters(ControllerContext controllerContext, IList`1 filters, ActionDescriptor actionDescriptor, IDictionary`2 parameters)\r\n   at System.Web.Mvc.ControllerActionInvoker.InvokeAction(ControllerContext controllerContext, String actionName)\r\n   at System.Web.Mvc.Controller.ExecuteCore()\r\n   at System.Web.Mvc.ControllerBase.Execute(RequestContext requestContext)\r\n   at System.Web.Mvc.ControllerBase.System.Web.Mvc.IController.Execute(RequestContext requestContext)\r\n   at System.Web.Mvc.MvcHandler.<>c__DisplayClass6.<>c__DisplayClassb.<BeginProcessRequest>b__5()\r\n   at System.Web.Mvc.Async.AsyncResultWrapper.<>c__DisplayClass1.<MakeVoidDelegate>b__0()\r\n   at System.Web.Mvc.Async.AsyncResultWrapper.<>c__DisplayClass8`1.<BeginSynchronous>b__7(IAsyncResult _)\r\n   at System.Web.Mvc.Async.AsyncResultWrapper.WrappedAsyncResult`1.End()\r\n   at System.Web.Mvc.MvcHandler.<>c__DisplayClasse.<EndProcessRequest>b__d()\r\n   at System.Web.Mvc.SecurityUtil.<GetCallInAppTrustThunk>b__0(Action f)\r\n   at System.Web.Mvc.SecurityUtil.ProcessInApplicationTrust(Action action)\r\n   at System.Web.Mvc.MvcHandler.EndProcessRequest(IAsyncResult asyncResult)\r\n   at System.Web.Mvc.MvcHandler.System.Web.IHttpAsyncHandler.EndProcessRequest(IAsyncResult result)\r\n   at System.Web.HttpApplication.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()\r\n   at System.Web.HttpApplication.ExecuteStepImpl(IExecutionStep step)\r\n   at System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)","SourceContext":"www.MvcApplication","Exception[0].Type":"System.InvalidOperationException","Exception[0].Message":"There is already an open DataReader associated with this Command which must be closed first.","HttpRequestClientHostIP":"11.222.333.444","HttpRequestClientHostName":"11.222.333.444","HttpRequestId":"e97f6d03-b103-458d-aa1d-40e2816c43a9","HttpRequestNumber":6,"HttpRequestRawUrl":"/xxxxxxxxxx/tasks/xxxxxxxxxxxxxxxxxx","HttpRequestTraceId":"00000000-0000-0000-0000-000000000000","HttpRequestType":"GET","HttpRequestUrl":"https://xxxxxxxxxxxxxxxxxxxxx/xxxxxxxxxx/tasks/xxxxxxxxxxxxxxxxxx","HttpRequestUserAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.105 Safari/537.36","HttpSessionId":"jsrmmon2drhlglgwmqqh5loe","UserName":"(anonymous)","YouTrackId":"xx","SubSystem":"www","HostingEnvironment":"LIVE"}

@timgaunt Based on this issue: https://github.com/JetBrains/YouTrackSharp/issues/94 -- I think the "summary" is too large. I'll add a truncate feature.

You could be onto something with that, I've set the summary template to be {{$Message}} and it's posted a couple of tests over fine

I've had a temporary test and truncated the Summary (title) but that hasn't entirely resolved it however if I set both the Summary and Body templates to something short then it works even for longer errors so I think the length is the issue when there are lots of properties.
For now we'll just remove the properties from the description.

That only got us so far. We've had to change the exception to report if there is one rather than output if there is.
{{#if $Exception}}
#### Exception
Please see the attached json for the stack trace
{{/if}}


update nuget packages

Pick up the otel CVE fix, plus update others since dependabot is struggling right now.
Used dotnet outdated -vl Major -u for.dependabot.only.sln (installed from https://github.com/dotnet-outdated/dotnet-outdated?tab=readme-ov-file#installation)

I can fix https://github.com/dotnet/aspire-samples/issues/192 after this, meantime I suggest merge this so the version change isn't mixed in.


code.tizen.org - example: Navigation bar not displayed properly

Visit:
https://code.tizen.org/demos?path=1.0%2Fexamples%2Fmobile%2FUIComponents%2Fcomponents%2Fnavigationelements%2Fpanel%2Findex.html
Observe:
view is broken

compare with:
https://samsung.github.io/TAU/examples/1.0/examples/mobile/UIComponents/components/navigationelements/panel/index.html

Repaired by #147

issue will be verified after code.tizen.org update

Issue works OK, but new issue was observed on navigation bar: https://github.com/Samsung/TAU-Design-Editor/issues/166


Docker Support

We should have a

[x] Dockerfile to build the tool
[x] A nice entrypoint that stitches the commandline params in
[ ] DockerImage here in the repo
[ ] A compose example (maybe on our test-examples) that

[ ]    builds the tool
[x]    mounts the project to repair
[ ]    mounts the output
[ ]    uses a configuration file

As shortly discussed in #20 , the program writes the .hi files in compilation.
Hence, the mounted input volume currently needs to be read-write (as the .hi are written).
To work around this, add a copy all to the entry point

[ ] to entrypoint: Copy from /input to /tmp_input_copy where the compilation runs
[ ] use :ro on original /input

We should have 2 Dockerfiles:
One that builds the program, and one that starts from the .exe.
This enables us to provide an image that uses the "hidden" binary and does not leak source code (for anon reasons)

We should have 2 Dockerfiles:
One that builds the program, and one that starts from the .exe.
This enables us to provide an image that uses the "hidden" binary and does not leak source code (for anon reasons)

I like this approach.

As shortly discussed in #20 , the program writes the .hi files in compilation.
Hence, the mounted input volume currently needs to be read-write (as the .hi are written).
To work around this, add a copy all to the entry point

[ ]  to entrypoint: Copy from /input to /tmp_input_copy where the compilation runs
[ ]  use :ro on original /input

I like this idea, but we have to be careful of what we copy. E.g. we should make sure we don't copy the dist-newstyle etc.

closed with #33 in commit 8935917f44cf .
The second anonymized dockerfile will be done in the experiment repo (I think it rather belongs there).
The :ro approach I do another day.


fix: dao depl script flaky

Codecov Report

Merging #454 (01e5c62) into develop (1b7f08b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #454   +/-   ##
========================================
  Coverage    72.41%   72.41%
========================================
  Files           59       59
  Lines         1820     1820
  Branches       279      279
========================================
  Hits          1318     1318
  Misses         502      502

Flag
Coverage Δ

contracts
87.18% <ø> (ø)

core-utils
53.79% <ø> (ø)

data-transport-layer
29.47% <ø> (ø)

message-relayer
83.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7f08b...01e5c62. Read the comment docs.


Linking static library failing with older Mingw64 ~gcc7.1 builds due to liberal use of experimental libraries

C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: ./libopenxr_loader.a(filesystem_utils.cpp.obj):filesystem_utils.cpp:(.text$_Z28FileSysUtilsGetCanonicalPathRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEERS4_+0x59): undefined reference to `__imp_PathCchCanonicalize'
collect2.exe: error: ld returned 1 exit status

The repo was built as a static library via,
mkdir build && cd build
cmake -G "MinGW Makefiles" ..
make all

Please migrate away from using PathCchCanonicalize located in static library Pathcch.lib as it is/was experimental. (build fail only shows when you try to link a program with it, as PathCchCanonicalize may be missing)

See also #214.
This library will be included in mingw-w64 v9, and I confirmed the loader will build with it. But that hasn't been released yet, and it won't help older mingw-w64 users anyway.

See also #214.
This library will be included in mingw-w64 v9, and I confirmed the loader will build with it. But that hasn't been released yet, and it won't help older mingw-w64 users anyway.

I'm pretty sure there's another issue about this too. I think we had agreed that you can actually no-op out the function using that (think there's only one, actually, so not that liberal 🤣 ): it's for following symlinks for manifests, which is a pattern on Linux and I asked for a Windows implementation.
Weird that it only shows up when you try to link a program with it - I had tried to get all the flags to force "eager" linking to find these issues early, though maybe that only works with dynamic linking. You probably want dynamic linking anyway, actually, in many cases, if nothing else to reduce the number of symbols exposed - if the default is still static on Windows that's just because we conflated that and having it system-wide-installed on Windows early on.
Looks like https://github.com/KhronosGroup/OpenXR-SDK-Source/pull/198 is what brought this usage in,

I'm pretty sure there's another issue about this too. I think we had agreed that you can actually no-op out the function using that (think there's only one, actually, so not that liberal 🤣 ): it's for following symlinks for manifests, which is a pattern on Linux and I asked for a Windows implementation.
Weird that it only shows up when you try to link a program with it - I had tried to get all the flags to force "eager" linking to find these issues early, though maybe that only works with dynamic linking. You probably want dynamic linking anyway, actually, in many cases, if nothing else to reduce the number of symbols exposed - if the default is still static on Windows that's just because we conflated that and having it system-wide-installed on Windows early on.
Looks like https://github.com/KhronosGroup/OpenXR-SDK-Source/pull/198 is what brought this usage in,

Fixed by #239.

Excellent. I will be testing this later.


Integration Test - Release - 2019/04/03 17:34:19

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

#Pri1

Only Microsoft employees can manage issues via commenting in this repo.

Only Microsoft employees can manage issues via commenting in this repo.

Only Microsoft employees can manage issues via commenting in this repo.

Only Microsoft employees can manage issues via commenting in this repo.

Only Microsoft employees can manage issues via commenting in this repo.

Only Microsoft employees can manage issues via commenting in this repo.


EXCEPTION CAUGHT BY WIDGETS LIBRARY

Steps to Reproduce
You can download a reproducible copy here:
https://github.com/ldco2016/news
The error occurs as soon as you run flutter run, this is the exact error:
                                     ⡿I/flutter (19044): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
I/flutter (19044): The following assertion was thrown building App(dirty):
I/flutter (19044): type '(RouteSettings) => dynamic' is not a subtype of type '(RouteSettings) => Route<dynamic>'

Logs
+25 ms] D/EGL_emulation(20689): eglMakeCurrent: 0xec5eed80: ver 3 0 (tinfo 0xf26cbd50)
[ +304 ms] I/flutter (20689): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
[        ] I/flutter (20689): The following assertion was thrown building App(dirty):
[        ] I/flutter (20689): type '(RouteSettings) => dynamic' is not a subtype of type '(RouteSettings) => Route<dynamic>'
[        ] I/flutter (20689):
[        ] I/flutter (20689): Either the assertion indicates an error in the framework itself, or we should provide substantially
[        ] I/flutter (20689): more information in this error message to help you determine and fix the underlying cause.
[        ] I/flutter (20689): In either case, please report this assertion by filing a bug on GitHub:
[        ] I/flutter (20689):   https://github.com/flutter/flutter/issues/new?template=BUG.md
[        ] I/flutter (20689):
[        ] I/flutter (20689): Widget creation tracking is currently disabled. Enabling it enables improved error messages. It can
[        ] I/flutter (20689): be enabled by passing `--track-widget-creation` to `flutter run` or `flutter test`.
[        ] I/flutter (20689):
[        ] I/flutter (20689): When the exception was thrown, this was the stack:
[        ] I/flutter (20689): #0      App.build (package:news/src/app.dart:11:26)
[        ] I/flutter (20689): #1      StatelessElement.build (package:flutter/src/widgets/framework.dart:4009:28)
[        ] I/flutter (20689): #2      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3941:15)
[        ] I/flutter (20689): #3      Element.rebuild (package:flutter/src/widgets/framework.dart:3738:5)
[        ] I/flutter (20689): #4      ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3924:5)
[        ] I/flutter (20689): #5      ComponentElement.mount (package:flutter/src/widgets/framework.dart:3919:5)
[        ] I/flutter (20689): #6      Element.inflateWidget (package:flutter/src/widgets/framework.dart:3101:14)
[        ] I/flutter (20689): #7      Element.updateChild (package:flutter/src/widgets/framework.dart:2904:12)
[        ] I/flutter (20689): #8      RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:998:16)
[        ] I/flutter (20689): #9      RenderObjectToWidgetElement.mount (package:flutter/src/widgets/binding.dart:969:5)
[        ] I/flutter (20689): #10     RenderObjectToWidgetAdapter.attachToRenderTree.<anonymous closure> (package:flutter/src/widgets/binding.dart:915:17)
[        ] I/flutter (20689): #11     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2328:19)
[        ] I/flutter (20689): #12     RenderObjectToWidgetAdapter.attachToRenderTree (package:flutter/src/widgets/binding.dart:914:13)
[        ] I/flutter (20689): #13     WidgetsBinding.attachRootWidget (package:flutter/src/widgets/binding.dart:795:7)
[        ] I/flutter (20689): #14     runApp (package:flutter/src/widgets/binding.dart:845:7)
[        ] I/flutter (20689): #15     main (package:news/main.dart:5:3)
[        ] I/flutter (20689): #16     _runMainZoned.<anonymous closure>.<anonymous closure> (dart:ui/hooks.dart:229:25)
[        ] I/flutter (20689): #21     _runMainZoned.<anonymous closure> (dart:ui/hooks.dart:221:5)
[        ] I/flutter (20689): #22     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:305:19)
[        ] I/flutter (20689): #23     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
[        ] I/flutter (20689): (elided 4 frames from package dart:async)
[        ] I/flutter (20689):
[        ] I/flutter (20689): ════════════════════════════════════════════════════════════════════════════════════════════════════
[  +31 ms] I/Choreographer(20689): Skipped 32 frames!  The application may be doing too much work on its main thread.
[  +14 ms] D/EGL_emulation(20689): eglMakeCurrent: 0xec985900: ver 3 0 (tinfo 0xd644de90)
[ +193 ms] D/EGL_emulation(20689): eglMakeCurrent: 0xec5eed80: ver 3 0 (tinfo 0xf26cbd50)

   info • Unused import: 'package:news/main.dart' • test/widget_test.dart:11:8 • unused_import
  error • The function 'MyApp' isn't defined • test/widget_test.dart:16:29 • undefined_function

2 issues found. (ran in 1.9s)

[✓] Flutter (Channel stable, v1.9.1+hotfix.4, on Mac OS X 10.14.5 18F132, locale en-US)
    • Flutter version 1.9.1+hotfix.4 at /Users/luiscortes/Projects/flutter
    • Framework revision cc949a8e8b (6 weeks ago), 2019-09-27 15:04:59 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/luiscortes/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[!] Xcode - develop for iOS and macOS (Xcode 11.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2, Build version 11B52
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install:
        sudo gem install cocoapods
        pod setup

[!] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

! Doctor found issues in 3 categories.

Nevermind, I was missing Route in Route routes(RouteSettings settings) {,  flutter was pointing at line 11 at onGenerateRoute: routes,, but I eventually found it.


Wfly 15459 jakarta namespace saaj impl

https://issues.redhat.com/browse/WFLY-15459

prepare a new cleaner PR for this  issue


Feat/golang

GOLANG SWITCH
Checklist

[x] PR is rebased to/aimed at branch develop
[ ] PR follows Contributing Guide
[x] Added tests (if necessary)
[x] Extended README/Documentation (if necessary)
[ ] Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

Codecov Report
Attention: 203 lines in your changes are missing coverage. Please review.

Comparison is base (67bc34d) 96.39% compared to head (5360ac8) 90.05%.

Files
Patch %
Lines

...rnal/validator/cosignvalidator/cosign_validator.go
47.27%
113 Missing and 3 partials :warning:

internal/utils/validation.go
65.71%
9 Missing and 3 partials :warning:

internal/validator/auth/auth.go
88.00%
8 Missing and 4 partials :warning:

internal/handler/mutate.go
94.60%
9 Missing and 2 partials :warning:

internal/alert/channel.go
92.80%
8 Missing and 2 partials :warning:

internal/alert/alerting.go
86.20%
7 Missing and 1 partial :warning:

internal/alert/config.go
87.23%
4 Missing and 2 partials :warning:

internal/config/config.go
91.42%
4 Missing and 2 partials :warning:

internal/kubernetes/workload_object.go
96.89%
4 Missing and 2 partials :warning:

internal/handler/validation/validation.go
97.10%
4 Missing and 1 partial :warning:

... and 4 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1509      +/-   ##
===========================================
- Coverage    96.39%   90.05%   -6.35%
===========================================
  Files           23       36      +13
  Lines         1359     2453    +1094
===========================================
+ Hits          1310     2209     +899
- Misses          49      210     +161
- Partials         0       34      +34

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ODB-28: Generate pvLookupTable on-demand to allow multiprocessing to run on non-interactive image creation.

Finished with 0.5.0


I18N - Convert model generated text

This issue has been fixed in the following pull requests:
https://github.com/ManageIQ/manageiq/pull/7493
https://github.com/ManageIQ/manageiq/pull/7492
https://github.com/ManageIQ/manageiq/pull/7466
https://github.com/ManageIQ/manageiq/pull/7438
https://github.com/ManageIQ/manageiq/pull/7397
https://github.com/ManageIQ/manageiq/pull/7387
https://github.com/ManageIQ/manageiq/pull/7381
https://github.com/ManageIQ/manageiq/pull/7379
https://github.com/ManageIQ/manageiq/pull/7377
https://github.com/ManageIQ/manageiq/pull/7349
https://github.com/ManageIQ/manageiq/pull/7343
https://github.com/ManageIQ/manageiq/pull/7295
https://github.com/ManageIQ/manageiq/pull/7287
and can now be closed.


Pagination for History

History can contain many items and at the moment we're only returning the 200 latest ones with no way for the user to go beyond.
We need to allow for pagination of history items.

Added in #141, needs design

Done


Update composer.json

Upgrade composer for PHP 8.1 support.

This is not necessary, ^8.0 includes 8.1 and 8.2 etc until <9