Support Instance::of for configuration in DI

When the DI container creates an object it first resolves the dependencies via the constructor.
After that, there's a fork.

The object implements Configurable, set the params as last argument for the constructor.
The object does not implement Configurable, set the params manually.

My proposal is to add support for resolving Instance::of() declarations here as well.
For example:
Container::get($class, $params = [], $config = []) { ... }

$container->get('SimpleClass', [], ['db' => Instance::of('test')]);

This would allow for intelligent property injection in cases where the container is available.
My use case, I have an application purely configured via DI.
Suppose my DI configuration array looks like this:
...,
\yii\web\Application::class => [
    'components' => [
        'fileCache' => FileCache::class // Config via DI,
        'dbCache' => DbCache::class // Config via DI
    ]
    'modules' => [
        'moduleA1' => modules\ClassA::class,
        'moduleA2' => modules\ClassA::class

    ]
]

Note that both modules are backed by the same class so I cannot configure them (separately) via DI.
These modules can use a service that I'd like to configure. In this case it's a cache.
So I try to configure these modules in the application config.
...,
\yii\web\Application::class => [
    'components' => [
        'fileCache' => FileCache::class // Config via DI,
        'dbCache' => DbCache::class // Config via DI
    ]
    'modules' => [
        'moduleA1' => [
            'class' => modules\ClassA::class,
            'cache' => FileCache::class
        ],
        'moduleA2' => modules\ClassA::class
    ]
]

Now in moduleA1 the public $cache = "FileCache". This means I have to go back to the DI container to get the instance. Instead I'd like to use this:
...,
\yii\web\Application::class => [
    'components' => [
        'fileCache' => FileCache::class // Config via DI,
        'dbCache' => DbCache::class // Config via DI
    ]
    'modules' => [
        'moduleA1' => [
            'class' => modules\ClassA::class,
            'cache' => Instance::of(FileCache::class)
        ],
        'moduleA2' => modules\ClassA::class
    ]
]

I'm aware that I could provide the module definition / configuration as a closure to work around this, just think this might be a clean solution without any downsides.
Opinions please, I can make a PR if you like the idea.

Overall it looks logical to support it. I have no objections. @yiisoft/core-developers what do you think?

If a property supports being set by DI you ususally use code like this: https://github.com/yiisoft/yii2/blob/0973117de289d8676ec1dc40f68ab36279d7cd2d/framework/web/CacheSession.php#L59
Supporting Instance::of() should be okay in general but running an instanceof check on all configuration entries could slow down instantiation process.

Would be great to have some benchmarks indeed...

@cebe, that's not DI that's the service locator pattern.
I've run a simple benchmark for the instanceof check:
public function actionBenchmark() {
        $times = [];
        $count = 0;
        for($i = 0; $i < 100; $i++) {
            $instance = Instance::of('test');
            $s = microtime(true);
            for ($j = 0; $j < 100000; $j++) {
                if ($instance instanceof Instance) {
                    $count++;
                } else {
                    $count--;
                }
            }
            $e = microtime(true);
            $times[] = $e - $s;
        }
        echo '<pre>';
        echo "$i iterations of $j checks\n";
        echo "Average: " . number_format(array_sum($times) / count($times), 3) . "s\n";
        echo "Min: " . number_format(min($times), 3) . "s\n";
        echo "Max: " . number_format(max($times), 3) . "s\n";
        print_r($times);

    }

This shows that on average doing 100k of instanceof checks takes 0.004 seconds.
I tried some actions in my application and they have about 300 total config parameters...

So there's no difference performance-wise. That's good.

@SamMousa do you have time for a pull request? We're going to release 2.0.14 soon so either it is in or not (we have it working in di package already).

I might have time tomorrow. Otherwise it'll have to wait (or someone else has to pick it up)

Seems to be fixed already by #15347 :)


IMP: Add *_samples_ncv pipelines

Closes #160. Initial stab at implementing the *_samples_ncv pipelines

This PR is being closed and issue #160 is being deferred to @nbokulich


Animated emoji Addition

Description
Animated emoji Addition
Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Closes #995

Type of PR

[ ] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I have performed a self-review of my code
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[x] I have commented my code, particularly in hard-to-understand areas.

Additional context:
[Include any additional information or context that might be helpful for reviewers.]

@varshith257  review it.

@varshith257 kinldy review and merge it.

@Damini2004 Solve conflicts and tag me for quick review

@varshith257  Does the conflicts get resolved ?

@varshith257 review it.


Test uninit memory validation

This adds the tests for https://github.com/rust-lang/rust/pull/74059.

@bors r+

:pushpin: Commit 04019eec3cc17684fff1790b0d15a5df89a9aa79 has been approved by RalfJung

:hourglass: Testing commit 04019eec3cc17684fff1790b0d15a5df89a9aa79 with merge 5e94f57cb321a973f7efb96b1a24405636a5e903...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 5e94f57cb321a973f7efb96b1a24405636a5e903 to master...


Merged configuration lists have unexpected precedence ordering

Problem
When merging TOML lists from configuration, the order does not follow the precedence order described in the documentation. The documentation does not explicitly specify the order for merging lists other than "Arrays will be joined together".
The docs state

If a key is specified in multiple config files, the values will get merged together. Numbers, strings, and booleans will use the value in the deeper config directory taking precedence over ancestor directories, where the home directory is the lowest priority. Arrays will be joined together.

The --config option may be specified multiple times, in which case the values are merged in left-to-right order, using the same merging logic that is used when multiple configuration files apply. Configuration values specified this way take precedence over environment variables, which take precedence over configuration files.

I expected a merged list would be:

command line
environment
deeper config
shallower config

Instead, the order appears to be:

deeper config
shallower config
command line
environment

Steps
The following script illustrates the current situation.
mkdir -p experiment/.cargo/
echo "test=['file']" > experiment/.cargo/config.toml
mkdir -p experiment/nested/.cargo/
echo "test=['nested-file']" > experiment/nested/.cargo/config.toml

pushd experiment/nested
CARGO_TEST=env-var cargo -Zunstable-options --config 'test=["first --config"]' --config 'test=["second --config"]' config get test
popd
rm -r experiment

test = ["nested-file", "file", "first --config", "second --config", "env-var"]

If a non-list is used, the precedence of these values is:
second --config
first --config
env-var
nested-file
file

Possible Solution(s)
Merge the lists with highest precedence first. The output of the above bash script should be:
test = ["second --config", "first --config", "env-var", "nested-file", "file"]

An alternative would be to merge them with lowest precedence first.
test = ["file", "nested-file", "env-var", "first --config", "second --config"]

Notes
No response
Version
cargo 1.73.0-nightly (7e9de3f4e 2023-08-13)
release: 1.73.0-nightly
commit-hash: 7e9de3f4ec3708f500bec142317895b96131e47c
commit-date: 2023-08-13
host: x86_64-unknown-linux-gnu
libgit2: 1.6.4 (sys:0.17.2 vendored)
libcurl: 8.2.1-DEV (sys:0.4.65+curl-8.2.1 vendored ssl:OpenSSL/1.1.1u)
ssl: OpenSSL 1.1.1u  30 May 2023
os: Ubuntu 22.04 (jammy) [64-bit]

For build.rustflags, the proposed solution might not be desirable, as flags in right overwrites those in right (if I remember correctly).

I implemented both possible orders, and putting high precedence last requires the fewest test changes and works better with rustflags per @weihanglo's comment.
high precedence last: https://github.com/rust-lang/cargo/commit/c611fed52
high precedence first: https://github.com/rust-lang/cargo/commit/b1522d7b8

Related issue: https://github.com/rust-lang/cargo/issues/8128.


Add agree_prop_par_asym to STM_domain

This PR fixes #310 by adding an asymmetric property agree_prop_par_asym to STM_domain.
This is handy to run tests that spawn only 1 child domain to run and interpret cmds in parallel with the parent domain.
To make printing of such triples nicer, the PR includes a new triple generator STM_domain.arb_triple_asym that has a corresponding "symmetric printer" set.
I pinned the patched version locally to see how this would help clean up the existing ws_deque test from lockfree.
For comparison, here's a diff:
diff --git a/test/ws_deque/stm_ws_deque.ml b/test/ws_deque/stm_ws_deque.ml
index fd502bc..90af0d1 100644
--- a/test/ws_deque/stm_ws_deque.ml
+++ b/test/ws_deque/stm_ws_deque.ml
@@ -63,56 +63,22 @@ end
 module WSDT_seq = STM_sequential.Make (WSDConf)
 module WSDT_dom = STM_domain.Make (WSDConf)

-(* The following definitions differ slightly from those in multicoretests:lib/STM.ml.
-   This has to do with how work-stealing deques are supposed to be used according to spec:
-   - [agree_prop_par] differs in that it only spawns one domain ("a stealer domain")
-     in parallel with the original "owner domain" (it also uses [Semaphore.Binary]) *)
-let agree_prop_par (seq_pref, owner, stealer) =
-  assume (WSDT_seq.cmds_ok WSDConf.init_state (seq_pref @ owner));
-  assume (WSDT_seq.cmds_ok WSDConf.init_state (seq_pref @ stealer));
-  let sut = WSDConf.init_sut () in
-  let pref_obs = WSDT_dom.interp_sut_res sut seq_pref in
-  let sema = Semaphore.Binary.make false in
-  let stealer_dom =
-    Domain.spawn (fun () ->
-        Semaphore.Binary.release sema;
-        WSDT_dom.interp_sut_res sut stealer)
-  in
-  while not (Semaphore.Binary.try_acquire sema) do
-    Domain.cpu_relax ()
-  done;
-  let own_obs = WSDT_dom.interp_sut_res sut owner in
-  let stealer_obs = Domain.join stealer_dom in
-  let res =
-    WSDT_dom.check_obs pref_obs own_obs stealer_obs WSDConf.init_state
-  in
-  let () = WSDConf.cleanup sut in
-  res
-  || Test.fail_reportf "  Results incompatible with linearized model:\n\n%s"
-     @@ Util.print_triple_vertical ~center_prefix:false STM.show_res
-          (List.map snd pref_obs, List.map snd own_obs, List.map snd stealer_obs)
-
-(* [arb_cmds_par] differs in what each triple component generates:
-   "Owner domain" cmds can't be [Steal], "stealer domain" cmds can only be [Steal]. *)
-let arb_cmds_par =
-  WSDT_dom.arb_triple 20 15 WSDConf.arb_cmd WSDConf.arb_cmd WSDConf.stealer_cmd
-
 (* A parallel agreement test - w/repeat and retries combined *)
-let agree_test_par ~count ~name =
-  let rep_count = 50 in
-  Test.make ~retries:10 ~count ~name arb_cmds_par
-    (repeat rep_count agree_prop_par)
-
-(* Note: this can generate, e.g., pop commands/actions in different threads, thus violating the spec. *)
-let agree_test_par_negative ~count ~name =
-  WSDT_dom.neg_agree_test_par ~count ~name
+let agree_test_par_asym ~count ~name =
+  let rep_count = 20 in
+  let seq_len,par_len = 20,12 in
+  Test.make ~retries:10 ~count ~name
+    (* "Owner domain" cmds can't be [Steal], "stealer domain" cmds can only be [Steal]. *)
+    (WSDT_dom.arb_triple_asym seq_len par_len WSDConf.arb_cmd WSDConf.arb_cmd WSDConf.stealer_cmd)
+    (repeat rep_count WSDT_dom.agree_prop_par_asym)

 let () =
   let count = 1000 in
   QCheck_base_runner.run_tests_main
     [
       WSDT_seq.agree_test ~count ~name:"STM Lockfree.Ws_deque test sequential";
-      agree_test_par ~count ~name:"STM Lockfree.Ws_deque test parallel";
-      agree_test_par_negative ~count
-        ~name:"STM Lockfree.Ws_deque test parallel, negative";
+      agree_test_par_asym ~count ~name:"STM Lockfree.Ws_deque test parallel";
+      (* Note: this can generate, e.g., pop commands/actions in different threads, thus violating the spec. *)
+      WSDT_dom.neg_agree_test_par
+                          ~count ~name:"STM Lockfree.Ws_deque test parallel, negative";

I realize that

I left some commented out code which needs removing
This needs a Changes entry

CC @lyrm as this could be helpful in ocaml-multicore/lockfree#61

Great ! Thanks !

PR rebased on top of the merged #318.
To make this convenient I've reexported all_interleavings_ok in STM_domain.
Because of the pulled-out precondition check of #318, one therefore has to specify it in a custom test property as an additional line, e.g., something along these lines:
+let agree_test_par_asym ~count ~name =
+  let rep_count = 20 in
+  let seq_len,par_len = 20,12 in
+  Test.make ~retries:10 ~count ~name
+    (* "Owner domain" cmds can't be [Steal], "stealer domain" cmds can only be [Steal]. *)
+    (WSDT_dom.arb_triple_asym seq_len par_len WSDConf.arb_cmd WSDConf.arb_cmd WSDConf.stealer_cmd)
+    (fun ((seq_pref,cmds1,cmds2) as triple) ->
+      assume (WSDT_dom.all_interleavings_ok seq_pref cmds1 cmds2 WSDConf.init_state);
+      repeat rep_count WSDT_dom.agree_prop_par_asym triple)

(We could also go further and export a version of all_interleavings_ok (perhaps under a different name) that simply accepts the triple, e.g., so that the latter lines could be simplified to something like:
+    (fun triple ->
+      assume (WSDT_dom.interleavings_ok triple);
+      repeat rep_count WSDT_dom.agree_prop_par_asym triple)

CI summary:

a Windows 5.0 threadomain crash
failure to trigger the Out_channel issue on Windows trunk and macOS trunk (push + pull request run)

None of these are related to the current PR

CI summary:

Windows bytecode trunk triggered a Thread CList failure
Windows and macOs trunk both failed to trigger the Out_channel issue
Windows bytecode 5.1 and trunk both timedout on the threadomains test
Cygwin trunk (PR and push) both timed out due to Lin DSL Weak HashSet test with Domain taking a long time


How to remove the "trace" which appears each 10 lines in a root block?

Hi. I'd appreciate your help.
As shown in the screenshot below, for each 10 lines in a root block there is a light "trace" being rendered.
How to remove that trace?
Thank you!

Hello, I guess this is a duplicate issue of this:
https://github.com/leodevbro/vscode-blockman/issues/52
Long story short:
I think it is a bug of VSCode, or Windows or both. I don't think that it is a bug of Blockman.
I made a bug report about it in the vscode repo:
https://github.com/microsoft/vscode/issues/137609
Possible solution:
If you have zoomed VSCode window, you can try resetting is:
Press F1, type "reset zoom" and click on View: Reset Zoom.
If you want to zoom, please don't use View zoom (ctrl and "+"), please use font zooming feature (mouse wheel zoom).

Thanks for your prompt reply (and for this outstanding extension) 👍
Sorry for the duplicated thread.
I'm not using zoom but triggered "reset" (UI and font) just in case, but the issue is still there.
I upvoted the thread https://github.com/microsoft/vscode/issues/137609

Thanks so much, well, please check the pixel resolution of your monitor, also the scaling percent of Windows (if you are using Windows 10).
Also maybe you should try installing VSCode Insiders (if you currently have VSCode) (or VSCode if you currently have VSCode insiders) and do not change any settings and just check how Blockman is working there. If you already have both, then this experiment cannot be done because we need totally clean software.
Also, please check exactly what is going on in the zoom settings. It must be 0 for best quality rendering.

Hello, I guess this is a duplicate issue of this: #52
Long story short: I think it is a bug of VSCode, or Windows or both. I don't think that it is a bug of Blockman.
I made a bug report about it in the vscode repo: microsoft/vscode#137609
Possible solution: If you have zoomed VSCode window, you can try resetting it: Press F1, type "reset zoom" and click on View: Reset Zoom.
If you want to zoom, please don't use View zoom (ctrl and "+"/"-"), please use font zooming feature (mouse wheel zoom).

That's interesting. Because in my issue, this bug disappears when I use View zoom (ctrl and "+"/"-") to zoom out, while mouse wheel zoom won't do. Besides, change the scale level into 100% in Windows 10 can also fix this problem.

Yeah, mouse wheel zoom does not fix the issue. When I said "mouse wheel zoom", I meant that it is a better alternative to "View zoom" because it does not cause such issues.

@carloscadux, @JC6123, Hello, I think this issue (strange horizontal lines) is fixed with the latest version of VSCode (1.66), so please update VSCode and check the issue again, and please tell me whether the situation is changed or not.

@carloscadux, @JC6123, Hello, I think this issue (strange horizontal lines) is fixed with the latest version of VSCode (1.66), so please update VSCode and check the issue again, and please tell me whether the situation is changed or not.

Yeah, seems it has been fixed now.

@carloscadux, @JC6123, Hello, I think this issue (strange horizontal lines) is fixed with the latest version of VSCode (1.66), so please update VSCode and check the issue again, and please tell me whether the situation is changed or not.

v1.66 didn't fix the issue for me. Actually, the issue became more consistent.
Before v.166, the "trace" would disappear depending on the part of the code I was visualizing.
I'd say the issue was intermittent.
After v.166 the "trace" became permanent, being shown each 10 lines starting from line 5, in all files I open in VSCode:

@carloscadux, have you tried, I don't know, restarting VSCode? Or maybe zoom to the value 0 (Window: Zoom Level)? Because, I guess your zooming is below 100%, and maybe you can try to set it to 100%, and then if you want smaller text, just use mouse wheel zooming, or font size. As I have experienced, Mouse wheel zooming and changing font size does not cause such strange horizontal lines. Only Window: Zoom Level causes it.

@carloscadux, also please try disabling GPU for VS Code.

Here is the link:
https://code.visualstudio.com/docs/supporting/FAQ#_vs-code-is-blank
.
.
.


[web][macos] IME panel place wrong

Steps to Reproduce
In the sample simplistic_editor, IME selection panel place is wrong.
Expected results:
The panel should be under the carer as below

Actual results:

I was able to replicate this error on macos/windows/web.
Thanks.

Hi @pedia
It seems this is simplistic_editor's issue since it doesn't happen on a minimal TextField as below:

Sample code
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const Scaffold(
        body: Center(
          child: TextField(),
        ),
      ),
    );
  }
}

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.7.3, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.7.3 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (17 hours ago), 2023-02-08 15:46:04 -0800
    • Engine revision 248290d6d5
    • Dart version 2.19.2
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Users/huynq/Library/Java/JavaVirtualMachines/corretto-1.8.0_302/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment Corretto-8.302.08.1 (build 1.8.0_302-b08)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.75.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 13 (API 33)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 110.0.5481.77

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.8.0-8.0.pre.24, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.8.0-8.0.pre.24 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (24 minutes ago), 2023-02-09 16:51:26 +0000
    • Engine revision eb346ba63f
    • Dart version 3.0.0 (build 3.0.0-218.0.dev)
    • DevTools version 2.21.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.75.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.58.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 13 (API 33)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 110.0.5481.77

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Please retry with above minimal sample code and confirm this. If it works as expected, feel free to close this issue and follow up on https://github.com/flutter/samples/issues/1648, the issue I saw you filed in that repository. Thanks!

Yes, this's simplistic_editor's issue.  But all rich editors failed with IME on Web

flutter quill
appflow_editor failed to

@pedia Since it's a separate issue for each repository, I recommend filing issues separately on those repositories. Closing this issue as above confirmation. Thanks!


feat: support parse token from post form

What type of PR is this?

feat: A new feature
What this PR does / why we need it (English/Chinese):

zh: 支持解析 form 表单中的 token
Which issue(s) this PR fixes:

Fixes (https://github.com/cloudwego/hertz/issues/564)

LGTM


An error occurred in ClientFunction code: ReferenceError: axe is not defined in TestCafe version 2.6 and 2.6.1

What is your Scenario?
Would like to run the test without running into an  'An error occurred in ClientFunction code: ReferenceError: axe is not defined' issue on version 2.6 and 2.6.1
What is the Current behavior?
Tests fail consistently with 'An error occurred in ClientFunction code: ReferenceError: axe is not defined'
For comparison, tests never fail with this issue when running using 2.5.1-rc.1
What is the Expected behavior?
Test should pass in all places without failing intermittently with 'An error occurred in ClientFunction code: ReferenceError: axe is not defined' issue on version 2.6 and 2.6.1
What is your public website URL? (or attach your complete example)
https://www.citethisforme.com
What is your TestCafe test code?
// @ts-ignore
import { t, Selector } from "testcafe";
const loginUrl = `https://www.citethisforme.com/login`;
export const emailForSignIn = Selector('input[id*="email"]');
export const passForSignin = Selector('input[type="password"]');
export const signInButton = Selector("button").withText("Sign in");
export const upgradeButton = Selector('button[aria-controls="accountMenu"]');
const a11y = require("./a11y.ts");

// user log in/log out methods
async function userLogInWithCredentials(
  email: string,
  password: string
): Promise<void> {
  await t.navigateTo(loginUrl);
  await t
    .typeText(emailForSignIn, email, { paste: true })
    .typeText(passForSignin, password, { paste: true })
    .click(signInButton)
    .wait(6000);
  console.log(`Logged in as user: ${email}`);
}

fixture`User log in and axe core client function failure`
  .meta({ fixtureID: "f-0001", author: "GROWTH", app: "" })
  .beforeEach(async (t) => {});

test.meta({
  testID: "t-0001",
})("User log in and axe core client function failure", async (t) => {
  await<EMAIL_ADDRESS>"Password@123");
  await t.expect(upgradeButton.visible).ok();
  await a11y(t);
});

test.meta({
    testID: "t-0001",
  })("User log in and axe core client function failure", async (t) => {
    await<EMAIL_ADDRESS>"Password@123");
    await t.expect(upgradeButton.visible).ok();
    await a11y(t);
  });

  test.meta({
    testID: "t-0001",
  })("User log in and axe core client function failure", async (t) => {
    await<EMAIL_ADDRESS>"Password@123");
    await t.expect(upgradeButton.visible).ok();
    await a11y(t);
  });

  test.meta({
    testID: "t-0001",
  })("User log in and axe core client function failure", async (t) => {
    await<EMAIL_ADDRESS>"Password@123");
    await t.expect(upgradeButton.visible).ok();
    await a11y(t);
  });

  test.meta({
    testID: "t-0001",
  })("User log in and axe core client function failure", async (t) => {
    await<EMAIL_ADDRESS>"Password@123");
    await t.expect(upgradeButton.visible).ok();
    await a11y(t);
  });

Your complete configuration file
module.exports = {
    clientScripts: [{ module: 'axe-core/axe.min.js' }],
    skipJsErrors: true
}

Your complete test report
An error occurred in ClientFunction code:
ReferenceError: axe is not defined
Screenshots

Steps to Reproduce

Clone https://github.com/ayemelyanenko-chegg/nextjs-nodejs-example
CD into nextjs-nodejs-example/
cd into my-app
npm install
npx testcafe chrome tests/sampleA11yTest.ts -L -c 10

For comparison, downgrade to version 2.5.1-rc.1 and run step 5 again. Tests will pass each time
TestCafe version
2.6.0 and 2.6.1
Node.js version
18.16.0
Command-line arguments
npx testcafe chrome tests/sampleA11yTest.ts -L -c 10
Browser name(s) and version(s)
Chrome 114
Platform(s) and version(s)
Mac OS
Other
Attaching in a log file if not able to run/reproduce locally. Please search for 'ReferenceError: axe is not defined' in the log file
https://upload.disroot.org/r/jGbr3cvK#KfeLRgGF5B/OyH7Oxz74rnFHOddSjrelwVr0TVituu8=

Hello,
Thank you for your report. As far as I can see, the test contains a login process. Our policy prevents us from accessing a customer's internal resources without prior written approval from the entity that owns the server/web resource. We did not obtain such approval for the web site mentioned in this issue. So, please send us a written confirmation, which permits DevExpress personnel to remotely access the website and its internal resources for research/testing and debugging purposes (support@devexpress.com).

Hello @Dmitry-Ostashev. I sent the email with the authorization today. Thank you.

Thank you for your email. I reproduced the issue.

Fixed in https://github.com/DevExpress/testcafe/pull/7771.


Roll Flutter Engine from 05228ad454bc to 27112a024dc9 (1 revision)

https://github.com/flutter/engine/compare/05228ad454bc...27112a024dc9
2022-08-03<EMAIL_ADDRESS>Roll Skia from 149eb4561980 to 3f99bc378abc (1 revision) (flutter/engine#35119)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

AutoRoller is stopped; closing the active roll.


GitHub Branch naming standard

We have repositories where developers are accessing and creating their own branches.
But we want to apply a rule, where developers can create a fixed/standard or defined naming convention, not like their own branch names.
They shouldnt not create any branch names other than what we have defined.
Can someone please suggest me how can we achieve this.
Thanks in Advance.

Hi, your question is a more general question about version control, while this issue tracker is for discussing features and bugs of a command-line tool called "hub" which doesn't aim to solve this question.
My personal opinion is that your team should come up with your own standard and stick to it!


Pool does not reuse connections with TiDB (works correctly with MariaDB)

As per title - every call to Pool::get_conn() returns a new connection (different connection ID) when using mysql-async with a TiDB database (v5.3.0).
When using a MariaDB database (10.6.5), the connection is automatically reused (same connection ID each time).
See the output below - the only difference is which database is used.
The following repository has code to reproduce the problem:
https://github.com/AlexDBlack/mysql_async_issue
[2022-01-17T08:59:47Z INFO  mysql_async_issue] ===== Starting MariaDB Test =====
[2022-01-17T08:59:47Z INFO  mysql_async_issue] Iteration 0 connection: id=9
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 1 connection: id=9
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 2 connection: id=9
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 3 connection: id=9
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 4 connection: id=9
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 5 connection: id=9
[2022-01-17T08:59:48Z INFO  mysql_async_issue] ===== Starting TiDB Test =====
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 0 connection: id=141
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 1 connection: id=145
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 2 connection: id=149
[2022-01-17T08:59:48Z INFO  mysql_async_issue] Iteration 3 connection: id=153
[2022-01-17T08:59:49Z INFO  mysql_async_issue] Iteration 4 connection: id=157
[2022-01-17T08:59:49Z INFO  mysql_async_issue] Iteration 5 connection: id=161

Hi, thanks for detailed report.
I believe this is because of Conn::reset. As far as I can see COM_RESET_CONNECTION is supported by TiDB since Aug 2020 (see pingcap/tidb#4640), so I'll fix it.


chore(web3-provider): switch from forno to quicknode

QuickNode includes an API key in its URL, and secrets are handled differently than normal config params in this repo, so this involves more code than you would think.
tested by running the indexer locally with quicknode

Codecov Report

:exclamation: No coverage uploaded for pull request base (cajubelt/fix-rate-limit-error@b16155a). Click here to learn what that means.
The diff coverage is n/a.

@@                       Coverage Diff                        @@
##             cajubelt/fix-rate-limit-error      #44   +/-   ##
================================================================
  Coverage                                 ?   84.41%
================================================================
  Files                                    ?        9
  Lines                                    ?      154
  Branches                                 ?       26
================================================================
  Hits                                     ?      130
  Misses                                   ?       24
  Partials                                 ?        0

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16155a...eeae33f. Read the comment docs.


Failed to start the server with https. Confirm that the SSL certificate files exist and are correct.

Hello,
I used the tutorial at https://deliciousbrains.com/ssl-certificate-authority-for-local-https-development/ to generate the certificate and put the files in the certs directory, but after a few seconds the container crashes and shows the following error message:
gateway     | 2024-08-06 10:41:47 | error | 	Failed to start the server with https. Confirm that the SSL certificate files exist and are correct.
Any idea to solve it?
Thank you.

Hello,
Any idea to solve it?
Thanks.


On the dynamic draggable form array, the change of order and value affects the other values

Describe the bug
On the submission form, when there's a dynamic array, the change of order and value affects the other values.
When the user inputs values and then changes the order of the lines, after inputting the new value, the change affects other lines too.
To Reproduce
On the submission form, on the dynamic draggable form array:

Add more than one element by choosing from the dropdown
select values
change order
select values again
after we change the order, the same value will be selected for other dropdowns.

DSpace Repository __ Edit Submission.webm

Note, this is probably the same as https://github.com/DSpace/dspace-angular/issues/3217
And may be fixed by https://github.com/DSpace/dspace-angular/pull/3228 (would love feedback!)


Add option to embed json fields metadata inside the log payload

Adding a boolean option moveFieldsIntoPayload to inject specified fields into the log JSON payload to allow for dynamic auto JSON parsing in Sumo. Enabling this option would also prevent fields from being sent in the HTTP request to Sumo.

Pushed some changes while waiting for some customer feedback on the log format when moveFieldsIntoPayload = true.
Per the latest changes, whenever moveFieldsIntoPayload is true, we always format the log payload into a JSON log format looking like
{"timestamp":1664396202215,"log":"{"timestamp":1654016401446,"PID":"3","USER":"root","MEM":"0.0","CPU":"0.0"}","metadata":{"bigintfield":"228930314431312345","boolfield":"true","intfield":"100","stringfield":"stringvalue"}}

essentially ignoring the payloadText field. The metadata field will include all fields.
Otherwise when moveFieldsIntoPayload is true, we revert to the previous behavior.

Otherwise when moveFieldsIntoPayload is true, we revert to the previous behavior.
@rishiyemme you meant when it is set to false, we revert to previous behavior.


Monaco Editor with Kusto query syntax support in Angular 16

Description
I'm working on the project that allow user to write kql. The project is using Angular 16.
I'm using ngx-monaco-editor-v2 and @kusto/monaco-kusto but unfortunately not manage to work. Keep getting error.
Is there any documentation or sample code for Angular 16?

Hi Samhoamt,
We don't have any angular examples at this time, sorry.
You might be able to get it working by copying most of our React/ESM example here (1) https://github.com/Azure/monaco-kusto/blob/master/samples/esm-webpack-react/src/index.js, and following a guide for using a vanilla .js library with Angualar.
After looking at the config for a moment, I think ngx-monaco-editor-v2 is using AMD modules. If you want to keep using it, then I'd take a look at our AMD example and see if you can't figure out how to apply what in that to the libraries config.
If you can share an error message I might be able to point you in the right direction.


[Doc] ProtobufNative Schema Support

Add doc based on https://github.com/apache/pulsar/pull/8372

Done in https://github.com/apache/pulsar/pull/9079.


Demo Extension : Server product type

This product type should create a server service when added to a project.
Product types should include

Include product and order questions
Service outputs from the provisioning process
Optionally use a service details page override

Need to add back service outputs - using same product type for the sample:demo products currently.

Per the initial request:

[x] server product type (See product type implementation here and service implementation here)
server product type order questions  - couldn't get this one because order questions aren't appearing in the cart atm. See https://github.com/boozallen/projectjellyfish/issues/1141 for conetext.
[x] service outputs (See here)
service details override leaving this one out because it was initially stated as optional.

Full implementation contained in PR https://github.com/projectjellyfish/jellyfish-demo/pull/8

Closed https://github.com/boozallen/projectjellyfish/pull/1142.


[Enhancement] Aggregate and display failures at the bottom of output

When a TestCase is run which contains a large number of tests, should any of those tests fail they are printed along with passed tests in what could be a very long list. When the number of tests becomes quite large, for example over 100, one must carefully scan every entry to see what the failed tests are. This is tedious and can result in tests being missed.
When any tests fail in a TestCase containing multiple tests, aggregate and display the failed tests together as the final portion of the output. Do not change any of the existing output, just add a section at the bottom which groups only the failed tests together.

Please understand this issue is part of an LFX mentorship, which is an application-based process. Application is no guarantee of selection. The mentee who is selected for this mentorship will be given priority over any PRs.
That said, please refrain from posting screenshots of text and terminal output. Please use proper code blocks. The output shown does not appear to include any successful tests so it is difficult to determine what the end behavior is.

Ah okay.
Sorry I thought we could try working on it.
Learnt a lot though.


AMBARI-25925: "hive.server2.enable.doAs" property cannot be set

What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/AMBARI-25925
How was this patch tested?
manual tests
Please review Ambari Contributing Guide before opening a pull request.

Hi @JiaLiangC
You can set the property 's value  in ambari web.
See

@dipayanb see details in issue , even set this  to false , it will not worked ,cause it set to true in below code


Issue with apk size

Using this package adds up approximately 15 mb to my apk . Is there some optimization

15MB is so big
I have more than an app in google play using my package and app size 9MB approx
so I will give u some advice
- size in debug mode is different from release mode
- don't upload apk to google play it is recommended to use appbundle to let google split it to different CPU architecture
- and don't forget to add proguard-rules.pro
https://github.com/AbdOoSaed/flutter_cached_pdfview/blob/8ca667d27234cde23a8ebef0e3220ec90a98dba2/example/android/app/proguard-rules.pro#L1
- and build.gradle from line 49 to 69
https://github.com/AbdOoSaed/flutter_cached_pdfview/blob/8ca667d27234cde23a8ebef0e3220ec90a98dba2/example/android/app/build.gradle#L49

i have attahced size analysis for both ,this is of a specific apk architecture , not fat apk
size jsons.zip

the diff is only 3MB when u use bundle

No its 18 mb , I am surprised too , that why adding this is causing issue
I tried atleast 7-8 times before and after filing the issue

18MB for all architectures
every device only use one architecture
google play will split ur bundle

Yes , i am aware of that , notice that , these are the analysis for specific cpu structure not of fat apk


Add --update-only option back to sync-ebooks.

I forgot to add the --update-only option back in during refactor.

Thanks!


Empire Doesnt create external listeners

Empire Version
1.6.0 beta and master
OS Information (Linux flavor, Python version)
Kali linux python 2.7
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
Screenshot of error, embedded text output, or Pastebin link to the error
[!] Error starting listener on port 1500: [Errno 99] Cannot assign requested address
[!] Error starting listener on port 1500, port likely already in use.
Any additional information
when i try to set a external listener i have an error, it says that the port its already in use,i have the ports open but only happen when i try to set it with the external ip, if i try to set internal, it works.

This is discussed in #327 and is resolved in the 2.0_beta branch, I'm not sure if there was a conclusion for 1.6.

Use DNS name instead. it'll work.

Hello, I'm unable to reproduce. The current version will resort to listening on <IP_ADDRESS> if it can't bind to an external IP. Have you done a git pull for the latest version?


Question: Is there a way to get an export from excalidraw to mermaid?

I've tried searching but can't find anything available. Do you know if there's a way to do excalidraw to mermaid?

Same thing here!

No, currently there is no way to convert from Excalidraw to Mermaid.
Could you please share the scenarios where you would need this feature?

Most of My Company's frontend documentation is based on drawings made in excalidraw, as of now we are migrating to customizable mermaid snippets in frontends wiki, so the question appeared. If it is not a case as of now, will be happy to work on it.

This would be incredibly helpful. I'm interested in this as well but wouldn't know where to start honestly

This is pretty much exactly my use case as well ☝

+1 on this
I think theres too many edge cases for it to be officially supported. The best bet might to use the outputted json to reconstruct it.

In my opinion, the main problem is that arrows don't have a start and end binding to a generic element, sometimes they have a text binding, but that's not necessary. As a result, we end up with sets of linear, generic, and text elements unrelated to each other. The only point of reference is the positioning and size of the element.

Hi everyone! I have tried to implement excalidraw to mermaid conversion. This only works well for .excalidraw files that are created from .mermaid imports or manually properly customized arrows. For most cases it doesn't work for the moment. I'd be happy if anyone decides to contribute. https://github.com/YokiToki/excalidraw-to-mermaid

I came here looking for an answer to that question. Mermaid is natively supported across various platforms like Notion

Personally I have a similar use case. I like drawing stuff in Excalidraw, not so much in mermaid, but we use mermaid in github readmes so the diagrams are versioned. So initially drawing a diagram and exporting it to mermaid would be nice.
As a workaround one can feed the Excalidraw diagram to ChatGPT and ask it to convert it to a mermaid diagram. It's not perfect, but it gives you a starting point.

Personally I have a similar use case. I like drawing stuff in Excalidraw, not so much in mermaid, but we use mermaid in github readmes so the diagrams are versioned. So initially drawing a diagram and exporting it to mermaid would be nice.
As a workaround one can feed the Excalidraw diagram to ChatGPT and ask it to convert it to a mermaid diagram. It's not perfect, but it gives you a starting point.

I have a similar use case to yours, hopefully, we will see that feature.

+1 on this, it will be nice feature!

+1 on this

+1 on this 🙌


Changes requiring reboot on VMs with HA configured fail to start VM after change.

When terraform changes require a VM to stop and start, if th VM is configured for HA (set to 'started') it seems that when the provider tells the VM to shut down, Proxmox is automatically changing the HA state to 'stopped' - but the provider doesn't recognize that, so when it tells the VM to start back up, proxmox ignores it (or fails to start) bceause Proxmox still sees the HA state set to 'stopped'.
So the provider is returning success but the VM has been shut down and won't start up again unless the HA state is changed back to 'started' - whether that's done manually, or by applying terraform again if hastate=started is included in the tf file for that resource.
Proxmox: 7.2-11
Terraform v1.3.2 on linux_amd64
+ provider registry.terraform.io/telmate/proxmox v2.9.11

I still see this today :(
Proxmox: 7.3.6
Terraform v1.4.0

provider registry.terraform.io/telmate/proxmox v2.9.13

Means I have to run all terraform apply twice


Allow syntax extensions to apply non-top level items

Correct me if I'm wrong, but it looks like syntax extensions can only apply to top level items. This means I can't use a syntax extension on a specific method of an impl without applying the syntax extension to the entire impl and somehow specifying which function the extension should apply to.
Another case is applying syntax extensions directly to struct members. I was thinking of something like this:
struct Foo {
    #[get]
    bar: u32
}

This would generator a getter for bar. I don't know exactly how these APIs would work, because you'd want some way to retrieve information about their parent nodes, i.e. which struct is this member in or which impl is this method in.

#[foo] is an attribute, not a syntax extension. Also, an RFC was accepted ages ago to allow attributes on expressions, and another RFC was accepted that allows attributes on match arms. Unfortunately, only the latter has been implemented.
Also, you totally can already add attributes to struct fields, so your example is already valid. There are probably a few other places attributes could be allowed, though.

@P1start I register #[foo] with Registry.register_syntax_extension, so what's the difference between an attribute and a syntax extension?
And how do you add attributes to struct fields? None of the SyntaxExtension variants seem to allow this. Can you provide an example?

Attributes can be interpreted as syntax extensions, but annotations on struct fields are not at the moment.

Ah, so then this issue is still relevant. Although I did figure out how to register extension on impl methods. You need to use the MultiModifier variant, not the Modifier variant.

I think the only part of this that is not implemented is allow attribute-like macros (syntax extensions) on struct fields (where built-in attributes are allowed). This would be a pretty small RFC and (I think) likely to be accepted. If anyone wants to draft such a thing, I'd be happy to help with feedback, etc.

This is implemented as can be witnessed with:
struct Foo {
    #[deprecated]
    bar: u32
}

fn main() {
// warning: use of deprecated item 'Foo::bar'
    (Foo { bar: 1 }).bar;
}


pecl install skywaking failed

protobuf,grpc have installed,and then use pecl install skywalking extension failed,how to solve it? thanks

Need to install gRPC dynamic library

gRPC dynamic library

I have done this:  brew install grpc, pecl install grpc, then I use pecl install skywalking,it failed. how to do? thanks.

Need to install gRPC dynamic library
@heyanlong
can you tell me how to solve this problem? let me make it success by the command: pecl install skywalking, thanks.

This is my install command.

This is my install command.

@heyanlong

Final result.

Maybe you should link /usr/local/include/grpc -> /usr/local/opt/grpc/include

Maybe you should link /usr/local/include/grpc -> /usr/local/opt/grpc/include

Nope!

See this document https://github.com/SkyAPM/SkyAPM-php-sdk/blob/master/docs/BUILDING.md


Change the bazel SHA we like. [phab:D660]

Created by zarko at 2015-12-16 23:49:28:
The SHA's out of date.
This is the version I have built locally.
If we're standardizing on a release version
let me know and I'll switch it to that.

schroederc wrote at 2015-12-16 23:59:37:
Can you also change this in tools/docker/Dockerfile, please?

zarko wrote at 2015-12-17 00:16:04:

Update Dockerfile.

schroederc accepted this revision at 2015-12-17 23:48:50

zarko closed via commit 93a8bc2d068d57b0734de0d998207a39189b8a22 at 2015-12-17 23:50:08


Wrong class type for factory instance?

In the factory implementation's +instance class method shouldn't the sharedInstance type be SEGCrittercismIntegrationFactory instead of SEGCrittercismIntegration?
+ (id)instance
{
    static dispatch_once_t once;
    static SEGCrittercismIntegration *sharedInstance; // <-- THIS LINE
    dispatch_once(&once, ^{
        sharedInstance = [[self alloc] init]; // <-- self here is of SEGCrittercismIntegrationFactory
    });
    return sharedInstance;
}

If this is a bug, then it should be checked across all integrations as well because it's not just this integration that does this.

@ynnadrules Thanks, this indeed looks like a bug! We'll do a full audit for integrations and update them

I'm a bit surprised the compiler didn't catch this.

yeah me too. np!

Fixed https://github.com/segment-integrations/analytics-ios-integration-crittercism/commit/fc1d15aafa36e5c332db877e97a05593386e15f8


chore: bump zio, zio-test, zio-test-sbt from 2.0.0-RC2 to 2.0.0-RC3

Updates

dev.zio:zio
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.0-RC2 to 2.0.0-RC3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #205.


enhance the about us and footer section

hi @1Shubham7  , I would like to fix the UI and hovering animations for the about us section in the below which is very basic right now
please assign me this issue under gssoc'24

people already working on it.


remove unneeded inclusion reward

Remove inclusion reward as it is calculated in usingwitnet as the substraction of value - tally

Some other changes are needed

Yep, it looks like a change is missing in line 37.
Anyway, I'm uncertain about the implications of this change. At a quick glance:

Before: you need to add both rewards to guess what the value of the requestUpdate transaction needs to be. If overfunded, excess value remains in the client contract.
After: any value greater than _witnetResultReward works as value of the requestUpdate transaction. If overfunded, the request relayer can claim all the excess value.

closed in #5


Fix code scanning alert - Use of a broken or risky cryptographic algorithm

Tracking issue for:

[ ] https://github.com/eischet/janitor/security/code-scanning/1

Dependabot is right, MD5 should not be used. It looked like a good idea at the time, but adding a broken legacy algorithm doesn't make sense. In case anyone ever needs actual MD5, it's easy enough to add in manually in a host app.

resolved in branch janitor-26


Fibula surgical guide generation is not working

Fibula surgical guide generation is not working. Nothing happens when the boolean operation button in fibula surgical guide generator is pressed.

Please @cmfsx do open a new issue when you have this kind of problems, comments on commits are not searcheable.
Open the python interactor. Press enter a few times to separe the previous messages. And press the button to make the fibula surgical guide. Does an error appear? if so, post it.
If not, is the time of processing in any step 0.00 if this happens it means that vtkbool failed to make the boolean operation and returned an empty model. You can check this by searching in the data module a model called "FibulaSurgicalGuidePrototype" and hovering the mouse over it will tell you the number of points the model has, it should say zero. I have solved this problem moving the miterBoxDirectionLine a little bit, creating the miterBoxes again and pressing the button to create the fibula surgical guide should work now.

Ok I gave it a closer inspection. The reason for this I find to be rather peculiar. I have in the case I reported have placed one fiducial point on 'air' and the cylinder was not going through the base. In this case, it failed to generate the surgical guide.  And when I adjusted the point so the cylinder intersects the base is successfully generated. Perhaps we can create a error message for this ?
In the python interaction, no error messages were generated.
In successful cases, we get longer processing times like "Processing completed in 8.88 seconds" and when it fails something like Processing completed in 0.04 seconds

Perhaps we can create a error message for this ?

Okey. I cannot explain lengthly all the possible reasons of error when an empty model is created on the error-message because it will be too long.
I don't know how to be helpful to the user without writing a lot.
@lassoan is an error message like "Error: Boolean operations failed." enough?


model in ParticleSampler

ParticleSampler still has a field named model. I guess we can remove it now?

yes, we can do that (if it doesn't have dependencies)

BTW: it is probably a good practise to start referencing issue IDs in commit comments.

I see. Good suggestion!

Implemented in #137


Add dark mode

Description
This is a jQuery plugin that enables developers to add a screen color change button to their web pages. With this plugin, users can customize the background colors of the page and add visual effects to the button.
Features
Dynamic Color Change: Choose from a variety of pre-defined colors to customize the appearance of your page.
Button Sink Effect:
How to Use
Installation:
npm i screen_color_plugin

Toggle Mode is a simple and customizable jQuery plugin that allows users to switch between light and dark modes on your website with ease. It's perfect for enhancing the user experience and accessibility by providing an option to change the display mode according to their preferences.
https://jquery-toggle-switch-plugin.vercel.app/
npm i jquery-toggle-mode-plugin

Hi @Biasiolo, thanks for the tips.
But for this project, I think that will better use the tools the Ionic framework already gives us.
For example, follow this tutorial: Dark Mode to Change Color Schemes and CSS Properties


Add the ability to redirect user from the host url

What issue does this PR address?
Add the ability to redirect user from the host url (Ex: ASP.NET Core Identity under /identity and IdSrv4 under /auth path).
Related question #4306.
Does this PR introduce a breaking change?
Yes.
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[x] Unit Tests for the changes have been added (for bug fixes / features)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: alaincroisetiere sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Question #4306 is under investigation.

Yep, we'll have a look when we can.


Having clearer and more detailed Tracer methods' descriptions and examples would be great

Right now it's not crystal clear when one should call which Tracer method when instrumenting other libraries and how those methods contribute to the trace lifecycle.
Having full-blown examples with comments would be the best, however better description of trace lifecycle in the docs / more clear and detailed javadocs for Tracer would also be good.

What exactly are you missing? What exactly is not understandable from the javadocs / documentation?

Closing due to inactivity.
Also added some javadocs here https://github.com/spring-cloud/spring-cloud-sleuth/issues/587


[Run] Distance starts in meters then changes to miles

Affected hardware version
Bangle 2
Your firmware version
2v13
The bug
Description
When I use the run app it starts by displaying distance in meters then after a certain threshold it shows miles.
Expected
Show meters then kilometer.
I tried reviewing the locale files but idk where this issue would steam from. If someone can point me in the right direction I would like to fix it myself.

I can confirm that this issue is also present on Bangle 1

After having a look at the source for apps/run/app.js it seems that the various reported metrics are calculated using the exstats module. There's a hook (if that's the right use of that word) in the run code for when the various metrics (or "stats"), like distance, are updated and a "notify" event is emitted by exstats; it's generic, because the layout is configurable, but take a look here:
https://github.com/espruino/BangleApps/blob/ac5c80ff38a474474236e3a852c23b7e2e21df44/apps/run/app.js#L101
The code which decides the string to display for the distance is here: https://github.com/espruino/BangleApps/blob/c2ca52fd1db986653e43176258178de7ca217be2/modules/exstats.js#L222
The getString method does rely on locale.
I haven't gone any further with this yet, but I'll keep digging as I'm learning a lot about the code! Next thing is to look at what locale is doing.

After reading a bit of this: https://www.espruino.com/Bangle.js+Locale ... it's clearer that the problem is in 'firmware'. Having a look at the Espruino repo, I found the line which causes this effect:
https://github.com/espruino/Espruino/blob/ff25ff80dff7065b495a9f7a7796b4acedc85cb8/libs/js/banglejs/locale.js#L24
Do we want to fix this? If so, what's the fix:

Make the locale yards and miles to agree with the "en_GB" locale here: https://github.com/espruino/BangleApps/blob/ac5c80ff38a474474236e3a852c23b7e2e21df44/apps/locale/locales.js#L70
Add some locale choices in settings, somehow, to allow the default to be globally UK Metric.
Add some settings in Run's app settings to display "dist (metric)". I can see that you might want per app distance.
...or you might want both in the same app, so a properties in exstat for "distance (metric)", "distance (imperial)", with "distance" clearly documented as the locale default.

PR for 'fixing' the distance in the default locale: https://github.com/espruino/Espruino/pull/2210

So, I'd say that there's still the outstanding issue of being able to display metric distance in the Run app.  I think this would be a matter of adding a stat to exstat (cf., the module's code) that ignores locale and just prints metres and kilometres; I would think that another stat to exstat that always converts to imperial would be balanced.

What country are you in?
Did you try just installing the Languages app for your country? Because then the units for distance should be changed to what you expect.
There is obviously the question of what if you're in that country but don't want the default units, and I guess ideally the Languages app's page could be modified to allow customisation...

I'm in the UK.
I had a thought: How about "re-branding" the default locale to "system" (i.e. it's not GB) and then allowing metres/kilometres for the distance?  I feel that would preserve consistency.  Would there be any impact on a re-brand?
There's still a change in the interface - the units will be formatting in wholly metric - but at least it's a change towards a more consistent interface.
If the imperial/metric choices can be made via the Languages app (my thought was exstats), then that's possibly the place to add them; I think that's a discussion for the BangleApps side of things, though.

How about "re-branding" the default locale to "system"

Sounds like a good plan, and then we can just choose what makes sense :) Just done, although I'm not sure if anyone even uses that field :)
Worth noting there's actually already a settings menu for exstats/run so selection of units might make more sense in there.

Worth noting there's actually already a settings menu for exstats/run so selection of units might make more sense in there.

I had noticed that the options available to Run are essentially the exstats module's properties; is this what you mean?

Well, here: https://github.com/espruino/BangleApps/blob/0c3a7dfe9e7e2f6aa4ad997cc226bb789d222f87/modules/exstats.js#L375-L387
So the idea being that any app that uses exstats can have those options in it - but they can be different for each app


Add proxy configuration UI and logic

This PR is a proposal aiming to solve the issue #343
Screenshots

:white_check_mark: Build ServiceBusExplorer 4.2.0-proxy-settings.57.build.646 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/c78cfa07a6 by @)

Great! However, the Options dialog gets too big for smaller screens. I just created a PR for adding tabs to the Options dialog. Once that is approved, put the proxy settings on the Connectivity tab.

Sure! will do!

I just approved @ErikMogensen PR that tabifies the Options form. It looks like this PR is in contrast with Erik's one. In other words, I will close this PR for now.


Get-ExternalInOutlook doesn't work in Shared Mailbox

Hi!
After we enabled Get-ExternalInOutlook we noticed that only regular mailboxes display [External] tag, but Shared mailboxes don't have it.
Is it a bug or a feature?

@cupntea, your best bet is to open a support case and ask there.

@chrisda no offense, but knowing how exchange support are treating those request, it's unlikely I'll get a coherent response even after a month of emails exchange explaining what I actually need.

@

@cupntea, sorry for the delay. I was having difficulty getting a response.
The up-to-date consensus is that this works on regular mailboxes (clearly) and shared mailboxes, but not Microsoft 365 Group mailboxes.
Can you confirm or deny?

@chrisda as far as I remember it simply didn't work for Shared mailboxes.
Ok, I will create a support ticket with Microsoft.

@cupntea Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


About css files

Hi @AllenFang ,
We are cdnjs team, we want to host this project in cdnjs.
I'd like to confirm if the files under css folder also need to be hosted in cdnjs. If yes, is it possible to put files under css folder into dist folder?
Thank you.
https://github.com/cdnjs/cdnjs/pull/8776
https://github.com/cdnjs/cdnjs/issues/8751

@pvnr0082t, ok I'll move the css file to dist folder in next version. Thanks

Fixed on v2.4.4

Thank you. @AllenFang


Font awesome social icons doesn't very well

Hey,
First, thanks for your job on this wp theme. You're doing it right!
I have a problem on my wp with social icons in the footer of my pages.
I'm using redirection with my dns because i have multiple webistes.
This comes from there because i have 2 urls for the same blog.
My visitors have to click on urbain.io .
And if you take a look in the footer you can see multiple square.
Do you know what it is could be ?
Thanks!

Okay, so i think i found a trick to solve this issue.
Go to admin panel > general > and change the domain name of the blog.
When i refresh the problem was solve.
I don't know how and why but it works!
Regards,


Fix broken package

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy
[x] Ensured the license file is being packaged.

Fix broken package (see https://github.com/conda-forge/r-pillar-feedstock/issues/4).

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


1D Convolution op

: https://github.com/llvm/torch-mlir/blob/536e45cb3bc6951ae90de5c8e969d7fd03cfd955/lib/Conversion/TorchToLinalg/Linear.cpp#L533

I'm interested in adding support for this

@stellaraccident can you add perms for Sam to accept issue assignment

Hi @dan-garvey, can we close this issue, if fixed?


Resources from the original API Demo are not parsed correctly

Loading http://www.markus-lanthaler.com/hydra/api-demo/issues/2 returns an incomplete object.
Looks like only the @id and @type are preserved and the rest somehow lost...

Nope, I'm just foolish


Updating and making it easier to run benchmark measurements for ODoH

Updates the ease with which benchmarks can be run
Makes corrections to the --out benchmark output
Adds scripts to download, and prepare dataset (Tranco) as an example

Signed-off-by: Sudheesh Singanamalla<EMAIL_ADDRESS>

@chris-wood @tanyav2 What do you think?

Is there a reason why this needs to be in this repo, as opposed to some other script or program that uses the client directly?

I think it'd be useful to have this directly with this client codebase as a reproducible artifact for the paper. A reviewer or someone wanting to test the benchmark portion of the client should be readily able to test it out of the box. So the documentation updates and getting the dataset and preparing it correctly might be valuable.

I think it'd be useful to have this directly with this client codebase as a reproducible artifact for the paper.

I understand, but that doesn't mean it needs to be in this repo, right? One could, for example, put the script to fetch data and drive the client in a separate repo, and that repo could just clone this one in the process and build the client.

That is a possibility.

Let's do that then. I'm not sure piling on things here is best. Closing!

Sure, I'll open a separate PR for fixing the --out issue


incorrect error message on apiVersions-Should-Be-Recent-In-Reference-Functions.test

See the template in #385 for a repro.
The reference function is using an older preview apiVersion - so this should throw an error, but the error thrown is "apiVersion not found" - it's found it's just too old and the error message should state that.

This needs to be case insensitive:
https://github.com/Azure/arm-ttk/blob/master/arm-ttk/testcases/deploymentTemplate/apiVersions-Should-Be-Recent-In-Reference-Functions.test.ps1#L106

template:
{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
    "contentVersion": "<IP_ADDRESS>602",
    "parameters": {
        "location": {
            "type": "string",
            "defaultValue": "[resourceGroup().location]",
            "metadata": {
                "description": "The location in which the resources should be deployed."
            }
        }
    },
    "variables": {
        "userAssignedIdentityName": "msi"
    },
    "resources": [
        {
            "type": "Microsoft.ManagedIdentity/userAssignedIdentities",
            "apiVersion": "2015-08-31-preview",
            "name": "[variables('userAssignedIdentityName')]",
            "location": "[parameters('location')]"
        }
    ],
    "outputs": {
        "foo": {
            "type": "string",
            "value": "[reference(resourceId('Microsoft.ManagedIdentity/userAssignedIdentities', variables('userAssignedIdentityName')), '2015-08-31-preview').principalId]"
        }
    }
}

This is fixed going to dogfood it in QuickStarts before we release


[Fix #3148] Make Rails/UniqBeforePluck more conservative

This change is to address Issue https://github.com/bbatsov/rubocop/issues/3148
Autocorrect is disabled by default for this cop since it can potentially generate false positives.
Add offenses for distinct as well as uniq.
By default only add offenses for calls to pluck directly
on constants.
Add an 'aggressive' mode that adds all offenses as the cop did
originally.

[x] Wrote good commit messages.
[x] Used the same coding conventions as the rest of the project.
[x] Feature branch is up-to-date with master (if not - rebase it)
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] All tests are passing.
[x] The new code doesn't generate RuboCop offenses.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.

@jonas054 Restored auto-correct, including support for distinct and uniq, squashed, and rebased. Auto-correct is disabled by default for this cop.

:+1: Changes look good. Just one more thing. Sorry I didn't mention it earlier. If this fixes #3148, which I think it does, you should start the commit message with [Fix #3148].

@jonas054 Updated the commit message to start with the issue being fixed. Thanks!

You'll have to rebase on top of the current master.

@bbatsov rebased


bug: Ionic Slide Box Breaks on splice an item. Goes to last index and overlaps.

Type: bug
Platform: ios 8 webview
Here is the code pen that shows the error. Try removing the item , example product 3, the slide box slides to last product and overlaps the other items. ( see the pager, it moves )
http://codepen.io/anon/pen/qEvyLV?editors=101
any help would be big help.
EDIT: I included a $ionicSlideBoxDelegate.update(); on slide change function, it seems to slightly fix the issue but only on slide change. Its not a 100% solution. Check Code pen.

Greetings @promactkaran!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

The slidebox implementation is broken when you try to update the underlying collection.
Just another demonstration of it. Also, my last comment links to a branch that has not been included in the RC's yet that contains an overhaul of the slidebox implementation.
https://github.com/driftyco/ionic/issues/3076

If you give the slidebox a millisecond or two for some asynchronous actions, it looks to work properly:
http://codepen.io/perrygovier/pen/QwoPbb?editors=101
Let me know if that doesn't resolve the issue

This is a good try, but unfortunately, its all messy now also, if I splice 1st product it goes to product3, and one major problem , if I splice last object (product 11) it splices behind leaving the screen blank..  @perrygovier

Possible work around I found to this problem: setting a SetInterval javascript function.
though its not 100% correct , it is one of the workaround when you want to splice slidebox slides.
here is a code pen for the same:
http://codepen.io/anon/pen/qEvyLV?editors=101

I'm having a very similar issue on Android as well, Looks like some users (including me) found this closed issue and are posting there:
https://github.com/driftyco/ionic/issues/1578#issuecomment-74268456

@CodyMorris have you tried the suggestion of calling update multiple times in a $timeout? It is the only known workaround right now with what is released. I use a loop that runs every 250ms for 4 times just to be sure.

@agnellvj Yes thats exactly what I do right now. I have set out a Interval function of javascript to call update every 200ms for 2 seconds.

Is there any fix of this issue? Please update.

@agnellvj yeah, that works but its definitely not ideal

Well...This worked for me though this is not a solution of the bug.
$scope.trashMe = function(index) {
var indexToremove = $ionicSlideBoxDelegate.currentIndex();
$scope.next();
$timeout(function() {
var data = $scope.slideData;
data.splice(indexToremove, 1);
$scope.slideData = data;
$ionicSlideBoxDelegate.update();
});
$scope.previous();
};

Hey guys, look at PR: https://github.com/driftyco/ionic/pull/3842
It's all broken because of angular ngAnimate, disabling it on the ionSlideBox directive works.

Having same issue.

Any progress in this issue, still facing the problem.

having same problem, do you solved the problem?

Hey everyone, can you try the new slidebox just pushed to master (available in upcoming 1.2):
<ion-slides options="options">
  <ion-slide-page>
  </ion-slide-page>
</ion-slides>

New slidebox should fix this ,closing until I get confirmation


Update quic-go to v0.48.2 plz

Version 0.8.0 does not support security fix updates of v0.48.0 and above, and a new version needs to be released

I guess you haven't read the README, have you?

Heartbreak.... But thank you very much.

You can just bump the quic-go version in your project's go.mod. It's a patch release, hence there are no breaking changes.

Incompatible with newer versions due to structural changes: https://github.com/quic-go/webtransport-go/commit/4ac2c9250e66042470c55c7e9f431269c7dbd3ed

That's not correct, but this is not a support forum.


Circular reference handled via proxies

I'm injecting types via DI constructor. When schema is built, I'm getting this error:
Schema must contain unique named types but contains multiple types named "CircularType" (see http://webonyx.github.io/graphql-php/type-system/#type-registry).
That is because I'm using proxies https://github.com/Ocramius/ProxyManager to get actual services so I avoid circular reference.
class TypeOne
{
    public function __construct(TypeTwo $typeTwo)
    {
        // ...
    }
}

class TypeTwo
{
    public function __construct(TypeOne $typeOne)
    {
        // ...
    }
}

However the test for duplicate types is $typeMap[$type->name] === $type and that's always false when using proxies even though the wrapped type is the same instance.
How to handle this properly? My only solution so far is to fork this and remove that check
        if (!empty($typeMap[$type->name])) {
            Utils::invariant(
                $typeMap[$type->name] === $type,
                "Schema must contain unique named types but contains multiple types named \"$type\" ".
                "(see http://webonyx.github.io/graphql-php/type-system/#type-registry)."
            );
            return $typeMap;
        }

The similar check is on Executor.php:942

Do you use proxies for circular types only? Have you seen this article in docs and why it won't work for you?

Yup, only for circular types. I use dependency injection for types that I autowire and not using static (global) types which I consider to be a cleaner way.
But I might have found a way -> opening PR as I believe it's not working properly in this library.

I am curious why your proxy manager (or DI container) creates multiple instances for the same underlying type? This seems wrong to me. It leads to subtle errors and may cause significant performance overhead (as basically, you have {number of fields of this type} objects per type vs 1) unless I am missing something.

The ocramius' https://github.com/Ocramius/ProxyManager creates multiple proxy instances with the same instance of underlying type within. Therefore, it doesn't create circular references when using DI. However I think this approach is no go with this library as it would require adding a new dependency.
Instead I started using callables those when invoked return the actual type instance. This way I can avoid circular references and still use DI. (https://github.com/webonyx/graphql-php/pull/257#issuecomment-373685194)

Closing after conversation in #257


New release

Any chance you can release the stuff that has made it on to master but isn't in hackage yet?

This doesn't build on GHC 8.4. Maybe merge https://github.com/pxqr/udev/pull/5 and push a new release?

I'd like to take over this package, since it seems that it is no longer maintained by the owner. I'm going to start going through the process to have this done with hackage. It seems that @pxqr is no longer active on hackage/github, but if you are, please let use know.

I could take it over, too. I have some other code that uses this, and more local changes I could PR. Or we could both maintain it. Whatever you prefer. You have more experience with publishing Haskell packages - I've only published one.

@LeifW Yeah I'm fine with either, just want to get the ball moving on this since I want to have this. I emailed the hackage maintainers already, but if you would rather take it over that would be great.


converting data import tool from console to windows

From @turpu-rakesh on October 9, 2018 9:0
Copied from original issue: Microsoft/Access2Justice#558

@svasylenko Please validate that this is complete.

This task relates to creation of LN API to pull data from a2j.


FileView chooser needs rename, delete etc file actions in context menu

e.g., if you do NewFolder, then you need to be able to rename it.

these were actually there -- triggered only on the icon though, because the other fields are string and have their own copy context menu that grabs event.  Good enough.  Rename was not working but now is.
main issue now is that duplicate and delete don't update -- better to get file event signals probably -- separate ticket


map location icon: apple icon is used on android

Description of issue
'take me to my location' icon on android uses apple icon (arrow) instead of android icon (target)
Expected behaviour
Android target icon should be used on android devices
Steps to reproduce
On Android, go to parade route
Look top right
Observe apple arrow icon instead of android target icon
OS / Browser / Device model
only tested on my Pixel
Screenshots
If it's a visual bug, please provide screenshots or screen captures.

So it was decided to use the functionality that we're using for iOS to go to current location, and while that was happening, consensus was that the iOS button was nicer/behaved better. I am however more than happy to change this to an android button, but it would mean getting assets from somewhere 😬

Hi @abinocoe Can we please use the Android icon? Think it might be better to keep the respective icon for each map application

The default Android button is not as nice. It doesn't have an active state. In addition we have limited control over its functionality. Would be great we could get custom assets, that match the Android default icon, though.

Cool - yeah let's do that... I'll hunt for an Android-ish icon @frigus02

Downloadable assets for Android Current Location in Zep:
zpl.io/awY1LgD
zpl.io/ad7k4wK

thank you @JunBadger

@JunBadger is it possible to get those icons grouped with the white background circle?

Cool, all done @abinocoe

Downgraded this to medium as we have some higher priority issues (like the map crashing the app)


Disable telemetry parameters in the token request when using OIDC protocol mode

This PR automatically removes the x-client-current-telemetry and x-client-last-telemetry parameters from the token request when using OIDC protocol mode.
Relevant issue

Codecov Report

Merging #6262 (be1a765) into dev (81d34b4) will decrease coverage by 6.55%.
Report is 217 commits behind head on dev.
The diff coverage is 48.68%.

Flag
Coverage Δ

msal-angular
96.73% <96.63%> (+0.22%)
:arrow_up:

msal-browser
?

msal-common
83.18% <ø> (-1.37%)
:arrow_down:

msal-core
?

msal-node
79.39% <ø> (-4.00%)
:arrow_down:

msal-node-extensions
41.10% <14.19%> (-34.54%)
:arrow_down:

msal-react
94.24% <ø> (-0.45%)
:arrow_down:

node-token-validation
?

Files Changed
Coverage Δ

...ions/msal-node-extensions/src/utils/Environment.ts
20.51% <0.00%> (-22.08%)
:arrow_down:

...l-node-extensions/src/broker/NativeBrokerPlugin.ts
3.80% <3.80%> (ø)

...node-extensions/src/persistence/FilePersistence.ts
56.52% <17.14%> (-17.25%)
:arrow_down:

...msal-node-extensions/src/lock/CrossPlatformLock.ts
72.50% <21.42%> (-8.59%)
:arrow_down:

.../msal-node-extensions/src/error/NativeAuthError.ts
28.57% <28.57%> (ø)

...-extensions/src/persistence/KeychainPersistence.ts
66.66% <30.76%> (-21.57%)
:arrow_down:

...extensions/src/persistence/LibSecretPersistence.ts
72.22% <30.76%> (-16.02%)
:arrow_down:

...tensions/src/persistence/PersistenceCachePlugin.ts
71.05% <33.33%> (-4.63%)
:arrow_down:

...c/persistence/FilePersistenceWithDataProtection.ts
58.33% <60.00%> (-22.75%)
:arrow_down:

extensions/msal-node-extensions/src/Dpapi.ts
66.66% <66.66%> (-33.34%)
:arrow_down:

... and 15 more

... and 212 files with indirect coverage changes


Add static search to MoMS site

Trying to use the MoMS alpha site search function currently leads to an error 404 page. Please add the static search function.

Done in rev 11448.


[UNDERTOW-1899] fix servlet mapping value in case of forward to error…

… page
Issue: https://issues.redhat.com/browse/UNDERTOW-1899
Upstream PR: https://github.com/undertow-io/undertow/pull/1170

Bulk closing PRs for 2.1.x, no 2.1.x releases planned.


error while using factiva_extract function

ValueError: time data '3 mars 2019' does not match format '%d %B %Y'

Yeah, your dates are gonna have to be in %d %B %Y format, which means English only for now. Sorry!


eslint errors on 'interface' keyword even when using this parser

I have Babel, ESLint, and Flow all being used in my React Native project. My .eslintrc looks like this:
{
    "parser": "babel-eslint",
    "env": {
        "browser": false,
        "commonjs": true,
        "es6": true,
        "node": true
    },
    "extends": [
        "eslint:recommended",
        "plugin:react/recommended",
        "plugin:flowtype/recommended"
    ],
    "parserOptions": {
        "ecmaFeatures": {
            "experimentalObjectRestSpread": true,
            "jsx": true
        },
        "sourceType": "module"
    },
    "plugins": [
        "flowtype",
        "react"
    ],
    "rules": {
        "indent": [
            "error",
            4
        ],
        "semi": [
            "error",
            "always"
        ]
    }
}

For some reason, I'm getting an error when I try to declare an interface type in my code:
// [eslint] Parsing error: interface is a reserved word in strict mode
export default interface ApiClient { ... }

Not sure why. Could I have setup something wrong?

Thank you for the issue. Now that @babel/eslint-parser has been released, we are making this repository read-only. If this is a change you would still like to advocate for, please reopen this in the babel/babel monorepo.


Fix y billboard shear when rotating camera

Fixes #52108.
Model rotation and scale are also ignored when transforming the billboard matrix now, removing additional shear when rotating the model itself as well as bringing it more in line with BILLBOARD_ENABLED.

Thanks!

Cherry-picked for 3.4.


Added interquartile range to target stats and target filtration.  Closes #375.

@vruano please review.  Your PR on FilterTargets was first, so any rebasing hassle in on me.

Looks good. Don't worry I will merge mine after, conflicts should be minimal.


[WIP] add support for [TRUNCATE|DISCARD|IMPORT|ANALYZE|OPTIMIZE|REPAIR] PARTITION

What problem does this PR solve?
Fixes  #432

MySQL Syntax:

alter_specification:
...
  | DISCARD PARTITION {partition_names | ALL} TABLESPACE
  | IMPORT PARTITION {partition_names | ALL} TABLESPACE
  | TRUNCATE PARTITION {partition_names | ALL}
  | ANALYZE PARTITION {partition_names | ALL}
  | OPTIMIZE PARTITION {partition_names | ALL}
  | REPAIR PARTITION {partition_names | ALL}
...

Add TRUNCATE PARTITION ALL clause.
What is changed and how it works?

Update ast/ddl.go, add AlterTableTruncateAllPartition and modify Restore.
Update parser.y.

Check List
Tests

Unit test

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

PTAL @tangenta

@huaouo There seems 2 shift/reduce conflicts encountered. you can grep conflict on to identify where indeed conflicts happens

@huaouo There seems 2 shift/reduce conflicts encountered. you can grep conflict on to identify where indeed conflicts happens

I'm sorry to bother you at midnight, but on my machine, there seems no such a problem. So wired.
➜  Workspace git clone https://github.com/huaouo/parser
Cloning into 'parser'...
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (29/29), done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 2162 (delta 18), reused 23 (delta 13), pack-reused 2133
Receiving objects: 100% (2162/2162), 13.57 MiB | 279.00 KiB/s, done.
Resolving deltas: 100% (1603/1603), done.
➜  Workspace cd parser
➜  parser git:(master) make test
gofmt (simplify)
sh test.sh
ok  	github.com/pingcap/parser	2.361s	coverage: 66.6% of statements in ./...
ok  	github.com/pingcap/parser/ast	1.422s	coverage: 44.8% of statements in ./...
ok  	github.com/pingcap/parser/auth	1.040s	coverage: 1.4% of statements in ./... [no tests to run]
ok  	github.com/pingcap/parser/charset	1.042s	coverage: 2.0% of statements in ./...
ok  	github.com/pingcap/parser/format	1.042s	coverage: 2.6% of statements in ./...
?   	github.com/pingcap/parser/goyacc	[no test files]
ok  	github.com/pingcap/parser/model	1.046s	coverage: 3.6% of statements in ./...
ok  	github.com/pingcap/parser/mysql	1.043s	coverage: 1.8% of statements in ./...
ok  	github.com/pingcap/parser/opcode	1.040s	coverage: 1.5% of statements in ./...
ok  	github.com/pingcap/parser/terror	1.040s	coverage: 2.4% of statements in ./...
ok  	github.com/pingcap/parser/types	1.048s	coverage: 7.3% of statements in ./...
➜  parser git:(master) git log -1 | head
commit ef08923e4d8e62fb1efba66716397bfe99fd8910
Author: Zhenhua Yang<EMAIL_ADDRESS>Date:   Tue Aug 13 23:18:18 2019 +0800

    add NO_WRITE_TO_BINLOG option for ALTER TABLE OPTIMIZE PARTITION & REPAIR PARTITION

@huaouo There seems 2 shift/reduce conflicts encountered. you can grep conflict on to identify where indeed conflicts happens

I'm sorry to bother you at midnight, but on my machine, there seems no such a problem. So wired.
➜  Workspace git clone https://github.com/huaouo/parser
Cloning into 'parser'...
remote: Enumerating objects: 29, done.
remote: Counting objects: 100% (29/29), done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 2162 (delta 18), reused 23 (delta 13), pack-reused 2133
Receiving objects: 100% (2162/2162), 13.57 MiB | 279.00 KiB/s, done.
Resolving deltas: 100% (1603/1603), done.
➜  Workspace cd parser
➜  parser git:(master) make test
gofmt (simplify)
sh test.sh
ok  	github.com/pingcap/parser	2.361s	coverage: 66.6% of statements in ./...
ok  	github.com/pingcap/parser/ast	1.422s	coverage: 44.8% of statements in ./...
ok  	github.com/pingcap/parser/auth	1.040s	coverage: 1.4% of statements in ./... [no tests to run]
ok  	github.com/pingcap/parser/charset	1.042s	coverage: 2.0% of statements in ./...
ok  	github.com/pingcap/parser/format	1.042s	coverage: 2.6% of statements in ./...
?   	github.com/pingcap/parser/goyacc	[no test files]
ok  	github.com/pingcap/parser/model	1.046s	coverage: 3.6% of statements in ./...
ok  	github.com/pingcap/parser/mysql	1.043s	coverage: 1.8% of statements in ./...
ok  	github.com/pingcap/parser/opcode	1.040s	coverage: 1.5% of statements in ./...
ok  	github.com/pingcap/parser/terror	1.040s	coverage: 2.4% of statements in ./...
ok  	github.com/pingcap/parser/types	1.048s	coverage: 7.3% of statements in ./...
➜  parser git:(master) git log -1 | head
commit ef08923e4d8e62fb1efba66716397bfe99fd8910
Author: Zhenhua Yang<EMAIL_ADDRESS>Date:   Tue Aug 13 23:18:18 2019 +0800

    add NO_WRITE_TO_BINLOG option for ALTER TABLE OPTIMIZE PARTITION & REPAIR PARTITION

Try to delete parser.go and execute make again?

@huaouo  Please resolve conflicts :)

LGTM

@kennytm PTAL

It seems there isn't an issue in the list about ANALYZE PARTITION, do I need to fix it? @leoppro

It seems there isn't an issue in the list about ANALYZE PARTITION, do I need to fix it? @leoppro

we needn't fix it

It seems there isn't an issue in the list about ANALYZE PARTITION, do I need to fix it? @leoppro

we needn't fix it

But according to MySQL's parser file, it also requires an opt_no_write_to_binlog option, same as ANALYZE TABLE stmt.

It seems there isn't an issue in the list about ANALYZE PARTITION, do I need to fix it? @leoppro

we needn't fix it

But according to MySQL's parser file, it also requires an opt_no_write_to_binlog option, same as ANALYZE TABLE stmt.

Oh, I had a  wrong understanding of your comment. We need to fix it.


option to use proxy

hello and thanks for the project.
is there any way to pass proxy options to the app,
and what about support for socks5, http/s formats?

Thank you for taking the time to share this suggestion and for your interest in Discordo! At this time, we do not plan to support proxies as it is beyond the current scope of this project. However, you can still achieve similar functionality by using a system-wide proxy or configuring proxies at the network level. Check out proxychains for Linux and Proxifier for Windows and macOS.


tools to convert tl schema to protobuf

is there a tool/program to convert TL schema to corresponding protobuf?

https://github.com/nebulaim/mtprotoc


Update drug documentation on platform documentation

The documentation pages for the Platform need to be updated to reflect changes:

https://docs.targetvalidation.org/data-sources/data-sources
https://docs.targetvalidation.org/data-sources/drugs

will be included in the new documentation


Fix vcpkg_host_path and its unit test

Fallout from https://github.com/microsoft/vcpkg/pull/24653:

What does your PR fix?
Fixes the broken unit tests for vcpkg_host_path.
Fixes PREPEND mode of  vcpkg_host_path to actually prepend, not append.
Adds host-path-list and merge-libs to the default features (i.e. always tested).
Related/partial duplicate: #24799 (CC @JackBoosY)

Which triplets are supported/not supported?  But it might significantly affect build results. Trigger a world rebuild?


Avl

Description 📜
Documentation of AVL Tree
Fixes #6569

Type of change 📝

[ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
[ ] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
[X] Documentation (Content Creation in the form of codes or tutorials)
[ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

[ ] Android Dev #(Flutter)
[ ] Android Dev #(Java)
[ ] Android Dev #(Kotlin)
[ ] Backend Dev #(Java)
[ ] Backend Dev #(.NET)
[ ] Backend Dev #(PHP)
[ ] Backend Dev #(Python)
[ ] C/#CPP
[ ] Competitive #Programming
[ ] Cyber #Security
[X] DSA
[ ] Data#base
[ ] Datascience with #Python
[ ] Datascience with #R
[ ] Frontend Dev #HTML/CSS/JS
[ ] Frontend Dev #React/Angular/Vue
[ ] Go#lang
[ ] Interview #Prep
[ ] Java_#Domain
[ ] JavaScript_#Domain
[ ] ME#RN
[ ] Machine #Learning
[ ] Open #Source
[ ] Python_#Domain
[ ] Ru#st
[ ] Statis#tics
[ ] UI/#UX

Checklist ✅

[X] I follow Contributing Guidelines & Code of conduct of this project.
[X] I have performed a self-review of my own code or work.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generates no new warnings.
[X] I'm GWOC'21 contributor

@prak895 I reverted the PR since it caused workflow error in DSA branch. You've added file in C_CPP folder though you're contributing in DSA branch. Please add file in DSA folder while working in DSA branch. If you wish to contribute to C_CPP then feel free to work in C_CPP branch. Also, while opening PR, do check if it shows 1 file changed since that's the correct way and shows your contribution only.
Right now, it shows 356 files changed.

@prak895 I reverted the PR since it caused workflow error in DSA branch. You've added file in C_CPP folder though you're contributing in DSA branch. Please add file in DSA folder while working in DSA branch. If you wish to contribute to C_CPP then feel free to work in C_CPP branch. Also, while opening PR, do check if it shows 1 file changed since that's the correct way and shows your contribution only. Right now, it shows 356 files changed.

what I do now?

Add file in DSA folder and create a new PR. Also, make sure to pull upstream commits of DSA branch.


Extension is installed but no system config options

I have dropped in the extension files.
Extension is showing as installed under system > advanced.
However there is no options available within system config.
Magento ver. Enterprise <IP_ADDRESS>
Any ideas why this is?

Hi @pushonrobert, I cannot reproduce this issue. On a clean install I see the configuration values in "System > Config" under "Advanced / System / Cachebuster Settings".

Please re-open with more details if you still have an issue.


Refactor feat #75

close: #75

At the end of the blue curve you have a curve, is this supposed to be correct?

Yes, it is how the data is.

At the end of the blue curve you have a curve, is this supposed to be correct?

Yes, it is how the data is.


[Improvement] Simplify Wallet Renaming Flow

Description:
Currently, renaming a wallet profile in Alby Go requires several steps, making it less intuitive. Here's the current flow for renaming a wallet named "DEFAULT":

Click the settings icon in the top right corner.
Select Wallets.
From the list, choose the wallet named “DEFAULT.”
Click the settings icon in the top right corner again.
Select Wallets once more.
With “DEFAULT” selected, click the settings icon next to it to access four options, including the option to rename the wallet.

Issue:
This flow feels unnecessarily long and could be streamlined for better user experience. It would be helpful to have a simpler way to access the wallet settings, especially since users occasionally skip naming their wallets, leaving them stuck with the placeholder "DEFAULT" (which can be a bit ugly, by default 😄). There is an issue about this, but these two are separate problems.
Suggested Improvement:
Provide a quicker, more direct way for users to rename their wallets from the settings page. This would enhance usability and reduce potential frustration, especially for new users.

@stackingsaunter maybe combine this with #214 so we can go directly to the active wallet settings from the icon


Clicking on "make a block" opens up Variable creation dialog box on top of block creation box in iPad device

Open the URL in an iPad.
Navigate to My Blocks -> Make a block (for new block creation)

Expected result should be Block creation dialog box should be displayed instead of Variable box creation

https://screencast.googleplex.com/cast/NjAxNjY0NTkxODA5NzQwOHw2NGMxZDA1Yi0wZg

On iPad device, the block creation box is shown up when clicks on "Make a Block".


Implement support for dilation in conv2d

Currently conv2d takes dilation = 1, need to support > 1.
Required by:
#9694
#9695

this is done.


feat: add error handling to FromElx trait

Closes #101
This PR makes the FromElx trait return a Result<Self, FromElxError>. The FromElxError simply wraps a String, but should make it easier to refactor gradually in the future.

@all-contributors please add @MegaRedHand for code


example-forum: Add custom fields required for user profile.

Changes in vulcan-users caused a regression in profile displaying. This patch is adding missing fields previously defined in vulcan-users.
karama is also required, but in reality it needs to go to vulcan_voting that depends on it, unless there are plans to remove it completely.

Thanks! Yeah I think we can leave karma out at least for now.