(BOLT-608) Add local transport for Windows OS

Add support for local transport on windows OS.

CLA signed by all contributors.

I have a testing environment set up at jbwztop5z8no6nc.delivery.puppetlabs.net feel free to use it. See example below.
C:\Users\Administrator\bolt>bundle exec bolt script run test.rb one -n localhost
bundle exec bolt script run test.rb one -n localhost
Started on localhost...
Finished on localhost:
  STDOUT:
    Ruby script
    one
Successful on 1 node: localhost
Ran on 1 node in 0.81 seconds

Looking forward to seeing this. +1 to all involved.

Needs a rebase.


[driver] Issue with driver for ADS1115

In case, when a range of measuring is set as RANGE_6_144V, and I try to measure 5v, I got ~4.8v instead of 5v.

There may be a margin of error that is listed in the device datasheet. There may also be a part of your circuit that is causing a small drop, such as a resistor.

There may be a margin of error that is listed in the device datasheet.

No, I've connected an input of the ADC directly to a source of 5v power without resistors and I've got only ~4.8v. But, there exists a strange thing that I've noticed, I've tried to measure 3.3v in such way and with my circuit, and it was measured correctly with the range: RANGE_6_144V.


Dev test: Gas Properties 1.0.0-dev.38

@KatieWoe, @arouinfar, @ariel-phet, @kathy-phet, gas-properties/1.0.0-dev.38 is ready for dev testing.  This sim is brand=phet only.  It has no PhET-iO and no a11y instrumentation.
It's highly desirable to have this testing completed by 7/2/19.
Document issues in https://github.com/phetsims/gas-properties/issues and link to this issue.
Assigning to @ariel-phet for prioritization.

General Dev Test

What to Test

Click every single button.
If there is sound, make sure it works.
Make sure you can't lose anything.
Play with the sim normally.
Try to break the sim.

Focus and Special Instructions

During implementation, this sim has been tested primarily on macOS+Chrome and iOS.  Other platforms need a good shakedown.

Multitouch could use a more thorough shakedown. Most interaction can be performed simultaneously.  Some interaction are mutually exclusive by design (sorry, there is no list).  For example, you cannot resize the container and move its lid at the same time.

Memory testing was done in https://github.com/phetsims/gas-properties/issues/103, if you want to compare results.

@pixelzoom will likely be gone during most or all of this dev test. Please refer "How is this supposed to work?" questions to @arouinfar, who is the lead designer.   You can also consult the Gas Properties design document, which is mostly up-to-date.

The "Hold Constant" radio button group (found only on the Ideal screen) allows the user to hold one quantity constant while one or more of the other quantities change.  In some situations that becomes possible, and the sim will display an "Oops!" dialog.  For a description of this feature, see the table in the "Hold Constant" subsection of the Gas Properties design document.

model.md and implementation-notes.md are works in progress, but you may want to give them a quick read before testing.

Be sure to check out the "Options" dialog, accessible via the PhET menu.

General Dev Test Platforms

[x] Latest macOS, Chrome and Safari
[x] Latest iOS, Safari
[x] Windows 10, all browsers
[x] Latest Chrome OS, Chrome

Issues to Verify
As of this writing, there are no specific issues too verify.  All known issues have been addressed.

Link(s)

Simulation

FAQs for QA Members

There are multiple tests in this issue... Which test should I do first?
Test in order! Test the first thing first, the second thing second, and so on.

How should I format my issue?

We typically assign the developer who opened the issue in the QA repository.

My question isn't in here... What should I do?
You should:

Consult the QA Book.
Google it.
Ask Katie.
Ask a developer.
Google it again.
Cry.

Slight bump down in priority due to app testing

QA is done

Thank you @KatieWoe and QA team!

With the exception of https://github.com/phetsims/gas-properties/issues/125, issues identified by this dev test have been addressed and are properly labeled.  So I'm going to close this issue.


Some default values and all image name has no laclization

Expected Behavior
All names and default values should be in the local language.
(In Israel many children do not know how to read English letters before the 4th grade)
Actual Behavior
Some name and variables are not yet translated:

Default costume names are: costume1, costume2,..
Same for backdrops: backdrop1...

All image names in the "choose image" and "choose backdrop" menus are not yet translated.

Some default values:

The translation will be available on Transifex.

As @apple502j said, the translations are available on Transifex but simply have not been translated yet.

All available translations on transifex are already translated and reviewed.
The images and backdrops names are not available there
Please reopen.


train test val split of 60/20/20 doesn't work while it does using train_test_split from sklearn

x_train, x_test, y_train, y_test = scsplit(x, y, stratify = y, test_size=0.4, random_state=42)
x_test, x_val, y_test, y_val = scsplit(x_test, y_test, stratify = y_test, test_size=0.5, random_state=42)

^ doesn't work
x_train, x_test, y_train, y_test = train_test_split(x, y, test_size=0.4, random_state=42)
x_test, x_val, y_test, y_val = train_test_split(x_test, y_test, test_size=0.5, random_state=42)

^ works
Traceback (most recent call last):
  File "train_test_val.py", line 26, in <module>
    x_train, x_test, y_train, y_test = scsplit(x, y, stratify = y, test_size=0.4, random_state=42)
  File "/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/verstack/stratified_continuous_split.py", line 153, in scsplit
    X_t, X_v, y_t, y_v = split(X, y_binned,
  File "/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/sklearn/model_selection/_split.py", line 2422, in train_test_split
    n_train, n_test = _validate_shuffle_split(
  File "/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/sklearn/model_selection/_split.py", line 2067, in _validate_shuffle_split
    raise ValueError(
ValueError: The sum of test_size and train_size = 1.1, should be in the (0, 1) range. Reduce test_size and/or train_size.

Hi @monajalal
Fixed the issue. Install the fresh version of verstack
$ pip install --upgrade verstack
And reset your indexes before doing the second split
x_train, x_test, y_train, y_test = train_test_split(x, y, test_size=0.4, random_state=42)
# reset indexes
x_test.reset_index(drop = True, inplace = True)
y_test.reset_index(drop = True, inplace = True)
x_test, x_val, y_test, y_val = train_test_split(x_test, y_test, test_size=0.5, random_state=42)

It does not reset indexes internally, because this is a sensitive issue. You might rely on your indexes so you decide wether you need to save original indexes or not before the split.
Let me know how it went.

Thanks a lot for your response, so I used the following and it keeps stuck in an infinite loop printing Fold 4 done
# create first split
x_train, x_val, y_train, y_val = scsplit(x, y, stratify = y, test_size=0.2, random_state=42)

# save first split val indexes
first_val_ix = x_val.index.tolist()

# create a list where the used val indexes (that can not be used in subsequent val folds) will get appended
used_vals = first_val_ix.copy()

# create the maximum size for your subsequent val_folds
appropriate_val_size = len(first_val_ix)

# create dict to store your val indexes, populate it with first split val indexes
val_folds_ix_dict = {0:first_val_ix}

# create additional folds, make sure to increment the range if you need more folds
for fold in range(1,5):
    fold_val_ix = []

    while len(fold_val_ix) < appropriate_val_size:
        # remove the random_state setting
        X_train, X_val, Y_train, Y_val = scsplit(x, y, stratify = y, test_size=0.2)
        new_val_ix = list((set(X_val.index) - set(used_vals)))
        for i in new_val_ix:
            if len(fold_val_ix) < appropriate_val_size:
                fold_val_ix.append(i)
                used_vals.append(i)
            else:
                break

        val_folds_ix_dict[fold] = fold_val_ix
        print(f'Fold {fold} done')

# check the means of the folds you've created
for fold_num, fold_values in val_folds_ix_dict.items():
    val_ix = fold_values
    y_ix = list(y.index)
    train_ix = list(set(y_ix) - set(val_ix))
    print(f'fold: {fold_num}')
    print(f'val target mean  : {y[val_ix].mean()}')
    print(f'train target mean: {y[train_ix].mean()}')
    print('-'*25)

# your valid indexes broken up by folds are in val_folds_ix_dict
print(val_folds_ix_dict.keys())

Also, is there a way to have train, test, val ration of 60/20/20 and at the same time 5-fold cross validation? i think it's fine iif there are partial overlaps.

Thanks a lot. Confirming that after upgrading the package, it worked correctly.

so, I just noticed that you had removed the stratify=y, and for me that is what causes the error.
So here's the code I have:
x_train, x_test, y_train, y_test = train_test_split(x, y, stratify=y, test_size=0.4, random_state=42)
reset indexes
x_test.reset_index(drop = True, inplace = True)
y_test.reset_index(drop = True, inplace = True)
x_test, x_val, y_test, y_val = train_test_split(x_test, y_test, stratify=y_test, test_size=0.5, random_state=42)
and here's the error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/tmp/ipykernel_24143/1859206023.py in <module>
----> 1 x_train, x_test, y_train, y_test = train_test_split(x, y, stratify=y, test_size=0.4, random_state=42)
      2 # reset indexes
      3 x_test.reset_index(drop = True, inplace = True)
      4 y_test.reset_index(drop = True, inplace = True)
      5 x_test, x_val, y_test, y_val = train_test_split(x_test, y_test, stratify=y_test, test_size=0.5, random_state=42)

/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/sklearn/model_selection/_split.py in train_test_split(test_size, train_size, random_state, shuffle, stratify, *arrays)
   2441         cv = CVClass(test_size=n_test, train_size=n_train, random_state=random_state)
   2442
-> 2443         train, test = next(cv.split(X=arrays[0], y=stratify))
   2444
   2445     return list(

/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/sklearn/model_selection/_split.py in split(self, X, y, groups)
   1598         """
   1599         X, y, groups = indexable(X, y, groups)
-> 1600         for train, test in self._iter_indices(X, y, groups):
   1601             yield train, test
   1602

/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/sklearn/model_selection/_split.py in _iter_indices(self, X, y, groups)
   1938         class_counts = np.bincount(y_indices)
   1939         if np.min(class_counts) < 2:
-> 1940             raise ValueError(
   1941                 "The least populated class in y has only 1"
   1942                 " member, which is too few. The minimum"

ValueError: The least populated class in y has only 1 member, which is too few. The minimum number of groups for any class cannot be less than 2.

x_train, x_test, y_train, y_test = scsplit(x, y, stratify=y, test_size=0.4, random_state=42)
# reset indexes
x_test.reset_index(drop = True, inplace = True)
y_test.reset_index(drop = True, inplace = True)
x_test, x_val, y_test, y_val = scsplit(x_test, y_test, stratify=y_test, test_size=0.5, random_state=42)

error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/tmp/ipykernel_24143/3064626340.py in <module>
      3 x_test.reset_index(drop = True, inplace = True)
      4 y_test.reset_index(drop = True, inplace = True)
----> 5 x_test, x_val, y_test, y_val = scsplit(x_test, y_test, stratify=y_test, test_size=0.5, random_state=42)

/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/verstack/stratified_continuous_split.py in scsplit(stratify, test_size, train_size, continuous, random_state, *args)
    166     y_binned = np.digitize(y, bins)
    167     # correct bins if necessary
--> 168     y_binned = combine_single_valued_bins(y_binned)
    169
    170     # split

/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/verstack/stratified_continuous_split.py in combine_single_valued_bins(y_binned)
     59     # split neighbors into groups for combining
     60     splits = int(len(neighbors)/2)
---> 61     neighbors = np.array_split(neighbors, splits)
     62     for group in neighbors:
     63         val_to_use = group[0]

<__array_function__ internals> in array_split(*args, **kwargs)

/SeaExp/mona/venv/dpcc/lib/python3.8/site-packages/numpy/lib/shape_base.py in array_split(ary, indices_or_sections, axis)
    776         Nsections = int(indices_or_sections)
    777         if Nsections <= 0:
--> 778             raise ValueError('number sections must be larger than 0.') from None
    779         Neach_section, extras = divmod(Ntotal, Nsections)
    780         section_sizes = ([0] +

ValueError: number sections must be larger than 0.

Verstack 3.2.3 version.
Same error here
*** ValueError: number sections must be larger than 0.
I believe the problem is caused by the line
174  y_binned = combine_single_valued_bins(y_binned)
in the stratified_continuous_split.py
When there are no single valued bins the combine_single_valued_bins function runs anyway and then you get the above error. By looking my bins I found that there is no single valued bin so I commented out this function and it worked fine.
Hope I helped.

Verstack 3.2.3 version.
Same error here
*** ValueError: number sections must be larger than 0.
I believe the problem is caused by the line
174 y_binned = combine_single_valued_bins(y_binned) in the stratified_continuous_split.py
When there are no single valued bins the combine_single_valued_bins function runs anyway and then you get the above error. By looking my bins I found that there is no single valued bin so I commented out this function and it worked fine.
Hope I helped.

Could you please provide a sample dataset and the code to reproduce this issue.


Add C3, S3 and Solo1 support + Build using PlatformIO

-ESP32-S3 build was flashed and tested with success.
-ESP32-C3 and ESP32-Solo1 are untested, but build ok.
Credits for PlatformIO support go to @lucaoliano.
Some changes where required because the bootloader address of the ESP32-S3 and C3 differs from the ESP32.
Closes #199
Closes #201
Closes #259
Leaves CMake support intact.
Artifacts from Github Actions can be used for release zip files and merged binaries in the ZIP files can be used for Webflash.
Could benefit from a release workflow to automate adding binaries to releases/webflash, but I'm no expert in Github Actions.
Also might be an idea to create a Docker build option using PlatformIO and add instructions for building using PlatformIO without Docker.

Hello, I have tried to flash a new M5Stamp ESP32 S3 (Chip: ESP32-S3FN8) with Nuki Hub 8.33 via Win10.
Could it be that the Nuki Hub doesn't work with it? After flashing and restarting the ESP, I can't find any WiFi, the LED is off and the chip remains cold, so it probably won't start?
The ESP32-S3 is found as
Bus 001 Device 014: ID 303a:1001 Espressif USB JTAG/serial debug unit
in the Linux terminal.
and my VM with Win10 detects the ESP as:
Espressif USB JTAG/serial debug unit [0101]
Windows console shows after flashing:
test offset :  4096 0x1000
case ok
test offset :  32768 0x8000
case ok
test offset :  57344 0xe000
case ok
test offset :  65536 0x10000
case ok

Uploading stub...
Running stub...
Stub running...
Changing baud rate to 115200
Changed.
NO XMC flash  detected!
SPI_BOOT_CRYPT_CNT 0
SECURE_BOOT_EN False
Compressed 18560 bytes to 12759...
Compressed 3072 bytes to 129...
Compressed 8192 bytes to 47...
Compressed 1739312 bytes to 1097401...

 is stub and send flash finish

If I understand correctly, the chip is not yet supported with Nuki Hub 8.33?

You need to use a pre release version of 8.34 right now as support will be added in 8.34.
The latest pre release for S3 can be found in PR #332 and is also available through webflash at https://technyon.github.io/nuki_hub/

Fine, that's the way it works :-)

PS: But not via webflash and Chrome Browser. Error message:
Failed to initialize. Try resetting your device or holding the BOOT button while clicking INSTALL
(btw. this item has no boot button)
Manny Thanks!

Good to hear you've got it working.
According to the docs you linked:
If you want to enter download mode, press and hold the G0 button on StampS3 before turning it on, then release it after powering it on.
If you follow this procedure webflash should work, although I haven't tested it on my own S3 yet.
Please note that the 8.34 pre release might include bugs related and unrelated to the S3

Yes, of course. I have only tested my ESP32-S3 briefly, as soon as 8.34 is officially released I will test it longer with my Nuki. For the G0 button, I would have to solder a pin on this device, which was not necessary due to the Flash Tool.
Thanks again for your great work!


Check root folder ACLs

A common pattern I recognized is admins placing applications in directories created in drive roots, e.g.:
C:\Install
C:\ORACLE
C:\SuperAccounting

Some installers also do this by default.
Since these folders inherit AddDirectory and AddFile permissions for the BUILTIN\Users group, any local user can place malicious DLL's inside these directories to hijack processes executed by other users of the same machine (think terminal servers):
C:\ORACLE
\__bin
    \__sqlplus.exe
    \__version.dll (totally legit *wink* *wink*)

For now, a new check only enumerates modifiable folders in root directories, and doesn't check whether there are any executables inside (this seems to be problematic elsewhere too). It also doesn't care if subdirectory ACL's are customized. Since there are other venues for attack (e.g. add a script to a conf.d-like folder) I'd rather just highlight the potential problem and let the tester assess the actual risk depending on the environment.
I only use PowerShell when I really have to, so the code is mostly frankensteined from other places. Also I don't expect this to be merged right away (not sure about base risk, are descriptions good enough, ...), any feedback is welcome!

I totally get your point, but...

There is already a check for misconfigured DACLs on program folders - Invoke-ModifiableProgramsCheck - the one you pointed out.
There is also a check for misconfigured DACLs on PATH folders, which often reveals this kind of bad practice because, most of the time, they were created at the root.
Checking root folder seems a bit too arbitrary. I mean, although it's a common place for misconfiguration. if I add this kind of check, I might have to consider other locations as well.
Overall, the philosophy is to limit manual analysis. I want the reports to be as accurate as possible.

So, I'm not entirely sure about this change. I will have to think a bit more about it. :thinking:

Thanks for considering this! Some notes:

Checking root folder seems a bit too arbitrary. I mean, although it's a common place for misconfiguration. if I add this kind of check, I might have to consider other locations as well.

I can hardly remember any case when I encountered similar misconfigs elsewhere, while installations in the drive root seem pretty common. Considering the standard top-level directory strucure in a fresh installation:

PerfLogs - I doubt anyone would install anything here
Program Files / Program Files (x86) - Strong default ACL, the preferred locations for system-wide installations
Users - User folders are accessible by their owner only (no cross-user contamination), Public may be interesting though
Windows - Strong default ACL

it seems to me that there are not many cases where one would install things. There are of course countless possible configurations and we can't cover everything (full recursive ACL checks would be overkill IMO).

Overall, the philosophy is to limit manual analysis. I want the reports to be as accurate as possible.

I created this patch because I had to go through a few dozen servers by hand (no network access) to collect this information, and it would've been nice if PrivescCheck did the work for me in a single run :)
Would it make a difference if we improved on executable detection too, so both Invoke-ModifiableProgramsCheck and this one would get more accurate?

Implemented with commit 7a747b362f4cb771933238ea94fc6b2f831dea5a
For testing:
powershell -ep bypass ". .\PrivescCheck.ps1; (Invoke-RootFolderPermissionCheck).Result"

Thank you, your implementation seems more complete than mine, so I'll close this PR.


Support nested folders

I have my MSUs several layers deep in some places--would it be possible to support traversing nested folders when finding MSUs? (like I have folders with categories of MSUs and stuff)

@Alaszun This is now available in the latest release: https://github.com/MattEqualsCoder/MSURandomizer/releases/tag/v0.9.5


C-22 Adding logs to basic module operations

This PR should be reviewed after the other current  (#18) is done because some things might be changed
This PR correlates to ticket C2-22 which deals with adding/changing logging messages in the basic module operations files.
Changes

Changed a lot of the error or information messages that were being printed in the module operation files (users.go, schedules.go, classrooms.go, courses.go) to use our new logger.
Updated the http response messages to only return plain English instead of the error given. The logger contains both the plain English and the error message. This was done because I don't think the other side should be receiving the actual error in case some sensitive information is provided with it. If they are a developer that needs the actual error they should be able to check the logs anyway.
Added some uniqueness checks in the create functions of users and classrooms to make sure they are not creating something that is already in the database collection
Added some existence checks in the update and delete functions of users, schedules, and classrooms to make sure they are not providing a message saying they updated or deleted something that never existed in the database.

Notes

Those last two changes correlate to ticket C2-39 which is in the backlog, they were implemented now because of testing reasons and they were easy enough. The rest of that ticket will be done in sprint 3.

Everything looks good


Questions about the results of Mask2Former

Hi, thank you for your open source. I would like to ask you how to use Mask2Former to obtain fine-grained semantic segmentation results, such as each zebra crossing and each dotted line. I cannot get these fine-grained segmentation results using  Mask2Former. Thanks very much.

@runnerhdh Have you read this script here? We all use this model and configs to parse semantic labels.

Thank you for your reply!
Yes, i used the same configuration file and pre-trained model. Did you directly use the model to infer the following results (zebra crossing and dotted line pointed by the red arrow)?

My reasoning results are as follows: (original picture on the top, inference result on the bottom), the zebra crossing and dotted line are not separated according to instance.

@runnerhdh I'm sorry that we use trained semantic model in our company which can not be released and you can search for other open source semantic models.

ok, thanks~


soapy: Fix RX stream activation by avoiding unintended runtime error.

The change introduced with 1c0ad68#r38372515 causes requests for RX streams
to fail with an "incorrect stream" runtime error. This commit resolves
issue #27.

https://github.com/xtrx-sdr/libxtrx/issues/28


MAC

NO

Almost done, testing now.

The MacOS build is now available, but there are extra steps needed to run it.

Go to https://github.com/awdev1/Vector24/actions.
Press the latest one that says "Auto Compile on Commit (macOS)" on the bottom.
Scroll down and press "final-zip-package".
Once downloaded, unzip the files.
Right-click the folder, head to "Services" -> "New Terminal at Folder".
Type in "sh ./start.sh" (which will run the script which starts Vector24).

The MacOS build is now available, but there are extra steps needed to run it.

Go to https://github.com/awdev1/Vector24/actions.
Press the latest one that says "Auto Compile on Commit (macOS)" on the bottom.
Scroll down and press "final-zip-package".
Once downloaded, unzip the files.
Right-click the folder, head to "Services" -> "New Terminal at Folder".
Type in "sh ./start.sh" (which will run the script which starts Vector24).

@JoseMoranUrena523 Hi Jose, can we compile that zip file as a release? It would probably be easier. Thanks.


Updated getting-started.rst

updated guide to install docker-compose and restructured the readme for better understanding.

@mileswwatkins review these changes and merge the PR.

Thanks for the tweak, @tabshaikh! One note: Docker for Mac, and potentially other Docker binary installs, already include Docker Compose, Kitematic, etc. Can you change your "Step 1b" to state that Docker Compose is probably already installed by "Step 1a"?

Okay I will make the necessary changes

@mileswwatkins a note has been added telling the new contributor that if the docker compose is not installed in step 1(a) then only proceed to step 1(b).


[REQ] webhooks

hey jr,
i wonder will it be hard for you , to implement function for deleting webhooks, based on their stream id, and their actual id? not sure, but this might be intended. personally want to clear the db, of hooks attached to dead places/forgotten channels. just because i'm now over 1k users (not all active, but registered) and i don't want to delete users anymore, just because of their dead hooks.
ty in advance

I've been considering discontinuing this project for some time now. I'm sorry I couldn't solve your issue, but I just don't enjoy working on multistreamer anymore.

I've been considering discontinuing this project for some time now. I'm sorry I couldn't solve your issue, but I just don't enjoy working on multistreamer anymore.


feat: add check and delete existing asset before upload

feat: add check and delete existing asset before upload

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.86%. Comparing base (923f9f3) to head (aaf7a88).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   80.93%   80.86%   -0.08%
==========================================
  Files          49       49
  Lines        4185     4185
==========================================
- Hits         3387     3384       -3
- Misses        656      659       +3
  Partials      142      142

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Returns False if username starts with non-alphabet
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Good and simple exercise! I liked it.


[bug] crc delete from tray menu throws unhandled expection

Tested on pre release bits for version 1.30.0 a regression failure was found
After start the cluster from the tray when trying to delete with the tray delete button it will show an unhandled exception:

Full error stack:
************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at CRCTray.CRCTray.DeleteReceived(DeleteResult result)
   at CRCTray.Helpers.DeleteReceivedHandler.Invoke(DeleteResult result)
   at CRCTray.Helpers.TaskHandlers.Delete()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at CRCTray.Helpers.TaskHelpers.<TryTaskAndNotify>d__0`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at CRCTray.CRCTray.<DeleteMenu_Click>d__27.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<>c.<ThrowAsync>b__6_0(Object state)

************** Loaded Assemblies **************
mscorlib
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll
----------------------------------------
crc-tray
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
System.Windows.Forms
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4360.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
System.Configuration
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4190.0 built by: NET48REL1LAST_B
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
System.Core
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4390.0 built by: NET48REL1LAST_C
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Core.dll
----------------------------------------
System.Xml
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4084.0 built by: NET48REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_<IP_ADDRESS>__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Text.Json
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
System.Net.Http
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4084.0 built by: NET48REL1
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.Net.Http/v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a/System.Net.Http.dll
----------------------------------------
HttpOverStream.NamedPipe
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
HttpOverStream
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
System.Threading.Tasks.Extensions
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
netstandard
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4084.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/netstandard/v4.0_<IP_ADDRESS>__cc7b13ffcd2ddd51/netstandard.dll
----------------------------------------
HttpOverStream.Client
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
System.ValueTuple
    Assembly Version: <IP_ADDRESS>
    Win32 Version: 4.8.4084.0
    CodeBase: file:///C:/WINDOWS/Microsoft.Net/assembly/GAC_MSIL/System.ValueTuple/v4.0_<IP_ADDRESS>__cc7b13ffcd2ddd51/System.ValueTuple.dll
----------------------------------------
System.Runtime.CompilerServices.Unsafe
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
System.Memory
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
System.Buffers
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
System.Text.Encodings.Web
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------
System.Numerics.Vectors
    Assembly Version: <IP_ADDRESS>
    Win32 Version: <IP_ADDRESS>
    CodeBase: file:///C:/Program%20Files/CodeReady%20Containers/crc-tray.exe
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

   at CRCTray.CRCTray.DeleteReceived(DeleteResult result)
   at CRCTray.Helpers.DeleteReceivedHandler.Invoke(DeleteResult result)

https://github.com/code-ready/tray-windows/blob/b43587eaaf3b5ce1e47d90359d92c1964a837f6f/Helpers/Handlers.cs#L65-L73
That is weird, as there is a null-check ... need more info to understand this.


[Feature Request] share-button / share-function

A share button would be nice. At the moment I don't really care about the format, a text-format would be ok. A better and more practically format would also be nice.

We've just recently released sharing for individual tasks (#172, released in version 1.1.10). Is that what you mean?

Oh, this sounds very good. I wasn't searching the iusse-list for "sharing" only for "share" (now it seems obvious...).
I am on version 1.1.9 (because this seems to be the newest version on F-Droid) therefore I have to wait to check the new feature. But indeed it seems to be the all I want.
Thanks a lot!

Great! I'll close this. Please open a new issue if something is missing in 1.1.10.


Text Node Transformations (Scale / Rotation)

Support for scale and rotation transformations on text nodes.

I've split out the parent alpha feature into #79. Any other text rendering feature requests, such as blur, need to be more specifically created.


Sc-4171 : ProfilePage Component

Codecov Report

Merging #419 (d622c81) into main (a81b930) will decrease coverage by 9.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #419      +/-   ##
==========================================
- Coverage   46.90%   37.68%   -9.22%
==========================================
  Files         231      151      -80
  Lines       11532     2367    -9165
  Branches      606      606
==========================================
- Hits         5409      892    -4517
+ Misses       5167     1302    -3865
+ Partials      956      173     -783

Impacted Files
Coverage Δ

directory/pkg/trtl/replica/prob.go

directory/pkg/trtl/jitter/jitter.go

directory/pkg/gds/models/v1/models.go

directory/pkg/gds/admin/v2/decode.go

directory/pkg/gds/backup.go

directory/pkg/trtl/config/replica.go

directory/pkg/trtl/replica/replica.go

directory/pkg/sectigo/serializers.go

directory/pkg/trtl/trtl.go

directory/pkg/bff/gds.go

... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81b930...d622c81. Read the comment docs.


Create tasks using JSON, to Integrate todoman in other systems.

Hello! Really liking the application. I was reading the documentation an saw a section about integration using the flag --porcelain which returns a JSON for the tasks. But It's only one way, one cannot create/update tasks by sending JSON to todoman. Would be a great feature to have.
I was looking to write a vim plugin, to interact with todoman.
Proposal
Something like:
todo --porcelain --input
[
    {
        # Since this task has an id, update/modify it.
        "completed": false,
        "due":<PHONE_NUMBER>,
        "id": 3,
        "list": "personal",
        "location": "",
        "percent": 0,
        "priority": 0,
        "summary": "Integrate with neovim"
    },
    {
        # Since this task has no id, create it.
        "completed": false,
        "due":<PHONE_NUMBER>,
        "list": "personal",
        "location": "",
        "percent": 0,
        "priority": 0,
        "summary": "Evaluate todoman for daily use"
    }
]

This way todoman becomes very extensible and easy to integrate.

Seems like that would be quite useful. Lemme think about how to get it through a bit more.

This would be so very useful!

@WhyNotHugo any updates? This would be really cool!

I haven't looked into it further.
We probably need to update todoman.cli.new to have the --json flag. When it's passed, need to skip running interactive, and parse stdin.
The problem is that the PorcelainFormatter can parse dates and priorities, but not an entire todo as a JSON string -- that needs to be implemented entirely (and is likely the best starting point, given it can be easily unit-tested).

Hi, I am interested in implementing a solution for this issue, maybe together with #240.
However, I would like to propose a small change, to not allow the implicit distinction between tasks to be created and tasks to be edited purely on whether the input JSON has a valid id field but to split up the functionality into todo --porcelain new --read-json and todo --porcelain edit --read-json.
This leaves it up to the user to manage existing tasks and create new ones. I believe that is a more robust strategy, and can still be used for building software based on todoman.

@skowalak What you say makes sense. We already have separate todo new and todo edit commands, so this aligns perfectly with the current design.

Are there still any efforts on-going with here? I found https://github.com/pimutils/todoman/pull/518 but it appears stagnant. In light of https://github.com/GothenburgBitFactory/taskwarrior/issues/2418 it would be great to be able to have JSON input/output support for todoman, to be able to write an intermediate layer that could provide a fake taskwarrior CLI interface, so that one could use tools like https://github.com/kdheepak/taskwarrior-tui with todoman.

Hi Marius, I am currently not working on #518 anymore. I am sorry for not marking it as stale earlier.


2968 localhost -> local.webaverse.com on startup

Updated docs and README.md to reflect the new instructions.
This does not resolve the forever loading avatar picture issue. I tracked that down to a separate problem and will open a PR once I'm sure I understand the problem and have a fix.

This does not resolve the forever loading avatar picture issue. I tracked that down to a separate problem and will open a PR once I'm sure I understand the problem and have a fix.

Awesome, thanks!


prepare for publication

Description
Test using:
USE FILE FROM COMMENT BELOW
Preparation for publication on Marketplace

It's called "Visual Studio Code" or "VS Code" for short – this should be in all places (not e.g "VSCode").

Fixes 1 and 2:
vaadin-vscode-1.0.0.vsix.zip


Add Metrics APIs as per "metrics.proto"

Add Metrics package and below classes based on metrics.proto. Although Metrics proto is still being finalized, We think it is safe to start working on value classes like LabelKey, TimeSeries, Point etc.

[x] Metrics: Add LabelKey and LabelValue.
[x] Metrics: Add Value and Point.
[x] Metrics: Add TimeSeries.
[x] Metrics: Add MetricDescriptor.
[x] Metrics: Add Metric.
[x] Metrics: Add Summary and Distribution.
[x] Metrics: Produce and store Metrics in Stats impl.(#1078)

Counterpart classes available in Java for reference : https://github.com/census-instrumentation/opencensus-java/tree/master/api/src/main/java/io/opencensus/metrics

/cc @ramonza

At the moment, I am leaning towards relying directly on the protobuf generated classes rather than re-implementing them unless anyone has objections.

@ramonza we should not add a protobuf dependency on the core library (that was our decision).

Will this include Go specific metrics like gc_pause time distributions?

Yes we can have that as a "contrib" package.

all tasks are complete.


🐞 - Build library command not targetting @codeimage/config

Which @codeimage/* package(s) are the source of the bug?
codeimage
Please provide a screenshot or a video to a minimal reproduction of the bug
No response
Description
When using pnpm libs:build command the package @codeimage/config is not targetted.
Which browsers have you used?

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

@codeimage/config need to be removed.


Add historyPlugin

This plugin exports an undo and redo button that allow you to add undo/redo functionality to the editor.
Ref #17

@mxstbr sooo good, thx dude!

one little UX improvement might be this: https://github.com/nikgraf/draft-js-plugin-editor/issues/47


Solarian Weapon Expertise and Twin Weapons

Currently, Solarian Weapon Expertise only gives critical specialization to the main solarian weapon, not to the secondary weapon created with Twin Weapons.

Seems to actually be related to a system bug preventing strike options from being passed. We'll look into that.


[Snyk] Security upgrade @angular/core from 8.2.14 to 11.0.5

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

packages/admin-frontend/package.json
packages/admin-frontend/package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

481/1000  Why? Recently disclosed, Has a fix available, CVSS 3.9
Cross-site Scripting (XSS) SNYK-JS-ANGULARCORE-1070902
Yes
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Expose internal connection type in some way

Thank you for such a neat generic library. I've tried to use it and, unfortunately, many other convenience related packages like Cornucopia or Refinery require a direct connection, let's say tokio_postgres::Client in my particular case. Is there a way to neatly expose the internal connection without monkey patching?
Example:
let p_conn = db_pool.get().await.unwrap();
let client = p_conn.conn.unwrap(); // here is the private field access

let something: WhateverStruct = do_that()
    .bind(&client) // should work fine now
    .one()
    .await
    .unwrap();

What do you mean by "require a direct connection"? PooledConnection<impl ManageConnection> impls Deref<Target = M::Connection which should be sufficient for most uses. For some other cases, there's also Pool::dedicated_connection().
(Your code sample isn't that helpful to me because it doesn't show me what types Cornucopia or Refinery need.)

@djc
Missed the DerefMut, that will do, perfect! Thank you, sorry for the inconvenience.


AntiAim

how can i see my antiaim?

reinterpret_cast<Vector>(reinterpret_cast<uintptr_t>(localPlayer.get()) + 0x31D8) = sent;

emmm, im not really experinced what i must do this?

bot_mimic 1

made a pull, close this #1546

Thanks!


Fail to resubmit job when job parameters change

Hi, I am getting errors in the operator pod when trying to upgrade a job with different parameters
Observed job submitter	{"cluster": <cluster name>, "state": "nil"}
Observed job submitter pod list	{"cluster":  <cluster name>, "state": {"metadata":{},"items":[]}}
Failed to extract job submit result	{"cluster": "<cluster name>", "error": "job pod found, but no termination log found even though submission completed"}
github.com/spotify/flink-on-k8s-operator/controllers.(*ClusterStateObserver).observe
	/workspace/controllers/flinkcluster_observer.go:206
github.com/spotify/flink-on-k8s-operator/controllers.(*FlinkClusterHandler).reconcile
	/workspace/controllers/flinkcluster_controller.go:137
github.com/spotify/flink-on-k8s-operator/controllers.(*FlinkClusterReconciler).Reconcile
	/workspace/controllers/flinkcluster_controller.go:81
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.3/pkg/internal/controller/controller.go:298
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.3/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
	/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.9.3/pkg/internal/controller/controller.go:214

I have observed whenever I try upgrading a job cluster with flinkProperties or job volume mount changes.
The previous submitter pods are terminated and no new submitter pods are spun up. The previous running job is also cancelled with no new job replacing it.
Would appreciate some pointers on resolving this issue. Thanks!

Seems like this is a regression only happens in the latest release. Works fine in v0.1.12


Support different protocols in URL

Expected behavior
Opening chrome settings using URL: chrome://settings doesn't work
Actual behavior
Chromium settings should be opened
Steps to reproduce

Open browser openBrowser()
Go to chrome://settings goto("chrome://settings")

Versions
Node: v10.16.3
Taiko: Version: 1.0.2 (Chromium: 76.0.3803.0) RELEASE

I tried to work around the issue by pressing "Cmd," (press(["Meta", ","])) which is the keyboard shortcut to open settings but it didn't work.
Looking into the code I found that we are allowing only http, https, file protocols and implemented a fallback to http
https://github.com/getgauge/taiko/blob/ff5d956bcf99bfb5a77fdda02352cd50323a1293/lib/taiko.js#L767
My use case for opening chromium settings:
I am trying to automate the downloading of multiple files from a website. There are different types of files and I want them to be downloaded in different directories. So I want to change the download location from chromium settings.
Let me know if this makes sense. I can raise a PR to fix this issue.

@arunvelsriram IMO you should pass args to openBrowser API to set flags. Refer https://peter.sh/experiments/chromium-command-line-switches/

I searched those args already and I couldn't find any to change the download location.

It might be download.default_directory

https://taiko.gauge.org/#openbrowser
Args to openBrowser() is an array of string. How do I use it with openBrowser() API?

Perhaps this example can help the file download use case:
https://github.com/getgauge/taiko/blob/master/examples/02-file_download.js

@sriv Awesome. That's close to what am looking for. Thanks


ONLINE_MODE: "FALSE" environment variable ignored in docker-compose

Describe the problem
I have added ONLINE_MODE: "FALSE" to docker-compose.yml, trying to start the container in online_mode off. It seems that the option is ignored and it starts in online_mode=true anyway.
I have tried to create .env file:
ONLINE_MODE=FALSE

and started docker-compose as  docker-compose --env-file .env up, the result was the same... Server started in ONLINE_MODE=True. docker run -e ONLINE_MODE=FALSE works as expected.  Am I doing something wrong?
Thanks and have a nice day.
Pavol
Container definition
version: '3'
# Other docker-compose examples in /examples
services:
  minecraft:
    image: itzg/minecraft-server
    ports:
      - "25565:25565"
    volumes:
      - ./mc/:/data
    environment:
      EULA: "TRUE"
      ONLINE_MODE: "FALSE"
      EXEC_DIRECTLY: "TRUE"
      ENABLE_WHITELIST: "TRUE"
      ENFORCE_WHITELIST: "TRUE"
      ALLOW_FLIGHT: "TRUE"
    restart: always
    stdin_open: true
    tty: true
volumes:
  mc: {}

Container logs
Paste logs here

How do you know it's ignored? You didn't provide container logs, so all looks "fine" to me since there's nothing to see.
In any case, add OVERRIDE_SERVER_PROPERTIES: "true" to ensure the properties file is getting updated as you're probably intending.

I had the same problem, online_mode: "false" wasn't working in my docker compose after inspecting server-properties in the container (see img below)
however OVERRIDE_SERVER_PROPERTIES: "true" did fix the problem now


Add off-steam installations support

You can do something similar to what is done here: https://github.com/bloodypenguin/Skylines-DaylightClassic/blob/master/DaylightClassic/TranslationFramework/Util.cs
They don't do searching of steam specific paths.
It's great when you have multiple installations with different path setups

This won't be implemented. The mod binaries are published only on Steam Workshop, so a subscription is required.

But for instance if I have subscribed but I use several installations with several mod configurations. How about that?

This is your special case then. Take the sources code (it is free), change it as you like, build your own binaries.


parse-integer

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: parse-integer
Document link: parse-integer.md
My Issue/Suggestion
The Parse-integer functie didn't work in a Xpath for me.

Using the word 'casting' or 'type conversion' would be useful if you want experienced programmers to easily find the information they need and helps new programmers learning the right terms.

Hi @joepveenman,
Thank you for your feedback.
The parseInteger function is indeed not supported in XPath queries. For more information on what's supported in XPth quesries, please see XPath Constraints and XPath Aggregate Functions.
I've added words like "casting" and "type conversion" as tags for this Parse Integer doc. I hope this can help with the search results. Given that Mendix is a low-code platform, we tend to use words that non-coders/low-coders can also easily understand. However, still thanks for the feedback!
I am closing this issue now. Please let us know if you have any more feedback in the future.
Kind regards,
Yiyun


Add config option for AWS EBS root volume size

I wanted it to be a bit easier to have custom sizes for minion and master root EBS disks when using AWS.
Typically I have tiny images and attach persistent disks for all my pods, but I have a use case where I'd like to have plenty of scratch space on my nodes for "EmptyDir" style data.
This makes it easier! :dancer:
Thanks!

I signed it!

This change didn't worked as it is. I replaced BLOCK_DEVICE_MAPPINGS_BASE variable with actual string and voila it worked.
Thanks .

@galacto Hrm? Mind sharing? This change has worked for me for a number of clusters. Note that kube-down doesn't delete the persistent volumes on AWS, and will re-attach them on kube-up even if you've changed something here in the util.sh. You have to actually delete the disks manually from AWS. Not sure if this applies to GCE.

@erulabs GCE has different way of doing it refer this #3192
for aws I did like this:
in util.sh
MINION_BLOCK_DEVICE_MAPPINGS="[{"DeviceName": "/dev/sda1","Ebs":{"DeleteOnTermination":true,"VolumeSize":${MINION_DISK_SIZE}}},{"DeviceName": "/dev/sdc","VirtualName":"ephemeral0"},{"DeviceName": "/dev/sdd","VirtualName":"ephemeral1"},{"DeviceName": "/dev/sde","VirtualName":"ephemeral2"},{"DeviceName": "/dev/sdf","VirtualName":"ephemeral3"}]"
and in config-default.sh introduced this variable
MINION_DISK_SIZE=${MINION_DISK_SIZE:-100}
unfortunately I lost the error message I got when I did that but it was kind of incorrect parameters
one more thing to note is when I created EBS through console it did not work, I had to create it through aws cli.

@brendandburns dumping AWS changes to you, sorry for the noise, please redistribute as you can

This is still failing shippable after a few runs. I think you may need to rebase before it will pass.

Removing lgtm label until this is rebased. @brendandburns please re-add it once shippable is passing.

Rebase complete - test's ought to pass shortly :+1: Thanks guys!

LGTM, shippable is now passing.


Chore: finish blog

Finish the blog post I'd started a month ago and post it

Issue has been open too long


Delete useless

删除mosn中历史遗留的，一些没有使用的代码

commonrule，这个是最初实现的一个限流filter，已经有新的代替方案
Listener仅更新TLS的接口。这是一个当初以外会有用的接口，实际都没有用上。
RCU实现，这是最初更新cluster时的设计，后来更新了新的更新算法，不再使用这个

Codecov Report

Merging #1534 (584efab) into master (653c2f3) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1534      +/-   ##
==========================================
- Coverage   59.21%   59.06%   -0.16%
==========================================
  Files         339      329      -10
  Lines       27189    26911     -278
==========================================
- Hits        16101    15894     -207
+ Misses       9295     9238      -57
+ Partials     1793     1779      -14

Impacted Files
Coverage Δ

pkg/server/adapter.go
56.09% <ø> (-4.25%)
:arrow_down:

pkg/stream/xprotocol/connpool_multiplex.go
54.11% <0.00%> (-7.06%)
:arrow_down:

pkg/metrics/shm/zone.go
62.12% <0.00%> (-3.04%)
:arrow_down:

pkg/stream/xprotocol/conn.go
35.58% <0.00%> (-1.23%)
:arrow_down:

pkg/server/handler.go
38.64% <0.00%> (-0.44%)
:arrow_down:

pkg/module/http2/server.go
80.71% <0.00%> (+0.15%)
:arrow_up:

pkg/module/http2/transport.go
76.76% <0.00%> (+0.16%)
:arrow_up:

pkg/network/connection.go
42.27% <0.00%> (+1.06%)
:arrow_up:

pkg/upstream/cluster/strict_dns_cluster.go
69.93% <0.00%> (+1.39%)
:arrow_up:

pkg/mtls/sds/subscriber.go
78.35% <0.00%> (+2.98%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653c2f3...584efab. Read the comment docs.


Use the correct element name in  blocks, gloss it seperately

If you write "anchor element" instead of "a element", you should also write "hyperreference attribute", instead of "href attribute".
Suggestion: write "a (anchor) element", or "anchor (a) element", to communicate the element name explicitly and gloss it at the same time.
The  sections should be valid code as far as possible.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@jean The typical reason anchor element is used is to avoid having to write something like "Create an a element...", which at first looks like incorrect grammar (a and an are both articles).  That could be confusing to a reader.  Nobody uses "hyperreference attribute", because "http attribute" can not be confused with another word.  That being said, if others think this is a useful change, then don't let my opinion prevent the change.  Just keep in mind there are many challenges where the anchor is referenced.  Should they all be changed to a?
Note: This really should have been brought up in an issue first, so we could discuss the broad ranging implications of the change, instead of discussing it on pull request for a single challenge.

"Create an a element...", which at first looks like incorrect grammar (a and an are both articles)

The incorrect grammar is the cue that this is not the correct reading; i.e. it's self-correcting. Even if the reader goes with the wrong reading at first, the sentence is meaningless (what element? any element?), again prompting re-reading.
It would be "Create an a element...", i.e. the a would be clearly marked up as code.

Nobody uses "hyperreference attribute", because "httphref attribute" can not be confused with another word.

I don't think anchor is being used to distinguish it from the article a. I think it's being used to clarify that the a tag signifies an anchor. I.e. it's a gloss that abuses code markup.

Just keep in mind there are many challenges where the anchor is referenced. Should they all be changed to a?

I would certainly argue so. If others are in agreement, I'm prepared to add those changes to this PR.

This really should have been brought up in an issue first, so we could discuss the broad ranging implications of the change,

Ah, sorry, I opened the PR as a starting point for discussion tied to a concrete example of the proposed change. I tend to think of PRs as issues with code attached, but you're right, github's UI segregates them.
Thanks for considering my proposal :-)

@thecodingaviator just curious, do you know why the .md challenge files would use html instead of _markdown_?

@jean I’m not sure why that happens but afaik, the markdown syntax does not work in the /curriculum files the same way it does in the /guide files

I think this change isn't required. anchor is used interchangeably with a element in many places, including MDN.
Additionally -

Create an a element

Non native english speakers might find this hard to understand at first glance. Unless the existing instructions are incorrect, we should try to keep things as simple as possible.
Thanks for creating the PR, btw!

anchor is used interchangeably with a element in many places, including MDN.

On the contrary --- the MDN example illustrates exactly what I am advocating: the  element is marked up using , and the gloss gets :
The HTML <a> element (or anchor element) creates a hyperlink [...]

Anchor is nowhere marked up as code. Regarding the readability argument, I see MDN does have an example of that usage:

A skip link, also known as skipnav, is an a element

I disagree that in the context of HTML documentation it is confusing, due to the explicit code markup. It's certainly less confusing than "A skip link, also known as skipnav, is an anchor element (but remember to write a, not anchor)". Marking up anchor as code is simply never correct.

We'll need more discussion on this issue

This looks like a reasonable change to me.  I agree with @jean that we shouldn't be implying that anchor is a valid html tag.
As far as legibility goes, if we reckon

Create an a element

could be confusing, we could go with

Create an  element

Cool :-) I'll look for other occurrences of anchor and push to this PR.
On Wed, 20 Mar 2019, 20:09 Tom<EMAIL_ADDRESS>wrote:

@moT01 approved this pull request.
Thanks for the PR @jean https://github.com/jean! try a more descriptive
branch name in the future. This LGTM, I don't think the a needs to be
wrapped in <> - I don't see elements wrapped with those in any of the
other challenges (that I checked), so I think it should stay like this for
consistency. This should make it clear enough for campers.
For reference - a picture of what this looks like deployed:
[image: Screen Shot 2019-03-20 at 8 00 14 AM]
https://user-images.githubusercontent.com/20648924/54686003-3a25cc80-4ae6-11e9-8e9a-a3f328f1c7ab.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/pull/35616#pullrequestreview-216704468,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFLQJhZM8RcLPzHvirGQ5Dv7eD79zG2ks5vYjL7gaJpZM4b320X
.

@moT01 This looks good to me, I'm waiting for a go ahead from @jean when they're done with the other occurrences

@thecodingaviator I think I got them all.
I noticed there are some discrepancies in markup, e.g. sometimes "anchor text" is marked up as code, and sometimes it isn't, and often "anchor tag" is used without any markup. I think these are minor style issues, so I'm leaving them alone.

The change you have made at https://github.com/freeCodeCamp/freeCodeCamp/pull/35616/files#diff-b17a1aeb668293733b6e42c313bd9fe4R20 has not been made in any of the other languages as far as I see. Please check

PR's are supposed to stick to one language, so I think this should stick to english - the word "anchor" would not translate to "anchor" in other languages. Not sure if we want it translated or not, but I have no idea how it reads in the other languages. If you want to leave it and see if someone else approves it like this, that's fine - but I can't approve it anymore.

@jean Split this PR into different for each language, without that you're violating this point you checked:

@thecodingaviator oh, sorry, yes I'll split languages!
Re: this change, yes, I was starting to change anchor text to anchor text, because it signifies descriptive text, not markup. But then I wavered, thinking that (in some cases, not everywhere) it also signifies something that the user is editing as part of the page they're writing, i.e. it will be part of their code. I didn't change it back, because I noticed that "anchor text" is not consistently marked up as code .. e.g. here, here, here, and other places it isn't marked up at all. It would make sense to think this through and make it consistent, but not in this PR. I wouldn't mind changing this occurrence back to anchor text.
@moT01

the word "anchor" would not translate to "anchor" in other languages

Well, it's an English word included in the other languages, to show that the a tag comes from the English word "anchor". It may well be translated elsewhere in the text, but I do think that changing e.g. anchor to a (anchor) in all languages is fine. What do others think here?

"anchor" only didn't get translated to other languages where it was wrapped in the code tags. The code tag is supposed to represent code which can only be done exactly one way so it doesn't get translated. But anchor should be translated since it is not code, take a look at this challenge - the word "anchor" is in the description several times with and without the code tags.
Here's the spanish translation of that file
Anywhere the code tags weren't used, it got translated.
This is what I think anyway

@jean , I'm getting 5 occurrences:

Check which one this PR is missing, I see only 4 files

@moT01

"anchor" only didn't get translated to other languages where it was wrapped in the code tags. The code tag is supposed to represent code which can only be done exactly one way so it doesn't get translated.

Correct, but this is an interesting case. The original anchor tried to do two things at the same time: 1. represent the code, 2. explain that the arbitrary a symbol actually comes from and is pronounced as the English word anchor. Including the English word at that point is the most obvious way to communicate this. This is quite separate from any other translations of anchor in the text. If you want to discard the gloss, then anchor can go. But I don't really see how that improves things.
@thecodingaviator in add-document-elements-with-d3.english.md#L12 anchor refers to a javascript variable named anchor, not to an anchor tag.

@moT01

The stuff in quotes did get translated and that would make it tough to pass the test

Yeah,
l nuevo párrafo debe tener un texto que diga "Ver más fotos de gatos", vs
"Your a element should have the anchor text of "cat photos""
right?
That should be a new issue though.

@moT01 awesome, thank you very much :grinning:


New optcodes por 6.38

Hi. Since 6.38, program runs w/o warnings nor errors, but it is just not working, I can't double weave anymore.
Does it need an optcode update or something?

Ya it happen the same to me , the virtual machine works fine as usual but this aparently didnt recognize the actions, we just need to weit for an update?

You need to wait for the official opcodes from https://github.com/Soreepeong/XivAlexander/tree/main/StaticData/OpcodeDefinition to update.


Proposal: Expand UI to Display Detailed Information About Token Providers

Description:
Currently, Fortify Tools displays only the token name in the list of available providers. I propose expanding the UI to include more detailed information about the token provider. This enhancement would allow users to access more information about the tokens they are using and would also provide a way to include additional token-related functionality, such as the option to refresh the session.
Current Implementation:
The current implementation represents such information objects as ProviderInfoProto and TokenInfoProto. You can refer to the relevant code in the following link: ProviderInfoProto and TokenInfoProto.
Benefits:

Enhanced User Experience: Users would have access to more comprehensive information about their tokens, helping them make better-informed decisions.
Improved Functionality: By including more details in the UI, we can introduce additional features, such as session management directly from the token information interface.

Example:
As an example, the SafeNET application provides a similar feature where it displays detailed information about token providers. Below is a screenshot demonstrating how SafeNET presents this information. This could serve as a model for implementing similar functionality in Fortify Tools.
Screenshot:

This could help with support, especially with unsupported tokens.


Generate predictable header ids for duplicate headers

Instead of:

https://docs.rubocop.org/rubocop/1.66/cops_bundler.html#examples
https://docs.rubocop.org/rubocop/1.66/cops_bundler.html#examples-2
https://docs.rubocop.org/rubocop/1.66/cops_bundler.html#examples-3

Do this:

https://docs.rubocop.org/rubocop/1.66/cops_bundler.html#examples-bundlerduplicatedgem
https://docs.rubocop.org/rubocop/1.66/cops_bundler.html#examples-bundlerduplicatedgroup
https://docs.rubocop.org/rubocop/1.66/cops_bundler.html#examples-bundlergemcomment

Links like this will continue to work when new cops are added. Anchors to cops themselves are kept as is, since these already consistently work between versions.
Right now, adding a new cop potentially shifts these numbers around which causes links like that to go to a different place than expected when linking to non-versioned doc links like https://docs.rubocop.org/rubocop/cops_style.html#safety-54

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

https://docs.rubocop.org/rubocop/1.66/cops_bundler.html#examples-bundlerduplicatedgem

In the future we might consider adding some dash between the department and the cop name (for better readability), but that's a minor thingy.

That would need more careful consideration. For example, the docs urls produced by rubocop are currently unversioned (and I think that's good), the anchors would then break for all previous versions. I'm not sure if you can have two anchors to the same place (you probably can).
If it does get changed, the best time is now, at least for the newly added anchors so that they don't have compatibility concerns like that.
Let me know if I should tweak the new anchors like that and I'll put up a PR.


2's complement 24->32 bits conversion

I borrowed your implementation of conv24bitsToInt (referenced your name/work)
However I think:
if (unpacked[0] >= 127):
Should be replaced by
if (unpacked[0] > 127):
has 127 is written 0111 1111, sign bit is off.

Wow, nice catch! Thanks for the fix, it's committed now :)

No problem


feat: support pytorch dataformat

Implement to_pytortch() for modeling in pytorch

Ibis supports to_torch (nothing particularly efficient, because PyTorch doesn't natively support Arrow), and IbisML currently has a naive integration with skorch.


Programs compile if commands are declared but not defined

This compiles, then complains about invalid program code:
declare foo
say foo 1

More than just that... any of these partial labels can be left dangling around:
def test
    goto foo
end
test

def test
    declare test2
    test2
end
test

do
    declare test
    test
end

etc

This is exposing some more weird behavior:
for: range 2
    test:
    say 'hi'
end
goto test

Technically valid, but feels like it shouldn't be, and causes an infinite loop

Okay, so rewinding this discussion a bit...
I'm talking about two broad issues:

Incomplete labels can currently exist, and cause weird issues -- this needs to be fixed
Goto over variable boundaries can happen -- this I'm just accepting as an acceptable cost for using goto in the first place, user beware

https://github.com/voidqk/sink/commit/b3c2d26c203dceafc7d1009d24b7925870dafe48 fixes


Insecure private repositories fail installation

[x] I am on the latest Poetry version.
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: macOS 10.14
Poetry version: 0.12.0

Issue
Trying to install a dependency from an HTTP (rather than HTTPS) private repo causes install to fail complaining about missing authentication-related parameters. I have not specified because there is no authentication necessary. This was not an issue in 0.11.x, which did not demand authentication.
[tool.poetry]
name = "foo"
version = "0.1.0"
description = ""
authors = ["foo<EMAIL_ADDRESS>license = ""

[[tool.poetry.source]]
name = "pypicloud"
url = "http://<hostname>/simple/"

[tool.poetry.dependencies]
python = "^3.6"
my-private-package = "^x.y.z"

with -vvv:
> poetry install -vvv
Using virtualenv: /Users/seankelley/Library/Caches/pypoetry/virtualenvs/foo-py3.6
Installing dependencies from lock file

Package operations: 7 installs, 0 updates, 0 removals

  - Installing markupsafe (1.0)
    Installing from unsecure host: <hostname>
[TypeError]
get_http_basic_auth() missing 1 required positional argument: 'repository_name'

Exception trace:
 /Users/seankelley/.poetry/lib/poetry/_vendor/py3.6/cleo/application.py in run() at line 94
   status_code = self.do_run(input_, output_)
 /Users/seankelley/.poetry/lib/poetry/console/application.py in do_run() at line 88
   return super(Application, self).do_run(i, o)
 /Users/seankelley/.poetry/lib/poetry/_vendor/py3.6/cleo/application.py in do_run() at line 197
   status_code = command.run(input_, output_)
 /Users/seankelley/.poetry/lib/poetry/console/commands/command.py in run() at line 77
   return super(BaseCommand, self).run(i, o)
 /Users/seankelley/.poetry/lib/poetry/_vendor/py3.6/cleo/commands/base_command.py in run() at line 146
   status_code = self.execute(input_, output_)
 /Users/seankelley/.poetry/lib/poetry/_vendor/py3.6/cleo/commands/command.py in execute() at line 107
   return self.handle()
 /Users/seankelley/.poetry/lib/poetry/console/commands/install.py in handle() at line 56
   return_code = installer.run()
 /Users/seankelley/.poetry/lib/poetry/installation/installer.py in run() at line 76
   self._do_install(local_repo)
 /Users/seankelley/.poetry/lib/poetry/installation/installer.py in _do_install() at line 286
   self._execute(op)
 /Users/seankelley/.poetry/lib/poetry/installation/installer.py in _execute() at line 294
   getattr(self, "_execute_{}".format(method))(operation)
 /Users/seankelley/.poetry/lib/poetry/installation/installer.py in _execute_install() at line 319
   self._installer.install(operation.package)
 /Users/seankelley/.poetry/lib/poetry/installation/pip_installer.py in install() at line 48
   auth = get_http_basic_auth(package.source_reference)

install [--no-dev] [--dry-run] [-E|--extras EXTRAS] [--develop DEVELOP]

I tried to use a workaround by doing something like putting in fake username/passwords to see if that would bypass the problematic code, but the docs on this at https://poetry.eustace.io/docs/repositories/ are a little thin and it's not clear to me how to configure my pyproject.toml to use authentication for a private repo. The docs say:

If your private repository requires HTTP Basic Auth be sure to add the username and password to your http-basic config using the example above

I can't find where the poetry config command listed in those docs makes changes, so I can't even try to mimic those changes in pyproject.toml.

Sorry about that!
I know where the issue is coming from and I will have a fix shortly.

This should be fixed in the new release (0.12.2)

Yup, appears to work, thanks again for the quick fix!


May Need To Apply Trie Logic To Ensure No Close Match Pollutes The Search

Issue description
Supposed the Java class's import region :
import java.util.Collections;

Then based on this class's parent's param list, it needs to add java.util.Collections to its import region, but the import java.util.Collection; is a close match of java.util.Collections  then it won't add.
example issue img:

Reproducible on this branch : initial-tests

Fixed in pull #18


Support horizontal scrolling in ScrollableViewport

LGTM. I think more work will be needed to really support scrollDirection: everywhere that it's appropriate.


Removed bundled QUnit in favor of npm package.

I presume that version of grunt-contrib-qunit is compatible with the version of qunit you are upgrading to?

Just seen your comment, so I guess we'll be upgrading it anyway.

I presume that version of grunt-contrib-qunit is compatible with the version of qunit you are upgrading to?

Yup. npm fails with an error if packages have conflicting requirements. Testing locally and on CI also indicates that they are compatible.

Is it worth checking versions of other dependencies in package.json in another PR? I don't know whether these have been looked at in a while...

Yup. eslint was handled in 38e2fdf1b077653f2461d1c52459b85a8a134a91 and grunt-contrib-qunit is being upgraded in #12572.


Added example in EXAMPLES.md

Added an  example of a Counter App using sagu-ui.
Fixes part of #31

I have no idea about the error... as i have changed just onr file EXAMPLES.md and it's running perfectly fine on CodeSandBox.
Plz suggest the changes(if applicable).

I have no idea about the error... as i have changed just one file EXAMPLES.md and it's running perfectly fine on CodeSandBox. Plz suggest the changes(if applicable).

@yash6318  why you did this changes ?

send a single commit with only the update on the EXAMPLES.md file

No I have'nt!! Check in the files changed section...only 1 is showing.

No I have'nt!! Check in the files changed section...only 1 is showing.
It's showing Unchanged files with check annotations . I have no idea about it! . Plz suggest.

You are right, strange build error. Please squash both commits in a single one. Then submit a new PR with a different branch name ( not main )
Feel free to close this one after the new one

hi @yash6318 don't forget to open a new PR in a different branch


Added support for the "Catalogue des services" API.

This change is

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Fix filterInput reset in MergeJoin

Fixes #6741
Instead of resizing base vector to 0, use prepareForReuse to also reset offset/size vectors.
Add test that has ArrayVector/MapVector as filter input.

cc @mbasmanova


AsyncPredicate AND and OR operations eagerly test every predicate

Because AsyncPredicate and and or operations are tested using Flux.zip it ends up calling every single one of the chained predicates.
This is specially a problem when using the readBody predicate because we end up reading the request body eagerly.
This can impact memory utilization as well as cause issues with readBody if used in different routes with different content types.
I am pushing a code change to only invoke the next predicate when it's actually necessary to determine the boolean result.

No need for an issue if you've already got a PR.
Closing in favor of #1571

不
------------------ 原始邮件 ------------------
    发件人: Spencer Gibb<EMAIL_ADDRESS>

    发送时间: 2020-02-13 12:51:22

    收件人: spring-cloud/spring-cloud-gateway<EMAIL_ADDRESS>

    抄送: Subscribed<EMAIL_ADDRESS>

    主题: Re: [spring-cloud/spring-cloud-gateway] AsyncPredicate AND and ORoperations eagerly test every predicate (#1570)

Closed #1570.  —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.


While creating global IP provider produced an unexpected new value: Root object was │ present, but now absent

Prerequisites

[ ] Have you tested the operation in the API directly?
[ X ] Do you have the latest Terraform provider version?
[ ] Review the compatibility matrix before opening an issue.

Describe the bug
While creating global IP provider produced an unexpected new value: Root object was │ present, but now absent
Expected behavior
IP address pool is getting created with bug notification

Screenshots
Please provide an screenshot of the successful API call with cuRL, Postman, etc.
Environment (please complete the following information):

Cisco DNA Center version and patch: Version <IP_ADDRESS>-70026
Terraform version: v1.8.0
Cisco DNA Center provider version: v1.1.31-beta
OS Version: 14.3.1

Additional context
Add any other context about the problem here.

Hi @ishrak99
I tried global_pool and did not get the error you mentioned,
You can activate the debug and send me the result either screenshots or .txt/.log
Also if you can send me the .tf that you used for the test
You can enable debugging by exporting these environment variables:
set -x DEBUG 'true'
set -x TF_LOG 'DEBUG'

Once debug is enabled, you will be able to see all logs and dnac api calls.

@ishrak99 I'm closing this issue due to inactivity, if the issue persists or you have a new one, feel free to reopen the issue or create a new one.


Viewer button icons and styling are funky

Description
A clear description of the bug
I am reporting this as a bug because it didn't fit into another issue category
The viewer buttons look a bit funky and are a little different than the design intent. Joe and I discussed this a while back and he is aware, I just wanted to make a ticket so we don't forget about it.

Border color is not accurate (too bright). The border color should be #6e6e6e.
There are new icons for many of these that were created by Thao
Ortho and perspective icons do not have enough padding in the button.
You can view spacing in the design file, but general guidance is 5px minimum padding between icons and button edge.

https://xd.adobe.com/view/75b6a3c8-f650-443b-bccc-d1fcd134a35e-20e5/
Please reach out if there are any questions! Thanks, Joe!
Expected Behavior
What did you expect to happen instead?

Reproduction
A minimal example that exhibits the behavior.
Environment
Any additional information about your environment. E.g. OS version, python version, browser etc.

closed by https://github.com/simularium/simularium-website/pull/478


Missing jdk-11.0.1 releases including Hotspot JVM

https://github.com/AdoptOpenJDK/openjdk11-binaries/releases/tag/jdk-11.0.1%2B13 offers only downloads including the OpenJ9 JVM. Downloads including Hotspot are missing.

Yep - we're aware of this one :-). Working on it this week.

Why did you remove the first 11 release (11.0.0) from the download page?

They shouldn't be removed - looking into it...

It's back, thanks. Now I'm hoping for a 11.0.1 hotspot verison... ;-)

JDK 11.0.1 with Hotspot JVM is available now, but JRE is not (i.e. OpenJDK11-jre_x64_linux_hotspot_11.0.1_13.tar.gz is missing at the release page). Is this temporary or JRE builds will not be provided anymore?
What does U in filename OpenJDK11U-jdk_x64_linux_hotspot_11.0.1_13.tar.gz means? Is it a Unified version of JDK and JRE? JREs with OpenJ9 are still available at GitHub but not at adoptopenjdk.net. Will JRE builds be discontinued?

closing as 11.0.2 came out.


Redifines GF Latin-Core

Latin Core is the base glyphset for every Google Fonts, especially non-commissioned ones that want to support common latin script based languages from Europe/America.
Right now it includes lots of currencies and necessary glyphs to build a proper fraction feature, but we discussing migrating those to a "PLUS" glyphset that is not latin-centric, but rather a set of symbols and figures for every fonts whatever the script.
Then we would create/update more latin sets, still to be determined but probably something like:

latin core + vietnamese
latin core + indigenous european and american languages
latin core + latin african languages

The last part of this Latin sets definition may be sets for transliteration and IPA.

And I see that last PR has not been taken into account in the migration https://github.com/googlefonts/gftools/pull/450


download onc button not working

its not letting me click it

No fix?

You sure you put in the correct format?

Yeah, but it's still not working

I have the same problem. It says "The download button will not do anything unless you type in the correct Wi-Fi properties." right in the KillSecurly Foundation - ONC but I do not know what this means. Im pretty sure this is our problem though


Using a template containing a task group: One or more of the steps defined in the build does not have an associated task definition

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Environment

Server - VSTS or TFS on-premises?

If using TFS on-premises, provide the version:
TFS  2017, Update 3
If using VSTS, provide the account name, team project name, build definition name/build number:

Agent - Hosted or Private:

If using Hosted agent, provide agent queue name:

If using private agent, provide the OS of the machine running the agent and the agent version:

Agent version: 2.122.1 or 2.112.0 (happens on both)
OS: Windows 7
Issue Description
1. Create a template containing a Task group (which contains a single command line task)
2. Create a build definition from that template
3. Try to queue a build
4. Queue fails:  "One or more of the steps defined in the build does not have an associated task definition. Check if the task was uninstalled or has failed a licensing check."
Can work around by removing and re-adding the task group, but that defeats the purpose of using a template.
Error logs
The build doesn't actually execute at all, this is a validation error in the Queue Build dialog.  I don't see anything interesting in event viewer on the TFS server.

Release since the steps are contained to templates and a task group.

Cant reproduce.
On your Agent server, go to the tasks subfolder of you agent ( if you have multiple agents on the server, do so for all) and delete the content of it.
As the agent downloads all tasks from server if that folder is empty or task definition has new tasks or new versions of a task, it is safe to delete the content.
Perhaps something is stuck with the versions of the tasks.
Other option if you have multiple agents on the same server is to try to force the build to run on each agent to see if there are differences

We have the same problem with TFS 2017 Update 3.
Workaround "Can work around by removing and re-adding the task group, but that defeats the purpose of using a template." was working for us.

I tried the following one of @ArieHein 's suggestions:

delete all tasks from tasks folder on all agents (/agent#/_work/_tasks/) on build machine
reboot build machine
repeat original steps

I still get the same result.  Getting it in an alert now because I'm queuing from a different spot I guess:
Message from webpage
There are issues with the request or definition that will prevent the build from running:
One or more of the steps defined in the build does not have an associated task definition. Check if the task was uninstalled or has failed a licensing check.
OK
The task group in my template just contains a command line task that runs dir.

I tried to reproduce it on my VSTS account but was not able to. @pabrams, @DanielTheCoder Does this error come only with TFS 2017.Update 3?

@bansalaseem I don't have another installation to try it on.  Our TFS server has been upgraded from an older version though, so if this can't be reproduced on a clean install, maybe that could be the reason?

Thanks Pabrams. We have identified the issue, have observed that the issue is fixed in TFS 2018 RTM and are preparing a patch change on top of TFS 2017.Update 3 so that you can try it out in your installation.

Steps to fix Build template issue with TaskGroups

Copy Zip file, backup script and rollback script (files given after steps) to TFS installation location. Default Location will be like C:\Program Files\Microsoft Team Foundation Server 15.0
Take backup using the backup script provided.
a.	Open command prompt in Administrator mode.
b.	Go to TFS installation location.
c.	Run the script.
d.	Once backup is successfully done. Move to next step.
Unzip the zipped file. You will get prompt for “Replace or Skip Files”. Click on “Replace the files in destination”.
You will get another prompt saying “Provide administrator permission to copy to this folder”. Click on “continue”.
Go to VSTS web page. Press Ctrl + F5.
If after the fix if you face any issue. Run Rollback script to revert the change.
a.	Open command prompt in Administrator mode.
b.	Go to TFS installation location.
c.	Run the rollback script.

Application Tier.zip
Backup script:  (Save the below mentioned script as .bat file)
@echo off
if not exist backup\nul mkdir backup
cd backup
if not exist min\nul mkdir min
if not exist debug\nul mkdir debug
cd ..
set "errorcount=0"
copy /Y "Application Tier\Web Services_static\tfs\Dev15.M125.1_scripts\TFS\debug\CIWorkflow\Scripts\Scenarios\Definition\Sources\BuildDefinitionSource.js"  "backup\debug" >nul 2>&1
if %errorlevel% neq 0 set /a errorcount+=1
copy  /Y "Application Tier\Web Services_static\tfs\Dev15.M125.1_scripts\TFS\debug\CIWorkflow\Scripts\Scenarios\Definition\Sources\BuildDefinitionSource.min.js"  "backup\debug" >nul 2>&1
copy  /Y "Application Tier\Web Services_static\tfs\Dev15.M125.1_scripts\TFS\min\CIWorkflow\Scripts\Scenarios\Definition\Sources\BuildDefinitionSource.js"  "backup\min" >nul 2>&1
if %errorlevel% neq 0 set /a errorcount+=1
if %errorcount% equ 0 (
echo Backup completed successfully.
) else (
echo Backup failed. Error copying 1 or more files.
rmdir /S /Q backup
)
Rollback script: (Save the below mentioned script as .bat file)
@echo off
set "errorcount=0"
copy /Y "backup\debug\BuildDefinitionSource.js" "Application Tier\Web Services_static\tfs\Dev15.M125.1_scripts\TFS\debug\CIWorkflow\Scripts\Scenarios\Definition\Sources"  >nul 2>&1
if %errorlevel% neq 0 set /a errorcount+=1
copy  /Y  backup\debug\BuildDefinitionSource.min.js" "Application Tier\Web Services_static\tfs\Dev15.M125.1_scripts\TFS\debug\CIWorkflow\Scripts\Scenarios\Definition\Sources"  ">nul 2>&1
copy  /Y "backup\min\BuildDefinitionSource.js" "Application Tier\Web Services_static\tfs\Dev15.M125.1_scripts\TFS\min\CIWorkflow\Scripts\Scenarios\Definition\Sources"  >nul 2>&1
if %errorlevel% neq 0 set /a errorcount+=1
if %errorcount% equ 0 (
echo Rollback completed successfully.
rmdir /S /Q backup
) else (
echo Rollback failed. Error copying 1 or more files.
)

Thanks @nishubansal, I'll try this when I get a chance.

Actually, my client has a workaround, so we don't need to mess with the server, so I probably won't try this, and will just wait until we upgrade instead.

I am closing this issue as Nishu has posted a workaround and we have fixed it in latest code.


Add notice/message that download is complete.

Right now the text reads "Download Software..." even after the download is complete.
Suggest changing that text or adding a notice that notifies the user that the download is complete.

Good point, I'll have to add a bit of a rewrite since downloading async will need a callback to tell when finished.
Will be in the next release


Update MechJeb2-dev.netkan

Updates the spec_version, x_ci_version_base, ci and homepage fields

poke Where are you jenkins?

poke

Oh.. lol this is NetKAN-dev... Carry on!

Looks good, merging with my thanks.


App setup (pt2 - component organisation)

PR Overview

Merge #1 first before reviewing this.
This PR experiments with a way to organise the code - arranging components in a way that, hopefully, make sense for devs.

TODO
[ ] Add Zooniverse-React-Components to our package.json and use the shared Zooniverse header
[ ] Review zoo-reduxify's recent updates - zooniverse/zoo-reduxify#8 zooniverse/zoo-reduxify#9 zooniverse/zoo-reduxify#10 - and see how the redux components were rearranged into ducks. This may need to be another PR though, to keep our changes readable.
[x] Provide a screenshot of how Pt 2 should look like, at this stage of commits:

For the most part, this looks good, but I made a line comment about mobile views.
Also, concerning the navbar, when clicking on "powered by," the scroll bar that appears pushes the navbar a bit to the left. I'm using Chrome.

Re: the components repo. I will be opening a PR soon to add a couple more shared components between PFE and PFE-lab app and also will be fixing the name (so it conforms to NPM convention correctly with lower case). Could y'all wait on adding it until I get that merged in? Also do open issues/PRs for any components you want added and also keep zooniverse/rfc#14 in mind too if we go that route.

@wgranger noted on the mobile view - I haven't even checked how this looks like on mobile!
This may be a good time to query Becky if she has any direction she wants to go to with the mobile design. (Why can't I @ her here? I'll ping her on Slack)
@srallen Awesome, thanks for the heads up! We can wait for that new PR before we do anything with the shared compos.

I also need to figure out a better way to break my PRs into different stages. I mentioned earlier that PR #1 should be merged first before reviewing this PR, because I thought it'd make reviewing the changes easier on Github.
Unfortunately, looking at the commits in this PR, this PR doesn't seem to recognise commits 750789d to 853e218 have already been merged into master, and are showing those code changes when looking at 'Files changed'.
Any idea on how to make this PR cleaner asides from me just rebasing this PR on master and then force-pushing the branch?

@shaunanoordin My assumption would be resorting to the good old rebase/force-with-lease, so I'm not sure of an alternative. What would be the argument against that approach here?

I've updated Zooniverse-React-Components, so feel free to use it now. It's not on npm, so install via the github repo using the tagged version. It may be getting the talk paginator added to it sometime this week.


Request for ultra-high precision model

Could you please send me the ultra-high precision model?
<EMAIL_ADDRESS>Thanks, Jo

I'm not sure if you have seen my request, as I didn't get any answer. Certainly, you are busy, but may I kindly refresh my request?
Thanks, Jo


Unused import warning in build

Let's fix this:
src/Home.tsx
  Line 3:8:  'Card' is defined but never used  @typescript-eslint/no-unused-vars

This was fixed by #12


Can you release the code for view images rendering from the ShapeNetCore dataset?

Hello!
I'm learning your repo but I found no code for generating the view images from the ShapeNetCore dataset. You mentioned in your paper that you used Blender and rendered from 24 azimuth angles with a ﬁxed elevation angle but I still wonder if you can release the code of this process.
I want to produce the input images under the same settings for lighting and camera etc., on a different train/val/test division.
Thanks.

The code is in this commit.
Thanks!! Though I already finished another blender rendering function but were sad to find the single category iou drop about 3% on airplane category. Maybe that was due to different render settings.
Issue closed.