Skip cell typing if cell type reference versions match

Closes #538
The main purpose of this PR is to incorporate a check to make sure the reference file is the same when skipping either SingleR or CellAssign. I also made the following adjustments:

I renamed the celltypes_publish_dir to celltypes_checkpoint_dir. This made more sense to me since we are storing checkpoints, not final results.
I grabbed the SingleR and CellAssign reference versions from the filenames and pass them to the script that adds the cell type annotation to the SCE object. Here, I chose to store both the source and version together as either singler_ref_version or cellassign_ref_version in the metadata of the SCE object. Rather than storing the source and version separately, it made sense to me to have one string. How do people feel about this?

The one thing I'm not really sure about is where this should get handled. Nice work with string manipulation in nextflow, but I wonder if we actually want to do this in the R script? Since we already have singler_model_file and cellassign_reference_file in the meta, we could get away with just passing those into the R script and parse items out accordingly.

I think when I started working on this I was thinking I needed to check the version, not the filename, so started doing it in Nextflow. I also kind of liked having explicit variables for the file vs the reference. In case we ever were to change the file format, we would need to change the code in the script. But that's probably the case for Nextflow too. So I'm good with this change and will go ahead and do that.

With the easier manipulation in R, I think I would prefer storing the sources and versions as separate strings, just for the logical separation, but I don't feel too strongly about it.

I agree with this so I think I'll separate them.

Okay I've moved all of the file name manipulation into the R script, rather than storing the version and source information in the meta object. I also split up the source and version to store them separately in the metadata of the SCE object.
The last thing I did was fix the supplemental cell type report to skip anything related to submitter cell types if no submitter cell types are present. It looks like there were a few chunks missing has_submitter.

I added in a little function to create the ref info list from a filename. I did not move the checks though because I only want to check for each of the filenames if the results for that cell type annotation were provided. So I want them in their respective if statements.


find JSON instance from FromJSON and ToJSON

@commercetools/ctp-backend please review. I've deployed that locally and checked that it does not break the compilation.


Help with running spacia, ERROR:::Spaca results don't match input!

Hi team,
I try spacia on a data with around 300,000 cells. However, I got an error, so I try on a subset with 300 cells. Seem the software ran well. However, I got this error on subset of 3,000 cells.
python spacia.py cell_by_gene_aligned.txt spacia_metadata_aligned.txt --receiver_cluster Astrocyte --sender_cluster Microglia-PVM --receiver_features CD74 --sender_features NOS1
cat spacia_log.txt
15:00:11,INFO:::Processing expression counts.
15:00:12,INFO:::Maximal distance for 10 expected neighbors is 671.38
15:00:12,INFO:::Limiting bags to those with at least 2 sender cells
15:00:12,INFO:::Number of bags: 338
15:00:12,INFO:::Cosntruct Receiver pathways from each input gene
15:00:12,INFO:::Constructing pathway using correlation aggregation
15:00:12,INFO:::Cosntruct Sender pathways from each input gene
15:00:12,INFO:::Constructing pathway using correlation aggregation
15:00:12,INFO:::Writing spacia_job.R inputs to the model_input folder.
15:00:12,INFO:::CD74_correlated_genes is already finished and will be skipped.
15:00:12,INFO:::Running spacia_R MCMC MIL models.
15:00:12,INFO:::Collecting results.
15:00:12,INFO:::Spacia_R_results at:
15:00:12,INFO:::        spacia/CD74_correlated_genes
15:00:12,ERROR:::Traceback (most recent call last):
15:00:12,ERROR:::  File "spacia.py", line 1051, in
15:00:12,ERROR:::assert (
15:00:12,ERROR:::AssertionError
15:00:12,ERROR::::
15:00:12,ERROR:::Spaca results don't match input!
Would you please have a suggestion? I checked the cell ID of cell_by_gene_aligned.txt and spacia_metadata_aligned.txt and they are the same. Thank you so much!
cell_by_gene_aligned.txt
spacia_metadata_aligned.txt

Hello @Chrisdoan9
Please contact Yunguan Wang<EMAIL_ADDRESS>directly for your question. I believe he wrote this part of the codes
Thanks!
Tao

Hi @wtwt5237,
Thank you for your suggestion! I reached out on Sunday and waiting for the reply.

Generally you will need more than 500 bags to run Spacia. MCMC may not be able to converge and return meaningful data.
As for the error. It is likely MCMC did not output the primary instances correctly in a expected manner. Spacia assume a one-to-one mapping between each receiver cell and each of its candidate sender cells. Can you check the content in the "pip_recal.txt" file?

Hi @yunguan-wang,
Thank you for your reply! I think the file pip_recal.txt is only available for a successful run. It is the folder spacia/CD74_correlated_genes/
CD74_correlated_genes_pip_recal.txt


Wire up Lucene-type query language support

This will required a dedicate parser, which will generate an AST.

The start of the query parser is here: https://github.com/ekanite/ekanite/tree/master/query


[Feature] Add ability to place market order by funds

Looks good to me. Thanks for doing this so quickly!


Show number of real accounts for each topic on topics page

Displays the number of real accounts present for each topic in brackets after the topic name. Nothing fancy but it's there!

Needs CSS, can be addressed after PR.


[bug/conflict] create all is only creating one item forcing you to click it multiple times.

Pretty much title. Not sure if it's something on NDui+ side or TradeSkillMaster side but upon having both enabled when you go into a profession to create an item and click on create all (on the default window and not TradeSkillMaster window) it will only make 1 item (even if you fill out the number to create all x amount of times) making you have to click the button again and again to continue crafting said item.
Having NDui+ disabled but TradeSkillMaster enabled allows the create all function to work as intended; having TradeSkillMaster disabled but NDui+ enabled also allows the create all function to work as intended.
If I have both enabled (both NDui+ and TradeSkillMaster) the only way that it ends up working as intended is if I enter the TradeSkillMaster window instead of the default profession window.
No errors or anything comes up, so I'm not really sure which one of the two addons is actually causing this issue in the end, so thought I'd come report it here (I plan on making a report to TradeSkillMaster as well when I can figure out how to exactly)

This is a potential taint error, and I'm not sure how it's caused yet. You can try to disable Extended Vendor UI in console and test again.

@Witnesscm hmm yea it seems to be something to do with the Extended Vendor UI that is causing it, upon disabling that it seems to work correctly.

@Witnesscm so looking more into this because I started running into this issue again today even with Extended Vendor UI still disabled, I believe the addon that is actually causing this issue is Craftsim as disabling the Craftsim addon things started working again, even when I enable the Extended Vendor UI again..
Still going to do some more digging as time goes on because for now I'm not fully sure which of the three things is tainting things fully xD

Thank you for the feedback. This is a tricky issue indeed. I also have this issue occasionally recently, but I didn't install Craftsim. So more than one addon can cause this issue. I'm looking for some steps to reproduce this issue stably.

I'm going to go ahead and close this issue here, as I haven't ran into this issue in a very long time now. if it comes up again at any point in the future I'll re-open this issue.


Update BBE for HTTP AccessLog

Description:
$title. with the changes made to HTTP AccessLog, update the existing BBE for HTTP AccessLog with the new changes.
Describe your task(s)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Closing the issue as this is already done.

https://github.com/ballerina-platform/ballerina-distribution/pull/5582
https://github.com/ballerina-platform/ballerina-distribution/pull/5504


CRA dev build Strict.Mode conditional rendering

Description:
Because of CRA dev "npm start" which as React Strict mode on .Usage of react router dom's  conditional redirect on authentication is always true. Either the condition is true in first render or second render which quickly makes the page redirect.
Version
"react-router-dom": "^5.2.0",
Test Case
Not adding CodeSandbox because this would not be reproducible in Codesandbox
Steps to reproduce
App.js:
    <AuthContext.Provider value={auth}>
        <Router>

          <Switch>
            <Route path='/login'>
              <Login />
            </Route>
             <Route path='/login'>
            <LoginPage />
          </Route>

            <ProtectedRoute exact path='/test' comp={Authapp} isAuth={auth} />
            <Route path='/'>
              <MainContent />
            </Route>
          </Switch>

        </Router>
      </AuthContext.Provider>

function ProtectedRoute({ comp: Component, ...rest }) {
  const auth = React.useContext(AuthContext);
  console.log('Protected=>' + auth);

  useEffect(() => {
    console.log('Rendered Once');
  });

  return auth ? (
    <Route {...rest} render={({ location }) => <Component />} />
  ) : (
    <Redirect
      to={{
        pathname: '/login',
      }}
    />
  );
}

Expected Behavior
Component should redirect to login page if the user is not logged in. And render  if the user is logged in.
Actual Behavior
The issue is that CRA uses <React.StrictMode> which leads to double render and on first iteration or second one the auth is undefined and the router quickly redirects so there is no way to make it working in dev build.
With Redirect in the ProtectedRoute shows this:
[HMR] Waiting for update signal from WDS...
App.js:29 Protected=>undefined
App.js:32 Rendered Once

Changing the ProtectedRoute Component to this shows the issue:
Console output:
[HMR] Waiting for update signal from WDS...
App.js:29 Protected=>undefined      ------> First render if Redirect is present it just redirects
App.js:29 Protected=>[object Object]. ------> Get's value from UseContext here but the app would have already redirected
authapp.js:5 Inside AuthApp ----> This is rendered in this example coz instead of <redirect> we are using
hello

App.js:32 Rendered Once

function ProtectedRoute({ comp: Component, ...rest }) {
  const auth = React.useContext(AuthContext);
  console.log('Protected=>' + auth);

  useEffect(() => {
    console.log('Rendered Once');
  });

  return auth ? (
    <Route {...rest} render={({ location }) => <Component />} />
  ) : (
    // <Redirect
    //   to={{
    //     pathname: '/login',
    //     // state: { from: location },
    //   }}
    // />

h3llo

  );
}

I would appreciate if we clarify this in documents as to how to deal with this situation as this is a very basic use case and example that people are using.

I saw a very similar question here and doesn't seem like there was a clear answer:
https://stackoverflow.com/questions/61821790/using-react-context-to-protect-a-route

I saw a very similar question here and doesn't seem like there was a clear answer:
https://stackoverflow.com/questions/61821790/using-react-context-to-protect-a-route


fix: dashboard/barchart replace numeration by empty characters

The code at the main branch is adding a numeration to each SBOM name in the Dashboard/Barchart to avoid collisions when multiple SBOMs have the same name.
This PR is replacing the numeration by empty characters so each SBOM will have a number of empty characters to the left according to their index in the array. E.g.

sbom1
 sbom2
  sbom3
   sbom4
    sbom5

The sbom names will still be renderered as they used to as the empty characters are not visible to the eye of the user. E.g.

@mrizzi The original JSON that generated the issue at https://issues.redhat.com/browse/TC-1769 was:
[
    {
        "sbom_id": "22f517f1-ac17-423e-816d-ee1ae57f083c",
        "sbom_name": "product-example",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    },
    {
        "sbom_id": "3092635e-a6ba-42e3-b77b-512407298e48",
        "sbom_name": "openssl-3.0.7-18.el9_2",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    },
    {
        "sbom_id": "4429e805-124b-4d9a-af74-584102f3478e",
        "sbom_name": "openssl-3.0.7-18.el9_2",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    },
    {
        "sbom_id": "quarkus-bom-2.13.8.Final-redhat-00004.json.bz2",
        "sbom_name": "quarkus-bom",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 1,
            "critical": 1
        }
    },
    {
        "sbom_id": "test-sbom-index-with-special-char:123",
        "sbom_name": "registry.k8s.io/coredns/coredns:v1.9.3",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    },
    {
        "sbom_id": "ubi8-8.8-1067.json.bz2",
        "sbom_name": "ubi8-container",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    },
    {
        "sbom_id": "ubi8-minimal-8.8-1072.1697626218.json.bz2",
        "sbom_name": "ubi8-minimal-container",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    },
    {
        "sbom_id": "ubi8_ubi-micro-8.8-7.1696517612.json.bz2",
        "sbom_name": "ubi8-micro-container",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    },
    {
        "sbom_id": "ubi9-9.3-782.json.bz2",
        "sbom_name": "ubi9-container",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    },
    {
        "sbom_id": "ubi9-minimal-9.3-1361.json.bz2",
        "sbom_name": "ubi9-minimal-container",
        "vulnerabilities": {
            "none": 0,
            "low": 0,
            "medium": 0,
            "high": 0,
            "critical": 0
        }
    }
]

That JSON contains 2 SBOM with the same name "openssl-3.0.7-18.el9_2".
Here is a video of that JSON being loaded into the chart (using this PR):
https://github.com/user-attachments/assets/841949e1-97ec-457b-9776-a9c6c17c1576

In the video we can see there are 2 SBOMs with the same name openssl-3.0.7-18.el9_2 rendered
When the user clicks on the first sbom "openssl-3.0.7-18.el9_2" then he is redirected to the details page where the SBOM id is 4429e805-124b-4d9a-af74-584102f3478e
When the user click on the second sbom "openssl-3.0.7-18.el9_2" the he is redirected to the details page where the SBOM id is 3092635e-a6ba-42e3-b77b-512407298e48


DOC: argument origin in scipy.ndimage.convolve

Reference issue
Closes #20370
What does this implement/fix?
The documentation for the argument origin in scipy.ndimage.convolve is now the same as scipy.ndimage.correlate.

Hmm, this seems to be in contradiction with #14877 and #14745?

Hmm, this seems to be in contradiction with #14877 and #14745?

Sorry for the mistake and thank you for the references. Perhaps I should just add the fact that one can also pass a sequence rather than an int? Passing origin=1 equals to passing (1, 1) due to this line:
https://github.com/scipy/scipy/blob/ec718244e278c489070cff539e9f3358822575bf/scipy/ndimage/_filters.py#L769
So the new text would simply change the first line of the current documentation:

origin : int or sequence, optional
Controls the origin of the input signal, which is where the filter is centered to produce the first element of the output. Positive values shift the filter to the right, and negative values shift the filter to the left. Default is 0.

Just encountered the discrepancy between docs and actual behaviour. The proposed change works for me to describe accurately what I can expect the function to do.


Add vendor defaults, for example empty spool weight

Is your feature request related to a problem? Please describe.
Currently every time you enter a new filament you have to fill in fields like empty spool weight with no default value
Describe the solution you'd like
Vendors appear to change empty spool vendors rarely (though it does happen).  If you added a field to the Vendor record "current empty spool weight" and use that as a default in the create filament screen once the vendor has been selected you would save data entry time.  When the vendor changes their spools a user would change that in the vendor screen and from that time on new filaments would default to the new value.
Describe alternatives you've considered
You could start to capture all the spool possibilities for a vendor, but that's probably overkill for 90% of cases.

Doesn't vendors have different spools for their different in-house brands? I think having this be default per vendor is too specific and would rarely be correct.
It's better to focus on having a filament database with known spool values instead.

Every spool I ever bought from Hatchbox no matter what the color or type of plastic) was the same, Esun as well.  When I say vendor I'm talking about the in-house brand so even if it did vary by brand it would still make sense to me to have a default spool weight associated with that brand.

You could also define the empty coils as an independent area.
This would also allow you to store different coils for each manufacturer. Some manufacturers offer plastic, cardboard, refill and/or wooden spools. In addition, you wouldn't have to search the Internet or your own tables every time for the empty weight of the respective spool.
Just my 2 cents...

Right now there is an empty spool weight at the filament level, which gives you the ability to set those weights per filament.  This should allow you to account for individual differences.
If there was an 'empty spool weight' at the vendor level that "fell through" to the filament, that would be ideal.  It's essentially a "default" value for empty spool weight that is applied when you create a new filament.
I would contend, though, that the Filament shouldn't have ANY spool values on it:  that's what Spool is for.  I've created a discussion (#338) to see if this would be a desirable change, or if I am just crazy.

Doesn't vendors have different spools for their different in-house brands? I think having this be default per vendor is too specific and would rarely be correct. It's better to focus on having a filament database with known spool values instead.

I have been thinking about this lately. Could we setup a way to pull the filaments from a community ran db? Make it optional so you can either use local db or community driven one.

Already in progress :) https://github.com/Donkie/SpoolmanDB
Will be available in next release

This issue can probably be closed, considering #339 was release in 0.17 and the community DB support is in 0.18


feat: add about page

Description
Adds about page
Fixes #33
Type of Change

[ ] Bug fix
[x] New feature
[ ] Test update
[ ] Refactor
[ ] Breaking change
[ ] Documentation update

Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have commented my code where necessary.
[x] I have made corresponding changes to the documentation (README, CONTRIBUTING, etc).
[x] I added a new Library/Dependency and have updated the README.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] My changes generate no new warnings or errors.
[x] New and existing unit tests pass locally with my changes.

@utk09-NCL

also @utk09-NCL before you merge the pr it would be great if you add a level label to the issue and then merge

what do you mean level label?

what do you mean level label?

like add a label with level1, level2 based on the tasks you have assigned to me as I'm a gssoc contributor, it would be of great help to me

Please don't push now @RNAdvani
See the updates on README

NOTE - CODEBASE IS CURRENTLY BEING UPDATED FROM JAVASCRIPT TO TYPESCRIPT. PLEASE REFRAIN FROM RASING ANY PR'S TILL SUNDAY 16:00 GMT

Also, I don't really know if I can assign level labels, and I'm not even sure if this has been accepted in gssoc (definitely accepted to hactoberfest though)

Please don't push now @RNAdvani See the updates on README

NOTE - CODEBASE IS CURRENTLY BEING UPDATED FROM JAVASCRIPT TO TYPESCRIPT. PLEASE REFRAIN FROM RASING ANY PR'S TILL SUNDAY 16:00 GMT

Also, I don't really know if I can assign level labels, and I'm not even sure if this has been accepted in gssoc (definitely accepted to hactoberfest though)

okay, i wont push, and ig you probably can assign level tags

these are rules for the gssoc points system

Yes, but can you check if this repo is accepted in gssoc?

yes it is, your repo is accepted i checked it

I can't find it, can you share a screenshot or something please? Are we looking at two different things? 😅

yes here is the screenshot

That's just the topic, but I think this repo is not listed on https://gssoc.girlscript.tech/project which I got to know recently. Sorry about that, but I thought the process was same as hacktoberfest. But apparently for gssoc, I needed to register the repo 2 months ago (when this project did not exist 😞)

correct, it's okay I'll still contribute to this loved working with you on this

Thanks @RNAdvani Appreciate the gesture and all your (past and future) contributions! 😄

The project has been updated to use Typescript, please pull the latest main and create a new branch with your changes (if that's easier). Thank you for understanding!


Slowdown while aim (PAY FEATURE)

Description
Slowdown while aim, new parameter UnscopeAfterShoot and BanScopeWhileCooldown. If UnscopeAfterShoot = True, then when activating the event WeaponPostShootEvent, make an exit from the scope. If BanScopeWhileCooldown = True, then it is necessary to prohibit the player from entering the scope while Delay_Between_Shots is active
Configuration
gun:
 Scope:
  Scope_Speed: 0-100%
  Unscope_After_Shot: True/False
  BanScopeWhileCooldown: True/False

Payment (optional)

[X] I'm willing to pay for this feature

https://www.spigotmc.org/threads/fov-change-insanity.621232/
working on a solution


send ci results to sputnik, added badge to readme

Fixes #1229

Current coverage is 96.58% (diff: 100%)

Merging #1674 into master will not change coverage

@@             master      #1674   diff @@
==========================================
  Files            89         89
  Lines         11213      11213
  Methods           0          0
  Messages          0          0
  Branches       1875       1875
==========================================
  Hits          10830      10830
  Misses          239        239
  Partials        144        144

Powered by Codecov. Last update d1dcb26...6ddf1ed


[viem] signMessage fails when using raw property of SignableMessage

Hey there!
I noticed that using @turnkey/viem's signMessage will always fail if you use the raw form of the SignableMessage type.
// succeeds
await turnkeyViemAccount.signMessage({ message: 'hello' });

// fails
await turnkeyViemAccount.signMessage({ message: { raw: stringToHex('hello') } });
await turnkeyViemAccount.signMessage({ message: { raw: hexToBytes('0x68656c6c6f') } });

Looks like it's due to this line, which assumes message is always a string, and casts it to 0x${string}:
https://github.com/tkhq/sdk/blob/89d9999757e004ce6f15ca5c91ea7378774c4ee2/packages/viem/src/index.ts#L190
I believe a quick fix is to replace keccak256(message as `0x${string}`) with hashMessage(message). You can import hashMessage from viem itself, and it accepts a SignableMessage, so it should be exactly what's needed here.
FYI Viem has a nice set of typesafe utilities, and also, as I recently found, common types like Hex so you don't need to type `0x${string}` all over :)

Hi @danscan thanks for reporting this! Awesome catch -- we're on it: https://github.com/tkhq/sdk/pull/117

Hey @danscan the fix has been merged + released. Will be closing this issue now - please let us know if there are any additional issues and we'd be happy to revisit. Thanks again for filing this!


Support Bytes feature in file scope

Summary
Add the ability to specify the bytes feature in the file scope
Motivation
Malware authors and exploit developers frequently use shellcode in their malware, which would normally be missed in the function and basic block scope.  Therefore, being able to detect byte sequences corresponding to common shellcode instruction sequences would be quite useful.
Describe alternatives you've considered
While the strings feature does exist, some x64 instructions aren't represented by bytes in the printable character range. Also, although the regular expression feature in strings should allow someone to input hex sequences through the use of \x's, so far this hasn't been able to detect the byte sequence itself within an executable. Finally, although bytes is available in the function and basic block scope, shellcode usually exists outside of both scopes, which means that Capa won't be able to detect the byte sequences in shellcode.

You've made a good argument for this feature.
We'd previously discussed some similar ideas, and the primary counter argument is to avoid competing with yara (which does a great job at matching binary content). On the other hand, I think we could experiment with this feature pretty easily.
First, would you propose a couple rules that make use of this feature? This way we can discuss the syntax on some concrete examples.
Then, would you think about if you'd like to help implement this feature? If you have the time and interest, it would be great to incorporate your experience. We can recommend strategies, if needed.

closing because the discussion has stagnated. please re-open to continue discussion.


Tab closing automatically

Hello, I'm trying your nice extension. It's fine when opening a new tab but when I'm typing an url in an existing tab the tab closes with its history.  It would be great to set a landing page instead or just leave the current tab as it is, if it's not too complex to achieve.
Kind regards and happy Easter,
V.

@Virgus
Great suggestion. I'll add an option so existing tab would stay open. It will be released this week under version 2.1.


[http_check] report check as metrics network.http.{can_connect|cant_connect}

What does this PR do?
Adds two metrics:

network.http.can_connect
network.http.cant_connect

Motivation
We had difficulty managing alerts from http checks vs our metric based alerts. Having a metric means we can configure a metric based alert instead. Some noted benefits in our environment:

the triggered alert can show url first instead of the instance from which the check ran
we can easily graph, use top list etc.
it's easier and more regular to configure the alert

Testing Guidelines
Not sure. Didn't see the other metrics that are reported (response_time) have tests. We are running this code in production with no issues.
Versioning

[x] Bumped the version check in manifest.json
[x] Updated CHANGELOG.md

Hey @aver-stephen-smith! Thanks for the contribution!
I think this is probably a good change. And, we'll give it a much more thorough review as soon as we can! Looking at it briskly, I think we likely would not merge it in its present state. Instead of inspecting the service checks and seeing what the service check is, you should set the metric in the same way and manner that the service checks are set, that would prevent them from getting out of sync.
Thanks a lot, again, for you contribution! We'll look into reviewing this asap!

Ok, thanks. Let me know what I can do to help. Happy to test! -Stephen

Hey! @aver-stephen-smith Thanks for your changes. I missed them, I apologize.
Could you resolve the conflicts? After that I can merge this! 😄


Should we add images to the readme page?

I just added an image to the readme page because I think it would be nice for beginners to see images instead of text to see what the plugin offers, but I don't know if you like it or not.
Should we describe the plugin features by text or should we also add images to the readme file?

sorry.. I added the image to the readme before asking one of you if it's okay and if you like it as plugin documentation.

Yeah that is fine, thanks. Feel free to improve the project as you like.

@fharms how did you create the animiated gif?

@bennetelli I'm using licecap from cockos. It's working both on Windows and OSX and currently using it on OSX

Thanks @fharms


gyp: Allow OS='ios' to successfully build

Cross compiling for ios currently works if you specify OS=mac at gyp-time.  This allows ios to also be specified while still working.
Not sure what the current standards in this library but I'm happy to make this change in the "right" place if I guessed wrong.

LGTM. Can you please clarify a bit more either on the first commit line or after that this is regarding cross-compiling? Something like "build: fix cross-compiling for iOS"

Thanks, I updated the commit as suggested.

Thanks! Landed in 96814fe


Added Full Website

In this milestone of the Math Magicians project :

a website consisting of 3 pages was created
a navbar was added
 was created for each page
react router was used to make the links usable

Thank you! Looking forward to your review.

Thank you @GzimAsani !


Zoom Out Effect on Hovering

Is your feature request related to a problem? Please describe.
The cards of team members are static , it would be good to add hovering effects on them.
Describe the solution you'd like
I can add zoom out effect on hovering on the cards with box shadow .

Is your feature request related to a problem? Please describe.
The cards of team members are static , it would be good to add hovering effects on them.
Describe the solution you'd like
I can add zoom out effect on hovering on the cards with box shadow .

@anushka-srivastava22  Can you add some screenshots or describe a bit more about cards on which page, etc.

@anushka-srivastava22 , Can you give any update or let us know more about the issue?
Otherwise if the issue isn't as such, then we can close this one and you can try for some other fresh one's.


Xerox Print Driver Processor is busted

Xerox completely changed the API I was using in this logic and it hasn't been a simple fix.  A few weeks ago, spent a few days working on it and wasn't able to determine the best route forward.
Hopefully will be able to work on this again in the near future...
Been meaning to submit this, just keep forgetting.

Fixed in 0614a2d.


guess conntrack netns ino independently of tracer netns ino v2

Reverts DataDog/datadog-agent#22097
fixes a small bug where the UDPv6 config for USM were not being set properly on newer kernels
https://datadoghq.atlassian.net/browse/NPM-3143

/merge


Conditional useObserver hook

This is a feature request.  I'm looking for a way to use the useObserver hook conditionally.
Depending on the state of my component, I'd like to be able to suspend and then resume the useObserver hook.

No hooks can be used conditionally. Use <Observer> component for conditional reactivity.

@FredyC This is what I had in mind.
https://twitter.com/DavidKPiano/status/1228700861024604160
Is there a way to use hooks such as the useObserver hook in a way similar to "subscribable" objects.
https://codesandbox.io/s/subscribable-context-e4j31

Streams are obviously a whole different paradigm. Feel free to use those, but MobX is about declarative observability so you never have to doubt that component will be up to date. When you introduce conditionals and have a bug in there, it will be really hard to track down.

OK, I'll close this ticket.

note that useObserver is already a subscription mechanism, and way way
smarter than any stream subscription, for example observables in unused
branches won't be subscribed to, whereas stream subscriptions are much more
coarse grained and dumber. So formulating the problem as generic as you do,
it sounds to me like you are asking for something that is worse than
what you have currently with useObserver. Now I don't know your use case,
but make sure you are not asking for this based on a theoretical exercise,
but rather on measured performance. Otherwise by trying to pull some clever
trick might very well be making things worse, not better.
On Sat, May 9, 2020 at 12:55 PM Les Szklanny<EMAIL_ADDRESS>wrote:

Closed #864 https://github.com/mobxjs/mobx-react/issues/864.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mobxjs/mobx-react/issues/864#event-3319317897, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAN4NBA5LYWKRJIG4PSSKGLRQVABRANCNFSM4M4XYAUA
.

Thank you for your answer @mweststrate .

for example observables in unused
branches won't be subscribed to

Could you please explain what you mean by "unused branches" and how they are handled?

@AjaxSolutions I believe he means something like this. To be honest, I did not know about this either. That basically gives you ability for conditional observability.
https://codesandbox.io/s/angry-sunset-doer5?file=/src/App.js
Note: initial 2 renders is normal, happens even if you comment out mutation

Every interesting.  Thank you for the codesandbox @FredyC .


Add prefix option to asset_hash

This allows manually changing the filename so that fiel header changes
can be reflected on the CDN. E.g. if you turn on crossOrigin serving
(CORS) the asset hash doesn't change, but the CDN cache needs to be
broken in order to pickup the new header.

Thanks! Any chance of a release soon?


Are healthchecks messed up?

I have stack with 3 services. Two of these has healthcheck enabled.
1st service (site) performs GET request to /healthcheck url
2nd one (api) check for tcp port 5099 open

But I can see what apiservice is in unheathly state. And in logs I see:

Here is containers Healtheck tab view:

At same time I see what it is no healthcheck activity in site container logs.
P.S. Docker version on this host is 1.11.1

Useful
Info

Versions
Rancher v1.1.0-dev1 Cattle: v0.160.3 UI: v1.0.7

Access
github admin

Route
service.containers

Host restart solved the problem.

It looks like you had something going on with your networking between your hosts. Please open a new issue if you encounter it again. Typically, if health checks go south, the first thing to check if the networking between your hosts is working by execing into the network agent and pinging the IP (10.42.x.x) of the network agent on another host.


Dart2JS rejects metadata on type parameters

Dart2JS fails to compile the following co19 test with 'Error: Expected identifier, but got '@'':
Language/10_Generics/09_Generics_A01_t17.
This should be allowed according to the grammar.

dupe of #5841


Dismiss Dialog

how to dismiss Dialog without using any button
is there any method to dismiss dialog please let me know

TabDialogFragment returns DialogFragment type so you could:
DialogFragment df = TabDialogFragment.createBuilder(MainActivity.this, getSupportFragmentManager())                         .setTitle("hello")                         .setSubTitle("subtitle")                         .setTabButtonText(new CharSequence[]{"Tab1", "Tab2"})                         .setPositiveButtonText("Love")                         .setNegativeButtonText("Hate")                         .setNeutralButtonText("WTF?")                         .setRequestCode(REQUEST_SIMPLE_DIALOG)                         .show();
now after the event you are listening to has occurred, simply call df.dismiss();
Make sure that df is global if you want to use it elsewhere in the class.

dialogexamplename.dismiss();
//
this works on every dialog lib or java default i saw


Cannot config CORS for PATCH method

Prerequisites

[x] I have written a descriptive issue title
[ ] I have verified that I am running the latest version of Nancy
[x] I have verified if the problem exist in both DEBUG and RELEASE mode (I deploy RELEASE mode)
[x] I have searched open and closed issues to ensure it has not already been reported

Description
Can not using PATCH method although already enable CORS
Steps to Reproduce
I enable CORS by using follow code
protected override void RequestStartup(ILifetimeScope container, IPipelines pipelines, NancyContext context)
        {
            base.RequestStartup(container, pipelines, context);
            //CORS Enable
            pipelines.AfterRequest += ctx =>
            {
                ctx.Response.Headers.Add("Access-Control-Allow-Origin", "*");
                ctx.Response.Headers.Add("Access-Control-Allow-Credentials", "true");
                ctx.Response.Headers.Add("Access-Control-Allow-Methods", "PATCH, PUT, GET, POST, DELETE, OPTIONS");
                ctx.Response.Headers.Add("Access-Control-Allow-Headers", "Content-Type, x-requested-with, Authorization, Accept, Origin");
                ctx.Response.Headers.Add("Access-Control-Expose-Headers", "Accept,Origin,Content-type");
            };
        }

Then, I using OPTIONS to check:
curl -H "Origin: http://example.com" \
  -H "Access-Control-Request-Method:PATCH" \
  -H "Access-Control-Request-Headers: X-Requested-With" \
  -H "Content-Type: application/json" \
  -X OPTIONS --verbose \
  -d '[{"op":"replace","path":"/Reference","value":"abc 123"}]' \
  http://api.mycompany.com/properties

It return
HTTP/1.1 200 OK
< Allow: GET, POST, PUT, DELETE
< Content-Type: text/html
< Server: Kestrel
< Access-Control-Allow-Credentials: true
< Access-Control-Allow-Headers: Content-Type, x-requested-with, Authorization, Accept, Origin
< Access-Control-Allow-Methods: PATCH, PUT, GET, POST, DELETE, OPTIONS
< Access-Control-Allow-Origin: *
< Access-Control-Expose-Headers: Accept,Origin,Content-type
< X-Powered-By: ASP.NET
< Date: Fri, 29 Sep 2017 08:43:38 GMT
< Content-Length: 0

I'm not sure about Allow: GET, POST, PUT, DELETE
Finally, I try using PATCH method
curl -H "Origin: http://example.com" \
  -H "Access-Control-Request-Method:PATCH" \
  -H "Content-Type: application/json" \
  -X PATCH --verbose \
  -d '[{"op":"replace","path":"/Reference","value":"abc 123"}]' \
  http://api.mycompany.com/properties

It return
< HTTP/1.1 405 Method Not Allowed
< Allow: GET, POST, PUT, DELETE
< Content-Type: text/html
< Server: Kestrel
< Access-Control-Allow-Credentials: true
< Access-Control-Allow-Headers: Content-Type, x-requested-with, Authorization, Accept, Origin
< Access-Control-Allow-Methods: PATCH, PUT, GET, POST, DELETE, OPTIONS
< Access-Control-Allow-Origin: *
< Access-Control-Expose-Headers: Accept,Origin,Content-type
< X-Powered-By: ASP.NET
< Date: Fri, 29 Sep 2017 08:45:43 GMT
< Content-Length: 0

As you can see, when using PATCH method, it return 405 Method Not Allowed  :(
System Configuration

Nancy version: Nancy2.0.0-Clinteastwood
Nancy host

[x] Nancy.Hosting.Aspnet
[ ] Nancy.Hosting.Self
[x] Nancy.Owin (Kestrel)
[ ] Other:

Other Nancy packages and versions:
Environment (Operating system, version and so on):
.NET Framework version: Net Core 1.1
Additional information:

Suddenly, it worked for me now, thanks


improve referent-person syncronization

Testing indicated that it's possible to have the referent/person connection possibly drift out-of-sync. So consider checks to ensure this doesn't happen.

partially improved 2020-06-08 in commit https://github.com/Brown-University-Library/disa_dj_project/commit/4e74f24f374f54e8a4db6a8a23d559deb952876f


#<ArgumentError: invalid byte sequence in US-ASCII>

Overview
Sometimes when code is mounted over a network share or docker shared volume and bad characters are present in puppet source code being tested onceover will crash
Expected result
Print an error message telling user to fix the bad encoding
Actual result
bundle exec onceover run spec --puppetfile Puppetfile.onceover
INFO	 -> Using Puppetfile 'Puppetfile.onceover'
INFO	 -> Updating module /shared/.onceover/etc/puppetlabs/code/environments/production/modules/stdlib
<<many lines snipped>>
INFO	 -> Updating module /shared/.onceover/etc/puppetlabs/code/environments/production/modules/puppet_enterprise

Error while running: #<ArgumentError: invalid byte sequence in US-ASCII>

Analysis
Modifying the onceover source code to print out the lines being evaluated reveals the cause - invalid characters in the puppetlabs-docker module's comments (fancy quotes?):
class docker::service (
# == Define: docker::stack
#
# A define that deploys Docker stacks or compose v3
#
# == Paramaters
#
# [*ensure*]
#  This ensures that the stack is present or not.
#  Defaults to present
#
# [*stack_name*]
#   The name of the stack that you are deploying
#   Defaults to undef
#
# [*bundle_file*]
#  Path to a Distributed Application Bundle file
#  Please note this is experimental
#  Defaults to undef
#
# [*compose_file*]
#  Path to a Compose file
#  Defaults to undef
#
# [*prune*]
#  Prune services that are no longer referenced
#  Defaults to undef
#
# [*resolve_image*]
#  Query the registry to resolve image digest and supported platforms
#  Only accepts (“always”|“changed”|“never”)

Error while running: #<ArgumentError: invalid byte sequence in US-ASCII>
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/controlrepo.rb:644:in `find_classname'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/controlrepo.rb:633:in `block in get_classes'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/controlrepo.rb:632:in `each'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/controlrepo.rb:632:in `get_classes'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/controlrepo.rb:178:in `block in classes'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/controlrepo.rb:177:in `each'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/controlrepo.rb:177:in `classes'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/controlrepo.rb:57:in `classes'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/class.rb:12:in `initialize'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/testconfig.rb:62:in `new'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/testconfig.rb:62:in `block in initialize'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/testconfig.rb:62:in `each'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/testconfig.rb:62:in `initialize'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/cli/run.rb:49:in `new'
/usr/local/bundle/gems/onceover-3.12.1/lib/onceover/cli/run.rb:49:in `block (2 levels) in command'
/usr/local/bundle/gems/cri-2.15.3/lib/cri/command.rb:359:in `run_this'
/usr/local/bundle/gems/cri-2.15.3/lib/cri/command.rb:296:in `run'
/usr/local/bundle/gems/cri-2.15.3/lib/cri/command.rb:314:in `run'
/usr/local/bundle/gems/cri-2.15.3/lib/cri/command.rb:314:in `run'
/usr/local/bundle/gems/onceover-3.12.1/bin/onceover:7:in `<top (required)>'
/usr/local/bundle/bin/onceover:29:in `load'
/usr/local/bundle/bin/onceover:29:in `<top (required)>'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/cli/exec.rb:74:in `load'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/cli/exec.rb:74:in `kernel_load'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/cli/exec.rb:28:in `run'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/cli.rb:424:in `exec'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/cli.rb:27:in `dispatch'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/cli.rb:18:in `start'
/usr/local/bundle/gems/bundler-1.16.6/exe/bundle:30:in `block in <top (required)>'
/usr/local/bundle/gems/bundler-1.16.6/lib/bundler/friendly_errors.rb:124:in `with_friendly_errors'
/usr/local/bundle/gems/bundler-1.16.6/exe/bundle:22:in `<top (required)>'
/usr/local/bundle/bin/bundle:104:in `load'
/usr/local/bundle/bin/bundle:104:in `<main>'

Proposed fix
Catch the ArgumentError and print a warning message

Currently testing a PR for this

seems to work ...


Handle List and User defined property types using from Json directive

Currently, we are not handling List and user-defined property types.
In the below example, we have a recent address that is of user-defined type "Address" and an address history is a List of Address. With the proposed changes these fields will be resolved.
type Author {
    id: Int! @fromJson
    name: String! @fromJson
    birthdate: DateTime @fromJson
    recentaddress: Address @fromJson
    addresshistory: [Address] @fromJson
}

type Address{
    id: Int! @fromJson
    state: String! @fromJson
    pincode: String! @fromJson
}

extend type Book {
    author: Author
}

Hey  @vickytr44,
great to have you back for another contribution.
Can you add a test that shows what you are fixing?

Yes i will write unit test for this.

I have added unit test for the changes.

Thank you ... will have a look at it today.


Metrics overview panel

This PR rebases metrics-overview-panel and i18n-japan on top of the current master.
Work encompassed:

Remaining work has been ticketed and discussed during group sync on 1/19/16.

Current coverage is 68.82%

Merging #256 into master will not affect coverage as of 525fad0

@@            master    #256   diff @@
======================================
  Files           71      71
  Stmts         2566    2566
  Branches         0       0
  Methods          0       0
======================================
  Hit           1766    1766
  Partial          0       0
  Missed         800     800

Review entire Coverage Diff as of 525fad0

Uncovered Suggestions

+0.67% via goldstone/views.py#30...46
+0.63% via ...stone/drfes/views.py#134...149
+0.40% via ...dstone/core/tasks.py#133...142
See 7 more...

Powered by Codecov. Updated on successful CI builds.

event details:

api event 4 and 500 response codes:

non-zero severity levels

:+1:


AttributeError: module 'params' has no attribute 'cnn_last_layer_length'

Hi Guys,
Can you please point me in the right direction about this error I m getting while running cnn only mode.

Thanks for pointing this out. The issue has been fixed. mlFunctions.py was still referring to the old name.


Giant Update Because I Waited Too Long

Introduce RecipeBuilder as an API surface: given a Graph structure and a NodeTypesMap, RecipeBuilder can construct Arc-ready recipes. Builds on the RecipeBuilder work @mariakleiner did in Particle-space, and extends Graph capabilities into Application control.

New skel* apps here to express options for boilerplate 'best practice' or as templates for CLI or script construction.
New arcs app to express the This Document Can Host Any Graph(s) uber experience.

It would help me follow along if you briefly mention key things you were working on as part of this change in the PR description.

It would help me follow along if you briefly mention key things you were working on as part of this change in the PR description.

Heard! Added some notes.


A weird behavior on production build.

Hi!
Stack: nuxt.js + vue-lazy-hydration
Description: There is an interesting thing. On development mode this works well and load the component bundle when it's almost visible.

But in the production build, it doesn't load nothing when I scroll to the footer.
Is that a correct behavior?

any workarounds for this issue?

I can't reproduce it.


[C++][Parquet] TrackingAllocator is not thread-safe

Using parquet-cpp from different threads will use the same default_allocator() and thus we can have races on total_memory_
Reporter: Uwe Korn / @xhochy
Assignee: Uwe Korn](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=uwe) / @xhochy
Related issues:

parquet-cpp 1.0.0 release (blocks)

Note: This issue was originally created as PARQUET-775. Please see the migration documentation for further details.

Uwe Korn / @xhochy:
PR: https://github.com/apache/parquet-cpp/pull/190

Wes McKinney / @wesm:
Resolved in https://github.com/apache/parquet-cpp/commit/002466539f6aba7bf1f885b66f61f302ed88fa6b


Update Cloud Bigtable ALPN and client jars

The Cloud Bigtable client is now v0.2.1, and requires an updated ALPN jar.
Tested manually.

LGTM


[Agreements] Add back Tableau.Reader

cc @denelon @stephengillie
Installer prompt:

Microsoft Reviewers: Open in CodeFlow

This manifest contains a term that is blocked:

Custom: ACCEPTEULA=1   - AgreementLabel: TABLEAU READER END USER LICENSE AGREEMENT ("EULA")

(Automated response - build 763.)


change cargo toml in oracle + change println message

fix issue https://github.com/o1-labs/proof-systems/issues/398
not sure if i should remove --all-features in the ci as ocaml seems to be relying on this. lmk on this
also im sorry @mimoo for missing out the println message. hopefully you are ok with me fixing in the same pr.

Great, thanks @chee-chyuan!

my pleasure. happy to contribute and pick up some skills

Thanks a lot @chee-chyuan !!


Impl DELETE-CONTAINER

This patch implements compaction for deleted-containers.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (impl-compact@c5750f7). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             impl-compact    #2630   +/-   ##
===============================================
  Coverage                ?   19.56%
  Complexity              ?     2778
===============================================
  Files                   ?      806
  Lines                   ?    65319
  Branches                ?     7962
===============================================
  Hits                    ?    12780
  Misses                  ?    51355
  Partials                ?     1184

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Merging it as pending reviewer is busy with other stuff and this pr has been out for two weeks.


terraform-landscape: 0.2.0 -> 0.2.1

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build terraform-landscape

Somehow the build didn't start...
@GrahamcOfBorg build terraform-landscape

Success on aarch64-linux (full log)
Attempted: terraform-landscape
Partial log (click to expand)
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bkd1p3v0ix2pkgicxxqxqa0v4512lak7-ruby2.5.1-terraform_landscape-0.2.1
patching script interpreter paths in /nix/store/bkd1p3v0ix2pkgicxxqxqa0v4512lak7-ruby2.5.1-terraform_landscape-0.2.1
/nix/store/bkd1p3v0ix2pkgicxxqxqa0v4512lak7-ruby2.5.1-terraform_landscape-0.2.1/lib/ruby/gems/2.5.0/gems/terraform_landscape-0.2.1/bin/landscape: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/w2qgcck5ams1h0d5ydmaz8yfq4c1az87-ruby-2.5.1/bin/ruby"
checking for references to /build in /nix/store/bkd1p3v0ix2pkgicxxqxqa0v4512lak7-ruby2.5.1-terraform_landscape-0.2.1...
building '/nix/store/bkparsfhyl5l9nlkhlq9hcnms0b9wkkg-terraform_landscape-0.2.1.drv'...
created 29 symlinks in user environment
building '/nix/store/ap83nxap5kdi2zhjcd06sl0vy9pxw73w-terraform_landscape-0.2.1.drv'...
/nix/store/sa08zfyf7sdazyddyw0cil3gdrdxr8ga-terraform_landscape-0.2.1

Success on x86_64-darwin (full log)
Attempted: terraform-landscape
Partial log (click to expand)
  Gem home: /nix/store/pn7472hr28r25gilh5611jwgvvx3jiwq-ruby2.5.1-terraform_landscape-0.2.1/lib/ruby/gems/2.5.0
Successfully installed terraform_landscape-0.2.1
1 gem installed
post-installation fixup
patching script interpreter paths in /nix/store/pn7472hr28r25gilh5611jwgvvx3jiwq-ruby2.5.1-terraform_landscape-0.2.1
/nix/store/pn7472hr28r25gilh5611jwgvvx3jiwq-ruby2.5.1-terraform_landscape-0.2.1/lib/ruby/gems/2.5.0/gems/terraform_landscape-0.2.1/bin/landscape: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/7s5p6cwgz63pp1wgln9f7bg7sgy5jyrm-ruby-2.5.1/bin/ruby"
building '/nix/store/5w0rm0j9h8j1zp0i29f7jsx86zqsrx2h-terraform_landscape-0.2.1.drv'...
created 29 symlinks in user environment
building '/nix/store/gqni96i8nazvy8i112n6jbnsng6a8imx-terraform_landscape-0.2.1.drv'...
/nix/store/frn9rqvig1vxinni4bij6961myrh9v00-terraform_landscape-0.2.1

Success on x86_64-linux (full log)
Attempted: terraform-landscape
Partial log (click to expand)
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6fsmwyjp7m4ycgm4x66jhj3643sxji6c-ruby2.5.1-terraform_landscape-0.2.1
patching script interpreter paths in /nix/store/6fsmwyjp7m4ycgm4x66jhj3643sxji6c-ruby2.5.1-terraform_landscape-0.2.1
/nix/store/6fsmwyjp7m4ycgm4x66jhj3643sxji6c-ruby2.5.1-terraform_landscape-0.2.1/lib/ruby/gems/2.5.0/gems/terraform_landscape-0.2.1/bin/landscape: interpreter directive changed from "/usr/bin/env ruby" to "/nix/store/42lf7caji1bykgrzmf22a58sqyb9knjj-ruby-2.5.1/bin/ruby"
checking for references to /build in /nix/store/6fsmwyjp7m4ycgm4x66jhj3643sxji6c-ruby2.5.1-terraform_landscape-0.2.1...
building '/nix/store/rj2fj6dmrxbi1pbn1f3pgd1vq3wnlfl3-terraform_landscape-0.2.1.drv'...
created 29 symlinks in user environment
building '/nix/store/x24x23sphz36l3nbv16r7bxqv31jc1ih-terraform_landscape-0.2.1.drv'...
/nix/store/nl7bw9k3gc9jig8q9qf8pc5b405caslx-terraform_landscape-0.2.1


Using slots

I'm working on a package that makes heavy use of sympy and we would like symengine to be a drop-in replacement. Since in our context there might be anywhere from a few to hundreds of thousands of variables, I'd like to build the variables using __slots__.
That approach works perfectly when inheriting from sympy.Dummy but unfortunately not when subclassing from symengine.Symbol. (I'm building on top of symengine 0.3 so I couldn't find Dummy there.)
Would it be hard for you to redefine your Python class interface to use __slots__?

I'm not familiar with __slots__ can you give a small example that doesn't work?

Sure, please take a look at the https://gist.github.com/Midnighter/7dbb09274296bc48730fb61869ff18af). Basically, classes with slots are more compact and deterministic. However, if you don't define __slots__ in your class, Python automatically defines the __dict__ attribute for you. If any class in your parent hierarchy does this,  it is pointless to use slots in child classes because __dict__ is already defined. The linked StackOverflow answer in my above comment has a very extensive description and I recommend reading it when you have the time. Please note that in the notebook I also care about the __weakref__ attribute because my code needs it but that actually doesn't really relate to this issue.

Note that all symengine classes deriving from Basic has only one attribute. The pointer to the C++ object.
Cython extension classes like Basic has a mechanism similar to __slots__. So, if you do pi.__dict__ it will throw an error. (pi is an object of type Constant which is a Cython extension class)
All the classes in symengine used to be Cython extension classes and then some were changed to be regular Python classes so that __new__ could be used for simulating SymPy behaviour of Add(1, 2) returning an Integer class.
Symbol was changed to a regular Python class at 83bd7ae1daf94b6b7cac9bf224220b4d814cd933 and I'm not sure why. There are two options,

Change Symbol to be a Cython extension class
Define __slots__ = () in class Symbol

Both should work. I'm not sure which is the best. I guess we can go with 1 and which to option 2 if that doesn't work.
Can you send a PR with the above change and a test case?

Option 2. I can easily do, while for option 1. I feel that I know too little about symengine. However, if that is your preferred way I can make a suggestion and you can review it.

Option 1 is basically changing class Symbol(Expr) to cdef class Symbol(Expr)


Wrong supported Firefox versions for options.signDisplay parameter: negative value

The page for:
JavaScript built-in: Intl: NumberFormat: NumberFormat() constructor: options.signDisplay parameter: negative value
shows that Firefox added support in version 93, but it was added in version 116.

This data comes from MDN BCD (file here), please report the issue there, thanks!


Make wookmark available through npm?

Any reason wookmark isn't available through npm? Or am I just missing it?

Nope, just registered it ;) https://www.npmjs.com/package/wookmark

@Sebobo Thanks! Unfortunately the postinstall script is erroring out, preventing it from being installed without adding --ignore-scripts (i.e. npm install wookmark --ignore-scripts)... you may want to fix that.


React-Components: Add keys to dynamic children

An unique key-prop should always be provided to dynamic children. This PR adds the missing key props to <RegistryItem>s (entry._id) and its dependencies (running index).
See http://facebook.github.io/react/docs/multiple-components.html#dynamic-children for more information.

:+1:


Missing data when the model starts to run

I have intermittent problems where this error pops up when I hit the "run" button.

I believe this is because the initial species concentration list starts with a blank line with 'Enter Formula' as the species name. If you don't set any initial species concentrations, this error pops up. I'll work on this

I think this is fixed now. I updated music-box with the latest commits to interactive. Could you give it a try and see if it works now?

This error is no longer seems to be present


[client] Fix new day printing

Leaving this running overnight to see if it fixes the issue, but upon starting a new client instance, I already see day changed messages in-between two different messages on the same day.  For example:
10:38:03 group conversation started: foo
10:38:03 <jrick> bar
10:38:19 first message received on 2 January 2019
10:38:19 <marco> baz

This is how the client has always operated, but it still seems like a bug to me.  I would expect it to display:
10:38:03 group conversation started: foo
10:38:19 first message received on 2 January 2019 <- this is server time, not client time, and not sure what timestamp is actually best here
10:38:03 <jrick> bar
10:38:19 <marco> baz

or to just leave out the first day changed message entirely.


WIndows materials

Description of the new feature / enhancement
Add windows 11 materials, like acrylic and mica to power toys features as power toys run.
Scenario when this would be used?
In windows 11
Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/4794


Testing/class renaming and removing imports from init.py

Hi
A little cleanup to give test classes unique names.
Also included is removing imports from Tests/init.py. Do we need these there? Removing them doesn't seem to impact my testing workflow (pytest from command line and within vscode). Removing them avoids processing the files and allows you to run the tests in eg Cells.py even if eg Annotations.py has errors.
Cheers
Alex

Thanks for addressing the naming issues.
That's a fair point.
But if we remove those import, I can't right-click the folder in PyCharm and click Run TM1py Tests anymore 😄
How do you execute it from command without the imports in the init file?

Ah, OK, I thought it might be something to do with pycharm but wasn't sure. I tend to just run them from the command line, ie:
$ pytest -x Tests/*.py

I use vscode and the tests don't show up at all by default, it will only show tests with names like test_annotations so don't tend to run them that way. I'm not sure how pycharm does it.
It's not a huge deal, I can redo the PR to leave init.py intact if you like?

Thanks.
I think it's best to leave the imports as is.
Then everyone who uses PyCharm has an easy way to execute them and a visual interface.

Sure, makes sense. Let me close this one and raise a new PR, there's a lot of noise after I tried to merge other changes


Add Information about env vars into documentation

The Problem/Issue/Bug:
Not easy to find how to change / add env vars manually.
How this PR Solves The Problem:
add documentation
Manual Testing Instructions:
read documentation
Automated Testing Overview:
no
Related Issue Link(s):
Release/Deployment notes:

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Oh and thanks so much for your contribution and reaching out with another perspective!
Please do update the title and fill in the PR to make the case for this, even though IMO it should land elsewhere.

Agreed. Let's leave this PR open until we find a proper home in #659

We're about to make the main docker-compose.yaml ddev-managed, meaning that users will be making a mistake by editing it. We plan to allow it, but it's not going to be mainline. We also plan to allow explicit setting of environment variables in .ddev/config.yaml, https://github.com/drud/ddev/issues/757 .
With your permission I'd like to close this in favor of those future paths.

@kaystrobach I hope you can take a look at https://github.com/drud/ddev/pull/816 and see what you think. Thanks!


Training stops abruptly after every 4 epochs with streaming zipformer2 recipe

    train_dl_iter=iter(train_dl)
    #extra_dloaders = [iter(dloader_libri),iter(dload_gigaspeech),iter(dload_commonvoice)]

    batch_idx = 0
    previous_batch="open"

    while True:

        try:

            if previous_batch=="open":
                batch = next(train_dl_iter)
                previous_batch="main"
            else:
                chosen_dloader=random.choice(extra_train_dl)
                batch=next(chosen_dloader)
                previous_batch="open"

        except StopIteration:
            break

        if batch_idx % 10 == 0:
            set_batch_count(model, get_adjusted_batch_count(params))

        batch_idx += 1
        params.batch_idx_train += 1
        batch_size = len(batch["supervisions"]["text"])

        logging.info("compute_loss called by train_one_epoch- - ")

Context
We are using streaming zipformer2 recipe. But we made a change to handle multiple datasets during training - instead of using the same dataset, we are alternating between main dataset and one of the randomly chosen open source datasets every batch.
We face a problem with this setup. Training is stopping after every fourth epoch. For example, training ran fine till 4th epoch and stopped. Restarting from 5th epoch worked fine until 8th epoch after which it stopped. We tried computing WER with these models and the numbers look good. GPUs are getting maxed out. We did not notice any error message in logs.

We did not notice any error message in logs.

Are there any logs after the training stops?
Could you use print or logging.warning or logging.error to replace logging.info to get more logs if logging.info does not work?

There is nothing in log files specifically.
In one iteration where I started from 21st epoch, it ran fine till24th epoch but behaved weird from 25th epoch (did not stop but models were getting saved within 10 to 20 minutes). Log file corresponding to this is uploaded here. After last line in this, GPU got maxed out.
log.txt
Logs are getting printed but we did not get any relevant information to decode this issue.
Attaching the screen shot to show the timestamps at which model files are created. We can see that the usual time taken for an epoch is around 1.5 hours but from 25th epoch the pattern doesn't make sense.

Are you using multiple dataloaders?

Yes, we are using multiple dataloaders. We will look into this and update you. Thanks.

Just for the sake of completion and benefit of others, I would like to point out 2 things that caused the issue.

We were using AWS SageMaker, and when this happened, the model was no longer getting trained, but, the training job kept continuing (this was caused because the raise statement was missed in the Exception block), which caused one of the process to not return the status code correctly.

Unlike main dataset loader, for the extra datasets, we were not creating an iter of the dataloader inside train_one_epoch function(we had created in some other function), as a result, the extra data loaders weren't getting reset.

So basically not icefall related ...


adding credential storage template / variables

Adds template for Credential Storage.
Can optionally add the vault-secret-id file, if the user provides the file.  When no path to the file is provided in the task, Ansible automatically searches both the Role and the Playbook files directories.  However the Role directory is given precedence over the Playbook, which would mean that any default file provided in this Role would be included instead of any custom file created with the user's playbook. Hence, the decision was made to not include a sample/default file.

@kunickiaj just wanted to make sure you had seen this pull request too.
Thanks!


v4.0.0-beta.4 - [merged]

In GitLab by @ltenorio on Mar 19, 2024, 17:05
Merges v4.0.0-beta.4 -> master
Features:

[x] Improved Login page design with animations
[x] Updated About page #103
[x] Fix mandatory login redirect on unauthenticated case
[x] Added a button to periodically refresh the home page #104
[x] Fix submit written text on changing other options #102
[x] Hover all the experiment cards and not just the header on the home page
[x] Allow multiple select jobs to generate setstatus commands
[x] Migrated from vis-network to Cytoscape
[x] Add multiple select in graph/tree view
[x] Add select by status option in the graph view
[x] Add page size options on the experiment search

Waiting to get feedback from the CES and Climate DT users to extend the scope of this version

In GitLab by @ltenorio on Mar 26, 2024, 16:37
added 1 commit
488cef2d - improve graph focus
Compare with previous version

In GitLab by @ltenorio on Mar 21, 2024, 17:16
added 1 commit
8b444955 - added JobBasket component
Compare with previous version

In GitLab by @ltenorio on Mar 26, 2024, 11:54
marked the checklist item Allow multiple select jobs to generate setstatus commands as completed

In GitLab by @ltenorio on Mar 22, 2024, 13:53
Preview of the Multiple Job Selection feature:

In GitLab by @ltenorio on Apr 2, 2024, 15:17
added 1 commit
b239aa6b - fix fancy tree multiple select
Compare with previous version

In GitLab by @ltenorio on Mar 20, 2024, 13:46
marked the checklist item Hover all the experiment cards and not just the header on the home page as completed

In GitLab by @ltenorio on Mar 20, 2024, 13:46
added 1 commit
64174f51 - update experiment card hover
Compare with previous version

In GitLab by @ltenorio on Apr 3, 2024, 12:01
added 1 commit
ef80dbb4 - add bottom panel in graph view
Compare with previous version

In GitLab by @ltenorio on Apr 2, 2024, 14:28
added 1 commit
39ecd378 - add Cytoscape to the Graph View
Compare with previous version

In GitLab by @ltenorio on Apr 3, 2024, 12:11
Migrated to Cytoscape and added a bottom panel to the graph view

In GitLab by @ltenorio on Apr 3, 2024, 15:37
added 1 commit
318434e5 - select by status in graph view
Compare with previous version

In GitLab by @ltenorio on Apr 3, 2024, 15:09
added 1 commit
a20e24d4 - Home page improvements
Compare with previous version

In GitLab by @ltenorio on Apr 5, 2024, 10:22
added 1 commit
67be9a47 - fix graph multiple select performance issue
Compare with previous version

In GitLab by @ltenorio on Apr 3, 2024, 15:40
marked the checklist item Add select by status option in graph view as completed

In GitLab by @ltenorio on Apr 5, 2024, 17:05
added 1 commit
a5870031 - refactor fancy tree
Compare with previous version

In GitLab by @ltenorio on Apr 16, 2024, 11:02
added 1 commit
9a3be77a - add tree, performance and stats tests
Compare with previous version

In GitLab by @ltenorio on Apr 9, 2024, 09:54
added 1 commit
626e06d6 - add localstorage save to bottom panel
Compare with previous version

In GitLab by @ltenorio on Apr 12, 2024, 14:31
added 1 commit
178342eb - add more filters in exp search
Compare with previous version

In GitLab by @ltenorio on Apr 10, 2024, 12:05
added 1 commit
192eb3e2 - adding react hook form
Compare with previous version

In GitLab by @ltenorio on Apr 26, 2024, 16:16
added 1 commit
b22d4183 - lint fixes & improvements
Compare with previous version

In GitLab by @ltenorio on May 2, 2024, 15:27
added 2 commits
e018a09e - 1 commit from branch master6a584e01 - Merge branch 'master' into 'v4.0.0-beta.4'
Compare with previous version

In GitLab by @ltenorio on Apr 26, 2024, 13:06
added 7 commits
3c0cc06e - initial docse28738be - old pages reviewbd5bb559 - add installation instructionsb21c033a - add landing pagea2f5fb4a - add .readthedocs.yaml75e462ca - add sponsor logo optionca559ecf - Merge branch 'read-the-docs' into 'v4.0.0-beta.4'
Compare with previous version

In GitLab by @ltenorio on May 2, 2024, 15:27
mentioned in commit fb3f3c815fab89807049dcc3628ea344956d8d6f

In GitLab by @ltenorio on May 2, 2024, 15:27
approved this merge request

In GitLab by @ltenorio on Apr 18, 2024, 13:43
added 1 commit
e15dc8bb - add statistics tooltip
Compare with previous version

In GitLab by @ltenorio on May 2, 2024, 11:34
added 1 commit
af769c17 - improve copy to clipboard button
Compare with previous version


V3

What?
Opening a draft PR for now containing all the changes made as part of v3.
Why?
Getting ready to release.

          1 Warning

:warning:
Any changes to library code should be reflected in the Changelog. Please consider adding a note there. \nYou can find it at CHANGELOG.md.

SwiftLint found issues
Warnings

File
Line
Reason

ChatManager.swift
131
TODOs should be avoided (This could be nicer).

ChatManager.swift
132
TODOs should be avoided (Do we need to nil out subscrip...).

ChatManager.swift
151
TODOs should be avoided (This is madness).

ChatManager.swift
281
TODOs should be avoided (Maybe we need some sort of Cha...).

ChatManager.swift
351
TODOs should be avoided (When can percent encoding fail...).

ChatManager.swift
110
Function should have complexity 10 or less: currently complexity equals 12

ChatManager.swift
110
Function body should span 40 lines or less excluding comments and whitespace: currently spans 100 lines

ChatManager.swift
355
Limit vertical whitespace to a single empty line. Currently 2.

ChatManager.swift
69
Lines should not have trailing whitespace.

ChatManager.swift
253
Arguments can be omitted when matching enums with associated types if they are not used.

ChatManager.swift
134
Variable name should be between 3 and 40 characters long: 'cu'

ChatManager.swift
342
Opening braces should be preceded by a single space and on the same line as the declaration.

ChatManager.swift
214
Line should be 120 characters or less: currently 129 characters

ChatManager.swift
240
Line should be 120 characters or less: currently 126 characters

ChatManager.swift
410
File should contain 400 lines or less: currently contains 410

PCBasicMessage.swift
4
Variable name should be between 3 and 40 characters long: 'id'

PCBasicMessage.swift
10
Variable name should be between 3 and 40 characters long: 'id'

PCBasicMessage.swift
16
Variable name should be between 3 and 40 characters long: 'id'

PCBasicMessageEnricher.swift
103
TODOs should be avoided (There may well be ways to make...).

PCBasicMessageEnricher.swift
19
Lines should not have trailing whitespace.

PCBasicMessageEnricher.swift
148
Lines should not have trailing whitespace.

PCBasicMessageEnricher.swift
154
Files should have a single trailing newline.

PCBasicMessageEnricher.swift
17
Variable name should be between 3 and 40 characters long: 'messagesAwaitingEnrichmentDependentOnUserRetrieval'

PCBasicMessageEnricher.swift
101
Variable name should be between 3 and 40 characters long: 'id'

PCBasicMessageEnricher.swift
13
Line should be 120 characters or less: currently 127 characters

PCBasicMessageEnricher.swift
64
Line should be 120 characters or less: currently 159 characters

PCBasicMessageEnricher.swift
67
Line should be 120 characters or less: currently 138 characters

PCBasicMessageEnricher.swift
74
Line should be 120 characters or less: currently 132 characters

PCBasicMessageEnricher.swift
97
Line should be 120 characters or less: currently 155 characters

PCBasicMessageEnricher.swift
101
Line should be 120 characters or less: currently 132 characters

PCBasicMessageEnricher.swift
106
Line should be 120 characters or less: currently 136 characters

PCBasicMessageEnricher.swift
116
Line should be 120 characters or less: currently 133 characters

PCBasicMessageEnricher.swift
145
Line should be 120 characters or less: currently 145 characters

PCCurrentUser.swift
1235
Else and catch should be on the same line, one space after the previous declaration.

PCCurrentUser.swift
1238
Else and catch should be on the same line, one space after the previous declaration.

PCCurrentUser.swift
1241
Else and catch should be on the same line, one space after the previous declaration.

PCCurrentUser.swift
1244
Else and catch should be on the same line, one space after the previous declaration.

PCCurrentUser.swift
1247
Else and catch should be on the same line, one space after the previous declaration.

PCCurrentUser.swift
26
TODOs should be avoided (This should probably be [PCUse...).

PCCurrentUser.swift
436
TODOs should be avoided (Use the soon-to-be-created new...).

PCCurrentUser.swift
526
TODOs should be avoided (Do we need to fetch users in t...).

PCCurrentUser.swift
760
TODOs should be avoided (Do we need a Last-Event-ID opt...).

PCCurrentUser.swift
1123
TODOs should be avoided (What to do with an error? Just...).

PCCurrentUser.swift
935
Function body should span 40 lines or less excluding comments and whitespace: currently spans 53 lines

PCCurrentUser.swift
695
Lines should not have trailing whitespace.

PCCurrentUser.swift
702
Lines should not have trailing whitespace.

PCCurrentUser.swift
705
Lines should not have trailing whitespace.

PCCurrentUser.swift
716
Lines should not have trailing whitespace.

PCCurrentUser.swift
719
Lines should not have trailing whitespace.

PCCurrentUser.swift
788
Lines should not have trailing whitespace.

PCCurrentUser.swift
804
Lines should not have trailing whitespace.

PCCurrentUser.swift
905
Lines should not have trailing whitespace.

PCCurrentUser.swift
929
Lines should not have trailing whitespace.

PCCurrentUser.swift
934
Lines should not have trailing whitespace.

PCCurrentUser.swift
947
Lines should not have trailing whitespace.

PCCurrentUser.swift
951
Lines should not have trailing whitespace.

PCCurrentUser.swift
955
Lines should not have trailing whitespace.

PCCurrentUser.swift
957
Lines should not have trailing whitespace.

PCCurrentUser.swift
965
Lines should not have trailing whitespace.

PCCurrentUser.swift
970
Lines should not have trailing whitespace.

PCCurrentUser.swift
975
Lines should not have trailing whitespace.

PCCurrentUser.swift
979
Lines should not have trailing whitespace.

PCCurrentUser.swift
990
Lines should not have trailing whitespace.

PCCurrentUser.swift
992
Lines should not have trailing whitespace.

PCCurrentUser.swift
997
Lines should not have trailing whitespace.

PCCurrentUser.swift
1004
Lines should not have trailing whitespace.

PCCurrentUser.swift
1009
Lines should not have trailing whitespace.

PCCurrentUser.swift
1013
Lines should not have trailing whitespace.

PCCurrentUser.swift
1016
Lines should not have trailing whitespace.

PCCurrentUser.swift
216
MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...'

PCCurrentUser.swift
311
MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...'

PCCurrentUser.swift
678
Arguments can be omitted when matching enums with associated types if they are not used.

PCCurrentUser.swift
678
Arguments can be omitted when matching enums with associated types if they are not used.

PCCurrentUser.swift
8
Variable name should be between 3 and 40 characters long: 'id'

PCCurrentUser.swift
65
Variable name should be between 3 and 40 characters long: 'id'

PCCurrentUser.swift
186
Variable name should be between 3 and 40 characters long: 'id'

PCCurrentUser.swift
203
Variable name should be between 3 and 40 characters long: 'id'

PCCurrentUser.swift
252
Variable name should be between 3 and 40 characters long: 'id'

PCCurrentUser.swift
328
Variable name should be between 3 and 40 characters long: 'id'

PCCurrentUser.swift
388
Variable name should be between 3 and 40 characters long: 'id'

PCCurrentUser.swift
126
Collection literals should not have trailing commas.

PCCurrentUser.swift
729
Opening braces should be preceded by a single space and on the same line as the declaration.

PCCurrentUser.swift
207
Line should be 120 characters or less: currently 122 characters

PCCurrentUser.swift
557
Line should be 120 characters or less: currently 143 characters

PCCurrentUser.swift
585
Line should be 120 characters or less: currently 121 characters

PCCurrentUser.swift
611
Line should be 120 characters or less: currently 147 characters

PCCurrentUser.swift
616
Line should be 120 characters or less: currently 147 characters

PCCurrentUser.swift
638
Line should be 120 characters or less: currently 133 characters

PCCurrentUser.swift
646
Line should be 120 characters or less: currently 139 characters

PCCurrentUser.swift
649
Line should be 120 characters or less: currently 134 characters

PCCurrentUser.swift
706
Line should be 120 characters or less: currently 124 characters

PCCurrentUser.swift
720
Line should be 120 characters or less: currently 124 characters

PCCurrentUser.swift
772
Line should be 120 characters or less: currently 123 characters

PCCurrentUser.swift
814
Line should be 120 characters or less: currently 128 characters

PCCurrentUser.swift
976
Line should be 120 characters or less: currently 123 characters

PCCurrentUser.swift
1078
Line should be 120 characters or less: currently 136 characters

PCCurrentUser.swift
1230
Line should be 120 characters or less: currently 122 characters

PCMessage.swift
46
Operators should be surrounded by a single whitespace when defining them.

PCMessage.swift
4
Variable name should be between 3 and 40 characters long: 'id'

PCMessage.swift
16
Variable name should be between 3 and 40 characters long: 'id'

PCMessage.swift
36
Line should be 120 characters or less: currently 130 characters

PCMessageSubscription.swift
87
TODOs should be avoided (Should we call the delegate er...).

PCMessageSubscription.swift
69
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
236
Limit vertical whitespace to a single empty line. Currently 2.

PCPayloadDeserializer.swift
171
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
183
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
185
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
195
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
208
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
219
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
223
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
227
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
231
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
235
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
236
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
241
Lines should not have trailing whitespace.

PCPayloadDeserializer.swift
20
Variable name should be between 3 and 40 characters long: 'id'

PCPayloadDeserializer.swift
174
Variable name should be between 3 and 40 characters long: 'id'

PCPayloadDeserializer.swift
198
Variable name should be between 3 and 40 characters long: 'id'

PCPayloadDeserializer.swift
67
Line should be 120 characters or less: currently 145 characters

PCPayloadDeserializer.swift
100
Line should be 120 characters or less: currently 156 characters

PCPayloadDeserializer.swift
140
Line should be 120 characters or less: currently 122 characters

PCPayloadDeserializer.swift
145
Line should be 120 characters or less: currently 161 characters

PCPayloadDeserializer.swift
160
Line should be 120 characters or less: currently 148 characters

PCPayloadDeserializer.swift
181
Line should be 120 characters or less: currently 158 characters

PCPayloadDeserializer.swift
206
Line should be 120 characters or less: currently 163 characters

PCPayloadDeserializer.swift
222
Line should be 120 characters or less: currently 142 characters

PCPayloadDeserializer.swift
225
Line should be 120 characters or less: currently 141 characters

PCPayloadDeserializer.swift
229
Line should be 120 characters or less: currently 133 characters

PCPayloadDeserializer.swift
251
Line should be 120 characters or less: currently 141 characters

PCReadCursorDebouncerManager.swift
29
Initializing an optional variable with nil is redundant.

PCReadCursorDebouncerManager.swift
12
Line should be 120 characters or less: currently 124 characters

PCRoomDelegate.swift
21
TODOs should be avoided (This should be unnecessary).

PCRoomSubscription.swift
219
TODOs should be avoided (What happens if you provide bo...).

PCRoomSubscription.swift
16
Function body should span 40 lines or less excluding comments and whitespace: currently spans 100 lines

PCRoomSubscription.swift
61
Lines should not have trailing whitespace.

PCRoomSubscription.swift
129
Lines should not have trailing whitespace.

PCRoomSubscription.swift
181
Lines should not have trailing whitespace.

PCRoomSubscription.swift
185
Lines should not have trailing whitespace.

PCRoomSubscription.swift
285
Lines should not have trailing whitespace.

PCRoomSubscription.swift
295
Lines should not have trailing whitespace.

PCRoomSubscription.swift
321
Lines should not have trailing whitespace.

PCRoomSubscription.swift
331
Lines should not have trailing whitespace.

PCRoomSubscription.swift
333
Lines should not have trailing whitespace.

PCRoomSubscription.swift
336
Function should have 5 parameters or less: it currently has 6

PCRoomSubscription.swift
390
Function should have 5 parameters or less: it currently has 8

PCRoomSubscription.swift
78
Line should be 120 characters or less: currently 146 characters

PCRoomSubscription.swift
111
Line should be 120 characters or less: currently 146 characters

PCRoomSubscription.swift
135
Line should be 120 characters or less: currently 145 characters

PCRoomSubscription.swift
9
Delegates should be weak to avoid reference cycles.

PCRoomSubscription.swift
448
File should contain 400 lines or less: currently contains 448

ChatManagerTests.swift
30
Lines should not have trailing whitespace.

ChatManagerTests.swift
24
Line should be 120 characters or less: currently 145 characters

ChatManagerTests.swift
25
Line should be 120 characters or less: currently 145 characters

CurrentUserTests.swift
19
Function body should span 40 lines or less excluding comments and whitespace: currently spans 67 lines

CurrentUserTests.swift
97
Variable name should be between 3 and 40 characters long: 'ex'

TestingDelegates.swift
40
Returning Void in a function declaration is redundant.

TestingDelegates.swift
44
Returning Void in a function declaration is redundant.

TestingDelegates.swift
111
Returning Void in a function declaration is redundant.

TestingDelegates.swift
115
Returning Void in a function declaration is redundant.

TestingDelegates.swift
119
Returning Void in a function declaration is redundant.

TestingDelegates.swift
138
Lines should not have trailing whitespace.

MessageTests.swift
647
Function body should span 40 lines or less excluding comments and whitespace: currently spans 64 lines

MessageTests.swift
747
Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines

MessageTests.swift
812
Function body should span 40 lines or less excluding comments and whitespace: currently spans 44 lines

MessageTests.swift
23
When using trailing closures, empty parentheses should be avoided after the method call.

MessageTests.swift
30
When using trailing closures, empty parentheses should be avoided after the method call.

MessageTests.swift
9
Lines should not have trailing whitespace.

MessageTests.swift
161
Lines should not have trailing whitespace.

MessageTests.swift
164
Lines should not have trailing whitespace.

MessageTests.swift
167
Lines should not have trailing whitespace.

MessageTests.swift
175
Lines should not have trailing whitespace.

MessageTests.swift
182
Lines should not have trailing whitespace.

MessageTests.swift
188
Lines should not have trailing whitespace.

MessageTests.swift
193
Lines should not have trailing whitespace.

MessageTests.swift
205
Lines should not have trailing whitespace.

MessageTests.swift
208
Lines should not have trailing whitespace.

MessageTests.swift
214
Lines should not have trailing whitespace.

MessageTests.swift
221
Lines should not have trailing whitespace.

MessageTests.swift
225
Lines should not have trailing whitespace.

MessageTests.swift
234
Lines should not have trailing whitespace.

MessageTests.swift
240
Lines should not have trailing whitespace.

MessageTests.swift
243
Lines should not have trailing whitespace.

MessageTests.swift
249
Lines should not have trailing whitespace.

MessageTests.swift
256
Lines should not have trailing whitespace.

MessageTests.swift
262
Lines should not have trailing whitespace.

MessageTests.swift
267
Lines should not have trailing whitespace.

MessageTests.swift
335
Lines should not have trailing whitespace.

MessageTests.swift
338
Lines should not have trailing whitespace.

MessageTests.swift
341
Lines should not have trailing whitespace.

MessageTests.swift
344
Lines should not have trailing whitespace.

MessageTests.swift
352
Lines should not have trailing whitespace.

MessageTests.swift
355
Lines should not have trailing whitespace.

MessageTests.swift
358
Lines should not have trailing whitespace.

MessageTests.swift
361
Lines should not have trailing whitespace.

MessageTests.swift
369
Lines should not have trailing whitespace.

MessageTests.swift
378
Lines should not have trailing whitespace.

MessageTests.swift
381
Lines should not have trailing whitespace.

MessageTests.swift
384
Lines should not have trailing whitespace.

MessageTests.swift
387
Lines should not have trailing whitespace.

MessageTests.swift
396
Lines should not have trailing whitespace.

MessageTests.swift
408
Lines should not have trailing whitespace.

MessageTests.swift
411
Lines should not have trailing whitespace.

MessageTests.swift
503
Lines should not have trailing whitespace.

MessageTests.swift
506
Lines should not have trailing whitespace.

MessageTests.swift
508
Lines should not have trailing whitespace.

MessageTests.swift
517
Lines should not have trailing whitespace.

MessageTests.swift
522
Lines should not have trailing whitespace.

MessageTests.swift
525
Lines should not have trailing whitespace.

MessageTests.swift
528
Lines should not have trailing whitespace.

MessageTests.swift
535
Lines should not have trailing whitespace.

MessageTests.swift
544
Lines should not have trailing whitespace.

MessageTests.swift
547
Lines should not have trailing whitespace.

MessageTests.swift
550
Lines should not have trailing whitespace.

MessageTests.swift
555
Lines should not have trailing whitespace.

MessageTests.swift
558
Lines should not have trailing whitespace.

MessageTests.swift
564
Lines should not have trailing whitespace.

MessageTests.swift
569
Lines should not have trailing whitespace.

MessageTests.swift
574
Lines should not have trailing whitespace.

MessageTests.swift
577
Lines should not have trailing whitespace.

MessageTests.swift
580
Lines should not have trailing whitespace.

MessageTests.swift
587
Lines should not have trailing whitespace.

MessageTests.swift
596
Lines should not have trailing whitespace.

MessageTests.swift
599
Lines should not have trailing whitespace.

MessageTests.swift
602
Lines should not have trailing whitespace.

MessageTests.swift
607
Lines should not have trailing whitespace.

MessageTests.swift
610
Lines should not have trailing whitespace.

MessageTests.swift
616
Lines should not have trailing whitespace.

MessageTests.swift
621
Lines should not have trailing whitespace.

MessageTests.swift
624
Lines should not have trailing whitespace.

MessageTests.swift
627
Lines should not have trailing whitespace.

MessageTests.swift
634
Lines should not have trailing whitespace.

MessageTests.swift
643
Lines should not have trailing whitespace.

MessageTests.swift
97
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
125
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
163
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
198
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
239
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
272
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
304
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
337
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
357
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
383
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
413
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
505
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
549
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
601
Variable name should be between 3 and 40 characters long: 'ex'

MessageTests.swift
171
Line should be 120 characters or less: currently 138 characters

MessageTests.swift
200
Line should be 120 characters or less: currently 139 characters

MessageTests.swift
201
Line should be 120 characters or less: currently 142 characters

MessageTests.swift
202
Line should be 120 characters or less: currently 144 characters

MessageTests.swift
203
Line should be 120 characters or less: currently 150 characters

MessageTests.swift
345
Line should be 120 characters or less: currently 132 characters

MessageTests.swift
365
Line should be 120 characters or less: currently 142 characters

MessageTests.swift
370
Line should be 120 characters or less: currently 136 characters

MessageTests.swift
391
Line should be 120 characters or less: currently 143 characters

MessageTests.swift
392
Line should be 120 characters or less: currently 161 characters

MessageTests.swift
539
Line should be 120 characters or less: currently 131 characters

MessageTests.swift
556
Line should be 120 characters or less: currently 169 characters

MessageTests.swift
557
Line should be 120 characters or less: currently 155 characters

MessageTests.swift
591
Line should be 120 characters or less: currently 131 characters

MessageTests.swift
608
Line should be 120 characters or less: currently 169 characters

MessageTests.swift
609
Line should be 120 characters or less: currently 155 characters

MessageTests.swift
638
Line should be 120 characters or less: currently 131 characters

MessageTests.swift
878
File should contain 400 lines or less: currently contains 878

RoomEventBufferingTests.swift
6
Type body should span 200 lines or less excluding comments and whitespace: currently spans 230 lines

RoomEventBufferingTests.swift
70
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.

RoomEventBufferingTests.swift
71
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.

RoomEventBufferingTests.swift
76
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.

RoomEventBufferingTests.swift
77
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.

RoomEventBufferingTests.swift
94
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.

RoomEventBufferingTests.swift
95
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.

PCBasicMultipartMessage.swift
4
Variable name should be between 3 and 40 characters long: 'id'

PCMultipartMessage.swift
43
Operators should be surrounded by a single whitespace when defining them.

PCMultipartMessage.swift
11
Lines should not have trailing whitespace.

PCMultipartMessage.swift
14
Lines should not have trailing whitespace.

PCMultipartMessage.swift
42
Lines should not have trailing whitespace.

PCMultipartMessage.swift
7
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.

PCMultipartMessage.swift
5
Variable name should be between 3 and 40 characters long: 'id'

PCMultipartMessage.swift
16
Variable name should be between 3 and 40 characters long: 'id'

PCMultipartMessage.swift
84
Variable name should be between 3 and 40 characters long: 'id'

Errors

File
Line
Reason

ChatManager.swift
329
Variable name should be between 3 and 40 characters long: 'c'

ChatManager.swift
383
Line should be 120 characters or less: currently 366 characters

ChatManager.swift
392
Line should be 120 characters or less: currently 248 characters

PCBasicMessageEnricher.swift
150
Enum element name should only contain alphanumeric characters: 'success(_:)'

PCBasicMessageEnricher.swift
151
Enum element name should only contain alphanumeric characters: 'error(_:)'

PCCurrentUser.swift
7
Type body should span 200 lines or less excluding comments and whitespace: currently spans 712 lines

PCCurrentUser.swift
769
Variable name should be between 3 and 40 characters long: 'r'

PCCurrentUser.swift
811
Variable name should be between 3 and 40 characters long: 'r'

PCCurrentUser.swift
1147
Variable name should be between 3 and 40 characters long: 'm'

PCCurrentUser.swift
1153
Enum element name should only contain alphanumeric characters: 'noSubscriptionToRoom(_:)'

PCCurrentUser.swift
1181
Enum element name should only contain alphanumeric characters: 'messageIDKeyMissingInMessageCreationResponse(_:)'

PCCurrentUser.swift
1253
File should contain 400 lines or less: currently contains 1253

PCPayloadDeserializer.swift
259
Enum element name should only contain alphanumeric characters: 'incompleteOrInvalidPayloadToCreteEntity(type:payload:)'

PCPayloadDeserializer.swift
18
Function should have 5 parameters or less: it currently has 14

PCRoomSubscription.swift
206
Function should have 5 parameters or less: it currently has 9

PCRoomSubscription.swift
273
Function should have 5 parameters or less: it currently has 9

ChatManagerTests.swift
24
Force casts should be avoided.

ChatManagerTests.swift
25
Force casts should be avoided.

MessageTests.swift
5
Type body should span 200 lines or less excluding comments and whitespace: currently spans 572 lines

MessageTests.swift
687
Variable name should be between 3 and 40 characters long: 'b'

MessageTests.swift
773
Variable name should be between 3 and 40 characters long: 'b'

MessageTests.swift
839
Variable name should be between 3 and 40 characters long: 'b'

RoomEventBufferingTests.swift
19
Function body should span 40 lines or less excluding comments and whitespace: currently spans 222 lines

PCMultipartMessage.swift
63
Enum element name should only contain alphanumeric characters: 'inlinePayload(payload:)'

PCMultipartMessage.swift
64
Enum element name should only contain alphanumeric characters: 'urlPayload(payload:)'

PCMultipartMessage.swift
65
Enum element name should only contain alphanumeric characters: 'attachmentPayload(payload:)'

PCMultipartMessage.swift
76
Line should be 120 characters or less: currently 253 characters

  Generated by :no_entry_sign: Danger


TD.2.3 Implement Player and adapt to discussed changes

@tikost add code and close

9c64e414b017543a2b22d7eee851f6a736a49b09
bbf673a5b64427405cd922530687bfed4476e1cc


add critical tv smacking feature back in

importance: verily

I have no idea what this is meant to do?

I don't get the reference for "smack tv", and I hate seeing the words there, but this is actually kind of cool. The canvas (tv screen) has a filter on it to make it look like there are scanlines. This makes it so when you click the little steam logo it changes that filter. It has a couple different effects you can cycle through.

Although this patch doesn't seem to contain that code. I think maybe tubersan submitted the wrong patch, or the reversions have confused git's diff.

Sorry, but something seems to have screwed up your pull request? I put part of it back. If you intended on adding anything else that I missed please open a new pull request.

Mmh, I had changed the code so that the Smack TV words are next to the TV and not on the little steam logo anymore, it should look something like this: https://i.nope.bz/05XK.png (notice the "Smack TV" on the left and right of the screen)
Should I submit another PR that puts the button/link for smacking in that place instead of where it is now?