Can't browse server in production

I use django-ckeditor, django-storage and digitalocean.
# CKEditor configurations
CKEDITOR_UPLOAD_PATH = "wysiwyg/"
CKEDITOR_ALLOW_NONIMAGE_FILES = False
CKEDITOR_RESTRICT_BY_DATE = False
CKEDITOR_IMAGE_BACKEND = "pillow"
CKEDITOR_BROWSE_SHOW_DIRS = True

# Django storage. Only used in production.
if not DEBUG:
    DEFAULT_FILE_STORAGE = "storages.backends.s3boto3.S3Boto3Storage"
    AWS_QUERYSTRING_AUTH = False
    AWS_ACCESS_KEY_ID = env("DIGITALOCEAN_ACCESS_KEY")
    AWS_SECRET_ACCESS_KEY = env("DIGITALOCEAN_SECRET_ACCESS_KEY")
    AWS_STORAGE_BUCKET_NAME = "media"
    AWS_DEFAULT_ACL = "public-read"
    AWS_S3_ENDPOINT_URL = "https://xxxxxxx.ams3.digitaloceanspaces.com"

So I only use digitalocean in production. Uploading and displaying images is no problem but I can't use the "Browse Server" function. I get a 500 error

Basically, the exact same issue as described here on SO; https://stackoverflow.com/questions/66658818/i-cant-browse-server-files-with-django-ckeditor
One thing that comes to mind is that the pop-up window for browsing is requesting my app's URL but the files are on DO.
https://xxxx.herokuapp.com/ckeditor/browse/?CKEditor=id_description&CKEditorFuncNum=3&langCode=en
But I'm not sure.
Worth noting is that everything else works fine. Uploading and browsing locally and uploading in production.
Thank you!

It's practically impossible to tell what's going on here without a stacktrace or some other sort of debugging information. You should probably set up your app to send mails on server crashes (that's the default behavior of Django) or log errors to Sentry or something.

I will look into that.
The logs look like;
2022-07-11T14:36:39.562423+00:00 heroku[router]: at=info method=GET path="/static/ckeditor/ckeditor/plugins/scayt/dialogs/dialog.css?t=L4KA" host=xxxxx.herokuapp.com request_id=08585113-708a-47a8-b11b-f68074259927 fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=7ms status=200 bytes=725 protocol=https
2022-07-11T14:36:41.086055+00:00 heroku[router]: at=info method=GET path="/static/ckeditor/ckeditor/skins/moono-lisa/images/hidpi/lock.png" host=xxxxx.herokuapp.com request_id=4b207a18-0908-46f1-b24e-a2b3d8a4a278 fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=2ms status=200 bytes=1479 protocol=https
2022-07-11T14:36:47.302304+00:00 heroku[router]: at=info method=GET path="/ckeditor/browse/?CKEditor=id_description&CKEditorFuncNum=3&langCode=en" host=xxxxx.herokuapp.com request_id=a26df5e0-9895-49a5-8e4e-f2674a31b90e fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=336ms status=500 bytes=482 protocol=https

Changed to store the files on S3 instead and it works. I think the problem was with digitalocean and the folder permission(which seems to be quite a hassle https://www.digitalocean.com/community/questions/how-to-make-my-spaces-public)
So I guess it a digitalocean problem more than a django-ckeditor problem.


[Distributed] fix session cache leader interface and docs

As cluster_new is closing to merge into master, It is better not to open the leader cache by default and give an parameter interface for distributed IoTDB, otherwise it will cause unnecessary performance waste to the stand-alone IoTDB.

As cluster_new has been merged into cluster using squash, this PR is not able to merge into master. So I have closed this PR and create a new one base on master's latest commit.


update deprecated chars function

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (556764a) 52.64% compared to head (0691070) 53.70%.

:exclamation: Current head 0691070 differs from pull request most recent head a9cb8cf. Consider uploading reports for the commit a9cb8cf to get more accurate results

Files
Patch %
Lines

R/Utilities.R
75.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #380      +/-   ##
===========================================
+ Coverage    52.64%   53.70%   +1.05%
===========================================
  Files           13       13
  Lines         3210     3212       +2
===========================================
+ Hits          1690     1725      +35
+ Misses        1520     1487      -33

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bluetooth: Add BT_GAP_ADV_PROPs for report data status

When the controller reports advertising data, the advertisement data
may be split into multiple reports. In order to decode the data, the
application must know if the report is complete and if it is the first,
intermediate, or last fragment.
Another approach would have been to accumulating the data in the host
until the data is complete. That would require additional memory
management.
Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/37368
Extended an existing tests to validate that the
BT_GAP_ADV_PROP_REPORT_LAST is correctly set.
Signed-off-by: Rubin Gerritsen<EMAIL_ADDRESS>

Another approach would have been to accumulating the data in the host
until the data is complete. That would require additional memory
management.

So we should decide if we wish to have the host recombine the advertising fragments or if the application is responsible for this.
It would make more sense to do it in the host IMO.
We should probably have a different net_buf for recombination of advertising data with a configuration option to store the data since I don't think holding a reference to the HCI event buffer is a good idea in this case.

So we should decide if we wish to have the host recombine the advertising fragments or if the application is responsible for this

I've created https://github.com/zephyrproject-rtos/zephyr/issues/37368 to track this decision. We could consider moving the discussion there.

It would make more sense to do it in the host IMO.

Yeah, we agree @Thalley

https://github.com/zephyrproject-rtos/zephyr/pull/37377 implements advertising data reassembly in the host.

@Thalley Based on discussion in the Reassamble PR it seems that @rugeGerritsen wishes to proceed with this approach instead.
Any more input on this?

@Thalley Based on discussion in the Reassamble PR it seems that @rugeGerritsen wishes to proceed with this approach instead.
Any more input on this?

I'm in a bit of a pickle regarding this. I don't think offloading the reassembly to the upper layers is a good API, but given the lack of start status of the advertising events, and the several ways the controller may behave in regards to sending the segments, the host stack cannot really ensure any correctness either, and would require a tremendous amount of memory to handle different cases.
The reassembly may be complex, which would be for the upper layers to implement, but on the other hand the upper layers may, as @rugeGerritsen have also mentioned, be better suited to determine how to handle based on the data.
So if we want the host stack to be controller and application agnostic, I think we need to offload it to the application (perhaps we can provide helper functions to alleviate some of the complexity) as is done in this PR.

@Thalley , thanks for your feedback. Let me know if you want to keep the question open for some more time allow others to provide their input.

@rugeGerritsen I'd like to recheck the spec regarding the way that segmentation and reassembly is done. I find it odd that the behavior of the controller is so undefined.
The paragraph from the core spec that made me only consider the case where the controller receives the full advertising data (up to 1650 octets) and can then split it into multiple (sequential) events is this:
The Controller may split the data from a **single** advertisement or scan response
(whether one PDU or several) into **several reports**. If so, each report except the
last shall have an Event_Type with a data status field of "incomplete, more data
to come", while the last shall have the value "complete"; the Address_Type,
Address, Advertising_SID, Primary_PHY, and Secondary_PHY fields shall be
the same in all the reports. No further reports shall be sent for a given
advertisement or scan response after one with a Data_Status other than
"incomplete, more data to come".

At least to me that paragraph states that the controller may take a full advertising report and split it up when sending over HCI, but it cannot just send fragments whenever it wants as @sjanc mentioned the NimBLE controller does in https://github.com/zephyrproject-rtos/zephyr/pull/37377#issuecomment-891757854.

@Thalley , you found the phrasing we needed. It clearly states that interleaving advertising reports is not allowed. @sjanc, you mentioned that the nimBLE controller is interleaving the reports. Do you agree that this is not as per spec requirements?

@Thalley , you found the phrasing we needed. It clearly states that interleaving advertising reports is not allowed. @sjanc, you mentioned that the nimBLE controller is interleaving the reports. Do you agree that this is not as per spec requirements?

@andrzej-kaczmarek @sjanc @ppryga any comments on this? We need to decide between the approach in this PR and the one in #37377

@cvinayak May also have some input here

If the Controller receives an ADV_EXT_IND PDU with an AuxPtr field, it shall
delay the report until after the corresponding AUX_ADV_IND PDU has been
received and the report shall combine the information in the PDUs; if the
Controller does not listen for or does not receive the AUX_ADV_IND PDU, no
report shall be generated.

@cvinayak :

isnt this only for primary and first auxiliary channel PDU?  is there something similar for AUX_CHAIN_IND PDU ?

@Thalley :

I am not sure. I can't find much more information in the spec.
The reason why we are discussing this, is that if the controller may send incomplete reports (segments) as they come, they may be interleaved with others. It's going to be very very difficult for the host to ensure correct reassembly.

@cvinayak :

The controller will give n partial, followed by complete or incomplete data status. I need to read if incomplete data status shall be given if no more report will be generated. That may help host, alongwith SID to assemble the fragments, hopefully.

@Thalley :

Correct, but what if there are multiple advertisers?
The host would require to have a X buffers for reassembly, although it could be argued that the controller would need the same.

@cvinayak:

Host can be designed to drop, like let an application tell which SID to assemble, may be? On the controller giving always only give ADV_EXT_IND + AUX_ADV_IND makes sense, then it can give AUX_CHAIN_IND as soon as received. Host will have enough info from ADV_EXT_IND + AUX_ADV_IND  to decide whether to assemble rest of the chain
Currently, Zephyr controller's scanner is going to buffer all the ADV_EXT_IND + AUX_ADV_IND + AUX_CHAIN_IND, but there is thoughts to reduce RAM in controller by giving out the PDUs as they arrive, so that Radio DMA PDUs can be reused sooner

@Thalley :

How does sending and receiving of the AUX_CHAIN_IND work?
If a remote controller RC1 sends 500 octets in 5 fragments, and another, RC2, does the same, would we always receive them as
RC1_1, RC1_2, ..., RC1_5 and then RC2_1, RC2_2, ..., RC2_5 or would they be interleaved as RC1_1, RC2_1, RC1_2, RC2_2, ... ?

@cvinayak :

It will be a mix of interleaved reports from multiple extended advertisers, legacy advertising reports, interleaved with periodic advertising reports and BIG Info report etc.

@cvinayak

It will be a mix of interleaved reports from multiple extended advertisers, legacy advertising reports, interleaved with periodic advertising reports and BIG Info report etc.

See https://github.com/zephyrproject-rtos/zephyr/pull/37336#issuecomment-901047351. This statement implies you cannot interleave incomplete advertising reports from different advertisers. Note: You can interleave include advertising reports with incomplete periodic advertising reports.

@rugeGerritsen The Spec only talks about combining the ADV_EXT_IND and AUX_ADV_IND before generating the report, it does not tell about completing the subsequent AUX_CHAIN_IND.
On the advertiser side, there is:

<IP_ADDRESS> Advertising Sets
The advertiser’s Host may instruct the Link Layer to interleave advertising
events.

Also, there is:

If the Controller receives an AUX_CHAIN_IND with no AdvData, it should send
the report (or the last report if it has split the data) immediately without waiting
for any subsequent AUX_CHAIN_IND PDUs.

And then,

An Event_Type with a data status field of "incomplete, data truncated" indicates
that the Controller attempted to receive an AUX_CHAIN_IND PDU but was not
successful.

Which implies, Controller will have to interleave the reports from multiple advertisers. I do not see how otherwise a scanner can receive multiple PDUs from multiple advertising sets of differing advertising intervals and PDU chain counts, without coming up with a fairness algorithm to ensure all advertisers reports are generated as soon as it has occurred in the on-air timeline.

@cvinayak

On the advertiser side, there is:

<IP_ADDRESS> Advertising Sets
The advertiser’s Host may instruct the Link Layer to interleave advertising
events.

This statement only concerns the advertiser. It is unrelated to how the scanner forwards the reports to the host.
The HCI spec states in which order reports are expected to reach the host. See Core v5.3, Vol 4, Part  E, Section <IP_ADDRESS> LE Extended Advertising Report event:

The Controller may split the data from a single advertisement or scan response
(whether one PDU or several) into several reports. If so, each report except the
last shall have an Event_Type with a data status field of "incomplete, more data
to come", while the last shall have the value "complete"; the Address_Type,
Address, Advertising_SID, Primary_PHY, and Secondary_PHY fields shall be
the same in all the reports. No further reports shall be sent for a given
advertisement or scan response after one with a Data_Status other than
"incomplete, more data to come".

Lets say we receive advertisements from three advertisers A, B, and C. The advertisement of A is split into two reports: A0, A1. The advertisement is received twice: A0_0, A1_0 and A0_1, A1_1.
Are you interpreting the statement in the HCI spec as:

It is not possible to interleave any advertisement. That is, the following is allowed: B, A0, A1, A2, C. But this is not: B, A0, C, A1, A2.
It is possible to interleave advertising reports from multiple advertisers (A, B, C): A0, B, A1, C. It is not allowed to interleave the reports from A. That is, the following sequence is not allowed: A0_0, A1_1, A0_0, A1_1.

I believe you and @sjanc interpret it as (2).

It is not about interpreting the HCI Spec, but the order of HCI LE Extended Advertising Report events in general.
If A, B and C are Extended Advertisers (3 different devices or 1 device with multiple sets), and the order of PDUs on-air are:

A_adv_ext_ind, B_adv_ext_ind, C_adv_ext_ind, A_aux_adv_ind, B_aux_adv_ind, C_aux_adv_ind, A_aux_chain_ind, B_aux_chain_ind, and C_aux_chain_ind.

Then, the HCI events can be:

A_0_1, B_0_1, C_0_1, A_1_1, B_1_1, and C_1_1

where A_0_1 is with data_status as partial and A_1_1 with data_status as complete or incomplete.

It is not about interpreting the HCI Spec, but the order of HCI LE Extended Advertising Report events in general.
If A, B and C are Extended Advertisers (3 different devices or 1 device with multiple sets), and the order of PDUs on-air are:

A_adv_ext_ind, B_adv_ext_ind, C_adv_ext_ind, A_aux_adv_ind, B_aux_adv_ind, C_aux_adv_ind, A_aux_chain_ind, B_aux_chain_ind, and C_aux_chain_ind.

Then, the HCI events can be:

A_0_1, B_0_1, C_0_1, A_1_1, B_1_1, and C_1_1

where A_0_1 is with data_status as partial and A_1_1 with data_status as complete or incomplete.

@cvinayak , if I understand you correctly, your opinion is that (2) is the correct interpretation of the spec in https://github.com/zephyrproject-rtos/zephyr/pull/37336#issuecomment-902675425?

It is possible to interleave advertising reports from multiple advertisers (A, B, C): A0, B, A1, C. It is not allowed to interleave the reports from A. That is, the following sequence is not allowed: A0_0, A1_1, A0_0, A1_1.

@cvinayak , if I understand you correctly, your opinion is that (2) is the correct interpretation of the spec in #37336 (comment)?

No, (2) is not the correct interpretation. The reports are allowed to be interleaved, there is sufficient repeated information like Advertiser Address, SID etc. in all the HCI LE Extended Advertising Report to successfully assemble interleaved reports from multiple overlapping advertisers.

The reports are allowed to be interleaved, there is sufficient repeated information like Advertiser Address, SID etc. in all the HCI LE Extended Advertising Report to successfully assemble interleaved reports from multiple overlapping advertisers.

I think you are correct here, assuming that if any PDU in the chain is lost, then the data status will be 0b10 = Incomplete, data truncated, no more to come, and then any subsequent PDUs that are in the chain are not reported to the host. I.e. if the data is sent as a 4 segments, S1, S2, S3 and S4, and S2 is lost then

S1 -> sent to the host with 0b01 = Incomplete, more data to come
S2 -> sent to the host with 0b10 = Incomplete, data truncated, no more to come
S3 -> not sent to the host
S4 -> not sent to the host

So I think it is possible to do properly in the host, if we assign 1 or more reassembly buffers. In case that the host receives an incomplete packet but more to come, and we are out of buffers, we'll need to discard it.
Based on that, I think it would be better to implement the solution from https://github.com/zephyrproject-rtos/zephyr/pull/37377, and have the number (and possibly size?) of the assembly buffers be controlled via a Kconfig, rather than offloading this to the application.
There are possibly cases where an application can use incomplete data, but I think that's far to rare to be the design goal in my opinion.

So I think it is possible to do properly in the host, if we assign 1 or more reassembly buffers. In case that the host receives an incomplete packet but more to come, and we are out of buffers, we'll need to discard it.

Agree.

No further reports shall be sent for a given
advertisement or scan response after one with a Data_Status other than
"incomplete, more data to come".

I have the same understanding of the wording. There is no information that advertising data from different devices or different advertising sets may not be interleaved. The wording ensures that controller does not interleave advertising reports from single advertiser.
I'm wondering about one situation.
Single peer device sends advertising data in parallel over:

extended advertising (interval 500ms)
chain of periodic advertising data (e.g. AUX_SYNC_IND + 3 AUX_CHAIN_IND; interval 4s)
Scanning controller should buffer periodic advertising data until receive all of chained PDUs. In other case it will not be able to report extended advertising events that overlap with periodic advertising event.

Am I right?

No further reports shall be sent for a given
advertisement or scan response after one with a Data_Status other than
"incomplete, more data to come".

I have the same understanding of the wording. There is no information that advertising data from different devices or different advertising sets may not be interleaved. The wording ensures that controller does not interleave advertising reports from single advertiser.
I'm wondering about one situation.
Single peer device sends advertising data in parallel over:

extended advertising (interval 500ms)
chain of periodic advertising data (e.g. AUX_SYNC_IND + 3 AUX_CHAIN_IND; interval 4s)
Scanning controller should buffer periodic advertising data until receive all of chained PDUs. In other case it will not be able to report extended advertising events that overlap with periodic advertising event.

Am I right?

@ppryga , the periodic advertising and extended advertising reports are independent. The periodic advertising reports are identified by their handle. Therefore they can be interleaved in any way.
Also the controller does not need to buffer all the AUX_CHAIN_INDs before forwarding the periodic advertising report. This is similar to the scanner.

Closing this PR as we will use an approach similar to https://github.com/zephyrproject-rtos/zephyr/pull/37377 instead.


v4 Failing To Load With Laravel Mix

Expected behavior
Bugsnag loads and functions properly when running Laravel Mix
Observed behavior
Currently, v4 will not initiate and work properly with Laravel Mix. It works when running Mix in development mode, but as soon as assets are compiled using the production command, Bugsnag fails to load with the error:
r._logger.warn(e) is not a function

It appears that something with how Webpack is compiling the libraries is preventing Bugsnag from loading properly. I'm genuinely not sure if this is an issue with Bugsnag or Mix (or maybe I'm just missing something simple), but I figured it made sense to open an issue since Mix is a pretty popular library and I'm assuming I'm going to be the only one with this issue. v3 worked without issue using Mix, and my v4 code worked fine when running via development.
Steps to reproduce

Install Laravel Mix (Instructions)
Install Bugsnag v4.0.0 as NPM dependency
Edit content of app.js file referenced in webpack.mix.js to load bugsnag-js and attempt to initiate Bugsnag
Run npm run production command in Terminal
Load website to see error referenced above

I apologize for the work involved in reproducing this one! Kind of a pain.
Version
v4.0.0
Additional information
Again, I'm uncertain if this is something with Bugsnag JS or Laravel Mix (@JeffreyWay), and I can open this issue in their repository if it's a better fit there. This is, however, the only library I've had any problems with while using Mix, and Bugsnag JS v3 worked properly.
Let me know if there is anything more I need to dig up.

Hi @aaronhuisinga thanks for the report! I've managed to reproduce, so thanks for the detailed steps.

I apologize for the work involved in reproducing this one! Kind of a pain.

Don't worry 😂 this was relatively straightforward to get set up!
I'll let you know where I get with it.

It looks like by default laravel mix uses the drop_console compressor option in uglify.
I'm surprised this doesn't break other libararies and user code! I'll see if there's something we can do about it.

@bengourley Hmm, I wasn't under the impression that activating that option as a default would potentially break any libraries. I can tag a new release that removes it, if needed.

@JeffreyWay is this the same for Laravel Elixir?

@jbrooksuk In production mode, yes, I think it drops console.

@JeffreyWay that'll do it. Any chance we could get a new version out that doesn't? We're not yet able to make the upgrade to Mix (we're working on it) but we'd really like to get the Bugsnag Vue stuff out.

Yep, today I'll tag both packages to set that drop_console option to false by default.

Thanks @JeffreyWay 🍻

Thanks for being responsive on this @JeffreyWay. I'm going to ship a version of bugsnag-js that scoots around this issue too (#281), as you're probably not the only one doing so!

Okay, Laravel Mix 1.7 has been tagged. We no longer strip console.logs.

Thanks @JeffreyWay!

Thanks so much for the quick fix @JeffreyWay and @bengourley! You guys are great.


Preparing users for new lazy component

In the pull request for React 18 I made the new lazy loading use loadable.reactLazy, but it would be better if that could be just lazy.
So I wonder if we could make a legacyLazy now alongside lazy. Then add warnings when people use lazy that legacyLazy must be used soon since lazy will be changed in the next major loadable.
Then once the feature for new lazy is ready, we add it as reactLazy with a warning it will change to lazy in the next major loadable.

But what are the customer-facing changes in the lazy behaviour they will need to be aware of and address during the migration? Isn't it mostly internal stuff?

New lazy uses Suspense and not fallback.

There are many things I don't really like in Loadable, something kept from the early days.
With React Suspense you are no longer supposed to use Loading/Fallback or Error components as a part of a "loadable" - it's better to be kept outside.
It's important to keep API change minimally to ease migration, but sometimes 😁 releasing a new major version could be a better idea.
To make migration easier we can provide codemod from "old lazy" to "legacyLazy"


Fix ResourceLoader::thread_load_tasks crash

This PR adds a new method: ResourceLoader::clear_thread_load_tasks(). This is called now just after clearing scripting languages, but before the modules and servers uninitialization. Otherwise, some resources would exist until unregister_core_types(), and crash the engine when trying to access servers in the resources destructors.
This PR also adds the clearing of scene references inside GDScriptCache in GDScriptCache::clear().
Fixes #69652

Thanks!


Agate integration

Adding existing branch as PR.

There's a single failure in test_table, which is fine because table is likely going away.
2.6 is failing because OrderedDict isn't available, but agate (which is 2.7+ only) uses it.

Ok to drop support for 2.6?

Fixes #477

Yes, 2.6 should still work, but we're not going to explicitly test it anymore. Py2.7 has been around for 5+ years at this point and several agate dependencies don't claim to support 2.6 anymore.

Also, to the extent there are clear priorities in the documentation and/or code, we should always be preferring Python3 at this point.

K, dropping 2.6 from Travis. If 3.5 passes I'll merge (with that one exception).
Do you know off-hand how to skip a test? (Without just commenting it out / deleting it).

Found SkipTest!

:+1:


when adding more than 10 filters the top header grid layout gets broken

a fix could be to use more rows for the filters in case they are alot.

Now can use a modal to handle more filters.
https://github.com/z-song/laravel-admin/blob/master/docs/en/model-grid.md#add-query-filters


Master

Fix variable and add Indonesian translation

Thanks for contributing. especially, catching my misspel hansler.  👍

@slametps :
Hi, i need Indonesian translation update.
Can you help me for this ?
Can you check this
thx
@bugsounet


Switch • Warning: Received false for a non-boolean attribute id

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: https://codesandbox.io/s/react-mui-forked-sdn1uh
Steps:

Open the codesanbox
Wait for the preview to load and see the switch (type submit) rendered
Open the console and see the warning

Current behavior 😯
When the Switch is of type "submit", the console warning is shown.
Warning: Received `false` for a non-boolean attribute `id`.

If you want to write it to the DOM, pass a string instead: id="false" or id={value.toString()}.

If you used to conditionally omit it with id={condition && value}, pass id={condition ? value : undefined} instead.

Expected behavior 🤔
No warning should be shown.
Context 🔦
The problem is here, when hasLabelFor is false, we pass that boolean as the id prop.

  Output from `npx @mui/envinfo` goes here.

Thanks for reporting this. It's a bug.
Would you like to submit a PR? It should be as simple as changing the id to hasLabelFor ? id : undefined.
Aside from that, I'm curious, what's the use case for a switch with type=submit?

I can create a PR this weekend. 👍
The use case is a Remix form where the switch triggers the form submission. The form also contains two hidden inputs with some values. I think it's a legit use case case but let me know if I'm missing something, please.

If it works for you, that's cool :) I just haven't seen a switch-type control trigger a submission anywhere before, I think.

If it works for you, that's cool :) I just haven't seen a switch-type control trigger a submission anywhere before, I think.

How would you propagate the change to the server otherwise?

The Switch is basically a checkbox with a different styling. A native HTML checkbox does not submit a form when it's checked. If you require such a feature, the easiest should be to create an onChange handler on a Switch that submits the form:
function App() {
  const formRef = React.useRef();

  function handleSwitchChange() {
    formRef.current.requestSubmit();
  }

  return (
    <form ref={formRef}>
      <Switch onChange={handleSwitchChange} />
    </form>
  );
}

The Switch wasn't really designed to be used with input type="submit", as it doesn't have the checked property. If you made it work somehow, that's OK, but bear in mind that such a switch will not be accessible unless you add custom ARIA attributes.

The docs link a nice article about when to use switches vs. checkboxes. I think it makes sense to me, concretely:

Tapping a toggle switch is a two-step action: selection and execution, whereas checkbox is just selection of an option and its execution usually requires another control.

You mention that it doesn't have the checked property, I don't understand what you meant because it does have a checked property.
The code you shared would be ok for a SPA, but in Remix, that wouldn't be the idiomatic way of handling a form. Using the switch with type="submit is working perfectly so far, and the only issue I had was the warning.

You mention that it doesn't have the checked property, I don't understand what you meant because it does have a checked property.

I was referring to the input type="submit"

The code you shared would be ok for a SPA, but in Remix, that wouldn't be the idiomatic way of handling a form.

Why? In a SPA, you'd likely want to prevent the form from being submitted and do the AJAX request with its data instead, no? In this case, we are submitting the form using standard means, as in a "classic" multi-page application.

Sorry, I'm confused. Yes, in a SPA you would prevent the form from being submitted and do a fetch request instead. In Remix, the input of type "submit" will submit the form, as any web form. The Switch component admits its type to be "submit", so I don't see the need of adding the extra indirection to do the same thing. As I mentioned, the code works just fine and also feels right, the only small problem was the DOM warning.
Btw, I didn't have time to create a PR but I'll try to do it today.

PR created! https://github.com/mui/material-ui/pull/36170


Format additional regular expression escape sequences and don't modify arguments with embedded quotes.

Add common regular expression escape sequences like \d, \s, \w, etc. to Format-WslArgument.
Also, if the user embeds single quotes in an argument (e.g. '''s/;/\n/g'''), leave it alone, otherwise formatting its content may not result in the expected behavior.

Additional support for ',' and '{}' added in 36bf248fd52d71b26c28348118889324ca000f72.


Don't dump records into temporary file

I browsed the source code the other day and found this statement. As it is referenced nowhere else in the code, I assume it was used for debugging purposes when implementing the Minitest support and is therefore no longer necessary.

Thanks.
It was added in https://github.com/exoego/rspec-openapi/pull/90/files#diff-61df5b43e87c7076a0f7eeda68626183021a685cd305969c9f49c940fa6c7c7fR16 and no longer needed.


pgapp_worker does not check the source of handle_info({'EXIT',

Problem
pgapp_worker expects to have one child epgsql_sock which is the connection to the database. The function handle_info({'EXIT', From, Reason}, State) deals with the case when this child dies for some reason. In this case we cast reconnect and a new child epgsql_sock is created.
When using pgapp:with_transaction, the code inside the provided function is run by the pgapp_worker process. If the code inside the transaction function receives the message {'EXIT', From, Reason} (for example a spawn_linked process finishes normally) pgapp_worker will interpret this as a crash of its child epgsql_sock and it will trigger a cast to reconnect, even though the original epqgsql_sock is alive and well.
This process will cause the number of open epgsql_socks to increase forever until the database limit is reached, at which point some of the open connections will be forcefully closed.
Solution
The function handle_info({'EXIT', From, Reason}, State) should ensure that the From PID is the same as its child epgsql_sock. If it is not, then it should not attempt to reconnect.

I have a fix for this issue in progress, I will submit a PR tomorrow if all is well.

PR#27 seems to fix this, I will double check with a full test in the rest of the application code to make sure there is nothing I have missed.

I have tested and all looks good to me! Feel free to merge #27 at your convenience.


Is there any support to use ControlNets together with Ella Embeds?

I couldn't find any way to add Controlnets to my workflows using this extension.

Not with this one, as this uses the original inference code which isn't compatible with rest of ComfyUI. However this node pack allows you to use everything, including controlnets:
https://github.com/ExponentialML/ComfyUI_ELLA


Pattern: Update the Content block functional specifications for the Solutions page changes

User Story

As a [user role below]:
DDS developer

I need to:
have the Content block functional specs

so that I can:
so that I can properly code the Content block component that meets the Solution template requirements

Additional information

Design Issue (#  )
Development issue (# )

Acceptance criteria

[x] Documented Content block Link functional specifications
[x] Sent and/or presented the specs to Design, Content Strategy and Dev for their review and comments
[x] Additional stories are created, if needed, for any work to be done in future sprints
[x] Send a message to Jeff to let him know that the functional specs are ready for a developer by tagging him in the dev issue.

Updated content block's functional specs. I added button as a style option for content block cta under bullet point 4.
https://ibm.box.com/s/kw9b8eal4gi1yqmnautekub0djekcrof

Review meeting conducted with DDS designers and dev's April 14, 2020.


example jina-bert run failed

What might cause a scenario where a process fails to run successfully, resulting in the phenomenon of not getting any results for an extended period and continuously increasing memory usage on a Mac Pro?

out of memory


Added a simple function to texttospeech function to make it easier to use

I found the code very confusing and hard to use when I was using it, so I created and added a simple function to make it so that users can do text to speech in one go, without nessicarily needing to know how it all works.
The function is called googleTexttoSpeech. It did require an extra import, but makes everything much simpler

@jacobtye I doubt we'll take this. We don't want to manage hand-written code on top of the generated output

Agree with @kevmoo , the next time the generator re-generates the API client libraries based on new discovery docs, this will be lost. @jacobtye Would it be possible to put this into a package which depends on package:googleapis.
/cc @jonasfj

Agreed, we don't want custom code in the generates files. That said making a separate package with more high-level wrappers is absolutely a good idea.


CI: Add Ruby 2.7

Goal
Increase the knowledge we have about how this library runs with latest Ruby.
Approach

add a 2.7 (an rvm alias)
drop unused directive sudo: false

This PR removes the no-longer-used Travis setting sudo: false. See more at the Travis blog.

Coverage decreased (-26.6%) to 73.418% when pulling d35fea24ff1fa785a95a5a9b065b0dfc91326cdf on olleolleolle:patch-3 into e7ad59d432ebd76087707fc2bf7e439095e4a6f6 on ivanoblomov:master.

The failures are all about "no API key".
Looks good!

This is a good idea @olleolleolle. Travis CI makes it easy to test against multiple versions, so why not take advantage. Regarding:

The failures are all about "no API key".
Looks good!

I added a key to the repo's Secrets. Strangely, it doesn't work with GitHub's ruby workflow in #25, but seems to work fine with Travis CI. 🤷🏽♂
Wanted to reduce the number of integrations, but if I can't get the ruby workflow/action to work, we'll stick with Travis. On the off chance I do, I'll be sure to cover multiple ruby versions as you suggested. Cheers!


Allow chroot to be based from a directory tree.

This allows the user to point at a directory instead of a loopback-
device-based image.  This is only enabled if NO_NEW_PRIVS is also
enabled in order to prevent setuid-binaries from being accessible
via the chroot image.
(Note: most of the diff is from whitespace changes.  The patch is easier to review with diff -w).

I want to spend some time going through this in more detail and it is hard for me to see the full context via this interface, but at first glance it looks good.
Thanks!

This looks good.
Thanks!!


Link entity key mismatched.

First of all, apologies for missing this in my previous issue. I was using a custom link entity and didn't come across this.
In isLink the key used to check the entity type is in all caps (LINK). Whereas when adding a link using the addLink function, the key used is in lowercase (link) with no parameter available to pass a custom key.

Fix PR: #14

Hey Dan, Thanks for reporting and for the PR. I really appreciate it.
I've merged and published your changes (v1.2.15.)


🐛 compatibility update

Refinements & Code Organization
• Streamlined the CONF_COUNTRY_CODE by removing its redundancy across multiple modules, resulting in cleaner and more efficient code.
Technical Updates
• Upgraded the pyxplora_api library from version 2.12.5 to 2.12.6, ensuring the integration stays up-to-date with the latest API changes.
• Updated aiohttp library to version 3.9.3, enhancing the overall stability and performance of the integration.
• Advanced the integration version to v2.13.5, reflecting these latest improvements.
Compatibility Enhancements
• Updated compatibility with Home Assistant to version 2024.1.6, ensuring seamless integration with the latest Home Assistant release.
• Upgraded HACS compatibility to version 1.34.0, offering a smoother experience within the Home Assistant Community Store.

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.


Carthage Build Failure

Hello,
I'm trying to get the Macaw framework installed for iOS, and the build is failing when running 'carthage update Macaw'. The Cartfile includes:
github "Exyte/Macaw" ~> 0.9.0
In the log, it seems the build may be failing due macOS-related code, specifically NSImage? Here are the relevant lines from the log:
/Carthage/Checkouts/Macaw/Source/model/scene/Image.swift:142:30: error: use of unresolved identifier 'NSImage'
        return MImage(named: NSImage.Name(rawValue: src))
                             ^~~~~~~
/Carthage/Checkouts/Macaw/Source/model/scene/Image.swift:45:15: note: did you mean 'mImage'?
  private var mImage: MImage?
              ^
/Carthage/Checkouts/Macaw/Source/model/scene/Image.swift:7:12: note: did you mean 'Image'?
open class Image: Node {
           ^
/Carthage/Checkouts/Macaw/Source/platform/macOS/Common_macOS.swift:19:20: note: did you mean 'MImage'?
  public typealias MImage = NSImage
                   ^
CoreGraphics.CGImage:1:14: note: did you mean 'CGImage'?
public class CGImage : _CFObject {
             ^
/Carthage/Checkouts/Macaw/Source/render/ImageRenderer.swift:66:37: error: use of unresolved identifier 'NSImage'
        let osImage = MImage(named: NSImage.Name(rawValue: image.src))
                                    ^~~~~~~
/Carthage/Checkouts/Macaw/Source/model/scene/Image.swift:7:12: note: did you mean 'Image'?
open class Image: Node {
           ^
/Carthage/Checkouts/Macaw/Source/platform/macOS/Common_macOS.swift:19:20: note: did you mean 'MImage'?
  public typealias MImage = NSImage
                   ^
CoreGraphics.CGImage:1:14: note: did you mean 'CGImage'?
public class CGImage : _CFObject {
             ^
Foundation.NSRange:1:18: note: did you mean 'NSRange'?
public typealias NSRange = _NSRange
                 ^

** BUILD FAILED **

The following build commands failed:
	CompileSwift normal x86_64
	CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)

Hi @uimike! Thanks a lot for your report! We fixed this in master and currently work on making it into 0.9.1, will try to release ASAP.

Thanks for the fast response, @kayuri! I pointed the Cartfile at the master branch, and am now having a different error when running a carthage update.
Running carthage update now produces this error:
*** Building scheme "Macaw iOS" in Macaw.xcodeproj Failed to write to /Carthage/Build/Mac/Macaw.framework: Error Domain=NSCocoaErrorDomain Code=260 "The file “Macaw.framework” couldn’t be opened because there is no such file." UserInfo={NSURL=file:///Library/Caches/org.carthage.CarthageKit/DerivedData/9.0_9A235/Macaw/3b10a4735b96c7c6df6ce691b910b23868a44fa7/Build/Products/Release-iphoneos/Macaw.framework, NSFilePath=/Library/Caches/org.carthage.CarthageKit/DerivedData/9.0_9A235/Macaw/3b10a4735b96c7c6df6ce691b910b23868a44fa7/Build/Products/Release-iphoneos/Macaw.framework, NSUnderlyingError=0x7fed4e5f3b00 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}
I am able to build successfully for simulator and device, but when I try to archive, the archive fails with errors stating it doesn't recognize classes from the Macaw framework, which I'm guessing is tied to the error above. Thanks again for your help!

Hello, @uimike !
Just fixed projects settings in master branch, you should be able to now to use it via carthage. I will add OS X target soon.

Thanks @vhailor13!
The carthage update command succeeds now without any issues.
However, it looks like there are still some problems when archiving my project from the Carthage build, possibly related to the architectures that Macaw is built with. Here are the relevant errors and warnings I'm getting when archiving my project:
ld: warning: ignoring file /Documents/Project/Macaw.framework/Macaw, file was built for x86_64 which is not the architecture being linked (arm64): /Documents/Project/Macaw.framework/Macaw ld: warning: ignoring file /Documents/Project/SWXMLHash.framework/SWXMLHash, file was built for x86_64 which is not the architecture being linked (arm64): /Documents/Project/SWXMLHash.framework/SWXMLHash Undefined symbols for architecture arm64:   "__T05Macaw9SVGParserCMa", referenced from:       __T013ViewControllerC19M0_tFTf4gXn_n in ViewController.o   "__T05Macaw7SVGViewCMa", referenced from:       __T013ViewControllerC19M0_tFTf4gXn_n in ViewController.o   "__T05Macaw7SVGViewCAcA4NodeC4node_SC6CGRectV5frametcfc", referenced from:       __T013ViewControllerC19M0_tFTf4gXn_n in ViewController.o ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation)
For reference, my project is archiving with the Valid Architectures of arm64, armv7, and armv7s. Again, I really appreciate the help!

Can be closed now.


Better way to send input to a prompt programatically

I've been using a queue, as described at https://github.com/jonathanslenders/python-prompt-toolkit/issues/519#issuecomment-318978114, to make it so that I can send text to a prompt programatically. For instance, I have a -c startup flag that allows to run a command as the first prompt. I also use this in the bracketed paste handler, as described in that issue.
The way I've done this is to pass items in the command queue through a PipeInput and use that as the input to the cli when there is a queue (and a normal input=None otherwise).
However, I'm not a fan of this approach, because it means that I have to manipulate the input command so that it gets accepted by the cli, for instance, by appending a key code that maps to accept_line.
I would much rather just set the prompt text to the command manually, and have it accept immediately. Is there a way to do this? I basically want to cli.current_buffer.insert_text(command) then have cli.run() bypass the eventloop and do a quick exit.

Hi @asmeurer,
I forgot to reply to this one.
The use case makes sense indeed. I'll consider adding an argument to the Prompt.prompt function for accepting the input right away. If the purpose is to actually render the prompt to the output for feedback, then this does make sense. (Just give me some time for this. I'm preparing the 2.0 release and don't want to push too many new features right now.)

Great. Actually I figured out that the overabundance of CPR codes printed to my terminal is mostly coming from me using PipeInput. The stdout Output class basically implicitly assumes that the corresponding Input class is a stdin class. I'm still working on transferring to 2.0, so I can't say yet if this is fixed there. The separation of the two classes does still exist there, as far as I know. To me, this indicates that one should never use PipeInput for interactive applications (it should only be used for unit testing basically). Or if you do use it, you need to stub out the cpr request in the output class simultaneously.  So in short, if a feature like this could let me completely eliminate PipeInput from my non-testing code, it should hopefully get rid of the CPR bugs for me.

The use case makes sense indeed. I'll consider adding an argument to the Prompt.prompt function for accepting the input right away. If the purpose is to actually render the prompt to the output for feedback, then this does make sense. (Just give me some time for this. I'm preparing the 2.0 release and don't want to push too many new features right now.)

How exactly would you do this? I would implement this myself, but I'm completely stumped on how it would be done. Maybe I'm missing something obvious. The eventloop code is still pretty opaque to me.

That looks like it works. The self.default_buffer.text part is unnecessary (just use the default argument to set the text). Something like
diff --git a/prompt_toolkit/shortcuts/prompt.py b/prompt_toolkit/shortcuts/prompt.py
index 6ba8320..1d2bc3b 100644
--- a/prompt_toolkit/shortcuts/prompt.py
+++ b/prompt_toolkit/shortcuts/prompt.py
@@ -667,7 +667,7 @@ class PromptSession(object):
             reserve_space_for_menu=None, enable_system_prompt=None,
             enable_suspend=None, enable_open_in_editor=None,
             tempfile_suffix=None, inputhook=None,
-            async_=False):
+            async_=False, accept_immedietly=False):
         """
         Display the prompt. All the arguments are the same as for the
         :class:`~.PromptSession` class.
@@ -692,11 +692,15 @@ class PromptSession(object):
             for name in self._fields:
                 setattr(self, name, backup[name])

+        def pre_run():
+            if accept_immedietly:
+                self.app.exit(result=default)
+
         def run_sync():
             with self._auto_refresh_context():
                 try:
                     self.default_buffer.reset(Document(self.default))
-                    return self.app.run(inputhook=self.inputhook)
+                    return self.app.run(inputhook=self.inputhook, pre_run=pre_run)
                 finally:
                     restore()

Except the accept_handler is not called. If I try adding self.default_buffer.validate_and_handle() I get
Traceback (most recent call last):
  File "/Users/aaronmeurer/Documents/prompt-toolkit/prompt_toolkit/application/application.py", line 616, in _run_async2
    result = yield f
  File "/Users/aaronmeurer/Documents/prompt-toolkit/prompt_toolkit/eventloop/coroutine.py", line 86, in step_next
    new_f = coroutine.send(None)
  File "/Users/aaronmeurer/Documents/prompt-toolkit/prompt_toolkit/application/application.py", line 510, in _run_async
    self._pre_run(pre_run)
  File "/Users/aaronmeurer/Documents/prompt-toolkit/prompt_toolkit/application/application.py", line 483, in _pre_run
    pre_run()
  File "/Users/aaronmeurer/Documents/prompt-toolkit/prompt_toolkit/shortcuts/prompt.py", line 698, in pre_run
    self.app.exit(result=default)
  File "/Users/aaronmeurer/Documents/prompt-toolkit/prompt_toolkit/application/application.py", line 696, in exit
    raise Exception('Return value already set.')
Exception: Return value already set.

Yeah I figured that I misspelled it :) That's probably a sign that the flag should be called something else.

Hmm, well validate_and_handle isn't actually what you want, because that adds a pre_run callable to reset the buffer, which would then clear the text when the app is actually run.
I'm trying to wrap my mind around the control flow here and what the right way to do this is.

To clarify, it's because _pre_run calls pre_run then the pre_run_callables: https://github.com/jonathanslenders/python-prompt-toolkit/blob/f255927556353e6a0a2339947cceb8bf4d31f30e/prompt_toolkit/application/application.py#L480-L488
This patch "fixes it", but I don't think it's a necessarily a good one.
diff --git a/prompt_toolkit/application/application.py b/prompt_toolkit/application/application.py
index 34ae7ee..e51e623 100644
--- a/prompt_toolkit/application/application.py
+++ b/prompt_toolkit/application/application.py
@@ -483,7 +483,7 @@ class Application(object):
             pre_run()

         # Process registered "pre_run_callables" and clear list.
-        for c in self.pre_run_callables:
+        for c in self.pre_run_callables[:]:
             c()
         del self.pre_run_callables[:]
diff --git a/prompt_toolkit/shortcuts/prompt.py b/prompt_toolkit/shortcuts/prompt.py
index f5e7530..a61e9c3 100644
--- a/prompt_toolkit/shortcuts/prompt.py
+++ b/prompt_toolkit/shortcuts/prompt.py
@@ -667,7 +667,7 @@ class PromptSession(object):
             reserve_space_for_menu=None, enable_system_prompt=None,
             enable_suspend=None, enable_open_in_editor=None,
             tempfile_suffix=None, inputhook=None,
-            async_=False):
+            async_=False, accept_immediately=False):
         """
         Display the prompt. All the arguments are the same as for the
         :class:`~.PromptSession` class.
@@ -692,10 +692,15 @@ class PromptSession(object):
             for name in self._fields:
                 setattr(self, name, backup[name])

+        def pre_run():
+            if accept_immediately:
+                self.default_buffer.validate_and_handle()
+
         def run_sync():
             with self._auto_refresh_context():
                 try:
                     self.default_buffer.reset(Document(self.default))
+                    self.app.pre_run_callables.append(pre_run)
                     return self.app.run(inputhook=self.inputhook)
                 finally:
                     restore()

@jonathanslenders any thoughts on this? This is the only thing keeping me from updating to 2.0.

Yes, this is one of the next things to do. I didn't want to postpone the 2.0 release any longer, but I'm coming back to this issue.

I'll take a look.


Define Error.Code as authoritative

(Opening up as a PR directly with the suggested change to clarify this point for implementations and clients but happy to discuss if this isn't the actual intention of the Error Code/Message distinction.)
This makes it explicit that the Code attribute of the Error model is the
authoritative source of truth for the origin of the error, while the
error message is secondary.
It also makes it explicit that the same error code may present multiple
different messages so clients of Rosetta implementations should not rely
on them for error detection and Rosetta backends should make an effort
to present error codes in a granular enough level for clients.

Thanks for posting this PR @matheusd ... I clarified a point about Error.Message vs Error.Details and think the documentation around these models could definitely be improved to include this.
Would ❤  if you repurposed this PR to improve the documentation on these Error fields!

Updated.
Given that the message has to be fixed, should they maybe be recommended to be code-like messages vs descriptive messages?
Stuff like "ErrBlockNotFound" vs "block not found"? Or do you feel this is an unnecessary distinction to make?

Thanks for writing these descriptions @matheusd! Some small nits around some extra trailing spaces but once those are fixed looks good.

Given that the message has to be fixed, should they maybe be recommended to be code-like messages vs descriptive messages?
Stuff like "ErrBlockNotFound" vs "block not found"? Or do you feel this is an unnecessary distinction to make?

That's a great question. I don't believe we need to restrict all messages to be code-like (descriptive messages may honestly make things more understandable). Consistency of message and code is the most important point here (which your changes already make clear).

(CircleCI didn't get kicked off so I had to close/open the PR)


Feature request: support JPEG decoding

Support JPEG decoding to easily replace libjpeg-turbo and MozJPEG on browsers.

Any idea, how much extra code would it take to actually implement this (how much / which parts of code can be reused)?

The only thing I know is what Jon Sneyers said.
https://github.com/mozilla/standards-positions/issues/522#issuecomment-856035731
"I want to point out that potentially a JPEG XL decoder could also be used as a JPEG decoder (libjxl currently doesn't do that yet, but it does contain all the code needed to do that), which means the dependency that browsers have on libjpeg-turbo could potentially be dropped."

Also, if you compare flowchats in slide 20 and 21 it kinda tells you which parts of the code can be reused.
https://docs.google.com/presentation/d/1LlmUR0Uoh4dgT3DjanLjhlXrk_5W2nJBDqDAMbhe8v8/edit#slide=id.g910bfb2ea8_45_0

JPEG provides subset of JPEG XL features (basically it's VarDCT image with only DCT8 varblocks and without fancy image features), so if jxl-oxide could read JPEG bitstream it would be able to reuse most of the rendering code.
I'm going to focus on properly implementing JPEG XL features, so rendering JPEG images is in somewhat low priority. It would be very nice to support JPEG decoding though!


EKS cluster Terraform plan

Scenario which you are working on
https://azurearcjumpstart.io/azure_arc_jumpstart/azure_arc_k8s/eks/eks_terraform/
Describe the bug
When executing the Terraform plan I get a warning and an error related to deprecated constraints and a deprecated function (see below)
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
Warning: Version constraints inside provider configuration blocks are deprecated
│
│   on providers.tf line 7, in provider "aws":
│    7:   version    = "~> 2.38.0"
│
│ Terraform 0.13 and earlier allowed provider version constraints inside the provider configuration block, but that is
│ now deprecated and will be removed in a future version of Terraform. To silence this warning, move the provider
│ version constraint into the required_providers block.
╵
╷
│ Error: Error in function call
│
│   on vpc.tf line 12, in resource "aws_vpc" "arcdemo":
│   12:   tags = map(
│   13:     "Name", "terraform-eks-arcdemo-node",
│   14:     "kubernetes.io/cluster/${var.cluster-name}", "shared",
│   15:   )
│     ├────────────────
│     │ var.cluster-name is a string, known only after apply
│
│ Call to function "map" failed: the "map" function was deprecated in Terraform v0.12 and is no longer available; use
│ tomap({ ... }) syntax to write a literal map.
Additional context
Add any other context about the problem here.

This is a bug introduced with Terraform v.15. We will update the calls to map() to use the new tomap() function.


Add @extern info to cinterop

Took me a while to find the solution in a quick primer on C3 under "Calling C functions" so it may be useful to have it on the dedicated cinterop page which a lot of people will naturally look at first (like I did).

Good idea! Can you wrap the example in c3  so we get code highlighting too?

My bad, seemed like the entire page was missing them so I've updated all the block.

Thank you for going the extra mile.


merge from arlac77/npm-package-template-esm-only

package.json

chore(scripts): cover@#overwrite c8 -x 'tests/**/*.mjs' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
chore(engines<EMAIL_ADDRESS>
.travis.yml

chore(travis): remove node versions 10.16.2
chore(travis): add node versions -10,-11,-12,10.16.3

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #76   +/-   ##
======================================
  Coverage    94.9%   94.9%
======================================
  Files           6       6
  Lines         412     412
  Branches       67      71    +4
======================================
  Hits          391     391
  Misses         21      21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f006fc...6cba542. Read the comment docs.

:tada: This PR is included in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Provide support for authenticating webhook requests

On the GitHub side, the express-github-webhook module being used by Staticman is ready to accept an expected webhook secret/token and check for a matching secret/token in each webhook request received (from GitHub). However, there is no logic/support in the Staticman codebase or config file(s) that allows for an expected secret/token to be configured.
Given that the downstream webhook handler (handlePR.js) allows for sending emails to subscribers, it seems to me that not providing support for webhook request authentication leaves Staticman installs open to abuse.
Support for authenticating webhook requests should be provided regardless of git service (GitLab or GitHub).

I've added the above-described functionality via PR https://github.com/eduardoboucas/staticman/pull/388
Here are the relevant entries in config.js:
  githubWebhookSecret: {
    doc: 'Token to verify that webhook requests are from GitHub',
    format: String,
    default: null,
    env: 'GITHUB_WEBHOOK_SECRET'
  },
  ...
  gitlabWebhookSecret: {
    doc: 'Token to verify that webhook requests are from GitLab',
    format: String,
    default: null,
    env: 'GITLAB_WEBHOOK_SECRET'
  },

If either secret is configured in the Staticman JSON config, but missing from the webhook calls sent from GitHub/GitLab (or not valued as expected), an error is thrown.


DCIM file reading error

Hey there!
Thanks for the amazing framework!
I am trying to read a DICOM file gathered from an ultra sonic machine developed by General Eletric. The DICOM file loads perfectly in slicer and the proprietary GE dicom viewer. When loading in AMI there is an error message:
DICM prefix not found at location 132 – this is not a valid DICOM P10 file
After contacting General Electric they told me that "the given DICOM file(“G4JDJN80”) has no issues with the format and it has “DICM” preamble after 128 bytes as expected and encoded using DICOM Part#10 defined format." Further they suspect that AMI may not be compatible with DICOM enhanced US volume files (SOP Class UID “1.2.840.10<IP_ADDRESS>.<IP_ADDRESS>”). Is this correct? Is there some kind of workaround? Maybe its due to the file including all slices in contrast to the demo where every slice is its own file?
I've attached the file in question. I worked with the "lesson 1" code from AMI. Thanks for the help!
Description
DICM prefix not found at location 132 – this is not a valid DICOM P10 file when loading a DICOM file into the "lesson 1" slicer example
Live Demo
https://github.com/coryoso/ami-dicom-error
Steps to Reproduce

Load file "G4JDJN80"
Error with file

Expected Results
Able to load file and slice
Actual Results
Not able to load file
Browsers Affected

[X] All

Versions

AMI: v0.32.0
THREEJS: v0.99.0

"US enhancend volumes" dicom files are indeed not supported, talking with the manufacturer I learned about it being relatively niche and therefore not being widely supported. Easy workarounds is using Slicer.app to convert the dicom file to .nrrd and then everything works as expected :)


[QUERY] Cosmos DB Spring Data - Timeout/retry configuration (using gateway mode)

Query/Question
I'm looking for a way to configure the timeout/retry for any Cosmos DB call (gateway mode). Did I overlook something in the documentation?
E.g., whenever a database call (specifically findById/deleteById/save),  takes longer than 3 seconds, kill it (or retry at most 3 times).
Why is this not a Bug or a feature Request?
I believe I may have overlooked something, as this operation would be essential in order to not overload our application server (e.g., if the findById operation takes longer than 3 seconds, kill it). If it is not implemented, please feel free to change this query to a feature request instead.
Setup (please complete the following information if applicable):

Library/Libraries: com:azure.spring:spring-cloud-azure-dependencies:5.8.0 (specifically the com.azure:azure-spring-data-cosmos:5.8.0 library)

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[X] Query Added
[X] Setup information Added

@kushagraThapar please help take a look, thanks


Update documentation with my 22.11 release experiences

This is a big one, sorry!

Preview https://shells.darmstadt.ccc.de/~hexa/8d25ca6/


Update README.md

Change installation instructions so it's more difficult to miss the crucial android part

Thanks! I think it'll help a lot of people!


typist.skip() doesn't work when you add a delay to text

Hi there!
I am running the skip() function on a left mouse click, and have discovered that before and after a [delay, 2000] in the text for example, it works fine, but during that 2 second delay, the text is actually unskippable with the skip() function. I am in version 9.0.0
I believe this is this an issue so apologies if it is just a programming error on my part!

Looking into this now.

Does indeed seem to be a bug! Fixing now.

Here's the fix: https://github.com/JujuAdams/Scribble/commit/768f5ef67acf91f169a7ba29586128b7d076d4d6#diff-76f5377ca6170938a5cb070de962755262b17fab32d98485ef95d01da4d56589
Will be released alongside 8.7.2 and 9.0.1


An upgrade "core files" option

Is your feature request related to a problem? Please describe.
Upgrading a project to a new version works, however that does not upgrade the core files, such as all the npm packages and the gulpfile.js
Describe the solution you'd like
Add an option, where you could run an "Upgrade solution" in the generator to get the latest versions of all dependencies.

Implemented in 2.11.0


NMAKE : fatal error U1077: 'cl' : return code '0x2' on Windows

Windows 10, 64 bit
Ruby 2.5.1
Visual Studio 2015 Update 3
Command Ran:
rubyc my_script.rb
Debug:
-> Project root not supplied, C:/Users/yohoj/Downloads/rs_acc_creator assumed.
Ruby Compiler (rubyc) v0.4.0
- entrance: C:/Users/yohoj/Downloads/rs_acc_creator/rs_acc_creator.rb
- options: {:make_args=>"-j4", :output=>"C:/Users/yohoj/Downloads/rs_acc_creator/a.exe", :tmpdir=>"C:/Users/yohoj/AppData/Local/Temp/rubyc"}

-> mkdir -p C:/Users/yohoj/AppData/Local/Temp/rubyc
-> cd C:/Users/yohoj/AppData/Local/Temp/rubyc/ruby-2.4.1-0.4.0
-> Running [{"CI"=>"true", "ENCLOSE_IO_USE_ORIGINAL_RUBY"=>"1", "ENCLOSE_IO_RUBYC_1ST_PASS"=>"1", "ENCLOSE_IO_RUBYC_2ND_PASS"=>nil}, "call win32\\configure.bat                                   --disable-install-doc                                   --prefix=\"C:/Users/yohoj/AppData/Local/Temp/rubyc/ruby-2.4.1-0.4.0/build\""]
NMAKE : fatal error U1077: 'cl' : return code '0x2'
Stop.
-> Running [{"CI"=>"true", "ENCLOSE_IO_USE_ORIGINAL_RUBY"=>"1", "ENCLOSE_IO_RUBYC_1ST_PASS"=>"1", "ENCLOSE_IO_RUBYC_2ND_PASS"=>nil}, "nmake "]

Microsoft (R) Program Maintenance Utility Version 14.00.24210.0
Copyright (C) Microsoft Corporation.  All rights reserved.

-> Running [{"CI"=>"true", "ENCLOSE_IO_USE_ORIGINAL_RUBY"=>"1", "ENCLOSE_IO_RUBYC_1ST_PASS"=>"1", "ENCLOSE_IO_RUBYC_2ND_PASS"=>nil}, "nmake install"]

Microsoft (R) Program Maintenance Utility Version 14.00.24210.0
Copyright (C) Microsoft Corporation.  All rights reserved.

NMAKE : fatal error U1073: don't know how to make 'install'
Stop.
Failed running [{"CI"=>"true", "ENCLOSE_IO_USE_ORIGINAL_RUBY"=>"1", "ENCLOSE_IO_RUBYC_1ST_PASS"=>"1", "ENCLOSE_IO_RUBYC_2ND_PASS"=>nil}, "nmake install"]

Maybe related issue?
https://github.com/pmq20/ruby-packer/issues/34

I believe this was occurring due to differing bit versions, specifically I believe I was running Visual Studio x86 instead of x64.
After getting everything on x64, get this issue:
https://github.com/pmq20/ruby-packer/issues/34
Going to continue this thread there.

The same error, even if I use x64 (set PATH for amd64/cl)

It worked for me with the Developer Command Prompt for VS 2017. If you want a script:
call "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\Tools\VsDevCmd.bat"
rubyc ...

Maybe you can use some environment variables to reduce the amount of hardcoded paths.


Reportback content

Fixes #162
Edit to return all reportback content, beyond only reportback id.

@chloealee which endpoints did you test against and can you copy and paste an example response in here? (just remember to strike out any sensitive data)

@jonuy sorry about that! Something got messed up when I tried to rebase. Just fixed it and should work now.
Here's the endpoint I'm testing against:
http://northstar.dev:8000/v1/users/mobile/{mobile_number}/campaigns
Here's an example response:
{
"data": [
{
"drupal_id": "",
"signup_id": *,
"signup_source": "",
"updated_at": "2015-07-01 02:42:25",
"created_at": "2015-06-30 19:31:50",
"reportback_id": ,
"reportback_data": {
"data": {
"id": "",
"created_at": "1394231347",
"updated_at": "1394231347",
"quantity": 12,
"reportback_items": {
"total": 1,
"data": [
{
"id": "",
"caption": "DoSomething? Just did!",
"uri": "http://staging.beta.dosomething.org/api/v1/reportback-items/41",
"media": {
"uri": "http://staging.beta.dosomething.org/sites/default/files/styles/480x480/public/kittycat_0.jpg?itok=pI3zyrHb",
"type": "image"
},
"created_at": "1402428343",
"kudos": null
}
]
},
"campaign": {
"id": "",
"title": "Party Animal",
"reportback_info": {
"copy": "Let us know how many items you included on your list! (Note: the shelter does NOT need an Xbox One.)",
"confirmation_message": "Thanks for helping homeless animals. You deserve a party!\\r\\n",
"noun": "items",
"verb": "wished for"
}
},
"user": {
"id": "*"
}
}
}
}
]
}

@chloealee could we get rid of that last nested data object in reportback_data? So instead of it being obj.data[0].reportback_data.data to get at the reportback data, it's just obj.data[0].reportback_data?

Also, it seems like GET /user/campaigns/:campaign_id should also work since you're updating the show() function. I just wanna make sure that one's getting tested too.

@jonuy yup - GET /user/campaigns/:campaign_id is working too! Just has the same issue as the index() with the extra nested data object in reportback_data - figuring out how to remove now - will keep you updated!

@jonuy removed the nested data object in reportback_data - should be structured correctly now!

:+1:


command to strip a particular tag or attribute

Reverse the logic of strip_tags and strip_attr (at least as an option)
Example: I want to remove all <a> tags from a webpage.
I wish I could just write strip_tags:a in order to strip <a>.
But instead I have to write a list of all the tags that I want to keep, eg strip_tags:"h2, h3, h4, p, ul, ol, li, blockquote, i, b, em, strong".
The reverse logic would fit better with a common template pattern: start with contentHtml, then remove annoyances with remove_html, strip_tags and strip_attr.

remove_html can already be used as the opposite of strip_tags

Different use cases. Here's a live example. Open https://stephango.com/style and apply this template:
# `remove_html`

{{selectorHtml:content|remove_html:"a"|markdown}}

# `strip_tags`

{{selectorHtml:content|strip_tags:"h2, h3, h4, p, b, i, em, strong, ol, ul, li, blockquote, figure, img, div, span"|markdown}}

Screenshot shows webpage with links (left), stripped tags (middle) and removed HTML (right).

The feature request is about making the task in the middle easier.
I want to

select the content
Strip the <a> tag (=remove the markup, but keep the text)
convert the content to Markdown.

That's the syntax I wish we had for such a common use case:
{{selectorHtml:content|strip_tags:"a"|markdown}}
or
{{selectorHtml:content|remove_tags:"a"|markdown}}

Ok. I don't think we should reverse the behavior of the strip filters since that would break all existing templates and also work differently than strip filters Twig and other templating languages. It's better to add a new filter that has the opposite behavior.

Added in 0.10.3


Replace httpbin.org/gzip Tests with WebListener and Re-Enable Deflate Tests

Add Compression/Gzip test to WebListener
Add Compression/Deflate test to WebListener
Replace tests using httpbin.org/gzip with WebListener
Re-enable testing for Deflate
Converted tests to -TestCase from foreach

I have no idea what ''7976639:Invoke-WebRequest does not support -TransferEncoding deflate'' and "7976639:Invoke-RestMethod does not support -TransferEncoding deflate" are, but in my limited testing it appears to no longer be true.
reference #2504

test fails unrelated (#4958)

@markekraus those numbers probably refer to old bugs we used to track internally in TFS, quite possibly no longer relevant

@markekraus The tests seemed to have hanged in Invoke-WebRequest tests.  Please have a look.
https://travis-ci.org/PowerShell/PowerShell/jobs/281969182

@adityapatwardhan I'm not sure it is related. https://travis-ci.org/PowerShell/PowerShell/jobs/281240156 had passed and the only changes since were superficial. I think it was a random macOS issue on Travis CI. I've pushed an empty commit to rerun the tests

@adityapatwardhan speaking of unrelated macOS failures in Travis CI https://travis-ci.org/PowerShell/PowerShell/jobs/282354703 :(
Does someone have access to restart just that Job? Or should  just push another empty commit?

@markekraus I restarted it for you

@SteveL-MSFT  Thanks!
@adityapatwardhan all passing now.


Update Account Creation Process

As spec section 7.3

[ ] lookup account URL based on account key (7.3.1)
[ ] handle changes of terms of service (7.3.4)
[ ] support account key roll-over (7.3.6)
[ ] support account deactivation (7.3.7)
[ ] use terms-of-service-agreed to indicate ToS acceptance

obsoleted


Compose Multiplatform support

Hi there! This library is truly amazing as it fills a big gap left in Compose.
However, it's only built for Android, so it can't be used in Compose Multiplatform for now.
Can this be implemented for other Compose targets, while providing a shared modifier that delegates to sensible platform-specific implementations?
Aside from project configuration etc, I think the implementations should be rather straightforward as Desktop/iOS platforms don't have the same limitations Android has on blur in older API versions, so a blur-based implementation could be easily done for them (and Skia is directly accessible in both).
As for web, I'm not sure how is the situation there, but it also uses Skia under-the-hood.
I'm ready to help with anything regarding this.
Thanks!

Hi, at first thanks for this feature request.
I checked your proposal, and it seems valid, but also I checked the CMP approach (basic app structure) and it seems quite obvious in the approach (similar to the Flutter). But I didn't find any examples of the UI CMP library, if you have any, please share them (in the meantime I am going to explore them as well).
As for the Skia implementation, yes, it is also possible, but I have 0 knowledge of it, and I would prefer a native approach for each platform.
So, I see this plan as the following. We can create a structure of interfaces that will cover common (shared) features with some extra properties for each platform if needed. As far as I see it, we can provide a new Modifier (.cmShadow(...)) that will have a Configurator class, where you can specify the desired shadow for each platform with the sealed class (because on the Web it could be multiple implementations, while on iOS only one).
So yeah, basically, we need to collect info on what types of shadows are supported in each platform, then design a cmShadow(...) structure, and then drive the actual implementation.
Regarding the implementation, I can lead the Android part, as for the iOS/Desktop/Web, I will just review/test it, so they approaches are aligned and the desired result is satisfied.
Gather your fellows to help us with this.
What do you think?

Thanks for the thorough response!

I didn't find any examples of the UI CMP library, if you have any, please share them

If you mean existing UI CMP libraries, there are quite a few, two examples that come to mind are Kamel, a lazy image loading library, and material3-windowsizeclass-multiplatform, which is a CMP port of the Android-only Material 3 Size class library in androidx.
As for CMP apps, there are some examples in the CMP repo, as well as many community projects.

As for the Skia implementation, yes, it is also possible, but I have 0 knowledge of it, and I would prefer a native approach for each platform.

Yeah indeed, a higher-level approach would be preferable. It's not more "native" than using Skia itself since that's what Compose Desktop/iOS/Web themselves use under-the-hood, through Skiko (Skia bindings in Kotlin), which is automatically imported with Compose itself.
Android itself uses Skia under-the-hood, but doesn't expose it directly, so Compose relies on what's exposed through the Android SDK.
In any case, a basic blur-based implementation for all three platforms could be very similar, if not identical, especially if we rely on high-level constructs (and in that case, it may as well be similar to the Android implementation). I'll begin experimenting with this at least on Desktop/Web and report my findings.
When it comes to naming the Modifier, I think it would be better if it keeps the same name, shadowsPlus, to not break expectations of Android developers moving to CMP, and keep all documentation consistent.
Side note: if we're going with a name change anyways, I would love to name it boxShadow on all platforms. While this name is very generic, the Compose team shows no interest in implementing box shadows anytime soon, so this library could be the de-facto implementation to serve everyone, and such a generic name would be easy to remember and reason about.
Allowing multiple implementation is a great idea, and we could pass a reasonable default as a default parameter.

Regarding the implementation, I can lead the Android part, as for the iOS/Desktop/Web, I will just review/test it, so they approaches are aligned and the desired result is satisfied.

I can code and test the Desktop/Web versions. As for iOS, I don't have a Mac, so I can't really test that (but if the implementation is identical between these, you can test if it works as expected).
Let's go for it!

Hi, good thoughts. Thanks for the resources. So the next step is to create a new feature branch and work there. Then create another library module for CMP approach. And then experiment with it. Currently, I am a little bit busy at work & free time.

After some time, I won't do it. This KMP is mehhh.


s: expected string, got nil

Describe the bug
Receiving a s: expected string, got nil error upon startup
To Reproduce
Open file in Git directory (so far have tried Rust and C++ files)
lua file:
require("gitsigns").setup {
    signs = {
        add = {hl = "DiffAdd", text = "│", numhl = "GitSignsAddNr"},
        change = {hl = "DiffChange", text = "│", numhl = "GitSignsChangeNr"},
        delete = {hl = "DiffDelete", text = "_", numhl = "GitSignsDeleteNr"},
        topdelete = {hl = "DiffDelete", text = "‾", numhl = "GitSignsDeleteNr"},
        changedelete = {hl = "DiffChange", text = "~", numhl = "GitSignsChangeNr"}
    },
    numhl = false,
    keymaps = {
        -- Default keymap options
        noremap = true,
        buffer = true,
        ["n ]c"] = {expr = true, '&diff ? \']c\' : \'<cmd>lua require"gitsigns".next_hunk()<CR>\''},
        ["n [c"] = {expr = true, '&diff ? \'[c\' : \'<cmd>lua require"gitsigns".prev_hunk()<CR>\''},
        ["n <leader>gs"] = '<cmd>lua require"gitsigns".stage_hunk()<CR>',
        ["n <leader>gu"] = '<cmd>lua require"gitsigns".undo_stage_hunk()<CR>',
        ["n <leader>gr"] = '<cmd>lua require"gitsigns".reset_hunk()<CR>',
        ["n <leader>gp"] = '<cmd>lua require"gitsigns".preview_hunk()<CR>',
        ["n <leader>gb"] = '<cmd>lua require"gitsigns".blame_line()<CR>'
    },
    watch_index = {
        interval = 100
    },
    current_line_blame = true,
    sign_priority = 6,
    update_debounce = 100,
    status_formatter = nil, -- Use default
    use_decoration_api = true,
    use_internal_diff = true,  -- If luajit is prese
    debug_mode = true
}

Steps to reproduce the behavior:

Open code-based file in folder
Receive error immediately

Happens consistently every startup.
Observed output

Error executing luv callback:
vim/shared.lua:64: s: expected string, got nil
stack traceback:
vim/shared.lua:64: in function 'gsplit'
vim/shared.lua:111: in function 'split'
...ite/pack/packer/start/gitsigns.nvim/lua/gitsigns/git.lua:198: in function
'_user_on_exit'
.../site/pack/packer/start/plenary.nvim/lua/plenary/job.lua:237: in function
'_shutdown'
.../site/pack/packer/start/plenary.nvim/lua/plenary/job.lua:32: in function
<.../site/pack/packer/start/plenary.nvim/lua/plenary/job.lua:23>

No additional output from debug mode.
Screenshots

Additional context
System: Mac
Neovim version: NVIM v0.5.0-dev+804ea22

Oh sorry, almost forgot, I have this included in my packer.vim
 use "nvim-lua/plenary.nvim"
 use "lewis6991/gitsigns.nvim"

There isn't really any specific instructions on how to reproduce this issue other than to open a file. Many people use this plugin and there is also a test suite that checks every commit so there must be something specific that's causing this otherwise the plugin is completely broken.
Is there anything else you can think off which would explain what's causing this? It's hard to help if I can't reproduce the issue.

I came here because I also have this problem.
Steps to reproduce:

:e new_file
:w
Error

It's probably because the file is untracked.

Have you tried updating neovim to latest?

Ok, my apoligies. I've just realised this error is due to config.current_line_blame.
I will update the issue template to instruct a minimum config should be supplied.

Oh, I was just trying to build the latest but was having problems.
So does this mean current_line_blame shouldn't be used any more?

No, keep using it. It's a trivial issue, just fixing it now.
90% of the work of fixing issues is just figuring out how to reproduce and identify.

Ok, that's great. Thanks for the quick answers :)
In case it's useful, here's some tracebacks:
When booting and moving the cursor:
Error executing luv callback:
vim/shared.lua:64: s: expected string, got nil
stack traceback:
        vim/shared.lua:64: in function 'gsplit'
        vim/shared.lua:111: in function 'split'
        ...ite/pack/packer/start/gitsigns.nvim/lua/gitsigns/git.lua:198: in function '_user_on_exit'
        .../site/pack/packer/start/plenary.nvim/lua/plenary/job.lua:237: in function '_shutdown'
        .../site/pack/packer/start/plenary.nvim/lua/plenary/job.lua:32: in function <.../site/pack/packer/start/plenary.
nvim/lua/plenary/job.lua:23>
        [C]: in function 'system'
        ...te/pack/packer/start/nvim-tree.lua/lua/nvim-tree/git.lua:11: in function 'update_root_status'
        ...te/pack/packer/start/nvim-tree.lua/lua/nvim-tree/git.lua:40: in function 'reload_roots'
        ...te/pack/packer/start/nvim-tree.lua/lua/nvim-tree/lib.lua:165: in function <...te/pack/packer/start/nvim-tree.
lua/lua/nvim-tree/lib.lua:159>

I noticed nvim-tree in the error, so uninstalled it and got this instead:
Error executing luv callback:
vim/shared.lua:64: s: expected string, got nil
stack traceback:
        vim/shared.lua:64: in function 'gsplit'
        vim/shared.lua:111: in function 'split'
        ...ite/pack/packer/start/gitsigns.nvim/lua/gitsigns/git.lua:198: in function '_user_on_exit'
        .../site/pack/packer/start/plenary.nvim/lua/plenary/job.lua:237: in function '_shutdown'
        .../site/pack/packer/start/plenary.nvim/lua/plenary/job.lua:32: in function <.../site/pack/packer/start/plenary.
nvim/lua/plenary/job.lua:23>

Not sure what the nvim-tree error is all about. I guess the error from gitsigns is interrpting it maybe?
Anyway I've fixed the issue in #124


server/db connection params (host, port)

How do you connect to a database on a different host, port, etc.?

new Mongolian("mongo://foo.com:12345") should not result in any database object at all. It should result in a server connection. From there you would call the db method to get a database instance. Defaulting to 'test' is extremely error-prone.
How are you determining the name is undefined?


Deeply nested key returning undefined console error

material-react-table version
v1.14.0
react & react-dom versions
v18.2.0
Describe the bug and the steps to reproduce it
When accessing a deeply nested value that is undefined using accessorKey, the console log spits out a bunch of warnings are annoying to read past. Is there any way to disable this functionality?
What makes me believe this is a bug is this only happens with keys that are deeply nested (ie in my attached screenshot, audit.create_utc will return this console error, but just having audit would not).
Minimal, Reproducible Example - (Optional, but Recommended)
`
const columns =
{
header: 'Created',
accessorKey: 'audit.create_utc'
}
//...

//...
`
Screenshots or Videos (Optional)

Do you intend to try to help solve this bug with your own PR?
No, because I do not know how
Terms

[x] I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

This happens if your nested data structure is inconsistent and sometimes has undefined values. In previous versions, we even through errors here to prevent devs from trying this to prevent unintended behavior with all the other features. Now we just show the warning.
What I recommend doing here if you have inconsistent data structures is to use an accessorFn instead of accessorKey. That way you can gracefully handle undefined data and have proper fallback values.

Hi @KevinVandy,
Thanks for the quick response!! I guess I'm still a little confused about the "data structure is inconsistent" part. In my case, audit.create_utc is always there; it’s just that sometimes its value is undefined. Why is it that only a deeply nested key that gives the console error? To clarify more, my records (sorta) look like this:
const foo = {
   bar: ‘bar’,
   baz: undefined,
   audit: {
      create_utc: undefined
   }
}

When baz is undefined, MRT is fine with it; but when create_utc is undefined, I get the warning. In other words, I’m getting the warning when the value in a nested field is missing, not when one of the keys is missing (which I think is what you mean by “inconsistent data structure”).
So it seems like MRT is treating missing values differently for a top-level key vs a nested key.
I could use the accessorFn to resolve this, but we have a lot of these and obviously I lose all the advantage of the very convenient nested foo.bar syntax if I have to change them all to accessorFn.

"See related Tanstack Table issue 4788"

"See related Tanstack Table issue 4788"

You can use an accessorFn instead of the string accessorKey. In your accessorFn, you can handle the undefined checks how you want.


Hacks standard span names in, but redundantly parsing

This has no tests, and needs to be done similarly for flux. feel free to close this with a different PR or commit. The approach is redundantly parsing at the mvc layer even when servlet closes the span.
This is kindof ok for now I think, as we have other work in brave needed to make the practice more standard (because we might try to avoid redundant parsing for the small overhead it makes.. not sure it will be possible)
Once this is in, things look pretty by default. ex building then using snapshot on https://github.com/openzipkin/sleuth-webmvc-example Once something like this is together, I'd recommend cutting a milestone as pretty spans are better than "get", "get", "get"

BTW, this is https://github.com/spring-cloud/spring-cloud-sleuth/issues/802, however it doesn't add the http.route tag by default, rather just uses it for the span name. I think micrometer's tag policy is mildly different at least in case format anyway, but anyway span names are a great start

actually I think I have a more sustainable alternative:
All things layered on servlet add the request attribute "http.route" some time before a response completes. If the servlet closes the span, it can find and parse this. If something else closes the span, they use however they like.

we can do something like what's in this change temporarily until https://github.com/openzipkin/brave/pull/635 or we can merge that and rebase this.

I guess that's made obsolete via https://github.com/spring-cloud/spring-cloud-sleuth/pull/878 ?

I'd go with merging https://github.com/openzipkin/brave/pull/635 and updating Brave in Sleuth

yeah the other approach is better


'Error Occurred while handling request' while using download/upload

P.S. I did everything according to the steps given. In case it's something minor, i apologize, a newbie here :)

The logs are a bit different while using magnet link. The one above is for a direct link.

Can you restart the app? and send the full log by clicking on save by the bottom right after reproducing the error

Can you restart the app? and send the full log by clicking on save by the bottom right after reproducing the error

ravagervala-bot-logs-1653832238642.txt
Restarted the bot and used download command with a magnet link.

added a fix,re-deploy and let me know if it works

added a fix,re-deploy and let me know if it works

Alright.

Can you restart the app? and send the full log by clicking on save by the bottom right after reproducing the error

ravagervala-bot-logs-1653832238642.txt
Restarted the bot and used download command with a magnet link.

Deleting this comment cause it leaks your telegram bot token and database url
Please revoke your current token and get a new one

Deleted your log comment cause it leaked you telegram bot token and database url

Deleted your log comment cause it leaked you telegram bot token and database url

Thanks, btw I don't know if I messed something or what but the bot isn't responding to any commands. heroku logs show that it starts alright but no output for any commands.

Does the shared drive selection menu work fine now?

Does the shared drive selection menu work fine now?

It does. So does the sys_info

Haha thank you, I appreciate it :v:
Feel free to create a new issue if you face any problems

Can I keep the keep_alive variable false and use external tools like cronjob for customized waking. I don't need the bot to stay alive while I sleep only to waste dynos.

Yes, I added that feature cause I was too lazy to use services like uptime robot

Yes, I added that feature cause I was too lazy to use services like uptime robot

Haha, cool. Have a great day!

@CoolFool I'm still getting POST requests to my bot from old bot token. Any idea?
2022-05-29T17:00:45.826936+00:00 heroku[router]: at=info method=POST path="/2014201801:AAFQAA8AMyKYmeX6_IXQ_UDWs5KBsKQS47Y" host=ravagervala-bot.herokuapp.com request_id=9fc64f40-1147-4e2c-85bc-780a286ab6b9 fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=1ms status=404 bytes=393 protocol=https

Maybe telegram has two registered webhooks? Wait for a day and if it still occurs create a new instance

Maybe telegram has two registered webhooks? Wait for a day and if it still occurs create a new instance

new instance of?


Add all contributor specification and render in library detail page

PM

[ ] PI implications

Design

[ ] Redline

Dev

[ ] Determine and document how our system consistently uses All Contributors
[ ] Read all contributors content per library
[ ] Render contributor table in the library detail page
[ ] Initiate PRs to all indexed libraries to consistently attribute contributors

We're blocked in two different ways at the moment:

What are the PI implications of listing all contributors on Carbon's website?
The All Contributors CLI/bot works at the repo level. We actually want that at the library level (especially as we consolidate more into Carbon's monorepo) and also at the individual asset level. That doesn't seem possible with All Contributors. Is there a better way to do this?

For (2) above, you can configure types:

Specify custom symbols or link templates for contribution types. Can override the documented types.

We could add custom types per library and asset using their ids like library:carbon-styles, library:carbon-react, asset:tree-view to attribute maintainers on a per-library and per-asset basis.

@mattrosno what's the status here... I'm going to update the the library detail pages to make sure they align with what we've done with the asset detail pages here:
https://github.com/carbon-design-system/carbon-platform/issues/589
I will also add library slack channels like we have on the asset detail overview tab... but what's happening with the maintainers/contributors piece? I see you have a design spec listed above, but we already had a design speced out, unless the content is changing?

@jeanservaas the status:

I wanted to use the industry-standards "all contributors" to specify contributors and maintainers. We use that in the majority of Carbon's repos currently. We've identified two shortcomings where a) it tracks contribution at the repo level and not per subdirectory (per library), and b) it doesn't have the ability to specify contributions per asset either. If we can't use the industry-accepted way to do this, our options become "hardcoding" names in markdown, or adding ability to specify this through the schema. Both have high risk of becoming stale over time.
I recall outstanding questions if we even want to list individual names on a per-asset basis, or instead, if we wanted to guide users to support channels so the community can be set up to support by not encouraging DM questions.

Let's figure out our point of view on (2). And let's get support channels dialed in for v1. And then we figure out listing contributors later (could be deferred post-v1).

Confirmed with @jeanservaas and @kingtraceyj - no need to list individual maintainers on a per-asset basis because we want to guide our community to ask questions through official channels (Slack, Discord, GitHub Discussions) instead of asking maintainers directly.

Deferring this to post-v1.


[Bug]: react/no-array-index-key falsely triggered for Map.prototype.forEach()

Is there an existing issue for this?

[X] I have searched the existing issues and my issue is unique
[X] My issue appears in the command-line and not only in the text editor

Description Overview

When using the forEach method on a Map, the second parameter given to the callback function is not an index, but rather a key of the map. I believe this is quite different from a typical array index and doesn't align with the reasons why react/no-array-index-key exists, and it isn't really displayed in the example document as well.
For example, some code like this triggers the warning:

const map = new Map();
...
return (

  {map.forEach((item, key)=>
{item}
)}

)

Whereas I think it is reasonable to assume the key given here is a unique ID that is different from a typical array index, since it is a map, therefore giving it a warning by the name no-array-index-key is quite unintuitive.

Expected Behavior

With the same code above, there should be no warning regarding the key props inserted in the return statement of the Map.prototype.forEach() call, or at the very least a warning with a different description to not give it an array-specific warning title.

eslint-plugin-react version
v7.28.0
eslint version
v8.2.0
node version
v18.15.0

You’re right except that forEach always returns undefined, so this won’t actually render anything at all - iow, it’s a bug that you’re lucky enough the lint rule caught. You’ll have to use Array.from and a mapper function to do it properly, at which point the index rule would apply.

You’re right except that forEach always returns undefined, so this won’t actually render anything at all - iow, it’s a bug that you’re lucky enough the lint rule caught. You’ll have to use Array.from and a mapper function to do it properly, at which point the index rule would apply.

Wow, sorry I had completely missed that part. I will rephrase the issue again, as I believe the false alarm still applies in situations like this:
const map = new Map();
...
const results = [];
// react/no-array-index-key triggered here
map.forEach((item, key) => results.push(
{item}
));

return
{results.map((item) => item)}
;

Although I admit this is a bit of a niche use case...

It is; forEach is for side effects, side effects aren’t appropriate in React (except with useEffect), and your use case calls for .map :-)


upgrade to jboss-ip-bom 7.0.0.CR2

@romartin when upgrading locally dashbuilder to jboss-ip-bom 7.0.0.CR2 the build fails because of
https://gist.github.com/mbiarnes/82e7c3549f498eba591001640677b542
It appears to be a conflict of elastic search and lucene. This has to be fixed.

  Found in:
    org.apache.lucene:lucene-sandbox:jar:5.3.1:test
    org.apache.lucene:lucene-core:jar:4.10.4:test

means that the lucene artifact versions are getting mixed. We need to find out why is that happening and fix it.

The current ELS 1.7.1 version used by dashbuilder used is a bit old.
The newer ELS version 2.2 uses the same Lucene version as the IP BOM => Lucene 5.3.1
To avoid conflicts as well as fixing some existing issues with the older ELS version (see https://issues.jboss.org/browse/DASHBUILDE-64), I do recommend to upgrade dashbuilder to the most recent ELS 2.2 version.
@romartin Can you please take care of that?

@mbiarnes @dgutierr This will take some time, not sure if I will be able soon :( at least I would need the  confirm from my manager. If urgent please let me know and will try to ask about hits.

@mbiarnes why did you close it?
As far as I now, @roger is working on the upgrade to ELS 2.0 in order to align with the Lucene version required by the new IP BOM. Once he is done, we will be able to merge this PR.

@mbiarnes @dgutierr Yes, I'm working on the ELS upgrade, so we will be using same lucene version as the latest IP BOM next week :)

We should upgrade directly to IP BOM 7.0.0.CR3. We can of course do that as part of this PR.

@dgutierr @romartin
the will be hopefully ASAP the fix Roger is working on and then we will upgrade directly to 7.0.0.CR3. So a new PR will be raised.

@mbiarnes @psiroky @dgutierr Yes! Next week I will have the upgrade done. Please @mbiarnes remember to confirm if we can move to jackson-core 2.6.2, this PR depends on this. Thanks!

@romartin @dgutierr @psiroky pls look at
https://gist.github.com/mbiarnes/8afa5ac60f5039cac7f8834f232f570f when trying to upgrade to jboss-ip-bom 7.0.0.CR3 and when doing an overwrite of jackson-core 2.6.2

@mbiarnes that is expected I think. We need changes from Roger which upgrade ElasticSearch to 2.x.

@mbiarnes yes, as @psiroky says, this is the error i'm fixing by upgrading to ELS 2.X, but I need to be sure that upgrading to jackson-core 2.6.2 on our kie-parent works before that.


[MATLAB] Add Valid as a name-value pair on the arrow.array.Float64Array constructor

Describe the enhancement requested
This is a follow up to #35676 and #35598 .
To allow users to clearly specify which values in an input MATLAB array should be treated as null values when constructing an arrow.array.Array, it would be helpful to add a Valid name-value pair.
This name-value pair would correspond to the public Valid property which encodes the validity bitmap (i.e. null values) in an arrow.array.Array (proposed in #35598).
Adding this name-value pair would provide clients with a way to unambiguously control null value handling behavior when constructing arrow.array.Array objects.
Example:
>> matlabArray = double([1, -1, -1, 3, 4, 5])'

matlabArray =

     1
    -1
    -1
     4
     5

>> A = arrow.array.Float64Array(matlabArray, Valid=logical([true false, false, true, true]))

A =

[
  1,
  null,
  null,
  4,
  5
]

Component(s)
MATLAB

@sgilmore10 Could you add a take only comment here to assign you to this issue?

take


Fix crash when reloading tileset

Fixes https://github.com/CesiumGS/cesium-omniverse/issues/425
This is a workaround for https://github.com/CesiumGS/cesium-omniverse/issues/425. By retaining a reference to the path we avoid a crash deep in the Sdf library that's triggered by loading a tileset, removing the tileset, and reloading the tileset. It's possible this will be fixed in a future Kit release at which point we can remove this workaround.
I'm tracking this in https://github.com/CesiumGS/cesium-omniverse/issues/243

The best way to test this is to load Cesium World Terrain (untextured) from the Add Asset window.
Textures are causing different crashes that I'm still looking into.


Missing comma in example

In the example for Multi-day Events, there's a typo:
$('#calendar').clndr({
events: lotsOfEvents,
multiDayEvents: {
endDate: 'end'
startDate: 'start',
}
});
Should have a comma after: endDate: 'end'

Fixed, thanks