ProcessBackgroundActions and max cache sizes tuning questions

Hi,

is the thread calling tcmalloc::MallocExtension::ProcessBackgroundActions()
must be detached, or joinable?

If joinable is ok, can you do the following at program teardown:
  tcmalloc::MallocExtension::SetBackgroundProcessActionsEnabled(false);
  bkgThread.join();

by quickly scanning MallocExtension_Internal_ProcessBackgroundActions(), I have concluded that it was doing more than just release memory...
is this correct?
because I am planning keep BackgroundReleaseRate to its zero default value to avoid generating madvise() system calls...

tcmalloc::MallocExtension::SetBackgroundProcessSleepInterval()

default value is 1 second.
What is the reasonable range for that parameter?
1 second - 1 hour ?
What are the tradeoffs of a long interval vs short interval?
I had in mind 30 seconds for my app.
Does the background housekeeping tasks induce lock contention to the threads using the allocator?

Which stats to look at to determine that increasing the max cache sizes could have a positive effect?

overflows / underflows ratio?
anything else?

I have been running the gperftools benchmark to compare glibc, gperftools and this project...
https://github.com/gperftools/gperftools/blob/master/benchmark/malloc_bench.cc
unless tweaking the params, it seems like there is an obvious winner...
there must be something that your project do that is better in some way and I need your help to appreciate what makes your lib shine because so far, I am unconvinced...

Hi Chris,
I have noted that your prod config differ. The attempt to mimick what you do is the motivation behind having opened this issue in the first place.
As you know, I am perfectly aware of the possible rseq conflict with glibc. I did launch the tcmalloc bench with:
GLIBC_TUNABLES=glibc.pthread.rseq=0 ./malloc_bench
but I can be  even more explicit by testing tcmalloc::MallocExtension::PerCpuCachesActive() from main() before executing the tests...
I'll do that and report back

I'll redo the test just after a reboot with nothing else running... just in case...
but to be fair, pt2malloc and gperftools have been run in the exact same setup.
So I was comparing apples with apples in the first place...
I am just going to put all the odds for tcmalloc to shine...

it seems like google tcmalloc is slowed down by:
+   23.01%    23.00%  malloc_bench  malloc_bench          [.] tcmalloc::tcmalloc_internal::PageMap::sizeclass(tcmalloc::tcmalloc_internal::PageId) [clone .constprop.0]
+    8.29%     8.29%  malloc_bench  malloc_bench          [.] tcmalloc::tcmalloc_internal::IsNormalMemory(void const*)

those slowdowns does not appear to be present in the original gperftools version...

I have reproduced the benchmarks initially performed by Sanjay at
https://gperftools.github.io/gperftools/tcmalloc.html
back in ~2006 when gperftools have been published, its tcmalloc was dominating glibc with every parameters. A lot of things have changed. glibc has improved a lot

The takeaway that I see when looking at the results are:

glibc is the best allocator as soon as there 4 or more concurrent accesses
gperftools is the best option for very low contention scenarios and for bigger allocations
google tcmalloc is unfortunately the slowest allocator in all categories...

it seems like google tcmalloc is slowed down by:

23.01%    23.00%  malloc_bench  malloc_bench          [.]
tcmalloc::tcmalloc_internal::PageMap::sizeclass(tcmalloc::tcmalloc_internal::PageId) [clone .constprop.0]

8.29%     8.29%  malloc_bench  malloc_bench          [.] tcmalloc::tcmalloc_internal::IsNormalMemory(void const*)

If you see these functions, you probably do debug build.
IsNormalMemory is really a trivial one line helper that's always inlined in release build.
For tight new/delete benchmark you should see only 2 functions from tcmalloc: new and delete. These should not have a stack frame as well.

I provide the bazel build cmd line + the BUILD file used 2-3 entries ago...
something that I have added in the cmd line is --strip never so that perf can provide me the function names in its reports...
beside that, I am not seeing how I could be using the debug build...
the compile options are: -O3 -g
you can quickly review what I do and tell me if there is something missing but I don't think that I have made anything that would give me a debug build...

no background thread... see my questions in the first post... I am seeking help to correctly setup the background thread...
Sanjay testing params are 1000000 iterations... plenty of time to warm up... beside, it is the exact same conditions for every allocators...
I am not sure what we are doing here... I have the impression some shady not well understood explanations are thrown at the test/build params as being responsible plausibly for the bad result instead of searching for the root of the problem.
if there are some mandatory settings needed for good performance on basic benchmarks, should it not be the default values so that tcmalloc is at least on par with its predecessor?
You can reproduce what I have done... All I did is run your allocator with gperftools testing programs... Give it a shot and if you are able to get different and much better results than I did, please document how you have achieve that...
ps.: t-test1.c got deleted from the project but you can retrieve it by digging the commits with git...

It matter how the tcmalloc library is compiled. If you add -O3 for cc_binary, it does not affect dependent libraries.
Also -O3 should go into copts, not linkopts.

it seems like google tcmalloc is slowed down by:

23.01%    23.00%  malloc_bench  malloc_bench          [.]
tcmalloc::tcmalloc_internal::PageMap::sizeclass(tcmalloc::tcmalloc_internal::PageId) [clone .constprop.0]

* 8.29%     8.29%  malloc_bench  malloc_bench          [.] tcmalloc::tcmalloc_internal::IsNormalMemory(void const*)

If you see these functions, you probably do debug build. IsNormalMemory is really a trivial one line helper that's always inlined in release build.
For tight new/delete benchmark you should see only 2 functions from tcmalloc: new and delete. These should not have a stack frame as well.

this is to be confirmed but I am pretty sure that profilers are able to tell in which inlined functions they are in when sampled in the corresponding code section when the debug symbols are available...

I have included jemalloc into the benchmark...
something suspicious is that all allocators appears to suffer from a lock contention except glibc... what could be the common denominator?
I have no clue on how the thread_local keyword is implemented but this could be this guy...

there was a glitch in my measurement methodology. Here are the updated graphs:


var.USE_PUBLIC_IP as resource count

There is a bug in below line. Count expect to get a number.

Error: Incorrect value type
on google_ecfs.tf line 160, in resource "google_compute_instance" "Elastifile-EMS-Public":
160:   count        = "${var.USE_PUBLIC_IP}"
Invalid expression value: number required.
Error: Invalid operand
on google_ecfs.tf line 223, in resource "google_compute_instance" "Elastifile-EMS-Private":
223:   count        = "${1 - var.USE_PUBLIC_IP}"
|----------------
| var.USE_PUBLIC_IP is false
Unsuitable value for right operand: number required.

What did you use in the terraform.tfvar file?
it should be true or false, for example:
USE_PUBLIC_IP = true.
Can you share your  terraform.tfvar ?

Didn't receive a reply

I was running with TF ver 0.12, while the code does not support. you can close this issue


I made the code syntax look more presentable

I simply made the code easily readable and neater by aligning the properties in each selector on the same margin. Then I added spaces of one line each before a new selector was styled in the code.

@Solomon403   thanks for making your first contribution, I will be merging your Pull Request, also look at the issues so that you can get a chance to win a limited community Swag from me.
If you like the project and Repo please give it a star and Follow me on Github (would be appreciated)


Add Documentation that Native is a "magical" name

I wanted to restructure an elm app and moved some files from the Native directory to another directory. I assumed the name was given to the directory/module because the developer thought it was a good name for it. After hours of wondering why my code doesn't work and being annoyed by completely unhelpful compiler errors I figured it's because it has to be named Native. This isn't documented anywhere and was completely unobvious to me.

If you'd like to express your concern in a constructive way, please open another issue. See the process-bot comment above for guidelines on how to do this.

Haha sorry, I guess a was a little upset after digging through the code for hours without any progress. 😅


Add CI to build latex documents

It would be ideal to add the latex compilation to the CI on this repository in order to make sure pushed latex code compiles correctly. This github action workflow: https://github.com/xu-cheng/latex-action seems to be doing exactly that. Consider using it for the CI of this repository.

Ideally, the CI will run on macOS and Ubuntu. macOS support on the CI has been added to #13 as well as a Dockerfile for the Ubuntu builds. The CI will be extended to use this ubuntu image (configured with the necessary latex packages) for the linux builds.

Ideally, the CI will run on macOS and Ubuntu. macOS support on the CI has been added to #13 as well as a Dockerfile for the Ubuntu builds. The CI will be extended to use this ubuntu image (configured with the necessary latex packages) for the linux builds.

Closing this ticket as #13 has been merged and it contains a CI job for macOS build. The linux build will be added later.

Closing this ticket as #13 has been merged and it contains a CI job for macOS build. The linux build will be added later.


Feat/20 objective clean

Here is some converged work of @sindhu2993  and some new features I added, like 1D objective. And doc on the fourier space business.

Ok I make an issue that we want to move the scalar product into muFFT in the future

Sounds good!


Add new ubuntu versions

This was stopping my clang builds from working

+1 builds are failing now with runs-on: ubuntu-latest

Sorry, I was in no fit state to deal with my GitHub Actions for the past year. I'll try to keep up in the future.
This has been fixed when I was finally going over my actions and released. Thank you very much for your input.


CPU frequency is always pushed at max on NixOS

Issue description
On a laptop with Intel Skylake 6300HQ CPU frequency is always seen pushed to max on NixOS, no matter which kernel version I use or whether I'm on battery or not; while frequency is seen lowered fine on Ubuntu. Am I missing something?
Steps to reproduce
lscpu | grep MHz
powertop
both NixOS installer and installed system are affected
Technical details

System: (NixOS: nixos-version, Ubuntu/Fedora: lsb_release -a, ...)
Nix version: (run nix-env --version)
Nixpkgs version: (run nix-instantiate --eval '<nixpkgs>' -A lib.nixpkgsVersion)

Ah, its just the cpufreq scaling governor is set to powersave on Ubuntu, but to performance on NixOS.
Closing, sorry for the noise.

Ah, you figured it out already...
I was about to post that this is what works for me:
  powerManagement = {
    enable = true;
    cpuFreqGovernor = "ondemand";
  };

@NeQuissimus Thank you! Additionally I found this: https://github.com/NixOS/nixpkgs/issues/9611#issuecomment-138880363

I was not aware of this setting, is performance really a good default for most people?

@Mic92 I believe it should be either ondemand or powersave (for recent Intel CPUs) https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/config/power-management.nix#L72
But setting to powersave is still not fixed, that's why I got performance.


Update Program.cs: Update Command Line Description

Trying to start the program with the parameters given in the original description will result in args.Length==1. Removing the first set of quotes does not affect the parameter passing and can solve this problem.

I dont see where the problem is, quotes are not affecting the parameter count at all,
Typing ToCBS "C:" "D:" "E:" "OutputCabs"
results in 4 parameters.
Maybe you got lost somwhere...

namespace CommandLineBasics101
{
    internal class Program
    {
        static void Main(string[] args)
        {
            Console.WriteLine(args.Length);
        }
    }
}

CommandLineBasics101.exe "C:\" "D:\" "E:\" "OutputCabs"
4

I dont see where the problem is, quotes are not affecting the parameter count at all,
Typing ToCBS "C:" "D:" "E:" "OutputCabs"
results in 4 parameters.
Maybe you got lost somewhere... (especially with your command interpreter, some interpreters do parse \ as an escape character requiring you to double it after all, really not the fault of the program and the commit does a pointless change in that regard, we expect you know how to use a cli that is non standard in such case here...)

This is very strange, did a quick test and it seems that command argument passing works fine on powershell, but the wrong behavior occurs on both cmd and run (meta_l-r). OK, another problem caused by Windows itself.


Implement config file

After discussion, we decide to implement the following algorithm:

.testcaferc.json is a name of the configuration file.
<browser_name> and <sources> parameters become optional.  I.e. it's a possible to run TestCafe with testcafe command.
look in the current directory (process.cwd()) .testcaferc.json. If it exists then read options from it.
if there are user-defined options then merge them with options from configuration file and show the inform message 'The values for  from the configuration file will be ignored'.
run TestCafe

Implemented in https://github.com/DevExpress/testcafe/pull/3147


Linting of stdin?

Would it be acceptable to allow for linting stdin somehow? (so this could lint the output of some other tool more easily)
The workarounds I tried failed in pretty amusing ways:
$ echo 'FROM scratch' | dockerfilelint -
File not found
$ echo 'FROM scratch' | dockerfilelint /dev/stdin
Argument should be a file
$ dockerfilelint <(echo 'FROM scratch')
Argument should be a file

That's a great idea.  I can't think of a different way to try it, sounds like we need to get a PR with that change.

I admit I'm not terribly familiar with Node, but wouldn't removing the if (!stats.isFile()) { block entirely at least make /dev/stdin and the Bash redirection work properly?


FE - Fix logic/permissions on favouriting PDs, Investors & Projects

Description
This PR fixes inconsistencies / non-working / issues with favouriting projects, project developers & investors.
Some didn't work at all (eg: favouriting investors), so the functionality was added.
In this PR:

Added the possibility of favouriting an investor; it was not implemented
Added the possibility of favouriting a project from the project page; it was not implemented
Fixed "Favourite" and "Contact" buttons not working on public pages
The data we fetch in getServerSideProps never contains whether a PD/project/investor is a favourite nor the contacts. I don't think the solution in the PR is the best one (added a note to the respective places), but what I've done is re-fetch the data on the client, which will include them (assuming the user is logged in)
When favouriting a project from the project details card, I'm setting the new query data with setQueryData, but also invalidating the ProjectList query, to cause a (hidden) refetch and ensure the project list is up to date.
Reasoning being that if the user closes the project details card and re-opens it, the "favourite" property would be out of date because we pass the project data as a prop.

Others:

Added a projectContacts helper to centralise how we extract the contacts for a given project and reduce the risk of bugs
Fixed a couple incorrect useQuery keys making query invalidation not work correctly
Swapped the jsona package with deserialize-json-api
Although they both do the same, jsona was causing issues due to circular references. We were using cycle to solve this, but it wasn't a perfect solution. deserialize-json-api handles deserialisation better and removes all issues.
Fixed some linting issues

Testing instructions

As a signed-in user:

When viewing a project page, I can:

Favourite & unfavourite a project
The Favourite / Unfavourite button will reflect the current status

When viewing the search pages, Projects tab, I can:

Favourite and unfavourite a project by clicking on the Favourite button
The Favourite / Unfavourite button will reflect the current status
The project card contains two Favourite buttons, both will update in sync
Favouriting / unfavouriting a project will not cause the map pins to disappear

When viewing a project developer page, I can:

Favourite & unfavourite the project developer
The Favourite / Unfavourite button will reflect the current status

When viewing an investor page, I can:

Favourite & unfavourite the investor
The Favourite / Unfavourite button will reflect the current status

As a non-signed-in user:

When viewing a project page:

The Favourite / Unfavourite button will be disabled

When viewing the search pages, Projects tab:

The Favourite / Unfavourite buttons in the Project details card will be disabled

When viewing a project developer page:

The Favourite / Unfavourite button will be disabled

When viewing an investor page:

The Favourite / Unfavourite button will be disabled

Tracking
LET-720

@clementprdhomme

All good: the code looks good and the feature works as expected. Unfortunately, the current code introduces a regression. Could you have a look?

I've reverted the change, it's no longer needed either. :)


Zend\Session does not play nice with upload_progress

aydin
2:40 Can anyone help with this? Happens after form submission. Form is validated (and passes) via ajax. Then the page is redirected. During page redirection load this error is received: http://pastebin.com/EanZ92UT. If I reload the page it loads fine however, I am logged out from zfcuser and using developer toolbar I am once again a user with the guest role. The error is only seen after submitting
2:40 the form, never again.
aydin
2:43 :D
mwillbanks
2:44 aydin: what version of zf are you using?
2:44 ocramius: yeah… session makes me angry :)
2:44 i love the session but i have a profound hate for it as well
aydin
2:45 mwillbanks: 2.2.0
mwillbanks
2:45 if we stayed away from arrayobject everything would be fine
2:46 aydin: you are using 5.3.3 huh
2:47 ok so basically here is the basic part of what is going on
2:47 your session was corrupted
aydin
2:47 mwillbanks: 5.4.9
mwillbanks
2:47 how it was corrupted i have no idea at the moment
2:47 but it failed to unserialize the result
2:47 which then passed null to the exchangeArray
aydin
2:48 mwillbank: it happends only when my form iis submiitted :(
mwillbanks
2:48 so you said there was something with ajax in there
mwillbanks
2:48 are you passing it via ajax back to your controller?
2:48 in that ajax call how are you manipulating the session basically is what i am wondering :)
aydin
2:49 forget the ajax, it does it without it also :/
mwillbanks
2:49 really?
aydin
2:49 yup, i disabled it earlier
mwillbanks
2:49 could you pastebin your session configuration?
2:49 are you using upload progress anywhere?
2:49 apc, zend opcache, etc?
2:49 php version
aydin
2:49 i've not modified the session config, standard zfcuser + bjy
mwillbanks
2:49 hrm
aydin
2:50 but yes upload progress
mwillbanks
2:50 ugh; upload progress has seemingly been causing some folks issues
2:50 does that form have upload progress on it?
aydin
2:50 yeah, im sure I disabled it though and was still getting the exception. 1 sec i'll check
2:51 yeah I commmented out the progress action, however, may it being enabled in php.ini be causing problems?
2:52 i'll check
mwillbanks
2:52 yeah i'd try disabling it and seeing if that solves it… then it atleast gives me an area to start looking deeper into the issue
aydin
2:54 mwillbanks: damm that fixed it
aydin
2:54 try and do cool new things and it doesn't work :(
2:54 this php problem then?
mwillbanks
3:13 aydin: not exactly
3:13 aydin: could you try this...
3:13 wait...
3:13 nm
3:14 so here is what i think is happening
3:14 when the upload progress happens; it opens up and manipulates the session; but it does not go through the normal session handler
3:15 when it puts the data into the session it then stores it corrupting the session state
3:15 zend\session attempts to read in the session and unserialize it
3:15 resulting in the corruption due to the set being different than how upload progress saved it in
3:16 now how in the hell that happens; is unknown to me.  i'll likely have to dig pretty deep to figure it out
aydin
3:23 mwillbanks: damm, anyway I can help? Should I open an issue or something?
mwillbanks
3:23 aydin: absolutely you can help… do you understand php src at all?
3:23 :)
aydin
3:27 mwillbanks: no, I don't know the php src :/
mwillbanks
3:27 yeah so i think i kind of figured it out… how i am going to fix this… well that is a whole different story
3:27 http://lxr.php.net/xref/PHP_5_4/ext/session/session.c#2250
3:28 so; on php shutdown session gets saved right… well it injects itself as it's own callback
3:28 it sets the upload_progress and then restores the original
mwillbanks
3:34 alright i am going to open up an issue on GH and then i got to go home

Any Updates?
I still got the error using ZF 2.4 and PHP 5.5 on Ubuntu.
Can't use workaround above because I am using this session via whole application.

@tasmaniski I'm not certain that this is a fixable problem without a huge BC break.  That's part of the reason we haven't touched it.  There are far better technologies than using the upload progress such as an html5 based uploader where you upload a packet at a time.  A great example of this are tools like: http://www.plupload.com/

Unfortunately, I realized that it isn't fixable bug.
Also, can't use HTML5 because it doesn't support some browsers - thanks for the suggestion!
One solution was to rewrite AbstractContainer - write custom one.
the crucial thing for rewrite Zend\Session\AbstractContainer::createContainer
protected function createContainer(){
    return new \ArrayObject(array(), ArrayObject::ARRAY_AS_PROPS);
    //return new ArrayObject(array(), ArrayObject::ARRAY_AS_PROPS);
}

But since rest of my app use old one, I can't apply this solutions.
My workaround is probably the most ugliest but pretty workable.

During the login process I write in session  USER_ID separated from standard Zend\Authentication
In bootstrapSession() method I checked for hasIdentity() and user_id.

if( !$auth->hasIdentity() && $session->getStorage()->user_id ){
    $user = $userService->getUser($session->getStorage()->user_id);
    $auth->getStorage()->write($user);
}

The case when session is corrupted is when hasIdentity() is false but user_id is still in the session.
For that case I reset the user in Zend\Authentication. After this the reset of app will not break.
If anybody has better solutions please write.

@tasmaniski
Slightly off-topic but File-Api is very, very well supported in most
browsers. See http://caniuse.com/#feat=fileapi
tasmaniski<EMAIL_ADDRESS>schrieb am Fr., 22. Mai 2015 um
20:14 Uhr:

Unfortunately, I realized that it isn't fixable bug.
Also, can't use HTML5 because it doesn't support some browsers - thanks
for the suggestion!
One solution was to rewrite AbstractContainer - write custom one.
the crucial thing for rewrite
Zend\Session\AbstractContainer::createContainer
protected function createContainer(){
return new \ArrayObject(array(), ArrayObject::ARRAY_AS_PROPS);
//return new ArrayObject(array(), ArrayObject::ARRAY_AS_PROPS);
}
But since rest of my app use old one, I can't apply this solutions.
My workaround is probably the most ugliest but pretty workable.

During the login process I write in session USER_ID separated from
standard Zend\Authentication
In bootstrapSession() method I checked for hasIdentity() and user_id.

if( !$auth->hasIdentity() && $session->getStorage()->user_id ){
$user = $userService->getUser($session->getStorage()->user_id);
$auth->getStorage()->write($user);
}
The case when session is corrupted is when hasIdentity() is false but
user_id is still in the session.
For that case I reset the user in Zend\Authentication. After this the
reset of app will not break.
If anybody has better solutions please write.
—
Reply to this email directly or view it on GitHub
https://github.com/zendframework/zf2/issues/4821#issuecomment-104734534.

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html

I put "&" at offsetGet function and found for me:
//Zend/Session/AbstractContainer.php line 425
public function &offsetGet($key)


Back button in Metronome

🐛 Bug Report
Hey @niloysikdar
There is no back button in metronome.
Please assign it to me.
Thanks
Add relevant screenshot or video (if any)
(Add here)

/assign


cannot apply two match filters to one column

Is there a way to apply an "or" filters?
For example, this plunker, http://plnkr.co/edit/LIQCrxwgoKvSr5vaVJwy?p=preview I want to show people with age 20 and 30
Any ideas? Thank you!

In general the feature is build to work as an AND.  Having said that, the filter does take a regEx, so you could write an OR regEx: http://plnkr.co/edit/6aIq4YfaLxyNlvvCJVLe?p=preview
Having said that, it would be better if you could put that regEx in the term, so I may have a play with that.

Thank you. The solution is good enough for me


AttributeError: partially initialized module 'jax' has no attribute '_src' (most likely due to a circular import)

Not knowing what's wrong. Thanks for answering!~

Hi @Waterkin, I'm not sure what's up here but I suspect you can fix this by updating JAX to the latest version. You can find instructions to do so here: https://github.com/google/jax#installation

Hi @Waterkin, I'm not sure what's up here but I suspect you can fix this by updating JAX to the latest version. You can find instructions to do so here: https://github.com/google/jax#installation

Thanks for your reply, Tom~

Hi @Waterkin, I'm not sure what's up here but I suspect you can fix this by updating JAX to the latest version. You can find instructions to do so here: https://github.com/google/jax#installation

Thanks for your reply, Tom~

Did you solve this problem？


[Bug Report]: NestJS, watch mode don't close previuos server instance

Steps to reproduce

Run in watch mode
bun run dev
Do any change. Example: change getHello function. Then, watch modes should restart the server
Repeat step 2
Now, there is an error saying that there is something running on port 3000.

Reproduce link
https://github.com/Altro31/farm-project.git
What is actually happening?
Watch mode, when NestJS app is running, don't close the previous server instance
System Info
System:
    OS: Windows 11 10.0.22631
    CPU: (4) x64 AMD Athlon 200GE with Radeon Vega Graphics
    Memory: 8.86 GB / 21.92 GB
  Binaries:
    Node: 22.0.0 - D:\Dev\nodejs\node.EXE
    npm: 10.6.0 - D:\Dev\nodejs\npm.CMD
    pnpm: 8.14.1 - ~\AppData\Local\pnpm\pnpm.CMD
    bun: 1.1.20 - ~\.bun\bin\bun.EXE
  Browsers:
    Edge: Chromium (126.0.2592.113)
    Internet Explorer: 11.0.22621.3527

We'll take a look

@Altro31  I used bun and did not reproduce your problem. Are you using the latest version of farm/core?

1.3.0

Actually, i updated to v1.3.6, also create a new project and I still getting the same issue

Actually, i updated to v1.3.6, also create a new project and I still getting the same issue

Actually, i updated to v1.3.6, also create a new project and I still getting the same issue

Could you please create an exmaple repository which can reproduce this issue to help use locate this issue?

Actually, i updated to v1.3.6, also create a new project and I still getting the same issue

Could you please create an exmaple repository which can reproduce this issue to help use locate this issue? I can't reproduce the problem consistently.

https://github.com/Altro31/farm-project.git

This may be a farmup bug. I'll fix it.

Hello, @Altro31  installing the latest farmup version should solve your problem. The reason is that the previous child process has not been killed but the next child process has been opened, causing a port conflict.

If the problem is solved, I will close this issue first.


After last update, pomodoro section is broken

On ubuntu 18.04, After update, pomodoro section is broken.
I don't know what is the info needed for troubleshooting.
I updated from gnome extension web. Then i uninstalled and cloned from github repo, with the same problem. All sections works except pomodoro.

Fixed. Will take a while to update on the extensions site though...

Thanks


(ci/fix): allow prs done from bots OR from forks be executed when the label safe is added

What this PR does / why we need it:
Six the problem where tests has been skipped when:

a) they are done from a fork PR and have the label @action/safe-to-test (i.e https://github.com/replicatedhq/kots/pull/3395)
OR
b) they are done from the dependency bot (i.e https://github.com/replicatedhq/kots/pull/3394)

Which issue(s) this PR fixes:
Closes: https://github.com/replicatedhq/kots/pull/3395
Special notes for your reviewer:
More info: https://replicated.slack.com/archives/CM8N4TWR0/p1667859937228889
Steps to reproduce

Check the PR done to test it out: https://github.com/replicatedhq/kots/pull/3395
Check the debug output to verify the data in the conditions (see that the github.event_name is 'pull_request' from the fork ): https://github.com/replicatedhq/kots/actions/runs/3417779228/jobs/5689304031

Then, we can review the changes in the conditional.
Does this PR introduce a user-facing change?
NONE
Does this PR require documentation?
NONE

Copying from Slack:

I am not sure if this will work because pull_request does not have access to repository secrets when triggered from an external fork, so the tests will run, but those using secrets will fail.

we used to have pull_request_target, but it was removed to allow for proper branch protection with the validate-success step

We have SC-61272 open to prioritize being able to run tests on dependabot PRs and external forks.  It seems we may need to re-work how we are doing branch protection in order to accomplish this?

/hold


BugCheck 0x139 Subtype 1d

I can not see subtype 1d in the docs. WinDbg Defines subtype 1d as "An RTL_BALANCED_NODE RBTree entry has been corrupted."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1073c44-369a-9365-a2a7-ea5b064fb1af
Version Independent ID: 28187f46-abb9-c7cb-9b22-ddd4a2ec9d37
Content: Bug Check 0x139 KERNEL_SECURITY_CHECK_FAILURE - Windows drivers
Content Source: windows-driver-docs-pr/debugger/bug-check-0x139--kernel-security-check-failure.md
Product: windows-hardware
Technology: debugger
GitHub Login: @DOMARS
Microsoft Alias: domars

@TheBestYTech - As it turns out, this topic is providing the decimal value and 0x1D = 29  An RTL_BALANCED_NODE RBTree entry has been corrupted. In general in the docs, values that are provided in hex are prefaced by 0x, otherwise base 10 is used.
Thanks for your interest in the debugger bug check documentation, and good luck with your debugging.


exitAtFirstDate - overlapping cohort error

When cohort exit is not included there is the possibility of creating overlapping records. We can fix this by collapsing any overlapping records created
library(CohortConstructor)
cdm <- mockCohortConstructor(
  tables = list(
    "cohort" = dplyr::tibble(
      cohort_definition_id = c(1, 1, 2, 2),
      subject_id = c(1, 1, 2, 2),
      cohort_start_date = as.Date(c("2000-01-01", "2000-01-03",
                                    "2001-01-01", "2000-01-03")),
      cohort_end_date = as.Date(c("2000-01-01", "2000-01-03",
                                  "2001-01-01", "2000-01-03")),
      # add 5 days
      date_1 = as.Date(c("2000-01-05", "2000-01-08",
                         "2001-01-05", "2000-01-08")),
      # example days to exit
      date_2 = as.Date(c("2005-01-01", "2005-01-01",
                         "2005-01-01", "2005-01-01"))
    )
  ),
    con = DBI::dbConnect(duckdb::duckdb()),
  writeSchema = "main"
)
#> Warning: ! 7 column in person do not match expected column type:
#> • `person_id` is numeric but expected integer
#> • `gender_concept_id` is numeric but expected integer
#> • `year_of_birth` is numeric but expected integer
#> • `month_of_birth` is numeric but expected integer
#> • `race_concept_id` is numeric but expected integer
#> • `ethnicity_concept_id` is numeric but expected integer
#> • `location_id` is numeric but expected integer
#> Warning: ! 2 column in observation_period do not match expected column type:
#> • `person_id` is numeric but expected integer
#> • `period_type_concept_id` is numeric but expected integer
#> Warning: ! 9 column in cdm_source do not match expected column type:
#> • `cdm_source_abbreviation` is logical but expected character
#> • `cdm_holder` is logical but expected character
#> • `source_description` is logical but expected character
#> • `source_documentation_reference` is logical but expected character
#> • `cdm_etl_reference` is logical but expected character
#> • `source_release_date` is logical but expected date
#> • `cdm_release_date` is logical but expected date
#> • `cdm_version` is numeric but expected character
#> • `vocabulary_version` is logical but expected character
#> Warning: ! 3 column in concept do not match expected column type:
#> • `concept_id` is numeric but expected integer
#> • `valid_start_date` is character but expected date
#> • `valid_end_date` is character but expected date
#> Warning: ! 1 column in vocabulary do not match expected column type:
#> • `vocabulary_concept_id` is numeric but expected integer
#> Warning: ! 5 column in concept_relationship do not match expected column type:
#> • `concept_id_1` is numeric but expected integer
#> • `concept_id_2` is numeric but expected integer
#> • `valid_start_date` is logical but expected date
#> • `valid_end_date` is logical but expected date
#> • `invalid_reason` is logical but expected character
#> Warning: ! 2 column in concept_synonym do not match expected column type:
#> • `concept_id` is numeric but expected integer
#> • `language_concept_id` is numeric but expected integer
#> Warning: ! 4 column in concept_ancestor do not match expected column type:
#> • `ancestor_concept_id` is numeric but expected integer
#> • `descendant_concept_id` is numeric but expected integer
#> • `min_levels_of_separation` is numeric but expected integer
#> • `max_levels_of_separation` is numeric but expected integer
#> Warning: ! 9 column in drug_strength do not match expected column type:
#> • `drug_concept_id` is numeric but expected integer
#> • `ingredient_concept_id` is numeric but expected integer
#> • `amount_unit_concept_id` is numeric but expected integer
#> • `numerator_unit_concept_id` is numeric but expected integer
#> • `denominator_value` is logical but expected numeric
#> • `denominator_unit_concept_id` is numeric but expected integer
#> • `box_size` is numeric but expected integer
#> • `valid_start_date` is character but expected date
#> • `valid_end_date` is character but expected date
#> Warning: ! 2 column in cohort do not match expected column type:
#> • `cohort_definition_id` is numeric but expected integer
#> • `subject_id` is numeric but expected integer
#> Warning: ! 2 column in person do not match expected column type:
#> • `person_id` is numeric but expected integer
#> • `location_id` is numeric but expected integer
#> Warning: ! 1 column in observation_period do not match expected column type:
#> • `person_id` is numeric but expected integer
#> Warning: ! 2 column in cohort do not match expected column type:
#> • `cohort_definition_id` is numeric but expected integer
#> • `subject_id` is numeric but expected integer
# overlapping cohort error
cdm$cohort1 <- cdm$cohort |>
  exitAtFirstDate(
    dateColumns = c("date_1", "date_2"),
    returnReason = TRUE,
    name = "cohort1"
  )
#> Error in `validateNewCohort()` at CohortConstructor/R/exitAtColumnDate.R:189:3:
#> ! There are new cohort end dates which resulted in overlapping records.
#>   Please check the dates provided in `dateColumns`.
#> Backtrace:
#>     ▆
#>  1. └─CohortConstructor::exitAtFirstDate(...)
#>  2.   └─CohortConstructor:::exitAtColumnDate(...) at CohortConstructor/R/exitAtColumnDate.R:37:3
#>  3.     └─CohortConstructor:::validateNewCohort(newCohort, cdm, tmpName) at CohortConstructor/R/exitAtColumnDate.R:189:3
#>  4.       └─cli::cli_abort("There are new cohort end dates which resulted in overlapping records.\n                   Please check the dates provided in `dateColumns`.") at CohortConstructor/R/exitAtColumnDate.R:256:5
#>  5.         └─rlang::abort(...)

Created on 2024-10-11 with reprex v2.0.2

Ah I see this is actually an expected https://github.com/OHDSI/CohortConstructor/blob/ac32f5ca4aed9e6fbaad6bb2b61470846f2e1afd/tests/testthat/test-exitAtColumnDate.R#L151
At the very least need to better document this, but could also think whether to allow this behaviour

If I recall correctly, at that moment we agreed that the user should be responsible to enter valid dates instead of us altering cohort entries


removed the antlr requirement from daiquiri

Antlr is a dependancy of queryparser not daiquiri.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.877%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4591

Relevant Lines:
6969

💛  - Coveralls


Problem: function "MergeWordLayout" in codeunit 9651 "Document Report Mgt." -> Usage of parameter "PrinterName" on event "OnBeforeMergeDocument"

Hello,
we are using the "OnBeforeMergeDocument" event in funktion "MergeWordLayout" (Codunit 9651 "Document Report Mgt.") in order to provide a alternate ISV solution for printing/exporting reports.
The standard call, which is allready implemented is:
OnBeforeMergeDocument(ReportID,ReportAction,InStrXmlData,PrinterName,OutStrWordDoc,Handled,FileName = '');
But we need the parameter "FileName" instead of "PrinterName":
OnBeforeMergeDocument(ReportID,ReportAction,InStrXmlData,FileName,OutStrWordDoc,Handled,FileName = '');
Maybe this is a bug or a unfortunate implementing in the current solution.
If we do not get the "FileName" as parameter in the event call, we do not have a chance to implement a different version of for example "SAVEASPDF" in the "OnBeforeMergeDocument". Because "PrinterName" is only filled, if the ReportAction is "Print". We can not access the "FileName", which is nessesary in this case.
I think, this would be a great benefit, even for everyone, who wants to use this "OnBeforeMergeDocument" event and it would not crash current implementions, because the "FileName" even holds the printername, if the ReportAction is "Print".
Best regrads
Jürgen Markgraf

Right, PrinterName parameter gets a value only if report action is printing.
The internal FileName value will not be exposed due to security reasons, the only thing we provide is a flag IsFileNameBlank. It was added as an answer to GitHub 3125


Added Jep into NOTICE file

Should we add TOMLJ as well? And should I mention Pytorch example repo in my PR as well?

I wasn't sure about tomlj, since it's only used in integration tests. But I'll add it in anyway.


Harmozine dependencies in .cabal file

If we list a package more than once we should be consistent on the version we request. Even better, we should request every package only once
@sestrella

Hi
Regarding dependencies:
Is it possible to keep the versions compatible with the Stackage LTS 2.1 release ?
I made some changes in a pull request to do that #20. Should be a matter of keeping them.
Finlay

@finlay that's definitely a concern for me. Using Stackage alleviates a lot of headaches.

@jsantos17 what else we are missing in order to close this issue? there is a PR already merged related to this

@jsantos17 It all works with Stackage 2.1, so maybe we can close this issue

@juanpaucar already tested it with Stackage LTS and it appears to work fine.
On Thu, Apr 23, 2015 at 9:59 AM, Juan Paucar<EMAIL_ADDRESS>wrote:

@jsantos17 https://github.com/jsantos17 It all works with Stackage 2.1,
so maybe we can close this issue
—
Reply to this email directly or view it on GitHub
https://github.com/stackbuilders/octohat/issues/27#issuecomment-95615371
.

#27 fixed this. Closing.


Update what-is-nuget.md

Docs Build status updates of commit 82994ab:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/what-is-nuget.md
:warning:Warning
View
Details

docs/what-is-nuget.md

Line 64, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/nuget/concepts/dependency-resolution' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 102, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/nuget/concepts/dependency-resolution' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 5, Column 12: [Suggestion-ms-author-invalid] Invalid value for 'ms.author', 'karann' is not a valid Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 82994ab:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/what-is-nuget.md
:warning:Warning
View
Details

docs/what-is-nuget.md

Line 64, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/nuget/concepts/dependency-resolution' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 102, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/nuget/concepts/dependency-resolution' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 5, Column 12: [Suggestion-ms-author-invalid] Invalid value for 'ms.author', 'karann' is not a valid Microsoft alias.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

I am closing this PR for now due to inactivity. If you'd like to pick up this work again, please open this again & make the relevant changes.


IRASA method

Quoting from the FieldTrip website

IRASA allows distinguishing rhythmic activity from concurrent power-spectral 1/f modulations. The technique virtually compresses and expands the time-domain data with a set of non-integer resampling factors prior to Fourier-based spectral decomposition. As a result, rhythmic components in the power-spectrum are redistributed while the arrhythmic 1/f distribution is left intact. Taking the median of the resulting auto-spectral distributions extracts the power-spectral 1/f component, and the subsequent removal of the 1/f component from the original power-spectrum offers a power-spectral estimate of rhythmic content in the recorded signal.

The math on this doesn't appear too bad, but figuring out an appropriate interface might be a little bit more complicated, including what to return and which classes to have this as a method.

In case that's helpful, I've implemented IRASA (as a function) here:
https://github.com/raphaelvallat/yasa/blob/200659872405fcc7d5477fd1069e328a372d3e9b/yasa/spectral.py#L229

That's quite helpful! Especially since it's already licensed under 3 clause BSD.

I guess this would be an mne.preprocessing method?
@palday do you want to try the method out using @raphaelvallat's code first?

That's the plan, but it definitely won't happen this week and probably not next....


Stories not displaying in the web browser- react-native

If you are reporting a bug or requesting support, start here:
Bug or support request summary
I created the stories and when running on browser then when I click on the any story
the stories were not displaying in the right pane of the browser
Actually they should display respective stories.
Steps to reproduce
I installed the storbook and run npm run storybook
Here is the screen shot:

Actually commentView story is selected but there is nothing displaye din the right pane
tis is what I have in package.json file
"@storybook/addon-storyshots": "^3.2.3",
"@storybook/react-native": "^3.3.15",
"@storybook/addon-actions": "^3.3.15",
"@storybook/addon-links": "^3.3.15",
"@storybook/addons": "^3.3.15"

In app it is working fine but when coming to browser it is not displaying

Quick question:
I've got everything up and running for React Native but was wondering if it was possible to have 2 simulators open at the same time, one with the storybook UI and one with the app being developed UI?
If this isn't possible, does it mean I have to shut down the packager to switch between seeing my app and storybook on the simulator?

@joegoodall1 you'll need to run two different packagers, one with the storybook script and the other with whatever you use to bundle your app

Thanks for replying so quickly @danielduan.
Can you give me some pointers on how to implement this? Is there a link to an example that is set up and working?
I did try the link here to use the haul packager but that was unsuccessful in running Storybook and our app at the same time.


builder: avoid parsing null- string to nil slice (issue #15634)

Fixes #15634
Currently parsing args in ADD, COPY and VOLUME instructions uses Decoder.Decode() first, and it binds nil if given bytes start with null.
This PR fixes to avoid parsing null string to nil slice by checking if the string starts with [.
Signed-off-by: Soshi Katsuta<EMAIL_ADDRESS>

ping @duglin

@skatsuta overall it looks good.  Can you do me a  favor and add an integration-cli test too? I'd like to make sure that nothing else in the total flow does anything weird with args that start with "null".  It also ensures that if we rip out the parser and replace it with something else we'll still cover this case.

@duglin Thank you for your review!
I added a integration test. If there's another missing test context, please comment and I'll add it.

@skatsuta thanks for adding the test.
One minor comment, if you want to tweak it.
Either way, LGTM if janky is happy.

@duglin That statement is easier to read. I modified it to use c.Assert().

LGTM

poor windows, needs some vitamin C or something  :-)


Use RenderTree for tree display

This quickly got out of hand.
So, instead of just using RenderTree for the nicer lines, I have

refactored the selection methods, so they're not as long as before and better readable
added type hints wherever possible (which is nice, because my initial PR had wrong type hints)
added colour customization to the multi select (fixes the todo)
added parentheses customization
fixed some PEP8 stuff

Sorry for having all of this in one MR instead of having multiple PR for each topic.

I'm pretty sure I knew why these are failing, hold on a second

It was Python 3.9's older type hint style :)


Fix: Expensify Card - issued starts with a lowercase i on shipping address message

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/51386
PROPOSAL: https://github.com/Expensify/App/issues/51386#issuecomment-2434566100
Tests
Same as QA Test

[x] Verify that no errors appear in the JS console

Offline tests
Same as QA Steps
QA Steps

Issue a physical card to a member
Sign in with the member's account
Go to the workspace chat
Verify that the "Issued" text starts with an uppercase letter
Change the language to Spanish
Verify that the "Emitió" text starts with an uppercase letter

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/d49b5688-28c9-4855-bfa3-121e25bbe470

Android: mWeb Chrome
https://github.com/user-attachments/assets/48031ae4-abef-4040-870a-e093683e1d39

iOS: Native
https://github.com/user-attachments/assets/3e9306cd-59ef-462f-8abe-5059923da342

iOS: mWeb Safari
https://github.com/user-attachments/assets/39e62f14-5071-42a5-967e-f90700ec544c

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/24e370c1-368d-490e-83dc-7008526aedfe

MacOS: Desktop
https://github.com/user-attachments/assets/70f4232a-17ea-4671-83ba-ab1727167faf

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/3ff71d16-23bb-474d-92ae-0c0f7c47e57a

Android: Native
https://github.com/user-attachments/assets/225a0794-9810-47eb-986f-4fe17b268510

iOS: mWeb Safari
https://github.com/user-attachments/assets/19e4a954-12a6-41b2-89b4-17c0c4eb4f88

Android: mWeb Chrome
https://github.com/user-attachments/assets/5eba31a1-4e46-4a6c-81c6-5603373108c3

iOS: Native
https://github.com/user-attachments/assets/f412d4f2-1a1e-444e-8311-7b2f6fd38275

MacOS: Desktop
https://github.com/user-attachments/assets/554bac4f-d3fa-49be-9fc9-8cbd1f3df53d

There is a leading i character in Spanish translation as mentioned https://github.com/Expensify/App/pull/51941#discussion_r1827450949 but looks like it’s intentional.

That's an exclamation point and it appears to be intentional.

There is a leading i character in Spanish translation as mentioned #51941 (comment) but looks like it’s intentional.

That's an exclamation point and it appears to be intentional.

Ok. Got it. That brings us to the only pending query from comment here as mentioned below:

And if we won't capitalize it this inverted exclamation mark is probably incorrect in this case
UserName ¡emitió a ${assignee} una Tarjeta Expensify!

As this needs feedback from the Spanish translation team, I have posted it in slack here

Sorry, even if it doesn't match the English version exactly, for the Spanish copy I would remove ¡ and !.
But just to be sure, can you confirm how all the copies (English/Spanish) would look and I can do one final review? Thanks!

Since this PR is closed, we can take this up in the issue itself here


unable to load project in sts

hello everyone,
i imported  serposcope in sts...its imported but im unable to make jar file of it or run it on sts. its shows error in  sts in particulary in core. as in core  we are trying to import querybuilder package but in src/main/java but there is no querybuilder package @noguespi @ron51.....kindly help.

Hi.. I do not use STS. I am quite new to building in Java too. I successfully build the project by following closely on the instructions at https://github.com/serphacker/serposcope/blob/master/BUILD-INSTRUCTIONS.md

@noguespi Can you check this out, we have a developer who can contribute to this project. If you can help then we will be able to resolve issues quickly and maintain this project.

@ron51 I have tried building from the master branch. It seem like there is 2 issues but not the error from your screenshot.
Can you try not using STS to narrow down the problems? I suggest running from the command line: mvn -Dcodegen clean install -U in the project root.
There is a package javax.annotations dependency missing, so I added the following in core/pom.xml.
        <dependency>
            <groupId>javax.annotation</groupId>
            <artifactId>javax.annotation-api</artifactId>
            <version>1.2</version>
        </dependency>

Do let me know how things works out.

also it requires java 8

yes its resolved.i followed all build instructions..now i could deploy it locally..but i couldnot do it in superdev mode..there was an error like no goals defined when i ran following command in serposcope/web folder
mvn ninja:run
-Dninja.mainClass=serposcope.lifecycle.Daemon
-Dninja.jvmArgs="-Dlogback.configurationFile=dev/logback-stdout.xml -Dserposcope.datadir=/var/tmp/serposcope -Dserposcope.db.options=;AUTO_SERVER=TRUE"
so i did only "mvn ninja:run"..
im able to see UI of it

@noguespi Can we schedule a call on Zoom? If yes, then please forward me your email id, I will send you an email with timings and invite.


[6.0] Sema: Fix incorrect use of STL iterator in associated type inference

6.0 cherry-pick of https://github.com/swiftlang/swift/pull/74800

Description: Crash-on-invalid from forgetting to compare STL iterator with end().

Origination: Regression in Swift 6 associated type inference implementation.

Risk: Very low, because the old behavior was UB.

Radar: rdar://problem/127575477.

@swift-ci Please test


improve performance on intel graphics

And split out the sky blend into a separate file, so we can more easily have add a CPU version later, if needed.

On the integrated graphics in my laptop (intel ?) this decreases frame time from 33ms to 6ms for the "jungle sprite test". It also seems to improve things for dass (has AMD GPU). There is a very small improvement on NVIDIA for me.
List of changes:

fix a bug with listener sending large files, like default-menu.gc causing a 16-bit integer to overflow
confirm that texture q is 1 for all tie/tfrag and avoid the divide in the fragment shader.
do blending of the sky on the CPU by default (optionally can go back to old GPU method).  The GPU based blending used a bunch of weird opengl stuff that might be slow.
properly use vertex array object for direct renderer
use a single attribute buffer for direct renderer instead of separate position, texture, rgba
use floats for direct renderer vertex positions (uint32 has issues on amd)
use a different part of the attribute buffer for different draws to avoid having to synchronize on each draw. Some drivers might be able to figure out how to avoid this, but intel on linux doesn't. Done in direct, tie, and tfrag.
increase vertex buffer sizes in a few places
use separate textures/buffers per tree in tfrag/tie to avoid synchronizing on each tree switch due to overlap.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 315 (0.63%)  changed or added relevant lines in 16 files are covered.
15 unchanged lines in 7 files lost coverage.
Overall coverage decreased (-0.05%) to 53.431%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/level_extractor/extract_tfrag.cpp
0
1
0.0%

decompiler/level_extractor/extract_tie.cpp
0
1
0.0%

game/graphics/opengl_renderer/SkyBlendCommon.h
0
1
0.0%

game/graphics/opengl_renderer/debug_gui.h
0
1
0.0%

game/overlord/iso.cpp
0
1
0.0%

game/graphics/opengl_renderer/debug_gui.cpp
0
2
0.0%

game/graphics/pipelines/opengl.cpp
0
2
0.0%

game/graphics/opengl_renderer/SkyRenderer.cpp
0
7
0.0%

game/graphics/opengl_renderer/OpenGLRenderer.cpp
0
12
0.0%

game/graphics/opengl_renderer/tfrag/Tfrag3.cpp
0
19
0.0%

Files with Coverage Reduction
New Missed Lines
%

decompiler/level_extractor/extract_tfrag.cpp
1
0%

game/graphics/opengl_renderer/DirectRenderer.h
1
0%

game/graphics/opengl_renderer/SkyRenderer.cpp
1
0%

game/graphics/opengl_renderer/DirectRenderer.cpp
3
0%

game/graphics/opengl_renderer/OpenGLRenderer.cpp
3
0%

game/graphics/opengl_renderer/tfrag/Tfrag3.cpp
3
0%

game/graphics/opengl_renderer/tfrag/Tie3.cpp
3
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.05%

Covered Lines:
40853

Relevant Lines:
76459

💛  - Coveralls


Collaborators wanted

The developer of zorbage-viewer is looking for collaborators who want to add some visualization and or data processing code to the zorbage-viewer. It would be a fun project for the right people. Please respond to this issue if you'd consider doing something like this.

I could imagine using your library as a image/file formats library for a new Symja module:

https://github.com/axkr/symja_android_library

Fell free to start a discussion here:

https://discord.gg/GFFW8EkJ

@axkr I get an error that your discord invite is invalid (using Chrome). Feel free to share a new link if possible.

I edited the above link and tested it with Chrome.


Provide utility to print Atom name during debug

Cannot be done through the Debug trait, so should be a separate utility.
Involves significant amount of additional code generation, so should be hidden behind a cargo feature debug_atom_names.
API:
trait DebugAtomNames {
    fn debug_atom_names(&self, f: &mut fmt::Formatter<'_>, c: &Connection) -> Result<(), fmt::Error>;
}

This debug print will have side effects as a request will be sent for each atom that is not in the list of predefined atoms.

This is finally done by having global variable, and through the fmt::Debug mechanism.
So users only have to activate the feature and it works without code modification.
Closed by #129


New BG grants section

Sharing an idea/proposal for the BG grants section for the landing page. It's essentially a CTA, same design that we're using in other places for announcing the grants. Some notes on it:

Check if we like that paragraph text (it's the main intro text we're using everywhere)
We also discussed if it would make sense to merge all funding sections in one and talk about: streams, cohorts and grants all at once, but I think we agreed that we were gonna keep them separate so they can shine a bit more.
I'll correct text spacing cause it looks a bit weird now

Merged!


Issue on building ATS with quic support

Hi Team,
I am new to ATS and trying to build ATS with QUIC support but facing below error
root@ubuntu:~# git clone git@github.com:apache/trafficserver.git || git clone https://github.com/apache/trafficserver.git
Cloning into 'trafficserver'...
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Cloning into 'trafficserver'...
remote: Enumerating objects: 195787, done.
remote: Counting objects: 100% (1918/1918), done.
remote: Compressing objects: 100% (1136/1136), done.
remote: Total 195787 (delta 989), reused 1510 (delta 754), pack-reused 193869
Receiving objects: 100% (195787/195787), 147.62 MiB | 10.26 MiB/s, done.
Resolving deltas: 100% (148343/148343), done.
root@ubuntu:~# cd trafficserver/
root@ubuntu:~/trafficserver#

root@ubuntu:~/trafficserver# autoreconf -if
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'm4/_aux'.
libtoolize: copying file 'm4/_aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:790: installing 'm4/_aux/ar-lib'
configure.ac:678: installing 'm4/_aux/compile'
configure.ac:109: installing 'm4/_aux/config.guess'
configure.ac:109: installing 'm4/_aux/config.sub'
configure.ac:46: installing 'm4/_aux/install-sh'
configure.ac:46: installing 'm4/_aux/missing'
configure.ac:2375: error: required file 'iocore/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/aio/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/io_uring/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/cache/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/dns/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/eventsystem/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/hostdb/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/net/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/net/quic/Makefile.in' not found
configure.ac:2375: error: required file 'iocore/utils/Makefile.in' not found
configure.ac:2375: error: required file 'mgmt/Makefile.in' not found
configure.ac:2375: error: required file 'mgmt/rpc/Makefile.in' not found
configure.ac:2375: error: required file 'mgmt/config/Makefile.in' not found
configure.ac:2375: error: required file 'proxy/Makefile.in' not found
configure.ac:2375: error: required file 'proxy/hdrs/Makefile.in' not found
configure.ac:2375: error: required file 'proxy/http/Makefile.in' not found
configure.ac:2375: error: required file 'proxy/http/remap/Makefile.in' not found
configure.ac:2375: error: required file 'proxy/http2/Makefile.in' not found
configure.ac:2375: error: required file 'proxy/http3/Makefile.in' not found
configure.ac:2375: error: required file 'proxy/logging/Makefile.in' not found
configure.ac:2375: error: required file 'proxy/shared/Makefile.in' not found
Makefile.am:30: error: required directory ./iocore does not exist
Makefile.am:30: error: required directory ./proxy does not exist
Makefile.am:30: error: required directory ./mgmt does not exist
parallel-tests: installing 'm4/_aux/test-driver'
example/plugins/c-api/Makefile.am: installing 'm4/_aux/depcomp'
autoreconf: error: automake failed with exit status: 1
root@ubuntu:~/trafficserver#

i am following steps from https://github.com/apache/trafficserver/wiki/HTTP-3-Documentation
root@ubuntu:~/trafficserver# uname -a
Linux ubuntu 5.15.0-60-generic #66-Ubuntu SMP Fri Jan 20 14:29:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
root@ubuntu:~/trafficserver# cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04.3 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.3 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy
root@ubuntu:~/trafficserver#

Could someone please help or am i missing anything here?

@Karthikdasari0423  We are on the process of moving our build system over to cmake.  I will update the documentation.

@bryancall is here any alternative way to build ATS with quic support?

I updated the documentation to build with cmake.  I am testing the changes with fresh Fedora 39 and Ubuntu 22.04 docker images and will update this comment when completed.  It looks good so far.

sure @bryancall

It is working on well on Fedora 39.  On ubuntu 2022.04 I am seeing this message when enabling debug logs and it doesn't finish a test curl request.
[Oct 25 18:49:26.314] [ET_UDP 0] DIAG: <QUICPacketHandler_quiche.cc:267 (_recv_packet)> (quic_sec) [d04832af-ed1c1ff5] client initial dcid=0xed1c1ff5da16e04e71d3cda3faa63b94aba79c06
[Oct 25 18:49:26.517] [ET_UDP 0] DIAG: <QUICPacketHandler_quiche.cc:267 (_recv_packet)> (quic_sec) [0157b458-7b2ffa11] client initial dcid=0x7b2ffa11862b32d79c40926235dc64e8f3d1d097
[Oct 25 18:49:26.718] [ET_UDP 0] DIAG: <QUICPacketHandler_quiche.cc:267 (_recv_packet)> (quic_sec) [2a412aa6-1b8e0474] client initial dcid=0x1b8e04741fd043ed43eb0e725ace01d33aaa7ad1
[Oct 25 18:49:26.919] [ET_UDP 0] DIAG: <QUICPacketHandler_quiche.cc:267 (_recv_packet)> (quic_sec) [541c1f9a-499c1d5f] client initial dcid=0x499c1d5f0e83d0829fc3646d77e87765a56e6773
[Oct 25 18:49:27.120] [ET_UDP 0] DIAG: <QUICPacketHandler_quiche.cc:267 (_recv_packet)> (quic_sec) [67680c4f-da288039] client initial dcid=0xda288039319b757d97cf1a7c5e9664a437440c48
[Oct 25 18:49:27.321] [ET_UDP 0] DIAG: <QUICPacketHandler_quiche.cc:267 (_recv_packet)> (quic_sec) [12d1018c-98c1bef4] client initial dcid=0x98c1bef417ec2b29e7f0b029c0c148293d365f77
[Oct 25 18:49:27.524] [ET_UDP 0] DIAG: <QUICPacketHandler_quiche.cc:267 (_recv_packet)> (quic_sec) [eca97e5c-190370aa] client initial dcid=0x190370aa431db7f9b69cda0a2f2f421e133efd0b

okay @bryancall
this might be due to failure in quiche?

Hi @bryancall
any update on this?

Hi @Karthikdasari0423, Bryan updated the docs so you can build ats+quiche using cmake, please have a  look. More likely you'll need to install few extra packages related to CMake so make sure you install them.
Regards.

Hi @bryancall @brbzull0 i tried and ats is installed sucessfully but i am facing below error
root@ubuntu:~/trafficserver# /opt/bin/curl -k --http3-only -v  https://localhost:4443/cache/1024
* processing: https://localhost:4443/cache/1024
*   Trying [::1]:4443...
* QUIC: connection to ::1 port 4443 refused
* QUIC connect to ::1 port 4443 failed: Couldn't connect to server
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
^C
root@ubuntu:~/trafficserver# /opt/bin/curl -k --http3 -v  https://localhost:4443/cache/1024
* processing: https://localhost:4443/cache/1024
*   Trying [::1]:4443...
* QUIC: connection to ::1 port 4443 refused
* QUIC connect to ::1 port 4443 failed: Couldn't connect to server
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying [::1]:4443...
* connect to ::1 port 4443 failed: Connection refused
*   Trying <IP_ADDRESS>:4443...
* Connected to localhost (<IP_ADDRESS>) port 4443
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to localhost:4443
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
^C
root@ubuntu:~/trafficserver#

am i missing anything here
below is my records.yaml
root@ubuntu:~/trafficserver# cat /opt/ats/etc/trafficserver/records.yaml
ts:
  accept_threads: 1
  cache:
    limits:
      http:
        max_alts: 5
    log:
      alternate:
        eviction: 0
    max_doc_size: 0
    min_average_object_size: 8000
    ram_cache:
      size: -1
    ram_cache_cutoff: 4194304
    threads_per_disk: 8
  diags:
    debug:
      enabled: 0
      tags: http|dns
  dump_mem_info_frequency: 0
  exec_thread:
    affinity: 1
    autoconfig:
      enabled: 1
      scale: 1.0
    limit: 2
  http:
    accept_no_activity_timeout: 120
    cache:
      cache_responses_to_cookies: 1
      cache_urls_that_look_dynamic: 1
      heuristic_lm_factor: 0.1
      heuristic_max_lifetime: 86400
      heuristic_min_lifetime: 3600
      http: 1
      ignore_client_cc_max_age: 1
      required_headers: 2
      when_to_revalidate: 0
    connect_attempts_max_retries: 3
    connect_attempts_max_retries_down_server: 1
    connect_attempts_rr_retries: 3
    connect_attempts_timeout: 30
    down_server:
      cache_time: 60
    forward:
      proxy_auth_to_parent: 0
    insert_client_ip: 1
    insert_request_via_str: 1
    insert_response_via_str: 3
    insert_squid_x_forwarded_for: 1
    keep_alive_no_activity_timeout_in: 120
    keep_alive_no_activity_timeout_out: 120
    negative_caching_enabled: 0
    negative_caching_lifetime: 1800
    normalize_ae: 1
    parent_proxy:
      retry_time: 300
    push_method_enabled: 0
    server_ports: 8080 8080:ipv6
    slow:
      log:
        threshold: 0
    transaction_active_timeout_in: 900
    transaction_active_timeout_out: 0
    transaction_no_activity_timeout_in: 30
    transaction_no_activity_timeout_out: 30
    uncacheable_requests_bypass_parent: 1
  log:
    auto_delete_rolled_files: 1
    logging_enabled: 3
    max_space_mb_for_logs: 25000
    max_space_mb_headroom: 1000
    periodic_tasks_interval: 5
    rolling_enabled: 1
    rolling_interval_sec: 86400
    rolling_size_mb: 10
  net:
    connections_throttle: 30000
    default_inactivity_timeout: 86400
    max_connections_in: 30000
    max_requests_in: 0
  res_track_memory: 0
  reverse_proxy:
    enabled: 1
  ssl:
    client:
      CA:
        cert:
          filename: localhost.crt
          path: /opt/ats/etc/trafficserver/
      verify:
        server:
          policy: PERMISSIVE
          properties: ALL
  task_threads: 2
  url_remap:
    pristine_host_hdr: 0
    remap_required: 1
---
ts:
  http:
    server_ports: 8080 4443:ssl 4443:quic
---
ts:
  udp:
    threads: 1
---
ts:
  diags:
    show_location: 2
---
ts:
  quic:
    initial_max_streams_bidi_in: 100000
# Document modified by traffic_ctl Tue Oct 31 06:18:39 2023
#
---
ts:
  quic:
    initial_max_streams_bidi_out: 100000
---
ts:
  quic:
    server:
      supported_groups: '"P-256:X25519:P-384:P-521"'
---
ts:
  quic:
    client:
      supported_groups: '"P-256:X25519:P-384:P-521"'
---
ts:
  quic:
    disable_http_0_9: 1
root@ubuntu:~/trafficserver#

curl  -V
root@ubuntu:~/trafficserver# /opt/bin/curl -V
curl 8.2.1-DEV (x86_64-pc-linux-gnu) libcurl/8.2.1-DEV OpenSSL/3.1.2 zlib/1.2.11 brotli/1.0.9 nghttp2/1.55.1 ngtcp2/0.17.0 nghttp3/0.13.0
Release-Date: [unreleased]
Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
Features: alt-svc AsynchDNS brotli HSTS HTTP2 HTTP3 HTTPS-proxy IPv6 Largefile libz NTLM NTLM_WB SSL threadsafe TLS-SRP UnixSockets
root@ubuntu:~/trafficserver#

netstat
root@ubuntu:~/trafficserver# netstat -alpn | grep 4443
tcp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*               LISTEN      251519/traffic_serv
udp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*                           251519/traffic_serv
root@ubuntu:~/trafficserver#

remap.conf
#     fields cannot.
#  2) The number of capturing sub-patterns is limited to 9;
#     this means $0 through $9 can be used as substitution place holders ($0
#     will be the entire input string)
#  3) The number of substitutions in the expansion string is limited to 10.
#
map / http://<IP_ADDRESS>/ @plugin=generator.so
root@ubuntu:~/trafficserver#

ssl_multicert.conf
# Examples:
#   ssl_cert_name=foo.pem
#   dest_ip=*   ssl_cert_name=bar.pem ssl_key_name=barKey.pem
#   dest_ip=<IP_ADDRESS>       ssl_cert_name=server.pem ssl_key_name=serverKey.pem
#   dest_ip=<IP_ADDRESS>:99 ssl_cert_name=port99.pem
#   ssl_cert_name=foo.pem ssl_key_dialog="exec:/usr/bin/mypass foo 'ba r'"
#   ssl_cert_name=foo.pem action=tunnel
#   ssl_cert_name=wildcardcert.pem ssl_key_name=privkey.pem
dest_ip=* ssl_cert_name=/opt/ats/etc/trafficserver/localhost.crt ssl_key_name=/opt/ats/etc/trafficserver/localhost.key
root@ubuntu:~/trafficserver#

am i missing anything here? @bryancall  @brbzull0
i believe above conf is correct

Hi @Karthikdasari0423 , sorry for the delay.
It seems curl is trying to use ipv6:
*   Trying [::1]:4443...

And based on your config,  the port isn't enable for ipv6,
I would add :ipv6  as a descriptor so you bind it to ipv6 too.
Hope it helps.
Thanks

@bryancall i dont think that is the issue
i added ipv6 to /opt/ats/etc/trafficserver/records.yaml

---
ts:
  http:
    server_ports: 8080 8080:ipv6 4443:ssl 4443:quic 4443:ipv6
---

and restarted the ats but still it is not getting opened on tcp6 and udp6
root@ubuntu:~# /opt/ats/bin/trafficserver ?
Usage: /etc/init.d/trafficserver {start|stop|status|restart}
root@ubuntu:~# /opt/ats/bin/trafficserver restart
 * Restarting Apache Traffic Server trafficserver                                                                               [ OK ]
root@ubuntu:~# /opt/ats/bin/trafficserver status
 * traffic_server is running
root@ubuntu:~#

root@ubuntu:~#
root@ubuntu:~# netstat -alpn | grep traffic
tcp        0      0 <IP_ADDRESS>:8080            <IP_ADDRESS>:*               LISTEN      255623/traffic_serv
tcp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*               LISTEN      255623/traffic_serv
udp        0      0 <IP_ADDRESS>:59163         <IP_ADDRESS>:53           ESTABLISHED 255623/traffic_serv
udp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*                           255623/traffic_serv
unix  2      [ ACC ]     STREAM     LISTENING     2514844  255623/traffic_serv  /opt/ats/var/trafficserver/jsonrpc20.sock
unix  2      [ ]         DGRAM      CONNECTED     2514837  255623/traffic_serv
unix  3      [ ]         STREAM     CONNECTED     2514839  255625/traffic_cras
unix  3      [ ]         STREAM     CONNECTED     2514838  255623/traffic_serv
root@ubuntu:~#
root@ubuntu:~#

any idea what am i missing here @bryancall

Please add:

---
ts:
  http:
    server_ports: 8080 8080:ipv6 4443:ssl 4443:quic:ipv6
---

note the 4443:quic:ipv6

Thank you @bryancall
i have added same to conf file

---
ts:
  http:
    server_ports: 8080 8080:ipv6 4443:ssl 4443:quic:ipv6
---

and restarted apache
root@ubuntu:/tmp# /opt/ats/bin/trafficserver restart
 * Restarting Apache Traffic Server trafficserver                                                                               [ OK ]
root@ubuntu:/tmp# /opt/ats/bin/trafficserver status
 * traffic_server is running
root@ubuntu:/tmp#

but still netstat is not showing port is open ipv6 port's and curl is giving same error
root@ubuntu:/tmp# netstat -alpn | grep traffic
tcp        0      0 <IP_ADDRESS>:8080            <IP_ADDRESS>:*               LISTEN      255623/traffic_serv
tcp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*               LISTEN      255623/traffic_serv
udp        0      0 <IP_ADDRESS>:59163         <IP_ADDRESS>:53           ESTABLISHED 255623/traffic_serv
udp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*                           255623/traffic_serv
unix  2      [ ACC ]     STREAM     LISTENING     2514844  255623/traffic_serv  /opt/ats/var/trafficserver/jsonrpc20.sock
unix  2      [ ]         DGRAM      CONNECTED     2514837  255623/traffic_serv
unix  3      [ ]         STREAM     CONNECTED     2514839  255625/traffic_cras
unix  3      [ ]         STREAM     CONNECTED     2514838  255623/traffic_serv
root@ubuntu:/tmp#

root@ubuntu:/tmp# /opt/bin/curl -k -v --http3 https://<IP_ADDRESS>:4443/cache/1024
* processing: https://<IP_ADDRESS>:4443/cache/1024
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 4443
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to <IP_ADDRESS>:4443
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
^C
root@ubuntu:/tmp#

am i still missing anything here @bryancall

is this the command correct to restart  @bryancall
/opt/ats/bin/trafficserver restart

Do you have acess to the ATS slack channel? it would be easy to talk over there.
in any case, this is what I have on my config:
 server_ports: 8080 8080:ipv6 4443:ssl 4443:quic 4443:quic:ipv6

ipv4/6 works.

/opt/ats/bin/trafficserver restart

I would make sure the pid changes when stop/restart if not, kill it manually and start it over again

is this the command correct to restart @bryancall
/opt/ats/bin/trafficserver restart

make sure you tag me @brbzull0 and not bryancall so he does not get flooded with messages.

sorry,my bad
sure @brbzull0

Do you have acess to the ATS slack channel? it would be easy to talk over there.
in any case, this is what I have on my config:
 server_ports: 8080 8080:ipv6 4443:ssl 4443:quic 4443:quic:ipv6

ipv4/6 works.

/opt/ats/bin/trafficserver restart

I would make sure the pid changes when stop/restart if not, kill it manually and start it over again

no, i don t have access to slack channel @brbzull0
Could you please share details
i killed the process and started again, now ports are opened on ipv6 as well but curl is still showing same
root@ubuntu:/tmp# netstat -alpn | grep traffic
tcp        0      0 <IP_ADDRESS>:8080            <IP_ADDRESS>:*               LISTEN      256970/traffic_serv
tcp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*               LISTEN      256970/traffic_serv
tcp6       0      0 :::8080                 :::*                    LISTEN      256970/traffic_serv
udp        0      0 <IP_ADDRESS>:19637         <IP_ADDRESS>:53           ESTABLISHED 256970/traffic_serv
udp        0      0 <IP_ADDRESS>:4443            <IP_ADDRESS>:*                           256970/traffic_serv
udp6       0      0 :::4443                 :::*                                256970/traffic_serv
unix  2      [ ACC ]     STREAM     LISTENING     2986304  256970/traffic_serv  /opt/ats/var/trafficserver/jsonrpc20.sock
unix  2      [ ]         DGRAM      CONNECTED     2986297  256970/traffic_serv
unix  3      [ ]         STREAM     CONNECTED     2986299  256972/traffic_cras
unix  3      [ ]         STREAM     CONNECTED     2986298  256970/traffic_serv
root@ubuntu:/tmp#

root@ubuntu:/tmp# /opt/bin/curl -k -v --http3 https://<IP_ADDRESS>:4443/cache/1024
* processing: https://<IP_ADDRESS>:4443/cache/1024
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 4443
* ALPN: offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to <IP_ADDRESS>:4443
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
*   Trying <IP_ADDRESS>:4443...
^C
root@ubuntu:/tmp#

share your email, I'll invite you.

here is my mail id
<EMAIL_ADDRESS>

you should  have been invited already.
slack me:  Damian Meden

sure @brbzull0
@bryancall added me ,Thanks @bryancall @brbzull0

As per our slack chat, ats+quic is working for @Karthikdasari0423 .
closing this now.

Thank you @brbzull0 for helping out.


Monaco editor disappears after clicking "Dynamic Content" sub-tab

Describe the Bug with repro steps

In any editor, open expression editor
Click "Dynamic Content" tab

Expected: Should be able to see expression editor still, and click tokens to add them.
Actual: Expression editor vanishes; clicking tokens does nothing and there is no way back without closing token picker entirely.
What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos

Browser
Chrome 127.0.6533.89 (Official Build) (64-bit)
Additional context
Appears to have been caused by #5107; specifically, this line:

cc @maturpi


Limit D3D9 staging memory

Games like Witcher 2 and modded Mass Effect 2 peak at 190MB and 170MB of memory used for staging buffers during loading screens. In the case of UE3 games, that happens at the same time as a very high peak for mapped resource memory, so this could be potentially problematic. Those games don't crash for me but I'd still prefer to get this under control.
The idea of this PR is to add a limit to how much staging memory an application is allowed to use and stall once we've exceeded that. I've settled on 16MB which was never an issue during gameplay in my testing.
Ideally we'd just unmap the memory and just not care but that doesn't work on Nvidia.
To track how much memory we're using for staging buffers, I add a new blank class that inherits from DxvkResource.
That allows us to check whether it's still in use (ie the command list has not been reset by the fence thread).
It's preferable to keep those objects around compared to keeping references to the actual staging buffers and checking those.
A prettier version of this would somehow inform DxvkCsThread of the last sequence number completed by the GPU. That's tricky to implement however, especially with DeferredContexts.

I don't think we need a custom staging buffer implementation for this. The DxvkMarker thing is kind of clever though.
I'll try something, will submit PR if it ends up working.

Superseded by #2808


[DNM] Prepare for deploying riff with istio enabled

add opt-out annotations to kafka and zk

Holding off on merging this


Problem with calling ASP WebMethod to fill bootgrid

I wrote StackOverflow post here describing my problem:
http://stackoverflow.com/questions/42853108/uncaught-syntaxerror-unexpected-token-in-json-with-asp-net-webmethod
Any ideas on how to sort it out?

I ended up using a Generic Handler in order to make my JSON data available instead of using a WebMethod


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3145

Questions ?
Please refer to the Backport tool documentation


Integration tests for ttrpc

For the commit of https://github.com/confidential-containers/attestation-agent/commit/283db89fe96de708f2e676f9c6f1e1996b066874 the decryption image layer tests will fail. Let's make some new test images to be decrypted. Until that, please do not merge this PR.
Close https://github.com/confidential-containers/image-rs/issues/115

Hi @jiangliu @arronwy @jialez0  This is a integration test for ttrpc stack covering AA, image-rs and ocicrypt-rs. Please take a look


"X" (close) button visible to the left of ESC

Describe the bug
I'm used to the location of ESC button on the very left, it should stay in the same place. Now I see [X] (close) button first, and ESC comes second.
To Reproduce
Steps to reproduce the behavior:
I think I haven't had that at the beginning, now I see this permanently - even just after I quit & restart Pock
Expected behavior
ESC should be the first icon on the very left.
Screenshots

Desktop (please complete the following information):

OS: OS X 10.14.05

This condition is perfectly normal if you have Hide Control Strip option disabled. That's because, with that option disabled, Pock is showed inside system Touch Bar and is not replacing it, and since Pock is showed inside the system Touch Bar, the user should have the ability to close it to switch to current frontmost app's Touch Bar.

Got it, after changing that it works as expected. Thanks! Maybe this would be a good section for some  HOWTO or FAQ, I think it's not obvious for "regular" users like me :)

FAQ section is coming 🏄🏻
https://twitter.com/pigigaldi/status/1142862572733063168?s=21


[release-1.17] Fix pilot using wrong readinessprobe check, should check if /validate and /inject endpoints are ready.

Please provide a description of this PR:
Manual cherry-pick 44526
Fix https://github.com/istio/istio/issues/44630

/retest


Inconsistent job labels between prometheus-operator discovery service and kube-prometheus

What did you do?
Deployed prometheus-operator with kubernetes-mixin for alerting.
What did you expect to see?
Matching job labels between prometheus-operator and kubernetes-mixin.
What did you see instead? Under which circumstances?
The job labels provisioned by [contrib/kube-prometheus/jsonnet/kube-prometheus/kube-prometheus-bootkube.libsonnet] do not match the upstream job selectors, which causes alerts (like CoreDNSDown and KubeVersionMismatch) that depend on these selectors to misfire.
Looking at the other configuration it looks like these are the only discovery services that append -prometheus-discovery and so I think the name change should happen in this repo.
Environment

Prometheus Operator version:

Current master (f8343b294f49c9009478138bd5572573f28811ec)

Kubernetes version information:

Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.3", GitCommit:"a4529464e4629c21224b3d52edfe0ea91b072862", GitTreeState:"clean", BuildDate:"2018-09-09T17:53:03Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}```

* Kubernetes cluster kind:

kops 1.10

* Manifests:
N/A

* Prometheus Operator Logs:
N/A

I commented in #2181, could you elaborate regarding my comment either here or in #2181?

Apologies, our service discovery was missing the k8s-app label and causing the metrics job label to default to the full suffixed name.

Closed PR as it was misconfiguration on our side for the service discovery label as per my comment in the PR. Thanks for the quick response @brancz!


Build: Remove dist on commit, add dist on release

Only lint staged files (like adslot ui)
Only run dist on release
On release, pre-dist, make sure all node modules are installed.
Add check that you're on master for release
Automatically pull pre-release

I wonder if we should do the non minified one still on commit?

@vinteo that's only in adslot-ui

Current coverage is 100% (diff: 100%)

Merging #336 into master will not change coverage

@@           master   #336   diff @@
====================================
  Files          26     26
  Lines         304    304
  Methods        48     48
  Messages        0      0
  Branches       43     43
====================================
  Hits          304    304
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last update 71921f4...7c4e1a0

Merging...