navigate to create workspace/workspaces list page without refreshing

Description
currently, navigate to "Create workspace" page and "All workspace" list page from workspace context menu triggers a full page reload which is unnecessary.
Issues Resolved

Screenshot

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report

Merging #220 (94c3f94) into workspace (2771ff9) will decrease coverage by 5.86%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #220      +/-   ##
=============================================
- Coverage      66.20%   60.35%   -5.86%
=============================================
  Files           3419     2159    -1260
  Lines          65753    42114   -23639
  Branches       10590     7730    -2860
=============================================
- Hits           43535    25418   -18117
+ Misses         19574    15002    -4572
+ Partials        2644     1694     -950

Flag
Coverage Δ

Linux_1
?

Linux_2
55.36% <ø> (ø)

Linux_3
42.77% <ø> (+<0.01%)
:arrow_up:

Linux_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

src/core/public/chrome/chrome_service.tsx
86.66% <ø> (ø)

... and 1561 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add WorldCereal input extractions worfklow

Just some minor remarks. We could setup mypy in our linting actions which makes static checks on the type hints, but it will require some refactoring to make it compliant and I'm not sure it's really a huge issue for now

shouldn't be hard to setup (can copy from presto, where we do it already), but as you say, it's gonna raise some issue the first time ;-) Maybe I can setup a branch for this specifically. It's gonna be worth it at some point.


Fix AZP builds when building a Pull Request build

When building a PR the BUILD_SOURCEBRANCH is like 'ref/pull/1/merge',
which breaks the build by "too many values to unpack (expected 2)"
See https://dev.azure.com/bincrafters/packages/_build/results?buildId=567

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   98.45%   98.45%
=======================================
  Files           8        8
  Lines         194      194
=======================================
  Hits          191      191
  Misses          3        3

Impacted Files
Coverage Δ

bincrafters/build_shared.py
98.03% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a360938...baa8c00. Read the comment docs.

Could you please point me to such a pull request where you noticed that?

Already mentioned in the PR description.
https://github.com/bincrafters/conan-wxwidgets/pull/16

Sorry, I was mobile earlier
I will review soon. Thanks for contributing 😄

Fixed via https://github.com/bincrafters/bincrafters-package-tools/commit/57f953487b0e26580e7ad3cc25e339134a3a7fe2
Result: https://dev.azure.com/bincrafters/packages/_build/results?buildId=574&view=results


ABOUT ME

:warning: This is a Pull Request Template :warning:

Checkout all the things you've done by placing an *x*\ within the square braces.

Proposed Changes

[ ] I've forked the repository.
[ ] I've created a branch and made my changes in it.
[ ] I've read the CODE OF CONDUCT and abide to it.
[ ] I've read the CONTRIBUTING.md
[ ] I understand opening a PULL REQUEST doesn't mean it will be merged for sure.

THANK YOU for suggesting .I had push my own code and I thought it is comfortable.

On 11-Oct-2018, at 10:31 PM, Josh Cunningham<EMAIL_ADDRESS>wrote:
@joshcanhelp requested changes on this pull request.
Please submit your own code sample instead of editing someone else's 🙌
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/my-first-pr/hacktoberfest-2018/pull/444#pullrequestreview-163918198, or mute the thread https://github.com/notifications/unsubscribe-auth/An9TxA2vdWvjrzcuRGQ9XkwblHrLtpzTks5uj3logaJpZM4XWNsf.

DID THE REQUIRED CHANGES

THANK YOU for suggesting the changes ,did all the necessary changes

On 13-Oct-2018, at 1:00 AM, Josh Cunningham<EMAIL_ADDRESS>wrote:
@joshcanhelp requested changes on this pull request.
@AMANSINGH1998 https://github.com/AMANSINGH1998 - Please remove .DS_Store and revert the changes to code/aboutMe.html
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/my-first-pr/hacktoberfest-2018/pull/444#pullrequestreview-164380068, or mute the thread https://github.com/notifications/unsubscribe-auth/An9TxHD1H-uM75O1qHLdRVu9GDFfvwZ5ks5ukO3ZgaJpZM4XWNsf.

Please re-submit when you're ready 👍


Q: Are feature engineering tools mixed in for BT, RF, and GB?

From This Scikit Learn tutorial it is easy to see that for data that is not orthogonal to one another, often times produce subpar results.
There has been tools that help with this through mixing different columns in the dataset through "feature engineering".
Some notable ones include the following libraries:

https://github.com/alteryx/featuretools
https://github.com/cod3licious/autofeat
https://github.com/feature-engine/feature_engine
https://github.com/mljar/mljar-supervised

Q: can this feature builder be used to create classifiers in tests/outputs/rules with engineered features?

For clarification, those libraries only create new columns for data, but ChefBoost can creative native Python code to run on columnar data, thus would it be possible to integrate mappers where variable xy would be converted to something like x * y or x + y?


[BugFix] Fix nullable column update rows not set _has_null and Fix be crash when flush mem table is null

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

starrocks_be_unittest succeeded.


Update the broken notebook links in Quick-Start.md

Quickstart had couple broken links, just updated them.
Description

How Has This Been Tested?

No need for tests as this is related to .md file
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

Can you bring this branch up to date with main?

Hey Selbi, thanks for the fix. @jbusche had the same change included in his quickstart update that was just merged so I am going to close this.


Link at the end of a sentence adds an extra space before full stop

I've really enjoyed using the different components here. Thanks @JulianCataldo for sharing them!
Issue
I'm having an issue with the <Link> component. When I use it at the end of a sentence, it adds a space between the link and the full stop. E.g. "This is the link ."
Example
(I can make a full MRE if it's helpful.)
Code

  This is fine when the <Link href="/somewhere">link</Link> is not at the end of the sentence.

  But there is an issue when the sentence finishes with a <Link href="/somewhere">link</Link>.

  Everything is fine when I have a normal link.

Result

Question

Is this behaviour expected? I'm aware that Astro behaves a little differently with spaces than what I expect from files like JSX. I'm wondering if this is somehow the default behaviour of <slot />.

Is there a simple way around it?

Hello :)
I recall that Astro is aligned with HTML regarding spaces, not JSX. Not 100% sure though.
It's tricky: https://developer.mozilla.org/en-US/docs/Web/API/Document_Object_Model/Whitespace.
That's probably why JSX strips phantom spaces for convenience, with a trade-off: {' '} has to be used when we want to add one explicitly, so the parser is kept away from stripping them.
A possible fix could be:
<slot />{/* */}

instead of:

  <slot />

{/* */} is a "glue", used to trick Astro's Prettier, so it doesn't force us an additional space.
Thanks for catching this! Will try this fix ASAP.


Any XML file that contains methods defined internally by rakudo will cause an exception.

Take the following excerpt for an example:
  <complexType name="ShipsFromType">
    <all>
      <element name="State" type="string" minOccurs="0"/>
      <element name="Country" type="string" minOccurs="0"/>
    </all>
  </complexType>

This will trip up XML::Actions with the following error, because method all() is provided by Any:
Too many positionals passed; expected 1 argument but got 2
  in method check-action at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 124
  in block  at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 79
  in method process-node at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 76
  in block  at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 79
  in method process-node at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 76
  in block  at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 79
  in method process-node at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 78
  in method process-document at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 72
  in method process at /home/cbwood/Other Projects/XmlActions/lib/XML/Actions.pm6 (XML::Actions) line 58
  in sub MAIN at project-tools/test-parse-1.pl6 line 132
  in block <unit> at project-tools/test-parse-1.pl6 line 9

This will find this method, which does not have the required number of parameters.
In such a situation, I'm not sure of the best way to fix it. For now however, I would suggest an error message that details the issue.
Method {$a} has triggered an error. If this method is not in your XML::Actions class, then you should consider overwriting it with the proper signature.

See this discussion for details.

Ik can reproduce the problem. I think that the solution will not be easy...

A shortcut solution is to provide a method all ( Array $parent-path, :$id ) { } in the class given to XML::Actions.process() to prevent the crash.
I can add an extra test for the method name extended with '-START' like I've done with testing for the end tag '-END'. Then add a deprecation message to the previous one. This will not break backwards compatibility but provides a way to change things. In this deprecation phase you still need to add a method 'all()' untill this way of calling is removed.

Sounds like a good compromise for the situation. I will add an override for all.
Thanks!

After studying extended identifiers I come up with the names element:start() and element:end(). This looks much nicer and XML namespace names do not interfere.
I also change the names for processing PI, CDATA, TEXT and COMMENT. See README in next version.


path is not absolute in OAuth Redirects

Using disableRedirectInitializer mode I try to get code for further authentication  in backend.
If for example I try auth on  domain.com/some/route   I get white screen popup with URL like like domain.com/some/route/torii/redirect.html?code=
It's works fine only in route domain.com/
 auth(provider) {
      this.get('torii').open(provider).then((authorization) => {
        ...some ajax.request to server with authorization credentials
      })
    }

torii: {
      disableRedirectInitializer: true,
      sessionServiceName: 'session-torii',
      providers: {
        'facebook-oauth2': {
          apiKey: process.env.OAUTH_FACEBOOK_ID,
          scope: 'email'
        }
      }
    },

To solve this problem each provider must contain redirectUri: 'http://domain.com/torii/redirect.html', and it's don't look as a good solution

I have the same issue and I'm forced to provide an explicit redirectUri coming from an environment variable in order to work across dev/staging/prod environments.
I would expect the default behavior to point to {domain}/torii/redirect.html.
Thanks ❤

@simonc are you handling the env variable with dev/staging/prod environments?
I need to do something similar, and for now, I have a bash startup script for my Docker container which reads env vars, and then runs sed on the Ember code.....which is really ugly, but I don't know how else to keep the same container and reuse it in different environments.

@k3n I used environment variables directly with ember-cli-dotenv so my environment.js file contains this:
torii: {
  sessionServiceName: 'session',
  providers: {
    'github-oauth2': {
      apiKey: process.env.OAUTH_GITHUB_CLIENT_ID,
      redirectUri: process.env.OAUTH_REDIRECT_URI,
      scope: 'read:user user:email'
    },

    'google-oauth2': {
      apiKey: process.env.OAUTH_GOOGLE_CLIENT_ID,
      redirectUri: process.env.OAUTH_REDIRECT_URI,
      scope: 'email profile'
    }
  }
}

and my .env files contain are set like this
# .env
OAUTH_REDIRECT_URI=http://localhost:4200/torii/redirect.html

# .env.production
OAUTH_REDIRECT_URI=https://dashboard.pdfmonkey.io/torii/redirect.html

That's not an ideal situation but at least it works 🙂


Improve getdistributionGraphDatas computing

For big files example R05 on dataialert file
getdistributionGraphDatas is very long and freeze ui
todo:
maybe it's possible to remove data vis limit with pagination:

provide loading as for numerical variables


Please use different colors to mark function parameters and function annotations so that I can quickly browse function signatures

Function parameters and function annotations are marked in the same color, so I can't quickly distinguish between default parameters and function annotations

Thank you for the suggestion.
This is a case where the textmate grammar is getting confused because we send Python markdown code section but it's not really valid Python.

If we change the (class) with def it becomes more valid and we can see the parameters get colorized correctly:

Any plan to improve this issue?😁

We are working on the tooltips, yes.
VS Code provides no mechanism to customize the colors of these tooltips. They are markdown that have no access to semantic tokens, just the TextMate profile.
I've tried changing our tooltips to a custom grammar that can handle the (function) or (class) etc at the beginning, but VS Code hardcodes the list of valid languages in tooltips, making it impossible.
This may be better if we drop (class) or something, as noted above.

Moving this issue to discussion as an enhancement request for comments and upvotes.


COI - explore multiple file attachments for LDB

In the new ldb branch of the workflow. The business would like to send all uploaded file attachments to an ldb mailbox.
from bhumin:
public ByteArrayDataSource generatePdf(String formId, String submissionId) throws IOException {
String url = String.format("%s/form/%s/submission/%s/export/pdf", documentApiUrl, formId, submissionId);
Mono<byte[]> pdfFile = httpServiceInvoker.exchangeForFile(url, HttpMethod.POST, null);
return new ByteArrayDataSource(pdfFile.block(), "application/pdf");
}
I did check where it pulls data and converts to byte[] to attach as file in Email. It does support only one file per name. And we have multiple file attachment for each field. Requires to convert this function to support multiple file in both format, uploaded file and base64 file.
We have base64 string, we can decode and convert that to byte[]....

Bhumin tested this - moving to PO!

For testing:
LDB is required for testing and DJ inbox receives all communications for testing purposes.

Waiting for resolution of #1855 to PO test this ticket

Best approach is to test with LDB folks directly. We will close this ticket after we do that.

Waiting to TEST


Java  : Add comment in the beginning

xml to java tool missing example how to deserialize in a comment in the begining


Can't change scrolling speed (lines skipped) in SQL editor

Problem
Dear contributors,
I just started to use dbeaver and while most of the things are nice, I find that the scrolling part is a bit awkward. I noticed that while in dbeaver, every single scroll of my Logitech wireless mouse would skip 9 lines in SQL editor, while other applications (such as pgadmin and Pycharm) only skip 3-5 lines, which is much more intuitive and accurate during work.
p.s. Skipping 9 lines is not ideal when you try to review SQL scripts. I have to keep using arrow keys to make sure I don't skip too many parts. This is something I
Request
I like to have an option to change the scrolling speed or the line that every single scroll could skip. Currently, I can't find the option, and changing scrolling speed in Mac system preference doesn't work. Please let me know if there is another way that I can do it. Thanks!
General information
Version: 21.1.0
OS: Mac OS 11.2.3
Tested with postgreSQL

Unfortunately I cannot reproduce it on Mac with Logitech mouse. Thank you for your suggestion. I will reply later, whether anything can be done on our side.

Hi,
Thanks for the reply. I found the situation is a bit more complicated, but I have some clue now. When I opened DBeaver, let my mac slept and then wake it up, my exiting scripts would have this problem (each scroll skipped 9 lines). However, if I closed one specific script and opened it again, the scroll function became normal (only past 4-5 lines; Other scripts still had the weird scroll problem).

Hi,
I think I found the cause. If I accidentally change the keyboard language input to "Zhuyin - Traditional" and type some characters, the space between lines would change and the problem would happen (every scroll would skip many rows; even I remove the mistyped characters). Right now, I can fix this by closing the script and open it again. Hope this give you more clues to fix it.
Thanks!


Improper query built for update of range columns by MySQL provider

The update query built by the MySQL provider does not use the underlying upper-lower range bound columns of a range input. It tries to update it like a single column. Hence the update API is broken for any rule system containing range inputs.

Resolved


email addresses with '.' generate invalid usernames

If I register an account with a dot in the name part of the email address, e.g<EMAIL_ADDRESS>then attempt join a channel you get an invalid username error from the server.
The server is ngircd. I coudn't find anything about the username format in the RFC but from the looks of the ngircd commit other servers may behave similarly.
I'm not sure of the implications, but perhaps just strip non-alpha chars when generating the username?
[Edit: fixed the commit link]

Sounds good to me! I didn't know this was an issue, but I don't see any harm on removing "." as well. Do you think removing it, or replacing it with "_" is the best choice?

I think remove, ngircd only allows alphanumeric (see commit - sorry fixed the link!) It's not really a UI thing, it appears in the output of /userhost and friends but I don't think the format would matter to anything trying to use it programatically like bots.

This fix will be part of the next release of Convos, 0.99_18. Hope to make a release later or early next week.

I do think it's weird that the server don't allow "" in the nick though... What should the logic for duplicate nicks be like then? Right now, if "yournick" is taken, then Convos will automatically try to add "" at the end, so the nick will become "yournick_".

Ah it's the username when initiating the connection that has the issue - not the nick. It looks like it is generated in Convos::Core::Connection line 90. Apologies for confusion.

p.s. I've introduced Convos to our mainly Perl dev team where it has been warmly received, we'll almost certainly be setting up a Convos dev environment and hopefully contributing!

Ah! That makes perfect sense 😄
I should've read the bug report more closely.

Hope I fixed the correct thing this time! 😃


Adding a video Source in the simulation environment

Hi, I am new to this.
How can I use a video to feed into the Nao's Camera and its music in the microphone sensor?
This might be a basic question. Sorry for that.
Thanks,
Suti

Hi Suti, I'm not so sure that I understand your question:

How can I use a video to feed into the Nao's Camera

By default, the camera of the virtual NAO is a simulated one, and will return images captured in the simulation (see here for more information). From what I understand you want to stream your own video data in the simulation ?

and its music in the microphone sensor?

The answer to this one is easier :smile: The simulated robot doesn't have microphones or speakers, so that's not possible at the moment

Yes, I want to stream my video data. How to create the environment for that?
Will there be any sooner release with audio data as well? Or any other alternative to achieve that?

I don't think that there is a nice and easy way to do that, you could always try to create a wall (that would act as a screen), segment your video into successive images and change the texture of the wall to match each image, one after the other. (that's quite dirty though)
Regarding the audio, we probably won't add that to the simulator, at least not soon, since the audio is not handled by the pybullet APIs.
What are you actually trying to achieve by streaming that into the simulation? Depending on your goal, using another simulator (such as morse or webots) might be more relevant

Thank you for your response. I am trying to simulate an orchestra environment Video Link. I want the humanoid bot to react with this.

Ok, and I guess that you want the robot to capture that to take into account the specificities of its sensors (eg camera fov, resolution, mic sensitivity etc) before processing the video and the audio?

Yes

Alright, I see! The camera of the robot will have a correct fov, resolution and intrinsic parameters, but there will still be a reality gap between the simulated camera and the real one (the real camera will render noisier images).
My guess is that if you really want to take into account the model of the sensors, you should maybe use a different simulator, that handles that kind of stuff more accurately (you can take a look at ignition, or webots). I think that there is already a NAO robot model available in webots

Okay, Thank you so much for all your suggestions. I will have a look at them.


(embassy-rp): Implementation of generic flash mutation access

I have attempted to utilize the work done in rp2040-flash by implementing embedded-storage traits on top, for RP2040.
Concerns:

Should the DMA be paused where I have put a FIXME note? DMA_CHx.ctrl_trig().write(|w| { w.set_en(false) })? If so, how to properly do that without have control over the peripheral for the DMA channels? And if so, I assume we should only re-enable/unpause the ones that were enabled before?
Should I make sure core2 is halted as part of this code? I am not sure if https://github.com/jannic/rp2040-flash/blob/ea8ab1ac807a7ab2b28a18bb5ca2e42495bb744d/examples/flash_example.rs#L103-L109 is heavy/slow code to run?
Any good way of making this configurable over FLASH_SIZE, WRITE_SIZE and ERASE_SIZE without doing it as generics or parameters, as those make it possible to do differing configs throughout the same program, which feels wrong? Preferably, a compile-time option?

EDIT:
I have implemented the flash API here under the assumption that all external QSPI nor flashes are infact Multiwrite capable, as this makes it possible to use the ROM function for writes of 1 bytes at a time.
I have also added a HIL test for this, but because HIL tests are running 100% from RAM and I wanted to make sure it still works when running from flash, I have also added an example testing erase/write cycles of entire sectors, as well as single bytes in multi-write style.
Ping @Dirbaio

Should the DMA be paused

Oof this is cursed. I guess yes, or this will be a problem when DMAing from flash.

If so, how to properly do that without have control over the peripheral for the DMA channels?

If the flash code globally disables irqs and stops the other core you have the guarantee that no other code will race you, so you can go ahead and do it unsafely I guess...

And if so, I assume we should only re-enable/unpause the ones that were enabled before?

Yes...
Also, are we sure EN=0/EN=1 pauses/resumes the channel fully seamlessly?
Alternatively we can disallow DMAing from flash... nRF has this limitation in hardware and it's not that bad, it means you have to copy through a RAM buffer though. Perhaps it could be feature-gated, so you can either "DMA from flash" OR "write to flash", but not both in the same binary...

Should I make sure core2 is halted as part of this code? I

In the final version yes, but I'd say it's OK to not do it for now since we don't support muticore yet.
Note that code resets core2, we want to pause it instead. It'd have to send an irq to the other core (using the FIFO maybe) so that the other core "parks" itself in a RAM irq handler. Also note it's possible to do flash ops from core2, in this case it should park core1 :sweat: .

Any good way of making this configurable over FLASH_SIZE, WRITE_SIZE and ERASE_SIZE without doing it as generics or parameters

Cargo features with a range of possible options? :P They're always powers of 2 so there shouldn't be too many "reasonable" options...?

Also, are we sure EN=0/EN=1 pauses/resumes the channel fully seamlessly?

From the RP2040 datasheet:

DMA Channel Enable.
When 1, the channel will respond to triggering events,
which will cause it to become BUSY and start transferring
data. When 0, the channel will ignore triggers, stop issuing
transfers, and pause the current transfer sequence (i.e.
BUSY will remain high if already high)

As I read that, it actually fully pauses any ongoing transfer, so I don't think this is too bad.

In the final version yes, but I'd say it's OK to not do it for now since we don't support muticore yet.
Note that code resets core2, we want to pause it instead. It'd have to send an irq to the other core (using the FIFO maybe) so that the other core "parks" itself in a RAM irq handler. Also note it's possible to do flash ops from core2, in this case it should park core1.

Noted.

Cargo features with a range of possible options? :P They're always powers of 2 so there shouldn't be too many "reasonable" options...?

Hmm, yeah. I'm not super fond of that way of doing it. It just doesn't seem to scale very well :(

I have attempted to utilize the work done in rp2040-flash by implementing embedded-storage traits on top, for RP2040.
Concerns:
1. Should the DMA be paused where I have put a FIXME note? `DMA_CHx.ctrl_trig().write(|w| { w.set_en(false) })`? If so, how to properly do that without have control over the peripheral for the DMA channels? And if so, I assume we should only re-enable/unpause the ones that were enabled before?

2. Should I make sure core2 is halted as part of this code? I am not sure if https://github.com/jannic/rp2040-flash/blob/ea8ab1ac807a7ab2b28a18bb5ca2e42495bb744d/examples/flash_example.rs#L103-L109 is heavy/slow code to run?

3. Any good way of making this configurable over `FLASH_SIZE`, `WRITE_SIZE` and `ERASE_SIZE` without doing it as generics or parameters, as those make it possible to do differing configs throughout the same program, which feels wrong? Preferably, a compile-time option?

Although a slightly different situation, I've had a similar dilemma in embassy-boot generalizing these, and ended up using const generics for them. What about a combination that allows both uses: a GenericFlash using const generics, and a type alias Flash based on cargo features? Or would that be too confusing?

I have attempted to utilize the work done in rp2040-flash by implementing embedded-storage traits on top, for RP2040.
Concerns:
1. Should the DMA be paused where I have put a FIXME note? `DMA_CHx.ctrl_trig().write(|w| { w.set_en(false) })`? If so, how to properly do that without have control over the peripheral for the DMA channels? And if so, I assume we should only re-enable/unpause the ones that were enabled before?

2. Should I make sure core2 is halted as part of this code? I am not sure if https://github.com/jannic/rp2040-flash/blob/ea8ab1ac807a7ab2b28a18bb5ca2e42495bb744d/examples/flash_example.rs#L103-L109 is heavy/slow code to run?

3. Any good way of making this configurable over `FLASH_SIZE`, `WRITE_SIZE` and `ERASE_SIZE` without doing it as generics or parameters, as those make it possible to do differing configs throughout the same program, which feels wrong? Preferably, a compile-time option?

Although a slightly different situation, I've had a similar dilemma in embassy-boot generalizing these, and ended up using const generics for them. What about a combination that allows both uses: a GenericFlash using const generics, and a type alias Flash based on cargo features? Or would that be too confusing?

That was actually exactly what I was thinking about.
Either chip specific exports like boot2 does for their bootloaders, or '1M_4_1' kind of definitions, where 'FLASH-SIZE_ERASE-SIZE_READ-SIZE'

What about a combination that allows both uses: a GenericFlash using const generics, and a type alias Flash based on cargo features? Or would that be too confusing?

It should be one or the other. Having 2 ways of doing the same thing is very confusing.

Given the kind of extreme limitations of the rom-data flash API, that aims at wide flash support, my suggestion would be to make a repo similar to https://github.com/rp-rs/flash-algo where we can implement a few different implementations (QSPI, Dual-SPI, SPI) in various configurations, compile and link them fully for RAM, and then include_bytes() one of them similarly to https://github.com/rp-rs/rp2040-boot2.
Then we can do fallback to the flash API in rom-data, if users do not wish the added flash size of an optimized flash API.
W.R.T flash configurations & cargo features vs const generics, how about adding a "custom" peripheral for flash, such that you can only instantiate it once (panic on re-entrance), where you can pass flash-size, erase-size etc., and then you would have to pass around the flash struct like all other microcontrollers?
Thoughts @Dirbaio @lulf ?

Sounds good to me! :+1:  I think having to write RAM-linked "flash driver" blobs is inevitable given the ROM limitations...

adding a "custom" peripheral for flash, such that you can only instantiate it once (panic on re-entrance), where you can pass flash-size, erase-size etc., and then you would have to pass around the flash struct like all other microcontrollers?

Not sure what you mean by "custom"? I'd make a normal FLASH peripheral (just a struct, no functionality) and then a Flash driver that you pass all that config when creating it. If we do this, the API would have the same structure as any other peripheral.

Not sure what you mean by "custom"? I'd make a normal FLASH peripheral (just the singleton struct, no functionality) and then a Flash driver that you pass all that config when creating it. If we do this, the API would have the same structure as any other peripheral.

By custom i just meant that it does not come from a pac peripheral. Not sure what the requirements are for the peripheral! macro in embassy?

Ah! then all our peripherals are already "custom". They're all invented by the HAL, we don't use the PAC ownership model. (rp and stm32 PACs don't have owned singletons at all because they're generated by chiptool. nrf PACs do because we're using the nrf-rs ones, but we just ignore them)

Perhaps it would make sense to just have the RAM-blobs implement the CMSIS-Pack ABI? That way it would be re-usable by probe-rs once they figure out how they want to tackle https://github.com/probe-rs/probe-rs/issues/1212

I've started looking into this again, and came up with a thought here:
Would it make sense to make N different flash RAM blobs that works in the same way as the boot2, where you have to include_bytes!() one of them, that is linked into a ram location, where each of the N versions would be e.g. QSPI, Dual SPI etc. based on chip capabilities. These RAM blobs would implement be implemented as the CMSIS-Pack ABI just like https://github.com/rp-rs/flash-algo/
What is left is then the considerations around ERASE_SIZE, WRITE_SIZE, READ_SIZE, FLASH_SIZE.
Would it be possible to make those configurable through a macro, in the same way as defmt::timestamp!()? (https://github.com/knurling-rs/defmt/blob/ce350f767ffe44bc12513e411a0440c47d5ba0f4/macros/src/items/timestamp.rs#L34-L59)
Basically a macro that fills three different link symbols, and can only be called once in the entire binary (checked at link time)
Something like embassy-rp::flash!(QSPI, 16 * 1024 * 1024, 2048, 4, 1), where embassy-rp::flash!(FLASH VARIANT, FLASH SIZE, ERASE_SIZE, WRITE_SIZE, READ_SIZE)? One could then do a fallback to the ROM function variant, if embassy-rp::flash!() is not called?
Thoughts @Dirbaio @lulf

@Dirbaio Ready for review!

Resolved

@Dirbaio Ready for merge!
In case you didn't see it on matrix, I figured out the issue was due to the RTT header residing in flash:

debugger looking for the RTT header which caused the flash access which in turn caused a fault?
I had the same issue with rp2040-flash, with the following workaround: https://github.com/jannic/rp2040-flash/blob/ea8ab1ac807a7ab2b28a18bb5ca2e42495bb744d/examples/flash_example.rs#L88-L92
For defmt-rtt, it should be fixed with version 0.4.0, which includes https://github.com/knurling-rs/defmt/pull/683

bors r+

bors r-

bors r+

bors r+

bors r+

I don't understand why the bors test is failing?
It works 100% of the times with teleprobe locally?
@Dirbaio

the CI has a Pico W, not sure if it matters..?

Hmm. I just tested it on a Pico I had lying around here (non W version), and it works great there as well. Teleprobe tests pass 100% of times.
Not sure what is different with the CI, but I don't have a Pico W to test it on :(

bors r+

bors r+


webpubsub client, update date on changelog

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

There is something strange with the jacoco.testCoverage

Both "azure-messaging-webpubsub" and "azure-messaging-webpubsub-client" should have tests, but it shows 0.
And curiously "azure-resourcemanager-webpubsub" got number, but it should be using the same jacoco configure in parent pom.


Combine createFile and completeFile when sync metadata

Before this change, syncMetadata writes an inode journal entry and then two additional updateInode entries to complete the file. This combines three entries into one so that we do not have a failure mode where the first inode entry is inserted and incomplete files are left behind.

@bf8086 @calvinjia still cleaning up the PR but would like early feedback. The general idea is to reuse as much of the current completeFile and createFile code as possible.  So createFile now has an optional completeFileContext passed in, and can get completeFile results.  Unfortunately, it is not as clean as i hoped because now InodeTree has a dependency on the FileSystemMaster to complete the file.

Codecov Report

Merging #12855 (3ca813e) into master (33b564b) will decrease coverage by 38.94%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33b564b...3ca813e. Read the comment docs.

@bf8086 @calvinjia still cleaning up the PR / fix tests but would like some early feedback. The general idea is to reuse as much of the current completeFile and createFile code as possible. So createFile now has an optional completeFileContext passed in, and can get completeFile results. Unfortunately, it is not as clean as i hoped because now InodeTree has a dependency on the FileSystemMaster to complete the file.

I agree we should avoid having InodeTree call back to FSM to handle complete files. Maybe we can have the RpcContext allow an optional "preprocessor" that will merge the create entry with complete/update entries as they are appended?

closing this and open #12875


Chat Card GM Helpers

Add some actions/views to chat cards, for GM only:

show target AC/HP
roll saving throws for all (non character) targets for a saving throw spell (Think about auto applying dmg? Propably not.. but .. hmmm)

Testing a few of those things using overlays on hover.
Also use css classes to hide the information from players. (yes they could go into console and change that stuff.. but cheating is already easy in FVTT, so why make it more complicated? :shrug:

first version just includes showing ac of the target for gm only.

Change in Idea here:

always show target (and attacker)  to players (if not gm only roll) but hide rolls
allow GM to display (i think dmg only) rolls (automatically), when rolled, to players, without extra information like amount of dice used, modifier, ....
maybe show "hit" / "miss" for attack rolls and allow to show that information (automatically) to the players.

Added damage resistances, vulnerabilities and immunities to the overlay:

GM Rolls now have a unique style:
GMs can roll openly, to just display the attacker and weapon used and show the target.
Then for either hits or dmg dice they can decide to show the final rolled results by clicking on the eye icon. (rolled only) Players then are able to see those results, but not the components (or rolled dice results)

Looking nice.
Did you add in the custom DI/DR stuff?  I had a bit of a time with it.
Now it just needs to handle multiple targets for AOE stuff LOL.  Ya I know that's going to make the target area even more crowded.  Not only would multiple target icons need to be displayed but also a way for the DM to select which targets to apply the damage too since different targets can have different DI/DR etc.  Perhaps a checkbox on/next to each target image?
Bob

Did you add in the custom DI/DR stuff? I had a bit of a time with it.
yes

Now it just needs to handle multiple targets for AOE
hm.. won't make that for the time being
not sure as to how i want to handle this without spamming to much (e.g. fireball on 10 means chatlog overload)

GM Rolls now have a unique style:
GMs can roll openly, to just display the attacker and weapon used and show the target.
Then for either hits or dmg dice they can decide to show the final rolled results by clicking on the eye icon. (rolled only) Players then are able to see those results, but not the components (or rolled dice results)

Stuff to consider:
currently for this you'd have to roll public. This means that either the GM has to switch roll modes all the time or players do see everything.
options here:
a) override roll type for attack cards (let setting decide whether this is enabled or not)
b) add extra button to attack cards to easily show them

hm.. won't make that for the time being
not sure as to how i want to handle this without spamming to much (e.g. fireball on 10 means chatlog overload)

Ya not going to be easy to make it look decent.  I was thinking more of 1 attack card with 10 target images with ability to roll saves, via context menu on image OR way to select multiple images and trigger saves/apply damage.

a) override roll type for attack cards (let setting decide whether this is enabled or not)
b) add extra button to attack cards to easily show the

Personal opinion here is a setting in MESS config that determines visibility of the rolls.  That way its a one time set and forget vs constantly changing and always forgetting and exposing rolls I didn't want seen LOL, I know I'd screw that up way to many times LOL.
Bob

Just thought of another detail that would be handy for a DM.  Range to target and weapon/spell range to help determin if the attack roll should be with disadvantage or not.  Perhaps adding the weapon short/long range to the weapon description say something like Shortbow (80/320) and on the target someplace display the range to the target.  Getting the range can be tricky so here's a function that does the trick.
function getDistance (t1, t2, wallblocking = false) {
		var x, x1, y, y1, d, r, segments=[], rdistance, distance;
		for (x = 0; x < t1.data.width; x++) {
			for (y = 0; y < t1.data.height; y++) {
		   		const origin = new PIXI.Point(...canvas.grid.getCenter(t1.data.x + (canvas.dimensions.size * x), t1.data.y + (canvas.dimensions.size * y)));
		    	for (x1 = 0; x1 < t2.data.width; x1++) {
		      		for (y1 = 0; y1 < t2.data.height; y1++){
				   		const dest = new PIXI.Point(...canvas.grid.getCenter(t2.data.x + (canvas.dimensions.size * x1), t2.data.y + (canvas.dimensions.size * y1)));
				   		const r = new Ray(origin, dest)
				   		if (wallblocking && canvas.walls.checkCollision(r)) {
				   			continue;
				   		}
				   		segments.push({ray: r});
		    		}
				}
			}
		}
		if (segments.length == 0) {
			return -1;
		}
		rdistance = canvas.grid.measureDistances(segments, {gridSpaces:true});
		distance = rdistance[0];
		rdistance.forEach(d=> {if (d < distance) distance = d;});
		return distance;
	};

Note the above can also take into account wall blocking and if set and the target has full cover the range is returned as -1.
Bob

thanks
but i'm a little bit torn  on this.
On one hand i see the appeal, having a number there and not measure yourself
on the other hand imo the players should do at least some things themself.. and this is one.
(Also i find measuring kinda fun and an important part. Possibly due to my infinity and warhammer 40k past..)
i'll  think about it, maybe include it. But i wouldn#t want the wall blocking part for one main reason: performance. There is already a small delay when clicking a button and checking wall blocking (for each target) just  increases this to much  imo

Ok i thought of a reason against the range measurement:
you'd always have to make sure to use the action from the proper token. (Which i actually a lmost never do)
and for those cases when you do not its  "just" confusing.

i'll keep it in the current state (ac, dr, di, dv displayed) for this version
and maybe reiterate over it later on.


Clear output window previous syntax error(s) or compile messages when re-saving and there are no more errors

Just an annoyance, if I previously had syntax error(s) in my snakemake file and there's message output from those, when I've fixed them and I save the file the previous messages are still there in the output window and I'm no certain that the syntax or compile errors are gone.

I just published a pre-release. In this version if the linting is successful a corresponding message is outputted.  If this message is not printed then the syntax or compile error is not fixed. Let me know if this works for you.

Also works really well, very nice


import_blogger erroring with UnicodeDecodeError

I'm running the following to load a blogger site:
python manage.py import_blogger --mezzanine-user=admin --blogger-id=XXX
where XXX has been replaced with the blogger id and I'm getting the following Traceback:
Traceback (most recent call last):
  File "manage.py", line 14, in <module>
    execute_from_command_line(sys.argv)
  File "/home/henry/Documents/Sites/Development/ExiledRobin/env/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 367, in execute_from_command_line
    utility.execute()
  File "/home/henry/Documents/Sites/Development/ExiledRobin/env/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 359, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/henry/Documents/Sites/Development/ExiledRobin/env/local/lib/python2.7/site-packages/django/core/management/base.py", line 294, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/henry/Documents/Sites/Development/ExiledRobin/env/local/lib/python2.7/site-packages/django/core/management/base.py", line 345, in execute
    output = self.handle(*args, **options)
  File "/home/henry/Documents/Sites/Development/ExiledRobin/env/local/lib/python2.7/site-packages/mezzanine/blog/management/base.py", line 170, in handle
    self.handle_import(options)
  File "/home/henry/Documents/Sites/Development/ExiledRobin/env/local/lib/python2.7/site-packages/mezzanine/blog/management/commands/import_blogger.py", line 84, in handle_import
    pub_date=published_date, tags=tags)
  File "/home/henry/Documents/Sites/Development/ExiledRobin/env/local/lib/python2.7/site-packages/mezzanine/blog/management/base.py", line 68, in add_post
    title = decode_entities(title)
  File "/home/henry/Documents/Sites/Development/ExiledRobin/env/local/lib/python2.7/site-packages/mezzanine/utils/html.py", line 77, in decode_entities
    return re.sub("&#?\w+;", decode, html.replace("&", "&"))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 37: ordinal not in range(128)

Hi Henry,
Please use the mailing list, where this question gets answered quite often.


Update tracing packages release versions

Update tracing packages to use the latest dependency versions.
Update samples to use the latest API changes and versions.

@alzimmermsft Since some of the packages are still deciding on the versions, I have everything with current master pom file versions for libraries. Also, all the readme and samples are .md so can be changed once the respective libraries are shipped.


improve theme shell

passion.zsh-theme: line#106
local cmd="${$(fc -l | tail -1)#*  }"
will return line number, and I think it's should be optimized

add -n flag to fc command to ignore the line number.
local cmd="${$(fc -ln | tail -1)#*  }"

/cc @ChesterYue

passion.zsh-theme: line#106 local cmd="${$(fc -l | tail -1)#* }"
will return line number, and I think it's should be optimized
add -n flag to fc command to ignore the line number.
local cmd="${$(fc -ln | tail -1)#* }"

I found fc can -number to get  last so just local cmd="$(fc -ln -1)"; 93e68a3eb714e361719e0ffce25c4d2108baf475

passion.zsh-theme: line#106 local cmd="${$(fc -l | tail -1)#* }"
will return line number, and I think it's should be optimized
add -n flag to fc command to ignore the line number.
local cmd="${$(fc -ln | tail -1)#* }"

I found fc can -number to get last so just local cmd="$(fc -ln -1)"; 93e68a3

Nice.


extend MilvusEmbeddingStore:

extend MilvusEmbeddingStore:

supports inserting by partition
supports search by partition

Summary by CodeRabbit

New Features

Introduced partition management functionality, including the ability to check for existing partitions, create new partitions, and insert into or search within specific partitions.

@langchain4j Please process this request


timeseriesinsights - When creating a new Standard Environment, data-retention-time is not properly documented

If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name (the extension in question)
timeseriesinsights
Description of issue (in as much detail as possible)
When creating a new Standard Environment, data-retention-time is not properly documented. The command sample is:
az timeseriesinsights environment standard ... --data-retention-time P31D ...

When it should be
az timeseriesinsights environment standard ... --data-retention-time 31 ...

add to S170


Update OWNERS file

What does this PR do?
Remove xbaran4 from OWNERS file
Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

quay.io/redhat-appstudio/pull-request-builds:spi-controller-#
quay.io/redhat-appstudio/pull-request-builds:spi-oauth-#

Yes, you are right. Updating it.


Echo =false option

It will be nice to have an "echo=False" option

Can you give me some context where echo: false option would be helpful.
I am asking this because I made this extension to show code contents from scripts file in the rendered output. echo: false does the opposite when used in a code chunk.


Implements Proposal: Address Base Image Reproducibility

https://github.com/GoogleContainerTools/jib/blob/master/proposals/reproducible_base_image.md
Fixes #241
Fixes #217

should you remove the proposal as part of this PR? Or move it to "archives" or something.

Yeah "archives" sounds like a good idea.


Structuring reducers publish prep

Add "Structuring Reducers" pages to docs TOC, and rename reducer pages for better URLs.

CC @timdorr
Think this should be all that's needed to get it publishing okay.

Looks like something is conflicting now?

Yeah, I think one of the typo PRs I merged conflicts with the edits.  Lemme poke at this.

Conflict fixed.  Should be good to go now.

Schweet!


Spotlight: initial commit

Adds a vanilla Spotlight application with README requirements and installation steps into the project repository. Includes Rubocop.
Intentionally keeping this as a draft PR until we meet again.

Changed this to merge against the new develop branch


update root /proxy path

Fix issue: https://github.com/kubernetes/kubernetes/issues/61826
Related change: https://github.com/kubernetes/kubernetes/pull/59884

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.10 Features: set Milestone to 1.10 and Base Branch to release-1.10
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box so that maintainers can work on your patch and speed up the review process. This is a temporary workaround to address a known issue with GitHub.>
Please delete this note before submitting the pull request.

/assign @mikedanese
For tech review.

/approve for docs
@mikedanese if it looks good to you, add an /lgtm and we'll get it merged. Thanks!

Thanks!


Computer crashes when clicking on 'Templates'

When I click on the 'Templates' button, my computer crashes. No clue why.
I'm using a Mac Mini (Late 2012) and Godot 3.0.2 (Stable)
Any help?

Please try Godot 3.0.6.

Ok

@Zeph-dev Can you still reproduce this in 3.0.6 or 3.1 alpha?

No, not that I know of.

Thanks, closing.


Maintenance/issue 2401 remove unnecessary standalone code try 2

Submission Checklist

[X] Run unit tests: ./runTests.py src/test/unit
[X] Run cpplint: make cpplint
[X] Declare copyright holder and open-source license: see below

Summary
Issue #2401, there's some unnecessary code for getting standalone functions working in rstan.  Also changed how standalone functions are generated (matching PR in rstan) so that the functions are generated inside namespaces and a wrapper is generated outside the namespace that calls the generated function with its fully qualified name.  Should reduce namespace pollution when using generated code.  Finally, I changed the comment tag that's generated for each function to be generic rather than Rcpp-specific since we have to do a little text-replacing in rstan anyway, as would any other interface that had to decide what to export.  The new tag for each wrapper function is:
// [[stan::function]]

Also thinned out some excessive includes.
Intended Effect
Remove unused generated code.  Make standalone functions easier to compile from rstan.
How to Verify
Run tests, they should all pass.  The rng helper is gone.
Side Effects
None, nobody relies on this code, AFAIK, outside of rstan which is getting a matching PR.
Documentation
NA
Copyright and Licensing
Krzysztof Sakrejda
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

No idea why this passed locally.

@seantalts a test failed, I edited the test locally and pushed to the branch this PR is based on but the commit is not showing up here and the testing hasn't re-started.  What do I do to make the commit show up and restart testing?

@sakrejda Github had a hiccup; I noticed it in my own testing. It seems to be working again.

I actually think Github is still hiccupping... There's a big lag between my own push being accepted and the webhook triggering to Jenkins, and I think even between the push registering and the changes appearing live in the repo or on the pull requests, for example... I don't think there's much we can do about it besides wait, unfortunately - even manually triggering the jobs does not seem to pull the latest commit.

https://status.github.com/messages

@seantalts ok, I get it now, thanks.

Jenkins retest this please

Wow, I think this would pass if I just put in the ast.hpp include but it's fascinating trying to resolve the specific includes required.

@mitzimorris this is ready to review, it goes with a PR in rstan but should be reviewed independently.  The goal was to get something more generic in here that could play better with Rcpp (and potentially any other C++ interface).  If you can suggest tests to make this easier to maintain into the future I can add some, previously it doesn't seem like there many but then again the component functions well tested. IDK.  I think it's either you or @bob-carpenter who need to review (?)

This PR is blocking rstan from deleting a whole bunch of hacks to implement standalone functions.  No idea when the next rstan release is happening but it would be great to get this in and reduce the frustration people have with using standalone functions.

Thanks Mitzi!


QFileSystemModel Goodness

Do the thing so the thing is done.

Bumping this back a bit - will not be ready for Lumina 1.4.0


Fix#240/add build step to construct psm1

Code to merge public and private functions into one psm1 file to address https://github.com/PowerShell/PowerShellGet/issues/240

Please take a look at the CI test failures.

In reply to: 372024549 [](ancestors = 372024549)

Thanks for that, are you saying there are affectively two modules here defined in the one module file? And that the ExportModuleMember -Functions in the PSM file list is actually different to the FunctionsToExport list in the PSM1. This seems odd to me.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Manikyam Bavandla<EMAIL_ADDRESS>Sent: Tuesday, March 13, 2018 3:08:44 AM
To: PowerShell/PowerShellGet
Cc: benny1007; Author
Subject: Re: [PowerShell/PowerShellGet] Fix#240/add build step to construct psm1 (#242)
@bmanikm commented on this pull request.

In tools/build.psm1https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r173913578:

   $publicFunctionsString += "$PublicFunction,"

}

$publicFunctionsString = $publicFunctionsString.TrimEnd(",")
$FunctionExportString = "Export-ModuleMember -Function $publicFunctionsString"

$ModuleFileContent = Get-Content -Path $ModuleFile
$ModuleFileContent = $ModuleFileContent.Replace("#buildScriptPrivateFunctionsGoHere", $PrivateFunctionContent)
$ModuleFileContent = $ModuleFileContent.Replace("#buildScriptPublicFunctionsGoHere", $PublicFunctionContent)
$ModuleFileContent = $ModuleFileContent.Replace("#buildScriptExportFunctionsGoHere", $FunctionExportString)

Write-Verbose -Message "Writing functions to PSM1 file"
Set-Content -Path $ModuleFile -Value $ModuleFileContent

Write-Verbose -Message "Updating module manifest file"
Update-ModuleManifest -Path "$ModuleRoot\PowerShellGet.psd1" -FunctionsToExport $PublicFunctions.BaseName

$PublicFunctions.BaseName [](start = 84, length = 25)
This adds all the provider level public functions at module level.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/PowerShellGet/pull/242#pullrequestreview-103181269, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AexDYd9AqbtarCaLrKYs_gxii8qblXTCks5tdse8gaJpZM4SlP_l.

@Benny1007 Please take a look at the below topics for more details.
How does PackageManagement relate to PowerShellGet? (High Level Answer)
How does PackageManagement actually relate to PowerShellGet? (Technical Details)
The PackageManagement provider functions, implemented in the PowerShellGet module, can't be used directly by the end-users, they can only be used with the PackageManagement cmdlets. That's they are not listed in the FunctionsToExport entry of the PowerShellGet module manifest.
All the public functions under public folder need to be separated into two folders, so that it will be easier to get the list of public cmdlets to be exported at the module level and the list of provider functions to be exported at provider level.
public\cmdlets
public\provider

(I am fine with other suitable names for the above proposed sub folders)
All public functions from both folders need to be listed as the Export-ModuleMember in PSModule.psm1 file.
All public functions under public\cmdlets dir need to be be listed as the FunctionsToExport in PowerShellGet.psd1 file.

Create install locations for scripts if they are not already created

Please move below region placeholders prior to this. This is the reason for below error in CI test runs related to Test-RunningAsElevated usage.
Test-RunningAsElevated : The term 'Test-RunningAsElevated' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At C:\powershellcore\Modules\powershellget\1.6.2\PSModule.psm1:856 char:110
+ ... :ProgramFilesInstalledScriptInfosPath) -and (Test-RunningAsElevated))
+                                                  ~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : ObjectNotFound: (Test-RunningAsElevated:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException

#region private functions imported via build script

#buildScriptPrivateFunctionsGoHere

#endregion

#region public functions imported via build script

#buildScriptPublicFunctionsGoHere

#endregion

Refers to: PowerShellGet/PSModule.psm1:855 in 84e1c78. [](commit_id = 84e1c78b60cbb1be40f0d892fa65be077517cd2d, deletion_comment = False)

with regard to moving the regions for the function import, I will do this. (this was actually the reason I made it place holder replacement rather than just appending to the file, however I forgot the reason I did that.

I am still not clear about those explanations around Packagemangement vs PowerShellGet. From reading those pages it would seem that PowerShellGet is just a package manager, and PackageManagement is a common interface to work with ANY package manager so why are there Packagemanagement implementation details within the PowerShellGet? Shouldn't Packagemanagement be a separate repo, or is it a separate repo already and these functions are just used by packagemanagement?

While merging the contents of individual files into the PSModule.psm1 file, we need to remove the below region, right?
#region Load of module functions after split from main .psm1 file issue Fix#37

$PublicFunctions = @( Get-ChildItem -Path $PSScriptRoot\public\*.ps1 -ErrorAction SilentlyContinue )
$PrivateFunctions = @( Get-ChildItem -Path $PSScriptRoot\private\*.ps1 -ErrorAction SilentlyContinue )

# Load the separate function files from the private and public folders.
$AllFunctions = $PublicFunctions + $PrivateFunctions
foreach($function in $AllFunctions) {
    try {
        . $function.Fullname
    }
    catch {
        Write-Error -Message "Failed to import function $($function.fullname): $_"
    }
}

#endregion

Proposal:

We might have to split the current contents of PSModule.psm1 file into multiple .ps1 files under PowerShellGet\private\init\ folder and dot source them in the PSModule.psm1 file. The current contents of PSModule.psm1 can be moved into begin.ps1, process.ps1 and end.ps1 files (these are just placeholder file names, I am open to other suitable names).
Move the private folder contents into private\functions.
process.ps1 will be ignored during the single file construction. This file will have the dot source logic as in above region with some additional logic.
During the single file construction, PSModule.psm1 file will be overwritten in Merge-FunctionsIntoPSMFile function.

Why are there Packagemanagement implementation details within the PowerShellGet? Shouldn't Packagemanagement be a separate repo, or is it a separate repo already and these functions are just used by packagemanagement?
PackageManagement has its own repo --> https://github.com/oneget/oneget
PowerShellGet is PackageManagement provider, so all the provider functions need to be implemented in this module, these provider functions can only be used with the PackageManagement cmdlets.
PackageManagment architecture can be found at https://github.com/oneget/oneget#get-started .
High-level execution flow of a PowerShellGet cmdlet
PowerShellGet\Install-Module --> PackageManagement\Install-Package --> PowerShellGet provider Install-Package function

@Benny1007 It looks like providerfunctions folder has psget function files and vice-versa.
Also please ensure that Get-PSRepository.ps1 file is under public\psgetfunctions folder as it is a PowerShellGet module level cmdlet.

�

Please fix the encoding of this file.

Refers to: PowerShellGet/PSModule.psm1:58 in 66ddc64. [](commit_id = 66ddc6489941a63700b768208c02e862ab85cfb3, deletion_comment = False)

@Benny1007 Below are the outstanding comments:
https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r177927072
https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r177890058
https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r177893797
https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r177894453
https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r177581202
https://github.com/PowerShell/PowerShellGet/pull/242#discussion_r177580314

@Benny1007 Please let me know if I can submit the required changes to your fork's branch.

@bmanikm sure be my guest, bit busy this weekend ! 👍


New Export Preset fileselection cleanup overwrites manual export_presets.cfg edits

Godot version:
3.2.2.rc2.official
OS/device including version:
win10 64x
Issue description:
The added (https://github.com/godotengine/godot/pull/39434) cleanup for export preset file selection seems to overwrite manual changes in the preset config file that are made while the editor is running. It seems the presets are saved with an old filelist that is created on editor startup and never updated when not opening the export menu.
This is not an issue for manual selection of files in the export preset (by using the export menu that triggers an update) but an issue that affects all scripted updates that edit the export_presets.cfg config file directly.
E.g. on a current game project there are way over 10.000+ files, no way to update this manually in the export preset by clicking them one by one. Instead all presets in the export_presets.cfg are updated with a script to add current files in the export_files=PoolStringArray().
Now everytime
a) Export menu is opened
b) Editor closes
.. the export presets save but the export_files get overwritten with the old list from the first editor startup.
Workaround:
"Crashing" the editor on purpose solves the overwrite issue currently and keeps the updated filelist on the next editor startup.
Possible fix:
The preset filelist should always update with the content from the export_presets.cfg directly before the preset save function runs to make sure it stays current and accounts for manual edits.
Steps to reproduce:
1.) Create export presets with file selections
2.) Start editor again
3.) Now make manual changes to the export_presets.cfg and export_files=PoolStringArray()
4.) Close editor or open export menu, all manual changes get overwriten even if all the added files exist in the project.

CC @mrushyendra

@smix8 Just to confirm, this occurs when someone:

Opens the editor
Makes manual changes to files in export_presets.cfg
Opens the export dialog (overwrites export_presets.cfg)

It seems like in the old version a similar issue exists too, but only when selecting Export Project:

Open the editor
Make changes to files in export_presets.cfg
Open the export dialog (does not overwrite the cfg file yet)
Export Project (exports project with the manual changes included)
Automatically overwrites export_presets.cfg with the original version

Another temporary workaround for now could be to use the command line to export, without opening the export dialog window at all. Lastly, closing the editor did not seem to overwrite the cfg file for me.

I now used a clean, new godot project and retried and it overwrites the export_presets.cfg with (old) content saved at editor startup when Project -> Export is opened.
It doesn't save/overwrite on editor close with a clean, new project so might be a toggled setting or leftover in the old project.
So the Project -> Export menu button triggers a write on the config but doesn't update the filelist before it overwrites.
I still think the update of the preset filelist shouldn't be bundled with a menu click alone, it should run directly before the preset save function runs so it always stays current or else it will only fix the problem for small projects but stay a nightmare for large projects with multiple users.


now-cli: releases without assets

On my CI I downloaded the now-alpine from the github release package in version 15.4.0.
I've done this with
wget -q https://github.com/zeit/now-cli/releases/download/15.4.0/now-alpine.gz

Today I wanted to update it to the latest version and found out that since 15.8.7 (explcuded) no pre compiled now assets are attached to the releases anymore.
Is this an issue or expected?
From where can I get the alpine now cli now?

I just found this: https://github.com/zeit/latest-now-cli
Thanks and have a nice day 😂

Reopened. Because the repo I mentioned does not work... :/

Hi @StefMa
We no longer ship Now CLI as a binary.
Instead, it requires node.js and npm to be installed first and then you can run npm i -g now.
https://zeit.co/download

But then my builds on the CI aren't exactly the same because it may happen
that you publish a new version which is incomatiple with my code...
Or can I specify the version to download with npm?
On Fri, Sep 27, 2019, 11:14 PM Steven<EMAIL_ADDRESS>wrote:

Hi @StefMa https://github.com/StefMa
We no longer ship Now CLI as a binary.
Instead, it requires node.js and npm to be installed first and then you
can run npm i -g now.
https://zeit.co/download
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zeit/now/issues/3074?email_source=notifications&email_token=ACOBQ64QP5HWXZKE3UN7T2LQLZZSVA5CNFSM4I2N5JWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD72DORQ#issuecomment-536098630,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACOBQ66MULMAOY7BUWAKZ7DQLZZSVANCNFSM4I2N5JWA
.

@StefMa You can, indeed!

Ah okay. Thank you 👍
Will close it because it's answered.


"Sign in" appears in the drawer when the user is already signed in after re-launching app.

Summary:
"Sign in" appears in the drawer when the user is already signed in after re-launching app.
Steps to reproduce:

Sign in to Open Food Facts.
Close the app (and kill it).
Re-open and observe the drawer.

Add system logs:
NA
Expected behaviour
Button shows the "Logout" option with icon.
Observed behavior:
Button shows "Sign In" still.
Device and Android version:
NA
Screenshots:

Working on it


Origin/feature/robot

Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata

There are some sleeps in the settings file. Can those be implicit waits, or is that not working in the settings page? Other than that, looks good to me.

you will see the update in the next checkin


Mouse pointer should be text and not arrow one

Expected behavior
The mouse pointer used should be the text cursor (Ꮖ) one since text is selectable, not the default arrow (↖) pointer.

Actual behavior
It's the default arrow pointer that's used.

#1375

Probably correct.

I very much hope that the  mouse pointer is always text, even if no text is selected; Just like git-bash and cygwin.

Is there any way to configure a text  mouse pointer is text cursor (Ꮖ), ? Just like git-bash and cygwin.

Just to make sure that I'm not missing anything, there's currently no option for this, right?

@matteocontrini You're not missing anything. This is not currently a possible setting. We'd welcome a community contribution to add this as a setting, but for now, it will remain on the backlog.

@zadjii-msft I understand this is not the priority right now but I think this should really be implemented like this, and not as an option. Just like there is no option in Word or Edge to disable the text cursor when an input/text area is active or the mouse is over some selectable text.
If I remember correctly, in very old cmd.exe by default it wasn't possible to select text: you had to choose an option in a menu to enter this mode. So this made sense the pointer wasn't the text one by default. But in the new Terminal app, this is no longer the case: you may always select text and the mouse cursor should hint at that.

No problem having an option for that but I still think that by default it should be consistent with the whole OS & apps. And whenever text is selectable, you shouldn't have an "↖" mouse pointer but a text "Ꮖ" pointer.

Scrolling through logs, a click is not going to move the active text insertion position into another place in the buffer. That's what the Ꮖ cursor makes me really think, and that's what won't happen in the Terminal.

I'm fine with that. Having a text mouse pointer and clicking somewhere doesn't necessarily mean that you are changing the active insertion position simply because you may have an area with selectable text that's simply not editable, so there won't be any active insertion position. Think about a webpage, a pdf reader, the about window of Windows 10 Calculator app, etc... There are lots of text that's selectable but cannot be edited and the user needs to know about it. In modern interfaces (that includes Windows apps, like Settings,...), when you hover text that's selectable, the mouse pointer switches to "Ꮖ". I don't see why this should be different for the Terminal app.
Here is the Windows Settings app:

I selected some text that's selectable, and it correctly uses the "Ꮖ" mouse pointer. But if I move the mouse over Your device recently got the latest update... on the right, the mouse pointer would turn into "↖", showing that this text cannot be selected/copied.
Here is an example of a Mac terminal app: selecting text doesn't change the insert position:

Here is an example of a Mac terminal app: selecting text doesn't change the insert position:

This is also the case on the default Ubuntu terminal, and probably many other distributions. The Windows cmd/wt is probably one of the few terminals to behave differently.

I actually think we should just always use Ꮖ. I know that's controversial :smile:

One thing to consider when designing this is that many Linux terminals will actually switch to using an arrow when the terminal app registers mouse support. You can see this when enabling Vim's mouse support, for instance.

Alright, I implemented this and i realized i hate it. I can't select text any more because I keep ending up off-by-one on the start point. It looks like it should be easy, but the point projected off the I-beam cursor doesn't line up with the completely normal terminal grid.

Alright, https://github.com/microsoft/terminal/pull/5028

Is there any chance for this to be implemented? Thanks

@matteocontrini not any time immediately soon. There was an attempt in #5028, but we ran into some fundamental issues with WinUI that prevented us from getting that across the finish line. We were under the impression that this wouldn't be a solvable problem before WinUI 3 (which we're not likely to move to any time soon).
I'd LOVE to see someone take that branch and prove me wrong!

I also would love the Ꮖ cursor to be set by default, but yeah an option is the better way here to let users decide. I don't have the skill to do this, unfortunately; but that's one of the time I wish Github could allow user to put bounties on tasks 😄 to attract more contributors and help @DHowett attempt! Cheers

One thing to consider when designing this is that many Linux terminals will actually switch to using an arrow when the terminal app registers mouse support. You can see this when enabling Vim's mouse support, for instance.

This is one of the strongest arguments
When the underlying console app DOES have mouse support, it signals the terminal (I don't know how it happens behind the scenes) and the terminal CHANGES the cursor from I-beam pointer to OS/DE defined arrow pointer. This in turn signals the user that it can or can not freely type into the area where the mouse is an arrow, or more exactly the user knows that when the cursor is arrow, the key presses are NOT sent ad-literam to the app, but instead at most they can be interpreted as command shortcuts to the app.
This UI convention has existed for years, I think even since Windows 3.11: programs that work with text input are responsible for changing the mouse cursor from arrow to I-beam when mouse is hovering or moving over the text input area. The only other case when the mouse cursor is changed from arrow to I-beam is when there is selectable text available, even if the text input is not available.
Windows Terminal should make no exception from this convention and has no reason not to. Sure it can be argumented "it's overly complicated at this stage", but this should be a clearly declared goal of the app. Not "hm, it's debatable, hm, oh it's so complicated technically that we might just let it low in the priority queue".
This should be among top priority tasks for a Terminal app.

rant: I can't believe this isn't so obvious and I have to spend time explaining why it should work that way.

rant: I can't believe this isn't so obvious and I have to spend time explaining why it should work that way.

I also can't believe I created this issue 4 years ago...

There's no debate as to if we should do this or not. For those who read the thread, as I mentioned before (https://github.com/microsoft/terminal/issues/1441#issuecomment-1302644917), we tried to do this a couple years back (in #5028), and ran into fundamental flaws in WinUI. We'd love if someone could prove us wrong though!


Mouse Side buttons have weird behavior(I have a mouse with 6 side buttons)

[] I have read the FAQ.
[] I have searched in existing issues.

Environment

OS: [Windows 10 22H2 ]
scrcpy version: [2.1.1]
installation method: [Windows Release]
device model:SMA536E
Android version: [Android 13,One UI 5.1]

Describe the bug
I have a mouse that has 6 side buttons.
Starting from the bottom and right to left as seen in the picture the first button works properly and opens the multitask view as intended. The middle button on the bottom rotates the screen by 90 degrees,(see console output when i press it)

The last button does nothing. The top row of buttons all highlight an app when pressed, multiple presses does not do anything further.

Ive also tested with a normal two side button mouse and it works properly. Is there any way to remap the buttons or limit my side buttons to only 2 in scrcpy so i can access the notifications tray?

The middle button on the bottom rotates the screen by 90 degrees

It probably generates Alt+right. Try scrcpy -Vverbose to get more info.

Is there any way to remap the buttons or limit my side buttons to only 2 in scrcpy so i can access the notifications tray?

If the mouse generates specific keyboard combinations, it should be configured in the mouse driver.

The middle button on the bottom rotates the screen by 90 degrees

It probably generates Alt+right. Try scrcpy -Vverbose to get more info.

Is there any way to remap the buttons or limit my side buttons to only 2 in scrcpy so i can access the notifications tray?

If the mouse generates specific keyboard combinations, it should be configured in the mouse driver.

Yep it generates Alt+right, for some reason the logitech software defaulted to Alt+right for forwards so it worked in other places like browsers and windows explorer,  but kept the back button as a system back button, it works just fine now. thank you so much for the help, Im really loving the app!


[#45] Initial try to fix module configuration not loading

Resolves #45

@palagdan
Note, that to overcome issues with different react versions I used:
npm install --legacy-peer-deps
I did not investigate much, but I guess it won't be possible to fix build without upgrading react version of s-pipes-editor-ui.

@blcham
The problem was indeed in version of react. I updated it to the version 18.2.0 and everything works fine:

However, I'm not a fan of using the --legacy-peer-deps flag. While investigating the dependency issues, I discovered that many dependencies haven't been updated in years. Updating to version 18.2.0 feels like a temporary fix rather than a long-term solution.
I've created another ticket to address the old dependencies and look for alternative libraries.

@palagdan is the screenshot showing how it works now? Because it looks strange ...

@blcham
No, there are no errors in the console. I noticed that you changed a dependency for s-forms. Could the problem be related to that?

test it
On Sat, 10 Aug 2024 at 17:17, Daniil Palagin @.***>
wrote:

@blcham https://github.com/blcham
No, there are no errors in the console. I noticed that you changed a
dependency for s-forms. Could the problem be related to that?
—
Reply to this email directly, view it on GitHub
https://github.com/kbss-cvut/s-pipes-editor-ui/pull/46#issuecomment-2282183755,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6HK7IRPTB4YE4UENJWAB3ZQYVH3AVCNFSM6AAAAABMGXOMB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGE4DGNZVGU
.
You are receiving this because you were mentioned.Message ID:
@.***>

@blcham
I investigated this problem and what I got:
Before updating React to version 18:
The "Error Loading SForms..." message appears in all examples except for the Hello-World example.
When attempting to call the loading module configuration in the examples where it fails, the response from S-Forms appears valid and should work, but it does not.

In the Hello-World example, which is the only one where it works, submitting the form results in a request that is missing parameters (firstName, lastName), leading to an error.

After I updated react to version 18:
The infinite "Loading SForms" error no longer occurs, but the form is still not working correctly as it fails to send the parameters in the request.

@blcham
I also investigated the issues with the incorrect forms and found some unusual results. Initially, I tested different packages and observed varying outcomes. At first, the Hello-World example returned the correct forms, while the other examples did not. I tested with different Docker builds, including ones published a year ago. However, when I tried the latest build, all forms were correct in all examples, except for the constraint validation example, which initially returned an incorrect form but then corrected itself after a few minutes. I’m quite confused by these inconsistencies. Could we review this together?


[Major] Update project to use pipeline template

Change Description:
We are required to use a pipeline template as a base for security purposes.  This updates the pipeline files to do so, but this also added the requirement to be able to run the linter at the monorepo root instead of separately for each project which also requires a shared tsconfig file at the root and some package updates.  All this added up to some standardization between project, build changes, and many linter fixes.  Nothing should be functionally different despite the many changes . . . but verification will be needed.
Should do a major version bump to cover the updated tsconfig building which updated some properties for some packages.

Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters)
No.

Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)
No.

If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct
Validation/testing performed:
Ran the linter, ran the build, ran the automated tests, and used the branch to verify the pipeline changes passed.

I think this is ok, however, would it be possible to break up these huge PRs in the future for ease of reviewing? Though, I realize, it may not always be possible


I created a dockerized version of this

We are running elasticsearch within docker. The data is one a docker volume and I wanted to use Luke (thanks for picking Luke up by the way!). This was a bit tricky so I decided to find a way: https://gitlab.com/roelandvanbatenburg/luke
Currently I only have 5.3.0 as that is what I needed for my ancient elasticsearch data.
I'm not sure what I'm trying to accomplish with this issue except maybe provide some knowledge on how to run Luke within docker. Happy to work with you on integrating my stuff within this repository if that is desired.

Thanks,
we are planning to merge this project to Apache Lucene.
https://issues.apache.org/jira/browse/LUCENE-2562
I think Lucene community don't like to maintain the Dockerfile so I want to keep open this issue to inform others who need dockernized Luke.


fix: allow update network server_type

What this PR does / why we need it:
fix: allow update network server_type

Does this PR need to be backport to the previous release branch?:

release/3.12
release/3.11

/cc @zexi @wanyaoqi

/area region climc


python312Packages.mailchecker: 6.0.8 -> 6.0.9

Changelog: https://github.com/FGRibreau/mailchecker/blob/v6.0.9/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 341319 run on x86_64-linux 1

8 packages built:

python311Packages.mailchecker
python311Packages.mailchecker.dist
python311Packages.python-benedict
python311Packages.python-benedict.dist
python312Packages.mailchecker
python312Packages.mailchecker.dist
python312Packages.python-benedict
python312Packages.python-benedict.dist


feat: adds models for problem interaction reports (FC-0024)

Models should support the following reports listed in #4 :

problem difficulty (via learner_problem_summary)
answer distributions per problem (via problem_responses)
problem submission counts (also via problem_responses)

These models have been tested with the force_primary_key=1 setting to ensure they make proper use of indexes.

Thanks for the pull request, @SoryRawyer!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

I think we're going to need to do some fiddling as the visualizations come online but this is looking good. We're also going to need to start joining in the block names from the event_sink schema, but I need to figure out how to make fake ones from the generated fake data first.

@SoryRawyer 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Option for disable _interopRequire

There is no option for this.
Actually some of modules define default property in exports.
https://github.com/expressjs/morgan/blob/master/index.js#L191
exports.format = function(name, fmt){
  exports[name] = fmt;
  return this;
};
exports.format('default', ...);

I noticed that only the import statements are wrapped in _interopRequire. If you use a regular require() it doesn't wrap it, or at least it was in my case.
I ended up using esperanto to pre-process my es6 code, which converts it can convert it to umd/commonjs/amd. From there you can apply 6to5. I used esperanto's bundler to eliminate the require's completely instead of using something like browserify.

Duplicate of #493


ERROR:subliminal.video:Skipping badly encoded directory

Hi,
When using subliminal from a Bash script executed by Nautilus on a directory, I have this message : ERROR:subliminal.video:Skipping badly encoded directory
When I launch the script directly from an xterm with parameter it work
Do you have any clue ?
Version used :1.01
OS : Ubuntu 14.04
Script :
!/bin/bash
/usr/local/bin/subliminal --debug download -l fr -s "$PWD/$1" >> /tmp/sub 2>&1
Error example on /Windows/Series/Arrow
ERROR:subliminal.video:Skipping badly encoded directory u'/Windows/Series/Arrow'
ERROR:subliminal.video:Skipping badly encoded directory u'/Windows/Series/Arrow/S02'
ERROR:subliminal.video:Skipping badly encoded directory u'/Windows/Series/Arrow/S03'
Any clue ?

That's Python not correctly listing directories. Check the environment variables, especially encoding related ones, like LANG and LC_ALL.
Try with Python3, it might help.

Thank you Diaoul, i will continue to investigate on those directions.

I am having the same issue and are unable to solve it. Tried everything I know to set the encoding variables. Through cron, .profile, /etc/environment but none fixes it.. any tips?

Thanks for sharing. Did you try python3?

I confirm It work with tvb solution for Nautilus in case you are trying to scan a directory.
#!/bin/bash
Nautilus Script to Get Srt
export PYTHONIOENCODING=utf8
/usr/local/bin/subliminal download -l "fr" -s "$PWD/$1" && zenity --info --title "Info" --text "Subtitle downloaded successfully" || zenity --error --title "Error" --text "Subtitles not downloaded successfully" >> /tmp/sub 2>&1
@Diaoul : I will try with Python3 as my current version is 2.7.6

I edited the syntax so it displays nicely on GitHub. That could be nice to ship examples on how to use subliminal in that kind of ways (example cron jobs, right click context menu, etc.)

I agree, the documentation is lacking here and there.


Listing operations for Azure File Storage

Which version of the AzCopy was used?
Note: The version is visible when running AzCopy without any argument
azcopy version 10.2.1
Which platform are you using? (ex: Windows, Mac, Linux)
Linux - Centos 7.6.1810
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
./azcopy list https://xxx.file.core.windows.net/xxx
What problem was encountered?
It seems like any operation other than copying (didn't test it) is not supported by the azcopy tools for File Storage (not blobs), see #277.
The lack of support for the File Storage isn't well documented. I could be sure of it only when I found the aforementioned feature request.
How can we reproduce the problem in the simplest way?
Rerun the command for any url corresponding to an Azure file storage.
Have you found a mitigation/solution?
For now we're using rsync with the mounted Azure filesystem. We'll maybe consider azcopy once the File storage support is improved.

Related to #692

This feature was added in 10.3.3., which was release today.


Migrate to go native vendoring

the vendored package in Godeps is unused, so delete it
The app will now always use the default version of Go provided by the
buildpack, so it won't need to be updated regularly

[#142416247]
Signed-off-by: Sam Smith<EMAIL_ADDRESS>

bump


hack to get semicolon through to API

Regardless of whether the api_bridge is receiving a literal semicolon in the options list, or whether it is receiving an encoded (%3B) version, make sure that it is sent to the API as %3B in order to be recognized as ;
If we decide to post data to the API instead of via the URL, this could be revisited.
Changes:

bumps a version of the rails gem
writes a test for the semicolon step
removes unused method

Needs to be done (creating issues for these):

revisit URI library in favor of CGI
redo syntax throughout gem to match internal CDRH styleguide choices

Looks great.
I'd really like to try to get the change for the obsolete method in before we finalize for initial launch 🤞
Seems like you found this also, but here's a link for use with creating the issue as mentioned above: https://ruby-doc.org/stdlib-2.4.2/libdoc/uri/rdoc/URI/Escape.html#method-i-escape-label-Description
I'll merge once those issues are created :)

https://github.com/CDRH/api_bridge/tree/replace-obsolete-encoding addresses #2
Seems to make semicolons work without the pre-encoding of semicolons in Orchid PR https://github.com/CDRH/orchid/pull/57, so may need to remove that change. Retaining the minimal code cleanup would be nice though :)


CVE issue in Superset new version 1.4.1

PRISMA-2021-0132 - sqlparse - fixed in 0.4.2
apache-superset 1.4.1 requires sqlparse==0.3.0, but you have sqlparse 0.4.2 which is incompatible.
CVE-2021-23727 - celery - fixed in 5.2.2
apache-superset 1.4.1 requires celery!=4.4.1,<5.0.0,>=4.3.0, but you have celery 5.2.2 which is incompatible.
Any detail on this python package update?

Closing as Github isn't the appropriate place for CVE discussion!
Check out this article: https://superset.apache.org/docs/security/#reporting-security-vulnerabilities


Redefining attribute with /OUTPUT qualifier does not mark it as to-be-output

Reported by ansley b manke on 22 Nov 2010 19:21 UTC
DEFINE ATTRIBUTE/TYPE=string  urot.standard_name = "wrong name"

followed by

DEFINE ATTRIBUTE/OUTPUT/TYPE=string  urot.standard_name = "right name"

The attribute is not marked as /OUTPUT.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1767

Modified by ansley.b.manke on 5 Jan 2011 18:28 UTC

Comment by ansley.b.manke on 31 Mar 2011 19:22 UTC
Fixed.  In fact, if a user defines a new attribute, mark it as /OUTPUT by default. Why else would they define a new attribute?


Netty DNS resolver ignores provided DNS server address

Expected behavior
In netty 4.1.8.Final, following code works fine. However, in 4.1.9 it does not send the request to provided address and sends it to default name server stream instead.
import java.net.{InetAddress, InetSocketAddress}

import io.netty.channel.nio.NioEventLoopGroup
import io.netty.channel.socket.nio.NioDatagramChannel
import io.netty.resolver.dns.{DnsNameResolverBuilder, DnsServerAddresses}

/** Simple dns resolver for testing stuff
  */
object Cli extends App {
  private val bossGroup = new NioEventLoopGroup()

  val res = new DnsNameResolverBuilder(bossGroup.next())
            .channelType(classOf[NioDatagramChannel])
            .nameServerAddresses(DnsServerAddresses.singleton(new InetSocketAddress("customdns.com", 33220)))
            .build()

  println(res.resolve("testaddress.com").await().get())
}

If you run this code with netty 4.1.9 in debug mode, you can see it's sending requests to system resolvers.
I suspect the problem is the doResolveUncached in DnsNameResolver where you check whether the address stream is null. I think you should check whether the nameServerAddress is null and if it is, you should default to system resolvers. if it is defined however, you should make it into a stream and use it. But maybe im missing something.
Netty version
4.1.8.Final is fine, 4.1.9.Final is broken
JVM version (e.g. java -version)
1.8
OS version (e.g. uname -a)
mac os

@Scottmitch can you please check as this was introduced by your change in 54c9ecf682eeafaaf7c826903c60f1c783b84dea . I think @tomasherman is correct that we should ensure we not override the name servers set by the user in this case.

temporary workaround: Use NoopDnsServerAddressStreamProvider.
There is currently an issue with the APIs. nameServerAddresses (e.g. DnsServerAddresses) doesn't have any knowledge of the hostname when selecting the DNS server, but DnsServerAddressStreamProvider does have knowledge of the hostname when selecting the DNS server. When they are both used it is not clear which should have precedence. Currently the DnsServerAddressStreamProvider has precedence and we fall back to nameServerAddresses [1], and it can't really work the other way around (because nameServerAddresses would always be used). So we have a few options:

Keep the current APIs. If the user wants to specify nameServerAddresses then they must ensure DnsServerAddressStreamProvider is properly configured for their use case.
 This way the user has fine grained control (per hostname being resolved) as to what DNS server should be used for resolution. This approach is also easy to cascade. For example the user could specify a DnsServerAddressStreamProvider which programmatically overrides the DNS servers for some/all hostnames, and fallback to system default otherwise.

I'm leaning toward approach 2. I think it represents what we are logically trying to achieve and limits the surface area to a single interface. Since the DNS coded is labeled as UnstableApi we can also make this breaking change now. @normanmaurer @trustin - WDYT?
[1] https://github.com/netty/netty/blob/4.1/resolver-dns/src/main/java/io/netty/resolver/dns/DnsNameResolver.java#L641

i think the #2 makes sense ... i think having to configure two things in order to set dns server will be confusing

@Scottmitch yep go with [2].

see https://github.com/netty/netty/pull/6588


chnaged style of feedback button

@mdazfar2  merge this pull request

@Krishna100604, this is not the correct way to work on open source. You directly created a pull request without being assigned to the issue.


docker: fix latest tag

Only update "inputoutput/cardano-wallet:latest" for tag builds.
Don't push unique tags for each git revision, because it clutters the repo page on Dockerhub.

bors r+


[docs] Add links to xstate-vue2

This PR adds a link to xstate-vue2.
Addresses https://github.com/davidkpiano/xstate/discussions/2193
cc. @chrisshank

Lgtm! Thanks


Implement wall-cling / wall-slide / wall-jump

[x] Implement wall-slide (Instead of dropping after wall-cling, transition into slide)
[x] Implement wall-slide sound effect
[x] While in wall-cling or wall-slide states, allow jumping off the wall
[x] Implement wall-jump sound effect

Decided to drop wall-clinging for now.