Set Content-Id header on attachments through send message API

Discussed in https://github.com/orgs/postalserver/discussions/2817

Originally posted by memcorrupt February 24, 2024
Good to see that postalserver seems to have resumed development. 🙌
Currently, there is no support for setting the Content-Id header on attachments sent through /api/v1/send/message. I'm not quite well versed enough with the project & programming in Ruby to pull request it at this time, but from my brief look into the source code, I believe it can be implemented pretty easily.

Add cid parameter and handling to attachments in send_api_controller.rb, so that it gets passed to OutgoingMessagePrototype.new
Set content_id key within mail.attachments[name].

https://github.com/postalserver/postal/blob/main/app/models/outgoing_message_prototype.rb#L177
https://github.com/mikel/mail/blob/master/lib/mail/attachments_list.rb#L84

If there is any documentation that could ease the setup of a development environment for Postal, I could attempt to make the changes and PR them upstream.

I direct your attention to https://github.com/postalserver/postal/blob/main/CONTRIBUTING.md for the information you seek and kindly ask not to duplicate discussions into issues :pray:


Identify API calls via presence of bearer token

This change permits authorisation of AJAX-style calls in GDS-SSO
hosting applications via cookie-based sessions.
The bearer token string is matched per:
https://tools.ietf.org/html/rfc6750#section-2.1
Closes alphagov/gds-sso#106.

Gosh, I could really do with access to your CI boxes 😄

Unfortunately, that'd require VPN access :( Here's the output https://gist.github.com/boffbowsh/01c6ab8e03ba1014643a820d36347cb0

Looks to be the same issue as #105. Looks like signon isn't starting due to the bundler activation issue. I'm not sure I'd be able to solve this from here.

I'm moderately concerned that this pull request is running tests in our CI environment at all :)
@tijmenb: Did this run because of the thing you documented recently where pushing a branch of the same name to origin runs the tests? If so, that's cool.

The README will also need updating: https://github.com/alphagov/gds-sso/blob/82ed8e/README.md#authorisation-for-api-users

@alexmuller Yeah, it ran because somebody pushed the branch to this repo (https://github.com/alphagov/gds-sso/tree/bearer-api-calls). Don't know who though.

FWIW it's not based on branch name, but the actual commit.

I am the :ghost:

@alexmuller Updated the docs to suit.

Thanks! We should also amend this comment once this is merged and released.

If you can rebase this PR, I'll push it again and it should pass and everyone will be happy

@boffbowsh Done.


Fix plugin install exit code when install fails

Fixes #2470

Unable to review with the #2462 changes merged in.
I think the best way to do chained PRs on github would be to set the #2462 branch as the base for this PR, then github will show the diff against that PR. Once the base PR is merged, fix the base branch for this PR back to master.

Cleaned out the other PR

The rubygems commands/functions/whatever do write to STDOUT during spinning and mess out the output, but that's another issue for the future.


Library updated with new version.

Library updated with new version.
Reason : Causing many issue due to outdated libraries.

@wilburx9 Can you merge this?

Sorry sir not getting your point.
WRTeam https://wrteam.in/ | Follow Instagram
https://www.instagram.com/wrteam.in/ | Skype Support
https://join.skype.com/invite/BZ8brCpb7far | Codecanyon
https://codecanyon.net/user/wrteam/portfolio
Regards,
Vimal Gondariya
On Tue, Sep 12, 2023 at 8:14 PM Geeky Geeky @.***>
wrote:

@wilburx9 https://github.com/wilburx9 Can you merge this?
—
Reply to this email directly, view it on GitHub
https://github.com/wilburx9/flutter_paystack/pull/170#issuecomment-1715866698,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARACS5FEIAXRRP236IFHVITX2BYMZANCNFSM6AAAAAA3AWGR4Q
.
You are receiving this because you authored the thread.Message ID:
@.***>

We need this. Many other packages depend on http package. And when they support the latest version of http, the project's version solving fails.

The versioning error I am facing in my pubspec file has brought me here.
@unangity @wilburx9
merging this PR will do a lot of good right now


HACS support

Appreciate your worka and he fact that this your first this kind of project.
I think it would be great if you would add HACS support for your work.
cheers

Thanks. I will take some time and dive into HACS requirements and what I have to do next week.

HACS is working perfectly for me with a custom repository FYI:

HACS is working perfectly for me with a custom repository FYI:

![image](https://private-user-images.githubusercontent.com/3595020/328963241-2a829d21-b466-464d-b5b9-c0f58bff5dbf.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTUyNDcwMjMsIm5iZiI6MTcxNTI0NjcyMywicGF0aCI6Ii8zNTk1MDIwLzMyODk2MzI0MS0yYTgyOWQyMS1iNDY2LTQ2NGQtYjViOS1jMGY1OGJmZjVkYmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDUwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA1MDlUMDkyNTIzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjhjZDhjMGFiY2Q4YzlhZjEzYzliNzY5YjA4NjFkODgyYmE0OGJjODU4Yjg1OWNiMmY2OTdiOTkzOWM0OTNjOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.EdyoFXNxWXdcPyPJpQahNteTOyih1b9Vj6MqBrPJ4MI)

Oh, great. Did not think about that custom repo will to the trick until i put it officially to HACS

Yeah it looks to be working, information is missing, that could be added at some stage?

Thought this could do with an icon. Here is something I knocked up in draw.io.
PNG Version
SVG Version


Splitup into smaller units

streaming-utils has some heavy dependencies and i (and @fosskers) believe it is worth it to split streaming-utils into streaming-attoparsec, streaming-aeson, etc. for backward compatibility, streaming-utils could just re-export those things.

http://hackage.haskell.org/package/streaming-attoparsec has been available for a while. Haven't gotten around to pulling out -aeson yet though.


Ionic v2 AgmCoreModule import

Issue description
I'm working on an Ionic v2 project. The import statement presented in Getting started guide does not work.
Possible solution
I think it should be: import {AgmCoreModule} from 'angular2-google-maps/ts/core';
Instead of: import {AgmCoreModule} from 'angular2-google-maps/core';
angular2 & angular2-google-maps version
"angular2-google-maps": "^0.15.0"
"ionic-angular": "^2.0.0-rc.0"

@juanlu91 have you managed to launch angular2-google-maps in ionic?
I'm stuck trying to getting started. Maybe you could help
I'm importing AgmCoreModule this way
import { AgmCoreModule } from 'angular2-google-maps/ts/core';

And I'm trying to add AgmCoreModule in imports
  imports: [
    IonicModule.forRoot(MyApp),
    AgmCoreModule.forRoot({
      apiKey: 'MY_API_KEY'
    })
  ],

Here is my full ngModule definition
@NgModule({
  declarations: [
    MyApp,
    Map,
    Activities,
    Submit,
    Settings,
    Login,
    Page1,
    Page2
  ],
  imports: [
    IonicModule.forRoot(MyApp),
    AgmCoreModule.forRoot({
      apiKey: 'AIzaSyCiF08n8AVLZqchOD7uoKZ43fqc-19oS0k'
    })
  ],
  bootstrap: [IonicApp],
  entryComponents: [
    MyApp,
    Map,
    Activities,
    Submit,
    Settings,
    Login,
    Page1,
    Page2
  ],
  providers: []
})

And I'm getting this error when trying to build
ngc error: Error: Error encountered resolving symbol values statically. Function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symbol AppModule in E:/node/hotby.me/hotby-ionic/.tmp/app/app.module.ts, resolving symbol AppModule in E:/node/hotby.me/hotby-ionic/.tmp/app/app.module.ts

I get the same error if I try to build angular2-google-maps in an ionic app. Changing the import statement does not change anything. The error is the same.
Any solution for that?

Ohh, I have the same issue. Any help?

Sorry guys, the only way I found to get it to work was to add '--dev' flag to the build task in package.json as described here:
"scripts": {
    "build": "ionic-app-scripts build --dev",

However, this produces very slow apps. So fow now, I'll use plain google-maps javascript v3 until the AOT compilation works again.
I closed this issue because it's a duplicate of #629.
Good luck! I wish we could have angular2-google-maps working soon.

This will be fixed with #709.
Related blog post: http://stevemichelotti.com/integrate-angular-2-google-maps-into-ionic-2/

I've upgraded to Ionic2 RC4 and Ionic app scripts 0.47 and the error started occurring again:
Error encountered resolving symbol values statically. Function calls are not supported.
            Consider replacing the function or lambda with a reference to an exported function, resolving symbol

Perhaps the package is not up to date anymore with the latest ngc? or with an incorrect version of metadata.json?


⚠ Bofrost.fr has degraded performance

In 6663f93, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1207 ms

Resolved: Bofrost.fr performance has improved in 10694be after 6 minutes.


Added noImplicitAny option

Thanks for adding your fix. I integrated it locally into the project and made a commit.


eslint.options.overrideConfigFile、eslint.options.overrideConfig not work

env
Version: 1.69.2 (Universal)
Commit: 3b889b090b5ad5793f524b5d1d39fda662b96a2a
Date: 2022-07-18T16:12:57.074Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.5.0
vscode-eslint version
v2.2.6
Expected
eslint.options.overrideConfigFile、eslint.options.overrideConfig.rules should  work，see detail at https://eslint.org/docs/latest/developer-guide/nodejs-api#-new-eslintoptions

But
eslint.options.overrideConfigFile、eslint.options.overrideConfig.rules not work

but eslint.options.configFile、eslint.options.rules work ,

Other
And the configFile and rules   should be removed in eslint

Anyone who can help me？Thanks very much !

Could you please provide me with a GitHub repository I can clone that demos this. That ensures that we are looking at the same setup in terms of options and eslint, plugin versions.

demo
https://github.com/RichieChoo/vscode-eslint-demo

Could you please provide me with a GitHub repository I can clone that demos this. That ensures that we are looking at the same setup in terms of options and eslint, plugin versions.

Demo: https://github.com/RichieChoo/vscode-eslint-demo

@dbaeumer Could you please help me to find  the reason

@RichieChoo the reason is the ESLint version you are using. The new overrideConfig option is only available since version 8.x but you are requiring 7.32.0
The ESLint npm package changed naming around this for version 8.x in a breaking way. Hence clients need to adopt to this.

I will close the issue. Please ping if this doesn't help.


"style" property in package.json not respected when importing css

Version
v2.6.3
Reproduction link
https://github.com/btkostner/nuxt-css-package-bug
Steps to reproduce

npm install --save semantic-ui
Add semantic-ui to global css or in a component file
Try to build but get error

What is expected ?
When you import a package in CSS that has a style package.json property, it resolves to that file.
What is actually happening?
When importing a package in CSS that has a style package.json property, it uses the main property and resolves to a Javascript file.
Additional comments?
postcss-import should do this automatically. I manually commented out the advanced resolve logic nuxt adds to postcss-import without any luck in fixing it...
Also, the reason bulma and normalize.css work without this issue is because the main field in the package.json file is set to the stylesheet.
https://github.com/jgthms/bulma/blob/master/package.json#L11

This bug report is available on Nuxt community (#c9200)

Never mind. After looking into this more, it was the resolver messing up. PR is open upstream but could be fixed in nuxt depending how long it takes.
https://github.com/jsless/postcss-import-resolver/pull/2

Fixed in c741bb488370cb0ccfa21edab6f39467c6707d9d and released in v2.7.1


Connecting to Fluent-v19

I am new to pyansys. So this might be a very naive question.
Does pyansys work with ANSYS Fluent?
I notice IO files errors: No file aaS_MapdlId.txt. On the other hand, the working directory has a similar file, aaS_FluentId.txt.
Is there a pyansys class for Fluent like mapdl? Any pointers will be appreciated.
Thanks,
Fu

Not yet, but that’s on the roadmap to be added.

I need to connect to fluent using python in linux for my research project. I think your ansys_corba as a template can be a great start.
I am wondering if you have any suggestions. (Perhaps a roadmap or a set of key steps.)
Thanks

I’ll need some help in creating the interface as I’m unfamiliar with fluent. Are you willing on helping?

Well, I have not used fluent before. So everything in this project is new to me. But I am definitely willing to help.
With some effort, I manage to compile fluent's idl file with omniORB and load CORBA in python. When python connects with a fluent session, however, it runs into transient error that prevents it using basic methods like "getComponentName", etc. Here is the error:
TRANSIENT: CORBA.TRANSIENT(omniORB.TRANSIENT_ConnectFailed, CORBA.COMPLETED_NO)
Have you experienced this issue? Any pointers will be appreciated.
Thanks

Ah, so Fluent does use corba.  Good (sorta).
CORBA isn't the best interface, but it works and I think I can work around this issue.  This is one of a zillion projects, so I can't say how much time I can dedicate to this, but if you're able to create an initial interface, that's a positive sign.
As for your error, it sounds like it's simply unable to connect to the CORBA server.  Are you using my corba interface files?  See:
https://pypi.org/project/ansys-corba/
https://github.com/akaszynski/ansys_corba
You'll have to replace the idl file and modify some of the module files to get it to work for fluent, but this does mean you don't have to recompile and can (potentially) use the same corba interface I developed for MAPDL.

I started off from scratch by building omniORBpy for fluent.
You are right. It was a connection issue to fluent server. I restarted fluent session and now it works. We can now interactive with fluent in python.
Cheers

Awesome!
Can you see if you can use the existing ansys_corba interface?  If we could modify that, it would make it possible to pip install the interface.

The idl compiler generates the associated python stub for fluent, CoFluentUnit_idl.py, and init files in folders AAS_CORBA and AAS_CORBA__POA, which are different from those in ansys_corba for mapdl.
It seems that two separate python stubs are necessary. I don't know much about combining them. In the init files, it is emphasized not to be edited.

Post the idl files here and I'll see what I can do.  Thanks for your help thus far!

Here is the zipped file of the entire folder generated by the idl compiler. The settings are omniORB-4.2.3 and python 3.7. The idl file itself is from fluent v19.
Let me know if you need anything else.
corba.zip

Due to my extreme inexperience with this, can you please upload a minimum working example for this?  I'll be able to generate the corba interface, but I've only started up fluent a handful of times.  Could you please share a working example with or without python using fluent text commands?

Closing this.  Please consider providing me with a minimum working example to try to add fluent support to pyansy.

umm guys,
Was anyone able to make a MWE for this?
There is a youtube video by folks from ansys here incase anyone unfamiliar with fluent wants to take a look.

Thanks for the link!  I can build the corba interface files for fluent, but establishing the API layer is going to take some time since I have no experience with the API.

How is the state of pyansys for fluent? Any update?

It's in progress.  I can't announce anything official, but it's being actively worked on and if I were to guess, you'll see something first half of next year.


File SD fails to instrument itself for when an inotify watcher instance is unable to be created

What did you do?
In our environment, we make considerable use of file_sd (many hundreds of individual file_sd configurations, in some cases) for Prometheus installed in a virtual machine.
A recent change to our virtual machine operating system introduced a subtle change wherein our
fs.inotify.max_user_instances kernel parameter was lowered (to 128); this prevents fsnotify/fsnotify from setting up a new watcher.
When watcher instances fail to create, scrape configs are potentially not created or updated which is no good :)
Steps to reproduce:

Deploy Prometheus to a virtual machine (container is probably also possible, but I've not tested that way) with an artificially limited kernel fs.inotify.max_user_instances
Create or update file_sd files in excess of the artificially low fs.inotify.max_user_instances ceiling
Observe triggering of this code path in file.go

Alternatively:

Begin with an existing Prometheus using several file_sd and with --web.enable-lifecycle
Artificially limit fs.inotiry.max_user_instances e.g. sudo sysctl fs.inotify.max_user_instances=4
curl -XPOST localhost:9090/-/reload and observe the same file.go error path

What did you expect to see?
I would expect Prometheus to instrument itself via a metric in such a way that this condition could be alerted on.
There is logging which ultimately helped our team identify the failure condition, however this would have been much more intuitive to see first as a metric. For environments which have lossy (or disabled) logging, this would have been a nightmare of an issue to triage.
What did you see instead? Under which circumstances?
A metric to correspond to the exiting logging would have been great!
System information
Linux 5.4.0-72-generic x86_64
Prometheus version
I have tested this on two versions so far:

prometheus, version 2.28.1 (branch: HEAD, revision: b0944590a1c9a6b35dc5a696869f75f422b107a1)
  build user:       root@2915dd495090
  build date:       20210701-15:20:10
  go version:       go1.16.5
  platform:         linux/amd64

prometheus, version 2.37.0 (branch: HEAD, revision: b41e0750abf5cc18d8233161560731de05199330)
  build user:       root@0ebb6827e27f
  build date:       20220714-15:13:18
  go version:       go1.18.4
  platform:         linux/amd64

Prometheus configuration file
Adapted from the quickstart, and with small modifications to e.g. job names to simulate our real environment:

scrape_configs:
- job_name: job1
  honor_timestamps: true
  scrape_interval: 1m
  scrape_timeout: 30s
  metrics_path: /metrics
  scheme: http
  follow_redirects: true
  file_sd_configs:
  - files:
    - /opt/prom_configs/job1.json
    refresh_interval: 5m
- job_name: job2
  honor_timestamps: true
  scrape_interval: 1m
  scrape_timeout: 30s
  metrics_path: /metrics
  scheme: http
  follow_redirects: true
  file_sd_configs:
  - files:
    - /opt/prom_configs/job2.json
    refresh_interval: 5m
- job_name: job3
  honor_timestamps: true
  scrape_interval: 1m
  scrape_timeout: 30s
  metrics_path: /metrics
  scheme: http
  follow_redirects: true
  file_sd_configs:
  - files:
    - /opt/prom_configs/job3.json
    refresh_interval: 5m
- job_name: job4
  honor_timestamps: true
  scrape_interval: 1m
  scrape_timeout: 30s
  metrics_path: /metrics
  scheme: http
  follow_redirects: true
  file_sd_configs:
  - files:
    - /opt/prom_configs/job4.json
    refresh_interval: 5m

(each job is just configured to scrape Prometheus itself, for simplicity)

### Alertmanager version

_No response_

### Alertmanager configuration file

_No response_

### Logs

```text
ts=2022-07-27T21:51:22.537Z caller=file.go:239 level=error component="discovery manager scrape" discovery=file msg="Error adding file watcher" err="too many open files"
ts=2022-07-27T21:51:22.537Z caller=file.go:239 level=error component="discovery manager scrape" discovery=file msg="Error adding file watcher" err="too many open files"
ts=2022-07-27T21:51:22.538Z caller=file.go:239 level=error component="discovery manager scrape" discovery=file msg="Error adding file watcher" err="too many open files"
ts=2022-07-27T21:51:22.538Z caller=file.go:239 level=error component="discovery manager scrape" discovery=file msg="Error adding file watcher" err="too many open files"

FWIW: I have opened https://github.com/prometheus/prometheus/pull/11066 as a first pass of what a metric might look like. This would be my first contribution to Prometheus and I'm happy to make adjustments to this PR if it's a good idea (and assuming there's adjustments to be made 😉)

Thanks again for your contribution! And sorry for the wait.


Fix #5795 - Claim images not lazy loaded

PR Checklist
Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number: #5795
What is the current behavior?

What is the new behavior?
Claim images and channel thumbnails are queued as they enter the user's viewport (when about 25% of the image container is shown). This frees up network resources and makes the app feel quicker.
Other information
Before the change, 37 image requests and a total of 60, were initiated on this page when only 4 claims are visible in the viewport.

After the change, only 11 image requests are made and a total of 28 requests when those same 4 claims are visible. This is ~53% reduction in total requests.

Thanks for taking a stab at this and improving performance! We'll get a review on it soon.
Not sure if it directly addresses the issue with uneven claim tiles being loaded, but I think this code is in another repo this is private at this time.
Can we show you some appreciation?

Thanks for taking a stab at this and improving performance! We'll get a review on it soon.
Not sure if it directly address the linked issue as this code may be in another repo that's not public at this time.

This looks like a smart change, thank you. Did you investigate whether loading="lazy" would produce a similar result with less JS?

@kauffj I did investigate that approach first, but it wasn't fruitful. The same amount of images were loaded when using loading="lazy".

@lousando thanks for the PR! We are a little backed up at the moment so it might be a few days before I can review/test this.


Theme Cicada - missing last fix

@fichtner ... i´m so sorry, but i forgot one last color fix. would be great if you could merge this. the cicada users will be very happy. regards rené

@fichtner i´m so sorry, but i forgot one last color fix. would be great if you could merge this. the cicada users will be very happy. regards rené

No worries, merged! Thanks 😊


[Feature request] Add support for proxy settings in authorization flows

The SpotifyWebAPI class has support for ProxyConfig but the authorization classes (e.g AuthorizationCodeAuth) don't have support for it. It would be awesome if support for proxies could be added to them.

Hi,
All Auth flows should have a public ProxyConfig property now. Will be released in 4.2.0
Thanks for the issue! If you run into any problems or have further feature requests, please report :)

Awesome. Thanks!


[HELP]: How to remove public from URL

How can I remove public from URL.
I remove public from URL by using method mentioned in the following link
http://stackoverflow.com/a/32580688/5013099
Above method works for all my projects but when I apply this method to Laravl-Admin. Things do work as expected.
May be z-song/laravel-admin users can tell me how they do it?????

Supposing you are serving the root folder (where .env is) instead of public subfolder, you could add an /index.php file with this inside:
chdir(__DIR__.'/public');
require __DIR__.'/public/index.php';

You will need also to copy /public/.htaccess to / (where the new index.php file is located) and modify it
# Fix for running from app root and in a sub-folder
# Any change done in "public/.htaccess" should be adapted here

<IfModule mod_rewrite.c>
    <IfModule mod_negotiation.c>
        Options -MultiViews
    </IfModule>

    RewriteEngine On

    # IMPORTANT: Change this to the relative path to app root
    # using env var instead of RewriteBase instruction
    #RewriteBase /your-subfolder-here/
    RewriteRule .* - [E=REWRITEBASE:/your-subfolder-here/]

    RewriteCond %{ENV:REWRITEBASE}::%{REQUEST_URI} ^(.*)::\1(.*)$
    RewriteCond %{DOCUMENT_ROOT}%1public/%2 -f
    RewriteCond %{REQUEST_FILENAME} !index.php$
    RewriteRule ^(.*)$ public/$1 [L]

    # Fix JWT from the "Authorization" header removed by Apache
    RewriteCond %{HTTP:Authorization} ^(.*)
    RewriteRule .* - [e=HTTP_AUTHORIZATION:%1]

    # Handle special case for the "/" route
    RewriteRule ^$ %{ENV:REWRITEBASE}index.php [L,R=302]

    # Redirect Trailing Slashes...
    RewriteCond %{REQUEST_FILENAME} !-d
    RewriteRule ^(.*)/$ %{ENV:REWRITEBASE}$1 [L,R=302]

    # Handle Front Controller...
    RewriteRule ^(.*)$ index.php [L]
</IfModule>

Some things to consider...

.env file, source code and other sensitive file/folder should be protected (htaccess?)
you may have collisions with routes and subfolders (some may be handled by htaccess)
you must maintain htaccess

So it works, but not the way intended to be used
Other ways are:

symbolic link from your documentroot to /public folder ..you may need RewriteBase in the /public/.htaccess if it's a subfolder
move the public folder outside the laravel installation and modify the index.php to point to the laravel install ..again you may need RewriteBase in the .htaccess if it's a subfolder

At this moment I have an issue when using a virtual document root (deploying for testing on a remote server with whm userdir).
I discovered that the Admin facade used inside the package creates urls that can't work in that case:
https://github.com/z-song/laravel-admin/issues/992
So my deployed install works, but the admin portion does not work, urls are all relative starting with /


Vertical align Text

Hi,
I have a fixed header where I would to vertical align my title in the middle. I don't figure out how to do that easily. I've found this closed pull request (https://github.com/konvajs/konva/pull/354) but it does not help me...

Have you any hints?

// align inside this height
const HEIGHT = 100;
const textHeight = text.height();

text.y((HEIGHT - textHeight) / 2);

http://jsbin.com/tikehiwina/1/edit?js,output

@lavrton thank you for your quick answer. I would know if it was possible to vertical align the text without to add some state variable to be able to calculate the middle?

Currently, there is no way to do this. I have to do some calculations in your component methods and update state.
Probably one day Konva will support vertical-align.

@lavrton as I already know the header's height (this is a fixed size and position), I managed to write it in one line:
<Text
   text="title" fontSize={45} fill="#FFF" x={20} width={80} align="center"
   ref={node => { node && node.y(20 + (100 - node.getHeight()) / 2); }}
/>

Thank you again for the hints!


Bigtable: iam policy implementation for an instance.

Implemented iam policy for an instance.

@tseaver @AVaksman Addressed all review comments, please have a look.

@sduskis All suggested changes have been implemented, PTAL

@tseaver, can you please re-review the PR?  There were a few changes since you approved it.

I want to hold off merging this PR until I land #5875 and push out a 0.30.1 release with that fix.


SignalR working with React and .net core web app

I have created .Net core web app with react js in visual studio, then implemented the SignalR but I never see to get success for this network call even ws: true
"wss://localhost:44428/chatHub?id=iUhsRg40iclkdBHsoS1EmA"

const target = env.ASPNETCORE_HTTPS_PORT ? `https://localhost:${env.ASPNETCORE_HTTPS_PORT}` :
  env.ASPNETCORE_URLS ? env.ASPNETCORE_URLS.split(';')[0] : 'https://localhost:7143';

const context = [
  "/api/",
  "/listen/",
  "/chatHub/",
];

const onError = (err, req, resp, target) => {
  console.error(`${err.message}`);
}

module.exports = function (app) {
  const appProxy = createProxyMiddleware(context, {
    target: target,
    // Handle errors to prevent the proxy middleware from crashing when
    // the ASP NET Core webserver is unavailable
    onError: onError,
    secure: false,
    // Uncomment this line to add support for proxying websockets
    ws: true,
    headers: {
      Connection: 'Keep-Alive'
    }
  });

  app.use(appProxy);
};

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f5beb7f5-5d28-d5e5-92ba-3e04c75e44b5
Version Independent ID: 867e3a3f-2387-ba46-c911-10822f8c4a81
Content: Create an ASP.NET Core app with React - Visual Studio (Windows)
Content Source: docs/javascript/tutorial-asp-net-core-with-react.md
Product: visual-studio-windows
Technology: vs-javascript
GitHub Login: @Mikejo5000
Microsoft Alias: mikejo

@rishisolutionsbysms -- thank you for your feedback.  This repo is solely for documentation issues, and this is implementation-related.  Please consider these resources:

Ask a question or find an answer on the Microsoft Q&A page for Visual Studio.
Check the Visual Studio MSDN Forum.
Stack Overflow
Reddit

I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


Document basic resource registration (STAC metadata ingestion) with pypgstac

There is a basic mechanism to get data into eoAPI, using pypgstac.
In situations where no other, more convenient services exist (like the resource registration building block will provide, some workflow manager like Airflow or Argo), how would a user use this mechanism to get data into eoapi-k8s?
The same question was asked and to some degree answered here:

https://github.com/developmentseed/eoapi-k8s/discussions/73

But we need to document this publicly, for posterity.
Acceptance criteria

[ ] Added docs on how to do basic ingestion with out-of-the-box eoapi-k8s

https://github.com/developmentseed/eoapi-k8s/discussions/73#discussioncomment-11153748


Add Windows to your travis-ci

Hi @isaacs would you mind adding Windows to your CI?  Any reason you can think of that tap without a glob wouldn't work on Windows?  See https://github.com/istanbuljs/spawn-wrap/pull/82#issuecomment-491258325

There's no reason it wouldn't work on Windows, but it's possible that it's getting tripped up by slashes or some other thing.  I'm re-downloading a VM now, I'll take a look.
I've found that the travis windows support occasionally gets unresponsive or times out.

Turns out the regexp is testing against the filename, but not sensitive to \ style paths.


TABS Closed Alpha: export error

This game is made with 5.5.0x1-CollabPreview version of Unity (unsupported by ripper):
Import: System.Exception: Unsupported version type x for version '5.5.0x1-CollabPreview'
So i tried to rename version to 2017.3.0f3 in default resources file and file what i want to export.
But it's throws a error in all cases. What i'm doing wrong?
Help, please
(in this case, file is resources.assets)
(i translated some words in log which was on my main languane - rus)
Import: Game file 'resources.assets' has been found
Import: System.Collections.Generic.KeyNotFoundException: This key is not in the dictionary.
in System.ThrowHelper.ThrowKeyNotFoundException()
in System.Collections.Generic.Dictionary2.get_Item(TKey key)    in uTinyRipper.SerializedFiles.SerializedFile.ReadAssets(EndianReader reader, Int64 startPosition)    in uTinyRipper.SerializedFiles.SerializedFile.Read(Stream stream, Action1 dependencyCallback)
in uTinyRipper.SerializedFiles.SerializedFile.Load(Action1 dependencyCallback)    in uTinyRipper.SerializedFiles.SerializedFile.Load(Parameters pars)    in uTinyRipper.FileCollection.LoadSerializedFile(String filePath)    in uTinyRipper.GameStructure.Load(List1 pathes)
in uTinyRipper.GameStructure.Load(IEnumerable`1 pathes)
in uTinyRipperGUI.MainWindow.LoadFiles(Object data)

First of all if this game is made with 5.5.0x1-CollabPreview you need to change version for all files you trying to process to 5.5.0f1. However it doesn't guarantee that ripper will process those file correctly. This version string only help ripper understand how it should parse data because each version has its own data layout. And if 5.5.0x1-CollabPreview really differ from 5.5.0f1 then you need to manually adapt ripper for this specific version.

First of all if this game is made with 5.5.0x1-CollabPreview you need to change version for all files you trying to process to 5.5.0f1. However it doesn't guarantee that ripper will process those file correctly. This version string only help ripper understand how it should parse data because each version has its own data layout. And if 5.5.0x1-CollabPreview really differ from 5.5.0f1 then you need to manually adapt ripper for this specific version.

So, it throws new error:
Import: Game file 'resources.assets' has been found
Import: System.Exception: End of stream. Read 2, expected 8 bytes
in uTinyRipper.SerializedFiles.ObjectPtr.Read(SerializedFileReader reader)
in uTinyRipper.SerializedFiles.SerializedFileReader.ReadArrayT
in uTinyRipper.SerializedFiles.SerializedFileMetadata.Read(SerializedFileReader reader)
in uTinyRipper.SerializedFiles.SerializedFile.Read(Stream stream, Action1 dependencyCallback)    in uTinyRipper.SerializedFiles.SerializedFile.Load(Action1 dependencyCallback)
in uTinyRipper.SerializedFiles.SerializedFile.Load(Parameters pars)
in uTinyRipper.FileCollection.LoadSerializedFile(String filePath)
in uTinyRipper.GameStructure.Load(List1 pathes)    in uTinyRipper.GameStructure.Load(IEnumerable1 pathes)
in uTinyRipperGUI.MainWindow.LoadFiles(Object data)
Also, game won't launch now. Looks like versions have really big differents.

I think you changed version with bad text editor. Some of them add extra symbols after you insert/replace a text. So try Notepad++ on fresh (non modified) files.

I think you changed version with bad text editor. Some of them add extra symbols after you insert/replace a text. So try Notepad++ on fresh (non modified) files.

I was using Notepad++ all time.

Well, in this case 5.5.0x1-CollabPreview really has completely different layout.


Fullscreen terminal has transparent background

When in fullscreen mode, the Zed terminal switches to a transparent background, making it difficult to read terminal text:

Aside, I've been checking for a black Dracula theme since I started using Zed. Thank you!!

Thanks for the issue! I updated it, not 100% sure here but I think the next extensions update will have these as v0.1.1.

@JacobCoffee Been waiting for this to land in Zed. I looked around just now, and also not 100% sure but I think maybe you need to open a PR with this update to zed-industries/extensions? A la #67 on that repo.

Ahh yeah.. sorry about that ☹ I don't know why i expected it to just be magic 😅
https://github.com/zed-industries/extensions/pull/620

Hey @dylanjt  - should be available now


data function will run twice

Onto the next difference - "Child node 1" appears closed - that is because in the data we supplied true as the "children" property of this node (you can see it in the server response). This special value indicated to jstree, that it has to lazy load the "Child node 1" node.
data: function (node, cb) {
	if(node.id === "#") {
	    cb(data); // initial data here
	}
	else {
	    cb([]);
	}
}

but when i  set data with a function to use custom lazy loading,i use cb with initial data, data function will run twice at first load.
Initial data is only one node with children value is 'true'.

The function will be called as many times as needed to populate the tree - if you have opened nodes or the state plugin enabled it will be called as many times as there are open node (+ one more for the root node).
If this does not answer you question and you need further assistance please provide a demo of the problem (a jsfiddle perhaps).
Best regards,


quilt_rails generator should install react/typescript versions that are guaranteed to be compatible with our stack

Overview
https://github.com/Shopify/quilt/pull/1038 added unbounded typescript / react / react-dom / @types/react / @types/react-dom installation.
At some point, one of these dependencies will get out of sync with the others, and bootstrapping an app will fail again.  We should avoid that.
Type

[x] Changes to existing features

Motivation
Avoiding future breakages.

@michenly  seems related to what you're working on

The task was done. However, what actually shipped included much more including more in the generator and documentation update.


Passing combined reducer results in error / warning

Came around an issue, when passing a rootReducer which has been combined using combineReducer function from redux. Redux will raise a warning (or en error on react-native), stating that the key offline, which is added by the reducer enhancer function in updater.js is unexpected.
Well it's the intended behaviour of combinedReducer to warn if there is an unexpected key added. I'm just wondering how to get around this? I'm now using my own implementation of combineReducer to prevent the (in react-native very annoying) error.

Ouch @benlime, that's no good. Thanks for submitting this issue. I will do my best to get to it tonight.

@jevakallio As per my post here: https://github.com/jevakallio/redux-offline/issues/27, I think the error was generated due to a service worker not being defined in my development environment.
Once I deployed to production, which has a service worker defined in index,html, I no longer receive the Unexpected key "offline" message.
See in devTools here

Once I deployed to production

Wait, you're already using this in production? 🥇 🌮

Sorry, I meant staging.  ;-)

Ok, on further investigation an 'redux-persist; cannot process cyclical state' error (See attached image) is generated when submitting a a comment. See in devTools here
Refer to my initial issue #27 for corresponding code review.

@benlime this has now been fixed and released as v1.0.3. Apologies for the delay getting this fixed, and thanks for reporting!

@TheoMer the issue "cannot process cyclical state" is unrelated, and is likely caused by your action payload being somehow cyclical (non-vanilla javascript objects). I took a look at the code you posted in #27, the possible culprits are the posts/comments.
Because redux-persist needs to be able to serialize your state to JSON, you'll need to give it serializable objects.


publish jsr

currently jsr doesn't support npx like command.
If there is an update for it, I'll upload this package to jsr.
Related: https://github.com/jsr-io/jsr/issues/157

This package is using typia.
We need to  build before publishing, so close this issue


Add transpose

Test generator for the transpose exercise and example solution.

Super, Thanks :heart:
I'll have a look at this later today.

This looks good :heart:
:thinking: I wonder if there's some way of making the tests better show the transposed results.

Thanks @Insti, I've renamed the variable expect to expected
Could potentially use HEREDOC or string concatenation with \ to make the transposed results look better in the test file. WDYT?

Could potentially use HEREDOC or string concatenation with \ to make the transposed results look better in the test file. WDYT?

If you want to try it and see how it looks that would be good.
You could add other temporary files to the PR called test_cases_with_heredoc.rb or something, so we can compare the different versions. Then when we've decided which is best we can delete the redundant ones before merging.
Another thing we could do is add a comment to the test_cases.rb file asking people to submit an issue if they have an idea for a better way to display it.

Added files for a heredoc version for test generation. 😄

Ok, Thanks for doing that :heart:
The initial version is my preferred one.
I really don't like how the heredoc test cases end up looking.

@Insti You still prefer the first version, or did the heredocs change do it for you?

The indented heredocs are much nicer.
I think we should just use the heredoc version.

Thanks for all your work on this @gchan :heart:

No problem. Thanks for the feedback. I learnt a few things along the way


Disable image auto-links if they point to themselves

Follow-up of https://github.com/sindresorhus/refined-github/pull/4127#issuecomment-802730145
This would help distinguish useless auto-links from actual, custom links. (The locations of images would still by accessible from the right-click context menu.)
Two examples with auto-linked images (demo screenshots) and purposely-linked images (sponsor logos) :point_down:

https://github.com/sindresorhus/refined-github
https://github.com/chalk/chalk

Would also love to see this includes replacing camo.githubusercontent.com image links (not image src) on GitHub with image's [data-canonical-src] attribute.
Currently I've rolled a script for myself.

Not a good idea, GitHub does that to avoid tracking. https://stackoverflow.com/a/57862219
May be ok for a local script but not in RG

I've said above it's to change the link, not the image source. The image source can stay using camo.githubusercontent.com.

Though said above, I'd like to make it clear: jt's to change <a href> not <img src>. The latter can stay using camo.githubusercontent.com.
The point is that knowing where the original image come from can be handy and you don't want to hunt for it in Devtools every time.
I also changed my mind and agree what you said here, that this feature should only deal with links literally pointing to the same url as images. The change I'm proposing above are also included.

PR welcome, I think this feature is basically:
for img of select.all('a img')
	if img.src === a.href
		a.replaceWith(img)

Too many feature requests, realistically we’ll never get there. I’m closing those I think aren’t worth it.


Added support for Taxonomies and Terms

Added support to fetch taxonomies and terms

Resolving the conflicts now

Awesome @makkinga, actually had someone ask for this end of last week 😄
Will merge when the conflicts are resolved!

Nah.. starting over with a new fork

@aryehraber I see the processing of the data is rerouted a bit so ill make a new fork and merge/ test it local.
Fetching nav is comming next. Already built it but wanted to make a seperate PR for it

Yeah, there were some recent changes to that -- no breaking changes for users, but for devs it's a bit different.
Thanks for the work on this and Nav 👍


image/webp upload type

This changes able to upload images that has image webp encoding.

In addition to the inline comment I left, please either incorporate this entire PR in #5883 or separate the config/mimes.php changes in another pull request (you're making changes to it in both PRs - a recipe for merge conflicts).

Fixed compliance, fixed MIMEs


fixed CalDav on calendar mode

Description

CalDav was not showing any events in Calendar mode, Code has been re-worked for Calendar mode to be more efficient and also to show CalDav as expected along with Google Calendar
Related issues

fixes #392

Motivation and Context

Calendar mode doesn't show events for CalDav connections
How has this been tested

Tested on my dev instance
Types of changes

[ ] Docs change / refactoring.
[x] Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
[ ] Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes don't generate new warnings.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests pass.

I have the same problem with our ical custom_component.  Is there an issue with the calendar format?
I don't really see what this PR fixes, but it seems to be something realted to whether there is an event.start.dateTime or an event.start.date or something.
W can modify the ical integraton to match what google does if that has changed lately.

I have the same problem with our ical custom_component.  Is there an issue with the calendar format?
I don't really see what this PR fixes, but it seems to be something realted to whether there is an event.start.dateTime or an event.start.date or something.
W can modify the ical integraton to match what google does if that has changed lately.

Hey @Olen,
Home Assistant handles both Google and CalDav differently which is a real pain, the dates are stored in different locations and as you have shown above.
I have had to add checks to see how the date is presented which will then decide how to set the date.

Hey @Olen,
Home Assistant handles both Google and CalDav differently which is a real pain, the dates are stored in different locations and as you have shown above.
I have had to add checks to see how the date is presented which will then decide how to set the date.

Hi, and thanks.  We based the ical-calendar on the caldav-integration, and it used to work in atomic-revive until some update a little hile ago.  But I can change the ical integration to whatever you think is best. Just need to know how you would prefer it.
        self._event["start"]["dateTime"] = event["start"].isoformat()
        self._event["end"]["dateTime"] = event["end"].isoformat()
        self._offset_reached = is_offset_reached(self.event)
        self._event["all_day"] = event["all_day"]

Are there any other attributes we should use to match either google or caldav?
It works fine in event mode, but not in calendar mode...

Hi, and thanks.  We based the ical-calendar on the caldav-integration, and it used to work in atomic-revive until some update a little hile ago.  But I can change the ical integration to whatever you think is best. Just need to know how you would prefer it.
        self._event["start"]["dateTime"] = event["start"].isoformat()
        self._event["end"]["dateTime"] = event["end"].isoformat()
        self._offset_reached = is_offset_reached(self.event)
        self._event["all_day"] = event["all_day"]

Are there any other attributes we should use to match either google or caldav?
It works fine in event mode, but not in calendar mode...

so google calendar will use start.date for full day or start.datetime for a normal event, which would make it easier if both the same

so google calendar will use start.date for full day or start.datetime for a normal event, which would make it easier if both the same

Sorry I keep on posting in the closed PR, I am just uncertain if I should open another issue request here, or if I should fix the ical implemetation...
I must admit the code in "getCalendarEvents" is currently beyond my comprehension...
I added some debugging to the card, and the events from ical calendars came up as the atached image.
I can see that the format in "f" and "i" does not match, as the date ical provides adds the UTC-offset (+0100), but I don't know if that is the root cause?

Sorry I keep on posting in the closed PR, I am just uncertain if I should open another issue request here, or if I should fix the ical implemetation...
I must admit the code in "getCalendarEvents" is currently beyond my comprehension...
I added some debugging to the card, and the events from ical calendars came up as the atached image.
I can see that the format in "f" and "i" does not match, as the date ical provides adds the UTC-offset (+0100), but I don't know if that is the root cause?

Now, this is weird!
When I added a single line with "console.log" to get the debug output above, the events from ical is starting to show up...
(Well, what I did was to use an online de-minifier on the provided atomic-calendar-revive.js from hacs.  The add a debug line, and replace the file in the /www/community/atomic-calendar-revive folder.  And do a full reload and refresh...
It could have been a caching problem or something.

Now, this is weird!
When I added a single line with "console.log" to get the debug output above, the events from ical is starting to show up...
(Well, what I did was to use an online de-minifier on the provided atomic-calendar-revive.js from hacs.  The add a debug line, and replace the file in the /www/community/atomic-calendar-revive folder.  And do a full reload and refresh...
It could have been a caching problem or something.

Quite possibly, if this is still an issue please open a new issue to properly discuss.
I think that if you have issues with your sensor and it matches the same format as caldav then it should work without issue, if it is having issues I'm more than happy to look but would obviously need to setup the sensor which I don't currently use.

Quite possibly, if this is still an issue please open a new issue to properly discuss.
I think that if you have issues with your sensor and it matches the same format as caldav then it should work without issue, if it is having issues I'm more than happy to look but would obviously need to setup the sensor which I don't currently use.

I really think the calendar format should be explicitly defined so all implementations can do it the same way.
But thank you for your patience.

I really think the calendar format should be explicitly defined so all implementations can do it the same way.
But thank you for your patience.

I totally agree, it's a bit of a bad choice on HAs implementation there. I guess a feature change request they may implement it.

I totally agree, it's a bit of a bad choice on HAs implementation there. I guess a feature change request they may implement it.


[release-2.6] Added sonar project properties file to repo

Related issue: https://github.com/stolostron/backlog/issues/24272
Signed-off-by: dislbenn<EMAIL_ADDRESS>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/hold

/lgtm

/unhold


Links inside rendered dataview blocks not clickable

For example,
```dataview
LIST FROM [[Some Note]]
\```

Generates a list of links, but the links are not clickable inside the repeat view. Should check if this is fixable.

This is what the elements look like. First one from within the dataview-rendered block, the second a working processed vanilla link

My Note

    My Note

The issue is happening because just calling MarkdownPreviewView.renderMarkdown doesn't handle dynamic dataview blocks, so the plugin's renderMarkdown function doesn't have anything to fix links for.
MarkdownPreviewView.renderMarkdown is deprecated. Maybe its successor doesn't have this issue.

https://docs.obsidian.md/Reference/TypeScript+API/MarkdownRenderer/renderMarkdown replaced by https://docs.obsidian.md/Reference/TypeScript+API/MarkdownRenderer/render

I switched the API, now dataview-rendered items do not show up at all (the element is

), which is a different issue.


How to index RAW data from Windows machine to Elastic search using Fluentd

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.
Describe the bug
I am trying to index Windows RAW data from D-drive to elasticsearch using fluentd. Once i start the Fleutd service none of the logs are indexing. I am new to EFK, could someone guide me how to index plain test files from windows to Elasticsearch.
To Reproduce
Created a RAW data file and created config file with "none" parse option as below and after start td-agent service in windows i could find any logs in Kibana
Expected behavior
Expect RAW data as present in log file to be index in Kibana without any parses or any formats
Your Environment
Windows 2012 server and it is DEv machine

Fluentd or td-agent version: fluentd 1.7.4
Operating system: Windows 2012
Kernel version: uname -r

If you hit the problem with older fluentd version, try latest version first.
Your Configuration
##INPUT 1

  @type tail
  path D:/testlogs/testfile.txt
  pos_file C:/opt/td-agent/testfile.pos
  tag server.testfile.log
  read_from_head true
  @log_level error

  @type none

<label @fluent_log>
<match @fluent.*>
@type null

##output config path
<match server.**>
@type forward
@type elasticsearch
host elasticsearch-hostname
port 9200
logstash_format false
include_timestamp true
index_name nonprod_server
fluentd flush_thread_count 30s

Your Error Log
Logs are fine and couldn't find logs are indexing in kibana
Additional context

Follow the guideline. Here is not forum but issue tracker. Thanks!


Release Rust crates only if they are marked as publish

Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Is your feature request related to a problem? Please describe.
In a workspace with several crates, some crates may be for testing purposes and shouldn't be released. Currently, all crates in the workspace are released by default when using the manifest and manifest-pr commands, even if they don't need to be. This is what the publish field in the Cargo.toml is for, but the current codebase doesn't take it into account.
Describe the solution you'd like
If the Cargo.toml for a crate in a workspace has publish = false, the crate should not be considered for release (i.e. Release Please should not touch its manifest or include it in the GitHub release).
Describe alternatives you've considered
There may be some ways to add additional configuration if this isn't always desired behavior.
Additional context
N/A

some crates with publish = false should still be released, as in the version gets increased and a release on github is made. publish = false just signifies that the crate should not be published in a crate registry.


Fix for missing content-length header when using QUIC

If request.ContentLength is set then it will be used instead of getting it from request.Header map since quic-go(lucas-clemente/quic-go@bb24be8) will not store (and pass) the Content-Length header using its header map.

Thanks @ssut - did you verify that this fixes an issue? Is the issue documented?

@mholt I'm pretty sure this fixes the exact issue such like #1370, in this case https://github.com/mholt/caddy/issues/1483#issuecomment-283955017.

@ssut By "pretty sure" do you mean it doesn't work before your change, but does work after? If you're sure that's the case, then I'm okay with merging this.

@mholt Yes indeed.

Great, thank you @ssut!


@__FILE__ doesn't report current file in weaving context

when loading data it's often convenient to use @__FILE__ to reference files relative to the current file. During weaving that macro seems to evaluate to "none" though.

Additionally @__DIR__ is the current working directory path instead of the directory the file is located in.

Just for the record -- we'll need to wrap everything Weave evaluates in something like CodeTools.withpath.

Weave uses Core.eval in a SandBox module to evaluate expressions from the various formats after converting them into chunks.
https://github.com/JunoLab/Weave.jl/blob/72e7ccfe8ac68c7dfc1ecd0c77b93de81cd5f3c0/src/run.jl#L235
We wouldn't be able to use CodeTools.withpath for this, right?

my hunch is adding something like this on eval_chunk will solve the problems.
I set this issue as a milestone for v0.11.

Yeah. Can also use something like https://github.com/JuliaDocs/DocumentationGenerator.jl/blob/d3c3ce4aa1dc9e3c813ac26d81023dda9d3dfc62/src/utils/rewrite.jl#L109-L117 if you don't want the dep on MacroTools.


Update wavewatch3 use case

This pull request includes edits to keep make the contents have the same format as the other use cases for paper publication.

refine the text in the notebook
remove the results in the notebook
add information in the readme file
add License file
add results folder

@bundzis I made some edits for the use case. Please look at them and merge this pull request if it looks good to you. Let me know if you have any questions. Thank you!


Feature: Custom RAFDrivers

This PR allows you to control when computations in Theatre tick forward.
We call this mechanism a rafDriver (raf stands for requestAnimationFrame).
The default rafDriver in Theatre creates a raf loop and ticks forward on each frame. With this PR, you can create your own rafDriver, which enables the following use-cases:

When using Theatre.js alongside other animation libs (@react-three/fiber/gsap/lenis/etc), you'd want all animation libs to use a single raf loop to keep the libraries in sync and also to get better performance.
In XR sessions, you'd want Theatre to tick forward using xr.requestAnimationFrame().
In some advanced cases, you'd just want to manually tick forward (many ticks per frame, or skipping many frames, etc). This is useful for recording an animation, rendering to a file, testing an animation, running benchmarks, etc.

This PR resolves #39, replaces #230, and #88.
Here is how you'd create a custom rafDriver:
import {createRafDriver} from '@theatre/core'

const rafDriver = createRafDriver({name: 'a custom 5fps raf driver'})

setInterval(() => {
  rafDriver.tick(performance.now())
}, 200)

Now, any time you set up an onChange() listener, pass your custom rafDriver:
import {onChange} from '@theatre/core'

onChange(
  // let's say object is a Theatre object, the one returned from calling `sheet.object()`
  object.props,
  // this callback will now only be called at 5fps (and won't be called if there are no new values)
  // even if `sequence.play()` updates `object.props` at 60fps, this listener is called a maximum of 5fps
  (propValues) => {console.log(propValues)},
  rafDriver
)

// this will update the values of `object.props` at 60fps, but the listener above will still get called a maximum of 5fps
sheet.sequence.play()

// we can also customize at what resolution the sequence's playhead moves forward
sheet.sequence.play({rafDriver}) // the playhead will move forward at 5fps

You can optionally make studio use this rafDriver. This means the parts of the studio that tick based on raf, will now tick at 5fps. This is only useful if you're doing something crazy like running the studio (and not the core) in an XR frame.
studio.initialize({
  __experimental_rafDriver: rafDriver,
})

rafDrivers can optionally provide a start/stop callback. Theatre will call start() when it actually has computations scheduled, and will call stop if there is nothing to update after a few ticks:
import {createRafDriver} from '@theatre/core'
import type {IRafDriver} from '@theare/core'

function createBasicRafDriver(): IRafDriver {
  let rafId: number | null = null
  const start = (): void => {
    if (typeof window !== 'undefined') {
      const onAnimationFrame = (t: number) => {
        driver.tick(t)
        rafId = window.requestAnimationFrame(onAnimationFrame)
      }
      rafId = window.requestAnimationFrame(onAnimationFrame)
    } else {
      driver.tick(0)
      setTimeout(() => driver.tick(1), 0)
    }
  }

  const stop = (): void => {
    if (typeof window !== 'undefined') {
      if (rafId !== null) {
        window.cancelAnimationFrame(rafId)
      }
    } else {
      // nothing to do in SSR
    }
  }

  const driver = createRafDriver({name: 'DefaultCoreRafDriver', start, stop})

  return driver
}

A couple of design decisions:

You can have several rafDriver-s on the same page, or even listening to the changes in values of the same object.

onChange(object.props, listener, aFiveFPSDriver)
onChange(object.props, listener, a60FPSDriver)

I debated whether to allow setting a default rafDriver for a whole project or all of @theatre/core. That's certainly possible, and it would make the API less verbose. However, it also makes the API more ambiguous (like which driver takes precedence when there are several?) and more tricky (you'd have to call the hypothetical core.setDefaultRafDriver() before any computation is done).

We're not exposing Ticker because a Ticker has responsibilities beyond just scheduling, such as keeping a list of stale computations and (in the future) prioritizing them.

What do you think @felthy and @donmccurdy? Does this address all of the requirements you mentioned?
A build of this PR is on npm on version 0.6.0-insiders.954391e.

Thank you for pursuing this @AriaMinaei! This API looks like it will meet our needs for all of our use cases.
I tested this today, and it works nicely when I want to manually advance the playhead and flush changes, by setting sequence.position then calling tick() on my driver.
However if I use sequence.play(), the internal coreTicker is being relied upon to advance the playhead.

There is no public API to allow me to use another driver, like XRSession, for this.
If there was, all of my sheets would be driven by the same driver. I need to isolate each driver to its sheet, such that calling tick() on one driver is guaranteed not to affect any other sheets.
Even if it will do so by default for convenience, I should be able to prevent Theatre from ever calling requestAnimationFrame() internally.

From what I can tell, the only things using the coreTicker are the PlaybackController implementations. I notice they only use the ticker from inside their play() and playDynamicRange() methods, so it seems we could:

remove the ticker constructor param (and private property) from the PlaybackController implementations
have the public sequence.play() and sequence.playDynamicRange() methods accept an optional rafDriver, and pass it through to the PlaybackController methods

Then if I always provide my custom rafDriver when calling play(), a coreTicker will never be created and I'll have no need to explicitly disable it.
What do you think?

Thanks for testing this out, @felthy! I'll make sequence.play() take an optional driver param.
Beside that, I'm curious, why would you want to "prevent Theatre from ever calling requestAnimationFrame() internally"?

@felthy okay, with this last commit, calling sequence.play({rafDriver}) is now possible. But the core requestAnimationFrame() driver will keep ticking as well, even if its Ticker's queue is empty. I'll do that next.

Alright, a24a77c implements active/dormant tickers. This means that if every onChange() and sequence.play() call uses a custom rafDriver, then the default driver that calls requeseAnimationFrame() won't even start.

Can we add rafDriver to a onValuesChange callback ?


Errors in S3 custom generated code

Describe the bug
As reported by @brycahta :

The get{{$memberRefName}}Action func takes no action when the inputs have differences
API calls are being recorded as UPDATE. Ex: rm.metrics.RecordAPICall("UPDATE", "DeleteBucket{{ $memberRefName }}", err)
In sync{{ $specFieldName }} , if a config is found to be in latest but not in desired then it deletes the desired config

In sync{{ $specFieldName }} , if a config is found to be in latest but not in desired then it deletes the desired config

I believe this isn't a bug. The code in this scenario calls rm.delete{{ $memberRefName }}(ctx, desired, *l) (see https://github.com/aws-controllers-k8s/s3-controller/blob/main/templates/hooks/bucket/sdk_file_end.go.tpl#L230). The delete method requires a resource and a svcapitypes.{{ $memberRefName }}, and constructs a DeleteBucket{{ $specFieldName }}Payload using those values. The only values it takes from the resource is the Spec.Name, the rest of the delete payload consumes fields from the svcapitypes value. Therefore, passing desired as the resource is fine, since we wouldn't expect the bucket name to change. As long as we pass l (the iterator in latest), it should delete the correctly identified configuration element.
As for the others, PR on the way.


Model for affected code citations

A number of jurisdictions offer citations to the sections of the legal/administrative codes that bills will potentially change, or have changed. It would be nice to track this data.
We're currently storing these in a few states in "extras", but it's kind of a sloppy abstraction because extras takes a string not a list, and because of the variety of citation formats, there's not a great separator for multiple entries.
I propose something like this (the method names need some work):
bill.add_proposed_citation(
  string Citation,
  datetimeoptional Adopted_date = null,
  datetimeoptional Effective_date = null,
)

bill.add_citation(
  string Citation,
  datetimeoptional Adopted_date = null,
  datetimeoptional Effective_date = null,
)

Some sample bills that have been codified:

CA
MN
WY

In these examples, in WY it would be something simpler,
bill.add_citation("CH0017", <datetime>, <datetime>)

whereas in CA it would be:
bill.add_citation("Cal. Fin. Code Ch 708 § 22202", <datetime>)
bill.add_citation("Cal. Fin. Code Ch 708 § 22250", <datetime>)
etc

Proposed citations would be similar, just for cases when it's clearly stated what the bill will modify, but it hasn't been passed yet.
Thoughts on this? I'd be willing to do the PR once new state legislative sessions cool down a bit, I just don't want to get too far down that path if it's out of scope or doesn't mesh well with other levels (municipal, etc)

I'm all for this.  I was initially confused by the use of a separate method
for proposed citations but I think I get it, we'll need to figure out how
to document that well.
Also, I'm curious where these usually appear, I've seen them in actions and
bill text.  I'm wondering how we'll want to handle actually adding them but
I think that getting them added to the model makes sense.
On Tue, Jan 7, 2020, 1:39 PM showerst<EMAIL_ADDRESS>wrote:

A number of jurisdictions offer citations to the sections of the
legal/administrative codes that bills will potentially change, or have
changed. It would be nice to track this data.
We're currently storing these in a few states in "extras", but it's kind
of a sloppy abstraction because extras takes a string not a list, and
because of the variety of citation formats, there's not a great separator
for multiple entries.
I propose something like this (the method names need some work):
bill.add_proposed_citation(
string Citation,
datetimeoptional Adopted_date = null,
datetimeoptional Effective_date = null,
)
bill.add_citation(
string Citation,
datetimeoptional Adopted_date = null,
datetimeoptional Effective_date = null,
)
Some sample bills that have been codified:

CA
http://leginfo.legislature.ca.gov/faces/billHistoryClient.xhtml?bill_id=201920200AB539
MN
https://www.revisor.mn.gov/bills/bill.php?b=Senate&f=HF12&ssn=1&y=2019
WY https://www.wyoleg.gov/Legislation/2019/HB0011

In these examples, in WY it would be something simpler,
bill.add_citation("CH0017", , )
whereas in CA it would be:
bill.add_citation("Cal. Fin. Code Ch 708 § 22202", )
bill.add_citation("Cal. Fin. Code Ch 708 § 22250", )
etc
Proposed citations would be similar, just for cases when it's clearly
stated what the bill will modify, but it hasn't been passed yet.
Thoughts on this? I'd be willing to do the PR once new state legislative
sessions cool down a bit, I just don't want to get too far down that path
if it's out of scope or doesn't mesh well with other levels (municipal, etc)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/opencivicdata/python-opencivicdata/issues/132?email_source=notifications&email_token=AAAB6YRFR6ZK4RXRFK3DDZDQ4TD55A5CNFSM4KD5L6MKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IESB6QQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAB6YTLFIH6V4MKTO7RQBDQ4TD55ANCNFSM4KD5L6MA
.

RE: proposed vs final yeah this could use better naming. I've noticed that proposed doesn't match final 100% of the time (usually because of sections of a bill getting struck between versions), but it seems like for a certain subset of users "I want to look up anything in play that might change the CA financial code" would be valuable in addition to "What sections of the code did this effect after it passed?".
RE:Actual collection -- Final citations seem to pretty much always be in actions, usually something like "Chaptered. SD Code Title 3 Ch. 4" or something, OR as a separate field on the site like in WY.
Proposed seems to be all over, but they're often in either titles or summaries (like that CA example).
They're (always?) in text too but just eyeballing it extracting those looks like a gnarly workload, so maybe we just go for low hanging fruit.
https://github.com/statedecoded/law-identifier has a bunch of nice example formats of standard citation formats.
From having done this in unrelated work in the past I know it can get crazy ("sections 6-34 of title nine, excepting 11,14, and 15.5-.9") but even if we started by just grabbing for a few big states it would be worth the data model work. It might benefit the local scraper folks too, since municipal code cites tend to be cleaner.


App is not considering hemisphere of base climate!

At the moment all glaciers are assumed to be in the northern hemisphere (starting the hydrological year in October) and so the climate of glaciers in the southern hemisphere is shifted 6 months (instead of starting with the hydrological year in April also starting in October).

maybe the simplest would be to avoid hydrological years altogether? Its a bit tricky because the hydro year makes a lot of sense in  many regions

let;s discuss this afternoon


adding JHK filters

Coverage remained the same at 97.913% when pulling 588ee2ead6235ef42d9e0577f86768917b8fdb5f on mnicholl:master into 6d02d47e7a38b0366b0a70b49d2860575cf1f990 on guillochon:master.


KAFKA-16275: Update kraft_upgrade_test.py to support KIP-848’s group protocol config

Added a new optional group_protocol parameter to the test methods, then passed that down to the methods involved.
New new consumer only works with 3.7+, so I added a new @matrix block with those parameters.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@lucasbru—here's another system test to review. Thanks!


HFP AG unable to open SCO data path. (IDFGH-4690)

Environment

Development Kit:      none
Kit version:          does not apply
Module or chip used:  ESP32-WROOM-32D
IDF version          v4.2-rc with patch from #6218
Build System:         idf.py
Compiler version:     8.4.0
Operating System:     Windows
Environment type:     PowerShell
Using an IDE?:        No (only PowerShell with ESP-IDF scripts)
Power Supply:         USB

Problem Description
My project is based on HFP-AG example from the ESP-IDF. After applying the patch from #6218 on ESP-IDF v4.2-rc I have a problem with opening SCO data path after connect_audio() request. I checked if the problem exists in HFP AG example and it does. I use HCI as a SCO data path, turned off WBS and I changed the BR/EDR Sync(SCO/eSCO) Max Connections to 1.
Expected Behavior
Audio data being seemlessly transferred to the HFP Client device.
Actual Behavior
I open and close audio several times. After some time the example can't open the SCO data path and audio closes just after opening. See debug logs below.
Steps to reproduce

Pull the ESP-IDF from the repo in rev 4.2-rc.
Apply the patch from #6218.
Enter idf.py menuconfig and:

In Component config > Bluetooth > Bluetooth controller:

Set BR/EDR Sync (SCO/eSCO) Max Connections to 1,
Set BR/EDR Sync (SCO/eSCO) default data path to HCI,

In Component config > Bluetooth > Bluedroid Options:

Set Hands Free/Handset Profile audio(SCO) data path to HCI,
Disable Wide Band Speech

Save the changes and exit menuconfig.

In app_hf_msg_set.c uncomment line 16 and provide the Bluetooth address of the device you want to connect with.
Build the firmware and flash the ESP32.
Connect to your headset using hf con; command in UART interface.
Connect and disconnect audio using hf cona and hf disa. After some time the issue should take place.

Code to reproduce this issue
Just original HFP-AG example with changes in menuconfig described above
Debug Logs
[0;31mE (305965) CNSL: Command [hf cona;][0m
Connect Audio
[0;33mW (305965) BT_BTM: BTM Remote does not support 2-EDR eSCO[0m
[0;33mW (305965) BT_BTM: BTM Remote does not support 3-EDR eSCO[0m
[0;32mI (305965) BT_APP_HF: APP HFP event: AUDIO_STATE_EVT[0m
[0;31mE (305975) BT_BTM: btm_sco_connected, handle 80[0m
[0;33mW (305975) BT_BTM: BTM Remote does not support 2-EDR eSCO[0m
[0;33mW (305985) BT_BTM: BTM Remote does not support 3-EDR eSCO[0m
[0;32mI (305995) BT_APP_HF: --Audio State connecting[0m
[0;31mE (305995) BT_BTM: btm_sco_connected, handle 80[0m
[0;32mI (306005) BT_APP_HF: APP HFP event: AUDIO_STATE_EVT[0m
[0;32mI (306005) BT_APP_HF: --Audio State disconnected[0m
[0;32mI (306015) BT_APP_HF: --ESP AG Audio Connection Disconnected.[0m

Before this happened the handle of the connection was 180 or 181. Can you tell me what it means?
Regards, Piotr

Hi @Alvin1Zhang, @Wth-Esp, @munho-espressif.
It's been a week since I posed this issue. Is there something going on with it. Has someone been assigned to it?
Regards,
Piotr

Hi @ypiotrp
The issue is assigned to @munho-espressif and he has been looking into it before the Chinese Spring Festival. He has found something suspicious but not very sure about the root cause. We have back to work now and I think he will share the findings ASAP.
Thanks

Hi @ypiotrp
Please try this
hfp_ag.zip
on v4.2-rc.
Thanks

Hi @ypiotrp
I facing the same issue you report
the patch didn't work for me, is there any change you made?
Thanks

Hi @chwwu,
this patch actually seems to be working well and solves my problem. The changes I made to 4.2-rc were more or less the two patches - one from another of my issues #6218 and second form the above post.
What is the problem you faced? Show me some logs and I will try to help you.
Regards

Hi @ypiotrp
The use case is the ESP32 acts as Audio gateway and can receive/sent audio data (pcm?) to handsfree devices
but hf cona; will lead core dump
This is my post issue
Best Regards


Refactor to make working with auto generated code easier

See this for the current structure
We want to do the following:
1. Automatically retrieve swagger.json
2. Preprocess the JSON
3. Generate code from that JSON
4. Only take the code we need from the JSON and have it nicely added to existing code.
5. Delete the rest of the auto generated code
2.4 isn't possible with current file structure (see 1). To do that, we will need to have some kind of separation between the auto generated code and manual code: we need to separate them into two files. When we run the automation in 2, we just override the auto generated code.

Note: for 3, there are two ways to do it:

By composition (original plan): generated Retrofit interface stays in a file; manual Retrofit interface (nextLink, forEach) stays in another file. The wrapper client will have both.
By inheritance (thanks to @jason-chan-lf ): generated Retrofit interface stays in a file; manual Retrofit interface (nextLink, forEach) stays in another file and extends the generated interface. The wrapper client will only have manual Retrofit interface.

1 is clearly doable. But 2 saves us one HttpClient instance so it costs less memory at run time. But we need to try if 2 works. The reason is, Retrofit interfaces are special. I don't know if it supports inheritance (it's really up to Retrofit, even though it's possible at language level).


Always install new pip on Appveyor

Builds currently failing, rgommers suggested this might be the issue.
This simply doesn't check for existing pip and always installs a new one.
Merging immediately to get tests working. Passes on my branch

The tests do pass, but I merged the PR before they finished running which cancelled them and shows up as failed (and I cannot force appveyor to rebuild a closed PR).

thanks, good to get this solved


Mouse position not working if body scrolled

Hi, what change can I make to make it work even if the menu is in a position in the body that you have to scroll to reach it? Thanks!

Do you have some working code I can look at? Have you tried to solve it? Thanks.

Hi, thanks for your answer.
Here's an example: https://www.vancode.it/playground/
I took the dist folder and just commented the inizialization of locomotive-scroll in the js. You can see now that everything is working if you don't scroll, but as soon as you scroll, the images are not displayed in the right position.
Any suggestions?

Thanks for the demo! I've changed the mouse position function in utils.js. It should work now.
Thanks!


(Peter) Find a good data source for star positions and magnitude

Find data for stars that have fixed positions relative to the Earth. This data does not need to be looked up each time so it can be stored as part of the application.

I found a dataset from the HYG-Database (https://github.com/astronexus/HYG-Database) and reduced it down to only the stars with proper names (about 150) and the variables that I thought would be most relevant. See stardata.csv (https://github.com/humboldt-cs/cs480-star-finder/blob/master/stardata.csv)


Replace week_start integer with an enum

It's unknown what the number is, for example, what is 0?
It's better to replace it with an enum, with weekdays.
For example:
WeekDay::Sat
...

chrono package already has this, we need to use it and re-export the enum in the SDK:
https://docs.rs/chrono/0.4.19/chrono/enum.Weekday.html

Same as the rrule crate: https://docs.rs/rrule/0.5.9/rrule/enum.Weekday.html
I dont remember the reason on top of my head why I chose to model the week start with a number, but I guess there is no good reason.
Another semi related thing is the recurrence attribute on CalendarEvent which should ideally be modelled as an rrule string which is well defined instead of a custom Recurrence struct. Google Calendar does this, but Outlook Calendar does not.


Bootswatch/Bootstrap 5

Hello all, I don't know if this is the place for this but I've been working on upgrading Bootswatch and Bootstrap to 5.2.3, I believe I have something usable, I'd like to get your opinion. The repo is https://github.com/mariofix/flask-admin
The example here https://github.com/mariofix/flask-admin/tree/bootstrap5/examples/bootstrap5
All comments are welcome

I'm interested - I think you should make a pull request.

Thank you, but it still has a few bugs to sort out, but I'm planning to make the PR soon.

Hello Mario, is it done?

I'll try to make it a module, but it doesn't go well with the way I like to manage dependencies. If anyone is interested in helping with this, I'd be very appreciative, because from what I see, it's been 5 months since the last merge.
The default bootstrap is BS3 and BS4 has many bugs.

I'll try to make it a module, but it doesn't go well with the way I like to manage dependencies. If anyone is interested in helping with this, I'd be very appreciative, because from what I see, it's been 5 months since the last merge. The default bootstrap is BS3 and BS4 has many bugs.

Is there any news? I'd like to help if I can.
I have mentioned two projects at https://github.com/flask-admin/flask-admin/issues/2163#issuecomment-2051320288.
And I just saw that you have contributed to one of them, I think it won't be so hard to build a package.


Add lint declarative_macro_missing

Working to implement the first item in #946: "removing a declarative macro that used to exist".
There's this case as well, but I'm not sure if it can be currently queried for:
#[macro_export]
macro_rules! inner_pub_use_will_be_removed {
    () => {};
}

pub mod inner {
    // Is it a breaking change if you remove the next line?
    pub use crate::inner_pub_use_will_be_removed;
}

Not sure how to address the beta failure...
The referenced type does not exist in the schema: Macro

It might need a cargo update to pick up the latest schema.
On Sun, Oct 13, 2024, 9:03 AM Miikka Koskinen @.***>
wrote:

Not sure how to address the beta failure...
The referenced type does not exist in the schema: Macro
—
Reply to this email directly, view it on GitHub
https://github.com/obi1kenobi/cargo-semver-checks/pull/966#issuecomment-2408853812,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR5MSTXYPY4FW77VUXYJW3Z3ILMZAVCNFSM6AAAAABPWUUBI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHA2TGOBRGI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I tried cargo update and it didn't help. I assume the point would be to update the versions of trustfall-rustdoc-adapter? It didn't touch the versions of any of those.

Hmm interesting, I might have messed something up then. I'll take a look
when I get back home later this week, sorry about that.
On Sun, Oct 13, 2024, 10:18 AM Miikka Koskinen @.***>
wrote:

I tried cargo update and it didn't help. I assume the point would be to
update the versions of trustfall-rustdoc-adapter? It didn't touch the
versions of any of those.
—
Reply to this email directly, view it on GitHub
https://github.com/obi1kenobi/cargo-semver-checks/pull/966#issuecomment-2408878651,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR5MSQAXNS7RGUUQBBFZB3Z3IUELAVCNFSM6AAAAABPWUUBI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBYHA3TQNRVGE
.
You are receiving this because you commented.Message ID:
@.***>

My bad, I got everything ready then just failed to cut the release 🙈 I'll have a new release up momentarily, and I'll take care of updating your PR to merge it to so I can atone for sending you down a debugging rabbit hole unnecessarily...
Excellent catch on re-exporting macros as well! To my surprise, re-exporting does seem to work: playground
#[macro_export]
macro_rules! inner_pub_use_will_be_removed {
    () => {};
}

pub mod inner {
    /// We can re-export macros at non-root paths, watch:
    /// ` ``rust
    /// use playground::inner::inner_pub_use_will_be_removed;
    ///
    /// inner_pub_use_will_be_removed! {}
    /// ` ``
    pub use crate::inner_pub_use_will_be_removed;
}

I've opened #968 to track this issue, which you are also welcome to grab if you're interested!


Changes to build scripts

Invert the skipdocs default parameter, so doc generation is always skipped
Remove the IL rewriting for 7.x

IL rewriting shouldn't be removed for 7.x, but it should only be run on CI to generate version specific packages


Ignore errors for disabling services that are not present

The error while disabling services are because of difference between the service module in Ansible 1.9.4 vs Ansible 2.0.2


Python Requirements Update

Python requirements update. Please review the changelogs for the upgraded packages.
Deleted obsolete pull_requests:
https://github.com/zubairshakoorarbisoft/edx-repo-health/pull/17

These Packages need manual review..

[DOWNGRADE] wheel changes from 0.38.4 to 0.38.4

List of packages in the PR without any issue.

coverage changes from 7.0.0 to 7.0.1
coverage[toml] changes from 7.0.0 to 7.0.1
doc8 changes from 1.0.0 to 1.1.1
multidict changes from 6.0.3 to 6.0.4

Closing obsolete PR.


increase_order

Hello.
When you renew a service, the renewal information is recorded in the table increase_order, but no renewal occurs.
I couldn't find reading information from this table anywhere in the code.
How it works? or doesn't work?

Hello, find it in the orders_list table

Hello, find it in the orders_list table

No. Everything is fine in this table.
But if you renew a package that is still actived, it ends up on the increase_order , and not on the orders_list.
and no code reads it from the increase_order

If you renew, the consumption data and time will be zero and the remaining volumes will be lost
And it is registered as a new purchase and this is registered in orders_list

If you renew, the consumption data and time will be zero and the remaining volumes will be lost And it is registered as a new purchase and this is registered in orders_list

This is the problem! When renew plan, the order_list does not change in any way, but it written to the increase_order.

@wizwizdev
I found error...
bot.php
for example in line 7506 (also in other functions)
wrong code
$newExpire = $time + $days * 86400;
right code
$newExpire = $expire_date + $days * 86400;

It will be checked


Empty commented lines and apersand in /etc/resolv.conf makes pygmy fail

On Fedora my /etc/resolv.conflooks like this:
# This file is managed by man:systemd-resolved(8). Do not edit.
#
# This is a dynamic resolv.conf file for connecting local clients to the
# internal DNS stub resolver of systemd-resolved. This file lists all
# configured search domains.
#
# Run "resolvectl status" to see details about the uplink DNS servers
# currently in use.
#
# Third party programs should typically not access this file directly, but only
# through the symlink at /etc/resolv.conf. To manage man:resolv.conf(5) in a
# different way, replace this symlink by a static file or a different symlink.
#
# See man:systemd-resolved.service(8) for details about the supported modes of
# operation for /etc/resolv.conf.

nameserver <IP_ADDRESS>
options edns0 trust-ad

I get this error:
pygmy up
Successfully started dnsmasq
Successfully started haproxy
Successfully created amazeeio network
Successfully connected haproxy to amazeeio network
Successfully started mailhog
Successfully started ssh-agent
Requesting sudo to write to /etc/resolv.conf
status to see details about the uplink DNS servers
# currently in use.
#
# Third party programs should typically not access this file directly, but only
# through the symlink at /etc/resolv.conf. To manage man:resolv.conf(5) in a
# different way, replace this symlink by a static file or a different symlink.
#
# See man:systemd-resolved.service(8) for details about the supported modes of
# operation for /etc/resolv.conf.
nameserver <IP_ADDRESS>  # added by amazee.io pygmy
nameserver <IP_ADDRESS>
options edns0 trust-ad' | sudo tee /etc/resolv.conf >/dev/null: -c: line 0: unexpected EOF while looking for matching `''
status to see details about the uplink DNS servers
# currently in use.
#
# Third party programs should typically not access this file directly, but only
# through the symlink at /etc/resolv.conf. To manage man:resolv.conf(5) in a
# different way, replace this symlink by a static file or a different symlink.
#
# See man:systemd-resolved.service(8) for details about the supported modes of
# operation for /etc/resolv.conf.
nameserver <IP_ADDRESS>  # added by amazee.io pygmy
nameserver <IP_ADDRESS>
options edns0 trust-ad' | sudo tee /etc/resolv.conf >/dev/null: -c: line 7: syntax error: unexpected end of file
Error configuring local resolver

Removing the empty commented lines and the commented lines containing an ", it runs through:
# This file is managed by man:systemd-resolved(8). Do not edit.
# This is a dynamic resolv.conf file for connecting local clients to the
# internal DNS stub resolver of systemd-resolved. This file lists all
# configured search domains.
# currently in use.
# Third party programs should typically not access this file directly, but only
# through the symlink at /etc/resolv.conf. To manage man:resolv.conf(5) in a
# different way, replace this symlink by a static file or a different symlink.
# See man:systemd-resolved.service(8) for details about the supported modes of
# operation for /etc/resolv.conf.
nameserver <IP_ADDRESS>
options edns0 trust-ad

https://github.com/pygmystack/pygmy fixes this


Fix time argument formatting to include time zone

In local testing, I saw that Container.logs misbehaved when passing the since parameter. I believe this is because my time zone is UTC-4, and so asking for something like
container.logs(since=container.state.started_at)

would return no logs as it was effectively asking for logs from the future:

container.state.started_at parses the inspect output into a zone-aware datetime; the timezone in inspect's output is always UTC (Z)
the time formatting in format_time_for_docker strips the time zone rather than converts to local time
the docker CLI treats its --since argument as being in local time

I instrumented the Popen call to see what arguments were passed to the docker CLI. Taking the exact same command and appending a Z to the time to force the correct time zone printed logs as expected.

Many thanks for the thorough bug hunting! That's awesome! From what you described, it sounds like a good fix. I'll take a look in details and give you a review in the next few days :) I also wonder if this kind of bug can occur somewhere else in the codebase.

@gabrieldemarmiesse yup I removed my monkey patch to test with current master and it works, thanks!


@xstate/react: add context option for convenience

Compilation will fail due to UseMachineOptions warning.
As I don't know TS, I'll need help to fix it.
cc @davidkpiano @Andarist

Can you share the compilation error here?

You can fix errors by applying this patch:
diff --git a/packages/xstate-react/src/index.ts b/packages/xstate-react/src/index.ts
index 2d16e28..f862040 100644
--- a/packages/xstate-react/src/index.ts
+++ b/packages/xstate-react/src/index.ts
@@ -20,14 +20,14 @@ interface UseMachineOptions<TContext> {
   immediate: boolean;
 }

-const defaultOptions: UseMachineOptions = {
+const defaultOptions = {
   immediate: false
 };

 export function useMachine<TContext, TEvent extends EventObject>(
   machine: StateMachine<TContext, any, TEvent>,
   options: Partial<InterpreterOptions> &
-    Partial<UseMachineOptions> &
+    Partial<UseMachineOptions<TContext>> &
     Partial<MachineOptions<TContext, TEvent>> = defaultOptions
 ): [
   State<TContext, TEvent>,
@@ -46,7 +46,7 @@ export function useMachine<TContext, TEvent extends EventObject>(
     {
       ...machine.context,
       ...context
-    }
+    } as TContext
   );

   // Reference the service

Thank you very much @Andarist!

Can you write a test for this? You can do this in /packages/xstate-react/test and run npm t in this directory.

I added a test, but it's failing to TS errors. 😡
    TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
    test/useMachine.test.tsx:114:48 - error TS2345: Argument of type '{ context: { test: boolean; }; }' is not assignable to p
arameter of type 'Partial<InterpreterOptions> & Partial<UseMachineOptions<{ data: undefined; }>> & Partial<MachineOptions<{ da
ta: undefined; }, EventObject>>'.
      Type '{ context: { test: boolean; }; }' is not assignable to type 'Partial<UseMachineOptions<{ data: undefined; }>>'.
        Types of property 'context' are incompatible.
          Property 'data' is missing in type '{ test: boolean; }' but required in type '{ data: undefined; }'.

    114       const [state] = useMachine(fetchMachine, { context });
                                                       ~~~~~~~~~~~

      test/useMachine.test.tsx:17:5
        17     data: undefined
               ~~~~~~~~~~~~~~~
        'data' is declared here.

I'll fix it.


merge from template-esm-only

.github/workflows/codeql_analysis.yml

chore: add github/codeql-action/init@v2 (jobs.analyze.steps.uses)
chore: add github/codeql-action/analyze@v2 (jobs.analyze.steps.uses)

:tada: This PR is included in version 11.0.16 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Source control tab now displays changes in tree view and cannot be set to list view via settings.

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.92.1 (Universal)
OS Version: maxOS Sonoma 14.5

Steps to Reproduce:

Open repo with changes in multiple different files

Today I noticed that the view of changes in the source control tab is now a tree. I'm not sure why this changed. I discovered the "scm.defaultViewMode": "list" setting that I figured would return things to the previous behavior but this doesn't appear to be the case.

@goleary, the setting controls the default view mode (list/tree) for the very first time you are opening a folder/workspace in VS Code. To toggle the view mode you can use one of the following actions:

Right click in the empty space in the "Source Control" view and choose "View as List" or "View as Tree"
Use the ... menu in the "Source Control" view, then "View & Sort" -> "View as List" or "View as Tree"

If that does not resolve the issue please feel free to reopen it. Thank you!


Need more information

There is insufficient information on how SfB uses file sharing and the impact on SfB services if file sharing is not deployed in a high availability configuration and the server hosting the file services fails.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f3ca816c-d7cf-500e-4710-8693b584b5ab
Version Independent ID: 511bacc3-dd79-52bd-a4a2-baa667693b68
Content: File sharing high availability in Skype for Business Server 2015
Content Source: Skype/SfbServer/plan-your-deployment/high-availability-and-disaster-recovery/file-sharing.md
Service: unspecified
Product: skype-for-business-itpro
GitHub Login: @MicrosoftHeidi
Microsoft Alias: heidip

Thank you for this feedback and for contributing to the wellness of the content! This is a good idea and we have added it into our backlog for triage and prioritization.


Configure Cobertura plugin to produce html only and aggregate coverage reports.

Automatic report creation is not currently configured- reports are generated with:
mvn cobertura:cobertura

This looks good.  Can you create a JIRA for it and I'll merge it.

I'll close this one, sort out the merge conflict and put up another referencing the JIRA.
Thanks!


Issue for generated types

If I put this in the schema.prisma
clientOutput = "@project/database"

Pothos generates me  from<EMAIL_ADDRESS>that's really not what I want. I just want what I wrote in the clientOutput, because I really don't want the index.js things I already define the exports field in my package.json of this package.
But I really think is something more than that, we can't use @project/database too because its in a node_module folder.. I have no choice to set a thing like that:
  output       = "../../../apps/api/src/pothos-types.ts"

But I really think is something more than than, we can't use @project/database too because its in a node_module folder.. I have no choice to set a thing like that:

Can you elaborate on this?  Are you saying that you are generating Pothos types into node_modules so that even if the import for the generated file was @project/database it wouldn't work?
A more complete example of what your setup is would be helpful (where are you generating the Prisma client, where are you generating Pothos types, what are the exports you are defining that you are trying to use.

I'm in a turborepo with all my apps and packages in esm. So my package.json looks like this:
"exports": {
    ".": {
      "types": "./dist/index.d.ts",
      "import": "./dist/index.js",
      "require": "./dist/index.cjs"
    },
    "./dist/*": {
      "types": "./dist/*.d.ts",
      "import": "./dist/*.js",
      "require": "./dist/*.cjs"
    }
  },
  "main": "./dist/index.cjs",
  "module": "./dist/index.js",
  "types": "./dist/index.d.ts",

It means that other packages/apps don't need the .js thing. Only in the same package.
The clientOutput = "@project/database" thing actually add a index.js so it's wrong. Then even if it write exactly what I put in the clientOuput field it doesn't work too because it's generated in:
/node_modules/.pnpm/@pothos+plugin-prisma<EMAIL_ADDRESS>and it can't resolve @project/database

I'm not sure that second part is something I can really solve for you.  What I would recommend instead is that you generate the pothos types into the package as the prisma client (into the @project/database package), you still would use a relative path for the clientPath, but it would be relatively short/simple

Yes I think I will do that, then I could import it with @project/database/dist/pothos-types

currently I think trying to detect package names and treat them differently (by not appending index.js) may be a breaking change, and I'm not sure it's actually a good idea to try to support this.  I'm going to close this for now, but happy to talk more about it if you feel it's important


Bump ruff to 0.3.0

Also, silence the ruff lint deprecation messages.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Screen readers do not announce anything when Datalist autocomplete results appear

Describe the bug
[Test URL]
https://clarity.design/documentation/datalist
[WCAG 2.1 Guideline]
Success Criterion 4.1.2 Name, Role, Value
(Level A)
https://clarity.design/documentation/datalist
[OS]
macOS version 10.15.1, Windows 10
[User Agents/Assistive Technologies]
macOS Safari/VoiceOver, Windows 10/NVDA/Firefox, Windows 10/NVDA/Edge
[Component]
Datalist form input
[Description]
Screen readers do not announce anything when Datalist autocomplete results appear.
See the test results for the datalist element at http://cx-guidelines.vmware.com/examples/datalist.html.
[User Impact]
Screen reader users will not hear anything when they use the autocomplete capabilities of this control.
[Steps to Reproduce]
Using one of the listed screen reader/browser combinations, activate the autocomplete feature of the datalist and observe that you do not hear anything.
[Recommendation]
Implement a control based on one of the following approaches.

http://whatsock.com/tsg/Coding Arena/ARIA Comboboxes/ARIA Comboboxes (Native Inputs, Editable with Word Match)/demo.htm

https://adamsilver.io/articles/building-an-accessible-autocomplete-control/

This seems to be a known bug with some browsers screen reader combinations.
See https://a11ysupport.io/tech/html/datalist_element.
I'm not sure there is anything actionable here, other than to use the Combobox when it is available if this is a problem for applications. I'm going to close this as unactionable due to it being out of our hands.