Feat/flatten fragments cost plugin

Introduce config to control if depthCostFactor should be applied to fragments when calculating the cost

Introduce config to control if depthCostFactor should be applied to fragments when calculating the cost

Sounds great ! We'll be reviewing soon

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.73%. Comparing base (9c39455) to head (d55f5ea).

Files with missing lines
Patch %
Lines

packages/plugins/cost-limit/src/index.ts
92.85%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   91.80%   91.73%   -0.07%
==========================================
  Files          17       17
  Lines         366      375       +9
  Branches      120      124       +4
==========================================
+ Hits          336      344       +8
- Misses         30       31       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Tilemap: Fix ATLAS tile bitmask not working outside of editor

This PR is related to #36972
With the actual solution for Tilemap "ATLAS Tile" the priority system works based on a priority flag inside the editor to enable the whole priority system / bitmask randomizer  (behind the scenes based on a "center bitmask flag"). This works like designed within the editor, but if the ATLAS tile is used via Tilemap by code (i. e. GD-Script) the complete priority system is not usable.
Reason: ATLAS Tileset by itself does not allow to set manual bitmasks via editor (which makes sense), but the bitmask code requires a "center bitmask flag" (as described above).
My simple solution to this issue, invert the check within "TileMap::update_cell_bitmask" and also invert the setting of this center bitmask in "TileMapEditor::_set_cell". With this change the original intention is still given, with the bonus, that it's now usable via code (i. e. GD-Script).
Additional Remark: (not done change)
I would also delete the following code in "TileMapEditor::_set_cell", as all ATLAS tile interactions are done based on the actual "cell", only in this case (which is deletion of tiles in the Tilemap Editor) it's updating the "bitmask_area" (3x3 field of cells), which causes also to reset all surrounding tiles. I don't think that this was the intention of the implementation and could also confuse users (only drawback I can see = it could have an impact on AUTO-TILES directly surrounding the deleted ATLAS tile). Remark: no need to change to "update_cell_bitmask" as the cell is set to empty in this case (-1).
	} else {
		node->update_bitmask_area(Point2(p_pos));
	}

Btw. also the comment within the code, indicates that the intention was opposite to the coded solution. With this change, the comment matches exactly.

Could someone guide me, how to fix the "The Travis CI build failed"?
The code is basicly the same as before, only changed sequence and "==" to "!=".

Btw. also the comment within the code, indicates that the intention was opposite to the coded solution. With this change, the comment matches exactly.

The BIND CENTER for atlas indicates that when you place a tile around that tile with BIND_CENTER, it will not be changed. Otherwise, whenever you place one atlas tile next to another, it will always randomize the tiles that have already been positioned, even if the tiles was positioned with priority disabled.

Tile that was placed with priority disabled shouldn't be changed


[Improvement] SortOrders.java shoudl have a private constructor

What would you like to be improved?
Utility classes should have a private constructor.
How should we improve?
Add a private constructor.

Will be working on this one.


feat: add zALLMATCHSCAN

Add zALLMATCHSCAN command.
Refactored the decoder as ClamAV can output multiple \0 terminated lines.
Also added a check that clamd is running on cargo test to improve dev exp.

Note that I will rebase #4 once it's merged so that this PR contains only the last commit 740e442

I've realised that there must be some issue in the parsing of the stream. After a few commands when .keep_alive(true), the client goes into error. Looking into it

Very strange, tests pass on my machine. Could you check if tests also work for you @LevitatingOrange ?

Very strange, tests pass on my machine. Could you check if tests also work for you @LevitatingOrange ?

Yeah weird, they pass on my machine too.


docs(FAQ): add frequently asked questions document

The new frequently asked questions document contains a collection
of commonly asked questions and answers to make it easier for users
to find solutions to common issues.

@bddckr I've created a PR to bring FAQs into the main repo, lemme know what you think
(Also, I know the links can be put at the bottom and don't all need to be repeated and inline on github, but when I copy/paste it into readme.io then all the links get lost unless they're inline so it's pure laziness on my behalf why they're all inline :) )


Add CI on Windows

Summary
Add Windows CI builds and fix/work around any issues that they found.

How to test

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

I just realized I forgot to add a changelog entry. WIll do so shortly.


Provide api call to Stop experiment

There are use cases that require stopping an already running experiment. This PR provides REST & gRPC endpoints to allow users to stop a running experiment.
The PR includes sanity checks for remove removing running tests.
One commit that is not directly related to the main functionality of the PR is some changes to speed up running the test suite.  Running the full testsuite went from 2562 seconds to 107 seconds on my machine, and allowed me to find a couple of race/locking issues. If it is deemed appropriate to separate out that change, I can revert that commit in this PR and open a separate PR

@johnaohara Thank you for adding this, should make it easier for scripts to integrate HPO into workflows thanks to this feature. Just one comment, can you update the API doc for the new API

@dinogun np, I will update the API doc

@dinogun I have updated the API Doc, and modified the response code to be consistent with the other POST commands. Quick question, is there a reason that the rest api's return -1 with a http 4xx response, and not return a message that is meaningful for the client?

@dinogun I have updated the API Doc, and modified the response code to be consistent with the other POST commands. Quick question, is there a reason that the rest api's return -1 with a http 4xx response, and not return a message that is meaningful for the client?

@johnaohara Yes, that was convenient for us when HPO was part of Autotune and returning specific error codes. This needs to be changed going forward.

@dino - Yes, I 'm done with the test changes.


Polymer Gestures: Left mouse button "Up" event not firing after right mouse button click.

Description
Polymer Gesture "Up" event does not fire on the left mouse button up ("mouseup"), when the right mouse button was clicked in the meantime.
Live Demo
https://jsfiddle.net/f47kun0v/25/
Steps to Reproduce

Add "down" and "up" events to an element.
Click and HOLD Left Mouse Button Down.
Click and Release the right mouse button.
RELEASE the left mouse button.

Polymer "Up" Event is never fired.
Expected Results
The "up" event of the left mouse button should be fired even if the right mouse button was clicked during left mouse button being clicked.
Actual Results
Polymer "Up" Event is never fired. It looks like the the event listeners are reset (untrackDocument()) on right mouse button click, so the "mouseup" event is never caught.
Browsers Affected
Tested with these:

[x] Chrome
[x] Firefox
[x] Edge

Versions

Polymer: v3.3.0 (3.4.1 did not work either)
webcomponents: v2.2.10

Can anyone provide me with the resources how to fix this issue?
As I am a beginner and don't know much about it.

@Oliviero50

Any news about this?

show
On Tue, May 2, 2023 at 7:18 AM akstek @.***> wrote:

Any news about this?
—
Reply to this email directly, view it on GitHub
https://github.com/Polymer/polymer/issues/5674#issuecomment-1531224881,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJABVIHCYVP3PBVLCKEKY3XEDNOXANCNFSM4SERAQIQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


Adding an introduction.md

I've edited down the text from my repo and added it into introduction.md as per #4 . I was trying to integrate it into the md, but I realized that I didn't want to break up the flow of the file.

This is amazing, thank you so much! 🙏


TechDocs, Writing Documentation

A guide for people writing documentation using TechDocs. Should describe how to get a environment running that allows for editing of documentation in the backstage UI of techdocs.
Template is provided in docs/features/techdocs/writing-documentation.md

Is included in the creating-and-publishing.md file.


Apply locality overrides in bootstrap

We have some logic to apply locality in the bootstrap, but it only works
on GCE. In Pilot, we provide an option to override locality directly via
labels. However, the pilot logic for capturing this is read from service
instance, if it exists, then fallback to bootstrap locality. This can
cause a race condition if the service instance isn't populated by then,
so we can account for this by just adding the locality to the bootstrap
as well.
Additionally, add better waiting during the locality LB test, which is
now passing 100% of the time with this change.
Fixes https://github.com/istio/istio/issues/13812
I took off the flaky test labels, since otherwise they won't run in the PR which is annoying. I can remove it after it runs once, I just want to make sure they pass on prow at least once. I ran 5 times locally and it passed every time, whereas before it passed maybe 1/5 times.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [howardjohn]
pkg/OWNERS
tests/integration/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
afdad9755385b3df6164fef5ab523c86f02cef13
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Test is still failing, so need a hold.. might be dependant on https://github.com/istio/istio/pull/14343

/test integ-pilot-k8s-presubmit-tests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
afdad9755385b3df6164fef5ab523c86f02cef13
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
afdad9755385b3df6164fef5ab523c86f02cef13
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
7a4c77067f896700d4072c8af7634e6d6e8237d6
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-pilot-k8s-presubmit-tests.sh
7a4c77067f896700d4072c8af7634e6d6e8237d6
link
/test integ-pilot-k8s-presubmit-tests-master

prow/integ-security-k8s-presubmit-tests.sh
7a4c77067f896700d4072c8af7634e6d6e8237d6
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-master

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
7a4c77067f896700d4072c8af7634e6d6e8237d6
link
/test integ-security-k8s-presubmit-tests-master

prow/integ-pilot-k8s-presubmit-tests.sh
7a4c77067f896700d4072c8af7634e6d6e8237d6
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-presubmit-tests-master
Testing again to check for false positives

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
89562665812e56090eecd7e83a758511f4ccfe6b
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [howardjohn,hzxuzhonghu]
pkg/OWNERS
tests/integration/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS
tests/integration/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-security-k8s-presubmit-tests.sh
f2000bb2f5faad9c6b7400782df952304a181be9
link
/test integ-security-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS
tests/integration/pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

/assign @nmittler this seems to fix the flaky tests (and real bug in the process), can you take a look?

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [howardjohn]
tests/integration/pilot/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu @liamawhite can you take a look please, needed a rebase

@hzxuzhonghu would you mind re-reviewing that one (lgtm label dropped after change).
I'd love to remove these flaky tests from 1.2 CI too

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS
tests/integration/pilot/OWNERS [howardjohn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
394d4ed7b597f6abfecb1a3d61288870423fd208
link
/test e2e-simpleTests-cni-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
394d4ed7b597f6abfecb1a3d61288870423fd208
link
/test e2e-simpleTests-cni-master

prow/integ-pilot-k8s-presubmit-tests.sh
394d4ed7b597f6abfecb1a3d61288870423fd208
link
/test integ-pilot-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler]
tests/integration/pilot/OWNERS [howardjohn,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

Thanks @nmittler, fixed now

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
394d4ed7b597f6abfecb1a3d61288870423fd208
link
/test e2e-simpleTests-cni-master

prow/integ-pilot-k8s-presubmit-tests.sh
394d4ed7b597f6abfecb1a3d61288870423fd208
link
/test integ-pilot-k8s-presubmit-tests-master

prow/istio-unit-tests.sh
0fc4279a5add6a9f9330d7c6f1fb626391c9c5f8
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu or @nmittler , please /lgtm again, as John addressed your comments and it dropped the lgtm label ;-)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler]
tests/integration/pilot/OWNERS [howardjohn,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a6de0fbfda5206418a482af4ba1a13fa4b0e3b8e
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a6de0fbfda5206418a482af4ba1a13fa4b0e3b8e
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master
Seems to be an infra flake

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a6de0fbfda5206418a482af4ba1a13fa4b0e3b8e
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a6de0fbfda5206418a482af4ba1a13fa4b0e3b8e
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a6de0fbfda5206418a482af4ba1a13fa4b0e3b8e
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a6de0fbfda5206418a482af4ba1a13fa4b0e3b8e
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
a6de0fbfda5206418a482af4ba1a13fa4b0e3b8e
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
cb8e21991a11b18fe1df11d116897d40ffcea855
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
cb8e21991a11b18fe1df11d116897d40ffcea855
link
/test e2e-simpleTests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simpleTests-master

/test e2e-simpleTests-master

@hzxuzhonghu or @nmittler prow is finally fixed if you can lgtm again

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: howardjohn, hzxuzhonghu, nmittler
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pkg/OWNERS [nmittler]
tests/integration/pilot/OWNERS [howardjohn,nmittler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[Idea] Provide inset aware layouts

We could make it easier to support insets, through a custom Scaffold implementation, as well making InsetAwareTopAppBar a real thing ™
Candidates:

Scaffold
TopAppBar
BottomNavigation
ModalDrawerLayout
BottomAppBar (less priority)

I don't know if adding custom composables of already existing ones is a good idea. That would require alot of maintanance in the future. If Scaffold is changed, so will InsetAwareScaffold have to change.
Wouldn't a simple modifier that applies the insets to the any Composable? Something like .padding(WindowInsets) or applyWindowInsets()

If Scaffold is changed, so will InsetAwareScaffold have to change.

Compose’s API is now API stable, so there won’t be any API changes. This library isn’t designed to live forever either.

Wouldn't a simple modifier that applies the insets to the any Composable? Something like .padding(WindowInsets) or applyWindowInsets()

We already have that: https://google.github.io/accompanist/insets/

From what I remember in Flutter, only the Scaffold was insets aware, and it passed those insets to its children. So maybe that's how it should be done in here as well?

Sure, but we're not copying Flutter, or being limited to what Flutter provides.

Hi, I made a very early version of InsetAwareScaffold.
class InsetAwareState(
    var topBarSize: IntSize = IntSize.Zero,
    var bottomBarSize: IntSize = IntSize.Zero,
)

@Composable
fun rememberInsetAwareState(): InsetAwareState = remember { InsetAwareState() }

fun Modifier.padding(
    insetAwareState: InsetAwareState,
    additionalTop: Dp = 0.dp,
    additionalBottom: Dp = 0.dp,
) = composed {
    padding(
        LocalWindowInsets.current.systemBars.toPaddingValues(
            top = false,
            additionalTop = with(LocalDensity.current) { insetAwareState.topBarSize.height.toDp() + additionalTop },
            additionalBottom = with(LocalDensity.current) { insetAwareState.bottomBarSize.height.toDp() + additionalBottom },
        )
    )
}

@Composable
fun InsetAwareScaffold(
    modifier: Modifier = Modifier,
    insetAwareState: InsetAwareState = rememberInsetAwareState(),
    scaffoldState: ScaffoldState = rememberScaffoldState(),
    topBar: @Composable () -> Unit = {},
    bottomBar: @Composable () -> Unit = {},
    content: @Composable (PaddingValues) -> Unit = {},
) {
    Scaffold(
        modifier = modifier,
        scaffoldState = scaffoldState,
        bottomBar = {
            Box(
                modifier = Modifier
                    .onSizeChanged { insetAwareState.bottomBarSize = it },
                content = { bottomBar() }
            )
        },
        content = { innerPadding ->
            content(innerPadding)
            Box(
                modifier = Modifier
                    .onSizeChanged { insetAwareState.topBarSize = it },
                content = { topBar() }
            )
        }
    )
}

Usage
  val insetAwareState = rememberInsetAwareState()
  InsetAwareScaffold(
        modifier = Modifier.fillMaxSize(),
        insetAwareState = insetAwareState,
        topBar = { TopAppBar() }
    ) {
        Box(
            modifier = Modifier
                .fillMaxSize()
                .padding(insetAwareState = insetAwareState)
        ) {
        ..................
        }
    }

Please no, that feels like adding unnecessary bloat (a little rude, excuse me). I don't want to have many theme / styles / layout implementations, that's a past thing which in my opinion should be

Please no, that feels like adding unnecessary bloat (a little rude, excuse me).

I get not wanting to bloat the main library, but this would be in an optional insets-layouts library (if we did it).

Oh, that’d be nice for some people, my guess.

On 30 Apr 2021, at 12:37, Chris Banes @.***> wrote:
Please no, that feels like adding unnecessary bloat (a little rude, excuse me).
I get not wanting to bloat the main library, but this would be in an optional insets-layouts library (if we did it).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/google/accompanist/issues/207#issuecomment-829876254, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH762BI33A7EHZC7TZM45H3TLJFZ5ANCNFSM4X42L7ZQ.

The issue is still relevant.

Oh, thank you!


build workspace faild

Description:

dns error
Expected Behavior:

archive.ubuntu.com can resolve
Context information:
Output of git rev-parse HEAD
6b16f2b479e24355897f0e3f999335bf52846892

Output of docker version
Docker version 19.03.9

Output of docker-compose version
1.25.5,

System info: Mac, Windows or Linux.  They have been ignored, or old ones used instead.
+ pecl channel-update pecl.php.net
Updating channel "pecl.php.net"
Channel "pecl.php.net" is not responding over http://, failed with message: Connection to `pecl.php.net:80' failed: php_network_getaddresses: getaddrinfo failed: Temporary failure in name resolution
Trying channel "pecl.php.net" over https:// instead
Cannot retrieve channel.xml for channel "pecl.php.net" (Connection to `ssl://pecl.php.net:443' failed: php_network_getaddresses: getaddrinfo failed: Temporary failure in name resolution)
ERROR: Service 'workspace' failed to build: The command '/bin/sh -c set -xe;     apt-get update -yqq &&     pecl channel-update pecl.php.net &&     groupadd -g ${PGID} laradock &&     useradd -u ${PUID} -g laradock -m laradock -G docker_env &&     usermod -p "*" laradock -s /bin/bash &&     apt-get install -yqq       apt-utils       libzip-dev zip unzip       php${LARADOCK_PHP_VERSION}-zip       nasm &&       php -m | grep -q 'zip'' returned a non-zero code: 1

Stacktrace & Additional info:
not only aliyun，and archive.ubuntu.com con not resolve

2


WIP: expose a JS api through WASM.

This leaves open the question of JS-exposing the rest of the API. KeyMaterial is a good start, but we also need to provide:
* `UcanBuilder`

I started on that one, will post my hack soon. Warning: wasm-bindgen and lifetimes are not the best friends :)

* `DidParser` (keeping in mind implications of #3 & #16)

Ok - that's where I think something like wit (https://github.com/bytecodealliance/wit-bindgen) is better since it makes it easy to import interface implementations from JS. I'll give it a try later.

* `ProofChain`

You scare me.

* Some coherent notion of expressing capabilities; this may just be a POJO/JSON API on the JS side

Right, I'm not sure either how deep in the strongly typed side we need/want to go for that.

  * Capability attenuation will be interesting; right now we depend on the Rust type system to make it work, so we need some generalized way to do the same work without making as rigid an assumption about object shape

Indeed...

And finally, I think packaging for JS should be done in a different project root. Absent a better alternative, I would like to take a page out of Rapier's playbook: a separate project root for a thin, ergonomic JavaScript shim over a WASM-targeted rs-ucan (written in TypeScript). My hope is that JS-specific packaging details can be neatly compartmentalized this way.

I agree - it's weird to hook up the wasm builds to ucan-key-support. But I don't expect much difficulty on that side.


Timezone consistency problem in Postgres ladder 99 functions or raw to public schema

With ladder 99 running in Docker on a Raspberry pi.  In Australia/Melbourne at 5 past 4pm:
for the session:
set timezone = 'Australia/Melbourne'
select now()

2023-12-07 16:05:54.69165+11  correct
select time, value from get_last_value('Main/1000'|| '/Availability', '1w');
for the time, returns:
2023-12-08 03:05:05.798+11 ( incorrect - it's added 11 hrs on to a UTC time as a local time, so that's now a future time - see the day is 8 not 7)
Setting session tz to UTC:
select now()
2023-12-07 05:11:39.885238+00 correct, we are +11 hrs at the moment
select time, value from get_last_value('Main/1000'|| '/Availability', '1w');
for the time, returns:
2023-12-07 16:05:05.798+00 (note this is a UTC tz but with a local time, hence a future time as above)
The time field is type timestamp with timezone.
Pi has it's clock  configured as follows:
pi@fiabtest:/etc $ timedatectl
               Local time: Thu 2023-12-07 15:59:25 AEDT
           Universal time: Thu 2023-12-07 04:59:25 UTC
                 RTC time: n/a
                Time zone: Australia/Melbourne (AEDT, +1100)
System clock synchronized: yes
              NTP service: active
          RTC in local TZ: no
pi@fiabtest:/etc $

Thanks,

Well, I did use a function that returned the latest value, but I've since truncated the history table and still have wrong data. not sure what I have to purge...

Thanks for reporting this issue, @Dowster64! :pray:
I need to look into it a bit more deeper, maybe I could find some time tomorrow. I am quite sure though that it has to be fixed somewhere (probably in the meter app).

@ottobolyos , I am using an inventcom CNCnetPDM adapter and, after re-installing ladder99 (and finding out about tags!) I discovered that everything was fine with your defaults, the time going off when I used their adapter.  Long story short, the CNCnetPDM adapter is the culprit!  It is sending / publishing local time as Zulu time, hence the doubling up.  It was 20:50+11 (my time with timezone) not 20:50+00 (ie UTC 11 hours ahead).  Many apologies.
2023-12-07T20:50:52.490Z|1000:COMP_QTY|316|1000:AX1|812.189 851.344 530.992 105.991 |1000:AX2|394.635 267.098 121.891 335.673 |1000:STATN|2|1000:STATT|Producing|1000:MODEN|1|1000:MODET|Memory|1000:PRGCU|2|1000:PRGMN|4712|1000:SEQCU|1|1000:FEEDR|748|1000:SPSPD|536|1000:ALMST|0|1000:TOOL1|5|1000:TOOL2|5|1000:ALMNR|0|1000:ALMTX|No


two code coverage backports to v1.14-branch

Fix some failures when enabling coverage in two samples.

ignore the Kconfig issues. Working on a fix.


Add port anyrpc

This PR adds a port for AnyRPC (https://github.com/sgieseking/anyrpc). This library provides clients and servers for multiple remote procedure call protocols.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: faaxm sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR! On the arm CI builds, it has an error:
Unknown machine endianess detected. User needs to define ANYRPC_ENDIAN.

@dan-shaw Sorry for the late reply, I didn't find time to look into this earlier... Is there a way to retrigger the build and get some more information? It seems like the logs are no longer available...

@dan-shaw Found a way to patch anyrpc to know the endianness for ARM when built via VS.
I am not supper happy with this as I had to assume that compiling for ARM with visual studio is always for a little-endian ARM-platform, but to my knowledge that should be valid...
Do you know more about this?
Will eventually submit this patch to the anyrpc-repo....

@faaxm Sorry for the delay. I believe compiling for ARM is always in little-endian on Windows. Other than that, the PR looks good. I will squash the commits then merge it - thanks for the PR!


[SYSTEMML-1808] Visualize Hop DAG for explaining the optimizer

This feature could be used in the external demos to explain the SystemML's compiler. It could also be used by beginners who might find it difficult to interpret our explain hop output. For advanced users, it doesnot provide any additional information over explain hop output (other than line numbers). Please note: it doesnot add any additional runtime overhead.

@deroneriksson @bertholdreinwald

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1811/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1814/

@deroneriksson @bertholdreinwald I would like to merge this PR today. Please let me know if there are any objections or concerns :)

Please don't merge yet before I have reviewed.

Sure :)

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1824/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1826/

@bertholdreinwald @mboehm7 @prithvirajsen @dusenberrymw I have added a new utility method jvm_stdout in our python API to display the output from Java. This feature is useful in notebook environment:

For long running jobs, please use the parameter parallel_flush:

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1832/

ping @deroneriksson

This is very extremely useful Niketan! Thank you for such a great contribution. LGTM with a couple comments:

Could the Java MLContext.getHopDag methods be moved to static MLContextUtil.getHopDag methods (and include an MLContext method parameter too to get the various settings) and called from the Python MLContext?
My thinking:
a) Output is in Python graphviz format which is used from python but not java/scala.
Example: digraph {h5[label="u(print)[1:0-1:19]", shape="octagon", color="yellow", tooltip="[-1 X -1], nnz=-1, mem= [in=0, inter=0, out=0 -> 0MB]"]; rankdir = "BT"}
b) MLContext Java class is very lightweight by design (notice how few parameters tend to exist on the MLContext method signatures). The MLContextUtil class tends to hold such code so far in the API.

Nice to have:
a) Javadoc all methods if they're in the MLContext API (public facing code).
b) Auto-format the MLContext API Java code with one of SystemML's code formats (in dev/code-style)

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1849/

Thanks  @gweidner for testing this PR on your laptop.
Thanks @deroneriksson  ... addressed your concerns :+1:

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1855/

Refer to this link for build results (access rights to CI server needed):
https://sparktc.ibmcloud.com/jenkins/job/SystemML-PullRequestBuilder/1856/Failed Tests: 1SystemML-PullRequestBuilder/org.apache.systemml:systemml: 1org.apache.sysml.test.integration.functions.data.FullReblockTest.testBinaryBlockMultipleMSparseMR


ARROW-13992: [R] CI jobs should use the latest version of rcmdcheck

@github-actions crossbow submit *

I took a look at a few of the errors, and they mostly seem to be in installing dependencies. I wonder if we should add in GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} (as recommended by r-lib/actions: https://github.com/r-lib/actions/blob/60e594624f0d630cdbf6bc9deee7b0771f77e0f3/.github/workflows/check-release.yaml#L15) to the GHA jobs at least to reduce those from happening. This is scope creep from this specific change, of course.

@jonkeane I wanted to add the relevant PAT to the task described in dev/tasks/r/github.macos.autobrew.yml  (it was failing at installed dev rcmdcheck without it), but (see the last but one PR), I did it wrong.  Given that the params that are passed in at the top level get printed out, I was a bit hesitant to try again and risk printing out the PAT.  Any idea how I could go about it without messing things up?

We should confirm this with @kszucs to make sure, but in my understanding they will be masked (and they are limited to the lifetime of the job anyway, though I only learned that by reading https://docs.github.com/en/actions/reference/authentication-in-a-workflow again just now!).
We already have at least one example of using something like this which obfuscates it appropriately.
We could consider removing printenv (notably in ci/scripts/r_test.sh ) but also in two more places as well to be extra extra careful. (Maybe replace that with a macro that lists a few of the vars we end up caring about like ARROW_R_DEV?

Closing this ticket as the change is now in the released version of rcmdcheck


Download Results JSON for a given deliverable

In order to deal with deadlines that are different for every lab section, we need access to the results of all the tests that classy ran for a given deliverable.  Reid suggested that it appear on the Config page and could look like:

But with a button label like "Download Results JSON".

This is a feature request that looks very convenient. At the moment, Elisa is requesting this data from us, which is by tech staff manually.
We have an export utility that runs in the console, but the export utility does not seem the most user-friendly compared to this idea.
We can start by exporting the results data, and if more tables are requested down the road, then it can be added in or the course staff can consider adding data to the result custom property to help support their analytics.


refactor: refactored events

@saurabhdaware enabling Netlify Deploy Previews would be nice :smiley:

@saurabhdaware enabling Netlify Deploy Previews would be nice

Oh yes! It is deployed on GitHub pages so can we have netlify for build previews only?


Apple TV card flickers and throws errors

Home Assistant release (hass --version): 0.39.1
Python release (python3 --version): 3.4.2
Component/platform: Apple TV
Description of problem: The Apple TV panel in the frontend constantly flashes as it tries to run some sort of animation and then goes back to being normal. In the Chrome Developer Console I'm seeing requests every second and the following error:
GET https://example.com/api/media_player_proxy/media_player.apple_tv?token=f6…12048928652b8f024f2648c4cb9a2c5bdb4&cache=398238c893b2a450b11cd4d1e51e0439 500 (Internal Server Error)
This happens no matter if my Apple TV 4 is turned on or off. The actual internal device state is correct and there are no errors showing up on the console either. I configured the device manually (as I'm suffering from the discovery memory leak issue). This has only been happening on 0.39.x.
Expected: The Apple TV card shows up without flickering and no errors are thrown in the Javascript Console.
Problem-relevant configuration.yaml entries and steps to reproduce:
media_player:
  - platform: apple_tv
    host: <ip>
    login_id: <id>

Traceback (if applicable):
GET /api/media_player_proxy/media_player.apple_tv?token=f63cb5705a09f9c5aa2ff1fb2bf0912048928652b8f024f2648c4cb9a2c5bdb4&cache=398238c893b2a450b11cd4d1e51e0439 HTTP/1.1
Host: example.com
Connection: keep-alive
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36
Accept: image/webp,image/*,*/*;q=0.8
Referer: https://example.com/states/group.example
Accept-Encoding: gzip, deflate, sdch, br
Accept-Language: de-DE,de;q=0.8,en-US;q=0.6,en;q=0.4

Additional info:

I am running into this also.  It appears that it flashes when it is trying to get the “what’s playing” artwork.  I noticed that when I am watching youtube on Apple TV, the Apple TV panel shows the name and artwork of the current video and does not flash but when I am not watching anything, the panel flashes.

On Feb 27, 2017, at 1:06 PM, Heiko Rothe<EMAIL_ADDRESS>wrote:
Home Assistant release (hass --version): 0.39.1
Python release (python3 --version): 3.4.2
Component/platform: Apple TV
Description of problem: The Apple TV panel in the frontend constantly flashes as it tries to run some sort of animation and then goes back to being normal. In the Chrome Developer Console I'm seeing requests every second and the following error:
GET https://example.com/api/media_player_proxy/media_player.apple_tv?token=f6…12048928652b8f024f2648c4cb9a2c5bdb4&cache=398238c893b2a450b11cd4d1e51e0439 500 (Internal Server Error)
This happens no matter if my Apple TV 4 is turned on or off. The actual internal device state is correct and there are no errors showing up on the console either. I configured the device manually (as I'm suffering from the discovery memory leak issue). This has only been happening on 0.39.x.
Expected: The Apple TV card shows up without flickering and no errors are thrown in the Javascript Console.
Problem-relevant configuration.yaml entries and steps to reproduce:
media_player:

platform: apple_tv
host:
login_id:
Traceback (if applicable):

GET /api/media_player_proxy/media_player.apple_tv?token=f63cb5705a09f9c5aa2ff1fb2bf0912048928652b8f024f2648c4cb9a2c5bdb4&cache=398238c893b2a450b11cd4d1e51e0439 HTTP/1.1
Host: example.com
Connection: keep-alive
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36
Accept: image/webp,image/,/*;q=0.8
Referer: https://example.com/states/group.example
Accept-Encoding: gzip, deflate, sdch, br
Accept-Language: de-DE,de;q=0.8,en-US;q=0.6,en;q=0.4
Additional info:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/issues/6293, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1W1Gn2bdXKKGPAbUwopOM_M2P8olojks5rgyysgaJpZM4MNkD8.

I think it's a media_player issue since I see it on my Apple TV as well as Sonos.

I see it on both my media-player cards too (LG TV and Apple TV)

I also have the problem with atv, comment out bravia and samsung tv, these 2 have not this issue.

Does this happen even if the Apple TV is turned off in the web interface?

no, only when its turned on

I can confirm this behavior on my side.

I have now created a PR with push update support which should also fix this, I hope. Please give it a spin: https://github.com/home-assistant/home-assistant/pull/6323

I'm glad I'm not the only one experiencing this issue. I made a screencast of the issue before seeing the fix, so I'll go ahead and post it anyway: https://youtu.be/nHKKhibytIE
@postlund I'll give the fix a try and let you know the results.

FYI: It's merged to dev now so you can just pull from dev.

I applied the necessary changes from #6323:
$ pip3 install --upgrade pyatv==0.2.1
$ mkdir -p /etc/homeassistant/custom_components/media_player
$ cd /etc/homeassistant/custom_components/media_player
$ wget https://raw.githubusercontent.com/postlund/home-assistant/1947ee153d59657abe9c9d45415592cc9c7fa976/homeassistant/components/media_player/apple_tv.py

Home Assistant is correctly loading the overridden file:
17-03-02 08:55:38 INFO (MainThread) [homeassistant.loader] Loaded media_player.apple_tv from custom_components.media_player.apple_tv

It is still happening even with #6323 in place. However, I think this might not be entirely related to the Apple TV platform, as I get a similar error in my Chrome Developer Console for a camera entity that I have disabled in Blue Iris, but still enabled in Home Assistant. When I attempt to load the proxy URL for either the Apple TV[1] or the Camera[2], Chrome spits out an ERR_INVALID_RESPONSE error. If I go to the actual Blue Iris camera URL[3], I get HTTP ERROR 503.
[1]Apple TV Proxy URL: https://my.domain/api/media_player_proxy/media_player.apple_tv_living_room?token=XXXXXXXX&cache=XXXXXXXX
[2]Camera Proxy URL: https://my.domain/api/camera_proxy/camera.camera_name?token=XXXXXXXX&time=XXXXXXXX
[3]Blue Iris Camera URL: http://X.X.X.X:12345/mjpg/camera_shortname/video.mjpg

@dale3h So, the frontend is making requests for the media image but in reality no image exists? If I have understood the flow correctly, the frontend uses entity_picture to get an URL to the media image. In the case of Apple TV, we can safely assume that no image exists if nothing is playing and return None in that case (that is how it's done now). But if something is playing, we can only know if artwork is available or if we try to fetch the artwork. A HTTP 500 error code is returned if no image is found. Maybe we are in a limbo here?

Just wanted to say that this problem is still there in 0.4.0 - same symptoms as described above. For now I'm back to hiding the platform in the frontend.
I haven't had time to take a deeper look at it, but if any further debugging information is needed I'll gladly provide it!


Fix card message

Right now the message displayed on the card is verbose, ugly, and unhelpful. We should make it look nice!

close #91