Add/pr teamplate

What is this PR for?
This PR has for goal to set guidelines regarding the Pull Request format in order to simplify the reviewer job.
It updates the project guidelines to include the template, and provides an easy click to fill Pull Request tool.
This PR itself is done using the Pull Request's format
What type of PR is it?
Documentation
Todos

[x] - Include PR Template in the Project Guidelines
[x] - Small modifications to the project guidelines
[x] - Add short bookmarklet to the project guidelines

Is there a relevant Jira issue?
No
How should this be tested?

You can check this PR's Markdown files for the documentation
You can try the bookmarklet by creating a new bookmarked page and copy/pasting the code as its content, then click on it while creating a PR.

Screenshots (if appropriate)
The template's bookmarklet in action:

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No, it is documentation

This is a really good template.
Two questions:

Do other open source projects find this level of formality necessary?  I'm not saying its a bad idea.  I just think whenever we have an issue, the first place we look should be to the experience of other projects.

Does it make sense to have a template for use by the reviewer?  I've seen a lot of "looks good to me" written so quickly after a PR is made, there's no way the reviewer could have compiled it, let alone tested it.  (I don't think this actually is an issue on other projects.)  So I'm wondering if it would be a good idea to ask that reviews give some indication of the nature of the review?

I don't have a lot of Open Source projects example that I can post right now, but it is quite usual for projects to have their own Issue Template or PR Template. I think it's even more important in an open source project since it gets contribution from a lot of people with different backgrounds.
A few examples that focus mainly on issue templates:

https://github.com/docker/docker/blob/master/CONTRIBUTING.md
https://github.com/atom/atom/blob/master/CONTRIBUTING.md
https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md

We documented the Review process and what terminology we use.
But yes, we could probably extend it to a Tested, LGTM when it was tested and not just reviewed.
I wouldn't go as far as making a template for that. As long as the wording we use is defined and documented.

@corneadoug can you also add PR status in readme ?
[![Issue Stats](http://issuestats.com/github/apache/incubator-zeppelin/badge/pr)](http://issuestats.com/github/apache/incubator-zeppelin)
should look like this in the output

Thanks

:+1: for bookmarklet

@r-kamath what would be the used of that badge?

@corneadoug similar to build status this badge is useful for checking the pr status

Looks good to me. Tested bookmarklet works really well.
FYI, According to issuestat.com that @r-kamath has mentions,
Time distribution of pr close in apache zeppelin is look like

while other well known projects like Apache spark

and Apache flink

.

Then, Merging if there is no more discussions


GitHub check for "failures all known"

A few times in CI Council we've discussed how we enforce that developers reference the tracking issues for failing tests.
One possible way to enforce this would be to hook into the runfo triage issues and produce a GitHub Check on PRs to track the failing tests. The check would be green there were no failures or if every job (for Timeline queries) or test (for Test, Helix Log, etc. queries) that failed matched an open triage issue. Otherwise, the check would be red. This would enable better tracking for ensuring that PRs correctly reference why there are failing tests before merging on red.

I've had similar thoughts. I do think whatever system we decide on for tracking test failures is going to have a behavior similar to this. Probably the simplest approach to start with is a bot that just opens a comment box detailing the failures which are known / not known.


Add pre-commit and its dependencies

pre-commit is "a framework for managing and maintaining multi-language
pre-commit hooks". More info here: https://pre-commit.com
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[X] Fits CONTRIBUTING.md.

I only found out after reviewing that this package already exists: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/version-management/git-and-tools/pre-commit/default.nix


Running Error

Description:
I do this instructor:
Fork repository
cd solrkit
npm install
npm link
go solrkit/example/talks
npm install
npm link solrkit
npm start

nothing loaded and npm say error.
npm version
5.5.1
Steps to replicate:
JSON Data required to replicate, if applicable:

Failed to compile.
/repo/solrkit/example/art/node_modules/<EMAIL_ADDRESS>(3422,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'a' must be of type 'DetailedHTMLProps<AnchorHTMLAttributes, HTMLAnchorElement>', but here has type 'DetailedHTMLProps<AnchorHTMLAttributes, HTMLAnchorElement>'.


Sysbox installer: Add jq dependency for postinst/postrm debian scripts or replace jq with shell commands

You replaced the jq script in the config debian script with shell commands. But the jq command is still used within the postinst and postrm scripts.
Please add jq debian package as dependency or replace jq with shell commands in postinst and postrm scripts as well.

I think jq will need to be added as a dependency then, because the Sysbox installer needs it to configure the Docker daemon.

jq has always been a Sysbox dependency, and that's still the case.
The changes we did in the latest release allowed us to remove jq from the debian-preconfig installation phase to avoid some dependency issues by following debian's package-policy guidelines. But jq is still a dependency for all other installation phases (preinst, postinst, etc).
@nudgegoonies, can you please elaborate what you mean?
$ sudo apt-get install ./deb/debbuild/ubuntu-focal/sysbox-ce_0.3.0-0.ubuntu-focal_amd64.deb
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'sysbox-ce' instead of './deb/debbuild/ubuntu-focal/sysbox-ce_0.3.0-0.ubuntu-focal_amd64.deb'
The following additional packages will be installed:
  jq
The following NEW packages will be installed:
  jq sysbox-ce
0 upgraded, 2 newly installed, 0 to remove and 252 not upgraded.
Need to get 0 B/26.8 MB of archives.
...

Sorry, i only looked into the Depends line and not into the Pre-Depends line which - was my recommendation :man_facepalming:
Can be closed!


Blogpost: Introduce property "AspectRatio"

Publish a blogpost and explain the new property "AspectRatio"

we have to discuss how we should handle the problem that Access does not update the height / width attribute of the browser control.

Option 1 : give a code example only in the docs how to handle the problem
Option 2 : include code in BAC to show how to handle the problem

we have to discuss how we should handle the problem that Access does not update the height / width attribute of the browser control.

Option 1 : give a code example only in the docs how to handle the problem
Option 2 : include code in BAC to show how to handle the problem

Lets discuss this here

Blogpost published on 16.01.2022
https://blog.team-moeller.de/2022/01/better-access-charts-das.html


Implement a .realActive() method

Implement a method for showing an html element's active state. cy.realActive() will put the element in the active state to check for active styling/behavior.
Use case: To check css active state styles/behavior of an element.
cy.get('button').realActive()

:tada: This issue has been resolved in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Panic in bdt when udp recv zero bytes data

The panic msg as follows:
"thread 'unnamed' panicked at 'index out of bounds: the len is 0 but the index is 0': component/cyfs-bdt/src/interface/udp.rs:284

By reviewing the code, it is found that there may be problems with the code at the following location:
https://github.com/buckyos/CYFS/blob/1fb3857bee27e9ca58ff53710074804fc5a648e7/src/component/cyfs-bdt/src/interface/udp.rs#L283
https://github.com/buckyos/CYFS/blob/1fb3857bee27e9ca58ff53710074804fc5a648e7/src/component/cyfs-bdt/src/interface/udp.rs#L353
It is necessary to check whether the length of the data received by UDP is zero.

It seems like someone scans the UDP port, and send the zero bytes package.
It has been fixed, commit at: eb379336e05b1a34db34b6d2c360d48a25d1fbe4


Help with using Awesome config on Arch

Hello, when I try to start awesome using startx it gives some error regarding files settings.json and desktop.json

Try creating a folder at ~/.cache/awesome/json, this is where these files you be written when setting up awesome

I would recommend you to try the latest commit as i have added garbage collection and now the missing folders will be automatically created


Unable to create scenes using front end UI.

Home Assistant release with the issue: 0.104.0b3
Last working Home Assistant release (if known): n/a
Operating environment (Hass.io/Docker/Windows/etc.): hass.io
Integration:
Description of problem:
Unable to create new scene in the front end. Creating with YAML works as expected.
Steps Taken

Test Adding Scene from Front end UI with existing scenes in YAML.

Unable to save new scene using the Front end UI.
Clicked Save, button goes away, scene name never updates.
Refresh scene list, new scene not listed.
Restart HA, new scene still not in list.

Test Adding Scene from Front end UI with no existing scenes.

Removed all scenes from YAML configuration files.
Still, unable to save new scene using the Front end UI.
Clicked Save, button goes away, scene name never updates.
Refresh scene list, new scene not listed.
Restart HA, new scene still not in list.

Traceback (if applicable):
Relevant Logs during scene creation.
2020-01-13 09:46:58 DEBUG (MainThread) [homeassistant.components.http.auth] Authenticated <IP_ADDRESS> for /api/config/scene/config/1578926818642 using bearer token
2020-01-13 09:46:58 DEBUG (MainThread) [homeassistant.components.http.view] Serving /api/config/scene/config/1578926818642 to <IP_ADDRESS> (auth: True)
2020-01-13 09:46:58 DEBUG (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: domain=scene, service=reload, service_data=>
2020-01-13 09:47:12 DEBUG (MainThread) [homeassistant.components.websocket_api.http.connection.140122678662992] Received {'type': 'call_service', 'domain': 'scene', 'service': 'apply', 'service_data': {'entities': {'light.eaton_halo_rl5601_02a7a52f_1': {'min_mireds': 153, 'max_mireds': 500, 'off_brightness': None, 'friendly_name': 'Eaton Halo_RL5601 2fa5a702 level, light_color, on_off', 'supported_features': 35, 'state': 'off'}, 'light.eaton_halo_rl5601_02ae8da4_1': {'min_mireds': 153, 'max_mireds': 500, 'off_brightness': None, 'friendly_name': 'Eaton Halo_RL5601 a48dae02 level, light_color, on_off', 'supported_features': 35, 'state': 'off'}, 'light.group_great_room_windows': {'min_mireds': 153, 'max_mireds': 500, 'friendly_name': 'Group Great Room Windows', 'supported_features': 35, 'state': 'off'}}}, 'id': 36}
2020-01-13 09:47:12 DEBUG (MainThread) [homeassistant.core] Bus:Handling <Event call_service[L]: domain=scene, service=apply, service_data=entities=light.eaton_halo_rl5601_02a7a52f_1=min_mireds=153, max_mireds=500, off_brightness=None, friendly_name=Eaton Halo_RL5601 2fa5a702 level, light_color, on_off, supported_features=35, state=off, light.eaton_halo_rl5601_02ae8da4_1=min_mireds=153, max_mireds=500, off_brightness=None, friendly_name=Eaton Halo_RL5601 a48dae02 level, light_color, on_off, supported_features=35, state=off, light.group_great_room_windows=min_mireds=153, max_mireds=500, friendly_name=Group Great Room Windows, supported_features=35, state=off>

Additional information:

Do you have your scenes.yaml imported in configuration.yaml?

I was having exactly the same behaviour until i followed https://www.home-assistant.io/docs/scene/editor/#updating-your-configuration-to-use-the-editor

@Jc2k Thanks. I didn't search hard enough for that documentation. Closing this.
I thought removing the configuration.yaml value !include_dir_list scenes/ would be enough to "reset" them. Added scenes.yaml in there, and they work now.


Sync: Saved Sites timestamps

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #3526   👈

This comment was auto-generated by Graphite.


Log SAML error message when Issuer name does not exists in SAML request

Description
Better to log the SAML error message in the Identity Server when the "Issuer" is not present in the SAML request. (SPEntityID attribute not present)
ex: <samlp:Issuer xmlns:samlp="urn:oasis:names:tc:SAML:2.0:assertion" />

SAML Response return the Status message as below, which can be logged in the Identity Server to improve error traceability
<saml2p:Status>
				<saml2p:StatusCode Value="urn:oasis:names:tc:SAML:2.0:status:Requester" />
				<saml2p:StatusMessage>Issuer/ProviderName should not be empty in the Authentication Request.</saml2p:StatusMessage>
		</saml2p:Status>

Tested Environment
IS 5.8.0 m6

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


NIFI-9309: Include a uiOnly flag when requesting flow for a given pro…

…cess group. In that case, do not include the property descriptors, property values, etc. for Processors. When fetching Variable Registry, improved logic to cache the VariableImpact for each property value instead of parsing/recreating it every time. When fetching bulletins for a component, avoid filtering through all components' bulletins and instead only look at bulletins that might pertain to the appropriate component

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks for this improvement @markap14! The concept seems like a helpful improvement, but what do you think about changing the name of the flag to something different than uiOnly?
Although the flag is descriptive in terms of the purpose, it seems somewhat more narrow than necessary. Another REST API consumer may make use of the resource for some other purpose where a more optimized response is preferable, but not be related to a user interface. What do you think about something along the lines of minimal, truncated, or summarized?  It is a minor thing when it comes to implementation, but some more descriptive of the function, versus the implied consumer, seems like it would be helpful.

@exceptionfactory i did consider some alternatives. I went with uiOnly because I specifically wanted to make it very clear that no other consumer should be using it. Ever. Because the point of it is that we can change what gets returned for that response at all. If we called it minimal, truncated, summarized, etc. even with that fact documented, a consumer would be likely to assume that if a field is populated in version 1.15.0, then in 1.15.1 it should be populated as well, etc.
Typically, we do use a flag of verbose, where that can be set to false in order to bring back minimal details. But we maintain backward compatibility between versions there. Here, we do not want to guarantee any sort of backward compatibility between versions.


[openpathsampling] 0.9.4

OpenPathSampling 0.9.4

@Lnaden : looks like everyone else is merging their own here; I don't have access, and you merged the last OPS update -- mind doing this one, too?
(Near future, OPS will move OpenMM to an optional dependency and we'll move to conda-forge -- in other words, before you offer, I don't think I need commit access here).

Got it! And thanks for also answering my follow up question!


[GitHub] Add ability to merge pull requests

Extension
https://www.raycast.com/raycast/github
Description
As a user of the Raycast extension, I would love to be able to merge pull requests directly from the Raycast interface. This would save me time and allow me to streamline my workflow by avoiding the need to switch between multiple tools. Adding this functionality would be a great enhancement to the Raycast extension and would greatly improve the user experience for those who frequently work with pull requests on GitHub.
Who will benefit from this feature?
No response
Anything else?
No response

It is possible to merge pull requests with the extension provided you have the rights (cf this file)


Building your own NetworkClient

Consider the following file:
using System;
using UnityEngine;
using Mirror;

public class GameServerConnectionToMasterBehaviour : MonoBehaviour
{
    public bool AutoStartServer = true;
    public string AutoStartMasterIP = "<IP_ADDRESS>";
    public int AutoStartMasterPort = 7777;

    private NetworkClient Client;

    private void Awake()
    {
        if (AutoStartServer)
        {
            DontDestroyOnLoad(gameObject);
            Client = new NetworkClient();
            Client.hostPort = 7778;
            RegisterClientMessages();
            Client.Connect(AutoStartMasterIP, AutoStartMasterPort);
        }
    }

    private void RegisterClientMessages()
    {
        Client.RegisterHandler(MsgType.Connect, OnClientConnectInternal);
        Client.RegisterHandler(MsgType.Disconnect, OnClientDisconnectInternal);
        Client.RegisterHandler(MsgType.NotReady, OnClientNotReadyMessageInternal);
        Client.RegisterHandler(MsgType.Error, OnClientErrorInternal);
        Client.RegisterHandler(MsgType.Scene, OnClientSceneInternal);
    }

    private void OnClientSceneInternal(NetworkMessage netMsg)
    {
        throw new NotImplementedException();
    }

    private void OnClientErrorInternal(NetworkMessage netMsg)
    {
        throw new NotImplementedException();
    }

    private void OnClientNotReadyMessageInternal(NetworkMessage netMsg)
    {
        throw new NotImplementedException();
    }

    private void OnClientDisconnectInternal(NetworkMessage netMsg)
    {
        throw new NotImplementedException();
    }

    private void OnClientConnectInternal(NetworkMessage netMsg)
    {
        throw new NotImplementedException();
    }
}

This file is pretty similar to the basics of the NetworkManager, yet it throws an error on Client.Connect(). The following error occurs whether or not there is a NetworkManager in the scene:
NullReferenceException: Object reference not set to an instance of an object
Any ideas? The Master Server in this case does not throw any errors or output any messages (it is using a NetworkManager).
Desktop:

OS: Windows
Build target: Windows
Unity version: 2018.2.14
Mirror branch: mirror

Try moving the Client = new NetworkClient(); outside the if(AutoStartServer). This will ensure that Client gets populated with a NetworkClient as long as Awake() is called.

Turns out before you create a new NetworkClient you need to Transport.layer = new TelepathyWebsocketsMultiplexTransport();. Seems obvious in retrospect, but Mirror should probably look for this and show a more specific error message.
Also, for posterity, you need to destroy it when your application quits, or Telepathy/Mirror will act weird between sessions:
protected void OnApplicationQuit()
{
    Transport.layer.Shutdown();
}


Update to latest version of the Checker Framework, and other maintenance

Issue #, if available:
n/a
Description of changes:
The purpose of this PR is to bring this repository up-to-date with the latest version of the Checker Framework. The changes are relatively minimal - the only interesting thing is the need to include a copy of ErrorProne's javac compiler if running the tests on a Java 8 JVM.
Since this repo was last updated, https://github.com/typetools/checker-framework/issues/2147 has been fixed. That meant that I could delete the workaround in ComplianceAnnotatedTypeFactory for that problem - the annotations on enums in the stub files are now be sufficient. The KMS stub isn't committed to this repo (for legal reasons, I assume?), but you can remove the comment above the definition of DataKeySpec that refers to that issue, too.
I also cleaned up the repo a bit so that it's possible to build the code and run the tests without signing/deployment keys, which should definitely be possible.
Finally, I updated to the latest versions of Gradle (for building) and the AWS SDK (for testing).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@seanmcl

I also added an explicit list of the qualifiers used by the typechecker to avoid classloader problems.


Sheets with hyperlinks and data validations are corrupted

I was trying to convert a file that had both an hyperlink and data validations. For some obscure reason, Excel didn't want to open the resulting file. Putting the links after the data validations in the sheet's XML fixed the issue.
I'm not familiar enough with exceljs to write a test for this issue.

Good catch. Don't worry, I'll add a unit test for this


fix(CLDX-128): update tasks as per testing of push-to-dev-portal pipeline

This commit fixes bugs for the tasks required for push-binaries-to-dev-portal after testing

/ok-to-test


Allow specifying a custom modifier on Initiative rolls

When the turn rolls over to a new one, it resets the multi action penalty rather than maintaining it.
Also there's nowhere to easily add bonus dice to initiative without modifying attributes/skills (say from a quick claw or an awareness charm)

When the turn rolls over to a new one, it resets the multi action penalty rather than maintaining it.

This one is working as intended since the penalty is based on how many actions have been taken in a given round.

As a workaround, the DM can edit the initiative value after the roll.

Would be nice to have a rolling turn pass feature then.
In core each participant takes a turn using an action in order of initiative, and it keeps looping around till nobody takes an action and the round passes to a new one.
Replicating this in foundry means you either don't pass turns using the foundry's interface, or you spend a lot of time manually fiddling with initiative.  At that point you might as well do initiative manually instead of using the built-in foundry tool.

You can navigate back to the start of a turn to get the right behavior without resetting the tracker but yeah, there's definitely room for improvement to make this less annoying. There will probably be a button or some prompt to go back to the first participant in a turn.

Added as a field in Actor settings (cog icon in Biography)


[T4A6][T11-B4] Tan Jun Hao

Ready for review

@e0003083 Some comments added. Please close the PR after reading comments.
Good job! remember to use imperative form for commit messages (e.g. "add" instead of "added")


Authorization Headers not scrubbed (Django Rest Framework)

Not 100% sure if this is a bug or feature request
Environment
How do you use Sentry?
Self-hosted 21.7.0 6a3c273
Which SDK and version?
Python 3.8.12
sentry-sdk 1.4.1
Django 3.2.3
Django Rest Framework 3.12.4
Steps to Reproduce

Create a DRF project using the versions provided above and have authenticated calls
Add sentry with init_sentry:

init(
        dsn=dsn,
        attach_stacktrace=True,
        request_bodies="always",
        with_locals=True,
        integrations=[
            DjangoIntegration(),
            LoggingIntegration(level=logging.DEBUG, event_level=logging.ERROR),
        ],
        traces_sample_rate=1.0,
        send_default_pii=True,
        release=getenv("API_VERSION"),
        environment=environment,
    )

Run the server and do an authenticated request

Expected Result
The Authorization header is not sent to Sentry
Actual Result
Authorization header is sent to Sentry
My investigation
The headers are added as part of the request object here. The _filter_headers method at the end of the same file seems like what I need, but it is not called here.
I see the Ruby Integration has a sanitize_http_headers  option which would achieve what I need.
If I want to open the PR myself which option would be preferable: Calling _filter_headers, adding a sanitize_http_headers option, or something else?
Thank you for your time

Looking more into the code and testing, I realize send_default_pii controls whther to filter the Authorization header or not.
It would be best to have a separate setting because we might still want to know about the users without leaking their tokens, but it solves my issue for now.

Thanks for writing in. We will improve our docs around this.

we have an event scrubber now that should take care of this
https://docs.sentry.io/platforms/python/data-management/sensitive-data/#event_scrubber


Added Toast on Successful Logout

Description
Added Toast on Successful Logout
Fixes #2764 Toast on Successful Logout
What changes did you make and why?
Added Toast when user log out so that they know they have been logged out.
Tests performed
Tested betaDebug on Xiaomi Mi A1 with API level 28 stock android.

Codecov Report

Merging #2765 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2765      +/-   ##
=========================================
- Coverage    2.83%   2.83%   -0.01%
=========================================
  Files         268     268
  Lines       12774   12775       +1
  Branches     1129    1129
=========================================
  Hits          362     362
- Misses      12387   12388       +1
  Partials       25      25

Impacted Files
Coverage Δ

...free/nrw/commons/theme/NavigationBaseActivity.java
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14a9c1...5529ad0. Read the comment docs.

@domdomegg Sure :)

By following the discussion below the issue, this solution is not preferred.


No LICENSE file

I just noticed that none of our repos have a LICENSE file nor are stated to be under any specific license. That means that they are not free software, as per the GitHub rules if I recall correctly.
I would suggest the BSD 3-clause, which is a permissive license (similar to MIT or BSD 2-clause), but which also protects the names of the copyright holders and contributors. It's used in many open source projects nowadays like Tor and Go.

Done. Used a standard BSD 3-clause template. Feel free to propose changes if you like.

SGTM. As long as everyone is fine with giving up their copyright to you :)

@mvdan I don't think it is common to explicitly list all contributors in copyright lines -- is there a standard approach to this? Shall it be Tuura team instead? I admit I'm often confused as to how this should work.

I'd go for Tuura authors, and then listing them in an AUTHORS file as name and e-mail.
See:
https://github.com/golang/go/blob/master/LICENSE
https://github.com/golang/go/blob/master/AUTHORS
I know this sounds overly complex, but it's really the easiest way to do it. Another way to do it would be to have a license header per-file with the copyright holders, which you can bet is more verbose and complicated.
I'll only contribute to this repo for now so I'm not worried myself about what you do with the other repos, but you might want to do the same.

I'd go for Tuura authors, and then listing them in an AUTHORS file as name and e-mail.

This looks like a good solution, let's use it. (Apparently things get far more complicated when AUTHORS contains companies, which brings CONTRIBUTORS into play. Crazy.)
I wouldn't want to bother with per-file copyright holders.

Yeah, there is also the world of CLAs and giving up copyright ownership, and things can get ugly.

OK, done.
@mvdan @jrbeaumont Please add your names and emails you'd like to use to AUTHORS.

Daniel Martí<EMAIL_ADDRESS>

<EMAIL_ADDRESS>I apologise I would do this myself but I am currently away without any decent access to a computer.

@jrbeaumont No problem, I added you to the list.

@mvdan I wonder what are the usual rules for qualifying as an author. If I go and add a comment to the Go project, that wouldn't be enough to suddenly get listed as an author, or would it?

I'm not sure, actually, and it doesn't specify. Anyone having authored a commit seems like the easiest way to do it.

Somehow it doesn't feel right, because it devalues the list. But then almost everything about copyright & other IP issues feels wrong, so nothing surprising.


About decleaf in Simple3DPoseBaseSMPL24

Hi,
I noticed that there is a layer named decleaf in the inference model:
https://github.com/Jeff-sjtu/HybrIK/blob/e10afb149e10cf721b619b12eb81f02b7ad3c4e0/hybrik/models/simple3dposeBaseSMPL24.py#L109
which does not exist in training model simple3dposeBaseSMPL.
When looking into the code, I found it seems that you extend the joints number from 24 to 29 to calculate the rotation of the five distal joints. Thus I have 2 questions:

Why not use the same methods to solve the leaf joints' rotation during inference time as in training time?
How to get the layer decleaf after I train the model from scratch?

Thanks a lot!

Thanks for clarification!
May I ask which model performs better? Thanks!


common_msgs: 1.11.9-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository common_msgs to 1.11.9-0:

upstream repository: https://github.com/ros/common_msgs.git
release repository: https://github.com/ros-gbp/common_msgs-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: 1.11.8-0

actionlib_msgs

No changes

common_msgs

No changes

diagnostic_msgs
* diagnostic_msgs: Add messages for service used to add diagnostics to aggregator
* Contributors: Michal Staniaszek

geometry_msgs
* clarify the definition of a Vector3
* Contributors: Vincent Rabaud

nav_msgs

No changes

sensor_msgs
* added type mapping and support for different types of point cloud points
* remove boost dependency fixes #81 <https://github.com/ros/common_msgs/issues/81>
* adding a BatteryState message
* Contributors: Sebastian Pütz, Tully Foote

shape_msgs

No changes

stereo_msgs

No changes

trajectory_msgs

No changes

visualization_msgs

No changes

Hold for coordinated release


Update API.hpp

Hello!
This will fix error below on Microsoft Visual Studio Community 2022 (64-bit) - Current Version 17.7.1
Error	C2327	'reframework::API::m_sdk': is not a type name, static, or enumerator
I just updated and could not compile my project because of that.

Thanks. Don't even know why latest VS did this.


make CVSSv3 score mandatory no more

It should be possible to create a flaw without CVSS3 provided.
This was identified as a discrepancy in the required OSIDB functionality during the IR acceptance testing
https://docs.google.com/spreadsheets/d/1JXjtwpCbpQesXWOQCkuh8rzkR3MbweM2zuEcBlX-bpk/edit?usp=sharing
Closing OSIDB-901

The code LGTM but does this mean that a Flaw can be published without cvss2/cvss3? Or is it more of a draft flaw problem?

Definitely a draft flaw problem. If we had the workflow (OSIM module) we could solve this properly. Actually as I am more thinking about it we might rather turn this into a soft alert instead of completely removing it. I will ask Marian

@Elkasitu so after discussing with Marian I am turning this into a non-blocking alert


Add doc for using Pulumi in Jenkins

Proposed changes
As the PR title says, this adds a doc for Jenkins.
Unreleased product version (optional)
N/A
Related issues (optional)
Related to #598. Needs https://github.com/pulumi/examples/pull/364 since it references an example project from our examples repo.

Should the images be placed in a different directory, aligned with the content directory? E.g. static/images/docs/console/continuous-delivery/jenkins instead of static/images/docs/reference/jenkins?

I placed the images in static/images/docs/reference/jenkins since that's where the current ones are. I can move them all to match the content dir structure in another PR?

Also, I really need https://github.com/pulumi/examples/pull/364 to pass so I can merge that and then this.


feat: send anniversary email notifications 🎂

Description ✏
Closes #474
Describe what this PR does.

sends an email notification that states how many years the given member has been a ColorStack member and congratulations them

Type of Change 🐞

[X] Feature - A non-breaking change which adds functionality.

Checklist ✅

[X] I have done a self-review of my code.
[X] I have manually tested my code (if applicable).
[X] I have added/updated any relevant documentation (if applicable).

Sounds good!

Thanks guys :)


completions for other shells

I only know and use zsh completions, so completions for other shells (bash/fish/etc) would need to be contributed if desired

bash: #8
fish: #6

that's all the major ones covered


feat(embedding): add batch embed size

Solves #375

@marcusschiesser We opted in yesterday to accumulate to batch the text
Then for now I removed the old way wouldn't have many advantages now
So currently the batch size can be controlled by the embed batch size , making it more flexible to the user of how much text will be sent in batches finding a proportion that doesn't get rate limited and fills well the maximum tokens available
The same of the Python package which look to works well
cc: @yisding

Thanks @EmanuelCampos ! Looking good to merge, just fix the conflict please


Traffic Ops Golang Gzip incorrectly sets Content-Type, not Content-Encoding

Traffic Ops Golang is incorrectly setting Content-Type: gzip when it gzips the body, not Content-Encoding: gzip. This violates RFC 7231 and conflicts with the Content-Type set by Handlers.
This is a critical bug, and breaks clients relying on the Encoding or Type to decode or display the data.
Fix is changing https://github.com/apache/incubator-trafficcontrol/blob/13b20c748b9bfe872a3bc3d5d7bec001ab8e4278/traffic_ops/traffic_ops_golang/wrappers.go#L189
w.Header().Set(api.ContentType, api.Gzip) to w.Header().Set("Content-Encoding", api.Gzip)

@rob05c - if this is indeed critical can you apply the 'critical' label?

resolved by #1359


chore(deps): update golang.org/x/exp digest to 1829a12

This PR contains the following updates:

Package
Type
Update
Change

golang.org/x/exp
require
digest
43b7b7c -> 1829a12

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.056%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
1234

Relevant Lines:
1957

💛  - Coveralls


[DOC-11174] Update info about default CC-Version

[DOC-11174] Update info about default CC-Version

Going to merge this low-risk change.


Utilize Graph Library for Tabular Stack Ensembling Representation

@jwmueller , @zhanghang1989
What are your thoughts on adding NetworkX as a dependency?
https://github.com/networkx/networkx
As I work more on the stack ensembling functionality, I find that it becomes increasingly important to have a DAG (Directed Acyclic Graph) representation where each model is a node and each instance of a model taking inputs from another model being an edge.
This is important because if we want to break from the fully densely connected scheme currently in place, then the existing method of tracking edges (kept in each model object, thus requiring loading of the model to check) will not scale.
This will also allow us to easily cut unnecessary models that aren't parents of the final model

@zheng-da Da is working on DGL, which is a graph library using Gluon.
Da, how DGL compare with NetworkX?

DGL is designed for running neural networks on graphs. NetworkX is designed for graph manipulation. If you want a flexible framework for graph manipulation and you don't need to deal with large graphs, I think NetworkX is probably a good fit.

Merged and utilized networkx in #385


Improve performance with large result sets

At the present moment we go through the entire list of Items and render them all, even though comparatively few are actually rendered.
We can improve performance of rendering by simply creating empty list items for those items that won't be visible on the screen.

While this did improve performance a little, after inspecting the project with https://github.com/flamegraph-rs/flamegraph the biggest performance hit is the Printable trait. So we'll look there first.


PROBLEM with bots??

How do I make the bots more realistic or dumber because they just savage you everytime?

Try the MultiOgar-Edited bots. They're a bit smarter, but bots aren't really meant to be played with, more for testing 👍

Howw do i add minions please help

minion (userid) (amount) (name)


Unlock aavegotchi after transferring

An Aavegotchi should be unlocked after a successful transfer. Otherwise we will have a lot of locked Aavegotchis and a potentially bad UX.

This is done.  Commit: fdbf92ad216749bbc2554afa953cf2043f2304d9

Great, closed.

Great, closed.


Fig up hanging

Indeterminate hanging while creating containers during a fig up.
@aanand @bfirsh I caught hanging behaviour while running with the verbose option, but I haven't managed to figure out the conditions to reproduce. Here's the output right up until the hanging starts:
Creating project_container_1...
docker containers <- (all=True)
docker containers -> (list with 21 items)
docker images <- (name=u'project_container')
docker images -> (list with 1 items)
docker create_container <- (name=u'project_container_1', image=u'project_container', environment={}, command='./figrun.sh', volumes={u'/code': {}}, ports=[u'4188'])
docker create_container -> {u'Id': u'036c7d5c45582068dfaea2ccf04c22b3825b126a9c8ae6577c6ee8bacbd4a827',
 u'Warnings': None}
docker inspect_container <- (u'036c7d5c45582068dfaea2ccf04c22b3825b126a9c8ae6577c6ee8bacbd4a827')
docker inspect_container -> {u'AppArmorProfile': u'',
 u'Args': [],
 u'Config': {u'AttachStderr': True,
             u'AttachStdin': False,
             u'AttachStdout': True,
             u'Cmd': [u'./figrun.sh'],
             u'CpuShares': 0,
             u'Cpuset': u'',
             u'Domainname': u'',
             u'Entrypoint': None,
...
docker containers <- (all=False)
docker containers -> (list with 20 items)
docker containers <- (all=False)

The hanging can be stopped by running fig ps in another terminal session, at which point the fig up immediately continues (but will sometimes fail again further on).
If left to hang the command exits with the following stack trace:
Traceback (most recent call last):
  File "/usr/local/bin/fig", line 9, in <module>
    load_entry_point('fig==1.0.1', 'console_scripts', 'fig')()
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/cli/main.py", line 31, in main
    command.sys_dispatch()
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/cli/docopt_command.py", line 21, in sys_dispatch
    self.dispatch(sys.argv[1:], None)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/cli/command.py", line 28, in dispatch
    super(Command, self).dispatch(*args, **kwargs)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/cli/docopt_command.py", line 24, in dispatch
    self.perform_command(*self.parse(argv, global_options))
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/cli/command.py", line 56, in perform_command
    handler(project, command_options)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/cli/main.py", line 427, in up
    insecure_registry=insecure_registry,
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/project.py", line 174, in up
    for (_, container) in service.recreate_containers(insecure_registry=insecure_registry):
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/service.py", line 199, in recreate_containers
    container = self.create_container(insecure_registry=insecure_registry, **override_options)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/service.py", line 178, in create_container
    return Container.create(self.client, **container_options)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/fig/container.py", line 37, in create
    response = client.create_container(**options)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/docker/client.py", line 526, in create_container
    return self.create_container_from_config(config, name)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/docker/client.py", line 533, in create_container_from_config
    res = self._post_json(u, data=config, params=params)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/docker/client.py", line 236, in _post_json
    return self._post(url, data=json.dumps(data2), **kwargs)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/docker/client.py", line 73, in _post
    return self.post(url, **self._set_request_timeout(kwargs))
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/requests/sessions.py", line 500, in post
    return self.request('POST', url, data=data, json=json, **kwargs)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/requests/sessions.py", line 457, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/requests/sessions.py", line 569, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/requests/adapters.py", line 422, in send
    raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='<IP_ADDRESS>', port=2376): Read timed out. (read timeout=60)

Thanks so much for tracking this down, @mikekelly! We'll investigate...

no worries. If I figure out how to reproduce I'll drop details here

If it helps, we have 31 containers. If there's any other info about our setup that would help you let me know.

I'm occasionally able to reproduce this, but not at all reliably: what I've done is create a fig.yml with 12 dummy containers in it which just sleep infinity, and run:
$ while true; do fig --project-name app${RANDOM} up -d; done

which just creates loads of containers forever. Eventually, one will hang, which as you say can be stopped by typing docker ps in another terminal.
Interestingly, while cleaning up (docker rm -f $(docker ps -q)), I experienced exactly the same hanging, which I was able to stop in exactly the same way - furthering my suspicion that this is a problem with the Docker daemon.

I have a hunch that a full disk might be causing the same error for myself:
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='<IP_ADDRESS>', port=2376): Read timed out. (read timeout=60)

Having the same problem, timeouts with the following:
requests.exceptions.Timeout: HTTPSConnectionPool(host='<IP_ADDRESS>', port=2376): Read timed out.

Am running this on OS X with the boot2docker VM, so I started that up in terminal mode in VirtualBox and found that I am indeed out of disk space on that machine, like @jn2009 hinted. I will repartition the VM and see if that makes a difference.

@cank Same environment here, I have been playing around with machine, fig, and boot2docker and this has been a recurring error in OSX. I've decided to move on and use Ubuntu instead.
If cleaning your drive doesn't help (I don't remember it being particularly helpful to myself) Might not be a bad idea to ssh in and try to setup fig within the boot2docker vm, then see if running fig from the command line prompt in the vm changes anything.
Might help to isolate the problem.
So I'm guessing docker ps works but not fig up for you as well?

Im having the same problem.  I had to nuke the whole box and recreate.

+1

I do experience the same issue when starting a set of containers where one is "media"-container that is only used as a volume with a rather large image (~ 2.2 GB).
I do believe that the timeout of 60 seconds is just to small for moving all that data (on a slow vm). But I am not sure because I have not figured out yet how I can increase the timeout for a quick test.
But I do now for sure that it does work if use a smaller image ( < 200 MB).

I have experienced a similar issue in docker-compose and have root caused it.  The issue I have is that I use volume data containers.  The intermediate container has no timeout, so fig locks up forever.  I have produced a small workaround at http://paste.fedoraproject.org/201072/69966901 .  I have found this only affects containers that have volume_from in 20 hours of testing/debug.
I believe the docker daemon is busted.  the Docker API wait command is not returning because wait defaults to wait until the container exits, because docker believes the containers are still running (as shown via ps  http://paste.fedoraproject.org/201073/26997245).  However, docker thinks the container is both running and not running.  See http://paste.fedoraproject.org/201074/97377142.
Regards
-steve

This is still an issue for me. Sometimes docker-compose up just hangs.
docker-compose version 1.5.2
docker version 1.7.1
is there a fix or workaround? Upgrading is not really an option for me at this point in time.
@sdake - The links you posted doesn't seem to be valid anymore.

You can run with --verbose to see which API call is hanging. There is a known issue with using tty: True, but otherwise we haven't see many reports of this recently.
I'm not sure how you plan to get the fix if you can't upgrade.

Always happens . Five or Six times a day.


Make sure all Linear layers respect bias argument

Hi @rusty1s,
When I made the #1248 PR, I had originally proposed both root and neighbor transforms have an additive bias. I'm not sure if this was intentionally hardcoded as False but I think it's more intuitive if both transforms respect the bias argument.
Thanks!

You're spotting is on point :P I'm not sure that's really needed though. IMO, lin_l(h) + lin_r(x) does not need two bias vectors, since either lin_l or lin_r can learn the overall bias added to the output.

@rhsimplex What's your take on that? Why are two bias values needed here?

I think you are right, sorry!


Check for the own updates

Add check for the own updates when calling firmware update operation for any model, and warn user in case there is a newer release available.
The motivation is here to make sure, that the latest update procedure is used, or at least the user is warned that the new release is available. The check for the latest firmware is done anyway, thus this will not make any unexpected network calls.
To reiterate, the check for the own updates should be done only on the firmware update operation calls (regardless of the model), not on the every invocation.
Cases, where this would help avoid problems:

https://support.nitrokey.com/t/update-nk3-not-working/3950/10?u=szszszsz

I would try to implement this

There already is a min pynitrokey version in the firmware-update container: https://github.com/Nitrokey/pynitrokey/blob/0cfa85d2ebd15eac2044573516ec9a2907e9a05d/pynitrokey/nk3/updates.py#L180
This could be extended to inform the user about the most recent available version

So it should be checked wether the current pynitrokey version is older
than the latest version (as per git tags)
and print a warning to the user if this is the case. Am I right?
As szszszsz stated:

when calling firmware update operation for any model

Just to be sure I dont miss any, is the following list complete?

https://github.com/Nitrokey/pynitrokey/blob/master/pynitrokey/cli/update.py#L36

https://github.com/Nitrokey/pynitrokey/blob/master/pynitrokey/cli/nk3/__init__.py#L420

https://github.com/Nitrokey/pynitrokey/blob/master/pynitrokey/nethsm/__init__.py#L1075

https://github.com/Nitrokey/pynitrokey/blob/master/pynitrokey/cli/nethsm.py#L1174

https://github.com/Nitrokey/pynitrokey/blob/master/pynitrokey/cli/pro.py#L113

https://github.com/Nitrokey/pynitrokey/blob/master/pynitrokey/cli/start.py#L187

https://github.com/Nitrokey/pynitrokey/blob/master/pynitrokey/cli/storage.py#L145

Just to be sure I understood everything right:
It should be checked wether the current pynitrokey version is older than the latest version (as per e.g. git tags)
and print a warning to the user if this is the case.
Second, as szszszsz stated:

when calling firmware update operation for any model

Just to be sure I don't miss any, is the following list of update operations (where the version should be checked) complete?
https://github.com/Nitrokey/pynitrokey/blob/0cfa85d2ebd15eac2044573516ec9a2907e9a05d/pynitrokey/cli/update.py#L36
https://github.com/Nitrokey/pynitrokey/blob/0cfa85d2ebd15eac2044573516ec9a2907e9a05d/pynitrokey/cli/nk3/__init__.py#L420
https://github.com/Nitrokey/pynitrokey/blob/0cfa85d2ebd15eac2044573516ec9a2907e9a05d/pynitrokey/cli/pro.py#L113
https://github.com/Nitrokey/pynitrokey/blob/0cfa85d2ebd15eac2044573516ec9a2907e9a05d/pynitrokey/cli/start.py#L187
https://github.com/Nitrokey/pynitrokey/blob/0cfa85d2ebd15eac2044573516ec9a2907e9a05d/pynitrokey/cli/storage.py#L145
I'm unsure which one is the correct one in the case of the following two:
https://github.com/Nitrokey/pynitrokey/blob/0cfa85d2ebd15eac2044573516ec9a2907e9a05d/pynitrokey/nethsm/__init__.py#L1075
https://github.com/Nitrokey/pynitrokey/blob/0cfa85d2ebd15eac2044573516ec9a2907e9a05d/pynitrokey/cli/nethsm.py#L1174

Thanks for looking into this!  From my point of view, we can omit the NetHSM because we only call a simple REST API endpoint that is not very likely to change or cause issues.  For the NK3, we now have a mechanism to ensure a minimum pynitrokey version so I’m not sure if we need this additional check.  We should discuss this tomorrow and get back to you to make sure that we’re on the same page here.

Okay, so we would like to add this for the pro, storage, start and fido2 update initially.  Users should be warned if their installation is outdated but should be able to continue at their own risk.  There already is some code to check the latest release of a GitHub repository in pynitrokey.updates that you should be able to re-use (something like Repository("Nitrokey", "pynitrokey").get_latest_release()).

should be able to continue at their own risk

How should I go about this?
Should there be

an interactive prompt like "continue with outdated version? [y/N]"
an cli option like --force or --ignore-version similar to --experimental of nitropy storage update
an environment variable to allow ignoring outdated versions for scripting

In my opinion an combination of (cli parameter/environment variable) and interactive prompt seems optimal as it still allows ignoring the warning in e.g. scripts while still prompting users if they are sure to continue.

From my point of view, an interactive prompt would be sufficient because updates should not be automated.  Though I see that start update already -y (yes) option.  @daringer Is this really a supported use case?

I guess start update is a "historically grown" feature :grin:
I would also suggest to have an interactive prompt.

Ok, so I only add the interactive prompt.


Having some issues creating pages

Hey @Devorein, I've been trying to create a collection view page and i've been having some trouble. it goes through without any errors, but when I check notion no page has been created... I've included the logs & code.

Am I doing something wrong here? My apologies if I am missing something obvious.
EDIT:  I thought I might add in yes, I have tried restarting notion and checking it on another device

Hey seems like youre missing just a single thing. Please call space.executeOperations at the e d to persist it in notions db. Sorry for that trouble. If you face any other problems, feel free to ask.

Thanks for the speedy reply,
all working fine now :)

Awesome. Glad to hear that.


Fix(CX-3670): display artworks in 2/3/4 columns

The type of this PR is: FIX

This PR solves CX-3670
Description

Display artworks in 2/3/4 columns depending on the screen size
https://user-images.githubusercontent.com/36167539/235716901-58fc53bf-4fd2-402d-88d1-7e713509d571.mov

One think I can think of is keeping the aspect ratio and the same UX across the different surfaces we display artworks


Landing Zone Peering to Hub MI Permissions

Landing Zone policy for creating a new vnet in the landing zone and subsequently peer that vnet to the vhub fails because of a permission error. When the vnet policy is deployed a new managed identity is created as the scope of that landing zone subscription. But that managed identity is not granted contributor access to the Platform/Connectivity subscription. Is it expected this permission update is a manual process?
Create policy to deploy-vnet-hubspoke and scope it at the landing zone subscription.
Identity type is SystemAssigned

This is expected. When you assign a policy at the landing zone (or child scopes to landing zones) that requires access to the platform side - such as policy to peer networking from a subscription in the landing zone to the connectivity subscriptio, the managed identity must have access also to the connectivity subscription/resource group.

This is expected. When you assign a policy at the landing zone (or child scopes to landing zones) that requires access to the platform side - such as policy to peer networking from a subscription in the landing zone to the connectivity subscriptio, the managed identity must have access also to the connectivity subscription/resource group.

Ok - If this is expected that is fine. Just has to be dealt with after the policy deployment and part of operation documentation. Thank you for the response.

Ok - If this is expected that is fine. Just has to be dealt with after the policy deployment and part of operation documentation. Thank you for the response.


Please add example for Auth0 integration

Trying to figure out how to combine it with passport-auth0 any help greatly appreciated!!

Have you tried integrating it as an oAuth2 strategy as documented in the oAuth 2 API?

Thanks for commenting on this issue. I think I will just use a similar approach that I used for GraphCool (GraphQL server) with Auth0, using localstorage and setting Bearer JWT token in Passport somehow via passport-jwt and/or passport-auth0
working on various integrations here: easy-graphql-auth
OAuth2 strategy won't work, as Auth0 is itself a wrapper for various OAuth (and other) strategies, ie. a "passport" in itself

Not sure how/where auth({ storage: localStorage }) fits in with the flow below?
In any case, I think this would work:
const feathers = require('feathers/client');
const rest = require('feathers-rest/client');
const superagent = require('superagent');
const hooks = require('feathers-hooks');
const localStorage = require('localstorage-memory');
const auth = require('feathers-authentication-client');

const client = feathers();

// NOTE: the order is important: auth must be configured _after_ rest/socket
client.configure(hooks())
  .configure(rest('http://localhost:3030').superagent(superagent))
  .configure(auth({ storage: localStorage }));

client.authenticate({
  strategy: 'local',
  email<EMAIL_ADDRESS>  password: 'admin'
})
.then(response => {
  console.log('Authenticated!', response);
  return client.passport.verifyJWT(response.accessToken);
})
.then(payload => {
  console.log('JWT Payload', payload);
  return client.service('users').get(payload.userId);
})
.then(user => {
  client.set('user', user);
  console.log('User', client.get('user'));
})
.catch(function(error){
  console.error('Error authenticating!', error);
});

We pretty much just have to replace:
client.authenticate({
  strategy: 'local',
  email<EMAIL_ADDRESS>  password: 'admin'
})
.then(response => {
  console.log('Authenticated!', response);
  return client.passport.verifyJWT(response.accessToken);
})

With something like:
lock
  .subscribeAuthenticated()
  .showLock(displayConfig)
  .onSuccess('signin', (data) => {
    let {
      auth0Token,
      profile
    } = data
    console.log('Authenticated!', data)

    try {
      let payload = await client.passport.verifyJWT(data.auth0Token);
      console.log('JWT Payload', payload);
      let user = await client.service('users').get(payload.userId);
      client.set('user', user);
      console.log('User', client.get('user'));
    } catch (err) {
      console.error('Error authenticating!', error);
    }
  })

I haven't used Auth0 in a while. At a quick glance that looks like it would work but I don't think this totally correct.
You also need to have your own hooks to protect endpoints using the Auth0 JWT. I'm sure it's doable but you'll need to dive into the Auth0 docs to see if they have a way of verifying their JWT on your server. I suspect it's a remote API call because you'd need to know the secret they are signing the tokens with.
Another option (probably the easiest) is to use the Auth0 OAuth2 strategy and you'll get back a Feathers JWT just like with any other OAuth provider.
@kristianmandrup did you get it solved. If so, maybe you could write up a guide? 😁

The Auth0 oAuth2 strategy has been added to the generated application has been added via https://github.com/feathersjs/generator-feathers/pull/254 so all that should be necessary now is to put in your client secret and id.

Awesome thanks! If anyone is interested, here is my attempt at writing various utils for integrating JWT/Auth0 for various use cases...
https://github.com/tecla5/easy-graphql-auth
Feathers App https://github.com/tecla5/easy-graphql-auth/tree/master/packages/feathers-app
Use https://github.com/tecla5/easy-graphql-auth/tree/master/packages/easy-auth0-lock
To display/manage Auth0 lock login dialog
Extend f.ex AjaxAuthConnection: https://github.com/tecla5/easy-graphql-auth/tree/master/packages/http-auth-conn
to integrate Auth0 service with Feathers...

Would like to have authentication-jwt support localstorage as well as "old school" cookie to store/retrieve the jwt token on the client.

To enable localstorage support, we need to add a custom-extractor-function
to load from localstorage if not found in request.
var localstorageExtractor = function(req) {
    var token = null;
    if (localstorage)
    {
        token = localstorage.get('jwt');
    }
    return token;
};

Then register via fromExtractors([array of extractor functions]), which creates a new extractor using an array of extractors provided. Each extractor is attempted in order until one returns a token.
I started writing a more detailed guide in my sample feathers-app

Started developing a feathers-auth0 client/server demo app, using latest feathers-cli (generators) and feathers-client: https://github.com/tecla5/easy-graphql-auth/blob/master/packages/feathers-app/Auth0.md

+1 for reopening
I'm getting an invalid signature error and have been struggling with it for hours. I've used the generator, checked the right signing algorithm is used, client secret is correct.
An example would help sooo much right now 😩


 It's currently possible to define a locale with a parent that is not yet defined. However, in the case of this bug when attempting to create a moment using a child locale with a parent that hasn't been loaded yet or hasn't been defined causes an exception to be thrown during prepareConfig.
This fix first attempts to load the parent locale during defineLocale if it can't be found initially.  If in the case that a moment is created or a locale is set with a child who's parent can't be loaded or hasn't been defined, chooseLocale returns the global locale instead of null. This mitigates the error described in this bug report in the instance the parentLocale can't be located, and follows the same logic when defining a child can't load a parent. I've added a test for this case.
As this is an edge case it may not be necessary, but makes for a nicer experience rather than having an unhandled exception thrown. I considered adding a warning in chooseLocale but this affected a number of tests.
Also, a warning was previously shown to indicate the parentLocale is missing but was removed (assuming due to the ability to define a parent after a child). However, the documentation specifies that it should still show the warning? I'm assuming in this instance the documentation needs updating.
Apologies if these scenarios have already been discussed and addressed.

@ichernev - you should look at this one


[Elrond]: add elrond staking unit tests

Description
Implement Elrond staking from #2674
https://docs.elrond.com/validators/delegation-manager/#delegating-and-managing-delegated-funds
I hide the real private key and changed value of the unit tests since my funds are lock for 9 days, but broadcasting was successful
How to test
Run C++ unit tests
Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[x] I have read the guidelines for adding a new blockchain.

Should we expose elrond codec to C interface or we assume hex encoding + big endian are available on both kotlin/swift side? (see undelegate unit test)

Since we don't have it for Ethereum either, I would say it's acceptable if it is not exposed. If field format has to be well documented in .proto file, and there are some examples in the tests, it's OK.


Make Very Good Cli Github Workflow work with Freezed

https://github.com/VeryGoodOpenSource/very_good_workflows/issues/41


PowerToys Run not working after v0.19.0 Update

Environment
Windows build number: 10.0.18363 build 18363
PowerToys version: 0.19.0
PowerToy module for which you are reporting the bug (if applicable):
PowerToys Run

# Steps to reproduce

Update PowerToys to 0.19.0, try to launh PowerToys Run through the default shortcut (Alt + Space).

# Expected behavior

After clicking the shortcut, search bar should be available.

# Actual behavior

The searchbar is not opened.

I have the same behavior, in this version and the previous version (v0.18.2).
Windows version 1903 (version of operating system 18362.900)

Have you tried deleted the powertoys folder C:\Users\YOUR ACCOUNT\AppData\Local\Microsoft?

Hi boe323,
I've just tried a couple of times, also making an OS rebbot, but unfortunately nothing has changed.

Experiencing the same issue with 0.19.0.
However, for me it is app-dependant.
Where it does not work: Visual Studio Code  MS Excel.
It works in windows itself (when I click the taskbar and then hit assigned hotkey)
It works in total commander or Chrome or Edge or MS Word etc.
I'm pretty sure it used to work in VSCode and Excel before.
PS: also noticed that a change to the hotkey is applied only after I 'close' PowerToys settings.

Installed 0.19.0 (without uninstalling 0.18.2). There were described app-dependant issues.
Uninstalled 0.19.0 via the control panel. Installed 0.18.2. No issues.
Uninstalled 0.18.2. Installed 0.19.0. No issues anymore.

I have similar problems with 0.19.0. I changed the shortcut to ctrl + space, this made me think it is working better but still sometimes it won't open.

I'm having the same issue. Pressing Alt + Space instead opens the context menu for the window.

Have you tried deleted the powertoys folder C:\Users\YOUR ACCOUNT\AppData\Local\Microsoft?

this as change nothing.

Installed 0.19.0 (without uninstalling 0.18.2, i.e. updated). There were described app-dependant issues.
Uninstalled 0.19.0 via the control panel. Installed 0.18.2. No issues.
Uninstalled 0.18.2. Installed 0.19.0. No issues anymore.

I also try and the issue is still there.

Same problem here. Shortcut: Win + Space. O.S version 10.0.19042.330

Installed 0.19.0 (without uninstalling 0.18.2, i.e. updated). There were described app-dependant issues.
Uninstalled 0.19.0 via the control panel. Installed 0.18.2. No issues.
Uninstalled 0.18.2. Installed 0.19.0. No issues anymore.

I've tried this solution too but, after uninstalling 0.19.0 I installed 0.18.2: it seems the PowerToys Run doesn't work too with 0.18.2 now.

In my case doesn't work in Chrome with Ctrl+Space shortcut, and in Chrome ALT+SPACE or Win+Alt+Space (I changed to test) opens de Control Windows Menu, because in that is assigned already it to do that.
Win+Space open the Language Switch, that is a Windows Default Shortcut, I don't know if I can changed that.
PowerToys version 1.91
Windows 10 Enterprise version 2004 19041.329

Win+Space open the Language Switch, that is a Windows Default Shortcut, I don't know if I can changed that.

I have PowerToys Run working with the Win + Space shortcut, mapped to Left Alt + Space using the Keyboard Manager / Remap Shortcuts also included in PowerToys. So it's definitely possible, and fixes one of my biggest usability problems with Windows (I was switching languages quite often by accident).
That said, I'm also finding that the shortcut to launch PowerToys Run occasionally stops working in PowerToys v 0.19.1. Restarting PowerToys didn't work, neither did running PowerToys Run as Administrator, but restarting the computer fixed it.

I've just installare version 0.19.2, but nothing has changed....

hi sorry about this @dielandro89, can you confirm if this repro's in the latest release, 19.2?

hi @dielandro89, are your windows running in admin? also this behaviour isn't one-off, you can't use PT Run at all correct?

hi @dielandro89, are your windows running in admin? also this behaviour isn't one-off, you can't use PT Run at all correct?

hi @saahmedm, my windows are running in admin, I continue not to use PT Run at all

hi @dielandro89, it looks like this is your problem: #4427 , we're still trying to tackle this so please follow the discussion there. The issue is Run isn't running as admin. can you confirm if PT Run launches if your windows are not running in admin?

hi @sakariya, I'm not sure I've got the point. PowerToys is running as
admin, how can i check if my windows (or background apps) are running as
admin?
Despite my previous answer, I'm not sure of this.
Il giorno mer 22 lug 2020 alle ore 01:45 sakariya<EMAIL_ADDRESS>ha scritto:

hi @dielandro89 https://github.com/dielandro89, it looks like this is
your problem: #4427 https://github.com/microsoft/PowerToys/issues/4427
, we're still trying to tackle this so please follow the discussion there.
The issue is Run isn't running as admin. can you confirm if PT Run launches
if your windows are not running in admin?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/4671#issuecomment-662162082,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQETLYPFTSIUDHMGETE3HODR4YSCXANCNFSM4OOADDZA
.


fix: change otel counters to gauges

Counter: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#asynchronous-counter

reports monotonically increasing value(s) when the instrument is being observed. Example uses for Asynchronous Counter: CPU time, which could be reported for each thread, each process or the entire system. For example "the CPU time for process A running in user mode, measured in seconds".

Gauge: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#asynchronous-gauge

reports non-additive value(s) (e.g. the room temperature - it makes no sense to report the temperature value from multiple rooms and sum them up) when the instrument is being observed.

After this PR, for a POST check:

Codecov Report

Merging #177 (07366c8) into main (667706a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   74.77%   74.79%   +0.02%
==========================================
  Files          79       79
  Lines        8792     8792
==========================================
+ Hits         6574     6576       +2
+ Misses       1816     1815       -1
+ Partials      402      401       -1

Impacted Files
Coverage Δ

server/commands/check.go
85.99% <100.00%> (+0.56%)
:arrow_up:

server/commands/list_objects.go
62.20% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Web Gui

Hi.
Exists a web gui that can be integrated in order to read the honeypot data?
Thanks!

Sadly no :(


More automation for configuration

The code is very sensitive to a condition that could be considered an "incomplete" configuration. While region configuration is not strictly necessary for azurectl operation it is not intrinsically obvious when such configuration is necessary and when it is not. At the same time for a user setting up azurectl for the first time it is rather cumbersome to add configuration for each region, Azure currently covers 13 connected regions.
We should be able to probe Azure and add some automation to the setup maybe something along the lines of
azurectl setup account modify --name=account_name --auto-configure-regions
For every region that has a strorage account created it could automatically be added to the config. If multiple storage accounts exist we could ask for the one we should use.

... while I agree with this enhancement request, I'll just add "not for 2.0".

:+1:


DocExtract: several improvements

Accepts Publications as reference section.

Refactors book handling and search.
(closes #959)

Daemon extracts all added pdfs.

Correctly handles PDF/A files.

Adds LIGO and LHCP report numbers to the kb.

Adds the filename of the extracted files in the 999C6f field.

Converts arxiv urls to report numbers

Adds support for hdl identifiers.

Sets a priority on which title form is the most important.
References will be given priority over anything else while Reference
will rank last with Bibliography in between.
That means that if "Bibliography" is found in the text, we assume it is
the reference section and we don't look for a section titles "Reference".

Improves error message when pdftotext is missing.

Signed-off-by: Alessio Deiana<EMAIL_ADDRESS>Tested-by: Samuele Kaplun<EMAIL_ADDRESS>

Note the kwalitee is failing on copyright year, but when I originally made the PR they were correct (2014). Should I really go and amend all 15 files to write copyright 2015 (even if no change happened in 2015?)

@tiborsimko this could be integrated into 1.2

Should I really go and amend all 15 files to write copyright 2015 (even if no change happened in 2015?)

This is bug. Could you please report it to kwalitee package? Thanks

This is bug. Could you please report it to kwalitee package? Thanks

It's actually more funny: although the PR was made in 2014, and refreshed in 2015, the single commit is dated back to 2013 :dancer:

This is superseded by https://github.com/inspirehep/refextract


Fix single string entry

Fixes #37
Not the most elegant fix but it should work.

Hello @bencooper222, thanks for the fix! I have to test it before, or maybe someone could check if the fix is correct? Without any review I can't merge it.

@leonm1 or @cktang88 could you test and review this? It's related to https://github.com/VandyHacks/vaken/issues/94

I re-built the error-overlay-webpack-plugin using the patch from this PR and it worked for my app.
Tested building and intentionally causing an error, the error appeared as expected in the overlay.

@neoziro good to merge, I think?


babe: secondary blocks with VRF

This enables secondary blocks (aura-block) with VRF in BABE. cc @burdges
Currently, secondary blocks in BABE only has slot number and authority index. This adds an additional secondary block type, which also contains an VRF. The VRF is not used in beacon randomness, but is available and may be useful for parachains.
It does not yet support live upgrade. This is due to BabeConfiguration currently only fetched from genesis block. Should be possible to lift the restriction in the future.

It does not yet support live upgrade. This is due to BabeConfiguration currently only fetched from genesis block. Should be possible to lift the restriction in the future.

Live upgrade from primary-only should not be possible but live upgrade from secondary to secondary-VRF should, right? This is the purpose of the check has_api_at(2) as I understand the code.

Also, @burdges should we be including these VRF outputs in the epoch randomness?

No.  We'll only provide "fast" randomness to A&V and to parachains using this.
Primary blocks can freely choose their ancestors from among the recent secondary blocks, so including the secondary randomness would only increase the primary block producers influence of over the randomness beacon.  Fewer choices is better.  :)

Attempted support for live upgrades of BABE engine https://github.com/paritytech/substrate/pull/5514

In #5497 I've added these docs to the babe pallet. This is a reminder to update them in this PR.
impl<T: Trait> RandomnessT<<T as frame_system::Trait>::Hash> for Module<T> {
	/// Some BABE blocks have VRF outputs where the block producer has exactly one bit of influence,
	/// either they make the block or they do not make the block and thus someone else makes the
	/// next block. Yet, this randomness is not fresh in all BABE blocks.

Could you also update the docs here: https://github.com/paritytech/substrate/blob/master/client/consensus/babe/src/lib.rs#L43 ?

Rebased on #5514, so when merging, need to merge that first.

Tested syncing Kusama for the EpochChanges migration by syncing without this PR and then with the PR for a few hundred blocks, not detecting issues.


feat(wasm): remove slight and wws shims and use SpinKube spin shim

What type of PR is this?
/kind feature
/kind deprecation

What this PR does / why we need it:
This PR removes the slight and wws shims from AKS WASI Nodepool. It also swaps the Spin shim from Deislabs to SpinKube org.
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

I have ran e2e-local.sh it looks that all the tests have passed
./e2e/e2e-local.sh
+ : 90m
+ : 100
+ go version
go version go1.22.5 darwin/arm64
+ go test -parallel 100 -timeout 90m ./...
?       github.com/Azure/agentbaker/apiserver   [no test files]
?       github.com/Azure/agentbaker/cmd [no test files]
?       github.com/Azure/agentbaker/cmd/starter [no test files]
?       github.com/Azure/agentbaker/fuzz/api    [no test files]
?       github.com/Azure/agentbaker/parts       [no test files]
?       github.com/Azure/agentbaker/pkg/agent/toggles/fieldnames        [no test files]
ok      github.com/Azure/agentbaker/pkg/agent   5.061s
ok      github.com/Azure/agentbaker/pkg/agent/common    0.627s
ok      github.com/Azure/agentbaker/pkg/agent/datamodel 0.474s
ok      github.com/Azure/agentbaker/pkg/agent/toggles   1.116s
ok      github.com/Azure/agentbaker/pkg/proto/nbcontract/v1     0.738s
ok      github.com/Azure/agentbaker/pkg/vhdbuilder/datamodel    0.949s

I think we'll need to tweak these changes to only add the new runtime and keep the originals, after we've released these changes and the corresponding RP changes we can then safely remove the existing runtime classes

@cameronmeissner good idea, I've created a new PR #4744 that addresses your concern, namely that the new PR does not introduce breaking changes, only upgrades to the spin shim. I am going to close this PR and move the conversation to there.


[T2A5][T1-A4]Vu Hai Long

Ready for review

Hi @haiilong if your tutorial is Wednesday 9am, your team ID should be [W09-A4] instead of [T1-A4]. Please update your PR title accordingly.

Hi @haiilong, your pull request title is invalid. It should be in the format of [Activity ID][Team ID] Your name, where [Activity Id] has no dashes or spaces (e.g. [T2A3] stands for Tutorial 2 Activity 3) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2). Please follow the instructions given strictly and edit your title for reprocessing.
Note that this comment is posted by a bot sorting all the pull request submissions.


provide env vars for flag arguments

We kinda/sorta follow the 12 factor app model and have everything that can be configured in a service configured by environment variable.  It is generally easier and more standard than setting configs via launch flags.  (Not all apps handle flags the same way.)
As such it would be nice if flags like:  -http.addr :80 -log.format json
could also be set via environment variable.
HTTP_ADDR=:80
LOG_FORMAT=json
etc.

I've noticed this too. It's inconsistent and we can fix. Overall I'd like to see paygate read from a file based config in the future.

We find env vars to be preferable.  We do manage them as .env files which
is useful.  Again, the main reason is it remains consistent across many
different types of services.
A file based config is certainly sometimes needed.  If config gets
complicated or hierarchal.  Indeed, many infrastructure type services use
them (elasticsearch, mysql, etc.)
For these we prefer if what is in the file is stuff that is not environment
specific.  Such that the file is something we just package in the
container.  But for things like URL references to other services, or
credentials we try to pass them in via environment variables.  In fact,
when we can't we end up writing a start.sh that generates a config file
from environment variables and then start the service.
Otherwise, the trick of volume mounting a config gets rather difficult.  We
either have to push for non-standard infrastructure set up - or what we we
usually do is store the entire file in the secrets store or an environment
variable and again create a start.sh file that loads that data and
generates the file before launching.
So bottom line - I'm voting to keep it all environment variables as long as
possible!  :)
On Wed, Jul 3, 2019 at 10:53 AM Adam Shannon<EMAIL_ADDRESS>wrote:

I've noticed this too. It's inconsistent and we can fix. Overall I'd like
to see paygate read from a file based config
https://github.com/moov-io/paygate/issues/130 in the future.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/moov-io/paygate/issues/158?email_source=notifications&email_token=AKE5LWXGKEM4SFIXXYU44DTP5TRQFA5CNFSM4H5HQZLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZFG2DQ#issuecomment-508194062,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKE5LWTKD6CGIQL4QKWYKNTP5TRQFANCNFSM4H5HQZLA
.

I created https://github.com/moov-io/paygate/pull/162 to resolve this. Thoughts?


Allow custom CommonName when cluster_mtls: pki

What this PR does / why we need it:
The CommonName for the cluster certificate must be set to kong_clustering when running in cluster_mtls: shared mode. When running in cluster_mtls: pki mode it can be any value that a CA will accept.
I've also added some additional documentation. The existing README shows how to use hybrid mode with a shared certificate. When running with Cert Manager we need to switch to pki mode.
This PR adds example values.yaml files + a README for this specific use case as it's come up a few times.
Which issue this PR fixes
FTI-4396
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the main branch.
[ ] Changes are documented under the "Unreleased" header in CHANGELOG.md
[ ] New or modified sections of values.yaml are documented in the README.md
[x] Commits follow the Kong commit message guidelines

@pmalek This is my first contribution to charts. What's the process for merge + release?

@pmalek This is my first contribution to charts. What's the process for merge + release?

You'd bump the version in https://github.com/Kong/charts/blob/4a8626047d2b66d5cf9ef1d6adbffe0019ac6b3e/charts/kong/Chart.yaml#L14 and edit the changelog accordingly. Upon merge chart-releaser will figure it out that a release is required due to a bumped version and will do so accordingly.


Custom parachain id in chain name

Allow customize parachain id by adding a prefix to the chain name.
It only applies to "khala-dev" and "khala-local".
E.g.:"khala-local-2004" means "khala-local" at para 2004

LGTM


Delete defenderexpertsforhuntingprev.md

Deleting to redirect traffic to new one

Docs Build status updates of commit 4ed8caa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-365/security/defender/whats-new.md
:warning:Warning

Details

microsoft-365/security/defender/defenderexpertsforhuntingprev.md
:white_check_mark:Succeeded
n/a (file deleted)

microsoft-365/security/defender/whats-new.md

Line 57, Column 203: [Warning: file-not-found - See documentation] Invalid file link: 'defenderexpertsforhuntingprev.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1c644ee:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

microsoft-365/security/defender/defenderexpertsforhuntingprev.md
:white_check_mark:Succeeded
n/a (file deleted)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Clarify to use docker for unsupported systems

This feels a bit better. I wasn't sure if we should add a link to the building from source as well at some point.

You could just add that as an alternative if they don't want to install docker or can't install the docker.


(maint) pin addressable gem to avoid ruby 2 dependency

CLA signed by all contributors.

Test PASSed


feat: add search bar

Adds search bar and test for it.
see: https://github.com/Problematy/goodmap/issues/133

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

24 of 29 (82.76%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.5%) to 72.281%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/Map/components/MapAutocomplete.jsx
5
6
83.33%

src/components/common/Autocomplete.jsx
19
23
82.61%

Totals

Change from base Build<PHONE_NUMBER>7:
1.5%

Covered Lines:
167

Relevant Lines:
229

💛  - Coveralls

can you run make lint-fix and commit linted code?


New File input bar obscured by bottom message panel

If Sublime is currently displaying a message in the bottom panel (in this example, the message shown by the add-on package Sublimerge), the new file prompt is covered by it.
This is as shown in the image.

Look at Known Issues section
Just drag the top edge and restart Sublime Text.

I didn't realise you could drag other panels too!
My apologies then, feel free to close this issue.

:wink:


Support the "friendly" rendering in python

Allow python objects to output the friendly rendering described at https://dhh1128.github.io/sgl/docs/renderings.html#human-friendly-text

Maybe allow them to read it, too?
Create methods to parallel to_json and from_json -- to_friendly and from_friendly, maybe?

Link doesn't exist. It is https://github.com/evernym/sgl/blob/master/docs/renderings.md#plain-english.
I think if you want to have a human friendly rendering, specifically for non-developers, the examples you give in the 'plain-english' section aren't going to be all that helpful to them, simply because they have to hallucinate to interpret the meanings of 'priv1' (even if they are more 'meaningful', such as 'school' or 'food' in the Mya use-case example).
I can imagine that some part of the grant language must be human readable, e.g. when - e.g. in the Mya use-case - Malcolm can read on its tablets what stuff to ask for, and what checks to make before dispensing a food ration. That implies that the grant language must also be human-interpretable. Maybe that requires some other syntax?


Error running brad_tee_and_heatset_nuts.py: AttributeError: 'Assembly' object has no attribute 'metadata'

I'm using the current cq_warehouse repository HEAD (cc694aa10102bcc82aa80b6c5462a8e39487a511), and the latest published cadquery (2.1)  and cq-editor (0.3.0dev) packages from conda, and running the brad_tee_and_heatset_nuts.py example I'm getting the following error:
Traceback (most recent call last):
  File "/home/sean/Workspace/Repositories/cq_warehouse/examples/brad_tee_and_heatset_nuts.py", line 54, in <module>
    cq.Workplane("XY")
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/extensions.py", line 944, in _clearanceHole
    return self.fastenerHole(
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/extensions.py", line 876, in _fastenerHole
    baseAssembly.metadata[baseAssembly.children[-1].name] = fastener
AttributeError: 'Assembly' object has no attribute 'metadata'

This happens on some of the others as well.

Hi Sean,
I had to make a change to cadquery to support metadata (
https://github.com/CadQuery/cadquery/pull/928) which was merged on Dec 10,
2021 so you'll need to upgrade to cadquery master to make it work.
Cheers,
Roger
On Sun, Mar 13, 2022 at 4:46 AM Sean Leavey @.***>
wrote:

I'm using the current cq_warehouse repository HEAD (cc694aa
https://github.com/gumyr/cq_warehouse/commit/cc694aa10102bcc82aa80b6c5462a8e39487a511),
and the latest published cadquery (2.1) and cq-editor (0.3.0dev) packages
from conda, and running the brad_tee_and_heatset_nuts.py example I'm
getting the following error:
Traceback (most recent call last):
File "/home/sean/Workspace/Repositories/cq_warehouse/examples/brad_tee_and_heatset_nuts.py", line 54, in
cq.Workplane("XY")
File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/extensions.py", line 944, in _clearanceHole
return self.fastenerHole(
File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/extensions.py", line 876, in _fastenerHole
baseAssembly.metadata[baseAssembly.children[-1].name] = fastener
AttributeError: 'Assembly' object has no attribute 'metadata'
This happens on some of the others as well.
—
Reply to this email directly, view it on GitHub
https://github.com/gumyr/cq_warehouse/issues/29, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUNL25VZ2SYFI7TGWQ3UXUDU7WTNTANCNFSM5QTBQXRQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks, that worked. I thought I had made sure I had the latest versions of all of the packages but it seems I didn't get conda to update correctly. Reinstalling worked.
There are still a bunch of errors running some of the examples - but not from lack of metadata - are these already known or should I submit new reports for these?

Please let me know about the errors, either here or on github.  Are you
getting these errors running the cq_warehouse examples?
On Mon, Mar 14, 2022 at 1:43 PM Sean Leavey @.***>
wrote:

Thanks, that worked. I thought I had made sure I had the latest versions
of all of the packages but it seems I didn't get conda to update correctly.
Reinstalling worked.
There are still a bunch of errors running some of the examples - but not
from lack of metadata - are these already known or should I submit new
reports for these?
—
Reply to this email directly, view it on GitHub
https://github.com/gumyr/cq_warehouse/issues/29#issuecomment-1067108533,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUNL25SMTPIX5WI4G7GOIG3U753CPANCNFSM5QTBQXRQ
.
You are receiving this because you commented.Message ID:
@.***>

getting these errors running the cq_warehouse examples?

Yes. Using cadquery master and cq-warehouse master (both as of today) on Python 3.10. I ran pip install -e . on a local clone of cq-warehouse to get the latest.
The following three examples fail. The rest are fine.
(cadquery)  $ python brad_tee_and_heatset_nuts.py
Traceback (most recent call last):
  File "/home/sean/Workspace/Repositories/cq_warehouse/examples/brad_tee_and_heatset_nuts.py", line 43, in <module>
    heatset = HeatSetNut(
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/fastener.py", line 559, in __init__
    self._cq_object = self.make_nut().val()
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/fastener.py", line 983, in make_nut
    lower_knurl_faces = HeatSetNut.knurled_cylinder_faces(
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/fastener.py", line 907, in knurled_cylinder_faces
    bottom_face = cq.Face.makeFromWires(
  File "/home/sean/Workspace/env/conda/envs/cadquery/lib/python3.10/site-packages/cadquery/occ_impl/shapes.py", line 2268, in makeFromWires
    raise ValueError("Cannot build face(s): outer wire is not closed")
ValueError: Cannot build face(s): outer wire is not closed

(cadquery)  $ python drafting_examples.py
/home/sean/Workspace/env/conda/envs/cadquery/lib/python3.10/site-packages/cadquery/utils.py:65: FutureWarning: Kwarg <cut> will be removed. Plase use <combine='cut'>
  warn(
Traceback (most recent call last):
  File "/home/sean/Workspace/Repositories/cq_warehouse/examples/drafting_examples.py", line 82, in <module>
    length_dimension_line = metric_drawing.extension_line(
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/drafting.py", line 597, in extension_line
    d_line = self.dimension_line(
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/drafting.py", line 460, in dimension_line
    line_wire = Draft._path_to_wire(path)
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/drafting.py", line 262, in _path_to_wire
    path_as_wire = Wire.assembleEdges([path])
  File "/home/sean/Workspace/env/conda/envs/cadquery/lib/python3.10/site-packages/cadquery/occ_impl/shapes.py", line 1905, in assembleEdges
    wire_builder.Add(occ_edges_list)
OCP.Standard.Standard_TypeMismatch: TopoDS::Edge

(cadquery)  $ python flag_of_Ukraine.py
Traceback (most recent call last):
  File "/home/sean/Workspace/Repositories/cq_warehouse/examples/flag_of_Ukraine.py", line 43, in <module>
    projected_top_face = top_face.projectToShape(the_wind, direction=cq.Vector(0, 0, -1))[0]
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/extensions.py", line 1348, in _face_projectToShape
    projected_faces = [
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/extensions.py", line 1349, in <listcomp>
    ow.makeNonPlanarFace(
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/extensions.py", line 1623, in _wire_makeNonPlanarFace
    return makeNonPlanarFace(self, surfacePoints, interiorWires)
  File "/home/sean/Workspace/Repositories/cq_warehouse/src/cq_warehouse/extensions.py", line 1593, in makeNonPlanarFace
    raise RuntimeError("non planar face is invalid")
RuntimeError: non planar face is invalid

Thanks Sean.  I'll try to recreate the problems you're seeing.  I didn't know cadquery supported Python 3.10 yet so there are definitively some things to look into.

It looks like at least some of the issues are related to makeNSidedSurface.  I raised an issue here: https://github.com/CadQuery/cadquery/issues/1030  I did my development with a version of cadquery from around the beginning of the year but I don't know if that's helpful as there hasn't been a release in a year.

Fixed drafting with https://github.com/gumyr/cq_warehouse/commit/4c81538bf333b0d2f2d08099a50c715f888dc080  A non backwards compatible change was made to assembleEdges which required a minor fix.

Works, thanks!


No way to configure the passport "Asynchronous configuration retrieval"

There are some instances where we need to have an asynchronous retrieval for the configuration of the LDAP settings every time we make a request.
This explains how to achieve this by passing in a function rather than an object to the new strategy's instance.
https://github.com/vesse/passport-ldapauth#asynchronous-configuration-retrieval
Current there is no way to pass a function into this feathers auth strategy.

Closed via https://github.com/feathersjs-ecosystem/feathers-authentication-ldap/pull/24


XRDP issue with ssl-cert

After installing XRDP on Ubuntu 20, you need to give access to certificate to the xrdp user.
sudo adduser xrdp ssl-cert
As explained here:
https://mikerodionov.com/2021/01/xrdp-service-error-cannot-open-private-key-file/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 077ee673-528a-d893-5832-7656b91dbec8
Version Independent ID: 2180e845-1ead-3b47-03be-c26aee00c6f7
Content: Use xrdp with Linux - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/use-remote-desktop.md
Service: virtual-machines
GitHub Login: @cynthn
Microsoft Alias: cynthn

@mattmcinnes and @kobulloc-MSFT FYI

#reassign @mattmcinnes

#assign @mattmcinnes

#assign:@mattmcinnes

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. The requested updates have not been made since the creation of this issue, and the timeline for resolution may vary based on resourcing. We are closing this issue for now, but feel free to comment here as necessary. #please-close
@mattmcinnes