Nightly parallel build fix for elf/posix_spawn/module build break

Makefile: remove context dependency to avoid apps context build twice
In nuttx pass1dep and pass2dep builds, context firstly would be built once.
It then call 'make -C apps depend' which would trigger the context built twice.
There is race condition between symtab.c generated by mksymtab.sh in second time
and compiling symtab.c in parallel build. So remove context dependency for apps
depend to make sure context build only one time for apps.
Parallel build break logs as below:
/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to g_elf_nexports' riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to g_elf_exports'
make[1]: *** [nuttx] Error 1
make: *** [pass2] Error 2

@liuguo09
Parallel build aging test is working without any problems so far.

Thanks for merged, let's waiting for the result of Nightly build today. I see it's now building with these changes.

There is still one maix-bit/module config build break in today's nightly build : (
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/staging/libapps.a(module_main.home.jenkins.jenkins-slave.workspace.NuttX-Nightly-Build.apps.examples.module.o): in function module_main': /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/module/module_main.c:164: undefined reference to g_mod_exports'
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/module/module_main.c:165: undefined reference to `g_mod_nexports'
make[1]: *** [nuttx] Error 1
make: *** [pass2] Error 2
make: Target 'all' not remade because of errors.

@masayuki2009  @xiaoxiang781216
Besides the context built twice problem, It seems in the time window mksymtab.sh redirect to symtab.c, there is chance symtab.c would also be built meantime. Or should we still consider to not revert your mv operation to reduce the time window?

@masayuki2009 @xiaoxiang781216
Besides the context built twice problem, It seems in the time window mksymtab.sh redirect to symtab.c, there is chance symtab.c would also be built meantime. Or should we still consider to not revert your mv operation to reduce the time window?

@liuguo09 can you reproduce the same error by adding sleep in mksymtab.sh which you tried before?

@masayuki2009 I cannot reproduce the same error by adding sleep in mksymtab.sh.
But I found there is some dependency issue in example/module, I make a PR in https://github.com/apache/incubator-nuttx-apps/pull/129. It may make some difference.

@masayuki2009 I cannot reproduce the same error by adding sleep in mksymtab.sh.
But I found there is some dependency issue in example/module, I make a PR in #129. It may make some difference.

@liuguo09 Thanks for the information. I’ve just merged #129.

@masayuki2009 @xiaoxiang781216
Besides the context built twice problem, It seems in the time window mksymtab.sh redirect to symtab.c, there is chance symtab.c would also be built meantime. Or should we still consider to not revert your mv operation to reduce the time window?

Hi, @liuguo09
Unfortunately today's nightly build failed again.
https://builds.apache.org/job/NuttX-Nightly-Build/70/consoleText
I'm still not sure if our previous patches (i.e. mv operation) resolve the issue but we should reconsider to apply them again.
What do you think?

@masayuki2009 I think we could consider it. I have just made the PR https://github.com/apache/incubator-nuttx-apps/pull/130 to use our former mv operation. Hope it works.


[Bug report] call FlutterImageCompress.compressWithList on web get Unimplemented error

Version
2.1.0
Platforms
Web
Device Model
Chrome
flutter info
[√] Flutter (Channel stable, 3.16.2, on Microsoft Windows [Version 10.0.19045.4046], locale en-IL)
    • Flutter version 3.16.2 on channel stable at C:\Users\Maya\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9e1c857886 (3 months ago), 2023-11-30 11:51:18 -0600
    • Engine revision cf7a9d0800
    • Dart version 3.2.2
    • DevTools version 2.28.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Maya\AppData\Local\Android\Sdk
    • Platform android-33, build-tools 30.0.3
    • ANDROID_SDK_ROOT = C:\Users\Maya\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop Windows apps
    X Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version openjdk version "11.0.13" 2021-10-19

[√] VS Code (version 1.86.1)
    • VS Code at C:\Users\Maya\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.84.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.4046]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 122.0.6261.112
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 122.0.2365.80

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

How to reproduce?
Jest call :
            capturedImage = await FlutterImageCompress.compressWithList(
              capturedImage,
              minWidth: 300,
            );

on flutter web
Logs
UnimplementedError

Example code (optional)
capturedImage = await FlutterImageCompress.compressWithList(
                  capturedImage,
                  minWidth: 300,
                );

Contact
No response

I have this issue too, It only occurred when I deploy to it eg with firebase hosting

Yes this is correct!! BUT with regular internet i get:
Expected a value of type 'Function', but got one of type 'Null'
(I will open a new issue for that)
I think they need to provide a better error messages (:

I guess it can be closed.. the error msg is not correct but this is very minor problem..

I guess it can be closed.. the error msg is not correct but this is very minor problem..

Works fine on release mode and debug mode in localhost, only stops working after hosted.(Firebase hosting)

@MayaBloodsAI how did you solve the unimplemented error I keep getting it only on release mode in firebase hosting

I don't get why was this closed?
I am having the same error (firebase hosting) and there was no solution offered...

@orikurt i found out how to resolve this problem, you have to upgrade the web package in the pubspec.yaml to the newest version.
web: ^0.5.1


wont stop as a user thread keeps alive

the new thread is not a daemon thread, so it will prevent the application from exiting

@littleboyonearth In the latest version of FXTrayIcon, we do not use this Thread anymore. The check is instead done by invoking EventQueue.invokeLater() this way we can check on that particular thread, so there's no timing issue.
Please update your fork/clone to the latest version. Thanks!


Feature request - HTTP OPTIONS SHOULD allow body in response

Hello,
Why this feature is required (specific use-cases will be appreciated)?

https://tools.ietf.org/html/rfc2616#page-52
https://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.2
https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/OPTIONS

RFCs and docs i readed say that OPTIONS http request can include a body response.
My specific use-case
I create an api for my work and I wanted document my API under OPTIONS route (with same url) and define in returned body the schema of request and response body.
With CORS Middleware activated, OPTIONS route handle request and return empty body in response before reach my controller.
Have you tried any other work arounds?
For now, my work around is to disable CORS middleware...
Are you willing to work on it with little guidance?
I can try too fix it, but I don't want to risk to break someone else existent code.
Solution I suggest
https://github.com/adonisjs/adonis-cors/blob/develop/src/Cors/index.js#L278
replace handle function by
  async handle ({ request, response }, next) {
    this
      ._setOrigin(request.header('origin'), response)
      ._setCredentials(response)
      ._setExposeHeaders(response)

    /**
     * If request is OPTIONS set CORS headers before call next.
     */
    if (request.method() === 'OPTIONS') {
      this
        ._setMethods(response)
        ._setHeaders(request.header('access-control-request-headers'), response)
        ._setMaxAge(response)
    }

    return next()
  }

NB
I'm not really used to creating issues, so I hope I did it right :wink:

I believe this can be achieved by creating your own Cors middleware, which extends the inbuilt CORS middleware.
const Cors = use('App/Middleware/Cors')

class AppCors extends Cors {
  async handle ({ request, response }, next) {
    this
      ._setOrigin(request.header('origin'), response)
      ._setCredentials(response)
      ._setExposeHeaders(response)

      if (request.method() === 'OPTIONS') {
        this
          ._setMethods(response)
          ._setHeaders(request.header('access-control-request-headers'), response)
          ._setMaxAge(response)
      }

      await next()
  }
}

module.exports = AppCors

and then inside start/kernel.js file, you must register your own middleware and remove the existing one

Closing, since no response from the creator

Hi, sorry for not having aswered.
I've solved my issue with your response. But I think the cors middleware should allow body response on OPTION verb, because it's allowed by http specification.
Feel free to accept my linked pr.
Best regards.

@thetutlage
I have this error in my Middleware:
Class extends value # is not a constructor or null
My code is :
const Cors = use(‘Adonis/Middleware/Cors’)
class Origin extends Cors {
async handle ({ request, response }, next) {
console.log(request.headers())
this
._setOrigin(request.header(‘origin’), response)
._setCredentials(response)
._setExposeHeaders(response)
if (request.method() === 'OPTIONS') {
this
._setMethods(response)
._setHeaders(request.header('access-control-request-headers'), response)
._setMaxAge(response)
}
await next()
}
}
module.exports = Origin

Maybe the cors middleware is not declared in your bootstrap server file (I don't remember the name) so  use(‘Adonis/Middleware/Cors’) returning null ?

returning null ?
return this:
Cors {
options:
{ origin: [Function: name],
methods: [ 'GET', 'PUT', 'PATCH', 'POST', 'DELETE' ],
headers: true,
exposeHeaders: true,
credentials: true,
maxAge: 90 } }


Unrecognized resource type: ethereum_classic_network and zcash_network

Hi,
I'm trying to get information about transaction using following code:
        $transaction = new Transaction(
            null,
            $additionalData['transaction']['resource_path']
        );

        $this->client->refreshTransaction($transaction);

$additoonaData is data send to webhook notificaiton addres (https://developers.coinbase.com/api/v2#notifications)
But for ETC and ZEC exception is thrown with error "Unrecognized resource type: ethereum_classic_network" or zcash_network.
How can I fix this ?

The same issue #204 , please review issue for solution to fix.


Improve Github actions

Hello.
It looks like commiting to branches excluding master does not run Github Actions. So users which are working on feature/bugfix branches cannot see that their changes are leading to failed tests until they'll create a pull request to master branch.
So I've removed restriction against branch name for push events.
Also I've found another quite annoying bug - step actions/cache does not update cache item if it was restored using a primary key.
For example, some dependencies like dialyzer or other ones store their files in deps or _build folders (which are cached in the workflow). But when these dependencies perform some updates of these folders, it does not lead to the updating of mix.lock file. File hasn't been changed -> hash is the same -> cache primary key is the same -> caching action will not update the existing cache.
This will cause the increase of workflow run time because the stored cache will not be used by some steps. Until mix.lock will be updated which will lead to updating the cache item.
Here I've appended a commit SHA to the cache primary key, so it will always be updated. But it will not affect cache reading.
What do you think about that?

Done.

Thanks!

I've also added a PR into some other absinthe repos with the same actions set:
https://github.com/absinthe-graphql/absinthe_plug/pull/253
https://github.com/absinthe-graphql/absinthe_phoenix/pull/84
https://github.com/absinthe-graphql/dataloader/pull/121


Update conf.py

Minor typo

Codecov Report

Merging #38 (34d9b65) into main (da291d4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           10        10
  Lines          308       308
=========================================
  Hits           308       308

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


trying to use .env-cmd.. getting error

I am trying to set env variable through terminal like,
node node_modules/env-cmd -f ./async-env.js node index.js
getting below error.. Please assist
TypeError: util_1.promisify is not a function
at Object. (/node_modules/env-cmd/dist/parse-rc-file.js:15:26)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object./node_modules/env-cmd/dist/get-env-vars.js:11:25)
at Module._compile (module.js:570:32)

It looks like to me you're running some very old version of node as it is complaining about no promisify support.

That seems to be the issue. NodeJS's official promisify util was added in node v8.0.0. Documentation for that function can be found here: https://nodejs.org/api/util.html#util_util_promisify_original
This project has a minimum supported NodeJS version of 8.0.0. As @Akkuma said, it seems like you are running on an unsupported NodeJS version < 8.0.0

Closing due to inactive/no response from the original poster.


[Bug Report]

Describe the bug
When I land on an item that has an amount of that item in a stack higher then one I often get given less of that item as expected. E.g I land on 16 oak logs but I only get given 2 oak logs.
Versions (please complete the following information):

Minecraft Server Version: 1.16.4
Crazy Crates v1.10.1 Snapshot

*Do NOT say Latest use /version crazycrates in the console.
Pastebin any errors in console
Link: There are no errors in console
Issue
I don't get enough items when I land on the item
Screenshots

Try switching to the give command instead of the items option should fix it.


[Telegram Bridge] Image duplication

Describe the bug
In any telegram post that contains pictures, these pictures will be repeated twice - once in the post, and once after the post ends.

I could not reproduce this issue. This is likely how your client handles enclosures. Does the issue appear on the Html view on the rss-bridge instance?

I loaded the red_spades channel using these parameters: http://<IP_ADDRESS>:7463/?action=display&bridge=Telegram&format=Mrss&username=red_spades
Inside the xml I clearly see the duplication of images twice per item: once inside the description, the second time outside of it.

Так же я прикладываю xml-ответ сервера.
<IP_ADDRESS>.txt

This is intended behaviour. Those duplicates are enclosures.

But I see duplicate images in the rss reader (freshrss and reeder), and it makes it hard to read the posts comfortably: it takes me a while to realize that the continuation of the post is actually not a continuation, but a double of the images I've already seen. There hasn't been this behavior for several months; it has appeared recently.
What about the fact that the expected behavior breaks the proper display of the post (the way it looks in the tg feed, for example)?

This is an issue in how FreshRSS handles enclosures: https://github.com/FreshRSS/FreshRSS/issues/1668

I'm just pointing out the facts:
1)The other RSS feeds do not have this problem (I subscribed to more than 100 different sources, which are generated by different engines on different sites and the problem with duplicate pictures is only in RSS-Bridge)
2)Such behavior started to be observed a month or two ago in two readers at once (freshrss and reeder): thus, I conclude that there is a potential possibility of sending the working feed to the readers without duplicate images, and something was changed in the RSS-Bridge code a month ago that led to such behavior.
3)Since the problem exists in two readers (on three different platforms) and only in RSS-Bridge feeds, I conclude that it's not really that a particular reader suddenly broke the feed display. It seems to me that if I check several other popular and active readers, at least some of them will have the same problem.
So, from all of the above, I conclude that the problem is how the RSS-Bridge/TG Bridge is shaping the RSS feed. Am I wrong?

Since this behavior started recently, are you able to find the commit that resulted in the error using git-bisect for example? I looked in the history and I don't see anything that should have changed this behavior recently.

Thanks for your comments @vvzvlad. We actually do infact scrape the content and insert images as enclosures. I am uncertain whether this is the most useful behaviour.
I can imagine that feed readers can do lots of useful stuff with the image enclosures, such as prefetching, caching, proxying etc. I also understand it's annoying for users to see duplicated images. Would like more input from the community regarding what to do about this.
One short-term option is to add a bridge checkbox: "Exclude images from enclosures".

I can't really imagine how I would apply individual images from my posts to my RSS feed, since I don't have such tasks. But, assuming that users use RSS for its intended purpose, as reading news, I would say that I would like to have a separate RSS stream for dealing with images, and still use the old format, as then for human-readable rss readers. For example, this could be implemented as a separate parameter:
?action=display&bridge=Telegram&format=Mrss_image_as_enclosures&username=red_spades
If this was the case, the bridge would output a stream with pictures.
The &images=without_enclosures parameter would also work fine. However, I and other users who were affected by this problem would have to go through the whole list of rss-addresses and edit each one inserting a new parameter, which is somewhat inconvenient (I did it when I changed the server to local, and the fastest way to do it - to open sqlite database freshrss in the editor and correct each line of my 40 TG sources manually), so I would prefer the option above (format=Mrss_image_as_enclosures).

Since this behavior started recently, are you able to find the commit that resulted in the error using git-bisect for example? I looked in the history and I don't see anything that should have changed this behavior recently.

Возможно, дело в коммите 55acf661b9f456669be1e501ac3306582ac356a0? Если это будет единственным решением проблемы, я могу использовать bisect для поиска, но это потребует разворачивания тестового окружения, т.к. мое текущее решение с docker-контейнером не очень позволяет быстро менять версии RSS Bridge

I actually meant "Does your feed reader also show duplicated images for Atom feeds?".
I am aware, that image-related xml elements appear both in body and in enclosures.

I actually meant "Does your feed reader also show duplicated images for Atom feeds?".

I added a copy of an existing channel with "&format=atom" to the rss reader, and there are duplicate images in that too.

The problem is recognized and understood @vvzvlad
We just need to decide which default behavior is the least painful one. To repeat: it was intended behaviour to duplicates images in enclosures. I prefer dropping them but need more input because they might be important to feed readers.

Possible workaround - add config option like "drop_enclosures". Did not think a lot about better naming.

Unless objected to, I am going to remove these image enclosures from the telegram bridge because they are already present in the body.


Arrows are not straight when bow=0

Hi there, I found that my arrows were not at all straight when i set bow to zero. I had to set it to -0.5 or -0.45 to be straight. That's strange, I don't know why that happens

Nevermind, found my mistake. Had to set stretch to zero as well. Can close.


fix mapping and repos

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Matus Majchrak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Write a Profiling Flutter Apps page

Similar to our Debugging Flutter Apps page, flutter.io should have a page on profiling and tuning Flutter apps covering performance tuning and memory analysis.
In particular, Flutter generates very different ARM code in debug mode (vs profile or release mode) in order to facilitate hot-reload.
Flutter's default debug mode build make it easy to accidentally end up profiling a debug-mode build. Similar to the iOS releasing process, it's worth considering what we can do to make the tooling more developer-friendly for profiling. Perhaps a flutter profile command that behaves like flutter run but builds in profile mode.

@Sfshaza plans to work some in this space in Q1.

@cbracken, I'd like to talk to you about the page I published earlier this year and see what is stable enough to add. (Flutter's Profile observatory page has been unstable and I'm not sure what @stereotype441 has planned, tooling wise.)


Running on windows for local testing

please how i run it on window

I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


revamp ports

k8s ports (pod, service) should be determined by which receivers are setup rather than managed independently via .Values.ports unless there is a reason that receiver ports and k8s ports should differ.
This would be a breaking changes.

Not that important for now.


MQTT on different port

I have my own running mqtt-server inside an other docker image, sitting on port 1183 (instead the default 1883). Is that possibile to set the configuration to work with that? (Right now there an option to set the ip address. Or should we use it like ip:port? )

Oh, a million pardon...
Example from CloudMQTT
host: mqtt:///m10.cloudmqtt.com:19427

Where did you find this setting? I have the same issue. Did you change the mqtt-bridge in docker to another port, or did you use the standard 8080?

I only changed the mqtt-server port to 1183. If you do it, you can do it two different way. You can change only the mqtt port in the config, and you can leave it, as you connect it trough local dockep IP.  Or you can make it public, via docker port-forward. (I did it both.) So, locally and "publicly" I use tehsame non-default port, 1183. Then when I configured this samrt-mqtt-bridge, I also had to change the port in the url above.
(I hope, I get what you want to know.)
(My problem is with that whole smarttings things. I really dont get it trough. Smartapps, and so on...)

I realized I have to read more up on how the computer communicates with  the Docker containers as I have never used it before.
Are your events listed in the live log on the smartthings page?


Update ansible-lint.yml

Updated the ansible-lint.yml to correctly install the ansible and ansible-lint versions and perform ansible lint on specific set f files.

Ok, will raise a code review request.


Upgrade ingress-controller to latest version

This is related to https://github.com/ministryofjustice/cloud-platform/issues/1290
Upgrade ingress-controller to latest version
Chart version: 1.24.0
appVersion: 0.26.1

Removed $the_real_ip variable  as it was removed from template and default log_format from v0.26.0

@digitalronin Thanks for the review, updated the comment as suggested.


MHub / GC - Add the GC stoic baseline model

This PR adds the GC STOIC baseline model (from the STOIC2021 challenge) to MHub.
GitHub Repo: https://github.com/luukboulogne/stoic2021-baseline
GC page: https://grand-challenge.org/algorithms/stoic2021-baseline/
Algorithm I/O

Input should be a CT Lung image (MHA) (This MHub implementation expects a Dicom which is converted to MHA using MhaConverter)
Outputs are:

A JSON file with the following output scores:
*probability-covid-19
*probability-severe-covid-19

Test images for this algorithm can be downloaded from here: https://stoic2021.grand-challenge.org/stoic-db/

Caveats

The PR target is main, but should be something like m-gc-stoic-baseline
In the Dockerfile the MHub model repo integration is currently marked TODO since it requires the creation of the appropriate branch for this code first.
Added a TODO to the MHAConverter since it doesn't have the panimg backend yet.

I suggest we use ValueOutput in combination with a ReportExporter.

I suggest we use ValueOutput in combination with a ReportExporter.

I'll add these soon.

The ValueOutputs and ReportExporter have been added, plus some minor cleanup.

The repository commit has been fixed and additional comments have been added to the runner.

I removed the ValueOutput.Meta lines and updated the Dockerfile with the new import

output.zip

/review
The meta.json file has been updated and the comments have been addressed.


Add Oracle specific Query for GET_ALL_UM_ORG_ATTRIBUTES

Purpose
$Subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/10264694477

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10264694477
Status: success

The missed lines cannot be covered with unit tests since the logic added is specific for Oracle Database. Hence merging the PR.


add CI for podman_crun

Add the CI for podman + crun

flows summarize

Hello, I am a serverless review bot on flows.network. Here are my reviews of code commits in this PR.

This is outdated. Closing it. Thanks.


depend on exact versions of packages

i think that depending on exact versions is more safe, the jsreport repository does it that way

Good point. I froze the dependencies now and also updated to the latest.


test

⏱ Before you start...

[X] Have you checked if a similar feature request has already been reported?

📄 Description
test
🗃 Alternative solutions
No response
📸 Assets
No response

@DeveloperWOW64 why did you create this?

@DeveloperWOW64 why did you create this?

Ahh.. needed to test what the Markdown looked like for the issue template.. nvm


Do not create tasks.json when creating debug configuration for gcc build active file

VSCode Version: 1.43.2
OS Version: Ubuntu 18.04.4

Steps to Reproduce:

Install C/C++ extension ms-vscode.cpptools
Start debugging
Select environment: C++(GDB/LLDB)
gcc run and debug active file

A launch.json file is created but no tasks.json. I tried to do it by hand by going to Menu -> Terminal -> Configure tasks -> Create tasks.json file from template  I do not have such option for creating tasks.json for 'gcc build active file'
The instruction below is not relevant as the bug is related to the extension extension ms-vscode.cpptools.

Does this issue occur when all extensions are disabled?: Yes/No

Please reopen this on the C/C++ extension: https://github.com/Microsoft/vscode-cpptools


fix: set max-width for Toast message

Description
Set max-width for Toast.
Fixes #9049
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Use showAlert to create a lengthy message
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/toast-lengthy-content

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
54.77 (0)
36.62 (-0.01)
33.48 (0.01)
55.3 (-0.01)

:green_circle:
app/client/src/components/ads/Toast.tsx
77.78 (0.42)
63.64 (1.14)
80.95 (0.95)
77.78 (0.42)

:red_circle:
app/client/src/selectors/commentsSelectors.ts
83.61 (-1.64)
61.76 (-2.95)
73.33 (0)
88.24 (-2.35)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.04 (-0.22)
40.42 (-0.83)
34.48 (0)
55.96 (-0.26)

/ok-to-test sha=a4dd87b

https://github.com/appsmithorg/appsmith/actions/runs/1439092299

@somangshu @rishabhsaxena
A widget's name can be a maximum of 30 characters. Here's how the message look like if we do undo/redo for a widget that has 30 character length name. It's around 440px length. If we reduce the width, the action buttons can go below the text.

An alternate solution could be adding a max-width prop to the undo / redo toasts as a quick fix, and keeping the default as before?

@aswathkk an alternate solution could be adding a max-width prop to the undo / redo toasts as a quick fix, and keeping the default as before?

If we are able to keep the styles separate for both the conditions aforementioned, We should go about doing it

PR #8955 caused this issue. Before that, the width was 264px. I set it as the default value for max-width now.

/ok-to-test sha=372cff3

https://github.com/appsmithorg/appsmith/actions/runs/1439803060


Relax repository path validation.

The changes introduced in #3 have broken the ability to upload packages to CodeArtifact using this backend.
Test setup procedure:
$ python3 -m venv venv
$ source venv/bin/activate
$ pip install keyrings.codeartifact

$ export REPOSITORY_URL=$(aws codeartifact get-repository-endpoint --region us-west-2 --format pypi --query repositoryEndpoint --output text --domain test-domain --repository test-repo)
$ echo $REPOSITORY_URL
https://test-domain-NNNNNNNNNNNN.d.codeartifact.us-west-2.amazonaws.com/pypi/test-repo/

Now keyring doesn't recognize the aws CLI-provided URL:
$ keyring get $REPOSITORY_URL username
WARNING:root:Invalid CodeArtifact PyPI path: /pypi/test-repo/

... but twine does:
$ export TWINE_USERNAME=aws
$ export TWINE_PASSWORD=$(aws codeartifact get-authorization-token --region us-west-2 --domain pypi-domain --query authorizationToken --output text)
$ twine upload --repository-url $REPOSITORY_URL dist/arbitrary-package.0.1.0-py3-none-any.whl
(successful)

Appending /simple/ to $REPOSITORY_URL allows the backend to look up an authorization token with keyring:
$ keyring get "${REPOSITORY_URL}simple/" username
(outputs authorization token)

... but breaks uploading with twine:
$ twine upload --repository-url "${REPOSITORY_URL}" dist/arbitrary-package.0.1.0-py3-none-any.whl
Uploading distributions to https://test-domain-NNNNNNNNNNNN.d.codeartifact.us-west-2.amazonaws.com/pypi/test-repo/simple/
Uploading arbitrary-package.0.1.0-py3-none-any.whl
WARNING  Error during upload. Retry with the --verbose option for more details.
ERROR    HTTPError: 404 Not Found from https://test-domain-NNNNNNNNNNNN.d.codeartifact.us-west-2.amazonaws.com/pypi/test-repo/simple/
         Not Found

This is the path validation regex introduced in 1.3.1:
PATH_REGEX = r"^/pypi/([^/])+/simple/?$"

There are three issues with it:

The /simple suffix is an unnecessary restriction -- as identified above.
The regex only matches last character of the repository name.
It will only ever match an exact path -- not just a prefix of it.

@rorybartie noticed a flaw in the URL path matching logic where re.fullmatch() attempted to match the full path string instead of a prefix of it. I've committed 92857a3 to fix that.


Bug when trying to view delivery details for reports that are not batched but sent as single messages#

User Story
As a receiver who has useBatchHeaders set to false. I want to be able to see my reports in Daily Data without errors.
Description/Use Case
When there are multiple reports sent to a receiver at the exact same time (which occurs when there is a receiver not using batch headers, but is instead receiving each message as it's own report). The delivery details link returns a 500 error with the exception:
"org.jooq.exception.TooManyRowsException Message: Cursor returned more than one result"
This can by observed logging in as ar-phd in prod, going to Daily Data, and then selecting the "reportID" link to see more details for report_ID "18955639-1c6d-4182-a078-f91f6ecbdc25"
Risks/Impacts/Considerations
Dev Notes
This occurs because the query in the fetchAction method in the DatabaseDeliveryAccess class throws an exception because there is more than one report with the same action id.
Acceptance Criteria

[ ] The delivery details page loads for reports that originated from a report with multiple messages to a receiver who has useBatchheaders set to false.
[ ] The fetchAction method can handle the situation where there are multiple reports returned OR multiple reports being returned are eliminated as a possibility.

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @brick-green @david-navapbc @jack-h-wang @jalbinson @JFisk42 @mkalish @thetaurean


[question] Input system/Switch keyboard language?

My current situation is that I'm using an extended mechanical keyboard with US-layout to work and use a custom Plasma keybinding to switch the layout to German for chatting with my coworkers.
My goal is to have or emulate that behaviour when using other window managers, so is there a feasible way of changing the input language completely, apart from writing a language-specific layout for every modifier key?
In an x-session I could just bind setxkbmap ... to any key, but what about wayland-compositors which read the kbd only once on startup?
How would KMonad behave if I call setxkbmap while it's running, anyway? Does it receive raw key events or those translated by the X-server?
EDIT: I didn't try setting the xkbmap while under Plasma, as it also has some keyboard management hooked before it. Changing language via Plasma settings is reflected in KMonad, e.g. z becomes y after I switch to the US layout.

Wm's have tools to feed/change configuration on-the-fly (swaymsg, i3-rpc).
If your active layer matches qwerty -- all external keybinding tools (even plover steno and chinese input engine) will work as expected, kmonad is very low-level.

kmonad processes keycodes, not keysymbols, so you don't have to change your layers if the position is important, not the symbol (the text on the keys of your keyboard)
wayland compositors have their own way of changing the keyboard layout, so you won't be able to use a uniform setxkbmap or sth
there is no problem with running setxkbmap, while running kmonad, kmonad processes the keys before X. (Though you may want to use a different mapping for qwertz).

PS: In case you use qwerty for its better symbols instead of simple qwertz, i can recommend you one of the successors of the neo keyboard layot (https://neo-layout.org/, http://www.adnw.de/index.php?n=Main.HomePage, https://www.maximilian-schillinger.de/keyboard-layouts-neo-adnw-koy.html)

Thanks for the clarification. After the explanation it was clear I could use a hybrid -- use xkb-tools to set the WM's layout to us,de with a switch-layout-key managed directly by xkb, and using KMonad to get those special behaviours like mapping [home] to [capslock] for my emacs leader keys (doom with evil disabled and replaced by a customised xah-fly-keys map).
It's a pity there's no way to distinguish between the multiple [control] and [backspace] keys on my x-bows keyboard in a more granulated manner, but that's due to them all sending the same keycode.
@vherrmann, the person having my first name as a last name ;) -- thanks for pointing out the neo-... keymaps. They are somewhat intriguing, but would also force me to learn typing anew. I might if I find the time. My main reason for switching to US was not better symbols in the first place, but I my boss ordered me the x-bows keyboard and it would need one more key for a German layout (the one just next to the left shift) -- and having no | in the shell or no <> in React is kind of a bummer... I noticed only afterward that it saved me from rolling the thumb under my hand to type angular parantheses for example...

@hermann-p If you have the time someday and want to use neo, simply join the #neo irc, we can help you with using one of the neo-family with x-bows
PS: Please close the issue, as far as i see, all your questions were answered


Fix failing signature validation

The primary change here was making sure MarshalProtobuf is used for listing serialization rather than MarshalJSON.

Coverage increased (+0.9%) to 40.744% when pulling d63ff381b4961090f714d711bac747139a05f34e on failing-listing-sign-verify into 0a699e1f3a4f38be22d87ac9583d65b7db1a5a0b on ethereum-master.

Should this target ashwin's branch instead of ethereum-master?

No as the problems are in ethereum-master, which were merged into his branch from ethereum-master.


Automated cherry pick of #4557: add cloud account create&update options

Cherry pick of #4557 on release/2.12.
#4557: add cloud account create&update options

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.12@6cb1715). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.12   #4626   +/-   ##
==============================================
  Coverage                ?   6.87%
==============================================
  Files                   ?     502
  Lines                   ?   85552
  Branches                ?       0
==============================================
  Hits                    ?    5879
  Misses                  ?   79180
  Partials                ?     493

Flag
Coverage Δ

#aFlag
6.87% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb1715...cf42418. Read the comment docs.


Inconsistency with CI conda environment and test dependencies results in tests failing in local pip install.

https://github.com/TomNicholas/VirtualiZarr/pull/64/commits/5952cda0fd02e6a29a140b20997a45f52aa9d192 removed netCDF4 from test dependencies.  As per the xarray.to_netcdf docs

The default format is NETCDF4 if you are saving a file to disk and have the netCDF4-python library available. Otherwise, xarray falls back to using scipy to write netCDF files and defaults to the NETCDF3_64BIT format (scipy does not support netCDF4).

So without this dependency, the netcdf4 file in test_kerchunk will actually fallback to creating a NETCDF3_64BIT file causing assert failure.
The CI environment.yaml still contains the dependency so tests pass in the CI environment.

@TomNicholas I'll submit a PR for this, just wanted to make a note quickly as it was blocking my local tests.

Was this closed by #90?


xdg-desktop-portal: build failure when doCheck = false

Steps To Reproduce
When building xdg-desktop-portal with doCheck = false, the build fails with the error Program 'pytest-3 pytest' not found or not executable.
Build log
Log excerpt:
(...)
Program /nix/store/7753941pnr2kii6csvnj445r84rbv92f-glib-2.78.1-dev/bin/gdbus-codegen found: YES (/nix/store/7753941pnr2kii6csvnj445r84rbv92f-glib-2.78.1-dev/bin/gdbus-codegen)
Configuring xdg-document-portal.service using configuration
Configuring org.freedesktop.portal.Documents.service using configuration
Configuring org.freedesktop.impl.portal.PermissionStore.service using configuration
Configuring test.portal using configuration
Configuring limited.portal using configuration
Configuring org.freedesktop.portal.Documents.service using configuration
Configuring org.freedesktop.impl.portal.PermissionStore.service using configuration
Program pytest-3 pytest found: NO

tests/meson.build:268:9: ERROR: Program 'pytest-3 pytest' not found or not executable

A full log can be found at /build/source/build/meson-logs/meson-log.txt

Additional context
This is when trying to build NixOS 23.11. I've disabled the tests locally because the test-portals-inhibit test is failing non-deterministically on my systems (probably due to timing issues?).
Notify maintainers
cc @jtojnar @pks-t @bobby285271

Add a :+1: reaction to issues you find important.

Disabling checkPhase removes checkInputs so this is expected.
On Thu, 21 Dec 2023, 17:54 someplaceguy, @.***> wrote:

Steps To Reproduce
When building xdg-desktop-portal with doCheck = false, the build fails
with the error Program 'pytest-3 pytest' not found or not executable.
Build log
Log excerpt:
(...)
Program /nix/store/7753941pnr2kii6csvnj445r84rbv92f-glib-2.78.1-dev/bin/gdbus-codegen found: YES (/nix/store/7753941pnr2kii6csvnj445r84rbv92f-glib-2.78.1-dev/bin/gdbus-codegen)
Configuring xdg-document-portal.service using configuration
Configuring org.freedesktop.portal.Documents.service using configuration
Configuring org.freedesktop.impl.portal.PermissionStore.service using configuration
Configuring test.portal using configuration
Configuring limited.portal using configuration
Configuring org.freedesktop.portal.Documents.service using configuration
Configuring org.freedesktop.impl.portal.PermissionStore.service using configuration
Program pytest-3 pytest found: NO
tests/meson.build:268:9: ERROR: Program 'pytest-3 pytest' not found or not executable
A full log can be found at /build/source/build/meson-logs/meson-log.txt
Additional context
This is when trying to build NixOS 23.11.
Notify maintainers
cc @jtojnar https://github.com/jtojnar @pks-t https://github.com/pks-t
@bobby285271 https://github.com/bobby285271
Add a 👍 reaction
https://github.blog/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/
to issues you find important
https://github.com/NixOS/nixpkgs/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc
.
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/issues/275863, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFMEY5GB3N6Z2AS3DBWDZ3YKRSVJAVCNFSM6AAAAABA6VZZR6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TENZXGE3DENQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@jotjnar Please see #275867 for a potential fix.

test-portals-inhibit also fails non-deterministically on my system; maybe we can open another bug for this?


Improve story for "system modules"

@stellaraccident , for the Python bindings we can just pork-barrel all the needed VM modules, but for real use folks are going to want a better story. Filing this issue to keep track of it.

Can you elaborate @silvasean?
(doesn't make much sense without context)

In the python bindings we add modules hal and tensorlist into everything. Long-term for deployment, we need a better story, e.g. if a program doesn't use tensorlist, then we don't necessarily want the tensorlist module loaded. Similarly, if we are hypothetically in the future lowering directly to a Vulkan VM dialect, then we wouldn't want to load the hal dialect in deployments.
I think the questoin here is can we have a better story than "just link in modules and add them to your vm context until your program runs". E.g. could the compiler produce some sort of metadata (or perhaps we can read it already out of the flatbuffer) that we could use to generate a stub .cc file with the needed vm context initialization calls? (just a random idea of what this could look like).

Ah cool - didn't know this was at the python level - thanks!

I think it will also apply to non-python use cases down the road (should people link in the tensorlist module into their application when they use IREE? strings module? ...)

As you say, Sean, I kind of have in my mind that a module dependency (including some currently undefined notion of version) needs to be embedded in the flatbuffer binary in a similar way that dynamic library dependencies are embedded in a .so. Then the loading machinery can line up the runtime modules appropriately.
I don't have a specific design beyond that in mind, but I think that is the approach that resonates with me.
Just shoving it in the python API is very much a "get something working" step.

The work done on native_module provided a stable API for upper layers to inject modules that can interact with the lower layers. Tensorlist & co should be rewritten to use this.


minInclusive and maxInclusive

minInclusive and maxInclusive are not being set properly when XSD is converted to JSON Schema

Can you share me the XSD if possible?
Sent from My IPhone
On Wed, 14 Aug 2024 at 19:35, Rachel Dufour @.***>
wrote:

minInclusive and maxInclusive are not being set properly when XSD is
converted to JSON Schema
image.png (view on web)
https://github.com/user-attachments/assets/b5e41a8e-83ce-4383-a05b-8275f4e5d977
image.png (view on web)
https://github.com/user-attachments/assets/417a6abf-7223-43eb-b5ee-9d0601ee93b2
image.png (view on web)
https://github.com/user-attachments/assets/e8fd65cb-20b5-47e5-b01b-b11d1f46ada4
—
Reply to this email directly, view it on GitHub
https://github.com/pixelbyaj/vsc_xsd/issues/3, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFU4NEGIYAJAAUPVI4NV5LZROIM5AVCNFSM6AAAAABMQZUNH6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DMNBTGA2DIMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

new version released to resolve this issue


Merging with the chaos master 👍

🔥🔥🔥

The chaos master has accepted your pull request and successfully integrated your work with the latest (unpushed) version of PyLDFI!
Thanks for all your hard work, Sarah!


Mesh nodes not set to correct gridfunction

During my post processing updates, I noticed that the Jacobian calculations is using the beginning of time step coordinates rather than the end of time step coordinates of the mesh. I saw this in the deformation gradient calculations when it was giving me the previous time step values. I'm guessing this error was introduced at some point when doing all of the refactoring for the GPU stuff. Since, it was originally working correctly with the UMAT stuff based on the deformation gradients that were returned back then. Nominally, I wouldn't expect this to make a drastic difference if you have small time steps or going out to small strains. However, it'll definitely cause issues as your strains increase or you're taking large time steps.
I'll push a fix shortly and then will do a new release once I've quantified how a big a difference this makes for large strains. I'll probably do 2 commits for this. One with the fix and then one with the test rebases, so it's easier to see how things have changed.

This was fixed in the earlier commit, and it looks like for the loading direction that for deformations that were in the tens-hundreds of MPa that the values changed were in the KPa for 1% strain. However, I'll take a look at something that out's to 20-30% where I take larger step sizes to see how big of a difference we're really at in the end. Hopefully, it's within 1% error. Nonetheless, I'll push out a new release this weekend once I've add in the functionality to also output the volume average deformation gradient, and if you're running ExaCMech models then the plastic work.

With the release of version 0.5.0 this is now fixed. This is the version recommend for people to now run.
Additionally, I did a few large monotonic tension tests out to 25% engineering strain for a copper sample and only noticed errors within 1% for the macroscopic response. However, I can't say how bad the difference might be for more complicated loading conditions or the intragrain response would be. If a user does see larger differences I would be interested to hear about it.

If this was the issue with the jacobian being wrong but the residual was still correct then you would expect differences in convergence rate but not in quality of the solution for well-converged solutions, right?

On Apr 4, 2021, at 8:40 PM, Robert Carson @.***> wrote:

With the release of version 0.5.0 this is now fixed. This is the version recommend for people to now run.
Additionally, I did a few large monotonic tension tests out to 25% engineering strain for a copper sample and only noticed errors within 1% for the macroscopic response. However, I can't say how bad the difference might be for more complicated loading conditions or the intragrain response would be. If a user does see larger differences I would be interested to hear about it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

So, I think the converged solutions were close in the tests I was looking at for a few reasons. First, I think the fact that we're a velocity based code is a reason this wasn't caught sooner. I don't think I ever took more than a 1% strain step at a time, so the velocity gradients between time steps should be close in the fully developed plastic flow. Therefore, the stress should still be fairly close.
I've added a unit test that checks the volume average deformation gradient at each step to hopefully catch any potential future errors like this. Although, I don't think this should happen again as this was an artifact from when ExaConstit was using UMATs for things and we needed the beginning time step jacobians.

Ah — I thought you meant Jacobian just in the sense of the stiffness compression. Sounds like it was more than that.

On Apr 11, 2021, at 1:06 PM, Robert Carson @.***> wrote:

So, I think the converged solutions were close in the tests I was looking at for a few reasons. First, I think the fact that we're a velocity based code is a reason this wasn't caught sooner. I don't think I ever took more than a 1% strain step at a time, so the velocity gradients between time steps should be close in the fully developed plastic flow. Therefore, the stress should still be fairly close.
I've added a unit test that checks the volume average deformation gradient at each step to hopefully catch any potential future errors like this. Although, I don't think this should happen again as this was an artifact from when ExaConstit was using UMATs for things and we needed the beginning time step jacobians.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


Adding option to close stream of ArchiveReaders

Stack from ghstack:

#36
-> #35

@nivekt has imported this pull request.  If you are a Facebook employee, you can view this diff on Phabricator.


Feature Request: Gmail

From takeout, I only exported my Gmail account.  Ideally I could parse this into sqlite via this tool.

I've got this almost working. Just needs some polish

Awesome!

@Btibert3 I've opened a PR with my initial attempt at this.  Would you be willing to give this a try?
https://github.com/dogsheep/google-takeout-to-sqlite/pull/5

I am just seeing this sorry, yes!  I will kick the tires later on tonight.  My apologies for the delay.

Sorry for the delay, I got sidetracked after class last night.  I am getting the following error:
/content# google-takeout-to-sqlite mbox takeout.db Takeout/Mail/gmail.mbox
Usage: google-takeout-to-sqlite [OPTIONS] COMMAND [ARGS]...Try 'google-takeout-to-sqlite --help' for help.

Error: No such command 'mbox'.

On the box, I installed with pip after cloning: https://github.com/UtahDave/google-takeout-to-sqlite.git


Terraform definition does not perfectly record reality

There is something awry in the terraform definition whereby either or both of these is true:

It does not contain some default values
It opaquely sets some values, regardless of the current value

As a result, terraform apply always has changes.  Sometimes, there are changes to things like version numbers in AWS services that cause terraform to want to update certain configuration items, but this is not the case here.
To reproduce -

cd to a terraform directory (e.g. pipeline/terraform/2024-02-01)
terraform init
terraform plan

If this is an existing pipeline, set according to the tf definitions, it should say there is nothing to do.
It actually says 5 to add, 57 to change, 5 to destroy.

terraform apply (and yes to apply the change)
terraform plan again

The response is once again 5 to add, 57 to change, 5 to destroy.

container_definitions in the scaling service forces replacement.


Issues with Bam files from Dorado with segmeth

I merged the bam files from the modified 5mc and 5hmC from Dorado with samtools merge, I index and sorted it with samtools as well.
when I try to run methylartist segmeth with this bam file as my -b I get this as an error.
Traceback (most recent call last):
File "/usr/local/bin/methylartist", line 5522, in
main(args)
File "/usr/local/bin/methylartist", line 5210, in main
args.func(args)
File "/usr/local/bin/methylartist", line 2381, in segmeth
mod_names = mods_methbam(bam)
File "/usr/local/bin/methylartist", line 686, in mods_methbam
bam = pysam.AlignmentFile(bam_fn)
File "pysam/libcalignmentfile.pyx", line 751, in pysam.libcalignmentfile.AlignmentFile.cinit
File "pysam/libcalignmentfile.pyx", line 1000, in pysam.libcalignmentfile.AlignmentFile._open
ValueError: file has no sequences defined (mode='r') - is it SAM/BAM format? Consider opening with check_sq=False
Is there something I need to do to the bam files from dorado before merging and indexing them?

Apologies for the delay. If this is still relevant, can you check that there are reads in the .bam (samtools view)?
In general .bam files from dorado seem to work fine in methylartist without any further processing.


feat: Add ctrl.setResponse, ctrl.setError

Motivation

Way better names
Solution

Mark TODO to deprecate previous names in next sem major. Otherwise, both will continue to exist.

Codecov Report

Merging #2331 (a2c6c16) into docs/7.1 (a2c6c16) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head a2c6c16 differs from pull request most recent head 319249b. Consider uploading reports for the commit 319249b to get more accurate results

@@            Coverage Diff            @@
##           docs/7.1    #2331   +/-   ##
=========================================
  Coverage     98.22%   98.22%
=========================================
  Files           128      128
  Lines          2028     2028
  Branches        310      310
=========================================
  Hits           1992     1992
  Misses           19       19
  Partials         17       17

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Compilation and execution time of contracts test is slow

Area
[X] Plutus Foundation Related to the GHC plugin, Haskell-to-Plutus compiler, on-chain code
[] Plutus Application Framework Related to the Plutus application backend (PAB), emulator, Plutus libraries
[] Marlowe Related to Marlowe
[] Other Any other topic (Playgrounds, etc.)
Summary
Compiling and running the Plutus modules and test from hydra-plutus takes between 1 and 2 minutes which makes troubleshooting issues with small "probes" and test-driven development somewhat painful.
Steps to reproduce
Steps to reproduce the behavior:

Checkout the project at above commit
nix-shell && cabal test hydra-plutus to prime cache and compiler data
Make a minor change in OnChain module
recompile and run tests with time cabal test hydra-plutus
Observe results like:

1 out of 5 tests failed (6.99s)
Test suite hydra-plutus-test: FAIL
Test suite logged to:
/home/curry/hydra-poc/dist-newstyle/build/x86_64-linux/ghc-8.10.4/hydra-plutus-0.1.0/t/hydra-plutus-test/test/hydra-plutus-0.1.0-hydra-plutus-test.log
0 of 1 test suites (0 of 1 test cases) passed.
cabal: Tests failed for test:hydra-plutus-test from hydra-plutus-0.1.0.

real    1m34.826s
user    1m30.105s
sys     0m3.023s

Expected behavior
It's hard to give consensual "expectations" when it comes to compilation time, but comparing what happens in the hydra-node project which has ~40 modules and 70 tests is enlightening:
Finished in 9.2972 seconds
70 examples, 0 failures
Test suite tests: PASS
Test suite logged to:
/home/curry/hydra-poc/dist-newstyle/build/x86_64-linux/ghc-8.10.4/hydra-node-0.1.0/t/tests/test/hydra-node-0.1.0-tests.log
1 of 1 test suites (1 of 1 test cases) passed.

real    0m30.977s
user    0m21.054s
sys     0m3.017s

System info (please complete the following information):

OS: Ubuntu
Version: 20.04
Plutus version or commit hash: 5e20b2df3ac55b55b9d70eb7271b295ac797ed5e

Please, try 426ad89fcd937f3af15b89579761c6448145efce. #3846 should improve the situation.

36dcbb9140af0c9b5b741b6f7704497d901c9c65 is even better (from #3850).
I'm closing this issue because "slow" is a relative term and should be compared to something. The aforementioned improvements should help.
If there will be any questions please re-open the issue.

Thanks for the heads up. I agree "slow" is relative, in this context it means slow w.r.t. to standard Haskell compiling.

Yeah, I think we're hoping that the extra overhead from our stuff is no longer noticeable, do reopen if you find that isn't true.


[Feature Request] LLaMA2 PPO baseline support

Required prerequisites

[X] I have searched the Issue Tracker and Discussions that this hasn't already been reported. (+1 or comment there if it has.)
[X] Consider asking first in a Discussion.

Motivation

Motivation:
We need a PPO baseline based on LLaMA2 model.
Current problem:
I tried the latest code to reproduce beaver-7b. However, after running the code (using LLaMA2 pretrained model), I got the alpaca_eval score: win_rate=30.12, which is much lower than llama-2-7b-chat-hf (score: 71.37).
Unfortunately, currently, I could only apply for LLaMA2 model (I filled out the LLaMA form but didn't get response; I filled out the LLaMA2 form and get the model successfully).

Request:
Should there be any modificaition of the code or hyperparameters to produce a relative comparable baseline?
Solution
I suggest that baseline based on LLaMA2 should be provided (source code and final model weights).
Alternatives
No response
Additional context
No response
Checklist

[X] I have made every effort to write this issue in English, including all comments, the title, and the description.
[X] I have provided all relevant and necessary information above.
[X] I have chosen a suitable title for this issue.

Thank you for your question!
We tested our secure RLHF algorithm on alpaca 7b due to its earlier release time. Although we focus more on safe-related performance, as shown in your test results on alpca_eval, our algorithm can still improve the model's output capability.
We will also consider testing our algorithm and pipeline on llama 2, but considering the cost and time of collecting data, we regret to say that we will not be able to provide corresponding results and models in the short term. 😂

Hi, actually, I used LLaMA2 (not LLaMA model in your test) as the pretrained model to carry out RLHF and got the result score: 30.12.
The reason why I use LLaMA2 to reproduce your result is because I can't apply for LLaMA (as I explained, I filled out the LLaMA form but didn't get response; I filled out the LLaMA2 form and get the model successfully).
Question: RLHF result based on LLaMA2 is supposed to perform much better than result based on LLaMA, right? So, the fair comparision is with llama-2-7b-chat-hf (score: 71.37), right? @rockmagma02

Thank you for your question!
We tested our Safe RLHF algorithm on Alpaca-7b due to its earlier release time. Although we focus more on safe-related performance, as shown in your test results on alpca_eval, our algorithm can still improve the model's output capability.
We will also consider testing our algorithm and pipeline on Llama 2, but considering the cost and time of collecting data, we regret to say that we will not be able to provide corresponding results and models in the short term. 😂

May I ask what is your final result of Alpaca-7b w/o and with your Safe RLHF on alpaca-eval? The overall performance comparison should be introduced in the readme?

Thank you for your question!
We tested our Safe RLHF algorithm on Alpaca-7b due to its earlier release time. Although we focus more on safe-related performance, as shown in your test results on alpca_eval, our algorithm can still improve the model's output capability.
We will also consider testing our algorithm and pipeline on Llama 2, but considering the cost and time of collecting data, we regret to say that we will not be able to provide corresponding results and models in the short term. 😂

May I ask what is your final result of Alpaca-7b w/o and with your Safe RLHF on alpaca-eval? The overall performance comparison should be introduced in the readme?

I didn't test the provided Alpaca-7b on alpaca-eval. The evaluation method refers to the alpaca-eval github.

Hi, actually, I used LLaMA2 (not LLaMA model in your test) as the pretrained model to carry out RLHF and got the result score: 30.12. The reason why I use LLaMA2 to reproduce your result is because I can't apply for LLaMA (as I explained, I filled out the LLaMA form but didn't get response; I filled out the LLaMA2 form and get the model successfully).
Question: RLHF result based on LLaMA2 is supposed to perform much better than result based on LLaMA, right? So, the fair comparision is with llama-2-7b-chat-hf (score: 71.37), right? @rockmagma02

Hello, have you encountered a loss of nan while training with Llama2 weights (SFT and reward model)?

@jc-ryan Hi! We didn't encounter any 'nan' issues when training with Llama2. Just a heads up, we trained with 'bf16' precision.

@jc-ryan Hi! We didn't encounter any 'nan' issues when training with Llama2. Just a heads up, we trained with 'bf16' precision.

Okay, copy that. Thank you~

Closing due to inactivity. Please feel free to ask for a reopening if you have more questions.


Task PowershellV2 has not arguments field when inline is selected as type

The scriptblock is checked for variables so you don't need an argumentsfield. You can write
write-host "$(myMessage)"
where myMessage is a variable from your build or release

If your variable is scret you need to map it in the "Environment Variables" section of the task. Lets assume you map the scret variable  $(myMessage) to 'MYMESSAGE' you can then access it like
$secretvalue = $env:MYMESSAGE
Note that the variable my get replaced in the console output (which makes sense for secet variables) if you are trying to display it's value.  The script will still use the resolved value

I believe @JohannesDrexler is correct.

Secret variables are masked in the logs as ***
Here is a document describing working with secret variables. The first section has examples that illustrate the masking behavior. The second section recommends best practice to map a secret variable into your script.


WRO-5933: Fix ui test fail on jenkins(VirtualGridList)

Enact-DCO-1.0-Signed-off-by: Dongsu Won<EMAIL_ADDRESS>Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[x] At least one test case is included for this feature or bug fix
[x] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added

Need to change scrollTo() api to work after setState.

Resolution

Change scrollTo() api to work after setState.

Additional Considerations
Links
WRO-5933
Comments

Jenkins passed:
/job/enact-ui-tests/3396~3400


Fix Typo in Label

There is an typo in the label Compnent::Contexts.
I think it should be spelled Component::Contexts
😉

Fixed


Use Nix Flakes

Convert to using Nix Flakes and add GitHub Actions to automatically build a tarball

Thank you, this is pretty awesome! I will have a look in the next days.

Thank you, this is pretty awesome! I will have a look in the next days.

@Trundle I think this is ready for merge now
One suggestion though: should the default username of andy be updated, to something like nixos, if this can now be provided as a prebuilt tarball?

Thank you! I changed the default username to nixos in 1c13caed8ac906de6de8e7726e674cd72316e7e3.


Implementation of rotate algorithm, equivalent to std::rotate() in C++

Initial implementation of rotate function in stdlib. Ticket #SR-125
Is it the right place for this function?
Is it the right place for the test?

Dmitri, this should go to swift-evolution first, right?

@gribozavr that is.

@lattner Yes, it should.
@bolshedvorsky Please write an informal proposal to swift-evolution.  One piece of feedback that you could immediately incorporate is that this algorithm should be defined on MutableCollection instead of Arrray.

@bolshedvorsky Are you planning to work on this in a different PR?

Yes, I will work on this in a different PR. I'm finishing a formal proposal for this feature. I will create a new PR for this feature once the proposal will be accepted.

@bolshedvorsky Thanks!


LegacyPhoneFeatures issue in Injected.js (fixed in official whatsapp-web.js)

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
In Injected.js line 16, there is a line that causes Client initialize crash even if connection is good
You basically just have to comment this line to fix it, or you can get last version of whatsapp-web.js that also fixed the issue :
src/utils/Injected.js
[...]
window.Store.CryptoLib = window.mR.findModule('decryptE2EMedia')[0];
window.Store.DownloadManager = window.mR.findModule('downloadManager')[0].downloadManager;
// You just have to comment this line
// window.Store.Features = window.mR.findModule('FEATURE_CHANGE_EVENT')[0].LegacyPhoneFeatures;
window.Store.GroupMetadata = window.mR.findModule('GroupMetadata')[0].default.GroupMetadata;
window.Store.Invite = window.mR.findModule('sendJoinGroupViaInvite')[0];
window.Store.InviteInfo = window.mR.findModule('sendQueryGroupInvite')[0];
[...]

Expected behavior
I don't know why this line makes the creation bug, but sometimes window.mR.findModule('FEATURE_CHANGE_EVENT')[0] is not defined, so getting the index at 0 catches an error.
You can simply replace it by :
    const _features = window.mR.findModule('FEATURE_CHANGE_EVENT')[0];
    if(_features) {
        window.Store.Features = _features.LegacyPhoneFeatures;
    }

(That's what they did in wweb-js)
Steps to Reproduce the Bug or Issue
Create a new Client
Relevant Code
No response
Browser Type
Other (please write in Additional Context)
WhatsApp Account Type
Standard
Does your WhatsApp account have multidevice enabled?
Yes, I am using Multi Device
Environment
Os : Windows
Phone : Iphone
wweb.js-electron : last
Additional context
No response

Please check if this still happens with the new version


Added comment on parameterlength and extended the corresponding function in ANN.

Added parameterlength routine in AbstractNeuralNetworks and included this comment in the sympnet_tutorial file.

@benedict-96 The docs are failing to build because of a missing parameterlength method. Please check and fix.

Oh, of coure. Sorry. I added a method in AbstractNeuralNetworks (branch main) but that of course doesn't trigger a new release. Changed something in the script, the tests should go through now.


fix: use NODE_AUTH_TOKEN

:tada: This PR is included in version 1.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Don't set var keyword if namespace contains a dot

I've been using MyObject.myjson as namespace, but a var keyword was preceded by. This fix sets a var key word only if namspace doesn't contain a dot

I don't have time to maintain this package. Happy to transfer ownership.

Yes sure. I can maintain this package in the future.

I can't transfer to you until you delete your grunt-json fork.

Closed, feature is already implemented.


fix: Bump Metamask SDK version to fix webpack dynamic import issue

Bumps the metamask sdk version to 0.31.1 to fix the webpack dynamic import issue. Metamask SDK 0.31.0 has this issue and prevents @wagmi/connector from working in nextjs. See the next playground example on main to see the error. https://github.com/MetaMask/metamask-sdk/issues/1150
fixes #4432

Ideally this issue shouldn't have made it onto main, bumping the Metamask SDK version to 0.31.0 in #4422 caused this issue as there was a bug in that version of the Metamask SDK that prevented building with Webpack, breaking Nextjs. I'm able to reproduce this by simply running the next playground example, causing an immediate build error. Perhaps running the playground examples should be a requirement when bumping package version (or just generally).
In the long run, writing basic automated tests to boot up the playgrounds and use the basic functionality would be sufficient to prevent breaking end user apps in the future. If there's interest in going in this direction I'd be happy to look into it.

Please don’t spam these threads. Nothing is stopping you from doing an npm override.


Inability to have multiple connections to an external API simultaneously

I see that the library expects the client secret and client ID to be passed as hard variables to establish a "service" object in the getService() function-
Is there a reason why these aren't passed as parameters so, as the apps script developers, we could manage the establishment of any number of service objects (users of the software,) by entering different credentials as we like?

Those values do need to be passed into the Service object, but you don't have to hard code them as I show in the samples. You could load them from Properties or even an external server. That said, client ID and client secret are meant to identify the application, not the user. Each user gets a unique access token, but the same client ID and secret should be throughout.

Ah I see, sorry for the misinterpretation. I was trying to determine if the library had the ability to facilitate multiple users at the same time, and my question was pointed at the wrong specific details. This question still remains for me, however: Does this library allow for multiple user connections to the API to exist at the same time (and those credentials automatically managed and updated)? Or is the service object created for the user operating in the moment, and a connection thereby only existing every time the getService() function is called?

Sorry for the slow reply, and the answer is yes, it does. There are two things that control the connection:

The name of the service.
The property store used.

Usually you keep the name of the service the same for all users, and just change it if you are connecting to two or more OAuth providers. But if you set the property store to user properties, then each user will have their own tokens, AKA connection.


fix: make THOR repayments great again

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5898   👈

This stack of pull requests is managed by Graphite.


colors look bad on a light terminal

The cli colors are hardcoded and assume a dark background. They aren't readable on a light background. The screenshot shows how it looks on Solarized Light.
This isn't an easy change because it's all through the code, but I still think it's worth having an issue for.

What do other tools do to handle this? Do you simply turn off the color in tools like ls?

CLICOLOR=1 seems to do the trick for ls, not sure how it distinguishes light/dark, I don't have an LSCOLORS override. My .vimrc contains set background=light. git simply has color enabled.
Chalk doesn't support themes as easily as colors.js, but it appears to be possible, at least. It'd be a lot easier if all of p-cli's display code was wrapped, I think.

I agree this will be easier to customize when the CLI is more modularized.

I like the look of colors.js and the theming support, so that we can use named styles rather than raw colours. The system could provide a light/dark theme and try to make a sensible default choice, although the user can also specify the desired theme via env vars or a custom theme json file.

I use a white terminal with black text, which provides better contrast with the light grey text than the screenshot in the issue description.


Bug In Temperature Reporting

I noticed that my LG 4-Way-Cassette is always reporting the internal thermistor value in C9.
My Artcool Gallery behaves differently and responds with the value set by the controller.
This is a display issue though, the Cassette reacts correctly to whatever I set the room temperature in both Controller and 2TH mode.
I guess it just keeps reporting its internal sensor to display it in PREMBT001 along with the controller sensor:
[23:06:26][D][lg-controller:371]: sending A<IP_ADDRESS>.<IP_ADDRESS>F.<IP_ADDRESS>.F6 (13)
[23:06:26][D][climate:380]: 'LG Schlafzimmer' - Sending state:
[23:06:26][D][climate:383]:   Mode: HEAT
[23:06:26][D][climate:388]:   Fan Mode: LOW
[23:06:26][D][climate:400]:   Swing Mode: OFF
[23:06:26][D][climate:403]:   Current Temperature: 17.50°C
[23:06:26][D][climate:409]:   Target Temperature: 17.00°C
[23:06:26][W][component:214]: Component <unknown> took a long time for an operation (0.54 s).
[23:06:26][W][component:215]: Components should block for at most 20-30ms.
[23:06:31][D][lg-controller:525]: update
[23:06:31][D][lg-controller:387]: received A<IP_ADDRESS>.<IP_ADDRESS>F.<IP_ADDRESS>.F6 (13)
[23:06:31][D][lg-controller:396]: verified send
[23:06:37][D][lg-controller:525]: update
[23:06:50][D][lg-controller:371]: sending A<IP_ADDRESS>.<IP_ADDRESS>F.<IP_ADDRESS>.F6 (13)
[23:06:50][W][component:214]: Component <unknown> took a long time for an operation (0.51 s).
[23:06:50][W][component:215]: Components should block for at most 20-30ms.
[23:06:55][D][lg-controller:525]: update
[23:06:55][D][lg-controller:387]: received A<IP_ADDRESS>.<IP_ADDRESS>F.<IP_ADDRESS>.F6 (13)
[23:06:55][D][lg-controller:396]: verified send
[23:07:01][D][lg-controller:525]: update
[23:07:13][D][lg-controller:582]: line busy, not sending yet
[23:07:19][D][lg-controller:525]: update
[23:07:19][D][lg-controller:582]: line busy, not sending yet
[23:07:25][D][lg-controller:525]: update
[23:07:25][D][lg-controller:387]: received C<IP_ADDRESS>.<IP_ADDRESS>A.<IP_ADDRESS>.9B (13)
[23:07:25][D][sensor:094]: 'Error Code': Sending state 0.00000  with 0 decimals of accuracy
[23:07:25][D][climate:380]: 'LG Schlafzimmer' - Sending state:
[23:07:25][D][climate:383]:   Mode: HEAT
[23:07:25][D][climate:388]:   Fan Mode: LOW
[23:07:25][D][climate:400]:   Swing Mode: OFF
[23:07:25][D][climate:403]:   Current Temperature: 23.00°C
[23:07:25][D][climate:409]:   Target Temperature: 17.00°C
[23:07:25][D][climate:380]: 'LG Schlafzimmer' - Sending state:
[23:07:25][D][climate:383]:   Mode: HEAT
[23:07:25][D][climate:388]:   Fan Mode: LOW
[23:07:26][D][climate:400]:   Swing Mode: OFF
[23:07:26][D][climate:403]:   Current Temperature: 23.00°C
[23:07:26][D][climate:409]:   Target Temperature: 17.00°C
[23:07:26][D][lg-controller:387]: received C<IP_ADDRESS>.<IP_ADDRESS>A.<IP_ADDRESS>.9B (13)

My fix for this is simple:
https://github.com/florianbrede-ayet/esphome-lg-controller/commit/b3d24963acff562d88caefb8056cbf7a7d67a934
Since I already added some functionality (hysteresis to fix the stupid LG behaviour in heating mode, setting installer messages in yaml, configurable setpoint thresholds), I wasn't sure if you're interested in a full PR.

Hm this sounds similar to the behavior the reporter in issue #4 was seeing. I actually wish my units would still report the internal temperature... I can land your fix.

Since I already added some functionality (hysteresis to fix the stupid LG behaviour in heating mode, setting installer messages in yaml, configurable setpoint thresholds), I wasn't sure if you're interested in a full PR.

In case it helps: a few days ago I set installer setting 15 (heating temperature thresholds) to 4 (-0,5C/+0,5C). This makes my units work a lot more like how I want them to. In HA I use a filter sensor to average the temperature over 10 minutes to make it not turn on/off too aggressively.

I need to experiment more with the overheating.
The artcool gallery is complete design failure, its layout makes it impossible to work well for heating.
It has an airflow loop from the side vents to the intake.
It would help to control them individually, but that seems to be unsupported.
When I set it to 4, it won't heat anymore, because the ambient heat from the copper pipes is enough to heat the thermistor above 20°C at all times even with the fan running.
Do you know if the installer setting (0: default for unit, 1: +4C/+6C, 2: +2C/+4C, 3: -1C/+1C, 4: -0.5C/+0.5C) should apply to both unit and external controller thermistor?
Because by default, the device overheats by at least 6°C.
As soon as I set it to external controller however, it stops at >+2°C without changing the setting above.

Do you know if the installer setting (0: default for unit, 1: +4C/+6C, 2: +2C/+4C, 3: -1C/+1C, 4: -0.5C/+0.5C) should apply to both unit and external controller thermistor?
Because by default, the device overheats by at least 6°C. As soon as I set it to external controller however, it stops at >+2°C without changing the setting above.

My units behave the same in this regard with internal or external sensor. The default setting for wall units is +1/+3, so when I started using an external sensor I had to set it to 19C to make it turn on at 20C and off at 22C. Changing this installer setting to 3 or 4 fixed that; I can now set it to 20.5 or 21.
My wall units also aren't ideal for heating, especially for my unit that's near a corner. Fortunately the external sensor fixes most of that.


running py2neo with threading lock() and queue freeze on create relationship

I have experiencing some issue when creating relationship using thread.
simplify of my code
import queue
import threading
from py2neo import Graph
GRAPH_HOST = "bolt://localhost:7687"
GRAPH_PASS = "......."

exitFlag	= 0
threadList 	= ["Thread-1","Thread-2", "Thread-3"]
queueLock 	= threading.Lock()
workQueue 	= queue.Queue(20000)

class myThread (threading.Thread):
  def __init__(self):
    threading.Thread.__init__(self)
    pass

  def run(self):
    graph_consumer()

def graph_consumer():
  while True:
   if not redisQueue.isEmpty():
     data = redisQueue.get()
     userid = data['userid']
     item_id = data['item_id']
     graph.run(f"MATCH (n:Person {{userid:{userid}}) MATCH (m:Item {{item_id:{item_id}}) MERGE (n)-[a:buyer]->(m) return n.name")

that query will freeze my script. it only affected on creating relationship, creating node working fine.
I guess there is something with threading.Lock() or queue.Queue() function. Since actually I did not use threading.Lock()  and queue.Queue() , it just junk in my code (copy-paste from old script).
after I remove those two lines, it working great.

This is unlikely to be a specific problem with py2neo, although if you can narrow it down to code that can be used an a test, please reopen the issue.
Note also that graph.run results should be consumed. You are RETURNing values, but not using them.


benchmark non-temporal xsk memcpy

Description
Describe the purpose of and changes within this Pull Request.
We tried this years ago, with ambiguous results. See if anything has changed.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?
Installation
Is there any installer impact for this change?

The first iteration shows a dramatic perf regression for RX on x64, and nearly no change for arm64.

Abandoning this for now. It would be interesting to retry this once we stabilize two-machine netperf tests.


Script indentation

It would've been nice to have indentation inside script tag.
<script setup lang="ts">
  defineProps<{
    modelValue: unknown[]
  }>();
</script>

instead of
<script setup lang="ts">
defineProps<{
  modelValue: unknown[]
}>();
</script>

I'm not using dprint anymore, so I won't spend time adding features to this plugin.
However I'm open to pull request, if you have the time.


"Find" doesn't find overlapping matches

This is a feature, but I will add checkbox to disable this behavior

merged to master


not found Interact, ServeHTTP

This is the code in the llm_chain example, I don't find package serve
from serve import Interact, ServeHTTP

Hey @ngoanpv, unfortunately, that was old code & we missed removing the readmes. I've removed them now. Please follow this readme to deploy your apps as REST/WebSocket APIs instead.


Added code for Colorful Fixed Header

Related Issue
Added Colorful Fixed Header
Closes: #245
Describe the changes you've made
Added 3 new files

assets/css/colorful_fixed_header.css
assets/js/colorful_fixed_header.js
public/colorful_fixed_header.html

The files contain code for a fixed header which changes color based on the scroll.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
NA
Checklist:

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] New and existing unit tests pass locally with my changes.

Screenshots

Before Scroll

After Scroll

@urvashi-code1255
@Vishal-raj-1
Request you to review it.
Thanks!

Also check the conflicting file

@Nkap23 ??


Unify copys and/or buttons in new modals

So...

'CLOSE' should never be present in the bottom left.
Not sure if removing the CLOSE button when being the only action.

@josecruz can you take a look at the actual UI to start unifying this?

We only keep the button on the bottom area when is the only action. I'll create a new issue with the list of modal that we need to modify.

Created new issue here #4378


fix: repairs $EXTRA_COMPILER_ARGS error with multiple args

Summary:
Fixes a regression added on merge of #37531 (though oddly I don't see it in #37531's diff, so perhaps added during conflict resolution?) where multiple arguments in $EXTRA_COMPILER_ARGS are now incorrectly wrapped in quotes, including RN's own sourcemap support:
runner@SeansMacBookGo sampleapp % /Users/runner/builds/y_x6gsp4/0/sampleapp/ios/Pods/hermes-engine/destroot/bin/hermesc -emit-binary -max-diagnostic-width=80 '-O -output-source-map' -out /Users/runner/builds/y_x6gsp4/0/sampleapp/ios/build/derived-data/Build/Intermediates.noindex/ArchiveIntermediates/sampleapp/BuildProductsPath/Release-iphoneos/sampleapp.app/main.jsbundle /Users/runner/builds/y_x6gsp4/0/sampleapp/ios/build/derived-data/Build/Intermediates.noindex/ArchiveIntermediates/sampleapp/BuildProductsPath/Release-iphoneos/main.jsbundle
hermesc: Unknown command line argument '-O -output-source-map'.  Try: '/Users/runner/builds/y_x6gsp4/0/sampleapp/ios/Pods/hermes-engine/destroot/bin/hermesc -help'
hermesc: Did you mean '-output-source-map'?

Changelog:

[IOS] [FIXED] - Fix build error when there are multiple EXTRA_COMPILER_ARGS
Test Plan:
Removing the quotes and running the command results a successful run of hermesc (exit code 0 and the expected files produced).

I have noticed the same issue as well, I cannot generate sourcemaps on iOS with RN 0.72.
I've applied the changes described here with the following test plan to further test this fix and can attest that it works:

Create a new RN project using npx react-native@latest init SourcemapsDemoApp
Add export SOURCEMAP_FILE=./main.jsbundle.map to the end of the ios/.xcode.env file
Open the project on XCode with xed ios
Change the XCode Scheme to set "Release" as build configuration
Build the project
The build fails
Edit node_modules/react-native/scripts/react-native-xcode.sh with the content from this PR
The build succeeds
Remove the line from ios/.xcode.env and rebuild
The build succeeds again

Thanks for noticing. It was a mistake on my side. I'm going to have this landed.


How can I run visda18?

Thank you for sharing your code.
Recently I'm trying to reproduce your work on the visda18 dataset.
On the other hand, it seems that the pair-wise computation of s3vaada consumes a lot of CPU memories.
In my case on visda18, s3vaada consume more than 180G of CPU memories which is not feasible.
Can you share the evaluation protocol and running options for visda18?

Thanks for the comment.

We removed other classes from the VisDA-18 dataset to make it similar to AADA. For your reference, we attached a zip file containing a script to download and extract VisDA-18 data which we used for training. Please run the script datasets/ to avoid any path issues.
getvisda18.sh.zip
Also, make sure to turn on the lr schedular during VisDA-18 training as stated in paper.
To run the code for VisDA, we recommend using the following command:
python main.py --name s2r-s3vaada --source synthetic --target real

Hope this will help.

Hi @sehyun03 if your problem is resolved can we close this issue?


karma - Error: no such file or directory

I'm currently trying to get enzyme working with an karma, webpack, mocha setup.
Unfortunately karma does not find a configuration file, when I am using enzyme.
I am reporting the bug in the enzyme repo since everything works fine until I import enzyme.
Note, that I don't need to call any functions of enzyme, importing like
import {shallow} from 'enzyme';

is enough to trigger the error.
Needless to say, the file exists and has the following content
const integrationTests = require.context(
  '../../src',
  true,
  /([\w-]+\/)*\/test\/[\w-]+\.spec\.js$/
);

integrationTests.keys().forEach(integrationTests);

This is the error message I get:
> env BABEL_ENV='test' node node_modules/karma/bin/karma start build/karma/karma.conf.js

01 04 2016 10:44:33.499:ERROR [karma]: { [Error: no such file or directory]
  code: 'ENOENT',
  errno: 34,
  message: 'no such file or directory',
  path: '/_karma_webpack_/build/webpack/tests-integration.config.js' }
Error: no such file or directory
    at MemoryFileSystem.readFileSync (/Users/name/Project/node_modules/memory-fs/lib/MemoryFileSystem.js:107:10)
    at MemoryFileSystem.readFile (/Users/name/Project/node_modules/memory-fs/lib/MemoryFileSystem.js:297:21)
    at doRead (/Users/name/Project/node_modules/karma-webpack/index.js:156:26)
    at Plugin.readFile (/Users/name/Project/node_modules/karma-webpack/index.js:160:3)
    at _combinedTickCallback (node.js:376:9)
    at process._tickCallback (node.js:407:11)
Hash: 3c5b4b6d5b26acf0d742
Version: webpack 1.12.9
Time: 8562ms

I am using
react: 0.14.8
enzyme: 2.2.0
karma 0.13.22

Does anyone know how to fix this issue? Or how I can debug this?
Any help would be greatly appreciated. :-)

Hi.
I had the same issue and I solved it  by adding this config in my karma.conf.js file as mentioned in the enzyme documentation (http://airbnb.io/enzyme/docs/guides/karma.html)
config.set({
  ...
  webpack: {
    ...
    exernals: {
      'react/lib/ExecutionEnvironment': true,
      'react/lib/ReactContext': true
    }
  }
});

hope that helps

@Terminux Thank you for the link, this was one of the problems I had.  An other one was https://github.com/cheeriojs/cheerio/pull/832.
Note to myself: debugging webpack is easier when the webpack NoErrorsPlugin is commented out.

@Terminux 's solution is correct. Just notice that exernals should be externals :)


ERROR: value is invalid for target location

Hi there,
Thank you for this great library which saves us!
I have a User class which has a UserProfile property. UserProfile property has OnboardingStatus field. When I try to update the Onboarding status it throws error:
SystemTextJsonPatch.Exceptions.JsonPatchTestOperationException: The value '{                 "OnboardingStatus": 1             }' is invalid for target location.
This is how I call the API:
{
    "Username"<EMAIL_ADDRESS>    "PatchDocument": [
        {
            "op": "replace",
            "path": "/UserProfile",
            "value": {
                "OnboardingStatus": 1
            }
        }
    ]
}

These are the classes for User and UserProfile:
public class User
{
	public Guid Id { get; set; }
	public required string ClerkUserId { get; set; }

	public UserProfile? UserProfile { get; set; }

	public ICollection<Organization> Organizations { get; } = new List<Organization>();
}

public class UserProfile
{
	public Guid Id { get; set; }

        public required string Username { get; set; }

	public required string FirstName { get; set; }
	public required string LastName { get; set; }

	public required string Email { get; set; }

        public required int OnboardingStatus { get; set; }

	public Guid UserId { get; set; }
	public User? User { get; set; }
}

Thank you for your assistance!

Hi @SihirliDev
Thanks for reporting the issue.
I can try to take a look when time permits.
If you want to speed up getting this fixed, could you please create a complete repro in a Github project or a zip file with complete source code.
Thanks

Hi again,
After investigating the problem so far, I could find that I didn't include the UserProfile property in my query. Added it, and it works.
So, there is no issue related to this package.
Thank you for your interest and have a wonderful day!


Test UI does not appear in activity bar

I installed the Mocha Test Explorer, the Angular/Karma Test Explorer and with them the Test Explorer UI. You can see them installed in the screenshot. Yet the lab flask icon does not appear in the activity bar and the UI does not seem to be present or accessible.

VSCode 1.47
macOS 10.14.6

Did you set testExplorer.hideWhen in your VSCode settings? Otherwise I don't know how this could happen.

Thanks for responding. I have this setting set to "never".

Thanks for responding. I have this setting set to "never".

Hmm, interesting. In this case it should always appear in the activity bar.
I still can't figure out how it is possible that it doesn't.

If there is any more information I can provide from my end, let me know.

Hi, I have the same problem with

VSCodium
Test Explorer UI 2.19.1
Fedora 32 - Wayland

I found out that in my case the problem seems to be the VSCodium package repository. It seems to be different than the MS repository and for whatever reason the version from that repository does not work. Using the Microsoft Repository, the extension works again.

I found out that in my case the problem seems to be the VSCodium package repository

It turns out that the version of the extension published on open-vsx.org was broken. I republished it and now it should work.

@dschuessler I just tried installing the Mocha and Karma Test Explorers in a fresh install of VSCode in MacOS 10.15 and it did work as expected (i.e. the Test Explorer UI appears and I could interact with Mocha tests). You could try the same (e.g. in the Guest user account of MacOS or by renaming ~/.vscode and ~/Library/Application Support/Code) to see if this issue is triggered by some other extension or some VSCode setting.

@hbenl This is not necessary. I had installed the extension via VSCodium as well and just checked that it is not a VSCodium related error by starting up VSCode using the same extension directory. So VSCode was using the version from Open VSX as well. It did not occur to me that the installation source could be important for the reproduction of the error.
I updated the extension and the icon is appearing now. Thank you for investigating this!

It did not occur to me that the installation source could be important for the reproduction of the error.

It didn't occur to me either. Thanks to @jounathaen for pointing this out!


iOS Demo Pod install error

i can search "Tensorflow", but can not install example : https://github.com/tensorflow/examples/tree/master/lite/examples/gesture_classification/ios
Error info:

As mentioned in step 2 did you change your directory to lite/examples/gesture_classification/ios
before running pod install

not work

Can you also try pod install --repo-update --verbose?
Also, what specific version of pod tool are you using?

It has been 15 days with no activity and the awaiting response label was assigned. Is this still an issue?

@WPDreamMelody
Any update on this issue please.Thanks!

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


After adding a POST user should land on FP Feed page.

Open "https://staging.fightpandemics.work"
Login using valid email/password
Create a POST and if you have multiple POST existing, then the POST will be added randomly but not as new/recent POST on the top.

Issue#1: User should land on FEED page rather than FP home page.
Issue#2: While adding multiple POST, the recent POST should be added on the top, currently it is added at the last of the users POSTs.
P.S. the video zip file for the functionality.
Screen Recording 2020-06-25 at 4.54.03 PM.zip

I will be closing this issue since we have already something on going for this. @ppagarawal and @jyclam have decided that we will give the option to the user to navigate to the newly created post (view post) or close the modal of success on post creation. Please refer to #636 & #687.

Also, I would highly encourage you to use a tool such as this one -> https://www.getcloudapp.com
This app will allow you to record short gifs for about 15secons and short videos if you need to and give you a URL that you can post here, and Engineers will be able to see it on the cloud without having to download a file, and then unzip and then play...

Also, I would highly encourage you to use a tool such as this one -> https://www.getcloudapp.com
This app will allow you to record short gifs for about 15secons and short videos if you need to and give you a URL that you can post here, and Engineers will be able to see it on the cloud without having to download a file, and then unzip and then play...

Sure, thnx for sharing.


Upgrade cardigan node version to 20

What does this change?
It upgrades the version of Node that our Storybook instance (Cardigan) runs on from 16 to 20.
How to test

rm -rf node_modules
yarn cache clean
you may need to run yarn global add node-gyp locally to prevent a warning about optional dependencies in the next step
yarn

Have we considered potential risks?
I had to upgrade the elastic-apm-node package in order to upgrade Node – it was a point release so there shouldn't be any changes, but we should keep an eye on the monitoring after this is merged to check that it's good.

Can we add an .nvmrc file to specify which node version is required?

I ran your recommended steps (on node v20.15.0) and it went nicely, I was able to run the app.
I didn't need yarn global add node-gyp.


how to get device status while filtering services?

I have such a code
devices = nb.dcim.devices.filter(status="active", has_primary_ip=True)

then i want to join this with
services = nb.ipam.services.filter(tag=[some_tag])

is there way how to get only active devices with primary ip ?
the only found now approach is to iterate over services
    services = nb.ipam.services.filter(tag=[some_tag])
    for service in services:
        # todo: remove subqueries. too slooow
        if service.device.status.value != "active":
            continue
        if service.device.primary_ip.status.value != "active":
            continue

looks like i am watching something like  this
services = nb.ipam.services.filter(tag=[some_tag], device__status="active", device__primary_ip__status=="active")

Yeah, sorry, that relationship doesn't look like it's exposed via the REST API. We have to work with what that API allows us to do.