DELETE object does not delete writing state manifests [JIRA: RCS-316]

At tag 1.2.2 (expected result, {leeway_seconds, 2} in app.config):
# Try PUT 1GB object and disconnect in uploading (by Ctr-C)
$ s3cmd --disable-multipart -c .s3cfg.8071.alice put /data/static/rand.1GB s3://test
/data/static/rand.1GB -> s3://test/rand.1GB  [1 of 1]
   26419200 of<PHONE_NUMBER>     2% in    2s    11.39 MB/s^CSee ya!

# Then inspect the bucket, there is one 'writing' manifest
$ scripts.local/riak_cs_inspector.sh <IP_ADDRESS> dev1 test
Key ============================: Sibl. == State ========== UUID =========================== Content-Length== First Block ====
rand.1GB                        : 1        writing          8334e5fc480c4ea1836226701a643451<PHONE_NUMBER> Found

# Wait 2 sec (= leeway_seconds) and delete it
(py27_base)shino@shino-xub-vbox$ s3cmd -v -c .s3cfg.8071.alice del s3://test/rand.1GB
INFO: Applying --exclude/--include
INFO: Summary: 1 remote files to delete
File s3://test/rand.1GB deleted

# The manifest turns into 'scheduled_delete', nice
$ scripts.local/riak_cs_inspector.sh <IP_ADDRESS> dev1 test
Key ============================: Sibl. == State ========== UUID =========================== Content-Length== First Block ====
rand.1GB                        : 1        scheduled_delete 8334e5fc480c4ea1836226701a643451<PHONE_NUMBER> **Not Found**

# After GC, the manifest disappears
$ scripts.local/riak_cs_inspector.sh <IP_ADDRESS> dev1 test
Key ============================: Sibl. == State ========== UUID =========================== Content-Length== First Block ====

At 1.4.3 (unexpected, also {leeway_seconds, 2} in app.config)
# Try PUT 1GB object and disconnect in uploading (by Ctr-C)
$ s3cmd --disable-multipart -c .s3cfg.8071.alice put /data/static/rand.1GB s3://test
/data/static/rand.1GB -> s3://test/rand.1GB  [1 of 1]
   19075072 of<PHONE_NUMBER>     1% in    1s    17.64 MB/s^CSee ya!

# Then inspect the bucket, there is one 'writing' manifest
$ scripts.local/riak_cs_inspector.sh <IP_ADDRESS> dev1 test
Key ============================: Sibl. == State ========== UUID =========================== Content-Length== First Block ====
rand.1GB                        : 1        writing          4e1c3f19082048e496c44c7a05eeccc9<PHONE_NUMBER> Found

# Wait 2 sec (= leeway_seconds) and delete it
$ s3cmd -v -c .s3cfg.8071.alice del s3://test/rand.1GB
INFO: Applying --exclude/--include
INFO: Summary: 1 remote files to delete
File s3://test/rand.1GB deleted

# The manifest still remains in 'writing' state.
$ scripts.local/riak_cs_inspector.sh <IP_ADDRESS> dev1 test
Key ============================: Sibl. == State ========== UUID =========================== Content-Length== First Block ====
rand.1GB                        : 1        writing          4e1c3f19082048e496c44c7a05eeccc9<PHONE_NUMBER> Found

1.4.0 and 1.3.2 show the same result as 1.4.3.

Partial solution is #1280 that collects manifest and blocks when a socket was closed by client or any other errors. Do we add another work on "existing" stale write objects?

For existing manifests (writing and pending_delete) should be treated in another way, I think. #937 is the issue for that. So, I agree that #1280 is good solution for this issue.

For release note:
The issue was, if there was a canceled upload, manifest was left as writing and no overwrite happened then those partially uploaded blocks and manifest were to be left as it was and occupies certain disk space. This is fixed by adding additional error handling routine to move the manifest to GC bucket by catching socket error.

Although, there might still be chance to leave such manifest in case of CS node failure, which are to be collected by #937 fixes.

So far I close this issue and let us track #937.


Update the default value of unsafeDisableTooltip to false and remove redundant props and wrappers

Closes https://github.com/primer/react/issues/2008
Related https://github.com/primer/react/issues/4696

[!NOTE]
We managed to complete the roll out at dotcom  🎉  (View the progress here (internal link only))

Changelog

Changed

The default value of unsafeDisableTooltip to false
Added unsafeDisableTooltip={true} a coupe of IconButton instances where it is not safe to enable tooltips.

Removed

Explicit Tooltip wrappers
unsafeDisableTooltip={false} prop since it is the default value now.

Rollout strategy

[ ] Patch release
[x] Minor release
[ ] Major release; if selected, include a written rollout or migration plan
[ ] None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

[x] Added/updated tests
[ ] Added/updated documentation
[x] Added/updated previews (Storybook)
[ ] Changes are SSR compatible
[x] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge
[ ] (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

Integration tests pass https://github.com/github/github/pull/332110 and tested on RL, everything looks good 🎉


Look into ClientSMDatabaseTransaction

This might have become redundant due to a recent refactor by @dpc. ClientSMDatabaseTransaction was introduced to limit a DBTX to the module's DB partition when owned by a module, but allow general DB access when owned by core code. I think to remember having seen something similar under a different name recently.

I will also review this when I can

Unless I'm missing something, with the refactored database structures I still don't see an easy way to convert a "prefixed" DatabaseTransaction back to a non-prefixed DatabaseTransaction, which I believe is what we need. The tricky part is that the module code needs access to the global database transaction (e.g for functions like claim_input, so we can't just pass the prefixed DatabaseTransaction from the executor to the state transition function.
Some other possible options:

Pass the module instance id into the state transition function. Breaks some of the abstraction but this is essentially what we're doing with ClientSMDatabaseTransaction anyway.
Add a strip_prefix or something to DatabaseTransaction to allow going from a prefixed transaction back to a global transaction.
Just refactor ClientSMDatabaseTransaction into fedimint-core and rename it so its not just a client-side abstraction. This struct could hold an (optional) prefix and have the ability to access either the global dbtx or the prefixed dbtx

This might have become redundant due to a recent refactor by @dpc. ``

I've looked at it while doing the refactor and I don't think they are redundant. ClientDbTxContext is the new similar struct, and maybe they can be unified, but I kind of doubt it, because ClientDbTxContext has a wider "scope/meaning" and thus comes with bunch of extra operations (and possibly even more in the future).

Pass the module instance id into the state transition function.

Breaking abstraction doesn't seem worth it.

Add a strip_prefix or something to DatabaseTransaction to allow (..)

Breaks abstractions. We do not want the module to have any ability to get access to global db.

Just refactor ClientSMDatabaseTransaction into fedimint-core

The abstraction / isolation depends on pub(crate) fn global_tx which will break if we move it out of fedimint-client
Generally I don't see any problem with ClientSMDatabaseTransaction to justify any extreme changes. Maybe we could rename to StateTransitionTransaction or StateTransitionContext etc. to clarify and make the name less cryptic. Or merge it with DynGlobalClientContext or something.
If we wanted to get rid of t, then the way to do it would be to break the call chain to avoid needing it. The module state transition logic is potentially calling something like:
global_context.claim_input(dbtx, input).await.0

"to call-in into internal logic" which under the hood "unwraps the global dbtx out of dbtx.
I find it all quite reasonable, similiar to how ClientContext works and don't see any good way to get rid of the whole thing completely.


os: File implicitly closed when garbage-collected due to runtime finalizer but this behavior is not documented

What version of Go are you using (go version)?

$ go version
go 1.15.2

Does this issue reproduce with the latest release?
Yes.
What operating system and processor architecture are you using (go env)?
Linux and macOS.
What did you do?
Code: https://play.golang.org/p/YmHIIc7sha4
Note: This does not reproduce in go playground, but can reproduce on my mac/linux.
What did you expect to see?
No panic.
What did you see instead?
panic: bad file descriptor
Reason
I found that this is because there's an implicitly close call when the file object is garbage-collected.
In os/file_unix.go:
func newFile(fd uintptr, name string, kind newFileKind) *File {
	...

	runtime.SetFinalizer(f.file, (*file).close)
	return f
}

What do I expect
I know there's thousands of method to avoid being garbage-collected such as runtime.KeepAlive, but I think this is unreasonable, either this behaviour should be removed or the file object should not be garbage-collected.
If a user forgets to call file.Close, the memory should be leaking.
Also, this behaviour isn't documented anywhere.

Thank you for filing this issue @PureWhiteWu!
Unfortunately we can’t remove this behavior, but perhaps we can document it. I worry thought that documenting that files have finalizers might encourage callous behavior in which folks just rely on garbage collection to sort out for them file close problems which will cause undeterministic leaks and bugs. I understand that in between invoking syscall.Write(fd, payload) and the end, a garbage collection cycle might run, but unfortunately that program has a leak that then depends on undefined behavior. How often have you seen such code?

@odeke-em Thanks for your reply!
This is a bug we encountered in our real-world program, in which we are doing something like this(simplified version):
// open the file
file, err := os.OpenFile("x", os.O_RDWR, 0666)
...
// get its fd
fd := int(file.Fd())
// do some work using syscall directly forever
for {
    data := getData()
    syscall.Write(fd, data)
    ....
}
syscall.Close(fd)

And we got -9 (bad fd) after some time.
This bug is hard to debug, so I think something should be changed to prevent this.

Gotcha, I understand and thank you for the citation. For some remedies:
a) defer file.Close()
b) runtime.KeepAlive(file) although that would mask the problem with the missing file.Close()
Some docs updates to state that a file might be garbage collected perhaps could have helped you in this case then, if we stated the need to keep the file alive for the course of usage or to ensure it is closed, but the finalizer is an implementation/system specific detail. It is definitely inconvenient to try to go down many rabbit holes trying to figure out why a bad fd error occurred.

/cc @ianlancetaylor

Also, this behaviour isn't documented anywhere.

It is documented. The os.File.Fd documentation says, in part,

The file descriptor is valid only until f.Close is called or f is garbage collected.

It sounds like you already understand the problem and the workarounds from your original description.

This bug is hard to debug

Perhaps, though the crash seems fairly hard to miss.
In any case, if you're using direct syscalls to write files rather than the usual mechanisms, you should be prepared for some amount of tricky debugging.

@cespare Thanks very much, I missed this part.

Perhaps, though the crash seems fairly hard to miss.

In some cases, the for loop may quit before gc, so this may occur occasionally. I think this is really hard to debug for users, because users are not expected to understand how gc works and when will gc execute.
@odeke-em Thanks for your reply, I think defer file.Close() makes sense in this situation.
But maybe we can make things more clearly, such as adding an extra line:
// File represents an open file descriptor.
// Note: File.Close is automatically called if it hasn't been when it is garbage collected.
type File struct {
	*file // os specific
}

Related issue: #34810

The problem here is the call of the Fd method, and the Fd method is the place to document any possible issues with the finalizer.  As @cespare points out, the Fd docs already say "The file descriptor is valid only until f.Close is called or f is garbage collected."  Can we make that clearer?  More prominent?
I do not think we should add any documentation to os.File because there is no problem with ordinary use of os.File.  The problem only arises for programs that call the Fd method, which is a rare case.  Most programs that need to all Fd should instead be using syscall.Open or the SyscallConn method.  Perhaps that we what we should say in the Fd docs.

Can we make that clearer?

Perhaps runtime.KeepAlive(f) could be suggested there, to prevent f from being garbage collected.
Currently "or f is garbage collected" doesn't look important enough because many don't know when GC can hit them (importantly, it can get GC'd even before f goes out of scope).
On the other hand if f.Close() or any other method gets called it'd be kept alive too, some maybe these should be documented as well to not cause needless use of runtime.KeepAlive(f).
Maybe one more sentence like "Method call like f.Close() or runtime.KeepAlive(f) can be used to prevent unexpected closure of file descriptor".
I agree with suggestion to use syscall.Open instead too.
Either way documentation could be expanded there, and probably should, but that's just my 2c.

I think that the File.Fd method should be deprecated in favor of RawConn.Cintrol and perhaps a new RawConn.MuktiControl. We cannot remove File.Fd due to the Go 1 promise, but it is very hard to use correctly. It is what I would call a "foot gun".

@ianlancetaylor Why this is a NeedsFix? As you said, is there anything really need a fix? How is the FD doc not clear enough on its usage? After reading this thread I get the message that the "bug" was a misuse of FD, other than an issue of the document since it is the caller's responsibility to keep the file open, such as @odeke-em  suggested use defer f.Close() other than use syscall.Close.

I think that the File.Fd method should be deprecated in favor of RawConn.Control and perhaps a new RawConn.MultiControl.

Perhaps. Should probably be separate issue though.

but it is very hard to use correctly. It is what I would call a "foot gun".

It's here to stay so might as well minimize damage by documenting it.

How is the FD doc not clear enough on its usage?

Apparently it wasn't if user still made mistake after reading it. And took their time to write up issue in bug tracker (how many more users have done this mistake? how many fixed it for themselves and didn't make an issue?).

After reading this thread I get the message that the "bug" was a misuse of FD, other than an issue of the document since it is the caller's responsibility to keep the file open, such as @odeke-em suggested use defer f.Close() other than use syscall.Close.

Yes. But documentation doesn't suggest using f.Close(). And runtime.KeepAlive() combined with syscall.Close wouldn't have been disastrous either. But none of them were suggested.
I know that it's not a place to explain whole GC workings inside one function documentation, but IMO documenting common footgun (GC closing fd) and common workarounds (proper usage of f.Close() or runtime.KeepAlive()) would be valuable and would save people some time debugging.
If this function were discouraged in the future, it would also be good explanation, why it is (namely, this footgun).

(how many more users have done this mistake? how many fixed it for themselves and didn't make an issue?).

Hmm. I think people who made such a mistake, solved, and stay silent thought it was their mistake other than an issue of the document, meaning the doc is clear on documenting its behavior.
A meta issue regarding the misuse of a (potential) problematic APIs (such as Timer.Reset) are neither removed from standard library nor redesigned because of the Go 1 promise, could add comments like // Deprecated, // Abandoned. But this should be discussed in a separate issue.

But documentation doesn't suggest using f.Close().

I don't see a reason the document needs explicitly suggest using f.Close()? If a file is opened using os.Open, is there any good reason to seek far and neglect what lies close at hand, i.e. using syscall.Close other than a better choice of f.Close? Especially this pattern has been primarily advertised over tutorials.
f, err := os.Open("foo")
if err != nil { ... }
defer f.Close()

Why spend time arguing against documentation enhancement? Amending the docs is no more costly :-)

If a file is opened using os.Open, is there any good reason to seek far and neglect what lies close at hand, i.e. using syscall.Close other than a better choice of f.Close?

I believe that issue is that some people consider f.Fd() method as "disown", therefore they continue using only returned fd only, and in this case calling syscall.Close() sorta makes sense. Dealing with only single variable instead of 2 is probably easier.
Yeah, it isn't very good reason to use it like that because it's wrong (fd isn't disowned), but if they overlook that it's wrong, it's convenient shortcut to make and forget f.
 If at least one more sentence were to be added it probably would bring a bit more attention to possible mistake (they would at least check if they do f.Close() properly, or runtime.KeepAlive() maybe), if they know that there may be unexpected dragons if they don't.
We could also add suggestion to prefer using syscall.Open() or f.SyscallConn() depending on usage scenario instead.
Is there reason to not do anything? I don't think adding a bit more info to known footgun method would hurt anyone.

Why spend time arguing against documentation enhancement? Amending the docs is no more costly :-)

Indeed. Maybe I should just try making PR at this point.

@changkun I marked this as needs-fix because I think the documentation can be improved.  I think the docs should explicitly point at f.SyscallConn as an alternative, and I think the docs should emphasize that when f is garbage collected the descriptor will be closed rather than leaving that at the end of the sentence, and I think docs should explicitly point to runtime.SetFinalizer which carries all sorts of warnings about finalizers.

First, thank you all for involving in issue!
I want to share what the really experience was when I made this mistake:
I usually use Goland for coding, so when I was using it, I just saw the Fd method through the code hint and used it directly, without reading the Fd comment carefully, and assumed that if I didn't close it, Fd would always exist, based on my C experience.
When the problem occured, I didn't read Fd's comments, but instead I read the comments for OpenFile and the File struct, because I thought this behavior should have been explained at the whole struct level, I couldn't find it at that time (and ended up looking at the code to confirm).
Based on @cespare's reply, I found that indeed this behavior is stated in the Fd comment, and that it was indeed my misuse that caused it. But I also have to say that this comment is easy to miss (getting Fd is such a common operation that I'm sure there are very few people who would read the comment carefully), at least for a rookie like me missed it.
So I wonder if we could consider adding some annotations to explicitly point out the problem a bit more, since it's counter-intuitive and counter-empirical, and it's a bit harder to troubleshoot.
We are familiar with the GC and the source code of Go, so maybe it's not so difficult for us to find out the problem. But I don't think we should ask users to be familiar with either GC or the source code before they can use Go to write code.
Thank you for reading this.

actual comment has SyscallCon not SyscallConn (typo)


ci: the ci-job-validation script uses an undefined variable

It seems ci-job-validation.groovy got merged with a mistake. The
git_repo variable is used, but was not defined.

Merging it Manually


Some suggestions

Hi @marinagrprat ,
here are some suggestions intended to simplify a couple of things around.

renaming xnat_dashboards to just dashboards (underscores in module names are just ugly 😱 )
improving style of run_dashboards.py
speeding tests adding some environment variable CI_TEST (and n_max, see data_fetcher.py)
taking config.json out of the Python module (to the parent level)

This also includes some tentative version of tests using one single file tests.py. The problem I found was that if test_save.pickle is created in one file and other tests use it from a different file, there might be some issues when the latter is executed first (test_save.pickle does not exist yet).
So it may be less nice with only one long file but it fixes that problem.
What do you think?

Closing this PR and reopening locally from @marinagrprat's repository.


Fixed #373 -- Added CompositeField-based Meta.primary_key.

Trac ticket number
ticket-373
Branch description
This branch is based on PR #17279.
See my proposal.
Code example:
class Tenant(models.Model):
    pass

class User(models.Model):
    tenant = models.ForeignKey(Tenant, on_delete=models.CASCADE)
    id = models.SmallAutoField()

    class Meta:
        primary_key = ("tenant_id", "id")

class Comment(models.Model):
    tenant = models.ForeignKey(Tenant, on_delete=models.CASCADE)
    id = models.SmallAutoField()
    user_id = models.SmallIntegerField()
    user = models.ForeignObject(
        User,
        on_delete=models.CASCADE,
        from_fields=("tenant_id", "user_id"),
        to_fields=("tenant_id", "id"),
        related_name="+",
    )

    class Meta:
        primary_key = ("tenant_id", "id")

@charettes, could you give it a look? It looks like a big PR, but most of the changes are just tests.

I squashed all the commits in a new branch, so closing this.


luci.mk: sort languages in lexical order

If you make a fresh build env the languages config tags CONFIG_LUCI_LANG_* are sometimes resorted in an undefined order.
I track my configuration with git this will mess my change tracking.
There are changes where no changes are!
This change will fix this
Signed-off-by: Florian Eckert<EMAIL_ADDRESS>

@hnyman ping?


Sync: Write the unit (most), functional (some) and end-to-end (few) tests which verify the sync contracts

Is your feature request related to a problem? Please describe.
See #793
This task is to cover the work involved in verifying the individual contracts that, when strung together, make up the overall sync contract. (Definition of those contracts is covered by #794)
Describe the solution you'd like
Verify the contracts by implementing the test cases for

[ ] (Client) How items are added to the 'uncommitted' queue on the client side (upon data store operations)
[ ] (Client) How the client processes that uncommitted queue (while sending updates to server) - e.g. how is the queue ordered, how is it de-duped, etc
[ ] (Server) How the server processes updates from the client (including the responses it generates) and what the expectations are - i.e. can we reject? what happens when we reject? and more
[ ] (Server) How items are added to the commit log on the server such that they are available for sync to the clients
[ ] (Server) How the server processes that log (when sending updates to client) - e.g. again ordering, de-duping, etc
[ ] (Client) How the client processes updates from the server - can the client reject? under what conditions? what happens upon a rejection?
[ ] The 7th contract is the contract for precisely how the client and server exchange information. Currently this is implemented using the batch verb and has state like 'syncInProgress' and 'isInSync'.

Describe alternatives you've considered
No response
Additional context
No response

@VJag Feel free to either leave this as it is (single ticket) or add individual tickets for each of the subtasks as you wish

@VJag @srieteja @purnimavenkatasubbu Please can you (1) link branch(es) and/or PR(s) to this ticket and (2) provide brief summary of where we've got to and what's left to do?

Unit tests have been completed for the first 2 groups in the file sync_new_test.dart and the changes are available in the following PR sync_unit_tests.
Pending Work

To continue writing the remaining unit tests
Raise enhancement requests for the tests that need a change in the SDK.

Client-side unit tests are implemented and the changes are merged to trunk.
server-side unit tests implementation is done. Code review is pending.
server-side unit tests can be found in the PR sync_unit_tests

PR merged to trunk. sync_tests. Hence closing the issue.


Changed tail to make use of watch file.

Fixed an issue where the log file required a manual refresh before the new lines were detected.
Before I applied this fix I had to go into the folder of the log. Press the F5 button, before the file change was detected. Which in term would trigger the message sending from MC to Discord.
After I applied this fix, I no longer had to refresh the log folder and changes were being detected automatically.

Which OS were you on? Also, can the options variable be removed and the object passed to the constructor? I generally tend to steer clear from var in my code.

Which OS were you on? Also, can the options variable be removed and the object passed to the constructor? I generally tend to steer clear from var in my code.

I'm running on Windows, I'm not able to test Linux unfortunately.
I've also fixed the coding style for you 😉.

I’ve tested it appears to work in Linux, doesn’t seem to be as efficient as the default watch command though I suppose it should not matter as much 👍


Closes: #1 Fixed the function to verify first character is a letter

Fixes #1

It's a good idea to open an issue first for discussion.

[x] Tests pass
[x] Appropriate changes to README are included in PR

Finishing up here. Hope this helps.


Verify Compact mode for your adapter

We have detected that your adapter supports the compact mode. Please use the latest js-controller 2.0 and verify that everything works.
Some more information what is important to check can be found at https://github.com/ioBroker/ioBroker.js-controller/issues/512
On questions please answer to the linked issue. Please close this issue after your test and add the version number that you have tested please as a comment.
Thank you for your support.

Just for info, I will switch off compact mode for this adapter because it uses a lot o networking which is hard to control and to stop...

because it uses a lot o networking which is hard to control and to stop...

Do you have examples :-)

Ingo, will make tests on it for V 3.0 next month. I am just upgrading to 2.1 to have newest devices shipping now added


How to generate the 3Dmesh and NeRF from this repo?

I visited your HF spaces, and you mentioned that we can generate NeRF or 3D mesh using this repo.  But I am not sure how to do it. Could you please give detailed information for the reconstructing the NeRF and 3D mesh using your code?

Hi, thanks for your interest in our work.
If you have a multiview image from HF, you just run the "train_renderer.py" as below.
python train_renderer.py -i /path/to/your/image.png -n neus -b configs/neus.yaml -l /output/folder/to/output
Make sure to replace /path/to/your/image.png with the actual path to the image downloaded from HF. Additionally, replace /output/folder/to/output with the desired output folder path.
If you encounter any issues or have further questions, feel free to ask!


Catalog: Link to GitHub source code location

Fetch from the descriptor's managed-by location if type is github


V 0.8.7

All Submissions Basics:

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] Have you checked all Issues to tie the PR to a specific one?

All Submissions Cores:

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your core changes, as applicable?
[ ] Have you successfully ran tests with your changes locally?
[ ] Does your submission pass tests, including CircleCI, Travis CI, and AppVeyor?
[ ] Does your submission have appropriate code coverage? The cutoff threshold is 95% by Coversall.

New Model Submissions:

[ ] Have you created a .py in ~/pyod/models/?
[ ] Have you created a _example.py in ~/examples/?
[ ] Have you created a test_.py in ~/pyod/test/?
[ ] Have you lint your code locally prior to submission?

Pull Request Test Coverage Report for Build 1887

184 of 191 (96.34%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 95.457%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyod/test/test_rod.py
86
87
98.85%

pyod/models/rod.py
98
104
94.23%

Totals

Change from base Build 1839:
0.03%

Covered Lines:
4896

Relevant Lines:
5129

💛  - Coveralls


"fileinfo" function would be useful in Calc

Returning an object such as:
{ name: 'abc.txt', attributes: 'rwx', datecreated: 18655, ... }

Basically the information we could get with "dir" or "ls -al" from the command line.
If the file doesn't exist, then return empty object (?)

This should be implemented via code in Dir.java (pulled into separate class(es) presumably), so it can be used in several places.

The biggest coding issue seems to be translating from FileTime to our home-grown LocalDate + nanos forms for display...


Does not work together with ion-item or any other directive with isolated scope

Error: [$compile:multidir] Multiple directives [ionDatetimePicker (module: ion-datetime-picker), ionItem] asking for new/isolated scope on:

Definitely a bug, thanks for the catch.

Workaround for now is to use these directives on different elements.

transform ion-item to div.

yes. I try this 👍

        {{dateValue2| date: "yyyy-mm-dd H:mm:ss"}}

work well.
thank you

I'm getting the same error. maybe you can edit the readme to show a different example?

Changed readme to accommodate that, thanks!

Please help me , i want store in scope variable the date and time i choose .
at this time i can store the present time with new Date();
pls help me

Your problem has nothing to do with this issue. You should file your own one. But this problem was already discussed many times, use search in issues.

As I don't see an easy fix for that and a workaround exists, let's call it wontfix for the current version. The next version will use component() syntax of angular 1.5, so this problem won't happen anymore.


How to enable Sync on Thorium for MacOS

Hi Thorium team,
nn my work macbook (Monterey with Intel CPU) the google sync feature is deactivated in official Chrome. Installing the Chromium.woolyss.com Chrome v95 sync was possible, but there are no updates to it.
I then installed the Thorium special Release M102, it runs but sync is not available. Am I doing something wrong? Leftovers from the other Chromium? Is it ok to still have Chromium installed (don't need to)?
When I run Thorium, stop it and open Chromium again I am completely logged out of my Google account in Chromium.
Thanks for your help
Felix

@The-Engineer Its not really a team its just me lol, but @midzer does make the mac builds since I dont have a mac (I use a vm for some source code things for the mac builds, but it would take days to compile in a VM).
This is the same issue as https://github.com/Alex313031/Thorium-Win/issues/9 so follow the instructions there.

It now works in the newest release with the keys, thank you very much for your work


MultipartFile content-disposition

MultipartFile cannot customize content-disposition

Unfortunately this is not enough information to diagnose the problem.
Please create a new issue with properly filled issue template (information about your environment and the steps to reproduce the issue)


haraka crash when set nodemailer secure true

I'm studying haraka and first thank you for your excellent work.
I installed haraka in ubuntu and it works well with STARTTLS. I can send emails using the outlook client.
then I tried to use nodemailer, and something went wrong.
Haraka version 2.6.1 and nodemailer version 1.4.0
when i use following nodemailer options, haraka logs 'UNABLE_TO_GET_ISSUER_CERT', and i think it's nodemailer's problem.
var transporter = nodemailer.createTransport({
    host: '<IP_ADDRESS>',
    port: 2525,
    secure:false,
    auth:{
<EMAIL_ADDRESS>        pass:'a112358'
    }
});

but when i set the secure option true, haraka crashed
var transporter = nodemailer.createTransport({
    host: '<IP_ADDRESS>',
    port: 2525,
    secure:true,
    auth:{
<EMAIL_ADDRESS>        pass:'a112358'
    }
});

the output in node v0.10.35 is
[DEBUG] [25D38B82-6640-42F5-899B-3DE4040A7851] [core] running connect_init hooks
[DEBUG] [25D38B82-6640-42F5-899B-3DE4040A7851] [core] running connect_init_respond
[DEBUG] [25D38B82-6640-42F5-899B-3DE4040A7851] [core] running lookup_rdns hooks
[DEBUG] [25D38B82-6640-42F5-899B-3DE4040A7851] [core] [early_talker] state=4 esmtp=false line="C?���bU�Y	椸s�{�Ġb�<(������0�,�(�$��"
[CRIT] [-] [core] Caught exception: {}
[NOTICE] [-] [core] Shutting down

the output in node v4.1.0 is
[DEBUG] [AD2B5DE9-6EDA-4E0E-97D0-8BB9076CAB85] [core] running connect_init hooks
[DEBUG] [AD2B5DE9-6EDA-4E0E-97D0-8BB9076CAB85] [core] running connect_init_respond
[DEBUG] [AD2B5DE9-6EDA-4E0E-97D0-8BB9076CAB85] [core] running lookup_rdns hooks
[DEBUG] [AD2B5DE9-6EDA-4E0E-97D0-8BB9076CAB85] [core] [early_talker] state=4 esmtp=false line="�C �0�,�(�$��"
[CRIT] [-] [core] RangeError: Maximum call stack size exceeded
[CRIT] [-] [core]     at new Uint8Array (native)
[CRIT] [-] [core]     at Buffer.subarray (native)
[CRIT] [-] [core]     at Buffer.slice (buffer.js:565:23)
[CRIT] [-] [core]     at Connection._process_data (E:\workspace\node\Haraka\connection.js:357:43)
[CRIT] [-] [core]     at Connection._process_data (E:\workspace\node\Haraka\connection.js:374:18)
[CRIT] [-] [core]     at Connection._process_data (E:\workspace\node\Haraka\connection.js:374:18)
[CRIT] [-] [core]     at Connection._process_data (E:\workspace\node\Haraka\connection.js:374:18)
[CRIT] [-] [core]     at Connection._process_data (E:\workspace\node\Haraka\connection.js:374:18)
[CRIT] [-] [core]     at Connection._process_data (E:\workspace\node\Haraka\connection.js:374:18)
[CRIT] [-] [core]     at Connection._process_data (E:\workspace\node\Haraka\connection.js:374:18)
[NOTICE] [-] [core] Shutting down

of course nodemailer is not good enough, but i think there should no crash here.

Hi,
what do you have configure in config/tls.ini on haraka?
what is get nodemailer on callback for an error?
transporter.on("log", function(data) {console.log("LOG type: " + data.type);console.log("LOG message: " + data.message);});

// send mail
transporter.sendMail({
    from<EMAIL_ADDRESS>    to<EMAIL_ADDRESS>    subject: 'hello world!',
    text: 'Authenticated with OAuth2'
},
function(err,data){
    console.log(err, data);
});

Ok - that bug is already fixed and once Haraka 2.7.0 is out, it will no longer crash.
However - you're incorrectly setting 'secure: true' in Nodemailer.   The secure flag puts Nodemailer into SMTPS mode, which is used on port 465 only (it's also deprecated in favour of port 587 as STARTTLS) and you're attempting that on port 25 (which is plain-text only).
So - in short - drop the secure: true from your Nodemailer options and it will work just fine and Nodemailer will use STARTTLS instead (provided you have configured Haraka with TLS certificates).

i know secure:true means ssl, my idea is just  we need no crash


reduce the number of redis requests when using it with ActiveRecord queries

I'm using a counter on an ActiveRecord object to keep track of the clickthroughs, as:
class Car < ActiveRecord::Base
  counter :clickthroughs
end

In the view, I want to display the clickthroughs of 50 cars (together with some other attributes), so normally I would load the cars, let's say Car.first(50) and then in the view access the clickthroughs for each car: car.clickthroughs.
However, since there's 50 cars, it will do a request to redis for each car, which is quite slow.
So I've thought of doing monkeypatching on top of the ActiveRecord::Relation, to add someting like includes_redis_counters(: clickthroughs) which fetches all clickthroughs in one request and saves them on the objects as attr_accessors.

What would be the best practice?
Cheers
Adrian

@AdrianFlorian Did you get time to implement this? @nateware any thoughts on how you might implement this? I might be able to put a patch for this feature - brainstorming.

Closed due to lack of interest by the community in providing a patch.


migration of material files to nullsafety

Description
NNBD migration for part of material
Related Issues

dart-lang/sdk#40146

Tests
I added the following tests:
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

Could a googler check why Google testing is still Pending?

We have some infra problem and cannot fetch this PR correctly. Looking into it now.

This has something to do with the API we use. I will try to fix this by EOB Monday.


SerializationException during test runs on CI machines

Tests on CI occasionally fail with this error message. The error goes away on repeated test runs.

System.Runtime.Serialization.SerializationException : Type 'Microsoft.EntityFrameworkCore.Specification.Tests.TestSqlLoggerFactory+SqlLoggerData' in assembly 'Microsoft.EntityFrameworkCore.Relational.Specification.Tests, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=adb9793829ddae60' is not marked as serializable.

We should make this test class serializable as we suspect there is an underlying error causing this condition.


Add archive relay docker image

PR description please

PR description please

I don't know what else should I write apart from maybe repeating the title.

What’s the reason for adding it? Why wasn’t it here before?

What’s the reason for adding it? Why wasn’t it here before?

It wasn't built using nix, I've added it for the consistency.


Update to Swift 4

Would you consider updating the existing codebase for Swift 4 and Xcode 9?
I could totally do it if you want to.

@NSMyself  yes please upgrade to swift 4 and keep swift swift3 version in separate folder (give it a name
Calculator-iOS_Swift_3 and keep swift 4 version separately and give it name Calculator-iOS_Swift_4
Thanks :)


Color formats in Color Picker

Microsoft PowerToys version
0.71.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
ColorPicker
Steps to reproduce
Hi, thanks for the tool :D
I wanted to report a problem when trying to use the same name in color formats, in settings.
As color formats I have:
HEX ffe4b5
RGB 255; 228; 181
HSV hsv(38, 29%, 100%)
I wanted to have two RGB with ; and with ,. When I go to rename HSV to RGB the settings crash as soon as I press B.
✔ Expected Behavior
It could give me an error message for the name already used or it could allow me to use the same name
❌ Actual Behavior
It crashes
Other Software
No response

If you update your version to 0.72.0 you will notice you can't click the add button if there is already a color format with that name. Try updating your version to the new version where the bug is fixed.

Unfortunately even with version 0.72.0 as soon as I change the name and it becomes like an existing name it crashes.
In this case I have HEX RGB and RGB, as soon as I remove the , the settings crash

I can easy reproduce this crash: System.ArgumentException: 'An item with the same key has already been added. Key: RGB'

This has been worked on for the 0.74.0 release. Please update PowerToys to the latest version. 😉
https://github.com/microsoft/PowerToys/releases


fix(tier4_control_launch): add parameter about nearest search

Signed-off-by: tomoya.kimura<EMAIL_ADDRESS>Description
Add parameter to operation_mode_transition_manager.param.yaml
https://github.com/autowarefoundation/autoware.universe/pull/2523

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe Could you approve this?


Add cloudwatch_metric_alarms_enabled variable. Update Terratest. Update to context.tf

what

Add cloudwatch_metric_alarms_enabled variable
Update Terratest
Update to context.tf

why

Allow disabling CloudWatch metrics alarms
Standardization and interoperability
Keep the module up to date

related

Closes #83
Closes #73
Closes #66
Closes #79

/test all


The extension forcefully override navigator.hardwareConcurrency

Description
When using DuckDuckGo Privacy Extension, the extension forcefully overrides the navigator.hardwareConcurrency information provided by the browser. This in turns causes many websites, services and extensions that probe this number to actually under-perform as they are going to assume there are only 2 CPU Logical Cores available instead of the actual number.
Steps to Reproduce

Have DuckDuckGo Privacy Extension enabled
Download e.g. some large files previously uploaded on https://drive.proton.me  (Proton Drive employes parallelization in order to optimize download speed and decryption of e2ee files. With the extension enabled network utilization is suboptimal because only one block at a time is downloaded, instead of multiple parallel blocks.

Expected behavior:
Given how critical this number is for performance I'd expect as a user to have control whether this value is overridden by the extension or rather the real number of logical cores is exposed
Actual behavior:

Versions

Extension: 2023.11.17
Browser: Firefox (but actually any browser)
OS: Windows (but actually any OS)

Additional Information

The actual line enforcing this is here: https://github.com/search?q=repo%3Aduckduckgo%2Fduckduckgo-privacy-extension hardwareConcurrency&type=code

Thanks for filing this. This is one of our fingerprinting protections - we fix this, and several other hardware values to the same value for all users to make it so this cannot be used for fingerprinting by trackers. Your example on proton.me seems to be a rare example of a site using navigator.hardwareConcurrency for its actual purpose, rather than fingerprinting, and our chosen value for it may be a bit low for most extension users.
I've opened https://github.com/duckduckgo/privacy-configuration/pull/1679 to mitigate the issue on proton.me, and opened a task internally to discuss how to deal with valid usages of this API. If you know of other sites with issues, please let us know so we can mitigate any issues there too.

I just ran into this issue with the Zoom Video SDK for Web (link).  This JS library allows websites to embed video chat into a webpage.  However, it has limited functionality on machines with limited computing power.  Specifically, you cannot use HD video or virtual background (blur) unless navigator.hardwareConcurrency>2 (see this file).
While I know that I can add exclude my site in the DuckDuckGo Privacy Essentials options, this SDK could be used on many different sites, and it is not intuitive or user-friendly to have to have to do so on each of these sites.  Also, this means that the rest of the DDG PE features turned off for these sites.
I would suggest raising the number of reported cores from 2 to 8, similar to what Safari/WebKit does (link).


Deprecate all APIs that use framework fragments

@samtstern The Android team announced their decision to kill all framework fragments so this PR deprecates all APIs that use those. It includes eventually getting rid of support for normal activities in some cases. Do you think that's okay?

@SUPERCILEX thanks for bringing this up.  It's an interesting move for sure, maybe we should wait and see what some other prominent Android libraries do to reflect the change?

@samtstern So I've been poking around a bunch of libraries, and it seems like we're one of the few who support fragments and the only ones who support framework fragments besides https://github.com/permissions-dispatcher/PermissionsDispatcher. I've created https://github.com/permissions-dispatcher/PermissionsDispatcher/issues/445 to see what they think.

@SUPERCILEX wow thanks for doing the research!

@samtstern Ok, so Glide and the other permission library have both deprecated framework fragments so I think that's the way to go. 👍

@SUPERCILEX thanks for the research!  I still want to wait until the actual Fragment deprecation is visible in the SDK (it isn't yet, right) to actually release this.

Alrighty, SGTM

@samtstern Ok, API 28 is out! 😁 I nuked all the framework APIs so we can jump straight to v2.0, but I'm still on the fence about the Activity stuff. Should we support plain activities or require a FragmentActivity?

@samtstern SGTM, that's what I was thinking too. As for support lib stability, it's an RC and they said APIs aren't going to change so I don't think we have too much to worry about there. (Though I don't mind waiting a bit longer. 😄)

Alrighty, this PR is ready to rock whenever you are! 😁

Nice!  I'll give it the respect it deserves on Monday.  Also I am not worried about support lib stability, more worried about forcing our consumers to pull an rc dependency into their app.  People tend not to like that.
So I think we might want to wait to release until then.  That said, can still review and merge in the meantime.

Oh yeah, makes sense. 👍 The support lib team usually ships a final version pretty fast after an RC, so I doubt we'll be waiting too long. 😄

Yup. We can also get rid of the few remaining deprecated methods.


Add your current/previous education

https://github.com/MLH-Fellowship/project-reboot-rebels/pull/20


CharacterModelUMA to AnimatorCharacterModel conversion issue

Converting UMAPlayerCharacterEntity from CharacterModelUMA to AnimatorCharacterModel brokes the character editor. It doesn't drop any errors or warnings, but the character editor just didn't appear anymore.

Found it! Solution:
CharacterModelUMA should be converted to AnimatorCharacterModelUMA instead of just AnimatorCharacterModel


Partial assembly based residual distribution method

This PR does a refactoring to move towards the MF Residual Distribution method.
At the moment we are now able to use the new MFEM 4+ routines to compute geometric factors/face normals etc... and evaluate the action of the face terms.
Goals of this PR are:

[x] Use new MFEM PA/GPU friendly routines to compute the low order solution
[x] Create MF PA based 2D methods for Residual Distribution
[x] Create MF PA based 3D methods for Residual Distribution
[x] Clean up pass....

@vladotomov  I think this is ready for prime time! The kernel's aren't quite optimized yet but we are now have the option of a fully matrix free remap framework.

Mention in CHANGELOG?


updated to latest eth2-docker

updated to latest eth2-docker

pulled wrong way, deleting

pulled wrong way, deleting


[PT Run] [Windows settings] Add entries for settings tools

Additional I suggest to add one entry per settings app. This would help us to fix the bug that Control Panel as app result can't be translated:

System settings
Control Panel

Originally posted by @htcfreek in https://github.com/microsoft/PowerToys/issues/13734#issuecomment-940032710

@htcfreek did this get wrapped up with the Oct 11 merge?

@htcfreek did this get wrapped up with the Oct 11 merge?

Yes. It's all working an merged with #13746. Can you please assign the project (0.51). Thanks.

This is fixed in 0.51.  Please head over to our releases and get the update!  https://aka.ms/installpowertoys


feat(#64): fill CacheTojo

Tojos.KEY -> Tojos.ID_KEY
Add toMap method to Tojo
Init CacheTojo cache

Closes: #64

@yegor256 Could you have a look, please?

@rultor merge

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@yegor256 Could you release a new version, please?

@rultor release, tag is 0.18.1

@rultor release, tag is 0.18.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.18.1

@yegor256 Done! FYI, the full log is here (took me 6min)


Fixes #2770-Improve error handling for JSON Import during Create Project

Fixes #2770
Changes proposed in this pull request:

The refresh the page after the error alert has been dismissed

Why do we need to refresh the page?

Good work @WaltonG,
But, when I run the tests, I get this error. I also rebased your branch, hope it's not the problem.
[ERROR] Tests run: 680, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 124.629 s <<< FAILURE! - in TestSuite
[ERROR] reconNonJsonTest(com.google.refine.model.recon.StandardReconConfigTests)  Time elapsed: 2.671 s  <<< FAILURE!
java.lang.AssertionError: expected [false] but found [true]
        at com.google.refine.model.recon.StandardReconConfigTests.reconNonJsonTest(StandardReconConfigTests.java:264)

[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]   StandardReconConfigTests.reconNonJsonTest:264 expected [false] but found [true]
[INFO]
[ERROR] Tests run: 680, Failures: 1, Errors: 0, Skipped: 0

Regards, Antoine

Thats strange as there is no test failure with the integration server. Let me try running the test from my end

Thats strange as there is no test failure with the integration server. Let me try running the test from my end

@WaltonG I'm sorry to have to say, I made a mistake here. Let me look it again today.
Regards,
Antoine


Refactor localization to allow configured language and better use of server language

Resolves #114

Going to wait to merge/publish as a full release until I get word back from the issue reporter that this resolves their problem. But I've tested this locally and it appears to work for me.


Need Timeout settings on the VSTS tasks

I'm using your PS cmdlets, scripts and VSTS build tasks to automate the build and deployment of a very large CRM-based solution.  Everything works great until I get to the Publish Customizations step, which times out.  For our solution, since we have so many custom entities, I need to be able to control the timeout of the Publish Customizations build task, since the default 2 minute timeout isn't sufficient.
I've used the cmdlets to write scripts for developers where we can pass in this timeout to the cmdlet components, and that works great.
For all of the VSTS tasks, can you add a Timeout parameter that we can set in the build definition that then gets passed into the cmdlets?

@BinaryMike thanks for the feedback. I have added the timeout to the Publish Customisations Task. Which other Tasks you think this will be useful? Many of them are quick operations or run in Async mode.

Awesome!  Thanks for the quick response.  Even when the operation is async, I have seen some of the operations time out.  For example, Import Solution may timeout because my solution ZIP file is over 20 MB, and sometimes it's slow to upload and process before the async operation begins.  Import Solution would definitely be useful.  That's the only other one that I use in the build process for now.
Export Customizations I have a script based on your scripts where I've augmented it with the timeout, since we need it there for developers, but that doesn't require you to update it.  It might be useful for other folks if you included a timeout parameter in the example script.
When will the changes show up in the Visual Studio Marketplace, so my build definition will pick it up?

Export already had timeout settings. I added this to the import task as well. Version 8.3.1 Live


Falsely believed alt Windows creds could not be used to login. Fixed to support Win cerds.

To test, ensure that sql auth and windows auth with alternative credentials (say, base\chrissy if you usualy run as base\ctrlb)

Not tested this yet, just noticed you've asked to merge this directly into master, is this intentional? I thought no one could do that any more?

Total mistake! Will submit new Pr today
Sent from my iPhone

On Aug 9, 2016, at 12:37 AM, Daniel Alexander<EMAIL_ADDRESS>wrote:
Not tested this yet, just noticed you've asked to merge this directly into master, is this intentional? I thought no one could do that any more?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


TypeError: Cannot read property 'document' of undefined

Testing #114969

open SCM view
open diff editor for plotly.txt-notebook
reload window
after a short while the error below is printed

This doesn't seem to happen when the explorer is the active view 🤯

 ERR Cannot read property 'document' of undefined: TypeError: Cannot read property 'document' of undefined
	at d.get cell [as cell] (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:73:33411)
	at file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:73:32468
	at Array.map (<anonymous>)
	at asApiEvent (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:73:32459)
	at Array.map (<anonymous>)
	at m._spliceNotebookCells (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:73:39279)
	at file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:73:37940
	at Array.forEach (<anonymous>)
	at m.acceptModelChanged (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:73:37789)
	at h.$acceptModelChanged (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:77:188565)
	at f._doInvokeHandler (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:78:76443)
	at f._invokeHandler (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:78:76135)
	at f._receiveRequest (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:78:74805)
	at f._receiveOneMessage (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:78:73607)
	at file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:78:71735
	at v.fire (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:55:1836)
	at MessagePort.f.port1.onmessage (file:///Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/worker/extensionHostWorker.js:86:3488)
workbench.desktop.main.js:618   ERR ModelService: Cannot add model because it already exists!: Error: ModelService: Cannot add model because it already exists!
    at mi._createModelData (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:732:2892)
    at mi.createModel (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:733:959)
    at z._buildMetadataEditor (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2545:18617)
    at z.updateMetadataRendering (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2545:15068)
    at x.buildHeader (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2545:13057)
    at z.buildBody (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2545:36762)
    at new P (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2545:14659)
    at new z (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2545:35315)
    at C._createInstance (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:614:21800)
    at C.createInstance (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:614:21219)
    at Ia.renderElement (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2545:48968)
    at z.renderElement (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:138:1588)
    at l.insertItemInDOM (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:124:16989)
    at l._splice (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:124:12805)
    at l.splice (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:124:11171)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3:139286
    at Array.forEach (<anonymous>)
    at t.splice (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3:139273)
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:138:7711
    at d.bufferEvents (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:55:4384)
    at o.splice (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:138:7678)
    at _a.updateLayout (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2559:10091)
    at async file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2559:6087
workbench.desktop.main.js:618   ERR Cannot read property 'domNode' of null: TypeError: Cannot read property 'domNode' of null
    at l.updateItemInDOM (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:124:17713)
    at l.render (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:124:15952)
    at l.updateElementHeight (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:124:10848)
    at o.updateElementHeight2 (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2545:49887)
    at F (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2559:11088)
    at M._runner (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2559:11260)
    at M.execute (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:66:8267)
    at He (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:66:8481)

@jrieken as the call stack points out, it throws in
https://github.com/microsoft/vscode/blob/b7e87c1bf2780f6b9338721369e422dcb398224d/src/vs/workbench/api/common/extHostNotebookDocument.ts#L116
and it's the web worker extension host. Any idea how is this related to extension host code? Asking as I'm not able to reproduce locally with above steps.

@jrieken as the call stack points out, it throws in
https://github.com/microsoft/vscode/blob/b7e87c1bf2780f6b9338721369e422dcb398224d/src/vs/workbench/api/common/extHostNotebookDocument.ts#L116
and it's the web worker extension host. Any idea how is this related to extension host code? Asking as I'm not able to reproduce locally with above steps.

That would mean that either the renderer side is wrong or, and I think that's more likely, the splice-data NotebookCellsSplice2 is bogous. Before emitting the event that causes the error we update the extHostDocument data. So, it seems that there is a content change event for which we didn't add model

That would mean that either the renderer side is wrong or, and I think that's more likely, the splice-data NotebookCellsSplice2 is bogous. Before emitting the event that causes the error we update the extHostDocument data. So, it seems that there is a content change event for which we didn't add model

I am pushing a change that prints the cell-document error with its uri so that understanding this is simpler

I am pushing a change that prints the cell-document error with its uri so that understanding this is simpler

I am somewhat able to reproduce, running out of sources I still see the last two errors but not the first. One error is about failure to create a model. If that model is already removed from the extension then this error might happens. This is the latest stack trace (it seems they need a little to appear)
 ERR ModelService: Cannot add model because it already exists!: Error: ModelService: Cannot add model because it already exists!
    at ModelServiceImpl._createModelData (file:///Users/jrieken/Code/vscode/out/vs/editor/common/services/modelServiceImpl.js:297:23)
    at ModelServiceImpl.createModel (file:///Users/jrieken/Code/vscode/out/vs/editor/common/services/modelServiceImpl.js:365:34)
    at ModifiedElement._buildMetadataEditor (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:367:65)
    at ModifiedElement.updateMetadataRendering (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:219:26)
    at PropertyHeader.buildHeader (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:148:27)
    at ModifiedElement.buildBody (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:931:34)
    at new AbstractElementRenderer (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:207:18)
    at new ModifiedElement (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:876:13)
    at InstantiationService._createInstance (file:///Users/jrieken/Code/vscode/out/vs/platform/instantiation/common/instantiationService.js:89:20)
    at InstantiationService.createInstance (file:///Users/jrieken/Code/vscode/out/vs/platform/instantiation/common/instantiationService.js:60:31)
    at CellDiffSideBySideRenderer.renderElement (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.js:202:83)
    at PipelineRenderer.renderElement (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:750:26)
    at ListView.insertItemInDOM (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:538:26)
    at ListView._splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:344:26)
    at ListView.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:267:29)
    at file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/splice.js:14:45
    at Array.forEach (<anonymous>)
    at CombinedSpliceable.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/splice.js:14:30)
    at file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:970:67
    at EventBufferer.bufferEvents (file:///Users/jrieken/Code/vscode/out/vs/base/common/event.js:674:23)
    at NotebookTextDiffList.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:970:32)
    at NotebookTextDiffEditor.updateLayout (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:346:24)
    at async file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:218:25
log.js:144   ERR Cannot read property 'domNode' of null: TypeError: Cannot read property 'domNode' of null
    at ListView.updateItemInDOM (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:568:22)
    at ListView.render (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:489:26)
    at ListView.updateElementHeight (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:255:18)
    at NotebookTextDiffList.updateElementHeight2 (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.js:252:23)
    at relayout (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:372:28)
    at AnimationFrameQueueItem._runner (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:380:17)
    at AnimationFrameQueueItem.execute (file:///Users/jrieken/Code/vscode/out/vs/base/browser/dom.js:147:22)
    at animationFrameRunner (file:///Users/jrieken/Code/vscode/out/vs/base/browser/dom.js:183:21)
log.js:144   ERR MISSING extHostDocument for notebook cell: vscode-notebook-cell:/Users/jrieken/Code/_samples/devfest/notebooks/plotly.txt%20copy.ipynb#ch0000001: Error: MISSING extHostDocument for notebook cell: vscode-notebook-cell:/Users/jrieken/Code/_samples/devfest/notebooks/plotly.txt%20copy.ipynb#ch0000001
	at ExtHostCell.get cell [as cell] (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:82:27)
	at /Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:34:67
	at Array.map (<anonymous>)
	at asApiEvent (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:34:50)
	at Array.map (<anonymous>)
	at ExtHostNotebookDocument._spliceNotebookCells (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:334:50)
	at /Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:275:26
	at Array.forEach (<anonymous>)
	at ExtHostNotebookDocument.acceptModelChanged (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:270:29)
	at ExtHostNotebookController.$acceptModelChanged (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebook.js:468:26)
	at RPCProtocol._doInvokeHandler (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:341:27)
	at RPCProtocol._invokeHandler (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:326:45)
	at RPCProtocol._receiveRequest (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:253:32)
	at RPCProtocol._receiveOneMessage (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:181:26)
	at /Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:65:52
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:479:38)
	at BufferedEmitter.fire (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:375:35)
	at /Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/node/extensionHostProcessSetup.js:146:41
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:479:38)
	at BufferedEmitter.fire (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:375:35)
	at PersistentProtocol._receiveMessage (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:654:41)
	at /Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:510:83
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:479:38)
	at ProtocolReader.acceptChunk (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:189:37)
	at /Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:158:61
	at Socket.listener (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/node/ipc.net.js:17:40)
	at Socket.emit (events.js:315:20)
	at addChunk (_stream_readable.js:295:12)
	at readableAddChunk (_stream_readable.js:271:9)
	at Socket.push (_stream_readable.js:212:10)
	at Pipe.onStreamRead (internal/stream_base_commons.js:186:23)
log.js:144   ERR ModelService: Cannot add model because it already exists!: Error: ModelService: Cannot add model because it already exists!
    at ModelServiceImpl._createModelData (file:///Users/jrieken/Code/vscode/out/vs/editor/common/services/modelServiceImpl.js:297:23)
    at ModelServiceImpl.createModel (file:///Users/jrieken/Code/vscode/out/vs/editor/common/services/modelServiceImpl.js:365:34)
    at ModifiedElement._buildMetadataEditor (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:368:65)
    at ModifiedElement.updateMetadataRendering (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:219:26)
    at PropertyHeader.buildHeader (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:148:27)
    at ModifiedElement.buildBody (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:931:34)
    at new AbstractElementRenderer (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:207:18)
    at new ModifiedElement (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:876:13)
    at InstantiationService._createInstance (file:///Users/jrieken/Code/vscode/out/vs/platform/instantiation/common/instantiationService.js:89:20)
    at InstantiationService.createInstance (file:///Users/jrieken/Code/vscode/out/vs/platform/instantiation/common/instantiationService.js:60:31)
    at CellDiffSideBySideRenderer.renderElement (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.js:202:83)
    at PipelineRenderer.renderElement (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:750:26)
    at ListView.insertItemInDOM (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:538:26)
    at ListView._splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:344:26)
    at ListView.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:267:29)
    at file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/splice.js:14:45
    at Array.forEach (<anonymous>)
    at CombinedSpliceable.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/splice.js:14:30)
    at file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:970:67
    at EventBufferer.bufferEvents (file:///Users/jrieken/Code/vscode/out/vs/base/common/event.js:674:23)
    at NotebookTextDiffList.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:970:32)
    at NotebookTextDiffEditor.updateLayout (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:346:24)
    at async file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:231:25
log.js:144   ERR Cannot read property 'domNode' of null: TypeError: Cannot read property 'domNode' of null
    at ListView.updateItemInDOM (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:568:22)
    at ListView.render (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:489:26)
    at ListView.updateElementHeight (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:255:18)
    at NotebookTextDiffList.updateElementHeight2 (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.js:252:23)
    at relayout (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:372:28)
    at AnimationFrameQueueItem._runner (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:380:17)
    at AnimationFrameQueueItem.execute (file:///Users/jrieken/Code/vscode/out/vs/base/browser/dom.js:147:22)
    at animationFrameRunner (file:///Users/jrieken/Code/vscode/out/vs/base/browser/dom.js:183:21)

I am somewhat able to reproduce, running out of sources I still see the last two errors but not the first. One error is about failure to create a model. If that model is already removed from the extension then this error might happens. This is the latest stack trace (it seems they need a little to appear)
 ERR ModelService: Cannot add model because it already exists!: Error: ModelService: Cannot add model because it already exists!
    at ModelServiceImpl._createModelData (file:///Users/jrieken/Code/vscode/out/vs/editor/common/services/modelServiceImpl.js:297:23)
    at ModelServiceImpl.createModel (file:///Users/jrieken/Code/vscode/out/vs/editor/common/services/modelServiceImpl.js:365:34)
    at ModifiedElement._buildMetadataEditor (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:367:65)
    at ModifiedElement.updateMetadataRendering (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:219:26)
    at PropertyHeader.buildHeader (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:148:27)
    at ModifiedElement.buildBody (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:931:34)
    at new AbstractElementRenderer (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:207:18)
    at new ModifiedElement (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:876:13)
    at InstantiationService._createInstance (file:///Users/jrieken/Code/vscode/out/vs/platform/instantiation/common/instantiationService.js:89:20)
    at InstantiationService.createInstance (file:///Users/jrieken/Code/vscode/out/vs/platform/instantiation/common/instantiationService.js:60:31)
    at CellDiffSideBySideRenderer.renderElement (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.js:202:83)
    at PipelineRenderer.renderElement (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:750:26)
    at ListView.insertItemInDOM (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:538:26)
    at ListView._splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:344:26)
    at ListView.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:267:29)
    at file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/splice.js:14:45
    at Array.forEach (<anonymous>)
    at CombinedSpliceable.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/splice.js:14:30)
    at file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:970:67
    at EventBufferer.bufferEvents (file:///Users/jrieken/Code/vscode/out/vs/base/common/event.js:674:23)
    at NotebookTextDiffList.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:970:32)
    at NotebookTextDiffEditor.updateLayout (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:346:24)
    at async file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:218:25
log.js:144   ERR Cannot read property 'domNode' of null: TypeError: Cannot read property 'domNode' of null
    at ListView.updateItemInDOM (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:568:22)
    at ListView.render (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:489:26)
    at ListView.updateElementHeight (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:255:18)
    at NotebookTextDiffList.updateElementHeight2 (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.js:252:23)
    at relayout (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:372:28)
    at AnimationFrameQueueItem._runner (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:380:17)
    at AnimationFrameQueueItem.execute (file:///Users/jrieken/Code/vscode/out/vs/base/browser/dom.js:147:22)
    at animationFrameRunner (file:///Users/jrieken/Code/vscode/out/vs/base/browser/dom.js:183:21)
log.js:144   ERR MISSING extHostDocument for notebook cell: vscode-notebook-cell:/Users/jrieken/Code/_samples/devfest/notebooks/plotly.txt%20copy.ipynb#ch0000001: Error: MISSING extHostDocument for notebook cell: vscode-notebook-cell:/Users/jrieken/Code/_samples/devfest/notebooks/plotly.txt%20copy.ipynb#ch0000001
	at ExtHostCell.get cell [as cell] (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:82:27)
	at /Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:34:67
	at Array.map (<anonymous>)
	at asApiEvent (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:34:50)
	at Array.map (<anonymous>)
	at ExtHostNotebookDocument._spliceNotebookCells (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:334:50)
	at /Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:275:26
	at Array.forEach (<anonymous>)
	at ExtHostNotebookDocument.acceptModelChanged (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebookDocument.js:270:29)
	at ExtHostNotebookController.$acceptModelChanged (/Users/jrieken/Code/vscode/out/vs/workbench/api/common/extHostNotebook.js:468:26)
	at RPCProtocol._doInvokeHandler (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:341:27)
	at RPCProtocol._invokeHandler (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:326:45)
	at RPCProtocol._receiveRequest (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:253:32)
	at RPCProtocol._receiveOneMessage (/Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:181:26)
	at /Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/common/rpcProtocol.js:65:52
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:479:38)
	at BufferedEmitter.fire (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:375:35)
	at /Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/node/extensionHostProcessSetup.js:146:41
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:479:38)
	at BufferedEmitter.fire (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:375:35)
	at PersistentProtocol._receiveMessage (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:654:41)
	at /Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:510:83
	at Emitter.fire (/Users/jrieken/Code/vscode/out/vs/base/common/event.js:479:38)
	at ProtocolReader.acceptChunk (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:189:37)
	at /Users/jrieken/Code/vscode/out/vs/base/parts/ipc/common/ipc.net.js:158:61
	at Socket.listener (/Users/jrieken/Code/vscode/out/vs/base/parts/ipc/node/ipc.net.js:17:40)
	at Socket.emit (events.js:315:20)
	at addChunk (_stream_readable.js:295:12)
	at readableAddChunk (_stream_readable.js:271:9)
	at Socket.push (_stream_readable.js:212:10)
	at Pipe.onStreamRead (internal/stream_base_commons.js:186:23)
log.js:144   ERR ModelService: Cannot add model because it already exists!: Error: ModelService: Cannot add model because it already exists!
    at ModelServiceImpl._createModelData (file:///Users/jrieken/Code/vscode/out/vs/editor/common/services/modelServiceImpl.js:297:23)
    at ModelServiceImpl.createModel (file:///Users/jrieken/Code/vscode/out/vs/editor/common/services/modelServiceImpl.js:365:34)
    at ModifiedElement._buildMetadataEditor (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:368:65)
    at ModifiedElement.updateMetadataRendering (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:219:26)
    at PropertyHeader.buildHeader (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:148:27)
    at ModifiedElement.buildBody (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:931:34)
    at new AbstractElementRenderer (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:207:18)
    at new ModifiedElement (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/diffComponents.js:876:13)
    at InstantiationService._createInstance (file:///Users/jrieken/Code/vscode/out/vs/platform/instantiation/common/instantiationService.js:89:20)
    at InstantiationService.createInstance (file:///Users/jrieken/Code/vscode/out/vs/platform/instantiation/common/instantiationService.js:60:31)
    at CellDiffSideBySideRenderer.renderElement (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.js:202:83)
    at PipelineRenderer.renderElement (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:750:26)
    at ListView.insertItemInDOM (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:538:26)
    at ListView._splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:344:26)
    at ListView.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:267:29)
    at file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/splice.js:14:45
    at Array.forEach (<anonymous>)
    at CombinedSpliceable.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/splice.js:14:30)
    at file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:970:67
    at EventBufferer.bufferEvents (file:///Users/jrieken/Code/vscode/out/vs/base/common/event.js:674:23)
    at NotebookTextDiffList.splice (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listWidget.js:970:32)
    at NotebookTextDiffEditor.updateLayout (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:346:24)
    at async file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:231:25
log.js:144   ERR Cannot read property 'domNode' of null: TypeError: Cannot read property 'domNode' of null
    at ListView.updateItemInDOM (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:568:22)
    at ListView.render (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:489:26)
    at ListView.updateElementHeight (file:///Users/jrieken/Code/vscode/out/vs/base/browser/ui/list/listView.js:255:18)
    at NotebookTextDiffList.updateElementHeight2 (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.js:252:23)
    at relayout (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:372:28)
    at AnimationFrameQueueItem._runner (file:///Users/jrieken/Code/vscode/out/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.js:380:17)
    at AnimationFrameQueueItem.execute (file:///Users/jrieken/Code/vscode/out/vs/base/browser/dom.js:147:22)
    at animationFrameRunner (file:///Users/jrieken/Code/vscode/out/vs/base/browser/dom.js:183:21)

notebook and just wait a little

More insights: this is waiting for some file seems to be fired (unsure when/how) and that causes things to go south

notebook and just wait a little

More insights: this is waiting for some file seems to be fired (unsure when/how) and that causes things to go south


docs(README): use correct name for tslib

ts-lib is some 6 year old package with no README, tslib is the correct package.

Good spot!


Update to SuiteSparse:GraphBLAS 9.1.0

@alugowski @michelp I made some progress updating python-suitesparse-graphblas to 9.1.0 (yes I know 9.2.0 was just released).
The wheel builds are failing (hooray for tests!), and I'm wondering if either of you could help take a look (I'm busy traveling this week and next week).
Changes:

It looks like "GraphBLAS.h" moved from "include/" to "include/suitesparse", and we need to update the wheel building scripts to look here
It looks like add_arm_to_libomp_dylib.sh script may no longer be necessary
SuiteSparse:GraphBLAS updated how it builds (maybe in 8.3?), and we need to update too. Maybe this means using cmake instead of make as was done here: https://github.com/conda-forge/graphblas-feedstock/pull/71

I can take a look this weekend.
To get rid of the macos OMP hack we'll need to use the new runners as per https://github.com/actions/runner-images/issues/9254
We may need to keep the current one for x86, too, since we get omp from brew and AFAIK it'll still only install the native arch. That's ok, I purposely kept the two macos arches separate in anticipation of this :)

FYI I've had good experience using scikit-build-core for cmake-based projects. Better try fixing what we have first, but might be worth considering for any future refactor.

Would it be possible to make this into a branch on this repo so I'm able to add commits?

The latest updates to the cmake build system for GraphBLAS (and all of SuiteSparse) is very stable now. So any changes you need to make would also work for a long time, for future updates to my codes.

Would it be possible to make this into a branch on this repo so I'm able to add commits?

Done. update9.1.0 branch

Would it be possible to make this into a branch on this repo so I'm able to add commits?

Done. update9.1.0 branch

Great! I pushed changes to that branch that appear to work. Sorry I don't think it's possible to update the PR to be from that branch instead of the one from your fork, so I opened a new PR https://github.com/GraphBLAS/python-suitesparse-graphblas/pull/128 Let's move discussion there.


Get rid of jQuery

jQuery.jFeed can be replaced with the feed parser used by the RSS reader
most $() can be changed with document.querySelector()

Fixed by https://github.com/nt1m/livemarks/commit/2df117107fb26c4119cb8b0840ecbd0ca1f75634


Use the chrome.runtime api onInstalled event to launch the firstrun page

There is an event provided by the chrome.runtime api to determine when an extension is updated or installed.  Currently we use stored values in LocalStorage to determine this.  We should update firstrun.js to use this API instead of maintaining this functionality ourselves.

Working on this.

PR sent on #109

Had some issues with #109 . Sent a new PR on #110 .

See https://github.com/privly/privly-chrome/blob/develop/javascripts/background_scripts/first_run.js#L10


Expose “dev mode” flag (3.x)

This is a 3.x back-patch of #138

Creates a top-level getter that can be used to conditionally do stuff based on whether the "dev" build of ReactJS is being used on the page.
@greglittlefield-wf @jacehensley-wf @clairesarsam-wf @trentgrover-wf

+10

All tests pass locally in content-shell and chrome

Merging this and releasing 3.7.0


Remove unused repos.json file accessor

From what I understand, https://github.com/fastlane/ci/pull/459 will make more methods unnecessary that are in this file 👍


Decorator @minValue, @maxValue to support scalar Duration

Clear and concise description of the problem
Context: ARM guidance instructs Resource Providers to expose duration in the ISO 8601#Durations, e.g.:

Human readable
System.Timespan
Duration

1 minute
00:00:01
PT1M

1 hour 15 minutes 30 seconds
01:15:30
PT1H15M30S

Here's my TypeSpec model where I have a property of type scalar duration but which is missing the Seagger-side validation for the min and max values:
@doc("Threshold properties")
model ThresholdProperties {
  @doc("Window duration")
  //@minValue("?")
  //@maxValue("?")
  windowDuration: duration;
}

Proposal: update the existing decorators minValue and maxValue to support more scalars, such as duration, e.g.:
@minValue("PT1M")
@maxValue("PT1H")
windowDuration: duration;

Checklist

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

OpenAPI's minimum, maximum are numeric values. While TypeSpec is richer than OpenAPI, we need to figure out the unit translations from string such as "PT1M" to a numeric value. There will be information loss when generated to OpenAPI.
Proposals:

Do nothing. Our client codegen does not do client-side validation. So adding this doesn't add any value to the current scenario.

Extend current @minValue and @maxValue to apply to a duration property and let user to specify and interpret the base for that number. For Azure, we can specify a base such as second for the value.
Affects:  1P & 3P
Pro:  Minimal change, Flexible
Con: User need to do unit translation, Unclear intension to codegen if validation needs to be generated

Add @durationMinValue and @durationMaxValue.

extern dec durationMinValue(target: ModelProperty, minValue: valueof string, encodingUnit: "h" | "m" | "s" | "ms" = "s");

model Foo {
  @durationMinValue("PT1M", "s")
  prop: duration;
}

=>
      properties:
        a:
          type: string
          format: duration
          minimum: 60

Affects: 1P & 3P
Pro: Minimal impact, Precise
Con: Same information loss in OpenAPI.

Add #2 only in Azure.Core to limit it to 1P. When the RPaaS service codegen is back up, this information can be used to provide precise validation in service code.
Affects: 1P & 3P
Pro: Limited usage & impact, Precise definition
Con: Azure only, Codegen needs specificalization


[filter-form] Replace Type bestuursorgaan filter for Type eredienst

Description
DL-5330
This PR replaces current filter Type bestuursorgaan filter for Type eredienst so users can look for recognized worship types when they're already filtering on Type bestuur leaving them 6 options to pick from (Anglicaanse, Islamitische, Israëlitische, Orthodox, Protestantse of Rooms-Katholiek).
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other

Related services

frontend-worship-decisions
mu-cl-resource
toezicht-search-query-management

How to test (From Loket app)

drc up -d
Make sure the seach-query-management and frontend services have been pulled.
a. You can always proxy the ember app instead of pulling the image if that doesn't work
Log as ABB.
Apply type bestuur filter then type eredienst based on the 6 options.
It should show results.

See Examples here

What to check

Typos

Links to other PR's

https://github.com/lblod/toezicht-search-query-management-service/pull/1
https://github.com/lblod/app-worship-decisions-database/pull/81

Notes

Make proper release + CHANGELOG

Haven't been able to test due to that missing image of the other service, but the code change looks good :+1: .


#159268417 Distinguish between tools and technologies in README

What does this PR do?
Clarifies the distinction between technologies and tools
Description of Task to be completed

Understand the difference between a tool and a technology.
Rewrite README file to reflect the newly acquired understanding

How should this be manually tested?
Review the README file
What are the relevant pivotal tracker stories?
#159268417

Pull Request Test Coverage Report for Build 37

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 35:
0.0%

Covered Lines:
51

Relevant Lines:
51

💛  - Coveralls


OxO 2 - Simple voting feature

@serjoshua dont try to work on this yet, but if you could give me an estimate of how much it would be to do this:

Add a thumbs up thumbs down button on each mapping (both search and mappings pages)
Create a log in with ORCID features (openid)
When clicking thumbs up or thumbs down, the orcid along with the vote is stored in a file somewhere.

Do you have any experience with openid? How hard would it be to build this feature?

No experience with OpenID. A bit familiar because of OntoString. An API that the UI can consume will be useful.

Basically what you are saying is that we need an API endpoint in the SSSOM API to record votes (I think this makes total sense).
But I still need some way to understand how much work Open ID login would be. Are we talking 10 days, 20 days, 30 days?

I think even the OpenID thing could be an API, but not sure if we have to. I have to check OpenID first or our OntoString implementation in Java. On a high level perspective, this could be a half a week effort. If you include the voting, might be a week.

Alright, I will leave it to you to figure this out in between other tasks.
Let's assume a POST api endpoint where you send a rating (0 or 1) and an ORCID, but no need to wait for this. As for login I think I would prefer into a system that does not need any registration. You login with openid or github or whatever and that is enough authentication for this. Please discuss with both Anita and James when you see them - I do Not want to build a backend for managing users, just a simple way to provide a rating.


Add Code of Conduct

We recommend that every repo has a code of conduct. If you don’t feel comfortable creating your own Code of Conduct from scratch we highly recommend using one of the templates provided by GitHub. If you do use a template, please read through the template and ensure that you can and will abide by the Code of Conduct.
Please follow these instructions on how to add a Code of Conduct.
Sample: https://github.com/Recode-Hive/Stackoverflow-Analysis/blob/main/CODE_OF_CONDUCT.md

@Princegupta101 there is code of conduct file, is there any problem in it?


build: keep the boot partition with label COS_GRUB

Problem:
The boot partition changed after we repacked to support the legacy BIOS.
That would make the installation hang because of the wrong partition. We depend on the COS_LIVE to mount the data partition on installation.
Solution:
Keep the boot partition has the COS_GRUB label
Related Issue:
https://github.com/harvester/harvester/issues/4510
Test plan:
Make sure the whole installation works as usual.

LGTM, tested installation without any issue. I'm wondering how to fully test this issue, as I can't even reproduce the problem this issue brought up 🤔

Thanks for the review. For me, I reproduce in the following ways

Simulate the USB drive with ISO on the KVM (@bk201 has some trick for it)
Use dd or similar behavior ISO editor to flash ISO to USB to reproduce on my i7 laptop

BTW, rufus would not work because it will break the original ISO layout.

Investigate the lab Jenkins failure, tested with interactive/iPXE mode on my local environment.

Investigate the lab Jenkins failure, it works fine with interactive/iPXE mode on my local environment.

Somehow installation was stuck before installation, try to install it on vnc and looks fine.
Re-trigger test again and looks normal.

@mergifyio backport v1.2


tidy: blob check vs shallow clone

We want to avoid large files in the repository. Naively listing just the files won't work: if the file is added in one commit and removed in a subsequent one, it will be absent from the working tree, but will still be perpetually present in the Git history.
For this reason, tidy is smart --- it asks git itself to list large git objects.
But GitHub outsmarts tidy, as it does a shallow clone by default.
Fix this treachery within treachery within treachery with a proper clone
See https://stackoverflow.com/a/6802238/1936422 for why this specific depth.

Double-checked that it actually works:
https://github.com/tigerbeetle/tigerbeetle/actions/runs/8821492655/job/24217470840

If you hadn't delay, I wouldn't have realized that I can actually check this by adding large file and reverting it in this branch. So, no, you failed to delay unproductively!