chapter4/thesaurus/thesaurus.go - interface not used?

The interface, Thesaurus, we create in Chapter 4 does not seem to be used in the rest of the code?
If I haven't missed something how would the code change if we did require this interface?
I think I need a little more explanation here please.

It's more the idea of describing an interface, which we then provide the first (or default) implementation of. But it would let others (outside the code) contribute their own implementations, and they wouldn't be forced to use ours.

Would it be clearer if we used a var statement first, in synonyms/main.go?
var thesaurus thesaurus.Thesaurus
Then we actually use the interface in this example code?

Thanks Mat,that is pretty much what yous said in the book. Are you saying that the interface would never get used in the code and that it is just a guide to future users?

Yeah, and you might well decide not to do this. Instead, you could provide a concrete type and let other users write an interface that fits if they need it. As an extra exercise, you could try writing a test implementation that doesn't use a real web service?


Change BackEndGrpc naming

The BackEndGrpc class should be renamed as RemoteBackEnd and related header/source files should be renamed as well.

Done thanks to #292 and file rename in https://github.com/torquem-ch/silkrpc/commit/ddabeddec107b24c505d13c36994680f44e5d095


Canceling a reload closes autoupdate connections

Open a form that prevents reloading (for example motion create)
Fill out a field
Reload
An alert should open - Click Stay on page

Now all autoupdate connections got closed.

While investigating this I stumbled upon caveats regarding beforeunload and unload events causing this events not to be fired. (For example using a mobile device).
This could cause the following issues:

stream.component.ts the streaming lock will not be deleted
autoupdate.service.ts streams not getting closed.

While 1. only leads to the livestream not starting automatically 2. could cause performance issues.
Further information can be found here: https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event#usage_notes and https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event.


Fixed some typos in README.md

@greg1232 Hi again! I fixed a few typos and one grammar error.

Thank you!


API Version Latest Query Return

Adding a catch to the API wrapper to return latest version of a given file
Overview

Made changes in the cli to catch if --version latest is passed in. Version would then need to be removed in order for a correct query to be returned. That query is then filtered based on what the greatest version number is.
Closes #38
New Dependencies

New Files

Deleted Files

Updated Files

cli.py

Testing

I plan on doing a General Documentation update soon for the API wrapper. My hope is for it to be a clear outline of how to utilize the wrapper and what features it supports. That way certain commands like --version latest don't get coded and then never mentioned. My plan is to include everything that the api wrapper should be able to do and then label certain commands as WIP .

https://github.com/all-contributors please add @daralynnrhode for code

@all-contributors please add @daralynnrhode for doc


Bump upper bounds on time and filepath deps

Also remove un-need allow-newer stanzas in cabal.project.

Thanks @tvh !


[Angular - NgRx] Fix: add missing netlify badge to profile page

The Netlify badge was missing from the profile page, so this PR adds the badge to that page.
Closes #1294

Also fixed deploy previews in this PR! 🎉

Browser metadata
Path:      /lindakatcodes
Browser:   Chrome <IP_ADDRESS> on Mac OS 10.15.7
Viewport:  1648 x 968 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved


Develop upstream sync 200518

Upstream-sync for the week of 2020-05-18.  Fixed merge conflicts.
$ git merge google_upstream/master --no-edit
Auto-merging third_party/gpus/cuda_configure.bzl
Auto-merging tensorflow/tools/api/golden/v2/tensorflow.raw_ops.pbtxt
Auto-merging tensorflow/tools/api/golden/v1/tensorflow.raw_ops.pbtxt
Auto-merging tensorflow/tensorflow.bzl
Auto-merging tensorflow/python/ops/signal/mel_ops.py
Auto-merging tensorflow/python/ops/nn_ops.py
Auto-merging tensorflow/python/ops/math_ops.py
Auto-merging tensorflow/python/kernel_tests/matrix_solve_ls_op_test.py
Auto-merging tensorflow/python/kernel_tests/BUILD
Auto-merging tensorflow/python/debug/BUILD
Auto-merging tensorflow/python/compiler/tensorrt/BUILD
CONFLICT (content): Merge conflict in tensorflow/python/compiler/tensorrt/BUILD
Auto-merging tensorflow/core/ops/nn_ops.cc
Auto-merging tensorflow/core/kernels/BUILD
Auto-merging tensorflow/compiler/xla/service/gpu/ir_emitter.cc
Auto-merging configure.py
Auto-merging README.md
Automatic merge failed; fix conflicts and then commit the result.

Can one of the admins verify this patch?

All unit tests pass -
rocm:
Executed 1403 out of 1403 tests: 1403 tests pass.

rocm-cpp:
Executed 741 out of 741 tests: 741 tests pass.

rocm-xla:
Executed 937 out of 937 tests: 937 tests pass.

Merging this weekly sync.


Convert to Swift 4

Support for Swift 4

It would be great if anyoune could accept this PR 😸

Sorry, all mailing from github goes to spam :<


Fix faulty "missing argument in phpDoc block" check

Fixes phpDocumentor/phpDocumentor2#1476

Please resubmit this PR against master so that we can include it in version 2.8.*


[Bug] When renaming fields/methods, references get not renamed (in different files)

Describe the bug
When renaming a method from an objects point of view, the method is getting renamed and the definition is getting renamed as well, but all known instances of the class wont get renamed.
To Reproduce
Steps to reproduce the behavior:

Create a class and two instances
Create a method and invoke them by these two instances (one in another file).
Rename the method from one of the instances
See that the other one won't get renamed

Expected behavior
Either errormessage renaming from objects POV or rename all referenced methods.
Screenshots

Environment (please complete the following information):

OS: Windows
Client: VSCode

Additional Context
Apparently same issue with classes.

They should be fixed in 2.3.7, please check out it

There is still this issue:

But with class works fine.


add GetIPV4Routes,GetIPV6Routes function

Currently, after routing.New(), the v4,v6 routing table info is only used for String() or internal use.
It makes sense to increase the interface to obtain ipv4 and ipv6 routing table information separately.
For example, I use it to compare whether the ip segment is in the corresponding routing table.

@googlebot I signed it!

I would be happy for any friend who has passed CLA to approve and submit the PR  :)


LINK error when building for UWP with IL2CPP in Master configuration

After adding "SQLite for Universal Windows Platform" to the references, apps will build for UWP while in the Debug or Release configuration, but not under the Master configuration.
The error that occurs is: "LNK1181: cannot open input file 'sqlite3.lib'"
This is an issue because some of .net is excluded in non-IL2CPP builds for UWP, and Unity games will only pass Microsoft's certification when built with the Master configuration in visual studio. This issue can be reproduced with the example project in the repository.

This issue is not actually a problem with the plugin, but with the way that unity interacts with the SQLite for Universal Windows Platform extension. To solve this issue, you need to edit the file in the plugin directory at: "\v<IP_ADDRESS>\ExtensionSDKs\SQLite.UWP.2015\3.19.2\DesignTime\CommonConfiguration\neutral\SQLite.UWP.2015.props"
Open that file as an administrator in a text editor (Visual Studio works), and add the line "Retail" in the  block.


chore: Add v1 APIs and Conversion webhooks for v0.36.x

Fixes #N/A
Description

Add v1 APIs and the conversion webhooks
This is a copy and from main to release a patch version of 0.36

How was this change tested?

make presubmit

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

255 of 717 (35.56%)  changed or added relevant lines in 9 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-4.7%) to 77.631%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1/ec2nodeclass_defaults.go
0
1
0.0%

pkg/apis/v1beta1/ec2nodeclass_conversion.go
0
2
0.0%

pkg/apis/v1/ec2nodeclass_conversion.go
184
190
96.84%

pkg/webhooks/webhooks.go
0
6
0.0%

pkg/apis/v1/ec2nodeclass_status.go
0
14
0.0%

pkg/apis/v1/ec2nodeclass.go
37
60
61.67%

pkg/apis/v1/zz_generated.deepcopy.go
0
410
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.43%

pkg/fake/utils.go
2
94.56%

Totals

Change from base Build<PHONE_NUMBER>:
-4.7%

Covered Lines:
5598

Relevant Lines:
7211

💛  - Coveralls


Compare images using raw data

Improves the performance of image comparison by using raw data instead of Color structs.
Reading the image to the buffer line by line to prevent the array getting placed on the LOH.
Did not save the measurements I did, but from memory I think this lowered the time from around 80ms to 10ms per image pair.
This adds some dependencies and complexity, not sure what you think of that.
Made a smaller edit with improvements if you rather not add more dependencies I can make a pull-request of that:
https://github.com/DarkOoze/ScreenToGif/tree/local-counter
P.S. My first pull-request, please be gentle 😄.

Hi, sorry for the delay.
Right now, I'm trying to use less dependencies possible. To enable a simple single executable for the portable mode.
This will change when I switch to .NET 5.

Refactored the method to remove the dependencies and the lock object.

I'm back on testing this PR and I found an issue.
In a test project, the resulting process got me a different number of frame than the current code (using same settings).
Current:

Proposed:

After a couple of tries I was able to reproduce it and found the issue.
The Current implementation don't compare the last pair. Is that intended?
for (var i = 0; i < Project.Frames.Count - 2; i++)
{

The line below gets Frame + 1, so for the last iteration, there's no next frame to compare.
Looks like the difference is in the image comparison method (I'm still trying to understand).
Oh btw, I just noticed that the image comparison method is using an old PixelUtil utility.
With the newer PixelUtil, it's possible to reduce the delay with the Unlock() method by using UnlockBitsWithoutCommit() instead (since nothing is being changed, just compared).

I noticed that on a test project, frames 2 and 3 have a different equal pixel count.
Current: 222532
Proposed: 222528
Some other frames had the same pixel counts.
I'm still not sure which one is the correct.
46 frames.zip

Are you sure? I'm getting the same result in both versions.
0 1 222554
1 2 222528
2 3 222532
3 4 222528
4 5 222528

I was mistaken. Your code is working fine :)
The current code should have been i < Project.Frames.Count - 1 instead.


dialect/sql/schema: fix postgres index migration

Fix PostgreSQL index migration when table_name = type_name.
Closed #1344

Skipping the migration CI test, because this PR renames tables.


CodeChecker to support clang-tools like compilation database lookup (multi-root workspace)

CodeChecker should support an analysis mode where for each source file,
it tries to find the closest compile_commands.json file up in the directory hierarchy starting from the source file.
clangd and clang-tidy works this way: https://clangd.llvm.org/installation.html
clangd will look in the parent directories of the files you edit looking for it, and also in subdirectories named build/. For example, if editing $SRC/gui/window.cpp, we search in $SRC/gui/, $SRC/gui/build/, $SRC/, $SRC/build/, …
This feature would allow the analaysis of multi-root projects also in the vscode plugin https://github.com/Ericsson/CodecheckerVSCodePlugin/issues/113

Done in #3815


Feature request: merge

As of the new Inkscape 1.0 release, it is found it runs slow or more often hangs with multiple <style> tags. Merging all the tags will resolve part of the problem.
Eg.
<style ... >
stuff { }
</style>
<style ... >
stuff2 { }
</style>

Should becomes
<style ... >
stuff { }
stuff2 { }
</style>

It is definitely not necessary to resolve issues for other program, but it seems merging tags can reduce the file size, which meets the goal of SVGO. Also, as far as I know, at least matplotlab is producing a lot figures with this problem, which means that this feature will benefit a lot people.
See https://gitlab.com/inkscape/inkscape/-/issues/504 for details on the Inkscape issue.

@snail123815: PR ready for the mergeStyles plugin: https://github.com/svg/svgo/pull/1278

Fixed in https://github.com/svg/svgo/releases/tag/v2.3.0


Suggest new feacture

You can add an onclick event on each cabin?
I want yo use a ferris wheel component like a different component to "loading component".
Each cabin trigger a onclick for differents actions
Also you can add a xml attribute like "autoplay:true" for auto-play animation
Thanks for your time!

@gtmora200 sorry about the delay.
You can try new version 1.2


Move OpenStack plugin configuration to it's own page

Similar to plugins like Gerrit Trigger plugin, it would be nice if the OpenStack plugin configuration is own it's own page. We find that all the plugins having configuration inside the global jenkins config page inconvenient and overloads the page.

That is a valid request for all clouds as they tend to be quite chatty. Needs to be addressed in Jenkins core.

https://issues.jenkins-ci.org/browse/JENKINS-36341


Disabling jit for small subsection of code

Is there an easy way to disable jitting for a part of the code only?
# can't @jax.jit because it contains a non-jittable section
def foo(a):
   b = bar(a) # jittable
   c = scipy.bfgs.minimize(b) # non-jittable
   d = zar(c) # jittable
   return d

This can be manually split into two different jit sections
bar = jax.jit(bar)
zar = jax.jit(zar)
def foo(a):
   b = bar(a)
   c = scipy.bfgs.minimize(b) # non-jittable
   d = zar(c)
   return d

However I often have an extremely long call-stack that explicit jitting is very tedious (especially through compositions and custom_vjps) and it would be nice to be able to specify something like @jax.nojit. Not sure how the implementation detail would work though, maybe automatically generate two sets of jaxprs/HLOs that sandwich the non-jittable part?
(and yes, I've tried tfp's bfgs optimizers and unfortunately it is very deficient compared to that of scipy's bfgs)

We've talked about adding such a feature, but nothing of that form exists at the moment. There's no way to "escape" from a JIT computation and call back into Python at the moment.


As a web content producer, I need help with auro icon screen reader availability

General Support Request

Support request

The title and desc tags rendered by auro-icon are not accessible to NVDA screen reader.  I believe this is because aria-hidden="true" is rendered by auro-icon in the svg tag that contains the title and desc tags.  When i set this to false, NVDA read the title and desc tags.
Page tested on: https://www.alaskaair.com/content/travel-info/flight-experience
Auro-icon example element from live page:

Shadow root from the above auro-icon:
First Class legroomIndicates additional legroom for First Class cabin
Possible Solution

I think preferred solution for web content would be to remove default of aria-hidden="true" from auro-icon.
If that isn't possible, allowing us to pass aria-hidden="false" into auro-icon would be a usable solution.  I tested this out just to see if it already exists.  It did not work for me so I would guess this isn't currently an option.
Auro-icon doc: https://auro.alaskaair.com/icons
Context

By end of year, we need to have all images accessible by screen reader.  This means ALL images.  That includes small icons, svgs, background images, scenic images.
Your Environment

Version used: 3.1.0 (i think)
Browser Name and version: Chrome Version 104.0.5112.102 (Official Build) (64-bit)
Operating System and version (desktop or mobile): Windows desktop
Link to your project: na

Fixing my code examples so they show up.
Auro-icon example element from live page:
<auro-icon class="small-icons" style="color:var(--auro-color-brand-midnight-400)" customcolor="" customsize="" category="in-flight" name="first-class-legroom"></auro-icon>
Shadow root from the above auro-icon:

<svg viewBox="0 0 24 24" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns="http://www.w3.org/2000/svg" role="img" aria-hidden="true" style="min-width:var(--auro-size-lg);height:var(--auro-size-lg);fill:currentColor" class="ico_squareLarge"><title>First Class legroom</title><desc>Indicates additional legroom for First Class cabin</desc><path d="m8.872 7.324.31 <IP_ADDRESS>.629 2.207c.234.782.462 1.24.682 1.3<IP_ADDRESS>.046.827.05H13.32c.072-.004.144-.002.215 0 .722.03 1.205.203 1.447.5<IP_ADDRESS>8.846.843 <IP_ADDRESS>.<IP_ADDRESS>6l1.483 3.292c.<IP_ADDRESS>2.197.4<IP_ADDRESS>3.615.525.6<IP_ADDRESS>3.066 1.622.031a.714.714 0 0 1 .74.688v.026a.745.745 0 0 1-.746.745h-1.9c-.07 0-.14.002-.21.004-.46.019-.76-.061-.899-.24a3.12 3.12 0 0 1-.224-.395l-.115-.233a38.295 38.295 0 0 1-.294-.616l-.028-.06-1.57-3.47a5.24 5.24 0 0 1-.159-.394c-.33-.925-.604-1.439-.819-1.542h-1.958c-.04 0-.078 0-.117.002-1.437.032-2.237-.22-2.4-.757-.438-.845-.82-1.85-1.149-3.015l-.12-.444-.43-1.67a.736.736 0 0 1 .553-.902.815.815 0 0 1 .958.563Zm3.008 11.679a.745.745 0 0 1 0 1.49H7.786a.745.745 0 0 1 0-1.49h4.094ZM4.986 7.595l1.426 5.42c.<IP_ADDRESS>.045.16.292.93.594 1.635.904 2.117.324.503.955.75 1.894.742a2.24 2.24 0 0 0 .324-.012l2.307.009c.4<IP_ADDRESS>3.74.742a.74.74 0 0 1-.74.74H9.729c-.09 0-.181.003-.272.01-1.457.113-2.53-.281-3.221-1.183-.484-.632-.899-1.52-1.244-2.66-.015-.05-.029-.101-.042-.152L3.52 7.894a.71.71 0 0 1 .547-.871.789.789 0 0 1 .92.572ZM7.32 3.5c.69 0 1.25.551 1.25 1.231s-.56 1.231-1.25 1.231a1.24 1.24 0 0 1-1.25-1.23c0-.68.56-1.232 1.25-1.232Z"></path></svg>
<slot></slot>

Icons are 100% presentational. They are not required to be read aloud by a screen reader. Icons are to be accompanied by editable text.
https://accessibility.expedia.biz/pages/5-2

By end of year, we need to have all images accessible by screen reader. This means ALL images. That includes small icons, svgs, background images, scenic images.

I disagree with this statement.

That being said, there is an opportunity to have the aria-hidden attribute made editable for the auro-icon element.

This issue also raises interesting questions. Given that there are some opportunities for icons to be read aloud to screen readers, e.g. the icons that appear in auro-hyperlink, aria-hidden is on the SVG itself, not on the auro-icon element.
While I disagree that ALL icons should be read in screen readers, that's not Auro's call to enforce an opinion on that.
The actual work to be done is with Auro Icons to remove that aria-hidden attribute. Then in the auro-icon element should be updated with an aria attribute that would be set to false by default but will allow the end user to decide if the icon should be read aloud or not.
See the title key in this json file for all the content that would be read back by screen readers. https://github.com/AlaskaAirlines/Icons/blob/master/src/data/icons.json
Additional issues created for this:

https://github.com/AlaskaAirlines/auro-hyperlink/issues/134
https://github.com/AlaskaAirlines/Icons/issues/137

per our separate email thread, please change the default behavior of auro-icon to be that aria-label is "displayed" / readable by screen readers.  i believe you already have descriptions for all of the icons in the aria-labels and they just need to be made accessible.  let me know if i can assist with any missing descriptions.  Deunan would be another good resource for getting actual copy to include.

Moving this issue to BACKLOG. All work will be tracked in the issues linked to this issue. This issue will remain open until all related work is complete.


Blur Background move up when using Collapsing toolbar(With Appbarlayout)

If I use normal toolbar without Appbarlayout, it works fine but when I use Appbarlayout for collapsing purpose, then the blurred background move up(hiding half of the toolbar)

@ajaystha005 Were you able to resolve it?


Documentation: libs release branch testing doc (more details)

Based on the discussion in https://github.com/falcosecurity/libs/pull/580 additional documentation can help increase technical clarity around additional testing of libs in release branches.
@incertum team up with maintainers to help create v1 of such a doc. https://github.com/falcosecurity/libs/pull/580#discussion_r965072203
CC @leogr @Molter73

/assign @incertum

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Assuming this has been fixed by #580
/close

@leogr: Closing this issue.

In response to this:

Assuming this has been fixed by #580
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


docs: Small fixes

Individually small fixes. Spelling, typos, repeated words...

Fixes issue #254

Codecov Report

Merging #260 (312e575) into master (bacb96e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   85.10%   85.10%
=======================================
  Files          44       44
  Lines        2725     2725
=======================================
  Hits         2319     2319
  Misses        406      406

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Uploading pfx with 2 public certificates goes wrong

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az functionapp config ssl upload
Errors:
'NoneType' object has no attribute 'digest'
Traceback (most recent call last):
Temp\pip-install-yh2ypeu1\knack\knack\cli.py, ln 215, in invoke
azure\cli\core\commands\__init__.py, ln 654, in execute
azure\cli\core\commands\__init__.py, ln 718, in _run_jobs_serially
azure\cli\core\commands\__init__.py, ln 709, in _run_job
azure\cli\command_modules\appservice\commands.py, ln 55, in _polish_bad_errors
azure\cli\core\commands\__init__.py, ln 688, in _run_job
azure\cli\core\commands\__init__.py, ln 325, in __call__
site-packages\azure\cli\core\__init__.py, ln 776, in default_command_handler
azure\cli\command_modules\appservice\custom.py, ln 2207, in upload_ssl_cert
azure\cli\command_modules\appservice\custom.py, ln 2224, in _get_cert
AttributeError: 'NoneType' object has no attribute 'digest'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az functionapp config ssl upload --certificate-file {} --certificate-password {} --name {} --resource-group {} --query thumbprint --output tsv

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.6.6
Installer: MSI

azure-cli 2.9.1 *

Additional Context

functionapp


False positive with untrusted flag, but manual certificate check shows trusted status

tlsx version: v1.0.9
Current Behavior:
In my case, the tool flagged a certificate as untrusted, but the manual inspection of the certificate showed it to be trusted.
Expected Behavior:
The tlsx tool should accurately identify untrusted certificates, providing reliable results consistent with manual certificate checks.
Steps To Reproduce:

Run tlsx tool with the appropriate parameters on the target website. (tlsx -un -host ebay.co.jp)
Note the output and observe if any untrusted flags are raised.
Manually check the certificate of the website using other methods (e.g., web browser)

Anything else:
List of Certificates:
(https://ebay.co.jp/): The tlsx tool flagged the certificate as untrusted, but manual inspection showed it to be trusted.
(https://www.mylandscapes.co.uk/): Similarly, the tool indicated an untrusted certificate, while manual inspection confirmed its trustworthiness.
(https://comicon.it/): Another instance where the tool's untrusted flag did not match the actual trusted status of the certificate.
More Certificates for example:

I believe this issue is worth investigating to ensure the accuracy of the tlsx tool's results.

@whydee86 this is now fixed in latest release - https://github.com/projectdiscovery/tlsx/releases/tag/v1.1.1

I appreciate your attention and resolution to this issue.
It's working amazing now, as you can see in the image below. Thank you!


Ability to skip ssl verification in the pull request pipeline resource

Expected Behavior
I should be able to use the pull request pipeline resource in conjunction with a self hosted git server (e.g Gitlab) with a self signed certificate for testing.
Actual Behavior
The pullrequest pipelineresource code provides no mechanism by which to create a client with tls insecureSkipVerify set to true.
Steps to Reproduce the Problem

Create and use a pull request pipelineresource against a git server with a self signed certificate

Additional Info

@dibbles Now what #1881 is merged, can we close this or is there more work remaining?

ah yes.... good spot! Closing.


Removing nop from rtic::export

As discussed in #733, re-exporting nop in rtic::export may be unnecessary, and something like continue would do the trick in most cases. Personally, I'd keep the mandatory elements of rtic::export to the minimum. If anyone needs by chance the cortex_m::nop instruction, I'd say that they use it directly from the cortex-m crate instead of RTIC's re-export.

This sounds good to me. It's a remnant from when loop optimization was broken I'm the compiler.


Battery export sensor incorrect

Describe the bug
The battery export sensor indicates a battery discharge of only 3kWh/day while reality is approx. 12kWh/day
Expected behavior
correct data being read from the battery export sensor
Screenshots

Diagnostic File
config_entry-solaredge_modbus_multi-a150630511e990a73146f8eb62c16c53 (1).json
Debug logs
20 minute debug log was almost 4 million characters and messed up the form.

Home Assistant Version
2024.4.1
solaredge-modbus-multi Version
latest
Installation Type
HAOS
Read the Instructions

[X] I have read https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki
[X] My configuration follows https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Configuration
[X] This issue is not about a template error (template errors should not be reported as an issue, read https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Template-Design-Notes)

Additional Context
Up until recently, the battery export sensor functioned fine, although, due to a database change, I cannot dettermine when it started to go wrong, but it is clearly visible that the data is not correct.

If you look in the debug file look for the battery_id_1 section towards the bottom.
The sensor values for battery energy are:
        "B_Export_Energy_WH": "0x40806d",
        "B_Import_Energy_WH": "0x409e8b",

These are hex integer values, so a value of 0x40806d is 4227181 watt-hours, or 4227.181 kilowatt-hours
The integration does not interpret these values, they are passed through as given by the inverter. You would need to either download diagnostic files or watch debug logs to check if that value is increasing or not.
The data in the SolarEdge online platform is separate from modbus.

So if I understand you correctly, the integration reads the values as presented by the inverter and only converts the HEX to numerical value. Then I appologize for sending in the bug report and will try to solve on the inverter side.

Concerning these two sensors (sensor.solaredge_b1_energy_import and sensor.solaredge_b1_energy_export) I see them unavailable frequently. Reloading the integration kicks them again.

Did you find a solution for this?
I see the same

I'm running off battery overnight, and the B1 Energy export level is not changing overnight

No, according to the developer it is not the integration, so no, there is no solution.
I doubt it is the SolarEdge software as the web-application shows the correct information.

Download diagnostic files or check debug logs to see if the value of B_Export_Energy_WH or B_Import_Energy_WH is changing.

Hi,
i am having the same issue and will monitor the logfiles after it freezes, then reload and check the logfiles again.

 > /tmp/04.log

Step 1: Screenshot, state unknown since yesterday 2200ish
Step 2: Activate logging
Step 3: Reset Integration
Step 4: Screenshot, state OK
Step 5: Download log
Step 6: Deactivate logging
The first lines in the log :
2024-04-20 22:24:14.794 WARNING (MainThread) [pymodbus.logging] Failed to connect  2024-04-20 22:24:18.599 WARNING (MainThread) [pymodbus.logging] Failed to connect  2024-04-20 22:24:24.002 WARNING (MainThread) [pymodbus.logging] Failed to connect  2024-04-20 22:24:34.205 WARNING (MainThread) [pymodbus.logging] Failed to connect
Correspond well with the battery sensor death, although i don't know whether they are zulu time or local (+2). I might have screwed up the logging/resetting process since the log shows nothing about the integration restarting.
home-assistant_solaredge_modbus_multi_2024-04-21T09-35-53.544Z.log
024-04-21 11:33:46.248 DEBUG (MainThread) [custom_components.solaredge_modbus_multi.hub] I1B1: B_Export_Energy_WH 0xa6b <class 'int'> 2024-04-21 11:33:46.248 DEBUG (MainThread) [custom_components.solaredge_modbus_multi.hub] I1B1: B_Import_Energy_WH 0xe72 <class 'int'>

So first off, all I'm really doing here is proving this is not a bug in the integration: the integration just takes values the inverter gives, does some validation and checks for obviously wrong or invalid states that would mess up graphs/statistics, and passes them into Home Assistant.
The SolarEdge app and monitoring platform is completely separate from modbus. If one of those works and the other doesn't, that's a bug in the inverter firmware that SolarEdge would need to fix. This integration can only use the data the inverter gives it over modbus. If the inverter keeps returning the same data every time it asks without increasing the values, that's an inverter bug and unfortunately there's nothing I can do about it except show you how it's not my problem to fix.
You could try power cycling your entire system to cold boot it (turn off all AC and DC safety switches) to see if that re-syncs everything. That's been reported as a solution in the past and is mentioned in known issues.
Battery energy sensors going unavailable can be several things which are already documented in known issues:
https://github.com/WillCodeForCats/solaredge-modbus-multi/wiki/Known-Issues
If you have battery energy going unavailable you probably have the "backwards" data issue and need to turn on some of the options that are designed to allow that. Home Assistant expects that energy meters should not go backwards, so if they do the sensors will go into unavailable state.

hi,i am running an original SolarEdge battery so it seems to be either something different or they have this problem with their own batteries now.

Correspond well with the battery sensor death, although i don't know whether they are zulu time or local (+2). I might have screwed up the logging/resetting process since the log shows nothing about the integration restarting. It also starts timestamping after my screenshot. Do i need to download the log before restarting?

Yes because logs are cleared when Home Assistant restarts.

I restarted the integration only, there was no new boot info in the log.

I'm not really seeing anything here that suggests a problem with the integration.
I don't have batteries on my system, so I can't give any advice on them.


Latest 4.0.0 alpha breaks with babel

If you are reporting a bug or requesting support, start here:
Bug or support request summary
Latest 4.0.0 alpha breaks because yup has a dependency on a different pre-release version of @babel.
https://github.com/jquense/yup/blob/master/package.json#L88
https://github.com/storybooks/storybook/blob/master/package.json#L76
Now that babel 7 is officially released, it seems like it would make sense to coordinate with @jquense to update both packages to stable babel
Steps to reproduce
Please provide necessary steps for reproduction of this issue. Describe the exact steps a maintainer has to take to make the problem occur. If the problem is non-trivial to reproduce, please link a repository or provide some code snippets.
(A screencast can be useful for visual bugs, but it is not a substitute for a textual description.)
Please specify which version of Storybook and optionally any affected addons that you're running

@storybook/react 4.0.0-alpha.18

Screenshots / Screencast / Code Snippets (Optional)
ERROR in ./node_modules/yup/lib/util/createValidation.js
Module not found: Error: Can't resolve '@babel/runtime/helpers/builtin/objectWithoutProperties' in '/Users/kastens/Sites/kepler/haven/node_modules/yup/lib/util'
 @ ./node_modules/yup/lib/util/createValidation.js 8:55-120
 @ ./node_modules/yup/lib/mixed.js
 @ ./node_modules/yup/lib/index.js
 @ ./src/screens/account/profile.tsx
 @ ./stories/screens/account.tsx
 @ ./stories/screens sync \.tsx$
 @ ./stories/index.stories.tsx
 @ ./stories sync .stories.tsx$
 @ ./.storybook/config.js
 @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/config.js (webpack)-hot-middleware/client.js?reload=true

+1. Had to roll back to alpha-16 to make this work.
ERR! Failed to build the storybook ERR! ./.storybook/addons.js ERR! Module build failed (from ./node_modules/babel-loader/lib/index.js): ERR! ReferenceError: [BABEL] /Users/bill/Projects/wombo/.storybook/addons.js: Unknown option: /Users/bill/Projects/wombo/node_modules/react/index.js.Children. Check out http://babeljs.io/docs/usage/options/ for more information about options. ERR!  ERR! A common cause of this error is the presence of a configuration options object without the corresponding preset name. Example: ERR!  ERR! Invalid: ERR!   { presets: [{option: value}] }ERR! Valid: ERR!  { presets: [['presetName', {option: value}]] }ERR!  ERR! For more detailed information on preset configuration, please see https://babeljs.io/docs/en/plugins#pluginpresets-options. (While processing preset: "/Users/bill/Projects/wombo/node_modules/react/index.js") ERR!     at Logger.error (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/logger.js:41:11) ERR!     at OptionManager.mergeOptions (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:226:20) ERR!     at /Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:265:14 ERR!     at /Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:323:22 ERR!     at Array.map (<anonymous>) ERR!     at OptionManager.resolvePresets (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:275:20) ERR!     at OptionManager.mergePresets (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:264:10) ERR!     at OptionManager.mergeOptions (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:249:14) ERR!     at OptionManager.init (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:368:12) ERR!     at File.initOptions (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/index.js:212:65) ERR!     at new File (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/index.js:135:24) ERR!     at Pipeline.transform (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/pipeline.js:46:16) ERR!     at transpile (/Users/bill/Projects/wombo/node_modules/babel-loader/lib/index.js:50:20) ERR!     at /Users/bill/Projects/wombo/node_modules/babel-loader/lib/fs-cache.js:118:18 ERR!     at ReadFileContext.callback (/Users/bill/Projects/wombo/node_modules/babel-loader/lib/fs-cache.js:31:21) ERR!     at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:242:13) ERR!  @ multi ./.storybook/addons.js<EMAIL_ADDRESS><EMAIL_ADDRESS>manager[0] ERR! ./.storybook/config.js ERR! Module build failed (from ./node_modules/babel-loader/lib/index.js): ERR! ReferenceError: [BABEL] /Users/bill/Projects/wombo/.storybook/config.js: Unknown option: /Users/bill/Projects/wombo/node_modules/react/index.js.Children. Check out http://babeljs.io/docs/usage/options/ for more information about options. ERR!  ERR! A common cause of this error is the presence of a configuration options object without the corresponding preset name. Example: ERR!  ERR! Invalid: ERR!  { presets: [{option: value}] }ERR! Valid: ERR!  { presets: [['presetName', {option: value}]] } ERR!  ERR! For more detailed information on preset configuration, please see https://babeljs.io/docs/en/plugins#pluginpresets-options. (While processing preset: "/Users/bill/Projects/wombo/node_modules/react/index.js") ERR!     at Logger.error (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/logger.js:41:11) ERR!     at OptionManager.mergeOptions (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:226:20) ERR!     at /Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:265:14 ERR!     at /Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:323:22 ERR!     at Array.map (<anonymous>) ERR!     at OptionManager.resolvePresets (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:275:20) ERR!     at OptionManager.mergePresets (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:264:10) ERR!     at OptionManager.mergeOptions (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:249:14) ERR!     at OptionManager.init (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/options/option-manager.js:368:12) ERR!     at File.initOptions (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/index.js:212:65) ERR!     at new File (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/file/index.js:135:24) ERR!     at Pipeline.transform (/Users/bill/Projects/wombo/node_modules/babel-core/lib/transformation/pipeline.js:46:16) ERR!     at transpile (/Users/bill/Projects/wombo/node_modules/babel-loader/lib/index.js:50:20) ERR!     at /Users/bill/Projects/wombo/node_modules/babel-loader/lib/fs-cache.js:118:18 ERR!     at ReadFileContext.callback (/Users/bill/Projects/wombo/node_modules/babel-loader/lib/fs-cache.js:31:21) ERR!     at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:242:13) ERR!  @ multi<EMAIL_ADDRESS><EMAIL_ADDRESS>./.storybook/config.js iframe[2] info Building storybook completed. error Command failed with exit code 1.

not sure how i'm involved but there is a new version of yup out now :P

😆 I made a mistake.. Doesn't actually seem like I have an issue here with storybooks. Updating yup fixed it for me.


Add support for functions polyfills for the requirement checker

The requirement checker currently extension based polyfills. In other words, if the project or a dependency requires a certain extension, when it is declared in their composer.json files like so:
{
    "require": {
         "ext-mcrypt": "*",
         "ext-mbstring": "*"
    }
}

The requirement checker will be able to pick those requirements. It also supports a range of polyfills. So with the example above, if phpseclib/mcrypt_compat is found in the installed dependencies (not as a dev dependency), the extension mcrypt will actually not be required. Likewise, if symfony/polyfill-mbstring is found, it will not require ext-mbstring.
However no function support is currently provided. For example if the project requires the Intl grapheme_* functions, there is no way to tell the requirement checker that those functions are required and that they are not if the symfony/polyfill-intl-grapheme package is installed

@MacFJA if you have any idea of how it could be implemented, I'm all ears. Otherwise I'm for closing this as I'm not sure it's actually possible...

I'm working on it.
I should be able to have something to show soon

Here the solution that I came up: https://github.com/MacFJA/polyfill-registry
I still need to make some work (add a README, add examples, add to packagist, etc.) but it should work.
To summarize, the code will be something like:
$registry = new PolyfillRegistry();
// ...
$polyfilledExtensions = [];
foreach ($packages as $packageInfo) {
    $polyfilledExtensions = array_merge($polyfilledExtensions, $registry->getPolyfillExtensions($packageInfo['name']));
}
$polyfilledExtensions = array_filter(array_unique($polyfilledExtensions));
$polyfilledExtensions = array_fill_keys(array_values(polyfilledExtensions), true);

The huge drawback of my solution is the list of polyfill to keep up to date

The huge drawback of my solution is the list of polyfill to keep up to date

Not so much of drawback since it's the same for what is currently done in Box. Maybe a small difference is that right now Box supports some come to be polyfills since it relies on a package name pattern for the Symfony polyfills.
So there's still two things I'm wondering:

Is declaring all the functions necessary? There is some polyfills covering only a few functions of an extension as opposed to the whole extension and this is where it's necessary. But otherwise maybe you could omit it which would lower the maintenance work on your end.

How does one declares that his application requires those functions which are either provided by an extension or polyfills? And actually when is it needed (I realise I struggle to find a real case scenario)?

In any case I think having a polyfill registry would be a good idea. I would just suggest to support some "pattern based" polyfills like for the Symfony ones to reduce the work.

How does one declares that his application requires those functions which are either provided by an extension or polyfills? And actually when is it needed (I realise I struggle to find a real case scenario)?

A tool like PhpCodeAnalyser can found functions/constants/classes of extensions used.
(I'm planning to integrated it into phpqa, maybe I can make it usable as a lib and not only as a CLI)

Is declaring all the functions necessary? There is some polyfills covering only a few functions of an extension as opposed to the whole extension and this is where it's necessary. But otherwise maybe you could omit it which would lower the maintenance work on your end.

As I design the tool to work in both way (find a polyfill for an extension and find extensions of a polyfill), I need to have a relativily precise dataset.
For the maintenance cost I planning to create some helper tools to make most of the work

Sorry I may not have been clear enough for the second point. Here's the scenarios I can think of:

The application depends on some extension functions but has a fallback. For example psysh has a soft dependency on ext-pcntl. However it won't ever get checked by the requirement checker since at no point the app says "I require the extension pcntl".

The application depends on a certain extension, e.g. mbstring, but it has a polyfill symfony/polyfill-mbstring: the requirement checker supports it so there is nothing more to do.

The application execute third-party code and requires that third-party code to have an extension e.g. mbstring. In that case, it's a different level of complexity since it entirely depends on how the application loads that third-party code. In which case I would argue it's not the responsibility of the requirement-checker to check that. If anything eventually, what would be missing on Box end is to allow the application the run without bailing out because the mbstring extension is missing (right now you could only disable the requirement checker entirely)

The application depends on some extension functions but has a fallback. For example psysh has a soft dependency on ext-pcntl. However it won't ever get checked by the requirement checker since at no point the app says "I require the extension pcntl".

For the case of psysh we have an indirect requirement as the composer.json (and lock) have a suggest section where to specify those soft dependency. The requirement checker can warn the user (to indicate that some features can be missing) about those extension if no polyfill exists but as there are soft dependency they should, in theory, works without them. And, IMO, the requirement checker mustn't be blocked by them.

The application execute third-party code and requires that third-party code to have an extension e.g. mbstring. In that case, it's a different level of complexity since it entirely depends on how the application loads that third-party code. In which case I would argue it's not the responsibility of the requirement-checker to check that. If anything eventually, what would be missing on Box end is to allow the application the run without bailing out because the mbstring extension is missing (right now you could only disable the requirement checker entirely)

The composer.lock is a flatted version of all composer.json, so required extensions of third-party code should appear in it (as well as the suggest section). Also, when Composer do its dependency resolution, this case is handled: Composer check all dependencies requirements (from root package level to the deepest dependency)

I think relying on the suggest is harder:

It can be anything, not necessarily a soft dependency
In the case of psysh for example, it actually includes those suggest at build time to provide a PHAR with all the suggested polyfills (and I think that's how it should be done)

So I don't think there is anything else to do here.

The composer.lock is a flatted version of all composer.json, so required extensions of third-party code should appear in it (as well as the suggest section). Also, when Composer do its dependency resolution, this case is handled: Composer check all dependencies requirements (from root package level to the deepest dependency)

Sure but how can you know that the application needs to load third-party code and how it should do it? You could very well have:
$ acme.phar scan project # Loads the code
$ acme.phar fix file # does not load the code

So making any assumption here looks very brittle

Bump on the issue.

However no function support is currently provided. For example if the project requires the Intl grapheme_* functions, there is no way to tell the requirement checker that those functions are required and that they are not if the symfony/polyfill-intl-grapheme package is installed

I think it's actually not an issue per se since there is no way to tell Composer you have a dependency on grapheme_* functions...
@MacFJA unless I'm missing something, I think we can close the issue for now. I still think the idea of a polyfill registry is a good one but maybe we don't need to keep track of the functions.


Sending only one time request for each piece

currently we just sending request like a blind program that don't aware it already HAVE the piece in it's buffer.

#16 should solve that


Increased image resolution for links (facebook)

The option media_min_width is available. The picture attributes returns an image with a max width of 130px. So when media_min_width exceeds 130 retrieve full_picture, else picture.


Update nginx config for dev

We are providing a base nginx conf for dev setup. This is causing false positives in tests where the nginx package get's updated and we don't test with the base nginx.conf.
Remove nginx.conf.template + the setup that happens in dev mode. We should always be relying / running on what we ship with for consistency.

As a follow-up, a package bump enabled a 404 error page, which broke our http -> https redirect.


margin done

Because

This PR

Issue

Closes #XXXXX
Additional Information

Pull Request Requirements

[ ] I have thoroughly read and understand The Odin Project Contributing Guide
[ ] The title of this PR follows the location of change: brief description of change format, e.g. 01-flex-center: Update self check
[ ] The Because section summarizes the reason for this PR
[ ] The This PR section has a bullet point list describing the changes in this PR
[ ] If this PR addresses an open issue, it is linked in the Issue section
[ ] If applicable, I have ensured that the TOP solution files match the Desired Outcome image

problem solved

We do not accept PRs for user solutions in our exercise repos so I'll be closing this. In the future please refrain from opening such PRs.


Refine ubuntu installation mirror directory

when the ubuntu installation's payload's mirror directory is '/mirrors/ubuntu' not '/ubuntu' like  "repo": "http://<IP_ADDRESS>:9080/mirrors/ubuntu"  ubuntu os installation workflow cannot work. refine it to be compatible with ubuntu mirror directory like  '/mirrors/ubuntu'
@RackHD/corecommitters @WangWinson @pengz1

Coverage remained the same at 91.152% when pulling ae7648130e6477d3783b3d1278e3314e9748fcec on anhou:enhancement/ubuntu-repo into 878482f0ab8adcdb05d681e3cbbf9a06d94e737b on RackHD:master.

Coverage decreased (-0.02%) to 91.13% when pulling ae7648130e6477d3783b3d1278e3314e9748fcec on anhou:enhancement/ubuntu-repo into 878482f0ab8adcdb05d681e3cbbf9a06d94e737b on RackHD:master.

:+1: after CI pass

:+1:

Maybe I'm misunderstanding what's happening here, but wouldn't it be better to just make these task definition variables that could or could not reference each other? Putting regex replacement logic into the template itself seems like something that could be very hard to debug in the future should problems/variations arise.

@benbp I had considered breaking repo url to repoHostname and repoDirectory for all OS in install-os task definiton, but I think this is a special case for Ubuntu, and this way is not straightforward compared with a repo url from user perspective. and let repoHostname, repoDirectory to be handled in template, not in install-os.js is intented to make ubuntu repo handling independent.  and regex is also simple, each of them is one line javascript code. If it hadmore logic, I also intended to move them to install-os.js.

Thanks @anhou. Yep, makes sense to me, normalizing the task definition. I imagine @yyscamper's proposal/work to allow for different schema's will alleviate issues like this going forward.


Playback resolution setting

Hello,
I want to know how do I use "100%" value as resolution setting.
Currently, I'm using "640x360" as player resolution.
It looks like good in my laptop side but if I access via my smartphone, then the playback area is protruded.
The webpage is below.
http://thinkourfuture.ddns.net/wowza/wowza5/

Hi, @Tkamiya.
Clappr supports setting "100%" to its dimensions. You just need to embed the player using:
var player = new Clappr.Player({
  // ...
  width: "100%",
  height: "100%"
})

The only restriction is that you have to set the parent element dimensions. Otherwise the player will always compute its size to 0x0.
I checked the webpage you mentioned, and the parent element (<div id="player">) has no explicit size. It currently computes to 660x360 because it contains the player, which in turn has an intrinsic size. If you change the player to occupy 100% of the parent space, you'll have to add explicit dimensions to the parent element, like:
#player {
  width: 660px;
  height: 360px;
}

Please let me know if this works for you.

Hi towerz,
Thank you for your information.
I added your information to parent element.
I can see it works properly on my laptop.
But if I access via my smartphone, then player is still protruded like attached picture file.
You can see the red selected area in this picture file.

I expect that the player resolution is changed automatically by each devices.

@Tkamiya it seems you have changed the player container correctly, but your responsive style is not resizing it to the right size.
I ran the chrome inspector simulating a Nexus 5X, and the player container is sized to 660x360, instead of being resized to fit the viewport width (411px in my test).

Try adding responsive rules to the style of the #player element.


Question: Can we make it work with the Composition API?

Question: Can we make it work with the Composition API?
I have tested version 0.1.6 with my newly created app, and it works well with a test store -- Options API. The stores I have in the app use Pinia's Composition API. Can we update your plugin to support that API?

It's made for Composition API


Not working with nested <Routes>

If I render a component with nested <Routes> the story doesn't render.
example:
https://stackblitz.com/edit/react-ts-miwcgv?file=App.tsx

Can you try version 0.1.13 and tell me if it works?

@JesusTheHun nope, that doesn't work.

I think the issue is here: https://github.com/JesusTheHun/storybook-addon-react-router-v6/blob/main/src/components/StoryRouter.tsx#L20
the path is generated, but there's no way to modify the root route path. the entry needs to point to /:id/:subId where the root route needs to point /* and there's no way to currently specify both

You can wrap things in your story template :
export default {
    title: 'Example/Repro',
    component: ListingDetailPage,
    decorators: [withRouter],
};

const Template = (args) => (
    <Routes>
        <Route index element={<Link to="/1">Goto Id</Link>} />
        <Route path=":id/*" element={<ListingDetailPage />} />
    </Routes>
);

export const Default = Template.bind({});
Default.parameters = {
    reactRouter: {
        routePath: '*',
    }
}

@JesusTheHun that wouldn't render the ListingDetailPage directly

Quick update : I'm currently working on this feature. ETA : this week

@lifeiscontent I've published version 0.2.1 which includes support for descendant routes.
Can you give it a try ? I've added some instructions in the readme ;)
It took some time because I wanted to still be able to provides route params for descendant routes, something that react router does not provide so I had to hackaround. Check the new routeMatches property in the log panel.
Let me know if you face any difficulties or have any question.

@JesusTheHun almost! using the /* renders the page, but :subId is not defined in params, instead it has the correct value but the param is * instead of :subId

also, not sure if its helpful, but its common to publish .rc releases for features that are in flux, not sure if you knew about rc releases, but just wanted to call it out in case you didn't / find it useful.

Thanks for your feedback.
Do you think routeMatches is confusing ? Shall I make the routeParams display the params of all routes instead of using the routeMatches property ? Because right now the routeParams only show the params of the route declared at routePath. So this change would unify the behaviour ; maybe we don't make it an array if there is only one matching route.
// this version would display all params available inside the route's element
routeParams = [
  '/listing/*': { *: '1/1' },
  '/:id': { id: 1 },
  '/:subId': { id: 1, subId: 1 },
]

// display only additional params
routeParams = [
  '/listing/*': { *: '1/1' },
  '/:id': { id: 1 },
  '/:subId': { subId: 1 },
]

// we try to be smart (dangerous)
routeParams = [
  // '/listing/*': { *: '1/1' }, # we detect no dynamic param and a wildcard so we don't show this entry
  '/:id': { id: 1 },
  '/:subId': { subId: 1 },
]


MSID: 102417 Version: 1 DOI: 10.1101/2<IP_ADDRESS>9711

MSID: 102417
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>9711
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=102417
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>9711

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/102417v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>9711
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/102417/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

WOS query sent

OK to proceed


Login Page responsive

Title and Issue number
Title : Login Page responsive
Issue No. : #1314
Close #1314
Description
Made the Login Page responsive
Video/Screenshots (mandatory)
https://github.com/user-attachments/assets/c7d89c56-56eb-4fc4-823b-32457886f7e1
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist:

[X] I have performed a self-review of my code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have tested the changes thoroughly before submitting this pull request.
[X]  I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have gone through the  contributing.md file before contributing

##Are you contributing under any Open-source programme?

[X] I am contributing under GSSOC'24
[ ] I am contributing under VSOC'24

@apu52 ,
Please review this PR. Thank You!

Hey @TBorundia, on which login page you have implemented the responsiveness?


sieve  is not best match on 13gen cpu?

i got a intel 13700K,
i run primesieve 1e12, without other paramets it take ~ 11.7sec,
but when i add -s32, it take only ~9.9sec

Yes, you are right.
However, it is simply very difficult to know the best sieve size for every CPU (see here: https://github.com/kimwalisch/primesieve/blob/master/src/api.cpp#L149 and here: https://github.com/kimwalisch/primesieve/blob/master/src/Erat.cpp#L101). What primesieve does is use a CPU sieve array size that works well across all different CPU types. The current setting is e.g. optimal for AMD CPUs and Apple CPUs, for Intel CPUs it also optimal but only when using a single thread.
The L2 cache of current Intel CPUs has multi-threading performance issues. I think that Intel will eventually fix those issues in a future CPU generation at which point the current primesieve settings should perform best.

Something to try is factoring out the hyper-threads on the p-cores. Unable to verify, I'm not sure which CPU IDs are the performance cores ([0-7] or [0,2,4,6,8,10,12,14]), the hyper-threads ([8-15] or [1,3,5,7,9,11,13,15]). The e-cores are likely [16-23].
On Linux, one can apply CPU affinity using the taskset utility. Below is an attempt to factor out the hyper-threads. One of these will run faster [0-7] or [0,2,4,...] for determining the physical core CPU IDs.
taskset -c 0-7,16-23 primesieve --threads=16 1e12
taskset -c 0-7,16-23 primesieve --threads=16 -s32 1e12

taskset -c 0,2,4,6,8,10,12,14,16-23 primesieve --threads=16 1e12
taskset -c 0,2,4,6,8,10,12,14,16-23 primesieve --threads=16 -s32 1e12

Similarly, one can run primesieve on the p-cores only or e-cores.
# run on p-cores + hyper-threads
taskset -c 0-15 primesieve --threads=16 1e12

# run on p-cores excluding hyper-threads
# select the one that ran fastest above [0-7] or [0,2,4,...]
taskset -c 0-7 primesieve --threads=8 1e12
taskset -c 0,2,4,6,8,10,12,14 primesieve --threads=8 1e12

# run on e-cores only
taskset -c 16-23 primesieve --threads=8 1e12


Remove batch of rows from a MutableObservable2DArray section

Hello. I'm very new to Bond and I'm wondering if there is an easy way to remove all rows from a MutableObservable2DArray section? I tried writing my own function as an extension, but it crashes with "Index out of bounds" after 5 iterations (in a section with 7 items). I'd like to keep the section in my datasource (as I'd always like to display the header), while dynamically adding or removing a batch of rows.
extension MutableObservable2DArray {

    func removeRowsIn(sectionIndex: Int) {
        guard let section = sections[safe: sectionIndex] else { return }
        batchUpdate { dataSource in
            section
                .items
                .enumerated()
                .map { IndexPath(row: $0.0, section: sectionIndex) }
                .forEach {
                    dataSource.removeItem(at: $0)
            }
        }
    }
}

Whenever you remove an item, all items that follow are shifted one place left so eventually you'll try to remove item at non-existing index path. Therefore, you have to delete items in reverse order. If you do reversed() just before forEach, I think it should work.
Anyway, it a helpful feature, so let's plan it as an enhancement :)

Awesome! Thanks for the help.


Broadcast not in scope during loop

The following code fails verification because the broadcast use is somehow not in scope during the loop.
pub spec fn map_contains_key_opaque<Key, Value>(m: Map<Key, Value>, k: Key) -> bool;

pub broadcast proof fn axiom_map_contains_key_opaque<Key, Value>(m: Map<Key, Value>, k: Key)
    ensures
        #[trigger] map_contains_key_opaque::<Key, Value>(m, k) <==> m.contains_key(k)
{
    admit();
}

fn test_axiom(m: Map<u64, u32>, k: u64)
    requires
        map_contains_key_opaque(m, k)
{
    broadcast use axiom_map_contains_key_opaque;
    for i in 0..10
        invariant
            map_contains_key_opaque(m, k)
    {
        assert(m.contains_key(k)) by {
//            broadcast use axiom_map_contains_key_opaque; // <== needs this to verify
        }
    }
}

@Chris-Hawblitzel I can also take a look at this if you'd like.


Action "AnomalyScoring" for an override on a managed rule supported in Azure Portal but not CLI

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az network front-door waf-policy managed-rules override add
Errors:
az network front-door waf-policy managed-rules override add: 'AnomalyScoring' is not a valid value for '--action'. Allowed values: Allow, Block, Log, Redirect.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Use action of "AnomalyScoring" for az network front-door waf-policy managed-rules override add
az network front-door waf-policy managed-rules override add --policy-name {} --resource-group {} --type {} --rule-group-id {} --rule-id {} --action AnomalyScoring --disabled {}

Expected Behavior
Should set the action for a rule to AnomalyScoring.
As a side note, if I set the action in the Azure Portal, the Azure CLI will correctly show "action": "AnomalyScoring" when I do a az network front-door waf-policy managed-rules override list. The CLI just does not let me set this value. (unlike the Azure Portal)
Environment Summary
Windows-10-10.0.19044-SP0
Python 3.10.5
Installer: MSI

azure-cli 2.41.0

Extensions:
application-insights 0.1.16
cosmosdb-preview 0.19.0
datafactory 0.6.0
front-door 1.0.16

Dependencies:
msal 1.20.0b1
azure-mgmt-resource 21.1.0b1

Additional Context

route to CXP team

@vhhughes Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

The enum values Allow, Block, Log, Redirect for --action  parameter seem to be taken from the auto-generated code here:
https://github.com/Azure/azure-cli-extensions/blob/main/src/front-door/azext_front_door/vendored_sdks/models/_front_door_management_client_enums.py#L29
We are looking into this further. We will keep you updated.


Problems with OBI "processed material"

class: OBI:0000047
name: processed material
def: "Is a material entity that is created or changed during material processing." []
equivalent_to: BFO:0000040 ! material entity
  and
  OBI:0000312 ! is_specified_output_of
  some OBI:0000094 ! material processing

material processing is defined as A planned process which results in physical changes in a specified input material
= achieves_planned_objective some 'material transformation objective'
which is itself defined as an objective specifiction[sic] that creates an specific output object from input materials.
This doesn't specify what an input material is, neither does the def of objective specification.

The label for OBI:0000047 is misleading. "material" sounds like a mass noun rather than an object. It is odd to think of the Empire State Building as "material", yet I think it is intended to classify here. If this the intent the label should be "processed material entity"?
This is an injector class, it claims a broad variety of subclasses from multiple ontologies with different scopes, as such I think this is (inadvertently) violating https://obofoundry.org/principles/fp-005-delineated-content.html
It is inconsistently applied (inevitable, for an injector class). For example, we would expect to see the following under it:

IAO: photographic print
random access memory
guar gum
manufactured

Or maybe I'm wrong and processed material should only be used for materials in the sense of substances, but there needs to be more guidance in what is included and what is excluded
UPDATE I did not need to write so much, COB already uses the label "processed material entity" signaling intent. I think for now if OBI updates the label to sync with COB that is sufficient to close this issue for now, and we can take everything else to the COB tracker

Should partially be addressed when we do the COB merge in #1671


updated to work with flask 2.2+

Replaced _request_ctx_stack.top with request_ctx per https://github.com/pallets/flask/pull/4682/files

@nickjj, hey, no, no errors, just the depreciation warning that in flask 2.3 the _request_ctx_stack will be removed.

Ah right.
This project currently has Flask >= 0.8 defined. I do like the idea of removing the deprecation warning by using the "new" way for Flask 2.3 but we should figure out a solution that still works for versions < 2.3. I think you could detect the version of Flask and import either one based on the version and use as to ensure the import name is the same for both so the usage can remain as req = request_ctx.request.
What do you think?

Yeah, that's an idea. From the flask PR, they said this was existing all along, but I'm not sure what version of flask it was really added.
We could something like this:
int(flask.version.split(".")[0]) < 2 and int(flask.version.split(".")[1]) < 2
Probably there is a cleaner way?

I didn't fully test this but, but if you put this into a Python interpreter it works:
import flask

from packaging import version

version.parse(flask.__version__) >= version.parse("2.2.0")

That condition is what you could do to require a specific package from Flask.

How this look @nickjj ?
The tests run fine w/ tox, but not the stylecheck. It looks like the tox file needs updated?

I filed https://github.com/flask-debugtoolbar/flask-debugtoolbar/issues/184 to track bumping our version of Flask... I'm very open to doing so if /when we need it. But as @nickjj pointed out here, for this PR checking the version is a clean-backwards compatible method, so def the right way to go here.

I'm generally ok with it as a concept. I'm not loving repeating that version check twice but this also feels like a spot where if it were refactored and made into a general version compare function it might make things less readable in the end.
Do you want to wait for the author of the PR to potentially remove that 1 empty line before merging it @jeffwidman?

Thanks again!


har_extractor.py usage example

I don't know if I'm just looking in the wrong place, but I've been trying to convert a flow to a har for hours and am hitting road block after road block (largely due to python acquisition/package management). Now I have everything in place and I still don't really have any idea how to "use" har_extractor.py.

If I figure it out, I'll send a PR adding some notes somewhere...

So, it was me looking in the wrong place. I needed to be looking at the mitmdump documentation. I thought the script was loaded into mitmproxy.
This was the relevant page, in case someone winds up here via Google in the future:
http://mitmproxy.org/doc/mitmdump.html
Full instructions:
apt-get update
apt-get install python-pip mitmproxy
pip install setuptools
pip install harparser
wget https://raw.githubusercontent.com/mitmproxy/mitmproxy/master/examples/har_extractor.py
mitmdump -ns "har_extractor.py bugreport.har" -r ./bugreport.flow

Sorry for the confusion :-/
What did you try to install stuff and how did it fail?
pip install mitmproxy[examples] should install everything that is needed, so we may just need to document that better.
You should be able to use the har_extractor like so:
mitmdump -n -r dumpfile -s "har_extractor.py harfile.har"

Ah, happy to hear that things cleared up - if you happen to struggle with something like that again, please don't refrain and ask on Slack. :relaxed:

Hehe, thanks Maximilian. I will definitely keep Slack in mind. Cheers.

Mitmproxy with this functionality is exactly what I have been looking for! However, I can't get it to work:
$> mitmdump -n -r dumpfile -s "har_extractor.py harfile.har"
mitmdump: No such file: har_extractor.py harfile.har
$> mitmdump -n -r dumpfile -s har_extractor.py harfile.har
mitmdump: Error in script start:

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/libmproxy/script.py", line 51, in run
    return (True, f(self.ctx, *args, **kwargs))
TypeError: start() takes exactly 2 arguments (1 given)

mitmproxy version is 0.9.2-2 from Ubuntu 14.04. (Latest mitmproxy installed via pip fails with mitmdump)
Am I doing something wrong?

I have error

Script error: TypeError: done() takes exactly 1 argument (0 given) -

cmd : mitmdump -n -r test.dump  -s "har_extractor.py test.har"

For anyone reading this, as for mitmproxy version 6.0.2, this worked for me:
mitmdump -n -r test.dump -s har_dump.py --set hardump=test.har

You can find har_dump.py on a Linux installation in this directory: /usr/share/doc/mitmproxy/examples/complex, or just get it here: https://github.com/mitmproxy/mitmproxy/blob/master/examples/contrib/har_dump.py


HDDS-10987. Add explicit dependency for hadoop-auth

What changes were proposed in this pull request?
Ozone server components use code from hadoop-auth, e.g. org.apache.hadoop.security.authentication.client.AuthenticationException.  However, dependency on hadoop-auth is only transitive via hadoop-common.  We should add explicit dependency.
https://issues.apache.org/jira/browse/HDDS-10987
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/9421451719

Thanks @hemantk-12 for the review.

Thanks @swamirishi for the review, too.

I had a doubt how do we check for other similar transitive dependency issues in the code base? As in figuring out if a particular dependency comes from transitive dependency or a direct dependency.

how do we check for other similar transitive dependency issues in the code base?

Maven Dependency Plugin can help with this.  I'll check and file some further tasks for this.


Whatever happened to TeaHouse?

Charting is awesome! :)

TeaHouse is a product by discretelogics to chart time series inside TeaFiles. It is not offered anymore.

What technology stack was it written on? Is it something you would consider open sourcing?


Untranslate of msgid "Create BitcoinZ Wallet"

Hi,
I'm french and when i change the language in 'BTCZ wallet' in Android v10.09 i'm going to see an untranslated text visible before having a wallet.
The message is always in english after change the language.

On 'i18n/po/template.pot' the text is :
msgid "Create BitcoinZ Wallet"
msgstr ""

#: www/views/tab-create-personal.html:131

but on 'i18n/po/fr.po' (and all other language) the text is :
msgid "Create bitcoin wallet"
msgstr "Créer un portefeuille bitcoin"

#: www/views/tab-create-personal.html:131

I think the msid "Create bitcoin wallet" is not correct in all .po' files.
It should be named : "Create BitcoinZ Wallet" in all '.po' files. (same as 'template.pot')
also the msgstr in :

'fr.po', "Créer un portefeuille bitcoin" should be replaced by "Créer un portefeuille BitcoinZ"
'it.po', "Creare portafoglio bitcoin" should be replaced by "Creare portafoglio BitcoinZ"
'ja.po', "ビットコインウォレット作成" should be replaced by "BitcoinZウォレットを作成する" ???
'nl.po', "Bitcoin portemonnee aanmaken" should be replaced by "BitcoinZ portemonnee aanmaken"
'pl.po', "Utwórz portfel bitcoin" should be replaced by "Utwórz portfel BitcoinZ"
'pt.po', "Criar carteira bitcoin" should be replaced by "Criar carteira BitcoinZ"
'ru.po', "Создать биткойн-кошелёк" should be replaced by "Создайте Биткойн-кошелек" ???
'zh.po', "创建比特币的钱包" should be replaced by "创建一个比特币钱包" ???

Best regards
gilardh

See pull requests #39

Merged! Thanks for your contribution!


Various Enhancements and features

Remove all scheduled tasks when a FCM token unregistered (i.e. app uninstalled or new token issued)
Use more caching and performance improvements
Add tests for testing the server under different loads (No end-to-end test though)
Improves exception handling
Re-enables the cancel functionality as required when timezone changes/ schedule re-generated in aRMT
Adds sound parameter to notification payload as some devices reported no sound on notification delivery
Also add server mode to the list of available scheduler options so as to allow concurrent access to the database (Can build a simple UI on top of it for checking notifications in the future)
Adds docker-compose file for the XMPP-server and database server and Dockerfile for building and running hsql database server

Looks great :+1 - these are nice improvements.
I was thinking perhaps a persisting the delivered schedule for a configurable length of time for schedule provenance

@afolarin Yes that can be done. will that be required when the server sends delivery info to kafka too ? (Since i have already started implementing that)

@yatharthranjan no it won't. Go ahead with the current implementation


Error with Wasserstein distance

When I try to use "wasserstein" distance I get the error: "Optimal transport problem was INFEASIBLE. Please check " "inputs.". What exactly should I check? How should the inputs be? If I use other distances like "euclidean" or "manhattan" I don't get any errors.

Might help if you posted a reproducible example (and verified the latest version still has this issue)

The most likely cause would be an all zeros vector. Problems are infeasible if there is no way to transport one probability distribution to the other. If one of the items can't be expressed as a distribution because it is all zero, so upon normalization ends up with NaNs, or has negative values, that would be ne way to be infeasible. Another option would be if the cost matrix has NaNs, of infs in it, that makes certain transportations impossible.


Improve the service-certificate test

Add checks for the TLS_DIR env var and the
certificate volume mount
This is to deal with issue #313

@leochr updated as requested


[0.5pt] Add footer - group task

Create footer according to the wireframe:

We are going to resolve this task as PAIR PROGRAMMING.


Fix documentation for callCC

Fixed: return -> pure
Added a type signature to setTimeout: If someone is trying to figure out what's going on here and they look up setTimeout on pursuit, they will find setTimeout :: Int -> Effect Unit -> Effect TimeoutId in js-timers, which does not work here at all. The added type signature shows we are intentionally using a simplified version of the function.

Thanks!


use rbac.authorization.k8s.io/v1 for ClusterRole/Bindings where k8s >…

…= 1.17

Fixed #516
Based on https://github.com/external-secrets/kubernetes-external-secrets/pull/581, but fixed tests.

Fixed #516
Based on https://github.com/external-secrets/kubernetes-external-secrets/pull/581, but fixed tests.

Thanks for your CR. Fixed.

Thanks for your CR. Fixed.


Can we do limit user per organisation?

How I can add limit users per organization? I mean when I am configuring new organization I want to add user limit.
Organisation A can add maximum X users.... and so on...

I don't think that's currently possible. Could you explain why you want this feature?

@Gittenburg
I am thinking to control user limit......plan wise.....for an organization.
If organisation requested plan A then the limit for the user will be X....If plan B then limit XX and so on....

Closing, as a billing system for a third-party chat service is out of scope for Zulip.


Add Central Cinema

https://www.central-cinema.com/calendar

Currently being handled by a third party site: https://www.goelevent.com/CentralCinema/e/List?s=&v=&t=1&st=null
So that URL is probably subject to change.

OK, I can crank the scrapers out pretty quickly at this point.


【Type：Feature】Super admin forces password change

about issue #4602
Make sure that:

[x] The backend supports the super administrator user to initialize password modification
[x] The backend supports reminders that the password of the super administrator user has not been modified for a long time.
[x] Features are configurable.

Codecov Report

Merging #4603 (b6262fb) into master (86a7379) will decrease coverage by 0.21%.
The diff coverage is 56.45%.

:exclamation: Current head b6262fb differs from pull request most recent head 785350b. Consider uploading reports for the commit 785350b to get more accurate results

@@             Coverage Diff              @@
##             master    #4603      +/-   ##
============================================
- Coverage     69.18%   68.98%   -0.21%
+ Complexity     7822     7821       -1
============================================
  Files          1037     1040       +3
  Lines         29901    29940      +39
  Branches       2726     2727       +1
============================================
- Hits          20686    20653      -33
- Misses         7595     7657      +62
- Partials       1620     1630      +10

Impacted Files
Coverage Δ

...enyu/admin/controller/DashboardUserController.java
71.87% <ø> (ø)

.../apache/shenyu/admin/model/vo/AlertTemplateVO.java
100.00% <ø> (ø)

...n/java/org/apache/shenyu/admin/model/vo/ApiVO.java
100.00% <ø> (ø)

...ava/org/apache/shenyu/admin/model/vo/DetailVO.java
68.65% <ø> (ø)

...java/org/apache/shenyu/admin/model/vo/FieldVO.java
72.83% <ø> (ø)

...a/org/apache/shenyu/admin/model/vo/MetaDataVO.java
74.64% <ø> (ø)

...che/shenyu/admin/model/vo/MockRequestRecordVO.java
86.73% <ø> (ø)

...apache/shenyu/admin/model/vo/PermissionMenuVO.java
48.97% <ø> (ø)

...a/org/apache/shenyu/admin/model/vo/RoleEditVO.java
20.00% <ø> (ø)

...spect/controller/SuperAdminPasswordSafeAdvice.java
17.39% <17.39%> (ø)

... and 5 more

... and 20 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


vpn connecting failure

the cloudflare check always fails

Is it just with a VPN or in general?
If it's in general, try changing the agent.
I changed mine to:
Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36
I confirm at the time of replying that this agent works.


CLOUDP-114248: Store all config files with mongocli folder

Proposed changes

Jira ticket: CLOUDP-114366

Checklist

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
[x] I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
[x] I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
[x] I have run make fmt and formatted my code

Further comments

While loading the config, if the file doesn't exist, check the old path~/.configand load the file copying to the new path ~/.config/mongocli/config.toml.
~Note: Still trying to figure out linux test failure - but sending for early review~
~Note: some evergreen files need to be updated to address this, but I want to run an e2e test without the change to see this solution working.~

CM tests are failing because of one of the changes in this PR https://evergreen.mongodb.com/task_log_raw/mongocli_master_e2e_cloud_manager_remote_cloud_manager_deploy_replica_set_e2e_patch_2911a9e4aba35f76cfa2ab03053c9510c83f47d1_62264cc20305b9056d333730_22_03_07_18_19_47/0?type=T#L47


toRdf produces a list of triples in reverse? order

The output should be in the same order as the input.

It's a feature of the algorithm. Overall, the RDF triples order does not matter.


[Error] Submitting an calling array to multicall contract, it seems reverts all that renders not to go further away

Error Statusquo

When submitting a call array in a multicall contract, even if just one of the arrays is reverted, the whole multicall gets reverted. This is the problem I'm trying to tackle.

[tokenAName, tokenADecimal, tokenBName, tokenBDecimal] = await multicall.aggregate([
  tokenAContract.methods.symbol(),
  tokenAContract.methods.decimals(),
  tokenBContract.methods.symbol(),
  tokenBContract.methods.decimals(),
]);

The error phenomenon is as follows when using require in solidity code,
Error: Returned error: evm: execution reverted
The following error occurs when require is removed.

Error: Returned values aren't valid, did it run Out of Gas? You might also see this error if you are not using the correct ABI for the contract you are retrieving data from, requesting data from a block number that does not exist, or querying a node which is not fully synced.

Workaround

it would be able to avoid the problem by using try-catch statement, since call returns false value to direct the code into catch condition.
Is there any proper way to solve the problem? The aformentioned approach seems a stopgap to me.

@jypthemiracle hey, please checkout https://github.com/HashEx/web3-multicall it has a workaround in contract for failed requests inside smart contract

@masquel hey, thanks for your kind reply. do not understand what the difference between call and staticcall - can you explain more? highly appreciated.

@jypthemiracle hey, please check out https://github.com/HashEx/web3-multicall it has a workaround for failed requests inside smart contract

Seems like the code is a copy paste of this repo without any giving any credits.

Error Statusquo

When submitting a call array in a multicall contract, even if just one of the arrays is reverted, the whole multicall gets reverted. This is the problem I'm trying to tackle.

[tokenAName, tokenADecimal, tokenBName, tokenBDecimal] = await multicall.aggregate([
  tokenAContract.methods.symbol(),
  tokenAContract.methods.decimals(),
  tokenBContract.methods.symbol(),
  tokenBContract.methods.decimals(),
]);

The error phenomenon is as follows when using require in solidity code,
Error: Returned error: evm: execution reverted
The following error occurs when require is removed.

Error: Returned values aren't valid, did it run Out of Gas? You might also see this error if you are not using the correct ABI for the contract you are retrieving data from, requesting data from a block number that does not exist, or querying a node which is not fully synced.

Workaround

it would be able to avoid the problem by using try-catch statement, since call returns false value to direct the code into catch condition.
Is there any proper way to solve the problem? The aformentioned approach seems a stopgap to me.

The contract would need to handle that internally

@witherblock now that repo is made like a fork from yours. Also we mentioned your library in our article - https://blog.hashex.org/multicall-analytex-approach-to-data-processing-978f81185db6
@jypthemiracle the workaround we used is contract doesn't require a success response during a call, but you need to handle it now by yourself. call function can change contract state, staticcall can't. So it's better to use staticcall in mulitcall if you plan only to read values, not to write.

Okay thanks, closing this issue.


Disable images in dataset?

It would be useful to have a way to somehow disable the images for a dataset. Having the images seems to drastically slow down the app at least for my relatively large dataset (images = 135). It’s possible to load a dataset without the images, so I want a way to turn them off to be able to use the app more quickly which includes uploading the dataset when I have not added or changed the images. Also, an option to upload the data without the images.

I know we changed how the datasets get downloaded from the server which only downloads the spots for each dataset automatically then allows the user to select if they want to download the images for those datasets.
We can look into the possibility of uploading datasets without images but keeping them in the project locally.


0.29.2 ViteNodeServer times out with experimentalOptimizer enabled

Describe the bug
Follow-up from #2932. The same error is thrown with much the same stack on 0.29.2:

Error: ViteNodeServer: /home/projects/vitejs-vite-j7gysr/node_modules/.vitest/deps/whatwg-fetch.js not found. This is a bug, please report it.
    at Timeout.eval [as _onTimeout] (file://file:///home/projects/vitejs-vite-j7gysr/node_modules/vite-node/dist/server.mjs:322:15)
    at listOnTimeout (https://vitejsvitej7gysr-xk1f.w-credentialless.staticblitz.com/blitz.fc57b779eff411414c7b91114df9b720faaf721b.js:6:306542)
    at processTimers (https://vitejsvitej7gysr-xk1f.w-credentialless.staticblitz.com/blitz.fc57b779eff411414c7b91114df9b720faaf721b.js:6:307365)
    at https://vitejsvitej7gysr-xk1f.w-credentialless.staticblitz.com/blitz.fc57b779eff411414c7b91114df9b720faaf721b.js:15:263678
    at https://vitejsvitej7gysr-xk1f.w-credentialless.staticblitz.com/blitz.fc57b779eff411414c7b91114df9b720faaf721b.js:15:263978

On Stackblitz, after the first error is thrown, the following appears:
fatal error: too many writes on closed pipe

goroutine 6 [running]:
runtime.throw({0x95c7a, 0x1e})
        runtime/panic.go:1047 +0x3 fp=0x838ee0 sp=0x838eb8 pc=0x122b0003
os.sigpipe()
        runtime/os_js.go:144 +0x2 fp=0x838ef8 sp=0x838ee0 pc=0x139b0002
os.epipecheck(...)
        os/file_unix.go:195
os.(*File).Write(0x80c020, {0x6600c00, 0x18c,

Reproduction
https://stackblitz.com/edit/vitejs-vite-j7gysr?file=package.json
System Info
System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 7.17.0 - /usr/local/bin/npm
  npmPackages:
    @vitejs/plugin-react: ^3.1.0 => 3.1.0
    vite: latest => 4.1.4
    vitest: ^0.29.2 => 0.29.2

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Vitest 0.31.4 changes how experimentalOptimizer works. Now Vitest only optimizes dependencies inside experimentalOptimizer.include (which can be populated by plugins), so this should no longer be a problem.


pageserver: improve readability of shard.rs

No functional changes, this is a comments/naming PR.
While merging sharding changes, some cleanup of the shard.rs types was deferred.
In this PR:

Rename is_zero to is_shard_zero to make clear that this method doesn't literally mean that the entire object is zeros, just that it refers to the 0th shard in a tenant.
Pull definitions of types to the top of shard.rs and add a big comment giving an overview of which type is for what.

Closes: https://github.com/neondatabase/neon/issues/6072
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

On a related note, I wonder why TenantShardId is in pageserver_api: TenantId is in the utils crate instead, same for TimelineId. In  #7322 I had to add a dependency on pageserver_api because of TenantShardId (it was already a transitive dependency, but still).

On a related note, I wonder why TenantShardId is in pageserver_api: TenantId is in the utils crate instead, same for TimelineId.

I wanted to avoid exposing all the shard.rs content to modules that don't really talk to pageservers, as it's kind of a concept that's "owned" by the pageserver (at least, until the safekeeper becomes shard aware).  In future it might be nice to define a crate for "foundational types" (or some better name) -- these ID types aren't really "utilities as such".


x/net/http2: Unhandled Setting: [MAX_HEADER_LIST_SIZE = 1048896]

The Go http2 server sends MAX_HEADER_LIST_SIZE in its initial SETTINGS frame, but the Transport doesn't use it.
Fix.
/cc @bmizerany

This isn't worth it for Go 1.6.
Similar to #14048 (validate transmitted header field names & values), this would involve making the Transport fail earlier before transmitting anything, telling the user that the server is likely to reject it. (except in #14048's case, the rejection is due to a spec violation, not an "advisory" soft limit, as this is).

This is tricky because it requires us to back up the hpack encoder state if we find out we wrote too much in encodeHeaders. I guess encodeHeaders needs to ask hpack.Encoder return a snapshot its state, then we write everything into the bytes.Buffer and count the size as we go. Or we need to do first pass of everything, just counting size[1], then another pass doing the encoding.
[1] Remember that this isn't about the hpack-encoded bytes size, but the Sum(EachField(len(key)+len(value)+32)-ish thing:

This advisory setting informs a peer of the maximum size of header list that the sender is prepared to accept, in octets. The value is based on the uncompressed size of header fields, including the length of the name and value in octets plus an overhead of 32 octets for each header field.

I'm demoting this to a Go1.7Maybe.

(I'm going away for a month. If anybody else wants to fix this before Jun 23rd, feel free.)

Is this issue still up for grabs?

Yes.

Ok, I'll have a look. My idea is to update (*ClientConn) encodeHeaders to implement your second suggestion from above, i.e., do a first pass counting bytes, then a second pass to write the headers. Does that sound reasonable?

Above comment refers to client-side only. Looking into the server side, I see there is a corresponding encodeHeaders function, but it seems there are also a few calls to encKV sprinkled throughout write.go. These additional calls to encKV are responsible for only a few tens of bytes I would guess, and at first glance it looks like they could all be shoehorned into encodeHeaders anyway.

I've mailed a changelist covering only the client portion in order to get feedback before I start on the server side (assuming we even want to handle this on the server).

/cc @tombergan

The client-side fix has been committed. Thanks @tombergan for reviewing.
It will be at least a month before I have a chance to look into the server-side (laptop dead, parts on the slow boat from China), so If anyone else wants to tackle it before then, feel free.