Add version type to Background, Border, BorderRadius, and Checkbox prop controllers

This is needed for server-side introspection.

@migueloller Two questions:

One main difference with the control is that we don't have separate data and value for prop-controllers. For example, for the CheckboxControl, we have CheckboxControlData and CheckboxControlValue. While on the CheckboxPropController we only have the CheckboxValue and not CheckboxData. I was thinking of introducing the data type, but I'm afraid it'll complicate things because we don't have a centralized place to turn the data into the value`.

I saw that we're importing prop-controller values from the control-serialization. As we're changing those, this shouldn't make a problem right? It's weird that we have old prop-controllers but not the new one.

⚠ No Changeset found
Latest commit: 14c7adf
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR

@fikrikarim, where's the changesets?

One main difference with the control is that we don't have separate data and value for prop-controllers. For example, for the CheckboxControl, we have CheckboxControlData and CheckboxControlValue. While on the CheckboxPropController we only have the CheckboxValue and not CheckboxData. I was thinking of introducing the data type, but I'm afraid it'll complicate things because we don't have a centralized place to turn the data into the value`.

We do have a centralized place to handle these things, the PropsValue component.

I saw that we're importing prop-controller values from the control-serialization. As we're changing those, this shouldn't make a problem right? It's weird that we have old prop-controllers but not the new one.

I'm not sure I understand this question. We still need to make sure the control and prop controller definitions are serializable. New controls are all serializable except for a couple like composable controls and advanced ones like Combobox which have functions in the definition. Older controls have stuff like hidden so most of them need to be serialized. This is related to definition serialization, not data serialization, though. So since all we should be doing is adding or bumping the version number in the definition, that shouldn't affect serialization. Which, by the way, I'm not seeing that in this MR, adding a version to the control so that the panels/overlays in the builder know to write in the latest data format.

Closing in favor of #711


vim nvH and nvL do not work correctly

VSCode Version: Code - Insiders 1.4.0-insider (fc167f86c1aee27951b7d4b4db51229f62d0a0ad, 2016-07-26T05:12:44.554Z)
OS Version: Linux x64 4.4.0-28-generic, Ubuntu 16.04

#9699
These do not seem to function correctly:

nvH Select till first non white space character of nth line from the top of the view
nvL Select till first non white space character of nth line from the bottom of the view

Both seem to select to outside the view.

This is dependent on the view port range computation in the editor. When a line is partially visible (wrapped), view port data some times containing the wrapped line of the line as starting line even though it is not visible.
This has to be fixed along with #9542.
Duplicates #9542


Manage externals via Carthage

Adds a Cartfile. This ensures transitive dependencies can be seen when using Madness via Carthage.

This resolves #71.

:bow: thank you kindly, @sharplet!


📘 DOC: Lint for broken links in all languages

Currently we have a yarn lint:linkcheck:local command that can check for broken links, but we don't have any way to switch what language you're using without JS, so it only checks the English pages.
I want to write a script using the programmatic version of blc to check all translations of the docs for broken links!

Sure @sarah11918, why not! I'll have a look 🙂

I've implemented it myself. See my PR above. The output looks like this:
/da/getting-started/
  ❌ https://docs.astro.build/quick-start
  ❌ https://docs.astro.build/installation
  ❌ https://docs.astro.build/reference/builtin-components

/de/core-concepts/component-hydration/
  🔗 https://docs.astro.build/de/core-concepts/component-hydration/#mycomponent-clientonly-

/de/core-concepts/routing/
  🔗 https://docs.astro.build/reference/api-reference#getstaticpaths

/de/getting-started/
  ❌ https://docs.astro.build/reference/builtin-components

[...]

*** Found 76 broken links.

When a link leads to a 404 page, the target href is prefixed by a ❌.
When the target page exists, but the link contains an URL hash that does not exist on that page, the prefix is 🔗.

@sarah11918 This issue can be closed now, my PR got merged. 🎉

YAY! 🥳


fix: custom migration e2e test

Description of changes

fixes e2e logic

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing


Configurable version in JaegerSpec

Should we provide a simple conf property to specify the version? Note that at the moment we allow overriding images for each individual component.
IIRC  p8s and etcd operators offers this.

@pavolloffay I'm looking to do just what you mentioned, override component version to use "latest" tag since I want to test this change from this morning https://github.com/jaegertracing/jaeger/pull/1473
and since the operator version is 1.11.1 it's pulling the images tagged at 1.11 right? this change currently  only in the latest tag, so in part, question on strategy: Production where should override the version for each component like jaeger-collector etc?

@jordo1138 You can follow the all-in-one-with-options.yaml example as reference. All components (collector, query, ...) support the image property.

I'm closing, as we've decided that the Operator will manage the underlying Jaeger version, based on its version (Operator v1.13 == Jaeger v.1.13). When the operator is updated to, say, 1.14, it will take care to bring all managed instances to the same version.


Django Channels layer messages

As discussed via email, I've made some changes to allow Django
Channels layer messages to be consumed from within Strawberry
subscription resolvers. The changes are fairly minimal, please refer
to the commit messages for some more details.

@LucidDan I've rebased my work against the upstream main branch, which is why there are so many reported conflicts. The rebase was very simple, if you rebase your branch those conflicts should (mostly) disappear.


Add init file for working like module.

Closes #26

This pull request is now managed with CodeReviewHub. Refresh.


Default values for ignore_scheduled_start_times

Review the default values for ignore_scheduled_start_times in the configuration files.

See my comment from 2019 at the related issue #81:

I found the reason: the deadlock occurs if the ignore_scheduled_start_times parameter is set to true and there are updates. I think we have never tested this constellation during the last two years. (We have benchmark Postgres with Interactive complex reads and BI reads - but never used updates.)
Setting ignore_scheduled_start_times to false works around the problem - but this flag is important for repeatability, see https://github.com/ldbc/ldbc_snb_driver/wiki/Introduction for details.

Scheduled Start Time: The wall clock time when an operation is due to be executed, i.e., when it is passed to the database connector. Explicitly assigning start times to operations is one of the techniques used by the driver that enable it to generate repeatable workloads.


fixed multiple bugs and consolidated in one script

I was getting an error
pair_with:5: command not found: pair_with_impl.sh
and it was failing other if checks.

Hi Ali,
I moved that into a separate file because that code doesn't work on zsh. My idea was to have a small universal script (needed because I need to do the export), and then have a bash file with the bulk of the work.
One way of fixing this would be to make pair_with universal, but I don't have the bash-fu to figure that out easily. Another would be to be more resilient to where the pair_with_impl.sh is located, or alternatively to keep it as a string and then bash -c it?

As a data point, I am using zsh and the new version works for me.

Talked to @AnilRedshift in person and it seems the other errors I fixed for the conditionals ([[ instead [) fixed the zsh problem and should work for bash. @AnilRedshift will try it for bash and if works well for him we might have a good solution.


perf: Infinite Scroll janky when used inside a nested ion-nav-view

Type: perf
Platform: android 4.4 webview
Anyone else encountered bad performance (high levels of jank) in the infinite scroller when used inside a nested ion-nav-view?
The issue resolved when I pulled the content outside of the named nested ion-nav-view.

Greetings @maverix!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

How is it nested? Could you demonstrate this in a codepen?

I narrowed it down further to just the presence of the ion-Nav-bar. If I
swap it for a ion-bar scrolling works as expected (nice and smooth).
I will get a repro together asap.
On Saturday, 23 May 2015, Perry Govier<EMAIL_ADDRESS>wrote:

How is it nested? Could you demonstrate this in a codepen?
—
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic/issues/3796#issuecomment-104740832.

--
This email has been sent to you...
I offer no guarantee that any attached documents are virus free – so at own
risk!
Love your guts!

Greetings @maverix!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


queue command returns no results if bot is not in voice channel

Rem does not display any queue items when she is not in a voice channel in the guild, even if there are items saved in the queue from the last session (within 4 hours).

smh lemme fix


Use schema 2 image for HostPid test.

Use schema 2 image which doesn't affect test result. :)
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

@Random-Liu Is this because containerd only supports schema 2 images?

LGTM

@Random-Liu Is this because containerd only supports schema 2 images?

Yeah, they'll support schema 1 soon, but not yet finished.


Changing username results in 404 errors

I recently changed my username, and I get 404 errors when I try to load anything.
I haven't looked at the github api, but there should be some endpoint to get the username of a given oauth token.
I would just log out and back in, but I can't seem to find where to log out (not sure if this is related).

You should build against our latest master. Meanwhile, we are trying to update the PlayStore version, as soon as possible.

Sam isn't using the play store version I don't think

Ah, my bad..
Are you doing similar with #819 ?

Yep, that's it. For some reason that issue didn't come up when I searched earlier. Feel free to mark this as a duplicate

Dupe of #819


Design, test, and implement Ealing motor control

Controlling the Ealing motors is required to run the ps delays and opas. As soon as they are working, the delays and opas should come along very very quickly.

 The OPA and Delay modules are working in concert with the motors. I'm calling this section done.


#699/first impression

Description
Lowers the barrier to contribution by focusing the README.
Issues Resolved
699
Check List

[ N/A ] New functionality includes testing.

[ N/A ] All tests pass

[ N/A ] New functionality has been documented.

[ N/A ] New functionality has javadoc added

[ X ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

LGTM, can I nitpick and ask you to get rid of the text wrap at 80 columns? Markdown doesn't care and the diffs are easier to read without it.

@dblock
I appear to be unable to reply directly to your "nitpick" comment (perhaps it wasn't marked as a review comment?), so please find my answer below. Also, I'd be grateful if you could resolve the earlier conversations that you're satisfied with.
Nitpicking is more than fine: I often find that they are expressions for deeper (tacit) concerns :slightly_smiling_face: In this case, however, would you mind clarifying your reasoning - perhaps even in a project style guide, so that the same discussion won't have to take place in the future? At some level, I guess, I don't see why we should forego wrapping just because we're dealing with a README.
My perception is that a 80 or 100 columns restriction improves diff readability in most relevant situations, e.g., editorial changes don't get swamped by the rest of the paragraph. Are there any particular scenarios in which you find the opposite to be true? Also, do you diff on entire PRs or on individual commits?
I don't think I understand your comment about markdown not caring - neither do most programming languages, but the popular style guides still enforce wrapping. Could you please clarify? (I wrap because I find such source files to be easier to work with, not because I'm misguided about markdown rendition.)
Thank you for considering my patience: It makes me feel appreciated. For the most part, I'm fine with taking the time to sort out all worries, especially when I believe doing so benefits the project of the individuals :slightly_smiling_face: For example, should you decide to raise a ticket and send up a PR for a minimal style guide, I'm happy to wait for it (that way, you won't have to duplicate your text).

I decided I'd write this up here :)

@jesperolsson-se can you please rebase this, there's a merge conflict.
I don't care about the 80 column thing for this PR.

@dblock
It pleases me to hear that our discussion inspired you to write, and I hope that others find it helpful. While I don't believe you meant any harm, I would like to request that you ask for permission next time.
Of course, anything we write here becomes public, but that's not really my point. Perhaps it's a cultural difference (I really can't tell :slightly_smiling_face:) but, to me, asking for consent prior to publication is a sign of respect for the individual. It's difficult to express this notion (and even more so in text), and perhaps it isn't very important to do so because I'll gladly give you my consent a posteriori.
Regarding this PR, I've now rebased (it seems like you were the author whom I had conflicts with). Most of the conflicts related to paragraphs that I was removing or rewriting, and a couple were style differences for which we have no guide. The end result is pretty much identical to what you've reviewed thus far in this PR.

@dblock
It pleases me to hear that our discussion inspired you to write, and I hope that others find it helpful. While I don't believe you meant any harm, I would like to request that you ask for permission next time.
Of course, anything we write here becomes public, but that's not really my point. Perhaps it's a cultural difference (I really can't tell 🙂) but, to me, asking for consent prior to publication is a sign of respect for the individual. It's difficult to express this notion (and even more so in text), and perhaps it isn't very important to do so because I'll gladly give you my consent a posteriori.

I am sorry if I did something wrong, that was definitely no intent to do so. I wrote why I prefer not to wrap text in markdown, which seems like not something I should seek permission for. I do not mention you in the post, and link to your well-written publicly available comment about the matter. What permission did I need to seek?

Regarding this PR, I've now rebased (it seems like you were the author whom I had conflicts with). Most of the conflicts related to paragraphs that I was removing or rewriting, and a couple were style differences for which we have no guide. The end result is pretty much identical to what you've reviewed thus far in this PR.

Thanks

start gradle check


Firmware update issue 1.0.6

I update to firmware 1.06. When I tried to update the LCD I received error message not correct model? Is there a different file I should use than the one provided (HASwitchPlate.tft) with the 1.0.6 files?
HASPone FW Version: 1.06
LCD Model: NX3224F024_011R
LCD FW Version: 3
LCD Active Page: 3
LCD Serial Speed: 921600

There are two firmwares in this project, the HASPone PCB is now at 1.06 and LCD firmware is version 3, so you should be good to go!


Flash back for the new version 14.1 version R3sk game.

In response to LOL version 14.1, R3 no longer works normally. I did the following tests: I injected the game file with the DLL extension file of version 13.24 R3, and found that the new version of the game can run normally and will not exit. Does that prove that we can combine the 13.24 file with 14.1 to carry out a series of fusion upgrades? What do you think, Mr. Author?

The Tencent server's anticheat is different from the global server's anticheat project. It cannot be generalized.

腾讯服务器的反热与全球服务器的反热项目不同。不能一概而论。目前，vanguard for global server尚未投入使用。谁也无法预测以后会发生什么。

Sir, is there room for optimization in the extension file of version 14.1? If we lose this R3sk, we will lose our enthusiasm for the game.


Generattor error when assertions entry point template class name is changed

If one used the following template :
package ${package};

/**
 * Entry point for assertions of different data types. Each method in this class is a static factory for the
 * type-specific assertion objects.
 */
public class MyAssertions {
${all_assertions_entry_points}
  /**
   * Creates a new <code>{@link Assertions}</code>.
   */
  protected MyAssertions() {
    // empty
  }
}

the generator will still generates a file named Assertions.java instead of MyAssertions.java but the generated content is correct.

This issue is referenced by my sample project https://github.com/aro-tech/template-example
In my project (which is an educational prototype), I modify the templates to generate the standard endpoint Assertions.java not as a class but as a mixin interface - to combine with other mixins, including one for the assertj-core Assertions (see my project https://github.com/aro-tech/tdd-mixins-core ). It would be nice to be able to rename the generated endpoint to reflect the fact that it's a mixin interface rather than a class with static methods.


Unify TestBatchNormalization and TestBatchNormalizationAxis

Add ideep tests to TestBatchNormalizationAxis.  Then unify the code with TestBatchNormalization.
#4266

jenkins, test this please.

The CI failed due to a warning that is seeming irrelevant to this PR. Could you merge or rebase the latest master branch?

Done

Thank you!

jenkins, test this please.

jenkins, test this please.

LGTM

LGTM


add ability to use front camera on start

Allow ability to set the initial camera to the front instead of the back camera in addition to the default mode or camera/library order #62

@mikemliu Thanks! I have to have my mac repaired. When my mac has been fixed, I will check your pull request.


Use black for code formatting

Fancy new code formatter. I use the following on my projects:
$ virtualenv venv
$ venv/bin/pip install git+https://github.com/ambv/black
$ venv/bin/black --line-length=79 $(git ls-files '*.py')

I'm 100% in favor of this.

Nice one! @theacodes The blacken session isn't very future proof. Are you opposed to using
$(git ls-files '*.py') to make sure all source files get blackened?

@dhermes I'm not opposed, but there's only two top-level files that I care about formatting right now.

OK. We can revisit if needed. SGTM.

Thank you for your attention to detail. :)
On Thu, Aug 23, 2018 at 8:53 PM Danny Hermes<EMAIL_ADDRESS>wrote:

OK. We can revisit if needed. SGTM.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/theacodes/nox/issues/114#issuecomment-415643363, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPUc6zFBnhaZ53smmUTnV8D_SabJgJaks5uT3i7gaJpZM4WJ_ks
.


How to save OHIF measurement or annotation to mySQL

For work reasons, I need to use OHIF to view DICOM images
I followed the documentation to download and deploy OHIF + Orthanc, and it ran successfully.
I have stored the metadata of Orthanc’s uploaded DICOM images in MySQL, but I still don’t understand how to save the measurement data in the OHIF viewer to MySQL.
This problem has been plagued for many days and read Document several times.
In addition, there is a problem that the default downloaded by OHIF only supports round and square measurement. How can we develop the labeling and measurement of arbitrary polygons?
Thanks very much

Here is what I have done. I searched all files for RectangleRoi and added FreehandRoiTool nesxt line to it. And renamed FreehandMouse.js to FreehandRoi.js , and added to toolbar with toolbarModole.js file as below. And its done but in measurements sidebar they still in yellow color with warning.
**
{
id: 'RectangleRoi',
label: 'Rectangle',
icon: 'square-o',
//
type: TOOLBAR_BUTTON_TYPES.SET_TOOL_ACTIVE,
commandName: 'setToolActive',
commandOptions: { toolName: 'RectangleRoi' },
},
{
id: 'FreehandRoi',
label: 'Freehand',
icon: 'circle-o',
//
type: TOOLBAR_BUTTON_TYPES.SET_TOOL_ACTIVE,
commandName: 'setToolActive',
commandOptions: { toolName: 'FreehandRoi' },
},**

Here is what I have done. I searched all files for RectangleRoi and added FreehandRoiTool nesxt line to it. And renamed FreehandMouse.js to FreehandRoi.js , and added to toolbar with toolbarModole.js file as below. And its done but in measurements sidebar they still in yellow color with warning.
**
{
id: 'RectangleRoi',
label: 'Rectangle',
icon: 'square-o',
//
type: TOOLBAR_BUTTON_TYPES.SET_TOOL_ACTIVE,
commandName: 'setToolActive',
commandOptions: { toolName: 'RectangleRoi' },
},
{
id: 'FreehandRoi',
label: 'Freehand',
icon: 'circle-o',
//
type: TOOLBAR_BUTTON_TYPES.SET_TOOL_ACTIVE,
commandName: 'setToolActive',
commandOptions: { toolName: 'FreehandRoi' },
},**

For tool issue.
Here is what I have done. I searched all files for RectangleRoi and added FreehandRoiTool next line to it. And renamed FreehandMouse.js to FreehandRoi.js , And added to tools needed to toolbar with toolbarModole.js file as below. And its done :) But in measurements sidebar they still in yellow color with warnings.
**
{
id: 'RectangleRoi',
label: 'Rectangle',
icon: 'square-o',
//
type: TOOLBAR_BUTTON_TYPES.SET_TOOL_ACTIVE,
commandName: 'setToolActive',
commandOptions: { toolName: 'RectangleRoi' },
},
{
id: 'FreehandRoi',
label: 'Freehand',
icon: 'circle-o',
//
type: TOOLBAR_BUTTON_TYPES.SET_TOOL_ACTIVE,
commandName: 'setToolActive',
commandOptions: { toolName: 'FreehandRoi' },
},**

For tool issue.
Here is what I have done. I searched all files for RectangleRoi and added FreehandRoiTool next line to it. And renamed FreehandMouse.js to FreehandRoi.js , And added to tools needed to toolbar with toolbarModole.js file as below. And its done :) But in measurements sidebar they still in yellow color with warnings.
**
{
id: 'RectangleRoi',
label: 'Rectangle',
icon: 'square-o',
//
type: TOOLBAR_BUTTON_TYPES.SET_TOOL_ACTIVE,
commandName: 'setToolActive',
commandOptions: { toolName: 'RectangleRoi' },
},
{
id: 'FreehandRoi',
label: 'Freehand',
icon: 'circle-o',
//
type: TOOLBAR_BUTTON_TYPES.SET_TOOL_ACTIVE,
commandName: 'setToolActive',
commandOptions: { toolName: 'FreehandRoi' },
},**

To interact with your server, confidently make an XHR POST call.


[SPARK-23529][K8s] Support mounting hostPath volumes

What changes were proposed in this pull request?
This PR introduces a new config spark.kubernetes.driver/executor.volumes taking a values of the format documented here
The use case is to enable short-circuit writes to distributed storage on k8s. The Alluxio File System uses domain sockets to enable short-circuit writes from the client to worker memory when co-located on the same host machine. A directory, lets say /tmp/domain on the host, is mounted on the Alluxio worker container as well as the Alluxio client ( = Spark executor) container. The worker creates a domain socket /tmp/domain/d and if the client container mounts the same directory, it can write directly to the Alluxio worker w/o passing through network stack. The end result is faster data access when data is local.
How was this patch tested?
Manual testing on a k8s v1.8 cluster. Unit tests added to Driver/ExecutorPodFactorySuite.
This PR replaces https://github.com/apache/spark/pull/21032.

Can one of the admins verify this patch?

@liyinan926 @foxish Please take a look

Can one of the admins verify this patch?

jenkins, ok to test

@madanadit, thanks for following up with the PR and for your design doc. I had a few comments on the doc which I've added for discussion.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2451/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2398/

Test build #89529 has finished for PR 21095 at commit 7c1be8a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89529/
Test PASSed.

Merged build finished. Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2398/

Thanks @foxish for your feedback. As a first time contributor to Spark, I would like to limit the scope of the changes in this PR. Let me know when you're ready to review again.

My general comment is the code is centered around parsing and setting up hostPath volumes even though the proposal is generic. I would suggest making the code generic as well. Particularly I would like to see an implementation that is able to parse all volume related properties and add all discovered volumes in one shot.

Test build #89601 has started for PR 21095 at commit f482dfc.

@liyinan926 Thanks for the comment. I refactored it to address your concern. The code is simple enough to be easily refactored if the need be by whoever implements the next volume type.
Note that the goal of this PR is limited to hostPath volumes. Even though the implementation here is general enough to be extended, I will not attempt to add other volume types in this PR.

Test build #89601 has finished for PR 21095 at commit f482dfc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89601/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2505/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/2450/

Thanks @madanadit! I will take a look over the weekend or early net week.

Hey @liyinan926, do you think you'll have time to take a look this week?

@madanadit, sorry about the long turnaround time here. I made a cursory pass over it - and it looks good. Before getting deeper into the code, I think we need more exhaustive unit testing for non-hostpath type volumes, and a couple of e2e tests. Once those are done, I'm also happy to do a more detailed review here.

Hi @foxish, I don't see why the 2 testing concerns should block reviewing this PR.

This PR does not attempt to address non-hostpath volumes (both implementation and unit tests are hence not included).
I agree e2e tests do make sense. However, e2e tests should not block this PR in any way. e2e tests can also be added once the PR is reviewed?

@madanadit @liyinan926 @foxish I addressed comments here and added PVC support https://github.com/apache/spark/pull/21260. However I'm unsure if this is the right way to go, please check the PR.

@andrusha Is the purpose of https://github.com/apache/spark/pull/21260 to replace both this PR and https://github.com/apache/spark/pull/21238?

@liyinan926 that's the idea. We should have a single step to mount all kinds of volumes including hostPath and emptyDir. The only problem is the configuration awkwardness.

Thanks @liyinan926 for the review and @andrusha for addressing the comments and moving the work along. I can close this PR once #21260 merges.

Can one of the admins verify this patch?

@madanadit can you close this as #21260 has been merged?


Enable gzip compression in Caddyfile

This will gzip responses from our webserver if the client indicates
support for it. All modern browsers do.

I tested this locally by building a local container and inspecting the network tab when loading the homepage.
zef install . --deps-only
./bin_files/build-site --without-completion --no-status
./.buildkite/archive.sh
./.buildkite/container.sh latest
podman run --rm -p 8080:80 quay.io/colemanx/raku-doc-website:latest


Cannot read JSON in CentOS

VSCode Version: 1.12
OS Version: CentOS 7

Steps to Reproduce:

Install vscode on CentOS
You will get this

this issue is probably related.

I have the same problem.
Version: 1.13.0
OS: Debian 6

The same problem using latest Raspbian (debian jessie arm):
Version 1.14.0
Commit ebecfa501bf8d6e353cd971628b05cf5c223fa45
Date 2017-06-11T20:16:09.668Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0
Installed DEB built and packaged by https://code.headmelted.com/

Can you open the developer tools (Help > Toggle Developer Tools) and see if there is more information?
Is this only with JSON or with any other file format?

duplicate of #32193


Add config option to disable action_view annotations

Rails allows you to set a config option named config.action_view.annotate_rendered_view_with_filenames which will wrap rendered templates in HTML comments indicating the file system path of the file being rendered. This can be useful in dev environments to make it easier to track down where parts of the page are coming from. However it can create a bit of noise when viewing the HTML tab of a component in Lookbook. Below is an example of setting this value to true in the workbench app.

This PR introduces a new Lookbook config setting to generate this source without these annotations in the event the setting is enabled. Setting config.lookbook.disable_action_view_annotations = true will generate the source without them.

I made this a configuration setting in the event there are folks who want to leave these annotations in place. I'm defaulting it to false because that matches the existing functionality so it feels less disruptive. I'm happy to change the default to true if you feel otherwise though.
The action_view.annotate_rendered_view_with_filenames config option was first added to Rails in 6.1.0. I'm not sure the best way to test this in versions prior to that to ensure it works or which versions we want to ensure Lookbook is compatible with.

@steves this is really great! Many thanks for this.
Just one minor thing - I've been trying to 'namespace' related config options via a prefix on the name. So as this option is related to previews I think it should probably be called preview_disable_action_view_annotations - it's a bit of a mouthful but follows the convention of the other preview related options. What do you think? Would you be able to update the PR if you agree?
Also my gut feeling with this is to set the default value to true, even if that is a change in the current default behaviour. Looking at the screenshot you provided, the annotations add a lot of noise and if they can be easily turned back on I think stripping them out is probably a better default for new users. Do you agree?
Let me know what you think and then I'll get this merged in when ready.

@allmarkedup Thanks for the feedback. Those changes make sense to me. I'll make them today and get the PR updated.
@DRBragg Thanks for the input. I was thinking of adding a respond_to? check to be on the safe side. I tend to prefer checks like that over version numbers as I find them more self documenting.

@steves @DRBragg yep the respond_to? check works for me, nice one 👍
@steves thanks for making those changes, all looks good to me now so I'm going to merge this in and will include it in the next release. Really appreciate the contribution!


Error on register event

But the register is working anyway

I found that the problem was that uwsgi was using python 2.7 and so tried to decode string to ascii when sending the email resulting in an error on the register.
I installed uwsgi for python 3 and restarted the service


UI to start and stop recording?

Could I ask you to add UI to start, stop and then display a kind of rolling buffer, similar to this but for audio:
https://github.com/syedhali/EZAudio

Please refer to issue #7
Thanks.


Fixed #24335 -- Bumped required psycopg2 version to 2.4.5 (2.5 for contrib.postgres).

Looks good (except for the checks, but that appears to be a transient error).

Pretty clear to me :+1:

:+1:


Automate releases

Using this issue to bring together the efforts scattered across other repos.
The goal is to have all releases to RubyGems, NPM, Maven etc. made by GitHub Actions workflows. We'll use GitHub Environments to secure the secrets used to publish packages.

[x] cucumber/build https://github.com/cucumber/build/issues/42
[x] cucumber/cucumber-ruby-wire https://github.com/cucumber/cucumber-ruby-wire/pull/49
[x] factor out a publish-rubygem action
[x] factor out a versions action to read the changelog latest and tagged release versions
[x] factor out a create-release action. WIP in https://github.com/cucumber-actions/create-release
[x] review all instances of release workflows and ensure they're using the latest versions of our actions
[x] archive get-released-version action which is superseded by the new versions action.
[x] cucumber/cucumber-expressions https://github.com/cucumber/common/issues/1688
[x] cucumber-ruby-core: https://github.com/cucumber/cucumber-ruby-core/pull/224
[x] cucumber-ruby: https://github.com/cucumber/cucumber-ruby/pull/1567
[ ] cucumber-parent: https://github.com/cucumber/cucumber-parent/issues/32
[ ] create a publish-go action
[ ] create a check-release-commit-is-on-main action (see here
[ ] factor out RELEASING.md to try having a single one compatible with all the repos

[ ] script or automate the bump of the version numbers into package descriptors
[x] extract update of gemspec of the release process, or document it as a generic process as part of the release one

The current strategy to mark the commit to be released with a temporary pre-release/* branch is a bit fragile as, if that branch is deleted before the release is made, we don't know what commit to tag.
Maybe the pre-release script needs to make a "Draft" Release (and a tag), then we can just publish that Release when we make the actual release.

We can pull out the sha of the commit being released like this:
url=$(gh pr list --state closed --base release/v0.8.0 --json url | jq -r '.[0].url')
sha=$(gh pr view $url --json commits --jq '.commits[-1].oid')

That should work even if the pre-release/* branch has been deleted.

I've sketched out a repo for a create-release action where we can properly test the different scenarios around tagging release commits. It's not finished yet. https://github.com/cucumber-actions/create-release

We now have a working GitHub Actions release workflow in cucumber/cucumber-expressions
Preparing a release is still a bit too manual for my liking. Things I'd like to improve:

[ ] Make it easier for people to install the changelog tool. We can improve the existing goreleaser config so that people can install it with various package managers.
[ ] Provide a scripts/prepare-release script that runs changelog release ..., updates the package descriptors and pushes to github.

Now that we're splitting up common into more and more repos, I think each repo will need a RELEASING.md file and a scripts/prerelease script. I also think they will be the same. So we should look into a solution where we can maintain common files in a single repo and easily sync them to select repos.

I must say that once it is working, I find the release process pretty smooth. Like it a lot.
I see two things we could improve:

we could very easily push the release commit only on the release branch and never on the main branch: maybe we could make sure the commit we are about to release exists on the main branch
we could very easily too release a non working module. I think we should run the tests before the publication of the modules, even if tests have already been executed on the main branch. Actually nothing prevent us to push non working stuff on the release branch right now

* Provide a `scripts/prepare-release` script that runs `changelog release ...`, updates the package descriptors and pushes to github.

gh lets us trigger workflow_dispatch events to run arbitrary workflows with parameters, so we could probably bundle this script as a GH action and then use something like this to trigger it:
gh workflow run pre-release.yaml -f next-version=2.0.0

WDYT?

What would be the value to use a workflow over a local script?

The main benefit would be that we don’t have to install the changelog script locally.
we also wouldn’t have to copy-paste the pre-release script across multiple repos (but we’d still have to enable the action for each repo)

I have added some TODOs too following the comments here: https://github.com/cucumber/cucumber-ruby-core/pull/224#issuecomment-931954367

Some feedback after having released cucumber-ruby-core, cucumber-ruby-wire and cucumber-ruby using the new release process, the one with a single push on a dedicated release/vX.Y.Z branch.
First of all, it worked as expected. It was pretty smooth 🤩
In short:

we prepare the release as usual (preparation of the changelog, update of the gemspec, ...)
push a "Release" commit to main
then we can push the main branch to a dedicated release/vX.Y.Z branch. That will trigger a dedicated workflow which will release the new version.

The workflow has been copied from cucumber-expressions, and it has been tweaked:

I have added a check to make sure what we were about to release was pushed on main before (https://github.com/cucumber/cucumber-ruby/blob/main/.github/workflows/release.yml#L10)
I have added the execution of the tests before publishing the gem (https://github.com/cucumber/cucumber-ruby/blob/main/.github/workflows/release.yml#L22). That may slow-down the process, but it make it far more safer.

Also, as the repos have a single implementation, there was a single release workflow with the publication of the ruby gem, then the creation of the release on github. That may not be as simple with repos with multiple languages.

As an attempt of factorization, I have created an action to execute the tests, and use that action as part of the test workflow and the release workflow.
I don't know how far we could factorize the process. There are some redundancy across the repositories, but I am not sure this is because of duplication. We could maybe create a precheck action, but other jobs are already pretty well factorized into their own dedicated actions. What we have to take care of is: if we tweak the release for a repository, we may have to update it for other repositories as well.
Also as @aslakhellesoy pointed out, the RELEASING.md document could be standardized.
I am pretty confident with that process. BUT, there is a point we have to be extra careful: the security of the process rely on github settings: the protection of release/* branches, and the associated "Release" environment. If an option in those settings is missed, some secrets could be compromised.

@mattwynne @aurelien-reeves can we close this now and have smaller tickets for the remaining projects?

track continued progress at https://github.com/orgs/cucumber/projects/13


Check for python version before installing

Pydem requires python 2.7 but somehow I was able to install and import the library using python 3.5. Needless to say my application failed.
Unrelated feature request: It would be useful to be able to instantiate DEMProcessor from a 2D numpy array rather than passing the name to a tif file.

Agreed, should check python version. Will look into it.
Agreed. that would be a useful feature. Feel free to make a push request if manage to fix it.

Added a requirement for python 2.7 in version 0.2.0 .
Added ability to instantiate a DEMProcessor from a 2D numpy array, rather than passing the name to a tif file.


result after running eval.py

Hi Liu
I applied weight pruning on pretrained detector.core.backbone(resnet34) after training 80 epochs.
The process was training -> pruning -> finetuning.
However when I ran the eval.py.
The result was like this below

Can you guess what's the problem?
The result after 59 epochs training was like this below

Thanks

Could you please provide some scripts to reproduce the experiment?


Does it account for nodeSelector?

Sometimes, I want some pods to stay on OnDemand instances for lifecycle reasons (e.g. cannot afford interruption). So I specify a nodeSelector to target the OnDemand instance.
Will the spot rescheduler attempt to remove such a pod?

Bump. I think @TarekAS's question is a valuable one and I see no clear statement as to whether this is in fact considered in draining operations.


Serde integration

Example:
#[cfg_attrib(feature="serialize", derive(Serialize, Deserialize))]

cc @ebkalderon @msiglreith

@kvark I think you meant #[cfg_attr(...)]. 😉 I am currently preparing two pull requests, one for draw_state and one for gfx_core.

Okay, took a bit longer than I expected, but the PR for draw_state is now ready! (gfx-rs/draw_state#42)


Flutter 2.8 compatibility fix

https://github.com/singerdmx/flutter-quill/issues/497
https://github.com/singerdmx/flutter-quill/issues/513
Tried to implement TextEditingActionTarget, but copypasting appeared to be much easier.
Selection toolbar behaviour has changed. Need a bit testing.

To make your review easier I just copied all those method from here:
https://github.com/flutter/flutter/blob/cf4400006550b70f28e4b4af815151d1e74846c6/packages/flutter/lib/src/widgets/text_editing_action_target.dart#L1473-L1477

OK, got it. Is the PR ready to be merged?

If you're asking me, then yes, I'm sure that it's ready, cause I'm using this solution already in my project.


Add warning info to affected MS Graph commands

Is your feature request related to a problem? Please describe.

WIth the upcoming migration to MS Graph and planned retirement of the AAD Graph endpoint, customers need to be informed of upcoming changes and recommendations on how to prepare for migration.
Describe the solution you'd like

An issue has been created to track the Azure CLI Docs side of things, but another solution is to provide messaging directly in-tool for future affected commands to inform customers currently using said commands that they will need to update/migrate for new MS Graph integration.
Describe alternatives you've considered

Documentation, blogposts and Social media blasts will happen as well
Additional context

@jiasli for awareness


Consider removing filters with one unique value.

i doubt every study needs the the analysis subsetters (Subset 1, Subset 2, Subset 3).  they might be worth optionalizing, either when the variables don't exist or are constant.
Test Notes

Set all values of a filter variable equal to the same value and render that chart.  That filter should not show up, and a note should print to the console that it was removed.

Download the data file.
Delete all values in any of these columns: status, subjfreezeflg, sitename, subset1, subset2, subset3.
Upload the edited data file and re-render the chart.
The filter representing the edited column should not appear.

@samussiah  deleted sitename and status. Both were removed and both printed to console but all other nesting filters were also removed. This is probably expected behavior but wanted to note it.


Add  Blog post about dev.to and add action to automatically x-post there

add blog post about dev.to
add and test action to cross-post to dev.to
update gitignore

the github action is in testing mode first. because of that it is limited to 2024 and in dry_run mode. :D if it works like i hope it works, i will change this...


irmin-pack: assertion failure when calling flush for a read-only index

Currently, we assert false if we call flush for a read-only index. See https://gitlab.com/tezos/tezos/-/issues/3520 for more context.
Is it the best solution to assert false in this situation?
Reasons I see for either making this a no-op or returning an Error:

Yes this is a usage error but throwing an exception (and likely crashing the process) because of this seems more than is necessary since it does not harm the system if we ignore these calls
The current api uses an error monad but we raise an exception; that is a break in expectation

I’m on the fence about making it a noop because even though it is harmless to ignore it might indicate some kind of API usage issue if flush is being called on a readonly store. It seems like an error might help them identify the issue and fix it?
I don’t have strong feelings either way though.

Yeah, it's definitely in the category of incorrect API usage. I lean slightly towards returning an Error instead of throwing an exception since it makes the error explicit for in calling code (like you're saying) and coheres with the current API.
The downside of an Error is it is awkward ergonomics if you know you've created a read-write instance. The ideal from an ergonomics perspective would be to not let this function be called at all with read-only instances through changes to t (perhaps using https://github.com/mirage/irmin/blob/main/src/irmin/perms.ml), but that is definitely a more involved change.

Agreed, something at the type level would be ideal!
It's not such a big issue because if you are knowingly calling flush on a readonly store then you're free to ignore the error result.
It looks like close, reload and flush all assert false when the instance is readonly, we should definitely make sure that they all handle it the same. I can make a PR to have them return Error `Ro_not_allowed instead of assert false if we agree that is the best fix.


Questions on train.txt

If I want to train my data set，If I'm going to train my data set, how do I tag something like 0100 0000?

You can just sort the labels in any order. And for each image x_i, let the j-th  bit to be 1 if and only if x_i belongs to j-th classes.

thank you
I thought the name of the picture was similar to 1-22, and 1 was the meaning of category ,yesterday。


Version 0.10.0 Release Update

:white_check_mark: Build aneris 0.10.0.build22 completed (commit https://github.com/DTOcean/aneris/commit/9d0b432e79 by @H0R5E)

:white_check_mark: Build aneris 0.10.0.build23 completed (commit https://github.com/DTOcean/aneris/commit/47c24f4253 by @H0R5E)

:x: Build aneris 0.10.0.build24 failed (commit https://github.com/DTOcean/aneris/commit/b1fc78d410 by @H0R5E)

:white_check_mark: Build aneris 0.10.0.build27 completed (commit https://github.com/DTOcean/aneris/commit/651f859f5d by @H0R5E)

:white_check_mark: Build aneris 0.10.0.build28 completed (commit https://github.com/DTOcean/aneris/commit/4e8cfd0c2b by @H0R5E)

:white_check_mark: Build aneris 0.10.0.build29 completed (commit https://github.com/DTOcean/aneris/commit/5f1c80ea51 by @H0R5E)

:white_check_mark: Build aneris 0.10.0.build30 completed (commit https://github.com/DTOcean/aneris/commit/779fde631a by @H0R5E)


Fix builds, update build containers, update dependencies, and fix ci.

Couple of minor things that weren't fully working while doing the 2.4.0 build.
Also periodic update to dependencies.

While fixing CI, suggesting to upgrade GHA actions to avoid deprecation warnings:
diff --git a/.github/actions/build-bitcoind/action.yml b/.github/actions/build-bitcoind/action.yml
index 49f9c72..0292d7c 100644
--- a/.github/actions/build-bitcoind/action.yml
+++ b/.github/actions/build-bitcoind/action.yml
@@ -9,7 +9,7 @@ runs:
         sudo apt-get install -y ccache
         echo "CCACHE_DIR=${{ runner.temp }}/ccache" >> "$GITHUB_ENV"

-    - uses: actions/cache/restore@v3
+    - uses: actions/cache/restore@v4
       id: ccache-cache
       with:
         path: ${{ env.CCACHE_DIR }}
@@ -25,13 +25,13 @@ runs:
         ccache --show-stats --verbose
         tar -czf bitcoind.tar.gz test/work/bitcoin/src/bitcoind

-    - uses: actions/cache/save@v3
+    - uses: actions/cache/save@v4
       if: github.event_name != 'pull_request' && steps.ccache-cache.outputs.cache-hit != 'true'
       with:
         path: ${{ env.CCACHE_DIR }}
         key: ${{ github.job }}-ccache-${{ github.run_id }}

-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       with:
         name: bitcoind
         path: bitcoind.tar.gz
diff --git a/.github/actions/install-sim/action.yml b/.github/actions/install-sim/action.yml
index 1a85e35..f9799f1 100644
--- a/.github/actions/install-sim/action.yml
+++ b/.github/actions/install-sim/action.yml
@@ -7,7 +7,7 @@ inputs:
 runs:
   using: composite
   steps:
-    - uses: actions/download-artifact@v3
+    - uses: actions/download-artifact@v4
       with:
         name: ${{ inputs.device == 'ledger-legacy' && 'ledger' || inputs.device }}-sim

@@ -55,7 +55,7 @@ runs:
         pip install construct flask-restful jsonschema mnemonic pyelftools pillow requests pytesseract

     - if: inputs.device == 'ledger'
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: ledger_app

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 600d248..dd9d792 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -133,7 +133,7 @@ jobs:
               find dist -type f -exec sha256sum {} \;
             "

-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: dist
           path: dist/
@@ -173,7 +173,7 @@ jobs:
           cd test; ./setup_environment.sh --${{ matrix.device.name }}; cd ..
           tar -czf ${{ matrix.device.archive }}.tar.gz ${{ matrix.device.paths }}

-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ${{ matrix.device.name }}-sim
           path: ${{ matrix.device.archive }}.tar.gz
@@ -188,7 +188,7 @@ jobs:
           cd app-bitcoin-new
           make DEBUG=1

-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: ledger_app
           path: app-bitcoin-new/bin/app.elf
@@ -240,7 +240,7 @@ jobs:
       - run: |
           pip install poetry

-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: dist
           path: dist/
@@ -248,7 +248,7 @@ jobs:
       - run: |
           ${{ matrix.script.install }}

-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: bitcoind

@@ -297,7 +297,7 @@ jobs:
           pip install poetry
           poetry install

-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: bitcoind

code lgtm! (did not review build stuff)


Fix NATS event store implementation

The currently implemented event store was written with a limited knowledge of NATS streaming, abusing some of the features.
Currently the naieve setup consists of the following subject structure

workflow.<id>: each subchannel contains one workflow.
invocation.<id> : each subchannel contains the activities of one workflow invocation.
_activity: NATS streaming doesn't support wildcard subscriptions as of the moment of writing (see https://github.com/nats-io/nats-streaming-server/issues/340 for progress on the feature). In order to replicate the behavior of a wildcard subscription this channel is used to publish notifications of when something happens in one of the various workflow/invocation subchannels. The event store implementation has one 'metasubscriptions' on this channel that creates new subscribers when new subjects appear.

The problems with this setup:

subjects/channels seem expensive. NATS streaming puts limits on the number of subscriptions (100) and the number of subjects (1000). Though these are artificial and it remains unclear what happens if changed to a much higher number.
subjects/channels cannot be deleted in any way. This means, even if invocations complete, they still remain in NATS as channels.
Messages cannot be deleted either. Nor can certain channels/messages be marked as deletable. Currently NATS just starts deleting the oldest messages once it is full.

Possible solutions:

Move workflows out of the event store. As these are considered immutable when generated/parsed, they can be kept out of the event store and left to be handled by Fission.

Though it might be needed to store them somewhere persistent, as workflow invocations are tied to these parsed workflows. Information which might be lost if the parsed workflow is not stored.

Use a single subject for all the things. I am not sure what the performance hit of this would be as, subscribers would need to go over all messages when recreating the state of anything.
Use a subject per workflow. In this case the workflow is stored together with associated invocations. The problem here might be that you will not be able to delete (when that option becomes available) any subject as that would also
Keep the current implementation and work with the NATS team to implement some of the missing functionality:

More advanced garbage collection; ability to mark subjects/messages as GC'able
Wildcard subscription support for NATS streaming
Ability to delete or archive subjects (or even messages) manually

Switch to a different database or message bus. There is no perfect solution on the market yet that contains all the required properties of the event store (fast, lightweight, persistent, reliable, scalable). A partial implementation exists for BoltDB (dropped after realizing it would need implementation of the entire pubsub functionality) which might be an alternative.

Currently, for the prototype, this is a low priority issue, as for small usage (<1000 invocations) it works just fine. Nothing is persisted yet, as fission-nats.yml deployment is still using in-memory, and can be cleared by simply restarting that deployment. So, until the prototype is advanced enough that it becomes clear what is needed from the event store, the current implementation is okay.

Curious if Kafka was ever considered. Seems like it would fit the bill.
5. Switch to a different database or message bus. There is no perfect solution on the market yet that contains all the required properties of the event store (fast, lightweight, persistent, reliable, scalable).

@saidimu it is indeed one of the options we looked at. However, Kafka is on the other side spectrum, containing a lot of overhead and features that are not needed for a simple, internal data store. For the main requirements of it needing to be fast and lightweight NATS seems preferable to Kafka. We are working with the NATS team to resolve some of the issues (in their codebase or this one)
That said, this is one of the parts that still needs to be improved a lot. The interface used to communicate with the data store is deliberately as simple as possible to allow for easy implementation of another data store. So, if preferred, it could be an option to add a Kafka backend as well.


Issue when Footnote with :

Maybe same as #20 :
Footnote error

.. [1] Footnote from : this journal

Parses as
document [0, 0] - [4, 0]
  paragraph [0, 0] - [0, 14]
  ERROR [2, 0] - [2, 35]
    label [2, 3] - [2, 6]
    classifier [2, 23] - [2, 35]

Because of the :, spaces are important for the failure.
I believe that's fine in sphinx as this seem to be the standard for citation in SciPy/NumPy

Yeah, fixing https://github.com/stsewd/tree-sitter-rst/issues/20 should fix all problems related to :


Update github action versions.

For publish, master is no longer recommended or maintained, so point the action at a release:
https://github.com/pypa/gh-action-pypi-publish#-master-branch-sunset-
Release versions of checkout and python actions also needed to be updated due to github changing the node they run on: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
Update supported versions of python, as we only went up to python 3.9, and 3.6 is now EOL:
https://devguide.python.org/versions/
Signed-off-by: Jason Guiditta<EMAIL_ADDRESS>

Good grief, now there is something deprecated in mergify, I'll close and reopen with updated merge message explaining changes:

bangbang Action Required bangbang

The configuration uses the deprecated rebase_fallback mode of the queue and/or merge action.
A brownout is planned on February 13th, 2023.
This option will be removed on March 13th, 2023.
For more information: https://docs.mergify.com/actions/queue/ or https://docs.mergify.com/actions/merge/
warning The configuration has been changed, queue and merge actions are ignored. warning

Shown in
https://github.com/release-depot/flask-container-scaffold/pull/28/checks?check_run_id=10609679770
I was considering splitting the mergify change into its own patch and doing that first, any thoughts before I close this? @fuzzball81 @jpichon

I was considering splitting the mergify change into its own patch and doing that first, any thoughts before I close this? @fuzzball81 @jpichon

Will the mergify change be able to merge without this one going in first, though?

I was considering splitting the mergify change into its own patch and doing that first, any thoughts before I close this? @fuzzball81 @jpichon

Will the mergify change be able to merge without this one going in first, though?

It will have to be merged by hand anyway, so I would think so

It will have to be merged by hand anyway, so I would think so

Right, I forgot about that! Sounds fine to me.

To recap irc convo - I will leave this as is, since it is passing, and submit a second patch once this merges to fix the deprecation warning from mergify.


join util

I'd like to propose a new join util.
The idea is simple: it calls foreach(str) before calling str.join. So, whenever you have something like
| foreach(str)
| ', '.join

you can replace it with
| join(', ')

You can customize the string conversion by passing either a function or a format string as the second parameter, e.g.:
| join(', ', lambda x: '-{}-'.format(x))        # function

| join(', ', '-{}-')                            # fmt string

Implementation
def join(delim, formatter=str):
    '''
    join(' ')
    join(' ', fmtFn)
    join(' ', fmtString)
    '''

    return foreach(formatter) | delim.join

Tests
def test_join(self):

    r = [1, 2, 3] > (pipe
                    | join(', ')
                    )

    self.assertEquals(r, '1, 2, 3')

def test_join_with_formatter(self):

    r = [1, 2, 3] > (pipe
                    | join(', ', lambda x: '-{}-'.format(x))
                    )

    self.assertEquals(r, '-1-, -2-, -3-')

def test_join_with_fmtString(self):

    r = [1, 2, 3] > (pipe
                    | join(', ', '-{}-')
                    )

    self.assertEquals(r, '-1-, -2-, -3-')

Hey,
thanks for the suggestion!
Some things for discussion:

The name - I think join might be too generic, because it could also be used to join different sequences together (think SQL JOIN), so maybe it should be strjoin or something.

Not sure about the version with formatting - just because for me:
| join(', ', '-{}-')

is much less understandable than:
| foreach('-{}-')
| ', '.join

Would it be possible to automatically perform the string conversion if we encounter the str.join function? I think it should be, in which case you could just do this and it would work:
[1, 2, 3] > pipe | ', '.join

And it would also solve questions 1 and 2 and look more like natural Python. Even though it might be a bit more tricky to implement.

Let me know what you think.

The name - I think join might be too generic, because it could also be used to join different sequences together (think SQL JOIN), so maybe it should be strjoin or something.

I don't see this as a problem. It's not usual to have multiple joins in the same namespace. IME, whenever I have a join in my code, it's this one. It doesn't clash with SQL's join because SQL is usually embeded in a string. Neither can it clash with str.join() because the later is a method of str. And, in the rare case where a clash happens, people can import the parent module to disambiguate.

Not sure about the version with formatting -  just because for me:
| join(', ', '-{}-')
is much less understandable than:
| foreach('-{}-')
| ', '.join

It doesn't bother me. I used something equivalent in Java for years. Maybe it's just a matter of familiarity / getting used to it? :man_shrugging:

Would it be possible to automatically perform the string conversion if we encounter the str.join function? I think it should be, in which case you could just do this and it would work:
[1, 2, 3] > pipe | ', '.join

And it would also solve questions 1 and 2 and look more like natural Python. Even though it might be a bit more tricky to implement.

I wonder if this wouldn't be a little too magical? :thinking:
And in some cases the string conversion would happen more than once. If you perform the conversion yourself, e.g.:
| foreach('-{}-')
| ', '.join

by the time the code reached the join part, it wouldn't know about it and would convert it again.

PS: Sorry for the huge delay in the reply.
PPS: Thank you for the project. It changed my life.
Seriously. When I first learned about it, I was like: "Where have you been my entire life?!"
:joy:

No worries, there's no rush ;) I'm glad you find the library useful!
About the join name, I meant that it's something that could potentially also be in pipetools namespace, as a general purpose collection-joining operation.
Think something like:
In [1]: orders > join(users, X.user_id, X.id) | list

Out[1]: [([order1, order2], [user1]),
         ([order3], [user2])]

Maybe concat could be used instead. Since for concatenating collections there's already chain.
About automatically converting to string before str.join, I wouldn't worry about double string conversion as that's not going to do anything. But I'd be more worried about silently continuing instead of failing when it's not able to produce anything useful - like with some objects that don't have __str__ implemented.


Edit and Clean non-functional files

This sits on top of #66 therefore merge against this branch to see the changes. This can be reviewed before and I will than rebase when #66 is merged.
Goals:

Clean CMakeLists.txt files
use Apache 2.0 license in all packages (this is mostly compatible with BSD used before in one package)
edit authors and maintainers lists
Add one license file and Contribution guidelines.

Became part of #71.


[Proposal] Current session loading process can be very confusing and should be simpler

Not a real and complete proposal, mostly a note from a chat with @jbloomAus.
Proposal
There should be a simple and documented way to load a (model, sae, dataset).
Ideally, there should be a way to load (model, sae) or model then sae, and a way to load a dataset that is more straightforward (or just documented) than ActivationsStore (which I wouldn't have guessed was the main dataloader).
Motivation
The version from the docs is broken, and somewhat confusion (e.g. it's hard to know how to use another dataset with that API).
Checklist

[ x ] I have checked that there is no similar issue in the repo

This is out of date (but I think mostly resolved by various changes we've made since then :) )


This page need a Information update

The section "Set up your device groups, device collections, and organizational units" does not compli anymore.
"

Go to the Microsoft 365 Defender portal (https://security.microsoft.com/).

In the navigation pane on the left, choose Settings > Endpoints > Permissions > Device groups.

Choose + Add device group.
"
This part of the page doesn't work anymore there is no settings --> Endpoints --> Device groups

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 42db2345-0d5c-45f3-6c24-d84a12775fb7
Version Independent ID: 1634b283-c538-907c-83db-ad6bd99402bb
Content: Switch to Microsoft Defender for Endpoint - Setup
Content Source: microsoft-365/security/defender-endpoint/switch-to-mde-phase-2.md
Product: m365-security
Technology: mde
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

@antonov314 Thank you for your feedback. I was able to navigate to the device groups section as described in the document.

If this still does not work, there could be permissions issues. I'd recommend you contact the support via the need help section on the admin center to troubleshoot further.
Hope this helps!
Thanks
Sri

HI, Thanks for your reply.
The issue I had was related to Microsoft changing the License. You need a
Pay License for this part of the website to see...... they changed it
recently
i tried with my Dev account where I should be able to see it but it
doesn't work....
Also the steps mentioned in the Guide on the website were incorrect...
Op wo 23 mrt. 2022 om 05:28 schreef Sriraman M S @.***>:

@antonov314 https://github.com/antonov314 Thank you for your feedback.
I was able to navigate to the device groups section as described in the
document.
[image: image]
https://user-images.githubusercontent.com/45987684/159623922-a7dc380d-4061-4467-9f70-e3da0d86a1d8.png
If this still does not work, there could be permissions issues. I'd
recommend you contact the support via the need help section on the admin
center to troubleshoot further.
Hope this helps!
Thanks
Sri
—
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/microsoft-365-docs/issues/8022#issuecomment-1075902659,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATD5SLMIGLJQ3XPJECRYNNDVBKMWLANCNFSM5QZUS47A
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Met Vriendelijke groet,
Lars Schretlen

@antonov314 Thank you for the response. You are right, you need a paid license for this to work. Let me know if there is anything in specific that you would like correct in the document.
Thanks
Sri


Issue with accessing json value of key in WebHelpers.ParseJson

Hi,
I am trying to parse a json response from web service like below.
Dim Json As Object
Set Json = WebHelpers.ParseJson ("{""a"":123,""b"":[1,2,3,4],""c"":{""d"":456}}")
I would like to print out the value of key 'c' ie {""d"":456}.
But when I try to access it like MsgBox Json("c"), I am getting an argument not optional error. I cannot specify the key to get the elements as the key in response varies from time to time.
It would be great if any body can help me figure out how to get this done.

Hi @mithunmanohar79, ParseJson parses recursively so {"d":456} has been parsed into a Dictionary and you can use Keys/Items to get the keys/values out of it. If you want to print the whole Dictionary out, you can use MsgBox WebHelpers.ConvertToJson(Json("c")) which converts the Dictionary back into a json object string.

Thanks @timhall for your quick reply !

Hi @timhall - a question relating to this subject - I have a fairly extensive json response that I've parsed into an object in which I'm trying to build a multidimensional array - this might be my clumsiness with dictionaries, but I can't seem to traverse the keys that are nested in an collection within the dictionary.
Below is the example response: - I need to grab the keys inside of "C" but I can't get past "B".  "B" is an array of objects in which there will be several "C"s to extract.
Thanks for your advice in advance!
{
   "A":{...},
   "B":[
      {
         "C":{...},
         "D":{
            "E":[...]
         },
         "F":{...}
      },
      {  }
   ]
}


Check an exampleContext.xml into the repo, update README.md

We would like to fulfill the app configuration requirements for #75. I suggest checking in an example context.xml into the repo and updating the README.md with instructions on how to put the example context.xml on the container.

We will add the context.xml lines that need to be in there to the readme with production dependancies to be complete, lets not check in a complete context.xml.

Well, we definitely shouldn't check in a file called 'context.xml' in the META-INF dir, but why not check in a file called 'exampleContext.xml' with sensible defaults that someone can just copy to their server?

There are two things to keep in mind here:

Checking in the exampleContext.xml can oftentimes be confusing as it gets out of date (mostly on me for lazily forgetting to update it)
We definitely want to make sure to remove configuration that doesn't specifically apply to this application.  This has been confusing on GDP in the past as the configuration didn't make it clear which application it applied to.

I prefer putting this kind of information in the README.md. I agree that including an exampleContext.xml frequently gets out of date. Of course it can also get out of date in the README.md, but at least this is something that we frequently see. We have used this successfully on a couple of Flask apps (pubs and wqp).

@jiwalker-usgs

Checking in the exampleContext.xml can oftentimes be confusing as it gets out of date (mostly on me for lazily forgetting to update it)
I agree. I need to point out that it is even more confusing for newcomers, be they internal or external, to have a total absence of example configuration. Starting with an out-of-date document is almost always easier than starting from scratch.

We definitely want to make sure to remove configuration that doesn't specifically apply to this application. This has been confusing on GDP in the past as the configuration didn't make it clear which application it applied to.
I agree. So far no one suggested checking in irrelevant configuration, but I am glad you reminded us so that we nip that potential problem in the bud. Mixing of concerns has definitely bitten us in the past. Namespacing the jndi var names can help a lot.

@mbucknell , you raise a great point. I'm sold. Let's stick it in the readme.

Pull request #79 has been merged, so I'm going to close this issue.


Copy Planner Plan updated to work with CLI v5.4.0

Because there is a new CLI version, following adjustments were made:

Copy priority of task as well
Removed deprecated command m365 planner task details get
Removed conversion method to convert date to valid ISO string (this has been fixed)

Thank you for updating the sample, appreciated 😊- this should be live shortly 🎉


[GSSoC - 23] Feat: Personalized Notifications.

Issue
Hey, @roshan1337d
I am back with my notification obsession 😂, I would like to add an amazing UX-enhancing feature to this coding-contests-companion bot.
Where the user could choose which platforms he wants to get notified for.
Current Behavior
Right now the user could either get notified for all of the platform contests or none of them.
Possible Solution
We could provide the user options in the Notification Embed to choose the platform, but reacting to the Embed.
Possible Implementation
Will add more, soon

:bulb: Request: Please assign this issue to me, additionally please help out with the yml issue templates added recently, I am new to them, or I can continue with Markdowns.

Can you please assign me this issue under GSSOC'23?

Actually, I am already applied for the issue, as it's based on First Come first serve basis.
But still we can wait for PA to choose one of us🙂

@JatinSharma32 ya okay.

@JatinSharma32 assigned it to you!
But I would suggest some changes to your idea:

Replace get notified and stop notifications buttons with opt-in for all, and opt-out of all. Make those buttons blue and red, and in a separate row. For all other platforms make those buttons as toggle buttons (opt-in with 1st click, opt-out with 2nd click). Add those buttons in new rows of same message, don't use different message. You can add upto 25 buttons to a single message.

A different role for each platform would make it difficult to setup for server admins. So you will need to improve setup-contests command to auto-create the roles instead of asking which ones to use. The stop command should also be modified to delete those roles at end.

Good luck 🚀

sure

I am sorry, I am not getting enough time to work on it, please reassign this issue to some one else

@JatinSharma32 Alright, no problem 👍
The issue is open for reassignment.

@roshan1337d  is it open ? i would like to work on it

Kindly assign this to me , I love to work on this

Hi @dashroshan I am looking forward to work on this new feature introduced by JatinSharma32.

Hi @dashroshan, can you please assign this issue to me under GSSoC'24?


Some questions about the correct workflow

Hey, I saw most of the issues are now solved :)
I have a few questions about the workflow of RRF:
On initial start, we have smth like this:
rrf: {
  user: {
    firstName: "",
    lastName: ""
  },
  forms: {
    user: {
      firstName: {...}
      lastName: {...},
      $form: {...}
    },
    $form: {...}
}

1) So, rrf.user is a model, which values are updated when the form inputs are updated. rrf.forms.user is the created form with this model and rrf.forms.user.$form object has the form state (errors, etc).
If this is correct, why aren't the values in rrf.forms.user.$form.value changed on field change?

State
rrf: {
  user: {
    firstName: "hey",
    lastName: "ho"
  },
  forms: {
    user: {
      $form: {
        value: {
          firstName: "", <-- why
          lastName: "" <-- why
        }
      }
    }
  }
}

2) What is the purpose of rrf.forms.$form, what are the values focus, pending, etc inside of it for? There is also rrf.forms.$form.value.user.firstName value, that is also not updated when the input is changed.

I'll be adding this to the documentation soon (well, after the holidays)!

hey @davidkpiano , maybe you could drop 1-2 small sentences about, I just wanted to understand the purpose.
I am planning to fully move to RRF for quite some time, but still need a few answers.

Sure, no problem. I'll do that today. For now, I'll answer your questions directly:

So, rrf.user is a model, which values are updated when the form inputs are updated. rrf.forms.user is the created form with this model and rrf.forms.user.$form object has the form state (errors, etc).

This is correct.

If this is correct, why aren't the values in rrf.forms.user.$form.value changed on field change?

They should be - I'll fix this.

What is the purpose of rrf.forms.$form, what are the values focus, pending, etc inside of it for?

The forms.$form indicates the entire form state, so focus would represent if any field in the form is focused, same with pending, touched, etc.

Since no one asked for this, we can probably close it.
The only question remaining for me is the 2 - What is deep.forms.$form for and it fields (focus, pending, etc), is it the state of all forms or just unused props?

is it the state of all forms or just unused props?

They reflect the state of all fields from this form, and the form itself.

@davidkpiano , nah, there is no form for it.
I have only 1 form - named login, so I have deep.login as model and deep.forms.login as form. There I have deep.forms.login.$form with the form state.
What I'm asking is - deep.forms.$form, it's like a global $form for all forms, what's the state there for 🤔

It's even written there - model: "deep", but I don't have such model 🤔