UseDrag action-sheet example not working for v10

Supplied example in use-gesture docs

https://codesandbox.io/s/github/pmndrs/use-gesture/tree/v10/demo/src/sandboxes/action-sheet
When dragging throws this error:
TypeError
Cannot destructure property 'Symbol(Symbol.iterator)' of 'undefined' as it is undefined.
  22 | const bind = useDrag(
> 23 |   ({ last, vxvy: [, vy], movement: [, my], cancel, canceled }) => {

The issue also occurs when running locally

Information:

React Use Gesture version 10
OS: MacOS 10.14.6
Browser Chrome 94

Indeed, thanks for pointing this out, vxvy is removed in v10 in favor of velocity which is now a vector. I've updated the repo, should be fixed now.


Android hiding items after dragging a few times

Hey @computerjazz
First of all, crisp component - its super awesome to work with! Well on iOS at least :( After implementing this, i noticed that some of my items started to dissapear after dragging them a few times. Then i figured out they would just lay below other list items.
Afterwards I replicated this in the example code
Steps to replicate
Drag several times, possibly if you drag an item several spots towards the top.
Screenshot

Tested on a Huaweii P20 Lite
Setup
"react-native": "0.59.2",
"react": "16.8.3",
"react-native-draggable-flatlist": "^1.1.7",

What the solution ? @icew1nd

I have noticed same issue on Windows app as well. #48 (yet to merge) resolved the issue.

@leenakhaled never Solved it im afraid - had a bit of a weird usecase so ended up rendering a regular flatlist until going into edit mode where i made my own (not as this fast rendering draggable list) but it signifantly improved rendering times in the end anyway

@npmun #48  is not ideal as it shifts everything by 1px.
I've rewritten this pkg to be more robust, please check out #81 and see if it fixes your issue. I'm just waiting on the corresponding reanimated release before I publish.

@icew1nd We are probably looking at two different issues with similar symptoms. It was very easy for me to recreate before adding 1px offset and fix definitely resolved the issue. Please note that I was only testing example code in this repository (not in the actual app)
@computerjazz I will test V2 this evening and let you know how it goes.


IOS-XE and NX artifactory URLs?

XR has useful artifactory links to download images at, is there an equivalent for XE and NX? There are miscellaneous images of CSR 1000v etc. but I do not see an official location.
Does anyone know of official locations for IOS-XE and NX virtual ISOs / Vagrant box files?
Also, thank you for distributing Vagrant box files alongside ISO files - it is incredibly useful.

@remingtonc we are looking at providing better and more consistent delivery for artifacts, and specifically Vagrant boxes for different platforms.  Stay tuned!

looking forward to that XE vagrant box! Especially if you had some basic topologies for CI/CD testing like with NSO and APIC-EM automation testing.


Unable to use OpenId Connect and Jwt Bearer together in ASP.NET Core 2.1. Error The authentication handler registered for scheme 'Bearer' is 'JwtBearerHandler' which cannot be used for SignInAsync

I have a scenario where:

I have some API endpoints which for I need to use JWT Bearer Token.
For other MVC UIs I need to use OpneId Connect.

The API part is working, however I'm getting following error when I hit the MVC action method which has [Authorize] attribute on it.:
System.InvalidOperationException: The authentication handler registered for scheme 'Bearer' is 'JwtBearerHandler' which cannot be used for SignInAsync. The registered sign-in schemes are: Cookies.
   at Microsoft.AspNetCore.Authentication.AuthenticationService.SignInAsync(HttpContext context, String scheme, ClaimsPrincipal principal, AuthenticationProperties properties)
   at Microsoft.AspNetCore.Authentication.RemoteAuthenticationHandler`1.HandleRequestAsync()
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

Here's my start up:
 public void ConfigureServices(IServiceCollection services)
        {
          // other code
            services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
                .AddOpenIdConnect(OpenIdConnectDefaults.AuthenticationScheme, options =>
                {
                    options.Authority = $"{Configuration["Oidc:Instance"]}/{Configuration["Oidc:Doamin"]}/v2.0/";
                    options.ClientId = Configuration["Oidc:ClientId"];
                    options.CallbackPath = Configuration["Oidc:CallbackPath"];
                    options.ResponseType = OpenIdConnectResponseType.IdToken;
                    options.TokenValidationParameters.ValidateIssuer = true;
                })
                .AddCookie()
                .AddJwtBearer(JwtBearerDefaults.AuthenticationScheme, options =>
                {
                    options.TokenValidationParameters = new TokenValidationParameters
                    {
                        ValidateIssuer = true,
                        ValidateAudience = true,
                        ValidateLifetime = true,
                        ValidateIssuerSigningKey = true,
                        ValidIssuer = Configuration["Jwt:Issuer"],
                        ValidAudience = Configuration["Jwt:Issuer"],
                        IssuerSigningKey = new SymmetricSecurityKey(Encoding.UTF8.GetBytes(Configuration["Jwt:Key"])),
                    };
                    options.ForwardSignIn = OpenIdConnectDefaults.AuthenticationScheme;
                    options.ForwardSignOut = OpenIdConnectDefaults.AuthenticationScheme;
                });
    // other code

I assumed options.ForwardSignIn whould forward the SignInAsync to OpenId but it doesn't.
Is there any other way?

Your problem is here
AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
You're telling the authentication layer to use JWT for everything, signin, signout, etc. JWT doesn't have an interactive signin or signout.
So, switch it around, the default should be OpenID, and then for your API areas either forward from the ODIC pieces, or use the Scheme parameters in the authorize attribute, or inside your policies.


Is it possible to add another locale and translations without doing it in the package source code?

Hi,
Is it possible to add another locale and translations without doing it in the package source code?
I need to support another locale in my app but didn't want to download source code and use a local package if possible.
Thank you!
Karl

Hi!
Hope everything is going well for you. Yes, it's possible to do so. Please see https://github.com/kekland/croppy/blob/master/doc/localization.md and https://github.com/kekland/croppy/blob/master/example/lib/localization_override_example.dart for an example of how to do so.
If there are further questions feel free to reopen this issue.


Wrong references in change model

Change models refer to the original DocBook models but the URIs are wrong.
For instance, in random10-single-1, the refered docbook is ../random10.docbook but the file is located one folder above, the correct URI should be ../../random10.docbook.

Hi,
I think there is also another kind of issue in change model. References to model elements seem incorrect in addition to incorrect references to URI.
In the same model (random10-single-1), I think the affectedElement is incorrect. I guess the affectedElement should be se2 while 09a6ddf5-620b-433f-a14e-0e72648d4db7 should be the id of the `deletedElement' (omitted here).
Regards
Valentin

@TheoLeCalvar oops, I'll look at this now!
@ValentinBesnard that is actually the intended behaviour - the event is saying that a certain element within the containment reference was deleted. Therefore, the container was affected by having a child object be deleted.

Fixed the relative paths issue. On second thought, you might be on to something @ValentinBesnard about the change events. I'll look at this again.

See the pull request

Maybe it can be useful to also add: change.setDeletedElement(<the element to remove>);
to have both the affectedElement and the deletedElement

Yep, I did that. I also fixed a silly mistake with single-valued containment refs.


authorizing nil object

Hi
say i have an update function of Sample with

authorize @sample, :update?

sometimes @sample is nil, because the client sent non existing sample id.
how can I render an error message and not crash with exception of
"unable to find policy of nil" ?
thanks a lot

Maybe use a null object?

hi and thanks. yes, i can "check" for nil in many ways, but if it is nil, what should i "authorize" ? (as i must authorize something)
thanks again

@dowi What @ingemar is saying is that you can use a null object, that is, a NullSample object that implements update and always returns false. It could even be a generic object NullObject that you use in other controllers too, and you could have a NullObjectPolicy that returns true or false for all actions, based on what makes sense in your application. Since Pundit infers the policy form the object, your action will be properly authorized.
# Model
class NullObject
  def update
    false
  end
end

# Policy
class NullObjectPolicy
  def update?
    false
  end
end

# Controller
@sample = Sample.find_by(id: params[:id]) || NullObject.new
=> @sample


[Spanner] credentials object not passed into InstanceAdminAPI

Hi Folks,
I don't see that the credentials I pass into the Spanner Client are being used for the InstanceAdminClient or DatabaseAdminClient instantiations.  I'm chasing a downstream bug and will fill in details soon, but from what I see, defaultcredentials are assumed to be used when using those APIs, whereas it should use the provided credentials object.

OS type and version
CentOS
Python version and virtual environment information python --version
Python 2.7.9
google-cloud-python version pip show google-cloud, pip show google-<service> or pip freeze

gapic-google-cloud-spanner-admin-database-v1==0.15.0
gapic-google-cloud-spanner-admin-instance-v1==0.15.0
gapic-google-cloud-spanner-v1==0.15.0
google-auth==0.8.0
google-auth-httplib2==0.0.2
google-cloud-core==0.23.1
google-cloud-spanner==0.23.1
google-compute-engine==2.3.2
google-gax==0.15.6
googleapis-common-protos==1.5.2
grpc-google-iam-v1==0.11.1
grpcio==1.1.3

Stacktrace if available
Steps to reproduce

Create credentials with a service account.  Make sure default credentials will fail.
Try to interact with an instance.

Code example

import google.auth.credentials
from google.cloud import spanner
from google.oauth2 import service_account
SPANNER_ADMIN_SCOPE = 'https://www.googleapis.com/auth/spanner.admin'
JSON_KEY='/home/me/keys/mykey.json'

credentials = service_account.Credentials.from_service_account_file(
                JSON_KEY)
scopes = [ SPANNER_ADMIN_SCOPE ]
credentials = credentials.with_scopes(scopes)
# credentials = google.auth.credentials.with_scopes_if_required(credentials, scopes)
sc = spanner.Client(project='my-project, credentials=credentials)

i = sc.instance('my-instance', configuration_name='regionally-us-central1')
i.exists()

I checked these sites before filing:

https://github.com/GoogleCloudPlatform/google-cloud-python/issues
http://stackoverflow.com/questions/tagged/google-cloud-python

Thanks for raising this issue. It looks like a bug; we will look into it soon.

On this now.


Hard drive storage stats

Feature request to add hard drive storage stats. ie. free space & total

Just wanted to submit exactly the same request. :)
While working on VPS, the most insufficient resource is not cpu/mem/swap.  Instead, it is a free space on the storage device.


Tests become broken as optional parameters are required

After requiring this package in composer and running tests I noticed that many of them became broken as calls expectations changed. For example if I have a function
getFirstWhere($arg1, $arg2, $arg3 = []) and I set my expectation to $mock->getFirstWhere('arg', 'arg2') I get the error saying that expectation was not met because there was a call to $mock->getFirstWhere('arg', 'arg2', [])(notice the empty array at the end). Not sure what is the reason of that. Example log:
  39  - it returns list of sample messages
      method call:
        - getAllWhere("client_id", 5, [])
      on Double\ClientServicesRepository\ClientServicesRepository\P82 was not expected, expected calls were:
        - getAllWhere(exact("client_id"), exact(5))

So basically I call in my real code getAllWhere("client_id", 5) but somehow it takes the optional parameters into an account.

Thank you for reporting this issue. You observed a side effect of my hack to make Prophecy support pass-by-reference. It was such a hack and upstream is reluctant to support that anyway. So before I dig deeper into that rabbit hole, I decided to drop pass-by-reference completely. Please update to php-mock/php-mock-prophecy-0.0.2.
If one needs mocking functions with pass-by-reference go to another framework, e.g. php-mock-phpunit,


implement aws recommended alarms for managed opensearch

as per the documentation here

Made the change to disable and override alarms. Test plan: https://app.terraform.io/app/sph/workspaces/platform-eng-logging-base-dev/runs/run-8m6PaZ3zz2hk9JE8


Support to drop multiple tables at once

Allow to drop multiple tables at once as it is supported in PostgreSQL:
DROP TABLE tbl1, tbl1;

https://www.postgresql.org/docs/current/sql-droptable.html

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

See https://github.com/crate/crate/discussions/11655#discussioncomment-1200698 for some info on what it would take to implement this.

Could this issue be assigned to me? I would like to make an attempt to it and make my first ever contribution to an open source.

I actually have something WIP for this.

hi , if this issue is still open i would like to take it up

Hi @DHRUV6029, sure, thanks for your interest!
Assigned it to you.

Thanks

Hi, A question these drop statement should be Atomic right ? if one fails the operation rollbacks to prev state

A question these drop statement should be Atomic right ?
Good point, thanks for raising it. I don't think so, see below.

if one fails the operation rollbacks to prev state
let's say we dropped table t1 with some records and for whatever reason couldn't drop table t2.

Rolling back would mean that we need to restore table t1 with all records.


Hand Indexer Usage

Just wondering how is the hand indexer being used and if it is actually required? I'm building the lib for use with WASM and getting a bunch of C compiler errors when targeting wasm32-unknown-unknown. the issues seem to be compiler errors (possibly relating to clang version and wasm or general rust+C+WASM interoperability) rather than an issue with this lib. I'll look into fixing those but in the meantime I couldn't see how the hand indexer is being used?

If it is used but only for non-core functionality (evaluator and equity calc), perhaps we could enable it via a feature?

Hand Indexer isn't used for the equity calculation.  It's instead used for card abstraction in the actual poker solver.  It maps isomorphic hands into the same index with no holes so AhKh maps to the same index as AsKs preflop.
I think you're right enabling it via a feature could be a good solution.  I'll look into that as well as the C compiler errors that you're getting

I've been looking around and it seems like there is no way to compile rust -> wasm with a static c library.
So I've created a workspace and moved hand_indexer to its own module which can be enabled with a feature.  I've also made a few other changes.
I'm new to features so take a look and let me know

Another thing, the cargo build now generates the entire hand evaluation table.  The idea is the you can serve these as assets to your web app so they can be found on the client side by your wasm module

very nice! I ran into a couple of issues when trying to get it working with WASM:

local file system operations aren't supported so it panics when trying do File::open
the equity calc uses crossbeam which results in an "operation not supported on this platform" error due to lack of threading support with WASM

I played about and got it working by not using crossbeam when on WASM and generating the evaluation table at runtime. It'd be cool to get it working with WASM but I think it might need too many changes and might make the code a bit horrible by littering it with all sorts of platform arch checks? I did also get this deployed as a Lambda function and it worked perfectly!

I agree, I think using a lambda function or querying a rust web server is the way to go.  Building the evaluation table may take too much time and use too much memory, and even if you could get the wasm to load the files that would mean the client has to download a ~200kb file

Hi, just a question. I just had a question about how indexer gets used by evaluate. I'm looking through the code and I still can't find how evaluate uses hand_indexer. I tried to rebuild the code by getting rid of all the references in both cargo.toml files and the lib.rs file in source. Am I missing something? I'm new to rust.


Compatibility with latest networkx and pandas

Fixes Issue #84 and Issue #80

Thank you for the work on this.
Is this problem going to be fixed? Now the nextworkx has upgraded into 2.7.1. I think it would be good to have mordred compatible with the latest version of networkx, which potentially resolves a lot of problems.  Thank you.
I would love to help, but I don't have the access to merge the PRs.
@philopon @UnixJunkie @hirotomo-moriwaki @mkrompiec

@mkrompiec @Kastakin I have cherry-picked these changes over on mordred-community and released an updated package on PyPI: pip install mordredcommunity


ERROR: Signature extraction failed

[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['https://www.youtube.com/watch?v=Ix8ocFEMa1o', '--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.6 - Linux-3.13.0-39-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: avconv 9.16-6, avprobe 9.16-6, ffmpeg N-74748-gbaeb8f5, ffprobe N-74748-gbaeb8f5, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] Ix8ocFEMa1o: Downloading webpage
[youtube] Ix8ocFEMa1o: Extracting video information
WARNING: unable to extract html5 player; please report this issue on http://yt-dl.org/bug
[youtube] {22} signature length 41.40, html5 player None
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 603, in _decrypt_signature
video_id, player_url, s
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 499, in _extract_signature_function
raise ExtractorError('Cannot identify player %r' % player_url)
ExtractorError: Cannot identify player u'https://s.ytimg.com/yts/jsbin/player-en_US-vflJENbn4/base.js';

+1
I'm getting the same error at least since yesterday for any youtube video.

Same error for me since morning on OS X 10.11 Yosemite.
Updated twice, still same. Error logs follow for a video that I had downloaded 3 days ago as well.
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', 'https://www.youtube.com/watch?v=uxpDa-c-4Mc']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.11.02
[debug] Git HEAD: cd9895d
[debug] Python version 3.4.2 - Darwin-15.0.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 2.5.2, ffprobe 2.5.2
[debug] Proxy map: {}
[youtube] uxpDa-c-4Mc: Downloading webpage
[youtube] uxpDa-c-4Mc: Downloading video info webpage
[youtube] uxpDa-c-4Mc: Extracting video information
WARNING: unable to extract html5 player; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[youtube] {22} signature length 41.40, html5 player None
ERROR: Signature extraction failed: Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflJENbn4/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflJENbn4/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflJENbn4/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflJENbn4/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/YoutubeDL.py", line 661, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/common.py", line 290, in extract
    return self._real_extract(url)
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 1345, in _real_extract
    encrypted_sig, video_id, player_url, age_gate)
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 827, in _decrypt_signature
    'Signature extraction failed: ' + tb, cause=e)
youtube_dl.utils.ExtractorError: Signature extraction failed: Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 817, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/lib/python3.4/site-packages/youtube_dl/extractor/youtube.py", line 709, in _extract_signature_function
    raise ExtractorError('Cannot identify player %r' % player_url)
youtube_dl.utils.ExtractorError: Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflJENbn4/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Cannot identify player 'https://s.ytimg.com/yts/jsbin/player-en_US-vflJENbn4/base.js'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Version 2015.11.10 adapted to the new YouTube player. As you can see in your output, you are using an outdated version of youtube-dl. See our FAQ if you need help updating.


convert from MQTT to CAN

Hi
Is there a simple way to convert from MQTT to CAN? (The opposite of this package)
Thanks,
Adel

Hi, this is more of a question than it is an issue. But yes this is possible. This package is a bidirection can <-> MQTT Bridge not an one way converter ;-)


Upgrade to embedded-hal 1.0.0-alpha.6

This PR updates everything to embedded-hal 1.0.0-alpha.6. 1.0.0 is around the corner so those traits are more less what to expect from v1.0.
This version also adds CAN traits. So this is prerequisite for adding CAN support with https://github.com/esp-rs/esp-idf-hal/pull/27.

I assume, once we migrate to alpha6, it would still be possible to use crates that depend on embedded-hal V0.2 via the embedded-hal-compat crate?
If you can confirm that?
The background of my question is that there are gazillion of LED drivers in the embedded-graphics ecosystem, that currently depend on embedded-hal 0.2 and I don't see them migrating overnight once 1.0 is released. On the other hand, I don't want that we are losing compatibility with them.

Basically, we need at least reverse compatibility for GPIO, I2C and SPI.

I will look into embedded-hal-compat.
At the moment I am still working on CAN. If this is finished then I'll check how to deal with backwards compatibility.

I will look into embedded-hal-compat. At the moment I am still working on CAN. If this is finished then I'll check how to deal with backwards compatibility.

I assume not 'if' but 'when'. :)
Also, forgot to say - thank you for this contribution! I don't really expect compatibility issues by utilizing the compat crate - just something we should check before merging.
Let me know once you think this diff would be ready for merging.

I looked into embedded-hal-compat. It indeed allows to use 0.2 drivers. Tried with st7789:
use display_interface_spi::SPIInterfaceNoCS;
use embedded_hal_compat::ReverseCompat;

let config = <spi::config::Config as Default>::default()
    .baudrate(26.MHz().into())
    .bit_order(spi::config::BitOrder::MSBFirst);

let di = SPIInterfaceNoCS::new(
    spi::Master::<spi::SPI2, _, _, _, _>::new(
        peripherals.spi2,
        spi::Pins {
            sclk: pins.gpio18,
            sdo: pins.gpio19,
            sdi: Option::<gpio::Gpio21<gpio::Unknown>>::None,
            cs: Some(pins.gpio6),
        },
        config,
    )?
    .reverse(),
    pins.gpio27.into_output()?.reverse(),
);

let mut display = st7789::ST7789::new(
    di,
    pins.gpio23.into_output()?.reverse(),
    // SP7789V is designed to drive 240x320 screens, even though the TTGO physical screen is smaller
    240,
    320,
);

Notice .reverse() here and there. This makes 1.0 traits compatible with 0.2.
Essentially esp-idf-hal itself is not going to use embedded-hal-compat, it must be used on application side.

Essentially esp-idf-hal itself is not going to use embedded-hal-compat, it must be used on application side.

That should be fine.

@ivmarkov, it should be now ready for merge.

@andresv Before merging this PR, I would like to at least announce that this is coming at our regular ESP32 meeting. And probably solicit some feedback, as to e.g. what are the plans in relation to embedded-hal versions for the bare-metal HAL crate (esp32-hal) (@MabezDev @jessebraham - ping). Not that we have to absolutely be using the same embedded-hal version across bare-metal and ESP-IDF HALs, but would be good to be working towards a common vision.
Fortunately, the next meeting is just behind the corner - Jan 04. Since it is open for everyone, you can attend too - that is - if you wish, given that you have a stake in this development.
Please ping me on the Matrix channel in private, so that I can forward you the meeting.
By the way - in addition to CANBUS support - there is now one more reason - albeit minor - to migrate to alpha6/1.0: The ADC support that I just landed cannot be implemented for 'degraded' pins (GpioPin<>), because in V0.2, adc::Channel::channel() does not take &self. They've fixed this in post V0.2 releases :)

@andresv Before merging this PR, I would like to at least announce that this is coming at our regular ESP32 meeting. And probably solicit some feedback, as to e.g. what are the plans in relation to embedded-hal versions for the bare-metal HAL crate (esp32-hal) (@MabezDev @jessebraham - ping). Not that we have to absolutely be using the same embedded-hal version across bare-metal and ESP-IDF HALs, but would be good to be working towards a common vision.
Fortunately, the next meeting is just behind the corner - Jan 04. Since it is open for everyone, you can attend too - that is - if you wish, given that you have a stake in this development.
Please ping me on the Matrix channel in private, so that I can forward you the meeting.
By the way - in addition to CANBUS support - there is now one more reason - albeit minor - to migrate to alpha6/1.0: The ADC support that I just landed cannot be implemented for 'degraded' pins (GpioPin<>), because in V0.2, adc::Channel::channel() does not take &self. They've fixed this in post V0.2 releases :)

@ivmarkov, take a look, errors are now handled as you proposed.

@ivmarkov, take a look, errors are now handled as you proposed.

Sorry for the delay, I've been busy in standing up a new branch, where your alpha6 + canbus code is in, but additionally, this branch would simultaneously support embedded-hal alpha6 and embedded-hal 0.2. Why?

The statement that embedded-hal 1.0 is "just around the corner" wasn't accepted that well :). Seemingly it has been "just around the corner" for an year and a half now, with 4 issues still unresolved (I thought it is one, but they are really 4)...
The 'compat' crate has incomplete support for reversing, i.e. not all 0.2 traits are supported
Folks just feel uneasy that we'll put an extra burden on our users in the form of an additional crate

Anyway. Work progressing nicely, I have i2c, spi and adc done that way, gpio and delay remaining.
But in the meantime... have you seen this?

Merged into https://github.com/esp-rs/esp-idf-hal/tree/embedded-hal-1-compat


simple update to change that the way that panels are built.

The way that react panels are generated are not flexible enough.
I added several classes to handle the different parts of a panel to make it easier use the parts of a panel you wish to display.

Coverage remained the same at 94.07% when pulling 186cbd32637a218f05e3e83e4c90362bc5d3a0c0 on refactor-react-panel-display into 0e06c06edec3f57e9c2b1781d8e428a929098b9a on phase2.

When I load this form I get a number of warnings from react about invalid props.

Coverage remained the same at 94.07% when pulling bc0c6bcc65fe8ed8efe77bbb10d37b81e0ae0fc2 on refactor-react-panel-display into 0e06c06edec3f57e9c2b1781d8e428a929098b9a on phase2.

Coverage remained the same at 94.07% when pulling 7e45e27edccbeab3cf6f96a8843056573b41dc02 on refactor-react-panel-display into 0e06c06edec3f57e9c2b1781d8e428a929098b9a on phase2.

:+1:

Coverage remained the same at 94.07% when pulling 9d5516956f1c898a915978d17243ffcb312768db on refactor-react-panel-display into 0e06c06edec3f57e9c2b1781d8e428a929098b9a on phase2.


Change Logic Behind # of Payloads Executed

🐛 Summary
When a report is generated, the value attached to "payloads executed and connected to the CISA team's command-and-control C2 server (Not Blocked)." counts both border protection and host protection Not Blocked's, when it should only count the host protection Not Blocked's.
To reproduce
Steps to reproduce the behavior:

Generate a test report
Scroll to the section "Phishing Controls Assessment"
Locate value associated with total payloads executed and compare with all Not Blocked's in the Host Protection Column of the chart below

Expected behavior
What did you expect to happen that didn't?
We expected the total payloads executed value to match the total number of Not Blocked's in the Host Protection Column of the payloads.
Any helpful log output or screenshots
Paste the results here:
Contact PCA Analysts for more information
Add any screenshots of the problem here.

Also in this paragraph, can we change "complicit user's inbox (in spam)" to "complicit user's mailbox" ? I don't think that "in spam" bit is dynamically generated from the JSON, and as such, this sentence likely won't be true for all users.


Incorrect/unhelpful link

The article includes this paragraph:
Global navigation in the SharePoint app bar must be enabled in order for SharePoint resources to display in the Microsoft Teams app bar for Viva Connections.
where "Global navigation in the SharePoint app bar" is a hyperlink. I assumed that hyperlink would educate me about what I need to do to enable the global navigation, BUT the hyperlink just points to the same page which provide no value and wastes time. Please correct this to provide a link that explains to people how to enable global navigation. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7210783d-e96e-9d14-9120-553f731d20ed
Version Independent ID: 84854221-f26b-4a19-b95e-0d5d7c640a46
Content: Add Viva Connections desktop to Microsoft Teams - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/viva-connections.md
Service: sharepoint-online
GitHub Login: @Holland-ODSP
Microsoft Alias: hokavian

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Thanks for your entry @JAndre7 , I just fixed this


Fix tokenization tests on GPU

Description

Move all tensors to the correct device in tests
Move new tensor to correct device in get_token_position()

Fixes #304
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have not rewritten tests relating to key interfaces which would affect backward compatibility

Thanks @rusheb !


[Question] Any plans to release llava-1.5 dataset?

Question
No response

The training data and scripts of LLaVA-1.5 are released here, and evaluation scripts are released here yesterday.


[docs] Improve SEO on titles

Before

After

Credit to @dtassone for the idea. Here is the search volume traffic in the US for each query:

I thought changing the translated files has no effect since crowdin will override it?

@eps1lon Oh yes, right! I have done the change with a regex search & replace. I didn't ignore the translation files.


Babel 7 support

Hello,
Babel 7 is behind the doors, and it comes with many nice improvements.
But it aswell comes with some deprecations. Babel 7 doesn't allow arrays as second argument to plugin.
.babelrc:
presets: [
    ['direct-import', ['...options...']]
]

This options has to be an object, not array.
You can find out how babel-plugin-lodash dealt with this:
https://github.com/lodash/babel-plugin-lodash
Thanks!

Hello @mcongy!
Thanks for heads-ups! I'll take a look at it in weekends.

Published as babel-plugin-direct-import@next.


Add requires.io

What kind of change does this PR introduce
This PR adds requires.io to the repository to track dependencies and stay up-to-date with all the dependencies.

What is the current behavior
There is no package in the repo to track dependencies.

What is the new behavior

Requires.io  automatically sends a pull request if a dependency of the project becomes out of date.
There is also a badge which tells whether the requirements of the repository are up-to-date or not.

Checklist for this PR

[x] I have read contributing guidelines.
[x] Updated the requirements (pip freeze > requirements/requirements.txt).
[N/A] Created new migrations (python webapp/manage.py makemigrations && python webapp/manage.py migrate).
[x] Pull request is towards develop branch.
[N/A] Documentation
[x] Ready to be merged.

you guys are sending  at awesome rate . ;-)

@rrmerugu  Do you know any other better packages than requires.io that does this task?


Fix validation log condition

coverage: 94.27% (+0.005%) from 94.265% when pulling 6f2ed712fadcb5561abb7273490fae80171f4db0 on validator-condition into da4b677baaa9259da7b51793195d37d716c116fc on main.

Related: https://github.com/medplum/medplum/discussions/2006


chore: pr-release: fix MESSAGE calculation

previously there was a logic bug where the check if a std tag exists
would override the result of whether a mathlib tag exists (both wrote
MESSAGE in both cases).
Now we only check for the mathlib tag if we found the std tag.

Sorry, missed this, and have already merged #3700.


Fails to highlight handlebars templates

My JS
    import hljs from 'highlight.js';     $(document).ready(function() {       $('pre code').each(function(i, block) {         hljs.highlightBlock(block);       });     });
My hbs template

{{> header}}

My header.hbs

Header Here

The output html is:

Header Here
 partial}}. But... Oh, I just saw that this issue is from 2018. Good, then at least I haven't broken anything ;-)
I'm not sure if she is expecting Handlebars to actually be executed, or if it actually was executed, or if just the header.hbs is highlighted.
As you said, "I'm confused, too".

And if that's NOT what she wanted then she'd need whatever type of escaping their is for handlebars, do you know the answer to that?

Escaping mustaches works by putting a backslash in front oft the mustache.
\{{> header}}

which incidentally is another case that is neither covered by the tests, nor working correctly with the current implementation. :-(

Isn’t that just a negative look ahead?

Assuming this one is likely fixed by all the new handlebars work (still in master though, not released).

Closing due to inactivity (we're cleaning out old stale issues that have likely been fixed).  If this is still a current reproducible issue please respond and we will happily re-open.


Crash when deleting first scanned document

Caught this when deleting my first scan before saving it.
Afterwards the app closes instantly when I try to open it.
FATAL EXCEPTION: main
Process: com.akylas.documentscanner, PID: 22200
com.tns.NativeScriptException: Calling js method onBindViewHolder failed
TypeError: Cannot read properties of undefined (reading 'id')
	at com.tns.Runtime.callJSMethodNative(Native Method)
	at com.tns.Runtime.dispatchCallJSMethodNative(SourceFile:1)
	at com.tns.Runtime.callJSMethodImpl(Unknown Source:100)
	at com.tns.Runtime.callJSMethod(SourceFile:1)
	at com.tns.Runtime.callJSMethod(SourceFile:2)
	at com.tns.Runtime.callJSMethod(SourceFile:3)
	at com.tns.gen.com.nativescript.collectionview.AdapterInterface.onBindViewHolder(Unknown Source:17)
	at com.nativescript.collectionview.Adapter.onBindViewHolder(SourceFile:2)
	at com.nativescript.collectionview.Adapter.onBindViewHolder(SourceFile:1)
	at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(SourceFile:1)
	at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(SourceFile:155)
	at androidx.recyclerview.widget.RecyclerView$Recycler.i(SourceFile:72)
	at androidx.recyclerview.widget.RecyclerView$Recycler.j(SourceFile:1142)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(SourceFile:6)
	at androidx.recyclerview.widget.i0.b(SourceFile:54)
	at androidx.recyclerview.widget.GridLayoutManager.C(SourceFile:99)
	at androidx.recyclerview.widget.LinearLayoutManager.s(SourceFile:49)
	at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(SourceFile:748)
	at androidx.recyclerview.widget.GridLayoutManager.onLayoutChildren(SourceFile:45)
	at androidx.recyclerview.widget.RecyclerView.s(SourceFile:61)
	at androidx.recyclerview.widget.RecyclerView.q(SourceFile:72)
	at androidx.recyclerview.widget.RecyclerView.n(SourceFile:91)
	at androidx.activity.j.run(SourceFile:246)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1231)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1239)
	at android.view.Choreographer.doCallbacks(Choreographer.java:899)
	at android.view.Choreographer.doFrame(Choreographer.java:827)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1214)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7924)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

@cafehaine sorry for the issue. Can you clarify what you did?

scan a document withh the camera
go back to main screen (list of documents)
delete the document
crash?

Scan a document, then on the capture edit screen hit the delete button
https://github.com/Akylas/com.akylas.documentscanner/assets/11913365/af0d0a99-85aa-4f3a-8109-b972eb211026

@cafehaine ok indeed i missed this one ! sorry yes it might break the app :( (you have a document without any page). You need to remove data from the app, is that ok with you?

That's fine with me, thanks :)

@cafehaine a new build is up which should fix your issue https://github.com/Akylas/com.akylas.documentscanner/releases/tag/com.akylas.documentscanner%2Fandroid%2Fgithub%2F1.1.3%2F8

Hi there 🙋♂
Same issue here.
I installed the app from F-Droid (Neo Store), launched it, took a first photo - and pressed the delete - button on the capture UI.
What I tried: Delete Application data, delete data & reinstall (two times), update with your new version, then delete data & launch again.
But the behavior didn't change.
As soon as I grant or deny the storage permission (which it asks for right after launch), it crashes instantly. But only after that.
Granting all permissions in advance didn't work either.
Again reinstalling the new version is also to no avail.

Maybe it has to do with my system:
Samsung Galaxy S8 (SM-G950F)
OS version: 9
Bootloader: G950FXXUCDVG4, VM: ART
Kernel: 4.4.111-21427293
Brand: samsung, Model: SM-G950F
Board: universal8895, Manufacturer: samsung
SDK
Target: 28, Min: 17
I debloated this device via adb shell "pm uninstall -k --user 0 <package_name> commands and removed almost everything related to both Samsung or Google - except needed system packages.
The device & (almost) all installed (F-Droid & GitHub) applications work like a charm and extremely fast. So that's not an issue.
However, I don't know if your Application depends on something that's no longer there after the debloat. Obsidian doesn't even start for example - even though VebView is still in place (oh right maybe because it's not up to date 🧐).
I tested on a second S8 with the new version you just provided - and avoided the delete button.
I found some issues while testing on the second S8 and will make separate cards for them.
Import -> click on "Restart" -> Message: Cannot read properties of undefined (reading 'getActivity')
The Export feature is a little broken:
Export to PDF -> click on "Open" or "Export" on any view -> Message: this.canvas.scale is not a function
After closing that dialogue, it hangs on "exporting" and doesn't react.
This comment is not finished yet.

@NA0341 sorry it still does not work. i will fix it. might also ensure it does not break the app on start

@NA0341 there is on thing i dont understand. Your issue is that now the app crashes on start, even if you uninstall/install the app ?
If so something is weird on your device. When you uninstall it should remove any app setting/data so the crash (which is due to a db thing the app does not like) should not happen again


Release azure-cli-appservice 0.1.1b2

Reviewers, please verify the following for this PR:

[ ] The PR title has format Release <component-name> <version>.
[ ] setup.py has been modified with the same version as in the PR title.
[ ] HISTORY.rst has been modified with appropriate release notes.
[ ] If releasing azure-cli or azure-cli-core, __version__ defined in __init__.py should also be modified to match.

Release of 'azure-cli-appservice' with version '0.1.1b2' successful. View at https://pypi.python.org/pypi/azure-cli-appservice/0.1.1b2.

GitHub release created. https://github.com/Azure/azure-cli/releases.


cloudShellPreDeploy.ps1: Need to connect to the correct AAD tenant before provisioning resources

Please provide us with the following information:

This issue is for:
- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Create new AAD tenant
Launch Cloud Shell and login to the corporate tenant (i.e. microsoft.onmicrosoft.com)
Execute cloudShellPreDeploy.ps1 and enter the tenant name that was created in step 1.

Any log messages given by the failure

Standard outputs

Expected/desired behavior

Admin user and app registration are created in the new AAD tenant

Actual behavior

Admin user and app registration are created in the tenant that was used to login to Cloud Shell.

Workaround
Before executing cloudShellPreDeploy.ps1, execute
Connect-AzureAD -TenantId <AAD_GUID>

OS and Version?

Not applicable

Versions

Not applicable

We can change this in the doc, thanks for the feedback.


The gather function fails to memoise some actions

Memorizing an action to compute a field of the HKD type t is done only when it's queried using hitchF. Because gather calls actions directly, evaluating gather can perform the action for a field up to 2 times (the field itself and as a dependency via hitchF.)
Unless it's going to be removed, I think one way to get rid of the duplications in gather is requiring a record of lenses to the field itself, like this:
newtype LensB t a = LensB
  { toVLLens :: forall g h. Functor g => (h a -> g (h a)) -> t h -> g (t h) }

class HasSelfLenses t where
    selfLenses :: t (LensB t)

gather :: (TraversableB t, HasSelfLenses t, Monad m) => TangleFT t f m (t f)
gather = btraverse (\l -> hitchF (toVLLens l)) selfLenses

HasSelfLenses is very ad hoc of course. I'm not very confident, but they seem to be related to Representable.
class RepresentableB (t :: (k -> Type) -> Type) where
    data Key t :: k -> Type
    bindex :: Key t a -> t f -> f a
    btabulate :: (forall a. Key t a -> f a) -> t f

Good point. barbies-th has AccessosB so I guess it's easiest to use it.


Cache primitive results in runtime.py

Fixed in commit https://github.com/usc-isi-i2/dsbox-ta2/commit/bf22083e87af05456c62fd22f75f4ac0af5fc5c7


MdDatepicker of angular material does not work with most recent version 1.7.7

I'm submitting a ...

[ x] bug report
[ ] feature request
[ ] other

Current behavior:
MdDatepicker stopped working on Angular Material with the most recent version of AngularJs 1.7.7
Expected / new behavior:
MdDatepicker was working on v1.7.5
Minimal reproduction of the problem with instructions:
https://codepen.io/anon/pen/jdGwLK?editors=1111
AngularJS version: 1.x.y
1.7.7
Browser: [all]

Thanks for the report. It seems the pen loads non-existing files from the Google CDN, doesn't it? All the AngularJS files return 404. If you upgrade AngularJS please make sure new URLs return expected files; it may take a while for the CDN to pick up a new release.
Now, for testing purposes (it's not the CDN!) the files should be available at https://code.angularjs.org/1.7.7/, similarly how there's a folder at https://code.angularjs.org/1.7.6/. Our deploy job failed so the files didn't get there, we're fixing it now.
In the meantime, you can take files from npm or unpkg.com which also hooks into npm, e.g. AngularJS itself is available at<EMAIL_ADDRESS>See the fixed Pen at https://codepen.io/mgol/pen/MLEGdj?editors=1111.
Is there anything else that doesn't work for you here?

@mgol I mainly reported it because in my current project after upgrading to 1.7.7 all datepicker stopped to work as well. But I can't do a reproduction repo for it. Will investigate further and will report back here

Files are now on https://code.angularjs.org/1.7.7/

Closing, since everything seems to work fine.
@dohomi, please open a new issue if you find problems with 1.7.7 and MdDatepicker.


Auto-end code blocks

I am not sure if this is an Atom feature or a language grammar feature (or both?) but Atom seems to enjoy adding closing syntax such as brackets, braces, and quotations when you type the opening equivalent. It would be pretty nice if this grammar could auto close code blocks that use "end" such as:
function name()
end

name = function()
end

for i=1, 10 do
end

for i, v in ipairs(t) do
end

for k, v in pairs(t) do
end

while true do
end

do
end

if true then
end

@karai17 As far as I know this is all handled by https://github.com/atom/bracket-matcher and not the language-lua package.

I think we should wait for https://github.com/atom/bracket-matcher/issues/6


f

Thank you for contributing to naz.
Every contribution to naz is important.
Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.
Now,
What(What have you changed?)

Why(Why did you change it?)

References:

Codecov Report

Merging #122 into issues/67 will increase coverage by 0.07%.
The diff coverage is 13.95%.

@@              Coverage Diff              @@
##           issues/67     #122      +/-   ##
=============================================
+ Coverage      82.29%   82.36%   +0.07%
=============================================
  Files             13       13
  Lines           1231     1236       +5
=============================================
+ Hits            1013     1018       +5
  Misses           218      218

Impacted Files
Coverage Δ

naz/client.py
76.15% <13.95%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e28a670...1ea8a67. Read the comment docs.


Product Landing Page

Create a landing page for a fictional product or service. Include a product description, pricing, and a call-to-action button.

Hi, @debrajrout  I created the PR for this issue. Please review and approve.
https://github.com/debrajrout/Dev.HFest/pull/26

Thanks For Contributing. Please share the repo.

Thanks @debrajrout. Will share this repo.

Go ahead and try to contribute more

Yeah, will do that. Can you please review and approve other PR's too? You can check the PR. Thanks once again


Make bindings resilient to OOM errors

This PR proposes a relatively simple but maybe controversial change.
In the functions that return a Vec, instead of using Vec::with_capacity and similar, we use Vec::new() followed with Vec::try_reserve. If try_reserve fails, we return VK_ERROR_OUT_OF_HOST_MEMORY.
Note that there's no shorter way on stable Rust to do this. Notably, try_with_capacity is unstable.
If I'm not mistaken, the bindings now never panic in case of OOM.
I personally don't have a need for this change, but I thought that this was a neat thing to add.

If we end up doing this, is there a lint that enables us to catch accidental/new remaining calls to Vec::with_capacity() and friends, that may result in panicking allocations?
Alternatively we could list such functions in disallowed-methods in clippy.toml via clippy::disallowed_methods.

I personally don't have a need for this change, but I thought that this was a neat thing to add.

Might be neat, but if we do this we're better complete about it :)


Project Satoshi: BEP-20 token Contract Tutorial

Make a tutorial as outlined in https://github.com/binancex/Grant-projects/blob/main/tutorials/beginner.md

Yes I’m still working on this issue I will provide a status update today.
How should I send it to?
On Sun, Nov 15, 2020 at 12:12 PM Gitcoin.co Bot<EMAIL_ADDRESS>wrote:

@coderrick https://github.com/coderrick Hello from Gitcoin Core - are
you still working on this issue? Please submit a WIP PR or comment back
within the next 3 days or you will be removed from this ticket and it will
be returned to an ‘Open’ status. Please let us know if you have questions!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=1 | 3
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=3 | 5
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=5 | 10
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=10
| 100 days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=100
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/binancex/Grant-projects/issues/3#issuecomment-727603549,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYCRYHQFPIDUQJ7M43VVYTSQADXHANCNFSM4TQQK3AQ
.

--
Derrick Wilson - Duncan
Temple University, B.S. Computer Science
<EMAIL_ADDRESS>www.linkedin.com/in/derrick-wilson-duncan-5ab07053
https://github.com/coderrick
https://github.com/coderrick

I am still working on this bounty issue
On Sun, Nov 22, 2020 at 12:12 PM Gitcoin.co Bot<EMAIL_ADDRESS>wrote:

Issue Status: 1. Open 2. Started 3. Submitted 4. Done
@coderrick https://github.com/coderrick due to inactivity, we have
escalated this issue
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053 to
Gitcoin's moderation team. Let us know if you believe this has been done in
error!

reminder (3 days)
escalation to mods (6 days)

Funders only: Snooze warnings for 1 day
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=1 | 3
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=3 | 5
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=5 | 10
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=10
| 100 days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=100
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/binancex/Grant-projects/issues/3#issuecomment-731778966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYCRYHU3QOQVPGHAFRRO2LSRFA6PANCNFSM4TQQK3AQ
.

--
Derrick Wilson - Duncan
Temple University, B.S. Computer Science
<EMAIL_ADDRESS>www.linkedin.com/in/derrick-wilson-duncan-5ab07053
https://github.com/coderrick
https://github.com/coderrick

I’m still working on it almost done.
On Mon, Nov 30, 2020 at 12:12 PM Gitcoin.co Bot<EMAIL_ADDRESS>wrote:

Issue Status: 1. Open 2. Started 3. Submitted 4. Done
@coderrick https://github.com/coderrick due to inactivity, we have
escalated this issue
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053 to
Gitcoin's moderation team. Let us know if you believe this has been done in
error!

reminder (3 days)

escalation to mods (6 days)

Funders only: Snooze warnings for 1 day
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=1 | 3
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=3 | 5
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=5 | 10
days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=10
| 100 days
https://gitcoin.co/issue/binancex/Grant-projects/3/100024053?snooze=100
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/binancex/Grant-projects/issues/3#issuecomment-735919525,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAYCRYDA7DAJDEPLHJTUQWDSSPG5ZANCNFSM4TQQK3AQ
.

--
Derrick Wilson - Duncan
Temple University, B.S. Computer Science
<EMAIL_ADDRESS>www.linkedin.com/in/derrick-wilson-duncan-5ab07053
https://github.com/coderrick
https://github.com/coderrick


Interference with Sublime Text DLLs?

Hello,
I'm getting this error message every time StreamDeck starts and loads this plugin. The plugin itself seems to work fine. But the error popping up every time I start the PC is quite annoying.

Translation:

streamdeck-discordmixer.exe - Entry Point not found
The process entry point "OPENSSL_sk_new_reserve" was not found in this DLL "C:\Program Files\Sublime Text\libssl-1_1-x64.dll"

Weirdly this stopped today. But I didn't change anything Sublime Text or this StreamDeck plugin.

:D Weird. I'll check if I'm packing libssl correctly with the plugin. Thanks for the info.


How can I test my model?

I have been trained my model,but I can't find the code to test my model.can you help me ? @auroua

You can reference eval_ckpt_file.py.

thanks!


Need of a video

Could you please record a video of doing this repacking? I can't really understand how to use it even with a guide 😪

In this example, boot_extracted contains the files extracted from the original boot.dat like this:


Sometimes auto tween is ignored.

Panel 3.0.0
DBAS 3.0.1
Sometimes the auto tween option is ignored by the AS library. I can see the property being written in the XML and the animation looks OK in the preview Panel. But when used in a Starling project some animations ignore the AS library and only keyframes are being displayed.

The auto tween option is removed in 4.7 library


[BUG]: Embedded Chat Widget: Incorporating chat History in query mode is missing

How are you running AnythingLLM?
Docker (local)
What happened?
Hi,
Problem:
The query mode inside the main application uses the chat history, but sadly the embedded widget only uses the chat history in chat mode, according to my tests.
Goal:
It would be amazing to be able to reference to previous question (at least the last one) in query mode with the widget, too! In chat mode I usually get at some point hallucinations that are not from my embedded documents with open-source LLM models. Even if I try to tune them inside the system-prompt. Therefore, for our use case we would need query mode + chat history (best if it could even incorporate the number in the main app "chat history" of previous chats).
More Information:
Under api/docs/#/Workspaces/post_v1_workspace__slug__stream_chat I also saw this comment:
Send a prompt to the workspace and the type of conversation (query or chat).
Query: Will not use LLM unless there are relevant sources from vectorDB & does not recall chat history.
Chat: Uses LLM general knowledge w/custom embeddings to produce output, uses rolling chat history.
But I am not sure if this has anything to do with the issue as it is working in the main app. Thanks and blessings!
Are there known steps to reproduce?
No response

When in query mode for the chat embed history is not maintained.
https://github.com/Mintplex-Labs/anything-llm/blob/b658f5012de0658272fb0853a1c00a1fda2ccf1f/server/utils/chats/embed.js#L201
Whereas in https://github.com/Mintplex-Labs/anything-llm/blob/b658f5012de0658272fb0853a1c00a1fda2ccf1f/server/utils/chats/stream.js#L64 you can see that the chat will refuse only if the entire thread is missing citations (enabling follow up questions on found citations).
https://github.com/Mintplex-Labs/anything-llm/blob/b658f5012de0658272fb0853a1c00a1fda2ccf1f/server/utils/chats/stream.js#L181
Makes sense to enable this followup citation backfilling to occur for the embed widget as well.


Update scalafmt-core to 3.3.2

Updates org.scalameta:scalafmt-core from 3.3.1 to 3.3.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Codecov Report

Merging #431 (51e5de6) into master (f8e3dfd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   99.51%   99.51%
=======================================
  Files           8        8
  Lines         412      412
  Branches       41       41
=======================================
  Hits          410      410
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e3dfd...51e5de6. Read the comment docs.


Is this package capable of calculating tokens for OpenAI assistant mode and more advanced chats?

Hello,
I noticed that the code package you wrote is very impressive. However, is it only capable of counting tokens for regular simple chats?
I saw your code requires the input prompt to include "role", "user", and "content" strings.....
message_prompt = [{ "role": "user", "content": "Hello world"}]
If using the assistant mode with instructions, file search, and uploading files to vector stores for RAG, the calculation might be more complex.
Are the token calculation methods for gpt-4-1106-preview and gpt4o the same?
I checked the tokenizer on the official website, but the tokenizer for gpt4o is not yet available:
https://platform.openai.com/tokenizer
Currently, my code for calculating tokens is as follows. Is this correct?
Thank you.
import tiktoken encoding = tiktoken.encoding_for_model("gpt-4-1106-preview")  token_contents = len(encoding.encode(contents))

Assistants mode- Currently not looking at this capability. Would be a great function to add, but I must admit I'm not an expert with the assistants API
Indeed- the gpt-4 and gpt-4o tokenizers will be considered the same because the 4o tokenizer isn't out yet. This is an unexpected bug with our library. We don't have every single tokenizer loaded in yet, so we fall back to cl100k for models Tiktoken doesn't recognize. Not perfect but still better than nothing. Would love some help from folks who know where to get the other tokenizers from

Thank you very much for your response. This feature is already great.
As for your mention that GPT-4O currently does not have a dedicated token segmentation tool, could we change the model to cl100k as follows?
Thank you.
import tiktoken
encoding = tiktoken.encoding_for_model("cl100k")
token_contents = len(encoding.encode(contents))

Thank you very much for your response. This feature is already great.
As for your mention that GPT-4O currently does not have a dedicated token segmentation tool, could we change the model to cl100k as follows? Thank you.
import tiktoken
encoding = tiktoken.encoding_for_model("cl100k")
token_contents = len(encoding.encode(contents))

Can you explain what you mean? We currently use cl100k as a fallback:
https://github.com/AgentOps-AI/tokencost/blob/e1d52dbaa3ada232aa68dabf5b58662da4bc2363/tokencost/costs.py#L101

Yes, I later changed the model name in this code segment to cl100k_base, but I encountered an error when running the program. I'm not sure where the issue in my code is. Thank you.
import tiktoken
encoding = tiktoken.encoding_for_model("cl100k_base")
token_contents = len(encoding.encode(content))
print(f"The prompt contains {token_contents} tokens.")
The error message is:
in encoding_for_model
raise KeyError(
KeyError: 'Could not automatically map cl100k_base to a tokenizer. Please use `tiktoken.get_encodin


SDN-1521: oc-plumbing-related-refactoring

Though the change looks big, its not:

I've refactored the folder structure under debug-scripts since in the image all scripts get copied into /usr/bin without retaining their folder structure. In future when we have more files, we can start using folders for arrangement.

I've removed the version and debug files since they don't seem really necessary.

I've moved some common functions into common.

Added the integration script for oc plumbing network-tools

SDN scripts were not working. Tidied them up and made them similar to OVN scripts.

TODOs after getting the client plumbing merged on the oc side:

There will be upcoming PRs that add a basic set of instructions for developers when adding scripts to the repo so that there is some sort of organization
Refactor the sdn_cluster_connectivity and sriov_connectivity scripts.

/cc @rcarrillocruz @juanluisvaladas : PTAL.
@astoycos : I've also modified your script moving the pod creation portions to a more common place. You can also push a PR later on to change the rest of the script accordingly and remove the comment of the script from the network-tools call.
 It will be easier to reivew.

/hold
until https://github.com/openshift/network-tools/pull/24 merges.

/hold
until https://github.com/openshift/network-tools/pull/24 merges.

/assign @juanluisvaladas @rcarrillocruz @astoycos

/assign @juanluisvaladas @rcarrillocruz @astoycos

Seems pretty good, I just have a couple nitpicks.

thanks Juan for the review. Have addressed the nits.

Seems pretty good, I just have a couple nitpicks.

thanks Juan for the review. Have addressed the nits.

/approve
/lgtm

/approve
/lgtm


Addition of matrix exponent for static size matrices.

I've implemented matrix exponent for static size matrices, happy to get feedback on improvements, e.g. for dynamic sized matrices.

Hi @fredrik-jansson-se!
Thank you for this PR. I'll review this next week-end.

Hey, thanks for reviewing. I've now made all changes requested.

That's great! Thanks!


Time zone does not work under Mongo.

Describe the bug
Time zone does not work under Mongo.

Expected behavior
I want the time to be -8:00 on writes and +8:00 on reads
Versions

Dependency
Version

node
14

typescript
?

mikro-orm
4.5.9

your-driver
mongo

My expected createdAt: "2021-11-04T015:06:08.368Z"


removing ziti-controller/ziti-router has broken the quickstart

need to find/fix/patch all the ziti-controller --> ziti controller, ziti-router --> ziti router

references to ziti-controller/ziti-router are removed


Parsing feedback from alexa

Hi,
thank you for this great piece of code.  I'm trying to wrap my head around it, and I wonder if you know if it is possible to do something else with alexa's response?
Now it's : you as a question, send the question, receive the answer, output the answer through the speaker.
But if for example I want to ask "Show me a picture of george michael".  I would want it to just send an "OK here you go" back, and I would write functionality to get the picture from google and display it on the mirror.
Is that at all possible, and how would I have to do that?
I presume I would have to use skill kit?  But how do I parse alexa's answer to know that it's "george michael" I have to search for?
thanks!

Now that you no longer need a button to make Alexa work I'd be very interested in how to do this... the instructions need some serious work LOL

@bartalluyn I was also looking for that solution, if the skill is yours there is a way to send the response with other way, but for all the skills I'm still researching about that. I'll update here if I find anything, please feel free to inform if you also find some solutions.
@cowboysdude yeah I've managed to do that, but I'll update the code when it's solid. About the instructions, soon we'll prepare a workshop with using this library, at that time I may have a chance to update the documentation. Also feel free to create a PR for updating the instructions, or create wiki pages.

@bartalluyn I was also looking for that solution, if the skill is yours there is a way to send the response with other way, but for all the skills I'm still researching about that. I'll update here if I find anything, please feel free to inform if you also find some solutions.
@cowboysdude yeah I've managed to do that, but I'll update the code when it's solid. About the instructions, soon we'll prepare a workshop with using this library, at that time I may have a chance to update the documentation. Also feel free to create a PR for updating the instructions, or create wiki pages.

Hi,
thanks for the response.
I'm currently looking into a way to start the Java Client for Alexa on my Pi (alongside the mirror app) and adjusting the java code of the client to sent post requests to the magic mirror electron app whenever it processes a request.  That way I can leverage the existing Java code provided by amazon with little code adjustments to the mirror.
I have to do a lot more fiddling, but I'm sure that could be a low impact way to add more functionality integration between the mirror and alexa.

@bartalluyn but the java client has the response as text? the reason of this library is actually avoiding to use any other library, so if java client support more feature it should be also included in here.


Added a bind mount for atrust data

Atrust stores some extra data (eg. connect URL) at /usr/share/sangfor/.aTrust in additional to /root. Added this bind mount let Atrust remember that url (and maybe some extra info)

如果绑定.atrust-data/usr/share/sangfor/.aTrust/目录到本地，可能会出现异常，在切换地址的时候会直接提示“环境异常需要重启”，尝试改为-v $HOME/.atrust-data/usr/share/sangfor/.aTrust/database:/usr/share/sangfor/.aTrust/database暂时未出现问题。


Karma Reporter

@LeaVerou has mentioned it would be nice to have an HTML reporter where users can re-run the tests in the browser. I was looking at something like this: https://www.npmjs.com/package/karma-jasmine-html-reporter.
@dperrymorrow - Seen this anywhere with karma? Ideas.

I don't see anything out there that works like QUnit, where you can re-run the tests in the browser.
Which begs the question, how important is this?

well if you reload the Chrome browser it launches, it does re-run the tests.
Are we looking to have the tests suite as a page on the gh-pages site? Is that what you mean?

@dperrymorrow - Yeah. That's the use case.

Using karma-htmlfile-reporter I'm able to generate a html file of the result of a Karma run.
Its not actually running the suite, but lists out all the tests ect...

You could wire up an html page for the tests, but that would probally require checking the npm_modules dir into the project.

Committing the node modules seems problematic.

i would agree,
only thing i can think of at the moment would be to have a gulp task that makes a concatenated minified js file for the html test page from the src in of node_modules.
could work...

If you wanted to spend some time seeing if something like could work, it might be worth releasing. Other than that, the only path forward I'm aware of is rewriting the tests in QUnit.

if we go down this road its just going to further complicate #59 though isn't it?

Possibly. Just trying to figure out what our options are. @LeaVerou: how important is this to you?

Closing this out for #82.

ok i can always take a stab later at building a gulp task to create a test web page.

IMO i think having CI in multiple browsers might be of more priority, with something like SauceLabs

I think Browserstack or SauceLabs is a good idea. We can get a free account since this is open source.


remove unused file

cleanup for #5363

Codecov Report

Merging #6121 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6121      +/-   ##
==========================================
+ Coverage   38.79%   38.85%   +0.05%
==========================================
  Files         353      352       -1
  Lines       50109    50030      -79
==========================================
- Hits        19442    19440       -2
+ Misses      27853    27776      -77
  Partials     2814     2814

Impacted Files
Coverage Δ

models/repo_list.go
66.84% <0%> (-1.06%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 830ae61...63c0bd9. Read the comment docs.

lg-tm


Globopt bug fix.

Don't load type spcialized values from arrays when type-spec is disabled.

@pleath and @meg-gupta , please code review.  Thanks.

@pleath and @meg-Gupta, Ping!

LGTM.


Killing an ffmpeg process kills Streamer

Killing an ffmpeg process currently kills Streamer instead of shutting down cleanly.
./shaka_streamer.py -i config_files/input_looped_file_config.yaml -p config_files/pipeline_live_config.yaml
Then pick an ffmpeg process from ps in Linux and kill it by PID.
The controller should see that a process died and shut down the pipeline by killing the others.
Instead, it dies and orphans the other subprocesses.

It looks like our assumptions of child processes was wrong.  When we spawn a child process, that process doesn't get closed when we exit.  If we want to kill the subprocesses, we need to explicitly kill them when we shut down.  Otherwise the process will get orphaned and remain running.
Also note that currently, the killing isn't detected as an error and the streamer returns success.  We are ignoring the return codes from the long-running processes and just stopping when one of the exits.


docs: add codeowner file

Description
Added the codeowner file to the project.
Related issue(s)

/rtm


[implant] Add code quality tools

Proposed changes
Chunck 1:
Add the next code quality tools to CI for Linux & Mac :
→ Cllippy: lint checks https://github.com/rust-lang/rust-clippy
→ Rustfmt: format code
→ Cargo Audit: check security dependencies (Linux, Mac)
→ test
After apply these tools some files were updated.
Related issues

Obas #1982

Checklist

[ ] I consider the submitted work as finished
[ ] I tested the code for its functionality
[ ] I wrote test cases for the relevant uses case
[x] I added/update the relevant documentation (either on github or on notion)
[x] Where necessary I refactored code to improve the overall quality

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Can we take advantage of your PR to push this renovation through?
https://github.com/OpenBAS-Platform/implant/pull/33
Thank you


Adding support for imgcodecs on WinRT

Enabling 'imgcodecs' module
Adding sample code

ABI incompatibility looks the same as we had here

Could someone please take a look and merge if it's fine. With this patch in the codebase videoio should be the next step.

:+1:


#49 Handle missing optional multi-value query param

This PR includes:

Improved handling of multi-value query parameters - handle any order of query parameters
Improved handling of optional multi-value query parameters - ordering still matters, but it handles now missing first parameter correctly
Major refactoring of the Stub.peb template to simplify the logic and remove duplication

Generally, this PR decreases the reliance on URL matching in favour of the WireMock's RequestMappingBuilder which provides full flexibility in terms of query parameter ordering. Unfortunately, it doesn't seem to support or which is necessary for optional query parameters. That is still handled by matching the entire URL which is order sensitive.

At Google we had a rule (that was enforced) to use named parameters for primitive values passed to methods. We used a comment to specify the parameters see below:
someMethod(/* someParam1= */ 1, /* someParam2= */ "hello")

While tedious, I feel your tests could benefit from this practice as it's unclear what parameters are being set to be what.

I see. IntelliJ has this feature. Let me try...

I remember we decided not to use it because IntelliJ displays the names by default like this:

With comments added it looks like this:

Which to me is worse but it helps when reviewing in Github....
Let me think about it. For now I will merge the PR and maybe raise a new one with the named params in comments added.

:tada: This PR is included in version 3.0.14 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Make gcr.io/kpt-fn/kubeval as a default validator

We want to have kpt fn render automatically validate the users KRM resources (via kubeval ) at the end of all the mutator functions. This guarantees any resources the KRM functions modified  are at least pass kubeval before they are saved. The downside is the additional overhead on running another function.
We should make the kubeval as a builtin function, so it should still be much faster than running the standalone gcr.io/kpt-fn/kubeval.
This is votes in kpt slack

@yuwenma, Instrumenta has stopped maintaining kubeval; so, unless new maintainers step in, investing further in integration of kubeval might not be the best course of action.

@masoudbahar thank you so much for this information!

For future discussions, I think we should consider what this comment says, even if our shifting left approach is kind of in a different scenario.

A potential alternative to using any third party validators is adding support for ValidatingAdmissionPolicy, in a client-side fashion, which is also an objective of the referenced KEP.
It would integrate well with the evolution of Kubernetes platform, and would allow operators to write their own validators, although it leaves open the question of who’d be responsible for writing a policy to check a given manifest’s conformance, not just any required restrictions.


Parameterized classes are incorrectly included into test targets that filter them out

Describe the bug

A clear and concise description of what the bug is.

Test classes annotated with @RunWith(Parameterized::class) end up running as part of flank invocations that do not include these classes in the config.
To Reproduce

Steps to reproduce the behavior:

Create an parameterized instrumentation test class in package foo.bar. For example:

package foo.bar

@RunWith(Parameterized::class)
class FooTest(private val horizontal: Boolean) {

  @Test
     test_one() {
       assert(true)
  }

    private companion object {
    @JvmStatic
    @Parameterized.Parameters
    fun data(): Collection<Boolean> = listOf(
      true,
      false
    )
  }
}

configure flank to run tests in a different package. For example:

test_targets:
- package foo.baz

Expected behavior

A clear and concise description of what you expected to happen.

parameterized class from step 1 should not be executed as part of the flank run
Actual: see see something like this:
80 tests + 1 parameterized class / 81 shards (where the parameterized class is outside of the configured target)
Details (please complete the following information):

Have you tested on the latest Flank snapshot? No
Post the output of  flank --version.
version: v20.09.3

Additional context

Add any other context about the problem here.

I think this is the same issue as https://github.com/Flank/flank/issues/1234, fixed in https://github.com/Flank/flank/pull/1233
I was unable to reproduce this error with the current master git checkout d7b74e but this error occurred without #1233 fix (git checkout f34ee09 commit before fix)
@valeraz if it's not a problem, let me know if you receive the same error with a snapshot version

Closing due to the impossibility of reproducing.


worktop/base64 - TypeError: Illegal invocation

import {decode} from 'worktop/base64'

// TypeError: Illegal invocation
decode(match[1])

// works
atob(match[1])

Version: 0.4.2

Thanks for this – How are you building it? What does the output look like?
Importing this and building with Rollup and cfw (which is esbuild under the hood) are both working as expected. I have production apps using this already, too. So my thought is that your build system is tampering with it in some way.

Closing this as I think it's invalid, but needs more info just to be sure.
Thanks!


Config value of TLSClientAuthMode does not work on TLS server.

The config value of TLSClientAuthMode is fixed on "RequireAndVerifyClientCert"(4) on TLS server whichever value is set.
https://github.com/yahoo/crypki/blob/8e3d5535f79a1a106fcf89e2b9a9a8ce04fff06a/server/server.go#L57
Is it a specification? This configuration is only for grpc?

Is it a specification?

By specification, if you mean a hard requirement for crypki to work, the answer is no. We can definitely make it configurable so users can set different values.

This configuration is only for grpc?

Same tls config is used for grpc and gateway server. It is initialized at https://github.com/yahoo/crypki/blob/94b3bf6e4b9d0388aa8c464035456bb4149f8fe4/server/server.go#L156
@mkontani

@maditya thanks confirmation.
I think that tlsConfig.ClientAuth value is overwritten to "tls.RequireAndVerifyClientCert" in initHttpServer func.
https://github.com/yahoo/crypki/blob/61fcaee548c39b8c55294c672cc3e1b0e120385e/server/server.go#L59
so any value is configured (0~4), crypki server always requires client cert auth (4).
# case configured "TLSClientAuthMode": 0
$ curl -X GET https://localhost:4443/v3/sig/ssh-user-cert/keys  -k
curl: (56) OpenSSL SSL_read: error:14094412:SSL routines:ssl3_read_bytes:sslv3 alert bad certificate, errno 0

If comment out the above line in initHttpServer func, the config value looks work.
# case configured "TLSClientAuthMode": 4
$ curl -X GET https://localhost:4443/v3/sig/ssh-user-cert/keys  -k
curl: (56) OpenSSL SSL_read: error:14094412:SSL routines:ssl3_read_bytes:sslv3 alert bad certificate, errno 0

# case configured "TLSClientAuthMode": 0
$ curl -X GET https://localhost:4443/v3/sig/ssh-user-cert/keys  -k
{"keys":[{"identifier":"ssh-user-key"}]}

Same tls config is used for grpc and gateway server.

Sorry, it's my misunderstanding.
thank you.


[Empyrical] Speed up Hill1t processing with concurrency

Currently Hill1t is quite slow for processing large files or amounts of files. I'm sure that there are ways to do this algorithmically, but what I have in mind at the moment is to introduce more concurrent processing. Most likely this should be done with concurrent.futures (docs). For the moment I'll keep this issue restricted to introducing concurrency since that's a bit more actionable.

If I were to do this, I would have simply used pandas along with one of the multiprocessed apply modules for it, like https://pypi.org/project/pandarallel/

That sounds promising, if nobody else picks this up then I'll look into using Pandas for it. Might also be worth introducing a more formal data science framework for other future projects since it's pretty heavily data-related.


Inconsistent reporting of run commands in "review" job

Orb version:
11.1.0
What happened:
I have an orb with multiple "jobs"; RC008 and RCOO9 seem to behave somewhat inconsistently with the "review" job.
RC008: All Run steps should contain a name: I have multiple jobs that have run steps without a name, but only a single one shows up, and that is in a file like the second example below where there should be 2 violations, but only one shows up.
RC009: All Run step's commands should be imported: Almost all the same items that should be flagging above also fail this check; in this case, they are reported. However, some of the additional detail seems to be missing or confusing:
(in test file review.bats, line 160)
  `exit 1' failed
File: "./src/jobs/job1.yml"
Line number: 12
---
---
File: "./src/jobs/job2.yml"
Line number: 15
---
null
---

I can't easily throw up a public demo repo, but happy to provide links to examples to Circle employees offline (I'm on the discussion forum under the same account), or provide more details if you're not able to repro it easily. The examples below are lightly sanitized versions of 2 of the files, but of course there's other stuff in the orb repo as well.
Expected behavior:
Given the following two files, the two checks should fail on both (these are also slightly sanitized versions of the ones that cause the output above):
src/jobs/job1.yml:
description: "Do some things and then `foo bar`"
executor: <<parameters.executor>>
parameters:
  executor:
    description: The name of custom executor to use
    type: executor
    default: wizzle
steps:
  - checkout
  - restore-deps
  - setup-auth
  - run: npm install --no-save
  - save-deps

src/jobs/job2.yml:
description: "Run thing1 (and, optionally, thing2) on code"
executor: <<parameters.executor>>
parameters:
  executor:
    description: The name of custom executor to use
    type: executor
    default: wizzle
  run-thing2:
    description: whether or not to run foo
    type: boolean
    default: true
steps:
  - checkout
  - restore-deps
  - run: npm run thing1
  - when:
      condition: << parameters.run-thing2 >>
      steps:
        run: npm run thing2

Additional Information:
Also, I would love to see RC008 and RC009 retained / usable, but loosened up somewhat (I just have them ignored outright for now) - I see the value of encouraging good practices and failing on missing titles for very long run commands, or failing on long / complicated shell scripts, but IMO it's a bit overkill to require a single command with no interpolation, variables, or other complexity to be turned into a shell script
i.e.,
## not getting much value out of linting this IMO
run: npm run eslint

vs
run: <<include(scripts/script_that_runs_npm_run_eslint.sh)>>

The BATS based approach kind of makes sense, but it might be cleaner to build a linter into the CLI that has somewhat more readable output.
Anyway, while I'd frequently do something like
run:
   name: Setup stuff
   command: |
      here is
      a very long set of
      commands that I don't
      really want to see all of & 2>&1

IMO, for very simple use cases like this:
run: npm run foo

is probably (in many cases) clearer and easier to understand in both the Circle web UI and in the config itself
run:
  name: Run foo on files
  command: npm run foo

So, I know the logic would be much harder to do, but would love to see something that will flag examples where these recommended practices will really help in terms of reducing complexity or increasing readability.

Thank you @wyardley 🙇 . I have already found an issue that I think may show that it was originally falsely approving maybe everything face palm. I am realizing the complexity of using BATS here makes it difficult to test my tests, at least automatically. So I am going to do some manual testing for the time being to get this patched and think later on how to better test the tests.
And Ah! When conditionals, excellent call, we'll have to get a secondary loop going.

IMO, for very simple use cases like this:
run:
  name: Run foo on files
  command: npm run foo

How about we don't trigger this rule until a minimum length? It would need to be somewhat arbitrary but I am thinking maybe anything over 32 characters?  That's close to three times as long as your example here, which is perfectly valid.

How about we don't trigger this rule until a minimum length?

Yeah, that would be a good start, esp if the length is configurable. Mustache templating might lengthen some commands slightly beyond that (at which point you might be able to argue that it should be broken out as well), but that  seems somewhat reasonable.

How about we don't trigger this rule until a minimum length?

Yeah, that would be a good start, esp if the length is configurable. Mustache templating might lengthen some commands slightly beyond that (at which point you might be able to argue that it should be broken out anyway I guess), but that seems somewhat reasonable.

I struggle to remember the specific example but there have been situations where mustache templating inside of bash has caused issues with injecting unwanted quotations which can in rare instances break a command when used in arguments.
I believe it might be something like, injecting a number parameter. and getting quotes.
My personal bias/opinion is to not use mustache templating inside bash, but it works perfectly fine directly in YAML where we can use it to set environment variables which are more native to our scripts.

My personal bias/opinion is to not use mustache templating inside bash, but it works perfectly fine directly in YAML where we can use it to set environment variables which are more native to our scripts.

Right - that's what I ended up doing in my case (based on the examples / discussion in the docs about this), though it was pretty confusing to implement esp. in the case where a parameter was type env-var-name. I could imagine some situations where you're doing more complicated conditional logic with mustache might be either harder or easier to read when done this way (in shell).
Also, does Circle have a style preference on spaces or not inside templates (<< foo >> vs <<foo>>? I keep seeing different examples, and have ended up switching back and forth, but that might be another thing worth flagging / linting / enforcing some kind of style on.

@KyleTryon thanks for the quick fix
Question: after testing with these latest changes, I see the same results / failed tests in both RC008 and RC009's results

and both mention "string formatting" - is something mixed up there?

ention "string formatting" - is something mixed up there? Reading the code / changes in https://github.com/CircleCI-Public/orb-tools-orb/pull/131/files, maybe this is intentional? But would love it if I can check the two separately (for example, I would like to be able to not use a separate name pa

Hey @wyardley,
This was intentional, but perhaps we have still done something incorrectly.
In both tests, there is a check for the .name and .command property respectively. In both situations, if the run step is actually of type string, then it would not have either property and so we must fail the test. Another option I considered was adding a new test specifically to ensure it was not a string, but then we would still have to decide what to do with RC009 and RC008, it did not feel right to ignore/skip the test when it is not valid.
Am I correct your config looks like this?
- run: npm install --no-save

If so, I believe the above in intended, but very open to suggestions/prs. Let us know!