.proto to .json

What version of gRPC and what language are you using?
1.14.2 (Python)
What operating system (Linux, Windows, …) and version?
Ubuntu 16.04
What runtime / compiler are you using (e.g. python version or version of gcc)
Python 3.6.5
What did you do?
I'm trying to "parse" the .proto and generate a .json.
What did you expect to see?
Something like pbjs does (but in Python).
What did you see instead?
I couldn't find a clean way until now. Looking for some help on it.
Anything else we should know about your project / environment?

I am not aware of a tool off the top of my head, but I recommend filing an issue on the google/protobuf issue tracker, as it is going to be more appropriately addressed there.


Multi-line messages

The user should be able to write multi-line messages

The initial version doesn't need to include this, but it'd be great to be able to specify the "format" for a multiline message: plain text or "code". If "Code" format is selected, it gets rendered with syntax highlighting when received (use highlight.js, same as for files atm).

Reference to try out: https://quilljs.com/

There is also

http://prosemirror.net/
http://codemirror.net/
https://facebook.github.io/draft-js/

which might be interesting to look at


Loading indicator always displayed at top of screen

The loading indicator in the scroll view is always displayed at the top of the screen even if new messages are loaded from the bottom. This is unintuitive and provides a bad UX.
(Also, scrolling stops when the load indicator is encountered. I think it'd be nicer to allow scrolling to continue as new messages get pulled in.)

Agree partially. CCing @timabbott
I was thinking about that...
I will move the progress bar indicator inside the list itself, so it is visible only if the list is at top.
Actually I will investigate in detail how it is handled in other chat apps.
One thing that got very improved over the last few years in UI regard, but I know many of us devs or tech guys that are not UX guys didn't caught up to is that showing a progress indicator is distracting and often gives the impression of slowness. For example Facebook and now a lot of other apps have the 'not yet loaded, but looking like content' type of thing that is the grey blocks imitating not loaded text (hope you know what I am talking about)

Yeah, I like the idea of moving it into the list itself and displaying it at top or bottom.  What do you think @neerajwahi?  Not sure grey blocks totally makes sense, since we don't know the size; but I think having the single top-of-feed or bottom-of-feed indicator display as a loading indicator if we're trying to fetch more makes a lot of sense (and display as something more definite if we're at the end).

I like the grey block approach for a couple of reasons:

I agree that users are conditioned to find loading indicators slow nowadays
With placeholders we can let the user continue to scroll uninterrupted (with the blocks filling in with content underneath). I think this will make the app feel a lot snappier (because the user interaction doesn't get interrupted)

@timabbott Definitely agree that not knowing the size of the blocks makes this a bit tricky. Hard to know without a prototype how it'll feel. Perhaps instead of blocks it could be a gradient, or just a background with a loading indicator that allows the user to continue scrolling while it's displayed.
@borisyankov Btw the news feed in the Facebook app actually seems to use loading indicators when scrolling.

The Facebook feed uses a 'not yet loaded' news type of thing, exactly what I proposed.
It has an animated gradient though. Also it loads super fast so is on screen for a very short time only.

@borisyankov why did you close this? It's still an open issue, no?

@neerajwahi I just implemented it. Not yet a PR though.

Cool. Let's leave issues open until merged into master and you can reference it in your PR. Easier to keep track that way :)

@borisyankov Could you send along the branch as a preview (even if it's not ready)?

It is in the cache PR.


Using fully-qualified Hyrax::Workflow::PermissionQuery in submodules

@projecthydra-labs/hyrax-code-reviewers

Can you say why you made this change (ideally in the commit message?)

@jcoyne I was getting Error: uninitialized constant Workflow::PermissionQuery when my works called WorkIndexer.generate_solr_document.  I can add that to the commit message.


Readme and Test for beforeBuildSave

Hi Travis, please let me know if there is anything else I have to change. Thank you!

@AngelloMaggio Thank you for contribution. I have already added this changes.


Add support for driver.ConnBeginTx

This PR adds support for drivers implementing the driver.ConnBeginTx interface.
Fixes https://github.com/gchaincl/sqlhooks/issues/20

Coverage decreased (-2.9%) to 72.202% when pulling b4e3892e2d1633b251602e96e1be9f83c77a82b3 on asdine:support-connbegintx into e01e589194fe30567fdff020d15a2d26f16c5135 on gchaincl:master.

Coverage decreased (-2.9%) to 72.202% when pulling b4e3892e2d1633b251602e96e1be9f83c77a82b3 on asdine:support-connbegintx into e01e589194fe30567fdff020d15a2d26f16c5135 on gchaincl:master.

Coverage decreased (-2.9%) to 72.202% when pulling b4e3892e2d1633b251602e96e1be9f83c77a82b3 on asdine:support-connbegintx into e01e589194fe30567fdff020d15a2d26f16c5135 on gchaincl:master.

Coverage decreased (-2.9%) to 72.202% when pulling b4e3892e2d1633b251602e96e1be9f83c77a82b3 on asdine:support-connbegintx into e01e589194fe30567fdff020d15a2d26f16c5135 on gchaincl:master.

Thank @asdine for doing this!
Any change to add a test for this?

Thank @asdine for doing this!
Any change to add a test for this?

Hey @gchaincl ! I added a test in here https://github.com/gchaincl/sqlhooks/blob/b4e3892e2d1633b251602e96e1be9f83c77a82b3/sqlhooks_interface_test.go#L66-L71, do you have something else in mind?

Hey @gchaincl ! I added a test in here https://github.com/gchaincl/sqlhooks/blob/b4e3892e2d1633b251602e96e1be9f83c77a82b3/sqlhooks_interface_test.go#L66-L71, do you have something else in mind?

Hey @gchaincl ! I added a test in here
https://github.com/gchaincl/sqlhooks/blob/b4e3892e2d1633b251602e96e1be9f83c77a82b3/sqlhooks_interface_test.go#L66-L71
, do you have something else in mind?

I think you can add it here: https://github.com/gchaincl/sqlhooks/blob/b4e3892e2d1633b251602e96e1be9f83c77a82b3/sqlhooks_interface_test.go#L15

Hey @gchaincl ! I added a test in here
https://github.com/gchaincl/sqlhooks/blob/b4e3892e2d1633b251602e96e1be9f83c77a82b3/sqlhooks_interface_test.go#L66-L71
, do you have something else in mind?

I think you can add it here: https://github.com/gchaincl/sqlhooks/blob/b4e3892e2d1633b251602e96e1be9f83c77a82b3/sqlhooks_interface_test.go#L15

I realized I didn't add it to that list and my solution doesn't work 🤦🏼♂
After a few tries and reading https://github.com/gchaincl/sqlhooks/pull/24, I think the best solution here is to add BeginTx to the base Conn type, dropping support for drivers not supporting driver.ConnBeginTx.
I have analyzed the drivers listed in https://github.com/golang/go/wiki/SQLDrivers:
53 drivers
Apache H2: https://github.com/jmrobles/h2go
Apache Ignite/GridGain: https://github.com/amsokol/ignite-go-client
Apache Impala: https://github.com/bippio/go-impala
Apache Avatica/Phoenix: https://github.com/apache/calcite-avatica-go
Amazon AWS Athena: https://github.com/uber/athenadriver
AWS Athena: https://github.com/segmentio/go-athena
Azure Cosmos DB: https://github.com/btnguyen2k/gocosmos
ClickHouse (uses native TCP interface): https://github.com/ClickHouse/clickhouse-go
ClickHouse (uses HTTP API): https://github.com/mailru/go-clickhouse
CockroachDB: Use any PostgreSQL driver
Couchbase N1QL: https://github.com/couchbase/go_n1ql
DB2 LUW and DB2/Z with DB2-Connect: https://bitbucket.org/phiggins/db2cli (Last updated 2015-08)
DB2 LUW (uses cgo): https://github.com/asifjalil/cli
DB2 LUW, z/OS, iSeries and Informix: https://github.com/ibmdb/go_ibm_db
Firebird SQL: https://github.com/nakagami/firebirdsql
Genji (pure go): https://github.com/genjidb/genji
Google Cloud BigQuery: https://github.com/solcates/go-sql-bigquery
Google Cloud Spanner: https://github.com/rakyll/go-sql-driver-spanner
MS ADODB: https://github.com/mattn/go-adodb
MS SQL Server (pure go): https://github.com/denisenkom/go-mssqldb
MS SQL Server (uses cgo): https://github.com/minus5/gofreetds
MySQL: https://github.com/go-sql-driver/mysql/ []
MySQL: https://github.com/siddontang/go-mysql/ [**] (also handles replication)
MySQL: https://github.com/ziutek/mymysql []
ODBC: https://bitbucket.org/miquella/mgodbc (Last updated 2016-02)
ODBC: https://github.com/alexbrainman/odbc
Oracle (uses cgo): https://github.com/mattn/go-oci8
Oracle (uses cgo): https://gopkg.in/rana/ora.v4
Oracle (uses cgo): https://github.com/godror/godror
Oracle (pure go): https://github.com/sijms/go-ora
QL: http://godoc.org/github.com/cznic/ql/driver
Postgres (pure Go): https://github.com/lib/pq []
Postgres (uses cgo): https://github.com/jbarham/gopgsqldriver
Postgres (pure Go): https://github.com/jackc/pgx [**]
Presto: https://github.com/prestodb/presto-go-client
SAP HANA (uses cgo): https://help.sap.com/viewer/0eec0d68141541d1b07893a39944924e/2.0.03/en-US/0ffbe86c9d9f44338441829c6bee15e6.html
SAP HANA (pure go): https://github.com/SAP/go-hdb
SAP ASE (uses cgo): https://github.com/SAP/go-ase - package cgo (pure go package planned)
Snowflake (pure Go): https://github.com/snowflakedb/gosnowflake
SQLite (uses cgo): https://github.com/mattn/go-sqlite3 []
SQLite (uses cgo): https://github.com/gwenn/gosqlite - Supports SQLite dynamic data typing
SQLite (uses cgo): https://github.com/mxk/go-sqlite
SQLite: (uses cgo): https://github.com/rsc/sqlite
SQLite: (pure go): https://modernc.org/sqlite
SQL over REST: https://github.com/adaptant-labs/go-sql-rest-driver
Sybase SQL Anywhere: https://github.com/a-palchikov/sqlago
Sybase ASE (pure go): https://github.com/thda/tds
TiDB: Use any MySQL driver
Vertica: https://github.com/vertica/vertica-sql-go
Vitess: https://godoc.org/vitess.io/vitess/go/vt/vitessdriver
YQL (Yahoo! Query Language): https://github.com/mattn/go-yql
Apache Hive: https://github.com/sql-machine-learning/gohive
MaxCompute: https://github.com/sql-machine-learning/gomaxcompute

12 don't support transactions at all (and thus are not compatible with SQLHooks)
Apache Ignite/GridGain: https://github.com/amsokol/ignite-go-client
Apache Impala: https://github.com/bippio/go-impala
Apache Avatica/Phoenix: https://github.com/apache/calcite-avatica-go
Amazon AWS Athena: https://github.com/uber/athenadriver
AWS Athena: https://github.com/segmentio/go-athena
Azure Cosmos DB: https://github.com/btnguyen2k/gocosmos
Couchbase N1QL: https://github.com/couchbase/go_n1ql
Presto: https://github.com/prestodb/presto-go-client
SQL over REST: https://github.com/adaptant-labs/go-sql-rest-driver
YQL (Yahoo!

I realized I didn't add it to that list and my solution doesn't work 🤦🏼♂
After a few tries and reading https://github.com/gchaincl/sqlhooks/pull/24, I think the best solution here is to add BeginTx to the base Conn type, dropping support for drivers not supporting driver.ConnBeginTx.
I have analyzed the drivers listed in https://github.com/golang/go/wiki/SQLDrivers:
53 drivers
Apache H2: https://github.com/jmrobles/h2go
Apache Ignite/GridGain: https://github.com/amsokol/ignite-go-client
Apache Impala: https://github.com/bippio/go-impala
Apache Avatica/Phoenix: https://github.com/apache/calcite-avatica-go
Amazon AWS Athena: https://github.com/uber/athenadriver
AWS Athena: https://github.com/segmentio/go-athena
Azure Cosmos DB: https://github.com/btnguyen2k/gocosmos
ClickHouse (uses native TCP interface): https://github.com/ClickHouse/clickhouse-go
ClickHouse (uses HTTP API): https://github.com/mailru/go-clickhouse
CockroachDB: Use any PostgreSQL driver
Couchbase N1QL: https://github.com/couchbase/go_n1ql
DB2 LUW and DB2/Z with DB2-Connect: https://bitbucket.org/phiggins/db2cli (Last updated 2015-08)
DB2 LUW (uses cgo): https://github.com/asifjalil/cli
DB2 LUW, z/OS, iSeries and Informix: https://github.com/ibmdb/go_ibm_db
Firebird SQL: https://github.com/nakagami/firebirdsql
Genji (pure go): https://github.com/genjidb/genji
Google Cloud BigQuery: https://github.com/solcates/go-sql-bigquery
Google Cloud Spanner: https://github.com/rakyll/go-sql-driver-spanner
MS ADODB: https://github.com/mattn/go-adodb
MS SQL Server (pure go): https://github.com/denisenkom/go-mssqldb
MS SQL Server (uses cgo): https://github.com/minus5/gofreetds
MySQL: https://github.com/go-sql-driver/mysql/ []
MySQL: https://github.com/siddontang/go-mysql/ [**] (also handles replication)
MySQL: https://github.com/ziutek/mymysql []
ODBC: https://bitbucket.org/miquella/mgodbc (Last updated 2016-02)
ODBC: https://github.com/alexbrainman/odbc
Oracle (uses cgo): https://github.com/mattn/go-oci8
Oracle (uses cgo): https://gopkg.in/rana/ora.v4
Oracle (uses cgo): https://github.com/godror/godror
Oracle (pure go): https://github.com/sijms/go-ora
QL: http://godoc.org/github.com/cznic/ql/driver
Postgres (pure Go): https://github.com/lib/pq []
Postgres (uses cgo): https://github.com/jbarham/gopgsqldriver
Postgres (pure Go): https://github.com/jackc/pgx [**]
Presto: https://github.com/prestodb/presto-go-client
SAP HANA (uses cgo): https://help.sap.com/viewer/0eec0d68141541d1b07893a39944924e/2.0.03/en-US/0ffbe86c9d9f44338441829c6bee15e6.html
SAP HANA (pure go): https://github.com/SAP/go-hdb
SAP ASE (uses cgo): https://github.com/SAP/go-ase - package cgo (pure go package planned)
Snowflake (pure Go): https://github.com/snowflakedb/gosnowflake
SQLite (uses cgo): https://github.com/mattn/go-sqlite3 []
SQLite (uses cgo): https://github.com/gwenn/gosqlite - Supports SQLite dynamic data typing
SQLite (uses cgo): https://github.com/mxk/go-sqlite
SQLite: (uses cgo): https://github.com/rsc/sqlite
SQLite: (pure go): https://modernc.org/sqlite
SQL over REST: https://github.com/adaptant-labs/go-sql-rest-driver
Sybase SQL Anywhere: https://github.com/a-palchikov/sqlago
Sybase ASE (pure go): https://github.com/thda/tds
TiDB: Use any MySQL driver
Vertica: https://github.com/vertica/vertica-sql-go
Vitess: https://godoc.org/vitess.io/vitess/go/vt/vitessdriver
YQL (Yahoo! Query Language): https://github.com/mattn/go-yql
Apache Hive: https://github.com/sql-machine-learning/gohive
MaxCompute: https://github.com/sql-machine-learning/gomaxcompute

12 don't support transactions at all (and thus are not compatible with SQLHooks)
Apache Ignite/GridGain: https://github.com/amsokol/ignite-go-client
Apache Impala: https://github.com/bippio/go-impala
Apache Avatica/Phoenix: https://github.com/apache/calcite-avatica-go
Amazon AWS Athena: https://github.com/uber/athenadriver
AWS Athena: https://github.com/segmentio/go-athena
Azure Cosmos DB: https://github.com/btnguyen2k/gocosmos
Couchbase N1QL: https://github.com/couchbase/go_n1ql
Presto: https://github.com/prestodb/presto-go-client
SQL over REST: https://github.com/adaptant-labs/go-sql-rest-driver
YQL (Yahoo!

I wasn't aware that there were +50 drivers, that's crazy!
I'm really not sure how to do this, is there a way for sqlhooks to know if a driver doesn't support BeginTx?

I wasn't aware that there were +50 drivers, that's crazy!
I'm really not sure how to do this, is there a way for sqlhooks to know if a driver doesn't support BeginTx?

It is possible by running a simple type assertion. The problem is that because we have different types implementing different interfaces, we cannot write a wrapper around them: https://play.golang.org/p/9fD_7jKW6gt
One solution would be to add one additional struct for each implementation (one for *Execer, one for *ExecerQueryer, etc.), but that seems a bit overkill. Since very few active drivers don't support BeginTx (7), and since the type has been introduced since Go 1.8, I believe it would be easier to cut a new version with support for BeginTx and people using one of the 7 incompatible drivers could still use the current version of sqlhooks.

It is possible by running a simple type assertion. The problem is that because we have different types implementing different interfaces, we cannot write a wrapper around them: https://play.golang.org/p/9fD_7jKW6gt
One solution would be to add one additional struct for each implementation (one for *Execer, one for *ExecerQueryer, etc.), but that seems a bit overkill. Since very few active drivers don't support BeginTx (7), and since the type has been introduced since Go 1.8, I believe it would be easier to cut a new version with support for BeginTx and people using one of the 7 incompatible drivers could still use the current version of sqlhooks.

That makes sense, which are the drivers that don't support BeginTx?

That makes sense, which are the drivers that don't support BeginTx?

which are the drivers that don't support BeginTx?

They are listed here in this comment, you can click on the arrows on this comment it's a dropdown  (not the best UI choice sorry) https://github.com/gchaincl/sqlhooks/pull/33#issuecomment-762712823

which are the drivers that don't support BeginTx?

They are listed here in this comment, you can click on the arrows on this comment it's a dropdown  (not the best UI choice sorry) https://github.com/gchaincl/sqlhooks/pull/33#issuecomment-762712823

ah sorry, my bad.
happy to cut a new version and drop support for those drivers

ah sorry, my bad.
happy to cut a new version and drop support for those drivers

As this drops support for drivers that don't implement ConnBeginTx I think we should release v2.0.0

As this drops support for drivers that don't implement ConnBeginTx I think we should release v2.0.0

@gchaincl Good idea, should I create a v2 directory or should we simply merge this and create a v2.0.0 release?

@gchaincl Good idea, should I create a v2 directory or should we simply merge this and create a v2.0.0 release?

I'd just merge it and release v2.0.0

I'd just merge it and release v2.0.0


Rails 6.1 support

Rails master is 6.1.0-alpha now, but current gemfile limits rails to <6.1.
Most probably this is just a question of relaxing version requirement.

I'll relax the gemfile in the master branch, but please note that there won't be an official gem release of font-awesome-rails until there's an official alpha or beta release of rails 6.1 published to rubygems.

There's a rails 6.1.0.rc1 released on RubyGems now :)

Just to add to this, we've been running 6.1rc1/6.1rc2 in production and things have been working fine with the gem overall. Just need to bump the Gemspec so it will work with the official 6.1 release expected next week :)

Rails 6.1 is out 🎉
Can you please bump the gem version with the latest master?

Please upload to Rubygems.org.
Now, if I want to use Rails 6.1.0, I need to install this gem from github.

@bokmann would it be possible to have a release with Rails 6.1 support?

@rmm5t ping

@rmm5t Can you please also publish gem to rubygems?
Thank you

@rmm5t Please release it

@rmm5t Any news on releasing gem to rubygems?


Trailing Zeros in n! (Python)

💥 Proposal
Code to calculate trailing zeros in n! using Python.
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


add copyleft licenses

as it says :) Pretty sure i'm invoking these licenses correctly
🎤 Which license do you want to use? Includes a LICENSE file in the repository root.
For more information, see:
- https://www.pyopensci.org/python-package-guide/documentation/repository-files/license-files.html
- https://opensource.org/licenses
   (Use arrow keys)
 » Permissive - MIT
   Permissive - BSD-3-Clause
   Permissive - Apache-2.0
   Copyleft - GPL-3.0
   Copyleft - EUPL-1.2
   Intermediate - MPL-2.0

I'd like to keep the options to what we recommend in the guide.

fair enough! as of {recently} we have added discussion of copyleft licenses! https://www.pyopensci.org/python-package-guide/documentation/repository-files/license-files.html#use-open-permissive-licenses-when-possible
so someone coming off the guide will recognize/see "ah yes copyleft, permissive, i remember those."

Folks can always replace the generated license with something else if they want to.

I know this is a point of cultural divide in FOSS world, and i also know that part of that cultural divide is permissive license folks thinking copyleft folks are busybody do-gooders that think licenses are magical, and allow me to play into that caricature for a moment. defaults are powerful, and while it is true it's always possible to change things afterwards, I think it's important to at least present them as options for a few reasons -
one is that we narrow the scope of who pyos is for by only acknowledging the existence of permissive licenses. it sends the message to other free-as-in-liberation programmers that pyos isn't for them. I like the healthy blend of people from different worlds we have here and would like to keep deepening that!
two is that information is political, as is open source software, and part of the duty of an educator in politicized spaces is to make sure your students are at least aware of, if not conversant in those politics. I tried hard in the guide to not be preachy or longwinded, but rather just nod to the cultural divide between camps so they could investigate further if they wanted. this is a similar level of light touch: if you want to know more, you might search the license name, otherwise you can just cruise through with the defaults.
three is that i want to use this tool, so it would be nice if it had the licenses i prefer in it XD

I have added header comments based on the chosen license.

Ah! missed those. will update.

ok how bout dat

made partials for the license "stub" (not sure what to call that) and header so we can reuse them
added a test for one partial that uses a macro, that felt like a little too much template logic to just yeet into the template
started making some central fixtures like eg. using the copier.yml config to parameterize fixtures so we don't have to keep a bunch of things sync'd in multiple places

trying not to overengineer, but also stung by the painful memories of getting myself in knots when working on sprawling code generators lol


Release 0.1.7

I haven't been testing enough during the development of l293d, so before bumping to 0.1.7 and releasing, I'll try and break/fix it as much as possible.

Done - see https://pypi.python.org/pypi/l293d/0.1.7


Add a SynchronousInstrument superclass to enable code reuse

Counter, UpDownCounter, Histogram should all subclass from it. Common properties like Proxy, Name, Description, Unit, can all be properties of the superclass. There may be other code re-use opportunities as well, both in the M and C++ levels.

in metrics branch


@( doesn't auto-close inside of an HTML tag

Note: Old editor doesn't do this either but I'm not sure why the new one doesn't. Things should work

Fixed by @DoctorKrolic


skuba: Add new 'completion' command

Why is this PR needed?
As skuba is growing, new commands can be added. It's beneficial to
have a bash and zsh autocompletion commands which can be used to
generate a script which can autocomplete all skuba commands.
Fixes https://github.com/SUSE/skuba/issues/792
What does this PR do?
Adds the commands skuba completion bash and skuba completion zsh that generate script for cli completion
Anything else a reviewer needs to know?
Dockerfile that can be used to test:
FROM opensuse/leap

RUN zypper in -y git go1.12 make zsh bash-completion
ENV GOPATH=$HOME/go
ENV PATH=$GOPATH/bin:$PATH
RUN git clone https://github.com/tdaines42/skuba.git
RUN cd skuba && git checkout add-bash-completion && make install
RUN echo "source <( /go/bin/skuba completion bash | sed -n '/^#/,\$p' )" > /etc/bash_completion.d/skuba.sh
RUN skuba completion zsh | sed -n '/^#/,$p' > /etc/zsh_completion.d/_skuba

Info for QA
Related info
Status BEFORE applying the patch
How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove
this issue is not fixed.
Status AFTER applying the patch
How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.
Docs
If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp.
At the time of creating the issue, this PR can be work in progress (set its title to [WIP]),
but the documentation needs to be finalized before the PR can be merged.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

Based on code from https://github.com/SUSE/skuba/pull/95

One thing I'm not sure about is changing the commands in the help messages to something like skuba completion bash | tail -n +2 > "/etc/bash_completion.d/skuba.sh" and skuba completion zsh | tail -n +2 > "/etc/zsh_completion.d/_skuba"

I think we should package files in the *.d directories with the skuba command, and just remove that part from the help.
We really just need to sed that first line off of the generated output, using something like $(skuba completion bash) in the file. Then the file contents don't have to change.  Do you know how to get another couple of files into the rpm, @tdaines?

I think we should package files in the *.d directories with the skuba command, and just remove that part from the help.
We really just need to sed that first line off of the generated output, using something like $(skuba completion bash) in the file. Then the file contents don't have to change. Do you know how to get another couple of files into the rpm, @tdaines42?

I haven't had experience with packaging. I would assume there's something in IBS that could even generate the files after building skuba. 🤷♀

I think we should package files in the *.d directories with the skuba command, and just remove that part from the help.
We really just need to sed that first line off of the generated output, using something like $(skuba completion bash) in the file. Then the file contents don't have to change. Do you know how to get another couple of files into the rpm, @tdaines42?

I haven't had experience with packaging. I would assume there's something in IBS that could even generate the files after building skuba.

IMO, after this PR is merged,  we need to have another issue card for changing skuba spec file to apply this.

The completion file really just needs to contain a single line in order to work.  In the case of bash, the /etc/bash_completion.d/skuba.sh file I was testing with looks like:
eval "$( ~sauer/go/bin/skuba completion bash | sed -n '/^#/,$p' )"

(print everything from the first comment line to the end of the file, for people who hate sed)
Though, the file should clearly use the right path for skuba. :D  That would be a nuiscance to generate in the spec file due to the quotes.  Perhaps we should just have the spec file run skuba completion bash > skuba.sh (probably also with the sed above, to clean up untagged versions) in the install stage and then copy skuba.sh into the right directory instead of the static file contents.  And repeat for zsh, of course.  That'd be pretty easy, and I think is what you're proposing, @tdaines42
The only drawback is that it would potentially break if someone compiled a new skuba without installing the package, but do we care about that developers-only situation?  I'm thinking that we don't; people who break packages should probably expect breakage.

Should Marcos be removed from the authors in the commit so we're "all green" on the contributor check, or do we not care about that (since he did, technically, write some of the code - and was authorized to do so at the time).

I made some changes and updated the dockerfile to reflect that

LGTM.
Though, A dockerfile is mentioned, but I don't see it in the commit - is that intentional?

It's in the comment for the PR for manual testing

I updated the skuba spec file in my skuba branch at https://build.suse.de/package/show/home:dannysauer:branches:Devel:CaaSP:4.0/skuba to build bash and zsh completion files.  When this gets merged, that spec should create two new packages - skuba-bash-completion and skuba-zsh-completion.

Binary packages at https://build.suse.de/package/binaries/home:dannysauer:branches:Devel:CaaSP:4.0/skuba/SLE_15_SP1


Implement initial questions

On the homepage, choose regions. On the next page, choose product categories.
Then get filtered results.

Wait, I left a FIXME in.

👍


feat: implement get changelog cli command

[ ] Tests or benchmark included
[ ] Documentation is changed or added on https://app.gitbook.com/
[x] PR title must follow conventional-commit-standard

How will it look like in the CLI. Could you attach a screen?


ServerSelectionTimeoutError: <IP_ADDRESS>:27019: timed out,<IP_ADDRESS>:27018: timed out

The remote server is synchronized to the local monogo
The mongodb on the remote server is version 2.8
Local mongo is version 3.2.6
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/usr/local/lib/python2.7/site-packages/mongo_connector/util.py", line 104, in wrapped
    func(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/mongo_connector/connector.py", line 441, in run
    self.update_version_from_client(shard_conn)
  File "/usr/local/lib/python2.7/site-packages/mongo_connector/connector.py", line 334, in update_version_from_client
    is_master = client.admin.command("isMaster")
  File "/usr/local/lib/python2.7/site-packages/pymongo/database.py", line 491, in command
    with client._socket_for_reads(read_preference) as (sock_info, slave_ok):
  File "/usr/local/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/usr/local/lib/python2.7/site-packages/pymongo/mongo_client.py", line 859, in _socket_for_reads
    with self._get_socket(read_preference) as sock_info:
  File "/usr/local/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/usr/local/lib/python2.7/site-packages/pymongo/mongo_client.py", line 823, in _get_socket
    server = self._get_topology().select_server(selector)
  File "/usr/local/lib/python2.7/site-packages/pymongo/topology.py", line 214, in select_server
    address))
  File "/usr/local/lib/python2.7/site-packages/pymongo/topology.py", line 189, in select_servers
    self._error_message(selector))
ServerSelectionTimeoutError: <IP_ADDRESS>:27019: timed out,<IP_ADDRESS>:27018: timed out

command：
mongo-connector -m remote:27017 -t localhost:30000 --logfile=mongo_status.log -n test.status    -d mongo_doc_manager
If I sync mongo-connector on a remote host, there is no error, but the data is not synchronized
command：
mongo-connector -m localhost:27017 -t remote:30000 --logfile=mongo_status.log -n test.status    -d mongo_doc_manager

Hi, did you ever reach a resolution for this? I am running into the same problem. When I start mongo-connector ServerSelectionTimeoutError: <host>:<port> timed out but this host is one that I removed from the mongodb Replica Set at an earlier time.


Hand + Face of Human Pose

Hi,
Is it possible to generate a single character from the Pose for about 5 seconds?
I have a video of Pose ( openpose + hands + face) and i was wondering if it is possible to generate an output video withe the length of 5 seconds that has a consistent character/Avatar which plays Dance, .... from the controlled (pose) input?
I have a video of OpenPose+hands+face and i want to generate human like animation (No matter what, but just a consistent Character/Avatar)
Sample Video
Thanks
Best regards

Thanks for your interest.
I would recommend some works focus on  human pose generation ( https://github.com/mayuelala/FollowYourPose) or talking head generation (portrait.github.io), and using checkpoint finetuned on human (anything)
Our framework focuses on open-domain text-driven generation and can be sub-optimal for your human generation task.


Iteration triggers clippy::shadow_reuse

#![deny(clippy::shadow_reuse)]

fn main() {
    let array = [1, 2, 3];
    let _ = quote::quote!(#(#array)*);
}

As seen above, the internal quote! implementation triggers clippy::shadow_reuse in downstream projects. To avoid such behaviour, please consider tweaking the codebase or #[allow(clippy::shadow_reuse)] where applicable.

I would prefer if this were fixed in clippy. As a restriction lint this shouldn't be triggering in macro-generated code unless quote itself opted into the restriction.


Update logback-classic, logback-core to 1.4.7

About this PR
📦 Updates

ch.qos.logback:logback-classic
ch.qos.logback:logback-core

from 1.4.3 to 1.4.7
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "ch.qos.logback" }
}]

labels: test-library-update, early-semver-patch, semver-spec-patch, commit-count:1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 75.394%

Files with Coverage Reduction
New Missed Lines
%

scassandra/src/main/scala/com/evolutiongaming/scassandra/CreateClusterJ.scala
3
48.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
383

Relevant Lines:
508

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.6%) to 75.299%

Files with Coverage Reduction
New Missed Lines
%

scassandra/src/main/scala/com/evolutiongaming/scassandra/PoolingConfig.scala
1
91.18%

scassandra/src/main/scala/com/evolutiongaming/scassandra/SocketConfig.scala
2
53.85%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
378

Relevant Lines:
502

💛  - Coveralls

Superseded by #206.


fix compile failed caused by sse4_2

CentOS-7
gcc 11

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Create HTML DOM Element Object functions

Create HTML DOM Element Object functions

We will use this approach #86 that can minimise spaghetti code.
So, we don't need to create pure functions for everything.


Filtering not working

Trying to filter in vuetable-2 its not working. Same with sorting. It works when i use default data from http://vuetable.ratiw.net/api/users . But does not work with my data.
This is my output data
{
    "prev_page_url": null,
    "next_page_url": "http://<IP_ADDRESS>:8000/requests?page=2",
    "current_page": 1,
    "from": 1,
    "last_page": 14,
    "per_page": 15,
    "to": 15,
    "total": 200,
    "data": [
        {
           ......
      }
  ]

}

@mantey-github In API mode, Vuetable does not handle filtering and sorting on its own. It just sends parameters back to the server for processing and returning the result to it. In Data mode, it will call your provided function to do necessary processing (in this case, filtering and sorting) and wait for the returned result. Please go through the documentation here.

I am using the API mode and this is how I return the data from my server with Laravel
$requester = Requester::with('location:requester_id,id,location_name')
                              ->select([ 'id', 'requester_id', 'email', 'phone_number', 'created_at',
                                         DB::raw("CONCAT(other_names,' ',surname)  AS name")
                              ])->paginate();

        $requester = $requester->toArray();

        asort($requester);

        unset($requester['first_page_url']);
        unset($requester['last_page_url']);
        unset($requester['path']);
        unset($requester['path']);

        return $requester;

My output
{
    "prev_page_url": null,
    "next_page_url": "http://<IP_ADDRESS>:8000/list-of-requesters?page=2",
    "current_page": 1,
    "from": 1,
    "last_page": 14,
    "per_page": 15,
    "to": 15,
    "total": 200,
    "data": [
        {
            "id": 1,
            "requester_id": "RDM1",
            "email"<EMAIL_ADDRESS>            "phone_number": "0501377866",
            "created_at": "2018-08-24 00:09:57",
            "name": "Daniel Mantey",
            "location": {
                "requester_id": "RDM1",
                "id": 1,
                "location_name": "Emmie Ford"
            }
        },
        {
            "id": 3,
            "requester_id": "RRCP761",
            "email"<EMAIL_ADDRESS>            "phone_number": "+9247011069789",
            "created_at": "2018-08-24 00:09:58",
            "name": "Keara Medhurst",
            "location": {
                "requester_id": "RRCP761",
                "id": 2,
                "location_name": "Carter Drives"
            }
        },
        {
            "id": 4,
            "requester_id": "RNZD575",
            "email"<EMAIL_ADDRESS>            "phone_number": "+2994366533334",
            "created_at": "2018-08-24 00:09:58",
            "name": "Sydnie Lynch",
            "location": {
                "requester_id": "RNZD575",
                "id": 3,
                "location_name": "Halvorson Coves"
            }
        },
       ....


Docs link on homepage leads to dead page

Describe the bug
I was trying to pull up the docs to look into some of the packages available and was greeted with the following error after clicking Docs at the top of the site:

To Reproduce
Steps to reproduce the behavior:

Go to Nishan homepage.
Click on 'Docs' in the toolbar.
Note the error received, and the path attempted (/docs/root).

Expected behavior
I'd expect to be directed to the /docs endpoint with the documentation.
Screenshots
I've attached screenshots above.
Desktop (please complete the following information):

OS: macOS Version 11.2.1 (Build 20D74)
Browser: Chrome
Version 89.0.4389.90 (Official Build) (x86_64)

Additional context
From what I can tell, it's simply the Docs element/tag routing to an invalid path (/docs/root) instead of the correct one (/docs).

Hey, thank you for pointing out this issue. I've been really busy working on the coding side of things that I hardly had any time to put any effort into making sure that the doc works correctly. It should be an easy fix. I'll try to fix it within a few hours.

If it's possible you could join the discord server. The doc is a bit underwhelming at the moment. There is still a lot of work to be done.

Gladly! I'll pop in here shortly 😊

Hey, thank you for pointing out this issue. I've been really busy working on the coding side of things that I hardly had any time to put any effort into making sure that the doc works correctly. It should be an easy fix. I'll try to fix it within a few hours.

And no worries! I tried finding the code myself but I'm not sure which repository backs the website 😅


black header hides page content (overlays on top of it)

The black CF MetaData header is styled in such a way that it obscures the actual content of the page. This is worked around in most of the pages by leaving several blanks lines at the top of the page.
But when you are linking to content within a page (anchored content), the browser puts the anchor at the top of the page, which is behind the top border. Users will be confused because they won't see the section title that they just tried to jump to.
To make the anchor links work as expected throughout the pages, it will be necessary to fix the styling on the header.

Has this pull request been submitted?

I don't know whether this has been done. If no-one else knows, I suggest we close this issue in three weeks from now (on 29th September).

The issue does not appear to be fixed. Navigating to an anchor on the governance page, the title at the anchor is covered by the nav header.
Does anyone on the @cf-convention/info-mgmt team (or anyone else) know CSS well enough to see if there is an easy fix for this for this issue?

The navigation header varies in height depending on the width of the browser window (e.g. on a mobile device) so a fixed size offset can't work consistently.
I suggest either:

Move the vertical scroll bar down to the "container" div (e.g. by setting height: 100% on the html and body elements and height: 100%; overflow-y: scroll on the "container" div. You might also want to nest the content within another div to allow the scroll bar to stay on the far right of the screen.)
Simply stop the navigation header being fixed to the top of the window. It's simpler overall (easier to maintain, less likely to go wrong on random browser X, etc.) and doesn't really detract from the ease of use of the site.

(If you do decide to stick with a fixed position header and a fixed size offset then setting the scroll-padding-top property on the html element should be the easiest way.)

Dear @rhattersley
Thanks for explaining. I agree that the second option is better. I don't know which bit of the code does that. I suppose it must be in this block from _layouts/default.hml.

          <button type="button" class="navbar-toggle" data-toggle="collapse" data-target=".navbar-collapse">
            Toggle navigation
          </button>
          CF MetaData

            {% assign pages_list = site.pages %}
            {% assign group = 'navigation' %}
            {% include pages_list %}

Is style="position: relative; top: -10px" the thing which fixes it there, perhaps?
Do you know if there's a way to see what a GitHub-generated website will look like from a pull request, before merging it and it goes live?
Best wishes
Jonathan

To remove the fixed aspect I think it's just:

Remove the navbar-fixed-top class from the navbar div.
Remove the padding-top from the body.
Force the "margin-bottom" to zero on the navbar div.

All of which are controlled in _layouts/default.html as you had identified.
I'm not aware of any simple way of having a preview version of a Pages site for a pull request, but if you want to be thorough and don't mind the complexity... thanks to a GitHub workflow that's been defined for this repo, you can download a built version of the site for each pull request by navigating to the "Actions" tab and then finding the relevant "Check Jekyll Build" run, e.g. https://github.com/cf-convention/cf-convention.github.io/actions/runs/1214286324 is currently the latest run for pull request #161. At the bottom of which there's a 600+ MB "CF Website" zip file you can download and then preview.
For a simple change like this though, I would just use the developer tools in Firefox/Chrome (Ctrl+Shift+I) to dynamically explore & modify the contents of the page and then translate that back to the repo content.

Well, it's easy when you know how! But I certainly didn't. Thanks @rhattersley for your prescription for the navigation bar. I have implemented this in https://github.com/cf-convention/cf-convention.github.io/pull/161.

Daniel @erget proposes to merge https://github.com/cf-convention/cf-convention.github.io/issues/162, which includes this change, and no-one has objected here or there, so I'll close this issue now.


Determine what will happen with the current mechanistic classifications of MF

Investigate the mechanistic differentia currently used in the MF class hierarchy and consider how this axis of classification relates to the reaction-composition based approach proposed here. See e.g., oxidoreductase activity.
Most of the structure in the MF portion of the ontology is based on the EC, classification system. The major axis of differentiation for that system is by reaction mechanism, although in some cases is is a mixed bag of mechanism and reactant classification. It probably makes the most sense to keep the asserted class hierarchy in place and create logical definitions based on reactants. This will be valid as long as there are not cases where a different mechanism is used for exactly the same reactants in a reaction.
Keeping the structure of logical definitions based on reactants and asserted relations based on mechanism will allow ontology editors and annotators to infer MFs by entering participants of a reaction and running the reasoner. We will need to explore this a bit more.

We will leave them as asserted relations and not include them in the equivalence axioms.


Debug assertion thrown when trying to get values from XLRow, MSVC 2022, MFC

Working in VS Community Edition 2022, I have successfully built OpenXLSX through CMake and DOxygen docs, run all demo programs as console apps.
I need to use OpenXLSX in an existing legacy MFC application.   In Debug I can successfully open a workbook and worksheet and iterate through the rows and can view the contents of XLRow.   However, as soon as I change the code to read the values in a row, a debug assertion is thrown.
Here is the code snippet:
void  CBeckyDlg::ReadExcelFile(const CString sExcelFileName)
{
	CString sTemp;
	XLDocument doc;
	// need to convert from CString to std::string
	std::string s((LPCTSTR)sExcelFileName);
	doc.open(s);
	// open the worksheet note hard-wired name, need to fix
	auto wksDE = doc.workbook().worksheet("AllDEData_7_9_2023");

	int column_count = wksDE.columnCount();
	int row_count = wksDE.rowCount();
	// write the worksheet size to the output file
	sTemp.Format("Excel File %s Rows %d Columns %d\n", sExcelFileName, row_count, column_count);
	gOutputFile.WriteString(sTemp);
	gOutputFile.Flush();

	int rowcounter = 0;
	XLRow tempXLRow;
	std::list<XLCellValue> writeValues;
	// iterate through the first 10 rows of the worksheet
	for (auto& row : wksDE.rows()) {
		rowcounter++;
		tempXLRow = row;
		//writeValues = tempXLRow.values();  // PROBLEM HERE IF I UNCOMMENT
		if (rowcounter > 10)
			break;
		sTemp.Format("Excel Row %d\n", rowcounter);
		gOutputFile.WriteString(sTemp);
		gOutputFile.Flush();
		}
	doc.close();
	return;
}`

This code, when run with the writeValues=tempXLRow.values() line commented out, generates output as it should:

Excel File C:\ProgramData\Beachfx\Data\AllDEData_7_9_2023.xlsx Rows 1075 Columns 27
Excel Row 1
Excel Row 2
Excel Row 3
Excel Row 4
Excel Row 5
Excel Row 6
Excel Row 7
Excel Row 8
Excel Row 9
Excel Row 10

The error that is thrown is:
Program: C:\Projects\BeachFx\BeachFxCodeWorkingCopy\Debug\BeachFx.exe
File: minkernel\crts\ucrt\src\appcrt\heap\debug_heap.cpp
Line: 996

Expression: __acrt_first_block == header

For information on how your program can cause an assertion
failure, see the Visual C++ documentation on asserts.

(Press Retry to debug the application)
The thread 0x1488 has exited with code 0 (0x0).
The thread 0x3a94 has exited with code 0 (0x0).
The thread 0x60c has exited with code 0 (0x0).
A breakpoint instruction (__debugbreak() statement or a similar call) was executed in BeachFx.exe.

Debug Assertion Failed!

Program: C:\Projects\BeachFx\BeachFxCodeWorkingCopy\Debug\BeachFx.exe
File: minkernel\crts\ucrt\src\appcrt\heap\debug_heap.cpp
Line: 996

Expression: __acrt_first_block == header

I just need a workaround so that I can extract the non-homogeneous row data (columns are variously numbers, strings, dates) from the returned std::list.

Note that I have tried various attempts from the demo examples, the above code snippet is the simplest I have found that allows the needed iteration through the rows.

I’m also running this code inside a MFC app, with no issues.
Could it be compiler settings?
https://learn.microsoft.com/en-us/answers/questions/240332/assert-when-using-mtd-dynamic-library

Thank you for this suggestion.   I am still trying to work through it, not there yet.
Do you know if it is also necessary to modify the build of OpenXLSX through CMake for debug?  I am building as a static library, would this be better as a shared library?

it’s been some time, I used visual studio cmake tools to generate CMakeSettings.json. for debug and release
I am also using a static library, which I think it’s better because of whole program optimization

@rmmales I am in the process of going through the backlog of issues - are you still active? Could you test whether your issue is reproducible with the current version of OpenXLSX and post some feedback here?
Thank you!

I have not attempted to use the tool for some time and have left that
project.   However, I will try the new version at some point when I have a
chance and get back to you.
Dick
On Mon, Sep 2, 2024 at 4:05 AM aral-matrix @.***> wrote:

@rmmales https://github.com/rmmales I am in the process of going
through the backlog of issues - are you still active? Could you test
whether your issue is reproducible with the current version of OpenXLSX and
post some feedback here?
Thank you!
—
Reply to this email directly, view it on GitHub
https://github.com/troldal/OpenXLSX/issues/222#issuecomment-2324080420,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG4MBWUJ7JK2XDQDBDYJME3ZUQL5HAVCNFSM6AAAAABNPZFUCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRUGA4DANBSGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@rmmales : Thanks for the update & I'll keep this open for now.


Adds changes to pre-commit-hooks version

I have simply changed the version for pre-commit-hook.

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.AJGX17 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add support for LUIS V3 endpoint

This includes supporting (and tests) for dynamic lists and external entities.  This was done by calling the REST API directly in order to support both V2 and V3 in the same dll.
The SDK has renamed or mapped a number of things from the V3 SDK, either to match existing results or to be clearer.  It would be great if some of those end up in the V3 LUIS endpoint, but the only one that is required is mapping geo to an object.

Pull Request Test Coverage Report for Build 71147

0 of 0   changed or added relevant lines in 0 files are covered.
19 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.2%) to 77.308%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizer.cs
3
81.73%

/libraries/Microsoft.Bot.Builder.AI.LUIS/LuisUtil.cs
4
94.88%

/libraries/Microsoft.Bot.Builder.Dialogs/ComponentDialog.cs
12
78.16%

Totals

Change from base Build 70288:
0.2%

Covered Lines:
5325

Relevant Lines:
6888

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1


Updating schedule should recalculate next session time

Schedule was not recalculated when a new revision is pushed. This
becomes a problem when a previous revision has a daily schedule by
acccident and new revision fixes it to hourly schedule.

👍
Left some minor comments, though


ParameterState: Fix when subscribing only to EventCallback

Description
This fixes an interesting problem when you subscribe only to EventCallback and modify the child, for example you have content collapsed and you want to expand it via public method like ToggleAsync, the content would not expand, when it should.
Consider this as example:
<MudExpansionPanels>
	<MudExpansionPanel Text="Panel with async loaded contents" MaxHeight="1000" IsExpandedChanged="ExpandedChanged">
		Secret content
	</MudExpansionPanel>
</MudExpansionPanels>

@code {
    private void ExpandedChanged(bool newVal)
    {
    }
}

Note that when you click on expansion, you are triggering inner child toggle method
Before

After

The line in unit tests that specifically tests that this moment is covered:
https://github.com/MudBlazor/MudBlazor/blob/16d23398c928027782e1ef5bae545229834237a9/src/MudBlazor.UnitTests/State/ParameterStateUsageTests.cs#L235
and
https://github.com/MudBlazor/MudBlazor/blob/16d23398c928027782e1ef5bae545229834237a9/src/MudBlazor.UnitTests/State/ParameterStateUsageTests.cs#L250
aka the content must show when clicked and state should correspond that it's opened, before the fix this would fail.
How Has This Been Tested?
New bUnit tests that took me few hours to make...
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

@henon I'm merging this ASAP, but just FYI and I recommend you to rebase your branches where you work on ParameterState.


MongoDB plugin filter based on action trace

This PR addresses issue #5292

Nice catch and write up.

I'm not sure why it failed on first two builds, and apparently I have no access to the building logs, so is there anything I can do to fix these?

Assuming that is an issue with our build machine. Looking into it.

If you get a chance before me, would you mind rebasing to release/1.2.x. Would like to get this in the next patch release.

Sure, will do

Rebased to release/1.2.x in #5306


Examine alternatives for avoiding the boilerplate code in regression tests

Perhaps by using a class decorator.
Internal issue: https://madra.cscs.ch/scs/reframe/issues/402

@eth-cscs/reframe-devteam What do you think about the following way of writing tests without using any boilerplate code (I have already a working proof-of-concept):
@autoinit
class NewStyleBaseTest(RegressionTest):
    def __init__(self, a, b, c):
        self.name = 'new_style_%s_%s_%s_test' % (a, b, c)
        self.a = a
        self.b = b
        self.c = c

@register_test
class NewStyleTest(NewStyleBaseTest):
    def __init__(self):
        super().__init__(4, 5, 6)

@register_tests((a, b) for a in range(3) for b in range(3))
class NewStyleTest2(NewStyleBaseTest):
    def __init__(self, a, b):
        super().__init__(a, b, 10)

Of course, the decorators will be namespaced somewhere under reframe.


Step 4: Start report: Add theme definitions

Description:
This ticket is to write a definition for each theme that was identified in #350.
Acceptance Criteria:

[x] Define each of the themes/categories identified in #350 for Aug 2023 emails
[x] Category title, definition and percentage of emails that fall into that category are written in a word doc report (saved in teams channel)

Development Checklist:

Maximum of 16 categories/themes identified

Sub categories are not necessary

Dependencies

access to emails
blocked by #350

Definition of Ready

[x] Acceptance criteria are included
[x] Dependencies are identified (technical, business, regulatory/policy)
[x] Story has been reviewed and questions answered

Definition of Done

In progress:

[ ] Acceptance criteria are complete

PO Review:

[ ] Acceptance criteria are confirmed complete
[ ] Reviewed and approved by Product Owner

Notes:

moving to done


Add .git to builds

feat(deis-builder/add_dot_git): Add .git to builds
The current deis git push behavior strips .git from the build. This happens during the "git archive" step in the deis-builder template/builder script. In order to use submodules, the "git archive" method of sending the tarball to "docker build" needs to be replaced. As the repo is bare, it needs to be cloned to the TMP_DIR and checked out to the $GIT_SHA of the deployment. This also allows for the use of submodules in deployments.

Thankfully, in this context, we aren't destroying anything.
The TMP_DIR is actually cloned from a bare git repo, it is empty except for the .git directory that was copied over.
That TMP_DIR is indeed temporary (see the mktemp a few lines up). As such, there is no history there to be lost.
The big problem here is that you can't simply do a "git checkout $GIT_SHA" as it will blow up telling you that the .git/HEAD mentions "refs/origin/master" and that doesn't exist if you didn't git push a master branch yet. So, what you end up doing, is doing a: "git checkout $(git branch -a)" followed by a "git checkout $GIT_SHA", all to end up with effectively the same thing you would have had by doing a "git reset --hard $GIT_SHA" in the first place. One way you would be in a local branch named after whatever branch they pushed checked out to the specific SHA1, the other way you end up in a disassociated branch checked out to the specific SHA1. The net effect is ambiguous after build time anyway, it's really a question of what the slug runtime sees when it tries to use that .git tree.

After a bit of reading between the two, essentially they do the same thing for this operation so I guess it doesn't really matter either way.

@ianblenke would this close #1094?

Code LGTM.

Code LGTM. We should test this against a project with submodules.

Aye, this would potentially close #1094, with the caveat that you still must manage your ssh keys with your own buildpack (which we might build an example of) or in a Dockerfile as a RUN step. This fix merely makes .git available for use by a buildpack/Dockerfile.
In some cases, it might actually impair customers who expect a smaller resultant layer due to the fact that their .git has been ignored until now.
It might not be a bad idea to make this behavior conditional somehow to avoid that.
Principle of least surprise though: which is more surprising, finding that .git isn't included when doing a deploy, or finding that your smallish images are suddenly larger thanks to .git being included in a newer version of Deis?

IIRC Heroku strips this directory from the final slug. It might be better to clone the repository, initialize submodules then strip .git so the behaviour stays the same.

The question then becomes when to initialize the submodules. If we move that functionality into the deis build script, we have to take into account private credentials for private git repos. If we leave it up to the buildpack/Dockerfile, do we leave it up to those mechanisms to make that decision or whether or not to strip the .git folder? While we could conceivably strip the .git folder after building a slug using a buildpack, we can't really remove the space overhead in a layer generated by an app's Dockerfile - unless we just want to flatten all such app Dockerfile generates images into a slug-like form before deploying to further help possibly minimizing deploys (but not sharing anything between deploys as a result)...

hmm, I'm wondering if we should close this in favour of #3259 since that seems to cover all bases proposed here (private buildpacks, SSH keys, and heroku submodules).

@bacongobbler, I ran into problems attempting to use a shallow git clone with submodules, so I don't believe we can use the --depth 1 option as in #3259.

I ran into problems attempting to use a shallow git clone with submodules, so I don't believe we can use the --depth 1 option as in #3259

I don't see a --depth=1 being used in #3259..?

Unfortunately #3305 has to do with ssh keys. So does #3259. While that does help access to private repos, and is an important thing to consider as it is tangentially related to this issue, neither really addresses the submodules versioning problem.
According to this StackOverflow post, the commit sha1 of the submodule "is stored in Git's object database directly. The tree object for the directory where the submodule lives will have an entry for the submodule's commit (this is the so-called "gitlink")".
I just tried to create a pair of local git repos and have one file:// reference the other as a submodule, and I could shallow clone that with --depth=1 and it would indeed retain the submodule sha1, even after having added a few commits. The submodule sha1 metadata is being retained even in a shallow clone.
The point of this PR is really to make sure we clone the entire tree, including the .git folder. Without .git, there is no way to access this sha1 version metadata, and that is the larger problem that the ssh related issues don't address.

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

@ianblenke If you are looking for a git repo with lots of submodules and commits, see https://github.com/FuturesJS/FuturesJS - it isn't an app, but you may find it useful to test with what you're working on.

@ianblenke after our PR review this morning, we evaluated this and felt like this is a very special use case. This is a perfect use case for customizing the builder, but considering that the SSH_KEY PR should cover most of problems towards initializing submodules we're going to close this as a wontfix.


KNL-1400; mail from Yahoo is sometimes lost

I created an alternative PR here: #1440

I think Rutgers will probably use my original code. I’d rather use the actual address where we know it’s OK. Most of our addresses are Rutgers addresses. It’s silly to replace them. Mail programs often don’t show reply-to, so users are likely not to realize what’s going on.
Using postmaster as a default replacement address is fine, but I’d like the ability to override it.

On Dec 10, 2015, at 6:09:36 PM, Sam Ottenhoff<EMAIL_ADDRESS>wrote:
I created an alternative PR here: #1440 https://github.com/sakaiproject/sakai/pull/1440
—
Reply to this email directly or view it on GitHub https://github.com/sakaiproject/sakai/pull/1438#issuecomment-163782149.

I think Rutgers will probably use my original code.

Why don't we create code that works for everyone?

I’d rather use the actual address where we know it’s OK.

How is your original code doing this? I don't see any lookups to see if the domain is using DMARC.

It’s silly to replace them.

Well Yahoo, Google, etc are clearly telling us not to spoof FROM anymore. We either conform to the new demands or refuse to. I don't understand the middle path you're trying to take.

Mail programs often don’t show reply-to, so users are likely not to realize what’s going on.

Okay, then I'd recommend we attempt some sort of "On behalf of " in the FROM address personal section.

Using postmaster as a default replacement address is fine, but I’d like the ability to override it.

smtpFrom<EMAIL_ADDRESS>

On Dec 10, 2015, at 6:25:42 PM, Sam Ottenhoff<EMAIL_ADDRESS>wrote:
I think Rutgers will probably use my original code.
Why don't we create code that works for everyone?
I’d rather use the actual address where we know it’s OK.
How is your original code doing this? I don't see any lookups to see if the domain is using DMARC

The original code allows any address ending in rutgers.edu http://rutgers.edu/ through without change. That represents a very large fraction of our usage.

It’s silly to replace them.
Well Yahoo, Google, etc are clearly telling us not to spoof FROM anymore. We either conform to the new demands or refuse to. I don't understand the middle path you're trying to take.
Mail programs often don’t show reply-to, so users are likely not to realize what’s going on.
Okay, then I'd recommend we attempt some sort of "On behalf of " in the FROM address personal section.
Using postmaster as a default replacement address is fine, but I’d like the ability to override it.
<EMAIL_ADDRESS>mailto:smtpFrom<EMAIL_ADDRESS><EMAIL_ADDRESS>—
Reply to this email directly or view it on GitHub https://github.com/sakaiproject/sakai/pull/1438#issuecomment-163784964.

The original code allows any address ending in rutgers.edu http://rutgers.edu/ through without change. That represents a very large fraction of our usage.

I'd like to see one consistent and sustainable solution. What if example.edu institutes a strict reject DMARC policy?

In that case they would need to implement DKIM signatures for all their email generation. I’d assume Sakai would be included. You can’t do DMARC in that mode without expecting to have to do work on software that generates email. If we see a significant number of schools doing that, we’ll want to add it to Sakai. Of course if you did strict DMARC, Sakai would have to sign even the<EMAIL_ADDRESS><EMAIL_ADDRESS>
On Dec 10, 2015, at 10:19:28 PM, Sam Ottenhoff<EMAIL_ADDRESS>wrote:
The original code allows any address ending in rutgers.edu http://rutgers.edu/ http://rutgers.edu/ through without change. That represents a very large fraction of our usage.
I'd like to see one consistent and sustainable solution. What if example.edu institutes a strict reject DMARC policy?
—
Reply to this email directly or view it on GitHub https://github.com/sakaiproject/sakai/pull/1438#issuecomment-163825847.

they would need to implement DKIM signatures for all their email generation. I’d assume Sakai would be included.

SPF, DKIM, and DMARC allow separate rules for subdomains. I don't see any reason why Sakai will be forced to implement DKIM in the near future.

If we see a significant number of schools doing that, we’ll want to add it to Sakai.

Why don't we just develop a long-term solution for Sakai that doesn't require another modification as commercial providers and organizations get stricter around email? Your code that delivers differently for the local institution isn't a universal fix.

What I'd really like to do is check with DNS to see which addresses actually need to be hacked. If there's existing Java support for that we should use it.

On Dec 10, 2015, at 11:11 PM, Sam Ottenhoff<EMAIL_ADDRESS>wrote:
they would need to implement DKIM signatures for all their email generation. I’d assume Sakai would be included.
SPF, DKIM, and DMARC allow separate rules for subdomains. I don't see any reason why Sakai will be forced to implement DKIM in the near future.
If we see a significant number of schools doing that, we’ll want to add it to Sakai.
Why don't we just develop a long-term solution for Sakai that doesn't require another modification as commercial providers and organizations get stricter around email? Your code that delivers differently for the local institution isn't a universal fix.
—
Reply to this email directly or view it on GitHub.

Let’s try this:
config variable mail.sendfromsakai. If it’s true, do the processing.
config variable mail.sendfromsakai.exeptions. If it’s specified, it’s a regexp. If from matches, it isn’t replaced. Defaults null.
If processing is on and it’s not an exception,
set reply-to to from
set from to config variable mail.sendromsakai.from, default postmaster@
set the text in the from to a string that has replacements for address and personal name.
The default replacement would be “on behalf of , ”. or even “reply will go to , "
The address and replacement needs to be configurable to handle site whose expected language isn’t English. I don’t think the kernel knows the language of the tool sending the message, so the language probably needs to be site-wide.

On Dec 10, 2015, at 11:11 PM, Sam Ottenhoff<EMAIL_ADDRESS>wrote:
they would need to implement DKIM signatures for all their email generation. I’d assume Sakai would be included.
SPF, DKIM, and DMARC allow separate rules for subdomains. I don't see any reason why Sakai will be forced to implement DKIM in the near future.
If we see a significant number of schools doing that, we’ll want to add it to Sakai.
Why don't we just develop a long-term solution for Sakai that doesn't require another modification as commercial providers and organizations get stricter around email? Your code that delivers differently for the local institution isn't a universal fix.
—
Reply to this email directly or view it on GitHub https://github.com/sakaiproject/sakai/pull/1438#issuecomment-163834754.

What I'd really like to do is check with DNS to see which addresses actually need to be hacked. If there's existing Java support for that we should use it.

I can't imagine anyone is going to go down this path. There is too much complexity, too many edge cases, too many differences in behavior. I'm opposed to a large engineering effort here with lots of different handling based on email address parsing.


Feature request: streaming support (and thus allow piping)

For my application, I need to pipe a file form upload to another stream (this is some socket connected to my server).
Formidable is closest to what I need, but it does not seem to have thought of such streaming. I tried to overwrite onPart, but these parts are not streams.
Adding streaming support (and thus allow piping to another stream) would greatly improve the possibilities with Formidable, I truely hope this will get some attention.

Do you have an example of how could I pipe the file being uploaded by formidable to another stream?


ERROR: No mapping for the Unicode character exists in the target multi-byte code page

When running a definition, if some file name contains Unicode characters, this error occurs, and the process is interrupted.

You can avoid this with disabling Logging od set encoding to ANSII in UEngine.pas
--> TFile.AppendAllText(pubLogFile, DateTimeToStr(Now)+' - '+LogFilePrefix+Text + #13#10, TEncoding.ANSI);

You can avoid this with disabling Logging or set encoding to ANSII in UEngine.pas --> TFile.AppendAllText(pubLogFile, DateTimeToStr(Now)+' - '+LogFilePrefix+Text + #13#10, TEncoding.ANSI);

Right, but the text being sent to the log file contains unicode characters. So, in this case, it would not be correct for me to include a line in the file forcing ANSI encoding, right?


Teach SubstitutionMap::isIdentity about non-canonical generic params

Do a weaker check here that only looks at the canonical generic params and guarantees that those substitute to themselves. There may be replacement types for other generic params too, to canonicalize them, but that's not a problem.
This fixes a crash trying to mangle decls with opaque result types that have generic signatures that canonicalize away a generic parameter.
rdar://problem/51775857

Can you think of any other interesting test cases that I didn't include?
@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - d2d6631e823d93dc0bf85be7c3efc7bc0b20dfc2

Build failed
Swift Test Linux Platform
Git Sha - d2d6631e823d93dc0bf85be7c3efc7bc0b20dfc2

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - d2d6631e823d93dc0bf85be7c3efc7bc0b20dfc2

Build failed
Swift Test OS X Platform
Git Sha - d2d6631e823d93dc0bf85be7c3efc7bc0b20dfc2

@swift-ci Please smoke test

@swift-ci Please smoke test


component for ajax request

Hi
I use this component for checking ajax request
<?php

namespace app\component;

use yii;
use yii\filters\VerbFilter;

class myAjaxAccess extends VerbFilter{

    public function beforeAction($event)
    {

         $action = $event->action->id;
        if (isset($this->actions[$action])) {
            $verbs = $this->actions[$action];
        } elseif (isset($this->actions['*'])) {
            $verbs = $this->actions['*'];
        } else {
            return $event->isValid;
        }
////check if action is ajax request=> allowed
         if(in_array('ajax',$verbs))
        {
            if (Yii::$app->request->isAjax) {
                return $event->isValid;
            }
            else
            {
                throw new yii\web\MethodNotAllowedHttpException('Method Not Allowed. This url can only handle the following request methods:AJAx ');

            }
        }

        return parent::beforeAction($event);

    }

}

My problem is I can not use this class?

How do you use it? What do you expect?
Please notice, that GitHub is for bug reports. We are happy to help you on support forum or in gitter room https://gitter.im/yiisoft/yii2. It's always better to text there, unless you are sure it is a Yii2 core problem.

'verbs'=>[
'class'=>myAjaxAccess::className(),
'actions'=>[
'index'=>['get'],
                    '*'=>['ajax'],
                ]
            ]

i am not sure but i think it is a bug
yii could not be found Ajax request

What happens when you access index page with plain GET? If the result does not match your expectations, describe them.
What do you get when you access index page with AJAX? If the result does not match your expectations, describe them.
What do you get when you access any other action with AJAX? If the result does not match your expectations, describe them.
What do you get when you access any other action with AJAX? If the result does not match your expectations, describe them.

'verbs'=>[
'class'=>VerbFilter::className(),
'actions'=>[
'index'=>['get'],
                '*'=>['ajax'],
            ]
        ]

when i have an ajax request ...

Please, post exact answers to my questions.


Refactor interview submission logic

Currently, interviews will only close if 2 interviewers submit their notes. Change this to close if the interviewers who have submitted match the interviewers in the timeslot (i.e. allow for cases of single interviewer)

Fixed (sort of) in https://github.com/BUUPE/Inquisitor/tree/improvements/3.0


fix(ast, codegen, linter): panics in fixers.

Fixes panic in this action:
https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/10685877915/job/29619941099

#5431  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on  Graphite

does this fix all of the panics in that action?

Oh wait I forgot to say that we should add some tests. I intend to change how codegen deals with source_text at some point.

I am converting this to draft while I'm trying to find a good way to test it.
Do you have any specific approach for testing this in mind? What part should I test? The reason behind the panic was that I assumed source_text in the codegen would always be set similarly to formatter, That's why we encountered out-of-bound issues when trying to generate regexes. Now that fixers are operating on a codegen with source_text, This error is resolved.
The pattern.source_text method is a dead simple function and to_string/Display has its own set of tests.
We use source_text when available because the regex pattern loses some of the information from the original input so subsequently in some cases, we can't recreate the exact original input with the Display trait. We might even want to do the same thing for regex flags because as of now we change their order(However this is a small issue compared to the pattern itself which is more annoying if it changes unintentionally).

The linter rule tests should have at least 1 fixer test.
We should also have one integration test in apps/oxlint/src/lint/mod.rs with the fixture in apps/oxlint/fixtures/linter/debugger.js


Revert "make/archive: Use the full path name when matching or storing…

Summary
Revert https://github.com/apache/nuttx/pull/10395 (commit 563125fde3483b6dac97ee4a3ea4e93102f25b2d)
The P option of ar command has the following description.
P   Archives created with full path names are not POSIX compliant

Thus, it cannot extract or strip archive files with path names directly.
$ arm-none-eabi-ar x libm.a
bin//lib_acosf.o: No such file or directory
$ arm-none-eabi-strip --strip-unneeded libm.a
arm-none-eabi-strip: stnJhpyc/bin//lib_acosf.o: No such file or directory

If the P option is not mandatory for NuttX, it should avoid mixing the same filename in one archive file without P option.
Impactc
None
Testing
Build: Pass

There is already the same PR working on this issue, let's wait for this commit to be merged
https://github.com/apache/nuttx/pull/10973

Depends on: https://github.com/apache/nuttx-apps/pull/2138

need rerun CI when https://github.com/apache/nuttx-apps/pull/2138  was merged

@SPRESENSE Please rebase this PR

rebase done.


How to set the number of processes a.k.a. n_jobs?

Dear all,
I am using the TabularPredictor. However, I am missing a parameter to set the number of processes/jobs that are used.
Can somebody please give me hint how to configure that?
Thank you for your help.
Best regards,
Felix

predictor = TabularPredictor(...).fit(..., ag_args_fit={'num_cpus': 16})

While not all models will respect this value currently, this will work for some models (the two neural networks).
If you happen to know the name of the hyperparameter that controls the cpu count for a particular algorithm, you can also pass it, such as:

hyperparameters={'GBM': {'n_jobs': 16}}

It's generally recommended to use the default (using all cores). We are currently working on parallel training via ray in the next release (v0.4).

@ShaohongBai This is very interesting and not what I would expect. Is it possible for you to provide a minimally reproducible example script + data?

Understood, no more questions.

Hi @Innixma would you consider putting out another release with this fix before 0.4?

@knoam The fix for the F1 metric issue / general speedups is in pre-release. You can get it via:
pip install --pre autogluon


gnulib: symlink include/ to lib/

so that some programs can find the headers automatically instead of
adding -I${gnulib}/lib

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: gnulib
Partial log (click to expand)
updateAutotoolsGnuConfigScriptsPhase
Updating Autotools / GNU config script to a newer upstream version: ./build-aux/config.sub
Updating Autotools / GNU config script to a newer upstream version: ./build-aux/config.guess
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash
make: Nothing to be done for 'all'.
installing
/nix/store/6rfmkma0nw1wxvy7g7f8g8mqqr9ihj4p-gnulib-20180226

Success on x86_64-linux (full log)
Attempted: gnulib
Partial log (click to expand)
unpacking source archive /nix/store/8xzcy8ldivf3l7dms88h5gzfadlnrgw9-gnulib-0bec5d5
source root is gnulib-0bec5d5
patching sources
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash
make: Nothing to be done for 'all'.
installing
/nix/store/232hm55bb26jyh7ll6f64zianwsfirfi-gnulib-20180226


1288: seed AP rooms and beds

This PR adds an ApprovedPremisesRoomsSeedJob which seeds rooms, their characteristics, and beds via the seeding script run on remote pod (or local environment) as:
./script/run_seed_job approved_premises_rooms rooms_with_characteristics

The CSV provided must have the following columns:

apCode
bedCode
roomNumber
bedCount
isSingle
isGroundFloor
isFullyFm
hasCrib7Bedding
hasSmokeDetector
isTopFloorVulnerable
isGroundFloorNrOffice
hasNearbySprinkler
isArsonSuitable
isArsonDesignated
hasArsonInsuranceConditions
isSuitedForSexOffenders
hasEnSuite
isWheelchairAccessible
hasWideDoor
hasStepFreeAccess
hasFixedMobilityAids
hasTurningSpace
hasCallForAssistance
isWheelchairDesignated
isStepFreeDesignated
notes

Feels a bit strange to me that Bed and Room names would need to be unique across the entire CAS1/CAS2/CAS3 combined estate?  e.g. Shouldn't Bed 1 be a valid name for a bed in every Room of a given a Premises?  Similarly, shouldn't Room 1 be a valid name for a Room in every AP?

@edavey seems sensible 👍 might need to double check which Postgres version we're on and how it handles NULLs wrt UNIQUE constraints - can we havve more than one entry in a table with a NULL value on a unique column?

might need to double check which Postgres version we're on and how it handles NULLs wrt UNIQUE constraints - can we havve more than one entry in a table with a NULL value on a unique column?

@brownbearsoftware we're on PostgreSQL 15.2. I believe the default behaviour is to treat nulls as distinct, so we can have multiple room records with a null code. Postgres 15 introduces a NULLS NOT DISTINCT option, which would make that impossible -- not what we want here...
See https://pganalyze.com/blog/5mins-postgres-unique-constraint-null-parallel-distinct


MediaData AI Crawler Blocker Checker

Description
This PR introduces a new app to check which media houses in the MediaData database block AI crawlers.
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

mediadata_ai_blocklist is a terrible name Mr. @kelvinkipruto ... we're 100% going to use this app for more than media data for one. My vote is naming it something related to checking whether website content data is accessible to bots e.g. accessbot, etc.


Fix breakpoint ppc64x

Fixes #52101

I was working on the wrong branch so I pushed a lot of unnecessary commits.

I was working on the wrong branch so I pushed a lot of unnecessary commits.

Fixed.


Possibility to merge results from several test binaries?

I have a test suite of multiple test binaries. The cmake files work so far, but they only seem to determine the coverage of one (first or last) test binary. Is there a way to merge the coverage results from multiple tests?

Hello,
I am a bit unsure what you mean exactly, is this a public project I can look at maybe?
But I mean you can have any number of test binaries, that is not what matters. You add each in CMake using the add_test cmake command.
https://github.com/JoakimSoderberg/coveralls-cmake-example/blob/master/CMakeLists.txt#L37
Then when the coverage is calculated, cmake will run each executable in turn and calculate the coverage and all that should be gathered in the output.
I mean this is how my Cmake script runs the actual tests:
https://github.com/JoakimSoderberg/coveralls-cmake/blob/3717770200eca844a19df8fc8001a087e17a0416/cmake/Coveralls.cmake#L68
Which is just a fancy way to run ctest --output-on-failure.
https://cmake.org/Wiki/CMake/Testing_With_CTest
CTest is a test runner which is independent from CMake itself... it will simply take a bunch of tests and run them. It does not care how many executables there are, it just has a list of tests

Clear previous coverage results
Ctests runs any number of executables (all executables must of course have been compiled with coverage)
Cmake script finds all gcov files outputted as tests ran (it does not care about test executables) and translates them to JSON and uploads to coveralls

What step 3 above cares about is not the executables, but the source files you want the coverage from (you specify these as per the instructions for this project in your CMake file).
Hope all that made sense :)

P.S.
I'd also recommend looking into https://codecov.io/ it's also free. And from my experience more stable + has more features. And is simpler to use :)

https://github.com/JoakimSoderberg/coveralls-cmake/blob/3717770200eca844a19df8fc8001a087e17a0416/cmake/CoverallsGenerateGcov.cmake
Oh yea, this does the meat of the collection business. As you see there, all it does is look for gcov files, nothing related to specific test executables.

Hi there, thanks for the quick response!
The project is nlohmann/json, and I added a feature branch (see https://github.com/nlohmann/json/tree/feature/cmake_cleanup) to move the build system to Cmake. See https://travis-ci.org/nlohmann/json/jobs/186321152 for the Travis job.
It uses the same C++ sources than the 100% covered develop-branch (see https://coveralls.io/builds/9376166), but instead of having one large binary, the test suite is split into several binaries. All are added via add_test. The CMakeLists are here and here.
If you need any further information, please let me know. I shall try not to run any tests before executing make coveralls.

You forgot the important part. The coveralls that does not have 100% coverage :)
https://coveralls.io/builds/9409833
Because what is interesting is the build output:
https://travis-ci.org/nlohmann/json/jobs/186347999#L630
Anyway if you look in that output you see that GCOV is rewriting teh .gcov file for each test:
File '/home/travis/build/nlohmann/json/src/json.hpp'
Lines executed:63.18% of 402
Creating '#home#travis#build#nlohmann#json#src#json.hpp.gcov'

File '/home/travis/build/nlohmann/json/src/json.hpp'
Lines executed:56.79% of 1539
Creating '#home#travis#build#nlohmann#json#src#json.hpp.gcov'

File '/home/travis/build/nlohmann/json/src/json.hpp'
Lines executed:82.56% of 1055
Creating '#home#travis#build#nlohmann#json#src#json.hpp.gcov'

File '/home/travis/build/nlohmann/json/src/json.hpp'
Lines executed:80.10% of 603
Creating '#home#travis#build#nlohmann#json#src#json.hpp.gcov'

File '/home/travis/build/nlohmann/json/src/json.hpp'
Lines executed:64.51% of 417
Creating '#home#travis#build#nlohmann#json#src#json.hpp.gcov'

...

File '/home/travis/build/nlohmann/json/src/json.hpp'
Lines executed:83.45% of 1432
Creating '#home#travis#build#nlohmann#json#src#json.hpp.gcov'

Your last test happens to cover 83.45% of the file, and that's what ends up on coveralls.
I cannot say I have noticed this behavior myself, but maybe I never ran this with multiple test EXEs come to think of it. Or... your gcov version is old and does
So just quickly googling I found this thread from 2007 about fixing this behavior.
https://gcc.gnu.org/ml/gcc-patches/2007-06/msg00423.html

this patch adds a new option to gcov: --merge-results (-m).
When this option is set, gcov reads all input files before writing results instead of writing results after each input file.
Therefore, if two .gcda reference a common source file com.c, only one com.c.gcov file is generated with counts added rather than two
com.c.gcov, the second one overwriting the first one.

The -m option is removed in a later version of the patch:

this is the updated version of the patch. No new option, results are merged as soon as there are multiple input files.

So this might depend on the gcov version. Seems this is not in versione < 4.3
...
I can't say I know the reason for this. If it's at the .gcda stage or the .gcov stage the files are not merged.
Codecov also supports pushing multiple reports for a single commit. Even from different OS versions and so on, as I said it has more features and is simpler to use. So look at that as an alternative.
Here is how easy it is to include. Since my cmake script has compiled + generated all coverage files it simply finds those and does a bunch of magic. So try that and see if it solves your issues:
https://github.com/JoakimSoderberg/cargo/blob/master/.travis.yml#L41
I am not really enough invested in this script to hunt down this bug. But if you can fix this a Pull Request is always welcome :)

Thanks for the response!


Yet another unofficial Diffuser support

Github: https://github.com/rootonchair/diffuser_layerdiffuse
This project is a port to Diffusers, it allows you to run transparent image with SD1.5 (transparent only or joint generation) and SDXL (Attn and Conv Injection) with Diffusers friendly API
Don't hesitate to give it a try
from huggingface_hub import hf_hub_download
from safetensors.torch import load_file
import torch

from diffusers import StableDiffusionPipeline

from models import TransparentVAEDecoder
from loaders import load_lora_to_unet

model_path = hf_hub_download(
        'LayerDiffusion/layerdiffusion-v1',
        'layer_sd15_vae_transparent_decoder.safetensors',
)

vae_transparent_decoder = TransparentVAEDecoder.from_pretrained("digiplay/Juggernaut_final", subfolder="vae", torch_dtype=torch.float16).to("cuda")
vae_transparent_decoder.set_transparent_decoder(load_file(model_path))

pipeline = StableDiffusionPipeline.from_pretrained("digiplay/Juggernaut_final", vae=vae_transparent_decoder, torch_dtype=torch.float16, safety_checker=None).to("cuda")

model_path = hf_hub_download(
        'LayerDiffusion/layerdiffusion-v1',
        'layer_sd15_transparent_attn.safetensors'
)

load_lora_to_unet(pipeline.unet, model_path, frames=1)

image = pipeline(prompt="a dog sitting in room, high quality",
                       width=512, height=512,
                       num_images_per_prompt=1, return_dict=False)[0]

你好，我已收到你的邮件，我会及时处理^_^

@WyattAutomation I am happy to hear that it works with Oneflow flawlessly


Update open-source.tsx

PR-Codex overview
This PR adds DustinTurska to the list of GitHub users and updates the list of repositories in the open-source.tsx file.
Detailed summary

Added DustinTurska to the list of GitHub users.
Updated the list of repositories in the open-source.tsx file.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

📝 Changed routes:

/open-source

(view full size)

Commit a61d9f52c0b88cc2a5829530de89cdf63f57d6cb (https://thirdweb-meic4k2md.thirdweb-preview.com).


docs: fix highlighted lines in DTO usage

Link: https://docs.litestar.dev/latest/usage/dto/1-abstract-dto.html#dto-data
It used to be like this:

I moved all highlighted lines one line up.

There are other problems (like mentioning Person model that does not exist) in this part, but they are unrelated to this change and will take me some time to fix.