Macro support doesn't work

[Note i've previously posted this message as comment  on the Macro feature PR but it seems i've got no visibility, hope this don't violate any rule ]
Unfortunately on my environment it doesn't works fine well... i'm on PhpStorm with laravel 5.3
i have this code in a custom registered provider (my code is working fine)
class ResponseMacroServiceProvider extends ServiceProvider {

    /**
     * Perform post-registration booting of services.
     *
     * @return void
     */
    public function boot()
    {

        /**
         * Create a response()->apiResponse(...) function
         */
        Response::macro('apiResponse', function($apiResultObj, $serializazionGroups=null, $includeDefaultGroups=true, $jsonPCallback=null)
        {

            /* custom code here...*/

            return $resp;

        });
    }

}

I see ide-helper correctly generate this in _ide_helper.php file
/**
         * Create a response()->apiResponse(.
         *
         * ..) function
         *
         * @static
         */
        public static function apiResponse($apiResultObj, $serializazionGroups = null, $includeDefaultGroups = true, $jsonPCallback = null)
        {
            return \Illuminate\Routing\ResponseFactory::apiResponse($apiResultObj, $serializazionGroups, $includeDefaultGroups, $jsonPCallback);
        }

but the IDE don't recognize it in the autocomplete list.
when i write:
 return response()->apiResp
the method is not listed in the autocomplete list, and if i write it completely like
return response()->apiResponse($result, [], false);
the method is underlined and marked with a tooltip sayng the method is not found

Do you have any idea?

I use appstract/laravel-response-macros for my laravel passport.
ide-helper can not handle new methods from this package.
public function run($factory)
{
    $factory->macro('error', function ($message, $status) use ($factory) {
        return $factory->make([
            'status' => 'error',
            'error' => $message,
        ], $status);
    });
}

Got some macros defined in my TestCase base class and they do not get picked up either. What is the way to get our macros picked up by ide-helper? Any configuration parameter could help?

Currently, macro support is implemented as part of facade alias processing, so the target class must be registered as a facade with an alias. (Eg included in aliases in config/app.php)
Laravel has many classes that have the ability to define macro but not facade. (ex \Illuminate\Support\Arr, \Illuminate\Support\Collection, \Illuminate\Validation\Rule,...)  For this reason they are not the target of macro support.
One workaround is to prepare appropriate aliases for those classes and add them to aliases in config/app.php. For example:
    'aliases' => [
        ......

        'Collection' => \Illuminate\Support\Collection::class,
    ],

Note:
I think this will work for most classes, but it doesn't work for  \Illuminate\Database\Eloquent\Builder. This is because the current macro support judges whether or not the class has the macro function by judging whether or not the class uses the \Illuminate\Support\Traits\Macroable trait, \Illuminate\Database\Eloquent\Builder does not use the Macroable trait and has its own implementation.

but it doesn't work for \Illuminate\Database\Eloquent\Builder

vendor/barryvdh/laravel-ide-helper/src/Alias.php
Find:
if ($traits->contains('Illuminate\Support\Traits\Macroable')) {
Replace to
if ($traits->contains('Illuminate\Support\Traits\Macroable') || $reflection->getName() === Builder::class) {
And it will work :) (laravel 5.8)

It doesn't seem to find macros in custom service providers.... Or at least it isn't for the Cache facade.

@spencero91 were you able to figure this out? I've run into this situation where I've been curating macros definitions into an AutoCompleteHelper.php. That all works beautifully, however, if some macros are coming from different packages that are being used internally, if the next project has more macros or uses doesn't use all the macro's of the first file, you wind up having to manually curate that helper file.
Extracting the helper file to the package seems like the obvious win, and it will work if you open the file up with phpstorm, and let it index it manually. However, if you make a change in the file in another IDE for example, to model something like a composer update where it changes behind the scenes, it won't update in PHPstorms index. If you do the same thing to the regular AutoCompleteHelper behind the scenes, it seems like it will update.
This is probably a horrible solution, but the first thing that crosses my mind, is to add a command to composer dump-autoload that reads all packages for an AutoCompleteHelper.php, and then basically merge them into some safe space like config/autocomplete.php
If anyone has solved this already and better please advise.
I've got the rest working, so it seemed like a good idea to move the macro definitions into packages th

I wrote a small package that uses some of the advice here to solve my own use case, which deals with TestCase Macros as well as macros in packages. It's not the coolest solution but it does work. you can find it at https://github.com/roni-estein/package-macro-autocomplete

@barryvdh this is a duplicate of https://github.com/barryvdh/laravel-ide-helper/issues/40 and thus can be closed


fix: use matching versions instead of explicit workspace versions

We need to publish the packages to npm before we can use the monorepo url as a git dependency. Yarn workspaces will automatically link packages if the specific version is the same as the version in the local package. This means any external package using the git repo as a package dep will get a version number for other packages in the monorepo.
We need to publish versions of each package to npm so that module resolution won't fail when e.g. contracts depends on crypto.

Closing in favor of #32


Deploy openzeppelin-eth to Goerli network

Goerli is now a thing and is working fine with Infura. @spalladino has already created an issue to support it on ZeppelinOS. We may also want to consider publishing openzeppelin-eth to it :slightly_smiling_face:.

Since the release of @openzeppelin/contracts-upgradeable we no longer publish predeployed contracts.


const and let in switch not defined

When using const/let and typecheck in variable declaration I get:
Uncaught ReferenceError: n is not defined
it works with var tho.
switch (..)
  {
    case '..':
      // breaks
      const n: number = 3  // const
      let n2: number = 3  // let
      // works
      var n3: number = 3  // var, works
      // no typecheck
      const n4 = 3
      let n5 = 3
      ..

Hi, sorry for taking so long to respond to this, this project is now deprecated in favour of https://codemix.github.io/flow-runtime which aims for full compatibility with Flow.
I checked and babel-plugin-flow-runtime does not have this particular bug.


Moving AppVeyor tests command to a script

This is a quick tactical change to unblock @suwatch
Will create an issue to clean this up.

@fabiocav thanks!


Support one-to-many/many-to-one for each collection item

Say /Contact<>/firstName + /Contact<>/lastName => /Person<>/fullName. Currently this is prohibited due to "collection field cannot be a part of compound selection".
3 major things to consider:

runtime: instead of reading all source collection field into single FieldGroup tree, this type of mapping should iterate for each collection item, maybe in DefaultAtlasContext. How runtime decide to do that iteration is the question, maybe if both of source and target are collection.
UI: Mapping mode determination will get a bit more complex. It would be better drawing a state machine diagram on mapping mode transition triggered by a field click action.
Nested collection might make things more complex (#435)

Not yet supported. We currently join only the first items from both collections and add a warning. See https://github.com/atlasmap/atlasmap/blob/master/lib/itests/core/src/test/java/io/atlasmap/itests/core/MultiplicityTransformationTest.java#L88-L89
It seems to be exactly what I need to do for https://github.com/atlasmap/atlasmap/issues/2069

@igarashitm, has brought up how to distinguish /person<>/firstName + /person<>/lastName -> /person<>/fullName and /personA<>/firstName + /personB<>/firstName -> /perticipant<>/firstName
My suggestion is that for the latter we should have a separate join/append action for collections to let the user decide what to do.

#2580 to add that join/append kinda action


Allows to initialize/inject the Topology object without starting the Kafka streams.

Expected Behavior
Get the Topology from StreamsBuilderFactoryBean without starting the streams engine. Topology have to be created with properties and KafkaStreamsInfrastructureCustomizer and all futures updated if any.
It is necessary to run the tests with Kafka TopologyTestDriver.
Current Behavior
I can inject the StreamsBuilder, but I then I need to create and initialize the topology manually.
Context
Manual work around:
    @Autowired
    private StreamsBuilder streamBuilder;
    @Autowired
    private KafkaStreamsConfiguration streamConfig;
    @Autowired
    private KafkaStreamsInfrastructureCustomizer infrastructureCustomizer;

///....

        Topology topology = streamBuilder.build(streamConfig.asProperties());
        infrastructureCustomizer.configureTopology(topology);

But of course, it aligned with current version of StreamsBuilderFactoryBean only.

That is an interesting request. Could you elaborate on the use case that requires it?

I wonder why do you need StreamsBuilderFactoryBean if you create it manually.
There is also a PR like this https://github.com/spring-projects/spring-kafka/pull/1853 which does something with TopologyTestDriver.
The StreamsBuilderFactoryBean can also be configured for the setAutoStartup(false).
So, we indeed need more info how to proceed.
Perhaps the fully formed test would be great start to look into.
Thanks

I do not create StreamsBuilderFactoryBean manually.  In the real application all configured automatically.
The issue is in the tests. I have tree options:

Use Spring Boot test using Testcontainers - the Kafka Streams run exactly in the same way how it does in the application but tests take much more times, resources (the application works with 2 Kafka clusters) and very difficult and unstable due to asynchronous nature of the Kafka.
Use the plain JUnit test with Kafka TopologyTestDriver. Much faster and more predictable but I need to duplicate the configuration, topology setup (a have it as a set of beans too) etc. to run it. Also, it doesn't test the configuration from properties files and other things that handled in the real application by Spring.
Try to use the Spring Boot test but instead start the Kafka Streams use the TopologyTestDriver - it is my case. The reasonable balance between 100% identity with real application from the 1st case and lightweight and simplifying of testing from the 2nd case.

The test in general looks like
@TestPropertySource(properties = {
    "spring.kafka.bootstrap-servers=mock://appTopologyTest",
    "spring.kafka.streams.application-id=app-test-${random.uuid}",
    "spring.kafka.properties.schema.registry.url=mock://appTopologyTest",
    "spring.kafka.streams.properties.schema.registry.url=mock://appTopologyTest",
    "app.kafka.topic-offer-replicas=1",
    "spring.kafka.streams.auto-startup=false",
    "spring.kafka.listener.auto-startup=false",
    "logging.level.org.springframework.kafka.core.KafkaAdmin=OFF",
    "logging.level.io.confluent.kafka.serializers=WARN",
    "logging.level.org.apache.kafka.clients.admin=WARN",
})
@SpringBootTest
public class AppTopologyTest {

    //There is configuration for input/output topics

    @Autowired
    private StreamsBuilder streamsBuilder;
    @Autowired
    private KafkaStreamsConfiguration kafkaStreamsConfiguration;
    @Autowired
    private KafkaStreamsInfrastructureCustomizer infrastructureCustomizer;

    @ParameterizedTest(name = "{0}")
    @MethodSource
    protected void testProcessing(String info, List<InputNew<?, ?>> input, Matcher<Iterable<TestRecord>> expected, TopicType out) {

        //This is a tricky part I need to duplicate logic from
        //https://github.com/spring-projects/spring-kafka/blob/main/spring-kafka/src/main/java/org/springframework/kafka/config/StreamsBuilderFactoryBean.java#L347
        Topology topology = streamsBuilder.build(kafkaStreamsConfiguration.asProperties());
        infrastructureCustomizer.configureTopology(topology);

        try (TopologyTestDriver testDriver = new TopologyTestDriver(topology, kafkaStreamsConfiguration.asProperties())) {

            Map<TopicType, TestInputTopic<?, ?>> inputTopics = new HashMap(10);

            input.forEach(i -> send(testDriver, inputTopics, i));

            TestOutputTopic outputTopic = getOutTopic(testDriver, out);

            List<TestRecord> output = outputTopic.readRecordsToList();

            MatcherAssert.assertThat(output, expected);
        }

    }

    @SuppressWarnings("unused")
    private static List<Arguments> testProcessing() {
        int i = 1;
        return List.of(
            testSteps(i++, "Duplicates", MATCHER_1, IN_MSG_1, IN_MSG_1),
            testSteps(i++, "Single ent", MATCHER_2, IN_MSG_3),
            testSteps(i++, "Single another ent", MATCHER_3, IN_MSG_4),
            testSteps(i++, "Comb", MATCHER_4, IN_MSG_1, IN_MSG_2, IN_MSG_3, IN_MSG_4),
            //....
            testSteps(i++, "Nothing", MATCHER_NOTHING));
    }

    private <K, V> void send(TopologyTestDriver testDriver, Map<TopicType, TestInputTopic<?, ?>> inputTopics, InputNew<?, ?> input) {
        TestInputTopic<K, V> topic = getInputTopic(testDriver, inputTopics, input.getTopicType());
        topic.pipeInput(new TestRecord(input.getKey(), input.getValue()));
    }

    @SafeVarargs
    protected static Arguments testSteps(int iteration, String description, TopicType out,
                                         MatcherFn matcher, Function<Integer, InputNew>... inputs) {
        List<InputNew> parameters = StreamEx.of(inputs).map(input -> input.apply(iteration)).toList();
        return Arguments.of(description, parameters, matcher.apply(iteration), out);
    }
}

Ok. Try to provide PR next week.

Grr... Can't load the project into Eclipse due to https://github.com/eclipse-jdt/eclipse.jdt.core/issues/1621
Will be fixed in the next release of Eclipse (4.31)

@artembilan, @sobychacko, @foal
Hi, Spring Kafka Team and reporter.
I'm interested in this issue as well.
If this is on pausing, may i handle this issue?
i'm willing to do this work after reporter and maintainer's ok answer.

Yes, please!

@foal Thanks a lot 🙇♂
I will make a PR for this. 👍

https://github.com/spring-projects/spring-kafka/pull/3172
I create new PR.
Please take a look 🙇♂


As an organization worker I want a report to see All the countries in a region organised by largest population to smallest.

This is ready for a review.


rolling_update: nicer way to set osd flags

Prior to this patch, we were applying the osd flags like this:
"
General pre tasks
Set flags
Upgrade OSDs on a host
Unset flags <-- this triggers pending scrub to start
Set flags
Upgrade OSDs on a hosts
Unset flags <-- this triggers pending scrub to start
.
.
.
General post tasks
"
Now instead, we apply the flag once before starting the OSD update and
unset them once the last OSD is finished.
"
General pre tasks
Set flags and wait for any scrubs to finish
Upgrade OSDs on a host
Upgrade OSDs on a host
.
.
.
Unset flags
General post tasks
"
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

Looks like we have some valid CI failures here:
TASK [unset osd flags] *********************************************************
task path: /home/jenkins-build/build/workspace/ceph-ansible-prs-jewel-ansible2.2-update_cluster/rolling_update.yml:298
fatal: [mon0]: FAILED! => {
    "failed": true
}

MSG:

The conditional check 'not osd_containerized_deployment' failed. The error was: error while evaluating conditional (not osd_containerized_deployment): 'osd_containerized_deployment' is undefined

The error appears to have been in '/home/jenkins-build/build/workspace/ceph-ansible-prs-jewel-ansible2.2-update_cluster/rolling_update.yml': line 298, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

    - name: unset osd flags
      ^ here

fatal: [mon1]: FAILED! => {
    "failed": true
}

@andrewschoen thanks, pushed a new version.

jenkins test kraken-ansible2.2-docker_cluster

jenkins test jewel-ansible2.2-update_cluster

jenkins test jewel-ansible2.2-update_cluster

jenkins test kraken-ansible2.2-update_cluster

jenkins test jewel-ansible2.2-update_dmcrypt

jenkins test kraken-ansible2.2-update_dmcrypt

jenkins test jewel-ansible2.2-xenial_cluster

jenkins test kraken-ansible2.2-docker_cluster

jenkins test kraken-ansible2.2-purge_cluster

@leseb Would you please file a BZ to track this work?

@GregMeno it already exists, I forgot to add it into the PR: https://bugzilla.redhat.com/show_bug.cgi?id=1450754

depends on https://github.com/ceph/ceph-ansible/pull/1710


Separate ORM from Form dependencies

This crate might be better served if the Form/Admin panel functionality was separated from the ORM itself. That would reduce the crate complexity and simplify testing. The widgets/form pieces could be wrappers coming from a separate Wrapper type.
I'd be willing to put together a PR that demonstrates my point if that would help.

Hi!
I have very bad English, I crawl
google translator, I hope we understand each other.
Ваше видение проекта мне представляется интересным.
I would be glad if you contribute to the development of the project.

<<This crate might be better served if the Form/Admin panel functionality was separated from the ORM itself.>>
Forms are not used for the admin pane.
Forms are used for web development.
2.
<<The widgets/form pieces could be wrappers coming from a separate Wrapper type.>>
2.1.For such a solution, you need to take into account that it is convenient to create a map of widgets.
2.2.Widgets are used for both Forms and Models.
Telegram: @kebasyaty
P.S.
1.Dynamic widgets are useless without an admin panel.
2.I have a vision problem, when the situation improves, i have an idea to add two more types of widget.


App does not compile on Xamarin.UWP using .NET Native in release mode

Hi, first of all, very nice library you got there, having lot of fun with it :) good work!
Anyway, as the title says, my Xamarin.UWP app I use for testing does not compile in release mode when the .net native compilation tool chain is turned on (in project settings). Standard .nuget lz4net package is referenced.
You get very cryptic error in the build results window (this is from resharper's build output but it's gonna be the same for stock visual studio's):
Error: ILT0005: 'C:\<snip>\.nuget\packages\microsoft.net.native.compiler\1.6.1\tools\x86\ilc\Tools\Gatekeeper.exe @"C:\<snip>\obj\x86\Release\ilc\intermediate\gkargs.rsp"' returned exit code 1 (1, 1)
But turning verbose mode for msbuild reveals the true cause:
LZ4pn : Gatekeeper error GK0002 : GK0002 Arrays of pointers are not yet implemented. Use array of IntPtr as an alternative.
Any chance those "pointer arrays" gonna get refactored/worked-around?

As it says: "Arrays of pointers are not yet implemented" (emphasis on "yet") I guess they are working on  it. The problem, I guess, is related to limited support for "unsafe", and the whole point of "LZ4pn" is unsafe code.
But... If you distribute "LZ4.dll" without "LZ4pn.dll" it will work just fine. It just won't take advantage of unsafe code. This has relatively high performance implication but at least works...

Yea I'm fully aware it says "yet", thing is, with microsoft "not yet" can easily translate to "won't fix".
Anyway, if you didn't actually stop reading there you would notice the second part of the error. Where it provides an alternative ie. "Use array of IntPtr".
Now I didn't look at the source (yet) I can't tell how complex such refactoring would be so you be the judge of that but depending on what you do with those pointer arrays and how you use them it could mean next to no performance hit.
But you're right that the .net native compiler might have problem with unsafe code in general (it has "native" in name and can't use pointers, get it? :)
That after this particular problem is fixed next one will turn up etc. It would have to tested first I guess, to be sure. I might even try it myself later (both testing the current capabilities and refactoring lz4pn, depends on the size of the codebase) as it seems like fun and good to know stuff, will report back to you if that turned up anything useful.
In any case, you might want to consider putting a warning or another asterix in the project description somewhere saying the library won't compile with .net native for windows store apps (which should be all of them nowadays as .net native rocks). Like I stated before the error you originally get in VS is rather cryptic and doesn't directly point to lz4net...

https://github.com/MiloszKrajewski/K4os.Compression.LZ4


Upgrage keycloak

Upgrage keycloak to docker image 1.9.3.Final
Add env.properties file and templateParameters.properties to configure KEYCLOAK_USER / KEYCLOAK_PASSWORD

Can one of the admins verify this patch?

ok to test

Tested successfully


Don't find Station ID

Hi,
My problem is that I don't find any Station ID.
May You help?

Sure, but you need to give some more input :)
If you don't find any station, do you receive any error message upon execution of node findStation.js apiKey apiUser stationName?
For example, you could use a station name from an example of the API documentation:
https://gti.geofox.de/html/GTIHandbuch_p.html
In this case, Christuskirche should definitely work


user can add and view promos with location data included

Description
updated user promotions so user can add promos rendered with location info
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ x] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[x ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x ] New and existing unit tests pass locally with my changes
[ x] There are no merge conflicts

Great job adding this functionality 👍


devops: Use maven wrapper

Thanks for your interest in the project! Could you explain why we would need the wrapper?

Thanks for your interest in the project! Could you explain why we would need the wrapper?

@yury-s Maven is a better choice for maven as it is portable and cross platform where as installing maven on especially windows causes some PATH issues. Also because of this, no need to install maven on the machine and users building from source will have a better experience as they won't be required to install maven.

As far as I understand the wrapper may simplify Maven installation process but all our CI integrations work smoothly with the standard Maven installation and I also haven't heard any complains about using playwright-java with bare Maven in local setup. Considering that, I'm not sure we want this to be a part of the project at the current stage as it doesn't solve much while would require maintaining another flavor of dev setup. The functionality of the wrapper is gonna make it to Maven 3.7 so I'd just wait for that.


select() timeout with 5 usecs causes hitches on Windows

webby.c around line 1333:
timeout.tv_sec = 0;
timeout.tv_usec = 5;

err = select((int) (max_socket + 1), &read_fds, &write_fds, &except_fds, &timeout);

I experienced large hitches in the select() call on Windows (VS 2015 Update 1, x64, Windows 10) until I set the tv_usec field to 0 instead of 5. I assume there's a timer granularity difference between the current Winsock libraries and whatever platform Webby has been tested with.

Maybe this should be a server config option.

I think that makes sense. I can't personally think of a reason I'd want a timeout at all (even if it didn't cause Windows hitches), but I'm sure you and others have valid use cases.


Use updated URL for Solana Installation

We've been using Metaplex actions and recently discovered that a new version of Solana we want is only available at https://release.anza.xyz/, not https://release.solana.com/. From a quick skim of the Anza site, it seems like all versions >= 1.17.25 are available there while older versions are still on the Solana site.
An alternative to this PR (accounting for two URLs) is to ask the owners of those domains to point one to the other so that only one URL is needed.

Hi there, thanks for this! Could you just let me know which version you are not able to download using the solana.com URL? I'm asking because I'm able to download Solana 1.18.* using it.

The version that we're using is v1.18.19, which seems is only available at the Anza URL.
The Solana base URL redirects to https://solana.com/docs for me, so I can't see which versions are listed there.

Yeah I think we need this! Could we just accept the base URL as an input though and make it default to the fancy logic you've provided based on the desired version?

@blockiosaurus This can be closed as this was fixed by https://github.com/metaplex-foundation/actions/pull/8.

@lorisleiva apologies for the delayed response on my side, but thanks for merging in the changes! I can close this pull request.


Carousel indicatorPosition bottomLeft required

Right now you can only add top or bottom as indicatorPosition of carousel, but I need to use bottomLeft. Carousel should support all the positions:
"topLeft",
"topCenter",
"topRight",
"centerLeft",
"center",
"centerRight",
"bottomLeft",
"bottomCenter",
"bottomRight"

@kmahmood74 @sharjeelyunus It's done in this PR - #950

@sharjeelyunus  Now you can set the topRight, bottomLeft, etc values to the indicatorPosition property


Fix TreeSyntax for macro definitions

I wasn't able to add def macros in an annotation macro because the generated tree for Defn.Macro contained a syntax error.
scala> import scala.meta._
import scala.meta._
scala> q"def foo = macro fooImpl"
res0: meta.Defn.Macro = def foo: = macro fooImpl
scala> q"def foo: Int = macro fooImpl"
res1: meta.Defn.Macro = def foo: : Int = macro fooImpl
After making this change, I was able to add def macros in my annotation
macros and the syntax looks correct in the console.
scala> import scala.meta._
import scala.meta._
scala> q"def foo = macro fooImpl"
res0: meta.Defn.Macro = def foo = macro fooImpl
scala> q"def foo: Int = macro fooImpl"
res1: meta.Defn.Macro = def foo: Int = macro fooImpl
I have no idea if there are some tests that should be updated
or if a new test should be added.

Thank you for this contribution! A good place to test this would be here: https://github.com/scalameta/scalameta/blob/master/scalameta/scalameta/src/test/scala/scala/meta/tests/prettyprinters/SyntacticSuite.scala#L470-L473
I think it would be good to include a test for both with and without a decltpe, I couldn't see any tests for either.
Related #567

Thank you for this contribution! A good place to test this would be here: https://github.com/scalameta/scalameta/blob/master/scalameta/scalameta/src/test/scala/scala/meta/tests/prettyprinters/SyntacticSuite.scala#L470-L473
I think it would be good to include a test for both with and without a decltpe, I couldn't see any tests for either.
Related #567

Updated with a test.

Updated with a test.


feat: option to specify additional json files to update version number

This is critical feature we are missing during our application development. Our applications contains metadata file like version.json or info.json which is loaded by monitoring tool. So we can see our deployed version on monitoring dashboard.

Hey @mvrana-cen81948 ! Thank you for the PR. This is definitely something that we want to solve with our new custom "strategy" system.
We want to let developers choose which files to update and how.
It could be a JSON file but also a YAML file or a custom format...
That said, we still don't have an ETA and we don't want people to be stuck either.
@edbzn maybe we could add the option and mark it as "experimental"? This way, we wouldn't have to maintain it for long once the custom strategy system is out.


Bug: No indication of a limit for insight pages

Describe the bug

While preparing for a stripe demo, I needed to add 50+ repos to one insight page. Note that the button is disable, but no message is displayed.

Steps to reproduce
Add 50+ repos from https://github.com/stripe-samples/ to one insight page.
The limit appears to be 49.
https://insights.opensauced.pizza/pages/bdougie/23/repositories
https://insights.opensauced.pizza/pages/bdougie/23/dashboard
We should add a feature add all repos from an org or a CSV
Browsers
No response
Additional context (Is this in dev or production?)
A tool tip on hover of the button would be enough.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

The limit appears to be 49.

That feels rather low (especially for some orgs that have 100s of repos that may have many different teams associated with any number of them. Just look at AWS's open source org: over 700 https://github.com/orgs/awslabs/repositories?type=all)
Maybe a separate issue, but would be cool to see this limited expanded for super user orgs out there.

Maybe a separate issue, but would be cool to see this limited expanded for super user orgs out there.

True. We need someone to hit the limit first. At the moment most insight pages are 2 repos on average. I am sure if we allowed org indexing it would be hire. No is going to manually add them today. We can for sure adjust the limit based on super user.

That's weird because I was able to add 50+ repos -> https://insights.opensauced.pizza/pages/takanome-dev/697/repositories

When I added the 10th repo, the button was disable (I saw that the limit is 10 in the code) but for some reason it starts working again and I added 54 repos so far. Humm 🤔
https://github.com/open-sauced/app/blob/f43502655626f6e588caca352e6340a7fcfb2560/lib/store/index.ts#L8
https://github.com/open-sauced/app/blob/f43502655626f6e588caca352e6340a7fcfb2560/components/organisms/InsightPage/InsightPage.tsx#L470-L480


Add query_percept to get list of all agents in an area

From @dhixsingh on April 17, 2018 22:41
The query_percept should allow the BDI system to query MATSim for a list of all agents that are located within a given polygon area. The use case is to allow messages to be sent to agents within a arbitrary polygon area (see #31).
Add a test that demonstrates a staged evacuation, such that the Fire Alert  message is sent to two groups of agents (split into two arbitrary rectangular areas) at different times.
Copied from original issue: agentsoz/bdi-abm-integration#32

Zone based messaging has been working for a while and at least since 3f064f5 there is a dedicated test SurfCoastShirePopulationSubgroupsIT for zone based staged evacuation.

Note that there is no query_percept for this, but it is done through the interaction betwen the disruption and MATSim models. The code (in MATSimModel.java) can easily be refactored and made available through the query_percept interface if required, but am closing for now as there is no immediate need for that.


Grafana integration Part 2

More PRs are coming, I'm mostly trying to bootstrap myself for tighter feedback loops in terms of code reloading and so on.
I'm not sure how actively you're working on it all at the moment, let me know if you're in the middle of uncommited changes.
I'm working on making it possible to feed multiple metrics back to grafana. Hope to show it shortly.

Thanks alex!

Thanks!


Use Long.js for 64 bit support

This builds off of https://github.com/sidorares/node-dbus/pull/101 and https://github.com/sidorares/node-dbus/pull/150.
Leveraging Long.js features, it can marshal numbers up to 53 bits, strings with decimal digits representing full 64 bit values, and other Long.js compatible objects into 64bit (x/t) dbus fields. When unmarshalling 64 bit (x/t) dbus fields, by default it will still convert into a number like it did previously, however there is now a 'ReturnLongjs:true' option that will cause it to return a Long.js object instead of a number.
I have hopefully added appropriate test cases to cover this. It adds a dependency to Long.js but hopefully remains otherwise backwards compatible. I think I got the options to pass correctly down to DBusBuffer, but someone could double check. (I also stumbled upon the option 'ayBuffer' which didn't seem to be passed down to DBusBuffer previously, unless I missed something.)

Apparently Node.js 0.12 does not have Object.assign(), do I need to use an alternative or is Node.js 0.12 support still required by this project?

Borrowed an Object.assign() replacement from https://stackoverflow.com/a/30498430.
Looks like it should work for Node.js 0.12 now.

maybe use object-assign from npm instead of bundling merge function? https://github.com/sidorares/node-mysql2/pull/397/commits/7f3d84f69a175fb1e4365b77d6fb8cd69b70b913

Ok, replaced previous polyfill with object-assign.

Thanks!


GEOPY-947: replace os.path by pathlib

GEOPY-947 - replace os.path by pathlib

Codecov Report

Merging #20 (fa0650a) into develop (a9a070a) will decrease coverage by 0.78%.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop      #20      +/-   ##
===========================================
- Coverage    89.44%   88.66%   -0.78%
===========================================
  Files            4        4
  Lines          199      203       +4
  Branches        32       33       +1
===========================================
+ Hits           178      180       +2
- Misses          14       15       +1
- Partials         7        8       +1

Impacted Files
Coverage Δ

param_sweeps/driver.py
89.28% <75.00%> (-1.30%)
:arrow_down:

param_sweeps/constants.py
100.00% <100.00%> (ø)

param_sweeps/generate.py
78.94% <100.00%> (ø)


DHT11 - Humidity reading timing issue?

Every once in a while I get an "off" humidity reading with DHT11.  Is the sensor producing this? ( notice the "54.0" in the last column):
18:15:43 - 132,25.0,42.0
18:16:28 - 133,25.0,40.0
18:17:13 - 134,25.0,41.0
18:17:58 - 135,25.0,54.0
18:18:43 - 136,24.0,44.0
18:19:28 - 137,25.0,44.0
18:20:13 - 138,25.0,43.0
18:20:58 - 139,26.0,43.0
18:21:43 - 140,25.0,42.0
18:22:28 - 141,25.0,42.0
18:23:13 - 142,25.0,45.0
18:23:58 - 143,25.0,41.0
18:24:43 - 144,25.0,42.0
18:25:28 - 145,25.0,43.0
18:26:13 - 146,25.0,40.0
18:26:58 - 147,25.0,43.0
18:27:43 - 148,26.0,43.0
18:28:28 - 149,24.0,44.0
18:29:13 - 150,25.0,43.0
18:29:58 - 151,23.0,44.0
18:30:43 - 152,25.0,41.0
18:31:28 - 153,25.0,54.0
18:32:13 - 154,24.0,44.0
18:32:58 - 155,25.0,40.0
18:33:43 - 156,25.0,43.0
18:34:28 - 157,26.0,43.0

see commit 1dc1dd4


[FLINK-16516][python] Avoid codegen user-defined function for Python UDF

What is the purpose of the change
This pull request will replace python udf codegen code with static class code
Brief change log

Add PythonScalarFunction.java and PythonTableFunction.java in flink-table-common
Remove PythonFunctionCodeGenerator.scala

Verifying this change
This change added tests and can be verified as follows:

It is not a new feature, so current test is enough

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Thanks a lot for @dianfu  review. You are right. We don't need SimplePythonFunction anymore.
I have addressed the comment at latest commit.

LGTM. Merging.


Merged ImmutableMash objects incorrect stlll allow #store API to write to the merged object

We're not throwing a correct ImmutableAttributeModification for Hash#store:
node['bar']['foo']['tokens'].each do |key, values|
  # puts "key: #{key}, values: #{values}"
  # puts '---'
  node['foo']['bar']['additional_attributes'].store(key, values)
end

That should behave the same way as []=:
node['bar']['foo']['tokens'].each do |key, values|
  # puts "key: #{key}, values: #{values}"
  # puts '---'
  node['foo']['bar']['additional_attributes'][key] = values
end

Somewhat unclear how that API got missed since it does date back to ruby 1.8.7.
Probably need a re-audit of all the new Hash + Array methods that have been introduced at least in ruby 2.0 to look for writers and block them as well.

The other thing is probably to just freeze the immutable objects (unfreeze them when populating the cache) so that any mutators that we fail to catch and display the pretty error will still throw.

dan pointed out that there's no way to unfreeze an object in ruby, so that won't work.
we probably need a spec test which whitelists the allowed readers and audit and add anything like #store that we've missed in the blacklist and then throw an exception if there's new unaudited methods in Array or Hash


Add test for CreateDefaultDisk Setting

This PR adds a test for the Setting: Create Default Disk on Labeled Nodes that was implemented in longhorn/longhorn-manager#331. The test will check three different cases for when this Setting is enabled:

A Disk already exists on the Node. No additional Disk should be created.
A Disk doesn't exist on the Node, and the Node is labeled properly. The default Disk should be created at the path specified in Setting: Default Data Path.
A Disk doesn't exist on the Node, but the Node doesn't have the appropriate label. The default Disk should not be created.

Note that since additional permissions are needed to label the Nodes in this test, the ClusterRole created for the test has been modified accordingly.
This PR also contains a commit to set the Namespace for the test's Resources explicitly to default so that the test Resources are not inadvertently created in the wrong Namespace.

Switched the order of the calls to modify the Default Data Path and Create Default Disk on Labeled Nodes.
Renamed fixture to random_disk_path.


Issue with Colcon Build on Software Training on Docker

Command I am running: ~/rj_training_container/training_ws $ colcon build
Starting >>> joystick_msgs
Starting >>> astar_path_planner
Starting >>> controllers
Starting >>> coordinate_transform
Starting >>> keyboard
Starting >>> localization
Starting >>> mapping
Starting >>> mineral_deposit_tracking
Starting >>> obstacle_detector
Starting >>> peak_finder
Starting >>> rj_training_bringup
Starting >>> teleop
--- stderr: coordinate_transform
CMake Error at CMakeLists.txt:12 (find_package):
By not providing "Findstsl_interfaces.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"stsl_interfaces", but CMake did not find one.
Could not find a package configuration file provided by "stsl_interfaces"
with any of the following names:
stsl_interfacesConfig.cmake
stsl_interfaces-config.cmake

Add the installation prefix of "stsl_interfaces" to CMAKE_PREFIX_PATH or
set "stsl_interfaces_DIR" to a directory containing one of the above files.
If "stsl_interfaces" provides a separate development package or SDK, be
sure it has been installed.

Failed   <<< coordinate_transform [4.77s, exited with code 1]
Aborted  <<< peak_finder [4.27s]
Aborted  <<< mineral_deposit_tracking [4.50s]
Aborted  <<< mapping [4.68s]
Aborted  <<< localization [4.91s]
Aborted  <<< keyboard [5.22s]
Aborted  <<< teleop [4.60s]
Aborted  <<< astar_path_planner [5.66s]
Aborted  <<< joystick_msgs [5.80s]
Aborted  <<< controllers [5.72s]
Aborted  <<< obstacle_detector [5.19s]
Aborted  <<< rj_training_bringup [5.73s]
Summary: 0 packages finished [9.04s]
1 package failed: coordinate_transform
11 packages aborted: astar_path_planner controllers joystick_msgs keyboard localization mapping mineral_deposit_tracking obstacle_detector peak_finder rj_training_bringup teleop
4 packages had stderr output: coordinate_transform localization mineral_deposit_tracking peak_finder
1 package not processed
`

To build and run the code in this repository, you will also need the packages from stsl. You can clone the source for these packages into your same colcon workspace to build them alongside the packages from this repo.
Your colcon workspace should look like this:
colcon_ws
└ src
  ├ software-training (this repo)
  └ stsl

Hi Matt! Thanks for answering the question, we fixed day of and forgot to close issue. I have updated setup.sh to appropriately clone the directory. And note added in docker.md


Updates VMware documentation links and fixes typos

This PR adds a redirection for the VMware vSphere getting started guide to VMware's external documentation website and updates related hyperlinks. Also, typos at several locations have been fixed.
This PR makes the following changes:

Adds 301 redirection for /docs/getting-started-guides/vsphere/ to https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/
Updates hyperlinks from /docs/getting-started-guides/vsphere/ to https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/
Fixes typos i.e. VMWare and Vmware -> VMware

/cc @abrarshivani

/lgtm


Sign-In Failed env HTTP_PASSWORD_HASH

Hello, we're using docker latest image tag
env HTTP_PASSWORD_HASH (bcrypt hash) isn't working anymore (the value we had before nor the freshly generated)
env HTTP_PASSWORD does the trick
Might be related to https://github.com/joeferner/redis-commander/commit/679861f6781f20e8ddef0ceb459757c5ef1ad65e ?

does your system use the native bcrpyt or nodejs implementation of bcryptjs?
How did you generated the new bcrypt hash?

added a helper script below bin/ folder to generate a bcrypted password hash - its working with that using.
And running inside docker the hashed password can be supplied via file too now.

@man4red any feedback? Problem remains or solved?

@man4red @sseide @joeferner I can confirm that this still doesnt work.


Document Release Process

With the skywater shuttle out there now we officially have a deployment target for 0.1. In order to address some current issues and continue development, we need to break naming on some files while also stabilizing and testing the skywater deployment.
Since we have committed to semantic versioning a 'main/develop' give insufficient space for all possible versions.
Rough guideline:

main -> active development branch
release-M.m -> stabilized/frozen release branches

So e.g. we branch off main as release-0.1. Main now targets 0.2 active development. Changes/patches from 0.2 that are API compatible can be backported to the release-0.1 branch. In this case a new patch release is made such as 0.1.0 -> 0.1.1.

#125

#125


Rename feature_index to variable_source

The name feature_index is confusing as "feature" means something different in the context of this project than in the wider GIS community. Instead of the term "feature", we will use the term "variable" which is functionally equivalent in the context of the project. Further, we will address the fact that this table is not exactly an index, but more like a second source table due to the amount of unique data it contains.
Changes should be made in the SQL db and in the R code that touches the SQL db.

In SQL this change entails:

Changing table name from feature_index to variable_source
Changing column names that use "feature" or feature_index" to "variable" or "variable_source"

Pretty much right as I was finishing this it hit me that this should be called variable_registry
@rtmill thoughts? Worth changing again?

@kzollove If you feel strongly enough about it being a better fit to give you the motivation to make the change, the name makes sense to me.


Parse should not raise an ArgumentError

IO.iodata_to_binary used in Parse will raise an error if the input is
not iodata, such as if we try to call Poison.decode(:hello). If an
error is raised, it will now be rescued and an {:error, :argument}
tuple will be returned instead. Parse! will raise an ArgumentError as
expected.

Not entirely sure if this is the right approach to the problem I ran in to or if I should handle this in my own code instead.
My thought is that I want to feel safe that no exceptions are thrown or errors are raised when I use decode without the !. At the same time, I know that for example File.read without ! will have similar issues when doing File.read(:hello).

Indeed, non-bang functions do not stop exceptions from happening when you pass in the wrong types. That's why Elixir has guards.

Alright, thanks - good to know!
Even though I kinda like this more "safe" approach, it's probably wrong by convention. :smiley:
I'll close this.


UPDATE docs/UserGuide.md

Add modcheck userguide for the add command.

Codecov Report
Patch and project coverage have no change.

Comparison is base (abf33bc) 72.15% compared to head (c39f3c2) 72.15%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #40   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Document new events

 2020-12-16 16:03:28,317 hikari: ignoring unknown event GUILD_INTEGRATIONS_UPDATE:
    {'guild_id': '265828729970753537'}

And all the slash-related ones

GUILD_INTEGRATIONS_UPDATE isn't useful, it just dupes the newer integration events without providing any useful information

We can have a null handler to stop it from logging at least

We can have a null handler to stop it from logging at least

not too sure that's necessary since this is only debug logging anyway but if you'd rather it didn't then sure


secrets that do not exist do not error when used with Functions

Environment information
System:
  OS: macOS 14.6.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 168.42 MB / 32.00 GB
  Shell: /opt/homebrew/bin/fish
Binaries:
  Node: 22.8.0 - ~/.local/state/fnm_multishells/13750_1727708399158/bin/node
  Yarn: undefined - undefined
  npm: 10.8.2 - ~/.local/state/fnm_multishells/13750_1727708399158/bin/npm
  pnpm: 9.10.0 - ~/.local/state/fnm_multishells/13750_1727708399158/bin/pnpm
NPM Packages:
  @aws-amplify/auth-construct: Not Found
  @aws-amplify/backend: 1.3.0
  @aws-amplify/backend-auth: Not Found
  @aws-amplify/backend-cli: 1.2.8
  @aws-amplify/backend-data: Not Found
  @aws-amplify/backend-deployer: Not Found
  @aws-amplify/backend-function: Not Found
  @aws-amplify/backend-output-schemas: Not Found
  @aws-amplify/backend-output-storage: Not Found
  @aws-amplify/backend-secret: Not Found
  @aws-amplify/backend-storage: Not Found
  @aws-amplify/cli-core: Not Found
  @aws-amplify/client-config: Not Found
  @aws-amplify/deployed-backend-client: Not Found
  @aws-amplify/form-generator: Not Found
  @aws-amplify/model-generator: Not Found
  @aws-amplify/platform-core: Not Found
  @aws-amplify/plugin-types: Not Found
  @aws-amplify/sandbox: Not Found
  @aws-amplify/schema-generator: Not Found
  aws-amplify: 6.6.2
  aws-cdk: 2.160.0
  aws-cdk-lib: 2.160.0
  typescript: 5.6.2
AWS environment variables:
  AWS_PROFILE = josef
  AWS_REGION = us-east-1
  AWS_STS_REGIONAL_ENDPOINTS = regional
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
No CDK environment variables

Describe the feature
When using a secret on a Function that does not exist I am not presented with an error notifying me of the missing secret like I do for Auth. This can be confusing because I will not see an error until the Function is invoked and fails to resolve the secret.
// amplify/functions/say-hello/resource.ts
import { defineFunction, secret } from "@aws-amplify/backend"

export const sayHello = defineFunction({
  name: "say-hello",
  environment: {
  	MY_SECRET: secret("DOES_NOT_EXIST"),
  },
})

Use case
see above

marking as a feature request


support sourcemap

Any updates?

May we have sourcemap support or just skipping sourcemaps for locale files, but not broke it at all?
Sourcemap is likely to be incorrect: a plugin (vite-plugin-vue-i18n) was used to transform files, but didn't generate a sourcemap for the transformation.
Consult the plugin documentation for help.

{"version":3,"file":"main.js","sources":[],"sourcesContent":[],"names":[],"mappings":";;;;;;;;;;;;"}

May we have sourcemap support or just skipping sourcemaps for locale files, but not broke it at all?
Sourcemap is likely to be incorrect: a plugin (vite-plugin-vue-i18n) was used to transform files, but didn't generate a sourcemap for the transformation.
Consult the plugin documentation for help.

{"version":3,"file":"main.js","sources":[],"sourcesContent":[],"names":[],"mappings":";;;;;;;;;;;;"}

Is there any way to solve this? I'm getting this same error while trying to generate sourcemaps for Sentry.

I would really like to support it ...
I'm not currently a full-time OSS developer, but I have plans to continue to support it.
Please wait :pray:

@kazupon how can we (Cypress) help?

Hello! @JessicaSachs  😺
I tried to support the source map this repo before
https://github.com/intlify/vite-plugin-vue-i18n/pull/33
At the time, I had a hard time mapping the source map retrieved from the rollup to the source map returned by the json and yaml generator.
if I will be possible a little more time, I think I can support the source map, but I need a little focus time on it.
If you (Cypress) can support it, I would be really happy. :relaxed:

I've just fixed it and released out @intlify/vite-plugin-vue-i18n v3.2.1
Please check it!

I've just fixed it and released out @intlify/vite-plugin-vue-i18n v3.2.1 Please check it!

Thank you!

We are missing a source map with<EMAIL_ADDRESS>on dev mode
Console Error
DevTools failed to load source map: Could not load content for<EMAIL_ADDRESS>HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE
Steps to reproduce

Create a new project with npm init vite@latest my-vue-app -- --template vue
Install vue-i18n with npm i @intlify/vite-plugin-vue-i18n vue-i18n
Add i18n plugin to vite.config.js
Run dev mode npm run dev to inspect

package.json
{
  "name": "my-vue-app",
  "version": "0.0.0",
  "scripts": {
    "dev": "vite",
    "build": "vite build",
    "preview": "vite preview"
  },
  "dependencies": {
    "@intlify/vite-plugin-vue-i18n": "^3.2.1",
    "vue": "^3.2.25",
    "vue-i18n": "^9.1.9"
  },
  "devDependencies": {
    "@vitejs/plugin-vue": "^2.0.1",
    "vite": "^2.7.12"
  }
}

vite.config.js
import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'
import i18n from '@intlify/vite-plugin-vue-i18n'

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [vue(), i18n()],
})

Environment
macOS 12.1
Node 14.18.2
npm 8.3.1
Chrome 97
Safari 15.2
I can see the inlined source map for http://localhost:3000/@vite/client when I don't have installed the plugin, that's why I suspect that it's related.
I don't know how I can help to fix it, I hope somebody can address me.

Can confirm this problem exists, also running macOS 12.1 and tried in Chrome and Safari. If @kazupon has very little time to look into it, perhaps he can point us in the right direction to look for a fix ourselves so we can make a pull request?

DevTools failed to load source map: Could not load content for<EMAIL_ADDRESS>HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

Hmm 🤔 ,
As for the cause of this, I honestly don't know.
It happens with source map support, so I'm pretty sure that fix is affecting it.
There may be a problem with the way the rollup API is used.
The issue with no support for source map has been resolved. The new issue will be opened as a separate #82
Thanks!


Update Composer dependencies (2021-01-07-00-06)

Visual regression test passed!
View the visual regression test report

Visual regression test passed!
View the visual regression test report


Fix lambda layer publish script

What does this PR do?
The lambda layer publish script did not work as expected locally and presumably in GH actions and created 20+ lambda layer versions in eu-west-1 instead of 1 version in every region.
The script added by this PR proved to work in a GH Actions workflow in https://github.com/elastic/apm-agent-python and https://github.com/elastic/apm-aws-lambda.

:grey_exclamation: Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-06-13T11:30:35.172+0000

Duration: 8 min 45 sec

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


Updating CGI handler to support Python 3 byte strings.

This addresses an issue that I encountered where PNG byte streams were not being emitted correctly. Treating them as normal strings resulted in Python wrapping them with b'', so browsers thought the image was corrupt. Emitting the byte string directly to the stdout buffer allowed the image to be rendered properly. Per the Python docs, this appears to be a change in behavior in Python 3.

Any traction on getting this PR approved and merged?


Add run_exports

Currently this package is missing run_exports. It would be good to add that with an appropriate version constraint
Edit - Also would recommend adding this to global pinnings so migrations are handled correctly: https://github.com/conda-forge/conda-forge-pinning-feedstock/issues/6623

Fine with me. Though docs could really use some work, they just talk about adding run_exports but don't give an example. conda.io docs were more helpful.
So I assume you want sth like?
run_exports:
    - {{ pin_subpackage('libblst', max_pin='0.3.x') }}

If all 0.3.x are actually ABI compatible I am not sure though. So far 0.3.13 is the only version anyway.

I initially created the recipe with versioning and run_exports but was asked to simplify it. Do you mean that I should create a libblst.so.x.x.x and the associated libblst-{{ so_major }}?

...they just talk about adding run_exports but don't give an example

Like this example?

For example, you may use Pinning expressions to obtain flexible version pinning relative to versions present at build time:
build:
  run_exports:
    - {{ pin_subpackage('libpng', max_pin='x.x') }}

With this example, if libpng were version 1.6.34, this pinning expression would evaluate to >=1.6.34,<1.7.

The docs live here. Please feel free to raise a new issue or PR with feedback

I initially created the recipe with versioning and run_exports but was asked to simplify it. Do you mean that I should create a libblst.so.x.x.x and the associated libblst-{{ so_major }}?

Think the PR ( https://github.com/conda-forge/libblst-feedstock/pull/3 ) looks reasonable

...they just talk about adding run_exports but don't give an example

Like this example?

I was referring to this part: https://conda-forge.org/docs/maintainer/pinning_deps/?highlight=run_exports#specifying-run_exports
But ok if it's mentioned somewhere else it's fine.

Ah had included the former in the OP link of the issue. So assumed that was what we were talking about
There have been discussions over the years about not repeating the conda & conda-build docs in conda-forge. So what we have is more minimal. Perhaps we could add more links there

@jakirkham While we have your attention, I was under the impression that github: source build (when there is a Release/Tag) were preferred to PyPI sourced build, am I in error? I systematically go directly to the github when creating staged recipe, often not checking pypi, but for naming convention

Small question @MementoRC as you put run_exports pinned package as x.x, will it just match on everything?
https://github.com/conda-forge/libblst-feedstock/pull/3/files

While we have your attention, I was under the impression that github: source build (when there is a Release/Tag) were preferred to PyPI sourced build, am I in error? I systematically go directly to the github when creating staged recipe, often not checking pypi, but for naming convention

Personally prefer PyPI as it provides artifacts with stable checksums. GitHub releases don't provide this (at least not without additional effort by project maintainers)

Do you mean for the headers sub-package? from what I understand the pin is only needed for the dynamic library, I could just make one output, I originally had a -devel, -so_major and -headers. When I removed the -so_major, I felt lazy to have to remove the ouputs, as well as personal preference for the flexibility of selecting what goes into the package, this recipe builds a static library, that shouldn't be included

Small question @MementoRC as you put run_exports pinned package as x.x, will it just match on everything? https://github.com/conda-forge/libblst-feedstock/pull/3/files

Please disregard, seems I still didn't know how this worked.

Personally prefer PyPI as it provides artifacts with stable checksums. GitHub releases don't provide this (at least not without additional effort by project maintainers)

The sha256sum? I guess I was influenced by my first recipe where the PyPI did not include the license, nor the package tests - github feels less 'man-in-the-middle'

Please disregard, seems I still didn't know how this worked.

TBH, me neither, possibly even less ... lol

Do you mean for the headers sub-package? from what I understand the pin is only needed for the dynamic library, I could just make one output, I originally had a -devel, -so_major and -headers. When I removed the -so_major, I felt lazy to have to remove the ouputs, as well as personal preference for the flexibility of selecting what goes into the package, this recipe builds a static library, that shouldn't be included

This is a reasonable question. Naively would have thought we would have thought the packages would be...

libblst - shared objects only
libblst-devel - depends on libblst and adds headers + build config files (like .pc + FindBlst.cmake or similar)

The libblst-devel would then have run_exports to add libblst
That said, don't know as much about this library. So there may be reasons for carving up the way it is that I'm not aware of

@xhochy Did I mis-understood your review (not sure whether it is this recipe or nother) where I was implementing the scheme above and you mentioned a simpler scheme was preferred?
This is my de-facto scheme for any C/C++ lib package that I work on,, sometime it requires so pretty big butchering of upstream, when they don't naturally implement the lib versioning
To clrify, I just want to know which scheme to use and when ... quite confused (especially given that I had done the work, this lib did not implement the versioning upstream)

I agree with the scheme that @jakirkham posted. I don't remember the particular review, but we mostly use the -headers suffix if something ships a header-only part, i.e. if you only use things from these headers, you don't need the shared library at runtime.

Thanks for the feedback. I am pretty sure I don't quite get it yet ... and likely will implement the wrong scheme in future recipes, just point me in the right direction when I do - For this recipe, should I separate?
Currently, my limited understanding is that, if you use the headers, you define things related to that library in your binary so will most likely need the runtime lib - unless it's a header only library like I saw in boost? To me, it looks like a difficult thing to assess

For this recipe, should I separate?

If you are unsure, probably not.

@xhochy Do you have any comments on the way I interact with conda-forge? Could some (or most?) of what I do be considered obnoxious? You did say a few good things for some of my PRs, so an honest feedback would be welcome, suggestions as to how to improve/reduce/limit as well.


Identifying mathematics theorems

Draft PR, writing these out is surprisingly taxing. The plan is to have 10 theorems from each of the following categories:

Group Theory and Representation Theory
Analysis
Topology
Number Theory and Commutative Algebra
Theoretical Computer Science

Five of them will be "easy" (first college course in the area) and five will be "hard" (advanced undergraduate or graduate level).

@googlebot I signed it!

Hmmm.... it appears I commited from my Enterprise GitHub account by accident. I'm not sure how I'm supposed to remedy this though.

Hi Stella,
Thanks for your submission! If you'd like to submit from a different
account, I suggest closing this PR and creating a new one using your other
account. Would that work?
Best,
Guy
On Thu, Mar 4, 2021 at 9:11 PM Stella Biderman<EMAIL_ADDRESS>wrote:

Hmmm.... it appears I commited from my Enterprise GitHub account by
accident. I'm not sure how I'm supposed to remedy this though.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/BIG-bench/pull/121#issuecomment-791158774, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADGRNYSJHFG4BC57ZBJFNTTCBRX5ANCNFSM4YUPEXFQ
.

Hi Stella, Thanks for your submission! If you'd like to submit from a different account, I suggest closing this PR and creating a new one using your other account. Would that work? Best, Guy
…

The account that I originally submitted from (and the one I am now posting from) is the correct account. However one of the commits in the PR was made from the wrong account. Is deleting the PR still required?

Got it. I suggest either signing the CLA from the new account (if you're
comfortable doing that of course), or creating a new PR. Do either of these
work for you?
Best,
Guy
On Thu, Mar 4, 2021 at 9:32 PM Stella Biderman<EMAIL_ADDRESS>wrote:

Hi Stella, Thanks for your submission! If you'd like to submit from a
different account, I suggest closing this PR and creating a new one using
your other account. Would that work? Best, Guy
… <#m_4402750793553344496_>
The account that I originally submitted from (and the one I am now posting
from) is the correct account. However one of the commits in the PR was made
from the wrong account. Is deleting the PR still required?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/google/BIG-bench/pull/121#issuecomment-791166887, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADGRN6KQCVOWJBYBGUT2W3TCBUIVANCNFSM4YUPEXFQ
.

Got it. I suggest either signing the CLA from the new account (if you're comfortable doing that of course), or creating a new PR. Do either of these work for you? Best, Guy
…
On Thu, Mar 4, 2021 at 9:32 PM Stella Biderman @.***> wrote: Hi Stella, Thanks for your submission! If you'd like to submit from a different account, I suggest closing this PR and creating a new one using your other account. Would that work? Best, Guy … <#m_4402750793553344496_> The account that I originally submitted from (and the one I am now posting from) is the correct account. However one of the commits in the PR was made from the wrong account. Is deleting the PR still required? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#121 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADGRN6KQCVOWJBYBGUT2W3TCBUIVANCNFSM4YUPEXFQ .

Your system won't let me sign the CLI from my other account (it recognizes that we are the same person) and opening a new PR will not solve anything. The commits were authored by my other account, and that's what your bot sees. Getting around this would require falsifying the GitHub commit history

See here and the image below

Hi Stella,
Here are instructions that might help resolve this, can you please take a
look?
https://opensource.google/docs/cla/#wrong-email
Another thing we could do is create a new branch with the same commits but
with the correct author, create a new PR based on that branch, and delete
the old branch and PR.
Sorry for the hassle! Your submission looks interesting and I would
definitely like to get it in so we can get the process started.
Best,
Guy
On Fri, Mar 5, 2021, 8:02 PM Stella Biderman<EMAIL_ADDRESS>wrote:

Got it. I suggest either signing the CLA from the new account (if you're
comfortable doing that of course), or creating a new PR. Do either of these
work for you? Best, Guy
… <#m_-8830352545756999543_>
On Thu, Mar 4, 2021 at 9:32 PM Stella Biderman @.***> wrote: Hi Stella,
Thanks for your submission! If you'd like to submit from a different
account, I suggest closing this PR and creating a new one using your other
account. Would that work? Best, Guy … <#m_4402750793553344496_> The account
that I originally submitted from (and the one I am now posting from) is the
correct account. However one of the commits in the PR was made from the
wrong account. Is deleting the PR still required? — You are receiving this
because you commented. Reply to this email directly, view it on GitHub <#121
(comment)
https://github.com/google/BIG-bench/pull/121#issuecomment-791166887>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADGRN6KQCVOWJBYBGUT2W3TCBUIVANCNFSM4YUPEXFQ
.
Your system won't let me sign the CLI from my other account (it recognizes
that we are the same person) and opening a new PR will not solve anything.
The commits were authored by my other account, and that's what your bot
sees.
Reply to this email directly, view it on GitHub
https://github.com/google/BIG-bench/pull/121#issuecomment-791862298, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADGRN4UYTTSYQV6Q4HFXITTCGSMXANCNFSM4YUPEXFQ
.


Easily discover expiration details of Certificates

Is your feature request related to a problem? Please describe.

Currently the expiration for a certificate is shown in two places

Secrets Lists - In a column full of text. There's no sort on this
Secret Detail Page - In the header
Note - The date is in red if expired, and also red if expiring (see https://github.com/rancher/dashboard/issues/10018P)

This is clear to the user if they see it for specific secrets, but they are unable to easily discover these

Describe the solution you'd like

Add a list view where users can see only cert secrets
Allow the user to easily see which certificates are expiring or have expired

Additional context

This was done as part of hackweek, so hasn't gone down the usual UX design path. Need to consider this before merging

@kwwii / @edenhernandez-suse I did this as part of hackweek, so the UX is developer created. There's a PR up with a screenshot. I'll bump this issue to your side for a review. If it looks fine, then I try and get it merged for 2.8next1

Looks good for an initial implementation. We can tweak how we are showing this kind of information later if necessary.

Added to possible automation-candidate as we can mock a cluster already (https://github.com/rancher/dashboard/blob/master/cypress/e2e/blueprints/nav/fake-cluster.ts), so we should "fake" some data in order to assert expiration dates, banners, etc

E2E looks good to me moving to Done


Blazor, AMP compatability

AMP just came out with a huge new feature; they are allowing 150kb of custom javascript. But the Blazor javascript code is more than 150kb. I would like for blazor to be AMP compatible because, with AMP and Blazor working side by side, websites could be incredibly fast, responsive, and use minimal resources!
AMP disallows very specific parts of the code that slows down the browser, and it does a lot of this by preventing pages from painting new elements after it's loaded, if the browser has to for example: modify the style sheet, then it has to repaint the page again, slowing things down a ton. AMP already has figured out what slows down the browser the most and gave us guidelines to keep things running smooth. And now, with Blazor, we would never have to reload the page at all, thanks to its powerful single page applications. Please, make this AMP compatible!

Thanks for contacting us, @AidanSpeakss.
This is not a goal for us at the moment. In the future we may look into reducing our JavaScript footprint.


Is there way to reverse transliteration string to its origin ?

Hello!
I need to transliterate some string and then get origin string from this transliterated string. Is there way to do it ?
Thanks in advance for your reply!

Hi @HarDGraD,
As far as I know it's quite hard to say. It depends on the specific languages you'd like to transliterate.
I'll take two examples.
tu and tú in Spanish do not mean the same thing, but they are both translated into tu.
上海 in Chinese means Shanghai (city) and is translated into Shang-Hai, but it also could be 伤害 (hurt).
Hope it helps.

Thank you for reply.
Yes. You are right. I will choose another way to resolve my problem.


Remove package-level Vitess flags

Similar to https://github.com/dolthub/vitess/issues/155, this is a show-stopper issue that crops up anytime you use go-mysql-server alongside with Vitess.
I do not believe the dolthub uses of Vitess require these to be flags at all. I do not believe you set them anywhere,
I am going to take a two-pronged approach here:

I'll set up a personal repo to demonstrate the flag namespace conflict
I'll open a PR against this vitess fork to replace all of the configurable flags with variables hard-coded to the default value

Please let me know if you think the above approach is unlikely to be accepted into this repo.

Example repo demonstrating the flag collision issue: https://github.com/ryanpbrewster/vitess-conflict-example
In particular:
$ go test src/my_test.go
/tmp/go-build3353698422/b001/my.test flag redefined: log_err_stacks
panic: /tmp/go-build3353698422/b001/my.test flag redefined: log_err_stacks

goroutine 1 [running]:
flag.(*FlagSet).Var(0xc00011c120, {0xc44218, 0x10f2e7c}, {0xb2be81, 0xe}, {0xb374b2, 0x1b})
        /home/ryanpbrewster/opt/go/src/flag/flag.go:879 +0x2f4
flag.BoolVar(...)
        /home/ryanpbrewster/opt/go/src/flag/flag.go:638
vitess.io/vitess/go/vt/vterrors.init.0()
        /home/ryanpbrewster/go/pkg/mod/vitess.io/vitess@v0.14.1/go/vt/vterrors/vterrors.go:103 +0x4e
FAIL    command-line-arguments  0.006s
FAIL

@reltuk, you kindly shepherded the previous protobuf cleanup PR through. Can you recommend someone who could champion this PR?

Confirming that as of commit c7560b3fabf0d1fcdaf845662b921c5187eb9320 in go-mysql-server this issue is resolved, I'll leave my example repo up w/ documentation.


Modules.Translate: figure out how to best let the user specify which space the offset should be applied in

A translation might happen in model space, instance space, view space, world space... and we need to allow the user to specify this, in a way as charming as possible. :)
Two immediate options, but there are more:

Add a new prop to Translate to specify which space the offset should be applied in.
Leave it to the user, who can probably easily transform the offset into the desired space themselves.

The big disadvantage of the first solution is that we would need to add this prop to all modules that build on top of Translate. The latter solution would not share this issue.

Decided to go for option B, and have Translate no longer apply its own transformation.


Maybe wrong EventType for set-uuid-state

https://github.com/serlo/serlo.org-database-layer/blob/21df42d5b5639bbe36ed663715211aa31ba06037/src/event/model/set_uuid_state.rs#L41
@inyono this should be __typename: EventType::SetUuidState, right?

Yes, good catch. (shouldn't cause issues atm since only raw_typename is actually used)

Yes, good catch. (shouldn't cause issues atm since only raw_typename is actually used)

Will fix it in my next PR,
was just hopeful thinking that the Event logic for /thread/set-archived is done already ^^

Will fix it in my next PR,
was just hopeful thinking that the Event logic for /thread/set-archived is done already ^^


Can I change the "content" left position?

I am experiencing a disturbing behavior where in "docked" mode, the "content" (everything on the right of the bar, that contentClassName designs), starts much further than the end of the side bar.
E.g. the side bar has a width of 150, but the content has style "left: 427px", and so I have a large white vertical band in the middle of the screen.
It goes away if I trigger a re-render somehow, but reappears when I reload the page. It does not matter what the content is.
Is there any way that I an at least specify a fixed left position for the "content"?

Ok, the solution is to not use className and CSS but the "style" attribute, and never put anything else but a link  in the content of the sidebar. An image, a span, an image in a link, whatever else will break the layout.


could no open port: "PermissionError(13, 'The device connected to the system is not functioning.', None, 31) in the AT script

When I run the AT test script, an exception is thrown when opening the AT serial port: could no open port: "PermissionError(13, 'The device connected to the system is not functioning.', None, 31)" I get this message. I don't know whats wrong, please help！
Below is my code ：
try:
self.controller = serial.Serial(self.com, self.rate)
rev_threa = threading.Thread(target=self.receive_msg_from_port_thread_py3)
rev_threa.setDaemon(True)
self.log('open serial')
rev_threa.start()
except Exception as ex:
self.log("SUMMARY:SUB SERVICE:%s,%s" % ("NA", "AT Port Exception"))
self.log('[%s]serial_open [%s, %d], ERROR:%s' % (self.module_name, self.com, int(self.rate), str(ex)))

just install ch341 driver version3.4 and RESTART. sure your uart chip is counterfeit


⚠ schweickart.me has degraded performance

In 2e545ec, schweickart.me (https://schweickart.me) experienced degraded performance:

HTTP code: 521
Response time: 265 ms

Resolved: schweickart.me performance has improved in a35d3d0 after 7 minutes.


docs: fix model name/year formatting

We should remove this todo soon so this can't happen https://github.com/commaai/openpilot/blob/master/selfdrive/car/docs_definitions.py#L79


[otbn,dv] Cover and trigger URND/RND spurious ack checking

OTBN is going to have checks that make sure we don't get acks from either EDN interface when we're not expecting them. Add coverage for these events and then write sequences to trigger them.

estimate 8
remaining 2022-08-11 4
remaining 2022-08-15 2
remaining 2022-09-15 1

@vogelpi and @GregAC : Is this one only about repetition and FIPS related checks?

No, this is not related to repetition and FIPS checks. The repetition and FIPS check tell us something about the quality of the received entropy.
The spurious ack checks tell us whether we've received entropy without requesting it. This is a strong sign that something doesn't behave as expected which may be due to a) a bug, or b) some FI attack going on.

Adding coverage point to see it happening.
Change response to see random ack.

estimate 4 2022-08-11

remaining 2022-08-15 2

Triggering done. Cover points not yet complete @prajwalaputtappa

remaining 2022-09-15 1

#14919 merged so closing


169 update landing page of dirtviz

Confused to what is being updated. Not only is this PR old, it appears that the description has already been updated.

Old PR closing


Hackage Latest Release is 1.5.19, but on GitHub Tags/Releases stop at 1.5.14

This is just a gentle request to properly tag the releases in this Git Repository according to what's on Hackage.
C.f. https://hackage.haskell.org/package/turtle

Thanks for the reminder!  I just update the tags to match Hackage


Should I commit .happypack folder to version control?

Here is the result of running ten times locally with happypack enabled (in ms):
47349
20827
32435
22967
20572
18457
17984
19034
18496
25159
and I would like to use it on production. However, we are doing many split testing on different servers, it would be better to have .happypack folder on each repo to boost the build time.
I also observed that the first time are always slower. How can I use happypack to optimize if there is only single build on each server? Or happypack is just designed to optimize the non-first-build performance?

So, the first time is always slower because I'm assuming there's no cache yet (i.e. .happypack isn't populated). How long does a webpack build normally take without happypack?
You may gain more speed on the initial build if you tune the thread count, or use a threadpool if you're using multiple happypack instances.
Otherwise, maybe you can do the build once then share the .happypack folder on all servers so that they all have a valid cache and don't need to build the assets again?
I know others have tried sharing the cache. You may end up with a path-related issue since right now happypack's cache contains full filepaths of the files, so if those change from one server to another the cache won't be valid, but we can solve that if it's the case.

I actually mean even if there is a cache (.happypack) exist, the first build time is still the slowest. Btw, thanks for answering.

Does it say that it's using items from the cache? Or does it say that N items are stale (where N would be your module count)?
Can you show the output of webpack with happypack please?


update cluster method with unions

Closes https://github.com/JuliaReach/ReachabilityAnalysis.jl/issues/347
@dfcaporale  if you have time to try again the model that triggered https://github.com/JuliaReach/ReachabilityAnalysis.jl/issues/347 and check that it is now fixed (or not) that would be great! iirc this method makes sense only if we set UnionSetArray <: LazySet  (that's why i didn't add a test here).

Pull Request Test Coverage Report for Build 454135510

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
1418 unchanged lines in 42 files lost coverage.
Overall coverage decreased (-30.3%) to 12.983%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Flowpipes/clustering.jl
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/Algorithms/TMJets/TMJets.jl
2
0%

src/Initialization/init.jl
2
66.67%

src/Algorithms/ORBIT/ORBIT.jl
3
0%

src/Algorithms/GLGM06/post.jl
4
82.14%

src/Hybrid/constructors.jl
4
62.5%

src/Algorithms/LGG09/LGG09.jl
5
0%

src/Flowpipes/solutions.jl
5
23.73%

src/Algorithms/INT/post.jl
6
74.07%

src/Continuous/exponentiation.jl
7
19.19%

src/Algorithms/ASB07/ASB07.jl
8
0%

Totals

Change from base Build 454044256:
-30.3%

Covered Lines:
568

Relevant Lines:
4375

💛  - Coveralls


WaveFormat tag will affect audio stream to file?

I found saving raw memory stream audio data using new WaveFormat(48000, 32, 2) and WaveFormat.CreateIeeeFloatWaveFormat(48000, 2) will produce very different results, the latter mixed with noises, the latter sounds like what I expected. When I looked into the source code, the only difference is Tag, BlockAlign looks the same. This really confused me since I need to resample and save raw audio bytes to file or pass to external service, first thing is that raw audio data is correct, how can I know about that?
using (MemoryStream memStream = new MemoryStream(_fileStream.ToArray()))
using (var pcm = new RawSourceWaveStream(memStream, new WaveFormat(48000, 32, 2)))
{
memStream.Flush();
pcm.Flush();
WaveFileWriter.CreateWaveFile(f, pcm);
}
using (MemoryStream memStream = new MemoryStream(_fileStream.ToArray()))
using (var pcm = new RawSourceWaveStream(memStream, WaveFormat.CreateIeeeFloatWaveFormat(48000, 2)))
{
memStream.Flush();
pcm.Flush();
WaveFileWriter.CreateWaveFile(f, pcm);
}

RawSourceWaveStream is for when you know exactly what the format of the audio is. The two waveformats you are using are different. The first is 32 bit integer (quite rare), and the second is 32 bit IEEE floating point (usually normalized into the range +/- 1.0)


feat: api endpoints for project boards

Fixes https://github.com/go-gitea/gitea/issues/14299
This PR is the continuation of the #28111
Adding endpoints for the boards

[x] POST /projects/{projectId}/boards
[x] GET /projects/{projectId}/boards
[x] GET /projects/boards/{boardId}
[x] PATCH /projects/boards/{boardId}
[x] DELETE /projects/boards/{boardId}

Just had a quick look but it looks like there is no is-user-able-to-see-project check at all.

Just had a quick look but it looks like there is no is-user-able-to-see-project check at all.

yes there is none right now, coz there are below mentioned hurdles which I wasn't sure how to tackle so wanted to discuss this out with someone responsible amongst the maintainers so that I take the right approach.
I asked this on the develop channel on discord but haven't received any response yet, so waiting for it
Hurdles:

Since projects and boards can be be related to either User, Organization and Repository the Permission's logic will differ based on the owner ship of the project.
Projects and Boards api are sort of root api example /user/{userId}/projects or /org/{orgname}/projects, so there is no ownership related contextual information available to do permission's check at the Route level.
Due to the above point we will have to perform all the permission's check in the Handler, which I am not sure if is the right idea since I have not seen this being done anywhere.

If someone can confirm, if its ok to do the manual permission's check in the Handler then I will go ahead and do the remaining implementations and finish this PR

Projects and Boards api are sort of root api example /user/{userId}/projects or /org/{orgname}/projects, so there is no ownership related contextual information available to do permission's check at the Route level.

What is the use case for these URLs? They seem to be GET the available projects for the current user which I think can be fulfilled by GET /api/v1/projects/search.
One can then further filter down by userId or orgname, much like /api/v1/repos/issues/search


cocoapods: 1.14.3 -> 1.15.1

Description of changes
https://github.com/CocoaPods/CocoaPods/releases/tag/1.15.1

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[x] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 286491 run on aarch64-darwin 1

2 packages built:

cocoapods
cocoapods-beta


Bad request: 400, random failure with message of "Sending.....

Randomly, some users are getting what appears to be a time out. Is there any more debugging I can enable?
On discord, requestrr just says "Sending....."
In the logs, it shows:
fail: Requestrr.WebApi.RequestrrBot.ChatBot[0]
Error while searching movies with title the marvels : Bad request: 400
DSharpPlus.Exceptions.BadRequestException: Bad request: 400
at DSharpPlus.Net.DiscordApiClient.EditWebhookMessageAsync(UInt64 webhook_id, String webhook_token, String message_id, DiscordWebhookBuilder builder, IEnumerable1 attachments)          at DSharpPlus.Entities.DiscordInteraction.EditOriginalResponseAsync(DiscordWebhookBuilder builder, IEnumerable1 attachments)
at Requestrr.WebApi.RequestrrBot.ChatClients.Discord.DiscordMovieUserInterface.MovieSelection(String customId, MovieRequest request, IReadOnlyList1 movies) in D:\Dev\Requestrr\requestrr\Requestrr.WebApi\RequestrrBot\ChatClients\Discord\DiscordMovieUserInterface.cs:line 46          at Requestrr.WebApi.RequestrrBot.ChatClients.Discord.DiscordMovieUserInterface.ShowMovieSelection(MovieRequest request, IReadOnlyList1 movies) in D:\Dev\Requestrr\requestrr\Requestrr.WebApi\RequestrrBot\ChatClients\Discord\DiscordMovieUserInterface.cs:line 31
at Requestrr.WebApi.RequestrrBot.Movies.MovieRequestingWorkflow.SearchMovieAsync(String movieName) in D:\Dev\Requestrr\requestrr\Requestrr.WebApi\RequestrrBot\Movies\MovieRequestingWorkflow.cs:line 49
at Requestrr.WebApi.RequestrrBot.SlashCommands.RequestGroup.MovieByTitle0(InteractionContext ctx, String movieTitle)

Hey @jkexbx,
This is a common issue I've seen on our Discord support server, from your logs, I can see your using an older version.  Recently I have taken over maintaining Requestrr, and as a consequent, all newer updates come from a new repo/location.
If you have installed Requestrr locally, you can get the newest update here.
If you are using docker, you will need to remove and setup the container again with your old settings, an example of these commands are:
sudo docker stop requestrr && sudo docker rm requestrr

sudo docker run \
  --name requestrr \
  -p 4545:4545 \
  -v path to config:/root/config \
  --restart unless-stopped \
  thomst08/requestrr:latest

If you are using Unraid, force an update, it should pull an update form the new location automatically, are worst, remove it and reinstall it.
I hope that helps, let me know if this works for you or if you have any issues.

Thanks for following up. I am using unraid, and did have to remove it and reinstall. It wouldn't pull an update just in unraid.
Funny enough, I get the exact same error when I rerun the search now that I'm on the new fork.
Error while searching movies with title marvels : Bad request: 400
DSharpPlus.Exceptions.BadRequestException: Bad request: 400
at DSharpPlus.Net.DiscordApiClient.EditWebhookMessageAsync(UInt64 webhook_id, String webhook_token, String message_id, DiscordWebhookBuilder builder, IEnumerable1 attachments)          at DSharpPlus.Entities.DiscordInteraction.EditOriginalResponseAsync(DiscordWebhookBuilder builder, IEnumerable1 attachments)
at Requestrr.WebApi.RequestrrBot.ChatClients.Discord.DiscordMovieUserInterface.MovieSelection(String customId, MovieRequest request, IReadOnlyList1 movies) in D:\Users\thoms\Documents\GitHub\requestrr\Requestrr.WebApi\RequestrrBot\ChatClients\Discord\DiscordMovieUserInterface.cs:line 46          at Requestrr.WebApi.RequestrrBot.ChatClients.Discord.DiscordMovieUserInterface.ShowMovieSelection(MovieRequest request, IReadOnlyList1 movies) in D:\Users\thoms\Documents\GitHub\requestrr\Requestrr.WebApi\RequestrrBot\ChatClients\Discord\DiscordMovieUserInterface.cs:line 31
at Requestrr.WebApi.RequestrrBot.Movies.MovieRequestingWorkflow.SearchMovieAsync(String movieName) in D:\Users\thoms\Documents\GitHub\requestrr\Requestrr.WebApi\RequestrrBot\Movies\MovieRequestingWorkflow.cs:line 41
at Requestrr.WebApi.RequestrrBot.SlashCommands.RequestGroup.MovieByTitle0(InteractionContext ctx, String movieTitle)

Thank you, I have seen a couple of reports of this exact same issue this morning on our Discord server and have recreated the issue, I have located the issue and will get a fix made soon, I will keep you posted when I have resolved the issue.

@jkexbx, I have created a new build to correct this bug.
https://github.com/thomst08/requestrr/releases/tag/V2.1.4-hf3
Please let me know if this is still an issue after updating.

Thanks! Confirmed running the new build. I'll keep an eye to see if it happens again.
Starting Requestrr - build v2.1.4 - Hotfix 3

Excellent, I have reports from others having the same issue and they have reported everything is working fine after this update, I will keep this open for a few days and close it if this is no longer reported.

There has been no more reports of this issue, I consider it to be resolved.


drafts: Add LeafletMap and LeafletGtfs

These are prototype maps using Leaflet, which gives card authors finer-grained control over rendering compared to the Google Maps iframe embed.

As an example of that type of control, there’s a LeafletGtfs card definition that fetches a GTFS file that specifies transit routes and renders them on the map.

It would be preferable to make use of Leaflet this without fetch and eval but I couldn’t get that working. This commit documents my hacks toward getting a traditional import of Leaflet from a CDN to work but I wasn’t able to get past an error about trying to read deviceXDPI off window.screen. I think the addition of document to the Fastboot context might be something to consider regardless.
This has some type errors, please see the comments and let me know how I can fix them.

@backspace any reason not to merge this?

@backspace any reason not to merge this?

no one has reviewed or answered any of my questions 🤓 some of the code here seems quite unsuitable to me and I’d love to learn best practices


Renaming not triggering proper events with different character cases

Hi,
When I rename a file with the same name but with different cases, such as test.txt -> Test.txt, unlike other renaming behaviors, such as test.txt -> test2.txt, the events triggered are "change + add" instead of an "unlink + add".
Occurred with:

Windows 10 Professional (20H2)
Node v12.22.1 & v14.17.2
Watcher v1.2.0
renameDetection is and must be disabled in my case but using it doesn't work either and also returns a "change + add"

Thanks!

That sure sounds like a bug, I'll look into that, thanks for reporting the issue!

renameDetection is and must be disabled in my case

Can you expand a little bit more on that? In particular has that to do with Watcher not being good enough for your use case?

Oh, don't worry about this!
The "must" is just that I've programmed it in a way that it's less redundant using only add and unlink rather than implementing additional events when those two already does the job properly together in my case. (It's a synchronization application)
Thanks again!

Implemented in v2.1.0. It was a bit tricky to implement, but pretty cool that it's detectable too.


running pm2 with npm script "react-scripts start"

Hi,
I am trying to use pm2 on a dev server with your npm start up script react-scripts start
Do you have any recommendations on where we could execute pm2 process on node.js running this script? normally we use pm2 start server.js --watch

Can you please explain the use case?
pm2 is meant for production usage.
npm start in Create React App is meant only for development as mentioned in its output message.

hi @gaearon
Our client requested we continuously run in dev mode on a server, so their beta testers can see error logs in the console. as well as the redux state logs to report back to our team.
So I wasn't sure exactly the path I can pass over to PM2 that will actually run this file, same goes for running in production I should add for the future.
Thanks so much for replying!

The command itself is in node_modules/.bin. npm adds it to PATH automatically inside scripts.
So the full command you want to run is node_modules/.bin/react-scripts start. Although it would be better to just run npm start in the project folder.
I hope this helps!

@gaearon is there a way to just execute the file? I just worry that it would run node and pm2 at the same time, I believe it runs node  already under the hood with pm2 command

Sorry, I don't really know how pm2 works. I provided the script path so it should be enough for you. If you're not sure how to pass it to pm2 please refer to its documentation or ask on StackOverflow. Cheers! Let me know if there's any other info I could provide you with.

problem is that npm start doesn't run as a daemon, so it's hard to detach and monitor. We need a way to run react-script as a daemon.

Can you create an issue describing your proposal?

https://github.com/facebookincubator/create-react-app/issues/1089

I just ran an ejected copy successfully in pm2 like this:
pm2 start scripts/start.js --name "myapp"
I imagine that for non-ejected apps, and based on the comments above, it would be executed like this:
pm2 start node_modules/.bin/react-scripts/start.js --name "myapp"

@sam3k 's command failed for me but I got it to run with a slight adjustment pm2 start node_modules/react-scripts/scripts/start.js --name "myapp"

It makes no sense to run npm start with pm2. The start script is only meant for development. You need to serve the production build using an actual server, like node with express.

I agree the question was a little misguided, but this answer puts one on the right path and goes beyond that by explaining the process very concisely.  Above and beyond the call of duty! Thanks!

add this deploy to your script in package.json
"deploy": "pm2 start ./server.sh --name yourAppName",
Then in the same directory as the package.json, create an executable server.sh:
echo "Serving yourAppName!"
serve -s build

Don't forget to make server.sh an executable by running:
chmod +x server.sh
Now it's party time! Deploy your app by running
npm run deploy
Done!


Add CodeCov integration to CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@055c391). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage          ?   92.85%
=========================================
  Files             ?       11
  Lines             ?      210
  Branches          ?        0
=========================================
  Hits              ?      195
  Misses            ?       15
  Partials          ?        0

Flag
Coverage Δ

unittests
92.85% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055c391...f9399a7. Read the comment docs.

@brianhhu An alternative coverage reporting "app" for CI that has no issues with fork-based PRs because no tokens are required for public repos.

LGTM, the error may be due to a missing existing CodeCov report for the base commit (see here)?

Good find! Basically what I suspected but wasn't willing to find a hard explanation.


Add spinning Glo icon to impact animation on wallet connection

Lottiefile coming soon

@Syncretik apologies for the delay on this - here's the lottiefiles
Cyan on pine lottiefiles.zip

do we need this for launch?

do we need this for launch?

Yes please. This is the only flashy animation that people will see regardless of their Glo balance --> important for a great first experience. Let's discuss with broader team if someone needs to take over this ticket / another one that's on your plate.


Partial mode should support syntactic diagnostics

Suggestion

🔍 Search Terms
partial mode, syntax-only, syntax diagnostics
✅ Viability Checklist

My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
When the server is in syntax-only mode, it should be able to provide syntactic diagnostics.  It would be non-trivial to provide all syntactic diagnostics because some are deferred until semantic checking, but we can and should report simple problems like unbalanced quotes and brackets.
For editors that consume diagnostics synchronously, this means supporting syntacticDiagnosticsSync.  For editors that consume diagnostics asynchronously this means accepting getErr and firing syntaxDiag events (but not semanticDiag or suggestionDiag events).
It's up to the editor to decide when diagnostics are requested, but they probably should be limited to permanent partial mode (as opposed to temporary partial mode, during project load).

📃 Motivating Example
if ((A && B) || (!C && D) || (!E && F))) {
   // There is an unbalanced paren above and it would be nice to find out without rebuilding
}

@DanielRosenwasser  I don't understand the labels on this feature.

This doesn't sound like an RC feature. Did we decide on that at the editor meeting?
If it's help wanted, do I need to work on it?

I haven't worked with partial mode at all, so it's going to take me more time than usual so I can learn how that works and how to test it.