osmoutils: error tolerance helpers

Closes: #6326
What is the purpose of the change

Add tolerance comparison function between osmomath.Dec
Add helper function to osmoassert to abstract assertion of equality in tests
Migrate tests to use this new function

Testing and Verifying

Test for Dec comparison: https://github.com/osmosis-labs/osmosis/pull/6336/commits/d9f07a45ce956ab92f4816b6ad29e8e478451fde
Migrated tests will check the helper

Documentation and Release Note
N/A

Important Notice
This PR modifies an in-repo Go module. It is one of:

osmomath
osmoutils
x/ibc-hooks
x/epochs

The dependent Go modules, especially the root one, will have to be updated to reflect the changes. Failing to do so might cause e2e to fail.
Please follow the instructions below:

Open https://github.com/osmosis/osmosis/actions/workflows/go-mod-auto-bump.yml
Provide the current branch name
On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

Just a thought: would be good to have an issue so that this doesn't comment if CI detects go.mod as updated

Nice! Some minor suggestions and requests.
Are you sure these are all the usage instances of errTolerance that we can refactor? It feels like there were more

hmm, you are right. I found more instances, but they directly use require package to assert comparison(example).
I refactored Equal() function to take testing.T and not testSuite here: https://github.com/osmosis-labs/osmosis/pull/6336/commits/80b3ad8c87c2dfa5ca15d6af6e40873c7e9c0c9b.
thanks for noting that out
cc: @p0mvn @mattverse

question to reviewers: why do we need this comparison - https://github.com/osmosis-labs/osmosis/blob/main/x/twap/api_test.go#L899-L904? the result is not checked. if it should not be checked, we can remove those lines, if the result should be 0, it is unchecked.
I tried to check the result value: https://github.com/osmosis-labs/osmosis/pull/6336/files#diff-f86385179fdd51029d8446f3063a7a6e71b8ac928c97e794ccad9b96f82ee28cR900, test fails
cc: @mattverse @p0mvn

question to reviewers: why do we need this comparison - https://github.com/osmosis-labs/osmosis/blob/main/x/twap/api_test.go#L899-L904? the result is not checked. if it should not be checked, we can remove those lines, if the result should be 0, it is unchecked.
I tried to check the result value: https://github.com/osmosis-labs/osmosis/pull/6336/files#diff-f86385179fdd51029d8446f3063a7a6e71b8ac928c97e794ccad9b96f82ee28cR900, test fails
cc: @mattverse @p0mvn

Please make an issue documenting all the findings and don't worry about it in this PR as it is out of scope

hey @p0mvn! issue created: https://github.com/osmosis-labs/osmosis/issues/6348, main merged

hey @p0mvn! issue created: #6348, main merged

Please review CI and re-ping once ready


add financial aid models to admin and load country income thresholds

Pre-Flight checklist

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
fixes #559
What's this PR do?
adds financial add models to admin and load country income thresholds
How should this be manually tested?
Just run the management command and that should load all the threshold incomes for each country
docker-compose exec web python manage.py load_country_income_thresholds flexiblepricing/data/country_income_thresholds.csv
Screenshots (if appropriate)

Codecov Report

Merging #563 (4970500) into main (2fbd1c3) will decrease coverage by 0.59%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   86.89%   86.29%   -0.60%
==========================================
  Files         114      116       +2
  Lines        4816     4868      +52
  Branches      766      775       +9
==========================================
+ Hits         4185     4201      +16
- Misses        520      556      +36
  Partials      111      111

Impacted Files
Coverage Δ

flexiblepricing/api.py
0.00% <0.00%> (ø)

flexiblepricing/exceptions.py
0.00% <0.00%> (ø)

flexiblepricing/admin.py
87.50% <86.66%> (-12.50%)
:arrow_down:

flexiblepricing/constants.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fbd1c3...4970500. Read the comment docs.

Getting an error trying to run the management command using the supplied CSV file:
Traceback (most recent call last):
  File "/src/./manage.py", line 19, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/src/flexiblepricing/management/commands/load_country_income_thresholds.py", line 20, in handle
    import_country_income_thresholds(options["csv_path"])
  File "/src/flexiblepricing/api.py", line 50, in import_country_income_thresholds
    country_income_thresholds = parse_country_income_thresholds(csv_path)
  File "/src/flexiblepricing/api.py", line 37, in parse_country_income_thresholds
    income_thresholds = [
  File "/src/flexiblepricing/api.py", line 37, in <listcomp>
    income_thresholds = [
  File "/usr/local/lib/python3.9/csv.py", line 111, in __next__
    row = next(self.reader)
ValueError: I/O operation on closed file.

File definitely exists in the container and can be read.

Getting an error trying to run the management command using the supplied CSV file:
Traceback (most recent call last):
  File "/src/./manage.py", line 19, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 419, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python3.9/site-packages/django/core/management/__init__.py", line 413, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 354, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python3.9/site-packages/django/core/management/base.py", line 398, in execute
    output = self.handle(*args, **options)
  File "/src/flexiblepricing/management/commands/load_country_income_thresholds.py", line 20, in handle
    import_country_income_thresholds(options["csv_path"])
  File "/src/flexiblepricing/api.py", line 50, in import_country_income_thresholds
    country_income_thresholds = parse_country_income_thresholds(csv_path)
  File "/src/flexiblepricing/api.py", line 37, in parse_country_income_thresholds
    income_thresholds = [
  File "/src/flexiblepricing/api.py", line 37, in <listcomp>
    income_thresholds = [
  File "/usr/local/lib/python3.9/csv.py", line 111, in __next__
    row = next(self.reader)
ValueError: I/O operation on closed file.

File definitely exists in the container and can be read.

Could you try once more by restarting your container? I did not get any such error even once.

I rebuilt and restarted the containers and am still seeing the error. Looking at it, the income_thresholds line (37) probably just needs an indent - it's outside the with so the file's closed at that point.

You could check that it's running till the end ZW,0 in the attached screenshots. Re-ran still going till the end and line 37 is already in the with block and in the same scope

@jkachel It's already in the with block and working fine as shown in the previous comment with the attached screenshots. But if I move that block out of with statement then it produces the error that you are asking for.
Maybe it's being moved out of with statement on your side. Could you please confirm it?


mp-packet-forwarder_3.0.20-r1 is obsolete

The code references "https://github.com/kersing/multitech-installer/raw/master/mp-packet-forwarder_3.0.20-r1_arm926ejste.ipk" to download the packet forwarder.
Unfortunately, this link is now broken.
Actually it was broken as of 2020, but I never noticed because the scripts look for, and use, a local copy.
Three action items (the Spanish Inquisition, etc.):

we should put a copy of the official 3.0.20-r1 someplace safe (maybe with mlinux stuff?).
the scripts should refer to the safe place
we need to consider updating to 3.0.25-r2 (which is current)

3.0.25 no longer needs node as it no longer applies the multiech overrides.

Fixed somewhere along the way to the current master.


spawn: print exception class and backtrace to stderr

I'd even ponder to exit! in that case, what do you think?

Should error/exit functionality be standardized?  Maybe a method or 2 on Exception like fatal_exit() or pretty_print(io = STDERR) followed by exit!

Updated to use the new method from #1300

@jhass :+1:


[ENH] _HeterogenousMetaObject to accept list of tuples of any length

Mirror PR of https://github.com/sktime/sktime/pull/4793 from sktime.
This improves the _HeterogenousMetaObject by widening its functionality.
_HeterogenousMetaObject now allows tuples of any length in the _steps_attr, as long as the zeroth elements are str names, and the first elements are estimators
Todo: add tests, can be adapted from the PR linked above.

Codecov Report

Merging #206 (94a3c28) into main (149fefa) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
- Coverage   82.41%   82.29%   -0.13%
==========================================
  Files          43       43
  Lines        2832     2835       +3
==========================================
- Hits         2334     2333       -1
- Misses        498      502       +4

Impacted Files
Coverage Δ

skbase/base/_meta.py
17.97% <0.00%> (-0.26%)
:arrow_down:

... and 1 file with indirect coverage changes


"atlas migrate diff" between schemas with slightly differing names produces: Error: *schema.ModifySchema is not allowed when migration plan is scoped to one schema

I'm trying to use atlas with schemas that are the same but have different names: i.e. we're hosting our (several) dev schemas and test schema on the same host so they all have slightly different names "project_db_jon", "project_db_alan", "project_db_test". Our staging/production schemas are on separate hosts and they're just called "project_db".
When I do atlas migrate diff I get this error Error: *schema.ModifySchema is not allowed when migration plan is scoped to one schema I assume because it's not happy about the different source/target schema names.
The only way I could get this to work was to generate HCL schema files and manually change all the schema name references, but is there a better way to make this work?

@a8m tagging as requested on discord

Hey @JonJLee2001 👋
I believe I've identified the problem - could it be that the MySQL dev database has a different collation or charset compared to what's defined in the HCL file? You can confirm this by running atlas schema inspect -u <dev-url>.

I'm getting the same error when running the exact command mentioned in the docs:
atlas migrate diff migration_name \
  --dir "file://ent/migrate/migrations" \
  --to "ent://ent/schema" \
  --dev-url "docker://postgres/15/test?search_path=public"

# Error: *schema.ModifySchema is not allowed when migration plan is scoped to one schema

Hey @ivanvanderbyl, downgrading Atlas to v0.12.0 should solve the issue. I will send a patch to fix this later today.

Closing, as this was resolved a few months ago.


fix error writing table when schema has no dyanmic columns

Inserting into the table will return an error if the table schema has no dynamic columns.
Here is an example that replicates the issue:
package main

import (
	"github.com/go-kit/log"
	"github.com/go-kit/log/level"
	"github.com/polarsignals/arcticdb"
	"github.com/polarsignals/arcticdb/dynparquet"
	"github.com/segmentio/parquet-go"
	"os"
)

func main() {
	var err error
	columnstore := arcticdb.New(nil)
	db := columnstore.DB("test_db")

	logger := log.NewLogfmtLogger(log.NewSyncWriter(os.Stderr))
	logger = level.NewFilter(logger, level.AllowDebug())

	schema := dynparquet.NewSchema("test_schema",
		[]dynparquet.ColumnDefinition{
			{
				Name:          "Column1",
				StorageLayout: parquet.Encoded(parquet.String(), &parquet.RLEDictionary),
				Dynamic:       false,
			},
		},
		[]dynparquet.SortingColumn{
			dynparquet.Ascending("Column1"),
		})
	tableConfig := arcticdb.NewTableConfig(schema, 256, 512*1024*1024)

	table, err := db.Table("test_table", tableConfig, logger)
	if err != nil {
		panic(err)
	}

	buffer, err := schema.NewBuffer(map[string][]string{})
	if err != nil {
		panic(err)
	}

	row := make([]parquet.Value, 0)
	row = append(row, parquet.ValueOf("hello").Level(0, 0, 0))
	err = buffer.WriteRow(row)
	if err != nil {
		panic(err)
	}

	err = table.Insert(buffer)
	if err != nil {
		panic(err)
	}
}

panic: failed to split rows by granule: failed to create dynparquet reader: deserialize dynamic columns metadata "": malformed dynamic columns string

goroutine 1 [running]:
main.main()
        /Users/albert.lockett2/Development/arcticdb/albert/main.go:52 +0x6e5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm sorry if this PR doesn't make sense. Maybe it is not appropriate to have a schema with no dynamic columns.
If that is the case, maybe one of the methods that is used to create the table could return an error as the schema without dynamic columns is invalid?

Amazing!! Thank you so much for the contribution!! 💯 🎉

@brancz happy to help

@brancz happy to help


[FR] Keep IDS/IPS logs

IPS logs are wiped after a restart when using tmpfs. It would be good if they could be kept, just like some of the other logs since those are pretty important.

No, don't use it. This has been the standard behaviour for years. Going to split /tmp and /var MFS setting eventually, but that won't change the underlying behaviour of a memory file system.

As long as you keep /var out of tmpfs, then it's all good :+1:

I will try to make this happen for 16.1.x :)


NodeJS SDk: Update test case for parallel provisioners

As a follow up it would be good to modify this test case to be similar to the one in Go or Python and run provisioners in parallel with each other: https://github.com/dagger/dagger/blob/main/sdk/python/tests/connectors/test_docker.py#L18
Not a blocker for merge though
Originally posted by @sipsma in https://github.com/dagger/dagger/pull/3820#discussion_r1022236930

This issue is out of date. The provisioning approach has changed.
More context here : https://github.com/dagger/dagger/pull/4194


Add sprites to a Custom Substate

What feature do you want to get added on the base engine?
The ability to add sprites into a custom substate. Because whenever you add a Lua sprite, regardless of whether or not you use, for example, onCustomSubstateCreate, sprites are always made and used in the PlayState class. If the substate pauses your game, this can cause an animated sprite to not be animated. So there should be a way to add sprites to the Custom Substate instead of PlayState.
To test your sight, and reliability, please select the option of what should NOT be requested.
Stage Editor, 6K+ support, and winning icons.

runHaxeCode exists for this

So how would I use runHaxeCode to do that? I'm not too familiar with Haxe code.

CustomSubstate.add(object);

function onSongStart()
	runTimer('start break', 0.2);
end

function onTimerCompleted(tag, a, b)
	if tag == 'start break' then
		openCustomSubstate('littleBreak', true);
	end
end

function onCustomSubstateCreate(tag)
	if tag == 'littleBreak' then
		runHaxeCode([[
			FlxG.sound.play(Paths.sound('confirmMenu'));
			bgSpr = new FlxSprite().makeGraphic(FlxG.width, FlxG.height, 0xFF000000);
			bgSpr.alpha = 0.4;
			CustomSubstate.instance.add(bgSpr);

			new FlxTimer().start(1.0, function(tmr)
			{
				FlxG.sound.play(Paths.sound('cancelMenu'));
				game.closeSubState();
			});
		]])
	end
end```


goreleaser: Use name_template for archive name

archive.replacements has been deprecated
so we should use archive.name_template.
Ref https://goreleaser.com/deprecations/#archivesreplacements
Blocks #22

bors merge

???

+ rsign sign -p /home/runner/work/go-change/go-change/.github/workflows/release.pub -s release.key -t 'pulumi/go-change v0.1.3 signed with automated key' -c 'see website for signing information' -x B3SUMS.auto.minisig B3SUMS
No such device or address (os error 6)

RELEASE_KEY secret is missing.
@AaronFriel I think only you can fix that.

bors merge

@AaronFriel I assumed your stamp came with the secret configuration fix. Was that not right?

bors merge

Oh I see, I missed the RELEASE_KEY comment. @abhinav feel free to remove the b3 signature check from the GitHub Actions - I think @blampe had a similar issue rolling out merge queues on the Pulumi Watch repo. The RELEASE_KEY is set on the repo, but it looks like the rsign command changed its signature.
I've added an issue to add cosign signatures, as that's easier to implement and verify.

bors merge

bors merge

@AaronFriel as far as I can guess, it's not a B3-specific issue? Should I just skip the signing step completely for now?

@abhinav Yeah, I don't know what broke with rsign's CLI.

bors merge

bors merge

bors merge

🤷

bors cancel

bors merge

Finally 😌


refactor(docs): add  important text about routes

Thanks @SanderElias ,  I spent a lot time working on it


Support running integration tests against local registry

This is just a POC.  Still takes 15 minutes :-(

PTAL; I'll leave modifying .travis.yml to a subsequent PR


PEAR-2056: Customize Columns - Reset Button - Tooltip z-index

Description
Checklist

[ ] Added proper unit tests
[ ] Left proper TODO messages for any remaining tasks
[ ] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

looks good 👍


Ballerina CLI tool throws Null pointer exception when generating a Ballerina service/client using an OpenAPI definition

Description:
I tried to generate a Ballerina service and a client Stub from an OpenAPI Contract as explained in the documentation using OpenAPI definition for JIRA. This gives me the following error stack.
[2021-08-16 23:01:09,287] SEVERE {b7a.log.crash} - null
java.lang.NullPointerException
at io.ballerina.generators.BallerinaServiceGenerator.createNodeForQueryParam(BallerinaServiceGenerator.java:794)
at io.ballerina.generators.BallerinaServiceGenerator.getFunctionDefinitionNode(BallerinaServiceGenerator.java:305)
at io.ballerina.generators.BallerinaServiceGenerator.generateSyntaxTree(BallerinaServiceGenerator.java:245)
at io.ballerina.openapi.CodeGenerator.generateBallerinaService(CodeGenerator.java:408)
at io.ballerina.openapi.CodeGenerator.generateBalSource(CodeGenerator.java:218)
at io.ballerina.openapi.CodeGenerator.generateBothFiles(CodeGenerator.java:113)
at io.ballerina.openapi.cmd.OpenApiCmd.generateBothFiles(OpenApiCmd.java:298)
at io.ballerina.openapi.cmd.OpenApiCmd.openApiToBallerina(OpenApiCmd.java:211)
at io.ballerina.openapi.cmd.OpenApiCmd.execute(OpenApiCmd.java:136)
at java.base/java.util.Optional.ifPresent(Optional.java:183)
at io.ballerina.cli.launcher.Main.main(Main.java:58)
Steps to reproduce:

Get the OpenAPI definition for JIRA here.
Run bal openapi -i openapi.json

Affected Versions:
Ballerina Swan Lake Beta 2
Language specification 2021R1
Update Tool 1.3.5
OS, DB, other environment details and versions:
Cent OS 7
OpenJDK 11.0.12 2021-07-20 LTS
OpenJDK Runtime Environment 18.9 (build 11.0.12+7-LTS)
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

This issue cause to query parameter to have an array type without no item type, Those types of query parameters can not be mapped to the ballerina resource query parameter since the ballerina query parameter not support for array with anydata.
In addition to that, I have identified other scenarios we are not supporting from openapi tool , one is we are not supporting the delete method with the request body required true. reference  RFC2616 (HTTP 1.1)

closing the issue since this NPE problem has been fixed in the Ballerina Swanlake beta6 version. Feel free to reopen if you will still face issues after running against the valid openAPI contract. 🙂


where to find the following Altera Quartus 9.0 SP2 files

Wanted to put this request in altera_archiving but can´t:
To the point: do you know where to find any of the files belonging to Altera Quartus II 9.0 SP2?
90sp2_nios2eds_windows.exe (12708709 bytes)
90sp2_modelsim_ae_windows.exe (231173223 bytes)
90sp2_dsp_builder_windows.exe (106965748 bytes)
thanks

I have the first two.  Unfortunately archive.org is still read-only so I can't upload them currently.  Feel free to email me at rick at mxshift.com and we'll figure something out.


motor out of range error isn't being caught

also display array number

needs reformatting so error is raised only after all linting is complete on the array and motor numbers


Client\Adapter\Proxy, Socket, and Test optimization on write() method to avoid repetitive uri->getQuery() when possible

[x] Is this related to quality assurance?

Thanks, @samsonasik


Update glossary copy

add definition as mouse-over text on event type bubble (see photo)

REVISED GLOSSARY
Town Hall - A forum where lawmakers give legislative updates and answer open questions from constituents.
"Empty Chair" Town Hall - A citizen-organized town hall held with or without the invited lawmaker.
Adopt-A-District/State - A citizen-organized town hall featuring a member of Congress from another district.
Office Hours - Opportunity to meet and question a lawmaker's staff. Usually held in district offices but sometimes are "mobile office hours."
Campaign Town Hall - A town hall organized by a candidate for office - whether an incumbent or challenger. (Town Hall Project includes these events as a public resource--not to endorse a particular candidate or campaign)
Ticketed Event - Paid events. Typically fundraisers. (Town Hall Project includes these events as a public resource--not to endorse a particular candidate or campaign)
Tele-Town Hall  - A town hall conducted by conference call or online.
DC Event - Event held in Washington D.C. when Congress is in session.

@nathanmwilliams I dont see a photo attached to this, but you're saying you want this as a little tooltip? When you mouse over the event card or the table or both?

Yeah, top priority is just updating the glossary on the main page and in the email alerts.
Total luxury is adding the definition as a tooltip on the event category bubble.


Probe interval behavior - faq

@chadmath : Thanks for your contribution to the Azure documentation! The author, @davidmu1, has been notified to review your proposed change.

@amitsriva - Are we going to do something with this or should I close it?

@vhorne Can you take a look?

@chadmath
OK, Instead of putting probe info in the FAQ, we clarified the probe interval description in the Health article: https://docs.microsoft.com/en-us/azure/application-gateway/application-gateway-probe-overview#probe-intervals
#please-close


Update tests for sources using processor.py

Changes to the processor.py file means expected output for tests need to be updated.

I can have a look at this :-)

That's grand thanks. I got as far as changing the source files so structure is ok.
But because we are using exact copies of data files (including content) it seems to be failing where the content between expected output (static) and test output (generated) is significantly different - in the cases I've seen, where the order of the content is different. So this makes it really easy to fail since we don't consistently order the content post-retrieval.
I also have much much bigger questions about whether we should be using exact copies of data, rather than making a dummy set of data for test purposes only. Exact copies of data will age really quickly.
See what you think?

got it working locally.
bug 1 - generate mock data tries to get new data for new data sources (add at CTC) and this causes issues - can mask these for now.
bug 2 - dcat.py has a bug on line 47. ds[8] should be ds[9] now.

I'm not sure I follow on the test data? it's a copy but that's in order to make it static.
Obviously we need to update the csv compare files if we change the headers / ordering. I could split the data source update from the csvs expected update.

on bug 1:
change line 67 in generate_new_mock_data.py to: if url_list[name]["type"] in ["USMART", "dcat", "arcgis"]:

generate_new_mock_data.py could certainly be improved. likely you'd like it to be more selective in what it does, rather than a blanket update of everything. but that's a separate issue/feature

I'll sort it out :-)

bug 3 - csv checker needs a new checker for valid filenames {"title": "FileName", "test_func": is_valid_filename}, - which for now i'll just make as a basic string check

see #158 PR. I fixed it :-)
You can close this one is you like.

PR #158  closes this. Keen to follow up on @gavbarnett's point about improving generate_new_mock_data.py so have opened #159 for it.


[doc] Add instruction for running cirque tests

Problem
We don't have cirque test document in chip so that we don't know how to locally reproduce it if it breaks.

Summary of Changes
Add instruction for running cirque tests
Fixes #4084

Will merge restyled pr after this is approved.


Add styling and responsiveness

Can I do this ?

Yeah you can

Can I do this ?

Made the required changes just have a look.

Yeah Great work.


Mac Catalyst dev tools support

For macOS with .NET MAUI dev tools, react to resolution of https://github.com/dotnet/maui/issues/5561. Context at https://github.com/dotnet/AspNetCore.Docs/pull/25384#discussion_r834701257.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 48e7c079-a7e4-e0a4-ed19-935436113b70
Version Independent ID: 48e7c079-a7e4-e0a4-ed19-935436113b70
Content: Use browser developer tools with ASP.NET Core Blazor Hybrid
Content Source: aspnetcore/blazor/hybrid/developer-tools.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Fixed by https://github.com/dotnet/AspNetCore.Docs/pull/28115.


MultiFileWatcher - Improve error handling if FileSystemWatcher fails

This doesn't fix the issue with the finalizer thread dying in FileSystemWatcher.Dispose (See also https://github.com/NLog/NLog/issues/1946#issuecomment-369038913 and mono/mono#7338)
It just improves the error handling and logging.

:+1:


feat: 🎸 Dashed rendering options for tools with lines/handles

Dashed line rendering options for all tools.
Open the console and paste:
const tools = cornerstoneTools.store.state.tools;
tools.forEach(tool => { const config = tool.configuration;  config.renderDashed = true; tool.configuration = config});

And all tools will be rendered in dashed mode. This can be done per tool, so you could have dashed in one viewport and solid in another.
The dash style is set in the globalConfiguation module, with a default lineDash of [4,4].

Is the lineDash hard coded? [4, 4]
I think that's fine for now.
Long-term, it would be nice if tools/annotations had a way to override toolStyle in a consistent/granular way.
Thanks for authoring this PR

@dannyrb

Is the lineDash hard coded? [4, 4]

That's just the default, you can set it in the globalConfiguration module.

:tada: This PR is included in version 4.16.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unable to target html elements within the webui-popover with jquery

Trying to target the content that is added within the popover, however it seems like the plugin might be preventing it?
The .on function should work for this but doesn't...
$("body").on("click",".label",function(e) {
alert("Testing");
});

@nick2687 Has this been solved for you? I cannot get it to work.

@sandywalker I am using this as my content in the popover:
var emailBody =

Send Email

and this is how I am creating popover:
$('#shareEmailButton').webuiPopover({
placement : 'top',
type:'html',
content : function() {
return emailbody;
}
});
But when I click on input or textarea, nothing happens and I cannot edit them.
Can;t seem to get it working.

The plugin updated so much, this problem should be fixed

Hi @sandywalker. It still didn't work.

Had the same problem trying to reach inputs inside popover in my modal.
Changing 'container' option to '.modal-body' for correct events delegation did the trick for me.
Found answer here: https://stackoverflow.com/a/24015585/6103499


Constant refreshing occurring after redirecting back on LinkedIn

Description
After scraping companies on glassdoor, the application redirects back to linkedin but keeps refreshing. Fix the constant refreshing happening after scraping company
To replicate the issue:

Run the code by following the steps provided on the README.md file
Wait for LinkedIn to load and press ' c ', to start scraping the Glassdoor website
Give some small value like ' 10 '
After it finishes scraping, it will redirect back to LinkedIn
Error comes here and it never stops refreshing

can i get it assigned ?

can i get it assigned?

can i get assigned this issue?

@VirajShankar you have been assigned. @maverickayush7 and @n1haldev you have been assigned to other issues check that

can you assign me this

can you assign this issue to me?

I tried but I'm not able to make any valuable changes.You can assign it to someone else @Vaarun-Kamath

@kaushal1014 You have been assigned for this issue.

Can I get assigned this issue?

can i get assigned to this issue #7

@kaushal1014 I need an update by 9:45, else I will reassign this issue

hi can i please work on this issue

can i get assigned if this is still open?

@devanshishukla17 you have been assigned to this issue

@devanshishukla17 reply if you are working on this issue.

Can I get assigned?

@Suhaniverma2004 you are assigned


Apply value transform immediately on construction

Resolves #239

Coverage remained the same at 100.0% when pulling 867fd91d2663ac100231ef215de84a37396a3c85 on jeffgbutler:gh-239 into c4a05d1dd0d02ae91126471db6e01a9341f15f71 on mybatis:master.


Option to disable third party requests for embedded content

If a link to, for instance, a Youtube video, is posted, the Rocket.Chat client will embed the video (meaning that the electron client will make connections to Youtube to retrieve the embed page and assorted javascript). This is a privacy leak, so it would be nice to have an option to disable this behavior, or to disable all such third party connections in general.

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!


Improve performance for physical plan creation with many columns

Which issue does this PR close?

Closes #12738.
Rationale for this change

I investigated the performance degradation in creating physical plans for queries with a large number of columns compared to version 40 and discovered the following:

The main time loss occurs during the cloning of plan nodes during optimizations. We can compare two flame graphs (for version 40 and version 42, attached) and see that in version 42, enforce_distribution spends additional time destroying the vector of AggregateFunExpr. It turns out that in patch f5c47fa274d53c1d524a1fb788d9a063bf5240ef, the Arc for storing aggregate expressions was removed. As a result, during calls to with_new_children, fairly heavy structures are being cloned and destroyed.

Some time was also spent on a new optimization: limit pushdown. This is optional and left up to the user to decide whether to use it, so there are no issues here.

This patch restores the Arc wrappers for storing aggregates in the physical plan nodes, and also adds a benchmark aimed at preventing the degradation from recurring.
Additionally:
As can be seen from the flame graphs, a significant amount of time is spent on creating ProjectionMapping. This mapping is only needed when there are eq properties, which are irrelevant for some plans, so it gets built unnecessarily, wasting time. I will raise a separate issue for this.

====
Flamegraphs here:
flamegraphs.zip

As can be seen from the flame graphs, a significant amount of time is spent on creating ProjectionMapping. This mapping is only needed when there are eq properties, which are irrelevant for some plans, so it gets built unnecessarily, wasting time. I will raise a separate issue for this.

THank you

I have this on my list to review tomorrow if no one beats me to it

Additionally:
As can be seen from the flame graphs, a significant amount of time is spent on creating ProjectionMapping. This mapping is only needed when there are eq properties, which are irrelevant for some plans, so it gets built unnecessarily, wasting time. I will raise a separate issue for this.

It would be great to file an issue for this -- I am happy to do so if you like

Additionally:
As can be seen from the flame graphs, a significant amount of time is spent on creating ProjectionMapping. This mapping is only needed when there are eq properties, which are irrelevant for some plans, so it gets built unnecessarily, wasting time. I will raise a separate issue for this.

It would be great to file an issue for this -- I am happy to do so if you like
Yes, I like, thank you!

Thanks again @askalt  -- I am now working on the follow on ticket

Filed https://github.com/apache/datafusion/issues/13015 and a follow on issue here https://github.com/apache/datafusion/pull/13012


Unexpected UnobservedTaskException when sending a request with Mediator with a consumer that throws

Contact Details
No response
Version
8.x
On which operating system(s) are you experiencing the issue?
MacOS, Linux
Using which broker(s) did you encounter the issue?
Mediator
What are the steps required to reproduce the issue?
Create a trivial `Consumer` that just always throws:

public record DummyResponse(string Id);

public record DummyRequest(string Id);

public class DummyRequestConsumer : IConsumer<DummyRequest>
{
    public async Task Consume(ConsumeContext<DummyRequest> context)
    {
        await Task.Yield();

        context.CancellationToken.ThrowIfCancellationRequested();

        throw new InvalidOperationException("This is a dummy exception");
    }
}

Use it in a Minimal API like so:
routeBuilder.MapPost("/error", async (HttpContext ctx, IScopedMediator mediator) =>
{
    var guid = Guid.NewGuid().ToString();
    try
    {
        var response = await mediator
             .CreateRequestClient<DummyRequest>()
             .GetResponse<DummyResponse>(new DummyRequest("foo"));
        System.Console.WriteLine("success");
    }
    catch (InvalidOperationException e)
    {
        System.Console.WriteLine("error in mass transit consumer");
    }

    // below wouldn't be in real code but needed to force the UnobservedTaskException to happen immediately
    GC.Collect();
    GC.WaitForPendingFinalizers();

    return Results.Ok();
});

And register a UnobservedTaskException handler during startup:
// in Program.cs

TaskScheduler.UnobservedTaskException += (sender, eventArgs) =>
{
    System.Console.WriteLine("Unobserved task exception!");
};

What is the expected behavior?
No UnobservedTaskException happens, InvalidOperationException thrown from the call to await CreateRequestClient().GetResponse<>() and handled by the catch clause.
What actually happened?
a UnobservedTaskException event is raised,  This is causing spurious Sentry errors since Sentry by default includes capture of UnobservedTaskException (and I'd rather not disable it).
The try-catch does work as expected as well, and the UnobservedTaskException is not actually causing any problems beyond the spurious error reporting.
Related log output, including any exceptions
The above is adapted from the real code so I don't have the logs captured, but pretty much there is a log from MassTransit like this:
[13:42:34 ERR MassTransit] R-FAULT loopback://localhost/mediator 9b470000-a202-f230-94b2-08dbaf19cc99 DummyRequest DummyRequestConsumer(00:00:00.0006384)

followed by the WriteLine output from the catch clause and then the UnobservedTaskException handler from the example code above.
Link to repository that demonstrates/reproduces the issue
No response

If you can submit a complete repository reproducing the issue, great, otherwise, this will be closed.
It's likely a duplicate as well, cause I know this was fixed: https://github.com/MassTransit/MassTransit/issues/1240

I did look for past issues along these lines and I saw that one, but since it happens with the latest version (I am running 8.0.15 in prod, but I tried locally with 8.1.0 just to test), I am pretty sure this one is different.
I will create a repo.

@phatboyg  https://github.com/dkokotov/mt-unobserved-task-error
and the output:
info: Microsoft.Hosting.Lifetime[14]
      Now listening on: http://localhost:5098
info: Microsoft.Hosting.Lifetime[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Hosting.Lifetime[0]
      Hosting environment: Development
info: Microsoft.Hosting.Lifetime[0]
      Content root path: /Users/dkokotov/dev/checkouts/cnaught/mt-unobserved-task-error
warn: Microsoft.AspNetCore.HttpsPolicy.HttpsRedirectionMiddleware[3]
      Failed to determine the https port for redirect.
info: MassTransit[0]
      Configured endpoint mediator, Consumer: Test.DummyRequestConsumer
fail: MassTransit[0]
      R-FAULT loopback://localhost/mediator 63500000-a202-f230-e9e6-08dbaf1ff86a Test.DummyRequest Test.DummyRequestConsumer(00:00:00.0063990)
      System.InvalidOperationException: This is a dummy exception
         at Test.DummyRequestConsumer.Consume(ConsumeContext`1 context) in /Users/dkokotov/dev/checkouts/cnaught/mt-unobserved-task-error/Program.cs:line 58
         at MassTransit.DependencyInjection.ScopeConsumerFactory`1.Send[TMessage](ConsumeContext`1 context, IPipe`1 next) in /_/src/MassTransit/DependencyInjection/DependencyInjection/ScopeConsumerFactory.cs:line 22
         at MassTransit.DependencyInjection.ScopeConsumerFactory`1.Send[TMessage](ConsumeContext`1 context, IPipe`1 next) in /_/src/MassTransit/DependencyInjection/DependencyInjection/ScopeConsumerFactory.cs:line 22
         at MassTransit.Middleware.ConsumerMessageFilter`2.MassTransit.IFilter<MassTransit.ConsumeContext<TMessage>>.Send(ConsumeContext`1 context, IPipe`1 next) in /_/src/MassTransit/Middleware/ConsumerMessageFilter.cs:line 48
fail: MassTransit[0]
      R-FAULT loopback://localhost/mediator 63500000-a202-f230-e9e6-08dbaf1ff86a 00:00:00.0409309
      System.InvalidOperationException: This is a dummy exception
         at Test.DummyRequestConsumer.Consume(ConsumeContext`1 context) in /Users/dkokotov/dev/checkouts/cnaught/mt-unobserved-task-error/Program.cs:line 58
         at MassTransit.DependencyInjection.ScopeConsumerFactory`1.Send[TMessage](ConsumeContext`1 context, IPipe`1 next) in /_/src/MassTransit/DependencyInjection/DependencyInjection/ScopeConsumerFactory.cs:line 22
         at MassTransit.DependencyInjection.ScopeConsumerFactory`1.Send[TMessage](ConsumeContext`1 context, IPipe`1 next) in /_/src/MassTransit/DependencyInjection/DependencyInjection/ScopeConsumerFactory.cs:line 22
         at MassTransit.Middleware.ConsumerMessageFilter`2.MassTransit.IFilter<MassTransit.ConsumeContext<TMessage>>.Send(ConsumeContext`1 context, IPipe`1 next) in /_/src/MassTransit/Middleware/ConsumerMessageFilter.cs:line 48
         at MassTransit.Middleware.ConsumerMessageFilter`2.MassTransit.IFilter<MassTransit.ConsumeContext<TMessage>>.Send(ConsumeContext`1 context, IPipe`1 next) in /_/src/MassTransit/Middleware/ConsumerMessageFilter.cs:line 72
         at MassTransit.Middleware.TeeFilter`1.<>c__DisplayClass5_0.<<Send>g__SendAsync|1>d.MoveNext() in /_/src/MassTransit/Middleware/TeeFilter.cs:line 40
      --- End of stack trace from previous location ---
         at MassTransit.Middleware.OutputPipeFilter`2.SendToOutput(IPipe`1 next, TOutput pipeContext) in /_/src/MassTransit/Middleware/OutputPipeFilter.cs:line 76
         at MassTransit.Middleware.OutputPipeFilter`2.SendToOutput(IPipe`1 next, TOutput pipeContext) in /_/src/MassTransit/Middleware/OutputPipeFilter.cs:line 108
         at MassTransit.Middleware.DeserializeFilter.Send(ReceiveContext context, IPipe`1 next) in /_/src/MassTransit/Middleware/DeserializeFilter.cs:line 40
         at MassTransit.Middleware.RescueFilter`2.MassTransit.IFilter<TContext>.Send(TContext context, IPipe`1 next) in /_/src/MassTransit/Middleware/RescueFilter.cs:line 43
error in mass transit consumer
Unobserved task exception!
Unobserved task exception!

Yeah, seems like something about the way mediator immediately throws is causing it. Since other exception types don't behave the same way.

I'm not really sure why, but it's easily reproduced in a unit test. I just don't know what Task it is. Not sure when I'll get back to it since it's a benign warning.

For whatever reason I couldn't let this go, so did a bit more debugging this morning and I have a theory.
For one thing, this does not happen if I change the example repo to use an in-memory bus instead of mediator.
Stepping through in the debugger, the difference is in the execution of ClientRequestHandle.SendRequest. In the mediator case, if the consumer throws, then the call on line 145 (https://github.com/MassTransit/MassTransit/blob/develop/src/MassTransit/Clients/ClientRequestHandle.cs#L145) throws, and is handled by the catch on line 168 (https://github.com/MassTransit/MassTransit/blob/v8.0.15/src/MassTransit/Clients/ClientRequestHandle.cs#L168). Note that this eventually rethrows. But the SendRequest method is assigned to _send in the constructor but never awaited. Therefore, once the ClientRequestHandle instance goes out of scope and is finalized/GC-ed, the UnobservedTaskException is triggered. Another way to verify this is to replace the call to GetResponse in my example repo with
    RequestHandle<Test.DummyRequest> handle = requestClient.Create(new Test.DummyRequest("foo"));
    await handle.GetResponse<Test.DummyResponse>().ConfigureAwait(false);

in this case, because the handle instance is not yet eligible to be finalized when I call GC.Collect() the unobserved error does not happen.
On the other hand, for the in-memory bus, the exception is not thrown synchronously in SendRequest, rather, a fault message is send and then converted into RequestFaultException as you describe in https://masstransit.io/documentation/concepts/requests#request-consumer. So the _send task is never faulted.
I haven't tried to implement a fix yet, but I think it would just be to add an await _send to GetResponse before returning response.

I tried to address that one by adding to the constructor:
_send = SendRequest();

_send.IgnoreUnobservedExceptions();

But it didn't change the outcome. I've gone down the same path, and tried to ignore everything, but it doesn't help. It's some other task, and I can't figure out which task it is. You're right about the different path, because of how mediator runs immediately, vs. via a message.

ok, I spent a bit more time down this rabbit hole. It wasn't actually the _send thing because after stepping through the code more carefully, it's actually what is returned from GetResponse (via ResponseHandlerConnectHandle) and therefore is awaited.
Instead the culprit _seems) to be the execution of HandleFail via Task.Factory.StartNew(HandleFail, CancellationToken.None, TaskCreationOptions.None, _taskScheduler) (https://github.com/MassTransit/MassTransit/blob/v8.0.15/src/MassTransit/Clients/ClientRequestHandle.cs#L251).
I am not totally sure what the problem is. One theory is that it sets exception on the _completed task completion source in ResponseHandlerConnectHandle. one reason for thinking so is that if you actually examine the sender of the UnobservedTaskException event, it is a Task<ConsumeContext<DummyResponse>> - and this is the only place in the code where that task might be produced, from what I can tell.
a fix I tried that seems to work is having an async version of the Fail method where that call to Task.Factory.StartNew(HandleFail, CancellationToken.None, TaskCreationOptions.None, _taskScheduler) is awaited. with this in place, the unobserved task exception disappears. I also tried your adding .IgnoreUnobservedExceptions() to that call, but that did not fix it. I pushed this to my sample repo: https://github.com/dkokotov/mt-unobserved-task-error/blob/main/MyClientRequestHandle.cs#L165, https://github.com/dkokotov/mt-unobserved-task-error/blob/main/MyClientRequestHandle.cs#L251.
I confess I still only have a half-understanding of how all the pieces fit together, so I am not sure if this would have any ill side effects, but at least in my simple example, it did not.

This is the unit test I use within the MassTransit codebase to reproduce it:
    [TestFixture]
    [Explicit]
    public class Sending_a_request_using_mediator_that_faults :
        InMemoryTestFixture
    {
        [Test]
        public async Task Should_observe_all_exceptions()
        {
            var mediator = MassTransit.Bus.Factory.CreateMediator(x =>
            {
            });

            List<object> unhandledExceptions = new List<object>();
            List<Exception> unobservedTaskExceptions = new List<Exception>();

            AppDomain.CurrentDomain.UnhandledException += (sender, eventArgs) =>
            {
                unhandledExceptions.Add(eventArgs.ExceptionObject);
            };

            TaskScheduler.UnobservedTaskException += (sender, eventArgs) =>
            {
                eventArgs.SetObserved();
                unobservedTaskExceptions.Add(eventArgs.Exception);
            };

            IRequestClient<PingMessage> requestClient = mediator.CreateRequestClient<PingMessage>(InputQueueAddress, TimeSpan.FromSeconds(1));

            Task<Response<PongMessage>> response = requestClient.GetResponse<PongMessage>(new PingMessage());

            Assert.That(async () => await response, Throws.TypeOf<RequestException>());

            GC.Collect();
            await Task.Delay(1000);
            GC.WaitForPendingFinalizers();
            GC.Collect();

            Assert.That(unhandledExceptions, Is.Empty, "Unhandled");
            Assert.That(unobservedTaskExceptions, Is.Empty, "Unobserved");
        }
    }

You're also calling CancelAndDispose instead of HandleFail...
https://github.com/dkokotov/mt-unobserved-task-error/blob/main/MyClientRequestHandle.cs#L278

Good catch on that - I obviously copy-pasted the wrong line.
So it was a bit of a red herring, but I think it did point to what is actually the right solution - while having the Fail call awaited did not matter, not calling it at all did fix it.
So after further trial and error, the culprits do appear to be some of those TaskCompletionSources. Specifically ClientRequestHandle._message and ResponseHandlerConfigurator._completed. Adding a .IgnoreUnobservedExceptions() to their tasks (https://github.com/dkokotov/mt-unobserved-task-error/blob/main/masstransit-error/MyClientRequestHandle.cs#L52 and https://github.com/dkokotov/mt-unobserved-task-error/blob/main/masstransit-error/MyResponseHandlerConfigurator.cs#L27) fixes the issue. I've added your unit test (https://github.com/dkokotov/mt-unobserved-task-error/blob/main/masstransit-error-test/UnobservedExceptionMediatorTest.cs) and it fails using the unchanged MT code but passes with my fixes.
I can create a PR with this fix against your actual repo if it helps.

I added the ignore unobserved exception in the cases where the exception was specified.

Awesome, thanks! When do you think you'll push a new tag/nuget package with the fix?

There is already a prerelease package with the fix.


[fix] Fixes Azure DevOps link formats. Fixes #1439

Description
Currently, the Copy As -> Copy Remote File Url command for an Azure DevOps repo does not result in an URL that will open the file. This closes #1439
Checklist

[x] I have followed the guidelines in the Contributing document
[x] My changes follow the coding style of this project
[x] My changes build without any errors or warnings
[x] My changes have been formatted and linted
[x] My changes include any required corresponding changes to the documentation
[x] My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
[x] My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

Thank you for your contribution!


It does not scroll correctly

Hi there!
i've tried to use it on two different components, a menu and the other components (which contains the anchors) When i click on the menu nothing happens however the URL is correctly modified. if I let it as localhost/#item and refresh the browser it correctly scrolls down to the element.
Any idea how I can fix this?

Do you have the code available, or a demo?

I am experiencing the same issue. The url is being updated (most likely due to HTML/React itself) but no scrolling is taking place.
Relevant code: https://paste.ofcode.org/38s55GyB4baHePvBbh73GBy
React version: 6.1.0
I'm working in a Gatsby project. Not sure if that has anything to do with it.

Fixed. Wrap content in a div to make it work properly.


Awesome Work Really Loved it.

Hello. I was wondering if there is a way to get full chapters instead of specific verses?

Hi Daniel,
Apologies for the extremely late response. Currently not unless you specify the entire verse range. I will look into adding this as it is a great feature to have.
Best Regards,
Glow


[BUG] Connecting to Server with Puppet on Stage using Unsynced Assets

If you join a server, it makes all the puppets appear before it downloads any assets the server has that you don't. That makes any character using those assets not appear, and they won't reappear even after the assets are downloaded.
Current workaround: the pupppet can switch to another puppet and then back, and he'll appear on any clients that didn't see him before.

Additionally, if you try to connect and are using assets not available on the server, then you won't even be assigned your own puppet.
Current workaround: Connect using a puppet that only uses assets already available on the server. If you are unsure what assets they have, create an empty puppet and connect using that.

Fixed with 9da2899cf07b11d3c608b5f25aabe767d6b24597


Inline chat content widget doesn't relayout when having multiple input lines

start inline chat
in the content widget author multiple lines
:bug: the widget's height doesn't change

still kind of running into this kinda - height changes, but the prompt layout after querying is unreadable.
also, seems like there is a weird horizontal scroll element on the bottom left of the widget?
https://github.com/microsoft/vscode/assets/54879025/7faf4837-a555-4180-a558-7af0dd914888

I see. This is because the height of the zone is limited by the overall height of the editor. It doesn't want to take more than 42% - that's something we can tweak but you might be facing a bit of a special case having a multiturn convo and accessibility viewer enabled as well.

The first prompt handles a long string nicely.
A long string for the follow-up prompt results in content overflow.


chore: jsonfmt hardwaresecuritymodules

Ran jsonfmt -w "specification/hardwaresecuritymodules/**/*.json"

Automation for azure-sdk-for-go

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

Automation for azure-sdk-for-java


Add a cop to enforce expected exceptions to be specified

In order to avoid false-positives in the context of exception checking it is valuable to be able to enforce that each to raise pair to include specifying information about the type of exception.
We have this vendored internally at Strava and have been happy with the improvement and would love an opt-in solution upstream.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the changelog if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[x] Added the new cop to config/default.yml.
[x] The cop documents examples of good and bad code.
[x] The tests assert both that bad code is reported and that good code is not reported.

I think this is a brilliant idea. I’m open to having this cop enabled by default – why not?
I have a few comments regarding the implementation, but I’ll wait with those until I’ve heard other opinions on the rule itself.
/cc @Darhazer

I agree, the rule is good and let's have it enabled by default

Alright, I've addressed all of the feedback I believe - I've made the cop a default, used MSG correctly, and even remembered some tricky semantics.  Please take another look.

Any comments on the implementation @Darhazer ?

I tried to do something clever to DRY out the specs to cover both raise_error and raise_exception but failed to do so in a way that didn't make the specs worse (IMO).  I've duplicated the tests in two contexts but am definitely willing to make them better if you have good ideas on how.

Alright, I've addressed the second round of feedback - how are we feeling about this now @Darhazer ?


Add nested global member creation to shim

Since literally nowhere else do we reference a TypeScript namespace anymore, it wasn't getting made.
Fixes #35469

@weswigham thanks for the fix!


Socket.io example development server does not connect to socket.io websocket in server/index.js

What version of Remix are you using?
1.4.0-pre.2
Steps to Reproduce
Clone the Remix repo and navigate to the Socket.Io example: https://github.com/remix-run/remix/tree/main/examples/socket.io
Start the app server:
npm run start:dev

Run the development server:
npm run dev

Visit http://localhost:3000, and notice the connected log from the websocket in your terminal.
Then try making a change in the app's app/routes/index.tsx like changing some text.
The text will not update.
Visit http://localhost:3001, and try making a change again in app/routes/index.tsx and you will notice that the changes are reflected in your browser, however, you will not have a connection to the websocket.
Expected Behavior
The websocket should connect on a localhost port and the development changes in the app should also be reflected on the same port, without manually restarting the server.
I just want to run npm run dev and not have to worry about what port I am visiting my app on.
Actual Behavior
The "start:dev" script starts the server with websocket on localhost:3000
The "dev" script starts the development server in watch mode on localhost:3001
When visiting port 3000 you get the websocket, but no reloading of the server when you make changes in your app
When visiting port 3001 the changes in your app are reflected, but the websocket does not connect
Having these two separate servers makes it harder to develop an application.
My current workaround is to close my server and run npm run dev:start whenever I am making changes to the websocket code in server/index.js

The dev script should run remix watch instead so it builds the app without running a server

Is that all? @sergiodxa
I just tested it with the watch command and now everything seems to work fine on localhost:3000

[x] Connects to websocket, pinging works
[x] Changes are reflected on the same port

Unless I'm missing something I think this can be closed when a PR changes it.
I can create it and submit the PR.


LGTM.com - Java - Lost type information leads to incomplete path and false positive

Description of the false-positive
It looks like the query language is connecting sources and sinks through a type checking system that is interpreting methods like Object::toString when called on Object when at runtime that type will be String to be the same as MyCustomType::toString.
URL to the alert on the project page on LGTM.com
https://lgtm.com/projects/g/spring-projects/spring-framework/snapshot/a21fcec7555409e8859aba85fb2fe95d53760f80/files/spring-web/src/main/java/org/springframework/web/context/support/HttpRequestHandlerServlet.java?sort=name&dir=ASC&mode=heatmap#xe877feaabe7d1240:1
Analysis
QL Correctly identifies a source of user-supplied data and correctly tracks it to a place where it is used in the toString method.

Now we have some arbitrary location in the codebase where toString is called on Object.

Now we see where those code paths allow this toString value to be returned up the stack.

Now we get to the sink location. However, we see that StringUtils.arrayToDelimitedString is being passed a String[] not a ServletWebRequest that would mean this was indeed a vulnerability.

TL;DR: Looks like a type confusion issue? Or perhaps there's no logic for detecting the true type that toString will be called on.

Thank you very much for this very detailed report.  The short answer is that we indeed currently are missing the type of logic needed to rule out this FP.
The long answer is that virtual dispatch is a hard problem and that we do a lot of type flow analysis to improve it, and since Object.toString() in particular has a known tendency to induce FPs like this, we even have a special purpose analysis to improve the virtual dispatch of those calls.  On top of this we use a one-level call context to improve dispatch further in the context of data flow, but this is of course insufficient here.  One aspect that makes pruning FPs like this hard, is that we cannot perform the check on the path as we see it, since we're just shown a few representative paths among possibly exponentially many possible paths in the data-flow graph.  All this said, this particular case has given me some ideas on general pruning improvements that we could potentially make in the data-flow library - this is something that I'll likely look further into in the hopefully not too distant future.


Re design features

What does this PR do?

Re-designs features on the landing page and gaming screen

Description of Task to be completed?

Increase transition speed to the animation in how-to-play section
Red-design the invite player box in the gaming screen
Remove max-width from gaming screen

How should this be manually tested?

Run npm start

Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
N/A
Screenshots (if appropriate)
N/A
Questions:
N/A

Coverage remained the same at 100.0% when pulling 539e050bacc72e5eb79aaeed63836a06fc6ade1e on re-design-features into 0462a51e1dbe7222de75618ef04b869403cf86b7 on develop.


New postgres connection is not picking the right database when connecting by "host"

Description
When I add a new connection to a postgres database and I "connect by" host it doesn't pick the database name from the database textbox in the add new connection dialog. The URI section doesn't get grayed out which is weird, I'm unable to edit it but it's not grayed out and in the end the database name that gets picked for the connection comes from the URI instead of the database textbox. What makes this hard to debug is that it still shows the database name from the database textbox in the UI but dbeaver is silently connected to the default "postgres" database.
DBeaver Version
Version <IP_ADDRESS>310221533
Operating System
Fedora Linux 38
Database and driver
PostgreSQL JDBC Driver 42.2.20
PostgreSQL 14.7 on x86_64-pc-linux-musl, compiled by gcc (Alpine 12.2.1_git20220924-r4) 12.2.1 20220924, 64-bit
Steps to reproduce

Set up a pg server with a default database "postgres" and another one that can be named anything, add clearly identifiable objects to the latter (several schemas for example).
Add a new connection
Set "connect by" host
Add the connection parameters to the second DB name in database entry
Verify that dbeaver connects to the default database regardless, in my case the "default" for the driver which seems to be "postgres".

Additional context
No response

@rpgdev Could you provide footage for reproducibility please?

@rpgdev Have you any updates?

It's been a while since no update here. If the issue is still actual please let me know and provide additional information.


My impression is the app is NOT getting any support

My impression is the app is NOT getting any support
i see open issues here going back YEARS
i do not see any developer responses to pretty much ANYTHING.
comments?

The latest version came out a few months ago. The author of the program often replies in issues.
And don't forget that it is open source. No one owes you anything. If you have a problem - the source code is open source. Please solve it and create a pull request.

Noted


dex: fill in position-by-price RPCs

This allows querying what positions are available on the chain by price and pair.

I spotted #2499 while testing this.


Add support for custom font and attributed text.

These changes add support for custom fonts for the title and subtitle, as well as attributed text in the title and subtitle.  If attributed text is specified, the fonts will be ignored.
Examples have been updated for both cases as well.

Hey James, @digitalcatnip
Thank you for using FCAlertView and thanks for contributing! That's a great idea 👍 doing custom attributed text. I'm just going to go over the changes, test them on my end and merge it soon! Cheers!

@digitalcatnip That would be awesome! Yeah I didn't get to fully look into landscape mode. Sure, looking forward to it.

Thanks for the contributions James! I'm going to check out the changes soon 👍

Everything looks good James! It would be awesome if you could also update the README file so people would be able to implement the changes for the custom fonts and attributed titles and subtitles. I'll be able to merge it right after. Cheers 👍

Hi James, would you be able to add the changes to the Readme as well?

@digitalcatnip

Hey Nima!  Yes I will do it this week.
On Fri, Feb 3, 2017 at 4:20 PM, Nima Tahami<EMAIL_ADDRESS>wrote:

Hi James, would you be able to add the changes to the Readme as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nimati/FCAlertView/pull/38#issuecomment-277365103,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOGS41LSvXu4otAZcRFuN3heGPAyS5q6ks5rY5oGgaJpZM4LYlXM
.

--
James McCarthy
Managing Director
Digital Catnip

I re-submitted with the updated Readme.


[cocoyaxi] Fix SHA

Describe the pull request

What does your PR fix?
Fixes ports/cocoyaxi archive file sha512 value

Which triplets are supported/not supported? Have you updated the CI baseline?
All, No

Does your PR follow the maintainer guide?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

The actual problem with this port is the fact the same upstream is already ported under the name co.

@idealvin Could you give some advice?

@neoblackcap , ping for response https://github.com/microsoft/vcpkg/pull/25916#discussion_r942450999

@JonLiu1993 Superseded by #26514


regeneratorRuntime is not defined error

Node version: 0.11.16
MacOS 10.10.5
Upon running npm run debug I encountered this error window:
Uncaught Exception:
ReferenceError: regeneratorRuntime is not defined
    at Window.setTitle (/xxxx/markn/app/scripts/main.js:1000:15)
    at /xxxx/markn/app/scripts/main.js:973:14
    at /xxxx/markn/app/scripts/main.js:1359:10
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:380:3)

Maybe it has something to do with babel config?

Thanks for your reporting :sushi:
I tried to build after cleaning up my environment, the app throws same error.
Now I fixed it.

It's working now. Thanks for fixing.


fix bug varautoencoder_mednist.ipynb

Bug in VAE tutorial, indexing of the data dictionaries train_datadict[:10] and test_datadict[:10] had been left there.
Description
In a previous commit, someone left indexes on the data dictionaries train_datadict[:10] and test_datadict[:10] to debug. I removed them so the code properly runs on the whole dataset.
Checks

modules/engines/unet_training_dict.py
I am currently using the above tutorial for supervised training. Unfortunately, the early stopping handler is triggered right at the beginning. I am receiving the following below feedback and I could not identify where the bug is. Thanks in progress!
2024-02-03 10:44:10,219 ignite.handlers.early_stopping.EarlyStopping INFO: EarlyStopping: Stop training
2024-02-03 10:44:10,220 - INFO - Epoch: 1/100, Iter: 21/3264 -- train_loss: 1.0000

Hi @Sembelawi, the reason is that your loss didn't decrease after the patience. You can either set up larger patience or check your data.
https://github.com/Project-MONAI/MONAI/blob/33afaefff925dce45b8331e8290f234a4d95fd51/monai/handlers/earlystop_handler.py#L37


made commands in readme consistent

Resolves #76
Proposed Changes:

Made commands consistent in readme

DCO1.1 Signed-off-by: Thomas Boop<EMAIL_ADDRESS>

Hi boopt2,
Thanks for submitting this pull request!
I can confirm that the DCO1.1 sign-off has been included. It is okay to process this pull request.
dco-bot


include example with exact match (fuse options)

So far there is no example with some of the fuse options which could be nice as default.
Also all examples lack the sourcecode as text on the website so no easy copying possible so far.

Fuse has it's own properties for matching. They can be loose or strict but usually involves more than one criteria in your settings. Here is my example but I don't know what your definition of exact is. In my scenario any character entered can be found in any index point of the string but does return a match only fitting the characters entered:
      fuseOptions: {         includeScore: true,         includeMatches: true,         threshold: 0.4,         location: 0,         distance: 100,         maxPatternLength: 32,         minMatchCharLength: 1       }


Autosave support

When you open/load a file using the new FS, we should support opt-in autosaving during the editing session.
Upon close, if changes aren't saved, it should nevertheless prompt to save changes (https://github.com/excalidraw/excalidraw/issues/2728) regardless of the opt-in status.

Hey guys, I lost a lot of my work because I opened a new file for just check something. Please implement a opt-in auto save function!

Lost some of my work again, because my local file wasn't autosaved :(
Is the implementation of autosave still on the table?

I have the same requirement. Losting the drawing is annoying.

This was started in PR #3047 but that was years ago and it might need updating.


UCX: add endpoint by sockaddr connection + peer error handling.

Signed-off-by: Peter Rudenko<EMAIL_ADDRESS>Adding spark.rapids.shuffle.ucx.listener.enabled config option (false by default) - to start UcpListener and connect by sockaddr. Also adding spark.rapids.shuffle.ucx.peerErrorHandling.enabled to setup peer (false by default) error handling mode, which allows to better detect peer failure.

@petro-rudenko I thought that UCX 1.10 native libraries had a bug that meant we need to run with sockaddr if and only if the native library is UCX 1.11. Do you know what the 1.10 bug is regarding this?

@abellina No, the bug is in JUCX: https://github.com/openucx/ucx/pull/6649
It can be run with UCX-1.10

It will be fixed in jucx-1.10.1. But in order to use active messages API, and some other stuff - we need to use JUCX-1.11

Mentioned this in one of the comments but please target to branch-0.6, since I don't think we should put this into branch-0.5 right now, because at release time I think we want a specific jar version for JUCX (not SNAPSHOT).

@petro-rudenko we've been trying to not force push while reviews are happening, git gets confused (though it's doing remarkably well here). Just FYI, we can squash commits later.

build

@jlowe @revans2 when you get a chance could I get some :eyes: on this one? Needing a review from a code owner, not sure why exactly.

build


Limit the size of commits when using bbq endpoint.

When transaction content sizes are over 16MB, the client spits up the transactions into multiple commits, each handled separately.

@jgodlew -- question -- This PR does the upload of the split transactions in parallel, but not sure that's the best strategy here given concerns on the endpoint.  Should I do that sequentially?  Seems like that could take a really long time.


Merge LSST parsl work to master

This issue summarises planned merge work to get changes made for the LSST fork of parsl merged into master. My goal is to have PRs submitted for all of this by 30th September 2020.
I expect each bullet point to be approximately one PR.
Resilience

slurm debugging information to aid in understanding #1588
wrappers around every thread and process in monitoring and htex to log when any of those threads encounter an uncaught exception which otherwise often disappears unrecorded
more/rephrased logging around process worker<->interchange heartbeats
better configurability and documentation of htex interchange timing loops which at present generate 300 log messages per second in debug mode

Memoization

memoize FunctionType less strictly

Misc

Human readable text tidying
merge two sections of handle_exec_update which are separate for historical reasons

Monitoring Tidying

rename Hub so that is less ambiguous vs MonitoringHub - PR #1711
remove python2 class idioms - PR #1697
use main parsl logging configuration and style for monitoring processes - PR #1713 + more
refactor TASK_INFO sending code in DFK
remove unused RESOURCE_INFO tag - different queues are used to indicate resource messages, rather than using a tag that in fact isn't even used - PR #1712
rename queues used in monitoring db manager to make their purposes clearer
fix workflow auto-naming vs changed typeguard API

Monitoring Testing

Basic CI testing of parsl-visualize - see #1030 . PR #1700

Monitoring-focused data model work (in DB and DFK)

remove unused States.* states from DFK
remove usused eager failure code from DFK and monitoring
remove workflow duration from monitoring db - this is denormalized vs workflow end minus start
remove task elapsed time from monitoring db - this is denormalised
remove retries_left from DFK - denormalised, the only use can be replaced with fail_count
remove hostname from monitoring status table - the hostname is better associated with a (re)try which will be represented in the new try table
split done state in exec_done and memo_done to address #1485 #1587
separate representation of (re)tries vs tasks (to mirror executor futures vs AppFutures) - this will address the database side of #1494

I think we should get these two pieces into master for 1.0:

slurm debugging information to aid in understanding #1588
better configurability and documentation of htex interchange timing loops which at present generate 300 log messages per second in debug mode

The first of those is merged now, as #1631. The second is not in any mergeable form - it's more a TODO that I'm planning on doing in the next few months.


[SITE] Guest post for fail2ban setup

@chibenwa Thanks a lot for changes. There are still some problems with line breaks and spaces. I think my PDF file was the problem. The files are "log4j2.xml", "james.log" and "james.conf". There are the lines:
code.txt


PI-8393 Changed the styling of lists and links inside of product desc…

…riptions. Increased click area of textlinks in description and loginpage. Fixed linespacing for title in loginpage.

Pull Request Test Coverage Report for Build 532

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.076%

Totals

Change from base Build 531:
0.0%

Covered Lines:
1769

Relevant Lines:
4397

💛  - Coveralls


Update Monoid.swift

Change Product identity from zero to one.

Whoops! 🤭

It happens! 😀
Glad to help!


Implement homepage for nolleguiden

Implement a home page for the nolleguide. Design suggestion from föset can be found here: https://www.figma.com/file/Wf0dojtcdKcToa8WFNpuM6/F-appen?node-id=0%3A1. For this issue, implement empty buttons for the different parts of the guide, content will be added separately.

I will try to fix this asap so we have something to build the rest from.


Add grid line configuration for radial axis

Add the possibility to configurate grid lines for radial axis

See also:
https://www.chartjs.org/docs/4.4.2/axes/radial/linear.html#grid-line-configuration

Released with version 4.17.08


No lock file found

Não tem nenhum lock.yarn no projecto, não consigo instalar as dependências.

Hi @vilarezz 👋
The yarn.lock file is just a dependency cache file.
This file will be generated after installing the package.json dependencies, only it is necessary.
Run locally:
  git clone https://github.com/rocketseat-education/ignite-template-reactjs-conceitos-do-react.git

or
npx create-react-app project-name -e https://github.com/rocketseat-education/ignite-template-reactjs-conceitos-do-react

Go to the project directory
  cd ignite-template-reactjs-conceitos-do-react

Install dependencies
  yarn

Start the server
  yarn dev

Open http://localhost:8080 with your browser to see the result.
Hope this helps


Improve appearance and functionality in Linux (Mono).

This makes a few changes that make this component work properly under Mono on Linux.
(without impacting functionality or behavior under Windows.)

@ShreyasJejurkar Need help maintaining this repo? I use this component in a number of my projects, and would be happy to help.

Hi @dbrant , Thanks for the message. But I guess I am not the maintainer of this repo or the decision maker here to choose a maintainer.
Thanks.

I am not the maintainer of this repo or the decision maker here to choose a maintainer.

Oh sorry, the reason I ask is that you're the only member of the RibbonWinForms project group. Would you be able to add me?


Add support for reloading a pond when modifications are made

The edit command allows interactive edits to a pond but the changes are not reflected in the current shell session if the pond is enabled. This should be a simple case of calling the __pond_load_operation function after edits are made. Awaiting merge of #24 and #27 first.

Closing; the same behaviour can be achieved with pond edit <name>; and pond load <name>.

The edit command is being removed as part of a major refactor to introduce support for autoloading functions, and in preparation for 1.0.0 release. Closing this issue.


0.9.4 breaks some Typescript configurations

Description
Something in the changes in 0.9.4 causes NodeNext module resolution to fail.
https://github.com/drwpow/openapi-typescript/discussions/1634
Reproduction
Node.js side, but build time so no reason browser wouldn't also be affected. I can't get the playground to fail because I don't have full control of tsconfig it seems, but here's what fails in a local build with specific tsconfig values (as described in the discussion):
Playground
Expected result
URLs should be "known" but end up just being ignored/allow any value.
Checklist

[x] I’m willing to open a PR (see CONTRIBUTING.md)

Thanks for the investigation! Looking into it. It could have something to do with a change to openapi-typescript-helpers. I think I’m going to add tests for different moduleResolutions somehow. Could or could not be the problem based on #1634, but couldn’t hurt to eliminate that as a possibility. This seems like a bug, as TSConfig settings shouldn’t affect type safety.

Let me know if I can help - I had a sniff that the helpers might be involved too but I couldn't quite see how. There are a number of typing related changes in there, so it's a bit beyond my limited current understanding of the type infra here.

Is this theoretically fixed? I think it is but I have only seen that the playground errors now (as it should). But before I go through the variety of deps to update would love to know it was intentional :)

Running into exactly the same problem, currently stuck on 0.9.3, all versions afterwards lose all type information.

Whereas it used to work :)

Tried both openapi-typescript-helpers 0.0.7 and 0.0.8, no difference in the generated output together with openapi-typescript 6.7.6
My tsconfig.json has both module and moduleResolution set to NodeNext.

Investigated this a little further and in planning for the upcoming 0.10.0 release (which requires<EMAIL_ADDRESS>which will also get a stable release at the same time) this is hopefully fixed. Or if not fixed, easier to debug.
I believe some of this came from<EMAIL_ADDRESS>generating a lot of partial schemas, which made inference harder. 7.x generating full schemas with never types means openapi-fetch can get simpler inference, and easier cross-comparison since all shapes are fully outlined. Or that’s the hope, at least.

Some of the type inference that I believe led to the regression has been changed in 0.10.0. Are people still seeing the failures with the latest version?

Not resolved here.
Bumped both fetch and generator to latest, regenerated, but no types. Using nodenext.

It seems to be resolved with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Thanks :)

I think I'm still having this problem :-( (with latest versions: "openapi-fetch": "0.12.0", "typescript": "5.6.2")
For a Node project, the only way I get types is with "module": "CommonJS", in tsconfig, setting "module": "NodeNext", breaks it.

Is any reproduction available? I have a project at work that

uses ESNext modules (esm = transpiles into import/export syntax)
tsconfig moduleResolution set to "Bundler"
package.json has type: "module" to indicate that esm should be used (I guess)

The module system in javascript is a bit complicated to say the least (there's some light reading available at https://www.typescriptlang.org/docs/handbook/modules/theory.html#the-module-output-format).


FancyZones uses Layout of main Display on all Monitors.

Microsoft PowerToys version
0..58.0
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
No Matter what Layouts i chose, all my 3 Monitos get the Layout of the primary Display. Worked fine till 0.58.0
✔ Expected Behavior
Keep own Layout for each Display.
❌ Actual Behavior
All Display get Layout of primary Display.
Other Software
No response

Does it happen on the remote desktop?
/needinfo

I haven't testet remote desktop.
It happens in normal use. System is Windows 10 latest patches btw.
My display setup is rather unusual :
left:                    landscape  1920x1080
middle primary landscape   3440x1440
right                  portrait       1440x2560
Switched back to 0.57.2 works fine again.

Can you please send a /bugreport from the 0.58 version to help us investigate it?

I see the same issue when connecting to a remote machine using Remote Desktop Connection when the local machine has two monitors. If it's of any relevance, one of the monitors is in portrait mode rather than landscape. The local machine has no issue setting the correct zones on the same version (0.58.0)
I've attached a bug report.
PowerToysReport_2022-05-19-16-41-07.zip
.

I also have the same issue. 3 monitors, different sizes, one of them portrait and I am using remote desktop; I personally couldn't even get fancy zones to activate when pressing shift, both mouse keys, or using Windows + arrows.
It was also refusing to set my custom layouts on the different monitors. It would set my left monitor to None, and the other two monitors to Priority Grid, and wouldn't persist any changes I would make to each of the monitors; Just bounce back to those settings.
Following @danielsamuels suggestion of selecting "Allow zones to span across monitors" reenabled the ability to use Fancy zones but the interaction was so broken across my 3 screens, it just wasn't a feasible solution to work with.
I've uninstalled 0.58.0 and installed 0.57.2, which has fixed my fancy zones interactions completely. I can share a bug report, but I'd have to reinstall the version, so I guess if you need that let me know.

Sorry for delay.
Still all displays get layout of primary display. Took bug report on normal Desktop. No remote Desktop.
PowerToysReport_2022-05-22-19-36-05.zip

Thanks a lot :)
Got quite used to fancy Zones :)


Capacitor UI not rendering issue loading manifest.json

After latest release, getting the following error on the main screen of the UI
Something went wrong:
Cannot read properties of undefined (reading 'spec')
developer console is showing the following:

Failed to load resource: the server responded with a status of 401 () manifest.json
Manifest: Line: 1, column: 5, Unexpected data after root element.
TypeError: Cannot read properties of undefined (reading 'spec')
at om (index-CPzofljc.js:64:46518)
at Wl (index-CPzofljc.js:38:16998)
at gp (index-CPzofljc.js:40:43963)
at mp (index-CPzofljc.js:40:39727)
at Cg (index-CPzofljc.js:40:39655)
at Fs (index-CPzofljc.js:40:39508)
at tl (index-CPzofljc.js:40:35875)
at fp (index-CPzofljc.js:40:34826)
at E (index-CPzofljc.js:25:1565)
at MessagePort.X (index-CPzofljc.js:25:1928)

After pinning to a specific version, I can confirm that the UI is broken in different ways in versions 0.4.4. and 0.4.5. Version 0.4.3 seems to be functioning correctly.

After further testing, 0.4.3 also has issues: the bottom bar with Sources, Kustomizations and Helm Releases is no longer folding out.

About 0.4.5 and manifest.json:
Something returns 401 on the manifest.json file.
Capacitor never returns 401. Do you access it through a proxy or ingress?
Does it behave the same way when you access it via port-forward? kubectl port-forward svc/capacitor 9000:9000 -n flux-system


add more tslint checks

enforece PascalCased class names
enforece properly checks when using for ... in constructs
interfaces names must begin with capital I
no unused expressions (i.e., expressions that contain side-effects)
enforce type definitions in function parameters, properties for
interface declarations, and member variable declarations

Affected files by the added checks have been updated appropriately.

Based on discussion, this is ready for merge if approved by reviewers.

LGTM.


[ImageResizer]: Narrator should provide min/max value information for 'JPEG quality level' edit field during tab navigation.

Microsoft PowerToys version
0.45.0
Running as admin

[ ] Yes

Area(s) with issue?
Image Resizer
Steps to reproduce
Steps to reproduce
Test Environment:
OS: Windows 11 Version Dev
App version: 0.45.0
App name: PowerToys
Screen Reader: Narrator
Tool: Accessibility Insight for Windows
Repro Steps:

Launch 'PowerToys' application.
In General tab, navigate to 'Image Resizer’ button and activate.
Navigate to ‘Image Quality’ label under Encoding Section.
Observe the issue.

User Impact: -> Priority 2
Screen Reader user are impacted here as the label is not properly read by Narrator.
Guidelines Reference:
https://www.w3.org/TR/WCAG21/#labels-or-instructions
Attachments:
https://user-images.githubusercontent.com/87321414/134339368-7d2c2a75-b203-4ea6-a3cd-7b0fc56f18b7.mp4

✔ Expected Behavior
The Narrator should announce the Maximum and Minimum Image quality value on tab Navigation.
❌ Actual Behavior
The Narrator is not announcing the Maximum and Minimum value for Image quality Edit field on Tab Navigation.
Other Software
No response

@niels9001 i thought this was supposed to be a slider

NumberBox will be replaced by a slider, therefore closing this issue


Update mistralai-chat.adoc

In the manual configuration section of MistralAI SpringAI documentation is used a withMaxToken method that doesn't exist in the current version of the API.
Replaced with correct withMaxTokens method name.

Thanks @rubin0


Code

Hi：
I tried to run your code, but I didn't run through
TypeError: forward() missing 4 required positional arguments: 'future_data', 'batch_seen', 'epoch', and 'train'
Thanks so much for your reply.

Thanks for your comments.
The bug has been fixed in the commit fix: 🐛 remove unused parameters in STID_arch.py..


Storing OrganizationLinkToHashtag; fails on iteration

Using the frequency of hashtags as an indicator of an issue to be recommended to the organization (still needs to be matched with an actual WeVote issue to be followed). Currently only a single OrganizationLinkToHashtag object is stored. A duplicate key value violates unique constraint is thrown for further iterations, despite setting=False for fields and explicitly adding id = models.AutoField(primary_key=True.

👍

Thanks, Dale. Any thoughts on why the primary key isn't auto-incrementing in OrganizationLinkToHashtag() model?


Creating a new Bot on non-Windows platforms

As .NET Core is a cross-platform framework, many developers might not have Visual Studio 2017 installed or are not on Windows. Please provide steps to create a new bot from scratch with Visual Studio Code or the command line.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f1718fa-0745-3fee-6ef5-18e36b61fabf
Version Independent ID: fd9ef97f-4540-e624-d459-c076e94a50ad
Content: Create a bot with the Bot Builder SDK for .NET - Bot Service
Content Source: articles/dotnet/bot-builder-dotnet-sdk-quickstart.md
Product: bot-framework
GitHub Login: @Kamrani
Microsoft Alias: kamrani

Would definitely be great to be able to generate these projects on Linux / macOS via the CLI.

I think a Yeoman template, how it is done with JavaScript Bots also for C# would be a great first start for cross-platform creation of a Chat Bot.


Fake Googlebot plugin

Motivation
As we all know, many bots are fakeing User-Agent header to look like a Googlebot. In lots of cases, users are trusting this header and, for example, are not applying so high restrictions for such requests. Anyway, behavior where anyone is fakeing anything to get something more is considered bad (or should be). This plugin is able to detect and block such requests.
Proposed solution
As Google is publishing all it's IP ranges, we are able to use this information to detect fake Googlebots (see https://www.gstatic.com/ipranges/goog.json ). Plugin consists of these parts:

blocking rule (using @ipMatchFromFile)
python script for updating local database of Google IP ranges

While running a prototype of this plugin for about a week, almost 2000 fake Googlebot requests were detected with zero false positives (list of IPs: https://pastebin.com/saGWuq5E ).
Plugin registry PR: https://github.com/coreruleset/plugin-registry/pull/4.

Decision: the approach of #2228 is more robust, it won't need Google IP address updates and could also cover other bots. So closing this one for now and continue in #2228.


Fix compatibility with Pillow 10.1.0+

https://pillow.readthedocs.io/en/stable/releasenotes/10.1.0.html#setting-image-mode

Fixes https://github.com/uploadcare/heif-image-plugin/issues/22

It  breaks compatibility with other Pillow versions

oh no, in that case need to put a guard like hasattr(self, '_mode') or explicit pillow version check, as it is a break change on the pillow side.

Added the hasattr check to see if we're dealing with Pillow > 10.1 or not.
I thought about explicit PIL.version check but it seems that I would need to include additional packaging library to make a sensible version check to decide which code to run.

Have a look at https://github.com/imageio/imageio/pull/1045/files, perhaps that is a cleaner way to achieve setting the mode?
The pillow docs recommends using Image.convert(new_mode) to change the mode for versions > 10.1.
Pillow version be obtained with:
from PIL import __version__ as pil_version, so no additional dependency required.

I don't see a way to run workflows in current PR, so I created #24. All tests passed

I've released https://pypi.org/project/heif-image-plugin/

Awesome. And thanks for plugin 👍


Update memcache exception reason

Got this exception.
Caused by: colossus.protocols.memcache.MemcacheInvalidCharacterException: Key contains invalid character at position 46.

Would be nice to know what the key looks like.

:+1:


chore(app-astro): use VisualEditing component from @sanity/astro

The build fails with this error on Vercel, which is quite strange because it works locally when I test and the prop isn't required.

The build fails with this error on Vercel, which is quite strange because it works locally when I test and the prop isn't required.

I was able to reproduce this locally by recreating what is happening on Vercel:

cd apps/astro
pnpm install
turbo run build

Now, the @sanity/visual-editing dependency can't be resolved from inside @sanity/astro which caused the prop type error. I've mitigated this by manually specifying the @sanity/visual-editing dependency in the app. I suspect this error won't happen in user land, and it has more to do with this monorepo setup. What do you think, @stipsan ?

The build fails with this error on Vercel, which is quite strange because it works locally when I test and the prop isn't required.

I was able to reproduce this locally by recreating what is happening on Vercel:

cd apps/astro
pnpm install
turbo run build

Now, the @sanity/visual-editing dependency can't be resolved from inside @sanity/astro which caused the prop type error. I've mitigated this by manually specifying the @sanity/visual-editing dependency in the app. I suspect this error won't happen in user land, and it has more to do with this monorepo setup. What do you think, @stipsan ?

Yep this is similar to what we do in the other apps that use wrappers. For example both dev/next-no-cache and dev/next-server-only uses import {VisualEditing} from 'next-sanity' and have to use this in their package json as well:
"@sanity/visual-editing": "workspace:*"

And just like with next-sanity userland shouldn't need to do this :)

The build fails with this error on Vercel, which is quite strange because it works locally when I test and the prop isn't required.

I was able to reproduce this locally by recreating what is happening on Vercel:

cd apps/astro
pnpm install
turbo run build

Now, the @sanity/visual-editing dependency can't be resolved from inside @sanity/astro which caused the prop type error. I've mitigated this by manually specifying the @sanity/visual-editing dependency in the app. I suspect this error won't happen in user land, and it has more to do with this monorepo setup. What do you think, @stipsan ?

Yep this is similar to what we do in the other apps that use wrappers. For example both dev/next-no-cache and dev/next-server-only uses import {VisualEditing} from 'next-sanity' and have to use this in their package json as well:
"@sanity/visual-editing": "workspace:*"

And just like with next-sanity userland shouldn't need to do this :)

Fantastic! Thanks for reassuring me!


feat: 支持对 geometry 下的 elements zIndex 进行降序

Checklist

[ ] npm test passes
[ ] tests and/or benchmarks are included
[ ] commit message follows commit guidelines

Description of change

feat: geometry 增加 sortZIndex 配置项，允许配置 geometry 下的 elements 的展示(zIndex)排序规则

@hustcc @zqlu 你们看下这个配置项合理不，这是当前看到的最方便支持的方法。
但是存在一些 bug，比如交互 reset 后，zIndex 就丢失了，被激活又失去激活态的 element shape 会重置到最底层

@hustcc @zqlu 你们看下这个配置项合理不，这是当前看到的最方便支持的方法。
但是存在一些 bug，比如交互 reset 后，zIndex 就丢失了，被激活又失去激活态的 element shape 会重置到最底层

Pull Request Test Coverage Report for Build 462491140

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
23 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 93.407%

Files with Coverage Reduction
New Missed Lines
%

src/chart/controller/gesture.ts
7
82.14%

src/geometry/base.ts
16
94.35%

Totals

Change from base Build 462379674:
-0.09%

Covered Lines:
10698

Relevant Lines:
11106

💛  - Coveralls

Pull Request Test Coverage Report for Build 462491140

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
23 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 93.407%

Files with Coverage Reduction
New Missed Lines
%

src/chart/controller/gesture.ts
7
82.14%

src/geometry/base.ts
16
94.35%

Totals

Change from base Build 462379674:
-0.09%

Covered Lines:
10698

Relevant Lines:
11106

💛  - Coveralls


Team Inception Sessions Preparation

There will be two team-specific Inception sessions on Sep. 16 (Technical & Program Operations Teams) and Sep. 21 (Program Development Team). This ticket outlines the work to be done in preparation for those sessions.
Acceptance Criteria:

[ ] Understand what information we still need to gather for Inception phase
[ ] Establish desired outcomes of team session
[ ] Establish vehicle/medium of sessions (e.g. Miro workshop, conversation, etc.)
[ ] Write questions to ask in sessions
[ ] Share questions & session goals with teams in advance

Day-Of

[ ] Send reminder email


Renaming NH to ZKV

This is a first attempt at updating all the legacy New Horizen (and NH acronyms) references to zkVerify (ZKV).
Notice: the spec name of the runtime has not been changed, to preserve compatibility with the live testnet.

Not directly related to this PR, but since we are doing some renaming/cleaning, I stumbled upon verifiers/groth16/src/resources.rs header and I think we want to change // Copyright 2024, The Horizen Foundation to // Copyright 2024, Horizen Labs, Inc..

I am quite sure in .github/workflows/CI-rustdoc.yml we want to modify this url=nh_node/index.html to url=zkv_node/index.html, but please double check.


Adds support for specifying an IP to bind http-port

This PR allows Fortio to provide a flag for bindinghttp-port to a specific IP address. http-port type was changed from an int to a string.
Fixes https://github.com/istio/fortio/issues/91 and https://github.com/istio/fortio/issues/110

$ fortio server
Https redirector running on :8081
UI starting - visit:
http://localhost:8080/fortio/
Fortio 0.6.8 grpc ping server listening on port 8079
10:56:03 I uihandler.go:95> Guessing resources directory from runtime source location: true - /Users/ldemailly/go/src/istio.io/fortio/ui/uihandler.go
Fortio 0.6.8 echo server listening on port :8080

can you also change fgrpc to be consistent in showing :8079 instead of 8079
also for #110 I think maybe the line:
UI starting - visit:
http://localhost:8080/fortio/

should be (only when the addr: isn't specified)
UI starting - visit:
http://localhost:8080/fortio/   (or any host/ip reaching this machine)

(or get the actual bound addr)
if you prefer I can do that in a followup pr

tested with
fortio server --http-port <IP_ADDRESS>:8045
fortio server --http-port "[::1]:8045"
etc...

all work fine - nice !

@ldemailly I really appreciate all your thorough reviews. I also successfully tested the PR and provided my output in this gist.

@ldemailly I'll start working on fgrpc and https://github.com/istio/fortio/issues/110. My group is tracking the progress of this PR, so it's helpful to address this additional work in a separate PR.

Ok, thanks ! merged ! thanks for the contribution !


MOSFET N pins numbering

I am a bit confused about pins numbering for MOSFET N in your file:
kicad-library/libs/MOSFET-N.lib
From various datasheets I have worked with, I have always found that:
Gate is pin 1
Drain is pin 2
Source is pin 3
It looks like on your MOSFET-N you use the opposite, i.e. Drain is pin 3 and Source is pin 2. Or am I wrong? Can this be non standart and association (2-3) to (Drain-Source) be dependant on each specific component?

(for example, do  you agree that pins 2 and 3 are Drain and Source in this datasheet:
https://cdn-shop.adafruit.com/datasheets/irlb8721pbf.pdf
but the opposite Source and Drain on your component?)

Unfortunately MOSFET pin numbering is not standard.
Here are a couple examples.
https://cdn.sparkfun.com/assets/learn_tutorials/4/2/3/5lp01sp-legend.png
https://is.alicdn.com/img/pb/192/774/382/382774192_169.jpg
That's why I created MOSFET-N-123.lib and MOSFET-N-134.lib to help out with this.
Moving forward with this library I might be leaning more towards one part, one lib, one mod style similar to what Digikey has done: https://www.digikey.com/en/news/press-releases/2017/aug/digi-key-adds-kicad-pcb-model-download  Then there is no confusion or mistakes with pin numbering like this.

Super, thank you for confirmation. Funny, I had only met MOSFET with the pins config I refer to. Still a lot to learn...


Update source-build for 2.0.x release

@crummel commented on Thu Aug 24 2017

[ ] Fix existing build issues
[ ] Update CoreCLR, CoreFX, core-setup, CLI submodules
[ ] Update modules these depend on

Currently blocked on versioning


Scrollbar does not appear when container content changes

Hi there, please see reproduced here: http://jsfiddle.net/nmndpzku/

As in the old versions, the update call doesn't refill the scrollbars that have been removed by .html(). Please use the latest version of the plugin.
Thanks,

Ah it was the latest version on cdnjs.

I've just updated the fiddle with the latest version, and as you can see, it works well.
http://jsfiddle.net/45ofk0zw/
Sadly, you can't use the source files uploaded on the fiddle, because they're just hosted in my mini server.
Sadly, perfect-scrollbar in cdnjs is not maintained by me. I guess somebody made it. Anyway I'll update the cdn for you today.
Thanks.

Have a great day! Thanks for the quick response!

PR is uploaded here: https://github.com/cdnjs/cdnjs/pull/4657
Please wait till it's updated, hopefully soon :smile: