Increase test coverage, verify minimum target level

Significant increase in test coverage, although further work needed. Will close the associated PR now, further test coverage can be worked on at a future date in another issue.


Run code directly from vim

Added new feature to run currently open code file.
Is able to execute code written C, C++, Java, Python, Go, Bash and HTML.

Could be useful, thanks, @pratyaypande 👍


Look into requirements.txt

Someone mentioned this but I'm not sure why

[ ] #72
[ ] some-natalie/kubernoodles#12
[ ] freeform text


[bug] Berkeley Function-Calling Leaderboard:

Describe the bug
I think there is a problem with the golden number of parallel function calls.
For example, on line 27 of data/gorilla_openfunctions_v1_test_parallel_function.json，
{"question": "Find details of lawsuits with case numbers '67813', '71249' filed in the New York District court for type 'Civil' and 'Criminal' cases.", "function": {"name": "court_case.find", "description": "Locate details of court cases based on specific parameters like case number and case type.", "parameters": {"type": "dict", "properties": {"location": {"type": "string", "description": "The city and court where the lawsuit is filed."}, "case_number": {"type": "array", "items": {"type": "string"}, "description": "The unique case numbers of the lawsuits."}, "case_type": {"type": "string", "enum": ["Civil", "Criminal"], "description": "Type of the court case.", "default": "Civil"}}, "required": ["location", "case_number"]}}}

The golden answer called the function 4 times.
{"court_case.find_1": {"location": ["New York District", "NY District", "New York", "New York, NY", "NY"], "case_number": ["67813"], "case_type": ["Civil", ""]}, "court_case.find_2": {"location": ["New York District", "NY District", "New York", "New York, NY", "NY"], "case_number": ["71249"], "case_type": ["Criminal"]},"court_case.find_3": {"location": ["New York District", "NY District", "New York", "New York, NY", "NY"], "case_number": ["67813"], "case_type": ["Criminal"]}, "court_case.find_4": {"location": ["New York District", "NY District", "New York", "New York, NY", "NY"], "case_number": ["71249"], "case_type": ["Civil", ""]}}

Since the case_number parameter can be array, maybe 2 times is okay for this situation. My result is as follows.
{"idx": 26, "result": [{"court_case_find": "{\"location\": \"New York District\", \"case_number\": [\"67813\", \"71249\"], \"case_type\": \"Civil\"}"}, {"court_case_find": "{\"location\": \"New York District\", \"case_number\": [\"67813\", \"71249\"], \"case_type\": \"Criminal\"}"}], "input_token_count": 518, "output_token_count": 98, "latency": 14.348066568374634}

The number of function calls is not unique because the argument is a list. This situation is common in parallel function calls.

Hi @lucenzhong ,
Thanks for pointing this out. I agree that since the case_number parameter is an array, you could combine two function calls into one, and thus the possible answer should be more inclusive.
We plan to address this issue in the next release by updating the possible answers. You are also welcome to make a PR if you would like to contribute :)

@HuanzhiMao
Hello, may I ask when the next release will be? The current version appears to have several issues to be fixed.

Later this week or early next week! Sorry for the long wait.


Vagrant: make amount of CPUs and memory configurable from the environment

It really helps, if you have more powerful machine ;)

Note, in the past, when I have increased the number of CPUs the VM stalled.


gcc9 complaining about comparison between pointer and zero character constant

Hi @cavaliercoder,
gcc[1] reports this warning,
libzbxsystemd.c: In function ‘SYSTEMD_UNIT_DISCOVERY’:
libzbxsystemd.c:214:35: warning: comparison between pointer and zero character constant [-Wpointer-compare]
  214 |         if(NULL != filter || '\0' != filter)
      |                                   ^~
libzbxsystemd.c:214:38: note: did you mean to dereference the pointer?
  214 |         if(NULL != filter || '\0' != filter)
      |                                      ^

Why do you need to check that in parallel to the correspondent NULL?
[1] gcc (GCC) 9.3.1 20200317 (Red Hat 9.3.1-1)

gcc[1] reports this warning

...and rightly so!

Why do you need to check that in parallel to the correspondent NULL?

It should have been '\0' != *filter, which would be a check for empty string. Strings is C are null-terminated, i.e. null character '\0' marks the end of the string. *string is the same as string[0]. If the first character of the string is null-character, then the string is empty.
@mjtrangoni, would you like to create a pull request? I'm sure @cavaliercoder or @jangaraj will be happy to merge it.

@i-ky thanks for the explanation. I'll submit a PR tomorrow.


[SPARK-32761][SQL] Allow aggregating multiple foldable distinct expressions

What changes were proposed in this pull request?
For queries with multiple foldable distinct columns, since they will be eliminated during
execution, it's not mandatory to let RewriteDistinctAggregates handle this case. And
in the current code, RewriteDistinctAggregates dose miss some "aggregating with
multiple foldable distinct expressions" cases.
For example: select count(distinct 2), count(distinct 2, 3) will be missed.
But in the planner, this will trigger an error that "multiple distinct expressions" are not allowed.
As the foldable distinct columns can be eliminated finally, we can allow this in the aggregation
planner check.
Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
No
How was this patch tested?
added test case

Can one of the admins verify this patch?

Can one of the admins verify this patch?

add to whitelist

Test build #128133 has started for PR 29607 at commit 8ab8955.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/32758/
Test PASSed.

Test build #128133 has finished for PR 29607 at commit 8ab8955.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128133/
Test PASSed.

thanks, merging to master/3.0!


Middleware returns, flowing downstream promises up to root dispatch

When combining redux-loop with other middleware, I've found it useful to put it after my middleware. That way, all new actions generated by middleware will be processed by redux-loop. Then, redux-loop returns a promise from its overridden dispatch() which lets me know when the current action and any child Effect is done.
And so, any middleware which doesn't return the result of its next() call breaks that chain back up to the root dispatch() call.
This PR introduces that needed return statement in the router middleware.

Current coverage is 98.46% (diff: 100%)

Merging #104 into master will not change coverage

@@             master       #104   diff @@
==========================================
  Files            15         15
  Lines           195        195
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            192        192
  Misses            3          3
  Partials          0          0

Powered by Codecov. Last update 1b609b1...968e47a


Please add an info that Brick do not work from file:///

Adding Brick for an unexperienced web dev shouldn't require learning web components.

New Google's Polymer background library (webcomponentsjs instead of platform.js) can be executed from file:///


RST-6219 feature tests v2

Jira link (if applicable)
https://tools.hmcts.net/jira/browse/RST-6219

This is old now


Not working on sandbox

The version of the API in the reference app (master) does not seem to work with the version of the API readily available on sandbox. Running this app against api-sandbox results in an error.

Addressed by reverting using #8. Please confirm and close the issue.

LGTM


Instantiate QApplication once for all (doc)tests

Introduce fixture to provide QApplication instance to doctests, that is only created once throughout the whole test session. This is because instantiating QApplication multiple times can lead to crashes (on Linux at least).

@aknuds1 you need to import QApplication from quamash or else it fails with PyQt4 and PySide.

Ah darn it, just too banal for me to notice. Thanks.

I merged this all into 5c93eb66a97b6deb3709fd3fca6861b60042ddfb


Builder Constructor Access Level

The documentation from the @Builder annotation is inaccurate, it generates a package private constructor instead of a private constructor.

The documentation at https://projectlombok.org/features/Builder.html says PACKAGE access level which is accurate.
Adding @AllArgsConstructor(access = AccessLevel.PRIVATE) seems to do the trick.  Is there a reason why PACKAGE is the default instead of PRIVATE?

Why access level is package private? It should be public to can annotate subclass from another package

As of 1.16.18 there is a difference between the Javadoc for Builder and the generated constructor. The Javadoc at https://github.com/rzwitserloot/lombok/blob/master/src/core/lombok/Builder.java#L36 says 'private', the generated constructor is package-private.

It should to be a public level, otherwise it is impossible to put the
annotation in a subclass who is in other package
2017-07-05 18:44 GMT+07:00 mmoehring<EMAIL_ADDRESS>
As of 1.16.18 there is a difference between the Javadoc for Builder and
the generated constructor. The Javadoc at https://github.com/
rzwitserloot/lombok/blob/master/src/core/lombok/Builder.java#L36 says
'private', the generated constructor is package-private.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/rzwitserloot/lombok/issues/1182#issuecomment-313079730,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APqShTSAkOosO-lsui_Ts2w5BBCafaWhks5sK3cygaJpZM4Jys1L
.


Use "<? super T>" for all arguments of anyOf

fixes #256

Thanks @phoenix384, I was able to reproduce your issue after a bit of effort. Because Hamcrest itself is compiled with sourceCompatibility = JavaVersion.VERSION_1_7, the problem doesn't appear in that project. However, if I set up a new project with a Hamcrest as a dependency, and use sourceCompatibility = JavaVersion.VERSION_1_8, JDK 1.11 couldn't compile.


[HIGH] We need ISQQuantities

Being implemented in emmo-repo/EMMO#210.

In principle, everything can be implemented into EMMO beta4. This will hopefully happen in the next couple of days.


UP-4775 : Use alternativeMaximizedLink into portlet-titlebar - rel-4-3-patches

Replace the portlet maximized url by alternativeMaximizedLink when setted to open directly in a new browser tab.

Coverage decreased (-0.004%) to 22.867% when pulling 78260e217f752b5f779f6d394b999a3dda645b7b on GIP-RECIA:UP-4775_AlternativeMaximizedLink_into_Portlet-titlebar into e6b4afdd506529d90275b783e859c6be70f204ab on Jasig:rel-4-3-patches.

Coverage decreased (-0.004%) to 22.867% when pulling d49a2993bf2eb7d9f40b5feace22edbeb3123454 on GIP-RECIA:UP-4775_AlternativeMaximizedLink_into_Portlet-titlebar into e6b4afdd506529d90275b783e859c6be70f204ab on Jasig:rel-4-3-patches.

@ChristianMurphy : I rewrote my PR after considering yoursuggestion ;)
It's due to my merge tool it's configured to avoid to show change on spaces so...

Coverage decreased (-0.004%) to 22.867% when pulling d49a2993bf2eb7d9f40b5feace22edbeb3123454 on GIP-RECIA:UP-4775_AlternativeMaximizedLink_into_Portlet-titlebar into e6b4afdd506529d90275b783e859c6be70f204ab on Jasig:rel-4-3-patches.


refactor(all): move e2e tests to example/test_driver and update docs

Description
Moved all e2e tests to the example/test_driver folder.
Related Issues

https://github.com/fluttercommunity/plus_plugins/issues/28

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[x] No, this is not a breaking change.

Move sensors_plus/test/sensors_e2e.dart to sensors_plus/example/test_driver/, and
remove connectivity_plus/test/connectivity_e2e.dart (looks like duplicate of the one in test_driver)?

P.S. Are these missing how does one run flutter drive for battery & share?

battery_plus/example/test_driver/battery_e2e_test.dart
share_plus/example/test_driver/share_e2e.dart

Thanks for checking those!

sensors -> fixed
connectivity -> removed duplicated
share -> looks like the original share_test.dart was the e2e, so renamed and moved.
battery -> looks like the battery_e2e_test.dart was originally missing

I added the missing batter_e2e_test.dart and I was able to run and pass the test with flutter drive --target=./test_driver/battery_e2e.dart


Super Smash Bros. [AXF#01]

https://abload.de/img/nvidiaphp4c.jpg
This happens when both graphic packs are activated.

AFAIK Cemu seems to have issues when having the workaround pack and the actual graphic packs enabled at the same time. If the workaround doesn't screw over AMD, then I'll implement the workaround into the main packs themselves.

Here's a test pack, I'm assuming you're using 4K.
[Definition]
titleIds =<PHONE_NUMBER>110E00,0005000010145000,0005000010144F00,ffffffffd72e798a
name = "Super Smash Bros. - 2160p (4K)"

[TextureRedefine] # tv
width = 1920
height = 1080
formatsExcluded = 0x219
overwriteWidth = 3840
overwriteHeight = 2160

[TextureRedefine] # NVIDIA Fix
width = 1920
height = 1080
formats = 0x219
overwriteFormat = 0x820
overwriteWidth = 3840
overwriteHeight = 2160

[TextureRedefine] # half-res
width = 960
height = 540
overwriteWidth = 1920
overwriteHeight = 1080

[TextureRedefine] # q-res
width = 480
height = 270
overwriteWidth = 962
overwriteHeight = 542

[TextureRedefine] # o-res
width = 240
height = 135
overwriteWidth = 481
overwriteHeight = 271

[TextureRedefine] # half-res 2
width = 120
height = 67
overwriteWidth = 240
overwriteHeight = 134

[TextureRedefine] # q-res 2
width = 60
height = 33
overwriteWidth = 120
overwriteHeight = 66

[TextureRedefine] # o-res 2
width = 30
height = 16
overwriteWidth = 60
overwriteHeight = 32

[TextureRedefine] # o-res 3
width = 8
height = 1
overwriteWidth = 16
overwriteHeight = 2

[TextureRedefine] # 2nd
width = 820
height = 410
overwriteWidth = 1640
overwriteHeight = 820

[TextureRedefine] # 3rd
width = 730
height = 365
overwriteWidth = 1460
overwriteHeight = 730

[TextureRedefine] # 4th
width = 420
height = 210
overwriteWidth = 840
overwriteHeight = 420

It works

https://abload.de/img/fixedxcqkc.jpg

I've tested the NVIDIA workaround on AMD, no issues to be found. I think it's safe to push the fix to the main packs.

Fixed as of c9bf586

Nevermind apparently still broken on 1.7.5, image is from a friend

This might be fixed with 1.7.6's proper gl_FragCoord scaling. I will check to make sure that this is the case. If it is fixed, I will close this issue when 1.7.6 releases publicly.

Apparently this issue didn't happen for some in 1.7.5, but I'm getting the same friend to test in 1.8.0 to see if his issue is fixed. If so, I'll be closing this


Outdated example at https://ddev.com/ddev-local/customizing-ddev-local-images-with-a-custom-dockerfile/

Expected Behavior
Docs / blogs have to be updated properly.
Actual Behavior
The example to add files (https://ddev.com/ddev-local/customizing-ddev-local-images-with-a-custom-dockerfile/) is outdated. In the meantime, context was added to the docker-compose.yaml pointing to the root so the ADD directive is relative to the project root and not longer relative to the Dockerfile. Therefor .ddev/web-build/ must be prepended.
Steps To Reproduce
No response
Anything else?
No response

Thanks for catching that!

Oh, I see, didn't realize this was ddev.com. @mattstein I imagine this is in your court at this moment? Or it's possible that the ddev.com article should just point to docs.

Only sort of @rfay: the article exists in that form with minor changes to its formatting. If it’s harmful to keep that old post around, I can delete it and redirect to https://ddev.readthedocs.io/en/latest/users/extend/customizing-images/.
That also begs the question of what older posts should be pruned, vs. preserved for historical value. I’m not in the best position to decide, so I’ve only migrated posts unless we’ve explicitly agreed to remove them.

If you think there's value in that article (different approach) then we can keep it. Otherwise, we should drop it. I also replied in https://github.com/orgs/ddev/projects/3?pane=issue&itemId=19458667

@gilbertsoft Am I correct if I think it’s this specific line that needs updating?
ADD mailhog.conf /etc/supervisor/conf.d

And that it should be:
ADD .ddev/web-build/mailhog.conf /etc/supervisor/conf.d

?

Yes, that is correct @mattstein - And I think that's likely one of the articles that got moved into the docs...
And the same error exists in https://ddev.readthedocs.io/en/latest/users/extend/customization-extendibility/#explicit-supervisord-configuration-for-additional-daemons
I expected to see the same error on https://ddev.readthedocs.io/en/latest/users/extend/customizing-images/#extending-configyaml-with-custom-configyaml-files but it must have gotten migrated out of there maybe into the above error.

Sorry for the wait on this!
I’ve submitted a PR for the docs to fix the example @rfay pointed out, updated the referenced WordPress post, and updated that same post on the in-development site and used the built-in update note to call out the change:

Let me know if I missed anything, otherwise this is safe to close when the docs PR is merged.

I believe this was fixed in @mattstein 's PR and the new ddev.com.

Yep! The PR was merged and the updated post is live on the new site.


Test GH Discussions for real-time convos with contributors?

Haven't used GH Discussions yet but wondering if we should try it for real-time comms that don't yet rise to Issue status.  @palewire @chriszs @stucka Any thoughts on how livable/user-friendly Discussions are? Open to other options such as Gitter, Slack channel on NewsNerdery, or just sticking with Issues for now. Thoughts?

The React project moved some of their communication over to discussions. I don't have strong feelings.


None of the examples run?

I have my project in typescript, don't think it makes much of a difference. I installed the latest, copied and pasted the examples and ran, got a zero byte PDF.
Running Windows 10 on Node v12.18.3

Nice idea. Promise is very useful, I will create a async version.
Thank you for the suggestion.

Hi, @grbspltt
pdfkit-table is a Promise now(); Thanks so much!
https://github.com/natancabral/pdfkit-table#0168

@natancabral Nice! Thanks a ton.


Simplify Ticket Raising Form

What would you like to change?
The SlackBot ticket raising form asks the user for all the information needed in the ticket in a single modal. This can not only be overwhenming but is also very inconvenient as it makes the rest of the user's slack inaccessible as if they at any point close the modal, they lose all the information they entered into it, forcing them to re-enter everything.
Rework the ticket raising form to include several smaller modals that can help atomise the information. Additionally, include edit buttons on the messages sent from SackBot so the user can ammend the data they've already entered. The information to raise the ticket will then be collected from the messages SlackBot sent the user and passed into the regular ticket raising routine like normal.

I think resolved enough now, a few fields have been removed and AI is now auto suggesting answers and there's some pagination


update gmp-mpfr-sys to fix non gcc builds

@PaddiM8 would be great if this could become a release, to make the fix in nixpkgs much easier.

Looks good, neat.


TinaCMS - 🔍 Parse and Save Mermaid Diagrams

CC @wicksipedia @adamcogan
This continues from the work completed in https://github.com/tinacms/tinacms/issues/4733
Description:
Implement custom parsing and saving logic for Mermaid diagrams in TinaCMS. Since TinaCMS uses remark for content processing, develop a solution that ensures Mermaid syntax is parsed, saved, and rendered correctly. This task is complex as it requires modifications to the core of TinaCMS to handle various diagram types seamlessly. Investigate the potential use of rehype-mermaid for improved handling.
Acceptance Criteria:

[x] Mermaid diagrams should be correctly parsed and saved in markdown format.
[ ] Implement Mermaid into TinMarkdown component
[x] Diagrams should re-render accurately when changed/reloaded in the editor.

Update:
Saving and editing mermaid diagrams is working. There is some remaining work left on this PBI to do with intergrating it with TinaMarkdown as well as fixing a race condition bug with the code_block element. As the mermaid format is a code block on parsing back from the document the code block element is being called before the mermaid element.

Figure: 2 mermaid diagrams added to Plate.

[ ] Write Documentation
[ ] Done Vide


Configure both element and selector together ...

Replace:
var join = dataJoin()
            .element('li')
            .selector('li');

with
var join = dataJoin('li')

And replace
var join = dataJoin()
            .element('li')
            .selector('li.animal')
            .attr('class', 'animal');

With:
var join = dataJoin('li.animal');

This would simplify the vast majority of uses in d3fc.
We've got a couple of options here:

The dataJoin('li.animal') form could return the regular data-join component, which would mean further calls to element and selector could bemused to create a 'broken' join.
Use specific functions, classedJoin('li', 'animal') and elementJoin('li'), which do not expose any of the dataJoin properties (other than key)

I've noticed a pattern in the new d3-force forces whereby something similar to 1 is used. I think I'd prefer to see a mix of the two ideas though -
dataJoin('li', 'animal') // returns a dataJoin with element, selector and attr pre-configured.

Fixed by #6


allow threshold and name filters in forge snapshot

Component
Forge
Describe the feature you would like
forge snapshot can be a bit pedantic:
https://twitter.com/devtooligan/status/1551965598149513216

there was some discussion re merging --gas-report and snapshot https://github.com/foundry-rs/foundry/issues/2065#issuecomment-1163136664 but given that both serve different purposes it wasn't merged yet.
forge snapshot has been neglected a bit #2056
adding thresholds and name filters would be a quick fix though
this also should be configurable via config, see #2509
Additional context
No response

closed by #3102


Added Commitlint

This PR is related to and would close #123. It adds commitlint to standardize commit messages and standard-version to create an automatic CHANGELOG.md when running npm run release.
I use these tools in all of my projects and they help me better track my progress, let me know if you think this is a valuable addition! If it's not, there's no problem, we can just forget it :)

Thanks for submitting this @LuckeeDev. My main concern over this is making it more difficult for people to contribute without adding a lot of value. If we were developing tools for other devs I could see the value more but I don't think the average user will read a changelog.

@silent1mezzo you're totally right, we can close it and not merge it then. :)


FCFB-16 Include clock status in all embeds

More a suggestion but only some embeds are including the clock status
Play result this does have the clock status
Next offensive play request this does not

Updated writeup in DB to include clock status


Add error detail popup

Adds a popup with error, error details and correlation ID.  Not sure of the best way to do the CSS stuff, so let me know.

Updated image after switching to the patternfly table component..


Bugs/fixes 01

minor bug fixes, library updates, and improvements

minor bug fixes, library updates, and improvements


Subsampling in downstream analysis

Add subsampling for summary.single in alpha diversity analysis.

Closed by #126


Android debug sync

Description

This pull request fixes the issue described here: #1788

In this pull request, I have enabled usage of debug-synchronization for Android.
The main issue why this was not working - in spite of most of the groundwork already laid out, was that on the Detox native end, there was only one thread ever available for handling server requests. Since requests typically require responses, they are handled synchronously, effectively forcing a multi-thread environment in order to allow things to run in parallel (e.g. invocation and status-query).
Before this change, the status query was always ever handled only after in-flight invocations have completed, and thus executed when the environment is already idle. On the node side, you would only see output saying the app is currently idle - never busy.

For features/enhancements:

[x] I have added/updated the relevant references in the documentation files.

For API changes:

[x] I have made the necessary changes in the types index file.

Overall, looks stunning! 🤗  Can't wait when it lands. 🚀


Added a Local Image Build to MotorEase

Description and Changes
This PR addresses issues: #9, #10, #12, #13, #14, #15, #16, #18, #19.
Currently, when a developer wishes to deploy their changes to the Docker Image they can do it in 3 ways:

Rebuild the image.
Copy and paste the files with changes to the container with docker cp
Make the changes with editing tools such as vim or nano directly in the container.

However, there are issues with each one:

Rebuilding the image would take too long.
Copying and pasting or making the changes directly to the container would not make sense as if the container is deleted then the changes are not saved (so if you create another container it will not have the changes as the image was not changed).

So, with these changes, the developer would be able to propagate their changes automatically to a docker container.  So, if the developer deletes a container they wouldn't need to copy and paste their changes or rebuild the image, instead, they can run a command that will propagate their previous changes and their new changes to the container all at once. These changes are to make it easier for developers to see their changes locally and improves their quality of life. Also, they can also run the Docker Image locally. This is a new feature as the current builds of MotorEase does not include a local run for the image.
Changes to Code/requirements.txt:

Updated dependencies as they were outdated before which led to the failed build.

Changes to DockerFile:

Fixed the CMD line so MotorEase.py is properly read.
Added a new command that installs all of the necessary dependencies for the run.

Changes to Code/MotorEase.py:

Eliminated duplicate lines of txt and this is because it led to errors in the build since the extra line reassigned txt even though it was not supposed to.
Added correct code path as the MotorEase_PATH was not correct and led to build errors.
Added output so a folder is generated to create the report, which makes the repo more organized.
Added the Glove model path so the project can use the correct model. This can be changed easily, but the model I used was one of the smallest models that led to the same output as the Docker Image run.

Changes to Code/detectors/Visual/IconDistance.py and Code/detectors/Visual/TouchTarget.py:

Added Code to each code path that was used because the previous code path was not correct and it led to errors when it came to building the project locally.

Changes to README.md:

Added instructions on how to run the local image so other developers can understand how to run it.
Updated the instructions for running the image where I included this command:
docker run -it --rm -v $(pwd)/container_files:/container_files itsarunkv/motorease-arm
This command would still run the image but it doesn't need to enter Docker directly.

Created .gitignore:

Created a .gitignore so unnecessary files like the Glove models. This is because GitHub allows for a certain size of files and the Glove models were very large. I also did not want to include the output files as it was not necessary and this is the same for the files generated during the run in Data and the pycache.

Testing
Testing first done by running the Docker Image which is done by doing:

Step 1: Setup the Docker Environment
Step 2: Run python3 MotorEase.py in the Code folder
This test was to grab the original AccessibilityReport that will later be compared with the new local build option.

To grab the results for the local build I followed my instructions in the README (I am summarizing the commands here but the setup does have extra notes on what build requirements may be needed to run the image locally):

Step 1:

 docker build -t motorease Code

Step 2:

docker run -it --rm -v $(pwd)/Data:/data -v $(pwd)/Code:/code -v $(pwd)/Output:/output --env DISPLAY=$DISPLAY -v /tmp/.X11-unix:/tmp/.X11-unix motorease

Results
Below I have attached the two .txt files that contain the results from the local build and the image build.
localBuild.txt
dockerImage.txt
The results here are the same please consider that the name of the codepaths are different so running a comparison will show differences in those areas only.
As for the exception logging I have attached an image of the successful logging (this was to address issue #13):

Some of your changes mention a code/ directory but others still reference the Code/ directory. Are we changing the directory name to lowercase? If so, what is the purpose of this?

Some of your changes mention a code/ directory but others still reference the Code/ directory. Are we changing the directory name to lowercase? If so, what is the purpose of this?

I did not change the directory to "code" rather in Python it did not care for the capitalization so I can change it so it matches the repo's directory.

Some of your changes mention a code/ directory but others still reference the Code/ directory. Are we changing the directory name to lowercase? If so, what is the purpose of this?

Ah okay it's due to my mapping with the Docker command that does read in the "Code" directory but it shows up as "code"


Added group method. Includes tests.

This would make the Outbound integration much more useful to us. Let me know if there are any changes required. @gjohnson

Ping @ndhoule

Hey @dolfelt, can you point me to which part of the Outbound API this matches up with? I had a look at their API documentation and wasn't able to find any sort of grouping support.
If you could also send over some of your use cases and an example #group call, that'd be helpful in evaluating this, too.
Thanks!

@ndhoule The Outbound API doesn't support the group method. This is attaching all the traits from the group method to their user object. I'm doing something similar to what the Vero integration does.
https://github.com/segmentio/integration-vero/blob/master/lib/mapper.js#L61
The use case would be so that we don't have to fill our Segment user objects with Account/Group data but can still have it available to us in Outbound.

In addition to attaching the group traits to the Outbound user object, it would be really helpful if the track call could also include a property count by default when it reports to Outbound since Outbound doesn't keep track of how many times an event has been tracked. If there was a count property sent to outbound, it would make setting up rules based on how many times an event has happened very easy, not to mention make Outbound much more powerful when used with Segment.

ping @ndhoule

@ndhoule If you have questions about this, let @dolfelt or I know. We're trying to make Outbound work with all of the Segment trait data for group and identify calls. This shim does the trick for us and I'm sure others that are trying to feed Outbound with group and user data traits.

hey @chadworks and @dolfelt- we'll merge this for now, although ideally we'd want Outbound to implement this functionality rather than rely on a workaround. let us know if you face any issues!

Thanks @amillet89! When do you think this will go live into the Segment event flow?

@dolfelt Looks like its live. I see group.trait-name going into Outbound now.

yep it went live earlier today!


EC2/EBS: Detaching a volume does not update the block_device_mappings state

I would expect that when detaching a volume from an instance, that the block_device_mappings attribute gets updated to reflect that - this doesn't seem to be the case, as the below example shows:
from moto import mock_ec2
import boto3

@mock_ec2
def test_detach_volumes():
    region = 'us-west-1'
    ec2 = boto3.resource('ec2', region_name=region)
    instance, = ec2.create_instances(
        ImageId='ami-12345678',
        MinCount=1,
        MaxCount=1,
    )
    instance.load()
    count = []
    for b in instance.block_device_mappings:
        count.append(b)
    assert len(count) == 1
    volume = ec2.create_volume(
        AvailabilityZone=instance.placement['AvailabilityZone'],
        Size=1,
    )
    instance.attach_volume(
        Device='/dev/sdb',
        VolumeId=volume.volume_id
    )
    count = []
    for b in instance.block_device_mappings:
        count.append(b)
    assert len(count) == 2
    instance.detach_volume(VolumeId=volume.volume_id)
    # as expected, load() makes no difference
    volume.load()
    instance.load()
    print(instance.block_device_mappings)
    count = []
    for b in instance.block_device_mappings:
        count.append(b)
    assert len(count) == 1

test_detach_volumes()

Versions:
Python 3.6.5
Boto3: 1.9.47
Botocore: 1.12.47
Moto: 1.3.7

Thanks for opening. It doesn't look like we've implemented this part yet so I'm going to set this as a feature request.

@rdark I can successfully run your test against the latest version of moto.  Is this still an issue?

Going to close this due to a lack of response. Feel free to reopen if we've missed something.


Omit index.html from URLs in feed.xml.

Is this OK or does it have to include index.html? I could not find anything online.

I guess the same could be done for sitemap.xml?

I can't imagine it's necessary (though, like you, I didn't know and went for the conservative route but that's probably not needed), I'll merge this without releasing,  test it a bit with a couple of RSS readers and we can revert if there's something fishy going on.
Thanks for all the contribs!

On second though; perhaps it would be enough to prettify the URL here: https://github.com/tlienart/Franklin.jl/blob/41289c895f0cf3d0c65f35061d69558e44b02972/src/manager/rss_generator.jl#L188 since that is the only thing a human would see/click on. Perhaps that is better?

Yes that's true


Added radio update.

Major changes:
Added radio update function.
Changed how device information is checked for faster execution of script.
Minor changes:
Streamlined code.
Added more information.

Please check for firmware versions before merging!

As said in PM on TL forums, when updating the firmware the bootloader version number also changes.

Added link to readme file and changed minor text details.


kmeans is added

Thank you very much for adding K-means :) Do you mind merging it with the kmeans in the ML_Coding_Problems notebook? :)


error occured when run comfyui using the same prompts

Thanks to your excellent work!
Since comfyui try to find last generated image if using identical txt2img workflow(same seeds), there will be error occured because the images in output directory have been removed before prediction.

I think this is happening because there is no easy way to tell ComfyUI to flush it's cache.
A quick way around it would be to run a quick and simple reset workflow beforehand, like this one:
https://github.com/fofr/cog-comfyui/blob/main/examples/api_workflows/reset.json

I'm adding an option to run the reset as part of the prediction to prevent this.

You can now use this feature if it happens again.

You can now use this feature if it happens again.

@fofr I have this issue as well, how can I use force_reset_cache in the code? iirc it was in the predict.py but I updated to new commit and I don't see it anymore. Also is it safe if I have multiple items in the queue to use that option?

Yep, that should be fine


Sigh w/spaceship - InHouse profiles aren't recognized

when running sigh to generate a provisioning profile using an Enterprise account doesn't find the certificates needed and exits (the certificate is there)

related to #106

Fixed with the most recent commits to spaceship :+1:


opam depext --install flowtype hangs on [flowtype: make] Command started forever

Hi,
I've created a Docker image based on ocaml/opam:debian-8_ocaml-4.03.0 which is working great with Flow v0.26.0 but fails with the latest v0.27.0:
[flowtype: make] Command started

And then nothing more happens and no errors are thrown... any idea?
The source repository of the image is on https://github.com/yamafaktory/docker-flowtype. The described issue can be reproduced by running the following commands:
git clone https://github.com/yamafaktory/docker-flowtype.git
cd docker-flowtype
docker build --build-arg BUILD_FLOW_VERSION=0.27.0 -t yamafaktory/docker-flowtype .

This sounds similar to the issue described by https://github.com/facebook/flow/pull/1941. Presumably neither mercurial nor git are available in the docker image, right?

@mroch Thanks for the guidance! Strangely adding git (apt-get install git or apt-get install git-core) didn't fix the issue but mercurial did it. Regarding git, I also tried to upgrade the Debian image to Stretch without success.


Seperate Type into Type and Ty for owned and unowned types

This should be analogous to String and str - Ty should be used behind a pointer and be used to save some clones that would usually be done on the owned types.
pub struct Ty {
    _type: jit_type_t
}
impl !Sized for Ty {}
impl Ty {
    fn get_i8() -> &'static Ty {
        ....
    }
}
impl ToOwned for Ty {
    fn to_owned(&self) -> Type {
        ...
    }
}

pub struct Type {
    _type: jit_type_t
}
impl Deref for Type {
    type Target = Ty;
    fn deref(&self) -> &Ty {
        ...
    }
}

Implemented as of a few days ago!


Usage in a webpack dev environment

I am wondering how one would go about setting a webpack dev environment up with this plugin? All my efforts have so far ended up with the styles of the last saved file overwriting the content of the bundled file.

It's hard to tell what's wrong with your environment from far away. Your dev setup might be misconfigured. I'd like to take a look at it in order to understand what's going on.

I stripped down the project as much as I could (There might be some orphan islands left in) and is available at : [https://github.com/Nimaear/bare-example].
You should be able to see the problem after npm install && npm run dev

Created a pull request which solves the issue for me haven't encountered any problems so far.

I'm having the same issue using webpack.

I just released v1.2.2 with the referenced PR merged in.


issue with a10_router_bgp

seem to be having a issue with the a10_router_bgp.  here is what i got so far
python 2.7.5
ansible 2.7.5

name: update a10_router_bgp
a10_router_bgp:
a10_host: "asdfasdft"
a10_username: "admin"
a10_password: "asdfasdfasdf"
state: present
as_number: "64551"

The full traceback is:
Traceback (most recent call last):
File "/home/jsmith/.ansible/tmp/ansible-tmp-1549393384.87-185129765312972/AnsiballZ_a10_router_bgp.py", line 113, in
_ansiballz_main()
File "/home/jsmith/.ansible/tmp/ansible-tmp-1549393384.87-185129765312972/AnsiballZ_a10_router_bgp.py", line 105, in _ansiballz_main
invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)
File "/home/jsmith/.ansible/tmp/ansible-tmp-1549393384.87-185129765312972/AnsiballZ_a10_router_bgp.py", line 48, in invoke_module
imp.load_module('main', mod, module, MOD_DESC)
File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 479, in
File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 471, in main
File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 459, in run_command
File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 376, in exists
File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 372, in get
File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 298, in existing_url
KeyError: 'as-number'
fatal: [localhost]: FAILED! => {
"changed": false,
"module_stderr": "Traceback (most recent call last):\n  File "/home/jsmith/.ansible/tmp/ansible-tmp-1549393384.87-185129765312972/AnsiballZ_a10_router_bgp.py", line 113, in \n    _ansiballz_main()\n  File "/home/jsmith/.ansible/tmp/ansible-tmp-1549393384.87-185129765312972/AnsiballZ_a10_router_bgp.py", line 105, in _ansiballz_main\n    invoke_module(zipped_mod, temp_path, ANSIBALLZ_PARAMS)\n  File "/home/jsmith/.ansible/tmp/ansible-tmp-1549393384.87-185129765312972/AnsiballZ_a10_router_bgp.py", line 48, in invoke_module\n    imp.load_module('main', mod, module, MOD_DESC)\n  File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 479, in \n  File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 471, in main\n  File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 459, in run_command\n  File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 376, in exists\n  File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 372, in get\n  File "/tmp/ansible_a10_router_bgp_payload_XB1psn/main.py", line 298, in existing_url\nKeyError: 'as-number'\n",
"module_stdout": "",
"msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
"rc": 1
}

Closing due to age. Please re-open and send email to<EMAIL_ADDRESS>if you are still experiencing this issue.


Copy on proposal duration

Copy on proposal duration: “Number of (5 minutes) the proposal will be up for voting.” What does this copy mean? If it really means the input value times 5 minutes is the proposal duration, then this needs to be made much clearer.

Copy is updated


Unexpected token 'export'

Is any one encounter this issue ?
I build succesfully, but start failed ?
here is fail info:

here is my package version:

I have the same issue. I am not able to start the application without this problem crashing it from the start

@WreewanMorhee Thanks for alerting us to this issue. Perhaps this issue is what's causing it?
https://github.com/remix-pwa/remix-pwa/issues/93
If not, would be happy to review it ASAP

for all you here information
I change to use the code about base here: remix-pwa-docs (like package.json, remix.config.js, workbox.ts ... etc )
then my problem is done !
so I think something wrong about base code like mention above
I think it's better to provide some real example instead of just text tutorial

so I think something wrong about base code like mention above I think it's better to provide some real example instead of just text tutorial

Do you mean the source files? remix-pwa modules are ESM-modules by default, a problem for Remix bundlers (currently).
Not sure if you are referring to the docs though 😕?

@WreewanMorhee Use serverDependenciesToBundle.
// remix.config.js

/** @type {import('@remix-run/dev').AppConfig} */
module.exports = {
  ...
  serverDependenciesToBundle: [
<EMAIL_ADDRESS>  ],
};

Closing issue due to inactivity, if you have any other issues or problem please open a new issue


go-get problem: no buildable Go source files in the repo

I try to run go get github.com/MSOpenTech/azure-sdk-for-go as it is written in README file, but I get following error message:
→ go get github.com/MSOpenTech/azure-sdk-for-go
can't load package: package github.com/MSOpenTech/azure-sdk-for-go: no buildable Go source files in /Users/allomov/work/altoros/microbosh/go/src/github.com/MSOpenTech/azure-sdk-for-go

You're right this must be fixed. Meanwhile, try go get -d.

Thank you for your answer, I was able to fix it by fetching v1.2 tag.

Alternatively, go get github.com/MSOpenTech/azure-sdk-for-go/... will get you all packages and their dependencies under that path...

Has it been fixed?
I've tried the following commands and didn't work.
go get github.com/Azure/azure-sdk-for-go
go get -u github.com/Azure/azure-sdk-for-go
go get -d github.com/Azure/azure-sdk-for-go
go get github.com/Azure/azure-sdk-for-go/...

Howdy @michaelsync, to avoid getting the error messages you can target the individual packages that you need. (i.e github.com/Azure/azure-sdk-for-go/arm/compute)
The error message about having no buildable Go files is expected behavior of the go get tool when targeting a whole repository instead of the particular package/packages that you need.


Pull request tempates

It would be nice if we had a good template for PRs to keep PR styles consistent.

Honestly, I didn't think anyone would be interested in this project at all (thus no templates provided), but since you're willing to contribute, I'll get to work right away, thank you!

PR template added


Includes: manually add BIP reference links

Some merged BIPS now use non-.mediawiki extensions, so our code for automatically generating BIP links is broken.  Also, as BIP assignments become more sparse, that code is slowing down the side build for both Jekyll and Hugo.
Replace automatic code with a manual list.  This should not be too much of a problem for authors and it allows any BIP extension (or URL change) to be accommodated.
Our existing tests catch any case where we fail to provide a link definition, so this should be safe to merge as soon as it passes tests.

Concept ACK. This will address https://github.com/bitcoinops/bitcoinops.github.io/issues/1773

Postmerge ACK


Inference speed and classification head

I am getting around 2.1 fps on a desktop CPU, which is nowhere around real-time :smile:
Is this the same for everyone?
Also, in Gooogle AI blog post they said they have gesture classification head, but I can't find it in the code. Can somebody point out where I should look for?

I have the same performance issues with a CPU.

regarding fps look at #8
about the gesture classification head - I did not port it

also check out the new desktop hand tracking demo in the official Mediapipe repo


Update create image wizard

Several commits for each task done.

Created new image details step for wizard
Changed image output to checkboxes
Removed password from registration
Updated review step page with newly aligned content and added new component

Notes

On removing the registration step I changed from calling the registrationCreds to using DDF component types. Can add more validation to ssh with ddf, as well as any others.
Attempted to add default checked for output image. Need some advice on how to do that. (wouldnt accept isChecked / checked)
I switched from textlist to grid due to having issues with aligning the items and the need to keep data-testid attr (hopefully the data being nested isnt too bad)

Codecov Report

Merging #65 (5ae9634) into master (18fb43e) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   32.42%   32.25%   -0.18%
==========================================
  Files          57       58       +1
  Lines         922      927       +5
  Branches      251      247       -4
==========================================
  Hits          299      299
- Misses        585      590       +5
  Partials       38       38

Impacted Files
Coverage Δ

src/Routes/ImageManager/CreateImageWizard.js
0.00% <ø> (ø)

src/Routes/ImageManager/steps/imageOutput.js
0.00% <ø> (ø)

src/components/ReviewSection.js
0.00% <0.00%> (ø)

src/components/form/ReviewStep.js
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18fb43e...5ae9634. Read the comment docs.

I would like it to look like this

@resoluteCoder In steps/imageOutput.js instead of using the componentTypes.CHECKBOX create your own component that will have these checkbox and using the initialValue that will be passed set the default value.
You can see an example here:
How to create the custom component:
https://github.com/RedHatInsights/edge-frontend/pull/55/files#diff-0853c7d44069b685230dc398ad1307987939225667c282888220a1c431c261dfR1-R92
How to add the custom component to the componentMapper
https://github.com/RedHatInsights/edge-frontend/pull/55/files#diff-0cba6bb161be262e47785f3992fb80e1b2d7b6d0108483986e80898bf3f74812R10-R57
How to add it to the step component:
https://github.com/RedHatInsights/edge-frontend/pull/55/files#diff-bb4cbcec7b72ca2579f2374f0d14308f185f3aa5937a98432cfc518cf75221c3R38-R42

Please note that Andy made some new changes


Named arguments with multiple values, e.g. list[str]

Sample code
from cyclopts import App, Parameter
from typing import Annotated

app = App()

@app.default
def main(
    *, input: Annotated[list[str], Parameter(help="Input filename(s)")] = None
) -> None:
    """Process the input files."""
    if input is None:
        print("Not told what to do")
        return 1
    elif not input:
        print("Told to do nothing")
        return 0
    else:
        print("Working:")
        for file in input:
            print(f"* {file}")
        return 0

app()

Testing with cyclopts 3.1.1 on Python 3.12.7 on macOS.
This example works mostly as expected:
base ❯ python cyclopts_demo.py --help
Usage: main COMMAND [OPTIONS]

Process the input files.

╭─ Commands ──────────────────────────────────────────────────────╮
│ --help -h  Display this message and exit.                       │
│ --version  Display application version.                         │
╰─────────────────────────────────────────────────────────────────╯
╭─ Parameters ────────────────────────────────────────────────────╮
│ --input --empty-input  Input filename(s)                        │
╰─────────────────────────────────────────────────────────────────╯

❯ python cyclopts_demo.py
Not told what to do

This works as a way to set an empty list:
❯ python cyclopts_demo.py --empty-input
Told to do nothing

Now with a single argument:
❯ python cyclopts_demo.py --input A.txt
Working:
* A.txt

Passing multiple arguments this way works:
❯ python cyclopts_demo.py --input A.txt --input B.txt
Working:
* A.txt
* B.txt

However, the natural argparse supported syntax does not:
❯ python cyclopts_demo.py --input A.txt B.txt
╭─ Error ─────────────────────────────────────────────────────────╮
│ Unused Tokens: ['B.txt'].                                       │
╰─────────────────────────────────────────────────────────────────╯

This syntax is especially useful when combined with wildcards, --input *.txt for example.
Is this me using cyclopts wrong, or do you have the same limitation as click and typer?

https://github.com/fastapi/typer/issues/554
https://github.com/pallets/click/issues/484

I think I found the answer in your docs:
from cyclopts import App, Parameter
from typing import Annotated

app = App()

@app.default
def main(
    *,
    input: Annotated[
        list[str], Parameter(help="Input filename(s)", consume_multiple=True)
    ] = None,
) -> None:
    """Process the input files."""
    if input is None:
        print("Not told what to do")
        return 1
    elif not input:
        print("Told to do nothing")
        return 0
    else:
        print("Working:")
        for file in input:
            print(f"* {file}")
        return 0

app()

❯ python cyclopts_demo.py --input A.txt B.txt
Working:
* A.txt
* B.txt

Hooray! This deserves highlighting on https://cyclopts.readthedocs.io/en/latest/vs_typer/README.html in my opinion (as it looks to solve my number one frustration with Typer!)

glad you were blessed to figuring it out! Any recommendations on how to improve the docs (I'm very open to PRs as well!)? I don't think this feature is quite "bold" enough to make it to the README, but I certainly want all of Cyclopts information/features to be more readily available to users.

I didn't mean the top level https://github.com/BrianPugh/cyclopts/blob/main/README.md but as another page under https://cyclopts.readthedocs.io/en/latest/vs_typer/README.html
i.e. A sister page to entries like https://cyclopts.readthedocs.io/en/latest/vs_typer/help_defaults/README.html about the help defaults (another annoyance with typer where your defaults are better, cross reference typer issue 465).
I would explicitly reference the argparse nargs equivalence https://docs.python.org/dev/library/argparse.html#nargs for an indeterminate number of arguments.

Got it! I'll add that soon, thanks for the recommendation!

Addressed in #269


could display newline correctly

when use source code as practice source. it seems remove all the newline.
might same feature request as https://github.com/max-niederman/ttyper/issues/61

maybe could be a flag of some kind
-n     treat newlines as new words


Culturebox downloads stopped working

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.02.04. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x ] I've verified and I assure that I'm running youtube-dl 2018.02.04

Before submitting an issue make sure you have:

[x ] At least skimmed through the README, most notably the FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones
[x ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl --verbose http://medias2.francetv.fr/hbbtv/replay/streaming-adaptatif/evt/pf-culture/2017/12/132899-20171229-4-2176k.mp4
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'http://medias2.francetv.fr/hbbtv/replay/streaming-adaptatif/evt/pf-culture/2017/12/132899-20171229-4-2176k.mp4']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.02.04
[debug] Python version 2.7.6 (CPython) - Linux-3.13.0-24-generic-i686-athlon-with-LinuxMint-17-qiana
[debug] exe versions: avconv 9.20-6, avprobe 9.20-6, rtmpdump 2.4-n111-gitfa8646d-ppa9p2
[debug] Proxy map: {}
[generic]<PHONE_NUMBER>1229-4-2176k: Requesting header
WARNING: Could not send HEAD request to http://medias2.francetv.fr/hbbtv/replay/streaming-adaptatif/evt/pf-culture/2017/12/132899-20171229-4-2176k.mp4: HTTP Error 403: Forbidden
[generic]<PHONE_NUMBER>1229-4-2176k: Downloading webpage
ERROR: Unable to download webpage: HTTP Error 403: Forbidden (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 519, in _request_webpage
    return self._downloader.urlopen(url_or_request)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2199, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "/usr/lib/python2.7/urllib2.py", line 410, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 523, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 448, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 531, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Downloading from culturebox seems to have stopped working,

You must use the original URL.


add option to transaction-list command to specify count

closes #1043

What about calling this --limit instead? This could use a test, check out my comments on the other two PRs.

Also, should the limit be unlimited instead?

*default limit

Just added some tests, and changes the flag to --limit. Take a look and let me know what you think! I want to get this in, because I think having an implicit limit of 10 is a bit odd.


why this code provides no error?

module M {
     class A {
		c(a: number): A {
			return new B();
		}
	}
}

function B() {
}

https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#414-the-new-operator
For compat reasons, void-returning functions invoked with new return a value of type any.
You can cause this to be an error by running with the --noImplicitAny switch.


Rework hal initialization

I wanted to put this up for discussion before I invested all my time into updating examples/tests. This PR changes clock configuration into something more similar to embassy_stm32, which is hopefully somewhat simpler than our current solution.
TODO:

[x] update ALL the doc examples
[x] add to changelog
[ ] write documentation
[ ] write a migration guide

Looking at how the usage changed, I am considering two changes:

Not including software interrupts in the System (name pending) struct in its current form. Using it would probably consume the SYSTEM peripheral, or I might add a virtual SW_INT, I'm not sure yet.
Inlining peripherals in System (name pending) to remove that one level of annoyance. This will mean that System (name pending) will contain all ther peripherals plus a very inconsistent-to-have-you-here Clocks. Honestly, I'm sad we have to lug around Clocks, it makes things more difficult rn.

Thoughts?

Sometimes I wonder why we don't just have these as arguments to main.
Regarding the 2nd point, I personally think some grouping is nice. At some point I was thinking we could separate all the peripherals that need enable/reset (SPI, I2C, LCD_CAM, etc) into one struct and peripherals that are always available into another struct (GPIO, SW_INT, etc).
Not many thoughts on the first bullet point.

Sometimes I wonder why we don't just have these as arguments to main.

There's a bit of intentional cargo cult here, I would like esp-hal to look somewhat similar to embassy hals. A bit of consistency doesn't hurt the ecosystem, even if it's not required.
It's pretty hard to document how the main function would work, especially that the esp_hal_embassy main macro is different - eww looking at it, we have more work to do here anyway.
If we pass these to main, we still need a somewhat usable API for the HIL tests, which don't use main. So we might as well start with an ergonomic solution first, and add the magic later if needed.

I guess if we're queueing up breaking changes to improve the ergonomics around clocks, we might as well delay this PR to the next milestone, so we don't break things multiple times unnecessarily. So, expect this to remain a draft for the next week at least.

Added skip-changelog because of the changes needed in esp-hal-embassy.


FieldContentBuffer.Table.al must be removed

FieldContentBuffer.Table.al must be removed from the list of tables generated through txt2al because of in version 20 and onwards it is now part of system application. This will not let the upgrade go through and elevate an exception like e.g.
Type: Microsoft.Dynamics.Nav.Types.Exceptions.NavAppObjectMetadataException
ErrorCode: -1
SuppressMessage: False
ContainsPersonalOrRestrictedInformation: False
DiagnosticsSuppress: True
MessageWithoutPrivateInformation: The application object of type 'Table' with the ID '1754' is defined in multiple apps. The apps are: bc14baseapptablesonly by My publisher <IP_ADDRESS>; System Application by Microsoft 20.2.41144.41423.
SuppressExceptionCreatedEvent: False

Learn Build status updates of commit 1acc9b0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dev-itpro/upgrade/upgrade-to-microsoft-base-app-v20.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


A quick question: Were benchmarks data based on default tcp transport?

I am reading the source code, and saw dragonboat has an excellent performance which according to benchmarks data. Is these data were test base on  default tcp transport or other customed rpc transport.
Thanks a lot.

Default TCP transport on 40Gbps dual ports ethernet cards.
Note that the benchmark results were observed on 2 years old open source version. Most recent internal version is about 50% better in terms of throughput, latency is also significantly reduced.

Thanks a lot.


age field outside of unsigned under event context API

In the Swagger docs for the event context API the age field appears directly on the event object instead of inside an unsigned object like it does elsewhere.
Is this correct or should unsigned be added to the example JSON?
Edit: Also happens on the state API.

ftr it should be under unsigned. The age being top-level is a legacy representation of events that nothing should be using nowadays.


Text rendering with word wrap and RTL often clips

A bug in the API:

Phaser version(s): 2.12.0, 2.15.0
What steps produce the bug: Use RTL text, such as Arabic, with word wrap, so the text wraps.
What should happen: All letters should render properly.
What happens instead: One more more letters of the widest line(s) will be truncated on the right.

When the word wrapping routine splits text into words by spaces, each line's string (except possibly the last line) has a trailing space. Each line is then measured, and the width of a space is removed from the line length to account for that trailing space (necessary for accurate Center or Right alignment). For LTR languages, the trailing space for the widest line(s) are actually clipped off by the right side of the context's rectangle because of this. Since spaces are not visible, this is not an issue.
For a RTL language the trailing space is actually drawn on the left.  Since text rendering is positioned by the left edge, the subtraction of the width of a space from the width of the line may result in the right side of the text clipped by the width of the space.
Fix: Instead of measuring lines of word wrapped split text with trailing space included, then subtracting the width of a space, simply trim the trailing space of each word wrapped line from the string.

This corrects the defect.
Addition of 5 lines to Text.js:
    this._charCount = 0;

    for (var i = 0; i < drawnLines; i++)
    {
        if (this.style.wordWrap && lines[i].length > 0 && lines[i][lines[i].length-1] == ' ')
        {
            //Remove trailing space from word wrapped lines.
            lines[i] = lines[i].substring(0, lines[i].length-1);
        }
        if (tabs === 0)
        {

Remove from Text.js
`            // Adjust for wrapped text
            if (this.style.wordWrap)
            {
                lineWidth -= this.context.measureText(' ').width;
            }

Additionally, it is possible for this defect to manifest for LTR languages as well.  The final word-wrapped line will not end in a space (unless the original text has an extraneous text at the end) when words are split by spaces. The defective code assumes every line, including the final line, ends in a space. Thus if the final word wrapped line is the widest line, it could also be clipped by the width of a space.

Thanks. So what's a text string I could reproduce this with?

I'm checking with the copyright owners over that. I think if I provide you the raw text, font size and the word wrap width constraint you should be able to reproduce it.


Please explain what a TDU is

I am unfamiliar with the abbreviation.

Not surprising. Very CDC/NOS specific from long ago.  I actually found an on-line scanned copy of the manual describing TDU, PDU, CCL screen mode and some other things that shows not everything going forward is progress.  Screen interfaces were downright trivial compared to today from system shells and Fortran years ago.
Hopefully, that clears up the nomenclature.  Now if I can just get around to finishing this or creating the OOP screen interface including simple graphics I keep saying I want to make :>


Move Window

As a user I want to move the hole Window by clicking on a menu bar by drag and drop because I want to customize my squeak workspace. The menu bar is a bar on top of the canvas.

ca. 3h
ca. 3 story points


[RKE2] Document change in AppArmor requirements

Environmental Info:
RKE2 Version:

rke2 version v1.21.3+rke2r1 (2ed0b0d1b6924af4414393cd1796c174a1ff5352)
go version go1.16.6b7
Node(s) CPU architecture, OS, and Version:

OS: openSUSE Leap 15.3
Uname -a: Linux rke2debug 5.3.18-57-default rancher/rke2#1 SMP Wed Apr 28 10:54:41 UTC 2021 (ba3c2e9) x86_64 x86_64 x86_64 GNU/Linux
Cluster Configuration:

Just  a single node server.
Describe the bug:

Containerd isn't creating the containers for etcd, api server, etc. When I get the RKE2 logs:
Jul 26 18:57:13 rke2debug rke2[935]: {"level":"warn","ts":"2021-07-26T18:57:13.127Z","caller":"clientv3/retry_interceptor.go:62","msg":"retrying of unary invoker failed","target":"passthrough:///https://<IP_ADDRESS>:2379","attempt":0,"error":"rpc error: code = DeadlineExceeded desc = latest balancer error: connection error: desc = \"transport: Error while dialing dial tcp <IP_ADDRESS>:2379: connect: connection refused\""}
Jul 26 18:57:13 rke2debug rke2[935]: time="2021-07-26T18:57:13Z" level=info msg="Failed to test data store connection: context deadline exceeded"
Jul 26 18:57:16 rke2debug rke2[935]: time="2021-07-26T18:57:16Z" level=warning msg="Unable to watch for tunnel endpoints: Get \"https://<IP_ADDRESS>:6443/api/v1/namespaces/default/endpoints?fieldSelector=metadata.name%3Dkubernetes&resourceVersion=0&watch=true\": dial tcp <IP_ADDRESS>:6443: connect: connection refused"
Jul 26 18:57:18 rke2debug rke2[935]: time="2021-07-26T18:57:18Z" level=info msg="Waiting for API server to become available"
Jul 26 18:57:18 rke2debug rke2[935]: time="2021-07-26T18:57:18Z" level=info msg="Waiting for etcd server to become available"

So I used crictl to get the running pods.
POD ID              CREATED             STATE               NAME                                NAMESPACE           ATTEMPT             RUNTIME
f97e098ab891e       14 minutes ago      Ready               kube-scheduler-rke2debug            kube-system         0                   (default)
9b1ffe60998e3       14 minutes ago      Ready               kube-proxy-rke2debug                kube-system         1                   (default)
12870c199aaa0       14 minutes ago      Ready               kube-controller-manager-rke2debug   kube-system         0                   (default)
861a03f7b24ee       14 minutes ago      Ready               etcd-rke2debug                      kube-system         0                   (default)
981c0be6fd75e       27 minutes ago      NotReady            kube-proxy-rke2debug                kube-system         0

A crictl ps -a  returns:
CONTAINER           IMAGE               CREATED             STATE               NAME                ATTEMPT             POD ID
672f352fcd658       4a27aad01c210       15 minutes ago      Running             kube-proxy          1                   9b1ffe60998e3
1c6b87c25b317       4a27aad01c210       29 minutes ago      Exited              kube-proxy          0                   981c0be6fd75e

After suggest by @brandond I checked the containerd logs:
time="2021-07-26T19:06:08.154756874Z" level=error msg="CreateContainer within sandbox \"f97e098ab891e46b975a178e8c6247f4582505f86f325d1a7e8f04ff52fb2495\" for &ContainerMetadata{Name:kube-scheduler,Attempt:0,} failed" error="failed to create containerd container: get apparmor_parser version: exec: \"apparmor_parser\": executable file not found in $PATH"
time="2021-07-26T19:06:08.929885703Z" level=info msg="CreateContainer within sandbox \"12870c199aaa0a20511658f8d4c855e8836bf7997eefd78bb385058650e2aaf2\" for container &ContainerMetadata{Name:kube-controller-manager,Attempt:0,}"
time="2021-07-26T19:06:09.130619970Z" level=error msg="CreateContainer within sandbox \"12870c199aaa0a20511658f8d4c855e8836bf7997eefd78bb385058650e2aaf2\" for &ContainerMetadata{Name:kube-controller-manager,Attempt:0,} failed" error="failed to create containerd container: get apparmor_parser version: exec: \"apparmor_parser\": executable file not found in $PATH"

Steps To Reproduce:

Installed using the quickstart guide.
curl -sfL https://get.rke2.io | INSTALL_RKE2_TYPE="agent" sh -
echo "RKE2_CNI=calico" >> /opt/rke2/lib/systemd/system/rke2-server.env
systemctl enable rke2-server.service
systemctl start rke2-server.service

Expected behavior:

The expectation is that the server starts up without any errors.
Actual behavior:
It currently fails to start.
Current Fix that worked
I was able to correct this issue by install apparmor-parser and restarting rke2.
zypper install apparmor-parser
systemctl restart rke2-server.service

Additional context / logs:

@dweomer @brandond can you all provide details around which versions of RKE2 are impacted?

I am not sure, (frustratingly) haven't been able to pin it down how exactly the dependency came in. I would be comfortable just documenting this as a requirement for all 1.21 and newer branches - if the host kernel has apparmor, the apparmor userspace needs to be present as well.

I think the issue is that previous versions of containerd did not need apparmor_parser installed. We should document the new requirement somewhere.

I'm getting the same errors in my logs, but with apparmor_parser installed.


test(bin-utils): adjusted paths separator

Adjusted paths to match linux format on windows os.

What: Fixed tests for bin-utils on Windows

Why: Tests were failing on Windows

How: Adjusted paths seperator

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #135   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          10     10
  Lines         288    288
=====================================
  Hits          288    288

Impacted Files
Coverage Δ

src/bin-utils/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cd798...8f13bd6. Read the comment docs.

Sorry for that merge, I made a branch from old code without my old changes. If you want to keep a clean git history you can decline this pull request and I will make another one.

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the CONTRIBUTING.md file (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)

Wow, I feel honored! Will try to do my best and to not disappoint you.

You're already doing awesome man. Thanks for all your hard work :D

You're welcome! This project is really nice and I enjoy working on it :-)


Best practice to run Mask R-CNN in parallel

What ist the best practice to run Mask R-CNN in parallel?
@fmassa wrote in #1255

The current code assumes that you are using 1 GPU per process, with DistributedDataParallel.

Is this information up-to-date?

We use 1 GPU per python process, but that doesn't mean that we can't use more than 1 GPU for training / inference.
Best practice is to run the training code via
python -m torch.distributed.launch --nproc_per_node=8 --use_env train.py


24 Hour clock

It would be nice to have a 24 hour clock option

@jay18001 do you have any ideas on how to make it integrate with a 24 hour UI? (:

I have an idea see the screenshot

Hi, what is the API to show 24 hrs clock?

Any update oh this issue?


NoSuchElementException: key not found: org.apache.spark.ml.feature.OneHotEncoder #220

Hi,
I want to bundle a PySpark ML pipeline with MLeap.
I was able to do it fine until I added pyspark.ml.feature.OneHotEncoderEstimator to my pipeline.
When I am using a cluster based on Python 3 and Databricks runtime 4.3 (Scala 2.11,Spark 2.3.1) I got the issue  [#220]
As suggested in #220 I tried to import and use the mleap OneHotEncoder. However, I cannot import anything from org.apache.spark.ml.mleap.feature
`%scala
import org.apache.spark.ml.mleap.feature
notebook:1: error: object feature is not a member of package org.apache.spark.ml.mleap
import org.apache.spark.ml.mleap.feature
`
I got the same error with Databricks 3.5 LTS (Scala 2.11, Spark 2.2.1)
Extra Info:
I am using Databricks Community edition.
I have installed MLeap-Spark:

ml.combust.mleap:mleap-spark-base_2.11:0.10.1
ml.combust.mleap:mleap-spark_2.11:0.10.1
I have attached the libraries to all clusters.

I am new to Spark and to GitHub. I might be missing something really obvious. Please go easy on me :)

hey @ruimaximo we've removed mleap's own one hot encoder, so you can use
import org.apache.spark.ml.feature.OneHotEncoderEstimator
instead.
To use the pyspark integration, you'll need to attach to your cluster the mleap pypi dependency as well. And then you can do something like this
import mleap.pyspark
from mleap.pyspark.spark_support import SimpleSparkSerializer

from pyspark.ml.feature import OneHotEncoderEstimator```

Please let me know if you have any further questions, and if not, if it's okay to close this issue.

Hi @ancasarb
I am using Databricks run time version cluster:  5.2 ML Beta (includes Apache Spark 2.4.0, Scala 2.11) and from Marven : ml.combust.mleap:mleap-spark_2.11:0.12.0
I got thse same Error:
java.util.NoSuchElementException: key not found: com.databricks.sparkdl.DeepImageFeaturizer
Py4JJavaError                             Traceback (most recent call last)
 in ()
3 from pyspark.ml.feature import OneHotEncoderEstimator
4
----> 5 p_model.serializeToBundle("jar:file:/tmp/mleap_python_model_export/ModelImage-json.zip", tested_df)
/databricks/python/lib/python3.6/site-packages/mleap/pyspark/spark_support.py in serializeToBundle(self, path, dataset)
23 def serializeToBundle(self, path, dataset=None):
24     serializer = SimpleSparkSerializer()
---> 25     serializer.serializeToBundle(self, path, dataset=dataset)
26
27
/databricks/python/lib/python3.6/site-packages/mleap/pyspark/spark_support.py in serializeToBundle(self, transformer, path, dataset)
40
41     def serializeToBundle(self, transformer, path, dataset):
---> 42         self._java_obj.serializeToBundle(transformer._to_java(), path, dataset._jdf)
43
44     def deserializeFromBundle(self, path):

Hey, we don't have support for DeepImageFeaturizer, I could help guide you in what's required for adding support for it, if you'd like.

Yes please, I would like your help.
thanks


Consider to extract a contextClassName from a super interfaces of the ObservationConvention impls

Right now the logic is like this:
                if (myClass instanceof JavaClassImpl) {
                    Pattern classPattern = Pattern.compile("^.*ObservationConvention<(.*)>$");
                    JavaClassImpl holder = (JavaClassImpl) myClass;
                    for (String anInterface : holder.getInterfaces()) {
                        if (isGlobalObservationConvention(anInterface)) {
                            this.observationConventionEntries.add(new ObservationConventionEntry(unit.getGoverningType().getCanonicalName(), ObservationConventionEntry.Type.GLOBAL, contextClassName(classPattern, anInterface)));
                        } else if (isLocalObservationConvention(anInterface)) {
                            this.observationConventionEntries.add(new ObservationConventionEntry(unit.getGoverningType().getCanonicalName(), ObservationConventionEntry.Type.LOCAL, contextClassName(classPattern, anInterface)));
                        }
                    }
                    return FileVisitResult.CONTINUE;
                }

So, this assumes that our custom ObservationConvention does just exactly implements ObservationConvention<CustomContext>, when real use-cases is like this:
public class DefaultMessageReceiverObservationConvention implements MessageReceiverObservationConvention {
...
}
public interface MessageReceiverObservationConvention extends ObservationConvention<MessageReceiverContext> {

Our point is make end-users life easier in providing custom conventions into our components. Therefore we expose a specific interface.
Therefore this request is to see if the current parser is able to dig deeper in the class hierarchy to to find its desired pattern for a generic argument to extract.

Hi @artembilan
I have rewrote the search algorithm and updated the ObservationConvention detection in 4838a1d4e3778faf2118d8ff05efb40ff79587fa and a31989bfedb52134ccc31b7424ed5caaed8bb77d
The latest snapshot will look for the nested and parent classes/interfaces hierarchy as well.
I checked with spring-integration.
Comparing the generated _conventions.adoc with RC1 and current snapshot:
> diff _conventions.adoc-RC1 _conventions.adoc-SNAPSHOT
9c9
< |`org.springframework.integration.support.management.observation.DefaultMessageReceiverObservationConvention`|`n/a`
---
> |`org.springframework.integration.support.management.observation.DefaultMessageReceiverObservationConvention`|`MessageReceiverContext`

It now detected the MessageReceiverContext for the convention class from parent MessageReceiverObservationConvention.java.


chore: upgrade tdengine addon to v1.0 API

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (c34311a) to head (4b622ac).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1306   +/-   ##
=====================================
  Coverage   0.00%   0.00%
=====================================
  Files         69      69
  Lines       6693    6693
=====================================
  Misses      6693    6693

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

/cherry-pick release-1.0-beta


support more notebooks for redis guideline

Closes #
📑 Description

✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[ ] All the tests have passed
[x] Branch name follows type/descript (e.g. feature/add-llm-agents)
[x] Ready for code review

ℹ Additional Information

@ProKil I changed the content of the original stats notebook and provide better guidelines about the redis usage.
Additionally, I create a separate notebook about the serialization process of sotopia.


Feature request: category filters

Currently, users can filter notifications by channel name.
It would be great to have the ability to filter both notifications and broadcast lists by category/game. Very helpful if you are subscribed to a lot of variety-style streamers and never want to see specific games or categories of content.

A new settings section at the bottom of "Notifications" will be added in the next release (1.16). With that, you'll be able to add terms so notifications with categories containing one of them will be ignored.


Accessibility/button test

Summary
This PR aims to add test's for button.
Snapshot test for PR #31001 . This would make sure accessibilityState is properly set.
Changelog

[General] [Added] - Test's for button
Test Plan
npm test to run the test's.
Since the disabled prop of button has precedence over accessibilityState.disabled the test's will make sure it remains this way.

@lunaleaps @kacieb Can you please review this

@huzaifaaak I'll wait for your response from @kacieb's comment before landing.

@lunaleaps I have updated the test structure


Add Preset to metadata

To ensure the Preset is current and not just "last selected," we need to ensure Presets change to Select One when a registered supplier changes.

I don't want to litter the code with with countless classes calling ctl.presets.reset() along every path to a change in acquisition parameters.
What would be slicker would be an AcquisitionParameter class (or superclass?) which could trigger resets in PresetFeature, DarkFeature, ReferenceFeature etc. As an ABC, each could just call self.notify_changed(old=None, new=None). Notifications should include the class name, so ('IntegrationTimeFeature', old=100, new=200). Plugins would be able to subscribe to notifications as well (and issue them?)

resolved in 4.0.67


Separate "any chain" and "best chain" state service functions

Motivation
It's really easy to confuse the "best chain" and "any chain" functions in the state service. (And probably also the non-finalized state.)
For example, the spec for FindBlocks says that we only use the best chain, but in #1347, we used a bunch of "any chain" functions.
It's hard for developers to tell the difference, because they need to read and remember the docs for each function. And it's hard to pick up mistakes in review, because the functions all have similar names.
Potential Solutions
Rename all the chain functions in the state service or non-finalized state, so they contain "best" or "any".
Separate the state service and non-finalized state chain functions into two different structs, "self.best" and "self.any".
Related Tickets
Partly fixed by #1347

#1446 explains this better


multitenacy support

I would suggest implementing multitenacy support

Issue doesn't adhere to the guidelines of creating a proper issue.

Make sure that you are only reporting bugs or submitting feature requests on Github.
In case of feature requests, please be descriptive and explain how this feature helps a broader audience and not just you.

If you are not submitting a bug and neither a feature request, then please use the forum or discord server
In any case, issues which are not descriptive enough will be closed. Please respect our time.


Also, according to @AlekseySh, other commands make upload & make clean should be postfixed with -all as well, see https://docs.google.com/document/d/13c_eYG2v4wNnp9RIhE_gXCSTvEw_i_HQzK7djEsSOjw/


Create a document detailing the branch/release management and PR workflow

OpenEBS community, who are interested in contributing to improving the functionality (code/documentation) should be provided with guidelines on the process followed for raising issues/PRs that involve validating the fixes etc,.
The document also should include details on how the OpenEBS github branches are structured for providing fixes and making releases.

Currently, the releases are made manually by tagging the individual repos. The order followed for tagging is as follows:
(a) openebs/jiva is tagged using the master branch
(b) openebs/external-storage is tagged using the release branch. (This is a fork of the kubernetes-incubator project and the master branch may contain changes that may not be compatible with the current openebs release)
(c) openebs/mayaserver is tagged on master. (This will be replaced in future with a single tag on the repo openebs/maya)
Once the tagged images are available on the docker-hub, update the openebs/k8s/openebs-operator.yaml file with the following:

maya-apiserver and provisioner tags
update the default image env values for jiva image under the m-apiserver section.

The current process is being documented in https://docs.google.com/document/d/1yUqps_Yvg5i1fmu0QOXSAJeK1-H2kkTNaN524y3ko8g/edit.
After the reviews, will need to upload the above into contributor section.


TLS instructions/help

I'm replacing my version of epmdless I got from the erlang solutions post with this library and I'd like to use TLS, however I'm not entirely sure where I would begin there. Via you're instructions:
{epmdless, [
    {transport, tls},
    {listen_port, 17012},
    {ssl_dist_opt, [
        {client, [ssl:ssl_option()]},
        {server, [ssl:ssl_option()]}
    ]}
]}

I put this in my config.exs:
...
config :epmdless,
  transport: :tls,
  listen_port: 17_012,
  ssl_dist_opt: [
    client: [""],
    server: [""]
  ]
...

And that generates correctly during builds:
...
 {epmdless,
     [{transport,tls},
      {listen_port,17012},
      {ssl_dist_opt,[{client,[<<>>]},{server,[<<>>]}]}]},
...

But I'm unsure where I set up TLS for this. is it in the client and server sections of the config, or is it separate? I assume what's being looked for here is something like the following:
SSL_DIST_OPT="server_certfile   erl-dist.pem client_certfile   erl-dist.pem \
              server_keyfile    erl-dist.key client_keyfile    erl-dist.key \
              server_cacertfile ca.pem       client_cacertfile ca.pem       \
              server_verify     verify_peer  client_verify     verify_peer  \
              server_fail_if_no_peer_cert true"

But again, I'm not sure where to put this if this is what is needed. Any chance you could shed some light on this? Any and all assistance would be greatly appreciated. Thank you in advance.

@beardedeagle Thanks for the request. I will send the instructions soon.

@beardedeagle Our production config looks like this:
{ epmdless, [
        {transport, tls},
        {listen_port, 17012},
        {ssl_dist_opt, [
          {server, [
            {cacertfile, "certs/app.crt"},
            {certfile, "certs/client.crt"},
            {keyfile, "certs/client.key"},
            {verify, verify_peer}
            ]},

          {client, [
            {cacertfile, "certs/app.crt"},
            {certfile, "certs/client.crt"},
            {keyfile, "certs/client.key"},
            {verify, verify_peer}
            ]}
          ]}
    ]

I think this can be translated into something like this with Elixir:
config :epmdless,
  transport: :tls,
  listen_port: 17_012,
  ssl_dist_opt: [
    client: [
      cacertfile: "certs/app.crt",
      certfile: "certs/client.crt",
      keyfile: "certs/client.key",
      verify: false
    ],
    server: [
      cacertfile: "certs/app.crt",
      certfile: "certs/client.crt",
      keyfile: "certs/client.key",
      verify: false
    ]
  ]```

@beardedeagle Also I have found a bug in tls backend. https://github.com/oltarasenko/epmdless/pull/12 will address the issue.
For now please test the related branch :(.
Just in case I am using the following snippet to generate self signed SSL certificates: https://github.com/oltarasenko/exgraylog/blob/master/Makefile#L26

@beardedeagle
Ok, I have merged the PR above. And also published the related package to hex. Also as well as the question has appeared I have made a small sample repository to show how to setup epmdless with Elixir and TLS support: https://github.com/oltarasenko/epmdless-elixir-example
Hopefully, it could help you!

@beardedeagle I have decided to keep it open for now. In case you have some additional questions regarding it. Will close the issue by the end of the week if new questions will not appear.

I'm wondering if it would make sense to have epmdless_dist:add_node/2 to have a default for port number as this would make it compatible with other clustering libraries in elixir land.

@beardedeagle I am not sure about it. Let me think a bit. Technically it's easy to do, but...
In general, EPMDLess is used in the cases when we define each node port manually. Every node has own different port in our setup. I just wonder if the default port will give anything to us, as it looks like you will have to specify a port each time?
What do you think?


Terraform libvirt lb fixes

Why is this PR needed?
This PR fixes the terraform-libvirt provisioning when the nodes of the cluster are provisioned in the same way a real SUSE customer would do. That means the nodes are registered against RMT/SCC to get SLE-HA, CaaSP and the containers module packages.
What does this PR do?
Two variables related with load balancer was already available but were not used at all by the terraform states.
With this PR it will be possible to:

Prevent the creation of load balancer nodes (great for small scale testing)
Successfully provision a cluster that is using one or more load balancer

Anything else a reviewer needs to know?
Nothing really special to handle.
Info for QA
Without this PR it's simply impossible to provision a CaaSP cluster using terraform-libvirt by having access only to the same set of resources as our customers do. Right now the CI system is using the terraform-libvirt provider to run our tests, but it's consuming packages from internal private repositories.
This PR allows to provision a cluster by using an official SLE 15 SP1 image and by enabling the CaaSP and SLE-HA products (the latter one is required to have HAProxy).
Status BEFORE applying the patch
It's impossible to:

Create a cluster with 0 load balancer, even when the dedicated terraform variable is set to 0 there's always 1 load balancer used
Successfully run terraform apply when one or more load balancers are created. That happens because the LB node fails provisioning because there's no source to get the haproxy package. That happens because the node is not registered against any SLE repository.

Status AFTER applying the patch
You can deploy a cluster with 0, 1 or more LB nodes.
Docs
Nothing to do, this is not an officially supported deployment mechanism.
Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

@pablochacin, @evrardjp I've updated the PR to allow the creation of 1 or 0 LB. By default 1 LB will be created, the name will be very same one we had before.
I also preserved the output produced by terraform, for example (with flavio-caasp as stack name):
ip_masters = {
  "flavio-caasp-master-0" = "<IP_ADDRESS>"
}
ip_workers = {
  "flavio-caasp-worker-0" = "<IP_ADDRESS>"
}

@flavio I fail to understand why you are removing the load balancer. If not about the changes, but the rational.
I'm concern about introducing some complexity for uses cases that we don't actually have. IIRC we are not shipping this libvirt to customers, are we?
Considering we only support configurations with multiple masters, and LB is required. I don't see the point of having this "feature" which potentially breaks the tests.

I'm concern about introducing some complexity for uses cases that we don't actually have. IIRC we are not shipping this libvirt to customers, are we?

I thought we did, or that we'll do soon.

Considering we only support configurations with multiple masters, and LB is required. I don't see the point of having this "feature" which potentially breaks the tests.

I don't see a reason to force the presence of a load balancer for "test cases" customer environments, which only run one master node. It forces them to have an extra machine, with a license on it, for no valid reason.

I'm concern about introducing some complexity for uses cases that we don't actually have. IIRC we are not shipping this libvirt to customers, are we?

I thought we did, or that we'll do soon.

No, for libvirt, we dont't.

Considering we only support configurations with multiple masters, and LB is required. I don't see the point of having this "feature" which potentially breaks the tests.

I don't see a reason to force the presence of a load balancer for "test cases" customer environments, which only run one master node. It forces them to have an extra machine, with a license on it, for no valid reason.

As per my previous comment, this seems not a valid argument, as we don't ship this to customers.

We don't ship the terraform-libvirt deployment to our customers. That was intended to be used by developers and CI.
As a developer in some cases I want to spare the LB resources so that I can have more worker nodes on my "tiny" workstation.
The code changes introduced to handle the case of having 0 LB are really limited. The majority of the changes are about DRYing up the code (reducing the duplication between the LB cloud-init and the other ones) and making it possible to deploy a system by using official packages (the fact nobody ever noticed this was not possible kinda concerns me).

Rebased the PR against master before doing the merge

@pablochacin I think the failures are unrelated with this PR, they are happening on a VMware cluster.
Can I go ahead and merge this PR?

The code didn't change since the last approval, the failures are unrelated with this PR.
Forcefully merging as discussed with @pablochacin


Partition re-balance issue : 'FAILED to claim the partition'

When I start new process which joins same consumer group is failing with following message.
I think this is because If there are processes that are not released partition while new consumer is spawned.
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] Currently registered consumers: 3
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] logs :: Started topic consumer
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] logs :: Claiming 7 of 20 partitions
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] logs/0 :: FAILED to claim the partition: Cannot claim partition: it is already claimed by another instance
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] logs/9 :: FAILED to claim the partition: Cannot claim partition: it is already claimed by another instance
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] logs/6 :: FAILED to claim the partition: Cannot claim partition: it is already claimed by another instance
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] logs/15 :: FAILED to claim the partition: Cannot claim partition: it is already claimed by another instance
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] logs/3 :: FAILED to claim the partition: Cannot claim partition: it is already claimed by another instance
[Sarama] 2015/05/23 14:28:43 [logstash/2b5ec6db90f5] logs/18 :: FAILED to claim the partition: Cannot claim partition: it is already claimed by another instance

As workaround I have added a time wait here.
   func (cg *ConsumerGroup) topicListConsumer(topics []string) {
	for {
		select {
		case <-cg.stopper:
			return
		default:
		}

This should be fixed now by #68, and #72 will make this way more robust.


Not loaded by lazy, even with "lazy = false", "event = "VeryLazy"" and so son

The plugin is not loaded by lazy.vim, therefore i cannot use it

I don't know why that's happening. Can you try disabling all other plugins to see if it still doesn't load?

Chiming in to point out two things:

A plugin not being loaded by one plugin manager is hardly an issue with the plugin.
I can confirm that the plugin works as expected and is loaded by Lazyvim (so lazy.nvim) with the config that OP provided.

I would consider this user error and close the issue.