FileNotFoundError: [WinError 2] The system cannot find the file specified

Images are generated in the folder specified but FFmpeg throws this error when creating the video.
from stable_diffusion_videos.stable_diffusion_walk import walk

walk(
    prompts=['a cat', 'a dog'],
    seeds=[10, 42],
    output_dir='dreams',     # Where images/videos will be saved
    name='animals_test',     # Subdirectory of output_dir where images/videos will be saved
    guidance_scale=8.5,      # Higher adheres to prompt more, lower lets model take the wheel
    num_steps=5,             # Change to 60-200 for better results...3-5 for testing
    num_inference_steps=50,
    scheduler='klms',        # One of: "klms", "default", "ddim"
    disable_tqdm=False,      # Set to True to disable tqdm progress bar
    make_video=True,         # If false, just save images
    use_lerp_for_text=True,  # Use lerp for text embeddings instead of slerp
    do_loop=False,           # Change to True if you want last prompt to loop back to first prompt
)

Traceback (most recent call last):
  File "c:\python\Projects\stable-diffusion\stable-generator.py", line 3, in <module>
    walk(
  File "C:\python\Projects\Gesture Scrolling\keyvenv\lib\site-packages\stable_diffusion_videos\stable_diffusion_walk.py", line 288, in walk
    return make_video_ffmpeg(output_path, f"{name}.mp4", fps=fps, frame_filename=f"frame%06d{frame_filename_ext}")
  File "C:\python\Projects\Gesture Scrolling\keyvenv\lib\site-packages\stable_diffusion_videos\stable_diffusion_walk.py", line 66, in make_video_ffmpeg
    subprocess.call(
  File "C:\Users\meetg\AppData\Local\Programs\Python\Python39\lib\subprocess.py", line 349, in call
    with Popen(*popenargs, **kwargs) as p:
  File "C:\Users\meetg\AppData\Local\Programs\Python\Python39\lib\subprocess.py", line 951, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Users\meetg\AppData\Local\Programs\Python\Python39\lib\subprocess.py", line 1420, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
FileNotFoundError: [WinError 2] The system cannot find the file specified

Yes, you are correct. From subprocess.py file I  made some temporary changes and everything worked for me.
def __init__(self, args, bufsize=-1, executable=None,
                 stdin=None, stdout=None, stderr=None,
                 preexec_fn=None, close_fds=True,
                 shell="True", cwd=None, env=None, universal_newlines=None,
                 startupinfo=None, creationflags=0,
                 restore_signals=True, start_new_session=False,
                 pass_fds=(), *, user=None, group=None, extra_groups=None,
                 encoding=None, errors=None, text=None, umask=-1):

changed : shell  = True from false

Interesting. That should work on Unix as well right? If so, simple fix here.

@nateraw  yes I think so.

Are there any animation settings for walk() like deforum_stable_diffusion ?


Customizing underlying table names

In the https://github.com/comfy/comfortable-mexican-sofa/blob/master/db/upgrade_migrations/08_upgrade_to_1_12_0.rb migration, tables were switched to be prefixed with 'comfy_'. Has anyone successfully overridden the table names to revert back? When I attempt to change the table names via standard Active Record approach I run into a variety of issues. Before attempting to list each one, is there an easy way to do this documented somewhere I'm not finding?
I'm not very hopeful given I see this table prefix hardcoded in scopes (ie. Comfy::Cms::Page)...
# -- Scopes ---------------------------------------------------------------
default_scope -> { order('comfy_cms_pages.position') }

Any insight would be much appreciated!

Closing super old issue. Generally I'd never attempt to override table names. It just introduces too many problems.


Avoid non-json content conflict in storage on cmd/app/main.go

Ensure that cmd/app/main.go uses a prefix in storage to avoid conflict with non-json content
Closes #36
Signed-off-by: Ricardo Seriani<EMAIL_ADDRESS>

CI failure is unrelated.


Pickr fires "onSave" during construction

Do you want to request a feature or report a bug?
Bug (IMHO)
What is the current behavior?
Pickr fires the onSave event during construction.
If the current behavior is a bug, please provide the steps to reproduce.
Add to gh-page/js/script.js the following lines:
        onSave: function (hsva, instance) {
		console.log("onSave");
	}

Open index.html.
What is the expected behavior?
onSave should not be called (IMHO). It should only be called when the user makes a change.
Your environment:
Pickr-version: master (166ce8d6671be16cf81b7cefa7e29c7b73738490)
Browser-version:  68.0.3440.42 (Official Build) beta (64-bit)
Operating-system:  MacOs

Yeah, im not really sure if i didn't want to call this listener because it's basically a color-changing-action.
For example, if you have a website where you want the ability to choose a custom background and you have a onSave() listener which set it. Then it would, IMO, helpful if it would be fired on initialization.

I totally understand your point. It is sometimes easier, if you intentionally use this behavior in your application logic.
However, this kind of behavior might be non-expected for many developers, since none of the standard HTML inputs works like this. They only fire change events on user interaction, not on initialization, nor on API usage.
Also, if you do not rely on the onSave event being fired at initialization time, you may have to filter it out for performance reasons or for null-pointer prevention. That's what is happening in my case:
// inside class constructor:
this.pickr = createPickr({
    ...
    onSave: (hsva, instance) => {
	if (this.pickr != null) { // pickr is currently initializing, I cannot use it (nullpointer exceptions)
            this.methodUsingPickr(); // do something using this.pickr (not instance!)
        }
    },
});

Looks good. I will test it on Monday. Thank you!!


Copy-PnPFile and Move-PnpFile create new file when parameter -overwrite is used

When Copy-PnPFile and/or Move-PnPFile is used with the parameter -overwrite SharePoint deletes the old file and creates a new one resulting in a new file ID.
Let's say you want to copy "/sourcefolder/myfile.pdf" to "/targetfolder/myfile.pdf" and "myfile.pdf" in the targetfolder has ID 4, then SharePoint will delete the targetfile and create a new file with the same name, but obviously with the next available ID.

@Mark-227 - Please DO NOT delete the template when creating an issue. It's there to be filled.

What version of PnP.PowerShell are you using?
Which OS?

Sorry about that.
PnP Version is the latest 1.7
OS is Windows 10

@Mark-227 - I've tested both (PS and SPO UI) and this is the same behaviour as if you were using the interface. So nothing we can do unfortunately.


Server Docker Container Build

Hi,
This pull request has a working dockerfile for the server component, building on the work done in the coding club session on Friday.  It also includes a docker compose file with the docker run settings included, so getting it built and running with ports mapped is just
cd src/server
docker compose up

I hope this is helpful.
Best wishes,
Nick

Nice thanks everyone :)


Add dark mode feature

I added a dark mode feature, adding a dynamic button on the sidebar, and using tailwind dark mode class system.
Here are the previews :

What needs to be done to perfect :

Polish the colors. I made some decisions about the colors, to keep the blue spirit, and for the moment I am satisfied with the result. However, there are some colors that I didn't change (for example the orange one).
Rework the gifs and images to not have the white border, which is really ugly in dark mode (that is the number 1 priority)
Rework the Light logo to have a transparent background

Otherwise I am satisfied about how it turned, it may not be perfect, but it is better than nothing.
I also integrated a new sunIcon, taken from https://tablericons.com/, a really cool website with a lot of open source icons.
this pull request directly respond to the issue #387

amazing, thanks!

Is the PR ready for review @tomasoignons?

Great! In general you can re-request a review via github when you're done addressing comments to let the reviewer know it's ready for another review round.

thanks!


Cannot switch browser language

Describe the bug
Can't download language when selecting non-device default language
To Reproduce
Go setting and select a language
Expected behavior
Language changed.
Screenshots

Smartphone (please complete the following information):

Device: Google Pixel 6 Pro
Android Version : A13.TQ1A.20230205.002
Kiwi Browser Version: 107.0.5304.74

Swipe up the language you want to use by clicking three dotted thing.

Latest Kiwi v116 have this fixed . Can you confirm if it's fixed for you too ?

I have just updated kiwi to v116.0.5845.22 from play store.
On my device it's NOT fixed: I don't get the error in the screenshot.
Kiwi says to restart but after restart the language is not changed.

Same error with version 116.0.5845.26

Same error with version 124.0.6327.4 on Android 12


Skip tasks triggered by all_success if any upstream task is skipped

https://github.com/airbnb/airflow/issues/718

![img] (http://reactiongifs.us/wp-content/uploads/2013/02/youre_awesome_carl_sagan.gif)


feat: add :focus-within style to .input

As discussed here
https://github.com/saadeghi/daisyui/discussions/2350

Thank you.


[BUG] permify cannot handle Uint64 for uint IDs

Describe the bug
When I try to use a uint taken from a unit64 as a user ID in UserHasAnyRoles(id, "admin"), I get the following error:
/go/pkg/mod/github.com/!permify/permify-gorm@v1.0.0/repositories/userRepository.go:199 failed to encode args[0]: unable to encode 0xe40e81495b2643ba into binary format for int8 (OID 20):<PHONE_NUMBER>2383348666 is greater than maximum value for int64
[0.643ms] [rows:0] SELECT count(*) FROM "user_roles" WHERE user_roles.user_id =<PHONE_NUMBER>2383348666 AND user_roles.role_id IN (1)

Versions
Permify-gorm version: 1.0.0
Go version: 1.20
Gorm version: v1.25.0
Database driver name: gorm.io/driver/postgres v1.5.2
Database version: 15.3
To Reproduce
Steps to reproduce the behavior:
import (
	"github.com/google/uuid"
	"encoding/binary"
	permify "github.com/Permify/permify-gorm"
)

func UintFromUUID(id uuid.UUID) uint {
	return uint(binary.BigEndian.Uint64(id[:8]))
}
_, err := permify.UserHasAnyRoles(UintFromUUID(claim.ID), "admin")
// err != nil

Expected behavior
UserHasAnyRoles should work since the PG DB column is BIGINT which is 64 bits in size and my code produces a uint based on a 64bit integer.
Additional context
Add any other context about the problem here.
Environment (please complete the following information, because it helps us investigate better):
I'm using golang:1.20.3-alpine3.17 Docker image

Might be related to this issue: https://github.com/jackc/pgx/issues/1051


Azure blob storage filter by lease status

Hello Team,
I was wondering if there was an option to filter the blobs available in a container by its lease status using the listBlobs operation.
Thanks,
Viswanath V

Thank you for opening this issue, we will look into it.

Hi @ViswanathVeerappan, you can try with the --query param with something like this. az storage blob list --account-name satestquery -c container1 --query "[?properties.lease.status=='unlocked']"
here is the link to how to format the query for the specific status needed https://learn.microsoft.com/en-us/cli/azure/query-azure-cli?tabs=concepts%2Cbash#filter-arrays-with-boolean-expressions

Hi @calvinhzy, I'm using the Java client library and within the library, I've a couple of options to find the blobs associated with a container.

listBlobs() => does not have a way to send query to filter the blobs by properties or lease state in particular
findBlobsByTags => would take a query, but it would only search by tags added by a user.

Please help me find the appropriate api which would help me fetch blobs by lease state or in general the properties of a blob.
FYI, The following are the library details used in my application,

com.azure
azure-storage-blob
12.16.1

com.azure
azure-core
1.28.0

Hi @ViswanathVeerappan as far as I can see, the Python SDK does not have a way to filter on the service side. The filtering would need to be done through custom client code. Feel free to open an issue with the sdk team https://github.com/Azure/azure-sdk-for-java/issues/new?assignees=&labels=&projects=&template=feature_request.md&title=[FEATURE+REQ] and they might have some more insight as to when this filter option would be added.

Hi @calvinhzy, Thanks for your response. I have created a feature request for this here.
Thanks,
Viswanath V

Glad I could help! Thanks.


use open source util for email verification

use open source util for email verification
WHAT DOES THIS PR DO?
use open source util for email verification
Context: we were using a paid for version whose "free" units have expired.
We now need to quickly switch to this version asap.
WHAT JIRA STORY/TASK IS RELATED TO THIS PR?

README of the auth-service
WHICH ENDPOINTS SHOULD BE READY FOR TESTING?:
Request access endpoint. Test with wrong email addresses, eg<EMAIL_ADDRESS>IS THERE ANY JENKINS CONSOLE LINK FOR CODE COVERAGE AND BUILD INFO?
N/A
ARE THERE ANY RELATED PRs?
N/A

What verifications does it perform?? I tested with<EMAIL_ADDRESS>and I was successful. Looks like it only checks if the domain is valid
Getting some errors in the console

@Baalmart


Update detailed_workflow.ipynb

time_per_step bug.

Description

Wrong config of time_per_step in port_analysis_config.
Motivation and Context

There is a bug in detailed_workflow.ipynb.
How Has This Been Tested?

[x] Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
[ ] If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

Pipeline test:
Your own tests:

Types of changes

[x] Fix bugs
[ ] Add new feature
[ ] Update documentation

Thanks!  It looks great!


Version 2 angie

@gr2m
Can you help us figure out how to display the diff?

@gr2m Yup! That totally works.  Do you have any other feedback?

you can use template literals for the issue body, see https://github.com/hoodiehq/first-timers-only-bot/pull/63/files

Not sure what you mean by making "Update the file" dynamic?

Ignore me, it already is dynamic, it’s only not dynamic in my own PR (#63), I’ll fix it there, too

fixed it in my PR

Is version 2 done :grin: ?

yes, let’s merge it 🎉
Only bit missing is

show a link to the created issue so it can be reviewed and edited if needed

but let’s do that in a follow up pull request

Wooo!
The link to the issue should show up in the index.html page after submitting the link to the branch.

you are right! How could I miss that? W00p w00p, great work :)


Streaming inputs

Hi, I'm curious to know whether you or colleagues have implemented a streaming implementation for your QAData class.  My inputs are too large to fit in RAM and I'm looking to find a way to change get_fold_data to return an iterator.

Unfortunately not.
I believe it would require additional changes when building the vocab. Currently the software builds the vocab dynamically after we read the full dataset. In your case with streaming data, you would need to build the vocab with another method (e.g. by reading an external vocab file, using everything in the embeddings file, etc.).
Also, the training procedure would have to change. Right now we are doing negative sampling from the whole training set at runtime. With streaming data you probably would need to build these samples in the data generator (we create them in the training module).

Thanks, I'll look into making these changes.


Updated Salesforce for Heroku and Datorama

🗣 Description

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge checklist

[ ] Revert dependencies to default branches.
[ ] Finalize version.

✅ Post-merge checklist

[ ] Add a tag or create a release.

Remaining two Salesforce products have been checked/updated with this PR


This would be a great BOINC project

http://boinc.berkeley.edu/
Make the job run a specified period of time then report back what it finds via BOINC. Throw out duplicates and assign potential new bugs to another client for verification, or do that locally.

Closing as no work on this planned in foreseeable future. If somebody wants to work on this feel free to reopen.


tests: 🍼 a placholder abci application for mock consensus engine development

stub issue.
see #3588.
before we can connect the mock consensus engine up to pd itself, we should define a very very simple abci app to act as a placeholder for its own tests & development.
the cometbft repository has an example key-value store, for example. for our sake, we can probably implement something even more straight-forward than that.

Is there a particular reason we don't want to start using the Penumbra App itself? It lives in the same repo, and it would ensure that we're designing against our actual requirements. We even already have a test that we could write a second version of using our new framework (app/src/tests/spend.rs).

closing out, #3788 will track porting the existing spend.rstest!


[Blazor webassembly] library not working with linker disabled

Hello and thanks for your work ! I use your library in one of my blazor webassembly project, but it seem not working when the linkler is disabled
You will find a reproduction project here : https://github.com/julienGrd/blazorWebassembly3.2Preview1

run the app
go to fetch data
open the  chrome console, you will see this exception

System.TypeInitializationException: The type initializer for 'System.Linq.Dynamic.Core.DynamicQueryableExtensions' threw an exception. ---> System.Exception: Specific method not found: All ---> System.InvalidOperationException: Sequence contains no matching element

It seem this issue is related to this one on mono, if it can help : https://github.com/mono/mono/issues/12917
if you disable the linker(in the webassembly csproj) there is no longer problem, but it's not a good thing and make the app bigger
 <PropertyGroup>
    <BlazorWebAssemblyEnableLinking>false</BlazorWebAssemblyEnableLinking>
  </PropertyGroup>

thanks for your help !

Is this something which can be fixed by this library, or just as notification?

I'm not really sure... at the end of the issue (this one https://github.com/mono/mono/issues/12917) they speak about a PreserveDependencyAttribute which can be add to solve the problem but we have a lack of information. So if you understand what they speak about in the issue maybe you can make something but otherwise i will wait for more information.

If that property solves the issue, that means that property should be defined in the calling application, cannot be defined in this project.
I think...

apparently the guys of mono back to us in the month to explain, we will see at this moment.
Im not the only who use this library in blazor webassembly app so anyway it can be nice to put the solution here, even if it impact only the calling app and not the library itselve

Hi @julienGrd. You should be able to configure the linker for your library by embedding an XML linker config file into the library. I've put together a sample that shows how to do this here: https://github.com/danroth27/ComponentLibWithXmlLinkerConfig. Could you please try this out and see if it works for your scenario?

Hi @danroth27 , thanks it seem work perfectly ! just an important thing to make it works, i have to add the file at the project but also edit the csproj to add this directive (like your project)
<ItemGroup>
        <EmbeddedResource Include="LinkerConfig.xml">
            <LogicalName>$(MSBuildProjectName).xml</LogicalName>
        </EmbeddedResource>
    </ItemGroup>

Is this file not impact other .NET standard type of project?  because its not a blazor specific library !
@StefH : OK to add this to your project ? otherwise it seem i can make it directly on my client project

Is this file not impact other .NET standard type of project? because its not a blazor specific library !

All this is doing is embedded the XML linker config file into the assembly. This file will get picked up appropriately by the .NET IL linker wherever it gets used, including Xamarin apps and standalone .NET Core desktop apps. For apps that aren't using the linker this file is completely benign.

@danroth27 finally It seem not enough with this library. I fall into another problems when i try to use dynamic group by.
To reproduce :

open your ComponentLibWithXmlLinkerConfigproject
put this piece of code on the Initialized of your component
var test = people.AsQueryable().GroupBy("Name").ToDynamicList<IGrouping<dynamic, Person>>();

you will have this error :
blazor.webassembly.js:1 WASM: System.TypeInitializationException: The type initializer for 'System.Linq.Dynamic.Core.DynamicEnumerableExtensions' threw an exception. ---> System.InvalidOperationException: Sequence contains no matching element
blazor.webassembly.js:1 WASM:   at System.Linq.Enumerable.First[TSource] (System.Collections.Generic.IEnumerable`1[T] source, System.Func`2[T,TResult] predicate) <0x21b7380 + 0x00022> in <filename unknown>:0
at System.Linq.Dynamic.Core.DynamicEnumerableExtensions..cctor () <0x21b6f98 + 0x0002a> in <filename unknown>:0

What is strange, is im unable to reproduce this error when i reference the csproj of this project, its only when i reference the nuget package.
@StefH  : some idea on this ?

@julienGrd Makes sense - the type initializer for DynamicEnumerableExtensions uses reflection: https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/src/System.Linq.Dynamic.Core/DynamicEnumerableExtensions.cs#L16-L20. You could address this by updating the xml linker config to preserve the DynamicEnumerableExtensions type.

Yes i was thinking was something like that, i still don't really understand how to use the linker :-/. i try both these configuration without make it work
  <assembly fullname="System.Reflection">
    <type fullname="System.Linq.Dynamic.Core.DynamicEnumerableExtensions" preserve="all" />
  </assembly>

<assembly fullname="System.Runtime">
    <type fullname="System.Linq.Dynamic.Core.DynamicEnumerableExtensions" preserve="all" />
  </assembly>

@julienGrd DynamicEnumerableExtensions lives in the System.Linq.Dynamics.Core assembly, not System.Runtime.

ok it works perfect ! i will be happy to have some documentations about the linker when it will be possible !
Thanks for your help i will close this issue.
@StefH if you still want include by default this configuration to make it works in mono projects without client configuration, i can suggest a PR. just reopen this issue and say me.

@julienGrd Docs on how to configure the linker for libraries are in the works: https://github.com/dotnet/AspNetCore.Docs/issues/17369

the final solution to make it works, on the library or on the client project
Linker.xml
<?xml version="1.0" encoding="utf-8" ?>
<!-- IL linker format: https://github.com/mono/linker#link-xml-file-examples -->
<linker>
  <assembly fullname="System.Core">
    <type fullname="System.Linq.Queryable" preserve="all" />
  </assembly>
  <assembly fullname="System.Linq.Dynamic.Core">
    <type fullname="System.Linq.Dynamic.Core.DynamicEnumerableExtensions" preserve="all" />
  </assembly>
</linker>

csproj
<ItemGroup>
    <None Remove="LinkerConfig.xml" />
  </ItemGroup>
  <ItemGroup>
    <EmbeddedResource Include="LinkerConfig.xml">
      <LogicalName>$(MSBuildProjectName).xml</LogicalName>
    </EmbeddedResource>
  </ItemGroup>

Please make a PR.

Please make a PR.

perfect ! i will do this these next days !

And when this is done; I need to update the Wiki.
Also: can you include a full working example blazor project? Place this in a new src-blazor folder.

yes it's a good idea !Do you want some specific test in the blazor project ? or a simple dynamic order by on a table is OK for you ?

Keep it simple.

closing issue because PR is merged to master


Add several ini options for .bandit file

If Bandit actually supports an ini file why not use it for (almost) all the available CLI options?!

Hey @ericwb thanks for merging my changes and ofc sorry I can reply to you only now.
I see you already added all the options I forgot, so I think that's all done, am I wrong?
Bye.

@vuolter No worries.  You're all good.  Thanks for the contribution!


circular_queue using Java

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Description
(Write your answer here.)
Checklist

[X] I've read the contribution guidelines.
[X] I've checked the issue list before deciding what to submit.
[X] I've edited the README.md and link to my code.

Related Issues or Pull Requests
#1741
(Write your answer here.)

@shraddhavp, please review

@shraddhavp, please review

Closing the PR cause of no updates. Let me know if you would like this to be reopened.

Closing the PR cause of no updates. Let me know if you would like this to be reopened.

@HarshCasper , please reopen this PR, I will do the changes. And sorry for delay.


Fix 300s timeout for grpc streams

Disable idle timeouts in HTTP connection manager that causes idle gRPC streams to be terminated every 5 minutes. Along the way, also updated some deprecated fields.
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
033025af0891507f4d992cb03480ef7c7eee184b
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
033025af0891507f4d992cb03480ef7c7eee184b
link
/test istio-unit-tests

prow/istio-presubmit.sh
033025af0891507f4d992cb03480ef7c7eee184b
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
033025af0891507f4d992cb03480ef7c7eee184b
link
/test istio-presubmit

prow/istio-unit-tests.sh
7f5c0c3be71d8ee6275c0a82cafcaadad6d51f22
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
7f5c0c3be71d8ee6275c0a82cafcaadad6d51f22
link
/test istio-unit-tests

prow/istio-presubmit.sh
7f5c0c3be71d8ee6275c0a82cafcaadad6d51f22
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7f5c0c3be71d8ee6275c0a82cafcaadad6d51f22
link
/test istio-presubmit

prow/istio-unit-tests.sh
46141da3b94d27663feff20019a0a6b15bdb9859
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
7f5c0c3be71d8ee6275c0a82cafcaadad6d51f22
link
/test istio-presubmit

prow/istio-unit-tests.sh
3e7f5580c5726365d74f837011f45f88fd7ea7c1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3e7f5580c5726365d74f837011f45f88fd7ea7c1
link
/test istio-unit-tests

prow/istio-presubmit.sh
3e7f5580c5726365d74f837011f45f88fd7ea7c1
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
3e7f5580c5726365d74f837011f45f88fd7ea7c1
link
/test istio-presubmit

prow/istio-unit-tests.sh
19ab689e326cc5ca019959bb0f69c51a67206677
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
19ab689e326cc5ca019959bb0f69c51a67206677
link
/test istio-unit-tests

prow/istio-presubmit.sh
19ab689e326cc5ca019959bb0f69c51a67206677
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

seems to fail pretty badly - does it depend on a new envoy ?

/retest

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ijsnellf or @GregHanson could you please help with the PR?

All prow errors: “error	Failed to complete Init. Error istio-ingressgateway readiness check timed out”

/retest

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test

/test
(merged Envoy)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Tried to merge head so circle has the last version of envoy.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-mixer-no_auth.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-mixer-no_auth

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

prow/e2e-dashboard.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

prow/e2e-dashboard.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
22da7ff8e82b528ae4ccbf7d4176f27606ad9d73
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

prow/e2e-dashboard.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

prow/e2e-dashboard.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

prow/e2e-bookInfoTests-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-dashboard

prow/e2e-mixer-no_auth.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-mixer-no_auth

prow/e2e-bookInfoTests-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
add68026319055eae72d83abe2bc4a7ac6e04c75
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

From the failed simple test:
Pilot logs - shows a disconnect immediately after the RDS push:
2018-07-28T00:13:58.976529Z	info	ads	CDS: PUSH for istio-egressgateway-777f778c89-sgdxh.istio-system "<IP_ADDRESS>:53508", Clusters: 40
2018-07-28T00:13:59.120760Z	info	ads	LDS: PUSH for node:istio-egressgateway-777f778c89-sgdxh.istio-system addr:"<IP_ADDRESS>:53508" listeners:0
2018-07-28T00:14:13.974945Z	info	ads	ADS:CDS: REQ router~<IP_ADDRESS>~istio-ingressgateway-68f6748d46-gfcnb.istio-system~istio-system.svc.cluster.local-4 <IP_ADDRESS>:55018 raw: node:<id:"router~<IP_ADDRESS>~istio-ingressgateway-68f6748d46-gfcnb.istio-system~istio-system.svc.cluster.local" cluster:"istio-ingressgateway" metadata:<fields:<key:"ISTIO_PROXY_SHA" value:<string_value:"istio-proxy:efb5224d4b2249ff3894d989ff7355bb62d8af3e" > > fields:<key:"ISTIO_PROXY_VERSION" value:<string_value:"1.0.0" > > fields:<key:"ISTIO_VERSION" value:<string_value:"1.0-dev" > > fields:<key:"POD_NAME" value:<string_value:"istio-ingressgateway-68f6748d46-gfcnb" > > fields:<key:"istio" value:<string_value:"sidecar" > > > build_version:"0/1.8.0-dev//RELEASE" > type_url:"type.googleapis.com/envoy.api.v2.Cluster"
2018-07-28T00:14:14.014747Z	info	ads	CDS: PUSH for istio-ingressgateway-68f6748d46-gfcnb.istio-system "<IP_ADDRESS>:55018", Clusters: 40
2018-07-28T00:14:14.098806Z	info	ads	LDS: PUSH for node:istio-ingressgateway-68f6748d46-gfcnb.istio-system addr:"<IP_ADDRESS>:55018" listeners:1
2018-07-28T00:14:14.180048Z	info	ads	ADS: RDS: PUSH for node: istio-ingressgateway-68f6748d46-gfcnb.istio-system addr:<IP_ADDRESS>:55018 routes:1
2018-07-28T00:14:27.978374Z	info	ads	ADS: "<IP_ADDRESS>:55018" sidecar~<IP_ADDRESS>~echosrv-deployment-2-799cd8d8bd-2sdfp.istio-system~istio-system.svc.cluster.local-2 terminated rpc error: code = Canceled desc = context canceled
2018-07-28T00:14:27.978482Z	info	ads	ADS: "<IP_ADDRESS>:55018" router~<IP_ADDRESS>~istio-ingressgateway-68f6748d46-gfcnb.istio-system~istio-system.svc.cluster.local-4 terminated rpc error: code = Canceled desc = context canceled

Envoy logs for ingress:
[2018-07-28 00:14:14.090][51][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:388] add/update cluster outbound|9102||istio-statsd-prom-bridge.istio-system.svc.cluster.local during init
[2018-07-28 00:14:14.092][51][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:388] add/update cluster outbound|9125||istio-statsd-prom-bridge.istio-system.svc.cluster.local during init
[2018-07-28 00:14:14.092][51][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:388] add/update cluster BlackHoleCluster during init
[2018-07-28 00:14:14.092][51][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:110] cm init: initializing secondary clusters
[2018-07-28 00:14:14.095][51][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:133] cm init: all clusters initialized
[2018-07-28 00:14:14.095][51][info][main] external/envoy/source/server/server.cc:390] all clusters initialized. initializing init manager
[2018-07-28 00:14:14.175][51][info][upstream] external/envoy/source/server/lds_api.cc:73] lds: add/update listener '<IP_ADDRESS>_80'
[2018-07-28 00:14:14.180][51][info][config] external/envoy/source/server/listener_manager_impl.cc:903] all dependencies initialized. starting workers
[2018-07-28 00:14:17.178][51][info][main] external/envoy/source/server/drain_manager_impl.cc:63] shutting down parent after drain
[2018-07-28 00:14:27.977][51][warning][upstream] external/envoy/source/common/config/grpc_mux_impl.cc:240] gRPC config stream closed: 13,
[2018-07-28 00:19:08.103][51][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:394] add/update cluster outbound|80||a.istio-system.svc.cluster.local starting warming

Something is wrong here with envoy - it also took 5 min to reconnect.

+Piotr and Lizan - it seems the fix for envoy made things worse ? Or the max connection fix doesn't work.

It appears setting IdleTimeout results in envoy closing the connection after LDS is received, and
not connecting for 5 min.
[2018-07-29 03:44:46.473][51][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:133] cm init: all clusters initialized
[2018-07-29 03:44:46.473][51][info][main] external/envoy/source/server/server.cc:390] all clusters initialized. initializing init manager
[2018-07-29 03:44:46.553][51][info][upstream] external/envoy/source/server/lds_api.cc:73] lds: add/update listener '<IP_ADDRESS>_80'
[2018-07-29 03:44:46.561][51][info][config] external/envoy/source/server/listener_manager_impl.cc:903] all dependencies initialized. starting workers
[2018-07-29 03:44:49.558][51][info][main] external/envoy/source/server/drain_manager_impl.cc:63] shutting down parent after drain
[2018-07-29 03:45:00.711][51][warning][upstream] external/envoy/source/common/config/grpc_mux_impl.cc:240] gRPC config stream closed: 13,
[2018-07-29 03:49:58.276][51][info][upstream] external/envoy/source/common/upstream/cluster_manager_impl.cc:394] add/update cluster outbound|80||a.istio-system.svc.cluster.local starting warming

Removing that line seems to get the tests to pass.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]
tests/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
69adfb10a34e79152a086d025bbfcafaf4482952
link
/test istio-presubmit

prow/istio-unit-tests.sh
13536bc06df3517227d9753989fa8b2e406ad0d2
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
13536bc06df3517227d9753989fa8b2e406ad0d2
link
/test istio-unit-tests

prow/istio-presubmit.sh
13536bc06df3517227d9753989fa8b2e406ad0d2
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
5825a020f7905a076d02e3f23ffbde08034626ac
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-simple


Updated regular expression for sub word matcher and added additional …

…tests
Subword matcher can now correctly match tokens like:
"mockAPIClient123Factory" => ["mock", "API", "Client", "123", "Factory"]
Fixes issue #79

@pokey @brxck
FYI deepStrictEqual has arguments (actual, expected) which is a bit unusual ordering.

@pokey @brxck
FYI deepStrictEqual has arguments (actual, expected) which is a bit unusual ordering.

yeah that's def unexpected but good to know


Snapchat

cf-st.sc-cdn.net should be whitelisted, since it is required for Snapchat stories and picture embeds to load.

Is it blocked by default adlsits?

Oops seems that it isn't.


[MRG] Update to JupyterLab 4

Extract the part of https://github.com/jupyterhub/repo2docker/pull/1302 to update to JupyterLab 4, without the Notebook 7 update.

jupyter-server version to 2.x (how much of a breaking change is this?)

The default CMD still launches the old server via jupyter notebook it seems though?
https://github.com/jupyterhub/repo2docker/blob/f667caf49c9f199304b210b6643771b4c7a08053/repo2docker/buildpacks/base.py#L194

Support for python 3.7 in the base environment is now gone. How does this affect repos that specify python 3.7?

Python 3.7 reached end of life in June 2023: https://github.com/jupyterlab/jupyterlab/pull/13745. JupyterLab 4 requires Python 3.8 now.

jupyterlab to 4.x (so some extensions would break)

Yes, although many have been updated now: https://github.com/jupyterlab/jupyterlab/issues/14590
Also JupyterLab 3 will reach end of maintenance soon: https://github.com/jupyterlab/jupyterlab/issues/15921

How does this affect repos that specify python 3.7?

They are unaffected at the moment. As this PR stands, 3.7 stops getting updates, but continues to be supported for the server environment.
The next stage of reduced support is bumping kernel_env_cutoff_version to 3.8, at which point 3.7 becomes a 'kernel-only' version, like 3.6 and older. I think would be reasonable to make this change here as well, but not required.
Pro bumping kernel_env_cutoff:

all installs get the same jupyterlab/server versions
we will need to make this transition eventually, when e.g. a security requirement requires bumping a no-longer-supported package

Con:

bigger, more disruptive change for 3.7-using repos

Since there is no visible effect on 3.7 repos, I think it's fine to merge this as-is.

This may break users who are installing extensions which aren't compatible with JupyterLab 3. I think we should make an announcement on https://discourse.jupyter.org before merging.

announced: https://discourse.jupyter.org/t/ann-repo2docker-upgrading-to-jupyterlab-4/25845

Thanks @jtpio and @minrk :)


DocumentParser drops whitespaces at the beginning of a line

When using DocumentParser with no enabled block types, the Text nodes do not include whitespaces at the beginning of a line.
For example, when we use a parser with no enabled block types and the input is:
- text 1
  - text 2

the expected result is a document containing two Text nodes:

Text("- text 1")
Text("  - text 2")

but the second Text is "- text 2" (without preceding whitespaces)
To better illustrate here is a sample test that fails:
public class ParserTest {

    ...

    @Test
    public void noBlockTypes() {
        String given = "- text 1\n  - text 2";
        Parser parser = Parser.builder().enabledBlockTypes(Collections.<Class<? extends Block>>emptySet()).build();
        Node document = parser.parse(given);

        Node child = document.getFirstChild();
        assertThat(child, instanceOf(Paragraph.class));

        child = child.getFirstChild();
        assertThat(child, instanceOf(Text.class));
        assertEquals("- text 1", ((Text) child).getLiteral());

        child = child.getNext();
        assertThat(child, instanceOf(SoftLineBreak.class));

        child = child.getNext();
        assertThat(child, instanceOf(Text.class));
        assertEquals("  - text 2", ((Text) child).getLiteral());
    }
}

The reason for this is the paragraph parser. The spec says that leading whitespace is skipped: https://spec.commonmark.org/0.31.2/#example-222
Not sure how we would handle it. We can't add the leading whitespace to the literal of Text nodes as that would change rendering for existing code, but maybe we could add it as another attribute.
Note that you should be able to work around this limitation by checking the source spans of the text (see includeSourceSpans on Parser.Builder).

See also https://github.com/commonmark/commonmark-java/pull/290#issuecomment-1986613844


Notify GHA results in slack

Let's send the result of publish and test pipelines to #teamg-bots-releases and #teamg-bots-ci channels accordingly

A PR has been opened. Working on a slightly better message for the test workflow.


👋Bye Bye local PKI

We no longer build a local PKI, so this directory is confusing (and terrifying).
We'll either replace this with gsp-local or a sandbox dev instance.

I'm thinking of writing a script to spin up the PN locally - either by using pure Docker or some simple K8 cluster. Could any of the stuff be useful for that? Or should we just use the sandbox dev?

We'll keep it for now as we may need to re-use it


N-Stat sorting improvement for Type X measures (and others?)

Brief description
Sorting by N-stat appears to only consider the first triplet of a TypeX msr.
If a high N-stat value appear further down a Type X msr group, the entire Type X msr is reported too far down the sorted N-Stat list.
Feature improvement request: Consider N-stat value of all measurement components when sorting. (all measurement types).

Basic requirements
N-Stat sorting to account for all measurement components, for all measurement types.
Priority
Priority 2 (medium)] / Priority 3 (low)

Placing this example in support of the above. Note two highlighted nstats within the X-cluster msr which have absolute values larger than the max nstat of several earlier measurements.

In preparation for testing a new release candidate,
I confirm here for current release v1.2.7

--sort-adj-msr-field 7 (sort by Nstat)
The issue described above persists:
Sort order is as expected for all msr types here tested (DEHGXY)
Undesirable: Xmsr sort only on the first triplet in the msr

--sort-adj-msr-field 6 (sort by Adjusted std dev)  (tested on request)
Sort order is as expected for all msr types here tested (DEHGXY)
Dmsr (all angular msr?) sort as a separate section at the bottom of the list (due to nature of msr quantity)
Xmsr sort in the correct fashion (this was unexpected, given (1) above)
Undesirable: Dmsr do not all sort as expected

--sort-adj-msr-field 5 (sort by Measurement Correction)  (tested on request)
Undesirable: Sort order is not as expected. Sorting criteria are not obvious across several msr types

Testing of v.1.2.8-rc5 indicates that the above issues are all RESOLVED.

--sort-adj-msr-field 7 (sort by Nstat)
Sort order is as expected for all msr types here tested (DEHGXY).
Xmsr now sort as expected.

Sort order is as expected for all msr types here tested (DEHGXY).

--sort-adj-msr-field 6 (sort by Adjusted std dev)
Sort order is as expected for all msr types here tested (DEHGXY).
Dmsr now sort as expected
Note: Dmsr (all angular msr?) sort as a separate section at the bottom of the list

--sort-adj-msr-field 5 (sort by Measurement Correction)
Sort order is as expected for all msr types here tested (DEHGXY).
Note: Dmsr (all angular msr?) sort as a separate section at the bottom of the list


Vocabulary CDN for styles not found

Description
The CC Search browser Extension uses the following cdn for vocabulary styles https://unpkg.com/<EMAIL_ADDRESS>It is not working and thus the styles in the production version of the extension are not rendering. This is a problem because even if we change the CDN link with an updated one and push a new version of the extension to the store, it will take more than a week to pass the evaluation process of the various browser extension stores
Reproduction

Open the options page of the CC Search extension.

Expected behavior
The full options page must be rendered with Vocabulary styles.
Screenshots

@dhruvkb a gentle ping...

@makkoncept sorry for not noticing early. To account for the repo split, please update the URL to https://unpkg.com/@creativecommons/vocabulary.

@dhruvkb I understand, but can there be some temporary solution right now because as I mentioned that it will take at least 1 week before the chrome and firefox browser extension store verifies and pushes the new update.

Yes, I am out right now, but you should see it working in a few hours. I'll get home and immediately push a temporary update to the package. Meanwhile do update the URL and submit it for verification, approval and push.

Okay, thanks!

Pushed an update and @kgodey tells me that it is working now. In the meantime, however, you should change the URL as soon as possible. I'd recommend you set it to https://unpkg.com/<EMAIL_ADDRESS>as that is the last release before backwards-incompatible, breaking changes were made to the repositories.


Remove refcount pruning pass

because it is no longer valid. The pass was introduced in https://github.com/numba/numba/pull/2352 to avoid NRT-ops if the function doesn't need it. However, it's no longer possible to detect; at least with the current way we emit the LLVM-IR.
This fixes https://github.com/numba/numba/issues/5335, which provides a use-case where the @intrinsic added a hidden use of NRT allocation not observable from the pruning pass.

Note, the consequences of this PR is that https://github.com/numba/numba/issues/2350 will become a problem again

Some tests are failling. I think the pass was hiding refcount errors in simple array tests.

Performance vs leaks, I'd rather stop it leaking and dedicate time to an LLVM pass?

https://github.com/numba/numba/pull/5338#issuecomment-593966746
agree

Assuming this passes CI, this looks good.

#5338 (comment)
agree

Right, let's proceed with acknowledgement that we do correctness over performance, and we know how to fix the performance. Schedule that for Q2.


s32k1 EDMA clean up and loop support

Summary

Added DMAMUX for S32k146
Fixed missing comment S32K1XX_DMAMUX_CHCFG macro
EDMA Fix access violation causing resets and hardfaults due to 32 bit access to 8 bit registers.
HW TCD reset of DLASTSGA is 32 Bits.
Fixed initialization so the s32k1xx_dmach_getcount reports 0 when Done.
TCD has to be 32 byte aligned to work with Scatter Gather
ttype was removed - it was used to apply dcache operation on external buffers, but the API does not know the buffer extent, so it is better to do the dcache operations in the code that owns the buffers.
Added source or destination looping. Useful for non binary or large sided circular buffers.
Added Interrupt on Half or Major loop completion.
Scatters gather supports Single interrupt at the end.
Order of operations on the HW TCD were corrected.
DMA Termination order of operations changed to be able to get meaningful status on DMA completion or Error
DMAMUX selection left disabled until used

More driver dependent on this to follow
Impact
It will compile now and now work.
Testing
Tested on PX4 nxp_ucans32k146

@pkarashchenko rebased on master - hopefully the unrelated xtensa CI fail will have been resolved

@pkarashchenko or @xiaoxiang781216 - Please merge


Build instructions for nvml go bindings needed

I am unable to build go software against the nvml go bindings due to the following error:
/tmp/go-build280384238/b001/exe/build: symbol lookup error: /tmp/go-build280384238/b001/exe/build: undefined symbol: nvmlDeviceGetCount_v2

Can anyone provide guidance on the explicit packages and requirements to compile this code.
I am installing the following packages cuda-nvml-dev-8-0 and nvidia-cuda-dev
One thing worth mentioning is that the build is occurring within a container and so I am looking to install the development libraries etc without having running hardware.

You need at least cuda-9.0.


Elements used for the initial rendering of a v-for are immune to GC

Vue version
3.4.6
Link to minimal reproduction
https://github.com/peter-gy/vue3-v-for-memory-leak-repro
Steps to reproduce
Using MS Edge makes it easier to investigate the detached elements, so it is recommended to use it for reproduction.
Learn more about how to use the Edge DevTools to investigate memory leaks here.

Open the app in MS Edge
Open the DevTools and navigate to the "Detached Elements" tab
Refresh the element state and force an initial garbage collection by clicking the trash icon
Set the counter to 0
Refresh the element state and force a garbage collection by clicking the trash icon again
See that the detached elements are still there

What is expected?
After the initial items are removed from the DOM, they are removed from memory too, they don't keep on lingering in memory as detached elements.
What is actually happening?
All of the nodes used to initially render the list remain in the memory as detached elements.
System Info
No response
Any additional comments?
Vue SFC Playground Repro Link
Screencast:

[!IMPORTANT]
While on the right side in the screencast, you can read Vue ^3.3.11, the bug is present on the current latest version 3.4.6 too. The SFC Playground links to a repro using 3.4.6.

https://github.com/peter-gy/vue3-v-for-memory-leak-repro/assets/40776291/0dfc6b7e-56e3-4266-8737-aeee32cf4945
The https://github.com/peter-gy/vue3-v-for-memory-leak-repro repository allows you to check side-by-side that this behavior was not present in Vue2. Our team noticed massive memory leaks in our e2e test suite as we have been working on migrating from Vue2 to Vue3.

duplicate of #5256

I think you close it too quickly, I can reproduce these detached nodes even when hoistStatic is set to false.

Do note the detached elements do not increase over time so it is not a memory leak (which implies the memory would keep growing indefinitely).

I tend to disagree @yyx990803. In my "large" application, the v-for iterates on some dynamic user input elements. Because of these detached elements, the memory increases and increases indefinitely.

Do note the detached elements do not increase over time so it is not a memory leak (which implies the memory would keep growing indefinitely).

In our case that's the exact scenario. We have an E2E test suite where thousands of scenarios are executed one after the other. The memory occupied by the non-garbage-collected elements keep accumulating, as we move between scenarios. This is caused by the fact that the whole test suite is executed without any browser reload. This leads to crashing the testing process with an out-of-memory error.

Then unfortunately, your demo isn't showing the actual cultprit because the detached elements you see are retained by __vnode properties which are only attached in development mode for devtools usage. You can verify this by running a production build of your reproduction and see that there won't be any detached nodes.
The leak is therefore caused by something else and needs a valid reproduction.

Then unfortunately, your demo isn't showing the actual culprit because the detached elements you see are retained by __vnode properties which are only attached in development mode for devtools usage. You can verify this by running a production build of your reproduction and see that there won't be any detached nodes.
The leak is therefore caused by something else and needs a valid reproduction.

Thank you for the clarification. I can confirm that the described problem is not present in a production build. After further investigation on our side, this might really be a duplicate of #5256. Thanks a lot for having this issue reopened and for discussing the details though.

Closing this one for now then - please open a new issue if you find out the root cause of your leak is still from Vue core.

Closing this one for now then - please open a new issue if you find out the root cause of your leak is still from Vue core.

We had multiple leak sources, but running the tests using a production build as per your suggestion and patching the leak in a Vuetify component (vuetifyjs/vuetify#19024) seem to have solved our issues.


Remove ConsoleAppender from HadoopJavaJobRunnerMain

Remove ConsoleAppender from HadoopJavaJobRunnerMain  as it is not needed anymore.
It breaks compatibility with applications using log4j2.

I also see ConsoleAppender in JavaJobRunnerMain.java. Do we need to remove it as well?

Pull Request Test Coverage Report for Build 6867

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.004%) to 45.266%

Files with Coverage Reduction
New Missed Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
4
76.16%

Totals

Change from base Build 6859:
-0.004%

Covered Lines:
18066

Relevant Lines:
39911

💛  - Coveralls


limit nesting loop for SQLite filename creation to count of key array…

… otherwise an Undefined offset warning is raised while trying to access non-existing members of the key array.

Thanks! I've merged and released a bugfix version with this included.


License ?

Hello, under what license is this project released under ? I would like to study it to learn from it. Thank you.

Hi, MIT License now added. Thanks for bringing this up!


chore(master): release 0.41.0-alpha

:robot: I have created a release beep boop
0.41.0-alpha (2024-02-06)
Features

new (c94ab4c)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/mafqla/yalis-blog/releases/tag/v0.41.0-alpha :sunflower:


[Edit Profile] There are 'Cancel', 'Upload new photo',  'Delete photo' buttons instead of  'Cancel', 'Delete photo',  'Upload new photo' in 'Edit Picture' pop-up

Environment: OS Windows 10 Pro, browser - Google Chrome 89.0.4389.114 (64-bit)
Reproducible: always
Build found: last commit from https://ita-social-projects.github.io/GreenCityClient/#/profile/302/edit
Steps to reproduce

Log in;
'Edit Profile' is opened (Go to 'My habits' > Edit Profile (https://ita-social-projects.github.io/GreenCityClient/#/profile/302/edit))

Actual result

'Cancel', 'Upload new photo', 'Delete photo' buttons are displayed in 'Edit Picture' pop-up (see the attachment)

Expected result

'Cancel', 'Delete photo', 'Upload new photo'  buttons are displayed in 'Edit Picture' pop-up(see the attachment)

User story and test case links
User story #1011
[Test case GC-1626] https://jira.softserve.academy/projects/GC?selectedItem=com.thed.zephyr.je%3Azephyr-tests-page#test-cycles-tab [Test case GC- GC-1558] https://jira.softserve.academy/projects/GC?selectedItem=com.thed.zephyr.je%3Azephyr-tests-page#test-cycles-tab

CHANGE REQUEST
The mock-up is updated.
Actual result

'Cancel', 'Delete photo' , 'Upload new photo' buttons are displayed in 'Edit Picture' pop-up (see the attachment 1)

Expected result
2. 'Cancel', 'Upload new photo' buttons are displayed in 'Edit Picture' pop-up (see the attachment 2)


fix(takeWhile): force unsubscribe when it completes or errors

Force unsubscribe on takeWhile when it completes or errors, even when used with operator that does not unsubscribe reliably, so that source Observable is never subscribed longer than it needs to.
Related issues:
takeWhile suffered from the same problem as first: #2455
It is a concrete case of more general problem: #2459

Coverage increased (+0.0007%) to 97.69% when pulling 964fb6cbe350d53a946188991f8f68aac63e3831 on Podlas29:take-while-with-switch-map-fix into a88ac2a9f144641cc9bd2ae60f8221127c981181 on ReactiveX:master.

Like #2463, I worry that this will be a breaking change for some people, and we might have to release this with the next major (which we should probably do pretty soon)... @staltz? @trxcllnt?

@benlesh wouldn't all bug fixes count as breaking changes then?

wouldn't all bug fixes count as breaking changes then?

Yup, and there's no shame in that.

Interesting, to clarify, I don't object to make this breaking changes for major but just for curiosity - if some behavior was unintended / undocumented and ppl was using it by just found it, still we consider fixing it has major breaking changes? (this one looks in those way to me)


Update screenshots

Codecov Report

Merging #121 (fa77609) into master (bba6c97) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #121   +/-   ##
=========================================
  Coverage     60.96%   60.96%
  Complexity      546      546
=========================================
  Files           104      104
  Lines          2001     2001
  Branches        232      232
=========================================
  Hits           1220     1220
  Misses          713      713
  Partials         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba6c97...fa77609. Read the comment docs.


some incorrect paths

Thanks for this great tool - I am hoping to run taxvamb on my data so it is great to have this tool to convert my centrifuge annotations.
On my system, I got the following path errors after running taxconverter centrifuge -i <my input> -o <my output>:
2024-03-11 16:08:46.665 | INFO     | taxconverter.__main__:ncbi_lineage:45 - Loading NCBI lineage
Traceback (most recent call last):
  File "/my/university/system/.conda/envs/anvio/bin/taxconverter", line 33, in <module>
    sys.exit(load_entry_point('taxconverter', 'console_scripts', 'taxconverter')())
  File "/my/university/system/software/taxconverter/taxconverter/__main__.py", line 171, in main
    df_result = centrifuge_data(args.input)
  File "/my/university/system/software/taxconverter/taxconverter/__main__.py", line 38, in wrapper
    df = func(*args, **kwargs)
  File "/my/university/system/software/taxconverter/taxconverter/__main__.py", line 80, in centrifuge_data
    df_ncbi = ncbi_lineage()
  File "/my/university/system/software/taxconverter/taxconverter/__main__.py", line 46, in ncbi_lineage
    df_ncbi = pd.read_csv(NCBI_LINEAGE, quoting=csv.QUOTE_NONE)

It was solved by changing NCBI_LINEAGE and METABULI_LINEAGE to:
NCBI_LINEAGE = os.path.join(parentdir, 'data/ncbi_lineage.csv')
METABULI_LINEAGE = os.path.join(parentdir, 'data/metabuli_lineage.csv')

I also had an issue with unzipping the lineage.zip file on my university system. Neither gunzip / gzip -d / unzip worked, though my solution was to unzip it on my mac (which worked) and then copy the data over. This might be just a be a me problem though. I can submit this as a separate issue if you think it would be helpful, though it is very minor and might just need a clearer installation note in the readme, if anything.
Thanks again,
Will

Hi Will!
It's been an awfully long time since you left the issue! I apologize for missing it.
Thank you for your interest and testing the tool, I've added your code fix. The tool is slightly updated since we've updated the file formats in TaxVAMB (the preprint should finally drop in a few days).
I'll look into the zipping thing later.
Best,
Svetlana


make the rpcaudit.logfile configurable

are those test failures due to my changes?

are those test failures due to my changes?

Looks like you need to rebase to get some fixes that are already in master.

@tampakrap Thanks for your PR!
Any chance of an extra spec test along the lines of https://github.com/voxpupuli/puppet-mcollective/blob/master/spec/classes/mcollective_spec.rb#L639 ?

@alexjfisher done. thanks for the review

@tampakrap Great!  Thanks for adding the test.  Merged.


Adds Spotify Search queries function

Is your feature request related to a problem? Please describe if so, otherwise leave this blank..
Describe the feature
<-- A clear and concise description of the feature. What will it do, what will it affect, etc. -->
Adds Spotify search query function (https://open.spotify.com/)
Provide any alternatives to the feature you've considered
Any other alternatives to the feature request you are asking for if we decide not to go with your feature request?
N/A
Additional information
<-- If you have anything additional to say, you can say it here. Otherwise you can leave this blank. -->
N/A

Please assign this to me.


Revert "Revert "Revert "Revert "Test 2 (#6)" (#7)" (#8)" (#9)"

This reverts commit bc3e32e7ed887d72dbbbd8690c22edba784a4bf3.

/cherry-pick testbranch


update com.spotify:docker-maven-plugin

openjdk-runtime is using 0.4.13, this runtime should update from 0.3.2 to the new version

addressing in another issue


How to turn off line numbers in production env?

I assume with golang, finding the file/line number is more expensive. Is there a way to turn that off somehow in production?

bump..


Adopt build blocker plugin.

Description
I've filled this PR https://github.com/jenkinsci/build-blocker-plugin/pull/13 in order to fix a bug in the plugin.

ping @ffromm
Submitter checklist for adding or changing permissions

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[x] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[x] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[x] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[x] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[x] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[x] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @daniel-beck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@dmone90 please let me know if you want to be a default assignee in Jira


Allow conservative regridding of vectors

This is a simple modification to comment out a logical check in MAPL_ExtDataGridCompMod which forces a halt if the user tries to perform conservative regridding of a vector quantity. Although it is not clear if this is scientifically valid, we have seen that conservative regridding of wind data (whether vector or scalar) prevents a specific failure mode in regridding and provides a better result than bilinear interpolation under certain circumstances. This update at least removes a block which prevents users from testing this option.

I added this to the code a while back without doing a merge, so it is all set.


PEAR-1649 - Context-sensitive gene page, cancer distribution CNV counts are unexpected

Description
Checklist

[x] Added proper unit tests
[x] Left proper TODO messages for any remaining tasks
[x] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

looks good 👍


FTBFS on i386: request for member X which is of non-class type 'const long long unsigned int'

The current tip of master fails to build from source on i386 (but fine on amd64) due to the following errors:
/<<BUILDDIR>>/opengm-2.3.6+20160814/include/opengm/inference/lazyflipper.hxx:169:29: error: request for member 'maxSubgraphSize_' in 'p', which is of non-class type 'const long long unsigned int'
       :  maxSubgraphSize_(p.maxSubgraphSize_),
                           ~~^~~~~~~~~~~~~~~~
/<<BUILDDIR>>/opengm-2.3.6+20160814/include/opengm/inference/lazyflipper.hxx:170:27: error: request for member 'startingPoint_' in 'p', which is of non-class type 'const long long unsigned int'
          startingPoint_(p.startingPoint_),
                         ~~^~~~~~~~~~~~~~
/<<BUILDDIR>>/opengm-2.3.6+20160814/include/opengm/inference/lazyflipper.hxx:171:29: error: request for member 'inferMultilabel_' in 'p', which is of non-class type 'const long long unsigned int'
          inferMultilabel_(p.inferMultilabel_)

The detailed build log is available here.

Quick update to confirm the failure is happening for all 32-bit architectures, see here

And the corresponding bug report downstream.

I will have a look. Should not be a big thing.
During merging I run test on 64bit only. That's why I miss this.

I am currently testing the packaging with the new tip of master and will report if other things come up.

The FTBFS is fixed. Thanks @joergkappes. Closing.


Implement changes suggested during the 1st review

What does this PR do?
Implements the suggestions made by Chijoke Ndubisi & Verem Dugeri during the second review of the checkpoint.
Action points

Remove duplicate code for building queries in document controller.
Change status code from 200 to 404 when documents for an existing user are not available

Coverage increased (+0.3%) to 89.244% when pulling e681ba1027280f1e97fd27a2c21c381ee721b9e9 on review-1-changes into f93f18db7a7c85b6840e7dcd00b2686dc9a5c897 on develop.


[Feature] Added logics to hide iOS home indicator when screenshare is presented during a call

Purpose
Added logics to hide iOS home indicator when screenshare is presented during a call
Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: UX improvement

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code
Launch the app, join a call (with remote participant), either group call or Teams call is ok
Turn on screenshare (done by remote participant)
Follow What to check section
Turn off screenshare (done by remote participant)
Follow What to check section

What to Check
Verify that the following are valid

Check if the iOS indicator are hidden when screen share is presented on the screen during a call, in portrait and landscape mode.
Check if the iOS indicate are shown when switched to other screen such as Setup view, Participant / Audio Drawer, or exit overlay.

Other Information

Tested, work as described, just one concern since we are fading out the home indicator bar, there is now an odd grey area when in landscape view (see screenshot). Should we extend the participant view to the bottom?

@jimchou-dev yes this is a good call. There is currently an UI issue in zooming when in the double tap to zoom is performed in landscape, if the size of the screenshare view overlaps with iOS indicator. This bug is logged in the ui bug ticket [BUG 2767250] (will work on this asap). As a temporary solution the height of the screenshare has been reduced to so the view does not overlap with iOS home indicator.


Common functional on the AlaSQL library questions

Tell me, please, such questions on the AlaSQL library: 1. Does it work with BLOB objects? 2. The query result is returned only in JSON format? 3. Is there a limit on the size of blob objects in the browser?

Not sure about blob. Let me know when you find out.
Your browser memory is the limit to the size.

As far as I know, IndexedDB should not have restrictions and should store blob.


adjustment of the mapping of the dataenterer necessary due to change in the ch core

Change in CH Core:
EPRDataEnterer: valueReference only to Practitioner (not Person) #85
CDA-FHIR-Maps -> Change Reference from Person to Practitioner

CDA to FHIR: input\maps\CdaChToBundle.map

Line 138: group ChExtEprDataEnterer
Line 173: call of this rule

FHIR to CDA: input\maps\BundleToCdaCh.map

Line 168: rule dataEnterer

fixed, but see also issue https://github.com/hl7ch/ch-core/issues/93

Mapping FHIR to CDA (CdaContainingOriginalRepresentationAsPdfA.xml) is not correct:
  <dataEnterer>
    <templateId root="2.16.7<IP_ADDRESS>.<IP_ADDRESS>"/>
    <time value="20171003131500+0100"/>
  </dataEnterer>

Mapping CDA to FHIR  (CdaContainingOriginalRepresentationAsPdfA.xml) needs to be updated to PractitionerRole instead of Practitioner.
CH Core Data Enterer refers only to PractitionerRole.


Updated godeps for new rancher-compose

This picks up the metadata updates for rancher-compose.

LGTM.


AndroidFullScreen.leanMode is not defined

// Hide system UI until user interacts
AndroidFullScreen.leanMode(successFunction, errorFunction);
throws error
VM126:3 Uncaught TypeError: AndroidFullScreen.leanMode is not a function
    at <anonymous>:3:19
    at Object.InjectedScript._evaluateOn (<anonymous>:895:140)
    at Object.InjectedScript._evaluateAndWrap (<anonymous>:828:34)
    at Object.InjectedScript.evaluate (<anonymous>:694:21)

It looks like you're using an old version of the plugin with the latest code example: just update or re-install the plugin and you'll be fine.

thanks @neilrackett  .. it works now ..