Support for @Subscribe in kotlin

I made a few subsciber classes in Kotlin, but my index class does not get generated. I get this error at build time:
warning: The following options were not recognized by any processor: '[eventBusIndex]'
Is there some solution? I configured my build.gradle exactly like on your site...
Thanks!

It could be that kapt has to be used for kotlin, but how do I configure it? Is this right?
These are the dependencies:
compile 'org.greenrobot:eventbus:3.0.0'
kapt 'org.greenrobot:eventbus-annotation-processor:3.0.1'
provided 'org.glassfish:javax.annotation:10.0-b28'

This is how I got the args:
kapt {
generateStubs = true
arguments {
arg('eventBusIndex', 'com.lomdaat.coreservices.sync.MyEventBusIndex')
}
}
I've tried but it still doesn't work.. only the previous error disappears. But there are a lot of:
Error:Subscriber method must have exactly 1 parameter
Error:@Subscribe is only valid for methods

More information: kapt adds his own annotations to annotations array here.

Reported to jetbrains: https://youtrack.jetbrains.com/issue/KT-12201

Thank you for the response, I'm sorry I didn't write back then, I was busy with other task. Now I'm back to this and I'm wondering if there is a workaround? Our app is using eventbus for very important functionality, and it would be nice to have this optimization. Otherwise, should I switch back to version 2.4?
Thanks again! And also for the wonderful library!

Is there no current workaround for this? I am using kapt for the annotation processor and have it generating for the java files, but it's still not working on kotlin.

Tri this:
apply plugin: "kotlin-kapt"

No response, so I guess this works now. Closing. -ut

no. it still broken

@deviant-studio Any further details? Looking at the issue report this was fixed in Kotlin 1.0.6.

@greenrobot-team sorry, never mind. it works now


range-v3 package fails to build because hash doesn't match on download file

I've included the log from the output below. This is repeatable.
C:\lib\vcpkg>vcpkg install range-v3:x64-windows
The following packages will be built and installed:
range-v3:x64-windows
Building package range-v3:x64-windows...
-- CURRENT_INSTALLED_DIR=C:/lib/vcpkg/installed/x64-windows
-- DOWNLOADS=C:/lib/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/lib/vcpkg/packages/range-v3_x64-windows
-- CURRENT_BUILDTREES_DIR=C:/lib/vcpkg/buildtrees/range-v3
-- CURRENT_PORT_DIR=C:/lib/vcpkg/ports/range-v3/.
-- Downloading https://github.com/ericniebler/range-v3/archive/6eb5c831ffe12cd5cb96390dbe917ca1b248772d.zip...
-- Downloading https://github.com/ericniebler/range-v3/archive/6eb5c831ffe12cd5cb96390dbe917ca1b248772d.zip... OK
-- Testing integrity of downloaded file...
-- Testing integrity of downloaded file... OK
-- Downloading https://github.com/Microsoft/Range-V3-VS2015/compare/fork_base...00ed689bac7a9dcd8601dbde382758675516799d.diff...
-- Downloading https://github.com/Microsoft/Range-V3-VS2015/compare/fork_base...00ed689bac7a9dcd8601dbde382758675516799d.diff... OK
-- Testing integrity of downloaded file...
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:47 (message):
File does not have expected hash:
      File path: [ C:/lib/vcpkg/downloads/range-v3-fork_base_to_00ed689bac7a9dcd8601dbde382758675516799d.diff ]
  Expected hash: [ 615a53ebac22df03e865bdcc86580914c4505ec5fc691b6a2f864f7bf63690b99d0da0db2d5b1026e34b0a3f7557f30dfa0cad65643bae0b53c0ec066af9eb8e ]
    Actual hash: [ 6158cd9ee1f5957294a26dc780c881839e0bae8610688a618cd11d47df34d5e543fa09ac9a3b33d4a65af8eceae0a6a3055621206c291ef75f982e7915daf91a ]

The file may be corrupted.
Call Stack (most recent call first):
scripts/cmake/vcpkg_download_distfile.cmake:87 (test_hash)
ports/range-v3/portfile.cmake:9 (vcpkg_download_distfile)
scripts/ports.cmake:73 (include)
Error: Building package range-v3:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: range-v3:x64-windows
Vcpkg version: 0.0.81-39b69e5b06df309b9dcfea55296a4c2c3eea93ce
Additionally, attach any relevant sections from the log files above.

I'm using the command window "x64 Native Tools Command Prompt for VS 2017"

File does not have expected hash:
edit
portfile.cmake
и меняй хеши, то что выше
заменить
615a53ebac22df03e865bdcc86580914c4505ec5fc691b6a2f864f7bf63690b99d0da0db2d5b1026e34b0a3f7557f30dfa0cad65643bae0b53c0ec066af9eb8e
на
6158cd9ee1f5957294a26dc780c881839e0bae8610688a618cd11d47df34d5e543fa09ac9a3b33d4a65af8eceae0a6a3055621206c291ef75f982e7915daf91a

Thanks for reporting this!
@Voskrese fixed this in PR #1194 :)


Handle crashed runs on wandb

When you KeyboardInterrupt, wandb seems to upload some extra data... note-to-self to do something about this.

Related: if we checkpoint the model so much that the data exceeds ~115 MB, the uploader seems to hang forever after ~115 MB, I wonder if there's a way to manually resume


Add more granular control for source-code browser caching

Clear and concise description of the problem
I would like to have the option to control cache headers for source code that doesn't change often, so I can more aggressively cache chunks of my application while developing, without using Cache-Control: max-age=31536000,immutable.
Suggested solution
Today, Vite divides code into 2 categories - dependencies, which are pre-bundled and strongly cached, and source code which is never cached.
I'd like to propose a solution - allow users to set stale-while-revalidate cache headers for files that are known to change seldom.
This way we rip the benefits of all sides. With a small enough max-age we can ensure the browser almost always requests fresh content in the background, but the initial load is still super fast thanks to using the now-stale files.
Alternative
An alternative solution would be to use the optimizeDeps.include option in Vite's config, but I believe it some-what defeats the purpose.
Additional context
Large applications can contain thousands of modules, not all of which update frequently.
This causes initial (and sometimes subsequent) refreshes to be rather slow, taking sometimes as much as 30 seconds before the page is fully loaded.
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

I am a random person passing by and I wonder how you would mitigate the following issue:
Let's say you configure some files with stale-while-revalidate and 30s initial load becomes 5s.
The 25s are now performed by the browser in the background. If you update a file configured with stale header while browser is validating cache and before it's able to determine its validity, what will happen?
Let's keep her out of the equation to simplify (the file cannot be hot reloaded)
My guess is that vite won't reload the page because vite server was not yet requested by the browser. And the dev would have to manually reload. (Not a big issue but something to be aware of. Otherwise one could think auto reload is sometimes not working)
At worst vite would reload the page but browser would still use the version in cache. The dev might be confused and manually reload again. As it last 25s the dev might keep hitting the reload button thinking something is broken.
Maybe I am incorrect, I just discovered stale while revalidate thanks to this issue

With hmr, vite injects ?hmr query param to bypass browser cache. I think my concern is just about full page refresh (done manually or because hmr don't apply)

You can add a plugin that will add cache headers
// vite.config.ts
{
  plugins: [{
    name: 'manual-cache'
    configureServer(server) {
      server.middlewares.use((req, res, next) => {
        if (req.url?.endsWith('/myFile.js')) {
          // Add cache-control when vite doesn't add it
          res.setHeader('Cache-Control', 'max-age=3600')

          // OR, Add other headers to override once added by vite
          res.setHeader('Expires', '0')
          res.setHeader('Pragma', 'no-cache')
        }
        next()
      })
    },
  }]
}

@leo-buneev Thanks for the snippet. I was looking for a way to add middleware to change caching behaviour in the docs, but couldn't find something. This is working perfectly.

Closing this as the Vite plugin seems to be the solution here. Would could re-consider it again if there's more request for it.


The primary branch has been renamed from "master" to "main"

Renaming master branch to main
As a part of a broad effort to avoid problematic terminology in our software, we are renaming our default branch from master to main. We recognize that this is only a small step, but it is an opportunity to make our project and community more welcoming to historically marginalized communities.
How does this impact my development process?
There should be very little impact. GitHub will surface the branch name change in your fork, if you have one. For new forks, you will automatically have main as the default branch.
We encourage the use of feature branches for local development. The only change in practice is changing which branch your feature branch is started from. When sending Pull Requests on GitHub, the target will default to our main branch, so there are no changes to make there.
I have a lot of tools that depend on master being the upstream branch name. How can I fix that?
master has always been only a default value and a number of projects have used other names for their primary development branch for years. We encourage updating your tooling to instead dynamically determine the branch to use. This article provides insight into how you can do that. Additionally, you can always set up a branch locally of any name to track our main branch.
I'd like to do this for my own projects, do you have any documentation on how this works?
GitHub has published a guide documenting their tooling. We recommend reading that and the accompanying documentation.
If you're a Facebook employee looking to do this for a project you maintain, please reach out to the Open Source Team.
My PR is failing because of ci/circleci: get_base_build
This is because the master branch has been renamed to main, but our Circle CI scripts used to refer to master by name. To fix this, just rebase your branch on top of main to get the latest version of the Circle CI scripts:
git fetch origin
git rebase -i origin/main

Unfortunately, d456dfb has replaced URLs of many external repositories whose default branch is still "master". For example, README.md has this broken link now:
as found in the [LICENSE-DOCS.md](https://github.com/open-source-explorer/reactjs.org/blob/main/LICENSE-DOCS.md) file.

...because this external repository is using "master".

My apologies. I scanned the URLs being replaced in an attempt to filter out any that weren't the React repo, but apparently I missed a couple. I'll update them.


fckgLite now fckg

To bring fckgLite in line with Dokuwiki's naming conventions, I renamed fckgLite to fckg, which is the actual coded name of the plugin.  So, the plugin 'fckgLIte' should be deleted from the translate tool.
I thought it would be safe to do this because fckgLite has generated any translations because it had some code in its settings.php.
Thanks.

Hi,
I deleted the plugin fckgLite from translation tool.
Regards,
Andrwe

Thanks!


Wavesurfer on ready returns undefined as duration

In your documentation
https://wavesurfer-js.org/docs/events there is an event ready: [duration: number];. However it doesn't return a duration number, instead it returns undefined. Is there mistake in the docs?
wavesurfer.on('ready', (duration) => {
  console.log(duration) //undefined
})

This doesn't happen to me with other events such as audioprocess and it returns currentTime correctly.

Can you paste your entire code?

Can you paste your entire code?

https://jsfiddle.net/wn0f2kxm/

Prior to v7-beta, the ready event indeed didn't return anything. In your example, it's using wavesurfer v1.2.3.
Here's a v7 example: https://stackblitz.com/edit/typescript-4ggbcn?file=index.ts


For godot4 users: slice end is now exclusive

Godot4 array api has changed a lot, and the meaning of end param in slice method has changed, which is the inclusive index previously and now is the exclusive index, same as the original javascript lib.
In this case, line 295-296 should be
    triangles = _triangles.slice(0, triangles_len)
    halfedges = _halfedges.slice(0, triangles_len)

otherwise you will got a non-3-multiply length array .triangles, which is invild.

Thank you for the heads up! I haven't had time to try Godot 4.0.

FYI: I just updated my "ClickableMap" demo including the Delaunator script to work with Godot 4.0:
https://github.com/t-karcher/ClickableMap
Feel free to copy the script from this project back here. (I don't want to open a pull request because you'll also have to update you the rest of the project to make it work, and the 4.0 version is not backward compatible with 3.x)


Gatsby Build Failures

Hello,
First, thanks for building out such a great viewer! I'm trying to use it on a project, and it runs fine locally but when we go to deploy with gatsby build, we get several SSR related errors and the build fails
error Generating SSR bundle failed

Reading from "node:buffer" is not handled by plugins (Unhandled scheme).
Webpack supports "data:" and "file:" URIs by default.
You may need an additional plugin to handle "node:" URIs.
error Generating SSR bundle failed

Reading from "node:fs" is not handled by plugins (Unhandled scheme).
Webpack supports "data:" and "file:" URIs by default.
You may need an additional plugin to handle "node:" URIs.

and many more similar errors. I've tried several webpack workarounds, installing past versions of Clover, upgrading React, to no avail. I'm thinking that there might be incompatible node versions, but I've had a hard time finding what's required for Clover.
My project:
"dependencies": {
    "@samvera/clover-iiif": "^2.3.2",
    "algoliasearch": "^4.10.5",
    "assets": "file:src/assets",
    "atoms": "file:src/components/atoms",
    "caniuse-api": "^3.0.0",
    "classnames": "^2.3.1",
    "detect-browser": "^5.3.0",
    "embla-carousel-react": "^8.0.0-rc18",
    "gatsby": "3.14.5",
    "gatsby-plugin-algolia": "^0.25.0",
    "gatsby-plugin-google-tagmanager": "^3.14.0",
    "gatsby-plugin-image": "2.6.0",
    "gatsby-plugin-manifest": "^3.14.0",
    "gatsby-plugin-react-helmet": "^4.14.0",
    "gatsby-plugin-robots-txt": "^1.7.0",
    "gatsby-plugin-s3": "^0.3.8",
    "gatsby-plugin-sass": "^4.14.0",
    "gatsby-plugin-sharp": "^3.14.0",
    "gatsby-plugin-sitemap": "^4.10.0",
    "gatsby-source-filesystem": "^3.14.0",
    "gatsby-source-graphql": "^3.14.0",
    "gatsby-transformer-sharp": "^3.14.0",
    "gsap": "^3.10.4",
    "interweave": "^12.9.0",
    "jest-junit": "^12.2.0",
    "molecules": "file:src/components/molecules",
    "moment": "^2.29.4",
    "moment-duration-format": "^2.3.2",
    "npm": "^6.14.15",
    "organisms": "file:src/components/organisms",
    "react": "^17.0.2",
    "react-autosuggest": "^10.1.0",
    "react-compare-image": "^3.1.0",
    "react-dom": "^17.0.2",
    "react-helmet": "^6.1.0",
    "react-instantsearch-dom": "^6.12.1",
    "react-modal": "^3.14.3",
    "sass": "^1.39.0",
  },

Node 14.18.3
NPM 6.14.18

Do you know if my node version is incompatible, or maybe of another way to resolve this error? Thanks for the help!

Hi @MWhiteFearless
The SSR build fail is due to Clover's inclusion of OpenSeadragon as a dependency. OpenSeadragon includes function calls on instantiation to the browser window -- which causes the crash.
To accommodate this, Clover must be imported in an alternative method. I'm not extremely  familiar with Gatsby these days, however, in Next.js this is completed using the next/dynamic (https://nextjs.org/docs/app/building-your-application/optimizing/lazy-loading#importing-client-components).
See https://samvera-labs.github.io/clover-iiif/docs/viewer#nextjs
In Gatsby, this could possibly be completed with the following pattern:
import React, { Suspense, lazy, useEffect, useState } from 'react';

const CloverViewer = lazy(() => import("@samvera/clover-iiif").then((Clover) => Clover.Viewer));

const DynamicCloverViewer = () => {
  const [isClient, setIsClient] = useState(false);

  useEffect(() => {
    // This effect will run only once after the initial render, hence setting isClient to true
    setIsClient(true);
  }, []);

  return (

      {isClient && (
        <Suspense fallback={
Loading...
}>
          <CloverViewer />
        </Suspense>
      )}

  );
};

export default DynamicCloverViewer;

Thanks for the suggestion! Unfortunately I still get the same build errors with those changes

Thanks for the suggestion! Unfortunately I still get the same build errors with those changes

Hmmm... Darn. Do you have a public repo of your codebase?

Unfortunately our project is private, though we have been able to deploy Mirador successfully in the project (which also uses openseadragon) so I wonder if the issue might be something else? Mirador doesn't actually work for our use case which is why I'm still trying to get Clover to deploy :)

@MWhiteFearless I grossly overlooked your React version. Sadly, I believe this might be core issue. Is it possible to update React 18 @latest for your project?

I tried the react 18 and lazy/Suspense suggestions together and still get the same error, next maybe I'll try this workaround https://www.gatsbyjs.com/docs/using-client-side-only-packages/#workaround-4-load-client-side-dependent-components-with-loadable-components. Interesting that you can get it to build without issue, maybe this is an issue related to Gatsby 3

I determined that the errors I was running in to were actually related to @iiif/vault and incompatible dependency versions there, not openseadragon. I've moved forward with implementing openseadragon on its own and have it working :) thanks for helping troubleshoot! The lazy loading suggestion was helpful for getting openseadragon working. I think to get clover working on my project we would have to upgrade gatsby and node, which unfortunately isn't an option for us. We can probably close this issue!

@MWhiteFearless I'm going to close this but I also want to make you aware of a new Image component that is essentially a styled OpenSeadragon wrapper. https://samvera-labs.github.io/clover-iiif/docs/image


Add parser support for stream type QueryConstructType

Purpose

Add support for stream type QueryConstructType

Fixes https://github.com/ballerina-platform/ballerina-lang/issues/23742
Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #23956 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23956   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d6adc...da4adcd. Read the comment docs.


Update documentation: removed duplicate word

A small fix related to documentation for sbt plugin.

Cherry-picked, thanks!


fix(leftbar-row): corrected selected row's foreground color

Corrected selected row's foreground color
:hammer_and_wrench: Type Of Change

[x] Fix
[ ] Feature
[ ] Refactoring
[ ] Documentation

:pencil: Checklist

[x] I have reviewed my changes
[ ] I have added tests
[ ] I have added all relevant documentation
[ ] I have validated components with a screen reader
[ ] I have validated components keyboard navigation
[ ] I have considered the performance impact of my change
[ ] I have checked that my change did not significantly increase bundle size
[ ] I am exporting any new components or constants in the index.js in the component directory
[ ] I am exporting any new components or constants in the index.js in the root

@juliodialpad added another commit to resolve Lint PR


[wip] Flatten virtual package module into a series of casgns

Motivation

Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_LUmxBerksMB8br
→ https://go/builds/bui_LUmxQ2lrlSZzrj

Stripe issues should be resolved as of https://go/ps/pull/444402

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_LWRa0u9YrXig6L
→ https://go/builds/bui_LWRamYoNvxw6gR


Use dependabot to update go modules

Dependabot will automatically submit
pull requests for new versions of go
modules used by the project.
Documentation about using Dependabot
for version updates:
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates

/lgtm
/ok-to-test
Thanks!

/assign tashimi
I have no idea how to do this, pinging @tashimi for approval.

/approve


feat: dataspace protocol API configuration

What this PR changes/adds
Introduces the module dsp-api-configuration. The extension creates an API context for dataspace protocol endpoints, if no context is explicitly defined via configuration. It provides the json-ld ObjectMapper to the API context, allowing to use Jakarta JSON types as controller parameters. It also registers a filter for the context that checks authorization against the IdentityService.
Why it does that
To have an API context shared by all dataspace protocol endpoints.
Further notes
The PR is a draft for now as it is waiting for #2656. The DspApiConfigurationExtension needs to require the JsonLdTransformerRegistry added to the json-ld module in that PR, as it is the only service provided to the context by the json-ld extension and thus the only way to ensure the json-ld extension is loaded before the DspApiConfigurationExtension.
Linked Issue(s)
Relates #2474
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[ ] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Codecov Report
Patch coverage: 92.15% and project coverage change: +0.07 :tada:

Comparison is base (0fd6c57) 64.27% compared to head (0748a97) 64.35%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
+ Coverage   64.27%   64.35%   +0.07%
==========================================
  Files         897      901       +4
  Lines       18370    18421      +51
  Branches     1094     1095       +1
==========================================
+ Hits        11808    11855      +47
- Misses       6126     6130       +4
  Partials      436      436

Impacted Files
Coverage Δ

...api/configuration/serdes/ObjectMapperProvider.java
75.00% <75.00%> (ø)

...pi/configuration/auth/ClaimTokenRequestFilter.java
92.00% <92.00%> (ø)

...pi/configuration/DspApiConfigurationExtension.java
93.75% <93.75%> (ø)

...col/dsp/api/configuration/DspApiConfiguration.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


web-sys tests do not load in Chrome

Running cargo test --target wasm32-unknown-unknown in the web-sys directory results in this output:
~/projects/wasm-bindgen/crates/web-sys
$ cargo test --target wasm32-unknown-unknown
    Finished dev [unoptimized + debuginfo] target(s) in 0.16s
     Running /Users/twilcock/projects/wasm-bindgen/target/wasm32-unknown-unknown/debug/deps/all-a5c63a8c7fc00a5f.wasm
    Finished release [optimized] target(s) in 0.18s
     Running `/Users/twilcock/projects/wasm-bindgen/target/release/wasm-bindgen-test-runner /Users/twilcock/projects/wasm-bindgen/target/wasm32-unknown-unknown/debug/deps/all-a5c63a8c7fc00a5f.wasm`
no tests to run!
     Running /Users/twilcock/projects/wasm-bindgen/target/wasm32-unknown-unknown/debug/deps/wasm-d82521c4d7864ee1.wasm
    Finished release [optimized] target(s) in 0.16s
     Running `/Users/twilcock/projects/wasm-bindgen/target/release/wasm-bindgen-test-runner /Users/twilcock/projects/wasm-bindgen/target/wasm32-unknown-unknown/debug/deps/wasm-d82521c4d7864ee1.wasm`
Running server on http://<IP_ADDRESS>:8000

Which is fine.  But when you go to the URL provided in the last line in Chrome, all you see is a message that says "Loading scripts...".  In the console, there is the following error:
wasm-4faccd638d53fbc2:180 Uncaught Error: descriptor for id='contextMenu' not found
    at GetOwnOrInheritedPropertyDescriptor (wasm-4faccd638d53fbc2:180)
    at wasm-4faccd638d53fbc2:1610

The tests display as expected in Firefox.

I fixed this in: https://github.com/rustwasm/wasm-bindgen/pull/596

Thanks so much @jonathanKingston!
We can figure out later on I think how to test APIs that are Chrome or Firefox-only. This does raise an interesting question about how firefox-specific the WebIDL is, but let's see over time!


[sdl2] Building for ARM UWP builds x86

On 4cb5212:
$ ./vcpkg.exe install sdl2:arm-uwp
(…)
-- Performing post-build validation
The following files were built for an incorrect architecture:

    C:/Users/User/source/vcpkg/packages/sdl2_arm-uwp/debug/lib/SDL2.lib
Expected arm, but was: x86

    C:/Users/User/source/vcpkg/packages/sdl2_arm-uwp/lib/SDL2.lib
Expected arm, but was: x86

The following files were built for an incorrect architecture:

    C:/Users/User/source/vcpkg/packages/sdl2_arm-uwp/debug/bin/SDL2.dll
Expected arm, but was: x86

    C:/Users/User/source/vcpkg/packages/sdl2_arm-uwp/bin/SDL2.dll
Expected arm, but was: x86

Found 2 error(s). Please correct the portfile:
    C:\Users\User\source\vcpkg\ports\sdl2\portfile.cmake
-- Performing post-build validation done
Error: Building package sdl2:arm-uwp failed with: POST_BUILD_CHECKS_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: sdl2:arm-uwp
  Vcpkg version: 0.0.97-2017-11-17-06819e43e30b64769d1ef036d20f6038dab4da34

Additionally, attach any relevant sections from the log files above.

Thanks for reporting this!
I've pushed a change to master which uses SDL2's cmake files for UWP, which also fixes this issue. Could you try it out and confirm it works for you?

Thanks!
Yes, the library seems to be building correctly now. This is as far as I can verify right now, but it fixed the issue reported here, so I'm going to close it now.
For future reference, the commit in question is https://github.com/Microsoft/vcpkg/commit/e6c65b93b125cf0be13254cf2f5a9d27cb009707.


Don't emit empty statement in ClassTransformer if initInstanceVariables is empty

Closes #1822

the behaviour looks good to me for es5 and es6 script-mode with/without extends clause and with/without default constructors. will add tests..

@johnjbarton I think erik is gone for the week, but do you have an opinion on this? It's a pretty minor change and it sounds like at least one engine (I would bet JSC, although Safari on ios 8.2 didn't seem to have a problem with it) didn't like the empty statement

@caitp can you help me understand how initInstanceVars gets a value? I only see its initialization to [].
While I appreciate your test cases, we generally try to avoid using generated code as test expectations. (I regret the cases where we accepted them in the past).  The generated code can vary a great deal without altering the validity of the transformation.  By testing the operational result of the transformation on the evaluated program, the test becomes sensitive to only the transformation.  For example, by verifying that an instance of a class is initialized with the values in the class body we check the transformer without the test failing if we change formatting and so on.  That is why almost all of our *Transformer tests are actually 'feature' tests.

@johnjbarton it gets aliased as initVars while being modified (initVars points to either the static vars array or the instance vars array depending on the presence of the static keyword)

getting rid of the tests is fine --- the code "works" one way or the other, the empty statement being a syntax error was apparently a bug in the original report

Of course you would have exactly the example where feature tests don't work!
What do you think about adding a check in ConstructorValidator that we are not emitting empty statements?  I'd like to have some way to know that this is moving forward and that we don't break it later.

@johnjbarton I'm not sure there's a good way to do that (would need to know if the constructor is a default constructor or not) --- how about a codegen test which just verifies that there aren't 2 semicolons after "use strict", with whitespace/line endings removed?

Yes, but I think you can just check the transformed tree and only for the cases that would fail if this PR were not in place.

added a simpler test case which makes assertions about the structure of the transformed AST itself... tried to be as indirect as possible so that it doesn't break often.

An even simpler test would be to transform the tree, write it and compare it with the expected output. We have a few tests like that where we want to make sure the generated code "looks good".

Yeah, @johnjbarton wasn't keen on that

That's what the original PR did.  See https://github.com/caitp/traceur-compiler/commit/8d9df81fcc741825df6b593d33be0c8cff86f864 and my comments above.
If the Find apparatus was as part of our system rather than in this test it would look a lot better.

When testing that the constructor does not contain an empty expression I think it is cleaner to just look at the generated code instead of inspecting the AST.
@caitp Sorry for the conflicting input.

@arv there was a test suite (basically the ES6ClassTransformer tests adapted for ClassTransformer), but he wasn't keen on testing the generated code, preferring the functional testing. However, since functionally the empty statement is fine, it can't really be verified that way. The test was removed when the commit was amended
Honestly, there isn't much point in the patch, it just makes the output a bit cleaner. the original bug report mentioned a syntax error, but that seems to have been a mistake on the part of the poster.

I totally support the functional changes of this. I'm also fine just skipping a test for it. What I don't like is the current test since it is too complicated for what it needs to test.

Removed the test case

LGTM


Layout Editor js race condition

Seems to be an error on the Contents Edit page Uncaught Error: No element with type "Canvas" was found.
This is casued when window.layoutEditor = new LayoutEditor.Editor(editorConfig, editorCanvasData); in the LayoutEditor view is called before registerFactory("Canvas", function (value) { return LayoutEditor.Canvas.from(value); }); in the Models.js.
https://github.com/OrchardCMS/Orchard/blob/dev/src/Orchard.Web/Modules/Orchard.Layouts/Scripts/Models.js
https://github.com/OrchardCMS/Orchard/blob/dev/src/Orchard.Web/Modules/Orchard.Layouts/Views/EditorTemplates/LayoutEditor.cshtml
Fix:
Change anonymous function to JQuery document ready function JQuery(function() {});
https://github.com/OrchardCMS/Orchard/blob/dev/src/Orchard.Web/Modules/Orchard.Layouts/Views/EditorTemplates/LayoutEditor.cshtml#L38

Still having this issue with the minified Layouts.Models script.

Could you try running gulp from task explorer and see if that fixes it?

@sfmskywalker That fixed it, I'll open a pr shortly

@sfmskywalker That fixed it thanks!


keyboard open while presenting..

This is a minor irritant, but the alert is display under the keyboard while presenting. I am currently ending edits prior to display, but this is disruptive to the user's experience if they cancel.
Have i missed a setting somewhere?

Thanks for reporting this.
Could you see if setting:
self.window = UIWindowLevelAlert;

in https://github.com/fastred/AHKActionSheet/blob/master/Classes/AHKActionSheet.m#L398 helps?

thank you.. this worked:
    self.window.windowLevel = UIWindowLevelAlert;

and btw, this just makes tons of difference to a few other workflows as well, many thanks for the quick reply.

Great, I'll add this to the main repository. What specific workflows did you mean?

I referred my own ui actions that involved user interaction to confirm various items... those were not hindered by the keyboard in the way that prompted this question. Again thank you.

 Not sure exactly when, but one of the updates seems to have pushed the action sheet behind the open kb again.

This is apparently not related to this git.. and i am researching a solution in what might be the problem area. My apologies ;)

For reference:   self.window.windowLevel = 10000001; will correct this issue.

I rethought this and I'm not going to change that behavior. Keyboard hiding should be handled outside of the action sheet itself.
Motivation: It's not possible in AHKActionSheet, but for example in UIAlertView (old API) or UIAlertController it's possible to show alert with text field. Keeping keyboard behind wouldn't make much sense.
My advice: you can fork the repo and keep your changes in the fork. If you're using CocoaPods you can point the Podfile to your repo with this syntax:
pod 'AFNetworking', :git => 'https://github.com/gowalla/AFNetworking.git'

Thanks!

It is definitely your call my friend, but one peek at iMessage and you will see their equivalent functionality leaves the kb alone, drops the action sheet on top of it, and when cancelled, the kb is exactly as it was. The only diff is that Apple up'd the AlertLevel's value, which you can easily circumvent as i have shown. I will let it rest as i have reclaimed normal behaviour ;)  cheers!


test:type script failed in async component test process

Version
2.6.14
Reproduction link
https://github.com/vuejs/vue
Steps to reproduce
run yarn test:types
What is expected?
no errors
What is actually happening?
error TS2322: Type '{ component: () => Promise<Component<DefaultData, DefaultMethods, DefaultComputed, Record<string, any>>>; }' is not assignable to type 'void | Promise<EsModule<Component<DefaultData, DefaultMethods, DefaultComputed, Record<string, any>>>> | { component: Promise<EsModule<Component<DefaultData, DefaultMethods<...>, DefaultComputed, Record<...>>>>; loading?: VueConstructor<...> | ... 3 more ... | undefined; error?: VueConstructor<....'.
Type '{ component: () => Promise<Component<DefaultData, DefaultMethods, DefaultComputed, Record<string, any>>>; }' is not assignable to type '{ component: Promise<EsModule<Component<DefaultData, DefaultMethods, DefaultComputed, Record<string, any>>>>; loading?: VueConstructor | FunctionalComponentOptions<Record<...>, PropsDefinition<...>> | ComponentOptions<...> | { ...; } | undefined; error?: VueConstructor<...> | ... 3 more ... | unde...'.
Types of property 'component' are incompatible.
Type '() => Promise<Component<DefaultData, DefaultMethods, DefaultComputed, Record<string, any>>>' is missing the following properties from type 'Promise<EsModule<Component<DefaultData, DefaultMethods, DefaultComputed, Record<string, any>>>>': then, catch, [Symbol.toStringTag], finally
9 const b: AsyncComponent = () => ({
~~
10   // @ts-expect-error component has to be a Promise that resolves to a component
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
14     })
~~~~~~
15 })
~~
Found 1 error.
error Command failed with exit code 1.

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server or StackOverflow.


OpenSSL 1.1.0 API Changes  (was "Failing on Pthread compilation")

Having compilation errors that appear to have a problem with the pthread library. Issue occurs using the top two build options inside the Makefile.
Issue has been seen on multiple Kali boxes, all of which are completely updated.
root@kali:~/Desktop/revsh# uname -a
Linux kali 4.9.0-kali4-amd64 #1 SMP Debian 4.9.25-1kali1 (2017-05-04) x86_64 GNU/Linux

Can get passed this error by adding -pthread to the LIBS in the Makefile. After which, I am confronted with this error:

Confirmed. Several issues with building in Kali. One of these appears to be a change in the openssl command line parsing. Other issues seem to be related to kali libraries. I'll work on this and get it cleaned up.

Changed issue name. Everything here is because kali uses the newer OpenSSL 1.1. There are quite a few changes to the api. This may take some time, but is being worked on.

@emptymonkey are you sticking with openssl? Do you have any interest in switching to mbedtls and dropping openssl altogether? I would be happy to help port to mbedtls if I have some spare time as I had intended to put something like this together already, but it seems you've done most of the work for me..
https://github.com/ARMmbed/mbedtls

@mzpqnxow , I'm not set on any library. My only real design goals with revsh are:

The config and building isn't too painful for the end user.
everything "just works" once built. (This implies a full static build to rule out compat issues on the target. This is where OpenSSL 1.1 is failing pretty badly these days.)

I've been considering both mbedtls and wolfssl. (I'm not partial to one or the other. I've only ever coded with OpenSSL and am happy for the change.)  Unfortunately, life has gotten in the way of code right now, so I've been saying I'd work on this for several months but honestly haven't started. I'm happy for any help people want to contribute.
As for the mechanics, revsh is pretty modular right now. Other than a small number of "#ifdef OPENSSL" entries, everything of real interest is in the io_ssl.c file. The path forward I see in my head is to rename that file as io_openssl.c and then add an io_mbedtls.c, etc. All interchangeable depending on how the end user wants to build it.
Finally, because I have a bit of a fetish for tight binaries, I'm also interested in building both the tls lib and revsh itself with an embedded c lib like musl libc once we get the new tls lib code added.  Hit me up on email or twitter dm if you want to discuss how the internals of revsh are put together. (Start with Documentation/CODEMAP. Oh, and I have a devel branch where I smash it all together first, since lots of people seem to be using this these days I try not to jump straight to master.) Take a look under the hood. If it still sounds like something you want to work on, I'd be happy for the help. Cheers!

Thanks- yeah I will fork and let you know if I start putting any serious effort into getting away from OpenSSl- and yes, musl is a good option, I've already built a few statically linked revsh bins for a few platforms using musl-cross-make which makes it very painless (vi config.mak, make -j && make install)
I have configs for a few different platforms @ https://github.com/mzpqnxow/musl-cross-make-configs if you have any interest in messing with musl-cross-make, just replace config.mak with one of those configs, make clean && make -j && make install. Check it out if you haven't already and want to see how streamlined musl-cross-make is. Building the musl toolchain, openssl static libs and revsh statically linked for MIPS-I only took me about 15 mins, which isn't all that bad.

I'm going to go ahead and close this out as I seem to have it working now with the OpenSSL 1.1 family. There have been enough fixes to OpenSSL 1.1 that it now builds and works with a static binary, but only if you ignore the libssl.a and libcrypto.a files that ship with the distros and build from more recent source. I've updated the Install section of the README.md file as well as the Makefile to reflect this (in devel branch for now).
I haven't done a lot of testing yet. Once I make some more changes / do some more cleaning, I'll do a round of testing and push everything to master. Thanks everyone for the help!


Fix Checkout Step type

when sending checkout_step through gtag for ecommerce, according to this
documentation, the type should be "number", not "string", so send as a
number.
https://developers.google.com/analytics/devguides/collection/gtagjs/enhanced-ecommerce#action_data

Thank you @jormon 👍


Remove reference to marketing stack

I am going to tear down the marketing calendar stack and need to prevent this stack from referencing this first or this stack will fail to provision on the next deployment.

preview: https://app.pulumi.com/pulumi/www.pulumi.com/www-production/previews/a1fdf1c9-1372-436d-8265-56008a1a4719


Replace the HTML Parser

The current parsers is only able to return the last error it occures. The error may not even be correct as some problems cascade and cause element to fail incorrectly. There is probably no way to fix this without rewriting the parser all together. Only the error message is returned, so no code snippet can be extracted either.
A replacing parser should have the following features

Identifies all errors regarding incorrectly nested tags
Identifies duplicate attributes
Allows self closing tags
Prohibits closing tags of element that are not permitted to have them
Applies XML rules to pages with XML doctype (self closing met be with "/>")
Returns code snippet of with errors

Relates to #291


Move some help files from bundler/bundler site to man/ ?

An problem illuminated by this issue https://github.com/bundler/bundler/issues/4940 is that it's very confusing whether a particular piece of documentation should be in this repo, or in bundler/bundler-site. Many of those pages might be better if they were inside of  bundler/bundler's man/.
Good candidates?

https://github.com/bundler/bundler-site/blob/master/source/v1.13/bundle_clean.html.haml
https://github.com/bundler/bundler-site/blob/master/source/v1.13/bundle_check.html.haml

Yes, all the command docs should be manpages

i moved over everything that was missing but had a page in bundler site in #5348 - if y'all wouldn't mind giving it a once over that would be aces. thanks!

Done in https://github.com/bundler/bundler/pull/5348


CLI: Add support for metadata export

Is your feature request related to a problem? Please describe.
As a user I want to have the ability to back up [and restore - out of scope for this ER] metadata with the intent to store a copy in a custom file system location. In combination with import (again, out of scope for this enhancement request) this would allow for

backup (disaster recovery)
improved testing
cloning of deployments

Describe the solution you'd like
elyra-metadata export <schemaspace> [--schema_name=<schema>] [--valid-only] --directory=<path>

<schemaspace> (required): one of the supported schemaspaces, like runtimes, code-snippets, or runtime-images
schema_name (optional): if supplied and applicable, only instances of the provided <schema> are exported
valid-only (optional): if specified, only valid instances are exported. The default is to export all instances, which is identical to the behavior of the elyra-metadata list command
directory (required):

local file system path where the exported metadata will be stored
the specified directory is created if it does not exist
the exported <schemaspace> metadata is stored in a subdirectory of <path>, named after the <schemaspace>, e.g. <path>/runtimes or <path>/code-snippets.
The export format is the [JSON] format that is used  internally to store metadata.

Examples

Export all (valid and invalid) runtime configurations to /tmp/foo
elyra-metadata export runtimes --directory=/tmp/foo

This command creates the /tmp/foo/runtimes directory and stores all valid and invalid runtime configuration instances in that directory.

Export all Kubeflow Pipelines runtime configurations to /tmp/foo
elyra-metadata export runtimes --schema_name=kfp --directory=/tmp/foo

This command creates the /tmp/foo/runtimes directory and stores all valid and invalid Kubeflow Pipelines runtime configuration instances in that directory.

Export all valid Kubeflow Pipelines runtime configurations to /tmp/foo
elyra-metadata export runtimes --schema_name=kfp --valid-only --directory=/tmp/foo

This command creates the /tmp/foo/runtimes directory and stores all valid Kubeflow Pipelines runtime configuration instances in that directory.

Note:

The exported metadata format should be importable as is. This PR introduces CLI functionality that would already allow for import of these files, e.g. elyra-metadata install <namespace>, but should probably not be seen as a replacement for an elyra-metadata import command.

Thanks @sandhya-nayak!
Regarding the output directory (e.g., /tmp/foo/runtimes), I think we should tolerate its existence as well.  I suppose we could talk about whether the contents should be cleared or not.  I'm inclined to not clear contents.
When we get around to import, I think we should tolerate the specification of either /tmp/foo or /tmp/foo/runtimes when a schemaspace of runtimes is specified, since I believe the latter form will be more natural for folks.

As discussed in the Weekly Dev meeting, I'll be adding a "--clean" flag which would indicate that the user wants to clean out the folder for the schemaspace within the "--directory" (for e.g. delete everything inside /tmp/foo/runtimes). In the absence of the "--clean" flag, any exported file will overwrite the existing file with the same name leaving the others untouched.


typo in en.md in hello_world

Hello,

Why do I need to learn HTML?
HTML is a cornerstone of web. It's what you see I your browser every time you open a favorite site.

Perhaps it should be "...It's what you see in your browser..."?

Indeed. I have submitted pull #3.


Google Chrome | When bookmarksbar is show (ctrl + shift + b) sticky conteiner a little hide under bar

In Google Chrome (other browser do not testing) after using this plugin with jQuery, sticky container hide under bookmarks bar, when scroll down, and display good when scroll up

If this is still relevant, a screenshot would be helpful, thanks.

Ohhh, I can't even remember what kind of project it is)

Thanks, for your reply. At this momnet you cant close this issue


Install and configure Ubuntu WSL image

initial data entry for new user created during installation is acceptable

Added to default packages file


(build) Update choco-theme and resolve dependabot alerts

This will resolve dependabot security alerts and upgrade to the latest
choco-theme.
PRs from choco-theme include:

https://github.com/chocolatey/choco-theme/pull/105
https://github.com/chocolatey/choco-theme/pull/106

Testing:

After pulling down this PR, from the root of the repository run yarn audit.

It will find 0 vulnerabilities.

@designxsteph thanks for getting this fixed up!


Initial STM32L4 support + NUCLEO-L476RG BSP

All drivers are working correctly. The default clock rate of 4MHz does not allow newtmgr at 115200 (max is 57600 with 128 of mtu) but it works correctly when upgrading the clock to 8MHz. I have some local changes to the serial driver which I will first test on F3/F7. Also the flash driver is working correctly but there are some memcpying inside because fcb is returning non 8-byte aligned data. Will check how to fix that.

I think it would be nice to have separate commit for ST provided code. Then it would be easier to concentrate on mynewt code alone.

Yup, that's a pretty good idea, I will try to break it when it's done.

@kasjer I broke the commits as requested.

can we merge this?


Not working for gems with a gemspec but no Gemfile

I did check existing and past issues but nobody seems to have reported this already.
I use rubymine for both Reek and RubyCritic. Both projects use rubocop but since they are gems, rubocop is listed in the gemspec and not the Gemfile.
Is this something you have on your roadmap?

The Gemfile is only used to decide whether the command should be prefixed with bundle exec.
How dou you invoke rubocop from the CLI?

Also, out of curiosity: does it work if you put in a Gemfile with
source "http://www.rubygems.org"
gemspec

and run bundle install?

Also, out of curiosity: does it work if you put in a Gemfile with
source "http://www.rubygems.org"
gemspec

No, it is already like that.
Please see the screenshot attached as well.

So, I see this happening in the logs:
2015-11-25 15:29:11,246 [ 211606]  DEBUG - hub.sirlantis.rubymine.rubocop - Executing RuboCop (SDK=/usr/local/var/rbenv/versions/2.0.0-p647/bin, Bundler=true)/usr/local/var/rbenv/versions/2.0.0-p647/bin/ruby rubocop --format json /Users/marceljackwerth/Workspace/github/reek/lib/reek.rb

It thinks it should use bundler (which is correct) but then it doesn't use bundle exec in the call.
Wondering if this is a regression from #9 / https://github.com/sirlantis/rubocop-for-rubymine/commit/b755a0efcce40b1ce4bba7e82096d05b4d9f02fc

@sirlantis I'm seeing this same error after installing the plugin in rubymine and running inside a project with a Gemfile and the latest version of rubocop. Any troubleshooting/logging you'd like me to run?

I reproduced the issue and it should be fixed by 3.0.1 (submitted to Jetbrains right now)


Does not work with multi-color, multi-path svg

I tried using this with a two color svg. The react output shows that somewhere in the conversion process, the fill attribute was was lost on two of three paths. The paths were rendered, but came out black.
Original SVG

<path d="M23.5,16a.5.5,0,0,0,.5-.5V1a.5.5,0,0,0-.5-.5H21V12.998a3,3,0,0,1-3,3H13V16h1.1631a1.51,1.51,0,0,1,.9082.3062l4.9258,3.6909L20,16.7a.7.7,0,0,1,.7-.7Z" style="fill:#e8e5fe"/>

<path d="M14.3335,17H5.5A1.5,1.5,0,0,1,4,15.5V5H3V16.5A1.5,1.5,0,0,0,4.5,18L13,18l2.6659,2H18.333Z" style="fill:#e8e5fe"/>

<path d="M23.5.002H5.5A1.5,1.5,0,0,0,4,1.502V4H1.5A1.5,1.5,0,0,0,0,5.5v13.998a1.5,1.5,0,0,0,1.5,1.5H4V24a1.0009,1.0009,0,0,0,1.0044,1.002A.985.985,0,0,0,5.6,24.8l5.0664-3.8025L19.983,21l.0126.0022a1.0078,1.0078,0,0,0,.3764-.0737.5111.5111,0,0,0,.0432-.0278A.9817.9817,0,0,0,21,20V17h2.5A1.5,1.5,0,0,0,25,15.5V1.502A1.5,1.5,0,0,0,23.5.002ZM10.3306,20,5,24V20l-3.5-.002a.5.5,0,0,1-.5-.5V5.5A.5007.5007,0,0,1,1.5,5H4V15.5A1.5,1.5,0,0,0,5.5,17h8.8335l4,3ZM24,15.5a.5.5,0,0,1-.5.5H20v4h0L14.667,16H5.5a.5.5,0,0,1-.5-.5V1.502a.5.5,0,0,1,.5-.5h18a.5.5,0,0,1,.5.5Z" style="fill:#8075f2"/>

</g></svg>

React Converstion

const Conversation = props => (
  <svg viewBox="0 0 25 25" width="1em" height="1em" {...props}>
    <defs />
    <g id="budicon-conversation">
      <path
        className="cls-1"
        d="M23.5 16a.5.5 0 0 0 .5-.5V1a.5.5 0 0 0-.5-.5H21v12.498a3 3 0 0 1-3 3h-5V16h1.163a1.51 1.51 0 0 1 .908.306l4.926 3.691L20 16.7a.7.7 0 0 1 .7-.7z"
      />
      <path
        className="cls-1"
        d="M14.334 17H5.5A1.5 1.5 0 0 1 4 15.5V5H3v11.5A1.5 1.5 0 0 0 4.5 18H13l2.666 2h2.667z"
      />
      <path
        d="M23.5.002h-18a1.5 1.5 0 0 0-1.5 1.5V4H1.5A1.5 1.5 0 0 0 0 5.5v13.998a1.5 1.5 0 0 0 1.5 1.5H4V24a1 1 0 0 0 1.004 1.002.985.985 0 0 0 .596-.202l5.066-3.803 9.3<IP_ADDRESS>a1.008 1.008 0 0 0 .376-.074.511.511 0 0 0 .043-.027A.982.982 0 0 0 21 20v-3h2.5a1.5 1.5 0 0 0 1.5-1.5V1.502a1.5 1.5 0 0 0-1.5-1.5zM10.33 20L5 24v-4l-3.5-.002a.5.5 0 0 1-.5-.5V5.5a.5.5 0 0 1 .5-.5H4v10.5A1.5 1.5 0 0 0 5.5 17h8.834l4 3zM24 15.5a.5.5 0 0 1-.5.5H20v4l-5.333-4H5.5a.5.5 0 0 1-.5-.5V1.502a.5.5 0 0 1 .5-.5h18a.5.5 0 0 1 .5.5z"
        fill="#8075f2"
      />
    </g>
  </svg>
)

@beasleyz can you try to debug it using https://jakearchibald.github.io/svgomg/ this should be a SVGO issue.

Hello guys, have the same bug, any solutions?

Please fill a new issue in SVGO.


Updated dependencies

Codecov Report

Merging #373 (269e2a7) into 0.6.0-dev (c4fdd0b) will not change coverage.
Report is 1 commits behind head on 0.6.0-dev.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##           0.6.0-dev     #373   +/-   ##
==========================================
  Coverage      63.60%   63.60%
==========================================
  Files              4        4
  Lines            261      261
==========================================
  Hits             166      166
  Misses            75       75
  Partials          20       20

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fdd0b...269e2a7. Read the comment docs.


Uncaught Error: ENOTDIR: not a directory, scandir '~/Desktop/Work/peterandpauldev/lb.peterandpaul...

[Enter steps to reproduce:]

Sync a folder that doesn't exist on local yet

Atom: 1.14.4 x64
Electron: 1.3.13
OS: Mac OS X 10.12.3
Thrown From: Remote-FTP package 0.10.7
Stack Trace
Uncaught Error: ENOTDIR: not a directory, scandir '/Users/mac2/Desktop/Work/peterandpauldev/lb.peterandpauldev.co.uk/site/templates'
At fs.js:951

Error: ENOTDIR: not a directory, scandir '/Users/mac2/Desktop/Work/peterandpauldev/lb.peterandpauldev.co.uk/site/templates'
    at Error (native)
    at Object.fs.readdirSync (fs.js:951:18)
    at Object.fs.readdirSync (ELECTRON_ASAR.js:571:28)
    at Client.traverseTree (/packages/Remote-FTP/lib/client.js:596:31)
    at /packages/Remote-FTP/lib/client.js:672:18
    at tryApply (/packages/Remote-FTP/lib/connectors/ftp.js:16:14)
    at error (/packages/Remote-FTP/lib/connectors/ftp.js:125:13)
    at /packages/Remote-FTP/lib/connectors/ftp.js:147:33
    at final (/packages/Remote-FTP/node_modules/ftp/lib/connection.js:476:11)
    at Socket.ondone (/packages/Remote-FTP/node_modules/ftp/lib/connection.js:451:7)
    at Socket.g (events.js:286:16)
    at emitNone (events.js:91:20)
    at Socket.emit (events.js:185:7)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Commands
     -0:24.7.0 remote-ftp:sync-with-remote (span.name.icon.icon-file-directory)

Non-Core Packages
Remote-FTP 0.10.7
seti-icons 1.3.4

Related issue #112


[Event-Request] Codeunit 7304 Whse. Jnl.-Register Batch - OnBeforeDeleteWhseJournalLineAndSetupNewLine

Hi AL Team,
we need the following event in function Code:
         Init;
        "Line No." := WhseRegNo;

        // Update/delete lines
        // new event/code begin
        - if WhseRegNo <> 0 then begin
        + ForceDeleteAndSetupNewLine := WhseRegNo <> 0;
        + OnBeforeDeleteWhseJournalLineAndSetupNewLine(WhseJnlLine, WhseRegNo, ForceDeleteAndSetupNewLine);
        + if ForceDeleteAndSetupNewLine then begin
        // new event/code end
            // Not a recurring journal
            WhseJnlLine2.CopyFilters(WhseJnlLine);

...
[IntegrationEvent(false, false)]
local procedure OnBeforeDeleteWhseJournalLineAndSetupNewLine(var WarehouseJournalLine: Record "Warehouse Journal Line"; WhseRegNo: Integer; var ForceDeleteAndSetupNewLine: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Index file fix

Grammar fixes and fix QISKit in link

I don’t get your advance comment is this because I accidentally pulled in the change #300


Translation skipped for array accessed by relationship

While operation translations for simple types on owned entities are working well, array operations aren't getting translated into sql query.
public class Entity
{
    public int Id { get; set; }
    public OwnedEntity OwnedEntity { get; set; }
}

public class OwnedEntity
{
    public int[] Array { get; set; }
}

Configuration:
modelBuilder.Entity<Entity>(
  builder =>
  {
    builder.HasKey(s => s.Id);
    builder.OwnsOne(
      s => s.OwnedEntity,
      ownershipBuilder =>
      {
        ownershipBuilder
          .Property(entity => entity.Array)
          .IsRequired();
      });
  });

LINQ:
context.Set<Entity>()
  .Where(s => s.OwnedEntity.Array.Contains(1))
  .ToList();

Actual sql query:
SELECT s."Id", s."Id", s."OwnedEntity_Array"
FROM "Entity" AS s

Expected sql query:
SELECT s."Id", s."OwnedEntity_Array"
FROM "Entity" AS s
WHERE 1 = ANY (s."OwnedEntity_Array") = TRUE

Actual for: Npgsql.EntityFrameworkCore.PostgreSQL v2.2.0-preview1

This is actually unrelated to owned entities and can be reproduced with a regular one-to-one relationship as shown below. Seems like when an array property is accessed by traversing a relationship, for some reason we fail to translate to SQL.
@austindrenski I think you worked in these waters before, interested in taking a look? I won't have time to dive into this in the coming weeks...
class Program
{
    static void Main(string[] args)
    {
        using (var ctx = new BlogContext())
        {
            ctx.Database.EnsureDeleted();
            ctx.Database.EnsureCreated();

            // Produces good query:
            // SELECT s."Id", s."Array"
            // FROM "Posts" AS s
            // WHERE 1 = ANY (s."Array") = TRUE
            var posts1 = ctx.Posts
                .Where(s => s.Array.Contains(1))
                .ToList();

            // Produces bad query:
            // SELECT s."Id", s."PostId", "s.Post"."Array"
            // FROM "Blogs" AS s
            // LEFT JOIN "Posts" AS "s.Post" ON s."PostId" = "s.Post"."Id"
            var posts2 = ctx.Blogs
                .Where(s => s.Post.Array.Contains(1))
                .ToList();
        }
    }
}

public class Blog
{
    public int Id { get; set; }
    public Post Post { get; set; }
}

public class Post
{
    public int Id { get; set; }
    public int[] Array { get; set; }
}

public class BlogContext : DbContext
{
    public const string ConnectionString = "Host=localhost;Database=test;Username=npgsql_tests;Password=npgsql_tests";

    public DbSet<Blog> Blogs { get; set; }
    public DbSet<Post> Posts { get; set; }

    protected override void OnConfiguring(DbContextOptionsBuilder builder)
        => builder.UseNpgsql(ConnectionString);
}

Moving this to the backlog, @austindrenski you may be interested in this.

Yes, still interested... I need to wrap up a few more issues for 2.2 first, then I'll give this a look. It may also be worth waiting for #541 to merge, since that has an effect on how array translations evaluate.

I am unable to reproduce this with the test suite for dev (4441b26c54b0aaba0db2557d210212f48a31f3fc). So it looks like this will work as expected in v2.2.
Next I'll attempt to reproduce it with the test suite for hotfix/2.1.3 (cbbd243018f377083032e0111150950e06628498).
@roji Any ideas on what changed here?
[Fact]
public void Contains_with_navigation_property()
{
    using (var ctx = Fixture.CreateContext())
    {
        var _ = ctx.SomeEntities.Where(e => e.SomeRelatedEntity.SomeArray.Contains(3)).ToList();

        AssertContainsInSql("WHERE 3 = ANY (\"e.SomeRelatedEntity\".\"SomeArray\") = TRUE");
    }
}

public class SomeArrayEntity
{
    public int Id { get; set; }
    public int[] SomeArray { get; set; }
    public int[,] SomeMatrix { get; set; }
    public List<int> SomeList { get; set; }
    public byte[] SomeBytea { get; set; }
    public string SomeText { get; set; }
    public SomeRelatedEntity SomeRelatedEntity { get; set; }
}

public class SomeRelatedEntity
{
    public int Id { get; set; }
    public int[] SomeArray { get; set; }
}

-- full query output (formatted for clarity):

SELECT
  e."Id",
  e."SomeArray",
  e."SomeBytea",
  e."SomeList",
  e."SomeMatrix",
  e."SomeRelatedEntityId",
  e."SomeText"

FROM "SomeEntities" AS e

LEFT JOIN "SomeRelatedEntities" AS "e.SomeRelatedEntity"
  ON e."SomeRelatedEntityId" = "e.SomeRelatedEntity"."Id"

WHERE 3 = ANY ("e.SomeRelatedEntity"."SomeArray") = TRUE

Debugging in hotfix/2.1.3 shows that the issue is due to the navigation property being wrapped in a NullConditionalExpression, causing MemberAccessBindingExpressionVisitor.GetPropertyPath(...) to return no properties (i.e. properties.Count == 0).

We could simply unwrap NullConditionalExpression, but I'm a bit hesitant to do that because it's located in Microsoft.EntityFrameworkCore.Query.Expressions.Internal.
This does pass the test suite, but it feels risky for a patch release:
var subQueryModel = expression.QueryModel;
var fromExpression = subQueryModel.MainFromClause.FromExpression;

// unwrap and move on
if (fromExpression is NullConditionalExpression n)
    fromExpression = n.AccessOperation;

@roji Any thoughts on this?

@austindrenski thanks for deep-diving into this and for the good analysis!
I agree with everything you're seeing... If the bug no longer exists in 2.2 (which is about to be released), I don't see any reason to introduce a risky fix in a 2.1 patch release... Our answer here should probably be to just upgrade to 2.2.
From my side feel free to close this issue, unless you have other thoughts...

Sounds good to me, closing for now.


Add settings option to treat different instances of a class as different objects even if they are otherwise identical

The used Godot version:

Godot version 3.5
GdUnit3 version 2.4.1
OS including version:

Microsoft Windows 10 Home 10.0.19045 Build 19045
Describe the bug

The contains_exactly_in_any_order method for GdUnitArrayAssert does not work correctly for arrays of Resources. If an array of Resources contains Resources that are not supposed to be contained, the assertion does not fail.
Steps to Reproduce

Create a new test script file extending GdUnitTestSuite
Add the following test function:

func test_example():
	var r1 = Resource.new()
	var r2 = Resource.new()
	var a1 = [r1, r2]
	var a2 = [r1]
	assert_array(a1).contains_exactly_in_any_order(a2)

The expected behavior is that this test fails since a1 contains r2 in addition to r1. However, it passes instead.
I tested the same behavior with integers instead of resources and it worked properly:
func test_example():
	var a1 = [1, 2]
	var a2 = [1]
	assert_array(a1).contains_exactly_in_any_order(a2)

line <n/a>: Expecting contains exactly elements:
 1, 2
 do contains exactly (in any order)
 1
but some elements where not expected:
 2

Actually, it is even worse than I thought. It looks like different resources are not recognized as being different by GdUnit3:
func test_example():
	var r1 = Resource.new()
	var r2 = Resource.new()
	var a1 = [r1]
	var a2 = [r2]
	assert_array(a1).is_equal(a2)
	assert_object(r1).is_equal(r2)
	print(r1 == r2)

This passes, even though it shouldn't. (the print statement evaluates to false, confirming that Godot recognizes r1 and r2 as being different)

Dug a little bit deeper. I have a custom class called Monster that extends from Resource:
class_name Monster
extends Resource

var alignment : int

func with_alignment(value: int) -> Monster:
	alignment = value
	return self

The following test behaves as expected (it fails):
func test_example():
	var r1 = Monster.new().with_alignment(Alignment.GOOD)
	var r2 = Monster.new().with_alignment(Alignment.EVIL)
	assert_object(r1).is_equal(r2)

line 20: Expecting:
 <Resource>
 but was
 <Resource>

But if I give them the same value for alignment, it passes:
func test_example():
	var r1 = Monster.new().with_alignment(Alignment.GOOD)
	var r2 = Monster.new().with_alignment(Alignment.GOOD)
	assert_object(r1).is_equal(r2)

So without looking at the implementation, it seems to me that Resource equality is looking at whether two resources contain the same data to determine whether they are the same. My assumption as a user would be that Resource equality would look at the object reference so that different objects containing the same data would not be considered equal.
Assuming I am correct, is it intentional that object equality treats different objects as equal if they contain the same values? If so, I would recommend making a note of that in the documentation.

Sorry, just realized that the object assertions do in fact have is_same, which does what I want.
So I suppose the only real issue is that the array assertions always use is_equal rather than is_same. So that is the only thing I would request - a way to compare objects in arrays using is_same rather than is_equal (assuming I understand how it works).

Hello @ACG8 this is not an error ;)
Yes, your analysis is correct, GdUnit compares objects on their parameter equality.
So two "empty" resources are the same in the end.
To compare on object reference level there is the is_same in assert_object.
func test_example():
	var r1 = Resource.new()
	var r2 = Resource.new()

	# will success
	assert_object(r1).is_equal(r2)
	# will fail, is not the same
	assert_object(r1).is_equal(r2).is_same(r2)

Thanks! That is a very useful feature, now that I understand that it is not the only option. Is there a way to do the same thing for arrays of objects?

I understand your problem, this is not what a user expects at first ;)
It would probably be best to add a new option to disable the default depth comparison and then compare at object reference level.
e.g. under 'Asserts'
Strict object compare - 'Enables/disables to comapare objects by reference only'

Yes, that sounds perfect. Thanks!

for now you can do it manually.
To disable the deep check open res://addons/gdUnit3/src/core/GdObjects.gd line 213
and change the default deep_check :bool = true to false

Thanks! Super helpful. I really like GdUnit3, might make a tutorial video at some point.

I really like GdUnit3, might make a tutorial video at some point.

Thank you very much.
I would be very grateful. unfortunately I currently have no time to make tutorials. Am with GdUnit4 under full load

I'm going to close this topic because the proposed solution is not practical.
By default, GdUnit performs a deep comparison because Godot Object does not provide an Equal method and testing only by reference would break a lot of existing tests.
It would be better to add a flag to the assert verification is_equal to explicitly decide whether to test for object reference or object content in the test.
Since GdUnit3 is only in maintenance and I don't want to implement any new features here I will move the topic to GdUnit4 and implement it there.
Translated with www.DeepL.com/Translator (free version)


Broken path to types

Inside package.json:
"types": "./dist/types/index.d.ts"

should be
"types": "./dist/index.d.ts"

Looks like there's already a PR which fixes it #31

Please try<EMAIL_ADDRESS>thanks~

It works now, thanks.


chore: email login refactoring cleanup

Looks good so far. I am reading the ory documentation here https://www.ory.sh/docs/kratos/self-service/flows/verify-email-account-activation specifically the section on Attempted verification notifications and they reference this troy hunt article about account enumeration attacks https://www.troyhunt.com/website-enumeration-insanity-how-our-personal-data-is-leaked/ . We might want to consider also enabling a few more settings to prevent this.
flows:
  verification:
    enabled: true
    lifespan: 15m # Defines how much time the user has to complete the verification flow in the UI. Default: 1h.
    use: code # Defines which method is used, one of 'code' or 'link'.
    notify_unknown_recipients: true # Defines if the system sends attempted verification notifications to unregistered addresses.

should we expose the addEmailToIdentity via a graphql mutation or HTTP POST /auth/add/email?

should we expose the addEmailToIdentity via a graphql mutation or HTTP POST /auth/add/email?

not sure. I think the one of the heuristic I want to think about when doing auth related query is whether it requires an existing token or not. if it does, maybe using the graphql makes more sense because it simplify client side implementation? (ie: the upgrade path). but the login path should be more rest based.


initialize must be fault tolerant

every time zone.js library is attempted to be loaded multiple times it throws an exceptions and breaks everything on page, please change this to reuse already loaded instance (as it relies on globals and patching) as web and js is full of unstrict things and shouldn't behave like Clang apps and falling with segfaults and everything if anything.

@syncro , have been resolved by #1093


vue-i18n throws many warnings

Version
1.0.0-beta.16
Reproduction link
https://vue-test-utils.vuejs.org/
Steps to reproduce
I am using vue-i18n in my application, loading it via my Vuex store. Vue-test-utils throws a warning for every string:
WARN: '[vue-i18n] Cannot translate the value of keypath "error_went_wrong". Use the value of keypath as default'
WARN: '[vue-i18n] Cannot translate the value of keypath "common_retry". Use the value of keypath as default'
WARN: '[vue-i18n] Cannot translate the value of keypath "error_notification_history". Use the value of keypath as default'

What is expected?
No warnings should be throw
What is actually happening?
Warnings are thrown

I am using vue-i18n in my application, loading it via my Vuex store.

Please provide a reproduction. We can't work with a one-sentence description.

Closing for inactivity and missing reproduction.
We can consider reopening once a reproduction is provided.

I think its practically impossible to reproduce this as its in a complex corporate private repo with many dependencies but I understand that this could be the way to debug it.
I googled around and I've seen several issues with the same warning so I imagined there's some past experience/helpful tips on why this is happening.

past experience/helpful tips

Consider asking on forum.vuejs.org or chat.vuejs.org

why this is happening.

Since you didn't share your test code, I have to blindly guess what you might have done wrong. I will guess once:
You did not register the plugin with the local Vue instance created with createLocalVue().
If you did take care of that, then I'm out of things to guess.

good guess as I didn't actually do that. Do I have to do it in every component using it or can I do it somehow in my setup?

I'm not very familiar with th different ways of setting up that pugin - a good moment to switch to one of the sources I mentioned to ask other for help with that.

Likely this is due to how we've implemented sync behavior in beta.12. There are similar issues about warnings being thrown because we set the main render watcher to sync after it's initially run.
The temporary fix is to run with sync set to false, and use Vue.nextTick to await re renders:
test('use Vue.nextTick', (done) => {
  const wrapper = mount(TestComponent, { sync: false })
  wrapper.trigger('click')
  Vue.nextTick(() => {
    expect(wrapper.text()).toBe('updated')
    done()
  })
})

We're working on a solution right now that should be out in the next few weeks.


fix(package.json): add server.js to npm files array

@halt-hammerzeit This should fix #263, take a look please.

I approve this


Solax Cloud Meters: Set Tokenid String Type

Always treat template tokenid parameter as to be a string.
Refer to discussion #7889

This PR is a nop- the default type is always string.


No feedback when saving permissions on "Sharing" page

The user is getting no feedback when clicking the "save" button. The permissions are saved though (that's good!).
volto 3.2.7 / Plone 5.1.6
volto 4.0.0-alpha.10 / Plone 5.2

Currently there is a toast message after saving.


Auto-fuzz: Fix java merge

This PR fixes the merging of successfully generated java fuzzer. The new logic combines all successful fuzzers into a single java fuzzer Fuzz.java in order to significantly reduce the time needed for processing separate fuzzers. It also gathers the heuristic success ratio information and displays it at the end of the merging process to act as a benchmark on analysing the quality of each heuristic for discovering limitations and next step improvement of the java auto-fuzz process.

This PR will need rebase after #1071 is merged in.

This is ready for rebase


add bilstm layer

Hi,
It s me again, I opened a new issue because I tried to add a BILSTM layer to see if it ganna enhance the performance or not
Actually the enhancement was not impressive ~2% between two models
I wanted to share with u how I did to add the BILSTM layer and see if I did it correctly or not because I am a newbie in deep learning and I am trying to make my first model for a project study
  class Bert_Bilstm_CRF(BertPreTrainedModel):
def __init__(self, config):
    super(Bert_CRF, self).__init__(config)
    self.num_labels = config.num_labels
    self.bert = BertModel(config)
    self.rnn = nn.LSTM(bidirectional=True, num_layers=2, input_size=768, hidden_size=768//2, batch_first=True)
    self.dropout = nn.Dropout(config.hidden_dropout_prob)
    self.classifier = nn.Linear(config.hidden_size, self.num_labels)
    self.init_weights()
    self.crf = CRF(self.num_labels, batch_first=True)

def forward(self, input_ids, attn_masks, labels=None):  # dont confuse this with _forward_alg above.
    outputs = self.bert(input_ids, attn_masks)
    sequence_output = outputs[0]
    enc, _ = self.rnn(sequence_output)
    sequence_output = self.dropout(enc)
    emission = self.classifier(sequence_output)
    attn_masks = attn_masks.type(torch.uint8)
    if labels is not None:
        loss = -self.crf(log_soft(emission, 2), labels, mask=attn_masks, reduction='mean')
        return loss
    else:
        prediction = self.crf.decode(emission, mask=attn_masks)
        return prediction

Yes, you defined the model correctly.

ok thanks for answering


set up your Kanban board

Note: For this project our group has two members.
the Link : https://github.com/Graciano1997/space_travelers_hub/projects/1

STATUS: APPROVED 🟢
Hi @Graciano1997 and @mumbereh ,

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
(Highlights) Good Points: :+1:

You documented your work professionally. ✔
Project created based on the template. ✔
The tasks are successfully been assigned between the team members. ✔
The expected number of cards has been added and all cards have descriptions. ✔ 🎉  🎉  🎉

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@ridwanediallo  I want to thank you for recognizing all our efforts ... 👍 👍 👍 👍


Adds technology class

Per the conversation from yesterday's (9/15/22) group meeting, I am approaching the design from a new angle (adding technology classes and a dispatch problem). This PR is the first of this approach and includes a base technology class, tests, and documentation. This PR includes:

osier.technology which defines the technology baseclass
imports osier.technology in the __init__.py file.
a new docs directory "reference" that contains a single index.md file. Enabling future additions to the API reference.
adds tests for osier.Technology (see below for code coverage report).
adds a dependency for unyt in setup.py

Code coverage
(base) C:\Users\samgd\Research\osier>pytest --cov=osier
========================= test session starts ==========================
platform win32 -- Python 3.9.12, pytest-7.1.1, pluggy-1.0.0
rootdir: C:\Users\samgd\Research\osier
plugins: anyio-3.5.0, cov-3.0.0
collected 12 items

tests\test_technology.py ............                             [100%]

---------- coverage: platform win32, python 3.9.12-final-0 -----------
Name                  Stmts   Miss  Cover
-----------------------------------------
osier\__init__.py         1      0   100%
osier\technology.py     116      0   100%
-----------------------------------------
TOTAL                   117      0   100%

========================== 12 passed in 1.94s ==========================

Closes #10
Edit: updates the code coverage  (99% --> 100%)

@LukeSeifert thanks for taking a look at this! I think you can merge at will.

@ZoeRichter they're easter eggs ;). Thanks for checking it out, merge at will!


Flickering page problem in Webapps CIO demo page

Hi,
I noticed that our CIO dashboard implementation has just started to behave weird after we upgraded to September 2018. As I want to do a double check and try to find a difference, I looked at the demo CIO page and I came across the very same issue also here:
https://webapps.qlik.com/CIO/index.html
The weird thing is that especially in Chrome, page is like blinking / flickering, it turns out to be complete white for a short moment. And this is continuous.
I suspect that demo page is based on June 2018 which is also using Angular 1.6.9.
This may be a root cause.
And I also found similar issues telling this flickering thing:
https://github.com/angular/angular.js/issues/15461
I will look into this in detail but I wanted to inform you as well.
Many thanks,

Thank you nicefella
I do not seem to replicate the issue. The page looks fine to me. We are still in June, that is correct.
I will keep on monitoring

I do not think I am using ng-show. I am using routes and animate.css for the transition effects


Add target to tagView + removeButton for delegate to work

Currently if you create tagView instances and add them to tagList, delegate does not work.
And even if you try to attach selectors by yourself, removeButton is private property and you are not allowed to do so.
So I've added missing methods to tagListView to behave same as you add tags with :String

Would you like to add these methods in TagView.swift file?

Why there, there is no logical connection between TagView and TagListView in terms of delegation of events. On the other hand, what we should do is to make sure that onTap methods can be applied as well instead of delegate. So every TagView should have - onTap (whole cell), onRemoveTap (remove button) and longPress event...


Print raw json

Description & motivation 💭
When ?json searchParam is added to a Workflow Execution URL, print the Workflow, Pollers, and Event History data as plain text.
Helpful for debugging large events. Payloads will not be decoded.
Screenshots (if applicable) 📸

Design Considerations 🎨
Testing 🧪
How was this tested 👻

[x] Manual testing
[ ] E2E tests added
[ ] Unit tests added

Steps for others to test: 🚶🏽♂🚶🏽♀
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?

This is really made for support, and def can think about adding filters in future. But for now the use case is just the ability to see the full JSON from a url. I don't see support doing filters and such and then adding ?json.


initial support continuous scales

TODO: make sure to allow users to pass custom scales, and add a "palette of continuous scales" as well.


use correct env variable to check

Now that we have a run with the env variable dump, adjust the check to look for the correct variable

Codecov Report

Merging #10791 (750ff29) into main (aaf4210) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #10791   +/-   ##
======================================
- Coverage     62%      62%   -1%
======================================
  Files        476      476
  Lines      33058    33058
  Branches    5391     5391
======================================
- Hits       20765    20747   -18
- Misses     10257    10271   +14
- Partials    2036     2040    +4

Impacted Files
Coverage Δ

src/kernels/common/chainingExecuteRequester.ts
66% <0%> (-17%)
:arrow_down:

src/kernels/execution/cellExecution.ts
71% <0%> (-8%)
:arrow_down:

src/notebooks/outputs/tracebackFormatter.ts
93% <0%> (-7%)
:arrow_down:

src/platform/common/cancellation.ts
64% <0%> (-4%)
:arrow_down:

src/kernels/installer/pipInstaller.node.ts
67% <0%> (-3%)
:arrow_down:

src/kernels/jupyter/baseKernelConnectionWrapper.ts
30% <0%> (-3%)
:arrow_down:

src/platform/telemetry/interpreterPackages.node.ts
81% <0%> (-2%)
:arrow_down:

src/kernels/common/baseJupyterSession.ts
76% <0%> (-1%)
:arrow_down:

src/platform/msrCrypto/msrCrypto.js
16% <0%> (-1%)
:arrow_down:

src/platform/common/utils/localize.ts
76% <0%> (+<1%)
:arrow_up:

... and 4 more


Create 1.22 release branch

Upstream created release-branch.go1.22 today, we should start tracking it.

We should get https://github.com/microsoft/go/issues/1096 done (merge https://github.com/microsoft/go/pull/1097) first.

depends on https://github.com/microsoft/go/issues/1096


upgrade to Cake 4.0

long time no see
upgrade to Cake 4.0

order of TargetFrameworks changed - thanks @augustoproiete


FAQ Link #vac_cert_booster does not display requested FAQ section on mobile device

Where to find the issue
https://www.coronawarn.app/en/faq/#vac_cert_booster
Describe the issue
If the FAQ link "For further information, please see our FAQ page." (https://www.coronawarn.app/en/faq/#vac_cert_booster) is followed in the CWA app under "Note on Booster Vaccination" and the mobile device is in portrait mode, then no useful information is shown in the web browser. Instead only top-level FAQ topics are shown.
Steps to reproduce
In app
Mobile device is connected via WLAN

Tap Scan and scan in a 2/2 vaccination certificate
Tap back-arrow
Tap Certificates
Tap right-arrow
Tap "Note on Booster Vaccination"
Tap on link at bottom of text to Rule DE-BNR-0110 "For further information, please see our FAQ page."
Note that browser first goes to https://www.coronawarn.app/en/faq/#vac_cert_booster then to https://www.coronawarn.app/en/faq/results/#vac_cert. The display however shows only topic sections.

Edit: The above steps work in CWA 2.25. Starting with CWA 2.26 the target link has changed and the steps no longer show the issue.
In browser

Open Google Chrome on a desktop
Press F12 for developer mode
Toggle device toolbar and select Samsung Galaxy A51/71 in portrait mode with throttling set to Mid-tier mobile
Paste https://www.coronawarn.app/en/faq/#vac_cert_booster into address field and press Enter
Note that only section headers are shown and these do not lead to information about vaccination certificate boosters.

Expectation
When using the link on a mobile device to open https://www.coronawarn.app/en/faq/#vac_cert_booster, the section FAQ > App Features > Vaccination Certificates should be shown.

Workarounds

The following is not a useful work around in practice, however it shows that the issue is with the website in portrait mode.In the app "Steps to reproduce" above, before tapping on the link "For further information, please see our FAQ page.", turn the mobile device into landscape mode.
Scroll up to search field. Enter word "booster", select section "App Features", tap "Search". Scroll down to search results.

Background information
Before the FAQs were reorganized, the link https://www.coronawarn.app/en/faq/#vac_cert_booster displayed a list of links:

This list was removed and the nearest equivalent was the section heading above this list which is https://www.coronawarn.app/en/faq/#vac_cert.

Internal Tracking ID: EXPOSUREAPP-14102

This issue may be mitigated by CCL PR https://github.com/corona-warn-app/cwa-app-ccl/pull/90 which changes the FAQ anchor in use from #vac_cert_booster to #vac_booster_basics. Although the PR is merged, it is not yet in production (see https://github.com/corona-warn-app/cwa-app-ccl/issues/88#issuecomment-1223713618).

This issue is mitigated by CCL 3.2.1, however the underlying website issue is still present and the steps to reproduce using a desktop browser simulating a mobile device are still able to demonstrate the issue:
In browser

Open Google Chrome on a desktop
Press F12 for developer mode
Toggle device toolbar and select Samsung Galaxy A51/71 in portrait mode with throttling set to Mid-tier mobile
Paste https://www.coronawarn.app/en/faq/#vac_cert_booster into address field and press Enter
Note that only section headers are shown and these do not lead to information about vaccination certificate boosters.

@MikeMcC399 Thanks for reporting. FYI PR https://github.com/corona-warn-app/cwa-website/pull/3138


Is API in Programming Guide old version of ESP-Now?

I wanna use esp-now in my little project of ESP8266,i try to find reference in programming guide,and later i saw this.
the API is not the same ,so is this new version of ESP-Now?If so,is there any examples of old version.
Thanks

This esp-now project is application of esp now, based on the api defined in IDF esp_now.h.  Please refer to IDF/example/wifi/espnow to use the basic esp-now apis.

Thank you.
This helps a lot. :)

Thank you.
This helps a lot. :)

This esp-now project is application of esp now, based on the api defined in IDF esp_now.h. Please refer to IDF/example/wifi/espnow to use the basic esp-now apis.

Thank you.
This helps a lot. :)

This esp-now project is application of esp now, based on the api defined in IDF esp_now.h. Please refer to IDF/example/wifi/espnow to use the basic esp-now apis.

Thank you.
This helps a lot. :)


typo

azure cli on "List virtual machines with their network interface and public IP" should start with az instead of azure

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac94b233-b387-fd3e-1942-83044d29fc80
Version Independent ID: f6554623-0d7b-f4cc-fc00-8616010f0714
Content: Advanced query samples - Azure Resource Graph
Content Source: articles/governance/resource-graph/samples/advanced.md
Service: resource-graph
GitHub Login: @DCtheGeek
Microsoft Alias: dacoulte

@jeangougou Thanks for your feedback! We will investigate and update as appropriate.

@jeangougou Thanks for letting us know about this! We're going to go in and make that change accordingly.
Please let us know if there are anymore questions within the scope of this git issue. If not, I will be closing out this git issue by end of day today. Please file a new git issue with a reference to this one if you have anymore concerns. Thanks


showControls doesn't work dynamically

I have this component:
class CommonChart extends React.Component {
  constructor(options) {
    super(options);
    this.state = {show: false};
  }
  onClick = () => {
    this.setState({show: !this.state.show});
  }
  render() {
    return (

        <button onClick={this.onClick}>change state</button>
        Show: {""+this.state.show}
        <NVD3Chart showControls={this.state.show} {...this.props}/>

    );
  }
}

After first click on the button Controls (Grouped and Stacked) are showing, but after next click they doesn't disappear.
I'm going to investigate it and to try to fix it.
Related to #4 and #5
hmm.. I think this is nvd3 problem
Yes, they just don't remove controls after showControls updating. I'm going to create PR there: https://github.com/novus/nvd3/pull/1413
I don't know who have to update Controls -- react-nvd3 or nvd3.
@topicus , what do you think?

I have been out of pocket thia week. Today I am going to take a look at this. Thank you for your help.

Seems to be an NVD3 issue:

Using showControls directly and calling the update method doesn't change the controls visibility.
Using options({showControls: !chart.showControls()}) produce the same behavior you were found in react-nvd3
Legend component seems to be working in a similar way
Other parameters works fine

https://github.com/novus/nvd3/pull/1436


blog: Explain the exec nodes

Recently I got the question why the exec nodes were disabled on FlowForge Cloud, but there's cases you'd not disable them for each stack. While this blog post doesn't explain that, it explains the basic knowledge I assumed others to have for my explanation.
This blog post builds a basis on which to build in follow ups, for example: why is stdin missing? How doe FileDescriptors work, and how does that influence the exec node? And in what cases do we need the exec nodes?

@ZJvandeWeg I've made some commits, can you review? Otherwise I was happy with the PR.

@robmarcer looks good to me, ready to be published when it fits in the schedule


Typo: "SetRequiredMembersAttribute" should be "SetsRequiredMembersAttribute"

On https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-11.0/required-members#setsrequiredmembersattribute
Where it is written:
SetsRequiredMembersAttribute
All constructors in a type with required members, or whose base type specifies required members, must have those members set by a consumer when that constructor is called. In order to exempt constructors from this requirement, a constructor can be attributed with SetRequiredMembersAttribute, which removes these requirements. The constructor body is not validated to ensure that it definitely sets the required members of the type.
Should be:
SetsRequiredMembersAttribute
All constructors in a type with required members, or whose base type specifies required members, must have those members set by a consumer when that constructor is called. In order to exempt constructors from this requirement, a constructor can be attributed with SetsRequiredMembersAttribute, which removes these requirements. The constructor body is not validated to ensure that it definitely sets the required members of the type.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 491550b6-23f8-a48a-c6e5-f177151030ff
Version Independent ID: 4037b376-e4f6-73cc-3dd1-abea0fc7db5b
Content: Required members - C# 11.0 draft specifications
Content Source: proposals/csharp-11.0/required-members.md
Product: dotnet-csharp
Technology: csharp-spec
GitHub Login: @dotnet-bot
Microsoft Alias: wiwagn

Fixed in https://github.com/dotnet/csharplang/commit/00993c98cecc3e431458a1a17f346db0cebb673f

Perfect, thank you @agriffard - closing as already addressed.


Adding an image indexer

The backend is going to be placing images in the frontend's static files
location, but the client-side JavaScript needs a way of knowing what files
are there. The images indexer (and API) give the client-side JavaScript an
index of these files.

Coverage increased (+25.3%) to 46.875% when pulling a94e3501aeacb8bda4712350cf3565249c0facab on mtlynch:image-indexer into baa162802f4db9a584ada6b392884221f8356825 on JeetShetty:master.

Coverage increased (+25.3%) to 46.875% when pulling 13ba2f22e7b703afd67ebe16fd6b9ea8611be7b1 on mtlynch:image-indexer into baa162802f4db9a584ada6b392884221f8356825 on JeetShetty:master.

Coverage increased (+25.3%) to 46.875% when pulling 8a83d1560daf48c72b157598de4e974a36b604ee on mtlynch:image-indexer into baa162802f4db9a584ada6b392884221f8356825 on JeetShetty:master.


encoding issue

Hi
Here is something I'll have trouble fixing on my own
Debug: Wildfly_resource[/subsystem=datasources/jdbc-driver=OracleDriver](provider=http_api): Exists? /subsystem=datasources/jdbc-driver=OracleDriver
Error: /Stage[main]/Main/Wildfly::Datasources::Driver[driver journal-BDRBGODS]/Wildfly::Util::Resource[/subsystem=datasources/jdbc-driver=OracleDriver]/Wildfly_resource[/subsystem=datasources/jdbc-driver=OracleDriver]: Could not evaluate: undefined method `encoding' for nil:NilClass

Could you provide your execution log with --trace?

I'll close this, but feel free to contact me if you still need help with this.


Make sure assetslib does not see no needed files.

When installing through AssetsLib

on has to unselect some files and others are unnessary to see.

By adding .gitattributes your ZIP download gets way smaller.
See also https://github.com/bitwes/Gut/blob/master/.gitattributes and https://github.com/clemens-tolboom/godot_3_spawn_points/blob/develop/.gitattributes and their ZIP downloads at both GitHub and AssetsLib

Thanks!


Matrix Interaction Buttons

Although the date of this page is 5/28/2019, the buttons shown in screenshots are still from the older version of Power BI.  Please update with screenshots from the newer version.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3825d5bd-51e3-468a-0f7d-a936083f0dc5
Version Independent ID: 59eea08a-c392-951e-2ba6-860cfcc58281
Content: Use the matrix visual in Power BI - Power BI
Content Source: powerbi-docs/visuals/desktop-matrix-visual.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @mihart
Microsoft Alias: mihart

Hi, @ferdsjoseph -- you are so right! When the product changes as much as it did this time, we have many, many screen shots to update. We try to get to them expeditiously. I'm assigning your comment to the author, who is I'm sure already aware of the update.
Thanks for your attentive reading, and for using Power BI!

Hi @ferdsjoseph ,
Thank you for your feedback.  The matrix article is being updated this week, so look for the fresh new screenshots no later than next week.

Thank you!


This version is not compatible with the new Mac Version 14.0

Dang it... is there any alternative??