⚠ Samsung has degraded performance

In 9b6ce7a, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2267 ms

Resolved: Samsung performance has improved in 2ce467c.


Question marks in passwords

Enables the use of question marks in Postgres connection string passwords

Not sure how I feel about this.  Was there an issue opened on node-postgres about this?
cc @brianc

@phated, No, AFAIK no issue was ever opened. I was using a module (https://github.com/evs-chris/node-postgres-gen) that kind of circuitously used this library to parse connection strings. My database connections were timing out, and I realized that they weren't being parsed correctly due to a question mark in the password. I had no problems connecting to Postgres using psql, and Postgres had no qualms setting a password with a question mark, but the URL parsing took the question mark to be the beginning of a query string.
Eventually I just changed the password to something that didn't utilize that character, so everything is hunky-dory now. Thought this might save some future headaches, though, in case anyone ever ended up with the same problem.

That's fair.  I wonder if we could just escape the connection string better or tweak the regexp.  Just seems like the implementation is complex for the support.

Agreed. It's not a very concise solution at all. If I get some free time I'm happy to revisit the code and try to consolidate things.

I've been looking at this, and I'm not sure if we should solve this with a complicated parsing step.
Technically, any URI with a username/password containing unescaped reserved characters is malformed, and I don't think the library should be expected to accept and fix a broken URL. The general expectation is to encode the username and password fields prior to building the url: postgres://usern%40me:pass%3Ford@localhost/test. Once the URL is formed, it's significantly harder to determine where the username and password especially if we potentially have unescaped reserved characters in the content.
Unfortunately I don't think this current solution will work out, and might even introduce more bugs than it'll fix. The parsePostgresURL method doesn't seem to handle potential edge-cases very well (extra @, :, other weirdness), and only supports postgresql:// when postgres:// which is a valid alternative.
I think for simplicity's sake, we shouldn't really attempt to repair malformed urls. There is some existing functionality that attempts to repair unescaped spaces, but extending that to cover reserved characters like ? and @ would add considerable complexity due to their role in the URI structure. I would argue that we should reject obviously malformed URLs more loudly, but since this is only a passthrough library we can't really make that decision without potentially harming client implementations.
@webnard Can you verify that encoded url strings work in your situation? I'm going to close this issue, but if you run into any problems please don't hesitate to open an issue.

I agree with @2fast2fourier on this

Technically, any URI with a username/password containing unescaped reserved characters is malformed, and I don't think the library should be expected to accept and fix a broken URL

D'oh! I hadn't even thought about that. You're right: encoded strings seem to work fine. Apparently libpq's implementation of URI parsing per RFC 3986 (which it references) is incorrect, as it looks like it only checks for @ as an end-of-password delimiter.
Thanks for the help.


Better prompt out of the box

steps
Use sbt with a multi project build.
problem
The prompt just says >.
expectation
The prompt defaults to something that tells what your current project is.

We should poll the peoples. Because I like the minimal/no boilerplate default we have currently (and hate sbt-play messing with it).

This is analogous to sbt not shipping bash script sbt so ppl can customize it, like solder-it-yourself mechanical keyboard kit. Advanced users can change it back to >.

The equivalent to "solder-it-yourself mechanical keyboard kit" is probably "custom build sbt with your own prompt". We provide convenient settings to change the prompt. This is just about the default value.
The current implementation (0.13.x/1.0.x) is > . You mentioned current project. What about current directory? What about current date/time? Current user? Current branch? Current git status? Current battery percent? Current song playing? Current AAPL price?
You and I can change it to whatever. But to change the default we should poll the users, see what wins, and switch to that.

https://twitter.com/eed3si9n/status/884914670351659009

Project name would be really nice for first time users. It makes it easier and more comfortable to make a multi project build too.

Current user? Current branch? Current git status? Current battery percent? Current song playing? Current AAPL price?

lol

fwiw, I almost never use project to change projects, typing foo/ before things seems to me like a cheap price to pay for the gold of statelessness. ymmv

One nice side-effect of using the current project as the default prompt is there will probably be less root projects named "root".

I believe it makes life easier for beginners if the current project name is displayed by default. Anything that makes the shell a friendlier experience for beginners is a good thing IMO.
I've seen quite a few really confused devs losing track of where they are inside the shell. Until I've given them a customized prompt with a bit more contextual info.
Personally I just customize the prompt. But that's not something beginners will do.


Feature request: Handle collisions with different kinds of mobs differently

I am working on this for my own use. Please let me know whether this would be desired in the release.
Currently collisions of carts with mobs are controlled by one setting (collision.mobs) which manages collisions with animals, monsters, villagers, and pets. I would like this to be more granular. For example, I might want to have the train kill monsters, have animals enter, and have pets be ignored.
I propose these categories:

Tamed animals (aka "pets") -- tamed horses, cats, dogs
Other animals (including untamed horses, wolves, ocelots)
Monsters
NPCs

This would be backward compatible:

Any reference to "mob" in the configuration files would be replaced by new entries for animals, monsters, NPCs, ...
Any reference to "mob" on signs would set collision modes for all of the above entity types.

I've got this as a work in progress here and here

Very cool idea, only I think that you should use the mob categories.

Passive
Neutral
Hostile
Tameble
Utility
Boss

:+1: I'll keep this as a work in progress in my branches until it's done.

Those are the Mob categories provided by the Minecraft Wiki.


JOINDIN-143 show links on talk page

Show all links on the talk page

Can one of the admins verify this patch?

ok to test

Is there a joindin logo I can use for the previous talks link ? Currently its re using the code link but should really be updated to be a joindin one.

Really your options are:
https://joind.in/img/apple-touch-icon.png
or
https://joind.in/favicon.ico

Or shrink down this one: https://joind.in/img/event_icons/none.png


Fix some issues in StreamOps.intersection()

Previously, it was throwing ArrayIndexOutOfBounds when an odd number of streams is passed in, and only the first stream, and the (n/2+1)th element were intersected.

Thanks @jakebman ! This does look a lot better!


Adjust icon badge size

This PR fixes https://github.com/microsoft/azuredatastudio/issues/15254
Fixed for both the default and asyncTree
Earlier -

After change -

The connected scenario (green badge) looks the same.

Actually - can you look into just using px for this? em doesn't really make sense here - typically that should only be used for text so it scales properly. I'm guessing the root font-size changed with the merge that caused this.

@Charles-Gagnon px is actually absolute size, so it doesn't scale with screen size/resolution. I think em might be the correct solution here.

Pull Request Test Coverage Report for Build 797798071

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 43.513%

Totals

Change from base Build 797557598:
-0.002%

Covered Lines:
26370

Relevant Lines:
55175

💛  - Coveralls

That's what I'm saying. We don't want this scaling with respect to font-size (which is what em and rem do. That doesn't make sense - this isn't a font. It's an icon (and one that is a static size itself). So we should be using px here instead.


Uploaded Video is playing without the sound

Hello,
When I use a video component, the video is playing but no sound in Chrome and in Firefox.

Hello!
Playback of any media that includes audio is generally blocked if the playback is programmatically initiated in a tab which has not yet had any user interaction.
https://developer.mozilla.org/en-US/docs/Web/Media/Autoplay_guide

The autoplay of video content works fine in fact. The only problem I am experiencing is the lack of audio. But, thank you for the clarification. I will test it after invoking a user interaction. I can embed youtube video as a HTML code in the scene. Though I like a lot TuesdayJs native embeded video, especially, that I can navigate automatically to another slide once vide is over.
Thank you...

Btw, I think we can close this one. The issue was on my side. There is a slider sound in video properties, it was set to 0. After all both audio and video works fine. Thank u!!

Not an issue.


Support installing and uninstalling on Fish shell

Previously, the install script mentioned $PATH modifications that do not
apply to Fish. Users may have thought everything was all set up, only to
find invoking the poetry executable would fail in a Fish shell
environment because Poetry's bin directory could not be found on $PATH.
Now, if Poetry's bin directory is not found in Fish's $PATH environment
variable, that directory is added to the fish_user_paths universal
variable, making the poetry executable immediately available to
current and future Fish shell sessions.
Fixes #544

@stephsamson: Thanks for reviewing. As far as I can tell, that appears to be a glitch with GitHub Actions. If you look at the output, the cause shows:
##[error]fatal: couldn't find remote ref refs/pull/1535/merge

The actual linting step appears to pass without problems. Would you mind taking another look?

@stephsamson: I triggered a new build, and I suspected, this was most likely a GitHub CI glitch. All tests are now passing — I think this is ready to merge.

@justinmayer woo! Thanks @justinmayer 🚀 one more thing, it makes more sense to merge this against master instead of develop so that other fish users can have this ASAP. I'll merge it on that branch :)


"expand selection" behaves inconsistently

Environment data

Language Server version: 2023.5.20
OS and version: Mac OS 13.3.1 (a)
Python version (& distribution if applicable, e.g. Anaconda): Python 3.10.11., via Miniconda (v. 23.3.1)

Code Snippet

dict = {
    "key1": [1, 2],
    "key2": ["a", "two words", "the"]
}

Repro Steps

Place cursor inside of "two" and execute Expand Selection multiple times.

Expected behavior
The iterative selection should be the same each time and not be affected by a previous selection or a new line.
Actual behavior
The first selection extends in 5 steps until the entire line is selected. After deselecting, the same selection proceeds in only 2 steps. After entering some text on a new line, the selection takes 5 steps again.
 We were making an unintentional change to our parse tree when expand selection was run the first time. Changing the document caused a reparse which was why it worked as expected after a doc change.

This issue has been fixed in prerelease version 2023.5.41, which we've just released. You can find the changelog here: CHANGELOG.md


Add proof for RSA-PSS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@apetcher-amazon the RSA proof requires the latest SAW, I am working on updating SAW in the CI.


Add support for reading EmulationModel results

This PR adds interfaces to read emulation model results for simulations. It also fixes some consistency in terminology used in the results interfaces.
We discussed the possibility of adding len as an option to decision model simulation results. That is not present here.

c620eba

@claytonpbarrows I'm not sure I totally follow.  Please feel free. In case we are missing each other and you are referring to SimulationProblemResults, I expect that you should be getting timestamps in all cases already. Let me know if you aren't.

Yeah. That was poorly conceived comment. I'll make a PR to address once @jd-lara reviews and this is merged.

@claytonpbarrows I merged the PR already so I can rebase the large PWL PR on top of this one.


pylru is not in requirements.txt, but dev_server doesn't work without it.

We should make the dev server do no caching so that it doesn't require pylru.

Done!


components/lwip: errno.h should not be included if LWIP provides errno. (IDFGH-7377)

The standard <errno.h> should not be included directly in cc.h, to allow lwip to provide error numbers (via LWIP_PROVIDE_ERRNO) or a custom errno.h (via LWIP_ERRNO_INCLUDE).

Hi @iabdalkader
Thanks for the PR, we will not merge this.


A 10 line script takes 40 seconds to transpile

Hi!
We use typescript to transpile some es6 modules. I recently found a very annoying piece of code in moment  library that just hangs typescript for 40 (!!!!) seconds
TypeScript Version: 2.6.0-dev.20170824
Code
const ts = require("typescript")
const start = new Date().getTime()
let result = ts.transpileModule(`
let seconds, minutes, hours = 0;
let thresholds = {}
var a = seconds <= thresholds.ss && ['s', seconds] ||
    seconds < thresholds.s && ['ss', seconds] ||
    minutes <= 1 && ['m'] ||
    minutes < thresholds.m && ['mm', minutes] ||
    hours <= 1 && ['h'] ||
    hours < thresholds.h && ['hh', hours] ||
    days <= 1 && ['d'] ||
    days < thresholds.d && ['dd', days] ||
    months <= 1 && ['M'] ||
    months < thresholds.M && ['MM', months] ||
    years <= 1 && ['y'] || ['yy', years];

`, {
    compilerOptions: {
        module: "es6"
    }
});
const end = new Date().getTime();
console.log(result);
console.log("Took", (end - start));

I played around with it for a bit, and discovered that removing years <= 1 && ['y'] || ['yy', years];  (the last line) makes it compile pretty much instantly.
It's easy to reproduce: copy the snippet, create a js file (or ts) doesn't matter, and execute it.
Thanks a lot!

var a =
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4];

took 4.5 minutes to compile.
Seems both
var a =
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    .
    .
    .;

and
var a =
    x && [1, 2, ...] ||
    x && [1, 2, ...] ||
    x && [1, 2, ...] ||
    x && [1, 2, ...];

individually causes exponential compile time. Combining them obviously causes exponential^2 compile times.
I get the same result on 2.4.

Fixed in #18174.
Until the fix ships, a simple workaround is to add a type annotation to the variable being initialized, e.g.
var a: number[] =
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4] ||
    x && [1, 2, 3, 4];

👍


[HOLD for payment 2024-06-13] [$250] Send invoice - Workspaces in sender list are not arranged in alphabetical order

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Precondition:

User has several workspaces with custom workspace name
The workspaces are renamed randomly (eg, first workspace is renamed to R and second workspace is renamed to A, instead of first workspace is renamed to A and the second workspace is renamed to R)

Go to staging.new.expensify.com
Go to FAB > Send invoice.
Enter amount and select participant.
In confirmation page, click on the workspace.
Applause's Workspace -> C
Applause's Workspace 1 -> A
Applause's Workspace 2 -> B

Expected Result:
The workspaces will be arranged in alphabetical order
Actual Result:
The workspaces will be arranged in alphabetical order
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/9c272caf-0deb-4d74-bccc-902dfd2e0125
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cb4574300d46ea26
Upwork Job ID:<PHONE_NUMBER>797258752
Last Price Increase: 2024-05-07
Automatic offers:

akinwale | Reviewer | 0
ShridharGoel | Contributor | 0

Issue OwnerCurrent Issue Owner: @greg-schroeder

@AndrewGable  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

#vip-billpay related. Definitely not a blocker, not even sure if this is a bug, cc @danielrvidal

Solid clean-up, marking this as low as I don't think it's material to actually using it.

Confirmed the order should be alphabetical btw!

@akinwale - Let me know what you think

After reviewing the proposals, I believe we can move forward with @ShridharGoel's proposal, since it takes into account that the selected workspace should always be prioritised as the first workspace, before sorting the rest below in alphabetical order.
🎀👀🎀 C+ reviewed.

Bump @AndrewGable can you confirm the contributor assignment here?

PR is still in review

Processing

Payment summary:
Contributor: @ShridharGoel - $250 - paid via Upwork
C+: @akinwale - $250 - paid via Upwork

@akinwale can you take care of the checklist so we can close this out? Thanks!

[x]  [@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[x]  [@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x]  [@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not exactly a regression. This is more of a feature which wasn't specifically implemented.

[x]  [@akinwale] Determine if we should create a regression test for this bug.
[x]  [@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Launch the Expensify app.
Click on the global create FAB and select Send Invoice.
Specify an amount and select a participant.
Click on the workspace on the confirmation page.
Verify that the currently selected workspace is at the top of the list.
Verify that the other workspaces below the selected workspace are arranged in alphabetical order.

Do we agree 👍 or 👎?

@akinwale can you take care of the checklist so we can close this out? Thanks!

@greg-schroeder Done!

Thanks! filing regression test and closing


⚠ Bofrost.de has degraded performance

In ab1cb96, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1115 ms

Resolved: Bofrost.de performance has improved in 005f399 after 6 minutes.


Make rpi_rf.py threadsafe

Description:
The rpi_rf suffered from a race condition where, when two switches were triggered simultaneously (e.g. by the emulated_hue component through an Alexa command) would interfere with each other. This implementation uses a worker thread and a tx code submission queue to remove the race.
Checklist:
If the code communicates with devices, web services, or third-party tools:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
[x] New dependencies are only imported inside functions that use them ([example][ex-import]).
[ ] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[ ] Tests have been added to verify that the new code works.

Hi @ulido,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

maybe it is cleaner to use a https://docs.python.org/3/library/threading.html#rlock-objects

I considered that, but it would not preserve the order of arriving messages. I'm not sure if anything in home assistant relies on that, but people's scripts may, so I decided to go for a queue. But I'm happy to implement the whole thing as an RLock if you think the queue isn't necessary.


Multiple InMemory buses created causes hanging

I have some unit tests that are each creating their own In-Memory Mass Transit bus using:
Bus.Factory.CreateUsingInMemory(

When run individually, the tests are fine.  When run at the same time, they'll hang.  I'm still digging more into where they're hanging, but my question is: are multiple in-memory mass transit buses event supported?

It should work, they're mostly shared nothing but I do believe by default the share the same root message topology configuration.

Figure anything out here?


chrome os (probably) updated, crouton 14.04 gnome, now virtualbox won't start

I've been using crouton (for the last few months with Ubuntu 14.04 Gnome) on an Acer C720 for about a year, includng Virtualbox. Somewhere in the last few weeks, Virtualbox no longer starts, instead advising me to run /etc/init.d/vboxdrv setup (I had installed virtualbox a year ago along with my first Crouton install - Ubuntu 12.04 - and it has worked well until this.) This script does not run (ends with an error condition.) I imagine google forced an update of chrome OS (I really wish I could control that behavior; updates via a metered tethering account is an expensive process!)
As my C720+Crouton+Ubuntu is a daily-use ("daily driver") laptop, I have little time for tinkering and experimentation, so I'm looking for a time-efficient way to recover virtualbox to operational. I recall when I first installed Virtualbox (a year ago) that I was able to find .deb file(s) that contained pre-built kernel headers and such needed to allow Virtualbox to properly operate, instead of going through the whole rebuild-the-kernel cycle.
It seems that going through kernel rebuild would be unnecessary if someone archived the needed kernel header files (as I found a year ago), as it seems generating the files once and making them available would be straightforward.
Any pointer/advice (short of rebuilding kernel and all that?)
Very tks!

@wb0gaz - You might want to run this by @divx118 since he most likely created the headers and rc.local file you're speaking of. You can copy-n-paste this issue here - https://github.com/divx118/crouton-packages/issues/new

Following a link provided by @divx118 easily fixed the problem - thanks for the pointer!


Update README.md

Ran into an issue where I couldn't get the example compe/nvim-autopairs  conflict fix to work. Turned out I just forgot to remove my old binding.
This  was a stupid issue I had but I thought it'd be nice to mention it in the readme that the user can't just copy paste the example into their config and expect it to work

done


/static configuration broken when storage installed in different location

Summary:
When executing django-admin collectstatic command I get error: OSError: [Errno 2] No such file or directory: '/opt/graphite/webapp/content'
It should have looked at /opt/data/graphite/webapp/content instead
I added a debug print line in graphite.settings to indicated that the script is not picking the location of the content folder from the storage directory but rather from the default directory.
(The documentation is not clear as to what parameters should be applied when we decide to put the storage files and DB in a non default location)
Thanks for helping to resolve this issue
root@graphite-001:/opt/data/graphite# django-admin collectstatic --pythonpath=/opt/graphite/webapp --noinput --settings=graphite.settings

>>>>>>>>>>>>>>
STATICFILES_DIRS is in: ('/opt/graphite/webapp/content',)
>>>>>>>>>>>>>>

Traceback (most recent call last):
  File "/usr/bin/django-admin", line 5, in <module>
    management.execute_from_command_line()
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 399, in execute_from_command_line
    utility.execute()
  File "/usr/lib/python2.7/dist-packages/django/core/management/__init__.py", line 392, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 242, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 285, in execute
    output = self.handle(*args, **options)
  File "/usr/lib/python2.7/dist-packages/django/core/management/base.py", line 415, in handle
    return self.handle_noargs(**options)
  File "/usr/lib/python2.7/dist-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 167, in handle_noargs
    collected = self.collect()
  File "/usr/lib/python2.7/dist-packages/django/contrib/staticfiles/management/commands/collectstatic.py", line 102, in collect
    for path, storage in finder.list(self.ignore_patterns):
  File "/usr/lib/python2.7/dist-packages/django/contrib/staticfiles/finders.py", line 106, in list
    for path in utils.get_files(storage, ignore_patterns):
  File "/usr/lib/python2.7/dist-packages/django/contrib/staticfiles/utils.py", line 25, in get_files
    directories, files = storage.listdir(location)
  File "/usr/lib/python2.7/dist-packages/django/core/files/storage.py", line 249, in listdir
    for entry in os.listdir(path):
OSError: [Errno 2] No such file or directory: '/opt/graphite/webapp/content'

IIRC /opt/graphite prefix unfortunately hardcoded and you can't easily change that. But maybe I'm wrong.

I was able to get through this by changing STATICFILES_DIRS in settings.py
#STATICFILES_DIRS = (
join(WEBAPP_DIR, 'content'),
#)
STATICFILES_DIRS = (
join("/opt/data/graphite/webapp", 'content'),
)
The problem comes apparently from hard coding the value of WEBAPP_DIR in:
Filesystem layout
WEB_DIR = dirname( abspath(file) )
WEBAPP_DIR = dirname(WEB_DIR)
GRAPHITE_ROOT = dirname(WEBAPP_DIR)
An easy workable solution could be to be able to set WEBAPP_DIR in local_settings.py
settings.py should change to pickup that setting.

An easy workable solution could be to be able to set WEBAPP_DIR in local_settings.py

That's already the case, at least in master. Which version are you using?

Yes, I'm using master.
local_settings.py doesn't have any reference to WEBAPP_DIR
and even if so, it would be clobbered by settings.by
https://github.com/graphite-project/graphite-web/blob/master/webapp/graphite/local_settings.py.example

settigngs.py defines WEBAPP_DIR then imports local_settings so it really should be taken into account when overridden in local_settings.

Ok, then I suggest adding a commented line defining WEBAPP_DIR right under #STATIC_ROOT
in local_settings.py.example to address that and close this issue.
Thanks for your support.


Australian $.  I am assuming the register supports it; any idea when square register sdk will do ?  tx.

aus$ - I am assuming the register app now supports it; any idea when square register sdk support it ?  and I am correct in saying that USD, CAD and YEN are all sdk supported currencies ?  thanks.

Judging by this method it seems only USD CAD and JPY are supported:

+ (nonnull NSSet *)_setOfSupportedISO4217CurrencyCodes;
{
    static NSSet *setOfSupportedISO4217CurrencyCodes = nil;
    static dispatch_once_t onceToken;
    dispatch_once(&onceToken, ^{
        setOfSupportedISO4217CurrencyCodes = [NSSet setWithObjects:@"USD", @"CAD", @"JPY", nil];
    });
    return setOfSupportedISO4217CurrencyCodes;
}

What's next? When it will be added?

I'm pleased to announce that AUD is now available in SquareRegisterSDK-iOS 2.0.  Just update your installation to the latest version and you'll see that the AUD currency code is now in the set of supported currency codes.  Thanks for your patience!


Update branding to 3.1.1

Update branding & add trigger for internal release/3 branches
@JunTaoLuo @mmitche PTAL

This will probably fail until we get https://github.com/aspnet/AspNetCore/pull/17311 in & merge it to 3.1

Template failures:

Project new angular --auth Individual failed to publish.\r\nProcess exited with code 1\nStdErr: \nStdOut: Microsoft (R) Build Engine version 16.4.0-preview-19475-01+497296502 for .NET Core\r\nCopyright (C) Microsoft Corporation. All rights reserved.\r\n\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\MSBuild.dll -maxcpucount -property:Configuration=Release -restore -target:Publish -verbosity:m /bl .\AspNet.angularindividual.oueksvxrynk.csproj\r\n Restore completed in 23.26 ms for F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj.\r\n You are using a preview version of .NET Core. See: https://aka.ms/dotnet-core-preview\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3106: Assembly strong name "F:\workspace.16_work\1\s\obj\template-restore\microsoft.aspnetcore.app.ref\3.0.0\ref\netcoreapp3.1\Microsoft.AspNetCore.Antiforgery.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(). [F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj]\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3106: Assembly strong name "F:\workspace.16_work\1\s\obj\template-restore\microsoft.aspnetcore.app.ref\3.0.0\ref\netcoreapp3.1\Microsoft.AspNetCore.Authentication.Abstractions.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(). [F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj]\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3106: Assembly strong name "F:\workspace.16_work\1\s\obj\template-restore\microsoft.aspnetcore.app.ref\3.0.0\ref\netcoreapp3.1\Microsoft.AspNetCore.Authentication.Cookies.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(). [F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj]\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-preview1-014400\Microsoft.Common.CurrentVersion.targets(2106,5): warning MSB3106: Assembly strong name "F:\workspace.16_work\1\s\obj\template-restore\microsoft.aspnetcore.app.ref\3.0.0\ref\netcoreapp3.1\Microsoft.AspNetCore.Authentication.Core.dll" is either a path which could not be found or it is a full assembly name which is badly formed. If it is a full assembly name it may contain characters that need to be escaped with backslash(). Those characters are Equals(=), Comma(,), Quote("), Apostrophe('), Backslash(). [F:\workspace.16_work\1\s\src\ProjectTemplates\test\bin\Release\netcoreapp3.1\TestTemplates\AspNet.angularindividual.oueksvxrynk\AspNet.angularindividual.oueksvxrynk.csproj]\r\nF:\workspace.16_work\1\s.dotnet\sdk\3.1.100-previe

Others are PlatformManifestListsAllFiles and AssembliesAreReferenceAssemblies, which I think we fixed in 3.0. Looking

Oh, we need to update the baseline.

This will fail at least until dotnet-install.sh gets fixed


[Gluten-core] Support scan-only execution

Support scan-only execution. When enabled, only scan and the filter after scan will be offloaded to native.

This config is just for our local test and user special requirement. Can you keep it in your repo, not merge to gluten? Because it will make gluten logic complicate.

This config is just for our local test and user special requirement. Can you keep it in your repo, not merge to gluten? Because it will make gluten logic complicate.

Let's add this quick solution for now, It can help to debug the parquet reader issue quickly. If we don't need it in future, we can revert the PR.

This config is just for our local test and user special requirement. Can you keep it in your repo, not merge to gluten? Because it will make gluten logic complicate.

+1.

Merging this PR as a quick solution.


Suggestion for legacy phenotypes/alleles

So, I  am pretty sure that all of the alleles  with no name or description are in Artemis.
What if we

[ ] 1. Do the same as we have done for  legacy GO data and move into a flat file (gets rid of another chunk of data to maintain in Artemis. Since most updates to these data involve deletion, maintaining in a flat-file is much easier.

[ ] 2. Check that the alleles from Artemis with no name or description are all from sessions that have not been through Canto yet (if any have been through Canto , possibly the legacy annotation was overlooked, I will update the session or delete as necessary

[ ] 3. Once 2 is done, and I am happy that the legacy annotation WITHOUT ALLELE NAMES is from sessions that have not been curated,  put these annotations in a separate file, linked to this ticket:

https://github.com/pombase/curation/issues/3146
(it should actually be almost the same content as the files in alrredy there), and remove them from the "legacy PHAF file".
This data does not need to be loaded into PomBase - the were made by me and Jacky to compare to the cell cycle viability and morphology phenotypes. They were all subsequently recovered by the  deletion project. I think this is better practice than having phenotypes floating around that are not attached to alleles.

I slightly forgot what we decided to do here because I went straight into chatting with James after our Skype on Friday.  But I think the plan was to add more detail to the unnamed, unrecorded log file as a first step.  I've changed the query, hopefully in time for the load.  It's the log file that ends with .chado_checks.unnamed_unrecorded_alleles
I've added the gene name and a column with the PMID of the annotation from the contig file and the session ID of that PMID, if there is one.
Here's what it looks like from the Chado from the 24th: unnamed_unrecored_alleles.tsv.txt

Right, so some of the papers are already through  to Canto.
I will add to canto  and  delete from contigs phenotypes all of the ones from those sessions, as appropriate. Then you can continue.

I removed all of the ones that are in the sessions. That was  a  useful exercise, it confirmed that most if not all will be recovered  via other publications.
YOu can move to the next step|(s)

Hi Kim,
I forgot to put "next" on this. I am doing that now. Can you prioritise the next steps (when feasible) because I need to check that all of the phenotypes/alleles look OK in Intermie after the next load.

So is the summary that I need to move the phenotype annotation from the contig files into a PHAF file?

Some of the phenotype annotations in the contigs have no date but it's a required field in PHAF files.  Is there a date we can put in the PHAF file for those cases?

I've made these changes:

Added the phenotype annotations from the contig files to a new PHAF file in SVN:
pombe-embl/supporting_files/legacy_phenotype_annotations_from_contigs.phaf.tsv
Removed the annotations from the contig files.
Changed the load script to load the annotations from the PHAF file (https://github.com/pombase/pombase-legacy/commit/74fc809292e6090461208de0cbf72b40edc6126b)

I'm doing a local test load now.  When it's done I'll compare the Chado database from before and after to make sure we're getting the same annotation.

Is there a date we can put in the PHAF file for those cases?

For testing the loading I put in a dummy date (1999-09-09).

Dummy date is fine. Once this is done, we will not load any phenotypes which do not have an allele description.

I moved the annotations using unnamed alleles into a separate file before the load started:
pombe-embl/supporting_files/unnamed_legacy_phenotype_annotations_from_contigs.phaf.tsv
What's the next step?

I moved the annotations using unnamed alleles into a separate file before the load started

Everything worked so the website now has the phenotype annotations from the legacy phenotypes file and there are now no phenotype annotations in the contig files.

We. can close this and new tickets for anything else but that should be all.


compile error with lcos::communicator

Expected Behavior
stencil tutorial
should build correctly.
Actual Behavior
In file included from /usr/local/include/hpx/include/lcos.hpp:19,
                 from /home/msca8h/Projects/auto_task_size/stencil/main.cpp:24:
/usr/local/include/hpx/lcos/channel.hpp:222:30: note:   couldn't deduce template parameter ‘Action’
             return hpx::apply(action_type(), this->get_id(), std::move(val),
                    ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                 generation);
                 ~~~~~~~~~~~

I get a compile error
Steps to Reproduce the Problem
 void set(neighbor n, T&& t, std::size_t step)
    {
        // Send our data to the neighbor n using fire and forget semantics
        // Synchronization happens when receiving values.
        send[n].set(hpx::launch::apply, std::move(t), step);
    }

It seems the way the tutorial uses hpx::lcos::communicator is out of date.
Simply building the tutorials on the current hpx version breaks.
Etc..
I couldn't find documentation on how to fix lcos::communicator to work on the current version.
Simply changing
 void set(neighbor n, T&& t, std::size_t step)
    {
        // Send our data to the neighbor n using fire and forget semantics
        // Synchronization happens when receiving values.
        send[n].set(hpx::launch::apply, std::move(t), step);
    }

to
 void set(neighbor n, T&& t, std::size_t step)
    {
        // Send our data to the neighbor n using fire and forget semantics
        // Synchronization happens when receiving values.
        send[n].set(std::move(t), step);
    }

made it possible to build but I suppose the behavior is different.
Specifications
{version}: V1.2.0-trunk (AGAS: V3.0), Git: 30d0202dd4
{boost}: V1.67.0
{build-type}: release
{date}: Jun 13 2018 14:48:57
{platform}: linux
{compiler}: GNU C++ version 8.1.1 20180531
{stdlib}: GNU libstdc++ version 20180531

Thanks for the report. #3379 should fix the issue.

Great. I'll close the issue


pull request for e2e test at 12/16/2016 13:15:17

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Beautify screenshots in README.md

Make screenshots in README.md look nicer and more uniform. Some of them are quite wide, which makes it hard to read on mobile devices.

Hey,
I can make the screenshots look better for mobile devices.
This will be a great first issue for me.


Ensure accurate java main artifact name retrieval for multi-JARs and refine fallback approach

Improving Accuracy of Package Name Retrieval in Java Archives
This section outlines enhancements to accurately retrieve the main package artifact names and their corresponding SHA1 values. It focuses on resolving issues where incorrect package names were being retrieved, especially for JAR files with multiple internal JARs. The improvements include:

Correctly retrieving the main package name when the main POM file is present.
Addressing issues with incorrect package names for specific JAR files, such as those containing multiple JARs.
Ensuring accurate results by checking prefixes and suffixes, with a fallback mechanism if no exact matches are found.

Thanks for the contribution @dor-hayun!
I think for us to accept this we need to check on some of the downstream implications here and see if it changes any of our fixtures in vulnerability testing for the better.
Also, let me see about adding a test or two that can show the kind of behavior this prevents. Do you have an current cases you're running into that would serve as a good example?

HI @spiffcs ,
Please try to run syft on the following public image:
public.ecr.aws/docker/library/gradle@sha256:70da12adf27e83bcc125af9d2bc6f9432590e89c96609625aa688135b27e75fb
and then you can check what happens for 'jansi' package, it is the main artifact, you can see that there are 10 pom properties found inside the jar and my fix is to ensure Correctly retrieving the main package name when the main POM file is present.

Hey, @dor-hayun. It looks like I made a change that conflicts with this one a bit. Would you want to rebase this PR? Or I could push an update, if you don't mind.

@kzantow i'm rebasing it


Bluetooth: Host: Fix not clearing IDs upon bt_disable()

Expectation: After calling bt_disable() it is possible to use the Bluetooth APIs as if bt_enable() was never called.
This was not the case for bt_id_create(), it was not possible to set the default identity. This prevented an application developer to restart the stack as a different identity.
The API documentation is updated accordingly.

The new CIS disable test is failing because bt_disable() doesn't clear the stored keys. As a result, the central uses the previously stored keys when re-establishing security. As the device uses a new identity, this fails. We need to figure out if we want keys to be cleared as well.

The new CIS disable test is failing because bt_disable() doesn't clear the stored keys. As a result, the central uses the previously stored keys when re-establishing security. As the device uses a new identity, this fails. We need to figure out if we want keys to be cleared as well.

If we are clearing stuff like IRKs etc. (which I believe we are/should when doing an HCI reset), then we should clear all the other keys as well, unless they are store in BT_SETTINGS.

Sorry for the last pushes. I forgot to include the change in the prj.conf which I had locally


Native SMS.send().then()..catch() promise throws error

Ionic version:  (check one with "x")
[ ] 1.x
[ x] 2.x
I'm submitting a ...  (check one with "x")
[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Native SMS.send() falls into error after sms is sent.
SMS.send(a,b)
      .then(() => {
        // should be active
      })
      .catch((error: any) => {
          // THIS IS ACTIVE, error echoes "OK"
          })
        }
      );

Expected behavior:
code above
Steps to reproduce:
code above

This issue was moved to driftyco/ionic-native#858


fixed .env issues with database

Description
Fixed an issue where windows machine wasn't able to connect to postgres with broken up url. The url had to be a single string with login/port/dbName AIO.
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Test A - Tested on my Machine, and on heroku
[x] Test B - Tested on Christy's Machine

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

My machine still works with it today, so Its a check from me.


[Bug]: theres lag spike mid song

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
whydogcantspeed (discord)
Version Info
Latest available release
What operating system are you seeing the problem on?
Windows
Bug Behavior
mid playing it just freeze for like 2 ticks but the song is still playing and its like playing ez SV maps with little speed veriations
Expected Behavior
its shouldnt freeze i guess
Reproduction Steps
idk its only on my end or ppl has this issue as well
Anything else?
gl

a nonreproducible issue is a non issue. thanks to the lack of detail you presented, i cant give directly helpful advice. try to get better hardware. try closing discord and chrome while playing the game. try lowering the framelimit of the game. try not recording videos/streaming while playing the game. try plugging in your laptop.
dont make garbage github issues


[Alias, Interactive] update extensions for CLI namespace

-CLi uses event namespace as some extensions were already using it.
-this PR allows the alias and interactive extensions to once again refer to the right import

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/williexu/azure-cli-extensions.git@alias_inter#subdirectory=src/$EXT&egg=$EXT"


fix: Run button hiding issue

Description
Run button in queries and js page was getting squeezed when file name is longer.
PR fixes following issue(s)
Fixes https://github.com/appsmithorg/appsmith/issues/31298
Media
Before
https://github.com/appsmithorg/appsmith/assets/87797149/5948c7ad-1c29-489a-8857-004876261c6c
After
https://github.com/appsmithorg/appsmith/assets/87797149/758b2cec-1e05-4ebf-903c-9fa16f3b6489
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] JUnit
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test<EMAIL_ADDRESS>@tag.IDE"


Add support for better monitoring

We should provide better monitoring for reliability and security

I see some monitoring already, but leaving this on #178 for launch blocking

I see some monitoring already, but leaving this on #178 for launch blocking

Since #178 is closed, closing this too :-)


Fix reference-style links

Fixes #860

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ide/dotfuscator/capabilities.md
:white_check_mark:Succeeded

docs/ide/dotfuscator/index.md
:white_check_mark:Succeeded

docs/ide/dotfuscator/install.md
:white_check_mark:Succeeded

docs/ide/dotfuscator/upgrades.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[BUG]: Model Edit testing issues

Describe the bug
Multiple issues while trying to follow the Model Edit testing protocol found here, on staging on June 13 at 2pm: https://github.com/DARPA-ASKEM/terarium/blob/main/testing/manual/model-edit.md
ISSUE 1
The MODEL-EDIT test partially fails at step 2.5. After uploading the Configured SIR.json, dragging it onto a new workflow and attaching it to an Edit model operator, when you click to open it, you get this.
However, if you close the operator and reopen it, it opens properly.

ISSUE 2
The MODEL-EDIT test partially fails at step 3a-2. I linked port R from the t1 template to port B by accident. That's when I discovered there are is no way to disconnect ports. We probably need an unlink button like on the workflow nodes.
So I clicked the reset button and got an alert that the model was reset, but my canvas looks the same. Closing the operator and reopening it restores it.

ISSUE 3
The MODEL-EDIT test partially fails at step 4-2. Clicking 'Save' produces this error. Closing the operator and reopening it, then clicking 'Save' again is successful.

ISSUE 4
The MODEL-EDIT test gets a partial design fail at step 4-2. In the output selector, there is some helper text that says "Select outputs to display in operator". This is vestigial from when we were playing with the idea that operators could have multiple outputs. It should probably just say "Select output to display"

Another partial design fail from this...

ISSUE 5
And another partial fail when trying to save the model. First you get an error, then if you reload the site, it works.

@bigglesandginger  looks like most connection fails after 5 seconds, let's try improve it.


tidying up a bit

drop the vagrant user and add project_repo as an attribute

:+1: so far, keep adding if you like

For the record I did try changing the repo path to inside build user's home directory to avoid symlinking the gitconfig, didn't work.


AstBuilder methods which take an Option accept None without type annotation

Came across this in #4884:
https://github.com/oxc-project/oxc/blob/c0d4397a75956f61c32701bd128ad62ca2f7fb48/crates/oxc_transformer/src/es2020/nullish_coalescing_operator.rs#L78
And also:
https://github.com/oxc-project/oxc/blob/1e6d0fe7dddb9fa40a1d7b27df83de96b48fbc6e/crates/oxc_minifier/src/keep_var.rs#L60-L61
Is there any way to avoid need for type annotations when the param is None?
I tried changing binding_pattern to:
pub fn binding_pattern<T1>(
    self,
    kind: BindingPatternKind<'a>,
    type_annotation: Option<T1>,
    optional: bool,
) -> BindingPattern<'a>
where
    T1: IntoIn<'a, Box<'a, TSTypeAnnotation<'a>>>,
{
    BindingPattern {
        kind,
        type_annotation: type_annotation.map(|it| it.into_in(self.allocator)),
        optional
    }
}

But that doesn't help.
Is there anything we can do to avoid the need for type annotation on None?

@rzvxa Any bright ideas? I'm a bit stumped.

https://gtk-rs.org/gtk3-rs/stable/latest/docs/gtk/struct.Application.html#associatedconstant.NONE

A simple test:
diff --git a/crates/oxc_minifier/src/keep_var.rs b/crates/oxc_minifier/src/keep_var.rs
index 40297b7c8..454d58bc8 100644
--- a/crates/oxc_minifier/src/keep_var.rs
+++ b/crates/oxc_minifier/src/keep_var.rs
@@ -1,3 +1,4 @@
+use oxc_allocator::Box;
 use oxc_ast::{ast::*, syntax_directed_operations::BoundNames, AstBuilder, Visit};
 use oxc_span::{Atom, Span, SPAN};

@@ -43,7 +44,7 @@ impl<'a> Visit<'a> for KeepVar<'a> {
         }
     }
 }
-
+pub const NONE: Option<Box<TSTypeAnnotation<'_>>> = None;
 impl<'a> KeepVar<'a> {
     pub fn new(ast: AstBuilder<'a>) -> Self {
         Self { ast, vars: std::vec![] }
@@ -57,8 +58,8 @@ impl<'a> KeepVar<'a> {
         let kind = VariableDeclarationKind::Var;
         let decls = self.ast.vec_from_iter(self.vars.into_iter().map(|(name, span)| {
             let binding_kind = self.ast.binding_pattern_kind_binding_identifier(span, name);
-            let id =
-                self.ast.binding_pattern::<Option<TSTypeAnnotation>>(binding_kind, None, false);
+
+            let id = self.ast.binding_pattern(binding_kind, NONE, false);
             self.ast.variable_declarator(span, kind, id, None, false)
         }));

@rzvxa Any bright ideas? I'm a bit stumped. It's not so important, but would be nice if there's a simple way to solve this.

Since default function generic arguments are phased out there is no standard way to avoid it.
I have some idea of how we can avoid this via a custom trait that can provide a concrete None based on the type T. However, I haven't spent much time on it.
I'll mull this over and come back with some comments.

Since default function generic arguments are phased out there is no standard way to avoid it.

Drat!
Maybe a generalized version of what @IWANABETHATGUY suggested?
struct AnyNone;

impl<'a, T> FromIn<'a, AnyNone> for Option<Box<'a, T>> {
    fn from_in(_: AnyNone, _: &'a Allocator) -> Self {
        None
    }
}

const NONE: AnyNone = AnyNone;

I'm actually not sure how good an idea this is, though. It's weird to have to use NONE instead of None. Maybe the cure is worse than the disease!
@rzvxa Does your idea remove the need for this "magic" NONE? Or much the same?

Close as stale. There are no better alternatives right now.

On reflection, I think providing NONE is better than having to use annotations. Re-opening and moving to backlog.


[T4A6][W10-B1] Le Ba Hieu Giang

Ready for review

Some comments added. Please close the PR after reading comments.


swift implementation of fibonacci sequence

What a great code :smile: !
Just a little tip, its good to always put a description on your PRs to make more understandable.
Thank you for contributing! :rocket:


Implement "timelines" in page server

This replaces the page server's "datadir" concept. The Page Server now
always works with a "Zenith Repository". When you initialize a new
repository with "zenith init", it runs initdb and loads an initial
basebackup of the freshly-created cluster into the repository, on "main"
branch. Repository can hold multiple "timelines", which can be given
human-friendly names, making them "branches". One page server simultaneously
serves all timelines stored in the repository, and you can have multiple
Postgres compute nodes connected to the page server, as long they all
operate on a different timeline.
There is a new command "zenith branch", which can be used to fork off
new branches from existing branches.
The repository uses the directory layout desribed as Repository format
v1 in https://github.com/zenithdb/rfcs/pull/5. It it highly inefficient:

we never create new snapshots. So in practice, it's really just a base
backup of the initial empty cluster, and everything else is reconstructed
by redoing all WAL

when you create a new timeline, the base snapshot and all WAL is copied
from the new timeline to the new one. There is no smarts about
referencing the old snapshots/wal from the ancestor timeline.

 When you initialize
a new compute node with "zenith pg create", it connects to the page
server, and requests a base backup of the Postgres data directory on
that timeline. (the base backup excludes user tables, so it's not
as bad as it sounds).

Have page server's WAL receiver write the WAL into timeline dir. This
allows running a Page Server and Compute Nodes without a WAL safekeeper,
until we get around to integrate that properly into the system. (Even
after we integrate WAL safekeeper, this is perhaps how this will operate
when you want to run the system on your laptop.)

restore_datadir.rs was renamed to restore_local_repo.rs, and heavily
modified to use the new format. It now also restores all WAL.

Page server no longer scans and restores everything into memory at startup.
Instead, when the first request is made for a timeline, the timeline is
slurped into memory at that point.

The responsibility for telling page server to "callmemaybe" was moved
into Postgres libpqpagestore code. Also, WAL producer connstring cannot
be specified in the pageserver's command line anymore.

Having multiple "system identifiers" in the same page server is no
longer supported. I repurposed much of that code to support multiple
timelines, instead.

Implemented very basic, incomplete, support for PostgreSQL's Extended
Query Protocol in page_service.rs. Turns out that rust-postgres'
copy_out() function always uses the extended query protocol to send
out the command, and I'm using that to stream the base backup from the
page server.

TODO: I haven't fixed the WAL safekeeper for this scheme, so all the
integration tests involving safekeepers are failing. My plan is to modify
the safekeeper to know about Zenith timelines, too, and modify it to work
with the same Zenith repository format. It only needs to care about the
'.zenith/timelines//wal' directories.

So, this is what I've been hacking this week. It grew into a much bigger patch than I intended; sorry for the massive PR.
The main point is to:

Introduce the concept of a "Zenith repository". The repository is the persistent storage format used by the page server.
Introduce the concept of "zenith timelines". One repository holds one postgres cluster, but it can contain multiple timeline of the same cluster. One page server serves them all.

I started this originally as a CLI project, but there is actually only few changes to the CLI. Most of the changes are in the page server.
My plan next is to make the changes in the walkeeper so that the walkeeper tests would pass again. But since I've been hacking on this or a while, I wanted to share and get any feedback now.

Thanks for unifying things, I quickly read diff -- looks good.
some random notes:

why do we need timeline_id in branch string "mybranch@2/15D3DD8". Isn't branch == timeline and mybranch@15D3DD8 is enough?

with this format we are bringing pg-style data directories to the pageserver. We should be cautious not to use any non-relation files directly, as if we will depend on that -- that would cut out paths to sharding.

system_id was a handy concept =) I'm now working on db creation on the cloud side and was planning to use pageserver for storing databases. I can use timelines for different users/databases (technically they all inherit initdb-created database), but that feels weird. We can create different "repos" in the pageserver on the fly -- but does this degree of freedom brings anything to us? We could just create different branches as a databases with different system_id. Or am I missing some technical aspect of why is that a bad idea?

On 18 April 2021 11:13:17 EEST, Stas Kelvich @.***> wrote:

Thanks for unifying things, I quickly read diff -- looks good.
some random notes:

why do we need timeline_id in branch string @.***/15D3DD8". Isn't branch == timeline and @.***D3DD8 is enough?

Ah, that "2"" is not a timeline id. It's just part of the LSN, the high bits, in the standard Postgres notation.

with this format we are bringing pg-style data directories to the pageserver. We should be cautious not to use any non-relation files directly, as if we will depend on that -- that would cut out paths to sharding.

Agreed. We should perhaps store the non-relation files in a .tar.gz file in the snapshots dir, to make it more clear that the page server is not supposed to look at them, except when it regurgitates them back to a client that asks for a base backup.

system_id was a handy concept =) I'm now working on db creation on the cloud side and was planning to use pageserver for storing databases. I can use timelines for different users/databases (technically they all inherit initdb-created database), but that feels weird. We can create different "repos" in the pageserver on the fly -- but does this degree of freedom brings anything to us? We could just create different branches as a databases with different system_id. Or am I missing some technical aspect of why is that a bad idea?

Each systemid should have a separate namespace of timelineids. So if there is timeline "1234abcd" in systemid 1, it should be possible to also have timelineid "1234abcd" in systemid 2. Perhaps treat the systemid as a prefix of the timelineid. But for multi-tenancy, that's not quite enough, it must be possible for multiple tenants to have a cluster with the same systemid.
Maybe we need to support having two clusters with the same systemid even within one tenant. Not sure. That situation  could arise out of luck, the systemid isn't all that random, and not very long. Or more likely, if you make a copy of the data dir at some point to create a new cluster.
At the end of the day, we can't depend on any user- or client-generated ID to distinguish clusters across tenants. We need to have a server-generated "tenant id" as part of the key.

Heikki

Rebased, and made the required change to the WAL safekeeper and safekeeper_proxy, to make them also work with the timelines. All the tests pass on my laptop now.
Please take a look. Barring objections, I'll push this later today.
Some notes on what to do next:

This removed the support for restoring from S3. It's not urgent, but we probably want to add that back at some point, but working with the new repository format
This repository format V1 is very dumb, it's just a postgres base backup (called snapshot here) + WAL archive. And there isn't even any code to take new snapshots. And when you create a new timeline, all the history is copied to the new timeline, rather than just referencing the history. So there is a lot of work to be done there. We had a slightly smarter format in the old zenith_pull, zenith_push, zenith_slicedice' commands in the vendor/postgres/src/bin/` directory. Those are now obsolete, and probably should be removed, but I'll leave that for another commit.

Pushed. I intended to squash the last commit here, "Fixes, per Eric's and Konstantin's comments" before pushing, but forgot. Oops.
This left behind some loose ends that I will work on next:

Refactor xlog_utils.rs and the snippets that this PR copy-pasted from xlog_utils.rs into a separate module.
Re-implement multi-tenancy in page server and WAL safekeepers


⚠ Bofrost.at has degraded performance

In 8261514, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1031 ms

Resolved: Bofrost.at performance has improved in de26822.


vulnerabilities

There are 4999 vulnerabilities  (4996 low, 3 high)

There are 4999 vulnerabilities (4996 low, 3 high)

Addressed on #20 . I'm closing this ! You can continue the discussion on #20


[iptraceable] Symfony2 Default Authentication Handler triggered before IP is set

iptraceable should start service with higher priority. In my case 10 was enough. In my example i was logging ips of user on successful login inside AuthenticationHandler.
services:
    extension.listener:
        class: AppBundle\Listener\DoctrineExtensionListener
        calls:
            - [ setContainer, [ "@service_container" ] ]
        tags:
            # as soon as possible (before authentication handler)
            - { name: kernel.event_listener, event: kernel.request, method: onEarlyKernelRequest, priority: 10 }

    public function onEarlyKernelRequest(GetResponseEvent $event)
    {
        $request = $event->getRequest();
        if ($request) {
            $ip = $request->getClientIp();

            if (null !== $ip) {
                $iptraceable = $this->container->get('gedmo.listener.iptraceable');
                $iptraceable->setIpValue($ip);
            }
        }
    }

thanks, will need to update documentation


update dependencies

SvelteKit now ships with vite 4.0.0 which breaks compatibility with this plugin ("vite": "^3").

+1. Would be great to update this peer dependency to vite 4

+1. Same.  Could not resolve dependency peer vite@"^3" from<EMAIL_ADDRESS>

Same here


Broken links in doc

https://github.com/ajv-validator/ajv/blob/418cd0f4308c07c627071b4d03544e7cc57f235c/docs/guide/combining-schemas.md?plain=1#L44
Links to Options and addSchema are broken

currently working on this. will have a PR up shortly

https://github.com/ajv-validator/ajv/pull/2006


Query parameter fuzzing

Address #6
Added a new option to be passed.
Updated README for new example.

Looks good to me, I can't test it right now but when I get the chance I'll merge this in

sure. thanks.

Looks good to me, thanks 😄


Set up watchable to communicate between components

This pulls in https://github.com/telepresenceio/watchable/ to use to communicate between components.  I added a watching.md doc describing the design a bit and how to use it; I'd usually put a lot more info in the PR description, but just go read it in the markdown file.  I moved the Kubernetes provider to publish its results via watchable.
As a bonus, https://github.com/datawire/envoy-gateway/commit/4c1f5211bcea92045ce07c2aecd55c493076a451 is mostly moving the IR translator types over as well... but I didn't include it in this PR because something about it is causing controller-gen to crash, and I didn't want to break make generate in this PR.  What's sort of weird about it is that it still writes all of the files correctly, but then crashes.
controller-gen crashing
$ make generate
make --warn-undefined-variables -f tools/make/common.mk generate
make[1]: Entering directory '/home/lukeshu/src/github.com/envoyproxy/gateway'
tools/bin/controller-gen object paths="./..."
panic: interface conversion: ast.Expr is *ast.CompositeLit, not *ast.Ident

goroutine 1463 [running]:
sigs.k8s.io/controller-tools/pkg/loader.(*referenceCollector).Visit(0xc008e31a00, {0xd5da58?, 0xc00761d9c8})
        /home/lukeshu/go/pkg/mod/sigs.k8s.io/controller-tools@v0.8.0/pkg/loader/refs.go:136 +0xff
…

Since this PR is failing CI and @LukeShu is on leave, I created https://github.com/envoyproxy/gateway/pull/193 to fix the CI failure. Closing this PR in favor of https://github.com/envoyproxy/gateway/pull/193


resizing terminal does not work properly when ssh from terminal

If I resize a terminal window after ssh login into another machine, the 'full-screen' programs like vi or top won't display properly. My setup is Windows + git shell. I haven't tested on other platforms so I don't know whether this problem is platform specific.

It happens to me too. I'm using Arch linux.

Please retest again with platformio-atom-ide-terminal 2.9.0 is using node-pty-prebuilt instead unmaintained and outdated pty.js


Enable publication of model code to Maven Central.

By publishing the model as a library, we make it easier to build other tools that can interact with our custom resource definition.

https://repo.maven.apache.org/maven2/com/indeed/rabbitmq-operator-model/0.0.1/


makeTreeSEFromPseq bugfix

Hi,
this fixes the bug related to the issue https://github.com/microbiome/mia/issues/200.
-Tuomas

This should work now after syncing with master. But this should be tested before merging.


Use esbuild-loader automatic loader resolution

What I changed
esbuild-loader can now detect loaders automatically. The current setting leads to errors like ERROR: The character ">" is not valid inside a JSX element or ERROR: Unexpected end of file before a closing "T" tag

v2.0.1


A few more constant classes

Signed-off-by: liach<EMAIL_ADDRESS>

Hmm, why didn't the branch updater not run...


fix iso8601 format check and add test cases

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.ingmarvdg seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Use Conda to do the crop mask

Because rsgislib is only available on Conda, install it from there.
Rasterio is installed with --no-binary, because we have specific versions of stuff installed from Conda
Pyproj is installed with Conda so we get a good version too.

@alexgleith infinite gratitude!


include procedurally-generated creatures

It doesn't include any information on procedurally-generated creatures.

Procedurally generated creatures are saved in a binary format, sometimes compressed (the unit-n.dat files in the save dir). There are not published utilities that I've found which parse these files. The data about names and description can be exported with dfhack (generated-creature-renamer has a 'list-generated' command) but that is only the name and if you specify 'detailed' it includes the description.

This should be on track to get included, although it requires a legends export-plus xml file. I recently added support for it to dfraw_json_parser which is the underlying program that enables overseer's manual to work.
The creatures exported in that are not as rich and detailed as the raw files but they do include enough information (it doesn't include any graphical information).


[feature request] Switch currencies on widget

Hey!
I love this widget but it would make my life 999% easier if I could switch around crypto and fiat (inserting USD amount to be converted instead of crypto amount).

For now, it will be as it is. Perhaps in a new project.


Not work backspace on Android

Hello,
Did not work backspace(delete) key on Android keyboard for JFXTextField. Compile JFoenix 1.8.0 retrolambda for Android 4.2.2

Hello,
did you try to use the java TextField control instead of JFXTextField?
if the issue still persist with java TextField, then this issue is related to JavaFXPorts not JFoenix (as JFoenix only updates the ui)
Regards,

Thank you for your answer. I try TextField, you were right, problem is related with JavaFXPorts.


Add Github Action for Publishing to Comfy Registry

This PR adds a Github Action (publish-node-action) that will run whenever the pyproject.toml file changes. The pyproject.toml defines the custom node version you want to publish (added in another PR).
Action Required:

[ ] Create an api key on the Registry for publishing from Github. Instructions.
[ ] Add it to your Github Repository Secrets as REGISTRY_ACCESS_TOKEN.
More info on the registry. Please message me on Discord if you have any questions!

Saw that you merged the PR which is amazing!!!!! Just a few last steps to
get you onboarded 🚀
Steps:

Go to the registry. [https://www.comfyregistry.org/]
Login and create a publisher id.
Update the toml file with your publisher ID, and publish your node
either through the CLI or with GH Actions!

There's also like a 1minute video we made too teehee -
https://youtu.be/WhOZZOgBggU
Let me know if there is anything else I can help with!!
On Fri, May 24, 2024 at 4:38 PM Faruk @.***> wrote:

Merged #1 https://github.com/fexploit/ComfyUI-AutoTrimBG/pull/1 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/fexploit/ComfyUI-AutoTrimBG/pull/1#event-12929463282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG3AD2P3CKNKJT5BWOSVGPLZD6QL3AVCNFSM6AAAAABIEW72UCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHEZDSNBWGMZDQMQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Ray cluster: TLS is blocking workers to join cluster

Steps to reproduce the problem
Deploy ray cluster with tls enabled
What is the current behavior?
Workers are handing in non-ready status on wait for GCS to be ready;
In init container wait-gcs-ready
This check is always failing

  until ray health-check --address cluster-user-994c3d3c-head-svc.quantum-serverless.svc.cluster.local:6379 > /dev/null 2>&1; do echo wait for GCS to be ready; sleep 5; done

Therefore workers cannot connect to head node a.k.a join cluster.
What is the expected behavior?
Workers should be able to join cluster with TLS enabled

@akihikokuroda I'm fighting with this today and have no progress.
When TLS is turned off everything works fine.

@IceKhan13 I'll take a look.

This is happening on IKS, so there may be something unique to that environment

I also reproduced it in rancher desktop

Well, then, nevermind :laughing:

It may be related to the IP address associated to the certificate.  I'm looking..


link in confirmation email not working

Hi,
First I would like to appreciate the effort you put into this pluggable app which provides easy integration. While registering a new user with api, email is sent but on clicking the link its not confirming the user. Link looks like as given below
http://localhost:8000/rest-auth/registration/account-confirm-email/tms6khpwpolzwpao5oruac0amiizcc6vdnevq5lb4iruukkqeveeojx2znsclvug/
and the above link redirects me to
http://localhost:8000/rest-auth/registration/account-confirm-email/tms6khpwpolzwpao5oruac0amiizcc6vdnevq5lb4iruukkqeveeojx2znsclvug/
and my homepage is loaded.
I tried changing /rest-auth/registration to accounts/confirm-email and got allauth confirm email page but confirm button click redirects me to the second link mentioned, However emails are not confirmed. I verified it by trying logging in using rest auth and got an email not verified response :)
I use default settings as per the documentation for installed apps and urls.py. How can I confirm the email using rest auth?

I have managed to resolve this issue by mapping allauth confirm view to rest auth confirm email view
from allauth.account.views import confirm_email as allauthemailconfirmation
....
url(r'^rest-auth/registration/account-confirm-email/(?P<key>\w+)/$', allauthemailconfirmation, name="account_confirm_email"),

It would be helpful if you mention any issues if any using this code like if this is not the right (standard) way. :)

This issue was explained in the FAQ section:
https://github.com/Tivix/django-rest-auth/blob/master/docs/faq.rst


not able to get the storage with ReadStorage method

Can someone please help me to understand how to make a call to the extrinsics which requires arguments to passed in
i observed we can get a data from the extrinsics which do not requires arguments but with extrinsics with arguments it is giving me null string
as in this example i am trying to call the erasRewardPoints extrinsic from staking module , i am passing the args array
still it will give me the null string .
thanks in advance

@andropixels Hi, args need to encode, you can try this https://github.com/itering/scale.go/blob/master/types/types_test.go#L300

thanks !


feat: add api caching

closes #383
I added a new helper directory since I didn't really see a good place to fit the CacheHelper class otherwise.
If you prefer it being in a different directory or perhaps converted to just export functions instead of a class, please open the discussions required or alternatively directly edit it yourself.
I tested this both via npm run serve and via a local build which I installed. It does seem to work as intended. To test locally  in regards to maxAge, clone it and set the maxAge to 60 or similar to do manual tests.
Initially the patreon.patrons key is twice, it seems this is due to the fact that both TheFooter.vue and Patrons.vue call PatreonService.getPatrons
This is my first pull request to this repo so I gladly welcome any feedback - be it regarding the code or the description here.

@Campiotti Thanks for the PR!
Apologies, this isn't mentioned anywhere but a lot of the backend code has changed for a 2.0.0 branch.
The best place for this to be merged into would be there.
A few changes might cause this to conflict, but if you rebase from the chore/2.0.0 it should give a good indication of what doesn't work.
That will be merged soon to support Wildlander 1.1.
In general, a few comments:

I try to avoid helpers or util because it starts to become a bit of a dumping ground of all sorts. I would consider this caching mechanism as another service that the Patreon and news service can call.
Currently, there are 2 separate calls for the data I think. As part of this change, it would be nice to reduce that to just one.
It looks like you're creating a new store instance each time which I think is unnecessary, would could keep a reference to the store instead.
If the cache is writing to the user's filesystem, it is truly faster for those that have HDDs? Could we perhaps use something like local storage instead?

The code looks clean though :)

@Campiotti  A lot changed in the backend in 2.0.0. One of the biggest changes was the renderer process no longer has access to any node APIs except when communicating via ipc handlers (our controllers).
If we want to persist something, I would suggest doing it in a service in the main process and having a controller expose an ipc handler.
I would also recommend if we want to use electron store that we use a different store with a different name, so it doesn't end up in the user preferences. Perhaps we can just call it cache.json or something

Same as #552 , rebased onto 2.0.0 & target branch changed.
Manually tested.

@MattLish is this (as well as #552 #556 ) still expected to be merged into 2.0.0?
If so, should I start resolving conflicts or what's the plan here?

Hey @Campiotti , I haven't forgotten about these! :)
I've just had a lot to do before Wildlander 1.1 comes out. 2.0.0 of the launcher will get released soon and we can merge these just after that. Each merge to master produces a release anyway, so it's not like it'll have to wait for the next big release.
I'll endeavour to get these merged next week :)
As for the conflicts, this is just because I had to rebase the chore/2.0.0 branch a few times to get the commits in a good releasable state.

I can sort this next week when I come to merge them though :)


Panic on macOS with empty config.ru file

I'm encountering a panic that crashes macOS when I run falcon serve from a directory that's empty except for an empty config.ru file.
Reproduction steps:
mkdir crash
cd crash
touch config.ru
falcon serve
#!> starts to log error and crashes operating system

I've tried latest stable Ruby 3.2 and 3.3 and seem to be able to consistently reproduce a similar panic with both.
panic(cpu 12 caller 0xfffffe003945000c): [SPTM] VIOLATION_ILLEGAL_SPRR_INDEX: sptm_map_page(sptm.c:411) - page_fte(0xfffffde003f1fe40), page_fte->type(0xe), new_sprr_index(0x7), new_pte(0x60010fca2e8e43), vaddr(0x11def0000)

Can you tell me your system hardware and OS version?

Maybe related: https://github.com/puma/puma/issues/3551

Can you tell me your system hardware and OS version?

Model Name: MacBook Pro
Chip: Apple M4 Max 16 (12 performance and 4 efficiency)
Memory: 128 GB
System Firmware Version: 11881.41.5
OS Loader Version: 11881.41.5
macOS: 15.1.1 (24B2091)

Thanks for the report and confirming the fix!


Fix link clearing issues

Fixes #990

Coverage increased (+0.02%) to 69.957% when pulling 8243eef67ca6bc81a77d76b95cc4fd78d3ba8e6d on Tyriar:990_fix_link_issues into c4da8325ace6e4bde77822377bf994d389a7c75a on sourcelair:v3.


Add as_blender_input_socket metadata

In order to hide the affected node's input, preventing connections.

It also addresses https://github.com/appleseedhq/appleseed/issues/1971


its not available on chrome extension store

on the link it shows an error :
404. That’s an error.
The requested URL was not found on this server. That’s all we know.

For the time being, you can manually install the extension.

Return to the main page of this repo
Click "Code" then "Download ZIP" (or clone the repo if you're feeling fancy)
Unpack the ZIP
Go to chrome://extensions/
Turn on Developer Mode in the top right, then click "Load unpacked"
Navigate to the root folder of the extension and Open

@harrylongia, the Chrome Web Store took down the extension over the holidays because I hadn't filled out the "Privacy practices" details within their Developer Dashboard, which is something that was added since I last published an update to this extension. Once I returned home from my holiday travels, I filled out those details and I've been waiting for the Chrome Web Store to restore the extension. I only now noticed this issue, which prompted me to go back to check the Developer Dashboard, upon doing so I noticed something else was blocking the publishing of the extension. So, hopefully with resolution of that addition item the extension will be restored soon.

Extension has finally been republished to the Chrome Web Store.


Feature/plugins loading

Hi Ben
first release candidate :)
I think it's missing:

add console methods, but there's a new task for this

component manager: if I understood correctly, extract as a plugin the methods related to load new methods to a specific scope (methods_for) so a developer can decide if he wants to use the previous way to create methods or not.

Thanks,
Juan

So I'd like to remove Adhearsion::Component::ComponentManager. Anything in it that is used by Adhearsion::Plugin should be moved there. The rest (as far as I can tell, code which loads components from the components/ directory in an app and provides YAML configuration) should be moved into a Plugin itself (packaged as a gem). That way, the old component structure can be removed from Adhearsion core and deprecated.

with the previous commit Adhearsion::Plugin does not depend on ComponentManager anymore.
Dialplan::ExecutionEnvironment and Drb load the dialplan and rpc methods using Adhearsion::Plugin with a specific method call (Plugin.add_dialplan_methods and Plugin.add_rpc_methods)

This looks good. The next step will be to write an ahn-components plugin which loads old-style components from the components/ directory.

ok, just deleted the Adhearsion::Components and split into files per class/module. I'll upload it now to the new repository ahn-components


How to appear in the results of the default?

hi,guys.
The workflow is very good,How to appear in the results of the default? like this：

I don't use alfred anymore, but the last time I checked you couldn't do default results. You could use  zazu if you want more specific behaviors like that.


Params refactor

Continuation of https://github.com/commaai/openpilot/pull/2005. Credit goes to @ahowe444

Cool. Thanks for fixing things up.

I'm entertaining the thought of dropping the transaction support since we don't really rely on that behavior. That should lead to a lot less code (see https://github.com/commaai/openpilot/pull/2300). I feel a little bad about all the work you put in this, but if we're not actually going to use the code there is no point in maintaining it.

That's fine. Trying to recreate the original python in C++ got complicated rather quickly. This is simpler.


Read from box from multiple isolates

Is your feature request related to a problem? Please describe.
I have audio playing on a separate isolate via audio_service, distinct from the UI. Even when the app is closed, audio can still play.
I need to keep track of where the user is holding in the audio, for
1, continuing from that place next time he starts up the app (even if he closes the background play back).
2. UI things - when user navigates to a file, he should see where he's holding even before play back starts, and even if another class is playing.
Saving the current position has to be done in the background audio isolate, because the UI thread could be closed at any time.
What comes out is that the background thread needs read and write access to the box, and the UI thread needs read access.
Describe the solution you'd like
I would like for there to be a way to open a box read only, and such an open would be allowed from multiple threads.
Describe alternatives you've considered
Currently, I'm planning on having 2 boxes, one for each thread 🙈
Version

Platform: Android
Flutter version: 1.12
Hive version: 1.3.0

I'm working with this idea in my project,
as I know, we cannot open box in multiple isolates , see #122   or you will see this kind of error

HiveError: This should not happen. (while opening a box)

So, I make a static function that create an instance for box and pass it to isolate function, In your case that should be backgroundTaskEntrypoint . and it works!

I am using workmanager package to do repeating stuff (e.g. syncing data with server) - so I have no access to main isolate.
No idea how to fix this, especially because I write to hive in the background isolate.

I am using workmanager package to do repeating stuff (e.g. syncing data with server) - so I have no access to main isolate.
No idea how to fix this, especially because I write to hive in the background isolate.

My solution is:

In WorkManager task (=background isolate) reading from Hive is OK, but I have to initialize alwalyst here:

await Hive.initFlutter();
  objectBox = await Hive.openBox('hive_name');

Next I send message to MAIN thread during Isolates:

sendPort = IsolateNameServer.lookupPortByName("XXX_CHANNEL_NAME");
...
sendPort.send({'key': key, 'json': hiveObj.toJson()});

I send only key from Hive and JSON (created from Hive instance). In MAIN I listen on the channel, find Hive object from DB and update from JSON and call save().
Conslusion:
Read in BACKGROUND, write only in MAIN thread, comunication during Isolates. I don't know if this is the best solution, but it works yet.
Sorry for my English.
Z.

@dundadevelop hey, Can You explain me more about the Hive and Workmanger Integration, I am still having Doubts

My final solution is:

Reading from the Hive is possible in the background process (BP). Data for init BP is always read from Hive.
BP can measure independently of the application run. I always save the BP result in separate JSON files. I only use Isolates as one-way BP communication to the main process.
The main process either gets information from BP via a Isolates or retrieves it from temp JSON files when started. In both cases, it modifies (deletes) the temp JSON files.

Z.

Oh that creative-ly Different 💡 , You are Saving the Data inside the JSON 💾 ,  hmmm.
But, How the Data of the BP looks like, 😄 🤔


Make use of php://memory stream for Unit testing

Q
A

Is bugfix?
❌

New feature?
❌

Breaks BC?
❌

Fixed issues
#42

https://github.com/yiisoft/proxy/issues/42#issuecomment-1177092160