Template deployment issue

Output from azd version
azd version 0.1.0-beta.2 (commit 13ec2b11aa755b11640fa16b8664cb8741d5d300)
Output from az version
"azure-cli": "2.38.0"
Describe the bug
Attempting to deploy https://github.com/Azure-Samples/todo-csharp-cosmos-sql but get the following output/error:
Creating Azure resources (17 of ~17 completed)
Deploying service api
Error: deploying service: deploying service api package: deploying service api: failed running az deployment source config-zip: exit code: 3, stdout: , stderr: WARNING: Getting scm site credentials for zip deployment
ERROR: (ResourceNotFound) The Resource 'Microsoft.Web/sites/jcTest1api' under resource group 'jcTest1-rg' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
Code: ResourceNotFound
Message: The Resource 'Microsoft.Web/sites/jcTest1api' under resource group 'jcTest1-rg' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
: exit status 3
To Reproduce
azd up --template todo-csharp-cosmos-sql
Expected behavior
When azd up is complete it will output the following URLs:
Azure Portal link to view resources
ToDo Web application frontend
ToDo API application
Environment
VS Code 16.9.2
Additional context
It appears I meet the install requirements stated in the application. Using Azure subscription where I am owner so permissions shouldn't be an issue.
Azure Developer CLI : azd version 0.1.0-beta.2 (commit 13ec2b11aa755b11640fa16b8664cb8741d5d300)
Azure CLI (2.38.0+):  2.38.0
.NET SDK 6.0: 6.0.302
Node.js with npm: node v18.6.0<EMAIL_ADDRESS>Git (2.36.1+): git version 2.37.1.windows.1

Thank you very much for reporting this issue. This may be because you used mixed cases in your environment. A bug reported in #115. We will be releasing a fix for this. The workaround for the time being is to use all lowercase for environment name.

That does look to be the issue. I retried the deployment with the same settings except lower case for the environment name and it deployed correctly (technically there was a number character in the name as well). Thank you for the clarification on this issue.

Glad it works. The number should be ok. Just no uppercase.

Closing this since issue resolved. Please reopen if any other issue.


Triple-Gauss PSF format

I've added a formula for the triple-Gauss PSF:
http://gamma-astro-data-formats.readthedocs.org/en/latest/irfs/psf/psf_3gauss/index.html
as well as some background info on radial PSFs:
http://gamma-astro-data-formats.readthedocs.org/en/latest/irfs/psf/index.html#point-spread-function
I think some discussion / checks are needed:

[ ] Is the formula correct? I took it from the HAP code that fits the PSF and added the 1/pi factor to go from dP/dr^2 (which is what HAP fits) to dP/d\Omega (which is what Fermi and OGIP use as PSF value).
[ ] Is there a more sane / stable parametrisation for multi-Gauss (look what PSFEx do) that we want to adopt?
[ ] Can the presentation / explanations be improved?
[ ] @mimayer - Does the PA exporter use the same parametrisation?
[ ] @JouvinLea - Do you use multi-Gauss in HAP-FR exporters? Same parametrisation?
[ ] I'd like to check the Gammapy code
[ ] @mimayer - Is gammalib.GCTAPsf2D consistent with this definition?

@JouvinLea commented via email:

why do you have S and not a normalization factor 1/(1pi*(s12 + A2 * S22 + A3S32))? I mean the PSF has to be normalize no?

I agree, having a normalised PSF is nicer.
The only reason to maybe not do it is backwards-compatibility with existing exporters / data / tools.
Thoughts?

@jknodlseder - Could you please comment on the following questions concerning the triple-Gauss PSF format?

Do you think changing to a parametrisation that is automatically normalised to integrate to 1 (like the King PSF) is a good idea? This would mean dropping SCALE as a parameter / column and putting the right normalisation factor in front of the format.
Would this change still be acceptable in Gammalib? Maybe via a "version=2" header keyword?

I think for the coming months / years we need some scheme to do backwards-incompatible changes to DL3 formats anyways to avoid being stuck with early mistakes, and we could use this as a test case on how to do this?
But of course this only makes sense if it's agreed that the change is good, i.e. the new PSF parameterisation is an improvement.

The SCALE parameter is in fact not used by GammaLib as the GCTAPsf2D class assures internally the normalisation. So in principle the SCALE parameter can be dropped. For the moment, the order of the parameter blocks in the FITS file are hardwired in GCTAPsf2D which is anyways a bad idea. Enhancing GCTAPsf2D so that the required parameter blocks are dynamically extracted from the column names would handle the two formats transparently. So we would not need to use the version header keyword for that (and to increment the number).
You may create a change request asking for an automatic detection of the parameter blocks based on column names. Note that this implies that the column names will then be fixed.
We also need to change GCTAResponseIrf::load_psf which for the moment checks the presence of columns and infers from that whether to use a Gaussian or a King PSF. We just need to remove the table.contains("SCALE") condition.
Le 2 févr. 2016 à 12:37, Christoph Deil a écrit :

@jknodlseder - Could you please comment on the following questions concerning the triple-Gauss PSF format?
Do you think changing to a parametrisation that is automatically normalised to integrate to 1 (like the King PSF) is a good idea? This would mean dropping SCALE as a parameter / column and putting the right normalisation factor in front of the format.
Would this change still be acceptable in Gammalib? Maybe via a "version=2" header keyword?
I think for the coming months / years we need some scheme to do backwards-incompatible changes to DL3 formats anyways to avoid being stuck with early mistakes, and we could use this as a test case on how to do this?
But of course this only makes sense if it's agreed that the change is good, i.e. the new PSF parameterisation is an improvement.
—
Reply to this email directly or view it on GitHub.

@jknodlseder - Thank you for the quick reply!
Change request for Gammalib is here:
https://cta-redmine.irap.omp.eu/issues/1656

We also need to change GCTAResponseIrf::load_psf which for the moment checks the presence of columns and infers from that whether to use a Gaussian or a King PSF. We just need to remove the table.contains("SCALE") condition.

I would much prefer to have declarative scheme. E.g. HDUCLASS and maybe a version as e.g. here:
http://gamma-astro-data-formats.readthedocs.org/en/latest/irfs/background/index.html#bkg-3d-format
Having to maintain code that pokes and guesses formats in Gammalib / Gammapy for the coming years is painful and not really needed if we tell data producers via these specs what to put, right?
(of course, short-term we have to keep doing this to keep the tools working with existing files...)

I fully agree that a declarative scheme should be implemented.
As we had so far no conventions, we simply put the emphasize on a system that "works", but now that the conventions start to emerge, we should of course fully support them.
Le 3 févr. 2016 à 11:02, Christoph Deil a écrit :

@jknodlseder - Thank you for the quick reply!
Change request for Gammalib is here:
https://cta-redmine.irap.omp.eu/issues/1656
We also need to change GCTAResponseIrf::load_psf which for the moment checks the presence of columns and infers from that whether to use a Gaussian or a King PSF. We just need to remove the table.contains("SCALE") condition.
I would much prefer to have declarative scheme. E.g. HDUCLASS and maybe a version as e.g. here:
http://gamma-astro-data-formats.readthedocs.org/en/latest/irfs/background/index.html#bkg-3d-format
Having to maintain code that pokes and guesses formats in Gammalib / Gammapy for the coming years is painful and not really needed if we tell data producers via these specs what to put, right?
(of course, short-term we have to keep doing this to keep the tools working with existing files...)
—
Reply to this email directly or view it on GitHub.


Remove build hack for WithLifecycle after Spine Proto Compiler supports optional generation of interfaces

The code of server/build.gradle has the task for removing generated WithLifecycle.java. The task is needed because there is handcrafted WithLifecycle class, which is used in code generation, so that EntityRecord implements it.
The hack can be removed after Spine Proto Compiler supports optional generation of interfaces via extended syntax of is option. Once it's available the following needs to be done:

[ ]  New option should be used in entity.proto.
Presumably, it would look like:
option (is).java_type = "WithLifecycle" ;

This syntax assumes that generate attribute equals false.

[ ]  The task deleteGeneratedWithLifecycleJava and dependence on it is removed from server/build.gradle.

@armiol, I could not find an issue for the improvement of new is option syntax. I presume it's no in the Spine org. at all. If so, please create and link to this request.

See #911.


Building the Apollo project in VSCode

I have added the "apollo/dev_build.sh" and "apollo/.vscode/tasks.json" files to build the Apollo project in VSCode.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

please click the "CLA: not signed yet" button. Then I can merge your change into Apollo.


Add more icons to the UI

As this commit added an icon props to sidebars, and #939 already revised some of the exemplary icons put there, we could maybe think of providing good describing icons to other sidebars as well:

use a general Overview icon everywhere - or, a different one for Organizations, Products and Repositories?
an icon for Secrets
an icon for Infrastructure Services
does the "Technical" section of the run details sidebar need icons as well? Logs, Reports, Job configs, Issues?

To me, using carefully selected icons in the UI is not just a matter of "eye candy" - icons often "teach" more visually thinking users in where to find what, and should lead to a better UX. The Issues and Pull requests icons in GitHub are some good examples.

Smells a bit like a design guideline...

Could a secret be represented with a key icon, for example this?

Could a secret be represented with a key icon, for example this?

I'd prefer something like https://lucide.dev/icons/book-lock.

Then we would need a good representative icon for infrastructure services, and I could add them (Overview, Serets, Infrastructure services) to the UI sidebar menus. Tried to search for a suitable one but nothing obvious popped up.

a good representative icon for infrastructure services

Maybe https://lucide.dev/icons/server-cog?


Update machine-learning-recommendation-api-documentation.md

This is up to date, just updating the date.

Hi @LuisCabrer, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (luisca). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


EOL normalization

See changes, ignoring newlines: https://github.com/NLog/yamtp/pull/21/files?w=1
after .gitattributes has been changed:
rm .git/index     # Remove the index to force git to
git reset         # re-scan the working directory
git status        # Show files that will be normalized
git add -u
git commit -m "EOL normalization"

Current coverage is 99.49% (diff: 95.23%)

Merging #21 into master will not change coverage

@@             master        #21   diff @@
==========================================
  Files             6          6
  Lines           197        197
  Methods          40         40
  Messages          0          0
  Branches         22         22
==========================================
  Hits            196        196
  Misses            1          1
  Partials          0          0

Powered by Codecov. Last update 0e062cb...1e20400

@304NotModified I think you may want to modify the .editorconfig file I added with extra options.
From the official doc:

end_of_line: set to lf, cr, or crlf to control how line breaks are represented.
charset: set to latin1, utf-8, utf-8-bom, utf-16be or utf-16le to control the character set.
trim_trailing_whitespace: set to true to remove any whitespace characters preceding newline characters and false to ensure it doesn't.
insert_final_newline: set to true to ensure file ends with a newline when saving and false to ensure it doesn't.
root: special property that should be specified at the top of the file outside of any sections. Set to true to stop .editorconfig files search on current file.

I only work in IDEs supporting this and I find it a great help to enforce consistent formatting when you work accross multiple projects with different style rules.


confusing limit filter

Scenario A
client.query.get( 'Article', [ 'title' ] ).with_where( where_clause ).do() gives some results
Scenario B
client.query.get( 'Article', [ 'title' ] ).with_where( where_clause ).with_limit( 1 ).do() gives no result
The only difference between the two scenarios is the limit filter. It seems the limit filter is applied on to the results before the where filter. So, it seems, in this case, if the 1st data does not match our where filter and only the 2nd data in database is the desired one, the limit filter leaves only the 1st data in the list passing to where filter.
Does limit filter limit only the end result?

Thanks for spotting this. That sounds like a bug, definitely not the desired behavior. Can you post a minimal reproducing example and specify the exact versions? Thanks!

after a few trials, the problem may relate to data deletion, but dont know if it's the only cause

create and delete data first

id = client.data_object.create( { 'author': 'Simon' }, 'Article', vector=np.random.rand( 1, 128 ) )
client.data_object.delete( id )

and re-create data

client.data_object.create( { 'author': 'Simon' }, 'Article', vector=np.random.rand( 1, 128 ) )

query without limit filter gives the desired data

results = client.query.get( 'Article', [ 'author' ] ).with_where( {
  'path': 'author',
  'operator': 'Equal',
  'valueText': 'Simon',
} ).do()

and query with limit filter gives none

results = client.query.get( 'Article', [ 'author' ] ).with_where( {
  'path': 'author',
  'operator': 'Equal',
  'valueText': 'Simon',
} ).with_limit( 1 ).do()

Thank you for the reproducing example, this will definitely help in investigating this! One more question: Which weaviate version are you running this with?

sorry for missing the information
the version is 1.8.0

Hi @ywchan2005,
thanks again for reporting this and the great reproducing example. We have been able to reproduce this and a fix is on the way which will be part of the next release. If you need a fix more urgent than that, please let me know and I can provide you with an intermediary Docker image that contains the fix - even before the next release.
We have also added new tests to prevent a regression on this issue.
In case you are interested in what was going on, let me try to explain:

Internally each object has a numerical (uint64) document id which we use in the inverted index. In your example the first object you created has doc id 0 and the second you created had doc id 1
Since you were using a filter, you were making use of the inverted index. If a delete had never occurred, the entry for the value Simon would have been [0, 1] for both doc ids.
There was a bug with regards to cleaning up the inverted index, so when we deleted object 0, we never cleaned up the entry for Simon, so the row still was as is.
With a high limit you wouldn't notice because Weaviate would just look at both ids and decide that 0 no longer exists, so it would only serve you with 1. However, when the limit was 1 weaviate would first cut off the results, so it only contains [0]. Then it would find out that this object no longer exists and return no results.
After the fix it would only ever get back [1] so even after truncating the list, the correct result is still on there :)


When run llama2, Caught signal 11 (Segmentation fault)

Hi, I had tried to test llama2 based on TensorRT-LLM.
my environments (based on "nvcr.io-nvidia-tritionserver-23.10-trtllm-python-py3"):

cuda 12.2
gpu A100 40G (1)
python 3.10.12
ubuntu 22.04.3
tensorrt 9.2.0.post12.dev5
tensorrt-llm 0.7.0
triton 2.1.0

I tried to use llama2 based on examples/llama/README
I had success build, when I run :
$ python build.py --model_dir meta-llama/llama-2-7b-hf\                 --dtype float16 \                 --remove_input_padding \                 --use_gpt_attention_plugin float16 \                 --enable_context_fmha \                 --use_gemm_plugin float16 \                 --output_dir ./tmp/llama/out/
when i tried to run engine after build :
$ python3 ../run.py --max_output_len=50 \                   --tokenizer_dir meta-llama/llama-2-7b-hf \                   --engine_dir=./tmp/llama/out/
I faced to this error message

[Instance-1891:140515:0:140515] Caught signal 11 (Segmentation fault: address not mapped to object at address 0x54000009)
==== backtrace (tid: 140515) ====
0 0x0000000000042520 __sigaction()  ???:0
1 0x000000000006ce20 PMPI_Comm_set_errhandler()  /build-result/src/hpcx-v2.16-gcc-inbox-ubuntu22.04-cuda12-gdrcopy2-nccl2.18-x86_64/ompi-db10576f403e833fdf7cd0d938e66b8393b20680/ompi/mpi/c/profile/pcomm_set_errhandler.c:81
2 0x000000000006ce20 opal_atomic_add_fetch_32()  /build-result/src/hpcx-v2.16-gcc-inbox-ubuntu22.04-cuda12-gdrcopy2-nccl2.18-x86_64/ompi-db10576f403e833fdf7cd0d938e66b8393b20680/ompi/mpi/c/profile/../../../../opal/include/opal/sys/atomic_impl.h:384
3 0x000000000006ce20 opal_thread_add_fetch_32()  /build-result/src/hpcx-v2.16-gcc-inbox-ubuntu22.04-cuda12-gdrcopy2-nccl2.18-x86_64/ompi-db10576f403e833fdf7cd0d938e66b8393b20680/ompi/mpi/c/profile/../../../../opal/threads/thread_usage.h:152
4 0x000000000006ce20 opal_obj_update()  /build-result/src/hpcx-v2.16-gcc-inbox-ubuntu22.04-cuda12-gdrcopy2-nccl2.18-x86_64/ompi-db10576f403e833fdf7cd0d938e66b8393b20680/ompi/mpi/c/profile/../../../../opal/class/opal_object.h:534
5 0x000000000006ce20 PMPI_Comm_set_errhandler()  /build-result/src/hpcx-v2.16-gcc-inbox-ubuntu22.04-cuda12-gdrcopy2-nccl2.18-x86_64/ompi-db10576f403e833fdf7cd0d938e66b8393b20680/ompi/mpi/c/profile/pcomm_set_errhandler.c:70
6 0x00000000000a728f __pyx_f_6mpi4py_3MPI_comm_set_eh()  /tmp/pip-install-8x8e5fta/mpi4py_ff745ee2b9414fd99054a30ef67df184/src/mpi4py.MPI.c:40330
7 0x00000000000a728f __pyx_f_6mpi4py_3MPI_initialize()  /tmp/pip-install-8x8e5fta/mpi4py_ff745ee2b9414fd99054a30ef67df184/src/mpi4py.MPI.c:8406
8 0x0000000000047e7c __pyx_f_6mpi4py_3MPI_initialize()  /tmp/pip-install-8x8e5fta/mpi4py_ff745ee2b9414fd99054a30ef67df184/src/mpi4py.MPI.c:8394
9 0x000000000023b2d3 PyModule_ExecDef()  ???:0
10 0x000000000023bda0 PyInit__thread()  ???:0
11 0x000000000015f854 PyObject_GenericGetAttr()  ???:0
12 0x000000000014b2c1 _PyEval_EvalFrameDefault()  ???:0
13 0x000000000016070c _PyFunction_Vectorcall()  ???:0
14 0x000000000014e8a2 _PyEval_EvalFrameDefault()  ???:0
15 0x000000000016070c _PyFunction_Vectorcall()  ???:0
16 0x0000000000148f52 _PyEval_EvalFrameDefault()  ???:0
17 0x000000000016070c _PyFunction_Vectorcall()  ???:0
18 0x0000000000148e0d _PyEval_EvalFrameDefault()  ???:0
19 0x000000000016070c _PyFunction_Vectorcall()  ???:0
20 0x0000000000148e0d _PyEval_EvalFrameDefault()  ???:0
21 0x000000000016070c _PyFunction_Vectorcall()  ???:0
22 0x000000000015fb24 PyObject_CallFunctionObjArgs()  ???:0
23 0x000000000023f4af _PyObject_CallMethodIdObjArgs()  ???:0
24 0x00000000001740ca PyImport_ImportModuleLevelObject()  ???:0
25 0x0000000000184458 PyImport_Import()  ???:0
26 0x000000000015fe0e PyObject_CallFunctionObjArgs()  ???:0
27 0x000000000016f12b PyObject_Call()  ???:0
28 0x000000000014b2c1 _PyEval_EvalFrameDefault()  ???:0
29 0x000000000016070c _PyFunction_Vectorcall()  ???:0
30 0x0000000000148e0d _PyEval_EvalFrameDefault()  ???:0
31 0x000000000016070c _PyFunction_Vectorcall()  ???:0
32 0x000000000015fb24 PyObject_CallFunctionObjArgs()  ???:0
33 0x000000000023f4af _PyObject_CallMethodIdObjArgs()  ???:0
34 0x0000000000174cda PyImport_ImportModuleLevelObject()  ???:0
35 0x0000000000151216 _PyEval_EvalFrameDefault()  ???:0
36 0x000000000016070c _PyFunction_Vectorcall()  ???:0
37 0x0000000000148e0d _PyEval_EvalFrameDefault()  ???:0
38 0x000000000016070c _PyFunction_Vectorcall()  ???:0
39 0x000000000014e8a2 _PyEval_EvalFrameDefault()  ???:0
40 0x000000000016070c _PyFunction_Vectorcall()  ???:0
41 0x0000000000148e0d _PyEval_EvalFrameDefault()  ???:0
42 0x0000000000239e56 PyEval_EvalCode()  ???:0
43 0x0000000000239cf6 PyEval_EvalCode()  ???:0
44 0x00000000002647d8 PyUnicode_Tailmatch()  ???:0
45 0x000000000025e0bb PyInit__collections()  ???:0
46 0x0000000000264525 PyUnicode_Tailmatch()  ???:0
47 0x0000000000263a08 _PyRun_SimpleFileObject()  ???:0
48 0x0000000000263653 _PyRun_AnyFileObject()  ???:0
49 0x000000000025641e Py_RunMain()  ???:0
50 0x000000000022ccad Py_BytesMain()  ???:0
51 0x0000000000029d90 __libc_init_first()  ???:0
52 0x0000000000029e40 __libc_start_main()  ???:0
53 0x000000000022cba5 _start()  ???:0
python3:140515 terminated with signal 11 at PC=7f887654de20 SP=7ffdd00247f0.  Backtrace:
/usr/local/mpi/lib/libmpi.so.40(PMPI_Comm_set_errhandler+0xb0)[0x7f887654de20]
/usr/local/lib/python3.10/dist-packages/mpi4py/MPI.cpython-310-x86_64-linux-gnu.so(+0xa728f)[0x7f8875d4728f]
/usr/local/lib/python3.10/dist-packages/mpi4py/MPI.cpython-310-x86_64-linux-gnu.so(+0x47e7c)[0x7f8875ce7e7c]
python3(PyModule_ExecDef+0x73)[0x55704666c2d3]
python3(+0x23bda0)[0x55704666cda0]
python3(+0x15f854)[0x557046590854]
python3(_PyEval_EvalFrameDefault+0x2b71)[0x55704657c2c1]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(_PyEval_EvalFrameDefault+0x6152)[0x55704657f8a2]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(_PyEval_EvalFrameDefault+0x802)[0x557046579f52]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(_PyEval_EvalFrameDefault+0x6bd)[0x557046579e0d]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(_PyEval_EvalFrameDefault+0x6bd)[0x557046579e0d]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(+0x15fb24)[0x557046590b24]
python3(_PyObject_CallMethodIdObjArgs+0xff)[0x5570466704af]
python3(PyImport_ImportModuleLevelObject+0x25a)[0x5570465a50ca]
python3(+0x184458)[0x5570465b5458]
python3(+0x15fe0e)[0x557046590e0e]
python3(PyObject_Call+0xbb)[0x5570465a012b]
python3(_PyEval_EvalFrameDefault+0x2b71)[0x55704657c2c1]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(_PyEval_EvalFrameDefault+0x6bd)[0x557046579e0d]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(+0x15fb24)[0x557046590b24]
python3(_PyObject_CallMethodIdObjArgs+0xff)[0x5570466704af]
python3(PyImport_ImportModuleLevelObject+0xe6a)[0x5570465a5cda]
python3(_PyEval_EvalFrameDefault+0x8ac6)[0x557046582216]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(_PyEval_EvalFrameDefault+0x6bd)[0x557046579e0d]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(_PyEval_EvalFrameDefault+0x6152)[0x55704657f8a2]
python3(_PyFunction_Vectorcall+0x7c)[0x55704659170c]
python3(_PyEval_EvalFrameDefault+0x6bd)[0x557046579e0d]
python3(+0x239e56)[0x55704666ae56]
python3(PyEval_EvalCode+0x86)[0x55704666acf6]
python3(+0x2647d8)[0x5570466957d8]
python3(+0x25e0bb)[0x55704668f0bb]
python3(+0x264525)[0x557046695525]
python3(_PyRun_SimpleFileObject+0x1a8)[0x557046694a08]
python3(_PyRun_AnyFileObject+0x43)[0x557046694653]
python3(Py_RunMain+0x2be)[0x55704668741e]
python3(Py_BytesMain+0x2d)[0x55704665dcad]
/lib/x86_64-linux-gnu/libc.so.6(+0x29d90)[0x7f8aa41e1d90]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80)[0x7f8aa41e1e40]
python3(_start+0x25)[0x55704665dba5]

When I tested GPT-NeoX Examples (using Polyglot Models), I got same issue.
I can use build.py that, but I can't use run.py that and got same error message.
I guess it is because of mpi.
Can any body help me solve this problem?

How did you build TensorRT-LLM?

Thanks for reply.
I had installed TensorRT-LLM using :
$ pip3 install tensorrt_llm --extra-index-url https://pypi.nvidia.com/ --extra-index-url https://download.pytorch.org/whl/cu122
because, when I build using $ python3 ./scripts/build_wheel.py --trt_root /usr/local/tensorrt,
I got this message

Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com/
Requirement already satisfied: accelerate==0.20.3 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 1)) (0.20.3)
Requirement already satisfied: build in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 2)) (1.0.3)
Requirement already satisfied: colored in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 3)) (2.2.4)
Requirement already satisfied: cuda-python==12.2.0 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 4)) (12.2.0)
Requirement already satisfied: diffusers==0.15.0 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 5)) (0.15.0)
Requirement already satisfied: lark in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 6)) (1.1.8)
Requirement already satisfied: mpi4py in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 7)) (3.1.5)
Requirement already satisfied: numpy in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 8)) (1.26.1)
Requirement already satisfied: onnx>=1.12.0 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 9)) (1.15.0)
Requirement already satisfied: polygraphy in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 10)) (0.49.0)
Requirement already satisfied: sentencepiece>=0.1.99 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 11)) (0.1.99)
Requirement already satisfied: tensorrt>=8.6.0 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 12)) (9.1.0.post12.dev4)
Requirement already satisfied: torch in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 13)) (2.1.0)
Requirement already satisfied: transformers==4.33.1 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 14)) (4.33.1)
Requirement already satisfied: wheel in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 15)) (0.41.2)
Requirement already satisfied: optimum in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 16)) (1.16.1)
Requirement already satisfied: evaluate in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 17)) (0.4.1)
Requirement already satisfied: datasets in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 2)) (2.16.0)
Requirement already satisfied: einops in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 3)) (0.7.0)
Requirement already satisfied: graphviz in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 5)) (0.20.1)
Requirement already satisfied: mypy in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 6)) (1.8.0)
Requirement already satisfied: parameterized in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 7)) (0.9.0)
Requirement already satisfied: pre-commit in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 8)) (3.6.0)
Requirement already satisfied: pybind11-stubgen in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 9)) (2.4.2)
Requirement already satisfied: pynvml>=11.5.0 in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 10)) (11.5.0)
Requirement already satisfied: pytest-cov in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 11)) (4.1.0)
Requirement already satisfied: pytest-forked in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 12)) (1.6.0)
Requirement already satisfied: pytest-xdist in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 13)) (3.5.0)
Requirement already satisfied: rouge_score in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 14)) (0.1.2)
Requirement already satisfied: typing-extensions==4.8.0 in /usr/local/lib/python3.10/dist-packages (from -r requirements-dev.txt (line 16)) (4.8.0)
Requirement already satisfied: packaging>=20.0 in /usr/local/lib/python3.10/dist-packages (from accelerate==0.20.3->-r requirements.txt (line 1)) (23.2)
Requirement already satisfied: psutil in /usr/local/lib/python3.10/dist-packages (from accelerate==0.20.3->-r requirements.txt (line 1)) (5.9.7)
Requirement already satisfied: pyyaml in /usr/local/lib/python3.10/dist-packages (from accelerate==0.20.3->-r requirements.txt (line 1)) (6.0.1)
Requirement already satisfied: cython in /usr/local/lib/python3.10/dist-packages (from cuda-python==12.2.0->-r requirements.txt (line 4)) (3.0.7)
Requirement already satisfied: Pillow in /usr/local/lib/python3.10/dist-packages (from diffusers==0.15.0->-r requirements.txt (line 5)) (10.1.0)
Requirement already satisfied: filelock in /usr/local/lib/python3.10/dist-packages (from diffusers==0.15.0->-r requirements.txt (line 5)) (3.12.4)
Requirement already satisfied: huggingface-hub>=0.13.2 in /usr/local/lib/python3.10/dist-packages (from diffusers==0.15.0->-r requirements.txt (line 5)) (0.20.1)
Requirement already satisfied: importlib-metadata in /usr/lib/python3/dist-packages (from diffusers==0.15.0->-r requirements.txt (line 5)) (4.6.4)
Requirement already satisfied: regex!=2019.12.17 in /usr/local/lib/python3.10/dist-packages (from diffusers==0.15.0->-r requirements.txt (line 5)) (2023.10.3)
Requirement already satisfied: requests in /usr/local/lib/python3.10/dist-packages (from diffusers==0.15.0->-r requirements.txt (line 5)) (2.31.0)
Requirement already satisfied: tokenizers!=0.11.3,<0.14,>=0.11.1 in /usr/local/lib/python3.10/dist-packages (from transformers==4.33.1->-r requirements.txt (line 14)) (0.13.3)
Requirement already satisfied: safetensors>=0.3.1 in /usr/local/lib/python3.10/dist-packages (from transformers==4.33.1->-r requirements.txt (line 14)) (0.4.0)
Requirement already satisfied: tqdm>=4.27 in /usr/local/lib/python3.10/dist-packages (from transformers==4.33.1->-r requirements.txt (line 14)) (4.66.1)
Requirement already satisfied: pyproject_hooks in /usr/local/lib/python3.10/dist-packages (from build->-r requirements.txt (line 2)) (1.0.0)
Requirement already satisfied: tomli>=1.1.0 in /usr/local/lib/python3.10/dist-packages (from build->-r requirements.txt (line 2)) (2.0.1)
Requirement already satisfied: protobuf>=3.20.2 in /usr/local/lib/python3.10/dist-packages (from onnx>=1.12.0->-r requirements.txt (line 9)) (4.25.1)
Requirement already satisfied: sympy in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (1.12)
Requirement already satisfied: networkx in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (3.2)
Requirement already satisfied: jinja2 in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (3.1.2)
Requirement already satisfied: fsspec in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (2023.9.2)
Requirement already satisfied: nvidia-cuda-nvrtc-cu12==12.1.105 in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (12.1.105)
Requirement already satisfied: nvidia-cuda-runtime-cu12==12.1.105 in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (12.1.105)
Requirement already satisfied: nvidia-cuda-cupti-cu12==12.1.105 in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (12.1.105)
Requirement already satisfied: nvidia-cudnn-cu12==<IP_ADDRESS> in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-cublas-cu12==<IP_ADDRESS> in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-cufft-cu12==<IP_ADDRESS> in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-curand-cu12==<IP_ADDRESS> in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-cusolver-cu12==<IP_ADDRESS> in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-cusparse-cu12==<IP_ADDRESS> in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (<IP_ADDRESS>)
Requirement already satisfied: nvidia-nccl-cu12==2.18.1 in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (2.18.1)
Requirement already satisfied: nvidia-nvtx-cu12==12.1.105 in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (12.1.105)
Requirement already satisfied: triton==2.1.0 in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 13)) (2.1.0)
Requirement already satisfied: nvidia-nvjitlink-cu12 in /usr/local/lib/python3.10/dist-packages (from nvidia-cusolver-cu12==<IP_ADDRESS>->torch->-r requirements.txt (line 13)) (12.3.101)
Requirement already satisfied: coloredlogs in /usr/local/lib/python3.10/dist-packages (from optimum->-r requirements.txt (line 16)) (15.0.1)
Requirement already satisfied: dill in /usr/local/lib/python3.10/dist-packages (from evaluate->-r requirements.txt (line 17)) (0.3.7)
Requirement already satisfied: pandas in /usr/local/lib/python3.10/dist-packages (from evaluate->-r requirements.txt (line 17)) (2.1.4)
Requirement already satisfied: xxhash in /usr/local/lib/python3.10/dist-packages (from evaluate->-r requirements.txt (line 17)) (3.4.1)
Requirement already satisfied: multiprocess in /usr/local/lib/python3.10/dist-packages (from evaluate->-r requirements.txt (line 17)) (0.70.15)
Requirement already satisfied: responses<0.19 in /usr/local/lib/python3.10/dist-packages (from evaluate->-r requirements.txt (line 17)) (0.18.0)
Requirement already satisfied: pyarrow>=8.0.0 in /usr/local/lib/python3.10/dist-packages (from datasets->-r requirements-dev.txt (line 2)) (14.0.2)
Requirement already satisfied: pyarrow-hotfix in /usr/local/lib/python3.10/dist-packages (from datasets->-r requirements-dev.txt (line 2)) (0.6)
Requirement already satisfied: aiohttp in /usr/local/lib/python3.10/dist-packages (from datasets->-r requirements-dev.txt (line 2)) (3.9.1)
Requirement already satisfied: mypy-extensions>=1.0.0 in /usr/local/lib/python3.10/dist-packages (from mypy->-r requirements-dev.txt (line 6)) (1.0.0)
Requirement already satisfied: cfgv>=2.0.0 in /usr/local/lib/python3.10/dist-packages (from pre-commit->-r requirements-dev.txt (line 8)) (3.4.0)
Requirement already satisfied: identify>=1.0.0 in /usr/local/lib/python3.10/dist-packages (from pre-commit->-r requirements-dev.txt (line 8)) (2.5.33)
Requirement already satisfied: nodeenv>=0.11.1 in /usr/local/lib/python3.10/dist-packages (from pre-commit->-r requirements-dev.txt (line 8)) (1.8.0)
Requirement already satisfied: virtualenv>=20.10.0 in /usr/local/lib/python3.10/dist-packages (from pre-commit->-r requirements-dev.txt (line 8)) (20.25.0)
Requirement already satisfied: pytest>=4.6 in /usr/local/lib/python3.10/dist-packages (from pytest-cov->-r requirements-dev.txt (line 11)) (7.4.3)
Requirement already satisfied: coverage>=5.2.1 in /usr/local/lib/python3.10/dist-packages (from coverage[toml]>=5.2.1->pytest-cov->-r requirements-dev.txt (line 11)) (7.4.0)
Requirement already satisfied: py in /usr/local/lib/python3.10/dist-packages (from pytest-forked->-r requirements-dev.txt (line 12)) (1.11.0)
Requirement already satisfied: execnet>=1.1 in /usr/local/lib/python3.10/dist-packages (from pytest-xdist->-r requirements-dev.txt (line 13)) (2.0.2)
Requirement already satisfied: absl-py in /usr/local/lib/python3.10/dist-packages (from rouge_score->-r requirements-dev.txt (line 14)) (2.0.0)
Requirement already satisfied: nltk in /usr/local/lib/python3.10/dist-packages (from rouge_score->-r requirements-dev.txt (line 14)) (3.8.1)
Requirement already satisfied: six>=1.14.0 in /usr/lib/python3/dist-packages (from rouge_score->-r requirements-dev.txt (line 14)) (1.16.0)
Requirement already satisfied: attrs>=17.3.0 in /usr/local/lib/python3.10/dist-packages (from aiohttp->datasets->-r requirements-dev.txt (line 2)) (23.1.0)
Requirement already satisfied: multidict<7.0,>=4.5 in /usr/local/lib/python3.10/dist-packages (from aiohttp->datasets->-r requirements-dev.txt (line 2)) (6.0.4)
Requirement already satisfied: yarl<2.0,>=1.0 in /usr/local/lib/python3.10/dist-packages (from aiohttp->datasets->-r requirements-dev.txt (line 2)) (1.9.4)
Requirement already satisfied: frozenlist>=1.1.1 in /usr/local/lib/python3.10/dist-packages (from aiohttp->datasets->-r requirements-dev.txt (line 2)) (1.4.1)
Requirement already satisfied: aiosignal>=1.1.2 in /usr/local/lib/python3.10/dist-packages (from aiohttp->datasets->-r requirements-dev.txt (line 2)) (1.3.1)
Requirement already satisfied: async-timeout<5.0,>=4.0 in /usr/local/lib/python3.10/dist-packages (from aiohttp->datasets->-r requirements-dev.txt (line 2)) (4.0.3)
Requirement already satisfied: setuptools in /usr/local/lib/python3.10/dist-packages (from nodeenv>=0.11.1->pre-commit->-r requirements-dev.txt (line 8)) (68.2.2)
Requirement already satisfied: iniconfig in /usr/local/lib/python3.10/dist-packages (from pytest>=4.6->pytest-cov->-r requirements-dev.txt (line 11)) (2.0.0)
Requirement already satisfied: pluggy<2.0,>=0.12 in /usr/local/lib/python3.10/dist-packages (from pytest>=4.6->pytest-cov->-r requirements-dev.txt (line 11)) (1.3.0)
Requirement already satisfied: exceptiongroup>=1.0.0rc8 in /usr/local/lib/python3.10/dist-packages (from pytest>=4.6->pytest-cov->-r requirements-dev.txt (line 11)) (1.2.0)
Requirement already satisfied: charset-normalizer<4,>=2 in /usr/local/lib/python3.10/dist-packages (from requests->diffusers==0.15.0->-r requirements.txt (line 5)) (3.3.0)
Requirement already satisfied: idna<4,>=2.5 in /usr/local/lib/python3.10/dist-packages (from requests->diffusers==0.15.0->-r requirements.txt (line 5)) (3.4)
Requirement already satisfied: urllib3<3,>=1.21.1 in /usr/local/lib/python3.10/dist-packages (from requests->diffusers==0.15.0->-r requirements.txt (line 5)) (2.0.7)
Requirement already satisfied: certifi>=2017.4.17 in /usr/local/lib/python3.10/dist-packages (from requests->diffusers==0.15.0->-r requirements.txt (line 5)) (2023.7.22)
Requirement already satisfied: distlib<1,>=0.3.7 in /usr/local/lib/python3.10/dist-packages (from virtualenv>=20.10.0->pre-commit->-r requirements-dev.txt (line 8)) (0.3.8)
Requirement already satisfied: platformdirs<5,>=3.9.1 in /usr/local/lib/python3.10/dist-packages (from virtualenv>=20.10.0->pre-commit->-r requirements-dev.txt (line 8)) (4.1.0)
Requirement already satisfied: humanfriendly>=9.1 in /usr/local/lib/python3.10/dist-packages (from coloredlogs->optimum->-r requirements.txt (line 16)) (10.0)
Requirement already satisfied: MarkupSafe>=2.0 in /usr/local/lib/python3.10/dist-packages (from jinja2->torch->-r requirements.txt (line 13)) (2.1.3)
Requirement already satisfied: click in /usr/local/lib/python3.10/dist-packages (from nltk->rouge_score->-r requirements-dev.txt (line 14)) (8.1.7)
Requirement already satisfied: joblib in /usr/local/lib/python3.10/dist-packages (from nltk->rouge_score->-r requirements-dev.txt (line 14)) (1.3.2)
Requirement already satisfied: python-dateutil>=2.8.2 in /usr/local/lib/python3.10/dist-packages (from pandas->evaluate->-r requirements.txt (line 17)) (2.8.2)
Requirement already satisfied: pytz>=2020.1 in /usr/local/lib/python3.10/dist-packages (from pandas->evaluate->-r requirements.txt (line 17)) (2023.3.post1)
Requirement already satisfied: tzdata>=2022.1 in /usr/local/lib/python3.10/dist-packages (from pandas->evaluate->-r requirements.txt (line 17)) (2023.3)
Requirement already satisfied: mpmath>=0.19 in /usr/local/lib/python3.10/dist-packages (from sympy->torch->-r requirements.txt (line 13)) (1.3.0)
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
[notice] A new release of pip is available: 23.3 -> 23.3.2
[notice] To update, run: python3 -m pip install --upgrade pip
-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- NVTX is disabled
-- Importing batch manager
-- Building PyTorch
-- Building Google tests
-- Building benchmarks
-- Looking for a CUDA compiler
-- Looking for a CUDA compiler - NOTFOUND
CMake Error at CMakeLists.txt:118 (message):
No CUDA compiler found
-- Configuring incomplete, errors occurred!
See also "{mydir}/TensorRT-LLM/cpp/build/CMakeFiles/CMakeOutput.log".
See also "{mydir}/TensorRT-LLM/cpp/build/CMakeFiles/CMakeError.log".
Traceback (most recent call last):
File "{mydir}/TensorRT-LLM/./scripts/build_wheel.py", line 306, in
main(**vars(args))
File "{mydir}/TensorRT-LLM/./scripts/build_wheel.py", line 160, in main
build_run(
File "/usr/lib/python3.10/subprocess.py", line 526, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'cmake -DCMAKE_BUILD_TYPE="Release" -DBUILD_PYT="ON" -DBUILD_PYBIND="OFF"  -DTRT_LIB_DIR=/usr/local/tensorrt/targets/x86_64-linux-gnu/lib -DTRT_INCLUDE_DIR=/usr/local/tensorrt/include  -S "{mydir}/TensorRT-LLM/cpp"' returned non-zero exit status 1

I need to build TensorRT-LLM again?
then how I can build clear this error?

-- Looking for a CUDA compiler
-- Looking for a CUDA compiler - NOTFOUND
CMake Error at CMakeLists.txt:118 (message):
No CUDA compiler found

According the error message, please verify that CUDA is installed correctly. Thank you!

Thanks for reply.
after I did check my CUDA, when build TensorRT-LLM again, I got this error.

{skip logs...}
[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/weightOnlyBatchedGemvBs2Int8b.cu.o
[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/weightOnlyBatchedGemvBs4Int4b.cu.o
[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/weightOnlyBatchedGemvBs4Int8b.cu.o
[100%] Building CUDA object tensorrt_llm/kernels/CMakeFiles/kernels_src.dir/weightOnlyBatchedGemv/weightOnlyBatchedGemvBs3Int8b.cu.o
[100%] Built target layers_src
[100%] Built target common_src
[100%] Built target runtime_src
[100%] Built target kernels_src
[100%] Linking CXX static library libtensorrt_llm_static.a
[100%] Built target tensorrt_llm_static
[100%] Linking CXX shared library libtensorrt_llm.so
/usr/bin/ld: ../../tensorrt_llm/batch_manager/x86_64-linux-gnu/libtensorrt_llm_batch_manager_static.pre_cxx11.a(kvCacheManager.cpp.o): in function tensorrt_llm::batch_manager::kv_cache_manager::KVCacheManager::getMaxNumTokens(tensorrt_llm::batch_manager::kv_cache_manager::KvCacheConfig const&, nvinfer1::DataType, tensorrt_llm::runtime::GptModelConfig const&, tensorrt_llm::runtime::WorldConfig const&, tensorrt_llm::runtime::BufferManager const&)': kvCacheManager.cpp:(.text+0x213e): undefined reference to ompi_mpi_comm_world'
collect2: error: ld returned 1 exit status
gmake[3]: *** [tensorrt_llm/CMakeFiles/tensorrt_llm.dir/build.make:1223: tensorrt_llm/libtensorrt_llm.so] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:727: tensorrt_llm/CMakeFiles/tensorrt_llm.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:734: tensorrt_llm/CMakeFiles/tensorrt_llm.dir/rule] Error 2
gmake: *** [Makefile:179: tensorrt_llm] Error 2
Traceback (most recent call last):
File "/data/project/swkim/triton/TensorRT-LLM/./scripts/build_wheel.py", line 306, in
main(**vars(args))
File "/data/project/swkim/triton/TensorRT-LLM/./scripts/build_wheel.py", line 164, in main
build_run(
File "/usr/lib/python3.10/subprocess.py", line 526, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'cmake --build . --config Release --parallel 255 --target tensorrt_llm tensorrt_llm_static nvinfer_plugin_tensorrt_llm th_common  ' returned non-zero exit status 2.

I already checked #617, but I can't solve that.
I set without duplicated about mpi4py now.
how I can solve that?

@Shixiaowei02 Is there any way I can solve this problem?

@Shixiaowei02 Is there any way I can solve this problem?

@Shixiaowei02
Thanks, I build my docker image again.
and I now meet new error, when I run below
$ python3 ../run.py --max_output_len=50 \ --tokenizer_dir meta-llama/llama-2-7b-hf \ --engine_dir=./tmp/llama/out/
error message is:
... { skip error message } ...

[TensorRT-LLM][ERROR] tensorrt_llm::common::TllmException: [TensorRT-LLM][ERROR] Assertion failed: d == a + length (/src/tensorrt_llm/cpp/tensorrt_llm/plugins/gptAttentionCommon/gptAttentionCommon.cpp:434)
1       0x7f13c715d229 /usr/local/lib/python3.10/dist-packages/tensorrt_llm/libs/libnvinfer_plugin_tensorrt_llm.so(+0x47229) [0x7f13c715d229]
2       0x7f13c715d473 /usr/local/lib/python3.10/dist-packages/tensorrt_llm/libs/libnvinfer_plugin_tensorrt_llm.so(+0x47473) [0x7f13c715d473]
3       0x7f13c72268e3 tensorrt_llm::plugins::GPTAttentionPlugin::GPTAttentionPlugin(void const*, unsigned long) + 19
4       0x7f13c7226962 tensorrt_llm::plugins::GPTAttentionPluginCreator::deserializePlugin(char const*, void const*, unsigned long) + 50
5       0x7f1416cbf8a6 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10d68a6) [0x7f1416cbf8a6]
6       0x7f1416cb766e /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10ce66e) [0x7f1416cb766e]
7       0x7f1416c52217 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x1069217) [0x7f1416c52217]
8       0x7f1416c5019e /usr/local/tensorrt/lib/libnvinfer.so.9(+0x106719e) [0x7f1416c5019e]
9       0x7f1416c67c2b /usr/local/tensorrt/lib/libnvinfer.so.9(+0x107ec2b) [0x7f1416c67c2b]
10      0x7f1416c6ae32 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x1081e32) [0x7f1416c6ae32]
11      0x7f1416c6b20c /usr/local/tensorrt/lib/libnvinfer.so.9(+0x108220c) [0x7f1416c6b20c]
12      0x7f1416c9e9b1 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10b59b1) [0x7f1416c9e9b1]
13      0x7f1416c9f777 /usr/local/tensorrt/lib/libnvinfer.so.9(+0x10b6777) [0x7f1416c9f777]
14      0x7f14256571a5 /usr/local/lib/python3.10/dist-packages/tensorrt/tensorrt.so(+0x571a5) [0x7f14256571a5]
15      0x7f1425643433 /usr/local/lib/python3.10/dist-packages/tensorrt/tensorrt.so(+0x43433) [0x7f1425643433]
16      0x560d65c4ee0e python(+0x15fe0e) [0x560d65c4ee0e]
17      0x560d65c455eb _PyObject_MakeTpCall + 603
18      0x560d65c5d7bb python(+0x16e7bb) [0x560d65c5d7bb]
19      0x560d65c3d8a2 _PyEval_EvalFrameDefault + 24914
20      0x560d65c4f70c _PyFunction_Vectorcall + 124
21      0x560d65c37f52 _PyEval_EvalFrameDefault + 2050
22      0x560d65c44784 _PyObject_FastCallDictTstate + 196
23      0x560d65c59744 python(+0x16a744) [0x560d65c59744]
24      0x560d65c4558c _PyObject_MakeTpCall + 508
25      0x560d65c3dc66 _PyEval_EvalFrameDefault + 25878
26      0x560d65c4f70c _PyFunction_Vectorcall + 124
27      0x560d65c4482d _PyObject_FastCallDictTstate + 365
28      0x560d65c59744 python(+0x16a744) [0x560d65c59744]
29      0x560d65c4558c _PyObject_MakeTpCall + 508
30      0x560d65c3e908 _PyEval_EvalFrameDefault + 29112
31      0x560d65c5d4e1 python(+0x16e4e1) [0x560d65c5d4e1]
32      0x560d65c5e192 PyObject_Call + 290
33      0x560d65c3a2c1 _PyEval_EvalFrameDefault + 11121
34      0x560d65c4f70c _PyFunction_Vectorcall + 124
35      0x560d65c37e0d _PyEval_EvalFrameDefault + 1725
36      0x560d65d28e56 python(+0x239e56) [0x560d65d28e56]
37      0x560d65d28cf6 PyEval_EvalCode + 134
38      0x560d65d537d8 python(+0x2647d8) [0x560d65d537d8]
39      0x560d65d4d0bb python(+0x25e0bb) [0x560d65d4d0bb]
40      0x560d65d53525 python(+0x264525) [0x560d65d53525]
41      0x560d65d52a08 _PyRun_SimpleFileObject + 424
42      0x560d65d52653 _PyRun_AnyFileObject + 67
43      0x560d65d4541e Py_RunMain + 702
44      0x560d65d1bcad Py_BytesMain + 45
45      0x7f1675747d90 /usr/lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x7f1675747d90]
46      0x7f1675747e40 __libc_start_main + 128
47      0x560d65d1bba5 _start + 37
[instance-1902:17213:0:17213] Caught signal 11 (Segmentation fault: address not mapped to object at address (nil))
==== backtrace (tid:  17213) ====
0 0x0000000000042520 __sigaction()  ???:0
1 0x00000000010d475f createInferRuntime_INTERNAL()  ???:0
2 0x000000000107dd42 getInferLibVersion()  ???:0
3 0x00000000010808ec getInferLibVersion()  ???:0
4 0x0000000001081e32 getInferLibVersion()  ???:0
5 0x000000000108220c getInferLibVersion()  ???:0
6 0x00000000010b59b1 createInferRuntime_INTERNAL()  ???:0
7 0x00000000010b6777 createInferRuntime_INTERNAL()  ???:0
8 0x00000000000571a5 pybind11::cpp_function::initialize<tensorrt::lambdas::{lambda(nvinfer1::IRuntime&, pybind11::buffer&)#8} const&, nvinfer1::ICudaEngine*, nvinfer1::IRuntime&, pybind11::buffer&, pybind11::name, pybind11::is_method, pybind11::sibling, pybind11::arg, char const*, pybind11::call_guardpybind11::gil_scoped_release, pybind11::keep_alive<0ul, 1ul> >(tensorrt::lambdas::{lambda(nvinfer1::IRuntime&, pybind11::buffer&)#8} const&, nvinfer1::ICudaEngine* ()(nvinfer1::IRuntime&, pybind11::buffer&), pybind11::name const&, pybind11::is_method const&, pybind11::sibling const&, pybind11::arg const&, char const const&, pybind11::call_guardpybind11::gil_scoped_release const&, pybind11::keep_alive<0ul, 1ul> const&)::{lambda(pybind11::detail::function_call&)#3}::_FUN()  pyCore.cpp:0
9 0x0000000000043433 pybind11::cpp_function::dispatcher()  :0
10 0x000000000015fe0e PyObject_CallFunctionObjArgs()  ???:0
11 0x00000000001565eb _PyObject_MakeTpCall()  ???:0
12 0x000000000016e7bb PyMethod_New()  ???:0
13 0x000000000014e8a2 _PyEval_EvalFrameDefault()  ???:0
14 0x000000000016070c _PyFunction_Vectorcall()  ???:0
15 0x0000000000148f52 _PyEval_EvalFrameDefault()  ???:0
16 0x0000000000155784 _PyObject_FastCallDictTstate()  ???:0
17 0x000000000016a744 _PyStack_AsDict()  ???:0
18 0x000000000015658c _PyObject_MakeTpCall()  ???:0
19 0x000000000014ec66 _PyEval_EvalFrameDefault()  ???:0
20 0x000000000016070c _PyFunction_Vectorcall()  ???:0
21 0x000000000015582d _PyObject_FastCallDictTstate()  ???:0
22 0x000000000016a744 _PyStack_AsDict()  ???:0
23 0x000000000015658c _PyObject_MakeTpCall()  ???:0
24 0x000000000014f908 _PyEval_EvalFrameDefault()  ???:0
25 0x000000000016e4e1 PyMethod_New()  ???:0
26 0x000000000016f192 PyObject_Call()  ???:0
27 0x000000000014b2c1 _PyEval_EvalFrameDefault()  ???:0
28 0x000000000016070c _PyFunction_Vectorcall()  ???:0
29 0x0000000000148e0d _PyEval_EvalFrameDefault()  ???:0
30 0x0000000000239e56 PyEval_EvalCode()  ???:0
31 0x0000000000239cf6 PyEval_EvalCode()  ???:0
32 0x00000000002647d8 PyUnicode_Tailmatch()  ???:0
33 0x000000000025e0bb PyInit__collections()  ???:0
34 0x0000000000264525 PyUnicode_Tailmatch()  ???:0
35 0x0000000000263a08 _PyRun_SimpleFileObject()  ???:0
36 0x0000000000263653 _PyRun_AnyFileObject()  ???:0
37 0x000000000025641e Py_RunMain()  ???:0
38 0x000000000022ccad Py_BytesMain()  ???:0
39 0x0000000000029d90 __libc_init_first()  ???:0
40 0x0000000000029e40 __libc_start_main()  ???:0
41 0x000000000022cba5 _start()  ???:0
Segmentation fault (core dumped)

@namang301 Do you still have the problem? If not, we will close it soon.


Ionic 4 tabs router crash after go to next page

Bug Report
Ionic Info
cli packages: (C:\Users\Daniel Ehrhardt\AppData\Roaming\npm\node_modules)

   @ionic/cli-utils  : 2.0.0-alpha.0405736c
   ionic (Ionic CLI) : 4.0.0-alpha.0405736c

local packages:

   @angular/cli    : 6.0.1
   @ionic/core     : 4.0.0-alpha.7
   Ionic Framework : @ionic/angular 4.0.0-alpha.7

System:

   NodeJS : v8.11.2
   npm    : 6.0.1
   OS     : Windows 10

Describe the Bug
If i want to use a button with a nav.goForward or a routerlink inside a tab page the app crash after i click the Button and Go Back.
Steps to Reproduce
Steps to reproduce the behavior:

Download the Ionic 4 Tabs Starter
Add a test page
Create the Route to the Page
Create a button with a routelink to the Test Page
go back
--> Tabs are crashed

or checkout
https://github.com/danielehrhardt/ionic4-tabs
run

npm install
ng serve
click on the Go to About Button
Go Back
click on a different Tab

Expected Behavior
navigate to a other page and go back
Additional Context

  "dependencies": {
    "@angular/common": "6.0.2",
    "@angular/core": "6.0.2",
    "@angular/forms": "6.0.2",
    "@angular/http": "6.0.2",
    "@angular/platform-browser": "6.0.2",
    "@angular/platform-browser-dynamic": "6.0.2",
    "@angular/router": "6.0.2",
    "@ionic-native/core": "5.0.0-beta.10",
    "@ionic-native/splash-screen": "5.0.0-beta.10",
    "@ionic-native/status-bar": "5.0.0-beta.10",
    "@ionic/angular": "4.0.0-alpha.7",
    "@ionic/schematics-angular": "latest",
    "core-js": "^2.5.3",
    "rxjs": "6.1.0",
    "zone.js": "^0.8.26"
  },
  "devDependencies": {
    "@angular/cli": "6.0.1",
    "@angular/compiler": "6.0.2",
    "@angular/compiler-cli": "6.0.2",
    "@angular/language-service": "6.0.2",
    "@angular-devkit/build-angular": "0.6.0",
    "@angular-devkit/core": "0.6.0",
    "@angular-devkit/schematics": "0.6.0",
    "@types/jasmine": "~2.8.6",
    "@types/jasminewd2": "~2.0.3",
    "@types/node": "~10.1.0",
    "codelyzer": "~4.3.0",
    "jasmine-core": "~2.99.1",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~1.7.1",
    "karma-chrome-launcher": "~2.2.0",
    "karma-coverage-istanbul-reporter": "~1.4.2",
    "karma-jasmine": "~1.1.1",
    "karma-jasmine-html-reporter": "^0.2.2",
    "protractor": "~5.3.0",
    "ts-node": "~6.0.2",
    "tslint": "~5.10.0",
    "typescript": "~2.7.2"
  }

could you said if .goRoot and goBack reproduce the same issue?

Yes also with goRoot

any news on this? I believe I am encountering the same issue ...

same here. Any solution for this?

Think this is fixed in beta.17. If not, just write here!


build: update @angular/dev-infra-private to d2e31fb063b86f5b9e40db3c114496f67b5c528c

Updates to the latest version of @angular/dev-infra-private

This update is already been done by renovate bot.
https://github.com/angular/angular-cli/pull/19222

Thanks for this @josephperrott
Closing in favor of #19222


nipapd: fix 0 update

We would get an exception when 0 objects were updated by a query due to
a bug in this code which is now being handled.
Fixes #843.

Nice. Merging!


S3 migrate command interrupted, how to continue?

Output of restic version
restic 0.7.0
compiled with go1.8.3 on windows/amd64
How did you start restic exactly? (Include the complete command line)
restic.exe --repo s3:s3.amazonaws.com/bucket-name -p repo-pass.txt migrate s3_layout
What backend/server/service did you use?
Amazon S3
Expected behavior
Migrate backend to new layout
Actual behavior
1st run: the process began running and I could see the data files being renamed in the bucket. After some time the process stopped with a connection error. I lost the message because I then ran check and it was longer than the console scrollback, but it was related to network connection - I've had lots of connection errors so this wasn't surprising.
2nd run: migration s3_layout cannot be applied: check failed
Steps to reproduce the behavior
I expect that disconnecting the network during the migration process would probably replicate this.
Do you have any idea what may have caused this?
The migration was interrupted, so it looks to me like the repo is in an inconsistent state.
Is there a way to continue the migration?

Thanks for raising this issue, I'll have a look now.

Please check out the branch migrate-s3-continue, build restic with go run build.go and re-run the migration with ./restic migrate s3_legacy --force. It now can be re-run with then new --force option and automatically retries on error. Please report back!

I ran migrate s3_legacy --force, it continued the migration and I think it completed successfully. The files were renamed and as below the results of check look OK. Given how long it took to complete I expected a connection error but it didn't stop.
Output:
check for migration s3_layout failed, continuing anyway
applying migration s3_layout...
renaming file returned error: Put https://bucket-name.s3-ap-southeast-2.amazonaws.com/restic/data/fb/fb60...ddc273: dial tcp <IP_ADDRESS>:443: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
migration s3_layout: success

After completion I tried to run check but I had to unlock it first.
After unlocking the results of check were tons of pack xyz: not referenced in any index followed by
Check snapshots, trees and blobs
Fatal: repository contains errors

I understand from the docs that this isn't a problem but I can clean it up with purge.
Running a backup now and it looks all good. Thanks very much Alexander!

Hm, interesting. I find the message about unreferenced packs unexpected, I'll have a second look. Can you check that the number of snapshots matches? And that the path snapshot has been successfully renamed to snapshots (including all files in it)?

Yes snapshot was renamed to snapshots with all files. The list of snapshots and number of snapshots appears to be correct - I don't have anything to compare it with.
There were a lot of unreferenced packs were there before the migration so I wasn't surprised to see this. I began a prune afterwards and there was a similar amount of duplicate data.
Thanks again :)

Thanks fro the feedback, I'm much calmer now :)


New behavior on latest versions: Unable to create new pages w/ git-gateway and gitlab

Expected:
Able to create new pages via netlify-cms when using a gitlab repository and git-gateway as the backend
Actual:
Upon trying to create a new page, netlify-cms throws an error:
entries.js:592 TypeError: this.backend.unpublishedEntry is not a function
    at t.default.unpublishedEntry (implementation.js:502)
    at j.entryExist (backend.js:303)
    at j.generateUniqueSlug (backend.js:331)
    at j.persistEntry (backend.js:681)
    at entries.js:582
    at index.js:8
    at redux.js:462
    at Object.onPersist (Editor.js:102)
    at EditorInterface.js:147
    at Object.onSelection (Dropdown.js:85)

Applicable Versions:
"gatsby-plugin-netlify": "^2.0.17",
"gatsby-plugin-netlify-cms": "^4.0.2",
"netlify-cms": "^2.9.2",
"netlify-lambda": "^1.4.13",
CMS configuration

backend:
  name: git-gateway
  branch: master

Additional context

On this line:
https://github.com/netlify/netlify-cms/blame/0ce995d78c8123a32a3e9ef7117fd5386f3cd02d/packages/netlify-cms-core/src/backend.js#L266
this.interface.unpublishedEntries is always true since in git-gateway (below link) the function is always defined.
https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-backend-git-gateway/src/implementation.js#L416
this.backend is either an instance of  GitHubBackend or GitLabBackend, depending on whether it's gitlab or github.
https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-backend-git-gateway/src/implementation.js#L416
Currently, only Github has a unpublishedEntries call:
https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-backend-github/src/implementation.js#L246
Whereas unpublishedEntries it is missing from Gitlab:
https://github.com/netlify/netlify-cms/blob/master/packages/netlify-cms-backend-gitlab/src/implementation.js
And therefore when trying to create a new page, when trying to generateUniqueSlug, it'll fail with this.backend.unpublishedEntry is not a function since it doesn't exist in the instance of GitLabBackend.

You're trying to use the editorial workflow with GitLab, which isn't supported yet. You can track the feature request here: https://github.com/netlify/netlify-cms/issues/568
That said, this should be caught at load time and the CMS should provide an error message in the UI and block login, so that should be fixed.
Sent with GitHawk

I'm seeing the exact same behavior. I had just created a new site and started noticing this. However I do not have the publish_mode set at all. Is there a default non-workflow value that people can use for that property? I'm also using gitlab.

@davidroberts63 did you use a starter or add the CMS to an existing site?
Sent with GitHawk

@erquhart I don't have publish_mode: editorial_workflow set in my config.yml set, and when I tried setting it to publish_mode: simple it didn't seem to change the behavior of throwing TypeError: this.backend.unpublishedEntry is not a function

I've added it to an existing site. It's 11ty. I've done it with two other sites in the past.
The odd bit is that it can update an existing file just fine. Creating a new file is where the problem occurs.
I've double checked that I'm not using an older cashed version.

I'm trying to figure out which versions of netlify-cms + gatsby-plugin-netlify-cms.
gatsby-plugin-netlify-cms is also throwing an error for me :( https://github.com/gatsbyjs/gatsby/issues/14794
TypeError: Cannot read property "minimizer" of undefined

I'm having the same exact problem:
Netlify: 2.9.2
Git repo: Gitlab
Not using Gatsby nor netlify-lambda, using 11ty as the static site builder.
My 11ty site was built with Eleventy CMS from the begining, and it always worked until this release.
Config.yml doesn't set a editorial_workflow and is as follows:
backend:
  name: git-gateway
  branch: master

Can't publish new content, the entries.js:592 TypeError: this.backend.unpublishedEntry appear

Tried resetting Gitlab token, to no avail.
Only downgrading to 2.9.1 works.

@unyo just a note, you should not be using netlify-cms with ^4.0 of gatsby-plugin-netlify-cms, you should use netlify-cms-app. and it looks like the minimizer issue has been resolved.

@barthc can you see if this is the case introduced in #2139

Our project is in Hugo and is hosted on GitLab
Backend Config:
backend:
  name: git-gateway
  branch: master # Branch to update (optional; defaults to master)

Stack Trace:
entries.js:592 TypeError: this.backend.unpublishedEntry is not a function
    at t.default.unpublishedEntry (implementation.js:502)
    at j.entryExist (backend.js:303)
    at j.generateUniqueSlug (backend.js:331)
    at j.persistEntry (backend.js:681)
    at entries.js:582
    at index.js:8
    at redux.js:462
    at Object.onPersist (Editor.js:102)
    at EditorInterface.js:147
    at Object.onSelection (Dropdown.js:85)

@talves Yes #2139 introduced this issue, I will send in a PR to address the issue.


Splitting markdown files into sections

@bqpd, @whoburg: essentially what I want my pdf to look like is:
Weight Model:
Assumptions
List of all my assumptions
Variables
List of all my variables
Constraints
List of all my constraints
Aero Model:
Same thing
Then the solution table.
Any idea on how to do this? You can look at my latest commit in 1682master to see my md file.

SOLAR HIGH ALTITUDE LONG ENDURANCE AIRCRAFT
#inPDF: skip

from gpkit import Variable, Model, units
import numpy as np
import matplotlib.pyplot as plt

class SolarHALE(Model):
    """High altitude long endurance solar UAV"""
    def __init__(self, **kwargs):
        """Setup method should return objective, list of constraints"""
        constraints = []

Steady level flight variables
#inPDF: replace with slfvars.generated.tex
        CD = Variable('C_D', '-', 'Drag coefficient')
        CL = Variable('C_L', '-', 'Lift coefficient')
        P_shaft = Variable('P_{shaft}', 'W', 'Shaft power')
        S = Variable('S', 'm^2', 'Wing reference area')
        V = Variable('V', 'm/s', 'Cruise velocity')
        W = Variable('W', 'lbf', 'Aircraft weight')

        eta_prop = Variable(r'\eta_{prop}', 0.7, '-', 'Propulsive efficiency')
        rho = Variable(r'\rho', 'kg/m^3')

#inPDF: replace with slfcnstrs.generated.tex

        constraints.extend([P_shaft >= V*W*CD/CL/eta_prop,   # eta*P = D*V
                            W == 0.5*rho*V**2*CL*S])

Aerodynamics model
#inPDF: replace with aerovars.generated.tex

        Cd0 = Variable('C_{d0}', 0.002, '-', "non-wing drag coefficient")
        cdp = Variable("c_{dp}", "-", "wing profile drag coeff")
        CLmax = Variable('C_{L-max}', 1.5, '-', 'maximum lift coefficient')
        e = Variable('e', 0.9, '-', "spanwise efficiency")
        AR = Variable('AR', 27, '-', "aspect ratio")
        b = Variable('b', 'ft', 'span')
        mu = Variable(r'\mu', 1.5e-5, 'N*s/m^2', "dynamic viscosity")
        Re = Variable("Re", '-', "Reynolds number")
        Re_ref = Variable("Re_{ref}", 3e5, "-", "Reference Re for cdp")
        Cf = Variable("C_f", "-", "wing skin friction coefficient")
        Kwing = Variable("K_{wing}", 1.3, "-", "wing form factor")

#inPDF: replace with aerocnstrs.generated.tex

        constraints.extend([
            CD >= (Cd0 + cdp + CL**2/(np.pi*e*AR))*1.3,
            cdp >= ((0.006 + 0.005*CL**2 + 0.00012*CL**10)*(Re/Re_ref)**-0.3),
            b**2 == S*AR,
            CL <= CLmax,
            Re == rho*V/mu*(S/AR)**0.5,
            ])

Weight model
#inPDF: replace with weightvars.generated.tex
        W_batt = Variable('W_{batt}', 'lbf', 'Battery weight')
        W_airframe = Variable('W_{airframe}', 'lbf', 'Airframe weight')
        W_solar = Variable('W_{solar}', 'lbf', 'Solar panel weight')
        W_pay = Variable(r'W_{pay}', 4, 'lbf', 'Aircraft weight')

        E_batt = Variable('E_{batt}', 'J', 'Battery energy')
        rho_solar = Variable(r'\rho_{solar}', 1.2, 'kg/m^2',
                             'Solar cell area density')
        f_airframe = Variable('f_{airframe}', 0.20, '-',
                              'Airframe weight fraction')
        h_batt = Variable('h_{batt}', 250, 'W*hr/kg', 'Battery energy density')
        g = Variable('g', 9.81, 'm/s^2', 'Gravitational acceleration')

#inPDF: replace with weightcnstrs.generated.tex

        constraints.extend([W_airframe >= W*f_airframe,
                            W_batt >= E_batt/h_batt*g,
                            W_solar >= rho_solar*g*S,
                            W >= W_pay + W_solar + W_airframe + W_batt])

@bqpd, I don't have class today so if it would help to meet up to talk about what I'm envisioning then let me know.

was this resolved by using individual ConstraintSets?

Yes it was.


Added common JS things

initial set of basic JS stuff

Thank you so much!!!! I've merged this in and cleaned up a few things, and I'm working on the translations!


privacy manifest

Starting with Spring 2024 Apple requires third-party SDKs to add a Privacy Manifest file. Is there any plans to add a privacy manifest?

I don't remember any using User Defaults even in project. Which reason to add manifest?


un-removed required loading watcher

I goofed when testing some cleanup for the fix for the “no data” message bug and removed a watcher that I thought was unnecessary but was actually needed. This re-adds the watcher.

What is going wrong? Why is it necessary?


Add iOS Support

I did my best to keep the Swift implementation in sync with @YoussefKababe's Kotlin code. Not everything lines up exactly.

I ended up registering 3 plugins. admob_flutter (the default), AdmobInterstitialPlugin and AdmobRewardPlugin.
I'm not sure unique id's are required Interstitial and Reward but I followed suit for now. I think this should be revisited since Reward is a singleton in Swift and Interstitial's are one use and done.

Thanks for reviewing!
Closes #2

@kmcgill88 The above looks good to me! I'm approving the PR, and if you have tested it well and everything seems to work on your side as well, let's merge it! 🎉

The only potential issue I've seen is related to banner ads. This only happens occasionally. I wouldn't think the test ads would do this? I'm pulling my fork into my app now. I will try with my real id's.
<Google> Cannot find an ad network adapter with the name(s): com.google.DummyAdapter. Remember to link all required ad network adapters and SDKs, and set -ObjC in the 'Other Linker Flags' setting of your build target.
Unsupported value: Error Domain=com.google.admob Code=8 "Request Error: Cannot find an ad network adapter for mediation." UserInfo={NSLocalizedDescription=Request Error: Cannot find an ad network adapter for mediation.} of type GADRequestError

@YoussefKababe I think this is ready to go! 🚀 Please squash and merge when you have time to publish 0.3.0.

@kmcgill88 Just merged and releases 0.3.0. Thank you so much for the awesome work! 🎉 🚀 ❤


[LOW] [Splits] Split - After clicking on a Split button for a member, WS disappears in the Recent list

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.54-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Prerequisite: User has a WS

Tap FAB
Tap Request money
Tap Manual
Enter any value tap Next
Tap Split button on a Member row

Expected Result:
WS should still exist in the Recent list, after clicking on a Split button for a member
Actual Result:
WS disappear in the Recent list, after clicking on a Split button for a member
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/0c59c20f-f3ec-4242-b480-b1c87f02bbdb
View all open jobs on GitHub

@miljakljajic  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #vip-split

Proposal
Please re-state the problem that we are trying to solve in this issue.
Split - After clicking on a Split button for a member, WS disappears in the Recent list
What is the root cause of that problem?
Here we pass prop includeOwnedWorkspaceChats. When a participant is not selected, iouType is request, but after a participant is selected it becomes split and the iouType === CONST.IOU.TYPE.REQUEST condition becomes false.
What changes do you think we should make in order to solve the problem?
Always set the includeOwnedWorkspaceChats property to true or replace above condition with below|
iouType === CONST.IOU.TYPE.REQUEST || iouType === CONST.IOU.TYPE.SPLIT

What alternative solutions did you explore? (Optional)

this should be fine to be handled externally @lanitochka17 - adding the label now!

@miljakljajic This expected behaviour we can not split between workspace and users


Fix Incorrectly Mapped FERC-EIA PUDL IDs

A couple of errors in matching FERC respondent_id to utility_id_pudl and utility_id_eia

Entergy Louisiana LLC: FERC respondent_id 454, matches to utility_id_pudl 114. However, utility_id_eia 11241 is the same utility, but matches utility_id_pudl 107.
MDU Resources Group: FERC respondent_id 95, matches to utility_id_pudl 178. However, utility_id_eia 12199 is the same utility, but matches utility_id_pudl 193.
Catalyst Old River Hydroelectric Limited Partnership: FERC respondent_id 18, matches to utility_id_pudl 53. However, utility_id_eia 12199 ("First National Bank - Commerce") also reports Sidney A. Murray Jr hydro as its only plant and appears to be the same utility, but matches utility_id_pudl 6371.
NSTAR electric Company is respondent_id 309, utility_id_pudl 230. There's no utility_id_pudl for utility_id_eia 54913, which has the same solar plants listed in eia860 as FERC  and appears to be the same utility.

another couple of missing utilities in utilities_eia, found in the EIA ownership table:
THE ALLEGHENY GENERATING COMPANY is respondent_id 5. The only plant they own is Bath County, which is operated by Virginia Electric & Power. In the EIA Ownership table, they show up as "First Energy Solutions Corp.", utility_id_eia 6458 which doesn't have a pudl ID.
Wheeling Power Company is respondent_id 192. It owns half of the Mitchell (WV) plant, which operated by Kentucky Power Co. The EIA Ownership table shows that this is utility_id_eia 20521, which doesn't have a utility_id_pudl
Cheyenne Light, Fuel and Power Company is respondent_id 403 and only owns parts of plants operated by Black Hills. The EIA Ownership table says their utility_id_eia is 3461, which doesn't have a utility_id_pudl

@aesharpe @cmgosnell Did we address this issue?

And @bendnorman if you do take on #1069 you might want to look into this if these IDs haven't been dealt with yet.

Are these in 2010? Are they related to the messed up owner / operator reporting that @cmgosnell found (See #1116 which was recently fixed)

The utilities in Jon's first comment have all been correctly matched.
utility_id_eia 6458("first energy services") has PUDL ID 10312 in the most recent version of the matching spreadsheet. First Energy owns both of the parent companies that own The Allegheny Generating Company, which continues to report to FERC, so I don't think we want to assign them the same PUDL IDs.
Wheeling Power Company and Cheyenne Light, Fuel and Power Company need to be linked. It will be no problem to link Brame and Rodemacher as well. I'll check in with Austen tomorrow to make sure I'm updating the right version of the matching spreadsheet.

I've made these changes and sent the file to Austen to check in.


Fix mac install

Fixes some things on Mac by creating a separate virtualenv in virtualenv-osx, so you can run stuff in a (Linux) docker container and still do stuff in OS X.
I will try to include a fix for #3934 by implementing #3785 before this PR is ready. Done.
Also (for now) includes the additional logging from #4141.
Reviewers: please check the changes to the relative virtualenv path in tools/launchdev.sh, as I'm not 100% sure where that command is supposed to be run from. This PR changes the virtualenv to the virtualenv directory at the root of the repo, because that's what makes the most sense to me.
Also, my implementation in tail.py works, but I'm not sure if it's the most optimal threading model.
Fixed. It now uses eventlet greenthreads and a greenpool.

While I like the PR, this would make people develop on mac and not use docker dev env. I guess choice is good. The other thing is we had issues with eventlet monkey patching and OS X filesystem (case preserving but insensitive - cat CAT.txt and cat cat.txt are equivalent but you could create both the files IIRC). So OS X is a gray area.

Basically, see if all unit tests pass and lanuchdev.sh works ok. That's a good starting point for sanity on OS X.

It seems to me that it would be fair to add a note during virtualenv-osx creation to let user know that OSX is not officially supported at that point and the results he'll get by running st2 in OSX may not represent of what he will get in linux (false positives\negatives in tests that will later are going to came during CI, problems related to default case-insensitive behavior of HFS+, outdated native dependencies and so on).
I agree that user should be able to do some development on osx. I also believe that the problems with osx compatibility should be uncovered and eventually resolved even though our main focus continues to be in linux env.

@Kami or @enykeev I'll merge this in once one of you reviews it.

On a brand new OS X, make requirements fails
lakshmi@Lakshmis-MacBook-Pro ~/Work/src/storm/st2 (fix-mac-install)$ make requirements                        [ruby-2.3.3p222]

==================== virtualenv ====================

# Note: We pass --no-download flag to make sure version of pip which we install (9.0.1) is used
# instead of latest version being downloaded from PyPi
# For OS X, we have to bootstrap install pip because otherwise it runs into
# SSLv1 errors when connecting to https://pypi.python.org/simple/ to
# download anything
/bin/bash: virtualenv: command not found

I tried checkout out this branch, recreating the virtualen environment to make sure requirements are up to date and starting the sensor, but I get the following error on Linux - https://gist.github.com/Kami/8972f8da8dfedb9eb1269f1612cca78f
I would imagine it's probably related to eventlet select module monkey patch. I thought it's maybe related to code change in https://github.com/StackStorm/st2/pull/4118/files, but even if I remove those changes I get the same error locally.

I could get it to work if I removed eventlet monkey patch (but only partially since it immediately crashed after the file was modified).
To get this to work, we have a couple of options:

Modify inotify implementation so it's eventlet compatible (probably not that easy and a lot of work)
Add the same work around we have here for select.poll also for select.epoll - https://github.com/StackStorm/st2/pull/4118/files#diff-edec9adda8cdf5199d2b026e5c4c3fceR76

I'm personally not a big fan of 2) approach, we already have more hacks / workarounds than we would like to have.
So with the pyinotify working out of the box, I wonder if those changes are still good idea if we can't get it to work with 1).

Here is a list of two different changes with which I could get the sensor to start:

Remove eventlet monkey patch (just to test it, not feasible as a solution)

diff --git a/st2reactor/st2reactor/container/sensor_wrapper.py b/st2reactor/st2reactor/container/sensor_wrapper.py
index dfcc7ab2e..36bad6acf 100644
--- a/st2reactor/st2reactor/container/sensor_wrapper.py
+++ b/st2reactor/st2reactor/container/sensor_wrapper.py
@@ -46,8 +46,8 @@ __all__ = [
     'SensorService'
 ]

-monkey_patch()
-use_select_poll_workaround(nose_only=False)
+#monkey_patch()
+#use_select_poll_workaround(nose_only=False)

 class SensorService(object):

Add the same eventlet select workaround for select.epoll as we have for select.poll

diff --git a/st2common/st2common/util/monkey_patch.py b/st2common/st2common/util/monkey_patch.py
index b83d74a4f..38435868d 100644
--- a/st2common/st2common/util/monkey_patch.py
+++ b/st2common/st2common/util/monkey_patch.py
@@ -77,7 +77,9 @@ def use_select_poll_workaround(nose_only=True):
     if not nose_only or (nose_only and'nose' in sys.modules.keys()):
         # Add back blocking poll() to eventlet monkeypatched select
         original_poll = eventlet.patcher.original('select').poll
+        original_epoll = eventlet.patcher.original('select').epoll
         select.poll = original_poll
+        select.epoll = original_epoll

         sys.modules['select'] = select
         subprocess.select = select

As mentioned above, I'm not a huge fan of another workaround, especially because pyinotify code worked out of the box.
My main question with those code changes is what do we gain over the previous approach if we still need to maintain a fork (this time the code is inside this repo and not inside another one, not any better, imo) and we need additional hacks / workarounds.

Also, would it be possible to split file watch changes in a separate branch / PR?
This way we could review OS X changes independently and hopefully get them merged faster.

As far as mac changes go - can we also add some tests for that?
Travis CI supports osx OS so we should add some checks tests / checks, if possible.

Travis CI supports Python and it supports Mac, but it doesn't natively support Python on Mac. There are some ways to do it, but we don't support running ST2 itself or tests on OS X, so I don't know what that would buy us.

As discussed in slack - I'm generally -1 on this change primarily because of two things. The additions to the Makefile and the additional virtualenv. It's our build system and we should hope to keep it as clean as possible and with as minimal corner cases covered since we have the luxury of being opinionated about it. We have to maintain every line, after all. I'd rather the effort going into making devbox (docker backed) or vagrant as clean as possible and that be the "one-true" way to do things (developers will always do what they want, but that shouldn't make it into master.)
Don't consider this comment a blocker, just me voicing my concern.
I'm generally +1 to the linux tail change.


Upload(doc): fix api

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's contributing guide (中文 | English).
[ ] Make sure you are merging your commits to dev branch.
[ ] Add some descriptions and refer relative issues for you PR.

before-upload  不支持promise，这个很麻烦。只能另换upload组件。

@transtone thats not a bug, thats a feature! :)
// means that when you are on a https site it will result in https://
on an http site it will result in an http:// call


Inconsistency in when BeanContainer.createInstance() may be called

The Javadoc for BeanContainer.createInstance() defines its behaviour when called during AfterBeanDiscovery. The Javadoc for BeanManager says it's not valid before AfterBeanDiscovery.
However, the spec (3.9.1) says that it's not valid before AfterDeploymentValidation which is fired after AfterBeanDiscovery.
The spec and the Javadoc disagree here, which one should be changed?

It looks like the TCK asserts that it can't be called before AfterDeploymentValidation (i.e. matching what the spec says)

It looks like the TCK asserts that it can't be called before AfterDeploymentValidation (i.e. matching what the spec says)

This is what I would expect to be the correct behavior.
Weld should behave that way as well, although we skip this verification in non-portable mode.

The Javadoc for BeanContainer.createInstance() defines its behaviour when called during AfterBeanDiscovery.

Interestingly, the same javadoc, just a few lines below, also defines that it throws an exception if invoked before ADV :)

Weld should behave that way as well

It does :)

Interestingly, the same javadoc, just a few lines below, also defines that it throws an exception if invoked before ADV :)

Huh, so it does.
I guess it's just the Javadoc that needs cleaned up then. I will check for any other references and make a PR.

Thanks!


Error: unknown flag: --watches-file

From channel:
I'm seeing this in our CI runs:
Error: unknown flag: --watches-file
Usage:
  operator-sdk run [flags]
Flags:
      --kubeconfig string         The file path to kubernetes configuration file. Defaults to location specified by $KUBECONFIG, or to default file rules if not set
      --namespace string          The namespace where the operator watches for changes.
      --olm                       The operator to be run will be managed by OLM in a cluster. Cannot be set with another run-type flag
      --manifests string          [olm only] Directory containing package manifest and operator bundles.
      --operator-version string   [olm only] Version of operator to deploy
      --install-mode string       [olm only] InstallMode to create OperatorGroup with. Format: InstallModeType=[ns1,ns2[, ...]]
      --include strings           [olm only] Path to Kubernetes resource manifests, ex. Role, Subscription. These supplement or override defaults generated by run/cleanup
      --timeout duration          [olm only] Time to wait for the command to complete before failing (default 2m0s)
      --local                     The operator will be run locally by building the operator binary with the ability to access a kubernetes cluster using a kubeconfig file. Cannot be set with another run-type flag.
      --operator-flags string     [local only] The flags that the operator needs. Example: "--flag1 value1 --flag2=value2"
      --go-ldflags string         [local only] Set Go linker options
      --enable-delve              [local only] Start the operator using the delve debugger
  -h, --help                      help for run
Global Flags:
      --verbose   Enable verbose logging

I'm having a hard time following when this flag was removed from the cmd/operator-sdk/run code

Hi @estroz,
This came from the channel. I was looking and shows that we remove the flag  here: https://github.com/operator-framework/operator-sdk/pull/2441
However, I am still facing the flag in the doc sdk-cli-reference and I was not able to find this CHANGELOG.md.
In this way, I decide to raise the issue here for:

Verify if it should be removed ( I understand that yes )
Update the doc  sdk-cli-reference by replacing it for exec-entrypoint ansible --watches-file=/opt/ansible/watches.yaml.
Add a retroactive entry in the changelog with the breaking change.

Please, let me know if I misunderstood something here.

For more context, this is the entrypoint to our ansible-based Operator: https://github.com/operator-framework/operator-metering/blob/master/images/metering-ansible-operator/scripts/entrypoint.sh
I'm able to build and run our origin images locally fine, and the problem only occurs when CI is building and using our OCP images. As a next step, I can try and build the OCP images locally, replacing the ... run ansible --watches-file with the exec-entrypoint ansible --watches-file and hopefully that resolves this issue.

Hi @timflannagan1,
If you are using the 0.15.x then you entrypoint.sh need to be updated as here

The run -> exec-entrypoint name change is already a breaking change in the changelog. We need to update the release notes and migration guide for v0.15.x.


malicious attack request

valid request:  https://localhost:28005/test/test.js
malicious attack request:  https://localhost:28005/test/test.js;;";;alert(12);;s="
jetty server return PathInfo is : /test/test.js, how to avoid malicious attacks
        final StringBuilder builder = new StringBuilder(req.getServletPath());
        if (req.getPathInfo() != null) {
            builder.append(req.getPathInfo());
        }
        final CachedAsset cachedAsset = loadAsset(builder.toString());

Refer to this for avoidance stategies for this type of malicious requests: https://www.owasp.org/index.php/Reflected_File_Download
As per Servlet spec: Use javax.servlet.http.HttpServletRequest.getRequestURI() to get the unprocessed (raw) http request line.

thanks, reneploetz.but,
the code of question is the source code of dropwizard. Without modifying the source code, do I have any other ways besides adding a filter to filter out the attack URL? Does the dropwizard take this into account?

@lp2jx0309 You can add a Servlet Filter to your Dropwizard application which drops or denies that kind of request.
See ServletEnvironment#addFilter().

This kind of parameters are not necessarily attacks - they are valid matrix parameters that can be handled in JAX-RS (via @javax.ws.rs.MatrixParam).
The main problem can be that you return the values sent to your application as part of the response, hence the name "reflection attack". Note that the mentioned download attack is one of the issues - other is the possibility of a reflected XSS. Those issues are application-specific tough, because allowing matrix parameters or not is depending on the application as well as injecting user-sent content without application-specific validation can be problematic.
With the assets servlet that you mentioned, all of this is not relevant unless you would want to support matrix parameters within this resources. Only static resources are served which by definition cannot contain the passed parameters. Note that even passing those parameters might result in 404-errors as the static resources usually do not contain matrix parameters in their filename.
So while you can sent this request to a static resource, it lead to a resource without parameters being returned, but would have no security impact other than that (matrix parameters are simply ignored).

@reneploetz，Indeed, the static resources do not require matrix parameters. I added Filter to filter this matrix parameters request.

@reneploetz
Indeed, the static resources do not require matrix parameters. I added Filter to filter this matrix  parameters request.

@joschi
thanks, I have added a filter


translate Overview cloud native security into Chinese

translate Overview cloud native security into Chinese

pls squash your commits and rebase on master.

@fancc It has been almost a month ... still working on this?

/lgtm
/approve


withClasspathResourceMapping copies empty file

Hi, as title says - I'm using a withClasspathResourceMapping functionality, and as I can see - library copies empty file to container filesystem
I've made a small reproducible example here https://github.com/IgorPerikov/testcontainers-file-issue
steps to reproduce:

clone repo
put a debug point here
launch test with default debug config
when debug point achieved check container name with docker ps -a
get container fs docker export your_container_name > ~/log.tar
open archive, check /tmp/myfile

I've checked it with 1.6.0 and 1.5.1 versions, both copies empty file
➜  ~ docker -v
Docker version 17.12.0-ce, build c97c6d6

Hello, @rnorth @bsideup! Can you provide any help here, please?

Hi @IgorPerikov,
Sure, let me take a look. Also, @rnorth is out file system ninja, maybe he has some ideas :)

... and thank a lot for the demo repo 👍

@IgorPerikov I just tried and it worked on my machine (macOS, Docker for Mac)
Try this patch:
Index: src/test/java/com/github/igorperikov/issue/MovingFileToContainerTest.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/test/java/com/github/igorperikov/issue/MovingFileToContainerTest.java	(revision 62929eaeb02fcb592f069322d64a03739a51a632)
+++ src/test/java/com/github/igorperikov/issue/MovingFileToContainerTest.java	(date<PHONE_NUMBER>000)
@@ -1,6 +1,10 @@
 package com.github.igorperikov.issue;

+import com.github.dockerjava.api.DockerClient;
+import org.apache.commons.compress.archivers.tar.TarArchiveInputStream;
+import org.apache.commons.io.IOUtils;
 import org.junit.Test;
+import org.testcontainers.DockerClientFactory;
 import org.testcontainers.containers.BindMode;
 import org.testcontainers.containers.GenericContainer;

@@ -9,9 +13,17 @@
             .withClasspathResourceMapping("myfile", "/tmp/myfile", BindMode.READ_ONLY);

     @Test
-    public void justToMakeADebugPoint() {
+    public void justToMakeADebugPoint() throws Exception {
         container.start();
         System.out.println("I'm up");
-        container.stop();
+
+        DockerClient client = DockerClientFactory.instance().client();
+
+        try (TarArchiveInputStream tar = new TarArchiveInputStream(client.copyArchiveFromContainerCmd(container.getContainerId(), "/tmp/myfile").exec())) {
+            tar.getNextEntry();
+            String content = IOUtils.toString(tar);
+
+            assert content.startsWith("this\nis");
+        }
     }
 }

Also, what OS and method (docker-machine, Docker for Mac/Windows, native) are you using?

Test with this patch is passed. But when I verify it's content with docker export it still says that the file is empty.
Right now I've tested it with Ubuntu 14.04.5 LTS
My previous runs was at Ubuntu 16.04.? LTS
Speaking about method - I don't know how to answer for this part of question

@IgorPerikov on Linux it's "native" (no virtualization involved) :)
https://docs.docker.com/engine/reference/commandline/export/#parent-command

The docker export command does not export the contents of volumes associated with the container. If a volume is mounted on top of an existing directory in the container, docker export will export the contents of the underlying directory, not the contents of the volume.

that's why you're not seeing it I suppose :) But the file is there as you can see from my version of the test

Oh, that's why. Thanks for your help

@IgorPerikov always welcome :)


delegateToken is treated as a string but should be a secret

Identified that the delegateToken input is being displayed as plain text in the Helm release, this is because all the values passed onto helm are considered plain text unless you use set_sensitive.
I aim to fix that on this PR

This has been merged.


prefer arrays for small fixed-size fields

Path Challenge/Response data is exactly 8 bytes. Stateless Reset Token is exactly 16 bytes. If we know the sizes in advance, there's no reason for the dynamic allocation.

Merged, thanks @ehaydenr!


URL for image and particle data

[HIGH PRIORITY] How to access the URLs for other files like images/particle data/meshes?

@iyerkrithika21
image.file.url
segmentation.file.url
mesh.file.url
optimized_particles.world.url
optimized_particles.local.url
optimized_particles.transform.url
optimized_particles.groomed_segmentation.file.url
optimized_particles.groomed_mesh.file.url

Images obviously won't work until https://github.com/girder/shapeworks-cloud/pull/107 is merged

This issue was created based on a previous version. I will try with the latest pip version since the merge.


Feature request for null values from System Manager

Hi, this is more of a feature request than a bug. SSM doesn't allow to have null values set, however this null values might be useful on the app side. For our app we ended up creating a script that replaces a given value in SSM with null, in our case if the value equals the name of the variable we set the value as null. We could add something similar here if this feature has enough quorum and we can decide a standard. The code change from what I've seen is limited to the system-manager-backend.js

Here's a PR for this: https://github.com/godaddy/kubernetes-external-secrets/pull/251

This feels a bit weird to me, couldn't this be solved by the user? Eg you have a standard in your team that if an ssm value is set to THIS_IS_NULL your application could treat it accordingly.
Setting the value to null based on the key name and value matching seems like it could cause a lot of confusion if you are not aware or expecting this behaviour.

I know this is a weird solution, and definitely parameter store has this shortcoming (not allowing empty values). It doesn't have to be the name of the variable, it could be when the value is NULL or some other value. I can move this to be solved on the app side, but if I'm not the only one dealing with this problem it would be nice to have this CDR handle this use case.

I know this is a weird solution, and definitely parameter store has this shortcoming (not allowing empty values). It doesn't have to be the name of the variable, it could be when the value is NULL or some other value. I can move this to be solved on the app side, but if I'm not the only one dealing with this problem it would be nice to have this CDR handle this use case.


Msw update from 1.2.1 to 2.0.1

msw package updated from 1.2.1 to 2.0.1
The main changes are
Call signature changes for graphql mutationn and query ( breaking change from 2.0 - Response resolver call signature is no longer (req, res, ctx) => res() but instead ({ request }) => new Response().)
setupWorker call chnaged to msw/browser
https://github.com/mswjs/msw/releases?page=2
https://mswjs.io/docs/api/graphql/

For this kind of thing in the future, it would be good to write stuff in such a way that the library-specific code is inside a function so that the change can just be made in one place instead of having to change the code everywhere it is used.

Yes, I totally agree and I thought about while doing this. I think probably the way to go is  a generic function where the library specifics like request and response object can be defined within , which can wrap the required context specific response.


Minor improvements

I came across the need for these improvements when using your Library in my application.

Please accept this PR - the zoomView getter is handy!

Thank for your contribution. Sorry for my late response