Add merge method

The real-world scenario:
I want to display day-wise data for the last month
I have an incomplete Collection from en external data source - data for some days but not all. The collection is as follows:

key is the date
value is the data

I want to fill in the blanks as to have an entry for every date, but with blank/default values (so that I can display them in a graph)
Expected/naive solution:
$externalCollection; //However I get the data
$defaultCollection = Collection::from([/**something that gives me an entry with key for each day */]);

$dataWithFilledDefault = $defaultCollection->merge($externalCollection);

Ugly solution 1 - bypass collection
$externalCollection; //However I get the data
$defaultCollection = Collection::from([/**something that gives me an entry with key for each day */]);

$dataWithFilledDefault = Collection::from(array_merge($defaultCollection->toArray(), $externalCollection->toArray()));

Ugly solution 2 - search for each item in the other collection manually
$externalCollection; //However I get the data
$defaultCollection = Collection::from([/**something that gives me an entry with key for each day */]);

$dataWithFilledDefault = $defaultCollection->map(static function($value, $key) use ($externalCollection) {
            return $externalCollection->has($key) ? $externalCollection->get($key) : $value;
        });

You are probably looking for https://dusankasan.github.io/Knapsack/#Operations-replace or https://dusankasan.github.io/Knapsack/#Operations-replaceByKeys

Sorry, my bad. 'replace' was not really the keyword I had in mind for this operation so I missed it. You are absolutely right. It is exactly what I was looking for.


error Identifier .. is not a top level resource - when calling validateMoveResources?api-version=2018-02-01

Hi there ,
Azure API 2018-02-01
I was trying to call validation method of azure API which checks possibility of moving resources to a different subscription but I get http error 400
{"error":{"code":"ResourceNotTopLevel","message":"Identifier '/subscriptions/subscriptionId/resourceGroups/RGName/providers/microsoft.cdn/profiles/CDNResourceName/endpoints/endpointName' is not a top level resource."}}
The thing is that in the same Http body there is that CDN parent resource which I believe this error is complaining about, so I am passing this sort of http body
{     "resources":  [                       "/subscriptions/subscriptionid/resourceGroups/RGName/providers/microsoft.cdn/profiles/CDNResourceName",                       "/subscriptions/subscriptionid/resourceGroups/RGName/providers/microsoft.cdn/profiles/CDNResourceName/endpoints/endpointname"                   ],     "targetResourceGroup":  "/subscriptions/targetSubscriptionid/resourceGroups/TargetRGName" }
And if I remove the endpoint resourceId from the array , request is accepted.
Important note: via Azure Portal it is moving well , and validation is part of the move operation
Can you please give me an idea about what is potentially wrong with that REST api request?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 76c1c185-685f-27e0-e634-844b510b1834
Version Independent ID: 09375778-5354-ab44-c5c6-94c2aebe34bc
Content: Move Azure resources to new subscription or resource group
Content Source: articles/azure-resource-manager/resource-group-move-resources.md
Service: azure-resource-manager
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@agrebenyuk Thanks for your question. Can you please share the url, if there is a particular Azure doc you have been following?

Hi @Karishma-Tiwari-MSFT  ,
I've been following these two:
https://docs.microsoft.com/en-us/rest/api/resources/resources/validatemoveresources
and
https://docs.microsoft.com/en-us/azure/azure-resource-manager/resource-group-move-resources

@agrebenyuk Thanks for sharing the docs. We are currently investigating and will update you shortly.

@agrebenyuk still investigating your issue. we may need to engage support to dig deeper. DO you have a support plan? If not please send mail to<EMAIL_ADDRESS>with your subscription ID and any supplementary diagnostic outputs and we will gladly help with engaging technical support.
@tfitzmac do you have any insights on this?

@agrebenyuk - thanks for this feedback. I'll try to test this scenario, and verify how to handle parent/child resources.

@agrebenyuk Closing this issue for now.  please reply to<EMAIL_ADDRESS>and we will gladly continue the discussion.

Hi @femsulu , I have just sent all needed info to<EMAIL_ADDRESS>as you suggested. An my best preference would be to keep this ticket open if possible please just for tracking purposes as it is not fully resolved yet. Regards!

@agrebenyuk - sorry for delay in looking at this issue. I am back to evaluating it. The profile and endpoint must exist in the same resource group. The CDN service just validates the profile and then moves its endpoints too.
Currently, I don't have a good idea of how many services have the same behavior, or how you would know whether you need to pass in the child resource IDs for validation. So, I am hoping to provide a better answer about how to handle these scenarios.

Hi @tfitzmac , thanks for your reply. Am I understanding you right that if I want to validate CDN profile with endpoints I need to supply CDN profile ResourceId only to validation api and it will validate all underlying endpoints as well ? If yes, then this probably needs to be documented somewhere as it does not seem to be obvious and thanks again - it would be very beneficial if you come back with some sort of list of resources which act the same way. Cheers.


Automated dependency update binary

@sebastienvas @yutongz
cron jobs and other relevant setup to invoke this binary will be made in another PR
Design Doc

Jenkins job istio/presubmit passed

You might want to rebase your change. There are commits from your previous
PR.
On Jul 21, 2017 5:15 PM, "istio-bot"<EMAIL_ADDRESS>wrote:

Jenkins job istio/presubmit passed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/493#issuecomment-317139619, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ80Z18VsWflRIm5zgFq1Tb1FsWUQ5_dks5sQT8egaJpZM4OgADA
.

cc @costinm

PTAL
There is only one thing left. For reliable editing of WORKSPACE or repositories.bzl, we hope to implement what I called "dependency hoisting"
Example:

	new_git_repository(
		name = "mixerapi_git",
		commit = "ee9769f5b3304d9e01cd7ed6fb1dbb9b08e96210",
		remote = "https://github.com/istio/api.git",
	)

becomes

	MIXERAPI = "ee9769f5b3304d9e01cd7ed6fb1dbb9b08e96210"
	new_git_repository(
		name = "mixerapi_git",
		commit = MIXERAPI,
		remote = "https://github.com/istio/api.git",
	)

I will refactor getDeps() function once the WORKSPACE and other bazel relevant files in all istio repos have conformed to such standard.

Jenkins job istio/presubmit passed

Try to think of way to apply this to istio repo.
On Jul 24, 2017 8:15 PM, "istio-bot"<EMAIL_ADDRESS>wrote:
Jenkins job istio/presubmit passed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/493#issuecomment-317616767, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ80Z8QAuHZbeP1an1QO8e2dSbxsRgtpks5sRV3HgaJpZM4OgADA
.

I have noticed the work @costinm  has been doing, which is also an effort to address the evolving dependencies among the istio repos. I like his idea a lot, but before the discussion settles and given the p0 demand for this feature, maybe I should finish this (least intrusive to current architecture) to set in motion the automation of dependency update and together searching and implementing a cleaner solution right after. But do let me know if I should channel my effort elsewhere.

Jenkins job istio/presubmit passed

Jenkins job istio/presubmit passed

@chxchx: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
79e7605a4caea2d19c4d15c8b4b254c30f939b0e
link
@istio-testing bazel test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I actually noticed that you created this form istio/istio. It should be in istio/test-infra cold you move it there in toolbox as well ? Also, after talking to @yutongz, I realized that there is currently no easy way to extract metrics repos anymore to know how far behing they are. This will be important for the build cop, as they need to know which repos as outdated deps.


Add a website (https://www.everdev.it/)

My personal web portfolio with blog powered by Leptos and Axum.
Some features:

Visualization of posts or projects counter.
Deployed in my own personal server.
RedisDB to storage some data.
Feedback feature powered by SMPT to email sender.
TailwindCSS
Grafana and InfluxDB to monitoring.

@gbj thanks and congrats for your amazing project!


[Proposal] Allow ClipRRect.borderRadius to support BorderRadiusDirectional

Currently the borderRadius of ClipRRect is of type BorderRadius,
So it is not possible to use a ClipRRect with BorderRadiusDirectional.
Proposal
Allow ClipRRect.borderRadius to support BorderRadiusDirectional

@goderbauer & @danagbemava-nc I would love to contribute and work on this issue!
@sm2017 For the meantime, you can invoke resolve() on instances of BorderRadiusDirectional as a workaround.
If you need and example and feel lost of implementing my suggestion, feel free to ask!

@or-adar Thank you very much, I did the same before opening the issue

Ohh this is actually going to be very useful, looking forwoard to contributing to this thing

@danagbemava-nc I would like to work on this issue. Can you please assign me this issue

Feel free to send us a PR that fixes this.


Setup Question

This is a great project and I hope to be able to contribute in the future. Thanks for taking the time to create it.
I read the docs and watched a video or two, but I still don't quite understand how the setup works.
I have Django on an EC2 instance in VPC subnet connected to an RDS instance in the same subnet.
Do I simply install the AWS SDK and then follow the simple zappa directions?
Does the setup process try to create its own VPC? Will it make any changes to my existing VPCs?
If my requirements file is up-to-date do I need to be in a virtual environment? My project is not in one (long story).
Thanks in advance for clarifications.

Hey Steve, please use the Zappa main project for discussion, django-zappa is deprecated.
Zappa doesn't create its own VPCs, you just specify them in your settings. Currently a virtualenv is a requirement, but there is an open ticket to allow supping a req.txt file instead.
For specific questions, please hop by the slack: https://slack.zappa.io

Sorry about that Miserlou-  will do.
Thanks for the slack link...


printer redirection

I am developing printer redirection on wfreerdp-server.
After research microsoft RDP and related protocol([MS-RDPEPC] [MS-RDPEXPS]), I found there is Remote Desktop Easy Print driver(tspring.dll) which integrated to windows system, that support xps format data.
The protocol part([MS-RDPEPC] [MS-RDPEXPS]) I have coded,  but I don't know how to transfer print job and file data from server to client.
Now I get the xps driver example (XPSDrvSmpl) from Windows-driver-samples, but I am confused that
1. How to get print job?
2. the xps format content of print job?
3. How to get print ticket from xps driver?

we currently only implement [MS-RDPEPC] as converting XPS to PostScript is quite a challenge and required for anything non windows (cups et al speak postscript)
so, if you want to get that done you need to implement the parts in the spec regarding XPS support (e.g. [MS-RDPEXPS] client and server code.
As for using issues for questions, please prefer contacting us on our matrix chat, see https://freerdp.com for details.

we currently only implement [MS-RDPEPC] as converting XPS to PostScript is quite a challenge and required for anything non windows (cups et al speak postscript) so, if you want to get that done you need to implement the parts in the spec regarding XPS support (e.g. [MS-RDPEXPS] client and server code.
As for using issues for questions, please prefer contacting us on our matrix chat, see https://freerdp.com for details.

Appreciate your reply.
I has already implement [MS-RDPEXPS] part under wfreerdp-server. Communication is normal between mstsc and wfreerdp-server.
But I have no idea about print job.
Do you know the format of print job and how to send print job from server to client?
Could you give me some advice about printer driver and print job?

Now I acommplish the printing from server to client through xpsdrv and  MS-RDPEXPS protocol.
But how to make the preferences work？
Should I use client printer ticket in server xpsdrv？

@elvis-sun as already mentioned by @akallabeth you will have to implement the whole MS-RDPEXPS virtual channel in order to be able to do that.

@elvis-sun as already mentioned by @akallabeth you will have to implement the whole MS-RDPEXPS virtual channel in order to be able to do that.

@mfleisz
I hava implemented the whole MS-RDPEXPS, but I don't know how to make preferences work in client side

@elvis-sun as already mentioned by @akallabeth you will have to implement the whole MS-RDPEXPS virtual channel in order to be able to do that.

Could you give some tips？

@elvis-sun since we haven't implemented anything of MS-RDPEXPS, I doubt anyone has more information other than what is written in the spec - sorry.

Could you give some tips？

@elvis-sun as already mentioned by @akallabeth you will have to implement the whole MS-RDPEXPS virtual channel in order to be able to do that.

@mfleisz I hava implemented the whole MS-RDPEXPS, but I don't know how to make preferences work in client side

@mfleisz
I implement the MS-RDPEXPS in wfreerdps-server, then use mstsc to connect wfreerdp-server.
Now I can print document.
Just preferences not work, for example the orientation setting.


Fix documentation on nginx ingress installation and ssh-proxy

Description

The example in the docs should match what the users need to do in reality. They don't want to expose no scheduler service but ssh-proxy instead.
Motivation and Context

We don't want to confuse people
How Has This Been Tested?

Looks in a deployed kubecf for the right name of the service
Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code has security implications.
[ ] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.

It's just that the service names aren't correct anymore - not namespaced. I once corrected it in the community docs, see https://github.com/cloudfoundry-incubator/kubecf-docs/commit/8d8c10d12a0c7c120846e038030cce0b21bb5526


403 https://api2.realtor.ca/Listing.svc/PropertySearch_Post

Hello,
It looks like realtor.ca recently changed the https://api2.realtor.ca/Listing.svc/PropertySearch_Post endpoint.
All requests now result in 403.

Hi @sabatale ,
Thanks for using pyRealtor and raising a concern.
Yes, we were getting 403 status code from Realtor.ca. After debugging, I found that their API Endpoint is same (https://api2.realtor.ca/Listing.svc/PropertySearch_Post), however they changed some of their API security features and started to block all API requests coming from proxy server.
I have changed the code, and published the new change in pyRealtor version 0.1.7.
Could you please try reinstalling the package and running the code again?

Thanks! Looks like it's working 👍


Events with different colors, please add this simple fucntionality

Hi I really like your calendar component, it is simple and compact, very good for dashboards.
Could you please add this simple feature as event color property to you event class?
I grab events from Google Calendar, where I have holidays in green, my events in red, birthdays in blue etc... Google api passes these colors (backgroundColor and foregroundColor) along as part of even object.
If you had backgroundColor and foregroundColor properties in your event object, it would be great and will help to display events in different colors on the calendar, no need to define any css, simply apply style="background-color: {event.backgroundColor}; color: event.foregroundColor". Could you please add this simple functionality? I can make this change locally, but I want to keep up with the latest version from your bower repository. Also it makes sense to move away from bower to npm IMHO, the vast majority of components and frameworks are in NPM these days. Thanks s bunch. Cheers :)

@slishnevsky Sure, I can add it. This calendar is based on Angular 1, that's why I tend to keep it into maintenance mode. Do you still plan to use it since Angular 6 is also there?

@twinssbc
Hi, I like you calendar a lot for simplicity. I have switched from AngularJS to Angular (v6 v7) do you by any chance have this calendar available for Angular? Thanks !!

@slishnevsky Sorry, I didn't write an Angular version.

Hello,
The idea of color is very interesting. We use this calendar in an internal project since few yea and we have no request to change currently.
If you cana add (easily)  selected color for event type, it will be very nice :)

i ll leave what i did here, maybe it can help someone. In my controller i added eventsource a condition whether it should be green or red:
color: (calendar_time['free_quota'] < 1 ? 'red' : 'green' ),

and in calendar.css file, i added two class below calender-event-inner as:
.calendar-event-inner.green {
background-color: #26c281;
color : white;
font-weight:bold;
}
.calendar-event-inner.red {
background-color: #e6291b;
color : white;
font-weight:bold;
}

and in the calendar.tpls.js file, gotta add ng-class next to calendar-event-inner div like:
ng-class="displayEvent.event.color.  (both line 1248 and 1270)
this works fine, cheers.


Initialize num_properties to 0 in ParameterSerializer.hpp

Building Fast-RTPS 2.0.x issues a warning on my system because num_properties may be unitialized. This PR sets num_properties to 0 and adds a check on valid. I wasn't sure which branch to target. Let me know if this should be targeting master instead.
Builds --packages-up-to rclcpp, and tests --packages-above fastrtps --packages-up-to rclcpp

Linux
Linux-aarch64
macOS
Windows

Signed-off-by: Stephen Brawner<EMAIL_ADDRESS>

Build status:

Linux
Mac
Windows

Thanks for running the tests. It doesn't look like those failures are related to my PR, but I'm not familiar with this codebase. Please let me know if there is anything I can do!

@brawner Thanks for your contribution!

Build status:

Linux
Mac
Windows


Lock to a specific release of Scarpe-Components and Lacci

We'll want a new release, I think. Short-term we could probably use head-of-main.

This is way off in the future, and also far too coarse-grained.


Added SubGridSelectAll

Added Feature to Click Select All option on a Subgrid

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Other (updates to documentation, formatting, etc.)

Description
Added a new Method to ClickSelectAll on the Subgrid to select all the records on the current page.
New command example to select all records on a Contacts Subgrid : client.ClickSubgridSelectAll("Contacts");
Issues addressed

All submissions:

[x] My code follows the code style of this project.
[x] Do existing samples that are effected by this change still run?
[ ] I have added samples for new functionality.
[x] I raise detailed error messages when possible.
[x] My code does not rely on labels that have the option to be hidden.

Which browsers was this tested on?

[x] Chrome
[ ] Firefox
[ ] IE
[ ] Edge

@dylanhaskins - Thanks for raising this. I've made some changes to the method, but have incorporated it into #864 .
The core of the changes ask for subGridSchemaName input (as opposed to a section name). This should ensure that the Select All method works across any subgrid (with the exception of 'card' layouts).
If you have any concerns with this, please let me know.
Warm Regards,
Tyler

Thanks @TYLEROL , I have incorporated this into our tests and confirm it is working perfectly.
Much appreciated.


The Composer installer script did not run correctly [exit code 259] and no output was returned.

Please supply a log file, as requested when you created this issue, otherwise we cannot help you.


grammatical errors

Your document contains some grammar errors and typos that should be corrected.  For example, early in the third sentence, the word "is"  should be "as"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e18eead-7795-0752-93b0-e07f6d088089
Version Independent ID: f637de69-b13c-eed8-ab05-3515106c9270
Content: What is Git? - Azure DevOps
Content Source: https://mseng.visualstudio.com/DefaultCollection/TechnicalContent/_git/devops-learn-pr?path=%2fdocs%2fgit%2fwhat-is-git.md&version=GBlive&_a=contents
Product: devops
Git Login: samgu
Microsoft Alias: kangan

@JJones-IAI Sorry this one slipped through the cracks and that it took so long to reply. I'll get this reviewed. Thanks for your feedback.


which-key requires updated bindings for v3

Describe the bug
Right now, if you start Neovim after updating plugins, you get:
There were issues reported with your **which-key** mappings.
Use `:checkhealth which-key` to find out more.
Press ENTER or type command to continue

To Reproduce

Start neovim
enter :Lazy console
Hit 'U' to update plugins.
Exit and restart neovim, receive above warning.

Desktop

OS: MacOS Sonoma 14.5
Terminal: Kitty

Neovim Version

0.10.0

D'OH! This is already fixed in master and I just needed to update :)
sheepish grin


Conv2d custom weights

x = np.random.rand(4, 10, 10, 128)
y = keras.layers.Conv2D(32, 3, activation='relu',kernel_initializer='glorot_uniform')
print(y.weights)
y.add_weight(shape =(3, 3, 128, 32),initializer='glorot_uniform', name='kernelA',trainable=True)
print(y.weights)
z = y(x)
print(y.weights)

Output:
"[]
[<KerasVariable shape=(3, 3, 128, 32), dtype=float32, path=conv2d_1/kernelA>]
[<KerasVariable shape=(3, 3, 128, 32), dtype=float32, path=conv2d_1/kernelA>, <KerasVariable shape=(3, 3, 128, 32), dtype=float32, path=conv2d_1/kernel>, <KerasVariable shape=(32,), dtype=float32, path=conv2d_1/bias>]"

So I wanted to use my kernels/weights, but I cannot since Keras conv2d creates another kernel by default after It runs with input. This becomes problematic in train cases since it just sees the kernel it created. How could I overcome this issue or this feature?
Also, when we want to implement it as a customer layer: customconv2d(keras.layers.Layer) with init, build, and call? How should we add our custom weights?
I couldn't see anything about it on the documentation; it was just about the initializer. Also, for custom layers, there was just an example for linear.

Hi,
I was able to reproduce the issue using Keras 3, please find the attached Gist here for reference. Thanks!

This code looks to me like it is working as expected.
Linie by line my understanding is as follows:

dummy data
You create a vanilla Conv2D layer (not build yet)
First print: [] -> nothing has been built yet, so no weights are present
You manually add a weight called KernelA to the layer.
Second print: [KernelA] -> the weight you added appears in weights, however the layer itself still has not been and cannot be build as not all input dimensions are known.
You build the layer by passing an input through it. Now all dimensions are known and the kernel tensor can be initialized.
Third print: [KernelA, Kernel, Bias] -> the build function of the Conv2D layer added a kernel and bias to the weights. These Kernel and Bias weights are used in the Conv2D layer calculations.

Note that the .weights property just shows all the weights that have been added, it does not indicate if the weights in the list are used or not (however, the optimizer would warn you that there is no gradient for your kernelA, if you were to train the layer). Custom behavior with custom weights requires modifications to the call statement, which would require a custom layer. The custom layer can be created using standard inheritance and is well documented in the api docs for base layer that you already referenced. While the doc page references a linear layer in particular, the example should provide all the information you need to create any custom layer with custom weights and custom functionality.

Hey @MoritzMo123, thanks a lot for your detailed answer and for explaining it line by line. I wanted to ask about this feature to clarify how it works. Since, as I thought, it is not an issue, I'm closing it.


Test against PHP 7.0 and HHVM

I've modified travis to test against PHP 7.0 and
against HHVM, but allow the tests to fail - for now.
This should help identify where and what would need
to be cleaned up or adjusted to meet the requirements
for those languages/versions.

Example build at https://travis-ci.org/moltin/php-sdk/builds/84109809

great! :+1:  I'm excited to see everything working on php7 :smile:


Support for Bresser 7-in-1 weather stations

Hi,
I have included the decoder for the Bresser 7-in-1 into this library (based on https://github.com/merbanan/rtl_433/blob/master/src/devices/bresser_7in1.c). You can check my forked repo at https://github.com/jorgenavarroortiz/BresserWeatherSensorReceiver.
After the pull request I will update the description at the beginning with two examples of weather stations using this decoder.
I hope you will find it useful and included in the upstream repository. Thanks.
Best regards,
Jorge

By the way, I have also included the pinout for the Heltec Wireless Stick (https://heltec.org/project/wireless-stick/), which is the device I have been using.

Dear Jorge,
Thank you very much for your contribution!
There are still two compiler warnings which I would like to have fixed before merging this pull request:
/home/runner/work/BresserWeatherSensorReceiver/BresserWeatherSensorReceiver/src/WeatherSensor.cpp: In member function 'DecodeStatus WeatherSensor::decodeBresser6In1Payload(uint8_t*, uint8_t)':
/home/runner/work/BresserWeatherSensorReceiver/BresserWeatherSensorReceiver/src/WeatherSensor.cpp:649:10: error: unused variable 'light_ok' [-Werror=unused-variable]
     bool light_ok    = false;
          ^~~~~~~~
/home/runner/work/BresserWeatherSensorReceiver/BresserWeatherSensorReceiver/src/WeatherSensor.cpp: In member function 'DecodeStatus WeatherSensor::decodeBresser7In1Payload(uint8_t*, uint8_t)':
/home/runner/work/BresserWeatherSensorReceiver/BresserWeatherSensorReceiver/src/WeatherSensor.cpp:811:15: error: unused variable 'tmp' [-Werror=unused-variable]
       uint8_t tmp = msg[i];
               ^~~
cc1plus: some warnings being treated as errors

May I ask you to fix this? I can imagine that was already in the original rtl_433 code.
Best regards
Matthias

Dear Jorge,
Thank you very much for your contribution!
There are still two compiler warnings which I would like to have fixed before merging this pull request:
/home/runner/work/BresserWeatherSensorReceiver/BresserWeatherSensorReceiver/src/WeatherSensor.cpp: In member function 'DecodeStatus WeatherSensor::decodeBresser6In1Payload(uint8_t*, uint8_t)':
/home/runner/work/BresserWeatherSensorReceiver/BresserWeatherSensorReceiver/src/WeatherSensor.cpp:649:10: error: unused variable 'light_ok' [-Werror=unused-variable]
     bool light_ok    = false;
          ^~~~~~~~
/home/runner/work/BresserWeatherSensorReceiver/BresserWeatherSensorReceiver/src/WeatherSensor.cpp: In member function 'DecodeStatus WeatherSensor::decodeBresser7In1Payload(uint8_t*, uint8_t)':
/home/runner/work/BresserWeatherSensorReceiver/BresserWeatherSensorReceiver/src/WeatherSensor.cpp:811:15: error: unused variable 'tmp' [-Werror=unused-variable]
       uint8_t tmp = msg[i];
               ^~~
cc1plus: some warnings being treated as errors

May I ask you to fix this? I can imagine that was already in the original rtl_433 code.
Best regards Matthias

I think I have corrected them in the fork repo (it was just to remove those files). I hope that this is already updated in the pull request, but I have little experience with github and pull requests. Can you check that everything is ok? If not, please just remove those lines. Thanks.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.997%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
30090

Relevant Lines:
30091

💛  - Coveralls

Thank you very much for the modifications! I have included your pull request  in 90b8e3394c0fbe311519a89afe3419c853a45e92 and made a few minor changes afterwards. The most important modification was to change the define set by the Arduino IDE for the "Heltec Wireless Stick" to ARDUINO_heltec_wireless_stick. This board has also been added to the CI workflow.
I will provide an updated release within the next couple of days.
Many thanks for this great addition!


Add new aliases for take and drop methods

Pull Request Description
Adds the aliases 'keep' and 'remove' to take/drop methods
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Support pom-only artifacts?

They exist, they don't have any jar. The can be supported by just adding a special case in AetherResolverImpl but they need checking that we don't go trying to load their jar in places.

Another issue is boms (Bill of Materials) like what Arquillian uses.

The problem with BOMs is that they don't declare dependencies, but versions for dependencies. You still have to import the dependencies you want, just not with their versions. https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html explains it. The BOM itself has no dependency. This is more like set in our overrides, but allowing you to import modules with no version.
We could support it by allowing no-version imports and stuffing the BOMs into overrides.

We could support it by allowing no-version imports and stuffing the BOMs into overrides.

Well that doesn't sound unreasonable. You mean no-version imports in module.ceylon, right?

Yes.

Sounds OK. Or, alternatively, you just write:
import "group.id:artifact-id" "?";

And the BOM overrides "?" to something meaningful.

For this to work properly tools would have to warn us at compile time that we need to specify those versions in an overrides file. Although my first preference would be to leave out the version instead of using a ? it does make it more difficult to give nice error messages because the intention of the programmer is more ambiguous: did they mean to use overrides or did they just forget the version? In that case using something like "?" is more obvious.

This was done by @FroMage, as far as I understand.

Support for BOMs is now #6674.


Display pending HBD to HIVE conversion(s)

When you convert HBD to HIVE conversion, the amount of HBD converted is moved into "limbo" for 3.5 days and is deduced from your liquid HBD
It would be nice if Keychain could display information about pending conversions (like peakd does):

I dont want to put too much info on the main screen and make it difficultly readable .
However, we can add a list of current conversions to the conversion screen, the same way we are showing current delegations on the delegation page.

A small icon with a tooltip like "n HBD pending conversion" would be enough for me.
More details on a separate page would be the icing on the cake


extra class selectors in dist/css/bootstrap-datepicker3.css

This is an issue with v1.4.0 (it looks like older releases did not include a dist/ directory).
See https://github.com/eternicode/bootstrap-datepicker/blob/v1.4.0/dist/css/bootstrap-datepicker3.css#L480
.active.active seems like unintentional specificity. This issue appears elsewhere in the /dist/css if more examples are needed.

Older releases had their compiled css in the css dir, but it was also an issue in 1.3.1 . I will take a look at the less files what causes this issue!

Fixed in #1638.


This fixes the "New Game" functionality not working, due to C7 JSON not loading.

Git Bisect pointed me to the VS2019 commit, and after double-checking, somehow that is the relevant one.  This commit consists of a reversion of that commit, plus including a regenerated c7-static-map-save.json file.
Please verify locally that this fixes the issue for you.  Still investigating why the VS change caused the issue, my guess is the change from net472 to netstandard2.0 in C7.csproj, though I don't know why that would have caused the issue.  But maybe Godot uses the sln and it was something in there?

Restored the changes to C7.sln as they are not causing any issues locally.  This seems to be sufficient for Visual Studio to compile the project, provide IntelliSense, etc., while being compatible with Godot.  It also makes more sense that the .csproj change was the one causing a JSON issue, given that there are some known changes in .netstandard 5.0 relative to .net4.7.2.

@Ulrich-Schmidt Does it not compile in Godot, or Visual Studio, or both?  I just realized Puppeteer and I were compiling the static-json-builder using completely different commands, so there are some differences going on.
With my local Visual Studio 2019, a clean and build works, when I open the C7.sln file.  Visual Studio reports that it is version 16.4.1, with Microsoft .NET Framework Version 4.8.03761.  I did notice that the Visual Studio version seems to have gone from 15 to 16, although I thought we'd both said we were on 2019, so maybe that has something to do with it.

Merging to fix the New Game issue.  I'd still like to figure out what's going on with Visual Studio so Lanzelot is back in commission.  I wonder if it's VS2017 vs VS2019?  Or a Mono vs .NET issue.

As mentioned in the forum, I just installed VS 2019, and this PR works. I opened the .sln in VS, pulled this merged commit as head, and I could use the build option in VS with 11 warnings and no errors. I could build from Godot successfully and open a new game.
VS did drop a backup sln file and an "Upgrade.htm" file which seems to suggest it did something to the .sln, but git sees no changes, only the 2 new files.


⚠ Bofrost.lu has degraded performance

In d419493, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2097 ms

Resolved: Bofrost.lu performance has improved in da06d3f after 7 minutes.


About usage

Download or `git clone` the buttons in a proper place. Hold on command button and drag each one into your Finder toolbar.

I try this guide first but fail.
After some random action, I find the right steps are:

press and hold left mouse button on the icon of app (e.g. CotEditorFinderButton.app) in a Finder window.
press and hold command key on keyboard.
drag the icon to Finder tool bar.

Any other way is wrong.

I'm using Magic Trackpad 2. I can confirm that I have to press down the command key first.
Could you specify your mouse?

My mouse is SteelSeries. Also, I try the built-in trackpad, same issue.
By the way, I'm using Go2Shell to launch terminal at current path.


Added the option to change WebDriver capabilities

I had to change the default capabilities for the WebDriver but the crate does not provide this function.
Renamed the chrome() function to chrome_caps and made it accept ChromeCapabilities as an argument.
Also created a chrome() function that calls chrome_caps with default ChromeCapabilities.
Usage example (changing the downloads directory):
let mut caps = DesiredCapabilities::chrome();
let mut prefs = HashMap::new();
prefs.insert("download.default_directory", "/path/to/directory");
caps.add_chrome_option("prefs", prefs)?;
let driver = chrome_caps(caps).await?;

Thanks for the contribution! I still have lots of changes to merge and will try to have a look at it as soon as possible


Fix stores filtering resets on reload

Fixes #5951

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes
g0.store_matches parameter appears in the url but doesn't applies in the frontend. Looks like it has been done on purpose and by removing a small piece of code fixes this issue.
variable named debugMode is used for the store filtering checkbox which is an unappropriate name. Using enableStoreFiltering variable to represent the state of checkbox.
Verification
I have tested this and the store filtering remains after window reload.

Could you please run make assets and upload the new bindata.go file before merging? :muscle: thanks for fixing!


bản quyền

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

có người đã sử dụng video của tôi để đăng lên nền tảng youtube làm cách nào tôi có thể gỡ nó xuống


How to loop when the slide has two lines

I have a project where I use the carousel with 2 lines, however, when it arrives at the end the slide locks and does not return to the first one. How can I do to leave in infinite loop?

Your issue is closed because it is not filled correctly. Before you open an issue please review the contributing guideline.
Please fill the issue template correctly and:

Clearly describe the issue including steps to reproduce when it is a bug.
Make sure you fill in the earliest version that you know has the issue.
Provide live link or JSFiddle/Codepen or website with isssue

It will save a lot of time for other contributors to check your issue and fix it.


Support type intersections

Same syntax as type unions, but with & as the delimiter instead of |. Thanks!

I'm sorry, this isn't enough for us to evaluate your request. Please update this issue with examples and links to relevant JSDoc docs showing what you're requesting. Thanks!

Hi! Here are a few recent examples of intersection types as a JavaScript language feature:
https://flowtype.org/docs/union-intersection-types.html
https://www.typescriptlang.org/docs/handbook/advanced-types.html
Could do this currently, but it'll wind up being a NameExpression. I assume that won't work with whitespace, though?

@nzakas Went ahead and submitted a PR for this. Thanks again!

@joelday Thanks! I'm not familiar enough with the doctrine codebase to review the PR, so I'll leave that to someone else. However, I do have a question -- does JSDoc itself specify that intersection types should be supported? While TypeScript and Flow do have support for intersection types with particular semantics, to my knowledge doctrine typically only supports features if they're actually part of the JSDoc spec.

@not-an-aardvark Thanks! Doesn't look like JSDoc supports it. (jsdoc3/jsdoc#1285) I'll be working on that end of it now.

Unfortunately, we can't include features that aren't supported by JSDoc itself. Doing so creates a lot of confusion and we would be forced to support every dialect that is tangentially related to JSDoc, which is untenable.
If JSDoc decides to support it, please comment back here so we can re-evaluate.

@nzakas I haven't heard anything from JSDoc yet. I'd like to close this for the time being so that it doesn't clutter up your open issues list.

Sounds good. Feel free to reopen later.

Looks like the consensus was to close this issue, so I'll do that.


Training for a smaller network input

I am downsizing the input image from 368 to 128 due to inference time limit, heatmaps will be 16x16 instead of 46x46, the results don't look good. Maybe I should tune sigma = 7 and n_sigma = 4 for the smaller input size?

Hi! You can infer the same network, which was trained with original 368 resolution. Pass --height-size 128 for the demo script. Training with smaller resolution might not result in good accuracy.

Hope, it helped.


Create function Context.get(socket, ...) to access the context

Is there a public API for accessing the context inside the update callback of a component?

Do you mean that, in the case of a sub component you want to see the context provided by the upper component?
I think the insight on components is that as you descend, each level only has access to anything explicitly passed down by the level above. ie there is no concept of a global variable that's available across all components.
Now, each component gets it's "assigns" trimmed as it gets called by a tier above. However, there is both explicit access to the assigns (through "prop" and "data"), but also an optional behaviour through "contexts". These seem to set sticky params in the assigns, which can then be (optionally) fished out and accessed in nested components
So I think in answer to your question, what you can see in the assigns is what you have access to. Context set by higher levels would be visible (I think). However, I'm unclear if you can alter them safely in a call back? But I guess reading them is acceptable?

Do you mean that, in the case of a sub component you want to see the context provided by the upper component?

Yes, you can do this of course in the template, but I was wondering if there is an API / plans to read it from the socket (i.e., assigns) in the update/2 callback of a component.
@msaraiva I could make a PR that adds an API to read the context from the socket assigns, but I'm not sure if this is something you'd like to have in the lib (maybe I'm missing the intended usage of Context)

Hi @dvic!
Sorry for the late response. I think we could have a Context.get(socket, ...). As far as I know, @olivermt is already using this approach in surface_bootstrap.  @lnr0626 do you think it's time to add this, even though we'll not be able to provide a Context.put(...)?

Yeah, that makes sense - not having the put api is reasonable, but a get would be useful

Cool, I'll try to cook up a PR for this.

@dvic Hi! Marlus  sent me here to comment and start a discussion :)
Question 1 is why is there a conclusion about not having put in that issue? I don't get it.
Then to follow up from that I feel that we should take this one step further than just adding some functions, especially I think we should have a proper discussion on what we want Context to be and make some decisions before we expose a public API that will lock in what is possible.
I have some thoughts and deliberations and I feel that we need to cover them before we revisit your PR.

The way context currently work is already not very friendly to re-rendering decisions etc so anything we officially do around Context should probably be related to making the usage more declarative and probably exposed through a data prop or similar
The Process seems to have become the stable vehicle for liveviews and we can probably expect that a liveivew is always one to two processes (the dead first, then the live on ws connect or live redirect).
Due to process being a stable vehicle, a context could possibly be rooted in the pdict instead of a macroed "pass it down the pipe" approach. This gives true prop drilling.
To support using the pdict and also support the rendering engine actually understanding whats up, we need to have some strong guard rails around how you use a context value and how to let the context provider know that a value was actually used (so we can signal re-rendering down the tree)

From all this, I propose that we expand the data prop with a provider configuration. The reason I am saying provider is that it is also extensible to more things later. If we now expand with provider: :context we can later do something like provider: {:pub_sub, "some-topic"} or provider: &my_dataloading_fun/2 where socket is passed as first arg.
Another reason to do this is to lift the Context plumbing out of the "unofficial" assigns and into a proper prop. If Context.put puts a context assign in the pdict of the liveview, any child component be it stateful or stateless can Context.get and grab it out of the pdict.
Now this is where the framework aspect comes into play and why I want a declarative prop. This means that any component that uses a dataprop with that provider can be tracked by the compiler so that we can enforce re-renders down the tree of modules that has used a given context provided data prop.
This last part is where I need people with bigger macro / framework brains than I have to give their five cent. I think we might be skirting close to some framework magic that everyone tried to escape in Rails by going to the more explicit and declarative Elixir, but I still think this is cleaner than trying to sidestep the whole assigns internal thing going on in LiveView with some spaghetti context internal assign.
Some open questions on my end is:

Can we given a module name (like Foo.BarComponent) that has used a context prop hook it in any way to either re-render or kick off its update/2 cycle? This is probably very achievable with stateful components just delegating down to send_update, but I am not sure how to solve this with stateless components, as I am not quite sure what their lifecycle is at all internally in Surface/LiveView.
Is this really a better solution than passing __context__ everywhere? The questions we need to solve around being declarative and making sure that change tracking and needless re-rendering (as in we need to expose an actual @variable so that the leex engine can state diff) are the same regardless of the vehicle we use to push context down. Forms rely on context being unique in each Context branch, so we need to solve that somehow if we go the liveview pdict route, so maybe nested macro assign context is better either way?

Looking forward to discussion :)

We should pay attention to this live_view issue, as it plays into this context discussion a bit for non change tracked context: https://github.com/phoenixframework/phoenix_live_view/issues/1386
As much as I like the pdict idea, ( have tried it myself). We should avoid it as part of the core - as its a path that will be hard to back out of. If storing data in the pdict is exposed via some opt in plugin system or context provider idea as proposed it would be OK

I have also decided that I would like to backtrack the pdict idea.
80% of my post still stands nicely in terms of exposing declarative props etc if we base it on macro based assigns propagation of a 'hidden' assign though.

why is there a conclusion about not having put in that issue?

the tldr is because of how context is handled currently providing a put is non trivial - while it's potentially feasible, the ways that come to mind would be even less friendly to change tracking than what we currently allow :-(

We should pay attention to this live_view issue ...

That's an interesting concept - I guess the idea would be to use whatever solution they have to store the surface data (that shouldn't be change-tracked) like __context__, and create assigns when specific pieces of it are accessed that would be changed-tracked correctly
We may still have some issues around slots - iirc implementing context so that it can be propagated to slot content does not play nicely with change-tracking; though it's been a long time since I've been in that area of the code and it's feasible live view has improved since then

given a module name (like Foo.BarComponent) that has used a context prop, can we hook it in any way to either re-render or kick off its update/2 cycle? ...

My understanding is that stateless components are re-rendered based on when the stateful thing (live view/stateful live component) that they are embedded in is re-rendered. I also believe that in the stateful component case, we need the component id as well as the module name; though I don't know for sure and I'm happy to be proven wrong :-)

Another reason to do this is to lift the Context plumbing out of the "unofficial" assigns and into a proper prop

A long while ago, we had something close to this. Instead of a data prop, there was a context macro and an init_context method that had to return the values for context props. We decided to re-implement it as a component with some compiler support. One of the interesting capabilities with our current implementation is the ability to have multiple different context trees within the same component - though I'm unsure if that's actually used anywhere

From all this, I propose that we expand the data prop with a provider configuration

This is an intriguing idea, and allows some interesting ideas like you hinted at with other providers (and potentially allows library authors/users to create their own providers). I think we'd quickly run into the question of how to handle initialization order (currently prop and data ordering doesn't have any meaning to surface itself, but once we allow automatically initializing values it would potentially matter).

The questions we need to solve around being declarative and making sure that change tracking and needless re-rendering (as in we need to expose an actual @variable so that the leex engine can state diff)

It would be nice to also address the issue underlying #267 as well - it's not immediately obvious that rendering a component inline and calling a function to render the same component have different results if the context is being used; and even when you know that, there's not really a satisfactory reason (at least to me) :-(

@olivermt Thanks for starting the discussion!
I'm not so familiar with the code base but after reading the responses above I do have a better intuition of the current limitations and what the possible directions are, so thanks for that!
If I would have to summarize the above macro-based approach, would that be something like:
defmodule MyComponent do
  context MyContext, :foo

  @impl
  def update(assigns, socket) do
    socket = assign(socket, assigns)

    foo = get_context(MyContext, :foo)

    {:ok, socket}
  end
end

where get_context is a macro that generates code that fails at compile-time if the context attribute is missing for that key and if it's not missing generates Map.fetch!(socket.assigns.__context_, {MyContext, :foo}) (or something like that).

Next version of LV will ship with some new features that might allow us to implement a better solution for contexts. If that turns out to be true, we might rethink the way we handle context assigns and maybe come up with a better API that maybe doesn't need this function.
I'm closing this for now. We can re-open it later if we think it can still be useful.

When this feature is thought through in the future, I'd like to show one more use-case that I think should be considered:
https://github.com/jshmrtn/hygeia/blob/f5c578981251ec9245a98b88ee972e4d9ed57e8a/apps/hygeia_web/lib/hygeia_web/live_view.ex#L74
Our own LiveView module extends on Phoenix.LiveLive & Surface.LiveView. Its job is to inject some global values into the context. Those are:

auth (user etc.)
logged_in (convenience instead of checking is_nil(auth)
browser_features (relayed modernizr flags to detect support of browser features like date inputs)
ip_address (request IP)
uri (request URI; used to show active link in navigations)
params (path params for current URL; used to show active link in navigations)

Since we didn't want to repeat a <Context put={...}> in every component, we inject those directly into the assigns at mount / handle_params.
I'm not sure if this is the nicest solution, but if a feature is planned to replace contexts, I'd like to consider a use case like this as well.

PS @msaraiva: What new LiveView feature are you referring to? live_session?

@maennchen From what I have seen on Twitter, it seems that Phoenix Live View will introduce "hooks" or "callbacks" to, hopefully, perform some manipulations before and after mount and update functions.
I implemented in #336 a first try of a plugin system that is pretty close to what you have done with Hygeia. We also closed this PR waiting for more info from LiveView.

@Malian I switched to using the new Phoenix LiveVIew Hooks in Hygeia. I however still see the need for a Contact.put function.
For reference:

My Context.put: https://github.com/jshmrtn/hygeia/blob/e8c6c5bd8774dbe61fa2397e1386d06f9f233530/apps/hygeia_web/lib/hygeia_web.ex#L205
Usage Example: https://github.com/jshmrtn/hygeia/blob/e8c6c5bd8774dbe61fa2397e1386d06f9f233530/apps/hygeia_web/lib/hygeia_web/live/init/context.ex#L38

Would you be interested in a PR that exposes this directly on the surface Context module?

Would you be interested in a PR that exposes this directly on the surface Context module?

@maennchen I like it! However, I wonder: does it also work when you have a component that only accesses the context from mount/update? Does surface currently always pass the __context__ assign? I believe I encountered this issue previously, where the __context__ assign would only be passed when I used <Context> in the component template.

@dvic I've used this everywhere in our application. Both through the component and also reading from the socket. I never encountered any problems with it so far.

Both through the component and also reading from the socket. I never encountered any problems with it so far.

@maennchen Yes when you have both it works, but do you also have an example of a component that only reads it using context_get (i.e., from the socket) and does not have <Context> in the template?
I expect this not to work for that component because it does not have the __context__ assign passed, because Surface optimizes this away (unless the implementation changes since the last time I checked).

@dvic This example should definitely be refactored, but it currently exclusively reads directly from the context:
https://github.com/jshmrtn/hygeia/blob/1481ccedf8b00889113eaf8fd9227026551219ad/apps/hygeia_web/lib/hygeia_web/live/record_view.ex#L57

@maennchen I just checked with an example repo and in my case it doesn't work. If you remove the <Context> line, the __context__ assign is empty inside the update/2 callback, just as I expected. I'm not sure why the context is working in your RecordView component though.

@dvic I think the update is only called with changes. Could it be that you didn't merge the current assigns and the updated ones to check?
(I have not checked how context actually works, I just assumed it's working like a normal assign...)

@maennchen As far as I know the update/2 callback is also called on first render (see LiveComponent lifecycle docs) and I do assign the assigns, on line 50. I also see the context being present in the assigns argument in update/2 just as long as I have the <Context get...> line in the template 🙂.
This is something that has bitten me previously, that's why I proposed a declarative macro as a second option to "signal" to the surface compiler that a component is dependent on some context. But I'm not sure what the current plans are for the context feature of surface.

By the way: it kind of makes sense that Surface does this, otherwise LiveView would have to re-render the whole component tree anytime something changes in a context (because all components would be dependent on the whole context). Instead, surface only passes the necessary context keys to each component, and it does this currently based on the <Context get={}> presence in the templates.

@dvic I see. Then I somehow got lucky here...

does it also work when you have a component that only accesses the context from mount/update? Does surface currently always pass the __context__ assign? I believe I encountered this issue previously, where the __context__ assign would only be passed when I used <Context> in the component template.

@dvic you're correct. In order to optimize the data sent, Surface only passes the __context__ assign when it detects the context will be used.  In order to do that, Surface follows a few rules, one of them is to check the :gets_context? and :changes_context? module attributes. That means is we want to add Context.put and Context.get, they'll have to be macros so we would have a chance to set those values at compile-time. Like we do here: https://github.com/surface-ui/surface/blob/c33bb3abbb92315585ccde7a58c342d548c01e36/lib/surface/compiler/eex_engine.ex#L965-L971
One of the reasons I want to postpone implementing this feature is because as we're currently implementing slots as a core feature in LV, there's a big chance we'll be able to fix the main issue, which is using variables in slots. If that happens, we'll able to remove all that optimiztion logic from our side, allowing us to rethink contexts and maybe come up with a better API.
BTW, I can see you found an issue with that logic and reported https://github.com/surface-ui/surface/issues/493. I still have to check that.

Thanks for the explanation and pointers @msaraiva! I guess it's best to wait then for the slot feature to land in LV, curious to see what it will bring us 🙂

BTW, I can see you found an issue with that logic and reported #493. I still have to check that.

Not sure if it's exactly related to this, but it is definitely a compiler bug as I just encountered the issue also on the reproduction repo (now the repo is on 0.5.x and everything is fine).
By the way: do you happen to know how is it possible that Mix is okay with me having LiveView 0.16 while Surface is on 0.5.x, which requires LiveView 0.15? I was expecting to have to do override: true for the LiveView dependency.

@dvic Surface is also compatible with LV v0.16. In fact, it's even recommended to use it as there's a bug in LV's diff tracker regarding using nested slots that has only been fixed in v0.16.

@dvic Surface is also compatible with LV v0.16. In fact, it's even recommended to use it as there's a bug in LV's diff tracker regarding using nested slots that has only been fixed in v0.16.

Didn't know that, thanks!

Now that slots are implemented in LiveView, is this feature now in view?

Hi @kingdomcoding!
Yes, the context API is being currently reviewed and should include a Context.get(...) function in future versions.

For those interested: this has now been implemented in #641


Bluetooth: rename Kconfig.iso

Some git systems employ hooks to prevent binary files from being committed accidentally.  The Kconfig.iso file, which contains Kconfig flags related to isochronous operation, causes the file-extension based binary detection hooks to falsely detect this is a binary file and reject pushes.
Rename Kconfig.iso toKconfig.isoc to avoid this issue in forks of zephyr.

I suppose this is fine. The one concern I have is that this is not the conventional short form, and e.g. all the Kconfig symbols in that file have a BT_ISO_* prefix. I fear that someone will at some point in the future forget about the reasoning for this change and rename the file back to Kconfig.iso in the name of consistency.

I suppose this is fine. The one concern I have is that this is not the conventional short form, and e.g. all the Kconfig symbols in that file have a BT_ISO_* prefix. I fear that someone will at some point in the future forget about the reasoning for this change and rename the file back to Kconfig.iso in the name of consistency.

Fair point - I took the easy path as this was only a two file change but changing the config flags would be more impactful.  Let me know if you'd like me to change the extension and/or config flags to align.

@quic-egmc Can you elaborate on what hooks may have an issue with .iso?
The naming convention of Kconfig.<feature> is something that we use quite a lot in LE Audio for example (see the Kconfig files in https://github.com/zephyrproject-rtos/zephyr/tree/main/subsys/bluetooth/audio), and if this is a generic issue, then we may want to simply rename the Kconfig files to e.g. Kconfig_<feature> instead.

@quic-egmc do you plan to return to this PR?

Sorry for neglecting the PR...

Can you elaborate on what hooks may have an issue with .iso?

This was a tool that was being "helpful" by trying to prevent binaries from being added to git repos.  AFAIK only this file was problematic in this regard.

@Thalley (fyi @MaureenHelm ) Sorry for neglecting the PR...

Can you elaborate on what hooks may have an issue with .iso?

This was a tool that was being "helpful" by trying to prevent binaries from being added to git repos. AFAIK only this file was problematic in this regard.

I see, that makes sense given the history of the .iso file extension.
I don't think we are planning to rename to isoc as that is not a common abbreviation for isochronous channels.
If we do decide to rename it to e.g. Kconfig_iso instead to avoid such file name extension issues, then we should do that across all of course Kconfig files, which would require additional input from others.
@alwa-nordic @jhedberg as maintainers of the BT subsystem, what are your thoughts on this? Any suggestions for solutions?

If we do decide to rename it to e.g. Kconfig_iso instead to avoid such file name extension issues, then we should do that across all of course Kconfig files, which would require additional input from others.
@alwa-nordic @jhedberg as maintainers of the BT subsystem, what are your thoughts on this? Any suggestions for solutions?

I agree with you. This is an issue for the Kconfig subsystem maintainers to address. I.e. The issue to be addressed is that users of Zephyr may have tools that confuse filename extensions with Kconfig-files having a 'Kconfig.' prefix and no filename extension.
I think we should not break pattern with the rest of the project. I suspect that we have tools that look for the pattern 'Kconfig.' in filenames.
We cannot on a general basis accommodate everyone's downstream linters. (Especially regarding false positives.) But I encourage the Kconfig maintainers to consider that filename extensions are a useful de-facto standard and look at the possibility of giving Kconfig files an extension.
I could go for renaming our Kconfigs to have fuller paths 'Kconfig.bt_iso'. That's anyway nice and fixes the problem in this particular case.

I could go for renaming our Kconfigs to have fuller paths 'Kconfig.bt_iso'. That's anyway nice and fixes the problem in this particular case.

That is a good idea. The bt_ extension prefix will be a nice generic solution, and can even be applied to https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/Kconfig to be Kconfig.bt
If we decide to rename, I'd be in favor of this approach.

I could go for renaming our Kconfigs to have fuller paths 'Kconfig.bt_iso'. That's anyway nice and fixes the problem in this particular case.

That is a good idea. The bt_ extension prefix will be a nice generic solution, and can even be applied to https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/Kconfig to be Kconfig.bt
If we decide to rename, I'd be in favor of this approach.
@quic-egmc Can you verify that Kconfig.bt_iso would not be an issue for your system?

Somehow I missed this thread long ago - no issue here.

@alwa-nordic @jori-nordic Should we go ahead and add the bt_ prefix to the extension of Kconfig files in BT? Maybe omit it for https://github.com/zephyrproject-rtos/zephyr/blob/main/subsys/bluetooth/Kconfig since it's extensionless

Replacing the . with a _ should also work fine, and might be a better alternative, since . usually indicates a file extension, which is not the case here.

This might actually be the better approach, given that . usually indicates a file extension, which isn't the case here.

@quic-egmc I'd be ok with approving this PR if you modify it to Kconfig_iso, as I think that would be the ideal direction to to with the Kconfig files with named extensions.

Reopening PR, we're finally getting around to addressing this.  Better late than never I guess?
Also adding @jonathonpenix who was willing to take this over the finish line, thanks!

@quic-egmc do you plan to return to this PR?

Yes but only about a year later.  :)


Fix missing variable error msg when importing library / variable in --dryrun mode

Here's a minimal example to reproduce this issue.
example.zip
run command robot --dryrun example/
Before fix:
there will be the error msg raise:
[ ERROR ] Error in file '/example/test.robot' on line 2: Variable '${module}' not found.
[ ERROR ] Error in file '/example/test.robot' on line 3: Replacing variables from setting 'Variables' failed: Variable '${var}' not found.
After fix:
there will not error msg
Because in many cases we will set the variables dynamically and in --dryrun mode, robot does not parsing the variables, and we do not expect to see these kind of errors.

I'm actually not sure is this a good idea at least with libraries and resource files. If importing them fails, keywords they contain won't be found and there will be failures also in dry run. The error about failed import makes it easier to understand them. This could be safely done with variable files, though, because we don't anyway look at variables in dry-run. I'm not sure is that worth the effort though.
If we agree to do this change, this PR would need to have tests and an issue tracking it should be submitted as well.

No comments since September. Closing.


Update crossbeam-deque to 0.7

I also have this branch ready: https://github.com/rayon-rs/rayon/compare/master...cuviper:crossbeam-deque-0.7
But we don't want to make this change until allowed by our minimum rustc policy in RFC 3, for at least one year of Rust support. crossbeam-deque 0.7 requires Rust 1.28 (2018-08-02).

Oh, did that because I couldn't find any open PR with it. I'll close mine then and wait for august.


BackgroundService enhancements

Fixes #15701
Set of updates seeking to:

Generally improve layout and coverage (e.g., bullets to paragraphs, xref API cross-links).
Surface that either ExecuteAsync must complete or yield for StartupAsync to complete. Trying to minimally capture the main point in BackgroundService blocked the execution of whole host (aspnet/Extensions #2149) and cross-link the engineering issue for the reader's further understanding.

❓ ... do you want it to specifically call out await Task.Yield() for the top of ExecuteAsync for scenarios where StartupAsync will be blocking? ... or should we let the cross-linked engineering issue capture that concept for the reader if they need to dig deeper? ... or even just wait until the engineering issue is addressed further for a future release?
❓ If we do call out await Task.Yield(), what do you want to say about 'an additional state machine is created (one per service)'? For example, do you want to surface any negative side effects?
EDIT ... and another ❓ ... do you want us to react to #14156 here as well, or save that for another day? 🏃😅
I'll add a note to the sample update tracking issue to check to see if this section should be modified and the cross-link pulled at some future release. EDIT ... Done!
cc: @bobbydog - thanks for opening the issue.

@Tratcher to review

Try it now ... it's updated from your guidance.
WRT ...

and ExecuteAsync should finish promptly.

... I made it say (in order to make it condition of token firing) ...

and ExecuteAsync finishes.

Try it now ... it's updated from your guidance.
WRT ...

and ExecuteAsync should finish promptly.

... I made it say (in order to make it condition of token firing) ...

and ExecuteAsync finishes.

I was trying to convey that the implementer of ExecuteAsync needs to react to the cancellation token in order to shut down, the host can't do that for them.

I see what you mean. It seems to be covered in the IHostedService interface section under StopAsync.
I changed it to ...

The cancellation token is triggered when [IHostedService.StopAsync](xref:Microsoft.Extensions.Hosting.IHostedService.StopAsync*) is called. `ExecuteAsync` finishes promptly either gracefully or ungracefully at the shutdown timeout.

@Tratcher Try it now.
In the IHostedService interface section, it calls out explicitly that the "background operations ... should be aborted" in ExecuteAsync.
This paragraph now reads ...

The cancellation token is triggered when [IHostedService.StopAsync](xref:Microsoft.Extensions.Hosting.IHostedService.StopAsync*) is called. Your implementation of `ExecuteAsync` should finish promptly when the cancellation token is fired in order to gracefully shut down the service. Otherwise, the service ungracefully shuts down at the shutdown timeout. For more information, see the [IHostedService interface](#ihostedservice-interface) section.


Can we support Apache Spark?

Hello, I wonder whether this plugin may support Apache Spark? And if not, what is blocking us?
Any hints are welcome, thank you very much!

Hi @zeninpalm, are you referring to something specific? This plugin does support Apache Spark clusters via the thrift connection method; those clusters can be hosted locally, on Amazon EMR, ...; while there is some functionality only available to users of Delta Lake / Databricks, we try to call that out explicitly in the codebase and documentation.

Thank you @jtcohen6 I asked this question because README didn't mention Apache Spark explicitly. Now I may try integrating this great plugin into my pipeline, thanks again!


gtk_window_set_accept_focus behaves a little weird.

Not sure if this is a bug or it is supposed to be like this.
When a GTK2 window is set by gtk_window_set_accept_focus to not, the input focus sure is not in the GTK2 window but previous window. But the color of the titlebar looks like the GTK2 window has focus.

JWM will allow a window to be focused if either WM_TAKE_FOCUS is set in WM_PROTOCOLS or the input flag is set in WM_HINTS.  In the case of WM_TAKE_FOCUS, the window manager is not supposed to give focus to the window directly, but instead send a message to the window to do something with the focus (set it to itself or some other window).  JWM still pretends to give the window focus because in this case since the window presumably wants to do something with the focus.
I’m not exactly sure whatgtk_window_set_accept_focus does without some more digging, but I would guess it sets the input flag in WM_HINTS.  Perhaps WM_TAKE_FOCUS is set?


Improve (hopefully) how HybridGibbs uses samplers state and history

Closes #483.
This PR makes it such that HybridGibbs will extract each of its samplers state and history, then reinitialize the sampler with a new target, then set the sampler state and history from earlier.
This reason we have to do this is because changing .target will not always correctly set all internal variables of the samplers that depend on the target.
Suggestion for review if method works
Use CWMH and compare with HybridGibbs using MH. Are the results similar? Test both warmup and sampling.

The MH sampler did not append to self._acc, and therefore self._acc stayed at the initial value 1, which meant that the tune method increased the step length to the maximum (i.e. 1). I have pushed a small change that fixes this.
In line 220 of cuqi/experimental/mcmc/_gibbs, the skip_len of the tune method is hardcoded to 1, meaning that the tuning of the scale parameter is always based on only the latest self._acc, i.e. either 0 or 1. This is not sensible for tuning. I suggest either using skip_len = max(int(0.1 * Nb), 1) which is the default in the warmup method in cuqi/experimental/mcmc/_sampler. Or letting it be user defined, again similar to the implementation in the warmup method in cuqi/experimental/mcmc/_sampler.

The MH sampler did not append to self._acc, and therefore self._acc stayed at the initial value 1, which meant that the tune method increased the step length to the maximum (i.e. 1). I have pushed a small change that fixes this.
In line 220 of cuqi/experimental/mcmc/_gibbs, the skip_len of the tune method is hardcoded to 1, meaning that the tuning of the scale parameter is always based on only the latest self._acc, i.e. either 0 or 1. This is not sensible for tuning. I suggest either using skip_len = max(int(0.1 * Nb), 1) which is the default in the warmup method in cuqi/experimental/mcmc/_sampler. Or letting it be user defined, again similar to the implementation in the warmup method in cuqi/experimental/mcmc/_sampler.

I fixed an issue concerning how I first implemented appendence to self._acc. Now implemented in HybridGibbs instead of MH so it is also compatible with regular sampling (non-Gibbs), which already has  appendence to self._acc implemented.
I have added the option of setting the tune_freq for HybridGibbs sampling, so it is no longer hard-coded. The implementation is equivalent to tune_freq in cuqi/experimental/mcmc/_sampler.
I have no further comments or concerns related to storing and using the acceptance rate in HybridGibbs :)


Port facebook workload to WA3

FTR, I'm working on this in the facebook branch of JaviMerino/workload-automation.


Add block list

From user safety perspective, we should consider whether to hide messages made by the person blocking from the person being blocked. Right now:

Blocker cannot see / join blockee's games
Blockee cannot see / join blocker's games
Blocker cannot see blockee's messages
Blockee can see blocker's messages

The game joining is the most important, so I think this PR gets that right. The messages portion right now functions like "I don't want to see this person", not "I don't want this person to see me". On social media sites blocking often functions as both, with the blocker sometimes being able to click and see blockee's messages in case they need to report it for further moderation (e.g. blockee is posting address / phone number of blocker to encourage harassment). I can see situations where the blocker is in lobby chat, the blockee sees their message and goes on a toxic tirade about them, which the blocker does not know about.
It may not matter much in this case, since we don't have things like notifications when a user mentions you, or direct messaging, and the lobby is highly visible in case we need to ban an especially abusive user, but it's something to consider.

I've addressed the comments but as discussed the performance hit of doing the reverse block list checking puts me off doing it for now.  It's a valid point and I do think we should do it at some point, but maybe as a 'v2'


Kulfy: Watch dutcotennant.com

Kulfy requests the watch of the watch_keyword dutcotennant\.com. See the MS search here and the Stack Exchange search here.

dutcotennant\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by double-beep in Charcoal HQ


POC Authentication Extension to GitHub application

Overview
The oauth2 extension only supports Client Credentials Flow for OAuth. GitHub only supports User Flow and Device Flow, both of which require a generation of a Token, a call, and a return with the token to be able to authenticate. While it's completely plausible to use something like this GitHub K8s feature to pro-grammatically create token's on the fly, this type of solution would only be a fix for those running in kubernetes with extensive support. PLus it's an undocumented feature. Creating a new Oauth2 extension for GitHub, and either a) contributing it upstream or b) taking the functionality and putting it in the oauth2 extension upstream, as a wider impact and wider area of support.
The goal of this is to prototype an extension to leverage within the Liatrio collector and figure out the ancillary points later.
### Tasks
- [ ] Document the commit for the extension boilerplate so we can reference later for compgen

Extension Requirements for CompGen
There are multiple types of extensions. In the case of this ticket, the type of extension I built was an authentication based extension. The general flow is create an extension component which returns the auth client that any other component will leverage.
The general documentation I leveraged was found here on  opentelemetry.io. In the case of this extension, I pretty much copied the oauth2 extension for the structure after reading the documentation. This was because the type of authentication I was going to do is oauth2 3 legged flow. The initial commit of the structure I went with, without tests, can be found here.
It was really simple tbh. The main complication I ran into was figuring out how to return the correct transport to the client as a component. The comments in the linked pull request document my findings. I think this should suffice on a set of documentation as this would be pretty easily repeatable.
This is not the only type of extension, so if this was added to compgen we would want to designate this as type auth.


implemented title alignment

Hello,
the following code should close issue #450
i appreciate any feedback on my code.
Keep up the awesome work! I really like working with tui-rs myself.
Best of regards
Yours
Andreas

Sorry, I haven't had a lot of time to work on tui lately and I'm just getting up to date with recent notifications. I believe #462 has a bit superseded your own contribution. I'm therefore going to close this PR but feel free to review/comment the other PR if you have feedback on the implementation.


dtype of regridded cube changes after realizing the data

🐛 Bug Report

After regridding a cube with dtype=float32 using regrid_unstructured_to_rectilinear and realizing the data the output cube's dtype is float64. If the data is saved and re-loaded before realizing the data, the dtype does not change.
How To Reproduce
import numpy as np

import iris
from iris.coords import DimCoord
from iris.cube import Cube
from iris.experimental.ugrid import PARSE_UGRID_ON_LOAD

import esmf_regrid
from esmf_regrid.experimental.unstructured_scheme import regrid_unstructured_to_rectilinear

print("iris version:", iris.__version__)
print("iris-esmf-regrid version:", esmf_regrid.__version__)

path = iris.sample_data_path('mesh_C4_synthetic_float.nc')
with PARSE_UGRID_ON_LOAD.context():
    cube = iris.load_cube(path)
    print("dtype input cube:", cube.dtype)

lat = DimCoord([10, 20, 30], standard_name='latitude', units='degrees_north')
lon = DimCoord([10, 20, 30], standard_name='longitude', units='degrees_east')
lat.guess_bounds()
lon.guess_bounds()
target = Cube(np.ones((3, 3)), dim_coords_and_dims=[(lat, 0), (lon, 1)])

regridded_cube = regrid_unstructured_to_rectilinear(cube, target)
print("dtype regridded cube before cube.data:", regridded_cube.dtype)

# If the following lines are added, the dtype is still float32 after realizing
# the data
# from pathlib import Path
# x = Path.home() / 'test.nc'
# iris.save(regridded_cube, x)
# regridded_cube = iris.load_cube(x)

regridded_cube.data
print("dtype regridded cube after cube.data:", regridded_cube.dtype)

prints
iris version: 3.4.0
iris-esmf-regrid version: 0.5.0
dtype input cube: float32
dtype regridded cube before cube.data: float32
dtype regridded cube after cube.data: float64

Expected behaviour

The dtype should be float32 for the regridding cube even after realizing the data.
Environment

OS and version: Red Hat Enterprise Linux 8.5 (Ootpa)
esmf_regrid version: 0.5.0

Thanks @schlunma for raising this.
@stephenworsley is on the case and will dip into this asap, cheers :+1:

still relevant

still relevant


Trying the trigger and getting an error

I'm getting this error  Failed to compose trigger parameter value for table: 'dispatch due to exception: Newtonsoft.Json.JsonReaderException. Exception message: Could not convert string to integer: AAAAABGrxfo=. Path 'ut', line 1, position 355.         Dispatch is the name of my table
I know the change tracking table is working because I'm able to see the changes using this query

declare @last_synchronization_version bigint;  /sync version look at last query/
DECLARE @PhotoColumnId int = COLUMNPROPERTY(OBJECT_ID('dbo.dispatch'),'status', 'ColumnId');   /looking dispatch status change/
select @PhotoColumnId, object_id('dbo.dispatch'), @last_synchronization_version
SELECT
CT.Id, P.Billto, CT.*,P.status, -- Always obtain values.
CASE
WHEN CHANGE_TRACKING_IS_COLUMN_IN_MASK(
@PhotoColumnId, CT.SYS_CHANGE_COLUMNS) = 1
THEN status
ELSE NULL
END AS CT_ThumbNailPhoto,
CHANGE_TRACKING_IS_COLUMN_IN_MASK(
@PhotoColumnId, CT.SYS_CHANGE_COLUMNS) AS
CT_ThumbNailPhoto_Changed,
CT.SYS_CHANGE_OPERATION, CT.SYS_CHANGE_COLUMNS,
CT.SYS_CHANGE_CONTEXT
FROM
dispatch AS P
INNER JOIN
CHANGETABLE(CHANGES dispatch, @last_synchronization_version) AS CT
ON
P.Id = CT.Id AND
CT.SYS_CHANGE_OPERATION = 'U';

We have an api that hits the database table using C#. I'm looking for the exact piece of code that changes the "status"
The status being changed is what I'm looking for. In my query above I was just making sure that the change tracking is turned on for the table and the columns.   (it is one of the queries in the microsoft docs on change tracking )  I have attached my table schema dispatch and I don't see any binaries fields.  )  I have no idea where it is getting binary types.
dispatch.zip

Hi @dkboon01, I am unable to understand how the function is setup on your end. It would be far easier for us to help you of you can share a minimal function and a minimal table schema that would let us reproduce the same error that you are getting.

I'm trying to create a new project to send to you.    In the new project, I have added the nuget package through the nuget package manager but it keeps complaining that the attributes like SQLChange , SQLTrigger are not found to compile.  Is there something in vs 2022 setup that would prevent it from using the preview package? When I try to build the project the same error messages occur.

SqlTrigger functionality is currently not in the public package yet - we'll be adding it to that soon so keep an eye out for that!

Thank you Charles-Gagnon that worked for me.  One last question, we have a home grown ORM system that usually brings in the table class definition.  Does the SQL trigger have to use entity framework?   I have always used EF or Dapper so what I did to get rid of the binary error was to create a class definition of dispatch using entity framework core and now it works. My next step is to leave the class dispatch the way it is and take away the EF packages that I had to add to generate the dispatch class using dotnet ef from commandline.  But before I break it again I was wondering if EF is a requirement.

There is no EF requirement - you can use whatever you want to generate the class definitions.
Are you still seeing the original error you mentioned or has that gone away?

When I generate the class for dispatch table using EF everything works.  However, I tried to use a class generated by our custom ORM and it does not work.  I will have to be work on this in more detail. For now, i will just use the EF class generation.  Should I be able to have two output bindings on the SQLTrigger?  Like this
[SqlTrigger("Dispatch",ConnectionStringSetting ="SqlTestConnectionString")]
IReadOnlyList<SqlChange> changes,
[SignalR(HubName = "ABCHub")]  IAsyncCollector signalRMessages,
ILogger logger

So I figured out the issue with the getting the json error above.   The issue is this:   We have a column in the table that is defined as timestamp the name of the column is ut.   When I do a dotnet scaffold using EF, the class it generates for this table makes this column a byte[] with ut as the column.  However, our ORM custom system is not adding this column at all on the generated class.
The only question I have outstanding is about adding a SignalR output binding to the SQLTrigger.  In the above comment, should this work? It would be nice that once I encounter the change of status that i could notify the UI via SignalR of the change.

Yup, that should work fine! It's a very common scenario to have a function with multiple bindings like that. In fact nearly all of our samples have an HttpTrigger with a SQL Input or Output binding : https://github.com/Azure/azure-functions-sql-extension/blob/main/samples/samples-csharp/OutputBindingSamples/AddProduct.cs

@dkboon01 Is there any issues you're still having or can we close this?

Yes, please close. Is there any update on when this will be released out of preview? I would like to use this in a production environment soon.

The trigger binding is still is private preview right now.
We'll be releasing it into public preview here this month.
GA date for the extension is TBD, but will be next year some time.


How can I use the browser to access the UDS to VDI

Hi @dkmstr ,

Created a user
Created the Servcie and Service Pool
Created two VDI in ovirt
Created a Tunneler by building the Guacamole project in OpenUDS and exposed the url as http://{SAME_IP_ADDRESSS_AS_UDS_SERVER}:8080/transport/
NOTE: If I run this, It is returning a black screen, Is that transport.war is just enough?  I see the real implementation of Apache Guacamole and they have few property file where they have the details about the configuration of the remote machine it is trying to connect.

Installed the UDS Actor and stuck as per the issue: https://github.com/dkmstr/openuds/issues/33

I installed the uds client plugin in my local

Created a HTML5 RDP transport using the tunneler IP (NOTE : In my case I deployed the transport.war in the same node as UDS server) and assigned this to the service pool

NOW when I click on the service in the user mode It ends up with error,

When I see in the Tomcat logs, I see the following error in catalina.out in Tomcat
==> catalina.out <==
15-Nov-2018 01:28:54.863 SEVERE [http-nio-8080-exec-5] org.slf4j.impl.JCLLoggerAdapter.error Creation of WebSocket tunnel to guacd failed: The UDS base URI is not defined.
15-Nov-2018 01:28:54.921 SEVERE [http-nio-8080-exec-4] org.slf4j.impl.JCLLoggerAdapter.error HTTP tunnel request failed: The UDS base URI is not defined.
15-Nov-2018 01:29:10.041 SEVERE [http-nio-8080-exec-2] org.slf4j.impl.JCLLoggerAdapter.error Creation of WebSocket tunnel to guacd failed: The UDS base URI is not defined.
15-Nov-2018 01:29:10.096 SEVERE [http-nio-8080-exec-3] org.slf4j.impl.JCLLoggerAdapter.error HTTP tunnel request failed: The UDS base URI is not defined.
15-Nov-2018 01:29:25.235 SEVERE [http-nio-8080-exec-5] org.slf4j.impl.JCLLoggerAdapter.error Creation of WebSocket tunnel to guacd failed: The UDS base URI is not defined.
Also following error :
<IP_ADDRESS> - - [15/Nov/2018:01:40:22 +0530] "GET /transport/websocket-tunnel?data=tbc3c7p3mlat3sgvjmw2qv381sn8c2mhllt54mdl&exit=http://<IP_ADDRESS>:8090/&GUAC_WIDTH=2043&GUAC_HEIGHT=600&GUAC_DPI=96&GUAC_AUDIO=audio%2Fogg&GUAC_AUDIO=audio%2Fmp4&GUAC_AUDIO=audio%2Fmpeg&GUAC_AUDIO=audio%2Fwebm&GUAC_AUDIO=audio%2Fwav&GUAC_VIDEO=video%2Fogg&GUAC_VIDEO=video%2Fmp4&GUAC_VIDEO=video%2Fwebm HTTP/1.1" 101 -
<IP_ADDRESS> - - [15/Nov/2018:01:40:22 +0530] "POST /transport/tunnel?connect HTTP/1.1" 500 1038
So it is clear that the way I deploy the Tunneler is not correct, I just deployed the transport.war in tomcat and provided the http://<IP_ADDRESS>:8080 in the HTML5 RDP Tunnel URL,
Could you help me in deploying the Tunneler properly, Please provide the steps with the configuration file for it? Thanks

Hi @dkmstr,
I am able to confirm it, I deployed your open guacamole project in eclipse and it reads the uds.conf to get the BASEURI and it failed, so what is the base URI I need to provide here?
Please provide the same uds.conf
    /**
     * Returns the base URI of the OpenUDS service. All services providing data
     * to this Guacamole integration are hosted beneath this base URI.
     *
     * @return
     *     The base URI of the OpenUDS service.
     *
     * @throws GuacamoleException
     *     If the base URI of the OpenUDS service is not defined because the
     *     tunnel.properties file could not be parsed when the web application
     *     started.
     */
    public URI getUDSBaseURI() throws GuacamoleException {

        // Explicitly fail if the configuration was not successfully read
        if (udsBaseURI == null)
            throw new GuacamoleServerException("The UDS base URI is not defined.");

        return udsBaseURI;

    }

@dkmstr / @mike-jumper,
Could you please check this ?

Sorry, i have no time right now to review all your messages :(.
The code is provided as is, i can help you from time to time with some issue, but several people have installed it with no problem, so you should also.
I'll be out for a couple of weeks.
If you need running this, use the free version provided on "https://www.udsenterprise.com",

@dkmstr,
Sorry for the bug you. I appreciate your responses.
Could you please help me for this last one, please let me know the steps to install tunneler (using guacamole)?
Actually, I build transport.war and deployed in tomcat and pointed the IP and Port and it is scueessfully hitting to the tomcat transport, Do I need to configure any guacamole server as additional?


ios not asking for Permission

Hey,
on Android it is working perfectly, but i have the problem on ios, that the "Permission request" to enable the push notifications doesn't show up. So i can never enter the hasPermission function.

@MazzMazz please show me some code. Here is my guide on how to open an issue.
https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/ISSUES.md

Closing for inactivity


Bug: login redirect breaks publicpage

Since publicpages are rendered serverside, redirecting from /login?next=/yeoman breaks because it expects group to be prehydrated.

fix here: https://github.com/OpenCollective/opencollective-website/pull/357.


doc can not specify path

works
{{ doc: doc.ts }}

doesn't work:
{{ doc: ./src/doc.ts }}

yes it does. Just no spaces.
ex. (I use ()) (load:/path/to/partial) (doc:src/docs.ts))
Does this work?

yes it does. Just no spaces.
ex. (I use ()) (load:/path/to/partial) (doc:src/docs.ts))
Does this work?


cursor pointer need some love for disabled items

Hello there,
If there is pointer-events: none; for buttons we can't use tooltips on buttons :(
Here is an example http://codepen.io/flexbox/pen/ONVVwa

:+1:

Looks great, thanks


Switch the pre-commit hook used to run shfmt

🗣 Description
This pull request switches the pre-commit hook used to run shfmt from cisagov/pre-commit-shfmt to scop/pre-commit-shfmt. It also updates the arguments to shfmt to use the long options that are now available.

💭 Motivation and context
The new hook actually bundles the binary releases from shfmt into a Python package that is used for the hook. This removes the need to have the shfmt tool installed before you are able to use the hook.

🧪 Testing
Automated tests pass.

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

Excellent!  👍
Does this mean that we can now make https://github.com/cisagov/pre-commit-shfmt a public archive?

Yes that's the plan once this is merged.

Excellent!  👍
Does this mean that we can now make https://github.com/cisagov/pre-commit-shfmt a public archive?

Yes that's the plan once this is merged.

Great!  You should add that as a post-merge checklist item so that we don't forget about it.