Make CreateCommitObject Support Merge Commits

Make CreateCommitObject support merge commits, with multiple parent hashes
Changed other files to use an array of parent hashes instead of a single hash

PR #172 will have to be changed after this is merged.


How to add a new geocoder?

I've set up a copy of the script to post a random square kilometer of Denmark. The reverse geocoding for Denmark is very coarse, so I'd like to use a local API instead, to get a better resolution. Where in the code would be a good place to add this in a way that will make it suitable for addition?

So ærialbot is by default just using Twitter's own reverse geocoding API – the request is sent in the Tweeter.get_location function (line 696 as of 50ec0b3) which returns a tuple of (full_name, country). You could supposedly subclass the Tweeter class and reimplement Tweeter.get_location to query DAWA instead of Twitter, but it might be simpler to replace the function call in line 892 with your DAWA querying logic.
(And make sure to provide me with a link to your bot if you don't mind – I've spent many childhood  summers in Denmark, so I'm definitely interested!)

I've hacked something together, that seem to work. I'll play around with it a bit more, and see if I can generalize it to an option in the inifile that allows for selection between different geocoders. It's tweeting as https://twitter.com/DanskKvadrat Right now a square kilometer, but I think I might increase the area a bit, to avoid too much farmland.

Sounds good!

I might increase the area a bit, to avoid too much farmland.

Yeah, this was surprising to me too – it's even more farmland in the US. Out of the hundreds of test images I generated for @americasquared, only four or five were of (sub)urban areas.

Closing this issue since your bot has been up and running with your custom reverse geocoder for quite a while. 🙂


Support authentication control for zkclient

1.Add auth interface and implements.
2.Add the ACL control.

Closing this as out-of-date...


Jupyter Labs or Notebook  Function Error

ipychart throws a JS error, here is my setup and error:

Versions:

Python 3.9.6
jupyterlab               3.6.3
ipychart                 0.4.0
jupyter                  1.0.0
jupyterlab               3.6.3
notebook                 6.5.4
pip                      23.1

basic packages installed (separately tested)

pip install jupyterlab
pip install jupyter
pip install ipychart

jupyter notebook
jupyter-lab

dataset = {
  'labels': ['Data 1', 'Data 2', 'Data 3', 'Data 4',
             'Data 5', 'Data 6', 'Data 7', 'Data 8'],
  'datasets': [{'data': [14, 22, 36, 48, 60, 90, 28, 12]}]
}

mychart = Chart(data=dataset, kind='bar')
mychart

Error:

[Open Browser Console for more detailed log - Double click to close this message]
Model class 'ChartModel' from module 'ipychart' is loaded but can not be instantiated
TypeError: o._deserialize_state is not a function
    at u._make_model (http://localhost:8888/nbextensions/jupyter-js-widgets/extension.js?v=20230421165510:2:752635)

Jupyter Lab or Jupyter Notebook active extensions:

!jupyter nbextension list

Known nbextensions:
  config dir: /Users/jhernandez/Documents/Workspace/Lab/Parquet/venv/etc/jupyter/nbconfig
    notebook section
      ipychart/extension  enabled
      - Validating: OK
      jupyter-js-widgets/extension  enabled
      - Validating: OK

Not sure if this is a compatibility issue.

Hello @levihernandez, thanks for raising the issue. I'll investigate on this and try to fix it.

I'm not able to reproduce this issue, here is all the commands I ran:
$ conda create -n ipyc-issue-6python=3.9.6 ipykernel
$ conda activate ipyc-issue-6
$ pip install jupyterlab==3.6.3 notebook==6.5.4 jupyter==1.0.0 ipychart
$ python -m ipykernel install --user --name=ipyc-issue-6
$ jupyter notebook

Then I copied your code in a cell:
from ipychart import Chart

dataset = {
  'labels': ['Data 1', 'Data 2', 'Data 3', 'Data 4',
             'Data 5', 'Data 6', 'Data 7', 'Data 8'],
  'datasets': [{'data': [14, 22, 36, 48, 60, 90, 28, 12]}]
}

mychart = Chart(data=dataset, kind='bar')
mychart

And the chart is correctly displayed and I didn't see any error. Can you try to reproduce the error from a fresh new env using the commands above ?
Thanks

Closing since I cannot reproduce the issue.


Enable replacer-plugin config inheritance

the plugin is used in uberfire-extensions as well

Seems fine to me but let's wait for @manstis to confirm as he seemed to have needed it in this commit: https://github.com/uberfire/uberfire/commit/256b0682ffa5967bb2a66fdc0167d133f43d7c00

+1 to merge.

master: eb8466643456ab599c9eac0713358fca35c0367d


add zhangying

Application Form

@zhangying-dev  If you are having trouble learning about Starcoin, you can send me a private message by this way or discuss if in a development group.

Since the PR is not updated for too long, it is temporarily closed. If you want to continue to participate in Startrek, please apply again.


Random crashing happening on OSX 10.10.4 using mocha-phantomjs

Here is the package.json of the mocha-phantomjs which I'm on.
The tests seems to be executed properly, and at the very end it just crashes, like 1 from 10 with no trackable pattern from what I can see.
Not sure what would be the best place to file report, but crash says:

PhantomJS has crashed. Please read the crash reporting guide at https://github.com/ariya/phantomjs/wiki/Crash-Reporting and file a bug report at https://github.com/ariya/phantomjs/issues/new with the crash dump file attached: /tmp/1434FB42-60BF-40CD-BE5C-7C7BA3D6B2FD.dmp

So here I'm. Let me know If I need open one on mocha-phantomjs side too, and/or close this one.
Thank you in advance.
dump.zip

Please upgrade to PhantomJS 2. 1.9.x is no longer supported, and known to have many crasher bugs that are fixed in 2.0.


trace query start_time desc

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[x] Improve performance

Related issues

Bug fix

Bug description.
as many end user expected and for better user experience, the trace details show as start_time desc
How to fix?

New feature or improvement

Describe the details and related test reports.

Coverage remained the same at 24.535% when pulling e96e98754aa6518e644e3ec904815207e9b0aee7 on candyleer:trace_sort_start_time_desc into 1e57d48d940631c1d0658f44eaec90a268da1f23 on apache:master.


Migrated SortedSet from collections.js to js-sdsl.

Codecov Report

Merging #25 (100668e) into main (af3e154) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines          103       101    -2
=========================================
- Hits           103       101    -2

Impacted Files
Coverage Δ

lib/number-allocator.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af3e154...100668e. Read the comment docs.


Tags views shows posts ascending but should be descending

This should be easy to fix but I cannot find the function controlling the posts displaying old posts first vs new first.  Looked everywhere so would be amazing if someone could even point me to the file.
Thanks!

You can find it in the tags_controller.rb file.
Thank you for pointing this out!

Thanks Kenny!  Yes I found this file but still cannot find any way to fix this behaviour.  Can this be easily fixed?


cilium-operator: attempts to reconcile non-Cilium xRoutes

Is there an existing issue for this?

[X] I have searched the existing issues

Version
equal or higher than v1.16.0 and lower than v1.17.0
What happened?
When enabling the Gateway API functionality in the 1.16.1 helm chart in our k8s clusters, the cilium-operator began reconciling HTTPRoutes owned by the Kong Kubernetes Ingress Controller, which caused both controllers to update the same HTTPRoutes in a tight loop.
How can we reproduce the issue?

Install the Cilium helm chart with Gateway API enabled
Install the Kong Kubernetes Ingress Controller chart
Create a KIC Gateway and an associated HTTPRoute
Observe the KIC and Cilium operators reconciling the HTTPRoute in a tight loop

Cilium Version
v1.16.1
Kernel Version
6.1.102
Kubernetes Version
v1.28.12-eks
Regression
No response
Sysdump
No response
Relevant log output
No response
Anything else?
No response
Cilium Users Document

[X] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

not stale


Rotary embeddings do not work properly in eva02_base_patch14_448.mim_in22k_ft_in1k

Describe the bug
  File "C:\Users\Bobyard\miniconda3\envs\py310\lib\site-packages\timm\layers\pos_embed_sincos.py", line 214, in apply_rot_embed_cat
    return x * cos_emb + rot(x) * sin_emb
RuntimeError: The size of tensor a (768) must match the size of tensor b (64) at non-singleton dimension 2

x.shape
Out[3]: torch.Size([BS, 1024, 768])
cos_emb.shape
Out[4]: torch.Size([1024, 64])
x.shape is due to PatchEmbed applied to the input of the model [BS, 3, 448, 448]
('patch_embed', PatchEmbed(
(proj): Conv2d(3, 768, kernel_size=(14, 14), stride=(14, 14))
(norm): Identity()
))
1024 in cos_emb comes from product of patch_embed.grid_size.shape (32x32=1024): feat_shape=None if dynamic_img_size else self.patch_embed.grid_size
64 in cos_emb comes from embed_dim // num_heads = 768 // 12 = 64
To Reproduce
Steps to reproduce the behavior:

timm.create_model('eva02_base_patch14_448.mim_in22k_ft_in1k', num_classes=1000, pretrained=True)
Some basic train loop

@bobyard-com model works fine for me with builtin train scripts so you'll have to provide a lot more detail on 'basic train loop' and environment if you think it's the lib's issue...

python train.py --dataset hfds/timm/resisc45 --amp -j 8 --model eva02_base_patch14_448.mim_in22k_ft_in1k --num-classes 45  -b 32
Training with a single process on 1 device (cuda).
Model eva02_base_patch14_448_mim_in22k_ft_in1k created, param count:86383149
Data processing configuration for current model + dataset:
	input_size: (3, 448, 448)
	interpolation: bicubic
	mean: (0.48145466, 0.4578275, 0.40821073)
	std: (0.26862954, 0.26130258, 0.27577711)
	crop_pct: 1.0
	crop_mode: center
Learning rate (0.0125) calculated from base learning rate (0.1) and effective global batch size (32) with linear scaling.
Using native Torch AMP. Training in mixed precision.
PyTorch version 2.2.1 available.
Scheduled epochs: 300. LR stepped per epoch.
Train: 0 [   0/590 (  0%)]  Loss: 3.81 (3.81)  Time: 1.607s,   19.91/s  (1.607s,   19.91/s)  LR: 1.000e-05  Data: 0.460 (0.460)
Train: 0 [  50/590 (  8%)]  Loss: 3.80 (3.80)  Time: 0.640s,   49.99/s  (0.657s,   48.73/s)  LR: 1.000e-05  Data: 0.005 (0.014)
Train: 0 [ 100/590 ( 17%)]  Loss: 3.80 (3.80)  Time: 0.645s,   49.64/s  (0.649s,   49.31/s)  LR: 1.000e-05  Data: 0.005 (0.009)

Sorry, we figured it out, this is because you have custom forward function. Our code calls modules of the network sequentially in for loop. So RoPE is applied in attention and not as a first layer.


[Feature, GFI] Include Pyre-Check for performant type checking

Is your feature request related to a problem? Please describe.
There is often no way to check if proper type checking and performant checking are being done within the project. The only focus so far has been on linting and formatting.
It would be nice that this project under Facebook incorporates functionalities provided by Pyre-Check for project performance
Describe the solution you'd like
Discussion over how to integrate and implement Pyre-Check.
Describe alternatives you've considered
I am not aware of tools that act like Pyre, but Pyre is favored since it's developed under Facebook.
Additional context
None.

@Rubix982 Sounds interesting..Can I take this up?

Here you go, @calicomills! Feel free to let us know if you're running into any problems or have any questions.

Hi, @calicomills! Is there any update regarding this? :tada:
Thanks!


broker linter errors

Please fix these errors so that linter can start enforcing again.
I1103 22:41:44.801] broker/pkg/testing/util/file.go:23:1:warning: readAndUnmarshal is unused (deadcode)
I1103 22:41:53.573] broker/pkg/model/config/mock_store.go:11:1:warning: comment on exported type MockStore should be of the form "MockStore ..." (with optional leading article) (golint)
I1103 22:41:53.573] broker/pkg/model/config/mock_store.go:22:1:warning: exported function NewMockStore should have comment or be unexported (golint)
I1103 22:41:53.574] broker/pkg/model/config/mock_store.go:28:1:warning: exported method MockStore.EXPECT should have comment or be unexported (golint)
I1103 22:41:53.574] broker/pkg/model/config/mock_store.go:28:31:warning: exported method EXPECT returns unexported type *config._MockStoreRecorder, which can be annoying to use (golint)
I1103 22:41:53.575] broker/pkg/model/config/mock_store.go:32:1:warning: exported method MockStore.Descriptor should have comment or be unexported (golint)
I1103 22:41:53.575] broker/pkg/model/config/mock_store.go:42:1:warning: exported method MockStore.Get should have comment or be unexported (golint)
I1103 22:41:53.576] broker/pkg/model/config/mock_store.go:53:1:warning: exported method MockStore.List should have comment or be unexported (golint)
I1103 22:41:53.576] broker/pkg/model/config/mock_store.go:64:1:warning: exported method MockStore.Create should have comment or be unexported (golint)
I1103 22:41:53.576] broker/pkg/model/config/mock_store.go:75:1:warning: exported method MockStore.Update should have comment or be unexported (golint)
I1103 22:41:53.577] broker/pkg/model/config/mock_store.go:86:1:warning: exported method MockStore.Delete should have comment or be unexported (golint)
I1103 22:41:53.577] broker/pkg/model/config/mock_store.go:96:1:warning: comment on exported type MockBrokerConfigStore should be of the form "MockBrokerConfigStore ..." (with optional leading article) (golint)
I1103 22:41:53.577] broker/pkg/model/config/mock_store.go:107:1:warning: exported function NewMockBrokerConfigStore should have comment or be unexported (golint)
I1103 22:41:53.578] broker/pkg/model/config/mock_store.go:113:1:warning: exported method MockBrokerConfigStore.EXPECT should have comment or be unexported (golint)
I1103 22:41:53.578] broker/pkg/model/config/mock_store.go:113:43:warning: exported method EXPECT returns unexported type *config._MockBrokerConfigStoreRecorder, which can be annoying to use (golint)
I1103 22:41:53.578] broker/pkg/model/config/mock_store.go:117:1:warning: exported method MockBrokerConfigStore.ServiceClasses should have comment or be unexported (golint)
I1103 22:41:53.579] broker/pkg/model/config/mock_store.go:127:1:warning: exported method MockBrokerConfigStore.ServicePlans should have comment or be unexported (golint)
I1103 22:41:53.579] broker/pkg/model/config/mock_store.go:137:1:warning: exported method MockBrokerConfigStore.ServicePlansByService should have comment or be unexported (golint)

broker/pkg/model/config/mock_store.go is generated code. I want to skip it in the linter. How does pilot deal with the similar issue?
I will fix the file.go issue.

Ok I will exempt check for mock.

seems there's a file called generated_files for the list of autogen files. Why not use it for the exclusion?

Hey, why do we want to check in generated files?

The idea is that if someone does not want to use bazel, they should be able to simply run a go build ....  This cuts out a lot of expensive proto compile/ compiling the tool chain etc. so if all the files are present locally, then things just work.

Can we close this?


chore(main): release addons-api 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-02-12)
Features

bump release (#10) (12f4f8e)
release 1.0.10 (12f4f8e)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/addonsio/addons-ruby/releases/tag/addons-api/v1.1.0 :sunflower:


Laser

created  with prefab for level placement. set up by having at least 2 destination objects referenced in the script attached to the beam. make sure there are no empty references in the destination array


python.nbxmpp: Fix dependency specs

These deps are actually needed at runtime, not just for the test suite.
This presumably hasn't been noticed until now because gajim, the only
consumer of nbxmpp, already depends on all three of these packages
anyway.
However, gajim only depends on libsoup transitively through gupnp-igd, and
thus fails to build if the dependency on that is disabled by passing
enableUPnP = false.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112673 run on x86_64-linux 1

1 package failed to build and are new build failure:

python39Packages.nbxmpp: log was empty

3 packages built:

gajim
python37Packages.nbxmpp
python38Packages.nbxmpp

    File "/build/precis_i18n-1.0.0/test/test_golden.py", line 44, in check_disallow                                                                                input_.encode(profile)                                                                                LookupError: unknown encoding: UsernameCaseMapped:ToLower                                                                                ----------------------------------------------------------------------                                                                                Ran 56 tests in 41.704s                                                                                FAILED (errors=1)                                                                                Test failed: <unittest.runner.TextTestResult run=56 errors=1 failures=0>                                                                                error: Test failed: <unittest.runner.TextTestResult run=56 errors=1 failures=0>                                                                                cannot build derivation '/nix/store/rlvhb299nv29x4chm89dzq8f1f3jcnxj-python3.9-nbxmpp-1.0.2.drv': 1 dependencies couldn't be built                                                          cannot build derivation '/nix/store/v7zyldb900yzl61zzn59c88p55wirhml-env.drv': 1 dependencies couldn't be built
	```

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112673 run on x86_64-darwin 1

1 package failed to build and are new build failure:

python39Packages.nbxmpp: log was empty

2 packages built:

python37Packages.nbxmpp
python38Packages.nbxmpp

The build failure reported by @SuperSandro2000 is valid but unrelated, see #112783

@SuperSandro2000 By the way, you might want to tweak your script, the way it formatted the error message as a single line with tons of spaces between the messages is highly unreadable.

/marvin opt-in
/status needs_reviewer

@SuperSandro2000 By the way, you might want to tweak your script, the way it formatted the error log as a single line with tons of spaces between the messages is highly unreadable.

That is manually copied from my terminal which mangles new lines. Alternative is a screenshot or the terminal finally fixes that bug.


ci: trigger pr pipeline for merge-queue branches

Describe your changes
Pipeline changes to support enabling Merge Queues.
https://pins-ds.atlassian.net/browse/RDSD-96
Useful information to review or test

Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ ] I have performed a self-review of my own code
[ ] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ ] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.27.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.33.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Feature] Subscribe to overlay data change

Feature Description
Hi. I would like to be able to track changes in the drawn layers and save them locally (localStorate, API, ...etc)
Maybe there is already such a possibility, but I did not find it in the documentation
To Do

chart.subscribeAction('OnOverlayChange', (overlay) => {})

Listen for onDrawEnd and onPressedMoveEnd for each created overlay.
chart.createOverlay({
    name: "Segment",
    onDrawEnd({ overlay }): boolean => {
        this.onOverlayChange();
        return true;
    },
    onPressedMoveEnd({ overlay }): boolean => {
        this.onOverlayChange();
        return true;
    },
})

But be aware of this issue, as restoring overlay state can lead to bugs https://github.com/liihuu/KLineChart/issues/459


Marked exported API's as noexcept

Signed-off-by: Alan Jowett<EMAIL_ADDRESS>Resolves: #1618
Description
Mark all exported functions as noexcept to catch bugs where exceptions are leaked across DLL boundaries are caught.
Testing
CI/CD
Documentation
No.

Closing this pull request and moving the noexcept calls to the ebpapi layer.


Write developer docs?

Should include

how to run the different testing and linting tools
something like these pr/testing guidelines: https://snakemake.readthedocs.io/en/stable/project_info/contributing.html#pull-request-guidelines
how to run the C/I locally with https://github.com/nektos/act
how to write documentation and docstrings

What else?
Bumping and changelogs would be nice to have automated in C/I too

Done in https://github.com/pyranges/pyranges/pull/347
See https://pyranges.readthedocs.io/en/latest/developer_guide.html


Add extra StepDefinitionPatternType for other than original gherkin realizations

🤔 What's the problem you're trying to solve?
As a developer of https://github.com/elchupanebrej/pytest-bdd-ng I try to implement messages protocol. pytest-bdd-ng have extra step definition patterns supported, so it can't fire correct messages
✨ What's your proposed solution?
Add extra type to define non-original step definition patterns; Make it non-required

With some what recent events in mind I don't think we'll get a working consensus on this anytime soon.
In the short term would not emitting the StepDefinition message when the pattern is neither regex nor cucumber expression work for you?


[Bug]: update Readme with npm cmds

Bug Title
Update readme
Description of BUG
The readme of the repo doesn't have npm commands that we use during development. Add those to the readme
Add the below points under the cotribution section

Checkout to the forked repo with a new branch for each PR/issue
npm install to install all js dependencies
npm run dev to start the local web server
Connect to localhost:3000
Make changes to the codebase(nextJS and tailwind/plain CSS)
Commit changes and raise PR

Reporduction URL of bug
Nill
Bug Issue Type
Documentation
Screenshot of the issue if in UI/ Document
Nill
Are you taking this issue fix
Up for grabs

Hello @jsvigneshkanna i could take this issue. Can you please assign this to me?

Hi @Yordaniss
Welcome to 😎 community, also it would be appreciated if issue #142 is taken

@jsvigneshkanna with video im not sure if i could do this. I let the opportunity for someone else to contribute to this project 😉
For this issue i have already created a PR. Please review this and let me know if some changes are required.

@Yordaniss
The PR looked perfect as per the requirement,  appreciate that
Please keep this repo in your watchlist to get notifed when new issues or feature request raised


possible issue of tensorflow.keras not handling shape correctly

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Win10 1709 x64
TensorFlow installed from (source or binary): binary from PyPI
TensorFlow version (use command below): 1.6.0
Python version: 3.6.4
Bazel version (if compiling from source): /
GCC/Compiler version (if compiling from source): /
CUDA/cuDNN version: 9.0/7.0
GPU model and memory: GTX1060 6GB
Exact command to reproduce: /

Describe the problem
i believe this is a bug that tensorflow.keras not handling the shape correctly, self.input_shape is provided by me which is [7514, 1] in this case. My code runs fine with keras but get this error with tensorflow.keras
Source code / logs
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-1-21e293afadc1> in <module>()
     22 # x_err[x_err<0] = 0
     23 from astroNN.models import load_folder
---> 24 bcnn = load_folder('astroNN_0224_run002')
     25
     26 # x = np.random.rand(1000,7514)

d:\university\ast425\astronn\astroNN\models\__init__.py in load_folder(folder)
    144         pass
    145
--> 146     astronn_model_obj.compile()
    147     astronn_model_obj.keras_model.load_weights(os.path.join(astronn_model_obj.fullfilepath, 'model_weights.h5'))
    148

d:\university\ast425\astronn\astroNN\models\BayesianCNNBase.py in compile(self)
    238             self._last_layer_activation = 'softmax'
    239
--> 240         self.keras_model, self.keras_model_predict, output_loss, variance_loss = self.model()
    241
    242         if self.optimizer is None or self.optimizer == 'adam':

d:\university\ast425\astronn\astroNN\models\Apogee_BCNN.py in model(self)
     64
     65     def model(self):
---> 66         input_tensor = Input(shape=self.input_shape, name='input')
     67         labels_err_tensor = Input(shape=(self.labels_shape,), name='labels_err')
     68

~\Anaconda3\lib\site-packages\tensorflow\python\keras\_impl\keras\engine\topology.py in Input(shape, batch_size, name, dtype, sparse, tensor, **kwargs)
    621   if dtype is None:
    622     dtype = K.floatx()
--> 623   if not shape and tensor is None:
    624     raise ValueError('Please provide to Input either a `shape`'
    625                      ' or a `tensor` argument. Note that '

ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

The bug description is a little unclear. It seems like you think the error is L623 in topology.py but the actual ValueError message is different than what that line produces. Are you sure that is the line that is causing the error?

Hi, I have found out the cause of issue.
The issue is in tensorflow.keras, the shape cannot be a numpy array while keras can. The issue is gone now if I explicitly convert self.input_shape to a list,
I do think this is a bug???

Assigning to Francois to take a look at it.

Nagging Assignee @fchollet: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@fchollet  May I take a look at this, or have you already solved this? This would be my first issue..

@alphaCTzo7G This issue can still be reproduced with the latest TF1.7, so the issue is not solved. The workaround is I simply convert the numpy array to python list.

Ok.. thanks for reporting @henrysky. If its ok with @fchollet, I will take a look at it and create a PR

Nagging Assignee @fchollet: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 75 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 90 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 105 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 120 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 135 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 150 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 165 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 180 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 195 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 210 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 225 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @fchollet: It has been 240 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


add cross-compile options to Linux build script

This PR adds cross-compile options to the Linux build script build.sh. See #2463.
By calling ./build.sh --arch=arm --rid=linux-arm, both the native and managed components are built for Linux on ARM. Other architectures and RIDs can easily be added as they are brought up.
Calling ./build.sh without args should continue to work identically. The argument parsing is done in the same style as all the dotnet build scripts.
3 things of note, any/all of which can be done as part of this PR if desired, or a separate PR, or not at all:

psl-native-test is currently skipped for cross-compiled ARM builds because a QEMU ARM chroot/rootfs is not available to run the tests. At first glance it looks like Travis can handle it fine.

While the build currently succeeds, running Powershell on an ARM device currently segfaults. I can look into this either on this PR or a separate one -- let me know which is preferred.

Should I add documentation, similar to CoreCLR's? Not sure how "supported" we want this to be at this time.

@stevedesmond-ca,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@stevedesmond-ca, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

cc @SteveL-MSFT

Just ran gdb on it, segfault dump:
0xb674aecc in VirtualCallStubManager::predictStubKind(unsigned int) () from /home/vtsv/powershell/libcoreclr.so
(gdb) bt
#0  0xb674aecc in VirtualCallStubManager::predictStubKind(unsigned int) () from /home/vtsv/powershell/libcoreclr.so
#1  0xb67501d6 in VirtualCallStubManager::getStubKind(unsigned int) () from /home/vtsv/powershell/libcoreclr.so
#2  0xb674d1b4 in VirtualCallStubManager::FindStubManager(unsigned int, VirtualCallStubManager::StubKind*) ()
   from /home/vtsv/powershell/libcoreclr.so
#3  0xb674e98e in VSD_ResolveWorker () from /home/vtsv/powershell/libcoreclr.so
#4  0xb67f4b30 in ResolveWorkerAsmStub () from /home/vtsv/powershell/libcoreclr.so
#5  0xaa205a6e in ?? ()

Sorry, things this deep are beyond my pay grade ;)

@stevedesmond-ca very cool!  I'll try to work on this tomorrow or Friday

I'm not sure if this script is being kept up to date.  It might be better to update build.psm1 and get rid of this.

Segfault issue is being tracked at dotnet/coreclr#13667

@TravisEz13 I have changes to build.psm1 to enable cross-compile in my fork however it's pending the coreclr issue.  If we don't depend on build.sh, perhaps we should consider getting rid of it since it's not up to date with build.psm1

My only hesitance with removing the bash script is the old chicken and egg problem: how do you build Powershell on a system that can't already run Powershell? And maybe that's fine / not a supported use case.

You can cross-compile in the build.psm1.  You cannot cross-package currently, but I usually just manually copy the files to the target platform and get packaging working there.

@TravisEz13 perhaps the @PowerShell/powershell-maintainers should own the decision on whether we still want build.sh?

Who last run the build.sh and why?

It looks like @stevedesmond-ca has run it and he says why.   I don't use it because it's not been maintained and building properly take more/different steps than what is in build.sh.

So if we add the cross-compile scenario in our installation guide we can safely remove build.sh?

I think so.

@stevedesmond-ca Could you please check that the cross-compile scenario works for you (for arm)?

@stevedesmond-ca Could you please check that the cross-compile scenario works for you (for arm)?

Just took a look at @SteveL-MSFT's branch, and I think it's a much better implementation. Since there is an Ubuntu release for Powershell 6b6, we can rely on use Powershell to build Powershell on Ubuntu, and it's made clear in the updated build.psm1 that Ubuntu is the only supported distro for cross-compiling.
I made one quick amendment to Steve's branch  to ensure that the ARM toolchain file is getting called correctly when Start-PSBuild $Runtime linux-arm is run, and pulled that all into this PR. Hopefully that's OK, Steve! Otherwise, feel free to cherry-pick that single commit into your branch and create a new PR that way.

@stevedesmond-ca I've incorporated your change into my PR (which incidentally will remove build.sh since it's not being maintained).  You can close this PR.

Sounds good, thanks!

@stevedesmond-ca Thanks! Come back with new contributions!


librespot-player crashes on Android at random times

Describe the bug
I'm using librespot-java on my Android app, https://github.com/vhaudiquet/BladePlayer
Maybe i'm doing something wrong, but i tried to stay as close as possible to the librespot-android implementation.
Anyway, sometimes (it happened only 3 times in ~10 hours of development/testing this day), my app randomly crashes with this stack trace :
2022-01-07 00:09:13.980 21511-21558/v.blade W/x.g.l.c.Session: Socket timed out. Reconnecting...
2022-01-07 00:09:14.007 21511-21558/v.blade E/x.g.l.c.Session: Failed reconnecting, retrying in 10 seconds...
    java.io.InterruptedIOException: thread interrupted
        at com.android.okhttp.okio.Timeout.throwIfReached(Timeout.java:147)
        at com.android.okhttp.okio.Okio$1.write(Okio.java:75)
        at com.android.okhttp.okio.AsyncTimeout$1.write(AsyncTimeout.java:157)
        at com.android.okhttp.okio.RealBufferedSink.flush(RealBufferedSink.java:222)
        at com.android.okhttp.internal.http.Http1xStream.finishRequest(Http1xStream.java:163)
        at com.android.okhttp.internal.http.HttpEngine.readNetworkResponse(HttpEngine.java:748)
        at com.android.okhttp.internal.http.HttpEngine.readResponse(HttpEngine.java:622)
        at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:475)
        at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:411)
        at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:248)
        at xyz.gianlu.librespot.core.ApResolver.request(ApResolver.java:78)
        at xyz.gianlu.librespot.core.ApResolver.refreshPool(ApResolver.java:54)
        at xyz.gianlu.librespot.core.Session.reconnect(Session.java:713)
        at xyz.gianlu.librespot.core.Session.access$1200(Session.java:77)
        at xyz.gianlu.librespot.core.Session$Receiver.lambda$run$0$xyz-gianlu-librespot-core-Session$Receiver(Session.java:1361)
        at xyz.gianlu.librespot.core.Session$Receiver$$ExternalSyntheticLambda0.run(Unknown Source:2)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
        at java.lang.Thread.run(Thread.java:920)
2022-01-07 00:09:14.023 21511-21557/v.blade E/AndroidRuntime: FATAL EXCEPTION: session-packet-receiver
    Process: v.blade, PID: 21511
    java.lang.NullPointerException: Attempt to read from field 'java.io.DataInputStream xyz.gianlu.librespot.core.Session$ConnectionHolder.in' on a null object reference
        at xyz.gianlu.librespot.core.Session$Receiver.run(Session.java:1339)
        at java.lang.Thread.run(Thread.java:920)
2022-01-07 00:09:14.185 21511-21557/v.blade I/Process: Sending signal. PID: 21511 SIG: 9

There seems to be nothing from me in this stack trace, but maybe i misconfigured something in the library ? Or maybe there is a bug (race condition ? something like that ?) in librespot-java...
It always happens after a 'Socket Timed Out, reconnecting...' event, but when i try to reproduce by enabling/disabling internet connection, i can't. I don't really understand why, but again if it is a race condition there might be an explanation.
Do you have an idea of what could be causing this ?
I tried to reproduce on librespot-android but i did not really have time to reproduce it (i only left it in the background playing music for 1 hour and it did not happen, but that does not mean anything...)
Maybe i'm doing something wrong, did i forget something in the configuration that could be causing this ?
I did not really understand the use of WeakReference in your librespot-android implementation ; maybe this issue comes from that ? I tried with and without WeakReference but it seems to happen in both cases...
I'm really sorry if i'm wasting your time and the bug is on my end, and in that case if you could provide me any information that would help me fix it, i would be grateful :))
To Reproduce
I don't really know how you can reproduce that, given the 'rarity' of the event...
Version/Commit
I'm using librespot-player:1.6.2
I configure the player in here : https://github.com/vhaudiquet/BladePlayer/blob/master/app/src/main/java/v/blade/sources/spotify/SpotifyPlayer.java

Update :
I found this issue : https://github.com/square/retrofit/issues/2069 which seems to be the same as this one.
They explain that the issue comes from the okhttp client, and that it can happen on a timeout i think ?
Anyway, i think that this exception can be catched, at librespot level ? That seems better than just crashing...

Has anyone actually tried this with android now? I might need some help.

I have updated Blade Player to the latest snapshot of librespot-java, and i can confirm that it seems to work now (even tho the issue happened at random times before, so i cannot be 100% sure)


Create UnstableTests.txt

I'm going to have Jenkins ignore these when detecting error status, but still report on them

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/706/ for details

No pylint warnings for pull request 6295:

Unit test changes for pull request 6295:

WMCore_t.WorkQueue_t.WorkQueue_t.WorkQueueTest:testThrottling changed from failure to success

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/712/ for details


deploy/charts/cert-manager: Fixes typo in webhook-psp definition

What this PR does / why we need it:
It fixes the typo that prevents helm chart to be used with psp enabled.
This kind of issue might be detected early in the future by enabling psp
in e2e tests (https://github.com/jetstack/cert-manager/pull/2280).
A similar bug was already fixed in
be0b865522e9d876b81155790996a2ea1e37a893.
Which issue this PR fixes : fixes #2386
Special notes for your reviewer:
Release note:

NONE

/assign @munnerz

/lgtm
/approve
/ok-to-test

Thanks for this contribution! 😄


Store light / material / ambient / fog colors always in sRGB space

Based on the Scene.gammaCorrection, we store those colors either in gamma (this is the default), or linear space (when gamma is disabled). This causes two problems:

when gammaCorrection changes, the scene looks visually different, as the shader math is the same, but its input colors uniforms are different. So when we switch to HDR, the scene is too bright.
we cannot correctly handle multiple cameras, one using sRGB and one linear, as colors are adjusted based on a global gamma setting.

Suggestion:

always store these colors in sRGB only.
Scene.gammaCorrection should only affect the way pixels are written to render target, not encoding of inputs

I would expect no impact to majority or maybe even all users, as our HDR rendering path was hardly functional till now.
some of the relevant code:
https://github.com/playcanvas/engine/blob/5a6ff8668e0c0f3deb56ce89d4897b523b020abd/src/scene/materials/standard-material.js#L1101-L1109
https://github.com/playcanvas/engine/blob/5a6ff8668e0c0f3deb56ce89d4897b523b020abd/src/scene/renderer/forward-renderer.js#L150-L154
https://github.com/playcanvas/engine/blob/5a6ff8668e0c0f3deb56ce89d4897b523b020abd/src/scene/renderer/forward-renderer.js#L231
https://github.com/playcanvas/engine/blob/5a6ff8668e0c0f3deb56ce89d4897b523b020abd/src/scene/renderer/forward-renderer.js#L780-L784

This sounds like it would explain a lot, as someone who mostly runs playcanvas in hdr mode we've struggled a while with consistency over the two modes (e.g. gsplats are very different right now).  I'll be sure to give the PR a test if and when there is one

This sounds like it would explain a lot, as someone who mostly runs playcanvas in hdr mode we've struggled a while with consistency over the two modes (e.g. gsplats are very different right now). I'll be sure to give the PR a test if and when there is one

yep, there will be a PR today / tomorrow for this.


NAS-125087 / 24.04 / Add integration test for debug and compress path permissions

Context
PR adds integration test to ensure that the permissions of the debug and compress paths are always set to 700.
Work was done in this PR.

Jira URL: https://ixsystems.atlassian.net/browse/NAS-125087

Jira URL: https://ixsystems.atlassian.net/browse/NAS-125087


Queries for views

That's still a WIP - posting code to have a better place for discussion on what actually should be developed

Rename getPositionById to getPositionHistoryById


HubSpot calendar embed blocked by Chrome extension

Description
Hello. I found a past Issue in this repo about this extension blocking HubSpot CTAs. It may now also be blocking the embedded scheduler tool. I was first notified of this by a colleague and was able to reproduce it on my machine. With the extension on, it blocks the embedded HubSpot meeting scheduler tool.
I've embedded it two different ways here (with two different schedulers and HS accounts) and it is blocked both ways with extension on:
https://smartinbound.com/testing/
And here was the original bug found:
https://sittadel.com/start/
Steps to Reproduce

Visit either of the above webpages with the extension on, OR
Embed the HubSpot scheduler on any website
Activate the Privacy Essentials plugin on Chrome

Expected behavior:
The scheduler should show.
Actual behavior:
The scheduler does not show.
Versions

Extension: 2024.7.24
Browser: Chrome
OS: Mac

Additional Information
It is repeatable, no console errors, unsure about upgrade (was referred to this issue by an extension user, I am the web dev)

Thanks for the report, and our apologies for the trouble! Really appreciate the links to repro. We'll get a fix out for this ASAP.

@dharb Incredible, thank you much!

@jdinbound we just merged a fix in https://github.com/duckduckgo/privacy-configuration/pull/2224, it will roll out to clients over the next 15-30 mins. Any chance you could confirm that the issue is fully resolved?
We'd love to send you a free DuckDuckGo t-shirt for taking the time to submit such a thorough report. If you're interested, shoot me an email at the address I used in the test form with your size and where to send it.

Confirmed resolved on both my sites! Thanks for the fast work. Very happy to help, love your mission. I will absolutely email you haha :)

Thanks for confirming! Closing as fixed.


Edit the max upload size

Hello,
I have seen your project on Reddit, thanks for this awesome idea !
I would like to know if its possible to add a variable to choose the max upload size allowed for this web server for the Docker image. I want to translate a bigger video than 128 MB but I can't do it.
Thanks 🙂

Would also like to know what the process would be.
I believe the Reddit post that brought us here said that this was possible, but isn't documented anywhere in the repository or in the Reddit post at the time of posting this.

https://github.com/aschmelyun/subvert/blob/94ef8eb877d8a6ce065478bedb47d8fe7a533bbc/Dockerfile#L6
I think you just change this line and rebuild the docker image

https://github.com/aschmelyun/subvert/blob/94ef8eb877d8a6ce065478bedb47d8fe7a533bbc/Dockerfile#L6
I think you just change this line and rebuild the docker image

That's good to know. Thanks!
I think, though, this should be an environmental variable to easier management.

You can add this line to docker compose file
See https://www.baeldung.com/ops/docker-compose-multiple-commands

Done! There's now two new env arguments you can pass to your docker run command with -e flags:

UPLOAD_MAX_FILESIZE - Changes PHP's UPLOAD_MAX_FILESIZE setting. Default: 256M
MEMORY_LIMIT - Changes PHP's MEMORY_LIMIT setting. Default: 512M

You can try this out by pulling in the latest Docker image docker pull aschmelyun/subvert:latest

Awesome!!


fix: Transaction estimate - failed to sign

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #9418

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed UI

Copilot Summary
copilot:summary
copilot:poem

could not reproduce this problem, any tips?

Thanks!
pay 30 usd

😍 Perfect, I’ve sent the payout
💵 $30 @ 7.74 USD/DOT ~ 3.876 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x08d85c2d79203dd6f770a92652fa3d3c0ae0722f6aa20258ec6b113afe6b57d2
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Icon request: Shopee

URL of the site or app (required): https://shopee.co.id/
Logo resources for the icon (optional): https://upload.wikimedia.org/wikipedia/commons/f/fe/Shopee.svg

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/SVG/Shopee.svg

❓ How to add icon(s) to Aegis?
⭐ Support this project by giving a star! Just adding like to this comment is also appreciated.


Debug build crashed due to sceneData->aggregateInstancePtrs being cleaned up?

Hi Rohan,
When I run demo with bvc.json, it crashed at https://github.com/rohan-sawhney/zombie/blob/d1756baf72efbbc568707e8cb584d6914ebbc62f/include/zombie/utils/fcpw_scene_loader.h#L229
It seems that within fcpw.inl: inline void Scene<DIM>::build(const AggregateType& aggregateType, bool vectorize, bool printStats, bool reduceMemoryFootprint), aggregateInstancePtrs and aggregateInstances will be reset if there is only 1 aggregate instance.
I have yet to dig into the detail of your fcpw/zombie implementation, but my temporary fix for this issue is simply returning sceneData->aggregate if aggregateInstancePtrs is empty.
Though, release built work magically with disabled indexing check for std::vector under MSVC's implementation and it could fetch the correct aggregate somehow. =D
Best!

@Hearwindsaying thanks for reporting the bug, fixed now!


GoLint Tool not giving errors

I was running golint tool on go program but it is not able to detect errors such as blank if
My program
: package main
import "fmt"
func main() {
fmt.Println("Hello,World!")
var b int
for b := 0; b < 10; b++ {
if(b<10) {
}

}
}
I am running golint  from command line
Command: golint filename.go
Please help me out i am unable to understand since it is not giving any o/p

Thanks for the note.
This appears to be out of scope and so is being closed. If you feel this is in error please feel free to re-open.
Please note this is not the forum to discuss edits to CodeReviewComments. If you wish to propose changes to it please send a mail to golang-nuts.


fixes for "run-script-os" and pyinstaller's "--onefile" issues, on linux

Bumped all dependencies, specifically "run-script-os" because of this issue(https://github.com/charlesguse/run-script-os/issues/42) in version 1.0.7.
Removed "--onefile" for linux since it throws error, instead updated spec files in order to create true standalone executable.
I only checked these changes in linux environment, and I have no idea if it will for windows and macos. Please report here if you have checked.

Thanks for the PR!


Simplify the parameter for forward index creators

Also move method getNumBitsPerValue() into PinotDataBitSet and re-implement it without using double

Codecov Report

Merging #3208 into master will increase coverage by 0.05%.
The diff coverage is 97.72%.

@@             Coverage Diff              @@
##             master    #3208      +/-   ##
============================================
+ Coverage     70.33%   70.38%   +0.05%
  Complexity        4        4
============================================
  Files           957      957
  Lines         44238    44226      -12
  Branches       5962     5961       -1
============================================
+ Hits          31113    31128      +15
+ Misses        11056    11027      -29
- Partials       2069     2071       +2

Impacted Files
Coverage Δ
Complexity Δ

...mpl/fwd/MultiValueUnsortedForwardIndexCreator.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...ment/creator/impl/SegmentColumnarIndexCreator.java
88.76% <100%> (-0.05%)
0 <0> (ø)

...pl/fwd/SingleValueUnsortedForwardIndexCreator.java
100% <100%> (+10.52%)
0 <0> (ø)
:arrow_down:

...loader/defaultcolumn/BaseDefaultColumnHandler.java
92% <100%> (+0.1%)
0 <0> (ø)
:arrow_down:

...m/linkedin/pinot/core/io/util/PinotDataBitSet.java
100% <100%> (ø)
0 <0> (ø)
:arrow_down:

...impl/fwd/SingleValueSortedForwardIndexCreator.java
94.73% <93.75%> (-1.27%)
0 <0> (ø)

...in/pinot/core/query/pruner/ValidSegmentPruner.java
57.14% <0%> (-28.58%)
0% <0%> (ø)

...a/manager/realtime/RealtimeSegmentDataManager.java
75% <0%> (-25%)
0% <0%> (ø)

...lix/EmptyBrokerOnlineOfflineStateModelFactory.java
86.66% <0%> (-13.34%)
0% <0%> (ø)

...impl/dictionary/FloatOffHeapMutableDictionary.java
85.45% <0%> (-7.28%)
0% <0%> (ø)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d36680...f21067f. Read the comment docs.


Restructure and rename repo to allow running more than ruby

We want to write snakes in other languages like Go, Python, or Rockstar. We don't want to spin up multiple container instances (more $$ and management).
We can cram the other services into our Docker image, and run them the same way on different ports 🎉 .

we still got some work to do on this yo. re-opening

I think we can call this done for now.


Decompiling s&box default shaders fails

Describe the bug
Using the latest Windows Source2Viewer build, decompiling s&box default shaders (simple, complex, sky, glass, etc), will fail with 'Object reference not set to an instance of an object.'
Relevant log output or exception with stacktrace
[21:57:47.849] [ExtractProgressForm] Failed to extract 'simple.shader_c': System.NullReferenceException: Object reference not set to an instance of an object.
   at ValveResourceFormat.IO.ShaderExtract..ctor(Resource resource) in D:\a\ValveResourceFormat\ValveResourceFormat\ValveResourceFormat\IO\ShaderExtract.cs:line 88
   at ValveResourceFormat.IO.FileExtract.Extract(Resource resource, IFileLoader fileLoader) in D:\a\ValveResourceFormat\ValveResourceFormat\ValveResourceFormat\IO\FileExtract.cs:line 175
   at GUI.Forms.ExtractProgressForm.ExtractFile(Resource resource, String inFilePath, String outFilePath, Boolean flatSubfiles) in D:\a\ValveResourceFormat\ValveResourceFormat\GUI\Forms\ExtractProgressForm.cs:line 368

What game does this happen in
S&box
Reference file in a Source 2 game
(steam path)\sbox\common\addons\base\shaders\simple.shader_c
Expected behavior
I'd expect this to output the decompiled (.shader) file from the (.shader_c) file to the specified directory
What version of VRF are you using? On what platform?
Source 2 Viewer v7.0.2766+b14cdfbc9f316ff8085d2f1c226a50d1c6f6f6e6 (Windows 10)

Can't repro.


HIVE-24191: Introduce configurable user to run compaction as

What changes were proposed in this pull request?
Add a restricted config.
Why are the changes needed?
Sometimes we want to run compaction as a specific user.
Does this PR introduce any user-facing change?
Admin can optionally specify a user that will run compaction and list files in compaction Initiator and Cleaner.
How was this patch tested?
Unit tests

As discussed with @pvary offline: Restricting isn't needed because the Initiator/Worker/Cleaner configs can't be changed without restarting HMS (or HS2 if applicable)


Setting different hostnames

I am trying to pass hostnames to isOnline(), using isOnline({hostnames: ["http://www.google.com"]}), but it is always using the hostnames listed on hostnames.js file, ignoring the hostnames I passed when call isOnline()
I am using it on electron too, so I need to pass hostnames as options to be able to use http or https on requests that check internet, because without this the lib automatically does the requests using file://

Addressed URL support in https://github.com/sindresorhus/is-reachable/commit/aa425c29178b663e44e249c40621440a2390fa01.

@silverwind can you estimate when this changes will be released?

Right now we're contemplating removing the is-reachable dependency entirely (https://github.com/sindresorhus/is-online/issues/22#issuecomment-276912618). Is there any specific reason why you can't use is-reachable directly?

no, I am already thinking about this, to use is-reachable directly. But you will remove and is-online will work in a different way of is-reachable?

Yes, after the removal, there would only be the root dns and the predefined URL check (which arguably could be made configurable).
is-online is all about checking if you have a working internet connection.
is-reachable is about checking if you can reach a particular server.

With this, it is more interesting to me to keep using is-online. Because check the internet is exactly what I need. The only reason why I need to be able to configure the url to check is because I am using this on an electron app, and on electron when I check an url without http it tries to check with file://

Isn't there a way to force electron to load the Node.js version of this module? . E.g. not use the browser field from package.json, but instead use main (which defaults to index.js).
Anyways, I'll get to releasing.

Released 6.1.0 which supports URLs for the hostnames.

Thank you @silverwind, and thanks for the quick replies


ninja fails to cross compile for aarch64 due to exec format error

Steps To Reproduce
Steps to reproduce the behavior:

build ninja for aarch64-linux

Build log
unpacking sources
unpacking source archive /nix/store/nqgbichcldbrvingbmhcyymh2xydghmr-source
source root is source
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
bootstrapping ninja...
./src/json.cc: In function ‘std::string EncodeJSONString(const string&)’:
./src/json.cc:36:18: warning: comparison is always true due to limited range of data type [-Wtype-limits]
   36 |     else if (0x0 <= c && c < 0x20) {
      |              ~~~~^~~~
./src/ninja.cc: In constructor ‘{anonymous}::DeferGuessParallelism::DeferGuessParallelism(BuildConfig*)’:
./src/ninja.cc:1400:16: warning: ‘{anonymous}::DeferGuessParallelism::config’ will be initialized after [-Wreorder]
 1400 |   BuildConfig* config;
      |                ^~~~~~
./src/ninja.cc:1399:8: warning:   ‘bool {anonymous}::DeferGuessParallelism::needGuess’ [-Wreorder]
 1399 |   bool needGuess;
      |        ^~~~~~~~~
./src/ninja.cc:1402:3: warning:   when initialized here [-Wreorder]
 1402 |   DeferGuessParallelism(BuildConfig* config)
      |   ^~~~~~~~~~~~~~~~~~~~~
wrote build.ninja.
bootstrap complete.  rebuilding...
Traceback (most recent call last):
  File "/build/source/configure.py", line 720, in <module>
    subprocess.check_call(rebuild_args)
  File "/nix/store/qc8rlhdcdxaf6dwbvv0v4k50w937fyzj-python3-3.10.8/lib/python3.10/subprocess.py", line 364, in check_call
    retcode = call(*popenargs, **kwargs)
  File "/nix/store/qc8rlhdcdxaf6dwbvv0v4k50w937fyzj-python3-3.10.8/lib/python3.10/subprocess.py", line 345, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/nix/store/qc8rlhdcdxaf6dwbvv0v4k50w937fyzj-python3-3.10.8/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/qc8rlhdcdxaf6dwbvv0v4k50w937fyzj-python3-3.10.8/lib/python3.10/subprocess.py", line 1847, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 8] Exec format error: './ninja'

Additional context
Discovered on my Hydra instance, (build job).
View raw log
Notify maintainers
@thoughtpolice @bjornfor @orivej
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.74, NixOS, 22.05 (Quokka), 22.05.3848.c132d0837df`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - channels(root): `"nixos-22.05"`
 - channels(ross): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Upstream does not seem to support cross bootstrap for now, but I've authored an experimental patch for that: https://github.com/NickCao/ninja/commit/92330cc2320cc8aac432d80da12235abcb2bb449

Alright, I'll try it on my Hydra setup. If it works, could probably PR it and keep this issue open until it is included.


⚠ Processors has degraded performance

In b9d04f5, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 95 ms

Resolved: Processors performance has improved in 07b2c96.


fix: handle execution report

Description

This PR is to fix the issue #494
Related Issue

#494
Motivation and Context

Refer #494
How Has This Been Tested?

A test case is written and running on my development server.
Screenshots (if appropriate):

Codecov Report

Merging #495 (5454d3b) into master (5daea00) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #495   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           90        90
  Lines         3315      3314    -1
  Branches       559       557    -2
=========================================
- Hits          3315      3314    -1

Impacted Files
Coverage Δ

app/binance/user.js
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Hello @chrisleekr
It seems everything fine!
I just added one comment but we are good to go.


Added warning

This will prevent future GCI students to get confused with the installation instructions

Automated message from Dropbox CLA bot
@Juanvulcano, it looks like you've already signed the Dropbox CLA. Thanks!

ping @timabbott This looks great to me, I think we should merge it once Travis builds.

Thanks for working on this @Juanvulcano!  I'd like to start with doing a lighter warning, since (1) the previous instructions had nothing at the page suggesting the differences between production and development and (2) this page is one of potential users first interactions with our production documentation, and I'd like to avoid bold warnings unless they are needed.  So I've merged b8ec9a5 to address this issue.  Huge thanks for helping discern this problem and working on it!


Adding a test for the document for the Pod security standard

Why are these changes needed?
This PR is based on #750 and #769. It adds a unit test for the document for the Pod security standard.
What does this unit test do:

Create namespace pod-security with restricted Pod security policy
Install the operator in the default namespace(another option is install operator in namespace pod-security)
Apply the restricted Pod security standard to all Pods in the namespace pod-security.
test if can create the RayCluster in the namespace pod-security.

Why use k8s python client instead of kubectl to create Pod without securityContext?
shell_subprocess_run(kubectl -f XXX.yaml) only returns 0 or 1 to indicate if the command succeeds or fails.
shell_subprocess_check_output() does provide the output but we are expecting an exception. unittest provides assertRaises to pass the test if an exception is raised. shell_subprocess_check_output needs to use try to produce an exception which is not a good implementation. k8s_v1_api.create_namespaced_pod  can return a specific exception.status(error type),  so that only forbidden error(403) is allowed.
Related issue number
#750
Closes #769
Checks
I have tested this by creating the RayCluster with/without proper securityContext configurations by running:
#Path: kuberay
python3 tests/security-test.py

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

Merge this PR.

The CI failure "Compatibility Test - Nightly" has no relationship with this PR. See https://github.com/ray-project/kuberay/issues/852#issuecomment-1387340849 for more details.

@Yicheng-Lu-llll found a bug about pod-security.md, but the root cause is about Ray's docker image. @Yicheng-Lu-llll will open issues to track the progress.

#873

@kevin85421 "another option is install operator in namespace pod-security" should be the default


Feature Request: distribute from baseline

Hello!
Each second command it seems to me I use this plugin. But while creating screens I often have to measure from baseline t baseline (Sketch: hold opt + ctrl).
It would be a nice feature to have some settings to let the Distributor know where he have to measure from …
BR

Hello, sorry for never responding to this. I like this idea and think it fits within the scope of Distributor. Right now I don't know how to implement it, but I will have a look at it.


Authenticate w/ tokens w/ the HTCondor-CE collector

This is redmine issue https://cdcvs.fnal.gov/redmine/issues/26576
OSG issues https://opensciencegrid.atlassian.net/browse/HTCONDOR-735
and   https://opensciencegrid.atlassian.net/browse/HTCONDOR-991

In GWMS 3.9.5 and 3.7.7


Default branch settings are inconsistent

When creating a new project from scratch copier initializing git with a default branch name specified by git's init.defaultBranch setting ("master" if not specified). However most of template's Github Actions workflows use "main" branch.
Generally speaking, it is unclear for me why testing and linting are not being applied for all branches.

Thanks for the note, you're correct that the latest tagged release of the copier template defaults to 'master'. However, we have a change staged that will change that to default to 'main', we just haven't tagged it for release yet :)
Your second point about testing and linting being applied to all branches is a valid question. As it stands, I believe all of the CI automation will run when a user creates a PR that will merge into main - which we take to be the "standard" work flow.
However, I don't think there is a reason to restrict it to just PRs that will merge to main. If it's ok with you, I'll rename this ticket to reflect that as the primary request.

General consensus is that we'll leave this as is, with the understanding that we're supporting a "typical use case". Hydrated projects can, of course, modify the CI action triggers as needed. And when users update their projects from the template, they have the option of excluding changes to the CI actions that would overwrite their customizations.

For me it looks like it probably was fixed even before I wrote this issue, in e4ddc2b1be538772dad07f2f3cd30e8378e1546c, so sorry for the confusion


Complex example, with props.

Hello are there any guides for how to best pass props to vk components?
Also how to extend them?
Thanks!

Hi there,
Vuikit components are standard Vue components, it inherits all best practices from Vue. You should review it documentation.
As for extending them, this is the recommended way, but not limited to.


Add a validation that weight of product can not be in negative.

Framework Version : 0.1.2
Actual- Able to add weight in negative.

Framework Version: 0.1.4
Fixed


Add testing info to docs

Adding information on how to test Kefir Observables would be a nice addition to the docs. Wondering if we should put all of that into the main docs site, or have a separate site for testing with chai-kefir, or maybe moving all the docs into a kefirjs.github.io repo & website. Thoughts?

I'd probably put testing documentation into chai-kefir.
As for separate repo for the docs, I think it's great idea. Might be tricky to separate from the main repo though.


[question]  inside

The following piece of code wil render the   inside the textarea as html is not allowed.
render() {
    return html` <textarea> <slot> </slot> </textarea>`
}

Thus  becomes unusable, is there a way to use javascript to set the slow inside?

By spec, the text area only allows text content, so you can't usefully add a slot to it.
Testing in Chrome, I was able to add a slot by calling appendChild, but the slot's contents are never displayed.
If you want to let users set the starting text in the textarea, you could expose a property on your element that gets bound to the textarea's value:
return html` <textarea .value=${this.myprop}></textarea>`

If you really need to configure the default text for the textarea based on slotted content, you could consider having a hidden slot element (a sibling, not a child, of the textarea), and grab the text that gets slotted in. That could look something like this:
updateSlotted({target}) {
  this.myprop = target.assignedNodes().map((n) => n.textContent).join('');
}

render() {
  return html`<textarea .value=${this.myprop}></textarea>
    <div hidden>
      <slot @slotchange=${this.updateSlotted}></slot>
    </div>`;
}

Hope that helps!

Closing, as the solution @arthurevans gave above are the best options to deal with slotting content into textarea.  Hope that helps your use case!


Rewrite the match statement according to the spec

Description:
$subject
Related Issues (optional):
#25040

After all match patterns are implemented, check the TODOs which are used to handle the pending match patterns.


tikv keep oom on arm64 k8s deployments

Bug Report

What version of TiKV are you using?

MySQL [(none)]> select distinct type,version,git_hash from information_schema.cluster_info;
+------+-------------------------+------------------------------------------+
| type | version                 | git_hash                                 |
+------+-------------------------+------------------------------------------+
| pd   | 5.4.0-alpha-49-geba75c3 | eba75c3080a0db2d5edda7a2a8628e3a08c1af87 |
| tidb | 5.4.0-alpha             | 755553660e6036ead13d1f0aa271eaf59d939fbd |
| tikv | 5.4.0-alpha             | 7eeff52ec2f9494a24c712479720bbcf5e9d85dd |
+------+-------------------------+------------------------------------------+
3 rows in set (0.017 sec)

What operating system and CPU are you using?

arm64 linux
Steps to reproduce

restore the ycsb dateset
    br restore db --db=test --pd "pd-peer:12379" \
        --storage "s3://ycsb-100m-v5.0.0" \
        --s3.endpoint "xyz.com" \
        --send-credentials-to-tikv=true \
                --check-requirements=false

What did you expect?
restore successfully
What did happened?
tikv keep oom and br restore fail
why tikv use 62G memory immediate just after startup.
For the tikv pod, 64G memory is allocated. memory_limit is set to 62GB.
  arch: arm64
  user: "tidb"
  ssh_port: 22
  deploy_dir: "/tiup/deploy"
  data_dir: "/tiup/data"
  resource_control:
    memory_limit: "62G"
monitored:
  node_exporter_port: 19100
  blackbox_exporter_port: 19115
server_configs:
  pd: {}
  tidb: {mem-quota-query:<PHONE_NUMBER>0, prepared-plan-cache: {enabled: true}}
  tikv: {"storage.block-cache.capacity": 30GB}

[Thu Dec 16 22:46:27 2021] [<ffff0000082a145c>] mem_cgroup_oom_synchronize+0x3c0/0x424
[Thu Dec 16 22:46:28 2021] [ pid ]   uid  tgid total_vm      rss nr_ptes nr_pmds swapents oom_score_adj name
[Thu Dec 16 22:46:28 2021] oom_reaper: reaped process 24747 (tikv-server), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[Thu Dec 16 22:47:18 2021] sst-importer4 invoked oom-killer: gfp_mask=0x14000c0(GFP_KERNEL), nodemask=(null),  order=0, oom_score_adj=-998
[Thu Dec 16 22:47:18 2021] [<ffff000008210ca8>] oom_kill_process+0x2b8/0x524
[Thu Dec 16 22:47:18 2021] [<ffff0000082a145c>] mem_cgroup_oom_synchronize+0x3c0/0x424
[Thu Dec 16 22:47:19 2021] [ pid ]   uid  tgid total_vm      rss nr_ptes nr_pmds swapents oom_score_adj name
[Thu Dec 16 22:47:19 2021] oom_reaper: reaped process 26019 (tikv-server), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[Thu Dec 16 22:47:40 2021] sst-importer6 invoked oom-killer: gfp_mask=0x14000c0(GFP_KERNEL), nodemask=(null),  order=0, oom_score_adj=-998
[Thu Dec 16 22:47:41 2021] [<ffff000008210ca8>] oom_kill_process+0x2b8/0x524
[Thu Dec 16 22:47:41 2021] [<ffff0000082a145c>] mem_cgroup_oom_synchronize+0x3c0/0x424
[Thu Dec 16 22:47:41 2021] [ pid ]   uid  tgid total_vm      rss nr_ptes nr_pmds swapents oom_score_adj name
[Thu Dec 16 22:47:41 2021] oom_reaper: reaped process 27400 (tikv-server), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB
[Thu Dec 16 22:48:15 2021] raftstore-4-0 invoked oom-killer: gfp_mask=0x14000c0(GFP_KERNEL), nodemask=(null),  order=0, oom_score_adj=-998
[Thu Dec 16 22:48:15 2021] [<ffff000008210ca8>] oom_kill_process+0x2b8/0x524
[Thu Dec 16 22:48:15 2021] [<ffff0000082a145c>] mem_cgroup_oom_synchronize+0x3c0/0x424
[Thu Dec 16 22:48:15 2021] [ pid ]   uid  tgid total_vm      rss nr_ptes nr_pmds swapents oom_score_adj name
[Thu Dec 16 22:48:16 2021] oom_reaper: reaped process 28058 (tikv-server), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB

/found automation

/type bug

/severity major

the oom due to the THP is not disabled on the arm64 machine, after disable THP, there is no oom.


chromium: speechSynthesis does not work

Steps to reproduce:
nix-env -i speech-dispatcher espeak chromium
chromium --enable-speech-dispatcher

var msg = new SpeechSynthesisUtterance();
msg.text = "Hello, World!";
msg.lang = "en";
speechSynthesis.speak(msg);

expected: should say hello world
obtained: silence
Test

window.test = function(){
  window.speechSynthesis.onvoiceschanged = function() {
    console.log(window.speechSynthesis.getVoices())
  };
}

expected: should return an non-empty array of SpeechSynthesisVoice
obtained: empty array
see: https://jsfiddle.net/wdhLd55r/2/

I have the same issue with Brave and Firefox :
Steps to reproduce :

open browser with speech programsnix-shell --packages brave speechd espeak --command "sh -c 'speech-dispatcher --run-single --log-level 5 --timeout 0 & brave --enable-speech-dispatcher https://jsfiddle.net/wdhLd55r/2/'"

click on Test

Actual result :
No sound
Expected result :
Speech

@pinage404 while looking for a solution myself, I run into this pr https://github.com/NixOS/nixpkgs/pull/210453 that solved the issue for me on Firefox.

speechd is included in chromium as of https://github.com/NixOS/nixpkgs/pull/133544 (and switched to speechd-minimal in https://github.com/NixOS/nixpkgs/pull/329658). Can anyone reproduce this issue on Chromium?

Yes, same problem for me with Chromium 130.0.6723.58.


Update links to Rest API docs

Two benefits:

No redirect needed, users land on the final URL immediately.
This will make maintenance easier, as it will be easier to find internal links that do not use the relref shortcode.

There is a reason to do this

This will make maintenance easier, as it will be easier to find internal links that do not use the relref shortcode.


fix: don't initialize S3 client on startup

Issue #, if available:
Description of changes:
Don't construct an S3 client until it is requested. Removes S3 client from cache if region changes.
Why is this change necessary:
The HTTP client initialization for the S3 client takes ~5s on rpi3.
It is not necessary to pre-construct an S3 client as that just increase the
service initialization time.
How was this change tested:
Tested load time on rpi3
Any additional information or context required to review the change:
This changes behavior of the getS3Client to also throw a DeviceConfigurationException if the config is invalid.
Previously this getter would always return the last valid client, or null if there never was one.
S3Downloader appears to be the only place that uses this factory.
Checklist:

[ ] Updated the README if applicable
[x] Updated or added new unit tests
[ ] Updated or added new integration tests
[ ] Updated or added new end-to-end tests
[ ] If your code makes a remote network call, it was tested with a proxy
[ ] You confirm that the change is backwards compatible

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This is fantastic! I'm sure this 5 seconds saved would be much appreciated by drivers in the car who is waiting for Nucleus to start! : )


Missing key segments in the parameter object in the latest OpenAPI refresh.

Describe the bug
Missing key segments in the parameter object in latest OpenAPI refresh. This must be something recent as it wasn't there when we last tested OpenAPI.Net.OData preview 1.0.10 in https://github.com/microsoftgraph/microsoft-graph-devx-api/issues/902.
To Reproduce
Steps to reproduce the behavior:

Download the latest OpenAPI file. e.g., v1.0 Application.yml.
Go to a path with an indexer e.g., '/applications/{application-id}'.
Scroll down to any operation object and inspect its parameter object.
The indexer will be missing in the parameter object.

Expected behavior
Indexers should be present in the parameter object e.g.,
Screenshots

The parameter should be declared on the path item but not just missing from the operation. Are you not seeing it at the path item level?

@peombwa, does AutoREST care whether params are declared on the path item or on the parameters object?

@irvinesunday, I'm not entirely sure as it is not covered in their tests. We will have to test to verify if it's even supported.

Sorry @peombwa, @baywet, I missed this, the parameters appear at the bottom of the path item, after the operations:

@peombwa  with this, AutoREST wasn't able to identify the segment param?


Unable to serialize type Update with v13.3.0-rc1

I updated my NuGet package to v13.3.0-rc1 today to try out the new Live Location and ChatSticker functionality released in 3.4 and experienced the below issue when attempting to serialize incoming JSON.
Seems to be related to the changes in commit 48f5b32100c2c6977a76a317020ee319537ccbcd that the snake case naming is not propagating correctly.
Testing JSON inserted at the bottom of the template
Steps to reproduce
To reproduce, have a test project referencing Telegram.Bot v13.3.0-rc1 and then call the following code
string jsonInput = "<update-json-captured-from-telegram>";
Update testUpdateFromStringObj = Telegram.Bot.Types.Update.FromString(jsonInput);
Update testUpdateJsonConvObj = JsonConvert.DeserializeObject<Update>(jsonInput);
string jsonFromStringOutput = JsonConvert.SerializeObject(testUpdateFromStringObj);
string jsonJsonConvOutput = JsonConvert.SerializeObject(testUpdateJsonConvObj);
Expected  behavior
Both testUpdateFromStringObj and testUpdateJsonConvObj should be populated with all values from the given JSON.
Actual behavior
JsonSerializationException is thrown with details:

Newtonsoft.Json.JsonSerializationException occurred
Message=Required property 'IsBot' not found in JSON. Path 'message.from', line 1, position 159.
Source=Newtonsoft.Json
StackTrace:
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.EndProcessProperty(Object newObject, JsonReader reader, JsonObjectContract contract, Int32 initialDepth, JsonProperty property, PropertyPresence presence, Boolean setDefaultValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.JsonConvert.DeserializeObject(String value, Type type, JsonSerializerSettings settings)
at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String value, JsonSerializerSettings settings)
at Telegram.Bot.Types.Update.FromString(String data)

Environment data
NuGet Package Version:
13.3.0-rc1
.NET Version:
.Net Framework 4.6.1
IDE:
VS2017
App:
WinForms and WebAPI
Testing JSON
The "from" section was manually changed to testing data, but the original gave the same error as this.
{"update_id":100,"message":{"message_id":8,"from":{"id":10050,"is_bot":false,"first_name":"Test","last_name":"User","username":"Testuser","language_code":"en"},"date":1511265251,"chat":{"id":10050,"type":"private","title":null,"username":"Test","first_name":"Testuser","last_name":"User","all_members_are_administrators":false,"photo":null,"description":null,"invite_link":null,"pinned_message":null},"forward_from":null,"forward_from_chat":null,"forward_from_message_id":0,"forward_signature":null,"forward_date":null,"reply_to_message":null,"edit_date":null,"author_signature":null,"text":"/testcommand","entities":[{"type":"bot_command","offset":0,"length":12,"url":null,"user":null}],"audio":null,"document":null,"game":null,"photo":null,"sticker":null,"video":null,"voice":null,"video_note":null,"caption":null,"contact":null,"location":null,"venue":null,"new_chat_member":null,"new_chat_members":null,"left_chat_member":null,"new_chat_title":null,"new_chat_photo":null,"delete_chat_photo":false,"group_chat_created":false,"supergroup_chat_created":false,"channel_chat_created":false,"migrate_to_chat_id":0,"migrate_from_chat_id":0,"pinned_message":null,"invoice":null,"successful_payment":null},"edited_message":null,"inline_query":null,"chosen_inline_result":null,"callback_query":null,"channel_post":null,"edited_channel_post":null,"shipping_query":null,"pre_checkout_query":null}

That definitely was caused by the latest update. We used global SnakeCaseNamingStrategy to get rid of excessive code in json related attributes. For now you can use one of the two solutions:

You can change ContractResolver to custom contract resolver with SnakeCaseNamingStrategy in JsonSerializerSettings (in case of WebApi in old ASP.NET I believe it's somewhere in GlobalConfiguration)

If I'm not mistaken you can do it like this (and I can be mistaken because I've only used ASP.NET Core):
var contractResolver = new DefaultContractResolver
{
    NamingStrategy = new SnakeCaseNamingStrategy()
}

GlobalConfiguration.Configuration.Formatters.JsonFormatter.SerializerSettings.ContractResolver = contractResolver;

But this solution will affect all json serialization in your project.

Or you can take the update as string and deserialize it yourself passing JsonSerializerSettings instance.

var settings = new JsonSerializerSettings
{
    ContractResolver = new DefaultContractResolver
    {
        NamingStrategy = new SnakeCaseNamingStrategy()
    }
}

Update update = JsonConvert.DeserializeObject<Update>(updateString, settings);

Thanks for the reply and suggestions for a workaround. I'll give it a shot later tonight.
I started with a potential fix where all the Type classes get their JsonObject attribute expanded with the NamingStrategyType=typeof(SnakeCaseNamingStrategy) attribute, which has worked sofar on my side in a test project.
Would that be the desired solve and if so, should I Branch > PR or Fork > PR?
Never sure which one which project uses


Episodes for Plex/Kodi are out of order

@maxpiva I figure you forgot, or I didn't notice if it got fixed

Should be fixed on 3.6.

I have a button to test it, so we'll see

This is fixed


module 'compat53.module' not found on Lua 5.3

I've got a machine where /usr/bin/lua is Lua 5.3.
tl$ readlink -f $( which lua )
/usr/bin/lua5.3
tl$ lua -v
Lua 5.3.3  Copyright (C) 1994-2016 Lua.org, PUC-Rio
tl$ ./tl
lua: .//tl.lua:1: module 'compat53.module' not found:
	no field package.preload['compat53.module']
	no file './/compat53/module.lua'
...etc

Running busted produces a lot of errors because there's no compat53 module, which makes sense since it's not needed on 5.3.

Noted. I can make it smarter to not need it when running on top of 5.3 but
for now you can install compat53 to silence these errors with no problems:
it is a noop module when running with 5.3. I'm using it to make tl produce
the same behavior over different Lua versions.


Handle {atom,safe} variant of OTP-25 call_fun2/3

This PR only handles the {atom,safe} variant: {atom,unsafe} appears to only happen in try blocks (example).
Also included is a check for {move,{literal,Fun},Dst} instructions that processes any literal functions. I'm a little stuck on how to handle replacing the function with its extracted equivalent (see 3e7c340341ea0cb46ca3eec9ed0d0025ff9ac638). Exporting these extracted functions would be the simplest way but I'm hoping there's a clever way to capture a local function instead so we can keep the current exports (just run/Arity).
connects #19

Thank you for starting to work on this!
Good find about the {move, {literal, fun tx_funs:min/2}, {x,0}}! To extract it, you can't use the same state because a state instance is made for a specific anonymous function extraction process. You need to call to_standalone_fun1(Fun, Options) (i.e. with the same options as the function being extracted). See the following code as an example:
https://github.com/rabbitmq/khepri/blob/0af07327fcff34c91072448b3df3605f58d41440/src/khepri_fun.erl#L2142-L2153
Now, I need to think about how we should handle this. Perhaps we need to modify the #standalone_fun{} record to have a place to store other "attached" extracted functions. khepri_fun:exec/2 will have to load all attached extracted functions.
It could be tricky if the attached function has a non-empty environment. That said, it's possible that the {literal, fun ...} construct will always reference external functions and thus will always have an empty environment (in which case we should assert for that).
The assembly code would be modified to reference the name of the extracted module & function instead:
%% Before:
{move, {literal, fun tx_funs:min/2}, {x, 0}}.

%% After:
{move, {literal, fun kfun_long_module_name_with_some_hash:run/2}, {x, 0}}.

Also, this should probably be two different patches in the end :-)

Pull Request Test Coverage Report for Build 573

0 of 3 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.6%) to 85.587%

Totals

Change from base Build 572:
-1.6%

Covered Lines:
1924

Relevant Lines:
2248

💛  - Coveralls

I opened #101 to address literal funs in move instructions.


Custom element does not exist (Fire tablet)

I have added the frigate card to my dashboard and works perfectly  fine in the PC, Iphone and Fire tablet 10.  However I can not get this to work on the lower models  of fire tablets.  I have a fire 8 tablet that I am using for display.  No matter which I use Fully kiosk browser, Native Home assistant app or web page I get the same.
Custom element does not exist: Frigate Card error message with red box.
I have cleared the cache in all browsers and rebooted nothing seems to work.  Is this something related to hardware capabilities?

i have the same on a samsung family hub tv (probably use webkit or something)

Have the same problem on bluestacks 5.

No matter which I use Fully kiosk browser, Native Home assistant app or web page I get the same.

Which specific Browser have you tried? Which version? I would suggest trying on Chrome 110+.

I played around on Browserstack and found I can reproduce this issue if I use very old versions of browsers (e.g. Chrome 70), so the issue is likely Javascript-based incompatibilities from old browsers or old hardware with old webview. I don't think supporting such hardware/browsers is the right use of the development cycles available, so I'm going to close this bug. I've added a browser support note in https://github.com/dermotduffy/frigate-hass-card/pull/1036 . I realize this is not a terribly satisfying answer, but I think it's a realistic one...

Not only spending development cycles, but it is very likely that adding support for such old browsers can potentially degrade the performance for other users in newer browsers.


*: change default charset from utf8 to utf8mb4

Required for https://github.com/pingcap/tidb/pull/7965/

@tiancaiamao PTAL

Please regenerate parser.go since you've modified parser.y.

LGTM

@kennytm PTAL

LGTM


Adding dependabot.yml file

We need to add dependabot.yml file as it helps us to keep our dependencies up to date. Every day, it checks your dependency files for outdated requirements and opens individual PRs for any it finds.
@AshutoshDash1999 please assign me this issue under gssoc'23.

Thanks, @Anshika-Jain02 for the suggestion. But we don't need it for now as we don't have any dependencies.


Connect to an instance without installing bionty / wetlab

Should be possible to connect to an instance without installing bionty / wetlab?
An R user of laminr who doesn't want to authenticate prior to connecting to an instance currently needs to install lamin-cli and fetch the instance info by running the following commands:
pip install lamin-cli
lamin connect laminlabs/lamindata
Rscript -e 'laminr::connect("laminlabs/lamindata")'

However, the second command fails if the user does not have wetlab installed:
$ lamin connect laminlabs/lamindata
ImportError: Python package for 'wetlab' is not installed.
If your package is on PyPI, run `pip install wetlab`

Could we change lamin-cli such that a user can just install lamin-cli instead of lamindb[bionty,wetlab] to be able to interact with these instances from R?

You're absolutely right and I will fix this today.

(Sorry, it wasn't an issue because people would have all of these things installed; but it really shouldn't be a necessity even when they use the Python API. They might not care about certain parts of the schema.)

Resolved here:

https://github.com/laminlabs/lamindb-setup/pull/883

Will be in a release today.

Awesome! Tysm!


Groups - Assign prefered language to open in certain Group

When I'm working, I order my groups for language.
Now: I change the group before open a file.
I want, maybe it's posible:

assign a language (js) in certain group
when open file with this language(js)
open the file in group assigned for that file language
when not assigned file to a certain group is open, the file is open in wherever group.

Example:
Group 1: assigned to javascript (also allow unassigned language)
Group 2: assigned to json (also allow unassigned language)
Group 3: assigned to python (also allow unassigned language)

Not a duplicate issue


LIME-815 - Updating firstNameMiddleName validation to be conditional …

What changed
Updated validator to set the max length of middleName/FirstName conditionally dependant on licence issuer, this is because DVA and DVLA have different max lengths for these fields

@ElliotMurphyGDS Theres one line causing the validation to fail across scenarios. Lets catchup tomorrow


(2024.04.02 and earlier) Windows NVIDIA instances in ap-southeast-2(Sydney) fail to launch

Bug description
Amazon Machine Images (AMIs) are used to spin up virtual desktops (VDIs) in RES with specific configurations. Each AMI has an associated ID that differs per region. The AMI ID configured in RES to launch Windows Nvidia instances in ap-souteast-2 (Sydney) is currently incorrect.
AMI-ID ‘ami-0e190f8939a996caf’ for this type of instance configuration is incorrectly listed in ap-souteast-2 (Sydney). AMI ID ‘ami-027cf6e71e2e442f4’ should be used instead.
Affected versions
This issue affects all RES version 2024.04.02 or earlier
Mitigation
The following mitigation has been tested on RES version 2024.01.01

Register a new software stack with the following settings

AMI ID: ami-027cf6e71e2e442f4
Operating System: Windows
GPU Manufacturer: NVIDIA
Min. Storage Size (GB): 30
Min. RAM (GB): 4

Use this software stack to launch Windows - NVIDIA instances

This is fixed on 2024.02

This issue was fixed in 2024.06 release. For 2024.04.02 and earlier refer to the solution here.