Fix editor behavior when core.commentChar is auto

Fixes #1512.
I didn't write a test for whether the feature works for releases; all that's changed is using # rather than auto, which doesn't seem very important.
There is also the extreme possibility that every candidate comment character is already in the message. In this case, i just use "auto", but I'm not sure if this is right.
I've not coded in Go, so there might be issues with code organization?

I want to say I'm sorry.... for all the wrong on my PC I've been doing... My husband is cheating on me... That's why I been on them.  looking for him... AND I DID


koord-descheduler: support evicting all bare pods in migration controller

Ⅰ. Describe what this PR does
This PR add a new arg EvictAllBarePods into MigrationController. If this arg is set as true, all bare pods including failed phase can be evicted. The default value is false. Users should know the risk and use this arg carefully because pods without OwnerRef cannot be re-created by default.
To implement this, I mocked the filter function in DefaultEvictor. Other functions used by MigrationController such as PreEvictionFilter are still be imported by the adapter.

Ⅱ. Does this pull request fix one issue?
fixes #2099

Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[ ] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/lgtm

/approve


Change the seq_length in Text preprocessing for BERT

Hi, I'm using bert to do a text classification but I want to change my seq_length to another, the document confused so much

How can I change the seq_length instead of 128 default(one input is only one sentence)? I read this demo

But which is the mode input? text_inputs or tokenized_inputs? Could you give me a whole process? Thanks a lot!

@YangHan-Morningstar ,please check link and confirm if your questions are answered.

OK, I have solve my question, just change the text_inputs to one element is ok, thanks a lot!


Fix:Discord broken link in  readme.md

Description
Closes:

https://github.com/elys-network/issues/issues/XXX
https://github.com/elys-network/issues/issues/XXX

What has Changed?
Discord link is broken. Updated it to the official one

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[ ] included the correct type prefix in the PR title
[ ] added ! to the type prefix if API or client breaking change
[ ] targeted the correct branch (see PR Targeting)
[x] provided a link to the relevant issue or specification
[ ] followed the guidelines for building modules
[ ] included the necessary unit and integration tests
[ ] included comments for documenting Go code
[ ] updated the relevant documentation or specification
[ ] reviewed "Files changed" and left comments if necessary
[ ] confirmed all CI checks have passed

Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...

[ ] confirmed the correct type prefix in the PR title
[ ] confirmed ! in the type prefix if API or client breaking change
[ ] confirmed all author checklist items have been addressed
[ ] reviewed state machine logic
[ ] reviewed API design and naming
[ ] reviewed documentation is accurate
[ ] reviewed tests and test coverage
[ ] manually tested (if applicable)

Deployment Notes
Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.
Screenshots and Videos
Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.

@cosmic-vagabond I've updated the link


Remove master and worker terminology from AP5GC docs

Kubernetes has removed master and slave terminology (see https://github.com/kubernetes/website/issues/6525); we should do the same in our docs.  Worker could also be removed.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3089f1d8-525e-cb37-394a-87212b4ce918
Version Independent ID: 89c621a7-0616-10e8-14a3-9939086994fd
Content: Azure Stack Edge virtual machine sizing
Content Source: articles/private-5g-core/azure-stack-edge-virtual-machine-sizing.md
Service: private-5g-core
GitHub Login: @b-branco
Microsoft Alias: biancabranco

@tomprice-msft
Thanks for your feedback! We will investigate and update as appropriate.

@tomprice-msft, many thanks for the feedback. I've updated the article with your suggested changes.

#please-close


Error with compiled Typescript code

LiveEdit is great - just getting the following error though:
Watching your project: com.xxxxx.com
Found 2:  change ./app/views/appointments/appointments-view-model.js<PHONE_NUMBER>0
16 Wed Dec 02 2015 12:36:23 GMT+1000 (E. Australia Standard Time)<PHONE_NUMBER>016
6806
Checking updated file:  ./app/views/appointments/appointments-view-model.js

---- Failed Sanity Tests on ./app/views/appointments/appointments-view-model.js

STDOut: ./app/views/appointments/appointments-view-model.js: line 3, col 5, Rede
finition of '__extends'.
./app/views/appointments/appointments-view-model.js: line 3, col 17, Possible st
rict violation.
./app/views/appointments/appointments-view-model.js: line 5, col 21, Possible st
rict violation.
3 errors
I've based my view models on the way the sample Friends app is coded (which is the compiled typescript code):
1  'use strict';
2
3  var __extends = this.__extends || function (d, b) {
4  for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
5    function __() { this.constructor = d; }
6    __.prototype = b.prototype;
7    d.prototype = new __();
8  };
Hope this can be fixed.
Many thanks
Janine

Uhm, did you copy lines 3-8 or were they generated?   My understanding is that block of code is not used anymore and just a waste of space.    If you delete 3-8 in that file; you should be good to go.

Hi -I based my code around the Nativescript Friends app - so copied the view model design from their.
Deleting has worked a treat!  - Many thanks - I just love your LiveEdit!
Janine


eventstat: 0.05.01 -> 0.06.00

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ColinIanKing/eventstat/releases.
meta.description for eventstat is: Simple monitoring of system events
meta.homepage for eventstat is: https://github.com/ColinIanKing/eventstat
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.05.02 with grep in /nix/store/yxb0mrxs94acbyy90l77058jpz6lj3zh-eventstat-0.05.02
found 0.05.02 in filename of file in /nix/store/yxb0mrxs94acbyy90l77058jpz6lj3zh-eventstat-0.05.02

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
eventstat

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/yxb0mrxs94acbyy90l77058jpz6lj3zh-eventstat-0.05.02 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A eventstat https://github.com/r-ryantm/nixpkgs/archive/277b9ae8f28990df78285e3e5605d49ed3107530.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/277b9ae8f28990df78285e3e5605d49ed3107530#eventstat

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/yxb0mrxs94acbyy90l77058jpz6lj3zh-eventstat-0.05.02
ls -la /nix/store/yxb0mrxs94acbyy90l77058jpz6lj3zh-eventstat-0.05.02/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

eventstat

Maintainer pings

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/ColinIanKing/eventstat/releases.
meta.description for eventstat is: Simple monitoring of system events
meta.homepage for eventstat is: https://github.com/ColinIanKing/eventstat
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.06.00 with grep in /nix/store/ihcr1jnr74gflps0xkggi7sdpnf4a4c4-eventstat-0.06.00
found 0.06.00 in filename of file in /nix/store/ihcr1jnr74gflps0xkggi7sdpnf4a4c4-eventstat-0.06.00

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
eventstat

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ihcr1jnr74gflps0xkggi7sdpnf4a4c4-eventstat-0.06.00 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A eventstat https://github.com/r-ryantm/nixpkgs/archive/1f6a258684679fff38f9c3006f66cd5923da73c8.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1f6a258684679fff38f9c3006f66cd5923da73c8#eventstat

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ihcr1jnr74gflps0xkggi7sdpnf4a4c4-eventstat-0.06.00
ls -la /nix/store/ihcr1jnr74gflps0xkggi7sdpnf4a4c4-eventstat-0.06.00/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

eventstat

Maintainer pings


Retrieve new NFT settings from space

New nft key will be added to space settings json. We need to be able to retrieve it via graphql

Closing, settings are now saved directly in the smart contract


⚠ Processors has degraded performance

In 652c89d, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 129 ms

Resolved: Processors performance has improved in 01de8e2.


[OTHER] move all socket function into a different file

What would you like to share?
Only focus on this component
https://github.com/Dun-sin/Whisper/blob/dbec99c68f63c606647ea2cef1d458a72ae83b1b/client/src/components/BuddyMatcher.jsx
move them into a file in lib folder called buddySocket.js put them in the same format as https://github.com/Dun-sin/Whisper/blob/main/client/src/lib/chatSocket.js

Can i work on this issue?

@Dun-sin Can I work on this issue?


How to replicate results for SWE-Bench with SWE-agent?

How can I replicate results for SWE-Bench with SWE-agent? Can you add detailed setup steps?

I see bunch of scripts here: https://github.com/princeton-nlp/SWE-agent/tree/main/scripts.
But no clear direction how to replicate it.

@karthikncode please help.

Let me close this issue in favor of #88


Add support for getting and sending raw transactions

Now you can grab the raw transaction associated with an id, and you can re-broadcast it as well. This will help exchanges that have started struggling with the mempool.

still needs:

api docs
api test
test for the Broadcast function (probably both in api and in tpool)
fix the way you select parents

I have a validation test in mind but this PR isn't ready for it yet.

Updated with review comments.

Why are we using  base64 encoding for this? Wouldn't JSON work just fine?

The original spec called for returning Transactions and Parents as a marshalled byte slice, which the encoding/json package automatically encodes as base64. We could return the transaction set as a []types.Transaction, types.Transaction encoded to JSON instead, which seems more correct to me. @DavidVorick can probably expand on why a []byte was chosen instead of a []types.Transaction

We definitely want the JSON as a []byte. Using Sia's internal encoding makes interop a huge headache. It would mean that api consumers would have to reimplement the encoding package in order to construct transactions.
AFAIK the only endpoint that exposes the encoding package is the miner one, but that's a special case because it's high performance and the manipulations are simple (just overwriting bytes in-place)

@lukechampine that's why it's called the raw endpoint. You aren't supposed to do anything with the data besides get and post, and you aren't supposed to manipulate it in between.
Giving users access to the actual transactions is a different endpoint.

I thought about the raw vs. json for a while longer, but I still feel convinced that raw is the right way to present this. The purpose of this endpoint is so that you can fetch and post transactions, not so you can see inside of the transaction pool. Seeing inside of the transaction pool would likely involve a completely different structure for the api.

Why would you want to have a separate get and post for transactions if they're opaque? Is this solely to support resubmitting existing txns? If so, why not just have a /resubmit route?
I don't think "raw" necessarily implies opaque. Why not use JSON? What is the downside?


How to use with chrome?

I'm trying to use this library in web server, chrome keeps throwing ERR_QUIC_PROTOCOL_ERROR , I'm using chrome flag --origin-to-force-quic-on. After further inspection I've got some logs and exact error message:
t=7591 [st=14]    QUIC_SESSION_VERSION_NEGOTIATION_PACKET_RECEIVED
                  --> versions = ["draft29"]
t=7591 [st=14]    QUIC_SESSION_CLOSED
                  --> details = "Client may support one of the versions in the server's list, but it's going to close the connection anyway. Supported versions: {Q050}, peer supported versions: {draft29}"
                  --> from_peer = false
                  --> quic_error = 20 (QUIC_INVALID_VERSION)
t=7591 [st=14]    QUIC_SESSION_CLOSED
                  --> details = "Client may support one of the versions in the server's list, but it's going to close the connection anyway. Supported versions: {Q050}, peer supported versions: {draft29}"
                  --> from_peer = false
                  --> quic_error = 20 (QUIC_INVALID_VERSION)
t=7591 [st=14] -QUIC_SESSION

From my reaserch on quic versions (I might be mistaken):
Q050 - one version before draft29
Q051 - draft29
The question is: how to get this library working with chrome? Or maybe better question: is it possible to get list library working witch chrome?
Thanks!

We send Alt-Svc. That should be sufficient in practice to make Chrome dial using the right version.

Sorry but I can't understand how this should help me getting QUIC working with chrome. Could you provide siple working example?


Network Interface Cleanup

Description
Brief attempt to clean up some of the Network Interfaces and standardize them on config values
Test Steps

Checklist:

[x] I have tested my changes. No regression in existing tests.
[x] I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/bot run formatting

Hi @holden-zenith, thank you for this clean-up PR. It looks at all network interfaces and let them use the same set of macros.
I miss a summary in "Description" here above.
I went through all changes and noted the following:
Cleaning up static instances of xLLMNR_MACAddress and xMDNS_MacAddress, although the latter should be spelled as xMDNS_MACAddress.
    extern const MACAddress_t xMDNS_MacAddress;     // Mac
    extern const MACAddress_t xMDNS_MACAddressIPv6; // MAC

The following "local" macros will be deprecated:
niEMAC_HANDLER_TASK_NAME
niEMAC_HANDLER_TASK_STACK_SIZE
niEMAC_HANDLER_TASK_PRIORITY
nwRX_TASK_STACK_SIZE
Macros now in use:
● EMAC_HANDLER_TASK_NAME is defined in NetworkInterface.h as "EMAC". It would be nice if the name can be set by the user.
Also, it would be nice to see a specific EMAC name like "EMAC_STM32Fx".
● ipconfigEMAC_TASK_STACK_SIZE with a default of ( 8 * configMINIMAL_STACK_SIZE ) words. See remark below.
● ipconfigEMAC_HANDLER_TASK_PRIORITY, defaults to high which is good.
About the stack size of the EMAC task:
There was a PR #435 : "Rename configEMAC_TASK_STACK_SIZE to the more correct macro name ipconfigEMAC_TASK_STACK_SIZE_WORDS."
Mind the extension _WORDS in ipconfigEMAC_TASK_STACK_SIZE_WORDS.
The stack sizes for the EMAC tasks vary between (2*configMINIMAL_STACK_SIZE) and (8*configMINIMAL_STACK_SIZE).
So it would be safe to set a default of 8 times the minimal stack size, except that users with little memory will complain: 4 KByte in stead of 1 KByte is used for the stack of the EMACtask. 3 KByte can be a lot!!!
We never came up with a satisfying solution, but wasting 3 KB on a small CPU is also not very satisfactory.
You replaced EMAC_CONSIDER_FRAME_FOR_PROCESSING with ipCONSIDER_FRAME_FOR_PROCESSING, but why not everywhere?
In NXP1060\NetworkInterface.c you s/ipCONSIDER_FRAME_FOR_PROCESSING/EMAC_CONSIDER_FRAME_FOR_PROCESSING/. That is the other way around.
In \linux\NetworkInterface.c, you change s/EMAC_CONSIDER_FRAME_FOR_PROCESSING/ipCONSIDER_FRAME_FOR_PROCESSING/.
In all other network interfaces, EMAC_CONSIDER_FRAME_FOR_PROCESSING is still used. Why?
In LPC17xx\NetworkInterface.c, you define ipCONSIDER_FRAME_FOR_PROCESSING without ever using it?
In the interface, use xPhyObject.ulLinkStatusMask in stead of calling the access function GetPhyLinkStatus() or so. I don't see an advantage of that. xxxGetPhyLinkStatus() should access mentioned field.
Added a new trace macro: iptraceEMAC_TASK_STARTING(). Great.
The macros EMAC_IF_RX_EVENT are now declared in NetworkInterface.h in stead of in the interfaces.
But STM32Hxx\NetworkInterface.c is still defining the EMAC events. Why, forgotten?
Some strange code \libslirp\MBuffNetworkInterface.c :
    if( pxDriverCtx->xInterfaceState == pdFALSE )
    {
        pxDriverCtx->xInterfaceState = pdFALSE;

        if( xPhyObject.ulLinkStatusMask != 0U )

Next time I will give inline comments as usual.

@htibosch
EMAC_HANDLER_TASK_NAME can be moved and changed to ipconfigEMAC_HANDLER_TASK_NAME.
ipconfigEMAC_TASK_STACK_SIZE can be renamed to ipconfigEMAC_TASK_STACK_SIZE_WORDS.
If the stack sizes are meant to be user definable than you could either undef and redefine ipconfigEMAC_TASK_STACK_SIZE or perhaps have a NetworkInterfaceConfigDefaults.h file that gets included at the beginning of FreeRTOSIPConfigDefaults.h which would define values such as ipconfigEMAC_TASK_STACK_SIZE, ipconfigDRIVER_INCLUDED_RX_IP_CHECKSUM, ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM, ipconfigETHERNET_DRIVER_FILTERS_FRAME_TYPES, ipconfigETHERNET_DRIVER_FILTERS_PACKETS, etc which are NetworkInterface dependent. Otherwise if they are just to be definable by NetworkInterface then you could set a constant value at the beginning of each NetworkInterface file, very similar to how xBufferAllocFixedSize is used in the two different BufferAllocation files currently.
For EMAC_CONSIDER_FRAME_FOR_PROCESSING, this actually didn't replace ipCONSIDER_FRAME_FOR_PROCESSING but is the inverse of it. One is meant to be used in the Network Interfaces and the other is used in FreeRTOS_IP.c. Currently ipCONSIDER_FRAME_FOR_PROCESSING is used in both instances but are defined as inverses of each other which is a bit confusing. I don't entirely follow your comments on NXP1060, linux, and NXP1060 as they all just use the EMAC_CONSIDER_FRAME_FOR_PROCESSING as defined in NetworkInterface.h and don't define either ipCONSIDER_FRAME_FOR_PROCESSING or EMAC_CONSIDER_FRAME_FOR_PROCESSING.
The reason I used GetPhyLinkStatus() instead of xPhyObject.ulLinkStatusMask is because not all interfaces have implemented xPhyObject yet and xGetPhyLinkStatus() is compatible when using multiple interfaces because of the NetworkInterface_t parameter.
You are correct about STM32Hxx and those definitions need to be deleted.
The code in libslirp seemed redundant so I removed the pxDriverCtx->xInterfaceState = pdFALSE; part after checking the interface is already down.
The general idea of all this in my mind was to slim down and make each NetworkInterface file as similar as possible to eventually use a common NetworkInterface file with the unique hardware portions defined using a custom port NetworkInterface file, similar to what I mentioned when I asked about using the CMSIS standard drivers.

@htibosch Should I break this up into smaller, more easily reviewable changes? There are a few things that don't affect running code at all.

@HTRamsey
Thanks for taking time to create this PR.

If the stack sizes are meant to be user definable than you could either undef and redefine ipconfigEMAC_TASK_STACK_SIZE or perhaps have a NetworkInterfaceConfigDefaults.h file that gets included at the beginning of FreeRTOSIPConfigDefaults.h which would define values such as ipconfigEMAC_TASK_STACK_SIZE, ipconfigDRIVER_INCLUDED_RX_IP_CHECKSUM, ipconfigDRIVER_INCLUDED_TX_IP_CHECKSUM, ipconfigETHERNET_DRIVER_FILTERS_FRAME_TYPES, ipconfigETHERNET_DRIVER_FILTERS_PACKETS, etc which are NetworkInterface dependent.

This seems to be a good idea for keeping network interface specific configurations, but as it involves adding a new file to each network interfaces it might break some of the existing projects.
Just wondering if you had a chance to build/validate the changes on any of these interfaces.

@tony-josi-aws I can only do so for a couple of the interfaces unfortunately. There are a few changes not involving running code that I think could be made safely though, which is why I was wondering about breaking up this PR into smaller ones.

There are still checks for PHY_LS_HIGH_CHECK_TIME_MS in several of the interfaces, which is handled in FreeRTOSIPDeprecatedDefinitions.h now.
The definitions for ipconfigPHY_LS_HIGH_CHECK_TIME_MS will never be included since it is defined in FreeRTOSIPConfigDefaults.h.
The iptraceEMAC_TASK_STARTING(); could safely be added if it is added to IPTraceMacroDefaults.h.
The config files I deleted are no longer needed as they don't do any configuration anymore in v4.0 and thus aren't used anywhere in the tests (the standard source files are used instead of the copies in the unit-test folder).

As far as including the standard config macros that change things like stack size and such, these should be held off until more extensive testing can be done, which unfortunately is a bit of a nightmare considering how many interfaces there are. You could do individual PRs for each interface but I believe parallel PRs like that are discouraged.

@tony-josi-aws did you have any thoughts on this? Or perhaps any other areas that I could help with?


🔧 stages: Add org.osbuild.rhsm stage to configure RHSM

Add new org.osbuild.rhsm stage to configure to configure RHSM DNF
plugins. The stage currently supports only enabling / disabling the DNF
plugins. The stage's configuration schema allows extending it in the
future to configure other aspects of RHSM if needed.
The schema specifies each DNF plugin as an explicit object. The reason
is that although currently only setting of one common option (enabled)
is allowed, the subscription-manager plugin's configuration actually
allows one additional plugin-specific option. The stage may support
setting it in the future, which will be easier with distinct objects for
each plugin.
Changes included in the PR:

new org.osbuild.rhsm stage
updated SPEC file with a new dependency python3-iniparse, needed by the org.osbuild.rhsm stage
updated the test/data/manifests/f32-build{,.mpp}.json to include python3-iniparse and regenerated other manifests by running make --always-make test-data.
added necessary test data to test the org.osbuild.rhsm stage

CI tests finally passed. I believe that this PR should be finally in a good shape for merging. :fireworks: Thanks for all the comments, they were very helpful!

CI tests finally passed. I believe that this PR should be finally in a good shape for merging. :fireworks: Thanks for all the comments, they were very helpful!


Copy billing data during export/import

Checklist

[ ] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated.
[ ] Changelog entry has been written

Billing data for environments is not currently copied during an export/import.
TODO:

[X] Copy the created date for environments
[ ] Copy the storage data for environments

Depends on changes in the lagoon API before this will work:

https://github.com/amazeeio/lagoon/pull/2464
https://github.com/amazeeio/lagoon/pull/2459

Changelog Entry

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

billing is not part of lagoon anymore


[terra-paginator] The screen reader isn't announcing the PageLabel.

Summary
fixed- The screen reader isn't announcing the PageLabel.
What was changed:
Added VisuallyHiddenText with pageLabel to support screen reader users.
Why it was changed:
Screenreader is not accurately announcing the PageLabel passed.
Testing

This change was tested using:

[ ] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[ ] No tests are needed

Reviews
In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:
UXPLATFORM-9806

Thank you for contributing to Terra.
@cerner/terra

@AH106586Harika  Can you update before and after screen reader response screenshots

@AH106586Harika Can you update before and after screen reader response screenshots

Updated.


loans - allow DUSD to contribute to 50% of total collateral

What would you like to be added:
This feature allows DUSD to be counted towards the DFI requirement for vault collateral, where collateral factor = 99%.
Simply put, DUSD proportion + DFI proportion ≥ 50%
Examples
30% DFI, 40% DUSD, 30% dBTC :white_check_mark:
50% DUSD, 50% dBTC :white_check_mark:
100% DUSD :white_check_mark:
For the upcoming hard fork, we will include DUSD on the 50% calculation check. These are checked on two scenarios:

[x] Removing collateral

[x] Taking a loan

[x] Add a feature flag since this will only be enabled after the hard fork block

Updated per feedback to add vault collateral sum of DFI and DUSD (showing an error state and the normal state)

Latest update on drawer modal.
What changed:

Removed vault share in the modal - focusing the attention of the modal on vault requirement
Vault requirement only pertains to DFI and DUSD - however, we will still display this component to all the other collateral tokens as they still affect the calculation of vault requirement. The /50% in the right part is fixed to 50% as the vault requirement needed to be fulfilled
Updated designs below are applied to both add/remove collateral tokens and to all collateral tokens (even dBTC/USDT/USDC)

Screens: https://www.figma.com/file/SDIpZciuxJlUf4xf8yheiY/PRDCT---Mobile-Light-Wallet?node-id=9531%3A297428

@jtlntno-des @thedoublejay


Fix esp_bt_controller_mem_release()

Region boundaries may not exactly match the regions defined in soc_memory_regions.
We know we're releasing DRAM, so use DRAM caps directly.
Fix boundary checks in heap_caps_add_region_with_caps.
Fixes https://github.com/espressif/esp-idf/issues/1277

Isn't the change to components/heap/heap_caps_init.c enough to fix everything?

Hi @rojer,
Thanks for sending this. We have a fix in the pipeline for this as well, and it should be merged in the next day or so. Will let you know.
FWIW, the simpler range check in this PR disallows adding a region that's within an existing heap (maybe you allocate some memory via malloc() and then re-register it as a new heap capability). This may seem like a wacky use case but it can be useful for creating your own memory pools. The bug is an off-by-one in the existing checks.
Fix coming shortly. We're also going to add esp_bt_controller_mem_release() to our integration tests so it shouldn't break like this again.

ok, i'll close this and wait for a proper fix then. thanks!


Support toggling individual bevy_diagnostic plugins at runtime

What problem does this solve or what need does it fill?
Toggle diagnostics at runtime (e.g. with a keybind) without recompiling or restarting the app.
What solution would you like?
There isn't really a standard way to do this, but usually there's some resource with a bool inside.
What alternative(s) have you considered?
Restarting the app with a different LOG_FILTER to fully disable / enable all bevy_diagnostic logs. This requires a restart, lacks the granularity to target specific diagnostic plugins, and only disables the logging, not the collection of diagnostics (though that's probably fine).

it's already possible to disable logging at runtime:
use std::time::Duration;

use bevy::{
    diagnostic::{DiagnosticsStore, FrameTimeDiagnosticsPlugin, LogDiagnosticsPlugin},
    prelude::*,
    time::common_conditions::on_timer,
};

fn main() {
    App::new()
        .add_plugins((
            DefaultPlugins,
            FrameTimeDiagnosticsPlugin,
            LogDiagnosticsPlugin::default(),
        ))
        .add_systems(
            Update,
            toggle.run_if(on_timer(Duration::from_secs_f32(10.0))),
        )
        .run();
}

fn toggle(mut store: ResMut<DiagnosticsStore>) {
    for diag in store.iter_mut() {
        info!("toggling diagnostic {}", diag.path());
        diag.is_enabled = !diag.is_enabled;
    }
}

in my opinion this is preferred over stopping collection as it means better stats when starting to log them

I see. That's really hard to find in the documentation.


update reset

i was able to reproduce https://github.com/adafruit/Adafruit_CircuitPython_AD569x/issues/3. also saw the same behavior that it did work with other boards (esp32-s3 tft feather and rp2040 feather). i think that the reset() function was raising the error because the DAC was resetting before the command was being acknowledged over I2C (this is noted in the arduino driver). i updated the function to not raise

@ladyada

yay thanx!


Implement support for different task_types in one multi-modal-chain

The existing multi-modal example (MMIMDB) is aimed to process that classification task only.
However, the rating prediction is mostly a regression task.
To solve this task, the CNN classification block and other regression blocks should be combined in one chain.
The corresponding changes in core logic, validation rules, and test should be implemented/

Current version of FEDOT supports multimodal data using API, so I think this issue can be broaded to a general multimodal pipeline case


500 error when accessing repo on web (context deadline exceed, LastCommitCache related)

Gitea Version
commit d47798ccc72236fa239834583ae8367a16ab3fbe
Git Version
2.33.0
Operating System
Debian 11
How are you running Gitea?
built from source with Go 1.17.2, Node 14.17.6 (npm 6.14.15) on Ubuntu 20.04. Running as systemd service on production mode. Connected to a PostgreSQL 14 instance on separate server.
Database
PostgreSQL
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
https://gist.github.com/bagasme/5c5dc41a48d8cea354b0f68fc6d2f6bd
Description
I'm trying to access one of my repo (a local copy of git.git) on the web interface (at https://gitnode.io/bagas/git). It returns 500 error instead of showing the repo contents. Going through log, the error occurs at renderDirectoryFiles(), but before it logs LastCommitCache stuff.
Screenshots
(not relevant, since the 500 error page is generic).

This is going to be related to #16467 - something will have changed that that PR relied on and now instead of the error being ignored/expected it's being propagated up.
I'll take a look.

Well given a feature I made caused it...
Repo view should now be a lot more snappy for big repos.

Well given a feature I made caused it...

right.. still thanks.

Repo view should now be a lot more snappy for big repos.

it does feel that way. btw I was only getting 500s on larger™ repos and now I'm not so that's great. 🚀


nixos-rebuild fails due to builder.pl - Possible unintended interpolation of @storeDir in string

Describe the bug
As the title suggests, I am trying to rebuild my system with nixos-unstable being at c3aa7b8938b17aebd2deecf7be0636000d62a2b9 commit.
Logs:
       > Possible unintended interpolation of @storeDir in string at /nix/store/b8cv67wx64j0m00f49g3qxx1yaz4hmqd-builder.pl line 49.
       > Global symbol "@storeDir" requires explicit package name (did you forget to declare "my @storeDir"?) at /nix/store/b8cv67wx64j0m00f49g3qxx1yaz4hmqd-builder.pl line 49.
       > Execution of /nix/store/b8cv67wx64j0m00f49g3qxx1yaz4hmqd-builder.pl aborted due to compilation errors.

Steps To Reproduce
Steps to reproduce the behavior:

Run sudo nixos-rebuild switch

Expected behavior
Rebuilds and switches the configuration normally
Additional context
Even the NixOS ISO can not be built.
Notify maintainers
Pinging @emilazy @max-privatevoid who touched the nixos-rebuild script a while ago. Also CC @SuperSandro2000
Though it's more of a builders.pl issue.
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"

 - system: `"x86_64-linux"`
 - host os: `Linux 6.10.4-xanmod1, NixOS, 24.11 (Vicuna), 24.11.20240814.c3aa7b8`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.2`

Add a :+1: reaction to issues you find important.

What is the stack trace? Something one stack up is missing.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/buildenv/builder.pl#L49

Turns out this was because of a corrupted nix store, never had the problem after repairing.


It is possible to combine Honda's and Toyota's giraffe in the same circuit board?

giraffe is an open hardware project, but Honda's and Toyota's giraffe are using different circuit layout
however I wonder about  it is possible to combine these 2 hardware into one.
If not, what reasons cause they must be 2 different hardware?

Not sure if it's possible or worthwhile.  Honda and Toyota use different connectors to connect to the car.  If you wanted all 4 connectors (2 honda and 2 toyota) in addition to the panda connector it becomes a much bigger board.  Some vehicles don't have room for a bigger board.  A giraffe is a vehicle adapter and it generally makes sense to keep it separate for each make/model with different requirements to keep complexity low and board size smaller.
With that said it's open source if you really want it on one board your probably going to have to lead that effort yourself.


custom exceptions for session stub

[Current coverage][cc-pull] is 52.17%

Merging [#16][cc-pull] into [master][cc-base-branch] will increase coverage by 8.01%

@@             master        #16   diff @@
==========================================
  Files             6          8     +2
  Lines           231        276    +45
  Methods          54         67    +13
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            102        144    +42
- Misses          129        132     +3
  Partials          0          0

Powered by Codecov. Last updated by [dac9d40...8755bc5][cc-compare]
[cc-base-branch]: https://codecov.io/gh/tidal/WampWatch/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/tidal/WampWatch/compare/dac9d408adeb53505f910a7215313f0b3e556dcc...8755bc52747888443888cefb177a9c9092d781c3?src=pr
[cc-pull]: https://codecov.io/gh/tidal/WampWatch/pull/16?src=pr


example R: add the librpma example

In this example we want to introduce to you a basic way of accessing
Persistent Memory when it is installed in a remote system.
Remote Persistent Memory (or RPMem for short) is a way of doing this
via a network by making use of the Remote Direct Memory Access (RDMA)
technology.
This example is an introduction to RPMem. We will guide you briefly through
setting up all required hardware and software components and verifying whether
the connection works properly. Having that, we will show you how to access
Persistent Memory on a remote system using the librpma library.
After completing this example you will know:

what is RPMem and what it is good for,
how RPMem is different comparing to PMem,
what hardware and software components are required to start using RPMem,
how to verify whether the RDMA network works properly,
how to use librpma API to:
establish a connection,
prepare memory for remote manipulation,
manipulate memory on the remote system,
assure persistency of stores to the remote system.

Step-by-step you will:

test the connection on the basic level using ping,
test the connection RDMA capabilities using rping,
review an application focusing on establishing a connection,
review an application reading remote system's memory and writing it back
in the persistent manner.

Co-authored-by: Oksana Salyk<EMAIL_ADDRESS>Co-authored-by: Jan M Michalski<EMAIL_ADDRESS>Signed-off-by: Lukasz Dorau<EMAIL_ADDRESS>

This change is

Replaced with https://github.com/pmemhackathon/hackathon/pull/1


Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'api')

  const appLoading = createApp(AppLoading)   appLoading.mount('#appLoading')   const app = createApp(App)   appLoading.unmount()   app.mount('#app')
index.js?v=fc2c00c9:4404 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'api')
at Object.set (index.js?v=fc2c00c9:4404:36)
at setActiveAppRecord (index.js?v=fc2c00c9:3089:29)
at async index.js?v=fc2c00c9:4506:7

Duplicated #356, We've fixed it in v7.3.0. Let's wait for the release. (You can also try v7.3.0-beta.1 now)

Fixed in v7.3.0


[TextField] Text going below underline

Problem description
When typing in a textfield with maxRows set to n, the text will actually go to n+1 rows and be visible below the underline.

Steps to reproduce
Create a textfield and set the rowsMax to any number. Start typing into the textfield and go to what should be the last line, the text will drop down to a new row below the underline.
This can be reproduced even on the material-ui components page on the multiline example:
http://www.material-ui.com/#/components/text-field
Versions

Material-UI: 0.15.0
React: 15.0.2
Browser: Firefox 45.1.1 and Chrome 50.0.2661.94

I think event.preventDefault() on keydown event can fix the issue.

Looks like this was addressed in #4322


Deploy backend

LGTM, but we already have a requirements.txt in the back-end directory. Now there are three requirements.txt files. Do we need all three? Or could we just keep one of them?

We need one in the root directory, We can keep the current one if there are no conflicts with the one I just pushed. I don't know if we also need one in the back-end folder, I wasn't the one that added the one in the back-end. But I am guessing we need it when we run manage.py locally. So I'll leave it and we'll have two.


Add Logs interface

Logs interface, implemented by LogsInGist and LogsOnServer, which will return the address of an Action's log file, depending on whether the ejb is deployed standalone or together with charles-rest.
If it's standalone, then each log file will be written in a secret Github Gist and the link to that gist is returned to the client. If it's not standalone, then a link to charles-rest's logs [endpoint] (https://github.com/amihaiemil/charles-github-ejb/blob/master/charles-rest/src/main/java/com/amihaiemil/charles/rest/LogsResource.java) will be returned.
Important:
System property charles.rest.logs.endpoint should contain the rest endpoint which fetches the logs by name (e.g. www.example.com/charles/api/logs/. If this property is not set then it's considered that the ejb is deployed standalone and the LogsInGist flow will be accessed.

Ticket #38 originated form here

done


Small fix to iOS support

Add ONLY_ACTIVE_ARCH=NO to the xcode call because it is required by the latest xcode.
For the iOS example, you would expect AppKit.h to be included by the imported module. It is, but at the same time it is ignored for performance reason since none of the imported module services are used. This will be fixed in a future PR. For now, we add the include locally as it is a better example and happen to avoid the problem.

:shipit:

test osx please

+1

oops, I do not know why I ran it on osx since cocoa is skipped: http://jenkins.gresil.org/jenkins/job/CI Github OSX/84/testReport/tests.nitcs.lib/cocoa/


Add ability to remove trace sets from Trace Explorer

Fixes #336
Remove button appears on hover

When window is made smaller the remove button would still appear

Clicking on remove button deletes the trace, does the same as right-click->'Delete Trace'

Tooltip added to remove button:

Wondering what tooltip should we add to clarify that the buttons deletes an experiment and not the trace files. Perhaps something like "Delete Trace Set"? @ebugden, any thoughts?

Do we need to have a warning dialog box asking the user to confirm it?

Personally, I'm comfortable merging without a confirmation dialogue and waiting for user feedback on this.

I don't think the average user (my guess of an average user: ~1 GB traces, 1-2 traces opened together) would be bothered that there's no confirmation
But I think it's probable that users dealing with massive traces and complex analyses would want a confirmation box (ex. Because they don't want to accidentally lose all the analysis configuration work they've done, or because it takes a long time to complete analyses again).

Remove button is aligned with trace group name:

Added warning dialog box to confirm action:

Is it correct that clicking this close-box merely removes the traces from the UI of the viewer? The user could add them again, if it were removed by mistake? If that's correct, then maybe the correct verb is "Remove traces from Trace Viewer"? I'd lean away from confirming a non-destructive action, but it's a bit of a judgement call.

Is it correct that clicking this close-box merely removes the traces from the UI of the viewer? The user could add them again, if it were removed by mistake? If that's correct, then maybe the correct verb is "Remove traces from Trace Viewer"? I'd lean away from confirming a non-destructive action, but it's a bit of a judgement call.

What it does it removes the traces from the trace viewer UI and from the trace server back-end. But, the actual traces files are not deleted from the local file system.

Requested change:

[ ]  Button should be aligned with the trace group name (top right of the box). Otherwise when there are multiple files in the group it looks like you're deleting a particular file instead of all of them

🌈 Thank you for this improvement! These are great design choices:

Having the button appear on hover keeps the widget visually clean and then draws attention to the button at a time the user might need it.
@mirsky-work's suggestion to highlight the button when you hover directly over it clearly communicates that the user can interact with this button.

I've implemented the requested changes as well as added a warning dialog box to confirm delete action

Something related to this PR is that the right-click context menu currently lists this same "Remove Trace from Trace Viewer" action as "Delete Trace". For consistency. This context menu should be changed to match the tooltip and confirmation "Remove Trace", but that has to do with #277 and would be a separate PR (I added a comment in that issue).
Context menu label for the same action as this PR: "Delete Trace"

Is it correct that clicking this close-box merely removes the traces from the UI of the viewer? The user could add them again, if it were removed by mistake? If that's correct, then maybe the correct verb is "Remove traces from Trace Viewer"? I'd lean away from confirming a non-destructive action, but it's a bit of a judgement call.

What it does it removes the traces from the trace viewer UI and from the trace server back-end. But, the actual traces files are not deleted from the local file system.

@ssmagula Removing the traces from the viewer is not entirely without consequence because you lose the analysis layout/configuration and also I believe all the analyses and indexing would need to be re-run which for large traces could be time consuming.

Requested changes:

[ ]  The tooltip label ("Delete trace from trace viewer") and confirmation messages ("Remove traces from trace viewer") should be the same (since they refer to the same action).

Thanks for the update!

Before merging, please squash (combine) some of your commits. This PR doesn't need to be 8 commits.

Thanks, all for clarifying. I grasp the main issues, now.
Short term: Let's change the labeling in the UI
from "Opened Traces" to » "Trace Sets"
This will enable the UI to use "Remove Trace Set" (on hover of close-box, and on right-click) to refer to the action of getting rid of this element ("trace group" seems equally clear, and we need to formalize our nomenclature, see below). The word "delete" implies "destruction that is non-recoverable." When a user gets rid of a trace set, the user will lose the indexing and any config, but this can be redone so in my opionion, that's still a recoverable action. My gut is that confirming a recoverable action is not needed. But I'll defer to those who better know the pain of losing a giant trace set.
This discussion is a great example of why crystal clear nomenclature is vital. We (the product development team) use the word "Traces" to refer to both "a single trace data file" and "a group or set of trace data files, which have already been indexed, and may already be configured by the user"
How might we even further clarify these nouns to the user? If we are finding it hard to refer to these core nouns in a non-ambiguous way, how will users feel in the product?

Recommended:
A single trace file should have an icon and label that communicates "a single trace data file"
A group of "trace data files" should similarly have a label and an icon that communicate "multiple trace data files" Maybe an acronym representing the trace format is also useful info to help disambiguate this set vs. that set?
If people agree, I can write the user story for this

Thank you for weighing in on this topic @ssmagula!

ssmagula: Short term: Let's change the labeling in the UI from "Opened Traces" to » "Trace Sets"
This will enable the UI to use "Remove Trace Set" (on hover of close-box, and on right-click) to refer to the action of getting rid of this element ("trace group" seems equally clear, and we need to formalize our nomenclature, see below).

I can see how changing the widget label from "Opened Traces" to "Trace Sets" would clarify some things, but this change should be proposed and debated in a separate issue and it is out of the scope of this PR in my opinion. Can you create a separate issue for this and we can discuss there?
In the mean time I changed this PR's title to more accurately reflect the changes that are proposed here. (We can use the language "trace set" in the commit log even if it's not yet in the UI because on the implementation side of things it's relevant to make the distinction between a "trace" and a "trace set"/"trace group" (formerly "experiment"))

ssmagula: The word "delete" implies "destruction that is non-recoverable." When a user gets rid of a trace set, the user will lose the indexing and any config, but this can be redone so in my opionion, that's still a recoverable action. My gut is that confirming a recoverable action is not needed. But I'll defer to those who better know the pain of losing a giant trace set.

This PR already lave this action as "Removing a trace". I agree that "delete" shouldn't be used to describe this action (unrelated to this PR: this needs to be changed in the right-click context menu, see my comment on #277)

ssmagula: This discussion is a great example of why crystal clear nomenclature is vital. We (the product development team) use the word "Traces" to refer to both "a single trace data file" and "a group or set of trace data files, which have already been indexed, and may already be configured by the user"
How might we even further clarify these nouns to the user? If we are finding it hard to refer to these core nouns in a non-ambiguous way, how will users feel in the product?

Recommended:
A single trace file should have an icon and label that communicates "a single trace data file"
A group of "trace data files" should similarly have a label and an icon that communicate "multiple trace data files" Maybe an acronym representing the trace format is also useful info to help disambiguate this file vs. that file?
If people agree, I can write the user story for this

I agree that we should have a discussion about nomenclature, but again in a separate issue. Can you make a separate issue?
One of the reasons this nomenclature discussion isn't totally obvious is that some trace formats (ex. CTF) are already a collection of several trace files (although you're never really looking at them individually?).

Thanks everyone for the weighing in. I agree that Remove is a better term than Delete, and the confirmation would probably be more annoying than useful, as it's a recoverable operation.

A single trace file should have an icon and label that communicates "a single trace data file"
A group of "trace data files" should similarly have a label and an icon that communicate "multiple trace data files" Maybe an acronym representing the trace format is also useful info to help disambiguate this file vs. that file?

@ssmagula, the distinction is already communicated today. Trace sets list the containing traces:

mirsky-work: I agree that [...] the confirmation would probably be more annoying than useful, as it's a recoverable operation.

Ok let's remove it then since several folks seem to agree. Not having a confirmation was my first reflex. @hriday-panchasara could you make this additional change?

[ ] Remove confirmation box

A single trace file should have an icon and label that communicates "a single trace data file"
A group of "trace data files" should similarly have a label and an icon that communicate "multiple trace data files" Maybe an acronym representing the trace format is also useful info to help disambiguate this file vs. that file?

@ssmagula, the distinction is already communicated today. Trace sets list the containing traces:

I made an issue #561 to continue the discussion about this. Left some thoughts there.

Just a quick note about the confirmation message. To avoid to show it all the time (and be annoying) there could be check-box Don't show again and the user's selection is then persisted. With this the users get informed about what happens and can choose to not see the warning again.

My preference would be to merge this without a confirmation box. Then, if users mention that they're frustrated because they're accidentally deleting complex analysis setups we can add a confirmation box (maybe that shows only when the traces are large i.e. have a large number of events)

bhufmann: To avoid to show it all the time (and be annoying) there could be a check-box Don't show again and the user's selection is then persisted. With this the users get informed about what is going to happen and can choose to see or to not see the warning again.

I think having a "Don't show again" checkbox makes more sense in a situation that involves risk (ex. "Are you sure you want to automatically connect to this network in the future"), but it this situation (removing a trace set) we think that in most cases there isn't significant risk associated with it (because for most trace sets it takes maybe a minute max to redo the all the analyses the user had open).

mirsky-work: I agree that [...] the confirmation would probably be more annoying than useful, as it's a recoverable operation.

Ok let's remove it then since several folks seem to agree. Not having a confirmation was my first reflex. @hriday-panchasara could you make this additional change?

[ ]  Remove confirmation box

A single trace file should have an icon and label that communicates "a single trace data file"
A group of "trace data files" should similarly have a label and an icon that communicate "multiple trace data files" Maybe an acronym representing the trace format is also useful info to help disambiguate this file vs. that file?

@ssmagula, the distinction is already communicated today. Trace sets list the containing traces:

I made an issue #561 to continue the discussion about this. Left some thoughts there.

I've removed the confirmation box

The behaviour looks good to me! Thanks for the update.

My preference would be to merge this without a confirmation box. Then, if users mention that they're frustrated because they're accidentally deleting complex analysis setups we can add a confirmation box (maybe that shows only when the traces are large i.e. have a large number of events)

bhufmann: To avoid to show it all the time (and be annoying) there could be a check-box Don't show again and the user's selection is then persisted. With this the users get informed about what is going to happen and can choose to see or to not see the warning again.

I think having a "Don't show again" checkbox makes more sense in a situation that involves risk (ex. "Are you sure you want to automatically connect to this network in the future"), but it this situation (removing a trace set) we think that in most cases there isn't significant risk associated with it (because for most trace sets it takes maybe a minute max to redo the all the analyses the user had open).

Removing a trace from the trace viewer will remove all analysis results and it can be a long procedure to rebuild (incl. upload the trace to the server in the future remote case). This depends on the size of the trace. I'll open a separate issue tracker for the confirmation dialog box because it's out of scope of this PR.

I'll going to merge it as because it brings in an UX improvement. The inconsistent labels can be fixed as part of fix for #277.


CSRF problems are back on EL8

Peering Manager version
v1.7.3-dev
Python version
3.8
Steps to Reproduce

Follow the documentation to install using gunicorn behind nginx proxy on CentOS8/Alma8/RHEL8/etc.
start 3 systemd services (peering-manager, peering-manager-rqworker, nginx)
try to log in

Expected Behavior
Should have been able to log in
Observed Behavior
Similar to what was described in #132 , I get:
Forbidden (403)
CSRF verification failed. Request aborted.

More information is available with DEBUG=True.

I altered settings.py to dump the assigned value of CSRF_TRUSTED_ORIGINS, like so:
CSRF_TRUSTED_ORIGINS = getattr(configuration, "CSRF_TRUSTED_ORIGINS", [])
print( CSRF_TRUSTED_ORIGINS )

and in stdout I get:
[]
no matter which way I access the server.

However, if I run the server from manage.py runserver then it works fine despite CSRF_TRUSTED_ORIGINS being an empty array?!?
For now I can use the runserver approach for testing, but how do I fix this?  Is this an EL8-vs-Ubuntu issue somehow?
(I can send nginx config if that's relevant, opting not to clutter this up until asked.)

CSRF_TRUSTED_ORIGINS will always be defaulted to an empty array unless you change it yourself in the configuration.py file. This is intended behaviour, see Django docs for more details.

OK.  In a way that's too bad, OS-specific problems are sometimes easier to find...
But: since I got out of web development before Django even existed, I have to ask for more guidance on how to resolve this.
My expectation is/was that if there was a mandatory additional step, it would be documented along with the others in [https://peering-manager.readthedocs.io/en/latest/setup/4b-nginx/].
Is this CSRF error something that occurs because I've messed up elsewhere, and just doesn't become visible until I put peering-manager behind nginx?  Or is it environment-specific?  Or is everyone expected to know how to resolve this error on their own?  (And why doesn't it happen in the runserver runtime environment, only behind nginx?  Is this an nginx problem?)
VERY confused, and can't tell where to go from here.

In general you don't need to modify the CSRF_TRUSTED_ORIGINS value but it remains a possibility. Most installs probably did not have to modify it, mine included. Most likely that's a nginx config that triggers the issue, as it looks like you do not face it when bypassing nginx with the built-in web server.


RFC: Use AppConfig Extension in Parameters module

Key information

RFC PR: (leave this empty)
Related issue(s), if known:
Area: (i.e. Tracer, Metrics, Logger, etc.) Parameters
Meet tenets: (Yes/no) that's a question

Summary
Add integration with AppConfig through the AppConfig Extension.
Motivation
The parameters module in Powertools for Java does not provide AppConfig integration. This integration can be achieved in two ways:

Using the Java SDK and the AppConfigDataClient
Using the AppConfig Extension for Lambda

This RFC is about letting the developer choose his preferred option, and thus implement the two.
Proposal

Detect the presence of the extension (automatically, or with an environment variable set to true).
Get config from the extension: http://localhost:2772/applications/%s/environments/%s/configurations/%s
Developer must add the extension layer to his function.

This proposal has been drafted in #826 (code here)
Drawbacks

Need an additional layer (which is limited in each function)
The extension already provides the cache mechanism which is also implemented in Parameters.
Increase the size of the package : extension + SDK (unless we could avoid adding the SDK when using the extension)

Rationale and alternatives
N/A
Unresolved questions
Detect the presence of the extension (properly), rather than using an environment variable. Pinging the extension endpoint, or looking at /opt/extensions directory. But it slows down the overall execution.

closing, won't be implemented


Support Firefox

~I'm using Firefox to avoid Chrome + GitHub problem, See https://github.com/kachick/times_kachick/issues/239~
=> Fixed this problem after uninstalling DeepL extension

And chrome has IME problem on wayland https://github.com/kachick/dotfiles/issues/689, I frequently use Firefox in these days...

https://qiita.com/Chippppp/items/098c39479a98f1caa6da

https://github.com/mozilla/web-ext

At least using in debug mode, it looks working
(displaying watcher number is another problem...)

However option page looks broken

:thought_balloon: Now preferring chrome again

If anyone want this, please notice me!


Remove unnecessary things for an API based application

Hi,
I would like to know what things I can remove if I just want to build a API. I've ran jets new api --mode api to generate a new API and I see what appears to be things I don't need within the public directory. May I remove the entire public directory, or shouldn't I?
Thanks.

Let’s put questions on the community forums 👍
You can remove the public folder just fine though. Be sure to update the default route also.
Think the ‘jets new -mode api’ can updated to do this also. Will dig into in time.

@tongueroo awesome! Thank you for the awesome framework and sorry for posting the question here.


Is "Delete Database" implemented?

Calling dbContext.Delete() followed by dbContext.Create() throws an exception saying it can't create a database that already exists.
John

Hello @johnknoop ,
We are currently cleaning all issue of NMemory before doing the same for Effort.
Since that issue is related to Effort, I have "moved' it here: https://github.com/zzzprojects/EntityFramework-Effort/issues/126
Best Regards,
Jonathan


Option to 'retain' data

Is it possible to retain data in MQTT. HA now thinks i'm still pulling 20W from the Sun when it's dark, this was the last state reported before the device went offline and got pulled to HA.

Fair point. It indeed is an annoyance that there's still a small wattage reported while the PV system is offline. Even the SolarmanPV API itself reports a wattage whilst the deviceState is 'offline' (3).
I was thinking on setting the value for the wattage to 0 over MQTT when the deviceState is offline. I found it nicer not to adjust values of data reported back from the API.
For myself, I resolved this in Home Assistant for now, via an automation and a script to set entity values:
The automation:
alias: Reset power sensor to zero when pv is offline
trigger:
  - platform: state
    entity_id: sensor.daylight
    to: 'dawn'
condition: []
action:
  - service: python_script.set_state
    data_template:
      entity_id: sensor.solarmanpv_current_power
      state: 0
mode: single

The python helper script:
#--------------------------------------------------------------------------------------------------
# Set the state or other attributes for the entity specified in the Automation Action
#--------------------------------------------------------------------------------------------------

# Example usage:
#
#   action:
#     service: python_script.set_state
#     data_template:
#       entity_id: Binary_sensor.sensor1
#       state: ON

inputEntity = data.get('entity_id')
inputStateObject = hass.states.get(inputEntity)
inputState = inputStateObject.state
inputAttributesObject = inputStateObject.attributes.copy()

newState = data.get('state')
if newState is not None:
    inputState = newState

newIcon = data.get('icon')
if newIcon is not None:
    inputAttributesObject['icon'] = newIcon

hass.states.set(inputEntity, inputState, inputAttributesObject)

That helper script is setup via the Home Assistant python_script integration (https://www.home-assistant.io/integrations/python_script/).  I just added the script to ./config/python_scripts/set_state.py.

I now manually have enabled retain and even then it sometimes reports a constant 10w. This makes sense because the script only polls once every minute (decreased the polling time to 60 sec). And if it turns off in this very minute it makes sense. Now I'm not using HA as much so I created something else. When there is a state change to 3 it pushes usePower and generatedPower to 0.0. Works for me just fine. Maybe add a remark to the README to make this clear. Thanks for your answer!


[ci skip] adding user @jGaboardi

Hi! This is the friendly automated conda-forge-webservice.
I've added user @jGaboardi as instructed in #4.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #4

@ocefpaf Should I try to re-render these? Or is there some other failure that I am overlooking?

We don't expect the CIs to run when adding a new maintainer. This is fine.

Ah, got it! Thanks!


Add Speech get_operation method

This functionality was previously part of the hand-written API, but is missing from the
fully-generated code. Adding the functionality now, before it is generalized in the generated code, because users are asking for this functionality to be restored. This implementation uses the same hooks as the streaming helper code.
require "google/cloud/speech"

speech_client = Google::Cloud::Speech.new version: :v1

op = speech_client.get_operation "1234567890"

# Process error operations.
log_error op.error if op.error?

if op.done?
  # Process completed operations.
  log_finished op.response, op.metadata
else
  # Process pending operations.
  log_pending op.name, op.metadata
end

[refs #2213, #2204]

I forget... What's the status on this? Did we need a gax update first, or is this ready for review?

This is ready to review. We don't need any changes in google-gax to accept, merge, or release this.
But, we do need to figure out what a generalized solutions to this would be. Long term we will need some changes to google-gax. But for now I think this is an acceptable short term solution. @jbolinger, how does this look to you?


Add mstest runner docs

Summary
Add documentation for MSTest Runner.
Fixes #Issue_Number (if available)

Internal previews

📄 File
🔗 Preview link

docs/core/testing/unit-testing-mstest-runner-exit-codes.md
MSTest runner exit codes

docs/core/testing/unit-testing-mstest-runner-intro.md
MSTest runner overview

docs/core/testing/unit-testing-mstest-runner-telemetry.md
Telemetry

docs/core/testing/unit-testing-mstest-runner-vs-vstest.md
MSTest runner and VSTest comparison

Post merge clean up.


Catch 'Unexpected startLinearAdMode invocation (Preroll)' warning

Hi,
I use playlist example with autoplay settings for video.js.
Sometimes when I switch src for the player, I get Unexpected startLinearAdMode invocation (Preroll)' warning  => autoplay doesn't work.
I researched the issue, the flag this.contentResuming from video-contrib-ads is false (at the error situation), but I couldn't find where this flag becomes to false (there are two places at video-contrib-ads, where this.contentResuming is set to false, none of them isn't called)
Can you help me understand, how I can fix this issue?

The Warn is caused because videojs-ima is calling this method after adstimeout event occurs.
This bug makes the player's behavior erratic. For example the class vjs-ad-playing is not added to the videojs element while the ad is playing.

Hi,
I’m closing this issue because it has been inactive for a few months.
Please reopen if you still encounter this issue with the latest stable version
Thank you!

I currently encounter the same issue.
While changing src when pre-roll is playing.
these are the versions I am using.
"video.js": "7.7.5",
"videojs-contrib-ads": "6.6.5",
"videojs-ima": "1.8.0"
And for some reasons, this is only happening on Safari browsers for me...


Resiliency over anonymous Tor Network (auto-retry & auto-resume)

Hi,
at GlobaLeaks.org we have been using the jQuery-File-Upload over Tor Hidden Services anonymous network http://torproject.org .
The Tor HS network can have:

Unexpected disconnection during file transfer
Failure in connection attempt (going in timeout)

That means that most upload done via jQuery-File-Upload fail due to it's inability to handle:

Automatic Reconnection Attempt (if a connection timeout while connecting, retry automatically X times with a configurable Y connection timeout)
Automatic Resume (if a connection die, automatically attempt to resume the upload)

We would like to see such kind of features implemented in jQuery-File-Upload and/or some direction on how to implement such kind of features.
This would make the jQuery-File-Upload resilient over bad network conditions, such as the one you may encounter into the Tor Darknet.

The section "Resuming file uploads" in the Chunked File Uploads documentation should give you a general idea.
e.g. the following code would submit the remaining bytes after a file upload error occurs (other than abort):
$('#fileupload').fileupload({
    maxChunkSize: 1000000, // 1 MB
    multipart: false, // required for Mozilla Firefox versions < 7
    add: function (e, data) {
        var that = this;
        $.getJSON('upload.php', {file: data.files[0].name}, function (file) {
            data.uploadedBytes = file && file.size;
            $.blueimpUI.fileupload.prototype
                .options.add.call(that, e, data);
        });
    },
    fail: function (e, data) {
        var that = this;
        if (data.errorThrown !== 'abort') {
            $.getJSON('upload.php', {file: data.files[0].name}, function (file) {
                data.uploadedBytes = file && file.size;
                data.submit();
            });
        }
    }
});

However, depending on the timeout and probably the server setting, file upload requests can usually survive short network failures without any error handling code as the snippet above.
You can test it yourself on the demo.
If you cut your network connection while uploading the request should stay in pending state and will continue the upload process after the network connection has been reestablished.
At least it worked that way in my tests with the demo and Google Chrome.

Would it also possible to detect if a transfer get stalled, and in that case act by shutting down the chunk upload, and resuming it?


method onNewIntent(Intent)

[react-native android]
Hello,
today I've encountered a problem compiling your code (android setup, step 2).
The message i get (command react-native run-android):

error: FacebookLoginModule is not abstract and does not override abstract method onNewIntent(Intent) in ActivityEventListener

I got it to work by adding the method into class FacebookLoginModule:
@Override
public void onNewIntent(Intent intent) {
//super.onNewIntent(intent); //theres no such a method on parent
}
As you can see, the method does not do anything, i cannot even call parent. Is it ok to leave it empty? If so, can you please push a fix?
Good job, keep it up
HK

i think this was put in as part of some recent fixes but not published as yet
https://github.com/magus/react-native-facebook-login/blob/master/android/src/main/java/com/magus/fblogin/FacebookLoginModule.java#L348

Thanks for your response.
Also, in android setup step 3, now you add these two lines mentioned into class MainApplication instead of MainActivity. Not sure if its necessary to add any code to handle the onActivityResult, i didnt have to.

Hi,
I saw there is a #132 for fixing this bug. Is there available in the 1.2.0 version ?

Please reference master until it is published
On Mon, Aug 8, 2016, 5:01 AM Nicolas Hodicq<EMAIL_ADDRESS>wrote:

Hi,
I saw there is a #132
https://github.com/magus/react-native-facebook-login/pull/132 for
fixing this bug. Is there available in the 1.2.0 version ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/magus/react-native-facebook-login/issues/139#issuecomment-238179922,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF02ef9qxPHkMZnofR1T-nUH6yBXqVzhks5qdvBZgaJpZM4JZ13i
.

--

Regards
Layton Whiteley

This is what i did. Thanks for your answer

1.3.0 published


Simplify API using content slots

Instead of the complicated btnModalPositiveEventName etc properties, a simpler approach for the buttons and their states / behaviors may be to replace them with a second content slot for the footer of the modal and provide a method or event listener for closing the modal.

Can'T you provide an .open() and .close() functions for the modal? .modalButtonClicked() is far from trivial/intuitive.

Pull requests are always welcome.


Running boxen after upgrade throws Puppet::DataBinding::LookupError

Hi there.
After upgrading to Boxen 2.6.0 I get the following error when running boxen --debug
Info: Loading facts in     /Users/stianselland/Documents/projects_real/boxen/repo/shared/stdlib/lib/facter/root_home.rb
Debug: importing '/Users/stianselland/Documents/projects_real/boxen/repo/shared/boxen/manifests/environment.pp' in environment production
Debug: Automatically imported boxen::environment from boxen/environment into production
Debug: hiera(): Hiera YAML backend starting
Debug: hiera(): Looking up boxen::environment::relative_bin_on_path in YAML backend
Debug: hiera(): Looking for data source common
Debug: hiera(): Cannot find datafile /var/lib/hiera/common.yaml, skipping
Debug: hiera(): Hiera Module Data backend starting
Debug: hiera(): Looking up boxen::environment::relative_bin_on_path in Module Data backend
Error: uninitialized constant Puppet::DataBinding::LookupError at /Users/stianselland/Documents/projects_real/boxen/repo/manifests/site.pp:1 on node stians-macbook-pro.local
Wrapped exception:
uninitialized constant Puppet::DataBinding::LookupError
Error: uninitialized constant Puppet::DataBinding::LookupError at     /Users/stianselland/Documents/projects_real/boxen/repo/manifests/site.pp:1 on node stians-macbook-pro.local

I've followed the upgrade instructions here.
From what I can see it looks like boxen is looking for a configuration key called relative_bin_on_path.
Cheers
Stian

Hi, I’m facing same issue. Can u pls tell how did u started fresh boxen install since in my case it is remote gem thus looking for a way to do a fresh reinstallation.

Hi @sachingupta771,
Are you able to elaborate on what steps you've taken and any error messages you've received? This is a 3 year old issue so you're probably best creating a new issue with your specific environment details to help diagnose it.

Hi  @jacobbednarz,
I'm getting the error while testing the unit test case file using rspec gem with puppet
Puppet::DataBinding::LookupError:
Function lookup() did not find a value for the name 'profiles::ci::jenkins::user' at /app/hybris-devops/hybris/modules/profiles/spec/fixtures/modules/profiles/manifests/ci/jenkins/config.pp:1 on node
Thus was thinking of trying to reinstall boxen after reading above comments since I’m not able to trace the actual issue.

Based on that error message, it isn't anything to do with core Boxen - it's an issue with the Jenkins puppet module that is trying to find a value and you haven't provided a value for. I'd recommend taking a look at the module and following the setup ensuring you define the correct values in hiera.


Error while I try generate a project

Hi!, I installed vue-init following steps that describes at vue-init respositories, but when I run  vue init webpack example or vue init I get the next error:
module.js:457
    throw err;
    ^

Error: Cannot find module './src/init'
    at Function.Module._resolveFilename (module.js:455:15)
    at Function.Module._load (module.js:403:25)
    at Module.require (module.js:483:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/usr/lib/node_modules/vue-cli/node_modules/gulp-sourcemaps/index.js:4:9)
    at Module._compile (module.js:556:32)
    at Object.Module._extensions..js (module.js:565:10)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)

Ubuntu: 16.04 64-bit,
Proccessor: Intel® Core™ i5 CPU M 460 @ 2.53GHz × 4
Node: 6.7.0
npm: 3.10.3
Thanks!

I'm getting the same
os x sierra
Macbook Air (2011)
Node: 6.8.0
npm: 3.10.8

Same here
Vue-cli version 2.4.0
Node 6.8.0
npm 3.10.8
Happens on vue init but also vue init webpack my-project

There is an issue with the gulp-sourcemaps module that is installed with vue-cli.
Please see the issue here: https://github.com/floridoo/gulp-sourcemaps/issues/242
I fixed the issue finally after manually downloading the gulp-sourcemaps repository and placing its contents in the gulp-sourcemaps folder found in the node_modules of your vue-cli installation.
When installing vue-cli, the "src" folder for gulp-sourcemaps was not installed. By copying the repository which includes the "src" folder, I was able to get it running.

@brysem thanks for your temporary solution. Now, it worked for me.
If you want automatically replace folder then you could use the bellow command  in the node_modules of your vue-cli installation:
I executed this command at Ubuntu:
sudo sh -c "wget https://github.com/floridoo/gulp-sourcemaps/archive/master.zip ; unzip master.zip ; rm -rf gulp-sourcemaps ; mv gulp-sourcemaps-master/ gulp-sourcemaps/ ; rm -rf master.zip"

Note: I used the master version because src has never been part of the repo for releases

@davidenq Updating vue-cli seems to fix the issue
If the error still persist, tell me so I can reopen the issue

same issue with mac ... any workaround?
Would love to know what version of vue-cli and vue and node with npm versions are stupposed to work properly...


GH-2076: Fix Async Commit Retries

https://github.com/spring-projects/spring-kafka/issues/2076
Do not attempt to retry asynchronous commits.

a later commit for the same topic/partition may have already succeeded
many consecutive retryable exceptions can cause a stack overflow

cherry-pick to 2.8.x, 2.7.x

Back-ported to 2.8.x as https://github.com/spring-projects/spring-kafka/commit/9722b8420b670eb256dc9000e53e5269a66253d4 after fixing conflicts.
And as https://github.com/spring-projects/spring-kafka/commit/45a6b06ba2a03fa442a204650adaad5545f96e96 to 2.7.x after more conflicts.


Pt 161747758 nested abort

https://www.pivotaltracker.com/story/show/161747758

Rebased and added test for a top level call to abort.


ArgumentNullException when returning empty ViewResult

Having the following code:
public class HomeController
{
    public IActionResult Index()
    {
        return new ViewResult();
    }
}

Results in an ArgumentNullException:
ArgumentNullException: Value cannot be null. Parameter name: viewData
Microsoft.AspNet.Mvc.ViewFeatures.ViewExecutor.<ExecuteAsync>d__1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Mvc.ViewResult.<ExecuteResultAsync>d__24.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Mvc.Controllers.FilterActionInvoker.<InvokeResultAsync>d__53.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Mvc.Controllers.FilterActionInvoker.<InvokeResultFilterAsync>d__52.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
Microsoft.AspNet.Mvc.Controllers.FilterActionInvoker.<InvokeAllResultFiltersAsync>d__51.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Mvc.Controllers.FilterActionInvoker.<InvokeResourceFilterAsync>d__46.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
Microsoft.AspNet.Mvc.Controllers.FilterActionInvoker.<InvokeAsync>d__41.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Mvc.Infrastructure.MvcRouteHandler.<RouteAsync>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Routing.Template.TemplateRoute.<RouteAsync>d__27.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Routing.RouteCollection.<RouteAsync>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNet.Diagnostics.DeveloperExceptionPageMiddleware.<Invoke>d__6.MoveNext()

Running on the latest version:

Microsoft.AspNet.vc.6.0.0-rc1-15954
dnx-coreclr-win-x64-1.0.0-rc1-15798

In an older version this still worked.

I was having a discussion about this with @MartinJohns in jabbr, and he's saying that this worked in earlier builds before we added argument validation.
Maybe it was dumb-luck that it worked before, but this would be convenient for POCO controllers. It's odd to require view data to be explicitly managed by the user when they are using view models for everything they show on the view.

@rynowak I think this could at a minimum be changed to fail a bit more gracefully by perhaps failing earlier with a better error. But do you feel that some un-set values could just be silently ignored for scenarios such as POCO controllers?

That's what I'm suggesting - if you're not using a feature like ViewData - the system still needs it (HtmlHelpers), but we shouldn't require you to plumb it through for us.

Ok so pass in a dummy ViewData if it isn't there?

yes

Similar with temp data also if we can

[A-Za-z]{4}Data?

Closed in #3310


[Follow-up] QC check sessions that previously did not pass behavior but can be good for BW analysis ?

JH and GC did an analysis showing that for ~18 sessions marked currently as 0 for behavior, there are actually 400 trials during which the behavior is good. The overall performance decreases because of the subsequent trials. (thread here https://int-brain-lab.slack.com/archives/GMJNZ63U4/p1701104969162209)
Has the BW agreed that we should be using these sessions (and thus release them)?
If so, what is needed in terms of QC?

[ ] Raw ephys website (Chris) + check (Gaelle) ?
etc

BWM and DAWG cleared this for release
Data will be release untruncated (full)

[ ] Change behavior QC to include these sessions @juhuntenburg
[ ] Analyze if most of late sessions will be removed by BWM filter
[ ] Communicate with BWM TF @juhuntenburg
[ ] Raw ephys sign off @chris-langfield @GaelleChapuis
[ ] Spike sorting @oliche
[ ] Video @mayofaulkner @juhuntenburg
[ ] All other sign off @juhuntenburg

Wheel aligned videos by Mayo, go through QC and sign off
    'c7a9f89c-2c1d-4302-94b8-effcbe4a85b3_left' # -300,
    'c7a9f89c-2c1d-4302-94b8-effcbe4a85b3_right' # -700,
    'db4fe6df-b1d2-4958-9c93-e71696d58f7f_right' # 21,
    'fe83be91-8b8b-44d2-ab32-fdda1992fcfb_left' #361,
    'fe83be91-8b8b-44d2-ab32-fdda1992fcfb_right' #895

Figure out what to do about this probe (see Phys WG slack)
probe01 UCLA015/2022-04-05/001
f180b2b2-5a6a-4fea-9550-4fb0c4376666


MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.16.1, and co…

…nda-forge-pinning 2<IP_ADDRESS>.05.28

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Feature: Add clear transcript functionality

Proposed changes

Added a button to clear transcription
Resolves #4

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update or tests (if none of the other choices apply)

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules


Change Password: character limit

When the user is changing their password, the GUI informs that password must be at least 8 characters.

If user sets 1-7 characters password and submit it, a message is returned by the GUI saying , in Portuguese, that the minimum number of characters that is required are 8.

The same message appears as ToolTip when the password and confirm password fields are partially populated.

Expected behavior: the same behavior as "New Password"
Affected Version: 0.3.0-nightly_20181010

Test OK.


animate.css added still animation not working

animate.css already added but still animations are not working
help pls
Bootstrap v3.3.7
jQuery v2.1.4

It looks like Animate.css has been updated. I couldn't get classes like animated fadeInDown (from the bootstrap-notify docs) to work. Instead try something like the following:
animate: {
	enter: "animate__animated animate__fadeInDown",
	exit: "animate__animated animate__fadeOutUp"
}


updated readme

revised about. added diagram of architecture

@gldysmile I approved it but just noticed there are conflicts. Can you look into that, most likely just need pull on the main


Nvim fails to open temp file

Formatting consistently fails with an error message like this for me:
Error detected while processing BufWritePre Autocommands for "*":
Error executing lua callback: Vim:E484: Can't open file /tmp/nvim.leah/5RM6OQ/3
stack traceback:
				[C]: in function 'readfile'
				...zy/format-on-save.nvim/lua/format-on-save/systemlist.lua:20: infunction 'systemlist'
				...m/lazy/format-on-save.nvim/lua/format-on-save/format.lua:128: in function 'format_with_shell'

After taking a look at the code, I don't exactly understand why it's failing to create a temporary file - I can do it just fine manually. Any insights?

Hi,
It's strange, the vim.fn.filereadable() returns non-zero which means it expects the file to be readable but then vim.fn.readfile fails. Maybe filereadable isn't the proper way, I'm curious to look into this.
If you try to open the temp file manually (while the error message is still displayed), does it exist? what's the contents?
Also, what is your plugin configuration? which formatter is this?

Hi,
Thanks for raising this issue, It's strange, the vim.fn.filereadable() returns non-zero which means it expects the file to be readable but then vim.fn.readfile fails. Maybe filereadable isn't the proper way, I'm curious to look into this.
If you try to open the temp file manually (while the error message is still displayed), does it exist? what's the contents?
Also, what is your plugin configuration? which formatter is this?

Yeah this is weird... I'm trying to format Nix files with alejandra, and I couldn't find the temp file when tried to ls the temp folder. Maybe it's not creating the temp file at all?
Update: I tried to update the plugin via lazy.nvim and now it's no longer present. It might just be a problem with an older, faulty build of this plugin. I was going to say alejandra's behaving very strangely and printing messages to stderr even when it has successfully formatted the file, but I realized that was a me problem as I forgot to pass --quiet :woman_facepalming: Everything should be working now


Feat  improved visibility

Description
Several metrics and states were not exposed making debugging challening.
Fixes # HAT-145 HAT-125 HAT-142
Type of change

[x] New feature (non-breaking change which adds functionality)

What's Changed

[x] expose worker state
[x] improve worker view
[x] expose workflow run metrics counts
[x] add workflow run summary
[ ] improve output with \n


B2b copy

PTAL, this implements (but doesn't end2end test) the buffer to buffer copies that will be necessary to copy data from the GPU to a MapRead buffer.
Part of #45

Thanks!


error

[04:32:51] [Server thread/CRITICAL]: ErrorException: "mysqli::__construct(): (HY000/2002): Connection refused" (EXCEPTION) in "/plugins/BlockPets-master/src/BlockHorizons/BlockPets/pets/datastorage/MySQLDataStorer" at line 80

Please change your database inside the config.yml to SQLite or disable storing to database.


⚠ Bofrost.at has degraded performance

In cef77e8, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1419 ms

Resolved: Bofrost.at performance has improved in 834f23a.


Improved updation of blockchain height

Improved updation of blockchain height

@mod What do you think about this?


fix: Update Virtual Network Gateway query and add new query for TrafficManagerProfiles

Overview/Summary
This fix is to prevent any issues with Advisor recommendations using Lower or Upper characters in its recommendation GUIDs.
It also adds a new query for traffic manager profiles, to identify profiles without at least two endpoints in different regions.

This worked in my customer environment - Good to go


Missing action to push repository to GitHub

Moving to roadmap because we'll be moving from github to gogs very soon

The git repository used doesn't impact on the code that will be used to
push. So we can still implement this feature migrating to gogs won't break
it
On Sun, Nov 27, 2016, 20:35 Geert Audenaert<EMAIL_ADDRESS>wrote:

Moving to roadmap because we'll be moving from github to gogs very soon
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/jscockpit/issues/238#issuecomment-263131940,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASgPNdFtLoe5709ejEldhd03vrdirsEks5rCbFUgaJpZM4Kubv0
.

OK to move to roadmap @FastGeert, but why are we moving to gogs? This will probably break so many things? Don't we have already enough issues?

But do we need it urgently?
On Nov 27, 2016 19:26, "Christophe de Carvalho"<EMAIL_ADDRESS>wrote:

The git repository used doesn't impact on the code that will be used to
push. So we can still implement this feature migrating to gogs won't break
it
On Sun, Nov 27, 2016, 20:35 Geert Audenaert<EMAIL_ADDRESS>wrote:

Moving to roadmap because we'll be moving from github to gogs very soon
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/Jumpscale/jscockpit/issues/238#
issuecomment-263131940>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AASgPNdFtLoe5709ejEldhd03vrdirsEks5rCbFUgaJpZM4Kubv0>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/jscockpit/issues/238#issuecomment-263134840,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOij1ljQPyc7oLbiHZk7QuLc9nhJTwobks5rCb07gaJpZM4Kubv0
.

No

Gogs is urgent for many reasons
On Nov 10, 2016 13:15, "Yves Kerwyn"<EMAIL_ADDRESS>wrote:

[image: screen shot 2016-11-10 at 10 14 22]
https://cloud.githubusercontent.com/assets/13795109/20170910/8c880424-a72e-11e6-8087-b8a5a9e72761.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/jscockpit/issues/238, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFvi1MH7d5sv1qBoBVmfQrgGUfIxDOe8ks5q8uCigaJpZM4Kubv0
.

Gogs is only for stories and env repos
On Nov 10, 2016 13:15, "Yves Kerwyn"<EMAIL_ADDRESS>wrote:

[image: screen shot 2016-11-10 at 10 14 22]
https://cloud.githubusercontent.com/assets/13795109/20170910/8c880424-a72e-11e6-8087-b8a5a9e72761.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/jscockpit/issues/238, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFvi1MH7d5sv1qBoBVmfQrgGUfIxDOe8ks5q8uCigaJpZM4Kubv0
.

Not for cockpits?
ᐧ
On Mon, Nov 28, 2016 at 7:44 AM, kristof de spiegeleer <
<EMAIL_ADDRESS>wrote:

Gogs is only for stories and env repos
On Nov 10, 2016 13:15, "Yves Kerwyn"<EMAIL_ADDRESS>wrote:

[image: screen shot 2016-11-10 at 10 14 22]
<https://cloud.githubusercontent.com/assets/13795109/20170910/8c880424-
a72e-11e6-8087-b8a5a9e72761.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/jscockpit/issues/238, or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AFvi1MH7d5sv1qBoBVmfQrgGUfIxDOe8ks5q8uCigaJpZM4Kubv0>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/jscockpit/issues/238#issuecomment-263195179,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOij1lZV3y84dpVFSjbhgtCtdmZ60Ha3ks5rCnhlgaJpZM4Kubv0
.

--
http://www.rogerthat.net
GEERT AUDENAERT / founder
<EMAIL_ADDRESS>/ +32 (0)474 201 541
ROGERTHAT
-- Avoid WhatsApp for business communication--
-- Integrate your staf with your applications--
+32 (0)9 324 25 64
Antwerpsesteenweg 19 9080 Lochristi
www.rogerthat.net
<EMAIL_ADDRESS>

Yep also cockpits
On Nov 28, 2016 11:36, "Geert Audenaert"<EMAIL_ADDRESS>wrote:

Not for cockpits?
ᐧ
On Mon, Nov 28, 2016 at 7:44 AM, kristof de spiegeleer <
<EMAIL_ADDRESS>wrote:

Gogs is only for stories and env repos
On Nov 10, 2016 13:15, "Yves Kerwyn"<EMAIL_ADDRESS>wrote:

[image: screen shot 2016-11-10 at 10 14 22]
<https://cloud.githubusercontent.com/assets/
13795109/20170910/8c880424-
a72e-11e6-8087-b8a5a9e72761.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/jscockpit/issues/238, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/
AFvi1MH7d5sv1qBoBVmfQrgGUfIxDOe8ks5q8uCigaJpZM4Kubv0>
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/Jumpscale/jscockpit/issues/238#
issuecomment-263195179>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AOij1lZV3y84dpVFSjbhgtCtdmZ60Ha3ks5rCnhlgaJpZM4Kubv0>
.

--
http://www.rogerthat.net
GEERT AUDENAERT / founder
<EMAIL_ADDRESS>/ +32 (0)474 201 541
ROGERTHAT
-- Avoid WhatsApp for business communication--
-- Integrate your staf with your applications--
+32 (0)9 324 25 64
Antwerpsesteenweg 19 9080 Lochristi
www.rogerthat.net
<EMAIL_ADDRESS>—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Jumpscale/jscockpit/issues/238#issuecomment-263202130,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFvi1ClYv28Ds27WTDGARgq9_m6BugyOks5rCoRogaJpZM4Kubv0
.


Bug: the provider doesn't return the status code from AbstractProvider

In the checkResponse function a hardcoded 0 is used for the code of the exception
https://github.com/stevenmaguire/oauth2-keycloak/blob/a6441cc27412ef7125770ec4ea22ad6b4d69dd05/src/Provider/Keycloak.php#L246
The status of the response should be used
throw new IdentityProviderException($error, $response->getStatusCode(), $data);

Next week I will look at and prepare fix

I can rebase my changes on the latest master, if it'll get merged this time around :sweat_smile:.

@LiquidPL rebase please an I will look at and merge them

@mstefan21 done

Released new version v5.1.0