V2 - Able to assign cla-manager-desginee role for already signed project through API

Observed that through API we are able to assign cla-manager-desginee role for already signed project
Tried for below data
Project Name - DPDK Core
Project SFID - a092M00001IV4ARQA1
CLA Group Name - DPDK-Core CCLA_ICLA_EmployeeICLA_Yes
CLA Group ID - 6430f241-f118-4379-9713-beb68e61fedc
praj - contributor for the project (used this user's authorization token and email in the endpoint)
Observed that post was successful and praj was assigned with cla-manager-designee role

Once we have a CLA Manager configured for a given CLA Group/Project - do not allow users to become designees and sign.  Once a CLA Manager is established, he/she must add them through the corporate console.

Observed a regression issue where in always "project already signed" is returned even when there is no signature. Issue is tracked in #1107
Testing is blocked due to this issue

Tried with below 2 endpoints and observed that we are able to assign cla-manager-designee role for a user for already signed Project and Organization
https://api-gw.dev.platform.linuxfoundation.org/cla-service/v4/company/0014100000Te0iaAAB/project/a092M00001IfR9lQAF/cla-manager-designee
https://api-gw.dev.platform.linuxfoundation.org/cla-service/v4/company/0014100000Te0iaAAB/project/a092M00001IfR9lQAF/cla-manager/requests

500 Internal server error is returned for cla-manager/requests endpoint

Issue is fixed for cla-manager-designee endpoint
https://api-gw.dev.platform.linuxfoundation.org/cla-service/v4/company/00117000018BhtKAAS/project/a091700000AGJ5EAAX/cla-manager-designee

@nirupamav the cla manager request issue was fixed .. reference https://app.zenhub.com/workspaces/easyclav2-5ed619832c71a855a76ef404/issues/communitybridge/easycla/1565 so can be tested for this use case

Verified that issue is fixed
https://api-gw.dev.platform.linuxfoundation.org/cla-service/v4/company/00117000018BhtKAAS/project/a091700000AHldEAAT/cla-manager/requests

https://api-gw.dev.platform.linuxfoundation.org/cla-service/v4/company/00117000018BhtKAAS/project/a091700000AHldEAAT/cla-manager-designee


Django 1.9 support

It seems that handy doesn't support Django 1.9. If I try to use the package I get the following error:
Traceback (most recent call last):
  File "runtests.py", line 37, in <module>
    runtests(*sys.argv[1:])
  File "runtests.py", line 24, in runtests
    django.setup()
  File "/home/gregor/projects/oTree/otree-core/.tox/py2.7-django1.9-unittest/lib/python2.7/site-packages/django/__init__.py", line 18, in setup
    apps.populate(settings.INSTALLED_APPS)
  File "/home/gregor/projects/oTree/otree-core/.tox/py2.7-django1.9-unittest/lib/python2.7/site-packages/django/apps/registry.py", line 85, in populate
    app_config = AppConfig.create(entry)
  File "/home/gregor/projects/oTree/otree-core/.tox/py2.7-django1.9-unittest/lib/python2.7/site-packages/django/apps/config.py", line 116, in create
    mod = import_module(mod_path)
  File "/usr/lib64/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/gregor/projects/oTree/otree-core/otree/apps.py", line 11, in <module>
    from otree.models_concrete import StubModel
  File "/home/gregor/projects/oTree/otree-core/otree/models_concrete.py", line 1, in <module>
    from otree.db import models
  File "/home/gregor/projects/oTree/otree-core/otree/db/models.py", line 13, in <module>
    from handy.models import JSONField, PickleField
  File "/home/gregor/projects/oTree/otree-core/.tox/py2.7-django1.9-unittest/lib/python2.7/site-packages/handy/models/__init__.py", line 1, in <module>
    from .fields import *
  File "/home/gregor/projects/oTree/otree-core/.tox/py2.7-django1.9-unittest/lib/python2.7/site-packages/handy/models/fields.py", line 17, in <module>
    from handy.utils import get_module_attr
  File "/home/gregor/projects/oTree/otree-core/.tox/py2.7-django1.9-unittest/lib/python2.7/site-packages/handy/utils.py", line 10, in <module>
    from django.db.models.sql.where import Constraint
ImportError: cannot import name Constraint

Is there any chance that Django 1.9 will be supported in the future?

Fixed this in 54ed9e23014863ec0032c351d4283b144f99bcbe. Please try it with your code.

Great! Thank you! Is it possible to get out a new release for this package, so that we can pin our dependencies against it?

@Suor Do you plan to release a new version of this anytime soon so that everyone could use the Django 1.9 support?

Released.


How to test the logged out case in Devise?

I am able to follow https://github.com/plataformatec/devise/wiki/How-To:-Test-controllers-with-Rails-3-and-4-(and-RSpec) to test my controllers methods which require login (using RSpec).
But for the life of me I am unable to test the logged out case, just to ensure that there is actually a 404 or redirect. I always get one of the following:
ArgumentError:
    uncaught throw :warden

or
NoMethodError: undefined method 'authenticate!' for nil:NilClass

Can somebody help me out?

Please use the mailing list or stack overflow for questions, we reserve the issues tracker for issues. Thanks!


Duplicate "Beginning of New Chat" Message and Email in LHN when Changing Assignee

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click the plus sign and select "Assign Task"
Fill in the title, description, and assignee, and share somewhere
Click on the assignee and change it to a new email that has not been used before
Observe that the "Beginning of New Chat" message and email appear twice in LHN.

Expected Result:
The "Beginning of New Chat" message and email should only appear once in LHN when changing the assignee with a new email.
Actual Result:
When changing the assignee to a new email, the "Beginning of New Chat" message and email appear twice in LHN, causing duplication.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.53-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/de928642-6829-4380-a250-3692ff4851f3
https://github.com/Expensify/App/assets/43996225/a75bdece-30ab-47b4-acba-45e38f0c578d
Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691065190422649
View all open jobs on GitHub

This seems to be expected behaviour.

I only received one "Beginning of New Chat" message. Can you send a screenshot of the duplicate report so I am on the same page?

Is the issue that there are two tasks?

I switched assignee back and forth from mmoore+2020 to mmoore+2021, and it created a second task. Is that what the issue is referring to?

No worries @allroundexperts - definitely always worth double checking.


cri/sbserver: Add support for user namespaces (KEP-127)

This PR just adds support for user namespaces in sbserver. Now there is feature parity regarding userns support between cri/server (what is currently on main) and cri/sbserver.
It's better to review this series commit by commit, as commits should be atomic and properly explained.
I did the commits adding test as separate commits just in case, as it proved to be useful in the past to simplify backporting (somtimes the structure of the tests change).
I've tested this locally with k8s and the e2e, all runs fine here.
Here is an overview of the commits:

Commits 1-4 are simple preparatory commits + minor fixes (like typos)

Commit "cri/sbserver: Let OCI runtime create netns when userns is used" does the thing about letting the OCI runtime create both the userns and netns, as we can't create the netns ourselves before the userns and have proper ownership for the netns. One thing to highlight is that I'm doing the CNI setup for the userns case after the controller.Start(). In the cri/server, we are doing this same thing between create and start (this is something that was added due to reviewers comments back in the day). But I couldn't get the PID of the sandbox before Start() using the Status() call, so I couldn't do it between Create() and Start() here. I'll investigate this further, but let me know if you prefer to move this before start and have any ideas on how we should get the PID of the sandbox at that point :)

Commits 6-8: Just porting the corresponding commits from cri/server to sbserver. The port is very straighforward and the original cri/server commits are mentioned in the commit msgs.

Commit 9-10: Just a port of https://github.com/containerd/containerd/pull/8779 to sbserver. In that PR we added a TODO to do it once we support userns, so I'm doing it now :)

Commit 11: Just enable integration tests on sbserver too.

cc @mxpv

The only CI failure seems to be something broken in main an unrelated to this PR.

/ok-to-test

/test pull-containerd-sandboxed-node-e2e

Probably this should be highlighted in https://github.com/containerd/containerd/blob/main/docs/containerd-2.0.md


Feature Request: Hide Controls

It would be very useful if there was an option to hide the controls. On the standard HTML video tag, just not including the controls attribute would remove them.

Version 2.6.0 has been released which allows you to force the state of the overlay/controls, instead of using the default behaviour.
You can disable the overlay/controls as follows.  You can bind this to a boolean variable to dynamically alter the behaviour.
<mat-video src="/assets/video.mp4" [overlay]="false">

Options:

[overlay]="null" - default behaviour
[overlay]="false" - always hide the overlay
[overlay]="true" - always show the overlay

Not including the overlay attribute falls back on the default behaviour.
The documentation and sample have both been updated to reflect this change.
Closing.


Fix marker placing bug

When selecting a position on the map, the marker is placed incorrectly because "transform" CSS property is set to 1.25. This commit fixes this by setting initial "transform" to 0.75 and when the user wants to place a marker on the map, the "transform" becomes 1.

Because my editor automatically removes trailing whitespace, I recommend looking at the diff ignoring whitespace.

Hello thanks for contributing. I will review by this weekend.

Hello I reviewed your repository and it is actually a bug I didn't notice. Thanks I appreciate!


feat: Make test:unit check fail if code coverage is not 100%

Description
This PR forces code coverage to be at 100% for the test:unit check to succeed.

What is the purpose of this pull request

[x] Other

Nice! Thanks! ❤


MarlinLCD12864 is not displayed on TFT3.5 when uploading firmware.

MarlinLCD12864 is not displayed on TFT3.5 when uploading firmware.
This is a link to download the firmware file.
https://drive.google.com/file/d/1rlBbMdjzhrDeOQ9JEc7tuGK5K0eWDBh9/view?usp=sharing

@auger1234 how is this related to Visual Studio Code? Maybe you posted to the wrong repo.


Hackathon submission -- Civ 3 Continent Counter (week 1)

You’ve done a great job with solving this challenge! I especially like your calculation of land percentage and your random world generator.
To level up your solution you could ask the user for what size world they would like to create and you could try benchmarking your program to see if there are any bottle necks in your code where speed could be improved.
You’ve made a wonderful use of constructors and your error checking is very good. Your solution would be a great example to use for beginners if you fancied adding some comments explaining what each line does and why you did it that way, so that beginners could understand your method and the reasoning behind it.


[BEAM-7269] remove StateSpec from hashCode of SimpleStateTag

[BEAM-7269] remove StateSpec from hashCode of SimpleStateTag

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

There are some unit tests which need to be updated in StateTagTest.java
The fixes seem trivial as in the tests should say the two state tags are the same even if the coders are different.

Oops, I thought I have run the tests, but apparently I haven't. :-) Fixed.

Run Java PostCommit

@je-ik Do you want to take a look at https://issues.apache.org/jira/browse/BEAM-2777 since it also seems to be related to state incorrectly being stored in a map using the wrong key?

Thanks @je-ik

@lukecwik sorry I didn't respond, is the issue you mentioned related to this? It seems to me, that it refers to storing user supplied keys in user states (which currently behaves similarily to how java collections work, which might not be an issue), or am I missing something?

Storing user keys inside a Java map assumes that equals and hashCode work correctly. Imagine the user uses a byte[] as there key (note byte[] only has object identity equality), then the map will store multiple keys with byte[]'s containing the same contents because we aren't using the structural value.

Sure, that was exactly how I understood it, but my point was that that's exactly the way HashMap and HashSet work, so that probably won't be any surprise to Java developers. Although a simple fix would probably be to use coder and store serialized key wrapped in ByteBuffer or something similar. Question is if it is "worth it", because as noted previously, there will probably not be many people storing byte arrays as keys. Just my 2 cents.

A coder already has a method to return a value which implements equality without encoding the actual value (that is what consistentWithEquals and structuralValue is about). While other coders like ByteArrayCoder just return an equivalence wrapper around the object.
It is worth it because people will hit correctness issues otherwise around missing/wrong values stored in user state.


StringLike field with quotes breaks out of title

Describe the bug
Storing content in a field that contains quotes results in only the content before the first quote is in the title. The rest of the content is stored in the tag as individual attributes.
We noticed this when the word hidden was stored after a quote, which resulted in the cell being hidden and the rest of the row shifting to the left.
Reproduction steps

For a given record with a StringLike field:

Put the content Example "text" hidden  in the field.
View the index page that contains this model/field.

Expected behavior

The content should show (with ellipsis if necessary based on space), and the title should represent the whole field escaping quotes with "

Additional context

rails version: 7.1.3
rails_admin version: 3.0.0.beta2

I realized that this issue lead to an XSS vulnerability, so I've published a security advisory: https://github.com/railsadminteam/rails_admin/security/advisories/GHSA-8qgm-g2vv-vwvc
I recommend upgrading to the latest release 3.1.3, as soon as possible. Also fixed in the master: https://github.com/railsadminteam/rails_admin/commit/32f91e4b49205e44d3931c2e36d9f7273384a250
Thank you for giving the valuable report 👍

@mshibuya thank you for your work on this!
When trying 3.1.3 with this change I am seeing unescaped HTML tags in the title attribute. The field value does appear properly escaped -- it is the HTML from pretty_value in rails admin that is unescaped and no longer stripped out.
For example on booleans:

<td class="flag1_field boolean_type" title="">

Or associations:

<td class="user_field belongs_to_association_type" title="Test User1">
  Test User1

rails version: 7.0.8
rails_admin version: 3.1.3

@q3aiml So sorry for the issue, I messed up 🙇♂
I'm preparing for another release now.

Released 3.1.4. Please give it a try, and if you see any issue please let me know 🙇♂


Close

Very good app.
Not closing when not playing any radio. The notification remains active. I have to force close the app to remove notifications.

Hello,
this is the way it is intended and was built into the app.
Therefore, I'm closing here again.


fix: inject_global_variables should considering string imported name

#7768  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


reading time indicator

follow either https://carlosbecker.com/posts/jekyll-reading-time-without-plugins/
or install this plugin https://github.com/gjtorikian/jekyll-time-to-read

great job @himanshub16


Add m1 mac support to install script

Fixes the install script.
Motivation
Allow M1 Macs to pull darwin/arm64 build of rosetta-cli
Solution
Add a line in the install script to reference the build

@syuan100 thanks for the PR. Can you gpg verify and update the commit?

Thank you!


Stpl comprehensions

Fixes the parser to allow this code to render:
% a = [
%    (i + 1)
%    for i in range(5)
%    if i%2 == 0
% ]

This was written on top of the cleanup in https://github.com/bottlepy/bottle/pull/689

Is there ever going to be a 0.12.9 release that this change could go into? I'm getting tired of running a bleeding edge install when I write complex templates

Sure. I just cherry-picked it into release-0.12 and will release in the next minutes.


Teleport binding for tier 3 items

Describe the feature you'd like to have added
I'd love an indicator for binded blocks aswell as a way to see if I've done the bind correctly. the cordinate system is a good placeholder but it's abit unintuitive. Love the mod though great job for the most part ^^
Additional information
No response

I'd love if, while holding a tool with Teleport, if you're within 16 blocks of your bounded block, that block is highlighted or brightly outlined.

I'd love if, while holding a tool with Teleport, if you're within 16 blocks of your bounded block, that block is highlighted or brightly outlined.

I like that Idea but I'd like an option to render it and also turn it off just like most machines in the mod :v

Render Added - along with a toggle on the ability to hide it :)


feat: specific class for configured connection-url factory

Codecov Report
Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (61aaa59) 67.59% compared to head (4d99ee9) 67.46%.

Files
Patch %
Lines

...ns/Configuration/ConfiguredConnectionUrlFactory.cs
58.33%
7 Missing and 3 partials :warning:

....Extensions/Configuration/ConnectionUrlSettings.cs
42.85%
2 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   67.59%   67.46%   -0.13%
==========================================
  Files         238      239       +1
  Lines        3027     3058      +31
  Branches      526      536      +10
==========================================
+ Hits         2046     2063      +17
- Misses        849      858       +9
- Partials      132      137       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bump flutter SDK version to 3.0.3

Opened because of this comment https://github.com/realm/realm-dart/pull/1066#discussion_r1052588593.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 89.217%

Files with Coverage Reduction
New Missed Lines
%

lib/src/subscription.dart
1
90.48%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
2813

Relevant Lines:
3153

💛  - Coveralls


LDAP Authentication or single logon

This is probably on a whole new level but think it would be nice to have (at some point) - especially if the number of services keeps growing. So maybe in Version 2 or something :D
This could be a starting point:
https://spring.io/guides/gs/authenticating-ldap/
I imagine it like this:
A user can create a central account (LDAP) and gets access to all application that the LDAP admin unlocked for him/her.
Or am I the only one who is seeing it?? :P

I have to give this a bit more thought

Couldn't Traefik be used to add authentication with client certificates? It's far from LDAP authentication, but it's a start...

I think your right. Maybe like this!? https://docs.traefik.io/v2.0/middlewares/basicauth/

That's for HTTP Basic authentication, which is also an option indeed. Traefik also supports TLS client certificates for authentication: https://docs.traefik.io/v2.0/https/tls/#client-authentication-mtls
And then there's the possibility to forward authentication requests to an external service: https://docs.traefik.io/v2.0/middlewares/forwardauth/
Note that the configuration Ansible-NAS uses is still for Traefik 1.7: https://github.com/davestephens/ansible-nas/pull/132


 Hopefully fixes in this version's new filters help you scan less items than you need to. Please let us know if they're resolved, thanks!
Additionally, I'll look into adding longer delays for lower-end PCs.

Now the scanner closes itself during scan, 2 tries and it just closed itself.
InventoryKamera.log

Newer versions should have a slow scan option which should be enough for low-end computers. If that is still too fast... I guess I could make it even slower?

How about replacing the speed slider with a textbox for the desired ms value?

Letting users set delays manually would be more trouble than it's worth to debug. There are also varying specific delays based on the selection from the menu.


Add docs for setup and testing

It'd be great if there are docs to:

setup
use
test
flamingo.

It could be as simple as the quickstart for cloud-init at http://www.projectatomic.io/docs/quickstart/

I've provided documentation for the tasks you've listed as well as script binaries to test/build/install flamingo. You can also get the binary built for fedora from v0.1.0


chore(deps): upgrade jenkins-x/jx3-versions to version 1.1.29

from: https://github.com/jenkins-x/lighthouse.git

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign cagiti
You can assign the PR to them by writing /assign @cagiti in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Exchange: HITBTC

{
  "name": "hitbtc",
  "docurl": "https://api.hitbtc.com/#socket-market-data",
  "wssurl": "wss://api.hitbtc.com/api/2/ws",
  "pairs": "BTCUSD, LTCUSD, LTCBTC, ETHUSD, ETHBTC, ETCUSD, ETCBTC, BFXUSD, BFXBTC, RRTUSD, RRTBTC, ZECUSD, ZECBTC",
  "active": "N"
}

Second exchange to try. Going to add ability to send exchange name from command line e.g. server.js hitbtc so the same code can run up exchanges independently. For now options will be
server.js  -> do nothing
server.js  hitbtc -> do hitbtc
server.js  bitfinex -> do bitfinex

Moving this bit to different issue "Going to add ability to send exchange name from command line e.g. server.js hitbtc so the same code can run up exchanges independently. For now options will be
server.js -> do nothing
server.js hitbtc -> do hitbtc
server.js bitfinex -> do bitfinex"


How to handle several versions?

@FuXiming, @nh36, I need some info here on different versions of the same text passage, so I can think of how to handle this best. Any quick explanations?

Hey @LinguList, when you say you need info on different versions of the same text passage, can you explain the problem a bit further? Happy to give all the details you need. (Sorry, new to Github so if this comment is pointing to something more specific I might just not be seeing that.)


Declare httpd a requirement dependency of UI and API workers

Both of these workers expect Apache to be running, so declare a requirement dependency on httpd.service for them.
Wants= will start the units whenever the declaring unit is started but has enforces no explicity ordering like After= or Before= [ref].
Since we just need Apache to start whenever the UI/API are running we don't need to enforce any ordering.

I'm not sure when we start apache (or if it is always enabled on every appliance)

This PR just keeps getting better 😄

Can we drop the following too?

https://github.com/ManageIQ/manageiq/blob/acdc1ccdaa3a01060415f2499455e3e3fe9b54ca/app/models/miq_ui_worker/runner.rb#L6
https://github.com/ManageIQ/manageiq/blob/acdc1ccdaa3a01060415f2499455e3e3fe9b54ca/lib/workers/evm_server.rb#L109

Once those are removed I think we can drop the entirety of MiqApache::Control - https://github.com/ManageIQ/manageiq/blob/acdc1ccdaa3a01060415f2499455e3e3fe9b54ca/lib/miq_apache/control.rb

Once those are removed I think we can drop the entirety of MiqApache::Control - https://github.com/ManageIQ/manageiq/blob/acdc1ccdaa3a01060415f2499455e3e3fe9b54ca/lib/miq_apache/control.rb (and possibly MiqApache::Config)

yeah, what's left... think of the orphans... don't leave them homeless. 🔥

We need https://github.com/ManageIQ/manageiq/blob/acdc1ccdaa3a01060415f2499455e3e3fe9b54ca/app/models/miq_ui_worker/runner.rb#L6 to start httpd in the ui worker pod

The ruby worker starts httpd, the container only runs the entrypoint script launching the ruby worker.

Sorry - I meant I understand how it works now, but is it possible to change it to not work that way, and always start these 2 processes (the worker and httpd).

We can probably switch to using dumb-init or something similar in the UI worker container that will launch both.

Can we also delete MiqApache::Control.start and stop?

Okay I'll leave MiqApache::Control for now

I'm good with dropping the rest in a follow-up :+1:.  This LGTM


support described values

See https://github.com/jondot/storybook-cartesian#beautiful-names-for-variants :)


mmctl: 7.10.5 -> 9.2.2

Description of changes
This PR updates mmctl version to v9.2.2, which is the latest release
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Wow, right, I didn't see mmctl moving to the monorepo. Tested, LGTM. Thanks!

@ofborg build mmctl mmctl.passthru.tests


Jupyter content

Replacing PR #129 with content in a separate branch.

Realized I forgot to update the toc this time to point to the jupyterlab file. Fixed now

Julia, this looks really great! I've made a few comments in ReviewNB.
One thing that we might want to consider as a separate issue is adding a video to go along with the documentation. With all of the moving parts in trying to explain the Jupyter environment a video might really help. CC'ing @ncorbin-id for her thoughts.

Julia, this looks really great! I've made a few comments in ReviewNB.
One thing that we might want to consider as a separate issue is adding a video to go along with the documentation. With all of the moving parts in trying to explain the Jupyter environment a video might really help. CC'ing @ncorbin-id for her thoughts.

Most of this content is from the Jupyter video on our Youtube. Do you think embedding that video at the end is the best move or that we should edit that video into several small videos that are embedded after each section? We can address this is a different issue / PR as you say.

Updated the timing and removed experience level, in line with the new template (thanks @r-ford !)

Julia, this looks really great! I've made a few comments in ReviewNB.
One thing that we might want to consider as a separate issue is adding a video to go along with the documentation. With all of the moving parts in trying to explain the Jupyter environment a video might really help. CC'ing @ncorbin-id for her thoughts.

Most of this content is from the Jupyter video on our Youtube. Do you think embedding that video at the end is the best move or that we should edit that video into several small videos that are embedded after each section? We can address this is a different issue / PR as you say.

Per our conversation today I will open an issue to possibly create a video that is synched with this notebook. However, in the interim can you add a link to the existing video that you have, possibly under the other references section

Okay I've tried to really dig in and have left, uh, plenty of feedback (sorry!). It's really such good content that all I had to dig for was pretty nitpicky. This will be an excellent addition and is nearly ready to go in, with really the biggest thing likely settling the above discussion about import hello. Thanks a ton @jukent!

Error:
Error: Resource not accessible by integration
Error: See this action's readme for details about this error

the same as elsewhere. Does not have to do with the content in this PR but some permissions upstream.

Since it looks like @brian-rose's (and everyone else involved!) reviews were addressed, I'm going to go ahead and merge for the selfish reason that I'm ready to tweet about it! Thanks a ton @jukent and all who reviewed.


how to get empty buckets?

Hi,
Is there a way to get all the buckets (also empty ones) in a result? It would be useful in "should" (or) queries to expand the search.
We can get around it doing an extra query but its a bit cumbersome.
Thanks
PS: I tried posting a similar question in the Google Group (as it seems more appropriate for questions), but it did not go through.

Sorry for the issue posting to the google group.  Everyone's first message to the group is moderated, and I must have missed the notification that your message was in the queue.  I will try to add more moderators to the group so we can avoid this in the future.
Can you provide an example of what you are asking for?  Like what kind of query and facets are you specifying, and which empty buckets you want returned (some facets create buckets dynamically, making this part unclear)?

Ok no problem. Since you answer - here lets continue...
Yes sure. I add fields like this to the documents:
doc.AddField(bluge.NewKeywordField("color", c).Aggregatable())
...

And then when I create a search I specify the same eg.
q.AddMust(bluge.NewTermQuery("black").SetField("color"))
agg := aggregations.NewTermsAggregation(search.Field("color"), 10)
req.AddAggregation("color", agg)
...

In this case I will get the "color" aggregation in the result, but it will only contain the "black" bucket with some count value > 0.
I would like to get all the colors with a count = 0 as well.
Is there an option for that?
Thanks in advance,


[Bug]: During the process of identifying chapter items within PDF documents using the rec.onnx model, a specific recognition error occurs

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
main
Other environment information
No response
Actual behavior
This error involves the character "十", which represents the number ten in Chinese, being incorrectly identified as "于". This misinterpretation becomes evident when the model attempts to read phrases such as "第十条" (meaning "Article 10") or "第十二条" (meaning "Article 12"), where "十" should denote the digit ten.

use book parse method

Expected behavior
No response
Steps to reproduce
no

Additional information
No response

This may be an error that occurred during OCR model recognition. This issue can be resolved by improving the model's capabilities in the future.


Feature/mm project model tests

This branch will add unit tests to the project model

I am closing this to keep all the unit tests im doing in their own branch, seperate commits


Refs/heads/my slide

OK

ok

ok

Good pull requests have a body description that tells other contributors about the change you're suggesting, so they understand the context.
Let's edit this pull request to add a body description.
keyboard Activity: Fixing your pull request
1. The first comment on your pull request will have the default text of **No description provided**. Click on the **...** icon located at the top right corner of the comment box, then click on **Edit** to make an edit

2. Add a description of the changes you've made in the comment box. Feel free to add a description of what you’ve accomplished so far. As a reminder, you have: created a branch, created a file and made a commit, and opened a pull request

3. Click the green **Update comment** button at the bottom right of the comment box when done

If you would like assistance troubleshooting the issue you are encountering, create a post on the GitHub Community board. You might also want to search for your issue to see if other people have resolved it in the past.
I'll respond when I detect this pull request's body has been edited.


Use strict mode and block scoping, update readme examples

Summary
index.js

use es6 block scoping for variables in index.js
use strict mode
note: this script is jshint-compliant with the following config (asi:true, node:true, esnext:true)

README.md

update the code examples to match updates in index.js
use syntax highlighting for code blocks

Thank you!


[BUG] SKImage.FromEncodedData(String) returns image with broken alpha on GPU backend

Description
We are using 1.68.1 and see that SKImage.FromEncodedData(String) loads PNG images with broken alpha when drawn on GPU backend.
Code
using (var image = SKImage.FromEncodedData(path))
{
   canvas.DrawImage(image, new SKPoint(400.0f, 100.0f));
}

Expected & Actual Behavior

Basic Information

Version with issue:  1.68.0, 1.68.1
IDE:  Visual Studio
Platform Target Frameworks:

Windows Classic:  Windows10

Target Devices:

Desktop

Reproduction Link
SkiaApp.zip

This is not the only overload with this behavior. I've faced the same issue with Stream overload if I am remember it correctly. Fixed it with use of another overload.

I'll have a look and see what I can find out. Maybe something is broken in the decoder that is not using the correct alpha from the file - but - it works in raster...

Thanks for the issue. I got a fix building and it will be in the <IP_ADDRESS> release.


Improve documentation of relationships between operations

This adds a bunch of improvements to the documentation introduced in https://github.com/ably/ably-asset-tracking-common/pull/74. See commit messages for more details.
As an example, here's the subscriber diagram before:

and after:

And here’s the publisher enhanced location update diagram before:

and after:

I'm currently working on changes to the subscriber diagram. Do you have an idea about the approach to keeping those diagrams up to date? 🤔

No, good question! I didn't think about creating a process for updating them, because I mainly created the diagrams to help build my own understanding of the current behaviour, and wasn't sure if anybody else would care about them or want to maintain them. The documentation does say that they describe a fixed commit of the codebase, so hopefully people won't automatically assume they're up to date.
Do you think it would be worth us making sure we keep these diagrams up to date?

I'm currently working on changes to the subscriber diagram.

🎉 awesome!


Single Table Inheritance (STI) doesn't work with nested JSONAPI::Resource

When I have the following setup
routes.rb
namespace :namespace do
    jsonapi_resources :animals
    jsonapi_resources :farms do
        jsonapi_resources :animals
    end
end

resources/namespace/animal_resource.rb
class Namespace::AnimalResource < JSONAPI::Resource
    immutable
end

resources/namespace/cat_resource.rb
class Namespace::CatResource < Namespace::AnimalResource

end

When making a request to /namespace/animal-resources/5 the type is cat as it should be according to https://github.com/cerebris/jsonapi-resources#immutable-heterogeneous-collections
however, when making a request to /namespace/farms/1/animal-resources/5 the type is animal, but it should be cat
This seems to be a bug, any thoughts?

I'm not a maintainer, but as per this comment:

Nested resources are not yet a supported feature.

I think the fact that you're "allowed" to create such routing structures anyway is an accidental side effect of using blocks to customize which relationship/related-resource routes are generated.
As a point of advice, it usually makes sense to have routes be as shallow as possible (so e.g. /farms/1/animals is valid, but individual animals are accessed at /animals/5). While the JSONAPI spec doesn't technically prescribe any route structure, this is the structure used in their examples, and is also the only structure supported out of the box by many client libraries. JSONAPI::Resources itself also assumes your routes are arranged this way when it generates links (i.e. the generated link for an animal will be /animals/5 even if you have no such route).


[upstream] NUMA bindings support for private memory

This change is

@igchor @byrnedj thank you for the review. I have created PR195 to Meta's repo.


CAMEL-11704

This PR allows a queue to be declared "passively".

Thanks, I will review soon.

Thanks the PR has been merged. Can you close this?
For the next PRs (I hope there will be others :-) ) can you please run:
mvn -Psourcecheck

and fix the codestyle and then
mvn clean install

to eventually update the docs generated automatically?
Thanks :-)

Ok, thank. What about the conflicts, don't they need to be resolved?

It is already merged. The conflicts are related to the fix I've done to fix the code style.

ah, I see. Thanks for your time!.

Thanks to you for the contribution :-)


Implement automagic KMS server discovery in pykms_Client

https://github.com/SystemRage/py-kms/issues/121

Duplicate of #45

This is not a duplicate this is a feature request

sry

From my understanding, the py_client is ran to bootstart the local kms server in order to reach 25 activations.
what would be the usage to query random kms servers ? (well, server would be known after a DNS request srv _vlmcs._tcp)

py_client is ran to bootstart the local kms server in order to reach 25 activations

Nope, just to trigger the database creation for the sqlite webinterface...

what would be the usage to query random kms servers ?

Could you elaborate?

py_client is ran to bootstart the local kms server in order to reach 25 activations

Nope, just to trigger the database creation for the sqlite webinterface...

what would be the usage to query random kms servers ?

Could you elaborate?

Automatic KMS discovery is based on _vlmcs._tcp.domain.tld DNS query. Should you have two or more KMS server on your lan, you can't know for sure what will be the DNS answer, hence what would be the KMS used to activate your client.
although, I get the point, If you wish to validate kms discovery the py_kms client, that feature is needed.

#66 is a proposition to implement KMS discovery feature.

Closed, feature merged in #66


Fix repeat flag doesn't terminate monika on fail probe

Monika Pull Request (PR)
What feature/issue does this PR add

#1164

How did you implement / how did you fix it
There are several bugs that causes the issue #1164

The setProbeRunning is called almost every second in this line https://github.com/hyperjumptech/monika/pull/1165/files#diff-c3cb2be3e6fbad9e8455e2fc282a2d52cc7875688162e517023bff5be26371b6L54. The fix: moved it back down as originally written.

The retry function is called without maxAttempt here https://github.com/hyperjumptech/monika/pull/1165/files#diff-c3cb2be3e6fbad9e8455e2fc282a2d52cc7875688162e517023bff5be26371b6R81. This causes Monika to keep retrying to monitor the probe in a cycle which causes the bug in #1164. The fix: added maxAttempt with value whichever bigger between incidentThreshold and recoveryThreshold because we want to retry for both incident and recovery cases. See below for more information.

Removal of recoveryThreshold causes the recovery notification to be sent immediately upon recovery. But we don't want that. Just like we don't want to immediately send incident notification, Monika needs to retry several times first before sending the recovery notification. The fix:

restore the recoveryThreshold and remove the deprecation warning https://github.com/hyperjumptech/monika/pull/1165/files#diff-028bd48d9206d28afc908d305ef5ac57026ad51ba014a0741fb8abcaef2af741R113. I think there was misunderstanding, we just don't want user to be able to set the threshold from symon, but we still need it in Monika.
don't immediately send the recovery notification, instead keep retrying until recoveryThreshold. https://github.com/hyperjumptech/monika/pull/1165/files#diff-537950d0505c20b7b3ec67590102fdafdbbbbddb0130d5dbf7a4ac232060598dR152

Some further changes to improve performance:

Set the default retryInitialDelayMs value to 2 seconds. 128 milliseconds is not a sensible default. There's no need for Monika to retry that fast. https://github.com/hyperjumptech/monika/pull/1165/files#diff-06df4a808fa037b48c082497d352cb7825c883648d52a17ab72b0e7dd70a5c5dR84
Remove unnecessary error throws, e.g., https://github.com/hyperjumptech/monika/pull/1165/files#diff-5d5a93a3e7827f41dca4b896d385bc9ab744774dd26149e2f605fbe064398021L134

Probing Mechanism
With this PR, I also fixed the probing mechanism. This is how it works.
Say we have the following probe:
probes:
  - id: '1'
    name: Localhost
    description: Check status
    interval: 5
    incidentThreshold: 3
    recoveryThreshold: 3
    requests:
      - method: GET
        timeout: 10000
        url: http://localhost:8000/api/delay
    alerts:
      - assertion: response.time > 800
        message: Response time > 800

Then say the server in the localhost:8000 is offline (unreachable). The process will go like the following:

In the first cycle, Monika will try to probe it but fails. Monika will not send the incident notification immediately. Instead, it will retry 3 times (based on the incidentThreshold) with exponential backoff algorithm.
If in the second retry, the server is up, then it will do nothing and just wait for 5 seconds (based on the interval) to start another cycle.
On the other hand, if after 3 attempts the server is still unreachable, it will send the incident notification, and mark the probe as has incident. Then it will wait until 5 seconds (interval) has passed to probe it again.
In the next cycle, if the server is online, Monika will not send the recovery notification immediately because the probe was marked as incident previously. Instead, it will retry to monitor the probe 3 times (according to recoveryThreshold) before sending the recovery notification.

The same process is also executed when the probe can reached but the assertion fails which in this case when response's time is greater than 800 ms.
When the -r flag is provided, Monika will perform as many cycles as defined by the repeat flag value. However, it will also still do retries in case of incident and recovery as defined by the probes' incidentThreshold and recoveryThreshold if provided, or use their respective default values.
How to test

Use the following monika.yml:

probes:
  - id: '1'
    name: Localhost
    description: Multiple
    requests:
      - url: http://localhost:3000

npm run start -- -c ./monika.yml -r 2

Screenshots
Running with -r 1 and the probe cannot be reached (offline):

Running with -r 2 and the probe cannot be reached (offline):

Running with -r 1 and the probe can be reached (online):

Running without -r flag (continuously):

I can't seem to reproduce the first case where the config is monika.yml with -r 1 flag. I still have the incident threshold as 5 instead of 2:

But after the probe is marked as incident Monika stopped itself though. Was it intended or not?

The first and second cases are by design. The fourth case should be fixed now.


Make pacakge optional when using -r/--requirements

Just noted that it's useful to make package optional in this case.

Hmm—doesn't * imply that already? (Zero or more)
https://docs.python.org/3/library/argparse.html#nargs

Unfortunately not (at least in testing).

The argparse documetnation seems to back this up too. I don't think * actually means zero or more :/

The lack of * meaning zero or more could also be a bug in Python 2.6.x which we are still on largely here at APN

Actually let me test this again on Python 2.6 :) Just to be sure!

I think I jumped the gun with this one haha :) Sorry! Must have got confused by something else that was going on!


Mccalluc/all assay types

Ivan is going to to update this list, with just the codes they are actually using, so I'll close this.


FIX: depends on param >= 1.12.0

Is fixing #1019 actually this simple? Sorry if not, just trying to be helpful.

Hi! I think it is almost this simple :) you just need to open this PR against the holoviz/hvplot repository rather than in your own fork. You should see a little "edit" button at the top of this pull request and you can change the target there.


Update adobe-ims-config.md

@andimov  You must complete the CLA to submit through this external repo. It is strongly recommended for Adobe employees to submit PRs in the internal repository (https://git.corp.adobe.com/AdobeDocs/commerce-admin.en).

@leslietilling I'm closing this PR as I've created an internal one https://git.corp.adobe.com/AdobeDocs/commerce-admin.en/pull/29
could you please review it?


Circle Pack

This is more of a tech demo but it's an interesting one to have. That being said can you improve your PR to describe what you've done.

This is more of a tech demo but it's an interesting one to have. That being said can you improve your PR to describe what you've done.

Should I put the description in a README file?

You could do that but just writing a description here is also okay.

Also snapshot should reference one of the file names in your snapshots folder.

Also snapshot should reference one of the file names in your snapshots folder.

wydm?

oh okay

It does 👍

This
@snapshot: circlePacker
should be this
@snapshot: circlePacker.png

circlePacker

👍

Okay I fixed it for you. You can order your Blot here. Congrats!


Add support for grpc-web.

Description
Support grpc-web,
Note:
need to implement grpc-web listener on ion-sfu first
Reference issue
Fixes #59

We need to remove the references to
import IonSFUJSONRPCSignal from './json-rpc-impl';
import IonSFUGRPCWebSignal from './grpc-web-impl';

in src/signal/index.ts
Otherwise they and their dependencies will be bundled even if we arent using them. Users should instead import directly. Like
import IonSFUJSONRPCSignal from 'ion-sdk-js/src/signal/json-rpc-impl';

or
import IonSFUGRPCWebSignal from 'ion-sdk-js/src/signal/grpc-web-impl';

I don't quite understand if it is not exported in indiex.ts, how to select the signaling type on-demand in the compressed ion-sdk.min.js

hmm we will need to create separate bundles then. otherwise if i am using my own custom signaling module, i am still sending my clients all of the proto js ect

So，we should modify the webpack rules to generate separate js bundles.
look like this:
<script<EMAIL_ADDRESS><script<EMAIL_ADDRESS>
Is that correct?

@tarrencev
I modified webpack to separate bundles,
Three independent files will be output, and the corresponding js can be loaded as required.
ion-sdk-js% ls -lh dist
total 2232
-rw-r--r-- 1 duanweiwei staff 1.0M 12 5 17:21 grpc-web.min.js
-rw-r--r-- 1 duanweiwei staff 44K 12 5 17:21 ion-sdk.min.js
-rw-r--r-- 1 duanweiwei staff 63K 12 5 17:21 json-rpc.min.js

use json-rpc in echotest.html.
    <script src="dist/ion-sdk.min.js"></script>
    <script src="dist/json-rpc.min.js"></script>

    const jsonrpc = new Signal.IonSFUJSONRPCSignal("ws://localhost:7000/ws" );

    const client = new IonSDK.Client(jsonrpc);

    jsonrpc.onopen = () => client.join("test session")

use grpc-web in echotest.html.
    <script src="dist/ion-sdk.min.js"></script>
    <script src="dist/grpc-web.min.js"></script>

    const grpcweb = new Signal.IonSFUGRPCWebSignal("http://localhost:9090" );

    const client = new IonSDK.Client(grpcweb);

    grpcweb.onopen = () => client.join("test session")

@cloudwebrtc Awsome.  we can add ion-grpc-web base on grpc-web which support pion/ion so that ion-app-web can use it. @cgojin
This depends on @tarrencev review


Add support for Maya 2020

Tasks:

Officially add support for Maya 2020 in the build system
Provide binaries for the next release

Quick experiments show that Serlio compiles and works for Maya2020 on Windows without any modifications and on Linux it only requires a trivial one line change

Merged support for Maya 2020 to develop branch

Fixed in v2.0


Fix support for oneTBB new inteface >= v2021.1

Submitting a support for oneTBB new interface. I suggest that this should be tested with a proper CI/CD.
oneTBB library do not provide <tbb/tbb_stddef.h> anymore as can be seen here. It is now replaced by <tbb/tbb.h> since v2021.1.

I believe __has_include is only available for C++17, while Stan still supports C++14 as a minimum.
Are you defining TBB_INTERFACE_NEW during compilation? That is required to use Stan-math with TBB 2021

Instead of relying on the makefile, I use CMake's FetchContent to integrate Stan-math into my project as a module. This approach streamlines the build process and eliminates the need to install unused components, allowing greater flexibility in managing dependencies.
I could find related interest in using FetchContent + CMakeList.txt in  #2967
include(FetchContent)
FetchContent_Declare(
     stanmath
     GIT_REPOSITORY https://github.com/jeanchristopheruel/math
     GIT_TAG develop
     GIT_SHALLOW TRUE
     )
FetchContent_MakeAvailable(stanmath)

find_package(Boost 1.81.0 REQUIRED)
find_package(TBB 2021 REQUIRED)
find_package(Eigen3 3.4 REQUIRED)

add_library(stan-math INTERFACE)
target_link_libraries(stan-math INTERFACE Eigen3::Eigen TBB::tbb -lstdc++ -lm)
target_include_directories(stan-math INTERFACE ${stanmath_SOURCE_DIR} ${Boost_INCLUDE_DIRS})
add_library(stan::math ALIAS stan-math)

#2967 is definitely the right place to discuss CMake, and I'm hoping we can support it sooner rather than later.
In the mean time, you should still be using target_compile_definitions or just add_compile_options to define TBB_INTERFACE_NEW as the way of selecting to use newer versions

Thanks for your time. I will do so. However, it still wont support TBB_VERSION_MAJOR == 2021. Current statement for #if TBB_VERSION_MAJOR >= 2020 will fail.

We use TBB 2021 for the conda-forge builds of cmdstan with this. If you can share the error you are getting I can try to help debug it, but it is definitely possible to use newer TBBs without source changes

OneApi TBB does not have tbb_stddef.h anymore. TBB does.
Migration guide TBB -> OneApi TBB

If you define TBB_INTERFACE_NEW, that header will not be included by Stan Math

Indeed, as you previously pointed out. My apologies.
Closing issue.


Improve playground design

While the playground is meant to be showcase of the tools and feature interesting components that developers can easily fork to their projects, the design could also be improved and more pleasurable to look at.
For example dark mode might be nice improvement, more animations, more notifications and visualizations.

Postponing due to more important tasks in pipeline.


Mesh expansion: connect VM without public IP and without using VPN

I'd like to add VM worker node to a cluster. VM is behind NAT and doesn't have public IP.
I need to access a service running on this VM from Kubernetes cluster (VM access to cluster services not needed).
How to accomplish this task without using VPN?
I follow this guide to setup istio-sidecar connection from VM to the cluster, but to my surprise, I cannot use this connection for exposing VM service to cluster. It is said that I need to create ServiceEntry for service resolution using VM IP (like for third party external service).
So what is the point of establishing a connection between istio-sidecar (on VM) and the main cluster if I cannot use it (for port forwarding)?

@irisdingbj would you be king enough to answer this question and see if there is engineering work involved here?
Cheers
-steve


Update grpc-device to use black auto-formatter

What does this Pull Request accomplish?
Update grpc-device to use black auto-formatter.
Exclude metadata, which uses a different "pretty printed" python style.
Why should this Pull Request be merged?

black 100 is the ni standard python style.
grpc-device has very inconsistent python style, which is frustrating for developers.
grpc-device uses an auto-formatter for C++ code, which makes IDE config challenging to exclude python.
black is great!

What testing has been done?
Ran and passed black source\codegen examples .

Note:
@SparkingSpork @reckenro @mgumble
Going straight to owners because this is mostly a philosophical PR and you might as well start considering it now.
+@DavidCurtiss because we're already discussing this.

@harsha-bhushan because this affects examples (although we already use black formatting for some examples).
@doshirohan as representative of NIB team.


Additional fixes for Oracle schema support

fixes #4595

@code-ape Could you please test this branch?

@kibertoad confirmed that this fixes "knex.dropTable() errors on Oracle when .withSchema()" (#4595) for our use case. Thank you!


Sandbox .service by default?

Hey there,
from the old DNSCrypt version I remember that the .service could be sanboxed by editing the .service file similiar to this:

[Service]
CapabilityBoundingSet=CAP_IPC_LOCK CAP_SETGID CAP_SETUID
ProtectSystem=strict
ProtectHome=true
ProtectKernelTunables=true
ProtectKernelModules=true
ProtectControlGroups=true
PrivateTmp=true
PrivateDevices=true
MemoryDenyWriteExecute=true
NoNewPrivileges=true
RestrictRealtime=true
RestrictAddressFamilies=AF_INET AF_INET6
SystemCallArchitectures=native
SystemCallFilter=~@clock @cpu-emulation @debug @keyring @ipc @module @mount @obsolete @raw-io

Maybe you could add a similiar approach out of the box?

Most of those is already done https://github.com/jedisct1/dnscrypt-proxy/blob/master/systemd/dnscrypt-proxy.service#L9


Login page improvements

I first formatted the HTML and CSS files of the login page.
Firstly, it increased the size of nav elements and added a hover effect to it.
Added border radius for input boxes.
Added hover effect for forget password and slightly increased it's size
Added hover effect for sign in and sign up buttons both sides
Increased size of text below hello friend and welcome back
Added margins to improve layout.

#29

Please consider this PR for hacktoberfest


Add README explaining test suites input files format

Mbed TLS test suites use source and data files in tests/suites/. Their format needs to documented for development and maintenance purpose. Since #930 changes the framework this issue should be worked after #930 is merged.
Documentation should include:

All relevant file formats
generate_test_code.py limitations/assumptions
Guideline for creating new tests: data & functions.

While it isn't exactly what was originally requested, I'm marking this task as fulfilled by https://tls.mbed.org/kb/development/test_suites . It documents the relevant file format, and includes some guidelines for writing tests.
I've filed https://github.com/ARMmbed/mbedtls/issues/3618 to improve the documentation with some non-obvious cases.


Error when entering to an app

Problem
When I try to enter to an app, the program crashes with a git error, but I can't understand what is exactly the problem. I searched it in google, and it seems to be relative to git commit, and I don't understand why is there a git commit.
Screenshot

Environment details
I used the npx srcbook@latest start and npm install -g srcbook and no one worked, so I don't think that it's the problem. I'm in Windows 11 and I have git installed and I only configured the name and email.

I don't know if it's necessary, but when I say app I refer to this:

So, can someone explain to me what's the error?

This bug should be fixed in 0.0.15.
Try:

deleting the app
install the latest version (0.0.15) with npx srcbook@latest start
create a new app

If this still doesn't work, let me know

Same behavior and now is using the 0.0.15

Yeah, we don't support windows yet unfortunately, as described in https://github.com/srcbookdev/srcbook/pull/444
To solve this, we brought the app online at https://srcbook.com
It's currently free to use, let me know if this solves your needs!


Deeper contribution possible?

Hey!
I don't know if you've read https://github.com/mycargus/nightwatch-docker-grid/pull/6#issuecomment-324909538 but I'd like to build a testing grid such as this one around a project I have and have made lots of improvements/fixes of the work you've done by trying to adapt it to my project.
So my "question" is, is there a way I can do a big contribution? I'm afraid this potential contribution will never be make it if delayed too much. Maybe a big PR made of small intelligible commits? Atomic commits as suggested in my comment? Tell me, I'd like to participate/help. :)
cheers
EDIT: I've bundled my commits, I'll make a PR, you can close this if it suits you

Wow, thanks for all the work! Usually I'm a fan of small-as-possible PRs with limited scope, but I'll take a look this week.
Sorry I've not been more available to review your requests. I've had to focus on my employer's needs lately. Normally I'm not so busy. :)
I'll close this thread and we can continue discussions in the other issue you opened.


chore: add Bazel support

Blocked by: https://github.com/bazelbuild/bazel/issues/6176

See https://github.com/alexeagle/angular-bazel-example/pull/228

How far is your implementation ? There is no issue open for this pr.

The feature issue was simply: switch the build system to bazel :D


need more details in the name for a kusto script

I'm trying to create a kusto script.  the name will be "dm"  which is too short.  It should had least have 3 chars, but the error message doesn't say that.
PS C:\workspace\azure\poc-azure\azure-templates\iothub-to-data-explorer> az kusto script create --cluster-name pocdaxsdionne --database-name pocadx --name dm --resource-group rg-sdionne --force-update-tag<PHONE_NUMBER> --script-content ".create table [dm] (data: dynamic)"
Command group 'kusto' is experimental and under development. Reference and support levels: https://aka.ms/CLI_refstatus
(InvalidScriptName) Invalid value 'dm' for property 'Script Name'. Expected only alpha-numeric, spaces, dash and dot characters, and be less than 260 characters in length..
Code: InvalidScriptName
Message: Invalid value 'dm' for property 'Script Name'. Expected only alpha-numeric, spaces, dash and dot characters, and be less than 260 characters in length..

it I try with "dm2" it sill works
PS C:\workspace\azure\poc-azure\azure-templates\iothub-to-data-explorer> az kusto script create --cluster-name pocdaxsdionne --database-name pocadx --name dm2 --resource-group rg-sdionne --force-update-tag<PHONE_NUMBER> --script-content ".create table [dm] (data: dynamic)"
Command group 'kusto' is experimental and under development. Reference and support levels: https://aka.ms/CLI_refstatus
Long-running operation wait cancelled.

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az kusto script create Extension Name: kusto. Version: 0.5.0.
Errors:

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az kusto script create --cluster-name {} --database-name {} --name {} --resource-group {} --force-update-tag {} --script-content {}

Expected Behavior
Environment Summary
Windows-10-10.0.19044-SP0
Python 3.10.5
Installer: MSI

azure-cli 2.40.0 *

Extensions:
azure-devops 0.25.0
azure-iot 0.17.1
kusto 0.5.0
spring 1.1.7
spring-cloud 3.1.5
storage-preview 0.8.3

Dependencies:
msal 1.18.0b1
azure-mgmt-resource 21.1.0b1

Additional Context

@survivant Thanks for your feedback! We will investigate and update as appropriate.

route to CXP team

Hi @survivant and thank you so much for contacting!
I've been looking into the issue and enriched the error message:
script name should be at least 3 characters.
This is why "dm" fails altogether "dm2" succeeds :)
This shall be updated in the following deployment.
Thanks once again for letting me know, and don't hesitate to contact in any issue or concern.

This is fixed.

Perfect!
Aviv Yaniv
Sitehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.tau.ac.il%2F~avivyaniv%2F&data=04|01|avivyaniv%40microsoft.com|af2eef4507a242876aec08d99654635a|72f988bf86f141af91ab2d7cd011db47|1|0|637706111603431191|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=IsUn8cvS7QO7Lt0FDu4Tx1eM16KlgANQNwT4aw4WO8E%3D&reserved=0 ★ Bloghttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Favivyaniv.medium.com%2F&data=04|01|avivyaniv%40microsoft.com|af2eef4507a242876aec08d99654635a|72f988bf86f141af91ab2d7cd011db47|1|0|637706111603431191|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=2WLU9CX%2FH0lh5%2F4nB96bokudevXIxwneHLn67YLPn58%3D&reserved=0 ★ StackOverflowhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstackoverflow.com%2Fusers%2F14148864%2Faviv-yaniv%3Ftab%3Dprofile&data=04|01|avivyaniv%40microsoft.com|af2eef4507a242876aec08d99654635a|72f988bf86f141af91ab2d7cd011db47|1|0|637706111603441146|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=0akMCdDpXfMnPVqx8XZF4frn4k%2FDxB1xX%2BfoW%2FF9k2M%3D&reserved=0 ★ GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAvivYaniv&data=04|01|avivyaniv%40microsoft.com|af2eef4507a242876aec08d99654635a|72f988bf86f141af91ab2d7cd011db47|1|0|637706111603441146|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=5eEGhxx8XwC3wT2qC6cf1m2zott88Q3lNSphgzT3pGo%3D&reserved=0 ★ ProjectEulerhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fprojecteuler.net%2Fprofile%2FAviv_Yaniv.png&data=04|01|avivyaniv%40microsoft.com|af2eef4507a242876aec08d99654635a|72f988bf86f141af91ab2d7cd011db47|1|0|637706111603451106|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=oB0M6ILuVN35gdHOlO1%2FgbvcCL87zBCap0xkoZ2su2w%3D&reserved=0

From: RakeshMohanMSFT @.>
Sent: Friday, January 6, 2023 10:30:34 AM
To: Azure/azure-cli-extensions @.>
Cc: Aviv Yaniv @.>; Mention @.>
Subject: Re: [Azure/azure-cli-extensions] need more details in the name for a kusto script (Issue #5460)
This is fixed.
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F49954584%2F210961870-238410cb-2e15-41fc-9d5b-a01742f53085.png&data=05|01|avivyaniv%40microsoft.com|55317c2e05ce4c97955408daefc0482e|72f988bf86f141af91ab2d7cd011db47|1|0|638085906414486411|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=OPRisRhzXslJESQTWChVr3TRUFZ53neNNqEPVDkmQYo%3D&reserved=0
—
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli-extensions%2Fissues%2F5460%23issuecomment-1373344206&data=05|01|avivyaniv%40microsoft.com|55317c2e05ce4c97955408daefc0482e|72f988bf86f141af91ab2d7cd011db47|1|0|638085906414486411|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=oE4cJs0ZUcgILLBxtRuuWicAfyIbq9uFEysbslywHaU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAVRTCWI7NG4XTY6C2U6BY63WQ7J2VANCNFSM6AAAAAARHIZGO4&data=05|01|avivyaniv%40microsoft.com|55317c2e05ce4c97955408daefc0482e|72f988bf86f141af91ab2d7cd011db47|1|0|638085906414486411|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=OBhNdAw8ehfsacd4GwP%2BcvIlK8X4aORS3BhAkwzFE%2BQ%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>


Account reset UI

Adds UI for chatting with users with account resets during your chat conversation.

You can go back and forth between resets, handles TLFFinalize notification.
@keybase/react-hackers

The commits dc664617ea32...ffc6712515fe introduce visual changes on linux. :mag_right: 1 changed

Changed: Old_Profile_Reset_Notice-Normal (before) (after)

The commits dc664617ea32...43a1c3ec26c2 introduce visual changes on linux. :mag_right: 1 changed

Changed: Old_Profile_Reset_Notice-Normal (before) (after)

The commits e9038c9d12bb...10bcbc89fdf9 introduce visual changes on linux. :mag_right: 1 changed

Changed: Old_Profile_Reset_Notice-Normal (before) (after)


Backend/deployment support for setting the OCP cluster name

The base domain name gets updated when zvm-ipconf is run. Customer feedback asks that the name of the OCP cluster also be customisable.
This will have to be a co-operative effort with the back-end Ansible code -- many of the tasks currently performed in zvm-ipconf at ISN firstboot will have to be separately executable.
Opening this issue to track the backend Ansible aspects of this (UI aspects are tracked in https://github.ibm.com/fastvm/oqs-header/issues/19)

There was a deployment bug caused by changes for #60 ... the comment on commit fb3677d says "adding Jinja2 raw flags ... so that [we can use] the variable created in ipconf.sh".  I had coded ipconf.sh to generate the cluster_base_domain as a variable, but not cluster_name (which I had also exposed for parameterisation).
There are still places in the inventory that the cluster_name causes an issue for not being exposed.  So, since we will need to have something in ipconf.sh anyway once this gets built, for now let's have ipconf.sh write cluster_name too.

On second thought... let's add it as a runtime-created variable at the command line when invoking the create-cluster playbook.  This will more easily extend to supporting multiple clusters later.

The new OCP interface (being developed in the elan-web repo) has the ability to define multiple clusters and makes the cluster name editable.  This will provide frontend support for changing the cluster name.

Cluster name is captured in the new build process.  Used to create a "cluster service ID", a Linux user on the ELAN that contains all the links etc for the cluster being managed.  The new process does a "define" of the cluster, where dependencies like HAProxy and DNS config are performed, then readies for the "build" of the cluster.


Add EnvironmentFile to GraphDB Service

TES-316
Description
Added an environment file to the service and in the AMI. Changed the script to use it.

Related Issues
TES-316

Changes
Changed build.pkr.hcl, files/gdb_environments, files/graphdb.service, files/install_graphdb.sh

Checklist

[x] I have tested these changes thoroughly.
[x] My code follows the project's coding style.
[x] I have added appropriate comments to my code, especially in complex areas.
[x] All new and existing tests passed locally.

Added in https://github.com/Ontotext-AD/packer-aws-graphdb/pull/14


Make consumer interruptable

Use pcntl_signal_dispatch instead of declare ticks which has lots of overhead.

I've added some extra commits because PHPstorm was complaining about return values for consumer methods and the possibility inside invoke of rejectDispatch() throwing again. The essence is consumer not declaring ticks and driver using time_nanosleep() to make it interruptable. The nanosleep needs to be ported to the other drivers which i can't test (mongo, reddis, etc)

See my comments (before making this branch :-D)
https://github.com/bernardphp/bernard/issues/306#issuecomment-443195565

Thanks @GDmac! Ok for me @sagikazarmark 👍

rebased on current master


FIX: Security::$default_message_set Config value unusable

Security::set_default_message_set() is marked as deprecated and encourages the use of the Security.default_message_set config setting, but that setting isn’t actually used when fetching messages.
I’ve also removed the default empty string value. If the default is a string, setting an array value in config results in a type mismatch exception, whereas if the default isn’t defined you can set the value to either a string or an array.

Can we have some tests for this feature, please?
If there was a bug you're fixing, please recreate the bug in a test and prove it's fixed. also, if there are any other bugs or potentially untested scenarios, that are now resolved, it'd be good to give that some test coverage

Added tests, also removed one of the messages as it’s never used.

Hmm, is that something that's meant to be in 3.2 but some how made it's way into 3.1?

Either way, it should come out if it's not used, but please take it out of the docblock too?
Did you check it wasn't used in CMS?

I don't see how it could even possibly be used.

I’ve removed 'logInAgain' from the docblock too. The array is a local variable that’s never returned or passed to any other methods, so it can’t be used anywhere else. Looking at blame view it looks like it’s a really old (removed) feature that tried to guess if you’d just logged out

Whoop, good riddance!

And I think we made it! thanks

Note problem


iOS : Advertiser assets outside native ad view & MediaView is too small for video

The issue is only for iOS with newly provided nativeTemplateStyle.small

Plugin Version
google_mobile_ads: 3.0.0
Steps to Reproduce

Add a Native ad small size to app
Load Ad
await NativeAd(          adUnitId: nativeAdUnitId,          factoryId: 'listTile',          request: const AdRequest(),          nativeTemplateStyle: AdStyleHelper()              .getStyle(templateType: TemplateType.small, context: context),          listener: NativeAdListener(            onAdLoaded: (ad) {              setState(() {                _adList = ad as NativeAd;              });            },            onAdFailedToLoad: (ad, error) {                          ad.dispose();            },          ),        ).load();
Display
Padding(                  padding: const EdgeInsets.only(left: 15, right: 15),                  child: Container(                    height: _adList != null ? 90.0 : 0,                    alignment: Alignment.center,                    child: AdWidget(ad: _adList!),                  ),                )

keep GADNativeAdValidatorEnabled to true in info.plist
<key>GADNativeAdValidatorEnabled</key>  <true/>

Run flutter App on iOS iPhone X (iOS : 16.4.1)

Ad Validator will display validation error.

Sample App with issue (Issue can be reproduced on iPhone SE 3rd generation simulator as well )
native_template_example.zip
Flutter Doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.0, on macOS 13.3.1 22E261 darwin-arm64 (Rosetta), locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.77.3)
[✓] Connected device (4 available)
[✓] Network resources

Thanks for filing the issue. I also can see it with native_template_example code.
With medium type, there is no issue. Labeling the issue for further investigation.
Plugin version: google_mobile_ads: ^3.0.0

small
medium

@huycozy
Below are few screenshots for Native inline Ads in production for 90 height container.
OS : iOS, iphone 14 (16.4.1 (a))
google_mobile_ads: 3.0.0
Flutter : Channel stable, 3.10.0

@huycozy Below are few screenshots for Native inline Ads in production for 90 height container.
OS : iOS, iphone 14 (16.4.1 (a)) google_mobile_ads: 3.0.0 Flutter : Channel stable, 3.10.0

@huycozy
My bad I had used wrong TemplateType for 90 height, do not consider above message

This issue is still not fixed. I'm getting this issue.

Still not fixed.

The second warning (assets outside native ad view) should be fixed at head with https://github.com/googleads/googleads-mobile-flutter/pull/874.
The first warning is WAI - the small template purposefully has a small media view and video will not serve into it.

plugin version 4.0.0
this problem is still not fixed

Advertiser assets outside native ad view

I'm not using flutter but also having this issue. It only occurred when the Advertiser string is empty. I tried to set minHeight and minWidth on my UILabel but it still keeps showing this message.

same issue with the latest Google Mobile Ads 4.0.0 and Flutter 3.19. Anyone has solution? Do we need to create a custom xib    file for the small native ad?

plugin version 4.0.0
this problem is still not fixed

same issue seems not fixed

same

why would you show a warning if nothing can be done on small? Any updates?


Notification instability, possibly due to concurrent access to sqlite db?

Hi there,
Thanks for the awesome project! I'm having some trouble using this project with my farm. The code is connecting to the Chia RPC endpoints and getting data just fine, but the summary notifications seem to consistently break. I'm using discord for notifications, but I don't believe the issue is specific to the notification provider used.
The usual pattern I see is that I get one notification sent successfully, and then nothing after that. This error will show up in the console, typically within a few minutes of starting up:
2021-07-13T17:25:38.316 ERROR  Failed to retrieve event from DB. Please initialize DB using: 'pipenv run alembic upgrade head'

After instrumenting the code a bit to print more stack trace and exception info, it looks like the underlying error is typically saying that the database is locked, e.g.:
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) database is locked
[SQL: SELECT sum(anon_1.plot_count) AS sum_1
FROM (SELECT max(harvester_events.plot_count) AS plot_count
FROM harvester_events
WHERE harvester_events.ts > ? GROUP BY harvester_events.host) AS anon_1]
[parameters: ('2021-07-13 17:25:03.302213',)]

This error is always thrown in notifier.py in the await asyncio.gather(*tasks) call.
I've attempted to rule out any DB corruption issues by deleting my DB and re-running alembic to create a fresh DB, but that doesn't seem to make any difference.
Have you seen any issues like this in the past? Could it be due to multiple coroutines attempting to use the DB simultaneously?
Happy to provide additional logs/context, just let me know. Thanks!

Hey @cmatthias, thanks for the elaborate bug report and your initial debugging efforts 🙂
You are the first one reporting this kind of issue, but I agree with your suspicion that too many concurrent queries to the DB might be the root cause. We could try to reduce the number of simultaneous queries by awaiting the notifications sequentially.
Could you try to replace the following lines in notifier.py
tasks = [n.run() for n in self.notifications]
await asyncio.gather(*tasks)

with
for notification in self.notifications:
    await notification.run()

and report if that helps to resolve your issue?

@philippnormann
Why not answer my websocket question，wuwuwuwuwuwu

Hi @philippnormann, thanks for the reply! I first tried making that change but was still receiving the same error, unfortunately.
However, I'm now testing an additional fix, which involves adding a couple of arguments to create_async_engine in monitor/database/__init__.py. Setting up the engine using the following line has resulted in no "database is locked" errors for about 20 minutes, which is way better than what I was seeing before.
engine = create_async_engine(DATABASE_URL, echo=False, connect_args={'timeout': 30.0, 'isolation_level': None})

The reason I tried this was that I guessed that somewhere in the code a commit() was being missed, resulting in a transaction locking the DB for longer than it should. As far as I understand it, the timeout: 30 arg means "wait for the lock to be released for up to 30 sec before throwing an exception", and the isolation_level: None arg forces the python sqlite library to use autocommit mode.
I also have the "sequential await" fix that you suggested in place still. Not sure if that's required with the above changes but I will test it out.
I am sure that the timeout arg is probably too long, and I'm not sure how you feel about autocommit mode, but these changes make things more stable for me. I will let this run for some time today and report back. Thanks again!

Hey @cmatthias, I don't feel great about this kind of workaround, but I also failed to find any mistake in our DB usage and therfore suspect the bug to lie somewhere in the async implementation of SQLAlchemy. For now, enabling AUTOCOMMIT and increasing the timeout seems like a good way to mitigate the issue. The documentation I found suggests slightly different parameters:
engine = create_async_engine(DATABASE_URL,
                             echo=False,
                             isolation_level="AUTOCOMMIT",
                             connect_args={'timeout': 30.0})

Not sure if it makes any difference, but I would definitely be curious to hear your results for this variant and the one you suggested without the "sequential await" fix. Thanks again for being so helpful!

Hey again @philippnormann, thanks for the extra info! It turns out I did eventually get DB lock errors (after about an hour) with my original set of changes. I just changed the isolation_level argument to the style you suggested (which I agree looks right based on the docs) and I'll let you know if that does any better.

Looks like I'm still seeing this issue even with your suggested change. I'm racking my brain trying to figure out why no one else sees this, because it's consistently reproducible on my machine. I'm on an Ubuntu 21.04 VM running python 3.9.5, which doesn't seem like it'd be an unusual setup. The underlying storage for the VM is an SSD (so it's not unusually slow). I am running my full chia node, wallet, and harvester on the same machine, so maybe that has something to do with it?
Any other thoughts/ideas would be most welcome :) Thanks for your help so far!

Was seeing something similar, no errors, but I need to restart a few times a day to get notifications back

Hi @philippnormann, wanted to updated you on this issue: I discovered there was a configuration issue with the VM that I was running my chia node and chia-monitor on. The VM's disk image was living on an NFS-mounted directory on the host, meaning the VM's storage was not local to the host and instead was going out over a (probably overtaxed) gigabit network. I discovered this after noticing some other weird I/O behavior on the VM (unrelated to chia-monitor).
After moving the VM's disk to be local on the VM host, this issue disappeared and I have been successfully receiving notifications, even after backing out the changes you suggested earlier in the thread. I'm not 100% sure if there is still an underlying issue in the code that was exposed by my probably-close-to-worst-case I/O scenario, but I'll close this issue for now since the issue as I was experiencing it is resolved.
If you'd still like to investigate more, feel free to reopen this, and now that I know how to reproduce the issue I could set a VM back up for testing any potential fixes.
Thanks so much for your help!


Bank Tags not working?

I have just re-installed the client after seeing that there are no ways to add bank tags.
I have enabled it in the right configuration interface, it is a green checkmark there on "Bank Tags".
But i still cannot add or edit any bank tags, like it only shows "Withdraw" and "Examine" on items on bank when right clicking. How come?

Fixed in #1416


[Poisson Kriging] Add directions to point selection

Is your feature request related to a problem? Please describe.
Using directional variograms in Poisson Kriging (like in Ordinary Kriging and Simple Kriging) would be a good idea. Now Poisson Kriging is only non-directional.
Describe the solution you'd like

[x] Centroid-based PK - directional selection of point support and areas (will be presented in version 0.3.6),
[ ] Area to area PK - directional selection of point support and areas, (will be introduced in version 0.3.7),
[ ] Area to point PK - directional selection of point support and areas, (will be introduced in version 0.3.7).

Describe alternatives you've considered
n/a
Additional context
n/a

It is still unstable part of the package, and I don't trust it at all, probably there will be some corrections in the future. There must be another issue added with a warning for those directional kriging methods...


Using federated trust in GH Action, I had to add azd login between azd executions

Output from azd version
azd version 0.7.0-beta.1 (commit 9ce71659f7688d0dc3dda8b84e5accedca58cf01)
Describe the bug
I have to add duplicate steps for azd login inside a single job within GH Action using the new Federated trust with Github. It appears either the token generated from azd login was expiring too soon or execution of azd deploy commands were wiping it out. The reason wasn’t shown in logs, just that I was not logged in and needed to run azd login, here was the message:
Error: not logged in, run azd login to login
Error: Process completed with exit code 1.
Note that prior to using the federated GH integration (using SPN Secret), this was not an issue with azd.
To Reproduce
Setup azd for GH actions by running azd pipeline config, then execute these as different steps in github action, on execution of #3, I got a request to azd login. In my scenario, step #2 took roughly 20 minutes to complete.
1- azd login  --client-id ${{ secrets.AZURE_CLIENT_ID }}  --federated-credential-provider "github"  --tenant-id ${{ secrets.AZURE_TENANT_ID }}
2 - azd provision --no-prompt
3 - azd env set AZURE_RESOURCE_GROUP ${{ secrets.AZURE_ENV_NAME }}daily2-rg
Expected behavior
Did not expect to need to azd login again.
Environment
Information on your environment:
Ubuntu-latest in GH Action runner, using image: mcr.microsoft.com/azure-dev-cli-apps:latest

@ellismg take a look at it.

@wbreza can you take a look at this OIDC timeout issue?

Seems to be a duplicate of #1901 https://github.com/Azure/azure-dev/issues/1901#issuecomment-1506136846
Closing this one.


Multiple sidebar selection should not result in empty timeline

The timeline should be the union of articles.

I'm not able to recreate this.  Could you post a screenshot of it happening?  Maybe I can figure out how to recreate it from the screenshot.

I think I figured it out — it’s showing only unread articles.

Yeah, I made it that way since the default behavior for Folders is to only show unread articles.  Because multiple selection doesn't have a way to save the unread filter state, I figured this would be the correct behavior.

Let’s make it so that it’s the union of what you would see if you clicked each item individually, respecting the filter settings of each individual item.


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.2.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Avoid redefining Python's native NotImplementedError

Minor PR that proposes renaming one of the exceptions to avoid redefining the native exception in Python. I'm fine if you prefer the original implementation and want to disregard this PR

Hmm, I didn't even know this was a builtin. Turns out we aren't using it correctly anyway, as per the documentation. Great catch -- I will review and run isort to get the CI passing.


two or more spaces, then type return

On John Gruber, Markdown Syntax Documentation
We can read : "When you do want to insert a  break tag using Markdown, you end a line with two or more spaces, then type return."
It seems it's not working on egui_commonmark, is this intended?
Thank you for your work.

It does work with two spaces after first line  . Is there something else that you have in mind?

The reference spec works the same way:
https://spec.commonmark.org/dingus/?text=first line
second line

text with a \
break

text with a large

separator

ooops sorry, i test it on a bad way.


Bug in FindCallingMethodOnStackTrace wrt wrapping logger

Added unit test that shows a bug in FindCallingMethodOnStackTrace: using a wrapper type only works if no method on a different type is present on the callstack between the wrapper type method and the NLog method.
E.g. it's not possible to get a proper stack trace when wrapping NLog 2 for Common.Logging.
I'll try to come up with a fix.

Proposed solution added.
Issue http://nlog.codeplex.com/workitem/6737


Element does not modify config

Fixes #53

Technically this was always the case - more of a confirmation commit than anything else.


Proposal: allow the FMA addend to be in either src_fmt_i or dst_fmt_i

Currently, the addend operand of the FMA shares its FP format with the result:
https://github.com/openhwgroup/cvfpu/blob/4aac6b3e87a30c8567dbe7401eba3274eea18afc/src/fpnew_fma_multi.sv#L37-L38
This makes sense when considering the various fused multiply-accumulate operations of the RISC-V spec, which add the product of two multiplicands given in one FP format to an accumulator in another FP format. However, the RISC-V vector spec defines widening FP add and subtract operations that come in two flavors:

one which sums two narrow operands and produces a wider result
one which sums one narrow and one wide operand to produce a wide result

The latter is directly supported by CVFPU but the former is not, as that would require the addend operand of the FMA to be in src_fmt_i as well.
Looking at the source code of the FMA, nothing is fundamentally preventing the FMA addend to be in a different format than the result. It would suffice to change the following lines, which unpack the 3 operands, to use a different format for operand_c (and info_c):
https://github.com/openhwgroup/cvfpu/blob/4aac6b3e87a30c8567dbe7401eba3274eea18afc/src/fpnew_fma_multi.sv#L234-L240
Hence, in order to improve support for these type of widening FP add/sub and potentially other operations and to generally increase the flexibility of CVFPU, I propose to allow the FMA addend to be in either src_fmt_i or dst_fmt_i (at least for the add operation).
This change could be implemented, for instance, by:

Adding a new port add_fmt_i to the FMA, all opgroup modules and the fpnew_top module that specifies the format of the addend. This would be the most flexible option but changes the ports of the top module.
Adding a new operation ADDW to the operation_e enum, which behaves the same as the ADD operation except that src_fmt_i is used for the addend instead of dst_fmt_i. This would avoid changes of the top module.

@davideschiavone @pascalgouedo @stmach @lucabertaccini Please let me know if you would support such a change and your preferred way of implementing it. If favorable, I would then prepare a PR.

Hi @michael-platzer
I prefer solution 2 as it doesn't change top level as well as T-Head FDIV/FSQRT interfaces.
Regards,
Pascal.

Hi,
as you say, nothing fundamentally prevents using a separate format for each of the operands, and you nicely point out why we didn't need to do it so far when designing the unit.
While less general, I also like option 2 as it keeps the changes internal to the FMA module (which itself becomes more general) and doesn't introduce [even more] configurability to the whole unit where it's not needed in most cases. Specialized architectures can still use direct instances of the FMA block if they require a more specific configuration.
Cheers,
Steve

Thanks for the feedback @pascalgouedo and @stmach! In that case I will move forward with option 2 and add a new operation for the add with operands of the same FP type.

Specialized architectures can still use direct instances of the FMA block if they require a more specific configuration.

Should I then add a new port add_fmt_i for the addend format to the FMA block, and assign as follows in all instantiations of the FMA?
    .add_fmt_i ( op_i == fpnew_pkg::ADDW ? src_fmt_i : dst_fmt_i )

That would allow specialized architectures to have even more freedom when directly instantiating the FMA block. Or should the format of the addend rather be decided within the FMA block?

I think an extra port on the multiformat FMA and the necessary changes for assigning it in the instantiating block is worth the effort to keep some generality on one hand, and conceptually not mingle formats and operations too much in the execution unit (basically the format used in the execution unit itself should just be decided by the format port itself).
Secondly, just a personal nit on naming: I would probably name the new port src2_fmt or similar (since it's just the format of the second source operand port), as with src_fmt and add_fmt there are kind of two separate nomenclatures (the addend is also a source after all) - I see that it was not very clean to begin with, as one of the source operands used the destination format in the past.
Consider renaming the format ports either

src01_fmt & src2_fmt (or just src and src2 without the 01); or
mul_fmt & add_fmt, but that clashes with the use of src and dst in the rest of the project.

(in case you want to go fully generic crazy, you could make each operand format independent and have src_fmt be an array of length 3 with one format for each operand - but that's not really something that's necessary at this point)

I think an extra port on the multiformat FMA and the necessary changes for assigning it in the instantiating block is worth the effort to keep some generality on one hand, and conceptually not mingle formats and operations too much in the execution unit (basically the format used in the execution unit itself should just be decided by the format port itself).

Alright, I agree that this sounds like a reasonable tradeoff.

Secondly, just a personal nit on naming: I would probably name the new port src2_fmt or similar (since it's just the format of the second source operand port), as with src_fmt and add_fmt there are kind of two separate nomenclatures

Good point!

src01_fmt & src2_fmt (or just src and src2 without the 01);

I went with this approach and renamed the new port to src2_fmt_i. Updated my PR accordingly.


SA1200 wrongly firing with File Scoped Namespaces?

If I have a class like that:
using Project.Models.Base;

namespace Project.Models;

internal class Object
{
    public int Id { get; set; }
}

Then I get the warning SA1200 "A C# using directive is placed outside of a namespace element.". But with the File Scoped Namespace, every line in the file is within the namespace. So what are the conventions in this case?
Because if I move the using line below namespace line, it no longer triggers. How should using and namespace lines be placed in a class that uses File Scoped Namespace?

SA1200 wants the using statement after the file scoped namespace declaration.
Would be good if there documentation could get updated to clarify this.