Parallelism

Adds concurrent implementation to the template
Adds nullity annotations
Adds additional logs to allow easier diagnostics
Adds metric collection
Minor clean-ups

{minor}

Codecov Report

Merging #3 (973c47e) into main (05166d7) will increase coverage by 0.20%.
The diff coverage is 96.19%.

@@             Coverage Diff              @@
##               main       #3      +/-   ##
============================================
+ Coverage     96.21%   96.41%   +0.20%
- Complexity       43       92      +49
============================================
  Files             7       13       +6
  Lines           132      279     +147
  Branches         11       12       +1
============================================
+ Hits            127      269     +142
- Misses            5        9       +4
- Partials          0        1       +1

Impacted Files
Coverage Δ
Complexity Δ

...hub/nagyesta/cacheonly/raw/BatchServiceCaller.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...cacheonly/raw/exception/BatchServiceException.java
100.00% <ø> (+50.00%)
2.00 <0.00> (+1.00)

...a/cacheonly/transform/NoOpPartialCacheSupport.java
14.28% <14.28%> (ø)
1.00 <1.00> (?)

.../metrics/BasicBatchServiceCallMetricCollector.java
96.55% <96.55%> (ø)
14.00 <14.00> (?)

...a/cacheonly/core/AbstractCacheServiceTemplate.java
98.95% <98.95%> (ø)
26.00 <26.00> (?)

.../nagyesta/cacheonly/core/CacheRefreshStrategy.java
100.00% <100.00%> (ø)
7.00 <0.00> (-1.00)

...ta/cacheonly/core/DefaultCacheServiceTemplate.java
100.00% <100.00%> (ø)
6.00 <6.00> (-15.00)

...core/conurrent/ConcurrentCacheServiceTemplate.java
100.00% <100.00%> (ø)
11.00 <11.00> (?)

...nly/core/conurrent/ConcurrentOperationSupport.java
100.00% <100.00%> (ø)
2.00 <2.00> (?)

...a/cacheonly/core/exception/CacheMissException.java
100.00% <100.00%> (ø)
2.00 <1.00> (+1.00)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0d210...973c47e. Read the comment docs.

Codecov Report

Merging #3 (973c47e) into main (05166d7) will increase coverage by 0.20%.
The diff coverage is 96.19%.

@@             Coverage Diff              @@
##               main       #3      +/-   ##
============================================
+ Coverage     96.21%   96.41%   +0.20%
- Complexity       43       92      +49
============================================
  Files             7       13       +6
  Lines           132      279     +147
  Branches         11       12       +1
============================================
+ Hits            127      269     +142
- Misses            5        9       +4
- Partials          0        1       +1

Impacted Files
Coverage Δ
Complexity Δ

...hub/nagyesta/cacheonly/raw/BatchServiceCaller.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

...cacheonly/raw/exception/BatchServiceException.java
100.00% <ø> (+50.00%)
2.00 <0.00> (+1.00)

...a/cacheonly/transform/NoOpPartialCacheSupport.java
14.28% <14.28%> (ø)
1.00 <1.00> (?)

.../metrics/BasicBatchServiceCallMetricCollector.java
96.55% <96.55%> (ø)
14.00 <14.00> (?)

...a/cacheonly/core/AbstractCacheServiceTemplate.java
98.95% <98.95%> (ø)
26.00 <26.00> (?)

.../nagyesta/cacheonly/core/CacheRefreshStrategy.java
100.00% <100.00%> (ø)
7.00 <0.00> (-1.00)

...ta/cacheonly/core/DefaultCacheServiceTemplate.java
100.00% <100.00%> (ø)
6.00 <6.00> (-15.00)

...core/conurrent/ConcurrentCacheServiceTemplate.java
100.00% <100.00%> (ø)
11.00 <11.00> (?)

...nly/core/conurrent/ConcurrentOperationSupport.java
100.00% <100.00%> (ø)
2.00 <2.00> (?)

...a/cacheonly/core/exception/CacheMissException.java
100.00% <100.00%> (ø)
2.00 <1.00> (+1.00)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0d210...973c47e. Read the comment docs.


Spinner in plots tab: window progress is re-set

In the most recent configuration of the loading spinner in the plots tab, the spinner prevents scrolling while it is displayed, and re-enables scrolling once computation is finished and the spinners are hidden. This results in the scroll progress of the screen being re-set each time the plots compute, which can be frustrating when working with plots that appear near the bottom of the window.
To avoid this, the spinner should appear outside the scrolling window (the main panel). This will keep it from disappearing when the user scrolls down, and it will also remove the need to modify the scrolling window.
The DOM hierarchy would look something like this:

 Navbar container

 Sidebar panel
 Spinner container

 Main panel

 DimPlot
 Feature Plot
 Violin Plot
 ...

This is contrasted with the current hierarchy:

 Navbar container

 Sidebar panel
 Main panel

 Spinner container

 DimPlot
 Feature Plot
 Violin Plot
 ...

This was fixed in 37e55ac.


[Feature Request]: Canonical 'chat with your documents' example

Describe the problem
When searching the web, there isn't a good standalone 'chat with your documents' example application that a user who just installed Chroma can build / follow along with. This is the most popular use-case, so we should help people get started.
Describe the proposed solution
Make a canonical version of 'chat your documents'.
Alternatives considered
Link to other tutorials which use Chroma under the hood. Feels bad to send people elsewhere.
Importance
would make my life easier
Additional Information
No response

Hi, @jeffchuber @atroyn
I have created the chat with doc example using Python already I would like to give a try for this.
This is my GitHub Repo := Git Repo
My question is how to contribute and where to add my example in this Repo.
Tq.

Hi @jeffchuber @atroyn,
I hope you're doing well. I've been working on creating a "chat with doc" example using Python, and I'd love to contribute this example to the Chroma project. I believe this could be a valuable addition for new users looking to get started.
I've already prepared the example, and you can find it in my GitHub repository: Doc-GPT-App. The example is designed to help users interact with their documents using Chroma.
You can also check my work on this feature on these social links:

LinkedIn LinkedIn
Personal Website/Blog: Blog

Before proceeding, I wanted to check if it's alright with you if I contribute this example to the Chroma project. If you're interested, I'd appreciate guidance on where to add this example within the project repository and any specific steps or formatting you'd recommend.
Thank you for your time and consideration. I'm excited about the possibility of contributing to Chroma and helping users get started more easily.
Best regards,
Basavaraj Patil

Hi @Basavarajrp,
thanks for submitting. I like that you have a way to ingest PDFs. We just landed https://github.com/chroma-core/chroma/pull/881 which includes a minimal chat-your-docs example, if you like you could open a PR to extend it with PDF line-by-line loading, against this file: https://github.com/chroma-core/chroma/blob/main/examples/chat_with_your_documents/load_data.py

Closed by https://github.com/chroma-core/chroma/pull/881


Add rotary encoder to Louder ESP32 (rev H)

I really love the Louder ESP32, it works really well.
I would like to add a rotary encoder to add the possibility to change volume directly at the speaker.
Could you give some information how this is done easiest?
I've seen some GPIOs available on the PCB of my rev H (2, 4, 13, 15, 32, 36, 3V3, GND).
Can I use all of them or are some of them better suited for the rotary encoder?
I suppose the programming needs to be done via the I2C or SPI Bus Parameters in the Hardware Section of Squeezelite-ESP32?
I have some KY-040 available here, but it seems they're working with 5V?
https://www.az-delivery.de/en/products/drehimpulsgeber-modul
"GND"
"+" = 5V
"SW" = Interrupt for Push-Button
"DT" = Encoder Pin B
"CLK" = Encoder Pin A
If they're not suited, could you give me a suggestion which ones are better suited?
Thanks in advance, maybe this could also be added to the readme?

Hey @flix-one
First of all, rotaries are not active devices, they are basically switch whatever voltage you feed in, like basic buttons. Please use 3.3V as power and you'll get good reliable 3.3v on all signal lines.
You can use pretty much any pins that are available with some limitations. In your list avoid pin 2 (bootstrapping pin), the rest should be good to go.
Last point, here is the squeezelite docs on how to configure rotary encoder as soon as you have it connected.

Thank you for the feedback, I think of using
SW = GPIO 4
CLK (Pin A) = GPIO 13
DT (Pin B) = GPIO 32
In the Pinout Reference it says:
Note: ADC2 pins cannot be used when Wi-Fi is used. So, if you’re using Wi-Fi and you’re having trouble getting the value from an ADC2 GPIO, you may consider using an ADC1 GPIO instead. That should solve your problem.
Are the ADC2 pins (0, 2, 4, 12, 13, 14, 15, 25, 26, 27) used for Wi-Fi by your PCB configuration (especially 4 and 13)?

As far as I know, this warning only applies if you're using ADC, or analogRead. For digital functions it is fully functional.

With SW on GPIO 4, DT (A) on GPIO 32 and CLK (B) on GPIO 13 it works with rotary_config: A=32,B=13,SW=4,volume,longpress
Thank you for the support!

You're very welcome. Feel free to attach a pic of the end result, if it is all right :)


fix: logstash-http flushes message one by one by default

Information

Type
Status
Migration

Fix
Ready
No

Description
logstash-http
When letting delayToFlush and bufferMax as default values.
And when logs are sparse.
=> logs are sent twice
Solution

remove second push in buffer
allow flush when bufferMax is not set
use delayed flush trigger only when logs were not flushed already

Usage example
Example to use your feature and to improve the documentation after merging your PR:
import { Logger } from '@tsed/logger'
import '@tsed/logger-logstash-http'
import configuration from './config'

logger.appenders.set('logstash', {
  type: 'logstash-http',
  level: ['info'],
  options: {
    debug: true,
    url: configuration.get('url'),
    application: 'elastic-index',
    requireAlias: true
  }
})

logger.info('should be sent only once')

Todos

[ ] Tests
[ ] Coverage
[ ] Example
[ ] Documentation

:tada: This PR is included in version 6.6.2 :tada:
The release is available on:

v6.6.2
GitHub release

Your semantic-release bot :package::rocket:


Decode a Morse code message

Hello Reviewer 👋
In this pull request we were able to:

Run a program using the command line.
Use Ruby syntax for basic programming operations.
Use Ruby to solve basic coding challenges.

Project Status: INVALIDATED :red_circle:
Hi @Mutai-Gilbert and @calebchris000 ,
While you made a great effort in this project, I can't go ahead and review your code.

Invalid Code Review Request

This is because you have submitted a project, that is missing the rubocop linter checks Ruby in your project :100:

Your Current checks

What you should have

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @NahnahAJ in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


rpi-base.inc: update IMAGE_BOOT_FILES for change in oe-core

[Issue #285] -- https://github.com/agherzan/meta-raspberrypi/issues/285
The openembedded-core commit 1860d9d3c62e2e94cd68a809385873ffd8270b6d
changed the names of DTB files in the deploy directory - they are no
longer prefixed with "${KERNEL_IMAGETYPE}-". Update make_dtb_boot_files
(which generates entries in IMAGE_BOOT_FILES) to take this change into
account.
Signed-off-by: Jonathan Haigh<EMAIL_ADDRESS>

Can one of the admins verify this patch?

@jenkins-ag ok to test

Did you test this with rpi-sdimg too?

No. I don't currently have an rpi-sdimg build; I'll set one up and test.

Okay, I've now tested rpi3 builds using rpi-sdimg and Wic. Both boot fine and look to have a full set of dtb and dtbo files in the boot partition.

LGTM

Thanks @jonathanhaigh-arm for the test. Merged to master.

Thanks all.


✨ Modal window

Необходимо создать функциональность вызова диалогового окна. Должна быть возможность передать в диалоговое окно любой компонент с любыми параметрами. При показе окна должна блокироваться прокрутка страницы.

The aside window already exists in the branch. There are many things that are the same for Modal window and Aside wondow:

they can open and close;
they must have a title and a cross;
you can put a component in them;
they should loop the focus of their inputs;
they must return focus to the button that opened them after they are closed;
they should block scrolling;
maybe something else.

It is necessary to implement a modal window in such a way that the same code is not written twice. We need to redistribute the code in such a way that the common functionality exists separately, and the Modal and Aside windows would reuse it.


mat dialog actions hiding/overflow

Bug, feature request, or proposal:
Bug
What is the expected behavior?
Show all mat dialog action
What is the current behavior?
the resizing of the window is hiding the mat dialog action
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Google Chrome Versão 64.0.3282.140 (Versão oficial) 64 bits
TypeScript 2.6.2
Ubuntu 16.04
Material 5.1.0
Angular 5.1.0

I believe that this is an issue with how we handle the dialogs hitting the bottom of the viewport in general. It should be addressed by https://github.com/angular/material2/pull/9236.

Closing since there are a few other issues tracking the same thing (#2481, #3239, #6584, #8493).


cue/eval: list.Range fails inappropriately when called in definition

What version of CUE are you using (cue version)?

$ cue version
cue version v0.0.0-20221207090135-ccdac14a7cb8

       -compiler gc
     CGO_ENABLED 1
          GOARCH amd64
            GOOS linux
         GOAMD64 v1
             vcs git
    vcs.revision ccdac14a7cb8b8eda5a101d4ededadb2c579db33
        vcs.time 2022-12-07T09:01:35Z
    vcs.modified false

Does this issue reproduce with the latest release?
What did you do?
exec cue export x.cue
cmp stdout expect.json

-- x.cue --
package c

import "list"

#T: {
	p: [...]
	r: list.Range(len(p)-1, 0, -1)
}

t: #T
t: p: [1, 2]

-- expect.json --
{
    "t": {
        "p": [
            1,
            2
        ],
        "r": [
            1
        ]
    }
}

What did you expect to see?
A passing testscript test.
What did you see instead?
> exec cue export x.cue
[stderr]
#T.r: error in call to list.Range: end must be less than start when step is negative:
    ./x.cue:7:5
[exit status 1]
FAIL: /tmp/testscript4234227699/x.txtar/script.txtar:1: unexpected command failure

The argument to list.Range is treated as final even though it isn't being emitted.

A similar issue occurs just using indexing:
exec cue export x.cue

-- x.cue --
package c

#T: {
	p: [...]
	_q: [for x in p {x}]
	r: _q[0]
}

I'd expect that to be OK because the p field can later be instantiated with a non-zero-length list, but I see this error:
> exec cue export x.cue
[stderr]
#T.r: index out of range [0] with length 0:
    ./x.cue:6:8
[exit status 1]


Merge from vscode fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3

https://github.com/microsoft/vscode/commit/fcf3346a8e9f5ee1e00674461d9e2c2292a14ee3 Web - try to detect native fullscreen (https://www.github.com/microsoft/vscode/issues/106479)
https://github.com/microsoft/vscode/commit/e13875b77c89b95f20ccb5667e14ff164c198e57 Only prevent default  for copy paste in webviews when on electron
https://github.com/microsoft/vscode/commit/51dc3193d3f92c0d1854be9b1a462d0cedbd8a7e Move webview editor into own module
https://github.com/microsoft/vscode/commit/58015614246e855b525e5bdd12f1c2a2979415d6 fix https://www.github.com/microsoft/vscode/issues/105735.
https://github.com/microsoft/vscode/commit/33c24b8fc1a697e5e1f101ad9631ad6d589bbb63 Fix cell state persisted with wrong index
https://github.com/microsoft/vscode/commit/9b4bc5ab505e421702894a980cff93e00261377b applyEdits.
https://github.com/microsoft/vscode/commit/475b674fe0cb5901b065cc0c936217e6a89bc3ab Closes https://www.github.com/microsoft/vscode/issues/106683 - adds view title tooltips
https://github.com/microsoft/vscode/commit/0012b4ceb5b74acde20afb01e1737eaf247c706b Merge pull request https://www.github.com/microsoft/vscode/issues/106523 from microsoft/raymondzhao/activitybarmoveaction
https://github.com/microsoft/vscode/commit/f7131a4cb33a36a63a7bce06119ccebdde29b8d0 Persist cell view states by index instead of handle Fix https://www.github.com/microsoft/vscode/issues/106670
https://github.com/microsoft/vscode/commit/caa87aa67388b992ccfaf11aaf577afac82a0cd0 Merge pull request https://www.github.com/microsoft/vscode/issues/106601 from vuongggggg/fix/add-missing-dep-for-devcontainer
https://github.com/microsoft/vscode/commit/91bac85a5b4707f1ddd728a8fb245eb9121c06f5 Defer all resize events for git bash terminals
https://github.com/microsoft/vscode/commit/f9bc1654f2388faad0b2c6ecf5fba11af9117fa4 Fix https://www.github.com/microsoft/vscode/issues/105597: New Search Editor focuses results instead of query input when seeded (use focusResults: false by default)
https://github.com/microsoft/vscode/commit/1025f4aae70267a81dd8b2023f27c88517902025 remove unused import
https://github.com/microsoft/vscode/commit/84d817bc8d1846db627ffdf60b8152a024b3682d fix TS 4.1 errors
https://github.com/microsoft/vscode/commit/85304e386cad2ce51e1a2ae7fd58c0863309809a Revert "Fix https://www.github.com/microsoft/vscode/issues/90890"
https://github.com/microsoft/vscode/commit/f096f594049a066152f2b186a1d86d604b9a7ee9 refine test for https://github.com/microsoft/vscode/issues/106657 and document issue with fragments and the editor opener
https://github.com/microsoft/vscode/commit/98ee37629de497e9cb2e363204a22bc0836570c5 remove web filter
https://github.com/microsoft/vscode/commit/c67bd0271b75120155e518904908705a0be2c555 enable web server only in server less
https://github.com/microsoft/vscode/commit/b9aa43aeb3e35880affb6c734a5738fc6b0e7695 fixes https://www.github.com/microsoft/vscode/issues/100172
https://github.com/microsoft/vscode/commit/f69faf4e22527c9da7aecd447eeeb68d22a6bb83 fixes https://www.github.com/microsoft/vscode/issues/86180
https://github.com/microsoft/vscode/commit/a6ae00a3842dd813cd19b75c58d498a5a06f47f2 add regression test for https://github.com/microsoft/vscode/issues/106657
https://github.com/microsoft/vscode/commit/863acbab188c7248531fdc3c5f04783f315fcd68 fix bad classList usage
https://github.com/microsoft/vscode/commit/5a683332be29ed2c8972548493111f2998b3adbf notebook - when creating a notebook, check that no notebook with another viewtype exists
https://github.com/microsoft/vscode/commit/ed24319ef9264a668ceec8d025c2f37763da8363 fixes https://www.github.com/microsoft/vscode/issues/106406
https://github.com/microsoft/vscode/commit/68410abc36030d3fb321145d2e4945f72f6e6bee debt - make class list utils functions so that @deprecated works for them
https://github.com/microsoft/vscode/commit/db784028161e7ffde7fcf586abc618015a115932 update search files
https://github.com/microsoft/vscode/commit/3761ee6575b1db222f925d47eba49f23702817d0 workaround, maybe fix for https://github.com/microsoft/vscode/issues/106657
https://github.com/microsoft/vscode/commit/883da596a4c2aeb328a3c36ceb7e9bfe071b7f23 remove deprecated function calls
https://github.com/microsoft/vscode/commit/efc7cb3a6eddf5da4dd331c7c22082bc78d27bc9 use debian stretch images (https://www.github.com/microsoft/vscode/issues/106656)
https://github.com/microsoft/vscode/commit/68ff54f9759cebbb3b038e6145e5d60c0685564a rename RunOnceScheduler#timeout to delay
https://github.com/microsoft/vscode/commit/90a2bed8c8023694041f4b211ecd48efded483d0 fix delay issue for provideCodeLenses, https://github.com/microsoft/vscode/issues/106267
https://github.com/microsoft/vscode/commit/933bdbc296ed02864a9b89eb254a8910e22a877a add NotebookCell#index, https://github.com/microsoft/vscode/issues/106637
https://github.com/microsoft/vscode/commit/b9291026a673804f7465d3f9b0c4e76f36c78468 adopt notebook integration tests, https://github.com/microsoft/vscode/issues/105283
https://github.com/microsoft/vscode/commit/842741469cde51b8cd9a4c44fb3f07704755c604 WorkspaceEdit-api changes, https://github.com/microsoft/vscode/issues/105283
https://github.com/microsoft/vscode/commit/06377cfaaa5edef12d5ee80ba14d20fe42b2cd98 NotebookEditorEdit-api changes, https://github.com/microsoft/vscode/issues/105283
https://github.com/microsoft/vscode/commit/ef4df1d1aa8a27a27034d5fe0f317d43c66a4164 remove old renderCodicons-function, rename renderCodiconsAsElement to renderCodicons
https://github.com/microsoft/vscode/commit/e3380f2682ec6a6a4857ec5b14915401369185ab don't use renderCodicons any more, https://github.com/microsoft/vscode/issues/105799
https://github.com/microsoft/vscode/commit/d3e19e4210e18cad611a0376ce2b7d708b746bf9 Skip formatting when during format-on-save, the configured formatter cannot be found (continue to show silent notification), https://github.com/microsoft/vscode/issues/106376
https://github.com/microsoft/vscode/commit/cca20eba8974b1d6b6a9b71bf4e60a29c8f26648 Revert "API proposal for tree item icon color"
https://github.com/microsoft/vscode/commit/cc899f17d32ef960397522af6f464750f4250d40 Create webview.web.contribution
https://github.com/microsoft/vscode/commit/02e6fa2ddd33dfd7368e2da6c31bce322c2a2a2c Use Set instead of array
https://github.com/microsoft/vscode/commit/8a6b38e4ef2f773e336da01edb425dde670943df use optional chaining
https://github.com/microsoft/vscode/commit/3e71592258309914a19a134285999782e6a8a6b6 Add comment to WebviewViewResolveContext
https://github.com/microsoft/vscode/commit/2fb42c30242fdfe26676cee0f3e4828cd79c91ba Add optional typing for webview state in WebviewPanelSerializer
https://github.com/microsoft/vscode/commit/db01f714bc2f291b5ed09f265a883328d29e0664 hide outputs if it is transient.
https://github.com/microsoft/vscode/commit/402092dd67d55e0c4f326b834cda03dcaa2084ac fix https://www.github.com/microsoft/vscode/issues/106430.
https://github.com/microsoft/vscode/commit/122fc9a1b8a378c7349d5be091c819be6932be64 debug: update js-debug
https://github.com/microsoft/vscode/commit/352a39025160b234d37af128c48a9b19c4a44ff5 Add preferred_username to the list of msft token claims (https://www.github.com/microsoft/vscode/issues/106511)
https://github.com/microsoft/vscode/commit/c53524a198ca46dd327d2559bcafa9296d6230e6 cell language should not be freezed.
https://github.com/microsoft/vscode/commit/59dcc5c9124ad82d15adc888013b2a861405d794 notebook document data loss.
https://github.com/microsoft/vscode/commit/07ad5d6f18d91a365d6fa3faa2c2e05c590dc40f Remove unused 'SettingSearch' issue type
https://github.com/microsoft/vscode/commit/5c76fc51e043dd4af9423b6be5b0ed7f9f6b845d Update Codicons: add 'magnet' icon https://github.com/microsoft/vscode-codicons/commit/https://github.com/microsoft/vscode/commit/4c6115529dd1fa20b635f32f9271f50030b0722e
https://github.com/microsoft/vscode/commit/b0a913b761f79ddd2f5074354008cdc8b7cbdadd explorer: Should maintain row focus after deleting a file
https://github.com/microsoft/vscode/commit/133d95e61892e304af8763b6df1412af5a87f32d adopt new amd loader with support for TrustedScriptURL, add typings for TrustedTypesFactory et al, https://github.com/microsoft/vscode/issues/106396
https://github.com/microsoft/vscode/commit/c2da75080d889d1fa0aa31c706d55ac8717b27ac do not use deprecated dom helper methods
https://github.com/microsoft/vscode/commit/93c96b63c0ad62ac9d9c1dc5a76763c2786f9300 debug and explroer: do not use dom.addClass, dom.toggleClass
https://github.com/microsoft/vscode/commit/292001621a300b10be5f1eff0225db5e37cb198b do not use hasClass and first
https://github.com/microsoft/vscode/commit/1fccb9e58c7b03f218ccab2124b0262b1d1bcb9a proxy authentication does not work on 1.49 (https://www.github.com/microsoft/vscode/issues/106434)
https://github.com/microsoft/vscode/commit/bc38b0accb3c62180317c63dbe7323200977db0f argh
https://github.com/microsoft/vscode/commit/bea7a2334e462b8fcb62d56a987035b2887cf21d fix linux build
https://github.com/microsoft/vscode/commit/1f1ac9a2a3e29a5f4d9a5fceb69116acfa4f25ed update distro
https://github.com/microsoft/vscode/commit/e75b1a6dcd02813ecb2f139db33dcd2c484c5d80 Merge branch 'joao/linux-arm'
https://github.com/microsoft/vscode/commit/13aca0a170f12a37193614568386631ea59a2712 debt - remove some any casts from window
https://github.com/microsoft/vscode/commit/8e12a92976c6c853995632ffc0e30616019a2974 Remove Schemas.vscodeRemote from simple file dialog
https://github.com/microsoft/vscode/commit/3994ae4c9ec6ee6ec5ee57592f54c66a844ccdc1 Trusted types - don't use innerHTML for rapid render, https://github.com/microsoft/vscode/issues/106395
https://github.com/microsoft/vscode/commit/a46ba1f84c7fefbb08106d8013d0c513ba2754de :up: web playground
https://github.com/microsoft/vscode/commit/7c20c3f8b9e4e70f3935f84b5874ce126791ade6 Merge pull request https://www.github.com/microsoft/vscode/issues/106374 from microsoft/dependabot/npm_and_yarn/extensions/css-language-features/server/yargs-parser-13.1.2
https://github.com/microsoft/vscode/commit/55a7f0aa48eb429f094a82a9098fa7db602d7e45 update search file, https://github.com/microsoft/vscode/issues/106395
https://github.com/microsoft/vscode/commit/87847325a66f098621f6650a16d665c9cd07f15a electron - set spellcheck: false again for windows
https://github.com/microsoft/vscode/commit/37a11b4314892f8c3ee605c2393ad9bac03cf0bb try to fix build (linux)
https://github.com/microsoft/vscode/commit/2e2d14cb13de1e4727aa05731c613bd57e3897e2 some jsdoc for https://github.com/microsoft/vscode/issues/54938
https://github.com/microsoft/vscode/commit/40827f365c376dd6753116326fd10a9f826655b7 fix fonts in monaco menu
https://github.com/microsoft/vscode/commit/2c1dd109d63e80aec73b7970629668f9c23ba1ee Fix some trusted type violations, https://www.github.com/microsoft/vscode/issues/106395
https://github.com/microsoft/vscode/commit/62b70e6bb5d3dcf19425479ba1a55743de38ea35 update exploration branch
https://github.com/microsoft/vscode/commit/4aefd4390f1aad1708fda593a7db8587f92462b8 remove spliceNotebook api from textmodel.
https://github.com/microsoft/vscode/commit/58d9622c421e06f1516e6cea3cd2bac5a9d93b47 unit tests for batched edits.
https://github.com/microsoft/vscode/commit/ee11170fef1d832e220552aff0efa4d437e78ceb Pin blob storage dep see Azure/azure-sdk-for-jshttps://www.github.com/microsoft/vscode/issues/11187
https://github.com/microsoft/vscode/commit/310e5a9057eae40d62ff849293f0e51868b94988 Replace our arrays.find with stdlib find
https://github.com/microsoft/vscode/commit/d82bb0ec7703a1b20cee61cf7a024081237bec10 Improve views contribution point
https://github.com/microsoft/vscode/commit/f731c6f2dba581f6a7cedc81e1df7d20381f4fef Document view.type contribution
https://github.com/microsoft/vscode/commit/7daf6e1e8135056ca4b6ff3d7aa7d1eca60f98d3 fix build.
https://github.com/microsoft/vscode/commit/5ae0dc07e33effb689069366a307f429fb302cec :lipstick:
https://github.com/microsoft/vscode/commit/f3c42d8057ad3271d437345d1c936010e023f805 do not copy execution related metadata
https://github.com/microsoft/vscode/commit/ea02bca1e0fc2586fca436475cedb432d4a66935 replace insertCell with applyEdit.
https://github.com/microsoft/vscode/commit/f88fca50386904fbdc7d3ddf10e5a72e1401b0b1 applyEdit supports begin/end selections.
https://github.com/microsoft/vscode/commit/2103630537d53753fd4d8c89ab3f52f6498ceef4 private outputs slice and unknown change.
https://github.com/microsoft/vscode/commit/f0426274b496d4e8ab028b41b29869b42736f36d notebook text model initialization does not increment version
https://github.com/microsoft/vscode/commit/b37c4b08e98428b203e330377504b861e76ee32b re https://www.github.com/microsoft/vscode/issues/105735. batch apply edits.
https://github.com/microsoft/vscode/commit/c59d5dd63db73070c0069c393bbd23a09b73cacc - reload only local user configuration after initi - add perf mark up and logs
https://github.com/microsoft/vscode/commit/a45fa6ed50858306e5510742414887371d218a52 Use @example tags in vscode.d.ts (https://www.github.com/microsoft/vscode/issues/106352)
https://github.com/microsoft/vscode/commit/ad451c4586e3a9e307a3ab60116f24409ed490c1 Fix one innerHTML usage https://www.github.com/microsoft/vscode/issues/106395
https://github.com/microsoft/vscode/commit/2e56d31a7290187120714b23cbeab9444bc2d714 use textcontent in menu css refs https://www.github.com/microsoft/vscode/issues/106395
https://github.com/microsoft/vscode/commit/70a3975a15c6196cdaed357823840750e2216baa Use textContnet for style element
https://github.com/microsoft/vscode/commit/eba1cc8de3a8b66f03f8aedd8ca7f90eaa6f296e Remove arrays.findIndex
https://github.com/microsoft/vscode/commit/a9a7cf18f3877f5d52fa22ab137752458d20eaaa Bump yargs-parser in /extensions/markdown-language-features (https://www.github.com/microsoft/vscode/issues/106373)
https://github.com/microsoft/vscode/commit/4c67705ae3a958172ae5d2eb045736cb9cc8a82f refs https://www.github.com/microsoft/vscode/issues/106358
https://github.com/microsoft/vscode/commit/7fdda46e1622e68c600b2c3a6dab693c21e2b4cb some integration tests for notebook editing, https://github.com/microsoft/vscode/issues/105283
https://github.com/microsoft/vscode/commit/6e022766d135689a6a5f92a4f3d9ebf97b238dd0 debt - adopt defaultUriScheme over hardcoded vscode-remote in toLocalResource
https://github.com/microsoft/vscode/commit/b1b5b8a9a3b4f43ff2f6b394f74509bb8baefca5 debt - adopt defaultUriScheme also for userHome
https://github.com/microsoft/vscode/commit/e37e0ffb7454cc4adbc8caf5db3d581b071d3749 Adjust active terminal tab when active tab moves (https://www.github.com/microsoft/vscode/issues/106413)
https://github.com/microsoft/vscode/commit/e73d3a8ed7b8e605ac72bc24b969febd3eeb19c5 pathService - defaultUriScheme() => defaultUriScheme
https://github.com/microsoft/vscode/commit/e0d5fae35ff101b37da0c8bee61551ceeb6a2e1c fixes https://www.github.com/microsoft/vscode/issues/106355
https://github.com/microsoft/vscode/commit/246aab4a05c5f314b1711dac9e775921e93e786e debt - REMOTE_HOST_SCHEME => Schemas.vscodeRemote
https://github.com/microsoft/vscode/commit/7651656e69f8b6acf6fd01a483075b08942d61fd Avoid innerHTML (https://www.github.com/microsoft/vscode/issues/106395)
https://github.com/microsoft/vscode/commit/01b1902dcfce176157f6f512365f42513f1cbcdb Avoid innerHTML (https://www.github.com/microsoft/vscode/issues/106395)
https://github.com/microsoft/vscode/commit/cc9415ca823a96c20d59322307a1208deb1acc36 Fix  https://www.github.com/microsoft/vscode/issues/106303
https://github.com/microsoft/vscode/commit/3d6d7189a621a4bdb34c298c82c95484ec83c4bd :lipstick:
https://github.com/microsoft/vscode/commit/8c1342172739417141a673ea319e742252fd3b85 Add defaultUriScheme to path service (https://www.github.com/microsoft/vscode/issues/106400)
https://github.com/microsoft/vscode/commit/149f31ed01fa46841d27dca9318e28066af26335 fixes https://www.github.com/microsoft/vscode/issues/104047
https://github.com/microsoft/vscode/commit/abb9c8dc1bf0fe911717a5b1c89ada70c597f521 Correct linux code-workspace path
https://github.com/microsoft/vscode/commit/c334da19524bc37fb333d0babd601eae6521cbb9 Multi git executable paths (https://www.github.com/microsoft/vscode/issues/85954)
https://github.com/microsoft/vscode/commit/3271ccc99ab13d08ea4942b3655e9cdcb9966fb4 Correct path to code-workspace.xml
https://github.com/microsoft/vscode/commit/a5a54adba8eb8eb6ab8873d2e2099ee92efa0567 web - fix bad credentials lookup
https://github.com/microsoft/vscode/commit/015c3afe96966df50c15a7d66be2ab0ef1dc5f49 fixes https://www.github.com/microsoft/vscode/issues/106334
https://github.com/microsoft/vscode/commit/e38b9d0727ef6200a9241ecaff8ed6e29fa7bca2 add ExtHostFileSystemInfo which knows what schemes are reserved and which are used, https://github.com/microsoft/vscode/issues/91697
https://github.com/microsoft/vscode/commit/9a2a94107566377d73bb58b1a9fc0b7ee483304f debug: return result of a msg to debug adapter can be undefined
https://github.com/microsoft/vscode/commit/371f6306f9de7e704870e7d7263a96ebc5eb2c88 Merge pull request https://www.github.com/microsoft/vscode/issues/106378 from mjbvz/add-isWritableFileSystem
https://github.com/microsoft/vscode/commit/44699b02546d504b42fe22d43c1932ccf3e246ae Fix Trusted Types violations (round https://www.github.com/microsoft/vscode/issues/2) https://www.github.com/microsoft/vscode/issues/106395
https://github.com/microsoft/vscode/commit/01f9355f655710c10c356ebae66b8070bbfa0566 debt - simplify metadata edit because we now have CellEditType.DocumentMetadata
https://github.com/microsoft/vscode/commit/533ca9bf07c053cc331eec37367f44f5deb6b6f2 Adress https://www.github.com/microsoft/vscode/issues/106358: Fix TS 4.1 errors in codebase
https://github.com/microsoft/vscode/commit/26803cee9b0b86d990e8dced73410be367df2084 Fix TS 4.1 errors for tasks and remote explorer Part of https://www.github.com/microsoft/vscode/issues/106358
https://github.com/microsoft/vscode/commit/226c417bc6108d1a017c69f661959a7cf15dc248 update trusted types search
https://github.com/microsoft/vscode/commit/72f468f5690ad5fe539faa6337d87db04e4ff845 more TS 4.1 fixes (https://www.github.com/microsoft/vscode/issues/106358)
https://github.com/microsoft/vscode/commit/41794e5631035898d7c4980066ae4711e74203d2 trusted types
https://github.com/microsoft/vscode/commit/663810e275674080075a29ced578935ee71ae975 Adds commands for --no-verify commit variants (https://www.github.com/microsoft/vscode/issues/106335)
https://github.com/microsoft/vscode/commit/82d953a731d3acf530f2ee898536b58ac3d00e05 pinned tabs - add a tab.lastPinnedBorder color
https://github.com/microsoft/vscode/commit/6173cf8a99005aa90ee25b92c8385395caccb8bd pinned tabs - closing pinned tab should open next non-pinned
https://github.com/microsoft/vscode/commit/25081cdb65eeb3d18264e804f5463978a07c4cfd fix ts errors
https://github.com/microsoft/vscode/commit/a443309bcf9d72921f01772120dbddd1cb5d7088 Merge pull request https://www.github.com/microsoft/vscode/issues/106385 from microsoft/ben/pinned-tabs-setting
https://github.com/microsoft/vscode/commit/c591f8b562421f4ed97da10577f089987c1a29ec fix TS 4.1 compile errors, https://github.com/microsoft/vscode/issues/106358
https://github.com/microsoft/vscode/commit/76e7cbb0dabcfbea50d1c97178215662d9aff119 fix some TS 4.1 errors (https://www.github.com/microsoft/vscode/issues/106358)
https://github.com/microsoft/vscode/commit/3fb8967173fd16d9d63b98efdd264cfe2fc5be7b fix some TS 4.1 errors (https://www.github.com/microsoft/vscode/issues/106358)
https://github.com/microsoft/vscode/commit/ec8016f7d1f29ce0ce682a38c7aac41d9ed4ecc0 Cache webview view title across reloads
https://github.com/microsoft/vscode/commit/cf38af84ff2d0cdfa293c41a9016dc410dfda68c Revert "Fix https://www.github.com/microsoft/vscode/issues/106303"
https://github.com/microsoft/vscode/commit/3f8f022200b8e227059569a5f5a928a9582de2bd Use destructuring to make code more clear
https://github.com/microsoft/vscode/commit/8e5eed12991c8af7a599b3f68fb9ca723b953316 Fix https://www.github.com/microsoft/vscode/issues/106303
https://github.com/microsoft/vscode/commit/03960a5aa1c21f8dc6db2211e0a62a736624ff71 re https://www.github.com/microsoft/vscode/issues/105735. no more udpateMetadata api.
https://github.com/microsoft/vscode/commit/73a3c9ded30ca1eea2ec1e5d6121614e64e78f81 re https://www.github.com/microsoft/vscode/issues/105735.
https://github.com/microsoft/vscode/commit/7e6273963931402426447bf243fe23c7b577f607 debug: bump js-debug-companion
https://github.com/microsoft/vscode/commit/cceaf143236f352fc0eb429b5084aaf74545c323 https://www.github.com/microsoft/vscode/issues/106358
https://github.com/microsoft/vscode/commit/80b1a775d691612ce8334238d786a922d55e3544 Enable webview commands for webview views
https://github.com/microsoft/vscode/commit/6cf52e3828e6fdab666b0206cea68addcee0c514 Mark property readonly
https://github.com/microsoft/vscode/commit/889fe1787b6dc58da5755a943f9f547e6e62225e :lipstick:
https://github.com/microsoft/vscode/commit/69f26324d46dfabe3574b3e33c411536e2ead4d7 initialize notebook text model data only through ctor.
https://github.com/microsoft/vscode/commit/a037570775ff264fba26289e11d5c1683c0c5937 Update Codicons: add 'graph-left' https://github.com/microsoft/vscode-codicons/commit/https://github.com/microsoft/vscode/commit/dd1edb245d2217efcfb931c293b77b78e634e59a
https://github.com/microsoft/vscode/commit/6821292b4be0c63f1ba03f7edee05572de22a05d Fix ts 4.1 issues in terminal api tests
https://github.com/microsoft/vscode/commit/d55efd8041ac8048b6fba6f7e769c1b8f1ebd836 Fix terminal ts 4.1 compile issues
https://github.com/microsoft/vscode/commit/ebff341de3aba9e9c48fbc605bbb69ad75169c28 Add subscribers action
https://github.com/microsoft/vscode/commit/424a2bf17b722c2779bdc1a46a4f30891d3a11cf refs https://www.github.com/microsoft/vscode/issues/106285
https://github.com/microsoft/vscode/commit/ee5ee9e8aa79e554c717983713ce3242caed815d chore, simply notebook text model event emitter
https://github.com/microsoft/vscode/commit/8bc3145bc555efde56a6b9a1cf04c6f451329827 move dirty state to NotebookEditorModel.
https://github.com/microsoft/vscode/commit/4e70e4a6993b0175f2661cc066774c07989881ab fix https://www.github.com/microsoft/vscode/issues/105916. expand metadata section if modified.
https://github.com/microsoft/vscode/commit/e491efbaabaf1416b8c56a7ea669db1b6099efad replace changeCellLanguage to applyEdit
https://github.com/microsoft/vscode/commit/eb7f042acf7e711d75a3a09ee0af32a26a901a08 remove selections from nb text model.
https://github.com/microsoft/vscode/commit/deaf9f268923634f3f754cba3db5b89a11784ea0 :guard: polish nb tests.
https://github.com/microsoft/vscode/commit/eb05b79e9b222c18ca307ed5e0a0f920c95c2827 do not need isUntitled.
https://github.com/microsoft/vscode/commit/9753398da5cca522ba8de488e092733121744f42 debt - invoke resolve notebook when opening a notebook in an editor, not when loading a notebook from source
https://github.com/microsoft/vscode/commit/e40d854df6306d91c4eff12d8e1559107242c1c8 debt - IMainNotebookController#removeNotebookDocument
https://github.com/microsoft/vscode/commit/5cdf679c440a1054ef747c1af0256d74507b761b Add explicit undefined parameters / types
https://github.com/microsoft/vscode/commit/fecec73e53f3a8076ee3a63b9fea6b102ef743a4 Update Codicons - Update 'pinned' - Add 'export' - Compress 'merge' https://github.com/microsoft/vscode-codicons/commit/https://github.com/microsoft/vscode/commit/5bcb1a045413eb5a9737e6e46411e13f9c4e5c9c
https://github.com/microsoft/vscode/commit/f3532c9061bb22e3423f21fb0b89ee3c1e76c001 chore - use workingCopyService.isDirty instead notebook.isDirty
https://github.com/microsoft/vscode/commit/7e0c1aa76e4ce162679409828af17535d50a4424 Don't use async on abstract functions
https://github.com/microsoft/vscode/commit/c348165cc045cd48e08f85342a6380b670274620 Adding more explicit typings for promises
https://github.com/microsoft/vscode/commit/2a954244f0136a1a12dbc3b491a4ab8cf19b3720 Only allow configurePlugin against main TS Server
https://github.com/microsoft/vscode/commit/c1e950222340898117bac71981ab58f3eceb0fc6 Save prompt is shown while saving from settings split json editor (fix https://www.github.com/microsoft/vscode/issues/106330)
https://github.com/microsoft/vscode/commit/f41efe546c5fad1f75ad938c563aa57e28e0014d Merge branch 'master' into pr/85074
https://github.com/microsoft/vscode/commit/d9d314e8c6b509877d1307deee8b72a1d212674f Update extensions/git/src/commands.ts
https://github.com/microsoft/vscode/commit/bec65e80deed257f8de4803200f7ada430be8ad5 Update extensions/git/src/commands.ts
https://github.com/microsoft/vscode/commit/9ff783bdd6913e733f24699725c2c6888646a833 Update extensions/git/src/commands.ts
https://github.com/microsoft/vscode/commit/c8bf91604654baf7ecc1a716475bdc140c019e07 Add cursor change after revert or stage changes

Pull Request Test Coverage Report for Build 281160470

43 of 116 (37.07%)  changed or added relevant lines in 39 files are covered.
79 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.1%) to 39.497%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/base/browser/ui/buttonMenu/buttonMenu.ts
0
1
0.0%

src/sql/platform/connection/common/connectionStatusManager.ts
2
3
66.67%

src/sql/platform/connection/common/connectionStore.ts
2
3
66.67%

src/sql/platform/serialization/common/serializationService.ts
0
1
0.0%

src/sql/workbench/api/browser/mainThreadAccountManagement.ts
0
1
0.0%

src/sql/workbench/api/common/extHostAccountManagement.ts
2
3
66.67%

src/sql/workbench/contrib/dashboard/browser/dashboardRegistry.ts
0
1
0.0%

src/sql/workbench/contrib/notebook/browser/cellToolbarActions.ts
0
1
0.0%

src/sql/workbench/services/accountManagement/browser/accountManagementService.ts
2
3
66.67%

src/sql/workbench/services/accountManagement/browser/accountPickerImpl.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/sql/base/browser/ui/buttonMenu/buttonMenu.ts
2
1.82%

extensions/notebook/src/common/ports.ts
4
74.14%

src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts
4
21.46%

src/sql/workbench/contrib/dashboard/browser/widgets/properties/propertiesWidget.component.ts
5
40.0%

src/sql/workbench/services/insights/common/insightsUtils.ts
16
3.45%

src/sql/workbench/services/dialog/browser/dialogPane.ts
48
1.0%

Totals

Change from base Build 280725472:
-0.1%

Covered Lines:
19850

Relevant Lines:
45935

💛  - Coveralls

not sure if we should be merging ADS 'main' into this branch because the merge bot is doing that

@cssuh the branch had merge conflicts with main so we'd either need to (1) merge main into the branch (2) update the PR from the bot to pickup more recent main\vscode changes or (3) manually resolve the merge conflicts without merging.  I think merging main seems like the most straightforward way to resolve the conflicts since (2) would reset a lot of the work to get this ready.  Let's get this PR in once the CI builds are clean and we can fixup what ever we need to in the bot to finish catching up the merge.  Let's chat about how best to handle in the future.

All the checks are passing on this.  Though there are still some issues that need follow-up.  e.g smoke tests and web builds.  Let's take this to get the vscode merges in and then I'll resolve the remaining issues separately.


docs: add additional info in backport process

add information in backporting process related to cherry-picking main PR and related fixes
Signed-off-by: Akhil Mohan<EMAIL_ADDRESS>

/kind doc

/cc @dmcgowan


Please port getLeastSignificantBits() and getMostSignificantBits() from java

See https://stackoverflow.com/questions/64917603/looking-for-javascript-equivalents-for-javas-getleastsignificantbits-and-getm
I am interfacing with an API that requires the UUID to be packaged as two 64-bit integers as computed by those functions.

IMHO, this is out of scope for this project.   JavaScript doesn't have a true 64-bit integer data type (JS Numbers are 64-bit floats per IEEE822) and the incremental value in this is pretty small given that parse.uuid() is already a thing.
FWIW, I believe you can roll your own version of these functions using uuid.parse().  E.g. ...
// First 64 bits => BigInt
uuid.parse(id).slice(0,8).reduce((a, b) => a << 8n | BigInt(b), 0n).toString(16)

// Last 64 bits => BigInt
uuid.parse(id).slice(8, 16).reduce((a, b) => a << 8n | BigInt(b), 0n).toString(16)