why the info doesn‘t have the attribute image?

Traceback (most recent call last):
File "/home/yiqunhe/second.pytorch/second/pytorch/train.py", line 304, in train
for example in dataloader:
File "/home/yiqunhe/.conda/envs/yiqunhe/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 582, in next
return self._process_next_batch(batch)
File "/home/yiqunhe/.conda/envs/yiqunhe/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 606, in _process_next_batch
raise Exception("KeyError:" + batch.exc_msg)
Exception: KeyError:Traceback (most recent call last):
File "/home/yiqunhe/.conda/envs/yiqunhe/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 99, in _worker_loop
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/yiqunhe/.conda/envs/yiqunhe/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 99, in
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/yiqunhe/second.pytorch/second/pytorch/builder/input_reader_builder.py", line 42, in getitem
return self._dataset[idx]
File "/home/yiqunhe/second.pytorch/second/data/kitti_dataset.py", line 166, in getitem
input_dict = self.get_sensor_data(idx)
File "/home/yiqunhe/second.pytorch/second/data/kitti_dataset.py", line 190, in get_sensor_data
"image_idx": info["image"]["image_idx"],
KeyError: 'image'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/yiqunhe/second.pytorch/second/pytorch/train.py", line 670, in
fire.Fire()
File "/home/yiqunhe/.conda/envs/yiqunhe/lib/python3.7/site-packages/fire/core.py", line 127, in Fire
component_trace = _Fire(component, args, context, name)
File "/home/yiqunhe/.conda/envs/yiqunhe/lib/python3.7/site-packages/fire/core.py", line 366, in _Fire
it is info!!!!!!!     component, remaining_args)
File "/home/yiqunhe/.conda/envs/yiqunhe/lib/python3.7/site-packages/fire/core.py", line 542, in _CallCallable
result = fn(*varargs, **kwargs)
File "/home/yiqunhe/second.pytorch/second/pytorch/train.py", line 428, in train
json.dumps(example["metadata"], indent=2)
UnboundLocalError: local variable 'example' referenced before assignment

Have you solved this question? I get the same questions

I also get the same questions.

same problem, any solution?

I had the similar problem. I figured out that the kitti_infos_train.pkl file I was using was generated using a different version than this repo. To fix that, you can run
python create_data.py kitti_data_prep --root_path=/path/to/KITTI/root/directory
and generate new kitti_infos_train.pkl which will have the necessary keys for the dictionary to be read by the script.

@niqbal996 can you mention the version. I got the same error even though the versions were same


chapter 1 notation of decision rule

In page 8, equation 1.14:
I want to make the suggestion that the notation of having the function f(x; \theta) in the conditional is slightly confusing, it would be nicer to have it stated as done in equation 1.9 to be consistent.
So RHS of 1.14 should read: -log p (y | x; \theta).
Not biggest issue in the world :) and it's a great book.

I see your point, but I will keep it as is.


docs: add kitajs/html example and tests

Related to https://github.com/kitajs/html/issues/159
@arthurfiorette indeed the tests and example works, but I had to make a monkey-patch adding the jsx-dev-runtime as a copy of jsx-runtime and rename jsx to jsxDEV, probably a necessary change in kitajs/html to support it. For the moment I leave the PR and don't merge it until the new version with this change is ready.

Awesome! Could you also document it inside the kitajs/html readme?

Should the CI be fixed with v4.0.0-next.3 or it's something else kitajs should fix?

@arthurfiorette by upgrading the version already pass the pipeline tests 🥳


Make binaries cross-os

Similarly to how we have it in DNC, making the build of binaries Cross-OS compatible (windows) so that we can build the binaries on windows machines as well

This LGTM, though the github diff view is showing some addtions/removals at some line endings. Could you double check that these are still using LF line endings instead of CRLF?

Go trivially cross-compiles (set GOOS=windows), and I think trying to make all of the tooling multi-OS is unnecessary and adds quite a lot of complexity and maintenance burden. Is there a strong requirement for building on Windows?

This PR enables building the linux binaries from a Windows dev box. Windows/powershell doesn't handle this syntax of placing a variable assignment in front of a command, so we can use make's support for per-directive environment variables instead.

The one thing I need this for is to build cns in a service fabric pipeline.
Service fabric is primarily windows, so all of the jobs up until now are run on windows machines.
Is adding just the one variable export ok?

I checked the line endings, they are LF, the reason there's a change is that there was trailing whitespace before:

The one thing I need this for is to build cns in a service fabric pipeline. Service fabric is primarily windows, so all of the jobs up until now are run on windows machines. Is adding just the one variable export ok?

I would prefer the "special case" be in the SF pipeline, adding a Linux runner has basically no maintenance overhead or complexity, vs the complication being added to our Makefile where we need to maintain it.

We already support windows make targets in our makefile such as npm-windows-image and cns-windows-image, which are run on windows vms in our CI/CD
Since we already have windows targets, I think we should allow this change, as it keeps Linux working still
I would have to add a Linux job to the service faction pipeline, to change to GOOS to windows, to then copy those binaries from a Linux job to windows job, which just seems like more convolution than this change
What do you think @rbtr ?
@thatmattlong what do you think?


Skydive at my ICP v2101

From<EMAIL_ADDRESS>I have installed Skydive at my ICP v2101. At the first time, I can see the topology. After a while, I cannot get any topology again, just blank screen.
If I delete all skydive pods again, it will come out again… But, after a while, the topology will be disappeared again.
Any thought on it?
ERAN: Can you share logs from those pods (execute kubectl logs <pod_name>). Also, did you had to restart the Analyzer pod, the Agent pods or all ?

Eran, can we close this one ? any news on this ?

No more details, closing


Unable to display and input uppercase icelandic characters

Tested in v1.3 on Ubuntu 19.04.
Trying to add the task "This is a test Þ Ö Á É Ý Ú Í Ó Ð Æ" results in the following.

It also gets saved incorrectly. Note that lowercase letters are fine. All older tasks (added with different programs) are also affected as long as they feature uppercase icelandic letters.
Simple reproduction
Add: Þ
becomes
Add:  ^

Thanks for this report. Dang it, when we added support for other character sets at 77a9f97b I was hoping it would fix problems like this. Just to be sure, everything works fine when you add the task using Taskwarrior directly, right?

Yes, Taskwarrior works fine. Tasks added in taskwarrior with uppercase iceland-specific characters display correctly in Taskwarrior. But those tasks do get displayed incorrectly in Vit.
I've now tested this on two of my computers (both running Ubuntu 19.04) with the same results.
This is a bit of an odd bug as I've experienced and reported a lot of bugs in software regarding inputting and displaying icelandic characters throughout the years. Often they manage to display the accented characters (í á é, etc...) correctly but fail at more specific characters like Þ and Ð. I've never seen a problem where only capital letters would get mangled in such way.
One other thing. The terminal cursor also gets displayed in the wrong location. In the first screenshot it was supposed to be on the end of the line, but instead was displayed a bit to the left to it's actual location. For example, when writing "Þ" vit displays "  ^", with the cursor sitting on the empty space. So for each new uppercase icelandic character written two "characters" get added but the mouse only moves one spot forward.

Thanks for these extra details. VIT 2.0 is in the works and will be a big change. There's a chance this problem will be solved from the restructuring. Let's wait until then and then come back to this.

One other thing. The terminal cursor also gets displayed in the wrong location.

This is not surprising, given the main bug. Apparently it's not trivial to detect the length of a word written in an unsupported languages, because many characters require multiple bytes for each character. If it sounds like I know what I'm talking about, I don't :). But I will be interested in learning more and trying to fix this issue if VIT 2.0 doesn't magically fix it.

@johannesgunnar VIT 2.x alpha 1 has been released, think you can investigate if this issue still occurs there?
https://github.com/scottkosty/vit/releases/tag/v2.0.0a1

can confirm that v2.0.0a1 seems to have fixed the issue. Can't promise with special characters from other languages, but icelandic capital special characters work perfectly fine now.
Thank you very much.

Great, thanks for confirming!


Track user submissions

As a user, I need to know who submitted each test result for training and audit reasons.
Will we be able to track this in Stage 1? If so, it may require us to add a field to capture "User" in the export and/or in the Results table. Need further discussion on authentication approach and engineering effort.

By stage 1, do you mean for the prototype (non-production) or mvp (production)?
The prototype will not have a database, so we can populate it with fake data from the export and display in the client, but it can only be updated by the single user of the app.

Stage 2 is when we were planning on building multi-user capability, so this won't be possible until after Stage 2 (or as part of a large Stage 2 feature).

I was trying to use the definitions Shelby posted in slack! I think we need to align Stage 1, Stage 2, Stage 3 with what we (me, Heather, Alicia) have been using to refer to the different stages, which are MVP, MVP+, and Future State. We thought it might also be a good idea to start using those tags here. That is a different topic I can raise in Shelby's original thread.
To your original question, I meant stage 1 (prototype), but based on Pete's answer, I see this won't be possible until Stage 2 or later. Should I move tag this issue as "Stage 2" and move it to the icebox?

We've been sticking to only mapping out Prototype Stages so far - so in this case, Stage 2 Prototype is when we plan to add "multiple user / multiple device support" (more than one person / device to interact with the application). Until we build the Stage 2 Prototype, the application won't even have the concept of users, so we can't track what user did something.
Once we have initial multiple user / multiple device support delivered, we can start logging user actions. And building out so many more user features that will probably be required.

Stage -1 - local-only prototype
Stage 0 - multi user/multi-device prototype
Stage 1 - MVP
Stage 2 - MVP+
Stage 3 - Future State

This is a part of #119

Dependent on auth


Official documentation shows no information for algorithms contained in HistogramThresholding.jl

I was looking for information on the Entropy binarization algorithm, and found the following:
https://zygmuntszpak.github.io/ImageBinarization.jl/stable/reference/

However, that documentation is visible here:
https://juliaimages.org/HistogramThresholding.jl/stable/

Thanks for catching this. This might be due to our Documentation CI issue. The latest package version is v0.2.8 while the documentation is still v0.2.3. I'll check it later today.

The issue here is that Documenter CI isn't triggered by new tag releases. A github action (TagBot CI) cannot trigger another github action (docs CI) unless ssh key is configured. See also the "TagBot & tagged versions" in https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#GitHub-Actions
@zygmuntszpak Because TagBot uses DOCUMENTER_KEY, can you verify that DOCUMENTER_KEY secret is correctly configured? If not, you might want to follow https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#travis-ssh

closed by 900406f


Add ability to create codemirror with merge plugin, fixes #91

This let's you use the merge plugin by adding merge-view to the directive.
Example:
<ui-codemirror
    merge-view
    ui-codemirror-opts="options"
    ng-model="editCopy">
</ui-codemirror>

$scope.options = {
        orig: 'StringToCompareWith',
        lineNumbers: true,
        highlightDifferences: true,
        connect: true,
        collapseIdentical: false
}

I needed to use the merge plugin so I have done some functional testing of this PR. As far as I can tell this seems to work.
I think it would be a good idea if these changes could be considered for integration.

Hello,
Any news about this contribution ?

I don't understand how to use merge plugin.
Both values (old and new) I receive from ajax ($resource), and on initialisation moment I have no values...
What I should do?
html

js
$scope.editorOptions = {
mode: 'xml',
lineNumbers: true,
highlightDifferences: true,
connect: true,
collapseIdentical: false
};
...GET {
$scope.leftVar = val1;
$scope.rightVar = val2;
$scope.editorOptions.origLeft = $scope.rightVar;
}

I used hack. Wrap in ng-if and directive start only after ajax complete.


Pattern merge pipeline trial run - poisoning.tsv

Trying out new pattern merge pipeline from #4385  with the poisoning.tsv pattern file

Wow, I cant believe its worked. Its not so much me that should review it - the question is - does this match your expectations (ignore the small changes to the synonyms, this is because of the normalisation process).

I think it did work how I anticipated, but I'm seeing that checks have failed. Can you help me understand what the problem is?

I could, but I leave it to @sabrinatoro or @nicolevasilevsky to walk you through that. This has an easy fix, but needs some medical expertise and explanation. So, don't worry about it now! They will look at it on Monday!

@laurenechan I'll take a look at this asap but it may not be until later in the week

@laurenechan this is the reason for the failure:
FAIL Rule ../sparql/qc/general/qc-single-child.sparql: 1 violation(s)
entity,property,value
http://purl.obolibrary.org/obo/MONDO_0024251,http://www.w3.org/2000/01/rdf-``schema#subClassOf,http://purl.obolibrary.org/obo/MONDO_0018020
the issue is a single child, we have a check for this. You can read more about it in Chris' blog post: https://douroucouli.wordpress.com/2022/01/04/ontotip-avoid-the-single-child-anti-pattern/
I'll look into this and fix it

these are the classes in question

'Minamata disease'  is defined as A neurological syndrome caused by severe mercury poisoning.
It is caused by mercury poisoning, but it is not necessarily a type of mercury poisoning. Wikipedia says Minamata disease is a neurological disease caused by severe mercury poisoning.
I'll revise the parent class for this term.

need to fix conflict and then this can be merged


Add helper classes for building deploys that match the python SDK

Created a pull request. The test for some of the services are missing though (we need to clarify this issue with the Docker image)


Vogel 2008

[ ]  Evaluate dataset
[ ]  Fix maps
[ ]  Complete template checklist
[ ]  Write up summary report narrative
[ ]  Good commenting
[ ]  External review by someone else

Used code from #20 and created new markdown. Tables look okay but Alaska maps seem to be greatest bug 38b021d

Debugged Alaska issue in c87f904 on local branch
Added it to template in 2e3b249
@ktoddbrown let me know how you feel about the format of the maps when run (and the addition to the template) - I can adjust them accordingly.


Pixels for reporting autofill breakage UI

Task/Issue URL: https://app.asana.com/0/488551667048375/1207772527673440/f
Description
General pixels around reporting autofill breakage dialog
Steps to test this PR
ℹ Local hack to enable feature: In AutofillSiteBreakageReportingFeature, set default value to true
ℹ Logcat filter: message~:"Pixel sent:.*autofill_logins_report"

[ ] Manually add a password for fill.dev
[ ] visit https://fill.dev
[ ] Open Overflow->Passwords and authenticate (note, important to go through overflow here)
[ ] Verify autofill_logins_report_available in logs

Verifying cancellations

[ ] Tap on Report a problem with autofill; verify autofill_logins_report_confirmation_displayed in logs
[ ] Tap Cancel button; verify autofill_logins_report_confirmation_dismissed in logs
[ ] Tap on Report a problem with autofill again
[ ] This time, tap outside of the dialog; verify autofill_logins_report_confirmation_dismissed in logs
[ ] Tap on Report a problem with autofill again
[ ] This time, tap back button; verify autofill_logins_report_confirmation_dismissed in logs

Verifying acceptance

[ ] Tap on Report a problem with autofill again
[ ] Tap on Send Report button; verify autofill_logins_report_confirmation_displayed in logs

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4768  👈
#4765
#4763
#4741
#4740
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on  Graphite

Merge activity

Jul 24, 5:55 PM EDT: @CDRussell started a stack merge that includes this pull request via Graphite.


Add liveness check for heal client

Description
Continuation of PR: https://github.com/networkservicemesh/cmd-nsc/pull/401
Issue
https://github.com/networkservicemesh/sdk/issues/1187

@NikitaSkrynnik Could you rebase?


Add a sequence diagram for the requestflow

To make clear what happens when, it would be nice to have a sequence diagram, to see what happens when

can be found in DIAGRAMS.md, next to the README file


[PE-D][Tester A] Inputting Invalid Date Does Not Prevent Creation of Meeting

Invalid Date(2025-04-31 14:00) is still allowed in creation of meeting
Input
add n/Test Name 7 p/123 e/email@email a/what m/2025-04-31 14:00

Labels: type.FunctionalityBug severity.High
original: JerryO3/ped#3

Justification: Allowed to fix because this issue affects our meetings command, which is specified in our UG to "display all meetings for the week". This issue may cause some invalid dates to either appear or not appear in the Meetings window, depending on the day of the week.


Deployment zones are sometimes the wrong way round

Some missions have the red deployment zone next to the blue dice roller and vice versa.

Fixed in 5a0394f720236b7dc95be8d6d67b051b53debddd, with many thanks to @FChippendale


Update JMS client connector documentation

Closing this PR since JMS is moved to a separate repo, and these docs are no longer valid.
Created a separate issue https://github.com/ballerinalang/ballerina/issues/4020 to clean up the docs.


Website demo not working on mac with Safari

http://valor-software.github.io/ng2-bootstrap/
when go to datepicker:
ReferenceError: Can't find variable: Intl
Then no other page will work because of this error

@jaumard thanks for reporting, seems related with https://github.com/angular/angular/issues/3333


Broken video link on Azure Event Hub page

On Azure event hub page, video link is broken.
URL : https://youtu.be/45wgY-VSk9I

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0a6e2fa9-99f3-7a01-5629-42ff4a762ea8
Version Independent ID: d3992cd6-6809-d757-2725-0be592ee6521
Content: What is Azure Event Hubs? - a Big Data ingestion service - Azure Event Hubs
Content Source: articles/event-hubs/event-hubs-about.md
Service: event-hubs
GitHub Login: @spelluru
Microsoft Alias: spelluru

@surenderssm - Thanks for reporting the issue. Our platform doesn't support embedding YouTube videos in articles anymore, so I will remove the link today. Thanks!

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

Fixed. #please-close


Please invite me to the GitHub Community Organization

Name
Arosha
Discord Username (if applicable)
No response
Additional Context
I met him on Twitter I would  like to join to know more about open source projects and I want to contribute too.

I would like to join as beginner.


API Connector "HTTP + Swagger" - Improve example documentation for trigger?

The example given for documenting the HTTP + Swagger Trigger should be replaced with something more meaningful, demonstrating a real use-case for this trigger type.
What is shown today, makes no sense from my point of view (pollinig the face detection service; and even worse, without providing any input) and would rather distract new/average users which might just be exploring available standard connectors like this one.
Please correct me, but at the end the, HTTP + Swagger Triger is nothing more than a shortcut for using a Schedule-Trigger plus an additional HTTP/HTTP+Swagger Action.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b8856668-d4f5-0ade-5576-661ada7fcb0e
Version Independent ID: 291ff6b8-bfcc-786d-6295-eefae7d1b0d2
Content: Connect to REST endpoints from Azure Logic Apps - Azure Logic Apps
Content Source: articles/connectors/connectors-native-http-swagger.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@peta Thanks for the feedback! We have assigned this issue to the content author to review and update accordingly.

@peta, thanks for raising this issue. I've added a work item to our doc backlog for prioritization. I'll close this item for now and report back when the work is done.
@PramodValavala-MSFT: #please-close


[Bug]: Indented literal block "Could not find line"

To Dos

[X] I tested with the latest released version.

[X] I have checked the issues and think that this is not a duplicate.

[X] I added a very descriptive title to this issue.

Example Code (rst)
- Change the configuration defaults by running in your terminal:

  .. code-block:: console

      $ defaults write org.python.python NSAppSleepDisabled -bool YES

Relevant log output
Could not find line for literal block directive. Source: 'doc/help/faq.rst' at line None

Description
A nested/indented .. code-block:: causes problems. Unindenting it fixes them (but then doesn't render in RST nested in the bulleted list).
Operating System
macOS
Operating System Details
No response
Python Version
3.11.5
rstcheck Version
6.2.0, 1.1.1
Additional Context
No response

I think the underlying issue is the NodeVisotor from docutils, which is used under the hood for rst source validation. When the code block is indented the code block's node.line is None. I did not dive deeper, so I don't know the exact reason.
I reduced the message's level to warning and stated explicitly that the message itself only is a warning and may be due to an indented code block but is not an error of itself.

Released in 1.2.0


Enhancements to Admin

Add more columns to the IgnoreEmail admin page, including a calculated column of the queues the ignore relates to.
Sorry about the messy history - still learning!

Codecov Report

Merging #524 into master will decrease coverage by 0.04%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   63.28%   63.24%   -0.05%
==========================================
  Files          35       35
  Lines        3247     3254       +7
  Branches      494      497       +3
==========================================
+ Hits         2055     2058       +3
- Misses       1056     1060       +4
  Partials      136      136

Impacted Files
Coverage Δ

helpdesk/admin.py
86.53% <100%> (+0.53%)
:arrow_up:

helpdesk/models.py
78.87% <20%> (-0.65%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410f59a...a3741ad. Read the comment docs.


MsalGuard and consent scopes fail when scopes from multiple resources are specified

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.16.1
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.0.2
Description
We've been using MSAL Angular for a long time now, and I thought I knew how to configure it. We had to spend a few hours troubleshooting an error yesterday and although we got it working I'm confused. Was hoping you could provide some clarification.
In the MsalGuard config factory I've been including the full list of scopes to which the user needs to consent. This worked fine with scopes from two resources (Graph and our own API). When we added a third resource (another of our own APIs) we started getting this error:
AADSTS28000: Provided value for the input parameter scope is not valid because it contains more than one resource.
This error happens during authentication, not during an attempt to obtain access tokens for APIs (it doesn't get that far).
Removing the scopes from the guard config fixed the problem. Removing the new API from protected resource map also fixed it, but then we couldn't call that API, so that wasn't an option.
I'm just wondering what we're supposed to be doing with authRequest.scopes. The scopes are already consented by admins in Azure, so we don't actually need it, but if we did then would we be able to use it?
MSAL Configuration
const protectedResourceMap = new Map<string, Array<string>>();
protectedResourceMap.set('https://graph.microsoft.com/v1.0', ['User.Read']);
protectedResourceMap.set('https://api-number-one', ['api://api-number-one-id/access_as_user']);
protectedResourceMap.set('https://api-number-two', ['api://api-number-two-id/access_as_user']);

export function msalInterceptorConfigFactory(): MsalInterceptorConfiguration {
    return {
      interactionType: InteractionType.Redirect,
      protectedResourceMap
    };
  }

export function msalGuardConfigFactory(): MsalGuardConfiguration {
  return {
    interactionType: InteractionType.Redirect,
      // This fails. If I comment out authRequest, it works fine.
      authRequest: {
      scopes: [
        'openid',
        'profile',
        'User.Read',
        'api://api-number-one-id/access_as_user',
        'api://api-number-two-id/access_as_user',
      ]
    },
    loginFailedRoute: loginFailedUri
  };
}

Relevant Code Snippets
No response
Identity Provider
Azure AD / MSA
Source
External (Customer)

Hi @rellis-of-rhindleton , thanks for opening this issue, happy to help.
AAD doesn't support scopes for multiple resources in the scopes parameter, but there is a query parameter that MSAL and AAD support called extraScopesToConsent. Putting scopes for other resources in extraScopesToConsent should allow the server to prompt the user for consent on those scopes while they're logging in and although they won't receive an access token for those scopes immediately, the app can later request those access tokens silently.
Check out our docs on Resources and Scopes for more info on extraScopesToConsent and some usage examples.
Let us know if your issue is resolved with this suggestion so we can close the issue, thanks!

I see - apparently the documentation for msalGuardConfigFactory needs to be updated. There’s nothing in  about that.
I believe that answers my question, thanks.


Replace UnsafeMutablePointer.assign with update to remove rename warnings

Replaces to UnsafeMutablePointer.assign(repeating:count:) with renamed UnsafeMutablePointer.update(repeating:count:) to remove compilation warnings.
Checklist

[X] I've read the Contribution Guidelines
[X] My contributions are licensed under the Swift license.
[X] I've followed the coding style of the rest of the project.
[X] I've added tests covering all new code paths my change adds to the project (if appropriate).
[X] I've added benchmarks covering new functionality (if appropriate).
[X] I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
[X] I've updated the documentation if necessary.

@lorentey Sorry was looking at the wrong branch version when I made this PR. Assumed I was on main.


Adding chgrp to the Dockerfile causes the HasModifiedFiles check in Preflight 1.6.5 to fail

Bug Description
Adding chgrp on /usr/tmp to the Dockerfile causes the HasModifiedFiles check in Preflight 1.6.5 to fail.
I'm not sure if that's a bug, to be honest. Changing the ownership on /usr/tmp seems a bit strange but valid.
Version and Command Invocation
1.6.5
Steps to Reproduce:

Build an image quay.io/tkrishtop/chgrp-example:v0.0.1 using the Dockerfile below:

FROM registry.access.redhat.com/ubi8/ubi:8.8-854

RUN chgrp -R 0 /usr/tmp && \
    chmod -R g=u /usr/tmp

CMD ["cat", "hello world"]

Run the Preflight check and observe the HasModifiedFiles check fail:

$ podman run -e PFLT_LOGLEVEL=trace quay.io/opdev/preflight:1.6.5 check container
quay.io/tkrishtop/chgrp-example:v0.0.1
-- snip --
time="2023-06-07T11:23:19Z" level=debug msg="found disallowed modification in layer"
file=usr/tmp layer="sha256:a7c537545914139085dd460c4f33d59f4f4c7bd1f4dbf89973e32bebd7555799"
time="2023-06-07T11:23:19Z" level=info msg="check completed" check=HasModifiedFiles result=FAILED

Initially /usr/tmp is a symlink coming from ubi8 base image

$ podman cp $(podman create --rm registry.access.redhat.com/ubi8/ubi:8.8-854 bash):/usr .
$ tree
--snip--
    ├── src
    │   ├── debug
    │   └── kernels
    └── tmp -> ../var/tmp

Expected Result
Should HasModifiedFiles fail? Strictly speaking, we're not changing the file itself.
Actual Result
check=HasModifiedFiles result=FAILED
Additional Context
We are currently checking with the application guys on the partner side if these lines can be removed without harming the application.
cc: @bcrochet @acornett21

So, yes, a bug. Sort of. I would argue that if one would just change that to chmod /var/tmp instead of /usr/tmp, it would no longer fail, since we expect things in /var to change. Not sure what package owns that symlink (not really relevant), but I can see an argument for adding it to the exclusions, given it's usage as a temporary directory.


Drop Ruby 1.8.7 support

Where do we stand with supporting 1.8.7 going forward?
CI has been turned off for that version for a while now. There are some failures on my end around cases with time zones and segfaults around yaml, although those could just be my environment.
It does still seem to "mostly" work as I've done my best to keep everything compatible, but it probably makes sense to commit to a cutoff for ice_cube 1.0.
On the positive side, everything's all green in ruby-2.0.0.

Too old, nobody cares about 1.8.7 anymore.


Versions of the Docker Files

What do these versions refer to?  They are clearly not NWM versions (unless things have progressed much more quickly than I thought.  If these are versions for something else I would add a README describing this otherwise I think people may get confused.

Thanks for addressing this, this issue has been addressed in the updated readme.


Do we need libunwind?

https://www.nongnu.org/libunwind/
A complete C++ runtime stack consists of three components, from top to bottom:

a C++ standard library
a C++ ABI library
a stack unwinding library
As stated in my introductory post, in this GSoC project these roles will be taken by libc++, libc++abi and libunwind, respectively. As higher-level libraries depend on lower-level ones, we need to build them from bottom to top, i.e. :

build libunwind
build libc++abi against libunwind
build libc++ against libc++abi

Build libunwind:
$ cd $REPOS/libunwind && mkdir build && cd build
$ cmake -DCMAKE_C_COMPILER=x86_64-pc-linux-musl-gcc \
-DCMAKE_CXX_COMPILER=x86_64-pc-linux-musl-g++ \
-DLIBUNWIND_ENABLE_SHARED=0 \
-DLLVM_PATH="$REPOS/llvm" ..
$ make
Note: I want to statically link libunwind into libc++abi, so I disable the building of shared library through LIBUNWIND_ENABLE_SHARED. You may safely omit this option if you want a shared version.

Note: libgcc is GCC’s stack unwinding library and should not be used in our C++ runtime stack, so I explicitly disable it through LIBCXX_HAS_GCC_S_LIB ; otherwise it’ll sneak into our library.

We will need the unwinder. We'll also need to support SJ/LJ exceptions for ARM.

libunwind header support has been merged into libcpp master.


Package request: Ghostty

Project description
Ghostty is a terminal emulator that differentiates itself by being fast, feature-rich, and native. While there are many excellent terminal emulators available, they all force you to choose between speed, features, or native UIs. Ghostty provides all three.
Metadata

homepage URL: https://github.com/ghostty-org/ghostty
source URL: https://github.com/ghostty-org/ghostty
license: MIT License
platforms: macOS, linux

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Already merged. #368404


Use Uber maintained mockgen fork

The golang maintained version is no longer maintained. and they recommend the fork from the folks at Uber.
there is also ~50 commits ahead on the Uber fork :)) https://github.com/uber-go/mock

Thanks!


Possibility to specify the version of Docker to install

Be able to match a particular version of docker rather than using the latest one available

Fixed by PR : https://github.com/IshentRas/cookbook-openshift3/pull/10


[C# sample] Add .NET TwentyQuestions sample

Address https://github.com/microsoft/teams-ai/issues/251.
Tested on both local and Azure. Ready for review.

@corinagum could you review the docs?


Discontinue support for old PHP versions

As you can see from the list of supported versions, most of the versions we're still actively supporting are no longer supported by PHP itself. It might be time to drop support for these versions and update to use language features that are only available on later versions (e.g. type hinting of scalars). Older versions of this package will still be available to those that insist of running on ancient PHP versions, but they would be excluded from new functionality onwards.

A v2 of this package could achieve so much enhancement, like these PHP versions, a cleaner HTTP client #39 , and making objects immutable.

It seems that updates to this package are done mainly through contributor PRs - I guess that Messagebird don't use PHP themselves, so there isn't much drive to improve the code quality and get a v2 out.
Perhaps one of the maintainers could create a v2.x branch, so that we might create PRs against that and start getting some improvements in, eg:

Drop PHP 5.x
Use Guzzle as the HTTP client rather than re-inventing it
Remove the mutable objects (everything is public in Base, there's no constructor, no validation or validation can be skipped)

You should use HTTPlug rather than confining to Guzzle. Zee http://httplug.io/

A v2 of this package could achieve so much enhancement, like these PHP versions, a cleaner HTTP client #39 , and making objects immutable.

Dropping php version support would not necessarily require a v2 (https://www.doctrine-project.org/2017/07/25/php-7.1-requirement-and-composer.html)


Lake bridge

The bridge appears to be broken, it is passing the limits of the object.

Thanks for catching this! Fixed in 1.0.4.


How to force yarn install to install both darwin-x64 and darwin-arm64 on ARM Electron build?

Hi team,
I use electron-builder to build Beekeeper Studio. I just announced LibSQL compatibility but had to take it back because it broke my x64 Mac builds.
In electron, it's common practice to use an ARM64 Mac to build BOTH arm and x64 versions of the app. In fact you can also build a single universal binary.
However when I do this, only the darwin-arm64 package is installed, not the darwin-x86_64 package.
Is there a way to properly force both?

@rathboma  Not 100% sure but I do that on postinstall:
npm i --cpu x64 --os linux @libsql/client-linux@npm:@libsql/client --no-save

--cpu x64 --os darwin will download darwin-x64 build


How to create mask ?

I am exploring the dataset and was hoping to create mask for ALL_IDB1 and 2. Do you mind sharing details ?

This repository is just for ALL_IDB2, for ALL_IDB2 dataset take a look here.
To obtain the masks you have to select the pixels values you are interested in.
eg. to select background values are (255,255,255). Complementing the background, you can obtain the mask for the whole WBC

do you mind sharing code for this if you have handy ?

In Python
background = cv2.inRange(img, np.array([255,255,255], dtype=np.uint8), np.array([255,255,255], dtype=np.uint8))
#to obtain the cell mask
mask = 255 - background
in MATLAB
background = img(:,:,1)==255 & img(:,:,2)==255 & img(:,:,3)==255;
#to obtain the cell mask
mask = 1 - background

By changing the search values, you can obtain a different mask, as follows:
background  = 255, 255, 255
nucleus = 0, 255, 255
cytoplasm = 0, 0, 255


[MB 13164] PPM Closeout Expense Dropdown

Jira ticket for this change
Summary
This PR created the ExpenseForm component and displays different scenarios of its use in storybook under Customer Components / PPM Closeout / Expense Form
Storybook https://output.circle-artifacts.com/output/job/4d27fb3e-efb8-4c2f-8b3e-1608258c59bb/artifacts/0/storybook/index.html?path=/story/customer-components-ppm-closeout-expenses-ppm-form--sit-expenses
Designs https://app.zeplin.io/project/625896e702018f8ff82451c0/screen/625897c910f1e1907c1b2151
Setup to Run Your Code
Start the Storybook locally.
make storybook

Screenshots

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 3a7cba515019af32845a5db8d5710edae62d637a

Thanks Dina!
I've addressed your feedback, changes can be viewed with the updated url

Quite a few of what you listed here are just storybook specific interaction issues. I went ahead and mocked out the interactions for file uploading and deleting since storybook can't use our actual APIs for handling these events. So if you were to click on the file upload component, you'll just see the event registered in the actions tab
The extra decimal issue has been addressed
FWIW we have other text fields in the PPM closeout flow (like the vehicle description field on the Weight Ticket screen) that aren't implementing a character limit
Thanks for the link to the alert for what happens when the missing receipt button is checked. That was missing from this ticket. I went ahead and added it here. However, I noticed the blue used on figma is different than what's used for our Alert component. I'm not sure if that's an intentional change that should be introduced to all info type Alerts?

@pearl-truss I took another look and I think it looks good!
I will admit I don't know what changes were made to the upload functionality but understand that there are limitations because of Storybook so will assume that when this is on a page in Milmove we can take another look there.
I'm checking with @AnnaGingle about a copy thing in the alert here so once I hear back we can call this done. With regard to the Alert styling, yeah, it's very different in Storybook than in our designs. What we have in our designs should be the source of truth but because it takes engineer time to update the component in Storybook it's not a blocker at the moment.

@dinabeigelman does copy match? I pushed a recent change

@pearl-truss looks good to me!


fix: dynamic size not working properly when working with RWD

fix: dynamic size not working properly when working with RWD

Pull Request Test Coverage Report for Build 905806612

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 2.113%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/useVirtual.ts
0
3
0.0%

Totals

Change from base Build 903748306:
-0.03%

Covered Lines:
7

Relevant Lines:
256

💛  - Coveralls


failing the test should throw an error and stop the test execution

Currently calling fail not always stopping the test execution (specifically in callbacks), but it should.

Implemented as part of 1.0.0 release


Root accounts left with no passwords despite using encrypted data bags

After using percona::server with appropriately set encrypted data bags, I tested it worked with mysql -u root. I was able to login. I also tested with mysql -u root -p which also worked. Not understanding what was happening, I investigated further:
mysql> use mysql;
mysql> select host,user,password from user;
+-----------+------------------+-------------------------------------------+
| host      | user             | password                                  |
+-----------+------------------+-------------------------------------------+
| localhost | root             | redacted|
| myhostname       | root             |                                           |
| <IP_ADDRESS> | root             |                                           |
| ::1       | root             |                                           |
| localhost | debian-sys-maint |redacted |
+-----------+------------------+-------------------------------------------+
5 rows in set (0.00 sec)
It looks like the line from percona/recipes/configure_server.rb which performs the update:
configure_server.rb:  command "mysqladmin --user=root --password='' password '#{passwords.root_password}'"
...only applies the change to root@"localhost", but leaves other open root entries.
This is a nasty security issue.
I'd like to know if there's something in an attribute i can do to fix this, or if I need to write a separate recipe to clear out any accounts without passwords (or apply the password across all entries).
This was on Ubuntu 12.04 for reference.

I have the issue and I'm using the default named bag.  It's on RHEL if that is an issue.

Closing as old issue, please reopen if this is still a problem?


Expose index

I want to be able to render multi-column version, could you expose index and yield it in tghe template please?
{{#each checkboxes as |checkbox index|}}
  {{#if hasBlock}}
    {{yield checkbox.option checkbox.isSelected index}}
  {{else}}
    <li>
      <label>
        {{input type="checkbox" checked=checkbox.isSelected disabled=disabled}}
        {{checkbox.label}}
      </label>
    </li>
  {{/if}}
{{/each}}

Thanks,
Serge

Feature added as of 0.10.0, thanks for the feedback!


New function shortestPaths()

shortestPaths(from, to, { labels: [ *[,] ], maxDepth: , limit:  } )
We need a function that returns multiple shortest paths, ordered by shortness. limit is the maximum number of shortest paths you want to retrieve.

My apologies in advance if not proper place but,
I'd also appreciate if Dijkstra function also allows you to specify mandatory vertices and/or subpaths.

@Unduli WDYT about creating a new issue with the detail of what you're looking for?

This is a must!  Is there a chance to have this function integrated before 2.2?  Is it too late for 2.1?

I ran across this while digging through the issues database after a sleepless night (I blame @lvca for creating OrientDB in the first place).
Anyways, @Unduli's reply about an implementation of Dijkstra's algorithm in addition to shortestPaths() got me thinking. Would someone more familiar with the internal intricacies and implementation of OrientDB be willing to write up a draft of "best practices" for the implementing algorithms like the ones being talked about here for use in OrientDB?
Release quality documentation isn't necessary, I'd be more that willing to take even a rough sketch proof, expand, and generally get the addition into a state where it could be included in the official developer documentation.

@voxadam I hope you're blaming my name anymore :-) @luigidellaquila is working to the new pattern matching, probably he's the right guy to ask for this guide. Nice idea.

Hi, testing shortestPath() (no ShortestPaths).
I obtained only one results linking between two vertexes; but there should be more paths of the same length.
I understood ShortestPaths will returned more paths ordered by shortness.
Does shortestPath return multiple paths of the same shortest length or just one and only result?

As best I can tell, currently (e.g. In 2.1.7) there is no way to determine, in general, the edges corresponding to the shortest path that is found by any of the shortest-path builtins.  This seems to be a major oversight, but perhaps it can be remedied relatively easily, e.g. by adding a parameter so that the shortest path functions can be instructed to return vertices and edges.  (Alternatively, variant functions could be added, e.g. shortestRoute(s).)


fix: Add missing amundsen-rds package

Signed-off-by: hhobson<EMAIL_ADDRESS>Summary of Changes
databuilder version 4.2.1 is missing amundsen-rds package. Have added package and with no version pinning as presume will always want to use latest.
Tests
No test added as only changed setup.py
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes make test

thanks


feat: breaking e2e tests with initial siloing impl

Please read contributing guidelines and remove this line.

Benchmark results
Metrics with a significant change:

proof_construction_time_poseidon_hash_ms (32): 77.0 (+35%)
proof_construction_time_sha256_100_ms (16): 7,037 (+24%)
protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 2,852 (-17%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 57.8 (-34%)
avm_simulation_time_ms (Token:_increase_public_balance): 9.41 (-88%)
avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 141 (+91%)
protocol_circuit_proving_time_in_ms (base-parity): 1,916 (+34%)
protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 9,007 (-18%)
protocol_circuit_proving_time_in_ms (public-kernel-teardown): 16,315 (-18%)
protocol_circuit_proving_time_in_ms (root-rollup): 25,171 (-21%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Proof generation
Each column represents the number of threads used in proof generation.

Metric
1 threads
4 threads
16 threads
32 threads
64 threads

proof_construction_time_sha256_ms
5,730
1,548
706
754 (+2%)
763 (-1%)

proof_construction_time_sha256_30_ms
11,765
3,140
1,401 (-1%)
1,437 (+1%)
1,516 (+3%)

proof_construction_time_sha256_100_ms
44,096
12,545 (+1%)
:warning: 7,037 (+24%)
5,609 (+1%)
5,527

proof_construction_time_poseidon_hash_ms
78.0
34.0
34.0
:warning: 77.0 (+35%)
90.0 (+3%)

proof_construction_time_poseidon_hash_30_ms
1,522
417
200
233 (+7%)
271 (+2%)

proof_construction_time_poseidon_hash_100_ms
5,615
1,513
674 (-2%)
728
744 (-1%)

L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
4 txs
8 txs
16 txs

l1_rollup_calldata_size_in_bytes
740
740
740

l1_rollup_calldata_gas
6,728
6,716
6,716

l1_rollup_execution_gas
611,995
612,134
612,285

l2_block_processing_time_in_ms
751 (-1%)
1,394
2,651

l2_block_building_time_in_ms
10,514 (+2%)
20,134 (-2%)
40,459

l2_block_rollup_simulation_time_in_ms
10,514 (+2%)
20,133 (-2%)
40,459

l2_block_public_tx_process_time_in_ms
8,772 (+2%)
18,222 (-2%)
38,414 (-1%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric
3 blocks
5 blocks

node_history_sync_time_in_ms
6,963
9,781 (+1%)

node_database_size_in_bytes
12,718,160
16,900,176

pxe_database_size_in_bytes
16,254
26,813

Circuits stats
Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Function
time_ms
bytecode_size_in_bytes

GasToken:_increase_public_balance
94.7
8,139

GasToken:set_portal
11.7 (+9%)
2,362

Token:constructor
120 (-4%)
31,107

FPC:constructor
96.1 (-2%)
24,011

GasToken:mint_public
79.7 (-1%)
6,150

Token:mint_public
86.0
11,720

Token:assert_minter_and_mint
:warning: 57.8 (-34%)
8,028

AuthRegistry:set_authorized
42.6 (-3%)
4,537

FPC:prepare_fee
252 (-13%)
8,812

Token:transfer_public
38.7 (+8%)
47,374

FPC:pay_refund
70.6 (+17%)
12,114

Benchmarking:increment_balance
1,018 (-2%)
7,450

Token:_increase_public_balance
:warning: 9.41 (-88%)
8,960

FPC:pay_refund_with_shielded_rebate
:warning: 141 (+91%)
12,663

Public DB Access
Time to access various public DBs.

Function
time_ms

get-nullifier-index
0.151 (-3%)

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
256 leaves
512 leaves
1024 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.4 (+1%)
16.5
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.7
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.601 (+1%)
0.508
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
47.8
75.3
132 (+2%)
241
462

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
287
543
1,055

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.488
0.463
0.453 (+2%)
0.437
0.432

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
59.4 (+1%)
109
179 (-1%)
346
683

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
109
207
355
691
1,363

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.500 (+1%)
0.491
0.475
0.469
0.468

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
72.0
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
133
N/A
N/A
N/A
N/A

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
0.511
N/A
N/A
N/A
N/A

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
62,729
664,455

Transaction size based on fee payment method
| Metric |  |
| - |  |


Get Pins of a Section

Hi,
Could you please allow to retrieve the pins of a section?
The code should be like this:
foreach ($ bot-> boards-> pins ($boardId, $sectionId) as $ pin) { // ... }
I ran the above code. It does not return an error, but I get the pins of the board, not the pins of the section.

Hi! What is the point of this request?
When talking about providing a pull request in #388 I've suggested that you would implement this feature. And then I could merge your code in the library.

Closing.


[Best Practice] Permissions code with allow access by default patterns

When checking for permissions, its possible that the user is set to null, when this occurs it has identical behavior as if the user was cluster admin.  This 'allow access by default' paradigm creates risk, no matter if it is an error in this code base, another plugin, or inside of OpenSearch; the result is a situation where unauthorized access/actions can occur.
Can we modify the code to deny access if the user is null?
https://github.com/opensearch-project/index-management/blob/279f7a6a148f2d31105c6fedbc5b72766b948bad/src/main/kotlin/org/opensearch/indexmanagement/util/SecurityUtils.kt#L137-L138
https://github.com/opensearch-project/index-management/blob/279f7a6a148f2d31105c6fedbc5b72766b948bad/src/main/kotlin/org/opensearch/indexmanagement/util/SecurityUtils.kt#L151-L152
See vulnerability classification CWE-841: Improper Enforcement of Behavioral Workflow

This is a backward compatibility consideration.
For ISM user upgrade from older version that doesn't has security integration feature, the user object in the old ISM jobs is always null, and we don't want those to be blocked but to work with admin permission.

For ISM user upgrade from older version

This seems like something that could be fixed with migration from previous versions to new versions that would no longer have this weakness

This is not really a weakness because our plugin security model is designed as this:

If security integration feature is there, the user object is saved into system index which is supposed to be a safe place that cannot be manipulated. The only way to create/update the user object is by calling the ISM API, and ISM API will get the user information and save it behind the scene which also cannot be manipulated.
user object can only be null if cluster is updated from an environment w/o ISM security integration feature. We treat this null user object as the admin.


Fixes how constraints are recorded in verbose=True

Description
Scalarizes the constraint count instead of just reporting the number of constraints.
Type of change

[ ] New feature (backwards compatible)
[ ] New feature (breaking API changes)
[x] Bug fix
[ ] Other (Documentation, CI, ...)

Contribution checklist

[ ] Add our license to new files.
[ ] Check that your code adheres to our coding style.
[ ] Write unittests.
[ ] Run the unittests and check that they’re passing.
[ ] Run the benchmarks to make sure your change doesn’t introduce a regression.

Nice!


badge number not shown on android

Thanks a lot for this super nice plugin!
Everything was as expected on both ios and android except the badge on android.
But maybe I misunderstand something here.
I expected a number "7" appear in the right top corner of "my app" logo, when it's closed.
I get notification text but not the the badge number. I get this red number for ios app though.
Is it intended behaviour and I have to set it myself in Push.addListener('badge')
or it should be shown automagically?
push code:
        Push.send({
            from: 'push',
            title: 'Some title',
            text: 'Some text',
            badge: 7,
            sound: 'airhorn.caf',
            payload: {
                title: title,
            },
            query: {
                // this will send to all users
            }
        });

<EMAIL_ADDRESS><EMAIL_ADDRESS>config.push.json:
{
  //...
  "production": false,
  "badge": true,
  "sound": true,
  "alert": true,
  "vibrate": true
}

is badge count supported now by the android OS?

I don't think so, I thought your plugin sets it (similar to cordova-badge-plugin)?

@vohtaski ok - nope - the push package uses the native behaviour - it's not present on android - the cordova-badge-plugin is as I recall kind of a hack.
I think it would make sense to add the badge feature in the cordova push package, since it provides the badge updates/api on iOS already.

yep, but it'd be indeed kind of a hacky solution, since android does not support it out-of-the-box through APIs. imho, for now we decided to skip this for our app ;)
so we can close the issue, unless you wish to change it into "feature request"

@vohtaski I think it's a valid feature request - I'm just thinking if it's better suited for the cordova push plugin instead though :)

closing, submitted an issue on phonegap-plugin-push

@raix Hi Sir, First of all thank you so much such a great plugin. As badges are supported now in android, do we have badges working for the same?


(Try to) upstream functionality to pgx

Hi, I've stumbled over your library while searching for how to use the pgx struct tags with insert / update operations. In my opinion the pgx functionality is quite incomplete because it only allows for scanning. Don't you think it would be a better idea to try to upstream the functionality of your library to the pgx project?

Thanks for the suggestion and sorry I don't think that makes sense. There are two library families in there: one hosted by the pgx core maintainer, and another one hosted by additional contributors.


added screenshots in FAQ section for Screenshare

Updated Screenshare Docs

@KaustubhKumar05 In this PR, I want to reduce the size of the images such that the 3 screenshots show up side by side. How can it be done?


duckdb: 0.6.1 -> 0.7.0

Description of changes
Bump duckdb from 0.6.1 to 0.7.0
Notes

Because of a new build process in 1a512421e31e540624e3ca7d232901448954c1b7, I had to add a patch that installs the duckdb binary to the previous INSTALL_BIN_DIR location.
Some new network-based failing tests are skipped

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@lovesegfault Can you take a look at this?


AMBARI-24194: Fix broken Java UTs in ambari-server code --- Part 2

What changes were proposed in this pull request?
The fix is to clear all broken audit, bootstrap, checks and cleanup 4 modules UT cases, also fixed some broken UT cases in agent moduel due to merge with trunk.
How was this patch tested?
Manually tested

@jonathan-hurley @adoroszlai @swapanshridhar Could you please review this patch? thanks.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3104/
Test FAILed.
Test FAILured.

Why are there so many commits in this PR? You should be rebasing your changes on top, resolving conflicts as you go.

@scottduan Only before you open the pull request:
git rebase upstream/branch-feature-AMBARI-14714

Once the PR is open, please avoid rebasing or amending commits that are already pushed to the PR, because they alter history.  Usually you don't need to merge either, unless there are conflicts which you must resolve.  Incremental commits to address review items should be fine.

@adoroszlai I just submtted new patch to fix incorrect order of import file and removed unused import files. If your review is ok, please help me merge it to the feature branch. Thanks.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/3109/
Test FAILed.
Test FAILured.


Truncate branch name when used in Google Cloud names

Motivation
Zebra's DevOps workflows fail on long branch names:

ERROR: (gcloud.compute.images.create) Could not fetch resource:

Invalid value for field 'resource.name': 'zebrad-cache-increase-block-validation-timeouts-0eb6a83-v23-mainnet-tip'. Must be a match of regex '(?:a-z?)'

https://github.com/ZcashFoundation/zebra/runs/6283701351?check_suite_focus=true#step:10:69
It would be good to fix this eventually, but it's not urgent.
Designs

truncate branch names before using them in length-limited contexts (in this case, we can only use 24 characters)

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

Motivation
Zebra's DevOps workflows fail on long branch names:

ERROR: (gcloud.compute.images.create) Could not fetch resource:

Invalid value for field 'resource.name': 'zebrad-cache-increase-block-validation-timeouts-0eb6a83-v23-mainnet-tip'. Must be a match of regex '(?:a-z?)'

https://github.com/ZcashFoundation/zebra/runs/6283701351?check_suite_focus=true#step:10:69
It would be good to fix this eventually, but it's not urgent.
Designs

truncate branch names before using them in length-limited contexts (in this case, we can only use 24 characters)

Yep I'm good with 'just' truncating the branch names, that is still helpful to a human to distinguish branches

This made a full/checkpoint sync test fail:
https://github.com/ZcashFoundation/zebra/runs/7535292198?check_suite_focus=true#step:8:70
So I'm marking it as medium priority.

We fixed long branch names in image names in PR #4962.
We also use these long branch names in instance and disk names, but the other text is much shorter, so they can be 30+ character. If that limit becomes a problem, we can open another ticket to fix the failing usage.


Implement the Program API

Added to epic https://github.com/pulumi/pulumi-kubernetes-operator/issues/586


openapi  from odata error

I generated the openapi spec from an odata application and the typescript client in kiota didn't work with the url parentheses. for example, for the url http://aaaa.bbb/entities({id}) in the model, a method called entitiesWithId(type | undefined) was generated and when used it causes an error that entitiesWithId is not a function. i can generate some code for error reproduction if need it.
Another situation is that using the "strict" option in the typescript settings, the following error message is generated in all models:
src/app/models/contratoAggregate/index.ts:125:95 - error TS2345: Argument of type '(writer: SerializationWriter, contrato?: Partial | undefined) => void' is not assignable to parameter of type 'ModelSerializerFunction'.
Types of parameters 'contrato' and 'value' are incompatible.
Type 'Partial | null | undefined' is not assignable to type 'Partial | undefined'.
Type 'null' is not assignable to type 'Partial | undefined'.
writer.writeCollectionOfObjectValues<Contrato>("value", contratoCollectionResponse.value, serializeContrato);

Hi @marcioatws
Thank you for using kiota and for reaching out.
For the parameter type this was introduced by #1248 and needs the corresponding generator changes to function properly https://github.com/microsoft/kiota/pull/5163. You can use the latest preview release and re-generate the client.
For the non-existent function, can you provide a repro description please?


Feature Request - UA Goals with Funnels

Universal Analytics Goal List does not provide the standard export data from the Management API; the JSON returned provides the funnel for URL_Destination Goals.
Insight into these funnel configurations can provide clearer direction when translating UA->GA4. It drives a strategic conversation with site owners around the uniqueness of a funnel's contents. It helps to decide between one funnel_steps event with parameters illustrating the different step numbers/names vs. individual funnel_stepN events for each one of the paths previously listed in the UA Goal.
Management API: with a 1 step required funnel as a short example
{
      "id": "11",
      "kind": "analytics#goal",
      "selfLink": "https://www.googleapis.com/analytics/v3/management/accounts/XXXXXXXX/webproperties/UA-XXXXXXXXX-8/profiles/XXXXXXXX/goals/11",
      "accountId": "XXXXXXXX",
      "webPropertyId": "UA-XXXXXXXX-8",
      "internalWebPropertyId": "XXXXXXXXXX",
      "profileId": "XXXXXXXXX",
      "name": "LP \u003e\u003e order",
      "value": 0,
      "active": true,
      "type": "URL_DESTINATION",
      "created": "2019-06-26T16:52:02.163Z",
      "updated": "2019-06-29T00:29:51.287Z",
      "parentLink": {
        "type": "analytics#profile",
        "href": "https://www.googleapis.com/analytics/v3/management/accounts/XXXXXXXX/webproperties/UA-XXXXXXXX-8/profiles/XXXXXXXX"
      },
      "urlDestinationDetails": {
        "url": "^\/summary\/(.*)confirmed",
        "caseSensitive": false,
        "matchType": "REGEX",
        "firstStepRequired": true,
        "steps": [
          {
            "number": 1,
            "name": "Zava",
            "URL": "^/zava\-"
          }
        ]
      }
    }

**Utilities:** with no indication that a funnel exists for this URL Destination

This is a great point. Thanks for bringing this up.
Adding these array values into a spreadsheet format where each row is an individual goal is bit tricky. The simplest option would be to create a new column and write the "steps" JSON output for a given goal to a single cell in that goal's row. Would that address the use case you described?
It wouldn't be very convenient for anyone want to to make a goal with funnel steps from scratch from the sheet, but hopefully folks aren't doing that these days.

A single column as "hasFunnel" with "true/false" values would be minimally viable.
The JSON output into a single cell would be fantastic.

Fixed in the latest release.


fix: prevent panic on malformed slice

Fixes a panic when slices are malformed that was found via fuzz testing CLI shorthand and makes the type checker more resilient against nested negative indexes when nested types are unavialable.

Codecov Report
Base: 66.50% // Head: 66.50% // No change to project coverage :thumbsup:

Coverage data is based on head (b094623) compared to base (4dd5401).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #5   +/-   ##
=======================================
  Coverage   66.50%   66.50%
=======================================
  Files           7        7
  Lines        1000     1000
=======================================
  Hits          665      665
  Misses        272      272
  Partials       63       63

Impacted Files
Coverage Δ

interpreter.go
70.73% <100.00%> (ø)

typecheck.go
68.70% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[TIKI-113] feat: https proxy support

Add support for extra environment variables to be passed to the helm template, so that the standard HTTPS_PROXY variable can be supplied. Document that this is supported.

:tada: This PR is included in version 0.19.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


all fields are resetting when changing an initial value attached to redux state

function mapState(state) {
    return {
        initialValues: {
            terms: state.register.toJS().terms.value
        }
    };
};

[map dispatch object here]

export const MyFormContainer = reduxForm({
    form: 'myForm',
    fields: ['email', 'password', 'terms']
}, mapState, mapDispatch)(MyForm);

<input type="checkbox" {...terms} onChange={this.handleTermsToggle.bind(this)}/>

When clicking the checkbox, the email and password fields are cleared. If I use the overwriteOnInitialValuesChange: false flag, the checkbox can no longer be checked or unchecked. Is this not the correct way to attach a simple boolean value from an existing redux state?

Turns out I was approaching the problem from the wrong angle. I needed to remove that chunk of the state tree altogether, and instead, use { change } from 'react-redux' in my outside component to modify the value.

So you solved the problem?

@erikras The initialValues behavior in version 5 still seems a little wonky to me, but this is all set on my end now; closing.


Destroying messages after logout

Fixes #816

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/817 (JID-3610)

@blueorangutan package

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/817 (JID-3611)

Not destroying the notifications since that'll clear the session expired notification


输入英文单词重复.

输入英文单词,比如who 然后选择whole就会变成whowhole.

Duplcated: https://github.com/ibireme/YYText/issues/89


CHP: Improve Lighthouse stats

CHP performance and accessibility are in the yellow zone.
See https://www.foo.software/dashboard/pages?pageId=6074b1ca0ed13f002507bc56
Some suggestions from Lighthouse:

[ ] #636
[ ] #649
[ ] #634
[ ] #648
[ ] #650
[x] https://github.com/mitodl/ocw-hugo-themes/issues/1038
[x] https://github.com/mitodl/ocw-hugo-themes/issues/1035
[x] https://github.com/mitodl/ocw-hugo-themes/issues/1033

I'm unable to access this link:

maybe you can add me as a user in Account > Users though I have created an account on foo.software and added a page https://ocw.mit.edu/ and the stats which I'm seeing has accessibility=100 though performance, CLS, LCP are in yellow zone and  PWA in red zone so I'll look into these.

I think, by doing the following, we can improve Performance (including CLS, FCP, LCP, TTI):

Most important: Change the image formats to nextgen formats, i.e: WebP and AVIF (reference). Browser compatibility might be an issue so in that case, maybe we can reduce/compress the image size to 30-150 KB at max.
Defer loading for scripts that are not immediately required when the page loads.
Serve static assets with an efficient cache policy. I'm not much sure about it, maybe if @gumaerc can share some thoughts on this?
Reduce/remove unused CSS/JS (if any)
Add explicit width and height for image elements.

Other than performance, Accessibility, Best Practices and SEO seems to be fine (90+ value) but PWA is not good. But I'm not sure if our goal is to make OCW a PWA? If yes, then I can look into it.

@MAbdurrehman12 The entire site is fronted by Fastly (including static assets) so that should be covered.  Because the entire thing is a static site, it's pushed up to S3 and then Fastly caches content as it's requested.

@MAbdurrehman12 The entire site is fronted by Fastly (including static assets) so that should be covered. Because the entire thing is a static site, it's pushed up to S3 and then Fastly caches content as it's requested.

Thanks.
Do you also have some thoughts on the description of this issue?

The entire site is fronted by Fastly (including static assets) so that should be covered. Because the entire thing is a static site, it's pushed up to S3 and then Fastly caches content as it's requested.

@gumaerc I'm not sure which recommendation you're responding to. I started breaking them out into separate issues. Can you comment on them as appropriate?

@pdpinch Will do, but I was commenting on the item @MAbdurrehman12 tagged me in about caching specifically.  Essentially caching should already be covered because we front the entire site with Fastly, but you may want to ask devops for confirmation on how that works.

@MAbdurrehman12 won't finish this before he leaves


Add RAG using Azure Cosmos DB for MongoDB vCore and Azure OpenAI

If you are submitting a new azd template to the gallery
Fill this out if you want your template to be added to the awesome-azd gallery!
Your template repository
Place your template repository link here:
https://github.com/john0isaac/rag-semantic-kernel-mongodb-vcore

[X] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

[X] Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

[X] Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

[X] Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

[X] Link to Author's GitHub or other relevant website - Used for attribution

[X] Author's Name -  Name to credit on the gallery card

[X] Link to template source - Link to the template GitHub repo

[X] Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!
Required tags:

[X] Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
[X] Tag the IaC provider ("bicep" or "terraform")
[X] At least 1 tag for programming language used
[X] At least 1 tag for Azure services integrated
[X] Add the "new" tag for any newly authored templates

[ ] In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

@john0isaac, @hemarina - We have finished this template test, and we filed three issues. Please review.

https://github.com/john0isaac/rag-semantic-kernel-mongodb-vcore/issues/8

https://github.com/john0isaac/rag-semantic-kernel-mongodb-vcore/issues/9

https://github.com/john0isaac/rag-semantic-kernel-mongodb-vcore/issues/10

Hey @zedy-wj, @hemarina
Thank you for testing.
I solved all the issues. Don't know why it failed to work for @Menghua1
I just deployed this and it works fine for me.

All is done now, thank you everyone for testing and reviewing!


Adding title and link to the event schema

We were discussing today about NOTIF-538 which requests a common way to display the event in the UI and link to them.
The proposal is to add the optional fields for title which describes the event in a human readable form such as: 10 recomendations found for system ABC. It will be up to the sender to define a title.
Other nice thing to have would be an URI to link back to the event or to see more information, this would be related to the event.
Right now the consumer of the event has to create a title by checking the event type and using the contents of the event to build a meaninful message.
//cc: @RedHatInsights/notifications-committers

I'm wondering if we should limit in length the title...
I don't have a good number in mind though, it will vary if this is displayed in Splunk vs Grafana vs Email subject vs Notif drawer...
We can always truncate I guess...

The idea is basically to put that in the envelope to make sure that every sub-schema provides it in the same way (if they decide to provide that at all)?

Yes, so you can always display a summary of the event.
They should be optional, but then some title should be generated from eventype/app name

BTW a known issue is when you have multiple events per message... The title is set at the message level and would be the same for all events...
For Policies we have all matching policies in a single message, they would all share the same title... "Policy matching for rhel8" for instance

PS: I started a discussion here. I'm still hesitant because I'm not sure how useful it would be when there are multiple events in a message

PS: I started a discussion here. I'm still hesitant because I'm not sure how useful it would be when there are multiple events in a message

We can also add the title/href for each event, json schema supports something like "your own object plus this other object" using the allOf syntax.

Then I guess this would be much better !

PS: I started a discussion here. I'm still hesitant because I'm not sure how useful it would be when there are multiple events in a message

We can also add the title/href for each event, json schema supports something like "your own object plus this other object" using the allOf syntax.

Updated the content - using the title and href_url as part of the event itself and the data.
Changes might be easier to review with hide whitespace enabled.
I'm unsure about the name on the separate schema (human  readable), would appreciate your thoughs.

Congrats on finding a name, I don't have a better proposal.
Changes sound fine to me and a lot more useful than my initial proposal!
(and thanks for the "hide whitespace" pro-tip, I learnt something today)

@jeromemarc change request to the future schema, adding a text and URL to an event.

Actually i missread the schema. In event level, the data is a single thing. It is the application that defines/allows to have multiple sub-events. This human_readable schema would need to be extended by all of them in the particular event.
But i guess we are back again to square one; the application (notifications or splunk) would need to look where to look for the sub-events.

@josejulio I'm also thinking it probably makes sense to close #7 and incorporate anything necessary from that PR here. Thoughts?

For daily aggregation, it's implemented on notifications side.
We introduced support to sent multiple events at once because of examples like this:
1 - a system payload is uploaded by a RHEL machine
2 - Advisor finds 5 recommendations for this payload
When we store in splunk, user would prefer 5 distinct lines/events. When we address a human by email, he'll prefer 1 email with the 5 recommendations.
Adding support to send related events at once is a lot easier on our side.
The alternative is to stop supporting this, get individual events and do all the aggregation ourselves, this would make it a lot harder on our side I think. I know @gwenneg  got familiar with Kafka streams and that my help...
I guess, for aggregated emails for a single payload we would need to
1 - collect events that share some same id
2 - wait for related events
3 - after a defined amount of time send the aggregated result (or an event claiming, it's the last one)
I don't know how that works when multiple pods are reading from Kafka and in case of failures during that process...
We'll also need to somewhat define what's the "id" that we want to look at, but we could have an additional field for an event-type that defines what field to use to aggregate events for emails, or part of the email template definition ?

Would "description" or "text" be a better field name than "title" ? Additional schemas will need to be careful about possible collisions anyway

I guess so, title seems so specific.

I would probably change title to description as long as there is no conflict with other fields.

@josejulio revisiting this, I get the impression that the goal of this is to add a re-usable schema for emitting aggregations. Is the expectation that the apps themselves will do the aggregations?

One issue we had with splunk is that they were consuming notifications from policies, drift and advisor (AFAIK), but they needed some sort of title/description and a link for their UI.
They could pick the app and event names (policy - policy triggered) or they could dig down on the data of each particular notification to build one (Policy "Foobar" triggered for system "System-003").
The aim here is to add a schema to allow (but not enforce) some kind of UI-ready metadata without having to know much about the contents for the consumers of the events. In the end, the consumer of the event could check somehow if the event conforms to that schema and use the fields.
@theute commented about the problem we have with allowing (and not allowing) multiple events within a single notification.
Not really a problem about the aggregation.

@josejulio I'm also thinking it probably makes sense to close #7 and incorporate anything necessary from that PR here. Thoughts?

The purpose of this PR is different from #7. But I can happily take over #7 (or create a new PR) if you want.

@josejulio given you approved #7, I went ahead and merged it. Please feel free to rework this PR to make additional changes, or close this one if you like.

Updated the code, sort of follows what #4 requires - but instead of a human readable representation for the event-type it aims to help provide a human readable representation for the event itself.
Suppose we have the event type  cost-management-report-ready, the human readable schema could be used to include:
"data": {
  "title": "Cost management monthly report is ready",
  "href_url": "https://link-to-cost-management-monthly-reports/123b/foobar.pdf"
}

If we have a advisor-recommendation, the human readable schema could extend the advisor schema to include it. e.g.:
"data": {
  "advisor_recommendations": [ "/* all recommendations */" ]
  "title": "15 recommendations for system MySystem",
  "href_url": "https://inventory/MySystem"
}

It could go further than that and include the human_readable as part of each recommendation - it's up to the application how to use this schema.
"data": {
  "advisor_recommendations": [
    {
      "rule_id": "abc-001",
      "...",
      "title": "Recomendation abc-001 do not share your password on system MySystem",
      "href_url": "https://advisor/recommendations/abc-001"
    }
  ]
}

Current code extends the objects with title and href_url, but could live under a property (e.g. human_readable) - that might help to keep more order.
tagging @beav as the reporter of #4


Alternate install command for global tools packages on the packages page

Addresses https://github.com/nuget/NuGetGallery/issues/5182 .

Packages with this package type should display a “dotnet install packageId packageVersion” tab only, rather than the standard tabs.

The options I've considered are:

[ ] Display the correct message for dotnet.exe. Display unsupported for others.
This is what I've implemented here.

[x] Display the correct message for dotnet.exe. Don't display tabs for others.

We need a review from PMs before merging this.
@anangaur @karann-msft
I'll sync up offline as well.
@skofman1 Please let me know if I should target a different branch in order to get this through live soon.
//cc for visibility.
@KathleenDollard
@wli3
@rrelyea

it should be
dotnet tool install  ---global PackageID

Also, how is this effected by https://github.com/NuGet/NuGetGallery/pull/5656?
/cc @khellang

Showing unsupported is not right. We should hide the other tabs. And show only the .NET CLI tab:

We should get the warning text (may be convert from warning to info text with gray background) from @KathleenDollard . Learn more in the text should take to global tools intro documentation. Again get a permalink from @KathleenDollard

Does that mean there's no way to install project-local tools anymore? I though the global tools were an addition, not a replacement?

The packages of dotnetCliToolReferences and global tools are not compatible. global tools will replace dotnetCliToolReferences, but so far there is change on dotnetCliToolReferences. It should be keep working

@nkolev92 do attach the screenshot post implementation

@anangaur
Will do :)
I was going to sync up offline with you on how exactly it should look before I added a screenshot here :D

@anangaur
Updated with another screenshot.

Only the link to .NET tool is missing. Otherwise LGTM.

Kathleen is on a conference this week. Could this link be added later?

I can add it when I'm finishing https://github.com/NuGet/NuGetGallery/pull/5656 👼

@nkolev92 , looks good! Please review the text with PM before merging.

.NET tool package that lets you install a tool in the .NET environment

The word "tool" is repeated too many times for such a short sentence :)

Changed the message based on Svetlana's feedback, but will just use what message and link,
@KathleenDollard and .NET team deem appropriate.
🔔
@loic-sharma
@joelverhagen

@wli3
Just waiting on a corrected message and a link.

@nkolev92 wait for Kathleen? She will be back next week

Do we have an agreement on the link? @anangaur @mairaw @KathleenDollard  If not could we have a meeting to decide it? also @nkolev92 , there is no technical issue blocking this PR right?

@wli3
Nope. Just waiting on a consensus message and link.

@KathleenDollard do we have anything in the form of spec or design notes for global tools somewhere? I could create a fwlink that would point to a temporary location for this until the official docs are not published.
I'm super busy this week working on a different release so I can't drop everything to go work on this instead.

Having a fwlink is probably a great idea regardless.
We shouldn't need a change on the server if a docs reorg happens.

@mairaw Since this link will be to the docs, can you create a fwlink that makes sense. I will be working on content for this.
Maira and I met on this. This link will be to using tools, what they are any what the user should consider. That article will probably have a link to creating them.

I suggest:
This package contains a .NET Core Global Tool you can call from the shell/command line.
I think this should clearly state that this isn't a Visual Studio tool, and supply the link in a consistent manner.
@miraw, can you set up the fwlink or aka link?

I think that message is great.
I'll update the PR as soon as I have the fwlink.

fwlink: https://aka.ms/global-tools

@joelverhagen @skofman1
Updated the messaging and link.
Happy to test this out on dev whenever.

@nkolev92 , looks good! feel free to merge!


Data set rerieval related fixes

Tests included.
@romartin Can you review & merge please?

Merged:
035060fbd3882742ec39bc679d360ae0ffc94886
a274559619283417b743a689026e251f952b6e34
c1a81f9f29a2a0d50ee6d5829edc3e1ee9ca8f71
b7d94f192917cd729520e5ba670b877f80f3d733


what reuseExistingChunk: true means, can give a sample?

Do you want to request a feature or report a bug?
document not clear

What is the current behavior?
what optimization.splitChunks reuseExistingChunk: true means, can give a sample?
If the current behavior is a bug, please provide the steps to reproduce.

If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.

@PlayMa256  that's no clear, can give a sample?

@webpack-bot move to webpack/webpack.js.org


Due to the circular dependency, the wire cannot be generated, but the corresponding variable cannot be found when the error is reported.

Describe the bug
If I am in the following apps directory structure
in app1 package, app.go
package app1

import (
   "awesomeProject/wire_test/app"
   "fmt"
)

type A struct {
   C *app.C
}

func (a *A) Add(b app.B) {
   fmt.Println(b)
}

in wire package , wire.go
//go:build wireinject
// +build wireinject

package wire

import (
	"awesomeProject/wire_test/app"
	"awesomeProject/wire_test/app/app1"

	"github.com/google/wire"
)

func Inject() *app.B {
	wire.Build(
		wire.Struct(new(app1.A), "*"),
		wire.Struct(new(app.B), "*"),
		wire.Struct(new(app.C), "*"),
	)
	return nil
}

in intance.go
package app

import "awesomeProject/wire_test/app/app1"

type B struct {
	A app1.A
}

type C struct {
}

As a result, the following error was reported. In fact, it should be a circular reference that caused the wire to fail to be generated
wire: /Users/genyuanguo/Desktop/awesomeProject/wire_test/app/wire/wire.go:13:1: inject Inject: no provider found for *invalid type
        needed by awesomeProject/wire_test/app/app1.A in struct provider "A" (/Users/genyuanguo/Desktop/awesomeProject/wire_test/app/app1/app.go:8:6)
        needed by *awesomeProject/wire_test/app.B in struct provider "B" (/Users/genyuanguo/Desktop/awesomeProject/wire_test/app/intance.go:5:6)
wire: awesomeProject/wire_test/app/wire: generate failed
wire: at least one generate failure

To Reproduce
.
└── app
|── app1
│   └── app.go
|── intance.go
└── wire
|── wire.go
└── wire_gen.go
If you use the wire directory structure like this
Expected behavior
Should report an error app1 and app circular reference.
Version
github.com/google/wire v0.5.0
Additional context
Add any other context about the problem here.

I think I have a similar issue. I'm seeing wire flip flopping between success and failure - and giving a cryptic error message:
$ wire ./apps/agent
wire: apps/agent: wrote <...>/apps/agent/wire_gen.go
$ wire ./apps/agent
wire: <...>/apps/agent/t_serverbuild.go:36:26: cannot use a.Context() (value of type *engine.Context) as *invalid type value in argument to a.WebsocketWrite

I narrowed it down to a circular dependency that didn't actually occur when compiling the project the regular way.


Aromatic N in non-aromatic ring can have bad valence

Discussed in https://github.com/rdkit/rdkit/discussions/5443

Originally posted by hogru July 22, 2022
I am not a heavy user of rdkit so it might well be that this is a based on wrong assumptions: I generate molecules and try to assess whether a molecule is valid. If it is, I canonicalize it. The issue is, that the generated molecules are checked/validated again later in the pipeline and some of those molecules seem not to be valid (can not be canonicalized)
This is a (simplified) example source code for illustration.
from rdkit import Chem

smiles = "[O-]c1ccc(C[C@H]2NC(c3ccc(Cl)cc3)=n2c2nc(-c3ccco3)cs2)cc1"
print(f"The original SMILES: {smiles}")

print("Check if this is a valid SMILES...", end="")
mol = Chem.MolFromSmiles(smiles)

if mol is None:
    print("Invalid SMILES, stop here")
else:
    print("It IS valid, canonicalize...")
    canon_smiles = Chem.CanonSmiles(smiles)
    print(f"\nCanonicalized SMILES: {canon_smiles}")  # the first n became an N

    print("\nNow, canonicalize the canonicalized SMILES again...")
    print("Expectation: works, no change in canonical SMILES; in reality: raises ArgumentError exception")
    canon_smiles = Chem.CanonSmiles(canon_smiles)  # throws an exception (could handle it, but why?)
    print(f"\nCanonicalized SMILES: {canon_smiles}")

The input molecule has a four-coordinate neutral N. The RDKit should generate a valence error when sanitizing it, but it's being confused by the aromatic N in the input.

Thank you for the quick action!!

@ptosco this one has me a bit stumped
I can come up with a way of fixing it which introduces another point in the sanitization code where an exception can be thrown - in the adjustHs() call - but that's a pretty significant change in behavior to fix something which is really just very edge-casey bad input.
I could well be missing something obvious: any thoughts on a straightforward solution?

This is another example I believe. I apologize if this is of the same "type" as your much shorter example above and does not add any value; I actually can't interpret the molecule properties from the string (not a chemist):
C#CCN1/C(=N\C(=O)c2cccn2-c2ccccc2)=c2ccccc2=[NH+][C@@H]1C

@greglandrum I'm surprised this can be kekulized and keep the "aromatic" nitrogen.


bug: Add all missing imports no longer works as expected

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.1
Operating system/version
MacOS 14.5
Describe the bug
When I use cM to add all missing import, I am presented with a dialog that has the same option twice:

Same with remove all unused code. When I use cu I get this message:

(also note cu is listed as "Remove unused imports" but the dialog says "Remove all unused code")

Steps To Reproduce

remove an import
try using cM to auto add the missing import
observe the dialog with repeated options

Expected Behavior
cM should auto import immediately, not show a dialog with the same option twice.
Repro
local lazypath = vim.fn.stdpath("data") .. "/lazy/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  -- bootstrap lazy.nvim
  -- stylua: ignore
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", "--branch=stable", lazypath })
end
vim.opt.rtp:prepend(vim.env.LAZY or lazypath)

require("lazy").setup({
  spec = {
    -- add LazyVim and import its plugins
    { "LazyVim/LazyVim", import = "lazyvim.plugins" },
    -- import any extras modules here
    -- { import = "lazyvim.plugins.extras.lang.typescript" },
    -- { import = "lazyvim.plugins.extras.lang.json" },
    -- { import = "lazyvim.plugins.extras.ui.mini-animate" },
    -- import/override with your plugins
    { import = "plugins" },
  },
  defaults = {
    -- By default, only LazyVim plugins will be lazy-loaded. Your custom plugins will load during startup.
    -- If you know what you're doing, you can set this to `true` to have all your custom plugins lazy-loaded by default.
    lazy = false,
    -- It's recommended to leave version=false for now, since a lot the plugin that support versioning,
    -- have outdated releases, which may break your Neovim install.
    version = false, -- always use the latest git commit
    -- version = "*", -- try installing the latest stable version for plugins that support semver
  },
  install = {
    -- try to load one of these colorschemes when starting an installation during startup
    colorscheme = { "tokyonight" },
  },
  checker = { enabled = true }, -- automatically check for plugin updates
  performance = {
    rtp = {
      -- disable some rtp plugins
      disabled_plugins = {
        "gzip",
        -- "matchit",
        -- "matchparen",
        -- "netrwPlugin",
        "tarPlugin",
        "tohtml",
        "tutor",
        "zipPlugin",
      },
    },
  },
})

That comes from the LSP server itself. Do you have multiple LSP servers attached to the buffer?
I don't do Typescript myself so I just asked ChatGpt to generate an example with imports and this is how it looks like with the Typescript Extra enabled.
Screencast_2024-09-09-20-37-45.webm

Looks like I had two typescript clients attached:

ts_ls and vtsls
I uninstalled ts_ls using mason and now it's working.
I think the problem is that nvim-lspconfig renamed tsserver to ts_ls: https://github.com/neovim/nvim-lspconfig/pull/3232
And LazyVim is still trying to disabled the old name tsserver: http://www.lazyvim.org/extras/lang/typescript
LazyVim needs to be updated to disable ts_ls instead.

There's already #4406 about that.

Nice. What's preventing it from being merged in?

Wait for the maintainer to come back. See pinned issue.


Design QA - Login to place bet button

When a user adds a bet to the betslip and he is not logged in, we should show a "Login to place a bet" button:

https://www.figma.com/file/wogMuUDylgOHgTEYhZ3jgp/Augur-Bet-UI?node-id=7654%3A270124

Ok!


Current user check (not root)

Don't allow the CLI to be installed as root because it will cause problems down the line.

Maybe addresses https://github.com/Automattic/vip/issues/71 ?

I think we can solve this with documentation for now; doing it in code feels messy and likely to cause other problems.
@joshbetz can you log what the problems with installing using sudo / root are?

The two problems I've seen are:

From #71:

prebuild-install WARN install EACCES: permission denied, access '/Users/nickdaugherty/.npm'

It install successfully, but not in a directory in the current user's PATH, so vip doesn't work.

I've been pointing people to https://docs.npmjs.com/getting-started/fixing-npm-permissions

@simonwheatley are you able to help wrangle some docs for this? I'm happy to help with the language if necessary. I'm assuming we'll have a doc in the VIP documentation. Anywhere else though?

https://vip.wordpress.com/documentation/vip-go/vip-cli/

@joshbetz Yes, I can look at this.

Is there no way we can throw an error during installation? I am fairly concerned that people will just plough through quickly and not notice documentation 😐

Are there common issues we can spot when the code is running, or some kind of check we could build into vip -v?

It’s messy partially because root is a Unix thing, but we really need cross platform support. I think we can do it eventually, but ideally we can ship with just docs because I have a feeling this could get fairly involved.

Closing; covered by docs for now. We can revisit if it's a commonly reported problem.


Adds punctuation support

Fixes #4 and #7 kinda

Don't support every single ascii character, the transparency will be too noticeable. Stick to punctuation and maybe a few extra


Weird Glitch were minecarts stop or go in the ground

BkCommonLib version: 1.66 (latest)
TrainCarts version: latest
Spigot version: 1.8.9

Problem or bug:
Trains stop at random moments (mostly in turns) Or when going up a hill.

In the screenshot above: The cart just stops, or goes into the ground.

In the screenshot above you can see how the train just stops and splits into two different trains.
Happens most of the time when a player is in the cart.
Expected behaviour: Train should move normally on the rail.
Steps to reproduce: Happens at random. Most of the time at small turns or at small hills

Duplicate of #43

Exception I get:
6:59:41 PM [SEVERE] [Train_Carts] Failed to perform physics on train 'train1' at world_-703_24_1012:
6:59:41 PM [SEVERE] java.lang.NullPointerException

@mg-1999 Why did you close this?

It is the same as #43 in my point of view.


Library modification is easily forgotten, so there should be a warning.

A one-character modification to a 3rd party library file, WebResponseImpl.h, is documented in the manual, but users are likely to miss or forget this.  This mistake leads to web pages containing placeholders where useful content should be.
There should be a check at startup time with a strong pointer to how to fix this.

This is been addressed by making an unedited placeholder a fatal error.  An alternative would be a strong nonfatal warning and a message on all web pages.  I'll leave this open for a while in case there are comments.