All day events and event timings in ICS

Continuing from https://github.com/jyotisham/jyotisha/commit/49b9973e0e628df8234629f5061123b065799a6d#commitcomment-45562144 :
Currently, in http://jyotisham.github.io/jyotisha/output/sahakAra-nagar-bengaLUru/MULTI_NEW_MOON_SIDEREAL_MONTH_ADHIKA__CHITRA_AT_180/gregorian/2000s/2020s/2021.ics , even though the event has:
END:VALARM
END:VEVENT
BEGIN:VEVENT
SUMMARY:आखुरथ-महागणपति सङ्कटहर-च
 तुर्थी-व्रतम्
DTSTART;VALUE=DATE:20210102
DTEND;VALUE=DATE:20210103

it does not show up in a couple of calendar apps. IIUC from the context, @karthikraman concludes that this is due to the presence of DTSTART value (which does not have time). So, solution is either to add the time, or to remove DTSTART and DTEND altogether.
It seems that @karthikraman has currently implemented the latter. But why was http://jyotisham.github.io/jyotisha/output/sahakAra-nagar-bengaLUru/MULTI_NEW_MOON_SIDEREAL_MONTH_ADHIKA__CHITRA_AT_180/gregorian/2000s/2020s/2021.ics not automatically regenerated with https://github.com/jyotisham/jyotisha/runs/1633528655?check_suite_focus=true ran??
How about using sunrise to sunrise time by default instead? (Though ideally we should look at timing field in the rule.)

What is the best practice for creating an all day event? Are the calendar apps buggy? I have no problem importing these into Google or Microsoft accounts...

What is the best practice for creating an all day event? Are the calendar apps buggy? I have no problem importing these into Google or Microsoft accounts...

What is the best practice for creating an all day event?

Greater and clearer info certainly helps, and I've observed that setting time in all-day events works well (see screenshots in thread linked earlier). We ought to set the all-day event to start with either sunrise time or aruNodaya time or midnight or moonrise as appropriate (currently working on beginning to do that).

Are the calendar apps buggy? I have no problem importing these into Google or Microsoft accounts...

I cannot import  http://jyotisham.github.io/jyotisha/output/sahakAra-nagar-bengaLUru/MULTI_NEW_MOON_SIDEREAL_MONTH_ADHIKA__CHITRA_AT_180/gregorian/2000s/2020s/2021.ics to Google Calendar fruitfully. So, I'd concluded that Google Cal is buggy!

What is the best practice for creating an all day event?

Greater and clearer info certainly helps, and I've observed that setting time in all-day events works well (see screenshots in thread linked earlier). We ought to set the all-day event to start with either sunrise time or aruNodaya time or midnight or moonrise as appropriate (currently working on beginning to do that).

Are the calendar apps buggy? I have no problem importing these into Google or Microsoft accounts...

I cannot import  http://jyotisham.github.io/jyotisha/output/sahakAra-nagar-bengaLUru/MULTI_NEW_MOON_SIDEREAL_MONTH_ADHIKA__CHITRA_AT_180/gregorian/2000s/2020s/2021.ics to Google Calendar fruitfully. So, I'd concluded that Google Cal is buggy!

The reason to remove time was to truly mark the event as all-day, rather than a 24-hour event.

Here, you see that the event starts at 00:00 hours, which is OK, but weird. Putting intervals to the various festivals will end up greatly cluttering the calendar. It's just nice to have them all in the top. Hope this will be implemented as an option for the ICS, if at all... thanks!
I used to have DTSTART without time in the previous versions, and had no issues importing them into Google calendar.

The reason to remove time was to truly mark the event as all-day, rather than a 24-hour event.

Here, you see that the event starts at 00:00 hours, which is OK, but weird. Putting intervals to the various festivals will end up greatly cluttering the calendar. It's just nice to have them all in the top. Hope this will be implemented as an option for the ICS, if at all... thanks!
I used to have DTSTART without time in the previous versions, and had no issues importing them into Google calendar.

The reason to remove time was to truly mark the event as all-day, rather than a 24-hour event.

This is some MS calendar app? The 0-s should be gone and replaced by sunrise times, mostly, I think - which is sensible. Check it out.

Putting intervals to the various festivals will end up greatly cluttering the calendar.

As in there will be long event rectangles squatting on the day in the calendar app? If so, I'm hoping not, thanks to https://github.com/jyotisham/jyotisha/blob/c669f5b260d6f4626084079d3966cf4104a209c3/jyotisha/panchaanga/writer/ics/festival_event.py#L122 .

It's just nice to have them all in the top.

Agreed - especially for events spanning most of the day rather than a small slice (like chandradarshanam or pradoShavrata). Is this not the case some how?

I used to have DTSTART without time in the previous versions, and had no issues importing them into Google calendar.

Hmm. Thanks for the info. I'm guessing it's something to do with day-summary events (I recall that removing those made importing work, back when I was fixing ics generation).

The reason to remove time was to truly mark the event as all-day, rather than a 24-hour event.

This is some MS calendar app? The 0-s should be gone and replaced by sunrise times, mostly, I think - which is sensible. Check it out.

Putting intervals to the various festivals will end up greatly cluttering the calendar.

As in there will be long event rectangles squatting on the day in the calendar app? If so, I'm hoping not, thanks to https://github.com/jyotisham/jyotisha/blob/c669f5b260d6f4626084079d3966cf4104a209c3/jyotisha/panchaanga/writer/ics/festival_event.py#L122 .

It's just nice to have them all in the top.

Agreed - especially for events spanning most of the day rather than a small slice (like chandradarshanam or pradoShavrata). Is this not the case some how?

I used to have DTSTART without time in the previous versions, and had no issues importing them into Google calendar.

Hmm. Thanks for the info. I'm guessing it's something to do with day-summary events (I recall that removing those made importing work, back when I was fixing ics generation).

FWIW, I'm now seeing useful star-times for fests in Evolution calendar app (I needed to force "refresh", it seems).

FWIW, I'm now seeing useful star-times for fests in Evolution calendar app (I needed to force "refresh", it seems).

This is cluttering up the TeX greatly. Not sure how to fix, because there are other puNyakAla events that span 24 hours (I was originally thinking of checking length and ignoring the interval if > 0.75 like you had used)...

This is totally amazing for chandra darshanam etc. though!

This is cluttering up the TeX greatly. Not sure how to fix, because there are other puNyakAla events that span 24 hours (I was originally thinking of checking length and ignoring the interval if > 0.75 like you had used)...

This is totally amazing for chandra darshanam etc. though!

Could it be captured by a flag, instead of explicitly setting the interval as sunrise to sunrise?

Could it be captured by a flag, instead of explicitly setting the interval as sunrise to sunrise?

This is cluttering up the TeX greatly. Not sure how to fix, because there are other puNyakAla events that span 24 hours (I was originally thinking of checking length and ignoring the interval if > 0.75 like you had used)...

I'd anticipated this :-) Perhaps, we could reuse the method proposed in https://github.com/jyotisham/jyotisha/commit/c669f5b260d6f4626084079d3966cf4104a209c3#commitcomment-45577035 in both places?

This is cluttering up the TeX greatly. Not sure how to fix, because there are other puNyakAla events that span 24 hours (I was originally thinking of checking length and ignoring the interval if > 0.75 like you had used)...

I'd anticipated this :-) Perhaps, we could reuse the method proposed in https://github.com/jyotisham/jyotisha/commit/c669f5b260d6f4626084079d3966cf4104a209c3#commitcomment-45577035 in both places?

Perhaps, there should be a way to disable this as an option... The all-day events are way nicer...

Oh - I see that your calendar client behaves differently (I don't get those ugly long rectangles here). Then, we should have an option in the ics generation function (the core calendar generation should continue to assign intervals). This option would switch off DTSTART for all_day events.

Perhaps, there should be a way to disable this as an option... The all-day events are way nicer...

Oh - I see that your calendar client behaves differently (I don't get those ugly long rectangles here). Then, we should have an option in the ics generation function (the core calendar generation should continue to assign intervals). This option would switch off DTSTART for all_day events.

This is Google calendar :) Calendar client behaves ok... Instead of the "0" it shows a "6".

This is Google calendar :) Calendar client behaves ok... Instead of the "0" it shows a "6".

Chandra darshanam timings are sometimes off..

It should be calculated from sunset until moonset on the day assigned...

Chandra darshanam timings are sometimes off..

It should be calculated from sunset until moonset on the day assigned...

This example was on 2020-10-18

This example was on 2020-10-18

Chandra darshanam timings are sometimes off..

It should be calculated from sunset until moonset on the day assigned...

सूचनयोपकृतोऽहम्। प्रायेण समीकृतम् अधुना।

Chandra darshanam timings are sometimes off..

It should be calculated from sunset until moonset on the day assigned...

सूचनयोपकृतोऽहम्। प्रायेण समीकृतम् अधुना।

The fix forecloses the option of having times in all-day events (which I liked). But since that preference is not (yet) that strong, I acquiesce. (I was hoping that you would add an option as I'd suggested in one of the commit threads https://github.com/jyotisham/jyotisha/commit/c669f5b260d6f4626084079d3966cf4104a209c3#r45577843 .)

The fix forecloses the option of having times in all-day events (which I liked). But since that preference is not (yet) that strong, I acquiesce. (I was hoping that you would add an option as I'd suggested in one of the commit threads https://github.com/jyotisham/jyotisha/commit/c669f5b260d6f4626084079d3966cf4104a209c3#r45577843 .)


docs: fix typo on the Pipelines page

It's a minor fix, but I corrected the typo on the Pipelines page.

Ups 🙃 Thank you!


Benchmark for tools in repository

Related to issue #62 ?

Thai text classification benchmarks https://github.com/PyThaiNLP/classification-benchmarks by @cstorm125

A little bit too vague. Will create separate issues for each type of benchmark.

For benchmark on word segmentation, see https://github.com/heytitle/thai-word-tokenisation-benchmark/


Theme selectors: reorganize Layouts / Compositions

Themes can be filtered by Layout / Composition, which is nice.
But some categories are overlapping ("Website" / "Multipage"), others are empty ("Personal website") or missing an icon

Inspiration:

https://themes.gohugo.io

https://gethugothemes.com (see "All Themes" menu)

https://jekyll-themes.com :
Portfolio themes
Blog themes
Landing page themes
Documentation themes

https://jekyll-themes.com/categories/

A first proposal:

Landing page
Blog
Documentation
Ecommerce
Portfolio
Resume
Gallery
(not sure about this last one though)

Let's give up Single page app as a Landing page can come with a Blog section for example


Let me clean up manually without the need to delete the dom

Yes we also realy need that on our project!

Please, this is a must-have!

Good news, this feature is now available from v2.1.0 and v1.2.0 releases!


[BUG] Harvester single node upgrade will get another operation (install/upgrade/rollback) is in progress error

Describe the bug
Harvester single node upgrade will encounter another operation (install/upgrade/rollback) is in progress error after node reboot. Therefore, it will block the next Harvester upgrade or managedChart update. Potentially related to https://github.com/helm/helm/issues/8987#issuecomment-786149813
To Reproduce
Steps to reproduce the behavior:

Install a Harvester cluster with an old version, e.g., v1.1.1
upgrade the Harvester cluster to a newer version, e.g., v1.1.2-head.iso
after the upgrade is complete, the upgrade status shows success, then check the harvester managedChart status and it will contain an error of:

conditions:
  - lastUpdateTime: "2023-03-08T05:42:32Z"
    message: 'ErrApplied(1) [Cluster fleet-local/local: another operation (install/upgrade/rollback)
      is in progress]; daemonset.apps harvester-system/kube-vip [progressing] Available:
      0/1; kubevirt.kubevirt.io harvester-system/kubevirt [progressing] Deployin

Expected behavior
single node upgrade should not contain the above error.
Support bundle

Environment

Harvester ISO version: v1.1.1 upgrade
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630):

Additional context
Workaround can be referred to https://github.com/helm/helm/issues/8987#issuecomment-786149813; however, ensure the rollback version is correct.

@w13915984028 I guess this is not completely addressed or perhaps a new regression.

@bk201 looks so, this issue still happens, I will look into fleet-agent's new code when free.
@guangbochen do you have a support-bundle file ?

reproduced in a single-node upgrade:
from the helm release history, the harvester chart is upgraded several times inbetween upgrade, the last 3 times are in almost same time, will continue check why this happens.
harv31:~ # kk get bundle -A
NAMESPACE     NAME                                          BUNDLEDEPLOYMENTS-READY   STATUS
fleet-local   fleet-agent-local                             1/1
fleet-local   local-managed-system-agent                    1/1
fleet-local   mcc-harvester                                 0/1                       ErrApplied(1) [Cluster fleet-local/local: another operation (install/upgrade/rollback) is in progress]; daemonset.apps longhorn-system/longhorn-manager [progressing] Available: 0/1; deployment.apps longhorn-system/longhorn-admission-webhook [progressing] Deployment does not have minimum availability., Available: 1/2; deployment.apps longhorn-system/longhorn-driver-deployer [progressing] Deployment does not have minimum availability., Available: 0/1; deployment.apps longhorn-system/longhorn-ui [progressing] Deployment does not have minimum availability., Available: 0/1

harvester-system                         sh.helm.release.v1.harvester.v1                                     helm.sh/release.v1                            1      82m
harvester-system                         sh.helm.release.v1.harvester.v2                                     helm.sh/release.v1                            1      79m

harvester-system                         sh.helm.release.v1.harvester.v3                                     helm.sh/release.v1                            1      18m
harvester-system                         sh.helm.release.v1.harvester.v4                                     helm.sh/release.v1                            1      18m
harvester-system                         sh.helm.release.v1.harvester.v5                                     helm.sh/release.v1                            1      16m

harv31:~ # uptime
 22:04:11  up   0:08,  1 user,  load average: 1.18, 2.30, 1.39

I just ran into this issue.

Did more tests, there are 2 possibilites:
(1) when fleet-agent is busy upgrading those managedcharts, the POD is replaced by the upgrading procssing of Rancher, which causes the fleet-agent cannot update the status of release
(2) the kube-apiserver process is killed and recreated by RKE2 before system rebooting, which may cause fleet-agent update release status fail
continue...

add some debug in upgrade_node.sh, the root cause looks to be:
the fleet-agent is busing upgrading all bundles, even when wait_rke2_upgrade is met. the upgrade_os will cause the fleet-agent POD restart once, the ongoing upgrading does not finish ontime, and when fleet-agent runs again, it finds the previous upgrading is there and complains.
Solution: before upgrade_os, wait fleet-agent does all its job on bundle.
will validate next day.
  # Upgarde RKE2
  upgrade_rke2
    wait_rke2_upgrade
  clean_rke2_archives
  convert_nodenetwork_to_vlanconfig
  ..........--------------------------> check all bundle,
    # Upgrade OS
  upgrade_os

....
+ echo 'check bundle 24'
+ kubectl get bundle -A
NODE_CURRENT_HARVESTER_VERSION is: v1.1.1
The UPGRADE_PREVIOUS_VERSION is v1.1.1, NODE_CURRENT_HARVESTER_VERSION is v1.1.1, will check nodenetwork upgrade node option
There is nothing to do in nodenetwork
check bundle 24
NAMESPACE     NAME                                          BUNDLEDEPLOYMENTS-READY   STATUS
fleet-local   fleet-agent-local                             0/1                       NotReady(1) [Cluster fleet-local/local]; deployment.apps cattle-fleet-local-system/fleet-agent [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   local-managed-system-agent                    1/1
fleet-local   mcc-harvester                                 0/1                       WaitApplied(1) [Cluster fleet-local/local]
fleet-local   mcc-harvester-crd                             1/1
fleet-local   mcc-local-managed-system-upgrade-controller   0/1                       NotReady(1) [Cluster fleet-local/local]; deployment.apps cattle-system/system-upgrade-controller [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   mcc-rancher-logging                           0/1                       NotReady(1) [Cluster fleet-local/local]; daemonset.apps cattle-logging-system/rancher-logging-rke2-journald-aggregator [progressing] Available: 0/1; deployment.apps cattle-logging-system/rancher-logging [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   mcc-rancher-logging-crd                       1/1
fleet-local   mcc-rancher-monitoring                        0/1                       WaitApplied(1) [Cluster fleet-local/local]
fleet-local   mcc-rancher-monitoring-crd                    0/1                       WaitApplied(1) [Cluster fleet-local/local]
+ kubectl get pods -n cattle-fleet-local-system -o wide
NAME                           READY   STATUS    RESTARTS   AGE    IP            NODE     NOMINATED NODE   READINESS GATES
fleet-agent-6ffcdc7f94-45sfm   1/1     Running   0          6m4s   <IP_ADDRESS>   harv31   <none>           <none>

.....
+ echo 'check bundle 25'
+ kubectl get bundle -A
check bundle 25
NAMESPACE     NAME                                          BUNDLEDEPLOYMENTS-READY   STATUS
fleet-local   fleet-agent-local                             1/1
fleet-local   local-managed-system-agent                    1/1
fleet-local   mcc-harvester                                 0/1                       ErrApplied(1) [Cluster fleet-local/local: another operation (install/upgrade/rollback) is in progress]
fleet-local   mcc-harvester-crd                             1/1
fleet-local   mcc-local-managed-system-upgrade-controller   1/1
fleet-local   mcc-rancher-logging                           0/1                       NotReady(1) [Cluster fleet-local/local]; deployment.apps cattle-logging-system/rancher-logging [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   mcc-rancher-logging-crd                       1/1
fleet-local   mcc-rancher-monitoring                        0/1                       ErrApplied(1) [Cluster fleet-local/local: another operation (install/upgrade/rollback) is in progress]
fleet-local   mcc-rancher-monitoring-crd                    0/1                       ErrApplied(1) [Cluster fleet-local/local: another operation (install/upgrade/rollback) is in progress]
+ kubectl get pods -n cattle-fleet-local-system -o wide
NAME                           READY   STATUS    RESTARTS      AGE     IP            NODE     NOMINATED NODE   READINESS GATES
fleet-agent-6ffcdc7f94-45sfm   1/1     Running   1 (77s ago)   7m16s   <IP_ADDRESS>   harv31   <none>           <none>

(2) the kube-apiserver process is killed and recreated by RKE2 before system rebooting, which may cause fleet-agent update release status fail

My investigation also shows this might be the cause.  One idea is to scale fleet-agent deployment to 0 replicas before upgrading RKE2 and bring it back once the RKE2 is upgraded...

Attempt to fix by scaling fleet agent replicas to 0 before upgrading RKE2 and scale it back to 1 later: https://github.com/harvester/harvester/pull/3641

A new test to wait for bundle:
before upgrade_os, fleet-agent took 120+s to settle all bundle down,  the upgrade-os will restart the POD, if we do not wait bundle to be ready, fleet-agent will hit he issue when upgrading bundles but POD is rebooted
I will commit another patch to solve this issue.
  wait_for_fleet_bundles

  # Upgrade OS
  upgrade_os

wait_for_fleet_bundles
..
Mon Mar 13 11:57:06 UTC 2023
...

NAMESPACE     NAME                                          BUNDLEDEPLOYMENTS-READY   STATUS
fleet-local   fleet-agent-local                             0/1                       NotReady(1) [Cluster fleet-local/local]; deployment.apps cattle-fleet-local-system/fleet-agent [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   local-managed-system-agent                    1/1
fleet-local   mcc-harvester                                 0/1                       NotReady(1) [Cluster fleet-local/local]; daemonset.apps harvester-system/harvester-network-controller [progressing] Available: 0/1; daemonset.apps harvester-system/harvester-node-manager [progressing] Available: 0/1; daemonset.apps harvester-system/kube-vip [progressing] Available: 0/1; deployment.apps harvester-system/harvester-load-balancer [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   mcc-harvester-crd                             1/1
fleet-local   mcc-local-managed-system-upgrade-controller   0/1                       NotReady(1) [Cluster fleet-local/local]; deployment.apps cattle-system/system-upgrade-controller [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   mcc-rancher-logging                           0/1                       NotReady(1) [Cluster fleet-local/local]; daemonset.apps cattle-logging-system/rancher-logging-rke2-journald-aggregator [progressing] Available: 0/1; deployment.apps cattle-logging-system/rancher-logging [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   mcc-rancher-logging-crd                       1/1
fleet-local   mcc-rancher-monitoring                        0/1                       NotReady(1) [Cluster fleet-local/local]; apiservice.apiregistration.k8s.io v1beta1.custom.metrics.k8s.io [progressing] endpoints for service/rancher-monitoring-prometheus-adapter in "cattle-monitoring-system" have no addresses with port name "", Resource is current; daemonset.apps cattle-monitoring-system/rancher-monitoring-prometheus-node-exporter [progressing] Available: 0/1; deployment.apps cattle-monitoring-system/rancher-monitoring-kube-state-metrics [progressing] Deployment does not have minimum availability., Available: 0/1; deployment.apps cattle-monitoring-system/rancher-monitoring-operator [progressing] Deployment does not have minimum availability., Available: 0/1
fleet-local   mcc-rancher-monitoring-crd                    1/1

....
Mon Mar 13 11:59:20 UTC 2023
++ kubectl get bundle.fleet.cattle.io -A -o 'jsonpath={.items[*].status.conditions[?(@.type=="Ready")].status}'

bsr='True True True True True True True True True'

upgrade OS:
Flag --directory has been deprecated, 'directory' is deprecated please use 'system' instead
INFO[2023-03-13T11:59:25Z] Starting elemental version v0.1.1
WARN[2023-03-13T11:59:25Z] failed reading installation state: open /run/initramfs/cos-state/state.yaml: no such file or directory
INFO[2023-03-13T11:59:26Z] Upgrade called
...
+ GRUBENV_FILE=/oem/grubenv
+ chroot /host /bin/bash -c 'if ! [ -f /oem/grubenv ]; then grub2-editenv /oem/grubenv create; fi'
+ umount /host/usr/bin/elemental
...
+ kubectl get pods -n cattle-fleet-local-system -o wide
NAME                           READY   STATUS    RESTARTS        AGE     IP          NODE     NOMINATED NODE   READINESS GATES
fleet-agent-6ffcdc7f94-g9fkm   1/1     Running   1 (2m42s ago)   8m22s   <IP_ADDRESS>   harv31   <none>           <none>
sleep 60

Update rancher side issue: https://github.com/rancher/fleet/issues/637#issuecomment-1469446802
We're using a workaround here only.

@bk201 should the Conditions contain an error, as I'm not able to see one listed? in the describe on the managed charts of:

harvester
harvester-crd
In the fleet-local namespace:

Spec:
  Chart:              harvester
  Default Namespace:  harvester-system
  Diff:
    Compare Patches:
      API Version:  apiextensions.k8s.io/v1
      Json Pointers:
        /status/acceptedNames
        /status/conditions
        /status/storedVersions
      Kind:         CustomResourceDefinition
      Name:         engineimages.longhorn.io
      API Version:  apiextensions.k8s.io/v1
      Json Pointers:
        /status/acceptedNames
        /status/conditions
        /status/storedVersions
      Kind:         CustomResourceDefinition
      Name:         nodes.longhorn.io
      API Version:  apiextensions.k8s.io/v1
      Json Pointers:
        /status/acceptedNames
        /status/conditions
        /status/storedVersions
      Kind:      CustomResourceDefinition
      Name:      volumes.longhorn.io
  Paused:        false
  Release Name:  harvester
  Repo Name:     harvester-charts
  Targets:
    Cluster Name:  local
    Cluster Selector:
      Match Expressions:
        Key:       provisioning.cattle.io/unmanaged-system-agent
        Operator:  DoesNotExist
  Values:
    Containers:
      Apiserver:
        Hci Mode:  true
        Image:
          Image Pull Policy:  IfNotPresent
    Harvester - Load - Balancer:
      Enabled:  true
    Harvester - Network - Controller:
      Enabled:  true
      Image:
        Pull Policy:  IfNotPresent
      Vip Enabled:    true
    Harvester - Node - Disk - Manager:
      Enabled:  true
      Image:
        Pull Policy:  IfNotPresent
      Label Filter:
        COS_*
        HARV_*
    Kube - Vip:
      Enabled:  true
    Kube - Vip - Cloud - Provider:
      Enabled:  true
    Kubevirt:
      Spec:
        Monitor Account:    rancher-monitoring-operator
        Monitor Namespace:  cattle-monitoring-system
    Longhorn:
      Default Settings:
        Default Data Path:  /var/lib/harvester/defaultdisk
        Taint Toleration:   kubevirt.io/drain:NoSchedule
      Enabled:              true
    Multus:
      Enabled:         false
    Rancher Embedded:  true
    Service:
      Vip:
        Enabled:     true
        Hw Address:  5a:d7:d0:48:7b:39
        Ip:          <IP_ADDRESS>
        Mode:        dhcp
    Webhook:
      Image:
        Image Pull Policy:  IfNotPresent
  Version:                  0.0.0-v1-1-e257df76
Status:
  Conditions:
    Last Update Time:  2023-03-22T19:51:31Z
    Status:            True
    Type:              Ready
    Last Update Time:  2023-03-22T19:51:31Z
    Status:            True
    Type:              Processed
    Last Update Time:  2023-03-22T19:55:45Z
    Status:            True
    Type:              Defined

and
Spec:
  Chart:              harvester-crd
  Default Namespace:  harvester-system
  Paused:             false
  Release Name:       harvester-crd
  Repo Name:          harvester-charts
  Take Ownership:     true
  Targets:
    Cluster Name:  local
    Cluster Selector:
      Match Expressions:
        Key:       provisioning.cattle.io/unmanaged-system-agent
        Operator:  DoesNotExist
  Values:
  Version:  0.0.0-v1-1-e257df76
Status:
  Conditions:
    Last Update Time:  2023-03-22T19:50:08Z
    Status:            True
    Type:              Ready
    Last Update Time:  2023-03-22T19:50:08Z
    Status:            True
    Type:              Processed
    Last Update Time:  2023-03-22T19:55:45Z
    Status:            True
    Type:              Defined

With upgrading a single-node v1.1 -> Harvester Version: v1.1-e257df76-head.
Rancher is still v2.6.11 as expected off of v1.1-head.

With upgrading a single-node v1.1 -> Harvester Version: v1.1-e257df76-head.
Rancher is still v2.6.11 as expected off of v1.1-head.

@irishgordo that's expected. Rancher has its own version and we upgrade from v2.6.9 to v2.6.11.

@bk201 if I wasn't encountering the issue - should I retest with rc4?

@irishgordo Yes. please help test with rc4. This should be quite easy to reproduce with rc3 (single node)...

@bk201  - on a v1.1.0 3 Node cluster airgapped, I'm noticing that after applying the fix for slow disks of:
harvester-node-0:~ # cat > /tmp/fix.yaml <<EOF
> spec:
>   values:
>     systemUpgradeJobActiveDeadlineSeconds: "3600"
> EOF

And:
harvester-node-0:~ # kubectl patch managedcharts.management.cattle.io local-managed-system-upgrade-controller --namespace fleet-local --patch-file=/tmp/fix.yaml --type merge

And:
harvester-node-0:~ # kubectl -n cattle-system rollout restart deploy/system-upgrade-controller

That this:
harvester-node-0:~ # kubectl get managedcharts -A
NAMESPACE     NAME                                      AGE
fleet-local   harvester                                 2d23h
fleet-local   harvester-crd                             2d23h
fleet-local   local-managed-system-upgrade-controller   2d23h
fleet-local   rancher-logging                           2d23h
fleet-local   rancher-logging-crd                       2d23h
fleet-local   rancher-monitoring                        2d23h
fleet-local   rancher-monitoring-crd                    2d23h
harvester-node-0:~ # kubectl get bundle -A
NAMESPACE     NAME                                          BUNDLEDEPLOYMENTS-READY   STATUS
fleet-local   fleet-agent-local                             0/1                       ErrApplied(1) [Cluster fleet-local/local: another operation (install/upgrade/rollback) is in progress]
fleet-local   local-managed-system-agent                    1/1
fleet-local   mcc-harvester                                 1/1
fleet-local   mcc-harvester-crd                             1/1
fleet-local   mcc-local-managed-system-upgrade-controller   1/1
fleet-local   mcc-rancher-logging                           1/1
fleet-local   mcc-rancher-logging-crd                       1/1
fleet-local   mcc-rancher-monitoring                        1/1
fleet-local   mcc-rancher-monitoring-crd                    1/1

Is Present.
Describing the bundle:
---
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: default-allow-all
  namespace: cattle-fleet-local-system
spec:
  egress:
  - {}
  ingress:
  - {}
  podSelector: {}
  policyTypes:
  - Ingress
  - Egress

    Name:  agent.yaml
  Targets:
    Cluster Name:  local
    Cluster Selector:
      Match Expressions:
        Key:       fleet.cattle.io/non-managed-agent
        Operator:  DoesNotExist
Status:
  Conditions:
    Last Update Time:  2023-03-24T21:10:18Z
    Message:           ErrApplied(1) [Cluster fleet-local/local: another operation (install/upgrade/rollback) is in progress]
    Status:            False
    Type:              Ready
    Last Update Time:  2023-03-24T21:10:19Z
    Status:            True
    Type:              Processed
  #####################################################################
  #####################################################################
  Summary:
    Desired Ready:  1
    Err Applied:    1
    Non Ready Resources:
      Bundle State:        ErrApplied
      Message:             another operation (install/upgrade/rollback) is in progress
      Name:                fleet-local/local
    Ready:                 0
  Unavailable:             1
  Unavailable Partitions:  0

Should the adjustments for slow-disk be reverted and then re-applied?

retesting with rc4 currently :smile:

validation failed
@bk201 w/ rc4 - upgrading from v1.1.1 -> v1.1.2-rc4 - I'm still encountering that issue:
fleet-local   fleet-agent-local                             0/1                       ErrApplied(1) [Cluster fleet-local/local: another operation (install/upgrade/rollback) is in progress]

supportbundle_b6d05b91-0872-4eeb-bc61-30d134a1e853_2023-03-29T00-48-31Z.zip
(qemu/kvm testing)

moved back to implement but feel free to change :smile:

@irishgordo https://github.com/harvester/harvester/pull/3643 reduce the chance of seeing the issue for Harvester-managed charts. fleet-agent-local chart is still out of our control. We should have a document to advise rollbacking the chart if this happens. cc @w13915984028

@bk201 - oh okay, thank you for sharing 3643, in that case I'd feel comfortable closing this out, since the only issue I've seen is fleet-agent-local chart related in testing :smile:

Tested as well with rc5 not seeing anything concerning fleet-agent-local chart.

I will go ahead and close this out, pending that some documentation gets mentioned about the fleet-agent-local chart :smile: :+1:
cc: @bk201

We'll use the issue https://github.com/harvester/harvester/issues/3675 in 1.2.0 to track upstream issue https://github.com/rancher/fleet/issues/637


Custom postprocessor with python library

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

Is there a way to write a custom postprocessor without modifying the library itself?

If you are just using the command-line program, consider using --exec ... with a custom script. To add a custom post-processor, I think you'll need to modify files like youtube_dl/__init__.py.
If you want to add a custom post-processor in the context of your own program that uses the yt-dl API, it should be possible to make the necessary changes in a subclass. But I haven't tried that.

i tried making a custom postprocessor subclass but it breaks when it tries to find it in get_postprocessor because it is not imported in youtube_dl/postprocessor/__init__.py and when execution gets to that file the subclass is out of the globals() scope.
this is what i tried:
class MyPostProcessor(PostProcessor):
    def __init__(self, downloader, new_file_format):
        super(MyPostProcessor, self).__init__(downloader)
        self.new_file_format = new_file_format
        print("test0")

    def run(self, information):
        new_file_format = self.new_file_format

        print("test1")

        return [], information

ydl_opts = {
    'format': 'bestaudio/best',
    'logger': MyLogger(),
    'postprocessors': [{
        'key': 'MetadataFromTitle',
        'titleformat': "%(series)s - %(title)s // S%(season)s: Episode %(episode)s",
    }, {
        'key': 'MyPostProcessor',
        'new_file_format': "%(series)s - S0%(season)sE0%(episode)s - %(title)s.%(ext)s",
    }],
    'verbose': True,
    'outtmpl': '%(title)s.%(ext)s'
    # 'dump_single_json': True,
    # 'forcejson': True,
    # 'simulate': True,
}

im wondering if there could be a way to pass it the object directly similar to how the logger does it. if the project is open to a PR to add that functionality i would be happy to look into it

so i had a quick look and it was fairly easy to work out. it adds a new class option to the postprocessors dict that gets passed to ydl and if that is present it will use that class instead of using get_postprocessor to get the class.
i added some logic to the postprocessor adding for loop in YoutubeDL.py:
        for pp_def_raw in self.params.get('postprocessors', []):
            if pp_def_raw.get('class'):
                pp_class = pp_def_raw['class']
                if not issubclass(pp_class, PostProcessor):
                    self.report_error('postprocessor %s is not subclass of PostProcessor'% pp_def_raw.get('class'))
                    continue
            elif pp_def_raw.get('key'):
                try:
                    pp_class = get_postprocessor(pp_def_raw['key'])
                except KeyError:
                    self.report_error('postprocessor %s not found'%pp_def_raw.get('key'))
                    continue
            else:
                self.report_error('postprocessor not found')
                continue

            pp_def = dict(pp_def_raw)
            pp_def.pop("key", None)
            pp_def.pop("class", None)

            pp = pp_class(self, **compat_kwargs(pp_def))
            self.add_post_processor(pp)

this checks if the class key is present and if it is it will use that class. it will also check if that class is a subclass of PostProcessor and throw an error if it isnt.
i also had to add this to the imports in YoutubeDL.py from .postprocessor.common import PostProcessor
example ydl_opts:
ydl_opts = {
    'postprocessors': [{
        'key': 'MetadataFromTitle',
        'titleformat': "%(series)s - %(title)s // S%(season)s: Episode %(episode)s",
    }, {
        'class': MyPostProcessor,
        'new_file_format': "%(series)s - S0%(season)sE0%(episode)s - %(title)s.%(ext)s",
    }],
}

let me know if you would be open to adding this and ill do all the PR things (run tests, update docs, etc) and open a PR. i dont think this can impact any existing code or CLI usages (with the possable exception of the error checking around get_postprocessor and that can be removed if its an issue)

What I'd suggest is to see if your problem is solved, or easier to solve, with the yt-dlp codebase, and perhaps propose any necessary improvements there. Then, a PR to back-port the resulting code, or a subset of it, or a PR that implements a subset of that functionality to yt-dl, would be helpful.
Rationale: avoid solving the same/related problem twice, or learning from an existing solution; avoid clashing changes to the CLI and API; considering that yt-dlp will generally port changes made here, avoid making that unduly complex or pointless.

so here is where i have to addmit something kind of stupid, up untill about an hour ago i thought i was working with yt-dlp. at some point during my initial attempts to get what i want working i clicked a link that i thought was to the yt-dlp repo but was actually to this one and i didnt notice. i have been working witht that tab as the root for my work since then without realising it was not yt-dlp.
and, as you thought might be the case, yt-dlp does infact solve my problem out of the box with no extra work requiered.
im guessing the reason it hasnt been backported to here is because the way they seem to be solving it is by letting postprocessers run as preprocessers so that the metadata changes they make are applied to the whole process. im assuming that implemenging that here would mean a significant redesigne and that is why it hasnt been done.
if any of the things i have worked on are still useful simply because they implement similar functionality without needing large changes i would be happy to do a PR but if not ill leave it here.
the main things i have done are add a rename from metadata postprocessor, add options to allow custom postprocessor when using the python api and allow MetadataFromTitle to handle numeric fields when given regex. let me know if any of these would be useful
thanks for your advice and help and sorry for the confusion.
ill close #32678 now since it dosnt make sense to have both open

If someone had cared enough, some relevant yt-dlp functionality would have been pulled. Now, the two areas of output formatting and post-processor scheduling have diverged sufficiently that pulling any specific subset of that functionality is not at all trivial.

yep, that makes sense. ill close this issue now


[PLUGIN, RR2] Plugin with workers pool w/o any external endpoints like HTTP/Temporal/etc

At the moment if a user needs to have some workers to handle some background tasks it forced to use HTTP plugin for that. But actually, user doesn't need the HTTP endpoint, only workers.
Such plugin should start, let's say, RAW PHP worker w/o any external transport like HTTP/TCP provided by the RR. Logging capabilities should be preserved and work like in the regular HTTP/Temporal plugins.

discussion: https://github.com/spiral/roadrunner/discussions/632

Discussed name with @wolfy-j : should be service. Like Linux/Windows daemons/services.

Config sample (draft):
service:
   something:
     command: php something.php
     instances: 4
     restart: true
     restart_delay: 10


add dash cooldown mechanic

Implements #892.

[ ] optimize off-field tick implementation.
[ ] decide whether to use statuses or cooldown queue to implement.

decide whether to use statuses or cooldown queue to implement.
Since it's most likely not affected by cooldown reduction, it should probably be a status.

FYI: Wanderer's Dash also has to be adjusted to account for this change, assuming he gets merged before this.


[SS 4.7.2 -> 4.7.3] HTTP 503 errors after upgrading symfony/cache from v3.4.47 to v4.4.31

Affected Version
From Silverstripe 4.7.3 to 4.9.0
silverstripe/googlesitemaps            dev-main 7326028 SilverStripe support for the Google Sitemaps XML, enabling Google and other search engines t...
silverstripe/recipe-cms                4.9.0            SilverStripe recipe for fully featured page and asset content editing
silverstripe/recipe-plugin             1.5.0            Helper plugin to install SilverStripe recipes
silverstripe/spamprotection            3.1.0            Spam protection module for SilverStripe.
tractorcow/silverstripe-fluent         5.0.0            Simple localisation for Silverstripe
undefinedoffset/silverstripe-nocaptcha 2.2.1            A spam protector and form field using Google's reCAPTCHA v2 or optionally a foundation v3 im...
undefinedoffset/sortablegridfield      2.0.9            Adds drag and drop functionality to SilverStripe 4.x's GridField

Description
After upgrading from 4.7.2 to 4.7.3, I noticed several 503 errors in the front and backend:

Service Unavailable
The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.

Since 4.7.3 contains no major code changes apart from the upgraded "symfony/cache"-module I tried downgrading by manually specifying composer require "symfony/cache" "^3.4", this worked as immediately no 503 errors where showing any more, when browsing through the website.
I tried upgrading Silverstripe to 4.9.0 using symfony/cache 3.4.47 and it worked all the way. After removing manual the "symfony/cache": "^3.4" requirement from the composer.json-file, composer update --no-dev upgraded symfony/cache to 4.4.31, again resulting in several 503 errors.
Curiously enough, 503 errors are only shown on pages that contain frontend-forms (e. g. Silverstripe-Backend, Siverstripe Login, frontend pages like the contact page containing a form).
Unfortunately I have no more information, as a php error.log or any other kind of debug output is not generated.
Steps to Reproduce

Upgrade Silverstripe from 4.7.2 to any newer version using composer and PHP 7.4.
Notice that symfony/cache gets upgraded from 3.4.47 to 4.4.31
Try to open /admin or any page containing a form.
See HTTP 503 errors.

Sorry, I forgot to mention this.
Yes, I tried clearing the cache multiple times. It does not help unfortunately.

Actually the webspace on that hoster is also my dev environment :cold_sweat:
I also made a quick search through core for 503 errors. Since no code in core from 4.7.2 to 4.7.3 changed it has to be within symfony/cache or how silverstripe uses that library (3.4 to 4.4 seems like a breaking version jump, but apparently it breaks only for me). I made this issue here since silverstripe has updated its dependencie to this version :/
I'll try to contact my hoster next and get back to this issue. Maybe they can see something in their logs.

The technician from my webhosting provider just got back to me: The have no further information for this problem in their logs.
Apart from littering the silverstripe with die(__FILE__.':'.__LINE__) statements to see how far the code runs on the hosting enviroment (which I already tried, but it's very hard for me to follow the flow to figure out what gets called next..) I am out of ideas how to approach this error.
Does Silverstripe have an facilities besides setting an SS_ERROR_LOG-file?


Fixed "Bad file descriptor" when running parallel builds

Thanks @velo for the pull request. It looks good to me, but can you resolve the merge conflict that now exists? I'd be happy to merge then.

@mattnworb done

@mattnworb any news on this?

cri cri

Closing old pull requests w/o activity

rebased on master here https://github.com/spotify/docker-maven-plugin/pull/383


Feature/saleor 1564 Add next.js to the Storefront

Add next.js to the Storefront

I want to merge this change because...

Screenshots

Pull Request Checklist

[ ] All visible strings are translated with proper context.
[ ] All data-formatting is locale-aware (dates, numbers, and so on).
[ ] The changes are tested.
[ ] The code is documented (docstrings, project documentation).
[ ] Changes are mentioned in the changelog.

Test Environment Config

API_URI=https://master.staging.saleor.rocks/graphql/

@piotrgrundas what's the state of this?  is this going to get merged to master soon?

@matiasmm that's the plan.
The second PR is waiting to be merged which will finish adding nextjs client only routing to the storefront. Should be merged in the upcoming days.

@matiasmm that's the plan.
The second PR is waiting to be merged which will finish adding nextjs client only routing to the storefront. Should be merged in the upcoming days.

@matiasmm that's the plan.
The second PR is waiting to be merged which will finish adding nextjs client only routing to the storefront. Should be merged in the upcoming days.

@matiasmm that's the plan.
The second PR is waiting to be merged which will finish adding nextjs client only routing to the storefront. Should be merged in the upcoming days.


remove preamble when converting with header=no

$ echo "some text" | asciidoctor-latex -b latex -d book -a header=no -

The result was:
\begin{preamble}
some text

\end{preamble}

It would be only the some text, without preamble, ins't it?

I did a little experiment with the file (*) below.  It runs
without error on my machine with both pdflatex
and xelatex.  On the other hand, both fail if I run
either on a file without the harder and footer — just the
“bare latex” part between %%%%%.
So in my setup, \tt and \texttt work or fail under
the same conditions. I think it is not a problem
of Asciidoctor-Latex, but rather of tex configuration.
Can you confirm this?
The reason for using xelatex is that it can deal with
unicode characters, not just ASCII.  That said
pdflatex should work if there are no such characters.
Please let me know whether you now have a setup
that works — if not we can work this problem some more.
— Jm
(*)
———————
\documentclass[11pt, oneside]{article}
\begin{document}
%%%%%%
{\tt monospace text} \emph{italic} \textbf{bold}
\texttt{monospace text} \emph{italic} \textbf{bold}
\begin{verbatim}
\monospace is interpreted
as a macro
\end{verbatim}
%%%%%%%
\end{document}

Hi, @jxxcarlson your message was about the #36 I will answer there.


UI of Premise section breaks in smaller screen

Describe the bug
In smaller screen sizes the Premise section components are aligned horizontally
Expected behaviour
In smaller screen sizes the Premise section components should be aligned vertically
Screenshots

To Reproduce

Go to home page('/')
Inspect the page
Change the screen size to less than 600px

Desktop
OS: Ventura 13.1
Browser: Chrome

@yochannah @padmajabhol can you please assign this to me

@yochannah @padmajabhol I want to work on this issue. Can you please assign this to me?


bug(mat-dialog): mat-dialog-content always has a scroll bar when there is a element with ripple overflowing inside

Reproduction
Steps to reproduce:
put a mat-slide-toggle in a mat-dialog-content
https://stackblitz.com/edit/angular-pt8j22?file=src/app/dialog-content-example-dialog.html
EDIT: same goes for checkboxes
Expected Behavior
there should not be a scroll bar when having a mat-slide-toggle in a mat-dialog-content if the content does not exceed the max height allowed
Actual Behavior
mat-dialog-content always has a scroll bar when there is a mat-slide-toggle inside it
Environment

Angular: 10
CDK/Material: 10
Browser(s): Chrome
Operating System (e.g. Windows, macOS, Ubuntu): Windows

Hi, this is caused by .mat-slide-toggle .mat-slide-toggle-ripple that has 40px height, which is larger than the mat-slide-toggle's 24px. We overcome this problem by applying padding top/bottom to a the toggle, when it's first/last.

@Totati Thank you for the workaround, I could not find the solution, much appreciated.

Just wanted to add that I ran into this issue with radio buttons as well, when they are at the bottom of the dialog content.

Just wanted to add that I ran into this issue with radio buttons as well, when they are at the bottom of the dialog content.

@nienow Yes, it happens because radio buttons also have ripples.

@nienow Yes, it happens because radio buttons also have ripples.

Any update on this?  This has been an annoyance for a long time.  Would be nice to get it fixed.

Yeah having the same issue, with radio buttons at the bottom of dialog

Angular material 15: this solved the issue
// to fix the issue with the dialog scroll issue
.mdc-dialog__surface {
overflow-y: hidden !important;
}

Its weird and unusable behavior


Grouping imported files by path in .use files

In .ooc files, it's possible to write things like use path/to/[File1, File2, AnotherFile]. This doesn't seem to work with the Imports: line in .use files, but would be neat.

As in, the 'Imports' directive of .use files?
On Jul 10, 2015 5:38 PM, "David Hesselbom"<EMAIL_ADDRESS>wrote:

In .ooc files, it's possible to write things like use path/to/[File1,
File2, AnotherFile]. This doesn't seem to work in .use files, but would
be neat.
—
Reply to this email directly or view it on GitHub
https://github.com/fasterthanlime/rock/issues/904.

Yes, I edited my answer to clarify. Sorry about being unclear.

No problem, just had me wondering for a while, "do namespaced usedefs even
exist?"
On Jul 10, 2015 5:59 PM, "David Hesselbom"<EMAIL_ADDRESS>wrote:

Yes, I edited my answer to clarify. Sorry about being unclear.
—
Reply to this email directly or view it on GitHub
https://github.com/fasterthanlime/rock/issues/904#issuecomment-120444223
.


Filter cli shorthand

It would be nice if I could do simple filtering without the need of a script.
i.e.
$ dox | doxie --filter isPrivate true
# or maybe
$ dox | doxie --filter 'isPrivate=true'

Yup, definitely! I’ve been thinking of two higher-level plugins for this: --drop and --keep. They can even  use --filter under the hood.

And here the programmatic API: https://github.com/studio-b12/doxie.output/tree/eee2c7#programmatic-usage
Not so nice, but explicit.
I want it to be possible to do --drop @api private and drop({'@api': 'private'}).

Closing this then. It’s still here for reference.

Oh and @stoeffel if you have other ideas to make the overall API simpler, I’m definitely open.
At the moment that’s my greatest concern. I wonder if the tool isn’t too flexible and therefore bloated.

My idea for this is to have low-level plugins like this one and --render – and high-level ones like --keep and --preset.


Grouping of Blogs

This has been an enhancement that I have been wanting for a while, so I figured I might as well bring it up while I'm thinking about it again.
Would it be possible to group blogs together into folders or apply some sort of label to them inside the program? For a folder, I'm envisioning like a sorta free structure where blogs can be moved to, which can be expanded or collapsed. But a single label would work as well, as long as there is a column for it that they can be sorted by.
Mostly, I am interested in being able to sort/group them inside the program itself, but an added bonus would definitely be to have all blogs with a folder/label also have their download folders be inserted into a subfolder of the Blogs folder. So, for all blogs in the "Wallpapers" folder/label, they would download to ".\Blogs\Wallpapers{BlogName}", and all blogs in the "Food" folder/label would download to ".\Blogs\Food{BlogName}". This would allow for easier sorting after downloading everything.

I would like to chime in and agree this kind of feature would be very desirable.  I posted the following in the common blog which is a similar request to this.
I know I requested this feature before, but in reading what I wrote it even confuses me.
The two features I requested was in how the reader saves the files into folders.
Currently it saves the files into a master folder which is set in the "settings" function. This allows all blogs to be saved in this master folder by the blog name.
I would like the ability to assign any blog to a "group" folder so that the file structure would be"
master/group1/blog1
master/group1/blog2
master/blog3
master/blog4
master/blog5
master/group2/blog6
master/group2/blog7
This would allow similar blogs to be grouped into a group folder by each blog.
The implementation of this could be a "group" column in the blog list where a special "group" folder could be added. Much like you do the "tags".
The other feature that would be useful would be to be able to select by blog if you wanted the files to be also placed into additional sub folders by the file extent.
Again this would be another field added to the blog list and would only need to be a checkbox kind of thing to enable or disable placing the file into a sub folder of the file extent in that blogs folder. Here is an example:
master/group1/blog2/gif
master/group1/blog2/jpg
master/group1/blog2/png
master/group1/blog2/mov
Having the ability to set these by individual blog would give much greater control on how the files were saved.
Thanks for a great program.
Slow

@tringate If you wanted to separate by file types, thats an easy fix.
Simply do a "sort by files" in the master folder, and then apply it to all sub folders.
Jerome


chore: removed unwanted CC_TEST_FLAGS when checking LuaJIT's FFI feat…

…ure.
We don't need the modified CC_TEST_FLAGS to pass the feature check.
And sometimes this change causes the configure script to fail.

@doujiang24
Could we merge it now?

@doujiang24
Could we merge it now?


Question about credential flow

hey, jasonraimondi, thanks for your awesome project,
I wonder if there are multiple microservices distributed on different machines, and I have to protect those endpoints by access_token, then what is the best practice (or common implementation) to do so?
for example, i have microservices A, B, C
now, service A have to send request to protected service B (with access_token)
i am not sure how can i complete this workflow 😣
my current thought is use client_credential to grant all services, each service will verify token before send request to another service endpoint, if the token expired or not existed, then create it at first, after we get access token from this authorization server, send request with access token and target service will verify this access token before data processing.
would appreciate for any advice 🙏🙏🙏

It does depend on the type of applications you are trying to deploy. Were you able to look at this flow chart to help decide? https://github.com/jasonraimondi/ts-oauth2-server#which-grant
Client credentials grant is not on behalf of a user, therefore it does not have a user context. If the access token is on behalf of a user, ie the endpoint you are trying to authorize into needs to know what user it is, you will need to use the password grant instead. Both the password grant and the client credentials grant should only be used by clients that can hold a secret.
Hope that helps,

Thanks for getting back to me, it really helps a lot :)
Yes, in my current situation, it just protect services without on behalf of any user,
my current work flow in detail is:

the credential client get access token from Authorization Server
the credential client send request to resource server with Bearer Token header (with access_token)
resource server send this access_token to Authorization Server and verify if this token is valid and authenticated
if this token is ok, then Authorization Server return scopes to resource server
resource server will check if it has enough authority to access current endpoint (based on scopes)
if everything goes well, then resource server send response to the credential client

I wonder if this work flow correct and make sense, thanks :D


Deleting users leaves their locations orphaned

When deleting a user account, all associated projects are deleted automatically in the process. However, locations that are assigned to these projects are not deleted. This leaves them without a parent project, which means that only the brand admin can access them at this point. (Actually, the original project_id is still referenced by the location, the project just no longer exists.)
The main problem with this behavior is, that any device that is still registered to such a location, can no longer be registered to another location without the intervention of the brand admin, who has to manually remove the device from its old location to make it available again.
Expected behavior would be that when a project is deleted, all associated locations are deleted as well, and the devices registered to those locations are removed automatically.

Destroying a user will now trigger a deletion of all locations (and aps) they own.


Callback calls using 'call' to force 'this'

Hi,
In order to retrieve the instance of Choices that triggered a callback, the callbacks are now invoked using the 'call' function to explicitly set 'this' inside the callback.
Thanks

Hey @froggiefab,
Thanks for this - was this causing a bug for you?
Thanks

Yes and no :)
I was previously using the "passedInput" parameter of the 'callbackOnChange' function to retrieve the instance.
This parameter was removed so I don't know wich instance triggered the callback anymore.
I thought it would be nice to have a way to retrieve the instance for all triggered callbacks.

Makes sense. Thanks - i'll review this ASAP.


Keeps on changing player rotation

##Issue
After loading up a new world, I did @gamer, and it went to the nearest tree as usual.  It proceeded to break enough logs to make a crafting table, made a crafting table and placed it down immediately
I expected it to start crafting sticks.
Instead, the view targeted the crafting table and slowly moved downwards. Once the crosshair moved off the crafting table,  the bot just started breaking another tree making a crafting table and proceeding started to repeat the problem.
Crashlogs and Screenshots (if applicable)

this is an image of the chat after making it stop
Other mods (if applicable)
baritone-unoptimized-fabric-1.18.2 (if this counts)
bedrock-miner-1.0.0
lithium-fabric-mc1.18.2-0.7.9
phosphor-fabric-mc1.18.x-0.8.1
sodium-fabric-mc1.18.2-0.4.1+build.15
viafabric-0.4.6+266-main
Discord username (if you want updates)
BestCheeringWinter#6141
Developer Notes (leave this blank)
Difficulty: __
Estimated Time Required: __
Once development starts.

Thanks for the detailed pictures.
Can you try to see if you are able to replicate this at all? And if so, what steps you took?

i had the same exact issue actually


Fedora/Ubuntu VM and VMI are ready but console access hangs.

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
BUG REPORT

/kind bug

What happened:
VMs on KubeEnv don't allow console access.
What you expected to happen:
Console access to booted VMs
How to reproduce it (as minimally and precisely as possible):
Running on AWS t2.mdium ec2 instances, 1 master 2 workers using Kubeadm.
Used krew to install the virt ctl.  Followed Lab2 step by step:
https://kubevirt.io/labs/kubernetes/lab2.html
"kubectl virt console fedora-vm" no access to console.
Anything else we need to know?:
Disk image of the same os in pvc has different size, on woker 2 (where vms are booting). The disk size is mere 4k but on woker 1 it's of 10 GB.
Environment:

KubeVirt version (use virtctl version):
Client Version: version.Info{GitVersion:"v0.20.1", GitCommit:"c2cacac0af5c2b1ee69845a2bb62ee1c5dc74b84", GitTreeState:"clean", BuildDate:"2019-08-09T17:41:44Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{GitVersion:"v0.17.0", GitCommit:"a067696ed6c25b0eab9dfcd01bbdc045f500f8ca", GitTreeState:"clean", BuildDate:"2019-05-06T14:58:11Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes version (use kubectl version):
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:13:54Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.3", GitCommit:"2d3c76f9091b6bec110a5e63777c332469e0cba2", GitTreeState:"clean", BuildDate:"2019-08-19T11:05:50Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

VM or VMI specifications:   Fedor-OS sample Lab 2 of KubeVirt

Cloud provider or hardware configuration: AWS t2.medium

OS (e.g. from /etc/os-release):  Ubuntu 16.04

Kernel (e.g. uname -a):  -Ubuntu SMP Fri Aug 2 13:50:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Install tools:

Others:
I solved the issue by copying the disk image to worker node 2 (/var/kubernetes/), but this issue shouldn't occur.

Hey, sorry for the late response. IIUC the setup described in the lab only works reliable on 1 node clusters. It uses a hostpath storage provisioner, which is deployed on a random node, and provides storage only on that node. So you would need to find out the correct node, and limit the VM to be deployed on that node... which is not ideal of course.
Will move this issue to the website repo.


cli: add support for providing timeout values in string format

Currently, the values for --timeout flag of the popper run command are given in seconds. As part of this issue, we will add support for human-friendly time format such as 180s, 3m, 3h, and so on..

I'd like to work on the issue

sure, please go ahead and let us know if you have any question. Thanks!


Jax-rs to fetch logs

Log files for each Action need to be retrieved from the server

Implement a REST endpoint in charles-rest that fetches Actions log files by name.

done


Two Small Changes, one proposed on how to handle non-transient connection failures

The ConnectionException is an idea to allow StartAsync to fail fast if the broker will never accept the connection. In this case, an authentication failure isn't going to suddenly become successful without a change to the broker (manually).

@poke pls comment when you can if this works for you. May expand to other transports once I know the specific exceptions.

Sorry, I was trying this out yesterday right after you submitted this but then I had a major hardware failure I first had to recover from. But I’m back in business now :smile:
I tried to test this by adding a test project. You can see that over here. If you start the program, you will see nothing; and only if you cancel the application with CTRL+K, you will see error log messages appear.
I’m not sure if I need to configure anything else to make this work or not. I also tried to configure an IReceiveEndpointObserver (commented it out in my commit) but that also didn’t help.


Run WMCore central services validation for HG2303

Impact of the new feature
WMCore central services
Is your feature request related to a problem? Please describe.
Monthly task
Describe the solution you'd like
Validate central services in cmsweb-testbed and provide the final feedback by the March deadline, specified by the CMSWEB team.
It also includes the creation of the service release notes and the validation check-list twiki.
Describe alternatives you've considered
None
Additional context
None

@todor-ivanov Todor, all the usual WMCore central services have been upgraded in cmsweb-testbed and their version is 2.1.8rc2. Please start the basic validation that we discussed on Monday.
Note that MSPileup has been upgraded as well, but MSPileup-tasks isn't yet deployed. Once @vkuznet gives us the green light, we can deploy that in testbed as well (but a new FE image is required to access that service from outside the cluster).

thanks @vkuznet I am going to start this validation ASAP

And here are the validation results:
https://twiki.cern.ch/twiki/bin/view/CMS/WMCore218Validation

Thanks Todor.
Here are the release notes: https://github.com/dmwm/WMCore/releases/tag/2.1.8
Shall we close this issue?

And I can confirm the services  with tag v2.1.8rc2 are  already in production  [1]. Thanks @amaltaro!
I am closing the issue.
[1]
https://cmsweb.cern.ch/reqmgr2/data/info


Replacing 1 by #

In this line (code for evaluation of CNNDM)
https://github.com/microsoft/unilm/blob/d22a233978842b824b449bcce6a5bd71aa98f952/src/gigaword/eval.py#L239
1 is replaced by #.
I don't understand it. Can someone explain me the reason of such post-processing ?

The file unilm/src/gigaword/eval.py follows the gigaword data preprocessing as in https://github.com/harvardnlp/sent-summary, which substitutes all the digits to #. However, our bpe tokenizer uses # to indicate subwords. So we preprocess the special token # to 1, and then replace them back after prediction. Notice that the unilm/src/cnndm/eval.py script doesn't use the preprocess.


Council of Ghosts Patron

Description
Adds the Council of Ghost patron which offers a new Blank Tombstone relic that gives intangible on turn 1 in exchange for max HP, or a Jar of Ghosts potion in exchange for health. Only one option can be used.

 You step into the eerie black mist, its embrace cold as dew. Squinting, you make out three shadowy masked figures that are towering over you.
[1] 1: "The puppet returns."
[2] 2: "WHAT FUN!"
[3] 3: "Quiet, you're frightening it. Can I interest you in a deal, mortal one?"
A deal?
No thanks.

[4] 3: "Promise your soul to me and I will grant you my unwavering protection."
[5] 2: "HOW ABOUT A PET SOUL OF YOUR OWN IN EXCHANGE FOR A SMALL SACRIFICE TO ME? IT WILL ONLY HURT A LITTLE."
[6] 1: "You forget yourselves.  Leave, puppet, for the good of us all."
[Promise Soul] Start each combat with 1 Intangible. Lose X Max HP. (40%/50%)
[Small Sacrifice] Obtain Ghost In A Jar potion. Lose X HP. (10%/15%)
[Leave]

[7] 3: "Excellent."
[8] A glowing ball of light grows from the spectre's hands, so bright it hurts your eyes. Through your fingers, you peer into the brilliant orb and see a vision of a headstone with a shadowy claw wrapped around it. The claw squeezes tighter and tighter. Cracks form then suddenly the gravestone is crushed to dust, debris flying into your face.
[9] Mist: When you open your eyes, the trio is gone, the darkness along with it, and all that remains is a heavy feeling in your chest.

[10] 2: "SO WE HAVE A DEAL?"
[11] The figure extends a shadowy hand out to you.  The color drains from your face as you begin losing consciousness.
[12] 1: "Enough."
Mist: The grip on you loosens. You fall to your knees, panting in a cold sweat. When you look up, the figures are all but gone, the smoke has cleared, and the denizens of the café are eyeing you warily.
[15] You feel something in your pocket. You pull out a corked bottle with some of the swirling mist inside. When you hold it against your ear you think you can hear screaming... Or is that just your imagination?

[17] 2: "YOU'LL BE BACK... HA HA HAHAHA!"
[18] Mist: The laughter subsides and the mist creeps away. You find yourself in the middle of the café once more, shivering - either with cold or fright, too shaken up to tell the difference.

[BLOCKING] You return to the eerie mist. After a few silent minutes wandering through the desolate twisting darkness you lose hope of finding the spirits again. You turn to leave, and within a few footsteps are suddenly back in the café._

Checklist

[x] I have added myself to the authors list in the ModTheSpire.json
[x] I have updated my entry and its state in the Contribution List
[x] I have removed all the placeholder and TODO strings in my contribution

Queries

My Sozu implementation isn't great - any preference on how to handle this?
I see no other examples of how to use multiple NPC names - is this integration acceptable?
Are the costs balanced? Would you like me to change them?

Thanks :)

@modargo Changes have been addressed, let me know if anything else is needed 👍

@modargo Changes have been addressed, let me know if anything else is needed 👍
edit: forgot to mention but I also updated the 1 Max HP check - this now costs 0 Max HP as I was unsure what going down to 0 Max HP would even do. Let me know if you think this should be changed.

Now that I think about it, I believe that's consistent with how the act 2 Ghosts event handles things. If you have 1 max HP, you can get the Apparitions for free. Not something I thought about initially but what you have now seems right.


Any example on using remote backend

Is your feature request related to a problem? Please describe.
It seems it must use node-fs-backend no matter what. If my resources are on remote server how to fetch
Describe the solution you'd like
Example on how to use remote backend plugin. Provided backend plugin will override node-fs-backend
Describe alternatives you've considered
module.exports = new NextI18Next({
  ...config,
  defaultLanguage: 'en',
  otherLanguages: OTHER_LANGUAGES.concat(DEFAULT_LANGUAGE),
  use: [nmdsBackend]
})

You can use whatever i18next settings you'd like. In this case we're talking about i18next-express-middleware settings. The config is completely overridable. You might want to take a look at #163. Otherwise, just play around with the config options seen here.
Let me know if you have any specific issues. I've never actually had this use case myself, so am unable to provide you with an example.

If we look at i18next documents you can use different types of backend plugins, right? i18next-node-fs-backend only works with files. But there is a locize service that we need to fetch our resources from remote server not from file. In that case how would we use this package?

Yes, you can add plugins via config.use. It's true that this package is primarily aimed at filesystem approaches, and I've explained my bias against serving localisation content over network requests in several places.
That said, if you have any concrete suggestions on how to improve functionality for different backend types, I am happy to discuss!

https://github.com/locize/next-i18next-locize


Update documentation on s3 integration

@javierluraschi kindly review.
Updated docs to reflect latest recommendations as per hadoop  wiki and added some pointers on how to configure spark to keep spark and hadoop config separate from sparklyR.

Thank you, @nhick!


update gradlew[.bat] with Apache license

As noted on<EMAIL_ADDRESS>gradlew[.bat] currently lack a license. These files are listed in our project license exclusions but we can address the lack of a license possibly by picking up new versions of these files. See

https://github.com/gradle/gradle/issues/2852
https://github.com/gradle/gradle/issues/8151

Need to update all the repos that use gradlew[.bat] (which will touch all the repos we've released so far).

This is the diff between the latest gradlew[.bat] is mainly just the license:
--- a/gradlew
+++ b/gradlew
@@ -1,5 +1,21 @@
 #!/usr/bin/env sh

+#
+# Copyright 2015 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 ##############################################################################
 ##
 ##  Gradle start up script for UN*X
@@ -28,7 +44,7 @@ APP_NAME="Gradle"
 APP_BASE_NAME=`basename "$0"`

 # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script.
-DEFAULT_JVM_OPTS=""
+DEFAULT_JVM_OPTS='-Dfile.encoding=UTF-8 "-Xmx64m" "-Xms64m"'

 # Use the maximum available, or set MAX_FD != -1 to use that value.
 MAX_FD="maximum"
@@ -109,8 +125,8 @@ if $darwin; then
     GRADLE_OPTS="$GRADLE_OPTS \"-Xdock:name=$APP_NAME\" \"-Xdock:icon=$APP_HOME/media/gradle.icns\""
 fi

-# For Cygwin, switch paths to Windows format before running java
-if $cygwin ; then
+# For Cygwin or MSYS, switch paths to Windows format before running java
+if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then

I took a look at Apache Kafka - they don’t include these scripts and instead punt it to the user to provide gradle. Rather inconvenient for the end user but perhaps cleanest for licensing.

For reference.
<EMAIL_ADDRESS>tl;dr like Kafka another Apache project gave up on including the gradle jar and punts the installation to the user (for a release).

I think I did an appropriate update to the NOTICE file in addition to updating the two files to the version from Gradle 5.5 in  https://github.com/apache/incubator-openwhisk-catalog/pull/305.  Once we decide we're happy with that, we can replicate across the gazillions of repos that have the same issue.

Adjusted in https://github.com/apache/incubator-openwhisk-catalog/pull/306.

I did this across all repos.


Cannot find module '../build/Release/sharp-linux-x64.node'

Cannot find module '../build/Release/sharp-linux-x64.node'
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

If you cannot confirm both of these, please open an installation issue instead.
Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.
What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?

System:
OS: macOS 13.3.1
CPU: (8) arm64 Apple M1
Memory: 74.13 MB / 8.00 GB
Shell: 3.2.57 - /bin/sh
Binaries:
Node: 18.15.0 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 9.5.0 - /usr/local/bin/npm
pnpm: 8.5.1 - /usr/local/bin/pnpm
npmPackages:
sharp: ^0.32.1 => 0.32.1
What are the steps to reproduce?

We have a lambda in AWS we just push this
What is the expected behaviour?

it should locate the module
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem

When we run the lib locally it works normally, but when we go up in a lambda function this problem occurs
Please provide sample image(s) that help explain this problem

Please see https://sharp.pixelplumbing.com/install#aws-lambda

@victorhenriq3 Were you able to make any progress with this?

Closing due to inactivity but please feel free to reopen with more details if further help is required.

I resolved this problem by use : npm rebuild --verbose sharp

If I had to do this manually bc I'm on a computer with no connectivity, how might I install sharp-linux-x64.node ?

Please upgrade to the latest version, currently v0.33.5.
If you're still having problems with cross/multi-platform installation with the latest version, please see https://sharp.pixelplumbing.com/install#cross-platform


5e roll template updates

Unfortunately, I don’t have a method for testing. So, beware….

What do you mean, you don't have a method for testing these changes?

I don't have a Pro account to test these out in the full Roll20 environment. If there is an available demo environment where I can test these changes at, please let me know. I'll be the first to admit I probably didn't dig deep enough into Roll20's developer space.

I believe Actoba already fixed these - I suggest picking them up from there.

I actually see very little change in @Actoba's changes from where it was. Again, I didn't test the changes, but I know the way it was caused "roll2" to incorrectly calculate the additional attack metrics.

You've got merge conflicts, and github is saying that you are changing every single line of the html which probably means your line-endings are different. Please fix these 2 things, and then I'll take a look at it.


Cleanup react components

Since the react-figma-plugin-ds dependency is broken, I recently "imported" the components that are used in this plugin.
However they need to be cleaned up, including the css.
This includes (but is not limited to):

[ ] Button
[ ] Checkbox
[ ] Select
[ ] Title
[ ] Input
[ ] Label
[ ] Text

Can I work on this issue???

Hey @ratnakar5938, sure I would love help with that.
It would be best to do one PR per component.
For any questions, feel free to ask me or send a [WIP] PR with questions / Ideas attached.

Can u plz explain wt are ur needs

Sure, so the components are mainly copied from the react-figma-plugin-ds package.
This means there is probably css in there that is never used in the plugin.
-> This css should be removed.
Also there may be states in the components that are never used. Those states should be removed as well.
This often leads to being able to remove more code from the components.
The goal of this is that the components react code & css (which is within the .tsx file) gets less complex.
Hope that helps.

can u describe how to start the local server
😬😬😬

Well, there is no local server. So you need to add it to figma as a plugin first. Afterwards you run "npm start" which builds it.
This may be a bit complicated though. :( sorry.
Do you need it to verify?

I will try
if any error comes up I will ask
😬😬

I installed the plugin in my figma
What to do next???

Hey, I am sorry, I think this does not even work. I thought you could get a dev version to run. But I am not sure that works.
I think you would need to run the react files locally but I am not sure it would work. You'd probably get errors due to specific figma api usage.
I think the only way to do it, is to do it "blind". But it's also fine if that is no fun for you. I understand that this is not a great dev experience. :)

Actually I am a newbie so working blind will not work for me :( sorry

Yeah, no worries, makes sense. I removed the two labels, as I realised that it has more complexity to it than I thought. Working on open source is a great idea though. Just find another problem to solve here or in another project. 👍
Cheers & thanks for offering help.

@lukasoppermann
I think this issue has already been addressed. Are there any remaining tasks related to this?
Mayme this https://github.com/lukasoppermann/design-tokens/pull/163.


Change thickness of lines proportional to flow quantities

Any idea?
Thanks for advance.

@osper66 is this what you are looking for? We have a demo that has different line widths (and colors) based on data attributes.
https://jwasilgeo.github.io/Leaflet.Canvas-Flowmap-Layer/docs/class-breaks-symbology/
https://github.com/jwasilgeo/Leaflet.Canvas-Flowmap-Layer/blob/master/docs/class-breaks-symbology/index.html#L94-L137

If CanvasFlowmapLayer.js's destinationFeature in line:186's property has flow value(population, migration etc.) , change g this._animateCanvasLineSymbol(ctx, symbol, screenOriginPoint, screenDestinationPoint) in line:642 to this._animateCanvasLineSymbol(ctx, symbol, screenOriginPoint, screenDestinationPoint, lineWidths[feature.properties.population) where lineWidths are given by some scaling rule according to population value and finally change  _animateCanvasLineSymbol: function(ctx, symbolObject, screenOriginPoint, screenDestinationPoint, lineWidth) in line:693 and ctx.lineWidth = lineWidth in line:695.


processing functions and spark

As I told by email I have the basic wrappers for the C++ code finished.   They remain to be fully tested.  In my current situation with grandkids I can't spend time doing that, but I have been thinking about how algorithms should be set up to interact correctly with SPARK.   A quick search got me to this extremely useful page I'm sure you are well aware of by I want to preserve here for later reference:  https://www.tutorialspoint.com/apache_spark/apache_spark_core_programming.htm
Clearly things like filter, map, collect, and reduce are key features.  Not yet clear to me when the other methods mentioned there are appropriate, but presume that will become apparent as I learn this.
I was thinking of adapting a C++ program I have to compute a 3C agc as a lightweight first algorithm to try.   I can do the coding for that and make a wrapper in an hour or so, but something I don't understand about spark at this point are a couple of fundamental issues:

I believe the model is that inputs are always treated as immutable.   Is that true?
Is there a hidden copy overhead in map?   i.e. especially in a distributed system it would seem required that some or all data get copied before processed.   Is that true?   Do I best view that as not my problem?
Since python is agnostic about type I presume input and outputs can be whatever and the interpreter handles the types internally.  Is that right?
What happens if the function passed to map sometimes throws an exception and fails?   Maybe that is in a section I haven't gotten to yet.

Enough for now.   Actually, pretty clearly the first thing I need to do when I have a block of time to do so is run your example python script under spark.   That likely will teach me more.  It would be helpful, however, if you could extend that example by calling a custom python script instead of the inline function your example uses.   I assume the idea is to have a symbol defined in a module such as
import mspasspy as msp
map(blah,blah, msp.agc,blah)

Design issue:  Just went back to reading the page noted above and noted something I missed on the first quick pass:  pipe.   Not a first order thing to try, but suspect that might be a good way to handle chains of process filters.   I have the machinery in antelope contrib to push data through pipes using boost serialization.   Worth keeping in mind as it might make some processing chains more efficient.

I think we don't really have to explore all the features of Spark as I think it will mostly be used as a task scheduler for processing. Map and reduce should cover most of our use cases.
To your questions:

I believe the model is that inputs are always treated as immutable. Is that true?
I think so. Each action or transformation should generate a new RDD.

Is there a hidden copy overhead in map? i.e. especially in a distributed system it would seem required that some or all data get copied before processed. Is that true? Do I best view that as not my problem?
Yes, there is definitely overhead in distributing the original data set from one node too all the others. There will also be overheads in communication in a chain of processing steps. There could be some significant memory consumption from all these, and I think I've seen people complaining about this when using Spark. However, just as you said, this is not our problem, and Spark is designed to be able to do all these efficiently. In the case we figured it is not a good fit for our application, we might also consider something else. Because our user interface will be based on Python, it should be straightforward to switch to something Spark alike that are available out there.

Since python is agnostic about type I presume input and outputs can be whatever and the interpreter handles the types internally. Is that right?
Yes, we got a lot of freedom here, and it could be dangerous, too.

What happens if the function passed to map sometimes throws an exception and fails? Maybe that is in a section I haven't gotten to yet.
I don't think Spark handles exceptions, but we should always implement exception handler within the functions for users anyway. Spark will terminate all parallel tasks when encountering error in any concurrently running tasks. We can handle the exception based on the severity to decide whether terminate the parallel tasks or just skip something silently.

Thanks for the education.  I realize now we visited the exception question in a less specific way earlier.  It is, in fact, why I created the ErrorLogger class to allow error handler to to not abort an entire map/reduce operation but only post an "Invalid" flag on a log entry.

discussion in #11


Support 1.21.1

This mod currently limits the version to 1.21. I tried to edit the fabric.mod.json to let it allow ~1.21 version and it seems to work.

I really need to remember to update this mod in a more timely manner lol, especially when it's just a simple version bump…
P.S. It's made it into a modpack? Wow!


Update README.rst

Update README instructions on how to use an already cloned cookiecutter
Ref: Issue #835

Hey @kevgathuku! 👋
I'm closing this as per comment on #835.
Please do get in touch if you continue to encounter issues around this functionality. 🙇


False negative of prop-types with stateless components

When a stateless component is created as a property of an object, prop-types gives false negative:
🚫 reports "'children' is missing in props validation":
Panel.Body = ({children}) => (

    {children}

)

Panel.Body.propTypes = {
  children: PropTypes.node
}

👌🏽 works fine:
const Body = ({children}) => (

    {children}

)

Body.propTypes = {
  children: PropTypes.node
}

Panel.Body = Body

Another example:
🚫 reports error:
function Foo({bar}) {
  return
{bar}

}

Foo.propTypes = {
  bar: PropTypes.string.isRequired
}

Passes:
Foo.propTypes = {
  bar: PropTypes.string.isRequired
}

function Foo({bar}) {
  return
{bar}

}

@kossnocorp How is created your Panel object ? To match the propTypes with Panel.Body we're searching for the Panel variable in the current scope but in your example Panel is never declared so we cannot makes the match.
This code is working:
var Panel = {}; // <= Declare Panel
Panel.Body = ({children}) => (

    {children}

)

Panel.Body.propTypes = {
  children: PropTypes.node
}

@kentcdodds What version of eslint and eslint-plugin-react are you using? Your first example is working for me with eslint-plugin-react v6.1.2

@yannickcr the Panel is declared as a class exported by default, maybe this is the problem. However, it's valid ES200X and supposed to be working 😇
I have errors:

... on such code:
import React, {PropTypes, Component} from 'react'
import classNames from 'classnames'

export default class Panel extends Component {
  static propTypes = {
    children: PropTypes.node,
    color: PropTypes.oneOf(['green', 'red', 'orange', 'grey', 'blue'])
  }

  render () {
    const {color, children} = this.props
    const panelClasses = classNames('Panel', {
      [`is-${color}`]: color,
      'has-color': color
    })
    return (

        {children}

    )
  }
}

Panel.Header = ({children}) => (

    {children}

)

Panel.Header.propTypes = {
  children: PropTypes.node
}

Panel.Body = ({children}) => (

    {children}

)

Panel.Body.propTypes = {
  children: PropTypes.node
}

@kentcdodds I just tried your code and I don't have the error:

You can try to update I suppose.

the Panel is declared as a class

Ok, seems the issue comes from here. I'll have a look.

Huh, it looks like my issue is possibly related but I'm not sure what's going on... Here's how I can reproduce the issue:
import React, {PropTypes} from 'react'

function Foo({bar}) { // react/prop-types error reported for bar on this line
  const {baz} = Foo
  return
{baz} {bar}

}

Foo.propTypes = {
  bar: PropTypes.string.isRequired,
}

Foo.baz = 'hi'

This does not produce any error:
import React, {PropTypes} from 'react'

function Foo({bar}) {
  const baz = Foo.baz
  return
{baz} {bar}

}

Foo.propTypes = {
  bar: PropTypes.string.isRequired,
}

Foo.baz = 'hi'

Here's a real use case
Looks like destructuring a property off of the function (whether inside the function itself or not) is causing issues.

@kentcdodds ok, it's a different problem then.
Can you open a new issue with your last message? Thanks.

Cool, will do, thanks!


feat(RHTAPREL-874): add e2e test for rhtap-service-push

Signed-off-by: Jing Qi<EMAIL_ADDRESS>Add e2e test case for rhtap-service-push pipeline
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/retest

/retest

/retest

/test load-test-max-concurrency-advanced

/test all

/test all

/test all

Just mentioning here as I have on slack, I am not sure what a good check for the rhtap-service-push pipeline is. This ticket probably needs to be groomed further


Fix spinal cord segmentation

Two subjects failing:

Using -c t2s they all look good! ✅

Except sub-04:

So I can make a close in the code to use -c t2 only for sub-04

Sorry to reopen.
I am not sure I understand. Are we switching back to sct_deepseg_sc for this project?
Have you checked other cases? In my experience, at least half the rf shim cases require some manual correction, especially lower down (slices 0-10). MONAI mislocalized or even fully missed the sc, see here for sub-05, patspec, slice 12

Are we switching back to sct_deepseg_sc for this project?

Yes we are.

Have you checked other cases? In my experience, at least half the rf shim cases require some manual correction, especially lower down (slices 0-10)

Yes, QC report is generated. All slices covering C1-T2 look fine to me with the current code.

Re-closing as https://github.com/shimming-toolbox/rf-shimming-7t/issues/31#issuecomment-1885746218 is addressed


GH-1385: Add qualifier for error infrastructure

Fixes https://github.com/spring-cloud/spring-cloud-stream/issues/1385
Avoid bean name collision when using multiple bindings to the destination/group.
Add a new property qualifier.

Codecov Report

Merging #1388 into master will decrease coverage by 0.01%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master    #1388      +/-   ##
============================================
- Coverage     61.14%   61.12%   -0.02%
- Complexity      813      818       +5
============================================
  Files           133      133
  Lines          3917     3928      +11
  Branches        551      551
============================================
+ Hits           2395     2401       +6
- Misses         1246     1249       +3
- Partials        276      278       +2

Impacted Files
Coverage Δ
Complexity Δ

...mework/cloud/stream/binder/ProducerProperties.java
93.18% <100%> (+0.49%)
32 <2> (+2)
:arrow_up:

...mework/cloud/stream/binder/ConsumerProperties.java
81.81% <33.33%> (-3.55%)
21 <1> (+1)

...ud/stream/binder/AbstractMessageChannelBinder.java
47.31% <75%> (-0.13%)
26 <7> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f5b63e...b5cd110. Read the comment docs.

After discussing it with @garyrussell we're not going with the above solution to avoid introducing yet another property to solve a problem that can be solved with the existing properties.
Basically do use different group to eliminate the conflict.
What we'll do also is provide better error handling with a more descriptive error message suggesting to the user about the potential issue and resolution.


Default/404 route is always rendering

Version
react-router-dom 4.1.1
react-redux 5.0.4
Steps to reproduce
ReactDOM.render(
  <Provider store={ store }>
    <Router>
      <Page>
        <Route exact path='/' component={ Home } />
        <Route exact path='/builder' component={ Builder } />
        <Route exact path='/form/:formId' component={ Form } />
        <Route component={ NotFound } />
      </Page>
    </Router>
  </Provider>,
  document.getElementById( 'root' ),
);

Expected Behavior
The last Route should only render, if there is no other match.
Actual Behavior
The last Route renders no matter what.

This is the correct behavior, for your expected behavior use Switch
<Switch>
  <Route exact path='/' component={ Home } />
  <Route exact path='/builder' component={ Builder } />
  <Route exact path='/form/:formId' component={ Form } />
  <Route component={ NotFound } />
</Switch>

Ah, I must have overlooked the Switch component. Thank you


Fix Broken UI Test for all General Configurable Settings

**This is a pull request raised for issue https://github.com/odk-x/tool-suite-X/issues/470
**Reason for Fix:
There are configurable settings available for a normal user of the app and there are configurable settings available for a user with admin privileges. The UI tests for these settings screen was broken following a rework of the settings screen. This PR was raised to fix the broken UI Test for the configurable settings that are available to a general user. These tests includes the following:

GeneralAdminConfigurationTest.java
GeneralDeviceSettingsFragmentTest.java
GeneralServerSettingsFragmentTest.java
GeneralTablesSettingsFragmentTest.java

**What was changed in these files:

GeneralAdminConfigurationTest.java
--corrected the reference for the string to be matched.
--fix the flow to enable the test enter the test password

GeneralDeviceSettingsFragmentTest.java
--corrected the reference for the string to be matched.

GeneralServerSettingsFragmentTest.java
--fix the flow to enable the test enter the test password
--referenced the correct text to be entered as password

GeneralTablesSettingsFragmentTest.java
--corrected the reference for the string to be matched.

**N/B: The checkBarcodeScanner_IsVisible() test in GeneralServerSettingsFragmentTest.java is still marked as ignore cos I couldn't find a QR code option on that screen.

@Redeem-Grimm-Satoshi awaiting your review

Well done! I see some changes made but I haven't tested it yet. Send a screenshot showing how it works at your end ( test passed ) then I can proceed to review from there

Hi @Redeem-Grimm-Satoshi I've  added the screenshot(s) as requested.


Change ext_auth logger id

Commit Message: Change ext_authz Filter logger id
Additional Description: -
Risk Level: low
Testing: Tested build locally and confirmed by running this command
./bazel-bin/source/exe/envoy-static -c /mnt/disks/envoy-project/examples/ext_authz.yaml --component-log-level ext_authz:trace

generated logs:
[2022-10-12 12:45:56.310][103024][trace][ext_authz] [source/extensions/filters/http/ext_authz/ext_authz.cc:73] [C0][S14765918889036524211] ext_authz filter calling authorization server
[2022-10-12 12:45:56.315][103024][trace][ext_authz] [source/extensions/filters/http/ext_authz/ext_authz.cc:417] [C0][S14765918889036524211] ext_authz filter rejected the request with an error.