[ALLUXIO-2182]  Display per-UFS IO metrics

https://alluxio.atlassian.net/browse/ALLUXIO-2182
Displays the IO metrics per under file system.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20139/Failed Tests: 1org.alluxio:alluxio-core-server-master: 1alluxio.master.metrics.MetricsMasterTest.testMultiValueAggregator
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20140/Failed Tests: 1org.alluxio:alluxio-core-server-master: 1alluxio.master.metrics.MetricsMasterTest.testMultiValueAggregator
Test FAILed.

@yupeng9 Based on @aaudiber's suggestion, we will change metrics system from a singleton, can you hold off on this until #7391 is resolved?

@calvinjia SGTM

@calvinjia PTAL

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20169/Failed Tests: 2org.alluxio:alluxio-core-server-master: 1alluxio.master.metrics.MetricsMasterTest.testMultiValueAggregatororg.alluxio:alluxio-minicluster: 1alluxio.multi.process.MultiProcessClusterTest.zookeeper
Test FAILed.

@yupeng9 Had a follow up question, also does valueOf not work in place of fromString for the enum?

@calvinjia It could with the toLowerCase transformation. I don't have a preference on either, so I'll change it to what you requested.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20179/Failed Tests: 13org.alluxio:alluxio-core-common: 1alluxio.metrics.MetricTest.testFullNameParsingorg.alluxio:alluxio-tests: 12alluxio.client.cli.fs.command.FreeCommandIntegrationTest.freealluxio.client.cli.fs.command.FreeCommandIntegrationTest.freePinnedFileForcedalluxio.client.fs.FileInStreamIntegrationTest.readTest1alluxio.client.fs.FileInStreamIntegrationTest.readEndOfFilealluxio.client.fs.FileInStreamIntegrationTest.asyncCacheAfterSeekalluxio.client.fs.FileInStreamIntegrationTest.asyncCacheFirstBlockPReadalluxio.client.fs.ImpersonationIntegrationTest.impersonationHdfsGroupAllowedalluxio.client.fs.ImpersonationIntegrationTest.impersonationHdfsGroupsAllowedalluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersDeniedGroupsAllowedalluxio.client.rest.FileSystemMasterClientRestApiTest.unmountalluxio.client.rest.S3ClientRestApiTest.putLargeObjectalluxio.server.configuration.ConfigCheckerIntegrationTest.unsetVsSet
Test FAILed.

@yupeng9 Looks good overall, could you update what the new metrics page looks like with the new aggregation?

Sure

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20194/Failed Tests: 10org.alluxio:alluxio-tests: 10alluxio.client.cli.fs.command.FreeCommandIntegrationTest.freeWildCardalluxio.client.cli.fs.command.FreeCommandIntegrationTest.freealluxio.client.cli.fs.command.FreeCommandIntegrationTest.freePinnedFileForcedalluxio.client.fs.FileInStreamIntegrationTest.readTest1alluxio.client.fs.FileInStreamIntegrationTest.readEndOfFilealluxio.client.fs.FileInStreamIntegrationTest.asyncCacheAfterSeekalluxio.client.fs.FileInStreamIntegrationTest.asyncCacheFirstBlockPReadalluxio.client.rest.S3ClientRestApiTest.getLargeObjectalluxio.server.ft.ZookeeperFailureIntegrationTest.zkFailurealluxio.server.configuration.ConfigCheckerIntegrationTest.unsetVsSet
Test FAILed.

Jenkins, test this please.

@yupeng9 Do you know if the test failures are related to your changes?

@calvinjia that's the same flakiness. I turned the client-side metrics collection on in this PR.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20206/Failed Tests: 6org.alluxio:alluxio-minicluster: 1alluxio.multi.process.MultiProcessClusterTest.zookeeperorg.alluxio:alluxio-tests: 5alluxio.client.fs.ImpersonationIntegrationTest.impersonationUsedHdfsUseralluxio.client.fs.ImpersonationIntegrationTest.impersonationHdfsGroupsAllowedalluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersAllowedGroupsAllowedalluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersDeniedGroupsAllowedalluxio.server.ft.ZookeeperFailureIntegrationTest.zkFailure
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20208/Failed Tests: 2org.alluxio:alluxio-tests: 2alluxio.client.fs.ImpersonationIntegrationTest.impersonationHdfsGroupAllowedalluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersAllowedGroupsAllowed
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20210/Failed Tests: 2org.alluxio:alluxio-minicluster: 1alluxio.multi.process.MultiProcessClusterTest.zookeeperorg.alluxio:alluxio-tests: 1alluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersDeniedGroupsAllowed
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20211/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.client.fs.ImpersonationIntegrationTest.impersonationHdfsGroupAllowed
Test FAILed.

jenkins, test this please

jenkins, test this please

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20216/Failed Tests: 3org.alluxio:alluxio-minicluster: 1alluxio.multi.process.MultiProcessClusterTest.zookeeperorg.alluxio:alluxio-tests: 2alluxio.client.fs.ImpersonationIntegrationTest.impersonationHdfsGroupAllowedalluxio.server.ft.ZookeeperFailureIntegrationTest.zkFailure
Test FAILed.

Merged build finished. Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20217/Failed Tests: 4org.alluxio:alluxio-minicluster: 1alluxio.multi.process.MultiProcessClusterTest.zookeeperorg.alluxio:alluxio-tests: 3alluxio.client.fs.ImpersonationIntegrationTest.impersonationHdfsGroupsAllowedalluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersDeniedGroupsAllowedalluxio.server.ft.ZookeeperFailureIntegrationTest.zkFailure
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20218/
Test PASSed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20220/Failed Tests: 1org.alluxio:alluxio-minicluster: 1alluxio.multi.process.MultiProcessClusterTest.zookeeper
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20221/Failed Tests: 2org.alluxio:alluxio-tests: 2alluxio.client.cli.fs.command.FreeCommandIntegrationTest.freePinnedFileForcedalluxio.server.auth.MasterClientAuthenticationIntegrationTest.customAuthenticationDenyConnect
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20229/
Test PASSed.

jenkins, test this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20234/
Test PASSed.

Merged build finished. Test PASSed.

@calvinjia @aaudiber rewrote the history and retargeted to branch-1.8

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20240/Failed Tests: 2org.alluxio:alluxio-tests: 2alluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersAllowedGroupsDeniedalluxio.client.fs.ImpersonationIntegrationTest.impersonationHdfsGroupsAllowed
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20243/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersDeniedGroupsAllowed
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20245/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.client.fs.ImpersonationIntegrationTest.impersonationUsersAllowedGroupsAllowed
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20247/Failed Tests: 2org.alluxio:alluxio-core-client-hdfs: 2alluxio.hadoop.AbstractFileSystemTest.useSameContextWithZookeeperalluxio.hadoop.AbstractFileSystemTest.resetContext
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20248/
Test PASSed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20249/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20268/Build result: FAILURE[...truncated 4101 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.8.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/checker/pom.xml to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/checker/target/alluxio-checker-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/checker/target/alluxio-checker-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/target/alluxio-core-server-worker-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/pom.xml to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/target/alluxio-logserver-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/target/alluxio-logserver-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.8.0-SNAPSHOT/alluxio-core-client-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.8.0-SNAPSHOT/alluxio-core-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/target/alluxio-core-server-proxy-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.8.0-SNAPSHOT/alluxio-tests-1.8.0-SNAPSHOT.pomchannel stoppedArchiving artifacts
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20272/
Test PASSed.

Merged build finished. Test PASSed.

@calvinjia @aaudiber any more comments?

@calvinjia, yes, USER_METRICS_COLLECTION_ENABLED is disabled only for 1 test.
In addition, client-side metric collection is tested in test MetricsMasterTest.

@yupeng9 Aren't we disabling USER_METRICS_COLLECTION_ENABLED in AbstractLocalAlluxioCluster.java?

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20303/Build result: FAILURE[...truncated 2085 lines...][JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-keyvalue-common/1.8.0-SNAPSHOT/alluxio-keyvalue-common-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-client-fs/1.8.0-SNAPSHOT/alluxio-core-client-fs-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-client-fs/1.8.0-SNAPSHOT/alluxio-core-client-fs-1.8.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-client-fs/1.8.0-SNAPSHOT/alluxio-core-client-fs-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-client-fs/1.8.0-SNAPSHOT/alluxio-core-client-fs-1.8.0-SNAPSHOT-tests.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT-tests.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-client/1.8.0-SNAPSHOT/alluxio-core-client-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core/1.8.0-SNAPSHOT/alluxio-core-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.pom[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving<EMAIL_ADDRESS>to org.alluxio/alluxio-tests/1.8.0-SNAPSHOT/alluxio-tests-1.8.0-SNAPSHOT.pomchannel stoppedArchiving artifacts
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20299/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.server.tieredstore.TieredStoreIntegrationTest.deleteWhileRead
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20301/Failed Tests: 42org.alluxio:alluxio-core-server-master: 14alluxio.master.block.BlockMasterTest.removeBlockTellsWorkersToRemoveTheBlockalluxio.master.block.BlockMasterTest.workerHeartbeatUpdatesAddedBlocksalluxio.master.block.BlockMasterTest.workerHeartbeatUpdatesRemovedBlocksalluxio.master.block.BlockMasterTest.registerCleansUpOrphanedBlocksalluxio.master.block.BlockMasterTest.workerHeartbeatUpdatesMemoryCountalluxio.master.file.FileSystemMasterTest.ttlDirectoryFreealluxio.master.file.FileSystemMasterTest.ttlFileFreealluxio.master.file.FileSystemMasterTest.freeDirWithPinnedFileAndForcedalluxio.master.file.FileSystemMasterTest.freeDiralluxio.master.file.FileSystemMasterTest.freealluxio.master.file.FileSystemMasterTest.ttlDirectoryFreeReplayalluxio.master.file.FileSystemMasterTest.freePinnedFileWithForcealluxio.master.file.FileSystemMasterTest.deleteFilealluxio.master.file.FileSystemMasterTest.ttlFileFreeReplayorg.alluxio:alluxio-tests: 28alluxio.client.cli.fs.command.CpCommandIntegrationTest.copyToLocalLargealluxio.client.cli.fs.command.FreeCommandIntegrationTest.freeWildCardPinnedFileForcedalluxio.client.cli.fs.command.FreeCommandIntegrationTest.freeWildCardalluxio.client.cli.fs.command.FreeCommandIntegrationTest.freealluxio.client.cli.fs.command.FreeCommandIntegrationTest.freePinnedFileForcedalluxio.client.cli.fs.command.PinCommandIntegrationTest.setPinalluxio.client.fs.FileInStreamIntegrationTest.asyncCacheFirstBlockalluxio.client.fs.FileInStreamIntegrationTest.asyncCacheAfterSeekalluxio.client.fs.FileInStreamIntegrationTest.asyncCacheFirstBlockPReadalluxio.client.fs.FileSystemMasterIntegrationTest.deleteDirectoryRecursivealluxio.client.fs.FreeAndDeleteIntegrationTest.freeAndDeleteIntegrationalluxio.client.fs.IsolatedFileSystemIntegrationTest.lockBlockTest1alluxio.client.fs.IsolatedFileSystemIntegrationTest.lockBlockTest3alluxio.client.fs.IsolatedFileSystemIntegrationTest.unlockBlockTest1alluxio.client.fs.IsolatedFileSystemIntegrationTest.unlockBlockTest3alluxio.server.ft.FlakyUfsIntegrationTest.deletePartialalluxio.server.health.BlockMasterIntegrityIntegrationTest.deleteInvalidBlocksalluxio.server.health.BlockMasterIntegrityIntegrationTest.deleteOrphanedBlocksalluxio.server.health.BlockMasterIntegrityIntegrationTest.deleteInvalidBlocksPeriodicallyalluxio.server.tieredstore.SpecificTierWriteIntegrationTest.midTierWritealluxio.server.tieredstore.SpecificTierWriteIntegrationTest.allTierWritealluxio.server.tieredstore.SpecificTierWriteIntegrationTest.topTierWritealluxio.server.tieredstore.SpecificTierWriteIntegrationTest.topTierWriteWithEvictionalluxio.server.tieredstore.SpecificTierWriteIntegrationTest.midTierWriteWithEvictionalluxio.server.tieredstore.SpecificTierWriteIntegrationTest.bottomTierWritealluxio.server.tieredstore.TierPromoteIntegrationTest.promoteBlock[0]alluxio.server.tieredstore.TierPromoteIntegrationTest.promoteBlock[1]alluxio.server.tieredstore.TieredStoreIntegrationTest.unpinFile
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20305/Build result: FAILURE[...truncated 2085 lines...][JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/keyvalue/common/target/alluxio-keyvalue-common-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-keyvalue-common/1.8.0-SNAPSHOT/alluxio-keyvalue-common-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/pom.xml to org.alluxio/alluxio-core-client-fs/1.8.0-SNAPSHOT/alluxio-core-client-fs-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-client-fs/1.8.0-SNAPSHOT/alluxio-core-client-fs-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-client-fs/1.8.0-SNAPSHOT/alluxio-core-client-fs-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/fs/target/alluxio-core-client-fs-1.8.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-client-fs/1.8.0-SNAPSHOT/alluxio-core-client-fs-1.8.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/pom.xml to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/common/target/alluxio-core-common-1.8.0-SNAPSHOT-tests.jar to org.alluxio/alluxio-core-common/1.8.0-SNAPSHOT/alluxio-core-common-1.8.0-SNAPSHOT-tests.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/integration/checker/pom.xml to org.alluxio/alluxio-checker/1.8.0-SNAPSHOT/alluxio-checker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/worker/pom.xml to org.alluxio/alluxio-core-server-worker/1.8.0-SNAPSHOT/alluxio-core-server-worker-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/logserver/pom.xml to org.alluxio/alluxio-logserver/1.8.0-SNAPSHOT/alluxio-logserver-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/client/pom.xml to org.alluxio/alluxio-core-client/1.8.0-SNAPSHOT/alluxio-core-client-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/pom.xml to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/examples/target/alluxio-examples-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-examples/1.8.0-SNAPSHOT/alluxio-examples-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/pom.xml to org.alluxio/alluxio-core/1.8.0-SNAPSHOT/alluxio-core-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/core/server/proxy/pom.xml to org.alluxio/alluxio-core-server-proxy/1.8.0-SNAPSHOT/alluxio-core-server-proxy-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/pom.xml to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.pom[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.8.0-SNAPSHOT.jar to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/shell/target/alluxio-shell-1.8.0-SNAPSHOT-sources.jar to org.alluxio/alluxio-shell/1.8.0-SNAPSHOT/alluxio-shell-1.8.0-SNAPSHOT-sources.jar[JENKINS] Archiving /home/jenkins/workspace/Alluxio-Pull-Request-Builder/tests/pom.xml to org.alluxio/alluxio-tests/1.8.0-SNAPSHOT/alluxio-tests-1.8.0-SNAPSHOT.pomchannel stoppedArchiving artifacts
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20306/
Test PASSed.

Merged build finished. Test PASSed.

@calvinjia That's a good call. USER_METRICS_COLLECTION_ENABLED should not be set in  `AbstractLocalAlluxioCluster.java.

@calvinjia PTAL.


dropping legacy serialization support

Could we just drop the ISerializable interface and SerializableAttribute altogether in 3.x for all runtimes?
Users that rely on that can use 2.x I guess.

Could we just drop the ISerializable interface and SerializableAttribute altogether in 3.x for all runtimes?
Users that rely on that can use 2.x I guess.
@ppkarwasz We would like to play safe as there was no feedback on #175.


Bump build number

Trying to debug what's happening in #18, so just trying a simple rebuild.
Not for merging.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin please rerender

@conda-forge-admin please rerender

:tada: building again!

Looking at it again, I have no idea how we got builds for windows before, as the build was still broken.

Looks like this is fixed up now, excellent. I'm going to merge to see if the files get uploaded, and then do another build to try out the OSX stuff.


provide content model scoping for discovery-level provenance information

Have to establish boundary for what is expected at discovery profile level and what is delegated to the provenance profile extension.  Update content model section in the cdif book

In particular, inclusion of information about instruments, sensors, platforms, software algorithms is added.  Proposed solution in Dagstuhl discussion is to use prov properties.


Re-stick sticky nav

The sticky nav isn't sticking. This makes it stick once more!

but why?

It got wrapped in a <div>, bruv


*: Add ignore_changes to lifecycle block for OS images

Configures TF lifecycle block to ignore changes to the OS image on each platform.
Should fix the problem referenced here: https://github.com/poseidon/typhoon/pull/76#issuecomment-365525232
This wasn't extensively tested, outside of the fact that I've used the lifecycle block and ignore_changes before in other projects.
@dghubble let me know if this looks sane to you.

I don't think this is needed, except perhaps AWS. I don't want to add bits that aren't fully understood.
AWS
I suspect it is needed on AWS because the AMI is always dynamically resolved in Terraform. A user chooses a channel (such as the default "stable"), deploys a cluster, retains the cluster until a new CL release occurs, and re-runs terraform apply. At that point Terraform re-evaluates the mapping from channel to actual AMI id, detects a change, and decides the instances should be replaced. This is undesired since controller nodes should not be replaced, plus node upgrades can already be handled by the CLUO addon.
"ami-65269d1d" => "ami-fc01ba84"

I've left an AWS cluster running with CL alpha to be able to verify this buggy behavior and test just the AMI fix.
Others
On Digital Ocean, images like "coreos-stable" are created via the DO API (no dynamic resolution) so I've yet to see a case where DO will destroy existing nodes upon new images becoming available in a channel.
On Google Cloud, docs currently recommend choosing exact images (gcloud compute images list | grep coreos) which avoids any issues. Its possible to specify "coreos-stable" to the GCP API for use in the controller image and worker instance template. I'm testing this out. I've yet to see GCP destroy existing nodes upon new images becoming available in a channel, but will report if its safe to switch from exact images to "coreos-stable", etc.

There is indeed a bug on AWS (regression, since old controller ASGs had the ignore_changes). The AMI id changes since the channel is evaluated client-side. I've taken just the AWS controller fix in c8313751d7ec4af5766cc93c7cd29ccbc2cb7a7d.
I'm not able to demonstrate this fixes the issue because going from a hash without the ignore_change to a hash with the ignore_changes after the AMI change still shows a diff that causes controller replacement. I suspect ignore_changes has to be initially present. I've deployed a fresh test cluster to catch the next alpha release cycle to verify.

Merged c8313751d7ec4af5766cc93c7cd29ccbc2cb7a7d


keep alive

It would be cool if the client could implement a keep alive and have that be configurable as a command line option.

👍

This would still be cool 7 years later.  :)

Added this in a fork; and opened a PR here to merge it in.  https://github.com/websockets/wscat/commit/da65d125312cc8f55ef0fcbd126f01dbdc889911


Use Base instead of head repository

In the script the head repository is used to determine which branch is the default branch and should not be deleted.
However if the PR is made from a fork the head repo will point to the fork and thus the default branch could be different.
It might tie in with #19

Nevermind, I missed that it will also attempt to delete the branch on the HEAD repo.
The action would still fail then as we don't have enough permissions to delete branches on forks.
Maybe it makes sense to not do anything if the PR is forked?


KeepAlive with keyed child and scoped style not working

Version
3.0.0-beta.18
Reproduction link
https://github.com/danyadev/vue3-bug
Steps to reproduce
Double click on the button and look in DevTools
What is expected?
no changes
What is actually happening?
the text "Foo" disappeared and an error appeared in the console:
TypeError: Cannot read property 'subTree' of null (runtime-core.esm-bundler.js?5c40:208)
    at move (runtime-core.esm-bundler.js?5c40:3677)
    at Object.sharedContext.activate (runtime-core.esm-bundler.js?5c40:4330)
    at processComponent (runtime-core.esm-bundler.js?5c40:3196)
    at patch (runtime-core.esm-bundler.js?5c40:2857)
    at componentEffect (runtime-core.esm-bundler.js?5c40:3384)
    at Object.reactiveEffect [as update] (reactivity.esm-bundler.js?a1e9:42)
    at updateComponent (runtime-core.esm-bundler.js?5c40:3273)
    at processComponent (runtime-core.esm-bundler.js?5c40:3203)
    at patch (runtime-core.esm-bundler.js?5c40:2857)
    at patchBlockChildren (runtime-core.esm-bundler.js?5c40:3128)

However, this is not the only problem with Keep-Alive. This is the second unplanned problem when trying to reproduce another bug:
(This is most likely due to the fact that there is no check for the lack of a deactivated hook)

In the near future, I hope I will argue this too. The difficulty may be that I use Keep-Alive with the beta version of the vue-router


fix(tsc): point to shimmed tsc entry point to support ts 5.7

Typescript 5.7 uses the tsc.js entrypoint for handling the node compile cache. This fix points to the new _tsc.js entry point but doesn't handle anything regarding the node compile cache. This needs to be looked at in a future release.
Resolves https://github.com/vuejs/language-tools/issues/5018

Won't that break in older typescript versions instead?

You're right - that was an early Monday morning PR. Let me have another look

I tried this fix on my pipeline but it throws the following error:
TypeError: Invalid Version: 5.7
 at new SemVer (/app/node_modules/.pnpm/semver@7.6.3/node_modules/semver/classes/semver.js:38:13)
 at compare (/app/node_modules/.pnpm/semver@7.6.3/node_modules/semver/functions/compare.js:3:32)
 at Object.gte (/app/node_modules/.pnpm/semver@7.6.3/node_modules/semver/functions/gte.js:2:30)

Seems like it should be 5.7.0...

what is blocking this PR from being merged?

what is blocking this PR from being merged?

At least 2 approving reviews are required by reviewers with write access.

Any idea when this is going to get merged? I feel this is pretty important to get out there.

At least 2 approving reviews are required by reviewers with write access.

Since @zhiyuanzmj and @KazariEX have both approved, this requirement is now fulfilled.

@davidmatter could you please resolve lockfile conflicts while we wait?

I hate to be a pain on an OS project, but respectfully, there needs to be a sense of urgency to get this merged and released. This is blocking upgrade to TypeScript 5.7, and other dependencies that have already been upgraded for TS 5.7.

I hate to be a pain on an open source project, but respectfully, there needs to be a sense of urgency to get this merged and released. This is blocking upgrade to TypeScript 5.7, and other dependencies that have already been updated for TS 5.7.

And this is not the first time this happens here...

You can use pnpm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@b8befb2 to fixed it temporarily.

Any idea when a versioned release on npm will follow? At the moment this problem blocks a lot of possible upgrades to TypeScript 5.7.

v2.2.0 was released containing this fix :partying_face:


added the font Futura to the left and right menus

Futura is the font that is used by the Greater Chicago Food Depository for their branding and website.  Updated the left & right menus with this font.


Separate chapter 1 and 2 a little bit

Closed in https://github.com/bjartnes/http-workshop/commit/b11a48b07e81139a46d760269ff1c4774fb73249


Gen2: ImageManip rotated/arbitrary cropping

Add types defined similar to some OpenCV ones:

Point2f: {float x, y;}
Size2f: {float width, height;}
RotatedRect: {Point2f center; Size2f size; float angle;}

And for arbitrary cropping, I was thinking on defining a sequence of 4 points in clockwise order forming a quadrilateral, that would get mapped to a rectangle, whose size we specify (so resizing + other warp transforms can be applied). First sequence point would get mapped to the top-left corner of the rectangle.
 0___1       0 ____ 1
 /   \   ->   |    |
/_____\       |____|
3     2      3      2

These are still open to ideas for improvement.

Does the intermediate rectangle size adds any additional benefits compared to just the final output size?

Does the intermediate rectangle size adds any additional benefits compared to just the final output size?

Does the intermediate rectangle size adds any additional benefits compared to just the final output size?

For the rotated rectangle (center, size, angle), it describes the crop area, that can be further resized.
For the quadrilateral (that I renamed it now to warpFourPoints), I removed the size specification, and it is auto-computed based on the points geometry, if the final resize is not specified.


Azure Machine Learning Remote Connection to Compute fails

Issue Type: Bug

Login to Azure with Azure Account Extension to 0.9.11 (the Version 0.10 does not work)
Select Subscription
Select Machine Learning Workspace
Select Compute Instance
Klick Connet to Compute Instance
--> Installation of Server fails after n retries.

VS Code version: Code 1.64.2 (f80445acd5a3dadef24aa209168452a3d97cc326, 2022-02-09T22:02:28.252Z)
OS version: Windows_NT x64 10.0.19044
Restricted Mode: No
Connection to 'vscode-remote' could not be established

System Info

Item
Value

CPUs
Intel(R) Xeon(R) E-2176M  CPU @ 2.70GHz (12 x 2712)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.52GB (15.37GB free)

Process Argv
--crash-reporter-id 0a3d6d07-5328-46de-920b-36ea2cb368d3

Screen Reader
no

VM
0%

Connection to 'vscode-remote' could not be established
Extensions: none
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstartedc:30433508
vsclayoutctrc:30448490
dsvsc008:30440022
pythonvsnew555:30442236
vsbas813:30436447
vscscmwlcmc:30438804
helix:30440343

We have written the needed data into your clipboard because it was too large to send. Please paste.

We think it is a firewall problem on our site. So we will investigate that part first. I close this ticket.


Fix for deserialization of BroadcastTx which was missing the type byte.

This fixes an issue when deserialising a BroadcastTx json-rpc request over websockets.
Until 0.11.4, such json would be valid:
{"id":"57EC1D39-7B3D-4F96-B286-8FC128177AFC4","jsonrpc":"2.0","method":"erisdb.broadcastTx","params":[2,{"address":"5A9083BB0EFFE4C8EB2ADD29174994F73E77D418","data":"2F2397A00000000000000000000000000000000000000000000000000000000000003132","fee":1,"gas_limit":1000000,"input":{"address":"BE18FDCBF12BF99F4D75325E17FF2E78F1A35FE8","amount":1,"pub_key":[1,"8D1611925948DC2EDDF739FB65CE517757D286155A039B28441C3349BE9A8C38"],"sequence":2,"signature":[1,"B090D622F143ECEDA9B9E7B15485CE7504453C05434951CF867B013D80ED1BD2A0CA32846FC175D234CDFB9D5C3D792759E8FE79FD4DB3006B24950EE3C37D00"]}}]}
In 0.12.0, the "params" value is wrongly expected to be a dictionary instead of the correct [ type, {dict}].

Thanks for this. Indeed we seemed to be assuming a CallTx, whereas with this change it can be any transactions type.
I'm a little wary of this change though because presumably it will break what our javascript libraries must be doing for 0.12. @NodeGuy - what do you provide for "params" when calling rpc/v0 from your libaries? @benjaminbollen can you remember why this was like this?

Silas,
It's a bit more than just a change from always assuming a CallTx to handling any types of Tx. The json representation of the asummed CallTx is also not consistent with how it's expected in the wire protocol (see txs/tx.go file, where the concrete type is defined for the wire protocol).
Ideally, this regression (introduced in 0.12.x) can be fixed for 0.16.0.
The way transaction types are handled (array with type byte followed by payload) is exactly the same as how pubkeys and signatures are handled so it should not be too hard to bring in line.
Let me know if/how I can help.
Alex

On 25 Jan 2017, at 17:11, Silas Davis<EMAIL_ADDRESS>wrote:
Thanks for this. Indeed we seemed to be assuming a CallTx, whereas with this change it can be any transactions type.
I'm a little wary of this change though because presumably it will break what our javascript libraries must be doing for 0.12. @NodeGuy - what do you provide for "params" when calling rpc/v0 from your libaries? @benjaminbollen can you remember why this was like this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I noticed that the RPC broke with 0.12 because the type bytes are no longer expected.  I mentioned this on Slack but got no response so I threw them all out on the JavaScript side.

Here's what's provided for params:
    this.server.transact({
      priv_key: privKey,
      address,
      data,
      gas_limit: gasLimit,
      fee
    }, callback)

https://github.com/eris-ltd/eris-db.js/blob/ab3c1b4cd34a4ab4526cfb9f6cab5abbbb1dce3e/lib/unsafe.js#L82-L88

David, awesome that you know exactly where the changes are. Could they be reverted for 0.16.0?
Thx,
Alex

On 25 Jan 2017, at 19:51, David Braun<EMAIL_ADDRESS>wrote:
Here's what's provided for params:
this.server.transact({
  priv_key: privKey,
  address,
  data,
  gas_limit: gasLimit,
  fee
}, callback)

https://github.com/eris-ltd/eris-db.js/blob/ab3c1b4cd34a4ab4526cfb9f6cab5abbbb1dce3e/lib/unsafe.js#L82-L88
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Alex,
This is my fault, I got this mixed up in the 0.12 release. This RPC is marked for deprecation, but it is more complete to consider reverting it, before doing so.  I will weigh in the opinion of the JS libs, but it seems a valid request.

Awesome. you make my evening :)

On 25 Jan 2017, at 22:56, Benjamin Bollen<EMAIL_ADDRESS>wrote:
Hi Alex,
This is my fault, I got this mixed up in the 0.12 release. This RPC is marked for deprecation, but it is more complete to consider reverting it, before doing so. I will weigh in the opinion of the JS libs, but it seems a valid request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/eris-ltd/eris-db/pull/453#issuecomment-275245375, or mute the thread https://github.com/notifications/unsubscribe-auth/AQPPLX8M8KWiWORY9N3SGPiwniXvVm8Nks5rV8UDgaJpZM4Ls2F9.

Strictly speaking we can merge this without breaking the JS libs as they call the transact method - not the broadcast method - but it is better to reduce complexity and have it aligned for less headaches.

Actually the JavaScript libraries never sent the type byte so there's nothing for me to revert.

I wanted to merge this into a feature branch and then we can work on it?

good idea

@silasdavis, yes, I think you are right, we can just use the DecodeBytes function.


feat: reorder collections filters

The type of this PR is: Enhancement

This PR resolves FX-3164
Description

Reordered collection filters to remain consistent with desired order.
Added "Artists" to filter list.
Updated jest test to reflect order change.

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Reorder filters on collection screen for iOS and Android apps - rquartararo

iOS user-facing changes

Android user-facing changes

Dev changes

Screenshots

This PR contains the following changes:

Cross-platform user-facing changes (Reorder filters on collection screen for iOS and Android apps - rquartararo)

  Generated by :no_entry_sign: dangerJS against f2af436fbe7235e96387b256035ddde7660a2cee


How to run Atom as root? - Linux

I'm aware that we should avoid sudo atom since it'll write to the users ./atom in their home directory as root which'll cause problems when not running atom as root. Normally you'd use gksu/kdesu or the newer polkit/policykit with pkexec. The former does nothing, I setup a policy file for polkit and everything seemed good, Atom opened like a fresh install with no packages or past working tabs open. However I was unable to save a file getting a permission denied error. This worked fine with Gedit using polkit I could run pkexec gedit and save a file in the same location as root, with pkexec atom no file was saved as myself or root, just running atom would allow me to write a file as myself.
I believe this might have something to do with how Atom launches via a shell script instead of a binary directly? Would anyone know a way to fix this so I can use Atom for editing root owned files too?
I've got a thread on reddit seeking help as well: https://www.reddit.com/r/Atom/comments/42doe4/linux_running_atom_as_root/

gksu atom does nothing, gksudo atom will run Atom as root, but has the same problems as my pkexec atom approach with permission to save being denied.

I am running atom.io on Linux Mint and am having the same problem. I run atom with gksu and find that atom does not use the elevated permissions granted to it. It continues to be refused write permissions on files that it should have full access to. How do we get around this issue?

It sounds like https://github.com/atom/atom/issues/4115 is really what you're looking for? The feature isn't added yet, but if Atom automatically prompted for escalation and allowed you to save files, would that cover your use case?

@lee-dohm that sounds more than what I'm looking for rather than needing to run Atom as a whole with elevated privileges via pkexec/polkit. Though in some cases with Linux certain files are not visible or writable to unless you're accessing the file system as that user or a user that belongs to a certain group. For example VMWare if running as root will not have it's log files available to my user, I have to open the file browser with root rights for the log files to be visible.
Most of the time though any files I need to edit with privileges  will not have that issue, normally a config file that'd be more pleasant to use Atom with :)
@siteleas  you're granting rights to the wrapper script that launches Atom far as I understand. You'd need to edit the shell script that your launcher/terminal runs to give rights to the actual Atom application that it launches. However without a bit more work, it'd always launch Atom with gksu or pkexec, etc...plus if a Atom update makes changes to that file you'd have to patch it again.

i have able to use super user privilages using this command line you should try this to
Sudo atom

@Thaall I don't know if anything has changed since, but if you read the description rather than just the title... you'll see that atom would call a shell script not a binary, the wrapper shell script then calls the actual binary.
Either sudo atom will also run the binary as root but potentially cause the problems writing root only files into your users atom configs (in which case your Atom instance probably doesn't have all the packages installed and being configured like it was withoout sudo) or it runs the wrapper as root but not Atom as I described with the proper methods to run GUI apps as root. Either or is bad.
DO NOT RUN ATOM WITH SUDO

Ahh now i see the problem LOL i just read the topic and answered  stupidly and thanks for heads-up

There isn't a good way to run Atom as root and probably shouldn't be given that it has no protections against malicious code. Elevating in the moment to save individual files should resolve the use cases that we want to support.

@lee-dohm Recently a well known dev in KDE community wrote a blogpost about providing root for read/write of files only when needed while keeping the rest of the application non-privlidged. Perhaps sudoedit could work like described there? Or PolKit/pbexec?

Hi. I don't know if this will help anyone here,
But my scenario is that I just wanted to develop and test files in Apache Server's /var/www/html folder. So, I just provided all read write access to my Atom using "chmod 777 atom" .It has started to compile and write code in the directory.
It solved my problem.

Kudos to KudosAbhay.  The chmod 777 atom worked.  One command that might help is 'whereis atom' which should list the location of your files so you can chmod the right files :)


Repeatedly running cargo fmt does not reach a fixpoint

Input (reduced via creduce, so no longer valid Rust code, but it was at one point in time):
impl a {
    fn b() {
        {
            {
                self.filter(|base| {
                        ctx.resolve_type(base.ty).has_vtable(ctx)
                    })
                    .c > e = d
            }
        }
    }
}

With this rustfmt.toml:
max_width = 80
format_strings = false
fn_brace_style = "SameLineWhere"
item_brace_style = "SameLineWhere"
struct_lit_multiline_style = "ForceMulti"
where_trailing_comma = true
reorder_imports = true
reorder_imported_names = true
normalize_comments = false
write_mode = "Overwrite"

Steps to reproduce:
$ cargo new tempcrate
$ cp $TESTCASE tempcrate/src/lib.rs
$ cp $RUSTFMT_TOML tempcrate/rustfmt.toml
$ cd tempcrate
$ git add .
$ git commit -m "Initial commit"
$ cargo fmt
$ git commit -am "Running cargo fmt once reformatted"
$ cargo fmt
$ git commit -am "Running cargo fmt a second time ALSO reformatted"
$ git diff HEAD^^ # No diff! Reformatted back to the initial commit! Infinite loop, no fixpoint of formatting

cc @nrc

Let me try and re-reduce while keeping the reduced file valid Rust

Here is a valid Rust file that exhibits the same behavior:
struct Base {
    ty: Ty
}

#[derive(Copy, Clone)]
struct Ty;

impl Ty {
    fn has_vtable(&self, ctx: &CodeGenContext) -> bool {
        unimplemented!()
    }
}

struct BaseMembers;

impl BaseMembers {
    fn base_members(&self) -> Vec<Base> {
        unimplemented!()
    }
}

struct CodeGenContext;

impl CodeGenContext {
    fn resolve_type(&self, t: Ty) -> Ty {
        t
    }
}

trait CodeGenerator {
    fn codegen(&self, ctx: &CodeGenContext);
}

impl CodeGenerator for BaseMembers {
    fn codegen(&self, ctx: &CodeGenContext) {
        if false {
            if false {
                let some_variable = self.base_members()
                    .iter()
                    .filter(|base| {
                        ctx.resolve_type(base.ty).has_vtable(ctx)
                    })
                    .count() > 1;
            }
        }
    }
}

Also, it seems like it would be a good idea for the extant tests (or test runner) to try reformatting again after formatting the initial time, and assert that there is no diff.

@fitzgen Also seems like a cool use of a fuzzer (cc @frewsxcv @Manishearth @nagisa).

@eddyb this is actually derived from rust-bindgen, not generated by a fuzzer. I figured a multiple thousands of lines test case wouldn't be appreciated, hence creduce to take the large test case and make it into a smaller test case :)

(potential)

Ah ok -- yes, it would be great to start fuzzing rustfmt :)

At least some part of the config seems necessary, I can't repro with the default settings.

I suspect it is a combination of the column width and maybe some of the others. I did not creduce the rustfmt.toml :-P

This should be fixed by https://github.com/rust-lang-nursery/rustfmt/commit/c7a33062e25e1d80545ae6094d3faa99348c79e1Please re-open if not.


Add currency sums to docs as in beta

Mention currency sums as a thing that exists and can be implemented upon request
More detail can be added here

#2185  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @liz-statsig and the rest of your teammates on  Graphite

🚀 Deployed on https://670da82f1fbea490c8bc1212--cozy-fox-0defec.netlify.app

Merge activity

Oct 15, 6:50 PM EDT: A user started a stack merge that includes this pull request via Graphite.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/232 is merged into live branch.
Auto archive content to https://github.com/OPS-E2E-PPE/docs-archive-test-target.git

Docs Build status updates of commit 3e44e7b:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error]

Cannot sync git repo to specified commit because branch Archive_master_2019-11-21-08-37-21 has been deleted or has been force pushed: fatal: couldn't find remote ref refs/heads/Archive_master_2019-11-21-08-37-21

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


add mp.jwt.verify.audiences requirement and tests

addresses #121

@chunlongliang-ibm  fyi

closing, will resubmit another with the correct signoffs.

@brutif Np, please address the above comments too


Does anyone who know not opening the shared post url?

below is my shared post url.
But, i says an invalid url. So, i couldn't use several apis.
who knows?
https://www.threads.net/t/Cu_Xnw7xwiV/?igshid=NTc4MTIwNjQ2YQ==

afaik that's a problem/bug with Threads itself

Thanks❤
2023년 7월 23일 (일) 오후 10:23, Junho Yeo @.***>님이 작성:

afaik that's a problem/bug with Threads itself
—
Reply to this email directly, view it on GitHub
https://github.com/junhoyeo/threads-api/issues/244#issuecomment-1646840061,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABDCVD7KRLVQLCEX6FJ6LV3XRUQVLANCNFSM6AAAAAA2T4ZAMI
.
You are receiving this because you authored the thread.Message ID:
@.***>


Release CI: sign windows installer & fix release workflow

It closes #162
Please, check out the automatically created draft (also it contains links to artifacts): https://github.com/spacemeshos/smapp/releases/tag/untagged-6fc496a0120f26073f39
And few questions (please answer by numbers):

Right now this workflow is triggered by any tag. Should this workflow be triggered only by v*.*.* (release) and v*.*.*-* (pre-release) tags?
What program name we should provide? (the more detailed question was here: https://github.com/spacemeshos/smapp/issues/162#issuecomment-893833373)
To bundle a release I download the latest release of go-spacemesh (not pre-release). Is it correct?
In continuation, for PR builds I use any latest release (pre-release or release). And it makes us possible to test new features using bleeding-edge builds of Node. So builds for PR and release builds may work differently, and this is a problem. However, I have an idea of how to manage it:

Release flow

Create release-* branch
Commit changelog / version bump / something else
Open a PR with the name "Release vX.X.X".
It runs PR-build GHA workflow with one difference (if branch name starts with release-): it downloads the latest release (not pre-release) of go-spacemesh
When the bot posts a comment with links to artifacts (unsigned yet), we should test it.
When we made sure that there are no errors, push the tag.
It triggers the building and signing process (release workflow).
When we got a release draft, we can test it again (if we want) and publish the release.

Do you agree with it?
If so, I need up to a couple of hours more, to implement it.

Right now this workflow is triggered by any tag. Should this workflow be triggered only by v*.*.* (release) and v*.*.*-* (pre-release) tags?

I think it is good to trigger it with v prefix in the tag.

What program name we should provide? (the more detailed question was here: Sign windows installer #162 (comment))

Spacemesh App

To bundle a release I download the latest release of go-spacemesh (not pre-release). Is it correct?
I think that what we want is to be able to bundle any go-spacemesh release by tag and not just assume latest. It will give us more flexibility.

In continuation, for PR builds I use any latest release (pre-release or release). And it makes us possible to test new features using bleeding-edge builds of Node. So builds for PR and release builds may work differently, and this is a problem. However, I have an idea of how to manage it:

I think we should always config a smapp release to work with a specific version of go-sm github release and never assume latest. I think you want to have a go-sm release string param in GHA and use that. If we want to change PRs to work with a different node release then we can just change this param in the GHA script.

Release flow

Create release-* branch
Commit changelog / version bump / something else
Open a PR with the name "Release vX.X.X".
It runs PR-build GHA workflow with one difference (if branch name starts with release-): it downloads the latest release (not pre-release) of go-spacemesh
When the bot posts a comment with links to artifacts (unsigned yet), we should test it.
When we made sure that there are no errors, push the tag.
It triggers the building and signing process (release workflow).
When we got a release draft, we can test it again (if we want) and publish the release.

Do you agree with it?
If so, I need up to a couple of hours more, to implement it.
Yes with the change to always use a specific go-sm release from a string param in GHA. e.g. v0.1.24.

I think we should always config a smapp release to work with a specific version of go-sm github release and never assume latest. I think you want to have a go-sm release string param in GHA and use that.

So in this case there is no need to make special rules for releases, like release-* branch name, because it will work the same for all of PRs. But I'll create a page in Wiki when we'll finish with this PR, called "Release process".
To achieve the same and fixed version of go-spacemesh, I created a /node/use-version file which contains a string with a version like a tag in GitHub releases. E.G. v0.1.45 is the current latest one. And both of workflows will look on this file to fetch the needed version of Node. Also, this file will be used to cache go-spacemesh.
Also, I've added yarn verify:node-version script, which has already been integrated into yarn start and yarn build scripts, which checks that the specified version matches with the version of Node. And then it can show three types of messages: OK (matches), WARNING (does not match, but NODE_ENV=development), ERROR (does not match, production). In the latest case, it will exit with error code 1. So it will fail CI workflow and pay attention to this error.

🙌

Everything is done.
Here is a link to the release draft: https://github.com/spacemeshos/smapp/releases/tag/untagged-23c177f2843fb7ce58e9
Before the merge, I'll remove the tag and delete this draft.
P.S.
I hope we got a lot of space on GCS and it doesn't cost much. :)

Regarding the releases, it will be great if this minor issue can be fixed: https://github.com/spacemeshos/smapp/issues/751

I think it will be good if you can provide short summary in repo's readme regarding how release artifacts for dev builds  and production builds work.

I hope we got a lot of space on GCS and it doesn't cost much. :)

Can't we just periodically cleanup old builds from that share?

Can't we just periodically cleanup old builds from that share?

We can do it automatically without special jobs in CI. GCS has a built-in feature "rules". So we can create a separate bucket for temporary artifacts (like PR builds) and set the deletion rule.
I just need another bucket secret to upload PR builds in this bucket and this thing will be done :)
Release builds use a tag name, so if we had to re-push the same tag a few times — artifacts should be overwritten.

@avive I've done with #751 and also updated README.md
Please, take a look at the two last commits (related to README.md) and if everything is fine, please approve PR.
Then I'll merge it.


⚖ Register Validator: CryptoSailors🐬

Network Choice
nemeton-1
Who are you?
CryptoSailors: https://cryptosailors.tech/
gentx
{"body":{"messages":[{"@type":"/cosmos.staking.v1beta1.MsgCreateValidator","description":{"moniker":"CryptoSailors","identity":"8F292E79DCDEF143","website":"https://cryptosailors.tech/","security_contact":"","details":"Team of professional validators with best digital solutions. Please visit our Telegram🔹https://t.me/CryptoSailorsAnn🔹"},"commission":{"rate":"0.100000000000000000","max_rate":"0.200000000000000000","max_change_rate":"0.010000000000000000"},"min_self_delegation":"1","delegator_address":"okp41sfzct8njqya3a5qerg09a0f8pd3ul4y9gxmlrx","validator_address":"okp4valoper1sfzct8njqya3a5qerg09a0f8pd3ul4y9aptka8","pubkey":{"@type":"/cosmos.crypto.ed25519.PubKey","key":"wGb6CClMuXZfYCREmxYqWdskOrgCGHgU7IObOaSHZFE="},"value":{"denom":"uknow","amount":"10000000000"}}],"memo":"6916e6e4d7a313abc759286f995ac29f58792f19@<IP_ADDRESS>:26656","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"Az720ftzvOLux4purWluN1O//OGsF+GqXGDPyEA7XEia"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["vC3EJhjvCI91ibz3yLYlOjOsEA377FEkOdl6CiQmklRPX1r0K+T9RcmW0czi1m7Fpv/yFa5k/fRhtKXBDbbUQg=="]}

😉 Here is the corresponding PR: https://github.com/okp4/networks/pull/187


lockbox and pg enums

Hi!
I have several questions about rodauth:
1 - is it possible to use it with https://github.com/ankane/lockbox
2 - how to configure rodauth to work with native postgresql enums (e.g. in account statuses)?

Yes, it should be possible to use Lockbox. Since Rodauth doesn't use Active Record models, you'll need to override correct Rodauth methods to perform encryption/decryption.

Assuming the following Lockbox & Blind Index setup:
class Account < ActiveRecord::Base
  has_encrypted :email
  blind_index :email
end

I believe the following Rodauth configuration should work:
save_account do
  account[:email_bidx] = generate_bidx(account[login_column])
  account[login_column] = encrypt(account[login_column])
  super()
end

account_from_login do |login|
  account_table_ds
    .where(email_bidx: generate_bidx(login))
    .where(account_status_column=>[account_unverified_status_value, account_open_status_value])
    .first
end

verify_login_change_old_login { decrypt(super()) }

email_to { decrypt(super()) }

auth_class_eval do
  private

  def _update_login(login)
    super(encrypt(login))
  end

  def encrypt(string)
    Account.generate_email_ciphertext(string)
  end

  def decrypt(string)
    Account.decrypt_email_ciphertext(string)
  end

  def generate_bidx(email)
    Account.generate_email_bidx(email)
  end
end

Yes, you just need to override the values Rodauth is writing to the database:

account_unverified_status_value "unverified"
account_open_status_value "verified"
account_closed_status_value "closed"


Cut Rumble

First of all, thank you for your great work. Finally I found a mod that allows me to reduce the rumble. Currently, the reduction of the rumble does not affect the menu and also not when I cross the lightsabers. Would it be possible to extend the rumble reduction so that it is active everywhere?
I play with the old Oculus Touch Controllers, which unfortunately vibrate unbearably loud that I can't play with them without annoying other people in the same room.

For now your best bet is disabling Saberclash entirely (Thats what the effect is called when the sabers touch). I'll consider making that rumble configurable.
As for the Menu rumble, thats already pretty short - Is that really an issue? Would probably not be too hard to add a setting for it, just trying to not add super niche stuff into the already pretty big list of tweaks

As for the Menu rumble, thats already pretty short - Is that really an issue?

Thanks for your quick reply. It would also be enough for me if I can completely disable the rumble effect in the menu, if that is easier to implement. My controllers make really strange noises.  Here is an example of how loud my controllers get in the game Space Pirate Trainer.
https://youtu.be/gC80fgmOg10

But surely thats not the Rumble that you get from hovering UI elements right? I dont think I would add something in to disable Menu vibrations - Thats just a way too niche thing unfortunately, but here's a quick standalone mod that entirely disables haptics
DisableUIRumble.zip
:

Not so extreme but loud enough that someone in the same room can wake up from the noise.
In the original Beat Saber release from May 2018, the vibrations were also much more subtle. I suspect in subsequent versions the vibrations were increased because the motors in the Quest 1/2 and Rift S controllers are weaker than those in the Oculus Touch controllers.
I wish Oculus had included the ability to globally reduce or disable force feedback in the software for the Oculus Rift, but unfortunately they have completely stopped development for the Oculus Rift software. In the software for the Oculus Quest, for example, there is the possibility to set the vibration effect globally for all games.
As a Rift 1 user for many games I always have to ask the developers if they can integrate this feature into the game (most of the smaller developer teams respond to customer feedback) or hope for mods like yours.
Update:
I tried the DisableUIRumble.dll but it had no effect on me in the menus the controller still vibrates when I go over menu buttons. Is there anything I need to do besides copy the DisableUIRumble.dl to the plugin folder?

Oh nah I messed up, this should work: DisableUIRumble.zip

It works fantastic. Now I can play Beat Saber again in the evening. Thanks for your great work.

I still have one small wish if it is not too much trouble. Is it possible to deactivate the vibration when contacting a wall so similar to disabling Saberclash?

Thats already an existing option

Oh crap I somehow overlooked that :)

Thank you for your great work kinsi. Just out of curiosity , i noticed the rumble duration option is not around anymore. Is there any plan of adding that option back.

If that the case. I assume normal cut at 100% is equivalent to default vibration and duration when the mod is off. Can the max be extended over 100%. In previous version , I always have my vibration duration longer then default around (0.35sec~0.37sec)

For the lower two sliders I've allowed going over 100% because those are rather short by default and one might possibly want to extend those, but 100% for the cut rumble is like 1/10th of a second - Thats already pretty long.
Such long haptics can cause temporary loss of haptics or even tracking issues, specifically on faster maps, which is why I didnt really consider allowing the cut rumble to go above 100%

Maybe could allow user to increase above the limit. Provided initial warning notice is displayed on menu.

I can see myself allowing the slider to go up to effectively .2 seconds but definitely not beyond that


disabled styles for slider not working

Although the style code for disabled is written in the slider's code, it does not work.
Here's the link to reproduce it, https://stackblitz.com/github/hsuanxyz/shadcn-ui-slider-issue?file=pages%2Findex.tsx

+1

@grayashh when will it be implemented?

I have the same problem. Would really love for this to be fixed

The issue is that the Tailwind classes that were chosen are looking for a disabled attribute on the element, but Radix is actually setting a data-disabled attribute.  Also, the opacity-50 class should not be on the thumb, but on the root.  This is what you need to do...

Add data-[disabled]:opacity-50 class to the <SliderPrimitive.Root /> component
Remove disabled:opacity-50 class from <SliderPrimitive.Thumb /> component
Replace disabled:pointer-events-none class on <SliderPrimitive.Thumb /> component with data-[disabled]:pointer-events-none

PR #3436

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.


http://devopy.io domain 404 error

Cant u send  instruction?
http://devopy.io/setting-up-zabbix-alertmanager-integration/

@devopsjonas Seems to be still down unfortunately.

Hey,, we are currently reworking the website and it should be back up in ~2 months.


fix(doc): Fix description of hooking Jasmine reporter

The Jasmine reporter-hooking example didn't work.  Some paste-o's when
copying it from jasminewd/index.js, I think.

Never mind.  Sorry for the confusion.

I was misled by this jslint warning on the code:  Weird construction. Is 'new' unnecessary? (W057).
Should anyone else run into that in the future, the supernew jshint option will suppress this warning.  The new is definitely necessary in this case.


src/stan/prob/transform.hpp: error handling in corr_matrix_free

exception handling is unlike other functions in Stan
It's probably not the only place where it's different. Should make it look like the rest of our code base.

This issue was moved to stan-dev/math#34


Clarify client best practice

Answering @jmeistrich's question here.

Great! FYI a similar sentence is also on the Next/Nuxt/Vue docs.


⚠ Bofrost.fr has degraded performance

In fc848f1, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1624 ms

Resolved: Bofrost.fr performance has improved in df49bc4.


About Dataset

Thank you for your work. Which dataset of nuscenes' dataset did you use specifically, was it Full dataset (v1.0).US? The URL you gave about obtaining the data set is not accurately accessible

yes, it is the Full dataset (v1.0).US.

Too many choices, which should I download

Trainval?

and LIDAR?

and LIDAR?

Lidar blods?

Hi, did you know it now? @Lincoln20030413


missing Markers

markers how up  on the frequency display once the plugin is loaded but i have no ability to edit or add frequencies.
i have a empty " Markers " dialogue box, clicking on it  and nothing displays

I have the same problem, the way I got it to reappear was,

Hover over SDRUno Icon (When running) on the taskbar
Right click on the 'MARKERS' in the preview box, a context menu appears click on 'Move' (don't click any mouse buttons yet)
The mouse cursor moves to the top left of the screen with a move icon, I had to press the right arrow on the keyboard then without clicking mouse button drag the MARKERS window back into the centre on the desktop.
You should be able to now drag it to another position.
I am not sure why it exhibits this behaviour but I have to do this most times after launching SDRUno and trying to load the Markers plugin, but it works for me


Update build configuration wiki

The build configuration wiki doesn't state the deprecated status of FORCE_LIBUVC, FORCE_WINUSB_UVC and ANDROID_USB_HOST_UVC
It doesn't include the description of FORCE_RSUSB_BACKEND
https://github.com/IntelRealSense/librealsense/wiki/Build-Configuration

It looks as though the build configuration page was last edited in August 2019, whilst Librealsense version 2.30.0 where RSUSB began being used was released in November 2019.  So I will give this case a 'Documentation' label.  Thanks for your report!

Thanks @MojamojaK
I updated the wiki


Csv-Parser  Reading FFat file instead SD card

hello dear developer.
i need to Parse a  txt and or CSV  comma-separated file, I have been searching for an example code of this  CSV-Parser to read file from FILESYSTEM  FFat on my esp32  for the last 3 days with no success .
Is CSV-Parser only for Sd  ?
any reference for using the library from FFAt will be much appreciated.
Thanks, in advance for your time .
Ing Denis Thornhill

Hello, the library is mostly independent of underlying file storage. As long as you can read the file into a string (as a whole, or in parts), then you can supply it to CSV_Parser (either in constructor as a whole, or by using << operator and supply it in parts).
I never worked with FFat using esp32 but the following article looks straightforward:
https://www.mischianti.org/2021/04/06/esp32-integrated-ffat-fat-exfat-filesystem-6/

You could combine it with existing examples of CSV_Parser, so the return of the readString() method from image above would either go into constructor of CSV_Parser, or it would be inputted like:
csv_parser_object << testFile.readString();
These examples could be helpful:
basic usage
supplying csv by incomplete parts

Hello dear developer.
first of all thanks for your response trying to help me out.
I have to spend many days trying to figure out this situation, I have read and read, search and search and tried 100 different combinations and I can not reach my goal.
I have implemented a A.I neural cell on the esp32  wroom using AVR 8.1.5  and Arduino IDE 1.8.19.
My goal is to Load the weights of my A.I Scenario.
USING THE SD CARD IT WORKED LIKE A CHARM  (NO PROBLEM AT ALL)
BUT as my   Denis.csv file containing my comma-separated weights is so small I really need it on FILESYSTEM  INSTEAD   as in future will automatically update  FILESYSTEM file Denis.csv from an internet Remote server,
SO to go straight to the point :
When using SD card  , working Perfectly
 CSV_Parser cp(/*format*/ "ffffffffffffffffffffffff", /*has_header*/ true, /*delimiter*/ ',');          cp.readSDfile("Denis.csv");                  float *WW1 = (float*)cp["WW1"];               float *WW2 = (float*)cp["WW2"];
Now I want to use the same CSV-Parser to parse the same file, BUT NOW from my FILESYSTEM FFat where Denis.csv is uploaded and perfectly READ by the next code
`void parse_ai_weights() {
File readcsv = FFat.open(F("/Denis.csv"), "r");
if (readcsv){
Serial.println("Read file content!");
/// Serial.println(testFile.readString());
String ai_weights = readcsv.readString();
Serial.println(ai_weights);   ///prints on Serial Monitor   PERFECTLY
readcsv.close();

}
}`

SO I HAVE A String  ai_wheights  Containing all the data I need to parse.
All the rest I can handle, cause I use the CSV-Parser library almost daily.
BUT  I have not been able to correctly code CSV-Parser to read My String  ai_wheights to be parsed.
I Tried your proposal as like this  But does not compile
 CSV_Parser cp(/*format*/ "ffffffffffffffffffffffff", /*has_header*/ true, /*delimiter*/ ',');          cp << readcsv.readString();   ////FAILED       cp << ai_weights;   ////FAILED                float *WW1 = (float*)cp["WW1"];               float *WW2 = (float*)cp["WW2"];
So  I am kind of desperate Now, if  you  could  help me out  I will much appreciate
Denis.csv
please let me know as it looks you have more knowledge than  I do.
Many thanks in advance for your time and Kindness
Ing Denis Thornhill

Hello, here's a small example. First it creates a file using "writeFile". Then it reads it character by character and supplies it to the CSV_Parser object using cp << file.read();. Then it uses cp.print() to view all parsed values. Then it prints values from VV1 column only.
#include "FS.h"
#include "FFat.h"

#include <CSV_Parser.h>

void writeFile(fs::FS &fs, const char * path, const char * message){
    Serial.printf("Writing file: %s\r\n", path);

    File file = fs.open(path, FILE_WRITE);
    if(!file){
        Serial.println("- failed to open file for writing");
        return;
    }
    if(file.print(message)){
        Serial.println("- file written");
    } else {
        Serial.println("- write failed");
    }
    file.close();
}

const char *denis_csv = "WW1,WW2,WW3,WW4,WW5,WW6,WW7,WW8,VV1,VV2,VV3,VV4,VV5,VV6,VV7,VV8,UU1,UU2,UU3,UU4,UU5,UU6,UU7,UU8\n"
                        "1.529006002,0.253733553,0,0,0,0,0,0,1.284589032,-0.16966153,0.061992747,-0.446341058,-0.453974486,0.293160251,-0.174254381,1.332099744,6.326600076,1.477596343,-1.496865036,9.003172761,-1.129388801,-2.241994092,-0.106482536,0.333588426\n"
                        "-0.217656669,0.496886743,0,0,0,0,0,0,-2.521074192,-0.248332009,2.304620566,3.063565941,-0.084831135,-1.245491029,1.169079723,-2.772691784,15.6392119,-6.559343484,-0.76593996,16.95741907,-0.229103923,-2.174205059,-2.783387003,-4.153871339\n"
                        "-0.685878196,-1.69774026,0,0,0,0,0,0,0.75732003,-0.191953244,2.284465675,0.504071024,-0.457960533,-0.689415175,-0.432202133,-0.505708842,5.091135436,0.857673313,2.886192935,1.381541316,0.413169009,2.899088995,-0.156824798,0.450908032"
                        "-1.56897012,-0.582719571,0,0,0,0,0,0,0.756744231,0.020471757,-0.605422857,-0.580923655,-0.292100131,0.654582639,-0.195243403,1.491637782,0,0,0,0,0,0,0,0\n"
                        "-0.600424066,0.294622049,0,0,0,0,0,0,0.156895215,-0.376825887,0.834245199,0.470031922,-0.25945908,-0.135387552,-0.316315596,0.130135589,0,0,0,0,0,0,0,0\n"
                        "0.75991028,0.84727152,0,0,0,0,0,0,0.021394153,-0.539207383,3.405282902,0.530846276,0.258361585,-0.799486165,0.28407691,-1.038734802,0,0,0,0,0,0,0,0\n"
                        "-1.221449941,-0.028690932,0,0,0,0,0,0,-2.046529053,0.334116574,0.79527923,1.594805338,0.808990216,-0.38662376,1.547053763,-1.93526403,0,0,0,0,0,0,0,0\n"
                        "1.524834584,0.646203694,0,0,0,0,0,0,-1.670471979,0.298746015,1.407371203,2.497918847,0.234797764,-0.900750431,1.002674102,-2.564860142,0,0,0,0,0,0,0,0";

void setup(){
  Serial.begin(115200);
  if(!FFat.begin()){
      Serial.println("FFat Mount Failed");
      return;
  }

  writeFile(FFat, "/Denis.csv", denis_csv);

  CSV_Parser cp(/*format*/ "ffffffffffffffffffffffff");

  File file = FFat.open("/Denis.csv");
  if(!file || file.isDirectory()){
      Serial.println("- failed to open file for reading");
      return;
  }
  while(file.available()){
      cp << file.read();
  }
  file.close();
  cp.parseLeftover(); // needed after reading the whole file when the last line of the file doesn't end with "\n"
  cp.print(); // prints all parsed contents

  Serial.println("\nVV1 column:");
  float *VV1 = (float*)cp["VV1"];
  for(int i = 0; i < cp.getRowsCount(); i++) {
    Serial.println(VV1[i]);
  }
}

void loop(){

}

It outputs:
CSV_Parser content:
rows_count = 7, cols_count = 24
   Header:
      WW1 | WW2 | WW3 | WW4 | WW5 | WW6 | WW7 | WW8 | VV1 | VV2 | VV3 | VV4 | VV5 | VV6 | VV7 | VV8 | UU1 | UU2 | UU3 | UU4 | UU5 | UU6 | UU7 | UU8
   Types:
      float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float | float
   Values:
      1.53 | 0.25 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 1.28 | -0.17 | 0.06 | -0.45 | -0.45 | 0.29 | -0.17 | 1.33 | 6.33 | 1.48 | -1.50 | 9.00 | -1.13 | -2.24 | -0.11 | 0.33
      -0.22 | 0.50 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | -2.52 | -0.25 | 2.30 | 3.06 | -0.08 | -1.25 | 1.17 | -2.77 | 15.64 | -6.56 | -0.77 | 16.96 | -0.23 | -2.17 | -2.78 | -4.15
      -0.69 | -1.70 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.76 | -0.19 | 2.28 | 0.50 | -0.46 | -0.69 | -0.43 | -0.51 | 5.09 | 0.86 | 2.89 | 1.38 | 0.41 | 2.90 | -0.16 | 0.45
      -0.58 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.76 | 0.02 | -0.61 | -0.58 | -0.29 | 0.65 | -0.20 | 1.49 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | -0.60
      0.29 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.16 | -0.38 | 0.83 | 0.47 | -0.26 | -0.14 | -0.32 | 0.13 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.76
      0.85 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.02 | -0.54 | 3.41 | 0.53 | 0.26 | -0.80 | 0.28 | -1.04 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | -1.22
      -0.03 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | -2.05 | 0.33 | 0.80 | 1.59 | 0.81 | -0.39 | 1.55 | -1.94 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 0.00 | 1.52
Memory occupied by values themselves = 768
sizeof(CSV_Parser) = 40

VV1 column:
1.28
-2.52
0.76
0.02
-0.38
-0.54
0.33

The "writeFile" function I used is copied from Arduino IDE -> File -> Examples -> FFat -> FFat_Test which btw contains some more useful functions.

hi Mr michalmonday
I had had some busy days  lately
I am so sorry for the delay in responding to you and being thankful for your response time and explanation.
What I did to fix the problem was
I read my Denis.csv file, as usual, using FFAT
Then passed it to a string
Then passed the String to a CHAR   called buf using tochararray, and then CSV_PArser  did his job perfectly.

It worked perfectly,
probably is not the correct way of memory use, but later I cleared the variable . and keep going .
Many thanks again for your time and cooperation.
Any comment will be perfect, especially based on my lack of knowledge.
Thanks again, if you agree I will close the issue.
Denis Thornhill

Hello, just wanted to let you know that since version 1.0.0 (released today), it is necessary to cast the return of file.read() built-in method to (char) before supplying it to CSV_Parser using << operator, like:
while(file.available()){
    cp << (char)file.read(); // (char) is needed because file.read() returns integer
}

So I edited the example from my previous post. I added a note in README.md explaining why:

Before the 1.0.0 version, the cp << 97; expression would append letter 'a' (because '97' stands for 'a' in ascii table). From 1.0.0 version onwards, the cp << 97; is equivalent to cp << String(97);, it will append '97' instead of 'a'. That is correct behaviour in my opinion, however due to design of Arduino built-in "File.read()" method, which returns an integer, it is necessary to cast it's return (with (char)csv_file.read() as shown above), and problems may occur if some existing code (using this library) doesn't explicitly cast it.


Can't run template: LegacyForms is undefined

I've checked out master (9670d122aa17b3cc1d9d18fd83215eb77c934793), built it with yarn and yarn dev, and scp'ed it over to the grafana v6.7.3 plugins directory. Navigating to the plugin options or trying to add a datasource using the plugin results in the following error in the console:
Failed to import plugin module Error: "_grafana_ui__WEBPACK_IMPORTED_MODULE_2__.LegacyForms is undefined
  Evaluating http://dlt-monitoring-grafana-1.datto.lan/public/plugins/myorgid-simple-datasource/module.js
  Loading plugins/myorgid-simple-datasource/module"

you must run the plugin with grafana v7.0.0

Isn't v7 still in beta? Is there a commit that works with a stable version?
I also have an older plugin that uses the same {{LegacyForms}} object and fails with a similar error, so its not like this was added in v7... is it?

the developing doc and demo of grafana plugin is really tricky
the demo run with v7 is ok


feat(pbts): Make synchrony params adaptive

Closes #2184

PR checklist

[x] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments
[x] Title follows the Conventional Commits spec

I think this PR may solve #2432.
I've just created this issue to separate the documentation from the implementation.


refactor(material-experimental/mdc-table): share code between MDC and non-MDC versions of MatTableDataSource

blocked on https://github.com/angular/components/pull/20924

feedback addressed


Add METAR applet - weather reports for pilots

Description

METAR: Text weather report for airports in aviation.
Includes details like wind, visibility, clouds, temperature, all encoded in special positionals
uses the free and open beta.aviationweather.gov METAR api
Takes a station ID (usually an airport code, like KORD, KMCO or KDEN for Chicago, Orlando, and Denver respectively)
Wraps and creates multiple frames based on the length of the METAR, displaying for a given duration

Copilot

🤖 Generated by Copilot at fe71e28
Summary
:memo::recycle::zap:

Refactored and simplified the metar applet to use a different weather API and a smoother animation. Updated the manifest.yaml file with new applet metadata.

Oh we're the crew of the metar.star
We fetch the weather from near and far
We've changed the API and the widget too
And made the config easier for you

Walkthrough

Rewrite applet logic and use a different API (link)
Update manifest file with new applet name, summary, description, and author (link)
Change configuration schema to use station ID and seconds per page as inputs (link)

I have read the CLA Document and I hereby sign the CLA


TypeError: limitNumber.concat is not a function

Describe the bug
The following error occurs when launching the lambda stastics window:

at InvocationCountLCD.updateData (....): TypeError: limitNumber.concat is not a function

sls-dev-tools: v. 1.0.6

@TLaue We will look into and fix this issue for you, this appears to be happening when the invocations are over 999 in the last 12 hours

@TLaue Thank you for raising this issue, this is fixed in the latest release V1.1.1


Update documentation and ocamlformat pass

Not a good PR but a bedrock for a possible release.

I think this PR is done, @lyrm can you confirm that the documentation is good enough?


Bug: Frozen UI on lnd Unavailability

I've identified some example scenarios where you can freeze the Zap UI. To recreate these have everything setup correctly and then at certain points you will kill the connected lnd daemon.
These are complete freezes and you need restart Zap.
Scenerio 1:

Start Zap
Click "Pay"
Kill lnd
Insert lightning invoice into payment request field

Scenerio 2:

Start Zap
Click "Contacts"
Kill lnd
Click "Wallet"
Click "Requests"

Example Screenshot:

This looks to be fixed - the current behavior is that the action is attempted, then when it fails, an error header is shown:


Issue with createGenerateClassName

Steps to reproduce
I am using "@material-ui/core" version "4.10.2"
Link to live example: (required)
Steps:

Using Webpack Module Federation, create a Microfrontend with One Host and 2 Child apps

Add import as below
import {StylesProvider,createGenerateClassName} from "@material-ui/core/styles";

Add createGenerateClassName definition as below;

// HOST
const generateClassName = createGenerateClassName({
  productionPrefix: "my-host",
  seed: `my-host-seed`,
  disableGlobal: true
});

// Child 1
const generateClassName = createGenerateClassName({
  productionPrefix: "my-child-1",
  seed: `my-child-seed-1`,
  disableGlobal: true
});

// Child 2
const generateClassName = createGenerateClassName({
  productionPrefix: "my-child-2",
  seed: `my-child-seed-2`,
  disableGlobal: true
});

Add StylesProvider wrapper in App.js as below (same for Host and 2 Child apps)

<StylesProvider injectFirst generateClassName={generateClassName}>
Current behavior
In the rendered DOM, I can see 'my-host-seed'. But I cannot see any generated class names for the child apps i.e. I cannot see either 'my-child-seed-1' OR 'my-child-seed-2'
Expected behavior
In the rendered DOM, I should be able to see 'my-host-seed' and also the generated class names for the child apps i.e. I should also see 'my-child-seed-1' AND 'my-child-seed-2'
Context
I am trying to resolve CSS conflict issues in my Microfrontend app using StylesProvider
Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Chrome
Search keywords: StylesProvider

Can you share a minimal reproducible example? It'd be a time taking process to setup a project with module federation.

Actually it would take me some tie to create the minimal reproducible example.
Meanwhile, from what I have highlighted is the relevant code. Not sure if the way I have used StylesProvider and specifically the 'disableGlobal' argument across the Host and Child apps is appropriate.

Actually it would take me some time to create the minimal reproducible example.

Without a reproducible sandbox or repo, there is nothing we can do to help.


Screenshots

Environment:

Release or git hash: 645ced4
Browser: FF

Fixed in https://github.com/hubmapconsortium/vitessce/pull/572


auth.rst: minor fixes to example scripts

Just some minor fixes to the example scripts to make them functional.  I'm not sure if the "jwt" schema was intentional; if so, the purpose should probably be stated in the docs.

You're right, when I created that example I had installed the pgjwt extension into the jwt schema by manually running the pgjwt--0.0.1.sql script. (I didn't want to expose functions like sign or verify by to web clients.) However the default way of creating the extension will put these functions into the main schema so your change is correct for most users.


questionable cluster selection in multi cluster setup

it was reported that given two clusters (one is much smaller than the other), smaller cluster was being picked for no apparent reason. let's understand this behavior in the context of that env and also argument the cpi with extensive logging about decisions it's making and reasons behind them.

#35 : This issue was earlier seen in cpi release 45.0.1. which was fixed in v46+ .
The culprit here was mis-calculation of balance score (an indicator of free space with cluster)
Adding more logging is being worked on.


[Dropdown] Inconsistent appearance

The visual appearance of the dropdown varies a lot across different OSes and browsers. Here are some examples:

OS | Browser
Image
OS | Browser
Image

Windows 7's dropdown

Windows 11 | Brave

Windows 10 | Brave

Linux (Kubuntu) | Brave

Windows 10 | Edge

Windows 10 | Firefox

(There's more but you get the idea)

This is due to the fact that the dropdown component is merely styling the browser's default select element. To achieve a consistent cross-browser dropdown box, we'd probably need to make a pseudo dropdown element and utilize some sort of CSS combinators (e.g. > or +).

https://github.com/necolas/normalize.css
Will the problem be alleviated if normalize is used?

@wll8 Unlikely, the main concern is the dropdown box's appearance e.g the borders, shape, shadow, background color... being not consistent, and normalize.css only helps standardize the fonts (line 163-168) and do not touch any of the aforementioned properties.
With my limited CSS knowledge, I don't think there's an easy way to address these properties of a native select element, best I might do is as I commented above.

Hi @khang-nd,
Just wanted to make you aware of the selectlist (previously selectmenu) proposal by Open UI. As it's still in a proposal state it isn't supported on any browsers currently (with the exception of Chrome under an experimental flag). But if this proposal becomes standard then we could aim to style the dropdown menu accordingly with the Windows 7 format; fingers crossed.
For your reading:
https://open-ui.org/components/selectlist/
https://caniuse.com/?search=selectlist
https://css-tricks.com/the-selectmenu-element/
Cheers.


Fix nova to use nested config (colon-delimited)

This is backwards incompatible. Hopefully it won't bite too many people since we did it early on.

thanks


fix(lsp): Ensure LSP can compile on Windows

Description

Problem*

Resolves
Summary*

This updates async-lsp to support windows. I needed to add a conditional implementation for the stdio stuff because Windows doesn't have non-blocking stdio (this is the same as async-lsp tests).
Documentation

[ ] This PR requires documentation updates when merged.

[ ] I will submit a noir-lang/docs PR.

[ ] I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt on default settings.

New run at https://github.com/noir-lang/build-nargo/actions/runs/5347742396


yapf: init at 0.11.0

Motivation for this change
yapf is awesome :snake:  https://github.com/google/yapf
it does for python code what gofmt does for go code (!!)
sorry about the whitespace diff!
Things done

[x] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

cc @FRidh


ensures proposal details goes to one column on smaller screens

Description

Notes

Issue / Notion doc (if applicable)

Testing

Screenshots (if applicable)

@Da-Colon going to merge this in and do some more mobile testing..


Remove unused views

Remove StudentCoursesView and CourseEnrollView.
Ref: #4114

Coverage decreased (-0.2%) to 56.541% when pulling 65b21ebf636e6759055a23def6a6b4161e13b16f on Imperadeiro98:remove-unused-views into 12b525714b381daa71cb318d2ced5e1576559ea0 on codecombat:master.

Looks good! Thanks for doing this, and splitting it out into separate PR's.


release 0.12.1: updating googleapis and toolkit

Updating version and commit hashes to the latest master commits.
Note: before this is released, I will make one (or more) PRs that will change .circleci/config.yml to make it easier to make artman releases.

@garrettjonesgoogle it failed even after I reverted the googleapis sha.
Failed to generate gapic_config of /tmp/googleapis_smoketest/google/bigtable/admin/artman_bigtableadmin.yaml.
Failed to generate python_gapic of /tmp/googleapis_smoketest/google/api/servicemanagement/artman_servicemanagement_v1.yaml.
Failed to generate java_gapic of /tmp/googleapis_smoketest/google/cloud/dialogflow/artman_dialogflow_v2beta1_java.yaml.

I will restart to see if it's flakyness or a real issue.

Failure:
Failure:
Failed to generate java_grpc of /tmp/googleapis_smoketest/google/artman_logging_external_types.yaml.

This has been failing on googleapis forever. I'm not sure why it wasn't failing in the Artman golden tests until now. I can reproduce it locally:
$ artman --config google/artman_logging_external_types.yaml --local generate java_grpc
ERROR: toplevel: Unexpected exception:
java.lang.IllegalArgumentException: 'google-appengine-v1' in proto_deps was not found in dependency list.
	at com.google.api.codegen.config.PackageMetadataConfig.createProtoPackageDependencies(PackageMetadataConfig.java:300)
	at com.google.api.codegen.config.PackageMetadataConfig.createFromPackaging(PackageMetadataConfig.java:273)
	at com.google.api.codegen.packagegen.PackageGeneratorApp.generate(PackageGeneratorApp.java:99)
	at com.google.api.codegen.packagegen.PackageGeneratorApp.process(PackageGeneratorApp.java:81)
	at com.google.api.tools.framework.tools.GenericToolDriverBase.run(GenericToolDriverBase.java:90)
	at com.google.api.tools.framework.tools.ToolDriverBase.run(ToolDriverBase.java:73)
	at com.google.api.codegen.GeneratorMain.packageGeneratorMain(GeneratorMain.java:313)
	at com.google.api.codegen.GeneratorMain.main(GeneratorMain.java:156)

I have made a fix in gapic-generator for this failure: https://github.com/googleapis/gapic-generator/pull/2104


Outdated information regarding C++20 modules and its relation to C++ projects.

The provided documentation on how to enable C++20 modules is outdated versus the configuration dialog on Visual Studio version 16.8.2.
It also doesn't clarify how C++ modules fit into static library, dynamic library, UWP components projects, MFC, WinRT and which kind of linker problems we run to when trying to migrate projects into modules.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad1fef9a-9c55-a8ab-faf4-8b9ceb9ff688
Version Independent ID: 0eadb3ed-bb38-58bc-b335-687b10f0fd31
Content: Overview of modules in C++
Content Source: docs/cpp/modules-cpp.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

Thank you for your patience as we work through our backlog. We have received more issues than we can manage at this time. We are closing issues based on their severity, how broadly applicable they are, and whether there is enough information provided to act on the issue. If you believe that this issue should not have been closed, please add a comment explaining why by 3/8/2024. We appreciate your contribution and encourage you to propose changes using public PRs, or submit feedback through our updated control at the top of the page, as we phase out Git Issues for this repo. For more information on our feedback systems, see https://aka.ms/ContentUserFeedback.


Add android chrome favicon

Reference: http://realfavicongenerator.net/blog/android-chrome-and-its-favicon/

@RoryJ- from what I'm seeing, Chrome on Android uses the same icon as the add-to-homescreen icon that we already defined in the manifest. I'm okay with explicitly tagging it in the head, but I don't think we need another image besides it.