Update Bitcoin Core to v0.20.0

Successfully tested with running the latest scripts:

Manual update script: https://github.com/openoms/bitcoin-tutorials/blob/master/raspiblitz.updates/README.md#v0200

https://github.com/bitcoin/bitcoin/releases/tag/v0.20.0

Did not get any problems, but the new lnd version release notes have
This marks the second minor release in the v0.10.0 series! This release allows lnd to be compatible with bitcoind 0.20, and fixes an important bug related to an on disk Static Channel Backups (SCB).

https://github.com/lightningnetwork/lnd/releases/
Best to update.
Related: https://github.com/rootzoll/raspiblitz/issues/1240

The Bitcoin 0.20.0 looking good. Closing issue.


Change secondary color

Should be merged after #7

Should be merged after #7

When blocked by another pending PR create a Draft PR instead (Convert pull request to draft)


Companies

Companies are a thing in 1.5
While there doesn't need to be 100 different companies, something needs to be done with them.

At the very least, vanilla ones need to be removed for now.
Long term, it also matters how Companies will work ones Spheres of Influence comes out.


Adds Kat Cosgrove as SIG Docs tech lead

Adding myself as SIG Docs tech lead!

/lgtm
/approve

/lgtm

@katcosgrove looks like we need to get you added to the Kubernetes-sigs org for this one

/approve cancel

/remove-lifecycle stale

How do we proceed with this?


New feature branch with form

This changes implement the Form with 2 input fields (title and description) for DataSpace. The Form implemented with Observable helper file, State management and the react component with the actual form.

Summary

How did you test this change?

[ ] Test(s) added
[ ] Manual testing (please provide screenshots/recordings)
[ ] No testing (please provide an explanation)

Can we add a short screenvideo of how the editor looks like with this two changes ?

Lets also please fix your description for this pull request to describe more what this feature is, same with description.

recording of the Form with 2 input fields as Title and Description in DataSpace
https://github.com/user-attachments/assets/eae7c3cc-6d9b-4326-bdcf-94e5a40ccf65

lets fix the title of the PR!

lets make sure the css aligns with the rest of the elements. could you spend time making it consistent to other editing. please see text or service editor.


Converting task to project doesn't convert sub tasks

I have a task with sub tasks. When I convert the task to a new project, the new project is created, but none of the subtasks are added to that new project. The new project is created and empty.
I've waited a few minutes, but still nothing. The screenshots are from latest version of Todoist on Windows 10 machine, but this also happens on web in Google Chrome.

Hi,
Thanks for reaching out, it seems that Todoist made some small API changes.
I fixed it, could you check it?

Works like a champ. Thanks for the quick response!


service to service calling

hi, i created an app service on azure. now i have another app service in some other azure tenant from where i will call this service. i was hoping to use service to service calling for it. i created an app in aad and went to expose an api and added the url for my service.
i was trying to test it through postman and i was able to get the token using something like this:
https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47/oauth2/token?grant_type=client_credentials&client_id=2058820a-4a94-474b-8d49-7dfffaf4a1c7&client_secret=XXX&resource=url for my app
but when i call the api, i get error saying "code": 401,
"message": "IDX10214: Audience validation failed. Audiences: '[PII is hidden]'. Did not match: validationParameters.ValidAudience: '[PII is hidden]' or validationParameters.ValidAudiences: '[PII is hidden]'."
}
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e20004e2-beab-6e67-9b98-eaa12f612442
Version Independent ID: 2a3db0c8-d0df-cca5-fb52-36d68cd67207
Content: Azure AD Service to Service Auth using OAuth2.0
Content Source: articles/active-directory/azuread-dev/v1-oauth2-client-creds-grant-flow.md
Service: active-directory
Sub-service: azuread-dev
GitHub Login: @rwike77
Microsoft Alias: ryanwi

@manish-shukla01
Thanks for your feedback! We will investigate and update as appropriate.

Have you properly added the bearer token to x-ms-token-aad-access-token?
And are you sure you don't have any authorize attributes in your Azure App Service code? The App Service's easy auth module is supposed to handle all of the authorization before it hits your app service.
Please also make sure that Allowed Token Audiences is selected for the Express Auth in App Services.
https://docs.microsoft.com/en-us/azure/app-service/app-service-web-tutorial-auth-aad
Let me know if this helps!

I'm closing this out since it's more of a product question than a document issue, but if you're still having this problem feel free to email me at<EMAIL_ADDRESS>and I can open a support case for this.


OnRowClick associated function can not detect changes in props

I have declared the following options which I pass into my datatable as the options prop
let options = {
responsive: "scroll",
selectableRows: false,
viewColumns: false,
print: false,
onRowClick: rowClicked
};
The function rowClicked recieves the following parameters according to the documentation: rowData: string[], rowMeta: { dataIndex: number, rowIndex: number }.
My rowClicked function looks like this:
function rowClicked(centre){
const id = centre[0];
const centre = props.data.centres.find(x=>x.id===id)
setFocusedCentre(centre)
}
basically we take the id out of the first column of the row, then we find the centre from the array of centres using that id, and then we change the state to save that centre under focusedCentre.
There is a huge issue however, props.data.centres DOES NOT CHANGE when props.data.centres changes, how can this be?
If I do a console.log(props.data.centres) INSIDE the rowClicked, it will always show the same values, never changing.
Of course when I do a console.log(props.data.centres) OUTSIDE of the rowClicked function, the changes are always correctly displayed.
Any ideas why the rowClicked function is preventing props.data.centres from updating whenever it actually updates?

Let me be a little more specific. Imagin I have a table with columns name and age, my first entry is Bob 44.
Lets assume then that we have onRowClick set up to just console.log the rowData array.
Then we change Bob's age to be 45, so then our table re-renders properly to show Bob 45, however when we click on that row, the rowData array would show ['Bob','44']. Without registering the changes that the table registered...
Might have to do with the fact that onTableChanged doesn't run even if the table data was changed?

A couple of things could be happening here. Firstly, props are read only, so I would not expect you to be able to change props directly in any circumstance.
You will need to change the data at the source. If you've passed it down a bunch of layers, and this is difficult, then you may need a different state management system such as redux. In any case, you need to change either the props you put in, in the first place, in the place where it's passed into the table, or you need to manage this data as state and use setState.
For now, this doesn't look to me like it is an issue with the table.

I don't change the props directly in my example.
Let me try to be a little bit clearer.
MUIDataTable recieves data={props.data.centres}. Whenever I update those props, the table correctly re renders with the new data.
rowClick performs const centre = props.data.centres.find(x=>x.id===id). However whenever I update those props, the function doesn't update with the new props, both the table and the function are inside the same component.
Could you explain that behaviour?

It does look like you are directly trying to set props, e.g. props.data.centres = 'hello'. So, as I was trying to explain, that's just not possible in react. You cannot change props directly, ever. You'll need to use state. It's a lot to explain here, so it might be better for you to look through some tutorials. The main react website is also a good source of information.

Listen, you are clearly not understanding my example so let me make this crystal clear.
function Example(){
[test,setTest] = useState(['hello'])
return
}
function TestComponent(props){
let options = {
onRowClick: rowClicked
};
function rowClicked(){
console.log(props.data)
}
return (

<button onClick={()=>props.setData(['hello world'])
)
}
So we run that little snippet:
1.- We click on the row of our DataTable, it will then console.log(props.data) which will show ['hello'].
2.- We click on our button which will update data (in the parent) from ['hello'] to ['hello world']
3.- Our DataTable will re-render and display the change correctly
4.- We click on the row of our DataTable, it will then console.log(props.data) BUT IT SHOWS ['hello'] instead of ['hello world']
So as I have been saying. The onRowClick function does't register the very simple change

@gabrielliwerant Hello, thanks for helping to support this library. I am having a somewhat similar issue.
I am trying have the onRowClick update a state in my component but the state change doesn't seem to be getting applied.
May I know if this is not supported or if I am missing a fundamental piece to my implementation?
Snippet of my code.
const options = {
filter: true,
filterType: "dropdown",
resizableColumns: true,
responsive: "standard",
download: true,
print: false,
draggableColumns: {enabled: true, transitionTime: 1},
selectableRows: 'none',
rowsPerPageOptions: [5,10,25],
onRowClick: (rowIndex) => {
setIsLoading(true)
}
};
const [isLoading, setIsLoading] = useState(false)
let itemProps = props.itemProps[0]
return (
<div style={{display: 'table', tableLayout:'fixed', width:'100%'}}>

{isLoading}

)
Thank you for your time.


Fix/ensures correct database support

[X] Adds tests scenario to prevent regressions
[X] Ensures multiple database support
[X] Ensures project works correctly without setting the broker as ORM

The failing part seems to be about the coverage token and not the tests.
I've added a scenario for the case without setting the ORM as broker. In that case it'll pick the database from the Schedule entry.

Thanks a lot @abxsantos!
Did you get the chance of reviewing this comment though?
https://github.com/Koed00/django-q/issues/558#issuecomment-873027786
Maybe we are still missing something to generalize the usage...

Thanks a lot @abxsantos!
Did you get the chance of reviewing this comment though?
Koed00#558 (comment)
Maybe we are still missing something to generalize the usage...

No I didn't!
I'll take a look today!


Tree Widget: Investigate ways to solve tree flickering without keeping the horizontal scrollbar.

Released with appui 4.1 release, so removing from the "Tree Widget: 1.0 release" milestone and setting to "Done".


Improve the math page

Introduction
You might need to have a quick introduction to the language. This is as short as it gets. If you have any question about Perl 6, it's probably better to either take it to StackOverflow or ask in the IRC channel, which you can access from the web.
The language used for the documentation is called Perl6 pod. You can pretty much follow the conventions that you already see in the document, but that guide above might help you find whatever is not there.
We are talking about this page, "Doing math with perl6", which you can edit directly on the GitHub page by clicking on the pencil right above the butterfly (a.k.a Camelia); saving it will generate a pull request, or via forking, editing locally and doing a pull request in the usual way.
The problem
Perl 6 includes extensive facilities for using math notation, and doing math with different types. The current page is short and includes only a few examples of sets, or arithmetic.
Suggestions
The page can be improved in many different ways, obviously not limited to the ones below.

[ ] Revise page for possible math terminology, or other, errors.
[ ] The Set section includes, effectively, only Sets, while Perl 6 includes several other kind of set-ty classes. Math on them could be added to that section
[ ] Most Set operations are not mentioned. Some examples of theorems proved using them, or simply solving some mathematical problems, would be interesting.
[ ] Perl 6 is a functional language. A section on type algebra would enhance this page.

Not directly math related, but I'm currently working on updating the documentation for sets, bags, and mixes page to be actually truthful to the current implementation.
So if you are adding anything set related, make sure you ignore most of what is currently written on that page, at least with regards to how the operators work with bags and mixes (and sets when they are involved in operations with bags and mixes).


Assert that added bilinear form integrators are supported by PA/EA

@YohannDudouit @dylan-copeland Currently, bilinear form integrators added via AddBoundaryIntegrator are simply ignored in PA and EA assembly. Similarly, mixed bilinear form integrators added via AddTraceFaceIntegrator and AddBdrTraceFaceIntegrator are ignored in PA assembly. Until these are supported, it would be good to have assertions to inform the user if they are trying to use PA or EA for such integrators.

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1694
@stefanhenneking
@tzanio
@YohannDudouit + @tzanio
08/13/20
⌛due 08/27/20
⌛due 09/03/20

Merged in next for testing...


Custom Trakt List incorrectly imported

The trakt list in question is https://trakt.tv/users/acoucalancha/lists/upcoming-anticipated-movies
It seems that the movie - A Quiet Place: Day One - is being incorrectly formatted, substituting the colon for a <0xa0> character, which from what I understand is a non-breaking space. I've attached the json of my filter to show you what it looks like (renamed to .txt because Github)
filter.json.txt

The trakt list in question is https://trakt.tv/users/acoucalancha/lists/upcoming-anticipated-movies
It seems that the movie - A Quiet Place: Day One - is being incorrectly formatted, substituting the colon for a <0xa0> character, which from what I understand is a non-breaking space. I've attached the json of my filter to show you what it looks like (renamed to .txt because Github)
filter.json.txt

How did you add this list to your config.yaml?
The title imports fine when I use this URL for example: https://api.trakt.tv/calendars/all/movies/2024-03-08/7

Try to append items/movies to the list url. That worked for me.
So like this https://api.trakt.tv/users/acoucalancha/lists/upcoming-anticipated-movies/items/movies
Let me know if that solved it.
Reference: https://trakt.docs.apiary.io/#reference/users/list-items/get-items-on-a-personal-list?console=1
My output: A?Quiet?Place? Day?One,A?Quiet?Place?Part?III
We need to figure out why it doesnt replace ?  with * though.

This is what I have right now:
- name: Upcoming Movies (acoucalancha)     type: trakt     url: https://api.trakt.tv/users/acoucalancha/lists/upcoming-anticipated-movies/items
Trying with /items/movies gives me the same result as your output. Would that json work tho. Shouldn't that space between Place? and Day be removed?

So I have done some tests and it does it correctly from this plaintext list: https://bin.r4tio.dev/raw/dakimolevi
lists:
  - name: plaintext
    type: plaintext
    url: https://bin.r4tio.dev/raw/dakimolevi/raw
    filters:
      - 27

But it fails to parse it from both Radarr and Trakt. Haven't figured out why yet.

The data from the API and your plaintext link seems to be identical. Don't really have any idea what could be causing this.
I did try with another list that has the same movie and it's the exact same result - https://trakt.tv/users/rzepkowski/lists/a-quiet-place-movies

I've tested other titles with a colon in it. For example Mission: Impossible III is parsed perfectly fine into Mission*Impossible?III.
This seems like some kind of freak edge case honestly. I will continue to look for a solution, and if you find more titles in the meantime, please share 😄

You kind of had the answer to the problem in your original post all along @PrivatePasta 😄
I have updated the regex to handle non-standard space characters so it should be good now.
This is why it worked with the plaintext one and not via Radarr, Trakt and mdblists. Since they all pull the title from the same source probably.
Thanks for helping me figuring it out!

Happy to help. Thanks for making a fix for this so damn fast, I really appreciate it


Replace deprecated ::set-env workflow commands for security reasons

replaced unsecure stdout based ::set-env workflow command with save file system based version
change allows this workflow to run after upcoming deprecation of stdout based command this month (November 2020)

Sources:

Google Project Zero vulnerability report
GitHub ::set-env deprecation notes
migration advice followed in this PR

@ascheibal: GitHub decided to move up the removal of the deprecated workflow commands to November 16th: https://github.blog/changelog/2020-11-09-github-actions-removing-set-env-and-add-path-commands-on-november-16/
In 3 days - any workflow that is still using the deprecated commands will stop working.

@jonico Thanks again, and thank you for keeping an eye on GitHubs decisions in this regard - we'll make sure to update the workflow before the next build.


Prevent crash with -playground when -experimental-skip-non-inlinable-function-bodies-without-types also passed

Skip playground transform for functions that have skipped bodies.
Discussion
This can happen when passing -emit-module and -experimental-skip-non-inlinable-function-bodies-without-types and also enabling the playground transform.  This causes the type to be nullptr.  The fix is for the playground transform to check AbstractFunctionDecl::isBodySkipped().
Changes

make the playground transform skip functions that return true for isBodySkipped
add a test to check that we prevent this crash

rdar://119258854

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test macOS

@slavapestov or @hborla or @xedin: any concerns with this?  In addition to the unit test, I have tested locally with roots.

Thanks for the review and approval!


pull request for e2e test at 12/30/2016 11:26:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Preserve chat history?

It would be nice if, when switching to a different assistant type, the switch happened without reloading the page and losing previous chat history. My use case: I wanted to follow up on some information that Nina told me, by using Bridget to execute some code, but when I clicked on Bridget in the dropdown the page refreshed without warning and I lost the previous responses.
More generally: if the chatbot could remember previous conversations like ChatGPT does, that would be very helpful.

We discussed this, maybe the easiest way forward is to implement the capability to @ an assistant in a conversation.


Investigation: Installing the Remote WSL extension out of the box

[x] Create a build with WSL as builtin @joaomoreno
[ ] Make sure it can be updated out-of-band @joaomoreno
[ ] Make sure the Remote extension pack can still be installed/uninstalled @joaomoreno
[ ] The remote explorer shouldn't show up if WSL isn't installed at all @aeschli

Some thoughts:

Do we indicate to users they are getting Remote-WSL as they're installing VS Code?
Do all Windows installs of VS Code get Remote-WSL?

More specifically:
Do we want to make sure users have WSL?

Do we include Remote-WSL with any Windows install of VS Code, no matter what the user has installed/configured on their machine (including if they don't have WSL)?

Do we indicate to users in any way that they're getting Remote-WSL?

Or, do we just include Remote-WSL if the user has WSL on their machine?

Checkbox, warning, opt-in/out

Do we include a checkbox in the VS Code installer where users can opt-in to installing Remote-WSL, and the box is already checked no matter what?
Or, do we include a checkbox where users can opt-in to installing Remote-WSL, and the box is only checked if they have WSL installed on their machine/they meet some other condition?
Or, do we include a checkbox where users can opt-in to installing Remote-WSL, and the box is not checked by default?

My preference: a dedicated page during the setup wizard which would contain a short explanation of WSL and a checkbox which
the user could control, checked by default, independently of the existence of WSL in the system. This is because, and @aeschli correct me if I'm wrong, the Remote WSL extension can guide users to install WSL if missing.

Yes, sounds good to me that the extension will do the guiding on how to install. Currently the install steps are non trivial, but in near future there's a setup wizard provided by wsl. It's easier to have the extension contain that logic.
But I think what would be really good if the install wizard can a link to more information. That way you can keep the description in the setup wizard brief.

Another aspect that needs to be factored in is that WSL is not supported on all version of Windows that are supported by VS Code. Whether we go with a page in setup, or bundling, we should only install the extension if the OS would support WSL2 (Windows 10 1903 or later).
Do we have guidance on what is the bar for an extension to be included as a bundled extension?

Another aspect that needs to be factored in is that WSL is not supported on all version of Windows that are supported by VS Code. Whether we go with a page in setup, or bundling, we should only install the extension if the OS would support WSL2 (Windows 10 1903 or later).

👌

Implementation-wise I think it would be best if the extension was actually bundled with the setup as a built-in extension. The question remains: will further Marketplace updates trigger VS Code to install newer versions of the extension in the user's extensions folder and prefer those newer versions? That is the ideal scenario. @sandy081 remind me if this is what's currently implemented or not.

As WSL becomes an important element of the developer story on Windows, I would like to propose that we bundle the WSL extension as a built-in extension for all versions of Windows that support WSL2 (Windows 10 1903 or later), without making any changes to the setup wizard.
While this change will get the extension installed on new machines that install VS Code, we should also consider installing the WSL extension as part of the VS Code update process so that the extension gets installed on machines that support WSL2 and already have VS Code installed.
@aeschli, does the WSL extension show a notification on activation if you have WSL installed? What about if WSL is not installed? Are we planning any changes related to these notifications? I am asking since it might cause some confusion if we install the extension as part of the update, and after restart suddenly the user would be presented with a WSL related notification.

There are some drawbacks with always bundling the Remote-WSL extension:

the remote indicator (status bar, lower left corner) would always show (it shows when there is an extension that makes contributions to it). Some users might not like that. Also, in the  next release of Remote-WSL we are showing new a new 'Open in WSL' button and menu points that will be in the way of users that don't want WSL.
we lose a chance to promote WSL. Right now it's the recommendation "The extension Remote-WSL is recommended as you have WSL installed' which offers, IMO, a quite a smooth and seemingly smart way of promoting our extension and remote story. Having the option in the wizard would give us a nice possibility to promote WSL. We could even decide to not enable the install by default, but the link to WSL will get people interested.

IMO, enabling new capabilities is always a nicer user experience that getting everything but then having to learn how to disable features as you don't need.
To your question. When the extension is installed, all commands show up regardless if WSL is installed. When invoked, we bring a dialog that contains a how-to-install link.

@joaomoreno Built in extensions cannot be updated from Marketplace currently. https://github.com/microsoft/vscode/issues/68410

@aeschli Could the Remote WSL extension be modified to address your bullet points? The green indicator could be omitted until WSL is actually installed, for example.

Sorry guys, what's the thinking behind this? I can't see anywhere in this thread an actual explanation of why everyone needs this extension installed.
I mean, there's even talk here of installing the extension to existing installations of VS Code that don't contain it. Why are we doing that exactly? Wouldn't the user install it if necessary?
As a user, I'm not seeing the need for this, honestly.

I agree with @IAmHopp; why? Is WSL2 actually becoming an "important element of the developer story on Windows" or is that just bias from a team that uses it a lot? Can we include Docker, ESLint and Material Icon Theme in VSCode by default as well, as these extensions have a larger userbase than Remote WSL, some far larger.
Why is this a discussion on the "how" instead of first asking "should" and "why"?
Add an optional opt-in to the first run experience if WSL is already present on the system; sure, why not. But pushing it on all users just because? No. Then where is the line being drawn as to when an extension should be built-in or not?

I agree with @IAmHopp; why? Is WSL2 actually becoming an "important element of the developer story on Windows" or is that just bias from a team that uses it a lot? Can we include Docker, ESLint and Material Icon Theme in VSCode by default as well, as these extensions have a larger userbase than Remote WSL, some far larger.
Why is this a discussion on the "how" instead of first asking "should" and "why"?
Add an optional opt-in to the first run experience if WSL is already present on the system; sure, why not. But pushing it on all users just because? No. Then where is the line being drawn as to when an extension should be built-in or not?

We came up with a different approach to help users to learn and familiarize with WSL and the Remote-WSL extension: https://github.com/microsoft/vscode-remote-release/issues/4255
The remote-wsl extension stays a separate extension and users can choose to install or uninstall it as with all other extensions.
The work done by @joaomoreno done for this issue was essential for https://github.com/microsoft/vscode-remote-release/issues/4255. I therefore renamed the description to represent only the work done by @joaomoreno

We came up with a different approach to help users to learn and familiarize with WSL and the Remote-WSL extension: https://github.com/microsoft/vscode-remote-release/issues/4255
The remote-wsl extension stays a separate extension and users can choose to install or uninstall it as with all other extensions.
The work done by @joaomoreno done for this issue was essential for https://github.com/microsoft/vscode-remote-release/issues/4255. I therefore renamed the description to represent only the work done by @joaomoreno


Saving file share removes metadata

Saving a file with metadata removes all metadata.
This issue was reported in #20 then "fixed" #24 but later noted it was only partially fixed.
Issue still persists to this day and makes systems depending on metadata unusable with this extension.
Thanks

Thanks for letting us know!


added the solution for auto-complete problem using trie in cpp

Auto-Complete
Problem Statement:
Given n number of words and an incomplete word w. We need to auto-complete that word w.
Printing all the possible words which can be formed using the incomplete word w.
Sample Test Case:
Input:
7
do dont no not note notes den
no
Output:
no
not
note
notes
Testing: Tested locally and also in online IDE.
Result: Code is working for all the cases.

Please have a look at https://github.com/amanmehara/programming/blob/master/CONTRIBUTING.md and make changes accordingly.
I'll approve and merge afterwards! 😃

Please have a look at https://github.com/amanmehara/programming/blob/master/CONTRIBUTING.md and make changes accordingly.
I'll approve and merge afterwards!

@amanmehara Done with all the changes. Please review it.


try miss_hit linter with travis

when miss_hit will become automatic, then Travis will run the code editor on all the code pushed within the pr, is this correct? Or, since it checks in pwd to all the code in the repo?
Also, will the edited code show up as a commit?
Sorry for all the question :) you can ignore them until we will have the occasion to nerd out about this in person

OK I managed to make it work.
So right now travis has 2 independent "jobs":

run the unit tests: make sure they pass
uses miss_hit to check all the .m files in the CPP_BIDS folder and subfolders (not just the "new" stuff of the PR) to see that our code conforms to our guidelines.

You can check the travis details to know which one failed: https://github.com/cpp-lln-lab/CPP_BIDS/pull/46/checks?check_run_id=896173512
And then look at the report for each job: for example: https://travis-ci.com/github/cpp-lln-lab/CPP_BIDS/jobs/363522080
Travsi won't fix our code for us. Maybe we could have something that works like Sourcery that sends a PR to fix our code, but I don't the skill or time to build such bot. :smile:
But if you have some time to kill.

OK the linter via travis works.
So even though technically this is a "fail" I will merge so that we can start making this part of our workflow

My inner Marie Kondo approves


Remove redundant codec and consider adding support for LeoRSFF8

It should be noted that LeoRSFF8 isn't actually GF8 right now because there's no Leopard GF8 in klauspost right now, so that codec should be removed unless Leopard GF8 is implemented (unless we want to still include go-leopard). We haven't made a decision on this yet.
Originally posted by @musalbas in https://github.com/celestiaorg/rsmt2d/issues/111#issuecomment-1245304954
this codec should be removed since it isn't actually using the 8 bit codec. We should also decided if we want to add support for the actual LeoRSFF8 codec.
edit: linked to correct not yet merged codec introduced in #111

The current LeoRSFF8 via go-leopard does use the 8 bit codec as leopard has an FF8 implementation.
However, it is also the case that in LeoRSFF16 when the shards are <256, leopard defaults to using the 8 bit codec. Therefore, LeoRSFF8 can indeed be removed as it doesn't really add anything, unless we want to make it so that LeoRSFF16 always uses the FF16 codec, which there isn't really an advantage to.

The codec mentioned in this issue no longer appears used. This repo has a singular Leopard codec here which uses Leopard GF8 when shards <= 256 or Leopard GF16 when shards > 256. Is this issue still relevant?
What is the difference between LeoRSFF8 and Leopard GF8?

I don't think this issue is relevant anymore because as you say, the Leopard codec uses GF8 when shards <= 256.


Delete unused UTF8 conversion helpers

#637 replaced these helpers with managed code.

@schellap PTLA

LGTM

Ah, remembered while driving... and then forgot. LGTM.


Need helps to figure out the Error and how to fix it

I am running the example from https://github.com/python-control/python-control/blob/master/examples/kincar-flatsys.py. And I am getting an error message as below,

ValueError                                Traceback (most recent call last)
 in ()
130 # Simulation the open system dynamics with the full input
131 t, y, x = ct.input_output_response(
--> 132     vehicle_flat, T, ud, x0, return_x=True)
133
134 # Plot the open loop system dynamics
2 frames
/usr/local/lib/python3.7/dist-packages/control/timeresp.py in _process_labels(labels, signal, length)
681     # Make sure the signal list is the right length and type
682     if len(labels) != length:
--> 683         raise ValueError("List of %s labels is the wrong length" % signal)
684     elif not all([isinstance(label, str) for label in labels]):
685         raise ValueError("List of %s labels must all  be strings" % signal)
ValueError: List of output labels is the wrong length**
The program is running in google Colab environment with python version 3.7.
Your help would be much appreciated.

That example was updated recently.  Assuming you're running python-control version 0.9.1 (check with import control as ct; print(ct.__version__), you need the example file from 0.9.1.

Alternatively, you can edit the latest version of the example to be compatible with the earlier version of the code.  Here's the diff to implement:
--- a/examples/kincar-flatsys.py
+++ b/examples/kincar-flatsys.py
@@ -109,7 +109,7 @@ def plot_results(t, x, ud):
 # Create differentially flat input/output system
 vehicle_flat = fs.FlatSystem(
     vehicle_flat_forward, vehicle_flat_reverse, vehicle_update,
-    inputs=('v', 'delta'), outputs=('x', 'y', 'theta'),
+    inputs=('v', 'delta'), outputs=('x', 'y'),
     states=('x', 'y', 'theta'))

The change is that in the latest master the default for a flat system is that the default outputs are the flat outputs (in v0.9.1, the default outputs were the entire state, which didn't really make sense).  This was changed in PR #709.

I am good now. Thanks a lot.


CLID-278: Fix M2M of operator already built

Description
Fixes # CLID-278
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Mirror to mirror twice with same catalog
Expected Outcome
pass

/retest

/lgtm


Jira Portfolio issue links migrate to ADO

Is your feature request related to a problem? Please describe.
I am trying to migrate Jira Portfolio issue links to ADO.  The issues migrate but the links do not.  Is Jira Portfolio with the "Parent Link" field supported?
Describe the solution you'd like
I would like the parent link field in jira portfolio to be supported in the migration from Jira to ADO
Describe alternatives you've considered
I have considered and tried various configurations in the config-bt file, to no avail
Additional context
Primarily I would like to see if it is possible to preserve the parent link between jira portfolio issues when migrated to ADO
AB#5791

Hi! Have you tried using the IncludeParents flag as described here? https://github.com/solidify/jira-azuredevops-migrator/blob/master/docs/config.md#download-options
// Alexander

I think so, but the dual exports worked for us. We can probably close this Issue.

Ok! Closing this issue for now. Let us know if you require additional support :)


PLDI benchmarker

This small PRQ, split off mw-pldi-experimental, adds a quick and dirty benchmark script that was used to generate benchmarks for the PLDI paper attempt.
It comes with a benchmark set that may, depending on order of PRQs, reference nonexistent examples.  Otherwise this is independent of the other PRQs.  I can fix this before merger if people want.
Tested on macOS, needs testing on Linux/BSD, probably won't work on Windows.

This has been superseded by the benchmark code in the CAV branch.


fix posCtrl factor

Update line 13 to create positive control factors from just positive controls, not entire set

@nranthony can you update this PR to merge into dev. We'll move your commit over to master after verification of the dev branch.

Thanks @NicoleEO
Sorry, just clicking too fast to think about options.


cannt play aac file remote on android

I hava test android 5.5 but fail  i hava try react-native-vedio but fail  could you help me ?

i know...
ios record aac file  cant play on android

@zmGitHub did you find a solution?

no.....

@arrygoo try react-native-sound


[Stable] Show updated release notes (#947)

Summary
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.891%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
17362

Relevant Lines:
20214

💛  - Coveralls


Caching problem

/uploads?page=1
and
/uploads
give me different content with the latter being several minutes (so far) out of date.

Removed the cache for this page.


improve sound quality when calling

Hello guys and @cloudwebrtc,
I'm currently working on project using Livekit to do voice call and audio call. Logic is fine but I have problem relevant to sound quality when calling. When I call, I can hear the sound of typing, echos, noise very far from me. I have using roomOptions in docs, but it seems doesn't work at all.
defaultAudioCaptureOptions: AudioCaptureOptions(         deviceId: '',         noiseSuppression: true,         echoCancellation: true,         autoGainControl: true,         highPassFilter: true,         typingNoiseDetection: true)
This is the video I record: (I call from Windows to MacOS, if I call from mobile to desktop same problem is happened)
https://github.com/livekit/client-sdk-flutter/assets/83997264/96f78dd6-bbdf-45cd-a843-16aa6ea2dce7
I have searched in documentation and issues on github and try many ways but the problem is still there. How can I improve this sound quality? Thank you!
My Flutter configuration:

Flutter version: 3.7.9 (channel stable)
Livekit Client: 1.3.1

@thaidmfinnick can you reproduce this with the built-in example app?
what about trying to use meet.livekit.io on the same device?

This seems to be due to the built-in NS algorithm on the desktop side not fully canceling keyboard taps or external noise (we may also need a third-party NS library to optimize noise reduction), especially when using speakers and high-sensitivity microphones.
This kind of twittering sound also usually occurs when two mobile devices speakerphones are turned on at the same time to make a phone calls, and the NS and AEC algorithms are not perfect.

Thanks for your responses! I have tried with meet.livekit.io @davidzhao, and here is the result, it's the same sound noise like my app.
https://github.com/livekit/client-sdk-flutter/assets/83997264/a8774fef-defc-4c6e-8d33-7ded4bbda518

@cloudwebrtc You mean that the algorithms cannot work as expected because of desktop side and from now, we cannot deal to this desktop's problem, can you?

This is the expected behavior of WebRTC noise cancellation. Google Meet is using a proprietary system that appears to be doing a better job here.
There isn't much we could do at this point. Closing the issue


TrainCarts induce lag to server (TPS drop)

BkCommonLib version: 1.13.1-v1
TrainCarts version: 1.13.1-v1
Spigot version:  1.13.1-R0.1-SNAPSHOT

Problem or bug: TrainCarts makes too much lag (Train Physics)
Please check this timings data: https://timings.spigotmc.org/?url=wipacowude
Expected behaviour: N/A
Steps to reproduce: N/A
Because of Train Carts, TPS is dropping to 20 -> 4.xx.. Please fix this..

"Steps to reproduce: N/A" => that helps so much.

Firstly, disable block collision for trains that dont need them to improve the timings of onMove.
Next, theres a lot of time spent in updateChunkInformation, which means its loading a lot of chunks sync instead of async. Theres been a bunch of trouble loading chunks asynchronously, and it might not yet work correctly, so that is an issue point worth looking into still.
Is this on the latest dev build of BKCommonLib from the jenkins ci? (I assume yes)

@male-gal It happens randomly not happens when I was doing something specially. So I don't know how to reproduce this problem...

@bergerkiller Thank you for replying, but as you know, the problem was fixed thanks to your hard work!
My nickname is Lavender in TC Discord channel.. Thank you again for your hard work for me..

@RichVillage I recognized your icon but I thought it might've been a new issue :)
I'll close this issue, then.


Texture disappears as camera moves away

Issue 1: As shown in the above image as the camera moves away from the Quad we can see the texture disappearing and blackens out, the reason for this unexpected behavior is unknow
[Could be resolved if swapchain reconstruction and resize logic is added]
Render Doc Capture Info:

(The depth texture is visible just the range is different needs to calibrated and can be seen in render doc)
Razix Engine Stats
Version                 : 0.20.0
Release Stage           : Development
Release Date            : 9-1-2022
OS                      : Windows 10 Home
Processor               : Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz   2.60 GHz
Vulkan API Version      : 1.2.186
GPU Name                : NVIDIA GeForce RTX 2060
Vendor ID               : 4318
Device Type             : DISCRETE GPU
Driver Version          : 497.116.0

Issue 2 Solution: By selecting the depth attachment in renderdoc and pressing the magic wand icon it correctly chooses the right range for the depth texture as explained in this issues here we can see the depth attachment properly

Resolved!


Fix some lgtm alerts

This PR fixes some alerts flagged by lgtm.com code queries. Most are minor improvements suggestions but a few some should fix unintentional code behaviour (e.g. wrong signatures in calls).
The standard lgtm engineering analytics highlights dependencies, vulnerabilities and tracks introduced and fixed alerts as the code changes. There are currently 188 alerts flagged, probably better investigated by someone more familiar with the code base than me, but you can also investigate further by writing your own custom queries to explore your code base.
I personally find lgtm alerts most useful when using PR integration as it allows to check and deal with potential issues before they find their way into master.
Full disclosure: I work on lgtm.com, hence my interest! I'm not very familiar with nltk but I hope you find this useful, any question please ask.

fwiw, we fixed several small bugs over at scikit-learn thanks to lgtm's
alerts, and fixed more after suggesting a bespoke query that corresponds to
a frequent source of bugs. This is not mere issue tracker spam.
On 11 Jul 2017 8:43 am, "Jean Helie"<EMAIL_ADDRESS>wrote:

This PR fixes some alerts flagged by lgtm.com code queries. Most are
minor improvements suggestions but a few some should fix unintentional code
behaviour (e.g. wrong signatures in calls).
The standard lgtm engineering analytics highlights dependencies,
vulnerabilities and tracks introduced and fixed alerts as the code changes
https://lgtm.com/projects/g/nltk/nltk/. There are currently 188 alerts
https://lgtm.com/projects/g/nltk/nltk/alerts/ flagged, probably better
investigated by someone more familiar with the code base than me, but you
can also investigate further by writing your own custom queries
https://lgtm.com/docs/ql/about-ql to explore your code base.
I personally find lgtm alerts most useful when using PR integration
https://lgtm.com/docs/lgtm/config/pr-integration as it allows to check
and deal with potential issues before they find their way into master.
Full disclosure: I work on lgtm.com, hence my interest! I'm not very
familiar with nltk but I hope you find this useful, any question please
ask.
You can view, comment on, or merge this pull request online at:
https://github.com/nltk/nltk/pull/1775
Commit Summary

fix signature of 2 _related() calls in _WordNetObject base class
suggest fix for conlicting variable corrupting if test
add ne implementation
properly initialise exception types using super()
user super() when relevant for child classes
avoid using self.class in super() as it can cause infinite loop
remove unecessary/confusing else statements after for loop without
break clause

File Changes

M nltk/classify/rte_classify.py
https://github.com/nltk/nltk/pull/1775/files#diff-0 (6)
M nltk/collections.py
https://github.com/nltk/nltk/pull/1775/files#diff-1 (3)
M nltk/corpus/reader/framenet.py
https://github.com/nltk/nltk/pull/1775/files#diff-2 (9)
M nltk/corpus/reader/nombank.py
https://github.com/nltk/nltk/pull/1775/files#diff-3 (4)
M nltk/corpus/reader/propbank.py
https://github.com/nltk/nltk/pull/1775/files#diff-4 (4)
M nltk/corpus/reader/wordnet.py
https://github.com/nltk/nltk/pull/1775/files#diff-5 (4)
M nltk/parse/recursivedescent.py
https://github.com/nltk/nltk/pull/1775/files#diff-6 (3)
M nltk/parse/shiftreduce.py
https://github.com/nltk/nltk/pull/1775/files#diff-7 (3)
M nltk/sem/logic.py
https://github.com/nltk/nltk/pull/1775/files#diff-8 (19)
M nltk/tokenize/stanford.py
https://github.com/nltk/nltk/pull/1775/files#diff-9 (2)
M nltk/translate/ibm_model.py
https://github.com/nltk/nltk/pull/1775/files#diff-10 (3)

Patch Links:

https://github.com/nltk/nltk/pull/1775.patch
https://github.com/nltk/nltk/pull/1775.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nltk/nltk/pull/1775, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6_trahXruZNNgAlsC4jy6UeXT5MQks5sMqkRgaJpZM4OTgqb
.

Thanks @jnothman !

@jhelie I'm merging this and will fix the names afterwards.

There's still more work on the LGTM and the spillover issues would be tracked on #1776.

@stevenbird thanks for your message and for merging this. I'm sorry I didn't get to update the parameters names myself last week - I see you just did so in 68390bdb53576a5c2a6a48b76d6195dc59e381fe :)
+@alvations: thanks both for the positive feedback, you might also be interested in turning on PR integration to get the chance to act on possible issues at review time (in case you're wondering very very soon you'll also be able to configure which type of alerts you want to hear about in the PR).
We're always looking for feedback so do feel free to get in touch with any comment you may have. In the meantime I'll try to have a look at current alerts and submit another PR if I get the chance.

:+1: to LGTM PR integration


AboutUs and README v1.1

AboutUs.md updated with 485ac0c4113bf20d43f0fca4ff662b8aba5b3ee2

Pushed to TP repo by following the workflow #7

Completed with PRs #7 #8 #9 #14 #15 #16


Added two new notebooks demo

Added two new notebooks 'resume-evaluator-ANN-index-search' and 'real-time-anomaly-detection'.
@pranavaurora  could you please check it once?
Thanks.

hey @kesmit13  made the suggested changes.
Let me know if I missed anything


chore: connect services when running dev:full

Summary
Now when running dev:full UI will automatically use local sx-api and mana.
How to test

Set up .env in apps/mana and apps/api (you can copy those files from your previous projects, but make sure DATABASE_URL is not changed from .env.example.
Run yarn dev:full.
Open UI, it uses local services (for Starknet sepolia and Mana).

Yeah, it's only replacing few networks. I was thinking if we should only enable networks that we run locally (so for now it would set just sn-sep, but I thought other networks might be useful for testing as well (and you don't need to run all the networks locally, just one).


Fix bug where we leak connections from EntryIteratorDAO

Close ResultIterator when an entire VerifiableLog action has been completed
We now use JDBI onDemand SQL objects which manage their own opening and closing of
database handles. When we reading from the database via EntryIteratorDAO, if the iterator
is not completely consumed (until there is no more hasNext), the iterator does not get closed
and therefore neither does the database handle. This therefore leaks connections.
We did not see this previously because we were explicitely closing the database handle
by using dbi.inTransaction around each action on the verifiableLog.

👍


ui: show account configure limits tab for domain-admin

Description
Fixes #5676
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan ui

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5858 (SL-JID-1010)

@blueorangutan ui

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5858 (SL-JID-1011)


Define full RV64I ISA and most pseudo-instructions

Ref:

Unprivileged ISA spec version 20240411: https://github.com/riscv/riscv-isa-manual/releases/tag/20240411

The ASM manual: https://github.com/riscv-non-isa/riscv-asm-manual/blob/ad0de8c004e29c9a7ac33cfd054f4d4f9392f2fb/src/asm-manual.adoc

This is draft for now because:

The parser currently does not accept bit pattern lines that begin with % because it thinks they're virtual field definitions. Mega is fixing it.

Need to write tests for all the instructions. (Based on https://github.com/Arnavion/riscv/blob/main/src/lib.rs#L89 which in turn are pulled from gas.)

This is draft for now because:

All done.


WIP: Add Travis builds with Clang v3.6

This includes additional debug builds with address sanitizer and memory sanitizer enabled.
This is on top of #429 to avoid merge failures (I've kept them separate because I don't know if this works, so don't review yet).
Clang also supports a "memory sanitizer" additionally to asan, but I wasn't able to make it work locally due to an incompatibility with recent Linux versions. I hope this works on Travis.

So, when msan is enabled there are like a billion test failures:
https://travis-ci.org/openssl/openssl/jobs/84089615#L1603
They are all caused by use of uninitialized memory, but not having the full log it's not clear if they are issues only present in the test suite or not (and I still can't run msan locally, though valgrind could be of help here).

Have a look in INSTALL, there's some guidance on how to increase verbosity.

closing this, unmerged, in favor of #429


[Feature Request] add promos as a filter

I think it would be nice to have the promos filtrable like bt, st and ex sets.

ah sorry. i didnt notice they were in rarity. cool to know it thanks


fix(routes): Add key prop to route component patch

:tada: This PR is included in version 1.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


dockerTools: Fix issue where image name with repository prefix was no…

…t supported
Fixes #12902
/cc @lethalman

I like it, thanks!


Quirk to change Nue GPO from light to power outlet

The Nue double GPO (NUE-AUWZ02-000) presents itself as an ON_OFF_LIGHT. This is a simple quirk to fix this and correctly present a MAIN_POWER_OUTLET instead.

Pull Request Test Coverage Report for Build 542816439

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 83.123%

Totals

Change from base Build 515356724:
0.03%

Covered Lines:
3295

Relevant Lines:
3964

💛  - Coveralls

Codecov Report

Merging #768 (ae7cf08) into dev (6c48099) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #768      +/-   ##
==========================================
+ Coverage   83.08%   83.12%   +0.03%
==========================================
  Files         176      177       +1
  Lines        3956     3964       +8
==========================================
+ Hits         3287     3295       +8
  Misses        669      669

Impacted Files
Coverage Δ

zhaquirks/nue/auwz02000.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c48099...ae7cf08. Read the comment docs.


fix "fatal error: concurrent map read and map write" bugs when we concurrently execute lots of delete volumes and create or list volumes tasks

- What I did
The globalLock use of struct type VolumeStore is not very correct in docker volume packages, sometimes it will cause "fatal error: concurrent map read and map write" because we concurrently execute lots of delete volumes and create or list volumes tasks. Add globalLock.Lock for read tasks will resolve this error, but the performance of docker would be lower too much, so I change type of globalLock from sync.Mutex to RWMutex, and all read task codes are around with globalLock.RLock, then the concurrent error will not happen, and the performance would not be lower too much either.
- How I did it
change VolumeStore.globalLock type from Mutex to RWMutex, and add globalLock.RLock() for the read task codes of names, refs, labels and options in VolumeStore
- How to verify it
concurrently execute lots of delete volumes and create or list volumes tasks, and docker will never down like before.
- Description for the changelog
none
- A picture of a cute animal (not mandatory but encouraged)
none
Signed-off-by: He Xin<EMAIL_ADDRESS>

SGTM, but it doesn't compile
00:02:19.200 # github.com/docker/docker/volume/store
00:02:19.200 volume/store/store.go:556: s.globalLock.UnLock undefined (type sync.RWMutex has no field or method UnLock, but does have Unlock)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:KevinTHU/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354237016
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@AkihiroSuda sorry, I have no build enviroment, I will re PR it again~~=_=!!

Oh, you didn't have to close this PR
$ git commit -a -s --amend
$ git push -f

:+1:

yeah, I just know that, but this is a good help, thx~


Request to web.com blocked by Cloudflare

🐞 Describe the bug
I am building a service that requires me to fetch metadata from any given URL.
This isn't at the center of what I am working on, it's an addon feature and after some Google search I found this package (cool stuff)
When working with most URLs and fetching data everything seems to work fine.
But whenever I try to retrieve metadata from http://web.com, it throws an error.
📚 To Reproduce
Try fetching metadata for http://web.com
💡 Expected behavior
I expect to get results with the metadata from the URL instead I get
HTTPError: Response code 403 (Forbidden)
    at Request.<anonymous> (/root/node_modules/got/dist/source/as-promise/index.js:117:42)
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  code: undefined,
  timings: {
    start:<PHONE_NUMBER>506,
    socket:<PHONE_NUMBER>517,
    lookup:<PHONE_NUMBER>568,
    connect:<PHONE_NUMBER>579,
    secureConnect:<PHONE_NUMBER>602,
    upload:<PHONE_NUMBER>602,
    response:<PHONE_NUMBER>759,
    end:<PHONE_NUMBER>809,
    error: undefined,
    abort: undefined,
    phases: {
      wait: 11,
      dns: 51,
      tcp: 11,
      tls: 23,
      request: 0,
      firstByte: 157,
      download: 50,
      total: 303
    }
  }
}

🖼 Screenshots
https://scrnli.com/CV2MNqySiJMIeS
⚙ Environment

OS: Linux Mint 20
Node.js Version: v12.16.3
Link to website

📋 Additional context

Looks like http://web.com is blocking the request, this is not an error with metadata-scraper by itself.
When requesting http://web.com using curl curl -L http://web.com I get the same error and a Cloudflare captcha page.

No not really. Cloudflare is somehow detecting that the request is automated and asks the client to perform a captcha.
Those issues usually only come up when the request comes from a server with high traffic/when performing a lot of requests from a known IP and not when running it locally.
Maybe #140 i.e. running the JavaScript from the site and actually rendering it in a browser could help prevent the request from being blocked by Cloudflare. Not sure though, feel free to investigate this yourself and let me know what comes up!

I found a temporary fix for what I am working on.
It is not a fix that directly concerns the package, just had to change the structure of my code to better handle a case like this a bit better. I ran a lot of tests and the issue persists for a couple of sites away from web.com.

Okay great! For the actual issue there's not much that can be done. Some sites will always try to block automated traffic.
I will see if #140 would reduce the likelihood of requests being blocked, but it would require to spin up a headless chrome instance for each request which is not ideal.
Will close this issue for now, but feel free to comment if you find a workaround/a way to bypass the block.


Importing nameko.cli.run to execute run()

Is it ok to use nameko.cli.run.run() from my code directly? I want to give nameko some configurations programmatically, using dynaconf, but I do not like the idea of copying and pasting (or "adapting") the contents of a run function in my program.
Is nameko.cli.run.run() safe to import, or it is not guaranteed to maintain the interface?

We don't have any kind of formal definition of the "public" APIs, but it should be safe.
The fundamental signature of some services to run, and the config to use when doing so, is not going to change. In the future it might grow some more keyword arguments like backdoor_port, but they'd be backwards compatible.

Do you think it would be appropriate to move some of the functions found under the cli module, such as run or setup_backdoor, to the utils package for instance? Since they are not really related to the CLI itself, but instead being used by it.

Yes, probably. I'm not sure utils is the right place, but certainly these two things are more about running services than the CLI. Perhaps a new nameko.run would be a good module to house them.

Sorry for the late reply here @gpkc. You're right that things are messy. These facilities have independently evolved and never been refactored into a neater place.
I would welcome a PR that incorporated run_services into nameko.cli.run.run() and perhaps also moved the whole lot to a better named module like nameko.run.
There is also the ServiceRunner class which is really just a convenience wrapper around multiple ServiceContainers. I'm not overly keen on it. I don't think it's really necessary and it could certainly be better named (ServiceContainerCollection perhaps, although that's a bit long)

This issue was moved to https://discourse.nameko.io/t/importing-nameko-cli-run-to-execute-run/292


Enhancement: Add Scalar API documentation

Summary

https://scalar.com/swagger-editor

Basic Example

Swagger
ReDoc
RapiDoc
Stoplight Elements
Scalar

Drawbacks and Impact
This will need to be refactored into a plugin once we do that for the rest of them.
Unresolved questions
No response

I've got refactoring of the openapi controller on my radar - would you be happy for this to wait until that is done?

@peterschutt welp i refreshed my page and you commented 😅 i am happy to decline my pr though

The way I envisage the new approach, is that the openapi UI frameworks that you want to use will be configurable via the openapi config object. For backward compatibility, the default value for that config option will have to be every UI framework that we have released on the current openapi controller. My preference would be to wait until that is done, and then we can write a "plugin".
I don't think these things will be actual litestar plugins, but just openapi frontend plugins. They'll have a render(openapi_config: OpenapiConfig, openapi_json: dict[str, Any]) -> bytes: method and have to declare the path they are to be served under.. smth like that anyway.

Closed in #2906


The pthreads are not working on user space. ARM64 cortex_a53 but generic requirement.

Describe the bug
Pthread is not working on ARM user space. The system exits when pthreads start.
Please also mention any information which could help others to understand
the problem you're facing:

The pthread requires stack to execute and creating the stack array is not possible in user space.
Is there a work around to provide it stack ?

To Reproduce
Steps to reproduce the behavior:

enable pthreads with user space

Expected behavior
Pthreads must work when called.
Impact
Unable to run multithreaded applications on arm64.
Environment (please complete the following information):

OS: Linux,
Toolchain Zephyr SDK

This is not supported and closing as a bug.  Please re-file as a feature request.

@AshwinKrishn - just thought I would chime in. This has been a feature in development for a long time. It's been on the backburner for me for a while. But yea, the assessment is accurate. There needs to be a new first-class Zephyr object type for thread stacks, which requires dynamic objects.
See also #26999, #24714, #25973


user not removed + home directory not created + NixOS confused

Issue description
Removing / renaming a user via /etc/nixos/configuration.nix does not remove the old user, does not create home directory for the new user (name) and leads to broken/confused NixOS system (no new users can be created).
Happened inside a chroot (nixos-install --chroot). Sorry for the rather "raw" report, I currently don't have that much spare time but wanted to record/report this. Also this is my (only) production system (being rebuild on new hardware after hard drive failure) thus I'm a bit limited with respect to tools atm.
Steps to reproduce (or better: The story how it happened)
Add a user:
user.users = {
  foo = {
    isNormalUser = true;
    createHome = true;
    uid = 1000;
    extraGroups = ["wheel" "cdrom" "networkmanager" "scanner" "vboxusers"];
  };
};

Run nixos-rebuild switch. Oh, but foo is a terrible name (or a typo), so go back and change:
user.users = {
  bar = {
    isNormalUser = true;
    createHome = true;
    uid = 1000;
    extraGroups = ["wheel" "cdrom" "networkmanager" "scanner" "vboxusers"];
  };
};

Run nixos-rebuild switch. ls /home shows only foo. Short panic, go back and change:
user.users = {
  bar = {
    isNormalUser = true;
    createHome = true;
    uid = 1001; ### HERE is the change
    extraGroups = ["wheel" "cdrom" "networkmanager" "scanner" "vboxusers"];
  };
};

Run nixos-rebuild switch. Still no home directory for bar, looking into /etc/passwd now shows both a line for foo and bar (with the correct home directory paths set). Notice output from the just finished nixos-rebuild with a line:
Died at /nix/store/531giy6mqh207cadkffsi1z960l4jywz-update-users-groups.pl line 144.

Try to start all over:
user.users = {
};

Run nixos-rebuild switch. Same error message as above. No change in /etc/passwd. Add a completely different user:
user.users = {
  frob = {
    isNormalUser = true;
    createHome = true;
    uid = 2000;
    extraGroups = ["wheel" "cdrom" "networkmanager" "scanner" "vboxusers"];
  };
};

Run nixos-rebuild switch. Same error message as before. /etc/passwd unchanged, no line for frob but still for both foo and bar. ls /home still has only a directory for foo.
Technical details

System: 16.09.929.80cbb8a (Flounder)
Nix version: nix-env (Nix) 1.11.4
Nixpkgs version: "16.09.929.80cbb8a"

Updated above description to include the (apparently) relevant line
    extraGroups = ["wheel" "cdrom" "networkmanager" "scanner" "vboxusers"];

in each user configuration.

I was investigating why /etc/passwd (and /etc/group) weren't usable (or to be precisely, writable). Running mount gives me (apart from a too huge list ... 2 pages is far too much for this setup):
/dev/mmcblk0p1 on /etc/passwd type ext4 (ro,relatime,data=ordered)
/dev/mmcblk0p1 on /etc/group type ext4 (ro,relatime,data=ordered)

/dev/mmcblk0p1 is the SD card from which I'm running the backup (NixOS) system. This looks very wrong to me.

Can you also paste your filesystem partitions?

Could be a duplicate of https://github.com/NixOS/nixpkgs/issues/6481

Are you using users.mutableUsers?

@domenkozar I don't think that's the issue here, I'm using a single (plain simple ext4) partition for the whole system.
  fileSystems = {
    "/" = {
      device = "/dev/disk/by-uuid/a344e210-b303-491f-87e9-0f9882f73c9e"; # this is /dev/sda3
      fsType = "ext4";
    };
  };

@kierdavis Yes, or to be precise: I use the default, which is true AFAIK.
I think the issue here is twofold:

Rebuilding with mutable users (AFAIK) merges the generated content with the already existing files like /etc/passwd. It should (that's a feature request, I guess) also be able to differentiate between content that has been generated by the last run and content that has been altered in the mean time.
Not being able to even change these files (i.e. them being mount points). This could be my fault (wrong usage): Is it even allowed/possible to run nixos-rebuild from within a shell opened by nixos-install --chroot ?

(triage) what’s the status?

I didn't investigate further than what I wrote above. I don't think it's too much of an issue, though this could be turned into a feature request for nixos to save the generated passwd file (and similar files) somewhere in the nix store (read only thus) and compare the actual passwd file to that in order to know which users had previously been defined.
Not sure if it's worth the effort, though.

Then I’ll close, feel free to reopen.


/opt/hostedtoolcache

Create /opt/hostedtoolcache by default so more actions work out of the box.

Resolved by #494


minimal-bootstrap.*: rebuild packages with musl

Description of changes

reduced the number of dependencies that link with mes-libc
gnumake-musl enables parallel builds
tinycc-musl can build gcc46 without gcc2
uses of glibc have been retired (except gcc2)

Related #227914
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

We can also circle back to mes musl dedup at the end.


Investigate prototyping kit refactor

SPIKE
The prototyping kit is becoming quite stale. It is quite brittle and inflexible in it's implementation and probably needs a refactor to make it more suitable for how it is currently used today.

Raise at the next monthly forum
Keen to get a view from IxD @Majsol (@LaurenDowling potentially had some good ideas before JB left?)

So happy to see this progressing.
I was talking with the Head of IxD for the Gov.uk Design System this week and he mentioned that several local govs, charities, and overseas gov departments already extend their design system using the undocumented plugin functionality - https://github.com/alphagov/govuk-prototype-kit-docs/issues/188
It could be a way forward that instead of maintaining our own completely separate design system - we instead piggyback on tried and tested patterns and simply develop specific patterns for ONS...
The IxD community here is really keen to be involved in any discussions about this - we need to agree the best and most sustainable way forward ⚡

@JNATION85 to speak to @liammcmurray

The investigation has already been done and three tickets have been created for us to work on.


fix lib/requirements

This upgrade fixes a CSRF error in FastAPI 0.65.2,
see https://github.com/tiangolo/fastapi/security/advisories/GHSA-8h2j-cgx8-6xv7

Signed-off-by: JoeyHwong<EMAIL_ADDRESS>

/assign @llhuii

This upgrade fixes a CSRF error in FastAPI 0.65.2

Not correct: that security bug does not happend in FastAPI 0.65.2, but is fixed in FastAPI 0.65.2
Another question: why not upgrade the latest version of FastAPI? Current version of FastAPI is 0.68.1.

This upgrade fixes a CSRF error in FastAPI 0.65.2

Not correct: that security bug does not happend in FastAPI 0.65.2, but is fixed in FastAPI 0.65.2
Another question: why not upgrade the latest version of FastAPI? Current version of FastAPI is 0.68.1.

fixed. Although current version updated to 0.68.1, the wheel size is little bigger than our minimum reqirement version (52254 > 51192).

/lgtm
/approve


Improve handling of parallel requests

Like already did for the 2.x branch, we should improve the handling of parallel request.

Done with #89


Update qiskit version

Summary
Updates the qiskit version to 1.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 79.467%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
5666

Relevant Lines:
7130

💛  - Coveralls


Caching files in memory

I'd need to buffer file streams, in memory, while waiting for the finish event. From there i'd pass them to the S3 upload stream. Is there a straight forward way to do so ?
Thanks

Why do you need to buffer the files if you're going to pass them to S3?

I need to run validations on the inputs before uploading to S3 so I am trying to avoid saving them to disk and just buffer then in memory instead.
On 29 Dec 2015 21:25, Brian White<EMAIL_ADDRESS>wrote:Why do you need to buffer the files if you're going to pass them to S3?
—Reply to this email directly or view it on GitHub.

Are you referring to inputs other than the files you're uploading (e.g. text fields)? If so, you can just move those fields before the file fields before submitting the form. If you want to preserve the current order, you can either:

Submit a reordered form via XHR
Use hidden fields (placed before the file fields) that store a copy of the actual, visible (text/checkbox/etc.) fields that get updated when the real fields change
(Hide and) reorder the actual field elements in the DOM right before form submission

Using one of these methods will allow you to receive the fields before the files, allowing you to avoid buffering entire files in memory (which is generally a bad idea).

as @mscdex wrote, caching in memory is bad, because: files might be very big or lots of users might upload small files simultaneously which floods your memory. Also Never trust your users. They might forge requests with many large files in order to DoS your server.
I think the best way would be to do your checks on the fly inside the data event and then pass the chunks to your upload pipeline. You could stream the files from the client to S3 that way. But that depends heavily on the kind of checks you want to do. In case you cannot do the checks on the fly, the probably most-used way is to cache them to a tmp directory on the server, do your checks on the file system and then upload the files. This also enables you to delay all checks, accumulate them and finally do them when server load is low, schedule a task or even push them to a different server to do your checks there.
Always try to prioritize serving users over doing background jobs like uploading files to the cloud.
Additionally to @mscdex three ideas I want to mention CSS. The easiest non-script way to visually rearrange your form without ever touching the DOM. That should be the first or second idea that comes to mind imho.

@mscdex OK thanks for answer. I did arrange files so that they are sent last. But still has issues due to the implantation I was using. ( Basically co-busboy where I replaced the Chan module for async-csp ). I ended up writing a small wrapper around busboy to get a half promise half CSP based interface that solved my issues.
@minecrawler Yeah that makes sense. Thanks for the input.


3029 command to recover SOLR index while online

Here is a management command to reindex SOLR while online.
usage: ./hsctl managepy solr_recover
or ./hsctl managepy solr_recover {resource-id}
Tested on cuahsi-dev-1 and led to complete recovery of SOLR function.

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[x] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]
After running the scripts, all resources appear in discovery page.

I would suggest simply copying this into the running image on www and running it. It is designed for that.
This will get us out of the woods for AGU.

Note: in the next release of management commands, I have eliminated the redundancy in management commands (like this one). That will be a 1.17.1 component.

@sblack-usu @martinseul @dtarb Note: I have to teach now. I will be offline for a while. Please feel free to merge this to develop when the checks are done. Otherwise I will do so when I'm available again at, e.g., 7:30 pm EST.


pod-gateway wrong default for vpn sidecar ?

Default values for openvpn sidecar  are setted with openvpn port 443 and protocol UDP, seems not correct for me (usually 1194 UDP and 443 TCP)
Changing network policy (in my case to honorate 1194 UDP) openvpn works .
Can you confirm me ?
Thanks

Thanks for reporting @lucacalcaterra - it is indeed an inconsistent default so I did a PR to change it.


Cannot declare supertype or subtype inside submodule of crate

MWE:
use typesets::Supertype;
use typesets::TypesetsError;

#[derive(Debug, Supertype)]
pub enum Animal {
    #[subtype(Mammal)]
    Cat,
    #[subtype(Mammal)]
    Dog,
    Frog,
    Lizard,
}

If this is in the root of a crate, then it doesn’t throw an error.
If this is in a submodule, then the following error occurs:
error[E0412]: cannot find type `TypesetsError` in the crate root
   --> src/mgc/syllable.rs:140:17
    |
140 | #[derive(Debug, Supertype)]
    |                 ^^^^^^^^^ not found in the crate root
    |
    = note: this error originates in the derive macro `Supertype` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider importing this enum
    |
1   | use typesets::TypesetsError;
    |

warning: unused import: `typesets::TypesetsError`
   --> src/mgc/syllable.rs:138:5
    |
138 | use typesets::TypesetsError;
    |     ^^^^^^^^^^^^^^^^^^^^^^^

error[E0284]: type annotations needed: cannot satisfy `<Mammal as TryFrom<Animal>>::Error == _`
   --> src/mgc/syllable.rs:140:17
    |
140 | #[derive(Debug, Supertype)]
    |                 ^^^^^^^^^ cannot satisfy `<Mammal as TryFrom<Animal>>::Error == _`
    |
    = note: this error originates in the derive macro `Supertype` (in Nightly builds, run with -Z macro-backtrace for more info)

Fix: fully qualify the name of TypesetsError in gen_enum.rs:48 (::typesets::TypesetsError)

Note that a workaround is to import TypesetsError in the crate root.


Space in single line objects

Rule(s) related to or rule(s) missing
I'm searching for a way which I can force a space around object in single lines.
Expected behavior
+{{ include('app/atoms/icon.html.twig', { icon: 'time' }, with_context = false) }
-{{ include('app/atoms/icon.html.twig', {icon: 'time'}, with_context = false) }}

Actual behavior
-{{ include('app/atoms/icon.html.twig', { icon: 'time' }, with_context = false) }
+{{ include('app/atoms/icon.html.twig', {icon: 'time'}, with_context = false) }}

This was developed to follow the twig standard https://twig.symfony.com/doc/3.x/coding_standards.html
With the following example {{ {'foo': 'bar'} }}.
But it should be able to configure this with some development.
Currently the check is made by this Sniff: https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/src/Sniff/PunctuationSpacingSniff.php
The idea would be to configure it like this:
$ruleset = new TwigCsFixer\Ruleset\Ruleset();
$ruleset->addStandard(new TwigCsFixer\Standard\Generic());
$ruleset->addSniff(new TwigCsFixer\Sniff\PunctuationSpacingSniff([
    'before' => ['}' => 1],
    'after' => ['{' => 1],
]));

or
$ruleset = new TwigCsFixer\Ruleset\Ruleset();
$ruleset->addStandard(new TwigCsFixer\Standard\Generic());
$ruleset->addSniff(new TwigCsFixer\Sniff\PunctuationSpacingSniff([
    '}' => ['before' => 1],
    '{' => ['after' => 1],
]));

or another syntax (I dunno which one is the best).
WDYT about this solution ?

The configuration looks good but I'm not sure if we run into problems with single vs multi line or how we can handle that:
{{ include('app/atoms/icon.html.twig', { icon: 'time' }, with_context = false) }

vs.
{{ include('app/atoms/icon.html.twig', {
    icon: 'time',
    space: '20',
}, with_context = false) }}

{{ include('app/atoms/icon.html.twig', {
    icon: 'time',
    space: '20',
}, with_context = false) }}

There is already the check
https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/src/Sniff/AbstractSpacingSniff.php#L45-L49
"If the next token is a new line, do nothing".
And
https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/src/Sniff/AbstractSpacingSniff.php#L85-L89
"If the previous token is a new line, do nothing".
So it shouldn't be an issue.

Also a little hint to the twig internals. Twig allow to be customized the tags: https://twig.symfony.com/doc/3.x/recipes.html#customizing-the-syntax. I'm not sure if you are using the twig lexer, twig parser, if we should use the Token constants of Twig itself so the cs fixer could be used with customized things. https://github.com/twigphp/Twig/blob/b5ec7ab1cdfebf3e0ab0a5fddc342dbd903763fa/src/Token.php#L34

So it shouldn't be an issue.

That looks great 👍

Also a little hint to the twig internals. Twig allow to be customized the tags: https://twig.symfony.com/doc/3.x/recipes.html#customizing-the-syntax. I'm not sure if you are using the twig lexer, twig parser, if we should use the Token constants of Twig itself so the cs fixer could be able to understand custom syntax. https://github.com/twigphp/Twig/blob/b5ec7ab1cdfebf3e0ab0a5fddc342dbd903763fa/src/Token.php#L34

I use my own constant, but some of them are Twig-based
https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/src/Token/Token.php#L12-L39
And my Lexer is more complex than, but similar to, the Twig one
https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/src/Token/Tokenizer.php#L16
And currently I would say it doesn't work if {{, {#,  {% are not used.

So it shouldn't be an issue.

That looks great 👍

Do you want to try a PR ?
I would say the best conf could be one array for the Before, one array for the after.
// What you want
$ruleset->addSniff(new TwigCsFixer\Sniff\PunctuationSpacingSniff(
    ['}' => 1],
    ['{' => 1],
));
// Another way to use it
$ruleset->addSniff(new TwigCsFixer\Sniff\PunctuationSpacingSniff(
    ['}' => 1, ']' => 1],
    ['{' => 1, '[' => 1],
));
// A way to disable check for `{` and `}`
$ruleset->addSniff(new TwigCsFixer\Sniff\PunctuationSpacingSniff(
    ['}' => null],
    ['{' => null]
));

@VincentLanglet I will try it at the weekend maybe. If somebody else want to implement before me, they can feel free todo it :)

@VincentLanglet I will try it at the weekend maybe. If somebody else want to implement before me, they can feel free todo it :)

Ping me if you need help

I made something if you wanna try https://github.com/VincentLanglet/Twig-CS-Fixer/pull/92 @alexander-schranz

@VincentLanglet the rule itself works like expected. I found one little edge case which is an empty object:
-{%- set additionalAttributes = attr|default({})|aria_data_attributes -%}
+{%- set additionalAttributes = attr|default({ })|aria_data_attributes -%}

I did just stumble over the cache. I think it would be great that the cache is not longer valid when:

A new twig-cs-fixer version is installed
The ruleset is changed, or ruleset options are changed

As the ruleset was not applied to all files instead only the files I changed since last run.

@VincentLanglet the rule itself works like expected. I found one little edge case which is an empty object:
-{%- set additionalAttributes = attr|default({})|aria_data_attributes -%}
+{%- set additionalAttributes = attr|default({ })|aria_data_attributes -%}

I'm not sure how to solve this.
With the config changes, the rule is literally asking for one space after {, and one space before }.
It seems not easy to add configurable special cases.

I did just stumble over the cache. I think it would be great that the cache is not longer valid when:

A new twig-cs-fixer version is installed
The ruleset is changed, or ruleset options are changed

As the ruleset was not applied to all files instead only the files I changed since last run.

Will take a look

@VincentLanglet not sure if I would complicate it to much and make currently just 1 given into that rule e.g.: new TwigCsFixer\Sniff\PunctuationSpacingSnif and keep the other things currently as defaults aslong as no more options are really required or requested by others.

The issue with
new TwigCsFixer\Sniff\PunctuationSpacingSnif(space: 1)

is that PunctuationSpacingSnif is working with every punctuation
private const SPACE_BEFORE = [
        ')' => 0,
        ']' => 0,
        '}' => 0,
        ':' => 0,
        '.' => 0,
        ',' => 0,
        '|' => 0,
    ];
    private const SPACE_AFTER = [
        '(' => 0,
        '[' => 0,
        '{' => 0,
        '.' => 0,
        '|' => 0,
        ':' => 1,
        ',' => 1,
    ];

So if you just give space: 1 it will override every token...
That's why I wanted to find something per token.


feat(trivy): Add dbRepository flag to get advisory database from OCI registry

This PR adds --db-repository flag to trivy plugin and helm config. The flag is introduced in https://github.com/aquasecurity/trivy/pull/1873
Related issue in GitLab: #350232

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@knqyf263 Could you please review this dependent PR also? Thanks 🙂

@chen-keinan Thanks for the comments, I've addressed them 🙂 Could you please take an another look?

@chen-keinan Thanks for the comments, I've addressed them 🙂 Could you please take an another look?

Thank you for the update; LGTM!!

Note that --db-repository was added in v0.25.1, but it had a critical bug. Please use v0.25.2 or greater.

@ksashikumar this PR should also include the trivy version change from : trivy:0.24.2 to trivy:0.25.1 (the version that support --db-repository flag)  Its used in various places in the code:
example: values.yaml , starboard.yaml etc. (test files)

@ksashikumar this PR should also include the trivy version change from : trivy:0.24.2 to trivy:0.25.2 (the version that support --db-repository flag) Its used in various places in the code: example: values.yaml , starboard.yaml etc. (test files)

@chen-keinan Thanks for that! I've updated the version in the files. Could you please take another look?

@ksashikumar thank you for this effort; LGTM.

@ksashikumar thank you for this effort; need also to update trivy version on itest--> matcher.go and matcher_test.go I think this is the cause for the Integration tests --> Run integration tests / Starboard CLI to fail

@chen-keinan Oops, I missed that. Thanks for letting me know. I've fixed that 👍


[Navigation Material] Standard (persistent) bottom sheet layout support

Description
At the moment I can only see support for ModalBottomSheetLayout, but I am wondering if the material 3 standard bottom sheet will also be supported in the future?
With the modal bottom sheet open, the user cannot interact with the active screen.

Hi, we only offer support for modal bottom sheets.

Like dialogs, modal bottom sheets appear in front of app content, disabling all other app functionality when they appear, and remaining on screen until confirmed, dismissed, or a required action has been taken.

Modals make sense as global navigation routes because they are independent and not tied to local content.

Standard bottom sheets co-exist with the screen’s main UI region and allow for simultaneously viewing and interacting with both regions

Standard bottom sheets are tied to a specific screen, thus a navigation destination for them does not provide any benefit.
We currently don't see any use case for standard bottom sheet destinations.


[Setup] Check CUDA_HOME instead of cuda.is_available() in setup.py

This is to solve #177
The issue is when building a docker image, torch.cuda.is_available() always shows False even CUDA_HOME is available. This seems normal to me because you don't need GPUs but just CUDA (or nvcc).
With this change, I could use the following Dockerfile to build an image:
FROM nvcr.io/nvidia/pytorch:22.12-py3
RUN apt update
RUN pip uninstall -y torch

RUN git clone https://github.com/comaniac/vllm.git /vllm; \
    cd /vllm; git checkout -b comaniac-patch-1; origin/comaniac-patch-1; \
    pip install -e .
ENV PYTHONPATH "/vllm:${PYTHONPATH}"

using
docker build -t vllm .

cc @WoosukKwon

Oops just found this PR is duplicated to #269. @WoosukKwon @zhuohan123 please let me know if you prefer to close this one or whatever.

Added @neubig as a co-author of this PR for identifying the issue in #269.


Invoke google.maps.event.trigger("resize")?

Is it possible to invoke resize on the map component? I have the map in a tab that is hidden on render and the map is therefor not shown when the tab is chosen.
I know about the modal solution but i don't want to rerender the map all the time.

Please read https://github.com/istarkov/google-map-react/issues/106#issuecomment-187944697
What are you think about proposed solution

The proposed solution to change center after _setViewSize did'nt work for me. I have two tabs where the map is rendered in the second hidden one, and i do the setViewSize in a postRenderCallback from the tabs component. I am using Redux and the tabs is onsen UI. I tryed setting the size of the container using css but the map is still gray. Any suggestions?

@istarkov you could check size of the map container on componentDidUpdate and store it in an instance variable of the google map, and trigger refresh when width or height changes-this would work as long as the parent component doesn't override shouldComponentUpdate I think
btw I'm having issues where the internal _setViewSize call isn't recalculating positions of the children

Looks like most sizing issues shoud be fixed by this PR #219
just use resetBoundsOnResize={true}
It works perfectly with resizable elements.

@moodysalem  In most cases checking element size on each update is not a good idea, as in all modern browsers this operation caused reflow.
please check latest npm version and set resetBoundsOnResize={true} on the map.

It works for me, thanks

Thanks is not for me, but for @RUPOJS
he did that amazing PR.

Amazing! This property is missing in the api docs, isn't? @istarkov

Half of features are missing in the documentation ;-)


feat: account cards

Ignore numbers, my test data is a bit messy

I did not understand what exactly was changed, but I do not think I see something that breaks anything, waiting for other reviews 👍

Thanks for reviewing 👍  the changes are the 3 boxes at the top of the page above the graph


Move TCL test unit/type/list-3 to Go case

I would like to do this task :)

@suica assigned. Go ahead!


sync: RWMutex.RLock is 2x slower than Mutex.Lock

What version of Go are you using (go version)?

go version go1.14 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/gaurav/.cache/go-build"
GOENV="/home/gaurav/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/gaurav/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.14"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.14/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build924554981=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Ran a benchmark with sync.Mutex vs sync.RWMutex and found the mutex.Lock() to be 2x faster than the RWMutex.RLock()
Description: Two scenarios (with lock and rwlock) with 1000 goroutines contending to read data from a slice (size = 10) and write to independent files.
https://play.golang.com/p/RZ-bE3OJ4H5
Output: Lock vs RWLocks()  in seconds
Locks			RWLocks
2.589610687s		5.52346426s
2.693844854s		6.13264221s
2.574230731s		6.857576762s
What did you expect to see?
Expected to see RWLock() to be atleast twice as fast than Lock()
What did you see instead?
Lock() is faster than RWLock() by almost 2X, then what's the point of having the RWMutex in the first place ?

RWMutex of course lets multiple goroutines hold the read lock in parallel, so there is a reason to have it even if it is slower.  It's pretty much sure to be slower than Mutex since it has a more complicated job to do.  But 2x slower does seem a bit surprising.

I suspect that your test is more about collisions on the single output file when using RWMutex than it is about a comparison between RWMutex and Mutex.

@ianlancetaylor , thanks for the analysis and valuable insights. That makes sense to me. So the single output file really became the point of contention for the goroutines. I did another experiment and that validates your point. Now, instead of writing to a file, I simply append the values to a temporary slice within the goroutine (which will be automatically garbage collected) and now the results make more sense.
Benchmark results:
Locks RWLocks
19.174382ms		6.887933ms
18.217681ms		6.904993ms
16.707576ms		12.16411ms
16.437133ms		12.819353ms
15.81977ms		7.775752ms
17.277763ms		12.772043ms
16.645841ms		14.092959ms
17.154119ms		6.893917ms
code link: https://play.golang.com/p/zf0n9ytgH4E

Id be concerned that your program is benchmarking heap growth and gc performance.
 If you did that you would benefit from the tools like -count, -cpu and benchstat.

Thanks.  I don't think there is any action to take here, so I'm inclined to close this issue.  We're always interested in performance improvements, of course, but I don't see anything here that leads to any promising approach to better performance.

@ianlancetaylor , sure I agree. Thanks again for the clarification.

RWMutex could stand a bit of an overhaul in general. (See also #17973.)


new notebook - TGI + SageMaker + Mistral

What does this PR do?
This PR includes a new notebook that shows how to compile and deploy Mistral-7B to a SageMaker endpoint with Inf2.
I also updated the notebooks.mdx page with a link to the notebook.

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[X] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!


list of missing 1.16 items

issue setup for the missing 1.16 items to be added

Basalt
Polished basalt
Smooth basalt
chain
Warped Fungus on a Stick
Warped Fungus
crimson_fungus
crimson roots
warped roots
Crying obsidian
Gilded blackstone
Nether gold ore
Nether sprouts
respawn anchor
Shroomlight
Soul lanterns
target
Twisting vines
weeping vines
warped wart block
lodestone_compass
warped fungus on a stick


[ALLUXIO-1877] Making BufferUtils thread safe.

https://alluxio.atlassian.net/browse/ALLUXIO-1877

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9293/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/9297/
Test PASSed.

LGTM. Thanks for the improvement.


scrollspy overlaps "group" checkbox button

On mobile versions or narrow screens the right navigation menu tooltips overlap with the form checkbox control causing a weird UX when filling the form from a mobile device.

#10


fixup: use curl commandline options to setup output-dir

learned in the curl session: https://www.youtube.com/watch?v=V5vZWHP-RqU&pp=ygUObWFzdGVyaW5nIGN1cmw%3D
Note:
We may need to drop ubuntu 20.04 support due it uses a older curl version which does not support this commandline options.

Otherwise it's possible to install curl with homebrew here, but this will not be the case on most machines so maybe some users get this error from the curl command...


Please make a new tag

It's over a year since a tag was made. I took the tip of the development branch and made a tarball (that's now in Ubuntu) on November 5th, but it would be good to get something tagged.
Let us know how we can help, and if there's anything left to complete before you're ready to tag.
Thank you!

Hello,
No objections here, I added only some minor things since then, but new translations alone would deserve it.
The only thing I'm not happy about is the poor sddm configuration handling, which I'm not sure I got how it works with multiple local configurations in /etc/sddm.conf.d.

Sure, I have no issue waiting for that to land. If I find myself with spare time this week, I'd be happy to push some code your way.
Thanks for what you do!
Kind regards,
Simon Quigley
Lubuntu Release Manager

Let me know if you are still busy, we can postpone for another later release, it's not necessary to do that now.

tagged 0.2.0


provide runtime method to register app_version/build number

We have to implement static setBuild in Configuration.java class.
This method should put into R.CONFIG new value for APP_VERSION key and register as zebrunnre reporting testrun artifact if not empty.
Also we have to add this new method into the migration steps (maybe new doc ticket needed for that). Among recommendations replace all project calls
R.CONFIG.put(Parameter.APP_VERSION.getKey(), value);
to
Configuration.setBuild(value);

done except adding migration steps

@vdelendik could you please add carina version and details for verification the ticket.

Verified. Fixed.


Cleanup around Monoid and Algebra test

Some minor things I stumbled upon

Codecov Report

Merging #775 into develop will increase coverage by 0.11%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #775      +/-   ##
===========================================
+ Coverage    89.27%   89.39%   +0.11%
===========================================
  Files          115      115
  Lines         9011     9011
  Branches       335      345      +10
===========================================
+ Hits          8045     8055      +10
+ Misses         966      956      -10

Impacted Files
Coverage Δ

...e/src/main/scala/com/twitter/algebird/Monoid.scala
91.26% <100%> (ø)
:arrow_up:

...in/scala/com/twitter/algebird/scalacheck/Gen.scala
90.9% <0%> (-9.1%)
:arrow_down:

.../main/scala/com/twitter/algebird/BloomFilter.scala
93.8% <0%> (-1.33%)
:arrow_down:

.../main/scala/com/twitter/algebird/Successible.scala
91.66% <0%> (+4.16%)
:arrow_up:

...ain/scala/com/twitter/algebird/AdaptiveCache.scala
77.77% <0%> (+5.55%)
:arrow_up:

...src/main/scala/com/twitter/algebird/Interval.scala
82.6% <0%> (+6.08%)
:arrow_up:

...ala/com/twitter/algebird/ApproximateProperty.scala
82% <0%> (+10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5ae8f0...2701fe3. Read the comment docs.


How to return insert id?

insertMail(recipientID, senderName, senderID, postcardDetails, sentDate, postcardType) {
		return this.knex("mail").insert({
			recipientID: recipientID,
			senderName: senderName,
			senderID: senderID,
			details: postcardDetails,
			date: sentDate,
			type: postcardType
		})
	}

How can I get the insert id from this?

https://knexjs.org/#Builder-returning

and https://knexjs.org/#Builder-insert for more general case


Adding support to run commands on more pod containers

Adding support to run commands on any pod container.
Updated PVC scenario.

rerun

LGTM!