Block edit assignee and mark as complete simultaneously

Details

Tapping assignee then marking the task as complete at the same time navigates to not found page. This PR applies singleExecution to those functions.
Fixed Issues

$ https://github.com/Expensify/App/issues/38577
PROPOSAL: https://github.com/Expensify/App/issues/38577#issuecomment-2018491026
Tests

Open a task report
Tap Assignee then quickly tap Mark as complete
Verify that user is navigated to Assignee page only

[x] Verify that no errors appear in the JS console

Offline tests

NA
QA Steps

Open a task report
Tap Assignee then quickly tap Mark as complete
Verify that user is navigated to Assignee page only

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/113963320/472f3aa6-7acf-4556-9d06-5ddd95e6ee75

Android: mWeb Chrome

https://github.com/Expensify/App/assets/113963320/94044438-53a8-4787-bcec-21958a5d0a41

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@tienifr Can we please have videos for all platforms?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/3069065/4e0d5ce2-aa0b-4934-a358-2c7d328b47e8

Android: mWeb Chrome
https://github.com/Expensify/App/assets/3069065/2bcd4dad-05b5-44df-ad4f-d0b5cd29e708

iOS: Native
https://github.com/Expensify/App/assets/3069065/91bc16b9-4d72-447c-a253-9e86c38e2d2b

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/888f293d-876d-4544-bee9-dc2fa6e5ef9b

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/dbf01b50-98c4-46c0-8e55-2e4022965b64

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/7378f01b-0d72-46e0-895a-bfa1a326007a

Thanks for notifying @tienifr.

Thanks I'll check this tomorrow.

Hey @mananjadhav did you get a chance to check the latest updates here?

I reviewed the changes, need to work on the checklist which I'll finish today.

@rlinoz Can you please trigger the adhoc builds again? especially for Android.

I'm not being able to hide the keyboard when pressing the back button on the description screen, but I think it is not related to this PR..

Thanks for the builds. Testing it now.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/f068ee93-6389-488d-919d-7ebea1cd1728

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/a4037f9a-b32b-4ff2-a69b-e9c2bc69e13e

MacOS: Desktop
https://github.com/Expensify/App/assets/3069065/68f9e373-8826-4b08-a9b2-0a8766b6ab1c

Let me try again.

Looks like it is working fine in this last version.

@mananjadhav can you complete the checklist, please?

@rlinoz Just did. all yours.

Reverted the PR because I could reproduce the issue above and it was causing another blocker.

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Adding LMQ support

Hi @EnotYoyo,
Found you project quite interesting. I would like to participate on it to add LightningMcQueen support.
If you agree I can push my first branch. I am not an expert in Python, dev might be slow as I am also sniffing BT packets to find missing command.
If you do not, no pb, I’ll fork.
Thanks for what you've done

Hi!
Yes. You can create pull request, I'll review and merge it.

Cool!
Try to push my branch, but I cannot. I guess you need to add me somehow.
remote: Permission to EnotYoyo/pysphero.git denied to MatP-MatP.
fatal: unable to access 'https://github.com/EnotYoyo/pysphero.git/': The requested URL returned error: 403

You must fork the repository. After, create some changes, push it into your repository and create pull request to my repository.  It's detailed here and here

Thanks, not familiar with open projects. Did my first PR.

I close this.


Is this using Python 3 or Python 2?

In the script, there is import http.server which is Python 3.
But when I run it using Python 3, it requires cv2 which only Python 2 can run.

I used anaconda and conda install -c menpo opencv3

cv2 is Python 2 only?
Can't you just install it with pip3 opencv-python?

You can use prebuilt cv2 for Python3 here.
http://www.lfd.uci.edu/~gohlke/pythonlibs/

readme is updated


docs: add git support

Signed-off-by: Batuhan Apaydın<EMAIL_ADDRESS>Co-authored-by: Furkan Türkal<EMAIL_ADDRESS>Co-authored-by: Erkan Zileli<EMAIL_ADDRESS>
[x] waiting to add a sample of retrieving public-key support
👀 sigstore/cosign#939

Summary

Add git support documentation of cosign
Ticket Link

Fixes
Release Note

docs: add git support

@lukehinds can we merge this one if you are ok with this?


NooBaa read_system throwing error "Cannot read property 'exec_account' of undefined"

Environment info

NooBaa Version: 5.8
Platform: OCP 4.8

Actual behavior

read system failed with

Aug-18 4:21:51.022 [WebServer/34] [ERROR] CONSOLE:: RPC._on_request: ERROR srv system_api.read_system reqid wss://noobaa-mgmt.openshift-storage.svc.cluster.local:443/rpc/-1059722 connid ws://[::ffff:<IP_ADDRESS>]:48262/(31933lxs0) TypeError: Cannot read property 'exec_account' of undefined
    at /root/node_modules/noobaa-core/src/server/system_services/bucket_server.js:1498:69
    at arrayMap (/root/node_modules/noobaa-core/node_modules/lodash/lodash.js:653:23)
    at Function.map (/root/node_modules/noobaa-core/node_modules/lodash/lodash.js:9622:14)
    at Object.get_bucket_info (/root/node_modules/noobaa-core/src/server/system_services/bucket_server.js:1491:23)
    at /root/node_modules/noobaa-core/src/server/system_services/system_server.js:593:39
    at Array.map (<anonymous>)
    at Object.read_system (/root/node_modules/noobaa-core/src/server/system_services/system_server.js:588:93)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async /root/node_modules/noobaa-core/src/rpc/rpc.js:340:32

The system itself had both functions and triggers enabled.
Once deleted, the system returned to function.
Expected behavior

Using functions and triggers should not break read system

Steps to reproduce

Unknown

More information - Screenshots / Logs / Other output

Closing, Dup of https://github.com/noobaa/noobaa-core/issues/7054


Remove trailing slash from recent dir if needed

This should fix #49453. I've used a similar logic that is present in favorites.

Note that there's already an open pull request trying to fix this: https://github.com/godotengine/godot/pull/49500

Yes, I've noticed it after I finished my fix ;) But the last comment there starts with:

Thanks for the revision! Unfortunately, though, building with that code, I found that the bug was still present. Thus that code does not fix issue #49453.

I assumed that I can submit my own PR, but I understand if you prefer to merge #49500 instead ;)

Thanks!

Cherry-picked for 3.4.

Cherry-picked for 3.3.3.


Move FetchingJSONSchemaStore to quicktype-core to allow it to be used  in applications using quicktype as a library

quicktype-core includes a JSONSchemaStore class that can be used to load JSON schema files however this does not support resolving JSON schema references ($ref) to different files or URI's.
The quicktype CLI supports resolving references to other files or URI's using a FetchingJSONSchemaStore that extends the JSONSchemaStore exposed by quicktype-core.
When using quicktype programmatically via quicktype-core it is useful to be able to resolve JSON schema's that reference other files and URI's.
This change moves the FetchingJSONSchemaStore from the cli to quicktype-core to enable programmatic use. This avoids users of quicktype-core  needing to re-implement this functionality.
All this change really involves is moving the FetchingJSONSchemaStore  and its dependencies to quicktype-core, then exporting the class and its dependencies and updating imports.
Testing
script/dev
npm run build
npm run test

Doesn't this make quicktype-core require Node?  quicktype-core must be able to run in the browser, too.

Doesn't this make quicktype-core require Node? quicktype-core must be able to run in the browser, too.

Apologies I did not realize it was a requirement for quicktype-core to run in the browser.  With this change that would be achievable using webpack or Browserify but it would be wrong to force consumers to use a particular build system.
That said I still feel that the functionality in FetchingJSONSchemaStore is valuable to expose as it is quite common for JSON schemas to reference other files or URI's. This does not really apply to browsers though as it references to other files depend on a file system.
Would it be acceptable to simply export FetchingJSONSchemaStore from quciktype ? so that any consumers who want to use the FetchingJSONSchemaStore could depend on both quicktype and quicktype-core.

I believe we can use isomorphic-unfetch for fetch that works in browser and node, then move this to quicktype-core. Please try it.

Thanks for suggestion Im happy to try that but the `FetchingJSONSchemaStore also uses Node's FS module to read files as a stream. Im not sure if that is even possible in browser as browsers have limited access to the file system

@dvdsgl @schani, I have done some research and I do not think it is possible for code running in the browser to open arbitrary files without user input. If this was possible it would obviously be a massive security vulnerability.
Would it be acceptable to change the FetchingJSONSchemaStore to use isomorphic-fetch so that it will be able to resolve schemas that are available at a URL both in Node and the browser and then throw some kind of invalid usage exception if the the $ref is a relative file path when not running in Node ?

I'm ok with that.

I've added a new revision that makes the FetchingJSONSchemaStore isomorphic. The change

Switches to using isomorphic-fetch instead of node fetch
Switches to readable-stream (isomorphic replacement for node strem)
User browser or node to guard calls to fs so we do not try to call methods on fs when in the browser
Added the following to the package.json for quicktype-core to make bundlers for the browser handle imports of fs

"browser": {
        "fs": false
    }

I saw that the build kite diff-against-last-master step failed. I have struggled to figure out how to reproduce this locally in order to debug. Im not even sure what it is that is being tested by that  test step.
Any pointers would be much appreciated.
Thanks !


Prevent default zoom on double click of node

On double click of node , its doing default action and zooming canvas . Is it possible to stop default action because I have custom action  to do on double click .
s.bind('doubleClickNode', function(e) {
	//e.preventDefault();  //  This does not work

      // Some custom action
});

You can set sigma's doubleClickEnabled setting to false, which will disable the standard zoom behaviour, while at the same time still allowing you to make use of the doubleClickNode event:
s.settings('doubleClickEnabled', false);

You can set sigma's doubleClickEnabled setting to false, which will disable the standard zoom behaviour, while at the same time still allowing you to make use of the doubleClickNode event:
s.settings('doubleClickEnabled', false);

I want double click on canvas to zoom but not in node , will this will solve my problem ? @AVermeij

In that case, you'd be best off setting doubleClickEnabled to false each time a user enters a node, then to set it back again to its regular behavior when a user exits a node. You can do this using the overNode and outNode events:
s.bind('overNode', function(e) {
  s.settings('doubleClickEnabled', false);
});

s.bind('outNode', function(e) {
  s.settings('doubleClickEnabled', true);
});

Brilliant it worked like charm !! Thanks @AVermeij

Just a little note that if your instance is already activated you will need to use
sigma.instances(0).settings({doubleClickEnabled: false});

It seems this answer does not work anymore ...

This answer is for sigma v1, not for the current version.
You can prevent the default behavior of the double click like that :
sigma.on("doubleClick", (event) => event.preventSigmaDefault());

Any tips how to achieve this on v3? sigma.on("doubleClick", (event) => event.preventSigmaDefault()); does not work for me 😿

Any tips how to achieve this on v3? sigma.on("doubleClick", (event) => event.preventSigmaDefault()); does not work for me 😿

It worked for me through destructuring:
function doubleClickNode({ node, event }) {
                event.preventSigmaDefault();
                //...
}


I am going to pull it as I see a change can be pushed on the kubernetes.io page

<!-- 🛈

 Hello!

 I would like to let you know that one of the page needs an update in the yaml. The contsraint template at https://kubernetes.io/blog/2019/08/06/opa-gatekeeper-policy-and-governance-for-kubernetes/ needs an update of the voilation which is missing.

instead of deny it should ne violation. Here is the revised yaml after I corrected it:

apiVersion: templates.gatekeeper.sh/v1beta1
kind: ConstraintTemplate
metadata:
name: k8srequiredlabels
spec:
crd:
spec:
names:
kind: K8sRequiredLabels
listKind: K8sRequiredLabelsList
plural: k8srequiredlabels
singular: k8srequiredlabels
validation:
# Schema for the parameters field
openAPIV3Schema:
properties:
labels:
type: array
items: string
targets:
- target: admission.k8s.gatekeeper.sh
rego: |
package k8srequiredlabels

    **violation[**{"msg": msg, "details": {"missing_labels": missing}}] { // this line needs update
      provided := {label | input.review.object.metadata.labels[label]}
      required := {label | label := input.parameters.labels[_]}
      missing := required - provided
      count(missing) > 0
      msg := sprintf("you must provide labels: %v", [missing])
    }

/assign @kbarnard10
Allow me to pull the repo. I intend to change the content template given as an example https://kubernetes.io/blog/2019/08/06/opa-gatekeeper-policy-and-governance-for-kubernetes/
This needs a change of one variable, instead of deny it should be violation, here is the change:
deny[**{"msg": msg, "details": {"missing_labels": missing}}] { // this is the current line
violation[{"msg": msg, "details": {"missing_labels": missing}}] { // deny should be changed to violation for it to work

/assign @kbarnard10
Allow me to pull the repo. I intend to change the content template given as an example https://kubernetes.io/blog/2019/08/06/opa-gatekeeper-policy-and-governance-for-kubernetes/
This needs a change of one variable, instead of deny it should be violation, here is the change:
deny[**{"msg": msg, "details": {"missing_labels": missing}}] { // this is the current line
violation[{"msg": msg, "details": {"missing_labels": missing}}] { // deny should be changed to violation for it to work

Hello @ShubhasisMathur .
Thanks for opening this pull request.
Is this related to issue #25976?
If so, you should create a branch with your changes to merge to the master branch, not dev-1.21.
For more information, see the contributing guide:
https://kubernetes.io/docs/contribute/
https://kubernetes.io/docs/contribute/new-content/open-a-pr/#fork-the-repo
If you need more information or help, you can reach out on Slack.

Hello @ShubhasisMathur .
Thanks for opening this pull request.
Is this related to issue #25976?
If so, you should create a branch with your changes to merge to the master branch, not dev-1.21.
For more information, see the contributing guide:
https://kubernetes.io/docs/contribute/
https://kubernetes.io/docs/contribute/new-content/open-a-pr/#fork-the-repo
If you need more information or help, you can reach out on Slack.

/hold

/hold

What is this? Is it an automation for merging changes in master to dev-1.21?

What is this? Is it an automation for merging changes in master to dev-1.21?

As this PR does not make sense (description is blank) and the changes neither, I will close it.
/close

As this PR does not make sense (description is blank) and the changes neither, I will close it.
/close

@sftim My observation is that this PR automagically pulls all PRs merged into master and include them here to the dev-1.21 branch. Isn't that a time saver?

@sftim My observation is that this PR automagically pulls all PRs merged into master and include them here to the dev-1.21 branch. Isn't that a time saver?

@sftim My observation is that this PR automagically pulls all PRs merged into master and include them here to the dev-1.21 branch. Isn't that a time saver?

@tengqm, No. It is not clear what the author intends to do with this pull request.

@sftim My observation is that this PR automagically pulls all PRs merged into master and include them here to the dev-1.21 branch. Isn't that a time saver?

@tengqm, No. It is not clear what the author intends to do with this pull request.

@kbhawkey I've been watching this PR since it was submitted. I had the same question ... what the .. is it? During the past 2 days, what I saw was that all PRs merged into the master branch are automatically added into this PR. It doesn't look like there is a human sitting there watching the changes.
@ShubhasisMathur Can you help clarify the purpose of this PR and see if we can improve it somehow?

@kbhawkey I've been watching this PR since it was submitted. I had the same question ... what the .. is it? During the past 2 days, what I saw was that all PRs merged into the master branch are automatically added into this PR. It doesn't look like there is a human sitting there watching the changes.
@ShubhasisMathur Can you help clarify the purpose of this PR and see if we can improve it somehow?

all PRs merged into the master branch are automatically added into this PR

No magic here. That's because the source branch for this PR is, in fact, master.

all PRs merged into the master branch are automatically added into this PR

No magic here. That's because the source branch for this PR is, in fact, master.

@sftim If I have a PR sourcing the master, empty one, and I propose it to dev-1.21, the PR will get automatically updated when something merged into master? I never know that.

@sftim If I have a PR sourcing the master, empty one, and I propose it to dev-1.21, the PR will get automatically updated when something merged into master? I never know that.


Vision: Add validation syntax for extrinsics enforced on transactions

Substrate could provide some syntax to move (or copy) simple ensure! checks into transaction validation "automatically"/very easily.
e.g. with this mock syntax:
#[weight = T::WeightInfo::bid()]
#[validate(value > 0)]
pub fn bid(origin, id: T::AuctionId, #[compact] value: T::Balance) { }

or complementarily:
#[weight = T::WeightInfo::bid()]
#[validate(ensure!(value > 0, "bids need to be higher than 0"))]
pub fn bid(origin, id: T::AuctionId, #[compact] value: T::Balance) { }

Related to #6753 (could maybe be a way of implementing it?)
Depends on #5678

Essentially, your domain of access in #[constraint = ...] is same as weight: You can only read transaction inputs and other data that is known prior to the execution (i.e. is static).
Also, I think the name can be better and is encouraging the user to "you don't need to understand this, it is magic". I prefer making sure the user understand what they are doing: #[validate = ..] fits well with the fact that the pool will validate this (using a runtime api called validate_transaction), but is probably ambiguous to someone unfamiliar. #[pool_validate = ..] might be better.

While the general idea is nice. I'm not sure we really should provide an easy way for this.
The problem is that no one is gone pay for this. These checks should always be very lightweight, which we can not ensure as the user could do anything in there. Normally when we reject such stuff on chain, the sender pays for it. Now, no one is gonna pay for it.
If we implement this, we should do a lot of education around this and what is bad etc!

I think we can already achieve this via SignedExtension so this will just be a syntax sugar.
Another question is when does the validation happen? Before entering tx pool? During block production? After tx inclusion?
We have dry run RPC so we can use it to prevent people from submitting bad tx already.
So unless the plan is to also expose the constraint via metadata, I don't really see why we need this. We already have enough macro magics.

As you already said, this is just syntactic sugar around SignedExtension and the validation always happens before entering the pool and before applying it on chain.

Another question is when does the validation happen? Before entering tx pool? During block production? After tx inclusion?

I don't think the runtime can and should specify that. The runtime provides the cheap checks via validate_transaction api, and when the client/pool calls that is up to them.

While the general idea is nice. I'm not sure we really should provide an easy way for this.
The problem is that no one is gone pay for this. These checks should always be very lightweight, which we can not ensure as the user could do anything in there. Normally when we reject such stuff on chain, the sender pays for it. Now, no one is gonna pay for it.
If we implement this, we should do a lot of education around this and what is bad etc!

Sure, we will need to educate, but as mentioned by others we need to do that for ValidateUnsigned and SignedExtensions as well.

Yes, but there is a difference between putting the shotgun on the table and putting them into some locker :P :D

I wonder whether we disagree on the tradeoff between pruning txs before they enter the tx pool (which this would make easier IIUC) vs making sure that attackers pay for traffic they cause.

making sure that attackers pay for traffic they cause.
is directly related to
pruning txs before they enter the tx pool

If I can send you tons of transactions that you reject before they enter the pool, you still pay the validation price and if there is some heavy computation hidden in this validation, it doesn't end good for you.
We already have seen that a lot struggled with custom SignedExtensions and transaction not being removed properly from the pool and whatever.
Let's take your example:
#[weight = T::WeightInfo::bid()]
#[validate(value > 0)]
pub fn bid(origin, id: T::AuctionId, #[compact] value: T::Balance) { }

Why should an UI send a value which is zero, when we know that zero isn't accepted? Correct, a good behaving UI wouldn't do this. However, when I'm trying to do be evil and sending transactions manually I would start sending with a value of zero. In my opinion you should pay for this, because this is misbehavior.

I feel there are two separate issues here:

Making it easier to write and include pallet-specific SignedExtensions (related #3419 #5006).
Making it easier to express some extra requirements of particular dispatchables and verify them in validate_transaction instead of dispatch phase.

While I'm a huge fan of 1. (see below) for some more details, I don't like 2:

it makes analysing the code harder, cause some assumptions are not expressed as part of the function body, but the metadata (kind of like solidity modifiers which imho are terrible).
it enables the footgun of opening yourself up for a DoS attack. On the first glance it seems "better" to express the conditions as metadata, but since it's not possible to move all of them (due to DoS) you end up with a really unintuitive split. Doing too much in the pre-checks becomes super easy and I don't see any direct gains - Agree with Basti that this is mostly the client / UX issue, not the core responsibility.

Ad.1:
I think this could be achieved with a VerifierSignedExtension<AllModules> composable signed extensions, where the condition would be to have all the auto-included pallet-specific extensions type AdditionalSigned = ();

I agree that this opens the nodes to risk of DoS if the checks are too heavy.
What you don't consider, IMO, is that the nodes will have to perform more work in the case where the extrinsic fails on an ensure inside of the function body. The transaction will be propagate through the network and clog up the transaction pool without contributing in any useful way to the state. Yes, the validators get payed for it, but that is because relevant network resources are used for it.
If the transaction were rejected before going into the pool, the network would spend fewer resources on it.

As a polemic example: You won't propagate a transaction whose encoding is wrong or which is not signed correctly.
So, there will always be transactions that are rejected by the node. I think it should be up to the runtime developer to decide where/shen the checks should happen.

@apopiak

What you don't consider, IMO, is that the nodes will have to perform more work in the case where the extrinsic fails on an ensure inside of the function body.

This is more work, but it paid fore. Validators mist love including a lot of transactions that fail on ensure!, as it is less work than. success, and same money.

I agree that this opens the nodes to risk of DoS if the checks are too heavy.
What you don't consider, IMO, is that the nodes will have to perform more work in the case where the extrinsic fails on an ensure inside of the function body. The transaction will be propagated through the network and clog up the transaction pool without contributing in any useful way to the state. Yes, the validators get payed for it, but that is because relevant network resources are used for it.
If the transaction were rejected before going into the pool, the network would spend fewer resources on it.

This is sensible from an engineering pov, but not economically. Validators would love to include lots of transactions that would fail on ensure, as they pay the full fee with a bit less work.

If the transaction were rejected before going into the pool, the network would spend fewer resources on it.

The network in overall? - perhaps. A single node that receives such transactions? - not really.

You won't propagate a transaction whose encoding is wrong or which is not signed correctly. So, there will always be transactions that are rejected by the node.

Yes, we do draw a line at some point, but do it extremely carefully (on the safe side) to prevent DoS attacks.

I think it should be up to the runtime developer to decide where/when the checks should happen.

And it is via SignedExtensions. The way I read your proposal is that you want to introduce something that seamingly looks like a "good practice" or a "favoured pattern" - i.e. encourage developers to move their ensure statements to "metadata checks" justifying it by having the network do less work in the happy case. I.e. prioritize "network efficiency" / developer friendliness over security. I feel this isn't the right approach, cause it's too easy to shoot yourself in a foot with this one - we don't really have any tooling which would help you decide which checks are fine to be before entering the pool and which are not, also we don't have tooling that makes sure this doesn't get broken over time (for instance refactoring and accidental extra complexity). IMHO we should make all things possible, but we can also favour patterns that are known to be safe (experienced devs can optimize where it really matters in such case by introducing a SignedExtension).

I think instead on focusing on way to express more logic to reject extrinsic when validating them in the transaction.
Logic which is not economically profitable for the block producer, and might open DoS attack to the same block producer.
We should rather focus on making those checks easily identifiable to the UI so that they never send such invalid transaction, probably using metadata. Similar to what is proposed in https://github.com/paritytech/substrate/issues/6753

We should rather focus on making those checks easily identifiable to the UI so that they never send such invalid transaction, probably using metadata. Similar to what is proposed in #6753

:+1: FWIW we have a pretty expressive Rust type system at our disposal. Maybe instead of having u64 we can simply have NonZeroU64 as the input type and this is immediately (with no extra changes) available to UI via Metadata.

If the transaction were rejected before going into the pool, the network would spend fewer resources on it.

This is sensible from an engineering pov, but not economically. Validators would love to include lots of transactions that would fail on ensure, as they pay the full fee with a bit less work.

But we already provide means for free transactions via unsigned transactions and also Pays::No, so we have to grapple with these questions and cannot just defer to "oh validators love to include faulty transactions for fees".

would be a nice luxury to have someday maybe.

interestingly, flies in the face of https://github.com/paritytech/substrate/issues/12331


input Dataset

What is the input dataset and does images.zip, after unzipping have sub folders neg and pos?
Does the dataset only contain sample images without bounding box or annotatations?

LOL. If anyone gets, do send it to me too.. Btw i used the pretrained model using yolo by @BlcaKHat

Well Yeah, i trained it you can use it for general use case.
Hope it's usefull.
Get Outlook for Androidhttps://aka.ms/ghei36

From: Nancy<EMAIL_ADDRESS>Sent: Wednesday, February 5, 2020 10:01:58 AM
To: iamdsc/automatic-helmet-detection<EMAIL_ADDRESS>Cc: vijay singh<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [iamdsc/automatic-helmet-detection] input Dataset (#2)
LOL. If anyone gets, do send it to me too.. Btw i used the pretrained model using yolo by @BlcaKHathttps://github.com/BlcaKHat
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/iamdsc/automatic-helmet-detection/issues/2?email_source=notifications&email_token=AEBPJ54AXXOKHZMBU2NMOH3RBI6L5A5CNFSM4KIFBBSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK2DMNA#issuecomment-582235700, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEBPJ537B7F5SEPLIJPNMKLRBI6L5ANCNFSM4KIFBBSA.

send for me also<EMAIL_ADDRESS>

send for me also please

<EMAIL_ADDRESS>

could you please send me the input dataset also? my gmail is<EMAIL_ADDRESS>thank you so much


Magnetometer not working, and ho to get yaw?

Hello, sorry for maybe asking a stupid question. but i hope someone can help me. I don't know why but my magnetometer value never change it stay on zero all the time. the other function like acce, gyro, roll, pitch works just fine. is the magnetometer not working because the module? i have tried the example only too with no change from myself, but it still the same. also the second question is, how to get yaw value?

 Many people have this issue.  In most cases the problem is that the MPU9250 module does not have MPU9250  IC , but an MPU6500. Please try the "Who Am I" sketch. What does it tell you? Unfortunately I can't tell you where to get correct modules. I once gave a recommendation but then the shop changed from the good to fake modules.

I think there is nothing more to say - I close the issue now.


Allow the use of TweakDBIDs in Create, Clone and DeleteRecord

Currently CET's implementation of CreateRecord, CloneRecord, and DeleteRecord only allow the first parameter to be a string value. Update the functions to allow TweakDBIDs for the first parameter.
Example:
-- Get the sticky frag grenade record
sticky_grenade = TweakDB:GetRecord("Items.GrenadeFragSticky")

-- Create a clone of "Items.GrenadeFragSticky" with the name "Items.GrenadeFragStickyNew"
TweakDB:CloneRecord(sticky_grenade:GetID() + "New", sticky_grenade:GetID())

-- Get the new record
sticky_grenade_new = TweakDB:GetRecord("Items.GrenadeFragStickyNew")
-- or
sticky_grenade_new = TweakDB:GetRecord(sticky_grenade:GetID() + "New")

-- manipulate the new record as needed

-- delete record many different ways
TweakDB:DeleteRecord(sticky_grenade_new:GetID())
TweakDB:DeleteRecord(sticky_grenade:GetID() + "New")
TweakDB:DeleteRecord("Items.GrenadeFragStickyNew")

CreateRecord works in a similar fashion.
Only minor thing is the lack of registering the string value of the record in the LuaVM since the actual string value is never explicitly typed out by the modder. But as shown above, the value can still accessed with the new name since it is hashed before being looked up.

The build error is unrelated to your PR, I will fix it then re-run your PR tomorrow, thanks for your work :)


Remarks about Regex Validation

It appears that RegularExpression always validate as full string, there are no difference between the pattern @"d" and @"^d$". Documentation should specify that or the implementation should be fixed, as this seems more like a bug.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 443a7c53-cc16-7ed5-5950-46a6f195f19c
Version Independent ID: 12fe9329-2cef-4056-4986-18ed7ae5c397
Content: Add validation to an ASP.NET Core MVC app
Content Source: aspnetcore/tutorials/first-mvc-app/validation.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

If you think this is a product bug, create the simplest possible sample that reproduces the problem and open an issue at GitHub ASP.NET Core
Include steps to reproduce the bug and the version you're using dotnet --version


Add option support to deserialize

Right now optional fiels are only supported during serialization, this PR is adding support for kind=option for deserialization as well.

Thanks a lot @ailisp for review. Do you think you could merge it and release new version?

@ailisp just wanted to check if you need me to do anything else before the merge?

@bartosz-lipinski it looks good on my side, great work! @volovyk-s please take another look : )


Not working

I am getting 'false' for each address. (tried @toptal.com, @gmail.com, @yahoo.com).

First blind guess is that either your origin server is blacklisted, or port 25 is closed on your network (as mentioned in readme). Can you please copy / paste here the error you're getting? Thanks

Right, I tried through different ISP and it was working. Looks like port was closed.
Thanks a lot.

 Cheers


URL Parsing Issue

using stable image in docker swarm and getting error:
[ERROR] Controller 1 Auth or Connection Error, retrying: unifi controller: parse ""https://<IP_ADDRESS>:8443"/": first path segment in URL cannot contain colon
[ERROR] parse ""http://influx-General:8086"": first path segment in URL cannot contain colon
I can, via web browser, log in with the credentials and URL without issue.  Using unifipoller for username/password for testing, so no special char issues in the mess.

Your URsL have quotes in them. ""https://<IP_ADDRESS>:8443"" and ""http://influx-General:8086""
If you're not sure why, please share your configuration.

Well, in JSON one would typically quote a string value, and I forgot I'm dealing with YAML and not JSON.  Now that I got rid of the quotes, well, things seems to be working, if I'm reading this line correctly:
[INFO] Everything checks out! Poller started, InfluxDB interval: 30s
But now I'm getting
[ERROR] influxdb.Write(points): {"error":"database not found: "unifi""}
Here's my compose lines for the environment variables
unifi-poller:
378     image: golift/unifi-poller:stable
379     networks:
380       - net
381     environment:
382       - UP_UNIFI_DEFAULT_URL=https://<IP_ADDRESS>:8443
383       - UP_UNIFI_DEFAULT_USER=unifipoller
384       - UP_UNIFI_DEFAULT_PASS=unifipoller
385       - UP_UNIFI_DEFAULT_SAVE_SITES=true
386       - UP_UNIFI_DEFAULT_SAVE_IDS=true
387       - UP_UNIFI_DEFAULT_SAVE_EVENTS=true
388       - UP_UNIFI_DEFAULT_SAVE_ALARMS=true
389       - UP_UNIFI_DEFAULT_SAVE_ANOMALIES=true
390       - UP_UNIFI_DEFAULT_SITE_0=[all]
391       - UP_INFLUXDB_URL=http://influx-General:8086
392       - UP_INFLUX_DB=unifi
393       - UP_INFLUXDB_INTERVAL=30s
394       - UP_PROMETHEUS_DISABLE=true
395     deploy:
396       placement:
397         constraints:
398           - node.role != manager

Did you make the database? Are your creds to access the database right?
Get Outlook for iOShttps://aka.ms/o0ukef

From: Jody L. Whitlock<EMAIL_ADDRESS>Sent: Monday, September 14, 2020 6:51:41 PM
To: unifi-poller/unifi-poller<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: Re: [unifi-poller/unifi-poller] URL Parsing Issue (#267)
Well, in JSON one would typically quote a string value, and I forgot I'm dealing with YAML and not JSON. Now that I got rid of the quotes, well, things seems to be working, if I'm reading this line correctly:
[INFO] Everything checks out! Poller started, InfluxDB interval: 30s
But now I'm getting
[ERROR] influxdb.Write(points): {"error":"database not found: "unifi""}
Here's my compose lines for the environment variables
unifi-poller:
378 image: golift/unifi-poller:stable
379 networks:
380 - net
381 environment:
382 - UP_UNIFI_DEFAULT_URL=https://<IP_ADDRESS>:8443https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2F<IP_ADDRESS>%3A8443%2F&data=02|01||25553ba36e614cec4d6508d85919e665|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637357315053700371&sdata=Wo00HOhseWRAWyVGmWe3bETP9Tc3lsik0RYjTpONIOc%3D&reserved=0
383 - UP_UNIFI_DEFAULT_USER=unifipoller
384 - UP_UNIFI_DEFAULT_PASS=unifipoller
385 - UP_UNIFI_DEFAULT_SAVE_SITES=true
386 - UP_UNIFI_DEFAULT_SAVE_IDS=true
387 - UP_UNIFI_DEFAULT_SAVE_EVENTS=true
388 - UP_UNIFI_DEFAULT_SAVE_ALARMS=true
389 - UP_UNIFI_DEFAULT_SAVE_ANOMALIES=true
390 - UP_UNIFI_DEFAULT_SITE_0=[all]
391 - UP_INFLUXDB_URL=http://influx-General:8086
392 - UP_INFLUX_DB=unifi
393 - UP_INFLUXDB_INTERVAL=30s
394 - UP_PROMETHEUS_DISABLE=true
395 deploy:
396 placement:
397 constraints:
398 - node.role != manager
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Funifi-poller%2Funifi-poller%2Fissues%2F267%23issuecomment-692412314&data=02|01||25553ba36e614cec4d6508d85919e665|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637357315053710361&sdata=rVppw2wM5bdltv0RNBoeY2ZebvnPv1lPLe1eJ2ZYIWU%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXVXG6QSXB2W6Y5HHYIT3SF3CC3ANCNFSM4RMBLUXA&data=02|01||25553ba36e614cec4d6508d85919e665|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637357315053710361&sdata=BXyIkb6wRhGmVNxrKSVCix5xOE4RzR4FhmQ0F7mLhjM%3D&reserved=0.

Glad it's working! Please check back in it you need more assistance.

FWIW, I had this and couldn't figure it out until this thread gave me some prompting. I had it in docker-compose like this:
    environment:
    - UP_UNIFI_DEFAULT_URL="https://<IP_ADDRESS>:443"

That is taken literally, including the quotes. This is correct:
    environment:
    - UP_UNIFI_DEFAULT_URL=https://<IP_ADDRESS>:443

This is true of all fields in a docker-compose.yml (and probably other setup methods). So I probably would have had problems with my UP_UNIFI_DEFAULT_PASS too.
Figured it was worth putting here for posterity.

I guess I could go full shotgun and rip quotes off the strings. We'll see. Thanks for the update!

I don't think it would help much, because once you get to the password it's hard to know what the right thing to do is (well, I guess the odds of a password beginning and ending with quotes is low, though having one or more in the string wouldn't be).
If nothing else, a hint with the error message maybe.

I put about 5 minutes of solid thought into this as I worked through each scenario in my head. Here it is:

If I rip all quotes including the password it will lead folks with a password ending in a quote on an hours-long wild goose chase they cannot win. This is the rarest of these 3 options.
If I rip all quotes including password, folks will not run into the error described in this thread. (same as 1)
If I rip all quotes except the password, folks will now struggle with a bad password error for hours when they quote all their strings.
If I leave it like it is now, folks will get a URL error immediately leading to a bad-quotes conclusion.

I'm leaning toward rip them all off and leave a warning that passwords ending in a quote are unacceptable.

Sounds good!


use copy instead of synchronized

Current coverage is 100.00%

Merging #47 into develop will not affect coverage as of 8e54131

@@            develop     #47   diff @@
=======================================
  Files            21      21
  Stmts           576     571     -5
  Branches         75      75
  Methods           0       0
=======================================
- Hit             576     571     -5
  Partial           0       0
  Missed            0       0

Review entire Coverage Diff as of 8e54131

Powered by Codecov. Updated on successful CI builds.


Error when changing wallet and placing bid

When changing wallet, if you don't clear your cookies you get this error while trying to place a bit (I suspect this is happening while trying to execute any transaction.
Steps to reproduce:

Sign in with an account
Swap to an other account via Metamask
Try to place a bid
Notice error
Clear your cookies
Login with account
Try to place a bid, should work now.

Could you make sure that you did sign the login message when switching the account?
I believe this is related, and this message was never signed, and so the token was never generated.

 Error when changing wallet and placing bid

Could you make sure that you did sign the login message when switching the account? I believe this is related, and this message was never signed, and so the token was never generated.
If this is the issue, then there is definitely an UX issue here and we should probably block the UI with a modal or so

If this is the issue, then the user should not be logged in.
I think this is the same regression I experienced the last few weeks: The UI says I'm still connected but also ask me to sign the authentication message. If I don't sign it, I'm still "connected" but maybe not 100% connected or something like this.

Closing this issue as I wasn't able to reproduce it on the latest version of the starter kit


Networks.java:36-39: Extend create with options to...

The puzzle 224-36c37640 from #224 has to be resolved:
https://github.com/amihaiemil/docker-java-api/blob/95dfab803aa54410ceeb4980faf3467430f01908/src/main/java/com/amihaiemil/docker/Networks.java#L36-L39
The puzzle was created by rultor on 20-Dec-18.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@amihaiemil please pay attention to this new issue.

@amihaiemil/z please, pay attention to this issue

Job #235 is now in scope, role is DEV

The job #235 assigned to @bkuzmic/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@bkuzmic/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat wait for #239 review

@0crat wait for #239 review (here)

@bkuzmic The impediment for #235 was registered successfully by @bkuzmic/z

The puzzle 224-36c37640 has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

The job #235 is now out of scope

Order was finished: +30 point(s) just awarded to @bkuzmic/z


Hyprpm update fails: missing subprojects/wlroots-hyprland

Regression?
No
System Info and Version
 System/Version info
Hyprland, built from branch  at commit 918d8340afd652b011b937d29d5eea0be08467f5  (flake.lock: update).
Date: Tue Jun 25 12:06:02 2024
Tag: v0.41.2, commits: 4886

flags: (if any)

System Information:
System name: Linux
Node name: ryzen
Release: 6.5.7-gentoo
Version: #9 SMP PREEMPT_DYNAMIC Fri Jan 12 10:13:30 EET 2024

os-release: NAME=Gentoo
ID=gentoo
PRETTY_NAME="Gentoo Linux"
ANSI_COLOR="1;32"
HOME_URL="https://www.gentoo.org/"
SUPPORT_URL="https://www.gentoo.org/support/"
BUG_REPORT_URL="https://bugs.gentoo.org/"
VERSION_ID="2.15"

Description
hyprpm update using latest version, seems like the cloned repo is missing subprojects/wlroots-hyprland
Also getting: meson returned: ERROR: Neither source directory 'build' nor build directory None contain a build file meson.build.
How to reproduce
hyprpm update on Gentoo
Crash reports, logs, images, videos
hyprpm.log

post output of hyprpm update -v

this should fix this, but obviously is staged for 0.42.0.
In the meantime, you can compile from git, and just copy the hyprpm binary to your path, and try that.

Same bug on Arch Linux.

post output of hyprpm update -v

hyprpm.log

yes I realize. Have you done what I said above?

@vaxerski Hello, Im kinda new to linux and all this plugin manager stuff, first time using Hyprland btw. Could you explain how to do what you said above? I did not understand how to make it work, thanks!

build hyprland from source and replace your system hyprpm binary with the built one

but how do I build it from source? Sorry if I'm asking a dumb question but i don't know how to do it

https://wiki.hyprland.org/Getting-Started/Installation/
please read the wiki

So, i cloned the repo to my computer, cd into it, ran make all, waited for it to finish, cd into the build folder, copied the hyprpm binary to my /usr/bin/ but it still didn't work. Got the same error, did I do something wrong?

2024-07-22 Arch: installed hyprland from pacman, got the same error. Reinstalled to hyprland-git form aur, clean hyprpm update, works for now.

have you tried --no-shallow?

So, firstly I tried to add --no-shallow to the command, but it did not work and I got the same error message. So I reinstalled to hyprland-git from aur as @greentea-cup suggested. It worked!

hyprland-git from the AUR not working with Nvidia

@m0r4a, can't reproduce your issue.
Ran yay -Syu hyprland-git (or reintsall hyprland-git), then hyprpm update -f.
To ensure usage of graphics card, I opened Hyprland from tty through prime-run.
Everything works like before except hyprpm that yells at me about outdated headers.
Try: updating nvidia drivers, adding environment variables (as per https://wiki.hyprland.org/Nvidia/), configuring system for nvidia usage (as per https://wiki.archlinux.org/title/NVIDIA#Wayland).
Hyprland version before update: (hyprctl version)
Hyprland, built from branch main at commit 7c68236a51291e71db04233d04eae65f4ebd594f  (egl: avoid setting debug mode and handle legacyrenderer).
Date: Tue Jul 23 00:05:22 2024
Tag: v0.41.2-76-g7c68236a, commits: 4962

flags: (if any)

Hyprland version after update:
Hyprland, built from branch main at commit 3c758db95c129ed6ca7ce0c1b5b82ad6e189488d  (renderer/layer-shell: use explicitly set exclusiveEdge (6984)).
Date: Tue Jul 23 00:36:58 2024
Tag: v0.41.2-77-g3c758db9, commits: 4963

flags: (if any)

Thank you for the comment.
I had my Hyprland configuration working before, but the issue was that I didn’t create the /etc/modprobe.d/nvidia.conf file for the new update.
If anyone else reads this comment, please check the documentation for the DRM kernel mode setting.

Can anyone build hl with this patch and retry hyprpm update -v?
diff --git a/hyprpm/src/core/PluginManager.cpp b/hyprpm/src/core/PluginManager.cpp
index 036609f3..edb98812 100644
--- a/hyprpm/src/core/PluginManager.cpp
+++ b/hyprpm/src/core/PluginManager.cpp
@@ -464,7 +464,7 @@ bool CPluginManager::updateHeaders(bool force) {
     progress.m_szCurrentMessage = "Checking out sources";
     progress.print();

-    ret = execAndGet("cd " + WORKINGDIR + " && git checkout " + HLVER.branch + " 2>&1");
+    ret = execAndGet("cd " + WORKINGDIR + " && git checkout " + HLVER.hash + " 2>&1");

     if (m_bVerbose)
         progress.printMessageAbove(std::string{Colors::BLUE} + "[v] " + Colors::RESET + "git returned (co): " + ret);

@fufexan is this what you need?

"hyprpm update -v" command with the lastest git commit
> hyprpm update -v
[v] version returned: Hyprland, built from branch main at commit 33a5c8ce325e1657ec5571b57e05c6378706f4cd  (config: avoid using initial ws tracking for exec-once).
Date: Thu Jul 25 07:29:39 2024
Tag: v0.41.2-98-g33a5c8ce, commits: 4984
flags: (if any)
[v] parsed commit 33a5c8ce325e1657ec5571b57e05c6378706f4cd at branch main on Thu Jul 25 07:29:39 2024, commits 4984
! Cloning https://github.com/hyprwm/hyprland, this might take a moment.
[v] will shallow since: Thu Jul 18 07:29:39 2024
✔ cloned
[v] git returned (co): Already on 'main'
Your branch is up to date with 'origin/main'.
[v] git returned (rs): rm 'subprojects/tracy'
HEAD is now at 33a5c8c config: avoid using initial ws tracking for exec-once
✔ checked out to running ver
! configuring Hyprland
[v] setting PREFIX for cmake to /home/m0r4a/.local/share/hyprpm/headersRoot
[v] cmake returned: CMake Warning (dev) at /usr/share/cmake/Modules/GNUInstallDirs.cmake:253 (message):
Unable to determine default CMAKE_INSTALL_LIBDIR directory because no
target architecture is known.  Please enable at least one language before
including GNUInstallDirs.
Call Stack (most recent call first):
CMakeLists.txt:4 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.
Not searching for unused variables given on the command line.
-- The C compiler identification is GNU 14.1.1
-- The CXX compiler identification is GNU 14.1.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Gathering git info
fatal: No names found, cannot describe anything.
-- Found Python3: /usr/bin/python3.12 (found version "3.12.4") found components: Interpreter
Building itab.c/itab.h...
-- Found PkgConfig: /usr/bin/pkg-config (found version "2.1.1")
-- Found WaylandScanner at /usr/bin/wayland-scanner
-- Found wayland-protocols at //usr/share/wayland-protocols
-- Configuring Hyprland in Release with CMake
-- Checking deps...
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found OpenGL: /usr/lib/libOpenGL.so  found components: GLES3
-- Checking for modules 'aquamarine;xkbcommon;uuid;wayland-server;wayland-client;wayland-cursor;wayland-protocols;cairo;pango;pangocairo;pixman-1;xcursor;libdrm;libinput;hwdata;libseat;libdisplay-info;libliftoff;libudev;gbm;hyprlang>=0.3.2;hyprcursor>=0.1.7;hyprutils>=0.2.0'
--   Found aquamarine, version 0.1.0
--   Found xkbcommon, version 1.7.0
--   Found uuid, version 2.40.2
--   Found wayland-server, version 1.23.0
--   Found wayland-client, version 1.23.0
--   Found wayland-cursor, version 1.23.0
--   Found wayland-protocols, version 1.36
--   Found cairo, version 1.18.0
--   Found pango, version 1.54.0
--   Found pangocairo, version 1.54.0
--   Found pixman-1, version 0.43.4
--   Found xcursor, version 1.2.2
--   Found libdrm, version 2.4.122
--   Found libinput, version 1.26.1
--   Found hwdata, version 0.384
--   Found libseat, version 0.8.0
--   Found libdisplay-info, version 0.2.0
--   Found libliftoff, version 0.5.0
--   Found libudev, version 256
--   Found gbm, version 24.1.4-arch1.2
--   Found hyprlang, version 0.5.2
--   Found hyprcursor, version 0.1.9
--   Found hyprutils, version 0.2.0
-- Looking for execinfo.h
-- Looking for execinfo.h - found
-- Configuration supports execinfo
-- Looking for backtrace in execinfo
-- Looking for backtrace in execinfo - not found
-- Looking for sys/timerfd.h
-- Looking for sys/timerfd.h - found
-- Checking for module 'epoll-shim'
--   Package 'epoll-shim', required by 'virtual:world', not found
-- XWAYLAND Enabled (NO_XWAYLAND not defined) checking deps...
-- Checking for modules 'xcb;xwayland;xcb-util;xcb-render;xcb-xfixes;xcb-icccm;xcb-composite;xcb-res;xcb-ewmh;xcb-errors'
--   Found xcb, version 1.17.0
--   Found xwayland, version 24.1.1
--   Found xcb-util, version 0.4.1
--   Found xcb-render, version 1.17.0
--   Found xcb-xfixes, version 1.17.0
--   Found xcb-icccm, version 0.4.2
--   Found xcb-composite, version 1.17.0
--   Found xcb-res, version 1.17.0
--   Found xcb-ewmh, version 0.4.2
--   Found xcb-errors, version 1.0.1
-- SYSTEMD support is requested (NO_SYSTEMD not defined)...
-- Setting precompiled headers
-- Setting link libraries
-- Checking for module 'hyprutils>=0.1.1'
--   Found hyprutils, version 0.2.0
-- Checking for modules 'tomlplusplus;hyprutils>=0.1.1'
--   Found tomlplusplus, version 3.4.0
--   Found hyprutils, version 0.2.0
-- Configuring done (1.5s)
-- Generating done (0.0s)
-- Build files have been written to: /tmp/hyprpm/hyprland-m0r4a/build
✔ configured Hyprland
[v] installation will run: sed -i -e "s#PREFIX = /usr/local#PREFIX = /home/m0r4a/.local/share/hyprpm/headersRoot#" /tmp/hyprpm/hyprland-m0r4a/Makefile && cd /tmp/hyprpm/hyprland-m0r4a && make installheaders
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╍━━━━━━━━━  4 / 5  Installing sources[v] installer returned: # remove previous headers from hyprpm's dir
rm -fr /home/m0r4a/.local/share/hyprpm/headersRoot/include/hyprland
mkdir -p /home/m0r4a/.local/share/hyprpm/headersRoot/include/hyprland
mkdir -p /home/m0r4a/.local/share/hyprpm/headersRoot/include/hyprland/protocols
mkdir -p /home/m0r4a/.local/share/hyprpm/headersRoot/share/pkgconfig
cmake --build ./build --config Release --target generate-protocol-headers
[0/2] Re-checking globbed directories...
[1/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-screencopy-unstable-v1-protocol.h
[2/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/hyprland-global-shortcuts-v1-protocol.h
[3/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/hyprland-toplevel-export-v1-protocol.h
[4/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-gamma-control-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-gamma-control-unstable-v1.hpp
[5/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-foreign-toplevel-management-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-foreign-toplevel-management-unstable-v1.hpp
[6/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/virtual-keyboard-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/virtual-keyboard-unstable-v1.hpp
[7/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-virtual-pointer-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-virtual-pointer-unstable-v1.hpp
[8/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/input-method-unstable-v2.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/input-method-unstable-v2.hpp
[9/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/kde-server-decoration.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/kde-server-decoration.hpp
[10/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-data-control-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-data-control-unstable-v1.hpp
[11/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-layer-shell-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-layer-shell-unstable-v1.hpp
[12/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/text-input-unstable-v1-protocol.h
[13/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-output-power-management-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-output-power-management-unstable-v1.hpp
[14/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-output-management-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wlr-output-management-unstable-v1.hpp
[15/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/hyprland-focus-grab-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/hyprland-focus-grab-v1.hpp
[16/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wayland-drm.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wayland-drm.hpp
[17/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/tearing-control-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/tearing-control-v1.hpp
[18/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/fractional-scale-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/fractional-scale-v1.hpp
[19/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/xdg-output-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/xdg-output-unstable-v1.hpp
[20/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/cursor-shape-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/cursor-shape-v1.hpp
[21/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/idle-inhibit-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/idle-inhibit-unstable-v1.hpp
[22/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/relative-pointer-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/relative-pointer-unstable-v1.hpp
[23/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/xdg-decoration-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/xdg-decoration-unstable-v1.hpp
[24/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/alpha-modifier-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/alpha-modifier-v1.hpp
[25/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/ext-foreign-toplevel-list-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/ext-foreign-toplevel-list-v1.hpp
[26/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/pointer-gestures-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/pointer-gestures-unstable-v1.hpp
[27/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/keyboard-shortcuts-inhibit-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/keyboard-shortcuts-inhibit-unstable-v1.hpp
[28/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/pointer-constraints-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/pointer-constraints-unstable-v1.hpp
[29/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/xdg-activation-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/xdg-activation-v1.hpp
[30/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/ext-idle-notify-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/ext-idle-notify-v1.hpp
[31/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/text-input-unstable-v3.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/text-input-unstable-v3.hpp
[32/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/ext-session-lock-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/ext-session-lock-v1.hpp
[33/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/presentation-time.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/presentation-time.hpp
[34/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/primary-selection-unstable-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/primary-selection-unstable-v1.hpp
[35/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/tablet-v2.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/tablet-v2.hpp
[36/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/xwayland-shell-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/xwayland-shell-v1.hpp
[37/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/viewporter.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/viewporter.hpp
[38/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/drm-lease-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/drm-lease-v1.hpp
[39/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/xdg-shell.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/xdg-shell.hpp
[40/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/linux-dmabuf-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/linux-dmabuf-v1.hpp
[41/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/linux-drm-syncobj-v1.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/linux-drm-syncobj-v1.hpp
[42/43] Generating /tmp/hyprpm/hyprland-m0r4a/protocols/wayland.cpp, /tmp/hyprpm/hyprland-m0r4a/protocols/wayland.hpp
find src -name '.h' -print0 | cpio --quiet -0dump /home/m0r4a/.local/share/hyprpm/headersRoot/include/hyprland
cp ./protocols/.h /home/m0r4a/.local/share/hyprpm/headersRoot/include/hyprland/protocols
cp ./build/hyprland.pc /home/m0r4a/.local/share/hyprpm/headersRoot/share/pkgconfig
if [ -d /usr/share/pkgconfig ]; then cp ./build/hyprland.pc /usr/share/pkgconfig 2>/dev/null || true; fi
chmod -R 755 /home/m0r4a/.local/share/hyprpm/headersRoot/include/hyprland
chmod 755 /home/m0r4a/.local/share/hyprpm/headersRoot/share/pkgconfig
✔ installed headers
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━  5 / 5  Done!
→ checking for updates for split-monitor-workspaces
→ Cloning https://github.com/Duckonaut/split-monitor-workspaces
✔ repository split-monitor-workspaces has updates.
→ Building split-monitor-workspaces
✔ found hyprpm manifest
→ Manifest has 6 pins, checking
→ Building split-monitor-workspaces
━━━━━━━━━━━━━━━━━━━━━━━━━╍━━━━━━━━━━━━━━━━━━━━━━━━  2 / 4  Updating split-monitor-workspaces[v] shell returned:  -> cd /tmp/hyprpm/m0r4a && PKG_CONFIG_PATH="/home/m0r4a/.local/share/hyprpm/headersRoot/share/pkgconfig" meson setup build --wipe
The Meson build system
Version: 1.5.0
Source dir: /tmp/hyprpm/m0r4a
Build dir: /tmp/hyprpm/m0r4a/build
Build type: native build
Project name: split-monitor-workspaces
Project version: 0.1
C++ compiler for the host machine: c++ (gcc 14.1.1 "c++ (GCC) 14.1.1 20240720")
C++ linker for the host machine: c++ ld.bfd 2.42.0
Host machine cpu family: x86_64
Host machine cpu: x86_64
Compiler for C++ supports arguments -std=c++23: YES
meson.build:8: WARNING: Consider using the built-in option for language standard version instead of using "-std=c++23".
Found pkg-config: YES (/usr/bin/pkg-config) 2.1.1
Run-time dependency hyprland found: YES 0.41.2
Run-time dependency pixman-1 found: YES 0.43.4
Run-time dependency libdrm found: YES 2.4.122
Build targets in project: 1
Found ninja-1.12.1 at /usr/bin/ninja
-> cd /tmp/hyprpm/m0r4a && PKG_CONFIG_PATH="/home/m0r4a/.local/share/hyprpm/headersRoot/share/pkgconfig" meson compile -C build
ninja: Entering directory `/tmp/hyprpm/m0r4a/build'
[1/2] Compiling C++ object libsplit-monitor-workspaces.so.p/src_main.cpp.o
[2/2] Linking target libsplit-monitor-workspaces.so
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja -C /tmp/hyprpm/m0r4a/build
✔ built split-monitor-workspaces into build/libsplit-monitor-workspaces.so
✔ updated split-monitor-workspaces
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━  4 / 4  Done!
✔ Ensuring plugin load state
✔ Loaded split-monitor-workspaces
✔ Plugin load state ensured

@fufexan will git realize if the hash is not on main?

Does it matter if the hash is not on main? Git won't care.

ok

Can anyone build hl with this patch and retry hyprpm update -v?
diff --git a/hyprpm/src/core/PluginManager.cpp b/hyprpm/src/core/PluginManager.cpp
index 036609f3..edb98812 100644
--- a/hyprpm/src/core/PluginManager.cpp
+++ b/hyprpm/src/core/PluginManager.cpp
@@ -464,7 +464,7 @@ bool CPluginManager::updateHeaders(bool force) {
     progress.m_szCurrentMessage = "Checking out sources";
     progress.print();

-    ret = execAndGet("cd " + WORKINGDIR + " && git checkout " + HLVER.branch + " 2>&1");
+    ret = execAndGet("cd " + WORKINGDIR + " && git checkout " + HLVER.hash + " 2>&1");

     if (m_bVerbose)
         progress.printMessageAbove(std::string{Colors::BLUE} + "[v] " + Colors::RESET + "git returned (co): " + ret);

Applying this patch on 0.41.2 fixes the issue. Previously I tried to patch with 043b859 but it didn't work

@fufexan can you commit that then, please

So, firstly I tried to add --no-shallow to the command, but it did not work and I got the same error message. So I reinstalled to hyprland-git from aur as @greentea-cup suggested. It worked!

I still have the same error after doing this. Also tried to manually building and replacing the hyprpm generated


Missing Anti-Aliasing and no HardwareAcceleration

I'm experiencing sawy edges when loading a model in the SceneView. Hardware Acceleration seems to be disabled.
The error occured on an a Galaxy Tab S8
simply added a SceneView like this
<io.github.sceneview.SceneView
        android:id="@+id/sceneView"
        android:layout_height="match_parent"
        android:layout_width="match_parent"
        />

sceneView = findViewById(R.id.sceneView)
...
val model = ModelNode()
sceneView.addChild(model)

lifecycleScope.launchWhenCreated {
      model.loadModel(
           context = this@MainActivity,
           glbFileLocation = "models/FiatPunto.glb",
           autoAnimate = false,
           autoScale = true,
           centerOrigin = Position(x = 0.0f, y = 0.0f, z = 0.0f)
      )
}

If I print
Log.i("SceneView", "HWaccel = " + sceneView.isHardwareAccelerated)
I recieve false.
That's how it looks like (very prominent on the lower end of the windows):

Here is a picture of the same Punto model loaded into the sample Filament viewer

.
As discussed with grassydragon it might be a mipmapping issue not anti-aliasing.

After some more investigation I could reconstruct similar artefacts on the sample-gltf-viewer.
Those are the settings on the sample-gltf-viewer

And this is the resulting scene

var view = sceneView.renderer.filamentView
view.renderQuality = view.renderQuality.apply {
  hdrColorBuffer = View.QualityLevel.MEDIUM
}

view.dynamicResolutionOptions = view.dynamicResolutionOptions.apply {
  enabled = true
  minScale = 0.7f
  maxScale = 0.8f
}

view.multiSampleAntiAliasingOptions = view.multiSampleAntiAliasingOptions.apply {
  enabled = true
  sampleCount = 4
}

view.antiAliasing = View.AntiAliasing.FXAA

It turned out the issues was that the default settings of the filamentView were applied and the have MSAA disabled and dynamic screen resolution turned on with some minScale and maxScale values applied by default. The above code makes it possible to access some of the render settings. But things might change with RIP Renderer (?)

Hi!,
where I can find this sample-gltf-viewer?

@Veerarma The sample viewer is part of https://github.com/google/filament . It's included in the releases for desktop platforms.


Registered buffers of non-leaf nodes are not removed

profile register buffer on all modules:
https://github.com/Lyken17/pytorch-OpCounter/blob/dbc052ec2d914e950b3e0fa24d3eea753a4e0bb7/thop/profile.py#L141-L143
However, only pop buffers on handlers:
https://github.com/Lyken17/pytorch-OpCounter/blob/dbc052ec2d914e950b3e0fa24d3eea753a4e0bb7/thop/profile.py#L195-L198
It causes saved checkpoint contains irrelevant parameters.

I see. Thanks for pointing it out. Could you scratch a PR for it?
Besides, I am considering about adding net.clone() before profiling it. So the profile will never change the original network. Let me know what you think.

Yes, I think deepcopy the net before profiling would be better.


Test 'use_binary' branch on macos runner

level=info msg="Checking minimum RAM requirements"
crc requires at least 11.27GB to run


Avoid checking if the controllers are synced

This change is

Coverage decreased (-0.08%) to 46.518% when pulling<PHONE_NUMBER>a91bdbedcf4c1890cf483a9e21467d on aledbf:refactor-has-synced into 592f3c0736bc6591edb2858afd0fa1d945a15b96 on kubernetes:master.


Grid view: Customize axis for x and y

Would be cool to be able to show grids for different X and Y axes than width and weight, via a dropdown or something (or am I just missing this?)

Revival of Grid view #4
https://github.com/TypeNetwork/videoproof/issues/4


Grammer Error in Doc

On page scaffolding.html
"Modify and recompile responsive.less as a separate"
not exactly sure what it should be?

Resolved in 2.0.1-wip already.


What channel will authors use for high-level feedback?

Pull requests are a good mechanism for discussing specific edits already made, but in cases where we want to share high-level feedback with many or all code contributors, where shall we do that?
GitHub issues?
Private chat.google.com space?
Wait for regular video calls?

This sounds great for a spot to point out medium and large issues. For lot’s of back-and-forth we’ve been using Slack, yet Google chat is also fine! Thoughts everyone?

Sounds good to me. I will close this and use issues.


8075: document --tabColor command line argument

Docs Build status updates of commit c8ae7a2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

TerminalDocs/command-line-arguments.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


ROSA provider: adjust clean up operations based on cluster settings

What
This commit adjusts the ROSA delete cluster method to properly clean up a clusters operator roles and oidc provider. Resources were being left over due to there are different options that need to be provided when you use an oidc config id.
Reference: https://github.com/openshift/rosa/blob/master/cmd/dlt/cluster/cmd.go#L114-L124

/hold

/unhold


File validation

To be merged after #205
This fixes the behaviour of the form to upload new data files when the (mime_type , extension) is not valid.
Previously, the UploadedFile was not created because the validator was working correctly, but the associated ExperimentDataFile was still created. This caused the associated experiment details page to break entirely.
With a small fix in the views, the ExperimentDataFile is not created and helpful messages are displayed (see below).
Files which are now handled correctly:

Group+10+-+Cell+25_02_MB_C03.mpr: This is a binary file and we should not expect it to be parsed. The extension is not valid so it is caught by the validator.

closes #190

Both good points and fairly easy fixes. The reason for 2. was because the post method for that view has been heavily modified to deal with all the checks required for uploading files. We had forgotten to put the conditional redirects in place.


Added error handling w/emails

Let me know what you think!
Michael

Would probably be better if we could pass an anonymous function in as the error_handler instead. Closing so we can build a more generic implementation.


Boot/reboot/shutdown splash screen

Steps to reproduce issue
Connect to the HDMI connected to a monitor
Boot the device
Expected result
Resin logo splash screen should be visible
Actual result
Logo is not displayed at boot-up. The HDMI screen shows only the boot log
Notes:

boot may be too fast to actually have time to show the logo.
needs some testing on a different HDMI screen as the one I am using loses signal for a short period of time during boot-up

At reboot and shutdown, the logo is displayed correctly
Other information
Reported by: Florin Sarbu
Test configuration: NUC
Test case number: TC07
Test run: https://resinio.testlodge.com/projects/16238/runs/196239?tab=2&run_section_id=176152&executed_case_id=9459437#executed_case_9459437

This issue was moved to resin-os/resinos#66


Too many command line arguments segfaults (unless GC_INITIAL_HEAP_SIZE is set)

When lots of command line arguments are passed to a Crystal binary, it will exceed the memory at startup, which results in a segfault. An example where that can happen is when you are writing a script that receives files as input.
$ ./do_something some_dir/*.gz
Segmentation fault (core dumped)

If there are many files, it will segfault and you have to explicitly set GC_INITIAL_HEAP_SIZE=4M to make it work. I would consider it a bug for two reasons:

IMHO the error message is misleading (it took me a while to figure out that it is running out of memory)
It happens even with relatively small memory requirements (we are not talking about passing in file lists with GBs of data)

To reproduce, you can take the example from OptionParser:
require "option_parser"

upcase = false
destination = "World"

OptionParser.parse do |parser|
  parser.banner = "Usage: salute [arguments]"
  parser.on("-u", "--upcase", "Upcases the salute") { upcase = true }
  parser.on("-t NAME", "--to=NAME", "Specifies the name to salute") { |name| destination = name }
  parser.on("-h", "--help", "Show this help") { puts parser }
  parser.invalid_option do |flag|
    STDERR.puts "ERROR: #{flag} is not a valid option."
    STDERR.puts parser
    exit(1)
  end
end

destination = destination.upcase if upcase
puts "Hello #{destination}!"

And run it as follows:
$ crystal run example.cr -- $(seq 1 100000)
Program exited because of a segmentation fault (11)

However, on my system, that will work:
$ GC_INITIAL_HEAP_SIZE=4M crystal run example.cr -- $(seq 1 100000)
Hello World!

Building a binary (either debug or release mode) does not change the behavior.
When it crashes, the critical operations happens at startup:
kernel.cr:41:
...
40 # An array of arguments passed to the program.
41 ARGV = Array.new(ARGC_UNSAFE - 1) { |i| String.new(ARGV_UNSAFE[1 + i]) }
42

I attached a picture with the backtrace.It triggers immediately the garbage collector, which eventually crashes:

$ crystal -v
Crystal 0.33.0 [612825a53] (2020-02-14)

LLVM: 8.0.0
Default target: x86_64-unknown-linux-gnu

OS: Ubuntu 18.04

What's the error you get in Ruby?
I want to reproduce it but I already get the error in zsh with a long argument, so I can't even reach Crystal or Ruby.
In my opinion this should be fixed but it has a very low priority, because in any case the program will not work.

Should have added that I am using Bash as a shell.
It is true that there exists a limit on the number of parameters. In my real example, there are fewer arguments, but the file paths are longer. In other words, each argument uses more space than the numbers for seq.
With Ruby, I cannot reproduce the behavior (running out of memory by receiving a huge ARGV list).

For the record, I tried to run the Ruby(v2.7.0) version and it worked:
require 'optparse'

params = {}
OptionParser.new do |opts|
  opts.on('-a')
  opts.on('-b NUM', Integer)
  opts.on('-v', '--verbose')
end.parse!(into: params)

p params

I ran it in zsh(v5.8) like this:
./file.rb -- {1..100000} and it correctly output {}.

Fixing this seems hard, because different programs expect different sizes of input. If it's not enough by default programs with large input will fail. If it's too much, programs with small input will consume more memory than they need.
First we should figure out, what the current default is. That's not officially documented anywhere. Judging from bdwgc's souce it depends on several configuration values, but seems to be 384 kB in most cases (with LARGE_CONFIG).

Why does it depend on the GC_INITIAL_HEAP_SIZE at all?
The argv is passed in from libc, which does not allocate that on the GC heap. Anything after that is done in crystal code, where I've never seen GC_INITIAL_HEAP_SIZE affect anything.
I suspect GC_INITIAL_HEAP_SIZE is incidentally masking unsafe behaviour.

I want to reproduce it but I already get the error in zsh with a long argument

By the way, this is not about the shell but about the system. Both Linux and Mac have
getconf ARG_MAX
and for me it's 2097152.
Could be less on Mac.

Perhaps the issue is just that "GC collecting while in early init is broken" and we need to work out why?

Example seems to work OK for me now?

It still segfaults for me on Linux.
With gdb I got:
(gdb) run
Starting program: /home/...
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x000055555565022e in GC_find_limit_with_bound ()

It still reproducible with Crystal 1.3.0. For instance, here in Docker:
docker run --rm -it crystallang/crystal:1.3.0 bash

root@e343dd3af420:/# crystal --version
Crystal 1.3.0 [a3ee70ca0] (2022-01-06)

LLVM: 10.0.0
Default target: x86_64-unknown-linux-gnu

root@e343dd3af420:/# echo "puts ARGV.size" > example.cr
root@e343dd3af420:/# cat example.cr
puts ARGV.size

root@e343dd3af420:/# crystal run example.cr -- $(seq 1 100000)
Program exited because of a segmentation fault (11)

# But it still works when setting `GC_INITIAL_HEAP_SIZE`:
root@e343dd3af420:/# GC_INITIAL_HEAP_SIZE=4M crystal run example.cr -- $(seq 1 100000)
100000


I keep getting invalid url even for standard open ai calls

          I keep getting invalid url even for standard open ai calls

Originally posted by @Ethan-Otto in https://github.com/saoudrizwan/claude-dev/issues/216#issuecomment-2336431842

The base url should be https://api.openai.com/v1


When trying to Spread Two Fragments which Contain Identical Properties, an Error Occurs

Describe the bug
I will provide more details later today, but opening this as a stub so I don't forget to report it in more detail.
To Reproduce
Steps to reproduce the behavior:
1.
2.
3.
4.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions:

PostgreSQL: [e.g. 14.1]
pg_graphql commit ref: ea2ab60

Additional context
Add any other context about the problem here.

please re-open once you have a chance to fill in the details


Add sample data set

function to download a data set.  Or have a small data set to run this on.

Added sneapsters


Request: bypass registry optimisations

Hi,
I would like to use the script for everything other than the registry optimisations (although keeping getting rid of defaultuser0 and any other registry cleanups related to removing features/services). Something like a -NoRegistry switch? Leaving current registry switch out still produces all the altered registry changes (as noted by the log).
I prefer to use group policy scripts after the OS has installed.

Hello, I have removed the automatic value of "Default" that automatically sets when the script is run, so now if you omit the -Registry parameter it will skip setting any of the registry optimizations.


Shared playground id's not case-sensitive

The generated playground id's are not case-sensitive.

@kbrandwijk what do you mean with that? That the case will be ignored in the graphql-bin?

@timsuchanek Yes. When you share, you get an url with lowercase and UPPERCASE characters, but you can also access using any casing. For example, I just shared and empty one and got https://graphqlbin.com/j0McG. But https://graphqlbin.com/j0mcg (or https://graphqlbin.com/J0MCG) also works, so that makes it a lot less random.

Now it works correctly, thanks for reporting issue.


Updated Readme.md

@19ANDY : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@corob-msft - Would you review the proposed changes? Thanks

@19ANDY Based on the link targets, I might guess this change is intended for people who come here and wonder "What is Visual Basic, anyway?" But the rest of the paragraph is about telling people that were looking for something else that it isn't here, and shows them where they can find it. That is, it's for people who know what VB and C# and VS are, and want to edit those topics instead of the C++ ones. Now a few people may come here and think "Hmm, VB, I don't know what that is, let's find out more," but I'm going to guess that's a really small number of people. And for everyone else, the links are actually a little bit of a distraction. So, I'm curious what your justification is for this change, and thus if it's worth making. Would you care to elaborate?

@19ANDY We appreciate your efforts to contribute to our content, and want to encourage it. I'm closing this PR, as I'm not convinced it's necessary, but feel free to reopen if you have additional justification.