Conversion of frozen graph .pb to .tflite error

So I tried to convert a frozen graph that I got from https://github.com/tensorflow/models/blob/master/research/object_detection/g3doc/detection_model_zoo.md (the name of the model is "faster_rcnn_resnet101_fgvc"), to a tflite, by using the following command on google collab:
!tflite_convert --graph_def_file=frozen_inference_graph.pb --output_file=optimized_graph.lite --input_format=TENSORFLOW_GRAPHDEF --output_format=TFLITE --input_shape=1,1024,1024,3 --input_array=image_tensor --output_array=Softmax
I sort of guessed (probably incorrectly) the input and output arrays, and input_shape, because that information was not provided with the model. I got an error saying something like "2019-04-23 09:30:48.751842: F tensorflow/lite/toco/tooling_util.cc:627] Check failed: dim >= 1 (0 vs. 1)
Aborted (core dumped)". I am new to Tensorflow, so is there any way I can find out how that error occurred, and how I can resolve it?

Hi Mowghli,
You can use summarize_graph tool to inspect the input and outputs of the graph
See
https://github.com/tensorflow/tensorflow/tree/master/tensorflow/tools/graph_transforms#inspecting-graphs

So I got this:
Amoghs-MacBook-Pro:tensorflow amoghbhabal$ bazel-bin/tensorflow/tools/graph_transforms/summarize_graph --in_graph=frozen_inference_graph.pb
Found 1 possible inputs: (name=image_tensor, type=uint8(4), shape=[?,?,?,3])
No variables spotted.
Found 4 possible outputs: (name=num_detections, op=Identity) (name=detection_classes, op=Identity) (name=detection_scores, op=Identity) (name=detection_boxes, op=Identity)
Found 57548019 (57.55M) const parameters, 0 (0) variable parameters, and 65923 control_edges
Op types used: 66369 Const, 8603 Reshape, 5794 StridedSlice, 5772 Shape, 5733 GatherV2, 5714 Fill, 2898 Add, 2895 Mul, 2892 Pack, 2890 Sub, 2884 Range, 2874 Slice, 2872 ConcatV2, 2870 Minimum, 2865 Less, 2865 Select, 2858 ZerosLike, 2855 NonMaxSuppressionV3, 61 Enter, 58 BiasAdd, 56 Conv2D, 49 Relu, 34 Identity, 27 RealDiv, 25 Cast, 22 TensorArrayV3, 22 Switch, 21 Merge, 20 NextIteration, 13 Maximum, 12 TensorArrayReadV3, 12 TensorArrayScatterV3, 12 Greater, 11 Split, 10 TensorArraySizeV3, 10 Squeeze, 10 TensorArrayWriteV3, 10 Tile, 10 Exit, 10 Unpack, 10 TensorArrayGatherV3, 9 ExpandDims, 7 Pad, 6 LogicalAnd, 6 Assert, 6 Transpose, 5 LoopCond, 5 Equal, 4 GreaterEqual, 4 Exp, 4 Size, 4 MaxPool, 4 TopKV2, 4 Round, 3 Where, 2 MatMul, 2 Softmax, 2 Sum, 2 Mean, 1 All, 1 Placeholder, 1 Max, 1 Relu6, 1 ResizeBilinear, 1 CropAndResize
To use with tensorflow/tools/benchmark:benchmark_model try these arguments:
bazel run tensorflow/tools/benchmark:benchmark_model -- --graph=frozen_inference_graph.pb --show_flops --input_layer=image_tensor --input_layer_type=uint8 --input_layer_shape=-1,-1,-1,3 --output_layer=num_detections,detection_classes,detection_scores,detection_boxes

So I found the input and output layers, but the input_layer_shape is an issue. I tried running:
!tflite_convert --graph_def_file=frozen_inference_graph.pb --output_file=optimized_graph.lite --input_format=TENSORFLOW_GRAPHDEF --output_format=TFLITE --input_shape=-1,-1,-1,3 --input_array=image_tensor --output_array=num_detections,detection_classes,detection_scores,detection_boxes --allow_custom_ops

and I got the error
2019-04-25 23:06:13.427794: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-04-25 23:06:13.428096: I tensorflow/compiler/xla/service/service.cc:150] XLA service 0x55705b2bac60 executing computations on platform Host. Devices:
2019-04-25 23:06:13.428154: I tensorflow/compiler/xla/service/service.cc:158]   StreamExecutor device (0): <undefined>, <undefined>
Traceback (most recent call last):
  File "/usr/local/bin/tflite_convert", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/lite/python/tflite_convert.py", line 442, in main
    app.run(main=run_main, argv=sys.argv[:1])
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 125, in run
    _sys.exit(main(argv))
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/lite/python/tflite_convert.py", line 438, in run_main
    _convert_model(tflite_flags)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/lite/python/tflite_convert.py", line 122, in _convert_model
    converter = _get_toco_converter(flags)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/lite/python/tflite_convert.py", line 109, in _get_toco_converter
    return converter_fn(**converter_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/lite/python/lite.py", line 288, in from_frozen_graph
    _set_tensor_shapes(input_tensors, input_shapes)
  File "/usr/local/lib/python2.7/dist-packages/tensorflow/lite/python/convert_saved_model.py", line 220, in set_tensor_shapes
    raise ValueError(message)
ValueError: The shape of tensor 'image_tensor' cannot be changed from (?, ?, ?, 3) to [-1, -1, -1, 3]. Dimension -1 must be >= 0

Is there any way I can convert this model to .tflite format?
Also, are there any tensorflow lite sample models that perform object detection on animals and plants? I only found sample models trained on COCO dataset, and retraining them would involve using VMs, since the iNaturalist dataset is too large.

Is this resolved? facing the same issue.
TIA

@Mowghli  Is this still an issue?

Sorry for the late reply. I asked the owner of the repository that has the model, regarding the same issues. He replied that he is not sure if conversion of FasterRCNN models to TF Lite is supported yet. He suggested performing transfer learning using a much smaller subset of the iNaturalist Dataset. He also gave the following links:

https://medium.com/tensorflow/training-and-serving-a-realtime-mobile-object-detector-in-30-minutes-with-cloud-tpus-b78971cf1193
https://medium.com/tensorflow/training-and-serving-a-realtime-mobile-object-detector-in-30-minutes-with-cloud-tpus-b78971cf1193

The Faster RCNN model is also not trained with quantization enabled, so it might become inaccurate when deployed, assuming you can convert it to TFLite.
Also, I tried converting this model to TFLite, with the following command (I tried guessing the shape, I am not sure if it is correct):
!tflite_convert --graph_def_file=frozen_inference_graph.pb --output_file=optimized_graph.lite --input_format=TENSORFLOW_GRAPHDEF --output_format=TFLITE --input_shape=0,1024,1024,3 --input_array=image_tensor --output_array=Softmax --allow_custom_ops

I got the following output (This is output is not complete, it's just the end of the output text I got):
2019-04-23 09:06:30.883905: I tensorflow/lite/toco/import_tensorflow.cc:1324] Converting unsupported operation: Round
2019-04-23 09:06:30.883938: I tensorflow/lite/toco/import_tensorflow.cc:1324] Converting unsupported operation: Round
2019-04-23 09:06:30.884003: I tensorflow/lite/toco/import_tensorflow.cc:1324] Converting unsupported operation: TensorArrayWriteV3
2019-04-23 09:06:30.884051: I tensorflow/lite/toco/import_tensorflow.cc:1324] Converting unsupported operation: TensorArrayWriteV3
2019-04-23 09:08:50.422889: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 67000 operators, 136448 arrays (0 quantized)
2019-04-23 09:11:01.390182: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After Removing unused ops pass 1: 502 operators, 749 arrays (0 quantized)
2019-04-23 09:11:01.408409: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 502 operators, 749 arrays (0 quantized)
2019-04-23 09:11:01.594021: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 1: 207 operators, 447 arrays (0 quantized)
2019-04-23 09:11:01.600658: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before dequantization graph transformations: 207 operators, 447 arrays (0 quantized)
2019-04-23 09:11:01.614120: F tensorflow/lite/toco/tooling_util.cc:627] Check failed: dim >= 1 (0 vs. 1)
Aborted (core dumped)

Seems like there were a lot of unsupported operations.

@Mowghli looks you have found an alternative. Can we close this?

Yes. The issue is resolved.

Glad it resolved.


flags.adv-reminder.message.all does not show on attack or damage rolls

Does work for skill and ability rolls, but not seeing it on weapon or spell attack or damage rolls

--
Sorry, this was with Midi enabled, so it's probably just due to the incompatibility there, #16 is probably tracking the relevant info?

Yeah, nothing I can do here unfortunately. Midi doesn't pass dialogOptions through on attack and damage rolls and this module uses that to "tag" the dialog to make sure the message appears on the right one. So the module is setting the option but unless we get Midi to pass it through then the message won't appear.

Keeping this open though, should probably add this to the readme. At the very least it'll remind me why it doesn't work!

Closing now that this issue is captured in the compatibility notes section of the readme

Is there an open issue in Midi's Git for this?

Is there an open issue in Midi's Git for this?

Not that I know of. I didn't file one. Think I should?

Midi probably wont change without one, right? It would be a great boon to this mod if it was implemented

I know I should, but just didn't want to at the time. I think I was just sour on Midi compatibility issues because I wrote this module so I didn't have to use Midi. I'll reopen this and file an issue there. It'll be blocked until/unless Midi fixes it, but we can have this issue as a reminder

https://gitlab.com/tposney/midi-qol/-/issues/689

Looks to be resolved with the latest midi update!
Thanks for creating that ticket, I could not have made one with nearly the same detail


feat(Spring CodeGen): Add customized spring composer for package info

In this PR:

Add SpringPackageInfoComposer.java to generate package-info.java, similar to ClientLibraryPackageInfoComposer.java but customized for spring.
In SpringWriter.java, remove generation of gapic_metadata.json for spring libraries.

Todos:

[x] Also update SpringComposerTest to include this file
[x] Libname and (spring) package name logic should be updated to call Utils after #1061 is merged

A few comments below, and just a thought (this could totally be a separate pr if we want it): You probably started out from ClientLibraryPackageInfoComposer.java for SpringPackageInfoComposer.java and cleaned out irrelevant contents. What if we keep the descriptions for each service like in here, remove the samples, and at the bottom, add a sample to use along the lines of: "You can inject auto-configured service bean to your Spring Boot application with annotation based configuration @Autowired [serviceBean] or Constructor Injection "

@zhumin8 Ah I think that would be helpful! One concern here might be that ClientLibraryPackageInfoComposer has logic for formatting service descriptions that is not currently exposed, so copying it could run us into inconsistency if that part of gapic generator code gets updated in the future (though those lines haven’t been modified for a while).
A couple of possible approaches here come to mind, in order of estimated effort. Let me know if you have any preferences or suggestions?

We could skip the service description and just list each service client name, followed by the Spring-specific snippet
We could copy over service description logic from ClientPackageInfoComposer, and keep SpringPackageInfoComposer updated if this ever changes (any discrepancy would also only impact generated javadoc and not code)
We could possibly refactor ClientPackageInfoComposer to expose service description logic for reuse? (This option would definitely warrant a separate PR)

I am inclined to option 3.
But either way, you are right, it could be done in a separate PR. Let's get this merged in and talk about it separately.

I am inclined to option 3. But either way, you are right, it could be done in a separate PR. Let's get this merged in and talk about it separately.

Sounds good!


Packaging issues

Looks like the apps are generated with org.springframework.boot as the groupId. Shouldn't that be org.springframework.cloud.stream.app or something?
The time module Java apps have the wrong package - org.springframework.could.stream.app.time should be org.springframework.cloud.stream.app.time.

@trisberg Followed the same pattern for other spring cloud apps generated through the initializr. For ex, if you go to start.spring.io, and select eureka, you would get a pom like this:
<parent>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-parent</artifactId>
		<version>1.3.3.RELEASE</version>
		<relativePath/>
	</parent>

	<dependencies>
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-starter-eureka</artifactId>
		</dependency>

		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-test</artifactId>
			<scope>test</scope>
		</dependency>
	</dependencies>

Although the generated apps are part of the spring-cloud-stream-app-starter repo, each apps are self contained maven modules. Do we want to make it having a different parent than what the other spring cloud apps follow?

Can't we just specify a  instead of defaulting to the Boot parent groupId

sure, we can. I will make org.springframework.cloud.stream.app as the parent group id.

@trisberg new parent groupid/artifactid:
<groupId>org.springframework.cloud.stream.app</groupId>
<artifactId>spring-cloud-stream-app-parent</artifactId>

The typo in package name for time apps is also fixed.

@trisberg All the generated apps from Initializr needs to have the spring-boot-parent as this is simply a boot application. They prefer we provide a bom to include all the other dependencies and suggest us not changing the parent that comes as default in any way.


docs: Yarn how to comment

Adds a comment to the NPM publishing example to indicate the command to use when using Yarn as opposed to NPM
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[x] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

Fixes #599 🦕

@schalkneethling thank you for the contribution 👍


The info/debug logs in Jaggery level do not get printed.

Description:
Jaggery Log object have been created without using the default constructor which leads to log messages not been printed at jaggery level.
Steps to reproduce:
The info logs in jaggery level does not get printed.
Affected Product Version:
3.0

Fixed with https://github.com/wso2-support/carbon-apimgt/pull/1882


Which dependencies in elm.json are not compatible?

I used elm-upgrade and ended up with this:
(I did get a warning about missing 0.19 versions at some point)
{
    ...
    "dependencies": {
        "direct": {
           ...
            "elm-community/random-extra": "2.0.0"
           ...

When doing a elm make I got the below message and had to add them one by one again to find the one that is not compatible
> elm make
-- INVALID PACKAGE DEPENDENCIES --------------------------------------- elm.json

The dependencies in your elm.json are not compatible.

Did you change them by hand? Try to change it back! It is much better to add
dependencies with elm install or the dependency management tool in elm reactor.

Please ask for help on the Elm slack <http://elmlang.herokuapp.com/> if you try
those paths and still cannot figure it out!

I guess there is a way to come up with the list of incompatible dependencies?

As you wrote, for everybody searching for help, right now you can use elm-upgrade and look carrefuly at the warnings (like WARNING: mgold/elm-date-format has not been upgraded to 0.19 yet!) or https://kraklin.github.io/elm-readiness/ can help.


Can't create vpn connection --shared-key not working

Hello,
I'm attempting to create a VPN connection with the following:
az network vpn-connection create --verbose --name vpncn --resource-group defaultRg --vnet-gateway1 "defaultgateway" --local-gateway2 "localgateway" --shared-key 'abcd12345677'
however I keep getting:
--shared-key is required for VNET-to-VNET or Site-to-Site connections.
Am I doing something wrong?

When you run az --version what do you see?  What OS are you using and what shell?

My first thoughts are you might be using a version of the CLI that didn't incorporate fix for #2054. My second thought is that you should not quote your values. Specifically, when I tried to repro, using 'abcd1234' will cause the deployment to fail because the quotes are included in the string.

Hello, I'm on OSX Sierra 10.12.3
dky@mba ~ $ az --version
azure-cli (0.1.2rc1)
acs (0.1.2rc1)
appservice (0.1.1b3)
batch (0.1.1b3)
cloud (0.1.2rc1)
component (0.1.1rc1)
configure (0.1.2rc1)
container (0.1.1b2)
core (0.1.2rc1)
documentdb (0.1.1b1)
feedback (0.1.2rc1)
iot (0.1.1b2)
keyvault (0.1.1b4)
network (0.1.2rc1)
nspkg (0.1.2)
profile (0.1.2rc1)
redis (0.1.1b2)
resource (0.1.2rc1)
role (0.1.2rc1)
sql (0.1.1b3)
storage (0.1.2rc1)
vm (0.1.2rc1)
Python (Darwin) 2.7.13 (default, Dec 18 2016, 07:03:39)
[GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-8<IP_ADDRESS>)]
dky@mba ~ $ bash --version
GNU bash, version 4.4.12(1)-release (x86_64-apple-darwin16.3.0)
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
I'll check out that fix #2054.
Thanks for pointing me to it.

az was installed via pip. I supposed it would fetch the latest version but I guess not.
Here was the command I used:
pip install --user azure-cli

Hi @dky yes, you have an old version of the CLI. Try: pip install --upgrade --user azure-cli

It will install the latest, but if you had an old version on there that lingered, it would use that. You can force it to reinstall with pip install --user azure-cli -I

@tjprescott, Thank you, I'll update and give it another shot.


missing protectedBy protectionRole labels in volume_labels Rest

Tested with AFF250

As part of the snapmirror source_cluster view, we have removed snapmirror api call from volume plugin and moved these labels [protectionRole, protectedBy, all_sm_healthy] from volume to snapmirror labels.
https://github.com/NetApp/harvest/commit/4d7c5a7cf49c674a28fe40a49a69d873d41a46af#diff-eb14ea86460068481a9995da11e93dbd70ac14a1592722286a5bc76d22b743b1
Rest plugin have those changes but missed from zapi.
Working on them.


Add step about updating changelog to release doc

Fixes #1163.
This PR aligns the Kit's release doc with the Design System's release docs.

@joelanman @lfdebrux Can I get a review? :)

@EoinShaughnessy thanks for this! Just wondering if it's worth waiting for @NoraGDS to review this?

@lfdebrux Good shout!

I'll move this issue and PR to 'Blocked' until @NoraGDS can review - this is a process she follows during releases, so it would be good to get her thoughts.

Moving from blocked as @NoraGDS has reviewed.

@NoraGDS Thanks for your help with this! :)


Backend: introduce a REST API that allows people to consume our map data

Description
This is based on #501 (so should get merged after)
Introduces a new firebase "host" at api.reach4help.org (see: https://api.reach4help.org/edge/map/data) for creating general API endpoints for interacting with other projects.
Motivation
As part of our collaboration with mutualaid.wiki, they need an endpoint to be able to consume our data. Once the mutual aid data has been migrated over to mutualaid.wiki, and we instruct users to enter new group information there instead of using our form, then it's unlikely there will be a continued need for mutualaid.wiki to ue this API, but it will remain useful for others!
(Note: we still need to transfer the hard-coded data to our database, hence the low result count)
Release Checklist

[ ] This code has unit tests
[x] I have a plan to verify that these changes are working as expected after deploy
[x] I have a plan for how to revert, rollback, or disable these changes if things are not working as expected

Security Checklist
This PR creates, modifies, or deletes:

[x] API routes: API routes, parameters, or user authorization
[ ] Authentication: Authentication mechanism
[ ] Credentials: Server side credentials, or secrets in configuration / source code
[ ] Cryptography: Encryption, hashing, certificates, signatures, random numbers, etc.
[ ] User data: personal information handling, logs, error messages, etc.

cc @reach4help/security
Additional Notes
Closes #487
The majority of our data still needs to be migrated from JSON to our firestore database before it becomes available through this API.
cc @tapjay @Pingid

Since we only have one endpoint we don't need to consider this now, but in the future this might be something to think about. https://nextjs.org/docs/api-routes/introduction
Again, this is an improvement for down the road and shouldn't impact this PR.

@sabind accepted your caching suggestion :)

Going to merge this in now as i'm working on other stuff that depends on this.


[Feature Request] Fix scaling of FMV cutscenes

FMV cutscenes show bad scaling artifacts at resolutions >1080p and look very pixelated.

FMV cutscenes show bad scaling artifacts at resolutions >1080p and look very pixelated.

I've mentioned the thing here https://github.com/ThirteenAG/MaxPayne3.FusionFix/issues/4#issue-1943379692 and I think it's because the PC port lacks bilinear filtering / a basic filter to smoothen out the movies...
Artifacts are because of the bad upscale Rockstar did for the PC port, I think.
Using the Console movies fix that, although their resolution is a bit lower (720p), they seem to also have MPEG artifacts, and they look even more pixelated lol.

Differences:
PC (with console movies, 4K):

PS3 (RPCS3, 4K internal res):

Xbox 360 (Xenia, 4K resolution scale):

--> Notes: Open each photo on a new tab and decrease monitor / display brightness, contrast to see better.
The Console cutscenes on PC have color artifacts (Maybe even the default PC ones. Can anyone check?)... No idea why they're parsed like this... (Might be because of the color gamut / gamma being stronger on consoles)
The Xbox 360 version seems to behave the same as the PC version in terms of pixelation, but the colors treated correctly on 360.
The PS3 version seems to look the best out of all.
--> Additional note: Cutscene movie files are the exact same on both PS3 and Xbox 360, there are no differences, same file sizes and resolution.

Actually, I think the issue I portrayed here, might actually be caused by the bink decoder or something, and not the video files themselves. When I play the videos in the Bink Video Player, everything seems to look fine, apart from the extremities of the screen borders having subtle garbled artifacts. But I think this one could be fixed by somehow implementing Console Gamma for the bink pass(?), which would probably be the best possible outcome anyway.
Using the console movies isn't really ideal after all, as the PC ones seem to have been reshot at higher graphical settings, so when you look at the console videos, you'll notice the lower texture quality, shadow quality etc, on top of the 720p resolution. Some peds are also different between them, some panel transitions etc. but still, not worth sacrificing the overall quality for them. I did heavily consider uploading those somewhere, but I just don't think it's worth it after finding out these things.

The issue is definitely related to the Bink decoder/rescaling code of the game – as long as the game is set to 1080p (the pre-rendered cutscenes' native resolution) everything looks fine. But when set to any resolution higher than 1080p, the internal scaling kicks in and makes everything look pixelated as it just uses nearest neighbor scaling.


browserify support

There's great support for RequireJS and Component, but how about Browserify? The readme lists support for CommonJS, but even though List.js is composed of CommonJS modules it's dependent upon Component packages and component(1). So close, yet so far :sweat_smile: Totally respect the decision to use Component, but it's pretty opinionated. Since I can load List.js standalone I think it's just an issue with the structure of the code that's preventing it from working with Browserify.
I'd love to be able to at least add List.js as a Bower dependency and require /dist/list.js with Require (shimming the global as necessary), but I run into this:

Error: module "get-by-class" not found from "/node_modules/list.js/index.js"

Of course that's just because I'm missing the build step with Component to pull down your dependencies. One route I could go is to use the decomponentify transform. But I'd still need to add Component as a dependency for my project and a build step.
Just wanted to put this on your radar if it wasn't already!

any news on that one ?

Good news - this is coming in the next version, whenever that may be https://github.com/javve/list.js/issues/271#issuecomment-100679229

Yep, this will be included in the next version (which is actually getting closer and closer!). Duplicate of #235


Enhance improve publish version performance

Proposed changes
Issue Number: close #xxx
The current publish daemon executes serial, if a transaction publishes for a long time, it will cause other things to be blocked, resulting in slow transaction release, and some load task will fail due to txn num overload.
We use multi threads to publish and speed up the finish of the transaction
The publish time for each percentile is significantly reduced

The number of load txn also decreased significantly
## Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

Give a explanation about the pictures.  Is blue curve is  old code,  yellow curve is the PR ?  Why yellow curve of the latency after "07:18 12:00:00" drop sharply ?


Create New Connection Error

Type: Bug
When clicking the Create Connection button in the Server list, an error is displayed: "Cannot read properties of null (reading 'fullName')"
Error in console:
workbench.desktop.main.js:1531 TypeError: Cannot read properties of null (reading 'fullName')
    at C.run (workbench.desktop.main.js:1303:6535)
    at handler (workbench.desktop.main.js:1103:23346)
    at o.invokeFunction (workbench.desktop.main.js:918:453)
    at S._tryExecuteCommand (workbench.desktop.main.js:2322:17644)
    at S.executeCommand (workbench.desktop.main.js:2322:17001)
    at h.run (workbench.desktop.main.js:1103:22992)
    at T.runAction (workbench.desktop.main.js:227:50726)
    at T.run (workbench.desktop.main.js:227:50629)
    at A.onClick (workbench.desktop.main.js:1527:24011)
    at HTMLLIElement.<anonymous> (workbench.desktop.main.js:383:24102)
    at _ZoneDelegate.invokeTask (C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:443:35)
    at Zone.runTask (C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:214:51)
    at ZoneTask.invokeTask [as invoke] (C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:525:38)
    at invokeTask (C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:1727:22)
    at globalCallback (C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:1758:31)
    at HTMLLIElement.globalZoneAwareCallback (C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:1794:20)
onDidChangeNotification @ workbench.desktop.main.js:1531
(anonymous) @ workbench.desktop.main.js:1531
_deliver @ workbench.desktop.main.js:139
_deliverQueue @ workbench.desktop.main.js:139
fire @ workbench.desktop.main.js:139
addNotification @ workbench.desktop.main.js:1531
error @ workbench.desktop.main.js:2403
(anonymous) @ workbench.desktop.main.js:2418
_deliver @ workbench.desktop.main.js:139
_deliverQueue @ workbench.desktop.main.js:139
fire @ workbench.desktop.main.js:139
run @ workbench.desktop.main.js:227
await in run (async)
onClick @ workbench.desktop.main.js:1527
(anonymous) @ workbench.desktop.main.js:383
_ZoneDelegate.invokeTask @ C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:443
Zone.runTask @ C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:214
ZoneTask.invokeTask @ C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:525
invokeTask @ C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:1727
globalCallback @ C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:1758
globalZoneAwareCallback @ C:\Users\jtsombakos\AppData\Local\Programs\Azure Data Studio\resources\app\node_modules.asar\zone.js\dist\zone.js:1794

Azure Data Studio version: azuredatastudio 1.49.0 (6e6d22ddd74bbb4fbe344ed80b93b53489fe0239, 2024-08-01T05:19:02.202Z)
OS version: Windows_NT x64 10.0.22631
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz (6 x 3000)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.78GB (11.89GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (3)

Extension
Author (truncated)
Version

schema-compare
Mic
1.21.0

ADS-add-columns
sof
0.0.12

vscodeintellicode
Vis
1.3.1

@jtsom I wasn't able to repro myself.  Are there any other details that would help determine what's going on?  e.g., Do you have any other connections saved already or is this the first connection?  Is this a clean install or a regression upgrading from previous version?  Is there anything being displayed in the UI when the error occurs?

I do have several other connections saved. I did exit ADS and re-launch, and clicking the New Connection button did work, and not show the error. Something must have just been mucked up and the restart cleared it up. Thanks.
If it happens again, I will create another issue.

Thanks for following up.  I'll see if I can figure out what's going on from call stack.


Add ability to push events to specific channels.

Add ability to push events to specific channels. Add ability to pass options with symbol keys for create_event method as well

LGTM. Thanks @ZhKostev !


/temp crashes MoonCord

Calling /temp crashes mooncard at discord/commands/temp.js, line 114.
Problem seems to be that moonraker doesn't report power for temperature fans, only temperatures, targets and speeds - therefore the access to powers crashes the program.

A simple fix to use speeds instead of powers in line 114 works (at least for me):
const speed = calculatePercent(temps[temp].speeds[temps[temp].speeds.length - 1])
Let me know if you need further input.
Kind regards
Stephan

Good to know, i dont have a heat fan actuelly, thank you very much for the Details :)


Fix ipv4 header initialization.

The version/header length/TOS field is 16 not 32 bits wide.
Also add a self-test.

Looks good to me. Thanks!


Add an association for Datacenters

Datacenters are a subclass of EmsFolder but have their own inventory
collection.  This will allow us use the standard association attribute
for an inventory_collection rather than having to define a custom arel
like Ovirt does today ref.

:dependent => :none is the default, not sure if we care about this miq-bot warning

@kbrock yeah since datacenter is a subclass any dependent destroy will be handled by the ems_folders association


⚠ Minecraft has degraded performance

In 1556a32, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 1359 ms

Resolved: Minecraft performance has improved in 4348a31.


riot replication - not able run to change data capture

Hello,
I am trying to get data into elastic cache from redis:-
redis version: 2.8.24
riot version:  "2.0.8"
destination: elastic cache
Using the below command i'm able to get the data into elastic cache. What seems to be happening is that only the data at the time of calling riot is getting replicated. Any incremental data written post starting riot does not get written into elastic cache. If i stop riot and re-start it seems to pick up the reminder of the keys and the same behavior continues.  Wondering if this is expected behavior ? Looking at the redis documentation looks like this might have something to do with 'notify-keyspace-events'. Also, will I need to make data changes for this work.
Looking for more info as to why this might be happening and a possible way to solve this.
./riot-redis --info -r redis://localhost:6379 replicate -r redis://xx-redis-xx.xxxxx.ng.0001.use1.cache.amazonaws.com --live
Also, I can get riot to pull data out of elastic cache and replicate it down to my redis(reverse of my scenario above). Is there more options I need to pass to the above command for that to work?
Thanks for you time.

Yes you need keyspace notifications enabled on the source Redis database in order for live replication to work, as outlined in the documentation : https://developer.redislabs.com/riot/redis/


TLS Handshake bytes

I have this code:
package main

import (
   "encoding/hex"
   "fmt"
   "github.com/google/gopacket"
   "github.com/google/gopacket/layers"
)

const ipv4 = "45000181000040004006c622acd90ea30ad7ad0101bb963a77eb888ebc0fefd650182000b49c000016030300ec040000e8000189c000e20181707f176e28362f0c47652928fd581b9edd207ab9d5181cb03a39839449dc45dd78b377fc75a00877e38985211d3f4d18d9fa08328b98a687b233f2325a8dbe03b0270c901eefd308434c3719f1bed23e075e21e17e37155a77d9f52a7a71a663190124ce0b09e3a64afd181975f733748cc6112646c862c571a6d897672d0ec045fa13ffc3d48a3964767ccd6e5587e79f86f95fe634ec88aaea4c8868a3cf70fdb4d4bb8e0cc4335fe4b52e9f3c9f6b76f050f95bbdd52f769e9d1266add50875b1d5682cf53642cb7ace3d1fcaa4743b973fa0512a7f456bfe4396e21f1cc31403030001011603030020b0aae794fe71c67c2dbde28684f19df7e07984a3644ee6635abbefc28989dd041703030038f55a18e4017989eecdffcba058a557543fa5d277badbd606fa08a973c3717cfd3539f9a2375f0be478de6985c61fc829bd566f6dcfb65438"

func main() {
   data, err := hex.DecodeString(ipv4)
   if err != nil {
      panic(err)
   }
   packet := gopacket.NewPacket(data, layers.LayerTypeIPv4, gopacket.Default)
   payload := packet.TransportLayer().LayerPayload()
   var layer layers.TLS
   layer.DecodeFromBytes(payload, gopacket.NilDecodeFeedback)
   fmt.Printf("%#v\n", layer)
}

Where the input is a single IPv4 packet with a TLS Layer (345 bytes), and four TLS Records:

Record
bytes

New Session Ticket
241

Change Cipher Spec
6

Encrypted Handshake Message
37

Application Data
61

Application Data gets saved as .AppData and .BaseLayer, and Change Cipher Spec is saved as .ChangeCipherSpec. But New Session Ticket is just gone, and you only get the Handshake metadata, rather than the actual Handshake bytes. I am needing to extract Handshake bytes from all packets, is that possible?

workaround:
https://github.com/89z/parse/tree/master/crypto


Trim pull request line to terminal width on unix systems (no wrap)

commit MERGED in pull request #26


narrow: Fix narrowing behavior when loading a new tab.

In the very early days of Zulip, we didn't have unread counts; just
the pointer, and the correct behavior when opening a new tab was to
place you near the pointer.  That doesn't make any sense now that we
do have unread counts, and this corner case has been a wart for a long
time.
This commit does the main behavior change here.  However, there's a
bug we need to fix, where we might end up trying to pre-render a view
of the narrow based on the all_msg_list data before all_msg_list
is caught up).  We need to fix that bug before we can merge this; it
should be possible to determine that using FetchStatus on
all_msg_list, or with better performance by using the unread_msgs
structure to determine whether the message we should be selecting is
present locally.
Fixes #789.

For testing this and working on the outstanding bug, the test procedure is this:

manage.py populate_db -n2000
manage.py mark_all_messages_unread
Login as Iago, pick a stream/topic pair, narrow and hit end in that narrow to mark as read.
Reload.

Before this change, you'd be placed at the first message to that topic ever.  With this change, you get placed somewhere random that appears to be the bottom, and then a fetch from the server adds a few more messages below where you're placed.  Correct would be to be placed at the very bottom.
I made some notes on fixing the remaining issue above.  I believe what we need to do is as follows:

For the on-reload case, first (correct but potentially not optimized version), just unconditionally do a fetch from the server when doing rendering.  I have an idea for how to do this that I'll try in a commit after getting home.

This was merged, along with a series of other commits required to fix the rest of the problem.


Will PowerShell 6 have Get-HotFix?

Is Get-HotFix a Microsoft-only thing?

Get-Hotfix uses a CIM (WMI) class - root\cimv2\Win32_QuickFixEngineering
so will only work on systems that have that class available.  At the moment that's Windows boxes only

@RichardSiddaway - Thanks for your reply. Is there any plan to include other platforms? I can understand that Apple could respond with support, but am not suggesting that they would. How would Linux distros support such a capability?

This is another one that a vendor such as Red Hat, Ubuntu, and/or Apple should pick up.

If this were to be made xplat, I would imagine it would perhaps be best reimplemented as a PSProvider of sort.

Can we add this cmdlet back for Windows for PowerShell v7 backwards compatibility?

@SteveL-MSFT Please confirm that we can bring the cmdlet back as Windows-only. Or is current intention to use it by a compatibility tool?

Let me look into this a bit

The reason it was missing previously is that it relied on the old WMI .NET APIs which didn't exist in .NET Core 2.x.  However, they are back so we can re-enable this cmdlet with some small changes.  Working on a PR.

So I got it working on my Win10 machine, however it doesn't return anything.  This cmdlet basically wraps the WMI query: select * from Win32_QuickFixEngineering, which also doesn't return anything on my Win10 machine when used directly outside of PowerShell.

@SteveL-MSFT  that's strange, I can run a Get-CimInstance and get values returned on my Win10 machine on PS 6.2.2 and 7-preview4.
PS C:\> Get-CimInstance -ClassName Win32_QuickFixEngineering

Source        Description      HotFixID      InstalledBy          InstalledOn
------        -----------      --------      -----------          -----------
              Update           KB4495618     NT AUTHORITY\SYSTEM  6/12/2019 12:00:00 AM
              Security Update  KB4470788                          3/12/2019 12:00:00 AM
              Security Update  KB4503308     NT AUTHORITY\SYSTEM  6/12/2019 12:00:00 AM
              Security Update  KB4504369     NT AUTHORITY\SYSTEM  6/12/2019 12:00:00 AM
              Security Update  KB4509095     NT AUTHORITY\SYSTEM  8/11/2019 12:00:00 AM
              Security Update  KB4512577     NT AUTHORITY\SYSTEM  9/27/2019 12:00:00 AM
              Security Update  KB4516115     NT AUTHORITY\SYSTEM  9/27/2019 12:00:00 AM
              Security Update  KB4512578     NT AUTHORITY\SYSTEM  9/27/2019 12:00:00 AM

@tnieto88 the key part is:

This cmdlet basically wraps the WMI query: select * from Win32_QuickFixEngineering, which also doesn't return anything on my Win10 machine when used directly outside of PowerShell.

In other words, somehow this WMI/CIM class only exists inside PowerShell. wmic also can't find it either.
That's a first for me, @SteveL-MSFT, has this sort of thing been done before? 😕

@vexx32 would it be possible to rewrite it to be a cdxml instead of a binary cmdlet?

@tnieto88 let me create a Win10 VM that isn't domain joined in case something is happening there to try it.  I don't think it makes sense to rewrite it.  The code is pretty simple, just need a system that has instances of that class to test against.

But the class is included in the standard WMI class documentation - https://docs.microsoft.com/en-us/windows/win32/cimwin32prov/win32-quickfixengineering
I've got a script from the Windows 2000 Scripting Guide that uses Win32_QickFixengineering class via VBScript so it should be accessible outside of PowerShell
In theory it would be possible to produce a CDXML wrapper for the class. I can experiment with that if required

It's certainly possible to wrap it in CDXML.  Feel free to experiment!

On my Win7 VM, the cmdlet works, so I'll add some conditional tests if Win32_QFE returns any instances then submit a PR.

To be clear, this is only re-enabling the cmdlet on Windows.


Added helper methods to InputEvent

Added helper methods for InputEvent to detect first press and release actions. Could be done before, but this makes it nicer and more clear to write. Would like to amend the in-editor documentation to explain the new methods.

Don't forget that now Input.is_action_pressed and InputEvent.is_action_pressed has different behaviours.


[Question]: I want to store the chat_history in a postgresql that is installed locally on my machine.

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
So, I am trying to create a chatbot that performs RAG over documents of different companies.
I what to store chat_session in a postgres table using chat_session_id.
Also, when I retrive the data back from the table, I wany to convert it into
[List[ChatMessage]]

and pass it to my ContextChatEngine
chat_engine = ContextChatEngine.from_defaults(
        memory=memory,
        retriever=index.as_retriever(),
    )

@SiddharthMurjani you can convert your chat history to json / string, then store it wherever you need
Something like
chat_history_dicts = [x.dict() for x in chat_engine.chat_history]
chat_history_blob = json.dumps(chat_history_dicts)

chat_history_dicts = json.loads(chat_history_blob)
chat_history = [ChatHistory.parse_obj(x) for x in chat_history_dicts]

chat_engine.chat("Hello", chat_history=chat_history)

Thankyou @logan-markewich !


Custom Taxonomy support in Lumberjack

Is there or will there be custom taxonomy support in Lumberjack? I haven't been able to register or use them at all in lumberjack, and there seems to be no documentation regarding this at all...

Great question. As Lumberjack is just a layer on top of WordPress, you can register and use custom taxonomies the usual WordPress way.
Saying that it is something we are keen add into Lumberjack. We were thinking of a similar setup to custom post types. We have made a start in this already, but I can't say when it'll be finished.
It's also worth noting that due to Lumberjack's extensibility, you can write your own implementation. You could write your own service provider to register. This is Lumberjack's service provider for custom post types as a guide:
https://github.com/Rareloop/lumberjack-core/blob/master/src/Providers/CustomPostTypesServiceProvider.php
Any more questions please let me know.

Thanks for the great answer. I've managed to implement the registration of custom taxonomies the same way custom post types are registered.  This still needs some work, but the basics are layed out at this point.
I'd love to see what you can come up with this, with custom classes would be cool

Glad you managed to handle the registration yourself. We have some decisions to make, that involve understanding more about Timber's Term class more, as we'll probably want to extend this (similar to how we extend Timber's Post).
So yeah, this is on the cards but we want to make sure we get it right :)

Is there any news or progress on native custom taxonomy support in Lumberjack?

+1. Just ran into the need for taxonomies. @joldnl would you mind sharing your implementation? Cheers!


[build] Integration Tests occasionally timeout

It seems that the integration tests occasionally timeout. Rerunning them on CircleCI will get them to pass but this is very annoying.

We could make the integration task have some huge timeout, and the jest test as well, and then record how long these tests take into some file and then in a couple weeks review the average numbers

We could make the integration task have some huge timeout, and the jest test as well, and then record how long these tests take into some file and then in a couple weeks review the average numbers

That's a good idea, if the failure is just caused by the tests not completing in time.
I suspect there might be a race condition somewhere though(I think the wallet might not get loaded in time for the first API call), so it may be that the when the tests fail they will timeout no matter the time we give them.


Add Admin API Catalog

Description:
Add Admin API Catalog based on [1].
[1] https://github.com/wso2/apk/blob/main/admin/admin-domain-service/ballerina/resources/admin-api.yaml

Live location of the doc
https://apk.docs.wso2.com/en/latest/catalogs/api-reference-admin/


Add a nutrition tips page

Description
Develop a comprehensive Nutrition Tips page that provides users with practical and actionable advice on healthy eating. This page should be a valuable resource for users looking to improve their diet and make informed food choices.
Features
Daily Nutrition Tips
FAQ
Seasonal Eating Guides

Please assign this issue to me @samarsajad


Added 6 new icons and linked 2 apps to existing ones

Description

Added power icon (I hope it's okay that I gave it a universal name since it's not an app specific icon) and linked Classic Power Menu to it. Added icons for CPU Info, LocalMonero, DeutschlandCard, Easer (also linked it to Easer (beta)) and Fallout Shelter. Linked Clock You to clock and Geometry Dash Lite to geometry_dash.
Type of change

:x: Bug fix (non-breaking change which fixes an issue)
✅ : Icon addition (non-breaking change that adds/modifies Lawnicons's icons)
:x: General change (non-breaking change that doesn't fit the above categories, such as copyediting)

Icons addition information

Icons added

Classic Power Menu (com.kieronquinn.app.classicpowermenu)
CPU Info (com.kgurgul.cpuinfo)
LocalMonero (co.localmonero.app)
DeutschlandCard (de.deutschlandcard.app)
Easer (ryey.easer)
Fallout Shelter (com.bethsoft.falloutshelter)

Icons linked

Clock You (linked com.bnyro.clock to @drawable/clock)
Geometry Dash Lite (linked com.robtopx.geometryjumplite to @drawable/geometry_dash)
Easer (beta) (linked ryey.easer.beta to @drawable/easer)

I only tested this out after opening the pull request and I've noticed that clips don't seem to work, so I'll need to fix that before this can be merged

I've fixed the issue, all icons how they're supposed to now

Changed it

Mind just resolving conflicts and I'll merge it then

cc @Fxsch

Conflicts should be resolved

Actually, never mind. Now the appfilter.xml has duplicates and 2 closing tags for resources.

I just replaced appfilter.xml with the newest version from this repo and added my changes back in, I hope everything's fixed now

Would be nice if this could get merged soon, I'm already working on a new pull request


Modified GDScript code gets saved to disk without a prompt

Godot version:
master branch commit eaa5dfbdbd1217d62902f966496658770638c3d1
Steps to reproduce:

Save all the changes to a scene.
Open a GDScript with the built-in editor and write some text to it and do not save those changes.
Go to Scene->Quit to exit the editor, and click on Quit.
The GDScript that was being modified gets saved to disk

I've also noticed that when editing a GDScript that was just saved, it is not getting marked as modified in the editor as soon as you start typing.
Minimal reproduction project:
saved_without_asking.zip

I do not know the system of the reported issue but I can confirm this on Ubuntu in master and 3.0.2 too.

I got the same issue, and I'm able to trigger it by doing this:

Modify a GDScript
Instead to save the file Press F5 to start the game

Now even if the editor show saving process the file was not saved and it became impossible to save. The only way to make it saving again is Close then Open the editor.

Maybe script text editor is applying (saving to disk) changes on exit?

Apparently this is just a feature of the editor and can be enabled/disabled with the interface/editor/save_each_scene_on_quit property. So this isn't a bug and can probably be closed?

Still reproducible in the current master branch.

This one's nasty! Combined with #40199 I think the only way to safely discard bad changes to a script is to forcibly kill the Godot process.

This is likely due to the script editor remembering script state across sessions. Can someone try to reproduce this on the latest master branch?
cc @Paulb23

I could reproduce it on master branch with the same steps.


TypeError: this.element.nativeElement.getElementsByTagName is not a function

Hi!
I've imported textmask to my project (.net core and angular 4). However, there is still error:
TypeError: this.element.nativeElement.getElementsByTagName is not a function
at MaskedInputDirective.setupMask
Could you help me to take a look?

Please provide a plunkr, I cannot make any sense of this issue with the current description.


Tendermint 0.18.0

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


[relay][external codegen] outline and inline lifted functions for external codegen

This PR outlines the functions that will be handled by external codegen and then inline them back to avoid the optimizations from Relay. All function level passes are handled directly from the pass manager. A few module level passes needs to detect if a function uses default compiler or not. This is because these passes take the functions internally and they are invisible to the pass manager.

cc @comaniac @mbaret @soiferj @tqchen @icemelon9 @masahi

How about adding batch norm to the test to make sure it is still there after opt passes?

@masahi Good point. Done

Will wait for @mbaret's approval.

Also need to wait for the github bug to be resolved

Thanks @zhiics @mbaret @comaniac

@zhiics It looks like this makes it so we can't run any passes on external functions. Is this the intended behaviour, and if so are we intending to add a mechanism at some point to allow for passes on external functions?

Yes, this is intended. We plan to do it. For example, we may want to have a build pipeline that executes target independent passes first and then target dependent passes. We can partition after platform independent passes and rely on external compilers to take care of them.
You can do this right now manually. For example, you can run constant folding, CSE, etc, before partitioning.

Beforehand, we had been running some passes after partitioning (for instance a layout transform for ACL functions). It looks like we can't even force these to run now though as no function passes are allowed to touch external functions. We can't run the passes before partitioning because it will transform the entire graph, not just the bits for external partitioning.

I personally don't think TVM should be aware of accelerator specific transformations because they are very hardware specific. For example, we don't want this on TRT, dnnl, and many other accelerators. However, you can still do this even now. You can directly run layout transformation by yourself.

It's possible we're doing something wrong, but the function LowerExternalFunctions in compile_engine produces modules just containing external functions. We want to call passes on these modules from our ACL-specific codegen (so they'll only affect our codegen, not all TVM functions). However, it looks like the passes are skipping all the functions in these modules because they don't use the default compiler. Is there another way we can manually run the passes?

Can you post the questions on discussion forum?

Yep, I'll try and give a better explanation there in the morning.


Fix include

Oh god! What a mistake! I guess it can be removed at all as unused, or the file haven't compile at all...


Unable to get metadata from webhook callback

Hi @wilburt! Great work on this library.
Just one issue. I'm unable to get the metadata passed to the charge object when I get the callback on my webhook.
Here's my charge object.
Charge charge = Charge()
..amount = _amount * 100
..accessCode = accessCode["data"]["access_code"]
..email =<EMAIL_ADDRESS>..putMetaData("payment_data", [
{
'action': 'fund-wallet',
'customer_id': bucket.accountObject.items[0].customerId
}
]);
Metadata comes in as null. I'd really appreciate your help.
Thanks.

@wilburt Any feedback?

@Nigeriancoder  Please, can you show the full code including the payment method?

Closing this for now since there's been no response from OP. Please, reopen if the issue persists.

@Nigeriancoder have you found a way around this?


Remove storage implementation dependency from chain validator

Description of the Change
Removes postgres dependency from chain validator, because chain validator is not linked with postgres.

Benefits
Project builds successfully.

Possible Drawbacks
None.

Testing
A test that builds every CMake target independently will be written soon.

Now present in https://github.com/hyperledger/iroha/pull/1059


[front] - chore: use CitationNew component

Description
This PR refactors front to use the new CitationNew component instead of Citation and deprecate the zoomable citation component.
Risk
UX breaking changes
Deploy Plan
Deploy front

Can you do the same changes in extensions 😇 🙏


CI not catching updates to LICENSE files and api docs

          I wonder how is it possible that this delta is not caught by CI, it sounds like something is broken? @vdemeester wdyt?

Originally posted by @afrittoli in https://github.com/tektoncd/pipeline/issues/6189#issuecomment-1435244240
/kind bug

Curious if there's a good way to check license files? It would involve diffing the entire third_party directory which I'm not sure whether or not is worth it. (Then again we diff the whole vendor directory so maybe it wouldn't take that long; or maybe someone who's better at shell scripting than I am knows a magic way of doing this :) )

Curious if there's a good way to check license files?

What is involved in this kind of check? diffing third_party directory? Please elaborate

We do diff any "generated" files (from go generate, from go mod vendor , …), so we could definitely also check the third_party content. But, from my memory, I really thought we did already 🤔

We don't diff third_party but on second thought adding it in is totally reasonable-- working on this in https://github.com/tektoncd/pipeline/pull/6342


android-sample can not be compiled

Hi, thanks for sharing the Vulkan Samples.
The console reminds me that "Buildfile: build.xml does not exist!", after I executed the "build triangle" command. any suggestion?

The build.bat should initialize all required files (by calling _setup), including the build.xml:
call android.bat update project -p . -t android-19
If that's not working you may have to install the API19 (4.4.2) SDK platform from the Android SDK manager.
I should mention this somewhere in the readme, or try to check if there is a higher API-Level installed and just use that.

Many thanks for helping, that works.:)


Update Conda-app.yml

@henrykironde is the aim here to fix the conda build errors? https://github.com/mamba-org/setup-micromamba/issues/130.  Status here?

@henrykironde - is this still active and if so can you let us know what the goal is

Sorry, I missed the comments this was just me trying out some conda builds that were passing from other projects, not needed anymore.


Build a source servers overview page

The page should show a list of all servers with data like:

Time taken for a complete crawling cycle
Amount of indexed files
Approximate space usage (in TB)
Errors like a failled-connection-counter, failed-authentication-counter, …

e461a8bf1371497a279613654447d1190b34b195


Conflict between EntityCache and PersistentCache in beta 7

Hi, I have a siesta compile error since beta 7. Compilator says it need more context because there is two candidates for EntityCache class (in EntityCache.swift and in PersistentCache).

Oops: PersistentCache.swift shouldn’t be there at all. Looks like it got accidentally re-added during the big OS X PR merge, but the project still compiles locally & with Carthage because PersistentCache.swift isn’t in the Xcode project. Fixing.

Ok that's what i thought when i saw that this was exactly the same content


rename docs/readme.md

I believe that the reason  we only see the readme page at https://s3alfisc.github.io/pyfixest/ is because github pages thinks that the README is the full structure of the website.
Looking at https://github.com/s3alfisc/pyfixest/tree/gh-pages the README is the html page. However, other gh-pages branches do not have this html:

https://github.com/NKeleher/statsframe/tree/gh-pages

https://github.com/rstudio/pins-python/tree/gh-pages

I've renamed docs/readme.md to docs/pyfixest.qmd.
Confirmed that the website renders locally. I also ran quartodoc to update the references pages.

The website now render properly 🥳Thanks for all your work on this, it will save me an incredible amount of time in the future!


feat: add CreationDate fields to various resources

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


add partner profile for dnation

discussed with @mpilka

Visible on staging: https://staging.scs.community/website/partners/dnation


Displaying gif on canvas

I have tried image function with p5 but it just showed the initial image of the gif not the entire animation, any advice?

@emrebicer
Here's a demo: https://editor.p5js.org/kjhollen/sketches/S1bVzeF8Z
Maybe this will help you.

Thank you for the answer :)

In addition, there is this open issue on p5 to get animations working natively: https://github.com/processing/p5.js/issues/3380

Also, check out this library!
https://github.com/wenheLI/p5.gif/


Airdrop page to Navbar

Hello,
Based on forum post - make the claim airdrops less intrusive. I have moved the Airdrop popup to menu.
This PR contains:

Move the airdrop page trigger to menu.
Fix on Airdrop page loader.
Removal of the previous Airdrop component and logo.
Introduce the "highlighted" nav items status.

The new implementation looks like this:

When user navigates to the page the airdrop menu item is displayed as a menu item. The menu requests the Airdrops, if there are airdrops available the button will be turned green to inform the user that has an airdrop to be claimed. When the user navigates to the airdrop page if the data is not loaded it will load the data (in the meanwhile shows the loader).
Regards,
Emi

Close this out as our preference is for airdrops to remain as is and its possible that airdrops arent likely to continue much longer as there will be a proposal to stop them.


OS 2.1: change recommendation cannot be created without line numbering

This might be a feature but it is not clear why:

open a motion, set the line numbering to inline or turn it off
try to create a change recommendation

result: this is impossible

That's correct. To create a new change recommendation you have to show the line numbers in outline mode because you have to select line numbers (which is to complicated in inside mode and not possible in none mode).

OK, Ill document this behavior.


Add Docker and Linux setup instructions

Issue Resolved: #29

Added Linux setup instructions
Added Docker files and setup instructions
A separate section for environment variables setup instructions to avoid repetition

@rk119 can you pull the latest changes from the main branch to your PR?


[tool_crash] RPCError

Command
flutter run

Steps to Reproduce

...
...
...

Logs
RPCError
#0      VmService._call (package:vm_service/src/vm_service.dart:1769:7)
#1      VmService.getVM (package:vm_service/src/vm_service.dart:1245:25)
#2      FlutterDevice.initLogReader (package:flutter_tools/src/resident_runner.dart:428:55)
#3      HotRunner.attach (package:flutter_tools/src/run_hot.dart:266:21)
<asynchronous suspension>
#4      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:867:27)
<asynchronous suspension>
#5      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1408:27)
<asynchronous suspension>
#6      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#7      CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#8      FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:420:9)
<asynchronous suspension>
#9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#10     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:364:5)
<asynchronous suspension>
#11     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:130:9)
<asynchronous suspension>
#12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:153:19)
<asynchronous suspension>
#13     main (package:flutter_tools/executable.dart:93:3)
<asynchronous suspension>

[✓] Flutter (Channel stable, 3.24.4, on macOS 14.7 23H124 darwin-arm64, locale en-VN)
    • Flutter version 3.24.4 on channel stable at /Users/admin/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 603104015d (3 weeks ago), 2024-10-24 08:01:25 -0700
    • Engine revision db49896cf2
    • Dart version 3.5.4
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/admin/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16B40
    • CocoaPods version 1.15.2

[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Android Studio (version 2024.2)
    • Androi

Closing this as a duplicate of https://github.com/flutter/flutter/issues/154903


feat: SSR - Reload browser automatically on hot reload

Description
Right now we need to manually reload the page to see the change when hot reload triggered
Think that auto-reload the browser is a crucial part of good DX
Requirements

[ ] All CI/CD checks are passing.
[ ] There is no drop in the test coverage percentage.

Additional Context
No response

Thanks for opening this issue @moshe5745 👋
This is a good suggestion and one that would make Dart Frog development feel a bit more like Flutter based development. The first feedback from the team on this is that having some kind of add in being injected when running in Debug mode that would have an open socket back to the Dart Frog server listening for server updates. When an update is received reload the page. This would have the side effect of breaking the current flow that the user is in as there wouldn't be any context saved across the page reload but overall would allow for the Hot Reload functionality.
This feels like something that our proposed Plugin system could be used for as it would be hooking into the build process at certain times. We need to get through that work before implementing this but we can leave this ticket open to try and discuss the implementation specifics and get them documented here before any code get's written.

This would have the side effect of breaking the current flow that the user is in as there wouldn't be any context saved across the page reload

I don't think we care about SPA like the state
If we do SSR the client state would be minimal and probably backed up in local storage(like Alpine.js do)
But there is another scenario that could be annoying
When you fill-up a form and it reset on reload
A solution to this could be to save the state of forms in the Dart Frog server


Added "308 Permanent Redirect" to ReasonPhrases

From RFC7538 - https://tools.ietf.org/html/rfc7538

Also, are you interested in a PR for "451 Unavailable For Legal Reasons" (RFC7725)? I see it's missing from the HTTP abstractions as well...

:ship:

@muratg @Eilon @davidfowl What's your take on 451?

:shipit: 308 seems like a pretty safe. I would take 451 too because why not?

Submitted 451 as well... #930

Seems safe and nice to me too. Though bar for 1.0.0 is very high now, so we'll get this in once we branch for RTM.

Let's merge this. :ship:


Log all events

All events such as creating shops and banks, trying to destroys someone elses shop, accessing a shop, etc. should be logged in a separate log file with time stamps. This could be togglable and would ease debugging significantly.

Config could have a verbosity level parameter, were 0 is default, 1 is error only, 5 is all events, etc.

It seems that best practice for logging in Bukkit/Spigot/Paper plugins is to use the built in plugin.getLogger() method. Here all log entries are entered with timestamps and a verbosity level. These event will then be quite easy to filter out from the log file, using tools such as grep. However whether or not more events should be logged is definitely up for discussion. Currently the following is being logged: locking and unlocking chests(shops), failure to read from files(balance.yml and config.yml)


Port db_modes_test to Python test framework

The db_modes_test has been very unstable on Mac. This is likely because it takes a much longer time to start up nodeos on Mac and the db_modes_test.sh script just waits for a few seconds before proceeding forward with the assumption that it has started up.
We would like to make the test more robust by actually polling (with reasonable timeouts) for signals that nodeos has actually successfully started up. For example, by enabling the eosio::chain_api_plugin and polling get_info until the testing script gets back a successful response.
Building it support for this into the existing bash script will require recreating code that is already in place in the Python testing framework. So instead, we would like to port over that test to the Python testing framework and making it more robust in the process.
Note that using eosio::chain_api_plugin as a mechanism to make the db_modes_test more robust will make it non-parallelizable (at least until the Python testing framework is updated to force usage of different port numbers to avoid conflicts) and so the ported over test should have the nonparallelizable_tests label.

Resolved by #7390


MSID: 98662 Version: 1 DOI: 10.1101/2<IP_ADDRESS>5864

MSID: 98662
Version: 1
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>5864
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=98662
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>5864

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/98662v1
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>5864
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/98662/v1/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

Need to move videos into package from eJP.

WoS question asked


Integrate Dwolla

[x] set up Dwolla application
[ ] create Dwolla button
[ ] integrate Dwolla on page (integrate with sharing?)
[ ] create a thanks.html page to which people will be redirected after a successful payment

Honestly... I don't think Dwolla is a good fit for us. Might be worth reevaluating options sometime in the summer. We certainly aren't going to have anything in place for Season 2.


Creating A Custom Animated Shimmer Effect with Jetpack Compose

Article checklist
Attention
Our Peer Reviewer and Content Moderator teams do NOT provide any revisions services. All revisions and edits should be completed on your own forked repo (as to not take up room in the queue) in order for our team to review them all in a timely manner.
ANY ARTICLE SUBMITTED WITH GLARING ERRORS WILL BE IMMEDIATELY CLOSED.

As a rule of thumb - please be sure to only submit articles (pull requests) that are fully polished and ready to be published. Be sure to go through our resources documents for extra and 3rd party (vetted) resources to help improve overall technical writing.

Pre-submission checks

Please ensure that you have only one open topic suggestion (issue) + in-review article (linked pull request) at a time. This will ensure that we complete the review process in a timely manner from inception to publishing

If you have not already, please go over our Resources Page for more tips and tricks on how to improve your overall technical writing so reviews are swifter, increase the chance of a payout and provide more value to our readers.

For first-time contributors and for more details on our submission guidelines, see our Contributing Guidelines.

Formatting and structure checks

[x] Have you used the correct folder and file structure? - see Contribution Guidelines

[x] Is your article properly formatted in Markdown? - see Github Markdown guide

[x] Have you used our preferred heading structure? - H3 (###) and up

[x] Does your article follow any of the suggested structure formats? - see example formats

[x] Is your article over 750 words? - Tool: Wordcounter.net

[x] Is the article you are submitting an in-depth and unique article? Does it go beyond what is in the official docs and what is covered in other blog sites. See these articles as examples.

[x] Does your article provide enough value and detail about your topic? - Articles should be clear, accurate, and fully explained.

[x] Can your article be understood by beginners? - Assume the audience is smart but has no prior exposure to the common terminology in your article.

[x] Have you included a hero image that is 600x400 pixels, under 300KB in size, and have the copyright to use it? - Tools: Pixlr Image Editor for resizing and Unsplash for Creative Commons images

Grammar & plagiarism checks

[x] Have you spellchecked and grammar checked your article? - Tools: Write&Improve - ProWritingAid - Grammarly
[x] Please place your article through a 3rd party plagiarism checker. We suggest using Quetext, this tool is free and has a daily limit. We typically accept articles with 10% or less.
[x] Have you checked your article for readability? - Tool: Hemmingway
[x] Have you added sources for quotes and images that aren't yours?

Technical checks

[x] Are your code snippets properly formatted for syntax highlighting - see Syntax guide
[x] Have you checked your code runs correctly and you've highlighted all necessary dependencies for installation?
[x] Are the software programs and packages you're highlighting in your article up to date, using current versions and not deprecated?

Topic suggestion this closes

Remove the backticks and add the issue number below to link and close your Topic Suggestion (issue) when your article has been published (PR has been merged). See this video for more details.

This closes #5070

@Ericgacoki  👋
thank you for jumping on this PR
Is there any older PR that you can review instead? I believe we have a few unassigned that have been open for a few days.
This one was opened an hour ago. Thank you

@Ericgacoki wave thank you for jumping on this PR
Is there any older PR that you can review instead? I believe we have a few unassigned that have been open for a few days.
This one was opened an hour ago. Thank you

@hectorkambow :wave:
Thanks for pointing this out. I had glanced through the old PRs and none of them seemed too familiar to me or within my review areas. No worries though, let me take a second look and find one that I can follow along with 🤗

Greetings @hectorkambow :hand:
I'll proceed with this one since it's in a reasonable position in the queue.

Hello @kirwa-elyjah, we're glad to see you at Section Eng-ed. Congrats on opening your first PR 👏 🎅🏿

Plagiarism check is done.

Nice work gents @kirwa-elyjah @Ericgacoki

Merged #5753 into master


AmbiguousMatchException at SearchServiceClient

On the latest search preview, I'm trying to create a new SearchServiceClient like below
new SearchServiceClient(searchServiceName, new SearchCredentials(apiKey));
then I get the following error. However, this is only on the server. What is the problem?
[AmbiguousMatchException: Multiple custom attributes of the same type found.]
   System.Attribute.GetCustomAttribute(Assembly element, Type attributeType, Boolean inherit) +122
   Microsoft.Rest.ServiceClient`1.get_FrameworkVersion() +103
   Microsoft.Rest.ServiceClient`1.SetDefaultUserAgentInfo() +177
   Microsoft.Rest.ServiceClient`1.SetUserAgent(String productName, String version) +50
   Microsoft.Azure.Search.SearchServiceClient..ctor(String searchServiceName, SearchCredentials credentials) +79

@ahmettaha This looks like an issue with the Microsoft.Rest.ClientRuntime library. Are you able to reproduce the problem with any other Azure SDKs that take a dependency on the same version of Microsoft.Rest.ClientRuntime that the Search SDK does?
@shahabhijeet Digging through the history, I see that you're the author of ServiceClient.FrameworkVersion. Any idea what the problem could be?

I dont use ClientRuntime for anything else. Also, this error does not happen on my local compute simulator. It happens on azure cloud service deploy. I'm not sure if it means anything.

ok. BotFramework is also using it apperantly, and I got the same error when using it.

ok. got it fixed. I downgraded Microsoft.Rest.ClientRuntime from 2.3.3 to 2.3.2.

Possibly related: https://github.com/Azure/autorest/issues/1542

I was not able to downgrade Microsoft.Rest.ClientRuntime from 2.3.4 to 2.3.2 due to Microsoft.Azure.Search 3.0.1 having a dependency on 2.3.4. So I had to downgrade Microsoft.Azure.Search to 1.1.3.

@jeradrose Are you also using Application Insights by any chance?

On Azure, and client-side, yes. But not server-side (SDK).

Also receiving AmbiguousMatchException when initializing SearchServiceClient after upgrading to Microsoft.Azure.Search 3.0.1.
Application Insights is configured on my WebRole properties to send diagnostic data to App Insights - and I can confirm that when I disabled Application Insights on my web role properties I no longer receive the AmbiguousMatchException (App Insights SDK is still installed in my web project and collecting requests but not sending additional diagnostic data).

@jeradrose

On Azure, and client-side, yes. But not server-side (SDK).

And you observe the AmbiguousMatchException in all three cases...?

The Application Insights team are working on a fix:

We know the root cause and working on a fix. We expect the fix shipped next week. Meanwhile the work around is to disable Application Insights Azure WebSite extension or StatusMonitor. Please escalate using CSS channel if you need a hotfix sooner.

@brjohnstmsft Assignign to you to resolve when the root issue is resolved.  Please reassign if appropriate.

Updating the App Service - Application Insights extension to the latest version solves the issue.
Azure Portal > App Service > Extensions > click on Application Insights > click on Update

The root issue has been resolved. See the related issue for details on how to deploy the fix.


Feature/hook new

@vmihailenco I think the change to replace .clone() with *c resulted in the c.cmdable still being bounded to the previous c.Process as a result the return from WithContext returns a client that on .Process still uses the old ctx or nil if it does not exist.
Is this intended behavior?

@e-zhang You are right - should be fixed in https://github.com/go-redis/redis/pull/1080


[FEATURE REQUEST]: Add USACE Division Download Extents

Feature Request Type

[X] Application Programming Interface (API)

Is your feature request related to a problem? Please describe.
RFC Extents have partial coverage for watersheds along the perimeter of the RFC extents.
Describe the solution you'd like
The USAC Division boundaries cover all the watersheds within each division.
Describe alternatives you've considered
District boundary extents as well as custom project extents for a group of USACE watersheds are also desirable, and will submit a separate requests for those.
Additional context
Would like to start with the SAD and NAD Division extents

Suggest a new Office category of "USACE" and for Watershed use the Division names and acronyms, e.g.:

North Atlantic Division (NAD) - https://github.com/USACE/cumulus/issues/420
South Atlantic Division (SAD) - https://github.com/USACE/cumulus/issues/419

NAD.zip
SAD.zip

@adamscarberry thank you! I confirmed the update and functionality, all good.


bindTooltip should unbind existent tooltip

if a tooltip is bound to a layer with the option permantent: true and then a new tooltip is bound to the layer, the open permanent tooltip is not removed

var layer = new L.Marker(center).addTo(map);
layer.bindTooltip('Tooltip Test text', {permanent: true});
layer.bindTooltip('Other text', {permanent: false}).openTooltip();

https://jsfiddle.net/falkedesign/h6mogur9/
I think this can be added in the Refactor DivOverlay/Popup/Tooltip project.

"Overlapping" is not important
"permanent" is not important
What is really important: bindTooltip should close existent tooltip.

What is really important: bindTooltip should close existent tooltip.

Correction: should unbind existent tooltip.


[Feature Request] Ability to use different colors in Radio-group Attributes

Existing Component
Yes
Component Name
Radio
Description
As far as understand, the Radio-group Attributes allow to select one font and background pair of attributes, to be used on all the buttons. Would it be possible to have each button styled on its own (to have one, say, red when selected, and another one yellow when selected)?

+1

Sorry, we have no plan to support this. You can write your own CSS.


feat: Adds YamlLinting and TF checking

Why the Terraform checks when Terraform isn't in this repo?

@chris31389 I'm thinking of future proofing it, is that a bad idea? I was gonna make the builds consistent across all of the repos. What do you think?

I mean I suppose you'd need the tf deploy code, so some code would need to be added anyway.

I think its not needed here.  All the repo's are simple small repo's and only the cosmos repo requires Terraforms.
If you add it, its another thing to maintain


[🐞]i want to use ant design ui ,but it use less。did qwik support less?

Which component is affected?
Qwik Runtime
Describe the bug
[🐞]i want to use ant design ui ,but it use less。did qwik support less?
Reproduction
null
Steps to reproduce
null
System Info
null

Additional Information
No response

yes! you can use less!
https://qwik.builder.io/docs/components/styles/#css-preprocessors


Test ignoring metric value duplicate key

We should have a test to exercise  what happens if we add a metric that would cause duplicated labels? This is in the KafkaMetricsCollector in the convert method and in the YammerMetricsCollector in the convert method.
LOG.warn("Ignoring metric value duplicate key {}", v1);

@mimaison @k-wall
The logic that handles non-numeric metrics is in the DataPointSnapshotBuilder class. Here is where a new label with a metric value is created.
Currently we unconditionally add our new label without checking if a label with the same name exists already.
Is this the correct desired behaviour or should we also consider either of the following posibilities:

Do nothing if a label with this name already exists
Add a WARN log if it happens

In the previous iteration for version 0.16.0 we had the following warning:
LOG.warn("Ignoring metric value duplicate key {}", v1)
Should we have something like this again?
Two question I have.

What are the circumstances that would lead to multiple labels with the same name existing? Would this be a user who would do this?
What are the ramifications if we do add another label with the same name as an existing label which could potentially happen with the current logic?

II've written this to add the warning back in. WDYT?
       Map<String, String> labelMap = new HashMap<>();
       labels.forEach(label -> labelMap.put(label.getName(), label.getValue()));

       String sanitizedMetricName = PrometheusNaming.sanitizeLabelName(metricName);
       String valueString = String.valueOf(value);

       if (labelMap.containsKey(sanitizedMetricName)) {
           LOG.warning("Ignoring metric value duplicate key: " + sanitizedMetricName);
           labelMap.put(sanitizedMetricName, valueString);
       } else {
           labelMap.put(sanitizedMetricName, valueString);
       }

       Labels.Builder newLabelsBuilder = Labels.builder();
       for (Map.Entry<String, String> entry : labelMap.entrySet()) {
           newLabelsBuilder.label(entry.getKey(), entry.getValue());
       }

       Labels newLabels = newLabelsBuilder.build();
       return InfoSnapshot.InfoDataPointSnapshot.builder()
               .labels(newLabels)
               .build();
   }

Seems to be working as expected:
WARNING: Ignoring metric value duplicate key: name
Ignoring metric value duplicate key: name

java.lang.IllegalArgumentException: Duplicate label name: 'name'.

I think there are 2 different things.

Existing labels that once sanitized collide: When we sanitize label names, some characters are replaced, so a metric could have 2 labels that only collide when they are sanitized, for example some-label and some_label would collide. Previously  we would log a warning in that case: https://github.com/strimzi/metrics-reporter/blob/5d5c3b20c5ec2e9c7c9ef730c9057eb50007f496/src/main/java/io/strimzi/kafka/metrics/MetricFamilySamplesBuilder.java#L82
Causing a collision when we insert a new label for non-numeric metrics. As far as I can tell, previously we would always insert our new label, as seen in https://github.com/strimzi/metrics-reporter/blob/5d5c3b20c5ec2e9c7c9ef730c9057eb50007f496/src/main/java/io/strimzi/kafka/metrics/KafkaMetricsCollector.java#L118 and https://github.com/strimzi/metrics-reporter/blob/5d5c3b20c5ec2e9c7c9ef730c9057eb50007f496/src/main/java/io/strimzi/kafka/metrics/YammerMetricsCollector.java#L132 and not log anything.

It would be good to define the expected behavior in both cases.

One thing you should have done is check the behavior of Labels. A quick test shows we can't insert labels with the same names, doing so throws IllegalArgumentException.
Running:
Labels.Builder labelsBuilder = Labels.builder();
labelsBuilder.label("k", "v");
labelsBuilder.label("k", "v");
Labels labels = labelsBuilder.build();

produces:
java.lang.IllegalArgumentException: k: duplicate label name
	at io.prometheus.metrics.model.snapshots.Labels.validateNames(Labels.java:174)
	at io.prometheus.metrics.model.snapshots.Labels.sortAndValidate(Labels.java:164)
	at io.prometheus.metrics.model.snapshots.Labels.of(Labels.java:108)
	at io.prometheus.metrics.model.snapshots.Labels$Builder.build(Labels.java:437)

I get the same behavior if I call labels.add("k", "v").

So it is throwing an exception already if there are duplicate labels? Just not being logged?

Having gone through it, this happens after lebels are sanitized

If it's an existing label or a newly inserted one, once the duplicate is detected after sanitization, an exception is thrown, right?
So if k-1 isn't sanitised, we get the is an illegal label name exception. I've tested this and it does sanitize bad labels. When the label is sanitized, then it becomes k_1 and if we have this label already we get the : duplicate label name exception. This terminates the metrics processing right? Having a warning means the the metrics will still be gathered without crashing the whole thing.
Questions still for me are:
*Do we want a hard stop with an exception if there are duplicate lables?
*Do we want to issue a warning, don't add the duplicate and carry on?
*Do we want to alter the duplicate so that both metrics can be logged (is this even possible)?

@mimaison
Rewriting the infoDataPoint method (below), this catches a duplicate label name after sanitization and logs a warning inststead of throwing an exception. To me, this behaviour makes sense. WDYT? I've also written the test which I can commit and push if we agree this is the desired behaviour?
public static InfoSnapshot.InfoDataPointSnapshot infoDataPoint(Labels labels, Object value, String metricName) {
        Map<String, String> labelsMap = new LinkedHashMap<>();
        labels.forEach(label -> labelsMap.put(PrometheusNaming.sanitizeLabelName(label.getName()), label.getValue()));

        String sanitizedMetricName = PrometheusNaming.sanitizeLabelName(metricName);
        String valueStr = String.valueOf(value);
        if (labelsMap.containsKey(sanitizedMetricName)) {
            LOG.warning("Ignoring metric value duplicate key: " + sanitizedMetricName);
        } else {
            labelsMap.put(sanitizedMetricName, valueStr);
        }

        Labels.Builder newLabelsBuilder = Labels.builder();
        labelsMap.forEach(newLabelsBuilder::label);
        Labels newLabels = newLabelsBuilder.build();
        return InfoSnapshot.InfoDataPointSnapshot.builder()
                .labels(newLabels)
                .build();
    }

Do we want a hard stop with an exception if there are duplicate lables?
I don't think so. If we throw and don't handle the exception, then no metrics will be collected. As monitoring is crucial this is not an option.

Do we want to issue a warning, don't add the duplicate and carry on?
Yes we should log something so operators are informed if this happens. A warning with details about the issue seems right.

Do we want to alter the duplicate so that both metrics can be logged (is this even possible or desired)?
I'm not sure I understand exactly what you mean. Can you provide an example?

@OwenCorrigan76 If you want feedback on a piece of code it's best if you open a PR or at least commit to a branch in your fork. This allows other participants to comment, provide feedback and easily run the code. It's a bit clunky if for example I have to tell you have one that the 10th lines there's something not quite right.
The Labels class has a contains() method. Why are you not using that to check if a label name already exist? Creating a temporary Map and then creating another Labels instance is unnecessary. Also at this point the label names have already been sanitized. Finally this code only addresses the 2nd point from my comment above.

Done in https://github.com/strimzi/metrics-reporter/commit/210e4d0273ec81a4e6af0db5aaaa758cc8496968


Are DeepDPM dependencies compatible with recent GPUs ?

Hello,
We are trying to run the test code of DeepDPM on RTX 3090 and RTX A5000.
We created a singularity VM with the dependencies listed in
https://github.com/BGU-CS-VIL/DeepDPM/blob/main/requirements.txt
Then, from this VM, ran the test code:
Singularity> python3 DeepDPM.py --gpus 1 --offline --dataset synthetic --log_emb every_n_epochs --log_emb_every 1
Sequential()
GPU available: True, used: True
TPU available: False, using: 0 TPU cores
LOCAL_RANK: 0 - CUDA_VISIBLE_DEVICES: [0,1,2]
/usr/local/lib/python3.8/dist-packages/torch/cuda/__init__.py:145: UserWarning:
NVIDIA GeForce RTX 3090 with CUDA capability sm_86 is not compatible with the current PyTorch installation.
The current PyTorch install supports CUDA capabilities sm_37 sm_50 sm_60 sm_70.
If you want to use the NVIDIA GeForce RTX 3090 GPU with PyTorch, please check the instructions at https://pytorch.org/get-started/locally/

  warnings.warn(incompatible_device_warn.format(device_name, capability, " ".join(arch_list), device_name))

  | Name              | Type              | Params
--------------------------------------------------------
0 | cluster_net       | MLP_Classifier    | 201
1 | subclustering_net | Subclustering_net | 252
--------------------------------------------------------
453       Trainable params
0         Non-trainable params
453       Total params
0.002     Total estimated model params size (MB)
Epoch 0:   0%|                                                                                | 0/158 [00:00<?, ?it/s]/usr/local/lib/python3.8/dist-packages/pytorch_lightning/utilities/distributed.py:68: UserWarning: training_step returned None if it was on purpose, ignore this warning...
  warnings.warn(*args, **kwargs)
Epoch 0:  50%|█████████████████████████████████████████████████████████████████████████                                                                         | 79/158 [00:00<00:00, 240.26it/s, loss=nan, v_num=]Initializing clusters params using Kmeans...
Epoch 0:  51%|██████████████████████████████████████████████████████████████████████████▍                                                                        | 80/158 [00:02<00:02, 33.51it/s, loss=nan, v_num=]
Traceback (most recent call last):                                                                                | 0/79 [00:00<?, ?it/s]
  File "DeepDPM.py", line 448, in <module>
    train_cluster_net()
  File "DeepDPM.py", line 428, in train_cluster_net
    trainer.fit(model, train_loader, val_loader)
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/trainer/trainer.py", line 499, in fit
    self.dispatch()
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/trainer/trainer.py", line 546, in dispatch
    self.accelerator.start_training(self)
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/accelerators/accelerator.py", line 73, in start_training
    self.training_type_plugin.start_training(trainer)
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 114, in start_training
    self._results = trainer.run_train()
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/trainer/trainer.py", line 637, in run_train
    self.train_loop.run_training_epoch()
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/trainer/training_loop.py", line 577, in run_training_epoch
    self.trainer.run_evaluation(on_epoch=True)
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/trainer/trainer.py", line 726, in run_evaluation
    output = self.evaluation_loop.evaluation_step(batch, batch_idx, dataloader_idx)
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/trainer/evaluation_loop.py", line 166, in evaluation_step
    output = self.trainer.accelerator.validation_step(args)
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/accelerators/accelerator.py", line 177, in validation_step
    return self.training_type_plugin.validation_step(*args)
  File "/usr/local/lib/python3.8/dist-packages/pytorch_lightning/plugins/training_type/training_type_plugin.py", line 131, in validation_step
    return self.lightning_module.validation_step(*args, **kwargs)
  File "/mnt/iribhm/people/zzhang/DeepDPM/DeepDPM-main_vincent/src/clustering_models/clusternet_modules/clusternetasmodel.py", line 268, in validation_step
    logits = self.cluster_net(codes)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/mnt/iribhm/people/zzhang/DeepDPM/DeepDPM-main_vincent/src/clustering_models/clusternet_modules/models/Classifiers.py", line 59, in forward
    x = F.relu(self.class_fc1(x))
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/linear.py", line 103, in forward
    return F.linear(input, self.weight, self.bias)
RuntimeError: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.

Next, we tried to run DeepDPM from a VM we routinely use with RTX 3090 and RTX A5000 GPUs, which rest on more recent libraries versions. Not too surprisingly this failed:
python3 DeepDPM.py --gpus 0 --offline --dataset synthetic --log_emb every_n_epochs --log_emb_every 1
2022-08-12 13:26:04.514401: W tensorflow/stream_executor/platform/default/[dso_loader.cc:64](http://dso_loader.cc:64/)] Could not load dynamic library 'libcudart.so.11.0'; dlerror: libcudart.so.11.0: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /.singularity.d/libs
2022-08-12 13:26:04.514479: I tensorflow/stream_executor/cuda/[cudart_stub.cc:29](http://cudart_stub.cc:29/)] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
Traceback (most recent call last):
  File "DeepDPM.py", line 19, in <module>
    from src.clustering_models.clusternet_modules.clusternetasmodel import ClusterNetModel
  File "/mnt/iribhm/people/zzhang/DeepDPM/DeepDPM-main_vincent/src/clustering_models/clusternet_modules/clusternetasmodel.py", line 17, in <module>
    from src.clustering_models.clusternet_modules.utils.plotting_utils import PlotUtils
  File "/mnt/iribhm/people/zzhang/DeepDPM/DeepDPM-main_vincent/src/clustering_models/clusternet_modules/utils/plotting_utils.py", line 8, in <module>
    import umap
  File "/usr/local/lib/python3.8/dist-packages/umap/__init__.py", line 2, in <module>
    from .umap_ import UMAP
  File "/usr/local/lib/python3.8/dist-packages/umap/umap_.py", line 28, in <module>
    import numba
  File "/usr/local/lib/python3.8/dist-packages/numba/__init__.py", line 200, in <module>
    _ensure_critical_deps()
  File "/usr/local/lib/python3.8/dist-packages/numba/__init__.py", line 140, in _ensure_critical_deps
    raise ImportError("Numba needs NumPy 1.21 or less")
ImportError: Numba needs NumPy 1.21 or less

Any advice to fix this issue?
All the best,
Vincent

Hi,
We tried running our code on RTX 3090 and it ran smoothly...
Can you please try create an environment with the requirements as they are listed in the readme file? (maybe there was a problem with generating the requirement file?)
Let us know how it goes...

Hello,
We needed cuda >= 11.3 and finally managed to run your demo command in GPU mode with the latest pytorch/cuda installs and only a minor fixe:
    trainer = pl.Trainer(logger=logger, max_epochs=args.max_epochs, gpus=args.gpus, num_sanity_val_steps=0, checkpoint_callback=checkpoint_callback, limit_train_batches=args.limit_train_batches, limit_val_batches=args.limit_val_batches)

changed to
   trainer = pl.Trainer(logger=logger, max_epochs=args.max_epochs, accelerator='gpu', devices=args.gpus, num_sanity_val_steps=0, callbacks=checkpoint_callback,limit_train_batches=args.limit_train_batches, limit_val_batches=args.limit_val_batches)

to accommodate a recent Pytorch Lighting update.
We still get a few 'deprecated' warnings, but nothing preventing us to run the code.
Thanks for your reply !
Vincent