Tenant user created after bootstrap cannot create products and order.

We are trying to create a product and order from the user-created after the tenant website bootstrap, but the request is failing.
Below is the comparison of the token from the bootstrap user and the user-created after bootstrap.

The token from the non-bootstrap user does not contain the custom tenant id field.
Below are the logs of the product container.

method  createUser() in UserManagementService.java file does not set  custome:tenant-id.

Hi, Just want a clarification here because createUser() function will not be invoked in the product and order flows. Are you saying you are seeing this issue when adding products/orders or when adding a user?

Hi, Just want a clarification here because createUser() function will not be invoked in the product and order flows. Are you saying you are seeing this issue when adding products/orders or when adding a user?

Aah ok. Will check it out and get back. Thanks for reporting

Hi, any updates?

Hi, Yes, we were able to replicate the issue and are working on a fix. You will see an update here once it is approved and merged.

Hi ranjith. Will it take longer?

Hi! yes, this is going through a round of testing, so we are looking to merge it to main once that is complete. You will see updates this week.

Root cause: Web app not passing custom attribute "custom:tenant-id" as part of the Cognito IdToken in the case of a new user created from the tenant's application. This fails validation when the request is processed by TokenManager class inside ProductService causing the tenantId to be null and therefore rejects the request. Incoming PR to add the missing custom attribute tenant-Id while creating the new user in createUser() function of UserManagementService.java

Hi @ameetcateina could you retest and let us know? You would just have to rebuild and deploy the user-management-service to test this out. I will leave the issue open for now until you confirm. Please let us know how it goes.

Hi Ranjith,
I Redeployed the entire thing since we had to change aws regions.
Now after deployment when I hit the admin site it gives the following error.

When i run the build_and_upload_admin_site.sh it gives the following error.

Hi @ameetcateina that seems to be an issue with the node version? if you run node --version is it > 12?

Hi, the node version is v10.24.1.

Can you try using a newer version of node? If you're running on cloud9 you can just run:
nvm install 14
and then
nvm use 14

Hi, I upgraded node i get the followwing error on running the admin site script

Hi, i upgraded the node ver and ran the admin site script but i get the following error
amit_karkera:~/environment/aws-saas-factory-eks-reference-architecture (main) $ ./build_and_upload_admin_site.sh starfishstack starfishstack-adminsite-1md03juonc-adminappbucket-1cfhy3sqqsp28 e2edigital.com
aws s3 ls s3://starfishstack-adminsite-1md03juonc-adminappbucket-1cfhy3sqqsp28
Current Dir: /home/ec2-user/environment/aws-saas-factory-eks-reference-architecture
Configuring environment for Admin Client

eks-ref-arch-admin@ postinstall /home/ec2-user/environment/aws-saas-factory-eks-reference-architecture/clients/Admin
ngcc --properties es2015 browser module main --first-only

npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>- 3 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>- 3 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/webpack-dev-server/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
removed 1 package and audited 1467 packages in 10.591s
90 packages are looking for funding
run npm fund for details
found 1 moderate severity vulnerability
run npm audit fix to fix them, or npm audit for details

eks-ref-arch-admin@ build /home/ec2-user/environment/aws-saas-factory-eks-reference-architecture/clients/Admin
ng build --prod --aot --buildOptimizer --commonChunk --vendorChunk --optimization --progress

Option "--prod" is deprecated: Use "--configuration production" instead.
Support for camel case arguments has been deprecated and will be removed in a future major version.
Use '--build-optimizer' instead of '--buildOptimizer'.
Support for camel case arguments has been deprecated and will be removed in a future major version.
Use '--common-chunk' instead of '--commonChunk'.
Support for camel case arguments has been deprecated and will be removed in a future major version.
Use '--vendor-chunk' instead of '--vendorChunk'.
Warning: Support was requested for IE 11 in the project's browserslist configuration. IE 11 support is deprecated since Angular v12.
For more information, see https://angular.io/guide/browser-support
⠦ Generating browser application bundles (phase: building)...WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacer, 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷

298 │ $headings-margin-bottom:      $spacer / 2 !default;
│                               ^^^^^^^^^^^
╵
<EMAIL_ADDRESS>298:31  @import
<EMAIL_ADDRESS>9:9               @import
<EMAIL_ADDRESS>10:9                  @import
src/scss/style.scss 5:9                                            root stylesheet
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($input-padding-y, 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷

493 │ $input-height-inner-quarter:            calc(#{$input-line-height * .25em} + #{$input-padding-y / 2}) !default;
│                                                                                ^^^^^^^^^^^^^^^^^^^^
╵
<EMAIL_ADDRESS>493:80  @import
<EMAIL_ADDRESS>9:9               @import
<EMAIL_ADDRESS>10:9                  @import
src/scss/style.scss 5:9                                            root stylesheet
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($custom-control-indicator-size, 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷

560 │ $custom-switch-indicator-border-radius:         $custom-control-indicator-size / 2 !default;
│                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
╵
<EMAIL_ADDRESS>560:49  @import
<EMAIL_ADDRESS>9:9               @import
<EMAIL_ADDRESS>10:9                  @import
src/scss/style.scss 5:9                                            root stylesheet
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacer, 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷

706 │ $nav-divider-margin-y:              $spacer / 2 !default;
│                                     ^^^^^^^^^^^
╵
<EMAIL_ADDRESS>706:37  @import
<EMAIL_ADDRESS>9:9               @import
<EMAIL_ADDRESS>10:9                  @import
src/scss/style.scss 5:9                                            root stylesheet
DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacer, 2)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷

711 │ $navbar-padding-y:                  $spacer / 2 !default;
│                                     ^^^^^^^^^^^
╵
<EMAIL_ADDRESS>711:37  @import
<EMAIL_ADDRESS>9:9               @import
<EMAIL_ADDRESS>10:9                  @import
src/scss/style.scss 5:9                                            root stylesheet
WARNING: 84 repetitive deprecation warnings omitted.
✔ Browser application bundle generation complete.
Error: src/app/containers/default-layout/default-layout.component.ts:4:21 - error TS2307: Cannot find module 'process' or its corresponding type declarations.
4 import { env } from 'process';
~~~~~~~~~
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! eks-ref-arch-admin@ build: ng build --prod --aot --buildOptimizer --commonChunk --vendorChunk --optimization --progress
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the eks-ref-arch-admin@ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!

Sorry, I said node 14, can you try node 12? I have a fix coming in for node 14, but to get you up and running you should be able to use node 12. Note this line in the setup script

Hi, i am using this script to deploy adminsite.
./build_and_upload_admin_site.sh starfishstack starfishstack-adminsite-1md03juonc-adminappbucket-1cfhy3sqqsp28 e2edigital.com
I also tried wih url admin.e2edigital.com.
But I get the following errors.
Error: src/app/containers/default-layout/default-layout.component.ts:4:21 - error TS2307: Cannot find module 'process' or its corresponding type declarations.
npm ERR! errno 1
npm ERR! eks-ref-arch-admin@ build: ng build --prod --aot --buildOptimizer --commonChunk --vendorChunk --optimization --progress
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the eks-ref-arch-admin@ build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/ec2-user/.npm/_logs/2021-07-02T05_04_54_068Z-debug.log
aws s3 sync --delete --cache-control no-store dist s3://starfishstack-adminsite-1md03juonc-adminappbucket-1cfhy3sqqsp28
The user-provided path dist does not exist.

@ameetcateina I just pushed a change that should fix the build issue. Please make sure that you're running > node 12 in your terminal before attempting to run the build_and_upload_admin_site.sh script

node version is 12 as you suggested but its throwing same error

Did you pull the latest commit?

Sorry, my bad it wasn't the latest commit. But after doing git clone to the latest commit I get this error.
amit_karkera:~/environment/aws-saas-factory-eks-reference-architecture (main) $ ./build_and_upload_admin_site.sh starfishstack starfishstack-adminsite-1md03juonc-adminappbucket-1cfhy3sqqsp28 e2edigital.com
aws s3 ls s3://starfishstack-adminsite-1md03juonc-adminappbucket-1cfhy3sqqsp28
Current Dir: /home/ec2-user/environment/aws-saas-factory-eks-reference-architecture
Configuring environment for Admin Client
npm WARN using --force I sure hope you know what you are doing.
npm WARN Invalid version: "1.0"
npm WARN Admin No description
npm WARN Admin No repository field.
npm WARN Admin No README data
npm WARN Admin No license field.
up to date in 0.367s
found 0 vulnerabilities
npm ERR! Invalid version: "1.0"
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/ec2-user/.npm/_logs/2021-07-02T18_49_51_774Z-debug.log
aws s3 sync --delete --cache-control no-store dist s3://starfishstack-adminsite-1md03juonc-adminappbucket-1cfhy3sqqsp28
The user-provided path dist does not exist.
amit_karkera:~/environment/aws-saas-factory-eks-reference-architecture (main) $ node --version
v12.22.2

Please pull again. I accidentally added a version to the package.json

Hi, I am able to access the website but the same error has occurred which I posted here in the beginning.
Unauthorized error.

Hi @ameetcateina, notice the redirect_mismatch in the error string that's returned. Notice how the redirect URL is setup in the client by looking at this file. It's setting the redirectUrl url to window.location.origin. Assuming your admin application is running from from the appropriate Route53 alias, the value of window.location.origin should match the value of your Application Client's "Callback URL(s)" as seen in this screen shot.
 Can you verify that your Callback URL matches the domain name of your admin site?

Hi Toby,
Yes, it does match the URL of the window. location.origin.

Sorry this is becoming such an ordeal :( Are you sure you were attempting to hit the admin site from the https vs. http url? So, in your case, it should be https://admin.e2edigital.com

Hey toby, it's working.

working. The tenant user cannot make products on the tenant website. Also, a separate kubernetes namespace is not getting created for the tenant.

It might not be a bad idea. We've had minor issues installing (we did it again last weekend), but nothing like what you're seeing. Perhaps it's a region thing. If the namespace isn't getting created, you should look at the codepipeline that gets spun up for the tenant. There will be diagnostic information in the codebuild log.

Thanks for your time and effort, it's working after a fresh install. The only thing not working is the logout functionality on both admin and tenant sites.


make \dt and \dv use verbose and pattern arguments

see #82

Apart from the minor nitpick. PR looks great.
Thank you!  :penguin:

Sure thing. I also just realized that \di uses the same sql so that accepts verbose & pattern args now too

It's so nice when things come together like this. :)
Good work on spotting it. :snowman:


Remove pre-population of uploads on new revision

Delete the code which propagates the uploaded files from the
previous revision when generating a new revision.

LGTM


⚠ ca1grpc.serverssh.us has degraded performance

In befccce, ca1grpc.serverssh.us (http://ca1grpc.serverssh.us/) experienced degraded performance:

HTTP code: 200
Response time: 8819 ms

Resolved: ca1grpc.serverssh.us performance has improved in 0572fbd.


Installing latest versus a specific version

What is missing?
I noticed that the version of grafana which this role will install defaults to latest.
Making the decision to default to latest rather than specific version of grafana differs from the other roles that cloudalchemy publishes such as the pometheus and node_exporter role.
I personally like the fact that the role installs a known working version that the role is able to properly configure. Having the role install latest can cause issues if any breaking changes were released upstream.
Here are some references at the time of writing to the other roles which cloudalchemy publishes showing that the roles default to a specific version of the package.
https://github.com/cloudalchemy/ansible-prometheus/blob/aa95978755345097effca886bf116dace739d31b/defaults/main.yml#L2
https://github.com/cloudalchemy/ansible-node-exporter/blob/18ff8f8833b1e357ce91bee6832c3a3d16e709f2/defaults/main.yml#L2
Why do we need it?
To make it consistent with the behavior of the other roles which cloudalchemy publishes.
Environment

Role version:
0.19.1

Ansible version information:
ansible [core 2.11.6]

Anything else we need to know?:
I've recently ran this role and have installed version 8.2.5 of grafana.
If a choice needs to be as to which version of grafana this role should default to, 8.2.5 might be a good choice.

Closing due to inactivity.


how to query parametrized collection

We have OData service in which one of collection requires input parameters - how we can solve it using pyodata?
Using web browser it works using collection name, parameters passed in brackets and added "/Results" at the end of URI.

How does the URL looks like in browser?
Is your parameter passing described in OData v2 specification?

Our URL (XXXX for hiding business data...):
XXXXXXXX.XXXXX.net:XXXXX/sap/opu/odata/sap/XXXXXX-service/XXXXX-collection(XXXXClient='532023',XXXXClientTo='')/Results

Actually, you want to get a navigation property of an entity.
In your canse the navigation property is Results and the entity is XXXXX-collection(XXXXClient='532023',XXXXClientTo='')
count = client.entity_sets.XXXXX_collection.get_entity(XXXXClient='532023',XXXXClientTo='').nav('Results')

Works great, thanks for your help!

Actually, you want to get a navigation property of an entity. In your canse the navigation property is Results and the entity is XXXXX-collection(XXXXClient='532023',XXXXClientTo='')
count = client.entity_sets.XXXXX_collection.get_entity(XXXXClient='532023',XXXXClientTo='').nav('Results')

I have the same problem,
But I still don't understand how to get the final data through "count"?

Actually, you want to get a navigation property of an entity. In your canse the navigation property is Results and the entity is XXXXX-collection(XXXXClient='532023',XXXXClientTo='')
count = client.entity_sets.XXXXX_collection.get_entity(XXXXClient='532023',XXXXClientTo='').nav('Results')

I have the same problem,
But I still don't understand how to get the final data through "count"

Actually, you want to get a navigation property of an entity. In your canse the navigation property is Results and the entity is XXXXX-collection(XXXXClient='532023',XXXXClientTo='')
count = client.entity_sets.XXXXX_collection.get_entity(XXXXClient='532023',XXXXClientTo='').nav('Results')

I have the same problem,
But I still don't understand how to get the final data through "count"


operators dell-csi-operator (1.7.0)

Signed-off-by: Rensy Thomas<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.
New Submissions

[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Have you considered whether you want use semantic versioning order?
[ ] Is your submission signed?
[ ] Is operator icon set?

Updates to existing Operators

[x] Did you create a ci.yaml file according to the update instructions?
[x] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[x] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[x] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[x] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[x] Description about the managed Application and where to find more information
[x] Features and capabilities of your Operator and how to use it
[x] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[x] Human readable name and 1-liner description about your Operator
[x] Valid category name1
[x] One of the pre-defined capability levels2
[x] Links to the maintainer, source code and documentation
[x] Example templates for all Custom Resource Definitions intended to be used
[x] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need
2 For more information see here

/merge possible

/merge possible

/merge possible

/merge possible

Hi @mvalarh, I tried to install dell-csi-operator v1.7.0 from OperatorHub.io (https://operatorhub.io/operator/dell-csi-operator), It installs the older version of operator (v1.6.0) and not the latest version (v1.7.0).


C4702: unreachable code

Hello!
I have a problem:
C:\builds\eprotect-platfrom\auth\client\include\nonstd\expected.hpp(2142) : error C2220: the following warning is treated as an error
C:\builds\eprotect-platfrom\auth\client\include\nonstd\expected.hpp(2142) : warning C4702: unreachable code

OS: Windows 2022
Visual Studio 2022 v17.5.0
https://conan.io/center/recipes/expected-lite?version=0.6.3

Me too

How does that work? That line is a comment, there is no code there: https://github.com/martinmoene/expected-lite/blob/v0.6.3/include/nonstd/expected.hpp#L2142
Is it any different in your build directory?

Hello!
Repro:
#include "expected.hpp"

int main()
{
    nonstd::expected<int, int> ei = 0;
    return ei.value();
}

Compile using cl /O2 /W4 /WX main.cpp. expected-lite version is 0.6.3.
Output:
Microsoft (R) C/C++ Optimizing Compiler Version 19.39.33523 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

main.cpp
C:\test\expected.hpp(1803) : error C2220: the following warning is treated as an error
C:\test\expected.hpp(1803) : warning C4702: unreachable code

On Compiler Explorer:

MSVC v19.latest: -O2 -W4 -WX -Dnsel_CONFIG_SELECT_EXPECTED=nsel_EXPECTED_NONSTD: C4702: unreachable code.
clang 18.1.0: -O2 -Wall -Wunreachable-code-aggressive -Dnsel_CONFIG_SELECT_EXPECTED=nsel_EXPECTED_NONSTD: no warning.

I'm not sure what to think of MSVC's warning.

Thanks for your helpful thoughts to advance this issue.


[suda] Vim(let):E730: Using a List as a String

Hello.
I'm using vim(VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Jan 29 2024 09:41:19)) on openwrt.
I installed suda.vim on vim, and I tried to SudaWrite I've got this message.
[suda] Vim(let):E730: Using a List as a String

Any help would be appreciated.

Reproduced. It works on Neovim but Vim. Downgrading suda.vim to https://github.com/lambdalisue/suda.vim/releases/tag/v1.1.0 may helps.

We need to revert https://github.com/lambdalisue/suda.vim/pull/74 while Vim does not support a List expr but Neovim.
fyi @aarondill

Thanks!

@lambdalisue okay, i'm going to change the system to escape and join the string in suda#systemlist before passing it to system (sadly this means we have to use the intermediate shell)

@nemonein can you test #78 to make sure it fixes this issue?


Fix: multiple bugs on spark-shell usage

Submitting a fatJar after adding bblfsh-client results in runtime exceptions only when used \w spark-submit/spark-shell
java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.directExecutor()Ljava/util/concurrent/Executor;
	at io.grpc.internal.ClientCallImpl.<init>(ClientCallImpl.java:104)
	at io.grpc.internal.ManagedChannelImpl$RealChannel.newCall(ManagedChannelImpl.java:554)
	at io.grpc.internal.ManagedChannelImpl.newCall(ManagedChannelImpl.java:533)
	at gopkg.in.bblfsh.sdk.v1.protocol.generated.ProtocolServiceGrpc$ProtocolServiceBlockingStub.parse(ProtocolServiceGrpc.scala:37)
	at org.bblfsh.client.BblfshClient.parse(BblfshClient.scala:23)

This PR includes:

[x] update CI to run spark-shell --jar

[x] ~fix Caused by: java.lang.IllegalArgumentException: Allocation size must be greater than zero on .classifyLanguages()~ better be fixed in https://github.com/src-d/enry/pull/106 or elsewhere upstream

[x] ~fix~ workaround Caused by: java.lang.NoSuchMethodError: com.google.common.util.concurrent.MoreExecutors.directExecutor()Ljava/util/concurrent/Executor; on .extractUASTs()
Which is result of having old version of Guava in runtime classpath of Spark, when gRPC needs a new one. Best of all worlds solution would be - gRPC re-shade guava in their build... https://github.com/grpc/grpc-java/issues/2688 but that will take a while to get ScalaPB to adopt it.
Another option could be re-shade it on our side in a fatJar build. This should be handled in sub-sequent PRs.
There is a workaround, if we ship newer Guava AND a clients of SparkAPI set configuration properties in their apps (before creating in spark context i.e though spark-submit --properties-file)
 spark.driver.userClassPathFirst=true

CI uses this workaround. It can be automated on the client side by putting the above $SPARK_HOME/conf/spark-defaults.conf

[x] for some reason, spark.executor.userClassPathFirst=true results in  🐞
Caused by: java.lang.ClassCastException: cannot assign instance of tech.sourced.api.provider.SivaRDDProvider$$anonfun$tech$sourced$api$provider$SivaRDDProvider$$generateRDD$1 to field org.apache.spark.rdd.RDD$$anonfun$map$1$$anonfun$apply$5.cleanF$1 of type scala.Function1 in instance of org.apache.spark.rdd.RDD$$anonfun$map$1$$anonfun$apply$5

[x] workaround, using non-fat jar + --packages

After much experiments I could not find a way to work around different Guava version at runtime, while submitting a fatJar.
The only way it works for me is - submitting a regular jar, and providing all the dependencies though --packages with setting  spark.{driver, executor}.userClassPathFirst=true

The workaround is ready to be merged at will.
A fix for submiting actual fatJar would be handled in subsequent PR

But even if we implement the spark-shell wrapper we still have the same problem in the python wrapper and using the library programmatically unless the user adds userClassPathFirst to properties file, right?

I think all the errors fixed here are already fixed on master branch. Close these PR if true. Thanks!

@ajnavarro great!
I might have missed it, but could no find in master analog of end to end tests from 0a904e0


Revert "Jvenstad/config model incosistency fix part unknown"

Reverts vespa-engine/vespa#9311
In case we need to revert again

Seems we won't need to :)


Ignore CVE-2017-18342 for now

There is not a patched version ready yet and we don't load arbitrary YAML files anyway

@kierenbeckett i think we are going to have to do this as part of https://github.com/ONSdigital/eq-survey-runner/pull/1675 now eq-schema-validator change has been merged


Add information for biome-providers/extrusions directory

About https://github.com/PolyhedralDev/TerraOverworldConfig#customization
How do I make biomes larger / smaller?
It's said that meta.yml can be used, but the file itself doesn't specify units. For example:
mushroom-island-radius: 4
  # How large any given mushroom island will be.
  # Default: 4

What is that, 4 blocks? Meters? Yards? For anything -scale what does 1 unit represent -  global-scale says 300:1 in blocks but is that the same for the rest?
How do I remove all oceans / all land / all hot biomes / etc?
Notice the "etc" ... let's say we want to remove all Mountain biomes. We're led to biome-providers/presets/default.yml so is there something to do here or would it be at the source (and if so, how?). Also, biome-providers/README.md doesn't explain what the Extrusions subdirectory is for.
Please update with clarification.

Meta Scales
Noise distributing biomes for the most part is arbitrarily scaled. There's no absolute reference that says 'with this list of noise functions at x frequency, with a biome generating within ranges y of the each noise output, within area z there will be a biome on average n blocks wide'. This arbitrary noise scale is what each 'meta scale' modifies, so a scale of 1 means well.. a scaling of 1 i.e no scaling of that noise function (which could produce biomes of any size). A scale of 2 would increase the 'sizes' of applicable noise samplers by 2. (See https://terra.polydev.org/config/development/samplers/index.html#frequency)
To know the exact average block radius that something like 'mushroom-island-radius: 4' produces, you would need to go through and figure out how whatever particular noise algorithm is being used produces noise, determine some kind of 'unit length' between noise 'details' (e.g the size of the simplex grid used for simplex noise), and factor in everything that could possibly a affect that absolute reference size (which would probably require knowing how every step of the biome distribution process works for that particular biome provider).
Figuring out how things translate to exact block sizes is kinda an ass process and not really practical for anybody to do, it's way easier to just eyeball how big things are and adjust accordingly rather than being super scientific with exact block sizes. These meta scales simply provide an easy method to modify the arbitrary size of things by a factor.
Presets
Picking and choosing from presets only provides macro changes to biome distribution, for more specific things that we don't already have an easy way of changing (e.g removing all mountain biomes) would require modifications to the stage(s) that generate them. Making guides for specific modifications like this not really a priority and for such modifications it would be easier to just ask how to in Discord for the meantime.
Extrusion Dir
This should be documented, just hasn't been done :P

Thanks for the clarification. It would great if meta.yml could have a header comment stating that all values are arbitrary and to use a "try it and see" approach.
Not expecting specific guides, but how would one generally determine which stage needs to be modified? Looking at default.yml there's a cacophony of stages with no clear indication of which one generates biomes (basic_continents jumps out but as you say there's only a macro-level pool). Is there some rule of thumb to go by?

Something like that can be added
The current pipeline is setup such that the base ocean/land zones are distributed via the source, then slowly subdivided into more specific areas according to different noise maps.
The process is Continental (ocean/coast/land) -> Elevation (group biomes into zones based on terrain height) -> Temperature -> Precipitation -> Biome specific variants
Between those stages misc stuff like volcanoes, mushroom islands, etc are added.
This ordering should probably be documented somewhere, however is going to be slightly changed with 2.0 as elevation zones within the pipeline will  be replaced by a global terrain height map.

Yeah, after precipitation zones it'll either split off into actual biomes or into the variants stage - PRs are welcomed. The headers of the main stages should have most of that information already but if you think it should be somewhere else feel free to PR that

Also I should note that there will be a wiki for the overworld some time in the future:tm: where stuff like this will be explained - if you want to make markdown pages for that add them to the .wiki subdirectory which will be set up to sync with https://github.com/PolyhedralDev/TerraOverworldConfig/wiki


optimize: optimize transaction context switch logic when transaction mode switching

… is switched

Ⅰ. Describe what this PR did
Optimize transaction context behavior when transaction mode is switched:
1.remove interceptorType context variable.
2.add  branchType context variable and use it to distinguish different branch transaction modes.(distinguish TCC Mode and AT Mode)
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #2307 into develop will decrease coverage by 0.11%.
The diff coverage is 44%.

@@              Coverage Diff              @@
##             develop    #2307      +/-   ##
=============================================
- Coverage       51.4%   51.29%   -0.12%
- Complexity      2663     2664       +1
=============================================
  Files            510      510
  Lines          16604    16587      -17
  Branches        2033     1992      -41
=============================================
- Hits            8536     8508      -28
+ Misses          7261     7248      -13
- Partials         807      831      +24

Impacted Files
Coverage Δ
Complexity Δ

...java/io/seata/tm/api/GlobalTransactionContext.java
100% <ø> (ø)
6 <0> (ø)
:arrow_down:

...java/io/seata/spring/tcc/TccActionInterceptor.java
13.88% <0%> (+0.73%)
2 <0> (ø)
:arrow_down:

...c/main/java/io/seata/core/context/RootContext.java
40% <0%> (+7.39%)
9 <0> (ø)
:arrow_down:

...ing/annotation/GlobalTransactionalInterceptor.java
10% <0%> (ø)
2 <0> (ø)
:arrow_down:

...a/io/seata/tm/api/transaction/TransactionInfo.java
95.83% <100%> (+0.59%)
14 <2> (+2)
:arrow_up:

...java/io/seata/tm/api/DefaultGlobalTransaction.java
71.57% <100%> (+1.57%)
21 <1> (ø)
:arrow_down:

...in/java/io/seata/tm/api/TransactionalTemplate.java
73.4% <100%> (ø)
24 <0> (ø)
:arrow_down:

...a/io/seata/rm/datasource/exec/ExecuteTemplate.java
9.37% <16.66%> (+1.96%)
3 <2> (+1)
:arrow_up:

...obuf/convertor/BranchRegisterRequestConvertor.java
90.47% <0%> (-9.53%)
3% <0%> (ø)

...otobuf/convertor/BranchReportRequestConvertor.java
90.9% <0%> (-9.1%)
3% <0%> (ø)

... and 27 more

@q294881866 PTAL tcc


setSelectorSize method added to modify programmitically

setSelectorSize  added to modify the range slider with programmatically.

@oli107 in analysis, indicated as 'programmatically given dimensions needs to be in DP unit' but it won't. Suppose, you need to set setSelectorBoundarySize  and then pass value in pixel unit as argument.


bosh logs Does not work with teams

When running bosh logs as a user with bosh.teams.myteam.admin scope, users are unable to fetch logs for a deployment, and get a 401 from the director. All other tasks indicated by https://bosh.io/docs/director-users-uaa-perms/ for team admins are working.
CLI Output:
Using environment 'https://mybosh.com25555' as user 'me' (openid, bosh.teams.myteam.admin, bosh.teams.myotherteam.admin)

Using deployment 'test'

Task 2882113

Task 2882113 | 22:10:47 | Fetching logs for prom-test/b9858fe1-f860-4a55-ae7d-4f5c4bc8cb28 (0): Finding and packing log files (00:00:01)

Task 2882113 Started  Fri Jun 22 22:10:47 UTC 2018
Task 2882113 Finished Fri Jun 22 22:10:48 UTC 2018
Task 2882113 Duration 00:00:01
Task 2882113 done

Downloading resource '79385f79-74f8-4f4d-6840-d142d519f21f' to '/Users/localadmin/Workspace/test-20180622-151050-745764.tgz'...

Downloading logs:
  Downloading resource '79385f79-74f8-4f4d-6840-d142d519f21f':
    Director responded with non-successful status code '401' response ''

Closing this issue and re-opening it to create a tracker story.


Silent casting of heterogenous lists

In answering a stackoverflow question, I wanted to report what might be termed a bug. I'm using Numba 0.29.0.
In the docs, it says that lists must be "strictly homogenous" or numba will reject them. However if I have a function:
@nb.njit
def func(x):
    s = 0.0
    for a,b in x:
        s += a*b

    return s

and then call it with:
func([(1,1), (18.3,1), (2,2)])  # return 23 instead of 23.3

I'm not sure about the exact implementation, but it looks like numba is looking at the types of the first item in the list and then assuming that they are the same thus producing a different output than the undecorated function would.
The following function fails as expected:
@nb.njit
def func2(x):
    s = 1
    for a in x:
        s *= a
    return s

func2([1.1, 1, 3, 7.6])

gives:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-61-d39e4199a593> in <module>()
----> 1 func2([1.1, 1, 3, 7.6])

TypeError: can't unbox heterogenous list

Is it a bug that Numba is not checking type consistency of complex list items?

Thanks for the report. I think that the list is considered homogeneous as it is composed of tuples, irrespective of the varying contents of the tuples themselves.
@nb.njit
def func3(x):
    s = 0
    for a in x:
        s += a[0]
    return s

print(func3([(1,), (1.5,), (3,), (7.6,)]))
print(func3([(1.2,), (1.5,), (3,), (7.6,)]))
print(func3.inspect_types())

gives:
12
13.3
func3 (reflected list((int64 x 1)),)
...
func3 (reflected list((float64 x 1)),)
...

The first element is used as the baseline for comparison for the homogeneity test and then compared to the type of each subsequent element. Code used is here:
https://github.com/numba/numba/blob/master/numba/targets/boxing.py#L557-L564
I think is is a bug.

I experienced something similar but with numba.jit  instead.
I was passing arrays of tuples and was getting the can't unbox heterogenous list error message. Running it without jit was successful, so in order to find out was going on I ran it with some print messages inside the compiled function. To my surprise it ran successfully! I realised that there was nothing special with print, except for the delay it caused (it was printing the arrays). I had the same successful result inserting a time.sleep.
In the second example mentioned in this issue, if you run it with @numba.jit and add time.sleep(1), it does not complain about homogeneity at all.
Any ideas why is this happening?

I suspect you are observing the compiler pipeline backtracking that happens in @jit mode. When a function decorated with @jit is compiled, the first compilation pipeline attempted is a no-python pipeline that will result in function with a code path that avoids the interpreter, if this pipeline fails a fall back pipeline is run (object-mode) which tries to optimise as much of the function as possible via techniques such as loop lifting, but fundamentally will need to make use of the interpreter. Your observations tie in with this in that print only has partial support in no-python mode and time has none, so the fall back object-mode pipeline will be used. The heterogeneous list requirement is only enforced in no-python mode so if that mode cannot be employed due to the presence of some unsupported function then that constraint won't be present.
Example:
from numba import jit, njit
import time

# original function
def func(x):
    s = 0.0
    for a,b in x:
        s += a*b
    return s

# function with unsupported time.sleep call, loop cannot be lifted
def func_unsup_unliftable(x):
    s = 0.0
    for a,b in x:
        time.sleep(1)
        s += a*b
    return s

# function with unsupported time.sleep call, but the loop can be lifted
def func_unsup_liftable(x):
    time.sleep(1)
    s = 0.0
    for a,b in x:
        s += a*b
    return s

data = [(1, 1), (18.3, 1), (2, 2)]

jfunc = njit(func)
# this is the original reported bug
print(jfunc(data))

jfunc_unsup_unliftable = jit(func_unsup_unliftable)
# this does *not* trigger the bug because time.sleep is in an unliftable loop which forces object mode
print(jfunc_unsup_unliftable(data))

jfunc_unsup_liftable = jit(func_unsup_liftable)
# this does trigger the bug because time.sleep is in a position where the loop can be lifted into no-python mode
print(jfunc_unsup_liftable(data))

Running gives:
$ python issue2220.py
23.0
23.3
23.0

@stuartarchibald That's clear. Thanks man!


resultCode return CROP_IMAGE_ACTIVITY_RESULT_ERROR_CODE in android 11

When I take photo and click ok step crop image is ignore, close CropImageActivity and resultCode return CROP_IMAGE_ACTIVITY_RESULT_ERROR_CODE

@phamhoanuit 🚨🚨🚨🚨🚨 THIS LIBRARY IS NOT MAINTAINED, PLEASE READ THIS 🚨🚨🚨🚨🚨 #818

Replace the method getCaptureImageOutputUri in the CropImage.java file with the below code, might solve the problem.
it worked for me
public static Uri getCaptureImageOutputUri(@NonNull Context context) {
Uri outputFileUri = null;
File getImage = context.getExternalCacheDir();
if (getImage != null) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
outputFileUri = FileProvider.getUriForFile(context, BuildConfig.APPLICATION_ID + ".provider",
new File(getImage.getPath(), "pickImageResult.jpeg"));
} else {
outputFileUri = Uri.fromFile(new File(getImage.getPath(), "pickImageResult.jpeg"));
}
}
return outputFileUri;
}

Hey guys, i'm getting Failed to load sampled bitmap: file:///storage/emulated/0/Android/data/com.tayta.par/cache/pickImageResult.jpeg/storage/emulated/0/Android/data/com.tayta.par/cache/pickImageResult.jpeg: open failed: ENOENT (No such file or directory) after take the picture from camera on Motorola One Macro with Android 10. It works from gallery but not from camera. please i need help with this issue

@jimmyale3102 🚨🚨🚨🚨🚨 THIS LIBRARY IS NOT MAINTAINED, PLEASE READ THIS 🚨🚨🚨🚨🚨 #818

@Canato Then... Is there another library you recommended me?? I need to solve this soon

@jimmyale3102 yes, please read the #818

@jimmyale3102 yes, please read the #818

Yes, i am... i will migrate to that library, thank you so much

Replace the method getCaptureImageOutputUri in the CropImage.java file with the below code, might solve the problem. it worked for me
public static Uri getCaptureImageOutputUri(@nonnull Context context) { Uri outputFileUri = null; File getImage = context.getExternalCacheDir(); if (getImage != null) { if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { outputFileUri = FileProvider.getUriForFile(context, BuildConfig.APPLICATION_ID + ".provider", new File(getImage.getPath(), "pickImageResult.jpeg")); } else { outputFileUri = Uri.fromFile(new File(getImage.getPath(), "pickImageResult.jpeg")); } } return outputFileUri; }

not working in my case when i tap on button. it's not showing chooser.

@Canato the new library is not stable and not working for android 11

@Canato the new library is not stable and not working for android 11

Please open an issue on the new library, maybe worth checking the ones that are open. Indeed there are some issues in some devices for Android 11 that I cannot reproduce and people are working on a fix please feel free to help :)


Consolidate master cluster resize

Coverage decreased (-1.9%) to 87.549% when pulling 5a69cc66c76c7cf557621dfc33c2a791555f0247 on yuce:consolidate-master-cluster-resize into b48f94cc36568ce7c624409c2aa40fb587b0afde on pilosa:master.

@jaffee Is it OK to merge this PR?

@jaffee Great. Exported client.Status


How to get the length of time from ICU admission to death

Hi，
I want to calculate the 28-day mortality rate and the 90-day mortality rate. But there seem to be no death time,  how can I do to get the length of time from ICU admission to death.
Thanks

Unfortunately, eICU-CRD does not have data beyond the hospital admission, so you will not be able to calculate that rate in patients who's hospital stays aren't >28 or >90 days.


{Misc.} Fix consider-using-enumerate pylint error

Description
Finish the unfinished tasks of https://github.com/Azure/azure-cli/pull/20192
Fix consider-using-enumerate pylint error.

Thank you for your contribution! We will review the pull request and get back to you soon.


Pick up old jobs after reboot

A worker that is rebooted should restart the stream jobs it has been working on.

Should be fixed with #1233


the imports are not properly generated for customFetch which  fail running in docker environment

I am using customFetch  and additionalEnvelopPlugins with scripts pointing in my src as shown below.
everything works fine locally, but when I am doing docker build, I am getting import path error for  customFetch
This works in local run i.e, npm run dev but when dockerized and run, it is failing with path issues for customFetch

Workaround: I have to use this during docker build to make it work. (obviously not going to work for local run)

Note: additionalEnvelopPlugins has no issues.
I think the root cause is how imports are generated in .mesh/index.ts

Could you create a reproduction repo? Thanks!

Dockerfile
FROM node:19-alpine as runtime

# install pnpm
RUN corepack enable; corepack prepare<EMAIL_ADDRESS>--activate

WORKDIR /app

# clean install dependencies, no devDependencies, no prepare script
COPY .npmrc package.json pnpm-lock.yaml .meshrc.yml ./
RUN pnpm fetch --prod --unsafe-perm --ignore-scripts --unsafe-perm
RUN pnpm install -r --offline --prod

COPY . .

RUN pnpm build
RUN pnpm prune --prod --no-optional
############################################################
### stage_final
############################################################
FROM gcr.io/distroless/nodejs:18 as final

USER nonroot
ENV NODE_ENV production
WORKDIR /app

ENTRYPOINT ["/nodejs/bin/node"]
COPY --from=runtime --chown=nonroot:nonroot /app/.mesh ./.mesh
COPY --from=runtime --chown=nonroot:nonroot /app/config ./config
COPY --from=runtime --chown=nonroot:nonroot /app/src ./src
COPY --from=runtime --chown=nonroot:nonroot /app/tsconfig.json ./tsconfig.json
COPY --from=runtime --chown=nonroot:nonroot /app/package.json ./package.json
COPY --from=runtime --chown=nonroot:nonroot /app/node_modules ./node_modules

ENV PORT 4000
EXPOSE 4000

CMD<EMAIL_ADDRESS>"start"]

tsconfig.json
{
	"compilerOptions": {
		"outDir": "dist",
		"skipLibCheck": true,
		"target": "esnext",
		"moduleResolution": "node",
		"module": "commonjs",
		"lib": ["esnext"],
		"allowSyntheticDefaultImports": true,
		"esModuleInterop": true
	},
	"include": ["src"],
	"exclude": ["node_modules"]
}

Could you create a repo so we can run and reproduce?

@ardatan sorry for the delay. here is the repo to reproduce this issue
To reproduce error, run:
git clone https://github.com/xmlking/graphql-mesh-specific
cd graphql-mesh-specific
pnpm i
pnpm build
pnpm start

Error
💥 🕸  Mesh Error: Cannot find module './src/middleware/custom-fetch.ts'
Require stack:
- /graphql-mesh-specific/.mesh/index.ts

This should work without error
pnpm dev

I debugged this a bit and the issue is basically here:
https://github.com/Urigo/graphql-mesh/blob/30ecdbde782acf9b33e35805bc0f7deacbf4b038/packages/config/src/utils.ts#L103
which then calls:
https://github.com/Urigo/graphql-mesh/blob/30ecdbde782acf9b33e35805bc0f7deacbf4b038/packages/config/src/utils.ts#L66
A very hacky fix:
const relativeModuleName = cross_helpers_1.path.isAbsolute(moduleName) ? (type === 'fetch' ? `../${name}` : moduleName ) : moduleName;

I don't have time to dedicate to finding all the ways this (or a better fix) could break things (i.e. a proper solution).
For now, I'll likely sed my way out of this but maybe this helps someone more knowleadgeable to fix this quicker.
Btw this doesn't only affect docker environments. This happens calling yarn run mesh build.


issue: websearch (SearX)

Bug Report
Description
Correct URL for SearX instance ( eg, https://metasearx.com/search?q=<query> ) returns error.

Confirmed that -json is enabled in the SearX instance

Bug Summary:
Error message:
"Something went wrong :/ Oops! The URL you provided is invalid. Please double-check and try again"
Steps to Reproduce:

Open admin panel, settings, websearch.
Searxng Query URL enter: https://metasearx.com/search?q=<query>
Save settings
Open a new chat and enable websearch
Error returned

You can verify that the json is returned correctly for eg:
https://metasearx.com/search?q=what+is+the+weather%3F%0A%0A&format=json&pageno=1&safesearch=1&language=en-US&time_range=&categories=&theme=simple&image_proxy=0
You get mixed results when you adjust the URL for example,:
https://metasearx.com/?q=%
There is no error and sites are returned, however they are:
https://www.math.net/percentage
https://en.wikipedia.org/wiki/Percent_sign
Adding in <query> anywhere seems to break the process.
Expected Behavior:
Entering a query with websearch enabled and the websearch searx query url set to https://metasearx.com/search?q=<query>queries the searx instance, returns the JSON and answers the query based on results.
Actual Behavior:
Entering a query with websearch enabled and the websearch searx query url set to https://metasearx.com/search?q=<query> queries the searx instance, returns  "Something went wrong :/ Oops! The URL you provided is invalid. Please double-check and try again"
Environment

Open WebUI Version: latest

Ollama (if applicable): latest

Ubuntu 20.04

Brave

Reproduction Details
Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I am on the latest version of both Open WebUI and Ollama.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.

Logs and Screenshots

Browser Console Logs:
N/A]
Docker Container Logs:
Not sure how to get these
Screenshots (if applicable):

Installation Method

git clone project locally
installed docker nvidia container and settings
docker-compose -f docker-compose.yaml up -d

Additional Information
From the testing that I have done, even with my own searx instance (not local) and ensuring that json format is enabled the results come back if I use the url directly in the browser.  For some reason open-webui thinks that the json results returned are an error.
There is something funky happening with the way <query> is parsed.

I don't use searxng myself, so if anyone could chime in, I'd greatly appreciate it!
@manfromdownunder if you manage to find out what the culprit is, please keep us updated!

searxng

searxng I gave up too. There are issues, it's always unstable to use.

I think I have found the issue and it has nothing to do with the code.  There was an incorrect name server defined first in /etc/resolv.conf.  I fixed dns resolution and everything appears to be working as expected. The error I was seeing was due to the dns lookup failing.

Thanks for the followup @manfromdownunder 🙏


Profiles listing does not respect machine group filters

The report total in the top left is correct, but the tallies in the overall report listing as well as the full listing details do not support machine groups right now.

I think this has been fixed a long time ago


Update outdated d3 and other deps

After ensuring "d3": "3.5.3" was installed alongside the latest patternfly-timeline I see the following when attempting to start my app.

Been trying to troubleshoot exactly what this is, best I can manage is dependency jsdom being used by "d3": "3.5.3" is at 1.0.0 but we're looking for 1.0.0-pre.6 as per the devDependencies (also if you look at the jsdom deps, the ones its asking for are in the pre.6 version).

This appears to be a webpack configuration error:  https://github.com/webpack/webpack/issues/718 - you probably will need to modify your configuration to make sure jsdom is appropriately available on the window (just a guess).  The timeline demo app is still functioning correctly with a full clear/reinstall of the node_modules locally so the dependency tree outlined in the package.json is still valid.

oh! Hmm thanks for the lead, lets see where it leads...

Updating this pr to be a request to update the deps the lib specifically d3 from 3.x.x -> 4.x.x  👈 the migration guide is really thorough but alas, after stabbing at this all yesterday determined it is likely going to be a non-trivial amount of work to get this done
TL;DR - stale deps for patternfly-timeline prevent sui from incorporating the lib
https://www.pivotaltracker.com/story/show/142772825
@himdel

Hmmm.... The current patternfly dependency is 3.7 which also has dependencies on D3 3.x as does angular-patternfly (via patternfly). This would mean an update to both of those repositories as well.

@jeff-phillips-18 Perhaps the jsdom dependency is simply too specific here?
Upgrading to d3 4 can't quite happen for patternfly until a version of c3 which supports it is released.

While this lib does need a dep update for all things that can be, repurposing this issue just to make jsdom a little more flexible in hopes of fixing the above mentioned issue

@allenbw - does the jsdom dependency update fix this for you?  it's not intended to be a runtime dependency in the timeline (those would be managed within d3 and are outside the scope of this repo)

@AllenBW could you please address @dgutride question?

😃 will add that pt to current sprint

@chriskacerguis @dgutride no bueno on updating only jsdom dep

@AllenBW - we've updated D3 to a version that works with webpack, can you try to see if this addresses your problem  by using the latest hash in master-dist:  https://github.com/patternfly/patternfly-timeline/tree/master-dist  in your package.json file?

@dgutride I haave the same issue and can confirm that it does solve the problem.

@dgutride tks for point out


Handle errors

bors r+

bors retry

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+

bors r+


OCPBUGS-12689: hosted clusters default KAS PDA config should be consistent with OCP

What this PR does / why we need it:
Set hosted cluster KAS config pod security enforcement to privileged.
Which issue(s) this PR fixes:
Fixes OCPBUGS-12689
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/jira refresh

/area control-plane-operator

/jira refresh

/test e2e-aws

/approve

/jira refresh

/jira refresh

/test e2e-aws

/lgtm


Seeking clarification - Behaviour when mounted optional configmap appears after the pod is started

I am seeking clarification of the expected behaviour when a pod mounts a configmap (marking optional: true) and that configmap appears only appears after the pod has started.
      volumes:
        - name: foo
          configMap:
            name: foo
            optional: true
      containers:
      - name: controller
        volumeMounts:
        - name: foo
          mountPath: /foo

Will the pod see the configmap content?  Experimenting with v1.19, I believe the answer is yes, but I want to understand if this is defined behaviour and hence safe to rely on.
I don't think the docs make the point clear.
https://kubernetes.io/docs/tasks/configure-pod-container/configure-pod-configmap/#understanding-configmaps-and-pods
I see the point raised a couple of times during the feature's proposal:
https://github.com/kubernetes/kubernetes/issues/37041#issue-190191613

A config-map reference that is labeled as optional will show up as an empty directory. In addition, if the referenced config-map come into existence at a later point, it seems natural to have the config-map content show up in the mounted volume.

And during review of #175
https://github.com/kubernetes/community/pull/175#discussion_r93053986

Define what happens if an optional configmap is missing when the pod is started on the node, and the configmap appears later while the pod is running... will the files be populated at that point, or not?

but this point wasn't answered directly.

Hi @k-wall
We're happy to track an issue about the page being unclear - it's worth making it clear what happens if you add a ConfigMap where an existing Pod has this as an optional filesystem-based configuration source.
In terms of confirming the defined behavior is, that's a little outside of SIG Docs' usual purview. SIG Storage looks after ConfigMap as an API so what might make sense is if you submit a PR (pull request) that documents the behavior you've seen, and then request a review from @kubernetes/sig-storage-pr-reviews.
Does that make sense?
/language en
/sig storage

Fixed in #26957


Audit challenges and make sure each challenge has a hint article

Currently when you click the "get a hint" button, it opens a corresponding "hint article" on the forum with hints. We instead want to open a corresponding article on the Guide, since the Guide is much better suited toward presenting this type of information.
Currently, most of the hint articles lead to forum posts like this one: https://forum.freecodecamp.org/t/freecodecamp-algorithm-challenge-guide-roman-numeral-converter/16044
We've also ported these over to the guide, but they are varying states of repair: https://guide.freecodecamp.org/certificates/roman-numeral-converter/
@nsuchy has started the process of cleaning these up. We should finish it, then make sure every challenge on freeCodeCamp has at least a stub that we can point to for it.
This will be a big undertaking. I estimate it will be perhaps 20 - 30 hours worth of coding. These improvements could come through many pull requests.
In short, we need to:

[ ] Clean up the existing Guide articles for each challenge
[ ] Audit the challenges to make a list of challenges that lack a corresponding article
[ ] Create stubs for challenges that lack an article
[ ] Update the hint button on staging to point to the Guide rather than the forum

I would like to give this one a stab, if that's OK.

@iabrenne OK - awesome! Which part of this do you want to tackle first?

@QuincyLarson - I can start with with updating the links - the last item on the list:

[ ] Update the hint button on staging to point to the Guide rather than the forum

@iabrenne Just a quick update - we are still waiting for the new version of Gatsby.js, which will help us fix the problem we're having with too many article in Guide. As soon as we do, we'll resume working on all this. I'm closing this issue for now. Thanks for all your help.
By the way, we just launched our new curriculum and learning platform: https://learn.freecodecamp.org. We would welcome further contributions from you. Thanks again for helping improve the freeCodeCamp open source community!


Plotting

Could not get matplotlibcpp to work because it requires python. My computer being many years old has apparently resulted in many instances of python being installed in different locations. Seems like a pain to fix.

I will attempt to run it on a different computer.


Open new Firebase console to copy secret.

The location of the Firebase secret changed with the addition of the new console.  This PR opens the new console by default (but prints the correct URL for the classic Firebase admin page if needed).

Looks good!


Fix inheritance when schema in hierarchy does not have properties

Closes https://github.com/RicoSuter/NSwag/issues/2151
But one test fails and thus it is a breaking change...

Closes RicoSuter/NSwag#2151

That one isn't closed

But one test fails and thus it is a breaking change...

@RicoSuter  A failing test does not always mean a change is breaking. Which test was it? (The appveyor link above doesn't let me see which one)

There is also a merge conflict.

Updated with master.

@RicoSuter Any idea when this might be merged?


dotnet command line instructions don't work on a mac

With .net 6 Preview 7, the instructions for using the dotnet CLI fail on a Mac when trying to build a Maui app for iOS. Would like to use VS Code and dotnet CLI on a mac as a baseline build environment and eventually Visual Studio for Mac. Here is the outcome of running the Maui dotnet CLI instructions on a Mac.
breynolds@*** GitHub % dotnet new maui -n MyApp

The template ".NET MAUI App" was created successfully.

breynolds@*** GitHub % cd MyApp

breynolds@*** MyApp % ls

MyApp		MyApp.WinUI	MyApp.sln

breynolds@*** MyApp % dotnet restore

  Determining projects to restore...
**/usr/local/share/dotnet/sdk/6.0.100-preview.7.21379.14/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(90,5): error NETSDK1100: Windows is required to build Windows desktop applications.** [/Users/breynolds/GitHub/MyApp/MyApp.WinUI/MyApp.WinUI.csproj]

breynolds@*** MyApp % dotnet build -t:Run net6.0-ios

Microsoft (R) Build Engine version 17.0.0-preview-21378-03+d592862ed for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

MSBUILD : error MSB1009: Project file does not exist.
Switch: net6.0-ios

Hi @breynolds
The key instruction is: "In the .NET CLI, change directory to the single project and restore its dependencies:"
Your cd into MyApp brings you into the solution level folder. Do another cd MyApp to bring you into the single project. Then restore/build.


SAA-1758: Add new attendance deleted to environment

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.20%. Comparing base (56e8825) to head (05fcddf).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #952   +/-   ##
=========================================
  Coverage     84.20%   84.20%
  Complexity     3649     3649
=========================================
  Files           377      377
  Lines         12083    12083
  Branches       1056     1056
=========================================
  Hits          10174    10174
  Misses         1431     1431
  Partials        478      478

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can't create folder in top level！

Create folder always in clicked folder AND can't move to top level !

I'm sure no existing one. I just need to create or move folder to top level/

How to move an existing one to top?

Just drop it in the empty area below.
I understand this can be hard to do if you have too many files and fodlers but there is already an issue covering that.


ParallelTaskBuilder.execute hangs forever waiting for a task completion in sync mode after resources released

When ParallelClient.releaseExternalResources  is called while ParallelTaskBuilder.execute is waiting for a task to complete is sync mode then ParallelTaskBiulder hangs forever in this while: https://github.com/eBay/parallec/blob/1b4f1628f34fedfb06b24c33a5372d64d3df0952/src/main/java/io/parallec/core/ParallelTaskBuilder.java#L278
Even calling interrupt on executing thread (or shutdownNow on executor) does not have a result, because interrupts are swallowed.
Code snippet to reproduce:
    private static final Duration RELEASE_TIMEOUT = Duration.ofSeconds(3);
    private static final AtomicInteger PING_THREAD_ID_GEN = new AtomicInteger();

    public static void main(String[] args) {

        final ExecutorService pingExecutor = Executors.newSingleThreadExecutor(
            r -> new Thread(r, "PingThread-" + PING_THREAD_ID_GEN.incrementAndGet()));
        pingExecutor.submit(() -> ping());

        final ScheduledExecutorService releaseScheduledExecutor = Executors.newSingleThreadScheduledExecutor();
        releaseScheduledExecutor.schedule(() -> {
            new ParallelClient().releaseExternalResources();
            pingExecutor.shutdownNow();
            releaseScheduledExecutor.shutdownNow();
        }, RELEASE_TIMEOUT.getSeconds(), TimeUnit.SECONDS);
    }

    private static void ping() {
       new ParallelClient().preparePing()
                            .setPingNumRetries(0)
                            .setPingTimeoutMillis((int) RELEASE_TIMEOUT.plus(Duration.ofMillis(1000)).toMillis())
                            .setTargetHostsFromList(Collections.singletonList("<IP_ADDRESS>"))
                            .execute((result, responseContext) -> System.out.println(result));
    }

Result: PingThread-1 is sleeping forever.
Could you add !Thread.currentThread().isInterrupted() condition to the while (if this will not break anything else :) )? Or react on interruption in some way.

@kefasb  thanks so much for trying parallec.  Normally i do not need to run the releaseExternalResources if running as a server.   what is the use case we need to release all the resources?


Exact phrase search?

Anyway to make this work?

what about Bing.web('"to be or not to be"', ... )? so the double quotes are included in the search


tb -h problem

Describe the bug
tb -h doesn't work the same as tb --help
To Reproduce
type tb --help and observe the output
type tb -h and observe the output
Expected behavior
Outputs should be the same
Screenshots
none
Technical Info (please complete the following information)

OS: macOS 10.13.4
Node.js Version: 10.7.0
Taskbook Version:  0.1.1

Additional context
I don't know JavaScript, but if I'm reading the code correctly then there's also a problem with "tb -v" (and I verified that that's true).

Duplicate of #13.

Fixed at the pull request #53


Remove access control temporary override

Problem
Temporary override needs to be removed (issue #13867)
Also, controllers would like to provide custom implementations of
AccessControl::Check without having a cluster, ACL entries, etc.
Change overview
The delegate can now override the check, or proceed with
the standard check.
The "empty" default delegate now denies access, by
implementing check to return "deny."
The "permissive" example delegate still permits access, by
implementing check to return "allow."
The "normal" example delegate still performs a standard check,
by implementing check to return "not implemented" so the
standard check is performed.
Testing
How was this tested? (at least one bullet point required)

Unit tests pass on Linux
Ran against all-clusters-app via chip-tool on Linux

Need to see if CI indicates some tests need additional setup due to now denying if not set up.


<em> tag doesn't put text in italic in v4.4 as it does in 4.3

looks like a font impact, if I remove font-family, em text goes back in italic

Did you ever notice that Orange Brand Guidelines does not allow italicized text 😄?
FWIW it's because of font-synthesis I guess.

Confirmed, italic is forbidden by our brand. The only way to put an emphasis is the bold.
So unpopular question: should <em> be bold?


proxy: capitalize some request headers

Go std lib will normalize the request header, so something like Sec-WebSocket-Key will be changed to Sec-Websocket-Key. while some servers (e.g. weechat in issue #1332) may depend on the original one case-sensitive.
Signed-off-by: Tw<EMAIL_ADDRESS>

I've tested your branch and I can confirm this fixes issue #1332 for me completely. Thanks for your work on this!

Umm, wait a sec. I'm not saying No to this PR, but WeeChat is broken if it treats headers as case-sensitive. Why should we fix something in Caddy that is not broken?
(Thanks for working on this @tw4452852! I'm not criticizing your fix, I'm upset at weechat.)

@mholt Maybe weechat shouldn't treats headers as case-sensitive.
But I actually find something similar in gorilla.

Gorilla caved... I'm torn on this. I'll have to think about it!

Thanks for your thorough research on this @tw4452852 -- I've opened an issue upstream. I'll leave this open for a little bit but I will probably close it. If this change is what causes weechat to work with Caddy, then it's a bug in weechat and not in Caddy.

It looks like they're working on it upstream! 🙌  I'm going to close this now, since it looks like weechat 1.7 will have the fix. Thank you for your work on it!

Interesting.  While I can understand @mholt point of view and I agree with it, I also think it is not a good idea for caddy to modify headers as they go through.
My understanding here is that caddy is modifying the headers on the request.
Should we allow @tw4452852 fix and also have weechat fix their side?

My understanding here is that caddy is modifying the headers as the request is sent downstream.

The standard library is -- they are being normalized according to convention. Caddy itself doesn't change them, per-se. In HTTP/2, header field names are lowercased anyway. Let's just let weechat fix their end, and if Go shouldn't be modifying the casing of header fields, then that should be an issue with the Go standard library.


是否考虑可以集成到kubesphere中？

Yeah, we've plan to integrate OpenFunction into KubeSphere, possibly in KubeSphere v4.0


Add support for extra tags on all resources

This change introduces the ability to include extra tags on all resources created by Terraform. As @kezhenxu94 suggested - this enhancement enables compliance with enterprise-specific AWS tagging requirements and ensures a smooth resource creation process.

This PR might need a rebase (due to conflicts in the variables file) after the other two PRs are merged.


Adding a bit Joomla compatibility

In Joomla I meet a problem, that Joomla native validator seems to be triggered on a button click.

But it works with A tag perfectly

I like it. Thanks for the contribution 👍

Version 2.1.0 now built and released. Installing via bower should pull down the new version.


fixes for test

don't merge yet. will add some comments on monday. Thought it would be more helpful/instructive to open as PR-into-your-PR rather than just pushing to your branch.

@CarinaFo have a look through the files changed tab and see if you understand the changes and LMK if you have any questions. If you're satisfied, feel free to merge this now and it will become part of your PR into mne-python upstream.


turn on crud

Summary

What: Turn on crud v0
Why: 🚀

Checklist

[x] I merged latest trunk
[x] I manually verified the change
[x] I added labels to my PR
[x] I either asked design for a review or hid my changes behind a feature flag
[ ] I tested in multiple browsers
[ ] I added relevant unit tests
[ ] I have notified others of changes they need to make locally (migrations, jobs, package updates, etc)

Looks like dockerhub being down is breaking a bunch of the CI checks


Upgrade gradle to 8.5

Description
Autocuts seem to be failing with the following error: Could not open settings generic class cache for settings file '/tmp/tmpe5afgno0/sql/settings.gradle' (/home/ci-runner/.gradle/caches/7.6.1/scripts/9ay5uc1kgv3krvoxgzbw9z61y).

BUG! exception in phase 'semantic analysis' in source unit 'BuildScript' Unsupported class file major version 65.

Indicating incompatibility between gradle and jdk 21 - which is now being used to build opensearch 3. https://github.com/opensearch-project/opensearch-build/blob/main/manifests/3.0.0/opensearch-3.0.0.yml#L9. Confirmed this to be the case by checking compatibility page: https://docs.gradle.org/current/userguide/compatibility.html stating that Java 21 is compatible with 8.4 and 8.5. Bumping to 8.5 to be consistent with core/security plugin.
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Potentially fix: https://github.com/opensearch-project/sql/issues/1392, https://github.com/opensearch-project/sql/issues/2326

Might also be related to query workbench/dashboards observability autocuts

Merged PR with upgrade to 8.4. So closing this PR.


IE8 doesn't support hasOwnProperty on window object

IE8 doesn't support the hasOwnProperty on the window object, so this change leverages the Object prototype method to perform the same call, without the IE8 script error.

please @matthewhudson consider this PR. Applications containing devicejs cannot be load on IE8 for the moment because of this.

+1

@cosmod @JSteunou @nebrot Much love, all merged!

thank you @matthewhudson


[plugin-vue]: scoped css :global generate wrong style

Describe the bug
Vitejs plugin vue is support style scope css module modifier :global, and use :global modifier will gerenate not scope style, like this.
vite-plugin-vue: 2.2.0
<style scoped>
:global(.ee) {
  background: #000;
}
</style>

will gerenate code:
<style type="text/css">.ee {
  background: #000;
}</style>

It's ok.
But, When I use :global with scoped classname, like this:
<style scoped>
.editor :global(.d) {
  @apply !bg-transparent;
}
</style>

Will gerenate:
<style type="text/css">
.d {       //  <--------------------------------
  background: #000;
}</style>

No error or warn, but missing class .editor[data-xxx]
And, the Deep Selectors like this:

<style scoped>
.editor >>> .e {
  background: #000;
}
.editor :deep(.a) {
  background: #000;
}
</style>

Got warning [@vue/compiler-sfc] the >>> and /deep/ combinators have been deprecated. Use :deep() instead., but working, will gen:

.editor[data-v-7ba5bd90] .e {
  background: #000;
}
.editor[data-v-7ba5bd90] .a {
  background: #000;
}

Only :global will gerenate wrong code.
Reproduction
https://github.com/Innei/vite-vue-scoped-global
System Info
System:
    OS: macOS 12.2
    CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
    Memory: 169.63 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.0 - ~/.nvm/versions/node/v16.13.0/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.1.0 - ~/.nvm/versions/node/v16.13.0/bin/npm
  npmPackages:
    @vitejs/plugin-vue: ^1.9.3 => 1.10.2
    vite: ^2.6.4 => 2.8.0

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

It looks like vue was designed this way on purpose. But it's a bit against CSS Modules :global.
https://github.com/vuejs/core/blob/1574edd490bd5cc0a213bc9f48ff41a1dc43ab22/packages/compiler-sfc/src/stylePluginScoped.ts#L165-L168

please create a issue at vue with a link to here

Ok.

Closing according to https://github.com/vuejs/core/issues/5420#issuecomment-1040614604


showcase: add dsign

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

[ ] You have updated the .github/CODEOWNERS file according to your changes.
[ ] You have registered new documents to /sidebars.js if any.

Wondering if I can move the position of where it displays? Can I choose to be displayed next to a particular project like Codebase?


$type property of document not being copied from or to Cosmos

When using the tool to backup from Cosmos DB either directory to another Cosmos DB or JSON files, there are $type properties in our documents that are not being copied. We're using the IncludeMetadataFields setting in both the Source and Sink settings.
"itemType": {
"$type": "xyz123",                                  <<<<<<<<<<<<
"property1": false,
"property2": false
"value": 3,
"displayName": "ABC"
},

This is related to Issue #97


[BUG] Listen Now tab displays nothing

I have an issue today. When I click on the listen now tab it displays nothing. But when I click on the other tabs is normal. And my playlist are disappear. I use acrylic theme and acrylic transparency. I attach the screenshot down below.

Performing a clean installation should resolve this.


Start using "embed" module for static assets

See https://github.com/openshift/csi-driver-shared-resource-operator/pull/19#issuecomment-960938724
and for reference https://github.com/openshift/aws-ebs-csi-driver-operator/pull/131

/remove-lifecycle stale


Calculation improvement

Increased memory buffer
Changed default step to 1m15s (1.25m)
Fixed duration and step formatting in queries

Just tested this and found it odd that all my deployments had recommendation of 100m CPU request, even those that consumed almost no CPU in the past (for instance, config-reloader).

@fcecagno I think this is because we set the minimal recommendation to 100m for CPU (previously it was 5m I think). @Avi-Robusta Don't you think that we should make it less?


Relative path to js in index.html inside downloadable template zips breaks the page!

Changing
 <script src="../../dist/js/materialize.js"></script>

to
<script src="js/materialize.js"></script>

fixes this issue.
As they are zips, I am forced to post this instead of a pull request as
any fix will break the online demo in your website!

Fixed in 0e8955b

Hello!
New message, please read http://mega-data.biz/law.php?cpyfv
<EMAIL_ADDRESS>


Extract some fixtures methods to the new FixturesLoader class

Can be merged to upstream.

Can be submitted to upstream.


[FLINK-36240][runtime/metrics] Fix incorrect Ports display in the PrometheusReporter constructor in case of the httpServer creation failure

What is the purpose of the change

Fixes incorrect Ports display in the PrometheusReporter constructor in case of the httpServer creation failure. Instead of printing the port numbers, the error message currently displays an Iterator object reference, which is not useful for debugging.

Brief change log

Collected the port numbers into a list (attemptedPorts) while attempting to create the HTTP server, and used this list in the error message if server creation fails. This ensures that the actual ports are printed in the exception message instead of the Iterator reference.

Verifying this change

Extends the existing cannotStartTwoReportersOnSamePort test by checking the exception message thrown to verify that the log message contains the actual ports and not the object reference.
Examples

before: Could not start PrometheusReporter HTTP server on any configured port. Ports: org.apache.flink.util.UnionIterator@67065fd3
after: Could not start PrometheusReporter HTTP server on any configured port. Ports: [9000, 9001, 9002, ...]

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

TBD
I have also considered changing the constructor parameter from Iterable<Integer> to List<Integer>, as it would provide a more straightforward way to manage the port numbers. This change would require minor adjustments in the codebase, namely modifying the PrometheusReporterFactory and some test cases, which currently use Iterable<Integer> and would need conversion to List<Integer>. I’d like to discuss if this change is worthwhile, as it could improve code clarity but requires slightly more effort.
Alternatively, converting the Iterable<Integer> to a List<Integer> at the beginning of the constructor, and then attempting to create the HTTP server using this list, could also be a solution. In my opinion, this would make the code a bit cleaner and easier to read. However, it would require iterating over the ports twice: once when converting the Iterable to a list, and again during the actual HTTP server initialization. While this extra iteration may have a small impact on performance, I don't think it would be significant enough to cause issues.
Questions for Discussion:

Is it worth refactoring the constructor to use List<Integer> instead of Iterable<Integer>, considering the minor adjustments required across the codebase?
Would the conversion from Iterable to List in the constructor be a good trade-off for improved readability, even if it introduces a second iteration?
Does the current implementation fit well as-is, or could these refinements be valuable improvements?

One other alternative would be to initialize a PortRange in the factory and pass that object in the PrometheusReporter ctor. PortRange stores the original original string config, and is converted into that in case of toString() so it will display the ports correctly. This way we do not need to care about converting to a list at all, simply getting the iterator through the PortRange, which was my original intent when I wrote that util. :)
A con of this approach might be the usage of a fairly specific class instead of a common interface in the PrometheusReporter ctor, but since that ctor is not meant to use and should be instantiated by the factory IMO it does not really matter.
WDYT?

Using the PortRange as a domain wrapper for the ports seems like a good choice. The question is whether adding the extra dependency to the flink-metrics-prometheus module for the single class is worth it (IMO it makes the code more intuitive to read). If so, then I would go for it.

Using the PortRange as a domain wrapper for the ports seems like a good choice. The question is whether adding the extra dependency to the flink-metrics-prometheus module for the single class is worth it (IMO it makes the code more intuitive to read). If so, then I would go for it.

You make a good paint here, did not check the code in the morning, I thought PortRange lives in the same module as NetUtils, but it seems I put it into flink-runtime as I added the improvement in that module back in the day.
PortRange is  general utility class that makes the NetUtils#getPortRangeFromString a bit more user-friendly so I think it makes sense to move them into the same module.
@gaborgsomogyi if you have some time, I would appreciate your opinion on this. If agreed, I'll open another ticket about the utility move.

PortRange is general utility class that makes the NetUtils#getPortRangeFromString a bit more user-friendly so I think it makes sense to move them into the same module.

Strongly agree, if the ticket would be created and you have something more urgent to do, I will volunteer to do it as well.

PortRange is general utility class that makes the NetUtils#getPortRangeFromString a bit more user-friendly so I think it makes sense to move them into the same module.

Strongly agree, if the ticket would be created and you have something more urgent to do, I will volunteer to do it as well.

Thank you, if we go into that route, I will create the ticket, and assign it to you! I think it can be solved in this one pull-request, just create 2 separate commits for the 2 change, and we can "rebase and merge".

cc @mateczagany

I have looked into the PortRange class and I think using that would solve the problem this JIRA is trying to tackle. I like the solution, so just to confirm we would have 2 commits:

Move PortRange class from flink-runtime to flink-core module, so no additional dependencies required for flink-metrics-prometheus.
Change constructor of PrometheusReporter to require a single parameter of PortRange.

Yep, exactly what you described.

Created FLINK-36316 to track the util move, @eon2208 feel free to proceed with the changes and force-push this PR with the 2 separate commits.

@ferenc-csaky Done!

Logic LGTM, lets wait for the CI run, will approve when it is successful.

FYI: compile failed because of code style, make sure to run mvn spotless:apply to format your code.

Thanks for the reminder.I changed one thing after the spotless apply and auroformatting made a mess of it (Have seen the docs on setting up the IDE and will do it later).I have double checked it now and am pushed properly formatted code.


CTRL+CLICK to jump to documentation is not working under certain conditions

Godot version
3.4.2 stable
System information
Windows 10, GLES3,  NVIDIA Quadro P2000
Issue description
Ctrl + click on a built-in method name should display its script documentation, right? But I found that for some methods and under certain conditions, it doesn't show up. For example:
if OS.get_ticks_msec() % 5 == 0:
	print_debug("test")

In this code, if you Ctrl + Click OS.get_ticks_msec(), it doesn't display the documentation. But if you write like
var foo = OS.get_ticks_msec()
and do the same action, it does work. The former code itself completely works and doesn't show any error, so basically the only problem is the inexplicable missing link to documentation. The same issue also occurs in some other codes, such as:
if OS.get_audio_driver_count() > 1:
	pass

At first I thought the if block is the cause, but then I found out that some methods in if-statement have no problems with showing documentation by ctrl+click. For instance, the code below jumps to SceneTree documentation with ease.
if get_tree().get_node_count() > 5:
	print("test")

I haven't tried on many codes, so maybe it only happens with OS., or maybe not. In any case, I think it would be good to fix.
Steps to reproduce
The fastest way I guess is to write a script like this
extends Node

# Called when the node enters the scene tree for the first time.
func _ready() -> void:
	if get_tree().get_node_count() > 0:
		print("code works, link to documentation works")
	if OS.get_audio_driver_count() > 0:
		print("code works, link to documentation doesn't work")
	pass

And try to Ctrl + Click on get_node_count() and get_audio_driver_count() to check if it jumps to documentation.
Minimal reproduction project
No response

Duplicate of #26114
This is resolved in 4.0


isDraggable param not working when taking it's value from input

It would be great to have switcher that would activate dragging of blocks on users' demand

You mean per item, or the whole grid?

The whole grid


BottomNavigationBar backgroundColor not working with BottomNavigationBarType.shifting

Issue Description
When using BottomNavigationBar with BottomNavigationBarType.shifting, setting the backgroundColor property of the widget does not have any effect on the background color of the widget. It only works when using BottomNavigationBarType.fixed. This behavior is unexpected and inconsistent with other widgets in Flutter.
Steps to Reproduce

Create a BottomNavigationBar widget with BottomNavigationBarType.shifting.
Set the backgroundColor property to any color.
Observe that the background color of the widget does not change.

Expected Results
The backgroundColor property should work consistently regardless of the BottomNavigationBarType used.
Actual Results
The backgroundColor property only works with BottomNavigationBarType.fixed.
Environment
BottomNavigationBar(
    backgroundColor: Colors.blue,
    type: BottomNavigationBarType.shifting,
    showSelectedLabels: false,
    showUnselectedLabels: false,
    iconSize: 30,
    elevation: 0,
    items: [
        BottomNavigationBarItem(
            icon: const Icon(Icons.home_outlined),
            label: context.localizations.navigation_bar_home,
        ),
        BottomNavigationBarItem(
            icon: const Icon(Icons.bar_chart_outlined),
            label: context.localizations.navigation_bar_statistics,
        ),
        BottomNavigationBarItem(
            icon: const Icon(Icons.insert_drive_file_outlined),
            label: context.localizations.navigation_bar_library,
        ),
        BottomNavigationBarItem(
            icon: const Icon(Icons.settings),
            label: context.localizations.navigation_bar_settings,
        ),
    ],
)

[√] Flutter (Channel stable, 3.7.0, on Microsoft Windows [Version 10.0.22621.1413], locale en-US)
    • Flutter version 3.7.0 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision b06b8b2710 (9 weeks ago), 2023-01-23 16:55:55 -0800
    • Engine revision b24591ed32
    • Dart version 2.19.0
    • DevTools version 2.20.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc2)
    • Android SDK at C:\Users\tareq\AppData\Local\Android\Sdk
    • Platform android-33, build-tools 33.0.0-rc2
    • Java binary at: C:\Program Files\Android\Android Studio1\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin

video with the problem
https://www.youtube.com/watch?v=yIsOsX-UeT8

Hi @tareqAbuNasser, see https://github.com/flutter/flutter/issues/117991#issuecomment-1373538680 for why this happens.
In shifting mode, the backgroundColor is taken from the individual items.
You can also find this in the documentation https://api.flutter.dev/flutter/material/BottomNavigationBar-class.html
Closing as this is working as documented.
Thank you


[CORE-3525] Add support for java.sql.Types.TIMESTAMP_WITH_TIMEZONE.

Liquibase does not currently support the java.sql.Types.TIMESTAMP_WITH_TIMEZONE type. For example, using java.sql.Types.TIMESTAMP_WITH_TIMEZONE as the column type in Liquibase generates a column with the TIMESTAMP WITHOUT TIME ZONE type in PostgreSQL.
Add support for the java.sql.Types.TIMESTAMP_WITH_TIMEZONE type to Liquibase so the correct SQL is generated for databases supporting timestamps with timezones.
Repo Steps

Create a createTable changeSet with a column having type="java.sql.Types.TIMESTAMP_WITH_TIMEZONE"
Run changeSet against postgresql or another database that supports timestamp with timezone types
Check that the table was created as timestamp with timezone information

QA Manual Test Requirements

Execute the steps as described in repro and assert the correct dataype is created on the database.

QA Automated Test Requirements

Write a Postgres regression test following the repro steps.

┆Issue is synchronized with this Jira Story by Unito
┆Fix Versions: Liquibase 3.10.2

I was going to change the base to master vs. 3.8.x because this is a large enough change that it will need to go in a major release, not a patch release. But, there were a lot of conflicts because I've not gotten 3.8.x merged back to master for a while so I changed the base back for now.
I added the "part of a larger change" label because there is a bigger piece we are looking at around improving data type support and how we can test and manage new datatypes across all our supported databases. We'll want to make sure we're considering that when we merge this in.

RiskHigh since the change looks big and may have issues to sort through, attempting to get this into 3.10.1

This change itself is small and low-risk and fits with the current design. @suilven is right that the change is just fixing up our support for specifying type="java.sql.Types.TIMESTAMP_WITH_TIMEZONE" like you can specify type="java.sql.Types.INTEGER" instead of the sql version of the type. That is a type we should try to handle.
This fix may not be handling all the timezone specifics that all the different databases support, but it's improving what's there anyway and this is just a convenience/alternative to specifying type="TIMESTAMP WITH TIMEZONE" or whatever. This change doesn't affect any other ways people can specify their types.
@katzyn is right that the overall design/split between generic timestamp types and timezoned timestamps need to be better modeled in liquibase, and that is something we are planning on addressing. But, no reason to block this PR until that larger problem gets addressed.

I merged this into a LB-34 branch for easier local testing


Transcode 1ton

@uartie , @FocusLuo and @wangzj0601  - could you please review this patch

please rebase

Also, don't forget to remove gen_transcode_1to1_xxx methods... I don't think they're used anymore.

Also, don't forget to remove gen_transcode_1to1_xxx methods... I don't think they're used anymore.

Did you miss this comment?

Also, don't forget to remove gen_transcode_1to1_xxx methods... I don't think they're used anymore.

Did you miss this comment?
sorry, forgotten to reply no more transcode_1to1 methods in code

Also, don't forget to remove gen_transcode_1to1_xxx methods... I don't think they're used anymore.

Did you miss this comment?
sorry, forgotten to reply no more transcode_1to1 methods in code

They need to be removed from lib/parameters.py.

Also, don't forget to remove gen_transcode_1to1_xxx methods... I don't think they're used anymore.

Did you miss this comment?
sorry, forgotten to reply no more transcode_1to1 methods in code

They need to be removed from lib/parameters.py.

thanks, fixed now (missed to grep in lib folder)

Also, don't forget to remove gen_transcode_1to1_xxx methods... I don't think they're used anymore.

Did you miss this comment?
sorry, forgotten to reply no more transcode_1to1 methods in code

They need to be removed from lib/parameters.py.

thanks, fixed now (missed to grep in lib folder)

Please don't remove them until the last patch in your series (i.e. when the last usage of them was eradicated)

Also, don't forget to remove gen_transcode_1to1_xxx methods... I don't think they're used anymore.

Did you miss this comment?
sorry, forgotten to reply no more transcode_1to1 methods in code

They need to be removed from lib/parameters.py.

thanks, fixed now (missed to grep in lib folder)

Please don't remove them until the last patch in your series (i.e. when the last usage of them was eradicated)

thanks, merged the change to last commit instead of first patch


NISQ Analyzer: pytket service for t|ket> compiler (size: big)

Implement service to use t|ket> compiler aka pytket (such as qiskit-service) and implement connector for NISQ Analyzer
Acceptance Criteria

implement pytket service
implement connector in nisq-analyzer

Done


Show GitHub projects on new About tab

Adds content to the Home Screen
Adds an "About" screen that lists open source projects

Before
After
New About

https://github.com/user-attachments/assets/a25544b9-fab4-4c17-9e97-b399b2621a3c
Note: this loads projects from an app hosted on my Vercel account. Todo, move to thoughtbot-owned.

I chatted with Diego at the end of his day. Since his blog post announcing Belt will go out tomorrow, I will go ahead and merge this and cut a build, so we have these updates in place.


Teach git that gradlew ought to have crlf lineendings

This makes it easier to work with this file on systems where the native
line ending isn't CRLF.

Can you describe the use case we are trying to solve here exactly? It would also only be relevant to developers or contributors working on the Gradle core code base.

This will cause 'git clone' of gradle on machines with autocrlf=input or some other git configurations, to have the correct line endings for *.bat files.
Without this "git status" shows a difference to this file as it will get converted to LF line endings.

I am assuming you are exclusively referring to gradlew.bat here? Let make the rule specific if that's the case.

Modified the PR.

Thanks for the pull request. It has been merged.

We had reports from users on other OSes than Windows that noticed unexpected side-effects. Therefore, we decided to revert the change.


cargo espflash behaves differently to espflash when trying to flash bins > 1MB

We promoting the usage of cargo espflash for simple and easy testing of --examples in a repository. Unfortunately when one of the examples is bigger than 1MB than cargo espflash wont be able to flash it. For example the usage of cargo espflash flash --target riscv32imc-esp-espidf --example wifi --monitor inside esp-idf-svc.
The error that is reported  is as follows
Error: espflash::image_too_big (link)

  × Supplied ELF image of 1802560B is too big, and doesn't fit configured app partition of 1048576B
  help: Reduce the size of the binary or increase the size of the app partition.

espflash is able the handle that issue and autoincrease the app partition itself. I think it would make sense if cargo espflash behave the same.

cargo-espflash uses the partition-table generated from ESP-IDF project built, while espflash generates a partition table using esp-idf-part and uses it. If you add the partition table arg to espflash and point to the esp-idf generated one, the result should be the same.

I think we shouldn't do anything here. I don't think we want to stop the default behaviour of using the bootloader from esp-idf-sys, therefore I think you should add a partitions.csv with a bigger default partition to run your examples.
Feel free to reopen if you have a better suggestion :).

I am fine with it, it was just a bit anoying that with cargo espflash you get a new option -> automatically getting the esp-idf-sys build partition.csv , but you cant get the feature for auto-resizing, the only alternative is that you have to manually specify the partition.csv.
On that note, i now would use the espflash.toml to setup the configuration in idf-hal/svc to workaround the issue. You talked about removing the .toml and unify the places for settings?

On that note, i now would use the espflash.toml to setup the configuration in esp-idf-hal/svc to workaround the issue. You were talking about removing the .toml and unify the places for settings?

Not sure what you mean by removing the .toml, but we only support espflash.toml settings now (locals or global), that means that, when using cargo-espflash, you can't specify settings in the package metadata anymore.