improve indexed colormaps

We've been doing great with gradient colormaps, but I'd like more options for customizing/accessing indexed palette colormaps. For example I'm working on a Mel scaled spectrogram (https://github.com/swharden/Spectrogram/issues/14), but it's not super easy for me to change the default colors of the triangles.

This is the whole colors module, and I think we can do better by taking inspiration from the recent colormap improvements.
https://github.com/swharden/ScottPlot/blob/6d585f5c174c3218099b8ed2ed7400f24cb002d6/src/ScottPlot/Config/Colors.cs#L8-L30
I don't think we should add palette colors to the Colormap module, instead we should have a ColorSets module. This may require some thinking/experimenting to design well...

... regarding licensing, this may take some reconsideration. The original default color palette was a clone of matplotlib
https://matplotlib.org/3.1.1/users/dflt_style_changes.html#colors-color-cycles-and-color-maps
and they say The colors in the default property cycle have been changed to the category10 color palette used by Vega and d3 originally developed at Tableau.
It looks like that website is http://tableau.com/about/blog/2016/7/colors-upgrade-tableau-10-56782
There's no mention on this page about a license, and they show the colormap right there on the screen. I'm guessing you can just use a color selector tool and get the hex codes.
J3 has this colorset with hex colors on the page... this is probably where I sourced the original hex values.
https://github.com/d3/d3-3.x-api-reference/blob/master/Ordinal-Scales.md#category10
OMG what a rabbit hole. Tracked down the issue related to the original PR and it looks like there may be a sticking point. I posted a question and we'll see what happens...
https://github.com/d3/d3-scale-chromatic/pull/16

This is coming along nicely, and looking pretty cool
Current Default Colorset

New Colorsets

The module is now in place and in use. More color sets would be useful, but they can be added any time in the future.


Dolly 15k instruction finetuning dataset

Implementing the Dolly dataset, which is urgently needed for the NeurIPS competition (none of our current datasets is supported atm).
Seems to work fine and looks good to me, but I need to run an additional finetuning test (GPUs are currently busy due to QLoRA experiments)
Fixes #394

Thanks @carmocca . I incorporated your two suggestions.

changing the test size to 10%
specifying utf-8 encoding

In addition, I added an optional --max_seq_length argument which is useful when training on single GPU regarding memory limitations. Otherwise, most people won't be able to use it.  By default it uses the max supported sequence length from the model config like alpaca.


WFLY-10426 (WF14) Drop use of JpaAttachments#TRANSACTION_MANAGER + #TSR (also remove some unused parameters)

https://issues.jboss.org/browse/WFLY-10426
This is for WildFly 14.

@scottmarlow the failures seem consistent, adding the fixme label.

I'm verifying a fix locally, needed to add the WildFly Transaction Client module dependency to the weld jpa module.

retest this please

@kabir the failures are fixed, thanks!

two org.jboss.as.test.clustering.cluster.singleton failures on linux - elytron, doesn't seem related to this pr.


Allow testnet mode

I'd love for LoafWallet to have an option for testnet mode when setting up the wallet, similar to Copay. There are no LTC testnet wallets on iOS, which makes developing in the ecosystem difficult when you have to rely on Electrum and other desktop clients.

Internally LoafWallet does support testnet mode for developers. If you open
the project in Xcode, there are testnet build targets available. Developers
are suggested to use this.
I feel that adding UI internally increases code complexity unnecessarily &
makes UI more confusing to regular users.
On Fri, 17 May 2019 at 14:38, Aleksander<EMAIL_ADDRESS>wrote:

I'd love for LoafWallet to have an option for testnet mode when setting up
the wallet, similar to Copay. There are no LTC testnet wallets on iOS,
which makes developing in the ecosystem difficult when you have to rely on
Electrum and other desktop clients.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/litecoin-foundation/loafwallet-ios/issues/71?email_source=notifications&email_token=AAT43OVET5XKOCMB5OM3PGTPV2YNXA5CNFSM4HNVLQUKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GUM7Q4A,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAT43OSOLK3QI4FT7PQH4ETPV2YNXANCNFSM4HNVLQUA
.

Internally LoafWallet does support testnet mode for developers. If you open the project in Xcode, there are testnet build targets available. Developers are suggested to use this. I feel that adding UI internally increases code complexity unnecessarily & makes UI more confusing to regular users.

More than just developers use testnet mode - early adopters of crypto software as well are among them, but we are forced to rely on BTC and BCH which are provided in a very clean way through Copay.
As an example it could be an option in the settings menu when resetting your wallet, that way casual users are automatically directed to mainnet as they are now, but power users can go in and create a testnet wallet if they wish.

Hi @alekplay I just picked up technical lead for all Loafwallet and BRCore does need to be updated to allow tLTC for the Loafwallet.  I agree it is needed and it is in the horizon.
This was apparent when initial talks with our partners who are using tLTC for the dev and staging environments.  Look for movement in <2 months.

@alekplay  the update is imminent but there are other issues being focused on first.  If you want to try, pull the loafwallet-ios Xcode project, run cocoapods and  using the Testnet scheme and commenting out lines 123 - 125 of BRAPIClient.swift will give you a running project.  The problem is produces tBTC not  tLTC.
The fix is to fork loafwallet-core (https://github.com/litecoin-foundation/loafwallet-core) to refactor tBTC components....
It's on my plate but you are welcome to take a crack at it first.


Minor fixes in cli

restructured match block to not load bin when not required (at main.rs)
removed an unnecessary line? although it might have been there readability (at logging.rs)
there was difference in pattern of if block at same kind of code, so changed it all to if let pattern (at serve.rs)

If these are ok changes, then I may make more in this same PR?

There is no init option on dx should I create one?

There is no init option on dx should I create one?

That would be nice!


Update Google doc URL

The previous one references code.google which is several years obsolete.

ah thanks.
the correct url is this one:
https://developers.google.com/maps/web-services/
you used the client javascript one, whereas this is a server side library

published as npm<EMAIL_ADDRESS>


feat(context-menu): remove open preview option

Fix #117

:tada: This PR is included in version 1.20.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Empty mask patch

In aamod_mask_fromsegment, when masking results in empty image, throw an error

@dprice80, @jooh can correct me, but I think you should perhaps merge the main branch so that your PR can be updated...

Yes, you are right. I think I made a mistake there. I thought I had merged already.

I'm a bit confused. When I compare with my main branch (which is up to date with Rhodri's) it seems the only difference is the change to the patch (the intended change). https://github.com/dprice80/automaticanalysis/compare/v5-devel...dprice80:dprice80-emptymask-patch?expand=1
Same if I compare to Rhodri's main https://github.com/rhodricusack/automaticanalysis/compare/master...dprice80:dprice80-emptymask-patch?expand=1

Maybe @jooh can enlighten us. :)

It's okay. I've just closed this one and reopened it using the up-to-date branch. There is probably a way to update the PR, but I don't have time to figure out right now.


Enabling the GPU plugin freezes the game and doesn't load at all

Describe the bug
As soon as i enable the plugin it freezes, even before i login into rs.
To Reproduce
Steps to reproduce the behavior:
I have a  NVIDIA GTX 1080 and an i5-8600k CPU am running windows 10. My client also has hard ware acceleration off with the line --mode=OFF on startup due to artifacting with the side bar I tried it without this line of code and it still doesn't work.
Expected behavior
Freezes once enabled
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
windows 10

RuneLite version: [1.5.0]
Launcher version: [1.6.0]

Can confirm, same issue here running the lastest version of RuneLite on a GeForce 940M and i5 6200U with Windows 10. Fresh install of RuneLite, no settings changed from default and the problem persists.

Make sure your graphics drivers are up to date. You can find more information for possible fixed and requirements at https://github.com/runelite/runelite/wiki/GPU-FAQ

Thank you, compatibility options were the problem, after turning those off it runs perfectly (Graphical issues as a separate bug aside).10-20fps increase on integrated graphics, pretty nice

I found what the problem was, i reinstalled runelite using the "all platforms" version and it worked fine, i use a bat file to remove acceleration since it is a .jar file and everything is working as it should


[Bug]: Agent; Groq API connection error

Describe the Bug
Currently we are having problems with tests running agents using Groq on the workflow.

They keep giving a connection error in the workflow,
locally they seem to be working correctly :

(this test was taken on Ubuntu 22.04 Linux PC)
Steps to Reproduce

Run the test in a Workflow run

Software Version
Latest (Nightly Build)
Python Version
Python 3.10
Environment Details
No response
Relevant Logs or Error Output
FAILED pkgs/swarmauri/tests/integration/agents/RagAgent_i9n_test.py::test_agent_exec - groq.APIConnectionError: Connection error.
FAILED pkgs/swarmauri/tests/unit/agents/QAAgent_unit_test.py::test_agent_exec - groq.APIConnectionError: Connection error.
FAILED pkgs/swarmauri/tests/unit/agents/SimpleConversationAgent_unit_test.py::test_agent_exec - groq.APIConnectionError: Connection error.
FAILED pkgs/swarmauri/tests/unit/agents/ToolAgent_unit_test.py::test_agent_exec - groq.APIConnectionError: Connection error.

Additional Context (Optional)
You can share any progress on this issue, by commenting :),
thank you!
Confirmation

[X] I have searched the existing issues for this bug.
[X] I have provided all necessary information to reproduce the bug.

i had to ensure the environment variables are loaded using dotenv  module


Failure to download image from Digikey

I have recently setup inventree and found this very helpful tool.  Been playing with it today and all is working great, except downloading of images from digikey.  I see the following error, but on inspection I see that it's failing to download the image.  It's getting a 403 error code.  I have downloaded the image from a browser with no issues.  I thought maybe I had some cached authentication in the browser cache.  So I tried a browser that I've not used to log into digikey and it also downloaded just fine.  So a bit puzzled why the script would fail with a 403.
Trying URL https://mm.digikey.com/Volume0/opasdata/d220001/medias/images/5565/MFG_PI_5_HERO.jpg
<Response [403]>
ERROR: Request code is 403
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File<EMAIL_ADDRESS>line 87, in _run_code
    exec(code, run_globals)
  File "/Users/bpayne/wip/inventory/Digikey-Inventree-Integration/inventree_digikey/__main__.py", line 23, in <module>
    add_digikey_part(dkpart)
  File "/Users/bpayne/wip/inventory/Digikey-Inventree-Integration/inventree_digikey/Inventree.py", line 27, in add_digikey_part
    inv_part = create_inventree_part(dkpart)
  File "/Users/bpayne/wip/inventory/Digikey-Inventree-Integration/inventree_digikey/Inventree.py", line 81, in create_inventree_part
    upload_picture(dkpart, part)
  File "/Users/bpayne/wip/inventory/Digikey-Inventree-Integration/inventree_digikey/Inventree.py", line 121, in upload_picture
    invPart.uploadImage(img_file)
  File "/Users/bpayne/wip/inventory/venv/lib/python3.9/site-packages/inventree/base.py", line 543, in uploadImage
    raise TypeError(f"uploadImage called with invalid image: '{image}'")
TypeError: uploadImage called with invalid image: '-1'

I suspect this has something to do with digikeys CDN provider Akamai and their validation of a "real" browsers.  I get this error with a python test program that just uses requests, I also get this error with curl.  Interesting I don't get this error with wget, or a real browser.  I'm guessing were just missing some headers in the request.  But haven't found the right ones yet...

Here's an interesting thread about others having issues with Akamai servers an another http library.
https://github.com/aio-libs/aiohttp/issues/5643

Interestingly I've found that using http.client library directly does work fine.  The code is a little more complex (but not too much).  But it doesn't seem to create an error, at least in my test code.  I'm importing this into the code and will test it a bit.  If it look good I'll send a pull request.

I've create a pull request with the changes to use http.client.


Facebook OAuth redirect URI fixed

The redirect URI that AAD B2C uses doesn't match what the instructions indicate.

#sign-off


Fix typos in RELEASE.md and account.md documentation

Description
Corrected minor spelling errors in documentation files. These changes improve the clarity and accuracy of the content.
Other changes

Fixed the typo in the RELEASE.md file: corrected "significant" to the correct spelling.
Fixed the typo in the docs/command-line-interface/account.md file: corrected "beneficary" to "beneficiary".

PR-Codex overview
This PR focuses on fixing typographical errors in the documentation files RELEASE.md and docs/command-line-interface/account.md.
Detailed summary

Corrected "signicant" to "significant" in RELEASE.md.
Fixed "benficiary" to "beneficiary" in the description of celocli account:delete-payment-delegation in docs/command-line-interface/account.md.
Corrected "Addess" to "Address" in the flags section of docs/command-line-interface/account.md.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Hi @aaronmgdr !
I reviewed the repository and performed a thorough search for the word "beneficary," but I didn’t find any instances of this typo in the code or documentation. Please let me know if there's anything else I should check.

oh you need to search for the misspelling benficiary

@aaronmgdr Fixed

i had to re open here https://github.com/celo-org/developer-tooling/pull/440
we have a ci steps which gets a specific version of foundry and something about the permissions dont work on forks right now

@cypherpepe oh I didnt realize you would be penalized for me closing the pr. Ill try to work with dev rel to repeal that strike

Hi @aaronmgdr thank you for flagging this to me. I'll reach out to the Scout Game. This repository should not have been added to the game. Will sort it out.


Improve skip pattern

Skip pattern should include all static files and common health endpoints used in spring.

Should we have a single pattern across all places that uses a skip pattern? In other words, should I change the Servlet repository to use the skip pattern you'll use here ?

IIRC servlet instrumentation does not use any default value for skip pattern.
The default value in this repo will probably include spring specific patterns (e.g. spring actuator).


redirects are causing capybara-webkit to hang

Everything works fine with Selenium ff, but with webkit the tests run successfully, and then it hangs.  You then have to hit ctrl-c twice.
Latest capybara-webkit, qt etc.
    it 'redirects an existing logged in user to the dashboard' do
      user = FactoryGirl.create :user
      login(user, then_visit: "/")
      # normally we would do a find at this point, but to simplify I am just doing a sleep.
      sleep(10) # if this line is removed the test will fail because dashboard
      # is not loaded.  But the rspec will terminate.   If this line is executed, and the delay
      # is long enough to allow the page to load, then the test will "pass" but rspec will
      # not terminate.
      expect(page.current_path).to eq "/account/#{user.id}/dashboard"
    end

Here are two logs:  The first is when there is a 10 second delay, long enough for the page to load.  The second is when there is a 1 second delay, and the page does not load (so the test fails, but rspec exits)
https://gist.github.com/catmando/81dafb5212e8163389bd
https://gist.github.com/catmando/264accacf25e98bcb179

Can you include the versions you're using for Capybara? You can find this by running puts page.driver.version.
From the hanging log, it looks as though the webkit server processes all of its commands fully, including the reset command at the end of the spec.
If you hit ctrl-c once and wait long enough, does it exist with a backtrace?
From the current logs, it's not clear where it's waiting.

Here is a clue (hopefully)
I made it so you could visit the "/account/#id/dashboard" page without logging in (just in test :-) and now it works...
So it seems have something to do with going the session page, logging in and then redirecting?
here is the code for "login"
  def login(user, opts = {})
    visit "/session/new#{'?return_to='+opts[:then_visit] if opts[:then_visit]}"
    fill_in "user_session[login]", with: user.login
    fill_in "user_session[password]", with: user.password
    click_button "mobile_login_submit"
  end

It never exits after 1 ctrl-c... you have to hit it twice

this is with Capybara: 2.5.0 (via the puts statement as you suggested)

What were the other versions?

capybara 2.5.0

what other versions?  Not following you

When you run puts page.driver.version, you should see a list of version numbers. For example, mine looks like this:
Capybara: 2.5.0
capybara-webkit: 1.7.1
Qt: 5.5.1
WebKit: 538.1
QtWebKit: 5.5.1

sorry... version: Capybara: 2.5.0
capybara-webkit: 1.7.1
Qt: 5.5.0
WebKit: 538.1
QtWebKit: 5.5.0

@jferris - thanks for looking at this with me... What I have just discovered is that if I change my login method from:
  def login(user, opts = {})
    visit "/session/new#{'?return_to='+opts[:then_visit] if opts[:then_visit]}"
    fill_in "user_session[login]", with: user.login
    fill_in "user_session[password]", with: user.password
    click_button "mobile_login_submit"
  end

to
  def login(user, opts = {})
    visit "/session/new"
    fill_in "user_session[login]", with: user.login
    fill_in "user_session[password]", with: user.password
    click_button "mobile_login_submit"
    sleep(10)
    visit opts[:then_visit] if opts[:then_visit]
  end

things seem to work fine
I wonder if by immediately doing a "visit" right after the login, it was confusing things?

Okay, thanks. I don't know of any issues with those releases.
Doing consecutive visits shouldn't confuse things, but there's a lot of asynchronous behavior in the driver, so sometimes we find bugs with rapid fire requests. Generally, it tries to wait until requests are finished when doing things like clicking buttons, but JavaScript events sometimes load new pages in ways that are difficult to detect.
One thing that may reliable fix the issue is looking for something on the next page before trying to visit another. For example:
click_button "mobile_login_submit"

expect(page).to have_content("You are now logged in.")

visit next_url

Interestingly enough just adding a sleep(10) to the end of the original method did not work.  So it does seem some how related to the controller redirecting (instead of the test case)

And after some more experiments it seems that any of our pages that do redirects cause the problem...huh

That's pretty odd. We have many examples of capybara-webkit following redirects successfully, so it must be something more specific.
Do you have a smaller example log where directly visiting a controller that redirects causes the tests to hang? The current example logs have a large number of errors and warnings which obscure what may actually be happening.

yes I will whittle it down to a minimal example.
I turns out its not a redirect, but just javascript updating window.location.href.

I may be hitting the same issue using Turbolinks...

We're having the same issue when trying to test logging in against an oauth provider
Capybara: 2.6.2
capybara-webkit: 1.9.0
Qt: 5.5.1
WebKit: 538.1
QtWebKit: 5.5.1

Just an update on this (@scong you may be interested)
I got everything to work nicely be implementing a wait_for_ajax method, that we use whenever there are pending ajax requests.  I found this hint here:
https://spin.atomicobject.com/2012/04/27/intermittent-test-failures/

I believe I have run into this issue as well.   I have to ctrl+c twice.  When I run the full suite, it will hang part of the way through, once it finishes the file with the offending tests.  The offending tests contain a visit to a page that has some interesting redirects going on.  I don't know all the inner workings of the redirects, but I have narrowed down the test behavior that causes the issue for me:
scenario 'test passes and doesn't hang' do
  # general setup
  using_session :viewer do
    visit page_with_redirect
    expect(page).to have_text 'test'
  end
end

scenario 'test passes, but hangs afterward' do
  # general setup
  using_session :viewer do
    visit page_with_redirect
    expect(page).to have_text 'test'
    visit page_with_redirect
    expect(page).to have_text 'other text'
  end
end

Fortunately, I have found I can workaround the hanging issue by inserting a Capybara.reset_session! between visits.

@zacharyjt What type of redirects are being done?  A self-contained reproducible example of this is really needed for it to be fixed.

@twalpole I dug into this with the engineers, and found it actually has to do with “beforeunload” on window that fires an ajax request.  We have this bit of code in a file that tracks time users spend on a page:
$(window).bind('beforeunload', function() {
    $.ajax({
      url: '/event.json',
      type: 'POST',
      dataType: 'json',
      data: { time: {}, id: 1 }
    })
} );

The issue for me occurs in the scenario I outlined above, but just replace page_with_redirect with page_with_tracking.  There are a number of additional workarounds I have found:

Insert a sleep 30 after the first visit and expect()
Empty the data key: data: {}
Do an 'unbind': page.execute_script('$(window).unbind("beforeunload");')
Make the ajax request synchronous: async: false
Make it a GET request: type: 'GET'

@zacharyjt Ok -- I can understand why your third and fourth workarounds could potentially make a difference since they stop the request completely and prevent unload from happening until the request is completed respectively.  The 2nd and fifth could just be speeding up the response to the request enough that it's done before unload actually happens (assuming the handler checks for data and does nothing when empty and a GET request isn't accepted so it quickly errors).  The first workaround doesn't really make a lot of sense though.

@zacharyjt What version QtWebkit did you build capybara-webkit with?

@twalpole Here is the debug output of a hanging test.  The test I ran was:
scenario 'test' do
  visit '/documents/1'
  expect(page).to have_text 'Blank Proposal'
  visit '/documents/1'
  expect(page).to have_text 'Blank Proposal'
end

Here are my versions:
Capybara: 2.12.1
capybara-webkit: 1.14.0
Qt: 5.5.1
WebKit: 538.1
QtWebKit: 5.5.1

Closing since no reproducible example has been provided.   If/when one is we can reopen.


Test is stuck if it calls Flutter action when native app is in foreground

More details:

let's say we have a test, in which we do something in browser
while we are in browser, we try to tap on a button on the website
though this button is a bit below the screen and sometimes the tap succeeds, though it shouldn't
bc we tapped on an invisible button, the action that this button does is not triggered
patrol thinks that the button was tapped, so it continues the test
next action after the tap is waitUntilVisible on a Patrol finder
it is called, though it never ends, probably bc it needs the flutter app to be in foreground, but the app is in background (we still see the browser on the screen)

I tried to debug this case, and it looks like the while loop here executes exactly 2 times and after that it just stops. If I brought the flutter app to foreground manually during the test, it got unstuck and failed (which is expected, bc the element that we wait for in the waitUntilVisible is not present). Debugging is hard though, bc it only happens the first time it is run in develop mode, after hot restart it doesn't get stuck and fails normally.

This seems related to #430 and

I understand that this is the crux of the problem:

next action after the tap is waitUntilVisible on a Patrol finder
it is called, though it never ends, probably bc it needs the flutter app to be in foreground, but the app is in background (we still see the browser on the screen)

waitUntilVisible calls pump, but pump will never succeed when when the Flutter app is in background.
See also somewhat related issues:

#1037
#1038


Markdown Checkbox render issues

When adding tasks the text to the markdown checkbox is rendered in a new line in the "Title" field. In the "Description" field it is correct.

Thanks for the report, @q-wertz! Can you help me understand your use case that requires putting multiple lines in the title and embedded checkboxes within a task?

Hello,
using multiple lines in a title field does not seem to make sense, you are right. But as the functionality for multiline titles is available and works for everything despite checkboxes I use it to let users select some things (e.g. the services they need access to). This shouldn't be a task as then it counts to the done/undone tasks and it will never be 100%.
In this setup I use the Description field just for a small hint that they should fill it.

I could also change it to

just wanted to let you know the issue as (despite I kind of misuse the title field) it still looks like a bug.

just wanted to let you know the issue as (despite I kind of misuse the title field) it still looks like a bug. (and it seems strange that lists which are also multiline objects are working but not the checkboxes)

Understood, and thank you for the report! Agree that modelling this in the description is probably best for your use case the way things work currently. I also agree that we should look into disabling some markdown functionality in this case, e.g. lists and checkboxes don't make sense in the header.
@hmhealey, do you know if we have the flexibility to choose what we "support" when rendering markdown?

Not at the moment. I have ideas for how to do that in my one-day-we'll-get-to-it ideas for Markdown, but the current version doesn't support that except for extra things we add like at-mentions and hashtags.


Build error with npm run deploy:m5stack on Docker environment

Describe the bug
npm run deploy:m5stack fails on the tsc phase.
To Reproduce
Steps to reproduce the behavior:

Open stack-chan/firmware with VSCode
Open devcontainer
npm run deploy:m5stack_core2
Error appears

Expected behavior
Type check succeeds.
Logs
If any compile error occurs, add a full compile log.
# tsc tsconfig.json
../extern/scservo/src/scservo.ts:53:3 - error TS2376: A 'super' call must be the first statement in the constructor when a class contains initialized properties, parameter properties, or private identifiers.

 53   constructor(option) {
      ~~~~~~~~~~~~~~~~~~~~~
 54     const onReadable = function (this: PacketHandler, bytes: number) {
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
114     this.#state = RX_STATE.SEEK
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
115   }
    ~~~

../extern/scservo/src/scservo.ts:185:9 - error TS18022: A method cannot be named with a private identifier.

185   async #sendCommand(command: Command, address: Address, ...values: number[]): Promise<number[]> {
            ~~~~~~~~~~~~

../extern/scservo/src/scservo.ts:213:9 - error TS18022: A method cannot be named with a private identifier.

213   async #lock(): Promise<unknown> {
            ~~~~~
...

OS: Ubuntu 18.04
IDE: VSCode and Docker
Stack Chan Version: latest main b35e2e48f4f8177debffa0f20ca82bf7edaf17cd
Type of M5Stack to use: Any M5Stack leads the same result

This is caused by the too-old TypeScript version that does not support (hard) private class fields.
I'm bad I wrote too new and jumped over the edge...


Nav dropdown refactor

Refactored header so DOM order is more intuitive, and menus open upon focus, and can be navigated with the arrow keys.
Also adjusted blog header CSS so outline is visible.
Test URLs:

Before: https://main--www--headwire-edge-delivery.hlx.page/
After: https://nav-dropdown-refactor--www--headwire-edge-delivery.hlx.page/

Shouldn't this arrow be pointing to the left ?


test: set initial Terraform state

#182362436
Checklist:

[ ] Have you added Draft Release Notes in docs/draft-release-notes.md?
[x] Have you followed the Conventional Commits specification?

Hi @zucchinidev - I think these changes are great, good catch on the error handling.
I merged a PR for CSB which means we don't need to do the initTFState setup explicitly in the tests, so we can remove that step, but the other changes should be merged.
I notice this is on a fork, do you not have access to create branches on the main repo?


refactor: Make extensions use the FilemoonExtractor shared lib

Checklist:

[x] Hates the antichrist

Is this posible in android? I don't even Know what Iam asking hehe
Because I dont have idea what is myStream, streamSB, Birdstream, Filemoon...

Haha, nothing man!  The think is that I want to learn and understand what is Github and know more about aniyomi extentions and how the aplication works.
I dont know what yo do exactly. But I know that you are important person in the creation of aniyomi.
I really love the content in hindi, thank you so much.
Lastly I want to know what is all this code (I dont know nothing of programing) I want to learn it to modify aniyomi :) (I don't know if its posible).
Sorry for the text, Honestly I want to thank you and all the persons worked in this😊😶

@maxninety If you want to learn more about how extensions work, read the contributing guide. If you have any further questions, please ask them in the discord, because this isn't the correct place for such discussions.


Fix submodule mirror repository remote using main repo URL

Followup to https://github.com/buildkite/agent/pull/1959.
Upon updating to 3.44, we started seeing the new submodule mirror directories having their origin remote set to the URL of the pipeline's repo instead of the submodule's repo. This is causing a double git fetch of the main repo to happen, once when checking out the commit to build and once when updating submodules.
We also don't want to be running any fetches in the submodule mirror repo since the only branch or PR information the agent has is for the main repo, and those fetches would most likely fail in the submodule mirror.
Reproed in https://github.com/francoiscampbell/buildkite-submodule-test:
# Acquiring mirror repository update lock
--
  | # Using flock-file-locks experiment 🧪
  | $ git --git-dir /nvme/reference_repos/https---github-com-apache-incubator-airflow-git rev-parse 1e54b01ba9676cf74089a2c50e30495e2c16c0e2^{commit}
  | fatal: ambiguous argument '1e54b01ba9676cf74089a2c50e30495e2c16c0e2^{commit}': unknown revision or path not in the working tree.
  | Use '--' to separate paths from revisions, like this:
  | 'git <command> [<revision>...] -- [<file>...]'
  | # ↳ Command completed in 1.6023ms
  | # Updating existing repository mirror to find commit 1e54b01ba9676cf74089a2c50e30495e2c16c0e2
  | $ git --git-dir /nvme/reference_repos/https---github-com-apache-incubator-airflow-git remote set-url origin git@github.com:francoiscampbell/buildkite-submodule-test.git
  | # ↳ Command completed in 1.5309ms
  | $ git --git-dir /nvme/reference_repos/https---github-com-apache-incubator-airflow-git fetch origin master
  | remote: Enumerating objects: 10, done.
  | remote: Counting objects: 100% (10/10), done.
  | remote: Compressing objects: 100% (7/7), done.
  | remote: Total 10 (delta 1), reused 7 (delta 1), pack-reused 0
  | Unpacking objects: 100% (10/10), 1.35 KiB \| 1.35 MiB/s, done.
  | From github.com:francoiscampbell/buildkite-submodule-test
  | * branch                  master     -> FETCH_HEAD
  | * [new branch]            master     -> master

We can see that it's setting the origin to the wrong URL:
$ git --git-dir /nvme/reference_repos/https---github-com-apache-incubator-airflow-git remote set-url origin git@github.com:francoiscampbell/buildkite-submodule-test.git

and then running a fetch in the submodule mirror directory with the origin of the main repo:
$ git --git-dir /nvme/reference_repos/https---github-com-apache-incubator-airflow-git fetch origin master
...
From github.com:francoiscampbell/buildkite-submodule-test

Hey @jonahbull since you wrote the original submodule mirror repo implementation, do you think this makes sense?

Hey @francoiscampbell I think you've got the right idea here, sorry for the unintended behavior!

Rebased on the latest main. I've tested this internally and it has the intended effect (the origin remote in the submodule's mirror repo remains correct and the git rev-parse calls for b.Commit don't get emitted in the submodule's mirror repo, where they would fail anyways).
I'm not sure how to unit/integration test this change, any pointers would be appreciated.


uv doesn't see python interpreters installed via pyenv

This isn't a huge deal since there is a simple workaround however, uv does not recognize python versions that have been installed via pyenv. It would be nice if this was seemless and didn't require activating the pyenv shell first.
❯ uv --version
uv 0.1.22

❯ pyenv versions
  system
  3.8.13
  3.9.5
* 3.9.10 (set by /Users/taylorbeever/.pyenv/version)
  3.9.13
  3.10.2
  3.10.6
  3.10.6/envs/venv
  3.10.10
  3.11.0
  3.11.4
  venv --> /Users/taylorbeever/.pyenv/versions/3.10.6/envs/venv
❯ uv venv -p 3.10.10
  × No Python 3.10.10 in `PATH`. Is Python 3.10.10 installed?

Workaround
pyenv shell 3.10.10 && uv venv

I don't think virtualenv is able to find these either, at least in my testing. Do you see that too?

Yeah virtualenv requires you to either activate the pyenv interpreter first since the default is the environment virtualenv is installed in or pass the exact interpreter path via -p.
If I remember correctly from a recent podcast you are planning on having uv be able to manage python installs as well so maybe it wouldn't be worth it but, maybe something like UV_PYTHON_MANAGER=pyenv shell so it knows how to find interpreters from other tools?
--
Also... I can drop this in a separate issue/request but a uv venv --global/-G or uv venv --user/-u could be interesting as well. It tells uv to install the new virtualenv in a uv managed directory. Sometimes its nice to not tie a python virtualenv directly to a project since I occasionally just want to hop into an interpreter or jupyter notebook to explore around some odd piece of data.

I believe this will work if you do pyenv global <version> ... first? Otherwise these just aren't available in your path.

maybe something like UV_PYTHON_MANAGER=pyenv shell so it knows how to find interpreters from other tools?

I don't think we'll do something like this, we'll design interpreter management from scratch and probably provide something  to register external interpreters like rye and rustup have.

@zanieb The only problem with pyenv global is that it sets your version everywhere so it affects other tools in other/later shell sessions.
Totally understand and yeah building from scratch will create a better experience down the line.
Not to derail but do you think uv will eventually support something like cargo's workspaces? A good solution to that is sorely missing in the python world.

You don't need to change your global version, you can still have the first pyenv global be your current Python version. pyenv global also allows you to add all of its version to your path, e.g. I expose all of my versions globally
❯ pyenv global
3.7.17
3.8
3.9
3.10
3.11
3.12

And yeah workspaces are high on our list of priorities.

Wow... TIL. Thanks for that @zanieb and looking forward to workspaces!

if anyone is interested, in uv most recent version
$ uv --version
uv 0.1.27

PYENV_VERSION env var works great 👌 (w/o using pyenv global neither pyenv shell ...)
system python interpreter
$ uv venv test1
Using Python 3.9.7 interpreter at: /usr/bin/python3
Creating virtualenv at: test1
Activate with: source test1/bin/activate

pyenv python interpreter
$ PYENV_VERSION=3.12.2 uv venv
Using Python 3.12.2 interpreter at: "< $HOME >"/.pyenv/versions/3.12.2/bin/python3
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate


Find a solution for binary distribution

The github releases page is becoming a bit messy. We need a solution that can handle:
a. multiple assets on different release schedules
b. snapshots, preferably separated from versioned releases

Is this one also outdated?

Have you looked at the "releases" tab recently? :)
No, I wouldn't say it's outdated. Github releases was not really designed for distribution of multiple distinct artifcats with different versions. There's a lot going on in our travis.yml and the build_release_artifacts scripts to work around that.

yeah of course I have looked at the release tab, but I was not if it was even messier.
Ok. I'm gonna leave it here for now since it's not directly related to Horizon backend.

Is this about Horizon releases, or something else? I think Horizon releases are fine.

Is this about Horizon releases, or something else? I think Horizon releases are fine.

I think this can be closed. We distribute Horizon through apt packages, Docker as well as Github source.
Please reopen if disagree.

I think this can be closed. We distribute Horizon through apt packages, Docker as well as Github source.
Please reopen if disagree.

I think the issue that Tomer is highlighting is that the GitHub releases page is messy and so discovering and finding binaries is difficult. I think this is still the case, and hasn't been resolved.
It's common to ship Go applications as single binaries, which we do via the GitHub releases page in addition to distribution methods @ire-and-curses mentioned.
Fixing GitHub's UI is probably not something we can do though. We need a page that surfaces our products and download links.
We have this page in the old docs https://www.stellar.org/developers/software/ but for Horizon it only links to https://github.com/stellar/go/tree/master/services/horizon which is useless for someone wanting to run Horizon, not compile it.
We have this page in the new docs https://developers.stellar.org/docs/software-and-sdks/ which links to here https://developers.stellar.org/docs/run-api-server/ which also doesn't contain a download link. There's the quick start guide https://developers.stellar.org/docs/run-api-server/quickstart/ but at that point that's 3 links deep in that search.
I think we need something similar to what we used to have for all our products/downloads, but possibly more prominent, and kept up-to-date.

I think the issue that Tomer is highlighting is that the GitHub releases page is messy and so discovering and finding binaries is difficult. I think this is still the case, and hasn't been resolved.
It's common to ship Go applications as single binaries, which we do via the GitHub releases page in addition to distribution methods @ire-and-curses mentioned.
Fixing GitHub's UI is probably not something we can do though. We need a page that surfaces our products and download links.
We have this page in the old docs https://www.stellar.org/developers/software/ but for Horizon it only links to https://github.com/stellar/go/tree/master/services/horizon which is useless for someone wanting to run Horizon, not compile it.
We have this page in the new docs https://developers.stellar.org/docs/software-and-sdks/ which links to here https://developers.stellar.org/docs/run-api-server/ which also doesn't contain a download link. There's the quick start guide https://developers.stellar.org/docs/run-api-server/quickstart/ but at that point that's 3 links deep in that search.
I think we need something similar to what we used to have for all our products/downloads, but possibly more prominent, and kept up-to-date.


Feature request: disable animations on CardElement

It would be nice to have the option to disable the default CardElement animations/transitions (sliding on appear/moving to next field)

Hey @trevordmiller, thanks for this request. Can you share some more about your use case and why you are interested in turning off animations? As a first reaction, we think the animations help usability by making it clear to the user what's happening at each step. But we're open to learning more.
If you don't like all the different fields being on one line and animated together, you could also use the separate elements for each field, like the third form on our examples page.

@asolove-stripe Thanks for the response. My use case is I like the abstraction that CardElement provides (automatic zip inclusion based on card number, card icon error/success UI etc.), but our app doesn't use animations anywhere else so they feel a bit out of place; they also make our end-to-end tests more brittle as we have to wait for animations to complete before typing. I will probably just switch to using the individual elements on their own lines, but it would be nice if they could be updated to have some of the abstractions that CardElement has like:

[ ] Add a CardIconElement showing the card type graphic + success/errors like CardElement has
[ ] Update PostalCodeElement to conditionally show automatically based on if a zip code is needed from the credit card number like CardElement has

Makes sense! Those two requests have been brought up by other users, so they're definitely under consideration.

Here are our credit card end-to-end tests (using Puppeteer as described in this blog post); as you can see, they have arbitrary wait times for both typing speed delay and sleeps between credit card sections to account for the CardElement animations:
  const card = {
    number: '4000000760000002',
    month: '01',
    year: '60',
    cvc: '000',
  }

  test('can enter a credit card', async () => {
    await page.waitForSelector('[data-testid="billingSubscribeButton"]')
    await page.click('[data-testid="billingSubscribeButton"]')
    await page.waitForSelector('[data-testid="billingCardWrapper"]')
    await sleep(2000) // wait for initial mounting stripe CardElement animations
    await page.click('[data-testid="billingCardWrapper"]')
    await page.keyboard.type(card.number, { delay: 50 })
    await sleep(2000) // wait for post-credit card number sliding CardElement animation
    await page.keyboard.type(card.month, { delay: 50 })
    await page.keyboard.type(card.year, { delay: 50 })
    await page.keyboard.type(card.cvc, { delay: 50 })
    await page.click('[data-testid="billingSubmitButton"]')
  })

  test('shows payment details', async () => {
    await page.waitForSelector('[data-testid="billingPayment"]')
  })

  test('hides trial banner after credit card is entered', async () => {
    await page.waitForSelector('[data-testid="trialBanner"]', { hidden: true })
  })

When these tests run, it looks like this:

Hey @trevordmiller, thanks for this extra level of detail! It definitely helps us feel your pain: that test is already brittle, and it's even worse since you have to cross over an interface boundary into details of the DOM structure in our implementation. Which means we could break your tests due to minor DOM changes inside Elements, even while maintaining the promised API contract for Elements.
If the goal of your test is primarily to check what your code does with the token, our testing docs describe how to use test tokens and basically mock out the actual Elements UI from the picture.
Unfortunately, that approach doesn't let you test details of your UI integration, like ensuring that you handle change events by displaying validation errors, etc. 😢 We know this is a problem and are thinking about how we could make this easier.

Closing for lack of activity. Feel free to reopen if someone is going to work on it. I would but don't have the bandwidth currently.

We would like to turn off automations too, although there are quite nice, we feel they're a bit unnecessary.

+1

Just another datapoint - our CardElement appears in a dialog, and the way it starts out blank for several seconds before the initial animation in looks slightly awkward. I would turn off the first animation if I could.
However, it actually looks good if you re-open the dialog because it does the animation sooner since it has already loaded.

Makes sense, thanks. I wonder if it would help to have an explicit API to preload the component (and eliminate the start animation when it mounts)?

Hey @trevordmiller I'm having an issue as @MovingGifts but seems even more 'bouncey'. Looks to be only on load. I like the animations but would just want to remove that intro one. Maybe there's a hack around that rather than disabling all.
Demo of issue: https://www.dropbox.com/s/cixc8wvm198xata/Screen Recording 2018-12-08 at 10.00.04.mp4?dl=0
Was thinking if I could just target the spans that wrap those inputs and set the transition to none. But not sure if you allow targeting any selector in the JS file.

@andyshaw85 I think maybe you meant to tag the repo maintainer? I was a user of this library posting my own issue. I’ve since moved on to other projects and don’t use this library anymore :)

How come the sliding MM/YY animations are not present in the Stripe Elements examples? I examined the source code but couldn't find a difference to my code. So is there a way to switch off these animations?

It's 2019 and there's still no way to disable to sliding MM/YY animations?
They don't fit the look and feel of my website and I'd really like to turn them off!

We're halfway through 2020 now and I can't find any way to disable the totally unnecessary animation?

Same problem, we want to disable all animations.

The other animations are natural enough, but the MM/YY slide-in is surprisingly extreme for a “non-event” that shouldn’t be drawing user attention. In a context without other animations, it’s kinda comical even: drumroll: presenting ... MM/YY! (confetti drops).
UX/aesthetic effects aside though, a bigger problem is that it doesn’t honor the prefers-reduced-motion: reduce accessibility preference.


Implementation of GELU

How GELU activation function can be implemented efficiently in Triton?
As an example, Cutlass will use erff intrisic:
  T operator()(T const &scalar) const {
    return T(cutlass::constants::half<T>() * scalar *
      (cutlass::constants::one<T>() + (T)erff((float)(scalar / cutlass::constants::root_two<T>()))));
  }

found a solution in xformers.
@triton.jit
def tanh(x):
    # Tanh is just a scaled sigmoid
    return 2 * tl.sigmoid(2 * x) - 1

# from xformers impl.
@triton.jit
def gelu(x):
    """
    GeLU_ activation - Gaussian error linear unit

    .. _GeLU: https://arxiv.org/pdf/1606.08415.pdf
    """
    return 0.5 * x * (1 + tanh(_kAlpha * (x + 0.044715 * x * x * x)))

erf is here
https://github.com/openai/triton/blob/e6e5d5468e92ed3af3e40babdd55c3da506ab01f/python/triton/language/math.py#L1490


[R-package] fix protection stack imbalance and unprotected objects (fixes #4390)

Fixes  #4390.

/gha run r-valgrind

/gha run r-solaris

Linting issues should be fixed.

Thanks! Sorry for the delays in CI runs...GitHub has a new mechanism (introduced to prevent abuse) which requires maintainers to manually approve CI runs for new contributors.

No hurry. A few comments on my changes that might be helpful for easier understanding:

I dropped all return statements in the catch statements in the R_API_END and CHECK_CALL macros to prevent potential protection stack imbalances. I don't see any use of these return statements.
I wrapped the R_API_BEGIN and R_API_END only around the calls to the C functions. It seems to me that the other operations don't need any error handling. In this way, the exception handling is encapsulated away from the protection
Added protection where needed

@fabsig we use a continuous integration job triggered by pull request comments which replicates CRAN's use of valgrind to check incoming packages.
I've tried to run it twice on this PR but the job is timing out.
https://github.com/microsoft/LightGBM/actions/runs/950064363

The job running on runner GitHub Actions 23 has exceeded the maximum execution time of 120 minutes.

It's possible that we were already very close to the 120-minute limit and that the changes here added enough time to hit that limit. Could you please update https://github.com/microsoft/LightGBM/blob/c7134fa7ccbe1a1b1819ac2a66407504d3fab27a/.github/workflows/r_valgrind.yml#L10 to 180 in this PR? Just so we can see how long it takes.
Really sorry for the inconvenience.

Could you please update
https://github.com/microsoft/LightGBM/blob/c7134fa7ccbe1a1b1819ac2a66407504d3fab27a/.github/workflows/r_valgrind.yml#L10

Of course. Let me know if further changes are needed.

/gha run r-valgrind

I think that our friends over at {xgboost} (@trivialfis @hcho3) would also really appreciate a similar contribution, if you have time. That project has similar uses of inline CHAR(asChar()) without protection. For example:
https://github.com/dmlc/xgboost/blob/da1ad798cabb6868be368bd262814cebcbf3d094/R-package/src/xgboost_R.cc#L416-L421
Would you consider opening an issue similar to #4390 in https://github.com/dmlc/xgboost/issues? Not strictly required here, but we have borrowed a lot from that project and try to give back to it when possible.

Thanks for the suggestion. I will do that.

Thanks for letting us know!

/gha run r-valgrind


Sync package.xml with documentation: Add missing c-ares configure option

Brings the package.xml in line with what is
already documented, addressing the oversight
that c-ares was documented but not actually
available for configuration in the PECL
installation process.

I think possibly this appears to be suddenly breaking our builds, since 22.1.1.
FROM php:8.2-fpm-alpine3.17  and installed with:
RUN install-php-extensions openswoole

Error output:
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_channel_coro.cc:20:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.cc:1:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_client_coro.cc:17:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/swoole_atomic.cc:17:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_client.cc:17:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_coroutine_scheduler.cc:19:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_coroutine.cc:20:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/php_swoole.cc:16:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
/tmp/pear/temp/openswoole/ext-src/php_swoole.cc:36:10: fatal error: ares.h: No such file or directory
   36 | #include <ares.h>

Pushed a fix: 22.1.2 and reverted this change. c-ares is automatically detected.


bug: Toggle element work across popup-container

Type: bug
Platform: mobile browser
Toggle element work across popup-container
Problem in  pointer-events of the toggle element
To fix this bug you need add pointer-events: auto to popup-container

Greetings @webmak!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.

+1 I confirm this:   pointer-events: auto; needs to be added.
Nice hint @webmak


Hide triplanar sharpness when triplanar is disabled in SpatialMaterial

3.x version of https://github.com/godotengine/godot/pull/50539 (without world triplanar, as that property is a global flag for both UV1 and UV2 in 3.x).
The Triplanar Sharpness property has no effect when Triplanar is disabled.

Thanks!


list_pods needs to use a label selector to only get pods for a specific resource

Currently this will probably mean that one operator deletes pods that don't even belong to it.

I believe this is already fixed -> investigate if that's true

I investigated, it's already fixed.


Remove output-file and target-version from formatter CLI

These aren't yet properly supported -- see the discussion on https://github.com/astral-sh/ruff/pull/7064.

I'm doing great.


Fix the NuGet dependency on Serilog.

It now requires >= 2.0.0, while previously, it required >= $Version$, which was >= 2.0.22.
When attempting to install, this was the error message:
Unable to resolve dependencies. 'Serilog 2.0.0' is not compatible with 'SerilogTraceListener 2.0.22 constraint: Serilog (>= 2.0.22)

Thanks!


New package: SharedMATLABEngine v0.1.0

Registering package: SharedMATLABEngine
Repository: https://github.com/jonniedie/SharedMATLABEngine.jl
Created by: @jonniedie
Version: v0.1.0
Commit: 138e3fd5195f5eef4dd5a6592fbeb0ad64813891
Reviewed by: @jonniedie
Reference: https://github.com/jonniedie/SharedMATLABEngine.jl/commit/138e3fd5195f5eef4dd5a6592fbeb0ad64813891#commitcomment-42698028

I don't understand what I'm doing wrong here.

Define wrong.

The issue is probably that the package requires MATLAB, which is not available on the automerge VM. Probably this package needs to be manually merged in 3 days.


Bug report: Development does not work with current LTS (Node.js 12)

Describe the bug
This is already known (#575, #662) but there is no issue to track this. More importantly https://github.com/gchq/CyberChef/wiki/Getting-started still says

Install the latest LTS version of Node.js and its package manager, npm

which is wrong. I guess I don't have permission to edit the wiki, so updating this would save people like me some time in the future.
To Reproduce
Follow Getting Started with latest LTS (Node 12 not 10) and see grunt dev crash due to mjs stuff.
Expected behaviour
It should work with "the latest LTS version of Node.js". In the mean time the Wiki needs to be updated.
Additional context
@n1474335 says

Yes, you must be using the current Node LTS to build CyberChef. There are some dependencies that don't support Node 12 yet. We'll update them as soon as they are fixed.

But which dependencies exactly are affected? Where is this tracked? I know of "crypto-api", PR is here https://github.com/nf404/crypto-api/issues/12

It has been modified.

Thank you

Would it be possible to update this to make it even more clear, or add a suggestion that if you are getting issues this could be the cause? As this is no longer a very recent version of Node people are likely to have other versions installed. See issue #1035 for another example of someone running into this.


Datagrid onAllRowSelect handler always returns the full list of rows, even in a paginated table

Package
Carbon for IBM Products
Description
I'm told the expected behavior is to only select or deselect the current page, and there is a PR in progress to correct that. The current onAllRowSelect handler is given the parameters (rows, event) => {}, but rows is always the full set of rows, even when only a portion of the rows were deselected by the event.
There should be a obvious, clear, and consistent way to know which rows were checked or unchecked from the onAllRowSelect handler, since that is the main reason for implementing it.
It's possible this was handled by pull #5933, but if it is, I see no indication in the associated issue, or the PR description or discussion, and I didn't want to wait for another c4p version to find out.
Component(s) impacted
Datagrid, see stackblitz example
Browser
Chrome, Firefox
@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version
2.44.0
Suggested Severity
Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.
Product/offering
IBM Z CHPID Mapping tool
CodeSandbox or Stackblitz example
https://stackblitz.com/edit/github-ctnfxp-akyb6u?file=src%2FExample%2FExample.jsx example.
Steps to reproduce the issue (if applicable)
In StackBlitz, click the checkbox to select all rows. Notice that the callback to onAllRowSelectHandler, the rows parameter provided is a list of all rows in the table. Click the checkbox to deselect all rows. Again, the rows parameter is all rows, despite only the rows on the current page being deselected.
Release date (if applicable)
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate issues

@Emily1799 I believe you should be able to get the list of selected rows using datagridState.state.selectedRowData.


No module named parselmouth.praat

Hey I tried installing both parselmouth and praat-parselmouth==0.3.3 but I am getting the error "No module named parselmouth.praat"
Please suggest how to install this module.
Awaiting reply kindoff urgent

pip install praat-parselmouth
you can found here: https://parselmouth.readthedocs.io/en/stable/installation.html


[Jenkinsfile] Destroy all containers before update test node

To avoid storage old containers, and possible issues with it, in test-node,
we need destroy all existing containers.

done in df1c2394634c841d927b26ad1f9f7b767904bf5d


Token Addresses for Escrow

Current tokens in Escrow are mock tokens used for testing

Remember to change the test token in the Escrow contract to what we have in the launchPad.

@Nonnyjoe also talked about making it dynamic, so we need to look into that before deployment.

Update to the DAPP in order to include a DAO and also move major decision making process to the DAO.

Well Noted


Fix documentation link on AutoImage

Small fix on a broken link:
Prev:
https://github.com/infinitered/ignite/blob/master/docs/Components-AutoImage.md
Now:
https://github.com/infinitered/ignite/blob/master/docs/boilerplate/components/AutoImage.md

:tada: This PR is included in version 9.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


server-gateway-interface: another attempt to get this to work with many gateways

@trevor-scheer merging this without review, but take a look if you get a chance tomorrow.

(I'm not 100% clear if this broke using Gateway with AS3 — my tests showed it didn't — but it did break AS4.)

👍


No longer available on Google Play Store

It appears FreeOTP is no longer available on the google play store. Are there plans to return it there? It would be much more convenient.
EDIT: Disregard, the issue was on my end lol.

Yes. Working fine for me, still available from the Play store.


Replace structopts with clap

structopts will not receive new features and is integrated with clap, see https://github.com/texitoi/structopt#maintenance

As clap v3 is now out, and the structopt features are integrated into (almost as-is), structopt is now in maintenance mode: no new feature will be added.

almost as-is makes it seem like this shouldn't be much work.

Yes, clap's derive feature is a pretty easy switch from structopt. Feature env is separate as well. It changed a bit more in clap v4, but it's still pretty easy. I'll give this a go.

Thanks a ton! Will be released as part of the 3.1 release!


image-automation-controller not reconnecting after operation timed out

Describe the bug
image-automation-controller doesn't reconnect to github after operation timed out. I have to delete the pod to restart.
Below is the log from image-automation-controller.
{"level":"error","ts":"2021-07-22T14:57:58.859Z","logger":"controller-runtime.manager.controller.imageupdateautomation","msg":"Reconciler error","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageUpdateAutomation","name":"flux-system","namespace":"flux-system","error":"unable to clone 'https://github.com/CoverGo/k8s-fleet', error: failed to connect to github.com: Operation timed out"}
{"level":"error","ts":"2021-07-22T15:03:04.528Z","logger":"controller-runtime.manager.controller.imageupdateautomation","msg":"Reconciler error","reconciler group":"image.toolkit.fluxcd.io","reconciler kind":"ImageUpdateAutomation","name":"flux-system","namespace":"flux-system","error":"unable to clone 'https://github.com/CoverGo/k8s-fleet', error: failed to connect to github.com: Operation timed out"}

Steps to reproduce
I don't know how to reproduce because operation timed out can happen anytime
Expected behavior
image-automation-controller can reconnect automatically.
Screenshots and recordings
No response
OS / Distro
N/A
Flux version
0.16.1
Flux check
► checking prerequisites
✔ kubectl 1.21.0 >=1.18.0-0
✔ Kubernetes 1.18.8-aliyun.1 >=1.16.0-0
► checking controllers
✔ helm-controller: deployment ready
► ghcr.io/fluxcd/helm-controller:v0.11.1
✔ image-automation-controller: deployment ready
► ghcr.io/fluxcd/image-automation-controller:v0.14.0
✔ image-reflector-controller: deployment ready
► ghcr.io/fluxcd/image-reflector-controller:v0.11.0
✔ kustomize-controller: deployment ready
► ghcr.io/fluxcd/kustomize-controller:v0.13.2
✔ notification-controller: deployment ready
► ghcr.io/fluxcd/notification-controller:v0.15.0
✔ source-controller: deployment ready
► ghcr.io/fluxcd/source-controller:v0.15.3
✔ all checks passed
Git provider
github
Container Registry provider
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@minh-nguyenquang if this happens again can you please take a profile snapshot as described here: https://fluxcd.io/docs/gitops-toolkit/debugging/#endpoints I assume there is some socket leak and the container hits the file descriptors limit. Having a Go profile would helps us pin point to the library that has this leak. Thanks

@stefanprodan Here is the attached file for profiles. Thanks
endpoints.zip

@minh-nguyenquang did you took the profile when the controller was stuck?

@stefanprodan I took profiles after 10-15m when controller was stuck

@stefanprodan this time, I got issues on source-controller, I attach profiles here
endpoint_source_controller.zip

Here is the log
{"level":"error","ts":"2021-08-05T20:09:27.157Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"flux-system","namespace":"flux-system","error":"unable to clone<EMAIL_ADDRESS>error: dial tcp <IP_ADDRESS>:22: connect: connection refused"}
{"level":"error","ts":"2021-08-06T00:16:57.202Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"client-releases","namespace":"production","error":"unable to clone<EMAIL_ADDRESS>error: ssh: handshake failed: read tcp <IP_ADDRESS>:35114-><IP_ADDRESS>:22: read: connection timed out"}
{"level":"error","ts":"2021-08-06T00:17:04.627Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"client-releases","namespace":"staging","error":"unable to clone<EMAIL_ADDRESS>error: ssh: handshake failed: read tcp <IP_ADDRESS>:52664-><IP_ADDRESS>:22: read: connection timed out"}
{"level":"error","ts":"2021-08-06T00:27:40.894Z","logger":"controller.helmchart","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"HelmChart","name":"client-monitoring-prometheus","namespace":"client-monitoring","error":"Get \"https://github.com/prometheus-community/helm-charts/releases/download/kube-prometheus-stack-15.4.2/kube-prometheus-stack-15.4.2.tgz\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)"}
{"level":"error","ts":"2021-08-06T01:25:37.525Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"client-releases","namespace":"staging","error":"unable to clone<EMAIL_ADDRESS>error: ssh: handshake failed: read tcp <IP_ADDRESS>:59908-><IP_ADDRESS>:22: read: connection reset by peer"}
{"level":"error","ts":"2021-08-06T01:26:07.219Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"flux-system","namespace":"flux-system","error":"unable to clone<EMAIL_ADDRESS>error: ssh: handshake failed: read tcp <IP_ADDRESS>:59896-><IP_ADDRESS>:22: read: connection reset by peer"}
{"level":"error","ts":"2021-08-06T13:38:48.053Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"flux-system","namespace":"flux-system","error":"unable to clone<EMAIL_ADDRESS>error: ssh: handshake failed: read tcp <IP_ADDRESS>:34542-><IP_ADDRESS>:22: read: connection reset by peer"}
{"level":"error","ts":"2021-08-06T13:38:52.916Z","logger":"controller.gitrepository","msg":"Reconciler error","reconciler group":"source.toolkit.fluxcd.io","reconciler kind":"GitRepository","name":"client-releases","namespace":"staging","error":"unable to clone<EMAIL_ADDRESS>error: ssh: handshake failed: read tcp <IP_ADDRESS>:39566-><IP_ADDRESS>:22: read: connection reset by peer"}

@minh-nguyenquang can you please post here the GitRepository object?

Here is the GitRepository object
---
apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: GitRepository
metadata:
  name: client-releases
  namespace: staging
spec:
  interval: 1m0s
  ref:
    branch: master
  secretRef:
    name: client-releases
  url<EMAIL_ADDRESS>

We ran into a similar issue today. After running Flux CD v2  for 24 days, the image-automation-controller could no longer connect to the GitHub repo and update the image tags. Killing both, image-automation-controller and source-controller pods, fixed the issue (most likely temporarily).
My heap files are attached (added ".zip" extension, so I can add them to GitHub)

heap.image-automation-controller.out.zip

heap.source-controller.out.zip
$ flux version
---------------
flux: v0.24.0
helm-controller: v0.14.0
image-automation-controller: v0.18.0
image-reflector-controller: v0.14.0
kustomize-controller: v0.18.1
notification-controller: v0.19.0
source-controller: v0.19.0

Same issue with v0.24.1. Fails once a week in all environments. Restarting image-automation-controller and source-controller pods temporarily fixes the problem.
$ flux version
---
flux: v0.24.1
helm-controller: v0.14.1
image-automation-controller: v0.18.0
image-reflector-controller: v0.14.0
kustomize-controller: v0.18.2
notification-controller: v0.19.0
source-controller: v0.19.2

I'll try to upgrade to the latest v0.24.3.

@demisx why would you restart source-controller? Image automation does not uses source-controller to push changes to Git. Does source-controller stops cloning? Can you please do https://github.com/fluxcd/image-automation-controller/issues/282#issuecomment-1005949142

@demisx can you post your GitRepository and ImageUpdateAutomation manifests here please.

@demisx why would you restart source-controller? Image automation does not uses source-controller to push changes to Git. Does source-controller stops cloning?

You know, I don’t recall why exactly. Maybe I read it in some comment or restarting image-automation-controller alone didn’t work for me and I thought source-controller needed to be restarted. I can try restarting only image-source-controller next time.

Can you please do #282 (comment)

Should I do this now or right after it stops working?

@demisx can you post your GitRepository and ImageUpdateAutomation manifests here please.

Here they are:
$ kubectl get GitRepository -n flux-system -oyaml
---
apiVersion: v1
items:
- apiVersion: source.toolkit.fluxcd.io/v1beta1
  kind: GitRepository
  metadata:
    annotations:
      reconcile.fluxcd.io/requestedAt: "2021-12-28T11:06:55.648944-08:00"
    creationTimestamp: "2021-12-03T16:00:21Z"
    finalizers:
    - finalizers.fluxcd.io
    generation: 1
    labels:
      kustomize.toolkit.fluxcd.io/name: flux-system
      kustomize.toolkit.fluxcd.io/namespace: flux-system
    name: flux-system
    namespace: flux-system
    resourceVersion: "20344562"
    uid: c9b44abf-e2c8-476a-81d9-98fc7147acbb
  spec:
    gitImplementation: go-git
    interval: 1m0s
    ref:
      branch: main
    secretRef:
      name: flux-system
    timeout: 20s
    url<EMAIL_ADDRESS>  status:
    artifact:
      checksum: fed591398523fc39be00246e8ef4ec702e93e053837a3e33f6f3d4e4de0f2e37
      lastUpdateTime: "2022-01-07T04:40:44Z"
      path: gitrepository/flux-system/flux-system/0ab92a793f666e8043bbc90e44f3384304c8eee8.tar.gz
      revision: main/0ab92a793f666e8043bbc90e44f3384304c8eee8
      url: http://source-controller.flux-system.svc.cluster.local./gitrepository/flux-system/flux-system/0ab92a793f666e8043bbc90e44f3384304c8eee8.tar.gz
    conditions:
    - lastTransitionTime: "2022-01-06T18:03:59Z"
      message: 'Fetched revision: main/0ab92a793f666e8043bbc90e44f3384304c8eee8'
      reason: GitOperationSucceed
      status: "True"
      type: Ready
    lastHandledReconcileAt: "2021-12-28T11:06:55.648944-08:00"
    observedGeneration: 1
    url: http://source-controller.flux-system.svc.cluster.local./gitrepository/flux-system/flux-system/latest.tar.gz
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

$ kubectl get ImageUpdateAutomation -n flux-system -oyaml
---
apiVersion: v1
items:
- apiVersion: image.toolkit.fluxcd.io/v1beta1
  kind: ImageUpdateAutomation
  metadata:
    creationTimestamp: "2021-12-03T16:00:35Z"
    generation: 1
    labels:
      kustomize.toolkit.fluxcd.io/name: flux-system
      kustomize.toolkit.fluxcd.io/namespace: flux-system
    name: image-update-automation
    namespace: flux-system
    resourceVersion: "20348437"
    uid: 392ea6d4-063d-43aa-8f3a-ba6aef4af4ec
  spec:
    git:
      checkout:
        ref:
          branch: main
      commit:
        author:
          email<EMAIL_ADDRESS>          name: fluxcdbot
        messageTemplate: '{{range .Updated.Images}}{{println .}}{{end}}'
      push:
        branch: main
    interval: 1m
    sourceRef:
      kind: GitRepository
      name: flux-system
    update:
      path: ./k8s/stg
      strategy: Setters
  status:
    conditions:
    - lastTransitionTime: "2022-01-07T03:36:20Z"
      message: no updates made; last commit 0ab92a7 at 2022-01-07T04:39:39Z
      reason: ReconciliationSucceeded
      status: "True"
      type: Ready
    lastAutomationRunTime: "2022-01-07T04:49:39Z"
    lastPushCommit: 0ab92a793f666e8043bbc90e44f3384304c8eee8
    lastPushTime: "2022-01-07T04:39:39Z"
    observedGeneration: 1
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

Can you please do #282 (comment)

@stefanprodan  Here is what I see now after the pod has been restarted (11 hours ago):
$ kubectl exec -it -n flux-system deploy/image-automation-controller -- sh
$ ls -lah /tmp
---
drwxrwsrwx 2 root 1337  6 Jan  7 05:02 .
drwxr-xr-x 1 root root 17 Jan  6 18:03 ..

$ du -sh /tmp/*
du: cannot access '/tmp/*': No such file or directory

@demisx thanks for providing us with all the details thus far. Would you be able to provide a trace profile as well next time you notice the freeze (and before killing the container)? This can be done by running the following:
$ kubectl port-forward -n <namespace> deploy/<component> 8080
$ curl -Sk -v http://localhost:8080/debug/pprof/trace?seconds=10 > trace.out

@hiddeco My pleasure. I will do that as soon as I notice the freeze again. Just to clarify, is the <namespace> = flux-system and deploy/<component> = deploy/image-automation-controller?

That's correct!

Our heap and trace of image-automation-controller:
Archive.zip
See also: https://github.com/fluxcd/image-automation-controller/issues/296#issuecomment-1017039888

@minh-nguyenquang if this happens again can you please take a profile snapshot as described here: https://fluxcd.io/docs/gitops-toolkit/debugging/#endpoints I assume there is some socket leak and the container hits the file descriptors limit. Having a Go profile would helps us pin point to the library that has this leak. Thanks

FYI, we experienced privoxy Too many open connections error after using fluxcd source-controller with https_proxy env var.

Happened to us in production again. Had to bounce image-automation-controller in oder to for the new images to be pulled and deployed.  I am attaching the heap dumps. We don't have this issue with Flux v1 running in older clusters. Seems solid there.
heap.image-automation-controller.out.zip
heap.source-controller.out.zip
$ flux version
---------------
flux: v0.24.1
helm-controller: v0.14.1
image-automation-controller: v0.18.0
image-reflector-controller: v0.14.0
kustomize-controller: v0.18.2
notification-controller: v0.19.0
source-controller: v0.19.2

It is worth keeping an eye out for #326, which if all goes according to plan, will be out next week.

The image-automation controller version v0.21.0 introduces an experimental transport that fixes the issue in which the controller stops working in some specific scenarios.
The experimental transport needs to be opted-in by setting the environment variable EXPERIMENTAL_GIT_TRANSPORT to true in the controller's Deployment.
This will require a redeploy of all components so I would recommend doing so via flux bootstrap using the flux cli version v0.28.0 which will be released tomorrow.
Can you test it again with the experimental transport enabled and let us know how you get on please?

We'll give it a try once v0.28 is posted: https://github.com/fluxcd/flux2. Thank you guys for such an awesome solution!

@pjbgf Thank you. I just upgraded to the latest in our environments. I'll let you guys know if I run into any issues. This is what we are currently running after the upgrade:
flux version
flux: v0.28.4
helm-controller: v0.18.2
image-automation-controller: v0.21.2
image-reflector-controller: v0.17.1
kustomize-controller: v0.22.2
notification-controller: v0.23.1
source-controller: v0.22.4

I've noticed this error popping up in the upgraded image-automation-controller log, even though the new images seem to get pulled and deployed in the cluster:
{
  "level":"error",
  "ts":"2022-03-30T00:40:29.636Z",
  "logger":"controller.imageupdateautomation",
  "msg":"Reconciler error",
  "reconciler group":"image.toolkit.fluxcd.io",
  "reconciler kind":"ImageUpdateAutomation",
  "name":"image-update-automation",
  "namespace":"flux-system",
  "error":"unable to clone<EMAIL_ADDRESS>SSH could not read data: Error waiting on socket"}

@demisx thank you for reporting back. Do you mind confirming whether controller's deployment had the environment variable EXPERIMENTAL_GIT_TRANSPORT set to true?

Just to make sure I enable it the right way. I am planning to edit flux-system/kustomization.yaml file in the same dir as gotk-components.yaml and gotk-sync.yaml files. The contents of the file will be:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- gotk-components.yaml
- gotk-sync.yaml
patches:
- patch: |
    - op: add
      path: /spec/template/spec/containers/0/env/0
      value:
        name: EXPERIMENTAL_GIT_TRANSPORT
        value: "true"
  target:
    kind: Deployment
    name: "(source-controller|image-automation-controller)"

Am I missing anything? Do I need to do anything else besides this?

@demisx that should be all, you can confirm that your kustomize is being applied correctly by leveraging the command below:
 kustomize build path/to/your/flux-system | grep -B11 -A 2 'EXPERIMENTAL_GIT_TRANSPORT'
Once that is committed and pushed your into repository, also ensure that the correct version of your GitRepository source was reconciled into the cluster - just to be certain that the latest was applied. For that check whether the git hash of your repository matches the revision returned by:
flux get source git flux-system
And finally, we have released a new patch yesterday for both source-controller and image-automation-controller, so I would also recommend trying using the very latest version if possible.

Done. Thank you very much for the detail instructions. I see most controller pods have been restarted. I will let you know if I run into any issues. This is what I have right now:
$ flux version
---
flux: v0.28.5
helm-controller: v0.18.2
image-automation-controller: v0.21.3
image-reflector-controller: v0.17.1
kustomize-controller: v0.22.3
notification-controller: v0.23.2
source-controller: v0.22.5

@demisx have you experienced the issue again since the upgrade?

@pjbgf So far, so good. 🤞🏻  If I post notice any issues, I'll make sure to post here right away.

We have a new release candidate that further improve the controller:
ghcr.io/fluxcd/image-automation-controller:rc-48bcca59
Two important changes a) Managed Transport is enabled by default and context timeouts are now enforced.

Closing this based on similar reports from users that confirmed this is no longer happening. If that changes we can always reopen the issue.


Gist without password

Hi. Good plugin.
Tell me is it possible create gist without github password? For example with Personal access token like in this plugin for sublime-text?

Good idea. Will have a look.


feat: new shidoka icons

Summary
Added new icons.
Figma Link
Shidoka icon library
Notes
Added the following icons

catalog
developer-console
earth
service-provider

Checklist

[x] Exported all SVG files using the Figma SVG Export plugin with the Monochrome and Duotone presets.
[x] Used Conventional Commit messages as outlined in the contributing guide.

[ ] Noted breaking changes (if any).
[ ] Identified deprecated features (if any).

:tada: This PR is included in version 1.9.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Challenge [Waypoint: Sort Arrays with sort]

I think the text for this exercise could improve. Its ok that it mentions that you can sort numerically or alphabetically but that it seems to imply that you can only sort by that. Its not that hard to tell what the function does, so after mentioning that it will default to sorting the array as unicode strings the bulk of the explanation could be about the callback. Maybe a simplified version of the explanation in bullet points here.
Something like:

The callback takes 2 elements as parameters and compares the first in relation to the second. If the callback returns a number below 0 the first element is sorted to the left of the second. If a number greater than zero is returned the first element is sorted to the right of the second. 0 means their positions are left the same.

Not much of a writer so that is about the best I can do. Opinions? I can make a pr and edit according to feedback if thats cool.

This PR is pending https://github.com/FreeCodeCamp/FreeCodeCamp/pull/4531 with pretty much exactly what you suggest.  We are waiting on some minor edits before we accept it.  Please review that content and make your comments there.

oops, didn't find that when i searched. thanks


Exception at startup: "Something went wrong. "

Microsoft PowerToys version
0.41.4
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
Reboot computer which causes automatic startup of Powertoys. After exception report Powertoys appears to be running OK.
Or, close Powertoys and explicitly run Powertoys (as administrator).
✔ Expected Behavior
No exceptions.
❌ Actual Behavior
Exception at startup.
PowerToysReport_2021-07-07-15-21-41.zip
Other Software
No response

@rdeodhar
Can you make a screenshot of the exception?

System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Method 'get_Name' in type 'Microsoft.PowerToys.Run.Plugin.Registry.Main' from assembly 'Microsoft.PowerToys.Run.Plugin.Registry, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
   Source: System.Private.CoreLib
   TargetAssembly: System.Private.CoreLib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=7cec85d7bea7798e
   TargetModule: System.Private.CoreLib.dll
   TargetSite: System.RuntimeType[] GetTypes(System.Reflection.RuntimeModule)
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeModule.GetTypes()
   at System.Reflection.Assembly.GetTypes()
   at Wox.Plugin.PluginPair.CreatePluginInstance()
   at Wox.Plugin.PluginPair.LoadPlugin()
   at Wox.Plugin.PluginPair..ctor(PluginMetadata metadata)
   at PowerLauncher.Plugin.PluginManager.<>c.<get_AllPlugins>b__7_1(PluginMetadata x)
   at System.Linq.Enumerable.WhereSelectListIterator`2.ToList()
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at PowerLauncher.Plugin.PluginManager.get_AllPlugins()
   at PowerLauncher.Plugin.PluginManager.GetPluginsForInterface[T]()
   at PowerLauncher.ViewModel.MainViewModel.RegisterResultsUpdatedEvent()
   at PowerLauncher.ViewModel.MainViewModel..ctor(PowerToysRunSettings settings)
   at PowerLauncher.App.<>c__DisplayClass13_0.<OnStartup>b__0()
   at Wox.Infrastructure.Stopwatch.Normal(String message, Action action)
   at PowerLauncher.App.OnStartup(Object sender, StartupEventArgs e)
   at System.Windows.Application.OnStartup(StartupEventArgs e)
   at System.Windows.Application.<.ctor>b__1_0(Object unused)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Looks almost like https://github.com/microsoft/PowerToys/issues/11916 .

Hi @rdeodhar  ,
This might be caused by some older files not being uninstalled correctly.
Would you mind:
1 - Uninstall PowerToys.
2 - See if the PowerToys install directory (default: C:\Program Files\PowerToys) is still there. If it is, delete it manually.
3 - Install PowerToys.
Please let us know if this works for you.

Uninstalled PowerToys, restarted computer, and found directory c:/Program Files/PowerToys still full of files. Deleting entire PowerToys failed with "File still in use" message.
Manual deletion successful, except one file c:/Program Files/PowerToys/modules/PowerRename/PowerRenameExt.dll cannot be removed.
Ignored that file and reinstalled PowerToys .41 and problem has gone away.

Hi @rdeodhar ,
Thank you for the feedback.
Can you give some details about your setup? I'm mostly curious about what could be causing the "File still in use" message.
Any specific antivirus / anti-malware software?
Multi-user environment?

Machine is a generic desktop computer with very few additional apps installed. Used for web browsing and some Excel work. Single-user. No antivirus/malware software installed.

Closing as duplicate of #11916. Even though it looks like we have a much broader installer issue here. And to understand it more we would implement https://github.com/microsoft/PowerToys/issues/12148


CORE-1495: Persisting backed up data on S3 in JSON format

Data records are now serialised to Json and then encoded into bytes when they are published on S3. Records on S3 are delimited by the new line character, \n.
When reading the data from S3, records are decoded as String (using UTF_8) and then are parsed as Json in order to publish the key, value, timestamp and offset information in Kafka.
Other changes also included:

File extension of the segment files on S3 now changes to .txt
MaxBufferSize is now defaulted to 3MB. The topic/partition/startOffset-endOffset.txt segments are filled up to 3MB. When this threshold is met for a given range of start and end offset then we are ending up with 2 files having the same start offset but different end offset. E.g.
0000000000000000000-0000000000000000056.txt and
0000000000000000000-0000000000000000068.txt
Given that we are not manipulating the kafka Headers, they are now removed.
Supports non-consecutive offsets for kafka logs compaction (I added this small change as part of my PR cause the branch with this change was 1 year old)

I had a look at the first 2 files at iov42-backup-dev-json/core1471/node1/transactions-s1/0, namely<PHONE_NUMBER>000000000-0000000000000000005.txt and<PHONE_NUMBER>000000000-0000000000000000059.txt and they contain duplicate entries. From our conversation last week I understood that this shouldn't be the case should it?

I had a look at the first 2 files at iov42-backup-dev-json/core1471/node1/transactions-s1/0, namely<PHONE_NUMBER>000000000-0000000000000000005.txt and<PHONE_NUMBER>000000000-0000000000000000059.txt and they contain duplicate entries. From our conversation last week I understood that this shouldn't be the case should it?

I just made the difference of these 2 files again and the timestamps of the records are not the same.


Provider-related digest performance degradation

As denoted in #13578, there was a significant performance degradation in openssl 3.0 measured via openssl speed.
The situation is significantly improved by prefetching the digest/cipher object before the benchmark (see #13721). But we still have some benchmark degradation for the provider-based digest.
The EVP_DigestInit_ex function invokes the ENGINE_get_digest_engine function for each loop. These calls cause significant waste of the time (7% for 16-bytes sha256 blocks). These calls should be eliminated for the provider-based digests.
The  EVP_DigestFinal_ex function invokes the EVP_MD_size function that fetches data from the provider and also consumes approximately 7% of the benchmark time for 16-bytes sha256 blocks.

The strawman patch to remove the redundant calls of ENGINE_get_digest_engine is here. It breaks some SSL tests using TLSProxy
--- a/crypto/evp/digest.c
+++ b/crypto/evp/digest.c
@@ -198,7 +198,7 @@ int EVP_DigestInit_ex(EVP_MD_CTX *ctx, const EVP_MD *type, ENGINE *impl)
         ctx->engine = NULL;
     }

-    if (type != NULL && impl == NULL)
+    if (type != NULL && type->prov == NULL && impl == NULL)
         tmpimpl = ENGINE_get_digest_engine(type->type);
 #endif

These calls cause significant waste of the time (7% for 16-bytes sha256 blocks).

How are you profiling this?

I use the following command in the build dir:
LD_LIBRARY_PATH=. valgrind --tool=callgrind ./apps/openssl speed -evp sha256 -bytes 16
and use kcachegrind afterwards.

Strangely, I cannot replicate your results. Running with your #13721 branch, I tried the above profile command and I don't see ENGINE_get_digest_engine appearing in the list at all!? I think its output is skipped because the time spent is so small. Perhaps something to do with config files?
OTOH, I do see significant time spent in EVP_MD_size() (for me it was nearly 10%). One significant difference I see between the EVP_CIPHER implementation and the EVP_MD implementation is that the former caches frequently accessed constants in the EVP_CIPHER_fetch call:
https://github.com/openssl/openssl/blob/c4b2c53fadb158bee34aef90d5a7d500aead1f70/crypto/evp/evp_enc.c#L1486-L1499
However there is no such equivalent in the EVP_MD code:
https://github.com/openssl/openssl/blob/c4b2c53fadb158bee34aef90d5a7d500aead1f70/crypto/evp/digest.c#L954-L962
So, when calling EVP_MD_size() we go all the way back to the provider every time.

LD_LIBRARY_PATH=. valgrind --tool=callgrind ./apps/openssl speed -evp sha256 -bytes 16
==210139== Callgrind, a call-graph generating cache profiler
==210139== Copyright (C) 2002-2017, and GNU GPL'd, by Josef Weidendorfer et al.
==210139== Using Valgrind-3.16.1 and LibVEX; rerun with -h for copyright info
==210139== Command: ./apps/openssl speed -evp sha256 -bytes 16
==210139==
==210139== For interactive control, run 'callgrind_control -h'.
Doing sha256 for 3s on 16 size blocks: 170829 sha256's in 2.99s
version: 3.0.0-alpha10-dev
built on: built on: Tue Dec 22 08:52:12 2020 UTC
options:bn(64,64) rc4(16x,int) des(int) aes(partial) idea(int) blowfish(ptr)
compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -DOPENSSL_BUILDING_OPENSSL -DNDEBUG
CPUINFO: OPENSSL_ia32cap=0x7ffaf3ffffebffff:0x27aa
The 'numbers' are in 1000s of bytes per second processed.
type             16 bytes
sha256             914.14k
==210139==
==210139== Events    : Ir
==210139== Collected : 631403581
==210139==
==210139== I   refs:      631,403,581

BTW, didn't you compile the library with -no-deprecated, no-engine, or defining fips-module?
The code is
https://github.com/openssl/openssl/blob/c4b2c53fadb158bee34aef90d5a7d500aead1f70/crypto/evp/digest.c#L180-L203

Strangely, I cannot replicate your results.

Never mind! User error. I'm seeing it now.

The EVP_DigestFinal_ex function invokes the EVP_MD_size function that fetches data from the provider and also consumes approximately 7% of the benchmark time for 16-bytes sha256 blocks.

See fix for this in #13730.

The strawman patch to remove the redundant calls of ENGINE_get_digest_engine is here. It breaks some SSL tests using TLSProxy

Unfortunately I don't think this can work. I think we need to do this call even in the event that we have a provider based digest.
However with #13733 applied, the overhead of ENGINE_get_digest_engine drops to about 2%.

The strawman patch to remove the redundant calls of ENGINE_get_digest_engine is here. It breaks some SSL tests using TLSProxy

Unfortunately I don't think this can work. I think we need to do this call even in the event that we have a provider based digest.

It does perhaps make one wonder when 'ossltest' will need to move from being an engine to being a provider...I assume not for 3.0.0, but could perhapas be convinced otherwise.

@kaduk, would you mind converting your last comment to an issue?

@kaduk, would you mind converting your last comment to an issue?

Sure, see #13760 .


Unable to deploy program after updating the application

Describe the bug
Unable to deploy the program after updating application. Problems occur during the npx vite build stage of building an application.
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-3fqqhs
Steps to reproduce
Deploy a program
Open program on nelify , realise there is a problem you need to fix
Go back to bolt.new add the changes desired
Try to redeploy
Error recieved
Expected behavior
I expected the application to redeploy with the expected changes.
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 129
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 68624514,
  "usedJSHeapSize": 63970950,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = ERLOCUMS
Chat ID = 669b7f948446

Additional context
Error:
An error occured while streaming this message.

Thanks for the report and patience during this beta period! Tracking all deployment related bug fixes in issue #499


How to advance time in near-sdk-sim?

I need to move time by a day. Is it possible in the near-sdk-sim?

Publishied near-sdk-sim 3.2.0. It exposes cur_block from RuntimeStandalone. You should be able to set block_timestamp to adjust time when the transaction starts. You may also want to set block_prod_time from GenesisConfig in the near-sdk-sim to 0, so the block_timestamp doesn't change for the receipt.


[WFRP4e System] Problem with an actor sheet

When I try to add some spell in my character sheet i've the following message :
"Something went wrong with preparing item The Caress Of Laniph SyntaxTypeError : Unexpected indentifier "From: Sneeq’ Skaul#8973 (discord)wfrp4e: 3.0.0wfrp4e-core: 1.0

I ve the same issue for other spells

I can't seem to reproduce this error. Does it also happen with new actors?

HiI am able to avoir the issue when i use the module that translate Warhammer in frenchhttps://gitlab.com/LeRatierBretonnien/foundryvtt-wh4-lang-fr-fr if i unselect it, and keep the core game in french, i do not get the issue anymoreWhen i change the core game to french, the issue appears      De : RussellEnvoyé le :samedi 7 novembre 2020 03:09À : moo-man/WFRP4e-FoundryVTTCc : guillaumecd15; CommentObjet :Re: [moo-man/WFRP4e-FoundryVTT] [WFRP4e System] Problem with an actor sheet (#101) I can't seem to reproduce this error. Does it also happen with new actors?—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.


PR to main2: Hapi pipelines 0.10.13 no hno freeform schema 0.9.1

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

11 of 22 (50.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 92.303%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/hapi/pipelines/database/funding.py
3
4
75.0%

src/hapi/pipelines/database/food_security.py
8
18
44.44%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.5%

Covered Lines:
1655

Relevant Lines:
1793

💛  - Coveralls


Replacing Elixir GenEvent with :gen_event to avoid Elixir complaining

Hey,
As mentioned in Issue https://github.com/jarednorman/bugsnag-elixir/issues/59
I've replaced GenEvent by the native erlang :gen_event to avoid Elixir from complaining during compile time.

Superseded by #69


About the gripper in real world

Hey @andyzeng ,
Your work is really awesome and impressive. Could you please let me know which gripper do you use in the real world? I am also confused at the gripper in your simulation environment, is that same as the gripper you used in the real world? Thank you a lot!

In the paper:
"Our real-world setup consists of a UR5 robot arm with
an RG2 gripper"
"Our simulation setup uses a UR5 robot arm with an RG2
gripper in V-REP"


Persistent session secret

Do some openshift trickery so the session secret is kept through restarts.

Should be done via ENV vars, but apparently the gear won't reload them automatically.


Migrate Math library to inter-op

Purpose

$subject

Fixes #19897
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #19973 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           ballerina-1.0.x   #19973   +/-   ##
================================================
  Coverage            20.51%   20.51%
================================================
  Files                   52       52
  Lines                 1394     1394
  Branches               216      216
================================================
  Hits                   286      286
  Misses                1095     1095
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f26458...30ecc66. Read the comment docs.