environment.yml unable to resolve dependencies

Hello @BPHO-Salk ,
I wanted to test PSSR on some 8nm FIB-SEM datasets and am attempting this on Ubuntu 18.04 (through WSL2), but I think I'm encountering dependency hell.
Using the provided environment.yml leads to four libraries not found
$ conda env create --file=env.yml
Collecting package metadata (repodata.json): done
Solving environment: failed

ResolvePackageNotFound:
  - regex==2018.01.10=py37h14c3975_1000
  - dataclasses==0.6=py_0
  - spacy==2.0.18=py37hf484d3e_1000
  - thinc==6.12.1=py37h637b7d7_1000

I edited the .yml and moved the four packages under the pip section, but incompatibilities persist (see PSSR-environment-yml-issues.txt
for the full conflicts.
Similarly, if I add conda-forge to the list of channels, I get an UnsatisfiableError
PSSR-with-conda-forge-channel.txt
Any help/suggestions would be greatly appreciated!
Will

I can get around this somewhat by using env-fresh-Copy.txt
but then libtiff can't be imported.
Seeing that Inference_PSSR_for_EM.ipynb only uses libtiff for loading, I commented out the import statement and replaced the first two lines in tif_predict_movie_blend_slices with data = skimage.external.tifffile.imread(tif_in)
The cells run without issue until loading the model.
<ipython-input-9-e1d63bdede98> in <module>
      1 #state = torch.load(path, map_location='cuda:0')
      2 model_name = 'PSSR_for_EM_1024'
----> 3 learn = load_learner('./stats/models', f'{model_name}.pkl').to_fp16()
      4 size = int(model_name.split('_')[-1])
      5 print(f'{model_name} model is being used.')

~/anaconda3/envs/pssr/lib/python3.7/site-packages/fastai/basic_train.py in load_learner(path, file, test, **db_kwargs)
    608     "Load a `Learner` object saved with `export_state` in `path/file` with empty data, optionally add `test` and load on `cpu`. `file` can be file-like (file or buffer)"
    609     source = Path(path)/file if is_pathlike(file) else file
--> 610     state = torch.load(source, map_location='cpu') if defaults.device == torch.device('cpu') else torch.load(source)
    611     model = state.pop('model')
    612     src = LabelLists.load_state(path, state.pop('data'))

~/anaconda3/envs/pssr/lib/python3.7/site-packages/torch/serialization.py in load(f, map_location, pickle_module, **pickle_load_args)
    385         f = f.open('rb')
    386     try:
--> 387         return _load(f, map_location, pickle_module, **pickle_load_args)
    388     finally:
    389         if new_fd:

~/anaconda3/envs/pssr/lib/python3.7/site-packages/torch/serialization.py in _load(f, map_location, pickle_module, **pickle_load_args)
    572     unpickler = pickle_module.Unpickler(f, **pickle_load_args)
    573     unpickler.persistent_load = persistent_load
--> 574     result = unpickler.load()
    575
    576     deserialized_storage_keys = pickle_module.load(f, **pickle_load_args)

~/anaconda3/envs/pssr/lib/python3.7/site-packages/torch/serialization.py in persistent_load(saved_id)
    535                 obj = data_type(size)
    536                 obj._torch_load_uninitialized = True
--> 537                 deserialized_objects[root_key] = restore_location(obj, location)
    538             storage = deserialized_objects[root_key]
    539             if view_metadata is not None:

~/anaconda3/envs/pssr/lib/python3.7/site-packages/torch/serialization.py in default_restore_location(storage, location)
    117 def default_restore_location(storage, location):
    118     for _, _, fn in _package_registry:
--> 119         result = fn(storage, location)
    120         if result is not None:
    121             return result

~/anaconda3/envs/pssr/lib/python3.7/site-packages/torch/serialization.py in _cuda_deserialize(obj, location)
     93 def _cuda_deserialize(obj, location):
     94     if location.startswith('cuda'):
---> 95         device = validate_cuda_device(location)
     96         if getattr(obj, "_torch_load_uninitialized", False):
     97             storage_type = getattr(torch.cuda, type(obj).__name__)

~/anaconda3/envs/pssr/lib/python3.7/site-packages/torch/serialization.py in validate_cuda_device(location)
     87                            'torch.load with map_location to map your storages '
     88                            'to an existing device.'.format(
---> 89                                device, torch.cuda.device_count()))
     90     return device
     91

RuntimeError: Attempting to deserialize object on CUDA device 1 but torch.cuda.device_count() is 1. Please use torch.load with map_location to map your storages to an existing device.

The traceback here is actually helpful--I can get around this by modifying line 610 in ~/anaconda3/envs/pssr/lib/python3.7/site-packages/fastai/basic_train.py to include map_location like torch.load(source, map_location='cuda:0') to explicitly set my only GPU
old:
state = torch.load(source, map_location='cpu') if defaults.device == torch.device('cpu') else torch.load(source)
new:
state = torch.load(source, map_location='cpu') if defaults.device == torch.device('cpu') else torch.load(source, map_location='cuda:0')
But then the next cell (while predicting) fails with RuntimeError: expected backend CPU and dtype Float but got backend CUDA and dtype Float
I'm not really sure what to do at this point.
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
<ipython-input-9-e7a6526bad09> in <module>
      4     orig_name = results/f'{fn.stem}_orig.tif'
      5     print(fn)
----> 6     tif_predict_movie_blend_slices(learn, str(fn), size=size, orig_out=orig_name, pred_out=pred_name )

<ipython-input-3-0521c6b7a95d> in tif_predict_movie_blend_slices(learn, tif_in, orig_out, pred_out, size)
     10             img /= img_max
     11             img = img[np.newaxis, :]
---> 12             out_img = unet_image_from_tiles_blend(learn, img, tile_sz=size)
     13             pred = (out_img[None]*255).astype(np.uint8)
     14             pred_img_out = pred_out+f'_slice{depth}.tif'

<ipython-input-4-5880e9deca7b> in unet_image_from_tiles_blend(learn, in_img, tile_sz, scale, overlap_pct, img_info)
     37             else:
     38                 img_in = Image(in_tile[:,:,0][None])
---> 39             pred, _, _ = learn.predict(img_in)
     40
     41             out_tile = pred.data.numpy()[0]

~/anaconda3/envs/pssr/lib/python3.7/site-packages/fastai/basic_train.py in predict(self, item, return_x, batch_first, with_dropout, **kwargs)
    368         norm = getattr(self.data,'norm',False)
    369         if norm:
--> 370             x = self.data.denorm(x)
    371             if norm.keywords.get('do_y',False): raw_pred = self.data.denorm(raw_pred)
    372         ds = self.data.single_ds

~/anaconda3/envs/pssr/lib/python3.7/site-packages/fastai/vision/data.py in denormalize(x, mean, std, do_x)
     59 def denormalize(x:TensorImage, mean:FloatTensor,std:FloatTensor, do_x:bool=True)->TensorImage:
     60     "Denormalize `x` with `mean` and `std`."
---> 61     return x.cpu().float()*std[...,None,None] + mean[...,None,None] if do_x else x.cpu()
     62
     63 def _normalize_batch(b:Tuple[Tensor,Tensor], mean:FloatTensor, std:FloatTensor, do_x:bool=True, do_y:bool=False)->Tuple[Tensor,Tensor]:

RuntimeError: expected backend CPU and dtype Float but got backend CUDA and dtype Float

The new environment set-up instructions work for me. Closing this issue but will include the instructions below for posterity. Thanks, Linjing!
git clone https://github.com/BPHO-Salk/PSSR.git
conda create --name pssr python=3.7
conda activate pssr
pip install fastai==1.0.55 tifffile czifile scikit-image
pip uninstall torch
conda install pytorch==1.1.0 torchvision==0.3.0 cudatoolkit=10.0 -c pytorch


feat(auth): add onTokenCreated option

Description
Introduce onTokenCreated option to auth() mehotd.
Context
Fixes #86

This is a 5 min. draft PR to validate the approach. I would like your input here @gr2m @wolfy1339 @ofhouse

@oscard0m Thank you very much for taking the initiative!
The existing onVerification callback seems to accept an async callback function.
For our case we will invoke a transaction on our database when the callback is triggered.
So it would be helpful if onTokenCreated would also optionally accept an async callback function.

@oscard0m Thank you very much for taking the initiative!
The existing onVerification callback seems to accept an async callback function. For our case, we will invoke a transaction on our database when the callback is triggered. So it would be helpful if onTokenCreated would also optionally accept an async callback function.

Applied an await when invoking onTokenCreated() + added void | Promise<void> as return type

Looking forward to getting this merged and released.


api error 403

idk why but im getting ""An error occurred: Command raised an exception: APIException: 403 403 on https://myanimelist.net/anime.php?q=dragon+ball&type=1&score=0&status=0&p=0&r=0&sd=0&sm=0&sy=0&ed=0&em=0&ey=0&gx=0&c[]=a&c[]=b&c[]=c&c[]=f&c[]=d&c[]=e&c[]=g: error for search type=anime, query=dragon ball""
.

Was an API related issue - which should be fixed now.
Is this still occurring for you?

Nope, its working now, thx!

It's happening again 😢

Issue with MAL.
https://github.com/jikan-me/jikan/issues/283


update packages

:white_check_mark: Build TheIdServer 2.1.1-maintain-1-0-01-0074 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/a77e08e9a8 by @)


Small typo in RLMAnalytics.mm

https://github.com/realm/realm-cocoa/blob/master/Realm/RLMAnalytics.mm#L50
says mimimum,
should say minimum.

Thanks! We just fixed it.


Internal build failure: 'status_or.h' file not found

I'm trying to run performance tests in Google's internal system and got the following kind of building errors:
In file included from third_party/flutter_engine/lib/ui/painting/image.cc:11:
./third_party/flutter_engine/lib/ui/painting/image_encoding_impeller.h:10:10: fatal error: 'third_party/flutter_engine/fml/status_or.h' file not found
   10 | #include "third_party/flutter_engine/fml/status_or.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

sponge2/34a90d3c-29af-45ca-952f-6e9733c86612
Adding status_or.h to the internal fml/BUILD file resolves the error.
The file was added in https://github.com/flutter/engine/pull/46738 which introduces this new file without adding it to BUILD.gn

cc @jonahwilliams @gaaclarke
(I could've just filed a PR that adds this file to BUILD.gn but I'm not sure if the BUILD.gn is converted to the internal BUILD.)

Note that this breakage is tangential to the internal production build and is mainly used for debugging. It's expected for this to be broken from time to time (with fix forwards), and I'm actively looking into fixing the build at this time.
@dkwingsmt let's talk more internally about your use case :)

@jiahaog Thank you! Sure!

status_or is missing from the GN rule which is an engine issue and will be patched. I am unable to provide guidance about the internal failure.

I'm discussing the internal building issue with jiahaog and we agreed this Github issue can now be closed.


[ja] Translate docs/concepts/security/api-server-bypass-risks.md into Japanese

This is a Feature Request
What would you like to be added
Translate docs/concepts/security/api-server-bypass-risks.md into Japanese
Why is this needed
There is no Japanese translation for this page
Comments

File to translate:

https://github.com/kubernetes/website/blob/main/content/en/docs/concepts/security/api-server-bypass-risks.md

Related page:

https://kubernetes.io/docs/concepts/security/api-server-bypass-risks/

日本語に翻訳する際は、以下のドキュメントを参考にしてください。

Japanese Localization document: https://kubernetes.io/ja/docs/contribute/localization/

/area localization
/language ja
/help
/triage accepted

/assign


Fixed spelling and stats for Persistence TMR

Spelling from Persistance to Persistence
Stats from +30% SPR to +20% SPR

Thanks for the fix !

No problem, thanks for making an extremely useful program :)


New ImGui IO event API

This pull request reworks the Unreal backend for ImGui to use the new IO event API introduced in ImGui 1.87.
Most of the intermediate storage has been removed in this project as core ImGui now handles it correctly even at low framerates. Certain missing keybinds have been added (such as Super/Command).
It is advisable for users of this project to thoroughly review and test this before it is merged.

Is this properly tested? I gave it a try but keyboard & gamepad navigations both not working anymore after applying the diff.

This will be required to update imgui above v1.91.4. Help would be appreciated.


fix: searchBar #285

Coverage decreased (-0.007%) to 70.957% when pulling f9c43a7c76fe662b6b1425dd0a7bf6431a1a4770 on Yang03:fix4 into 63a518bd0666a278de80428b3698b2c481dc5a86 on ZhonganTechENG:dev.

fix #285


Source Control

This is a minor thing,
Is /Generated meant to be kept under source control?
I don't see a way around it, and I currently do keep it under source control, but I find it just a bit uncomfortable that ComponentIds.cs gets changed all over because of reordering the ComponenetIds each time I add or remove a new Component.
Had nothing better to complain about, and needed my daily does :)
Just wanted to make sure I am doing it right.

:)
Yes, Generated has to be in version control.
... but, when we have the roslyn generator - some day - we could ignore the generated folder.


Replace print statement with logger

Hi @artbycrunk,
Can I handle this one?

Sure thing @ron-huberfeld, thanks

@ron-huberfeld hi, were you able to make any progress here?

Hi, I was not able to pass the test cases in the existing code. I notice tests didn't pass for a long time. I didn't want to put new stuff before tests are ok.
Do you have any insight of why they are failing?
Do you want me to insert new code and ignore the tests?

oh that's not good,
ok please insert your new code,
while I look into why the tests are not passing anymore.
Thanks


Warnings after run python3 install on macOS

My python version is 3.9.6. Get following warning and cannot continue:
/Library/Python/3.9/site-packages/binwalk-2.3.3-py3.9.egg/binwalk/modules/extractor.py:969: SyntaxWarning: "is" with a literal. Did you mean "=="?
/Library/Python/3.9/site-packages/binwalk-2.3.3-py3.9.egg/binwalk/modules/extractor.py:984: SyntaxWarning: "is" with a literal. Did you mean "=="?
/Library/Python/3.9/site-packages/binwalk-2.3.3-py3.9.egg/binwalk/modules/extractor.py:969: SyntaxWarning: "is" with a literal. Did you mean "=="?
/Library/Python/3.9/site-packages/binwalk-2.3.3-py3.9.egg/binwalk/modules/extractor.py:984: SyntaxWarning: "is" with a literal. Did you mean "=="?

The Python version of Binwalk is largely unmaintained and will soon be depreciated. It is succeeded by Binwalk v3, which is written in Rust; unfortunately, at least for now, only Linux is supported


fix fix scale check of Decimal/Datetime type

Proposed changes
Issue Number: close #xxx
before:
drop to BE
now:
throw error on FE
Further comments
Need to rebase after another pr merged. So draft now

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.03 seconds
stream load tsv:          506 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select:          29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size:<PHONE_NUMBER>4 Bytes

run buildall

run buildall

run buildall

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.6 seconds
stream load tsv:          509 seconds loaded<PHONE_NUMBER>9 Bytes, about 140 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select:          29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size:<PHONE_NUMBER>2 Bytes

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.43 seconds
stream load tsv:          539 seconds loaded<PHONE_NUMBER>9 Bytes, about 132 MB/s
stream load json:         20 seconds loaded<PHONE_NUMBER> Bytes, about 112 MB/s
stream load orc:          65 seconds loaded<PHONE_NUMBER> Bytes, about 16 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size:<PHONE_NUMBER>7 Bytes


Set up Open API / swagger

[ ] Add the Open Api
[ ] Expose actuator endpoints
[ ] Include tests to ensure the endpoint is available to access the swagger
[ ] Document it

https://springdoc.org/


debugging with ray

Hi guys,
Not an issue strictly related to this repo, did you guys figure out that there is a better way to debug ray-related code other than using ray debug and pdb? Is there a way to connect ray debug to vscode? How do you guys debug this code normally? Setting ray local_mode==true could make use of the vscode debugger but it could only use a single gpu.

Ray is a distributed framework, so its debug is not natural as normal python program. For now, I would suggest ray debug and add more logging to your program.

thank you, I guess there is no better way to work with it.


change:improve placeholder for empty settings tables

Fixes: #27250
This PR fixes the first two items of the issue:

Changing the string "No X found" to "There are no X"  in settings tables.
Using "emoji" rather than "emojis", like elsewhere on this page / in our documentation.
Replaces  "No linkifers set." to "No linkifiers configured." (to match the Playgrounds placeholder text)

Before changes

After Changes

Thanks for working on this @Himanshi2012! Closing in favor of #28905 for this issue.


[GHSA-qppj-fm5r-hxr3] HTTP/2 Stream Cancellation Attack

Updates

Affected products

Comments
tomcat -> tomcat-coyote as the affected maven artifact id per the fix commits (example https://github.com/apache/tomcat/commit/944332bb15bd2f3bf76ec2caeb1ff0a58a3bc628 taken from https://tomcat.apache.org/security-8.html#Fixed_in_Apache_Tomcat_8.5.94)

Hi there @Lukasa! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.
This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory


Terminal not scrolling to the bottom when executing code

VSCode Version: Code - Insiders 1.18.0-insider (81cca6cc606eeca3443998025bff3893fcfe3ad5, 2017-10-31T05:19:39.344Z)
OS Version: Windows_NT x64 6.2.9200
Extensions: PowerShell|ms-|1.5.0

Steps to Reproduce:

Execute code that has terminal output (PowerShell code)
Scroll up to see the first line of output
Execute the code again and notice that the terminal is not scrolled down to the bottom to see the result of the latest code run

This issue has been reported in #18362 and in #17325. But I don't think it's fixed or possible to set this behavior without resorting to macro extensions.

It looks like you would be executing the code via the powershell extension so please create the issue over there https://github.com/PowerShell/vscode-powershell


only build intel vulkan driver

I came across the fact that valve also uses a seperate radv driver
I thought why could we not do the same with our patched intel driver? So I tried this. No idea if it works, so looking for testers :)

The manifest would need to be updated to add all the other mesa packages that are being removed. This can be used as a reference point. https://github.com/ChimeraOS/chimeraos/commit/be81aab24cca0a923b6ae5cae12639d3a3d81f66

Neat!


Auth provider OIDC not listing the groups

Hi
We are testing OpenID connect Auth provider but are unable to list the groups in the 'Test login'.
When looking at our access manager (ForgeRock), we noticed that there is no groups scope request. Only the following scopes are in the request to the access manager according to the AM logs:
"scope":"openid profile email"

When looking at the code (not a GO expert) I did find this (pkg/auth/authproviders/oidc/backend_impl.go):
func createBaseOAuthConfig(clientID string, clientSecret string, endpoint oauth2.Endpoint, helper *endpoint.Helper, offlineAccessSupported bool) (oauth2.Config, error) {
        baseConfig := oauth2.Config{
                ClientID:     clientID,
                ClientSecret: clientSecret,
                Endpoint:     endpoint,
                Scopes:       []string{oidc.ScopeOpenID, "profile", "email"},
        }
        if clientSecret != "" && offlineAccessSupported {
                baseConfig.Scopes = append(baseConfig.Scopes, oidc.ScopeOfflineAccess)
        }

        var err error
        baseConfig.Endpoint.AuthURL, err = helper.AdjustAuthURL(baseConfig.Endpoint.AuthURL)
        if err != nil {
                return oauth2.Config{}, err
        }
        return baseConfig, nil
}

The 'groups' isn't passed on to the Scopes variable/config. Only openid (ScopeOpenID), profile and email.
The configuration we are passing on to the API to create the AuthProvider:
{
  "name": "ForgeRock_api_test",
  "type": "oidc",
  "uiEndpoint": "central.example.com",
  "enabled": true,
  "config": {
    "client_id": "<our_client_id>",
    "client_secret": "<our_client_secret>",
    "issuer": "https://forgerock.example.com:443/poam/oauth2/",
    "mode": "auto"
  },
  "validated": false,
  "extraUiEndpoints": [],
  "active": false,
  "requiredAttributes": [],
  "traits": {
    "mutabilityMode": "ALLOW_MUTATE",
    "visibility": "VISIBLE",
    "origin": "IMPERATIVE"
  }
}

Is there something we are missing here to get the groups in the scopes?
Stackrox version: v4.3.x-199-g63837ac284
Thank you!
Regards
Matthias

@matthiasdeblock groups is not a standard OIDC scope hence we don't request it. Usually it's possible to configure an IdP to include groups information into the token. Maybe you can configure ForgeRock to do that? Maybe enabling "Always Return Claims in ID Tokens" under OAuth2 Provider > Advanced OpenID Connect would work

Hi
The id token does have the groups information. Our other apps, for example
Argocd, are working with the groups in the id token. They receive the
groups as they ask for it. Stackrox does not ask for it so it does not
receive it.
Is it possible to configure the scopes?
Thanks!
Regards
Matthias
On Mon, Nov 20, 2023, 8:55 PM Alex Rukletsov @.***>
wrote:

@matthiasdeblock https://github.com/matthiasdeblock groups is not a
standard OIDC scope hence we don't request it. Usually it's possible to
configure an IdP to include groups information into the token. Maybe you
can configure ForgeRock to do that? Maybe enabling "Always Return Claims in
ID Tokens" under OAuth2 Provider > Advanced OpenID Connect would work
—
Reply to this email directly, view it on GitHub
https://github.com/stackrox/stackrox/issues/8715#issuecomment-1819704894,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADR3RHDD3VUHHNZSQ2JSQP3YFOYRLAVCNFSM6AAAAAA7S2EPBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZG4YDIOBZGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@rukletsov any updates from your side?

The issue has been registered as ROX-23628 in our system and will be addressed in accordance with our current availability, the priority level of the issue, and our ongoing project plans. We are committed to providing quality service and handling each query with the utmost importance.
While I don't have an exact timeline right now, please rest assured that we are on it. We will keep you updated on the progress and notify you as soon as we have more specific information or require further details.
Thank you for your understanding and patience.

This will be possible to configure via API starting with version 4.5.


feat(ui-shell): add navigation menu component

Closes #1358
This PR will add functionality to the UI shell navigation menu component, which extends a generic navigation panel component (name subject to change). Shares changes intended for #1359
Changelog
New

navigation menu

Changed

header markup and styles to accommodate hooks needed for navigation menu
renamed nav component to navigation-menu

Also noticed a bug when clicking to close the menu in that it will close and then re-open right after 🤔

Also noticed a bug when clicking to close the menu in that it will close and then re-open right after 🤔

thanks for catching that @joshblack ! It should be resolved now

@aagonzales the changes should be reflected in the updated staging link now. Please let me know if I have misinterpreted any of your feedback

It looks like you got all of them except making the selected items font-weight: semibold/600.

should be fixed now @aagonzales let me know if additional changes are needed


don't limit the number of tessellation polygon sides

@jeffeb3 per your comment in #105, I've refactored the tessellation to allow any number of polygon sides. I like it - you can create nice circular patterns now for polar machines.

LGTM


SqlServerDsc: Add a CODE_OF_CONDUCT.md

Pull Request (PR) description

Changes to SqlServerDsc

Added a CODE_OF_CONDUCT.md with the same content as in the README.md (issue #939).

This Pull Request (PR) fixes the following issues:
Fixes #939
Task list:

[x] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

I'm not sure I see the value in retaining the code of conduct in the README file with the addition of the CODE_OF_CONDUCT file. If it's best practice to have a separate code of conduct file, I think it should be removed from the README at the same time it is added to the code of conduct file.

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@randomnote1 I agree. Raised the question in https://github.com/PowerShell/DscResources/issues/337 just to be sure there is no legal issue by removing it. :)
Lets keep this open until we get answer on that issue.

Codecov Report

Merging #940 into dev will decrease coverage by <1%.
The diff coverage is n/a.

@@         Coverage Diff         @@
##            dev   #940   +/-   ##
===================================
- Coverage    96%    96%   -1%
===================================
  Files        32     32
  Lines      3533   3515   -18
===================================
- Hits       3413   3395   -18
  Misses      120    120

Reviewed 2 of 2 files at r1, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Kube-DNS Failing in some Node Pools

Is this a request for help?:
Yes
Is this an ISSUE or FEATURE REQUEST? (choose one):
Issue
What version of acs-engine?:
v0.24.3

Kube-DNS is failing to resolve in two out of five node pools in the ACS-Engine 1.10.0 k8s cluster. The DNS failures began after upgrading to 1.10.0 from 1.9.6. In three of the node pools, there are no issues with dns resolution, however there are consistent failures in two of the node pools.
There are many related issues in the Kubernetes repo regarding DNS timeouts/latency, however several fixes have failed to resolve the time out. This includes applying the 4.15.0-1030-azure kernel patch as well as configuring the single-request-reopen configuration in resolv.conf for the pods.
We have confirmed that the kernel patch did not resolve the issue in both busybox and CoreOS containers in this instance.
Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes 1.10.0
What happened:
Attempting to ping external sites (e.g. bing.com) from inside a pod in the affected node pools result in a long wait (~5-10 seconds) or a timeout altogether intermittently. Curl consistently times out across the pods in the affected node pools.
What you expected to happen:
DNS to resolve in a timely manner for pods across all node pools// a consistent behavior for DNS across all node pools.
How to reproduce it (as minimally and precisely as possible):
Create an ACS-Engine 1.9.6 cluster with five node pools, upgrade it to ACS-Engine 1.10.0, and test resolution to external domains across all node pools.
Anything else we need to know:
Kube-DNS is deployed with 2 replicas, both on the affected node pools (one on the first affected node pool, the other on the second affected node pool).

In order for us to understand. I will name failing pools f1 an f2. Can you confirm

Pods on f1 and f2 fail to resolve DNS via kube-dns? Do they fail with default policy as well? https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/?
Pods anywhere fail to resolve dns via kube-dns? Do they work with default policy as well? https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/

@jackfrancis

Pods on f1 and f2 succeed in resolving external addresses when set to default policy. However, when using the default policy, we are unable to access internal k8s services.
Pods in non failing pools when set to default dnsPolicy also succeed (as with ClusterFirst setting)


New version of apache commons pool cause problems with class loader.

Due to this lines of code:
https://github.com/apache/commons-pool/blob/trunk/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java#L605-L606
Jedis may throw
java.lang.ClassNotFoundException: org.apache.commons.pool2.impl.DefaultEvictionPolicy
error when creating JedisPool in class with other class loader than thread, like when we have master app and addons for it (and this apache library is shaded into addon), simple work around is just override context class loader:
Thread.currentThread().setContextClassLoader(this.getClass().getClassLoader());
but this may cause other problems depending on used software. (Other apps can change this loader etc)
Any possible fixes?

@GotoFinal any ideas if this problem has been reported to commons pools also?. What's their opinion about this?

@marcosnils
Commit with that change: https://github.com/apache/commons-pool/commit/3a3e763c90aa6bc04a0537b4480f9e005a45ba22
https://fisheye6.atlassian.com/changelog/commons?cs=1627022
But seems that they fixed it later again:
https://issues.apache.org/jira/browse/POOL-292
it is even visible here: (I don't know why I didn't saw this)
https://github.com/apache/commons-pool/blob/trunk/src/main/java/org/apache/commons/pool2/impl/BaseGenericObjectPool.java#L608
So the only issue is outdated version of library.

@GotoFinal Jedis uses commons-pool2 2.3 which I believe includes this fix. Is this still an issue?

@marcosnils No, fix was added in 2.4.1 as far as I see.

@GotoFinal you're correct. I guess we can upgrade commons-pool version then.
Thanks for pointing it out!. Would you mind crafting a PR?.

@varrix. You're using commons-pool2 2.4.x with Jedis correct?. Found any issues so far?

@yaojuncn @lboue thoughts?

weird, travis test failed?, it runs just fine on my small app, but I don't have any special code here ;/

@marcosnils Currently running:
// Java Redis client
compile group: 'redis.clients', name: 'jedis', version: '2.7.3', transitive: false, { ext { fatJarExclude = false } }
// Apache Commons-Pool2 for Jedis pooling
compile group: 'org.apache.commons', name: 'commons-pool2', version: '2.4.1', transitive: false, { ext { fatJarExclude = false } }

Have quelled any and all issues I've encountered so far. Although the farthest we use it right now is with the JedisPool. We don't make use of transactions, clusters, etc.


TimeMap random blink

Godot version:
Godot_v3.1.1
OS/device including version:
Windows7 x64
Issue description:
TimeMap random blink
Steps to reproduce:
Open and run the demo "Kinematic Character".
Click the game Window Title Bar to fouce on the Window.
See the video:
20191010144810rec.zip
Minimal reproduction project:
The demo "Kinematic Character" of Godot.

Duplicate of #9913


Add ability to mute video.

added mute flag to Mp4Composer with builder style.
added check for mute boolean in Mp4ComposerEngine
added checkbox in sample app to support muting
updated README.md usage table to show mute function

Thanks great pull request !!


Kibitz PR to #528

Basically "Looks pretty good to me"...
Sam, if you want to merge this and start deploy, I'm happy with that.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Warning

:warning:
Big PR: 808 lines of code changed

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #530 into master will decrease coverage by 0.08%.
The diff coverage is 66.31%.

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   68.88%   68.79%   -0.09%
==========================================
  Files         201      202       +1
  Lines       11129    11091      -38
==========================================
- Hits         7666     7630      -36
- Misses       2908     2909       +1
+ Partials      555      552       -3

Impacted Files
Coverage Δ

lib/deployer.go
100% <100%> (ø)
:arrow_up:

lib/resolver.go
95.23% <100%> (+15.57%)
:arrow_up:

lib/loggingprocessor.go
83.67% <33.33%> (+7.03%)
:arrow_up:

ext/singularity/deployer.go
70% <46.93%> (-1.96%)
:arrow_down:

lib/nameresolver.go
73.33% <55.55%> (+4.58%)
:arrow_up:

lib/deployable_pair.go
57.14% <57.14%> (ø)

lib/deployable_chans.go
80.48% <78.94%> (-7.75%)
:arrow_down:

lib/pipeline.go
72.72% <81.48%> (+1.61%)
:arrow_up:

lib/deployment_diff.go
94.94% <91.42%> (-3.43%)
:arrow_down:

lib/deploystate.go
0% <0%> (-33.34%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e355a85...b2f93d1. Read the comment docs.

I'm putting this through its paces by repeatedly running make test. So far I've run it 3 times, it passed first 2 but had the same issue as yesterday on the third run, so I'm going to keep going doing that until I'm happy it's no less stable than #528

OK, I've compared the 2 branches enough and there's no material difference, so getting this merged now, tx.


SIM105 should clean up unused variable after refactor

x = None
try:
    x = func_that_might_throw()
except AttributeError:
    pass
return x

is getting simplified to
x = None  # Variable "x" is not accessed
with contextlib.suppress(AttributeError):
    return func_that_might_throw()

If this is the first time we've seen x, can we clean up the null assignment?

Thanks for the report! Seems reasonable to me although it may be non-trivial.

I believe this works as expected, assuming you enable the right set of rules: ruff check foo.py --select SIM --select RET --select F -n --fix.
We like to treat each fix as independent. Here, the SIM105 rule gives you:
import contextlib
def f():
    x = None
    with contextlib.suppress(AttributeError):
        x = func_that_might_throw()

    return x

Then the RET rule simplifies to:
import contextlib
def f():
    x = None
    with contextlib.suppress(AttributeError):
        return func_that_might_throw()

Then the F rule identifies the unused variable:
import contextlib
def f():
    with contextlib.suppress(AttributeError):
        return func_that_might_throw()

(This all happens in one ruff invocation, I'm just breaking it down for clarity.)
Perhaps you have F841 disabled?

Ahh, @charliermarsh is correct.
unfixable = ["B007", "ERA001", "F841", "RUF100"]

We disabled autofix on F841 because variables are often temporarily unused while rearranging a file. We don't want an errant ⌘ + S to accidentally delete useful code. In this case, though, there's no danger since it's only unused as a result of the other (safe) autofixes.

@tylerlaprade I agree that seems like a fair use-case. We probably don't want to resolve this just for this specific rule though, instead we should work on a general solution that checks for unused variables introduced by an autofix.
Would you mind if I retitle this issue?

Yes, please do! I'm glad this could potentially turn out to be more generally applicable than just a single rule.

In the meantime, for this use-case, I'd recommend leaving F841 enabled in your configuration and only disabling it in the flags passed when used by the IDE. Would that help?

Yes, that's a good suggestion, thank you Zanie!

Ah, no luck - that same flag is used for the recursive fixes, so ⌘ + S still has the same behavior.

I think the suggestion was to leave you with a setup such that unused variables would be removed when running via the CLI, but not when running in the editor (which could happen "by accident").


Trying to bind key shows "unknown"

VSCode Version: 1.18.0
OS Version: Windows 10

Steps to Reproduce:

Open keybindings.json.
Press "Ctrl-X Ctrl-X" to add a keybinding
Press "Ctrl-X b"

Dialog says "unknown", and I cannot bind the key.

Reproduces without extensions: Yes

This does not reproduce for me on macOS.

Are you using a non-english keyboard layout?

These troubleshooting tips may be helpful: https://github.com/Microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-windows-keybindings

As a matter a fact I am using a non-english layout in that I make use of Keyman Desktop. It this could be made to work it would be nice (and in can be made to work because regular Emacs does get it right) but I understand that it may be more difficult in Electron.

@tger On our side, on Windows, we are using the keyCode property of the keydown event to do keybinding dispatching.
You can see the value we receive for this keyCode property when pressing the key and hovering over the input box.
What does VS Code detect when you press the desired key combination? Please hover over the input box and take a screenshot:

It just says "unknown":

It is possible to hover over the input box and see the keyCode number even for unknown.


NIFI-1474 Added validation for p in scrypt

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Added validation, used in constructor, and added unit tests.
Failing unit test TestListFile#testFilterAge but this is not related to my changes.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[x] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[x] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Reviewing...

Thanks for your first contribution. I have merged it and closed the ticket.


Bots somethimes go to the same PlatesCounter wasting time

Bots somethimes go to the same PlatesCounter and when no plates are ready to be taken they wait there untill a new plate spawns

this could be 'fixed' by using grid distance to chose which PlatesCounter to go to.
It won't really fix it if a lot of Bots are closer to a specific PlatesCounter, but should anyway help

Fixed using Manhattan distance and in case of same distance the counter with the highest ID


Nginx config

Hello, better check, what file exists on filesystem: http://leopard.in.ua/2013/11/23/rails-and-webp/

Using map and try_files is more lightweight and recommended by nginx: http://wiki.nginx.org/IfIsEvil

Yep, but instead server non-webp file (example: webp file was not converted), you redirect to 404 - it is invalid config for usage, because we still can show image.

I don't. Look at the line:
try_files $uri$webp_suffix $uri =404

It will first try to serve image.png.webp`` and if it does not exists it will try to serve image.png` (which was requested) and the if not found returns 404.

Oh, I don't looks at space between. But what about add_header Vary Accept?

Yeah, it tricked me first time I saw that too :) I took this example from https://github.com/uhop/grunt-tight-sprite/wiki/Recipe:-serve-WebP-with-nginx-conditionally
Don't know much about Vary Accept breaking IE. Can you send some examples?

http://jakearchibald.com/2014/browser-cache-vary-broken/ - this article wrote about this problem
https://www.igvita.com/2013/05/01/deploying-webp-via-accept-content-negotiation/ - how it solved by Ilya Grigorik, but here used nginx if for configs

Well we could also change the line with add_header Vary Accept; to:
if ($webp_suffix != "") {
    add_header Vary Accept;
}

What you think?

Yep, it is better, than set this header always.

Shall I create fresh, clean PR?

Nope, you can just rebase from current master to this pull request.

The thing is that I don't know how to do that :) Any hint?

git pull https://github.com/kavu/sprockets-webp.git in your branch.

thanks!

My pleasure! :)


SkiaSharp support is highly required to get rid of System.Drawing dependency, which will make FastReport cross-platforms again

Due to dependency on System.Drawing, FastReport.OpenSource became limited to Windows only.
As Commercial FastReport used SkiaSharp to solve the aforementioned issue,
SkiaSharp support in FastReport.OpenSource is highly required to get rid of System.Drawing dependency,
which will make FastReport cross-platforms again.

Hello!
To solve your problems you can use our demo packages FastReport.Core.Skia, FastReport.Web.Skia, and FastReport.SkiaDrawing.
Best regards,
Bogdan

Hello!
To solve your problems you can use our demo packages FastReport.Core.Skia, FastReport.Web.Skia, and FastReport.SkiaDrawing.
Best regards, Bogdan

The open source version creates a DEMO_VERSION in top left of PDF export. It is usable.
But this demo versions replace random values of my report with Demo version, making the reports unusable.


Quasar variant implementation

Hey @Yagua! Hope you are doing great. First of all I want to praise the great job you have done with Nebulous.nvim, since this project is one of my favorite and personally used in my day to day since it makes my work inside Nvim more comfortable. On the other hand, today I want to make a contribution to the project by contributing a light variant called "quasar" for all those who like and enjoy this kind of color themes and, of course, to contribute to the growth of Nebulous.

Wow, thank you very much for your PR, it is really very welcome.
Merged


Is it possible to ignore extra keys?

I have a hotkey set to command+s and I press command+v shortly before it, because I want to insert text, then the command+sshortcut is being ignored, because it tries to execute command+v+s. Is there a way to ignore extra keys pressed?

I just found out, that the *is supported.

Unfourtunately the combination with the asterisk doesn't work, because now the hotkey is triggered everytime regardless of the key combination.


[2.12.0] Upgrade to sbt 0.13.13

I would suggest we leave the 2.12.0 build where it is. Everything is frozen there.


⚠ WSINGRESOS - OXXO has degraded performance

In a41e26d, WSINGRESOS - OXXO (https://srvshyweb.yucatan.gob.mx/cgi-bin/wspd_cgi.sh/WService=wsingresos/internet/compartido/wspagosoxxo.r) experienced degraded performance:

HTTP code: 200
Response time: 24137 ms

Resolved: WSINGRESOS - OXXO performance has improved in 0f561d6.


The IPhotinoWindow interface should not refer to an implementation.

I have created a remoteable BlazorWebView (see https://github.com/budcribar/RemoteBlazorWebView) based on the work that Steve Sanderson and Jan-Willem Spuij have done. I would also like to reimplement a Remoteable WebWindow based on the photino window. However, in order to do that, I will need to reimplement the IPhotinoWindow interface which would require a change to the interface. Currently, the IPhotinoWindow interface depends on the PhotinoWindow class instead of IPhotinoWindow. This pull request contains the changes necessary for me to start on the conversion. I can be reached at<EMAIL_ADDRESS>if you have questions.

Hi @budcribar!
That's a great catch, thank you for your contribution!
Just one thing, I saw that the search & replace also replaced the string "PhotinoWindow" with "IPhotinoWindow" in comments and the log output. Would you mind to revert the changes in those places and target the PR against our debug branch?
I'll make sure to get this in with the next release!

Closed to make on Debug branch


TLS hostname validation logic does not support subjectAltName with IP records

If I am running a custom certificate authority I might want to generate a TLS certificate that encodes its subjectAltName using an IP address (iPAddress in https://tools.ietf.org/html/rfc5280#section-<IP_ADDRESS>). this is useful when I do not have DNS records for servers in my application but I still want to validate identity.
Unfortunately, the hostname validation logic requests uses does not validate these records. It only validates DNS records within subjectAltName.

You are entirely correct. This likely applies a bit more broadly than requests: we pulled this algorithm out of the standard library, which means it is likely affected. Similarly, I checked service_identity, and I believe it may also not handle this appropriately.
Can I get some input from @reaperhulk, @hynek, and @tiran about whether that assessment is right?

Please note that I believe if you set the IP as a dNSName this will work correctly. This is quite a common practice, plenty of browsers have (and have had) similar limitations, so many iPAddress fields are duplicated in dNSName fields. That is technically poor practice, but it's a common work-around.

We filed issue with service_identity too (https://github.com/pyca/service_identity/issues/12).
We can't use the workaround of putting IP in dNSName because that blows up service_identity :wink:.

Yeah IP in dNSName is an (unfortunately) common thing. service_identity definitely needs to support iPAddress but probably will need to loosen its restrictions on dNSName as well...

Ok then, so I think the first priority here is working out whether or not this is a problem in the stdlib as well. @tiran?

AFAIK an IP in dNSName is invalid pre RFC?  IIRC it’s okay in commonName.

It is definitely invalid. Unfortunately, browsers have previously had problems where they allowed IP addresses in dNSName, but didn't use the iPAddress field, so you could expect to see certificates of that form.

Has anybody seen a cert with an IP address in the wild? I've never seen one that is signed by a public CA.
Yes, the stdlib doesn's support ipAddress. It only validates dNSName. It also uses server_hostname for two jobs: SNI and host name validation. That is going to make it more tricky...

Oooof. Thanks @tiran. For the moment I'll leave the stdlib in your hands, I think we should update the algorithm we've back ported to add this support. I'll take a look at this today and see if I can extend it.

I just checked how OpenSSL 1.0.2 has implemented the checks:

OpenSSL supports multiple host names (X509_VERIFY_PARAM_add1_host() and X509_VERIFY_PARAM_set1_host()). One of the host in the host list must match. The matching host name can be accessed with X509_VERIFY_PARAM_get0_peername()
OpenSSL has a couple of extra flags like X509_CHECK_FLAG_ALWAYS_CHECK_SUBJECT and X509_CHECK_FLAG_NO_WILDCARDS
For IP address and S/MIME email address only one address of each is supported
If both IP address and hosts are set, then BOTH are validated.
If no host and no IP address is set, then the check passes.

As for s_i, adding non-RFC conform behavior that weakens the security is out of question unless I’ll get overwhelming proofs that it is a problem in real life.
If someone wants to help with pyca/service_identity#12 be my guest. :)

Oh, this is fun: we actually can't validate the iPAddress when using the stdlib ssl module because it doesn't return iPAddress fields from the SAN extension. That's extremely unfortunate. We can still add support for it from pyOpenSSL though, and require that people use pyOpenSSL when they want to do this validation.

Mozilla's NSS library doesn't support IP addresses in dNSName either: https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/certdb/certdb.c#1427

FYI 1: http://bugs.python.org/msg244665
FYI 2: https://tools.ietf.org/html/rfc3546#page-9
Literal IPv4 and IPv6 addresses are not permitted in "HostName".

I'd be interested in seeing what a browser developer thinks is the "right thing" in this case since the reality of what is required for validation is sometimes at odds with RFCs. Unfortunately I don't know any on GitHub so I'm not sure who to CC ;)

I could try to get in contact with NSS developers at Red Hat.
And there are  Ryan Sleevi and Adam Langley from Google and the Chromium project.

@tiran the use case is only for private CAs. Can't imagine a public CA would sign an IP, yes.

@Lukasa do you think cURL handles this? Should we give Daniel a ping?

Why not. @bagder?

Ok, here's a response from the "there's no such thing as a simple answer" department:

I don't think I've ever actually seen such a cert used
curl supports roughly speaking a bazillion TLS backends and most of them feature their own name checking functions so then we use those and then we of course rely on them doing this check correctly.
OpenSSL is the by far mostly used TLS backend with curl and for this we of course have written our own verifying code and yes, we do check 'iPAddress' fields[1]. But please consider my point (1) again for this.

[1] = https://github.com/bagder/curl/blob/master/lib/vtls/openssl.c#L1211

@bagder thanks so much. :cake:
Ok, with Daniel's point 1 in mind, I still think we should aim to do this if possible. I don't believe we need to do it on both of our SSL backends (stdlib and PyOpenSSL), but if we can make it possible in our PyOpenSSL backend I think we should. That will allow users who desperately need this function to achieve it, but we won't bend over backwards to make this available to all our users.

It's worth noting that cURL's implementation doesn't do anything particularly clever on IP address checking, which bodes well for us. I do think we need to normalise the IP address though, and that may be somewhat painful (the stdlib doesn't provide any function that does that I think, though I'll check).

If by normalize you're referring to RFC 3986's definition of normalization, we can steal code from rfc3986
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Ok, having made a tweak to urllib3's match_hostname function I've now discovered that we don't use it if there is a match_hostname function available in the standard library. Which is unfortunate.

Actually, I think this just means that until the standard library does this, we can't. Closing until the Python stdlib is capable of doing something with iPAddress fields.


Let arduino-cli decide library specification

Demonstrates a possible bug in arduino-cli

Depends on https://github.com/arduino/arduino-cli/issues/1092 I think

Reading the discussion, would it not make sense to create four test repositories under https://github.com/Arduino-CI/ to have some known reference points to use for testing this? E.g.
FooLibLegacy1
|_ FooLib1.h

FooLibLegacy2
|_ src
    |_ FooLib2.h

FooLibNonLegacy3
|_ library.properties
|_ FooLib3.h

FooLibNonLegacy4
|_ library.properties
|_ src
    |_ FooLib4.h

@hlovdal I do have something resembling that already:

https://github.com/Arduino-CI/arduino_ci/tree/master/SampleProjects/OnePointOhDummy
https://github.com/Arduino-CI/arduino_ci/tree/master/SampleProjects/OnePointFiveDummy
https://github.com/Arduino-CI/arduino_ci/tree/master/SampleProjects/OnePointFiveMalformed


⚠ Orpheus has degraded performance

In 75fc6a9, Orpheus ($OPS) experienced degraded performance:

HTTP code: 502
Response time: 8202 ms

Resolved: Orpheus performance has improved in d58d687 after 6 minutes.


Using pagination to the list_releases() by using offset

Thanks for your PR!

Thanks for your PR!


add license to contrib repo

like suggested in issue https://github.com/Itseez/opencv_contrib/issues/302

Let's do this :smile:

thank you! and sorry for delay :+1:


Connect to SQL Server without app registration

Is it possible to connect to Azure SQL Server without registering app using Azure AD user? We are trying to create simple Windows Forms app for some administrative tasks.
It should be possible, because SSMS offers exact same feature "Universal with MFA support". I have been searching around and found nothing useful; any direction would be much appreciated.
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 692d8637-4033-767b-aa29-3859f301b7b8
Version Independent ID: de143a26-3dd6-a513-6854-604e4f68c52f
Content: ActiveDirectoryInteractive connects to SQL
Content Source: articles/sql-database/active-directory-interactive-connect-azure-sql-db.md
Service: sql-database
Sub-service: security
GitHub Login: @GithubMirek
Microsoft Alias: MirekS

Hi @matjazmav - Thank you for your feedback! We will review and update as appropriate.

@matjazmav Only with SQL Authentication. Universal with MFA is still an Azure Active Directory authentication method. In fact, it is more secure than AAD Auth by itself. Please see the following: The five authentication options (link).

@Mike-Ubezzi-MSFT We are planning to use our tool across different AD domains and we are trying to avoid registering our tool in each AD domain. So we would like implement authentication exactly like in SSMS "Universal with MFA support" that we can use to connect without explicitly allowing SSMS to access Azure SQL Server resource.

I will investigate this but can you please detail how you are accessing your Azure SQL Database via SSMS? Did you establish an Azure Active Directory Admin for this same Azure SQL Database instance, and are you using this account in your scenario? If not, what user is being leveraged to access the database instance via SSMS?
Please be as detailed as possible so that I gain a clear understanding of the current behavior.
Thank you,
Mike
Get Outlook for Androidhttps://aka.ms/ghei36

From: Matjaž Mav<EMAIL_ADDRESS>Sent: Saturday, July 6, 2019 5:10:31 AM
To: MicrosoftDocs/azure-docs
Cc: Mike Ubezzi; Mention
Subject: Re: [MicrosoftDocs/azure-docs] Connect to SQL Server without app registration (#34555)
@Mike-Ubezzi-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMike-Ubezzi-MSFT&data=02|01|mike.ubezzi%40microsoft.com|023a4a6989b84dcf106408d7020af170|72f988bf86f141af91ab2d7cd011db47|1|0|636980118337819376&sdata=KqUOot7H1AhHNHgBlYi8NFOqKt641anoUDA4yg6bP8M%3D&reserved=0 We are planning to use our tool across different AD domains and we are trying to avoid registering our tool in each AD domain. So we would like implement authentication exactly like in SSMS "Universal with MFA support" that we can use to connect without explicitly allowing SSMS to access Azure SQL Server resource.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F34555%3Femail_source%3Dnotifications%26email_token%3DAI3H7WW4T7L5VGZWLMM3B53P6CDTPA5CNFSM4H53VH62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZKYPQA%23issuecomment-508921792&data=02|01|mike.ubezzi%40microsoft.com|023a4a6989b84dcf106408d7020af170|72f988bf86f141af91ab2d7cd011db47|1|0|636980118337829367&sdata=87DuppRK2VhWmcc%2BUmaPXlvPwVsbZtpU%2FzEtOCBwIr0%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAI3H7WWKMVUQWTJAGJZQQXDP6CDTPANCNFSM4H53VH6Q&data=02|01|mike.ubezzi%40microsoft.com|023a4a6989b84dcf106408d7020af170|72f988bf86f141af91ab2d7cd011db47|1|0|636980118337839363&sdata=M%2FxPHandh0flbW%2F5OCQhwVGA37kSX9QeVG%2FhF8%2B6R%2Bk%3D&reserved=0.

@Mike-Ubezzi-MSFT We configured just firewall and set AAD admin for Azure SQL Server. Then we can simply connect with SSMS providing AAD login, then browser popup opens asking for password and that is it (user is not prompt for consent to allow access to any specific Azure resource).
We also can login with users added afterwards like this:
CREATE USER<EMAIL_ADDRESS>FROM EXTERNAL PROVIDER;

It also work for guest AAD users, but you have to specify "AD domain name or tenant ID" under "Connection Properties" in SSMS.

@matjazmav Thank you for this detail. The reason this work is because SSMS meets the client requirements as detailed here. If you are running an Azure App Service and these minimum client requirements cannot be met, then you must leverage an app registration process to ensure that the source is trusted. I believe this is the case here.

@Mike-Ubezzi-MSFT Well, I should meed this requirements, because I have installed SSMS 17.9.1, VS 16.1.3 and also tool is based on net472 framework, because at least net471 is required for ActiveDerictoryInteractive authentication mode.
Also couldn't find code example how to connect to without specifying clientId parameter.
My guess is that SSMS uses more privileged Azure API (available only to the MS applications) that can access Azure SQL Server without explicitly registering it?

@matjazmav The closest you can replicate this functionality is to run your application on an Azure virtual machine where this VM is part of the same Azure Active Directory tenant you Azure SQL Database AAD Admin is part of. Question for you. Is the login credential used to access the client host where SSMS is being used to access your deployed instance of Azure SQL Database also the same account ID used to login to the Azure Portal? I believe this is the case. So, by registering an App ID you gain the same level of trust.

@matjazmav We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Add background-color using linear gradient on shorten button

Add some mixed background-color to the shorten button.

Okay ! Try this out

This issue has been inactive for a long time
I would like to work on this issue
Please assign

@Kalivarapubindusree @sagnik-p Actually , No need of it now


installed cauchy-mult but does not work

I installed cauchy-mult following the description "going to extensions/cauchy/ and running python setup.py install.".
But when I run the 'sashimi.py' to investigate its structure. This message shows again "CUDA extension for cauchy multiplication not found. Install by going to extensions/cauchy/ and running python setup.py install. This should speed up end-to-end training by 10-50%"
I installed pykeops==1.5 first.

That's strange. First, perhaps try uninstalling pykeops to be safe (I don't use it anymore). Second, check if the extension exists with pip list | grep cauchy. If it does, try reinstalling with pip uninstall -y cauchy-mult && pip install . (inside the extensions folder), and then check again if pip finds it. Then try opening a Python REPL and checking if you can import the extension (import cauchy_mult).

Thank you. When I install cauchy in another workstation, I met this issure
python setup.py install

running install
running
bdist_egg
running egg_info
writing cauchy_mult.egg-info/PKG-INFO
writing dependency_links to cauchy_mult.egg-info/dependency_links.txt
writing top-level names to cauchy_mult.egg-info/top_level.txt
reading manifest file 'cauchy_mult.egg-info/SOURCES.txt'
writing manifest file 'cauchy_mult.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_ext
/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/utils/cpp_extension.py:788: UserWarning: The detected CUDA version (11.5) has a minor version mismatch with the version that was used to compile PyTorch (11.3). Most likely this shouldn't be a problem.
warnings.warn(CUDA_MISMATCH_WARN.format(cuda_str_version, torch.version.cuda))
building 'cauchy_mult' extension
Emitting ninja build file /home/ubuntu0/Downloads/YuTian/extensions/cauchy/build/temp.linux-x86_64-3.7/build.ninja...
Compiling objects...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/1] /usr/bin/nvcc  -I/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/include -I/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/include/TH -I/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/include/THC -I/home/ubuntu0/anaconda3/envs/rftorch/include/python3.7m -c -c /home/ubuntu0/Downloads/YuTian/extensions/cauchy/cauchy_cuda.cu -o /home/ubuntu0/Downloads/YuTian/extensions/cauchy/build/temp.linux-x86_64-3.7/cauchy_cuda.o -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr --compiler-options ''"'"'-fPIC'"'"'' -O2 -lineinfo --use_fast_math -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="gcc"' '-DPYBIND11_STDLIB="libstdcpp"' '-DPYBIND11_BUILD_ABI="cxxabi1011"' -DTORCH_EXTENSION_NAME=cauchy_mult -D_GLIBCXX_USE_CXX11_ABI=0 -gencode=arch=compute_86,code=compute_86 -gencode=arch=compute_86,code=sm_86 -std=c++14
FAILED: /home/ubuntu0/Downloads/YuTian/extensions/cauchy/build/temp.linux-x86_64-3.7/cauchy_cuda.o
/usr/bin/nvcc  -I/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/include -I/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/include/TH -I/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/include/THC -I/home/ubuntu0/anaconda3/envs/rftorch/include/python3.7m -c -c /home/ubuntu0/Downloads/YuTian/extensions/cauchy/cauchy_cuda.cu -o /home/ubuntu0/Downloads/YuTian/extensions/cauchy/build/temp.linux-x86_64-3.7/cauchy_cuda.o -D__CUDA_NO_HALF_OPERATORS -D__CUDA_NO_HALF_CONVERSIONS_ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr --compiler-options ''"'"'-fPIC'"'"'' -O2 -lineinfo --use_fast_math -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=cauchy_mult -D_GLIBCXX_USE_CXX11_ABI=0 -gencode=arch=compute_86,code=compute_86 -gencode=arch=compute_86,code=sm_86 -std=c++14
/usr/include/c++/11/bits/std_function.h:435:145: error: parameter packs not expanded with ‘...’:
435 |         function(_Functor&& __f)
|                                                                                ^
/usr/include/c++/11/bits/std_function.h:435:145: note:         ‘_ArgTypes’
/usr/include/c++/11/bits/std_function.h:530:146: error: parameter packs not expanded with ‘...’:
530 |         operator=(_Functor&& __f)
|                                                                                ^
/usr/include/c++/11/bits/std_function.h:530:146: note:         ‘_ArgTypes’
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1746, in _run_ninja_build
env=env)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/subprocess.py", line 512, in run
output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "setup.py", line 24, in
cmdclass={'build_ext': BuildExtension})
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/setuptools/init.py", line 153, in setup
return distutils.core.setup(**attrs)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/core.py", line 148, in setup
dist.run_commands()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/dist.py", line 966, in run_commands
self.run_command(cmd)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/setuptools/command/install.py", line 67, in run
self.do_egg_install()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/setuptools/command/install.py", line 109, in do_egg_install
self.run_command('bdist_egg')
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/setuptools/command/bdist_egg.py", line 164, in run
cmd = self.call_command('install_lib', warn_dir=0)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/setuptools/command/bdist_egg.py", line 150, in call_command
self.run_command(cmdname)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/setuptools/command/install_lib.py", line 11, in run
self.build()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/command/install_lib.py", line 107, in build
self.run_command('build_ext')
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/cmd.py", line 313, in run_command
self.distribution.run_command(command)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/dist.py", line 985, in run_command
cmd_obj.run()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/setuptools/command/build_ext.py", line 79, in run
_build_ext.run(self)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/command/build_ext.py", line 340, in run
self.build_extensions()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 741, in build_extensions
build_ext.build_extensions(self)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/command/build_ext.py", line 449, in build_extensions
self._build_extensions_serial()
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/command/build_ext.py", line 474, in _build_extensions_serial
self.build_extension(ext)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/setuptools/command/build_ext.py", line 196, in build_extension
_build_ext.build_extension(self, ext)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/distutils/command/build_ext.py", line 534, in build_extension
depends=ext.depends)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 571, in unix_wrap_ninja_compile
with_cuda=with_cuda)
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1424, in _write_ninja_file_and_compile_objects
error_prefix='Error compiling objects for extension')
File "/home/ubuntu0/anaconda3/envs/rftorch/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1756, in _run_ninja_build
raise RuntimeError(message) from e
RuntimeError: Error compiling objects for extension

Your environment looks very out of date (e.g. python 3.7, pytorch 11.3)


Possible to get additional functions?

Hi!
Just wanted to say thank you for developing this library. Its been extremely useful!
Would it be possible to get additional functions added to this library.

drawLineSegment(ImVec3 p1, ImVec3 p2) - draws a line segment with the two circles on the end. The one that gets drawn when you move the translation gizmo. Could probably have additional input arguments to set the size/color of the circles

drawArrow( ImVec3 p_start, ImVec3 p_end, color) - draws the arrow that is used for the translation gizmo

Having an ability to detect if the mouse is over or has clicked on the line segment or arrow would be useful as well.
Thanks

I'd be happy to review your PR :)
immediate GUI mode would 'require' drawArrow and drawLineSegment to return true if user clicked over. I think returning an enum {Hover, clicked} can be good as well.

I'll see what I can do :)

Sorry for no PR, but here's some extracted code that can be placed into the ImGuizmo.cpp file.  Both functions return true if the mouse is over the line. Most of the code is just extracted from your current source and put into separate functions.
  // in ImGuizmo.h

   bool drawArrow(ImVec2 const & p1,
                  ImVec2 const & p2,
                  unsigned int color, // ImGuizmo.h does not include imgui.h, can't use ImU32
                  float lineThickness,
                  float arrowHeadSize);

   bool drawArrow(ImVec2 const & p1,
                  ImVec2 const & p2,
                  unsigned int color=0xAAAAAAAA);

   bool drawLineSegment(ImVec2 const &p1,
                      ImVec2 const & p2,
                      unsigned int color=0xAAAAAAAA);

   bool drawLineSegment(ImVec2 const &p1,
                      ImVec2 const & p2,
                      unsigned int color,
                      float lineThickness,
                      float endPointThickness,
                      unsigned int endPointColor,
                      float endPointRadius);

// in ImGuizmo.cpp

   // signed distance field for a capsule, used for checking
   // mouse intersection with line
   // https://www.iquilezles.org/www/articles/distfunctions/distfunctions.htm
   static float sdCapsule( vec_t p, vec_t a, vec_t b, float r )
   {
     vec_t pa = p - a, ba = b - a;

     float h = Clamp( pa.Dot(ba)/ba.Dot(ba), 0.0f, 1.0f );
     return (pa - ba*h).Length() - r;
   }

   bool drawArrow(ImVec2 const & p1,
                  ImVec2 const & p2,
                  ImU32  color,
                  float lineThickness,
                  float arrowHeadSize)
   {
       ImDrawList* drawList = gContext.mDrawList;

       drawList->AddLine(p1, p2, color, lineThickness);

       // Arrow head begin
       ImVec2 dir(p1-p2);

       float d = sqrtf(ImLengthSqr(dir));
       dir /= d; // Normalize
       dir *= 6.0f;

       ImVec2 ortogonalDir(dir.y*arrowHeadSize, -dir.x*arrowHeadSize); // Perpendicular vector
       ImVec2 a(p2 + dir*arrowHeadSize);
       drawList->AddTriangleFilled(p2 - dir, a + ortogonalDir, a - ortogonalDir, color);

       auto & io = ImGui::GetIO();
       auto mP = io.MousePos;
       return sdCapsule( {mP.x,mP.y,0,0}, {p1.x, p1.y,0,0}, {p2.x,p2.y,0,0}, lineThickness) < 0.0f;
   }

   bool drawArrow(ImVec2 const & p1,
                  ImVec2 const & p2,
                  ImU32  color)
   {
       return drawArrow(p1,p2, color, 3.0f, 1.0f);
   }

   bool drawLineSegment(ImVec2 const & p1,
                        ImVec2 const & p2,
                        unsigned int color,
                        float lineThickness,
                        float endPointThickness,
                        unsigned int endPointColor,
                        float endPointRadius)
   {
       vec_t dif = { p2.x - p1.x, p2.y - p1.y, 0.f, 0.f };
       dif.Normalize();
       dif *= 5.f;

       ImDrawList* drawList = gContext.mDrawList;
       drawList->AddCircle(p1, endPointRadius, endPointColor, 0, endPointThickness);
       drawList->AddCircle(p2, endPointRadius, endPointColor, 0, endPointThickness);
       drawList->AddLine(ImVec2(p1.x + dif.x, p1.y + dif.y), ImVec2(p2.x - dif.x, p2.y - dif.y), color, lineThickness);

       auto & io = ImGui::GetIO();
       auto mP = io.MousePos;

       return sdCapsule( {mP.x,mP.y,0,0}, {p1.x, p1.y,0,0}, {p2.x,p2.y,0,0}, lineThickness) < 0.0f;
   }

   bool drawLineSegment( ImVec2 const & p1,
                       ImVec2 const & p2,
                       unsigned int color)
   {
        return drawLineSegment( p1, p2, color,
                              2.0f,
                              1.0f,
                              color,
                              6.0f);
   }

Can you use uint32_t instead of unsigned int?
ImDrawList* drawList = gContext.mDrawList; implies a call to imguizmo::manipulate or the context will not be updated. I was thinking of adding 2 new functions: Imguizmo::begin and imguizmo::end and add an override on manipulate that will not need view/projection matrices. whereas begin will need those matrices and will build the context.
I believed you want 3D vectors for drawLineSegment. only 2d is enough? Can we provide a version with 3D that will use the view.projection matrices ?

I didn't use uint32_t because the cstdint header wasn't included in the imguizmo, but that can easily be changed.
I chose to stick with the 2D version because it was pretty trivial to convert my 3D  vectors into 2D. That way I didn't have to pass the matrices into the function.  I copied the worldToPos function into my code and changed it to use glm::mat4 to work better with my engine. You might need to expose that function to the user to be able to easily convert from 3D to 2D. Feel free to change the code however you want to make it fit with your design.
I have a working version of drawing the lines/vectors that integrates with my engine using the above code I posted, so you don't have to include any of this into your library if you do not feel it's necessary. I just thought it might be useful to some people.

Also, add an option (with a checkbox) in the sample to show an example using these new functions :)


Update slf4j-simple to 2.0.11

About this PR
📦 Updates org.slf4j:slf4j-simple from 2.0.9 to 2.0.11
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.0.9).
You might want to review and update them manually.
docs/plugins/make.md
project/scoverage.sbt

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.slf4j", artifactId = "slf4j-simple" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.slf4j", artifactId = "slf4j-simple" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

Superseded by #1940.


Fix require path for puppeteer-core 5.2.x

Fixes #154 .
It was already handled for puppeteer full version with commit f4d1fed53f0a20782900483b7c11539ba13faad9, but the path for puppeteer-core was not fixed.

closes: #158

Is this going to be merged soon?

Dear @alixaxel, if you are so kind and could merge this bugfix soon?
We would really appreciate it, as this is blocking a lot of people from using your nice project ;).

Yes Please @alixaxel
Also thanks @h1f1x @tomanagle @ik1ne for fixing and keeping track of this.

@h1f1x Apologies, work has been keeping me super busy lately - thanks for the heads up.
@ik1ne Thank you, I will be publishing a patch version with this shortly.


added loading/saving using a reader/writer

Is needed for https://github.com/manticoresoftware/columnar/pull/65 and https://github.com/manticoresoftware/manticoresearch/pull/2354

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


python311Packages.pipdeptree: 2.15.1 -> 2.16.0

Diff: https://github.com/tox-dev/pipdeptree/compare/refs/tags/2.15.1...2.16.0
Changelog: https://github.com/tox-dev/pipdeptree/releases/tag/2.16.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 293218 run on x86_64-linux 1

2 packages built:

python311Packages.pipdeptree
python311Packages.pipdeptree.dist


Merge to live

Adding an article detailing the TS restrictions for Scripts

Apply suggestions from code review

Co-authored-by: Elizabeth Samuel<EMAIL_ADDRESS>Co-authored-by: Elizabeth Samuel<EMAIL_ADDRESS>

Docs Build status updates of commit d291dc7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/develop/typescript-restrictions.md
:white_check_mark:Succeeded
View

docs/images/explicit-any-editor-message.png
:white_check_mark:Succeeded
View

docs/images/explicit-any-error-message.png
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Container does not respect safe are bottom inset on iPhone X

When popup is presented as bottomSheet, the content is pushed lower than it should be on iPhone X.
On gif attached below:
• big green button is properly pinned to the bottom edge of safe area
• container view's background is tinted red to indicate wrong offset as I pull it up

Suggestion / food for thought
iPhone X's form factor obviously present entirely new design challenge to STPopup (and edge-to-edge designed elements generally).
It would be amazing to have a style called .bottomFormSheet, that would effectively be a .formSheet, but pinned down to the bottom edge of safe area with a configurable insets.
The result could pretty much look like this from Apple.

@jakubheglas it's actually not wrong offset. The extra height is intended for bottom sheet style popup when you drag the bottom sheet up. See https://github.com/kevin0571/STPopup/blob/master/STPopup/STPopupController.m#L526
But you are right, the current implementation for bottom sheet is not perfect for iPhone X. Will see how to fix this without introducing a new style.

Oh, I absolutely understand the increased space because of the intentional drag!
Let me rephrase: In the gif, the height of area which is represented by red color, should be added to STPopupBottomSheetExtraHeight. I assume safeAreaInsets.bottom should help there.

Hi,
I'm facing same issue on iPhone x, does anyone solve it?

@kevin0571 did you resolve this issue?

Fixed in 1.8.4


feat(ci): upgrade devDependencies

release に失敗するので依存関係をアップグレード

:tada: This PR is included in version 3.0.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Add preview for draw io diagrams

Describe the feature you'd like
In our work we use wide charts.
Now to see them - you have to press edit and see the details there
I would like to press a button and be able to view the diagram as a picture (with the ability to scroll)
Describe the benefits this would bring to existing BookStack users
Allow everyone to view wide charts
Can the goal of this request already be achieved via other means?
I supposed yes
Just with extra zoom for picture
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
6 months to 1 year
Additional context
No response

Thanks for the request @mv-yurchenko. I feel the fundamental request here is already covered by #1548 so I'm going to close this off to de-duplicate requests.


VAC's New Anti-Cheat Measures

Just a question, Is Osiris affected by these new future update AC measures? If so then how? I understand that VAC doesn't have a signature for Osiris just yet but does this new update really matter?

Nvrmind, I got my answer from a duplicate :)


.ammy file reformat + formatting options

Hi!
I very needed the document reformat feature as having to manually format thousands of lines of code is no way timesaving than having XAML with ReSharper (where I can select the project root and ask it to reformat/cleanup all the files in the project).
Also I would like to have a formatting options for brackets style - some people absolutely cannot live with "Egyptian" K&R style brackets.
Regards!

Reformatting shouldn't be to difficult to implement. Although there is not Options window for Ammy at the moment so I would have to create one.

Done! Updated NuGet package + Extension will be published by the end of the week.


Please invite me to the GitHub Community Organization

Name
aybanda
Discord Username (if applicable)
No response
Additional Context
exploring the community of developers and found this as interesting

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."


chore(deps): update devdependency vite to ^5.4.3

This PR contains the following updates:

Package
Type
Update
Change

vite (source)
devDependencies
patch
^5.4.2 -> ^5.4.3

Release Notes

vitejs/vite (vite)
v5.4.3
Compare Source

fix: allow getting URL of JS files in publicDir (#17915) (943ece1), closes #17915
fix: cjs warning respect the logLevel flag (#17993) (dc3c14f), closes #17993
fix: improve CJS warning trace information (#17926) (5c5f82c), closes #17926
fix: only remove entry assets handled by Vite core (#17916) (ebfaa7e), closes #17916
fix: waitForRequestIdle locked (#17982) (ad13760), closes #17982
fix(css): fix directory index import in sass modern api (#17960) (9b001ba), closes #17960
fix(css): fix sass file:// reference (#17909) (561b940), closes #17909
fix(css): fix sass modern source map (#17938) (d428e7e), closes #17938
fix(deps): bump tsconfck  (#17990) (8c661b2), closes #17990
fix(html): rewrite assets url in
fix(preload): add crossorigin attribute in CSS link tags (#17930) (15871c7), closes #17930
chore: reduce diffs with v6 branch (#17942) (bf9065a), closes #17942
chore(deps): update all non-major dependencies (#17945) (cfb621e), closes #17945
chore(deps): update all non-major dependencies (#17991) (0ca53cf), closes #17991

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Hywax Assistant.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3f32c00) to head (92a407d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines          146       146
  Branches        26        26
=========================================
  Hits           146       146

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore: removed Translate unsupported samples

Devsite update: cl/364663635
go/cloud-ai-2021-snippet-cleanup

Failures are unrelated and being tracked:

Datastore: #1291
Assert #1295


Update Chai dependency to support Chai 3.2.0

Latest Chai is 3.2.0, which is breaking the semver spec of<EMAIL_ADDRESS><3.0.0' that nock currently asks for, would be nice to fix this if no breaking changes from Chai side

Fixed by b73b6032


Fix: bb-a-usd v2 added to feeDistrubutor token list

Description
We support two versions of bb-a-USD token. On claims page, only v1 is showing up. After this merge request, both versions of the token are visible.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency changes
[ ] Code refactor / cleanup
[ ] Documentation or wording changes
[ ] Other

How should this be tested?
Go to claims page and you should see both versions of bb-a-USD and be able to claim them.
Visual context
N/A
Checklist:

[x] I have performed a self-review of my own code
[x] I have requested at least 2 reviews (If the PR is significant enough, use best judgement here)
[x] I have commented my code where relevant, particularly in hard-to-understand areas
[ ] If package-lock.json has changes, it was intentional.
[x] The base of this PR is master if hotfix, develop if not

@Matthews3301 Could you make this a hotfix?


Added support for grouping repositories.

As requested per issue #134
NOTE: This does not affect the file-system (yet).

Thanks for the PR - I made a few comments, have a look and after few small modifications I'll be happy to merge.

Do you want me to overwrite the branch or just push a second commit with the changes?

Another commit is fine - but merge master as there is one small change that disables automatic merge.

Just to be clear, you mean I commit and push my change directly into master on my side, which would prevent an additional merge on yours?

I figured out what you meant, didn't notice the updates on your master. Its 5:30AM over here, should probably call it a day, hehe :P

Looking good, thank you :)


Use Github deployment API

It would be very nice if kudu could mark a PR as deployed when the source control is github powered.
I'd be happy to work on that, if you agree.

Tracked by #958. Unfortunately, we have not been able to get to that, but we can discuss!


x/vuln: Show which packages are being scanned

To help developers establish trust that govulncheck is behaving as they expect, we should include an option to show what it is scanning and how recent the vulnerability information it's checking against is. This could be part of verbose mode, though there might be a short summary that would also make sense for the default output.
As an example, we could print a list of all packages that were scanned and the timestamp of the vulndb that was used to scan them.

Also tracked in #56501. (keeping that one open due to an active discussion)


detecting loadProducts network errors

Hi,
I really needed this feature, so here is my own PR (instead of the #85 )
It's basically the same, enhanced with your review.

thanks :)


Pull request with type [CREATE] for user [Jing099] and object type [Baseline] - titled [TestBaseline12809714]

Automated pull request from the Endpoint Configuration Manager Community hub.

drop it


chore: update game bridge to 1.46.10

Update game bridge (build from ts-immutable-sdk version 1.46.10)

Closing, there is a new version available: https://github.com/immutable/unreal-immutable-sdk/pull/123


Adding new option to hide top rather than bottom in a waterfall

This implements #1594.
@addyosmani PTAL!

FWIW: LGTM

An @surma LGTM also works :) Thanks!


luci-lib-httpprotoutils: add airplay mime types

Airplay of a statically hosted video file from one Apple device to another fails due to unrecognized content-type. Adding Airplay supported mime types fixes the issue.
Signed-off-by: Sasha Andonov<EMAIL_ADDRESS>

Related to openwrt/openwrt#11871

Related to openwrt/openwrt/pull/11871


Mplayer idea

Hi. I have been giving the mplayer https issue some thought and came up with that ffmpeg can do https, and youtube-dl can get the vids etc, for example:
mplayer "ffmpeg://$(youtube-dl -f best -g https://www.youtube.com/watch?v=xCxHvNl9MmQ)"
If you do not intent to use this option in future versions, do you have an idea on how to add these lines to /home/USER/.config/youtube-viewer/gtk-youtube-viewer.conf ?
Mplayer is so easy to configure and works just fine on my cubietruck. mpv just sucks, even properly built from source :-/ mpv-build ...
I would be soo greatful.
Cheers.

Hi,
Nice discovery! :-)
To use this with youtube-viewer, add the following entry to video_players in ~/.config/youtube-viewer/gtk-youtube-viewer.conf:
ffmpeg => {
        cmd => "mplayer",
        arg => 'ffmpeg://$(youtube-dl -f best -g *URL*)',
        srt => "-sub *SUB*",
        fs => "-fs",
},

and set the value of video_player_selected from "mplayer" to "ffmpeg".

Wow, beautiful !! Thanx :-)

It works !! :-) Yes!!


Adding admin column causes error

When adding this field as a display column on an entries index page it causes a red "a server error occurred" flash notice in the control panel and the column does not get added.
Not sure I've narrowed down the exact error in the logs but I think it might be related to this:
[error][yii\base\ErrorException:8] yii\base\ErrorException: Array to string conversion in /Users/xxx/Sites/demosite.local/vendor/craftcms/cms/src/base/Field.php:539

@eduardoalonsoalbella could this be related to moving to UID's?

@ryanscherler the data structure is still the same, the only change is the data type from int to string, @dr-codswallop you might need to reconfigure "configure the whitelistes sites" that use this plugin and try again

@dr-codswallop looks like "configuring the whitelistes sites" that use this plugin seems to resolve the issue after some initial testing. I'm going to close out this issue - feel free to re-open a new one if we've missed something. Thanks!


feat(trading): show rank table in dispatch strategy tooltip

Related issues 🔗
Closes #6063
Description ℹ

[x] show rank table in dispatch strategy tooltip
[x] use this spreadsheet calculations

Demo 📺

Technical 👨🔧
Details of technical implementation that reviewers may need to be aware of, if applicable.

I think we should show:

Rank tier
Start rank
End rank
Places paid (num payouts)
Payout (per winning team)

We should include a note saying
"Payout percentages are base estimates assuming no individual reward multipliers are active.  If users in teams have active multipliers the reward amounts may vary."


Defect fix of SimulatedAnnealing with 1 variable optimization

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #2295
What are the significant changes in functionality due to this change request?
The SimulatedAnnealing could not process 1-variable optimization problem (crash). This PR addresses the problem
maxing sure that ``delta'' variable is always indexable (np array).
A test is added to show that 1 variable optimizations are now possible
In addition, a typo in the Serpent interface is corrected as well (no wrong results to the users but just a crash in case of usage of ``include'' paths sampled by RAVEN.

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Mingw Test on fb16367 : invalidated by @alfoa
fetch failed

@wangcj05 @mandd ready to review.
Thanks in advance.

PR checklist is good.