Callback not in main message - submsg size changed error

I have a problem with following proto structure and nanopb-<IP_ADDRESS>:
syntax = "proto2";

message SocketSetup {
    optional SocketInfo info = 2;
}

message SocketInfo {
    repeated ProbeInfo      humidity = 1;
    repeated ProbeInfo      temperature = 2;
}

message ProbeInfo {
    enum PartNumber {
        R_55B1210 = 0;
    }
    optional PartNumber partNumber = 1;
    optional uint32 address      = 2 [default = 0];
    optional uint32 index        = 3 [default = 0];
}

My goal is to encode SocketSetup message. Since this callback is not directly in the main message It is firstly sized and then ProbeInfo is encoded. The sizing phase is correct and for two humidity and two temperature repeated messages firstly my callbacks are executed with empty stream structure, call stack:

After the sizing when nanopb tries to encode again it ends up in PB_RETURN_ERROR(stream, "submsg size changed"); in pb_encode_submessage()

I have no problem when callback is directly in main message (eg. encode SocketInfo not SocketSetup).
Code to reproduce:
/*
this structure is shared across all repeated fields to
preserve context between callbacks
*/
typedef struct
{
    uint16_t index;
    size_t encodedSize;
    bool sentAll;
    ProbeInfo *msgLastAddress;
    MeasurementsQueue_t *measQueueLastAddress;
}SocketInfoCbArg_t;

void SocketMgmtEncode(uint8_t *outBuf, size_t *outSize)
{
    static SocketInfoCbArg_t SocketInfoAnsCallbackArg = {
        .index = 0, .encodedSize = 0, .sentAll = true, .msgLastAddress = ProbeInfoHead, .measQueueLastAddress = NULL};
    pb_ostream_t ostream = pb_ostream_from_buffer(outBuf, *outSize);

    SocketInfoAnsCallbackArg.measQueueLastAddress = MeasurementsQueueGet();

    SocketSetupAns.info.humidity.funcs.encode = SocketInfo_humidity_callback;
    SocketSetupAns.info.humidity.arg = &SocketInfoAnsCallbackArg;
    SocketSetupAns.info.temperature.funcs.encode = SocketInfo_temperature_callback;
    SocketSetupAns.info.temperature.arg = &SocketInfoAnsCallbackArg;

    SocketSetupAns.has_info = true;

    if (!pb_encode(&ostream, SocketSetup_fields, &SocketSetupAns))
        {
            const char * error = PB_GET_ERROR(&ostream);
            printf("SocketSetup_fields error: %s\r\n", error);
            return false;
        }
}

static bool SocketInfoGenericCallback(pb_ostream_t *stream, const pb_field_t *field, SocketInfoCbArg_t *dest)
{
    if(dest->measQueueLastAddress->measurement->type != field->tag)
    {
        return true;
    }
    // first encode after sizing, init args again
    if(stream->callback != NULL && stream->bytes_written == 0)
    {
        SocketInfoResetCallbackArgs(dest);
    }

    while(1)
    {
        if(dest->measQueueLastAddress->measurement->type != field->tag)
        {
            break;
        }
        dst->has_partNumber = true;
        dst->has_address = true;
        dst->partNumber = src->measurement->id;
        dst->address = src->measurement->address;
        if(!pb_encode_tag_for_field(stream, field))
        {
            break;
        }

        if (!pb_encode_submessage(stream, ProbeInfo_fields, dest->msgLastAddress))
        {
            break;
        }

        dest->msgLastAddress++;
        dest->encodedSize = stream->bytes_written;

        if(dest->measQueueLastAddress->next == NULL || dest->msgLastAddress == NULL)
        {
            dest->sentAll = true;
            break;
        }

        dest->measQueueLastAddress = dest->measQueueLastAddress->next;
    }

    return true;
}

static bool SocketInfo_humidity_callback(pb_ostream_t *stream, const pb_field_t *field, void * const *arg)
{
    if (stream == NULL || field->tag != SocketInfo_humidity_tag)
    {
        return true;
    }

    return SocketInfoGenericCallback(stream, field, (SocketInfoCbArg_t*)(*arg));
}

static bool SocketInfo_temperature_callback(pb_ostream_t *stream, const pb_field_t *field, void * const *arg)
{

    if (stream == NULL || field->tag != SocketInfo_temperature_tag)
    {
        return true;
    }

    return SocketInfoGenericCallback(stream, field, (SocketInfoCbArg_t*)(*arg));
}

This part seems a bit questionable:
// first encode after sizing, init args again
if(stream->callback != NULL && stream->bytes_written == 0)
{
    SocketInfoResetCallbackArgs(dest);
}

Seems like during sizing run, only SocketInfo_humidity_callback will end up encoding data, because it runs first and the info is not reset when the stream is the sizing stream. However, during the actual encoding pass also SocketInfo_temperature_callback resets the state and encodes the same data again.
That's because arg points to the same structure for both - not sure if that is just in your example and not in reality.
I would suggest just restarting from beginning every time the SocketInfoGenericCallback runs. There is no need for an encoding callback to continue from where it left off, as it should just write out all data it has.

I see, thank you for fast reply.
You are right, arg points to the same structure. I have a limited space for protobuf output (in worst condition only 11 bytes). I thought passing around same structure which will have encodedSize variable that will keep last size of fully encoded message might save me some time instead of calling pb_get_encoded_size everytime (if its possible to call it inside callback)
Is there any other mechanism that will allow me to easly encode as much as I can fit to limited buffer?

I think I would approach that problem by encoding the items to a buffer until maximum number of bytes is reached. And only after that wrap the items inside the submessages and length prefixes - which can be done either manually following protobuf encoding spec, or alternatively by just having a callback copy them from a temporary buffer to the final buffer.

Sounds great, that simplifies a lot of my code! I will try to implement it and let you know

One more question, is there any compile time variable that determines number of fields in specific message?

Well, it's a bit of a hack, but in 0.3.x one can use pb_arraysize(MyMessage_fields)-1 (-1 to subtract the list terminator). In 0.4.x there is MyMessage_msg.field_count.

I'm using LoRaWAN to send my messages. In LoRa when Adaptive Data Rate is enabled you can't control the payload size. You can get it only before sending a message. In my case messages are sent every 30 seconds
Unfortunately I'm unable to write a callback that will not have any common arguments, either global or passed via args struct - I must have last address of the ProbeInfo that I sent, I dont know where to. I also added index field based on repeated number and if there is more than 2 of the same kind, no index is sent for the later ProbeInfo - I can't predict how much space I will have and which ProbeInfo will have index or not, I encode it just before sending when I know how much space I have. It seems that I can't do that with pre-encoded approach.
I don't have more time for this task so I edited the protobuf structure to make sure that there is no sizing involved in pb_encode.


Parameters

Purpose

Added support for Outputs in main.bicep to write to environment variables
Allowed for parameter input when running azd up
Bug fixes in container environment OutboundSettings removed
Renamed resourceGroupName at main.bicep into AZURE_RESOURCE_GROUP for consistency
Updated documentation by removing the section where input variables were manually defined.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type
What kind of change does this Pull Request introduce?

[X] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code
Run azd up to deploy the template

What to Check
Verify that the following are valid

The solution deploys correctly

Newer pull request will be issued


UpdateQuery: marshal false as BOOLEAN if nullzero tag not set

Related to: #922, see this comment for detailed analysis. This commit demonstrates the bug.
Setting NullZero = true for fields with default:x tag led to false values being appended as NULL in UpdateQuery.
https://github.com/uptrace/bun/blob/8a4383505d7e954897b23811a412b9cdafaf41eb/schema/table.go#L378-L381
Apart from causing the bug, this seemed like a misuse of NullZero property. Removing this behaviour required additional (small) changes to InsertQuery, so I also added new test cases and extended an existing one to make sure we don't introduce any regressions (hence the many changed files).
Finally, I moved the chunky f.IsPtr && f.HasNilValue(strct), f.HasZeroValue(strct) && (f.NullZero || f.SQLDefault != "") conditional to a separate method and added some documentation for it.

@bevzzz could you please rebase this?

There will be some more conflicts here, because of the test cases added in the other PR we've just merged.
I'll rebase later today 👌

@bevzzz thanks :+1: Sorry for the hassle.

No problem, glad I could contribute :)


"Restrict to collection" is not properly working

It always shows x have uploaded their collection. and displays the green book for me when I join the site.
It doesn't matter if the "Restrict to Collection" check box is active or not. It correctly remembers its former state on join though.
But I always have to check and uncheck the box again to correctly update its state and make it display the yellow book and ...but are not using it. message.
Using FF 79.0

Good catch.
Should be fixed by 7c28dbeb0040231d546bcf90b93e326709a5f0bd

Thanks for the quick fix, will happily revisit after you deployed the change.

Seems to work now!


cuda runtime error on ubuntu 16.04 LTS / cuda 8.0

I'm seeing
THCudaCheck FAIL file=/tmp/luarocks_cutorch-scm-1-299/cutorch/lib/THC/THCGeneral.c line=608 error=4 : unspecified launch failure
/home/ankit/torch/install/bin/luajit: cuda runtime error (4) : unspecified launch failure at /tmp/luarocks_cutorch-scm-1-299/cutorch/lib/THC/generic/THCStorage.c:147

when running default training. i'm on ubuntu 16.04 with cuda 8.0 RC. it seems likely that there's a problem with cutorch and cuda 8.0 (the failure happens sometimes before a single batch is evaluated on, sometimes after -- the nondeterminism makes me think it's a fundamental driver problem), but before i either switch back to cuda 7.5 or ubuntu 14.04 or dive into the cutorch code, I was wondering if anything sticks out to you concerning this bug.

hmm i don't think i remember encountering that. i would recommend trying cuda 7.5 first (this is what we use).


I can't seem to get nvim config file to work

Hello just to start this off i'm a little new to nvim so sorry if i am just stupid and make an obvious mistake but i searched everywhere online and everyone tells me that either packer is not installed or my config file is not setup corectly.
so whenever i open neovim i get these errors:
Error detected while processing /home/ferenti/.config/nvim/init.lu
a:
E5113: Error while calling lua chunk: /home/ferenti/.config/nvim/l
ua/core/keymap.lua:44: module 'telescope.builtin' not found:
        no field package.preload['telescope.builtin']
        no file './telescope/builtin.lua'
        no file '/usr/share/luajit-2.1.0-beta3/telescope/builtin.l
ua'
        no file '/usr/local/share/lua/5.1/telescope/builtin.lua'
        no file '/usr/local/share/lua/5.1/telescope/builtin/init.l
ua'
        no file '/usr/share/lua/5.1/telescope/builtin.lua'
        no file '/usr/share/lua/5.1/telescope/builtin/init.lua'
        no file './telescope/builtin.so'
        no file '/usr/local/lib/lua/5.1/telescope/builtin.so'
        no file '/usr/lib64/lua/5.1/telescope/builtin.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file './telescope.so'
        no file '/usr/local/lib/lua/5.1/telescope.so'
        no file '/usr/lib64/lua/5.1/telescope.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        /home/ferenti/.config/nvim/lua/core/keymap.lua:44: in main
 chunk
        [C]: in function 'require'
        /home/ferenti/.config/nvim/init.lua:2: in main chunk

i have installed the packer repo with git clone --depth 1 https://github.com/wbthomason/packer.nvim\  ~/.local/share/nvim/site/pack/packer/start/packer.nvim as stated in the quickstart instructions in the packer.nvim readme.md file
keep in mind that i directly copied your nvim folder in my .config folder so i did not make any changes there
i feel like i'm missing something obvious here, can anyone help me out?

I've had this issue during the first time running nvim on a new os/pc after copying my config. From what I understand, It's a by a problem with the plugin load order.
I don't remember exactly I did to fix it but, try running " source % " in the following files: nvim/lua/core/packer-config.lua, nvim/lua/core/plugin_config/init.lua, nvim/init.lua in that order and/or reverse order. to ensure Packer is properly loaded.

ok so i ran
$source lua/core/packer-config.lua
lua/core/packer-config.lua (line 11): 'end' outside of a block
end
^~^
from sourcing file lua/core/packer-config.lua
source: Error while reading file 'lua/core/packer-config.lua'

and then
$ source init.lua                                                                                Sun 03:54
init.lua (line 1): command substitutions not allowed here
require("core.settings")
       ^~~~~~~~~~~~~~~~^
from sourcing file init.lua
source: Error while reading file 'init.lua'

and then
$ source lua/core/plugin_config/init.lua                                                                                Sun 03:54
lua/core/plugin_config/init.lua (line 1): command substitutions not allowed here
require("core.plugin_config.alpha")
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file lua/core/plugin_config/init.lua
source: Error while reading file 'lua/core/plugin_config/init.lua'

so i thought i should proabably run it with the lua interpreter
so i ran
$ lua lua/core/packer-config.lua
lua: lua/core/packer-config.lua:2: attempt to index a nil value (global 'vim')
stack traceback:
	lua/core/packer-config.lua:2: in local 'ensure_packer'
	lua/core/packer-config.lua:13: in main chunk
	[C]: in ?

and
$ lua lua/core/plugin_config/init.lua
lua: lua/core/plugin_config/init.lua:1: module 'core.plugin_config.alpha' not found:
	no field package.preload['core.plugin_config.alpha']
	no file '/usr/share/lua/5.4/core/plugin_config/alpha.lua'
	no file '/usr/share/lua/5.4/core/plugin_config/alpha/init.lua'
	no file '/usr/lib64/lua/5.4/core/plugin_config/alpha.lua'
	no file '/usr/lib64/lua/5.4/core/plugin_config/alpha/init.lua'
	no file './core/plugin_config/alpha.lua'
	no file './core/plugin_config/alpha/init.lua'
	no file '/usr/lib64/lua/5.4/core/plugin_config/alpha.so'
	no file '/usr/lib64/lua/5.4/loadall.so'
	no file './core/plugin_config/alpha.so'
	no file '/usr/lib64/lua/5.4/core.so'
	no file '/usr/lib64/lua/5.4/loadall.so'
	no file './core.so'
stack traceback:
	[C]: in function 'require'
	lua/core/plugin_config/init.lua:1: in main chunk
	[C]: in ?

and
$ lua init.lua
lua: init.lua:1: module 'core.settings' not found:
	no field package.preload['core.settings']
	no file '/usr/share/lua/5.4/core/settings.lua'
	no file '/usr/share/lua/5.4/core/settings/init.lua'
	no file '/usr/lib64/lua/5.4/core/settings.lua'
	no file '/usr/lib64/lua/5.4/core/settings/init.lua'
	no file './core/settings.lua'
	no file './core/settings/init.lua'
	no file '/usr/lib64/lua/5.4/core/settings.so'
	no file '/usr/lib64/lua/5.4/loadall.so'
	no file './core/settings.so'
	no file '/usr/lib64/lua/5.4/core.so'
	no file '/usr/lib64/lua/5.4/loadall.so'
	no file './core.so'
stack traceback:
	[C]: in function 'require'
	init.lua:1: in main chunk
	[C]: in ?

ran them in reverse order too and and got same outputs

It's my fault I should have specified this; run " :source % " inside each of the files I listed form within neovim


Azure Storage File Data Lake Readme Issue

Section link

Reason:
The variable name is the same as the class name.
Suggestion:
Update DataLakeServiceClient to dataLakeServiceClient.
@jongio for notification.

Thanks for reporting @zzhxiaofeng
Can you send a PR for this?

@ramya-rao-a Ok, I will fix this.

PR merged.


Teach vcpkg that vcpkg-configuration.json means an empty vcpkg.json.

This reverts the panic revert in https://github.com/microsoft/vcpkg-tool/commit/3247920fbdd47d08f36cbd480addd9890d3c2435 and implements the correct handling on the vcpkg side.
This resolves part of user story https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1638690

Closing for this for now because I don't like leaving broken PRs in draft forever.


Improve AI Grant Example

why
https://github.com/browserbase/stagehand/pull/235 is not easy to work because it's an an image. Update to the code inline with md and the example in examples/
what changed
Update markdown, New example in examples/, remove image
test plan
Documentation

Thanks so much for taking the time to do this! However, I don't think this needs to be merged.
The image is moreso to show how simple Stagehand is to write than Playwright, and imo it does a fair job encapsulating the difference with a side-by-side comparison that gets lost when you make it plain text.
We could have it as an example, but our existing examples do a fine job showing the capabilities of Stagehand. There's not much to be gained from an extra example. I believe @seanmcguire12 is adding something like this as an eval as well, which is where I would recommend this be moved instead.


Make enable all selector methods in FeatureScreening

In the FeatureScreening.jl/src/FeatureScreening.jl file only the Top selector is used:
important_names::Vector{<: N} = select(importances, Top(reduced_size); strict = false) .|> label

In the code, it should be possible to set which selector method we want to use.

Related to #20.


MudDataGrid resizable columns

Feature request type
Enhance component
Component name
MudDataGrid
Is your feature request related to a problem?
No response
Describe the solution you'd like
Columns should be able to be resized by dragging on the edge.
Have you seen this feature anywhere else?
This has a live example: https://demos.telerik.com/blazor-ui/grid/column-resizing
Excel, Google Sheets, etc..
Describe alternatives you've considered
No response
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

MudDataGrid is under active development, the finished component and what features or purpose it will have is not determent yet. And we already have this request in mind when developing MudDataGrid.
Until then please don't do feature requests for it


Error: Kraken API returned error: Service:Unavailable

Hi,
I’m often having some issue while requesting the Kraken API.
I didn’t found a similar issue so here is the debug log to give you some hint.
2017-08-07 23:31:40 (DEBUG):	Processing 15 new trades. From 2017-08-07 21:31:37 UTC to 2017-08-07 21:31:44 UTC. (a few seconds)
2017-08-07 23:32:00 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:32:01 (DEBUG):	Processing 8 new trades. From 2017-08-07 21:31:55 UTC to 2017-08-07 21:32:06 UTC. (a few seconds)
2017-08-07 23:32:20 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:32:20 (DEBUG):	Processing 7 new trades. From 2017-08-07 21:32:17 UTC to 2017-08-07 21:32:32 UTC. (a few seconds)
2017-08-07 23:32:40 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:32:40 (DEBUG):	kraken returned an error, retrying.. Error: Kraken API returned error: Service:Unavailable
    at Request._callback (/home/tr4sk/gekko/node_modules/kraken-api/kraken.js:155:34)
    at Request.self.callback (/home/tr4sk/gekko/node_modules/request/request.js:188:22)
    at emitTwo (events.js:125:13)
    at Request.emit (events.js:213:7)
    at Request.<anonymous> (/home/tr4sk/gekko/node_modules/request/request.js:1171:10)
    at emitOne (events.js:115:13)
    at Request.emit (events.js:210:7)
    at IncomingMessage.<anonymous> (/home/tr4sk/gekko/node_modules/request/request.js:1091:12)
    at Object.onceWrapper (events.js:314:30)
    at emitNone (events.js:110:20)
    at IncomingMessage.emit (events.js:207:7)
    at endReadableNT (_stream_readable.js:1045:12)
    at _combinedTickCallback (internal/process/next_tick.js:138:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
2017-08-07 23:32:51 (DEBUG):	Processing 6 new trades. From 2017-08-07 21:32:42 UTC to 2017-08-07 21:33:04 UTC. (a few seconds)
2017-08-07 23:33:00 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:33:00 (DEBUG):	Processing 3 new trades. From 2017-08-07 21:33:10 UTC to 2017-08-07 21:33:15 UTC. (a few seconds)
2017-08-07 23:33:20 (DEBUG):	Requested XBT/EUR trade data from Kraken ...
2017-08-07 23:33:20 (DEBUG):	Processing 11 new trades. From 2017-08-07 21:33:20 UTC to 2017-08-07 21:33:32 UTC. (a few seconds)

This should not be a big problem: Gekko merely logs the error will tries again :)


Validating regform. closes #29

Implement regform validation. Close #29
Review request:both @cleac and @webknjaz

I cannot comment diff from mobile app, so I'll do this here.

Why did you pick cerberus over other options? Plz outline ins and outs. Just curious.
Why do you return 200 for error? I wouldn't do that.
It would be extremely nice to move schema to yaml file :)
(it's possible to refer python callables from yaml, see Jinja2 functions example)

There should be some builtin email/url checkers. Have you tried googling those?

Not a valid -> Invalid

It is just a validation tool, with neat schema, that CAN be stored in YAML. And it was also the most popular package on pypi. Thus I decided if so many people trust it, we can trust it too)

Something like 400 bad request?

Hence it is possible, I think, I'd do that)

There is no built-in email checker for Cerberus. Cerberus is like gentoo for validator stuff -- it provides only basic functionality. Everything else you want you can and have to build (write) by yourself using its API. This is actually one more reason, why have I chosen it over livr and trafaret.

OK

yes. Plz refer http://www.restapitutorial.com/httpstatuscodes.html for more codes
2.1) Keep in mind to raise HTTPError instead of returning dict. It's automatically converted into JSON already.

I meant smth from python standard library

Now server returns 400 if validation failed
Change error message from Not a valid ... to Invalid ...

All solutions I've found are based on using regex validation. Sometimes regex validation is followed by hostname resolution validation. But I'd rather keep it as simple as possible for now.

@cleac: do you have any comments on this PR?

Except failing tests all's already mentioned by @webknjaz

Why didn't you use raise statement? You are not supposed to set http response code manually.

@webknjaz and how should I set JSON response body in case of raise?

That's the point! You shouldn't. It will be done automatically.

See 0c17c18fe767c3cb59639df5086338c1095e1406

Here's working example:
When you open /api/info in your browser unauthorized, tool throws an exception with HTTP error 401 https://github.com/GDG-Ukraine/gdg.org.ua/blob/master/src/GDGUkraine/lib/tools/authorize.py#L27.
Response is:
{
    message: "Please authorize",
    reason: "Unauthorized",
    code: 401
}

@anxolerd I've pulled from you and PRed you some code. Plz check it, merge to your branch and if you have time+wish refactor it.
If not, make final fixes and I'll check more carefully.
Btw, there's some bug with admin in this branch. I cannot explain it. If you open event in admin it doesn't list any GDG place in drop-down and there's no logout menu in top right corner, and there's no Participants tab, which should be available in godmode.
So plz merge master into your branch and check whether it's fixed.

Pushed @webknjaz ' PR (see https://github.com/anxolerd/gdg.org.ua/pull/1)

LGTM


Cannot convert string to int for increment_id on edited orders

When order is edited from the admin page the order is recreated as a new childorder with a order ID with a dash (100000003-1). This throws an exception.
Inner exception i get is: "{"Could not convert string to integer: 100000003-1. Path '4.increment_id', line 1, position 9103."}"
Magento version: <IP_ADDRESS>
Magento-RestApi installed from NuGet package

Hi Martin,
Changed to type string and is available in nuget in version 1.0.3


examples for Nebius and YandexCloud

Codecov Report
Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (5bd4d45) 40.00% compared to head (d0b8301) 32.81%.
Report is 3 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   40.00%   32.81%   -7.19%
==========================================
  Files           2        4       +2
  Lines         315      384      +69
==========================================
  Hits          126      126
- Misses        176      245      +69
  Partials       13       13

Flag
Coverage Δ

go-1.18.x
32.81% <0.00%> (-7.19%)
:arrow_down:

go-1.19.x
32.81% <0.00%> (-7.19%)
:arrow_down:

go-1.20.x
32.81% <0.00%> (-7.19%)
:arrow_down:

macOS
32.81% <0.00%> (-7.19%)
:arrow_down:

ubuntu
32.81% <0.00%> (-7.19%)
:arrow_down:

unit
32.81% <0.00%> (-7.19%)
:arrow_down:

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

credentials.go
0.00% <0.00%> (ø)

options.go
0.00% <0.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Added a missing Holiday to Venezuela

Hi, I missed "Muerte del Libertador Simón Bolívar" when I wrote the holidays for Venezuela, I added them this time

ok I don't know how to resolve the error: Tests / Run Quality Assurance (pull_request)

You can try fix the coverage with:
python -m black holidays/countries/venezuela.py

Also, you are pointing to the master branch and I believe that all PR must point to dev branch

Ohh, let me try that command, though, first time I see it .
I was doing it in the beta branch, but probably change it and didn't realize it

@javicalle

You can try fix the coverage with:
python -m black holidays/countries/venezuela.py

Also, you are pointing to the master branch and I believe that all PR must point to beta branch

Thank you!
This is substantially correct, although black package is not a dev explicit requirement, so a call like that would usually fail.
Please refer to here for the proper instructions.
@antusystem

Ohh, let me try that command, though, first time I see it .
I was doing it in the beta branch, but probably change it and didn't realize it

Not a problem! I switched your PR target to beta.
On the other hand, test coverage for Venezuela is a bit low (87%) so, while still being on it, I kindly ask you to review your tests to reach the required value.
Please refer to here for detailed commands to do it.
Thank you both, cheers! 👍

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.0002%) to 97.855%

Totals

Change from base Build<PHONE_NUMBER>:
0.0002%

Covered Lines:
5774

Relevant Lines:
5842

💛  - Coveralls

Ok done, I downloaded my repo and used pre-commit and pytest to check everything. Thanks for the link provided :)

Hi @antusystem I had to rework your code due to:

some missing tests
some mistakes in the "Semana Santa y Carnaval" block

Now it's 100% working and tests covered: released in beta.
Cheers


#184639058 Server starter Scripts && ES6 configuration

What does this PR do?
This PR serves to add extra scripts for the express server. It also enables es6 for imports for the project.
Description of the task to be completed?
Has the following functionalities:

Adds dev script.
Adds build script.
Enabbles ES6 usage.

How should this be manually tested?
Clone the project, and install all the dependencies. Run npm run dev, npm run start, or npm run build. You can also trying importing files with the import statement not the require.
Any background context you want to provide?
Not any
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)

Please squash your commits into one commit; and see why your test is failing while on develop passed


Switch the import module finding order

In https://github.com/digital-asset/ghcide/blob/master/src/Development/IDE/Import/FindImports.hs#L81-L82, we prefer the source files over the modules from the package database. But that causes problems in a multi-cradle environment. When module MA belongs to cradle CA and MA imports another module MB, which belongs to cradle CB, ghcide tries to interpret module MB because it is found as a source file. If the import dependency chain is deep, it significantly slows down ghcide and sometimes causes build errors because GHC options generated for module MA may not work for interpreting module MB.
We should prefer the package database in this case.

The current behavior matches the behavior of ghc afaik and I don’t really want to diverge from that.

A common way to avoid this issue is to use different source directories. That’s one reason why Haskell projects often have app, src, and test.

Makes sense. I suspect this problem is unique to our build system. I'm closing this now. We may have to patch ghcide's import module finding logic a little bit so that it doesn't search random locations in the file system but only the current set of target files.
Thanks, @cocreature !

ghcide should never search random locations. It only searches the include dirs and relative to the module the import is from (the latter is mostly coming from DAML and will probably go away at some point).

Ah, sorry that's what I meant :)
And that doesn't work very well with our internal build system (basically bazel).


Fixing types of UIEventArgs properties.

Hi,
I found out that some properties of UIEventArgs objects doesn't match with either w3 standard or with their description.
Example:
public float Detail { get; set; }
should be based on mozilla or w3
public long Detail { get; set; }
Even the description of property says, that it represents count of clicks incremented by 1, therefor  representing them by long makes more sense to me.
I found several other properties with mismatching types. I can fix them and propose fixes in this PR, but at first I would like to get some feedback on this.
Thanks.

Maybe you should cooperate with @Niladri24dutta here:
https://github.com/aspnet/Blazor/issues/1483

I have posted some more comments here regarding this #1483

@Niladri24dutta
Yeah, I know you have been working on the property Location and on changing it to Enum. I had no intention to solve it in this PR, because I though you have been focusing only on Location prop.
But I found several others like Detail, Height and Width, which should't be float based on docs.
I certainly didn't check all of them, so there could be more to change.
I suppose those changes should be in different PR than PR for #1483.
If it makes sense to solve it in the same PR, then we should go for it.
@SteveSandersonMS What are you suggesting?

@KristianJakubik are you sure that Height and Width should't be float? I have laptop with DPI scaling set to 150% and I'm sure I have seen values like 100.5px in window.innerWidth for example. Here is a note from http://api.jquery.com/innerwidth/

The number returned by dimensions-related APIs, including .innerWidth(), may be fractional in some cases. Code should not assume it is an integer.

There a lot of different event types in https://github.com/aspnet/Blazor/blob/master/src/Microsoft.AspNetCore.Blazor/UIEventArgs.cs with ScreenX/ScreenY/ClientX/ClinetY properties and all of them have type long which is consistent with the spec:
https://www.w3.org/TR/uievents/#interface-mouseevent
On the other hand here:
https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/clientX
we can read

Originally, this property was defined as a long integer. The CSSOM View Module redefined it as a double float.

What should we have in Blazor? Personally I think that we can always convert from double to int or long but when we have only an integer value there is no way to restore fractional part.

@Andrzej-W
Thanks for your response.

@KristianJakubik are you sure that Height and Width should't be float? I have laptop with DPI scaling set to 150% and I'm sure I have seen values like 100.5px in window.innerWidth for example. Here is a note from http://api.jquery.com/innerwidth/

I went through docs again and you are right. It says, that it should be double . I will edit my comment.
docs: mozzila, w3

What should we have in Blazor? Personally I think that we can always convert from double to int or long but when we have only an integer value there is no way to restore fractional part.

My personal opinion is, that we should be as accurate as possible for objects, which are accessible from outside of the framework. If I was a user of Blazor, I wouldn't be happy, if I had to convert the value every time when I'm working with UIEventArgs object. That's the main reason why I created this PR.

Thanks for this! It's now moved to https://github.com/aspnet/AspNetCore/pull/4595.


digested source maps

recently stumbled into this project while attempting a rails 7 update. I am using the predigested ".digested" method because my js files need to reference themselves, and am having 2 issues with the source maps.

The sourceMappingURL is being striped away: https://github.com/rails/propshaft/blob/390381548b125e8721c8aef1b9d894b7cc8bd868/lib/propshaft/compilers/source_mapping_urls.rb#L29 (quick and dirty solution in dev mode is to call config.assets.compilers.pop to remove Propshaft::Compilers::SourceMappingUrls)
Also the source maps will not be served without tweaking extract_path_and_digest - https://github.com/firien/propshaft/compare/3903815...ed67507

Thanks for the report @firien. I will hold back a solution for this one for now, as it seems #100 was the one to break. As soon as I decide if it will be reverted or not, I'll fix this one.

Well I for one was excited to see #100 - we need something like this right?

It cleaned up some internal code and added a useful feature, which is why I’m holding back on reverting it. Still hoping we can find something that will satisfy all the use cases.
Fortunately Propshaft will only replace Sprockets as the default on Rails 8, so there’s time.

https://github.com/firien/propshaft/tree/esbuild has fixes and tests for 2 issues mentioned above


Reject trailing bytes when deserializing from &[u8]

In deserialize_from, it makes sense to allow deserializing multiple values from the same io::Read. But in deserialize, I think trailing data should be an error.
I would expect this to be an error rather than ignoring b"x":
extern crate bincode;

fn main() {
    println!("{:?}", bincode::deserialize::<char>(b"1x"));
}

@dtolnay Is this issue in response to my question: https://github.com/TyOverby/bincode/issues/192 ?
Does it mean that multiple serialised messages (differing by trailing bytes) can deserialise to the same content?

https://github.com/TyOverby/bincode/issues/192#issuecomment-313660286 gives a workaround to detect trailing bytes.

I'm wondering if this is possible to achieve without incurring a performance penalty. The first method that came to mind was to modify the SliceReader struct, but the read methods on this struct may get called multiple times and there is no way to know if this is the last call so that method is out. The only other method that is immediatly obvious to me is to keep track of bytes read during the deserialization and error out at the end if bytes read and buffer length don't match. The issue with this method is that we would have to add code (Quite possibly to the sizelimit structs) to check this, which seems like it would be an unwanted amount of overhead. Especially in the common case of SizeLimit::Infinite

Thanks for tackling this.

A constant overhead is fine (i.e. not linear in the number of input bytes).
Using pub(restricted) is fine. It can easily be replaced with #[doc(hidden)] if someone complains.

I'm moving this to post-1.0 because I don't think that it is fundamental to the library and can be added in a backwards compatible way with a config option.
The config option won't even need to be a compile-time reified config option either.


syslog/rsyslog: support dynamic files

Requires new lens from https://github.com/hercules-team/augeas/pull/622

Coverage increased (+0.08%) to 91.403% when pulling 0b957e1a113690f047ccb49be0955b1a47a6d45c on raphink:rsyslog_dynamic into 2d8775165cdfe79daae4b3ccc4dad8ccc3208a81 on hercules-team:master.

Coverage increased (+0.08%) to 91.403% when pulling 0b957e1a113690f047ccb49be0955b1a47a6d45c on raphink:rsyslog_dynamic into 2d8775165cdfe79daae4b3ccc4dad8ccc3208a81 on hercules-team:master.


Minor problem with weird build numbers

I have a custom rom in my phone and atarashii doesn't like my build version "◄║JellySNAP ROM|Ξ|JSRAK47|Ξ|v7.0║►". I could change my build name for the time being but it could be good if you filter some of the characters out that cause problems like this character ◄. Here's the line that was causing problems from MALApi.java.
private static final String USER_AGENT = "Atarashii! (Linux; Android " + Build.VERSION.RELEASE + "; " + Build.MODEL + " Build/" + Build.DISPLAY + ") " + okUa;

Ehm yeah.
Why do they make such versions... :/
I will have to discuss this first.

Okay I searched a bit online and found this:
http://developer.android.com/reference/android/os/Build.VERSION.html#RELEASE
The user-visible version string. E.g., "1.0" or "3.4b5".
in your case "◄║JellySNAP ROM|Ξ|JSRAK47|Ξ|v7.0║►".
That entirely different!
I am afraid I can't do anything about this because this is the worst build version I have seen in my entire life XD
The other developer also doesn't know how we could fix this in a proper way.
So unless the developer of your ROM knows a way to fix this we are stuck with this.
Sorry.


Be able to Pop Out Chat and dock

I would like to be able to keep the window open and access the rest of VSCode (e.g., Explorer) at the same time.  It would be nice to be able to dock it separately in different parts of VSCode and/or be able to pop it out so it can be its own window and just keep it open.

Agreed, would be nice. Otherwise I keep having to hide and reopen Copilot Chat just to take a peek at my code

Agreed. I keep having to swap back to explorer view or something else to see other files.

Yeah. Also agreed for the same reason @michaelronnfeldt said.

Alternatively, you could have it as one of these tabs:

@StupidRepo I think that just moves the problem to blocking the terminal, output, etc.  The goal is to have all of VSCode at your disposal and have the chat window popped out so it can be moved around, sit next to your VSCode, etc.  Docking options would be a bonus so it could exist in spaces like the one you show, but next to other items (e.g., so it resembles a split terminal window).

It would be nice if there was more than one primary side bar in vs code. Docking copilot chat the non main side bar would be nice and have clickable icons.

@StupidRepo I think that just moves the problem to blocking the terminal, output, etc. The goal is to have all of VSCode at your disposal and have the chat window popped out so it can be moved around, sit next to your VSCode, etc. Docking options would be a bonus so it could exist in spaces like the one you show, but next to other items (e.g., so it resembles a split terminal window).

Ah yeah... silly me.

You can also put it in the editor view, either with the "Open editor" command or the "Open session in editor" command under the ... in the view title (currently this command only works when you have already asked a question in the chat)

You can also put it in the editor view, either with the "Open editor" command or the "Open session in editor" command under the ... in the view title (currently this command only works when you have already asked a question in the chat)

I just found this out and was literally coming here now to tell people this. Looks like you beat me to it. By 4 days!


Error in docker build linux/arm/v7

This is an awesome tool. But I had a problem in my multi-arch docker build.
I cant replicate it outside of travis (cant get qemu to run locally).
the error is this:
#51 [linux/arm/v7 builder 4/7] RUN lastversion mutability/mlat-client --down...
1314#51 4.477 Traceback (most recent call last):
1315#51 4.477   File "/usr/local/bin/lastversion", line 8, in <module>
1316#51 4.477     sys.exit(main())
1317#51 4.477   File "/usr/local/lib/python3.8/site-packages/lastversion/lastversion.py", line 430, in main
1318#51 4.477     version = latest(args.repo, args.format, args.pre, args.newer_than, args.filter,
1319#51 4.477   File "/usr/local/lib/python3.8/site-packages/lastversion/lastversion.py", line 256, in latest
1320#51 4.477     the_date = r_commit.json()['committer']['date']
1321#51 4.477 KeyError: 'committer'

It works fine for v6 and all other...
Link to the travis fail:
https://travis-ci.com/github/ShoGinn/adsbexchange-mlat/builds/153330515
excerpt from the failed command
FROM --platform=$TARGETPLATFORM python as builder

WORKDIR /mlat-client

RUN pip3 install --upgrade shiv importlib-resources lastversion

RUN \
    lastversion mutability/mlat-client --download mlat-client.tar.gz && \

I think you're not using the GITHUB_API_TOKEN env var, as per tips.
Despite the effort with caching of GitHub API responses, the tool needs to make a lot of requests to get reliable data. And for many requests, having a token is needed.
Can you try setting GITHUB_API_TOKEN ?
To make sure the token is in use, you can run with lastversion --verbose ... and then the output should include:
INFO: Using API token.

@dvershinin I made sure I had the GITHUB_API_TOKEN  was incorporated since it was a travis build.
I ran the build 2 times just to make sure.

gonna spin up a Debian vm with qemu and see if I can replicate for you ;) pretty unfair for me to give you so little info.

I cant get a consistent result.. but I was limiting my token to only certain functions.. which ones are necessary?
I just had:
read:packages

You are correct its an API issue, and because its docker its not pulling global env.
I guess there still exists a problem.. here is the dump none the less:
#29 [linux/arm/v7 builder 4/7] RUN lastversion mutability/mlat-client --verb...
1784#29 2.738 INFO: Verbose output.
1785#29 2.740 INFO: Using cache directory: /root/.cache/lastversion.
1786#29 2.779 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/releases/latest" in the cache
1787#29 2.782 DEBUG: No cache entry available
1788#29 2.789 DEBUG: Starting new HTTPS connection (1): api.github.com:443
1789#29 3.236 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/releases/latest HTTP/1.1" 404 None
1790#29 3.251 DEBUG: Status code 404 not in (200, 203, 300, 301)
1791#29 3.264 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/tags?per_page=100" in the cache
1796#29 3.267 DEBUG: No cache entry available
1797#29 3.393 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/tags?per_page=100 HTTP/1.1" 200 None
1798#29 3.405 DEBUG: Updating cache with response from "https://api.github.com/repos/mutability/mlat-client/tags?per_page=100"
1799#29 3.406 DEBUG: Caching due to etag
1800#29 3.425 INFO: Checking tag v0.2.11 as version.
1801#29 3.428 INFO: Parsed as Version OK
1802#29 3.430 INFO: String representation of version is 0.2.11.
1803#29 3.439 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/git/commits/5dc5bda8af4cf090d4fdc958c43f195da79951d4" in the cache
1804#29 3.441 DEBUG: No cache entry available
1805#29 3.509 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/git/commits/5dc5bda8af4cf090d4fdc958c43f195da79951d4 HTTP/1.1" 200 None
1806#29 3.522 DEBUG: Updating cache with response from "https://api.github.com/repos/mutability/mlat-client/git/commits/5dc5bda8af4cf090d4fdc958c43f195da79951d4"
1807#29 3.524 DEBUG: Caching due to etag
1808#29 3.552 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/releases/tags/v0.2.11" in the cache
1809#29 3.554 DEBUG: No cache entry available
1810#29 3.634 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/releases/tags/v0.2.11 HTTP/1.1" 404 None
1811#29 3.645 DEBUG: Status code 404 not in (200, 203, 300, 301)
1812#29 3.648 INFO: Setting version as current selection: 0.2.11.
1813#29 3.649 INFO: Checking tag v0.2.10 as version.
1814#29 3.651 INFO: Parsed as Version OK
1815#29 3.652 INFO: String representation of version is 0.2.10.
1792#29 3.662 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/git/commits/59e3d57ec0772d0dc5d7cde5a02130548a584840" in the cache
1793#29 3.664 DEBUG: No cache entry available
1794#29 3.729 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/git/commits/59e3d57ec0772d0dc5d7cde5a02130548a584840 HTTP/1.1" 200 None
1795#29 3.738 DEBUG: Updating cache with response from "https://api.github.com/repos/mutability/mlat-client/git/commits/59e3d57ec0772d0dc5d7cde5a02130548a584840"
1816#29 3.743 DEBUG: Caching due to etag
1828#29 3.753 INFO: Checking tag v0.2.9 as version.
1829#29 3.754 INFO: Parsed as Version OK
1830#29 3.756 INFO: String representation of version is 0.2.9.
1831#29 3.765 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/git/commits/3ddaeb1609c4eaeee7a74d19534bc85995b0b43f" in the cache
1832#29 3.766 DEBUG: No cache entry available
1833#29 3.838 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/git/commits/3ddaeb1609c4eaeee7a74d19534bc85995b0b43f HTTP/1.1" 200 None
1834#29 3.850 DEBUG: Updating cache with response from "https://api.github.com/repos/mutability/mlat-client/git/commits/3ddaeb1609c4eaeee7a74d19534bc85995b0b43f"
1835#29 3.852 DEBUG: Caching due to etag
1836#29 3.862 INFO: Checking tag v0.2.8 as version.
1837#29 3.864 INFO: Parsed as Version OK
1838#29 3.865 INFO: String representation of version is 0.2.8.
1839#29 3.874 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/git/commits/89c18fedb2eaffc0e4807addb6cb65471a4e0379" in the cache
1840#29 3.876 DEBUG: No cache entry available
1841#29 3.954 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/git/commits/89c18fedb2eaffc0e4807addb6cb65471a4e0379 HTTP/1.1" 200 None
1842#29 3.967 DEBUG: Updating cache with response from "https://api.github.com/repos/mutability/mlat-client/git/commits/89c18fedb2eaffc0e4807addb6cb65471a4e0379"
1843#29 3.969 DEBUG: Caching due to etag
1844#29 3.982 INFO: Checking tag v0.2.7 as version.
1845#29 3.984 INFO: Parsed as Version OK
1846#29 3.985 INFO: String representation of version is 0.2.7.
1847#29 3.995 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/git/commits/43c13f07e9cc7d2b65626938363e1f420b69dbba" in the cache
1817#29 3.997 DEBUG: No cache entry available
1818#29 4.083 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/git/commits/43c13f07e9cc7d2b65626938363e1f420b69dbba HTTP/1.1" 200 None
1819#29 4.097 DEBUG: Updating cache with response from "https://api.github.com/repos/mutability/mlat-client/git/commits/43c13f07e9cc7d2b65626938363e1f420b69dbba"
1820#29 4.098 DEBUG: Caching due to etag
1821#29 4.109 INFO: Checking tag v0.2.6 as version.
1822#29 4.111 INFO: Parsed as Version OK
1823#29 4.112 INFO: String representation of version is 0.2.6.
1824#29 4.121 DEBUG: Looking up "https://api.github.com/repos/mutability/mlat-client/git/commits/84c8c8a2ac2b74a175f825f3798b31ea5429f6c9" in the cache
1825#29 4.123 DEBUG: No cache entry available
1826#29 4.180 DEBUG: https://api.github.com:443 "GET /repos/mutability/mlat-client/git/commits/84c8c8a2ac2b74a175f825f3798b31ea5429f6c9 HTTP/1.1" 403 None
1827#29 4.188 DEBUG: Status code 403 not in (200, 203, 300, 301)
1848#29 4.221 Traceback (most recent call last):
1852#29 4.221   File "/usr/local/bin/lastversion", line 8, in <module>
1853#29 4.221     sys.exit(main())
1854#29 4.221   File "/usr/local/lib/python3.8/site-packages/lastversion/lastversion.py", line 430, in main
1855#29 4.221     version = latest(args.repo, args.format, args.pre, args.newer_than, args.filter,
1856#29 4.221   File "/usr/local/lib/python3.8/site-packages/lastversion/lastversion.py", line 256, in latest
1857#29 4.221     the_date = r_commit.json()['committer']['date']
1858#29 4.221 KeyError: 'committer'

I think you're looking for public_repo permission which is listed as Access public repositories.
That probably would also need to be coupled with repo:status, like this:

Although I'm not really sure which correspond to which actual API endpoints.
But the issue really is that there should be a more graceful way to show that 403 API error as requiring a token or a token permission is missing (instead of the exception) :)

Looking again at the last build log, the token is not used at all, so I think you need to pass it somehow more explicitly to the docker build.

Spot on. It won’t error with the token. Docker problem is part.
But I think the error should be captured.
Sent with GitHawk

@ShoGinn the error should be captured in the new release.
In fact, it will also emit a warning in case
of the rate limit being exceeded, and wait for it to be recharged... An edge case, untested, but hopefully works, as this would improve reliability a lot..


fix: Update shopware operator version to 0.0.22

Fix the operator version to 0.0.22

Please also update the version of the chart itself


#375 Task instances link from template view page

Create a remote branch on github
Brach name should have following pattern
issue_<number>_githubId  for example pull request related to 81 by Manoj will be named as issue_81_magrawa
Go to eclipse and commit or stash your master branch changes and sync your workspace
Do a Git fetch
Now switch over to remote branch you created in github
Once you commit your changes to new branch you can follow instructions here for creating a pull request
Create a New Pull Request
Learn more about pull requests

Hi Don,
Kindly review the changes.
Thanks,
Vimala G.N

Hi Don,
I incorporated review comments.
Thanks,
Vimala G.N


Omni Core v0.4.0 Buffer overflow detected

I manage to setup Omni Core via PM2 and success 100% synced to the blockchain network.
However, Omni Core will shutdown after startup within a week and show message as below:
 *** buffer overflow detected ***: ./omnicored terminated
Due to PM2 Omni Core will perform auto restart but Omni Core run block scanning upon every restart.
Initializing Omni Core v0.4.0 [main]
Loading trades database: OK
Loading send-to-owners database: OK
Loading tx meta-info database: OK
Loading smart property database: OK
Loading master transactions database: OK
Loading fee cache database: OK
Loading fee history database: OK
Loading persistent state: NONE (no usable previous state found)
Scanning for transactions in block 249498 to block 569684..
Still scanning.. at block 255226 of 569684. Progress: 0.45 %, about 35:35 minutes remaining..
Still scanning.. at block 267989 of 569684. Progress: 1.36 %, about 23:39 minutes remaining..
Still scanning.. at block 270640 of 569684. Progress: 1.62 %, about 29:57 minutes remaining..
Still scanning.. at block 273643 of 569684. Progress: 1.98 %, about 32:43 minutes remaining..
Can anyone enlighten me ? Thanks.

I've been there . You can't skip this
It is recommended to operate under stable environment
And use the omnicore-cli to exit

I've been there . You can't skip this
It is recommended to operate under stable environment
And use the omnicore-cli to exit

Thanks for your info.

It is recommended to operate under stable environment

Server hardware is meet the requirement to run the node (2 CPU Core, 4GB RAM, 300GB SSD) and server is only running omni core program.

I've been there . You can't skip this

Can you share how you solve to prevent omni core down ?
I wonder setup a schedule task for every X interval to restart the omni core node via "omnicore-cli" is workable or not ?

I'm having similar problems after running client for about 1 week. I've started scheduling a weekly manual shutdown and relaunch of omnicore-qt.exe. I really wish I knew what would be done to improve performance as this problem continues to get worse and worse.
https://github.com/OmniLayer/omnicore/issues/905

I'm having similar problems after running client for about 1 week. I've started scheduling a weekly manual shutdown and relaunch of omnicore-qt.exe. I really wish I knew what would be done to improve performance as this problem continues to get worse and worse.
#905

Thanks for the sharing.
I also try the same action. I manual restart omni core (via pm2 restart) in a week.
Sometime restart omni core will not enter rescan block.
This is my temporarily solution for now.


PhpdocSeparationFixer started grouping "other" annotations together

After merging #6501 PhpdocSeparationFixer started removing blank lines between annotations similar to: @Method('GET'), @OA\Property(...), @Assert\NotBlank. Before, they could be freely grouped or separated and the fixer did not care.
Configuration
'phpdoc_separation' => true,

Code example
<?php declare(strict_types=1);

use OpenApi\Annotations as OA;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Component\Validator\Constraints as Assert;

class Test
{
    /**
     * @Assert\NotBlank
     * @Assert\Email
     *
     * @OA\Property(type="string")
     *
     * @Method('GET')
     */
    public string $property;
}

Fixer
Before:
PHP CS Fixer 3.10.0 (76d7da6) Oliva by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.1.10
Loaded config default from "/private/tmp/-/.php-cs-fixer.dist.php".
Using cache file ".php-cs-fixer.cache".
Paths from configuration file have been overridden by paths provided as command arguments.
.                                                                                1 / 1 (100%)
Legend: .-no changes, F-fixed, S-skipped (cached or empty file), I-invalid file syntax (file ignored), E-error

Checked all files in 0.003 seconds, 14.547 MB memory used

After:
PHP CS Fixer 3.11.0 Oliva by Fabien Potencier and Dariusz Ruminski.
PHP runtime: 8.1.10
Loaded config default from "/private/tmp/-/.php-cs-fixer.dist.php".
Using cache file ".php-cs-fixer.cache".
Paths from configuration file have been overridden by paths provided as command arguments.
F                                                                                1 / 1 (100%)
Legend: .-no changes, F-fixed, S-skipped (cached or empty file), I-invalid file syntax (file ignored), E-error
   1) Test.php (phpdoc_separation)
      ---------- begin diff ----------
--- /private/tmp/-/Test.php
+++ /private/tmp/-/Test.php
@@ -9,10 +9,8 @@
     /**
      * @Assert\NotBlank
      * @Assert\Email
-     *
      * @OA\Property(type="string")
-     *
      * @Method('GET')
      */
     public string $property;
 }
\ No newline at end of file

      ----------- end diff -----------

Checked all files in 0.008 seconds, 18.000 MB memory used

It's not a bug, it's a feature?
I'm not sure what is the correct behavior here. The rule's description states:

Annotations of a different type are separated by a single blank line.

If this was true and given that: @OA\Property and @Assert\NotBlank are of different type I would expect the fixer to convert
/**
 * @OA\Property(type="string", format="email")
 * @Assert\NotBlank()
 */
public string $foo;

into
/**
 * @OA\Property(type="string", format="email")
 *
 * @Assert\NotBlank()
 */
public string $foo;

Neither v3.10.0 nor v3.11.0 do it. It's because all tags not matching certain regex are being treated as "other". For this exact reason v3.11.0 forces them to be grouped together. I'm not sure why v3.10 does not.
Personally I liked it better when fixer ignored custom annotations while still forcing separation of standard tags, but I know it's a matter of preference.
Configurability
It's obvious that grouping annotations is non-trivial so #6501 is a great feature to have. But now it's impossible to keep the rule turned on while still being allowed to have some custom annotations separated. After upgrading to v3.11 we were forced to turn off the rule because it reduced the readability of our phpdocs.
I don't know what is the way to go here. I think I would expect the fixer to convert
// example1

/**
 * @param non-empty-string
 * @throws \LogicException
 * @return non-empty-string
 *
 * @Foo\Bar
 * @Foo\Baz
 *
 * @SomeOtherTag()
 */
public function property(string $foo): string

or
// example2

/**
 * @param non-empty-string
 * @throws \LogicException
 * @return non-empty-string
 *
 * @Foo\Bar
 * @Foo\Baz
 * @SomeOtherTag()
 */
public function property(string $foo): string

into
// expectedResult

/**
 * @param non-empty-string
 *
 * @throws \LogicException
 *
 * @return non-empty-string
 *
 * @Foo\Bar
 * @Foo\Baz
 *
 * @SomeOtherTag()
 */
public function property(string $foo): string

Note that conversion example1 -> expectedResult is possible in v3.10.0 but not in v3.11.0
The configuration could look like this:
'phpdoc_separation' => [
    'groups' => [
        ['deprecated', 'link', 'see', 'since'],
        ['author', 'copyright', 'license'],
        ['category', 'package', 'subpackage'],
        ['property', 'property-read', 'property-write'],
        ['foo'],
        ['someothertag'],
    ]
],

See #6668 for a fix proposal.


Storybook with our components

https://github.com/tuchk4/storybook-readme и https://github.com/tuchk4/storybook-readme/blob/master/packages/example-vue/components/MyButton/MyButton.vue

https://github.com/storybooks/storybook/tree/master/addons/actions

https://github.com/storybooks/storybook/tree/master/addons/knobs


Allowing .jsx extensions in webpack

I don't know if this is wanted, but I've used .jsx to identify components in personal and work projects.
We usually have it as a rule of thumb to have .jsx for files that export React Components and .js for files that do not include jsx syntax. This is both helpful to identify component files while scanning the project and is helpful when using editors that identify .jsx files to use JSX syntax highlighting instead of regular javascript highlight.
If this is not wanted feel free to close this 👍

I completely forgot to read your comments in the issues regarding this before opening the PR.
If you still think this should not be applied feel free to close it like stated above 😄

when using editors that identify .jsx files to use JSX syntax highlighting instead of regular javascript highlight.

Are there any editors that can’t be reconfigured to use .js instead?

No I guess all editors can be configured to do that. For me I haven't done that myself because the theme I'm using in Atom doesn't have the same highlighting for pure JS when using JSX.
Like I said, this is not a strong preference for me, just wanted to suggest it since I use it at work and in my own projects.
I have done my fair share of these setups so I feel comfortable ejecting my app to get this nitpick in.

I haven't done that myself because the theme I'm using in Atom doesn't have the same highlighting for pure JS when using JSX.

The bigger problem is that JSX theme is usually not just "JSX".
Most "JSX" themes highlight all of the modern JS including some extensions (like Flow, async/await, ES6 etc). And most "JS" themes don't even support ES6.
This is why making "JSX" themes default for .js would make more sense to me because generally they tend to be more up-to-date, and it's a strict superset of JS.
Does this logic apply in your case?

Yup, that sounds about right.
I've gotten used to my theme for .js and .jsx being while it's definitely not a problem to switch over.
Closing this as a result then 👍

FYI we support JSX extension since 0.4.1 even though we don’t recommend it.
Read the release notes.


cron: ignore latest snapshot (2.8.0-snapshot.20231213.0)

It's broken because of the drivers.

On the bright side, I get the hourly notification again.


Resolve symlinks using Node resolution mechanism

Copying my comment from #1107 since that issue is pretty crowded and I want it to be here instead.

Having read some discussions in https://github.com/nodejs/node/pull/6537 and https://github.com/isaacs/node6-module-system-change I think we're actually already being inconsistent in how we handle symlinks.
Let's forget about the issue about compiling source code for a second. I feel like that can be solved by https://github.com/facebookincubator/create-react-app/issues/1333 and thus is not the most important one here.
The important part here is that the resolution should match Node algorithm so that our webpack setup matches our test setup. I thought that was the case, but I was wrong.
Consider this structure:
my-comp
  index.js // already compiled
  package.json // react is a peer dependency

my-app
  node_modules
    my-comp // symlink to my-comp folder

It turns out that if my-comp doesn't declare a dependency on react, it can find React in the browser builds but not in tests.

We introduced this regression in https://github.com/facebookincubator/create-react-app/pull/1359.
We probably missed it because if my-comp does explicitly depend on React (e.g. as a devDependency), the test passes (and in the browser we just get two Reacts).

Is it somehow related to #3776?

I found a workaround that I use in my projects.  You can run a watch process to compile your shared library and use it as symlink in your project. Here is my gist.

Any progress on this? I'm game to help if there's work to be done.

Any progress or a workaround for this that doesn't require running a watcher compiler?

Any progress on this?

Is there a scenario where someone would prefer having dependencies read from linked node_modules instead from CRA-based project's node_modules? Modifying webpack.config.js to have { resolve: { symlinks: false } } fixes the "two react" problem.
If there is no scenario, then maybe CRA should have the value from above hardcoded?

Up

I believe #7993 will fix this.

Over at Vim we've arrived at a decent working solution using craco.
I've elaborated here: https://github.com/facebook/create-react-app/issues/3547#issuecomment-668842318


Build on Raspberry Pi OS Bullseye

Raspberry Pi OS 32 bit Bullseye
Kernel 5.10
gcc version 10.2.1
cmake version 3.18
Language C# but not getting past the librealsense compile
Steps at https://github.com/IntelRealSense/librealsense/blob/development/doc/installation_raspbian.md
include packages that no longer exist in the newer OS, all that end in -dbgsym
Not installing those packages I continued
sudo udevadm control --reload-rules && udevadm trigger
gets Permission denied, no issue I guess a reboot will reload that.
cmake .. -DBUILD_EXAMPLES=true -DCMAKE_BUILD_TYPE=Release -DFORCE_LIBUVC=true
fails with missing open ssl missing, so installed libssl-dev
cmake .. -DBUILD_EXAMPLES=true -DCMAKE_BUILD_TYPE=Release -DFORCE_LIBUVC=true
Warning dynamic exception specifications are deprecated in C++11
and then fails with
/usr/bin/ld: ../../librealsense2.so.2.49.0: undefined reference to __atomic_load_8' /usr/bin/ld: ../../librealsense2.so.2.49.0: undefined reference to __atomic_store_8'
/usr/bin/ld: ../../librealsense2.so.2.49.0: undefined reference to `__atomic_fetch_add_8'
collect2: error: ld returned 1 exit status
make[2]: *** [examples/hello-realsense/CMakeFiles/rs-hello-realsense.dir/build.make:110: examples/hello-realsense/rs-hello-realsense] Error 1
make[1]: *** [CMakeFiles/Makefile2:1219: examples/hello-realsense/CMakeFiles/rs-hello-realsense.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
Any ideas how to fix this error?

Hi @davidscherf  Intel's official Raspbian installation guide is designed for Raspberry Pi 3.  If you are using a Pi 4 then the similar guide by Acrobotic in the link below is recommended.
https://github.com/acrobotic/Ai_Demos_RPi/wiki/Raspberry-Pi-4-and-Intel-RealSense-D435
You may also have a smoother build experience if you update protobuf to a newer version than the ones recommended in the Intel and Acrobotic guides - 3.14 should be a suitable one.  You should be able to install this by setting the protobuf version to v3.14.0 in the guide's protbuf install instruction.
As -DFORCE_LIBUVC=true is being used, this means that the build should not be dependent on Linux versions or kernel versions and does not require patching.  So the 5.10 kernel (which is not yet officially supported by the RealSense SDK) and changes to Raspbian since Buster should not in theory be influencing factors on whether the build succeeds.
Installing the SDK with the libuvc backend method does require an internet connection though.  Can you confirm please whether you had an active internet connection at the time of your installation attempt, please?

I did not install protobuf in buster, so was not trying to install it on bullseye, nor am i trying to compile any of the samples
Yes the pi had internet while trying to compile the SDK, It should not need the internet to compile as I did not need it to compile in buster.
I have compiled the SDK in buster, and worked out that I need the 2 binary files and some files from the Documents folder, and have made a setup to just cp the binaries and ln them, and copying this to bullseye works.
No idea why there is not a deb file or something to do this instead of compiling, have not gotten in to deb files yet so no idea how to make one myself.
Hope the steps are updated for when Raspberry PI OS gets x64.

Thanks very much for the further information, @davidscherf - it is excellent to hear that you had success with Bullseye using your binary copying method!

Hi @davidscherf  Do you require further assistance with this case, please?  Thanks!

Although I have a workaround, compiling under an older OS, this does not fix the compile errors with the newer gcc

In https://github.com/IntelRealSense/librealsense/issues/9962 there are a couple of Pi users who have also been having Raspbian installation problems recently.  I connected them to the information that you shared in this case.

Hi @davidscherf  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.

Kindly share the details about the two binary files that need to be added... kindly support. Thank you

Can you kindly on this method ....#Bullseye using your binary copying method! your support is required.

Hey @davidscherf can you explain in more detail which binaries did you copy, and how did you copy them? Thanks!

These instructions are as per arm64 and a user of pi, make modification as per your requirements
Any file outside your home directory will obviously need sudo to copy it there
I hope i did not miss anything
udev rule
file is: /etc/udev/rules.d/99-realsense-libusb.rules
sudo udevadm control --reload-rules
sudo udevadm trigger

make sure the following folder exists

/home/pi/Documents/librealsense2/presets

the following files go in there

L535_Max_Range.preset
L535_Max_Range_With_Binning.preset
L535_Medium_Range.preset
L535_Min_Range.preset

make sure the following folder exists

/usr/local/lib/aarch64-linux-gnu

the following files go in there

libfw.a
libglfw3.a
librealsense-file.a
Following files in the folder above are version specific e.g here it is 2.49
librealsense2.so.2.49.0
librealsense2-gl.so.2.49.0
Setup sym links
sudo ln -s /usr/local/lib/aarch64-linux-gnu/librealsense2.so.2.49.0 /usr/local/lib/aarch64-linux-gnu/librealsense2.so.2.49
sudo ln -s /usr/local/lib/aarch64-linux-gnu/librealsense2.so.2.49.0 /usr/local/lib/aarch64-linux-gnu/librealsense2.so
sudo ln -s /usr/local/lib/aarch64-linux-gnu/librealsense2-gl.so.2.49.0 /usr/local/lib/aarch64-linux-gnu/librealsense2-gl.so.2.49
sudo ln -s /usr/local/lib/aarch64-linux-gnu/librealsense2-gl.so.2.49.0 /usr/local/lib/aarch64-linux-gnu/librealsense2-gl.so

If you want the viewer

put it in: /usr/local/bin/realsense-viewer
sudo chmod +x /usr/local/bin/realsense-viewer
export PATH=$PATH:/usr/local/bin
sudo ldconfig -p


Organic Farming Page

Organic farming block connects to a youtube video
I want to develop the page and embed the video in the page itself.

@Suchitra-Sahoo  please assign this issues me

I would love the opportunity to contribute and work on this project.
Could you please assign the issue to me? I’m eager to dive in and make a meaningful impact. Thank you for considering my request!


Add numExecutors and fix files option issue

Add numExecutors in POST Batch request;
Fix problem of https://github.com/cloudera/hue/issues/195

The --num-executors part looks good, but as I mentioned in #195, could you factor out the files:// section since it would allow malicious users to access livy files they shouldn't have access to?

Hi @erickt I've revert the files option related code~

Hi @erickt , another problem found when livy get status of an application, The code in Client.scala shown that yarnClient init with default YarnConfiguation which's yarn.resourcemanager.address is <IP_ADDRESS>:8032, for can't get application status, the batch status will keep in 'running'. So I reload the yarn-site.conf by env['HADOOP_CONF_DIR']

Thanks!


Add support for the Outlook plugin / markdown links

Is your feature request related to a problem? Please describe.
Tasks added through the Outlook plugin are displayed as a user-unfriendly paragraph of symbols followed by the email subject.

Describe the solution you'd like
I'd really like to see it displayed as a clickable link as it is in the Todoist app. Clicking on it opens the email in Outlook.

Describe alternatives you've considered
Right now I just exclude email tasks, @type_email, from the filter.
Additional context
Regarding markdown links - if this is at all in the same vein - there are two different styles:

If this should be added as a separate feature request, let me know. I kinda figured they were similar. 😅 ¯\(ツ)/¯
Let me know if/how I can help dig up info or troubleshoot. My Javascript ability is next to nil, but I am technical.

Hey @Wittionary, Markdown links should render correctly in v1.7.0!
As for the Outlook links, this isn't valid Markdown (in fact it clashes with Obsidian [[internal links]]), I'm also not a user of this functionality which makes it hard to test. I'm not going to implement this side of things, but am happy to review a PR for it.

Hey @Wittionary, Markdown links should render correctly in v1.7.0!
As for the Outlook links, this isn't valid Markdown (in fact it clashes with Obsidian [[internal links]]), I'm also not a user of this functionality which makes it hard to test. I'm not going to implement this side of things, but am happy to review a PR for it.


The app.config file is not loaded using Shuttle.Core.Host

I have created a wrapper assembly for the Shuttle ESB that loads all the service bus configuration (queues, routing, modules etc.) from a database and not an app.config file.
I am exposing this solution as a Nuget package so that other solution teams in our organisation can create endpoints enabling them to implement only their message handlers. Note that we have standardized hosting for our endpoints by using the Shuttle.Core.Host.exe solution.
The Shuttle.Core.Host scans for IHost implementation and picks it up from my wrapper/nuget package and tries to load the app.config of that assembly type and not the solution teams project's (that references the nuget package) app.config files.
Can you extend the Shuttle.Core.Host to allow a /configurationFile=somefile.config parameter to explicitly specify which config file must be loaded?
ps: StackOverlow refers: http://stackoverflow.com/questions/32583439/the-app-config-file-is-not-loaded-using-shuttle-core-host

Tested with the latest Shuttle,Core.Host NuGetPackage version 3.1.8 and it works as expected.
Thanks Neill


Warning about Alamofire not being safe for Application Extensions

When using the Promissum/Alamofire subspec you'll get the following warning:
ld: warning: linking against a dylib which is not safe for use in application extensions: /Users/[yada-yada]-iphonesimulator/Alamofire/Alamofire.framework/Alamofire

This is because Alamofire declares NOT to be safe for use in application extensions, while Promissum declares it is:
https://github.com/tomlokhorst/Promissum/blob/93439490f05a5d594f6453a87206ef8bcfd04adf/Promissum.podspec#L20

Tried 3 options:

❌ Move the pod_target_xcconfig into the subspec declarations and override, but this results in an error when running pod install: [!] Can't merge pod_target_xcconfig for pod targets: ["Alamofire", "Core", "UIKit"]. Singular build setting APPLICATION_EXTENSION_API_ONLY has different values.

✅ Put the pod_target_xcconfig in it's own subspec, this works as expected, but requires the user to do something.

✅ While testing this I noticed that if the app/extension target the pod is for requires APPLICATION_EXTENSION_API_ONLY then this will be applied to the Pods also. So I think that we can just remove the pod_target_xcconfig line from the podspec.


Feature request: Data flow between SNS, SQS, S3, Lambda

User story
As a cloud security auditor I would like to have a tool that shows me how AWS services exchange information so that I can better understand attack vectors.
I would like to see a new command in cloudmapper that graphs:

Messages sent to SNS topic X are sent to SQS queue Y
Lambda function Z is triggered when SQS Y message is received
S3Put on bucket W triggers ...

Requirements
If SNS topic X are sent to SQS queue Y and lambda function Z is called when a message arrives to SQS queue Y, then that should be graphed as three dots (X, Y, Z) with lines connecting X->Y , Y-Z.
References
Tweet

I don't have much time now, but will try to remember this issue for the future and might contribute with a PR.

I'm hesitant on mapping this as I've run into complexity problems with the network mapping capability of CloudMapper (by which I mean the visual maps are too complex too understand). As a start, it would be good to just identify and list off what these integrations are.  That would help us understand just how many integrations might exist and possibly what filtering should be done on these.

At least for now, these are the ones that come to mind:

SNS
SQS
API Gateway
S3
Cloudformation (can send messages to SNS topic with events on how a stack is applied)
Lambda

I don't imagine this generating very complex graphs. I imagine one big graph (like the ones shown by webserver subcommand) with N graphs that have 2 or 3 edges and 1 or 2 lines.
Each edge would be one of SNS, SQS, API gateway, etc. The lines are drawn when there is a config in the edge service that will somehow invoke / call / message the next edge.
N will be large only if the AWS account has many integrations. Most accounts, at least in my experience, will have ~20 of these. If they do heavy use of this patterns, then it might be near 100.

I'm closing this issue as the network diagram functionality of CloudMapper is no longer being maintained.  Other features of CloudMapper, such as the audit functionality, is still maintained. If someone is interested in maintaining the network diagram functionality they can look at the issues tagged unmaintained_functionality for all the issues related to this that have been closed as they will unfortunately not be worked on by me.


Examples: Vector representation of documents

Added a notebook showing how to represent documents as vectors and a few use cases of the obtained vectors.

This is a really nice notebook, but it is a bit long imho. I would suggest we break it into three parts (embeddings, word to doc similarity, maps). Perhaps there could also be a file with precomputed embeddings to avoid running the entire embeddings workflow just to get maps?
Just an idea. :)

I like this notebook too and I also agree with @ajdapretnar to split this notebook into three notebooks.

I also added requirements.txt file in the examples directory so please just add requirements required in this notebook.


Add XLSX file format

https://github.com/ucscXena/xena-GDC-ETL/blob/58873ce30a57fd5a0a237311c419d4ba06774592/xena_gdc_etl/xena_dataset.py#L160-L161
clinical data now having some different sheet name other than Clinical Data, so I was getting errors. For example:

WT Data in Clinical.9c8108fd-c55e-46f8-ac13-9a2d9fbd1a6e.xlsx [TARGET-WT]
Sample Submission in
Clinical.f16dfbd6-132c-4d37-80af-357f721a1cea.xlsx [TARGET-AML]
Data Element in
Clinical.74e823e2-5ffb-43ec-824c-364030dee4dc.xlsx [TARGET-AML] (this one is possibly not required).

Possible fix:

Only consider the first list regardless of its name.
Ignore the list if its name is Data Elements.

What is this pull request doing exactly? I don't quite understand

All of the raw data for TARGET clinical is in xlsx file format. So in this PR, we have added support for them.

Did a quick check on TARGET phenotype data. The file with "Data Element" is not even phenotype data. They are data description. Please hold on this and wait for more specifications. My guess is only files having "Clinical Data" sheet are real phenotype data; so I did it that way. But I need to check.

For Sample Submission in Clinical.f16dfbd6-132c-4d37-80af-357f721a1cea.xlsx, let's not wrangle in this file. This file is more about QAing the sample quality rather than clinical or phenotype data our users would be interested in. Users who would be interested in this data (like someone who is developing a new algorithm to estimate tumor content), will have the skills needed to get this data directly from the GDC rather than going through us.

@ayan-b WT Data in Clinical.9c8108fd-c55e-46f8-ac13-9a2d9fbd1a6e.xlsx [TARGET-WT] --> this looks like data on the slides. Is that true? If so, we should not wrangle it to be consistent with our wrangling of the TCGA data.

Only considering Clinical Data now (i.e., ignoring Data Elements and TARGET-WT).

Just so you know, it's probably not consistent but I code it that way to "skip" invalid phenotype xls trying to play with the EAFP style.

OK. I didn't make this clear. Let me try this. This is a design problem. Let's imagine clinical data is a dict for simplification.
For EAFP style, you don't check whether you have "Clinical Data" or not but just get it and catch error later:
def read_clinical(fileobj):
    return fileobj['Clinical Data']

dummy_fileobj = {
    'No Clinical Data': 'Nothing'
}
clin_dfs = []
try:
    df = read_clinical(dummy_fileobj)
    clin_dfs.append(df)
except Exception:
    print('No clinical data in this file. Skip and move on')

For LBYL style, you check before doing anything and you don't have to catch error later because there is no error expected:
def read_clinical(fileobj):
    if 'Clinical Data' not in fileobj:
        return
    return fileobj['Clinical Data']

dummy_fileobj = {
    'No Clinical Data': 'Nothing'
}
clin_dfs = []
# The following line will work no matter what keys are in dummy_fileobj
df = read_clinical(dummy_fileobj)
if df:
    clin_dfs.append(df)
else:
    print('No clinical data in this file. Skip and move on')

I thought you are trying to change EAFP to LBYL in this PR. But I was wrong. My initial implementation has flaws and your 3c0f539c5255c7e357c5e60c08b0cfacbacc200c should be right.


Creating image from input stream

I'm receiving images from a messaging system as blob.
Is it possible to create an IplImage from the blob in order to play with using other operators ?

@jchailloux: Were you ever able to figure this out? I am attempting the same sort of thing - sending a Mat object via messaging (rabbitmq, as a blob) to a Streams application. Then, trying to decode the image into a Mat object within Streams using the opencv toolkit so I can further process it.


python311Packages.publicsuffixlist: <IP_ADDRESS>30614 -> <IP_ADDRESS>30617

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 238227 run on x86_64-linux 1

6 packages built:

python310Packages.publicsuffixlist
python310Packages.publicsuffixlist.dist
python311Packages.publicsuffixlist
python311Packages.publicsuffixlist.dist
trustymail
trustymail.dist


start: update links from all docs

Many of these updates were missed when the last GS update happened, it seems (they're currently hitting redirects).
Others are updated per https://github.com/iterative/dvc.org/pull/3941.

[x] Do not merge this before parent PR ☝🏼

To reiterate, this is just link updates to avoid redirects (all are passing ☝🏼)
Just needs an approve + merge.
The failing check is wrong (Prettier bug).


Unexpected error parsing sass module

Describe the bug
When importing a react component into hydrogen (which uses vite) i get a vite error
11:27:24 AM [vite] Error when evaluating SSR module /src/components/Header.client.jsx?no-proxy:
/home/ubuntu/vite-error/node_modules/@mytheme/header-menu/dist/header-menu.module.scss:1
.middle-bar {
^
SyntaxError: Unexpected token '.'
at Object.compileFunction (node:vm:352:18)
at wrapSafe (node:internal/modules/cjs/loader:1026:15)
at Module._compile (node:internal/modules/cjs/loader:1061:27)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
at Module.load (node:internal/modules/cjs/loader:975:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Module.require (node:internal/modules/cjs/loader:999:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object. (/home/ubuntu/vite-error/node_modules/@mytheme/header-menu/dist/header-menu.js:8:51)
at Module._compile (node:internal/modules/cjs/loader:1097:14)
11:27:24 AM [vite] Error when evaluating SSR module /src/components/Header.client.jsx:
/home/ubuntu/vite-error/node_modules/@mytheme/header-menu/dist/header-menu.module.scss:1
Reproduction
https://github.com/micalexander/vite-error
System Info
Need to install the following packages:
  envinfo
Ok to proceed? (y)

  System:
    OS: Linux 5.11 Ubuntu 20.04.3 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Xeon(R) CPU E5-2609 0 @ 2.40GHz
    Memory: 5.84 GB / 15.58 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 17.3.0 - ~/.nvm/versions/node/v17.3.0/bin/node
    npm: 8.3.0 - ~/.nvm/versions/node/v17.3.0/bin/npm
  Browsers:
    Chrome: 97.0.4692.71
    Firefox: 95.0.1
  npmPackages:
    vite: ^2.7.0 => 2.7.10

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I can't npm install in the repro. Looks like it's using a private package:
npm ERR! code E404
npm ERR! 404 Not Found - GET https://node.bit.dev/<EMAIL_ADDRESS>- Not found
npm ERR! 404
npm ERR! 404  '@zoxllc/zox.ui.header-menu@https://node.bit.dev/<EMAIL_ADDRESS>is not in this registry.
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

According to the error message ?no-proxy. This doesn't seem to exist in Vite. Perhaps it's a bug in Hydrogen?

Closing due to lack of response, please provide a repro without the private package so this can be tested.


seekTo not working with slider

Describe the Bug
The seekTo function is not working with the slider because the duration is coming in as zero.
Steps To Reproduce
I tried to replicate the example app and got the same error.
Code To Reproduce
`const TrackProgress = () => {
const {position, duration} = useProgress(200);
function format(seconds) {
let hrs = Math.floor(seconds / 3600);
let mins = Math.floor((seconds % 3600) / 60);
let secs = Math.trunc(seconds % 60);
if (hrs > 0) {
  return `${hrs.toString().padStart(2, '0')}:${mins
    .toString()
    .padStart(2, '0')}:${secs.toString().padStart(2, '0')}`;
} else {
  return `${mins.toString().padStart(2, '0')}:${secs
    .toString()
    .padStart(2, '0')}`;
}

}
return (
<View
style={{
paddingHorizontal: horizontalScale(24),
justifyContent: 'center',
marginTop: horizontalScale(20),
}}>
<Slider
value={position}
minimumValue={0}
maximumValue={duration}
onSlidingComplete={TrackPlayer.seekTo}
thumbTintColor="#ffffff"
thumbStyle={styles.thumbStyle}
minimumTrackTintColor={'#2EC4B6'}
maximumTrackTintColor={'rgba(108, 122, 137,1)'}
trackStyle={styles.trackStyle}
allowTouchTrack
/>
<View
style={{
flexDirection: 'row',
justifyContent: 'space-between',
alignItems: 'center',
}}>
<Text
style={{
fontFamily: 'Open Sans',
fontSize: 14,
fontWeight: '400',
fontStyle: 'normal',
color: '#164E5A',
}}>
{format(position)}

<Text
style={{
fontFamily: 'Open Sans',
fontSize: 14,
fontWeight: '400',
fontStyle: 'normal',
color: '#164E5A',
}}>
{format(duration)}

);
};
export default TrackProgress;`
Replicable on Example App?
Can you replicate this bug in the React Native Track Player Example App?
Environment Info:
System:     OS: macOS 14.1.1     CPU: (8) arm64 Apple M2     Memory: 122.81 MB / 16.00 GB     Shell: 5.9 - /bin/zsh   Binaries:     Node: 20.6.0 - /opt/homebrew/bin/node     Yarn: 1.22.19 - /opt/homebrew/bin/yarn     npm: 9.8.1 - /opt/homebrew/bin/npm     Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman   Managers:     CocoaPods: 1.12.1 - /opt/homebrew/bin/pod   SDKs:     iOS SDK:       Platforms: DriverKit 23.0, iOS 17.0, macOS 14.0, tvOS 17.0, watchOS 10.0     Android SDK: Not Found   IDEs:     Android Studio: 2023.3 AI-233.14808.21.2331.11709847     Xcode: 15.0.1/15A507 - /usr/bin/xcodebuild   Languages:     Java: 20.0.1 - /usr/bin/javac   npmPackages:     @react-native-community/cli: Not Found     react: 18.2.0 => 18.2.0      react-native: 0.71.14 => 0.71.14      react-native-macos: Not Found   npmGlobalPackages:     *react-native*: Not Found
react-native-track-player : 4.1.1
Both Real device & simulator
Android & iOS

last time i checked the example apps slider works fine? can u post a screenshot of the example app unmodified  thay dhoes the slider is mot worlkng? cuz if it works the problem lies in your code or your media

@lovegaoshi, the same code is working through the notification panel. I tried using value * duration, but I noticed that the duration comes as 0.

Buddy i really shouldnt have to walk u through debug 101
is the example app also showing useProgress 0 as it is? i dont think so bc
useprogreess is used for the progress bar, but correct me if im wrong and
this will be a serious bug report.
then u put ur media src in the example app. if it works, ur code is wrong.
if not, ur media src is wrong. and if u dont post any of them nobody can
help even if they r bored enough. also dont expect people to read ur
codebase.
On Mon, Jun 10, 2024, 8:53 PM Dubey Abhishek Santoshkumar <
@.***> wrote:

@lovegaoshi https://github.com/lovegaoshi, the same code is working
through the notification panel. I tried using value * duration, but I
noticed that the duration comes as 0.
—
Reply to this email directly, view it on GitHub
https://github.com/doublesymmetry/react-native-track-player/issues/2323#issuecomment-2159729454,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZMOVVQFZIVOPLIEUJH3L3DZGZYCZAVCNFSM6AAAAABJB7XZPSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZG4ZDSNBVGQ
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

@lovegaoshi, I made changes to my code, and after placing the Slider component inside a View, it started working properly. but I still don't know the reason why the duration was coming to 0 because it was provided by the useProgress() hook.

@lovegaoshi, I don't understand the issue because it has started happening again.

u know without anymore info its brutal but sounds like ur react skill aint good causing this. if i were u id copy wahts already working, aka the example app and put ur app on top of that. unless the example app doesnt work then pls let someone know.

@lovegaoshi, I think the problem is with Slider. I'm using the react-native-element slider.

@lovegaoshi, Please check the code for the progress. I have used Slider from react-native-element. inside onSlidingComplete method I'm getting duration as 0. You can check the console log I'm sharing in the attachment.

`// import Slider from '@react-native-community/slider';
import React from 'react';
import {Dimensions, StyleSheet, Text, View} from 'react-native';
import { Slider } from 'react-native-elements';
import TrackPlayer, {useProgress} from 'react-native-track-player';
import {horizontalScale, moderateScale, verticalScale} from '../Matrices';
export const Progress = () => {
const {position, duration} = useProgress();
// This is a workaround since the slider component only takes absolute widths
const progressBarWidth = Dimensions.get('window').width * 0.88;
console.log('duration ', duration);
return (

<Slider
value={position}
minimumValue={0}
maximumValue={duration}
thumbTintColor="#ffffff"
thumbStyle={styles.thumbStyle}
minimumTrackTintColor={'#2EC4B6'}
maximumTrackTintColor={'rgba(108, 122, 137,1)'}
trackStyle={styles.trackStyle}
onSlidingComplete={() => {
console.log('---- duration 2----', duration)
TrackPlayer.seekTo()
}}
allowTouchTrack
// thumbImage={require('../../../assets/icons/ck-icon.png')}
/>

{format(duration - position)}

);
};
const formatSeconds = (time) =>
new Date(time * 1000).toISOString().slice(14, 19);
const styles = StyleSheet.create({
container: {
width: '100%',
// height: horizontalScale(48),
paddingHorizontal: horizontalScale(10),
paddingBottom: horizontalScale(20),
flexDirection: 'row',
justifyContent: 'center',
alignItems: 'center',
columnGap: horizontalScale(10),
},
progressBar: {
flex: 1,
// width: '78%',
justifyContent: 'center',
// alignItems: 'center',
},
trackStyle: {
height: verticalScale(3),
backgroundColor: 'transparent',
},
thumbStyle: {
width: horizontalScale(12),
height: horizontalScale(12),
borderRadius: horizontalScale(12),
backgroundColor: '#D9D9D9',
},
timeText: {
fontFamily: 'Open Sans',
fontSize: moderateScale(14),
fontStyle: 'normal',
fontWeight: '700',
color: '#FFFFFF',
}
});
export default Progress;
function format(seconds) {
let hrs = Math.floor(seconds / 3600);
let mins = Math.floor((seconds % 3600) / 60);
let secs = Math.trunc(seconds % 60);
if (hrs > 0) {
return ${hrs.toString().padStart(2, '0')}:${mins       .toString()       .padStart(2, '0')}:${secs.toString().padStart(2, '0')};
} else {
return ${mins.toString().padStart(2, '0')}:${secs       .toString()       .padStart(2, '0')};
}
}
`

again, dont expect people to read ur code. there are nice people doing this but its not the norm. im not bored enough to read ur unformatted code snippet for free, nor looking into a ui lib that i never used and would not ever use. the best i can give u is the example app which uve been avoiding this entire time, or a working slider example as it comes from my app.

@lovegaoshi thanks for the example code.


add example heroku hello email

as we discussed in #467

Hello @pangaunn,Thanks again for the PR! We appreciate your contribution and look forward to                                              continued collaboration. Thanks!                                             Team SendGrid DX


Add support for Pydantic 2

This adds support for Pydantic 2 in a backwards compatible way.
For anyone who wants to use this before it is merged, you can do:
pip3 install --upgrade git+https://github.com/MatthewScholefield/pydantic-sqlalchemy.git@master#egg=pydantic-sqlalchemy

I know there's a PR to add a notice to the README to deprecate the project, but I still feel the project is useful for cases where SQLModel isn't yet complete (ie. migrations which the docs are currently yet-to-be-written).

I'm dealing with a PR that just so happens to use this package and noticed this PR exists.
Just out of interest is there plans for this PR to be merged still? As the changes resolve a couple of depreceation warnings I'm getting. If not I'll probably just fork this as it seems to only be a small use case.

Thanks for the interest! And thanks for the patience with my reply. :sweat_smile:
I deprecated this library a while ago in favor of SQLModel which would solve all the same use cases in a much better way, and I'm directing all the effort in that direction, so sadly I wouldn't be able to take new features here (that would also need maintaining them).
Given that, I'll close this one, but thanks for the effort! :coffee:
Also, thanks for adding instructions for people to install your branch and test it, it might be useful for them during migrations.


Option to disable logging of dechunking  (2nd try)

[Issue #1068 - Marc Stern]

Under the buildbots - https://github.com/SpiderLabs/ModSecurity/tree/v2/dev/pull_1403

I've patched the code to address my own concerns. This is now merged.


Morning session peer to peer code review

You did a great Job however, I suggest you use css to remove the ul style in your book list.

Thank you Feven, working on that now. Have a nice day

You did a great job, well done.


Fix  frontend crashed due to agent state changed to error.

When agent state changed to error (maybe many kinds of exceptions), the frontend crashed:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@a58f41a). Click here to learn what that means.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1605   +/-   ##
=======================================
  Coverage        ?   53.98%
=======================================
  Files           ?       91
  Lines           ?     3738
  Branches        ?        0
=======================================
  Hits            ?     2018
  Misses          ?     1720
  Partials        ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I think I beat you to it 😄 https://github.com/OpenDevin/OpenDevin/pull/1597/files

https://github.com/OpenDevin/OpenDevin/pull/1597/files

😂😂 I'll close this pr.


changing name of keys in header

In my jekyll blog I am using title and description . Can you make the keys configurable so that I can make it work for my blog, too?

Happy to incorporate that!


[BUG] Unable to withdraw funds to the Gourly network

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

Screenshot

Log output

Log Output
paste log output...

Context (Environment)

Browsers Affected

[x] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari 11
[ ] Safari 10
[ ] IE 11

Unable to withdraw funds to the Gourly network

This should be resolved now @pape12377749. Please try again! Closing this issue for now, feel free to open if issue persists.