Collect functions with executable attribute into a debug info field

This change is

crates/cairo-lang-syntax/src/attribute/consts.rs line 39 at r1 (raw file):
Previously, orizi wrote…
so rename to something longer and more cumbersome - for example:
execution_entrypoint
if a test will create such a thing - won't compilation recreate a lot of functions?

I wonder whether it would make sense, to use it for marking a main function in cairo-run :thinking: In that case, user would need to use it directly.

crates/cairo-lang-compiler/src/lib.rs line 150 at r2 (raw file):
Previously, orizi wrote…
i think maybe this function should just not exist.
and similarly to how we call compile_contract_in_prepared_db which is contract aware,
and compile_test_prepared_db in the test runner - we should call this with a list of the requested artifacts specifically - which would be in the executable list - being plugin based here feels like is going to be bad.

Sorry, what do you mean by list of the requested artifacts :thinking: ?
The artifact here is just ProgramArtifact.

Previously, orizi wrote…
the idea is - same as test plugin that knows what are the relevant functions (so it can fill the artifacts) and the starknet plugin, so can a run builtin - no need for new special attributes - as it logically per such build target in any case.

Well, we would like to push for a generalization of the executable concept here, so that multiple tools (like cairo-run,  sncast-scripts, forge etc.) could rely on a single artifact format (sierra.json), without a need to define specialized targets for each tool in upstream (Scarb).

Previously, orizi wrote…
but this means that things like tests would need to rewrite their code - we probably don't want that as well

Hmm, I am not saying we will push for cairo-test rewrite, but rather that we have tools that are bound to be rewritten already (forge test collection) and would benefit from this. With Scarb procedural macros + executable tag combo, we can run forge tests compiled through Scarb without any additional artefacts -> just sierra.json, thus fully decoupling Forge from the Cairo compilation level. Rewriting cairo-run / sncast scripts to this would be not a lot more than a one-liner, while also providing additional advantages (namely, ability to run code compiled in release mode, without debug ids).

Ok, thanks so much for elaborating, it makes a lot more sense to me now!

i was talking about all plugins requiring rewriting their code for this to capture it

Well, in case of Forge, which would be the biggest beneficiary of this flow,  we need to have a plugin that rewrites test attributes anyway, to move the compilation to Scarb (for full Cairo version <> Forge version decoupling). It would not be an issue there at all.

probably not - so there would be a compilation for testing, with its artifacts, and a different one for proof running, or starknet, or anything of that kind.

While it's of course true, that we should not push for a single artefact format for all use cases, I would still argue that there is a middle ground here. We would not want to have dedicated compilation targets, hardcoded into Scarb, for all possible tools that run Cairo (i.e. Forge/Cast/Dojo/etc) either. Some of them will naturally fall into +/- the same requirements category, i.e. finding a function in Sierra program and running it (which this proposition would enable).

the artifacts should IMO be guided by the caller - instead of by annotation that will need to be added in all cases in the world

Do you think that we should have some per build input here, so we can only collect executables with specific keys? :thinking:

crates/cairo-lang-sierra-generator/src/executables.rs line 61 at r1 (raw file):
Previously, mkaput (Marek Kaput) wrote…
Retracting because I have a better idea.

No longer relevant.

crates/cairo-lang-sierra/src/debug_info.rs line 41 at r1 (raw file):
Previously, mkaput (Marek Kaput) wrote…
We're iterating the structure of this field internally/offline.

Done.

crates/cairo-lang-defs/src/plugin.rs line 112 at r6 (raw file):
Previously, mkaput (Marek Kaput) wrote…
It doesn't make sense to return vec::IntoIter here. Return an owned Vec (you'll boil down to the same thing). You could also return impl Iterator<Item=String>, but this trait is using in dyn context so this is impossible.

Done.

crates/cairo-lang-compiler/src/lib.rs line 163 at r8 (raw file):
Previously, orizi wrote…
does this actually make sense? isn't failing more logical?

Hmm, why? You can have a simple Cairo build without any plugins.

crates/cairo-lang-compiler/src/lib.rs line 163 at r8 (raw file):
Previously, orizi wrote…
You can - but it is meaning less building without a particular target.

I am not sure if I would call it meaning less. It's what we have now with the scarb lib target - it compiles Cairo to Sierra. It can be used for instance to run functions by name, it's what some tooling uses already, or even simply for debugging purposes. I don't think we are ready to abandon it completely now.

crates/cairo-lang-compiler/src/lib.rs line 163 at r8 (raw file):
Previously, orizi wrote…
so at the very least it makes no sense without --replace-ids.
and should probably have a todo to deprecate.

Yes, logically you are probably right. I don't think it's worth to ban this specific configuration though, especially since we would really have to verify with community if there is any use case we are yet not aware of.

Previously, orizi wrote…
sounds great - just add a TODO here.

Great, added!


SAA-2153: convert long term sick activity to unpaid

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.23%. Comparing base (01a00d2) to head (2f46c2d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1126   +/-   ##
=========================================
  Coverage     84.23%   84.23%
  Complexity     3726     3726
=========================================
  Files           383      383
  Lines         12635    12635
  Branches       1093     1093
=========================================
  Hits          10643    10643
  Misses         1492     1492
  Partials        500      500

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


TableState lost during re-render.

The table state is lost during a re-render. All filters, page-rows, and other related information are reset.
Example to re-produce the issue:
import React from "react";
import ReactDOM from "react-dom";
import MUIDataTable from "mui-datatables";
import {
  createMuiTheme,
  MuiThemeProvider,
  withStyles
} from "@material-ui/core/styles";

class App extends React.Component {
  constructor(props) {
    super(props);

    window.table = this;
  }
  getMuiTheme = () =>
    createMuiTheme({
      overrides: {
        MUIDataTable: {
          root: {
            backgroundColor: "#FF000"
          },
          paper: {
            boxShadow: "none"
          }
        },
        MUIDataTableBodyCell: {
          root: {
            backgroundColor: "#FF0000"
          }
        }
      }
    });

  render() {
    const columns = [
      {
        name: "Name",
        options: {
          filter: true
        }
      },
      {
        name: "Title",
        options: {
          filter: true
        }
      },
      {
        name: "Location",
        options: {
          filter: false
        }
      },
      {
        name: "Age",
        options: {
          filter: true
        }
      },
      {
        name: "Salary",
        options: {
          filter: true,
          sort: false
        }
      }
    ];

    const data = [
      ["Gabby George", "Business Analyst", "Minneapolis", 30, 100000],
      ["Aiden Lloyd", "Business Consultant", "Dallas", 55, 200000],
      ["Jaden Collins", "Attorney", "Santa Ana", 27, 500000],
      ["Franky Rees", "Business Analyst", "St. Petersburg", 22, 50000],
      ["Aaren Rose", "Business Consultant", "Toledo", 28, 75000],
      ["Blake Duncan", "Business Management Analyst", "San Diego", 65, 94000],
      ["Frankie Parry", "Agency Legal Counsel", "Jacksonville", 71, 210000],
      ["Lane Wilson", "Commercial Specialist", "Omaha", 19, 65000],
      ["Robin Duncan", "Business Analyst", "Los Angeles", 20, 77000],
      ["Mel Brooks", "Business Consultant", "Oklahoma City", 37, 135000],
      ["Harper White", "Attorney", "Pittsburgh", 52, 420000],
      ["Kris Humphrey", "Agency Legal Counsel", "Laredo", 30, 150000],
      ["Frankie Long", "Industrial Analyst", "Austin", 31, 170000],
      ["Brynn Robbins", "Business Analyst", "Norfolk", 22, 90000],
      ["Justice Mann", "Business Consultant", "Chicago", 24, 133000],
      [
        "Addison Navarro",
        "Business Management Analyst",
        "New York",
        50,
        295000
      ],
      ["Jesse Welch", "Agency Legal Counsel", "Seattle", 28, 200000],
      ["Eli Mejia", "Commercial Specialist", "Long Beach", 65, 400000],
      ["Gene Leblanc", "Industrial Analyst", "Hartford", 34, 110000],
      ["Danny Leon", "Computer Scientist", "Newark", 60, 220000],
      ["Lane Lee", "Corporate Counselor", "Cincinnati", 52, 180000],
      ["Jesse Hall", "Business Analyst", "Baltimore", 44, 99000],
      ["Danni Hudson", "Agency Legal Counsel", "Tampa", 37, 90000],
      ["Terry Macdonald", "Commercial Specialist", "Miami", 39, 140000],
      ["Justice Mccarthy", "Attorney", "Tucson", 26, 330000],
      ["Silver Carey", "Computer Scientist", "Memphis", 47, 250000],
      ["Franky Miles", "Industrial Analyst", "Buffalo", 49, 190000],
      ["Glen Nixon", "Corporate Counselor", "Arlington", 44, 80000],
      [
        "Gabby Strickland",
        "Business Process Consultant",
        "Scottsdale",
        26,
        45000
      ],
      ["Mason Ray", "Computer Scientist", "San Francisco", 39, 142000]
    ];

    const options = {
      filter: true,
      filterType: "dropdown",
      responsive: "stacked"
    };

    return (
      <MuiThemeProvider theme={this.getMuiTheme()}>
        <MUIDataTable
          title={"ACME Employee list"}
          data={data}
          columns={columns}
          options={options}
        />
      </MuiThemeProvider>
    );
  }
}

window.setInterval(() => {
  window.table.forceUpdate();
},5000)

ReactDOM.render(<App />, document.getElementById("root"));

Tested here:
https://codesandbox.io/embed/0ylq1lqwp0?autoresize=1&hidenavigation=1
Steps to reproduce:
Select a filter. Wait 5 seconds. -> Everything will be reset
Expected behavior:
All table state information are kept after re-render.
Note:
This doesn't re-produce the exact issue. With the version I'm testing what is interesting is that the rows per page are not reset, but the filters are reset, maybe this helps.

After further digging into the issue getting closer to the core issue:
Adding:
      onTableChange: (action, tableState) => {
       this.props.onTableChange(tableState);

      },
      searchText: this.props.outerState().searchText,

while saving the state outside the component, and passing via outerState()
will lead to searchText persisting/not getting reset during a re-render.
Now the only thing I'm seeing missing is the filters.
Passing filterList/filterData/columns from outerState into options does not achieve the desired result (leaves filters fully unaffected).
How can the filters be persistingly passed into the table?

Also having issues.  How can I set the tablestate?
Would like to do this:
const handleTableInit = (action, tableState) => {
      console.log('handleTableInit: ', tableState)
      if (_.isEqual({}, tableMultiSelect)) {
        setTableMultiSelect(tableState)
      } else {
        tableState = tableMultiSelect
      }
    }

I have a stepper with different tables and I want to keep the filtering if the user go back.

In the source code of MUIDataTable there is interestingly an implementation of the prevState
        if (this.options.serverSide) {
          newState = {
            ...newState,
            data: prevState.data,
            displayData: prevState.displayData,
            selectedRows: prevState.selectedRows,
          };
        }

It'd be great to have an option like "persisState" to keep the state after re-rendering.

I believe this is by design. The project is moving towards having the table state managed outside of the table, that way props are reflected in the table whenever the table is re-rendered (see https://github.com/gregnb/mui-datatables/issues/679). As for saving the filters, here's one possible way:
https://codesandbox.io/s/muidatatables-custom-toolbar-cxrdn
Not sure if this is the best way, I don't use filters in my project, but this is one way that works. Basically whenever a filter is changed, it's info is saved onto a prop that we pass into MuiDatatables. That way whenever we re-render the table with the props, the props have the most up-to-date information.
This code similuates the re-rendering:
window.setInterval(() => {
  setVal(val + 1);
}, 10000);

Simply comment out the code inside of "onFilterChange" to see the filters erased every 10 seconds.

@patorjk : Thanks. Now the only problem with this is if the columns are passed as props. That will automatically reset to the props on render.

The same fix suggested by @patorjk works for the columns (code slightly adjusted to class):
      onColumnViewChange: (changedColumn, display) => {
        console.log(name, display);
        var newCols = this.columns.slice();
        for (var ii = 0; ii < newCols.length; ii++) {
          if (newCols[ii].name === changedColumn) {
            newCols[ii].options.display = display == 'add'?true:false;
          }
        }
        this.setColumns(newCols);
      },

Thank you @Fabbok1x and @patorjk for helping me to reproduce.
This is a known issue, and it is partly related to some tension in the design of the table (internal derived state vs. props, as @patorjk alluded to).
The workaround for now is to manage your own state whenever you notice an issue like this. In the case of the filters, you can manage it via filterList in the column options (so whenever a filter would change, either through user action or table refresh, you add to the appropriate column manually). There is also some advice in this issue about column refreshing, which is a little different of an issue, but I offer a codesandbox solution in case it would be useful to you to see how I worked around that one: https://github.com/gregnb/mui-datatables/issues/784.

Where do you pass this.state.tableStatePersist to MUIDataTable? Does selecting rows work for you?

@kkaminski-github See step 3. this.state.tablePersist is not passed to MUIDataTable, but is used by getColumns() and getSearchText(). getColumns() is the function that updates this.state.tableColumns, which is, as shown in the example, assigned to the datatable's columns prop.
You want to put getColumns() in componentDidMount() and right before any other line of code that will cause a table refresh, such as repopulating the rows data from a server or something.

@SaberMage Is there a reason you can't store your state normally and pass it into the table, as in the example column-options-update?

@SaberMage Is there a reason you can't store your state normally and pass it into the table, as in the example column-options-update?

@gabrielliwerant I kind of see what you are suggesting. Really, my approach achieves a similar outcome to the example you mentioned. The key differences are:

Where the preliminary or "default" column options are defined, such as display and filterList. In mine, these are defined inline along with all the other column options. In that example, they are defined in state which I acknowledge is likely a technical better practice, but is ultimately a little more confusing/cumbersome to read.
In the example column-options-update, the only state auto-saved is the filterLists. The method I shared auto-saves all desired states anytime changes are made, so they may carry across re-renders. onTableChange is a useful event for knocking them all out in one spot.

Looking back at it, my method can probably be streamlined a bit more. For instance, I imagine getColumns() could be assigned directly to the columns prop of the MUIDataTable, meaning the state variable datatableColumns could be dropped altogether.

@SaberMage Sure, just thought I'd bring it up in case it would be beneficial to anyone. One of the goals of the table is to allow users to seed it initial data and then control it afterwards via state, although it is certainly not as easy or clear to do as it could be.

I gave up storing the tableState in the component state. And I'm going to leave this as a RFC or an idea for anyone with the same problem.
The basic approach is, every time the onTableChange is triggered, the table state will be stored using this.setState.
Now, imagine you are searching something, you type in a lot of text. Every character will trigger a table state change. Which means the table will re-render (with the new searchText as initial state) as many times as the amount of characters. In my case, state updates would get grouped, and typing would become really slow.
My alternative was to store that outside of the state, avoiding those extra re-renders. If by any means, the re-render method is called, only then I will retrieve the searchText again.

@pedroo21 A good way to handle this sort of problem is to handle the search text action of onTableChange differently from other onTableChange actions. More specifically, I recommend using setTimeout to update the state.
Here is a brainstorm of the steps:

Initialize a variable "delayStore" -- the scope should be within Class or higher, basically wherever the onTableChange function can access it from while keeping it persistent between onTableChange calls. I suppose it could alternatively be stored in state
Check if(delayStore). When the test passes, call clearTimeout(delayStore)
Now, assign to delayStore the result of a setTimeout() where the wait time is something sensible like 1000 (msec = 1sec) and pass a callback function with the following: a. Your state-storing code (make sure you pass table state to it), b. clearTimeout(delayStore), and c. delayStore = null

That's all. Now, the event of storing state is queued out by 1 second and that timer is canceled and reset every time the user changes the search text. Since people generally type more than one letter per second, this will result in a greatly reduced frequency of re-renders (the user must stop changing the text for at least a full second) caused by storing the updated table state. Of course, you can change the timing to whatever seems to work best, like maybe 3 sec would make more sense in some scenarios.

@pedroo21 you could use the customSearchRender method to create a search that only calls the table's internal search when the user has stopped typing.
As an aside, I've been experiementing with changing how the table works under the covers. One idea I had was to rollover state values for fields that the developer hasn't provided in the options object. So things like searchText, filters, sorting, etc, wouldn't reset when the table re-renders. You'd only have to track what you're controlling.
It was actually pretty simple to do. For example, below is how to make searchText persistent (this would go in the setTableData function):
let searchText = status === TABLE_LOAD.INITIAL ? this.options.searchText : null;
if (typeof this.options.searchText === 'undefined' && typeof this.state.searchText !== 'undefined') {
  searchText = this.state.searchText;
}

So far the only issues I've seen is that rowsExpanded and rowsSelected need to be reset if the data changes. But persisting other data doesn't (so far) seem to have any negative effects.

This PR would fix the issue: https://github.com/gregnb/mui-datatables/pull/1086

Hi! One question... I'm having some problems trying to store the column state after sorting and re-rendering the table. I'm using redux so I'm saving the "new state" on the store but when trying to set the table state on onTableInit, it's not working...

onTableInit fires after the table initializes, which includes the data, so it is not the right place to set state, as it will be too late. You do not need hooks into the table to use redux anyway, you just use as normal with your state that you feed into the table.

onTableInit fires after the table initializes, which includes the data, so it is not the right place to set state, as it will be too late. You do not need hooks into the table to use redux anyway, you just use as normal with your state that you feed into the table.

Ok, but the problem is when I change from that view to another and then go back to that previews view, the all the filters I made are lost

@SaberMage thank you for that work-around. I spent three days trying to fix this issue and your solution worked!

My issue was that I had a state variable that was being changed in the same component that I was rendering my MUI DataTable. Example:
const ExampleComponent = () => {
    const [foo, setFoo] = useState();

   return <MUIDataTable />
}

When I used setFoo(), the sorting was reset so what I did to persist this was by saving the direction and changedColumn to the component's local state and then set the sort direction on each individual column such as options: {         sortDirection: sortBy === 'column_name' ? direction : 'none',       },
You can use the onColumnSortChange option that will give you those two variables and you can save them to your local state. I hope this helped!

Hello, just wanted to post, what I've come up with. Maybe, it may helpt somebody:

I created a state to save search and filters:

const [filterAndSearchPersist, setFilterAndSearchPersist] = useState<{
   filterList: string[][];
   searchText: string | null;
 }>({ filterList: [], searchText: null });

Then I created a function to append the saved state to any columns:

function apendFilterListToColumns(
    columns: {
      name: string;
      label: string;
      options: MUIDataTableColumnOptions & {
        customFilterListOptions: { render: (v: string) => string };
      };
    }[],
    filterList: string[][]
  ) {
    filterList.forEach((filter, index) => {
      columns[index].options.filterList = filter;
    });
    return columns;
  }

Then in the table I used this function and in onTableChange I am listening for changes of search and filter:

<MUIDataTable
        title={"My Title"}
        data={data}
        columns={apendFilterListToColumns(
          columns,
          filterAndSearchPersist.filterList
        )}
        options={{
           searchText: filterAndSearchPersist.searchText ?? undefined,
           onTableChange: (action, tableState) => {
            switch (action) {
              case "filterChange":
                setFilterAndSearchPersist({
                  ...filterAndSearchPersist,
                  filterList: tableState.filterList,
                });
                break;
              case "search":
                setFilterAndSearchPersist({
                  ...filterAndSearchPersist,
                  searchText: tableState.searchText,
                });
            }

          },

I hope this helps somebody.

Table state is now persistent in the table as of version 2.15.0

Table state is now persistent in the table as of version 2.15.0

What do you mean 2.15.0? Are you still releasing 2x versions?

Table state is now persistent in the table as of version 2.15.0

What do you mean 2.15.0? Are you still releasing 2x versions?

No, this is an old issue. I closed it and just mentioned the version when it would have been fixed (2.15.0 was the first version I did as a maintainer and consisted of one of the PRs I mentioned above). I came upon this while researching another issue and closed it when I realized what it was referring to.
When I get some time I'll probably go through and close more issues, but closing issues is a low priority so it probably won't happen any time soon, but when I see an issue that can be closed, I'll close it.

@saikumar305
In my case, I wanted to persist the removal of a default filter, when the user deselects a row. Despite being less flexible, I opted to use a state to persist the list of filters from just one column, that stores ids. In my case, the column was the last, so I used filterList.at(-1) to reference it. You should change it based on your logic.
const [filterList, setFilterList] = useState([[myId]]);

const columns = [
  {
    name: 'id',
    label: 'custom Id',
    options: {
        display: 'true',
        filterList: filterList?.at(-1), // Change the position of your column here
    }
  }
]

Then, in your options object:
const options  = {
  onFilterChange: (changedColumn, filterList) => {
        setFilterList(filterList);
      },
}


Rendering data from API

Hi Bhavesh,
Can you please provide a sample for how to load data from API and render inside datatable in Vue3 Compostion API.
Thanks,
sathish

Hi Satish,
You just need to get data from API using Axios or any other library and need to pass in all data in rows which is already in our examples.
You can find all the examples with the source code from the below link:
https://vue3-datatable-document.vercel.app/

Hi Satish,
You just need to get data from API using Axios or any other library and need to pass in all data in rows which is already in our examples.
You can find all the examples with the source code from the below link:
https://vue3-datatable-document.vercel.app/

Hi @SathishNaqel,
Its good news!.
Now our datatable supports server-side rendering and its live in latest release version 1.1.0.
I have also updated all the demos in server side rendering. so you can find the code from that.


[SPARK-36789][SQL] Use the correct constant type as the null value holder in array functions

What changes were proposed in this pull request?

In array functions, we use constant 0 as the placeholder when adding a null value to an array buffer. This PR makes sure the constant 0 matches the type of the array element.
Why are the changes needed?

Fix a potential bug. Somehow we can hit this bug sometimes after https://github.com/apache/spark/pull/33955 .
Does this PR introduce any user-facing change?

No
How was this patch tested?

existing tests

Test build #143399 has started for PR 34029 at commit 4515a97.

cc @HyukjinKwon let's see if this can fix the test failure. My theory is JVM may need to box the value in some cases (JIT not triggered?) which causes type cast exception.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47908/

Merged to master, branch-3.2, branch-3.1 and branch-3.0.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47908/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47908/

Test build #143399 has finished for PR 34029 at commit 4515a97.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143399/


[FEATURE] Ship .vst3 plugin as well as installer

Since you must already build it can you also include the .vst3 file in the release zip so we can copy it directly rather than have to use the installer exe ?

I like this idea.

Can you help me understand why you'd want this?
A workaround right now would be to build from source; does that work for you?

@sdatkinson
First of all, thank you for your hard work. NAM works and it's amazing.
This issue would be convenience improvement, because different apps lookup different paths for VST-s and sometimes people have to copy from the install destination.
Also not everyone needs the stand alone app, only the VST.
An easier work around is to install and copy from VST destination.
Some people are afraid to run exe files because it's always a security risk.
An ideal solution would be to create a zip distributable near the installer exe file. I am not sure how difficult would it be.

I can take a look into implementing this if @sdatkinson is supportive. There are 2 options - either include the .vst3 file in the current zip package, or create a separate one just for it.

This issue would be convenience improvement, because different apps lookup different paths for VST-s and sometimes people have to copy from the install destination.

It seems to me like specifying the install location would be preferable and more in line with what I usually see? If this isn't part of it right now (I don't remember), then opening an Issue regarding it would be fine.

Also not everyone needs the stand alone app, only the VST.

The installer currently allows you to select which parts to install, so I think this part is ok.

Some people are afraid to run exe files because it's always a security risk.

That doesn't seem like a good reason--executable installers are the norm, and I'm happy to stick with it. It does sound reasonable, though to ask for signed installers so that Windows & Mac will stop shouting so much 😉 This is tracked in #185.

An ideal solution would be to create a zip distributable near the installer exe file. I am not sure how difficult would it be.

I'm actually not really keen to add artifacts to the releases--there has been confusion in the past when users saw more than one thing that looked like it might be the right thing to download. Given that lesson, I'd like to keep it to one artifact per OS.

Since I think that the points in this issue are either resolved or would be better tracked in a narrower-scoped issue, I'm closing this.


Breakable PinJoints

It would be nice if there was a "breakable" mode on the pin joints in Godot. All you would have to do is detect the distance between the two physics bodies and if it is a certain distance, the joint would disable itself. This will help with a lot of joint systems such as a breakable building, a ragdoll, and whatever else you would need it for. I would find this a very useful feature.

@ConfusedCoder85 Pull requests are for when you've written code and are trying to add it to the engine, they are not the right place to put feature requests. Consider checking out the proposals repository.


Individual Category Sorting

Describe your suggested feature
I don't know if any other fork has this or if this is only a thing with the older UI, but I'd really like to be able to set different sorting styles to categories. I saw someone already request drag & drop back in January, which is a feature I also use with one category. However, the other categories I have on J2K are set as last read while some are set as alphabetical. I can't really do that in Komikku (or maybe that's just now the new UI is in general right now).
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an official extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version 1.11.2.
[X] I will fill out all of the requested information in this form.

It is actually possible to do that already. Go to More > Settings > Library > Per-category settings for sort

Oh, ok. I didn't know that's what that was. I do hope drag & drops get added to the options.

I'm less tempted to do custom order (drag/drop) since it will add more data to database, also handling order change when new entry added or removed from the categories is no good. One entry can be in several categories is another added complexity.
One more thing, I guess this feature is wanted when new users starting with a few entries in library at first. But eventually, when using the app for long time, more and more entries will be added to libraries and it's pointless to do custom order.

Idk about some others but having a custom order is helpful depending on the category for me. I have 584 local files organized into 7 categories. One 1 of them is using drag & drop, this has about 20 entries, bc of how I plan to read them. More control, I guess, is what people who use drag & drop want it for. Not really to use it for every category or ones will huge entries.
Then again, that's is just me and how I use it.


When will the picoScan100 drivers be released?

I'm trying to run a picoScan100 scanner, but I can't find the drivers, are they already available or will they be released?

Thanks for your feedback. A prerelease of sick_scan_xd for picoScan150 Core w/o Add On (picoScan100) is available in branch feature/api_logging.

Great, while the driver itself isn't really stable and mature yet, I got it to work and like the results, is there a roadmap for a release of the product/driver?

Support for picoScan100 devices will be added in the next release. Can you be more specific about "the driver itself isn't really stable and mature yet"? Is there a driver bug related to the new picoScan100 or a general instability? In case of sick_scan_xd issues, please do not hesitate to provide specific details.

Starting, restarting and stopping doesn't work and I had to reboot the device a few times, the launch file looks a bit messy and I think needs some polish. I can't go trough each point here, since I'm not part of your test departement, but it's obvious that it needs more polish. But I'm excited to work with it when it comes out.


WIP: Refactor of cloud game overlord and overworker

Work In Progress.
Fixes #68

@_@ wow, it's a massive change. When it finishes, it gonna be awesome. (y)

@giongto35 Hope so. I am still doing the changes. Hopefully, you can start to review some part from now. :) Thanks, man.

Yes I'm checking :P

I have a new update on encoder. You may need to introduce new files.
https://github.com/giongto35/cloud-game/pull/70/files
added files:

encoder/type.go
h264encoder/encoder.go

@giongto35 Go ahead and merge, please. I will fix the conflicts in my branch. :)

@giongto35 I have fixed all the merge issues. But while running My game is failing as my nanoarc.go:L345 is failing to find the game. I have moved the emulators to assets/emulator/libretro/cores directory as I think this is more appropriate palace. Can help me with this. What is this url represents? Is it relative to something? Or I need to put the .so files in the same directory?

To me the problem looks like a Mac issue. Did you happen to encounter this problem before? Let me know. @giongto35

@giongto35 I have completed the first version of refactoring the code.  Apart from the issue with C.dlopen everything else works fine. Please have a look. Help fix the error and if its looks okay - lets merge it. For reference, we need to fix the following in future iterations for refactoring

Use flags embedded in binary instead of global flags
Few more code refactoring inside overlord and worker codes
Rewrite Readme
Organize and fix docker files and builds
Get rid of pkg/config and reorganize pkg/util
Write E2e tests and move main_test.go to tests/e2e using ginkgo - example - https://github.com/appscode/voyager/blob/master/test/e2e/e2e.go

Sorry @sadlil, I have a problem of github notification, so I forgot to check. :D
This is massive and necessary. I 'm not aware of the problem with Mac because I develop it on Ubuntu. You re so good figuring it out.
And I prioritize your merge, Hopefully to get it merged today or tomorrow. Will not spoil any conflict :p

@giongto35 It okay. No worries. Take your time to review and please have a short testing session to check everything works well with this patch.

FYI, vendor removed all C files related to x264 :( . I need to use https://github.com/goware/modvendor to get it back.
BTW, I saw you using vendor but don't have any script based on vendor. I think vendor can only help when we build with -mod=vendor

I love the new log <3


chore(main): release 0.5.2

:robot: I have created a release beep boop
0.5.2 (2023-10-26)
Bug Fixes

remote.py error handling needs to shore up plugin error (#311) (b47b07f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Autodesk/pgbelt/releases/tag/v0.5.2 :sunflower:


mvn license:format fails for JfrUnit

Running mvn license:format fails for JfrUnit:
[ERROR] Failed to execute goal com.mycila:license-maven-plugin:4.0.rc2:format (default-cli) on project jfrunit: Execution default-cli of goal com.mycila:license-maven-plugin:4.0.rc2:format failed: Cannot read header document ${rootdir}/etc/license.txt. Cause: Resource ${rootdir}/etc/license.txt not found in file system, classpath or URL: no protocol: ${rootdir}/etc/license.txt

@aalmiray, any idea about this one?

Yes, you must run a lifecycle phase that turns on the whistles such as mvn initialize license:format. This is due to the bindings created by the parent pom.

Interesting, first time I'm seeing this; and I thought I'd know Maven quite well :) So probably good enough to document it in the README then.


Add ganeshpatil386386

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

I added the name after 438  line

Done with requested changes

@ganeshpatil386386 @Panquesito7 @Pradumnasaraf shouldn't the name be after line 437 ? Thank you.

No, it's correct, in my view, because h comes before I
For eg:
- [Ganesh ]
- [Genesia ]
- [Genesib ]
.
.
- [Genesis ]

The name on line 437 is Ganesh Balaji Radhakrishnan and the pull request is trying to add the name Ganesh Patil The first name is the complete same as eachother, but due to the second name, it should go one line under. confused I am a bit confused though.

The problem is old has added incorrectly, I guess
__
  Tags: Inefficient

Hey! Do you need any help with this? If so, do let us know. 🙂


Fix [Beetlesbot] (https://github.com/bleeptrack/beetlesbot/) in README.md

Remove the whitespace between [Beetlesbot] and the link (https://github.com/bleeptrack/beetlesbot/)
enjoy that you've solved the bug, and add one more project to the list!

Can I get this?

Yes! Go forward @pheliperocha !

Awesome, thanks for contributing!


Integrate 2 factor authentication via Phone text (similar to what's app)

Hey! great project. I was wondering if it is possible to integrate 2 factor authentication? Something similar to what whatsApp does. Like it sends a text and reads the text itself (without having the user to re-enter the text).

I have not put any work into this for a while. I do need to clean it up and add more but that is low on my list of things to do. Feel free to help out and contribute if you want


Error: Component "@sls-next/-component@undefined" was not found on NPM nor could it be resolved locally.

Before opening, please confirm:

[X] I have searched for duplicate or closed issues and discussions.
[X] I have read the guide for submitting bug reports.
[x] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

JavaScript Framework
Next.js
Amplify APIs
Authentication, GraphQL API, Storage
Amplify Categories
auth, storage, api, hosting
Environment information

2021-09-06T09:07:04.419Z [INFO]: # Executing command: npx envinfo --system --binaries --browsers --npmPackages --duplicates --npmGlobalPackages
2021-09-06T09:07:05.146Z [WARNING]: npx: installed 1 in 0.689s
2021-09-06T09:07:09.783Z [INFO]: System:
                                 OS: Linux 4.14 Amazon Linux 2
                                 CPU: (4) x64 Intel(R) Xeon(R) Platinum 8124M CPU @ 3.00GHz
                                 Memory: 3.20 GB / 7.45 GB
                                 Container: Yes
                                 Shell: 4.2.46 - /bin/bash
                                 Binaries:
                                 Node: 12.21.0 - ~/.nvm/versions/node/v12.21.0/bin/node
                                 Yarn: 1.22.0 - ~/.yarn/bin/yarn
                                 npm: 6.14.11 - ~/.nvm/versions/node/v12.21.0/bin/npm
                                 npmPackages:
                                 @ampproject/toolbox-optimizer:  undefined ()
                                 @aws-amplify/ui-react: ^1.2.13 => 1.2.13
                                 @babel/core:  undefined ()
                                 @next/bundle-analyzer: ^11.1.0 => 11.1.2
                                 @sls-next/serverless-component: ^3.3.0 => 3.3.0
                                 @vercel/nft:  undefined ()
                                 amphtml-validator:  undefined ()
                                 arg:  undefined ()
                                 async-retry:  undefined ()
                                 async-sema:  undefined ()
                                 autoprefixer: ^10.3.4 => 10.3.4
                                 aws-amplify: ^4.2.7 => 4.2.7
                                 bfj:  undefined ()
                                 cacache:  undefined ()
                                 ci-info:  undefined ()
                                 cli-select:  undefined ()
                                 comment-json:  undefined ()
                                 compression:  undefined ()
                                 conf:  undefined ()
                                 content-type:  undefined ()
                                 cookie:  undefined ()
                                 cross-spawn:  undefined ()
                                 css-loader:  undefined ()
                                 debug:  undefined ()
                                 devalue:  undefined ()
                                 escape-string-regexp:  undefined ()
                                 eslint: ^7.32.0 => 7.32.0
                                 eslint-config-next: ^11.0.1 => 11.1.2
                                 eslint-config-prettier: ^8.3.0 => 8.3.0
                                 file-loader:  undefined ()
                                 find-cache-dir:  undefined ()
                                 find-up:  undefined ()
                                 fresh:  undefined ()
                                 glob:  undefined ()
                                 gzip-size:  undefined ()
                                 http-proxy:  undefined ()
                                 ignore-loader:  undefined ()
                                 is-animated:  undefined ()
                                 is-docker:  undefined ()
                                 is-wsl:  undefined ()
                                 json5:  undefined ()
                                 jsonwebtoken:  undefined ()
                                 loader-utils:  undefined ()
                                 lodash.curry:  undefined ()
                                 lru-cache:  undefined ()
                                 mini-css-extract-plugin:  undefined ()
                                 nanoid:  undefined ()
                                 neo-async:  undefined ()
                                 next: ^11.1.2 => 11.1.2
                                 next-themes: ^0.0.15 => 0.0.15
                                 ora:  undefined ()
                                 postcss: ^8.3.6 => 8.3.6 (8.2.15)
                                 postcss-flexbugs-fixes:  undefined ()
                                 postcss-loader:  undefined ()
                                 postcss-preset-env:  undefined ()
                                 postcss-scss:  undefined ()
                                 prettier: ^2.3.2 => 2.3.2
                                 react: 17.0.2 => 17.0.2
                                 react-dom: 17.0.2 => 17.0.2
                                 react-dropzone: ^11.3.4 => 11.3.4
                                 react-hook-form: ^7.15.0 => 7.15.0
                                 react-redux: ^7.2.5 => 7.2.5
                                 react-table: ^7.7.0 => 7.7.0
                                 recast:  undefined ()
                                 redux: ^4.1.1 => 4.1.1
                                 redux-define: ^1.1.1 => 1.1.1
                                 redux-devtools-extension: ^2.13.9 => 2.13.9
                                 redux-saga: ^1.1.3 => 1.1.3
                                 redux-saga/effects:  undefined ()
                                 reselect: ^4.0.0 => 4.0.0
                                 resolve-url-loader:  undefined ()
                                 sass-loader:  undefined ()
                                 schema-utils:  undefined ()
                                 semver:  undefined ()
                                 send:  undefined ()
                                 source-map:  undefined ()
                                 string-hash:  undefined ()
                                 strip-ansi:  undefined ()
                                 tailwindcss: ^2.2.7 => 2.2.9
                                 terser:  undefined ()
                                 text-table:  undefined ()
                                 unistore:  undefined ()
                                 web-vitals:  undefined ()
                                 webpack:  undefined ()
                                 webpack-sources:  undefined ()
                                 zen-observable:  undefined ()
                                 npmGlobalPackages:
                                 @aws-amplify/cli: 5.4.0
                                 bower: 1.8.12
                                 cypress: 6.6.0
                                 gatsby-cli: 3.0.0
                                 grunt-cli: 1.3.2
                                 npm: 6.14.11
                                 sm: 0.2.12-rc.1
                                 vuepress: 1.8.2

Describe the bug
When amplify generate a build, the build fail and the error say "Error: Component "@sls-next/-component@undefined" was not found on NPM nor could it be resolved locally" like it doesn't know the name of the library to import.
When i try to reproduce this bug on my local machine it doesn't seem to have any problem.
Expected behavior
I expect the build to end succesfuly
Reproduction steps
I can not reprocude this bug outside the amplify hosting
Code Snippet
BuildLog:
2021-09-06T09:03:20.429Z [INFO]: Git SSH Key acquired
2021-09-06T09:03:20.503Z [INFO]: # Cloning repository: git@github.com:Starting-Finance/sf-app-backoffice.git
2021-09-06T09:03:20.511Z [INFO]: Agent pid 136
2021-09-06T09:03:20.542Z [INFO]: Identity added: /root/.ssh/git_rsa (/root/.ssh/git_rsa)
2021-09-06T09:03:20.793Z [INFO]: Cloning into 'sf-app-backoffice'...
2021-09-06T09:03:21.312Z [INFO]: Warning: Permanently added the RSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
2021-09-06T09:03:22.525Z [INFO]: # Switching to commit: c68d3f777349b74babd3d3d4c14009f8480d92a2
2021-09-06T09:03:22.541Z [INFO]: Agent pid 149
2021-09-06T09:03:22.542Z [INFO]: Identity added: /root/.ssh/git_rsa (/root/.ssh/git_rsa)
                                 Note: switching to 'c68d3f777349b74babd3d3d4c14009f8480d92a2'.
                                 You are in 'detached HEAD' state. You can look around, make experimental
                                 changes and commit them, and you can discard any commits you make in this
                                 state without impacting any branches by switching back to a branch.
                                 If you want to create a new branch to retain commits you create, you may
                                 do so (now or later) by using -c with the switch command. Example:
                                 git switch -c <new-branch-name>
                                 Or undo this operation with:
                                 git switch -
                                 Turn off this advice by setting config variable advice.detachedHead to false
                                 HEAD is now at c68d3f7 update all dependecy
2021-09-06T09:03:22.549Z [INFO]: Successfully cleaned up Git credentials
2021-09-06T09:03:22.549Z [INFO]: # Checking for Git submodules at: /codebuild/output/src237934045/src/sf-app-backoffice/.gitmodules
2021-09-06T09:03:22.573Z [INFO]: # Retrieving environment cache...
2021-09-06T09:03:22.601Z [INFO]: # Retrieved environment cache
2021-09-06T09:03:22.602Z [INFO]: ---- Setting Up SSM Secrets ----
2021-09-06T09:03:22.602Z [INFO]: SSM params {"Path":"/amplify/d2k9a1cllgs6e/dev/","WithDecryption":true}
2021-09-06T09:03:22.650Z [INFO]: # Ensuring NPM package '@aws-amplify/cli' is version: 'latest'
2021-09-06T09:03:27.873Z [INFO]: # Patching NPM package '@aws-amplify/cli' from 4.29.4 to 5.4.0...
2021-09-06T09:04:25.623Z [INFO]: # Done patching NPM package '@aws-amplify/cli'
2021-09-06T09:04:26.043Z [INFO]: # Retrieving cache...
2021-09-06T09:04:26.063Z [INFO]: # Extracting cache...
2021-09-06T09:04:26.074Z [INFO]: # Extraction completed
2021-09-06T09:04:33.023Z [INFO]: ## Starting Backend Build
                                 # Starting phase: build
2021-09-06T09:04:42.331Z [INFO]: Amplify AppID found: d2k9a1cllgs6e. Amplify App name is: sf-app-backoffice
2021-09-06T09:04:42.381Z [INFO]: Backend environment dev found in Amplify Console app: sf-app-backoffice
2021-09-06T09:04:43.235Z [WARNING]: - Fetching updates to backend environment: dev from the cloud.
2021-09-06T09:04:43.902Z [WARNING]: ✔ Successfully pulled backend environment dev from the cloud.
2021-09-06T09:04:44.204Z [INFO]:
2021-09-06T09:04:47.568Z [INFO]: Note: It is recommended to run this command from the root of your app directory
2021-09-06T09:04:53.052Z [WARNING]: - Initializing your environment: dev
2021-09-06T09:04:53.685Z [WARNING]: ✔ Initialized provider successfully.
2021-09-06T09:05:02.399Z [WARNING]: - Uploading files...
2021-09-06T09:05:02.408Z [WARNING]: - Uploading files...
2021-09-06T09:05:02.412Z [WARNING]: - Uploading files...
2021-09-06T09:05:02.419Z [WARNING]: - Uploading files...
2021-09-06T09:05:02.579Z [WARNING]: - Uploading files...
2021-09-06T09:05:04.950Z [WARNING]: - Uploading files...
2021-09-06T09:05:05.979Z [INFO]:
                                 GraphQL schema compiled successfully.
                                 Edit your schema at /codebuild/output/src237934045/src/sf-app-backoffice/amplify/backend/api/SfAppBackofficeAppSync/schema.graphql or place .graphql files in a directory at /codebuild/output/src237934045/src/sf-app-backoffice/amplify/backend/api/SfAppBackofficeAppSync/schema
2021-09-06T09:05:05.986Z [WARNING]: - Uploading files...
2021-09-06T09:05:06.303Z [WARNING]: - Updating resources in the cloud.  Your app can only send SMS messages to verified recipient phone numbers.
                                 To add verified test phone numbers or request to move to production, go to the SNS console: https://console.aws.amazon.com/sns/v3/home#/mobile/text-messaging
2021-09-06T09:06:10.141Z [INFO]:
2021-09-06T09:06:10.195Z [INFO]: Initialized your environment successfully.
2021-09-06T09:06:10.195Z [INFO]: Your project has been successfully initialized and connected to the cloud!
                                 Some next steps:
                                 "amplify status" will show you what you've added already and if it's locally configured or deployed
                                 "amplify add <category>" will allow you to add features like user login or a backend API
                                 "amplify push" will build all your local backend resources and provision it in the cloud
                                 "amplify console" to open the Amplify Console and view your project status
                                 "amplify publish" will build all your local backend and frontend resources (if you have hosting category added) and provision it in the cloud
                                 Pro tip:
                                 Try "amplify add api" to create a backend API and then "amplify publish" to deploy everything
2021-09-06T09:06:13.290Z [INFO]: # Completed phase: build
                                 ## Completed Backend Build
2021-09-06T09:06:13.292Z [INFO]: ## Starting Frontend Build
                                 # Starting phase: preBuild
                                 # Executing command: npm install
2021-09-06T09:06:21.954Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
2021-09-06T09:06:28.272Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS>Please upgrade to @mapbox/node-pre-gyp: the non-scoped node-pre-gyp package is deprecated and only the @mapbox scoped package will recieve updates in the future
2021-09-06T09:06:31.599Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
2021-09-06T09:06:31.650Z [WARNING]: npm WARN
2021-09-06T09:06:31.651Z [WARNING]: deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
2021-09-06T09:06:33.409Z [WARNING]: npm WARN deprecated<EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
2021-09-06T09:06:33.484Z [WARNING]: npm WARN deprecated
2021-09-06T09:06:33.485Z [WARNING]<EMAIL_ADDRESS>this library is no longer supported
2021-09-06T09:07:01.702Z [INFO]: ><EMAIL_ADDRESS>install /codebuild/output/src237934045/src/sf-app-backoffice/node_modules/aws-crt
                                 > node ./scripts/install.js
2021-09-06T09:07:02.458Z [INFO]: ><EMAIL_ADDRESS>postinstall /codebuild/output/src237934045/src/sf-app-backoffice/node_modules/core-js-pure
                                 > node -e "try{require('./postinstall')}catch(e){}"
2021-09-06T09:07:02.943Z [INFO]: ><EMAIL_ADDRESS>postinstall /codebuild/output/src237934045/src/sf-app-backoffice/node_modules/aws-sdk
                                 > node scripts/check-node-version.js
2021-09-06T09:07:03.766Z [WARNING]: npm notice
2021-09-06T09:07:03.767Z [WARNING]: created a lockfile as package-lock.json.  You must install peer dependencies yourself.
2021-09-06T09:07:03.791Z [WARNING]: npm
2021-09-06T09:07:03.791Z [WARNING]: WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
2021-09-06T09:07:03.796Z [WARNING]: npm
2021-09-06T09:07:03.796Z [WARNING]: WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
2021-09-06T09:07:03.800Z [WARNING]: npm
2021-09-06T09:07:03.800Z [WARNING]: WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
2021-09-06T09:07:03.807Z [WARNING]: npm
2021-09-06T09:07:03.807Z [WARNING]: WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta but none is installed. You must install peer dependencies yourself.
2021-09-06T09:07:03.807Z [WARNING]:
2021-09-06T09:07:03.814Z [INFO]: added 2520 packages from 1081 contributors and audited 2526 packages in 50.22s
2021-09-06T09:07:04.377Z [INFO]: 105 packages are looking for funding
                                 run `npm fund` for details
2021-09-06T09:07:04.377Z [INFO]: found 1 moderate severity vulnerability
                                 run `npm audit fix` to fix them, or `npm audit` for details
2021-09-06T09:07:04.417Z [INFO]: # Completed phase: preBuild
                                 # Starting phase: build
2021-09-06T09:07:04.418Z [INFO]: # Executing command: mv pages/aws-exports.js lib/aws-exports.js
2021-09-06T09:07:04.419Z [INFO]: # Executing command: npx envinfo --system --binaries --browsers --npmPackages --duplicates --npmGlobalPackages
2021-09-06T09:07:05.146Z [WARNING]: npx: installed 1 in 0.689s
2021-09-06T09:07:09.783Z [INFO]: System:
                                 OS: Linux 4.14 Amazon Linux 2
                                 CPU: (4) x64 Intel(R) Xeon(R) Platinum 8124M CPU @ 3.00GHz
                                 Memory: 3.20 GB / 7.45 GB
                                 Container: Yes
                                 Shell: 4.2.46 - /bin/bash
                                 Binaries:
                                 Node: 12.21.0 - ~/.nvm/versions/node/v12.21.0/bin/node
                                 Yarn: 1.22.0 - ~/.yarn/bin/yarn
                                 npm: 6.14.11 - ~/.nvm/versions/node/v12.21.0/bin/npm
                                 npmPackages:
                                 @ampproject/toolbox-optimizer:  undefined ()
                                 @aws-amplify/ui-react: ^1.2.13 => 1.2.13
                                 @babel/core:  undefined ()
                                 @next/bundle-analyzer: ^11.1.0 => 11.1.2
                                 @sls-next/serverless-component: ^3.3.0 => 3.3.0
                                 @vercel/nft:  undefined ()
                                 amphtml-validator:  undefined ()
                                 arg:  undefined ()
                                 async-retry:  undefined ()
                                 async-sema:  undefined ()
                                 autoprefixer: ^10.3.4 => 10.3.4
                                 aws-amplify: ^4.2.7 => 4.2.7
                                 bfj:  undefined ()
                                 cacache:  undefined ()
                                 ci-info:  undefined ()
                                 cli-select:  undefined ()
                                 comment-json:  undefined ()
                                 compression:  undefined ()
                                 conf:  undefined ()
                                 content-type:  undefined ()
                                 cookie:  undefined ()
                                 cross-spawn:  undefined ()
                                 css-loader:  undefined ()
                                 debug:  undefined ()
                                 devalue:  undefined ()
                                 escape-string-regexp:  undefined ()
                                 eslint: ^7.32.0 => 7.32.0
                                 eslint-config-next: ^11.0.1 => 11.1.2
                                 eslint-config-prettier: ^8.3.0 => 8.3.0
                                 file-loader:  undefined ()
                                 find-cache-dir:  undefined ()
                                 find-up:  undefined ()
                                 fresh:  undefined ()
                                 glob:  undefined ()
                                 gzip-size:  undefined ()
                                 http-proxy:  undefined ()
                                 ignore-loader:  undefined ()
                                 is-animated:  undefined ()
                                 is-docker:  undefined ()
                                 is-wsl:  undefined ()
                                 json5:  undefined ()
                                 jsonwebtoken:  undefined ()
                                 loader-utils:  undefined ()
                                 lodash.curry:  undefined ()
                                 lru-cache:  undefined ()
                                 mini-css-extract-plugin:  undefined ()
                                 nanoid:  undefined ()
                                 neo-async:  undefined ()
                                 next: ^11.1.2 => 11.1.2
                                 next-themes: ^0.0.15 => 0.0.15
                                 ora:  undefined ()
                                 postcss: ^8.3.6 => 8.3.6 (8.2.15)
                                 postcss-flexbugs-fixes:  undefined ()
                                 postcss-loader:  undefined ()
                                 postcss-preset-env:  undefined ()
                                 postcss-scss:  undefined ()
                                 prettier: ^2.3.2 => 2.3.2
                                 react: 17.0.2 => 17.0.2
                                 react-dom: 17.0.2 => 17.0.2
                                 react-dropzone: ^11.3.4 => 11.3.4
                                 react-hook-form: ^7.15.0 => 7.15.0
                                 react-redux: ^7.2.5 => 7.2.5
                                 react-table: ^7.7.0 => 7.7.0
                                 recast:  undefined ()
                                 redux: ^4.1.1 => 4.1.1
                                 redux-define: ^1.1.1 => 1.1.1
                                 redux-devtools-extension: ^2.13.9 => 2.13.9
                                 redux-saga: ^1.1.3 => 1.1.3
                                 redux-saga/effects:  undefined ()
                                 reselect: ^4.0.0 => 4.0.0
                                 resolve-url-loader:  undefined ()
                                 sass-loader:  undefined ()
                                 schema-utils:  undefined ()
                                 semver:  undefined ()
                                 send:  undefined ()
                                 source-map:  undefined ()
                                 string-hash:  undefined ()
                                 strip-ansi:  undefined ()
                                 tailwindcss: ^2.2.7 => 2.2.9
                                 terser:  undefined ()
                                 text-table:  undefined ()
                                 unistore:  undefined ()
                                 web-vitals:  undefined ()
                                 webpack:  undefined ()
                                 webpack-sources:  undefined ()
                                 zen-observable:  undefined ()
                                 npmGlobalPackages:
                                 @aws-amplify/cli: 5.4.0
                                 bower: 1.8.12
                                 cypress: 6.6.0
                                 gatsby-cli: 3.0.0
                                 grunt-cli: 1.3.2
                                 npm: 6.14.11
                                 sm: 0.2.12-rc.1
                                 vuepress: 1.8.2
2021-09-06T09:07:09.807Z [INFO]: # Executing command: npm run build
2021-09-06T09:07:09.964Z [INFO]: ><EMAIL_ADDRESS>build /codebuild/output/src237934045/src/sf-app-backoffice
                                 > next build
2021-09-06T09:07:10.401Z [INFO]: info  - Loaded env from /codebuild/output/src237934045/src/sf-app-backoffice/.env
2021-09-06T09:07:10.620Z [INFO]: info  - Using webpack 5. Reason: Enabled by default https://nextjs.org/docs/messages/webpack5
2021-09-06T09:07:10.729Z [INFO]: warn  - No build cache found. Please configure build caching for faster rebuilds. Read more: https://nextjs.org/docs/messages/no-cache
2021-09-06T09:07:10.741Z [INFO]: Attention: Next.js now collects completely anonymous telemetry regarding usage.
2021-09-06T09:07:10.741Z [INFO]: This information is used to shape Next.js' roadmap and prioritize features.
                                 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
                                 https://nextjs.org/telemetry
2021-09-06T09:07:10.776Z [INFO]: info  - Checking validity of types...
2021-09-06T09:07:13.329Z [INFO]: info  - Creating an optimized production build...
2021-09-06T09:07:18.788Z [WARNING]:
2021-09-06T09:07:18.790Z [WARNING]: warn - You have enabled the JIT engine which is currently in preview.
                                    warn - Preview features are not covered by semver, may introduce breaking changes, and can change at any time.
2021-09-06T09:07:42.235Z [INFO]: info  - Compiled successfully
                                 info  - Collecting page data...
2021-09-06T09:07:44.236Z [INFO]: info  - Generating static pages (0/5)
2021-09-06T09:07:46.104Z [INFO]: info  - Generating static pages (1/5)
2021-09-06T09:07:46.113Z [INFO]: info  - Generating static pages (2/5)
2021-09-06T09:07:46.119Z [INFO]: info  - Generating static pages (3/5)
2021-09-06T09:07:46.301Z [INFO]: info  - Generating static pages (5/5)
2021-09-06T09:07:46.330Z [INFO]: info  - Finalizing page optimization...
2021-09-06T09:07:46.333Z [INFO]:
2021-09-06T09:07:46.339Z [INFO]: Page                               Size     First Load JS
                                 ┌ ○ / (1602 ms)                    1.72 kB        95.8 kB
                                 ├   /_app                          0 B              94 kB
                                 ├ ○ /404                           196 B          94.2 kB
                                 ├ ○ /notifications (1677 ms)       1.23 kB         107 kB
                                 ├ λ /staff                         1.3 kB          222 kB
                                 ├ λ /tickerlists                   22.5 kB         247 kB
                                 ├ λ /tickerlists/[listid]          1.75 kB         247 kB
                                 └ ○ /tickerlists/create (1824 ms)  2.13 kB         299 kB
                                 + First Load JS shared by all      94 kB
                                 ├ chunks/framework.bdc1b4.js     42.6 kB
                                 ├ chunks/main.6409a0.js          23.3 kB
                                 ├ chunks/pages/_app.3efd68.js    25.5 kB
                                 ├ chunks/webpack.a7efa6.js       2.65 kB
                                 └ css/e9cf9bf2571ecdd7603a.css   4.18 kB
2021-09-06T09:07:46.340Z [INFO]: λ  (Server)  server-side renders at runtime (uses getInitialProps or getServerSideProps)
                                 ○  (Static)  automatically rendered as static HTML (uses no initial props)
                                 ●  (SSG)     automatically generated as static HTML + JSON (uses getStaticProps)
                                 (ISR)     incremental static regeneration (uses revalidate in getStaticProps)
2021-09-06T09:07:46.559Z [INFO]: Starting SSR Build...
2021-09-06T09:08:08.660Z [ERROR]: Error: Component "@sls-next/-component@undefined" was not found on NPM nor could it be resolved locally.
                                  at /root/.npm/_npx/2577/lib/node_modules//node_modules/@/core/src/utils/download.js:97:15
                                  at processTicksAndRejections (internal/process/task_queues.js:97:5)
2021-09-06T09:08:08.662Z [ERROR]:
                                  0s › Template › Error: Component "@sls-next/-component@undefined" was not found on NPM nor could it be resolved locally.

Terminating logging...

Log output

// Put your logs below this line

aws-exports.js
/* eslint-disable */
// WARNING: DO NOT EDIT. This file is automatically generated by AWS Amplify. It will be overwritten.

const awsmobile = {
    "aws_project_region": "eu-central-1",
    "aws_cognito_identity_pool_id": "eu-central-1:9fabfa6f-c909-4b1c-ad96-c99401461463",
    "aws_cognito_region": "eu-central-1",
    "aws_user_pools_id": "eu-central-1_CDSkVggRQ",
    "aws_user_pools_web_client_id": "7tm9jqqp4cjen3sskmggh4ksrm",
    "oauth": {
        "domain": "sf-app-backoffice-sampledev.auth.eu-central-1.amazoncognito.com",
        "scope": [
            "phone",
            "email",
            "openid",
            "profile",
            "aws.cognito.signin.user.admin"
        ],
        "redirectSignIn": "https://corporate.startingfinance.com/callback/backoffice/",
        "redirectSignOut": "https://corporate.startingfinance.com/callback/backoffice/signout/",
        "responseType": "code"
    },
    "federationTarget": "COGNITO_USER_POOLS",
    "aws_cognito_login_mechanism": [
        "EMAIL"
    ],
    "aws_cognito_signup_attributes": [
        "EMAIL"
    ],
    "aws_cognito_mfa_configuration": "OPTIONAL",
    "aws_cognito_mfa_types": [
        "SMS",
        "TOTP"
    ],
    "aws_cognito_password_protection_settings": {
        "passwordPolicyMinLength": 8,
        "passwordPolicyCharacters": [
            "REQUIRES_LOWERCASE",
            "REQUIRES_UPPERCASE",
            "REQUIRES_NUMBERS",
            "REQUIRES_SYMBOLS"
        ]
    },
    "aws_cloud_logic_custom": [
        {
            "name": "AdminQueries",
            "endpoint": "https://8dq0gfov8k.execute-api.eu-central-1.amazonaws.com/sampledev",
            "region": "eu-central-1"
        }
    ],
    "aws_appsync_graphqlEndpoint": "https://if3pg6lnpja6bgb37zi6cpt7da.appsync-api.eu-central-1.amazonaws.com/graphql",
    "aws_appsync_region": "eu-central-1",
    "aws_appsync_authenticationType": "AMAZON_COGNITO_USER_POOLS",
    "aws_dynamodb_all_tables_region": "eu-central-1",
    "aws_dynamodb_table_schemas": [
        {
            "tableName": "sf-app-lists-resource-gspmrc-TickersListsDetailsTableV1-1PJ1IYE6H7KYF",
            "region": "eu-central-1"
        },
        {
            "tableName": "sf-app-lists-resource-gspmrc-TickersListsTableV1-XGHXNPC88WH",
            "region": "eu-central-1"
        }
    ]
};

export default awsmobile;

Manual configuration
No response
Additional configuration
No response
Mobile Device
No response
Mobile Operating System
No response
Mobile Browser
No response
Mobile Browser Version
No response
Additional information and screenshots
No response

appId d2k9a1cllgs6e
Region eu-central-1

Build Settings
version: 1
backend:
  phases:
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - amplifyPush --simple
frontend:
  phases:
    preBuild:
      commands:
        - npm install
    build:
      commands:
        - mv pages/aws-exports.js lib/aws-exports.js
        - npx envinfo --system --binaries --browsers --npmPackages --duplicates --npmGlobalPackages
        - npm run build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Could be related to: https://github.com/aws-amplify/amplify-console/issues/2098

I'm also experiencing this issue with latest amplify-cli and nextjs. Haven't been able to resolve it thus far.

Build went through with SSR. I updated the build settings to the following:
version: 1
backend:
  phases:
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - amplifyPush --simple
frontend:
  phases:
    preBuild:
      commands:
        - yarn
    build:
      commands:
        - yarn build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Amplify CLI: 5.5.0
Nextjs version: latest

@truecolintracy do you mean that you got things working? If so, what exactly did you change in those building settings to make it work?

I'm also getting this error if I define the live package version override for Next JS to version 11 in the build settings.
If I set the package version override to latest it builds just fine.

Same for me - setting the Nextjs version to "11" does not work, but setting it to "latest" works fine.

For me none of the settings seem to work: webpack 4, webpack 5, node 11, node latest, node 10, amplify CLI 5.5.0, amplify CLI latest, yarn, npm... I don't know what else to try. I decided to create a custom docker image.

Ok, I solved this problem by:

Create a new amplify project from the cli
Recreating all the resources from scratch (from the cli)
Created my docker image, and hosted on Elastic Container Registry because all the image hosted on the docker-hub cannot be downloaded because all aws infrastructure exceeded the docker-hub's limit (BTW: the command to log in with docker in ECS is wrong only some us region work for the logion)
Set the env variable for the table that I have imported
Watch the deployment process and pry (I am not religious, but I can Learn)

@Lettly, thanks for taking the time to step through this. Reopening as this should be tracked to improve/fix.


correct  reconcilation to reconciliation in 84:144 and 85:137

Ⅰ. Describe what this PR does
Fixed #3986
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

you should add -s when you use command "git commit"

/lgtm


chore: bdd-spring-1574110500 to 0.0.1

chore: Promote bdd-spring-1574110500 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Scrolling becomes noticably slower in recent versions

Thanks for making image.nvim, it is awesome. I just updated the plugin and noticed that it has become much slower than before:
Scrolling with image.nvim using commit 1650eccca5b0d071d1305c17646ad16693987796:
https://github.com/3rd/image.nvim/assets/76579810/e0063b57-dc27-4db5-83ea-d1a217b9b6fe
Scrolling with image.nvim using commit 0ed70e2:
https://github.com/3rd/image.nvim/assets/76579810/106da79b-7153-42a0-811d-d7782e1cf0b3
Plugin config:
package.path = table.concat({
  package.path,
  vim.fs.normalize('~/.luarocks/share/lua/5.1/?/init.lua'),
  vim.fs.normalize('~/.luarocks/share/lua/5.1/?.lua'),
}, ';')

require('image').setup({
  backend = 'kitty',
  window_overlap_clear_enabled = true,
  tmux_show_only_in_active_window = true,
  window_overlap_clear_ft_ignore = {},
  max_width_window_percentage = 80,
  max_height_window_percentage = 30,
})

Neovim version:
NVIM v0.10.0-dev-1627+g879617c9bb
Build type: Release
LuaJIT 2.1.1700008891

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/share/nvim"

Run :checkhealth for more info

OS: Arch linux Linux 6.1.63-1-lts
Terminal: kitty 0.31.0 + tmux 3.3a

fixed in https://github.com/3rd/image.nvim/commit/2aad3ad35e136240a7b2fb53a50d87358f867463


[feature] [core] Synchronous version of the generate function

@antfu Not investigated this in detail yet, but I was wondering, if it is possible to get a synchronous API for the .generate() function, since it would be great to have it as an option?
https://github.com/antfu/unocss/blob/main/packages/core/src/generator/index.ts#L40-L44

I think it makes more sense to have your usage supports async functions instead, otherwise, we are basically saying we are limiting the possibilities and potential perf here to have asynchronous API. Sorry as I would not expect it to happen in the near future.

This is disappointing. It was a bummer that shikiji had no sync API, and now unocss. This is really limiting the scenarios in which this can be used.


Milestone: Add likes functionality

In this milestone:
I have hit the involvement API to Post, get and then display the updated likes on the page when the heart icon is clicked.

Approved project! ✅ 🥳 🎈 🎉🎉🎉🎉🎉🎉🎉🎉
Hi there,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


edited example to build with babeljs

Hey @matthewwithanm
I edited the example in the readme.  When I copied and pasted the example to a local project babeljs was breaking on some small syntactical things.  I removed the function() from class methods and added an empty string for when the ternary operator returns false.  Hope this helps a bit.

Awesome, thanks @Cspeisman! I squashed these and merged.


d1_canals_01 Various issue

1
A friend of mine was stuck where this screenshot he did take shows

I'd suspect there's some clipping going on when any other player reach the part where the OST kicks in
2
When a player is respawned by any checkpoint they won't have any weapon equiped from the map, idealy it should detect and add the USP for when the first checkpoint is used.
3
This checkpoint doesn't seems to vanish/activate

Regarding no 2. - Weapon addition through checkpoint was a feature added recently with Episodic additions. Before, it was either done manually in mapscript or not at all. Need to refactor these ancient mapscripts to the new checkpoint structure.


routes-loader doesn't run on Windows

On Windows development env the webpack route-loader is not run, thus bundleKey is not added to page's js files and the 404 info is displayed all the time

Thanks for reporting the bug @lukaszzdanikowski Have you tried dockerizing the application ?
I will test this in windows right away though.

@lukaszzdanikowski The problem was not with routes loader but with regex of the pages, that we use loader for thus changed the regex to support both "" & "/" I tested it on windows 10 Pro and is working just fine now. Please let me know if you still face any issue.


comfyui version

https://github.com/CapsAdmin/ComfyUI-Euler-Smea-Dyn-Sampler/tree/main
Feel free to just take the code and put it in this repo however you want to structure it.
The way I added the sampler is a little bit hacky, but easier for end users so they can just select the new sampler in the default samplers instead of creating new sampler nodes.

Thank you very much.


Add URL validator to DDF schemas

Description

Adds an URL validator for URL fields

Accepts all kinds of address (ipv4, ipv6, with/out port, etc.), the only part which is required is protocol identifier.
@gtanzillo Which protocols are we going to support? Right now, it is set to accept only http,https, but anything else could be added. Or we could make the protocol optional too.

@rvsia

@gtanzillo Which protocols are we going to support? Right now, it is set to accept only http,https, but anything else could be added. Or we could make the protocol optional too.

I think that's all we need to support @agrare?

I'm not sure what protocol we'd need for receptor-over-http but I don't think the receptor team knows either so we can cross that bridge when we get there.  http+https is good for now

Good to hear it, so this PR should be fine then.

Closes TPINVTRY-351


Mention S3 server-side encryption

https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingServerSideEncryption.html
Deserves a basic explanation and a link also to (no expanding) KMS section.

This is a related discussion from #questions today:
ahmed [9:11 AM]
I think I already know the answer to this question but need confirmation. With SSE-S3 since Amazon is managing the encryption technically if I’m using SSE-S3 for both buckets I can decrypt the contents of both with a regular IAM user that has access to the buckets since it’s just AES256, right?
jose [9:14 AM]
Yup should be transparent, as long as the user has permission to the bucket S3 will handle the decryption.
ahmed [9:15 AM]
Thought so. If I want to manage the decryption access then I need SSE-KMS
jose [9:16 AM]
Well not really, you'll want Client-Side encryption for that SSE-KMS is just telling S3 which keys to use to encrypt it, but access is the same since it's still server side
[9:17]
Really this is just in case someone steals an entire data center worth of drives and your info is on it
[9:18]
Client Side encryption would store the file as unreadable to even S3, the client would encode and decode
ahmed [9:19 AM]
Okay hang on a sec. CloudTrail uses SSE-KMS though and you need to grant decryptKey to the IAM user to access the objects.
http://docs.aws.amazon.com/kms/latest/developerguide/services-cloudtrail.html
http://docs.aws.amazon.com/awscloudtrail/latest/userguide/create-kms-key-policy-for-cloudtrail-decrypt.html
docs.aws.amazon.com
How AWS CloudTrail Uses AWS KMS - AWS Key Management Service
Learn how AWS CloudTrail uses AWS KMS to encrypt log files.
docs.aws.amazon.com
Granting decrypt permissions - AWS CloudTrail
Grant other users permissions to decrypt logs with a CMK.
[9:19]
So CloudTrail is doing object encryption on top of SSE-KMS? (edited)
jose [9:21 AM]
CMK
[9:21]
http://docs.aws.amazon.com/AmazonS3/latest/dev/serv-side-encryption.html
docs.aws.amazon.com
Protecting Data Using Server-Side Encryption - Amazon Simple Storage Service
How to protect data using Server-Side Encryption in Amazon S3.
[9:21]
3 Options
ahmed [9:21 AM]
Right
[9:22]
Okay so I think I got a better understanding of that
[9:22]
SSE-KMS is just nice for compliance reasons otherwise SSE-S3 is the way to go because replication is available (edited)
jose [9:24 AM]
:+1: (edited)
[9:25]
In this case (s3) KMS is pretty easy and transparent.
[9:26]
EBS and other services that are a bit more involved.
mcohen [1:11 PM]
So, when using SSE-KMS is the "audit trail” simply Cloudtrail, or is there an additional level of reporting only available by/within KMS ?

SSE-KMS also provides you with an audit trail of when your key was used and by whom

mcohen [1:16 PM]
Wonder if they’ll implement SSE-KMS encrypted replication for S3 objects at some point ?

"Amazon S3 does not keep the encryption keys you provide after the object is created in the source bucket so it cannot decrypt the object for replication, and therefore it does not replicate the object."

[1:16]
...perhaps its the additional KMS “envelope” key that impedes the decryption ?
ajkerrigan [1:19 PM]
Not sure about the replication question, but the audit trail comes from CloudTrail
[1:19]
Good reference on that with examples for various KMS events: http://docs.aws.amazon.com/kms/latest/developerguide/logging-using-cloudtrail.html
docs.aws.amazon.com
Logging AWS KMS API Calls Using AWS CloudTrail - AWS Key Management Service
Learn how to audit AWS Key Management Service (AWS KMS) customer-managed keys by using AWS CloudTrail.
[1:20]
It’s the CloudTrail log format you know and love, just with info relevant to KMS for requestParameters/resources
mcohen [1:26 PM]
Thanks for the clarity @ajkerrigan. Those docs state “"your log files are encrypted by using Amazon S3 server-side encryption (SSE)”, so this further identifies SSE-KMS encrypted objects arent supported for replication.
[1:27]
maybe someday, as unless using SSE-C, KMS already has the keys
[1:28]
Certainly a bit of a caveat (must use SSE-S3 if/when encrypting), that should be front and center for those requiring replication.
bgdnlp [3:15 PM]
SSE-KMS is not only for audit. With SSE-KMS you have two points of access control. One is access to the bucket and the objects in it. The other is access to the key to decrypt the data. It's a subtle difference, but it's important. It basically means that you can have different objects stored with different keys in the same bucket and people would only be able to access the ones that they have the keys to. Also, with SSE-S3, someone getting access to your bucket will automatically have access to the data, because it gets automatically decrypted. With SSE-KMS, they would also need access to the key.
[3:16]
so, for example, SSE-KMS would guard against badly configured access to a bucket (making it public by mistake) simply because it's harder to badly configure two things
[3:18]
or, you can have a bucket that must only be accessible through an instance for example. the associated role has access to the key, but only that role. even if someone gives access to users to the bucket, they still can't get the data
[3:19]
things like that
ahmed [3:20 PM]
@bgdnlp I was looking at the documentation today and cloudtrail does in flight encryption of log files before they’re stored in the S3 bucket that also has SSE enabled. With regular s3 SSE-KMS/C/S3 just controls how (how the key is managed) the objects are encrypted on the bucket. The objects themselves are not encrypted so a person just needs standard S3 access to pull the files. (edited)
bgdnlp [3:21 PM]
I don't understand
ahmed [3:22 PM]
Sorry, lemme see if I can rephrase that to make more sense
[3:22]
CloudTrail has Encryption as an option, it encrypts objects so an IAM user accessing the bucket also needs access to the decryptKey to retrieve the objects. It also uses SSE-KMS for server side encryption
[3:23]
Then there’s a regular S3 bucket and you enable SSE-KMS (or SSE-S3/C, doesn’t matter). That’s just how it’s encrypted on the hardware to protect against data theft in the warehouse
[3:23]
You’re not actually encrypting the objects, just the storage layer underneath is encrypted so giving access to a IAM user doesn’t require access to the CMK (edited)
bgdnlp [3:24 PM]
you mean, when you enable SSE-KMS on a bucket, the objects are not encrypted?
[3:25]
Can you give me a link to the docs? There's a misunderstanding here and I'm not sure on which side, probably mine
ahmed [3:25 PM]
S3 manages the encryption/decryption so it’s completely transparent to the user. That’s how I understood it at least (edited)
bgdnlp [3:25 PM]
because, you don't enable SSE encryption on a bucket. you ask for encryption for each object in part
[3:26]
yes
ahmed [3:26 PM]
http://docs.aws.amazon.com/kms/latest/developerguide/services-s3.html
docs.aws.amazon.com
How Amazon Simple Storage Service (Amazon S3) Uses AWS KMS - AWS Key Management Service
Discusses how Amazon S3 uses AWS KMS to encrypt data.
[3:26]
http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingKMSEncryption.html
docs.aws.amazon.com
Protecting Data Using Server-Side Encryption with AWS KMS–Managed Keys (SSE-KMS) - Amazon Simple Storage Service
Use server-side encryption so that Amazon S3 manages encryption and decryption for you.
[3:26]
That’s what I was looking at earlier
[3:27]
So, key policy gives s3 service access for SSE-KMS I think. I didn’t find anything stating the client needs access to the CMK (edited)
bgdnlp [3:28 PM]
yes, so, let me see if I understand the confusion. for SSE-S3, you set a policy on the bucket that requires the HTTP header asking for the object to be encrypted to be set for each object
[3:28]
if you try to upload an object and it doesn't have that header set, the upload will be denied
[3:29]
if you upload the object WITH the header set, S3 will receive the object, will encrypt it, then it will store it encrypted in the bucket
[3:29]
for SSE-S3, S3 chooses the encryption key. you have no control, you don't have a say in it, because if you chose SSE-S3, you don't care
[3:30]
for SSE-KMS on the other hand, you set two headers. one asking for SSE-KMS encryption and one specifying the key
[3:30]
basically the same process, with the addition of S3 checking that you also have access to the key, then using that specific key to encrypt it
[3:32]
with SSE-C, you require encryption and you pass on the key yourself. S3 encrypts the object, then discards the key, it's your problem
[3:33]
basically, when you set the bucket policies, you only say that upload will be denied unless encryption is set. You can use encryption without the bucket policies, but then it's optional
[3:33]
is that what wasn't clear, or did I totally misunderstand?
ahmed [3:33 PM]
So this is the part I haven’t gotten a clear answer on: https://og-aws.slack.com/archives/questions/p1487104255002002
bgdnlp
basically the same process, with the addition of S3 checking that you also have access to the key, then using that specific key to encrypt it
Posted in #questionsToday at 3:30 PM
[3:34]
Does the user or bucket need access to the key (edited)
[3:34]
Since S3 is handling the encryption and not the user (edited)
bgdnlp [3:34 PM]
the user. Amazon have access to those keys. With SSE-S3 and SSE-KMS, Amazon can read your data
[3:35]
in theory. I mean, there's a process and controls in place, but they have access to the key and they can read your data
[3:35]
you trust them that they won't
[3:35]
S3 has access and S3 will check that the user has access before encrypting/decrypting
ahmed [3:36 PM]
Well that’s where the key policy comes in as with CMK iam policy doesn’t give access until the key policy allows it. I think I’ll just need to test this out tomorrow and see what happens
bgdnlp [3:37 PM]
but that's what I said
[3:37]
or, what I meant
ahmed [3:38 PM]
Right so if S3 is handling it then it needs to request an encryption key from KMS to encrypt stuff with and I don’t think it will do masquerading to use the IAM users session
[3:38]
I may be talking in circles right now so please tell me if I’m frustrating you
bgdnlp [3:40 PM]
I don't know how they do it exactly. I don't think it's masquerading as the user either, as far as I understand S3 basically asks KMS "this guy here asks for this particular key to enctypt data with" and KMS simply says "yeah, he's good, here's the key" or "I don't know who the guy is"
[3:40]
I think
[3:41]
but, does it matter if S3 says "Hi, I'm Guy" or "Hi, I'm talking for Guy"?
[3:42]
(also, S3 doesn't get the CMK, it gets a "data key", encrypted with the CMK. no one gets to see the CMK)
ahmed [3:42 PM]
Kinda sorta but not really
[3:42]
Yeah data key (sorry, it’s getting late and I’ve been researching encryption in aws all day)
[3:43]
I’ve been building requirements and that nuance tells me how the key policy should be setup
bgdnlp [3:44 PM]
do you mean, if in the key policy you should give access to the user or to S3 service?
ahmed [3:45 PM]
Yeah
[3:45]
Or something else
bgdnlp [3:45 PM]
oh. user.
[3:45]
but... but... I'm not sure how you give access to a service
[3:45]
easy test though
[3:46]
I mean, I'm talking about keys that you create in KMS for users
ahmed [3:48 PM]
kms:ViaService condition
[3:49]
Okay so I guess by double checking that detail I finally answered my question.
http://docs.aws.amazon.com/kms/latest/developerguide/policy-conditions.html#conditions-kms-via-service
docs.aws.amazon.com
Using Policy Conditions with AWS KMS - AWS Key Management Service
Use AWS Key Management Service (AWS KMS) condition keys (context keys) in a permissions policy.
[3:49]
You give a user access to the CMK but that KMS condition is applied so they can only use it with the S3 service
[3:50]
And then a IAM Policy condition can be further used to only permit usage with a specific bucket

Personal contribution: http://www.neant.ro/2017/02/aws-encryption-types/
Could be shaped into a better form than added to the guide.

I did some further testing, here's the goodies:
The IAM user must have the following permissions to use SSE-KMS:
        {
          "Sid": "KMSAllow",
          "Effect": "Allow",
          "Action": [
            "kms:Encrypt",
            "kms:Decrypt",
            "kms:ReEncrypt*",
            "kms:GenerateDataKey*",
            "kms:DescribeKey"
          ],
          "Resource": [
            "arn:aws:kms:eu-west-1:43122223:key/blah-blah-blah-blah"
          ]
        }

This allows them to upload and download objects with SSE-KMS. Any user lacking those permissions will not be able to GET encrypted objects .
To restrict the CMK to S3 usage  the key policy must have the following condition:
      "Condition": {
        "StringEquals": {
          "kms:ViaService": "s3.eu-west-1.amazonaws.com"
        }
      }

In the S3 Bucket policy you can then require SSE-KMS and even specify the key id.

Right. Here's a bucket policy that requires KMS encryption using a specific key, courtesy of AWS support:
{
  "Version": "2012-10-17",
  "Id": "RequireKmsKey",
  "Statement": [
    {
      "Sid": "RequireSpecificKmsKey",
      "Effect": "Deny",
      "Principal": "*",
      "Action": "s3:PutObject",
      "Resource": "arn:aws:s3:::bucket-name/*",
      "Condition": {
        "StringNotEquals": {
          "s3:x-amz-server-side-encryption-aws-kms-key-id": "arn:aws:kms:eu-west-1:123456789012:key/xINSERTx-KEYx-IDxx-HERE-xxxxxxxxxxxx"
        }
      }
    }
  ]
}


User can configure default appmap filter settings

Fixes #681
This incorporates the frontend changes from this PR and adds logic to store and update saved filters.

:tada: This PR is included in version 0.84.0 :tada:
The release is available on:

v0.84.0
GitHub release

Your semantic-release bot :package::rocket:


Support for fixing parts of the binder?

I want to design a binder where I hold a the scaffold sequence fixed and only hallucinate / redesign my loops that are in contact with the protein. Is there a way to specify that?

Hi! This is not implemented yet, but we hope to put out that feature by the end of the year.


[#1557] made the modflow message to disappear if there is no recommen…

…ded required files

+1 once Jenkins clears


Chrome crashes when dragging a react-dnd enabled div containing a complex material-ui table

Description
When I try to drag a react-dnd enabled div containing a complex material-ui table in Chrome then the HTML 5 backend does not correctly snapshot the drag source - instead it just displays a slightly different mouse cursor.
(Sidenote: On my machine, when I "drop" the table on the target my browser crashes. Sometimes I even get booted out of my Linux desktop as a result - at a guess this is some "infinite loop"-like situation causing chrome to runaway and starve the system of resources. But I cannot reproduce this more severe version of the bug on another machine).
The above issue(s) do not happen in firefox, which initially made me think that it is the webkit issue described at https://github.com/gaearon/react-dnd-html5-backend/issues/18#issuecomment-183770505
However, I have tried the suggested workaround but I still get the issue. It is possible that there I have missed the application of the workaround to one of the div's that the material-ui table generates but I think I had gotten them all.
I have a test case based on the "01 Dustbin" example that comes with react-dnd. Basically, I have forked the react-dnd repo, added in the material-ui package and tweaked the dustbin example to put a material-ui table the boxes that are dragged.
Example of bug
https://github.com/theirishpenguin/react-dnd/commit/c51a1b3e1424828d4b6fce8ad65fa28d6df1e0e5
(Just visit the dustbin example when you once you have your local server running - ie. http://localhost:8080/examples-dustbin-single-target.html)
Example without bug (ie. when I use a simpler material-ui table)
https://github.com/theirishpenguin/react-dnd/commit/2fbe03ce857e3927001f6940e710018f471bb820
(Again, just visit the dustbin example when you once you have your local server running at http://localhost:8080/examples-dustbin-single-target.html)
Note: If you diff the above commits you can see the exact differences.
Versions

Material-UI: 0.16.6
React: 15.4.1
Browser: Version 52.0.2743.116 (64-bit)

Related
I had previously opened this bug on the material-ui github issue tracker (https://github.com/callemall/material-ui/issues/5898) but moved it here once I had a working test case.

I have refined the Dustbin test case. It is the tooltips in material-ui that are causing the problem.
The left hand side of the this diff works fine, the right hand side exhibits the problem...
https://github.com/theirishpenguin/react-dnd/compare/2fbe03c...theirishpenguin:0412a6e

Same issue with an item containing react-tooltip component.


Negative fractional value gives NaN in 'Representation error (dB)'

Just noticed that the Q-format calculator, returns NaN for 'Representation error (dB)', when a negative fractional number is given.

Can you please be more specific? What options did you use? What number(s) did you try?

Never mind. I found and fixed the issue.


Update views.py

Typo... compontent => component

Sorry, didn't see this PR. Should already be fixed in the develop branch.