svg2mod.py is not working on Windows

Hello. I'm new ussing svg2mod.py. I am on Windows 10 and Python 3.6. I cloned your repo and generated a file named "led_array_txt.svg" in inkspace, in a layer named SilkS. I typed in a terminal:
C:\Users\Jorge\Documents\Kicad\svg2mod-master\svg2mod>svg2mod.py -i led_array_txt.svg -p 1 -f 0.94
And the result was:
Traceback (most recent call last):
File "C:\Users\Jorge\Documents\Kicad\svg2mod-master\svg2mod\svg2mod.py", line 10, in
import svg2mod.svg as svg
File "C:\Users\Jorge\Documents\Kicad\svg2mod-master\svg2mod\svg2mod.py", line 10, in
import svg2mod.svg as svg
ModuleNotFoundError: No module named 'svg2mod.svg'; 'svg2mod' is not a package
Of course, no file .mod was generated. Could you help me, please?
Even if I run:
C:\Users\Jorge\Documents\Kicad\svg2mod-master\svg2mod>svg2mod.py --help
The result is the same:
Traceback (most recent call last):
File "C:\Users\Jorge\Documents\Kicad\svg2mod-master\svg2mod\svg2mod.py", line 10, in
import svg2mod.svg as svg
File "C:\Users\Jorge\Documents\Kicad\svg2mod-master\svg2mod\svg2mod.py", line 10, in
import svg2mod.svg as svg
ModuleNotFoundError: No module named 'svg2mod.svg'; 'svg2mod' is not a package
I'm lost...

i developed inkscape extension to convert drawing to kicad, it works on windows too
https://github.com/badgeek/svg2shenzhen-next

Can somebody give me an example how to execute the script? ..or installation guide?
With the older release it worked by calling "python svg2mod.py" from the svg2mod-master folder.
With the newer release it is missing the svg.py ..and i did not found any way to include it.
I now installed phyton365.. installed the script with "python setup.py install" but now i get the same error as jorgegarciamateos described.
I noticed that after installing the setup there is a svg2mod-script.py in the Scripts-folder.. so i tried to start the script there, but then i get "AttributeError: ´dict´ object has no attribute ´iteritems´ "
I dont know much about python and sorry for spamming this post. Im shure its my fault but i need to get this working again..

I've narrowed down the issue to Python version. Currently svg2mod is only compatible with Python2 environments. If you are running Python3, svg2mod in its current form will not work due to the deprecation of the following methods:
Built-in changes for Python 3:
Remove dict.iteritems(), dict.iterkeys(), and dict.itervalues().
    Instead: use dict.items(), dict.keys(), and dict.values() respectively.

After updated these methods in svg2mod.py and svg.py, I was able to get the script to work, but only when installed via the PIP method. Manually building via setup.py install still fails...
I created a fork that is compatible with python3 here.

It would be nice to add the "python setup.py install" command to the documentation. I mean, how everyone is supposed to know ?

Also, the line "import svg2mod.svg as svg" crashes.
It works by copying the files from the "svg/svg" folder to the same folder as the svg2mod.py, then replacing the import by "import svg"


two minor changes on "below" and "belowing"

Learn Build status updates of commit db97f8e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/machine-learning/how-to-create-data-assets.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@SturgeonMi
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


[BUG] remove the Burning assets item from the documentation

OS and Environment
any
GIT commit hash
any
Minimum working example / Steps to reproduce
Remove item #7Burning assets from https://hyperledger.github.io/iroha-2-docs/guide/bash.html#_5-registering-and-minting-assets because this command is not supported by irona_client_cli
`./iroha_client_cli asset --help
iroha_client_cli-asset
The subcommand related to assets
USAGE:
iroha_client_cli asset
OPTIONS:
-h, --help    Print help information
SUBCOMMANDS:
get         Get info of asset
help        Print this message or the help of the given subcommand(s)
list        List assets
mint        Command for minting asset in existing Iroha account
register    Register subcommand of asset
transfer    Transfer asset between accounts
`
Actual result
information is in the documentation
Expected result
information missing from documentation
Logs in JSON format

Log contents
nothing to do

Who can help to reproduce?
@timofeevmd
Notes
No response

hey, i would like to contribute to this issue

should I remove this 7th section from the documentation,, or do I have to replace it something else

after discussion, decision  was made to implement
https://github.com/hyperledger/iroha/issues/3462


Release v2.1.0

Description
Bring in changes for the student success team end points - successteam, pcp and advisors
**Resolves #32 **
Review Time Estimate
Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

[x ] Immediately
[ ] Within a week
[ ] When possible

Type of changes
Please select a relevant option:

[ ] Bug fix (non-breaking change which fixes an issue).
[x ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).
[ ] Other (any another change that does not fall in one of the above categories.)

Checklist:
Please select all applicable options:

[ ] I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
[ ] I have updated the CHANGELOG.
[ ] I have read the Contributor Guidelines.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] My change requires updating the documentation.
[ ] I have made necessary changes to the documentation.
[ ] I have added tests related to my changes.
[ ] My changes generate no new warnings.
[ ] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

I am closing this PR because it contains a code much more than https://github.com/rokwire/gateway-building-block/issues/32
It contains code for https://github.com/rokwire/gateway-building-block/issues/39 but not sure how it has been appeared there as we just merged it on the develop branch.
We will open a new PR.


Add sub-items to invoice

Summary
Adds CPU request and Memory request sub-items to compute item, if they exist.
Also slightly extends the golden tests.
Checklist

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[x] Update tests.

I'll merge this now to finally get this to production. Formatting changes can easily be added in a later PR


Failed to find catalog by ID

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
When upgrading from 2.2.3-rc6 to 2.2.3-rc7 rancher is unable to find the monitoring templates
Result:
an error is thrown indicating the failure to find catalog by ID
Other details that may be helpful:
Environment information
Rancher version 2.2.3rc7 HA install

| Failed to ensure catalog "catalog://?catalog=system-library&template=rancher-monitoring&version=0.0.3": failed to find catalog by ID "catalog://?catalog=system-library&template=rancher-monitoring&version=0.0.3": catalogtemplateversions.management.cattle.io "system-library-rancher-monitoring-0.0.3" not found
-- | --

I noticed the chart is only updated in the dev branch of the charts so I added that catalog to the deployment but it still fails to find the catalog. I am not sure if this is all expected given the rc status of the build. If so I do apologize for the spurious issue.
If not this is the exception after I disable monitoring and add the catalog and also if I try to disabling the default catalog.
Catalogtemplateversions.management.cattle.io "system-library-rancher-monitoring-0.0.3" not found

This is a known issue with rc7.

@deniseschannon Is this also a known issue with RC9, because it still exists.


Not redirecting after click on sign in facebook

Hello! I have an issue with this module afte click on any login link i'm redirecting to http://myssite/scn-social-auth/hauth?hauth.start=Facebook&hauth.time=1430150822 and after I'm not redirecting anywhere. What the problem I have? P.S.: Sorry for my bad english

I've found the solution! The problem was in my nginx config.
was:
location / {
try_files $uri $uri/ /index.php$querystring;
}
i've made
location / {
try_files $uri $uri/ /index.php?$args;
}

thanks for posting the answer :X


Moving documentation from Slate to Docusaurus

Slate doc starts to be a bit outdated and we have some part of the documentation that are not really accurate (default values, attribute list, ... ).
I know that React Native use Docusaurus and looks to be able to generate some parts of it on the fly (https://github.com/facebook/react-native-website/blob/master/sync-api-docs). We still have  some missing informations in components that we have in doc (ex: description).
I don't know where it's going but I'll start a new repository with a minimal Docusaurus theme, a "Doc" page and "Components" page as RN does.

Todo (not exhaustive)

[x] Create the repository https://github.com/iRyusa/mjml-doc-v2
[ ] Install Docusaurus
[ ] Setup a theme
[ ] Configure Docusaurus
[ ] Sync attributes in the doc
[ ] Create a new getting started

This is wonderful news! It's great this path is opening to the project.
Might the project describe the preferred final product so we can all work together?
For example:

What style do you seek? (Probably, something like, "not wordy or repetitive, but not cold either.")
Do you hope for more of a direct translation of the existing documentation or more of a complete rewrite? Or something between?
What audience do you hope we'll write for? Email authors with

Considerable experience in HTML, CSS, JavaScript, and email HTML?
No experience in email HTML?

Do you want to reserve the right half of the screen for the exclusive use of code examples, as with the Slate template? Do you prefer to intersperse code with text so as to more efficiently use screen space?

It's way too early to discuss about this as we'll most likely import our current doc into docusaurus to see if we can migrate easily.
You can just check exemple on https://docusaurus.io/


Permissive PeerAuthentication + Plaintext DestinationRule with a direct TLS requests leads to NR on inbound side

FC looks like:
{"destinationPort":18443,"transportProtocol":"raw_buffer"}
{"destinationPort":18443,"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}

DR:
apiVersion: networking.istio.io/v1alpha3
kind: DestinationRule
metadata:
  name: b
spec:
  host: b
  trafficPolicy:
    tls:
      mode: SIMPLE

Need to see if this is a regression

This is a regression from 1.7

current filter chains:
DISABLE
{"destinationPort":7070,"transportProtocol":"raw_buffer"}
{"destinationPort":8080,"transportProtocol":"raw_buffer"}
{"destinationPort":8443,"transportProtocol":"raw_buffer"}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer"}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer","applicationProtocols":["http/1.0","http/1.1","h2c"]}
{"prefixRanges":[{"addressPrefix":"::0","prefixLen":0}],"transportProtocol":"raw_buffer"}
{"prefixRanges":[{"addressPrefix":"::0","prefixLen":0}],"transportProtocol":"raw_buffer","applicationProtocols":["http/1.0","http/1.1","h2c"]}

PERMISSIVE
{"destinationPort":7070,"transportProtocol":"raw_buffer"}
{"destinationPort":7070,"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}
{"destinationPort":8080,"transportProtocol":"raw_buffer"}
{"destinationPort":8080,"transportProtocol":"tls","applicationProtocols":["istio","istio-http/1.0","istio-http/1.1","istio-h2"]}
{"destinationPort":8443,"transportProtocol":"raw_buffer"}
{"destinationPort":8443,"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer"}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer","applicationProtocols":["http/1.0","http/1.1","h2c"]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["http/1.0","http/1.1","h2c","istio-http/1.0","istio-http/1.1","istio-h2"]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}
{"prefixRanges":[{"addressPrefix":"::0","prefixLen":0}],"transportProtocol":"raw_buffer"}
{"prefixRanges":[{"addressPrefix":"::0","prefixLen":0}],"transportProtocol":"raw_buffer","applicationProtocols":["http/1.0","http/1.1","h2c"]}
{"prefixRanges":[{"addressPrefix":"::0","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["http/1.0","http/1.1","h2c","istio-http/1.0","istio-http/1.1","istio-h2"]}
{"prefixRanges":[{"addressPrefix":"::0","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}

STRICT
{"destinationPort":7070,"transportProtocol":"tls"}
{"destinationPort":8080,"transportProtocol":"tls"}
{"destinationPort":8443,"transportProtocol":"tls"}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls"}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["http/1.0","http/1.1","h2c","istio-http/1.0","istio-http/1.1","istio-h2"]}
{"prefixRanges":[{"addressPrefix":"::0","prefixLen":0}],"transportProtocol":"tls"}
{"prefixRanges":[{"addressPrefix":"::0","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["http/1.0","http/1.1","h2c","istio-http/1.0","istio-http/1.1","istio-h2"]}

7070=tcp
8080=http
8443=https

 {"destinationPort":7070,"transportProtocol":"raw_buffer"}
+{"destinationPort":7070,"transportProtocol":"tls"}
 {"destinationPort":7070,"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}
 {"destinationPort":8080,"transportProtocol":"raw_buffer"}
+{"destinationPort":8080,"transportProtocol":"tls"}
 {"destinationPort":8080,"transportProtocol":"tls","applicationProtocols":["istio","istio-http/1.0","istio-http/1.1","istio-h2"]}
 {"destinationPort":8443,"transportProtocol":"raw_buffer"}
+{"destinationPort":8443,"transportProtocol":"tls"}
 {"destinationPort":8443,"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}
 {"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer"}
 {"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer","applicationProtocols":["http/1.0","http/1.1","h2c"]}
 {"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["http/1.0","http/1.1","h2c","istio-http/1.0","istio-http/1.1","istio-h2"]}
 {"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}

I suspect a fix like this would do the trick

Also, passthrough traffic is broken in DISABLE and PERMISSIVE, including on 1.7
DISABLE chains (from 1.7):
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"applicationProtocols":["http/1.0","http/1.1","h2c"]}

You would think this works fine - http inspector finds nothing, so we go through the first filter chain. Nope, Envoy decides we wanted a tls inspector when we didn't configure one: https://github.com/envoyproxy/envoy/issues/13601.
PERMISSIVE chains (from 1.7):
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"applicationProtocols":["http/1.0","http/1.1","h2c"]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["http/1.0","http/1.1","h2c","istio-http/1.0","istio-http/1.1","istio-h2"]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}

This is broken in 2 different ways; if you send a tls request with alpn set to one in the list (like http/1.1) it will fail due to sending a TLS request when we expect mTLS cert. If you send without alpn, it will not match any filter chain
STRICT of course works since it is expected to block this (and it does).
In 1.8, this is working in DISABLE:
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer"}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer","applicationProtocols":["http/1.0","http/1.1","h2c"]}

The difference here is envoy doesn't inject the tls inspector, so no problems.
Permissive is broken for the same reasons

Also broken, although pretty obscure:
{"destinationPort":70,"transportProtocol":"raw_buffer"}
{"destinationPort":70,"transportProtocol":"tls","applicationProtocols":["istio-peer-exchange","istio"]}

This is permissive tcp port
If I send an HTTP request, alpn will be istio-http, and match no filters. If I was using strict mode or plaintext, it would work.
This requires split-brain from client and server on the protocol that is being used, which is possible but uncommon

{"destinationPort":9000,"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls"}
{"destinationPort":9000,"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["http/1.0","http/1.1","h2c","istio-http/1.0","istio-http/1.1","istio-h2"]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer"}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer","applicationProtocols":["http/1.0","http/1.1","h2c"]}

From config:
        apiVersion: security.istio.io/v1beta1
        kind: PeerAuthentication
        metadata:
         name: default
        spec:
         selector:
           matchLabels:
             app: foo
         mtls:
           mode: DISABLE
         portLevelMtls:
           9000:
             mode: STRICT

This is also broken, we will have a tls inspector, so the passthrough will not match and tls traffic - it should be passed through

From config:
       apiVersion: security.istio.io/v1beta1
        kind: PeerAuthentication
        metadata:
         name: default
        spec:
         selector:
           matchLabels:
             app: foo
         mtls:
           mode: STRICT
         portLevelMtls:
           9000:
             mode: DISABLE

Where 9000 isn't in service
{"destinationPort":9000,"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer"}
{"destinationPort":9000,"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"raw_buffer","applicationProtocols":["http/1.0","http/1.1","h2c"]}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls"}
{"prefixRanges":[{"addressPrefix":"<IP_ADDRESS>","prefixLen":0}],"transportProtocol":"tls","applicationProtocols":["http/1.0","http/1.1","h2c","istio-http/1.0","istio-http/1.1","istio-h2"]}

9000 is disable, shouldn't have tls inspector. However, it does, so we don't match.

Hi, @howardjohn is the related fix #29589 going to be a part of 1.8.2? If yes, when can we expect it to release?

@Demonsthere yes, it will be released ~1/12. A bit delayed due to holidays


Introduce Aba::Batch class

Functionality was moved from Aba class. Aba class should contain only a public API for any operations while dealing with ABA flat files. Operations like preparing, creating or parsing ABA flat files should be implemented in dedicated classes. This change also allows introducing a class for parsing ABA flat files while keeping clear structure of gem files.

I will reopen another PR for this changes as I want them to be on different branch in my repo.


MySQLI Error

Hello
I have done fresh installation and I am receiving MySQLI Error when accessing website for first time.
Database is also imported successfully during installation.
SQL error: Access denied for user ''@'localhost' (using password: NO)
SQL error code: 1045
Date: Saturday 28th of October 2017 05:06:04 PM

I have not done an install in quite some time. I will check it out tonight or tomorrow.
I have to assume that you entered the mysql username and password when you did the install. It's not showing that that info is present.

yes I have entered mysql database details during installation

I have found several areas that need attention. They stem from moving many cache files into memcache. I will push an update as soon as possible, likely within a day or two.

This should be fixed with this last commit.

Issue is still not resolved as there is some issue with database import on step 3
/install/index.php?step=3

My apologies. I think my second commit yesterday overwrote the changes in the first commit. It should be good now.

Please provide me with the php error logs and the SQL error logs.

here r few warnings i m getting'
[Thu Nov 02 18:04:48.955881 2017] [php7:notice] [pid 901] [client <IP_ADDRESS>:50408] PHP Notice:  Uninitialized string offset: -1 in /var/www/html/pu/include/bittorrent.php on line 1793, referer: http://<IP_ADDRESS>/signup.php
[Thu Nov 02 18:04:48.979836 2017] [php7:notice] [pid 901] [client <IP_ADDRESS>:50408] PHP Notice:  Undefined variable: users in /var/www/html/pu/include/cleanup/inactive_update.php on line 38, referer: http://<IP_ADDRESS>/signup.php
[Thu Nov 02 18:04:49.258586 2017] [php7:notice] [pid 901] [client <IP_ADDRESS>:50408] PHP Notice:  Uninitialized string offset: -1 in /var/www/html/pu/include/bittorrent.php on line 1793, referer: http://<IP_ADDRESS>/signup.php
[Thu Nov 02 18:04:50.029964 2017] [php7:notice] [pid 901] [client <IP_ADDRESS>:50408] PHP Notice:  Uninitialized string offset: -1 in /var/www/html/pu/include/bittorrent.php on line 1793, referer: http://<IP_ADDRESS>/signup.php
[Thu Nov 02 18:04:50.595552 2017] [php7:notice] [pid 785] [client <IP_ADDRESS>:55238] PHP Notice:  Uninitialized string offset: -1 in /var/www/html/pu/include/bittorrent.php on line 1793, referer: http://<IP_ADDRESS>/signup.php

It seems I missed another of my initial changes last night. One more time :)

I believe that I have fixed every issue involving the installer and creating the first two users. If you still have issues, please include the relevant log files.

no response, closing


Release to PyPi

Uploading scylla-ccm to pypi would help users of it to pin to a version, or specify version bigger then
and would enable more cases of usage of ccm (by scylla, and by external users)

[ ] modernize setup.py with pyproject.toml
[ ] configure the new package in pypi
[ ] use tags as versions (similar to scylla-cqlsh)
[ ] introduce github actions to automatically upload tagged versions.
[ ] define the release cadence (on each PR push ?, manually as needed, date based)

What are the expected releases? Should we release only master or all backport branches as well? Will we actually use the released package in our other projects or will we still use branches?

What are the expected releases? Should we release only master or all backport branches as well? Will we actually use the released package in our other projects or will we still use branches?

As written in the description, no one defined the release cadence.
Different projects would be able to consume it as they see fit, for example driver tests are taking the master branch all the time
Projects would be able to pin down a version as needed, and eliminate the need of doing release branches in CCM.
Still projects might still continue to consume it as they do now, straight from a branch. non of what suggested here contradict that.


Adds options to remove bookmark

Closes #684
Probably overrides #681

Checks whether bookmark is present or not
Display destructive or default action with Bookmark or Remove Bookmark title
Some sweet test for store

re: action sheet growing, I'm brainstorming ways to move all edit/action functionality into some sort collapsed feature set. Same w/ editing labels/milestones/etc. Would be nice to put it all in one place that is tucked away.


Need visualisation support for cingulate white matter

Related to #181 where the central cerebellar structures that did not lateralise, needed to be hard coded.
In this case, right cingulate WM and left cingulate WM, despite lateralising, do not appear on the visualisation (but do on the table):

this issue was brought to my attention during calibration #75

NB these correspond to GIF parecellation #s 83 (right) and 91 (left)

Can you provide a way to reproduce this?

Can you provide a way to reproduce this?

open branch Mappings Calibration starting at v 1.1.0
then run slicer and load the data
then add custom semiology map cing 2

So it doesn't happen on master?

So it doesn't happen on master?

ofcourse it does, I've just kept a cleaner copy of only the data in master, so the custom semiology map cing 2 won't show anything. This is a made up single datapoint which only maps to the cingulate white matter. If it doesn't work here, it doesn't work in any branch.

For reference, I get No query_semiology results for term "map cing 2" when I tried on master.
Also, the correct branch name is Mappings-Calibration-starting-at-v-1.1.0, not Mappings Calibration starting at v 1.1.0.

Ok so the reason for this is that those structures don't exist in our GIF parcellation for two reasons:

It's not on the list of included structures
Even if it were, it looks like the GIF algorithm didn't segment those from the MNI template we're using.  The parcellation is here. I don't think it typically does, anyway. Maybe we can use one of the manually-segmented brains in the GIF database, but 1) I doubt they include the regions and 2) we would lose the anatomical generality given by the template. I suspect they just merged the Neuromorphometrics labels for WM into right and left cerebral white matter.

Ok so the reason for this is that those structures don't exist in our GIF parcellation for two reasons:

They're not on the list of included structures
Even if they were, it looks like the GIF algorithm didn't segment those from the MNI template we're using.  The parcellation is here. I don't think it typically does, anyway. Maybe we can use one of the manually-segmented brains in the GIF database, but 1) I doubt they include the regions and 2) we would lose the anatomical generality given by the template. I suspect they just merged the Neuromorphometrics labels for WM into right and left cerebral white matter.

Can we include these on the list of included structures?

I don't understand this explanation. What do you mean?
Also the cing white matter are a very specific subset region of the cerebral WM, I'd be surprised if they were merged

Including them won't have any effect. The fact that these structures are in the list is maybe because they were in the Neuromorphometrics atlas, which was used to manually segment some MR images. But maybe they didn't segment all the structures in the atlas. GIF uses these manual segmentations to perform the automatic one (segmentation = parcellation), therefore I'm pretty sure you'll never see them as outputs of GIF.

ok - so can I check, how many segmentations does GIF have per each side of the brain in total?

In Slicer:
>>> import numpy as np
>>> labels = np.unique(slicer.util.array('MNI_152_gif'))
>>> names = [slicer.semiologyVisualisation.parcellation.getNameFromLabel(l) for l in labels]
>>> from collections import defaultdict
>>> count = defaultdict(int)
>>> for name in names:
...     if 'Left' in name:
...         count['Left'] += 1
...     elif 'Right' in name:
...         count['Right'] += 1
...     else:
...         count['Other'] += 1
...
>>> count
defaultdict(<class 'int'>, {'Other': 12, 'Right': 65, 'Left': 65})

This is after removing some structures such as white matter, etc., as I said earlier (https://github.com/thenineteen/Semiology-Visualisation-Tool/issues/184#issuecomment-681841361).

white matter not significant for cortical localisation, but labelled as enhancement as more accurately reflects database


merge from arlac77/npm-package-template-esm-only

package.json

chore(scripts): cover@#overwrite c8 -x 'tests/**/*' --temp-directory build/tmp ava && c8 report -r lcov -o build/coverage --temp-directory build/tmp
docs(package): remove keyword null

Coverage remained the same at 94.591% when pulling 4b8a22b27cb8232bfa0ec53eb7825dd3883b9f94 on npm-template-sync/1 into 74ea0ca849c0d9c54d43860535f9e1517267071c on master.

Codecov Report

Merging #835 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #835   +/-   ##
=======================================
  Coverage   93.74%   93.74%
=======================================
  Files          16       16
  Lines        1933     1933
  Branches      215      215
=======================================
  Hits         1812     1812
  Misses        118      118
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74ea0ca...4b8a22b. Read the comment docs.

:tada: This PR is included in version 5.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


audio

is there a way i can record specific audio outputs ?
like an application with my mic

Ah, right now you can only record one audio stream, specified by --audio-device, so turning this issue into a feature request to mix audio streams.

 For the method I outlined above.
Don't mark this as solved, I think it is a reasonable request. I was just posting a workaround for pipewire users.

Oh got it all i was just confused for what command or application to use for merging this
i search in the package manager for qwpgraph which you spelled wrong
but no problem i got it working now thanks to you appreciate you work sir
and guess i should mark it as solved just let me know


Remove deprecated Openstack modules

Fix #1658 by removing deprecated openstack modules
/terraform/openstack/hosts and terraform/openstack/hosts-floating
Hi, thank you for your contribution to Mantl! Before we can accept any code into
master, we need it to meet the following criteria. If there are any you can't
satisfy yourself, go ahead and open the pull request anyway and we'll help you
test. Feel free to delete this message once you're done. Thanks again!

[x] Installs cleanly on a fresh build of most recent master branch
[x] Upgrades cleanly from the most recent release
[x] Updates documentation relevant to the changes

@shreab373 : Thank you for your contribution Shreya!

@Cryptophobia let's be sure to tag issues/PR's with the upcoming version. Thanks!


[DOCFIX] Improve Docker POSIX doc

When enabling POSIX API using docker, launching the container in background would be more user friendly, so that they don't have to use a new tab/window.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.6 please


Implement latency measurements

Need to measure Pipeline latency ... source-to-sink ... and make available as a new Source Info Display Type

Agree, would be great to have latency measurements as with the sample deepstream-app.  Refer to: https://docs.nvidia.com/metropolis/deepstream/dev-guide/DeepStream_Development_Guide/baggage/group__ee__nvlatency__group.html

Will target v0.08.alpha release for this


Move XRT and tinynumpy to _3rdparty subpackage

Thesse libraries shouldn't be used directly by users and moving them to an _ package makes this clear.
Fixes: Xilinx/PYNQ-Dev#207

Codecov Report

Merging #1135 into image_v2.6.0 will decrease coverage by 1.88%.
The diff coverage is 80.00%.

@@               Coverage Diff                @@
##           image_v2.6.0    #1135      +/-   ##
================================================
- Coverage         48.69%   46.81%   -1.89%
================================================
  Files                22       25       +3
  Lines              3647     4452     +805
  Branches            600      757     +157
================================================
+ Hits               1776     2084     +308
- Misses             1830     2310     +480
- Partials             41       58      +17

Impacted Files
Coverage Δ

pynq/_3rdparty/ert.py
83.13% <ø> (ø)

pynq/_3rdparty/tinynumpy.py
29.28% <ø> (ø)

pynq/_3rdparty/xclbin.py
100.00% <ø> (ø)

pynq/_3rdparty/xrt.py
41.13% <ø> (ø)

pynq/pl_server/xclbin_parser.py
0.00% <0.00%> (ø)

pynq/mmio.py
100.00% <100.00%> (ø)

pynq/overlay.py
31.07% <100.00%> (-0.45%)
:arrow_down:

pynq/pl_server/xrt_device.py
27.84% <100.00%> (-1.90%)
:arrow_down:

pynq/pl.py
72.13% <0.00%> (-3.93%)
:arrow_down:

pynq/pl_server/device.py
33.18% <0.00%> (-3.81%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 596aec2...8679112. Read the comment docs.


Text in Prompts are cut off

VS Code Insiders
Version: 1.37.0-insider
Commit: 360e4e4dfa989135f28edc0d6f7e42df33cddf87
Date: 2019-07-10T05:29:59.244Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.5.0
Notice the image below

I do not see it anymore. Perhaps it was fixed already in insiders.
feel free to close


Multiple tables created

[ ] What animals belong to Melody Pond?

========================================================================
[ ] List of all animals that are pokemon (their type is Pokemon).

========================================================================

[ ] List all owners and their animals, remember to include those that don't own any animal.

=========================================================================

[ ] How many animals are there per species?

=========================================================================

[ ] List all Digimon owned by Jennifer Orwell.

=========================================================================

[ ] List all animals owned by Dean Winchester that haven't tried to escape.

=========================================================================

[ ] Who owns the most animals?

I delete extra lines and create MIT LICENSE.md file.


nmp install 5 vulnerabilities (3 moderate, 1 high, 1 critical)

Describe the bug
npm install lists vulnerabilities
To Reproduce
Steps to reproduce the behavior:

clone the repo
run npm install

Expected behavior
npm install vulnerabilities are fixed
Screenshots
PS C:\development\workspaces\Pborg> npm install

added 1032 packages, and audited 1033 packages in 37s

210 packages are looking for funding
  run `npm fund` for details

5 vulnerabilities (3 moderate, 1 high, 1 critical)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.
PS C:\development\workspaces\Pborg> npm audit fix

added 1 package, removed 4 packages, changed 40 packages, and audited 1030 packages in 6s

210 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

see PR https://github.com/BalticAmadeus/ProBro/pull/578

Merged


Error on upload using Vercel  "Not Implemented"

NotImplementedA header you provided implies functionality that is not implementedTransfer-EncodingKTV1RB2K6FKVMNH4YKFRIkbpJxVX6xFNvpYKKBlITTUumTTPbmc49smzwLSkMTqmHKGAmQEb1r3XcQ8joqleAXhfRQM=

Hi @becem-gharbi. Here is an example:
Request code:
const url = await upload(fileLogo.value, {
  url: form.value.logo,
  prefix: 'logos/',
})

Response:

Just to check, in module configuration have you set driver to s3?

~Just to check, in module configuration have you set driver to s3?~
Edit The error is not related to the module nor to the hosting platform but rather to the S3 provider which seems to reject the PutObject operation. I will check this later. Thanks for reporting this issue, appreciate it.

Thank you for your reply!

Hi @becem-gharbi
I tried it with the new version... I got this

@becem-gharbi Now it works correctly. Thank you very much for your work!


Update universal-application-platform-guide.md

Updated grammar and content structure

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Added an additional commit (c60dcb3) that I think should clear up the language.

Thanks, @devfables .


Remove unused references to use_name

The removes all references to use_name.
Notably absent here is changes to the systemd script, which never used this parameter in the first place.
The normal init script matches this behavior, so this parameter is cruft.

My plan for this is to ship a version to the Forge soon, with a deprecation notice in place for this. I'll let that sit a little and then merge this.


Satty9361 ban ddays config

This adds a default number of days of messages to delete while banning- which is much requested by users.
This is a better solution than #670  as it doesnt change behavior in existing servers while letting people set their own default per server.
Should work reasonably fine from testing , however I am not 100% sure about the changes in validation.go for a general purpose, for this - it works as desired.

Looks good 👍


Change import for express and body-parser

Express and Body Parser don't have default exports, so to use them within Typescript you need to use the import * as syntax.

Thanks a lot for catching this @hagnerd 🙏


When enabling DNS feature for rp pico W network stack never finish setup

I'm trying to make a small program with DNS feature enabled on Rasberry pi Pico W but it never seem to come past the setup.
In the following program the led is never turned on. I have verified that it is while waiting for the stack to be up that the program gets stuck. I have tried to use a static configuration instead of DHCP with no success. Disabling the DNS feature for embassy-net seem to fix it. The problem is that I would like to be able to make a DNS Query.
main.rs:
#[embassy_executor::task(pool_size = 2)]
async fn wifi_task(runner: cyw43::Runner<'static, Output<'static>, PioSpi<'static, PIO0, 0, DMA_CH0>>) -> ! {
    runner.run().await
}

#[embassy_executor::task(pool_size = 2)]
async fn net_task(stack: &'static Stack<cyw43::NetDriver<'static>>) -> ! {
    stack.run().await
}

#[embassy_executor::main]
async fn main(spawner: Spawner) {

    let p = embassy_rp::init(Default::default());

    let fw = include_bytes!("../cyw43-firmware/43439A0.bin");
    let clm = include_bytes!("../cyw43-firmware/43439A0_clm.bin");

    // To make flashing faster for development, you may want to flash the firmwares independently
    // at hardcoded addresses, instead of baking them into the program with `include_bytes!`:
    //     probe-rs download 43439A0.bin --format bin --chip RP2040 --base-address 0x10100000
    //     probe-rs download 43439A0_clm.bin --format bin --chip RP2040 --base-address 0x10140000
    //let fw = unsafe { core::slice::from_raw_parts(0x10100000 as *const u8, 230321) };
    //let clm = unsafe { core::slice::from_raw_parts(0x10140000 as *const u8, 4752) };

    let pwr = Output::new(p.PIN_23, Level::Low);
    let cs = Output::new(p.PIN_25, Level::High);
    let mut pio = Pio::new(p.PIO0, Irqs);
    let spi = PioSpi::new(&mut pio.common, pio.sm0, pio.irq0, cs, p.PIN_24, p.PIN_29, p.DMA_CH0);

    static STATE: StaticCell<cyw43::State> = StaticCell::new();
    let state = STATE.init(cyw43::State::new());
    let (net_device, mut control, runner) = cyw43::new(state, pwr, spi, fw).await;
    spawner.spawn(wifi_task(runner)).unwrap();

    control.init(clm).await;
    control
        .set_power_management(cyw43::PowerManagementMode::PowerSave)
        .await;

    let config = Config::dhcpv4(Default::default());
    // Generate random seed
    let seed = 0x0123_4567_89ab_cdef; // chosen by fair dice roll. guarenteed to be random.

    // Init network stack
    static STACK: StaticCell<Stack<cyw43::NetDriver<'static>>> = StaticCell::new();
    static RESOURCES: StaticCell<StackResources<1>> = StaticCell::new();
    let stack = &*STACK.init(Stack::new(
        net_device,
        config,
        RESOURCES.init(StackResources::<1>::new()),
        seed,
    ));

    spawner.spawn(net_task(stack)).unwrap();

    match control.join_wpa2(WIFI_NETWORK, WIFI_PASSWORD).await {
        Ok(_) => (),
        Err(_) => {
            loop {
                control.gpio_set(0, true).await;
                Timer::after_millis(100).await;
                control.gpio_set(0, false).await;
                Timer::after_millis(100).await;
            }
        }
    }

    // Wait for DHCP, not necessary when using static IP
    while !stack.is_config_up() {
        Timer::after_millis(100).await;
    }

    // THIS IS NEVER REACHED
    control.gpio_set(0, true).await;

    // And now we can use it!
}

Cargo.toml:
[package]
edition = "2021"
name = "embassy-rp-examples"
version = "0.1.0"
license = "MIT OR Apache-2.0"

[dependencies]
embassy-embedded-hal = { version = "0.1.0", git = "https://github.com/embassy-rs/embassy", features = ["defmt"] }
embassy-sync = { version = "0.5.0", git = "https://github.com/embassy-rs/embassy",  features = ["defmt"] }
embassy-executor = { version = "0.5.0", git = "https://github.com/embassy-rs/embassy", features = ["task-arena-size-32768", "arch-cortex-m", "executor-thread", "executor-interrupt", "defmt", "integrated-timers"] }
embassy-time = { version = "0.3.0", git = "https://github.com/embassy-rs/embassy", features = ["defmt", "defmt-timestamp-uptime"] }
embassy-rp = { version = "0.1.0", git = "https://github.com/embassy-rs/embassy", features = ["defmt", "unstable-pac", "time-driver", "critical-section-impl"] }
embassy-usb = { version = "0.2.0", git = "https://github.com/embassy-rs/embassy", features = ["defmt"] }
embassy-net = { version = "0.4.0", git = "https://github.com/embassy-rs/embassy", features = [ "defmt", "medium-ethernet", "medium-ip", "tcp", "udp", "dns", "dhcpv4", "proto-ipv4", "proto-ipv6"] }
embassy-net-wiznet = { version = "0.1.0", git = "https://github.com/embassy-rs/embassy", features = ["defmt"] }
embassy-futures = { version = "0.1.0", git = "https://github.com/embassy-rs/embassy"}
embassy-usb-logger = { version = "0.1.0", git = "https://github.com/embassy-rs/embassy"}
cyw43 = { version = "0.1.0", path = "./cyw43", features = ["defmt", "firmware-logs"] }
cyw43-pio = { version = "0.1.0", path = "./cyw43-pio", features = ["defmt", "overclock"] }

defmt = "0.3"
defmt-rtt = "0.4"
fixed = "1.23.1"
fixed-macro = "1.2"

#cortex-m = { version = "0.7.6", features = ["critical-section-single-core"] }
cortex-m = { version = "0.7.7", features = ["inline-asm"] }
cortex-m-rt = "0.7.0"
panic-probe = { version = "0.3", features = ["print-defmt"] }
display-interface-spi = "0.4.1"
embedded-graphics = "0.7.1"
st7789 = "0.6.1"
display-interface = "0.4.1"
byte-slice-cast = { version = "1.2.0", default-features = false }
smart-leds = "0.3.0"
heapless = "0.8"
usbd-hid = "0.7.0"

embedded-hal-1 = { package = "embedded-hal", version = "1.0" }
embedded-hal-async = "1.0"
embedded-hal-bus = { version = "0.1", features = ["async"] }
embedded-io-async = { version = "0.6.1", features = ["defmt-03"] }
embedded-storage = { version = "0.3" }
static_cell = "2"
portable-atomic = { version = "1.5", features = ["critical-section"] }
log = "0.4"
pio-proc = "0.2"
pio = "0.2.1"
rand = { version = "0.8.5", default-features = false }

[profile.release]
debug = 2

Do you have a debug probe? this is probably a panic, and you can only see panic messages with a debug probe.

I do not have any debug probe sadly,

There where 2 issues, one was that I did not add enought network stack resources (StackResources<4> worked) and the other was that there where to many DNS servers so I had to increase that config (SMOLTCP_DNS_MAX_SERVER_COUNT = "5")


Play 2.5 compatibility

Seems as if some APIs have been removed in Play 2.5 – would be nice to have a new version of play-pac4j compatible to Play 2.5! (-:

Sure. We just released a version 2.1.0 with the new security filter. Soon there will be a new version based on pac4j v1.9.
Let's do a v2.2.0 for Play 2.5. Would you mind giving it a try? I just created a branch 2.1.x and updated the master to 2.2.0 for that.
The demos have been updated accordingly.

Running local builds from master gives the following for me:

ExecutionError: java.lang.NoClassDefFoundError: play/mvc/Results$StatusHeader

Built using master branches of play-pac4j (2.2.0-SNAPSHOT) and pac4j (1.9.0-SNAPSHOT).

Thanks for the feedback. You should just try to move to Play 2.5 and still use pac4j 1.8.6 for now. It will be easier to just upgrade one of the two frameworks.

I get the same error as above with 1.8.6 (which is the reason I tried master branches).  The problem seems to stem from the fact that 'StatusHeader' is now a standalone class in Play 2.5 (and no longer under 'Results').  If I remove pac4j from my project, I don't see the error.

I'm not surprised that the new Play 2.5 version introduces some breaking changes and I think it can be easily fixed.
My main concern is about strategy: I think it's better to upgrade to pac4j 1.9 first and release a 2.2 version. And then, upgrade to Play 2.5 (with pac4j 1.9) and release a 2.3 version.
I will upgrade to pac4j 1.9 in the next days.

Sounds good.  Thank you very much for the feedback. :100:

I've managed to get this module working (as in, no longer throwing the error above) with Play 2.5, fork available at https://github.com/nielsdraaisma/play-pac4j
Further stability is unknown since I've only just started using this library and can't easily go back to older play versions.

Thanks for your help. Though, the priority is given to the upgrade towards pac4j v1.9 which will change several things (https://github.com/leleuj/play-pac4j/tree/play-102). So I would not spend too much time on the Play version upgrade before the play-pac4j version 2.2 is released.

I've noticed you've merged in the branch you mentioned above. Are you expecting more work to be done on that side, or would now be a good time to start looking at play 2.5 support.
I'm happy to retrofit my fork on the current codebase if it's not a waste of time :)

https://github.com/pac4j/pac4j/issues/558 is still on the path of the 1.9 release, but after that, I'll be able to release pac4j and play-pac4j and we'll be able to tackle the Play 2.5 upgrade.
So, currently, we have:

branch 2.1: Play 2.4 + pac4j 1.8 -> released
master (2.2): Play 2.4 + pac4j 1.9 -> in progress

Though, I realized this issue has been opened a few months ago so if you have time and will, I can update master to 2.3 and create a 2.2 branch on which you could upgrade to Play 2.5 while keeping pac4j v1.8, you would need to do that again after the upgrade to pac4j v1.9 as well as on the demos (https://github.com/pac4j/play-pac4j-scala-demo & https://github.com/pac4j/play-pac4j-java-demo).
What do you think?

Hold on.
I realized we already have this PR: https://github.com/pac4j/play-pac4j/pull/106, by @andriykuba which could be used if targeted to the right branch.
I just created the 2.2 branch: @andriykuba, can you submit a new PR to this branch? If so, @nielsdraaisma : could you review the PR ?

@leleuj: done

@andriykuba : thanks

Done for play-pac4j v2.2 (pac4j v1.8): to be done for play-pac4j v2.4 (pac4j v1.9)

Thanks.
I can't find it in maven central yet though. Will it be in there soon?
http://search.maven.org/#search|ga|2|pac4j

Snapshots are only available in the Maven snapshots repository: https://github.com/pac4j/play-pac4j#development till I release the project as the 2.2.0 release (available in the Maven central repo).

Would it be possible to release the latest changes on 2.2.x branch to the Maven snapshots repo? The version that is currently in the snapshots repo does not work with Play 2.5.

It should be ok now.

Great, thank you!

@andriykuba : I released the new play-pac4j v2.3.0 based on the new pac4j v1.9.0, but it is still based on Play 2.4. Would you mind upgrading it to Play 2.5? As well as the demos? Thanks

@leleuj: I will do it

@leleuj: please, verify my pull requests

Thanks for the pull requests and sorry if I was unclear, but they must target the master (which is in version 2.4.0-SNAPSHOT while the 2.3.x branch will stay in Play 2.4 and pac4j v1.9)

No problem, I have moved them to master.

Many thanks. Merging, except the Scala demo where the build is broken...

I will look, my local has been built fine.
Could it be because the "2.4.0-SNAPSHOT" in the sonatype snapshots repository still the old one, so scala demo takes wrong pac4j ?

I think the right 2.4.0-SNAPSHOT version has been deployed to Sonatype repo: https://oss.sonatype.org/content/repositories/snapshots/org/pac4j/play-pac4j/2.4.0-SNAPSHOT/ (I see one from this "morning" matching the latest build: https://travis-ci.org/pac4j/play-pac4j/builds/137747635)


access token created everytime after the same user logout and login again

Describe the bug
Access token got created everytime after the same user logout and login again. and the expire date was set in 100 years. See below screenshot.

Steps to reproduce

Sign in Memos
check the access token generated for this login
logout Memos
login again
check the list of access tokens, you will find a new access token created with a pretty longer valid period, 100 years.

The version of Memos you're using.
v0.22.2
Screenshots or additional context

Yeah, I have the same problem:

Fixed with https://github.com/usememos/memos/commit/6825c1def45fe61e872645cf94cfa1961612dc75


Add API Documentation to ParallelBus

Resolves #939

Coverage remained the same at 78.004% when pulling 35ad0b6ef47edb589bd90083903c7c38104bfe7a on api-parallel-bus into 0bfc5d09bb501ac1d73cc893ae663cb04be33de3 on master.


[WIP] Add sign up form

Resolves #66
temporarily removed required attributes and using my own email for testing
TODO
After submitting, take them to a thank you page.
😎 Preview

Started work on the backend endpoint here, will need to modify this form slightly to POST the form data as JSON to /account-request/submit

Alright, added a script to make the form POST to the new backend endpoint, got it to work locally! Last piece will be to do something like display a success message on the page after submitting, let's sync on how to handle that on Monday @maya :+1:

Thanks, I moved the JS in b9a2af9 to the waitlist form, since the account request form is going to be a different (huge) form. Take a look and let me know if that looks right.

@ClydeDroid Can we add some JS to the Account request form like you did for the waitlist form? https://github.com/CDCgov/prime-simplereport-site/pull/71/files#diff-0c1e6e7622f607373884a13528554e8e645afa4a06fb69d90eca9a1ecc3da991


feat: Support for multilingual embedding models and simultaneous hosting of LLM & embedding models

Problem
Jan lacks support for multilingual embedding models and cannot host both LLM and embedding models simultaneously.
Success Criteria
Jan should be enhanced to support a broader range of multilingual embedding models. Plus, it should be capable of hosting both LLM and embedding models concurrently within a single system.
Additional context
Add any other context or screenshots about the feature request here.

It is supported with the latest Cortex version; the Jan x Cortex would cover this.


Go pass slice in function

Go passes pointers to slices instead of the slice itself.
There are some functions that directly operate on the slice with the assumption, that the slice is copied. This probably leads to some errors.

There are now issues with that.


Delete workflow will delete workflow instance

Purpose of the pull request
Right now, when we delete a workflow we will not delete the relation workflow definition log/task definition log/ workflow instance, this may cause these data always in our db.
This change will delete the related data when delete workflow definition/ workflow instance.
Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #13336 (1097a65) into dev (6634ff9) will decrease coverage by 0.12%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##                dev   #13336      +/-   ##
============================================
- Coverage     39.55%   39.43%   -0.13%
+ Complexity     4305     4303       -2
============================================
  Files          1079     1083       +4
  Lines         40645    40708      +63
  Branches       4665     4650      -15
============================================
- Hits          16077    16052      -25
- Misses        22780    22872      +92
+ Partials       1788     1784       -4

Impacted Files
Coverage Δ

...i/service/impl/ProcessTaskRelationServiceImpl.java
22.05% <0.00%> (-0.17%)
:arrow_down:

...heduler/api/service/impl/ResourcesServiceImpl.java
38.43% <0.00%> (-0.12%)
:arrow_down:

...er/api/service/impl/TaskDefinitionServiceImpl.java
35.39% <0.00%> (-0.64%)
:arrow_down:

...uler/api/service/impl/TaskInstanceServiceImpl.java
50.70% <0.00%> (-5.99%)
:arrow_down:

...java/org/apache/dolphinscheduler/dao/AlertDao.java
26.89% <0.00%> (-1.58%)
:arrow_down:

.../dao/repository/impl/ProcessDefinitionDaoImpl.java
3.44% <0.00%> (-0.90%)
:arrow_down:

...er/dao/repository/impl/ProcessInstanceDaoImpl.java
14.28% <0.00%> (-10.72%)
:arrow_down:

...dao/repository/impl/ProcessInstanceMapDaoImpl.java
12.50% <0.00%> (-7.50%)
:arrow_down:

...ler/dao/repository/impl/TaskDefinitionDaoImpl.java
9.09% <0.00%> (-3.41%)
:arrow_down:

.../dao/repository/impl/TaskDefinitionLogDaoImpl.java
6.66% <0.00%> (-1.03%)
:arrow_down:

... and 33 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add ".well-known/jwks.json" path to common.txt file.

Hi,
This PR add the path to the JSON Web Key Sets file.
It refer to the issue #548 .
This file is documented in the following locations:

Auth0
AWS
Akamai

Thank you very much in advance 😃

Thank you!

You are welcome, thank to you for this project 😃


cp_demo not compiling

src\main.zig:7:14: error: type '@TypeOf(null)' does not support field access
var world: cp.World = undefined;
me new to zig so maybe something not get here

It compiles and runs well on my machine. Are you using latest zig compiler?

i use zig-windows-x86_64-0.14.0-dev.125+a016ca617

ok i found problem is when i copy sp demo in my clean project it not  compile but i found from this repo it works so probably i miss something in my build.zig

Maybe the link option is missing? chipmunk isn't linked ny default, please see last parameter of jok.createGame.

yup thats the reason thanks :)


feat: Buckets & MOS plugins in ExternalFrames in Dashboard

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Adds the Bucket concept and enables ExternalFrame guests to use MOS HTML5 Plugin API

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Other information:

Status

[x] The functionality has been tested by the PR author
[ ] The functionality has been tested by NRK

Looks good from initial glance (I've only looked at the server-side parts).
It needs to be rebased onto release20 and functionality-tested again before merging, I think.

Rebased onto release20 and should be ready for feature-testing along with Ola's updated MOS plugin.

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   66.99%   66.99%
=======================================
  Files         150      150
  Lines        9928     9928
  Branches     2220     2220
=======================================
  Hits         6651     6651
  Misses       3243     3243
  Partials       34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96b297...a96b297. Read the comment docs.

I just realized we should wait for testing before we merge, so that we don't cause any more mess in the workflow. This should now be ready for merging.


get apk urls

hello
How to extract all the links that are used in the apk file ?

Extract all strings using 'get_string' function and match the URL format.


Feature request: prompts

improve prompts

Greetings,
I have added one whitespace at the end of text for each prompt.


Logging: Convert string concatenation to a message template

Imported from Google Code issue #30 created by kushi.p on 2011-04-27T12:42:52.000Z:

This is just a minor nit to make logging read cleaner.
Converted a bunch of logging cases to use message templates as provided by java.util.logging.Logger.
Code review: http://codereview.appspot.com/4444071/
P.S. How do I change the type of issues I submit? Everything comes up under defect which is misleading.

Issue obsolete.


Alarm codec

This PR provides the basic scaffolding for alarms communication between the follower and the leader. The alarms codec encodes/decodes alarm actions into/from an alarm channel (belong to the follower). The leader polls its followers alarm channel periodically and executes messages in the queue (raise-alarm, clear-alarm).

I think there's only one scenario where the alarms channel can be full and it's when there are more alarms messages in the channel than the leader can consume. It's not possible that no one reads the alarm messages IMHO because it's guaranteed that the leader will do in its pull loop and will empty the channel in every iteration.
I think the solution I suggested above (to rationalize the number of alarms raises by using an intermediary table that eats up duplicate messages and flushes the table to the channel every n milliseconds) could be a good solution. Thoughts?

One issue I am thinking of is if we are using the ARP application without a leader -- e.g. as in the ipfix case.  In that case, what do we do?  The channel will fill up for nothing.
Currently the behavior is that we silently drop the most recent messages.  That's not so great!  We need a better answer.

Superseded by #878


RUMM-2209: Prepare version 1.4.0 release

What does this PR do?
Update changelog and version for the version 1.4.0 release.
Review checklist (to be filled by reviewers)

[x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[x] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[x] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #89 (c5f37ce) into release/1.4.0 (f1288ce) will increase coverage by 0.45%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             release/1.4.0      #89      +/-   ##
===================================================
+ Coverage            89.96%   90.40%   +0.45%
- Complexity             147      148       +1
===================================================
  Files                   20       20
  Lines                  448      448
  Branches                50       50
===================================================
+ Hits                   403      405       +2
+ Misses                  28       27       -1
+ Partials                17       16       -1

Impacted Files
Coverage Δ

...in/kotlin/com/datadog/gradle/plugin/DatadogSite.kt
100.00% <0.00%> (+13.33%)
:arrow_up:


Fix for proxy sqlite support

Fix #184

Hi @BcTpe4HbIu
Thank you for making time to create this PR. The CI build failed on this:
manifests/proxy.pp - ERROR: tab character found on line 489
manifests/proxy.pp - ERROR: tab character found on line 490
manifests/proxy.pp - ERROR: tab character found on line 490
manifests/proxy.pp - ERROR: two-space soft tabs not used on line 489
manifests/proxy.pp - ERROR: two-space soft tabs not used on line 490

Could you please take a look at it and fix it before I can accept this PR?
Thank you.
Kind regards,
Werner

Hi @dj-wasabi
Fixed it.

Thanks!!


vulkaninfo: Fix including promoted structures

If a structure is promoted to a core version, and the version used is equal or greater than that, the structure should not be included, since it will be a part of the core structure

CI Vulkan-Tools build queued with queue ID 93814.

CI Vulkan-Tools build # 1307 running.

CI Vulkan-Tools build # 1307 passed.

CI Vulkan-Tools build queued with queue ID 93823.

CI Vulkan-Tools build # 1308 failed.

CI Vulkan-Tools build # 1309 running.

CI Vulkan-Tools build queued with queue ID 93843.

CI Vulkan-Tools build # 1310 running.

CI Vulkan-Tools build # 1310 passed.


fix(utils): Ruby string count check

This PR includes a change to enable using the SDK with Rubymotion:

Condition to check for object count only if the object is not an NSString or subclass of NSString. The string size is checked in the length condition.

Can you also share a sample Rubymotion project?

The exception stack trace:
*** Terminating app due to uncaught exception ‘ArgumentError’, reason: ‘app/app_delegate.rb:14:in `application:didFinishLaunchingWithOptions:‘: wrong number of arguments (ArgumentError)
’
*** First throw call stack:
(
0  CoreFoundation                      0x000000010303fb0b __exceptionPreprocess + 171
1  libobjc.A.dylib                    0x0000000100328141 objc_exception_throw + 48
2  leanplum_test                      0x0000000100131a10 _ZL10__vm_raisev + 336
3  leanplum_test                      0x0000000100131aa0 rb_vm_raise + 80
4  leanplum_test                      0x000000010003b679 rb_exc_raise + 9
5  leanplum_test                      0x0000000100035793 rb_raise + 179
6  leanplum_test                      0x00000001000c2976 create_intersected_charset_table + 486
7  leanplum_test                      0x00000001000b718e rstr_count + 46
8  leanplum_test                      0x0000000100190fa9 +[Utils isNullOrEmpty:] + 119
9  leanplum_test                      0x000000010019c5db +[Leanplum setAppId:withDevelopmentKey:] + 68
The exception is raised by the Ruby for MacOS code: https://github.com/MacRuby/MacRuby/blob/master/string.c#L5547
since the count method in Ruby requires parameters.
The string responds to the count selector and even though it is cast to NSArray, the count method is executed on the string without parameters. The string does have a parameterless count method in Ruby and throws the above exception.
I have also sent you an email with more information.

Thanks for the info. I also found this that have been helpful to understand the issue:
http://community.rubymotion.com/t/cant-call-count-on-a-string-that-has-been-cast-as-an-nsarray/2145
Can you do 2 things?

Keep what you have but remove the casting. Both NSString and NSData have length, and it's not good to convert it explicitly to NSData. Similarly with count. All collections have this including Dictionary, Array and Set. Better to remove them.

Have a comment that says something like:
Need to check for NSString to support RubyMotion.
RubyMotion String have count: method and in their implementation, respondsToSelector(count) is true for count:.


Grouch Additions to README.md

Added trash

I'm not totally sure what I am doing here but I'm giving it a try.


feat(imagewithcaption): introducing image with caption

Related Ticket(s)
https://github.com/carbon-design-system/ibm-dotcom-library/issues/3546
Description
Created the image with caption (web component version)
Changelog
New

{{new thing}}

Changed

{{changed thing}}

Removed

{{removed thing}}

@andysherman2121 minor things for the documentation, the title in storybook we have been using spaces for the component names, can you make that adjustment?
Also it looks like in the props table in the README are missing description text.

@andysherman2121 minor things for the documentation, the title in storybook we have been using spaces for the component names, can you make that adjustment?
Also it looks like in the props table in the README are missing description text.

Fixed the title in storybook. Working on fixing prop table not showing up in storybook

Thanks @andysherman2121 for the update!
@jeffchew @kennylam - Not sure the icon position change in the Percy (titled: "Components/Feature Card Block Large: Default") is right or not, any thoughts? Thanks!

Thanks @andysherman2121 for the update!
@jeffchew @kennylam - Not sure the icon position change in the Percy (titled: "Components/Feature Card Block Large: Default") is right or not, any thoughts? Thanks!

I think the branch is out of date. I'll rebase it.


Implement skipped tests in OrganizationControllerTests

Implemented skipped unit tests in OrganizationControllerTests, sorry about the whitespace changes, I'm new to git, adding &w=1 to URL shows the changes without whitespace.
Closes #1425

@HamidMosalla thanks for the contribution and the updates! @tonysurma :shipit:


Use filter names in envoy api

Please provide a description of this PR:

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test lint_istio

gencheck_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test lint_istio

gencheck_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test gencheck_istio

unit-tests_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test gencheck_istio

unit-tests_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test unit-tests_istio

lint_istio
4e9ab83515341d416b34f2c0a0699230087f79cc
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
a42bbc2094b531c20e3dc7646481d4c05f6264b6
link
true
/test unit-tests_istio

lint_istio
4e9ab83515341d416b34f2c0a0699230087f79cc
link
true
/test lint_istio

gencheck_istio
4e9ab83515341d416b34f2c0a0699230087f79cc
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4e9ab83515341d416b34f2c0a0699230087f79cc
link
true
/test lint_istio

gencheck_istio
598968df9a325e4456fd4e42f3de3a2b8008dc5e
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
598968df9a325e4456fd4e42f3de3a2b8008dc5e
link
true
/test gencheck_istio

unit-tests_istio
598968df9a325e4456fd4e42f3de3a2b8008dc5e
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-cni-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-cni-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-cni-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-cni-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-cni-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-istiodremote-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-security-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-distroless-k8s-tests_istio

integ-pilot-istiodremote-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-tests_istio

integ-pilot-istiodremote-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-istiodremote-multicluster-tests_istio

integ-cni-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-cni-k8s-tests_istio

integ-pilot-k8s-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-k8s-tests_istio

integ-pilot-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-pilot-multicluster-tests_istio

integ-security-istiodremote-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-security-istiodremote-tests_istio

integ-security-multicluster-tests_istio
1e408f729381f7b2a224b38140bb4f05e5ea765f
link
true
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hzxuzhonghu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio/wg-user-experience-maintainers

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless-k8s-tests_istio
9ba7a540cfaf55a41bc6cfe7c47a58d185b604b3
link
true
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-distroless-k8s-tests_istio


Adding user guides go cloud guardrails

Problem to solve
Hello, this is my first time contributing on github, hope I am doing this right. My name is Benoit Larivee (benoit.larivee@canada.ca), I am a project manager for the Digital Communications and Collaboration Project at SSC. We helped most partners in the deployment of the security baseline. One of our technical SME (Cary Connolly) has developed some user guides that could be useful to both administrators and end users. We got asked for them a lot through the security baseline (cloud guardrails) session. We recently received the French translation of those documents and would like to make the French/English user guides available to all partners who seeks the guidance of the cloud guardrails. We would like to add them to Github but I am not sure how to proceed to add them. Can you please help me on how to add them?
Thank you
Intended users
All GoC partners
Further details
N/A
Proposal
If you could please upload the documents (GCDocs links below) to Github
Permissions and Security
N/A
What does success look like, and how can we measure that?
User guides can easily be shared with all GoC partners
Links / references
Getting started with OneDrive
English - https://gcdocs.gc.ca/ssc-spc/llisapi.dll?func=ll&objId=75373298&objAction=properties&nexturl=%2Fssc-spc%2Fllisapi.dll%3Ffunc%3Dll%26objid%3D54003693%26objAction%3Dbrowse%26sort%3Dname
French - https://gcdocs.gc.ca/ssc-spc/llisapi.dll?func=ll&objId=76919148&objAction=properties&nexturl=%2Fssc-spc%2Fllisapi.dll%3Ffunc%3Dll%26objid%3D54003693%26objAction%3Dbrowse%26sort%3Dname
How to register your security information for MFA
English - https://gcdocs.gc.ca/ssc-spc/llisapi.dll?func=ll&objId=75371158&objAction=properties&nexturl=%2Fssc-spc%2Fllisapi.dll%3Ffunc%3Dll%26objid%3D54003693%26objAction%3Dbrowse%26sort%3Dname
French - https://gcdocs.gc.ca/ssc-spc/llisapi.dll?func=ll&objId=76922079&objAction=properties&nexturl=%2Fssc-spc%2Fllisapi.dll%3Ffunc%3Dll%26objid%3D54003693%26objAction%3Dbrowse%26sort%3Dname
Preparing Teams and SharePoint
English - https://gcdocs.gc.ca/ssc-spc/llisapi.dll?func=ll&objId=75370677&objAction=properties&nexturl=%2Fssc-spc%2Fllisapi.dll%3Ffunc%3Dll%26objid%3D54003693%26objAction%3Dbrowse%26sort%3Dname
French - https://gcdocs.gc.ca/ssc-spc/llisapi.dll?func=ll&objId=76922080&objAction=properties&nexturl=%2Fssc-spc%2Fllisapi.dll%3Ffunc%3Dll%26objid%3D54003693%26objAction%3Dbrowse%26sort%3Dname

@benoitlarivee I'll take a look and add the links to the correct locations.

Thanks Benoit


An introduction to REST and its constraints

I've just added the first two chapters of the REST section: the introduction to REST and 6 constraints of REST.

Hi @oskardudycz, I'm not sure you've seen this PR. I would highly appreciate your feedback, which will help me in later chapters.

@Mejtika I appologize for a delay. I planned to check that during the weekend, but it didn't work out. I'll try to go through that today or in the worst case - tomorrow.
Thank you a lot for those changes!


Storefront returns 500

Hi, I have followed the instructions here: https://docs.saleor.io/docs/developer/installation
I have build and created docker image but when I try to run the platform. I can't acces to storefront. Even though I can acces to dashboard and graphql pages.
Anyone having similar issue?
…

System information
Operating system: Ubuntu 20.04
Browser: Chrome

I'm having the same issue
I tried to rebuild storefront image but it didn't work

System information
Operating system: Mac OSX 11.4
Docker: 3.3.3

Well, I managed to run storefront with saleor-platform by:

Stop docker instance by docker-compose down
Reset changes, checkout latest release version of storefront which is 2.11.0
Edit docker-compose.yml file from saleor-platoform. Under storefront service, change command: npm start -- --hostname <IP_ADDRESS> to command: npm start -- --host <IP_ADDRESS>
run docker-compose up -d to start the services again


Update repo link after split

It was still linking to the HAL.

Thanks for the fix!
The next patch / minor release will correct this on docs.rs and crates.io.


Allow defining a custom model for InboundEmail

Allows defining a custom model for InboundEmail giving us the ability to add additional relationships.

I had contemplated using the custom model in the CleanEmails command,
But given that it calls delete directly on the query builder instance, no events are fired anyway so I didn't see any benefit.

Nice addition. Thank you!

Sorry if this is not allowed here - but @hailwood can you maybe give a short example on how to use a custom model? I have tried adding my custom model in the config/mailbox.php file, and use below in my AppServiceProvider, where Email is my custom model:
<EMAIL_ADDRESS>function (Email $email) {
            // Handle the incoming email
            return $email;
});

And inside my Email model, I have defined another table:
  protected $table = 'emails';
   protected $fillable = [
       'message',
   ];

   protected static function boot()
   {
       parent::boot();

       static::creating(function ($model) {
           $model->message_id = $model->id();
       });

But when I send an email to the inbound, it will still be added to the default mailbox_inbound_emails table, and not my emails table.


Update unbound.conf and a-records.conf references

PR Summary
Small PR - adjusts the correct location of the unbound.conf and a-records.conf files in README.md.

Thanks for the contribution!


Fixed issues for the failing autodyne container and enabled web interface on host machine

This pr has the following changes:

Fixed issues for the failing autodyne container
Fixed "mkdir samples samples-output" issue
Fixed python version issue
Enabled web interface on host browser (added reverse proxy in containers)

webserver is just a nginx server serving the internal firmware router network on the container port 80

as i said, its just simple nginx server serving on port 80, and that can be changed too from the nginx and docker-compose config


EIS for SPMe+SR in Matlab Simulink

Hello,
I am trying to obtaing the EIS from simscape battery model  Dr Widanage based on the SPMe+SR model proposed by @brosaplanella.
The observation is I am getting an EIS quite different from the EIS plot we obtained previously in this discussion. The parameter set is Chen2020 for both cases. I am attaching my Matlab code and the EIS plot obtained below. If anyone can guide or propose some suggestions to this will be highly appreciated.
Thank you.
MATLAB Code
simuLinkMdlStr = 'TSPMeA_EIS_New1';                                                                             % Specify the simulink file name (without the file extension)
load_system(simuLinkMdlStr+".slx")
set_param(simuLinkMdlStr,'SimscapeUseOperatingPoints','off');
Vmax = 4.2;                                                                                % Set upper cut-off voltage [V]
Vmin = 2.5;                                                                                % Set lower cut-off voltage for terminating discharge [V]
modelProp = Simulink.SimulationInput(simuLinkMdlStr);
frequencies = logspace(-4,2,30);
Z_real_array = [];
Z_imag_array = [];
for FF = frequencies
Freq = 2piFF; % rad/s
Ts = 2*pi/Freq;
Amp = 0.01;    % A
%Changing any intial conditions if needed:
modelProp = modelProp.setBlockParameter([simuLinkMdlStr,'/TSPMeA'],'z0',num2str(0.9));                           % Initial cell SoC, let's assume 70%
modelProp = modelProp.setBlockParameter([simuLinkMdlStr,'/Temperature Source'],'temperature',num2str(298));     % Ambient temperature [K], let's assume room temperature
modelProp = modelProp.setBlockParameter([simuLinkMdlStr,'/TSPMeA'],'T0',num2str(1500));                           % Initial cell temperature [K], let's assume 283K (10degC)
modelProp = modelProp.setModelParameter('StopTime','Ts*20','SaveState','on','SaveOutput','on','SaveFinalState','on','FinalStateName','OperPoint'); % Set simuation options
simOut_P = sim(modelProp);                                                                                % Simulate the "modelProp" object with the above specifications
%period for the desired frequency 10Hz
period = 1 / FF;
% Calculate the number of samples per period
samples_per_period = round(simOut_P.tout(end) * FF);
Current_new = simOut_P.logsout{1}.Values.Data; %(end - 2 * samples_per_period:end);
Voltage_new = simOut_P.logsout{2}.Values.Data; %(end - 2 * samples_per_period:end);
save_system(simuLinkMdlStr+".slx")
% Extract time vector from simulation results
time_vector = simOut_P.tout;
% Calculate the sampling interval
sampling_interval = mean(diff(time_vector));
% Calculate impedance using Fourier transform
Fs = 1 / sampling_interval;  % Use the determined sampling interval
N = length(Current_new);  % Number of samples
current_fft = fft(Current_new)/Fs;
voltage_fft = fft(Voltage_new)/Fs;
%voltage_fft = fft(Voltage_new-mean(Voltage_new))/Fs;
% Find the index of the dominant frequency in the current signal
[~, idx] = max(abs(current_fft));
impedance_at_dominant_freq = voltage_fft(idx) / current_fft(idx);

% Store impedance results
Z_real_array = [Z_real_array, real(impedance_at_dominant_freq)];
Z_imag_array = [Z_imag_array, imag(impedance_at_dominant_freq)];

end

This isn't a PyBaMM model so closing this issue. Hopefully someone can help in the discussion you opened


addListing page from clone project

The file is empty!

Just update it, can you check again? Thank you 🤓


Set Up GitHub Pages from the main branch

Set up GitHub Pages under the repository settings and configure the publishing source accordingly.

Public website of my resume
https://l3onardvg.github.io/homepage/


warn if there are untracked files in the repo

I think Onyo should be opinionated about maintaining a clean repo.
If there are untracked files, it is likely:

a user oops
leftovers from an onyo oops
a bad user decision that is a disaster waiting to happen

It also makes it harder to trust our assertion that file names are unique, as we use the git index to check that.
Onyo should check at the beginning of every invocation (unless we determine this is too expensive) whether the tree is clean. By warning /right away/, users should have a pretty good idea of /what/ caused it, and the git history will be helpful.
The user should use .gitignore for any intentionally untracked files in-repo. Silly users should be silly in a sane-ish fashion.

If I understand this right, it would mean that an onyo-repo has to be either 100% onyo, and can't be a normal git repository with code or other stuff in it or at least if somebody would create a new file, since this would block onyo from working until all files are handled again?

No, that's not quite right.
If someone wants to store "non-Onyo" stuff in the repo, they have two options:

commit the files (the content is now tracked)
use .gitignore to ignore the files they're storing in the repo (in an uncommitted state)

What I am proposing is that Onyo should error when it encounters untracked files that are not ignored by .gitignore.

With the implementation of #86 the user will be warned when using any (except read-only) onyo <command> in case there are changes which are not commited.

Will they be warned? Or will it error out? I /strongly/ prefer the latter.

It will error out and specify the files causing problems, and how to solve them 👍


Make it easier to block websites

It is a hassle to have to supply the -s flag each time a site is blocked. Could this be make easier? Maybe the first argument always have to be the site that is blocked or unblocked.

Maybe I could make use of a subshell instead of piping the way brew handles installation and uninstallation of many packages at once:
brew list > ~/brewlist
brew uninstall —force $(brew list)
brew install $(cat ~/brewlist)


Support for verifications

It would be cool if we could verify the pacts using a mock server.
I saw something similar in this package: https://github.com/lemusthelroy/dart-pact-testing

I'm already working on unit testing verification that doesn't require the external mock server.
Will be the next big feature to release.


New message - New message line appears for the user who sent the message

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Expected Result:
New message line should only appear when the other user sends new messages
Actual Result:
New message line appears when the main user sends a message.
Action Performed:

Log in to expensify.cash
Navigate to a conversation and send a message

Workaround:
No need, visual issue.
Platform:
Where is this issue occurring?
Web ✔
iOS
Android
Desktop App
Mobile Web
Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Issue is not reproducible everytime, in fact it's hardly reproducible. We currently don't have solid reproducible steps but it has happened twice already to 2 different users.

Expensify/Expensify Issue URL:
View all open jobs on Upwork

From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1620756130077900

a message I sent myself shows as new, which makes no sense as I sent it

@iwiznia what was the time difference between receiving the message before this and you sending the message? ie were they sent within the same 60 secs of each other?

I've replicated a version of this where if you type at the same-ish time as someone else the New bar hangs for both messages -

It's not the exact same as Ionatan's report though where it seemed to exclusively apply to the new sent message

Am amending this to a weekly, as not able to repro reliably yet

Seems like yes

Why does that matter?

@iwiznia I just wonder if this is down to some sort of time lag that gets exposed when both messages are send within the same 30secs or whatever

It could be, I have no idea honestly.

There are no further reports of this, but leaving open

Triggered auto assignment to @mitchexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MitchExpensify am OOO til 5 July, so am handing over this one. Waiting for more reports / more reliable reproducibility before adding external

Sounds good @laurenreidexpensify ! Will keep an eye out for any more reports!

Not overdue

On hold


Operator is not creating Service for Daemonset.

When creating production Deployment of jaeger configuration, Agent service does not get created.
apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaeger-prod-es
spec:
  agent:
    strategy: DaemonSet
  ingress:
    enabled: false
  strategy: production
  storage:
    type: elasticsearch
    options:
.
.
.

Get pods command returns this:
NAME                                               READY   STATUS      RESTARTS   AGE
jaeger-op-prod-jaeger-operator-9dd6bb756-qrmgz     1/1     Running     0          4d19h
jaeger-prod-es-agent-daemonset-9886b               1/1     Running     0          4d17h
jaeger-prod-es-agent-daemonset-mfr9s               1/1     Running     0          4d17h
jaeger-prod-es-collector-59bcfb5c97-69hqk          1/1     Running     0          135m
jaeger-prod-es-es-index-cleaner-1580514900-p44xm   0/1     Completed   0          2d18h
jaeger-prod-es-es-index-cleaner-1580601300-pbqtd   0/1     Completed   0          42h
jaeger-prod-es-es-index-cleaner-1580687700-gkx49   0/1     Completed   0          18h
jaeger-prod-es-query-7c99b4db5b-ncjgg              2/2     Running     0          135m

I had to create the Agent Service locator manually. it is supposed to be created automatically...
apiVersion: v1
kind: Service
metadata:
  labels:
    app: jaeger
    app.kubernetes.io/component: agent
    app.kubernetes.io/instance: jaeger-prod-es
    app.kubernetes.io/managed-by: jaeger-operator
    app.kubernetes.io/name: jaeger-prod-es-agent
    app.kubernetes.io/part-of: jaeger
  name: jaeger-prod-es-agent
  namespace: observability
spec:
  clusterIP: None
  ports:
  - port: 5775
    targetPort: 5775
    name: zk-compact-trft
    protocol: UDP
  - port: 5778
    targetPort: 5778
    name: config-rest
    protocol: TCP
  - port: 6831
    targetPort: 6831
    name: jg-compact-trft
    protocol: UDP
  - port: 6832
    targetPort: 6832
    name: jg-binary-trft
    protocol: UDP
  selector:
    app: jaeger
    app.kubernetes.io/component: agent
    app.kubernetes.io/instance: jaeger-prod-es
    app.kubernetes.io/managed-by: jaeger-operator
    app.kubernetes.io/name: jaeger-prod-es-agent
    app.kubernetes.io/part-of: jaeger
  sessionAffinity: None
  type: ClusterIP

Service Listing from get svc command:
NAME                                     TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)                                  AGE
jaeger-op-prod-jaeger-operator-metrics   ClusterIP   <IP_ADDRESS>   <none>        8383/TCP,8686/TCP                        4d21h
jaeger-prod-es-agent                     ClusterIP   None             <none>        5775/UDP,5778/TCP,6831/UDP,6832/UDP      62m
jaeger-prod-es-collector                 ClusterIP   <IP_ADDRESS>   <none>        9411/TCP,14250/TCP,14267/TCP,14268/TCP   4d19h
jaeger-prod-es-collector-headless        ClusterIP   None             <none>        9411/TCP,14250/TCP,14267/TCP,14268/TCP   4d19h
jaeger-prod-es-query                     ClusterIP   <IP_ADDRESS>    <none>        16686/TCP                                4d19h

The DaemonSet shouldn't be backed by a service. The idea is that clients should get the DaemonSet's IP via downward API (host.ip) instead, so that all spans generated on a given node will reach the daemonset (via UDP) that is running on the same host. Using a service means that you'll potentially be sending data over the real network to some other daemonset.
If you going this path, then it's probably better to just make your clients talk directly to the collector.

I'm closing this issue, but feel free to reopen if you need further clarifications.

But how to open the port of agent above TCP/UDP?

@kakaNo1 not sure I understand your question.


Link to user-guide in readme is broken

The link to the user-guide in the readme links to a non existing file.

Thanks! Although there is not much of a user-guide available yet, the link has been fixed.


[fix] DESCRIPTIVE TITLE

Describe the bug
Koa-body is failing to parse the context request from the client
I sense a bug
i changed to use the latest version of koa-bodyparser and its worked
Node.js version:
NODE 16.15.0
OS version:
Linux - Ubuntu distro
Description:
const app = new Koa();
const router = new KoaRouter();
const server = http.createServer(app.callback());

app.use(helmet());
app.use(KoaBodyParser());
app.use(mount("/api", api));
app.use(mount("/auth", auth));
app.use(router.routes());

//catch errors in one place, automatically set status and response headers
onerror(app);

This should probably be opened on the middleware repo:

koa-body
koa-bodyparser
And the maintainers will also probably want some more details, especially the content-type of the request and a simplified version of its content.

@iamgabrielsoft this issue should be reported to @koa/body repo.