Feature/composite src generator

@firox263  @na2axl
This is the follow up PR for #133
It adds a source generator and modifies the sample project which demonstrates the usage of a composite template.
What do you think?

Depends on #140

Hm as we said that we wan't the source generators to be opt in, I think we should have two samples. One using a source generator for composite templates and one without. What do you guys think @gircore/coreteam ?

I like that idea. It's good understanding how everything works under the hood without any "magic", even if source generators are the practical option that most people would use.
I imagine there are some edge cases where doing it manually could be helpful too.

I wonder if we can have a better name for the Integrator project? As it would be some public nuget package later on. Any ideas?

We probably only want to provide one source generator to make it easy for users of our library to get the C# coding benefits. So the name should probably be s.th. general but with a connection to us.
As our libraries have a package id like Gir.CS.X it could be Gir.CS.Integration. Actually I like Integration better than Integrator. So I would rename the project accordingly?
@firox263 thoughts?

I like Integration quite a bit. I think we should go with that 👍
Off-topic, but what's the reason we have CS in our package IDs? It seems a bit redundant.

@firox263 / @na2axl :+1:
I renamed the folder and added some common *.props files to avoid duplication.
Regarding the package id: It was meant as preparation for libraries of a different language. Eg. if we manage to build some F# bindings on top of our C# ones to improve the language integration, those packages could be Gir.FS.X.
What do you guys think of it? Should we keep it or should we use a totally different name?

Regarding the package id: It was meant as preparation for libraries of a different language. Eg. if we manage to build some F# bindings on top of our C# ones to improve the language integration, those packages could be Gir.FS.X.

A while back, I decided to see if I could port QuickStart to visual basic, mostly to see if it was possible. It actually worked really well. Turns out, as long as we are CLR compliant, we can use C# libraries from other .NET languages "for free". So I'm not sure we'd ever need to build dedicated F# bindings.
One option could be to make a Gir.Integration.CSharp, and a Gir.Integration.FSharp, etc and use that as a namespace for all our language-dependent integrations. I haven't looked into this PR in detail enough to know if it works like that, but it could be an option for code sharing. What do you think?

A while back, I decided to see if I could port QuickStart to visual basic, mostly to see if it was possible. It actually worked really well. Turns out, as long as we are CLR compliant, we can use C# libraries from other .NET languages "for free".

Yep regarding VB there is no separation needed. The same goes for F# in principle. But I could guess that a nice F# API looks different to the C# one as we could try to hide objects and make it somehow functional (perhapps by wrapping the C# API).
I never tried it or thought it completely through but regarding functional UIs there are some slides from @praeclarum.

One option could be to make a Gir.Integration.CSharp, and a Gir.Integration.FSharp, etc and use that as a namespace for all our language-dependent integrations.

This sounds like a good idea. I'm going to update this PR with your idea.

Alternatively, if we wanted to keep our current naming, I'd prefer to put the language after the library (e.g. Gir.Gtk.CSharp, Gir.Gtk.FSharp) so we can sort by library alphabetically.

As a nuget search for CSharp brought a lot of hits and the CSharp was often a suffix and not a prefix I would do like you suggested and make it a suffix.

@firox263 Thanks for the review :+1:

@firox263 Thanks for the review :+1:


Update service-fabric-reliable-actors-kvsactorstateprovider-configura…

…tion.md

Hi @sumukhs, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Microsoft authors of articles need to make updates through the private repository so the updates can be staged and validated by the current validation rules. After you review staging and fix all validation issues, you can add the sign-off comment to let the PR reviewers know the updates are ready to be merged.
It�s easy to access the private repo version of your articles in GitHub. Just add �pr to the URL, as follows:
Public repo URL: https://github.com/Azure/azure-content/blob/master/articles/azure-portal-overview.md
Private repo URL: https://github.com/Azure/azure-content-pr/blob/master/articles/azure-portal-overview.md
We've closed this pull request. Please resubmit the updates through the private repo. If you need perms to the private repo, see the contributor guide instructions.


scaffolder: Fix issue with circular JSON whilst templating

fix: don't passthrough all of task
chore: added changeset

Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[ ] All your commits have a Signed-off-by line in the message. (more info)

@dagda1, most probably but it's pretty tricky to test. The tests were already in place we were just spreading in too much. Might add a small one :)

@dagda1, most probably but it's pretty tricky to test. The tests were already in place we were just spreading in too much. Might add a small one :)

no point if it does not add anything or is potentially flakey

Looks like this is actually already in 1.20.2: https://github.com/backstage/backstage/releases/tag/v1.20.2


[4.0] GDScript no syntax error on trailing comma(",") in function parameters

Godot version
Godot 4.0 beta 4
System information
Windows 10
Issue description
GDScript gives no syntax error on trailing comma(",") in function parameters. Below, is an example script with a trailing comma in the example function parameters, you'll note no syntax errors:

The above is not inline with Godot 3 behavior, as seen below:

Steps to reproduce

Open example project
Open example.gd
No syntax errors

Minimal reproduction project
example.zip

Just tested it, this also happens in function parameters:

Lists like in arrays and dictionaries allow a trailing comma. This is a convenient feature so you can have each entry on it's own line, and rearrange them without having to add/remove the last comma.
var arr := [
   1,
   2,
   3,
   4,
]

Perhaps it is intentional, as one could do the same thing with functions:
res = myfunc(
   arg1,
   arg2,
   arg3,
)

Or perhaps it is intentional and related to not variadic function proposals.
https://github.com/godotengine/godot-proposals/issues/1034
https://github.com/godotengine/godot/issues/16565

I think this is intentional indeed, it does allow a syntax like @tinmanjuggernaut showed:
res = myfunc(
   arg1,
   arg2,
   arg3,
)

It behaves similarly in Python 3:
>>> def somefun(
...   a1,
...   a2,
...   a3,
... ):
...     print(a1)
...
>>> somefun("hi", None, None)
hi
>>> def somefun2(a1, a2, a3,): print(a1)
...
>>> somefun2("hi", None, None)
hi
>>> somefun2("hi", None, None, )
hi
>>> somefun2("hi", None, None, ,)
  File "<stdin>", line 1
    somefun2("hi", None, None, ,)
                               ^
SyntaxError: invalid syntax

@akien-mga Okay, so I guess this issue should be closed?

Agreed, no need to disallow it, I can imagine using it in a monolithic function with a lot of arguments with each one being on a new row.

@Calinou also confirms this was a "heavily requested feature": https://github.com/godotengine/godot/pull/68691#issuecomment-1315588139


Make trains transition instead of teleport

The trains indicate movement by teleporting where they are, but I would instead make it transition to it's new position, so it looks a lot smoother and imo smoother. The current teleporting is kinda hard to look at tbh

I 100% agree. I'm going to try to construct a PR tonight!


Update Android SDKs, Java JDK and action versions to newer versions

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.
Could we maybe just lock in in the minor version?

Minor versions would be fine. Expectations and reality have a tendency to not align

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.
Could we maybe just lock in in the minor version?

Minor versions would be fine. Expectations and reality have a tendency to not align

It seems you can not refer to a minor version. Only major versions or absolute versions are supported, thus I have changed all actions to refer their latest version.
@fremartini Please re-review


Depends on #51: Feature/30 hinzufuegen von nicht gezeichneten objekten

Depends on: #51 Feature/23 veraendern der renderconfiguration per gui ermoeglichen

If the PR depends on #51 you should imho

merge #51's feature Branche into this feature branch AND
do modifications in this feature branch in order to still work correctly (precisely: change defaultRenderConfiguration’s entry for water to the "new" dictionary style)

Otherwise, merging #51 and afterwards #57 (this PR) would make defaultRenderConfiguration corrupted.


Please push the 1.2 update

This mod looks pretty interesting, however I'm not using the Steam version of the game (where the 1.2 update would be available according to the Steam Workshop page). Could you please push and release it here as well?
Thanks!

This mod is working perfectly fine in 1.2. I've just tested it. The game gives you a warning, but you can safely ignore it.
As for the warning in game, a new release of the mod with a requirements/version bump would be great of course.

@Zauberfisch: I'm aware it works fine. I just thought if they can bump the version on Steam, it shouldn't be to much to ask to also bump it here. :slightly_smiling_face:

Ditto with the 1.3 version; released on Steam, but not here :(


fix: properly display highlight group information

This is very much a patch set; you probably don't want to review the merged diff.
All commits have been formatted with stylua -- ..
fix: update to nvim_buf_set_extmark
nvim_buf_set_virtual_text was deprecated in Neovim v0.6.0.
fix: properly position highlight group text
Row offsets weren't accounted for.
feat: support |:command-bar| when possible
Ran into the lack of bar support while testing.
Refactoring commits
These patches are split up for readability. Most of them serve as preparation for the introduction of utils.get_hl_groups_for_range().
refactor: use utils.range_contains()
This function is introduced, which doesn't want the LHS to be a node. Use of this function clarifies that some existing checks use positions as zero-width ranges and that some other functions are able to take full ranges and not just positions.
perf: use utils.range_intersects()
This function is introduced as a companion to utils.range_contains(). Use of this function removes the final manual range checking in utils.get_hl_groups_at_position(). Use of this function allows for inspecting less trees whenever multiple trees share the same row (utils.get_hl_groups_for_range() will now ignore trees that occupy relevant rows but irrelevant columns).
refactor: use utils.for_each_hl_tree()
This function is introduced as a wrapper for LanguageTree:for_each_tree().
refactor: use utils.for_each_query_capture_for_range()
This function is introduced as a companion to LanguageTree:for_each_tree(), but instead iterating via Query:iter_captures(), mainly to factor out the range checking logic and clean utils.get_hl_groups_at_position()'s implementation further.
I think there's potential for better performance by using utils.for_each_hl_tree() and utils.for_each_query_capture_for_range() more directly in lua/nvim-treesitter-playground/printer.lua, but this is left as future work.
refactor: use for_each_hl_group_for_range()
This function is introduced as a private, specialized wrapper for most of utils.get_hl_groups_at_position()'s internals, and would not exist if not for the next commit.
fix: use utils.get_hl_groups_for_range()
This function is introduced as a range-based alternative to the position-based utils.get_hl_groups_at_position(). utils.get_hl_groups_at_position() would be changed to a simple wrapper of utils.get_hl_groups_for_range() if not for the slight interface change (returning a table with capture_id, capture_name, capture_node, and capture_metadata instead of a table with capture (containing the capture ID) and priority (containing one piece of information from the capture metadata). This more directly passes through what Query:iter_captures() provides. To provide this alternative interface with minimal code duplication, for_each_hl_group_for_range() is used. (If utils.get_hl_groups_at_position() becomes deprecated and later is removed, for_each_hl_group_for_range() should be inlined.)
Additionally, flatten_node in lua/nvim-treesitter-playground/printer.lua now directly uses utils.get_hl_groups_for_range() and avoids an extra iteration over every hl_group.
This commit's message follows:
utils.get_hl_groups_for_range() requires that highlight groups contain the whole range argument, preventing highlight groups that only occur at the start of a node's range from being reported for the whole node.
Without this patch, for get_hl_group_for_node, the playground prints:
  parameters: parameters [8, 36] - [8, 49] @variable / @function / @punctuation.bracket /
    "(" [8, 36] - [8, 37] @variable / @function / @punctuation.bracket /
    name: identifier [8, 37] - [8, 42] @punctuation.bracket / @variable / @parameter /

With this patch, the playground prints:
  parameters: parameters [8, 36] - [8, 49]
    "(" [8, 36] - [8, 37] @punctuation.bracket /
    name: identifier [8, 37] - [8, 42] @variable / @parameter /

In this example, @punctuation.bracket is no longer incorrectly associated with the parameters node, among other corrections.
fix: properly prevent trailing highlight group separator
As you can see in the previous playground example, trailing separators for highlight group information aren't being handled properly.
perf: separate highlight group separator virtual text
Avoiding these string concatenations is faster. Additionally, the separator is no longer highlighted.
With anonymous nodes & highlight group information showing in lua/nvim-treesitter-playground/hl-info.lua, I experience a noticeable speed-up compared to both the previous commit and master when adding and removing spaces in insert mode between M.show_ts_node and the directly following (opts. It's still laggy on my machine, but it's better. I consider this a performance win for the whole patch set.

Please don't lump unrelated commits into a single PR; that makes it impossible to review (and merge).
You should open a single PR per topic -- if in doubt, one per commit, unless there's a strong reason.

Not saying those changes aren't welcome, but I need to consider (and discuss, and merge) them one at a time.

When refactoring, also consider the eventual goal of upstreaming to Neovim core; there's now a bunch of utility functions in Nvim 0.8 that can (and should) be used here.

Please don't lump unrelated commits into a single PR; that makes it impossible to review (and merge).
You should open a single PR per topic -- if in doubt, one per commit, unless there's a strong reason.

The 2 commits through "fix: properly position highlight group text" deal with incorrect positioning of highlight group text, the 9 commits through "fix: use utils.get_hl_groups_for_range()" deal with incorrect highlight groups being returned by playground functions (one source, multiple expressions), and the 2 commits through "perf: separate hl_group separator virtual text" deal with the extra " / " at the end of every highlight group text line. These changes were initially one or two commits, but I split them up to try and make them easier to review. A lot of the intermediate stuff could be merged, but I was worried that a diff that large would be hard to review. I think these changes being in one PR makes sense, given that they're pretty related and most of the PR is dealing with the incorrect highlight group issue, but this could be split into 2 or 3 PRs if necessary. (The first two commits are just moving from nvim_buf_set_extmark to nvim_buf_set_virtual_text and then making sure to subtract one.)

When refactoring, also consider the eventual goal of upstreaming to Neovim core; there's now a bunch of utility functions in Nvim 0.8 that can (and should) be used here.

I was looking at those, but given that nvim-treesitter depends on Neovim v0.7.0, I didn't want to start using them here yet. I also considered the available utility functions in nvim-treesitter, but none caught my eye. The one I was closest to using was nvim-treesitter.ts_utils.get_node_range(), but AFAIK LuaJIT prefers when you don't use unpack(). I did some light analysis of nvim-treesitter.ts_utils.get_node_range() vs direct access and utils.range_contains() vs nvim-treesitter.ts_utils.is_in_node_range() with https://luajit.me/, but I can't speak confidently about LuaJIT optimizations.
Personally, I'd like to see functions that consistently work with range tables upstream ({ start_row, start_col, end_row, end_col }) instead of nodes (I think this could be pretty ergonomic with a TSRange class metatable—node:range():contains(other_node:range())). This allows for the left-hand side of these operations to be ranges not associated with nodes (e.g. the minimal range that contains two sibling nodes). (I'm not gonna hold up changes in this PR about all that though.)

I think these changes being in one PR makes sense, given that they're pretty related and most of the PR is dealing with the incorrect highlight group issue, but this could be split into 2 or 3 PRs if necessary.

Let me be clear here: it is necessary. "Pretty related" is not enough, they need to require each other for it to be a single PR.

nvim-treesitter depends on Neovim v0.7.0

No, that is only because I haven't had time to update it yet. Nvim-treesitter (and especially playground) only supports the latest release (0.8.0 at time of writing) and the latest commit on master.

LuaJIT prefers when you don't use unpack().

I don't think we need to worry about that kind of optimization here; if it becomes a (benchmarked!) bottleneck, we can optimize that function.

functions that consistently work with range tables upstream

Yes, that could be a reasonable refactor. We still need to work with nodes, but the interface should be made more consistent.


Disable nagles alg

Closes https://github.com/c42f/RemoteREPL.jl/issues/54.
This PR adds a single line to disable nagles algorithm, using the Sockets.nagle function. This is done on the client side, inside the setup_connection! function.
On my system, the effect is that @btime @remote 1+1 goes from 44.5 ms to 0.601 ms, or a 74x speedup. As the operation itself (1+1) takes 1.4 ns, we can say we are approximately timing the overhead. So in other words, the overhead of calls to @remote is reduced 74-fold.
I have made no changes to any documentation, and I have not performed any more than a single test. I am not sure if we should expect this to break anything, as the change is rather minor. Testing was done on Julia 1.9.3.

Ping @c42f have you found time to take a look at this?

Thanks for getting around to it. I know you are busy with other important stuff. I am pretty sure I was watching you live on the Juliacon stage when I wrote the previous comment xD


BearerTokenExample - format?

Hello,
Can you tell for the BearerTokenExample given that I have an OAuth token what should the override bearerToken() return? Is it just the OAuth token, "Bearer " + token, "OAuth " + token? Does the code even work with OAuth or is just with Session Id?
Thanks,
Phat

Forget it works. I used the wrong hostname.


getConfig() is being called early in controller if getParameters() is called.

I just found some strange behaviour in the execution order of JsonApiTrait.
Assuming the following methods added to the base controller:
// Controller.php
protected function setSchema($schemas = [])
{
    $this->schema = $schemas;
}

protected function getConfig()
{
    $config = $this->getIntegration()->getConfig();
    $this->schema === null ?: $config[C::SCHEMAS] = array_merge($config[C::SCHEMAS], $this->schema);

    return $config;
}

// AuthorsController.php
public function show(Request $request, $id, $type)
{
    // this causes getConfig to be called early
    $params = $this->getParameters();

    $this->setSchema([
        Post::class => function ($factory, $container) {
            $schema = new PostSchema($factory, $container);
            $schema->renderAsRelation = true;

            return $schema;
        },
    ]);

    return $this->getContentResponse(Author::findOrFail($id)->getPosts());
    }
}

If getParameters() is called inside a controller action before setSchema()
then getConfig() is also called before the schema can be injected into the
config array.

The root of the problem is that this trait is trying to be helpful (maybe too much :smile:)
When getParameters is called it works this way

it needs parameters from URL and controller configuration to compare (no problem here)
it decodes media types of received data (Content-Type header) and requested (Accept header). Then it wants to check if those types are supported (that's the root of the problem). It takes all registered encoders and decoders, finds best matching media types, encoder and decoder. While doing this it instantiates encoder (in EncoderMatcher::matchEncoder) (that's likely unnecessary thing to do) which leads to getConfig call.

What are the possible solutions?
Firstly I feel coupling between parameter parsing and matching encoder/decoder has to be changed. It doesn't look beautiful to intercept it with overriding getConfig when a developer actually wants to say 'use this encoder' or 'use these encoder settings'.
I think getParameters should parse and check URL parameters and media types in headers however encoder and decoder should not be instantiated. A developer should have an option to modify encoder/decoder/their settings before getContentResponse is called. For example

get media types (requested/matched) and set new encoder/decoder (object or closure)
get media types (requested/matched) and set parameters that will be sent on closure call

I tend to think the first variant is more flexible. In pseudo-code it might be
    if ($this->getEncoderMediaType()->getType() === 'application/vnd.api+json') {
        $this->setEncoder(Encoder::instance([
            Author::class  => AuthorSchema::class,
           ...
        ]);
    }

What do you think?

This works for me, and it makes more sense to be able to inject your own encoder vs just overriding an element in the config array.

Nice to hear it :smile:


Fix EE deploy template to use nodejs 14 to prevent consistently failing

Root cause TBD. Manually running deploy-parallel.sh from EE account works but running deploy using the codebuild wrapper fails to instantiate VPC.

--- deploy-output.vpc.txt ---
--
615 | Provisioning vpc resources
616 | npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!
617 | npm WARN<EMAIL_ADDRESS>No repository field.
618 | npm WARN<EMAIL_ADDRESS>No license field.
619 | npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
620 | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
621 |
622 | added 355 packages from 268 contributors and audited 356 packages in 14.266s
623 |
624 | 28 packages are looking for funding
625 | run `npm fund` for details
626 |
627 | found 0 vulnerabilities
628 |
629 | !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
630 | !!                                                                            !!
631 | !!  Node 12 has reached end-of-life on 2022-04-30 and is not supported.       !!
632 | !!  Please upgrade to a supported node version as soon as possible.           !!
633 | !!                                                                            !!
634 | !!  This software is currently running on node v12.22.12.                     !!
635 | !!  As of the current release of this software, supported node releases are:  !!
636 | !!  - ^18.0.0 (Planned end-of-life: 2025-04-30)                               !!
637 | !!  - ^16.3.0 (Planned end-of-life: 2024-04-30)                               !!
638 | !!  - ^14.5.0 (Planned end-of-life: 2023-04-30)                               !!
639 | !!                                                                            !!
640 | !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
641 | Unexpected token '?'
642 |
643 | Subprocess exited with error 1

Removed offending commit #332 but not clear why this caused an issue

Issue was caused by CDK no longer supporting nodejs 12. Github actions test container runs updated version of nodejs but deployment script doesn't.

This can probably be solved by changing both the GitHub Actions and CodeBuild containers to use Ubuntu.

Fixed by #336


HDDS-7403. README Security Improvement

What changes were proposed in this pull request?
Improve Ozone Security feature documentation. Ozone integrates with Kerberos for authentication and supports native and Ranger Acls.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7403

cc @kerneltime


IMessagesStore#storeRetained: this method should decide to store QOS0 messages

QOS0 retained messages

Closes: #304

This PR contains no fix. I am sorry i added your issue number to this but it was the wrong PR. The deletion of the link comment didn't have a effect to the linking.


Hi! You do a great job. And I want to know that have you already released your Supp?Where could I get it?

I have the same problem.

I've added a link to the supplemental PDF on the project page. You can find it here.
In addition, the submission had two supplemental videos. These are already included on the project page as 'Denoised Submillilux videos' and 'Comparison against other methods'.


Investigate setting document.currentScript

https://developer.mozilla.org/en-US/docs/Web/API/Document/currentScript

Trying to write to it normally fails in Firefox with:

TypeError: setting getter-only property "currentScript"[Learn More]

We can make a getter via:
		Object.defineProperty(document, 'currentScript', {
			value: tag,
			configurable: true
		});

However I'm not sure how to remove that once set to return to normal behaviour

However I'm not sure how to remove that once set to return to normal behaviour

Figured it out: we can use delete!


Wrong URL in Intune Installation

In the intune installation section:

To configure devices with Microsoft Intune, use a custom policy:
Go to the Microsoft Intune admin center

The URL is wrong.
It should have been https://intune.microsoft.com/ instead of https://intune.micorsoft.com/
Notice the spelling of Microsoft.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6f9ed30a-a257-6481-e3ea-960b7c33c658
Version Independent ID: 6f9ed30a-a257-6481-e3ea-960b7c33c658
Content: Configure Stickers for Windows 11 SE - Windows Education
Content Source: education/windows/edu-stickers.md
Product: windows-client
Technology: itpro-edu
GitHub Login: @paolomatarazzo
Microsoft Alias: paoloma

Thank you @anubhav4sachan ! Fixing it now.


Library support?

From what I see the software doesn't yet support tape libraries, is there plans for such? This software would be really convenient with a tape library.

Ltfs library edition does expose all the tapes in the library in the library mount point as folders. The driver works very much like single drive ltfs, just switch the -o devname flag to changer_devname in the mount command.
So I would assume each of the tapes would show in the software as the library is mounted?
[](https://www.ibm.com/docs/en/spectrum-archive-le/2.4.5?topic=system-starting-spectrum-archive-le-linux)


Duplicated contracts when ccrewrite is run with out-of-band contract assembly.

Example of this behavior can be observed in TestResults\Out\Deploy\OutOfBand.dll assembly created when running tests from UnitTests project. Rewrite is taking place in Foxtrot\Tests\UnitTests\RewrittenContractTest.cs on line x = RunProcess(deploymentDir, foxtrotPath, "/rewrite /assemblyMode=standard /rw:RewriterMethods.dll,TestRewriterMethods /nobox /throwonfailure /contracts:OutOfBand.Contracts.dll /autoRef:- OutOfBand.dll");
OOB contracts (/contracts: parameter for ccrewrite.exe) seem not to be used in final product during build.

Can we closed it?

Unfortunately no. This is an issue I found when enabled additional post-rewrite check in foxtrot. It is not critical so I will try to address it some other time.

@hubuk Ok. But this one will not block us from the new release? Right?

@SergeyTeplyakov It should not. The problem is not a regression. The only place I found where Out of band contracts are used (/contracts: switch) is in foxtrot tests. Rewriter run by MSBuild is not using this parameter.

@hubuk Excellent. If you know about any issues/PR that you would really like to see in the upcoming release, please note it here. I'm going to publish new rc-version tomorrow.

@SergeyTeplyakov I was able to provide one more fix for rewriter (issue #168) in PR #344. In addition the build is broken due to lack of some types used in new contracts for Task class. Fix for this is available as #343.


Improve process of reporting broken links

Currently, the 404 page looks like this:

This isn't very helpful if the link comes from Google, which is the most likely cause. It also doesn't acknowledge the fact that the link broke because we broke it. 😂
I suggest we replace this guidance with:

Sorry, we accidentally broke this link. Could you please let us know so we can fix it?

I think we should create a new issue template specifically for broken links and change the link to point to that template.
Once @mrderyk has shipped docs search, we can update the above message by appending it with:

You can also search for this topic in the search box above.

In theory, if we're following good development practices, this should be fairly rare at least for us to be the reason for it.  That is:

Docusaurus fails the build if it finds broken links, so as long as builds are being tested locally before they're getting pushed, we shouldn't have broken links within the docs.  (The exception is from API playground to other docs, where we're using fully qualified URLs instead of relative URLs)
We should be checking URLs we're sending from other locations (e.g. console, website) before pushing commits that break the docs.  This should be part of the review process

That said, this looks not very intuitive for those of us that have never used React, but https://stackoverflow.com/questions/71370916/how-do-i-customise-the-404-page looks like instructions on how to do it @pwoznic .  @cjcenizal  you might actually be in a better position to help do this

@eskibars One other situation in which broken links can occur is if Google indexes a page which we then rename or delete, and we forget to add a redirect. Of all 404s, this will likely be the most common.


Develop upstream sync 210621

The pylint failures are bogus.  The missing files were deleted upstream and that has been reflected in this merge but pylint got confused.  Also, the offending line corresponding to the line too long error exists upstream.  There seems to be issues even with this pylint test.


[Feature request]  ctrl + s  popup save dialog

Hi,
ScreenToGif is amazing ! Very easy to use.  Just one thing I think a little inconvenient ,  press ctrl + s show a right window, I have to click the folder ico to select where to save. Directly popup a save dialog to choose save path would be better I think.

Hi, thank you :D
I understand the inconvenience, but it's currently necessary.
The panel that opens when you hit Ctrl + S or when you click Save As lets you choose between 4 types of output files, each one of them has its own Output Folder and Filename.
So, there's a need for it to happen like that. :/


Fix random seed for generator function

#328
This draft works for c++ now. Not working for pybind.

Actually, before this PR, c++ part works fine.
I think the problem is all on pybind side.


feat: add month and year pickers to DateRangePicker and RangeCalendar

Closes #3089
Closes #3090

📝 Description
Added month and year pickers to DateRangePicker and RangeCalendar.
⛳ Current behavior (updates)
DateRangePicker and RangeCalendar do not have month and year pickers.
🚀 New behavior
DateRangePicker and RangeCalendar now support month and year pickers.
💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information

@ryo-manba please adjust the range calendar docs and make clear that it only works when visible months is 1, add examples as well to range-calendar and date-range-picker docs

@jrgarciadev
Sorry for the delay. I have updated the documentaton!

@ryo-manba
when is the pull request scheduled to be closed ?

@Artem2001S This PR is marked in 2.5.0 milestone. We'll merge this after v2.4.3.


Add codeclimate cov

Coverage remained the same at 67.314% when pulling 178b516d86a2307ad08497e10e5319152179bca2 on addCodeclimateCov into 05f13368dbd124c777e1eb66f0dda5d374e5adfd on master.


Create consistent performance iscsi disk

This pull request should co-work with the pull request in softlayer-go (https://github.com/maximilien/softlayer-go/pull/37), otherwise it might fail because of unresolved interface.
Since there was a little change of softlayer pricing model, a modification on getItemPrices was made to order performance storage.
I also removed a testcase for ""Reports error due to wrong disk size"" in softlayer_creator_test.go in softlayer disk package. Because I had changed the code to calculate the disk size to make it suitable for softlayer, the situation of wrong disk size would not happen, so this testcase became noneffective.

This actually looks good. One minor comment. Please address the comment in subsequent PRs.
Merging, thanks.


My Life in Ops: Docker, Terraform, AWS, and Learning As We Go

Over the past two years, Northwestern University Libraries has moved its repository infrastructure and applications to Amazon Web Services. Our initial solution, presented at Samvera Connect 2017, involved AWS CloudFormation, several different deployment platforms, and a lot of manual intervention. In our second phase, we have adopted a fully automated build/configure/deploy system to stand up Fedora, Solr, PostgreSQL, Redis, a Cantaloupe IIIF server, an Avalon Media System instance, a secure CloudFront streaming media distribution, and two Hyrax applications using Terraform, Docker, AWS Elastic Beanstalk, and a whole bunch of homegrown tools and hacks. This presentation will provide an overview of our current system, and hopefully jumpstart some discussions of how these tools can be adopted, standardized, and reused among other members of the Samvera community.
Michael B. Klein<EMAIL_ADDRESS>

Michael not able to attend - email 08/24:
In the intervening time since submitting my proposal, I’ve discovered that I have obligations here that will prevent me from traveling to Samvera Connect. I’m working with two of my Northwestern colleagues who will be in attendance to see if one or both of them would be willing to present in my place, with me leading the effort on designing and writing the presentation (and possibly even Skyping in for the Q&A). Would that scenario be acceptable to the program committee, or should I withdraw?
Response still needed 08/28


New GUI Concept

Made in Sketch, and looks better than the current. Also suggests a custom icon feature for VMs, if not use the last session's screenshot. Shows VM Name, Last used and Current size on disk.
This is only a home page so far. I could make more if needed.

The iPhone UI concept looks good, but would this translate over to iPads?

Yeah that looks nice. I'm not sure what the other tabs would be though. It doesn't make sense to make settings its own tab because it's per-VM. Debug Log isn't really useful for 99% of people, so it doesn't make sense to give real estate to it.
I think the tiles are nice but there's a bit too much shadow imo, it doesn't look "modern iOS". According to Apple:

Minimal use of bezels, gradients, and drop shadows keep the interface light and airy, while ensuring that content is paramount.

What do you think about this but with a modern design? Wizard machine creator based on your Apple hardware and the guest OS would be great.
It is Qemu manager 7 for windows.

Also
PDF MANUAL:
qemumanager.pdf

I very specifically wanted to AVOID something like that. It feels antiquated to me and doesn't fit iOS.

Yeah that looks nice. I'm not sure what the other tabs would be though. It doesn't make sense to make settings its own tab because it's per-VM. Debug Log isn't really useful for 99% of people, so it doesn't make sense to give real estate to it.
I think the tiles are nice but there's a bit too much shadow imo, it doesn't look "modern iOS". According to Apple:

Minimal use of bezels, gradients, and drop shadows keep the interface light and airy, while ensuring that content is paramount.

True, I did kinda neglect using a list view. I will update that.

The iPhone UI concept looks good, but would this translate over to iPads?
On iPads we could have a form of split screen, the selection for vm on the side, vm details on the rest of the screen (settings etc)

I’ll try make a better one with a bit more context and also a iPad version

It was only an idea to have more options but it's better to follow Apple guidelines, simplicity its much better.
Thanks, Osy86 and vishy.

I would try to make storyboards but sadly I'm not that experienced in iOS. I code in flutter, not native. I'll stick to sketch, I'm almost done with the home design, I'll also try design VM settings and maybe more menus. From reading latest issues, I'll make a MacOS version too

How does this look? I kind of based it on the current GUI, and Apple's Guidelines.

It looks very nice, I add in red my suggestion.
Mosaic/List view icon for more options
Different (Play) location
RAM in the general specs

I'll update that when I get time.

Thanks Vishy-dev

no problem, I just saw this project, had some free time, found it interestiny. I wanted to contribute.

I didn't add the second button you suggested parallel to the Windows 7 text, as that would be too many in my opinion.

Very nice but what about this? like in the Files app.

Also RAM first, SPICE Tool last. ;-)

Also there is a line for that. Boot sequence.

Very nice but what about this? like in the Files app.

tried that but couldn't find the icon in apples library so I went with that

Also there is a line for that. Boot sequence.

I'll update it in a bit

Also what should the Mac OS version look like hmm

Maybe I'll use a virtual box like design but then with new things. So like play controls and edit etc could be in a top bar like this

if we want more refinement, the icons with the OS logo can be even better. The exact OS Logo, Windows 10 logo is different to XP for example, and same in macOS, Tiger, Leopard, Catalina ... Linux Arch Debian, Suse, Ubuntu ... The ideal thing is to put the OS logo in the bottom left of the snapshot:

hmmmm i dont know if this is good so far

if we want more refinement, the icons with the OS logo can be even better. The exact OS Logo, Windows 10 logo is different to XP for example, and same in macOS, Tiger, Leopard, Catalina ... Linux Arch Debian, Suse, Ubuntu ... The ideal thing is to put the OS logo in the bottom left of the snapshot:

hmm, like how virtual box has some generic icons, we could get something like that

I’m by no means an expert on this but I strongly suggest that UTM uses generic icons because the project probably doesn’t have rights to use those icons

yes thats true for what snspla said. thats probably why vbox has their own icons

Probably, some Parallels and VMWare uses genuine logos, not generic but are paid apps, maybe with rights. But elegant generic is OK.

how it look?

vmware uses their own icons

looks custom too, but this could be a old version, its just from a google.

how it look?

Not so clean as previously. It needs more refinement, more Apple Style.

Which parts? I didn't know what to do for the like bottom info section. If you could guide me a bit as I'm not sure apple doesn't have much on listviews/ info views for macOS.

What do you think about this, without squares

Even, it can be simplified with small and elegant icons

I was also thinking about a fusion like design, with just a big picture and basic info on the VM view and the more detailed stuff in settings

like this?

Look at my Parallels and my VirtualBox: Complete different. I think UTM is a Qemu machine and should be more like what you are doing, similar to Virtual Box but with more macOS style and elegant.

hows my new design

also heres a pic of fusion for reference

yea what you are saying. It needs to be like vbox, but more fitting with macOS

like this?

This one looks very nice the only thing is the icons in the corner, not sure about the style. Also the trash is close to the settings so it can be accidentally touch

there would be some sort of verification before deleting?

1 min let me change the button style

or do we put the buttons in the toolbar ?

i like this one

Good point and the trash down in the corner, also a play button un the center of the os that when is paused can be converted into sleep button such as a moon or zzz

ok 2 mins

wait if we put a play button do we move the vm text down to below the image or put the play button below the Windows 10

I think that trash should be separated, in the corner or inside the setting.

hmm, i guess its in settings now

wait if we put a play button do we move the vm text down to below the image or put the play button below the Windows 10

where we put it

hmm, i guess its in settings now

I love this one

looks perfect now

or do we not like the play button

I love it, even with 2 play buttons but it's ok.

You are a genius Vishy

Maybe the notes in the OS corner should appear if in the settings, someone fills this field.

hmm
but i kinda like it there. for example if i stored credientals there if it was like a premade vm from a future importable like .utmVM or something. if so i would have to open settings every time to get the creds

I like it there too, but I mean that if we add a field in the settings to add notes, it automatically is on the main screen, but if it is empty, nothing there. What do you think?

yea could be. i kinda liked the area where it says click to add text as like a text box, but that could be too

The next step is the VM toolbar
In parallels is in the top, in Virtualbox is in the bottom

hmm

And the settings view also

Settings in VB and P

im a bit busy right now, ill be back in 15-20 mins

Take your time, you have done a big step. Thanks for your contribution

backkk. just attended a birthday party

ok ive put the latest version on https://vishy-dev.github.io/utmGUI so when we are done people wont have to scroll

do we use a side bar like par or topbar like vbox?

Good question, the idea is to do something original, clean and fresh design

im thinking a finder like sidebar with all the things

we can also make some minimal icons

what other settings would there be hmm

looks good

I like it and it is a good idea to have small icons, we have to think also in the dark mode, so the change doesn't affect to the final design.

don't think theres more stuff that utm does right now? can i get a like list of any settings im missing. if none ill start designing the icons and then the menus themselves

Storage maybe separate?

Sorry, Drives is there

yes

adding icons from apple's icons

usb icon is hard to find

maybe cause there isnt one...

got a usb icon but now need a disk icon

got it
(totally not stolen from finder but)

I don't know the icon style you are using to help you

almost done anyway

im just using apple's sf icons

looks good to me

very cool

thx, now im gonna do the pages itself

in the System tab:
Name, Description / Notes
Processor
RAM
JIT
...

should we make a general tab for Name, Description / Notes
then in system
Boot Sequence
OS
Architecture
Processor & Processor Aceleration
RAM

Better

In the General tab, an OS presets settings would be good (main OS configuration profiles for non-experts ), also a "restore defaults" button in all settings could be nice.

hows this?

Elegant but can we add color to the RAM bar? just to indicate the recommended for your computer based on your specs.

Boot Sequence for the General Tab

I’m gonna be busy for a bit, color may be harder to add as I’m using apples predefined ui  kit but ok

not necessary but maybe as it is in the iOS app, a numerical indicative in a note under the slider.

hows this

boot sequence can be a part of drives

In the General tab, an OS presets settings would be good (main OS configuration profiles for non-experts ), also a "restore defaults" button in all settings could be nice.

ill add the restore button, but i guess the config would be preset based on the os you select and your host's power

Was wondering why I had a hundred new emails this morning…

lollll, sorry

(Edited) I have made a new GUI for UTM: iPhone, iPad and MacOS (In Progress)
Instead of scrolling, I update the latest GUI at https://vishy-dev.github.io/utmGUI/
If you want to suggest something, add a comment. If you want to see the new GUI, just use the link

lol It will look like Virtual Box

(Edited) I have made a new GUI for UTM: iPhone, iPad and MacOS (In Progress)
Instead of scrolling, I update the latest GUI at https://vishy-dev.github.io/utmGUI/
If you want to suggest something, add a comment. If you want to see the new GUI, just use the link

if the ios device has dark mode enabled, will dark mode support the new GUI?

Closing this since the new UI will be tracked in #408


ISE when selecting link property in a complicated expression

Given the schema:
  type Person {
    required name: str;
  }
  type Queue {
    multi people: Person {
      position: array<int64>;
    }
  }

The following query produces an assertion failure in _normalize_view_ptr_expr:
update Queue set {
  people += (
    select distinct({
      Person{@position := <array<int64>>[]}
    }) {
      @position := [2]
    }
  )
};

Removing the distinct or the braces within the distinct call result in a more sane error message.
A different error is produced if the @position := [2] is removed while keeping an empty shape.

(This is definitely not an edgedb-python issue)

Please post the ISE message and traceback, also


Qdigidoc not probably wrapped with qt

Describe the bug
[nix-shell:~/.cache/nix-review/pr-69651]$ ./results/qdigidoc/bin/qdigidoc4
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted
To Reproduce
nix-shell -p qdigidoc4
qdigidoc4
Expected behavior
opens application
Screenshots
Metadata
Please run nix run nixpkgs.nix-info -c nix-info -m and paste the result.
$ nix run nixpkgs.nix-info -c nix-info -m
[1 copied, 0.0 MiB DL]

system: "x86_64-linux"
host os: Linux 4.19.74, NixOS, 19.03.173522.021d733ea3f (Koi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.2.2
channels(root): "nixos-19.03.173549.ebdc4419310"
channels(jon): "home-manager, nixpkgs-20.03pre194293.2436c27541b"
nixpkgs: /home/jon/.nix-defexpr/channels/nixpkgs

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

@yegortimoshenko (maintainer)
cc #65399

fixed on master


How to debug AADSTS501481: The Code_Verifier does not match the code_challenge supplied in the authorization request errors?

Please follow the issue template below. Failure to do so will result in a delay in answering your question.
Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Description
We see quite a few logs showing this error
AADSTS501481: The Code_Verifier does not match the code_challenge supplied in the authorization request
an example one with correlation id and trace id
501481 - [2020-12-03 19:34:01Z]: AADSTS501481: The Code_Verifier does not match the code_challenge supplied in the authorization request. Trace ID: 4dca72dd-f02e-4615-b1c9-e226952f2200 Correlation ID: 0a49cdbc-2e94-4089-bc6f-1162b123592c Timestamp: 2020-12-03 19:34:01Z - Correlation ID: 0a49cdbc-2e94-4089-bc6f-1162b123592c - Trace ID: 4dca72dd-f02e-4615-b1c9-e226952f2200
I understand the error is coming from the service, what can I do to debug this error and figure out why it is happening?
Thank you!

Closing as duplicate of #2691, also may be related to #2690


Unhandled promise rejections cause miniflare process termination (Windows, node v16.2.0)

e.g. if you forget to await a promise, an unhandled promise rejection is thrown causing process termination and requiring manual restart of the dev server. I think I can fix this by catching them in my own code, but it might be good for miniflare to catch them in general as it would better mirror the behavior of a cloudflare worker (which wouldn't die to an unhandled promise rejection-- at least I don't think they do?).

Hmm actually, I'm not sure that Worker support for the unhandledrejection event is released yet, so this may indeed need to be handled at the miniflare level https://twitter.com/jasnell/status/1447935685319667722

Great, I'll try it out!


Move new std::net backend to Rust

Migrate std::net to a new Rust library that provides access to reqwest to Python code.
Enhances the std::net tests to fully test the output of the network request, as well as adding an error-case test.

Finding concurrency bugs is genuinely one of my greatest joys.
On Tue, Oct 15, 2024, 19:50 Matt Mastracci @.***> wrote:

@.**** commented on this pull request.
In edb/server/http/src/python.rs
https://github.com/edgedb/edgedb/pull/7866#discussion_r1802258401:

       drop(permit);

   }

   counts.active -= 1;

}

fn update_limit(&self, new_limit: usize) {

   let mut counts = self.counts.lock().unwrap();

   let old_capacity = counts.capacity;

   counts.capacity = new_limit;

   if new_limit > old_capacity {

       let added = new_limit - old_capacity;

       self.semaphore.add_permits(added);

   } else if new_limit < old_capacity {

       let removed = old_capacity - new_limit;

       self.semaphore.forget_permits(removed);

Ack. I think you are correct. Let me add a test for this case.
—
Reply to this email directly, view it on GitHub
https://github.com/edgedb/edgedb/pull/7866#discussion_r1802258401, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACTC7LNW6YEBAZOJJITF5TZ3XH6LAVCNFSM6AAAAABQABOHYCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZRGA3DCMZSGE
.
You are receiving this because you commented.Message ID:
@.***>


Feature Request for Auto Language Detection

Hello
Firstly, thank you for developing this incredibly useful plugin. It's made my workflow in Obsidian much smoother.
I have a feature request that could further enhance the user experience: Would it be possible to implement auto-detection of the language used in a note? The idea is to generate titles that are contextually relevant to the language of the note. For example, if the note is written in French, the generated title should also be in French.
I believe this would be a valuable addition to the plugin, especially for those who often work with notes in multiple languages.
Thank you for considering this feature request. I look forward to any updates.

it should be done in version 0.5.25-beta


Package stopped working

Hi,
Since a week or so the package has stopped working. I think the issue is that it is unable to retrieve data from the morningstar website.
The code that i'm running is as follow, for example for adobe stock:
adbe = mf.Ticker('adbe')
adbe_ratios = adbe.keyRatios.T
adbe = adbe.financials.T
error:
AttributeError: 'NoneType' object has no attribute 'T'
The following statements are printed:
Unable to get keyRatios data for adbe
Check http://financials.morningstar.com/ratios/r.html?t=adbe
Kind regards

Unfortunately Morningstar decided to shut down the datasource.

Unfortunately Morningstar decided to shut down the datasource.


Merge scanlines

Thank you for helping out with embedded-graphics development! Please:

[x] Check that you've added passing tests and documentation
[x] Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, etc) if your changes affect the public API
[x] Run rustfmt on the project
[x] Run just build (Linux/macOS only) and make sure it passes. If you use Windows, check that CI passes once you've opened the PR.

PR description
Adds an optimisation/cleanup to merge adjacent scanlines when rasterising thick polygons.
A ~5% performance boost on x64, so not as much as I would've hoped for but it's in the right direction. The complex fix_overlap function is removed for a simple accumulator in the iterator that holds the currently growing line.

We could save a few bytes of memory by using Option<(i32, i32)> or perhaps Option<RangeInclusive>, because all we don't need to store the y coordinates. But I'm not sure if that's worth the effort.

We should definitely take a look at this in the future, but maybe it would be a good idea to take a look at thick polylines/thick polygons/thick triangles when all three are supported. For example, I'm working on thick stroked triangles at the moment and there might be some common code/logic we can introduce with a wider picture.

And I think there has been some rebase issue, because the commit is called: "Add support for transparent characters"

Oops. Let me fix that...

We should definitely take a look at this in the future, but maybe it would be a good idea to take a look at thick polylines/thick polygons/thick triangles when all three are supported. For example, I'm working on thick stroked triangles at the moment and there might be some common code/logic we can introduce with a wider picture.

Sounds good to me.


Enable installation using npm

Could be from repo (if npm supports that) or from registry

Done in #469 and documented in #470


Basic setup steps for contributing

There was no instructions on how to get set up and running tests.
(e.g. I found a bug in tensorflow and just want to fix it)

Edit: TODO:

[ ] Setup instructions for non-MacOS users
[ ] System tests for setup instructions?
[ ] bin/setup?
[ ] bin/test? Would test all targets by default?

Can one of the admins verify this patch?

@wolffg feel free to chime in.
That'll work for Mac, but we have other instructions for other OS. Maybe it's best to point to the general source building instructions.

@wolffg ping?

I started working on a draft https://github.com/Dorian/doma/blob/master/_drafts/2017-04-16-contributing-to-tensorflow.md
But ultimately a bin/setup and bin/test would be my goal (even if not integrated in the main repo)

I'm going to setup an automated process with a MacOS virtual image to test my instruction steps, might take a bit more time than I thought but it's all good :)

Hi Dorian, it turns out as part of a huge documentation day on Friday, a change is in the works to provide a full contributions list, which apparently includes this as well.  So I'm going to close this for now, and perhaps you can add to that one when it gets pushed (hopefully tomorrow?)

https://github.com/tensorflow/tensorflow/pull/9604/commits/a8cf54a732d2385fa7b97495c73a91e4515e8d60 is the pending file.

@vrv Nice! Thanks!
I also found a hacky way to get things working quickly:
> docker run -it tensorflow/magenta
> cd /tensorflow/tensorflow
> python examples/learn/iris.py
> bazel test python


Add favicon

Resolves #58. Not sure how to test if this works without merging with master.
Sources:

documentation
issue

It workes locally:


Wrapped React component not working after upgrading to 0.1.29

Describe the bug
I'm using react-confetti on my website. After upgrading from 0.1.28 to 0.1.29 I get an error when the confetti is supposed to drop
To Reproduce
Here are the relevant code snippets:
pcconfig.py
import pynecone as pc

config = pc.Config(
    app_name="my_website",
    db_url="sqlite:///pynecone.db",
    env=pc.Env.DEV,
    frontend_packages=[
        "react-confetti",
    ],
)

confetti.py
import pynecone as pc

class Confetti(pc.Component):
    """Confetti component."""

    library = "react-confetti"
    tag = "ReactConfetti"
    width: pc.Var[int]
    height: pc.Var[int]
    recycle: pc.Var[bool]

confetti = Confetti.create

Here is a snippit of me calling the component on the page.
pc.cond(
    GptState.received,
    pc.cond(
        GptState.confetti_dropped == False,
        confetti(
            height=2160,
            width=3840,
            recycle=False,
        ),
    ),
),

Expected behavior
The confetti should drop without an error.
Screenshots

** Specifics (please complete the following information):**

Python Version: 3.11
Pynecone Version: 0.1.29
OS: Ubuntu 20.04

this should be added to the docs, but for react components with default imports, you need to add an is_default = True prop to the component:
import pynecone as pc

class Confetti(pc.Component):
    """Confetti component."""

    library = "react-confetti"
    tag = "ReactConfetti"
    is_default = True
    width: pc.Var[int]
    height: pc.Var[int]
    recycle: pc.Var[bool]

confetti = Confetti.create

That worked! Thank you so much!


What's left for eth-testing to be feature complete?

Open
I was researching the dApps E2E testing recently as my team was trying to add E2E testing (using Cypress) to make sure we are that any new changes don't break older ones.  After a little bit of research, I found that this area (dApps E2E testing) is a little bit immature and there is a lot to be done! Most of the current solutions are still in beta or deprecated for some reason.
I came across this eth-testing and found it trying to address this issue.
Yet (as with other solutions) I found this warning on top.

⚠ The package is quite young, any contributions, issues or feedbacks are welcome ⚠

I have a couple of questions regarding eth-testing.

Is it reliable to use with Cypress?
What is left for eth-testing to be feature complete? Feel free to share any road map.

Finally, I wound like to offer my help!! WDYT?

Hey @AhmedIbrahim336! Thanks a lot for this issue :)
Sooo about the questions

What is left for eth-testing to be feature complete? Feel free to share any road map.

I would say that the library is currently good enough to be used seriously. I am using it in my personal projects and also in my professional project (but only on the backend and I still did not have the occasion to use it on a big frontend project). Given the downloads, there are also a few people using it but they don't have that much remarks for now 😀
I don't have any road map but it would definitely be interesting that I work on that, I will try to spend time for that this weekend :)
Right now, the priorities are

support for Wallet Connect V2 with #64,
improving documentation, examples, guidelines (I would need to formalise that in a better way)

Thanks a ton for offering your help on this, it would be amazing! I'll think on how I can encourage you (and other people) to contribute!
And I will remove this warning message as I think it's time to remove it :)

Is it reliable to use with Cypress?

So I never used it with Cypress yet. I would be happy to know if it works 🤔. I think it would be worth to check if you could inject a generated mock provider as a fake MetaMask in the browser window managed by Cypress :). If it can be done, then it should be good to go!
I just want to insist on a point. This library can maybe (and I hope) be used for tools such as Cypress or other E2E testing, however, it is not its primary target.
As we are still talking about a mock (i.e. you don't interact with a real blockchain), its primary target is more unitary and integration tests.
Testing in Ethereum applications is a big topic because it becomes complex to write good tests right very quickly. This library is meant to mock the connection to an Ethereum node so it finds its meaning naturally in unit or integration tests. It would be the equivalent to msw or nock in more traditional software :)
About E2E in Ethereum application
This is a topic that I always wanted to explore and clarify but I still did not have the occasion to do unfortunately. I know there are some interesting investigations in the space with synpress for example!
Regarding this library, as I said, if you are using it for E2E, then you are not doing "real" E2E as you are mocking the blockchain interaction part of the system. However, it is already great if you have all the other components of the system as real and the only remaining mocked part is the blockchain 😁.
I believe full E2E in Ethereum app could be done with

blockchain network: either some test networks (Goerli, Mumbai, else) or either a fork network using Ganache or Anvil,
wallet: MetaMask using Synpress (I never tested yet 🙈) or a burner wallet 🤔

Sorry all of this is a bit confusing and I hope you find the answers you are looking for in all of this 😅
Does that answer your questions?
I'll keep you updated on the road map though :)

Thank you so much for your detailed answer 👐

This is a topic that I always wanted to explore and clarify but I still did not have the occasion to do it, unfortunately. I know there are some interesting investigations in the space with synpress for example!

I did try Synpress but it didn't work for me for some reason. However, I will give it another chance.

So I never used it with Cypress yet.

Yup, it works 🎉  🎉  I did today a proof of concept example in which I mocked the connected wallets and the wallet balance and the chain!!
I will try to open a PR with a Cypress example! WDYT?
Thanks again!
To close this issue I will open this PR to remove this warning message!

It would be amazing to have some Cypress example, I hope it will work without too much struggle!
Thanks a lot for spending time on this :)


Overpass management

Problem
Currently, we use the first user attempt to view a campaign as a signal to download data from overpass. Downloading data can take a lot of time causing a bad user experience. We should always serve cached data to the user and update the cache in the background.
Proposed Solution
Set up a cron that cycles through projects and service the overpass requirements.

UPDATED Proposed Solution
Rather than having a cron (adding another moving part to the system). We have the last data show, with a date and a note that it is being updated.

@cchristelis Couple thoughts here:

Using only Overpass for monitoring will get us too much data and doesn't have all the changeset information we need to flag certain items - like type of editor used - to be able to filter out the data that we're tracking.

Should we look to slightly change the main data source? Instead of Overpass and working around it's limitations, we look to leverage the work from Mapbox around their OSMCHA tool. There is new work from them to expose a full API.

Look to run out own osmcha infrastructure so we can customize the types of features we want to flag. Instead of suspicious changesets, it's based on the insight functions that are part of the campaign.

@smit1678, let's use both of them in parallel.

@smit1678 @cchristelis
Osmcha feature already added as new insight function.
https://github.com/hotosm/field-campaigner/pull/104

@meomancer @cchristelis Is the OSMCHA just an insight function? From our previous chats, OSMCHA was being seen as a data source and not just a insight function. If we look at it as a data source, we can rely less on Overpass for evaluating errors or evaluating completeness.

hi @smit1678
yes, i miss it, thank you
will update it

new ticket for OSMCHA/Overpass management
https://github.com/hotosm/field-campaigner/issues/170


The operator merges trustedCAs certificates with ones shipped in the image (main)

Description
The operator should merge trustedCAs with the default certificates. It's more convenient approach for users as they can provide just an extra certificate and don't have to worry about for example DT server certificates.
How can this be tested?

e2e istio tests
deploy CN dynakube with any certificate using trustedCAs. The operator should be able to connect to the DT server because knows well-know RootCAs shipped with the OS

Codecov Report
Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.75%. Comparing base (3e41510) to head (c725aba).

Files
Patch %
Lines

pkg/clients/dynatrace/client.go
25.00%
2 Missing and 1 partial :warning:

pkg/oci/registry/client.go
0.00%
3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3271      +/-   ##
==========================================
- Coverage   58.77%   58.75%   -0.02%
==========================================
  Files         325      325
  Lines       18153    18158       +5
==========================================
  Hits        10669    10669
- Misses       6285     6289       +4
- Partials     1199     1200       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Please update PR name to conform to our style guide!


Escape/transform U+001B when it appears in the Windows console

Currently, if a console cell contains U+001B, winpty copies it through to the terminal.  This behavior wasn't ever intentional, and now that I've noticed it, I think it should be changed, probably by replacing U+001B with another character like a space, a question mark, or perhaps U+FFFD (�).  winpty generally tries to keep the terminal looking like the console, and the console does not interpret escape sequences.
This behavior is arguably a feature.  For example, this currently works, assuming default colors and a wide enough mintty terminal:
$ WINPTY_SHOW_CONSOLE=1 console c:/Python27/python
Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> print "\x1b[9mCROSSED\x1b[0m"
CROSSED
>>>

In mintty, the text is struck through, like CROSSED.
In the winpty's underlying console, this is what appears:
Python 2.7.10 (default, May 23 2015, 09:40:32) [MSC v.1500 32 bit (Intel)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> print "\x1b[9mCROSSED\x1b[0m"
�[9mCROSSED�[0m
>>>

The ability breaks easily, though.  If the escape sequence wraps around a line, winpty will typically insert its own control sequences (or at least CR and LF) into the console's escape sequence.  The ability also interferes with winpty's color handling and cursor positioning.
If a Windows console program's escape sequences are interpreted, they should be interpreted without writing them to the console screen buffer.

See also: https://github.com/rprichard/winpty/issues/43 and https://youtrack.jetbrains.com/issue/IDEA-155071

I noticed today a few instances where '\x1b' seemed to be translated to something other than '?'.

On Windows 7, in a console, run the Utf16Echo test program as Utf16Echo 1B.  With CP437, it produces U+2190 (LEFTWARDS ARROW).  With CP1252, it instead produces U+001B, and with CP65001, it produces U+0000.  The same behavior can be observed running Python 2.7 in a Cygwin mintty terminal via winpty:
$ winpty -Xallow-non-tty cmd /c chcp 1252 '&&' c:/python27/python -c 'print "7\x1b8"' | hexdump -C
00000000  1b 5b 30 6d 41 63 74 69  76 65 20 63 6f 64 65 20  |.[0mActive code |
00000010  70 61 67 65 3a 20 31 32  35 32 1b 5b 30 4b 1b 5b  |page: 1252.[0K.[|
00000020  3f 32 35 6c 0d 0a 1b 5b  30 4b 1b 5b 3f 32 35 68  |?25l...[0K.[?25h|
00000030  37 3f 38 1b 5b 30 4b 1b  5b 3f 32 35 6c 0d 0a 1b  |7?8.[0K.[?25l...|
00000040  5b 30 4b 1b 5b 3f 32 35  68                       |[0K.[?25h|
00000049

It looks like PHP 7.1.3 changes the code page to 65001 when it runs.  (PHP restores the original code page on exit, but not if you kill it with Ctrl-C.  Suppose you run php with no arguments, then realize there's no PHP REPL...)
winpty -Xallow-non-tty c:/php-7.1.3/php.exe -r 'print "7\x1b8";' | hexdump -C
00000000  1b 5b 30 6d 1b 5b 30 4b  37 00 38 1b 5b 30 4b     |.[0m.[0K7.8.[0K|
0000000f

In VSCode, the NUL character occupies 0 columns.
It might make sense to also translate U+0000 to '?'.  (or maybe space?)
IIRC, I didn't originally translate U+001B to U+2190, because the left arrow codepoint's width is ambiguous, and it might have displayed as 2 columns in some CJK fonts on Windows.


Keras Tensorboard callback fails with tf.eager

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Custom code
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
TensorFlow installed from (source or binary): Via pip
TensorFlow version (use command below): 1.9.0-rc1
Python version:  3.6.5
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: 9.0/7.0
GPU model and memory: GTX 1080Ti/11GB
Exact command to reproduce: Code given below

Describe the problem
I'm using tf.eager, Keras model subclassing and tf.Dataset on TF 1.9.0-rc1. When I try to add the Tensorboard callback to the Keras .fit method I get the following error:
  File "/home/ekami/workspace/src/main.py", line 112, in <module>
    main(args)
  File "/home/ekami/workspace/src/main.py", line 63, in main
    validation_steps=3)
  File "/home/ekami/workspace/src/models/base_model.py", line 75, in fit
    sample_weight, initial_epoch, steps_per_epoch, validation_steps, **kwargs)
  File "/home/ekami/Programs/anaconda3/envs/dl/lib/python3.6/site-packages/tensorflow/python/keras/engine/training.py", line 1328, in fit
    validation_steps=validation_steps)
  File "/home/ekami/Programs/anaconda3/envs/dl/lib/python3.6/site-packages/tensorflow/python/keras/engine/training_eager.py", line 979, in fit_loop
    callbacks.set_model(callback_model)
  File "/home/ekami/Programs/anaconda3/envs/dl/lib/python3.6/site-packages/tensorflow/python/keras/callbacks.py", line 70, in set_model
    callback.set_model(model)
  File "/home/ekami/Programs/anaconda3/envs/dl/lib/python3.6/site-packages/tensorflow/python/keras/callbacks.py", line 763, in set_model
    self.merged = tf_summary.merge_all()
  File "/home/ekami/Programs/anaconda3/envs/dl/lib/python3.6/site-packages/tensorflow/python/summary/summary.py", line 311, in merge_all
    'Merging tf.summary.* ops is not compatible with eager execution. '
RuntimeError: Merging tf.summary.* ops is not compatible with eager execution. Use tf.contrib.summary instead.

Here is a pseudo code to reproduce the error:
train_ds, train_slides, val_ds, val_slides, lookup_table = Dataset(logger, input_dir, output_dir, crop_size,
                                           cache_slide_size=cache_slide_size).get_dataset() # Returns a tf.Dataset object

patches_len = len(train_slides[0].patches)
model = SimpleCNNModel(num_classes=len(lookup_table))
model.compile(optimizer=tf.train.AdamOptimizer(),
                          loss='categorical_crossentropy',
                          metrics=['accuracy'])
model.fit(train_ds, epochs=args.epochs,
                callbacks=[tf.keras.callbacks.TensorBoard()],  # Will fail with the above error
                batch_size=batch_size,
                steps_per_epoch=patches_len // batch_size,
                shuffle=True,
                validation_data=val_ds,
                validation_steps=3)
model.save_weights(weights_pth)
logger.info("Done training!")

Source code / logs
Given above

Assigning to @anj-s as she has a fix ready.

The code provided should now work

Perfect, thank you :)

The code provided should now work

so should we just update ?

@malikaltakrori yep

Thanks for the reply @omalleyt12 .
Note that I am working on Windows, not Linux.
I did. Using Tensorflow version 1.10.0 and my callback is:
callbacks = [         # Write TensorBoard logs to ./logs` directory
tf.keras.callbacks.TensorBoard(),
# tf.keras.callbacks.ModelCheckpoint("./checkpoints", monitor='val_loss', verbose=1, save_best_only=True,
#                                 save_weights_only=False, mode='auto', period=1)
hist
]

history = model.fit([X_train_seqs, masked_X_train_seqs], y=tf.keras.utils.to_categorical(YDocLevel_train, 13),
          validation_data=([X_valid_seqs, masked_X_valid_seqs], tf.keras.utils.to_categorical(YDocLevel_valid, 13)),
          batch_size=16, epochs=100, shuffle=True, callbacks= callbacks)`

still got the same error:
File "D:\Anaconda2\envs\tensorflow\lib\site-packages\tensorflow\python\keras\callbacks.py", line 71, in set_model
callback.set_model(model)
File "D:\Anaconda2\envs\tensorflow\lib\site-packages\tensorflow\python\keras\callbacks.py", line 782, in set_model
self.merged = tf_summary.merge_all()
File "D:\Anaconda2\envs\tensorflow\lib\site-packages\tensorflow\python\summary\summary.py", line 311, in merge_all
'Merging tf.summary.* ops is not compatible with eager execution. '
RuntimeError: Merging tf.summary.* ops is not compatible with eager execution. Use tf.contrib.summary instead.

@malikaltakrori 1.10 is too early, please try 1.11 or nightly

I confirm it's now working on TF >= 1.11.0

I see.
Maybe there is something going on with my installation. I did I try to upgrade (with pip install --upgrade tensorflow)  I get:
Requirement already up-to-date: tensorflow in d:\anaconda2\envs\tensorflow\lib\site-packages (1.11.0rc2)
When I print tf.version I get 1.10
and when I print tf.file i get the correct location:
D:\Anaconda2\envs\tensorflow\lib\site-packages\tensorflow\__init__.py

Recently updated to TensorFlow version:  2.0.0-beta1
I now get ValueError: Session keyword arguments are not support during eager execution. You passed: {'callbacks': [<tensorflow.python.keras.callbacks.TensorBoard object at 0x1a473117f0>]}

I'm also experiencing this with TF 2.0.0-beta1
ValueError: Session keyword arguments are not support during eager execution. You passed: {'callbacks': [<tensorflow.python.keras.callbacks.EarlyStopping object at 0x00000000498CB940>, <tensorflow.python.keras.callbacks.EarlyStopping object at 0x00000000498CB9E8>]}

@MonsieurWave could you share a code snippet to repro?

Make sure that the callbacks argument is inside the fit call, and not inside the compile.


handle failure in dse shell-out methods

This adds the handling added in #510 to DSE methods.
It's not clear to me how the C* counterparts in node.py are tested. What should I do to test these changes? They work locally for me.
This is a breaking API change.

Oh, side note: the handle_external_tool_process requires an argument list in addition to the process being handled, because Popen objects don't persist this data until the addition of Popen.args in Python 3.3.
One way to slightly improve this function would be to use a custom Popen subclass as suggested in this StackOverflow answer. I'd be happy to throw this together for this PR.

Just fixed this -- Popen objects weren't redirecting output; this fixes that.

One way to slightly improve this function would be to use a custom Popen subclass as suggested in this StackOverflow answer. I'd be happy to throw this together for this PR.

This seems unnecessary? Unless it's more than just ugly that we're passing in the list of args as well

This seems unnecessary? Unless it's more than just ugly that we're passing in the list of args as well

Nope, just an unnecessarily ugly API. For now, there's nothing it prevents us from doing.


Pin numpy<2 as required by tensorflow to fix doc building

Pin numpy<2 as required by tensorflow to fix doc building.
Fix #630.

Now, "Build PR Documentation" is working: https://github.com/huggingface/evaluate/actions/runs/10827111656/job/30039545261?pr=631


xinference-client rerank has some bug

System Info / 系統信息
Running rerank demo code error

Running Xinference with Docker? / 是否使用 Docker 运行 Xinfernece？

[X] docker / docker
[ ] pip install / 通过 pip install 安装
[ ] installation from source / 从源码安装

Version info / 版本信息
v0.16.3
The command used to start Xinference / 用以启动 xinference 的命令
docker start
Reproduction / 复现过程
I checked the source code and found that there may be an issue with this section of code

Expected behavior / 期待表现
I commented out a piece of code, it's correct

Which version of xinference-client do you have?

v0.16.3
---- Replied Message ----
| From | Xuye @.> |
| Date | 11/24/2024 00:54 |
| To | @.> |
| Cc |<EMAIL_ADDRESS>|
| Subject | Re: [xorbitsai/inference] xinference-client rerank has some bug (Issue #2574) |
Which version of xinference-client do you have?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

你可以看源代码
---- Replied Message ----
| From | Xuye @.> |
| Date | 11/24/2024 00:54 |
| To | @.> |
| Cc |<EMAIL_ADDRESS>|
| Subject | Re: [xorbitsai/inference] xinference-client rerank has some bug (Issue #2574) |
Which version of xinference-client do you have?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Unhandled Exception: CameraException(error, CaptureRequest contains unconfigured Input/Output Surface!)

Unhandled Exception: CameraException(error, CaptureRequest contains unconfigured Input/Output Surface!)
got this error when "cameraController.takePicture(path)"

using camera plugin

@mohamed3051215
Please provide flutter doctor -v and a complete minimal reproducible code sample along with camera plugin version.
Thanks.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


pdf viewer

viewing pdfs in sources versus filter sources
If I click on a pdf for a citation using "sources", the pdf is automatically downloaded (no option to put in viewer).
If I click on a pdf for a citation using "filter sources", the pdf goes to the viewer (with the option for a download).
Sources should be doing the same thing as filter sources (pdf to viewer then option for download)

@JohnHeraty can you screenshot and highlight the two link locations?  Are they the same icon?

No - not the same

On Sep 1, 2020, at 11:14 AM, Matt<EMAIL_ADDRESS>wrote:
@JohnHeraty https://github.com/JohnHeraty can you screenshot and highlight the two link locations? Are they the same icon?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/SpeciesFileGroup/taxonworks/issues/1693#issuecomment-685045352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHF2MJFLIW5RHTATMYCXEJTSDU2XNANCNFSM4QR5XZOQ.

The icon there is the "download pdf", we can change it or just add the other one to open it.
Just to clarify, this is on Data -> Source

Add another.


Add Angles to Bower

I would like to suggest adding Angles to Bower (http://bower.io/) for easier install/management.

:+1:
Great wrapper!


Add option for Architect Linux

https://plus.google.com/communities/109428906975670306458
http://architectlinux.boardhost.com/
http://sourceforge.net/projects/architect-linux/
It's a minimal Arch setup that follows "the Arch way"... but actually walks you through it instead of having to follow the Wiki.

https://github.com/antonym/netboot.xyz/pull/64


Please list test dependencies explicitly

The most recent release, 1.1.7, introduced xarray as a dependency for running tests (3997b82). Yet, nowhere is that dependency mentioned, except in ci/environment.yml, which is not an obvious place. Nor is xarray a dependency of one of the packages dask-expr depends on.
Having test dependencies listed in either a requirements file or in a dedicated extra in pyproject.toml, allows our tooling to take care of it instead of manually having to intervene whenever dependencies change.
Alternatively, make tests depending on extra modules soft fail if the module is not available.

Alternatively, make tests depending on extra modules soft fail if the module is not available.

This is how we're typically doing this in other dask libraries. Are you interested in contributing a patch?


A way to copy the block clipboard to the system/mouse copy/paste buffer would be extremely useful

It would be handy to be able to paste copies of multiple blocks into other applications, like editor buffers, Notion outlines, and other websites! Copying the contents of the block clipboard to an external format (for pasting into other applications) would provide a kind of way to export the contents for preservation, and the opportunity to re-import the contents in the future. (This would be even more useful if you could select all the blocks on a page, and all the blocks on a collection of pages, for copying and exporting.)
This would involve:

A knob associated with the blocks clipboard – maybe an option in a right click menu?
Externalization of the contents for pasting into other applications, like browsers apparently do for rendered HTML.
Recognition of the exported format and automatic internalization for when it is pasted into an fresh block.

By making the externalization format like what browsers do for mouse-copied HTML, you could leverage the provisions that I've heard are already available for pasting HTML content to Volto. (Because of that provision I expect that much of this functionality is already present.)

This would further extend Volto's external interoperability.

@kenmanheimer This add-on may help you with that https://github.com/eea/volto-spotlight
Ping to @razvanMiu to fix the README of that add-on 😄


Support viewing previously failed pod logs

What would you like to be added:
The ability to view the previously failed pods logs like you would with kubectl logs --previous
Why is this needed:
It's useful to see the logs of a crashed pod and it's the only way to retrieve logs from a pod that's in a CrashLoopBackOff

Related: #430


Refactor TLA support

Closes https://github.com/quickjs-ng/quickjs/issues/339
392bbff5470bc9a9fad81aa685c931353272752e essentially reverts https://github.com/quickjs-ng/quickjs/pull/6 and the next commits apply progressively the commits mentioned in https://github.com/quickjs-ng/quickjs/issues/339.

Thank you for doing this! ❤

I think not but I'll take a closer look. Thanks again!

The only 2 missing ones are:
https://github.com/bellard/quickjs/commit/e44b793e3817766d9045ed2a776658fcbe0f2790
https://github.com/bellard/quickjs/commit/00967aac2408af0d3e591918b25e700229c9cdb3
I think we should at least include https://github.com/bellard/quickjs/commit/00967aac2408af0d3e591918b25e700229c9cdb3 here and the bits in https://github.com/bellard/quickjs/commit/e44b793e3817766d9045ed2a776658fcbe0f2790 that add the new eval flag. The REPL changes can be a subsequent PR.

Just added os.sleepAsync, the other changes in those two commits were already there (except the REPL changes).

LGTM. @chqrlie can you PTAL too?

Looking at this... Takes some time to ensure no unseen regressions, should be done soon.

Alright, I rebased this and added the missing REPL bits. @chqrlie PTAL!
Something I noticed is the difference in return values now:
qjs > os.readdir('.')
{
  value: [
    [
      '.',                   '..',                  'libregexp.c',
      'v8.sh',               'repl.js',             'test262.conf',
      'getopt_compat.h',     'quickjs.c',           'CMakeLists.txt',
      'LICENSE',             'run-test262.c',       'Makefile',
      'v8.txt',              'libunicode-table.h',  'qjs.c',
      'quickjs-c-atomics.h', 'libunicode.c',        'tests',
      'libbf.h',             'dirent_compat.h',     'cutils.c',
      'quickjs-libc.c',      'qjsc.c',              'gen',
      '.gitmodules',         'v8-tweak.js',         'README.md',
      'libregexp-opcode.h',  'list.h',              'a.out',
      '.gitignore',          'quickjs-opcode.h',    'libregexp.h',
      'examples',            't.js',                '.github',
      'quickjs-atom.h',      'doc',                 'quickjs.h',
      'unicode_gen_def.h',   'libunicode.h',        'v8.js',
      'test262_errors.txt',  'test262-fast.conf',   'build',
      'test262',             '.git',                'quickjs-libc.h',
      't.c',                 'unicode_download.sh', 'cutils.h',
      'unicode_gen.c',       'libbf.c'
    ],
    0
  ]
}
qjs >

vs before:
qjs > os.readdir('.')
[
  [
    '.',                   '..',                  'libregexp.c',
    'v8.sh',               'repl.js',             'test262.conf',
    'getopt_compat.h',     'quickjs.c',           'CMakeLists.txt',
    'LICENSE',             'run-test262.c',       'Makefile',
    'v8.txt',              'libunicode-table.h',  'qjs.c',
    'quickjs-c-atomics.h', 'libunicode.c',        'tests',
    'libbf.h',             'dirent_compat.h',     'cutils.c',
    'quickjs-libc.c',      'qjsc.c',              'gen',
    '.gitmodules',         'v8-tweak.js',         'README.md',
    'libregexp-opcode.h',  'list.h',              'a.out',
    '.gitignore',          'quickjs-opcode.h',    'libregexp.h',
    'examples',            't.js',                '.github',
    'quickjs-atom.h',      'doc',                 'quickjs.h',
    'unicode_gen_def.h',   'libunicode.h',        'v8.js',
    'test262_errors.txt',  'test262-fast.conf',   'build',
    'test262',             '.git',                'quickjs-libc.h',
    't.c',                 'unicode_download.sh', 'cutils.h',
    'unicode_gen.c',       'libbf.c'
  ],
  0
]
qjs >

Upstream is correct so it seems something is amiss here.

Simpler case:
qjs > var x;
{ value: undefined }

Ah https://github.com/bellard/quickjs/commit/00967aac2408af0d3e591918b25e700229c9cdb3

Alright, this is now ready to do AFAICT! @chqrlie can you PTAL? I'd like to cut a release after this goes in.

Alright, this is now ready to do AFAICT! @chqrlie can you PTAL? I'd like to cut a release after this goes in.

Very busy at the moment, will try to review by Friday night.

Gentle ping @chqrlie :-)

So, our implementation matches upstream now, 262 passes and I also tested with txiki.js: https://github.com/saghul/txiki.js/pull/540
I'm going to merge this and if we need to make tweaks to it we can dot hat as we do any other bugfix.

So, our implementation matches upstream now, 262 passes and I also tested with txiki.js: saghul/txiki.js#540
I'm going to merge this and if we need to make tweaks to it we can dot hat as we do any other bugfix.

OK for me, I was about to write the same thing :)


push image to docker hub

@carbonin can you push the image to docker hub so I can build upon it?

It's already there (https://hub.docker.com/r/manageiq/ruby/), still working on getting badges and such.
Also, I'll have a PR soon to make this image the base of the miq-app container from the miq-pods repo.


Default value for "required" param in @RequestMapping annotation

The guide at https://spring.io/guides/gs/rest-service/ and the docs (http://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/web/bind/annotation/RequestParam.html#required--) say that the "required" param in the org.springframework.web.bind.annotation.RequestMapping annotation has a default value of false.
In spite of that, when I run a project without specifying a value it defaults to true.
In netbeans, when I checked the downloaded sources from Maven, the default is set to true.
There seems to be a contradiction there.

The javadoc says "true" is the default for the required attribute of @RequestParam. But I'm not sure I know what you mean because you said "RequestMapping" and then linked to "RequestParam". The guide text is wrong, though, so we should fix that.

I meant RequestParam, sorry about that, and I read the javadoc wrong, . But the guide text as you say is incorrect.
On Sep 20, 2016 4:07 PM, Dave Syer<EMAIL_ADDRESS>wrote:The javadoc says "true" is the default for the required attribute of @RequestParam. But I'm not sure I know what you mean because you said "RequestMapping" and then linked to "RequestParam". The guide text is wrong, though, so we should fix that.
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

Fixed in spring-guides/gs-rest-service@c29a1de. Please raise issues with individual guides if you find any more.


rebar bootstrap fail

rebar -V: rebar 2.6.0 18 20150906_075813 git 2.6.0-24-g2941760
Erlang/OTP 18 [erts-7.0] [source] [64-bit]

how to fix?

This has been fixed on 2015-09-11 in commit e025430da864374c16a9c59f0c33fd8438213294 and has been part of a couple releases since.

Like I said, this has been resolved a long time ago in an older release. Therefore, this ticket can be closed as RESOLVED-FIXED.


Build Finschia layer-1 binary

Description
This PR adds Rollup, DA, and Settlement modules to the hub_for_ramus branch to build the L1 version of finschia blockchain.
Note that it is intended for PoC purposes. IBC and WASM functionality has been removed for avoid modification affecting many repositories.
How has this been tested?
pass make test

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Issues retrieving value

I have 2 String properties that I'm using your property wrapper for to store in the keychain. It does seem to store them just fine but when I retrieve them I seem to sometimes get back the wrong value. It happens in particular after quitting the app and restarting where I will get the same value for both properties.
Are each of my properties supposed to be keyed uniquely and how are the keys generated. I couldn't figure out how that is implemented skimming through your code.

Follow up:
Is the service supposed to be my key instead of the bundle identifier? Once I changed the service to be a unique value for each of my properties the issue seems to not occur anymore. Does this property wrapper access the keychain of the app defined by the bundle identifier by default?

@fahlout it seems it doesn't work properly. I store a value and I'm able to retrieve it. But it disappears on app restart

If this happens again, please share example code that triggers this and I'm happy to help. In our apps so far it's working fine.


drawing: 1.0.1 -> 1.0.2

https://github.com/maoschanz/drawing/compare/1.0.1...1.0.2
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

LGTM

Result of nixpkgs-review pr 223209 run on x86_64-linux 1

1 package built:

drawing


Feature/ci fourmolu check

Description
Add your description here, if it fixes a particular issue please provide a link to the issue.
Checklist

[ ] Commit sequence broadly makes sense
[ ] Commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] Any changes are noted in the changelog
[ ] Code is formatted with fourmolu on version <IP_ADDRESS> (which can be run with scripts/fourmolize.sh)
[ ] Self-reviewed the diff

Migrations

[ ] The pr causes a breaking change of type a,b or c
[ ] If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
[ ] Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

Once this is done we'll probably want to delete this PR https://github.com/input-output-hk/cardano-db-sync/pull/1375


chore(newchart): update chart creation dataset selection help text, styles

SUMMARY

Update help text to be "Add a dataset or view instructions."
Make "Add a dataset" link to the dataset CRUD page in a new tab with the + Dataset modal open

Add support for a #create URL hash on the dataset CRUD page that opens the + Dataset modal at load

Make "view instructions" link to the documentation in a new tab, as before
Update font styles and spacing on page

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:

After:

TESTING INSTRUCTIONS

Visit /chart/add and open the "Choose a dataset" select.
Confirm that clicking "Add a dataset" opens /tablemodelview/list in a new tab with the "Add dataset" modal open.

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[x] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

@michael-s-molina Re: opening the + Dataset modal via URL: I tried changing the trigger from hash #create to query param (create=true), but the table on the page clears the query params and sets its own as soon as it renders and though I didn't dig into it too deeply, it seemed like adjusting that behavior to allow my create=true one to survive long enough to be read would be a challenge.  OK to leave it as a hash or want me to keep working on making it a query param?

Can we maybe make the "Add dataset" modal reusable and open the modal directly from the "Add a dataset" link here?
Also, it seems the current "Add a dataset" modal supports only adding a physical dataset. We should probably design a way for users to create virtual datasets here, too.

Unless there is immediate urgency in adding this feature right now, I'd say we should implement the optimal user experience in one go instead of shipping something we'd likely to change again very soon.

@ktmud After some digging it looks like bringing the addSlice page into the SPA is on the Preset roadmap for the near future, so if we hold off on bringing the modal in until that's done we won't have to reproduce its state and API dependencies.

@michael-s-molina Re: opening the + Dataset modal via URL: I tried changing the trigger from hash #create to query param (create=true), but the table on the page clears the query params and sets its own as soon as it renders and though I didn't dig into it too deeply, it seemed like adjusting that behavior to allow my create=true one to survive long enough to be read would be a challenge. OK to leave it as a hash or want me to keep working on making it a query param?

I think it's ok to use the hash if we consider the modal as a subordinate of the listing.

/testenv up


Refactor TabContent

Codecov Report

Merging #184 into master will decrease coverage by 1.04%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage      50%   48.95%   -1.05%
==========================================
  Files          20       21       +1
  Lines         278      288      +10
  Branches       54       56       +2
==========================================
+ Hits          139      141       +2
- Misses        105      111       +6
- Partials       34       36       +2

Impacted Files
Coverage Δ

src/js/components/Tab/Url.js
100% <ø> (ø)
:arrow_up:

src/js/components/Tab/Tab.js
15.68% <0%> (+0.59%)
:arrow_up:

src/js/components/Tab/TabContent.js
16.66% <16.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e51f8...9be9b60. Read the comment docs.

Coverage decreased (-1.09%) to 42.291% when pulling 9be9b60a70921c764bdee2d1d3dd8cca373b480d on tab into 03e51f8c96d1158ddb9906edc9f14a0a5d69a326 on master.

Fix #25


Can "gpt" be  be replaced with other model?

tokenizer = GPT2Tokenizer.from_pretrained('gpt2')

Yes, you can switch you model to Openai()/Ollama/HF model.