Many elements do not render correctly

Some image tags as well as the table are not rendered correctly.
Will these be fixed by updating the CCMark dependencies?

We're very happy to update CCMark if necessary. Can you provide an example markdown that shows the problem?

We're very happy to update CCMark if necessary. Can you provide an example markdown that shows the problem?

Hi,

Tables: from https://guides.github.com/features/mastering-markdown/

First Header
Second Header

Content from cell 1
Content from cell 2

Content in the first column
Content in the second column

First Header | Second Header
------------ | -------------
Content from cell 1 | Content from cell 2
Content in the first column | Content in the second column

Img: (general image tags work fine)

![Swift](https://img.shields.io/badge/Swift-5.1-orange.svg?style=flat)

checklist:
[x] More to find in the app!

- [x] More to find in the app!

I'm not sure which of these are generally supported by markdown, but it would be great to have them! 😃
Also, I found emoji's not correctly displayed in my markdown rendered page. I wonder if the <meta charset="UTF-8"> is handled by the render engine?
Really appreciated!

GitHub markdown is a superset of CommonMark.  See https://github.github.com/gfm/ for the specification - the items you've identified are GitHub specific extensions so we can't support them here.
The issue of emoji's not rendering correctly sounds like a different issue.  Are you outputting the emoji as Unicode codepoints, or using the :shortcode: syntax that GitHub supports?

GitHub markdown is a superset of CommonMark. See https://github.github.com/gfm/ for the specification - the items you've identified are GitHub specific extensions so we can't support them here.
The issue of emoji's not rendering correctly sounds like a different issue. Are you outputting the emoji as Unicode codepoints, or using the :shortcode: syntax that GitHub supports?

Thanks for your heads up! I overlooked the original specs for cmark.
Talking about emoji, I'm inserting Unicode characters directly. like this: 🤔 -> 🤔, rather than using shortcode  :thinking: -> 🤔 or codepoints  &#x1F914 ->
🤔
When I want to directly insert an emoji character, I have to specify the charset attribute in my markdown .md document.
While it's OK to add a few lines of HTML to .md file, it would be great if I can set that with template engine's attribute somehow.
Currently it looks like this without setting the charset.

And it looks like this with setting charset and stylesheet with HTML tags in the .md file.

Can you show me what you're having to put in the .md file to get the emoji to render properly?

Can you show me what you're having to put in the .md file to get the emoji to render properly?

I'm including an HTML attribute in the .md file to specify its charset.

    <meta charset="UTF-8">

Without this, it seems the page defaults to some other charset.

Hi, by default itura-Markdown doesn't generate complete HTML documents - it generates an HTML fragment.
For example, for this Markdown:
# Header

Description with **bold** text

* Book1
* Book2

it will generate this HTML fragment:

Header

Description with bold text

Book1

Book2

What you want is a complete HTML document with a DOCTYPE etc. so you can specify the UTF-8 character set.
There are two ways to do this.

Use render(from: String, pageTemplate: String) which allows you to pass in a pageTemplate which specifies where in the template the Markdown should be inserted.

Use MarkdownOptions to specify a page template.

Either of these are good options and should work.
We're going to update our Markdown guide on kitura.io to make this clearer.  Thanks for raising the bug and do reopen if you have any more questions.  Thanks.

Thanks for the clarification! It works!


feature: voting/polls

With polls, community decisions can be measured!
use cases could be:

where to spend funds on
what kind of actions to do in a situation (like guidelines)
...

simplified steps for brainstorming:

users can vote via their wallets (e.g. options like: Yes, No, Abstain (A); or other definable  #answers)
there has to be decided on a criteria how the votes count: by balance (that would mean that whales could easily swing a poll), ...
a vote will cost something so people can't spam, ...
the vote result after the poll must be saved. so everyone can review past decisions

This feature could start first with command line voting, and later a UI could be added (or via external scripting). And then it could be made more pretty, e.g. showing the result as a pie chart
(A) Abstain would be important to legitimate the poll. E.g. when a poll has not many voters by share, ... it could be questioned. E.g. people were in vacation, hospital and couldn't participate

Will be added to roadmap for discussion and inclusion. Issue closed.


backup_control: Streamline CLI arguments, use UError

Hello again,
this is my follow-up from #2467 (@miDeb). This PR adds:

an arguments module that contains ready-to-use clap::Args for the backup-related CLI options
A UCustomError-based BackupError enum
A more intuitive signature to determine_backup_mode/suffix, which now both take a clap::ArgMatches and parse the options from there themselves (using what's defined in the arguments module)
Updated tests (Which imo are much nicer to read)
A lot of new docs so hopefully people understand what I tried to accomplish

Waiting for your feedback!

Yeah, about that common error: Should all of these become common errors? And if so, could I create something like a UCommonError::BackupError::*, or should the error hierarchy remain flat as in UCommonError::BackupInvalidArgument?
And then there's some other thing that I find myself constantly working against. In the doctests and some tests inside backup_control I'd really like to work with "unwrap" on UError and variants for brevity, because it saves me from writing a lot of unnecessary error checking. However, rust doesn't let me do that, because UError doesn't implement the Debug trait:
Error:    --> src/uucore/src/lib/mods/backup_control.rs:484:54
    |
484 |         let result = determine_backup_mode(&matches).unwrap();
    |                                                      ^^^^^^ method not found in `std::result::Result<mods::backup_control::BackupMode, mods::error::UError>`
    |
   ::: src/uucore/src/lib/mods/error.rs:135:1
    |
135 | pub enum UError {
    | --------------- doesn't satisfy `mods::error::UError: std::fmt::Debug`
    |
    = note: the method `unwrap` exists but the following trait bounds were not satisfied:
            `mods::error::UError: std::fmt::Debug`

Is there a specific reason for why Debug isn't implemented on UError?

Should all of these become common errors?

Yes, but I'm not quite sure what that would look like. I'm actually starting to think that the distinction between common and custom is not as helpful as we initially thought. The whole thing could be simplified a lot if we remove the distinction.

Is there a specific reason for why Debug isn't implemented on UError?

No, that's an oversight, feel free to add a derive for it :)

Uhm... I can't reproduce that clippy warning on my local machine. Is this safe to ignore? I also didn't touch any ioctl! macros.

@tertsdiepraam Do you have any more thoughts on the current state?

I can't do a full review right now, but it looks good!

@tertsdiepraam do you know when you will be able to review it? thanks :)

Rebased onto current master.

The build CI job for "x86_64-unknown-linux-musl" seems to fail quite frequently with an error similar to this:
Error: test failed, to rerun pass '--test tests'
Caused by:
  process didn't exit successfully: `/target/x86_64-unknown-linux-musl/debug/deps/tests-49dfddd67dde5327` (signal: 11, SIGSEGV: invalid memory reference)
Error: The process '/usr/share/rust/.cargo/bin/cross' failed with exit code 101

Is this caused by my changes?

@sylvestre I'll review this tomorrow!

I'm actually starting to think that the distinction between common and custom is not as helpful as we initially thought. The whole thing could be simplified a lot if we remove the distinction.

This is now finished in #2562. Could you update this PR to fit the changes I made there?

Okay, back from my holidays. Do I understand correctly that #2562 in essence dropped the UCustomError entirely in favor of "just" UError?
I did apply the changes now and due to some other work that was merged in the meantime I can now finally ? the result of determine_backup_mode in install and ln. What a joy to look at... :)
For reasons I don't understand, some changes to join and csplit ended up being attributed to this MR....? I've never seen these changes.

Do I understand correctly that #2562 in essence dropped the UCustomError entirely in favor of "just" UError?

Yes, exactly!

Thanks for the feedback! It's in now.

Sorry, there's a merge conflict. Could you fix it?

Done!

Thanks!


Implement MNAIO post hook for saving VM images [pike]

In order to be able to re-use MNAIO VM images for other
projects to reduce test times when using the MNAIO build
we implement a change to the MNAIO tooling to use a file
backing store for the VM's, the post hook to prepare them
for uploading, and the component_metadata.yml file to
upload them to Cloud Files using the standard RE hook for
uploading file artifacts.
Issue: RE-1994
Issue: RE-1989

Adding the status-dont-merge label to prevent a merge until releases are complete.

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.


Assumes global sass

Maybe add a line in readme? People (like me) are dumb sometimes... just a thought. 😄

sass has been added as a dev-dependency...shouldn't need it globally.  Try again?

npm run build                                            scss-starter/git/master

><EMAIL_ADDRESS>build /Users/xenu/Code/Repos/scss-starter
> sass --style expanded ./styles/main.scss:./dist/main.css

Errno::ENOENT: No such file or directory @ rb_sysopen - ./dist/main.css
  Use --trace for backtrace.

after npm i (of course)

dist folder was missing, so it was blowing up.  Please re-pull and try again!

Please re-open if you are having issues sir.

You know I will!


Factor AXI-lite to manycore endpoint using basejump modules

This PR, again, tries to address issue #164:

The following are the skeleton for the new manycore link implemented using basejump_stl:

bsg_manycore_link_to_axil.v  (includes **bsg_manycore_link_to_axil_pkg.v**)
 \__ bsg_manycore_endpoint_to_fifos
  |    \__bsg_manycore_endpoint_standard
  |
  |__bsg_parallel_in_serial_out
  |__bsg_serial_in_parallel_out
  |__bsg_bladerunner_configuration   (includes **bsg_bladerunner_rom_pkg.vh**)
  |
  |__bsg_axil_to_fifos
       \__bsg_axil_txs
       |__bsg_axil_rxs

Note, only tested with  localparam num_endpoints_gp = 1 , please see the doc at the header of each files for more details.

Reomve the Xilinx version of manycore link.

Simulation passed with commit ID:
bsg_manycore: d5d06b2
basejump_stl: 6dbdf49

Regression passed on
bsg_qcl: 35d7461

assigning enum values is not discouraged -- we have seen some synthesis
tools (I think it was vivado) have issues if they are not assigned.
On Thu, Oct 24, 2019 at 10:16 PM Tommy Jung<EMAIL_ADDRESS>wrote:

@tommydcjung commented on this pull request.
In hardware/bsg_axil_rxs.v
https://github.com/bespoke-silicon-group/bsg_f1/pull/443#discussion_r338889089
:

// axil read state machine

// --------------------------------------------

typedef enum bit [1:0] {
E_RD_IDLE = 2'b0,
E_RD_ADDR = 2'd1,
E_RD_DATA = 2'd2
} rd_state_e;

rd_state_e rd_state_r, rd_state_n;

always_comb begin
rd_state_n = rd_state_r;
case (rd_state_r)

 E_RD_IDLE : begin

I think you have arready_o =1 in E_RD_IDLE state, and when arvalid_i=1,
you flop the address as you switch to the next state.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bespoke-silicon-group/bsg_f1/pull/443?email_source=notifications&email_token=AEFG5AC4VZ6XHGGGXACMAFDQQJ6JNA5CNFSM4JENH6N2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJGDZWI#pullrequestreview-306986201,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG5AEOYDWKZGJQVOGI7FTQQJ6JNANCNFSM4JENH6NQ
.

The suggestions are great! Thanks @drichmond~


Added possibility to use fabricator as a builder from another project.

Hi, I added this possibility for multiple reasons. I added it in such a way that it still works as expected, but it can also be used from another project. If then this is a npm module, it can be used as a frame for the actual toolkits.
All feedback is very welcome!

Hi, any comments would be welcome. I just want to know how you are looking at this possibility. I don't want yet another repo out there. Better to have one with the option of how to use it.

@dietergeerts totally on my radar. I like the idea, just need time to give it a good review.
Hopefully I can carve out some time later this week. Thanks for putting this together!

I don't know if you had the time to look at it, but maybe it's better to have this as a seperate project that is used to build a toolkit rather than start one from it? I created an npm module for it and will try to keep it in sync with the original fabricator (this project). That way, people will be able to choose how they would like to use fabricator. I hope this is ok?

Hey @dietergeerts, sorry just been cranking at work recently, so I haven't had a ton of time to look at stuff.
From the bits of this PR that I've read, I think you're right that it might be better as a separate project. I am fine with however you want to manage that. I'd still love to give feedback as your project progresses. :sunglasses:


How to send a array of integers?

Hi, im using flexdatalist to populate a list of ids in a rails project.
Rails understand when i send a array of ids like [1,2,3,4] but, the flexdatalist is sending aways ["1,2,3,4"].
There is any chance to change this?
This is my js code:
$('.flexdatalist').flexdatalist({         minLength: 1,         valueProperty: 'id',         selectionRequired: 1,         searchIn: 'name',         textProperty: 'name',         data: '/musics'     });
This is what i try to change when the form is submitted to change the sent value:
$('form').on('submit', function (e) {         var datalist = [];         var inputList = $('.flexdatalist');         $(inputList).each(function (index, input) {             $($(input).val().split(',')).each(function (index, data) {                 datalist.push(parseInt(data));             });             $(input).val(datalist);             datalist = [];         });     });
Thanks for this great project!

Hi,
I'll improve the int handling on next releases.
Thank you!
Sérgio


Inform users that the original Flutter Analyser Extension could be uninstalled.

Via documentation and nudges after installing the extension.

Issue closed by PR #119


Change Default Eventstore Version to 2

Coverage decreased (-0.5%) to 66.278% when pulling d53544f114e7236c2ea962b5d98d9bbbdb11314e on yycptt:eventstore-version into 539e88a2effb4909e488729ea6095abe2b637921 on uber:master.


Pass user email to wallet

Issue To Be Solved
fcl.logIn() does not take any input params, logged in users need to write email address again while connecting to wallet (example: connecting blocto wallet).
(Optional): Suggest A Solution
Something like<EMAIL_ADDRESS>would allow to pass user's email from session tokens providing a better UX
(Optional): Context
We are developing a PoAP app for pre-authorized users. Each user logs in using a special token and mints the PoAP during which they need to connect their blocto wallet. We are using fcl.logIn() api to do this but since it does not consume any input parameters, user's have to write their email once again during the wallet connection.

@vasu5235 I agree this would provide some nice UX, but a couple concerns as well which I think have been reasons for not going forward with this in the past:

Not all wallets use email. In fact, many users prefer not to use wallets that require email in web3
What if the email one is logged into with the dapp is different than the one used with the wallet
There is not guarantee if we implemented this that all wallets would do the work to support it (if they supported email), so there might be confusion from developers on why it's not working when it only works some of the time

Curious to hear from some of wallets in the community on this.

Thank you for your thoughts. I'm going to close this for now. If you can make a broader case for why this might be helpful feel free to re-open it. Generally providing a mechanism for sending arbitrary data to the wallet (like user data) will cause a "coupling" of dapps to wallets which we would like to avoid.


map issues

i don't know where else to contact about this so i guess i'll do it here.
because you cannot talk to npcs until you get enough lore buffs (which happens at around fungal wastes)  you cannot get maps from cornifer.  which i thought was "fine, i will get them later".
now i can talk to npcs, so i went and talked to all the tapes cornifer left behind in crossroads-greenpath-fungal wastes,  then i went back to iselda and not only does she not sell those maps she doesn't even sell a quill.
is it intentional to play this mod without a proper map or do we get all of these later?

Hey, neither actually. You should be able to buy the maps as soon as you unlocked the listening ability. Are you sure Cornifer has left the map spots? Also, what does Iselda sell in your game?

she only sold the compass and the map pins, for 0 geo. i cleared her and then she has the dialogue about me having bought everything she has. and this does not change even after i go talk to cornifer's tapes.

Are you sure Cornifer has left the map spots?
as mentioned he has left his tapes in these 3 areas and i interacted with all 3 after i got the listening ability. i then met him in howling cliffs and got his map there so my only issue is the first 3 areas.

Oh sorry. Yeah I found the issue, I forgot to add the maps to the shop. Will add that with the new patch. Although expect this patch to release in the new year. Until then, you'd need to use the debug mod to obtain them, sorry.


Revalidate API token

I have to revalidate my API token after I have entered it on the initial start up. I have been trying to show the document in the Sanity Studio as it's described here in the readme

The token is stored in the dataset as a document of the type mux.apiKey with the id secrets.mux. Having the ID be non-root ensures that only editors are able to see it.

I have also tried deleting the studio and setting it up fresh however the keys seem to be stored in cached somewhere and I cannot get that start up screen again. Any information here would be great.

Hey, I have the same issue, was there a solution for this. Seems to be cached somewhere, uninstalling the plugin and reinstalling doesn't fix

It seems to be cached in the dataset somehow, creating a new one resolved the issue

This plugin seems half baked. There is no info in the UI explaining the signed url opinion and if checked, you cannot revoke your choice. Then you'll have to try to remove all related code everywhere to try to reset, but then you'll get invalid credentials error. Creating a new dataset is not an option for me so no MUX it is.

I agree and I am sorry to read this, I do get your frustrations. I was rather lucky for this to happen to me on a small site.
I did the usual, deleted npm, and removed package-lock.j.son.
I then removed this plugin from sanity.config....then reinstalled it all.
To my dismay it is cached in the data set. So I created a new one.
Solution:

Create a new data set but keep project.
Renaimed it "production-2".
Replaced "production" with"production-2" in sanity.config, next.config and sanity.cli.js

It allowed me to reset.
Draw back is you need to then populate the new data set.

As I found out here, the trick is to run this CLI command: sanity documents delete secrets.mux
It deletes the stored mux data in the dataset and you'll be able to reconfigure the API.

Thank you both @Lehmons and @HumidBrains for the feedback and sorry for the wait and frustrating experience.
We're still considering ways of making this flow more robust, but we've made the following improvements:

Note on the signing key behavior in the documentation (at the time of writing, it'll come in an upcoming release)
Ability to configure the plugin's credentials at any time from the uploader/input

This allows you to swap the signing key and have the plugin re-generate the private key, which would fix the reported issues

And to clarify, the cached key is private. The _id: 'secrets.mux' document is private via Sanity's ID paths, so you're safe :)

I'm closing this issue, feel free to comment and tag me if there's something else I'm missing - thank you again 🙏


Errors in compiling the iOS Sample GuestMeetingJoin

After downloading the sample and configuring the bundle signing, i am getting the following error:
No such module 'SkypeForBusiness'

When i add the SDK binary manually, i am getting 2 errors
unexpected duplicate task: CodeSign /Users/***/Library/Developer/Xcode/DerivedData/SfBDemo-fbngidqyuucvffeblhlvvgrmrzph/Build/Products/Debug-iphoneos/SfBDemo.app/Frameworks/SkypeForBusiness.framework (in target 'SfBDemo')
Multiple commands produce '/Users/****/Library/Developer/Xcode/DerivedData/SfBDemo-fbngidqyuucvffeblhlvvgrmrzph/Build/Products/Debug-iphoneos/SfBDemo.app/Frameworks/SkypeForBusiness.framework/SkypeForBusiness':
1) Target 'SfBDemo' has copy command from '/Users/sabicmobility/Downloads/skype-ios-app-sdk-samples-master/GuestMeetingJoin/SkypeForBusiness.framework' to '/Users/****/Library/Developer/Xcode/DerivedData/SfBDemo-fbngidqyuucvffeblhlvvgrmrzph/Build/Products/Debug-iphoneos/SfBDemo.app/Frameworks/SkypeForBusiness.framework'
2) Target 'SfBDemo' has copy command from '/Users/sabicmobility/Downloads/skype-ios-app-sdk-samples-master/SkypeForBusiness.framework' to '/Users/****/Library/Developer/Xcode/DerivedData/SfBDemo-fbngidqyuucvffeblhlvvgrmrzph/Build/Products/Debug-iphoneos/SfBDemo.app/Frameworks/SkypeForBusiness.framework'

If i remove all binaries and run the app, i will get a white screen and the following error
dyld: Library not loaded: @rpath/SkypeForBusiness.framework/SkypeForBusiness
  Referenced from: /var/containers/Bundle/Application/B0537D28-A948-440A-BA03-A5B2BA471F5C/SfBDemo.app/SfBDemo
  Reason: image not found
(lldb)


add oracle time_grains

DATE_TRUNC is not valid for oracle, which is what it was using before since OracleEngineSpec extends from PostgresEngineSpec.

build failure is unrelated to this PR, merging

Thanks for merging!


Limit scanner

[ ] Add builder for limit scanner
[ ] Add additional test cases
[ ] Update README.md

My initial attempt to add limit scanner


support OTA

we'll need be able to load new versions of firmware onto the ESP32-S3. once we've got wifi working (see #16), add OTA capabilities.

this looks pretty complicated, with lots of partitioning and such. ideally we'll find a trustworthy library to handle this.

are we going to have the device pull OTA from the internet, or do we expect it to be sideloaded, or need we support both? pulling it over the internet will require PKI--at the very least, TLS and a cert store on the device. i think we have to support sideload given our "no cloud" guarantee. so let's handle that first. ideally we would have a random password per device, tied to the serial number, but that requires infrastructure as well...

yeah i think sideloading is the way to go, at least at first. we can optionally check to see if there's new firmware, and if we find it, let the user know. even that, though, would require PKI.

https://github.com/arduino-libraries/Arduino_ESP32_OTA explicitly claims esp32-s3 support

https://github.com/gb88/BLEOTA looks nice for using BLE ala nordic's DTU, but there's only one radio on esp32, so you can't use wifi and bluetooth at the same time. we'd probably want to switch to BLE update mode, and if we timeout, switch wifi back on. sounds pretty complex. let's keep looking...

we're now using CONFIG_PARTITION_TABLE_TWO_OTA via menuconfig, which ought generate the necessary partitions to support simple OTA.
https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-guides/partition-tables.html

we needed step up to flavor country aka CONFIG_PARTITION_TABLE_TWO_OTA_LARGE=y. i verify that we have two partitions of equal size, one (the boot default) called ota_0, and the other ota_1:
[schwarzgerat](0) $ for i in ota_0 ota_1 ; do /home/dank/src/esp-idf/components/partition_table/parttool.py --quiet --port /dev/ttyACM1 get_partition_info   --part_list --partition-name $i | tail -n 1 ; done
0x20000 0x1a9000
0x1d0000 0x1a9000
[schwarzgerat](0) $

size is 0x1a9000, and offsets are 0x20000 and 0x1d0000.

hrmmm according to the csv we ought have five partitions:
[schwarzgerat](0) $ cat /home/dank/src/esp-idf/components/partition_table/partitions_two_ota_large.csv
# Name,   Type, SubType, Offset,   Size, Flags
# Note: if you have increased the bootloader size, make sure to update the offsets to avoid overlap
nvs,      data, nvs,     ,        0x6000,
otadata,  data, ota,     ,        0x2000,
phy_init, data, phy,     ,        0x1000,
ota_0,    app,  ota_0,   ,        1700K,
ota_1,    app,  ota_1,   ,        1700K,
[schwarzgerat](0) $

hrrmmm, and indeed we do:
[schwarzgerat](0) $ for i in nvs otadata phy_init ota_0 ota_1 ; do /home/dank/src/esp-idf/components/partition_table/parttool.py --quiet --port /dev/ttyACM1 get_partition_info   --part_list --partition-name $i | tail -n1 ; done
0x9000 0x6000
0xf000 0x2000
0x11000 0x1000
0x20000 0x1a9000
0x1d0000 0x1a9000
[schwarzgerat](0) $

so it looks like we just need call esp_ota_begin() with the next OTA partition, call esp_ota_write() (possibly many times), call esp_ota_end() if that succeeds, then call esp_ota_set_boot_partition() and reboot.
this, however, only writes one partition. do we want to write both, so that one can fail and we still run the newer code?


Spa  server support

how to use history-api-fallback api to support spa?

That may be probably outside the scope of this project.


Fix the ignore-exports option

The ignore-exports option has been broken since #688, as mentioned in https://github.com/haskell/haddock/pull/766#issue-172505043. This PR fixes it.

Thanks, merged now. 😄


username and passwordSecretRef settings remain after executing the az containerapp registry set --identity command

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
In Azue CLI containerapp extension v0.3.6, I ran to change the authentication to ACR to a Managed ID using az containerapp registry set --identity command, but the username and passwordSecretRef settings are still remain.
Steps to reproduct

The following command was executed for existing ACA (deploy from ACR, authentication method is username/password).

az containerapp registry set \
  -n '<ACA Name>' \
  -g '<Resouce Group Name>' \
  --server '<ACR Server Name>' \
  --identity 'system'

Expected behavior [What you expected to happen.]
I think the execution result should be like this.
Updating existing registry.
[
  {
    "identity": "system",
    "server": "<ACR Server Name>",
  }
]

Actual behavior [What actually happened.]
Actually, the result is as follows.
Note : The result was the same for --identity '<user-assigned managed ID'
Updating existing registry.
[
  {
    "identity": "system",
    "passwordSecretRef": "<Password (Secret)>",
    "server": "<ACR Server Name>",
    "username": "<User Name>"
  }
]

Additional context

az version resuilts

{
  "azure-cli": "2.37.0",
  "azure-cli-core": "2.37.0",
  "azure-cli-telemetry": "1.0.6",
  "extensions": {
    "containerapp": "0.3.6",
    "ssh": "1.1.1"
  }
}

The fix for this will be released with the next version of the containerapp CLI extension

@anthonychu the fix for this has been released as well


Grade parser

Grade parser reads from the csv grade files created by UTD ACM and inserts the data into the Nebula MongoDB.

Also, if you can, make a Makefile for the scraper. I can also do this for you if you can't use linux.


Update to latest version?

Any chance this library is going to update to the latest version of Stylus? Current stable version is 0.49.3, but this gem is only running 0.42.2
I am aware that I can run rake update from within the gem directory to get the latest version, but that requires me to install nodejs and npm (which I don't otherwise need), and obviously I have to make changes to a gem file after installation.

hey @BattleBrisket I haven't been using this library, but if you'd like to update it I can give you admin access to the repo and gem

@railsjedi we'd love to adopt the project. We're trying to do the same for @lucasmazza's https://github.com/lucasmazza/ruby-stylus as well since that's no longer actively being maintained.

Just here to confirm that @cmtonkinson and I do in fact work together. We would operate them under the forgecrafted namespace.

Just updated to 0.49.3; just waiting on rubygems.org access to promulgate.


feat: Add logging for runtime errors

Pull Request Key Information
Reason for change
LDAR-Sim runtime error messages are not logged, making it difficult to debug issues that occur during runtime.
What was changed
This change adds logging for runtime errors to make it easier to identify and resolve issues.
Intended Purpose
Runtime errors will be logged to the error file.
Level of version change required
N/A
Testing Completed
Manually tested using parameters and inputs from simple test case1. An alteration was made to the virtual world: infrastructure parameters such that the sites file pointed to a file that did not exist so the simulation would encounter a FileNotFoundError. Manually verified the error was logged to the error log.
All unit tests pass:
unit_test_results.txt
All E2E tests pass:
V4_simple_non_repairable_emissions_2d531627e50dc78d9d44ef8e70224b36abc25722.log
V4-simple_repairable_emissions_2d531627e50dc78d9d44ef8e70224b36abc25722.log
Target Issue
N/A
Additional Information
N/A

Latest E2E test results:
V4_simple_non_repairable_emissions_70105047c0c05c1abdf5fb13221cf291cbeaca96.log
V4-simple_repairable_emissions_70105047c0c05c1abdf5fb13221cf291cbeaca96.log
Latest Unit testing results:
unit_test_results.txt


unexpected error in llama server update_slots - exiting main loop

[1704891429] sampled token: 29896: '1'
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 256
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 128
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 64
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 32
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 16
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 8
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 4
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 2
[1704891429] update_slots : failed to find free space in the KV cache, retrying with smaller n_batch = 1
[1704891429] update_slots : failed to decode the batch, n_batch = 1, ret = 1
[1704891429] unexpected error in llama server update_slots - exiting main loop
[1704891429]
llama server shutting down
ollama is still running , and not respond for chat api

This question involves the occurrence of probabilistic behavior when a large model's output keeps repeating.
and must restart the ollama process to fix

ollama version is 0.1.23; i get the same problem like you
keep trap in this, request hang and endless print logs like you post
unless i restart ollama service

The same issue is present in version 0.1.24.

I haven't been able to reproduce this in the current version. Are you still seeing it? What platform are you using?

I have already updated to a version higher than v0.1.25, and it seems that the issue no longer occurs after v0.1.25.
I am still using ollama on Linux(and MacOS), and it works really well!

This still happens on 1.3.0..


Add some concrete examples of how to use isample export

I'm in the process of trying out this export client. I'm struggling to figure out the format for the query parameter.  For example, I wanted a query to reproduce the default query on the iSamples central interface:
https://central.isample.xyz/isamples_central/ui/#/?searchFields=BOj12i8m44Ml8hDk8LONqgLw0X4tfSWqcKfWcfGu4OjuTwUjo_VV-yq763jYgE4KcScAZs5pHY4eeFV4JisOeikMt76w9tfcbgiVw8BXCKSoZQIDqqkPvgtiqPAe6Nou8MUrsuCnolZ-SsMgVG6l5Ph5whHhl-qF&sortFields=YwvMoabCIirHibBoJ4dDAybCoqmjKj9H0b8vAK31p1GWfomnfpGLo4aiJbQgZGK0
After I figured out how to use the plantuml-encoder and ran
var plantumlEncoder = require('plantuml-encoder')

encoded = "BOj12i8m44Ml8hDk8LONqgLw0X4tfSWqcKfWcfGu4OjuTwUjo_VV-yq763jYgE4KcScAZs5pHY4eeFV4JisOeikMt76w9tfcbgiVw8BXCKSoZQIDqqkPvgtiqPAe6Nou8MUrsuCnolZ-SsMgVG6l5Ph5whHhl-qF";
console.log(plantumlEncoder.decode(encoded))

to get
[{"label":"Collection Date","field":"producedBy_resultTimeRange","type":"date-range-facet","minValue":1800,"maxValue":2024,"value":[1800,2023]}]

I'm left with the question -- can I feed the encoded or decoded query to isamples?  (I know that I can just try it after writing this up....so let me do so....)
I got the following incantation to work:
isample export -j $ISAMPLES_JWT -f geoparquet -d /tmp -q 'source:SMITHSONIAN'

I'm going to close this issue, not revising the documentation is complete, but Re #15 -- update README.md to get rid of the mention of export_clien… by dannymandel · Pull Request #19 · isamplesorg/export_client to provide a basic example was accepted.


alt+s (ś) not working in edit spec mode

This seems to be an issue with Ace editor itself. We're using buggy 1.1.9 and they promise to fix it in 1.2.0. Let's keep this open to track the release and upgrade on our side.

I removed the ace editor from the current version of featurebook. Editing features is more complicated than just adding editor's div and highlighting Gherkin syntax. It should be implemented from scratch; probably as a plugin with VCS integration.


rancer web access error

Rancher versions:
rancher/server or rancher/rancher: rancher version latest
rancher/agent or rancher/rancher-agent: rancher version latest
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable):
Docker version: (docker version,docker info preferred)
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
Steps to Reproduce:
Results:
access rancer ui hapen error
error info :
%growl.webSocket.connecting.title%
%growl.webSocket.connecting.warning%

Duplicated of https://github.com/rancher/rancher/issues/11961


left-hand label runs off the page when axis scale needs lots of digits

Reported by ansley b manke on 17 Nov 2011 01:39 UTC
Kevin ran into this with a variable having large values. Reproduce the behavior with this plot.
yes? define axis/x=1:100:1 xax
yes? let/units="Observation value" var = 1.e37 * sin(randu(x[gx=xax])-1)
yes? plot var
Nice behavior might be to auto-scale the axis labels and then add information to the plot saying what that scale was.
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1896

Modified by ansley.b.manke on 17 Nov 2011 01:41 UTC

Comment by ansley.b.manke on 22 Nov 2011 23:23 UTC
Fixed this by just checking whether there is enough space to write the axis title, and making the numeric labels slightly smaller if needed. If the user has defined small margins, the labels will still be missing; but the fix will ensure that plots that use the default Ferret settings for margins and labels sizes will not run off the edges.
I decided that scaling the axis labels and adding a note to the axis title is a bit far from the usual Ferret plot appearance.

Modified by ansley.b.manke on 9 Dec 2011 22:06 UTC

Attachment from ansley.b.manke on 17 Nov 2011 01:41 UTC
REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_1896_GIT_1168/margin.gif


MB-2496 fix storybook tests job and reenable

Description
See this thread for details. But basically there is still a resource constraint issue when running storybook_tests in CircleCI vs local. This issue was not appearing on branch builds but was failing very consistently on master. However, a subsequent push to master resolved it. I was able to replicate this locally by setting Docker to have 2 CPUs, 2 GB Memory, and 1 GB swap in docker for mac. This PR reduces concurrency to 1 and enables returning the exit code so that results can be propagated back to CircleCI.
Setup
Set Docker to have 2 CPUs, 2 GB Memory, and 1 GB swap in docker for mac
make storybook_tests

Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

MB-2496 for this change
this slack thread for background

FYI looks like build of the tests isn't much longer than before, only about 30 - 60 seconds more.


How to get current authenticated user id to be the default value in  enso-select -filter

This is  a feature request.

Prerequisites

[x] Are you running the latest version?
[x ] Are you reporting to the correct repository?
(enso is made of many specialized packages: https://github.com/laravel-enso)
[ x] Did you check the documentation?
[x ] Did you perform a cursory search?

Description
How to get current authenticated user id to be the default value in  enso-select-filter

Extract it from the local store (Vuex). It’s in the root.

It works very well like this:
computed:{
...mapState(['user'])
current user(){ return this.user.id}
},

....
    value="currentUser"

Can we close this?

Sure, Thanks for you help! Very Good Application


feat(jstzd): Implement Endpoint

Context
JSTZ-130
Description
Implemented struct Endpoint that represents an octez node RPC endpoint.
Note that the line #[allow(dead_code)] is added because the struct fields are not referenced anywhere else for now.
Manually testing the PR

Unit test: added test cases

This PR seems independent from the OctezNode work? Perhaps it could target main instead. The PR looks quite small so we can get this in quickly to unblock https://github.com/jstz-dev/jstz/pull/572


numbers concept: fix empty about.md

Fixes: #1562

While I agree with the suggested changes, I think they belong in a separate PR, as some of these changes would probably need to be reflected into instroduction.md. In fact, I opened an issue together with this PR to improve this description further - your points can be added there.
The point of this PR is just to quick fix  #1562 and provide a basis for further improvement.

The point of this PR is just to quick fix #1562 and provide a basis for further improvement.

@jmrunkle I agree with this statement by @andrerfcsantos. I'd prefer to get this merged and then do changes in a follow-up PR.
Note to both: I've commented on some on @jmrunkle's comments, which can help understand why this exercise was designed as it is.


Consider switching from CodeClimate to Sonarcloud

Since it seems like CodeClimate was abandoned after 1.15 I suggest switching to Sonarcloud

+1 for Sonarcloud, I am using it for most of my projects since years too

I have Sonarqube setup for my Personal Projects, but I think Sonarqube would be a better fit for this


[Feature]: Evaluate transition to ReadWriteOncePod access mode for persistent volumes

Is there an existing issue already for this feature request/idea?

[x] I have searched for an existing issue, and could not find anything. I believe this is a new feature request to be evaluated.

What problem is this feature going to solve? Why should it be added?
Kubernetes 1.29 introduces GA support for ReadWriteOncePod access mode of persistent volumes: the volume can be mounted as read-write by a single Pod. Use ReadWriteOncePod access mode if you want to ensure that only one pod across the whole cluster can read that PVC or write to it.
See https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes.
We fix access mode to ReadWriteOnce (possibly even in PVC templates - see #5145).
Describe the solution you'd like
See if we can simply add it as the default mode starting from version 1.25 (at that point, all stable Kubernetes versions will have ReadWriteOncePod available). Make sure that we provide a way to fallback to ReadWriteOnce in case storage classes do not support it. Shall we add an accessMode property to any storage block?
Describe alternatives you've considered
N/A
Additional context
No response
Backport?
No
Are you willing to actively contribute to this feature?
Yes
Code of Conduct

[x] I agree to follow this project's Code of Conduct

I quickly tried changing the access mode to ReadWriteOncePod and it did not work locally, as I feared:
failed to provision volume with StorageClass "standard": Only support ReadWriteOnce access mode
Waiting for a volume to be created either by the external provisioner 'rancher.io/local-path' or manually by the system administrator. If volume creation is delayed, please verify that the provisioner is running and correctly registered.


Supports exported snapshots for Pg 9.4+

@Naros, could you review this one? Thanks!

Merged, thanks @cscetbon !


GH-39430: [C++][ORC] Upgrade ORC to 1.9.2

Rationale for this change
This PR aims to bring the latest bug fixes

https://orc.apache.org/news/2023/11/10/ORC-1.9.2/

ORC-1525 Fix bad read in RleDecoderV2::readByte

https://orc.apache.org/news/2023/08/16/ORC-1.9.1/

ORC-1462 Bump aircompressor to 0.25 to fix JDK-8081450

What changes are included in this PR?
This PR upgrades ORC dependency from 1.9.0 to 1.9.2.
Are these changes tested?
Pass the CIs.
Are there any user-facing changes?
No.

Closes: #39430

Thank you!


Colour scheme for bid price buckets

In short, the colour scheme as is works and there is plenty of contrast between colours, but I wonder if the scheme could be made more intuitive for people interpreting the plots:

Option 1: Choose a categorical (could retain existing), sequential and diverging colour scheme, and add a checkbox so a user can choose which they prefer to view the data with. Ideally you could choose between colour schemes, but this might require a fair bit of effort to implement?
Option 2: Change the default to either sequential or diverging.

I think diverging could be good, particularly if the colour scale can be "centred" at $0/MWh. This way, you can distinguish negative and positive offers. On the other hand, there are far more buckets that are positive, so using a diverging scale might reduce contrast between positively priced offer buckets.
Some sites that might help:

https://colorbrewer2.org/#
http://vrl.cs.brown.edu/color
https://www.sessions.edu/color-calculator/

Thanks @prakaa for the suggestions. I've put together a potential diverging colour scheme, and would be interested in your thoughts. I've tried to match up the discrete and continuous schemes as well.

Thanks @prakaa for the suggestions. I've put together a potential diverging colour scheme, and would be interested in your thoughts. I've tried to match up the discrete and continuous schemes as well.

@nick-gorman: I think the discrete works well, although as I mentioned before it might be a little hard to differentiate some bands. The outline on each bar segment (i.e. white outline) helps a lot though.
Re continuous, the contrast in high prices is obscured. Is that intentional? Not sure if it can be done, but a contrast based on a log scale for the continuous chart might help?


flask snippets are gone

It seems that the flask snippets have been removed. http://flask.pocoo.org/snippets now redirects to https://palletsprojects.com/p/flask/. I am told this is due to them being unmaintained. However, there was always a giant warning at the top of the page:

Snippets are unofficial and unmaintained.
This is an archived view of user-submitted snippets. Despite being hosted on the Flask site, they are not official. No Flask maintainer has curated or checked the snippets for security, correctness, or design.

In my opinion this was plenty clear, so I see no issue with keeping them around. In the past I used the CSRF protection snippet and it worked well, so there is still some use for it. More seriously, there are still inbound links to the snippets page, for example: https://flask-login.readthedocs.io/en/latest/#login-example

I do not plan to bring them back at this time.

Please elaborate.

I don't think it's that useful to bring them back on the official site, but maybe we could dump them into a git repo? That way they are preserved but don't appear as official as something on the site

They never appeared as official on the site. The very first line of the page was "Snippets are unofficial and unmaintained." My concern is not that they are gone forever, but that links from other projects are now broken.
If you need an archive of it, one is available here:
https://web.archive.org/web/20190128005233/http://flask.pocoo.org/snippets/

They used to appear as official on the site. Then at some point years ago, before I better understood how to word deprecation notices, I added that warning. It was always intended as "this is deprecated, it can go away at any time". It's hosted on an application that's no longer up. I can't help what other projects link to years after a notice explaining the questionable nature of the resource was added. I don't want to be held hostage by that to keep up a resource I don't think should be in use.
If there are snippets that other projects find helpful, they should adopt them into their docs or code so that they can actually remain maintained.


help(Datepicker): set the format dynamically

I'd like to be able to set the format of dates dynamically, without changing the locale.
I've succesfully used this.dateAdapter.setLocale('en-GB'). However, I'd like to be able to get the user preferred format from API (MM/DD/YYYY or DD/MM/YYYY, for instance) and to set it dynamically.
I know I can do something like if (value === 'DD/MM/YYYY') this.dateAdapter.setLocale('en-GB') but I want to make it 100% generic.
Thanks!

There's an example of setting a custom format in the docs:
https://material.angular.io/components/datepicker/examples


Conform with strict provenance

Previous version stored pointer as a usize, which causes warnings in Miri by default and error with -Zmiri-strict-provenance.
This version stores pointer directly and allows using proper strict provenance APIs with sptr feature. It potentially benefits optimizations and clarifies semantics of pointer-to-integer casts.
This PR also rewrites a couple of Clone implementations to be defined in terms of Copy.
Unfortunately, doing this introduced some semver-incompatible changes to the API:

pack() now returns a *mut T instead of usize
unpack() now takes a *mut T instead of usize

Considering this, I’m not sure whether it would be worthwhile to merge. Maybe adding new pack_ptr() / unpack_ptr() functions would work better?

Or just bool instead of a Kind maybe

Thanks! I’m not sure 4.0.1 is a right increment though — pack() and unpack() APIs changed, so that’s a breaking change.


Add navi-directory performance tests

Originally posted by @kevinhinterlong in https://github.com/yahoo/navi/pull/706#issuecomment-596136888
We found that adding @tracked to query params made directory almost unusable although it seemed to still work on chrome (firefox was pretty unusable).
We should add performance tests to assert that we can load and perform searches at a reasonable speed

https://github.com/yavin-dev/framework/blob/0a6413a50c14af6cc7867b86fcf39648cb0c68c2/packages/reports/addon/templates/components/report-visualization.hbs#L5


forge verify-bytecode panics

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (1ca9b85 2024-04-15T02:34:32.892525726Z)
What command(s) is the bug in?
forge verify-bytecode
Operating System
Linux
Describe the bug
When trying to run forge verify-bytecode on Morpho Blue it panics with:

Reproduce on morpho-blue at last commit on main 470a6871b3eaa56e94efdc2ee15b873c5f03e086, and run the following command:
forge verify-bytecode --rpc-url $ETHEREUM_RPC --constructor-args 0xcBa28b38103307Ec8dA98377ffF9816C164f9AFa 0xBBBBBbbBBb9cC5e90e3b3Af64bdAF62C37EEFFCb src/Morpho.sol:Morpho --verification-type partial (with your own ETHEREUM_RPC)

cc @yash-atreya

@QGarchery Try setting the etherscan config in foundry.toml like so https://book.getfoundry.sh/reference/config/etherscan?highlight=ETHERSCAN#etherscan

To be fair we can make this not rely on block explorers if:

All required inputs are provided by the user, and
We're ok with only verifying runtime code

We can also verify creation code but finding creation code is harder and RPC intensive (binary search over blocks to find deployment block, iterate through each tx, trace tx find where it was deployed(


Feature Request for fetching the task information #83770846

I was going through Lattice project tracker and found a story #83770846 which needs to fetch the task information using task guid.
I have implemented the above story in the following way
root@ubuntu:~# ltc help tasks
NAME:
   tasks - Fetches information of tasks running on lattice

USAGE:
   command tasks [arguments...]

DESCRIPTION:
   ltc tasks TASK_GUID

root@ubuntu:~# ltc tasks task-guid-1
Displaying the information of task task-guid-1
Task Guid:              task-guid-1
Cell ID:
Status:                 PENDING

root@ubuntu:~# ltc tasks task-guid-1
Displaying the information of task task-guid-1
Task Guid:              task-guid-1
Cell ID:                lattice-cell-01
Status:                 RUNNING

root@ubuntu:~# ltc tasks task-guid-1
Displaying the information of task task-guid-1
Task Guid:              task-guid-1
Cell ID:                lattice-cell-01
Status:                 COMPLETED
Failiure Reason:        failed to initialize container

root@ubuntu:~# ltc tasks task-guid-123757652735
Displaying the information of task task-guid-123757652735
Error while fetching the task by GUID : task with guid 'task-guid-123757652735' not found
root@ubuntu:~# ltc tasks
Please enter the task guid

@davidwadden
If this implementation fulfills the need of the above story then I am ready to raise a PR for this or else I am ready to make changes according to feedback.
Waiting for you feedback.....

Hi Asif,
I know it can be hard for people who are not used to Tracker to understand, but what you have done is work on a story that has been stored in our 'Icebox.' In Tracker, the way work is organized is based on stories that are actionable and have been prioritized. Those are the only stories we'll typically work on, and they're found in the Current and Backlog columns.
Stories that are not prioritized (for any number of reasons) are kept in the Icebox. Those stories are a grab-bag of various stories, from feature requests, partially developed ideas, or the result of brainstorming. The Icebox is a repository for all stories that are under consideration, and may possibly undergo considerable transformation or be discarded entirely. Stories in the Icebox may never be prioritized, in fact you'll see at the bottom of the Icebox is a section called, 'Graveyard.' Stories are stored there specifically to record that an idea has been considered and discarded.
The Icebox is not always maintained in the same disciplined manner of the Backlog.
In the case of Tasks, they were a partially-fleshed out idea that are not likely to be prioritized. We've decided to go in a different direction, but the Tracker hasn't been updated to reflect that. So unfortunately, we won't be able to accept your implementation. I know this is frustrating, and I'm sorry. We're really delighted to have your help these past several weeks.
I do have an alternate system to propose:
Several days ago, @davidwadden went through and tagged stories both in the Backlog and the Icebox as 'community.' These are stories that we felt are particularly well-suited to community contribution, and feel would be excellent candidates for people such as yourself to pull and work on. In the reality that the Icebox will never be a perfectly organized prediction of all the work we'll do, the 'community' tag is a compromise that there are a variety of features we're confident will be welcomed.
I'm going to close this Issue, but of course you should always feel welcome to re-open it if you find that there's value that would be lost.
--
Marco Nicosia
Product Manager
Pivotal Software, Inc.

You know what, if you're still interested, and I apologize ahead of time for the short notice, but we decided to pull those tasks stories into this release after all to help us out with condenser.  If you're interested and able to deliver something for us to review by Tuesday or Wednesday this week (Monday is a holiday for us), we'd consider either either of the following stories.  As you can see on our Tracker, we're trying to cut v0.2.5 before the end of next week and want to get the tasks epic in.
#83770848 - ltc should be able to cancel tasks/remove completed tasks
#84348820 - ltc list should also list tasks
If you're interested, go ahead and open new Github issue(s) for the above stories to if you have any questions.  Please also take a look at our recently implemented ltc tasks (#83770846) and ltc submit-task (#83770844), and feel free to submit any improvements you may have for those.
Thanks again for all your support!
David
/cc @asifhuawei @ShwethaKumbla @dhilipkumars @savitaashture

Hi @davidwadden thanks for considering us to do this task, we will be happy to work on that as we have recently explored a lot on task related things and we will try to raise a PR for #83770848 #84348820 by Tuesday.
Thanks
Asif


chore: update mailme

What kind of change does this PR introduce?

upgrades supabase/mailme package to v0.1.0 which contains https://github.com/supabase/mailme/pull/2

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.112%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
8025

Relevant Lines:
12325

💛  - Coveralls


continuous operation

Hello dhhagen
Thank you for the documentations and library.
I am completely new to this and would like to know if anyone managed to get a continuous data output from the OPC.N2 at regular time intervals.
Thank you.

Hey @JananiVJ Yup. I ran 10 of them for 6 months continuously..just make sure your sampling interval >= 1.2 s otherwise it doesn't behave very well.

When I run the program, the OPC starts and runs continuously. And I get an output in the terminal which looks something like this:
pi@PC-17-0302:~/Documents/examples/opcn2 $ python py-opc.py
Alphasense OPC-N2v18.2
True
{'Temperature': None, 'Bin 10': 0.0, 'SFR': 3.700000047683716, 'Bin 12': 0.0, 'Bin 13': 0.0, 'Bin 14': 0.0, 'Bin 15': 0.0, 'PM2.5': 0.0, 'Bin1 MToF': 0.0, 'Pressure': None, 'Bin 11': 0.0, 'Bin5 MToF': 0.0, 'PM1': 0.0, 'Bin7 MToF': 0.0, 'Checksum': 0, 'Bin3 MToF': 0.0, 'PM10': 0.0, 'Bin 8': 0.0, 'Bin 9': 0.0, 'Bin 6': 0.0, 'Bin 7': 0.0, 'Bin 4': 0.0, 'Bin 5': 0.0, 'Bin 2': 0.0, 'Bin 3': 0.0, 'Bin 0': 0.0, 'Bin 1': 0.0, 'Sampling Period': 2.7139840126037598}
pi@PC-17-0302:~/Documents/examples/opcn2 $
PM values are zero. If I run it again then I get some numbers. How did you manage to get the output data continuously?

@JananiVJ It looks like your sampling period is a bit over 2.5 seconds; is that correct? Where are you operating the device?

right now for testing, inside a room. In the future I will install these devices in a fixed sites (outdoor). I will also use them in mobile measurements on vehicles and tethered balloons.

Could you show your script that runs the OPC?

@DancingQuanta : This is the script that I use to run the OPC
Import the OPCN2 module.
import spidev
import opc
from time import sleep
Open a SPI connection on CE0
spi = spidev.SpiDev()
spi.open(0, 0)
Set the SPI mode and clock speed
spi.mode = 0b01
spi.max_speed_hz = 10000
Send OPc data to SPI interface
to_send = [0x3F]
spi.xfer(to_send);
#wait a bit.
sleep(1.0)
Print PM (OPC-N2) sensor values
try:
    alpha = opc.OPCN2(spi)
except Exception as e:
    print ("Startup Error: {}".format(e))
print alpha

print alpha.on()
sleep(1.0) #give it time to turn on...

# Read the histogram and print to console
OPC= alpha.histogram()
print (OPC)

Note:
in /usr/local/lib/python2.7/dist-packages/opc/init.py
line 76: I set the major and minor versions manually
line 243: firmware_max = 18.2   # Maximum firmware version supported


nushellFull: 0.88.1 -> 0.89.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for nushellFull is: A modern shell written in Rust
meta.homepage for nushellFull is: https://www.nushell.sh/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.89.0 with grep in /nix/store/hbm4g20gzl1vc16rs85r3996cc31zqi5-nushell-0.89.0
found 0.89.0 in filename of file in /nix/store/hbm4g20gzl1vc16rs85r3996cc31zqi5-nushell-0.89.0

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
nushell
nushellFull
nushellPlugins.formats
nushellPlugins.gstat
nushellPlugins.query

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hbm4g20gzl1vc16rs85r3996cc31zqi5-nushell-0.89.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nushellFull https://github.com/r-ryantm/nixpkgs/archive/28abdc683232ff36812edd6d65cf37e66b54b22c.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/28abdc683232ff36812edd6d65cf37e66b54b22c#nushellFull

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hbm4g20gzl1vc16rs85r3996cc31zqi5-nushell-0.89.0
ls -la /nix/store/hbm4g20gzl1vc16rs85r3996cc31zqi5-nushell-0.89.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages failed to build:

nushellPlugins.formats
nushellPlugins.gstat
nushellPlugins.query

2 packages built:

nushell
nushellFull

Maintainer pings
cc @Br1ght0ne @JohnTitor @marsam for testing.

Been running this locally for a while, seems fine.

everytime there is a nushell update, the plugins need to have their hash updated too.
I know I've needed to make a proper update script for sometime now.
in the meanwhile here is the following PR to unbreak the plugins
https://github.com/NixOS/nixpkgs/pull/280955


Factor out visualisation code

Current issue
I am trying to install qiskit with pypy (v.6.0.0) but it fails on the matplotlib dependency. I don't need matplotlib in my project as a runtime dependency since I am only generating dataframes (from pandas). Later, I use these dataframes in a python notebook to do visualisation.
What is the expected enhancement?
Currently, qiskit-sdk depends on two visualisation libraries: matplotlib and pillow. These do not provide core functionality for qiskit, but rather provide a nice way for a user to interact with the data structures provided by qiskit.
I suggest factoring out the visualisation code and dependencies into a separate project or plugin.
Furthermore, it may be worth it to re-evaluate which dependencies provide "core" functionality for qiskit as a library rather than as an application.

A end-user of qiskit could, for example, install the qiskit-visualazation package that would depend on qiskit-core and thus bring in all dependencies. I don't think users that use qiskit as tool would notice much of a difference.
I did not suggest getting rid of C bindings.

Ok. This sounds good, to reduce dependencies of Qiskit on external libraries and make it leaner.

Yes, I think qiskit could function both as a library and an application. But the library should have minimal dependencies.

How about keeping the core package useful, and just have the visualization
module dependencies optional, and only loaded if the visualization
functions are called?
On Wed, Jun 27, 2018, 22:14 Eddie Schoute<EMAIL_ADDRESS>wrote:

Yes, I think qiskit could function both as a library and an application.
But the library should have minimal dependencies.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/QISKit/qiskit-core/issues/595#issuecomment-400814268,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABMPqUsnJhR3z_yBH0H44Q7faCRg-S4Lks5uA-e5gaJpZM4U2gWz
.

I don't see how a qiskit-core without matplotlib would be "useless"?

@eddieschoute it is our plan to make the visualizations a plugin but its not the top of the priority. Everything in the tools directory will be elements of qiskit over time. Acqua started with removing the optimization.

Visualization of circuits is kind of a key thing to have in a package that people use for building quantum circuits/algorithms.  I use it nearly every day.  The visualization tools and/or matplotlib are used in nearly every tutorial notebook QISKit has.  The vast majority of people find it useful.  I don't see why features need to be stripped when simple alternatives such as import at function call exist.  I would say that, at least in the near term, visualization is a key part of the core library, just not part of the functionality that you need.

I don't see why features need to be stripped when simple alternatives such as import at function call exist.
They shouldn't be stripped. But moved to a separate package with appropriate dependencies so that dependencies remain consistent and predictable. Runtime errors are very annoying.

yes paul but its not going to be factored out of pip install qiskit. As i said i want to change qiskit-core to qiskit-terra and for eddie clearly he only wants to install terra for most users they use all of qiskit

This i leaving on hold until we have time to think about it more.

I think visualization is a key function of terra. At least for the foreseeable future (it might change eventually) so I don't think we should remove the external dependency on matplotlib, etc. So I'm going to close this for now.
That being said, I think one thing we can look at longer term after we add the ascii drawer in #1054 and make the changes to remove all the paths we deprecated added in #1055 is using setuptools extras to make matplotlib an optional requirement. So on a default pip install qiskit we won't have matplotlib installed, which would only be fine if none of the default visualizations use it. But then people could do pip install 'qiskit[extra_graphs]' and get matplotlib and have the things that require it work. But that's something to look at in the medium to long term and we should probably open a separate issue to discuss that approach when the time is right.

I think this needs to be reopened because the @eddieschoute's point still stands.
It can be closed when matplotlib and pillow get removed from requirements.txt.

@1ucian0 no, I was saying that we won't ever be factoring the visualization code into a separate package or an optional plugin since it's a core function of terra today (which aligns with what @nonhermitian was saying earlier). It's tightly coupled with user expectations on what terra provides today and the only case in which we could move the code externally would be as a hard requirement for terra (which would not fix the primary point here about dependencies). So we're not going to be removing the visualization libraries from the requirements anytime soon because we're not going to be removing the drawing code from the terra repo/package.
The second paragraph was more me musing at an alternative approach we could consider longer term, but that's not actually achievable in any definable time frame. Landing #1054 is just an early prerequisite to even begin to consider what I was talking about there, it's not actually something actionable after #1054 lands (especially because the non-circuit drawer functions like bloch sphere, histogram, etc still depend on matplotlib).
Basically I closed this as invalid/won't fix, not that we've fixed it.

I see the original post as "remove the visualization dependencies", while the "refactor out" is "the suggested solution". I understand that we are not going to take that "suggested solution" (even when I don't agree). But we are going to solve the issue with respect to the visualization dependencies. So, it can be closed when fixed.
Did I understand you correctly @eddieschoute?

@1ucian0 except that's not actually an option. We have hard import dependency on the external libraries because matplotlib is used in many places. Unless we remove these hard dependencies from ever being imported at the module level (which we cannot do as I explained above, it's not just the circuit_drawer) they will have to be listed in the requirements for the terra package. There is not really a middle ground here where we remove dependencies and keep the code which requires those libraries in terra. Especially moving forward if we're considering having visualization as a top level thing in the terra tree, and/or adding a draw() method to top level constructs like QuantumCircuit.
As I said earlier in my first post on this issue I was thinking out loud about a potential approach we could consider takin at some indeterminate point in the future. But it's not actually something we can do now or any time soon unless we come up with alternative default backends with no external dependencies for all the visualizations we support or drop functionality that we both agree is core to terra. It's disingenuous to keep this issue open on just that, it's not actually something anyone is going to be working on or merging into terra.

I think what I consider to be "foundations of qiskit" (as implied by "qiskit-terra") do not align with @mtreinish 's views. To me, the core of qiskit is quantum information processing. Providing tools to work with quantum circuits. And, possibly, running circuits via simulations or on quantum devices. Simply removing functionality is not my goal (the impact of the plotting code in qiskit itself is insignificant), but rather removing dependency bloat. Graphing is not necessary for using qiskit, which is why my suggestion could be feasible.
I think matplotlib and similar dependencies are not insignificant and to make them mandatory should be considered carefully. Therefore, I would be interested to see why @mtreinish thinks these are core to qiskit (and therefore qiskit-terra).
Simply removing them from the requirements will cause errors if the user does not install the appropriate package and should be avoided. This is going to happen nonetheless if you go the way of pip extras, albeit with a nicer (custom) error message, perhaps.

@eddieschoute I feel it's a key part of qiskit because at least for today visualizing your results and/or the input circuits are a key part of how most people are using qiskit. You can look to what @nonhermitian said a few months ago, at most of the papers out there citing that they use qiskit, or most of the qiskit-terra examples out there and the majority of those either draw the circuits or visualize the results from the experiments/jobs in some way. Also moving forward on the plan for the next release we're looking at things like integrating visualization methods into the key primitives in terra. Like adding a draw() method on the quantumcircuit class (see #911 for that). Examples of that will likely increase in the future too. I could also make the argument that lots of functions in terra aren't necessary for a particular individual use case. You may not personally need graphing for how you use terra but that doesn't exclude that others view it as a key feature of qiskit. We can argue about the semantics of "foundations of qiskit" and what that really means and just honestly disagree on this point though.
Which is really how I'm looking at this, from a more pragmatic software maintenance point of view. We have a defined public API with an implicit contract for doing visualizations in terra today. Simply removing it, making it optional and opt-in (via setuptools extras or some other mechanism), shifting it into a separate optional qiskit-foo python package, or any other option which removes matplotlib from requirements.txt (and the requirements list in setup.py) or as an implicit dependency that gets installed by default will change that api contract in a way which will break existing users. We already have enough breaking API changes today and we're getting better about it and don't want to do this. So doing this without a proper deprecation period that emits a warning of the coming change is not really an option. That being said to do something like that has a very high cost and we have to have a very good reason for it, and I think that just removing matplotlib from the requirements list isn't sufficient to justify it. Especially because I think there isn't a clear consensus that graphing isn't a key function of terra.
This all being said I do agree with you on the cost of having matplotlib as a required dependency can be high for certain environments (mainly on osx and pypy). But drawing the line at matplotlib does seem a bit arbitrary to me. From what I can tell matplotlib has been in the requirements to qiskit for as long as we've supported using pip (which predates my work on the project) and it's also far from being the most difficult package to use in terra's requirements file. Both scipy and numpy are in the requirements file (and used in parts of qiskit that I think we both agree are core) and those are much more difficult to install properly and get running. Especially, under pypy (which fwiw we don't list as a supported python interpreter for this reason) where as far as I know scipy still doesn't work. For numpy I think you can get it working, but you need to jump through some hoops to get there. Also at least according to https://morepypy.blogspot.com/2018/04/pypy27-and-pypy35-v60-dual-release.html you can use matplotlib under pypy with the tkagg backend.

The treatise by @mtreinish spells it out nicely.

I think it is decided that visualizations will stay in Terra for the time being. We have relaxed the reliance on Latex and Matplotlib (basically you can get by without them to draw circuits), and matplotlib will only be imported when explicitly requested (#1275).


Grouped events

Inspired by a gamedev problem I'm currently working on, I realize that it would be useful to declare events as related, so they can be managed in a way similar to database transactions. More specifically;

Late events can be handled on a group bases, in a configurable manner:

Handle late events ASAP, disregarding groups (current behavior)
Delay the whole group, preserving relative timing
Cancel the whole group

If we implement cancel, update, repeat or similar operations on pending events, we can have those operations apply to whole groups, database transaction style, guaranteeing that an operation will either be performed in full on all events in the group, or the whole operation is cancelled or unrolled.

Since interface contexts can be considered stateful (current interfaces are created per thread, and a thread-safe implementation would rely on TLS, to the same effect), we can implement groups by adding methods along the lines of BeginGroup()/EndGroup(), where BeginGroup() switches event enqueuing to a local buffer, and EndGroup() finalizes and sends the group via a single event to the engine context. Thus, API can remain simple to use, with virtually no impact on synchronization, performance etc when using event grouping.

This is really a great sounding software synthesizer for use in games.  Your demos were great too. I'd use it if i could be as productive with my own projects  It's much appreciated!


[4.2.x] Fix dependencies

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Cherry-picked commits from gh-279.
Can't say much more since gh-279 has no additional info.
Probably just fixes some superfluous and missing dependencies reported by the post-build linking checks?

I compared the differences between conda-build's linking checks from
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=780591&view=results
and
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=785362&view=results
from main which covers the changes from gh-279
to those from
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=826644&view=results
and
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=848992&view=results
, i.e., the last build for 4.2.x and for this PR.
They look pretty much the same, so picking @isuruf's changes to 4.2.x is probably alright.


Fix markdown warning with newer Rust.

Without this, there are warnings when building docs for any crates
that depend upon this.

Thanks for your PRs!


SyntaxError: not a PNG file

Hi,
I've been using the dataframe-image package for some time and as of this week it stopped working for me. The relevant code is simply:
dfi.export(cal_sorted,"Earnings Calendar "+str(today.date())+" .png")
which gives me the error:
SyntaxError: not a PNG file
I am not sure why this issue suddenly arose. I am using the latest version. The export with table_conversion = "matplotlib" works, but the formatting is not good.
Thanks!

I am getting the same error. Any help is appreciated.

I have the same issue

I haven't been able to find a solution yet, but it does seem to be an issue with chrome. Similar to this issue https://github.com/dexplo/dataframe_image/issues/14. I've tried reinstalling chrome and changing my chrome path to no avail.
Maybe it's an issue after an update?

Same issue.

I got it working by not having the temporary image file open while the chrome subprocess is ran. Below is monkey patch which works for me but I don't know why the file was opened. If Chrome update was the reason for it breaking maybe older version didn't work without it.
import dataframe_image as dfi
from dataframe_image._screenshot import Screenshot

import subprocess
import io
from pathlib import Path
from tempfile import TemporaryDirectory
from matplotlib import image as mimage

def take_screenshot_override(self):
    temp_dir = TemporaryDirectory()
    temp_html = Path(temp_dir.name) / "temp.html"
    temp_img = Path(temp_dir.name) / "temp.png"
    with open(temp_html, "w", encoding="utf-8") as f:
        f.write(self.html)

    args = [
        "--enable-logging",
        "--disable-gpu",
        "--headless",
        "--no-sandbox",
        "--crash-dumps-dir=/tmp",
        f"--force-device-scale-factor={self.device_scale_factor}",
    ]

    if self.ss_width and self.ss_height:
        args.append(f"--window-size={self.ss_width},{self.ss_height}")

    args += [
        "--hide-scrollbars",
        f"--screenshot={str(temp_img)}",
        str(temp_html),
    ]

    subprocess.run(executable=self.chrome_path, args=args)
    with open(temp_img, "rb") as f:
        img_bytes = f.read()

    buffer = io.BytesIO(img_bytes)
    img = mimage.imread(buffer)
    return self.possibly_enlarge(img)

Screenshot.take_screenshot = take_screenshot_override

Same issue for me. I thought it was because I was using a Virtual Machine, but maybe it's because the Chrome version on my VM is newer.
I was able to workaround by replacing _screenshot.py Line 115
with open(temp_img, "wb") as f:
with this replacement line:
with open(temp_html, "rb") as f:
Or delete Line 115 altogether, and de-indent the block below it. It doesn't makes sense to me to open temp_img for writing, when it's being written by a subprocess (Chrome). It seems like doing that blocked Chrome from writing to temp_img now.

Details of bug:
Windows 10 VM on VirtualBox, running on Windows 10 bare metal OS.
VirtualBox 7.0.4
Chrome 109.0.5414.75
python 3.9.6
dataframe-image 0.1.3
>>> import pandas as pd
>>> import dataframe_image as dfi
>>> df = pd.DataFrame({'x':[1,2,3]})
>>> dfi.export(df, 'out.png')

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 48, in export
    return _export(
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 117, in _export
    img_str = converter(html)
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 194, in run
    img = self.take_screenshot()
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 146, in take_screenshot
    img = mimage.imread(buffer)
  File "C:\Python39\lib\site-packages\matplotlib\image.py", line 1541, in imread
    with img_open(fname) as image:
  File "C:\Python39\lib\site-packages\PIL\ImageFile.py", line 117, in __init__
    self._open()
  File "C:\Python39\lib\site-packages\PIL\PngImagePlugin.py", line 732, in _open
    raise SyntaxError(msg)
SyntaxError: not a PNG file

I got it working by not having the temporary image file open while the chrome subprocess is ran. Below is monkey patch which works for me but I don't know why the file was opened. If Chrome update was the reason for it breaking maybe older version didn't work without it.
import dataframe_image as dfi
from dataframe_image._screenshot import Screenshot

import subprocess
import io
from pathlib import Path
from tempfile import TemporaryDirectory
from matplotlib import image as mimage

def take_screenshot_override(self):
    temp_dir = TemporaryDirectory()
    temp_html = Path(temp_dir.name) / "temp.html"
    temp_img = Path(temp_dir.name) / "temp.png"
    with open(temp_html, "w", encoding="utf-8") as f:
        f.write(self.html)

    args = [
        "--enable-logging",
        "--disable-gpu",
        "--headless",
        "--no-sandbox",
        "--crash-dumps-dir=/tmp",
        f"--force-device-scale-factor={self.device_scale_factor}",
    ]

    if self.ss_width and self.ss_height:
        args.append(f"--window-size={self.ss_width},{self.ss_height}")

    args += [
        "--hide-scrollbars",
        f"--screenshot={str(temp_img)}",
        str(temp_html),
    ]

    subprocess.run(executable=self.chrome_path, args=args)
    with open(temp_img, "rb") as f:
        img_bytes = f.read()

    buffer = io.BytesIO(img_bytes)
    img = mimage.imread(buffer)
    return self.possibly_enlarge(img)

Screenshot.take_screenshot = take_screenshot_override

This worked for me too.

Same issue for me. I thought it was because I was using a Virtual Machine, but maybe it's because the Chrome version on my VM is newer.
I was able to workaround by replacing _screenshot.py Line 115 : with open(temp_img, "wb") as f:
with this replacement line: with open(temp_html, "rb") as f:
Or delete Line 115 altogether, and de-indent the block below it. It doesn't makes sense to me to open temp_img for writing, when it's being written by a subprocess (Chrome). It seems like doing that blocked Chrome from writing to temp_img now.
Details of bug:
Windows 10 VM on VirtualBox, running on Windows 10 bare metal OS. VirtualBox 7.0.4 Chrome 109.0.5414.75 python 3.9.6 dataframe-image 0.1.3
>>> import pandas as pd
>>> import dataframe_image as dfi
>>> df = pd.DataFrame({'x':[1,2,3]})
>>> dfi.export(df, 'out.png')

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 48, in export
    return _export(
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 117, in _export
    img_str = converter(html)
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 194, in run
    img = self.take_screenshot()
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 146, in take_screenshot
    img = mimage.imread(buffer)
  File "C:\Python39\lib\site-packages\matplotlib\image.py", line 1541, in imread
    with img_open(fname) as image:
  File "C:\Python39\lib\site-packages\PIL\ImageFile.py", line 117, in __init__
    self._open()
  File "C:\Python39\lib\site-packages\PIL\PngImagePlugin.py", line 732, in _open
    raise SyntaxError(msg)
SyntaxError: not a PNG file

Great solution, I finally got it works.

So it seems i have to edit the dataframe-image package itself with these solutions? Please excuse my ignorance.

Same issue for me. I thought it was because I was using a Virtual Machine, but maybe it's because the Chrome version on my VM is newer.
I was able to workaround by replacing _screenshot.py Line 115 : with open(temp_img, "wb") as f:
with this replacement line: with open(temp_html, "rb") as f:
Or delete Line 115 altogether, and de-indent the block below it. It doesn't makes sense to me to open temp_img for writing, when it's being written by a subprocess (Chrome). It seems like doing that blocked Chrome from writing to temp_img now.
Details of bug:
Windows 10 VM on VirtualBox, running on Windows 10 bare metal OS. VirtualBox 7.0.4 Chrome 109.0.5414.75 python 3.9.6 dataframe-image 0.1.3
>>> import pandas as pd
>>> import dataframe_image as dfi
>>> df = pd.DataFrame({'x':[1,2,3]})
>>> dfi.export(df, 'out.png')

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 48, in export
    return _export(
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 117, in _export
    img_str = converter(html)
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 194, in run
    img = self.take_screenshot()
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 146, in take_screenshot
    img = mimage.imread(buffer)
  File "C:\Python39\lib\site-packages\matplotlib\image.py", line 1541, in imread
    with img_open(fname) as image:
  File "C:\Python39\lib\site-packages\PIL\ImageFile.py", line 117, in __init__
    self._open()
  File "C:\Python39\lib\site-packages\PIL\PngImagePlugin.py", line 732, in _open
    raise SyntaxError(msg)
SyntaxError: not a PNG file

For this solution, I would have to edit the dataframe-image package files themselves correct? If so, do you recommend editing them directly or forking the repo? Please excuse my ignorance.

So it seems i have to edit the dataframe-image package itself with these solutions? Please excuse my ignorance.

Same issue for me. I thought it was because I was using a Virtual Machine, but maybe it's because the Chrome version on my VM is newer.
I was able to workaround by replacing _screenshot.py Line 115 : with open(temp_img, "wb") as f:
with this replacement line: with open(temp_html, "rb") as f:
Or delete Line 115 altogether, and de-indent the block below it. It doesn't makes sense to me to open temp_img for writing, when it's being written by a subprocess (Chrome). It seems like doing that blocked Chrome from writing to temp_img now.
Details of bug:
Windows 10 VM on VirtualBox, running on Windows 10 bare metal OS. VirtualBox 7.0.4 Chrome 109.0.5414.75 python 3.9.6 dataframe-image 0.1.3
>>> import pandas as pd
>>> import dataframe_image as dfi
>>> df = pd.DataFrame({'x':[1,2,3]})
>>> dfi.export(df, 'out.png')

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 48, in export
    return _export(
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 117, in _export
    img_str = converter(html)
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 194, in run
    img = self.take_screenshot()
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 146, in take_screenshot
    img = mimage.imread(buffer)
  File "C:\Python39\lib\site-packages\matplotlib\image.py", line 1541, in imread
    with img_open(fname) as image:
  File "C:\Python39\lib\site-packages\PIL\ImageFile.py", line 117, in __init__
    self._open()
  File "C:\Python39\lib\site-packages\PIL\PngImagePlugin.py", line 732, in _open
    raise SyntaxError(msg)
SyntaxError: not a PNG file

For this solution, I would have to edit the dataframe-image package files themselves correct? If so, do you recommend editing them directly or forking the repo? Please excuse my ignorance.

For this solution you do need to edit the _screenshot.py script which is part of the dataframe_image.

Same issue for me. I thought it was because I was using a Virtual Machine, but maybe it's because the Chrome version on my VM is newer.
I was able to workaround by replacing _screenshot.py Line 115 : with open(temp_img, "wb") as f:
with this replacement line: with open(temp_html, "rb") as f:
Or delete Line 115 altogether, and de-indent the block below it. It doesn't makes sense to me to open temp_img for writing, when it's being written by a subprocess (Chrome). It seems like doing that blocked Chrome from writing to temp_img now.

@buckyster do you think this is worth opening a PR for?

Same issue for me. I thought it was because I was using a Virtual Machine, but maybe it's because the Chrome version on my VM is newer.
I was able to workaround by replacing _screenshot.py Line 115 : with open(temp_img, "wb") as f:
with this replacement line: with open(temp_html, "rb") as f:
Or delete Line 115 altogether, and de-indent the block below it. It doesn't makes sense to me to open temp_img for writing, when it's being written by a subprocess (Chrome). It seems like doing that blocked Chrome from writing to temp_img now.
Details of bug:
Windows 10 VM on VirtualBox, running on Windows 10 bare metal OS. VirtualBox 7.0.4 Chrome 109.0.5414.75 python 3.9.6 dataframe-image 0.1.3
>>> import pandas as pd
>>> import dataframe_image as dfi
>>> df = pd.DataFrame({'x':[1,2,3]})
>>> dfi.export(df, 'out.png')

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 48, in export
    return _export(
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 117, in _export
    img_str = converter(html)
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 194, in run
    img = self.take_screenshot()
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 146, in take_screenshot
    img = mimage.imread(buffer)
  File "C:\Python39\lib\site-packages\matplotlib\image.py", line 1541, in imread
    with img_open(fname) as image:
  File "C:\Python39\lib\site-packages\PIL\ImageFile.py", line 117, in __init__
    self._open()
  File "C:\Python39\lib\site-packages\PIL\PngImagePlugin.py", line 732, in _open
    raise SyntaxError(msg)
SyntaxError: not a PNG file

Same issue for me. I thought it was because I was using a Virtual Machine, but maybe it's because the Chrome version on my VM is newer.
I was able to workaround by replacing _screenshot.py Line 115 : with open(temp_img, "wb") as f:
with this replacement line: with open(temp_html, "rb") as f:
Or delete Line 115 altogether, and de-indent the block below it. It doesn't makes sense to me to open temp_img for writing, when it's being written by a subprocess (Chrome). It seems like doing that blocked Chrome from writing to temp_img now.
Details of bug:
Windows 10 VM on VirtualBox, running on Windows 10 bare metal OS. VirtualBox 7.0.4 Chrome 109.0.5414.75 python 3.9.6 dataframe-image 0.1.3
>>> import pandas as pd
>>> import dataframe_image as dfi
>>> df = pd.DataFrame({'x':[1,2,3]})
>>> dfi.export(df, 'out.png')

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 48, in export
    return _export(
  File "C:\Python39\lib\site-packages\dataframe_image\_pandas_accessor.py", line 117, in _export
    img_str = converter(html)
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 194, in run
    img = self.take_screenshot()
  File "C:\Python39\lib\site-packages\dataframe_image\_screenshot.py", line 146, in take_screenshot
    img = mimage.imread(buffer)
  File "C:\Python39\lib\site-packages\matplotlib\image.py", line 1541, in imread
    with img_open(fname) as image:
  File "C:\Python39\lib\site-packages\PIL\ImageFile.py", line 117, in __init__
    self._open()
  File "C:\Python39\lib\site-packages\PIL\PngImagePlugin.py", line 732, in _open
    raise SyntaxError(msg)
SyntaxError: not a PNG file

Thanks! This worked well.

I had the same problem, I found the root cause and fixed it.
@PaleNeutron  can you merge my pr ?
Fixed https://github.com/dexplo/dataframe_image/pull/70

can you create a new release version with that fix? It will help a lot thanks

For this solution, I would have to edit the dataframe-image package files themselves correct? If so, do you recommend editing them directly or forking the repo? Please excuse my ignorance.

@Mumbo-Jumbo-3 , either way works, whatever you prefer.  If you're deploying to multiple machines, you probably want a fork that you can reference.
ItamarShalev has submitted a pull request as well. So hopefully that can be merged and released soon.

Thanks to every effort you make in this issue to find out the bug.
I have create a new release , enjoy it.

If columns is more than 8, getting this error.
Reproduced with simple dataframe with 10 columns.
@PaleNeutron


grapher/un_sdg/2022-07-07/un_sdg dataset is missing section 11.6.1

When trying to rerun grapher import of UN SDG dataset etl grapher/un_sdg/2022-07-07/un_sdg --grapher I ran into two problems.

Section 11.6.1 is not in data even though we use one of its variables in a chart
Some variable names have switched dimensions in their titles, for instance variables from this chart have names like 16.1.2 - Number of total conflict-related deaths, by sex, age and cause of death (Number) - VC_DTH_TOTN - Planted explosives and unexploded ordnance (UXO) - Both sexes - All age ranges or no breaks by age, but ETL is creating variables with name 16.1.2 - Number of total conflict-related deaths, by sex, age and cause of death (Number) - VC_DTH_TOTN - All age ranges or no breaks by age - Planted explosives and unexploded ordnance (UXO) - Both sexes (note position of Both sexes). Is it possible that dimensions ordering is not consistent?

It is possible that we've made some updates to UN SDG code and didn't upload it to grapher. With automatic deploys we need to make sure our code and grapher are in sync.
@spoonerf do you have any idea why 1. happens (and maybe even 2.)? I can fix 2. by changing the code, but I'm lost when it comes to 1.

That's super weird - I can't think of anything of the top of my head but I can take a look into it and try and figure out what happened (or what past me did). Sorry!

@spoonerf don't worry then if you don't know from the top of your head. I'll take a quick look first.

@Marigold - this is the culprit for 1, "EN_REF_WASCOL" shouldn't be there. I can't remember why I added it - massive apologies!

The second culprit was caused by different sorting of dimensions from what we have in grapher. Changing it would be a pain, so it's better to wait for the new version and then archive the old dataset.

Should be sorted in #802

Hey @Marigold - I think this should be sorted now, I have updated the UN SDG dataset and archived the problematic one.
Not sure if this line needs updating?
Sorry for the troubles!


Adding API on cmd.FileReader for reading a file as ArrayBuffer

This commit adds implementation of support for dom.FileReader.readAsArrayBuffer as public API of the cmd.FileReader object exposing a function that reads the file as a Vector[Byte] using the typdarray api.
Updated goodies.md with new API
fixes #249

Should this use the new Scala 3 IArray instead of Vector?

Updated the error message and changed to use IArray. Note that caling toArray on an IArray produces this error message
method toArray in object IArray is deprecated since 3.0.1: This method implementation is incorrect and calling it can crash your program, please use `IArray.genericWrapArray(myIArray).toArray` instead. bloop [645, 43]

I don't really see this as an issue as the error message is descriptive enough.


Support streaming?

Right now, reRPC only exposes support for unary RPCs. However, it wouldn't be terribly difficult to support client, server, and bidirectional streaming - under the hood, NewReflectionHandler already uses bidi streaming.
Advantages of streaming:

Support a wider variety of use cases.
Users wouldn't need to migrate to grpc-go just to call or serve one streaming method, so building with reRPC becomes a safer bet.

Disadvantages of streaming:

We'd be using net/http in a somewhat unusual way. I'd expect more difficult-to-diagnose bugs.
reRPC's surface area would grow quite a bit. We'd need streaming equivalents for Func and Interceptor, and we might even need separate interfaces for each streaming type (like grpc-go).
Twirp doesn't support streaming: twitchtv/twirp#3. Most of the discussion on that issue focuses on the JSON streaming format, but we'd also probably want a framing mechanism for binary protobuf and a way to communicate errors mid-stream (after the HTTP status code has already been sent). For all its complexity, the gRPC specification solves these problems well.
Client and server streaming will work over HTTP/1.1, but bidi requires HTTP/2. With the lack of Twirp support above, this makes reRPC's compatibility guarantees harder to understand.

I lean toward keeping reRPC unary-only, but I'm leaving this issue open for discussion. I'm particularly interested in talking to anyone willing to use reRPC streaming in production.

Pushed a bit more progress tonight: we're now generating the server-side code to support all three streaming RPC types. Hopefully I'll get the client-side code and tests done in the next few days.

Done! reRPC now supports client, server, and bidirectional streaming, and cross-tests show that we're compatible with grpc-go. (We should probably exercise more corner cases in tests, though.)
Adding streaming didn't expand the API as much as I feared. We needed:

A Stream interface, which also serves as a pretty good transport abstraction for the generated code.
A StreamFunc interface, analogous to Func.
An additional method in the Interceptor interface.
A set of StreamType constants.

I'm still pretty close to the code, but the APIs feel pretty narrow to me.


Cannot change GenericOAuthClient response_type (code)

Continuing, #1583:
Although you updated the configuration class, the GenericOauth20Client doesn't allow changing this variable, as you can see arround here:
https://github.com/pac4j/pac4j/blob/9ef4f5186e971cc14adc59544867e4a18feff560/pac4j-oauth/src/main/java/org/pac4j/oauth/client/GenericOAuth20Client.java#L60
As far as I know, GenericOAuth20ProfileDefinition this class ultimately extends the OAuth20Configuration (that opened this issue). I think it may be wise to be able to set the response_type through here.
What are your thoughts?
I'm trying to pass this to CAS, in this line of code. I seem to need to update GenericOAuth20Client.

You can change the response_type via: oauth20GenericClient.getConfiguration().setResponseType("token"). Allowing that in CAS is another problem.

Something to solve on CAS side. Closing


enhancement for stackdriver tracing

@lei-tang  per our offline talk, we may add support for stackdriver without StsPort
https://github.com/istio/istio/blob/80884d8a0bc3532cbd52c1265df5a00399fe6542/pilot/pkg/networking/core/v1alpha3/tracing.go#L326

plan to remove from OSS istio


WIP:Pin VSPK version to 5.x

For the rel_5 container, we should ship a vspk 5.x.x

vspk 5.x does not work with python3 because of async e.g. /usr/lib/python3.7/site-packages/vspk/v5_0/nume.py, line 1251