Specific configuration must override generic configuration

Proposal: Specific configuration must override generic configuration
Author: Debashis Prusty<EMAIL_ADDRESS>IRC: handle (if different)
Date: 2018/29/06

Status: New
Proposal type: core design
Targeted Release: <future release #, ex. 2.2>
Associated PR: <link to GH PR in ansible/proposals if PR was submitted>
Estimated time to implement: <X days, weeks, etc.>

Motivation
Generic variables defined within the playbook or provided via vars files are applicable for all hosts. But if the user wants some of the generic values (like interface name) to be different for a particular host, then there is no inbuilt mechanism to override that.
Problems
What problems exist that this proposal will solve?

Problem #1 I am doing some network configurations where interface name and IP varies for some hosts. Then I can simply specify those values in host specific file and through configuration change this issue is resolved.
Problem #2 I have few master nodes selected through polling. The set of master nodes is dynamic. That information is stored in my configuration locally. Now some patch upgrades should be differed on those hosts. Now this particular host specific value prevents those patches being applied on the masters.

In our playbooks we are importing all host specific variables at the end of setting variables section like below.

name: Including host specific variables from current directory (if exists)
include_vars: 'host_vars/{{ inventory_hostname }}'
ignore_errors: yes
roles:

h_conf
n_conf
patch_deploy

Solution proposal

Change the variable precedence.
The below should be the precedence list,
...
set_facts / registered vars
role (and include_role) params
include params
inventory host_vars/
playbook host_vars/
host facts**
extra vars (always win precedence)
https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#variable-precedence-where-should-i-put-a-variable

No. This is solvable perfectly fine right now if you use the inventory variables properly. The order of the variables in the inventory is:

inventory/group_vars/all/
inventory/group_vars/<group>/
inventory/host_vars/hostname/
With what you want to do, you can just setup a default layout in inventory/group_vars/all/ directory, and then override it in specific host directories using the same variable names. They will do exactly what you want, which is override global variables with specific variables.

@drybjed Not sure if understood the proposed solution. So explaining the problem a bit more.
If I have "myVar=true" defined in vars section of main.yml, how can I overwrite it to "false" by means of some vars file (not commandline). That is without using "--extra-vars".

If we are talking about role variables, don't use vars/main.yml file for them. Put the variables in defaults/main.yml, in that case they can be easily overriden via Ansible inventory where you can have all/group/host granularity as you please.
Playbook variables are not as flexible, therefore it's best not to use them in this context. I'm not using them at all, and instead rely on role default variables.

https://docs.ansible.com/ansible/latest/reference_appendices/general_precedence.html <= clear 'configuration/settings' precedence rules, variables are part of it  for a good reason and 'specificity' is normally associated with host > play.
The variable precedence (linked and referenced in subject) is orthogonal (it influences value of variable considered in configuration precedence) but does not determine the general precedence.
AS such I'm going to close this as 'completed', though it was unclear at the time, clear documentation has been provided now.


FTL Failed initialising target with HTTPS plex URL

The following configuration results in an error currently.

Please advise on the current syntax to use for a Plex server at an FQDN with a valid SSL certificate.

I have the same issue.  I also see #181 opened for this as well.

Same issue. If I use my local IP, it tells me "unsupported protocol scheme." If I try with my FQDN and HTTPS, it tells me "invalid character '<' looking for beginning of value"
I can't see to figure out the magic url format that autoscan is looking for.

this is NOT an issue with if you have the autoscan on the same server as plex.... even though plex requires https: it WILL accept requests from localhost without needing ssl.... the plex url in config will have to be set to  http://localhost:32400


OP Not working and Perms not working properly 1.12.2

I was wondering if anybody could help me please... We've just migrated from PEX however our ops don't have the ability to do everything as they used to, it is set in the config to allow them to, tried using the autoop and the perm but that doesn't work either, tried * that doesn't work, adding new perms for players and groups works sometimes, however we cannot unset or set them to false, they just remain there.
Any help would be hugely appreciated.
Tried the Discord and they couldn't help so sent us here.
Thanks

To add to it, this is a bungee setup using MySQL which is set in all configs, bungee jar is installed and setup and messaging-service is set to sql

I need specific info to be able to help.
Specifically which permissions? Which commands did you run?
Outputs of info and permission info commands after setting the permissions?
Verbose reports showing which nodes are being checked, and what the results of each check are?
https://github.com/lucko/LuckPerms/wiki/Verbose
https://github.com/lucko/LuckPerms/wiki/Command-Usage:-User#lp-user-user-info
https://github.com/lucko/LuckPerms/wiki/Command-Usage:-Permission#lp-usergroup-usergroup-permission-info
https://github.com/lucko/LuckPerms/wiki/Command-Usage:-Parent#lp-usergroup-usergroup-parent-info
If I had to guess, I'd say double check that you have IP forwarding setup correctly.
https://github.com/lucko/LuckPerms/wiki/Network-Installation#pre-setup

Managed to fix the permissions issue with the help of Discord but ops are still being limited by the permissions even though they are set to bypass in the config...
Verbose shows correct perms being checked
If a perm is negated on default, ops can't use that command although the all commands allowed config option is set to true.

What do you mean by saying op?

What server software do you use? Bukkit-based or sponge-based?

Bukkit based - Spigot - 1.12.2

Some commands are set with non-op defaults, in which case just setting /op won't work.
You could try setting a * permission, or disabling bukkit default permissions in the LP config.

The * permissiondid not work - this was also tested.

Can you send a verbose recording link, and also an output for /lp editor please :)

This is an example where essentials.balance was negated or unset (but negated in the default group) however I had the * permission (including essentials.* as a separate one) but I still got insufficient permission so had to add the permission separately!
Verbose: https://luckperms.github.io/verbose/?pb5EEPQ8ql
Editor: https://luckperms.github.io/editor/?vqWptDSdKf
Thanks for getting back to me again! =)

Oh right, yeah, that's intended behaviour.
Standard permissions will override wildcard assignments, even if the wildcard is assigned at a higher priority within the inheritance tree

So there is no way to allow ops to use all commands without having to add the permission to them or their group? Not even * in the group works.

Just make sure they don't inherit from groups that negate permissions

Okay, thank you for your help!
Hope you have a great day! =)


DialogControlEvent usage...

Hello, I'm trying to make use of the DialogControlEvent (it kinda exists... Its under readers, I just had to make a class for it.)
I think im not doing anything wrong, however I'm trying to see if a particular dialog item is pressed.
Currently I can see that a dialog item was pressed and its cid. However it looks like the cid may differ between games(maybe map versions?). I was wondering if anyone knows a way to determine the cid of a dialog item to hopefully alleviate this issue.
For my DialogControlEvent class its pretty basic...
class DialogControlEvent(GameEvent):     def __init__(self, frame, pid, data):         super(DialogControlEvent, self).__init__(frame,pid)         self.data = data         self.cid = data["control_id"]         self.type = data["event_type"]         self.eventdata = data["event_data"]
edit: I have no clue how to format that right on github :(

https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/creating-and-highlighting-code-blocks says:
```python
Your code here.
```

Currently I can see that a dialog item was pressed and its cid. However it looks like the cid may differ between games(maybe map versions?).

It's entirely up to the map code which control gets what ID. SC2 assigns them incrementally, for every *Create or *Hookup action. I don't remember if the IDs get released when *Destroy is called, but if I were to guess I'd say no.
So yes, map versions may have effect on the ID, simply due to fact that map can introduce new controls that get created before the one you care about, and that will shift the IDs by X.
If the controls are part of some dynamic interface, that gets created and destroyed multiple times during the game, in response to something that happens in the game. Then it'll inevitably affect the IDs as well.
If you've control over the map code, then there are some tricks you can do to make it easier to "parse" such things - make it more explicit what ID corresponds to what Control from the replay events perspective. If you don't... then it doesn't leave you with much room to maneuver, at best you could make an educated guess in regards to the IDs, using your knowledge about the map.

Thanks Talv, I don't have control over the map, however I can always ask/create an implementation so they just have to pop it in. Not sure what you mean/how to make it more explicit what ID corresponds to a Control. The button is just created using a Create Dialog Item Button.


ignore eclipse generated files

these files are created with sbt eclipse in lila

environment specific files should go to your user-wide gitignore https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

Well personally I'd rather not modify global settings to for issues specific to lila.  I could add these entries to .git/info/exclude but sbt eclipse is part of the getting started instructions on the lila wiki and the locations it adds files are configured in the repository.
Seems like a standard build script should not create files that git sees as untracked.  So maybe the sbt scripts should be changed but if sbt eclipse is supported I don't see the harm in ignoring these paths -- as a side effect it prevents a non-eclipse user from easily committing to paths which would break the eclipse workflow.

I didn't know eclipse was in the recommended dev stack. ok then.

Thanks. For the record here's where it's used:
https://github.com/ornicar/lila/wiki/Lichess-Development-Onboarding#import-code-into-ide


registryIdRef not working in Replication resource

Hi All
Testing the Replication resource using the registryIdRef showed that the reference to a Registry object seems not to work.

Looking at the code I suspect the issue is that the referencing code is not fetching the right property from the referenced object.
In https://github.com/globallogicuki/provider-harbor/blob/main/config/replication/config.go the reference is specified but does not have a custom Extractor to reference the right parameter in the Registry object which would be "registryId", see screenshot.

By default, the reference fetches the "id" parameter of a referenced object.

Hey @tschlaepfer. Thanks for raising the issue. Let me take a look at this and get back to you.

This should work as per other references like in project member group https://github.com/globallogicuki/provider-harbor/blob/main/config/membergroup/config.go
I've been able to replicate your issue locally, so trying to figure out what the problem is...

Hi @lornest thanks for looking into it. I also had a look this morning, and while it proved to be more challenging than I expected, I eventually found a way to fix the registryIdRef.
As I mentioned in the issue report, I expect that by default the reference is done to the "id" parameter of the referenced object which in the screenshot example would be /registries/1. If you create a custom Extractor and add this to the reference configuration you can then extract the correct parameter which is "registryId". I struggled a bit with getting the value because it is not straightforward as the value in "registryId" is not a string but rather a float64. However, in the end, I managed to get the extractor code to fetch the "registryId" parameter properly.
I tested it by running the provider locally against my cluster with Harbor in it. Here is a screenshot from creating a Replication object using registryIdSelector.

In addition to fixing the replication, I also added the code to reference registries in Project so that one can create cache proxy repositories :) Here is a screenshot from my test to create a cache proxy project using registryIdRef

I will supply you the code via pull request, let me know if I should improve or update anything, I'm not an experienced Go developer so my code may need some improvement.

Thanks for raising this PR @tschlaepfer. I'll need to take a look at it when I get some time today. Will let you know when the new provider version is ready.

@tschlaepfer this and issue 6 have just been released. I'll take a look at the other one you raised for the next release. Thanks!


Conflicting scripts folder between lit-gpt and eval harness

Hi! I just wanted to give a heads up that when installing EleutherAI's evaluation harness there's a scripts module that overrides the scripts folder in lit-gpt, which results in errors such as the following one when running finetune/lora.py:
Traceback (most recent call last):
  File "/lit-gpt/finetune/lora.py", line 29, in <module>
    from scripts.prepare_alpaca import generate_prompt
ModuleNotFoundError: No module named 'scripts.prepare_alpaca'

I understand that eval harness is part of the non-essential modules but wanted to share this anyway in case anyone is blocked due to this. Using a less common name for the dirs we add to our path on-the-fly might be a more reliable solution in the long term, but as a quick fix one can prepend the script directory instead of appending it, i.e.
# support running without installing as a package
wd = Path(__file__).parent.parent.resolve()
# instead of this:
# sys.path.append(str(wd))
# put this:
sys.path.insert(0, str(wd))

This way both lora.py and the eval/lm_eval_harness.py script seem to run properly.

Hi @aittalam. This should be fixed with https://github.com/EleutherAI/lm-evaluation-harness/pull/902
Are you still seeing issues after reinstalling lm_eval?
I did not make the insert() change because it didn't work for me in my debugging. Do you think you could create a google colab notebook that demonstrates the issue and the fix?

Hi @carmocca, many thanks for your reply! My bad, I did not see https://github.com/Lightning-AI/lit-gpt/issues/558 before opening this issue and I was using a previous version of harness. Thanks for fixing it!

What was the error you were getting? Was it on lit-gpt or harness side? Happy to try the colab thing, or share with you a Docker image where the problem occurs


signalr/intro-security

SignalR Security Concepts
Authentication and authorization
The client connection
Rejoin groups when reconnecting
Prevent Cross-Site Request Forgery
CSRF mitigations taken by SignalR
SignalR Security Recommendations
Secure Socket Layers (SSL) protocol
Don't use groups for security
Safely handle input from clients
Change in user status

Would love to see docs on these.


Include last move in chat message

So chat can react better, the players last move should be printed out.

The chat message now prints the last move of the player


Mailadress timespan

name: Pull request
about: Contribute your changes to the project
title: '[pull-request] new oss Mailadress, use  no timespan'
labels: ''
assignees: @darenegade
Description
new oss Mailadress, use  no timespan
Checklist

[ ] Acceptance criteria are met
[ ] Pipeline has been run successfully
[ ] JUnit tests have been run successfully
[ ] Changelog is adjusted
[ ] Documentations are completed
[ ] Frontend is tested
[ ] Created sub-branches are deleted

bald weggeworfen

humpf!!einself
fup https://github.com/it-at-m/digiwf-core/pull/100
;)


[HybridApp] feat: go back to OD when trying to sign out

Details

PR making the user go back to OD when instead of logging out in HybridApp.
Fixed Issues

$ https://github.com/Expensify/App/issues/43336
PROPOSAL:
Tests

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@AndrewGable not sure how we should handle the signOut button when there is some error in the App: https://github.com/Expensify/App/blob/f618a94c486b80aebab584c52288a7013ffad64a/src/pages/ErrorPage/GenericErrorPage.tsx#L70. Should we hide the button or just make the user navigate to OD when he clicks it? Right now it will work like that.
Also, if we are an anonymous user, I guess we do not want to navigate back to OD? Is it even possible in the context of OD to be an anonymous user in ND?

Should we hide the button or just make the user navigate to OD when he clicks it? Right now it will work like that.

If we are redirecting to the sign in page, I think we should redirect the user to OldDot.

Also, if we are an anonymous user, I guess we do not want to navigate back to OD? Is it even possible in the context of OD to be an anonymous user in ND?

I do not think it's currently possible to be an anonymous user in HybridApp.

Ok, so it should work like that right now 🚀

Trigger Error in App

@WoLewicki What kind of error can be used as a trigger for the test? Would throwing an exception from a useEffect hook work?

Probably yes, but since Error page is not something you normally want to end up in in your app, it can be tricky to get there without touching the code.

@akinwale can you review this today, please? Thanks!

@trjExpensify I'll review today.

Great, please do! :)

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native
https://github.com/Expensify/App/assets/4160319/1129145d-a1f2-4a0e-b568-5825abca6e04

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/4160319/be562c43-a713-45cf-82df-ef640a4e7b26

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@WoLewicki could you help to trigger error message?

Trigger Error in App (not sure how to do it) so you are navigated to GenericErrorPage and click Sign Out button. On HybridApp it should navigate to OD, on ND it should sign you out.

Looking at the code (https://github.com/Expensify/App/blob/1d607acab9c47f2e0da4e8c85de5d90e2d47c11b/src/components/ErrorBoundary/BaseErrorBoundary.tsx) it is only possible to get to this page when you get an error from the App, and I am not sure if there is any scenario available that can get you there. cc @mountiny do you maybe know if it is triggerable?

I guess we could add a row for HybridApp only to throw an error on the troubleshooting page?

Do you mean a row in the options of TroubleShoot page (https://github.com/Expensify/App/blob/adb04ffbceced3b9e79546b0fd6da84d8c2504c4/src/pages/settings/Troubleshoot/TroubleshootPage.tsx#L122) that would throw an error when clicked? Would we want to expose it to the users then?

that would throw an error when clicked? Would we want to expose it to the users then?

Yeah that's probably a bad idea

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.3-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Cut first monorepo release

Cut the first release of -cpp as a monorepo. This will look VERY similar to how it looks today. There should be no user-facing code or build-file changes to any of the existing -cpp code.

I think this is now done, or we had a release that included -spanner in mind?


Adapter doesn't receive media / attachment messages

Hubot adapter is (AFAIK) unable to process message objects with attachments.
The message object below is what's currently received when I sent a DM to the bot with an image attachment. The message text is empty other than the auto prepended name. I've also tried capturing attachment messages in non-DM rooms and the text is completely empty.
message:
      TextMessage {
        user: [Object],
        text: 'Hubot ',
        id: 'Lx8WhdADN7oxKQhFX',
        done: false,
        room: 'ew8pCDwTTJGi6m5mno7tkCdvbCxScK5xHR' } } }

@timkinnane have you tried looking on the msg.message object?

@geekgonecrazy Yeah I was pretty sure I looked through all the properties. Are you saying it should be there?

It should be on that message object.  Because we essentially drop our
message object as is in the adapter
On Fri, Jun 24, 2016, 23:11 Tim Kinnane<EMAIL_ADDRESS>wrote:

@geekgonecrazy https://github.com/geekgonecrazy Yeah I was pretty sure
I looked through all the properties. Are you saying it should be there?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RocketChat/hubot-rocketchat/issues/139#issuecomment-228509636,
or mute the thread
https://github.com/notifications/unsubscribe/AADLHLugIu2EG-wHbXTbdN4ZE4l2udqDks5qPKpZgaJpZM4I8XpY
.

@geekgonecrazy I did a quick look of what is going on. The newmsg we get from the setupReactiveMessageList here looks like this:
{
  "rid": "L5vn23nm6zZefHkqktrgGoxKphoXvPJqD5",
  "msg": "",
  "file": {
    "_id": "k6zgdvow3bcK3D39y"
  },
  "groupable": false,
  "attachments": [
    {
      "title": "File Uploaded: 1-4FCAIgmJa8BuildjlnsDeA.png",
      "title_link": "/file-upload/k6zgdvow3bcK3D39y/1-4FCAIgmJa8BuildjlnsDeA.png",
      "title_link_download": true,
      "image_url": "/file-upload/k6zgdvow3bcK3D39y/1-4FCAIgmJa8BuildjlnsDeA.png",
      "image_type": "image/png",
      "image_size": 72753,
      "image_dimensions": {
        "width": 600,
        "height": 253
      }
    }
  ],
  "ts": {
    "$date":<PHONE_NUMBER>436
  },
  "u": {
    "_id": "L5vn23nm6zZefHkqk",
    "username": "eugene"
  },
  "_id": "7pXcDQxoHBmaxiitC"
}

for messages with attachments. However, there is no check for the presence of an attachment or file   on the message object. Hence the assumption that all the incoming messages will have a truthy msg property.
Will be glad to make a pull request to resolve this issue.
cc: @timkinnane

@ngenerio We definitely welcome a PR to fix this 👍

Thanks @ngenerio. Sorry I never replied @geekgonecrazy, I was getting back to this today but it looks like Eugene fixed it. :D Hoping we can get that PR through quickly.

@geekgonecrazy I based the attachment work on v0.1.4. So that it can be an early fix for users working with v0.1.x.

@ngenerio perfect.  Yeah i'm debatting how we should handle that.  I guess we keep under the v0.1.x scheme of things for now.
I'll discuss a bit with the team and figure out how we can get things on the right track. 👍

That would be great. But you can check out the [attachment-support](https://github.com/ngenerio /hubot-rocketchat/tree/attachment-support) branch for now.

@geekgonecrazy I think we should go by the v0.1.x to support those using that version. Moreover, the README advices to use the v0.1.x versions for now as the work in v1.x.x is experimental.

@geekgonecrazy I also added the attachment support in the master branch. Hope this clears issues going forward with the master branch. Also have the attachment-support branch which was based of the   v0.1.4 tag.
cc: @timkinnane

Support for this was added in v0.1.4 and also present in v1.0.3.
Closing now.


Q: what is the use of the target images in test?

Hi there. Can you tell me what is the use of the target images ? Are those for training stages?
多谢老铁

target images are the target object we need to track in the first frame. And the searching area is the area to search in the next frame.

According to the training set you provide as train/target/000024.jpg,train/searching/000024.jpg,0.29269230769230764,0.22233115468409587,0.7991794871794871,0.7608061002178649
The bounding box in images is big, taking almost half the target images.
I think the original Caffe model used larger dataset and thus could track whatever we want. I don't know if the model you provide checkpoint.ckpt is good for tracking small objects like this ball?

楼上两位老铁不是亲兄弟？名字好像啊lol. sorry 歪楼了


Heads Up - CoinJoinResearch Repo

Some of you may be unaware that I manage a CoinJoin Research Repository.
I keep archives of every CoinJoin implementation as well as theory work which has not yet been coded (Theory), Exploits and more.
I have added the presentations & scraped audio of the videos and uploaded them to the Knapsack & Snicker folders (Including the license).
It would be great to try and keep my repository synchronized with your videos - Hopefully the repository can help inspire some interesting ideas / discussions for future hangouts.
If you find any CoinJoin research / implementations which are not in the repository please make a pull request adding them!
Thanks,
6102

@wbnns should we add a link on the website that points to this repo? Maybe the link is for additional resources? I would like to close this issue

@AvivMilner
Sure, I've opened #20. Here's a preview. Please feel free to go ahead and merge the pull request if you think it looks ok.
Maybe we could bring in some of the material from the repository itself, onto the website, if you, @6102bitcoin and/or others are interested in it.


[TRIVIAL] Fixes for gcc 10

Gcc 10 fails to compile rippled without this change.

Codecov Report

Merging #3393 into develop will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #3393      +/-   ##
===========================================
- Coverage    70.44%   70.43%   -0.02%
===========================================
  Files          682      682
  Lines        54392    54392
===========================================
- Hits         38315    38309       -6
- Misses       16077    16083       +6

Impacted Files
Coverage Δ

src/ripple/rpc/handlers/AccountTx.cpp
85.23% <100.00%> (ø)

src/ripple/server/impl/BaseHTTPPeer.h
85.96% <0.00%> (-3.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9771210...1cca80e. Read the comment docs.


Cannot navigate between cells in command mode using arrow keys

Description
Navigation between cells with key up/down no longer works in 3.2.1-1, but it works perfectly in upstream 3.2.1:

Using k or j instead works.
Reproduce

Create a notebook,
Add cells
Press down
See that notebook scrolls rather than select next cell

Expected behavior
Next/previous cell gets selected.
Context

Operating System and version: Linux Ubuntu 21.10
JupyterLab-Desktop version: 3.2.1
Installer: deb

Browser Output
No output

This is because we pulled in newer lumino with https://github.com/jupyterlab/lumino/pull/252.

I opened https://github.com/jupyterlab/lumino/pull/256. We should cut a patch fix release one new lumino is out.

I'm having same issue. Version 3.2.2. This is new behavior after an update I did today. Will have to roll it back, as it's nearly unusable now.

@krassowski this seems to be fixed with v3.2.3-1


Fixed the issue of home page not directing in Leaderboard page.

Fixed the incorrect redirection of the "HOME" button on the leaderboard page.
Updated the href in the leaderboard HTML file to point to the main index.html located outside all folders by setting the path to ../../index.html.
This ensures that clicking the HOME button will now correctly navigate to the main homepage of the site.

@Crimson-Typhoon-147 I am talking about the index.html in main. Sorry for late response I have away for a few days

Okay! Thank you for the clarification. making it.

@B1N4RY-P4R45173 Just need one more thing to confirm I guess the index.html has been renamed into badges.html  which redirects to the same page but there has been a css file badges.css and i don't think that it has anything to do with the badges.html file as it opens totally page.
Please review it and let me know what to do.


Fixing italics on Billing FAQ

What are you changing in this pull request and why?
Fixing the italics in the FAQs
Checklist

[ ] Review the Content style guide and About versioning so my content adheres to these guidelines.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

[ ] Add page to website/sidebars.js
[ ] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

[ ] Remove page from website/sidebars.js
[ ] Add an entry website/static/_redirects
[ ] Ran link testing to update the links that point to the deleted page

enabled auto merge and updated branch for pr can be merged


Updated docker compose files

Proposed changes
Updated docker compose files. Fix for #598 .
Types of changes
What types of changes does your code introduce to the project?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Maintenance (update of libraries or other dependences)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have run all the existing tests locally (not just those related to my feature) and there are no errors
[x] After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
[x] I have updated the RELEASE NOTES
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@pooja1pathak that's great, did you test you can actually start docker compose w/ any of those files?

@pooja1pathak that's great, did you test you can actually start docker compose w/ any of those files?

Yes I have tested all the docker-compose files and I am able to run all the containers. Please find below image of CircleCI with all the tested are passing:

@pooja1pathak thanks so much, I've just merged your PR into main.


Save Graph Feature

The user should be able to save the current graph into local storage, retrieve any saved graphs, and download saved graphs in edge list, adjacency matrix, or adjacency list formats.

Save graph feature has been added.


Packaging as egg says "ModuleNotFoundError: No module named '_pillow_heif_cffi'"

Describe the bug
I wanted to make this usable on a system where I can't run pip to install this. I did the usual python3 setup.py bdist_egg and got an .egg file.
But upon trying to import something, I get:
  File "/etc/hooks/myScript.py", line 13, in <module>
    from pillow_heif import register_heif_opener
  File "/etc/hooks/./pillow_heif.egg/pillow_heif/__init__.py", line 7, in <module>
  File "/etc/hooks/./pillow_heif.egg/pillow_heif/_lib_info.py", line 5, in <module>
ModuleNotFoundError: No module named '_pillow_heif_cffi'

Same result with building a .whl with python3 -m build
Steps/Code to Reproduce
Package as .egg and try to import it a pillow_heif module.
Expected Results
I can use pillow_heif.
Actual Results
I can't use pillow_heif.
Versions
Python 3.10, Linux 64-bit, latest pillow_heif release

Install python CFFI before building
Run setup.py under root (if libheif library is not already installed in system, minimum supported libheif is 1.13.0)

In 0.10.x version(which will be beta of 1.0.0 release) there will be not dependent on CFFI module, but i can't say when the release will be(probably in a month), rewriting it all to C is still in a progress...

@melyux any success on this?

Hey @bigcat88 I went with using a virtualenv instead for this instead of using eggs/wheels. Are you saying the simple bdist commands should work in the future without having to do the extra CFFI install?

yep, i am working on this =)

@melyux feel free to test building from source. binary release on pypi will be available in a few days.

@melyux when after you check all is ok, feel free to close issue.
cheers :)

I will take your word for it! Thanks


Idea: Select Start/End on One Picker

First off, I love this project because it's focused more on functionality and less on style. Leaving the styling to the implementer of the component is the perfect way to go.
I'm wondering how hard it would be to add a feature that let a date range be selected within one calendar/picker. I'm imagining something where you might start with a calendar with nothing selected. The first two days clicked determines the range (could chosen as start->end or end->start). Then after that, you can click and drag the start/end dates to somewhere else. The picker would need to remain open during this time, and some sort of action button would need to be present to close the picker.
I realize it sounds like a lot of work. I may try to just implement something like this on my own, then share it. Just wondering if anyone else has any interest too.

This can already be done, although without dragging: you can set startDate and endDate from your onChange handler.  Determining whether the new date should be the start or end of the range can be done with simple logic.

Hmm, yeah I see what you mean. That logic part may not always be so logical, though. For example, if the current range starts on some Monday and ends on some Friday and then the user clicks on the Wednesday between those two, does he want to change the start to Wed or the end to Wed? I suppose I could use the children feature to add a toggle button within the picker, but I'm not sure if most people would understand that UI. I shall play around with it a bit. Obviously drag and drop would be clearer and easier to use.

I think determining how to handle clicking a day in the middle should be left to the consumer of the component; there's no obvious right answer, and I don't think one solution will make everyone happy. =)


Dependency: ensure at least serverengine 1.5.11 is used

This is related to a livelock issue described here: https://github.com/fluent/serverengine/issues/21

Thanks!! :+1: :+1:


Annotations in .TIFF format

The dataset I am working on has annotations in TIFF format. Is there a way to incorporate that into this work easily?

The annotation readers are in the annotation.py module. These are used in the slide.py module here. The two supported annotation styles use the XML format and the arguments are named accordingly.
In order to support a new annotation format, at the very least you'd have to write a dedicated annotation reader and use it in the Slide class.

Got it thanks. Do you by chance have a sample of either xml file? The link
to the test files seems to be broken.
Appreciate the support!
On Mon, Apr 27, 2020 at 04:41 Luís<EMAIL_ADDRESS>wrote:

The annotation readers are in the annotation.py
https://github.com/luisvalesilva/wsipre/blob/master/wsipre/annotation.py
module. These are used in the slide.py module here
https://github.com/luisvalesilva/wsipre/blob/85077ce493253d8512c888908cc203f0c45d1ef1/wsipre/slide.py#L66.
The two supported annotation styles use the XML format and the arguments
are named accordingly.
In order to support a new annotation format, at the very least you'd have
to write a dedicated annotation reader and use it in the Slide class.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/luisvalesilva/wsipre/issues/1#issuecomment-619825851,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHP5LRO3Z4TI4KMP2DY6JHTROVAK3ANCNFSM4MRNBLVA
.

--
Very Respectfully,
Zac Dannelly
LTJG, US Navy
[US] +1<PHONE_NUMBER>
[WhatsApp] +44 (0)7375  322020
"Time is a currency yielding the best returns when invested in others"

You can download the two examples used in the demos directly from here (>4 Gb), temporarily.
For context, the two supported annotation types are from two computer vision challenges: CAMELYON16/17 and BACH ICIAR 2018). I haven't checked if the data is still available for download.
Happy to help.

Awesome thanks!
On Mon, Apr 27, 2020 at 11:42 Luís<EMAIL_ADDRESS>wrote:

You can download the two examples used in the demos directly from here
https://drive.google.com/file/d/1j59JJf8126ubVOuig-zBVvgjf7Q_vvM3/view?usp=sharing
(>4 Gb), temporarily.
For context, the two supported annotation types are from two computer
vision challenges: CAMELYON16/17 https://camelyon17.grand-challenge.org/
and BACH ICIAR 2018 https://iciar2018-challenge.grand-challenge.org/).
I haven't checked if the data is still available for download.
Happy to help.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/luisvalesilva/wsipre/issues/1#issuecomment-620066635,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHP5LRIXGIDOGJZYX2X5JHLROWRYHANCNFSM4MRNBLVA
.

--
Very Respectfully,
Zac Dannelly
LTJG, US Navy
[US] +1<PHONE_NUMBER>
[WhatsApp] +44 (0)7375  322020
"Time is a currency yielding the best returns when invested in others"

Sure. Good luck with your project! I am closing this.


rover cd destroy doesn't work

I tried it a couple of ways:
rover cd destroy
rover lp destroy -c $HOME/caf_config/demo/level0 -s $HOME/git/caf-terraform-landingzones -l level0
This may be due to the fact that I changed some things in caf_config. As follows:
resource_groups = {
level0 = {
name = "lp-l0"
tags = {
level = "level0"
}
} ... etc

I deleted my launch pad manually, then re-installed with a caf_config in which I changed nothing. Immediately after rover lp apply, did a rover lp destroy and it worked normally.

We need to look into cd destroy.
it seems to be working fine for me, but without a --level it will try to destroy all levels BUT starting with the launchpad which of course will nuke all remote state causing all other destroy to fail. Probably just need to run it in reverse

Also running this cd destroy -c samples/ref-app/symphony.yml --level level0 failed for me
with Error: variable "landingzone" was required but not supplied don't know why :(

I just had an error in my config. PR #72 puts checks in place which would have caught this
The deletion in reverse issue still holds


Tiny code changes

What:

update github.com/stretchr/testify to v1.8.4
use binary integer literal to show first bit 0b10000000 instead of 128

Codecov Report
Patch and project coverage have no change.

Comparison is base (fb3b4df) 73.72% compared to head (62435e4) 73.72%.

:exclamation: Current head 62435e4 differs from pull request most recent head ad363e3. Consider uploading reports for the commit ad363e3 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   73.72%   73.72%
=======================================
  Files          42       42
  Lines        2158     2158
=======================================
  Hits         1591     1591
  Misses        339      339
  Partials      228      228

Impacted Files
Coverage Δ

encoding/bertlv.go
91.30% <ø> (ø)

field/bitmap.go
80.64% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix: upgrade semver

:tada: This issue has been resolved in version 2.5.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Fixed in issue #194.
Closing.


restrict drag-drop destination to board limits

Fix #92

Note that this fixes the most glaring problem, but there are still some problems this doesn't fix:

The two markers could be so far apart that both can't be on the destination board at the same time.
A single object could be so large it can't fit on the destination board.
Drag the markers from the big board to the small board, but do NOT actually drop the markers there.  Continue dragging until the mouse cursor is in the big board's CSelectPieceView.  The mouse cursor changes to show that dropping there is forbidden, but release the mouse anyway.  This seems to put CB in a strange state.  The CSelectPieceView shows the markers as selected, but the board does not (re)draw the markers with handles.  Also, the markers can still be dragged despite not showing handles, but if they are dragged, the tracking rectangles don't properly follow the mouse cursor.  If I switch the big board to its tiny view, I can see that dragging the markers shows the tracking rectangles for the markers far away from the mouse cursor.  So apparently drag-drop doesn't properly clean up a forbidden drop.

Nevertheless, I would still suggest applying this change to fix the originally-discovered problem.

It's definitely behaving better than before. But is some cases I get artifacts. When I drag the mouse into the small board all worked well but when I when back to the large board and dragged along the right edge I see this:

But it doesn't always happen. It's almost like a race condition. I was running both the 64bit and 32bit debug versions of this PR to test.
Regarding your other points.

In the drag rectangle too large case the best approach may be to shrink the box until it fits along the top, left, or both (if too large in both dimensions) and proportionately relocate the dragged items.
In the dragged item too large it's tricky. One could just butt it up to the left/top edge and render the item it a manner that get clipped. Another approach would be to change the drag target cursor to something the indicates the target location can't accept the drop.
I couldn't reproduce this for some reason. I wonder if it's because I'm running on a 4K monitor. If you could give me more clarity on this: "Continue dragging until the mouse cursor is in the big board's CSelectPieceView."

-Dale

Regarding 1. and 2., I was leaning toward rejecting the drop in both cases, which I think is what you are saying as well.
Regarding 3., I don't have any trouble reproducing it.  Indeed, I now see that I can get into this problem without ever viewing the small board.

Start with the original .gsn.
Select just the rightmost marker.
Drag the marker approximately two big-board cells to the right, so that the mouse is in the big board's tiny board window, and drop the marker in this forbidden window.
The result is that the marker stays displayed in its original location, and the CSelectPieceView shows the marker still selected, but the marker is displayed with no handles.  Also, if I drag the marker again, the tracking rectangle is in the wrong place.  Note that to see the tracking rectangle located incorrectly, the second drag has to be performed without unselecting and then reselecting the marker.

Regarding 4., which is what I will call your drawing artifacts, I can reproduce the problem as well.  And, again, I can do so without ever viewing the small board.

Start with the original .gsn.
Select just the rightmost marker.
Drag the marker to the right, but don't actually move the cursor into the tiny board view.  Instead move the mouse cursor just far enough to the right to have the cursor just slightly to the left of the scroll bar.  I see the tracking rectangle start blinking.  Now start moving the mouse cursor up and down.  The blinking tracking rectangle will leave artifacts, which actually sort of make sense, because the XOR drawing logic could easily miss its tracking rectangle erase if the mouse moves at a bad time.

Regarding 1. and 2., I was leaning toward rejecting the drop in both cases, which I think is what you are saying as well.

Correction:  what you were saying for 2., but not 1.

Regarding 1. and 2., I was leaning toward rejecting the drop in both cases, which I think is what you are saying as well.

I think that would be fine as well for both cases. It's consistent.

... 4. The result is that the marker stays displayed in its original location,

Ok. I can see what you're talking about now. Thanks for the alternate repo procedure. Of course this is a bug.

Regarding 4., which is what I will call your drawing artifacts, .... because the XOR drawing logic could easily miss its tracking rectangle erase if the mouse moves at a bad time.

This is what it made it feel like a race condition to me. This artifact is in the shipping version as well. This only seems to happen when dragging along a view edge. It doesn't happen when dragging along an edge when the auto-scroll is occurring which is more complicated to process. Weird.
This PR fixes some items so we should probably merge this change (as you originally requested) but the other issues should be entered as a new defect. I'll do the merge with your thumbs up. I just wonder why this hasn't been reported before since it's in the shipping bits. There's a sequence problem somewhere in the code that allows this to happen--perhaps a recursive code call without lock to prevent reentry into the same code.
-Dale

This PR fixes some items so we should probably merge this change (as you originally requested) but the other issues should be entered as a new defect. I'll do the merge with your thumbs up. I just wonder why this hasn't been reported before since it's in the shipping bits. There's a sequence problem somewhere in the code that allows this to happen--perhaps a recursive code call without lock to prevent reentry into the same code.

Yes, I think this should be merged and three separate new bugs entered for 1./2., 3., and 4..

I'll add the new issue items later today-ish.
-Dale


Added Bento learning tracks with free tutorials

These are learning tracks made up of free, curated tutorials that I've personally gone through. It covers foundational understanding of each topic (HTML, CSS, JS, Git) including best practices and common pitfalls of each.

Hi Jon!
Thanks! Why these 5? I see you have 15 tracks. Have you just added the ones you feel are more or less complete? I looked at JS and Git which look like great additions.

I just wanted to add to the existing categories that are currently there. I didn't want to impose if the current categories are what we wanted to stay limited to. If the maintainers really want to add them all, let's do it!

Happy to support Bento, love what you're doing. Where the tracks are substantially complete, let's add them. I see that the categories for the courses list could use some clean-up; alignment with free-programming-books.md categories is desirable.

No problem - all of those headings should be fixed. Also, I just realized after you had mentioned it that I never even considered putting these resources in the main books list. If you don't mind, I've added it there as well!

@eshellman Done. I'm happy with how things look here, unless you need me to help with anything else :)

No, I don't think these are books.

That's fair - will revert.

One way you can help is to keep an eye on PRs for the free courses list and comment on their quality and appropriateness, trying always to encourage participation.

Sure thing. I'm happy with how things look here if you are.


Disabled and Enabled GUI animation properties

About
I'd like to propose a new Property on BABYLON.GUI.Button to handle animating a button to and from a 'disabled' state. The various pointer animation properties (pointerEnterAnimation, pointerDownAnimation, pointerUpAnimation, pointerOutAnimation) make it very easy to animate a button's visual state between normal, hover, and focus. However, there is not currently a similar means to animate a button to a 'disabled' state which is an extremely common use case.
Solution
I imagine there's dozens of ways to implement functionality to handle a buttons disabled state, and I'll leave that for you experts to determine, but here's an example of how it could be implemented.
New Properties: toEnabledAnimation and toDisabledAnimation.
These would function similarly to the pointerDownAnimation property. Once can write a function defining the properties of the button that need tweened/lerped to when that button's isEnabled property changes.
...
// Button state animations
prevButton.pointerEnterAnimation = () => {
    prevButton.image.source = prevButton_hover;
}
prevButton.pointerDownAnimation = () => {
    prevButton.image.source = prevButton_focus;
}
prevButton.pointerUpAnimation = () => {
    prevButton.image.source = prevButton_hover;
}
prevButton.pointerOutAnimation = () => {
    prevButton.image.source = prevButton_normal;
}

//The new properties
prevButton.toEnabledAnimation = () => {
    prevButton.image.source = prevButton_normal;
}
prevButton.toDisabedAnimation = () => {
    prevButton.image.source = prevButton_disbaled;
}

Ideally, any property available on the Button and its children could be animated. However for my current use cases, these are the things I would want to be able to change: button image, button text, children graphics.
I'm not sure how the pointerDownAnimation animation is timed, but I would say however it is handled could be the same for the disabled/enabled state animation. Since we do like to control the timing and curve in the world of UX, a future improvement could enable us to set the duration and easing function used by the animation.
Discussion
This request originated in this forum post which also includes a playground example showcasing the various pointer animation properties.

I like the idea! this is rad

Upon reviewing the button.ts script, I see that the isEnabled property actually comes from the control class. Should this idea be implemented in the control instead of the button?
If it should be implemented in the button class, how could I fire the toEnabledAnimation and toDisabledAnimation functions when the button's isEnabled property changes? If the setter can be overridden similar to how the _processPicking was overridden, then I may be able to throw together a pull request for you.

I agree! that should be at control level!

No traction. Please re-open if needed.


stable/jenkins securityRealm issue

Describe the bug
I've defined an ActiveDirectory securityRealm in values.yaml but the the pod's securityRealm continues to default to Legacy.
Version of Helm and Kubernetes:
helm version
Client: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:37:52Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.4", GitCommit:"c27b913fddd1a6c480c229191a087698aa92f0b1", GitTreeState:"clean", BuildDate:"2019-02-28T13:30:26Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
Which chart:
stable/jenkins
What happened:
I configured a custom securityRealm in the values.yaml, and applied it using the helm install command. (helm install --namespace sem --name sem-jenkins -f values.yaml stable/jenkins)
values.yaml.txt
AD authentication does not work with the Jenkins instance generated. I audited the ~jenkins/config.xml in the pod and the XML has the default Legacy securityRealm.
What you expected to happen:
I would expect for AD authentication to work as expected and the custom securityRealm XML info to be in the config.xml file in the pod.
How to reproduce it (as minimally and precisely as possible):
run helm install command referencing a custom values.yaml file which includes an AD securityRealm.
helm install --namespace sem --name sem-jenkins -f values.yaml stable/jenkins
Verify the securityRealm config is in the newly created pod.
Anything else we need to know:

Was it the first install when you configured the security realm or was the chart installed with a different security real before and then changed the value and did a helm update?
You can check if the config.xml is rendered correctly. Here is the source:
https://github.com/helm/charts/blob/master/stable/jenkins/templates/config.yaml#L23
The config.xml is only ever copied once unless you set master.overwriteConfig.

I've tried both the first install and the upgrade and my the resulatant
pod's securityRealm still defaulted to the legacy.
I deleted, and purged my release.
I changed the master.overwriteConfig = true
I installed the release and the securityRealm is still set to the Legacy.
I even tried and ugrade using the same values.yaml, still Legacy.
I've attached the debug output of the upgrade command.
The USER-SUPPLIED VALUES: shows the correct securityRealm.
The COMPUTED VALUES: shows the correct securityRealm.
The MANIFEST: shows the Legacy securityRealm.
I'm unsure why my securityRealm config is not being included.
On Tue, May 21, 2019 at 5:42 PM Torsten Walter<EMAIL_ADDRESS>wrote:

Was it the first install when you configured the security realm or was the
chart installed with a different security real before and then changed the
value and did a helm update?
You can check if the config.xml is rendered correctly. Here is the source:
https://github.com/helm/charts/blob/master/stable/jenkins/templates/config.yaml#L23
The config.xml is only ever copied once unless you set
master.overwriteConfig.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/helm/charts/issues/14048?email_source=notifications&email_token=AA2IG7OW5SCFLL66C6U6G2TPWRUD3A5CNFSM4HOOGZT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV5ITFI#issuecomment-494569877,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2IG7MTHVP4PVV6VZSJA6TPWRUD3ANCNFSM4HOOGZTQ
.

I gave it a try with:
helm install stable/jenkins --name jenkins --version 1.1.21 --values ci/security-values.yaml
ci/security-values.yaml:
master:
  securityRealm: |-
    <securityRealm class="hudson.plugins.active_directory.ActiveDirectorySecurityRealm"<EMAIL_ADDRESS>      <domains>
        <hudson.plugins.active__directory.ActiveDirectoryDomain>
          <name>xx.xxx.xxx</name>
          <bindName>CN=xx_xxxxxxx,OU=xxxxxxxxxxxxxxx,OU=xxxxxxxxxxxxxxx,DC=xx,DC=xxx,DC=xxx</bindName>
          <bindPassword>{xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx}</bindPassword>
          <tlsConfiguration>TRUST_ALL_CERTIFICATES</tlsConfiguration>
        </hudson.plugins.active__directory.ActiveDirectoryDomain>
      </domains>
      <startTls>true</startTls>
      <groupLookupStrategy>AUTO</groupLookupStrategy>
      <removeIrrelevantGroups>false</removeIrrelevantGroups>
    </securityRealm>

The generated config map contains the securityRealm as specified. I can't judge if the xml config is correct and what you want, but it's at least that what is passed in via ci/security-values.yaml
kubectl get cm jenkins -o yaml:
  ...
  config.xml: |-
    <?xml version='1.0' encoding='UTF-8'?>
    <hudson>
      <disabledAdministrativeMonitors/>
      <version>lts</version>
      <numExecutors>0</numExecutors>
      <mode>NORMAL</mode>
      <useSecurity>true</useSecurity>
      <authorizationStrategy class="hudson.security.FullControlOnceLoggedInAuthorizationStrategy">
        <denyAnonymousReadAccess>true</denyAnonymousReadAccess>
      </authorizationStrategy>
      <securityRealm class="hudson.plugins.active_directory.ActiveDirectorySecurityRealm"<EMAIL_ADDRESS>        <domains>
          <hudson.plugins.active__directory.ActiveDirectoryDomain>
            <name>xx.xxx.xxx</name>
            <bindName>CN=xx_xxxxxxx,OU=xxxxxxxxxxxxxxx,OU=xxxxxxxxxxxxxxx,DC=xx,DC=xxx,DC=xxx</bindName>
            <bindPassword>{xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx}</bindPassword>
            <tlsConfiguration>TRUST_ALL_CERTIFICATES</tlsConfiguration>
          </hudson.plugins.active__directory.ActiveDirectoryDomain>
        </domains>

I had a look at your values.yaml.txt file. That looks like you've been using a version < 1.0 of this chart. Please check which chart version you are using. My comments related to the current one (1.1.21). Pre 1.0.0 most of the values used different case e.g. Master.SecurityRealm instead of master.securityRealm.


Music Generator Error

Looks like there is an error when taking a 3 track song and making it a 4 track song.
IndexOutOfRangeException: Array index is out of range.
GameCreator.Chips.GCSfxrMusicChip.GenerateSong () (at Assets/GameCreator/Scripts/GameCreator/Chips/GCSfxrMusicChip.cs:815)
GameCreator.Bridges.GameEditor.GenerateSong () (at Assets/GameCreator/Scripts/GameCreator/Bridges/GameEditor.cs:878)
(wrapper dynamic-method) System.Runtime.CompilerServices.ExecutionScope.lambda_method (System.Runtime.CompilerServices.ExecutionScope,object,object[]) <IL 0x0000b, 0x000a4>
MoonSharp.Interpreter.Interop.MethodMemberDescriptor.Execute (MoonSharp.Interpreter.Script,object,MoonSharp.Interpreter.ScriptExecutionContext,MoonSharp.Interpreter.CallbackArguments) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Interop/StandardDescriptors/ReflectionMemberDescriptors/MethodMemberDescriptor.cs:195)
MoonSharp.Interpreter.Interop.OverloadedMethodMemberDescriptor.PerformOverloadedCall (MoonSharp.Interpreter.Script,object,MoonSharp.Interpreter.ScriptExecutionContext,MoonSharp.Interpreter.CallbackArguments) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Interop/StandardDescriptors/ReflectionMemberDescriptors/OverloadedMethodMemberDescriptor.cs:153)
MoonSharp.Interpreter.Interop.OverloadedMethodMemberDescriptor/<GetCallback>c__AnonStorey0.<>m__0 (MoonSharp.Interpreter.ScriptExecutionContext,MoonSharp.Interpreter.CallbackArguments) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Interop/StandardDescriptors/ReflectionMemberDescriptors/OverloadedMethodMemberDescriptor.cs:425)
MoonSharp.Interpreter.CallbackFunction.Invoke (MoonSharp.Interpreter.ScriptExecutionContext,System.Collections.Generic.IList`1<MoonSharp.Interpreter.DynValue>,bool) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/DataTypes/CallbackFunction.cs:58)
MoonSharp.Interpreter.Execution.VM.Processor.Internal_ExecCall (int,int,MoonSharp.Interpreter.CallbackFunction,MoonSharp.Interpreter.CallbackFunction,bool,string,MoonSharp.Interpreter.DynValue) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Execution/VM/Processor/Processor_InstructionLoop.cs:720)
MoonSharp.Interpreter.Execution.VM.Processor.Processing_Loop (int) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Execution/VM/Processor/Processor_InstructionLoop.cs:115)
MoonSharp.Interpreter.Execution.VM.Processor.Call (MoonSharp.Interpreter.DynValue,MoonSharp.Interpreter.DynValue[]) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Execution/VM/Processor/Processor.cs:67)
MoonSharp.Interpreter.Script.Call (MoonSharp.Interpreter.DynValue,MoonSharp.Interpreter.DynValue[]) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Script.cs:483)
MoonSharp.Interpreter.Script.Call (MoonSharp.Interpreter.DynValue,object[]) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Script.cs:502)
MoonSharp.Interpreter.Script.Call (object,object[]) (at Assets/UnityRunner/Assets/Plugins/MoonSharp/Interpreter/Script.cs:525)
PixelVisionRunner.Chips.LuaGameChip.Update (single) (at Assets/UnityRunner/Assets/Runner/Scripts/Chips/LuaGameChip.cs:62)
PixelVisionSDK.Chips.ChipManager.Update (single) (at Assets/UnityRunner/Assets/PixelVisionSDK/Engine/Chips/ChipManager.cs:112)
PixelVisionSDK.PixelVisionEngine.Update (single) (at Assets/UnityRunner/Assets/PixelVisionSDK/Engine/PixelVisionEngine.cs:190)
BaseRunner.Update () (at Assets/UnityRunner/Assets/Runner/Scripts/BaseRunner.cs:490)
GameCreator.GameRunner.Update () (at Assets/GameCreator/Scripts/GameCreator/GameRunner.cs:166)
GameCreator.GameCreatorRunner.Update () (at Assets/GameCreator/Scripts/GameCreator/GameCreatorRunner.cs:692)

This is fixed.


[HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

[HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.
Change Logs
TBD
Impact
TBD
Risk level (write none, low medium or high below)
Low. Feature hidden behind a flag. Disabled by default.
Documentation Update
TBD
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

NOTE: Had to create the dummy PartitionIdPassthrough due to refactoring in https://github.com/apache/spark/commit/c548e59301941a40ff2d07590645bcd24280a550

@xushiyan @danny0405 @codope @nsivabalan I have addressed all feedback. PTAL and resolve the open comments.

Thanks for the fix @prashantwason , here are some fixes for the checkstyle:
53.patch.zip


eosio-abigen 1.3.1 warnings

cc32d9@ubuntu01:~/build/localeos/escrow$ make
eosio-cpp -o loceosescrow.wasm loceosescrow.cpp
eosio-abigen -contract=loceosescrow --output=loceosescrow.abi loceosescrow.cpp
In file included from /home/cc32d9/build/localeos/escrow/loceosescrow.cpp:1:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/eosio.hpp:6:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/action.hpp:7:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/datastream.hpp:11:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/flat_set.hpp:27:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/new_allocator.hpp:24:
/usr/local/eosio.cdt/bin/../include/boost/container/throw_exception.hpp:56:21: warning: address of array 'msg' will always evaluate to 'true'
      [-Wpointer-bool-conversion]
      BOOST_ASSERT(!msg);
                   ~^~~
/usr/local/eosio.cdt/bin/../include/boost/assert.hpp:60:36: note: expanded from macro 'BOOST_ASSERT'
# define BOOST_ASSERT(expr) assert(expr)
                                   ^~~~
/usr/local/eosio.cdt/bin/../include/libc/assert.h:8:28: note: expanded from macro 'assert'
#define assert(x) ((void)((x) || (__assert_fail(#x, __FILE__, __LINE__, __func__),0)))
                           ^
In file included from /home/cc32d9/build/localeos/escrow/loceosescrow.cpp:1:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/eosio.hpp:6:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/action.hpp:7:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/datastream.hpp:11:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/flat_set.hpp:27:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/new_allocator.hpp:24:
/usr/local/eosio.cdt/bin/../include/boost/container/throw_exception.hpp:64:25: warning: address of array 'msg' will always evaluate to 'true'
      [-Wpointer-bool-conversion]
      BOOST_ASSERT_MSG(!msg, str);
                       ~^~~
/usr/local/eosio.cdt/bin/../include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'
# define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg))
                                             ^~~~
/usr/local/eosio.cdt/bin/../include/libc/assert.h:8:28: note: expanded from macro 'assert'
#define assert(x) ((void)((x) || (__assert_fail(#x, __FILE__, __LINE__, __func__),0)))
                           ^
In file included from /home/cc32d9/build/localeos/escrow/loceosescrow.cpp:1:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/eosio.hpp:6:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/action.hpp:7:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/datastream.hpp:11:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/flat_set.hpp:27:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/new_allocator.hpp:24:
/usr/local/eosio.cdt/bin/../include/boost/container/throw_exception.hpp:72:25: warning: address of array 'msg' will always evaluate to 'true'
      [-Wpointer-bool-conversion]
      BOOST_ASSERT_MSG(!msg, str);
                       ~^~~
/usr/local/eosio.cdt/bin/../include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'
# define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg))
                                             ^~~~
/usr/local/eosio.cdt/bin/../include/libc/assert.h:8:28: note: expanded from macro 'assert'
#define assert(x) ((void)((x) || (__assert_fail(#x, __FILE__, __LINE__, __func__),0)))
                           ^
In file included from /home/cc32d9/build/localeos/escrow/loceosescrow.cpp:1:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/eosio.hpp:6:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/action.hpp:7:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/datastream.hpp:11:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/flat_set.hpp:27:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/new_allocator.hpp:24:
/usr/local/eosio.cdt/bin/../include/boost/container/throw_exception.hpp:80:25: warning: address of array 'msg' will always evaluate to 'true'
      [-Wpointer-bool-conversion]
      BOOST_ASSERT_MSG(!msg, str);
                       ~^~~
/usr/local/eosio.cdt/bin/../include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'
# define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg))
                                             ^~~~
/usr/local/eosio.cdt/bin/../include/libc/assert.h:8:28: note: expanded from macro 'assert'
#define assert(x) ((void)((x) || (__assert_fail(#x, __FILE__, __LINE__, __func__),0)))
                           ^
In file included from /home/cc32d9/build/localeos/escrow/loceosescrow.cpp:1:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/eosio.hpp:6:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/action.hpp:7:
In file included from /usr/local/eosio.cdt/bin/../include/eosiolib/datastream.hpp:11:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/flat_set.hpp:27:
In file included from /usr/local/eosio.cdt/bin/../include/boost/container/new_allocator.hpp:24:
/usr/local/eosio.cdt/bin/../include/boost/container/throw_exception.hpp:88:25: warning: address of array 'msg' will always evaluate to 'true'
      [-Wpointer-bool-conversion]
      BOOST_ASSERT_MSG(!msg, str);
                       ~^~~
/usr/local/eosio.cdt/bin/../include/boost/assert.hpp:61:46: note: expanded from macro 'BOOST_ASSERT_MSG'
# define BOOST_ASSERT_MSG(expr, msg) assert((expr)&&(msg))
                                             ^~~~
/usr/local/eosio.cdt/bin/../include/libc/assert.h:8:28: note: expanded from macro 'assert'
#define assert(x) ((void)((x) || (__assert_fail(#x, __FILE__, __LINE__, __func__),0)))
                           ^
5 warnings generated.

Resolved.


Custom property not selected from problems panel

Describe the bug
When I click a custom propery from the problems panel (warning) then I expect the properties panel entry to be shown, but nothing happens:

Steps to reproduce

Open custom-property.bpmn
Open problems panel
Focus secrets.FOO deprecation message

Expected behavior
Selecting the warning entry focuses the field; this also works in element-template mapped fields.
Environment

OS: Linux
Camunda Modeler Version: v5.16.0
Execution Platform: Camunda 8
Installed plug-ins: None

Additional context
Found in the context of https://github.com/camunda/camunda-modeler/pull/3885.

Depends on https://github.com/bpmn-io/bpmn-js-element-templates/issues/16

Closing in favor of #3896.


Nuke IAM Users

Closes #160 , Partially Implements #116
Now we can delete IAM Users (still doesn't delete attached resources), configuring inclusion and exclusion rules on the configuration file and having a clean output when deleting IAM Users (as they are global and not region specific).
Please read each commit message for more details.
All comments are welcomed.

Looks good! raised_hands
I've left a couple of comments/questions, but nothing that should block you hopefully! I've also noticed there's a couple of TODOs that are still around here (the exclusion time filter & listPages), so I imagine this is still WIP slightly_smiling_face

Thank you so much for your thorough review :bowing_man:

@ina-stoyanova @zackproser @yorinasub17 mind taking another look, specially at the last commit?
This last one is "only a small feature":tm:  that actually requires a bunch of other stuff and extra validations, which I believe I was able to do.
Thanks :smile:

@yorinasub17 mind taking another look into the new commits that implemented the NITs that you gave?
(The retry logic will be in another PR)


Fix typo in EdmBoolean constant value

Fixes #29255.
The value for EdmBolean was "Edm.Boolean" instead of "Emd.Boolean".

API change check
API changes are not detected in this pull request.

@christothes based on your comments, I have removed the unreferenced constants from this file, including the value with the typo.


Handle deletion of clusters running a complex workload

If the cluster is gone there's not much we can do to delete the resources we previously deployed to it, so we just remove our finalizer and let the KAR be deleted.
Fixes #459

This is failing Sonar because I duplicated a string three times and Sonar wants it to be a constant. I've started work to fix but got carried away.
I think it would be ideal to either sync our linter config with Sonar's, or just use one or the other.

I think Sonar has a point :)

I think Sonar has a point :)

I mostly do too, though in starting to remedy this I ended up going through and making all error and error format strings constants. One one hand this is helpful for testing and to ensure frequently repeated strings remain in sync. On the other hand it's a little awkward to have error strings defined so far from where they're used (i.e. typically at the top of the file). In short, I felt like this was a good idea but then cooled on it a bit once I actually started implementing it.

a little awkward to have error strings defined so far from where they're used

I agree, for larger files, I tend to have multiple const blocks each closer to the actual usage.

Does Sonar have some CLI tooling I can use to determine whether my code is likely to satisfy it before I open a PR?

Do you mean something like this: https://www.sonarlint.org/


Use elliptic curve crypto

http://www.keylength.com/en/3/
Need to research if work factor in validation is less for ECDSA 256 key vs RSA 3248 key. Gmail uses this so should be safe for mass browser support also.
On the other hand, ECDSA requires a "true" random number generator as opposed to crypto/rand package which is a pseudorandom number generator. However we can combine crypto/rand with entropy generated by the incoming request (IP, request time, time spent on internal queue, load balancing route, handling server no, cpu mem usage for request, etc. etc.) to generate enough randomness for this purpose.
At this point, I'm not 100% sure if we should hash than XOR crypto/rand with other randomness or there is a more secure way.

I'm hearing that disabling RDRAND would also be beneficial as it can not be audited to be non-malicious.

Moved to: https://github.com/nbusy/ca/issues/1


Add Venator Bow please?

The Venator bow is missing, could you please add it as well? :)

I can add it if you can provide the animation id.

@ngraves95
player pose animation ID is 9857
player animation ID for firing is 9858


⚠ Site ANTS has degraded performance

In 6caaf47, Site ANTS (https://ants.gouv.fr) experienced degraded performance:

HTTP code: 200
Response time: 16881 ms

Resolved: Site ANTS performance has improved in e3a30b4.


Missing body/shape functions for dampings, gravity, filter

Currently it looks like there's no getters or setters for existing bodies for linear damping, angular damping, or gravity scale.
EDIT: I'm also noticing that there are no functions for getting/setting the filter on existing shapes.

Awesome, looks like the shape filter stuff is sorted and there's now setters for the body parameters. No getters though - is this intentional?

I can easily add the getters if you need them.

Yes please! I'm only creating issues for things I'm actively using in my engine that have gone missing between versions. I hope that's okay.

Thanks for the report. See #99


String with 'f' prefix not work with python2.7 by run examples

DRF OpenAPI version: 1.0.0
Python version: 2.7.11
Operating System: windows

Description
urlpatterns = [
    url(r'^admin/', admin.site.urls),
    url(f'{API_PREFIX}/schema/', MySchemaView.as_view(), name='api_schema'),
    url(f'{API_PREFIX}/snippets/', include('snippets.urls')),
]

String with 'f' prefix not work in python2.7
What I Did
python examples/manage.py runserver

f strings were added in Python3.6.
While f strings are really nice I think the best thing to update the docs to change these to raw strings instead.
@howmp would you be interested in submitting a PR updating it to raw regex in the docs?


Add reportlets to document run-wise DWI and anatomical file information

Summary

A few thoughts:

Phase encoding direction
Voxel size
TR
Number of directions
Number of unique bvals

Usually the PEDs have been merged during preprocessing, so there will be a mix of PEDs in the preprocessed data. And I don't think the TR is stored in the derivatives of qsiprep, so we'd need to grab that from the raw bids.
The number of directions and the unique bvals would be very useful though


Update free-courses-bn.md

What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[ ] Read our contributing guidelines
[ ] Search for duplicates.
[ ] Include author(s) and platform where appropriate.
[ ] Put lists in alphabetical order, correct spacing.
[ ] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

please add commits to this PR instead of duplicating it.

Can you help me, how can i commit to this PR? Please??

Can you help me, how can i commit to this PR? Please??

Make commits/mods over the same branch where the PR was sent instead of create a new branch. Github synchronizes automatically this fork changes over upstream where PR is listening

Did you updated the free-courses-bn.md file?

Did you updated the free-courses-bn.md file?

yes my friend. But always take care about branch to you are commiting (patch-3 in this PR)

But it is not updated in the main repository. I am not seeing the course
name that I have updated in main repository. Can you please see?
On Sat, Jul 16, 2022, 1:56 AM David Ordás @.***> wrote:

Did you updated the free-courses-bn.md file?
yes my friend. But always take care about branch to you are commiting (
patch-3 in this PR)
—
Reply to this email directly, view it on GitHub
https://github.com/EbookFoundation/free-programming-books/pull/6923#issuecomment-1185863048,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARAHHR2XQYRRZUHTRUIMWX3VUG67BANCNFSM53UJOL3A
.
You are receiving this because you authored the thread.Message ID:
@.***>

But it is not updated in the main repository. I am not seeing the course name that I have updated in main repository. Can you please see?
…
On Sat, Jul 16, 2022, 1:56 AM David Ordás @.> wrote: Did you updated the free-courses-bn.md file? yes my friend. But always take care about branch to you are commiting ( patch-3 in this PR) — Reply to this email directly, view it on GitHub <#6923 (comment)>, or unsubscribe <github.com/notifications/unsubscribe-auth/ARAHHR2XQYRRZUHTRUIMWX3VUG67BANCNFSM53UJOL3A> . You are receiving this because you authored the thread.Message ID: @.>

Needs a PR merge by this repo team to be seen in main branch since you don't have write access rights in this repo

Did the repo team merged my PR in the main?

Did the repo team merged my PR in the main?

Be patient. I'm on the reviewers team

Ok. Thank you so much. I just wanted to know.
Thank you again.
On Mon, Jul 18, 2022, 12:02 PM David Ordás @.***> wrote:

Did the repo team merged my PR in the main?
Be patient. I'm on the reviewers team
—
Reply to this email directly, view it on GitHub
https://github.com/EbookFoundation/free-programming-books/pull/6923#issuecomment-1186799338,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARAHHR6YBBMBNLZ7BQ6CMBLVUTXQ3ANCNFSM53UJOL3A
.
You are receiving this because you were assigned.Message ID:
@.***>

Thanks, and welcome to free-programming-books!

Thank you so much. I am very much glad to work with you. And I am very much happy 😊.  Finally, my dream to work with Ebook Foundation came true.
Once again thank you so much.


Calling setCurrentTime when video is paused does not update currentTime (Flash runtime only)

Context: I have a set of controls which jump to a particular point of a video and pause by doing:
me.pause();
me.setCurrentTime(timestamp);

HTML5 video works fine, but Flash video does not update the progress bar or current time indicator, although the video does move to the correct point. Calling getCurrentTime either immediately, following a 'seeked' event or even after a huge timeout returns the old time.
On closer inspection this is because the events passed out of the flash player following a call to setCurrentTime (namely 'seeking', 'timeupdate' and 'seeked') all pass a time property of whatever the old time was when the video was paused in their values attribute.
On closer, closer inspection these are coming from the Flash native flash.net.NetStream object, which I lack the knowledge of Flash to debug. My thought is probably that the Flash needs to wait until the _stream.seek call in VideoElement:setCurrentTime has completed and _stream.time reflects the updated value before firing a 'timeupdate' event, but as I said, I lack the Flash knowledge to work this out myself.
For now, I can work around by waiting for the 'seeked' event, forcing the Flash to emit an event by calling pause again, then manually updating with setCurrentRail(), but obviously this is not ideal.

@lennym Is this still an issue? If not, can you close this issue, please?

@ron666 Literally no idea at all. It was opened more than 4 years ago so I don't even remember what project I was working on at the time - I'm certainly in no position to determine if it's still a problem.
Happy for you to do whatever you like with the issue though.

@lennym Thanks for the quick response; the Flash file had evolved a lot, so I would consider this issue solved. Please close, and if in the event this arises again, we can create another one.


Publish KFServing 0.5 RC0 release

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Cut first v0.5.0 RC Release

@yuzisun, We can set the tag of pmmlserver to v0.5.0-rc0 ? Thanks.

@yuzisun, We can set the tag of pmmlserver to v0.5.0-rc0 ? Thanks.

@AnyISalIn just fixed.

/lgtm


Correct the Panopticon arefact for deleted Detailed Guides

Before this fix, deleted Detailed Guides were being registered under an incorrect slug and router path.
This is a prerequisite to fix the data issue in https://trello.com/c/oku0LGNO/67-detailed-guides-which-should-be-redirecting-display-a-410-page. Once this is available, we'll be creating a data migration to republish the routes for the withdrawn detailed guides.
The routes should go to Whitehall directly so that Whitehall can perform the correct redirect.
/cc @jamiecobbett @heathd

Oh wow!!! :crying_cat_face:
:+1:  Looks good to me.

:+1: nice work, yay for unit tests


Launch error

When I run the app, I have the following error (I donn't know how to deal with that)
Creating web host
Hosting environment: Development
Content root path: C:\tmp\acssamples\communication-services-web-chat-hero\Chat
Now listening on: http://localhost:5000
Now listening on: https://localhost:5001
Application started. Press Ctrl+C to shut down.
fail: Microsoft.AspNetCore.Server.Kestrel[13]
Connection id "0HMDQC4CRTNG3", Request id "0HMDQC4CRTNG3:00000001": An unhandled exception was thrown by the application.
System.AggregateException: One or more errors occurred. (One or more errors occurred. (The NPM script 'start --max_old_space_size=4096' exited without indicating that the create-react-app server was listening for requests. The error output was:
))
---> System.AggregateException: One or more errors occurred. (The NPM script 'start --max_old_space_size=4096' exited without indicating that the create-react-app server was listening for requests. The error output was:
)
---> System.InvalidOperationException: The NPM script 'start --max_old_space_size=4096' exited without indicating that the create-react-app server was listening for requests. The error output was:
---> System.IO.EndOfStreamException: Attempted to read past the end of the stream.
at Microsoft.AspNetCore.SpaServices.ReactDevelopmentServer.ReactDevelopmentServerMiddleware.StartCreateReactAppServerAsync(String sourcePath, String npmScriptName, ILogger logger)
--- End of inner exception stack trace ---
at Microsoft.AspNetCore.SpaServices.ReactDevelopmentServer.ReactDevelopmentServerMiddleware.StartCreateReactAppServer

Happy new year! Apologies that this issue dropped through the cracks in December.
Are you still facing this error or were you able to discover what was wrong with the setup?

Closing issue due to inactivity.


Run CI tests for Windows installer too

Fixes #12

@guillaumefavelier
Running mne sys_info on Windows CI (GH Actions) fails:
2021-12-20 11:44:13.326 (   2.802s) [                ]vtkWin32OpenGLRenderWin:635    ERR| vtkWin32OpenGLRenderWindow (00000223B6CB9630): failed to get wglChoosePixelFormatARB
41
ERROR:root:failed to get wglChoosePixelFormatARB
42
2021-12-20 11:44:13.328 (   2.803s) [                ]vtkWin32OpenGLRenderWin:713    ERR| vtkWin32OpenGLRenderWindow (00000223B6CB9630): failed to get valid pixel format.
43
ERROR:root:failed to get valid pixel format.
44
2021-12-20 11:44:13.328 (   2.803s) [                ]vtkOpenGLRenderWindow.c:569    ERR| vtkWin32OpenGLRenderWindow (00000223B6CB9630): GLEW could not be initialized: Missing GL version
45
ERROR:root:GLEW could not be initialized: Missing GL version
46

Have you seen this problem before and have any idea how to fix it? Is there something like xvfb-run for Windows?

This seems to be the required fix (thanks Guillaume):
https://github.com/pyvista/pyvistaqt/blob/87bcce9d00b295134f43b5bf01b23ac37219672e/.github/workflows/ci.yml#L73-L78


issue with nemo models

Hey, I noticed a problem when using nemo models (checked only the offline variants) when the audio duration is somewhere in the 6:50 long range its crash with this error:
sequential_executor.cc:514 onnxruntime::ExecuteKernel] Non-zero status code returned while running And node. Name:'/And_1' Status Message: C:\a\_work\1\s\onnx runtime\core/providers/cpu/math/element_wise_ops.h:540 onnxruntime::BroadcastIterator::Init axis == 1 || axis == largest was false. Attempting to broadcast an axis by a dimension other than 1. 5000 by 10 279
I used version v1.10.27 and see the same crash happen in pc and in android. I added the sound files to the issue (in mp3 format because wav are too large).
sound.zip

Could you post the detailed command you are using?

By the way, for the offline models, i.e., non-streaming models, we suggest that you don't input audio more than 30 seconds.

Oh I thought that this limitation of the whispers models, this is the settings I using in android
`  FeatureConfig featureConfig = FeatureConfig.builder().setFeatureDim(80).setSampleRate(16000).build();
OfflineModelConfig modelConfig = OfflineModelConfig.builder().setModelType("nemo_transducer")
  .setTransducer(OfflineTransducerModelConfig.builder().setDecoder("nemo/decoder.onnx")
    .setEncoder("nemo/encoder.onnx")
    .setJoiner("nemo/joiner.onnx")
    .build())

  .setTokens("nemo/tokens.txt")
  .build();

OfflineRecognizerConfig config = new OfflineRecognizerConfig.Builder()
  .setOfflineModelConfig(modelConfig)
  .setFeatureConfig(featureConfig)
  .build();`

I tried others offline models too and the crash is happening only in nemo

For all non-streaming models, please don't input long audio files.
You can use VAD + ASR for long audio files. Please see

https://github.com/k2-fsa/sherpa-onnx/tree/master/android/SherpaOnnxVadAsr
https://github.com/k2-fsa/sherpa-onnx/blob/master/python-api-examples/generate-subtitles.py

With vad we can't get the correct timestamp of the words in the audio which I need, I might just split the audio to smaller chunks or something