dataset.___join_datasets() flips the resulting image upside down

something something -geotransform[5]

apparently it was not necessary to specify the bounding box when invoking gdal.warp(). Currently in dataset.__join_datasets() we just specify the x and y resolutions, copying the from the target dataset.
			aligned_dataset = gdal.Warp('', self.ds[key], format='MEM',
				xRes=geotransform[1],
				yRes=geotransform[5])

I leave the issue open until I'm able to test everything with non-perfectly-overlapping images (my current test is too good to cover all marginal cases)

reimplemented multisource support via VRT


FAI-1196 Create the Equality question 2 Asian Page

New page added for Ethnic SubGroup Asian with unit test cases included
Story: https://skillsfundingagency.atlassian.net/browse/FAI-1196

Already merged as a separate PR


Prepared for install via npm

This changes resolve #69 when git cloneing and running npm install local.
In package.json this means:
"angular2-token": "file:/local_modules/angular2-token" when /local_modules/angular2-token is the directory, where the repository is cloned into.
It does not work when installing directly from git (see npm issues) For installing via npm registry this should work, as preinstall script from package.json is used both ways - installing from local and installing from npm registry.

It seems the failling CI tests are not caused by my changes, but by some third party node modules, if I am interpreting the travis job protocols the right way.

@micdahl thanks for your PR! I gonna try to replicate your changes on my own machine.
Could you do me a favor and clean up your PR a little, so I can see what you actually changed? Thanks!

@neroniaky The important changes are:

add *.js *.map *.d.ts to .gitignore
add *.ts !*.d.ts to .npmignore
change ./src to ./lib in angular2-token.d.ts
add import { ModuleWithProviders } from '@angular/core'; in src/a2t-ui/a2t-ui.routes.ts
add "declaration": true and "dirs": ["src"] to tsconfig.json, remove "files": ... from there and add "**/*.spec.ts", "angular2-token.d.ts" to "exclude".

Hope that helps. In package.json there should be no relevant changes. Reordering was done by installing and after that removing a package via npm.

There is still something wrong... I can compile now, but there are some problems with loading...

@micdahl I guess I need to get the CI up and running first.

@micdahl I just published v0.2.0-beta.6, which includes all your suggested changes. Thanks a lot for your help!


Make non-linear lateral pid into its own tuning class (pidnl).

Make non-linear lateral pid into its own tuning class (pidnl). This makes it more suitable for being accepted upstream (one day hopefully).

P.S. I am not quite sure if changes in selfdrive/controls/lib/pathplanner.py are part of this or just generic improvement,  i.e.:
+sadBP = [0., 5., 10., 25.]
+sadV = [.3, .3, .2, .1]
[...]
@@ -163,10 +183,16 @@ class PathPlanner():
     if desire == log.PathPlan.Desire.laneChangeRight or desire == log.PathPlan.Desire.laneChangeLeft:
       self.LP.l_prob *= self.lane_change_ll_prob
       self.LP.r_prob *= self.lane_change_ll_prob
+      self.libmpc.init_weights(MPC_COST_LAT.PATH / 3.0, MPC_COST_LAT.LANE, MPC_COST_LAT.HEADING, self.steer_rate_cost)
+    else:
+      self.libmpc.init_weights(MPC_COST_LAT.PATH, MPC_COST_LAT.LANE, MPC_COST_LAT.HEADING, self.steer_rate_cost)
+
     self.LP.update_d_poly(v_ego)

+    sad = interp(v_ego, sadBP, sadV)
+
     # account for actuation delay
-    self.cur_state = calc_states_after_delay(self.cur_state, v_ego, angle_steers - angle_offset, curvature_factor, VM.sR, CP.steerActuatorDelay)
+    self.cur_state = calc_states_after_delay(self.cur_state, v_ego, angle_steers - angle_offset, curvature_factor, VM.sR, sad)


General: Allows instructors exporting users' information from a course

Checklist
General

[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.

Motivation and Context

The users' window in a course just allows importing new users' (Students, Tutors, Editors, and Instructors) and their information from a CSV file. It is not possible to export the same information such as Name, Username, Email, and Registration number from the users.
Description

A new "Export as CSV" button is added to download the list of the users with their information {name, userName, Email, Registration Number} in a CSV file.

Steps for Testing

Prerequisites:

1 Instructor
1 Course with at least one registered student

Review Progress

Log in to Artemis
Navigate to Course Management
Get in a course
Open any users' window (Students, Tutors, Editors, or Instructors)
Check if the new button "Export as CSV" allows you to download the list of these users {name, userName, Email, Registration number} in a CSV file.

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[x] Test 1
[x] Test 2

Test Coverage

Screenshots

"Export as CSV" button on the right-up

I like the feature. Could you export the registration number as an additional column in the CSV as well and just leave it blank in rows where it is not available?
I added a few inline comments where I think the code style can be improved a bit. Additionally, unit tests should be added. An example for testing a similar CSV export can be found in src/test/javascript/spec/component/grading-system/grading-system.component.spec.ts (lines 736ff).


Website Content: Carbon Migration Guide

Work with @joshblack to integrate his dev migration content from the individual repos into the website.
To-do

[ ] Update Design Kit section of Migration page to support new sync method
[ ] Token migration guidance (type)
[ ] Hide links to Component repos from Migration page until GA
[ ] Confirm that comprehensive migration guides are available on all relevant repos
[ ] Add link to @ carbon/icons repo to Icons section
[ ] Add link to @ carbon/themes repo to themes section
[ ] Follow up on UI Shell migration guide for developers (who is owning this?)
[ ] Make it explicit that pages should be redesigned to use the new grid

Just to clarify, there does not exist migration content yet as we don't know what's been put in the release officially. I think we know for certain that we'll have to create migration docs for the following projects/use-cases:

Carbon Elements

Need to help sponsor users migrate over to the new elements package
Need to help carbon-icons users migrate over to @carbon/icons and sibling packages

Carbon Components React

Will need to provide help to migrate to @carbon/icons as the <Icon> component will most likely be deprecated (once again, not sure)
Other content TBD based on release

Carbon components

Will need migration guides for each component that has changed meaningfully since the previous release
Other content TBD based on release

Carbon icons

Will need to deprecate and offer a guide towards moving to @carbon/icons

Starter content for this page is ready in a first draft. All of the above details will be incorporated as they become available.

title: Migrating to Carbon X

Intro
Rollout Plan
Design Kit
Tokens
Icons
UI Shell
Migration Tooling

Carbon X is near!
Carbon X, aka v10, is currently in Alpha release. Please use this opportunity to explore and experiment with the new components, elements, layouts, and UI shell. The Alpha release is a work in progress; changes will be frequent and possibly breaking. This release is not approved for production. Please explore the system and provide bountiful feedback!
Rollout Plan

January 2019: Beta release
March 2019: Production release

Adoption and Activation Sessions
The IBM Design core team is establishing an adoption and activation program. A new IBM Design Essentials course is available, and teams will receive either in-person or remote education before the Production release of Carbon X. The Carbon team will share news on Slack, Connections, and in the IBM Design Town Hall as well.
Design Kit
The Beta release of Carbon X will arrive with a completely revised Sketch design kit, updated for the new IBM Design Language (f.k.a. "Duo"). All components in the kit have been reskinned, and colors, icons, typrography, UI shell, and grid elements will also reflect the new IBM Design Language.
Tokens
The type token architecure has been redesigned for better clarity and flexibility in v10. More detailed guidance on migrating to the new type tokens will be available in early 2019.
The color token architecture for v10 is based on the v9 architecture, with some minor updates for the new design language. Carbon v9 users will see automatic, non-breaking color updates when they upgrade to v10.
Spacing tokens will see no change from Carbon v9.
Icons
The iconography in Carbon X has been completely redesigned to align with the new IBM Design Language.
Coming soon: Carbon X icon migration guide for developers
UI Shell
The basic UI shell has been completely redesigned for Carbon X. Full documentation on the new shell is available on the Carbon website.
Coming soon: Carbon X UI shell migration guide for developers
Migration Tooling
When Carbon X reaches its Production release, specific developer tooling (custom scripts) will be available to help automate the transition. Stay tuned for updates!

Link to master boxnote: https://ibm.box.com/s/1kuhb60j1bz616ly6olk7g0rqvi7gbm5

New Info Architecture

Monday preview: https://deploy-preview-1280--carbon-website.netlify.com/updates/migration/overview

@designertyler @connor-leech can this be closed or are there still outstanding items?


IFU-main-03-03

Draft PR for IFU
Passes on:
release/1.13 - http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels_freestyle/325/
release/1.12
http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels_freestyle/313/
http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels_freestyle/314/
release/1.10.1 - http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels_freestyle/320/
Conflicts emerge from the install_rocm_magma changes, build-rocm.sh and the earlier change to install_conda.sh tto use ./
conflicts.txt

Passes on:
release/1.13 - http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels_freestyle/325/
release/1.12
http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels_freestyle/313/
http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels_freestyle/314/
release/1.10.1 - http://rocmhead.amd.com:8080/job/pytorch/job/manylinux_rocm_wheels_freestyle/320/

Closed as later IFU in progress https://github.com/ROCmSoftwarePlatform/builder/pull/25


Display relative/full path of workspaces in Workspace Sidebar

When searching from a home folder down through subfolders, multiple workspaces with the same name may exist.
This results in multiple workspaces with the same name in the Workspaces Sidebar. The only way to distinguish between them is to open the workspace and check what's inside.
It would be nice if the relative path from the home folder to the workspaces could be displayed, alternatively to showing just the workspace name. This would improve usability a lot when working with multiple tags/branches which each contain a workspace of the same name.

Added in v1.1.7
See: https://github.com/sketchbuch/vsc-workspace-sidebar/pull/7

I may optimise this in the next release to remove the folder path from the path displayed ("~/Dev" in the above screenshot). For now though this is hopefully sufficient.


Import/export tests don't cover Google

As far as I can tell the G job store isn't mentioned as the "other" job store in the tests.

@JakeNarkizian , Do you address this in any of your open PRs?
If so,  their description should mention this. If not, the fix is a one-liner, right? It won't have an effect of the build since Google and Azure are disabled right now via @experimental but I want to get this out of the way. Can you just include it in the clean PR. Separate commit obviously.


Bug: Cropping corrupts the image

I am using cropImage:
predlabel = cropImage(predlabel, predlabel, max(predlabel))
At this stage predlabel can be plotted, but it is already corrupt:
"> predlabel
antsImage
Pixel Type   : float
Pixel Size   :
Dimensions   : 32x49x38
Voxel Spacing: 2x2x2
Origin       : -93 138.1172 -82
Direction    : 1 0 0 0 -1 0 0 0 1
> predlabel[15,15,15]
index not inside the image : [14, 14, 14]
[1] NA"
After cropping, resampleImage is performed (within mrvnrfs, but I tried manually as well). There is no error but resampleImage produces a corrupt image, it cannot be plotted and getNeirghborhoodInMask is a matrix with 0 columns.
Cropping works fine if I use traditional code:

ttt2 = as.antsImage(as.array(predlabel)[20:80, 30:100, 1:84])
> ttt2[15,15,15]
, , 1

 [,1]

[1,]    0

plot(ttt2)
NULL
ttt3=resampleImage(ttt2, rep(4,3), 0, 1)
plot(ttt3)
NULL

as usual - need a reproducible example
brian
On Mon, Mar 16, 2015 at 10:52 AM, dorianps<EMAIL_ADDRESS>wrote:

I am using cropImage:
predlabel = cropImage(predlabel, predlabel, max(predlabel))
At this stage predlabel can be plotted, but there is already corrupt:

predlabel[15,15,15]
index not inside the image : [14, 14, 14]
[1] NA

After cropping, resampleImage is performed (within mrvnrfs, but I tried
manually as well). There is no error but resampleImage produces a corrupt
image, it cannot be plotted and getNeirghborhoodInMask is a matrix with 0
columns.
The image, however, works fine if I use traditional code:
ttt2 = as.antsImage(as.array(predlabel)[20:80, 30:100, 1:84])

ttt2[15,15,15]
, , 1

[,1]
[1,] 0
plot(ttt2)
NULL
ttt3=resampleImage(ttt2, rep(4,3), 0, 1)
plot(ttt3)
NULL
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTsR/issues/28.

https://www.dropbox.com/s/umhio3bp1npu1x5/predlabel.nii.gz?dl=1
predlabel=antsImageRead('predlabel.nii.gz', 3)
predlabel = cropImage(predlabel, predlabel, max(predlabel))
predlabel[15,15,15]

here is an example
fi <- antsImageRead(getANTsRData("r16"), 2)

fi <- antsImageRead(getANTsRData("r16"), 2)

cropped[1,1]

cropped[128,128]

this is the expected behavior because 1,1 is not in the image anymore ... after resampling, though, there is an issue but it's not clear how to resolve this "perfectly" b/c indices and physical space dont match exactly. what needs to be done is that the function SetOutputStartIndex in ResampleImageFilter
http://www.itk.org/Doxygen316/html/classitk_1_1ResampleImageFilter.html#a1f09112c98d174394f8a9dba8d2e1c0
needs to be set correctly ... not sure how to resolve that.   So, this needs to be dealt with here:
https://github.com/stnava/ANTs/blob/master/Examples/ResampleImage.cxx#L244
@ntustison  ... any thoughts re: how to define this?

i've learned more about this ... no resolution but here is an interesting example:
fi <- antsImageRead( getANTsRData("r16") ,2)
cropped <- cropImage( fi )
rcropped<-resampleImage( cropped, dim(cropped)/2, 1 , 0 )  # not correct ( i think )
antsImageWrite( cropped , '/tmp/crop.nii.gz')
cropread<-antsImageRead("/tmp/crop.nii.gz")
rcropped2<-resampleImage( cropread, dim(cropped)/2, 1 , 0 ) # correct

these produced different results but should not ... @jeffduda @ntustison  - any insight / guesses?

This behavior is somewhat confusing, as this is the only case I'm aware of
where indexing an antsImage doesn't work like indexing an array, and as far
as I can tell there's no way to tell where the indexing starts.  Should we
at least make it possible to see where the indexing begins?
2015-03-16 16:47 GMT-04:00 stnava<EMAIL_ADDRESS>
i've learned more about this ... no resolution but here is an interesting
example:
fi <- antsImageRead( getANTsRData("r16") ,2)
cropped <- cropImage( fi )
rcropped<-resampleImage( cropped, dim(cropped)/2, 1 , 0 )  # not correct ( i think )
antsImageWrite( cropped , '/tmp/crop.nii.gz')
cropread<-antsImageRead("/tmp/crop.nii.gz")
rcropped2<-resampleImage( cropread, dim(cropped)/2, 1 , 0 ) # correct
these produced different results but should not ... @jeffduda
https://github.com/jeffduda @ntustison https://github.com/ntustison -
any insight / guesses?
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTsR/issues/28#issuecomment-81928221.

that (albeit correct) behavior is a separate issue ... but one reason that
this is difficult to debug is because i cant (or dont know how to) see the
startindex for this image .... this can be accessed via:
image->GetLargestPossibleRegion().GetIndex()
or ( better but doesnt always work right )
image->GetRequestedRegion().GetIndex()
there probably should be an r interface implemented for this ...
the only reason this has not come up previously is that the StartIndex is
usually zero for itk images ... but not always (obviously).
brian
On Mon, Mar 16, 2015 at 4:57 PM, bkandel<EMAIL_ADDRESS>wrote:

This behavior is somewhat confusing, as this is the only case I'm aware of
where indexing an antsImage doesn't work like indexing an array, and as far
as I can tell there's no way to tell where the indexing starts. Should we
at least make it possible to see where the indexing begins?
2015-03-16 16:47 GMT-04:00 stnava<EMAIL_ADDRESS>
i've learned more about this ... no resolution but here is an interesting
example:
fi <- antsImageRead( getANTsRData("r16") ,2)
cropped <- cropImage( fi )
rcropped<-resampleImage( cropped, dim(cropped)/2, 1 , 0 ) # not correct
( i think )
antsImageWrite( cropped , '/tmp/crop.nii.gz')
cropread<-antsImageRead("/tmp/crop.nii.gz")
rcropped2<-resampleImage( cropread, dim(cropped)/2, 1 , 0 ) # correct
these produced different results but should not ... @jeffduda
https://github.com/jeffduda @ntustison https://github.com/ntustison

any insight / guesses?
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTsR/issues/28#issuecomment-81928221.

—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTsR/issues/28#issuecomment-81935510.

ok - i changed this behavior to use the origin rather than the index
fi <- antsImageRead( getANTsRData("r16") ,2)
cropped <- cropImage( fi )
d1<-decropImage( cropped , fi)
rcropped<-resampleImage( cropped, dim(cropped)/2, 1 , 0 )
upsam<-resampleImage( rcropped, dim(cropped), 1, 0 )
d2<-decropImage( upsam, fi )

the above shows "invertible" cropping resampling and decropping
not sure if this will fix other issues but it seems more consistent ....

Relevant to this conversation, I enabled indexing of antsImages without
explicit indices, so something like img[2, , ] will get the second slice of
an image.  This returns a matrix or array, not an antsImage, but if you
just need the voxel values you can use it.
2015-03-16 17:52 GMT-04:00 stnava<EMAIL_ADDRESS>
ok - i changed this behavior to use the origin rather than the index
fi <- antsImageRead( getANTsRData("r16") ,2)
cropped <- cropImage( fi )
d1<-decropImage( cropped , fi)
rcropped<-resampleImage( cropped, dim(cropped)/2, 1 , 0 )
upsam<-resampleImage( rcropped, dim(cropped), 1, 0 )
d2<-decropImage( upsam, fi )
the above shows "invertible" cropping resampling and decropping
not sure if this will fix other issues but it seems more consistent ....
—
Reply to this email directly or view it on GitHub
https://github.com/stnava/ANTsR/issues/28#issuecomment-81957671.


Support passing --disable-html5-mode on the command line

A more general solution for the other options would be nice, but this covers what I need right now.

Thank you! Could you change the target of this PR to dev. master is used for NPM releases.

I made PR from your branch against dev in https://github.com/SC5/sc5-styleguide/pull/596.


Fix launcher script

Fixed launcher script and update some wrong instructions in README
Fixes #2

Im fixing it at the moment

Nice, I had already forgotten about this PR


Refactor and implement new OpenGL commonly used functionality

OpenGL Buffer classes should be refactored (currently they break SOLID principles).


Respect useLineBreaks for union/intersect toString

This change makes Luau::toString() on a union or interesection type respect the useLineBreaks option in ToStringOption.
This mostly comes up in large function type intersections. For example for the type of game:GetService:
((self: ServiceProvider, service: "ABTestService") -> ABTestService) & ((self: ServiceProvider, service: "AdService") -> AdService) & ((self: ServiceProvider, service: "AnalyticsService") -> AnalyticsService) & ((self: ServiceProvider, service: "AnimationClipProvider") -> AnimationClipProvider) & ((self: ServiceProvider, service: "AnimationFromVideoCreatorService") -> AnimationFromVideoCreatorService) & ((self: ServiceProvider, service: "AnimationFromVideoCreatorStudioService") -> AnimationFromVideoCreatorStudioService)... <TRUNCATED>

Is now formatted as
((self: ServiceProvider, service: "ABTestService") -> ABTestService)
& ((self: ServiceProvider, service: "AdService") -> AdService)
& ((self: ServiceProvider, service: "AnalyticsService") -> AnalyticsService)
& ((self: ServiceProvider, service: "AnimationClipProvider") -> AnimationClipProvider)
& ((self: ServiceProvider, service: "AnimationFromVideoCreatorService") -> AnimationFromVideoCreatorService)
& ((self: ServiceProvider, service: "AnimationFromVideoCreatorStudioService") -> AnimationFromVideoCreatorStudioService)... <TRUNCATED>

Which makes this much nicer to read.
The equivalent is done for union operations.

Example when used in VSCode hover string

I realise that I think this toString operation is used internally for Studio's hover string. So I understand if this is undesirable behaviour / conflicts with studio internally (given that its the introduction of a lot more vertical space).

I'm also interested in slightly modifying the output of TableTypeVar's when using useLineBreaks
Currently a newline is not inserted after the opening brace and before the first field (and similarly after the last field and before the closing brace).
Would you be happy accepting a change to this upstream? Again I realise its an introduction of a bit more vertical space. Will open a PR if so

 Example of a before and after
local ATM: { Destroy: (self: any) -> (...any),
    __index: any,
    new: (base: any, store: any) -> (...any) }

will be modified to look like:
local ATM: {
    Destroy: (self: any) -> (...any),
    __index: any,
    new: (base: any, store: any) -> (...any)
}


Question: Hide menu bar?

I've looked through the open issues and searched the closed ones and didn't see anything mentioning this, is there a way to hide the menu bar I can't find? It's particularly distracting when using the mini player in my opinion.

You are on master :+1:
It is unstable :+1:
This will be fixed soon :+1:

:+1:

:+1:


Cannot use pop on a ModelOutput instance. (transformers)

Hi, I had a problem. When I run the file I get an error:
File "/usr/local/lib/python3.10/dist-packages/transformers/utils/generic.py", line 376, in pop
raise Exception(f"You cannot use pop on a {self.class.name} instance.")
Exception: You cannot use pop on a ModelOutput instance.
I saw here on GitHub that some ppl solve this by downgrading the transformers library at version 4.23.0, but when I try to do the same thing I get an error on installation:
ERROR: Failed building wheel for tokenizers
Failed to build tokenizers
ERROR: Could not build wheels for tokenizers, which is required to install pyproject.toml-based projects
Any ideas?
I saw on the internet that some ppl solve this by installing rust, but I get the same error.
Thanks

Hi, all, I'm facing the same problem as above..
If anyone has found a fix, please update 👍

Hi, @SakshamDhawan one method that you will find here  is to downgrade transformers
pip uninstall transformers
pip install transformers==4.23
and install it with this version, but for me after this i got an error with tokenizer(you cand see my comment in linke above) and i manage to solve all of this by using python 3.10 or 3.9.x but not python 3.11. Just create a new env and it should be ok.

I encountered the same issue. May I ask if you have already solved it?


Feat: Embedded Resource Component

PR for this issue: https://github.com/BeaconCMS/beacon/issues/349

Hey @edborsa just a friendly ping. The code is looking code but there are some conflicts :)


Bug Fix: IPv6 Address gets truncated to first 4 characters

Fix Issue #2521
Changes
NETCORE ClientIpHeaderTelemetryInitializer allow parsing of IPv4 and IPv6 addresses from the headers. The resulting IP requestTelemetry.Context.Location.Ip will not include a port number.
Checklist

[x] I ran Unit Tests locally.
[x] CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

[ ] Design discussion issue #
[ ] Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:

FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

We support comment build triggers

/AzurePipelines run will queue all builds
/AzurePipelines run <pipeline-name> will queue a specific build

Should a similar change be made to the WEB version of ClientIpHeaderTelemetryInitializer ?

Should a similar change be made to the WEB version of ClientIpHeaderTelemetryInitializer ?

Yes, i think so :)

TODO

Add failing test cases for non-IP addresses like a URL or other
Make similar change to WEB version of the same class and unit tests


bump version to 0.2.0

Why are these changes needed?
For release.
Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6087b5a) 27.69% compared to head (e284b9b) 27.62%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
- Coverage   27.69%   27.62%   -0.08%
==========================================
  Files          27       27
  Lines        3466     3479      +13
  Branches      784      788       +4
==========================================
+ Hits          960      961       +1
- Misses       2434     2446      +12
  Partials       72       72

Flag
Coverage Δ

unittests
27.62% <100.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi all, I plan to release v0.2 after this PR is merged as users have been asking. Please let me know if there is any breaking change you are working on and would like to hold the release.


logging: should have proper error message on protocol errors

when a clients gets disconnected because of invalid mqtt headers, verne should log something in a way that let's us understand the reason.

Absolutely.
We'll take this as a +1 and motivation on adding detailled DEBUG logging.
Thanks @aep!

As a preliminary info: Currently the parser makes the following errors explicit with debug logging enabled.
cant_parse_fixed_header
unknown_protocol_magic
invalid_rest_of_binary
cant_parse_variable_header
cant_validate_last_will_topic
cant_parse_username
username_flag_not_set
cant_parse_password
no_topic_provided
cant_parse_topics


The state of SQL detection

Problem
Linguist's detection of languages in the SQL family is currently quite inconsistent. The classifier seems to be quite biased towards PL/pgSQL, classifying a lot of SQL variants as PL/pgSQL (examples: mysql, oracle). This has been the subject of a few issues before: SQLite vs PLpgSQL, MySQL vs PLpgSQL, TSQL vs PLSQL or  TSQL vs PLpgSQL, PLpgSQL vs SQLPL.
Furthermore, current heuristics for the .sql extension seem to imply that PostgreSQL' dialect of SQL is PL/pgSQL, IBM DB2's dialect is SQL PL and Oracle's dialect is PL/SQL. But neither of these are true. All of them are extensions to SQL included that are just a subset of their SQL dialect. In practice, most PostgreSQL code out there does not use PL/pgSQL at all.
It is a bit tricky to disambiguate properly between all of them, but I think we should change towards falling back to SQL more often.
Possible Solutions
I'm not sure what's the best course of action, but I think it could include some of the following options. I will go ahead and create PRs for some of them, but I'd like to hear your opinions on the bigger picture.
Heuristics fallback to SQL, no classifier
We currently have a very broad expression to trigger the classifier, as the final rule for .sql:
https://github.com/github/linguist/blob/2a6d952df870807034c3830738f95ad33222aca0/lib/linguist/heuristics.yml#L459-L461
Any of these strings may appear in virtually every SQL dialect. In particular BEGIN, which is standard SQL. Given that it is unlikely that the classifier does well here, it may be better to just fall back to SQL:
  # Fallback to SQL
  - language: SQL

After all, seeing some PL/pgSQL code classified as SQL should not be that surprising. However, seeing it as PL/SQL, SQL PL or T-SQL is much more misleading.
Changes:

[x] .sql falls back to SQL #4888

Remove all patterns that are not exclusive to one SQL dialect
Reinforcing the previous point, we may remove all patterns that are not exclusive to one language. For example, the following statement, which is valid MySQL, is currently classified as T-SQL by the heuristics:
SELECT IF TRUE 1 ELSE 2 END IF;

And the following is classified as PL/SQL:
SELECT SYSDATE();

Changes in this direction:

[x] Relax T-SQL #4885 #4913
[x] Relax PL/SQL #4886
[x] Relax SQL PL #4887

Remove all patterns that are not exclusive to one PL
Stop considering any PostgreSQL as PL/pgSQL, Oracle as PL/SQL, etc. For example, I think that Oracle's XMLType is not necessarily part of PL/SQL, just part of the broader Oracle SQL.
Create a language group for SQL
Ok, maybe this is too extreme, but given the amount of misclassifications, it could even make sense to create a language group for SQL?
Create a specialized strategy
Create a specialized strategy for SQL dialect detection, with more advanced parsing than just regexps. Probably tons of work.

Given that it is unlikely that the classifier does well here, it may be better to just fall back to SQL:

Looks good to me :+1:

Ok, maybe this is too extreme, but given the amount of misclassifications, it could even make sense to create a language group for SQL?

Yeah, that seems reasonable to me if we can't find an efficient way to distinguish between all SQL variants.
Let's involve peeps who contribute all the SQL variants in the discussion. /cc @Shoelace contribute most of the variants, @beau-witter contributed the T-SQL variant.

This all seems reasonable to me. SQL does seem like a tough nut to crack and while i do agree that SQL should be used as a fall back more often (better to classify a square as a rectangle than misidentify a rectangle as a square), it will be unpleasant to not have the syntax highlighting you expect when viewing the file in the webapp. That last part may not be solvable currently and it is certainly outside the scope here, just wanted it said. =D

This issue is still relevant because SQL code still gets dis-detected.

@iomintz Could you post some examples of mis-detected SQL?

The examples you gave in your OP still hold.

@iomekam There's a pending PR (#4888) that should fix many issues. If you have any specific examples with URLs to files you are interested in, I can look into them.

#4888 has been merged. Can this be closed?

@pchaigno Yes, I think so. There is still the open question about creating a language group for SQL. Maybe we could reconsider this depending on follow up issues in the months after v7.11.0 deployment at GitHub?

Maybe we could reconsider this depending on follow up issues in the months after v7.11.0 deployment at GitHub?

:+1:

sorry i'm a bit late.. but i am happy with all of the merged changes.
i agree that error on the side of  generic SQL is preferable to choosing a wrong dialect.


Token not found

I have used slim-jwt-auth in my api. It works fine on localhost and on testing server but on production vps server, it shows token not found.
Htaccess for the VPS server is modified to support Http:authorization
RewriteRule .* - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}]

Header set Access-Control-Allow-Origin "*"
Header set Access-Control-Allow-Methods "GET, POST, PUT, DELETE, OPTIONS"
Header set Access-Control-Allow-Headers "Content-Type, Authorization"

Am I missing something?

Quickly looking everything looks ok. First I would test by doing the request using curl to make sure you are actually sending the token. Do not use Postman or anything similar, with curl you can be sure what kind of  request is made.
$ curl "https://example.com/foos" \
    --request GET \
    --include \
    --insecure \
    --header "Authorization: Bearer $TOKEN"

If token is really sent I would then start to debug why live server does not see it: print_r(apache_request_headers()), print_r($_SERVER) etc.

I tried
SetEnvIf Authorization "(.)" HTTP_AUTHORIZATION=$1
instead of
RewriteRule . - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}]
and it is working now.
Thanks


Unable to import json resume

Thanks for the wonderful website.  Noticed that I first logged in anonymously, prepared a resume, exported it as a pdf and json. Later i switched to login via my google account and attempted to import the json resume. The  screen went black for a while and nothing happened. Hence reporting this.  Is there a work around to get back to having my prepared resume on my google account or need to fill in everything from scratch.
Thank you.

@codefeast  I had same issue today. I opened Chrome console and noticed there is an issue with js.

I don't guess this is won't be fixed quickly. I suggest filling again.

Closing this in favor of Reactive Resume v3 release.
If you continue to face this issue, please raise a new one and I'll have a look at it as soon as I can.
In the meantime, if you are able to, please consider donating to keep supporting the project: https://www.buymeacoffee.com/AmruthPillai :)
Thank you!


Updating guinget to v<IP_ADDRESS>.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

hold up 🤦♂

Oh, right, I forgot they can't be together. I'll revert it, unless it really needs to have some changes but still be single-file. Was planning on changing to multi-file in the next version due to a few things.

Just do whatever you feel comfortable with, since the installer actually contains a user/machine switch i would say its sorta important, but i don't actually know if winget upgrade installs the specific scope, but i like to be on the safe side

Ended up going back. Thought winget would just have a way to install per-user or for the machine without having to specify it as different entries. Next version will be multi-file since, as stated, the installer has a per-user option.

 Manifest is invalid. (Line: 2, Col: 11, Idx: 49) - (Line: 2, Col: 11, Idx: 49): While scanning a plain scalar value, found invalid mapping.
wot we broke winget bot
Also you can specify if you want user or machine install in the winget settings or with winget install --scope

Looks like that error was from spaces that weren't supposed to exist. Forgot about the scope and setting. Per-user and per-machine isn't something I really do much with, but it may be useful in some cases.


Additional content to thermodynamic integration method

Hi,
I've been doing a bit of work in gravitational wave astronomy to use emcee_pt (and in the future pt_emcee) in PyCBC. Specifically, I'm interested in developing the thermodynamic integration method.
https://github.com/willvousden/ptemcee/blob/master/ptemcee/util.py#L97
There's been a bit of work in the statistics literature to try to make numerical estimations of the integral more accurate.
(Silia Vitoratou and Ioannis Ntzoufras 2013) [https://arxiv.org/pdf/1308.6753.pdf] and (Calderhead and Girolami, 2009) [https://core.ac.uk/download/pdf/80850.pdf] provide a method for giving the correction to the trapezoidal rule for estimating the marginalized likelihood in TI.
They use the Kullback-Liebler Divergence (https://en.wikipedia.org/wiki/Kullback–Leibler_divergence) to give the correction factor to the trapezoidal rule for discretization error.
Additionally, they identify another source of error in the TI numerical integral that comes from MCMC variance. The only place that I've yet seen a way to estimate the MCMC error for TI is listed in  (Jeff Annis and Nathan Evans 2018)[https://psyarxiv.com/r8sgn/], see equations 35 - 37. This source of error for TI isn't accounted for in the current module.
Would you all be interested in making some of these additions or in me putting in a pull request to incorporate these results?

Additionally, I'd like to add the stepping-stone algorithm which uses the same multi-tempered log likelihoods to compute the evidence (and seems to match TI very well). So, I can make a pull request for that if people are interested.

As a user of this package, I am definitely interested in seeing this additions made

Good.

@stevereyes01 how is progress with implementing these features in ptemcee? Or should I switch to pycbc?

Hi @ljschumacher , I haven't heard back from anyone in ptemcee. You can use the module in https://github.com/gwastro/pycbc/blob/master/pycbc/inference/evidence.py for calculating the evidence for a model using thermodynamic integration or steppingstone algorithm. There are some nuances to what I wrote there. Though using those modules is a bit hardcoded to the emcee_pt file formatting. If you want to discuss that we should open a thread else-where.
I'm going to close this issue since it's not gotten any attention in > 10 months.


Add more examples to go/* packages

It can be hard to figure out how to use the go/* packages. More examples will help.
Coming up with useful, short examples that demonstrate these packages well will be hard and ongoing and probably require some discussion, hence this meta-issue.
A complimentary wiki page (what would a good name for this page be?), in the vein of https://github.com/golang/go/wiki/cgo , would be helpful for larger or more complicated examples, some notes about when to use which package, links to helpful packages in golang.org/x/tools/go, and for various tips and tricks, but having playable examples of the basics will be very helpful.
Related issue: #23603 so that examples can rely on go/parser and go/build can still be playable even if they hit the fs. I think this should be okay with the following rules:

self contained example should be preferred.
the example can only parse files in its own package (to avoid unrelated changes breaking them)
the files accessed in the example must be included regardless of build tag (so that they're always easily reachable from the "Package files" section in godoc)
the example should rely only on features under the Go 1 compatibility agreement (to avoid having to be updated when the package itself is changed)

Here are some potential examples to include:
An example in go/parser that uses go/build and ParseDir to get the *ast.Package given an import path. (This seems to be a common stumbling block, in my experience).
Some examples in go/constant using BinaryOp and Compare and some of the conversions/constructors.
An example in go/token of using the FileSet to turn a Pos into a Position.
Based on s/owners, cc: @griesemer @alandonovan @rsc @robpike

go/constant is mostly intended as a utility package for go/types. But I agree that go/types constant results may require post-processing that could use some examples.

I've done such postprocessing before. I'll see if I have anything that can be adapted into examples or at least give me an idea for some good example.

I was looking at the extant examples in go/types.
In addition to #23095, the other two examples use importer.Default which don't work on the playground and won't even with  #23603. It looks like they could be changed to use the source importer without any further change. I'll play with those and send a CL if there are no regressions.
I went through the other examples to make sure everything else was running smoothly.
The example in go/printer is not runnable but looks like it will be with once both #23095 and #23603 are resolved.
The example in go/format is not runnable. It is not clear to me why it is not. However, it also should be in an external test file per #11257 and putting it in one makes it runnable, so I'll send a CL.


[TF1.14][TPU]Can not use custom TFrecord dataset on Colab using TPU

I have created a TFRecord dataset file consisting elements and their corresponding labels. I want to use it for training model on Colab using free TPU. I can load the TFRecord file and even run an iterator just to see the contents however, before the beginning of the epoch it throws following error-
UnimplementedError: From /job:worker/replica:0/task:0:
File system scheme '[local]' not implemented (file: '/content/gdrive/My Drive/data/encodeddata_inGZIP.tfrecord')
	 [[{{node MultiDeviceIteratorGetNextFromShard}}]]
	 [[RemoteCall]]
	 [[IteratorGetNextAsOptional_1]]

In my understanding, it wants the TFRecord file on the TPU bucket, I don't know how to do that on Colab. How can one use a TFRecord file directly on Colab TPU?

@rishabhsahrawat ,
Thanks for reporting the issue, Can you please provide a simple standalone code to reproduce the issue  or share us your colab gist. Also mention the TF version being used.Thanks!

HELLO @oanush , here is the Colab file link.
Please have a look and help me as soon as possible. Thank you!

Issue replicating for TF-1.14.

Hello @ymodak @oanush , any updates on this?. It is a major issue but no one is responding. Please  help me with this issue or just share a time window for which I must wait.
Thank you!

Hello! Yeah, we don't allow local filesystem access on TPUs right now, and we recommend that you read and write checkpoints and other files on GCS. See our MNIST on TPU colab for an example.
With future TensorFlow and TPU releases (2.1+), you will be able to use the ram:// file system to write temporary files that you don't need to access.

Hello @frankchn , thank you for your response. In your example link for MNIST data, it uses GCS bucket for storing image and label files, but I do not have a GCS bucket since I am using Google Colab free TPU or, maybe there is a way for free users to access and load the data to GCS.
Also, you talked about Checkpoints, checkpoints will be created once the model starts training which will require the dataset first.
So, my question is if there is a way I can use my TFRecord data directly to train a model on Colab using TPU?

@rishabhsahrawat Unfortunately you have to use GCS to store data going into and out of TPUs. This is a current design limitation for the platform that we are working to resolve, but we don't have anything to announce at the moment.
You can sign up for a Google Cloud Platform account with 5GB of free storage and $300 in credits at https://cloud.google.com/free/, so that should be able to provide you with enough credits to get started.

@frankchn alright, thank you for your answer.


bug: Dashboard crashes when the width of the terminal is smaller than the specified width for the dashboard

Did you check docs and existing issues?

[X] I have read all the snacks.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of snacks.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.2
Operating system/version
Linux 6.11.7
Describe the bug
If I set the default width for the dashboard to a value greater than the size that the screen can be rendered in (width = 100), the plugin crashes:
Error detected while processing UIEnter Autocommands for "*":
Error executing lua callback: ...cal/share/nvim/lazy/snacks.nvim/lua/snacks/dashboard.
lua:549: table index is NaN
stack traceback:
        ...cal/share/nvim/lazy/snacks.nvim/lua/snacks/dashboard.lua:549: in function '
layout'
        ...cal/share/nvim/lazy/snacks.nvim/lua/snacks/dashboard.lua:660: in function '
update'
        ...cal/share/nvim/lazy/snacks.nvim/lua/snacks/dashboard.lua:211: in function '
open'
        ...cal/share/nvim/lazy/snacks.nvim/lua/snacks/dashboard.lua:1047: in function
'setup'
        ...s/.local/share/nvim/lazy/snacks.nvim/lua/snacks/init.lua:126: in function <
...s/.local/share/nvim/lazy/snacks.nvim/lua/snacks/init.lua:123>

Steps To Reproduce

Update the default width to 100 and quit Neovim
Resize the window terminal. I set the width of my terminal to half that of my computer monitor (1920x1080)
Start Neovim

Expected Behavior
I think dashboard.nvim resolved this by just cutting out the edges on the header when it was overflowing.
Repro
return {
  "folke/snacks.nvim",
  lazy = false,
  opts = function()
    local logo = [[
 _____                                                                                _____
( ___ )                                                                               ( ___ )
 |   |~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|   |
 |   | ███████╗ ██████╗ ██████╗██╗     ███████╗███████╗        █████╗     ██╗ ██████╗  |   |
 |   | ██╔════╝██╔════╝██╔════╝██║     ██╔════╝██╔════╝       ██╔══██╗██╗███║██╔═████╗ |   |
 |   | █████╗  ██║     ██║     ██║     █████╗  ███████╗       ╚██████║╚═╝╚██║██║██╔██║ |   |
 |   | ██╔══╝  ██║     ██║     ██║     ██╔══╝  ╚════██║        ╚═══██║██╗ ██║████╔╝██║ |   |
 |   | ███████╗╚██████╗╚██████╗███████╗███████╗███████║██╗     █████╔╝╚═╝ ██║╚██████╔╝ |   |
 |   | ╚══════╝ ╚═════╝ ╚═════╝╚══════╝╚══════╝╚══════╝╚═╝     ╚════╝     ╚═╝ ╚═════╝  |   |
 |___|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|___|
(_____)                                                                               (_____)
   ]]

    local keys = {
      { icon = " ", key = "f", desc = "Find File", action = ":lua Snacks.dashboard.pick('files')" },
      { icon = " ", key = "s", desc = "Restore Session", section = "session" },
      {
        icon = " ",
        key = "c",
        desc = "Config",
        action = ":lua Snacks.dashboard.pick('files', {cwd = vim.fn.stdpath('config')})",
      },
      { icon = "󰒲 ", key = "L", desc = "Lazy", action = ":Lazy", enabled = package.loaded.lazy },
      { icon = " ", key = "q", desc = "Quit", action = ":qa" },
    }

    return {
      dashboard = {
        width = 100, -- This is the value I changed, if I set it to 60 then it does not crash
        enabled = true,
        pane_gap = 1,
        preset = {
          header = logo,
          keys = keys,
        },
        sections = {
          { section = "header" },
          { section = "keys", padding = 1, gap = 1 },
          { section = "startup" },
        },
      },
    }
  end,
}

Should be fixed now. Thank you for reporting.

Thank you!


[OSC-1301] Add summary logging

https://pageuppeople.atlassian.net/browse/OSC-1301

replaced by #34


Integrating Pylint, Flake8 and Bandit to the GitHub CI/ CD Pipeline.

Integrated Pylint, Flake8, and Bandit into the CI/ CD pipeline.
Now when the build and deploy action gets executed the linters and security scanner will automatically get fired up.

This was a branch used for testing to see if the linters and security scanner are working on the pipeline. This has been successful. Closing the PR and deleting this branch.

This was a branch used for testing to see if the linters and security scanner are working on the pipeline. This has been successful. Closing the PR and deleting this branch.


Tilted curve issue when using zhang fit

Hi,
I am currently using zhng fit model for the values mentioned below.
6441.98,6383.192,6325.8344,6269.60528,6214.487936,6159.418643,6105.581316,6053.799992,6001.876262,5950.335251,5898.042302,5847.675511,5796.543563,5741.443815,5684.597475,5629.008258,5580.121147,5536.025881,5495.629406,5456.531057,5419.432093,5381.39263,5344.964945,5307.471515,5272.287292,5237.151761,5204.087811,5172.047914,5142.027145,5112.015012,5083.808431,5056.964689,5031.754624,5008.143863,4985.179697,4965.064712,4944.248882,4924.062719,4902.46232,4882.505008,4862.247234,4842.734536
where the values are raw values which didnt have baseline corrected when i am trying to correct baseline using zhang fit it is showing as tilted curve. Is there anything can you help to make the curve corrected or any suggestion is good enough.

All I can say is that this could be an inherent property of the algorithm. As per the algorithm, this is a correct graph. You might want to try other algorithms for comparison purposes.


qtree_labels metrics are being captured at very irregular interval.

qtree_labels metrics are being captured at very irregular interval.
We have not set any different polling interval for this. Is it something set in the code? For every cluster, this interval is different.

hi @jmg011 labels are collected as part of the collector's PollData method, which means they are collected and published to the Prometheus endpoint roughly every 3m, assuming that the client_timeout or schedule instance was not changed in your default.yaml or qtree.yaml.
Some other ideas

Can you check your poller logs for any errors, especially timeout errors? Maybe the ZAPI is timing out when querying the qtrees and that causes the sporadic publish? The default client_timeout is 10s, but we can increase the client timeout for qtrees if there are timeouts
How many qrees do the irregular interval clusters have?
Maybe the qtree plugin added in 22.02 times out when collecting quota information for you qtrees. If so, that will be in the poller log file too. Can you post a poller log file for one of the irregular pollers?


Deploying to preview environment

Hey,
i've read through the documentation and source code and it's not clear is it possible to use this action to deploy to preview environment for example for specific pull requests?
It seems to me that it should then require --branch in https://github.com/cloudflare/pages-action/blob/main/src/index.ts#L67
but I am not sure.
If that functionality is not supported I would be happy to contribute with some guidance.

wrangler (and this action) automatically picks up the branch for a git workspace. If you need to override the branch that you're publishing to, you can indeed use the --branch CLI arg on wrangler. We don't currently have any plans to expose that option in this Action, but feel free to call wrangler yourself in Actions.

Ah ok, all clear now, thanks.

What about the uploaded directly?
What I upload directly is the production environment, and the default for action deployment is the preview environment. Can I specify the environment when using action?

wrangler (and this action) automatically picks up the branch for a git workspace. If you need to override the branch that you're publishing to, you can indeed use the --branch CLI arg on wrangler. We don't currently have any plans to expose that option in this Action, but feel free to call wrangler yourself in Actions.

Sorry, I'm confused. I'm testing this Action in a new workflow with 2 separate jobs where, in the first job, I checkout the repo using actions/checkout@v3 (with no additional options), build the site, and output the static content to an out directory. At the end of that job I upload the out directory as an artifact. In the 2nd job, I download the artifact, obtain secrets, and run cloudflare/pages-action@v1.
When this workflow is run on a PR, the workflow's deployment on the PR branch shows in my page's Deployments as "Production" on the main branch, and the site's production pages.dev domain is updated to point to the PR's deployment. This obviously shouldn't happen on a PR deployment and I assume I'm missing something, but it's not clear what.


Update storage-java-use-blob-storage-on-premises-app.md

Hi @micurd, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (micurd). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Don't precalculate etcd static IP addresses (WIP, being tested internally)

As part of effort to add support for provisioning into existing VPCs and subnets, kube-aws should stop trying to calculate static IPs itself: it is likely to cause conflicts for a first cluster in subnet and it is guaranteed not to work when provisioning second one.
This PR works by changing CF to save IP addresses  of InstanceEtcd in CF metadata which is then pulled by cfn-init scripts on nodes and placed in the right places.
It also adds explicit AWS::EC2::NetworkInterface resource which is then used as eth0 on Etcd instances.  Strictly speaking this change is not needed, but since kube-aws  decided not to manage Etcd instances after creation, in the real world they might need changes - having an explicit network interface resource allows instance to be recreated keeping same static IP.
Also few cleanups were done to etcd controller scripts.

Also fixes https://github.com/coreos/kube-aws/issues/218

Current coverage is 68.48% (diff: 100%)

Merging #226 into master will decrease coverage by 0.38%

@@             master       #226   diff @@
==========================================
  Files             4          4
  Lines          1134       1098    -36
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            781        752    -29
+ Misses          263        260     -3
+ Partials         90         86     -4

Powered by Codecov. Last update b7587a6...8bd5b09

@redbaron Thanks again for your contribution!
Explicit AWS::EC2::NetworkInterface sounds cool but would mind sharing your thoughts on how an EC2 instance running etcd could be recreated retaining the same private dns name before/after recreation in a cluster created by kube-aws with the change?

So, kube-aws is going to ignore any resources with pattern InstanceEtcd* copying them from existing CF fetched from AWS into a new one, which it then uploads back to AWS to apply changes.
This means that any modification to InstanceEtcd is outside of scope of kube-aws and administrator can manually do --export, then make changes needed and then apply them calling CF directly.
explicit AWS::EC2::NetworkInterface helps here because as long as it is not destroyed, but simply
reattached, it keeps it's private IP assigned at creation time, which itself means that PrivateDNSName property of AWS::EC2::Instance this interface is attached to remains the same even if instance itself (but not the interface!) is recreated.

This has been tested and seems to be working fine. Could you please review this change. I'll squash commits before merge

@mumoshu , all that cfn-etcd-environment.service + ExecStartPre="sed ... "" + AWS::CloudFormation::Initmight go away if only we could create a private.kube.localRoute53 zone  whereA` record are created:
etcd.clusername.kube.local   7200 IN A <ENI1.IP>
etcd.clusername.kube.local   7200 IN A <ENI2.IP>
etcd.clusername.kube.local   7200 IN A <ENI3.IP>

then it will be less crufty to distribute etcd endpoints across the clusters:

cloud-config-etcd:   will do something like ETCD_INITIAL_CLUSTER=$(paste -d, -s <(dig ya.ru +short | xargs -I{} echo '{}=https://{}:PORT'))
everyone else will use a single hardcoded endpoint https://etcd.clusername.kube.local:PORT.

But having a route53 zone is a bigger change from what we have now, but if you think it is OK to go that route, I'd prefer to use it instead of my current approach

@redbaron Would it be a solution to https://github.com/coreos/kube-aws/issues/189 if you could make the hosted zone used for etcd peer discovery customizable via cluster.yaml? (I'm assuming that the hosted zone can be anything if nameservers serving the zone is properly configured for EC2 instances via e.g. DHCP options. Am I correct?)

yes, hosted zone can be configurable, we can possibly reuse same zone which externalDNSName is using  by default if createRecordSet: true, but there will be no fallback to manually creating entries for etcd.
So if we go that route, then having a Route53 zone becomes a hard requirement, not an optional feature, but what we have instead is simpler and less error-prone etcd bootstrapping.
As for #189, setup described there is broken: if you set domain-name and keep using AWS DNS  you are asking for trouble, they even have it in their docs:

To change these to custom DNS hostnames, you must set domain-name-servers to a custom DNS server.

Trying to workaround unresolvable hostnames isn't something I am interested in :)

@redbaron Thanks!

we can possibly reuse same zone which externalDNSName is using  by default if createRecordSet: true

I'm ok if you meant to automatically create a private hosted zone used to resolve etcd hosts to private ips used among etcd nods and the zone is named after what was specified by externalDNSName 👍
assuming that hostedZoneId is currently for specifying "public" hosted zone used to host k8s API endpoint and not for resolving hosts to private ips.

there will be no fallback to manually creating entries for etcd.

I'm ok with it as long as we document it.
Anyways we can enhance kube-aws later to support accept custom hostnames which results in record-sets in the private hosted zone with something like the below?
internalDomainName: terradatum.com
etcd:
  hosts:
  - fqdn: foo.terradatum.com
  - fqdn: bar.terradatum.com
  - fqdn: baz.teradatum.com

As for #189, setup described there is broken: if you set domain-name and keep using AWS DNS  you are asking for trouble, they even have it in their docs:

Honestly saying I'm not very familiar with private DNS thing in EC2 but AFAIK a custom domain-name in a DHCP options set while pointing to <IP_ADDRESS>(=The ip address of amazon-provided DNS server) seems valid as long as one correctly created/configured a private hosted zone for the domain for the VPC according to the AWS doc?

The Amazon DNS server in your VPC is used to resolve the DNS domain names that you specify in a private hosted zone in Amazon Route 53
http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/VPC_DHCP_Options.html#AmazonDNS

Would you let me ask which part of the setup described in #189 looked problematic to you?

Honestly saying I'm not very familiar with private DNS thing in EC2 but AFAIK a custom domain-name in a DHCP options set while pointing to <IP_ADDRESS>(=The ip address of amazon-provided DNS server) seems valid as long as one correctly created/configured a private hosted zone for the domain for the VPC according to the AWS doc?

My understanding is that only domain names automatically maintained by AWS on instance creation are compute.internal and compute.amazonaws.com, everything else needs to be managed by AWS user. I just done a quick test to confirm that.

Would you let me ask which part of the setup described in #189 looked problematic to you?

Unless I misread description, they have situation where hosts receive names which can't be resolved via DNS, ie dig ip-10-1-0-171.terradatum.com on a node returns an error. You can't run system reliable where hostnames are unresolvable.

I'm ok with it as long as we document it.
Anyways we can enhance kube-aws later to support accept custom hostnames which results in record-sets in the private hosted zone with something like the below?

I'd add just these 2 params to cluster.yaml:
# DNS zone name to use when creating entries needed for cluster setup
# internalZoneApex: "{{ .clusterName }}.kube-aws.local"

# Uncomment and set to an existing route53 zone id which is capable of serving 'internalZoneApex' domain names. kube-aws will create one itself otherwise. If you use existing 'vpcId', newly created route53 zone will be associated with it.
# internalZoneId:

Whatever in kube-aws is going to use it will figure out itself what to add.
In case of etcd that would be just one DNS name with  A records added: etcd.{{.InternalZoneApex}}

My understanding is that only domain names automatically maintained by AWS on instance creation are compute.internal and compute.amazonaws.com, everything else needs to be managed by AWS user. I just done a quick test to confirm that.

Thanks! It matches to my expectation and therefore I'd guess one needs to either

add a record-set for a host before the host starts up (e.g. via cloudformation like I'm assuming you would do to implement https://github.com/coreos/kube-aws/pull/226#issuecomment-272630759) or
add a recordset  after the host starts up (e.g. via cloud-config and accordingly override hostname to match the record-set)

ref https://cantina.co/automated-dns-for-aws-instances-using-route-53/

Unless I misread description, they have situation where hosts receive names which can't be resolved via DNS, ie dig ip-10-1-0-171.terradatum.com on a node returns an error. You can't run system reliable where hostnames are unresolvable.

It seems like I had completely missed that part. I agree to you now. Thanks!

@redbaron Sounds great overall 👍
Several nits but:

internalZoneId:  should be internalHostedZoneId for consistency with the existing hostedZoneId (which could be deprecated and renamed to externalHostedZoneId in the future)
AFAIK "{{ .clusterName }}.kube-aws.local isn't a zone apex but kube-aws.local is and I guess you don't want to restrict it to a zone apex actually. Then, shouldn't the key be internalDomainName rather than internalZoneApex?

Also, sorry for not being clear enough but my snippet below was meant to support users who wanted to manually name etcd nodes:
internalDomainName: terradatum.com
etcd:
  hosts:
  - fqdn: foo.terradatum.com
  - fqdn: bar.terradatum.com
  - fqdn: baz.teradatum.com

I believe we don't need to care this now.

So if we go that route, then having a Route53 zone becomes a hard requirement, not an optional feature, but what we have instead is simpler and less error-prone etcd bootstrapping.

@redbaron Now I'm glad to make it a hard-req if we can choose to either automatically create one according to internalDomainName or provide an existing one via internalHostedZoneId. // I'm afraid i might be a time-consuming task though 🍺

Btw how are you going to enable TLS communication between etcd nodes?
AFAICS, https://github.com/coreos/kube-aws/pull/226#issuecomment-272630759 is meant for etcd peer discovery among etcd nodes + etcd node discovery from client-side; not for etcd peer communication.
I believe you'd need to provide a resolvable hostnames to etcd nodes for etcd peer communication in TLS. Are you going to assume that domain-name in a DHCP options are not customized i.e. relying on the default *.compute.internal hostnames?
Then, could it be possible to enhance your work to support customized hostnames without many changes? (Just curious. Not meant to scope-creep this PR if it isn't already intended on your side)

@mumoshu , this PR works as of now (nodepools remain untested),  I please consider merging it. DNS etcd endpoint discovery can be a further improvement in  a separate PR. I can't keep rebasing PRs for long, their number grows out of hands :(

@redbaron ok. I'm merging this anyway!
For anyone interested, AFAICS merging this should make node pools unusable because etcd-client-env isn't defined in nodepool/config/stack-template.json and private ips of etcd nodes which are required to define etcd-client-env isn't provided via cross-stack reference.
I'll fix it after merging several PRs including this but in the meantime if you'd like to use node pools, please consider not to use binaries built from master.
Or even better, submit pull request to fix it! 😄


Tweak List: performance and style improvement

@coderabbitai pause

@Lampese there was a bug in the formatter, the diff in string.mbt is incorrect

@Lampese there was a bug in the formatter, the diff in string.mbt is incorrect

Oh I had thought this was normal behavior for formatter, my mistake.


Docker image can't be run with my uid / gid

When trying to unpack my module with my current user id + gid:
$ docker run --user "$(id -u):$(id -g)" --rm -it -v "$(pwd)":/nasher nwntools/nasher unpack --file=RoUM.mod
WARNING: IPv4 forwarding is disabled. Networking will not work.
docker: Error response from daemon: OCI runtime create failed: container_linux.go:349: starting container process caused "exec: \"nasher\": executable file not found in $PATH": unknown.

If I change to --user "0:$(id -g)" it works.
This is probably because the nasher binaries are installed only for root user (in /root/...)
The end-result problem is that without --user the files on my filesystem become all owned by root

Sorry this took so long! nwntools/nasher:0.13.0 has been updated with this fix.


issue with hyper library

I have been using your lib without error for a few months until it recently stopped working. We are using Apex (for Lambda) and simply redeployed the function that included 'gobiko.apns' in our requirements.txt
The error is;
 GoAway frame could not be sent: 'NoneType' object has no attribute 'sendall'
and the traceback is;
local variable 'res' referenced before assignment: UnboundLocalError
Traceback (most recent call last):
File "/var/task/main.py", line 79, in handle
send_ios_push(params, developer_id, ios_devices, bundle_id)
File "/var/task/main.py", line 149, in send_ios_push
extra=formatted_params['extra']
File "/var/task/gobiko/apns/client.py", line 78, in send_bulk_message
return res
UnboundLocalError: local variable 'res' referenced before assignment

I think it may be failing to establish an SSL connection but not sure how to fix it.
AWS Lambda runs on python 2.7.12.

@iainwatt
I haven't looked into your issue specifically. But since you're mentioning an SSL problem with regards to push notifications.  Are you by any chance deploying using gevent?  Because gevent monkey patches the SSLSocket implementation.  I've had problems with gevent and APNS in the past.

Thanks for looking into it, I am deploying using Apex. When you deploy Apex pulls in the  all the libs from requirements.txt so on each deployment it seemed to be continually replacing some of the libs required in you package. I will try again and only load your package to Lambda once.

I'm seeing this too. I'm attempting to send_message from a Flask app in development mode, so using the Flask cli, which I think doesn't use gevent.

hyper is no longer maintained. They (hyper team) suggest switching to httpx.
I did so. See #32


Make type generation resilient to temporary swagger issues

If a particular swagger path fails, we should continue to use the old values, rather than removing it entirely.

This is done.


Added new tests for contract in negative scenarios

Description
Added new test cases for contract in negative scenarios

bors r+


Fetch prediction using bash or python

Is there a way to use bash or python to fetch a specific prediction from AlphaFold database? I installed AlphaFold from pypi but I didn't find any documentation if that was possible. The goal would be to have a prediction in a pdb format on a local server. Currently I need to download the whole database for a given species and use python to fetch a single prediction from the database.

Sure, you can use wget or curl.
For instance, to download a cif file for F4HVG8, you would do:
wget https://alphafold.ebi.ac.uk/files/AF-F4HVG8-F1-model_v1.cif

This new tool from our lab affetch


Ticket dependency delete confirmation - don't delete button click

Describe the bug
After add dependency to ticket and then want remove the confirm modal append and on do not delete 404 not find. Fixed wrang path on button click.
To Reproduce
Ticket dependency - do not delete 404
Steps to reproduce:
1.Log in with user(admin-role)
2.Helpdesk
3.All Tickets
4.Click any Ticket
5.Add Ticket Dependency
6.Delete Ticket Dependency
7.Don't Delete
Page not found (404)

Request Method:
GET

http://<IP_ADDRESS>:8080/tickets/12/dependency/

Expected behavior
Need to redirect to ticket edit after button do not delete is clicked.
Desktop (please complete the following information):

OS:MacOs - M1
Browser chrome
Version 98.0.4758.109 (Official Build) (arm64)

Thank you! This should be fixed now that #1001 is merged, so I will close this ticket.


test zipformer for front framework

hello. i am trying test pruned_transducer_stateless7_streaming in streaming_server.py.
my goal is test stream for frontend framework?

What is frontend framework?
And what issues do you have?

Is this possible?

Is this possible?

Yes, that is perfectly possible.
Could you post any issues you currently have?

What I mean is test zipformer in "https://github.com/k2-fsa/sherpa/blob/master/sherpa/bin/streaming_pruned_transducer_statelessX/streaming_server.py" i have been tried to add zipformer model but can not ?

please see https://github.com/k2-fsa/sherpa/pull/365


Wire Competition bot

Once the new platform is finalized and constructed, it will need to be wired in a similar fashion to the current test platform.

Duplicate of #225


*: report read statistics to pd

report the read statistics.

LGTM
But I suggest sending read statistics to the PD worker directly later.
PTAL @BusyJay @zhangjinpeng1987

LGTM
CI failed @nolouch


Why do I get a Forbidden message

I have tested the example in two servers both running Ubuntu 20.04.2.  In one I can run the example without problem.  This uses node-red v2.0.6, nodejs v12.22.4 and npm 6.14.14.
In the other one which uses node-red v2.0.6m nodejs v14.17.6 and npm v6.14.15 I get in each of the Linode nodes a message in red that says Forbidden and if I use the inject error I get FetchError.  In the enclosed file you will find and example
What can be be the problem?

Hi @frosich61 First of all, Thank you very much for your interest. =)
Does your network have any restrictions to access the following URL?
const LINODE_API_URL = "https://www.linode.com/docs/api/openapi.yaml"
p.s So however I have plans to bring YML to the server
kind regards.

Hi Marcos:
Yes, you are right.  This is what I get when I tried to wget https://www.linode.com/docs/api/openapi.yam
--2021-09-24 22:50:16--  https://www.linode.com/docs/api/openapi.yam
Resolving www.linode.com (www.linode.com)... <IP_ADDRESS>, <IP_ADDRESS>, 2606:4700::6812:7f04, ...
Connecting to www.linode.com (www.linode.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2021-09-24 22:50:16 ERROR 403: Forbidden.

Hi @frosich61
I've been thinking about it. This might be the key to a solution.

And maybe add some headers stuff in the code bellow.
      export async function getApiList() {
        const url = encodeURI('https://www.linode.com/docs/api/openapi.yaml')
        // server call
        return window.$.get('getNewOpenApiInfo?openApiUrl=' + url, function (response) {
          return response
        })
          .fail(function (message) {
            return message
          })
      }


[QUESTION] Msgpack/JSON request/response without middleware

First check

[x] I used the GitHub search to find a similar issue and didn't find it.
[x] I searched the FastAPI documentation, with the integrated search.
[x] I already searched in Google "How to X in FastAPI" and didn't find any information.

Description
How can I allow msgpack or JSON encoding in requests/responses without the middleware approach based on Content-Type and Accept headers. See the middleware approach here: https://github.com/tiangolo/fastapi/issues/521
We use msgpack because it's smaller as mentioned in the previous issue, but also because numerical data can be encoded/decoded much faster (1,000x+) with msgpack, (e.g., NumPy, Pandas, PyTorch, ...). In addition, general access to raw byte returns is beneficial without having have to encode/decode Python strings. Basing the encoding off Content-Type and Accept headers is beneficial for clients who do not want to bother with msgpack.
Additional context
My current solution is as follows.
Step 1
Prevent FastAPI from automatically serializing NumPy arrays and other binary objects in its jsonable_encoder function:
import numpy as np
from pydantic.json import ENCODERS_BY_TYPE

# Warnings and exclamation marks as this is a bit dangerous and Pydantic global...
ENCODERS_BY_TYPE[np.ndarray] = lambda x: x
...

Step 2
Custom msgpack encoders/decoders:
def custom_serializer(data: Any) ->bytes:

    def array_serialize(obj: Any) -> Any:
        # We can provide real msgpack here, but close enough for demonstration
        if isinstance(obj, np.ndarray):
             return np.ascontiguousarray(obj).tobytes()
        return obj

    return msgpack.loads(blob, object_hook=msgpack_decode, raw=False)

def custom_deserialize():
...

Step 3
Allowing msgpack requests without running through JSON can be worked as in #521 with the following:
class MsgpackRequest(Request):
    async def json(self) -> Any:
        if "application/x-msgpack" in self.headers.getlist("Content-Type"):
            self._json = custom_deserialize(self._body)
        return await super().json()

Step 4
Responses are the trickier part without running through JSON as in #521. You can return a custom response class for every route, but that doesn't allow you to parametrize this based off the Accept header as the information never exists within the Response classes [1]. My current solution is to make a new APIRoute class which replaces this function which works fine, but I worry is a bit brittle.
Questions:

Is there a simpler way to accomplish the above?
Is [1] patchable where we can pass through the headers to the Response class which can then determine its own content serialization (solves step 4)?
Is there room for strategic PRs which make other serialization formats beyond JSON easier?

[1] This may not be fully true. Looking at it, I think Starlette allows this, but FastAPI simply does not pass this through.

Thanks for filing this @dgasmith. Like my comment on #521 said, we are in the same boat as you. Working with medium to large sized numerical data APIs. Would love for one of the maintainers to chime in either there or here.

I second that! I am currently working on micro services for neutrino oscillation probability calculations and passing around numpy arrays with hundreds of millions of entries is only doable with workarounds like above.

@tiangolo Hey, suspect you are super-busy, but any input on this? It seems @dgasmith was, at least at one point, willing to make a PR for this, if just given some input on the preferred approach (https://github.com/tiangolo/fastapi/issues/521#issuecomment-658291782). It would be absolutely great if plugging in different serializations, without CPU overhead of internal JSON serialization, was more streamlined.

I believe this is somewhat related to what I was looking for as well.
I was hoping for a way to customize how requests and responses are encoded and decoded without going through FastAPI's jsonable_encoder and such. In my opinion, it was a matter of refactoring how the request handler was built. I've put up a PR that addresses the needs that I personally had https://github.com/tiangolo/fastapi/pull/4968

@tiangolo Do you think you would have time to discuss @dgasmith offer of a PR for this? (see e.g. https://github.com/tiangolo/fastapi/issues/521#issuecomment-672928213)


[e2e]: container push main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3834879065
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.push.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.push.main.default.slsa3.yml
Trigger: push
Branch: main
Date: Wed Jan  4 03:19:54 UTC 2023

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3843544920
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.push.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.push.main.default.slsa3.yml
Trigger: push
Branch: main
Date: Thu Jan  5 03:19:25 UTC 2023
Tests are passing now. Closing this issue.


add message if date is in the past

It does reject today, which I assume was specified when it was originally
implemented. Will run past Jim
On Thu, 3 Jan 2019 at 14:15, petergphillips<EMAIL_ADDRESS>wrote:

@petergphillips commented on this pull request.
In server/services/utils/formValidation.js
https://github.com/noms-digital-studio/licences/pull/708#discussion_r245011394
:

     const errorObject = error.path.reduceRight((errorObj, key) => ({[key]: errorObj}), errorMessage);
     return mergeWithRight(errors, errorObject);
 }, {});

}
+function getErrorMessage(fieldConfig, error, errorMethod) {

if (error.type === 'date.min') {

   return 'Enter a date that is in the future';

I can't really tell, but what happens if you enter today's date? Is that
allowed?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/noms-digital-studio/licences/pull/708#pullrequestreview-189025936,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARbMNz5Eia0NU_4pNeVm6Xp6QwbsByBEks5u_hCAgaJpZM4ZoI8a
.


snowball mini

run a subset of the snowball probes, make the full one something like snowball_x_full and inactive by default
requires #86

completed in 6554deeffaf6cb6b6050c581951a926318a13bfd


Remove version: Microsoft.Edge.Beta version 124.0.2478.10

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/d89f75fb-0eba-4b94-ac9b-623cad3a26bf/MicrosoftEdgeBetaEnterpriseX86.msi
OK
(Automated message - build 912)

Close with reason: Package still available;


Create a CI GitHub pipeline to release the collection

[x] Lint every build
[x] Package
[x] upload the tar file to  the action page
[x] use the build in each collection dir instead of using in the root
[x] build podman as well, for now we are only building docker  - check galaxy.yml  /cd and build
[x] add a release pipeline with build and test as well

@jhoekx


Feature request: Custom OAuth state

I need to store some extra information alongside the InternalStateData. In order to do this I need access to the oauth state in order to store/retrieve my data. I see two ways this could be implemented:

Allow the state parameter to be overridden. This would be a very small change, as it appears the API is already set up for this. This should not break the current API. I would be happy to submit a PR for this.
Instead of returning a String from client.authorize(), return a struct that contains the redirect URI and the internally generated state. This might be a more robust solution, but would also break the current API.

Are you open to this functionality?

I don't understand in what context and what kind of data you want to keep, but I believe that the oauth-client stores/retrieves only the data necessary for authentication, and the user data is stored by the application implementer themself.
The official TypeScript SDK for atproto allows the user to specify a state when calling authorize() and returns the value of that state upon successful callback.
https://github.com/bluesky-social/atproto/tree/main/packages/oauth/oauth-client#authentication
I plan to implement that functionality in ATrium as well, but wouldn't using that state value to store data in the application implementer's own store be a solution?

Sorry if I was confusing. I just need exactly the functionality the official SDK provides. If you implement that I should be good to go. In fact I can submit a PR if you'd like.


Results of training on my own dataset

Hi,When I train with my own dataset, the result is as shown in the following picture.Can you tell me where is the problem? May be the length of data is too short? (my dataset is about 20 minutes ) Looking forward to your reply ：

）

Hi, is it possible you've got teacher forcing enabled? Going by the attention matrix, the encoder doesn't seem to have an impact on the decoder

Hi, is it possible you've got teacher forcing enabled? Going by the attention matrix, the encoder doesn't seem to have an impact on the decoder

Hi,I check the hparams.py and train.py in synthesizer folder,how can I stop teacher forcing when training? is it ok?

I think if you use the following in hparams.py:
tacotron_teacher_forcing_mode="constant",
tacotron_teacher_forcing_ratio=0.,

It will disable teacher forcing in training

I think if you use the following in hparams.py:
tacotron_teacher_forcing_mode="constant",
tacotron_teacher_forcing_ratio=0.,

It will disable teacher forcing in training

thanks!

Could you share the attention plot after disabling the teacher-forcing? Did you solve the problem?