Able to give the resource that generates the renders?

Saw an article about this library on twitter & i'm trying to see if I can replicate the results using threejs. So far I haven't been able to get it working right. Curious if the environment map, the model, lighting setup, etc that is being used to generate the renders can be released to try to replicate the results as close as possible. If successful, maybe its something that can be added to the site itself.
Here's the article in question & my attempts to replicate the blood pbr.
https://twitter.com/SketchpunkLabs/status/1557063158027657224?s=20&t=uJMEMXkr5tt_mzySet2NgA

Funny you should say that, because I've started work on a "Material Explorer" using threejs that will hopefully be on the site sometime in the future. Sneak peek here (viewport size is broken atm): https://physicallybased.info/threejs/

Thats pretty kewl. Can't wait to see it all working.

Sorry I forgot to answer your question about releasing the render ball scene. I have plans to do just that. I need to clean it up and do some further testing to make sure it works consistently (as possible) across different render engines.

Just a little update; the USD Assets Working Group is working on a standardized render ball that I most likely will update to when it's ready. It's based on the same render ball I've used on the website.
Here you can read a little bit more about it: https://docs.google.com/document/d/1Xeg646DNUm9KWXN71BFSFLW1L5_Ed8_2DawT6NdEhTQ/edit#
This is the repository where it should be available when they release something: https://github.com/usd-wg/assets


flutter drive confusingly different from flutter run: no build step?

Steps to Reproduce
On MacOS, developing a Flutter app. Android device plugged.

$ flutter run
Manually test app, find something to fix
Make code change
R restart app
Manually retest, works great now! So lets run the autottest...
q stop app
$ flutter drive
Be confused.
$ flutter run
Be more confused.

Observe: the app launched by flutter drive does not include the change made in step 3 above. Neither does the app launched by the subsequent flutter run.
Flutter Doctor
[✓] Flutter (on Mac OS X 10.12.4 16E195, channel master)
    • Flutter at /Users/mravn/github/flutter
    • Framework revision 3c7e176a99 (21 hours ago), 2017-04-25 16:08:55 +0200
    • Engine revision a5b64899c9
    • Tools Dart version 1.23.0-dev.11.11

[✓] Host Executable Compatibility
    • Downloaded executables execute on host

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.2)
    • Android SDK at /Users/mravn/Library/Android/sdk
    • Platform android-25, build-tools 25.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] iOS toolchain - develop for iOS devices (Xcode 8.3.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 8.3.2, Build version 8E2002
    • ios-deploy 1.9.1
    • CocoaPods version 1.2.1

[✓] Android Studio (version 2.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Gradle version 3.2
    • Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06)

[✓] IntelliJ IDEA Community Edition (version 2016.3.4)
    • Dart plugin version 163.13137
    • Flutter plugin version 12.0

[✓] WebStorm (version 2017.1.1)
    • Flutter plugin version 13.0

[✓] Connected devices
    • Nexus 5X • 00bff34682e4b2ab • android-arm • Android 7.1.2 (API 25)

This doesn't fit our current priorities, so moving to the next milestone.
@sethladd This seems like a major bug, if it's still present; we might want to consider tweaking our priorities to allow this kind of thing to be included.

@mit-mit would have a better idea here, but all things considered, I can imagine a simple fix is to be more aggressive with our rebuild logic. Better to be correct and slow, then fast and incorrect.
The work around for this in the meantime is "flutter clean && flutter build && flutter drive", yes?

@mit-mit I'm current using flutter clean && fluter drive

Flutter drive currently includes a build step


[doc] add 101 doc for certification and finality

Description
add 101 doc for certification and finality
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes
add 101 doc for certification and finality

The content for this topic was moved to another page and included in #15177


Add a "Cook book" section to the docs

This would be similar to how-to guides, but focused on code (API usage). It would be longer than archetype snippets, but shorter than full examples.
Example idea to cover:

Setting up a custom time line
Setting up a blueprint
Simple 2D plots
…

The cookbook should have the same code in all languages.

I think we should only have two kinds of examples (not to be confused with categories): full fledged demos (most of what we have in examples/ today, with the exception of stuff like multithreading and such, as well as everything we have in external repos) and recipes / cookbook-style examples (I count all archetype snippets as such, as well as a few of the smaller things in the examples/ folder).

It would be longer than archetype snippets, but shorter than full examples.

Imo the length of an example isn't really that important when it comes to determining its kind (of course a recipe shouldn't be 5000 lines of code scattered across 10 files -- common sense still applies).
An example should either demonstrate how the product behaves in a real-world scenario (it's a demo), or it should show how to use the product to achieve one very specific thing (it's a recipe).
That doesn't mean a recipe cannot get complex/lengthy -- sometimes the one single thing you want to achieve does in fact require a lot of code to achieve, and that's fine.
Now, as for categories, both demos and recipes can have an arbitrary amount of categories.

As a real-world example, I will once again have to bring up the Bevy examples (shocker!).
Bevy basically has these same two kinds of examples: recipes (which can get quite complex) and full-fledged demos (games, in this instance).
And it is the best project cookbook I've ever used by a long mile.

I have a proposal to go about this:

We create a new (public) repo rerun-io/cookbook.
That repository is just a collection of markdown files in folders.
Landing page has a new "Cookbook" section whose content mirrors the hierarchy and content of the cookbook repo. Pushing to cookbook's main triggers a landing page deployment.

Pros:

Updating the cookbook is a simple PR with no other schenaniganeries.
The cookbook content is open to public contribution in a very accessible way. (Bells and whistles includes acknowledging contributors on the rendered page, to further promote contribution).

Cons:

None :)

Inspiration: the TIL section of Simon Willison's blog.

Repo: https://github.com/simonw/til
Deployed: https://til.simonwillison.net

Cons with the rerun-io/cookbook repo approach:

Version mismatches:

How should someone add a cookbook for a coming Rerun version that uses features that aren't yet supported?
How are we keeping track of version requirements for the entries? Enforcing they all work on latest release? Separate versions per entry? How do we run CI on these in that case? If no CI, do we just let these go stale and still have them on our docs page?

Community vs official:

If we actually render them on our docs we should probably have some way of separating community vs official cookbooks. In general we need to deal with the level of polish and "does thing in the right way"-ness we want to enforce on these.

How should someone add a cookbook for a coming Rerun version that uses features that aren't yet supported?

Maybe just a release branch on rerun-io/cookbook that we merge just after rerun release?

How are we keeping track of version requirements for the entries? Enforcing they all work on latest release? Separate versions per entry? How do we run CI on these in that case? If no CI, do we just let these go stale and still have them on our docs page?

Meta-answer: the spirit of the cookbook is to not let "perfect" get in the way of "good" (and "done").
Ensuring code doesn't rot is a valid concern. Ideally we'd have some variant of the snippet system, but that is local to the recipe in question and doest required messing with 3 config files in 2 different places. Fluidity is key here imo.

If we actually render them on our docs we should probably have some way of separating community vs official cookbooks. In general we need to deal with the level of polish and "does thing in the right way"-ness we want to enforce on these.

I'd expect the cookbook to undergo a standard PR reviews, so community contributions would be just as good an ours. Specifically, this would not be a wiki-like thing that anyone (or anyone with some privilege) could edit at will.

Let's start simple:

Add a Cookbook header to rerun.io/docs
Just write markdown. Low bar: no code testing etc
Maybe add a GitHub label to tell CI to cherry-pick a PR into doc-latest

Once we have 50 cookbook recipes, we can think about engineering this differently

That is super neat and would fit perfectly into that: https://discord.com/channels/1062300748202921994/1075873257124810852/1301647484891955241

@jleibs wrote:

Regarding the height map, the depth image is an interesting idea -- it's not exactly designed for that and I think the perspective projection might not be exactly what you want, but I'd be interested to hear if you're able to make it work.
The other way we've seen folks handle this is with an array of Boxes3D.
Here's a python snippet:
import rerun as rr

import numpy as np

rr.init("rerun_example_height_map", spawn=True)

height_map = np.random.rand(10, 10) * 10

# create the coordinate grid
x = np.linspace(0, 10, 10)
y = np.linspace(0, 10, 10)
X, Y = np.meshgrid(x, y)

# Offset the centers by half the height
centers = np.stack([X.flatten(), Y.flatten(), height_map.flatten() / 2.0]).transpose()

half_sizes = np.ones((len(centers), 3)) * 0.5
half_sizes[:, 2] = height_map.flatten() / 2

rr.log(
    "height_map_3d",
    rr.Boxes3D(
        centers=centers,
        half_sizes=half_sizes,
        fill_mode=rr.components.FillMode.Solid,
    ),
    rr.AnyValues(value=height_map.flatten()),
)


Build issues with MAPL 3 and ifx 2024.2

Well, unlike MAPL 2 (see #2880), MAPL 3 doesn't even build. It gets close, but dies in linking GeomIO:
[ 88%] Linking Fortran static library ../lib/libMAPL.GeomIO.a
cd /home/mathomp4/Models/MAPL3-IFX-2024.2/build-Debug/GeomIO && /ford1/share/gmao_SIteam/Utilities/cmake-3.28.3/bin/cmake -P CMakeFiles/MAPL.GeomIO.dir/cmake_clean_target.cmake
cd /home/mathomp4/Models/MAPL3-IFX-2024.2/build-Debug/GeomIO && /ford1/share/gmao_SIteam/Utilities/cmake-3.28.3/bin/cmake -E remove /home/mathomp4/Models/MAPL3-IFX-2024.2/build-Debug/lib/libMAPL.GeomIO.a
cd /home/mathomp4/Models/MAPL3-IFX-2024.2/build-Debug/GeomIO && /ford1/share/gmao_SIteam/Utilities/cmake-3.28.3/bin/cmake -E cmake_link_script CMakeFiles/MAPL.GeomIO.dir/link.txt --verbose=1
/usr/bin/ar qc ../lib/libMAPL.GeomIO.a CMakeFiles/MAPL.GeomIO.dir/GeomIO.F90.o CMakeFiles/MAPL.GeomIO.dir/SharedIO.F90.o CMakeFiles/MAPL.GeomIO.dir/Geom_PFIO.F90.o CMakeFiles/MAPL.GeomIO.dir/Grid_PFIO.F90.o CMakeFiles/MAPL.GeomIO.dir/GeomCatagorizer.F90.o CMakeFiles/MAPL.GeomIO.dir/pFIOServerBounds.F90.o
/usr/bin/ar: Relink `/ford1/share/gmao_SIteam/intel/oneapi/compiler/2024.2/lib/libimf.so' with `/lib64/libm.so.6' for IFUNC symbol `cosf'
Error running link command: Segmentation fault
make[2]: *** [GeomIO/CMakeFiles/MAPL.GeomIO.dir/build.make:173: lib/libMAPL.GeomIO.a] Error 1```

I'll mention @bena-nasa as he wrote the layer, but honestly, this error sort of baffles me. GeomIO's CMake is pretty boring and I don't think the code is that spectacularly different from the rest of MAPL3.

I mean, the error sort of points to a cosine function (I'd imagine) but there is no `cos()` in there.

I'm going to invoke the name of @climbfuji as maybe he's seen this as he looks at `ifx` in spack-stack land?

Closing as #2882 will fix this. Congrats to ifx for exposing a bug that apparently ifort, gfortran, and nagfor all missed!


ChoiceField Search always returns undefined

Hi,
I have a working-ish search dropdown. It queries a datasource dished out by DRF. The search dropdown queries correctly and finds results, but when selected the value isn't copied into the underlying hidden input. This isn't in place in the semantic ui docs so I assume this is specific to the django implementation. Do I need to manually copy the value into the hidden field onChange or is it a fault with the API mapping that means that although display of values is working, the underlying value isn't?
JS
    <script>
    $('.ui.dropdown')
      .dropdown()
    ;

    $('.ui.dropdown.search')
      .dropdown({
        apiSettings: {
          // this url parses query server side and returns filtered results
          url: '//<IP_ADDRESS>:8000/api/cities_light/cities/?q={query}'
        },
      })
    ;

    </script>

forms.py
class PublicLeadForm(ModelForm):
    email = EmailField()
    captcha = ReCaptchaField(label="Protect us from spammers...", widget=ReCaptchaWidget())
    locality = CharField(label="Town / Area", widget=TextInput(
            attrs={"_style": "search", "_override": "Select", "_name": "locality", "_dropdown_icon": "search"}))
    questions = CharField(label="Any Questions?", widget=Textarea(attrs={'rows':4,}))

    class Meta:
        model = Lead
        fields = ['name', 'email', 'gender', 'locality', 'age', 'questions', 'captcha']

Example API response
{
    "count": 1,
    "next": null,
    "previous": null,
    "results": [
        {
            "url": "http://<IP_ADDRESS>:8000/api/cities_light/cities/339/",
            "country": "http://<IP_ADDRESS>:8000/api/cities_light/countries/1/",
            "region": "http://<IP_ADDRESS>:8000/api/cities_light/regions/4/",
            "name": "Uxbridge",
            "name_ascii": "Uxbridge",
            "geoname_id": 2635042,
            "alternate_names": "",
            "display_name": "Uxbridge, England, United Kingdom",
            "search_names": "uxbridgeenglandunitedkingdom uxbridgeunitedkingdom",
            "latitude": "51.54890",
            "longitude": "-0.48211",
            "population": 0,
            "feature_code": "PPLA3",
            "timezone": "Europe/London"
        }
    ]
}

Realised that it was the API mappng;
    <script>
    $('.ui.dropdown')
      .dropdown()
    ;

    $('.ui.dropdown.search')
      .dropdown({
        apiSettings: {
          // this url parses query server side and returns filtered results
          url: '//<IP_ADDRESS>:8000/api/cities_light/cities/?q={query}'
        },
        fields: {
          name: 'name',
          value: 'name',
        }
      })
    ;

    </script>


Add a new workflow for ios automation build

@ckm007 We have to create .app file in iOS for UI automation. So we want to have it as separate workflow.


Maybe useful?

Don't know if this is useful for your project, but I have a list with data from php.net about all functions.
data.json

Updated version, now with data on 4235 functions
data.json


GL viewport doesn't change on resize

Using imgui-rs 0.10 + imgui-glow-renderer (AutoRenderer) + imgui-winit-support
I noticed that resizing the system window doesn't update the OpenGL context viewport, which messes up my custom GL app underneath the UI. Not that I think that it should or anything, but I was wondering how I can update it ?
I'm using something very similar to glow_02_triangle.rs
It looks like the window resize event gets forwarded to winit-support's handle_window_event and clearly stuff happens with it but it's not easy to follow everything.
Should I just catch the glutin event and set the viewport to WindowEvent::Resized(physical_size) ?
Thanks and sorry for the question-non-issue, I didn't know where else to ask.

I think this is mainly a glutin(/winit?) thing, so I'm not the best person to answer - but the "catch the glutin event and set the viewport to WindowEvent::Resized(physical_size)" sounds about right
Basically like this: https://github.com/rust-windowing/glutin/blob/v0.29.1/glutin_examples/examples/window.rs plus you'd still need to pass it to winit_platform.handle_event so imgui knows about the size change
(one thing to be careful with is the imgui-rs code is still using glutin 0.29, and "[the 0.30 version] of glutin has been rewritten from the ground and no longer depends on winit")

Thanks dbr, works fine indeed so far. I guess I was confused as to how imgui kept rendering correctly without updating the GL context's viewport. Then again my OpenGL-jitsu is low so there's gotta be something I don't know about that permits this.

Hey, I'm still having issues with this


Automated cherry pick of #1982: fix: rbd image resize not found error

Cherry pick of #1982 on release/2.9.0.
#1982: fix: rbd image resize not found error

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.9.0@9c5ee15). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release/2.9.0   #2022   +/-   ##
===============================================
  Coverage                 ?   7.69%
===============================================
  Files                    ?     336
  Lines                    ?   53973
  Branches                 ?       0
===============================================
  Hits                     ?    4155
  Misses                   ?   49430
  Partials                 ?     388

Flag
Coverage Δ

#aFlag
7.69% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5ee15...e834d26. Read the comment docs.

/lgtm

/approve


MuSig BIP Draft TODOs

[x] Add tweaking (#167).
[x] Add reference code (#166).
[x] Try to avoid O(n²) algorithm for finding of second unique key
[ ] Add more test vectors (in particular, test vectors that result in failure).
[x] Add proper design and motivation section.

[x] Mention that sorting the keys is optional and why.

[x] Improve nonce derivation.

[x] As specified right now, if the output of the RNG used as the secret nonce ever repeats, the secret key leaks immediately. It is possible to (slightly) reduce the possibility of nonce reuse by deriving the secret nonce from the RNG output, aggregate public key and message.
[x] Mention "counter mode" nonce derivation, i.e. deriving from secret key and non-repeating counter.
[x] Add BIP 340-like sidechannel resistance.
[x] Explain deterministic nonce derivation 2-of-2 nonce example.

[x] Post BIP draft to bitcoin-dev mailing list.

Moved BIP draft to https://github.com/jonasnick/bips/blob/musig2/bip-musig2.mediawiki


✨ Debounce health updates

#171  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RTLS and the rest of your teammates on  Graphite


Could this repo have an website interactive? That may be make people know where to track their work?

Is your feature request related to a problem? Please describe.
I'm curious how many people learn the idea and do exactly develop on it. People should add their experience and app samples related to the app idea. And more, they could have a link to discuss this app. I think Discord is a good choice.
Describe the solution you'd like

[ ] static website that displays well-UI so people could review the project conveniently.
[ ] discord online chatting so could chat with other people under same topic.

Describe alternatives you've considered

[ ] no need a new website, just add discord.
Or
[ ] make issues link to the markdown files, so people on GitHub do something related it could link it.

Additional context

Hello everyone 👋
I hope this message finds you well. As you may know, the original repository for app ideas has not been updated in a while and is no longer actively maintained. However, I'm excited to let you know that a new repository has been created to continue this project (https://github.com/vincent0426/app-ideas).
The new repository aims to provide a comprehensive list of practical and achievable app ideas that developers of all levels can work on to improve their skills and build their portfolios. We welcome contributions from anyone who wants to add their own app ideas or improve the existing ones, and we are also looking for volunteers who can help maintain the repository and keep it up to date.
If you are interested in contributing or maintaining this project, please head over to the new repository (https://github.com/vincent0426/app-ideas) ⭐ and take a look at the existing issues and pull requests. Feel free to open a new issue if you have an app idea to suggest or if you have any questions about the project.
Thank you for your attention, and I hope to see you in the new repository soon! 💖

⚠ This message was generated by a robot 🤖, if this message reached you, consider leaving a star for this robot, repository link
⭐ https://github.com/aldairandre/github-bot ⭐

Hello everyone 👋
I hope this message finds you well. As you may know, the original repository for app ideas has not been updated in a while and is no longer actively maintained. However, I'm excited to let you know that a new repository has been created to continue this project (https://github.com/vincent0426/app-ideas).
The new repository aims to provide a comprehensive list of practical and achievable app ideas that developers of all levels can work on to improve their skills and build their portfolios. We welcome contributions from anyone who wants to add their own app ideas or improve the existing ones, and we are also looking for volunteers who can help maintain the repository and keep it up to date.
If you are interested in contributing or maintaining this project, please head over to the new repository (https://github.com/vincent0426/app-ideas) ⭐ and take a look at the existing issues and pull requests. Feel free to open a new issue if you have an app idea to suggest or if you have any questions about the project.
Thank you for your attention, and I hope to see you in the new repository soon! 💖

⚠ This message was generated by a robot 🤖, if this message reached you, consider leaving a star for this robot, repository link
⭐ https://github.com/aldairandre/github-bot ⭐

Hello everyone 👋
I hope this message finds you well. As you may know, the original repository for app ideas has not been updated in a while and is no longer actively maintained. However, I'm excited to let you know that a new repository has been created to continue this project (https://github.com/vincent0426/app-ideas).
The new repository aims to provide a comprehensive list of practical and achievable app ideas that developers of all levels can work on to improve their skills and build their portfolios. We welcome contributions from anyone who wants to add their own app ideas or improve the existing ones, and we are also looking for volunteers who can help maintain the repository and keep it up to date.
If you are interested in contributing or maintaining this project, please head over to the new repository (https://github.com/vincent0426/app-ideas) ⭐ and take a look at the existing issues and pull requests. Feel free to open a new issue if you have an app idea to suggest or if you have any questions about the project.
Thank you for your attention, and I hope to see you in the new repository soon! 💖

⚠ This message was generated by a robot 🤖, if this message reached you, consider leaving a star for this robot, repository link
⭐ https://github.com/aldairandre/github-bot ⭐


[ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7.1

What is this PR for?
After [ZEPPELIN-1588]: bumping nvd3 to 1.8.5 merged, Zeppelin was occurring front-end side error such as Uncaught TypeError: Cannot read property 'x' of null because of upgrading for 1.7.1 to 1.8.5.
AFAIK, this is a bug in ndv3, and ndv3 is still fixing the problem discussing here.
Also The latest release(1.8.5 version) scatter file and the master scatter file have a lot of changes, so we should wait for the next release.
Thus, I think we need to revert version from 1.8.5 to 1.7.1 for stable Zeppelin and our next 0.7.1 release.
Plus, when I check on current master of nvd3, scatter chart works well like this.

What type of PR is it?
[Bug Fix]
What is the Jira issue?

ZEPPELIN-2229

How should this be tested?

Switch some of chart such like screenshots.

Screenshots (if appropriate)
[Before]

[After]

Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

@soralee Thanks for digging it up!
Seems https://github.com/novus/nvd3/pull/1934 fixed this issue and merged in Jan. Hopefully they have a plan to release another minor version soon including this fix.

Thus, I think we need to revert version from 1.8.5 to 1.7.1 for stable Zeppelin and our next 0.7.1

Then we can just revert #2042 commit from branch-0.7(and master?) instead of opening another PR and merging it. @Leemoonsoo What do you think?

@Remilito Will be appreciated if you can take a look this :)

@AhyoungRyu This PR reverted some of #2042 and I didn't include to change this line.
If we decide to revert # 2042, I can give you help to check the reverted code.

@soralee Yeah I can see the error when we have large data.

I tested it in release 0.7.1-rc2 bin package. Can you mention this PR with short description in 0.7.1-rc2 release vote? :)

@AhyoungRyu I did!  Thanks for reproduce!
Let me check this part I didn't include. If it is possible, we had better revert it.

@AhyoungRyu @Leemoonsoo I just checked it!
We can either revert or merge it. the part I didn't include don't matter.

@soralee Thanks for the explanation.
I tested this branch to make sure it works well or not, but when I select "Line chart" below error msg shows up.
vendor.bcb986b75e1664c0.js:64 Error: <g> attribute transform: Trailing garbage, "translate(813,NaN)".

I checked multiple times, but I could see this every time. Could you check this please?

@soralee And as you can see in the above gif image that i took, the tooltip in scatter chart is shown like "(age, value)". But before #2042 it looks like below.

@AhyoungRyu Thanks for detail test! Let me check this and leave comment!

My 2 cts here:
Yep the scatter chart bug in 1.8.5 is annoying, and unfortunately nvd3 does not seem to release very frequently ( 2-3 times a year or so). However I am not sure reverting the lib from 1.8.5 to 1.7.1 is the right move, keep in mind that  a lot of bugs were fixed between those two releases.
Reverting to 1.7.1 is very likely to reintroduce (or maintain) a lot of others bugs.
I wonder if we could do something directly in Zeppelin's visualization code to workaround the voronoi issue you spotted until 1.8.6 is released. Your thoughts?

I will agree with @Remilito on this one.
I think we can come up with a workaround and keep 1.8.5.

@AhyoungRyu I checked your comment about translate error.
The error seems to be caused by incompatibility with the 1.7.1 version and this line that is after merged this #2129 in master branch.
If we decide merge, I would fix issue.

@Remilito @anthonycorbacho Thanks for opinions!
Yeah, I think whatever we use 1.7.1 version or 1.8.5 versions, we have a lot of bugs. nvd3 release process is too slow and, I'm not sure 1.8.5 version has critical bugs than 1.7.1 version :disappointed:
If we don't mind those issues, we would be nice to keep the latest version!

@soralee , @AhyoungRyu , @anthonycorbacho : proposal of workaround here, https://github.com/apache/zeppelin/pull/2194 . Feedbacks welcome!

I closed this PR. Because In the better way which keeps on the latest version, @Remilito suggested #2194, I think we don't need to talk about this PR any more.

Let's move on #2194 PR!


GURPS] v1.6.1 Cosmetic and Fixes for gurps.html, gurps.css

Fixed wording from roll table to roll template. (Cosmetic Only)
Fixed Spell Macro roll to include Modifier, if any.
Fixed the Spell Effective Skill level to include the Spell MOD, if any
Fixed columns for MOD, Pts, Duration, and Maintains. (Cosmetic Only)
Reordered column layout to match GURPS Magic format. (Cosmetic Only)
Added attributes Class and Resisted By under Spells.
Fixed Spells ‘Based On’ header to show the attribute chosen. (Cosmetic Only)
Reduced the attribute size for Diff, MOD and Pts and increased size for Cost and Time. (Cosmetic Only)
Added attributes for Latest Changes date. (Cosmetic Only)
Added attributes College and Modifier Notes for Spells.
Updated Spell roll template with the new Class ad Resisted By attributes.
Added Attributes Misc and Modifier Notes for Skills.
Fixed Inventory totals for Value and Weight totals to show trailing zeros.
Fixed issue with Inventory Total Weight not rounding properly and not showing to 3 decimal places.
Made some format changes for Total Value and Total Weight under Inventory. (Cosmetic Only)
Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

[GURPS] v1.6.1
Bug fixes
Format corrections
Added some new attributes fr Spells


trouble with gist:geoOccupies and gist:GeoPoint

I'm having a little trouble determining how we describe something as being located at a lat/long point using gist8.0.0.  Here's why:

gist:latitude has domain of gist:GeoPoint (same for gist:longitude)
The only object property I could find that seems to tie something to its location is gist:geoOccupies
gist:geoOccupies has range  gist:GeoRegion or gist:GeoVolume (not gist:GeoPoint)

So if I wanted to say a certain landmark is at a lat/long, how would I say it in triples?
Sample construct that seems reasonable:
@prefix rdf:     <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix gist:    <http://ontologies.semanticarts.com/gist/> .
@prefix :        <http://example/> .

:_WashingtonMonument a gist:Landmark
  ; gist:geoOccupies :_GeoPoint_38.88-77.03
  .

:_GeoPoint_38.88-77.03 a :GeoPoint
  ; gist:latitude 38.889467
  ; gist:longitude -77.035251
  .

But is uses gist:geoOccupies to point at a point. Is this correct way to model?   (yes, could have maybe used gist:permanentGeoOccupies)
Suggestion: Change range of gist:geoOccupies to gist:Place?  (note: geo:Place is the inferred range)
(This may be related to #14 )

#56 in gist(.0.0


S3 enhanced

As the S3 bucket got heavier recently, most of the functions could not work as they were listing all files. Some functions were also needed in order to avoid switching between the workflow of aws CLI and boto3.

add list_folders method to S3Bucket class

add download_folder method to S3Bucket class

refactor widely list_files to allow more flexible use

modify get_files_metadata in order to add the same flexibility as list_files

add a read_credentials (not in S3Bucket class) to read the credentials : this avoids redundancy

These functions are also explained in a notebook.

add a notebook s3_tutorial  to facilitate use of the sub-module by new contributors.

Thanks for the PR ! Nothing to add, it's perfect 👍


Windows Keybase full screen bug

Keybase GUI Version: 6.3.1-20240530102114+0c98770127
I maximized keybase on my vertical oriented monitor and now I am unable to move the Window or change its size.

Also having this issue


Fix for custom transitions not properly loaded

Hi,
I noticed custom transitions are not properly loaded :
https://github.com/deulos/vue-flux/blob/0096716c9cb46300938d4d78f0857842f2db366c/src/components/FluxTransition.vue#L76-L79
should probably return this.transition.component.
A few comments : I took a look at the code and really like the clean and clever architecture fully using Vue transitions power, custom transitions are super easy to make. Did you consider passing the full images array as prop to the transition component? It could open some space for fun advanced effects.
Also the first custom transitions I'm doing are "back" versions of default transitions such as slide or swipe. If it's not too much work I really support the come back of the direction feature in v6 because some effects feel really weird when the same direction is used for next and previous slides.
Last thing I can't seem to import BaseTransition from the dist folder in my custom transitions, is there a way to do so? I had to copy it. On a related note when installed with npm the src folder isn't present, only dist, is this a choice ?

Hi,
I noticed custom transitions are not properly loaded :
https://github.com/deulos/vue-flux/blob/0096716c9cb46300938d4d78f0857842f2db366c/src/components/FluxTransition.vue#L76-L79
should probably return this.transition.component.

It should not, that computed returns the name of the component because:
https://github.com/deulos/vue-flux/blob/0096716c9cb46300938d4d78f0857842f2db366c/src/components/FluxTransition.vue#L7-L7
And the component is imported in:
https://github.com/deulos/vue-flux/blob/0096716c9cb46300938d4d78f0857842f2db366c/src/components/FluxTransition.vue#L100-L100
So you should not have any problem... paste the console error or give me a repo I can review :smile:

A few comments : I took a look at the code and really like the clean and clever architecture fully using Vue transitions power, custom transitions are super easy to make. Did you consider passing the full images array as prop to the transition component? It could open some space for fun advanced effects.

I really didn't think about passing all images array. Do you think that people will use more than one image to make a transition?

Also the first custom transitions I'm doing are "back" versions of default transitions such as slide or swipe. If it's not too much work I really support the come back of the direction feature in v6 because some effects feel really weird when the same direction is used for next and previous slides.

You are totally right, I didn't think about it, so I will consider taking them back...

Last thing I can't seem to import BaseTransition from the dist folder in my custom transitions, is there a way to do so? I had to copy it. On a related note when installed with npm the src folder isn't present, only dist, is this a choice ?

 About not including the source is a choice because it is available here, so for what add extra size to the package if most people will never use it?
BTW yesterday just checked the glitch in other environments and found that it only occurs in Firefox and in my source version, the beta.18 transpiled version is fine, so I suspect that could probably come from a dependency updated recently. Yesterday I started to clean and review some code to make another beta release and see if still occurs in Firefox.
I will include array of images and direction of transitions, thanks a lot for the support!!

Hi and thanks for your response.

It should not, that computed returns the name of the component because

Maybe I'm doing something wrong but the source of this Object.assign (this.transition.component) has no key, so all the props are added to the $options object without key, triggering an error.
Standard transitions :

Adding a custom transition:
      transitions: [{
         name: 'TransitionTest',
         component: TransitionTest,
      }]

Which gives a Unknown custom element: <TransitionTest> - did you register the component correctly? For recursive components, make sure to provide the "name" option.
I tried setting up my custom transition with a key, it gets better but fails on props retrieval and I don't think that's the way to go anyway. It works flawlessly when returning the whole Component in componentName().

I really didn't think about passing all images array. Do you think that people will use more than one image to make a transition?

I'm not sure it would be widely used but an interesting use case I see is displaying a relevant background (a third slide) for some effects like Blinds instead of a generic background.

You are totally right, I didn't think about it, so I will consider taking them back...
I will include array of images and direction of transitions

That is double great news :+1:

thanks a lot for the support

Thanks a lot for this super cool slider :100:

You are right, the $options.components is an object and I should assign the component in its key.
I will release a new beta with the fix as soon as I can be sure that the glitch is gone, expecting to be today or tomorrow.
Thanks a lot!!

Just tried last changes and fixes and unfortunately the glitch remains even in published version.
Feel free to download sources and experiment in Firefox, specially running the wave transition. You will see the glitch right when pressing the button of 3D transition.
My concerns are following... the code didn't really changed since beta.18 and doing git checkout to that version does not fix the glitch so I started to suspect something caused by the dependencies... but the ironic was that even rolling back setting specific version of deps keeps the glitch.
So my only thoughts are the global dependencies. Beside that the problem seems to come from synchronicity so or there is a bug in one of my global deps or I need to find a way to sync the process, which seems to be the best but unwilling choice...

Are you talking about the controls jumping to the top of the slider ? Else I don't see anything. If yes I will try to look at it.
Also since your last commit can you npm install vue-flux@beta ? I get a notarget No matching version found for vue-flux@beta even though beta20 is listed on npm.
I managed to update before this last commit, it seems that the added dependency to core-js embed a node_modules in vue-flux folder, is it necessary ?

Sorry, yesterday I did some tries to check if with a packaged and released version the glitch was not happening but unfortunately remained so I had to unpublish them and forgot to restore the beta tag. No should be set to version 6.0.0-beta.18 again.
The glitch is a kind of blink or flash caused by the main image when changes to display the next and the transition component is not drawn yet. Also in the wave animation, the sides of each var are sometimes displayed before the front side causing an ugly effect, probably caused because sides are just colored which causes to render faster than the front.
I managed to solve the blink with a couple of setTimeout to ensure that the things are run in order but I don't like it as solution and I think that the best approach would be to control readiness of child components and control their rending although I am afraid that cost in performance, complexity and final weight will be a problem...
The core-js is just one of the tests I did... today I will try downgrading the global packages and I will record a video to show you the glitch, because if it is not happening to you we can do a comparison to find where does it comes.
Regards and thanks a lot for the help

The glitch is a kind of blink or flash caused by the main image when changes to display the next and the transition component is not drawn yet.

All right I can reproduce this almost consistently for many transitions on Chrome Linux as long as dev tools are opened. I thought you were talking about something else because most likely this glitch is due to the nature of Vue and the architecture of vue-flux. I've never seen it with dev tools closed, did you ?
Anyway it feels like this can be compressed to a specific point but in the end depending on the client you can never be sure it will be unseen, there will always be a split second where the content is empty before the image is displayed.

I managed to solve the blink with a couple of setTimeout to ensure that the things are run in order but I don't like it as solution

indeed :crying_cat_face:

That's exactly the effect, but in your case is totally normal because having dev tools open disables the cache, which causes the preloaded images to be loaded again.
BUT I think you just pointed me to the problem and solution. I will try it this afternoon and let you know :grin:

Not lucky, firefox is working the same in all my home computers. But at work (previous version and in linux) the glitch does not happen.
I also tried downgrading the global packages and running with npm and yarn.
I recorded a video where you can see the glitch I mean, https://we.tl/t-VoqXbhVKlb grey bars sometimes in wave transition and blinks in slide transition also random.
All seems to be just a matter of synchronicity and render timing... I will take a few days to find what is the best approach

Did a LOT of tests and all the results where the same, sync is not properly managed by firefox, not even v5, because just using v5 is causing the glitch, which means that something changed in firefox rendering engine....
The only available solution now is to control the rendering flow, so I will work on it tomorrow and make a release ASAP.
I will keep you updated

Hi,
I might have found something about the "grey bars" in Wave :

A way to reproduce it consistently is to wrap the content of
https://github.com/deulos/vue-flux/blob/4aefd69fd3bc7115d6fa8cf9963556ed22144cb4/src/components/FluxImage.vue#L60
in a nextTick(), this way image will never be loaded and the bars will appear for the duration of the transition (also more convenient with a longer transition speed).
This gives the time to find the culprit, which appears to be transform-style: preserve-3d in FluxCube : remove this prop and bars disappear. I think that at this point the transformation has started but since image is not yet loaded it uses the background color (sideColor) defined in Wave (#333).
From there I don't really know what's best to do but I can tell setting base transformStyle to flat in FluxCube and appying preserve-3d only when transition has started makes the glitch disappear (in my case I added css.transformStyle = 'preserve-3d' in getSideCss()).
Or maybe just delay the apply of sideColor in Wave .
Now this falls back to the other problem of the flash before transition start. I still have to see it when dev tools are not opened (and indeed this is due to cache: when dev tools are opened with settings "keep cache" the glitch does not appear). I will try to look into this this week end.
Tell me if it helps !

I was aware that the grey bars were seen because are rendered faster than the frontal image, but you just had a super idea!! :grinning:
I was sure that the solution had to be based in drawing the fronts before the sides but was not sure about the best way achieve it with best performance, but I think that giving the initial flat style and then changing it to preserve-3d when fronts are loaded will do the trick, good job :+1:
Also I kept testing and had more findings... the glitch in firefox just happens if page is realoded, not when just accessed by link or address bar :joy: it's just insane...
This afternoon I will try to make to synchronize all components in the flow and if I succeed and the flat trick works next week the release could see the light finally!!
Thanks a lot again man for the help

Ok that's good news ! About the flash problem, a few thoughts :

If I'm not mistaking in your screencast the flash only appears when the page has just loaded, confirming the cache problem. I don't see the preloader in your video, is it disabled ? That would explain why you see it and I don't.

Did you try to wrap the content in mounted  in transition files into a nextTick() ? To my knowledge this is the only way to ensure children of current component are also mounted. In a typical component like Slide the wrapper start transitioning potentially before flux-image are mounted. Having wrapper transform inside a nextTick() prevents this.

If I'm not mistaking in your screencast the flash only appears when the page has just loaded, confirming the cache problem. I don't see the preloader in your video, is it disabled ? That would explain why you see it and I don't.

Yes, I removed the all the complements in that test to check if without having to render them would affect or not, but it does not really change the preloading as it is managed by the Images controller, not in the FluxPreloader component. Anyway the images are loaded from M2 HD so don't even take a second to load, and the flash appears the same event without having to reload the page again, but you just don't see it because of the video frame rate...

Did you try to wrap the content of mounted  in transition files into a nextTick() ? To my knowledge this is the only way to ensure children of current component are also mounted. In a typical transition like Slide the wrapper start transitioning potentially before flux-image are mounted. Having wrapper transform inside a nextTick() prevents this.

Yes, one of my thoughts is to move all the the transforms from the mounted hook to a method called play so it will be only called once the images are rendered. But before that I also need to syncrhonise the transition start from Transitions controller and the root image update, to ensure that are run right after.

nextTick inside FluxTransition.mounted() is not working... I will have to implement a ready bubble to know when everything is rendered, which still does not ensures that all have been rendered because I have no access to the browser engine.... I will try some CSS tricks to force engine rendering

Good news... I managed to control browser engine with this:
requestAnimationFrame(() => {
   requestAnimationFrame(this.run);
});

works perfect in firefox and chrome, just the wave grey vars remain...

All wrong, still happens, much less frequently but still...

Thanks for your fixes ! I'm taking a look this afternoon on this. Can I PR a test branch if I find something ?

sure! dont even need to ask 👍
if you find a solution test it in safari if you can because the glitch affects it too, at least in my ipad, don’t know in mac but probably too
tomorrow i will try some ideas if i have some time to spare. im sure im missing something. i want to check if nexttick affects all the components the same by bubbling or should be set in the respective component
regards!

Hi,
I kind of managed to do something interesting. Since I couldn't really reproduce the glitch my reference environment was Chrome with dev tools opened and cache disabled, which has the glitch most of the time if not anytime.
After reading your comment I've tried the demo on my iphone and  had the glitch 100% of the time :(
With fix enabled I got it only a very few times and only when mashing next button, I suspect these case are due to system memory limit somehow reached and can be fixable somehow. Note that I had to disable allowToSkipTransition and add a check on the props I added before allowing a new transition to be created : when transitions are allowed be skipped and replaced this happens more often (maybe for previous reasons).
See the PR (this is just a PoC) where the fix is applied on Fade and Slide. Note that Slide now can have a weird artifact when sliding (I've only seen it in Chrome but only with dev tools opened which always mess with transition anyway) but this is a different issue due to the dimensions changes I've made (see below), maybe it can be fixed with a flexbox positioning.
Anyway the main reason for the glitch to happen is that FluxImage doesn't really notify anyone when its image is loaded. There is something binded to the load event of the image but since it's a computed prop and it emits nothing the whole chain can't reliably happen in a correct order.
This is made even trickier because of the "permanent image" (let's call it like this) under the transtition has the weird behavior of displaying the to image at the same time transition starts. More on this below.
So right now the order of things is something like this :

current image is displayed
click on next slide
transition starts AND current index is changed
Two images must be displayed : permanent image AND transition from
transition starts whenever it's mounted (but most of the time one or both images still aren't loaded)
glitch happens

where it should be something like this :

current image is displayed
click on next slide
transition is called, do nothing until all its images are loaded (we do this by checking when the numbers of image loaded event is equal to the number of images called in the transition (1 for Fade, 2 for Slide)
When images are all loaded, transition can emit a ready event.
App component receives this event and can now trigger a current index change
Current index is changed, "permanent image" display new image
"Permanent image" emits a loaded event, listened by transition
transition can now play

At this point the result is better but glitch still happens sometimes.
All of this is made really harder because of this "permanent image" change on transition start (and no Vuex :( . Unless I'm missing something (I'm pretty sure it breaks many features actually)  currentIndex should ideally be changed once the transition has ended, removing the need for this bubbling up (and double render for the browser). To me the ideal flow is :

current image is displayed
click on next slide
transition is called, reversed way : for example Fade display to image instead of from
image emits loaded, start transitioning (so for Fade opacity from 0 to 1 instead of 1 to 0)
On transition end emit event
Current index can now be changed

With this setup (as seen in PR) the result is way better.
The others changes I have made, though I'm not sure it changes anything per se, is removing most of the calls to size calculation (mask, images, etc). Is this really needed ? Since the slider has dimensions, why not gives background-size:contain;width:100%; height:100%; top:0; left:0; bottom:0; right:0; to its children whenever it is possible ? I know you're doing it in case no dimensions are provided but that's a lot of code and complexity.
In general I'm not sure FluxImage should use anything else than the CSS passed as prop, IE no CSS calculation inside this component, always receiving CSS from parent. It might be trickier with more complex effect Cube effects but I almsot made it work for Wave (not present in PR).
About Wave you still get the grey bars effect with the fix but this can be removed with the transformStyle: 'flat' trick.
I've also added a few CSS props to ensure 3d acceleration is always triggered/optimized like translate3d(0,0,0,0) to containers or will-change on images, and remove most of the nextTick in the chain because I found out they were most of the time between useless and harmful. Also maybe others things that I forgot :D
Anyway that's messy but that should be a start !

Really appreciated! I will review it and do some tests ASAP.

I will resume everything 😄

I suspect these case are due to system memory limit

Not really... It's about processing speed

when transitions are allowed be skipped and replaced this happens more often

This is expected but with the right lifecycle it would not happen

it can be fixed with a flexbox positioning

Yes, in fact I should review some styles because were though for IE which I'm not willing to support in this version

Anyway the main reason for the glitch to happen is that FluxImage doesn't really notify

You just got my latest test in which I tried to manage the readiness but was just a test, unfortunally like you said computed elements do not pay attention to child $refs so was fail test 😠

weird behavior of displaying the to image at the same time transition starts

That is why I moved the transition logic to played hook

So right now the order of things is something like this

Your discovering about current lifecycle is totally right, "permanent image" is updated faster than the transition is rendered

where it should be something like this

Mostly right although once the transition images are fully loaded, the "permanent image" can be updated safely and we don't really care when it is finished rendering or not

change on transition start and no Vuex

I really want to keep all of my projects as far as possible from dependencies, in fact I had to implement the mobile gestures myself, but as far as not being a big deal, deps are ok but when a bug or bug is found it becomes in a domino effect problem

currentIndex should ideally be changed once the transition has ended

Not possible because we would need another extra image for some transitions, like the fade one for example

To me the ideal flow is

That is not valid flow because the FluxTransition component should be agnostic, and not depend on "permanent image". In fact one of the features of this version is to make all components as independents as possible to use this not only as slider but as image library

With this setup (as seen in PR) the result is way better

Can't discuss it although not elegible for the reassons I will explain you 😞

removing most of the calls to size calculation

We need them from window resizing and full screen 😔

Since the slider has dimensions, why not gives background-size:contain

That would break the composed images like grid and vortex. Images are displayed as background to save tags and need to be positioned and masked for FluxGrid and FluxVortex components. So FluxImage needs to be independent but compatible with the dependent components, and doing some division and multiplication does not increase complexity so much, in fact it ensures a pixel perfect rendering. Think about SOLID principles.

In general I'm not sure FluxImage should use anything else than the CSS

I will be glad to implement a solution that works for grid and single image if it does not cause an extra code caused by a wrong lifecycle of a component that should not affect it

About Wave you still get the grey bars

Yes, I go step by step because if I solve the lifecycle, the bars will be solved too so they don't really worry me

I've also added a few CSS props

Really appreciate it, I will take some of your code to improve the current, do not doubt it! 😁
Right now, because it is in beta stage I will not take a patch as a solution if it does not really solves the root problem.
As last option I still have 2 wild cards, one is to use an extra image like in v5, and the other is to control all FluxImages in a recursive function.
Thanks again for your time and ideas. Although they were not what the project needed right now will help to improve it ☺

I just upaloaded the recursive function wildcard to dev, feel free to test 😁

Great news... my requestAnimationFrame approach was good but missed a definitive detail.  Feel free to test it in any browser or device 😄
I will add the wave bars fix and all of your improvements and make a new beta release.
I would like to add you as contributor because you helped me a lot, would you like?

Hi thanks for your feedback and work ! I see the changes are clever. However I still get the glitch 100% of the time on my iphone (SE latest firmware). I really think @load in FluxImage has to emit an event before FluxTransition is allowed to play (because despite the image being preloaded the browser still need some time to display it). Also of course you can add me, I plan to add this nice transition in a few weeks maybe you will find it interesting !

Hi thanks for your feedback and work ! I see the changes are clever. However I still get the glitch 100% of the time on my iphone (SE latest firmware). I really think @load in FluxImage has to emit an event before FluxTransition is allowed to play (because despite the image being preloaded the browser still need some time to display it). Also of course you can add me, I plan to add this nice transition in a few weeks maybe you will find it interesting !

I managed to solve 99% of the wave transition glitch with the flat trick and is all I can do to make it work.
I only reproduced it in a top computer and smashing the wave button, which is is enough for me. It is funny that in low computers or devices never happens.
Tomorrow I will do some code and CSS improvements, add you as contributor and release the probably latest beta.
Next will be to update and finish docs with demos and playgrounds, and then release version final stable version.
BTW you didn't tell me if the fix worked for custom transition, I guess it did.

Hello! just to keep you updated, I've been travelling the past 2 weeks so I didn't have no much time for the slider, but this is how is it going:

I reduced the maths of image scaling (done)
Ratios are cached when image is loaded or container resized (done)
Use translate instead absolute positioning
Making the process sync

Some ideas came from you thank you!

Hello, I managed to solve the glitch, not in an elegant way but works 100%. Basically depending on the complexity of transition calculates a delay to start playing, although I still want to adjust the delay a bit more.
Feel free to test it although I already checked the animations in 2 iphones and both worked like a charm.
So on Friday I will release the new beta and update the docs. And as promised, If you want, give me any info you want to share as contributor :grin:
I'm also closing the issue as I consider that everything treated here is done and solved but you still can answer.
Thanks again for all your ideas, help and time.
Regards!


updated AspectSlope

changed bit depth to work w/ color maps and removed rft

Let's make sure this is tested  prior to merging this pull request.  Can you make sure these work with what you are working on @abhiataero @aileenbuckley.

@abhiataero, any updates on this? Thanks!


Improvement of the Contact Form

Hi, I would like to work on an update on the Contact form (Access CyberBear for free):

Adding a Short Description / Tagline for Clarity:
A one-liner description below the title that highlights CyberBear's value proposition. For example:
Get hands-on with cutting-edge cybersecurity tools designed to protect your digital life

Adding a Privacy Disclaimer for Reassurance:
Add a short privacy statement below the form to reassure users about the use of their data:
We respect your privacy and will only use your information to notify you about CyberBear access.

Add a dropdown button to select the country (with flag) and its code, followed by a field to enter the phone number.

Suggest an improved text for confirmation:
Your submission has been received! You’ll receive an email as soon as early access is available.

Please assign me this issue. I will work on it ASAP.
Thank you!

Contact form in the landing page


A3 Endscreen module port

When merged this pull request will:

Port the A3 Endscreen module to the new format.

@PiZZAD0X with a slight fix it's working, are we good to merge now?


Develop manual testing strategy for dagmc_export

May require a separate plugin that runs tests?  This separate plug in would be invoked with a journal file.

Reimplement read_cgm_* tests from MOAB.
introduce special build option that adds an additional command to the plugin to run tests


pr test

pr test

[Template] PR Description
In general, github system automatically copies your commit message for your convenience.
Please remove unused part of the template after writing your own PR description with this template.
$ git commit -s filename1 filename2 ... [enter]

Summarize changes in around 50 characters or less

More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical;
various tools like `log`, `shortlog` and `rebase` can get confused
if you run the two together.

Further paragraphs come after blank lines.

**Changes proposed in this PR:**
- Bullet points are okay, too
- Typically a hyphen or asterisk is used for the bullet, preceded
  by a single space, with blank lines in between, but conventions vary here.

Resolves: #123
See also: #456, #789

**Self evaluation:**
1. Build test: [ ]Passed [ ]Failed [*]Skipped
2. Run test: [ ]Passed [ ]Failed [* ]Skipped

**How to evaluate:**
1. Describe how to evaluate in order to be reproduced by reviewer(s).

Add signed-off message automatically by running **$git commit -s ...** command.

$ git push origin <your_branch_name>

:memo: Version: 1.20180820. Thank you for submitting PR #318. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://invain.mooo.com/.

To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://invain.mooo.com/TAOS-CI/ci/repo-workers/pr-checker/201810250928520.24772691726685-318-619a26e25cb3baf03c06aecae1cfa68afbb55ad0/report/misspelling_result.txt.

:octocat: cibot: @jongpuls, One of the format checkers is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnsuite/TAOS-CI/wiki/.

https://hacktoberfest.digitalocean.com/stats/jongpuls
You has completed the Hacktoberfest challenge!
Progress (6/5)


AVX fix for un-aligned grid sizes

@MissingChip @szaman19 there should be a test that shows a passing build after the fixes

I haven't touched this in a few days since we were talking about not messing with the API, but yes it's pretty much ready I'll just make it so it works with the actual build system and has the old API as well as the relatively minor changes I made to it.

Also, yeah. I think I'll rebase this around PR #17
The code still needs a bit of a clean up. Not very extendible or readable now, still. Also, naming should be better. If it's just a fix for the AVX issue, then ok with merging it in.

Also, yeah. I think I'll rebase this around PR #17
The code still needs a bit of a clean up. Not very extendible or readable now, still. Also, naming should be better. If it's just a fix for the AVX issue, then ok with merging it in.

It started as just a fix for the AVX issue, then I also started to minimize the code. There was a fair amount of unnecessary/redundant code. Definitely still needs cleanup, naming changes etc. but yeah that can be later, especially since API isn't finalized.

Also, yeah. I think I'll rebase this around PR #17
The code still needs a bit of a clean up. Not very extendible or readable now, still. Also, naming should be better. If it's just a fix for the AVX issue, then ok with merging it in.

It started as just a fix for the AVX issue, then I also started to minimize the code. There was a fair amount of unnecessary/redundant code. Definitely still needs cleanup, naming changes etc. but yeah that can be later, especially since API isn't finalized.

Sounds good. LGTM :shipit:

I also added stub functionality in the "backend" part for things like per-channel weights (not per-atom wieghts, we could also do that) and different density functions, so they would be easier to add later.

I am currently leaning towards the SKlearn API approach for weighted. Here is an example


Code quality fix - Try-with-resources should be used.

This pull request is focused on resolving occurrences of Sonar rule
squid:S2093 -  Try-with-resources should be used.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S2093
Please let me know if you have any questions.
Faisal Hameed

the compiler plugin is configured with source 1.5 and target 1.5 which means that its not possible to use try with resources etc.


Fatal Error

Hi,
I have an issue with Oasis Wallet on Firefox. I tried several times to open it with seed phrase and still have this error:
NetworkError when attempting to fetch resource.
The above error occurred in task vr
created by vr
created by takeEvery(account/fetchAccount, vr)
created by xr
Tasks cancelled due to error:
takeEvery(account/fetchAccount, vr)
Or
I tried too on Brave and i had this error:
Failed to fetch
The above error occurred in task vr
created by vr
created by takeEvery(account/fetchAccount, vr)
created by xr
Tasks cancelled due to error:
takeEvery(account/fetchAccount, vr)
Or
TypeError: Failed to fetch
at https://wallet.oasisprotocol.org/static/js/main.1cb68546.chunk.js:1:5921
at f (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:490496)
at Generator._invoke (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:490284)
at Generator.next (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:490921)
at n (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:44538)
at u (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:44741)
at https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:44800
at new Promise ()
at n. (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:44681)
at n.fetchApi (https://wallet.oasisprotocol.org/static/js/main.1cb68546.chunk.js:1:6510)
What can i do?

i have the same propblem

Failed to fetch
The above error occurred in task vr
created by vr
created by takeEvery(account/fetchAccount, vr)
created by xr
Tasks cancelled due to error:
takeEvery(account/fetchAccount, vr)
Or
TypeError: Failed to fetch
at https://wallet.oasisprotocol.org/static/js/main.1cb68546.chunk.js:1:5921
at f (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:490496)
at Generator._invoke (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:490284)
at Generator.next (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:490921)
at n (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:44538)
at u (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:44741)
at https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:44800
at new Promise ()
at n. (https://wallet.oasisprotocol.org/static/js/2.48cea8b1.chunk.js:2:44681)
at n.fetchApi (https://wallet.oasisprotocol.org/static/js/main.1cb68546.chunk.js:1:6510)

Regarding this and similar reports: we're working on making some of the functionality still work even when the block explorer APIs are down.

Yep, Oasis monitor was down yesterday. Duplicate of #403. Reopen, if error still persists today please.


Drop mdx_truly_sane_lists dependency

Removes mdx_truly_sane_lists dependency from docs
Change Summary
There was a markdown version dependency mismatch between mkdocs and mdx_truly_sane_lists, resulting in a warning during docs build. To my knowledge we're not using mdx_truly_sane_lists except for bool docs, which will be reworked soon anyway.
I'm also not a fan of multiple nested lists to the extent mdx_truly_sane_lists is needed anyway. Typically the information could be presented in a better way.
please review
Related issue number

Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

please update.

Ready for review

Lgtm


I want to set a number of tick count but also want to make the seekbar continuous.

@skkirtonia So sorry to tell you that they can be set at the same time, Maybe you can try to initail a continuous seekbar and then set the tick count.


Publish 3.4.4 to docker registry

What changes were proposed in this pull request?
Publish 3.4.4 to docker registry
Why are the changes needed?
To provide the docker image.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.

cc @yaooqinn and @viirya

Thank you, @yaooqinn and @viirya .
Merged to master.

FYI, official docker is ready  https://github.com/docker-library/official-images/pull/17826

Thank you for taking care of it, @yaooqinn !


Investigate issues

Codecov Report
Attention: Patch coverage is 75.16340% with 38 lines in your changes missing coverage. Please review.

Project coverage is 72.62%. Comparing base (5b07dc7) to head (eb667ac).

Files with missing lines
Patch %
Lines

...al_experiment/torch_interpreter/_aten_functions.py
77.22%
23 Missing :warning:

experimental_experiment/ext_test_case.py
69.56%
7 Missing :warning:

experimental_experiment/xbuilder/_dtype_helper.py
50.00%
4 Missing :warning:

...xperimental_experiment/xbuilder/model_container.py
50.00%
2 Missing :warning:

...mental_experiment/torch_interpreter/onnx_export.py
80.00%
1 Missing :warning:

...rimental_experiment/xbuilder/shape_type_compute.py
66.66%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   72.51%   72.62%   +0.10%
==========================================
  Files         170      170
  Lines       23996    24119     +123
==========================================
+ Hits        17401    17516     +115
- Misses       6595     6603       +8

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Error with gulp task

Actually when I try to execute a default task in gulp for compile my fork with my custom colors I have an error with task lint:sourses.

me to find the same error, when i try to install the master version

@judearasu what is the stable branch?

yeah, eslint is borked a bit - take out ['lint:sources', 'lint:aux'] from this line https://github.com/google/material-design-lite/blob/05db1a21d75393a096fdbf3ccc14f78556364525/gulpfile.babel.js#L131 and it'll build, serve, etc

@svzosorio, I think the lint error is quite easy to fix. By using @eriktrom's method, MDL will build files succesfully, but you can't serve the site correctly through gulp serve.
Below is the steps to fix the lint errors, note that you actually have 3 errors.
For the first two error, please open material-design-lite\src\mdlComponentHandler.js, and navigate to line 233, remove the single quotes for that line. Example:
Into:

Do the same for line 367.
Then, open material-design-lite\src\layout\layout.js, and go to line 569, and delete that blank line. Just like this:

Into this:

Your gulp task should be able to complete without error now.

Thank you very much, I'll be trying again tomorrow and tell them how I was

@svzosorio, or you can try download the latest master branch, because referring to pull request #4351, the fix has been merged into.
This is the merge commit for another reference .

Thanks @jiaming10


Broken links in readme

Description
the readme links for examples is broken when accessing from the terraform.io website
Autoscaling: A PostgreSQL cluster with enhanced monitoring and autoscaling enabled
Global Cluster: A PostgreSQL global cluster with clusters provisioned in two different region
MySQL: A simple MySQL cluster
PostgreSQL: A simple PostgreSQL cluster
S3 Import: A MySQL cluster created from a Percona Xtrabackup stored in S3
Serverless: Serverless PostgreSQL and MySQL clusters

https://registry.terraform.io/modules/terraform-aws-modules/rds-aurora/aws/latest

Good catch! Terraform Registry does not respect relative links.


Completion for import attributes in @module

Adds completion for the new import attributes in @module.

looks like CI is red
leftover of the previous CI issues which were not fully solved?

@cristianoc look again


[5.7-04182022] Sema: Accept existentials without any in swiftinterfaces

Cherry-pick of https://github.com/apple/swift/pull/58801
Accept existentials without any in swiftinterfaces.
Resolves rdar://93052306

@swift-ci please test

@swift-ci please test

@swift-ci please test

@swift-ci please test


[Enhancement] Show warning if .scala or .sbt configuration file changed

As I am learning SBT, I find myself making changes to .scala configurations and reloading them to test my configurations. Sometimes I forget to type 'reload' in the SBT console and end up being confused at why my last change didn't seem to take effect.
It would be very nice if SBT can "watch" the .sbt and .scala configuration files for change every time a task or command is executed on the SBT console and warn the user of changes, e.g.,
> run
[warn] project/Foo.scala has changed since the last "reload".

Multiple main classes detected, select one to run:

 [1] com.twitter.finagle.example.echo.EchoClient
 [2] com.twitter.finagle.example.echo.EchoServer

Or in case more than 1 file was changed:
> run
[warn] Configuration files have changed since the last "reload".

Yes, this would be very useful.

Is this not similar to 'sbt watch'?

Perhaps, what is "sbt watch"? The ~reload syntax doesn't detect changes to the SBT configuration files.

Not sure what watch does. This is all I know
$ sbt
> tasks
...
  watch                                  Continuous execution configuration.
  watch-sources                          Defines the sources in this project for continuous execution to watch for changes.
  watch-transitive-sources               Defines the sources in all projects for continuous execution to watch.

> watch
[info] sbt.Defaults$$anonfun$watchSetting$1$$anon$1@34c0328

In this case, 'watch' is a setting. See inspect watch
> inspect watch
[info] Setting: sbt.Watched = sbt.Defaults$$anonfun$watchSetting$1$$anon$1@2aec1c4d
[info] Description:
[info] 	Continuous execution configuration.
[info] Provided by:
[info] 	{file:/Users/jcheng/work/demo/hello-finagle/}finagle/*:watch
[info] Dependencies:
[info] 	*:poll-interval
[info] 	*:this-project-ref
[info] Delegates:
[info] 	*:watch
[info] 	{.}/*:watch
[info] 	*/*:watch
> inspect poll-interval
[info] Setting: Int = 500
[info] Description:
[info] 	Interval between checks for modified sources by the continuous execution command.
[info] Provided by:
[info] 	*/*:poll-interval
[info] Reverse dependencies:
[info] 	*:watch
[info] Delegates:
[info] 	*:poll-interval
[info] 	{.}/*:poll-interval
[info] 	*/*:poll-interval
[info] Related:
[info] 	*/*:poll-interval

When you type in ~compile at the SBT command line, SBT will look for changes every 500 ms (poll-interval) and recompile if something changes. Using the inspect command on watch tells us that you can configure the watch setting by setting the poll interval to a different value, e.g.,
  pollInterval := 2000

Now SBT will look for changes every 2 seconds instead.
So in short, the watch setting won't help here.

https://github.com/tototoshi/sbt-build-files-watcher

@jsuereth @xuwei-k FYI:
https://github.com/tototoshi/sbt-build-files-watcher/issues/1#issuecomment-72304860

Fixed in https://github.com/sbt/sbt/pull/4335/commits/28fd4a1e618f938f9e1a4bd9639255c90a629cba#diff-6373e7f7122325e753b75fe1cc76ff5fR391?

@dwijnand looks like it, will need to try

@eatkins How does watchProjectSources work? Is it still hooked up?

In my outstanding PRs, I added the feature where changes to *.sbt and *.scala files can automatically trigger a rebuild in a continuous build. We could also add a task that checks for diffs and to the build files and either automatically rebuilds or prints a warning if there are any changes. When to evaluate that task is not entirely obvious. My first thought would be to put it in the compile task, but you might want to automatically reload when running any arbitrary task. That would require running this check before any task evaluation which does add a small overhead. I think that's probably fine as long as it's configurable.

@eed3si9n and I discussed this in today's meeting. The continuous builds in 1.3.0-M3 do watch the project source files and will automatically reload if they've changed. I don't think that it makes sense to have that feature by default if we do not support automatic reloading (or warnings) in regular task evaluation. Given that, I think it makes sense to either put the automatic reloading in continuous builds feature behind a sys prop or to get it working in regular task evaluation before 1.3.0.


version 1.0 Binder Error: Referenced column "x" not found in FROM clause!

When using DuckDB 1.0 in C#, I got the following error:
Binder Error: Referenced column "city" not found in FROM clause!
LINE 1: ..._lo, temp_hi, prcp, date, id) VALUES (@city, @temp_lo, @temp_hi, @prcp, @date,...
my statement is:  INSERT INTO weather (city, temp_lo, temp_hi, prcp, date, id) VALUES (@city, @temp_lo, @temp_hi, @prcp, @date, @id );
where the DuckDBParameter are all correctly assigned, including ParameterName, SourceColumn, DateType and Value.
If NOT using parameters and hard coding above insert statement, it works well. When using parameters, I got above error.
Searching the web, I found other users got similar error message but their causes might be different. However, here the "FROM clause" is not relative.
Thank you for your hard work.

@jp200k Can you format the code as a code snippet? It's hard to read now.

According to duckdb doc prepared_statements, no start with @ paramter accept. Can you try to use like $city? @jp200k

This is a common scenario people run into (including myself). As @Cricle stated, the parameters need to be prefixed with $ not @. Otherwise you get the referenced error, which is a little misleading.
@jp200k so instead of:
INSERT INTO weather (city, temp_lo, temp_hi, prcp, date, id)
VALUES (@city, @temp_lo, @temp_hi, @prcp, @Date, @id);

try:
INSERT INTO weather (city, temp_lo, temp_hi, prcp, date, id)
VALUES ($city, $temp_lo, $temp_hi, $prcp, $Date, $id);

@brendonparker Thanks for confirming that this is not a DuckDB.NET issues. This is documented in the docs: https://duckdb.net/docs/basic-usage.html#parameterized-statements


How does the plugin get configuration information from the JFrog CLI?

How can we help?
I have a question about the JFrog CLI in respect to how it's integrated with Gradle. When I'm executing a GitHub Action, I am running the steps shown here:

My question: When I'm executing the "jf gradle" command, do I have access inside Gradle (in an extension or something) to what is set via the "--repo-deploy" switch passed to the "jf gradle-config" command? I'm trying to get access to this information for an in-house plugin that I'm currently working on.
I've launched both the JFrog CLI and Gradle with debug logging and nothing is really jumping out at me.
Thanks for your time!

@prestontim,
When you use jf gradle, the JFrog CLI injects the Gradle Artifactory plugin using a Gradle init script. This plugin is responsible for gathering the publication and extracting deployment candidates. Eventually, the complete artifacts and build-info are sent for publication to Artifactory.
If you could provide more details about your goal, I could offer you a more precise answer.

@prestontim
Appreciate you sharing the use case. I'm a bit uncertain about whether you're aiming to configure the repository key for the Gradle Artifactory plugin or if your goal is to retrieve the repository key.
From the provided screenshot, it appears that you're attempting to establish the deployment repository, distinguishing between snapshot and release. The plugin's code already handles the decision-making process for deploying to either repository, depending on the deployment path. For instance, if the path contains "-SNAPSHOT," the deployment is directed to the snapshot repository. You can check the implementation here: PublicationUtils.java#L406.
That being said, there's still a bit of fine-tuning needed before we can roll out this feature completely. You can take a look at the necessary adjustments here: https://github.com/yahavi/artifactory-gradle-plugin/commit/2bb42350daa11001a4adab2e89dea0d41ddd5374.
Example:
publish {
  repository {
    releaseRepoKey = 'libs-release-local'
    snapshotRepoKey = 'libs-snapshot-local'
  }
}

If we were to implement this feature, would it fulfill your requirements?
Thanks!

@prestontim
In Gradle Artifactory plugin v5.2.0 we added the above functionality of configuring release and snapshot repositories.
Feel free to use it and share your feedback with us.


Cluster goes into updating state when adding a worker node and a panic is seen on the cluster

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

This is on an upgraded rancher from 2.3.6 to 2.4.3-rc2
Deploy a custom cluster - 3 etcd, 2 control, 3 worker nodes in 2.3.6
upgrade rancher to 2.4.3-rc2
Add a worker node.
Worker node is stuck in "Registering" state
Add another worker node.
This is also stuck in Registering state,
But an existing worker node in cluster is in "Cordoned" state
Cluster goes into "Updating" state.
An rke up is triggered.
Now the cluster is stuck in "Updating" state
There is a panic in the cluster

Updated cluster [c-lr9nb] with node version [2]
2020/04/24 01:15:52 [INFO] Provisioned cluster [c-lr9nb]
2020/04/24 01:15:52 [INFO] checking cluster [c-lr9nb] for worker nodes upgrade
2020/04/24 01:15:52 [ERROR] NodeController c-lr9nb/upgrade_ recovered from panic "runtime error: invalid memory address or nil pointer dereference". (err=<nil>) Call stack:
goroutine 18685 [running]:
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/runtime.RecoverFromPanic(0xc008911d30)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:158 +0xb5
panic(0x3686aa0, 0x6c38100)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/rancher/rancher/pkg/controllers/management/rkeworkerupgrader.(*upgradeHandler).upgradeCluster(0xc00b5af340, 0xc0052e9700, 0xc0064a26a0, 0x10, 0x0, 0x0, 0x0)
	/go/src/github.com/rancher/rancher/pkg/controllers/management/rkeworkerupgrader/upgrade.go:262 +0x630
github.com/rancher/rancher/pkg/controllers/management/rkeworkerupgrader.(*upgradeHandler).Sync(0xc00b5af340, 0xc0064a26a0, 0x10, 0x0, 0xc000abc380, 0x7f63c16cc6d0, 0x0, 0x0)
	/go/src/github.com/rancher/rancher/pkg/controllers/management/rkeworkerupgrader/upgrade.go:84 +0xfc0
github.com/rancher/rancher/vendor/github.com/rancher/types/apis/management.cattle.io/v3.(*nodeController).AddHandler.func1(0xc0064a26a0, 0x10, 0x0, 0x0, 0xc0077a3cd8, 0x3, 0x3, 0x0)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/types/apis/management.cattle.io/v3/zz_generated_node_controller.go:152 +0xe0
github.com/rancher/rancher/vendor/github.com/rancher/norman/controller.(*genericController).syncHandler(0xc006a6f480, 0x33c6780, 0xc009e74c40, 0x0, 0x0)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:387 +0x371
github.com/rancher/rancher/vendor/github.com/rancher/norman/controller.(*genericController).processNextWorkItem(0xc006a6f480, 0x0)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:296 +0xef
github.com/rancher/rancher/vendor/github.com/rancher/norman/controller.(*genericController).runWorker(0xc006a6f480)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:284 +0x2b
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc009713710)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152 +0x5e
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc009713710, 0x3b9aca00, 0x0, 0x1, 0xc001ac5020)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153 +0xf8
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait.Until(0xc009713710, 0x3b9aca00, 0xc001ac5020)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x4d
created by github.com/rancher/rancher/vendor/github.com/rancher/norman/controller.(*genericController).run
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:276 +0xe8

2020/04/24 01:15:53 [INFO] checking cluster [c-lr9nb] for worker nodes upgrade
2020/04/24 01:15:53 [ERROR] NodeController c-lr9nb/upgrade_ recovered from panic "runtime error: invalid memory address or nil pointer dereference". (err=<nil>) Call stack:
goroutine 18686 [running]:
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/runtime.RecoverFromPanic(0xc008fd7d30)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:158 +0xb5
panic(0x3686aa0, 0x6c38100)
	/usr/local/go/src/runtime/panic.go:679 +0x1b2
github.com/rancher/rancher/pkg/controllers/management/rkeworkerupgrader.(*upgradeHandler).upgradeCluster(0xc00b5af340, 0xc0052e9700, 0xc0064a26a0, 0x10, 0x0, 0x0, 0x0)
	/go/src/github.com/rancher/rancher/pkg/controllers/management/rkeworkerupgrader/upgrade.go:262 +0x630
github.com/rancher/rancher/pkg/controllers/management/rkeworkerupgrader.(*upgradeHandler).Sync(0xc00b5af340, 0xc0064a26a0, 0x10, 0x0, 0xc0091a9880, 0x7f63c16cc6d0, 0x0, 0x0)
	/go/src/github.com/rancher/rancher/pkg/controllers/management/rkeworkerupgrader/upgrade.go:84 +0xfc0
github.com/rancher/rancher/vendor/github.com/rancher/types/apis/management.cattle.io/v3.(*nodeController).AddHandler.func1(0xc0064a26a0, 0x10, 0x0, 0x0, 0xc00773acd8, 0x3, 0x3, 0x0)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/types/apis/management.cattle.io/v3/zz_generated_node_controller.go:152 +0xe0
github.com/rancher/rancher/vendor/github.com/rancher/norman/controller.(*genericController).syncHandler(0xc006a6f480, 0x33c6780, 0xc009e74c40, 0x0, 0x0)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:387 +0x371
github.com/rancher/rancher/vendor/github.com/rancher/norman/controller.(*genericController).processNextWorkItem(0xc006a6f480, 0x0)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:296 +0xef
github.com/rancher/rancher/vendor/github.com/rancher/norman/controller.(*genericController).runWorker(0xc006a6f480)
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:284 +0x2b
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1(0xc009713720)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152 +0x5e
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil(0xc009713720, 0x3b9aca00, 0x0, 0x1, 0xc001ac5020)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153 +0xf8
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait.Until(0xc009713720, 0x3b9aca00, 0xc001ac5020)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88 +0x4d
created by github.com/rancher/rancher/vendor/github.com/rancher/norman/controller.(*genericController).run
	/go/src/github.com/rancher/rancher/vendor/github.com/rancher/norman/controller/generic_controller.go:276 +0xe8

2020/04/24 01:15:55 [INFO] checking cluster [c-lr9nb] for worker nodes upgrade
2020/04/24 01:15:55 [ERROR] NodeController c-lr9nb/upgrade_ recovered from panic "runtime error: invalid memory address or nil pointer dereference". (err=<nil>) Call stack:
goroutine 18682 [running]:
github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/runtime.RecoverFromPanic(0xc004ae9d30)
	/go/src/github.com/rancher/rancher/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:158 +0xb5
panic(0x3686aa0, 0x6c38100)

Expected Result:
Cluster should not go into updating state when a worker node is added
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.3.6 to 2.4.3-rc2
Installation option (single install/HA): single

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): custom RKE
Kubernetes version (use kubectl version):

1.17.4

Panic and the cordoning does not seem to be related as per this bug -- https://github.com/rancher/rancher/issues/26807

Verified on a custom image from 2.4-release and master branch
Steps:

Create a custom cluster - 1 node all roles
Add a worker node - The worker node will be stuck in registering state because of this issue - https://github.com/rancher/rancher/issues/26790
Add more worker nodes
No panic is seen
The cluster goes into Updating state for about 3-5 seconds and comes back to Active.
Existing "Active" worker nodes do NOT go into "Cordoned" state.


add objectionjs-graphql package to plugins documentation

objectionjs-graphql it's an updated version to support GraphQl

@firassziedan this is interesting! Shall we try and get your changes merge to the upstream one? How is compatiblity?

@lehni this will be great, this needs a major update there are a lot of changes that need to do, but it's possible.


Add documentation to the google_assistant add-on

The google_assistant add-on, currently, does not have documentation in its repository.
We should add it, so the users see the documentation and information in the Hass.io add-on and add-on store pages in the Home Assistant frontend.
A README.md file needs to be added. The documentation of the check_config add-on is a good example that can be used.

Hey! I would like to work on it

Thanks! Looking forward to the PR 🎖


showLastUpdate Vietnamese translation typo

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[ ] I have tried the npm run clear or yarn clear command.
[ ] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
When using showLastUpdateAuthor and showLastUpdateTime in Vietnamese language, there is a typo when the word "bởi" (which means "by") duplicates twice.

Reproducible demo
No response
Steps to reproduce
In your docusaurus.config.js:
i18n: {
		defaultLocale: "vi",
		locales: ["vi"],
	},
presets: [
		[
			//...
			({
				docs: {
					showLastUpdateAuthor: true,
					showLastUpdateTime: true,
				}
			}),
		],
	],

Expected behavior
It should be "Cập nhật lần cuối vào Date bởi Author"
Actual behavior
Instead of "Cập nhật lần cuối vào Date bởi bởi Author"
Your environment

Public source code:
Public site URL:
Docusaurus version used:
Environment name and version (e.g. Chrome 89, Node.js 16.4):
Operating system and version (e.g. Ubuntu 20.04.2 LTS):

Self-service

[ ] I'd be willing to fix this bug myself.

Thanks, should be fixed in https://github.com/facebook/docusaurus/pull/8424
Can you confirm this sentence looks good?

Cập nhật lần cuối vào {date} bởi {user}

@slorber that looks good 👍

thanks 👍