Handle unexpected HTTP verb

I have Raxx and Ace running in production and noticed some error logs with weird HTTP verbs like PROPFIND, PING and WSPB.
Someone is obviously trying to find security flaws and hoping to see certain systems like WebDAV.
How can I handle unexpected HTTP verbs? In this case I would like to just return a 404 or similar and not log an error to my log.
I can reproduce locally by starting my Ace/Raxx app and hitting it with this curl:
➤ curl localhost:4010 -X PROPFIND
curl: (52) Empty reply from server

It will give this error log, which is similar to the one on my production deploy:
➤ iex -S mix
Erlang/OTP 21 [erts-10.3] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe]

21:56:53.736 [info]  Serving cleartext using HTTP/1 on port 4010
Interactive Elixir (1.8.1) - press Ctrl+C to exit (type h() ENTER for help)
iex(1)>
21:56:55.083 [error] GenServer #PID<0.256.0> terminating
** (FunctionClauseError) no function clause matching in Raxx.request/2
    (raxx) lib/raxx.ex:133: Raxx.request("PROPFIND", %URI{authority: nil, fragment: nil, host: nil, path: "/", port: nil, query: nil, scheme: nil, userinfo: nil})
    (ace) lib/ace/http1/parser.ex:232: Ace.HTTP1.Parser.build_partial_request/2
    (ace) lib/ace/http1/parser.ex:129: Ace.HTTP1.Parser.pop_part/1
    (ace) lib/ace/http1/parser.ex:48: Ace.HTTP1.Parser.parse/3
    (ace) lib/ace/http1/endpoint.ex:64: Ace.HTTP1.Endpoint.handle_info/2
    (stdlib) gen_server.erl:637: :gen_server.try_dispatch/4
    (stdlib) gen_server.erl:711: :gen_server.handle_msg/6
    (stdlib) gen_server.erl:661: :gen_server.try_handle_call/4
Last message: {:tcp, #Port<0.8>, "PROPFIND / HTTP/1.1\r\nHost: localhost:4010\r\nUser-Agent: curl/7.58.0\r\nAccept: */*\r\n\r\n"}
State: %Ace.HTTP1.Endpoint{channel: %Ace.HTTP.Channel{endpoint: #PID<0.256.0>, id: 1, socket: {:tcp, #Port<0.8>}}, keep_alive: false, monitor: #Reference<0.69145361.3102212101.20885>, pending_ack_count: 0, receive_state: {:start_line, "", %{max_line_length: 2048}}, socket: {:tcp, #Port<0.8>}, status: {:request, :response}, worker: #PID<0.457.0>}

21:56:55.085 [error] GenServer #PID<0.256.0> terminating
** (FunctionClauseError) no function clause matching in Raxx.request/2
    (raxx) lib/raxx.ex:133: Raxx.request("PROPFIND", %URI{authority: nil, fragment: nil, host: nil, path: "/", port: nil, query: nil, scheme: nil, userinfo: nil})
    (ace) lib/ace/http1/parser.ex:232: Ace.HTTP1.Parser.build_partial_request/2
    (ace) lib/ace/http1/parser.ex:129: Ace.HTTP1.Parser.pop_part/1
    (ace) lib/ace/http1/parser.ex:48: Ace.HTTP1.Parser.parse/3
    (ace) lib/ace/http1/endpoint.ex:64: Ace.HTTP1.Endpoint.handle_info/2
    (stdlib) gen_server.erl:637: :gen_server.try_dispatch/4
    (stdlib) gen_server.erl:711: :gen_server.handle_msg/6
    (stdlib) gen_server.erl:661: :gen_server.try_handle_call/4
Last message (from #PID<0.255.0>): {:accept, {:tcp, #Port<0.7>}}
State: %Ace.HTTP.Server{settings: [port: 4010, cleartext: true], socket: nil, worker_supervisor: #PID<0.252.0>}
Client #PID<0.255.0> is alive

    (stdlib) gen_server.erl:403: :gen_server.loop/7
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3

21:56:55.085 [error] GenServer #PID<0.457.0> terminating
** (FunctionClauseError) no function clause matching in Raxx.request/2
    (raxx) lib/raxx.ex:133: Raxx.request("PROPFIND", %URI{authority: nil, fragment: nil, host: nil, path: "/", port: nil, query: nil, scheme: nil, userinfo: nil})
    (ace) lib/ace/http1/parser.ex:232: Ace.HTTP1.Parser.build_partial_request/2
    (ace) lib/ace/http1/parser.ex:129: Ace.HTTP1.Parser.pop_part/1
    (ace) lib/ace/http1/parser.ex:48: Ace.HTTP1.Parser.parse/3
    (ace) lib/ace/http1/endpoint.ex:64: Ace.HTTP1.Endpoint.handle_info/2
    (stdlib) gen_server.erl:637: :gen_server.try_dispatch/4
    (stdlib) gen_server.erl:711: :gen_server.handle_msg/6
    (stdlib) gen_server.erl:661: :gen_server.try_handle_call/4
Last message: {:DOWN, #Reference<0.69145361.3102212101.20884>, :process, #PID<0.256.0>, {:function_clause, [{Raxx, :request, ["PROPFIND", %URI{authority: nil, fragment: nil, host: nil, path: "/", port: nil, query: nil, scheme: nil, userinfo: nil}], [file: 'lib/raxx.ex', line: 133]}, {Ace.HTTP1.Parser, :build_partial_request, 2, [file: 'lib/ace/http1/parser.ex', line: 232]}, {Ace.HTTP1.Parser, :pop_part, 1, [file: 'lib/ace/http1/parser.ex', line: 129]}, {Ace.HTTP1.Parser, :parse, 3, [file: 'lib/ace/http1/parser.ex', line: 48]}, {Ace.HTTP1.Endpoint, :handle_info, 2, [file: 'lib/ace/http1/endpoint.ex', line: 64]}, {:gen_server, :try_dispatch, 4, [file: 'gen_server.erl', line: 637]}, {:gen_server, :handle_msg, 6, [file: 'gen_server.erl', line: 711]}, {:gen_server, :try_handle_call, 4, [file: 'gen_server.erl', line: 661]}]}}
State: %Ace.HTTP.Worker{app_module: LurtzWeb.WebServer, app_state: %{}, channel: %Ace.HTTP.Channel{endpoint: #PID<0.256.0>, id: 1, socket: {:tcp, #Port<0.8>}}, channel_monitor: #Reference<0.69145361.3102212101.20884>}

I don't have an answer ready for this issue.
These logs come from the parser in Ace, because each connection is isolated there is no harm in these logs but in that case they should not keep spamming your logs.
In my opinion there are two options here.

have Ace automatically return a default 400 response for any parser failure, it currently does this for several other kinds of "bad request"
expose these methods to the Raxx app and let user handle them as they want. This has problems because turning unknown methods to atoms opens up an attack vector to flood the atom table.

My preference is for 1 because it is simpler, and it handles the case you need right now.

@CrowdHailer 1. works for me too. I have not yet looked at Ace source code, but please let me know if you would like me to take a go on it ;)

It would be great if there were more eyes on the ace code. 👍
I'm hoping not too hard an issue to fix, hopefully just one extra case
clause somewhere.
On Thu, 28 Mar 2019, 05:05 Lasse Skindstad Ebert<EMAIL_ADDRESS>wrote:

@CrowdHailer https://github.com/CrowdHailer 1. works for me too. I have
not yet looked at Ace source code, but please let me know if you would like
me to take a go on it ;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CrowdHailer/raxx/issues/173#issuecomment-477449723,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFlznqpdzAYvqsZoj212nI6NBs8jR7Siks5vbE2xgaJpZM4cOxKG
.

I think it should just send a default 501 response

The 501 (Not Implemented) status code indicates that the server does
not support the functionality required to fulfill the request.  This
is the appropriate response when the server does not recognize the
request method and is not capable of supporting it for any resource.   A 501 response is cacheable by default; i.e., unless otherwise
indicated by the method definition or explicit cache controls (see
Section 4.2.2 of [RFC7234]).

@lasseebert Fixed in Ace with this commit https://github.com/CrowdHailer/Ace/commit/6a456447d5562385124f56d95e1b1f6dc2367c8f
Will release 0.18.7 soon

Awesome, thanks!


Split the root build script into multiple scripts.

Split the root build script into multiple scripts.
Add coveralls support.

Changes Unknown when pulling 1a2a5e44dc3076f5c9cbdd7b569bd444f6eda13a on mars-lan:coveralls2 into ** on linkedin:linkedin**.

Hi @mars-lan , maybe we need to resolve conflict and merge this also, along with the gradle play plugin change.

Yup doing that right now.


Support authorization on Apollo Federation _entities query

Product
Hot Chocolate
Is your feature request related to a problem?
I want to use a .NET AuthorizationHandler to authorize entity resolution, that is, calls to the _entities query.
I have successfully set up .NET authorization in a project so that regular methods of the top-level Query class, annotated with [Authorize("SomeRequirement")], are getting authorized as expected.
There seems to be no way in the current stable version (13.5.1 at the time of this writing) to make that authorization apply to the _entities query.  Here are the things I've tried:

Annotating the entity resolver class and/or method with [Authorize("SomeRequirement")].  This is the method registered with ResolveReferenceWith for the GraphQL type.
Annotating the GraphQL entity type with [Authorize("SomeRequirement")]
Annotation the top-level Query class with [Authorize("SomeRequirement")].  This results in an extra authorization call for regular methods in the Query class (one because of the annotation on the class and one because of the annotation on the method).

Using any of the methods above calling the _entities query does not trigger any authorization, as far as I can tell.
I've spent some time trying to understand how HotChocolate .NET authorization works, and it seems that for the _entities query that AuthorizationTypeInterceptor is not getting triggered.
It's entirely possible that I'm missing something obvious to make this work.  If so, just close this issue with a comment pointing to some sample code and I'll be very grateful!
The solution you'd like
I want to be able to authorize Apollo Federation entity resolution (the _entities query) the same way as regular queries.

@michaelstaib, can you verify whether I am right above that authorization does not currently apply to the _entities query?  Thanks.

What I see is that no field resolver level extensions function for entities, which kind of makes some sense since the resolver itself is not a field(the field is _entities), but it does make things annoying. Internally the reference resolvers are FieldResolverDelegates so it seems that this wouldn't be too much of a stretch.

It seems like this makes HotChocolate Apollo federation a no-go for most use cases.  Authorization is not optional.
I hope the answer isn't to switch to fusion.

Any updates for the authorization issue of reference resolvers? When can we expect a fix for it?

We will have a look at this next week.. I will include it in the next patch release.

Thank you.  I am glad this can be addressed soon.

https://github.com/ChilliCream/graphql-platform/pull/6769

I worked around this by using ApplyPolicy.Validation which does still fire for _entities

I couldn't use ApplyPolicy.Validation but worked around with with
     .AddQueryType(d =>
            {
                d.Name("Query").Authorize();
                d.Extend().OnBeforeCompletion((ctx, definition) =>
                {
                    // There is probably a better way to do this.
                    // But the _service and _entities fields don't exist until after the federation type interceptor has run
                    // and it doesn't check if the fields already exist, or have any way to modify the creation
                    var serviceField = definition.Fields.Single(f => f.Name == "_service");
                    var serviceFieldDescriptor = ObjectFieldDescriptor.From(ctx.DescriptorContext, serviceField);
                    serviceFieldDescriptor.AllowAnonymous();

                    var entityField = definition.Fields.Single(f => f.Name == "_entities");
                    var entityFieldDescriptor = ObjectFieldDescriptor.From(ctx.DescriptorContext, entityField);
                    entityFieldDescriptor.Authorize();
                });
            })

I worked around this by using ApplyPolicy.Validation which does still fire for _entities

I couldn't use ApplyPolicy.Validation but worked around with with

This is much nicer than how I was working around it, so definitely do this instead.

I couldn't use ApplyPolicy.Validation but worked around with with
     .AddQueryType(d =>
            {
                d.Name("Query").Authorize();
                d.Extend().OnBeforeCompletion((ctx, definition) =>
                {
...
                    entityFieldDescriptor.Authorize();
                });
            })

I can sort of get this to work, but as quoted above I end up with a directive that has no policy.  I can add a policy to the Authorize call above and see it on authorization, but in my use case I want a different policy for each different type of entity resolved.  It seems like I should be able to annotate the entity type or maybe the entity resolver, but I've tried all that to no avail.

Yah , I don't think you can do that currently, since the return type of
_,entities is any there's no "field" to attach it to.
The primary issue is that none of the usual field middleware attributes
are applied to reference resolvers. This is not only Authorize but also
UseProjection and some DI doesn't work the same.
I believe this is getting addressed in HC 14 by properly implementing the
field middleware. Last week Michael said he had a branch he hoped to merge
by last Friday.
On Thu, Jan 25, 2024, 11:47 AM Jeff Clary @.***> wrote:

I couldn't use ApplyPolicy.Validation but worked around with with
 .AddQueryType(d =>            {                d.Name("Query").Authorize();                d.Extend().OnBeforeCompletion((ctx, definition) =>                {...                    entityFieldDescriptor.Authorize();                });            })

I can sort of get this to work, but as quoted above I end up with a
directive that has no policy. I can add a policy to the Authorize call
above and see it on authorization, but in my use case I want a different
policy for each different type of entity resolved. It seems like I should
be able to annotate the entity type or maybe the entity resolver, but I've
tried all that to no avail.
—
Reply to this email directly, view it on GitHub
https://github.com/ChilliCream/graphql-platform/issues/6546#issuecomment-1910881505,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACEVOY6NXEHYGHBX7Q2HYCDYQKZEDAVCNFSM6AAAAAA4763P3KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJQHA4DCNJQGU
.
You are receiving this because you commented.Message ID:
@.***>


Error message improvement

See issue https://github.com/tensorflow/tensorflow/issues/7675

Can one of the admins verify this patch?

I signed it!

@tensorflow-jenkins test this please


App crashes upon settings update with wrong values

Hi, just to clarify : It's my first bug report. Sorry if I'm not specific enough about the issue.
I installed ScriptKit a few days ago. Made my first script this morning. It worked fine.
By default, await terminal() opens native macOS terminal. I changed it to iTerm by going to the settings.js (I believe, opened the config in the menu bar) and adding the "terminal" : "iTerm" value-key. It then crashed to this error.
I have watched John Lindquist video with Jason on Learn With Jason, and he made him change the code editor by going to the settings.
I have seen a few issues about this problem, is it the config change that triggered the crash, or something else ?
I don't know where the config file directory is located. Can't open ScriptKit anymore to change it sadly.
TypeError: Object has been destroyed
    at Fo (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:131018)
    at /Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:130065
    at l (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:110839)
    at Generator.<anonymous> (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:112177)
    at Generator.next (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:111202)
    at co (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:116831)
    at a (/Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:117035)
    at /Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:117096
    at new Promise (<anonymous>)
    at /Applications/Kit.app/Contents/Resources/app.asar/main.prod.js:2:116975

[2023-02-27 06:56:29.829] [info] kenv found
[2023-02-27 06:56:29.829] [info] node found
[2023-02-27 06:56:29.829] [info] node found
[2023-02-27 06:56:29.830] [info] node_modules found
[2023-02-27 06:56:29.830] [info] node_modules found
[2023-02-27 06:56:29.830] [info] kenv is configured
[2023-02-27 06:56:29.830] [info] kenv .env found
[2023-02-27 06:56:29.830] [info] Install verified
[2023-02-27 07:48:00.536] [info] 🪟 window-all-closed
Kit 1.48.0
Electron 22.0.3
darwin 22.1.0
Locale: en-GB

I followed the advice from OP here https://github.com/johnlindquist/kit/issues/1133 and removed ScriptKit App from macOS.
It was not enough, so I had to rm -rf .kenv .kit to delete both the files.
After that, a clean install worked for me. I will not edit the Config Settings again, as I am sure they caused the crash when I added a new property. Or maybe I wrote it wrong.

@Varkoff Thanks for reporting. I do need to handle malformed config files. I'll try to sneak it into tomorrow's build

Thank you for the tip. I must confess, I didn't know where the config files were located. 🙂


Store the Augmented FFCV Data then Load it?

Since some data augmentation techniques in transforms are not supported in FFCV (Ref. the end of #84)
Is it recommended to store the augmented data (e.g. crop, flip, color jitter, gray scale, gaussian blur) as beton first then load it directly? So we can augment them by transforms and at the same time avoid slowing the FFCV loading. But not sure whether there exists other costs that I was not aware of.

Thanks for the reply! Yes I agreed and did it later via zipping the FFCV data loader, and using both FFCV and torchvision's data augmentation (it is a pity that both this FFCV and meta's FFCV-SSL don't work well on the SSL's data augmentation)


NucPlot.py error

Hi,
Many thanks for this tool to evaluate the quality of an assembly.
I was trying to make a plot of a region with NucPlot.py but encountered the following error.
Using a font-size of 16
Packages loaded
Reading in the region or bed argument(s).
Reading in NucFreq from region: h1tg000093l:3555483-3557483
Traceback (most recent call last):
File "/NucFreq/NucPlot.py", line 178, in
cov = getCovByBase(contig, start, end)
File "/NucFreq/NucPlot.py", line 156, in getCovByBase
contig, start=start, stop=end, read_callback="nofilter", quality_threshold=None
File "pysam/libcalignmentfile.pyx", line 1592, in pysam.libcalignmentfile.AlignmentFile.count_coverage
TypeError: 'NoneType' object is not subscriptable
my command structure was like thus:
python /NucFreq/NucPlot.py --bed bedFile.bed -t 8 sortedBamFileInput.bam outputFileName
Any suggestions on what to do?
Thanks in advance.

Hi,
For other folks who may have similar issues, I figured out the problem after some more digging.
Pysam version was the problem. I had to install the latest version and this made the problem go away.
I will close this issue immediately.
Many thanks for the tool.


Using auth token for webhook

Toward https://github.com/giantswarm/giantswarm/issues/13201
Checklist

[ ] Update changelog in CHANGELOG.md.

Tested in gauss


Umbrella bug: Too many lists in k8s cluster

As reported in #6514 lists can be very heavy. Currently majority of CPU usage in apiserver is caused by list handler. We should limit this significantly.
Subtasks:

[ ] Replication controller issues too many lists #6562
[ ] Endpoints controller issues maaany lists #6518
[ ] Scheduler is not using watch to monitor nodes #6563

@wojtek-t @lavalamp @davidopp

#6513 may also be part of this effort.

Please see: https://github.com/GoogleCloudPlatform/kubernetes/issues/4817#issuecomment-89437368

@fgrzadkowski I don't completely understand the tradeoffs involved in swapping out those lists for watches,  thoughts on how we can avoid an Umbrella bug with %s/lists/watches down the line?

@bprashanth Sorry, but I don't understand your comment. I don't think there are any tradeoffs here. Semantically we will have exactly the same logic, but without reading the same objects multiple times.

Listing is less error-prone than watching.  We should definitely support
clients that want to list frequently.  The reported CPU saturation does not
make sense given the quantities of data involves, suggesting a pathological
bug.   That should be fixed first.
On Tue, Apr 14, 2015 at 12:00 AM, Filip Grzadkowski <
<EMAIL_ADDRESS>wrote:

@bprashanth https://github.com/bprashanth Sorry, but I don't understand
your comment. I don't think there are any tradeoffs here. Semantically we
will have exactly the same logic, but without reading the same objects
multiple times.
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/issues/6564#issuecomment-92657560
.

Watching involves continuously filtering every change on the server as it occurs, while listing is just filtering all objects as they currently exist (so if an object goes from rv 1->100, all 100 are sent down the watch, but only the 100th will be sent down the list). I would expect watches to add some constant strain, especially since the watch also does a periodic list every 5 minutes.

@erictune Please see my example in this https://github.com/GoogleCloudPlatform/kubernetes/issues/6514#issuecomment-93226784
@bprashanth I agree that listing is easier for some clients, but:
a) we already have simple libraries that make using watch very easy (watch-based cache)
b) current implementation of label/field selectors is sub-optimal
c) if we control some clients (such as controllers) we should make them as light-weight (from apiserver perspective) as possible. Obviously we will have to support lists and make them faster (see #6514 and #6800) but that's a completely separate story

After fixing #6518 situation improved but we still have high number (in terms of CPU usage) of lists. This happens in density test when replication controller creates new pods. I'm debugging what's the source (I don't think it's RC).
@wojtek-t

@rrati ^

Only remaining issue is #6562 so closing this one.


[Bug Report] Show password and clear icon on input type password

Element UI version
2.15.1
OS/Browsers version
Linux/Microsoft edge Version 91.0.825.0
Vue version
2.6.12
Reproduction Link
https://jsfiddle.net/wanwas/0obnagpz/1/
Steps to reproduce
enter something in the field
What is Expected?
The presence of only one icon for showing/hiding the password, which does not overlap the icon for clearing the field
What is actually happening?
There are two hide/show password icons, one of which overlaps the clear field icon.

This is the default edge styles applied to the input of the password type, we need use
::-ms-reveal {
width : 0;
height: 0;
}


Renamed prof-webschoolfactory.fr to prof-webschoolfactory.txt

The domain prof-webschoolfactory.fr is not recognized due to bad extension fr => txt.

@yohang Thank you very much for the update. Pull request merged.


Design multiple color corrections/update API spec

Users desire the ability to version and switch between different color corrections for a project. Color corrections are currently stored on the relation between the scenes and projects with only one able to be added and saved. We need to add support to have multiple ones, it is not immediately obvious the best way to do that or how to approach that.
One approach -- create a new relation, "color corrections", that have a foreign key back to scenes-to-projects and add a version to them.
Another approach -- keep overloading the jsonb field to store multiple color corrections.
Another consideration -- we may want to allow users to define their own color corrections, but not edit anything else on a project

Whoever takes this, please check in with @designmatty -- this might end up more of a brainstorm task than anything else

Created another issue for further discussion w/ a google doc: https://github.com/azavea/raster-foundry/issues/1494


Handle results in the next page of Google Calendar API events

Effectively handling of NextPageToken is not done yet.
References

Paging through lists of resources

Ignore this issue for now as the limit of is 2500 and it is not common to hit it with my use cases.


Fix cluster unable to spin up issue

Description
Fix cluster unable to spin up issue
Related Issues
https://github.com/opensearch-project/observability/issues/1872
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[ ] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 can you help review this PR? Thanks.


Readme & Callback added

Added callback for if a file already exists on the disk
Added readme

Cheers! Hopefully it is clear :)


Current version was improperly published / wrong docs

Describe the bug
A clear and concise description of what the bug is.
When I install this SDK, the published folder structure is improperly formatted and doesn't even come close to the documentation in terms of how it can be used. There are a couple of issues; I'll capture both individually.

The published file structure is wrong. The package should be published from the dist directory but it seems to have been published from the root directory and includes the dist directory. See my screenshot of the published file structure below. It also includes a bunch of other files and such that do not belong in the published package like config files, etc.

The docs in the README do not match the Cloud docs. Neither of them are correct for the currently published structure. Once the structure is fixed, however, the docs should be made to match. The README is more correct in terms of what it should be. The Cloud docs have all sorts of issues.

For example, the README gives the import path: @ibm-cloud/ibm-schematics/schematics/v1.
The Cloud docs show the import as const { SchematicsV1 } = require('@ibm-cloud/schematics');
It would be useful to show a proper import (const SchematicsV1 = require('@ibm-cloud/ibm-schematics/schematics/v1');) in this example.
To Reproduce
List the steps that can be used to demonstrate the bug.  Include the name of the service and operation that you're trying to invoke, if applicable.  Be sure to describe any relevant info regarding parameter values used with your API invocation.

Create a new test directory and install the SDK

$ mkdir node-schematics-test
$ npm init -y
$ npm install "@ibm-cloud/ibm-schematics"

Create a file, index.js, with the following code:

const SchematicsV1 = require('@ibm-cloud/ibm-schematics/schematics/v1');
const { NoAuthAuthenticator } = require('@ibm-cloud/ibm-schematics/auth');

const authenticator = new NoAuthAuthenticator();

const service = new SchematicsV1({
    authenticator,
});

Run the code

$ node index.js

Expected behavior
A clear and concise description of what you expected to happen.
The code should run cleanly, with no errors or output. Instead, there is an exception:
Error: Cannot find module '@ibm-cloud/ibm-schematics/schematics/v1'
Screenshots
If applicable, add screenshots to help explain your problem.

Must gather (please complete the following information):

SDK Version 2.0.0
Node Version 16.16.0

Additional context
Add any other context about the problem here.
Were you able to avoid the problem by changing your application code slightly?

Latest version 2.0.3 is published with fixes. Hence closing the issue


GetUserInput fix

Don't know why, but it's need this.

the reason is the max length also includes the string terminator character('\0'), how its currently set up means if the max length set is 8, you can write 7 chars then the string terminator will be the 8th

Ok thank's for the explication ! But it's better if we dont always need to add one, isn't ?

In that case it would be better to change https://github.com/EdgeKiller/scripthookvdotnet/blob/dev/source/Game.cpp#L180 to the following then instead:
Native::Function::Call(Native::Hash::DISPLAY_ONSCREEN_KEYBOARD, true, windowTitle.ToString(), "", defaultText, "", "", "", maxLength + 1);

on the subject of GetUserInput, it would be wise to check if update_onscreen_keyboard = 1(user finished editing) before returning get_onscreen_keyboard_result, if it = 2 then that means the cancelled the input

Was fixed in #295.


old row new row, urgent

i would like to get old row and new row like https://www.npmjs.com/package/mysql-events. right now all i got is IntVar {
timestamp:<PHONE_NUMBER>000,
nextPosition: 4795,
size: 9,
type: 2,
value: 17,
binlogName: 'mysql-bin.000001'
} basically i want more detail. can you help me ?
and it doesnt detect update too. here is my code
const mysql = require('mysql');
const MySQLEvents = require('@rodrigogs/mysql-events');
const program = async () => {
const connection = mysql.createConnection({
host: 'localhost',
user: 'root',
password: '',
database: 'sociominer'
});
const instance = new MySQLEvents(connection, {
startAtEnd: true,
excludedSchemas: {
mysql: true,
},
});
await instance.start();
instance.addTrigger({
name: 'TEST',
expression: '*',
statement: MySQLEvents.STATEMENTS.ALL,
onEvent: (event) => {
console.log(event); // { type, schema, table, affectedRows: [], affectedColumns: [], timestamp, }
},
});
instance.on(MySQLEvents.EVENTS.CONNECTION_ERROR, console.error);
instance.on(MySQLEvents.EVENTS.ZONGJI_ERROR, console.error);
};
program()
.then(() => console.log('Waiting for database events...'))
.catch(console.error);
and db

i just want to see if there are insert update delete event from test table ( only test table ) and coresponding old row and new row
and what about if i want to listen specificly to certain table only cause currently i listen to al table. already try expression: '*.test', but no event comming instead ( no event )
note : i never and dont want to use schema if possible
my aim is really similar to this https://github.com/kuroski/mysql-events-ui/blob/master/server.js except i need to know which table and row inserted and updated so i know which client shoud i emitted to. especially on insert and update

and it doesnt detect update too. here is my code
const mysql = require('mysql');
const MySQLEvents = require('@rodrigogs/mysql-events');
const program = async () => {
const connection = mysql.createConnection({
host: 'localhost',
user: 'root',
password: '',
database: 'sociominer'
});
const instance = new MySQLEvents(connection, {
startAtEnd: true,
excludedSchemas: {
mysql: true,
},
});
await instance.start();
instance.addTrigger({
name: 'TEST',
expression: '*',
statement: MySQLEvents.STATEMENTS.ALL,
onEvent: (event) => {
console.log(event); // { type, schema, table, affectedRows: [], affectedColumns: [], timestamp, }
},
});
instance.on(MySQLEvents.EVENTS.CONNECTION_ERROR, console.error);
instance.on(MySQLEvents.EVENTS.ZONGJI_ERROR, console.error);
};
program()
.then(() => console.log('Waiting for database events...'))
.catch(console.error);
and db

you just simply need to traverse the log by calling the right event and traverse the array "e.affectedRows['0']"  remember if you have "startAtEnd: true" flag set to true you will not see the output until you actually trigger an event , if you want to view all existing events so that you can debug and traverse without triggering an event set it to false
`instance.addTrigger({
name: 'monitoring all statments',
expression: 'test.testtable.*',
statement: MySQLEvents.STATEMENTS.ALL,
onEvent: e => {
  console.log(e.affectedRows['0']['before']);
  console.log(e.affectedRows['0']['after']);

}

});`

My problem is similar to CrazyBunnyz's
The event does not show all the info and the expression does not work unless I put only '*'.
My output is similar:
IntVar {   timestamp:<PHONE_NUMBER>000,   nextPosition: 715,   size: 9,   type: 2,   value: 8,   binlogName: 'mysql-bin-changelog.000188' }


Question for model inference code

Question for model inference code: can we have audio, visual and text as inputs at the same time and then output either text or audio. (Input of text may as a background prompt for some tasks)

Hi, for now, we did not train with mixed input, so it may not work with mixed text + audio + image as input.

Thank you for your answer!


removing a worker-group fails

I can create a worker-group, e.g.:
$ cloudctl cluster update <cluster-id> --machineimage debian-10.0.20220531 --machinetype m1-large-x86 --minsize 1 --maxsize 1 --workergroup gitlab-runner

But removing it fails (I use the exact same  as in previous step; fails also if I pass all missing arguments as before):
$ cloudctl cluster update <cluster-id> --remove-workergroup gitlab-runner
Error: cluster update requires exactly one clusterID as argument

$ cloudctl version
client: v0.10.20 (65b4fbac), tags/v0.10.20-0-g65b4fba, 2022-06-28T10:02:08Z, go1.18.3
server:
    builddate: "2022-07-19T12:04:08Z"
    gitsha1: 84d8e419
    name: cloud-api
    revision: tags/v0.18.26-0-g84d8e41
    version: v0.18.26

try: cloudctl cluster update <cluster-id>  --workergroup gitlab-runner --remove-workergroup

Unfortunately still the same :(
$ cloudctl cluster update <cluster-id> --workergroup gitlab-runner --remove-workergroup gitlab-runner
Error: cluster update requires exactly one clusterID as argument

Ah sorry ! I had to leave out the last gitlab-runner
Works not! Perfect :-)


Distorted hyprcursor after 0.40.0 update

Bug or Regression?
Bug
System Info and Version
 System/Version info
Hyprland, built from branch  at commit 9e781040d9067c2711ec2e9f5b47b76ef70762b3  (props: bump version to 0.41.1).
Date: Thu Jun 13 09:54:06 2024
Tag: v0.41.1, commits: 4818

flags: (if any)

System Information:
System name: Linux
Node name: gigas-acer
Release: 6.9.4-x64v3-xanmod1
Version: #0~20240612.gadde0ab SMP PREEMPT_DYNAMIC Wed Jun 12 20:03:38 UTC

GPU information:
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA106M [GeForce RTX 3060 Mobile / Max-Q] [10de:2520] (rev a1) (prog-if 00 [VGA controller])
06:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Cezanne [Radeon Vega Series / Radeon Vega Mobile Series] [1002:1638] (rev c6) (prog-if 00 [VGA controller])

os-release: NAME="Manjaro Linux"
PRETTY_NAME="Manjaro Linux"
ID=manjaro
ID_LIKE=arch
BUILD_ID=rolling
ANSI_COLOR="32;1;24;144;200"
HOME_URL="https://manjaro.org/"
DOCUMENTATION_URL="https://wiki.manjaro.org/"
SUPPORT_URL="https://forum.manjaro.org/"
BUG_REPORT_URL="https://docs.manjaro.org/reporting-bugs/"
PRIVACY_POLICY_URL="https://manjaro.org/privacy-policy/"
LOGO=manjarolinux

plugins:

Description
As title says, after 0.40.0 update the hyprcursor is looking distorted comparing to xcursor (was working fine before update). I'm setting cursors through config this way:
# GTK cursors
# https://wiki.archlinux.org/title/GTK
exec = gsettings set org.gnome.desktop.interface cursor-theme 'Sweet-cursors'
exec = gsettings set org.gnome.desktop.interface cursor-size 20
env = XCURSOR_THEME,Sweet-cursors
env = XCURSOR_SIZE,20

# hyprcursors
exec = hyprctl setcursor Sweet-cursors-hyprcursor 20
env = HYPRCURSOR_THEME,Sweet-cursors-hyprcursor
env = HYPRCURSOR_SIZE,20

Example of xcursor (1st one) and hyprcursor (2nd one) to see the difference:

This is only one example, but you get the gist.
The hyprcursors's size also considerably smaller than xcursor variant.
The actual hyprcursor files are not distorted, e.g this is the same cursor file from /usr/share/icons/Sweet-cursors-hyprcursor/hyprcursors/pointer.hlc/pointer_002.png

Maybe related to #6320?
How to reproduce
Build the hyprcursors from raw files with PKGBUILD or just install this package
Crash reports, logs, images, videos
conf.txt

can you try a different hyprcursor theme to rule out a problem with the theme?

can you zip the buggy theme and attach it?

Sure thing
Sweet-cursors-hyprcursor.zip

https://standards.hyprland.org/hyprcursor/

ripbozo, theme is not to spec


How to unpack encrypted .unity3d?

Anyone know how to unpack encrypted .unity3d?
There is a "ENCRYPT_HEADER" string when I open the file with hex editor.
this is the function from Assembly-CSharp.dll
public static byte[] RemoveEncryptHeader(MemoryStream ms)
{
	byte[] result = null;
	if (ms != null)
	{
		BinaryReader binaryReader = new BinaryReader(ms);
		byte b = binaryReader.ReadByte();
		if (b == 2)
		{
			string text = binaryReader.ReadString();
			if (text == "ENCRYPT_HEADER")
			{
				result = binaryReader.ReadBytes(Convert.ToInt32(ms.get_Length() - ms.get_Position()));
			}
		}
	}
	return result;
}

Thanks

How would you get the Assembly-CSharp.dll from the unity asset bundle (.unity3d) if it is encrypted?

Assembly-CSharp.dll is not in asset bundle.
It's located on managed folder and the encrypted assets bundle is in resources folder.

You just contradicted yourself. You've already unpacked the Unity asset bundle (.unity3d) Libraries for Unity games and apps can not be outside the Unity asset bundle, it wouldn't work. You decompiled the library to get the code and you want to export the assets from the asset bundle (.assets, .asset, etc.) What you should have done is opened the asset bundle in a hex editor and showed what the header says. However, you probably won't be able to use DisUnity to do what you want to do, I suggest you use Unity Studio, the latest version, which you can see on my Starred repositories page.

There is lot of asset bundle files (.unity3d), some of them unencrypted so I can unpack it with Disunity or Unity Studio.
But, some .unity3d is encrypted, when I open it in a hex editor, I've found this:
00000000 02 0E 45 4E 43 52 59 50 54 5F 48 45 41 44 45 52 ENCRYPT_HEADER

Hi there. Are u trying to decode Ragnarok Mobile files too?
Well, I have wrote a small snippet in Python to mimic the RemoveEncryptHeader function. But this function only removes the bytes from header: the file is still encoded.
I suppose that there is another function on Assembly-CSharp.dll that take the file encoded without the header and finally decodes it. Can u look for this on the dll?
There is the snippet of the same function in python:
decode.py
import sys
import os
from struct import *

class BinaryStream:
    def __init__(self, base_stream):
        self.base_stream = base_stream

    def tell(self):
        return self.base_stream.tell()

    def readByte(self):
        return self.base_stream.read(1)

    def readBytes(self, length):
        return self.base_stream.read(length)

    def readChar(self):
        return self.unpack('b')

    def pack(self, fmt, data):
        return self.writeBytes(pack(fmt, data))

    def unpack(self, fmt, length = 1):
        return unpack(fmt, self.readBytes(length))[0]

f = open(sys.argv[1], "rb")
stream = BinaryStream(f)
b = stream.readChar()
print 'b',b
text_header_size = stream.readChar()
print 'text_header size', text_header_size
text_header_content = stream.readBytes(int(text_header_size))
print 'text_header_content', text_header_content

new_filename = sys.argv[1].split('.')[0]+"_decoded.unity3d"
print 'result file is', new_filename
result = stream.readBytes(int(os.path.getsize(sys.argv[1])-stream.tell()))
f = open(new_filename, "wb")
f.write(result)
f.close()

To run this, please use:
$python decode.py config.unity3d

And it will be generated the file config_decoded.unity3d ( but remember, the file is still encrypted)


Please add documentation about supported tags

It would be very helpful to have a list somewhere of which jsdoc tags are supported.

this is now available: https://docs.deno.com/runtime/reference/cli/documentation_generator/#supported-jsdoc-tags


Unicode support for index entries

Followup from asciidoctor issue 2423.
Unicode defines an ordering, but AsciiDoctor does not support it in the index. It merges all non-ASCII character entries in one entry labelled "@". This is some enhancement requiring better Unicode support.
Example testcase:
(((Öffentlichkeit)))
This is a message.

(((日本語)))
これは日本語の文です。

[index]
== Index

Result:

In my attempt to promote symbols, I inadvertently promoted all non-Latin letters. Ruby 2.4 has Unicode-aware sorting, so I just need to figure out how to leverage that.

PR sent!


Use the correct service name when specifying the ingress backend

When utilizing the ingress generated by the chart, the serviceName used
by the ingress differs from the name used while generating the
Service.
This PR corrects that, by using the same template function in both
locations.
What this PR does / why we need it:
It currently creates an ingress that serves a 503
@zanhsieh

/ok-to-test

/lgtm

@nrmitchi I think this broke job that imports datasources, because:
$ kubectl logs grafana-set-datasource-kjtwl -n monitoring   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                  Dload  Upload   Total   Spent    Left  Speed   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: grafana-grafana

@amnk That error looks like it's unable to resolve the service internal to the cluster, no?
This PR just had the ingress reference the name that the service was previously using; it didn't actually modify the name of the service. Are you sure it was this PR?
It does look like it's a pretty similar problem though; it's attempting to access a service named after {{ printf "%s-%s" $releaseName "grafana" | trunc 63 }}, whereas the service is using a different template.
I haven't looked into it, but I would guess that the fix would be the same replacement, just in the set-datasources job.

@amnk
The line here: https://github.com/kubernetes/charts/blob/master/stable/grafana/templates/dashboards-import-job-configmap.yaml#L21
is using a different template. If you switch it to {{ template "grafana.server.fullname" . }} I think it'll work.
You could also edit the configmap directly (outside of helm) and put the right service name in.


Add k8s version support for EKS script and fix Jenkins script issues

/skip-e2e /skip-conformance /skip-networkpolicy

/skip-all


Is it possible to extend ProxyHandler interface?

I'll try to write externs for Record from Immutable.js.
When class contains only get method it's ok, but it's ignored when object contains custom methods

It looks like ProxyHandler is defined as an @record in es6_proxy.js, so it should be possible to extend it like this.
/**
 * @extends {ProxyHandler}
 */
function MyProxyHandler() {}

/**
 * @param {number} n
 * @return {string}
 */
MyProxyHandler.prototype.myMethod = function(n) {};

What does your code look like?

@ikabirov thanks for the detailed repro.
I've created an internal bug to track fixing this.


chore: do not directly import Tactic.Cases

This entails replacing not only induction' by its unprimed variant, but also cases' by cases/rcases/obtain. This reduces the number of imports for some files.

bors d+

bors merge


Automated Package Upgrade

:tada: This PR is included in version 6.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


SNOW-861532 Remove sp check for params in session.sql

Description
The change in Snowflake and the connector was checked in to reach full parity as far as integ/test_bind_variable.sql goes. We could remove this restriction from snowpark.
Testing
regression test with test_bind_variable.sql
Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-861532

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.
The change in Snowflake and the connector was checked in to reach full parity as far as integ/test_bind_variable.sql goes. We could remove this restriction from snowpark.

Ran test against https://github.com/snowflakedb/snowflake/tree/shixuan_bind_test
Test run: https://ci-dev-133.int.snowflakecomputing.com/job/RT-Precommit/12858/
Build job: https://ci-dev-142.int.snowflakecomputing.com/job/PythonStoredProcBuildPrecommitTest/456/
Specifically, the bind variable integ test passed: https://ci-dev-133.int.snowflakecomputing.com/job/RT-PC-TestWorker/177427/testReport/(root)/t_python_sp_integ/snowpark_test_bind_variable_sql/


Improve discovery of app.jar packaging

What would you like to be added:
Users of popular java frame work spring often package thier app as /app.jar.  This JAR file usually has a shell script prepended to them, ostensibly to enable them to configure their environment at runtime.  The script headers lead us to believe that it comes from the Spring framework / build tools, and we have little reason to believe that this is an uncommon way to distribute/deploy JAR files.
Why is this needed:
Steps to reproduce
syft packages [redacted]
Expected result
spring-core should appear in the output, as it's bundled in the /app.jar in the image
Additional context:

I would add that we would expect more than just spring-core in the output. In Anchore Enterprise 2.x the entire shar and all included JAR files would be unpacked and cataloged.

Interesting! I've never heard of that, but I'm a Java-ignoramus.
@hev Do we have an example? Or somewhere in Engine/Enterprise we can point to for this behavior? (I'll also look around)

For clarity this is the error:
WARN cataloger ‘java-cataloger’ failed to parse entries (Location<id=3557 RealPath=“/app.jar” VirtualPath=“/app.jar” Layer=“sha256:f8af747a7e09cfc41068429dadb08fa4a60de206eef9bade4bd4cba826d515ae”>): unable to read files from java archive: unable to open zip archive (/var/folders/9t/4dv6njks73b3x3krqm3fxxnm0000gn/T/syft-jar-contents-896927952/archive): zip: not a valid zip file
Engine uses a regular zip file processor for jars, it looks like the zip lib used by Syft isn't able to handle this type of file.

Yeah, I think we can support this functionality.
Currently the golang stdlib archive/zip package does not support this. It looks like there's been a patch to incorporate into go ready since 2015, but there is no PR and I think there is a way forward without needing to change the stdlib.
We could infer the archive length from the end of central directory record, create a new io.ReaderAt via io.SectionReader that is bounded to only the archive based on the length from the ECOD, and create a new zip reader via zip.NewReader() (instead of zip.OpenReader). We'd need to make certain that the underlying reader passed to the SectionReader is closed after each use since there is no Close() operation available from a zip.Reader.


Ability to convert to PNG?

Hey,
so it seems that platforms like Twitter don’t support the SVG output.
would it be possible to convert the SVG output to binary or something to output as an image?

Updated the playground to return png instead
https://github.com/wobsoriano/v-satori/blob/main/playground/server/api/og.ts


Nlog with a class Library

I have a class library and configuration file in a separate place I want to use it so I do the following
LogManager.Configuration = new NLog.Config.XmlLoggingConfiguration(configurationFile , true);
LogManager.ReconfigExistingLoggers();

The configuration of NLog is part of a remote app.config looks like
<configuration>
    <!-- ... -->
    <configSections>
        <section name="nlog" type="NLog.Config.ConfigSectionHandler, NLog" />
    </configSections>
    <nlog xmlns="http://www.nlog-project.org/schemas/NLog.xsd"  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
        <targets>
            <!--
              Log in a separate thread, possibly queueing up to
              5000 messages. When the queue overflows, discard any
              extra messages
            -->
            <target name="file" xsi:type="AsyncWrapper" queueLimit="5000" overflowAction="Discard"
                layout="${machinename} - ${level} - ${longdate} - ${callsite} - ${threadid} - ${message} ${exception:format=tostring}">
                <target xsi:type="File" fileName="C:\logs/${level}.txt" />
            </target>
        </targets>
        <rules>
            <logger name="*" minlevel="Debug" writeTo="file" />
        </rules>
    </nlog>
</configuration>

the configuration object LogManager.Configuration always has the default values , any idea how to fix this.

Hi,
please check https://github.com/NLog/NLog/wiki/Logging-troubleshooting

@alimhabib Guess this issue can be resolved? Since your question has been answered here:
https://stackoverflow.com/questions/53223915/nlog-with-a-class-library

@alimhabib Guess this issue can be resolved? Since your question has been answered here:
https://stackoverflow.com/questions/53223915/nlog-with-a-class-library

yes it solved, thanks a lot all , how to close this

yes it solved, thanks a lot all , how to close this

Usually there is a "Close Issue"-button at the bottom of the issue (Next to the green "Comment")


Links should open in new tab

Contact Details
No response
What happened?
Social and repo links open in same tab.
What should have happened?
Links should open in new tab.
Please assign this to me.
What browsers are you seeing the problem on?
No response
Version
No response
Relevant log output
No response

Go for it 🚀


Use a interface method to update the transaction option

Signed-off-by: Xu Qiaolun<EMAIL_ADDRESS>

close #359
cc @disksing

Thanks @gotoxu , would you like to continue to update tidb?

@disksing OK!


Laravel Add to cart with same product into cart with +1 Quantity.

I am new to Laravel. Add to cart button to add same product into cart with +1 quantity. Trying to check if stock greater than qty. When one item is qty 1 than 2 stock I would like to display some text "successfully added to the cart"
Storing the quantity in session for each product in the cart. Total Stock have 2. if 3 quantity in session than 2 total stock, prevent add to cart. like display "the requested qty is not availabile".
public function add_to_cart(Request $request)
        {
            $name = $request->product_name;
            $price = $request->product_price;
            $itemno = $request->product_itemno;
            $qty = $request->product_quantity;
            $color = $request->product_color;
            $size = $request->product_size;

            $stock = products::join('stocks', 'stocks.pid', 'products.id')
            ->join('sizes', 'sizes.pid', 'products.id')
            ->where([['products.item_no', '=', $itemno],['sizes.size_name', '=', $size]])
            ->first();

            // Current stock quantity
            $stockqty = $stock->qty;
            if($qty <= $stockqty)
            {
             echo "
was successfully added to your shopping cart
";

             Cart::add([
                'id' => $itemno,
                'weight' => 500,
                'name' => $name,
                'price' => $price,
                'qty' => $qty,
                'color' => $color,
                'size' => $size
                ]);
            }
            else
            {
             echo "
The Requested quantity for this product is not available.
";
            }

        }

https://user-images.githubusercontent.com/66638783/103177920-353ba280-48a0-11eb-801f-8be4add2c5f2.mp4

in this video from other websites. check if more 11 quantity in session than 10 total stock, then prevent add to cart.
https://user-images.githubusercontent.com/66638783/103178042-4afd9780-48a1-11eb-86d1-a5647575bb2b.mp4
please find the attached file video


This isn't a problem on the profiles so leave it alone.


Issue while running docker on Mac

Following issue occurred while installing cti-taxii-server via docker on Mac
Step 3/5 : COPY ./docker_utils/*.json /opt/taxii
COPY failed: no source files were specified

Hi @kp625544,
Assuming you have not moved the Dockerfile from the docker_utils folder, you have to call docker build with a path specification like so: docker build . -f docker_utils/Dockerfile -t medallion.
Were you following the instructions in the readme? I noticed that we don't specify where the Dockerfile is, so I will make a PR to add some description and link to this issue.
Hope this helps.

Fixed the issue will send a merge request for the same.
On Mon, 2 Mar, 2020, 11:12 pm zrush-mitre<EMAIL_ADDRESS>wrote:

Hi @kp625544 https://github.com/kp625544,
Assuming you have not moved the Dockerfile from the docker_utils folder,
you have to call docker build with a path specification like so: docker
build . -f docker_utils/Dockerfile -t medallion.
Were you following the instructions in the readme? I noticed that we don't
specify where the Dockerfile is, so I will make a PR to add some
description and link to this issue.
Hope this helps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oasis-open/cti-taxii-server/issues/103?email_source=notifications&email_token=AEK47HFWQG3323UMJVXKEPLRFPVYRA5CNFSM4K4FFPDKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENQHYDY#issuecomment-593525775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEK47HDULQT7VVSNP3OB2V3RFPVYRANCNFSM4K4FFPDA
.

closed by #104


Update Developer Guide

Coverage remained the same at 85.094% when pulling 26c956b69ff1dfd56a096072339d01973d29e4f0 on awarenessxz:v1.5_Developer_Guide into 8e6bde791fa6c9d88eeb57c82357c4986f2ff412 on CS2103AUG2017-W14-B2:master.

Coverage remained the same at 85.094% when pulling 13cdd11105ad870b9ab751e01f8a5844a4dfcfa8 on awarenessxz:v1.5_Developer_Guide into 8e6bde791fa6c9d88eeb57c82357c4986f2ff412 on CS2103AUG2017-W14-B2:master.

Coverage increased (+0.03%) to 85.505% when pulling f5ebdd3e85933e00e9b232cc1e2db35771099aef on awarenessxz:v1.5_Developer_Guide into 3a61b061c64513d97a9f2ff2e471de0b8a240f01 on CS2103AUG2017-W14-B2:master.

Coverage increased (+0.03%) to 85.505% when pulling c3df59f10c75a3a3a1a13d1da7da2b4587e2e954 on awarenessxz:v1.5_Developer_Guide into 3a61b061c64513d97a9f2ff2e471de0b8a240f01 on CS2103AUG2017-W14-B2:master.

Coverage increased (+0.03%) to 85.505% when pulling d4e293bf4fab65237511bd8affe4c8f6836bb713 on awarenessxz:v1.5_Developer_Guide into 3a61b061c64513d97a9f2ff2e471de0b8a240f01 on CS2103AUG2017-W14-B2:master.

Coverage increased (+0.03%) to 85.505% when pulling 66f099932bc526be7962de416af485efdc2d7541 on awarenessxz:v1.5_Developer_Guide into 3a61b061c64513d97a9f2ff2e471de0b8a240f01 on CS2103AUG2017-W14-B2:master.

Coverage increased (+0.03%) to 85.505% when pulling 66f099932bc526be7962de416af485efdc2d7541 on awarenessxz:v1.5_Developer_Guide into 3a61b061c64513d97a9f2ff2e471de0b8a240f01 on CS2103AUG2017-W14-B2:master.


HADOOP-17332. S3A MarkerTool -min and -max are inverted.

This patch

fixes the inversion
adds a precondition check
if the commands are supplied inverted, swaps them with a warning.
This is to stop breaking any tests written to cope with the existing
behavior.
adds tests for all this

Tested (IMarkerTool tests): S3 london

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  8s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m  3s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
17m 57s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+0 :ok:
spotbugs
1m  6s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  3s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m  8s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 17s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
findbugs
1m  7s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 16s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 28s

The patch does not generate ASF License warnings.

83m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2425

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux e42122c2a000 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8ee6bc2518b

Default Java
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/1/testReport/

Max. process+thread count
429 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.1.3

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Anyone got any opinions here @mukund-thakur @mehakmeet @bgaborg ?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 14s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
18m 25s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+0 :ok:
spotbugs
1m  4s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  0s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
javac
0m 27s

the patch passed

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 51s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
findbugs
1m  9s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 14s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

84m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2425

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2f3c5a0e8ff2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fc961b63d14

Default Java
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/2/testReport/

Max. process+thread count
628 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 12s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 21s

trunk passed

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
19m 18s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s

trunk passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+0 :ok:
spotbugs
1m  7s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  5s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 31s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 43s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

+1 :green_heart:
findbugs
1m  6s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 13s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

85m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2425

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b795c9d5f6b9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a7b923c80c6

Default Java
Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9+11-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_272-8u272-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/3/testReport/

Max. process+thread count
567 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2425/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

merged to trunk; will backport with a retest and patch of the guava import


⚠ Bofrost.lu has degraded performance

In fa9a6ae, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1112 ms

Resolved: Bofrost.lu performance has improved in 6cb79f0 after 6 minutes.


Bug in putbaraijlist

The implementation of putbaraijlist contains a bug, which leads to always ignoring the very last item that is added:
https://github.com/MOSEK/Mosek.jl/blob/da05669736ffc4f13dc7d2a32ed2aedf76a11774/src/msk_functions.jl#L6077
The num parameter is the number of Abar entries to add, i.e., it directly corresponds to the length of the parameters. It is not an index, hence there should not be a -1.
On the other hand (this is just a side remark), the alphaptrb and alphaptre are indices into the matidx and weights parameters, so for consistency with how Mosek.jl usually treats indices, one would expect that those should start with 1, but instead they are zero indexed (more precisely, alphaptrb is the zero-indexed start, and alphaptre is one plus the zero-indexed end, which is the one-indexed end). So either this should be changed or somehow documented.
Finally, there is also a version of putbaraijlist that accepts a SparseMatrixCSC. I did not use it, just saw it right now, but I suspect this one is also broken, since the colptr vector of Julia sparse matrices is one-indexed, and it is directly passed to the native function - which is related to my previous remark.

We will take a look at it next week.
Den fre. 18. mar. 2022 kl. 16.43 skrev Benjamin Desef <
@.***>:

The implementation of putbaraijlist contains a bug, which leads to always
ignoring the very last item that is added:
https://github.com/MOSEK/Mosek.jl/blob/da05669736ffc4f13dc7d2a32ed2aedf76a11774/src/msk_functions.jl#L6077
The num parameter is the number of Abar entries to add, i.e., it directly
corresponds to the length of the parameters. It is not an index, hence
there should not be a -1.
On the other hand (this is just a side remark), the alphaptrb and
alphaptre are indices into the matidx and weights parameters, so for
consistency with how Mosek.jl usually treats indices, one would expect that
those should start with 1, but instead they are zero indexed (more
precisely, alphaptrb is the zero-indexed start, and alphaptre is one plus
the zero-indexed end, which is the one-indexed end). So either this should
be changed or somehow documented.
Finally, there is also a version of putbaraijlist that accepts a
SparseMatrixCSC. I did not use it, just saw it right now, but I suspect
this one is also broken, since the colptr vector of Julia sparse matrices
is one-indexed, and it is directly passed to the native function - which is
related to my previous remark.
—
Reply to this email directly, view it on GitHub
https://github.com/MOSEK/Mosek.jl/issues/211, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACOAE4MMWA3PVG3LBUFFVIDVASQBBANCNFSM5RCGNNYA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This is a bug. Num should be passed unchanged.


Unable to save LNodeType of class LLN0 in Templates editor

If I open an SCD file and take a template with a type of LLN0, I can open it but cannot save it because it breaks the validation constraint somehow:

Sorry, that is clearly a bug :(. But I think easy to fix. I will add a fix asap


Cryptography Kata

Hi.
I'd like to create a kata on quantum cryptography, is it alright to get that put on the roadmap? Intend to introduce the coder to a quantum key distribution scheme, show how it could be used to create a one-time pad, and have them test whether the line is being eavesdropped on when generating the key.
Thanks,
Daniel

Great, quantum key distribution sounds good to me. BB84 is the natural place to start; will see if it feels right to introduce other protocols as part of the same kata as I develop it.


Add libdef for react-i18next

Adds libdef for react-i18next. Should be fairly robust, though there are some holes (not checking the i18n object). Special attention has been given to the translate HOC, which was modeled after connect from react-redux. I am new to flow, so please let me know if there is anything I can improve.
Usage:
// @flow
import { translate } from 'react-i18next'
import type { Translator, TFunction } from 'react-i18next'

type OwnProps = { s: string }
type Props = OwnProps & { t: TFunction }

const Comp = ({ t }: Props) =>
{ t('whatever') }

const translator: Translator<OwnProps, Props> = translate('whatever')

const WrappedComp = translator(Comp)

const OtherComp = () => <Comp s={ 2 } /> // TypeError

Nice, ready as you are? Everything done here?

Ready to go!


Emily/sort button2

#59 Made drop-down sorting menu

@mlelien There is still a bug in this where upon application launch it will launch the sort options regardless of where I tap. Also, can we try moving some of the setup logic out of the view controller. Let's leave the VC just for presenting the actual view (or converting to presenting a view controller instead of a view).


Create mssql.go

Explanation:
MSSQLDatabaseCredentials() is a function that generates the rule for detecting exposure of MSSQL database credentials. The Rule struct contains fields such as Description, RuleID, Regex, and Keywords, which define the rule. The Regex field contains the regular expression used for detecting secrets. In this case, it's looking for occurrences of Password= followed by any characters except ;. The Keywords field is used for string matching on fragments as a pre-filter. validate() function is used to validate the rule against example secrets (tps). You can provide example secrets that match the rule for testing purposes. The validate() function should return the validated rule.
Description:
Explain the purpose of the PR.
Checklist:

[ ] Does your PR pass tests?
[ ] Have you written new tests for your changes?
[ ] Have you lint your code locally prior to submission?

Hello, I had created a local .yml rule to identify these types of mssql "connection" password exposure. Because originally running gitleaks on pip it was not identified. And when manually reviewing via code-review I caught this type of scenario. With that I made the regex to automate and try to contribute so that if this type of exposure comes again, gitleaks will be able to catch it and alert me.
Below is an example of the manual test.


Any way to make peek window not create an entry in :oldfiles?

Is there any way to have a file opened in the glance window not create an entry in :oldfiles?
I'd only want an :oldfiles entry if I actually open the file in a normal editor buffer.
This is an awesome plugin btw, looks super nice and works great 👏

Hey,
I'm not sure if there is an API for modifying the oldfiles list
I'll look into it


Major refactor (Make things singletons, change some names to be consistent, add simple doc comments to commands, fix formatting issues)

Commands shouldn't have to have subsystems passed to them

Somehow got rid of all my code with the first merge

This PR can fix that issue because the motors are now set directly through hardware rather than through constructor arguments

Are the doc comments enough to still communicate which subsystems a command affects?

They show up pretty cleanly in autocomplete, so I don't think it'll be an issue

Ok I think this is ready now, I just checked through all the commands and I don't think I've missed anything else
I don't think removing the subsystem arguments from command is an issue, because doc comments show up just fine on vscode's autocomplete/hover, allowing you to still easily see what subsystems a command uses. Also, isn't this what documentation is for..?
Also, it's just annoying to have to pass in multiple subsystems when running some commands (it's just extra boilerplate).
As for reviewing PRs, just install the GitHub extension in vscode, then go to the github tab on the sidebar and click one of the PRs to open it in vscode.

I think (correct me if I'm wrong) there are three major changes:

Singletons
Changed Controls, Hardware, Robot (changed implementation), Subsystems, and the subsystems to singletons
Added doc comments to commands about which subsystems they used

Formatting
Fixed enum formatting, change line length to 110, insert newlines at ends of files, and join lines

Names
Renamed climbMotorFixed to climbFixedMotor, climbMotorDynamic to climbDynamicMotor, ingestIndexMotor to ingestMotor, feederIndexMotor to indexFeederMotor

Yeah I just kind of threw things in here

I can probably use git cherrypick to split everything apart without rewriting


Cherrypick Merge pull request #13797 from [BEAM-11679] Override PubsubUnboundedS…

…ource transform for dataflow runner v2
[BEAM-11679] Override PubsubUnboundedSource transform for dataflow ru…
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @chamikaramj

R: @chamikaramj

Run Java PreCommit

Run Java PreCommit

I think the PR is incorrect. It says "into apache:master" but should be "into apache:release-2.28.0"

I think the PR is incorrect. It says "into apache:master" but should be "into apache:release-2.28.0"

Run Java PreCommit

Run Java PreCommit

Python failure is unrelated (Dataflow worker images are not available yet).

Python failure is unrelated (Dataflow worker images are not available yet).

Run Java PreCommit

Run Java PreCommit


[Q] error running test command

Hi again, I am getting this error when im running the rist input/output test on the server. Been scratching my head for a while wondering how to resolve this? Any pointers would be appreciated!
root@ubuntu:~# tsp -I rist url rist://(server-ip-address):8194

Error: rist: Failure resolving host url: Temporary failure in name resolution
Error: rist: Host url cannot be resolved
Error: rist: Send failed: errno=88, reason=Socket operation on non-socket, ret=-1, socket=0
Error: rist: Send failed: errno=88, reason=Socket operation on non-socket, ret=-1, socket=0
Error: rist: Send failed: errno=88, reason=Socket operation on non-socket, ret=-1, socket=0
Error: rist: Send failed: errno=88, reason=Socket operation on non-socket, ret=-1, socket=0
Error: rist: Send failed: errno=88, reason=Socket operation on non-socket, ret=-1, socket=0
Error: rist: Send failed: errno=88, reason=Socket operation on non-socket, ret=-1, socket=0
Error: rist: rist_send_common_rtcp failed
Error: rist: rist_send_common_rtcp failed
Error: rist: rist_send_common_rtcp failed
Error: rist: rist_send_common_rtcp failed
Error: rist: rist_send_common_rtcp failed

Follow up: for the output I keep having to terminate the command because I keep getting this
root@ubuntu:~# tsp -O rist url rist://(server-ipa-address):8194
(literally nothing happens when i enter the command)
^C* tsp: user interrupt, terminating...
^C

@geoffroutledge, yes you got it. I didn't notice the extra url in  -I rist url rist://(server-ip-address):8194
The RIST URL is defined at https://code.videolan.org/rist/librist/-/wikis/risturl-Syntax-as-of-v.-0.2.0

I will give this a try once I get my environment up and running again thank you!


fixes for #412:shipyard-cli events would exit with error

hopefully it fixes the issue reported.

LGTM


Downscale step seems quite expensive at higher resolutions

Cfl_Mix:

KrigBillateral (those %s don't seem accurate lol):

Cfl_Mix without downscaling:

Even without downscaling it seems pretty good, especially for the cost but there is still some oddness going on. Any chance of a version with faster downscaling or a fast variant with no DS but better tuned values?

That looks a bit weird. I don't have access to my desktop right now, but the shader is generally very lightweight even on my laptop with an Intel igpu from years ago.
What's the resolution of this video? Also, are you prescaling luma before calling the CfL shader?

I can reproduce this with RAVU, I guess it's the combination of having a larger resolution plus the scaling factor difference to match chroma (0.25x rather than 0.5x).
I'll see what I can do about this, thanks =)

What's the resolution of this video? Also, are you prescaling luma before calling the CfL shader?

I'm trying out the 4x fast photo scaler from https://github.com/Alexkral/AviSynthAiUpscale in an attempt to remove aliasing so I believe it's scaling to 8k with my native res being 1440p.
When I removed the downscaling I was just binding and using LUMA, looking at closed issue there appears to be a version without downscaling before but NATIVE was used instead? The 12tap variant had less issues than mixed like that but I don't think it beat catmull_rom in when testing ~20 sources subjectively. Actually now that I've tested chroma scaling a lot more it appears catmull_rom is not just better than lanczos/ewa_lanczos(sharp) but krigbillateral too, at least when playing back from a high resolution (in my case upscaled). Is it possible you could run catmull_rom through your tests?

The version you linked didn't have the downscaling step yet, and it didn't have its own spatial scaler either so it should just use whatever you're setting cscale to (maybe you had it set to catmull_rom?).
Anyway, I'm trying to simplify the downsampling code a little bit and I think I could make it roughly twice as fast without any noticeable quality loss:
//!HOOK CHROMA
//!BIND LUMA
//!BIND HOOKED
//!SAVE LUMA_LOWRES
//!WIDTH CHROMA.w
//!HEIGHT CHROMA.h
//!WHEN CHROMA.w LUMA.w <
//!DESC Chroma From Luma Prediction (Downscaling Luma)

vec4 hook() {
    vec2 factor = ceil(LUMA_size / CHROMA_size);
    vec2 centre = factor / 2.0;
    vec2 offset = 1.0 / factor;

    float output_luma = 0.0;
    float wt = 0.0;
    for (float dx = 0.0; dx <= factor.x; dx++) {
        for (float dy = 0.0; dy <= factor.y; dy++) {
            float luma_pix = LUMA_texOff(vec2(dx, dy) - vec2(centre)).x;
            float wd = exp(-2.0 * pow(length(vec2(dx, dy) - vec2(centre) + offset), 2.0));
            output_luma += luma_pix * wd;
            wt += wd;
        }
    }
    vec4 output_pix = vec4(output_luma / wt, 0.0, 0.0, 1.0);
    return output_pix;
}

It's still obviously going to be much slower than not downsampling at all, but I guess I could write an orthogonal version of this and do it like Krig is doing (and in that case I suppose it would perform similarly). Could you help me test this in any case?

Anyway, I'm trying to simplify the downsampling code a little bit and I think I could make it roughly twice as fast without any noticeable quality loss:

testing with 4x luma upscale (not comparable to previous results)
12_Master:

12_Test:

12_9ad91ab:

Hmm actually just tested it with Mix and it causes some rather large artifacts:

vs master:

Does this fix the problem?
//!HOOK CHROMA
//!BIND CHROMA
//!BIND LUMA
//!SAVE LUMA_LOWRES
//!WIDTH CHROMA.w
//!HEIGHT CHROMA.h
//!WHEN CHROMA.w LUMA.w <
//!DESC Chroma From Luma Prediction (Downscaling Luma)

vec4 hook() {
    vec2 factor = ceil(LUMA_size / CHROMA_size);
    vec2 centre = factor / 2.0;
    vec2 offset = 1.0 / factor;

    float output_luma = 0.0;
    float wt = 0.0;
    for (float dx = 0.0; dx < factor.x; dx++) {
        for (float dy = 0.0; dy < factor.y; dy++) {
            float luma_pix = LUMA_texOff(vec2(dx, dy) - vec2(centre)).x;
            float wd = exp(-factor * pow(length(vec2(dx, dy) - vec2(centre) + offset), 2.0));
            output_luma += luma_pix * wd;
            wt += wd;
        }
    }
    vec4 output_pix = vec4(output_luma / wt, 0.0, 0.0, 1.0);
    return output_pix;
}

Not quite but it is a little less noticeable:

vs previous:

It's also slightly faster ~37000ns vs ~39k (frame isn't same as previous results).

Hmm, that's weird. I can't seem to reproduce this here so I suppose the conditions for it to happen aren't being completely met. The red outline in the logo makes me believe the 4-tap regression is the one at fault here, but if it doesn't happen with "master" then that's a bit peculiar.

It gets even less noticeable at 3x scaling so it's probably not anything to worry about:

No, I actually know what the problem is... I'm doing a half-pixel shift by mistake in the new code 🥲.

I think that actually made it worse :/

It seems to be breaking in more places now 🤔

Are you 100% sure the problem isn't elsewhere? I'm testing the downsamplers as standalone shaders and they produce almost identical results for 0.5x and 0.25x scaling factors.

Are you 100% sure the problem isn't elsewhere? I'm testing the downsamplers as standalone shaders and they produce almost identical results for 0.5x and 0.25x scaling factors.

It may be a combination of shaders causing it, I haven't tested that but in motion it is actually rather noticeable even at 2x. Master didn't have that problem and neither did the 12tap version of the previous downscaling code you sent me (didn't test 12tap with it since I didn't see the issue there).

Nevermind, I'm not looking at this properly and ended up creating another issue. It's fine at 0.5x but not at 0.25x.

Would it be possible to have version that doesn't downscale but does a catmull pass first?

Downscaling luma is honestly pretty optional and it's only really done to increase the correlation between the two, what's really important is that it also serves as a denoising/smoothing step which ends up helping the regression afterwards. You can use it without the downscaling step just fine, it just won't be as good.
You can just replace LUMA_LOWRES with LUMA after removing the first pass.

You can just replace LUMA_LOWRES with LUMA after removing the first pass.

That's what I originally did but the results weren't as good as 9ad91ab which didn't include a downscaling pass. While it was cheap cost-wise and looked better than catmull-rom in static shots, in motion catmull seemed quite a bit better.

You can double check with this just to confirm the edited shader wasn't in a broken state: https://pastebin.com/uQ4tHgw5

You can double check with this just to confirm the edited shader wasn't in a broken state: https://pastebin.com/uQ4tHgw5

Looks like I did the exact same thing from the start

Ah, it seems without any upscalers (and no other shaders running) it does look better than the old version, not sure why but it just doesn't seem to combine well with upscalers.

Which one? What is the "new version" here?

Which one? What is the "new version" here?

I was referring to master without downscaling (basically https://pastebin.com/uQ4tHgw5) vs https://github.com/Artoriuz/glsl-chroma-from-luma-prediction/commit/9ad91ab1bc94dfe52a763755b15a02a7ecca4264

I think it's because its built-in spatial filter is very sharp, it probably looks bad at 4x. I didn't really test anything at 4x so it's 100% plausible that I made it worse while pursuing improvements at 2x.

Have you tried doing a 2nd pass? I seem to be getting comparable or often less artifacts when running a 2nd pass:
original (notice the reds have a dark outline):

fsrcnnx8+cfl_12_noDS+cfl_12_noDS_AR:

vs fsrcnnx8+cfl_12 (master):

vs fsrcnnx8+catmull:

vs fsrcnnx8+krigbillateral:

Just to summarise what I was trying to do here:
The downscaler that's currently in master uses a scaling factor * 2 window size, which gets way too fucking big at 4x (weighted average of 64 pixels). I tried reducing it to scaling factor * 1 (while also rewriting it to an easier to understand/maintain, relative-position version of it), but that reduces its quality a little bit and I'm not sure if it's worth it since performance at 2x (normal scenario) seems fine with the bigger window (16 pixels rather than 4).
Admittedly, the correct thing to do here would be doing orthogonal downscaling since it is much faster, but I'm also getting slightly worse results with orthogonal downscaling... I'm leaving this open still because I still have some hope I'll find a way to make it faster without sacrificing quality too much.
As for https://pastebin.com/raw/p6YQsrcT, you can safely use it with any cscale, as the cscale acts as a fallback of sorts when the regression is known to be bad. I was running it with lanczos but I don't see why it wouldn't work with catrom. The change of hooking chroma instead of native and doing the spatial resampling myself was done mainly for performance reasons as that avoids having to load these pixels twice in different passes. I don't have access to my desktop right now, so I can't benchmark this on a real GPU, but it does make a decent difference on my laptop (Whiskey Lake iGPU, very very weak).
I could perhaps make a different variant aimed at 4x entirely for people who want to use it alongside luma doublers, but I guess that would be a different request.

The change of hooking chroma instead of native and doing the spatial resampling myself was done mainly for performance reasons as that avoids having to load these pixels twice in different passes.
Umm... The variant I linked when testing with no luma doubler is 1020μs avg frametime vs 985.... with fsrcnnx8 it's faster with 3450 vs 4420...
Though that is with catmull_rom which is like 2x faster than lanczos and also looks better than lanczos.
I actually made a really weird discovery, combining Krigbillateral's downscaling part (bit too soft on it's own) with the one you're using with catmull_rom chroma scaling gives very good results and fast with just 3070 with fsrcnnx8.

It should be much faster now with orthogonal downsampling, but I'm interested in seeing whether you can reproduce your artifacts when you use it alongside your other shaders.

Yeah it's a lot faster than master now:

vs Master:

It pretty much makes the issue with artifacts that look like object z-fighting almost unnoticeable (it appear for like 1 or 2 frames) so if you aren't looking for it you probably won't notice it. However it does nothing to improve the reds on dark surfaces (actually doesn't seem to occur in the older versions without the downscaling).
The mashup of old version is still a lot faster:

and this is with my current shader set:

Alright, thanks!
One problem solved then. I think quality in general took a small hit but it shouldn't be noticeable.

One problem solved then. I think quality in general took a small hit but it shouldn't be noticeable.
Can't decide if it's better or worse, it does some stuff better but appears to be maybe a tad too sharp and is thinning edges a bit.

Looks pretty good with the older code and scaling from native with kaiser instead which is also quite a bit faster vs the newest version in master (3300 vs 3650 at 2x):

vs cc15498:

Don't worry, I'll probably keep refining it as time passes. I closed the issue because the performance issue is gone.

Also, the artifacts in the white characters are interesting. I think the black outline is screwing up the linear regression but maybe there's something I can do about this.

Edit: Downloaded the source and I'm 99% confident this is an issue in the source itself
It doesn't happen with my current shaders which has changed again to using Krig's downscaling only and your latest downscaling code (set to hook Native instead of Chroma) and using hamming for cscale.

This is what it looks like with my current shaders:


Use HTTP buffering if available

Noticed that 0.9.x has some of this thanks to #1330. Porting it over to master.
refs #1690

Current coverage is 65.50% (diff: 0.00%)

Merging #1722 into master will decrease coverage by 0.12%

@@             master      #1722   diff @@
==========================================
  Files            54         54
  Lines          6125       6137    +12
  Methods           0          0
  Messages          0          0
  Branches       1210       1210
==========================================
  Hits           4020       4020
- Misses         1892       1904    +12
  Partials        213        213

Powered by Codecov. Last update e76a8d6...0f8bd9a


Alembic Windows compilation Python3.9.10 called with non-existent target "Imath::PyImath_Python3_9".

Compilation issue on windows
get_target_property() called with non-existent target
TLDR:

CMake Error at python/PyAlembic/Tests/CMakeLists.txt:49 (GET_TARGET_PROPERTY):
get_target_property() called with non-existent target
"Imath::PyImath_Python3_9".

How to reproduce
Requierements:

python 3.9.10
Boost source code (tested with 1.85.0 and 1.81.0, same behavior)
Imath Source code (3.1.11)
Alembic source code (1.8.5)
CMake
MSVC 14.39.33519

Compile boost with python binding
You can use b2 or cmake, i have tested with both, but in this example i will detail with cmake, more simple to explain.
So in <Boost_SOURCE_ROOT>/:
cmake -S . -B ./build -DBOOST_ENABLE_PYTHON=ON -DPython_ROOT_DIR=C:/python39 -DCMAKE_INSTALL_PREFIX=E:/compile_alembic/boost-1.85.0/install_prefix

cmake --build .\build\ --config Release --target install

Compile IMath
In <IMath_SOURCE_ROOT>/
cmake -S . -B ./build -DPYTHON=ON -DCMAKE_INSTALL_PREFIX=E:/compile_alembic/Imath-3.1.11/install -DCMAKE_BUILD_TYPE=Release -DBoost_ROOT=E:/compile_alembic/boost-1.85.0/install_prefix -DPython_EXECUTABLE=C:/Python39/python.exe -DPython3_EXECUTABLE=C:/Python39/python.exe -DBoost_NO_BOOST_CMAKE=OFF

cmake --build .\build\ --config Release --target install

Compile Alembic
cmake -S . -B ./build/ -DImath_ROOT=E:/compile_alembic/Imath-3.1.11/install -DUSE_PYALEMBIC=ON -DCMAKE_INSTALL_PREFIX=E:/compile_alembic/alembic-1.8.5/install -DBoost_INCLUDE_DIR=E:/compile_alembic/boost-1.85.0/install_prefix/includes/boost-1.85.0  -DCMAKE_BUILD_TYPE=Release

And now you should see this error:
CMake Error at python/PyAlembic/Tests/CMakeLists.txt:49 (GET_TARGET_PROPERTY):
  get_target_property() called with non-existent target
  "Imath::PyImath_Python3_9".

Things tried

Recompile boost using b2 then recompile imath
Recompile boost v1.81.0 using b2 then recompile imath
Recompile boost v1.81.0 using b2 and theses arguments release link=shared --python=3.9 --build-type=complete --prefix=.\prefix_install --threading=multi then recompile imath
Edit the .cmake file in <PREFIX_IMATH>/lib/cmake/Imath/ImathTargets-release.cmake To check if you have the Imath::PyImath_Python3_9 target, but we don't. , so i have tried to create-it manually, like this

set_property(TARGET Imath::PyImath_Python3_9 APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(Imath::PyImath_Python3_9 PROPERTIES
  IMPORTED_IMPLIB_RELEASE "${_IMPORT_PREFIX}/lib/PyImath_Python3_9-3_1.lib"
  IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/bin/PyImath_Python3_9-3_1.dll"
  )

Then i also add this in ImathTargets.cmake
...
add_library(Imath::PyImath_Python3_9 INTERFACE IMPORTED)
set_target_properties(Imath::PyImath_Python3_9 PROPERTIES
  INTERFACE_COMPILE_DEFINITIONS "IMATH_DLL"
  INTERFACE_COMPILE_FEATURES "cxx_std_11"
  INTERFACE_COMPILE_OPTIONS "/EHsc"
  INTERFACE_INCLUDE_DIRECTORIES "E:/compile_alembic/boost-1.85.0/install_prefix/includes/boost-1.85.0"
  INTERFACE_LINK_LIBRARIES "Imath::ImathConfig"
)
...

Everything i tried above, didn't work and when i try to compile without python binding it's works...
I don't know if it's normal or not, but i have searched for this Imath::PyImath_Python3_9 target, and i don't find it in any of targets .cmake file under <PREFIX_IMATH>/lib/cmake/Imath/, that's why i'm posting this issue here instead of on alembic google group.
Maybe i made something wrong, i'm a beginner with all this compilation pipeline stuff, using Imath and alembic, don't hesistate to share with me some feedbacks or idea.
Thank you

We noticed this problem on Linux as well.
We suspect its related to this:
https://github.com/AcademySoftwareFoundation/Imath/issues/360
Making it optional ended up totally removing Imath::PyImath_Python3_9 from ImathTargets-release.cmake.

@lamiller0 Do you think the problem is that the PyAlembic links against PyImath and therefore the EXPORT is in fact required when you are linking against PyImath? And in fact the fix does not make the python bindings optional but merely makes the linking of the python bindings impossible?
I do notice that alembic is not listed in the list of tested packages on Debian on the original report.
I wonder if the original bug report
CMake Error at /usr/lib/x86_64-linux-gnu/cmake/Imath/ImathTargets.cmake:115 (message):
  The imported target "Imath::PyImath_Python3_11" references the file

     "/usr/lib/x86_64-linux-gnu/libPyImath_Python3_11-3_1.so.29.8.0"
     but this file does not exist.

Indicates a more direct problem, like /usr/lib/x86_64-linux-gnu/libPyImath_Python3_11-3_1.so.29.8.0 actually does not exist, as the error says; perhaps it is not named correctly in ImathTargets.cmake, or perhaps it wasn't copied to the target destination.
I notice that the original bug report does not post the contents of ImathTargets.cmake, so I think we are fishing in the dark here. I assume that if you restore the line, then PyAlembic links again?

I assume that if you restore the line, then PyAlembic links again?

I ran out of time to be able to confirm this, but hope to early next week.   I suspect the solution will be to EXPORT it  if building PyImath.

Thank you all for your answers.
So I retried to compile alembic using an old version of imath, the built of alembic was a success using v3.1.8 version of Imath !

I think the idea of the original PR was that you didn't want that export to occur if you were turning off the python bindings. But instead of making it conditional on that, it just removed the export entirely, which breaks other projects that want the exported config to contain the target for the python module.
But admittedly, I'm a little hazy on the whole thing, so I may be misunderstanding.

I guess maybe it's more subtle than that? If I understand the original PR correctly, they were ok building the python bindings, but didn't want to install them, and in that case, having the exported target caused problems downstream. But now removing the exported target entirely causes problems for other downstream projects that need it (such as Alembic). So I stand by my assertion that the right fix should have been to selectively export the target so that somehow it still is present when you do want to both build and install the python bindings. (I'm still a little unclear on what the use case is for wanting to build, but not install, the python bindings.)

You're exactly right, Larry
The motivation to build the python bindings but not install them is this: Whether or not you EXPORT them, they are made available to Python by virtue of being in site-packages or whatever. The usual Python thing. EXPORT makes the library available for linking in a C++ linking area AND ALSO tells anything linking via the c/c++ toolchain that it needs to link to that library.
If you are linking against Imath, that's independent of linking against PyImath. So why do all those projects in debian think they need to link against pyimath in the first place? I think that's the root cause bad news right there, and eliding EXPORT is a red herring. Does our cmake put a dependency on pyimath on everything that links imath? That would be a root cause but I don't see where that would be happening.
The EXPORT  is in the MODULE_DEFINE for PyImath, not the library define for Imath. Do how does the python module impinge on the C++ build IN ANY WAY unless the export line itself is bad. That could be it.
EXPORT ${PROJECT_NAME}
PROJECT_NAME is likely Imath and this corrupts things, and probably we should exporting PYMODULE_NAME or whatever mystery sauce cmake has for the purpose.

I just did a few experiments with bringng back the EXPORT line back and diffing what changed when building WITH python:
In ImathTargets.cmake:
foreach(_cmake_expected_target IN ITEMS Imath::ImathConfig Imath::Imath Imath::PyImathConfig Imath::PyImath_Python3_9)
The Imath::PyImath_Python3_9 is added.
Also this block is added:
# Create imported target Imath::PyImath_Python3_9
add_library(Imath::PyImath_Python3_9 SHARED IMPORTED)

set_target_properties(Imath::PyImath_Python3_9 PROPERTIES
  INTERFACE_COMPILE_FEATURES "cxx_std_14"
  INTERFACE_INCLUDE_DIRECTORIES "/spfs/include"
  INTERFACE_LINK_LIBRARIES "Imath::Imath"
)

In ImathTargets-release.cmake  this block is added:
# Import target "Imath::PyImath_Python3_9" for configuration "Release"
set_property(TARGET Imath::PyImath_Python3_9 APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
set_target_properties(Imath::PyImath_Python3_9 PROPERTIES
  IMPORTED_LINK_DEPENDENT_LIBRARIES_RELEASE "Python3::Python"
  IMPORTED_LOCATION_RELEASE "${_IMPORT_PREFIX}/lib64/libPyImath_Python3_9-3_1.so.29.10.0"
  IMPORTED_SONAME_RELEASE "libPyImath_Python3_9-3_1.so.29"
  )

list(APPEND _cmake_import_check_targets Imath::PyImath_Python3_9 )
list(APPEND _cmake_import_check_files_for_Imath::PyImath_Python3_9 "${_IMPORT_PREFIX}/lib64/libPyImath_Python3_9-3_1.so.29.10.0" )

Thanks for that. None of that introduces an erroneous new dependency to non-python oriented targets.