IPv6/gateway monitoring fixes - attempt to fix #11570 and #12947

[x] Redmine Issue: https://redmine.pfsense.org/issues/11570
[x] 2nd Redmine Issue: https://redmine.pfsense.org/issues/12947
[x] Ready for review

Step-by-step instructions for anyone who wants to test

N.B. You can open https://github.com/pfsense/pfsense/compare/master...luckman212:ipv6-and-dpinger-fixes-from-4591-4595?diff=split to see a side-by-side diff of the complete changes that will be made.

install System Patches package
add new patch

description: ipv6/dpinger fixes from PR #4595
commit ID:   99d5e29d3aa762a66bf30adea8c841f1b6050fdc

leave all others at default, hit Save
Click Fetch
Click Apply
ssh or console to your pfSense
choose option 8
paste this command: chmod u+x /etc/rc.checkv6addrchange
run php -a
paste:

include("config.inc");
install_cron_job('/usr/bin/nice -n20 /etc/rc.checkv6addrchange', true, "*/1", '*', '*', '*', '*', 'root', true);

press CTRL+D or type exit to quit
for good measure, I suggest rebooting.

Prerequisite ⚠
This PR uses some functions that were added in #4591, so that patch would need to be applied first. See above note for full step by step guide for anyone who wants to test this on a "clean" system.
Update 6/19/22 👈
This new squashed commit is now somewhat more ambitous and attempts to also fix redmine 12947.
to add the required cronjob programmatically, see steps 9-10 above.
I tested with both DHCP6 and SLAAC and and this recovers successfully in both cases on my test system (6100 running 22.05.r.20220617.0613).
More testers wanted!
Previous PR note below...
This attempts to fix an issue with IPv6 gateway monitoring, where the old find_interface_ipv6() function is inadequate because it simply returns the first v6 ip on the interface, which could be an LL/ULA address that breaks monitoring.
Before this patch, each night my DHCPv6 WAN would go offline when the carrier issued a new IP or connectivity was momentarily lost. When I checked with pgrep -lf dpinger, I saw that it was restarted bound to a bogon IP and was unable to ping out anymore... so the gateway was marked down—even though I had a perfectly valid & working public IPv6.
The main change here is the addition of a get_usable_interface_ipv6() function, which, instead of returning the first IPv6 on an interface, instead iterates through all of them and returns either an array of all non-bogon IPs/prefixes, or if the $firstonly = true parameter is passed, just the first one. In that mode it's more or less a drop-in replacement for find_interface_ipv6().

Not sure if this may also be related to any of the following redmines:

https://redmine.pfsense.org/issues/8192
https://redmine.pfsense.org/issues/8136
https://redmine.pfsense.org/issues/13238

Pushed more updates to this...

added $fallback param to get_usable_interface_ipv6() whereby it will return a LL address iff $fallback==true and no other non-bogon IPv6's are present. This makes it even more of a drop-in replacement for find_interface_ipv6()
changes to rc.newwanipv6 to fix another edge case that I was hitting where a detached ifaddr was lingering around and being returned by the function (resulted in a dead gateway) -- may be related to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263986
add get_detached_ipv6_addresses() func
add remove_detached_ipv6_address() func
add remove_all_detached_ipv6_addresses() func
fix IPv6 display on dashboard Interfaces widget and Status->Interfaces

Updated, see redmine #12947.
N.B. it's not possible to apply cleanly via System Patches, I believe because of the differences in the files between CE and pfSense+. So you'd have to download the branch and merge the changes manually (I use Beyond Compare but other visual diff tools would work).
To clone this branch:
git clone --branch add-get_usable_interface_ipv6-func https://github.com/luckman212/pfsense

I have updated the top post with instructions for anyone who needs help testing this patch. I made a new branch that unifies the changes from 4591 + 4595 into a single commit to make verifying and patching easier.

Since @linnemannr has just deprecated pfSense_getall_interface_addresses() with commit b41340d this should probably be updated to use the new pfSense_get_ifaddrs()function where possible.

Since @linnemannr has just deprecated pfSense_getall_interface_addresses() with commit b41340d this should probably be updated to use the new pfSense_get_ifaddrs()function where possible.

It's preferable, especially if you need the interface attributes anyway, but I won't be removing pfSense_getall_interface_addresses() because plugins might be using it. At most I would wrap it around pfSense_get_ifaddrs() to avoid duplication of code. The key thing to take away from [commit b41340d] is get_interface_addresses() is preferred over pfSense_get_interface_addresses() as it omits VIPs when selecting the v4 and v6 address for the interface.

Updated, see redmine #12947.
N.B. it's not possible to apply the original commit cleanly via System Patches, I believe because of the differences in the files between CE and pfSense+. So for testing please follow the steps in the top post which uses a unified commit that can be applied normally with System Patches.

Hi Luckman212,
I tried to apply the commit via the patches but it's not working. I cannot apply to move on. I tried to follow the instructions at the top post to no avail. (I installed the prereq)

@brswattt It's been awhile and I am currently away from my keyboard, but I believe that the instructions at the very top of this PR (the squashed commit) have everything you need in one patch, no need to apply the "prerequisite". Try reverting/removing that prereq and then re-applying just the 99d5e29 patch. Don't forget to add the cronjob!
LMK

Turns out I didn't even have that old prereq installed. Doesn't even let me apply it anyways.  I tried to patch https://github.com/pfsense/pfsense/commit/99d5e29d3aa762a66bf30adea8c841f1b6050fdc and it is the same deal, no apply.

Okay, it's possible I need to make a different patch for pfSense CE, I will try to do that and test it. Now that we're getting close to 23.01 I was planning on rebasing and re-working this PR anyway so it aligns with some of the newer changes.

Okay, it's possible I need to make a different patch for pfSense CE, I will try to do that and test it. Now that we're getting close to 23.01 I was planning on rebasing and re-working this PR anyway so it aligns with some of the newer changes.

@luckman212 Gotcha. Can I use the https://github.com/pfsense/pfsense/commit/30ddd78822a10f2f62d593b2519f4235a7bda096 commit in the meantime or does that one not work properly? That one applied for me.

@brswattt TBH I think I force-pushed 30ddd78 by mistake, I just checked a few systems (including my own) where I've been running this for months, and all of them are using 99d5e29. So I'm going to pave a test system here and load 2.6.0 on it as well as a virgin 22.05 and see if it applies cleanly, or where the problem is. Will post an update on that ASAP.

@brswattt TBH I think I force-pushed 30ddd78 by mistake, I just checked a few systems (including my own) where I've been running this for months, and all of them are using 99d5e29. So I'm going to pave a test system here and load 2.6.0 on it as well as a virgin 22.05 and see if it applies cleanly, or where the problem is. Will post an update on that ASAP.

Hey man, any update on this?

FYI the full diff as of now applies successfully to 23.01.

@luckman212 Any update on this?

I too am having issues with the gateway monitoring on multi Wan Fail-over, and I am unable to apply the patch 99d5e29d3aa762a66bf30adea8c841f1b6050fdc on community edition. Version 2.6.0 CE. Patch 30ddd78822a10f2f62d593b2519f4235a7bda096 was able to apply but it didn't work.  Sorry about that. Now that 2.7/23.01 is imminent, I'm going to rebase and see if these patches are still necessary and rework them to merge smoothly. So, expect fixes out in the next week or so.

@luckman212 No problem man. I understand, fully. Thanks for the updates.

Good evening fellows, just checking up on this system patch, It does appear that this will not function with the version of php used on 23.01.  Thanks for writing this, I appreciate your time and I am happy to wait until you are ready to release.  Have a great week.

Hi are the v2 changes available as a patch for 2.7.0?

Thank you @luckman212 for the contributions. I'm closing this PR now that there have been multiple fixes to the reported issue. At this point, a new PR is warranted if any issues remain. See https://redmine.pfsense.org/issues/11570#note-54

@marcos-ng Understood. I've beeb working through some issues with 23.09 over the past week and getting ready to dust off some of these old PRs. I will submit fresh PRs as soon as possible.


FAQ's collapsing and better contrast Colour

Description
When we clicked FAQ's the tab the are opening are collapsing in the ends and the better Ui can be provided to it.
Screenshots

pls assign me this


Warning: Facter: Unable to getenv for pid 1, 'uninitialized constant Facter::Util::Linux'

Describe the Bug
puppet facts gives warning before json output:
server01 ~ $ puppet facts
Warning: Facter: Unable to getenv for pid 1, 'uninitialized constant Facter::Util::Linux'
{
  "agent_specified_environment": "production",
  "augeas": {
    "version": "1.14.0"
  },
}

Expected Behavior
No warning should be given when running puppet agent -t or puppet facts
Steps to Reproduce
Steps to reproduce the behavior:

Run puppet agent -t  or puppet facts on client where the agent is installed.

Environment

Version puppet7-7.32.1
Platform FreeBSD

Thanks for the info @Q1tum This is an issue in facter https://github.com/puppetlabs/facter/issues/2742 so I'm going to close this as a duplicate. There's a related facter PR you might want to try out https://github.com/puppetlabs/facter/pull/2744


Open Project file filter to prefer SCD files

The OpenSCD file open dialog has no filter for the file type. Can we set it to filter for SCD and SSD?

I guess it should for now include: scd, iid, sed, ssd, cid. WDYT @JakobVogelsang? I expect I can do a PR.

Sure yes we can do that :)


Update to webview-x(webview)?

I'm currently using this library, but is it outdated? because it doesn't support MSEdge that some javascript's features aren't working I think it uses IE11

It's an interesting idea. I know there's a newer version of WebView available, but I haven't looked into it yet.
I'd be happy to accept a PR to upgrade to webview-x if it isn't that complex.
You're right, this library is a bit outdated now.


Language in URL is lost on redirect

As per @aradianoff's comment on #9, the language is lost from any redirect that happens - particularly on submission when the user is brought to a success or failure page.

I assume merging the PR fixed this issue.


Mac: Out of sync state

There is a condition where the attributes get out of sync with the contents, it looks like a cache.
#!/bin/bash

for r in `yes | head -300`; do
for y in 41 42 43 44 45 46 47; do
    printf "\e[${y}m"
    for x in 31 32 33 34 35 36 37; do
	printf "\e[${x}mA"
    done
done
printf "\e[0m"
done

Save the output to a file and run it, rather than clearing the attributes, this keeps the last set of attributes.   Clearing the screen with C-l and then showing the last 900 bytes out of the above file (dd if=f skip=1 bs=90000) show that the attributes being rendered are wrong. (they should have a background, but do not).
Also, another artifact, after "cat" the output of the first file, some of the positions of the background cells are out of sync with the text.

Archive 2.zip

I believe this is fixed in the recent killing of the bad cache, but will confirm


help

ADD ISSUE DESCRIPTION HERE
Version: 1.79.2
Commit: 695af097c7bd098fbf017ce3ac85e09bbc5dda06
User Agent: Mozilla/5.0 (Linux; Android 7.0; Redmi Note 4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Mobile Safari/537.36
Embedder: codespaces

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Websocket with load balancing (ie lb://myservice)

Does load balancing assumes that the protocol is always http requests? I'm trying to use the load balancer with a websocket connection. My application.yml is the following:
spring:
  application:
    name: gateway-service
  cloud:
    gateway:
      # Set default filters to none
      default-filters:
      routes:
      # =====================================
      - id: chat_socket
        uri: lb://SERVICE-CHAT
        predicates:
        - Path=/socket.io
      # =====================================
      #- id: chat_socket_ws
      #  uri: ws://localhost:3000/socket.io/
      #  predicates:
      #  - Path=/socket.io

The second route chat_socket_ws works well, but the first does not work. Looking to the logs I see that it resolved the request to http:// instead of ws://:
2017-11-15 00:10:56.603 TRACE 9196 --- [ctor-http-nio-2] o.s.c.g.h.p.RoutePredicateFactory        : Pattern "/articles" does not match against value "[path='/socket.io/']"
2017-11-15 00:10:56.603 TRACE 9196 --- [ctor-http-nio-2] o.s.c.g.h.p.RoutePredicateFactory        : Pattern "/socket.io" matches against value "[path='/socket.io/']"
2017-11-15 00:10:56.603 DEBUG 9196 --- [ctor-http-nio-2] o.s.c.g.h.RoutePredicateHandlerMapping   : RouteDefinition matched: chat_socket
2017-11-15 00:10:56.603 DEBUG 9196 --- [ctor-http-nio-2] o.s.c.g.h.RoutePredicateHandlerMapping   : Mapping [Exchange: GET http://localhost/socket.io/?EIO=3&transport=websocket&sid=FSD-70PMIBf9JQBoAAAn] to Route{id='chat_socket', uri=lb://SERVICE-CHAT:3000/socket.io/, order=0, predicate=org.springframework.cloud.gateway.handler.predicate.PathRoutePredicateFactory$$Lambda$303/1756333997@15c043f3, gatewayFilters=[]}
2017-11-15 00:10:56.603 DEBUG 9196 --- [ctor-http-nio-2] o.s.c.g.handler.FilteringWebHandler      : Sorted gatewayFilterFactories: [OrderedGatewayFilter{delegate=GatewayFilterAdapter{delegate=org.springframework.cloud.gateway.filter.NettyWriteResponseFilter@38d17d80}, order=-1}, OrderedGatewayFilter{delegate=GatewayFilterAdapter{delegate=org.springframework.cloud.gateway.filter.RouteToRequestUrlFilter@6ede46f6}, order=10000}, OrderedGatewayFilter{delegate=GatewayFilterAdapter{delegate=org.springframework.cloud.gateway.filter.LoadBalancerClientFilter@4649d70a}, order=10100}, OrderedGatewayFilter{delegate=GatewayFilterAdapter{delegate=org.springframework.cloud.gateway.filter.NettyRoutingFilter@5d43409a}, order=2147483647}, OrderedGatewayFilter{delegate=GatewayFilterAdapter{delegate=org.springframework.cloud.gateway.filter.ForwardRoutingFilter@66273da0}, order=2147483647}, OrderedGatewayFilter{delegate=GatewayFilterAdapter{delegate=org.springframework.cloud.gateway.filter.WebsocketRoutingFilter@2127e66e}, order=2147483647}]
2017-11-15 00:10:56.603 TRACE 9196 --- [ctor-http-nio-2] o.s.c.g.filter.RouteToRequestUrlFilter   : RouteToRequestUrlFilter start
2017-11-15 00:10:56.603 TRACE 9196 --- [ctor-http-nio-3] o.s.c.g.filter.LoadBalancerClientFilter  : LoadBalancerClientFilter url before: lb://SERVICE-CHAT:3000/socket.io/?EIO=3&transport=polling&t=L-z0x3I&sid=FSD-70PMIBf9JQBoAAAn
2017-11-15 00:10:56.603 TRACE 9196 --- [ctor-http-nio-2] o.s.c.g.filter.LoadBalancerClientFilter  : LoadBalancerClientFilter url before: lb://SERVICE-CHAT:3000/socket.io/?EIO=3&transport=websocket&sid=FSD-70PMIBf9JQBoAAAn
2017-11-15 00:10:56.604 TRACE 9196 --- [ctor-http-nio-2] o.s.c.g.filter.LoadBalancerClientFilter  : LoadBalancerClientFilter url chosen: http://windows:3000/socket.io/?EIO=3&transport=websocket&sid=FSD-70PMIBf9JQBoAAAn
2017-11-15 00:10:56.604 DEBUG 9196 --- [ctor-http-nio-2] r.i.n.c.PooledClientContextHandler       : Acquiring existing channel from pool: DefaultPromise@7699b2d0(incomplete) SimpleChannelPool{activeConnections=0}
2017-11-15 00:10:56.604 TRACE 9196 --- [ctor-http-nio-3] o.s.c.g.filter.LoadBalancerClientFilter  : LoadBalancerClientFilter url chosen: http://windows:3000/socket.io/?EIO=3&transport=polling&t=L-z0x3I&sid=FSD-70PMIBf9JQBoAAAn
2017-11-15 00:10:56.604 DEBUG 9196 --- [ctor-http-nio-4] r.i.n.resources.DefaultPoolResources     : Acquired [id: 0x7b5d5497, L:/<IP_ADDRESS>:56965 - R:windows/<IP_ADDRESS>:3000], now 1 active connections

Is there any other option that I'm missing?
Thanks,
Pedro

It does not work yet

Thanks for the reply @spencergibb. Is there a roadmap to implement this feature?

We'll use this issue to track it

PR #126 is a proposed solution to combine loadbalancing with websockets


Make Deployment Name on the Publish Gke dialog a editable combo box.

Add a text block to indicate if we are updating or creating a GKE deployment.
Change the GkeDeployment static class to GkeDeploymentService.
Move all deployment logic to GkeDeploymentService.
During Gke Publish, skip the existing deployment check (already done as part of the UI).
Fixes #429

If required, I can split this into two PRs. One commits up to 50ebec1, and one for commits 15a60a1 on.

PTAL


Various improvements

This pull request adds one bug fix and several features.
First, it fixes a bug where if you start the logger with log file, set logLevel to 0, then delete the logger, the file won't be closed.
Second, it turns logLevel and commandWindowLevel into dependent properties.  This allows validation to be done on them when they are set.  All the methods access the values through real, hidden properties for performance reasons.  This includes making sure the level is valid, allowing specifying the level by name instead of just by number, and not allowing enabling file logging when a file hasn't been opened.
Third, it allows overriding the date format.  This also checks that the new date format is valid before setting it.

Not entirely sure that 788452d204d003c3d1741e46908de0fec6419208 is the culprit but I'm seeing a slow down in testspeed.m.

testspeed gives me
1e2 logs when logging only to command window
Elapsed time is 0.130840 seconds.
1e3 logs when logging is off
Elapsed time is 0.105394 seconds.
1e2 logs when logging to file
Elapsed time is 0.048177 seconds.

on master, and
1e2 logs when logging only to command window
Elapsed time is 0.148633 seconds.
1e3 logs when logging is off
Elapsed time is 0.195424 seconds.
1e2 logs when logging to file
Elapsed time is 0.059833 seconds.

with your changes. What do you think is responsible for the difference? The properties?

The problem was actually the isKey Map method.  It is extremely slow.  I have replaced it with an value-based lookup and now get performance roughly equal to current master.

Many thanks for all that! The timings looks good now. If I may, can I ask a couple more small things:

add a comment to explain the reason for getLevelNumber
indent with 2 spaces throughout (some places use 4)
add a short example in the README on changing the date format.

Requested changes have been implemented.

Many thanks!


Use mathml namespace

mathml needs to have the XML namespace set to be properly formatted. This forces Nokogiri to export mathml and only mathml.
Also, this stops automatically updating the expected XML, so that tests have the possibility of failing.

Thanks for your contribution, Erik! Where did you have this issue of incorrect formatting?
I'll check this out tonight, it somehow flew right under my radar.

I'm trying to improve the process of translation into HTML via oxgarage by embedding MathML in the docx xml. (It makes sense, I promise :)
In any case, MathML is not MathML unless it has a namespace or is embedded in HTML5.

Ha, I'm certain it makes sense, even if it sounds a bit strange. :)
Anything you can push upstream to OxGarage? As for the namespace, that
makes sense, my test case was HTML5, so I didn't consider this.
On tor., 13. okt. 2015 at 19:20 Erik Hetzner<EMAIL_ADDRESS>wrote:

I'm trying to improve the process of translation into HTML via oxgarage by
embedding MathML in the docx xml. (It makes sense, I promise :)
In any case, MathML is not MathML unless it has a namespace or is embedded
in HTML5.
—
Reply to this email directly or view it on GitHub
https://github.com/jure/mathtype_to_mathml/pull/3#issuecomment-147782855
.

Basically I am using the technique here:
https://msdn.microsoft.com/en-us/library/documentformat.openxml.wordprocessing.contentpart(v=office.14).aspx
to embed mathML in the docx file. This way we don't have to post-process the document based on errors reported by oxgarage. (That technique was not working for me)
These are the changes:
https://github.com/TEIC/Stylesheets/pull/117
https://github.com/Tahi-project/ihat/pull/65

You've overwritten the examples (manually collected by using MathType's native conversion) with actual outputs, so I'll have to fix that. I didn't run specs this way, as the XMLs never matched and will potentially never match exactly, but the visual comparison you get is very useful (that's the testing method I used):
bundle exec ruby spec/html_output.rb > test.html

We have three equations with issues (equation2.bin, equation4.bin, equation14.bin), so I'll look at those as well.

Committed here https://github.com/jure/mathtype_to_mathml/commit/936934927c0032fa7a66a97517891f003325a36e
I left the namespace addition in, and I'll make XMLs not be overwritten in RSpec's test, but I removed any other modifications to the expected XML files.
Hope that addresses your issue!

And this is the XML equivalence change: https://github.com/jure/mathtype_to_mathml/commit/db2030b16be7e429340b1b53eb615471441ed3d4
This is still not going to work right, because of the subtle differences between MathType's conversion and our own. Once we have a completely working test set (by comparing visually, and including #1), we can switch to comparing the XMLs directly, but for now I'd use the html_output.rb.

Thanks, @jure ! I think I misunderstood what your tests were doing. It sounds like you are checking against a reference XML output from mathtype.
Maybe these tests could be marked pending so that the tests pass.


Removed Position.End

cc: @pakrym, @davidfowl, @joshfree, @ahsonkhan
When sequences move to end default(Position) is returned from TryGet
Before calling ISequence.TryGet for the first time, the calling code has to call ISequence.First, as default position no longer mean the first item (necessarily)
APIs like buffer.PositionOf(byte value) return Position? (nullable). They return null if value is not found
All these changes were requested by @pakrym to allow him to use Position in pipelines instead of ReadCursor.

@dotnet-bot test Innerloop Ubuntu16.04 Release Build and Test


Provide more specific url in description of Genomic Reference Attribute

Information
Proposed change:
Provide more specific url in the description of the Genomic Reference attribute. Sheila Reynolds suggests using: https://www.ncbi.nlm.nih.gov/assembly/GCF_000001405.39 as the current url in the description "is not really specific, it just defaults to the current/latest

Dicussion link:
See comment in HTAN data model google sheet here: https://docs.google.com/spreadsheets/d/1tBK7lBcWU3FvdB2awtHLWbRuK6od3k4h60grDzydX8k/edit?disco=AAAALLFC3mk. This is a triaged issue from #151

How important is this feature?
Select from the options below

🏝 Low - it's an enhancement but not crucial for work

Implementation checklist

[ ] Branch created
[ ] HTAN.model.csv editied and pushed
[ ] HTAN.model.jsonld validated and created by Github action
[ ] PR opened
[ ] PR approved
[ ] PR merged into main
[ ] New Component added to ncihtan/HTAN-data-curator (if required)
[ ] DCA update requested
[ ] DCA updated

The line in question is
https://github.com/ncihtan/data-models/blob/29abf630031b6c7336b6255907ad9d09a8502367/HTAN.model.csv#L339

Description now reads
Exact version of the human genome reference used in the alignment of reads (e.g. GCF_000001405.39)


Integrate new codegen with cvxpygen

Integrate code generation functionalities with cvxpygen @maxschaller would you have time to help with this?

[ ] Adjust function call (no longer needs cmake) https://github.com/cvxgrp/cvxpygen/blob/5aaacdb894354288e2f12a16ca738248c69181c4/cvxpygen/cpg.py#L451
[ ] Edit API to pass codegen parameters https://github.com/osqp/osqp/blob/3c0ffa8de757ec84ecdd3ccf93bee0195557efc7/include/public/osqp_api_types.h#L128-L138

Yes!


A Small Bug in Example Time Series-Landsat

Hi Tylere,
time = [datetime.datetime.fromtimestamp(i/1000) for i in (data[0:,iTime].astype(int))]
This is from your example Time Series- Landsat. When I run the code, it seems that an error occurs becasue of astype(int).
The error is "Python int too large to convert to C long".
My environment is a Jupyter notebook Python 3 (windows 64-bit).
I think the solution is to exclude astype(int), just use time = [datetime.datetime.fromtimestamp(i/1000) for i in (data[0:,iTime])]. But I have not went through it.

Any luck fixing this? I tried removing the astype with no luck

I had my start date as 1989-01-01 in my code but should have just included the year

I solved my own code, if your start and finish dates are in the correct format then it should work


Please provide introspection of registered protobuf packages

The proto.MessageType and proto.GetProperties functions can, together, be used to introspect the fields available to a protobuf message type identified by name. This request is for corresponding functionality that operates at the level of protobuf packages.
syntax = "proto3";
package k8s.io.some.package;

message SomeMessage { ... }
message OtherMessage { ... }

The API doesn't need to be very complex, just enough to figure out which messages are available:
type Package struct {
  Name string // "k8s.io.some.package"
}
func (*Package) MessageTypes() []reflect.Type

// []string{"k8s.io.some.package.SomeMessage", "k8s.io.some.package.OtherMessage"}
func (*Package) MessageNames() []string

Use case: I want to add type safety to an existing protobuf-compatible config system. The user-visible behavior and error messages will be much more pleasant if the code can introspect the set of messages available to a named Protobuf package.

Hi, thanks for the issue. I'm going to close this as a duplicate of #268, which is the super-bug, tracking registration improvements. What you are describing is a feature I would like to see be possible in the overhaul of registration.


Need REST API to List Items in an Order

Hey team! Please add your planning poker estimate with Zenhub @even1111112 @nicksome168 @PepperandSummer @un-poco @yjhsieh2022


PP-3838 Expose internal mandate state to frontend

WHAT YOU DID
We need the internal state of a mandate to properly deal with error messages in frontend (ie. know if a mandate has expired)

I might be late at the party, but shouldn't we use external states to map to internal states? By sending internal connector specific states all the way to front-end then we couple the two microservices on internals of connector, we are not consistent on what we do (use external_state to send states to front-end from connector) and we have something not working in our code if we need internal states to display error messages. I know we are very pressured on time but we should strive more to be consistent in the way we do things.


Add option to enforce explicit module dependency declarations

Discussed in https://github.com/spring-projects/spring-modulith/discussions/923

Originally posted by ghferrari November 4th, 2024
First of all, thanks to the Spring Modulith team for this great package. :-)
If I've understood the documentation for version 1.2.5, Spring Modulith currently uses an “allow-by-default” access model i.e. access to other modules is allowed unless explicitly restricted. Is there a way to switch to a "deny-by-default” permission model? In this scenario, access to other modules would be forbidden by default unless specifically granted? I think this would be a useful feature.

This is currently not possible, but a very reasonable thing to ask for. As a workaround, you could use an ArchUnit rule that verifies @ApplicationModule being used and the allowedDependencies attribute set to a non-empty array.


Enable Wasm with V8 runtime on CI for both Windows and Linux/arm64.

Enable Wasm with V8 runtime on CI for both Windows and Linux/arm64.
cc @lizan

For arm64 the issue is we don't have emscripten, though we can enable wasm without emscripten tests, WDYT?

Sounds good, majority of tests have both C++ and Rust versions.

@PiotrSikora wasm-cpp-host failed to build on Windows:
https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/60523/logs/15

Could you try https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/117? I don't have a way to test it.
Also, please keep it mind that wee8.genrule_cmd wasn't tested on Windows, so it might need some fixes as well.

@lizan did it help?

Trying it out https://dev.azure.com/cncf/envoy/_build/results?buildId=61370&view=logs&j=b840a642-5ff3-5357-2e4b-e06e40b0cffd&t=67965174-5100-5631-9dc0-68b9f0aacb53

Could you try again with the latest commit? Previous build failed because of change to cargo-raze artifacts that wasn't updated in Envoy yet, buy it is now.


Harden remote events against bad input

Use typeof(value) instead of pcalling to determine userdata type
Perform type checks on arguments supplied by clients

Can we accept this? Looks like a good change.


Dependency not working for my project

For some reason I get an error after adding the dependency to my project. What's gone wrong here?

There are some issues with the Maven Central link as I'm moving this repo to jCenter..
I apologize for all inconveniences...

Any updates on this matter?

I now use the amazing tool jitpack.io for automated builds and maven deploying. Read the specific section in the README.md.


Running kalk.exe standalone from explorer has broken prompts in output

If I run kalk.exe straight from explorer it pops up a command window but the color codes seem to be broken and display as strings:

When I run this from e.g. conemu it works fine. Not sure if this is something about detecting console capabilities to turn off the color output or what might be the difference?

I'm not sure what information you might need from me - this is 0.1.1 downloaded straight from https://kalk.dev . I can build from source and debug or provide anything else you might need since I imagine this is system-specific and not a general problem.
btw I'm not sure if this is a separate unrelated issue but my gut feeling tells me it's too coincidental and it's probably related to the same thing. Even in conemu if I type in an unrecognised command it seems to break the prompt from then on:

And then if I type I typed this just once I get:

If that needs to be split into a separate issue please let me know, I didn't want to file two bugs since it felt like probably the same root cause.

Which OS are you? kalk indeed requires a compatible terminal that supports ANSI escape code sequences, which comes now almost by default with Windows 10. There is something in the code that tries to detect if it is supported and disable it, but seems that it doesn't work.
Otherwise, yeah, I have tried kalk only from a new Windows Terminal prompt and on MacOS. Even for the Linux version, I tried it from WSL2 from a Windows Terminal. I haven't tried in other terminals... not sure it is fixable easily on my side depending on the terminal tricks they are doing to support some ANSI escape code sequences...

Ah yeh, I'm on windows 7. Indeed on my windows 10 test machine it works fine, I should have thought to try that. If this isn't feasible to support then it's fine to close this. I'll see if I can hack something locally maybe as it mostly works aside from the error message case in conemu.

So I just tried kalk on Windows 10 from conemu and it's working as well (likely conemu is not trying to do anything with escape codes)
Weird thing is that you are getting a double \n in your conemu...
Anyway, I can't really help because I don't have a Windows 7 anymore around me (and I'm not sure I want to spend time on this myself! 😅 )

ansi colors are supported in windows 10 since the creators update (but not before).


Theme color override in TypeScript

👋 I'm trying to follow the 'Custom Theming' example from https://primer.style/components/primer-theme#custom-theming. My React app uses TypeScript. I'm getting the following error:

It looks like including the imported Primer theme isn't adding any properties of its own:

I'm importing the Primer theme with import { theme as primer } from "@primer/components";. Could the theme be missing type definitions? Thanks!

The theme's type definition i just a generic Object and it is included in the index.d.ts file so I'm not sure what's going on here 🤔 Mind DM'ing me in Slack the repo you're trying to use this on and I will take a look?

Hey @cheshire137! Checked in with our resident TS expert @T-Hugs and it looks like when you modify an object, it will lose the type from the object you're spreading (primer). All you'd need to do in this case it create a new interface for the new modified theme like so:
interface Theme {[key: string] : any}

const theme: Theme = {
  ...primer,
  space: [0, 8, 16, 32, 64],
  fontSizes: [10, 12, 16, 24, 48]
}

theme.colors.bodytext = '#111'

Thank you!!


Center delimiters vertically about the axis

Closes #540
This is the same song, different verse of the recently merged #1735.  The XITS Math parentheses have a low baseline.

However, the baseline plays no role in math layout:
TeXbook, Appendix G, Rule 19 (deep in the paragraph): "Shift the delimiters up or down so that they are vertically centered with respect to the axis."
XeLaTeX and MS Word have no trouble with delimiters with XITS Math.
This PR ensures that delimiters (which arise in vector, matrix, binomial coefficient, and LR constructions) are centered on the axis.
There were 9 test files that had changes.  All were very minor (2% or less pixel variations) associated with minor shifts associated with delimiters.
#set text(size:12pt)
#show math.equation: set text(font:"XITS Math", fallback:false)
$
( A / (sum_c^d k) )
$

Before

After

Wow, you are on a roll!


[Wasm]  Add Uno.UI.Helpers.Automation for UI Testing

PR Type
What kind of change does this PR introduce?

Feature

What is the new behavior?
Add Uno.UI.Helpers.Automation for UI Testing support
PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tested code with current supported SDKs
[ ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
[ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[ ] Wasm UI Tests are not showing unexpected any differences
[x] Contains NO breaking changes
[x] Updated the Release Notes
[ ] Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

You know what... it would be VERY COOL to add a way to ENUMERATE dependency properties on an object. That's would help a lot debugging UI in Uno & Apps on Wasm.


Font Color not changing to black?

I tried to set the font color to black #000000 and relaunch. The background turned white as expected but font stayed white too so I can't read anything.

I see what you mean. I'll have to investigate this more.

I've fixed this in commit 2a81cf5. You may have to clear your cache after you update (Shift + F5 in your browser).
The fix isn't great, but the implementation of this feature was bad to begin with. This should ideally be addressed by just having a couple of "themes" for users to choose from. But that won't be soon, so here's a bandaid.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.5 to before v5.12.10",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2ac061ce97f413bfbbdd768f7d2e0fda2e8170df",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=caec9bcaeb1a5f03f2d406305355c853af10c13e"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "2ac061ce97f413bfbbdd768f7d2e0fda2e8170df",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "caec9bcaeb1a5f03f2d406305355c853af10c13e",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "xen-netback: take a reference to the RX task thread\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.12.10 by commit caec9bcaeb1a5f03f2d406305355c853af10c13e, it was introduced in version v5.5 by commit 2ac061ce97f413bfbbdd768f7d2e0fda2e8170df. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1000822


Refs #33124 -- Avoided touching ConnectionsHandler.getitem until strictly necessary.

Ticket is 33124, following on from ticket 33025 which was PR 14769.

Repeated access to connections[alias] should be cached into a local variable wherever possible to avoid asking the Local for the value twice.
Asking for connections[alias] a single time should be deferred until absolutely necessary (ie: local to the if branch, or as the last part of an if chained comparison, etc)

@kezabelle These changes looks good, thanks :+1:  Is there anything left for this patch? If not, I can squash & merge.

I think this was all of the ones (outside of tests) which made sense, except for the change which Nick pointed out was problematic.
I think there's a couple of others that could be done, like eg: django.contrib.sites.management.create_default_site but they are "one and done" operations, which won't net any positive change and just muddy the git annotation history...
I can do another pass to find and do those if you'd prefer, though.

I can do another pass to find and do those if you'd prefer, though.

No need, thanks :+1:

buildbot, test on oracle.


Expand scraper.js support for events.

This PR adds events (instead of just commands) support for scraper.js
and fixes a crash when a type definition has no fields.

lgtm


Changed the position

Solved issue #370
https://github.com/user-attachments/assets/b6d1254c-3fd5-4236-bdd9-21f9d5c08644

@Akshatchaube01 Pls review this PR!!!


WASM module is not loaded; call 'await LibraryUtils.loadKeysModule()' to load

        import {
            MoneroUtils,
            MoneroNetworkType
        } from "monero-javascript";
        const result = MoneroUtils.validateAddress("45ENVMiz4MZV19MYYD3THkiaZ22eLEcB6KbNysSueNEa5sE5NdmnAGjhhMa3xgPttDC2SJji3bJiSdbpxg9VyNP55mGsLVD", MoneroNetworkType.MAINNET);
        console.log(result)

This code throws an error:
MoneroError: WASM module is not loaded; call 'await LibraryUtils.loadKeysModule()' to load
        at Function.validateAddress
        at verifyAddress
        at Object.<anonymous>
        at Object.asyncJestTest
        at new Promise (<anonymous>)
        at mapper {
      code: undefined

First call await LibraryUtils.loadKeysModule(); to load the WASM.
Then utility functions like MoneroUtils.validateAddress() can be called synchronously.


fix(aws-autoscaling): fix an AutoScalingGroup example in the README.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.
Summary
This patch fixes an AutoScalingGroup example in the README file.
Test

Deploy the sample snippet through cdk 0.12.0 (build 2dc324e).

Notes

It would be the best to update examples of README automatically if possible, but I do not have any good ideas.

Thank you!


added with_theme to Printer

cool. Can you push it to 0.8.1 crate?

To me it is. That would be appreciated. Thanks.
On Tue, 22 May 2018 at 00:23, Alexandre Bury<EMAIL_ADDRESS>wrote:

The current master has some breaking changes already, and is waiting for
some more that I'm trying to fit (if I'm going to make a breaking change,
make it count).
In the meantime I can backport it as a 0.8.2 on top of 0.8.1 if that's
important.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gyscos/Cursive/pull/251#issuecomment-390801143, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABS_551e3-x8S7QlSgfFmda6EhKDajezks5t0z5zgaJpZM4UHBzZ
.

Well, 0.8.2 is out, that's pretty easy.
For 0.9, the scroll branch is making good progress, and so is callback_preemption. Shouldn't be much longer... :^/


fix(CardLink): bx--grid--condensed added to the storybook story

Related Ticket(s)
CardLink: On a mobile device, the card is not stretched end-end of the mobile screen. #2609
Description
This isn't a problem with the component, only with its story
Changelog
New

bx--grid--condensed class to the CardLink story;

@guilhermelMoraes I'm looking at the deploy preview link and it still looks like it doesn't stretch the full width of the screen on mobile

@annawen1 it's supposed to fulfill the entire screen when it's smaller than 320px, right?

@guilhermelMoraes can you update jest snapshots?

@jeffchew updated the snapshot and noticed that the LightBoxMediaViewer is throwing an error:

@guilhermelMoraes try doing a yarn reset, the utilities package has been updated so you might need to rebuild locally.


[FEATURE] ADD SUPPORT DeepSeek-V2

DeepSeek-V2: A Strong, Economical, and Efficient Mixture-of-Experts Language Model
https://huggingface.co/deepseek-ai/DeepSeek-V2-Chat

I attempt to quan the deepseek-v2-lite. throw the error： “auto_gptq/nn_modules/qlinear/qlinear_exllama.py", line 64, in init
assert infeatures % self.group_size == 0
AssertionError”


python3Packages.ephem: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
Update to latest upstream release <IP_ADDRESS>
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129011 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.ephem
python39Packages.ephem


Extract cache directions calculation

(Please review https://github.com/5afe/safe-client-gateway-nest/pull/284 before)
This PR is preliminary work for #255. The /v2/flush endpoint needs to invalidate cache keys on demand, but the calculation of a concrete key/field is currently bonded to the client API functions (transaction-api.service, config-api.service classes), so this PR:

Extracts the cache key/field calculation from the API client class.
Centralises this calculation in a utility class with static functions (since state is not needed and the calculation is deterministic): CacheRouter.
Adds the CacheDir interface which encapsulates the key/field for a given cache address.

Coverage: 89.046% (+0.2%) from 88.851% when pulling bb02ed7a3375db0f7b21dc1f7bec7355741c8e1b on extract-cache-directions-calculation into 482300bef1680a0e3bf56178387ffc8cba3a4029 on main.


Branch out and make callendar with full controls

Add the ability to go forward and backward in time

Added ability to load more namedays
Closing.


Fix (Android): Remove fallback in l10n for unused strings

Looks good. Waiting for Travis to finish build checks. I approve this merge if travis succeeds.


Add one Snow test to quick e2e test suite

Issue #, if available:
Description of changes:
Adding one Snow test to the e2e suite.

Added all the required environment variables to the quick e2e code build spec yaml
Added TestSnowKubernetes128SimpleFlow to the QUICK_TESTS.yaml. It is disabled for now until we move the current tests to nightly, being cognizant of infrastructure limitations.

Testing (if applicable):

Manually invoking the codebuild project and sourcing the changes on this branch

Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


dryscrape console.log

Hello, congratulation for dryscrape.
Is it possible, with dryscrape, to get console.log(), like selenium:
for entry in driver.get_log('browser'):
print(entry)
Best regards

I Try:
hello = sess.exec_script('console.log("Hello World1")')
print(hello)
hello2 = sess.exec_script('document.write("Hello World2");')
print(hello2)
But no result:
None
None

succeded:
hello4 = sess.eval_script("function hello4(){ return 10;};hello4();")
print(hello4)
the script return: 10

This is not implemented. I would be happy to consider accepting this as a pull request.


Cleanup unused components on main page

Get rid of the following:

Leave the "counters" component as we'll replace those numbers later with fun facts regarding corporate american and first gen workers

PR #63


Disable minting button if user set zero value for listing

Disable submit button if a user submits NFT with listing price 0 as seems we've got an error.

👋

weirdly, I can't reproduce this bug, I'm minting with price 0 just fine? I get the warning @Jarsen136 implemented, not sure if I'm not getting something, but since @kkukelka took it, I assume other people face similar issues. Just a note, it looks from the message of the error that the number was considered too large?

@petersopko cant reproduce either
just minted with price 0
/rmrk/detail/13497940-64274F293D519F050C-AVGMUG-RED_MUG-0000000000000001

Me too. I could not reproduce that error when minting with price 0.

still can't reproduce the originally reported bug, but I've tried to put in very large numbers and I was successful at producing error message displayed at the image below. I think It would be in general best to look once again into the input field of price and make sure user won't be allowed to hit click to create nft(s) if he's about to run into some issues such as the one reported by @yangwao or me.

👋

still can't reproduce the originally reported bug, but I've tried to put in very large numbers and I was successful at producing error message displayed at the image below. I think It would be in general best to look once again into the input field of price and make sure user won't be allowed to hit click to create nft(s) if he's about to run into some issues such as the one reported by @yangwao or me.

what should we keep the max value?

what should we keep the max value?

the error I've attached resulted from the number switching from something like '1000000000000'  to '1*10^23'. if the number becomes too large, it switches to math expression which is confusing the input (it's converting number to string and then passing that to snek, iirc this was some hack we implemented to get around BigInt in indexer?). I've just now noticed there's more problems with the number input (at least on my local) as I can't even get the page to load properly

what should we keep the max value?

the error I've attached resulted from the number switching from something like '1000000000000' to '1*10^23'. if the number becomes too large, it switches to math expression which is confusing the input (it's converting number to string and then passing that to snek, iirc this was some hack we implemented to get around BigInt in indexer?). I've just now noticed there's more problems with the number input (at least on my local) as I can't even get the page to load properly

yeah on local it isnt opening up for me either, could be a side effect from #3377
CC @kkukelka

hmm i'll take a look at it then. thanks for debugging this so thoroughly @prachi00 @petersopko  👍

👋

ignore

what should we keep the max value?

the error I've attached resulted from the number switching from something like '1000000000000' to '1*10^23'. if the number becomes too large, it switches to math expression which is confusing the input (it's converting number to string and then passing that to snek, iirc this was some hack we implemented to get around BigInt in indexer?). I've just now noticed there's more problems with the number input (at least on my local) as I can't even get the page to load properly

The "not loading properly" issue needs to be fixed first https://github.com/kodadot/nft-gallery/issues/3444. I'm on it.

The "not loading properly" issue needs to be fixed first #3444. I'm on it.

thankfully fixed now, this issue remains open and we still need some limits for the input field


Connection to Voyant Tools

Find out why it does not work to directly import DraCor Data into Voyant Tools by providing the link to the API output, see also
https://github.com/EcoCor/ecocor-api/issues/1

It actually does work: https://voyant-tools.org/?view=corpusset&stopList=stop.de.german.txt&input=https://staging.dracor.org/api/v1/corpora/ger/plays/lessing-emilia-galotti/spoken-text
See https://github.com/EcoCor/ecocor-api/issues/1#issuecomment-2408132515.

OK, wow, that's great news. Was an easy fix ;)

Do you think we should include a link somewhere in the frontend, as for example the  DTA does (e.g. https://www.deutschestextarchiv.de/book/show/abelinus_theatrum_1635)?

Do you think we should include a link somewhere in the frontend, as for example the DTA does (e.g. https://www.deutschestextarchiv.de/book/show/abelinus_theatrum_1635)?

Yes, that would probably be nice. The question would be where and with which parameters. And only with spoken-text or other resources as well? Maybe you, @ingoboerner and @lehkost could create a ticket in dracor-frontend detailing the feature.

@ingoboerner, @lehkost please edit the description for dracor-org/dracor-frontend#310.


Improve search applet - ADD YOUR PICTURE BELOW

Before (left) and After (right)

Besides the visual overhaul, this indexing page is redesigned with many more features compared to the previous version.

Folders no longer need a +page.svelte file in each sub-folder to have the indexing work.
Search actually works.
Search has a fuzzy search (using fuse.js) to prohibit small typos.
Each applet has a preview button to quickly inspect each applet in "iframe mode".

!! TODO for all reviewers:
Previously, we discussed that it's inappropriate to add individual credits in the embed and share window, as these credits will be directly included in the book. In my opinion, we should add individual credits to this indexing page because it will serve as a home page and entry point from all applets and will never be visible in the final book.
To add your contribution:

Open this branch (improve-search-applet)
Add a profile picture in the /apps/web/static/contributors folder (Must be .png)
Rename the image to your name (Capitalised and with spaces, for me that is "Abel de Bruijn.png")
Add your name and title to the list of contributors in this file.

Alternatively, you can also leave your profile picture in a comment on this pull request, along with a title of your choice.

Ik kan de naam van mijn foto niet hernoemen, noch mijn naam toevoegen aan "dit bestand".
Verder weet ik niet wat ik verder nog moet reviewen; maar een kleine preview tijdens het zoeken (in te klappen?) lijkt me wel mooi.

A new PR will be created for those who have not yet added their profile image to the homescreen.


Remove illegal "debug" kw argument

Fix for https://github.com/numba/numba/issues/6615
Removes illegal argument from call to  FakeCUDAKernel. Hard to trigger in test -- but currently these lines are untested and clearly illegal, as FakeCUDAKernel does not take the debug keyword.
With these lines removed, works with my test suite in with NUMBA_ENABLE_CUDASIM defined; otherwise doesn't work.
Relevant configuration in conftests.py:
def pytest_configure(config):
    """
    Implement configuration options.
    * If "CUDA" is specified, make sure cuda simulator
      is turned on before collection if real cuda not available.

    * remove featureset cache if specified
    """
    cudasim = config.getoption("--cudasim")
    if cudasim:
        os.environ["NUMBA_ENABLE_CUDASIM"] = "1"
        config.option.cuda = "true"
        return
    cuda = config.getoption("--cuda")
    if cuda:
        check_cuda()

def check_cuda():
    """
    Check if CUDA simulator is necessary.

    Use CUDA simulator if CUDA not available.

    We have to call in subprocess because load of `cuda`
    module requires NUMBA_ENABLE_CUDASIM to be set first.
    """
    available = (
        subprocess.check_output(
            [
                "python",
                "-c",
                "from numba import cuda; print(cuda.is_available())",
            ]
        )
        .decode()
        .strip()
    )
    if available != "True":
        os.environ["NUMBA_ENABLE_CUDASIM"] = "1"
        print(f"Using CUDA Simulator (available: {available})")
    else:
        # make sure we use appropriate device
        from numba import cuda

        c_dev = cuda.get_current_device()
        cd_cc = c_dev.compute_capability
        assert cd_cc[0] >= 8 and (cd_cc[0] > 8 or cd_cc[1] >= 6)

Thanks for the PR @shaunc.
@gmarkall please could you review, thanks.

Thanks for the test! For the conftest to work, you also need pytest_addoption ... and probably that isn't what is wanted either (we want to test unconditionally -- not depending on an option, and the test should be isolated from other tests).
I meant that more as an illustration of how I was managing to trigger this problem (though I'm not actually sure in detail what is happening). Still -- the PR does fix the problem for me, so was hopeful it could find its way into the repo.

[Ok -- @gmarkall -- added your test to PR; Thanks!]

@shaunc thanks for the patch, any chance you could fix this flake8 error please so that CI succeeds? https://dev.azure.com/numba/numba/_build/results?buildId=8269&view=logs&j=9b1c419d-97bd-5aaf-47ca-b83be1ff9bc1&t=d1ed00e6-cc06-521a-e00c-4f5e4a0f55c5&l=84
Many thanks.
@gmarkall thanks for reviewing.

Think there's another debug= here https://github.com/numba/numba/blob/e0ffba72656d317d8ecd4396224d04c9088a39ae/numba/cuda/decorators.py#L76-L80 ?

Ok -- got that one too...

@stuartarchibald Are you happy for this to go in, following a successful buildfarm run?

@stuartarchibald Are you happy for this to go in, following a successful buildfarm run?

Yes, I think this is a fix solely based on inspection of the source/issue reported, the debug flag is evidently erroneous in various cases. Also, as noted, the logic needs looking at more generally but that's not a task for this PR. Thanks for reviewing @gmarkall.

Buildfarm ID: numba_smoketest_cuda_yaml_38.

Buildfarm ID: numba_smoketest_cuda_yaml_38.

Passed.

@shaunc Congratulations on your first contribution to Numba!


Some improvements around the Acquire trait

I think all current Connection types are Send, so this should be fine, right?

Yep, this is fine. I'm not sure how making that impl for &Pool more general helps, but if it does, great.
All Connections are Send.


Headphone jack no longer working

I just updated to the newest version on a 14 inch M2 Max macbook pro. Now the headphone jack is no longer working. I can see in dmesg the driver does detect any unplug/plug event:
[ 1677.110652] cs42l84 2-004b: Plug event
[ 1677.319839] cs42l84 2-004b: Detected bare headphone (no mic

But in pipewire I only have a dummy output Audio sink. How can I verify the provided alsa config is loaded properly?

For some reason this has resolved itself after rebooting twice.

I did have a similar issue when initially developing support, I'm not exactly sure why. But it did go away and seems to work nicely now.


"Invalid Elasticsearch URL" error, but the connector is pulling index and type data correctly

My Elasticsearch URL is http://lgb-es-01:9200. When I populate the "Elasticsearch URL" with this, I can see and select my index and types correctly. But hitting "Preview" or "Submit" causes an "Elasticsearch URL is not a valid URL" error.
Running ES 5.4, Tableau 10.2.0.

The issue is in app.js it looks like:
 var isValidUrl = function (str) {         var pattern = new RegExp
Looks like the regex does not expect numbers to be at the end of the URL.
My suggestion is to not validate the URL at all, since an "Unable to get Elasticsearch indices" error will occur if the URL doesn't point to a valid ES server anyway.

Yes, will update the regex, look for a fix for this soon.  thanks for identifying.


Azure inventory collection by region may need change

This is an "up for debate" issue that I thought I should post. If we decide to keep things as they are, so be it, but I thought I should at least bring it up.
At the moment, the Azure region a user selects in the UI narrows down the resources by the region of the resource groups, rather than the region of the resources themselves. However, in Azure there is (usually) no restriction that requires that the resources within a resource group to belong to the same region. So, you could have a resource group "alpha" in East US, which in turn contains resources from Central US, West US, etc.
Our original thinking, when we were brand new to Azure and V2 in particular, was that resources would always be in the same region as their respective resource group. Otherwise, why give a resource group a location at all? It turned out, however, not to be the case. In reality you are only "encouraged" to put resources in the same region as their resource group for ease of template deployments and potential availability issues, but are actually not required to do so. This is why you'll sometimes see resources that are "out of region" in the UI.
However, there is a certain logic in filtering by the location of a resource group, since it (potentially) keeps logically related items together that a user might expect to see, even if they aren't actually in the same region.
So, the question is, should we alter the logic for Azure inventory collection to filter by the location of a resource instead of its resource group? At least for those resources that actually have a location. Stuff like templates could still default to its resource group.
The actual code change would not be difficult - there's one method in the refresh parser than needs modification - but it will change the results.

@bronaghs @bzwei @blomquisg @roliveri @jerryk55 @Fryguy @jrafanie Thoughts?

So, are you saying that currently, if a user has a resource group that contains resources that are in a different region than the resource group (and hence the provider) in question, then the inventory collected will contain resources that are outside of the provider's  region?
If that's the case, then is it possible to have 2 providers for the same account, each for a different region?
If so, then it seems it would be possible for each provider to collect inventory for the same resources. I'm not sure how this will be handled in the vmdb. Will there be 2 entries for the same resource, each associated with a different provider?

@roliveri To answer your first question, yes. I don't know how common this will be in practice, though.
For your second question, I'm not entirely sure what you're asking. A resource can only belong to one resource group, though multiple resource groups can belong to the same region. So, I think the answer to your question is no, but maybe I've misunderstood.

@djberg96 Here's an example:

Say we have an Azure account (say acct1).
We have 2 regions: regA and regB.
When we add an Azure provider, we enter the account information for acct1 and specify regA for the region. Let's call this provider Provider_regA

Can we add another Azure provider, entering the account information for acct1 and specifying regB for the region? Let's call this provider Provider_regB (can we do this?)
Given a resource can only belong to one resource group, this part of my question changes. Assuming providers as described above:

Say we have resourceA in regA.
and we have resourceB in regB.
We have resource_groupA in regA.
resourceB is added to resource_groupA
resourceB cannot be added to resource_groupB

Given this, Provider_regA will see and have resourceB in its inventory, while Provider_regB will not. Even though resourceB is in the region designated for Provider_regB. This seems to be unexpected behavior. Would Provider_regA be able to do anything with resourceB?
I don't think the fact that Provider_regA can see resourceB  is necessarily a problem, but I do think the fact that Provider_regB can't,  may be an issue - especially if it's the only provider that can actually perform operations on, and using, resourceB.

I cannot think of a scenario where filtering resources by resource_group location versus resource location is better. In fact, at the time of implementing the Azure refresh parser we thought there was no way to filter inventory objects by location so we filtered on resource_group location, not realizing at the time a resource can belong to a different location that its resource_group.
This is a problem right now with networking.

The user adds a Cloud Provider in MIQ for the region regA, called Provider_regA.
A list of resource_groups inside regA and the inventory within them will show up in Provider_regA
cloud_network_a belongs to regB but will land in Provider_regA because it belongs to a resource_group in regA.
During provisioning within Provider_regA, if the user selects cloud_network_a all hell will break loose, see https://github.com/ManageIQ/manageiq/issues/8795.
@roliveri - I think the answer to your question "Would Provider_regA be able to do anything with resourceB?" is likely, "no".

https://github.com/ManageIQ/manageiq/pull/8758 is another bug caused by this, again around networking
Unless anyone can find a compelling reason not to, I propose we make the small code change to filter on  resource.location  instead of resource_group.location

#8869 was merged, closing.


Support use of specialized type as generic argument

The following code triggers an unimplemented case at findWitnessTable, where irVal->op == kIROp_specialize. Also need to handle such uses in other places such as IRSpecContext::maybeCloneValue.
// TODO: We might eventually have cases of `specialize` called
// on a witness table...

Test case:
generic-struct-with-constraint.slang:
//TEST(smoke,compute):COMPARE_COMPUTE:-xslang -use-ir
//TEST_INPUT:ubuffer(data=[0 0 0 0], stride=4):dxbinding(0),glbinding(0),out
// Confirm that generics syntax can be used in user
// code and generates valid output.

RWStructuredBuffer<float4> outputBuffer;

interface IElement
{
    float4 getValue();
};

struct SingleElement : IElement
{
    float4 value;
    float4 getValue()
    {
        return value;
    }
};

struct ListElement<THead : IElement> : IElement
{
    THead head;
    float4 getValue()
    {
        return head.getValue();
    }
};

float4 test<T : IElement>(T val)
{
	return val.getValue();
}

[numthreads(1, 1, 1)]
void computeMain(uint3 dispatchThreadID : SV_DispatchThreadID)
{
    ListElement<SingleElement> list;
    list.head.value = float4(1.0);
    float4 outVal = test(list);
	outputBuffer[0] = outVal;
}

Never mind, this is actually because I need to call test<ListElement<SingleElement>>(list) instead of test(list).
We need to add automatic witness argument deduction some time.
Closing this issue for now.

Well, changing it to test<ListElement<SingleElement>>(list) still crashes the compiler. I need to track further.

OK, this is because we currently have not implemented the case where the declRef points to a specialization instead of a simple struct type in findWitnessTable.

Ah yes. I think that in this case we need to support something like a generic witness table, and then specialize the witness table (which means make a clone of it with specialized methods).
We should probably first search for a witness table using the mangled name of the specialized type, and then I’d that search fails do another lookup using the unspecialized type name do find a table we can specialize.

Your point about needing to support witness tables when doing implicit generic specialization is also correct: we can’t really have usable syntax without it. Let’s open a separate issue for that (if we don’t already have it).

Working on this now, almost there.

Great! And obviously while I’m away feel free to do your own reviews and use admin permissions to check in as needed.


Decompose ConstantOfShape into Expand and some rewriting rules

This patch decomposes ConstantOfShape {value} into Expand (Constant {value}), and some canonicalization rules for Unsqueeze, Add and Sub operations when their inputs are from Expand (I use canonicalization because rules become now simpler).
Patterns are found in the roBERTa model, that is
%102 = onnx.Constant dense<1.000000e+00> : tensor<f32>
%367 = onnx.ConstantOfShape(%366) {onnx_node_name = "ConstantOfShape_9", value = dense<1.000000e+00> : tensor<1xf32>} : (tensor<2xi64>) -> tensor<?x?xf32>
// These two Unsqueezes can be folded into a new onnx.ConstantOfShape with value 1.0.
%370 = "onnx.Unsqueeze"(%367, %104) : (tensor<?x?xf32>, tensor<1xi64>) -> tensor<?x1x?xf32>
%371 = "onnx.Unsqueeze"(%370, %103) : (tensor<?x1x?xf32>, tensor<1xi64>) -> tensor<?x1x1x?xf32>
// This Sub can be folded into onnx.ConstantOfShape with value 0 since %102 and %371 are 1.0.
%372 = "onnx.Sub"(%102, %371) {onnx_node_name = "Sub_18"} : (tensor<f32>, tensor<?x1x1x?xf32>) -> tensor<?x1x1x?xf32>
// Multiply by 0
%373 = "onnx.Mul"(%372, %101) {onnx_node_name = "Mul_20"} : (tensor<?x1x1x?xf32>, tensor<f32>) -> tensor<?x1x1x?xf32>
// Add to 0
%418 = "onnx.Add"(%417, %373) {onnx_node_name = "Add_91"} : (tensor<?x12x?x?xf32>, tensor<?x1x1x?xf32>) -> tensor<?x12x?x?xf32>

@jenkins-droid test this please

@jenkins-droid test this please

@sorenlassen you have clearly a very in-depth knowledge of this topic; so when you are fine with the PR, I am good too.

Jenkins Linux amd64 Build #12716 [push] Decompose ConstantOfShap... started at 23:55

Jenkins Linux ppc64le Build #11732 [push] Decompose ConstantOfShap... started at 01:05

Jenkins Linux s390x Build #12739 [push] Decompose ConstantOfShap... started at 00:55

Jenkins Linux amd64 Build #12716 [push] Decompose ConstantOfShap... passed after 1 hr 13 min

Jenkins Linux s390x Build #12739 [push] Decompose ConstantOfShap... passed after 1 hr 28 min

Jenkins Linux ppc64le Build #11732 [push] Decompose ConstantOfShap... passed after 1 hr 45 min


Cleanup

Stop using unittests2, stop pylint's nonsense

Pull Request Test Coverage Report for Build 61

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.256%

Totals

Change from base Build 60:
0.0%

Covered Lines:
116

Relevant Lines:
130

💛  - Coveralls


Installation error against Python 2.7.6

Python Version: 2.7.6
OS: Ubuntu 14 LTS
PIP: 1.5.4
The following error is seen when installing via pip install.
Downloading/unpacking cryptography>=1.9 (from pyOpenSSL->python-binance)
Downloading cryptography-2.1.2.tar.gz (441kB): 441kB downloaded
Running setup.py (path:/home/caof/.virtual_envs/biance_ve/build/cryptography/setup.py) egg_info for package cryptography
error in cryptography setup command: Invalid environment marker: python_version < '3'
Complete output from command python setup.py egg_info:
error in cryptography setup command: Invalid environment marker: python_version < '3'

Cleaning up...
It seems like the dependent library cryptography doesn't support python 2.x

@caohunan can you try upgrading setuptools and see if that resolves the issue.
pip install --upgrade setuptools

@sammchardy
My bad...It works fine now. I forgot to upgrade setuptools. I used a pretty old version of setuptools.


In download ,how to output Chinese.

In download ,how to output Chinese.

I believe you are safe to use utf-8 encoding for Chinese text.
Here is [one example] (https://github.com/chfw/pyexcel/blob/master/tests/test_io_csvbook.py#L9) in the test code.


Assign thread priorities for read pool

According to an internal benchmark in TiSpark, when a specific thread pool's load keeps high (i.e. normal-priority thread pool in coprocessor), other threads does not have much chance to be scheduled.
Currently our "high priority" pool does not have high priority in fact. By assigning real thread priorities via syscalls to these threads we may get more in-time responses for high priority threads.

Hi! I'd like to give this issue a shot! Although I'd like to get some pointers to places in code that I can start looking for this issue.
Thanks.

We are now using Unified Thread Pool so that I believe this is no longer a problem any more.


Upgrade to Node 6

It seems it works, except it logs this warning:
(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

And a lot of JS stack traces.
Let's wait for fixes. Then update: .node-version, readme required Node 5+, circle.yml, babel node preset

Last night had issue on Heroku with node 6, build failed due to webpack-isomorphic-assets couldn't resolve css modules.

https://github.com/jhen0409/babel-preset-es2015-node6

@ilionic Did you already fixed webpack-isomorphic-assets issues?

It seems circleci still does not support 6.1.0
Hi Daniel,

We're planning on shipping some changes to our Ubuntu 14.04 build image. We will ship the changes between 18th and 19th, May.

Here is a brief summary of the major changes.

Adding Nodejs 6.1.0

https://gist.github.com/rauchg/8199de60db48026a6670620a1c33b700

Facing some issues on production build after switching to Node 6.
throw new _gulpUtil2.default.PluginError('webpack', buildError);
Error: Path must be a string. Received undefined

Could be related issues:
https://github.com/webpack/webpack/issues/2463
https://github.com/babel/babel/pull/3579
Has anybody faced similar?

No. Este works. Be sure you have Node 6.1+ and correct package.json dep versions.


Adding Item 12 Analyzer, Provider and Tests

I have added logic for the item 12 analyzer.
The analyzer can handle the rule as well as its exceptions:
You should not initialize your field to null, zero, false or an empty struct constructor, since their initialization is zero by default in memory.
You should not initialize your field in the declaration if you have diverging constructor initializations.
The algorithm works as follow:

Loop through constructors and keep track of all field initializations. (
There is an abstraction called FieldInitializationInfo to help keep track of this information.)

Iterate through all field declarations and using the constructor initialization information from step 1, determine where to report a diagnostic if necessary. The code should be commented to explain every individual line.

Note: The code fix provider is in its very first draft (I have not had time to go over it after I wrote the V1). I will update this PR when I make those changes.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Duplicate of #36


as developer, i can have tests that are automated to check all functionalities work

partially duplicates #108 - this may be rescoped to unit testing


Add Unit Tests for lr add commands

Add unit tests for lr add * commands.

Please assign this to me.

Any updates

Hi @gagandeepp
Thanks for showing an interest in LoginRadius CLI. Issue assigned to you, please follow the contribution guidelines for submitting the PR

Not interested please unassign


another add

This commits and stuff you have to take care of or u will keep having this

yes this makes sense -

Squashing and Rebasing , puts all the commits out of sync, and keeps showing ur not up to date
The proper way to do is

First discard commits
Then update branch
Main branch from where you made fork takes precedence , over what you ahve locally


Update LAB_04L02_Package_AVD_applications_ADDS.md

The az140-42_azuredeploycl42.json and az140-42_azuredeploycl42.parameters.json files are deploying a VM - az140-cl-vm42 with a Public IP address, even though the instructions suggest to leverage Bastion host. This opens a big security problem.
Please remove the Public IP references from the JSON files
Module: 04
Lab/Demo: LAB_04L02
Fixes # .
Changes proposed in this pull request:
-Remove Public IP address connected to VM az140-cl-vm42

updated


[T4A2][T10-B1]Lim Wei Ming Ronald

Ready for review.

@RonaldLWM Some comments added. Please close the PR after reading comments.


Change repo ACL

Repo to change access:

https://github.com/hyperledger/aries-mediator-service

GitHub ID to add:

[ ] dbluhm
[ ] jamshale
[ ] jsyro
[ ] WadeBarnes

Remove:

[ ] ianco
[ ] jleach

One of:

aries-mediator-service-committers:
Role:

Manage / Maintain

Done!


Add a Gitter chat badge to README.md

go-xorm/xorm now has a Chat Room on Gitter
@lunny has just created a chat room. You can visit it here: https://gitter.im/go-xorm/xorm.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Added manually


FizzBuzz using Java

FizzBuzz is a program that prints the numbers from 1 to 100. But for multiples of three it prints “Fizz” instead of the number and for the multiples of five, it prints “Buzz”. For numbers which are multiples of both three and five it prints “FizzBuzz”.

Thank you for your PR!
Unfortunately a solution similar to yours has already been submitted :/
The goal is to find creative/abstract new solutions to FizzBuzz.
See The top 5 samples here.
Thanks anyway! :)


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>

Coverage decreased (-0.1%) to 81.633% when pulling 9ab5b12100597c7491bc958719eed6427d778174 on template-sync-1 into f8d830f51825e5eeb30d30c445ffda422b9b32e5 on master.

:tada: This PR is included in version 7.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


drivers: flash: stm32: harmonization of flash erase implementation across STM32 series

Flash erase implementation differ from one STM32 serie to the other:
Some, like f7 (or f4) starts by clearing CR registers except sector mask. So reset of any previous configuration
	regs->CR = (regs->CR & (CR_PSIZE_MASK | STM32F7X_SECTOR_MASK)) | ...
other like l4 make the opposite: clear only page mask (and keep any previous settings)
	regs->CR &= ~FLASH_CR_PNB_Msk;
It can be a choice of implementation to keep previous configuration or to restart from scratch at each erase, but in all cases Page/sector mask must be cleared.
And it would be better to harmonize behavior across all STM32 implementations.
Keep previous configuration seems better from my point of view.
This has been done for H7 in PR #31708.
Proposal is to make the same for all STM32 serie

^^ @erwango

In fact implementation is similar for all stm32 series, but there is on F4 and F7 some misleading definitions:
like STM32F7X_SECTOR_MASK = 0xFFFFFF07
which is opposite of CMSIS mask definition:  FLASH_CR_SNB_Msk = 0x000000F8
Nevertheless in case of F7 there is a bug, as in this case  it should be
(regs->CR & (CR_PSIZE_MASK & STM32F7X_SECTOR_MASK))


Enhancement -- include vector string with negative or invalid string

Consider for consistency returning the invalid vector string as part of the return from the API, similar to a valid score, but a null result in the score and severity string.

Would something like below work?
API will add an "error" key when incorrect vectors are supplied.
{"vector":"CVSS:/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:H/VA:N/SC:N/SI:N/SA:N",
"score":"error",
"severity":"error",
"error":"Error invalid vector, incorrect CVSS v4.0 prefix"}

That would be perfect, anything informative that returns the originating bad vector and a message confirming that it's invalid, in JSON format.


Migrate to composite action

This avoids dependency on the NodeJS runtime which should make maintenance a tick easier because you don't need to deal with EOL stuff.

You can see a test run here: https://github.com/thomaseizinger/rust-libp2p/pull/55


Program components' communication protocol

Program components (sensor, STM32s, display) to communicate via SPI/UART using CubeIDE to meet project's communication requirements.

Used a different protocol, but we have completed it


Cannot use VideoReader due to ffmpeg issue

Hey experts,
Recently I've been trying to use the torchvision.io.VideoReader API on my MacOS machine.
Description
At first, I was trying to import the API directly, but hitting this issue:
  File "/Users/sallysyw/workspace/vision/gallery/plot_video_api.py", line 36, in <module>
    video = torchvision.io.VideoReader(video_path, stream)
  File "/Users/sallysyw/workspace/vision/torchvision/io/__init__.py", line 104, in __init__
    raise RuntimeError(
RuntimeError: Not compiled with video_reader support, to enable video_reader support, please install ffmpeg (version 4.2 is currently supported) andbuild torchvision from source.

Then I realized that I need to manually install ffmpeg package to get this work.
Firstly I tried conda install:
conda install ffmpeg=4.2=h677a3f5_0

After this is done, I re-built the torchvision package with
MACOSX_DEPLOYMENT_TARGET=10.9 CC=clang CXX=clang++ python setup.py develop

Then I tried
import torchvision

this time I'm hitting a new error:
libc++abi: terminating with uncaught exception of type c10::Error: Type c10::tagged_capsule<vision::video::Video> could not be converted to any of the known types.
Exception raised from operator() at /Users/sallysyw/opt/anaconda3/lib/python3.8/site-packages/torch/include/ATen/core/jit_type.h:1606 (most recent call first):
frame #0: c10::Error::Error(c10::SourceLocation, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >) + 98 (0x102646e12 in libc10.dylib)
frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 106 (0x10264552a in libc10.dylib)
frame #2: c10::detail::getTypePtr_<c10::tagged_capsule<vision::video::Video> >::call()::'lambda'()::operator()() const + 263 (0x129f49497 in video_reader.so)
frame #3: c10::detail::getTypePtr_<c10::tagged_capsule<vision::video::Video> >::call() + 27 (0x129f492eb in video_reader.so)
frame #4: c10::detail::infer_schema::(anonymous namespace)::createArgumentVector(c10::ArrayRef<c10::detail::infer_schema::ArgumentDef>) + 216 (0x10e27c508 in libtorch_cpu.dylib)
frame #5: c10::detail::infer_schema::make_function_schema(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >&&, c10::ArrayRef<c10::detail::infer_schema::ArgumentDef>, c10::ArrayRef<c10::detail::infer_schema::ArgumentDef>) + 123 (0x10e27c2ab in libtorch_cpu.dylib)
frame #6: torch::jit::Function* torch::class_<vision::video::Video>::defineMethod<torch::class_<vision::video::Video>& torch::class_<vision::video::Video>::def<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(torch::detail::types<void, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::initializer_list<torch::arg>)::'lambda'(c10::tagged_capsule<vision::video::Video>, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >)>(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::initializer_list<torch::arg>) + 477 (0x129f4872d in video_reader.so)
frame #7: torch::class_<vision::video::Video>& torch::class_<vision::video::Video>::def<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >(torch::detail::types<void, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::initializer_list<torch::arg>) + 114 (0x129f35242 in video_reader.so)
frame #8: _GLOBAL__sub_I_video.cpp + 226 (0x129f5b202 in video_reader.so)
frame #9: 0x0 +<PHONE_NUMBER> (0x1029df6c7 in ???)
frame #10: 0x0 +<PHONE_NUMBER> (0x1029dfad2 in ???)
frame #11: 0x0 +<PHONE_NUMBER> (0x1029da4b6 in ???)
frame #12: 0x0 +<PHONE_NUMBER> (0x1029d826f in ???)
frame #13: 0x0 +<PHONE_NUMBER> (0x1029d8310 in ???)
frame #14: 0x0 +<PHONE_NUMBER> (0x1029c8a12 in ???)
frame #15: 0x0 +<PHONE_NUMBER> (0x1029d3aee in ???)
frame #16: dlopen_internal(char const*, int, void*) + 185 (0x7fff203edcb4 in libdyld.dylib)
frame #17: dlopen + 28 (0x7fff203dc09e in libdyld.dylib)
frame #18: py_dl_open + 135 (0x102303ca7 in _ctypes.cpython-38-darwin.so)
<omitting python frames>

[1]    216 abort      python

I also tried the following options:

Download ffmpeg-4.2.4.tar.xz on their website and build it manually
Uninstall the conda package and use brew to install ffmpeg again

However, neither of them solves the issue, I'm still getting the python frames error.
Can anyone help? Thanks a lot!
Environment
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py

Results:
Collecting environment information...
PyTorch version: 1.10.0.dev20210728
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: macOS 11.4 (x86_64)
GCC version: Could not collect
Clang version: 11.0.0 (clang-1<IP_ADDRESS>)
CMake version: Could not collect
Libc version: N/A

Python version: 3.8.8 (default, Apr 13 2021, 12:59:45)  [Clang 10.0.0 ] (64-bit runtime)
Python platform: macOS-10.16-x86_64-i386-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.20.1
[pip3] numpydoc==1.1.0
[pip3] pytorch-sphinx-theme==0.0.24
[pip3] torch==1.10.0.dev20210728
[pip3] torchvision==0.11.0a0+b29ed34
[conda] blas                      1.0                         mkl
[conda] mkl                       2021.2.0           hecd8cb5_269
[conda] mkl-service               2.3.0            py38h9ed2024_1
[conda] mkl_fft                   1.3.0            py38h4a7008c_2
[conda] mkl_random                1.2.1            py38hb2f4e1b_2
[conda] numpy                     1.20.1           py38hd6e1bb9_0
[conda] numpy-base                1.20.1           py38h585ceec_0
[conda] numpydoc                  1.1.0              pyhd3eb1b0_1
[conda] pytorch                   1.10.0.dev20210728         py3.8_0    pytorch-nightly
[conda] pytorch-sphinx-theme      0.0.24                    dev_0    <develop>
[conda] torch                     1.9.0                    pypi_0    pypi
[conda] torchvision               0.11.0a0+b29ed34           dev_0    <develop>

I'm having the same issue. I don't know how to fix it for now :/
With some versions of ffmpeg, I even get a sefault in ffmpeg:
(pt) ➜  vision git:(develop) ✗ conda list ffmpeg
# packages in environment at /Users/nicolashug/opt/miniconda3/envs/pt:
#
# Name                    Version                   Build  Channel
ffmpeg                    4.3                  h0a44026_0    pytorch

(pt) ➜  vision git:(develop) ✗ ffmpeg
dyld: Library not loaded: @rpath/libopenh264.5.dylib
  Referenced from: /Users/nicolashug/opt/miniconda3/envs/pt/lib/libavcodec.58.91.100.dylib
  Reason: image not found
[1]    1719 abort      ffmpeg

@NicolasHug for FFMPEG, 4.3 is known to have a segfault, that's why we're only supporting 4.2 for now. I'll try to get my hands on a mac to investigate @sallysyw 's issue today

One way to go around it is to install ffmpeg 4.4 (eg with brew or from source) and comment out the ffmpeg check part in the setup.py (l351-362). With that I can read videos flawlessly

@bjuncek thanks for looking into this, did you find anything interesting?
Perhaps this is @andfoy can help with as well?

Not really - Edgar is on vacation, but I've booked him for Thursday to go over this and make a well documented issue that we can hopefully take to Francisco, Ralf and the pytorch builder team.
Basically, the errors (that I understand so far are the following)
0. pyav from conda-forge doesn't necessarily play nicely with custom built ffmpeg's

we cannot package FFMPEG as-is due to licensing; @andfoy had a PR in builder where he packaged pytorch-specific version, that never got merged and is at this point stale if I'm not mistaken
custom ffmpeg might (and do) break some other dependencies (such as pyav) if not updated
on top of all that several ffmpeg builds have a bug where they segfault in codec allocation I think; this is an issue as default conda-forge and apt versions are still 4.3.

My workaround is to install 4.2.x from conda-forge and try to link everything against it manually. @vmoens 's suggestion worked for me on a mac when 4.4. was installed from brew. But it's not the neatest solution.

@andfoy had a PR in builder where he packaged pytorch-specific version

@bjuncek did you mean this https://github.com/pytorch/builder/pull/554? What I glean from the current repo is that custom builds for windows/mac may never return.

Hi;
I am having the same problem, when trying to work on some videos.This is what I get:
RuntimeError: Not compiled with video_reader support, to enable video_reader support, please install ffmpeg (version 4.2 is currently supported) and build torchvision from source.
I tried to install torchvision  and latest version of ffmpeg from the source. I am still getting the same error.

Hi @kilicsedat : ATM there are a few gotchas (for more detailed info check the setup.py).

Building on a mac with python=3.9 causes a crash so it is disabled at the moment
If any of the following libraries is not installed (which might, but shouldn't happen when you install FFMPEG from source), it will not build: "libavcodec", "libavformat", "libavutil", "libswresample", "libswscale"

What OS are you building it on?


Fix small error in Task docs

I was trying to set focus on an element and found some relevant docs; however, I noticed that there was a mistake/typo with a referenced type.

I've moved on.


Use destroy_all to remove test users and admins

This lets rake remove_test_users_and_admins work without error even if some
of the data has already been deleted manually or in a previous run of
rake remove_test_users_and_admins

Coverage remained the same at 99.52% when pulling 62e0593416c483192ea28b46ba977d14488f1925 on md5:safer-test-user-removal into 44603c3ba978e9290ae00a1b22c02b306a701052 on codeforamerica:master.

Good catch, thanks! Could you please also add some tests that make sure the task can be run multiple times and that it only deletes a subset of users, and not all users?

Do you have any examples of specs that test Rake tasks? I'm not sure off hand how I'd do that, though I suppose I could break out the code into its own simple library or add a method each to User and Admin and test those. What do you think?

This looks like a reasonable approach possibly: http://carlosplusplus.github.io/blog/2014/02/01/testing-rake-tasks-with-rspec/

Sorry, I went offline early last night. I've been using thoughtbot's shared context (referenced in the blog post you linked to). The one thing to pay attention to is that the filename, task name, and spec description title have to match. So, here's what I would do.
Define the shared context in spec/support/shared_contexts/rake.rb:
require 'rake'

shared_context 'rake' do
  let(:rake)      { Rake::Application.new }
  let(:task_name) { self.class.top_level_description }
  let(:task_path) { "lib/tasks/#{task_name.split(':').first}" }
  subject         { rake[task_name] }

  def loaded_files_excluding_current_rake_file
    $LOADED_FEATURES.reject { |file| file == Rails.root.join("#{task_path}.rake").to_s }
  end

  before do
    Rake.application = rake
    Rake.application.rake_require(task_path, [Rails.root.to_s], loaded_files_excluding_current_rake_file)

    Rake::Task.define_task(:environment)
  end
end

Rename the task filename from remove_users.rake to remove_test_users_and_admins.rake.
Create the spec in spec/lib/tasks/remove_test_users_and_admins_rake_spec.rb. Here's an example that shows how to test user removal, and you can add the admin tests:
require 'rails_helper'

describe 'remove_test_users_and_admins' do
  include_context 'rake'

  before do
    create(:user)
    create(:admin)
    allow_any_instance_of(IO).to receive(:puts)
    Rails.application.load_seed
  end

  its(:prerequisites) { should include('environment') }

  it 'only removes 2 users' do
    subject.invoke

    expect(User.count).to eq 1
  end

  it 'only removes the demo users' do
    subject.invoke

    expect(User.pluck(:email)).to eq<EMAIL_ADDRESS>  end

  it 'can be run multiple times' do
    subject.invoke
    subject.reenable
    subject.invoke

    expect(User.count).to eq 1
  end
end

I pushed up a couple commits that to add your example (I used --author since I just used your code verbatim). I'm seeing this error when I run the spec:
     Failure/Error: Unable to find matching line from backtrace
     Bullet::Notification::UnoptimizedQueryError:
       user: mike
       N+1 Query detected
         User => [:api_applications]
         Add to your finder: :includes => [:api_applications]
       N+1 Query method call stack
         /Users/mike/Code/ohana-api/lib/tasks/remove_test_users_and_admins.rake:2:in `block in <top (required)>'
         /Users/mike/Code/ohana-api/spec/lib/tasks/remove_test_users_and_admins_rake_spec.rb:28:in `block (2 levels) in <top (required)>'

       /Users/mike/Code/ohana-api/lib/tasks/remove_test_users_and_admins.rake:2:in `block in <top (required)>'
       /Users/mike/Code/ohana-api/spec/lib/tasks/remove_test_users_and_admins_rake_spec.rb:28:in `block (2 levels) in <top (required)>'
     # ./spec/support/bullet.rb:8:in `block (2 levels) in <top (required)>'

Looks like bullet may not play well with #pluck.

Would it make sense to add this?
    Bullet.add_whitelist(
      type: :n_plus_one_query, class_name: 'User', association: : api_applications
    )

I opened this issue to ask about support for #pluck: https://github.com/flyerhzm/bullet/issues/226

Coverage decreased (-0.12%) to 99.41% when pulling a7997fbf876cc73e7325ffadbcbad15e965f69a3 on md5:safer-test-user-removal into 44603c3ba978e9290ae00a1b22c02b306a701052 on codeforamerica:master.

I think that might actually be a legitimate N+1 query since destroy_all calls the dependent callbacks to destroy the User's api_applications. Adding the includes as suggested by bullet should fix the issue:
User.includes(:api_applications).destroy_all

Still need to add the Admin tests here, but I wanted to push and see if this fixed Hound and Travis's failures.

Coverage decreased (-0.12%) to 99.41% when pulling e2fdfdf5538ea1e2c4524aedbae59e59085f90b3 on md5:safer-test-user-removal into 44603c3ba978e9290ae00a1b22c02b306a701052 on codeforamerica:master.

Coverage decreased (-0.12%) to 99.41% when pulling dd68408c9fddbc189a789be31e4586c039a817d4 on md5:safer-test-user-removal into 44603c3ba978e9290ae00a1b22c02b306a701052 on codeforamerica:master.

LGTM. No need to update the admin email. It's not a real email address. I think a squash is all that's left.

Squashed. I left the .rubocop.yml change in a separate commit.

It doesn't look like Coveralls is actually going to report for the latest build. Sometimes I see a completed status on the Coveralls.io page when the notification back to GitHub still takes a couple hours to arrive, but in this case it looks like the status on the Coveralls.io page is incomplete as well.

Thanks!

:metal:


Anyway to prevent send message after pressing "Enter" key?

I want my message line break on enter press rather than shift + enter..
How do I prevent default behaviour of sending messages on enter pressed!!!

@beevekmgr How do you want to send messages? Only using send button?

Um... yes actually "enter" key is use to switch language in japanese . which is causing a problem.

@beevekmgr Ok, I will add a property to disable send on enter

@VincentRoest, thank you for your awesome work!
I want to merge your PR, but the commit message needs to meet conventional commit requirements.
Please see my PR comment for the details.

@supersnager  still waiting this to be merged...

:tada: This issue has been resolved in version 1.8.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

Sorry guys for having to wait. I forgot that that commit message can be changed before merge :)


bugfix:OSIS-14 Query S3 Credentials not returning cd_tenant_id

Hello saitharunthodupunuru,
My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.
Status report is not available.

Incorrect fix version
The Fix Version/s in issue OSIS-13 contains:

None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

1.0.0

Please check the Fix Version/s of OSIS-13, or the target
branch of this pull request.

Codecov Report

Merging #64 (bd85bb4) into development/1.0 (10cc516) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##             development/1.0      #64      +/-   ##
=====================================================
+ Coverage              86.62%   86.66%   +0.03%
- Complexity               235      236       +1
=====================================================
  Files                     16       16
  Lines                   1062     1065       +3
  Branches                  77       77
=====================================================
+ Hits                     920      923       +3
  Misses                    85       85
  Partials                  57       57

Impacted Files
Coverage Δ

...lity/osis/service/impl/ScalityOsisServiceImpl.java
88.94% <100.00%> (+0.02%)
:arrow_up:

.../com/scality/osis/utils/ScalityModelConverter.java
95.27% <100.00%> (+0.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cc516...bd85bb4. Read the comment docs.

Waiting for approval
The following approvals are needed before I can proceed with the merge:

the author

2 peers

/approve

In the queue
The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.
The changeset will be merged in:

:heavy_check_mark: development/1.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.
IMPORTANT
Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.
The following options are set: approve

I have successfully merged the changeset of this pull request
into targetted development branches:

:heavy_check_mark: development/1.0

Please check the status of the associated issue OSIS-13.
Goodbye saitharunthodupunuru.


[2034] Review DR workflows

Context
Make adjustments suggested during the DR test
Changes proposed in this pull request
Include a summary of the change.
Guidance to review
Include any useful information needed to review this change.
Include any dependencies that are required for this change.
Checklist

[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

 TRS DR tests