Use standard Redux dispatch to replace most connectWithActions.

A couple remarks:

The last commit exists because I forgot to check my commits with prettier. After I had commited everything prettier complained about 7 files. Rebasing felt like too much of a pain, so I hope it's okay this time to have a fix-the-broken-style-of-the-previous-commits commit.

There were several typing issues popping up. Unfortunately, they all seemed not straightforward to fix, so I'd like to discuss them before digging too deep into them. I'll list them in a new comment.

Are you not using a prettier plugin inside your IDE?

Some thoughts about type issues that came up:

In RN, several components have anonPress() handler. onPress() takes a function f and calls f "on press". I checked all the different onPress docs for RN components, and for all of them the return value of f doesn't play any role. Yet, we have a discrepancy in our own type definitions about that return type: In one place, it's   onPress: () => void, in another onPress: () => void | Promise<any> and in a third onPress: () => any.
I think the two alternatives worthy to discuss are onPress: () => any and onPress: () => void. The first allows constructs like

            onPress={() => dispatch(navigateToAddNewAccount(''))}

The second requires this to be
            onPress={() => {
              dispatch(navigateToAddNewAccount(''));
            }}

I prefer the second option, since it makes it clear that it's the content of the function that matters, and not the return type.

DiagnosticsScreen seems to contain dead code. It has a prop experimentalFeaturesEnabled that's  used nowhere except in its function handleExperimentalChange, which isn't used anywhere. It looks like we should either remove this code, or finish the feature that was intended. Currently, this throws a type error because experimentalFeaturesEnabled is not specified when the component is created.

isStreamNarrow(narrow: Narrow) and potentially other functions in narrow.js are sometimes called with undefined, even though narrow: Narrow isn't a maybe type. I noticed this when uncommenting the "FlowFixMe"s in Chat.js. I'm not sure if the issue here is that narrow is undefined or that we don't use a maybe type.

You can import actions from the actions.js file which as
import { someAction, anotherAction } form '../actions';
thus not having multiple imports for multiple action files.

Added a commit for just importing ../actions instead of individual action files. Also, I remembered one other observation I made yesterday:
The pattern of changes in these commits is mostly  straightforward: Use connect instead of connectWithActions and then just directly import the actions you wanna use. This works fine if the file is self-contained, that is, when it doesn't pass down the actions to other files. When it does, however, there are two scenarios:

The first scenario is the https://github.com/zulip/zulip-mobile/pull/2648/commits/62d6d6db65a0e0bd95b2d7d7aa097c890270893f . Here, actions are passed down from AppEventHandlers to notifications.*.js. After changing connectWithActions to connect, we cannot pass down the actions anymore. In this case, this is fine because notifications.*.js is a "dead-end". It doesn't further pass down actions and we can just directly import actions in it as well.

The second scenario is a file like MessageList.js. I tried changing it from connectWithActions to connect, without success. This is because MessageList.js passes down its props (and with them its actinos) down a deep code path executeActionSheetAction, which then spreads out and sends the actions to further places, where they'll be eventually used. It'd be possible to resolve this with the same pattern as in the first scenario, but it'd require many more files to be changed. I'm not sure if we want to follow that code pattern, so asking here.

@roberthoenig I think it is fine to leave the less straightforward pieces for later refactor. The ones you are pointing too are not as trivial indeed.

Thanks @roberthoenig ! Just merged all of these that don't contain $FlowFixMe; we don't have to fix the type errors immediately (as they were presumably always there, we're just exposing them now), but I'd like to have a few words of explanation in any "fixme" comments we merge.
I did go ahead and rebase your prettier fixes, and consolidation of imports, into the respective commits. The key tool that I find makes that fairly easy is to commit each affected file as a separate, temporary commit (with a terse commit message that's just enough to understand for the next minute or two -- a typical command I just ran is git ci src/diagnostics/ -m 'prettier diagn screen', where git ci is an alias for commit); then git rebase -i to sort them to the right spot, and f/fixup there to fix up the respective commits with no further ado.
I pushed the rebase-squashed version of the whole branch to your PR branch, including the commits I didn't yet merge; so you might find it handy to pick up from there.
(I'll reply to your detailed comments and questions in a separate comment.)

onPress: () => void

I agree this seems best given the function's return value will be ignored. Thanks for making that study of the RN docs!

DiagnosticsScreen seems to contain dead code. It has a prop experimentalFeaturesEnabled that's used nowhere

Looks like this was last used to control the webview message list; and it was replaced for that purpose with 50cd02f, last October. So let's just cut this. Good catch!
I'd want to separate the commit that cuts it from the one that does the dispatch refactor; they can go in either order.

isStreamNarrow(narrow: Narrow) and potentially other functions in narrow.js are sometimes called with undefined, even though narrow: Narrow isn't a maybe type.

Yeah -- my pilot commit for this refactor ran into a case of this too, as you can see in Chat.js. The conclusion I wrote in that comment is that we probably really do need a real Narrow there, and not undefined. Investigation needed, though.

The first scenario is the 62d6d6d . Here, actions are passed down from AppEventHandlers to notifications..js. After changing connectWithActions to connect, we cannot pass down the actions anymore. In this case, this is fine because notifications..js is a "dead-end". It doesn't further pass down actions and we can just directly import actions in it as well.

Yeah, I'm pretty happy with this one. (Already merged it, in fact.)

MessageList.js passes down its props (and with them its actinos) down a deep code path executeActionSheetAction, which then spreads out and sends the actions to further places, where they'll be eventually used.

Hmm, interesting. Looking at that code, I don't think I'm a fan of that arrangement -- passing the whole props down through several layers like that feels wrong, like the abstractions that are being used don't reflect what the code is really doing. That's probably not something to fix within this PR, though.
As a matter of strategy, I'll echo Boris that it's a fine plan to just leave this one for later. Some kinds of refactors depend on being carried out everywhere before they're useful, and for those it's important to do (or at least fully understand) the hard cases early; but this one is helpful independently for each place we do it, so it works great to sweep through the easier cases first and come back to the few hard ones at the end.
Looking just a bit closer at this code, I think -- I haven't confirmed thoroughly -- all those functions that executeActionSheetAction passes the props to are in that same file messageActionSheet.js. And just a few of them actually use actions, even. So it may end up being not that much work to go and replace actions with dispatch throughout, just as you've been doing elsewhere.

Updated:

Added comments for FlowFixMes
Added commit to remove dead code in DiagnosticsScreen.js

Some of the comments are quite long I figure this shouldn't be a big problem, however, since we intend to fix these type errors timely?

Updated:

changed all remaining easy-to-chagnge connectWithAction calls.
Added commit to use connect() over connect(null) consistently.

Remaining calls to connectWithActions:

connectWithActions.js. Called by connectWithActionsPreserveOnBack. Once we remove the other connectWithAction calls, we can remove this one.

MessageList.js. Passes actions down to other files, see comments above. Feasible to change, will just require some more work.

SearchMessagesCard.js. Passes actions down to MessageList.js. Can change once MessageList is changed.

6 calls to connectWithActionsPreserverOnBack. connectWithActionsPreserverOnBack doesn't do any magic; It just calls connectWithActions with an additional mapDispatchToProps argument { areStatesEqual: isStateGoingBack } that makes state changes more efficient. We can get rid of it just like with connectWithActions, except that we need to add { areStatesEqual: isStateGoingBack } to every connect call.

Thanks @roberthoenig ! Just merged all of these except the one on ActivityText, which I want to look at a bit closer related to the review thread above. Excited to see this nearly done :-D
Long comments are totally fine. In one commit, I did edit the comments a bit -- they ended up shorter, but the main thing I wanted to change was just to get the explanation right there on the same line as the $FlowFixMe:
-  // We have two Flow errors here because we are accessing props.narrow yet
-  // Props has no `narrow` property.
-  // Ignore the next line because prettier messes up the ternary below such
-  // that the linter complains.
+  // Prettier messes up the ternary so the linter complains.
   // prettier-ignore
   backgroundColor: !props.backgroundColor
-    // $FlowFixMe
+    // $FlowFixMe: Props has no `narrow` property
     ? getTitleBackgroundColor(props.narrow)(state)
     : props.backgroundColor,
-  // $FlowFixMe
+  // $FlowFixMe: Props has no `narrow` property
   textColor: getTitleTextColor(props.narrow)(state),

Where the explanation is longer, that's fine too; just want it as immediately next to the issue as possible.
(Sadly Prettier seems to get confused if the prettier-ignore comment adds any explanation at all -- I tried a couple of ways.)

Merged! I added a commit on top with the resolution to that puzzling presences type issue. Thanks again.

Cool, closing this then. WIll open a new PR for the remaining cases.

Huh, just noticed there is no close button ^^. Is that because it has been merged?


Create getSubscription endpoint of the subscription module

Description
As a part of #50 , we should implement an endpoint that retrieves the subscription NFTs stored in the SubscriptionSubstore.
Request

Parameter
Type
Validation
Default
Comment

subscriptionID
bytes
Data type validation
(empty)
-

Response
OK
{
  "price": 1,
  "maxMembers": 5,
  "members": ["lskyg9ujmpkbn7ex96ejedhfrkj6avryn5nwgngbp"] // Array of addresses,
  "consumable": 1,
  "streams": 0,
 "creatorAddress": "lskyg9ujmpkbn7ex96ejedhfrkj6avryn5nwgngbp" // A Lisk 32 address
}

Not found
{
  "error": true,
  "message": "Subscription <collectionID> not found."
}

Bad request
{
  "error": true,
  "message": "Parameter subscriptionID is required."
}

Resolved by #73


Generate a "fat" jar for the CCUD Maven extension

In addition to adding the extension to the extensions.xml file, the CCUD Maven
extension can be used by putting it in the MAVEN_HOME/lib/ext directory, or by
referencing the jar on the command line by setting the maven.ext.class.path
system property when invoking Maven.
Unfortunately, if the extension is used via one of these two additonal methods,
then Maven is unable to resolve any dependencies of the CCUD Maven extension.
That means the extension could fail with a ClassDefNotFound error.
Users could add all of the extensions dependencies to their MAVEN_HOME/lib
folder, but we can make it easier on users if we publish a jar that contains
all of the extension's dependencies (which is currently only Groovy).

This seems like a good idea but this makes the extension a bit more heavyweight. I am unsure of the trade-off here of which one is best.

This seems like a good idea but this makes the extension a bit more heavyweight.

That is true, but I think the usability improvement (not having to remember to copy the dependencies into MAVEN_HOME/lib) is probably worth it. It also reduces what we need to document/explain to users. And it makes it easier to maintain our internal functional tests for the extension.

@marcphilipp WDYT?

While doing that I noticed a warning that we should solve by excluding META-INF/MANIFEST.MF from the Groovy JAR in the Shade plugin's configuration:

This is done.

We will include this in the next release of the extension.


Release 5.0.a1

I'll merge this after some of the open PRs are merged, and cut the first alpha release of 5.x to assist in development of gollum v5 .

👍


Delete the marker file (_$folder$) when removing a directory

When calling remove() on an S3Target pointing to a "directory", all files inside the directory are removed as expected. But when using Hadoop S3 Native FileSystem to store files in S3, each "directory" comes with a marker with the suffix _$folder$. This marker was not deleted by remove() causing bugs such as letting Hadoop think that the directory still exists when it does not. This patch fixes this.

Maybe add a test case? :)

@Tarrasch Just added a additional check in test_remove()

Merge the commits into one. They belong to the same logical sense.
It would also be great if you know somebody who knows S3 that can review this. Maybe you can look in the blame lines?

@Tarrasch @ddaniels888 Could you have a look at this please?

I'll merge once there's a +1 from somebody knowing s3.

:+1: looks good to me.


v1.2 created a histogram

Got through the histogram. Need to fix up sanitizing and clean up also the formatting is little off.

Looks like you hit all the main points and got it to work.
My big critique is that code is very hard to read when it is scattered with generic-sounding variable and method names. Your job as a programmer is about creating something which another human can reason about, and it is hard to reason about k and v.
That's a bit like giving someone directions to your house by saying "get on the train, wait until you get to the station, then walk off the train, go outside, walk on the sidewalk, and when you get to my house knock on the door". It's not easy to write good variable and method names, but it is important.
Also, why didn't you use the histogram() method that you wrote? Looks like you have two alternate ways to print the information.


https://github.com/independentcod/RDPWraper

Instructions on how to install are included.
If you are looking for another version the trick is the following:
search in this repo the Windows version and look in Issues then find the ini infos of your version and add it to the INI in the archive
on my Github, then install it.
Another option is to fork my repo here:
https://github.com/independentcod/RDPWraper
and add your info directly in the ini file then download and install it
(I'd prefer it that way)
Good luck and have a NICE DAY!
Remi

Not an RDPWrapper issue


Write in the documentation about configuring keycloak

I was unable to authenticate after configuring the project, an error about incorrect password or username was always returned. After some debugging investigations into the library, I found the following exception in from_credentials in Token.
b'{"error":"unauthorized_client","error_description":"Client not permitted for direct access grants"}'
To resolve this issue, I had to configure my keycloak client to enable direct access.

It would be interesting to see in the official documentation how the keycloak client must be configured for the library to work correctly.

Thanks for the effort of opening a ticket, but this is won't be resolved given the project's limited resources. The initial owners have moved on, and while I still use and continue to improve it, I haven't published the changes. The direction has changed slightly to focus on async middleware but requires clean up before it can be published.


Project deprecated?

http://www.clangsharp.org/
got 404 error
and seems project has no any update long times(seveal months)
https://github.com/dotnet/llilc seems deprecated too.
see kotlin native. progress is very fast.
hope this project wont be deprecated and do more faster....

Personally I have been busy with university and so I haven't contributed to my branch (OOAPI) for over a year. But I plan to pick it up immediately as soon as my workload decreases, since I need LLVM bindings for a project I'm already working on. So, at least as far as I'm concerned, it's not deprecated — but maybe we do need more contributors. =)

I was wondering about the status, too. So instead, I've been working on a forked copy of the LLVM bindings library from SharpLang, which uses SWIG. The API is in Net Standard 1.1 and links with Net Standard/Core/Framework. But, it is limited by the built targets for LLVM 4.0, although I do have native libraries for Windows 32 and 64-bit, Ubuntu, and I'm working on the armeabi/x86 Android targets now. LLILC is not a C# API for LLVM, rather a LLVM backend for CIL. It's completely in C++, and it is not very easy to read. If you're interested in a LLVM backend for CIL, Mono Mini, also in C++, also a forked LLVM, is very easy to read. I saw this week someone releasing a GPU backend for CIL on NuGet, but there is no code in any of the repositories for the project.

I thought Llvmsharp was the official project for Microsoft employees.
to Microsoft employees as the main source of contribution.
ok.I wish I could help, but my technical is too slag. Just like C #.

Can this be activated again along with llilc?

I personally intend to continue working on LLVMSharp soon. We can't speak on behalf of LLILC — it's an entirely different project.

So when will this be updated...

Not deprecated, we're targeting end of month having it all updated to LLVM 5.0 along with using the new VS 2017 .NET Core tooling.

Time to party!!!

Can I just read the llvm cookbook (which uses C++) while getting started with this?
I'm working on a compiler recently (in C#, targeting llvm). Hope this official LLVM binding will work. 😃 Cheers!

When will the LLVM-5 support be available?
When will the website reborn?
(Sorry for too many questions... 😜

Can anyone help @mjsabby

When will the LLVM-5 support be available?
When will the website reborn?
Will you change the old APIs? If so, how much APIs will be changed?
(Sorry for too many questions... :stuck_out_tongue_winking_eye:

@ice1000 checkout https://nuget.org/packages/LLVMSharp -- LLVM-5 supoprt is available.
The website redirects here, since most of the information is here.
APIs are determined by the LLVM project, and we just make sure to keep them up-to-date.

Nice! Thank you @mjsabby
I should say this project is awesome! You guys are really doing something cool! :smiley:

The project is not deprecated. Closing this issue.


There are problems with config of your thermostat.

Hi! Since a few days i am seeing this notification in the notifications panel:

I think i didn't do anything special in particular, am using your plugin a few months whiteout any issues. So maybe something changed in a recent version that broke something?
I have a Buderus installation with KM200 module (RC310). Scan log attached.
bosch_scan.json.zip
In HASS logs i'm seeing this
Logger: bosch_thermostat_client.helper
Source: /usr/local/lib/python3.9/site-packages/bosch_thermostat_client/helper.py:266
First occurred: January 22, 2022, 8:27:35 AM (1006 occurrences)
Last logged: 2:47:56 AM

    Can't update data for Current Summer Winter Mode. Trying uri: /heatingCircuits/hc2/currentSuWiMode. Error message: URI /heatingCircuits/hc2/currentSuWiMode doesn not exist: 404, message='Not Found', url=URL('http://<IP_ADDRESS>/heatingCircuits/hc2/currentSuWiMode')
    Can't update data for Health status. Trying uri: /system/healthStatus. Error message: Connection timed out for /system/healthStatus.
    Can't update data for Actual Power. Trying uri: /heatSources/actualPower. Error message: Connection timed out for /heatSources/actualPower.
    Can't update data for Actual Supply temperature. Trying uri: /system/appliance/actualSupplyTemperature. Error message: Connection timed out for /system/appliance/actualSupplyTemperature.
    Can't update data for Current Summer Winter Mode. Trying uri: /heatingCircuits/hc1/currentSuWiMode. Error message: Connection timed out for /heatingCircuits/hc1/currentSuWiMode.

Hope the this information helps?

What component version do you use? 0.17.3 was provided to handle the newest firmware

I just discovered that i was still in 0.16.8. Updated it now and the notification is gone. Was convinced HACS did auto updates :-)
Stupid! sorry ;-)


Different behavior with and without --sysbuild

I am porting my application from zephyr 3.5 to 3.7 and I have updated the boards structure according to the new standards. My project folder structure looks something like the following:
<home>
├── boards/plank
|	├── board.yml
|	├── plank_0_5_0_defconfig
|	├── plank_0_5_0.overlay
|	├── plank.dts
|	├── plank.yml
|	├── Kconfig.defconfig
|	├── Kconfig.plank
|	└── plank_defconfig
|
├── app
	├── CMakeLists.txt
	├── prj.conf
	├── sysbuild.conf
	└── sysbuild
    		└── mcuboot.conf

I have revisions for my board and since it allows to add configuration linked to boards on the boards folder, I have done so by moving some config that I had previously in prj.conf to plank_defconfig and plank_0_5_0_defconfig.
If I run west build -p always -b<EMAIL_ADDRESS>\app it works perfectly, even if I select other revisions.
But my problem starts when I try running it with sysbuild. If I run west build -p always -b<EMAIL_ADDRESS>\app  --sysbuild the compilation works for mcuboot, but fails for my application because the Kconfigs get messed up. It complains that s dependencies for configs in the board folder are missing (this dependencies are defined in the prj.conf).
Therefore my question is, what is the right procedure to use sysbuild while having board revisions and sub-configs defined at boards folder?

The board folder like that only works for applications, not sysbuild (since sysbuild itself is actually an application), you would need to add your board root in a module file e.g. see example application here https://github.com/zephyrproject-rtos/example-application/blob/main/zephyr/module.yml#L16

Hello @nordicjm, thanks for the fast answer.
Although I already have my board as a module imported by west and in the app module.yml I have the config as following, since my boards modules is 2 levels above the app:

build:
  settings:
    board_root: ..
    dts_root: ..

The dts and overlay it can find, it just can not link both prj.conf and board specific configs (plank_0_5_0_defconfig) to the final configs at the same time.

the only place a module.yml file can go is zephyr/module.yml from the root directory of the git repo, and it needs to be either the manifest repo itself or a module referenced in a west manifest

Yes, I have the module.yml inside a zephyr folder for the main project and on my modules.

Hmm, now I noticed I don't have it on the boards module because I point to it in the CMakeLists. Should I have a zephyr/module.yml also in my boards folder?

it should be in your boards repo yes, since the folder has to be named boards for the build system to find it and having a boards folder inside of a boards folder isn't ideal, you should have this in your board folder zephyr/module.yml file:
``

Thanks for the tip, I did it and I was able to remove an include in my CMakeLists. But I still have my initial problem.
An example, I have CONFIG_SENSOR=y in my prj.conf file and in my boards module I have my sensors enabled on the plank_defconfig (e.g. CONFIG_SHT3XD=y).
With normal application it builds fine, but with sysbuild it does not see CONFIG_SENSOR=y when including CONFIG_SHT3XD=y
warning: SHT3XD (defined at drivers/sensor/sensirion/sht3xd/Kconfig:6) was assigned the value 'y'
but got the value 'n'. Check these unsatisfied dependencies: SENSOR (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_SHT3XD and/or look up SHT3XD in the
menuconfig/guiconfig interface. The Application Development Primer, Setting Configuration Values,
and Kconfig - Tips and Best Practices sections of the manual might be helpful too.

Although, if I look in the autoconf.h, it is there:

Aaaa, now I notice something, the warning is while building the mcuboot, where the prj.conf is not included, but the plank_defconfig (I guess), generating the dependency error, even dough I don't need this on the mcuboot.

So it turns out that the dependency warning is only for the mcuboot build, and does not really affect it. My real problem is that while sysbuild builds the app my own modules are not finding the CONFIGs definitions

But CONFIG_SENSOR_LOG_LEVEL is present on the app/autoconf.h, so it looks the module is not including this definitions

Having a sensor enabled in a board defconfig is frankly wrong, if a project needs it, the project should enable it in the prj.conf (or boards/<board>.conf)


HAWQ-376. Fixed QE core dump at HdfsCloseFile() when run stress test …

…with COPY
The root cause of this defect is:
When the master got some error, it will send signal SIGABRT to all segments and then rollback all works done by all segments. If the segment node haven't finished processing SIGABRT before the master finishing rollback, all segfile created at this segment is deleted at master node in fact. So it will report warning to close/delete that hdfs file. We should clean up hdfs file cache before calling HdfsCloseFile(), so that we will skip second call of HdfsCloseFile() at ShutdownPostgres().

looks good to me. +1

LGTM. +1


Token issues with the AADv1 sample bot

Greetings,
I've been following an article that talks about adding authentication to a bot and how to set up an application and a bot so that I may be able to use some of the tasks with MS Graph
Link here
The bot has 3 simple tasks:

recents - checks any unread email in the last 30 mins
send - sends email on your behalf
me - shows your name and who you report to if any

When i write "recents", the bot will ask me to sign in using an oauth card. I sign in and then get a 6 digit magic number. I copy/paste it to the chatbot and it then validates me.
The problem happens when I write "recents" again, the bot prompts me to sign in again. It doesn't cache the token as it should or at least I expect it to...should which is to recognize me.
Is there something missing from that article?  I am using AADv1 to test authentication link

I have the same problem. But I even cant get magic number. the login in window just closed automatically.

@xiaolangxyz , did you enable authentication in the emulator?

@Rykimaruh No. Just waiting for someone who can help.

Thank you for reporting this, I am currently troubleshooting this walkthrough, I will update you when I have more information.

Ok, I have this working and am seeing the same behavior as you are.  This may be intentional behavior, I am not sure.  I will update you when I have more information.

@Rykimaruh we just pushed a fix and caching the token should be enabled now!  Please try again and let us know your results.

@Rykimaruh this is working for you now correct?

@JasonSowers , yes! thank you very much!
before wrapping all of this up, do you have any idea or information about dealing with authentication behind a corporate network that uses proxy and firewall?
I noticed that this works perfect in wifi, however when i connect to my corporate network that has a proxy it denies any attempts. We have Microsoft whitelisted, but not sure if there are certificates that need to be added or what.

There is currently a bug in Webchat that the identity team is looking into.

@JasonSowers , thanks for the update!

Closing this as it seems resolved please open a new issue if you experience more problems


Implement Singleton Pattern for Dialects and Refine Dialect Factory Methods

Type of PR

[ ] BUG
[ ] FEAT
[x] MAINT
[ ] DOC

This PR:

Implements the singleton pattern for our dialects.
Migrates our dialect factories away from using a lookup to using looking up subclass attributes.

New factory pattern - https://github.com/moj-analytical-services/splink/pull/1755#issuecomment-1822392832.
SplinkDialect singletons summary:

There can only be one instance of each dialect in existence within a python instance - i.e we pass the memory address around. As these classes are tiny already, this makes very little difference... but still.
The _DialectLookup class enforces uniqueness - we can only have one mapping to DuckDBDialect, for example.

SplinkDialect could alternatively be a frozen dataclass here, which would make it immutable (if that is something we desire).

Looks good to me - let's check @ADBond 's ok with this too before merging

Like the ideas here, and think the singleton pattern for the various SplinkDialects makes sense.
I agree that it would be nice to improve the way we do the string lookup - I actually had a slightly different idea on that, which I bring up as I think there are potentially a couple of advantages. This is a sketch of it for the db-api (this version returns the class rather than an instance, but that is not necessary here). This means that we don't need a separate lookup, and the data is stored on each subclass, which I think maybe makes the code a little cleaner. Also in terms of a practical advantage, this allows users to define their own SplinkDialect subclass and have the factory method work immediately, without needing to hack our private _DialectLookup.
Happy if either of you disagree on this - think the enum solution works fine also

Interesting - i think the two advantages of your approach are pretty compelling

Love it! Far cleaner and one less lookup for us to avoid updating. More than happy for @ADBond to implement that as our de facto factory method of choice.
Also yes, second what Robin said about not knowing this was possible. More python voodoo to play around with at a later date.

@ThomasHepworth is it okay to push implementation directly to this branch?

@ADBond - sorry, I was going to say in our slack chat to push your changes directly on here, but a delivery got in my way.

Have added that change now - included some additional tests to check that the behaviour seems sensible, which required a bit of fiddling to ensure that they are sufficiently 'forgetful', which I think now works without being too heavy-handed or needing to hack the implementation directly.
Let me know any thoughts or if anything is unclear!

Yeah - go ahead - sorry missed this being updated

@ADBond do you mind resolving the conflict?


Re #2113: disable 2D MPR when datasets have  multiple slices for the same ImagePositionPatient

Fix for https://github.com/OHIF/Viewers/issues/2113

@andrebot @igoroctaviano when you have time could you please review? Thanks


Have a less jargon-y intro/concepts page

Right now, the concepts section of the website assumes a lot of familiarity with network protocols and their behaviors. While it's fine to assume some things, it would be more inclusive to start the intro/concepts section with something more universally accessible. While MetalLB aims to be somewhat magical when it works, we should offer a gentle introduction to the inner workings to people who are interested.

If possible consider altering the slogan;
MetalLB is a load-balancer implementation for bare metal Kubernetes clusters, using standard routing protocols.

I had a hard time countering arguments like; "We are using VMs and don't want a load-balancer".
I had to explain it works perfecly fine on a VM and it isn't really a load-balancer.


Cuda restriction

Build the restriction matrix given the eigenvectors.

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   88.67%   88.67%
=======================================
  Files          11       11
  Lines         512      512
=======================================
  Hits          454      454
  Misses         58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c774ed...62f0abd. Read the comment docs.


WeatherMap OverLib - cacti_graph_id [UNKNOWN]

Having problems with this Weathermap for Cacti 1.x

It's not resolving {link:this:cacti_graph_id} - instead I get [UNKNOWN]  - for the graph-ids.
================================================================
Graph OverLib Mouse Hover shows:
Link
https://IP-ADDRESS/cacti/graph.php?local_graph_id=[UNKNOWN]
Images
https:///IP-ADDRESS/cacti/graph_image.php?local_graph_id=[UNKNOWN]&rra_id=0&graph_height=125&graph_width=400&random=35352
https://IP-ADDRESS/cacti/graph_image.php?local_graph_id=[UNKNOWN]&rra_id=0&graph_height=125&graph_width=400&random=17813
===WeatherMap Global link configuration====================================
SET rrd_use_poller_output 1
TEMPLATE-only LINKs:
LINK DEFAULT
INFOURL {map:cacti_url}/graph.php?local_graph_id={link:this:cacti_graph_id}
OVERLIBGRAPH {map:cacti_url}/graph_image.php?local_graph_id={link:this:cacti_graph_id}&rra_id=0
BWLABEL bits
WIDTH 4
BWFONT 3
SET cacti_use_ifspeed 1
==========================================
Using the following versions:
[viewed from changelogs]
Cacti - 1.2.22
cacti-spine-1.2.24
Weathermap - 1.1
==images=======================================

Was this working before?

Hallo @TheWitness
Yes, I would be willing to do a Zoom Call, my Timezone is +3 GMT.
Mayhaps when you see this message - we can agree on the appropriate time and you can send a link.

Are you using the latest develop?  GMT+3 is going to be hard for me tomorrow as I have some early morning meeting.  Thursday morning my time EST (GMT+5) will work out.  I'll look for your Email.

I am using the following versions .
Are they compatible? Where can I get the latest develop?
At one point, I resorted to downloading individual php pages from this fork to update the ones in my server with latest files, but the error persisted.
+5GMT is difference of only 2 hours, that is workable, share zoom link day before when you are ready.
[viewed from changelogs]
Cacti - 1.2.22
cacti-spine-1.2.24
Weathermap - 1.1

Sorry I tied to type -5 and somehow my fingers let me down.  We are 8 hours apart.  How about Saturday in my morning (EST)?

I have mainly usage questions so that I can verify the current logic to ensure the process is working.  Make sure you are on the latest develop too.

So, mainly, what column is the column in the config file represents the SNMP index?

@HerrDrSt, I'm here in my office now if you read this and have a few minutes.  We can get this issue resolved.

Hallo @@.*** @.***>
Sorry, I had a rushed weekend.
When you wrote your email below - it was 20:30h here - which was 12:30pm on
your side.
Maybe we need to coordinate a specific time so that I can set an alarm to
come online.
BR/
S.N
On Sat, Mar 23, 2024, 20:33 TheWitness @.***> wrote:

@HerrDrSt https://github.com/HerrDrSt, I'm here in my office now if you
read this and have a few minutes. We can get this issue resolved.
—
Reply to this email directly, view it on GitHub
https://github.com/Cacti/plugin_weathermap/issues/142#issuecomment-2016555616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG7WJ4OEMJB2YHGKVLJYEPLYZW4FHAVCNFSM6AAAAABEYPHKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGU2TKNRRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Back at the office now.  I know it's 8:00pm your time, but are you still around?

Yes, I'm here.
Pls ping me on my WhatsApp when you need me to reply quickly - +254736427777
On Sat, Mar 30, 2024 at 7:21 PM TheWitness @.***> wrote:

Back at the office now. I know it's 8:00pm your time, but are you still
around?
—
Reply to this email directly, view it on GitHub
https://github.com/Cacti/plugin_weathermap/issues/142#issuecomment-2028213943,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG7WJ4IBNGAWS2MHTXTHDJTY23RBNAVCNFSM6AAAAABEYPHKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGIYTGOJUGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

How about 9:00 am EDT tomorrow?  It's too late now for you.

Hallo @@.*** @.***>
Let's meet at that time - it will be 1600h here.
How do I prompt you to join the call?
BR/
Stephen N.
On Sat, Mar 30, 2024 at 10:37 PM TheWitness @.***>
wrote:

How about 9:00 am EDT tomorrow? It's too late now for you.
—
Reply to this email directly, view it on GitHub
https://github.com/Cacti/plugin_weathermap/issues/142#issuecomment-2028450989,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG7WJ4PIVFMJBOMSLDLDOM3Y24H6BAVCNFSM6AAAAABEYPHKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGQ2TAOJYHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

I use Zoom if that okay.

Zoom is okay.
Please send the link for me to click and join.
I think there is 2 hours left, now.
On Sun, Mar 31, 2024 at 1:35 PM TheWitness @.***> wrote:

I use Zoom if that okay.
—
Reply to this email directly, view it on GitHub
https://github.com/Cacti/plugin_weathermap/issues/142#issuecomment-2028632456,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG7WJ4KZLPOB5IR5JRN63YLY27RGFAVCNFSM6AAAAABEYPHKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGYZTENBVGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

Meeting is open now.
https://us06web.zoom.us/j/9079396179?pwd=OGY4NFl6cEtGQ2VrK3ZiaDJEd21SUT09

Okay, two files to update.  Please provide feedback.  This was a shotgun approach.

If you were running the latest develop, just replace the two files.  If not, just replace them all.

Hallo @@.*** @.***>
I have just replaced the two files - and tested by rebuilding the
weathermap.
Still showing "UNKNOWN - graph-id" with a broken-image.
Please find attached screenshot of the error.
BR/
Stephen N.
On Tue, Apr 2, 2024 at 5:30 AM TheWitness @.***> wrote:

If you were running the latest develop, just replace the two files. If
not, just replace them all.
—
Reply to this email directly, view it on GitHub
https://github.com/Cacti/plugin_weathermap/issues/142#issuecomment-2030963510,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG7WJ4J3P64CY4TEFL5ZWWTY3IJ3BAVCNFSM6AAAAABEYPHKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQHE3DGNJRGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hallo @TheWitness
I have just replaced the two files - and tested by rebuilding the
weathermap.
Still showing "UNKNOWN - graph-id" with a broken-image.
Please find attached screenshot of the error.

BR/
HerrDrSt

Okay.  I'll setup a local map.  Busy week though.

Hallo @@.*** @.***>
This is okay. Will continue to wait.
On another note, the same happened on a previous version, and Howie gave
some pointers on the post below - I dont know if it will help:
https://forums.cacti.net/viewtopic.php?t=34678
Quote:
The reason that fails is that you haven't got a SET to define
cacti_graph_id for the link. It's not set by the rrd datasource plugin (or
any other plugin).
The DSStats plugin (in 0.97) and rrdtool plugin (in poller_output mode
ONLY) should both set it.
If you run with DEBUG logging for one poller cycle, you should see what is
being set or not (look for lines about 'add_note').
I see some of files referenced are:

lib/ds-common.php
if(isset($r4['local_graph_id']))
$item->add_note("cacti_graph_id",intval($r4['local_graph_id']));

CHANGELOG.md:* FIXED  - cacti_graph_id set to 0 instead of ID, by
rrd/poller_output and dsstats plugins (thanks sh0x)

BR/
HerrDrSt
On Wed, Apr 3, 2024 at 9:25 AM TheWitness @.***> wrote:

Okay. I'll setup a local map. Busy week though.
—
Reply to this email directly, view it on GitHub
https://github.com/Cacti/plugin_weathermap/issues/142#issuecomment-2033654992,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG7WJ4LZGOGBTKQUZSWCMYDY3OOEXAVCNFSM6AAAAABEYPHKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTGY2TIOJZGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Anything in the Cacti log to speak of?

Hallo @TheWitness
These are the errors from the cacti-log,,

Mostly errors from "  Implicit conversion from float to int loses
precision in file" - which I saw is being handled in another topic on this
forum.
=> Was this resolved?

The other has to do with poller and image color.

====================================================================================================================================
2024-04-07 13:26:24 - CMDPHP PHP ERROR Backtrace:
(/poller.php[827]:api_plugin_hook(),
/lib/plugins.php[83]:api_plugin_run_plugin_hook(),
/lib/plugins.php[221]:weathermap_poller_bottom(),
/plugins/weathermap/setup.php[1142]:weathermap_run_maps(),
/plugins/weathermap/lib/poller-common.php[442]:WeatherMap->DrawMap(),
/plugins/weathermap/lib/WeatherMap.class.php[3604]:WeatherMap->DrawLegend_Classic(),
/plugins/weathermap/lib/WeatherMap.class.php[1792]:Colour->gdallocate(),
/plugins/weathermap/lib/WeatherMap.functions.php[1813]:myimagecolorallocate(),
/plugins/weathermap/lib/WeatherMap.functions.php[363]:imagecolorexact(),
CactiErrorHandler())
2024-04-07 13:26:24 - ERROR PHP DEPRECATED in  Plugin 'weathermap':
Implicit conversion from float 9.375 to int loses precision in file:
/var/www/html/cacti/plugins/weathermap/lib/WeatherMap.functions.php  on
line: 363
2024-04-07 13:26:24 - CMDPHP PHP ERROR Backtrace:
(/poller.php[827]:api_plugin_hook(),
/lib/plugins.php[83]:api_plugin_run_plugin_hook(),
/lib/plugins.php[221]:weathermap_poller_bottom(),
/plugins/weathermap/setup.php[1142]:weathermap_run_maps(),
/plugins/weathermap/lib/poller-common.php[442]:WeatherMap->DrawMap(),
/plugins/weathermap/lib/WeatherMap.class.php[3604]:WeatherMap->DrawLegend_Classic(),
/plugins/weathermap/lib/WeatherMap.class.php[1792]:Colour->gdallocate(),
/plugins/weathermap/lib/WeatherMap.functions.php[1813]:myimagecolorallocate(),
/plugins/weathermap/lib/WeatherMap.functions.php[363]:imagecolorexact(),
CactiErrorHandler())
2024-04-07 13:26:24 - ERROR PHP DEPRECATED in  Plugin 'weathermap':
Implicit conversion from float 4.6875 to int loses precision in file:
/var/www/html/cacti/plugins/weathermap/lib/WeatherMap.functions.php  on
line: 363
2024-04-07 13:26:24 - CMDPHP PHP ERROR Backtrace:
(/poller.php[827]:api_plugin_hook(),
/lib/plugins.php[83]:api_plugin_run_plugin_hook(),
/lib/plugins.php[221]:weathermap_poller_bottom(),
/plugins/weathermap/setup.php[1142]:weathermap_run_maps(),
/plugins/weathermap/lib/poller-common.php[442]:WeatherMap->DrawMap(),
/plugins/weathermap/lib/WeatherMap.class.php[3604]:WeatherMap->DrawLegend_Classic(),
/plugins/weathermap/lib/WeatherMap.class.php[1792]:Colour->gdallocate(),
/plugins/weathermap/lib/WeatherMap.functions.php[1813]:myimagecolorallocate(),
/plugins/weathermap/lib/WeatherMap.functions.php[363]:imagecolorexact(),
CactiErrorHandler())
2024-04-07 13:26:24 - SYSTEM STATS: WEATHERMAP Time:1.99 Maps:1 Warnings:8
Notes:None
2024-04-07 13:28:31 - AUTH LOGIN: User 'admin' Authenticated via
Authentication Cookie
^C
@.***:/var/www/html/cacti/log#
On Sat, Apr 6, 2024 at 2:28 PM TheWitness @.***> wrote:

Anything in the Cacti log to speak of?
—
Reply to this email directly, view it on GitHub
https://github.com/Cacti/plugin_weathermap/issues/142#issuecomment-2041053923,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG7WJ4PF4GLDGJ6ULZFIDJTY37L5RAVCNFSM6AAAAABEYPHKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGA2TGOJSGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

It looks like you are not running the latest develop.  A few of your files are out of date.

Hallo, You mean Cacti itself or Weathermap?

WeatherMap.  You should not be getting those deprecation warnings any longer.  I've confirmed in the code.

@HerrDrSt , weird that I closed this.  Can you update to the latest develop and see if it's fixed.  If not, can you do a Zoom on Saturday?

Hallo @thewitnessPlease confirm- which develop? For Cacti or Weathermap ?Have you uploaded the latest one for Weathermap ?On 26 Apr 2024, at 23:55, TheWitness @.***> wrote:
@HerrDrSt , weird that I closed this.  Can you update to the latest develop and see if it's fixed.  If not, can you do a Zoom on Saturday?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

https://github.com/Cacti/plugin_weathermap.git


The introduction of less files does not work.

Hello, because my project was introduced with less.
So my way of introducing it is this.
@import "~slick-carousel/slick/slick.less";
@import "~slick-carousel/slick/slick-theme.less";
but Don't work ；I checked and found a missing pattern.
.slick-initialized .slick-slide {
display: block;
}

This could be an issue with your build system.
Not a problem with this library


Add aoc_2024

Repository URL
https://github.com/david-a-perez/aoc_2024.git
Crate name
No response
Toolchain version
nightly-2024-12-02

Hey @david-a-perez, the workflow failed because you have a .git at the end of the repo url.
You can close this issue and recreate one with the correct link:  https://github.com/david-a-perez/aoc_2024


Make a release with new groupId com.spotify

Since Spotify has taken over this plugin, we want to make a new release with just a change to the groupId, before merging any feature PRs.

Solved by #133 and release 2.14


zone entities are duplicated on integration reload

What happened?
I've had the same behaviour as in #364. Each zone had two sensor entities.
e.g. my zone "Vorgarten" had the entities sensor.smart_irrigation_vorgarten and sensor.smart_irrigation_vorgarten_2.
I tried to reproduce it and noticed that they duplicate when I click on "Reload" in the integration. Interestingly, after each reload there is on more entity added than before.
I clicked on reload and the number of entities for one zone increased from 17 to 23. The next time I reloaded the integration it went from 24 to 30.
After a restart all entities other than the main one are unavailable with the message This entity is no longer being provided by the smart_irrigation integration. If the entity is no longer in use, delete it in settings.

I assume that it is not only triggered by manually reloading the integration because I don't recall doing this before I first noticed that I had each entity twice.
The zones are only once in the smart_irrigation storage.
config_entry-smart_irrigation-55a83ca033886c56dae74c7dfafdb914.json
How to reproduce
Settings->Devices & Services -> Integrations -> Smart irrigation -> Three dots -> Reload
Relevant log output
No response
Which version are you running?
v2024.4.3
Diagnostics file

[X] I have attached a diagnostics file

Additional information
No response

I deleted the "Smart Irrigation" entry in the Integrations view and after readding only one entity per zone is there. When I reload the integration it still duplicates them but at least this is a workaround to get rid of them without manually deleting them.

I deleted the "Smart Irrigation" entry in the Integrations view and after readding only one entity per zone is there. When I reload the integration it still duplicates them but at least this is a workaround to get rid of them without manually deleting them.

This may only work when home assistant was not restarted after deleting the integration. Probably because the configuration/storage is still in cache. When deleting the integration, restarting home assistant and then readding the integration there were no entities at all. Configuration is empty like when I first installed it.

i have the same, since 3 days my original zone entities have disapeared, and i have multiple new copies of them now, eg "sensor.smart_irrigation_trees_zone_2" and "sensor.smart_irrigation_trees_zone_3"
i have done nothing with the integration or settings of it for weeks...

Same here after updating to 2024.7.4

Please post your config

Please post your config

https://drive.google.com/file/d/1fUxyn56uVcHVF7PCad3sQY1pVOplYSvh/view?usp=share_link

same here after upgrading to latest v2024.7.5

same here after upgrading to latest v2024.7.5

Please open your own issue, this does not help at all.


ID class, purple

Attempting to change index.html to add a purple thing :)

I ended up making it in another issue, despite this one predating...


Spectra comparison

Changes Unknown when pulling f7a48243cd6ecd6abf100bb37887305123fcf9ec on spectraComparison into ** on master**.

Changes Unknown when pulling e19a9970e5b9b109e259db71a2cc09c583df4151 on spectraComparison into ** on master**.


BAC-305 added integration tests

added integration tests for the following methods

admin.publishSignals
admin.selectSignals
clarify.dataFrame
clarify.evaluate
clarify.selectItems
integration.insert
integration.saveSignals

I have converted to draft; please mark as ready for review when all current comments are resolved.


Add Getting started section to README

README Update
Please add getting started section to readme.

Added Getting Started section to preview it.


Combobox popup wrongly aligned to the bottom-end

Current behavior
I've to admit this is a weird bug that took me 1h to find the cause: it turns out that setting the body margin to 0 makes the combobox popup get aligned to the right.
Steps to reproduce the bug

Open sandbox: https://codesandbox.io/s/blazing-rain-cu8rym
Open the modal and it should be incorrectly placed at the right
Open the style.css and remove the margin: 0
Open the modal and note it's now correctly placed at the left

Expected behavior
Modal always aligned to the bottom-left, unless explicitly defined through the placement prop.
Possible solutions
No response

I've updated the link, sorry.

Hmm, I still can't see it.

Can you try again,  pls?

Ah, that's because the popover has a default padding to the edges of the viewport.
You can remove that with:
useComboboxState({ overflowPadding: 0 })

It should definitely be documented somewhere 😅


Consolidate dependency graph visitors

The primary goal of this change is to "bring up" the artifact visiting logic into the DefaultConfigurationResolver so that it can reside with the other graph visiting logic. Now, all logic that traverses constructed dependency graphs is located in one place. This will allow us to start merging the concepts of graph visitors and artifact visitors, so that we can in the future work towards adding more artifact information to resolution results -- or at least introduce some improved connections between a resolved graphs and the artifacts it produces.
As a side effect, some work was done to reduce reliance on ResolveContext in this area Additionally, DefaultArtifactDependencyResovler was renamed to DefaultResolverFactory to better reflect its behavior Further, javadoc was added in several places that otherwise lacked any description.

@bot-gitstream check all

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Sorry but I'm afraid you're not allowed to do this.

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


Ig-Combo clear Converts model to Array

I download sample of your current version igniteui-angular-wrappers-5.0.7
while i select any value from drop down and clear it ..it converts ngModel to array .
I attached screen shot of issue .

While selecting value model is number

2.after clearing value .. it converts to array .

Expected result
It should be number if our model is numeric.
It should be string if our model is string.
it should be array if our model is array

It is an empty array, because this is the model of igCombo when the value is cleared. I believe, it is done for consistency when there is multiple selection.

it is working fine for multi selection .
but if it is single selection then model will be set to null or undefined (in any cases )
if u convert model to array and pass model object or particular model to server side then it throws error .


Tracking issue for v0.2

Now that we have maintainers for this crate I think it's about time there were fixes to long standing issues like #20. It's probably worth making this a breaking update to avoid any issues with unmaintained users of the current version (and would be a good opportunity to make other breaking changes if there are any).
Checklist of things to sort out before releasing 0.2.0 (feel free to add more items and pull these  out to separate issues if they need discussion):

[ ] Sort out #20 (existing PR at #21, there's also a link somewhere to extra testcases I wrote for this a few years ago).
[ ] Look at #16 and #23
[ ] "nameless routes" (noted by @gameldar at https://github.com/rustasync/tide/issues/12#issuecomment-494453357)
[ ] Sort out licensing (#19 + the repo is missing license files for the current license).
[ ] rustfmt + clippy (open PR #27)
[ ] Update travis config (rustfmt + clippy, stable + beta + nightly, minimum Rust version)
[ ] Update metadata (at a minimum links + authors in Cargo.toml)
[ ] Improve documentation

I've created issues for the two things I know need addressing:

#29 is for the one referred to in the the https://github.com/rustasync/tide/issues/12#issuecomment-494453357
#30 - this came up during a recent Tide triage session - it may make more sense to solve this on the Tide side but we can discuss that - at present the query string is ending up in the last matching parameter's value.

Possibly the other thing that could be addressed here is URL decoding (https://github.com/rustasync/tide/issues/281) - this means it can be done once and without having to duplicate the parameters map after decoding in other contexts.


[Docker Extension] Make Catalog Items Clickable

Notes for Reviewers
This PR fixes #11517
Signed commits

[x] Yes, I signed my commits.

In other words, should we bother with this update or go directly to using the Sistent component, @humblenginr? Is this just churn?

We can do either way. The Sistent component should not have to do anything different to support this.


enhancement: optionally identify logging origin

to help us recognize 1st and 2nd level API logs

Done in https://github.com/palavrapasse/aspirador/issues/22

https://github.com/palavrapasse/query/issues/56
https://github.com/palavrapasse/santos/issues/48
https://github.com/palavrapasse/subscribe/issues/48


Created account but when I try to login: “ This email or password didn't match our records.”

Describe the bug
I created an account and activated it.
When I try to login I receive this message:
” This email or password didn't match our records. Please try again. Your account will be locked after 5 unsuccessful attempts.”
To Reproduce
Steps to reproduce the behavior:
Create a new account and see if this is repeatable. Someone else experienced a similar issue: https://repost.aws/questions/QUSB0wO0OiQ_irUdCx9ppjbg/registered-for-aws-sagemaker-studio-but-not-able-to-create-account
MacOS, Safari and Chrome

Dear @robptrck thank you for trying the Studio Lab and sorry for the late response. Do you still have the error? If so, please submit from the following form to confirm about your account.
https://pages.awscloud.com/GLOBAL_PM_PA_amazon-sagemaker_20211116_7014z000000rjq2-registration.html

I close this issue because of the no response. Dear @robptrck , I hope your problem is solved. If you still have the problem, please let us know by another issue.


Update portal ui

Description
Update portal ui to be in line with the latest changes.

LGTM but could you please bump this to incorporate the latest UI fixes?

@immanuelfodor yes I will update this 🙂

@gndz07 is https://github.com/traefik/hub-apiportal-ui still OK, or do we need/should update the README?

@svx the readme is still fine, it still works the same.

@immanuelfodor @nmengin can we merge this PR?

Yes, please, all dependencies are out with today's release


Introduce a mode in the server to disable queries

When we have problems with pinot servers in production, and need to isolate the
server by not sending queries to it, we use the shutdownInProgress field in the
instance config. This does not work if the server is restarted (due to deployment
or by other automated systems) because the upon restart, the server automatically
sets shutdownInProgress to "false". We would still like to isolate the server to
find out what the real issue may be.
This commit introduces another field called "queriesDisabled" in the instance config
that the admin can set.  The broker pays attention to this field and excludes the
server from routing table computations (thus not routing queries to it).
This behavior continues until such time as the value of this field is set to false.

Codecov Report

Merging #4767 into master will increase coverage by 7.84%.
The diff coverage is 80%.

@@             Coverage Diff              @@
##             master    #4767      +/-   ##
============================================
+ Coverage     49.95%   57.79%   +7.84%
  Complexity        4        4
============================================
  Files          1209     1209
  Lines         64938    64947       +9
  Branches       9458     9460       +2
============================================
+ Hits          32437    37539    +5102
+ Misses        29942    24551    -5391
- Partials       2559     2857     +298

Impacted Files
Coverage Δ
Complexity Δ

...org/apache/pinot/common/utils/CommonConstants.java
32.69% <ø> (+7.69%)
0 <0> (ø)
:arrow_down:

...er/routing/builder/RoutingTableInstancePruner.java
86.95% <100%> (+2.74%)
0 <0> (ø)
:arrow_down:

.../broker/routing/HelixExternalViewBasedRouting.java
90.79% <66.66%> (+42.82%)
0 <0> (ø)
:arrow_down:

...inot/transport/netty/NettyTCPClientConnection.java
81.45% <0%> (-3.32%)
0% <0%> (ø)

.../helix/core/realtime/SegmentCompletionManager.java
70.21% <0%> (+0.42%)
0% <0%> (ø)
:arrow_down:

...ment/creator/impl/SegmentColumnarIndexCreator.java
88.8% <0%> (+0.72%)
0% <0%> (ø)
:arrow_down:

...t/creator/impl/SegmentIndexCreationDriverImpl.java
89.71% <0%> (+0.82%)
0% <0%> (ø)
:arrow_down:

...e/io/writer/impl/MutableOffHeapByteArrayStore.java
85.71% <0%> (+1.09%)
0% <0%> (ø)
:arrow_down:

.../pinot/core/segment/index/SegmentMetadataImpl.java
80.97% <0%> (+1.21%)
0% <0%> (ø)
:arrow_down:

...pinot/core/operator/docvalsets/SingleValueSet.java
90.41% <0%> (+1.36%)
0% <0%> (ø)
:arrow_down:

... and 286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5439e77...7387778. Read the comment docs.


Making the frontend responsive for all screen sizes

Description:
We need to ensure that the CampusUnify frontend is fully responsive and adjusts well across various devices like mobile phones, tablets, and desktops. This can be done in phases, starting with critical pages and components. The styling should be implemented using Tailwind CSS, focusing on making all layouts flexible and user-friendly on smaller screens.
Tasks:

Analyze existing components and layouts for responsiveness issues.
Refactor CSS using Tailwind's responsive utilities.
Test each phase across various screen sizes (mobile, tablet, and desktop).
Ensure no functionality is compromised after implementing responsive design.

Phase Breakdown:
Distribute the work over several phases and PRs so that it would become easy to test and merge the final code.

I am closing issues #2 and #3, combining them both into this one

Assign me this, I'll work on it

Assigning to you. As this might be a big refactor, make sure that you open PRs in phases so that it becomes a bit easy for me to review and merge code

Hi! @PorePranav , I'm unable to signin/signup locally, it is giving server error saying
Uncaught Exception, Shutting Down!
Error: `key_id` is mandatory

What am I supposed to do?

Hi! @PorePranav , I'm unable to signin/signup locally, it is giving server error saying
Uncaught Exception, Shutting Down!
Error: `key_id` is mandatory

What am I supposed to do?

Just set up any random key for RAZORPAY_ID_KEY and related fields in config.env file for the server, that would fix it. Thanks!

The sever has started but not it is throwing this error when I'm trying to signup:

BTW #18 has been solved, should i create a separate pr for it?

The sever has started but now it is throwing this error when I'm trying to signup:
Is this still related to config.env?

Make sure that you are setting up VITE_APP_BACKEND_URL approriately in .env for client, the variable should point to the server url, which is http://localhost:3000/api/v1 by default

BTW #18 has been solved, should i create a separate pr for it?

No need to create a separate one, you can include it all in one PR

Thanks

And what exactly do you mean by opening PR in phases? Sorry if this sounds dumb

No need to apologize, we all learn at some point! I just meant that to commit changes in a phased manner and not to push all changes in a single commit. It just helps me with code review and testing.

So just make multiple commits instead of one?

So just make multiple commits instead of one?

Yes!

I'm not able to see any events in the events part?

I'm not able to see any events in the events part?

Could you please elaborate your issue, please provide me with additional information so that I can assist you better.

when i click on events, in my local environment, I am not able to see any current events but when I use your deployed link, I am able to see a lot of events

when i click on events, in my local environment, I am not able to see any current events but when I use your deployed link, I am able to see a lot of events

You need to create one club account to add events, then only you would be able to list the events

@PorePranav can i work for the frontend part for the responsiveness of the project.

@Anurag-singh-thakur I have already raised the PR, search for another issue


merge package from arlac77/npm-package-template

package.json

chore(package<EMAIL_ADDRESS>chore(scripts): cover@#overwrite c8 --temp-directory build/coverage ava && c8 report -r lcov --temp-directory build/coverage
chore(package): add main from template
chore(package): add nyc from template
docs(package): remove keyword null
chore(package): set $.ava.require='esm' as in template
chore(package): set $.ava.files='tests/-test.js,tests/-test.mjs' as in template
chore(package): set $.ava.extensions='js,mjs' as in template
chore(package): remove unknown value for main ({{main}})

Codecov Report

Merging #282 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   94.54%   94.54%
=======================================
  Files           5        5
  Lines         275      275
  Branches       42       42
=======================================
  Hits          260      260
  Misses         14       14
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f627b...e57b9d4. Read the comment docs.

Coverage remained the same at 46.392% when pulling e57b9d418746544c02804f53ba8c2f23c2923029 on template-sync-1 into c2f627b8173bc5cf10e5ea8d168a6bb4a94f5e0a on master.

:tada: This PR is included in version 1.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Any plan for more in depth language support?

That would be great if you can run something like https://github.com/ensime for full language support.

Thank you interesting link. Yes, I plan implement full language support.

:+1:

https://github.com/ensime/ensime-vscode  would be worth coordinating efforts here


Remove AssertCompareToSpecificMethodRector from CodeQuality set

Thanks :+1:  I'm looking at the rule now and see there is on reason for its existance. I'll handle the deprecatoin


Ability to search for tags + tag fuzzy matching

This issue will introduce a new command named /tags search <query: str>. When used, it will fuzzy match tags that are similar to the query listed in the same format as the /tags list command.
This issue should also introduce a fuzzy matching feature to the /tags view command that will show a "did you mean..." message when a tag does not exist.
Part of #1.

For the search, maybe we could just add it as an argument to /tags list, but it will get more confusing with too many arguments.

@mudkipdev /tags list probably does not need the fuzzy match since its just returning every tag anyways.


docker s3fs: transport endpoint is not connected

Summary
I'm trying to use rexray with docker swarm for volumes on a non-aws servers cluster.
I tried the s3 provider without success, both using an existing bucket name or using a new volume.
The connection with s3 seems working, because I can see all my existing buckets as swarm volumes from docker, and new buckets are created when a new volume is requested.
Unfortunately the docker service doesn't start because the mounting error cause a crash.
Bug Reports
Version
REX-Ray
-------
Binary: /usr/bin/rexray
Flavor: client+agent+controller
SemVer: 0.11.1
OsArch: Linux-x86_64
Commit:<PHONE_NUMBER>ac4426b04941b4002fb33b9efd972e
Formed: Tue, 19 Dec 2017 23:26:34 CET

docker -v
Docker version 17.12.0-ce, build c97c6d6

s3fs --v
Amazon Simple Storage Service File System V1.79(commit:unknown) with GnuTLS(gcrypt)

Expected Behavior
A new s3fs backed volume is mounted in the started docker container.
Actual Behavior
The service doesn't start, and if using a swarm service it continues to reschedule because it's failing attaching the volume.
Steps To Reproduce

installed s3fs using apt-get install s3fs
Installed rexray as a service in ubuntu using curl -sSL https://dl.bintray.com/emccode/rexray/install | sh
configure rex ray (see below)
start the rexray service using service rexray start
check if the service is running with service rexray status
create a new service with a rexray volume

docker service create --name rexray-test-00 \
    --mount "type=volume,source=rexray-test-bucket-00,target=/data,volume-driver=rexray" \
    busybox sh

see logs below for the logs output

Also using docker without swarm mode causes the problem
~# docker run -it -v s3svol:/data --volume-driver=rexray busybox sh
docker: Error response from daemon: OCI runtime create failed: container_linux.go:296: starting
container process caused "process_linux.go:398: container init caused \"rootfs_linux.go:58: mounting
 \\\"/var/lib/rexray/volumes/s3svol/data\\\" to rootfs \\\"/var/lib/docker/overlay2
/efe91e849443606c936cdb5a59a166a721aecb95c2d380e8850d5aa5e5b79ad3/merged\\\" at
\\\"/data\\\" caused \\\"stat /var/lib/rexray/volumes/s3svol/data: transport endpoint is not connected\\\"\"": unknown.

Configuration Files
s3fs:
  accessKey: MY_ACCESS_KEY...
  secretKey: MY_SECRET_KEY...
  region: eu-west-3
libstorage:
  service: s3fs

Logs
Service Log
Rexray log https://gist.github.com/lifeisfoo/eeb9f522e76495ed5e886bbd7e5be611
Client Log
Syslog https://gist.github.com/lifeisfoo/449fa100b1ac43e0a26eede2612d1a6a

Hello @lifeisfoo,
Have you tried manually using the S3FS tool from that instance?

Hi @clintkitson, I've tried just now and it works nicely. See below:
root@bemind-test1:~# mkdir s3test
root@bemind-test1:~# AWSACCESSKEYID=MY_ACCESS_ID AWSSECRETACCESSKEY=MY_SECRET \
         s3fs rexray-test-bucket-00 /root/s3test
root@bemind-test1:~# ls s3test/
root@bemind-test1:~# touch s3test/one_file.txt

Thank you for your time.

How about if you try it from inside of a container? I am wondering if the container networking itself isn't letting the container access the S3 API?

I've done another two tests.

Running a container as privileged - fail

root@test1:~# docker run -it --privileged -v rexray-privileged-test:/data --volume-driver=rexray busybox sh
docker: Error response from daemon: OCI runtime create failed: container_linux.go:296: starting container process caused "process_linux.go:398: container init caused \"rootfs_linux.go:58: mounting \\\"/var/lib/rexray/volumes/rexray-privileged-test/data\\\" to rootfs \\\"/var/lib/docker/overlay2/69411afb09712701130d53723ac88364db1276efb1e808b6260f8368bba5cd7b/merged\\\" at \\\"/data\\\" caused \\\"stat /var/lib/rexray/volumes/rexray-privileged-test/data: transport endpoint is not connected\\\"\"": unknown.

Adding a filemode in rexray config - fail

linux:
  volume:
    fileMode: 0777

After the filemode was added to the rexray confing, the service create command above returns always the same error. I've taken this hint from #907 without success.

@lifeisfoo Apologies for not being more specific. I was asking if you could manually launch a container with bash as the entrypoint, and then try running S3FS specific commands.
Also there are lots of folks with success getting this working. Check the thread below, possibly some nuggets here that might help you.
https://github.com/thecodeteam/rexray/issues/849#issuecomment-364017832


feat: App utilities gRPC services

closes https://github.com/ansys/pyfluent/issues/3553
>>> solver._app_utilities.get_product_version()
'25.2.0'
>>> solver._app_utilities.get_build_info()
'Build Time: Dec 10 2024 14:19:50 EST Build ID: 39 Revision: 14070d11dc Branch: hpohekar/t1178910/solver_utilities_grpc_service'
>>> solver._app_utilities.get_controller_process_info()
{'hostname': 'AAPQ13pUvWxQtxN', 'process_id': 69100, 'working_directory': 'D:\\pyfluent'}
>>> solver._app_utilities.get_solver_process_info()
{'hostname': 'AAPQ13pUvWxQtxN.win.ansys.com', 'process_id': 85668, 'working_directory': 'D:/pyfluent'}
>>> solver._app_utilities.get_app_mode()
<FluentMode.SOLVER: 'solver'>

>>> solver._app_utilities.start_python_journal("test_pyfluent_journal.py")

>>> "hi"

> "bye"

>>> solver._app_utilities.stop_python_journal()
>>>

>>> solver._app_utilities.is_beta_enabled()
False
>>> solver._app_utilities.is_wildcard("hello")
False
>>> solver._app_utilities.is_wildcard("hello*")
True
>>>

>>> solver._app_utilities.is_solution_data_available()
False
>>> > Fast-loading "D:\ANSYSDev\vNNN\fluent\fluent25.2\\addons\afd\lib\hdfio.bin"
Done.
Multicore SMT processors detected. Processor affinity set!

Reading from AAPQ13pUvWxQtxN:"D:/mixing_elbow.msh.h5" in NODE0 mode ...
  Reading mesh ...
       17822 cells,     1 cell zone  ...
          17822 mixed cells,  zone id: 87
       91581 faces,     7 face zones ...
           2168 polygonal wall faces,  zone id: 34
            268 polygonal wall faces,  zone id: 33
            155 polygonal pressure-outlet faces,  zone id: 32
            152 polygonal velocity-inlet faces,  zone id: 31
             55 polygonal velocity-inlet faces,  zone id: 30
           2001 polygonal symmetry faces,  zone id: 29
          86782 mixed interior faces,  zone id: 89
       66417 nodes,     3 node zones ...

Building...
     mesh
     materials,
     interface,
     domains,
     zones,
        Skipping thread 20 of domain 1 (not referenced by grid).
        Skipping thread 21 of domain 1 (not referenced by grid).
        Skipping thread 22 of domain 1 (not referenced by grid).
        Skipping thread 23 of domain 1 (not referenced by grid).
        Skipping thread 24 of domain 1 (not referenced by grid).
        Skipping thread 25 of domain 1 (not referenced by grid).
        Skipping thread 26 of domain 1 (not referenced by grid).
        Skipping thread 27 of domain 1 (not referenced by grid).
        Skipping thread 28 of domain 1 (not referenced by grid).
        wall-elbow
        wall-inlet
        outlet
        cold-inlet
        hot-inlet
        symmetry-xyplane
        interior--elbow-fluid
        elbow-fluid
     parallel,
Done.
Mesh is now scaled to meters.
adjoint/                parallel/               server/
define/                 parametric-study/       solve/
display/                plot/                   surface/
exit                    preferences/            turbo-workflow/
file/                   print-license-usage     views/
mesh/                   report/

>
Initialize using the hybrid initialization method.

Checking case topology...
-This case has both inlets & outlets
-Pressure information is not available at the boundaries.
 Case will be initialized with constant pressure

        iter            scalar-0

        1               0.000000e+00
        2               0.000000e+00
        3               0.000000e+00
        4               0.000000e+00
        5               0.000000e+00
        6               0.000000e+00
        7               0.000000e+00
        8               0.000000e+00
        9               0.000000e+00
        10              0.000000e+00

Hybrid initialization is done.

Note: Settings to improve the robustness of pathline and
      particle tracking have been automatically enabled.

adjoint/                parallel/               server/
define/                 parametric-study/       solve/
display/                plot/                   surface/
exit                    preferences/            turbo-workflow/
file/                   print-license-usage     views/
mesh/                   report/

>>> solver._app_utilities.is_solution_data_available()
True
>>>

>>> from ansys.fluent.core.streaming_services.events_streaming import SolverEvent
>>> solver._app_utilities.register_pause_on_solution_events(SolverEvent.TIMESTEP_ENDED)
'1'
>>> solver._app_utilities.unregister_pause_on_solution_events('1')

>>>

Is the AppUtilities interface implemented differently for older (pre 252) versions of Fluent?

@hpohekar Is the AppUtilities interface implemented differently for older (pre 252) versions of Fluent?

@seanpearsonuk No. We don't have such cases for app utilities.

@hpohekar Is the AppUtilities interface implemented differently for older (pre 252) versions of Fluent?

@seanpearsonuk No. We don't have such cases for app utilities.
@hpohekar I need some help to understand the design. How are we still supporting the older Fluent versions with these changes? Aren't we switching code that depended on scheme_eval etc to now depend on app_utilities?

@hpohekar Is the AppUtilities interface implemented differently for older (pre 252) versions of Fluent?

@seanpearsonuk No. We don't have such cases for app utilities.
@hpohekar I need some help to understand the design. How are we still supporting the older Fluent versions with these changes? Aren't we switching code that depended on scheme_eval etc to now depend on app_utilities?

@seanpearsonuk The changes we have made in this PR are independent of Fluent versions.

@hpohekar Is the AppUtilities interface implemented differently for older (pre 252) versions of Fluent?

Good point, eventually we'll need another implementation of AppUtilities using scheme-eval to get it working with Fluent version < 25.2. We'll keep the usage code of AppUtilities unchanged, abstracting the version-dependenent implementation inside the services module.
@hpohekar

@seanpearsonuk @mkundu1
Yes, got it now. app_utilities.proto will be available in the 25R2 only not in the prior versions. Yes, I agree with both of you. I considered ansys-api-fluent only, for the availability of the app_utilities.proto but it is present in Fluent as well.

Finally, to answer my own question, the following is the kind of change we are putting in all the calling code. This was my assumption, but I don't think that tis question is being addressed anywhere.

@hpohekar Is the AppUtilities interface implemented differently for older (pre 252) versions of Fluent?

Good point, eventually we'll need another implementation of AppUtilities using scheme-eval to get it working with Fluent version < 25.2. We'll keep the usage code of AppUtilities unchanged, abstracting the version-dependenent implementation inside the services module.
@hpohekar

@seanpearsonuk @mkundu1
Yes, got it now. app_utilities.proto will be available in the 25R2 only not in the prior versions. Yes, I agree with both of you. I considered ansys-api-fluent only, for the availability of the app_utilities.proto but it is present in Fluent as well.

Finally, to answer my own question, the following (a commit from today) is the kind of change we are putting in all the calling code. This was my assumption, but I don't think that this question is being addressed anywhere.

Two issues here:

We have not been clear about the approach.
I am not convinced that this approach is more efficient than simply implementing a flexible AppUtilities class from the outset.

@seanpearsonuk
We are using existing pattern if it's Fluent version older than 25R2 and app utilities otherwise.
It's not clear to me what exactly means flexible. We will have to evaluate the Fluent version everywhere to switch between scheme eval and app utilities so it's not clear how can we make it more efficient.

@hpohekar Is the AppUtilities interface implemented differently for older (pre 252) versions of Fluent?

Good point, eventually we'll need another implementation of AppUtilities using scheme-eval to get it working with Fluent version < 25.2. We'll keep the usage code of AppUtilities unchanged, abstracting the version-dependenent implementation inside the services module.
@hpohekar

@seanpearsonuk @mkundu1
Yes, got it now. app_utilities.proto will be available in the 25R2 only not in the prior versions. Yes, I agree with both of you. I considered ansys-api-fluent only, for the availability of the app_utilities.proto but it is present in Fluent as well.

Finally, to answer my own question, the following (a commit from today) is the kind of change we are putting in all the calling code. This was my assumption, but I don't think that this question is being addressed anywhere.

Two issues here:

We have not been clear about the approach.
I am not convinced that this approach is more efficient than simply implementing a flexible AppUtilities class from the outset.

@seanpearsonuk
We are using existing pattern if it's Fluent version older than 25R2 and app utilities otherwise.
Do we want to use it as follows ? In the following case we are evaluating the Fluent version only once.
class AppUtilitiesOld:
    """AppUtilitiesOld."""

    def __init__(self, service: SchemeEvalService):
        """__init__ method of AppUtilitiesOld class."""
        self.service = service

if FluentVersion(self.scheme_eval.version) < FluentVersion.252:
            self._app_utilities = service_creator("app_utilities_old").create(
                self._app_utilities_service
            )
else:
    self._app_utilities = service_creator("app_utilities").create(
        self._app_utilities_service
    )

AppUtilities would have two different implementations wit the same interface.

Having difficulty finding GitHub comment after email notifications. In brief, I agree with this, thanks:
"
@seanpearsonuk @hpohekar FluentVersion doesn't support the patch version field. Also, FluentVersion is restricted to only few version numbers and won't work generally if this module is reused outside PyFluent.
I think it is better of simply return a tuple from this method.
"

Having difficulty finding GitHub comment after email notifications. In brief, I agree with this, thanks: " @seanpearsonuk @hpohekar FluentVersion doesn't support the patch version field. Also, FluentVersion is restricted to only few version numbers and won't work generally if this module is reused outside PyFluent.
I think it is better of simply return a tuple from this method. "

@seanpearsonuk We have reverted it to the original state. i.e.  return f"{response.major}.{response.minor}.{response.patch}"


Support on Flash Player version <IP_ADDRESS>

Flash Player December release is now public available. (Version <IP_ADDRESS>, issued by Adobe on December 6, 2021)
FlashPatch has not support this version yet.

Official installer <IP_ADDRESS>
https://www.flash.cn/flashplayer/3400211/install_flash_player_ax_cn.exe
https://www.flash.cn/flashplayer/3400211/install_flash_player_cn.exe
https://www.flash.cn/flashplayer/3400211/install_flash_player_ppapi_cn.exe

Thank you. The latest version should support <IP_ADDRESS> now.

@darktohka wrote:

The latest version should support <IP_ADDRESS> now.

Hi :smile: ; many thanks for this tool; however...

I downloaded the official Chinese NPAPI setup from
https://www.flash.cn/flashplayer/3400211/install_flash_player_cn.exe
I extracted it to disk with "Adobe Flash Player Installer unpacker" (other tools may be available)
VirusTotal link:
https://www.virustotal.com/gui/file/8b683921377731905a81751765169718f06212eb7e1cb40d0b66c6baa3a5b60c => detection rate 1/66 (a false positive! :wink:)
I isolated original DLL file NPSWF32_34_0_0_211.dll (32-bit), here's the (unaltered) file sig:

I then launched latest FlashPatch.exe (v1.14) and wanted to use the Patch File... feature!
When I selected (file picker windows popup) the aforementioned unpatched DLL, I got the message below:

... and when I exited FP, indeed the DLL was left untouched, i.e. unpatched, with an intact file sig...
The test was carried out on two different systems, a) Windows Vista SP2 x86, with .NET FW 4.6.2 b) Windows 7 SP1 x64, with  .NET FW 4.6.1; AIUI, .NET FW 4.5 is the minimum version required; can you advise why I failed to patch the DLL myself?
FWIW, the already patched DLLs offered here work as they should, on both systems! :+1:
Any further insight will be appreciated :smile:
Many thanks, festive wishes, keep safe from "omicron"!

@Vangelis66 This bug should be fixed in the latest version, please test and let me know. :)

This bug should be fixed in the latest version, please test and let me know.

Thanks for your reply, unfortunately nothing changed with the advent of FlashPatch-v1.15.exe 😭
I'm attaching below the original, un-patched, x86 NPAPI dll of 34_0_0_211:
NPSWF32_34_0_0_211.zip (zipped)
OS: Windows Vista SP2 32-bit, fully patched + select WS2008SP2 updates
.NET Framework: 4.6.1 (32-bit) with MS patches installed manually
FlashPatch_v1.5.exe launches fine here:

I select the DLL to be patched (identical to the DLL attached above), but as soon as I click Open, FP informs me that:

... and the DLL is left untouched... 😞
If it isn't clear already, I want to patch Chinese Flash (<IP_ADDRESS> here) without having to first install it in my system (but via first extracting NPAPI+PPAPI dlls out of their respective installers...).
Any insight is welcome 😄

Thank you for your patience @Vangelis66.
Unfortunately the previous patch I made to fix your issue was an incomplete one.
The following release v1.15.1 should resolve your issue: https://github.com/darktohka/FlashPatch/releases/tag/v1.15.1
By the way, if you want to install Flash to your system, try using Clean Flash Installer, it is the most convenient option: https://gitlab.com/cleanflash/installer/-/releases

The following release v1.15.1 should resolve your issue:

At long last:

:+1: :tada: :rocket:

if you want to install Flash to your system,
try using Clean Flash Installer, it is the most convenient option:

Thanks :smiley_cat: , but I'm already aware of it :wink: , as well as of Clean Flash Player builds :+1:  ...
In fact, I'm using the latter as it is, for "portable" Flash installations (portable Serpent 52/360EEv11-12-13 installations) ...
What I was, in fact, trying to do, but hampered by the reported bug :angry: , was to verify/replicate the functionality of FlashPatch myself, having already access to the original Chinese (unpatched) setup, but without wanting to first install it systemwide... I hope it's now clear!
Thanks for fixing this, please do continue this nice project!
Kindest regards :smile:


lost connection to VM after running weave connect peerB

steps:
0. ssh to VM1(peerA) and VM2(peerB) which are built on KVM using virtio_net driver

weave launch peerA
weave launch peerB
weave connect peerB (from peerA)

Result:

lost connection to peerA and peerB
check status, connection will be established, and then failed very soon.
check docker logs weave, tcp connection error, cannot reach each peer.

console to peerA, no arp to peerB.
manually add arp entry to peerB, ping peerB,
then print: “ping: sendmsg: No buffer space available”
after reboot or "re-insert virtio_net, restart network", peerA could reach peerB.

weave script 1.5.0
weave router 1.5.0
VM-OS: CentOS Linux (3.10.0-123.4.4.el7.x86_64) 7 (Core)
net driver: virtio_net

Hi @elianka
To be honest this is much more likely to be a problem with your VM networking than a problem with Weave Net. The CentOS 7 kernel you're using as guest is very old and possibly impacted by virtio drivers bugs such as this one.
Can you try with a more recent guest kernel? What are you using for the host out of interest?

i have used the more recent kernel to test, everything is ok.
so that is possible be a problem with kernel version. i will check the bugs, that's very useful, thanks!
i was using weave on my cloud platform, and encountered this problem. I tried to resolve it and checked all the guest and host information because i doubt the kernel issue but not know why. That's it.

it's really a bug for linux. And weave may send big UDP packets using SOCKET_RAW.
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=8a0cafc9a8131cc545dc9924aed38f7176ee4ad7

Well spotted! Looks like the fix landed in the 4.4 kernel.

actually, kernel 3.13 has fixed this.


Android- Workspace- Messages displayed above the Welcome message in newly workspace.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Prerequesite User is logged In

Tap in the profile icon
In settings, tap in Workspaces
Create new workspace through the "New workspace" button
Close Workspace settings tapping in "X" button
Open announce room to the previously created WS
After opened start typing text and press enter.

Expected Result:
Message text should be displayed correctly below the welcome message in the newly created announce room.
Actual Result:
Messages are displayed above the Welcome message in newly workspace room
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/228067183-e9147f98-a43f-40f0-841a-df3946d95688.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Unable to reproduce steps on Google Pixel, v1.2.90-7

@kavimuru can you confirm this bug still exists?

@kbecciv same question 🙇

@dylanexpensify Let me check on my SG21/13, will update you shortly.

Unable to reproduced on build <IP_ADDRESS>
https://user-images.githubusercontent.com/93399543/228310786-d8a9da96-66bd-4850-a49b-eb7923caa30f.mp4


mvien/mip behavior

The spec says
But when bit 9 of mvien is one, bit SEIP in mip is read-only and does not include the value of bit 9 of mvip. Rather, the value of mip.SEIP is simply the supervisor external interrupt signal from the hart’s external interrupt controller (APLIC or IMSIC).
When it says the "value of mip.SEIP is simply the..." is it just saying the readable value or the actual value?
The reason I ask is because the wording makes it seem like mip.SEIP doesn't actually "exist". The prior sentence says
In particular, for most purposes, the value of bit 9 of mvip is logically ORed into the readable value of mip.SEIP.
and of course mvip.SEIP is an alias of mip.SEIP when mvien.9 is 0.
Suppose mvien.9=0, and there was a write to mvip.SEIP=1 (which means mip.SEIP should also be 1).
Then, mvien.9=1, and the supervisor external interrupt signal is 1, so mip.SEIP is still 1
Then, a write to mvip.SEIP=0
Then, the supervisor external interrupt signal is 0, so mip.SEIP becomes 0
Then, a write to mvien.9=0
Should mip.SEIP be 0 here or 1?

When it says the "value of mip.SEIP is simply the..." is it just saying the readable value or the actual value?

In the Privileged ISA's chapter titled "Control and Status Registers (CSRs)", in the section titled "Implicit Reads of CSRs", it says:

Unless otherwise specified, the value returned by an implicit read of a CSR is the same value that would have been returned by an explicit read of the CSR, ....

The "actual value" of mip.SEIP is no different from the readable value.
However, when mvien[9] = 0, mip.SEIP is unusual in having an underlying "software-writable bit" that contributes to its readable value.  This strange arrangement is described in the Privileged ISA section titled "Machine Interrupt Registers (mip and mie)".  See earlier AIA GitHub issue #64.

and of course mvip.SEIP is an alias of mip.SEIP when mvien.9 is 0.

That's not quite correct.  When mvien[9] = 0, mvip.SEIP is an alias of the software-writable bit of mip.SEIP.
To answer your last question, at the end of your sequence, if the incoming supervisor-level external interrupt signal is still 0, then mip.SEIP should be 0.  When mvien[9] = 0, mip.SEIP = (incoming SEI signal) || (software-writable bit SEIP).  And because mvip.SEIP is an alias for the software-writable bit SEIP, it's equally correct to say that mip.SEIP = (incoming SEI signal) || mvip.SEIP.


🐛 Bug: production site missing padding under "See all XYZ projects" button

Overview

The bug is only in production...

Fixed with a !important. 😢


Animated webps with n loops actually runs n+1 loops

Animated webps with a specified number of loops will actually run n+1 loops.  This is 100% reproducible with the version of Flutter I am on.
Steps to Reproduce

Clone this repo https://github.com/KevinTheGray/aweb_bug
Run the app on any device
Observe the top webp loops infinitely as expected (loop count of 0 specified), the second webp incorrectly loops twice (loop count of 1 specified), the third webp incorrectly loops three times (loop count of 2 specified).

Target Platform: Android/iOS/macOS
Target OS version/browser: macOS 10.14.5 (18F132)
Devices:  Happens on desktop as well as any simulator/emulator and physical device
[✓] Flutter (Channel master, v1.12.16-pre.35, on Mac OS X 10.14.5 18F132, locale en-US)
    • Flutter version 1.12.16-pre.35 at /Users/KG/Developer/Flutter/flutter
    • Framework revision b9a56b9f48 (7 days ago), 2019-11-29 20:40:44 -0500
    • Engine revision 8672e79af8
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/KG/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/KG/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.2.1, Build version 11B500
    • CocoaPods version 1.7.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 40.0.2
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] IntelliJ IDEA Community Edition (version 2018.2.5)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 29.1.3
    • Dart plugin version 182.4892.25

[!] VS Code (version 1.35.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    ✗ Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (4 available)
    • iPhone 5s  • 9288B215-C389-4B17-B00A-8C9303B53F4D • ios            • com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator)
    • macOS      • macOS                                • darwin-x64     • Mac OS X 10.14.5 18F132
    • Chrome     • chrome                               • web-javascript • Google Chrome 78.0.3904.108

Run the app on any device

flutter run -d chrome seems to work as expected!

Seems related to this:

https://github.com/flutter/flutter/issues/45246

The repetitionCount number is fetched from SkCodec's getRepetitionCount count:
https://github.com/flutter/engine/blob/f5250ec9b1ef54a6357a8d5ef2ad164270b727f2/lib/ui/painting/multi_frame_codec.cc#L17
The contract for getRepetition count is to return the number of times to repeat the animation (not including the first play): Skia docs.
According to the information in https://github.com/KevinTheGray/aweb_bug it seems like we're SkCode c is counting the first play for webps (but not for GIFs). So this seems like a bug in SkCodec for webp.

I tried looking at the 2-loop.webp in Chrome on Mac (Version 78.0.3904.108) and that seemed to loop three times as well. The report does indicate that this was not an issue in an unspecified version of Chrome. It could be that we need to update our libwebp dependency and this has been fixed upstream. The version we use 0.6.0 while the latest is 1.0.3. The build rules 1.0.3 seem significantly different though and I didn't find the roll trivial.

1.0.3 seems to exhibit the same issue as well so it is not the libwebp codec dependency.
webpinfo says loop count is 2.
Skia treats WEBP_FF_LOOP_COUNT as the repetition count.
Treating the loop count as the repetition count breaks Skia's documented behavior of not treating the first frame as being part of the repetition.

This looks like an issue with SkWebPCodec that is still present in Chrome. The fix is simple enough but I am not sure about the consequences for dependencies other than Flutter. We could special case WebPs in Flutter for repetition count but then Flutter would be susceptible to this breaking on us when Skia fixes the behavior.
@KevinTheGray Are you sure this works for you in Chrome as mentioned in the README in the reproducible test case? I am not able to reproduce the same. I just dragged the file into Chrome to open it.

This item from Blink Reviews seems to indicate that other browsers are trying to match Chrome's behavior:

WebP animation: Loop once more than stored loop count.

we should match the spec. if we decide that the spec is wrong, then we should get it changed.

we should match the spec

Spec is fine. Just that Chrome & Flutter are not following it. Firefox seems to be doing the right thing as well. I'll author a Skia patch.

xref https://skia-review.googlesource.com/c/skia/+/258680

This has been patched and Skia commit has rolled into Flutter Engine. https://github.com/flutter/engine/pull/14321#issue-351706140 adds a test for this in the engine.


[Bug] Cannot read properties of undefined (reading 'states') in pie/labelLayout.js when minShowLabelAngle removes a small angle and label position is "inside"

Version
3.53.1
Link to Minimal Reproduction
No response
Steps to Reproduce
I'm unable to recreate the error in JSFiddle.
This happens when I have a pie chart with label: {position: "inside"} and minShowLabelAngle is set low enough that an small-angle item gets left out.
Current Behavior
Error stack:
labelLayout.js:357
   Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'states')
at SeriesData.<anonymous> (labelLayout.js:357:22)
at DataStore.each (DataStore.js:1009:11)
at SeriesData.each (SeriesData.js:756:17)
at pieLabelLayout (labelLayout.js:336:8)
at PieView.render (PieView.js:291:5)
at Task.progress (Chart.js:233:20)
at Task._doProgress (task.js:187:10)
at Task.perform (task.js:153:16)
at echarts.js:1825:24
at GlobalModel.<anonymous> (Global.js:654:10)

pie/labelLayout.js is getting labelLine:
var labelLine = sector.getTextGuideLine();
and that's returning undefined, then it's trying to read from it:
if (Math.abs(sectorShape.endAngle - sectorShape.startAngle) < minShowLabelRadian) {
each(label.states, setNotShow);
each(labelLine.states, setNotShow);  // THIS ERRORS
label.ignore = labelLine.ignore = true;
return;
}
Expected Behavior
No javascript errors
Environment
- OS: Windows 10
- Browser: Edge 108.0.1462.54
- Framework: Svelte 3.53.1, Echarts 5.40

Any additional comments?
No response

5.4.1 has fixed this bug.