[$1000] Deleted message gets highlighted when we send a message, delete the message, visit any other chat and revisit the chat in offline mode

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Switch to offline mode
Delete any message (currently it is not highlighted)
Switch to other report and revisit the deleted message report to see that message is highlighted now
Switch off offline mode
Again visit the chat to see that deleted message is now gone
Switch back the offline mode
Revisit the chat and deleted message is back and it is still highlighted

Expected Result:
App should not highlight deleted message on revisiting chat in offline mode nor have the deleted message reappear after reconnecting online then offline
Actual Result:
App highlights deleted message on revisiting chat in offline mode and highlight remains intact. App shows deleted message in offline mode even after going back online then offline again.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.8
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/235247949-156727ea-9f12-4048-a81e-55280d5f022e.mp4
https://user-images.githubusercontent.com/43996225/235247965-22b4082c-8cec-4b49-b0ef-286b729d9340.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682681346161399
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013afb44ff7c31e750
Upwork Job ID:<PHONE_NUMBER>987746304
Last Price Increase: 2023-06-01

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

reviewing today!

Proposal
Please re-state the problem that we are trying to solve in this issue.
The deleted message while offline has a hover effect after switching back from another chat.
What is the root cause of that problem?
The hover effect will show if:

is hovered
is a whisper
a context menu active
is a draft message

and the condition that it meets is the third one. Why?
When we delete a chat, it will show a delete modal by calling showDeleteModal of PopoverReportActionContextMenu passing the selected report action id and the report id.
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L287-L296
When we confirm the deletion, we

delete the message
hide the modal
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L261-L265

One thing is missing is to reset the report action id and report id. So, when we reopen the chat, it will remount the component and check, is this chat message has an active context menu?
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ReportActionItem.js#L99-L101
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L110-L112
Because we didn't clear the report action id, it will say, yes, a context menu is active for this chat message.
This issue however doesn't happen when we simply cancel the deletion because when we cancel it, we will call hideDeleteModal that will reset the report action id and along with other state.
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L267-L277
What changes do you think we should make in order to solve the problem?

Reset the other state (only report action id and report id is necessary) when we confirm the deletion (in confirmDeleteAndHideModal).

Didn't get to this today due to focusing on ECUK and CPM tasks! Will review tomorrow!

Posted about this to get clarification on expected behavior. Will update this once we come to a conclusion.

After discussing we confirmed that this is an expected behavior! @dhanashree-sawant here's where you can find more info!

Hi @dylanexpensify, In the document, we have mentioned that it should be greyed out but in the issue, the deleted message gets highlighted not greyed out. It gets greyed out when we delete but when we revisit the chat, it gets highlighted.

I believe that makes sense it's still highlighted while in offline mode, since technically, the delete action hasn't registered 100% yet. I think this would be a bug if we got back online, and the deleted comment did finish deletion, but then still highlighted after switching back. Mind confirming for me it doesn't do that?

Yes so on going back offline, the deleted message reappears and it is still highlighted, steps I did:

switched to offline mode
delete any message (currently it is not highlighted)
switch to other report and revisit the deleted message report to see that message is highlighted now
Switch off offline mode
Again visit the chat to see that deleted message is now gone
Switch back the offline mode
Revisit the chat and deleted message is back and it is still highlighted

And after step 5, is the message now gone? Did you show those steps in the video above?

No message still exist, sorry I haven't shown that part in the video , I will add new video below with step 6 and 7 shown in it.

Ah that'd be great if you can show the steps you just commented in a video! Thanks!

Here is the video
https://user-images.githubusercontent.com/87513216/236191245-aa446e79-970e-4912-8ef8-3e79b2de674f.mp4

@dhanashree-sawant that new video is super helpful, ty!
@bernhardoj appreciate the thoughts, and like where your head is at with it!

Was able to successfully repro. Thanks for the back and forth here team!

Job added to Upwork: https://www.upwork.com/jobs/~013afb44ff7c31e750

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

Triggered auto assignment to @flodnv (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Updated the OP

deleted message reappear after reconnecting online then offline

@dylanexpensify Just re-read the updated expected result. I think this is a different issue. We previously have that issue here https://github.com/Expensify/App/issues/15048 which we decided to not handle it https://expensify.slack.com/archives/C01GTK53T8Q/p1680025815238389?thread_ts=1679595548.409089&cid=C01GTK53T8Q

Repened!

@dylanexpensify - im a bit lost on what the next step(s) on this issue need to be. going forward, please leave some context on what the new assignee should be doing on the GH (more info here).

@Santhosh-Sellavel or @flodnv - apologies, i was assigned this issue to cover for dylan while he's OOO. can someone give me an update on the status of this bug? are we still waiting on a proposal for this one?

Actually I think we already have a proposal here: https://github.com/Expensify/App/issues/18165#issuecomment-1531179702
@Santhosh-Sellavel can you review it please?

Sorry, I missed that one will try to review that today.

Just For quick reference.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The deleted message while offline has a hover effect after switching back from another chat.
What is the root cause of that problem?
The hover effect will show if:

is hovered
is a whisper
a context menu active
is a draft message
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ReportActionItem.js#L282-L286

and the condition that it meets is the third one. Why?
When we delete a chat, it will show a delete modal by calling showDeleteModal of PopoverReportActionContextMenu passing the selected report action id and the report id.
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L287-L296
When we confirm the deletion, we

delete the message
hide the modal
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L261-L265

One thing is missing is to reset the report action id and report id. So, when we reopen the chat, it will remount the component and check, is this chat message has an active context menu?
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ReportActionItem.js#L99-L101
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L110-L112
Because we didn't clear the report action id, it will say, yes, a context menu is active for this chat message.
This issue however doesn't happen when we simply cancel the deletion because when we cancel it, we will call hideDeleteModal that will reset the report action id and along with other state.
https://github.com/Expensify/App/blob/ce3b938b495b28fed058a6c2f1d50bb2aac7961c/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L267-L277
What changes do you think we should make in order to solve the problem?
Reset the other state (only report action id and report id is necessary) when we confirm the deletion (in confirmDeleteAndHideModal).
What alternative solutions did you explore? (Optional)
We can reset the report action id and report id in onModalHide callback of ConfirmModal
https://github.com/Expensify/App/blob/b6eb637298f77156c9dc9c482e30d77b105d2a26/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L332

Looks good, but will revisit it tomorrow for the final call!

@bernhardoj This happens even when we cancel the delete popup and switch and come back to the chat again. So we should handle this too.
Please include a snippet, or feel free to include diff links here if it requires.
https://github.com/Expensify/App/assets/85645967/cc3649ee-cd31-4d4a-b862-d0cc16fa0e7f

@Santhosh-Sellavel we have a PR that remove the reportAction reset when we cancel the modal https://github.com/Expensify/App/pull/17348/files#r1165760995, but the solution to this issue is to reset it. The reason behind this can be read from the link.
I was planning to reset the reportAction when the modal completely hidden with onModalHide callback, but currently I'm unable to delete a money request to make sure it works as expected (the modal text does not change while hiding).

Notice no delete button in the context menu. I think this is a bug because the PR expect a delete button to be present for unsettled money request.

@bernhardoj
Bit confused. What changes are you exactly proposing here?

@Santhosh-Sellavel Sorry if it confuses you. My current proposal is the changes I propose. My previous comment:

The first part is explaining why the issue also happens when cancelling the modal
The rest explaining that we need to fix a bug (or maybe it's intentional?) where a delete button is not present for money request action first. Why? To test and make sure our changes here does not create another issue that was fixed here https://github.com/Expensify/App/pull/17348/files#r1165760995

@bernhardoj
Can you include or share code snippets for the changes your are proposing?

Added in my proposal

@Santhosh-Sellavel what do you think about the proposal?

Sorry for the delay, @bernhardoj proposal addressed the highlight issue mentioned

App should not highlight deleted message on revisiting chat in offline mode nor have the deleted message reappear after reconnecting online and then offline

@flodnv I think we can hire @bernhardoj here, only highlighting issue that needs to be fixed here. As we used the force offline option, which cause unnecessary issues as API would have succeeded the first time itself, we just throw an error on the UI for testing purposes. In a real offline use case, the deleted messages are re-appearing again, but if there is enough time online, it goes away when the API succeeds.

Thanks 👍 Go for it @bernhardoj

Upwork is down, once back up I'll send payment!!

We're back! @Santhosh-Sellavel @bernhardoj @dhanashree-sawant can you all please apply here! 🙇♂

Hi @dylanexpensify, thanks I have applied to the job.

Offers sent, payments coming!

@Santhosh-Sellavel can we work on checklist today before we close out? 🙏

Commented above, Mel!

@Santhosh-Sellavel can you please apply? 🙇♂

@Santhosh-Sellavel bumping

Will look into the checklist this week!

@Santhosh-Sellavel can we get an update here

@Santhosh-Sellavel let's get this done today 🙌

@bernhardoj Could use your help here is the https://github.com/Expensify/App/pull/17348/files#r1165760995 which caused this regression?

@Santhosh-Sellavel let's get an update here today please! 🙇♂

Reviewing today!

Closing!

Ah I forgot that was a thing. Maybe edge case makes sense yeah..
On Wed, Jul 12, 2023 at 11:00 AM Dylan Courtney @.***>
wrote:

Closed #18165 https://github.com/Expensify/App/issues/18165 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/18165#event-9796519875, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7Y2OMQ464T3RPU6DMHKYDXPZRRJANCNFSM6AAAAAAXPVS5TU
.
You are receiving this because you were mentioned.Message ID:
@.***>

I've had not received payment for this @dylanexpensify will request via NewDot

Requested Payment on ND

reopened while we wait for @Santhosh-Sellavel to be paid! Cc @anmurali

Approved $1500 (with bonus) for Santhosh


Limit size for GIF

Description
Large gifs are creating issues with some crashes on the website on some occasions. Next.js does not optimize gifs, and thus the raw file is loaded and can be extremely resource hungry.
To limit this issue, I added a limit of 5MB to only GIFs. 5MB is still quite large and will still require quite a lot of bandwidth, but that should be enough quality.
How to test

Mint a new token
Add a gif of more than 5MB
You should expect an error

@EmmanuelDrouin, if you can have a quick look in terms of UX, that would be great

no file
file too large

I created a dedicated issue for that, I couldn't reproduce it with a gif on my own, maybe related to your gif.
Could you add it on https://github.com/liteflow-labs/starter-kit/issues/162


add support for mesos attribute constraints

For use when launching container using MesosContainerFactory

Description

added config properties to MesosConfig:
whisk.mesos{
        constraints = [] //placement constraint strings to use for managed containers e.g. ["att1 LIKE v1", "att2 UNLIKE v2"]
        blackbox-constraints = [] //placement constraints to use for blackbox containers
        constraint-delimiter = " "//used to parse constraint strings
        teardown-on-exit = true //set to true to disable the mesos framework on system exit; set for false for HA deployments
}

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[x] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[x] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[x] I updated the documentation where necessary.

You can always use the same placement constraints for black box and
managed. I just thought someone might find it useful to corral their black
box containers separately, unrelated to resource requirements.
Currently there is no notion of actions requiring specific resources other
than memory(I think?), which is a separate problem.
Is that what you mean?
On Wed, Apr 18, 2018 at 7:14 PM ddragosd<EMAIL_ADDRESS>wrote:

@ddragosd commented on this pull request.
In common/scala/src/main/resources/application.conf
https://github.com/apache/incubator-openwhisk/pull/3559#discussion_r182618124
:

@@ -162,5 +162,9 @@ whisk {
role = "*" //see http://mesos.apache.org/documentation/latest/roles/#associating-frameworks-with-roles
failover-timeout = 0 seconds  //Timeout allowed for framework to reconnect after disconnection.
mesos-link-log-message = true //If true, display a link to mesos in the static log message, otherwise do not include a link to mesos.

   constraints = [] //placement constraint strings to use for managed containers e.g. ["att1 LIKE v1", "att2 UNLIKE v2"]

   blackbox-constraints = [] //placement constraints to use for blackbox containers

I'm wondering whether the difference is in managed containers vs blackbox
containers to decide where to spin up new action containers, or if it
should be in some other place. I.e if I want to run containers on gpu VMs
vs regular VMs, regardless of them being blackbox or not, where can we
define this ? The reason I'm asking is b/c if the decision point should be
influenced by other factors, maybe we don't have to differentiate here
between blackbox vs non-blackbox containers ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-openwhisk/pull/3559#pullrequestreview-113449124,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABj__O-n28HUgpsytbSv8NaiFkGVTn5Yks5tp_L4gaJpZM4Ta9c9
.

Thanks @tysonnorris .
Provided we leave these 2 settings for now, I'm wondering if the blackbox ratio setting in the controller must be updated to correctly match the VMs allocated for blackbox when using different placement constraints ? For example, given a cluster with 100 VMs, out of which 30 VMs have special attributes for running blackbox actions, should the ratio config in the controller be updated as well to 0.3 ?

Precisely for this uncertainty of whether the blackbox ratio matters or not I was coming from with the thought that maybe we don't need to differentiate between blackbox vs non-blackbox right now. Intuitively I'm thinking that this would change once we introduce semantics for actions that require GPU resources, being blackbox or non-blackbox.
If you feel strongly about keeping the separation as-is in this PR, I would 👍 , waiting to solve the GPU part to get to the actual solution.

Given that this is only touching the Mesos parts, do we need to wait for a PG before merging ?
cc @markusthoemmes @mrutkows @rabbah

I kicked off PG2/3043 for you (might be faster than getting an answer....)

LGTM.

PG2 3403 🔵

thanks a lot @dgrove-oss !


Unmet peer dependencies from cosmiconfig-typescript-loader and graphql-config

Which packages are impacted by your issue?
@graphql-codegen/cli
Describe the bug
I am seeing the following peer dependency warnings with Yarn Berry:
➤ YN0002: │ @graphql-codegen/cli@npm:2.16.4 doesn't provide @types/node, requested by cosmiconfig-typescript-loader
➤ YN0002: │ @graphql-codegen/cli@npm:2.16.4 doesn't provide typescript, requested by cosmiconfig-typescript-loader
➤ YN0002: │ @graphql-codegen/cli@npm:2.16.4 doesn't provide cosmiconfig-toml-loader, requested by graphql-config

Your Example Website or App
N/A
Steps to Reproduce the Bug or Issue

Use Yarn Berry
yarn add<EMAIL_ADDRESS>
Expected behavior
No peer dependency warnings
Screenshots or Videos
No response
Platform

OS: MacOS
NodeJS: 18.12.1
graphql version: 16.6.0
@graphql-codegen/* version(s): 2.16.4

Codegen Config File
No response
Additional context
No response

pnpm reports an additional missing @babel/core peer dependency:
 WARN  Issues with peer dependencies found
.
└─┬ @graphql-codegen/cli 2.16.4
  ├── ✕ missing peer ts-node@>=10
  ├─┬ @graphql-tools/code-file-loader 7.3.16
  │ └─┬ @graphql-tools/graphql-tag-pluck 7.4.3
  │   └─┬ @babel/plugin-syntax-import-assertions 7.20.0
  │     └── ✕ missing peer<EMAIL_ADDRESS>  ├─┬ @graphql-tools/prisma-loader 7.2.53
  │ └─┬ @graphql-tools/url-loader 7.17.2
  │   └─┬ @graphql-tools/executor-http 0.1.1
  │     └─┬ meros 1.2.1
  │       └── ✕ missing peer @types/node@>=13
  ├─┬ cosmiconfig-typescript-loader 4.3.0
  │ ├── ✕ missing peer @types/node@"*"
  │ └── ✕ missing peer ts-node@>=10
  └─┬ graphql-config 4.4.0
    └── ✕ missing peer<EMAIL_ADDRESS>Peer dependencies that should be installed:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

For Yarn,
.yarnrc.yml
packageExtensions:
  "@graphql-codegen/cli@*":
    dependencies:
      "@types/node": "*"
      "typescript": ">=4"
      "cosmiconfig-toml-loader": "^1.0.0"

we removed cosmic config and ts-node in<EMAIL_ADDRESS>


Destroy The Slider After Component Destruction

Can you give more details?
Why do you think the slider is not destroyed?
Just did a simple test with a checkbox and v-if in the slider and even in the middle a of a transitions the component dissapeared

Sorry I just pressed Enter and i  did not have chance to write more details
actually i thought  there might be a special method that i should call
i did not test if it destroys itself
right now before your answer i was checking it in chrome
and it seems that you are right i was not able to find memory leak
thank you for quick response

No worries!
Regards


Add warning for unsaved changes before leaving page resource edit page

Description
This feature is present in compose for page builder. It would be nice if it would be implemented for:

[x] Reporter builder
[x] Compose module edit
[x] Compose namespace edit
[x] Compose page edit
[x] Compose chart edit

for today: address edge cases found by QC


Release v1.84.0

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2961
Originally created by @kgpayne on 2021-09-30 20:52:00

Evergreen Releases - Prep Steps:
An Evergreen release process means we are always releasing. We open a new release ticket as soon as we've completed the prior release. (It's therefore the final step in this checklist.)
"Evergreen Prep" Checklist

[x] Open this Issue
[x] Indicate the version to be released here in the issue's title Release vX.Y.Z

If the release number changes (from minor to major or patch, for instance), update the version here and in the issue description.

Readiness Checklist:
Engineering team, to get ready for the upcoming release:

[x] Ensure any already-merged commits since the last release have Changelog entries (excepting non-user-impacting commits, such as docs fixes).
[x] Create a comment in the #engineering-team slack channel with pending-but-not-merged MRs, potentially shipping. (Aka, the "burndown" list.)

Otherwise a comment that all known merge candidates are already merged.

[x] Create or link to a summary of MRs merged and/or expected in the #marketing Slack channel, with an @channel mention.

Release Checklist
Rotating assignee, on the morning of the release:

[x] Changelog updates and version bump:

[x] Check the pending MRs to make sure nothing expected is still waiting to be merged.
[x] Create a new branch named release/vX.Y.Z and a corresponding MR with the Release MR template.
An automated pipeline (linked to the branch prefix release/v*) will
immediately and automatically bump the version and flush the changelog.

[x] Check this box to confirm the automated changelog flush and version bump are correct.
You do not need to wait for the CI pipeline. (An identical CI pipeline is already included in the below.)

[x] Cut a release tag from your release/vX.Y.Z branch (not from main) named vX.Y.Z with Message=Release vX.Y.Z

In response to new tag creation, these steps are performed automatically in Gitlab pipelines:

Abort if tag vX.Y.Z does not match output from poetry version --short
Test everything.
Publish to PyPi .

Validate publish once the pipeline finishes. (While the process is running, you can continue with next steps, such as changelog grooming.)

[x] Check this box when the tag's pipeline has completed (eta 40-60 minutes).
[x] Check this box when PyPi publish is confirmed.

Groom the changelog:

[x] Compare the Changelog against the main branch commit history and add any significant user-impacting updates (excluding docs and website updates, for instance).
[x] Review the Changelog for readability and typoes, committing fixes or updates if needed.
[x] Final changelog review:

Open the Changelog in preview mode, mouse over each link and ensure tooltip descriptions match the resolved issue.
Check contributor profile links to make sure they are correct.

[x] Merge the resulting MR to main with the merge commit message Release vX.Y.Z
[x] Open the next Release issue using the Release template.

Announcements, Marketing, and Promotion
Marketing or Product team:

[x] Post-release announcement steps:

[x] Post announcement to Meltano slack: #announcements

Copy-paste to:

[ ] Singer slack: #meltano
[ ] dbt slack: #tools-meltano

[ ] Blog post
[ ] Tweet the blog post

View 20 previous comments from the original issue on GitLab


Main as .ts?

This is not relatively an issue but have been wondering about the structure of the project. But would it be possible to redo the file structure to something along the lines of example-project. I would like to have my main process as a Typescript file and also have it bundled correctly.
Currently when this project bundles within itself instead of a distributed lone directory. I am working on making changes to do this but have yet to accomplish it while also keeping the hot loading working for development.

I would like to see this as well. I am actually trying to load a typescript file into main.development.js and am having a bit of difficulty.

I think the core problem here is that the typescript is being output to /dist and the application is being run from /app so the generated js is out of scope for electron. Not sure on the way to properly fix this. This config also does not work if you have multiple windows that have different .html files as source.

@oullah I was able to do what I wanted and keep the really the structure of both the way they are. I simply moved his entire /app directory into the renderer folder and removed everything else.  I created a /main directory and placed in the main.ts file. I left the app.html alone but edited the index.tsx to this.
const rootElement = (
    <AppContainer>
        <Root store={store} history={history} />
    </AppContainer>
);
const main = document.createElement('main');
(document.querySelector('body') as HTMLElement).appendChild(main);
render(rootElement, main);

if ((module as any).hot) {
    (module as any).hot.accept('./containers/Root', () => {
        const NextRoot = require('./containers/Root').Root;
        render(
            <AppContainer>
                <NextRoot store={store} history={history} />
            </AppContainer>,
            document.getElementById('root') as HTMLElement,
        );
    });
}

After that I just made sure the build was correct with the webpack files separated for development and for building and made sure that package.json was pointing at the right dist location. And bam. It works just like this project in development and like the other project in build.


Add more info about root vs provider in docs

The Provider docs needed to have a little more info relating to the use of certain props and when nesting makes sense. I also changed a few examples to remove things like setting scale since we do not advise people to do that.
Updated the descriptions.

Docs: https://reactspectrum.blob.core.windows.net/reactspectrum/54f2f65135a70b886c79233828f5ed0f7e7e3ec5/docs/react-spectrum/Provider.html


feat(syntax/stdlib): add base64_decode helper function

PR Description
This adds base64_decode helper function into Alloy's standard library.
Which issue(s) this PR fixes

Closes #948
Notes to the Reviewer
PR Checklist

[x] CHANGELOG.md updated
[x] Documentation added
[x] Tests updated

@hainenber Looks like a quick conflict resolution for you and we can get this one merged :-)

Conflict resolved :D


Complete instruction

I lost about half of hour, cause I forgot to require extension in my handler

This is mentioned in the extensions documentation but certainly couldn't hurt to show here too. Thanks!


Add Hyperlink to VATUSA Profile on Visitor Application Page

Your Vatsim CID
1340265
What do you suggest?
On the visitor application page, add a hyperlink to their VATUSA profile, like https://www.vatusa.net/mgt/controller/1652726. I'm unsure if VATUSA API has one for visiting checklists, but having that checklist on the visiting application page is also nice.
Why do you need that?
convenience.
Alternatives
No response
Additional info
No response
Validation

[X] I have searched for other requests and did not find any alike
[X] I have also checked the roadmap, and this is not planned

This would be in then facility admin page correct?

https://vzdc.org/admin/visitor-applications under individual applications

This will be marked as a feature in the 1.2.0 update.

Done in next update


Harden ResinOS kernel

We should activate some hardening kernel configuration, here is a list of kernel hardening configuration options for the kernel: https://kernsec.org/wiki/index.php/Kernel_Self_Protection_Project/Recommended_Settings
I want to highlight:

CONFIG_CC_STACKPROTECTOR=y
CONFIG_CC_STACKPROTECTOR_STRONG=y

FD: https://www.flowdock.com/app/rulemotion/r-security/threads/ZXIGjUS1p-jgJ7bSXcUSIb-CaIc

See #846

@afitzek the stack protector options have been enabled. I'm not sure if there are any other items in the list that you think would be good to enable?
It's not always easy to tell how restrictive an option might be for users or how it might affect performance.

Ping @afitzek . Given that stack protector options where enabled, can we close this issue?

Closing for now.


Fixes for uninstall

I can confirm that it fixes the skipping mlflow part, note that it is also removing the fuseml-workloads namespace which deletes everything inside it such as tekton tasks, inference services, etc... But I guess that is ok since we will be moving mlflow to its own namespace.
Regarding kantive the installer fails with the following message:
namespace "kfserving-system" deleted
Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
customresourcedefinition.apiextensions.k8s.io "inferenceservices.serving.kubeflow.org" deleted
customresourcedefinition.apiextensions.k8s.io "trainedmodels.serving.kubeflow.org" deleted
Warning: admissionregistration.k8s.io/v1beta1 MutatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 MutatingWebhookConfiguration
mutatingwebhookconfiguration.admissionregistration.k8s.io "inferenceservice.serving.kubeflow.org" deleted
Warning: admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
validatingwebhookconfiguration.admissionregistration.k8s.io "inferenceservice.serving.kubeflow.org" deleted
validatingwebhookconfiguration.admissionregistration.k8s.io "trainedmodel.serving.kubeflow.org" deleted
serviceaccount "kfserving-models-web-app" deleted
role.rbac.authorization.k8s.io "leader-election-role" deleted
clusterrole.rbac.authorization.k8s.io "kfserving-manager-role" deleted
clusterrole.rbac.authorization.k8s.io "kfserving-models-web-app-cluster-role" deleted
clusterrole.rbac.authorization.k8s.io "kfserving-proxy-role" deleted
rolebinding.rbac.authorization.k8s.io "leader-election-rolebinding" deleted
clusterrolebinding.rbac.authorization.k8s.io "kfserving-manager-rolebinding" deleted
clusterrolebinding.rbac.authorization.k8s.io "kfserving-models-web-app-binding" deleted
clusterrolebinding.rbac.authorization.k8s.io "kfserving-proxy-rolebinding" deleted
configmap "inferenceservice-config" deleted
configmap "kfserving-config" deleted
configmap "kfserving-models-web-app-config-9kkt28dhgb" deleted
secret "kfserving-webhook-server-secret" deleted
service "kfserving-controller-manager-metrics-service" deleted
service "kfserving-controller-manager-service" deleted
service "kfserving-models-web-app" deleted
service "kfserving-webhook-server-service" deleted
deployment.apps "kfserving-models-web-app" deleted
statefulset.apps "kfserving-controller-manager" deleted
virtualservice.networking.istio.io "kfserving-models-web-app" deleted
Error from server (NotFound): error when deleting "https://github.com/fuseml/extensions/installer/kfserving/kustomize": the server could not find the requested resource (delete certificates.cert-manager.io serving-cert)
Error from server (NotFound): error when deleting "https://github.com/fuseml/extensions/installer/kfserving/kustomize": the server could not find the requested resource (delete issuers.cert-manager.io selfsigned-issuer)
: exit status

Ah, removing namespace by extension should not be done when it is using the default namespace.
The second problem is weird, I think this should be fixed by https://github.com/fuseml/fuseml/pull/180/commits/24ef63042d7b70f8a47a6619a3077d6e5d330b75 ... I have to investigate again

@flaviodsr however, both items you mention cannot be solved in this repo, so I think this PR actually does not need any changes


Removed inference from [TypeName] and underscore

Closes #1303
Please review

[ ] @gmarz / @Mpdreamz

+1 for removing support for infirring [TypeXName]Id and [TypeXName]_Id properties on instance of TypeX in 2.0.
Very obscure and hardly used feature. @gmarz agree?

Also this PR has to be targeted against the 2.0 branch

Yea, definitely agree.  I didn't even know this feature existed until you opened this issue. :)

Not longer valid.


[PATCH] Fix backend API issues, refactor database, and improve structure

Change Summary

Fixed various backend API issues related to user access and data integrity.
Refactored database schema (Models) to improve relationships and indexing.

Did you add field to tell if user is poster or bidder in the token

@SodaVolcano  gonna merge this with ignoring your requested file change cuz I think new changes should base on the refactored api design


Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

I have this error when switching between iron-lazy-page instances:
Uncaught NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

only appears on second load of iron-lazy-page children element
related to Polymer upgrade to 1.6.0

An example as here, the file containing iron-lazy-pages is this one.
(try clicking between tabs multiple times).
The row which causes the issue is follow:
document.head.removeChild(e.target || e.srcElement);

Opened a pull request to fix this issue in #23, please take a look.


🐛 bug: fix selectedRows repeat problem

close #502
close #513

close https://github.com/ant-design/pro-table/issues/540


Expose LocalStorageHelper for storage testing

Fixes https://github.com/GoogleCloudPlatform/google-cloud-java/issues/859

LGTM

Coverage decreased (-0.08%) to 80.983% when pulling 7c29209e00fc8f343d47d59d1c81a612e160145f on shinfan:docs into 50e37e624a8e7a8eb8087d90fb9f001a1654a980 on GoogleCloudPlatform:master.

Coverage decreased (-0.09%) to 80.97% when pulling 65ca307895e8108c7e091146a6083c2d7a51c47d on shinfan:docs into 50e37e624a8e7a8eb8087d90fb9f001a1654a980 on GoogleCloudPlatform:master.

Changes Unknown when pulling a390c9e510b0afd5a002876d4057f07315bf5513 on shinfan:docs into ** on GoogleCloudPlatform:master**.

Changes Unknown when pulling a390c9e510b0afd5a002876d4057f07315bf5513 on shinfan:docs into ** on GoogleCloudPlatform:master**.


Sample Improved and two major bug fixes

Two Major Bug fixes :-

null pointer when user not initialised mapColorForTab.
null layoutParams issue

and improved sample for users

bug fix when there is no parent for view in attach method and also when user might not have called mapColorForTab in that case the hashMap will be null and app crashes.
improved samples so users can check different ways to add bottom-bars easily

The colorMap is already initialized properly if null in the mapColorForTab() method, so it won't be null afterwards.
I'll look into the other stuff when I can though, thanks.

@roughike in your mainActivity try removing all five mapColorForTab, and test. It will crash

Holy shitballs, you're right! Will merge ASAP.


Translating to spanish

Hello!
I want to be part of this aweome project.
I see that almost all the chapters but the OpenTracing one are done...  Do you mind if I start translating it to spanish ? maybe some others can help translating it to another languajes too :smile:

Hi @Motojo, that would be an honor :) and if you would like to help me with the OpenTracing chapter too it's all open :)

Hi @Motojo and @cicekhayri , I can help too with translation into Spanish.
Does the approach of creating a new branch make sense base on current project structure? or do you have already agree on a different approach to managing internationalization?
So far it seems full internationalization via asciidoctor is still a WIP with good progress but not fully supported: https://github.com/asciidoctor/asciidoctor/issues/1129

Hi @Motojo and @cesarhernandezgt
I don't know if this is still up, because I missed to answer you guy sorry about that,
We haven't agreed on any approach


handleSubmit swallows errors thrown in onSubmit functions

I was having an issue where I was getting SET_SUBMIT_FAILED on every submit, even though my form had no validation errors. The error would come back empty. After digging into handleSubmit, it turns out that the try here will catch any type of error and will only give you error messages if caught error has submitError.errors.
https://github.com/erikras/redux-form/blob/master/src/handleSubmit.js#L20
      try {
        result = submit(values, dispatch, props);
      } catch (submitError) {
        var error = submitError instanceof _SubmissionError2.default ? submitError.errors : undefined;

In my case, I had a type error in my onSubmit function that was very hard to track down. Should we just rethrow if the error is a general runtime error? Something like this:
      try {
        result = submit(values, dispatch, props);
      } catch (submitError) {
        var error = submitError instanceof _SubmissionError2.default ? submitError.errors : undefined;
        if (!error) throw submitError;

I've been wondering about this too.
I think rethrowing errors that aren't SubmissionError objects is a great idea, but perhaps I'm missing some important scenarios where doing that would be problematic.
If the user has defined a onSubmitFail function, then perhaps it is better to pass the error to that callback rather than rethrowing the error, but then the onSubmitFail function wouldn't know whether it will be receiving a JavaScript error or a hash of validation errors, which would complicate the onSubmitFail API.
At any rate, as it stands now, if you have a legitimate non-validation error in your onSubmit function, you have no way of seeing the error unless you wrap your onSubmit function in a try/catch and log the exception. This is particularly cumbersome during development where errors from typos or undefined references are common.

Actually, passing the error to onSubmitFail was what I originally expected.
I like that idea best so far.
On Fri, Sep 23, 2016 at 12:19 PM Nathan<EMAIL_ADDRESS>wrote:

I've been wondering about this too.
I think rethrowing errors that aren't SubmissionError objects is a great
idea, but perhaps I'm missing some important scenarios where doing that
would be problematic.
If the user has defined a onSubmitFail function, then perhaps it is
better to pass the error to that callback rather than rethrowing the error,
but then the onSubmitFail function wouldn't know whether it will be
receiving a JavaScript error or a hash of validation errors, which would
complicate the onSubmitFail API.
At any rate, as it stands now, if you have a legitimate non-validation
error in your onSubmit function, you have no way of seeing the error
unless you wrap your onSubmit function in a try/catch and log the
exception. This is particularly cumbersome during development where errors
from typos or undefined references are common.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/erikras/redux-form/issues/1859#issuecomment-249236692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAkAtG9mxAMuxcrZWmJ96peMkn0Mm6oks5qs_vcgaJpZM4KFH8b
.

Just ran into this. Would greatly appreciate a solution that surfaces errors thrown in onSubmit instead of failing silently!

After looking at it more, I do think the simplest, most elegant solution is to just set error to submitError and let it get pushed into the onSubmitFail in user space. Happy to do a PR if we like that.
      try {
        result = submit(values, dispatch, props);
      } catch (submitError) {
        var error = submitError instanceof _SubmissionError2.default ? submitError.errors : submitError;

On second thought, I think an error should be thrown if result = submit(values, dispatch, props); immediately. If we weren't using try/catch, this would be what would happen and I don't think we should be propagating the runtime errors from user code into callbacks, I think it should blow up immediately.

Related: https://github.com/erikras/redux-form/issues/1709

Is there a workaround for this issue? It would be nice to see the errors.

@akhayoon If you wrap your passed function in a try/catch you can print the errors before they're caught and swallowed.

Just ran into this. It doesn't just swallow the error, but the call to stopSubmit(error) actually sets submitSucceeded to true. I needed to manually rethrow a SubmissionError with something inside the errors property to avoid this.

Interestingly enough I was looking at this bug for another reason 4 days ago (can't remember exactly why), but ran into the issue of not knowing why my form wasn't showing SubmissionError's.
Apparently I had forgotten to import SubmissionError, and since it was silently swallowing errors raised from my Promise I didn't realise that was going on... Trying to code tired is probably also not a good idea, but that threw me for a loop!

@akhayoon It's possible, but error prone, and then you have to handle SubmissionError separately.

Might be going against the grain here, but I'd honestly expect anything outside SubmissionError (or whatever other validation errors) to be re-thrown, rather than caught and handed to onSubmitFail. At the very least, it should probably be passed to a separate function (like onSubmitError)
Just ran into this today, took quite a bit of debugging before realizing handleSubmit was obscuring all errors.

I have the same issue, but even when i get to send a submission object, the validation const error = submitError instanceof SubmissionError ? submitError.errors : undefined doesnt work because the compiled file has this code submitError instanceof _SubmissionError2.default.
I know they are the same class, it is just the webpack build, but the typeof my submissionError it is different from an object created with _SubmissionError2.default, and the are both 'SubmissionError'

I ran into another issue with stopSubmit() setting submitSucceeded to true, which is that I do a transition to another page when submitSucceeded == true, which unmounts the form (thus destroying it). Then the line after stopSubmit() is setSubmitSucceeded(), which will set submitSucceeded on the destroyed form. This means when going back to the previous page, submitSucceeded == true and it will attempt the transition again. Hope that made sense. :smile:

I also ran into this issue. Took me (with little javascript debugging experiencs) about 2 hours to figure out that handleSubmit was silently swalloing the error. Could have been a matter of 2mins otherwise. I always advocate rethrowing / not cathing exceptions that you cannot handle. So I would be really grateful if this could be fixed. I think it would be rather strange to have to register an ExceptionListener in order to get to the Exception. That could be a valid scenario for production code, though.

Ran into the same problem. The exception was thrown in a reducer's case and I had to first figure out whether the case was reached, then at which point it "stopped", figure out why and eventually figure out why the exception was being swallowed and by who. This was tricky since nothing on the UI was changing and nothing was logged in the console.

Agree with most in this issue.  We need to re-throw the exceptions.

Fix published in v6.2.0.


The confusing positional arguments in the definition of focal loss

Hi, I think you have a small but quite critical mistake in: https://github.com/qubvel/segmentation_models/blob/ba5cfca2b30be14050304096dba2fe0963b588e3/segmentation_models/losses.py#L238
In here, the arguments aboved are passed to the function below in the form of positional arguments: https://github.com/qubvel/segmentation_models/blob/ba5cfca2b30be14050304096dba2fe0963b588e3/segmentation_models/base/functional.py#L286
Here comes the confusing part. I think the value of alpha which we expect it to be, is replaced with the value of gamma. The same thing happens to gamma, too. But I'm not 100% certain about this.
If anyone sees this issue, I hope you can give a clear answer.

One more thing, the implementation of binary focal loss here may be slightly different from the formula of widely accepted binary focal loss.
This issue https://github.com/qubvel/segmentation_models/issues/187 explain this problem.
@qubvel Hope you can help with this.

Hi @LeeJayHui
Thanks for pointing out about mostake in positional arguments! Can you create a PR to fix it?
About alpha coefficient.. It not clear (for me) from paper is it should be alpha and (1 - alpha) or just alpha. Because in paper it is noted as alpha_t without description.

I make a fix about positional arguments #259 , but if you would like to contribute, I will merge your PR.
What happens with alpha in case of categorical focal loss if for binary we have alpha and (1 - alpha)?

Thanks for your reply and confirm @qubvel . I check the paper https://arxiv.org/abs/1708.02002v2 and in section 3.1. Balanced Cross Entropy, the original paper goes as:

A common method for addressing class imbalance is to
introduce a weighting factor α ∈ [0,1] for class 1 and 1−α
for class −1. In practice α may be set by inverse class fre-
quency or treated as a hyperparameter to set by cross valida-
tion.

I think it means that in binary task, we should use (1-alpha) for the background class to address class imbalance.
I haven't created a PR yet. I am new to GitHub and Git. I am still trying to figure out how to use it. Thanks a lot to fix this problem. And this repository is really helpful. Good job!

I don't know how to reply your reply, so maybe all I can do is mention you.
@qubvel  As for multi-class focal loss, I think alpha is kind of confusing here.
Maybe it is potential to set alpha as the inverse class frequency. For example, assume we have ['dog', 'cat', 'rabbit'] and their corresponding frequencies are [0.1, 0.3, 0.6], we can set the alphas to be [1-0.1, 1-0.3, 1-0.6].
But from my perpesctive, muti-class focal loss is not widely used in CV tasks.

Ok, (1- alpha) sounds good for binary focal loss. Fix proposed in same PR #259
Will check this one more time and merge to master. You could install from source (see installation instructions in README) to get fixed version.

It would be nice if you check it also and report if something wrong, thank you!

Thanks a lot for your reply and fix! I have already modified the souce code in my local environment. And it did work. Good luck to your future job!
One last thing, I think the decoder parts here can be improved, too. Or we can add more choices of decoder. The plain stack of convolution/bn/act layers in decoder stages may not be the best choice. Any way, thanks again.

You are absolutely right, there are a lot of ways for improvement! If you have any ideas you can open a Pull Request and propose changes!


Cookie - http / https

How to implemet cookies for http/https video path (url) ?

videoInfo.addOption(Option.create(IjkMediaPlayer.OPT_CATEGORY_FORMAT, "headers", "Cookie: key=value\n"))

How to add multiple cookies


⚠ SkipTheCommericals has degraded performance

In d9150ec, SkipTheCommericals ($STC) experienced degraded performance:

HTTP code: 200
Response time: 1029 ms

Resolved: SkipTheCommericals performance has improved in 96382aa.


Fix code scanning alert no. 1: DOM text reinterpreted as HTML

Fixes https://github.com/dimagi/open-chat-studio/security/code-scanning/1
To fix the problem, we need to ensure that the value of data-redirect-url is properly validated or sanitized before it is used to set window.location.href. One way to achieve this is by using a URL parser to ensure the value is a valid URL and does not contain any malicious content.
We will:

Parse the data-redirect-url value using the URL constructor to ensure it is a valid URL.
Only set window.location.href if the parsed URL is valid.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!


archive endpoint should provide commit object

Feature Description
why
make easier to verify archive downloads by their commit hash
clients prefer the archive endpoint for better performance
but currently, it offers no way to validate the download by commit hash
git is a content-addressable filesystem
and versions are usually declared by their commit hash, not by their tree hash
reconstructing the commit object from the api endpoint is surprisingly painful (see my verify_github_api.py)
at least in the github commit api, the timezones are missing (committer time + author time)
so in the worst case, we must do 24*24 guesses to workaround github's lossy commit api
(i simply assume that the gitea commit api has the same bug ...)
also the api endpoint (usually) is rate-limited, where the archive endpoint is not
by including the commit object as http header, the client can get all data in one request
actual
curl --head https://gitea.com/gitea/awesome-gitea/archive/master.tar.gz
HTTP/1.1 200 OK
Set-Cookie: i_like_gitea=116b71d872546531; Path=/; HttpOnly; SameSite=Lax
Set-Cookie: _csrf=b1XrXHUJgvWdJZJexxFBQFFPWS46MTYzNzk5NDc4NTU5Mjk3OTAwOA; Path=/; Expires=Sun, 28 Nov 2021 06:33:05 GMT; HttpOnly; SameSite=Lax
X-Frame-Options: SAMEORIGIN
Date: Sat, 27 Nov 2021 06:33:05 GMT

expected
note the --header 'x-commit-object: 1' request header
and the X-Commit-Object: ... response header
curl --head --header 'x-commit-object: 1' https://gitea.com/gitea/awesome-gitea/archive/master.tar.gz
HTTP/1.1 200 OK
Set-Cookie: i_like_gitea=ed0c8886a6fb8c04; Path=/; HttpOnly; SameSite=Lax
Set-Cookie: _csrf=Hjlcjj5HJe1nH4Bwj4vnNoujUCs6MTYzNzk5NDkzNzY4MTgzMTA2OA; Path=/; Expires=Sun, 28 Nov 2021 06:35:37 GMT; HttpOnly; SameSite=Lax
X-Frame-Options: SAMEORIGIN
Date: Sat, 27 Nov 2021 06:35:37 GMT
X-Commit-Object: dHJlZSA4OGZiYTU0YTZlZjg0....Bub3JlcGx5LmdpdGVhLmlvPgo=

the X-Commit-Object response header is generated by
git clone https://gitea.com/gitea/awesome-gitea.git
cd awesome-gitea
git cat-file -p 4024c4771ff042cfb7971eaae8e3b9117945f491 | base64 -w0
dHJlZSA4OGZiYTU0YTZlZjg0....Bub3JlcGx5LmdpdGVhLmlvPgo=

edit: json -> base64, to ensure lossless encoding of binary data
verify the archive
when we have only the archive, we can compute the tree hash
in this case 88fba54a6ef84f7af70837885f0ab9db4ac6b073
to compute the commit hash, we also need the exact commit object
related

https://github.com/presslabs/gitfs/issues/378
Nix sha256 is bug not feature. solution: a global /cas filesystem

@milahu Could you send a PR to resolve that?

here is a start https://github.com/milahu/gitea/tree/send-commit-object-in-http-response-header
but im stuck ...
how do i get from gitea/routers/web/repo/repo.go
func addCommitObjectResponseHeader(ctx *context.Context, archiver *repo_model.RepoArchiver) {
	if ctx.Req.Header.Get("X-Commit-Object") == "1" {
		repo := ctx.Repo.Repository
		// FIXME type *models.Repository has no field or method GetCommitObject
		bytes, err := repo.GetCommitObject(archiver.CommitID)
		if err != nil {
			// TODO can we ignore this? CommitID should be valid here
			ctx.Resp.Header().Set("X-Commit-Object", "")
			ctx.Resp.Header().Set("X-Commit-Object-Error", err)
			return
		}
		str := base64.StdEncoding.EncodeToString(bytes)
		ctx.Resp.Header().Set("X-Commit-Object", str)
	}
}

to gitea/modules/git/repo_commit.go
func (repo *Repository) GetCommitObject(id SHA1) ([]byte, error) {
	// we need a bit-exact copy of the commit object for hash calculation
	// -p = print
	stdout, err := NewCommandContext(repo.Ctx, "cat-file", "-p", id.String()).RunInDirBytes(repo.Path)
	if err != nil {
		return nil, err
	}
	return stdout, nil
}

i guess i dont need archiver since all data is in ctx?
https://github.com/go-gitea/gitea/blob/dcdb4873c8d77a444526fad5b1c8e705fdfe149d/models/repo/archiver.go#L29-L36

ctx.Repo.GitRepo?

mkay. what would be a good place for a test?

I think you can write an integration test so you can visit some git repos. There is no ready git repo on unit test.

The commit object can be quite large. Why can't we just send the commit sha instead?

The commit object can be quite large.

so? bandwidth is cheap, the archive is usually 100x larger

Why can't we just send the commit sha instead?

trust no one : ) i want to verify the archive by its commit hash


"loaded" event in Meteor 1.3

seems to not get fired anymore in 1.3?

This happens only on initial build. After a HCP it works.
Maybe we need an "isLoaded" state before I add the "loaded" event?
I could not find something like this.

dang. nevermind. my fault.

the event is never called.
please see the code below:
Meteor.onStartup = ->
    Tracker.autorun( (computation) ->
        if(Ground.ready())
            Session.set("isLoading", true)
            LocalTags.addListener('loaded', ->
                Session.set("isLoading", false)
                console.log("Added LocalTags Listener")

...

The listener should not be applied in the startup+autorun - should be applied after definition

awesome. thank you.
However, a
Ground.loaded() and Collection.loaded()
would be a great addition.

I've released 2.0.0-alpha.1 Notes about the new version, migration and what it doesn't do - The issue might be resolved in that version, let me know what you think

@raix Is there any documentation on how to use events and listeners? I'm trying the code above and I'm not getting any signal.
I'd like a way to know: 1) that there is a cache available, 2) that the data is syncing 3) the data synced and is up to date.
Any ideas?
Ground.Collection(Report);
Tracker.autorun( function() {
    Report.addListener('loaded', function(){
          Session.set("isLoading", false)
          console.log("Added Report Listener")
      });
}

What version of ground db are you using?

The latest on Atmosphere, 0.3.15 , Thanks in advance!

you might want to tryout https://github.com/GroundMeteor/db/tree/grounddb-caching-2016 - this will soon be the latest - mind theres breaking behaviour (might get more backwards compatible)

Tak Morten, I didn't know you were working on a rewrite. Can you give an example of using the events, and what events are available. This is very helpful, looking forward to the release!

Hi, it currently seem stable - it's more limited on features that v1 compared to method call resume and offline tab sync - these might be added if needed (I've removed some of the magic and meteor ddp dependencies)
Note theres an example of semi backwards compability in https://github.com/GroundMeteor/db/tree/grounddb-caching-2016#need-a-near-backwards-compatible-solution - this might be added as a separate package if theres a need for it.
I've added documentation regarding events in: https://github.com/GroundMeteor/db/tree/grounddb-caching-2016#more


Update Copyright Notices to new format

Updates a bunch of ported copyright notices to the new simpler format.

Merged with #33.


React hooks exhaustive deps rule

Pull request opened by github-pullrequestcreator.

:tada: This PR is included in version 4.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Handling JSON and nested form data

I've attempted to use wtforms with JSON and nested FormField data, but it appears to be mostly unsupported. There are third party libraries such as wtforms-json which add support, but the code is quite dirty and of limited support.
This is a use case which I'd imagine is quite popular, as wtforms is arguably the best form validation library out there for Python.
Are there any plans to add support into the core for JSON? Could a core maintainer indicate whether such a feature request would be accepted? I'm happy to contribute time into a PR to make this happen.
EDIT: It seems that in 2.0 there has already been some preparations towards this, such as the addition of data into Form constructor.

Please ignore this issue, it seems that JSON is working perfectly fine with the data attribute of Form. If I get any further problems I'll re-open, apologies for the wasted time.

DO NOT pass user input to data or as a kwarg to a form because it is not validated! It's used as the default value for a field.

Thanks for the reply, I was actually due to update this issue in the morning as I already ran into problems and noticed that validators/coercion was not working correctly. I attempted to use obj but this didn't work either. As it seems the original issue is still valid, I'll re-open this.

Yea, would be great to have this built into wtforms. Thanks for bringing this issue up!

https://github.com/nicolaiarocci/cerberus
Might be of interest if only dealing with APIs...

This issue is very important, something should be done about supporting decoded JSON in WTForms. ATM event BooleanField doesn't work correctly (see https://github.com/wtforms/wtforms/blob/master/wtforms/fields/core.py#L692), not to mention FieldList and FormField.
@foxx May I ask what you ended up doing?

@roganov I got rid of it and used Colandar instead. It takes a day of getting used to, but it's far more powerful.

Planned for WTForms 3.0 #154

Also schematics is a good alternative, I prefer it more than Colandar.

Is this feature still on the 3.0 roadmap?
I suppose handling JSON inputs would require new fields. At least DictField to validate dicts, that is a notion absent from regular POST forms.
What would be the API for this? Adding a json parameter to Form that would be mutually exclusive with formdata? Or maybe we can add a datatype parameter that could be set to either formdata or json.

I think full JSON validation is better left to more API-focused libraries such as Marshmallow or the others mentioned above.
I don't think we'd need a DictField, as there's no notion of a dict in HTML forms. The requirement isn't to validate arbitrary JSON but to validate form data passed as JSON. I think there's two main things causing issues. First, fields only accept string data, so passing a bool to a bool field fails. Second, nested data (dict or list) should be flattened into the keys WTForms expects. These can be treated as two separate issues and don't have to block 3.0.


feat: add boost iterator, numeric_conversion, ratio

as title
need skip url stability check

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.iterator, boost.numeric_conversion, boost.ratio) have been updated in this PR. Please review the changes.


Type specific default options

While using toastr in my project I realised that I really wanted different default options per toast type (info/warning/error/etc.).
I could make a wrapper but that feels redundant given how simple the wrapper would be.
I can do the work and I can do it without causing a breaking change, but I wanted to make sure that maintainers agree it's worth implementing.

this is what I expect would be awesome
toastr.load(status,message,blah);

I'm not sure I understand the load function. I'm suggesting something that isn't message specific, by building it into the global options object. Something like this.
toastr.options = {
  // default options
  "closeButton": false,
  "debug": false,
  "newestOnTop": false,
  "progressBar": false,
  "positionClass": "toast-top-right",
  "timeOut": 3000,
  "extendedTimeOut": 3000,
  ...
  "typeoverrides": {   // takes 0 or more of the available toast types
    "error": {   // toast type as object key
       // subset of option properties valid in calls to toastr (i.e. toastr["error"](msg, opts) )
      "timeOut": 0
    },
    "warning": {
      "progressBar": true
    }
  }
}

My thinking is that options would remain hierarchical as they are currently. So that toastr.error(msg, calloverrides) would use global -> global.typeoverrides.error -> calloverrides to determine the final set of options to use for the call.
What do you think? Is this in keeping with the design principles of the project?

Turns out this is about 5 lines so I did it and will publish it as a PR. The new property is
options = {
  typeBasedOverrides: {
    info: {},
    success: {},
    warning: {},
    error: {}
  }

This would be very fine! I was just thinking that I'd like to persist error and warning messages instead of fading them after a while (while keeping success messages fading)
Hope it would be implemented soon! :-)

I have already implemented it and suitted a push request. I'm waiting on
acceptance.
https://github.com/CodeSeven/toastr/pull/574
On Fri, Jun 22, 2018, 5:13 AM Ivan<EMAIL_ADDRESS>wrote:

This would be very fine! I was just thinking that I'd like to persist
error and warning messages instead of fading them after a while (while
keeping success messages fading)
Hope it would be implemented soon! :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CodeSeven/toastr/issues/571#issuecomment-399377465,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE3RvyKVVmN5s0SlRPdipFQFOEkq6RIhks5t_LUsgaJpZM4UOwsT
.

--
-- John Schram

I really could use that too. Is this gonna get merged soon by any chance? Thanks.


Autolinking is not working with android

Bug
The component is not found without doing the manual linking with Android.
Environment info
react-native: 0.61.2
@react-native-community/viewpager: 3.3.0

Hey, it works. Please checkout https://github.com/troZee/viewPagerExample/commits/master


Bug - Using Ore() for >16 veins is impossible, where 16 causes crashes and < 16 works fine.

Edit: This only occurs in air, as far as I know. But stone seems fine, which is now obvious to me.

Hey, thanks for reporting this. Will see when I can improve this to at least not crash and/or add a note in the documentation.

Will need to create a test world and get a crash report. Will do after v7 since it probably won't affect many people.

[21:57:11] [Server thread/ERROR] [minecraft/MinecraftServer]: Encountered an unexpected exception
java.lang.RuntimeException: Whatever it is you're trying to do, we didn't write any code for it (sorry). Please contact Team OTG about this crash.
    at com.pg85.otg.forge.ForgeWorld.setBlock(ForgeWorld.java:841) ~[ForgeWorld.class:?]
    at com.pg85.otg.generator.resource.OreGen.spawn(OreGen.java:128) ~[OreGen.class:?]
    at com.pg85.otg.generator.resource.Resource.spawnInChunk(Resource.java:195) ~[Resource.class:?]
    at com.pg85.otg.generator.resource.Resource.process(Resource.java:152) ~[Resource.class:?]
    at com.pg85.otg.generator.ObjectSpawner.populate(ObjectSpawner.java:259) ~[ObjectSpawner.class:?]
    at com.pg85.otg.forge.generator.OTGChunkGenerator.func_185931_b(OTGChunkGenerator.java:203) ~[OTGChunkGenerator.class:?]
    at net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1019) ~[axw.class:?]
    at net.minecraft.world.chunk.Chunk.func_186030_a(Chunk.java:999) ~[axw.class:?]
    at net.minecraft.world.gen.ChunkProviderServer.func_186025_d(ChunkProviderServer.java:157) ~[on.class:?]
    at net.minecraft.server.MinecraftServer.func_71222_d(MinecraftServer.java:344) ~[MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.func_71247_a(IntegratedServer.java:186) ~[chd.class:?]
    at net.minecraft.server.integrated.IntegratedServer.func_71197_b(IntegratedServer.java:209) ~[chd.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486) [MinecraftServer.class:?]
    at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]

Followed by everyone's favourite, impossible to pin down savetodiskloop:
[21:57:16] [Server thread/INFO] [OTG]: SaveToDisk waiting on Populate. Although other mods could be causing this and there may not be any problem, this can potentially cause an endless loop!
All just from putting this in the resource queue: Ore(STONE:1,48,10,100.0,0,256,AIR) while Ore(STONE:1,48,10,100.0,0,256,STONE) causes no issues.

Won't cause a crash anymore for v8_r2


ZAdd with incr option return string instead of number

Hi,
I'm trying to port this library to a Dart package and when implementing ZAddCommand and writing the same test I found that the test is not written for incr, it just copied from previous test.
here the test in zadd.test.ts file
Deno.test("incr", async (t) => {
  await t.step("returns the number of changed elements", async () => {
    const key = newKey();
    const member = randomID();
    const score = Math.floor(Math.random() * 10);
    await new ZAddCommand([key, { score, member }]).exec(client);
    const newScore = score + 1;
    const res = await new ZAddCommand([
      key,
      { ch: true }, // it should be { incr: true }
      { score: newScore, member },
    ]).exec(client);
    assertEquals(res, 1);
  });
});

Then when I change to incr the result will return as a String instead of number, and that cause to throw exception as ZAddCommand result should be number or null according to the result bound.
here the dart code
group('incr', (){
    test('returns the number with added increment', () async {
      final key = newKey();
      final member = randomID();
      final score = 10;
      await ZAddCommand.single(key, score: score, member: member).exec(client);
      final newScore = score + 1;
      final res = await ZAddCommand.single(
        key,
        score: newScore,
        member: member,
        opts: zAddBy(incr: true),
      ).exec(client);
      expect(res, score + newScore);
    });
  });

So does it is a bug or should ZAddCommand handle both number and string as a result?
Thank you

Hey @rebaz94
Good catch!, I've fixed the test but it returns correctly as number. Javascript is pretty loose when it comes to types, so maybe that's why it works in javascript but not in dart?
According to the redis specs it returns a number as string, so you need to manually convert that to number in your client.
Btw, awesome to see a client in dart, I'd love to check it out!

Thank you for the quick response.
Yes I handled manually to convert to number.
I just started the implementation, will open source it soon if I have time to complete it. If you interested to give some advice let me know I will add to the git before I implement all commands.

yes I'd appreciate if you add me, so I can check it out.
I have never used dart before, but maybe I can help.
and thank you for open sourcing it, I'm sure others will appreciate it as well.
I'll close this for now, please open another issue if you find something else.


[v2.6] Update Chinese translation

Update Chinese translation for Rancher v2.6

Bumping e2e test


bugfix: Fix order of StorageReadRequest arguments extracted from memory

Codecov Report

Merging #519 (2fd4d2d) into main (d426de0) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #519   +/-   ##
=======================================
  Coverage   86.96%   86.96%
=======================================
  Files          53       53
  Lines        9976     9976
=======================================
  Hits         8676     8676
  Misses       1300     1300

Impacted Files
Coverage Δ

src/core/syscalls/syscall_request.rs
0.00% <0.00%> (ø)


Extended subgroups - Add support for extension cl_khr_subgroups_extended_types

Contributes to #532
Initial version. Add support for extension cl_khr_subgroups_extended_types

Thanks for pushing this! My initial reaction is that it's a bit on the big side for a single PR. A few comments:

I can't tell the purpose of the first commit. This will at least need a commit message.
The second commit contains changes that don't relate to cl_khr_subgroups_extended_types. These should be removed.
There are a number of trivial (whitespace, float->cl_float, etc) changes. Maybe we could land these  first to reduce the amount of noise? Although there aren't that many of them...
I'm concerned with the maintainability of all these templates which seem to duplicate a lot of code. Have you considered refactoring the existing test to use data tables for all the types? This should make extending the list of types pretty simple.

This is needed in further implementation - need to switch to vector of 4 elements. Then I have ability to send information to work item kernel e.g which broadcast id should be. Previously solution when generated data and broadcast id is the same value was problematic.
ok I will prepare once again but not sure which you mean are not related with cl_khr_subgroups_extended_types
ok I will try to separate them
regarding refactoring. I was thinking about this but I was lost in this Kingdom of Templates :) Because there was a lot of work with this group of subgroup extensions  I decided first implement with adjustment to existing code. My recommendation is to leave it as is and create new task for refactoring. I think code duplication is hard to reduce in this case.


Printable form of type from runtype?

I'm building a small framework for web applications and I use Runtypes for built in request validation. I'm a big fan of verbose error messages (at least on dev, prod is another thing).
I'd like to not just return the exception contents but also the whole structure of the Runtype when a validation error occurs. Maybe event with some sort of prose.
In combination with #41 this would empower Runtypes be the complete solution to build stable, comprehensible APIs.
Is there already a way to do this that I did not see? If not, anybody else interested? I could work on a PR.

Sorry for being late, let's track this at #236!


Add SystemLocale Resource - Fixes #50

Pull Request (PR) description
This PR migrates SystemLocale from SystemLocaleDsc.
This Pull Request (PR) fixes the following issues

Fixes #50

Task list

[x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
Entry should say what was changed, and how that affects users (if applicable).
[x] Resource documentation added/updated in README.md in the resource folder.
[x] Resource parameter descriptions added/updated in schema.mof
and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Resource Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
[x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing this one?

This change is

Codecov Report

Merging #280 into dev will increase coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff          @@
##            dev   #280    +/-   ##
====================================
+ Coverage    88%    88%   +<1%
====================================
  Files        14     15     +1
  Lines      1483   1526    +43
====================================
+ Hits       1308   1351    +43
  Misses      175    175

Hi @johlju - if you're looking for something to do, you could review this one for me? :grin:

Haha will do! 😄

@johlju - actually, hold off for a moment- I think something has happened with the rebase :cry:

I think I'll recreate this PR because during the change I renamed a localization folder to correct the case, and it has made the rebase "problematic". I think I'll just recreate this branch and PR to be safe.

Okay! Tag me and I will start the review on the new PR :)


Remove weird $HARVEY check in build

build was checking if you have HARVEY set and, if so, not
adding util/ to your PATH. Fix that because it caused weird
problems.
Signed-off-by: John Floren<EMAIL_ADDRESS>

LGTM


Export type including all options (OptionValues fields as well as cli fields)

Configuring the tool via a JS should support typing the exported object with an accurate type exported by this module. The closest existing type currently seems to be OptionValues, which does not include all the fields that are available (e.g. conn, output).
There should be an exported type that includes all options.

I realize now that configuration files are only supported in JS, so this use case is not all that relevant (feel free to close)


WIP: Display Map Depending on the Forecast

Hi Jalibu,
great module, I love it! I also like the "displayOnlyOnRain" option, however, I noticed that the map is usually shown too late with the option enabled for my liking. I especially need the map when it does not rain just yet, to estimate if it makes sense to quickly go outside before the rain or stay inside until it passed by.
As I have an hourly forecast (default weather module with OpenWeatherMap) running anyways, I implemented a feature based on the emitted 'WEATHER_UPDATED' notification and replaced the boolean "displayOnlyOnRain" option with a numeric "displayHoursBeforeRain". As the name suggests, the module will check if it will (by forecast) rain within the given number of hours, and if it will, display the module - or otherwise hide it. Setting the value to Infinity or 0 will have the same effect as the "displayOnlyOnRain" option before, so no functionality is lost.
I just implemented it today and still have to do some more tests to make sure everything works as expected, but I already wanted to ask what you think about this idea and if you are willing to integrate it. :)

Me gusta!
It brings great value when the map announces the rain BEFORE it is there :-D
Thanks for your contribution. I'll take a look at it over the next week.

@Jargendas can you please open a PR against dev?

Okay, I integrated your comments and changed the PR to be against dev.
Last week, it rained a lot where I live and the map appeared always when I needed it, so it seems to work well. :)


TextStyles.RESET does not work properly

For example this code -
private static Text getDescription(CommandSource source, CommandMapping mapping) {
    final Optional<Text> description = mapping.getCallable().getShortDescription(source);
    final Text.Builder text = Text.builder("/" + mapping.getPrimaryAlias());
    text.color(TextColors.GREEN);
    text.style(TextStyles.UNDERLINE);
    text.onClick(TextActions.suggestCommand("/" + mapping.getPrimaryAlias() + ""));
    mapping.getCallable().getHelp(source).ifPresent(t -> text.onHover(TextActions.showText(t)));
    text.append(Text.of( " ", TextStyles.RESET, TextColors.WHITE, description.orElse(mapping.getCallable().getUsage(source)))).build();
}

Causes the underline to remain on the following white text

While this code causes there to be no underline, using Text.of() instead and not resetting the style.
private static Text getDescription(CommandSource source, CommandMapping mapping) {
    final Optional<Text> description = mapping.getCallable().getShortDescription(source);
    final Text.Builder text = Text.builder("/" + mapping.getPrimaryAlias());
    text.color(TextColors.GREEN);
    text.style(TextStyles.UNDERLINE);
    text.onClick(TextActions.suggestCommand("/" + mapping.getPrimaryAlias() + ""));
    mapping.getCallable().getHelp(source).ifPresent(t -> text.onHover(TextActions.showText(t)));
    return Text.of(text, " ", description.orElse(mapping.getCallable().getUsage(source)));
}

The issue of the code here is that the white text is structually inside of the  underlined Text thus inherits that properties. (The reset does not know that there have been underlines in the first place.) The second example properly gives the Text an equal hierarchy.
The RESET would work if everything is created in one Text.of().

As far as I was aware, this is works as intended.

text.append(Text.of( " ", TextStyles.RESET, TextColors.WHITE, description.orElse(mapping.getCallable().getUsage(source)))).build();

You are appending a child composite text. If you were appending each of those, without constructing a child text it would be fine.


fix: writebuffer size not include the null terminating

writebuffer not include the null terminating char

Codecov Report

Merging #72 (3317a31) into master (2a48a60) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   95.78%   95.78%
=======================================
  Files          21       21
  Lines        2444     2445    +1
=======================================
+ Hits         2341     2342    +1
  Misses        103      103

Impacted Files
Coverage Δ

include/sonic/writebuffer.h
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix AsyncImage CornerRadius not working

Adds ClipToBounds=True to AsyncImage's Border to have CornerRadius working properly

@dotnet-policy-service agree


Add ability to load ca bundle from data

SSLContext.load_verify_locations allows to specify cadata with 2.7.9+, 3.4+

Thanks for this! Some notes:

Firstly, this patch contains changes to the urllib3 project. This is a sub-project vendored in its entirety unchanged into Requests.  That means any changes to urllib3 need to be made on that project, and they will then make their way into Requests over time.
Secondly, I am not sure how important this patch is. In the current Requests release it is possible to pass a SSLContext in to a transport adapter, as discussed in a few other issues (e.g. here). This means it's already possible to use cadata, which drastically reduces the urgency of this patch.
Thirdly, I suspect in v3 we'll want to refactor this so that verify can accept an SSLContext directly, rather than continuing to overload it with more stringly-typed inputs.

Because of the first reason I cannot merge this patch directly: you'd need to open a PR on urllib3 first. However, you may want to consider whether it's worth pursuing the "pass an SSLContext" approach instead.

Agree, passing custom SSLContext solves the issue.
Could you update documentation to better reflect that?

@Lukasa One question: won't implementation of ssl_wrap_socket override custom CA certificates by calling load_verify_locations inside?

@Lukasa That's how I did it so far:
from requests.adapters import HTTPAdapter

class CustomSSLContextAdapter(HTTPAdapter):
    def __init__(self, *args, ssl_context=None, **kwargs):
        super().__init__(*args, **kwargs)
        self._ssl_context = ssl_context

    def init_poolmanager(self, *args, **kwargs):
        kwargs['ssl_context'] = self._ssl_context
        return super().init_poolmanager(*args, **kwargs)

It's certainly possible. You may need to make further adapter overrides so you can set ca_certs and ca_cert_dir to None.

@Lukasa Something like this:
class CustomSSLContextAdapter(HTTPAdapter):
    """
    HTTP adapter with custom SSLContext.

    >>> from requests.sessions import Session
    >>>
    >>> with Session() as session:
    >>>     session.mount('https://', CustomSSLContextAdapter(ssl_context=...))
    >>>     session(method=..., url=..., ...)
    """
    def __init__(self, *args, ssl_context=None, **kwargs):
        """
        @param ssl_context: Custom SSL context.
        @type ssl_context: ssl.SSLContext
        """
        self._ssl_context = ssl_context
        super().__init__(*args, **kwargs)

    def init_poolmanager(self, *args, **kwargs):
        kwargs['ssl_context'] = self._ssl_context
        return super().init_poolmanager(*args, **kwargs)

    def cert_verify(self, conn, *args, **kwargs):
        super().cert_verify(conn, *args, **kwargs)
        conn.ca_certs = None
        conn.ca_cert_dir = None

?

I think that should be fine.


add branch up-to-date check

Utilize the git rev-list --left-right --count  tinygrad/master...${{ github.event.pull_request.head.sha }} to detect the exact amount of behind/ahead of current branch compare to the tinygrad master branch. Then just condition the comment bot action only on when branch is up-to-date (this is adjustable in $count -gt 0).
Here is a sample outout:
git rev-list --left-right --count  tinygrad/master...${{ github.event.pull_request.head.sha }} | awk '{print "Behind "$1" - Ahead "$2""}'
Behind 6 - Ahead 0

initially I kept this branch behind on purpose hoping to be able to test it when I make the PR. however, I don't think CI is using the new yml file from this PR. Thus the comment bot was triggered.
Here is the test I did to show that comment bot was skipped
https://github.com/g1y5x3/tinygrad/actions/runs/6216063049/job/16869566238?pr=10#step:3:21

Instead of skipping, I make it trigger another bot comment that suggests a rebase.
https://github.com/g1y5x3/tinygrad/pull/16


error message when adding Microsoft Bookings trigger: The renderComponentIntoRoot component encountered an error while loading.

Describe the Bug with repro steps
New workflow - add new Microsoft Bookings trigger, e.g. When a appointment is Created.
Same works with the old/legacy designer.
What type of Logic App Is this happening in?
Standard (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos

Browser
Edge
Additional context
No response

@ZoltanK-MSFT would you be able to send netowrk logs over to<EMAIL_ADDRESS>Also do you have any existing Microsoft booking connections or are you creating a new one?

Discussed with Eric via MS internal channel on 18th April.

there is an issue where if dynamic data passes an object, we were not parsing to get dropdown options for dynamic data and thus erroring. I'll have this fixed in my next PR


Release 0.18.0-m1

Scheduled release date: March 11, 2024
This is a tracker to aggregate issues that should be part of 0.18.0-m1.
Please add specific Issues or PRs prefixed with the "Depends on" keyword
Make sure to follow the manual steps listed below before starting the release process.
Manual Steps
For detailed information regarding each step, please check: https://submariner.io/development/building-testing/ci-maintenance/

[ ] Custom GitHub Actions
[ ] GitHub Actions
[ ] Kubernetes Versions
[ ] Shipyard Linting Image Software

https://github.com/submariner-io/releases/releases/tag/v0.18.0-m1


Unable to retrieve Instrumentation API to add Paper jar to classpath. If you're running paperclip without -jar then you also need to include the -javaagent:<paperclip_jar> JVM command line option.

Hi,
i always get this Warning when im starting my Server
on Deb10
and java11
"Unable to retrieve Instrumentation API to add Paper jar to classpath. If you're running paperclip without -jar then you also need to include the -javaagent:<paperclip_jar> JVM command line option."
can someone help me please

please include more info.
how do you start the server?

i use the server in a cloud system
so with executing the jar i guess

well, then its a bug in said "cloud" system, bring it up to them, they will know what to do with the error message

It's not a bug. JVM distribution is allowed not to have instrumentation API available. Launch paperclip locally, so it builds a paper jar (located in cache subdirectory) and use that for server.

Are you sure? I looked at the source for a second and saw they use the instrumentation api to add their own Javaagent and stuff so i wouldn't be surprised if they broke stuff

When people make their own JVM images, the instrumentation API is not required no. The “minimal” image does not include it for example.
There are some mailing list threads about this but it was never changed. Hence my other issue on this repo to provide more info when it happens.
http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-May/012702.html

I don’t know that there’s any real fixing this as far as paperclip is concerned either.
We can provide the user and ourselves with more information and guide them to a more complete (read: better) image, but not like we can correct it.
Original author, if you need more assistance with this please seek support on the forums or discord. You can either run it locally and take the cached patch jar and use that remotely or you need a different distribution of Java.

and how can i fix this?

Original author, if you need more assistance with this please seek support on the forums or discord. You can either run it locally and take the cached patch jar and use that remotely or you need a different distribution of Java.

So i can run the jar in a local server and then put the jar from the server after starting?

from the cache folder, yes


Add methods to SingleAxis and DualAxis to set deadzones

This adds with_deadzone methods to SingleAxis and DualAxis, which consume and return the self with the deadzones changed.
I wanted a more ergonomic way to set deadzones. This approach is still pretty primitive compared to using the constructor, since it is limited to symmetrical deadzones. Additionally, the library itself is limited to square deadzones, But the addition is light-weight and consistent with Bevy's style, and setting deadzones primitively seems like a common enough action.

Can you retarget this to dev?

Going to remake this quick to avoid fighting git :) Thanks!


Reenable CompatHelper for selected tutorials

This PR updates some additional tutorials to Turing 0.21 and reenables CompatHelper for all tutorials with the most recent Turing version.
Once all tutorials are updated, it would be safe (ie. without CompatHelper spamming the repo) to enable CompatHelper for all tutorials with a Project.toml file. I already included the code for it.

The error messages are the same as in https://github.com/TuringLang/TuringTutorials/pull/296#issuecomment-1109992876 it seems. They should be fixed first since currently most tutorials are not run.


Queue and await parallel calls to mute/unmute for local tracks

Introduces an additional dependency on 'async-await-queue'.
Keeping this PR clean, but we might be able to reuse the same lib for the signal request queue in order to keep the overall bundle size down as much as possible.

I don't have any reason to believe otherwise.
@davidliu do you see any problem regarding this change with react native?


Editable comment/description for a table or database

[Feature request] Editable comment/description for a table or database #19269
I found that we can set the comment for a table while creating it but we cannot update it anymore once it is created. (tried with ALTER TABLE command but it didn't work)
So, here are mainly 2 feature requests:

Make the comment of a table editable
Add the functionality to add a comment on a database too.

I think this issue has been done in https://github.com/StarRocks/starrocks/pull/21035


quota checking with static mapping between VMSize and number of cores

excuse the duplicated review comments, GH was playing up as I reviewed this.


How go generate a new account (wallet address)

Hi guys, how go generate a new account (wallet address) include: account_id, pub key, private key.
Thank you so muc!

Found this here:
https://github.com/eteu-technologies/near-api-go/blob/master/cmd/edkeypair/main.go


When autofilling, empty value in Firefox

When autofilling a form, in the input event target.value equals an empty string in the Firefox browser. For example, autofill in the Chrome browser generates 2 events: input and change. And the change event contains a filled string.
Reproduction where the input data is filled in correctly in other browsers, but fails to do so in Firefox: https://codepen.io/alxantipov/pen/BaEPEjM
OS: Mac OS/Window
Browser: Firefox
Inputmask 5.0.8

This is accepted behavior in Firefox since according to MDN,

Unlike the input event, the change event is not necessarily fired for each alteration to an element's value.

This is true for any input field, even if it has no Inputmask.


Trade history: price and quantity columns aren't lined up with labels

![Kapture 2020-02-11 at 17.11.11.gif]
Build:

done


Could you please provide an example on how to use callback with the new signature.

Hello! Thank you for updating the PubSubClient library. In the issues of the original repo  i stumbled upon your post about having to increase the packet size to receive images. I am currently in the same situation i am trying to receive an image which is around 15 kB on my ESP8266 but I am unsuccessful  even if I increase the MQTT_MAX_PACKET_SIZE variable in .h file.
You mention you were able to achieve the required functionality, so I tried files from your code but I am getting compilation errors since the signatures have change (i.e. callback function) Do you mind providing an example on how to read payload in callback function?
Thank you!
P.S. you disabled issues, so the only way to connect to you is through a PR.

+1, an example on how to use this callback signature would be great ! :)


[RHOAIENG-9411] - Update odh-model-controller's istio dependencies to 1.21

Updated the istio libraries and others based on go version 1.21
Description

How Has This Been Tested?

Merge criteria:

[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work

/approve

/hold
merge after kserve is in sync.

/unhold

/approve
/lgtm


Suggested add-on checkbox logic is poor.

In application.js it's suggested that to keep the active on the checkbox they should use the following code:
$('.add-on :checkbox').click(function () {
	if ($(this).attr('checked')) {
		$(this).parents('.add-on').addClass('active')
	} else {
		$(this).parents('.add-on').removeClass('active')
	}
})

This doesn't handle the case when they are out-of-sync on page load (pre-checked). It also uses an incorrect way of checking for checked state of the checkbox.
I would suggest:
syncCheckBox = function() {
    $(this).parents('.add-on').toggleClass('active', $(this).is(':checked'));
};
$('.add-on :checkbox').each(syncCheckBox).click(syncCheckBox);

you shouldn't be using this application code. It's just for our docs.


docs: add initial examples

🔗 Linked issue

❓ Type of change

[x] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This PR will add examples for an upcoming 101 article about ofetch (https://github.com/unjs/website/pull/108). In order to use the last version of ofetch, I create pnpm workspace.
I order to avoid regression in articles, I think we could add an action to check types of examples!
📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks for working on this and sorry got delayed to review. I have made a couple of reactors in order to keep changes minimal allowing to iterate over examples idea (once the article is ready, we can see what else is needed to make them running easier for users, i am thinking of some tooling...)


update piapro link

Because they moved their page without setting up a redirect for some reason. I guess CC-BY-NC doesn't require a working link, but it surprised me that they made it available with a CC license. You'll probably want to change the URL in the other repo, too.

thank you


[FLINK-15257][hive]convert HiveCatalogITCase.testCsvTableViaAPI() to use blink planner

What is the purpose of the change
convert HiveCatalogITCase.testCsvTableViaAPI() to use blink planner
Brief change log
convert HiveCatalogITCase.testCsvTableViaAPI() to use blink planner
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @bowenli86 @xuefuz @JingsongLi @lirui-apache to have a review.

LGTM, merged


Update interested-technical-writers.md

I added my information to the list of interested technical writers.

Hi, I left a pull request and it hasn't been closed yet. Please can I know if there is a problem?


Readme.md update

README updated with metabase reconfiguration steps (including images).
Dashboard dockerfile updated.
Unnecessary files removed.

This pull request has conflicts. Please solve them before approval.


feat: add configuable access command

Add configuable accessCommand to PodAccessTemplate, ExecAccessTemplate.

➜  oz git:(add-configuable-access-command) ✗  (⎈|kind-kind:N/A)$ k apply -f examples/pod_access_template.yaml
podaccesstemplate.crds.wizardofoz.co/deployment-example created
➜  oz git:(add-configuable-access-command) ✗  (⎈|kind-kind:N/A)$ dist/cli_darwin_arm64/ozctl create podaccessrequest deployment-example
Initiating Access Request...
  Template Name: deployment-example
  Request Name Prefix: dennis
Verifying Template deployment-example exists (ns: default)...
Creating PodAccessRequest... dennis-jd6km created!
Waiting for dennis-jd6km to be ready..
Success, your access request is ready! Here are your access instructions:
---
kubectl exec -it -n default dennis-jd6km-84662c4e -- /bin/bash
---

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 28 (64.29%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 45.747%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/api/v1alpha1/exec_access_request_types.go
0
1
0.0%

internal/controllers/podwatcher/types.go
0
1
0.0%

internal/builders/execaccessbuilder/create_access_resources.go
5
7
71.43%

internal/builders/podaccessbuilder/create_access_resources.go
2
4
50.0%

internal/builders/utils/access_command.go
11
15
73.33%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
952

Relevant Lines:
2081

💛  - Coveralls

This PR supersedes #121 ...


Automatic add to sys.path!! closes #1

Doh. that doesn't work at all, i was invoking the wrong deployment when i though this worked :cry: