Improve filling the User context

Fixes #706. I had no time to test it on a real project, so please do it if you can before merging 🙏

@cleptric can I ask for your review on this?

Yep, can take a look tomorrow/next week.

I found out that the RequestListener listener was overwriting the entire user context set on the scope. Since the LoginListener probably ran earlier than that, it may have been the cause of seeing only the user IP address for all subsequent requests. I still have some doubts about the fact that we need to listen on the kernel.request event to gather the user data from the token storage though because I'm not sure that the LoginSuccessEvent event is dispatched on every request...

Both LoginListener::handleLoginSuccessEvent and LoginListener::handleAuthenticationSuccessEvent seem not to be called on each request. In my controller, $this->security->getUser() does return the logged-in user. The event sent to Sentry only contains the IP.

Do you mind sharing the security.yaml file you're using in your test project? In mine, I configured it like this and it seems to work fine:
security:
    password_hashers:
        Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface: 'plaintext'

    providers:
        users_in_memory:
            memory:
                users:
                    john: { password: 'doe', roles: ['ROLE_USER'] }
    firewalls:
        main:
            provider: users_in_memory
            http_basic:
                realm: Secured Area

    access_control:
        - { path: ^/, roles: ROLE_USER }

security:
    # https://symfony.com/doc/current/security.html#registering-the-user-hashing-passwords
    password_hashers:
        Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface: 'auto'
    # https://symfony.com/doc/current/security.html#loading-the-user-the-user-provider
    providers:
        # used to reload user from session & other features (e.g. switch_user)
        app_user_provider:
            entity:
                class: App\Entity\User
                property: email
    firewalls:
        dev:
            pattern: ^/(_(profiler|wdt)|css|images|js)/
            security: false
        main:
            lazy: true
            provider: app_user_provider

            form_login:
                # "app_login" is the name of the route created previously
                login_path: login
                check_path: login

            logout:
                path: logout
                # where to redirect after logout
                target: /

            # activate different ways to authenticate
            # https://symfony.com/doc/current/security.html#the-firewall

            # https://symfony.com/doc/current/security/impersonating_user.html
            # switch_user: true

    # Easy way to control access for large sections of your site
    # Note: Only the *first* access control that matches will be used
    access_control:
        - { path: ^/sentry, roles: ROLE_USER }

when@test:
    security:
        password_hashers:
            # By default, password hashers are resource intensive and take time. This is
            # important to generate secure password hashes. In tests however, secure hashes
            # are not important, waste resources and increase test times. The following
            # reduces the work factor to the lowest possible values.
            Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface:
                algorithm: auto
                cost: 4 # Lowest possible value for bcrypt
                time_cost: 3 # Lowest possible value for argon
                memory_cost: 10 # Lowest possible value for argon

https://github.com/cleptric/symfony - Most logic is in the SentryController.

I have no clue on why it was working in my test project, but indeed the framework does not dispatch the two login-related events for each request. I readded back a listener for the request.kernel event and it now works as expected.

Looking good!
@Jean85 can you take another look, please?


Cannot use key aliases with bindKey or checkKey

Hope I'm note doing things wrong, but it looks like that key codes functionality (issue#33) is broken at least at v1.5.4
bindKey("a", () => console.log("a key")); //working
bindKey("@KeyW", () => console.log("w code")); //doesn't work

codesandbox: https://codesandbox.io/p/sandbox/keystroke-codes-issue-3n9nny
P.S. with 1.5.0 it's working, but I didn't make it work with numpad, e.g. bindKey("@KeyNumpad4", () => console.log("4 code"))

Hi @se-panfilov. I took a closer look. Key aliases are working for bindKeyCombo, but you are correct - they are not working with bindKey or checkKey. Thanks for reporting the issue, it's greatly apreciated.
I've deployed a fixed version (v1.5.5)
Let me know if you run into further issues.


Can't validate generated XML through the sandbox portal

Hey, first of all thanks for your tremendous efforts, I was trying the library out and it works great, the compliance API succeeds. However, I can't seem to be able to write the generated XML to a file then upload that to the sandbox portal validator.
Errors:

Code used to write to file:
fs.writeFile(__dirname + '/tmp/test.xml', signed_invoice_string, {
            flag: "w"
          }, function(err) {
            if (err) {
              return console.log(err);
            }
            console.log("The file was saved!");
});

Validator link: https://sandbox.zatca.gov.sa/TestXML

@AbdelrahmanManz Check this issue.
https://github.com/wes4m/zatca-xml-js/issues/16#issuecomment-1330333728


Inform the user that an ember is using a different ambient_api version than the runtime

'Nuff said, really.
Everyone is thrown for a loop when new, breaking changes to main happen, which is virtually every single day. If the ambient runtime could compare its version (perhaps against a commit) against an ember's version (again, maybe a commit, either read from the ember's Cargo.toml or exported as a Wasm global), it could save a LOT of trouble for anyone. The ambient runtime could inform the user, give them some methods to resolve the issue (upgrade or downgrade either package), and maybe even bail.

Potentially a dupe of https://github.com/AmbientRun/Ambient/issues/206 ?

I am building a tool to do that. see https://github.com/AmbientRun/Ambient/issues/684


Update Readme file new features

Description
Hello @Jaysmito101
Features I want to add -

add the contribution guidelines.
Add the maintainer details
Add new features for more attractiveness

These are important features of the readme file of any open-source project. kindly assign me this issue.
Submit this issue under IWOC

@Suryansh1720001 contribution guidelines already exists. What do you mean by maintained details? And what features? Please explain.

ok @Jaysmito101
I will add

contributors details
maintainer details
I will add some motivating lines with some attractiveness so that more people contribute in this project
adding the footer to the readme file

And attractive work for enhancing its quality.

@Suryansh1720001 as I already said please elaborate on what do you mean by attractiveness. Please elaborate your points rather than repeating them.

@Jaysmito101
Attractiveness means

adding some emojis when required
adding the spacing in between the new headings.
Some new headings align to the center

And as I said earlier some contributors and maintainer details.

@Suryansh1720001 that kind of contribution is not at all useful the project.


About the annotation of the datasets

Hi, dear organizer.
During verifying the performance of our method,  we meet some problems with annotations in Training set and Validation Set.
It mainly includes the following two aspects:

It seems that some fracture areas in the Validation Set are not annotated. As shown in the figure, there are two abnormal cortical bones, but the annotated area does not include these two places.

Part of the fracture occurred on multiple ribs, but only have one label. Such as the RibFrac114 in Training set and RibFrac445 in Validation Set. This may be for the convenience of annotating. However, annotations like this with gaps in the middle may have problems while under evaluation. (see line 246 in evaluation.py for details) When the centroid(x, y, z) is located in these gaps, whether it exists possible for the original labels to be classified as the 'Background'?

Hi @SwanKnightZJP ,
Thank you very much for your feedback!
For both issue 1 and 2, I am sorry that the mentioned issues are possible, even though we have tried our best to improve the annotation quality. It may occurs in the human annotation procedure or the pre-processing step.
We have paid more attention on the test set (than the training and validation), so that the risk of these issues will be reduced.  It is still human annotations anyway, I can not guarentee the 100% accuracy of the annotations though.
We are re-checking the annotations with the hope of a updated version (RibFrac v2), but it is not possible to make it done for the RibFrac Challenge this year. Stay tuned!
Please note that it is also fair the participants this year, since every participants use the same dataset anyhow.  Thanks for understanding.
Jiancheng Yang
On behalf of MICCAI 2020 RibFrac Challenge Organizers

Thank you very much for your reply, and thanks to the RibFrac project team for publishing such an excellent dataset.
Looking forward to the updated version.
(╹◡╹)ノ♡


ruff: 0.4.10 -> 0.5.0

Description of changes
Changelog: https://github.com/astral-sh/ruff/releases/tag/0.5.0
cc @figsoda

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 322953 run on aarch64-linux 1

8 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist

40 packages failed to build:

maigret
maigret.dist
nbqa
nbqa.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
sasview
sasview.dist
shell-gpt
shell-gpt.dist

16 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
emacsPackages.lsp-bridge
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

46 packages failed to build:

maigret
maigret.dist
nbqa
nbqa.dist
open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
sasview
sasview.dist
shell-gpt
shell-gpt.dist

16 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
emacsPackages.lsp-bridge
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on aarch64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

48 packages failed to build:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
maigret
maigret.dist
nbqa
nbqa.dist
open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
sasview
sasview.dist
shell-gpt
shell-gpt.dist

14 packages built:

emacsPackages.lsp-bridge
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on x86_64-darwin 1

4 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist

48 packages failed to build:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
maigret
maigret.dist
nbqa
nbqa.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
sasview
sasview.dist
shell-gpt
shell-gpt.dist

12 packages built:

emacsPackages.lsp-bridge
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

8 packages failed to build:

maigret
maigret.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
sasview
sasview.dist

56 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
emacsPackages.lsp-bridge
nbqa
nbqa.dist
open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
shell-gpt
shell-gpt.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on aarch64-linux 1

8 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist

8 packages failed to build:

maigret
maigret.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
sasview
sasview.dist

50 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
emacsPackages.lsp-bridge
nbqa
nbqa.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
shell-gpt
shell-gpt.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on x86_64-darwin 1

4 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist

44 packages failed to build:

maigret
maigret.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
sasview
sasview.dist
shell-gpt
shell-gpt.dist
tests.testers.lycheeLinkCheck.network
tests.testers.nixosTest-example
tests.testers.runNixOSTest-example
tests.trivial-builders.references

22 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
emacsPackages.lsp-bridge
nbqa
nbqa.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on aarch64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

50 packages failed to build:

maigret
maigret.dist
open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
sasview
sasview.dist
shell-gpt
shell-gpt.dist
tests.testers.lycheeLinkCheck.network
tests.testers.nixosTest-example
tests.testers.runNixOSTest-example
tests.trivial-builders.references

18 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
emacsPackages.lsp-bridge
nbqa
nbqa.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on aarch64-darwin 1

2 packages marked as broken and skipped:

khoj
khoj.dist

18 packages failed to build:

maigret
maigret.dist
open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
sasview
sasview.dist
shell-gpt
shell-gpt.dist
tests.testers.lycheeLinkCheck.network
tests.testers.nixosTest-example
tests.testers.runNixOSTest-example
tests.trivial-builders.references

50 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
emacsPackages.lsp-bridge
nbqa
nbqa.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 322953 run on x86_64-darwin 1

4 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist

16 packages failed to build:

maigret
maigret.dist
pentestgpt
pentestgpt.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
sasview
sasview.dist
shell-gpt
shell-gpt.dist
tests.testers.lycheeLinkCheck.network
tests.testers.nixosTest-example
tests.testers.runNixOSTest-example
tests.trivial-builders.references

50 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
emacsPackages.lsp-bridge
nbqa
nbqa.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

I have not observed any regression.

Note: if any packages regresses because of new lints, the correct fix is to disable lint checks in your package


IBC: Figure out how to send IBC transfers with a large memo field

When doing an IBC transfer to a shielded account, we need to include the MASP proof in the memo field, but I am currently getting an error back from the Cosmos RPC that memos are limited to 512 characters, which is not long enough to fit the MASP proof.

Done. It needs to be the inner memo field, not the wrapper one.


Yaml parsing errors always report tye.yaml file problem

Describe the bug
When YAML parsing acts on path argument, it always directs user to an error in tye.yaml file
To Reproduce

Create a foo.yml file with invalid yml syntax
Run tye with file from Step 1 as path argument (e.g. > tye run foo.yml)
Note error message says Error parsing tye.yaml: ...

Further technical details
Tye version: 0.6.0-alpha.21070

So you expect the error to report an error in foo.yaml rather than tye.yaml, correct?

Hi @jkotalik !
I'm willing to tackle this issue as a first contribution to Tye. Already looked a bit at the code, and my first guess is we should pass the filename in TypeYamException constructors, either as a FileInfo or a string. This change would require a lot of changes in *Parser classes, such as removing static accessibility modifiers to use a private FileInfo member.
What do you think about this change ?


Request: Tabbed browsing

I would love tabbed browsing for navigating BAM files of genome assemblies. A right-click Go to mate in new tab feature would be super fantastic.

Closing, too hard.


Minor fixes

For error message displayed for renaming to the same name as itself on edit project and edit client
For crash when edit project name parameter is null
For incorrect display of () without a client contact number
For incorrect adding of projects and clients with a name that is already that ignored case sensitivity

Codecov Report

Merging #234 (e7a8107) into master (0ab39e1) will decrease coverage by 0.01%.
The diff coverage is 35.71%.

@@             Coverage Diff              @@
##             master     #234      +/-   ##
============================================
- Coverage     38.51%   38.50%   -0.02%
- Complexity      528      529       +1
============================================
  Files           125      125
  Lines          3191     3200       +9
  Branches        409      412       +3
============================================
+ Hits           1229     1232       +3
- Misses         1781     1786       +5
- Partials        181      182       +1

Impacted Files
Coverage Δ

...dress/logic/commands/client/EditClientCommand.java
0.00% <0.00%> (ø)

...ess/logic/commands/project/EditProjectCommand.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/Name.java
66.66% <75.00%> (+1.66%)
:arrow_up:

...seedu/address/model/client/ClientWithoutModel.java
33.33% <100.00%> (ø)

...edu/address/model/project/ProjectWithoutModel.java
33.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


cmd/go:  go install fails with malformed file path ("*" in png file path)

What version of Go are you using (go version)?

$ go version
go version go1.18.1 linux/amd64

Does this issue reproduce with the latest release?
?
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/david/.cache/go-build"
GOENV="/home/david/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/david/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/david/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.18"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.18/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build2800159434=/tmp/go-build -gno-record-gcc-switches"

What did you do?
$ go install framagit.org/InfoLibre/rapido@latest
It should download all the module package.
What did you see instead?
Nothing is downloaded and there's an error message because one of the file in the package contains * character: https://framagit.org/InfoLibre/rapido/-/blob/master/docs/diaspora*.png

Looks similar to https://github.com/golang/go/issues/44776

@golang/tools-team
I can reproduce this on tip.

The error is intentional, and the error message seems to be accurate.

F* Windows!

F* Windows!
Perhaps you are looking for https://fsharp.org/use/windows/.

:rofl:


Content-Type header

Your document states
In your request, make sure you include a Content-Type header and set the header's value to application/json.
However, there is no example of it.
I am consistently getting the message
"Remember to include a Content-Type header set to application/json in your request." however I have no idea why it's saying that. There is no documentation on how to fix that error message.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 867f533b-1774-1fc8-1fa9-f0935eeaf337
Version Independent ID: 0cdfeb0a-9c9b-5cee-452b-efa1e87b4ad2
Content: Handle content types - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-content-type.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

@KristinBethea
Thanks for your feedback! We will investigate and update as appropriate.

@KristinBethea When you make a HTTP request from a client app or tools such as Postman to Logic Apps, the request header should be set like "Content-Type": "application/json" along with the request body shown in the example. This header needs to be set on the client side which is making the request to Logic Apps. Checkout a similar discussion regarding this.
I hope this helps and let me know if any questions.

Yes. I read that conversation and it was extremely confusing and did not really help. I finally figured out that it needs to come IN with a header and wasn’t talking about the actual settings in the Logic App.
This is why you need to make it more clear on the actual page where you are explaining and this is why I made the feedback that it was confusing.
Thank you,
KB
From: mumurug-MSFT @.>
Sent: Tuesday, September 5, 2023 2:01 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Bethea, Kristin @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] Content-Type header (Issue #114313)
@KristinBetheahttps://urldefense.com/v3/__https:/github.com/KristinBethea__;!!AbgBjg!2xaaw9sxRYDJODn-3vh-SQx08r80uD79tafaA8fBEhtau7gAVgJZ7QPTPqKDBPwXY32me8XygtNRhewd6ct-I2XKwnDUC70$ When you make a HTTP request from a client app or tools such as Postman to Logic Apps, the request header should be set like "Content-Type": "application/json" along with the request body shown in the example. This header needs to be set on the client side which is making the request to Logic Apps. Checkout a similar discussionhttps://urldefense.com/v3/__https:/powerusers.microsoft.com/t5/Building-Flows/Remember-to-include-a-Content-Type-header-set-to-application/td-p/152799__;!!AbgBjg!2xaaw9sxRYDJODn-3vh-SQx08r80uD79tafaA8fBEhtau7gAVgJZ7QPTPqKDBPwXY32me8XygtNRhewd6ct-I2XKmONSlOc$ regarding this.
I hope this helps and let me know if any questions.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/MicrosoftDocs/azure-docs/issues/114313*issuecomment-1707163981__;Iw!!AbgBjg!2xaaw9sxRYDJODn-3vh-SQx08r80uD79tafaA8fBEhtau7gAVgJZ7QPTPqKDBPwXY32me8XygtNRhewd6ct-I2XKmj11rj4$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A237SZPX3SP67DVDBXSLGI3XY5ZGPANCNFSM6AAAAAA4LXRQ2U__;!!AbgBjg!2xaaw9sxRYDJODn-3vh-SQx08r80uD79tafaA8fBEhtau7gAVgJZ7QPTPqKDBPwXY32me8XygtNRhewd6ct-I2XKwA23aOA$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>
NOTICE_________ This electronic mail transmission, including any attachments, contains confidential information of The Bridgespan Group ("Bridgespan") and/or its clients. It is intended only for the person(s) named, and the information in such e-mail shall only be used by the person(s) named for the purpose intended and for no other purpose. Any use, distribution, copying or disclosure by any other persons, or by the person(s) named but for purposes other than the intended purpose, is strictly prohibited. If you received this transmission in error, please notify the sender by reply e-mail and then destroy this e-mail. Opinions, conclusions and other information in this message that do not relate to the official business of Bridgespan shall be understood to be neither given nor endorsed by Bridgespan. When addressed to Bridgespan clients, any information contained in this e-mail shall be subject to the terms and conditions in the applicable client contract.

@KristinBethea Got it, we will make the changes to be clearer. Thanks again for the feedback.


[Question]Why does Run-AlPipeline bind a volume to c:\sources inside the container?

Describe the issue
We are using the Hello-World pipeline templates for some of our CI/CD-processes and I was trying to optimize the performance while running on self-hosted agents which always use the same target version because it is a dedicated build machine for a specific customer.
That is why I thought it should be possible to run the AL-Pipeline with the "-keepContainer" flag activated. Furthermore I just commented out the pipeline CleanUp Task, so that the container is still running.
The problem is now, that the Azure DevOps Job fails while initializing with the following error:

I think the problem here is, that the running container is somehow locking the agent working folder and I guess it has something to do with the fact, that there is a volume that is actively bound to the $basefolder in the Run-AlPipelines.ps1
$Parameters += @{
        "accept_eula" = $true
        "containerName" = $containerName
        "imageName" = $imageName
        "artifactUrl" = $artifactUrl
        "useGenericImage" = $useGenericImage
        "Credential" = $credential
        "auth" = 'UserPassword'
        "vsixFile" = $vsixFile
        "updateHosts" = $true
        "licenseFile" = $licenseFile
        "EnableTaskScheduler" = $enableTaskScheduler
        "AssignPremiumPlan" = $assignPremiumPlan
        "MemoryLimit" = $memoryLimit
        "additionalParameters" = @("--volume ""$($baseFolder):c:\sources""")
    }

I suspect this additionalParameters to be the culprit. And I was wondering where or why this volume is needed in the first place? Maybe we could also deactivate this dynamically with a parameter in the Run-AlPipeline function?
Any information / help would be greatly appreciated :)
Scripts used to create container and cause the issue
Param(
    [Parameter(Mandatory=$false)]
    [ValidateSet('AzureDevOps','GithubActions','GitLab')]
    [string] $environment = 'AzureDevOps',
    [Parameter(Mandatory=$true)]
    [string] $version,
    [Parameter(Mandatory=$false)]
    [int] $appBuild = 0,
    [Parameter(Mandatory=$false)]
    [int] $appRevision = 0
)

if ($environment -eq "AzureDevOps") {
    $buildArtifactFolder = $ENV:BUILD_ARTIFACTSTAGINGDIRECTORY
}
elseif ($environment -eq "GitHubActions") {
    $buildArtifactFolder = Join-Path $ENV:GITHUB_WORKSPACE "output"
    New-Item $buildArtifactFolder -ItemType Directory | Out-Null
}

$baseFolder = (Get-Item (Join-Path $PSScriptRoot "..")).FullName
. (Join-Path $PSScriptRoot "Read-Settings.ps1") -environment $environment -version $version
. (Join-Path $PSScriptRoot "Install-BcContainerHelper.ps1") -bcContainerHelperVersion $bcContainerHelperVersion -genericImageName $genericImageName

$params = @{}
$insiderSasToken = "$ENV:insiderSasToken"
$licenseFile = "$ENV:licenseFile"
$codeSigncertPfxFile = "$ENV:CodeSignCertPfxFile"
if (!$doNotSignApps -and $codeSigncertPfxFile) {
    if ("$ENV:CodeSignCertPfxPassword" -ne "") {
        $codeSignCertPfxPassword = try { "$ENV:CodeSignCertPfxPassword" | ConvertTo-SecureString } catch { ConvertTo-SecureString -String "$ENV:CodeSignCertPfxPassword" -AsPlainText -Force }
        $params = @{
            "codeSignCertPfxFile" = $codeSignCertPfxFile
            "codeSignCertPfxPassword" = $codeSignCertPfxPassword
        }
    }
    else {
        $codeSignCertPfxPassword = $null
    }
}

$allTestResults = "testresults*.xml"
$testResultsFile = Join-Path $baseFolder "TestResults.xml"
$testResultsFiles = Join-Path $baseFolder $allTestResults
if (Test-Path $testResultsFiles) {
    Remove-Item $testResultsFiles -Force
}

Run-AlPipeline @params `
    -pipelinename $pipelineName `
    -containerName $containerName `
    -imageName $imageName `
    -artifact $artifact.replace('{INSIDERSASTOKEN}',$insiderSasToken) `
    -memoryLimit $memoryLimit `
    -baseFolder $baseFolder `
    -licenseFile $LicenseFile `
    -installApps $installApps `
    -previousApps $previousApps `
    -appFolders $appFolders `
    -testFolders $testFolders `
    -doNotRunTests:$doNotRunTests `
    -testResultsFile $testResultsFile `
    -testResultsFormat 'JUnit' `
    -installTestFramework:$installTestFramework `
    -installTestLibraries:$installTestLibraries `
    -installPerformanceToolkit:$installPerformanceToolkit `
    -enableCodeCop:$enableCodeCop `
    -enableAppSourceCop:$enableAppSourceCop `
    -enablePerTenantExtensionCop:$enablePerTenantExtensionCop `
    -enableUICop:$enableUICop `
    -azureDevOps:($environment -eq 'AzureDevOps') `
    -gitLab:($environment -eq 'GitLab') `
    -AppSourceCopMandatoryAffixes $appSourceCopMandatoryAffixes `
    -AppSourceCopSupportedCountries $appSourceCopSupportedCountries `
    -additionalCountries $additionalCountries `
    -buildArtifactFolder $buildArtifactFolder `
    -CreateRuntimePackages:$CreateRuntimePackages `
    -appBuild $appBuild -appRevision $appRevision `
    -keepContainer

if ($environment -eq 'AzureDevOps') {
    Write-Host "##vso[task.setvariable variable=TestResults]$allTestResults"
}

trigger:
- master
- dev

pool: anaptis

variables:
- group: APT KeyVault

jobs:
- job: Build
  timeoutInMinutes: 300
  variables:
    build.clean: all
    platform: x64
    version: 'ci'
    appVersion: '2.0'
    appBuild: $(Build.BuildID)
    appRevision: 0
    skipComponentGovernanceDetection: True

  steps:
  - task: PowerShell@2
    displayName: 'Set BuildNumber'
    inputs:
      targetType: inline
      script: 'Write-Host "##vso[build.updatebuildnumber]$(appVersion).$(appBuild).$(appRevision)"'

  - task: PowerShell@2
    displayName: 'Run Pipeline'
    env:
      InsiderSasToken: '$(InsiderSasToken)'
      LicenseFile: '$(LicenseFile)'
      CodeSignCertPfxFile: '$(CodeSignCertPfxFile)'
      CodeSignCertPfxPassword: '$(CodeSignCertPfxPassword)'
    inputs:
      targetType: filePath
      filePath: 'scripts\DevOps-Pipeline.ps1'
      arguments: '-environment "AzureDevOps" -version "$(version)" -appBuild $(appBuild) -appRevision $(appRevision)'
      failOnStderr: true

  - task: PublishTestResults@2
    displayName: 'Publish Test Results'
    condition: and(succeeded(),ne(variables['TestResults'],''))
    inputs:
      testResultsFormat: JUnit
      testResultsFiles: '$(testResults)'
      failTaskOnFailedTests: true

  - task: PowerShell@2
    displayName: 'Copy deployment scripts'
    inputs:
      targetType: inline
      script: 'Copy-Item -Path scripts\Deploy-OnPremApp.ps1 -Destination $(Build.ArtifactStagingDirectory); Copy-Item -Path App\app.json -Destination $(Build.ArtifactStagingDirectory)\Apps '
      failOnStderr: true

  - task: PublishBuildArtifacts@1
    displayName: 'Publish Artifacts'
    inputs:
      PathtoPublish: '$(Build.ArtifactStagingDirectory)'
      ArtifactName: output

#  - task: PowerShell@2
#    displayName: 'Cleanup'
#    condition: always()
#    inputs:
#      targetType: filePath
#      filePath: 'scripts\Cleanup.ps1'
#      arguments: '-environment "AzureDevOps"'
#      failOnStderr: false

Full output of scripts
Starting: Initialize job
Agent name: 'CUSTOMER-a'
Agent machine name: 'BUILD-CUSTOMER'
Current agent version: '2.179.0'
Agent running as: 'agent'
Prepare build directory.
##[error]The process cannot access the file 'C:\agent1\_work\1\s' because it is being used by another process.
Finishing: Initialize job

Additional context

the problem appears when we run the pipeline a second time, because than the container is still running and locking the agent working folder

So you are creating a container in a pipeline and trying to keep the container for use from elsewhere...
The problem is that the agent is using the same folder for subsequent runs and that will mess around with the first container.
I kind of have to share the source with the container and I am not sure it is a good idea.
You could use c:\agent as basefolder, but you would then have to re-calculate all the other folders to be relative to c:\agent then.
You could also override the NewBcContainer and share c:\agent instead of the sub-sub-sub folder - then everything might work.

So you are creating a container in a pipeline and trying to keep the container for use from elsewhere...
The problem is that the agent is using the same folder for subsequent runs and that will mess around with the first container.
I kind of have to share the source with the container and I am not sure it is a good idea.
You could use c:\agent as basefolder, but you would then have to re-calculate all the other folders to be relative to c:\agent then.
You could also override the NewBcContainer and share c:\agent instead of the sub-sub-sub folder - then everything might work.

I just want to reuse the existing container for the next run of the same pipeline, because I know and control, that the next run will need the exact same BCArtifacts and so it would just need to remount the database from backup and would be ready to go, or am I wrong?
We are using this method with most of our CI/CD pipelines but because the customer wanted to selfhost on DevOps we advised him to use the Hello-World / Run-ALPipeline because we thought that the customer's developers could more easily get help with the Run-AlPipeline then try to understand our heavily customized ones.
And because of workflow decisions now every change has to be built four separate times (PR build validation Dev -> Dev CI -> PR build validation Master -> Master CI) ... and that is why I want to try to shave a couple of minutes off on every build.
I thought that this would be a low hanging fruit regarding build time optimization, but apparently I was wrong :D

I just want to reuse the existing container for the next run of the same pipeline, because I know and control, that the next run will need the exact same BCArtifacts and so it would just need to remount the database from backup and would be ready to go, or am I wrong?
We are using this method with most of our CI/CD pipelines but because the customer wanted to selfhost on DevOps we advised him to use the Hello-World / Run-ALPipeline because we thought that the customer's developers could more easily get help with the Run-AlPipeline then try to understand our heavily customized ones.
And because of workflow decisions now every change has to be built four separate times (PR build validation Dev -> Dev CI -> PR build validation Master -> Master CI) ... and that is why I want to try to shave a couple of minutes off on every build.
I thought that this would be a low hanging fruit regarding build time optimization, but apparently I was wrong :D

I am looking into manually switching the base folder... but am I correct to assume, that I also would not only have to switch the paths in the customers repos DevOps-Pipeline.ps1 script but also inside the installed modules Run-AlPipeline.ps1 on the agent itself? Because that would be to much tinkering for me... also I would be stuck with my customized BcContainerHelper and could not use any new version...

I am looking into manually switching the base folder... but am I correct to assume, that I also would not only have to switch the paths in the customers repos DevOps-Pipeline.ps1 script but also inside the installed modules Run-AlPipeline.ps1 on the agent itself? Because that would be to much tinkering for me... also I would be stuck with my customized BcContainerHelper and could not use any new version...

I don't think you need to change the code - as long as the folders and filenames are relative to the basefolder it should work, but the Run-AlPipeline is really not geared towards the scenario you are trying to do.
Currently the pipeline caches the image (if imagename is f.ex. "my") which would be the fastest way to re-create the container - restoring the database would only be slightly faster.

I don't think you need to change the code - as long as the folders and filenames are relative to the basefolder it should work, but the Run-AlPipeline is really not geared towards the scenario you are trying to do.
Currently the pipeline caches the image (if imagename is f.ex. "my") which would be the fastest way to re-create the container - restoring the database would only be slightly faster.

Did you manage to make this work?

Did you manage to make this work?

I have kind of given up on that right now. We were already planning a BC Version Upgrade and I think I will simultaneously replace the current CI Pipeline with the ones we are using in our own environments. The original plan was to use the Hello-World Templates and to do as little customizing as possible but now I would be on the hook of supporting multiple different customized Pipelines and that is too much hassle.
Although I have to disagree with you a little bit. Because in most of our Pipelines we are reusing the running containers and that process is at least 100-120 seconds faster than creating a new container from a cached image. And that time saved on 4 consecutive builds would speed up the build time by almost 25 percent for this one customer... so I think it would be a nice option to have an option to reuse Container with Run-AlPipeline ... but I understand that in most instances that would not work
As far as I am concerned though this issue can be closed

I have kind of given up on that right now. We were already planning a BC Version Upgrade and I think I will simultaneously replace the current CI Pipeline with the ones we are using in our own environments. The original plan was to use the Hello-World Templates and to do as little customizing as possible but now I would be on the hook of supporting multiple different customized Pipelines and that is too much hassle.
Although I have to disagree with you a little bit. Because in most of our Pipelines we are reusing the running containers and that process is at least 100-120 seconds faster than creating a new container from a cached image. And that time saved on 4 consecutive builds would speed up the build time by almost 25 percent for this one customer... so I think it would be a nice option to have an option to reuse Container with Run-AlPipeline ... but I understand that in most instances that would not work
As far as I am concerned though this issue can be closed

Thanks for the input.
I will consider whether I can make the reusability in Run-AlPipeline better.

Thanks for the input.
I will consider whether I can make the reusability in Run-AlPipeline better.


design: default to Light tables in repl

i propose that kui should default to Light tables in the REPL:

to keep the rendering of the CLI output closer to a terminal
impose less UI clutter in the repl
keep attention focused on the sidecar when it's open, not distracting the users' eyes towards the repl with heavily decorated tables


Improve task name handling

Building off the work in #44, I've made some improvements to the handling of task names while hopefully maintaining backwards compatibility.
The new file tasks.json was generated using the files in json_creation.zip:

task_names.json: A file created for internal use from data in the paper and repository
convert.py: A script to combine our JSON file and your dicts into a new file for inclusion in the library

I didn't actually test my changes by running ScienceWorld, but the tests make me pretty confident it would work.

In retrospect, it seems like referencing the tasks by either the ID in the paper (e.g. "3-1") or their detailed name (e.g. "create-a-circuit") is the way to go, since it makes sure there's no ambiguity.  The 0-29 numbering that's auto-sorted seemed great in development, but seems less great in retrospect. :)


C++ Class Template

Hackerrank problem link
Provide your hackerrank problem link here.
https://www.hackerrank.com/challenges/cpp-class-template-specialization/problem?isFullScreen=true
Issue Checklist

[ ] If you have previously contributed to this repo, you declare that you have not made a pull request for more than one issue in this repo till now.
[ ☑] Your forked repo is up-to-date with the the origin remote.
[☑ ] Have you checked that the hackerrank problem you are raising is not already present in the repo?
[☑ ] Have you checked that the hackerrank problem you are raising is not raised by or assigned to another contributor?

Hacktoberfest Contributor

[ ☑] Are you a Hacktoberfest Contributor?

Any other Changes?
If you are raising an issue with some more changes, please provide the details here.

Please assign it to me I am hactoberfest contributer

Hey, @Prajwalgupta You have made a PR in your forked repo and did not made a PR in the original repo.


Introducing new Cluster Group Affinity Rule commands

PR Summary
Adding new command to the module.

PR Checklist

[x] Descriptive Title: This PR's title is a synopsis of the changes it proposes.
[x] Summary: This PR's summary describes the scope and intent of the change.
[x] Contributor's Guide: I have read the contributors guide.
[x] Style: This PR adheres to the style guide.

@scanum seems is still a draft

@robinharwood - happy to merge this one if you're finished with it.

Yes please @michaeltlombardi, I was waiting for the first PR so that link wasn't broken 😄


Removed unnecessary conversion

append is already returning the correct type here.

Pull Request Test Coverage Report for Build 106

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.146%

Totals

Change from base Build 99:
0.0%

Covered Lines:
981

Relevant Lines:
1461

💛  - Coveralls

Pull Request Test Coverage Report for Build 106

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.146%

Totals

Change from base Build 99:
0.0%

Covered Lines:
981

Relevant Lines:
1461

💛  - Coveralls


enhancement: Add table length to multi index api.

this would be very handy to do pagination on the frontend/cleos without relying on offchain databases like demux.
We now only  know that there are "more" entries when reading long tables. It would be nice to have a number here!
For example if I have a table of length 100 and I request the table with limit 10, it would make sense that there is a key  in the results holding the value 90 {more: 90}.

@taokayan can you give me an example how to get the length of a multi index table without retrieving all entries? You said it's implemented but I don't see any reference to it in the issue you referenced. thanks a lot!

The value of "count" represents how many rows in the table in "get scope":
{
      "code": "eosio.token",
      "scope": "a11111111111",
      "table": "accounts",
      "payer": "eosio",
      "count": 1
    }


Source of entity dictionary

Do you create the entity dictionary based on any medical database?
Thanks!

In SMITH we used a custom dictionary that was derived from the ICD10 catalogue. But this is not a necessity to this project, you can use any dictionary for your purpose. It just needs two tab-separated columns. The first column holds the word, the second column holds the ID of the concept. This was the ICD10 code in our work.


On the Product Tab at Edit Request make button non-clickable if the user did not change any of the fields' values.

Describe the bug
On the Product Tab if the user did not change any of the values of the product the button allows to submit an Edit Request. That leads to a bug which doesn't allow to approve or reject such request.
Environment
Met on various instances.
To Reproduce
Steps to reproduce the behaviour:
Go to the Product Tab.
Click on one of the products.
Do not touch any fields.
Click Submit in the bottom of the page.
Further steps optional, to see the bug from Admin side:
5. Login as admin.
6. Go to the mentioned earlier request.
7. Scroll down to see the grayed out buttons.
Expected behaviour
The buttons are grayed out on the user side if he did not change any values on the Edit Request page.

@calbertan and I met regarding this ticket. After going through the code I realized that this was in fact a very complicated issue due to complex form validation logic with material UI. Being that it is not critical, I decided that it would be better to direct Christopher's time to a more critical ticket.
Also, we are using a different form validation method for the new designs with tailwindui components that makes form validation significantly easier.
It is great that @calbertan got to work on this to understand how complex form validation is, but going forward we can use him on some more important tickets.


Prefixed fullscreen API is deprecated on Firefox

On current versions of Firefox (I am using 47.0), the developer console shows a message:
Prefixed Fullscreen API is deprecated. Please use unprefixed API for fullscreen. For more help https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API

@DavidAnderson684 This is strange, plugin uses prefixed API only if unprefixed is not available. Is this issue still applicable? I am checking in Firefox 50 and don't see any messages.

I can confirm that we no longer get this in the Firefox developer console (Firefox 51).


Rudderstack poc

Switch tracking from Freshpaint to Rudderstack.

Events successfully showing in Rudderstack

I was unsure about exposing the write key and auth header in the repo. We previously exposed the Freshpaint token, but it doesn't seem like best practice.

@kylemcnair If you can think of a different approach, I'm all ears.

@kylemcnair If you can think of a different approach, I'm all ears.

@erezsh I don't have something in mind, but wanted to raise it. I talked to Dan about it, and don't think it's a blocking concern. I'll keep an eye out for alternatives and can always circle back in a subsequent PR.


fix erroneous indexed_color results

First off thanks for Alacritty, I've been loving it!
Since v0.2.1 I attempted to set custom indexed_colors and noticed that I was getting erroneous results.
If set to a color value of 200, nothing would get set:
- { index: 200, color: '0x2ec6c6' }
If set to a color value of 20, 20 would be set along with other indexed numbers (random from 25-160):
- { index: 20, color: '0x2ec6c6' }
20 20: Rgb { r: 46, g: 198, b: 198 }
25 20: Rgb { r: 46, g: 198, b: 198 }
30 20: Rgb { r: 46, g: 198, b: 198 }
35 20: Rgb { r: 46, g: 198, b: 198 }
40 20: Rgb { r: 46, g: 198, b: 198 }
55 20: Rgb { r: 46, g: 198, b: 198 }
60 20: Rgb { r: 46, g: 198, b: 198 }
65 20: Rgb { r: 46, g: 198, b: 198 }
70 20: Rgb { r: 46, g: 198, b: 198 }
90 20: Rgb { r: 46, g: 198, b: 198 }
95 20: Rgb { r: 46, g: 198, b: 198 }
100 20: Rgb { r: 46, g: 198, b: 198 }
125 20: Rgb { r: 46, g: 198, b: 198 }
130 20: Rgb { r: 46, g: 198, b: 198 }
160 20: Rgb { r: 46, g: 198, b: 198 }
This PR compares the ic.index value to the full_cube mutable index variable instead of 16 + r + g + b. Using this method I was able to get consistent and accurate indexed_color results.

Requested changes made including using if...else.
Also added the fix to the changelog.


[$injector:unpr] Unknown provider: $ionicNativeTransitionsProvider

I got this very strange error....
Error: [$injector:unpr] Unknown provider: $ionicNativeTransitionsProviderProvider <- $ionicNativeTransitionsProvider
I'v used
ionic plugin add https://github.com/Telerik-Verified-Plugins/NativePageTransitions#0.6.2
imported the  ionic-native-transitions.min.js from github and put it in the index.html file
I added 'ionic-native-transitions' as dependency in app.js
angular.module('myapp.external', ['ionic-native-transitions']);
angular.module('myapp', ['myapp.external']);

but I got this error.... any idea?
thank you

Make sure the ionic-native-transitions file is correctly injected in your app.

sorry, what do you mean?  I have the .js file in my path, and imported it in .index.html.
I use $ionicNativeTransitionsProvider only as directive and in state, as
.state('poi', {
url: '/poi',
templateUrl: 'templates/poi.html',
nativeTransitions: {
"type": "flip",
"direction": "up"
},
controller: 'descriptionPanelController',
controllerAs: 'descCtrl'
})
so I guess shouldn't inject it anywhere else.

missing $ionicNativeTransitionsProvider either means that the script is not injected in the page or that it is not added as a dependency.
Which version are you using?

ionic plugin add https://github.com/Telerik-Verified-Plugins/NativePageTransitions#0.6.2
and the imported .js file says
/*!
 * ionic-native-transitions
 *  ---
 * Native transitions for Ionic applications
 * @version: v1.0.0-rc10
 * @author: shprink<EMAIL_ADDRESS> * @link: https://github.com/shprink/ionic-native-transitions
 * @license: MIT
 *
 */

it works... sorry, I was injecting '$ionicNativeTransitionsProvider' also in app.run(). I removed the dependency from .run() and now it works.

I am also facing same issue when include $ionicNativeTransitionsProvider in config. All the default transition options are working fine without adding this provider but when trying to override and include it start giving unknown provider.
I have include ionic-native-transitions.js in index html
Add 'ionic-native-transitions' in app js
Transition works fine when add nativeTransitions in routes e.g.
.state('app.intro', {
        url: '/intro',
        nativeTransitions: {
          "type": "fade",
          "duration": "300"
        }
      })

Unknown provider error when
.config(function ($stateProvider, $urlRouterProvider, $ionicConfigProvider, $ionicNativeTransitionsProvider) {
Using ionic driftyco/ionic-bower#1.0.0
Any idea?


Linode node driver RKE2 Provisioning

Framework Updates:
Added support for provisioing linode RKE2 clusters. Including:

linode cloud credential helper
rke-machine-config.cattle.io.linodeconfig machine pool config helpers.

Validation test updates
Updated provisioning validation tests to account for linode node provider.

@paynejacob fixed merged conflicts

Can we squash the commits?

Can we squash the commits?

Commits have been squashed


Music recording

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error '....'

Expected behavior
A clear and concise description of what you expected to happen.
Log files
If possible, add log files from /var/log/mycroft/ to help explain your problem.
You may also include screenshots, however screenshots of log files are often difficult to read and parse.
If you are running Mycroft, the Support Skill helps to automate gathering this information. Simply say "Create a support ticket" and the Skill will put together a support package and email it to you.
Environment (please complete the following information):

Device type: [e.g. Raspberry Pi, Mark 1, desktop]
OS: [e.g. Ubuntu, Picroft]
Mycroft-core version: [e.g. 20.08]
Other versions: [e.g. Adapt v0.3.7]

Additional context
Add any other context about the problem here.
Please think carefully about whether you have modified anything in Mycroft's code or configuration files.  If so, can you reproduce this on a clean installation of Mycroft? Many "bugs" turn out to be non-standard configuration errors.

Hi there, there's nothing here except the default text so I'm assuming your a bot trying to look legitimate by posting in other projects.
If not, please feel free to re-open the ticket with some more detail.


Enhance the TypeScript types

⚠ Issue
close #

✏ Description
Avoid slow types and make objects read-only.

🔄 Type of the Change

[ ] 🎉 New Feature
[ ] 🧰 Bug
[ ] 🛡 Security
[ ] 📖 Documentation
[ ] 🏎 Performance
[x] 🧹 Refactoring
[ ] 🧪 Testing
[ ] 🔧 Maintenance
[ ] 🎽 CI
[ ] 🧠 Meta

[x] I agree to follow the Code of Conduct.

@coderabbitai review

@coderabbitai full review

@coderabbitai full review


raids plugin: add bats locator

This addition to the raids plugin will help locate bats in the thieving room. The chests are overlayed with transparent coloured dots. Unvisited chests are magenta, grubs chests are blue but these will be hidden, poison chests are green and the bats chest is white. Unvisited chests that are most likely to contain bats or poison have a bigger dot and are not transparent. Previously, indices of the chests were used instead of dots and an enlarged indices would represent the most likely chests. Tim Lehner's pull request has been used as a reference and the dots looked more promising. Tim's pull request was also used as a reference to make sure the functionality of this bats locator would surpass or atleast be equal to that of Tim's.
Initial state of the room with a left turn.

State of the room when a poison chest has been found.

State of the room when the bats chest has been found, in this case all three poison chests were found before the bats chest.

The bats locator preemptively hides chests with grubs from the overlay. Finding a poison chest will mark all other chests as grubs that are not in the same solution sets as the poison chest. This is all based on the solution sets given by Not Noob and Endless Dawn. It could happen that the chests in the thieving room are not yet supported by the solution sets. If this happens, the bats locator will fallback and hide the found chests containing grubs and show the found chests containing poison or bats. The poison and bats will not be overlayed with a dot but with a number. This number is the index of the chest starting from 0. The indices go from near to far and left to right when facing the entrance of the thieving room. This is a bit different from the existing online tools but it is consistent. Drawing numbers instead of dots will make it easier for people to report the invalid or missing solution set. It is advised to search all the chests before reporting. A few solution sets have been added or enhanced during development and the solution sets from the form of Endless Dawn's sheet have not been added. Some solution sets coming from Not Noob and Endless Dawn contain only two or three chests while most contain four and there might be a duplicate somewhere. Transforming the solution sets was a manual labor and mistakes could have been made.
A bats chest has been found in the room with a right turn.

A chest is opened containing poison which was not expected by the bats locator so it fallsback. None of the other chests were opened otherwise they would not show a transparent magenta dot.

The bats locator can handle opened chests when starting the plugin. The bats locator can not differentiate a poison chest from a bats chest when both are open when starting the plugin. The bats locator can be enabled by using the checkbox in the raids plugin menu. The checkbox is only there to show or hide the overlay, the bats locator registers spawning chests regardless of the checkbox.
Chest numbers of right turn, left turn and straight room.
Credits to Tim Lehner, Not Noob, Endless Dawn and myself.
Closes #2592
Closes #3115

I found that it is relatively easy to find not known solution sets but it is hard to detect solution sets that are partly incorrect. For example in the left room, (9, 34, 53, 62) comes from Not Noob but the solution I found in game was (13, 34, 53, 62). Both could be correct but it is hard to know if (9, 34, 53, 62) is incorrect.

If we don't know the correctness of completeness of this, maybe we just add it into external plugins?

If we don't know the correctness of completeness of this, maybe we just add it into external plugins?

I like to see it with the main plugins but if that is not option then external plugins will have to do.

I'd be fine with it in the main client if it were well understood and the code was more organized. It is hard for me to handle bug reports when a large portion of the solver logic is a bunch of magic numbers that may or may not be complete or correct.

Would it be possible to upload the solution set once three chests with poison and one chest with bats is found? Solutions sets could be downloaded when runelite is started and the bats locator can load them in. However, this will only work when solution sets consist of four chests and Jagex doesn't change the solution sets.

@Trevor159 can you take this and refactor it?

@Trevor159 can you take this and refactor it?

I personally think this is better suited for external plugins, but if you want it in release idm.

That would be fine too, I just didn't want this to get lost.

@chestnut1693 do you mind PRing this to the plugin-hub?

I do not mind but I first need to get familiar with the plugin-hub and figure out why downloading the plugin manifest keeps failing.

I do not mind but I first need to get familiar with the plugin-hub and figure out why downloading the plugin manifest keeps failing.

you should come in the discord if you need help with stuff like that, there is a developer channel to ask questions in. Also the readme here has a guide for the plugin-hub https://github.com/runelite/plugin-hub

added as external plugin


server: fix delete resource tag permission

Description
Fixes #6623
Thi PR fixes resource tag deletion behaviour. The permission check should be done only for the tags that are passed in the API call instead of checking for all the tags for the resource.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3968

@blueorangutan test

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-4678)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42816 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6634-t4678-kvm-centos7.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_08_upgrade_kubernetes_ha_cluster
Failure
3653.54
test_kubernetes_clusters.py

test_09_delete_kubernetes_ha_cluster
Failure
0.05
test_kubernetes_clusters.py

ContextSuite context=TestKubernetesCluster>:teardown
Error
74.81
test_kubernetes_clusters.py

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6634 (SL-JID-2158)

@blueorangutan package

@blueorangutan package

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3999

@blueorangutan test

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


Use npm lightwallet again or switch to other wallet

We needed to switch to our own fork of the ethereum lightwallet because the current version was broken.
We should switch back once this is fixed. If this is not fixed in the next time, we need to consider switching to a better maintained wallet lib.

Opened an issue with more information on switching the wallet to ethers.js https://github.com/trustlines-network/clientlib/issues/164. I think in the mid to long run we should definitely switch but for now stick with eth-lightwallet.

Closed via PR #191


Support dead code elimination for ES6 getters and setters

Currently, getters and setters desugar to Object.defineProperties, which doesn't allow for shaking, inlining, and other analysis. With ES6 adoption, users will want to have these behave as they expect other methods to behave in regards to their minified output.

This is probably a long ways out.

Duplicate of #1157.


Removed rubysl from the Gemfile.

This hasn't been required anymore since quite a while. Starting with 2.2.0 (if I
remember correctly) Rubinius takes care of ensuring the rubysl Gems are always
available, with or without Bundler.

Thanks!


JSON-LD Signature Support

What's here:
This PR adds support for JSON LD Credentials via vc-js and provides signature suite implementation for

EcdsaSecp256k1RecoverySignature2020
Ed25519Signature2018

Other LD Context definitions and LD-Signature algorithms can be included dynamically within Veramo, but they need to be wrapped.
LinkedDataSignature Interfaces must be wrapped into VeramoLdSignature that allow for the translation of the Veramo (typed) ecosystem into vc-js. Futhermore, VeramoLdSignature offer quite the powerful callbacks into the documentLoader and signature process in order to solve incompatibilities between Veramo and vc-js. Please have a specific look at those functions.
Open Points (TBD link to related tickets).

A challenge/response mechanism for VPs is currently not implemented in Veramos SDR flow and hardcoded challenge/responses are implemented for LD-based VPs

fixes #273
new credential-ld package
Support for LD-Signatures is optional.
If the @veramo/credential-ld plugin is not used, then creation and verification of LD VC/VPs will fail with an error that hints at installing the package.

Improved API to create VC/VP
This PR also introduces a few improvements to the ways credentials and presentations are created and verified.
For creation, the data types of the payloads required have been relaxed  See CredentialPayload/PresentationPayload.
Credential and Presentation related data types are now defined in @veramo/core, since they are shared by multiple
packages (credential-w3c and credential-ld).
fixes #756

Introduced API for verification!!
Finally, you can call agent.verifyCredential() and agent.verifyPresentation() and get a result instead of trying to force these through the MessageHandler.
The result is just a boolean for this PR, but it will be improved by #375

new package for common converters
A new @veramo/utils package is now available that provides some common methods to help with low level conversions and the interpreting of some types.
--
Follow up work

[ ] add support for EcdsaSecp256k1Signature2019
[ ] add support for Ed25519Signature2020
[ ] add support for EthereumEIP712Signature2021 #422
[ ] fix output of createCredential for JWT; people don't realize that Veramo returns the internal, parsed credential. Same for VP-JWT
[ ] extend verification result from boolean to a more expressive output #375

relates to #375

Add (optional) KeyID or VerificationMethodID to CreateCredential and pick key according to input.
Add a "VeramoPresentationContext" that allows for issuanceDate and "remove" dynamic deletion within presentations.

@mirceanis Sorry totally overlooked you asked a question.
What we are seeing and what is also my assumption is that most json-ld implementation are using ed25519 keys and then specifically Ed25519Signature2018 and these days Ed25519Signature2020 signature suites and verification methods, because of the blockchain heritage of a lot of DID methods. The latter version basically is a representation of the key in multibase format, so for ed25519 it is prefixing the proofValue of the verification method with the character 'z'.
Ed25519Signature2020: https://w3c-ccg.github.io/lds-ed25519-2020/
Ed25519Signature2018: https://w3c-ccg.github.io/lds-ed25519-2018/
The next interesting implementation is the ecdsa suites and verification methods, because of hardware support in mobile devices (as RSA), but they are less widely used in json-ld than ed25519 TTBOMK

Great work, thank you!
Do you have plans to publish these changes to npm?


Fixes for Issue 43

Some basic renames and a minor deprecation fix.
Solves Issue 43

Will take a look soon - thanks!

LGTM

Build fail: https://drone.io/github.com/tleyden/open-ocr/17


Ensure variables, gradients and bounds remain ordered

Previously the variables were sorted causing the bounds/gradient to be randomly shuffled. This PR sorts the variables when initialize is called and then uses that ordering when necessary.

LGTM!

Nice catch!


B-20653 Integration Rebase

Rebase from
Integration PR: https://github.com/transcom/mymove/pull/13620
Integration Kickback PR: https://github.com/transcom/mymove/pull/13687

Test coverage on server failed.
Last run: Fri 04 Oct 2024 09:31:44 PM UTC
Refer to this report to see coverage details for the server app.
Documentation for test coverage can be found at this link.


Size is invalid on SubImage

It might be expected that Image.Size is the size of Image.Bounds but this is not the case with SubImage created images which is causing me some math headaches. Take the following code:
package main

import (
	"fmt"
	"image"

	"github.com/hajimehoshi/ebiten"
)

func main() {
	img, _ := ebiten.NewImage(100, 100, ebiten.FilterDefault)
	w, h := img.Size()
	fmt.Printf("Bounds: %v, Size: %v - %v\n", img.Bounds(), w, h)

	subImg := img.SubImage(image.Rect(20, 20, 40, 40)).(*ebiten.Image)
	subW, subH := subImg.Size()
	fmt.Printf("Bounds: %v, Size: %v - %v\n", subImg.Bounds(), subW, subH)
}

This outputs:
Bounds: (0,0)-(100,100), Size: 100 - 100
Bounds: (20,20)-(40,40), Size: 100 - 100

But you would expect:
Bounds: (0,0)-(100,100), Size: 100 - 100
Bounds: (20,20)-(40,40), Size: 20 - 20

If this is by intention, I cannot see it documented anywhere.

@hajimehoshi - yeah, this broke all DrawImage calls which leverages Size. Can you confirm w/ a go build -a on any of your examples while having this commit checked out?

Oops, I'll revert this asap, and fix this again. Sorry.


UX fix for transform

If a user has an existing transform manifest in their transform dir, no error occurs, and it is not replaced. It may be useful to log a message to the user indicating this, and allow them to re-write the existing manifest with the new transform.

From what I recall, if a new transform file is generated, then any old ones are overwritten, but if there are no-longer-relevant old transform files, those are left alone (and not looked at). The intent (with the initial implementation) was that if I run transform and then apply, everything generated in the transform step is available for apply, and anything not touched by the transform step is ignored by apply. To support this, we do delete whiteout files for resources that are no longer indicated as whiteout.
So I have a couple questions on this:

Are you seeing new transforms not being created if there's an old file? If so, that's a bug and we need to fix it.
What should we do with other files that already exist prior to running transform? Delete them all? (that would be relatively easy.) Warn on any that exist that we're no longer dealing with? (This is probably not the right approach. We'd have to create a list of files, then identify which ones we overwrote, and then log a warning on anything in the list that wasn't touched again.)

It may be that for the "not relevant to this transform" file problem we want to provide a flag indicating whether or not to delete the directory contents prior to running transform. Perhaps by default it should be false (to lessen the chance of a user accidentally providing a directory that they actually need -- imagine a user choosing the current directory, or their home directory, as a transform dir). Further, perhaps we should only delete files that fit the transform file naming schemes -- so we'd only delete patch files and whiteout files, not other files.

@sseago We were seeing 1.

@shawn-hurley Ok, if we're failing to create new transform files as needed, that may be a regression from earlier behavior -- or maybe I didn't test things as I thought I did.  The os.Create(tfPath) call should create a new file it it doesn't exist or truncate the existing file if it's already there. If it's not doing that, then I'm not sure why.


Manager to run mount propagation test instead of the driver-deployer

Fixed issue(https://github.com/rancher/longhorn/issues/129)

Have you tested both cases?  (mount propagation enabled for cluster and disabled).

@yasker Yeah, I have tested enable/disabled mount propagation cases.

Wait, the order of commit is wrong. I don't think driver: Update MountPropagation option detect function can compile without the updated client.

@yasker Sorry about that. After separate the commit, the date of commit is different which caused a wrong order... I have fixed it.

Have you tested the final commit? The updated of the go client breaks the CSI plugin.
[longhorn-csi-plugin-drjnl longhorn-csi-plugin] time="2018-08-01T16:35:51Z" level=info msg="ControllerServer ControllerPublishVolume req: volume_id:"pvc-008b9885-95a7-11e8-8a76-def8917872c5" node_id:"yasker-longhorn-dev-1" volume_capability:<mount:<fs_type:"ext4" > access_mode:<mode:SINGLE_NODE_WRITER > > volume_attributes:<key:"storage.kubernetes.io/csiProvisionerIdentity" value:"1533140321748-8081-rancher.io/longhorn" > "
[longhorn-csi-plugin-drjnl longhorn-csi-plugin] E0801 16:35:51.484006       1 utils.go:100] GRPC error: rpc error: code = Internal desc = Failed to parse: {"actions":{"attach":"http://longhorn-backend:9500/v1/volumes/pvc-008b9885-95a7-11e8-8a76-def8917872c5?action=attach","engineUpgrade":"http://longhorn-backend:9500/v1/volumes/pvc-008b9885-95a7-11e8-8a76-def8917872c5?action=engineUpgrade","recurringUpdate":"http://longhorn-backend:9500/v1/volumes/pvc-008b9885-95a7-11e8-8a76-def8917872c5?action=recurringUpdate","replicaRemove":"http://longhorn-backend:9500/v1/volumes/pvc-008b9885-95a7-11e8-8a76-def8917872c5?action=replicaRemove"},"conditions":{"scheduled":{"lastProbeTime":"2018-08-01T16:22:49Z","lastTransitionTime":"2018-08-01T16:22:49Z","message":"","reason":"","status":"True","type":"scheduled"}},"controllers":[{"address":"","currentImage":"","endpoint":"","engineImage":"rancher/longhorn-engine:31c42f0","hostId":"","name":"pvc-008b9885-95a7-11e8-8a76-def8917872c5-e-934ad68a","running":false}],"created":"2018-08-01 16:22:06 +0000 UTC","currentImage":"rancher/longhorn-engine:31c42f0","engineImage":"rancher/longhorn-engine:31c42f0","fromBackup":"","frontend":"blockdev","id":"pvc-008b9885-95a7-11e8-8a76-def8917872c5","links":{"self":"http://longhorn-backend:9500/v1/volumes/pvc-008b9885-95a7-11e8-8a76-def8917872c5"},"migrationNodeID":"","name":"pvc-008b9885-95a7-11e8-8a76-def8917872c5","numberOfReplicas":2,"recurringJobs":null,"replicas":[{"address":"","currentImage":"","dataPath":"/var/lib/rancher/longhorn/replicas/pvc-008b9885-95a7-11e8-8a76-def8917872c5-80ffafe0","diskID":"681de48e5fe8bbb9","engineImage":"rancher/longhorn-engine:31c42f0","failedAt":"","hostId":"yasker-longhorn-dev-3","mode":"","name":"pvc-008b9885-95a7-11e8-8a76-def8917872c5-r-bcc4d853","running":false},{"address":"","currentImage":"","dataPath":"/var/lib/rancher/longhorn/replicas/pvc-008b9885-95a7-11e8-8a76-def8917872c5-953d8e44","diskID":"681de48e5fe8bbb9","engineImage":"rancher/longhorn-engine:31c42f0","failedAt":"","hostId":"yasker-longhorn-dev-1","mode":"","name":"pvc-008b9885-95a7-11e8-8a76-def8917872c5-r-c0f42c6b","running":false}],"robustness":"","size":"2147483648","staleReplicaTimeout":20,"state":"detached","type":"volume"}
[longhorn-csi-plugin-drjnl longhorn-csi-plugin] : json: cannot unmarshal object into Go struct field Volume.controllers of type string

I've fixed it at https://github.com/rancher/longhorn-manager/commit/1ed970ca96426082ad7b4093e8853be674ba3362


Error - unknown filter

Hi,
After implementation according readme I get following error:
"error","message":"unknown filter","filter_name":"check_dependencies"
Is this due to fact that this extension is just for Sensu Enterprise?
If so, it could be better to note it in readme in addtion to https://sensuapp.org/docs/latest/enterprise/filters/check-dependencies.html
Thanks

one cosmetic thing:
In readme part "Edit /etc/sensu/conf.d/extensions.json to load it" -> there is one bracket "}" missing.

hi @mcbsdEU, thanks for bringing the invalid JSON to my attention. I've fixed it in 81c48bc35624a58772c4c40a961916cf08c26aa6.
This extension is based on the Sensu Enterprise implementation you referenced. It is expected to work in Sensu Core when properly installed and will be added as a built-in extension in a future version of Sensu Core.
In working up a reply to this issue I see that we've shipped the current release in an unusable state. Specifically we renamed the gem project but didn't rename the extension Ruby file to match, so I've opened https://github.com/sensu-extensions/sensu-extensions-check-dependencies/issues/6 to track that.

Thanks!

@mcbsdEU version 1.0.1 is now on rubygems, please let us know if you have any further issues.

Hi,
I can confirm all is working now as expected.
Thanks


Shader Variant Compiling

Describe the bug
It appears that when I go to compile, FlatKit makes Unity want to do a LOT of shader variants. 154618M.
To Reproduce
So I try to compile as usual. I only have 36 shaders with 79 total variants but I get the above listed variants:

I removed ALL shaders from the Always Included Shaders list and my project compiled in 20 seconds but when run it of course was all pink. I went back and added JUST Stylized Surface and tried to build and it went right back to the 154 trillion shader variants.
Expected behavior
I expect it to only use proper shader variants. I've even tried using "Shader Control" from the asset store to disable certain keywords and it still wants the full 154 trillion.
Screenshots
see above.
Unity details:

Flat Kit version: 3.0.5
Unity version: 2021.3.10f1
Graphics Pipeline: URP
URP version (if applicable): 12.1.7
Development OS: Windows

Build platform:

Platform: Windows
Test device: Ryzen 3700X/32GB RAM/RTX 3070

Additional context
I know nothing about shaders. I've googled these issues and apparently since about 2021.2 (URP 12) shader variants have gotten out of hand for people and require many many hours of compiling for some projects. However, this seems even outside of that scope. I would love to provide any sort of assistance to you that you would require in replicating. I will also continue to tinker with things on my end. Otherwise, please do reach out and I will be happy to help.

Hi! We are not able to reproduce the issue so far, using the same URP and Unity major version compiling is relatively quick in our experiment. Can you please try building a demo scene included with the asset (e.g. "Pool" scene)? Does the issue persist?

If I don't have Stylize Surface in the Shader list it compiles in seconds but everything is pink. If I have it in the list I am back to trillions:

ProjectSettings.zip
I am attaching my projectsettings folder to see if you see any weirdness. I am also I guess going to abandon this project ultimately and copy over my work to a fresh project start too? I have no clue what is happening.

So you've tried building a demo scene and it still has lots of variants? In that case trying a fresh project is a good idea. But before transferring your work over to the new project, please try building a demo scene again to check if the issue is gone in that project.

Yeah it looks like the new project compiling the pool takes seconds.
I have no idea how my project got so bogged down. I want to say maybe Nature Render 2020 could be to blame. As far as I can tell, it intercepts ALL shader imports so it can add to them. I wonder if that did it.
I will start importing my work into this project and see how it goes. Otherwise, this clearly doesn't seem like a you guys thing. Thank you so much for your speedy responses.

I didn't even see the M display. Took me 3:30 to compile the Polygon Nature scene with some added characters and Stylized Surface on some stuff. Looks to be resolved. Really wish I could figure out where it went wrong but looks like I am good. Thank you guys.


Create an example .fhir-backed-vc file

Also need to review for alignment with https://github.com/smart-on-fhir/health-cards/issues/12

We now have examples for .smart-health-card files


Allow installation with React 18

The current peer deps don't include React 18, which means that package-manager-specific overrides workarounds are needed to get it to install with React 18.

Thanks!

:tada: This PR is included in version 1.0.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: