Site build broken with Java 11

Running mvn site with Java 11 results in several errors and a failed build.
Since we haven't actually used/deployed site for years, it begs the question if we actually need this and want to spent the effort of fixing this.

mvn site build log
%   mvn --batch-mode -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
    site -Daggregate=true site:stage "-DstagingDirectory=$(pwd)/site" \
    -P 'none,!frontend' \
    -DskipTests \
    -Dcheckstyle.skip=true \
    -Dpmd.skip=true \
    -Dcpd.skip=true

[…]

[INFO] >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
[INFO] Forking Opencast :: workspace-impl 10-SNAPSHOT
[INFO] >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven) @ opencast-workspace-impl ---
[INFO]
[INFO] --- buildnumber-maven-plugin:1.4:create (default) @ opencast-workspace-impl ---
[INFO] ShortRevision tag detected. The value is '7'.
[INFO] Executing: /bin/sh -c cd '/home/lars/dev/opencast/modules/workspace-impl' && 'git' 'rev-parse' '--verify' '--short=7' 'HEAD'
[INFO] Working directory: /home/lars/dev/opencast/modules/workspace-impl
[INFO] Storing buildNumber: b00dbcd at timestamp:<PHONE_NUMBER>908
[INFO] Storing buildScmBranch: gh-actions-tests
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.1:check (default) @ opencast-workspace-impl ---
[INFO]
[INFO] >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
[INFO] Forking Assemblies 10-SNAPSHOT
[INFO] >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven) @ opencast-assemblies ---
[INFO]
[INFO] --- buildnumber-maven-plugin:1.4:create (default) @ opencast-assemblies ---
[INFO] ShortRevision tag detected. The value is '7'.
[INFO] Executing: /bin/sh -c cd '/home/lars/dev/opencast/assemblies' && 'git' 'rev-parse' '--verify' '--short=7' 'HEAD'
[INFO] Working directory: /home/lars/dev/opencast/assemblies
[INFO] Storing buildNumber: b00dbcd at timestamp:<PHONE_NUMBER>920
[INFO] Storing buildScmBranch: gh-actions-tests
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.1:check (default) @ opencast-assemblies ---
[INFO]
[INFO] <<< maven-javadoc-plugin:2.10.4:aggregate < generate-sources @ base <<<
[INFO]
[INFO] 'generate-sources' forked phase execution for maven-javadoc-plugin:aggregate report preparation done
[INFO] configuring report plugin org.apache.maven.plugins:maven-jxr-plugin:2.5
[INFO] configuring report plugin org.apache.maven.plugins:maven-project-info-reports-plugin:2.8.1
[INFO] configuring report plugin org.apache.maven.plugins:maven-pmd-plugin:3.6
[INFO] Relativizing decoration links with respect to localized project URL: https://opencast.org
[INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.2 skin.
[INFO] Skipped "Surefire Report" report (maven-surefire-report-plugin:2.20:report-only), file "surefire-report.html" already exists for the English version.
[INFO] Skipped "JavaDocs" report (maven-javadoc-plugin:2.10.4:aggregate), file "apidocs/index.html" already exists for the English version.
[INFO] Generating "Surefire Report" report      --- maven-surefire-report-plugin:2.20:report
[INFO] Generating "JavaDocs" report             --- maven-javadoc-plugin:2.10.4:javadoc
[WARNING] Are you sure about the <javadocVersion/> parameter? It seems to be 11.09
[INFO]
12 errors
100 warnings
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for opencast 10-SNAPSHOT:
[INFO]
[INFO] opencast ........................................... FAILURE [ 40.562 s]
[INFO] Opencast :: common ................................. SKIPPED
[INFO] Opencast :: metadata-api ........................... SKIPPED
[INFO] Opencast :: workspace-api .......................... SKIPPED
[INFO] Opencast :: list-providers-service ................. SKIPPED
[INFO] Opencast :: dublincore ............................. SKIPPED
[INFO] Opencast :: workflow-service-api ................... SKIPPED
[INFO] Opencast :: message-broker-api ..................... SKIPPED
[INFO] Opencast :: series-service-api ..................... SKIPPED
[INFO] Opencast :: asset-manager-api ...................... SKIPPED
[INFO] Opencast :: authorization-xacml .................... SKIPPED
[INFO] Opencast :: common-jpa-impl ........................ SKIPPED
[INFO] Opencast :: rest-test-environment .................. SKIPPED
[INFO] Opencast :: authorization-manager .................. SKIPPED
[INFO] Opencast :: capture-admin-service-api .............. SKIPPED
[INFO] Opencast :: shared-filesystem-utils ................ SKIPPED
[INFO] Opencast :: search-api ............................. SKIPPED
[INFO] Opencast :: scheduler-api .......................... SKIPPED
[INFO] Opencast :: event-comment .......................... SKIPPED
[INFO] Opencast :: search ................................. SKIPPED
[INFO] Opencast :: ingest-service-api ..................... SKIPPED
[INFO] Opencast :: urlsigning-common ...................... SKIPPED
[INFO] Opencast :: urlsigning-service-api ................. SKIPPED
[INFO] Opencast :: kernel ................................. SKIPPED
[INFO] Opencast :: userdirectory .......................... SKIPPED
[INFO] Opencast :: search-service-api ..................... SKIPPED
[INFO] Opencast :: distribution-service-api ............... SKIPPED
[INFO] Opencast :: publication-service-api ................ SKIPPED
[INFO] Opencast :: distribution-workflowoperation ......... SKIPPED
[INFO] Opencast :: index-service .......................... SKIPPED
[INFO] Opencast :: presets ................................ SKIPPED
[INFO] Opencast :: static-file-service-api ................ SKIPPED
[INFO] Opencast :: statistics-service-api ................. SKIPPED
[INFO] Opencast :: statistics-export-service-api .......... SKIPPED
[INFO] Opencast :: themes ................................. SKIPPED
[INFO] Opencast :: smil-api ............................... SKIPPED
[INFO] Opencast :: composer-service-api ................... SKIPPED
[INFO] Opencast :: admin-ui-index ......................... SKIPPED
[INFO] Opencast :: solr ................................... SKIPPED
[INFO] Opencast :: series-service-impl .................... SKIPPED
[INFO] Opencast :: asset-manager-impl ..................... SKIPPED
[INFO] Opencast :: admin-ui ............................... SKIPPED
[INFO] Opencast :: admin-ui-frontend ...................... SKIPPED
[INFO] Opencast :: animate-api ............................ SKIPPED
[INFO] Opencast :: animate-impl ........................... SKIPPED
[INFO] Opencast :: animate-remote ......................... SKIPPED
[INFO] Opencast :: inspection-service-api ................. SKIPPED
[INFO] Opencast :: animate-workflowoperation .............. SKIPPED
[INFO] Opencast :: annotation-api ......................... SKIPPED
[INFO] Opencast :: annotation-impl ........................ SKIPPED
[INFO] Opencast :: asset-manager-workflowoperation ........ SKIPPED
[INFO] Opencast :: asset-manager-storage-aws .............. SKIPPED
[INFO] Opencast :: asset-manager-storage-fs ............... SKIPPED
[INFO] Opencast :: caption-api ............................ SKIPPED
[INFO] Opencast :: mpeg7 .................................. SKIPPED
[INFO] Opencast :: caption-impl ........................... SKIPPED
[INFO] Opencast :: caption-remote ......................... SKIPPED
[INFO] Opencast :: capture-admin-service-impl ............. SKIPPED
[INFO] Opencast :: comments-workflowoperation ............. SKIPPED
[INFO] Opencast :: composer-ffmpeg ........................ SKIPPED
[INFO] Opencast :: composer-service-remote ................ SKIPPED
[INFO] Opencast :: inspection-workflowoperation ........... SKIPPED
[INFO] Opencast :: composer-workflowoperation ............. SKIPPED
[INFO] Opencast :: oaipmh-persistence ..................... SKIPPED
[INFO] Opencast :: conductor .............................. SKIPPED
[INFO] Opencast :: cover-image-api ........................ SKIPPED
[INFO] Opencast :: cover-image-impl ....................... SKIPPED
[INFO] Opencast :: cover-image-remote ..................... SKIPPED
[INFO] Opencast :: cover-image-workflowoperation .......... SKIPPED
[INFO] Opencast :: crop-api ............................... SKIPPED
[INFO] Opencast :: crop-ffmpeg ............................ SKIPPED
[INFO] Opencast :: crop-remote ............................ SKIPPED
[INFO] Opencast :: crop-workflowoperation ................. SKIPPED
[INFO] Opencast :: db ..................................... SKIPPED
[INFO] Opencast :: dictionary-api ......................... SKIPPED
[INFO] Opencast :: dictionary-hunspell .................... SKIPPED
[INFO] Opencast :: dictionary-none ........................ SKIPPED
[INFO] Opencast :: dictionary-regexp ...................... SKIPPED
[INFO] Opencast :: distribution-service-aws-s3-api ........ SKIPPED
[INFO] Opencast :: distribution-service-aws-s3 ............ SKIPPED
[INFO] Opencast :: distribution-service-aws-s3-remote ..... SKIPPED
[INFO] Opencast :: distribution-service-download .......... SKIPPED
[INFO] Opencast :: distribution-service-download-remote ... SKIPPED
[INFO] Opencast :: distribution-service-streaming-wowza ... SKIPPED
[INFO] Opencast :: distribution-service-streaming-remote .. SKIPPED
[INFO] Opencast :: email-template-service-api ............. SKIPPED
[INFO] Opencast :: email-template-service-impl ............ SKIPPED
[INFO] Opencast :: engage-paella-player ................... SKIPPED
[INFO] Opencast :: engage-theodul-api ..................... SKIPPED
[INFO] Opencast :: engage-theodul-core .................... SKIPPED
[INFO] Opencast :: engage-theodul-plugin-archetype ........ SKIPPED
[INFO] Opencast :: engage-theodul-plugin-controls ......... SKIPPED
[INFO] Opencast :: engage-theodul-plugin-custom-mhConnection SKIPPED
[INFO] Opencast :: engage-theodul-plugin-custom-notifications SKIPPED
[INFO] Opencast :: engage-theodul-plugin-custom-usertracking SKIPPED
[INFO] Opencast :: engage-theodul-plugin-custom-matomo .... SKIPPED
[INFO] Opencast :: engage-theodul-plugin-description ...... SKIPPED
[INFO] Opencast :: engage-theodul-plugin-tab-description .. SKIPPED
[INFO] Opencast :: engage-theodul-plugin-tab-shortcuts .... SKIPPED
[INFO] Opencast :: engage-theodul-plugin-tab-slidetext .... SKIPPED
[INFO] Opencast :: engage-theodul-plugin-tab-downloads .... SKIPPED
[INFO] Opencast :: engage-theodul-plugin-timeline-statistics SKIPPED
[INFO] Opencast :: engage-theodul-plugin-video-videojs .... SKIPPED
[INFO] Opencast :: engage-ui .............................. SKIPPED
[INFO] Opencast :: execute-api ............................ SKIPPED
[INFO] Opencast :: execute-impl ........................... SKIPPED
[INFO] Opencast :: execute-remote ......................... SKIPPED
[INFO] Opencast :: execute-workflowoperation .............. SKIPPED
[INFO] Opencast :: external-api-index ..................... SKIPPED
[INFO] Opencast :: external-api ........................... SKIPPED
[INFO] Opencast :: fileupload ............................. SKIPPED
[INFO] Opencast :: hello-world-api ........................ SKIPPED
[INFO] Opencast :: hello-world-impl ....................... SKIPPED
[INFO] Opencast :: adopter-statistics-api ................. SKIPPED
[INFO] Opencast :: adopter-statistics-impl ................ SKIPPED
[INFO] Opencast :: incident-workflowoperation ............. SKIPPED
[INFO] Opencast :: ingest-download-service-api ............ SKIPPED
[INFO] Opencast :: working-file-repository-service-api .... SKIPPED
[INFO] Opencast :: ingest-download-service-impl ........... SKIPPED
[INFO] Opencast :: ingestdownloadservice-remote ........... SKIPPED
[INFO] Opencast :: working-file-repository-service-impl ... SKIPPED
[INFO] Opencast :: ingest-service-impl .................... SKIPPED
[INFO] Opencast :: ingest-download-service-workflowoperation SKIPPED
[INFO] Opencast :: inspection-service-ffmpeg .............. SKIPPED
[INFO] Opencast :: inspection-service-remote .............. SKIPPED
[INFO] Opencast :: statistics-writer-workflowoperation .... SKIPPED
[INFO] Opencast :: live-schedule-api ...................... SKIPPED
[INFO] Opencast :: live-schedule-impl ..................... SKIPPED
[INFO] Opencast :: logging-workflowoperation .............. SKIPPED
[INFO] Opencast :: lti-service-api ........................ SKIPPED
[INFO] Opencast :: lti .................................... SKIPPED
[INFO] Opencast :: lti-service-remote ..................... SKIPPED
[INFO] Opencast :: lti-service-impl ....................... SKIPPED
[INFO] Opencast :: mattermost-notification-workflowoperation SKIPPED
[INFO] Opencast :: message-broker-impl .................... SKIPPED
[INFO] Opencast :: metadata ............................... SKIPPED
[INFO] Opencast :: notification-workflowoperation ......... SKIPPED
[INFO] Opencast :: oaipmh-api ............................. SKIPPED
[INFO] Opencast :: oaipmh ................................. SKIPPED
[INFO] Opencast :: oaipmh-remote .......................... SKIPPED
[INFO] Opencast :: publication-service-configurable ....... SKIPPED
[INFO] Opencast :: publication-service-configurable-remote  SKIPPED
[INFO] Opencast :: publication-service-oaipmh ............. SKIPPED
[INFO] Opencast :: publication-service-oaipmh-remote ...... SKIPPED
[INFO] Opencast :: publication-service-youtube-remote ..... SKIPPED
[INFO] Opencast :: publication-service-youtube-v3 ......... SKIPPED
[INFO] Opencast :: runtime-info ........................... SKIPPED
[INFO] Opencast :: runtime-info-ui ........................ SKIPPED
[INFO] Opencast :: runtime-info-ui-ng ..................... SKIPPED
[INFO] Opencast :: scheduler-impl ......................... SKIPPED
[INFO] Opencast :: scheduler-remote ....................... SKIPPED
[INFO] Opencast :: schema ................................. SKIPPED
[INFO] Opencast :: search-service-feeds ................... SKIPPED
[INFO] Opencast :: search-service-impl .................... SKIPPED
[INFO] Opencast :: search-service-remote .................. SKIPPED
[INFO] Opencast :: security-shibboleth .................... SKIPPED
[INFO] Opencast :: security-aai ........................... SKIPPED
[INFO] Opencast :: security-cas-client-wrapper ............ SKIPPED
[INFO] Opencast :: security-cas ........................... SKIPPED
[INFO] Opencast :: security-ldap .......................... SKIPPED
[INFO] Opencast :: security-lti ........................... SKIPPED
[INFO] Opencast :: series-service-remote .................. SKIPPED
[INFO] Opencast :: serviceregistry ........................ SKIPPED
[INFO] Opencast :: silencedetection-api ................... SKIPPED
[INFO] Opencast :: silencedetection-impl .................. SKIPPED
[INFO] Opencast :: silencedetection-remote ................ SKIPPED
[INFO] Opencast :: smil-impl .............................. SKIPPED
[INFO] Opencast :: sox-api ................................ SKIPPED
[INFO] Opencast :: sox-impl ............................... SKIPPED
[INFO] Opencast :: sox-remote ............................. SKIPPED
[INFO] Opencast :: sox-workflowoperation .................. SKIPPED
[INFO] Opencast :: static ................................. SKIPPED
[INFO] Opencast :: static-file-service-impl ............... SKIPPED
[INFO] Opencast :: statistics-export-service-impl ......... SKIPPED
[INFO] Opencast :: statistics-service-impl ................ SKIPPED
[INFO] Opencast :: statistics-service-remote .............. SKIPPED
[INFO] Opencast :: statistics-provider-influx ............. SKIPPED
[INFO] Opencast :: statistics-provider-random ............. SKIPPED
[INFO] Opencast :: studio ................................. SKIPPED
[INFO] Opencast :: termination-state-api .................. SKIPPED
[INFO] Opencast :: termination-state-aws .................. SKIPPED
[INFO] Opencast :: termination-state-impl ................. SKIPPED
[INFO] Opencast :: textanalyzer-api ....................... SKIPPED
[INFO] Opencast :: textanalyzer-impl ...................... SKIPPED
[INFO] Opencast :: textanalyzer-remote .................... SKIPPED
[INFO] Opencast :: textanalyzer-workflowoperation ......... SKIPPED
[INFO] Opencast :: textextractor-tesseract ................ SKIPPED
[INFO] Opencast :: themes-workflowoperation ............... SKIPPED
[INFO] Opencast :: timelinepreviews-api ................... SKIPPED
[INFO] Opencast :: timelinepreviews-ffmpeg ................ SKIPPED
[INFO] Opencast :: timelinepreviews-remote ................ SKIPPED
[INFO] Opencast :: timelinepreviews-workflowoperation ..... SKIPPED
[INFO] Opencast :: transcription-service-api .............. SKIPPED
[INFO] Opencast :: transcription-service-persistence ...... SKIPPED
[INFO] Opencast :: transcription-service-google-speech-impl SKIPPED
[INFO] Opencast :: transcription-service-ibm-watson-impl .. SKIPPED
[INFO] Opencast :: transcription-service-amberscript ...... SKIPPED
[INFO] Opencast :: transcription-service-workflowoperation  SKIPPED
[INFO] Opencast :: urlsigning-service-impl ................ SKIPPED
[INFO] Opencast :: urlsigning-verifier-service-api ........ SKIPPED
[INFO] Opencast :: urlsigning-verifier-service-impl ....... SKIPPED
[INFO] Opencast :: userdirectory-ldap ..................... SKIPPED
[INFO] Opencast :: userdirectory-moodle ................... SKIPPED
[INFO] Opencast :: userdirectory-sakai .................... SKIPPED
[INFO] Opencast :: userdirectory-brightspace .............. SKIPPED
[INFO] Opencast :: userdirectory-canvas ................... SKIPPED
[INFO] Opencast :: user-interface-configuration ........... SKIPPED
[INFO] Opencast :: usertracking-api ....................... SKIPPED
[INFO] Opencast :: usertracking-impl ...................... SKIPPED
[INFO] Opencast :: videoeditor-api ........................ SKIPPED
[INFO] Opencast :: videoeditor-ffmpeg-impl ................ SKIPPED
[INFO] Opencast :: videoeditor-remote ..................... SKIPPED
[INFO] Opencast :: workflow-workflowoperation ............. SKIPPED
[INFO] Opencast :: videoeditor-workflowoperation .......... SKIPPED
[INFO] Opencast :: videogrid-service-api .................. SKIPPED
[INFO] Opencast :: videogrid-service-impl ................. SKIPPED
[INFO] Opencast :: videogrid-remote ....................... SKIPPED
[INFO] Opencast :: videogrid-workflowoperation ............ SKIPPED
[INFO] Opencast :: videosegmenter-api ..................... SKIPPED
[INFO] Opencast :: videosegmenter-ffmpeg .................. SKIPPED
[INFO] Opencast :: videosegmenter-remote .................. SKIPPED
[INFO] Opencast :: videosegmenter-workflowoperation ....... SKIPPED
[INFO] Opencast :: waveform-api ........................... SKIPPED
[INFO] Opencast :: waveform-ffmpeg ........................ SKIPPED
[INFO] Opencast :: waveform-remote ........................ SKIPPED
[INFO] Opencast :: waveform-workflowoperation ............. SKIPPED
[INFO] Opencast :: workflow-condition-parser .............. SKIPPED
[INFO] Opencast :: workflow-service-impl .................. SKIPPED
[INFO] Opencast :: workflow-service-remote ................ SKIPPED
[INFO] Opencast :: working-file-repository-service-remote . SKIPPED
[INFO] Opencast :: workspace-impl ......................... SKIPPED
[INFO] Assemblies ......................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  42.975 s
[INFO] Finished at: 2020-11-21T22:05:49+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.6:site (default-site) on project base: Error generating maven-javadoc-plugin:2.10.4:javadoc:
[ERROR] Exit code: 1 - /home/lars/dev/opencast/modules/statistics-export-service-impl/src/main/java/org/opencastproject/statistics/export/package-info.java:1: warning: a package-info.java file has already been seen for package org.opencastproject.statistics.export
[ERROR] package org.opencastproject.statistics.export;
[ERROR]                                       ^
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] javadoc: warning - The code being documented uses modules but the packages defined in http://docs.oracle.com/javase/8/docs/api/ are in the unnamed module.
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/Person.java:28: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/Content.java:28: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/FeedExtension.java:29: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/Enclosure.java:28: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/Image.java:28: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/Category.java:28: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/FeedEntry.java:31: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/Feed.java:31: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/search-service-api/src/main/java/org/opencastproject/feed/api/Link.java:28: error: tag not supported in the generated HTML version: tt
[ERROR]  * Note that this interface is heavily inspired and backed by the excellent rss/atom feed library <tt>Rome</tt>
[ERROR]                                                                                ^
[ERROR] /home/lars/dev/opencast/modules/composer-workflowoperation/src/main/java/org/opencastproject/workflow/handler/composer/PrepareAVWorkflowOperationHandler.java:51: error: tag not supported in the generated HTML version: tt
[ERROR]  * The <tt>prepare media</tt> operation will make sure that media where audio and video track come in separate files
[ERROR]        ^
[ERROR] /home/lars/dev/opencast/modules/composer-workflowoperation/src/main/java/org/opencastproject/workflow/handler/composer/SanitizeAdaptiveWorkflowOperationHandler.java:60: error: tag not supported in the generated HTML version: tt
[ERROR]  * The <tt></tt> operation will make sure that media where hls playlists and video track come in separate files
[ERROR]        ^
[ERROR] /home/lars/dev/opencast/modules/composer-service-api/src/main/java/org/opencastproject/composer/api/EncodingProfile.java:166: error: tag not supported in the generated HTML version: tt
[ERROR]    * the configured entry was <tt>mediaformat.format.xyz.test</tt>, then the key
[ERROR]                               ^
[ERROR]
[ERROR] Command line was: /usr/lib/jvm/java-11-openjdk/bin/javadoc -J-Xmx512m @options @packages
[ERROR]
[ERROR] Refer to the generated Javadoc files in '/home/lars/dev/opencast/target/site/apidocs' dir.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

I don't care about site itself, but pmd, cpd, coverage, and javadocs are all important. Whether there are better ways to generate these reports than site I'm not sure, but I'd imagine. It's dog slow too so if we can cut it that would be a (fairly major) bonus.

When asking about mvn site I was mainly referring to the Javadoc (fixing the title) which we never seem to actually use (though we constantly build it)

Ah. Well that's an easy decision: javadocs are required to push files to maven central :)

The we have to fix them, I guess

I can take a look at this. I see develop is busted, did you have time to check any earlier versions?


gopass sync works without ssh key in ssh agent

Summary
gopass sync command works without ssh key in ssh agent
Please help me to understand the issue
Steps To Reproduce

clear ssh-agent - ssh-add -D
adding ssh key in ssh-agent for gopass syncing ssh-add /path/to/private/ssh-key
try to generate some password gopass generate some/password/path1/password
make gopass sync
password has been generated and pushed to git-server
clear ssh-agent - ssh-add -D
There are no any ssh-key in ssh-agent now. Synchronization should not work now.
try to generate another password gopass generate some/password/path2/password
make gopass sync
But now the sync has happened again and the new password has been pushed to git server
At the same time git clone, git pull, git push fall with an error Please make sure you have the correct access rights
???

Version
gopass 1.14.3-git+HEAD go1.18.2 linux amd64

Yes, that does make sense. We use an persistent ssh control Socket to speed up subsequent sync operations: https://github.com/gopasspw/gopass/blob/master/internal/backend/storage/gitfs/ssh_others.go
You can disable that by overriding GIT_SSH_COMMAND.


Body.update doesn't scale time correctly

When setting the engine's timescale to zero, 0.00 bodies that already have velocity will continue with their velocity nearly constant (depending on scale).
Digging into Body.js I noticed you are applying force/acceleration properly scaled by the timescale set, but you are still taking velocity as is and applying it to the position without scaling.
I easily tested this by stopping time, moving a body into the air above a platform, then toggling the timescale between 1.00 and 0.00. Once the body was moving it would not slow down or stop when I "paused" time.

Last comment, but I'm also not sure why the body parts vertices are being permanently modified instead of used as relative offsets from the root body position and angle. It makes this significantly more difficult to correct as well as rely on the shape data for other operations if it's constantly being modified.


Way to open Wiki page from Grand Exchange plugin in sidebar

Describe the solution you'd like
With the addition of the Wiki plugin I feel like there is a possibility to add more Wiki functionality to the Grand Exchange plugin. Currently when you click on a searched item it opens up the official Oldschool Runescape GE page.
Maybe right clicking could open up the Wiki page of the clicked item.
An alternative is to make the whole block unclickable but add two clickable buttons, one for the GE page and one for the Wiki page.
A picture of the Grand Exchange plugin where right click could open Wiki page of the AGS.

Just use wiki search instead


Template import/export string can be misleading

The string presented to the user to import (and export) templates can be misleading.

Users could try to import full graph templates (.drawio) instead of the function templates (.json) and face the following error message:

Possible mitigations:

Ensure that the opening ImportFileDialog only accepts .json files.
Rename the strings (English and German) to something like "Import Function Template...".
Rename the templates provided in the repository from AttackGraphTemplate_TS50701.json to AttackGraphFunctionTemplate_TS50701.json.

Closes by #163


determine-solution-build-deploy not running when branch is part of a pr

Once the branch you are pushing to becomes the compare branch of a pr, the determine-solution-build-deploy workflow will not be triggered for the PR after running the export-unpack-commit-solution workflow.  This is because the default GITHUB_TOKEN used by workflows does not have permission to allow anything that happens in one workflow to trigger another workflow.  Therefore, the code that pushes the code to the remote must run with elevated permissions using a different token.

https://stackoverflow.com/questions/67550727/push-event-doesnt-trigger-workflow-on-push-paths-github-actions


Update order.py

There was an indentation in your return response while I was testing out my problem. I fixed it for you :). Happy holidays!

I have also seen this error. Please allow this to go through :) Thanks @zedin27 Enjoy your new year!

I just noticed this after making a pull request for the same thing...
I'll keep it up for now as it has a little extra info, and then delete later:  https://github.com/gamagori/pizzapi/pull/44

@zedin27 @aleybe @danielorf Thanks all for the good work :) merged to master


Styles

Can you add some examples how change styles?
For example
menu-header-wrapper {
        align-items: center;
}

I try @StyleSheet, @HtmlImport and other way. But can not apply it

As you probably know it is not possible to style elements that are inside the shadow dom. I will need to introduce a css variable to allow this.

I got the same problems. Tried to change styles but it doesn't work.
Also my custom styles of the view (elements inside the view) are ignored since the view is now contained in the shadow dom of the app-layout.
But it is possible to style vaadin components (e.g. TextField, ComboBox) with the usage of dom-module:
`

@LeshaRB A similiar issue we had on app-layout customization which is app-toolbar background color needs to get update. Although being not so sure about if I did the right thing or if I had any alternatives, I go with js injection after the document gets loaded:
After AppLayoutBuilder.build() method gets run,
css var: --app-layout-bar-background-color needs to get changed
Injected js:
// top tool bar background color css variable customization point
UI.getCurrent().getPage().executeJavaScript("window.onload = function() {\n" +
        "  setTimeout(function() {\n" +
        "    var html = document.getElementsByTagName('html')[0];\n" +
        "    html.style.cssText = \"--app-layout-bar-background-color: #004a96\";\n" +
        "  }, 0);\n" +
        "};");

Theming works fine for me as long as I use CSS Variables.
To set the css variables you need a file as this one:
https://github.com/appreciated/vaadin-app-layout/blob/feature-inherit-lumo-styles/app-layout-examples/app-layout-theme-example/src/main/resources/META-INF/resources/frontend/theming/custom.html
And import it via @HTMLImport.
You can find the current css variables available here:
https://github.com/appreciated/vaadin-app-layout/blob/master/app-layout-addon/src/main/resources/sass/app-layout/app-layout/app-layout.scss#L62-L116
You can find the future css variables here:
https://github.com/appreciated/vaadin-app-layout/blob/feature-inherit-lumo-styles/app-layout-addon/src/main/resources/META-INF/resources/frontend/com/github/appreciated/app-layout/app-layout.css

@LeshaRB for Vaadin Components you can always use the Vaadin API:
MenuHeaderComponent header = new MenuHeaderComponent("App-Layout",
        "Version 2.0.1",
        "/frontend/images/logo.png"
);
header.getElement().getStyle().set("align-items","center");


Fix hanging swagger by:

Specifying str type for role and
checking either auth token/key is there

closes #149


Remove unnecessary keyword

The privacy here is already private

I added the comment change from #42334 in this PR.
As mentioned in a previous PR, code style changes are welcome, but please try to group them together in a single commit. There might be hundreds of changes that can be done similar to those two PRs, and having a hundred style commits merged in the development branch would negatively impact the signal to noise ratio of the commit history (which makes it hard to find commits which actually changed engine behavior). So it's best to make such style changes locally while you read the code, and push them all at once (as long as they're all simple changes that won't require a lot of debate).

Thanks!


Ability to change the shortened parameters

On some integrations, we want to integrate instantsearch without changing the current behaviour (SEO purposes for instance). So we integrate on top of them.
For the URL, most search pages use the q query parameter to handle search, which makes it trivial to integrate in them.
However, some others use query. For these, it would be really neat to change the shortened version of the query parameter in order to have the parameter synchronization directly.
My example:

Zendesk's /search page accepts a query parameter.
I want to keep the default back-end search (which uses query) to have decent SEO on a query
However, by activating instantsearch, I end up with two parameters in the url /search?query=a&q=a
When I change the state the url becomes /search?query=a&q=abc.
If someone shares this URL, the back-end search will return results for a and the front-end results for abc, which is pretty uncool.

If I could change the "shortened" version of query from q to query, everything would be ultra simple.
I post it here because I believe it could be a urlSync parameter.
In order to do so, it would require us to expose the shortener on the helper, which is what https://github.com/algolia/algoliasearch-helper-js/pull/280 aims to do.

This is a good idea yes

I've tried to do that myself using the helper. I had a problem with existing URLs using ?page=<page> for pagination and the helper uses ?p=<page>. Would definitely use this if available.

awesome, @Jerskouille already started implementing it in the helper so it should not take too long

It was merged in the helper https://github.com/algolia/algoliasearch-helper-js/commit/7d93cac8aac6ae1ca2e50b73270ba139ec9b72fa so it should only be now an issue of implementing it (passing the parameter) and documenting it in instantsearch.js. @Jerskouille are you up to doing it? thx


Use current running env path to determine active BE

In my use case, I have BE's with legacy mountpoints set. GRUB decides which BE to boot, I understand that GRUB support is a WIP in zectl, however I noticed that zectl does not show the correct active BE which on looking closer I found was because it tried to confirm the value of the mountpoint. That in my opinion is a good check but isn't it better to trust lzeh.env_running_path path ? I am not certain how zectl intends to handle this case with GRUB ( mountpoints of active BE's ) but to have legacy mountpoint set and have GRUB booting from it, I don't see any issue in trusting lzeh.env_running_path instead as that should always get us the active BE's dataset name.

Could you elaborate on what you mean by it doesn't show the correct active boot environment? I'm also running legacy mounts, and they show up correctly.
Do you get a different behavior than the following:
zectl list
Name              Active  Mountpoint  Creation
linux-lts-5.4.33          -                 2020-04-23 10:36
linux-lts-5.4.39          -                 2020-05-14 12:14
default           RN      /                 2020-01-09 11:55
linux-lts-5.4.30          -                 2020-04-10 13:42
linux-lts-5.4.38          -                 2020-05-08 12:28
linux-lts-5.4.32          -                 2020-04-21 15:09
linux-lts-5.4.31          -                 2020-04-15 14:13
linux-lts-5.4.28          -                 2020-03-31 15:02

zectl activate linux-lts-5.4.33

zectl list
Name              Active  Mountpoint  Creation
linux-lts-5.4.33  R       -                 2020-04-23 10:36
linux-lts-5.4.39          -                 2020-05-14 12:14
default           N       /                 2020-01-09 11:55
linux-lts-5.4.30          -                 2020-04-10 13:42
linux-lts-5.4.38          -                 2020-05-08 12:28
linux-lts-5.4.32          -                 2020-04-21 15:09
linux-lts-5.4.31          -                 2020-04-15 14:13
linux-lts-5.4.28          -                 2020-03-31 15:02

zectl activate default

zectl list
Name              Active  Mountpoint  Creation
linux-lts-5.4.33          -                 2020-04-23 10:36
linux-lts-5.4.39          -                 2020-05-14 12:14
default           RN      /                 2020-01-09 11:55
linux-lts-5.4.30          -                 2020-04-10 13:42
linux-lts-5.4.38          -                 2020-05-08 12:28
linux-lts-5.4.32          -                 2020-04-21 15:09
linux-lts-5.4.31          -                 2020-04-15 14:13
linux-lts-5.4.28          -                 2020-03-31 15:02

@johnramsden yes that is accurate, I don't get the active N at all and that's because the BE is booted via GRUB and I don't mount it explicitly.
My diff basically just trusts the already retrieved information instead of going for the mountpoint attribute as that is legacy in my case and this fails for the active BE.

Interesting, I wonder what the difference is between how GRUB and systemd-boot mounts a dataset/clone. My BE is also mounted by the bootloader.
So this makes it work on GRUB? If so, then sure we can change it, as it should have the same behaviour.

Yes the BE is selected via GRUB. We have a framework in place to correctly generate the GRUB bits for BE selection. The linux kernel is started accordingly. I have  not tried systemd to see how it does this.
Please do let me know if you require more information from my end. I’ll be happy to assist. Thanks

@sonicaj Is this something you put together yourself the "GRUB bits"? Or is it built into a distro you are using? If it's a grub generator that is compatible with zectl, it could potentially be beneficial for the GRUB WIP #4 .

@johnramsden yes it's something that I have put together right now. It's a POC currently and is a shell script and some python bits, but I am looking at nice ways to make this work nicely with zectl. Probably would do that with my forked version as the current idea I have requires a dedicated GRUB dataset. I had a peek at GRUB WIP PR but unfortunately it doesn't seem to suit our usecase very well or maybe I just don't understand enough bits yet on how it's supposed to function. Anyways, if you have some time this week, we can potentially discuss the idea behind current WIP PR and how I intend to make it work. Let me know if that works, thanks.

@sonicaj Even if you have some recommendations on how the current WIP could be improved that would be useful. That would definitely be possible to have a dedicated dataset, that's how the current GRUB plug-in is intended to work. It has a dedicated boot dataset and optionally a dedicated boot pool.
I definitely have time to discuss it, feel free to open up a new PR, the current GRUB PR is seeing little development currently.
If you can get everything to work with a shell script that would be great, the other option is C++ or C so that we can use the zectl libraries directly.

@johnramsden please let me know what's the best way to get in touch with you and we can discuss briefly whats happening right now and how we can potentially make it work. Thanks


Importing kotlin-stdlib and kotlin-android-extensions

This project is written 100% in Java, however the SDK ships with a dependency on the Kotlin stdlib and Kotlin Android extensions. Kotlin was added in this PR, but seems unrelated?
Also as an aside it would be great if this library added nullability annotations to make Kotlin interoperability nicer! I can open up a separate issue for this if you'd prefer.

Hi @colinrtwhite , thanks for reporting this.
We will remove the unnecessary dependency in the next release coming soon.
I think we added them for few experiments and then mistakenly shipped on the release.
About the nullability annotation we are keen to add them for our two native mobile trackers (iOS and Android) with other API improvements. It's already planned for the version 2.0 which should be released in the coming months.
We added the annotation to few methods and classes we have refactored recently but it doesn't cover the full API at the moment.

Thanks for the quick response, sounds good. Is the plan to migrate to androidx as part of 1.5.0 as well? Thanks!

Not yet, we are considering that for the next major version 2.0, in order to avoid breaking changes in the apps not yet migrated to AndroidX.


Android: notifications with large images attached crash the app

Hello
I've noticed this for a while but has it's only  trigger by very large images, it's difficult to find a case.
A notification sent via curl with a very large image attached to a topic makes the app crash when opening that topic.
All other topics keep working, the app keeps receiving more notifications on that topic although unable to display them.
The last image to cause this was this: (WARNING: NSFW!)
https://i.imgur.com/pKiQk6l.jpg , 4.4mb 4480x6720
Android creates a log report and sends it somewhere, but i cannot intercept it.
The only error i found was:
java.lang.RuntimeException: Canvas: trying to draw too large(120422400bytes) bitmap.

I have experienced crashes with large photos as well, so I can confirm this happens. I think this should be one of the next Android tickets to be worked on. The app should never crash.
(Side note: You could have linked any other large photo ... Like, one from NASA or Wikipedia...)

This is a little trickier than expected, because I cannot catch a RuntimeException, and whether the exception is raised depends on your system and your available RAM. Figuring out whether an image is too large is non-trivial, because a JPG of 4480x6720 (as you posted) expends to 120 MB in memory. I could limit previews to 1 MB JPG files, or to certain dimensions, but it's not a sure thing.
The only way to solve this would be to bring in a library that intelligently does the image loading in a memory efficient way. And I' not sure I want to bring in a library just for that.
(I am working on this though, and will hopefully have a solution soon)

Perhaps the server, upon receiving a image could create a thumbnail. The whole file and the thumbnail could be passed to the Android app, but only the thumb would be previewed.
In anycase, i find  this issue peculiar. The tested smartphone is not weak on memory, 8GB.

This is the corresponding stack trace I got from the Google Play console for this issue; and from reproducing it locally:
Exception java.lang.RuntimeException: Canvas: trying to draw too large(120422400bytes) bitmap.
  at android.graphics.RecordingCanvas.throwIfCannotDraw (RecordingCanvas.java:266)
  at android.graphics.BaseRecordingCanvas.drawBitmap (BaseRecordingCanvas.java:94)
  at android.graphics.drawable.BitmapDrawable.draw (BitmapDrawable.java:549)
  at android.widget.ImageView.onDraw (ImageView.java:1446)
  at com.google.android.material.imageview.ShapeableImageView.onDraw (ShapeableImageView.java:198)
  at android.view.View.draw (View.java:23195)
  at android.view.View.updateDisplayListIfDirty (View.java:22062)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at androidx.constraintlayout.widget.ConstraintLayout.dispatchDraw (ConstraintLayout.java:1994)
  at android.view.View.draw (View.java:23198)
  at android.view.View.updateDisplayListIfDirty (View.java:22062)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at android.view.View.draw (View.java:23198)
  at android.view.View.updateDisplayListIfDirty (View.java:22062)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at androidx.recyclerview.widget.RecyclerView.drawChild (RecyclerView.java:5370)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at android.view.View.draw (View.java:23198)
  at androidx.recyclerview.widget.RecyclerView.draw (RecyclerView.java:4769)
  at android.view.View.updateDisplayListIfDirty (View.java:22062)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at android.view.View.draw (View.java:23198)
  at android.view.View.updateDisplayListIfDirty (View.java:22062)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at androidx.constraintlayout.widget.ConstraintLayout.dispatchDraw (ConstraintLayout.java:1994)
  at android.view.View.updateDisplayListIfDirty (View.java:22053)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at android.view.View.updateDisplayListIfDirty (View.java:22053)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at android.view.View.updateDisplayListIfDirty (View.java:22053)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at android.view.View.updateDisplayListIfDirty (View.java:22053)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at android.view.View.updateDisplayListIfDirty (View.java:22053)
  at android.view.View.draw (View.java:22926)
  at android.view.ViewGroup.drawChild (ViewGroup.java:4529)
  at android.view.ViewGroup.dispatchDraw (ViewGroup.java:4290)
  at android.view.View.draw (View.java:23198)
  at com.android.internal.policy.DecorView.draw (DecorView.java:819)
  at android.view.View.updateDisplayListIfDirty (View.java:22062)
  at android.view.ThreadedRenderer.updateViewTreeDisplayList (ThreadedRenderer.java:682)
  at android.view.ThreadedRenderer.updateRootDisplayList (ThreadedRenderer.java:688)
  at android.view.ThreadedRenderer.draw (ThreadedRenderer.java:786)
  at android.view.ViewRootImpl.draw (ViewRootImpl.java:4579)
  at android.view.ViewRootImpl.performDraw (ViewRootImpl.java:4290)
  at android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:3517)
  at android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:2286)
  at android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:8948)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1231)
  at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1239)
  at android.view.Choreographer.doCallbacks (Choreographer.java:899)
  at android.view.Choreographer.doFrame (Choreographer.java:832)
  at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1214)
  at android.os.Handler.handleCallback (Handler.java:942)
  at android.os.Handler.dispatchMessage (Handler.java:99)
  at android.os.Looper.loopOnce (Looper.java:201)
  at android.os.Looper.loop (Looper.java:288)
  at android.app.ActivityThread.main (ActivityThread.java:7893)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:936)

I managed to monkey patch this using this fix: https://github.com/binwiederhier/ntfy-android/commit/d09fdb2ff259f9e4d8cf83b515d37f4d3062d6b3 - The workaround is from here: https://stackoverflow.com/a/53334563/1440785
It works by checking if the loaded image is > 100 MB in memory and exits out gracefully if it does. The image is not rendered in that case. I could have gone for a "resize and display" option, but I think this is sufficient for now.
Will be in the next Android release.


Grace period should be documented

As described in this document, if my application does not respond to the SIGTERM message, then Container Apps control plane send SIGKILL to my container. How much grace period do I have from SIGTERM to SIGKILL?
In my testing, it seemed to be 30 seconds, similar to the default of Kubernetes terminationGracePeriod.
This information has a significant impact on implementation of graceful shutdown, so should be documented. I would appreciate it if you could consider it. Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bff43652-6118-110e-9c79-01e51f0811f9
Version Independent ID: 2a8e983a-06a2-5c08-73c1-827ec8ff8f89
Content: Application lifecycle management in Azure Container Apps Preview
Content Source: articles/container-apps/application-lifecycle-management.md
Service: container-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Hello @ToruMakabe - Thank you for your feedback! We will review and update as appropriate.

@vturecek - can you comment on the amount of time between SIGKILL and SIGTERM?

The grace period is 30 seconds.  Adding info to document.  Thank you for your input.
#please-close


Don't count FieldValue transformations against batch size limit

Thanks for stopping by to let us know something could be better!
Environment details

OS: macOS Catalina 10.15.3 Beta (19D75a)
Node.js version: 13.7
npm version: 6.13.6
@google-cloud/firestore version: 3.4.1

Steps to reproduce
I have the following function:
export const commitBatchUpdates = async (batchUpdates) => {
  const numUpdates = Object.keys(batchUpdates).length;
  if (!numUpdates) {
    return;
  }

  // The max number of updates per batch that firestore allows
  const BATCH_LIMIT = 500;

  // Construct an array of batches that can hold 500 updates each
  const batches = [...Array(Math.floor(numUpdates / BATCH_LIMIT + 1))].map(() => firestore.batch());

  console.log('NUM UPDATES:', numUpdates);

  // Add each batch update to the correct batch index
  Object.entries(batchUpdates).forEach(([docId, { payload, type }], i) => {
    const batchIndex = Math.floor(i / BATCH_LIMIT);
    const firestoreDoc = firestore.doc(docId);

    switch (type) {
      case 'update':
        batches[batchIndex].update(firestoreDoc, payload);
        break;
      case 'set':
        batches[batchIndex].set(firestoreDoc, payload);
        break;
      case 'delete':
        batches[batchIndex].delete(firestoreDoc);
        break;
      default:
        break;
    }
  });

  console.log('BATCH COUNT:', batches.length);
  for (let i = 0; i < batches.length; i++) {
    console.log('BATCH AT INDEX', i, 'has', batches[i]._ops.length, 'operations');
  }

  // Commit the batch updates
  try {
    await Promise.all(batches.map(async (batch) => batch.commit()));
  } catch (err) {
    console.log('it failed');
    console.log(err);
    throw err;
  }
};

I wrote this function to assist with making batch updates since there is a batch limit. The goal of the function is to take an input object of updates, convert it into an array of firestore batches, and commit each batch update. The input parameter batchUpdates is an object that has keys of document Ids (full paths with collection) and values of objects that contain a type that is either 'set', 'update', or 'delete' as well as a 'payload' that is a json payload to set/update a document with.
Examples of each type of value that could appear:
Set:
{ type: 'set', payload: { a: 1}  }

Update:
{ type: 'update', payload: { a: 1}  }

Delete:
{ type: 'delete' }

You would expect that each batch would be deleted. However, this is what I see:
NUM UPDATES: 11466
BATCH COUNT: 23
BATCH AT INDEX 0 has 500 operations
BATCH AT INDEX 1 has 500 operations
BATCH AT INDEX 2 has 500 operations
BATCH AT INDEX 3 has 500 operations
BATCH AT INDEX 4 has 500 operations
BATCH AT INDEX 5 has 500 operations
BATCH AT INDEX 6 has 500 operations
BATCH AT INDEX 7 has 500 operations
BATCH AT INDEX 8 has 500 operations
BATCH AT INDEX 9 has 500 operations
BATCH AT INDEX 10 has 500 operations
BATCH AT INDEX 11 has 500 operations
BATCH AT INDEX 12 has 500 operations
BATCH AT INDEX 13 has 500 operations
BATCH AT INDEX 14 has 500 operations
BATCH AT INDEX 15 has 500 operations
BATCH AT INDEX 16 has 500 operations
BATCH AT INDEX 17 has 500 operations
BATCH AT INDEX 18 has 500 operations
BATCH AT INDEX 19 has 500 operations
BATCH AT INDEX 20 has 500 operations
BATCH AT INDEX 21 has 500 operations
BATCH AT INDEX 22 has 466 operations
it failed
Error: 3 INVALID_ARGUMENT: maximum 500 writes allowed per request
    at Object.callErrorFromStatus (/Users/myusername/myproj/node_modules/@grpc/grpc-js/src/call.ts:79:24)
    at Http2CallStream.<anonymous> (/Users/myusername/myproj/node_modules/@grpc/grpc-js/src/client.ts:155:18)
    at Http2CallStream.emit (events.js:333:22)
    at Http2CallStream.EventEmitter.emit (domain.js:485:12)
    at /Users/myusername/myproj/node_modules/@grpc/grpc-js/src/call-stream.ts:183:14
    at processTicksAndRejections (internal/process/task_queues.js:79:11) {
  code: 3,
  details: 'maximum 500 writes allowed per request',
  metadata: Metadata { internalRepr: Map(0) {}, options: {} }
}

It clearly shows that each batch has 500 operations or less, yet the update is erroring out.

So as of now we should set the server timestamp ourselves? Is there a FieldValue transforms guide?

You can use the existing FieldValue API as is. The implications pointed out by @jakeleventhal only apply if you are hitting the batch size limit in a WriteBatch, in which case you should reduce the number of documents you are adding to your batches.

The v4.0.0 release using a different mechanism for FieldValue transformations. All document writes now map to a single backend operation.

@schmidt-sebastian does this include the removal of the 500 ops per batch restriction as well?

@jakeleventhal The 500 op limit is still in place for WriteBatch. Once BulkWriter is released, you will be able to write without needing to manually batch writes.

@thebrianchen @schmidt-sebastian is there a way to do a large (>500) atomic write?

No, there is not.

@schmidt-sebastian is there work tracking this?

I don't see any issues tracking this. You can search open issues at https://issuetracker.google.com/savedsearches/5337669?q=componentid:530136%2B status:open
You can also create a new issue. We do take this into account as we prioritize future work items.

@schmidt-sebastian @thebrianchen why would I want to use the bulk writer as opposed to the custom batch update tool that I provided?

@schmidt-sebastian @thebrianchen @Elyx0 I made this issue tracking it. Please vote for it!

@schmidt-sebastian @thebrianchen @Elyx0 I made this issue tracking it. Please give it a star!
https://issuetracker.google.com/issues/180813634


[HUDI-343]: Create a DOAP file for Hudi

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
DOAP file for HUDI
Brief change log
ASF Administrative Requirement for all projects in Foundation
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.
Committer checklist

[X] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

+1, 👍

Hi @smarthi, GitRepository needs be modified to
<GitRepository>
  <location rdf:resource="https://github.com/apache/incubator-hudi.git"/>
  <browse rdf:resource="https://github.com/apache/incubator-hudi"/>
</GitRepository>


Update readiness-assessment-fix.md

Updated based on issue #6124
If there is an existing Autopilot Deployment profile (even if it is not assigned) the setting "Convert all targeted devices to Autopilot" must be set to "No"

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/6124

@JohanFreelancer9 Please copy review

@jaimeo Please merge this PR. Thanks


Insert From Layer

Hallo GIS enthusiastic,
sorry if my question so basic. how i can input from layer in start location & end location in routing OSM TOOLS.
thanks in advance

sorry, this is not a forum. Contact<EMAIL_ADDRESS>or our Google Group.
And see #47. Make it a single geometry point layer to be safe, not MultiPoint.


Made reset metadata more clear

Requires this pull request.

Makes resetting the metadata more clear as mentioned in #48.
Adds a debounce to the button to not get an error when it's spammed.

Thank you! That should help make it more clear, really appreciate the PR!


[Macros] Fix lazy expansion of freestanding macros within types/extensions

An incorrectly-specified starting context for name lookup meant that
macro lookup itself was failing, and therefore did not trigger
expansion of the freestanding macro or introduction of the
macro-expanded declarations into the context.
Fixes rdar://108824784.

@swift-ci please smoke test


Coda 2 plugin

Need a plugin for Code 2. Help on writing plugins is here https://panic.com/coda/plugins.php

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Hi @xaolas!
I'm closing this because unless a PR is created it won't likely be addressed.
If you feel strongly about this request I encourage you to dig in and submit a PR 😸


Docker and libs

add Docker
update libs

Thanks for your contribution. It's not clear why adding Docker to the project is useful?
For the dependencies, I've configured dependabot, so they we'll be updated automatically. It already started creating the PR.


Generate a good http secret

Is your feature request related to a problem? Please describe.
At the current state, we are using every time in the deployment "test" as http secret.
Describe the solution you'd like
Generate a secrect during the deployment.
Take a look at: https://kubernetes.io/docs/concepts/configuration/secret/

Another solution would be something like this:
kubectl create secret generic application-secret --from-literal=secret="$(openssl rand -base64 48)"
But this requires openssl installed on the host system.


Normalize Windows drive letters to uppercase for analysis

This fixes #32095, however I'm currently unable to get the tests running locally. I'll continue to work on that, but I'm hoping that creating a PR runs all the tests on CI so we should at least get to see if this (legitimately) broke anything in the meantime?
@bwilkerson

Oh, looks like there's no CI build for the PR... I'll continue working on getting the tests running locally!

I was running the wrong tests here (analysis_server, but the change is in analyzer). Analyzer tests all pass both before/after this change:
02:46 +22943: All tests passed!

See https://dart-review.googlesource.com/c/sdk/+/40720 for review comments.

@bwilkerson

you can either click the button labeled "CQ Dry Run"

Where should that appear? I can't see it but don't know if that might be permission related (I have logged in as danny @ tuppeny...) or because you've already clicked it?
Should I be using Gerrit to raise reviews for things? If so, are there any notes on the process for raising a review once a PR is sent?

I'll send you an e-mail where we can have a process discussion. Seems more appropriate.


Reduce the execution time when the object is pretty large.

The test case is an object which contains more than 20k objects
and the stringify text is about 5MB after removing all spaces.
The execution time for each method is:

JSON.stringify     : 0.23s
before this commit : 4.50s
after this commit  : 0.85s

would it not break serialisation for non-cyclic shared nodes?


dd function not working

Hello
dd() doesn't working and it outputs a blank page.
dump() and d() seems to have no problem and works as good.
Here is my app info:
PHP version 7.2.1
MySQL 5.6.38
Craft Pro 3.1.29
Dumper 1.3.1

My craft environment is "dev", so it should have error info but I get only a blank page.

Hey! Where on your code are you using the function? In twig template, in a controller,... ?

Can confirm that this broke in Craft 3.1.29, still works on 3.1.28.
Investigating this tonight!

Hi, The issue is In twig template.

Should be fixed with upgrading to version 2.0.0 of the plugin. Do get in touch if you run into any other issues.
Thanks
Jan


Under Windows "datefile dir" gets "permission denied" if 'dir' is a directory

Running one of your examples under Windows, I get the following error:
C:\Users\hgolden\Documents\Automation\Haskell>ghci
GHCi, version 7.8.3: http://www.haskell.org/ghc/  :? for help
[snip]
Prelude> import Turtle
Prelude Turtle> dir <- pwd
[snip]
Prelude Turtle> time <- datefile dir
*** Exception: CreateFile "C:\Users\hgolden\Documents\Automation\Haskell": permission denied (Access is denied.)
Prelude Turtle>
It appears that this problem only occurs if the file is a directory. For example, this works:
Prelude Turtle> time <- datefile $ fromString ".\example.hs"
Prelude Turtle> print time
2015-03-16 21:40:36.697 UTC
Prelude Turtle>

In this case datefile is just a synonym for Filesystem.getModified:
-- | Get the time a file was last modified
datefile :: FilePath -> IO UTCTime
datefile = Filesystem.getModified

... and that comes from the system-fileio library so the error is further upstream.  You can report the error at:
https://github.com/fpco/haskell-filesystem/issues

I agree with you. It appears that the following code in system-fileio should use a zero parameter instead of Win32.gENERIC_READ:
#ifdef CABAL_OS_WINDOWS

withHANDLE :: FilePath -> (Win32.HANDLE -> IO a) -> IO a
withHANDLE path = Exc.bracket open close where
	open = Win32.createFile
		(encodeString path)
		Win32.gENERIC_READ
		(Win32.fILE_SHARE_READ .|. Win32.fILE_SHARE_WRITE)
		Nothing
		Win32.oPEN_EXISTING
		0
		Nothing
	close = Win32.closeHandle


input element's margin removed

If the location picker is applied on an input element with a margin then that margin disappears (before any interaction)

Hey max,
I think in this case you should add margins yourself onto the enhanced component.
Going to close this out since it's an older issue, sorry for the delay.


KFServing v1beta1 API (trigger e2e tests)

What this PR does / why we need it:
Trigger e2e tests for v1beta1 branch
Release note:

/restest

/retest


Test site: stealing passwords

On the other site @beerisgood posted link to this demo:
Demo: https://senglehardt.com/demo/no_boundaries/loginmanager/
Info: https://freedom-to-tinker.com/2017/12/27/no-boundaries-for-user-identities-web-trackers-exploit-browser-login-managers/
Maybe also a candidate for a Appendix A Test Sites

travankor said

https://github.com/mindedsecurity/behave
Behave! monitors and warn if a web page performs any of following actions:

Browser based Port Scan
Access to Private IPs
DNS Rebinding attacks to Private IPs

The info article is interesting... and frightening for those who use their browser's password manager.
I'm running Firefox 79.0 and I encountered no stolen password according to the test site and if interpret the following result correctly:

Result
Sniffed email: ?
Sniffed password: ?

No idea if this related to a Firefox modified setting. I had in mind network.auth.subresource-http-auth-allow. I tested with value 2 (default) and 0 (Ghacks-user.js recommends 1), in both cases results were as above mentioned.
@crssi I hope your thread gets fed by as many comments as possible, this is definitely important.

1st... you already are being covered by:
/* 0905: disable auto-filling username & password form fields
 * can leak in cross-site forms *and* be spoofed
 * [NOTE] Username & password is still available when you enter the field
 * [SETTING] Privacy & Security>Logins and Passwords>Autofill logins and passwords ***/
user_pref("signon.autofillForms", false);

2nd... this exploit is not as simple as it reads.
The attacker still need to do some MITB aproach to do so.
I am thinking of rogue web extension for example.
Cheers

Yes, signon.autofillForms set to false does it, of course. Got to my mind later on. No idea how I concocted such an hypothesis ...
By the way, the article is about three years old, is the info still pertinent? I first thought it was a scoop, hot news ...


remove unnecessary space

Current dependencies on/for this PR:

main

PR #13   👈

This comment was auto-generated by Graphite.


Can't install rock/rocm on Linux kernel 5.13.0-27-generic

I just tried to install rocm on a brand new computer with freshly installed OS (Ubuntu 20.04.3), and encountered repeated failures including the the following:
Reading package lists... Done
Building dependency tree
Reading state information... Done
amdgpu-dkms is already the newest version (1:<IP_ADDRESS>502-1350682).
0 upgraded, 0 newly installed, 0 to remove and 4 not upgraded.
1 not fully installed or removed.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] Y
Setting up amdgpu-dkms (1:<IP_ADDRESS>502-1350682) ...
Removing old amdgpu-5.11.32-1350682 DKMS files...

------------------------------
Deleting module version: 5.11.32-1350682
completely from the DKMS tree.
------------------------------
Done.
Loading new amdgpu-5.11.32-1350682 DKMS files...
Building for 5.13.0-27-generic
Building for architecture x86_64
Building initial module for 5.13.0-27-generic
ERROR: Cannot create report: [Errno 17] File exists: '/var/crash/amdgpu-dkms.0.crash'
Error! Bad return status for module build on kernel: 5.13.0-27-generic (x86_64)
Consult /var/lib/dkms/amdgpu/5.11.32-1350682/build/make.log for more information.
dpkg: error processing package amdgpu-dkms (--configure):
 installed amdgpu-dkms package post-installation script subprocess returned error exit status 10
Errors were encountered while processing:
 amdgpu-dkms
E: Sub-process /usr/bin/dpkg returned an error code (1)

The installation process for ver 4.5 apparently does not support the default linux kernel 5.13.0-27-generic.  (Apparently the previous version rocm 4.3 does not have this issue.)

From 4.5 installation steps changed for DKMS, here you can find the details.
https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation_new.html#installer-script-method

The installation process for ver 4.5 apparently does not support the default linux kernel 5.13.0-27-generic. (Apparently the previous version rocm 4.3 does not have this issue.)

Yes, Ubuntu 20.04 updated HWE kernel to 5.13 which will be supported in the next ROCm release.

Why do the instructions at https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation_new.html#confirm-you-have-a-supported-linux-distribution-version not make that clear? The  "System Requirements" paragraph states that Ubuntu 20.04.3 is supported.

In file included from /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.c:34:
 /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_topology.h:229:11: error: conflicting types for ‘amd_iommu_pc_get_max_banks’
   229 | extern u8 amd_iommu_pc_get_max_banks(u16 devid);
       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
 In file included from /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.c:31:
 ./include/linux/amd-iommu.h:201:4: note: previous declaration of ‘amd_iommu_pc_get_max_banks’ was here
   201 | u8 amd_iommu_pc_get_max_banks(unsigned int idx);
       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
 In file included from /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.c:34:
 /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_topology.h:230:11: error: conflicting types for ‘amd_iommu_pc_get_max_counters’
   230 | extern u8 amd_iommu_pc_get_max_counters(u16 devid);
       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 In file included from /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.c:31:
 ./include/linux/amd-iommu.h:202:4: note: previous declaration of ‘amd_iommu_pc_get_max_counters’ was here
   202 | u8 amd_iommu_pc_get_max_counters(unsigned int idx);
       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.c:347:11: error: conflicting types for ‘amd_iommu_pc_get_max_banks’
   347 | extern u8 amd_iommu_pc_get_max_banks(u16 devid);
       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~
 In file included from /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.c:31:
 ./include/linux/amd-iommu.h:201:4: note: previous declaration of ‘amd_iommu_pc_get_max_banks’ was here
   201 | u8 amd_iommu_pc_get_max_banks(unsigned int idx);
       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~
 /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.c:348:11: error: conflicting types for ‘amd_iommu_pc_get_max_counters’
   348 | extern u8 amd_iommu_pc_get_max_counters(u16 devid);
       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 In file included from /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.c:31:
 ./include/linux/amd-iommu.h:202:4: note: previous declaration of ‘amd_iommu_pc_get_max_counters’ was here
   202 | u8 amd_iommu_pc_get_max_counters(unsigned int idx);
       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 make[2]: *** [scripts/Makefile.build:281: /var/lib/dkms/amdgpu/5.11.32-1350682/build/amd/amdgpu/../amdkfd/kfd_iommu.o] Error 1

looks like it's triggered by a compliation error.

Same issue on a freshly upgrade'd (to 5.13.0-27) Ubuntu 20.04.3.

A couple of other bits of info:  Ubuntu version 20 changed kernel versions from 11 to 13 this past August, which may have been the genesis of this error; but whichever kernel is still designated Ubuntu version 20.04.3;
I was finally able to install (not build) ROCm by using the contents of the Docker file at RadeonOpenCompute as a guide.  Most of the commands need to have "sudo" prefixed in order to run them from the command line.

I ran into this issue on a fresh upgrade to (5.13.0-27) on Ubuntu release
as well. To resolve, I rolled back the kernel to 5.11 with the HWE tools.
Rollback, download (linux-headers-5.11.0-46-generic,
linux-image-5.11.0-46-generic, linux-modules-5.11.0-46-generic,
linux-modules-extra-5.11.0-46-generic, linux-tools-5.11.0-46-generic,
linux-hwe-5.11-tools-common) from here
https://packages.ubuntu.com/source/focal-updates/linux-hwe-5.11. Install
with sudo dpkg -i *.deb.
Purge 5.13
sudo apt-get autopurge 'linux-image-5.13.0--generic'
'linux-image-unsigned-5.13.0--generic' 'linux-modules-5.13.0--generic'
'linux-hwe-5.13-headers-5.13.0-' linux-generic-hwe-20.04
After this, I was able to install ROCm using amdgpu-install and run. Also,
I was able to build from source.
On Fri, Jan 28, 2022 at 3:20 PM bpickrel @.***> wrote:

A couple of other bits of info: Ubuntu version 20 changed kernel versions
from 11 to 13 this past August, which may have been the genesis of this
error; but whichever kernel is still designated Ubuntu version 20.04.3;
I was finally able to install (not build) ROCm by using the contents of
the Docker file at RadeonOpenCompute
https://github.com/RadeonOpenCompute/ROCm-docker/blob/master/dev/Dockerfile-ubuntu-20.04-complete
as a guide. Most of the commands need to have "sudo" prefixed in order to
run them from the command line.
—
Reply to this email directly, view it on GitHub
https://github.com/RadeonOpenCompute/ROCm/issues/1658#issuecomment-1024735926,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQDYWZJEZWBZX34H7J7WADUYMQDRANCNFSM5MLDU5OQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

My workaround is to uninstall kernel 5.13 and I found it work in 5.11.

I also had to downgrade to the 5.11 kernel which solved the problem.

Hi @bpickrel and all,
Thanks for reaching out.
We are aware of the issue and team is coming up with a fix/workaround. We have an internal issue already filed for this.
As Ubuntu recently pushed 5.13 kernel, and as ROCm is not built/validated on 5.13.0-27, this problem happened.
Meanwhile I request everyone to roll back to 5.11 kernel which is an approved kernel by ROCm.
I will keep you posted.
Thank you.

Good news is that, 5.0 internal builds are ready with fix/workaround incorporated. I have verified too and things are working good.
Please stay tuned for 5.0 builds(will be released very soon) having the resolution for this issue.
Thank you.

Great news, thanks for the update :)
I am only a lazy amateur running a rig that I update-upgrade-vacuum every 6 weeks or so.  I know occasionally all magic breaks but it'd really be great to keep up with LTS updates in future :)

Thanks, now working fine with 5.13.0-28

Thanks for the confirmation.
I am closing this thread as the fix is validated. Thank you.


Nightly documentation fail due to aplot

This does not always happens, but sometimes.
See:
https://github.com/pyansys/pymapdl/actions/runs/3791607565/jobs/6447155489#step:9:565

The aplot function has been checked and it seems to be well defined.
When running the lathe_cutter.py locally, the numpy.random.random(sizes_) array shape is (17,) an not<PHONE_NUMBER>,) as mentioned in the error report.
The failing is from somewhere else, to be continued!

Closed because #1865


GC heap initialization failed with error 0x8007000E Failed to create CoreCLR, HRESULT: 0x8007000E

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
wget https://github.com/PowerShell/PowerShell/releases/download/v7.4.0/powershell-7.4.0-linux-arm64.tar.gz
tar -xvf powershell-7.4.0-linux-arm64.tar.gz
./pwsh
GC heap initialization failed with error 0x8007000E
Failed to create CoreCLR, HRESULT: 0x8007000E
Expected behavior
./pwsh activates the programm

Actual behavior
./pwsh doesn't work because of error 0x8007000E

Error details
No response
Environment data
.

Visuals
No response

What operating system is this on?
I have no problems on Debian 11 on Raspberry Pi 4
$ wget https://github.com/PowerShell/PowerShell/releases/download/v7.4.0/powershell-7.4.0-linux-arm64.tar.gz
....
HTTP request sent, awaiting response... 200 OK
Length: 68068263 (65M) [application/octet-stream]
Saving to: 'powershell-7.4.0-linux-arm64.tar.gz'

powershell-7.4.0-linux-arm64.tar.gz               100%[=============================================================================================================>]  64.91M  2.96MB/s    in 19s

2023-12-10 14:16:53 (3.38 MB/s) - 'powershell-7.4.0-linux-arm64.tar.gz' saved [68068263/68068263]

$ tar xfz powershell-7.4.0-linux-arm64.tar.gz
$ ./pwsh
PowerShell 7.4.0
PS /home/bythesea/tmp>

@rhubarb-geek-nz this is on a ubuntu 20 vm that i got from andronix

I have just tested in a docker on aarch64 on a Raspberry Pi 4
FROM ubuntu:20.04

[internal] load metadata for docker.io/library/ubuntu:20.04

That same tar worked cleanly.
$ ldd pwsh
        linux-vdso.so.1 (0x0000007f9427d000)
        libpthread.so.0 => /lib/aarch64-linux-gnu/libpthread.so.0 (0x0000007f941da000)
        libdl.so.2 => /lib/aarch64-linux-gnu/libdl.so.2 (0x0000007f941c6000)
        libstdc++.so.6 => /lib/aarch64-linux-gnu/libstdc++.so.6 (0x0000007f93fe1000)
        libm.so.6 => /lib/aarch64-linux-gnu/libm.so.6 (0x0000007f93f36000)
        libgcc_s.so.1 => /lib/aarch64-linux-gnu/libgcc_s.so.1 (0x0000007f93f12000)
        libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000007f93d9f000)
        /lib/ld-linux-aarch64.so.1 (0x0000007f9424d000)

Given the limitations of Andronix I would not expect it to be a support environment.

Note that  0x8007000E indicates an out-of-memory condition.

The list of supported platforms is here

@rhubarb-geek-nz that makes sense, well i need to check other ones, thanks for the support


Update style-props.mdx to match overflow props to correct CSS props

Closes #
📝 Description

Add a brief description

Fix overflowX and overflowY to match the correct overflow-* css props

Good catch, @jonahallibone! Thanks for opening the PR 🙌


metric with empty label value will add a new metric record

What did you do?
I have a metric of cluster node's resource with several label, eg: label1, label2,  label1's value won't be empty, but value of label2 can be empty.
At first, the node has label2 with value2, so does the metric.
After I remove the label2 from node, then there is another metric wihout label2, instead of empty string value of label2 in the origin metric(I set the value of empty string to the metric if value is empty).

What did you expect to see?
before:
metric{label1="value1", label2="value2"} 1
after value2 change to ""
metric{label1="value1", label2=""}  1
What did you see instead? Under which circumstances?
metric{label1="value1", label2="value2"} 1
metric{label1="value1", label2=""}  1
System information
Linux 3.10.0-1062.9.1.el7.x86_64 x86_64
Prometheus version
Version	2.30.2
Revision	b30db03f35651888e34ac101a06e25d27d15b476
Branch	HEAD
BuildUser	root@80d1e84a93dd
BuildDate	20211001-12:26:58
GoVersion	go1.17.1

Prometheus configuration file
- args:
    - --storage.tsdb.retention=21d
    - --storage.tsdb.path=/prometheus
    - --config.file=/etc/prometheus/prometheus.yml
    - --web.enable-lifecycle
    - --web.enable-admin-api

### Alertmanager version

```text
0.14.0

Alertmanager configuration file
No response
Logs
No response

For Prometheus Labels with an empty label value are considered equivalent to labels that do not exist.
https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels

https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels

The change of any label's value, including adding or removing labels, will create a new time series.
Labels with an empty label value are considered equivalent to labels that do not exist.

Thanks. I see it . However, how can I make the old metric invalid. Now the sum value of the metrics with label1 will be double.

What do you mean by invalid? Could you elaborate?

I'll turn this into a discussion though.


Adding test infrastructure to alphatwirl-interface

added docker build for local running
added travis-ci config & activated project in travis
added dummy test
fixed existing pep8 errors

looks good to me. the dummy test actually ran in travis-ci.
the commit https://github.com/alphatwirl/alphatwirl-interface/pull/9/commits/03476b5427014fb4a567e67a6b1736a8f27ba688 makes so many changes that are not relevant to the title of this pr. i would recommend such a comment be in a separate pr next time.
anyway, i think that we should merge this and start adding actual tests. we should also add coverage.


Fix project directory has spaces lead to compile error

Steps to Reproduce:

I use 'flutter create -t module module_test' command in directory 'flutter test'

Opened this project using android studio

FAILURE: Build failed with an exception

Logs：
Could not determine the dependencies of task ':app:lintVitalRelease'.

Could not resolve all task dependencies for configuration ':app:releaseRuntimeClasspath'.
Could not resolve project :flutter.
Required by:
project :app
Unable to find a matching configuration of project :flutter: None of the consumable configurations have attributes.

I signed it!

We should add a test for this. In the past we've tested this kind of thing by having our entire CI infrastructure rename the directory to add a space in the path; maybe we broke than when moving to Cirrus?
cc @gspencergoog @goderbauer

No, Cirrus still installs into "flutter sdk" (with a space).

This is specific to the Add2App template stuff - I don't think we have as many tests around that
/cc @matthew-carroll


fix(formula): highlight error

close #2056
close #1684

Pull Request Checklist

[x] Related tickets or issues have been linked in the PR description (or missing issue).
[x] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[x] Unit tests have been added for the changes (if applicable).
[x] Breaking changes have been documented (or no breaking changes introduced in this PR).

LOG10 很特殊，这里先主动过滤。有些边界case没有考虑


Accepted selection doesn't change color until TAB is pressed

Describe the bug
When typing a command that has suggestion, the chosen selection doesn't change to accepted color until TAB is pressed. For example, when typing kubectl to get the history and do ALT+F to move forward the accepted selection didn't change color, it stays as the history color until TAB is pressed. Please see screenshots.
To Reproduce

Type a previously used command
Do CTRL+F or ALT+F to move forward
Color doesn't change
Press TAB and color will change.

% zsh -df
% source path/to/zsh-autosuggestions.zsh
% ... # what do you do to reproduce?

Expected behavior
The accepted parts of the command should change color
Screenshots
Typed kube and ALT+F 2 times, color didn't change

Pressed TAB then color changed

Desktop

OS + distribution: MacOS Ventura 13.3
Zsh version: 5.9
Plugin version: v0.7.0 (a411ef3e0992d4839f0732ebeb9823024afaaaa8)

Additional context

Had to use hex instead of 0-7.