A bug and advices on menu Ask Continue

Versions

OS: win10
Continue:v0.8.40
IDE: vscode 1.90

Validations

[X] I believe this is a way to improve. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that requests the same enhancement

Problem
When taking the quick fix menu "Ask Continue" on an issued line, it does open a side chat view, but usually with the older chat context, if there was an older chat before:

Solution

bug fix: Whatever there is  an old chat, the "Ask Continue" should always contain only the issue-related context and output solution automatically without the user input enter again;
optional improvement advice(basic): I would prefer the action of "Ask Continue" would directly fix the issued line of code, just like that of Microsoft copilot;
optional improvement advice(more radical): sometimes, there are many issued parts on the page of code(even multiple issued parts in a line!), then what if we make a new menu called fix ALL by Continue, so that Continue can try to fix all the issues with more complete context with the full page code and outputs a more global-context consistent  solution, be it output in the side chat view with an explanation or directly overwrite the page file code.

I definitely agree with (1), and (2) is something we used to have, but maybe worth trying again.
(3) sounds like a really cool experimental feature. Will try this, maybe even at the project level at some point!

at the project level at some point!

This reminds me of the time when I coded with C# with ReSharper in Visual Studio---this extension does have a feature to diagnose the whole project.


Adjustable default width

Thanks for the great library!
I was wondering if there is an option to adjust the initial widths of the elements?
Thanks in advance!

Hey, you can set the size of a column in the column options with:

minSize
size
maxSize

https://tanstack.com/table/v8/docs/api/features/column-sizing#enableresizing

Hey, you can set the size of a column in the column options with:
* minSize

* size

* maxSize

https://tanstack.com/table/v8/docs/api/features/column-sizing#enableresizing

This solves my problem, thank you!


Revert "Merge pull request #43 from andrsd/2d"

This reverts commit c8dd8fd0e6065328f78363441e095d8d71a765f6, reversing
changes made to b53ce2788245aed8abbf9248eccb63f5c9688834.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.71%. Comparing base (f9d2498) to head (c5f107b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   92.83%   94.71%   +1.87%
==========================================
  Files          13        9       -4
  Lines        1075      795     -280
==========================================
- Hits          998      753     -245
+ Misses         77       42      -35

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


⚠ Secret Website 3 has degraded performance

In d9a17bf, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2754 ms

Resolved: Secret Website 3 performance has improved in f2cd0c0.


ERROR: for ddev-router  Cannot start service ddev-router:

https://gist.github.com/stevekessler/de6164817a3236adccbbe341a71a083e
Describe the Problem
When I try and start a DDEV instance I get the following errors.
ERROR: for ddev-router  Cannot start service ddev-router: Ports are not available: listen tcp <IP_ADDRESS>:80: bind: An attempt was made to access a socket in a way forbidden by its access permissions.
ERROR: for ddev-router  Cannot start service ddev-router: Ports are not available: listen tcp <IP_ADDRESS>:80: bind: An attempt was made to access a socket in a way forbidden by its access permissions.
Encountered errors while bringing up the project.
Failed to start d8taxonomy: failed to start ddev-router: Failed to run docker-compose [-f /home/steve/.ddev/.router-compose-full.yaml -p ddev-router up -d], err='exit status 1', stdout='', stderr='Creating ddev-router ...
Creating ddev-router ... error
ERROR: for ddev-router  Cannot start service ddev-router: Ports are not available: listen tcp <IP_ADDRESS>:80: bind: An attempt was made to access a socket in a way forbidden by its access permissions.
ERROR: for ddev-router  Cannot start service ddev-router: Ports are not available: listen tcp <IP_ADDRESS>:80: bind: An attempt was made to access a socket in a way forbidden by its access permissions.
Encountered errors while bringing up the project.'
To Reproduce
To reproduce I run ddev start in a project folder.
I do not think it is project or project type specific since the same problem happens with the diagnostics script (see above).
Version and configuration information (please complete the following information):
This is my config.yaml file:
name: d8taxonomy
type: drupal8
docroot: web
php_version: "7.4"
webserver_type: nginx-fpm
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
mariadb_version: "10.3"
mysql_version: ""
use_dns_when_possible: true
composer_version: ""
web_environment: []

Additional context
I think that ddev worked for me on this computer but it has been almost a year since I would have ran it so I do not remember because I have a computer I was using it on at that time.  I have tried both a reused configuration and the above file very simple configuration and run into the same problem.  I run into the same problem even if I change the ports that are used.
I appreciate any I help.
Thanks,
Steve

Hi Steve - Thanks for the diagnostic. It looks like you're using WSL2, and it looks like perhaps you have a docker problem or else something else competing for port 80

Please show the output of wsl -l -v in PowerShell or git-bash (on the Windows side, not inside wsl2)
What distro are you using? Ubuntu 20.04?
Have you already tried restarting docker, restarting WSL2, and rebooting the computer?
The official way to use docker with ddev is to use Docker Desktop... is it possible you also installed docker inside the container?

Other things to remember:

Take a look at the troubleshooting for occupied ports
You may want to just change the ports you're using

Closing, no response from OP. I think the suggestions here will do you well enough. I'd always start with ddev poweroff and perhaps restarting docker.

Hi @rfay,
Thank you for your help. I am sorry it has taken so long for me to reply to this.   I had something thrown at me that became higher priority for me. ::sigh::
For anyone looking back at this I am not sure what "fixed" the problem. I did all the steps above and worked through the Docker port conflicts documentation referenced above.
I ended up finding that 8081 and 8443 worked for me.  I know idea why other ports would not and custom ports did not work when I opened the ticket.
Thanks again for the help.
-Steve


BUG - Archiving a project includes .git folder

Related Feature
Feature request: issue number
Description
Archiving a project includes the .git folder, if existing.
This should be excluded from the archive. It can increase the file size dramatically.
Steps to Reproduce
Steps to reproduce the behavior:

Clone or initiate a git-based project, e.g. https://github.com/SAP-samples/cap-sflight.git
For convenience, use the command Fiori: Archive Project in BAS/VSCode
Unzip project in explorer
Enable hidden files view, see that .git folder is included (in this case ~8mb)

Expected results

No .git folder existing

Actual results

.git folder included

Screenshots
If applicable, add screenshots to help explain the problem.
Version/Components/Environment
Add any other context about the problem here
OS:

[x] Mac OS
[ ] Windows
[ ] Other

Root Cause Analysis
Problem
{describe the problem}
Fix
{describe the fix}
Why was it missed
{Some explanation why this issue might have been missed during normal development/testing cycle}
How can we avoid this
{if we don’t want to see this type of issues anymore what we should do to prevent}

@Klaus-Keller - Oh thanks for investigating already, had the same place in mind. Would you mind having a look at #1088? Added case for non-existing gitignore file too.

@Klaus-Keller - Oh thanks for investigating already, had the same place in mind. Would you mind having a look at #1088? Added case for non-existing gitignore file too.

Good point, although a git repo without .gitignore is unlikely, it is possible and we should ignore .git in both cases.

Done with #1088


Correct Horizontal Spacing

Very minor aesthetic request to correct / reduce the spacing between the conditions icon and the date on its left and temperature on its right.  The attached screenshot shows Another Widget on the top and At a Glance below.  The amount of spacing on the former appear unnecessary.  This can also be seen between the temperature and the following degree symbol and scale.
Thanks.

In looking at this again, the issue may be that when text separators are disabled, spaces are left in place rather than the separator just deleted and the surrounding objects moved closer together.

In looking at this again, the issue may be that when text separators are disabled, spaces are left in place rather than the separator just deleted and the surrounding objects moved closer together.

There were no spaces in the previous AnotherWidget versions, even with separator disabled.

There were no spaces in the previous AnotherWidget versions, even with separator disabled.

Fixed


Version
2.5.11
Reproduction link
 https://jsfiddle.net/amazingzhang/obfst2c2/
Steps to reproduce
open it with IE.
What is expected?
Hide the table data   : 'no data'
What is actually happening?
but it is still here.

https://vuejs.org/v2/guide/components.html#DOM-Template-Parsing-Caveats
Please read document carefully first.

hello, as the page , we should not use other tag inner table ul ol, so the below code  how to be less and clean

English
French
China
Japan

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server, gitter or StackOverflow.

If you use a template string, you won't be limited by the DOM limitations 🙂


(SP: ) Fix the search bar for chat messages

If there are no results matching the request, the counter of matches is in the form of “0 of 0” with the inactive down-stepper icon button from the left and the inactive up-stepper icon button from the right and nothing happens.
https://github.com/user-attachments/assets/faa91a95-a25c-4d66-9603-848cbc25ede0

not relevant


没有中文文档？阿里的开源还是国人支持的多吧，请不要搞得太高逼格，最起码中英双文档吧

sorry， i am looking for chinese document about this subject, but i can not find it , maybe somewhere i neglected.
so , as i know ,and i was an alibaba  R&D before,most of alibaba staff are chinese,i think it's easy to provide a zh-cn document, pls.

支持，拥抱国际化的同时宣扬民族文化

ok，我们最近会补上中文文档，谢谢反馈。


Initial version of rotations manifold

I've implemented most of the rotations manifold. Some things are not there yet, like support for Double64 (which requires https://github.com/JuliaMath/DoubleFloats.jl/pull/78 ) or support for AD.

I will be travelling the next two weeks, so I will carefully look at your approach, especially towards AD and take another manifold then (maybe SPD) following the naming and implementation ideas. I will try during travels, to comment on/review your approach.

This implementation is mostly based on yours from Manopt.jl (with the notable difference that inner is scaled by a factor of 1/2 to get this: @test norm(M, pts[1], v) ≈ angles[2] - angles[1])
I'm going to implement a few more manifolds (probably power and product manifolds) in the near future. I'm also thinking about porting FunManifolds.jl to our API relatively soon but I'll probably wait until this package has CI and is registered.

Ah, even better (will look at the code only now);
When the Interface is fixed and manifolds are covered as far as I need them, I will also migrate Manopt.jl (slowly), after this package has a CI and is registered.

@sdaxen This book: http://www.eeci-institute.eu/GSC2011/Photos-EECI/EECI-GSC-2011-M5/book_AMS.pdf looks like a good source about matrix manifolds like this one.

You can get that book also officially open access https://press.princeton.edu/absil and yes I can recommend that book definetly.

@kellertuer , I'm finishing implementation of inverse retractions and I've found a problem. The polar inverse retraction does not seem to work for 2d rotations by 0 and pi/2. To be precise, an error is reported for Float32 but not for Float64 but AFAICT it's a problem with the method: sylvester function https://docs.julialang.org/en/v1/stdlib/LinearAlgebra/index.html#LinearAlgebra.sylvester requires A and -B to have no eigenvalues with equal real parts but in my case both eigenvalues are purely imaginary. What should we do about it?

What should we do about it?

Like for the logarithmic map, also inverse retractions are only locally defined and the two points you mention are exactly that: Not within injectiviy radius. What did we agree on for the log (on the sphere)? We could provide a deterministic choice or throw an error, but it should be consistent throughout the Museum.

This wasn't discussed for sphere yet. I think throwing a custom OutsideOfInjectivityRadius exception would be appropriate.

I would maybe call it OutOfInjectivityRadiusError but in general I am fine with an error for that case, since log (or here inverseRetraction is not a function in that case (but multivalued).

A few general notes.
What about renaming Rotations to RotationMatrices? I mention this because there are other ways of representing rotations as abstract geometric objects (e.g. quaternions), but we're restriction ourself to the usual rotation matrix representation. I don't have a strong preference here, but I'm curious about your thoughts.
It seems that this implementation implicitly defines the tangent space at any point as the tangent space at the identity, the Lie algebra. This is different from how we have been discussing the tangent spaces in coordinates of the embedding so far, where they are a vector subspace of the ambient space that is tangent to the manifold at the point. I favor using the consistent definition of tangent space here (for X \in SO(n), V \in T_e SO(n), W = X V \in T_X SO(n)) (see for example Absil eq 3.26).  We could always have variants of the functions that drop the point of the manifold, assuming the identity element, but in my opinion, those make more sense when we wrap Rotations{n} with the Lie group structure (without that structure, why prefer the identity element over any other)?
For at least n=2 and n=3, the matrix exponential/logarithm can be computed analytically, so we could specialize those computations.
I believe the injectivity radius of SO(2) is pi, not pi/2.

Renaming this to RotationMatrices is reasonable but I don't have strong preference either. Just using Rotations is shorter though and I doubt we will ever have an implementation that uses a different representation.
I'm also slightly in favor of changing the tangent space representation to the one that doesn't transform to T_e SO(n), the only reason I've picked the current solution is that's how it's done in Manopt.jl and it was easier to do this.
Yes, we should have some better implementations for these two cases (n=2, n=3).
The injectivity radius for SO(2) for this embedding (for the logarithmic map) is pi*sqrt(2) I think? I've removed the scaling. It's smaller for the polar inverse retraction.

Since for the Sphere we also have a default one (that does not say it's the embeddd one), I would like to keep Rotations. Another choice could be that as soon as we have several implementations, we use Rotations as a constructor with options that uses the “best” (most efficient) implementation for each dimension by default and can easily be used to switch to others.
Concerning the usage of the Lie algebra for all tangent spaces – the Lie groups I worked with always had the advantages that you spare several transforms if you save tangent vectors as elements from the Lie algebra. But you're right that might be a good default when using exactly that machinery. As long as this way of working can be done somehow I am fine with another default (i.e. the full representation).

@kellertuer Did you check your implementation of the QR retraction/inverse retraction in Manopt.jl? Code in this PR is almost identical and inverse_retraction! doesn't really give a vector that retracts to the original point. I've commented out the failing test for now.

The injectivity radius for SO(2) for this embedding (for the logarithmic map) is pi*sqrt(2) I think? I've removed the scaling. It's smaller for the polar inverse retraction.

Yes, pi*sqrt(2) looks right, though I worry now that this behavior might be too confusing for users. I'm starting to change my mind on the default embedding. I don't have a problem with embedding the rotation matrices in a Euclidean space with a metric of I/2, which would make distances angles and the injectivity radius length pi, as long as its clearly documented.

Concerning the usage of the Lie algebra for all tangent spaces – the Lie groups I worked with always had the advantages that you spare several transforms if you save tangent vectors as elements from the Lie algebra. But you're right that might be a good default when using exactly that machinery. As long as this way of working can be done somehow I am fine with another default (i.e. the full representation).

Yeah, this is the annoying part of it, but I think it's a common misconception that the Lie algebras is the tangent space at more than one point, and it would be nice if we were consistent for novice users to avoid that confusion.

Yes, pi*sqrt(2) looks right, though I worry now that this behavior might be too confusing for users. I'm starting to change my mind on the default embedding. I don't have a problem with embedding the rotation matrices in a Euclidean space with a metric of I/2, which would make distances angles and the injectivity radius length pi, as long as its clearly documented.

We can also change the embedding to have it isometric and get the geodesic distance be equal to the angle.

Concerning the usage of the Lie algebra for all tangent spaces – the Lie groups I worked with always had the advantages that you spare several transforms if you save tangent vectors as elements from the Lie algebra. But you're right that might be a good default when using exactly that machinery. As long as this way of working can be done somehow I am fine with another default (i.e. the full representation).

Yeah, this is the annoying part of it, but I think it's a common misconception that the Lie algebras is the tangent space at more than one point, and it would be nice if we were consistent for novice users to avoid that confusion.

Then I think I'll make a flag for this option, something like
abstract type AbstractTangentRepresentation end
struct OrthogonalTangentRepresentation <: AbstractTangentRepresentation end
struct LieAlgebraTangentRepresentation <: AbstractTangentRepresentation end

struct Rotations{N, TSR<:AbstractTangentRepresentation} <: Manifold end

with orthogonal representation being the default.

We can also change the embedding to have it isometric and get the geodesic distance be equal to the angle.

Can you explain this a little more? I thought an isometric embedding was one where the pullback metric was the same as the ambient metric. So doesn't the current metric assume an isometric embedding?

Then I think I'll make a flag for this option, something like
abstract type AbstractTangentRepresentation end
struct OrthogonalTangentRepresentation <: AbstractTangentRepresentation end
struct LieAlgebraTangentRepresentation <: AbstractTangentRepresentation end

struct Rotations{N, TSR<:AbstractTangentRepresentation} <: Manifold end

with orthogonal representation being the default.

I think it's good we're discussing this, because we're providing both a base interface for manifolds and default manifold implementations. My understanding of our philosophy so far for manifolds is that we provide default implementations assuming one representation but taking any type for points and vectors, and users can change the representation by creating their own MPoint, TVector, and CoTVector. This is one approach, but another would be for manifolds to be created with flags like you have proposed here that enable the methods to do dispatch. The downside to this is one may want to call a method for Rotations{N,OrthogonalTangentRepresentation} that internally uses the functionality of Rotations{N,LieAlgebraTangentRepresentation}. As a design decision, which do we want to prefer?

Can you explain this a little more? I thought an isometric embedding was one where the pullback metric was the same as the ambient metric. So doesn't the current metric assume an isometric embedding?

My idea was to use a different representation for SO(n) than rotation matrices to have the pullback metric that results in nice angles for geodesic distance. After some thought, it would be even more confusing than these scaled distances.

Then I think I'll make a flag for this option, something like
abstract type AbstractTangentRepresentation end
struct OrthogonalTangentRepresentation <: AbstractTangentRepresentation end
struct LieAlgebraTangentRepresentation <: AbstractTangentRepresentation end

struct Rotations{N, TSR<:AbstractTangentRepresentation} <: Manifold end

with orthogonal representation being the default.

I think it's good we're discussing this, because we're providing both a base interface for manifolds and default manifold implementations. My understanding of our philosophy so far for manifolds is that we provide default implementations assuming one representation but taking any type for points and vectors, and users can change the representation by creating their own MPoint, TVector, and CoTVector. This is one approach, but another would be for manifolds to be created with flags like you have proposed here that enable the methods to do dispatch. The downside to this is one may want to call a method for Rotations{N,OrthogonalTangentRepresentation} that internally uses the functionality of Rotations{N,LieAlgebraTangentRepresentation}. As a design decision, which do we want to prefer?

That's a problem that somehow wasn't discussed yet, with the assumption that a single representation for each manifold would be good enough, at least inside ManifoldMuseum. It looks like it isn't. By the way, I thought MPoint, TVector, and CoTVector are primarily for decorating arrays (like in the case of ArrayManifold) or as a base type for non-array representations. A different representation would be implemented by making a separate type for the manifold. I'm not sure though.
What's the problem with a method for Rotations{N,OrthogonalTangentRepresentation} that internally uses the functionality of Rotations{N,LieAlgebraTangentRepresentation}? It should be definitely possible.

That's a problem that somehow wasn't discussed yet, with the assumption that a single representation for each manifold would be good enough, at least inside ManifoldMuseum. It looks like it isn't. By the way, I thought MPoint, TVector, and CoTVector are primarily for decorating arrays (like in the case of ArrayManifold) or as a base type for non-array representations. A different representation would be implemented by making a separate type for the manifold. I'm not sure though.

Hmm, you're right, it seems I've misunderstood what MPoint and such are for. But I do think they're general enough to use to wrap arrays for dispatch (e.g. for charts).

What's the problem with a method for Rotations{N,OrthogonalTangentRepresentation} that internally uses the functionality of Rotations{N,LieAlgebraTangentRepresentation}? It should be definitely possible.

I have several issues with it. The first is that internally each call of myfunc(M::Rotations{N,OrthogonalTangentRepresentation},...) will need to create a new Rotations{N,LieAlgebraTangentRepresentation} manifold for dispatch. In this case, the manifold is a singleton, so there's no overhead, but what then do we do if we have non-singleton manifolds? (Or would the compiler optimize out any overhead?)
But for me the main issue is the conflation of the representation of a manifold and its (co)tangent spaces with the manifold itself by design. I'm just wondering what the downstream effects might be when we get to charts, etc. I'm not confident enough that this is a problem to oppose this approach though.

Hmm, you're right, it seems I've misunderstood what MPoint and such are for. But I do think they're general enough to use to wrap arrays for dispatch (e.g. for charts).

Yes, these types will also be useful for charts.

I have several issues with it. The first is that internally each call of myfunc(M::Rotations{N,OrthogonalTangentRepresentation},...) will need to create a new Rotations{N,LieAlgebraTangentRepresentation} manifold for dispatch. In this case, the manifold is a singleton, so there's no overhead, but what then do we do if we have non-singleton manifolds? (Or would the compiler optimize out any overhead?)

In such cases we could just extract the part useful for both representations to a separate function.

But for me the main issue is the conflation of the representation of a manifold and its (co)tangent spaces with the manifold itself by design. I'm just wondering what the downstream effects might be when we get to charts, etc. I'm not confident enough that this is a problem to oppose this approach though.

I'm worried about it too, it's yet another thing that will interact with other parts of the project and it's hard to predict these downstream effects. The easiest choice would be to merge this PR with one representation and come back to this issue at a later time, once we have support for multiple charts, custom metrics, Lie groups and more developed support for AD.

For me the additional type seems a little overtyped, do you think that the tangent representation is really necessary for the basic manifold you are implementing here?
I mean we could try to approach the same model we did for the metric: There is an implicit default representation (well documented, maybe different for every manifold) and if you want to have more control over that representation you use a TangentSpace (without Manifold for the type) that acts as a decorator (lice MetricManifold)? This way you again to not conflate but can still specify that later.

Yes, the decorator approach looks like a better idea. The only problem now is which tangent space representation should be the default one.

Let's just agree on one.

My favourite is the Lie algebra representation. It might be misleading for starters, since the elements you store are not the ones from the tangent space but the elements from the Lie algebra, but computationally that is the most effeícient way.
One could store really the tangent vectors but then your manifold functions would be inefficient. This might help first time users, but it might annoy advanced once, because they always have to decorate to just get an efficient version

I'm OK with this, documentation can just explain to first time users what representation is used and why.

I'm also fine with this if well documented.

I've added a distribution on the manifold of rotations and some documentation. The PR looks OK to me now. Is there something that should be done here before merging it?

Thanks @sdaxen for the review :+1: . I think I've fixed everything except the issue with is_manifold_point but I'd prefer to do it in a separate PR.

Nice! Okay, I think this PR is ready to merge now.

Great! Do you want to merge yours first?

Sure, I can do that.


Update link to logo image

/lgtm
/retest

/override pull-cert-manager-approver-policy-verify
(clearly not related to this change)

(clearly not related to this change)

yeah I guess we could exclude readme file from this test


Update chart linting

This is just https://github.com/konveyor/pelorus/pull/324 from my fork.
I'm getting a protected branch error that seems nonsensical.
remote: error: GH006: Protected branch update failed for refs/heads/update_chart_linting.
remote: error: At least 1 approving review is required by reviewers with write access.
To https://github.com/konveyor/pelorus.git
 ! [remote rejected] update_chart_linting -> update_chart_linting (protected branch hook declined)
error: failed to push some refs to 'https://github.com/konveyor/pelorus.git'

I updated my local helm version from 3.6.3 to 3.7.2 to match the one bundled from ct. I'm still seeing the dependency complaint locally but not in CI.

Possibly related to https://github.com/helm/chart-testing/issues/324.

I'm just going to update the linting tools and configuration, make it happy, and disregard the discrepancy for now. Confusing.


Add project closing

Reticketed from #3601.
Notify

[ ] https://gratipay.freshdesk.com/helpdesk/tickets/2750
[ ] https://gratipay.freshdesk.com/helpdesk/tickets/2645
[ ] https://gratipay.freshdesk.com/helpdesk/tickets/6453
[ ] https://gratipay.freshdesk.com/helpdesk/tickets/6575

Should teams whose applications have been denied be automatically removed at some point?
Should teams whose applications are under review be marked as such after creation and before being approved?

@whit537 I am a bit confused about this ticket since https://github.com/gratipay/gratipay.com/pull/3601 was a PR to do this. If it is then shouldn't PR be closed? If not what else is required to close this ticket

Should teams whose applications have been denied be automatically removed at some point?

We've been leaving them up since they are indicative of the types of teams that are approved. We can probably keep doing that even after Decouple, since we will retain "brand fit" as a review criterion.

Ok. Am I right that there are no team log-ins, only contributor/owner log ins? If so, can only the owner close a team? Do we want a way to transition team ownership to another member of the team? Which makes me wonder, can a team have more than one owner?

Am I right that there are no team log-ins, only contributor/owner log ins?

Yes.

If so, can only the owner close a team?

That's probably safest.

Do we want a way to transition team ownership to another member of the team?

That would be good to have, but that's probably worth doing in another PR. It's possible to change ownership by request, it just needs to be done manually in the database.

Which makes me wonder, can a team have more than one owner?

Good question. What are the benefits to a team having more than one owner? Is it ability to edit the team? Should there be owners and also ~users who have team-editing privileges but not ability to close the team?

@JessaWitzel Usually when I work on something like this I end up smashing around coding up a mess, just to wrap my head around the problem. Then I go back and produce several PRs methodically, starting from the inside out. In other words, the first PR probably modifies the database, the next one probably adds some Python APIs (and tests! and docs!). Then once there is Python API deployed, it's time for PRs that use the API and expose that functionality in the UI.
In other words, it's good to plan out the work a bit. Also: we generally try to scope PRs to be about 100-400 line changes each (additions + deletions), for easier digestion. :-)
Does that make any sense?

Can we hide everything, as we do for closed ~user accounts?

+1 from Freshdesk.
As a workaround, I'm inclined to mark the project as "rejected" but leave a note in the description that it was by request.

Can we hide everything, as we do for closed ~user accounts?

No, because we don't allow ~user accounts to be closed unless they aren't project owners, which means we need to clear out the project in order to close ~user accounts.
Closing ~user accounts seems to be the main driver ("user story"?) for people to want to close projects.

Moving to a PR in #4287.

Testing in reality...

Bug closing ~kytrinyx under #4286: https://sentry.io/gratipay/gratipay-com/issues/204048018/

You beat me to it.

Bug fixed and #4286 resolved!
Leaving open until we can notify the rest of the list in the project description ...

@whit537, can you confirm we got some money back for https://gratipay.freshdesk.com/helpdesk/tickets/6453 before I close? There's no entry for it.

Yeah, I don't see any money back yet. Ping again next Monday?

Went ahead and pinged them just now.

Gosh, what a mess! The way the PayPal fees worked out, the user in question still has a -$2.50 balance, and we don't allow closing accounts unless the balance is zero. 😩

Sentry: https://sentry.io/gratipay/gratipay-com/issues/204504679/.

All set! #4291/#4292 deployed and final account closed! 👍


Minor language adjustments

Just a couple of things I noticed reading the docs

Sorry, I just broke your patch by correctly fixing the reference you thought was an underline :)
Please correct.


Correct spelling of "suppress"

"Suppress" is spelled with two P's, even in British English.

+1

Thank you!


[CELEBORN-123] PushDataHandler handleRpcRequestCore fix bug about val…

… isMaster
[BUG]/[FEATURE] title
What changes were proposed in this pull request?
Why are the changes needed?

What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @related-reviewer
@waitinfuture @FMX @RexXiong
/assign @main-reviewer

It's a bug fix, and should be cherry-picked to branch-0.2 as well

It's a bug fix and should be cherry-picked to branch-0.2 as well

I think it should not be cherry-picked, it belongs to unreleased features.


gif images not working

We are using the current version 6bac5b501efd06090dca412af3d64030d4fcda0a
png and jpg images are working as expected.
We are using 4 different sizes.
However, gif images are being saved as 0 byte files at all 4 sizes.
Any ideas?

Just to confirm, I've cloned the repo fresh, used the sample config file along with the test fixture images.
The pngs and jpgs seem to work fine.
The reduced gif works fine.
The resized comes out as 0 bytes.

@elrob I believe this should be already solved.

@elrob I will close the ticket, because I did test gif conversion and it was working fine. If the issue happens for you after updating to latest version, do not hesitate to re-open it and give bit more details, like configuration used or example files. Cheers!


Temporarily set StorageClassDeviceSet.portable to false

Since portable OSDs create problems in combination with failureDomain=host,
and failureDomain=host is currently the only way we are setting failureDomain,
this patch disables OSD portability.
This is an alternative proposal to #172. PR #150 will revert this.
Signed-off-by: Jose A. Rivera<EMAIL_ADDRESS>

/lgtm was considering the exact thing myself.

/lgtm


IOS(Real device) app crashes in debug mode

When switching mobile network connection the app crashes. Only happens in debug mode, in release it's fine

I close this issue because this is related to this issue https://github.com/flutter/flutter/issues/93153


blogpost.

First class insights and visualizations in your pulumi app
As cloud apps tend to be long-lived, we think it's vital that it be possible to get insight and
understanding of the performance of the app, including getting information immediately when
something goes wrong.  Because this is vital to the health of the app, we think this should be
something built into the app from the start, and not something added after the fact as an out of
band artifact.  Pulumi apps allow you to easily define or reference the appropriate
metrics
that show the health of your services, create alarms to let you know when something is wrong, and even easily create dashboards to get live visualization of what's happening in the cloud.


Flash of components before styled components styles

Hi first of all thank you for the workaround to use Styled Components with Remix. Can you help me understand what causes component to without styles flash, before the styled-components styles apply and how to avoid that.

Sorry for the late reply.
Have you read the Pitfalls / Notes section of the readme?
maybe the discussion between @jozefmery and me can help you understand more? https://github.com/Xiphe/remix-island/issues/2
Apart from that I'd need more details to understand your scenario.

@Xiphe I've moved my global styles to the static head with ease. However, that's not helping with the styled components styling in each individual component. My thought is that I'd have to somehow wrap a sheet.collectStyles around the existing Remix context. Or I can create a new context and remove it after hydration (I have no clue how to remove it lol). I have my code set up like this so far:
`onShellReady() {
const head = renderHeadToString({ request, remixContext, Head });
const sheet = new ServerStyleSheet();
const globalStyles = renderToString(sheet.collectStyles())
shellRendered = true;
const body = new PassThrough();

responseHeaders.set("Content-Type", "text/html");
const styledComponentStyles = sheet.getStyleTags();

resolve(
    new Response(body, {
        headers: responseHeaders,
        status: responseStatusCode,
    })
);

body.write(
    `<!DOCTYPE html>
        <html lang="en">
            <head>
	    ${COMMON_HEAD}
	    ${globalStyles}
	    ${styledComponentStyles}
	    ${head}
	</head>
	<body>
	<div id="root">`,
);
pipe(body);
body.write(`</div></body></html>`);

},`

Hey @imballinst thanks for reaching out!
These comments are pretty essential to how remix-island is working. It might not be relevant for your app. But one of the great things with remix is that different routes can have different stuff in their <head>. (Good example for this is when you have a css file that's only relevant for one route you can configure it that it's only on the page when the route is active).
Since with remix island, remix itself does no longer control the <head> directly this lib need to cater for that. When you remove the comments it might happen that when you enter the page on a route that has a special css that makes the background pink and then navigate away from it, the special css stays on the page, even though it would have been removed in classic remix.
Here is the part in the code that picks up on those comments: https://github.com/Xiphe/remix-island/blob/main/src/index.ts#L122

As to you tailwind problem.

Everything that does not need to be managed by remix should be placed before ${head} in entry.server.tsx.

As your tailwind stylesheet is most likely constant across the whole page try moving it out of remix and into the entry.server.tsx file that way it will be placed outside of the remix-island managed part of the head.

@Xiphe  Does it make sense to replace useEffect with useLayoutEffect to prevent FOUC?

@dimik As mentioned earlier there shouldn't be a fouc when implemented correctly. If you experience it please share a repo that reproduces the issue.
The styles have to be on the page before hydration anyways so wether we use useLayoutEffect or useEffect shouldn't make a difference.


evaluate issue

In the process of sampling, I encountered the issue "bash: sampler.splits[validation, ]: command not found."The parameters I used are as follows:
python evaluation/generate_samples.py
sampler.config_sampler=evaluation/configs/sampler.yaml
sampler.model_logdir="./logs/2024-08-30T17-40-59_vas_transformer"
sampler.splits"[validation, ]" \
sampler.samples_per_video=10
sampler.batch_size=4
sampler.top_k=64
data.params.spec_dir_path="./data/vas/features//melspec_10s_22050hz/"
data.params.rgb_feats_dir_path="./data/vas/features//feature_rgb_bninception_dim1024_21.5fps/"
data.params.flow_feats_dir_path="./data/vas/features/*/feature_flow_bninception_dim1024_21.5fps/" \

try adding \ at the end of each line except for the last one

May I ask why I set sampler.samples_per_video=10 but the training shows 1

read 6.1.7 Evaluation of Generated Samples for details


multi-tenancy networking: adapt neutron network controller to work with network object in multi-tenancy cluster

What would you like to be added:
ability to manage vpc networks for Neutron-based network provider.
Why is this needed:
We had a network controller (part of kube-controller-manager) able to manage Neutron networks in previous iteration. However, it was not designed and implemented with multi-tenancy in mind, and it had no Network CR but used pod.spec.vpc field directly, which is not in line with the current design proposal.

closed; neutron integration is not priority for arktos right now.


Can't import-run in single mode

Hello,
Thanks for the great package, which I'm trying to use for the first time.
I would like to copy runs -- logged locally using Pytorch Lightning and MLFlowLogger -- from a local experiment on a machine that can't access our mlflow server (name=NAME, ID=XXX) to our mlflow server where the "same" experiment exists already (name=NAME, ID=YYY). Is that an intended use case?
Process:

export-run on local machine (works)
copy resulting folder to the machine which runs the server
import-run on server machine (having set MLFLOW_TRACKING_URI, giving --experiment-name=NAME and --input-dir)

I'm getting a load of mlflow.exceptions.MissingConfigException: Yaml file '/DATA/CALCUL/mlflow_artifacts/<exp_id>/meta.yaml' does not exist. errors -- basically one for each existing project (they indeed do not exist, maybe because the server was setup very long ago) -- then a final mlflow.exceptions.MlflowException: Experiment 'NAME' already exists.
Leaving the experiment.json in the resulting folder as is, a new folder XXX gets created on the server machine, containing only a meta.yaml file. Modifying experiment.json to match ID YYY, nothing seems to happen (the runs in experiment YYY on the server machine are intact). Both throw the same chain of errors.
Additional info: importing an experiment with a name and an ID that don't exist on the server gives the same error.
Also, I am curious whether this fits into "Importing from a file-based --backend-store-uri implementation is not supported"? Since I'm using Lightning without running a server locally, I'd say it belongs to the "file-based" category?
Could you please help with that?
Thanks a lot!

Hey there, sorry for the delay.

where the "same" experiment exists already (name=NAME, ID=YYY). Is that an intended use case?

Yes, this should be OK. If experiment exists import will use it. If t doesn't it creates it.

maybe because the server was setup very long ag

The tool doesn't address MLflow version discrepancies. I would recommend you upgrade your old tracking server to the latest MLflow, and then export it. Every now and then there are major API and schema changes, so you have to run the schema update script. Tools stays current of the latest MLflow version.

Importing from a file-based

File-based is not supported.  From General Limitations
"Importing from a file-based --backend-store-uri implementation is not supported"
Hope I got all the questions.


OnSignalExternalWorkflow doesn't function when signaling child workflow

Expected Behavior
I would expect that OnSignalExternalWorkflow would be triggered by calling workflow.SignalExternalWorkflow with matching params.
Actual Behavior
However, whenever the target of workflow.SignalExternalWorkflow is a child workflow started with env.OnWorkflow, it is now considered a running workflow, and mock calls will not be triggered, but rather it will attempt to signal this workflow. This will fail to signal and also not register the call to the mocked env.OnSignalExternalWorkflow.
Essentially, it's impossible to correctly assert that SignalExternalWorkflow was called if the target workflow was first mocked with env.OnWorkflow.
This may be considered a feature request, but this behavior doesn't seem like it's the intended way things should be working?

From our docs on OnSignalExternalWorkflow
TestWorkflowEnvironment handles sending signals between the workflows that are started from the root workflow. For example, sending signals between parent and child workflows. Or sending signals between 2 child workflows. However, it does not know what to do if your tested workflow code is sending signal to external unknown workflows. In that case, you will need to setup mock for those signal calls. Some examples of how to setup mock:

So  it is intended that signaling a child workflow does not trigger OnSignalExternalWorkflow .I don't think it is correct to call the mock on OnSignalExternalWorkflow . If the test environment is aware of the workflow being signaled then the test environment knows what will happen on the signal request, so there is no need to mock it. Mocking it just opens up potential ways users can write inconsistent test code

Closing since this is the intended behavior


Create Datapipe to load in raw data into resampled format

See https://github.com/openclimatefix/ocf_datapipes/issues/136

Can also be something to convert it and save to netCDF that can be read by the current datapipes as well, doesn't have to be a datapipe itself


[WOR-1190] Show protected workspace.

Jira Ticket: https://broadworkbench.atlassian.net/browse/WOR-1190
What

Changes the way that "locked" and "read-only" workspaces are displayed on the workspace dashboard.
Adds an icon w/tooltip for indicating a protected workspace (keys off of workspace policy, so only Azure workspaces will display this)
Adds a field to "Workspace Information" for protected workspaces

Why

Desire to make it clear when an Azure workspace is protected

Testing strategy
Before (read-only, if also locked both things would be in the same "pill"):

After (each attribute has it's own "pill"):

Protected (and locked) workspace:

Integration test failures are a known issue: https://broadinstitute.slack.com/archives/C02T8G2FJCQ/p1693934907369149


Startup perf improvements

Analyze current state of startup perf, determine if there are any places we can find improvements that we do not yet already know about.
Investigation results:
Startup perf has been steadily improving over the past year. Version 1.16.0 is about 2 seconds faster than version 1.12.0, 20% improvement.
I made some initial changes in 1.17.0 to reduce time spent in splash screen, but it's not much. At this point, there really isn't much more we can do to reduce time spent in the splash screen. At best we could probably cut that time down by no more than 0.5 seconds. In fact, our startup perf is closing in on VS Code. So at this point we have two goals:

Make startup visually fast and nice enough to get rid of splash window
Reduce time it takes to load initial nodes in the tree view

Recommendations to achieve those goals:

[x] Make loading of extensions happen in parallel with UI setup (blocked until we can control when nodes start loading, if QA nodes are dependent on an extension, then if extensions take too long to load, then, QA nodes will be broken). #3951
[ ] Get rid of splash window, just open main window with at least a background color matching that of the theme. Note: main window should be opened in startup earlier than it is today so the user has an indication that app is opening ASAP
[x] Setup dialog manager lazily. #4318
[ ] Setup updater main listeners lazily or move update manager to main so they aren't needed
[x] Setup windows jumplist/macos dock menu after UI is showed. #4327
[ ] Reduce number of preloaded resources.
[ ] Push checking for updates to much later, 30 seconds in?
[x] Make it possible to say "cloud explorer load tree view items now", doing so will allow for loading extensions in parallel and loading resources later. #3952
[x] Don't do API calls for resource type nodes, have producers return resource type node AND children resource nodes if there are that type of resource. #3953
[ ] Move providers/code which should be in main to main and make sure they are as lazily loaded as possible. E.g.: proxy, updates, dialogs.
[x] Setup identity stuff earlier so it loads in parallel with rest of the app #4319
[x] Initially create a facade of an app menu (just the File, Edit, Help, etc), and only fill them out once UI is shown

Recommendations following investigation:

[ ] - Make loading of extensions happen in parallel with UI setup (blocked until we can control when nodes start loading, if QA nodes are dependent on an extension, then if extensions take too long to load, then, QA nodes will be broken)
[ ] - Get rid of splash window, just open main window with at least a background color matching that of the theme
[ ] - Setup dialog manager lazily
[ ] - Setup updater main listeners lazily
[ ] - Setup windows jumplist/macos dock menu after UI is showed
[ ] - Reduce number of preloaded resources
[ ] - Push checking for updates to much later, 30 seconds in?
[ ] - Make it possible to say "cloud explorer load tree view items now", doing so will allow for loading extensions in parallel and loading resources later
[ ] - Don't do API calls for resource type nodes, have producers return resource type node AND each resource node if there are that type of resource

Everything we wanted for 1.20 is done. Moving this to 1.21.

Moving this to near future for now. The remaining ideas will only be small gains. There are now higher priority tasks that need our time.


MobilePay Purchase flow fails - State is null

MobilePay purchase flow fails when trying to create MobilePayPaymentDetails object after geting response from PurchaseRepository
PurchaseRepository.initiatePurchase returns a response with state = null and causes an exception:
CastError (type 'Null' is not a subtype of type 'String' in type cast)

Just to add to this, in my older version of the generated code, state is correctly marked as nullable. Whether this change is caused by a change in the library that generate the httpClient code, or the OpenApiSpec I'm not sure of yet

Bug is introduced in the package upgrade of swagger_dart_code_generator to 2.7.8 in Pull Request https://github.com/AnalogIO/coffeecard_app/pull/348
Analog Core does not support nullability officially yet. This requires an update of the codebase. See issue https://github.com/AnalogIO/analog-core/issues/82
Probably is it the best to rollback the package to the old version for now


Typo in UMDF versions

The page has the sentence: "Writing a driver using UMDF version 1 requires using the COM programming model to write C++ code. While UMDF version 1 is based on the same conceptual driver programming model as KMDF".
"version 1" is indicated both times. The first one should be "2", as in "Writing a driver using UMDF version 2 requires using..." This is clarified in the next paragraph.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7195a081-81f1-5160-a078-d6044e005d65
Version Independent ID: 9f07ab89-d297-ae95-4b4a-2cde15f4ea95
Content: Getting Started with UMDF - Windows drivers
Content Source: windows-driver-docs-pr/wdf/getting-started-with-umdf-version-2.md
Product: windows-hardware
Technology: wdf
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Wow Brett, great eye!  Thanks for the report.  I just pushed the fix -- should be on the live site in a few minutes.


TypeError: Cannot read properties of undefined (reading 'slice')

What are the steps to reproduce this issue?

Write a config for react-query as the client
Run orval command (v6.9.2

What happens?
A weird error appears, don't even know what's the issue
…
What were you expecting to happen?
Generate the models and API operations for all the enpoints
…
Any logs, error output, etc?
petstore - TypeError: Cannot read properties of undefined (reading 'slice')
…
Any other comments?
I saw there's already an issue which is really similar https://github.com/anymaniax/orval/issues/494
…
What versions are you using?
Operating System: MacOS X (M1)
Package Version: v6.9.2
Browser Version: …

Hello @kubakl do you have an example for me?

@anymaniax What type of example you want me to give you? The OpenAPIi spec?

If you can yes

Sorry for not answering, I assume it's a config issue, I copied it from the documentation but still it may be wrong:
module.exports = {
  petstore: {
    output: {
      mode: 'tags-split',
      target: 'src/petstore.ts',
      schemas: 'src/model',
      client: 'react-query',
      mock: true,
    },
    input: {
      target: '../schema/api-v1.yaml',
    },
  },
};

The schema doesn't have any issues because I also generate golang code using openapi-generator and it works just fine.

Hi @kubakl, I would need the yaml or an example that reproduce the error with the yaml

@anymaniax I'm reviving this thread as I am running into the same issue with orval printing out
🛑  api - TypeError: Cannot read properties of undefined (reading 'slice')

I have created a repo with a simple example that can be used to reproduce this error: https://github.com/lmossman/orval-example
To reproduce the error, you can follow these steps:

git clone git@github.com:lmossman/orval-example.git
cd orval-example
npm install
npm run orval
which will output the error above.

I believe this error happens when trying to reference an external json/yaml file in the OpenAPI spec, like I do on this line that I added to your petstore.yaml sample file:
https://github.com/lmossman/orval-example/blob/a8c46736987cf2ffd3fd3b7bf6f50048937000b4/src/petstore.yaml#L116-L117
I have confirmed that the openapi-generator validates my OpenAPI spec successfully, and is able to produce client code from it. So this issue seems to be specific to orval not being able to handle referencing external files.
Let me know if there is any other info that I can provide here! I'd love to get this fixed as we need to be able to reference external files in our production application that is using orval. Thanks!

As @lmossman says, I also have the same structure in my OpenAPI definition, I split it across different files, paths, schemas, responses etc. This actually could be the problem.

As temporary solution you could generate your schema with openapi-cli and then use orval with the output.
openapi-cli bundle yourschema.yaml -o tmp/yourschema.json && orval --config orval.config.ts --clean

On your orval you should add the generated file.
...
    input: {
      target: resolve(__dirname, "./tmp/yourschema.json"),
    },
...

@hbarrientosg nice suggestion, I will try that! Thanks

Hello @lmossman, @hbarrientosg, @kubakl, I improved the parsing and everything should work as expected in the next release

@anymaniax I have upgraded to version 6.11.0-alpha.5 of orval, and while I no longer get the TypeError posted above, the generated typescript still doesn't seem quite right.
For components that are pointing to external JSON schema files, the typescript file that orval generates still doesn't contain classes for the referenced JSON. It just adds a type onto the field which is the capitalized version of the field name, but doesn't actually define what that type is.
For example, in my orval-example repo that I created to demonstrate this behavior, I point to a breed.json JSON schema file here with a $ref: https://github.com/lmossman/orval-example/blob/ae07d4565f2851a86b211240e92259a5bfa1994d/src/petstore.yaml#L116-L117
But when I run npm run orval, the Petstore.ts file it generates just contains this interface definition for Pet, without ever defining the interface for Breed: https://github.com/lmossman/orval-example/blob/ae07d4565f2851a86b211240e92259a5bfa1994d/src/client/Petstore.ts#L29
So pointing to an external file results in broken typescript code generated from orval.

@lmossman can you try 6.11.0-alpha.6 and tell if it's good for you now?

@anymaniax it is a bit closer now, but I still have a couple of issues:

If the external JSON schema file is in some nested path, then orval uses two different names for the generated type.
For example, here I am now pointing to a nested directory that contains the JSON schema, and this results in orval generating the Pet object with a breed field of type Breed, but it defines that type with the name PathToSchemaBreed
It seems that orval is only generating types for the top-level fields in the external JSON schema, whereas I need it to generate types for every field and every nested field in that JSON schema.
For example, here I point to an external JSON schema file which contains a definitions block, containing JSON schema blocks that are pointed at with $ref in other parts of the file. This does produce an output file, but it only defines  the top-level PathToSchemaBreedNested type, and doesn't define types for nested fields like Ancestry. Orval also prints out these warnings when I run orval on that file:

🍻 Start orval v6.11.0-alpha.6 - A swagger client generator for typescript
🎉 api - Your OpenAPI spec has been converted into ready to use orval!
⚠  SyntaxError: Swagger schema validation failed.
  #/paths/~1pets/get/responses/200/content/application~1json/schema/items/properties/breed must NOT have additional properties
  #/paths/~1pets/get/responses/200/content/application~1json/schema/items/properties/breed must have required property '$ref'
  #/paths/~1pets/get/responses/200/content/application~1json/schema/items/properties/breed must match exactly one schema in oneOf
  #/paths/~1pets/get/responses/200/content/application~1json/schema/items must have required property '$ref'
  #/paths/~1pets/get/responses/200/content/application~1json/schema/items must match exactly one schema in oneOf
  #/paths/~1pets/get/responses/200/content/application~1json/schema must have required property '$ref'
  #/paths/~1pets/get/responses/200/content/application~1json/schema must match exactly one schema in oneOf
  #/paths/~1pets/get/responses/200 must have required property '$ref'
  #/paths/~1pets/get/responses/200 must match exactly one schema in oneOf
  #/paths/~1pets~1{petId}/get/responses/200/content/application~1json/schema/properties/breed must NOT have additional properties
  #/paths/~1pets~1{petId}/get/responses/200/content/application~1json/schema/properties/breed must have required property '$ref'
  #/paths/~1pets~1{petId}/get/responses/200/content/application~1json/schema/properties/breed must match exactly one schema in oneOf
  #/paths/~1pets~1{petId}/get/responses/200/content/application~1json/schema must have required property '$ref'
  #/paths/~1pets~1{petId}/get/responses/200/content/application~1json/schema must match exactly one schema in oneOf
  #/paths/~1pets~1{petId}/get/responses/200 must have required property '$ref'
  #/paths/~1pets~1{petId}/get/responses/200 must match exactly one schema in oneOf
  #/components/schemas/Pet/properties/breed must NOT have additional properties
  #/components/schemas/Pet/properties/breed must have required property '$ref'
  #/components/schemas/Pet/properties/breed must match exactly one schema in oneOf
  #/components/schemas/Pet must have required property '$ref'
  #/components/schemas/Pet must match exactly one schema in oneOf
  #/components/schemas/Pets/items/properties/breed must NOT have additional properties
  #/components/schemas/Pets/items/properties/breed must have required property '$ref'
  #/components/schemas/Pets/items/properties/breed must match exactly one schema in oneOf
  #/components/schemas/Pets/items must have required property '$ref'
  #/components/schemas/Pets/items must match exactly one schema in oneOf
  #/components/schemas/Pets must have required property '$ref'
  #/components/schemas/Pets must match exactly one schema in oneOf

🎉 apiNestedJson - Your OpenAPI spec has been converted into ready to use orval!

If orval can correctly produce an output file for that petstore_nested_json.yaml spec which contains properly-named types for Breed, Ancestry, and OriginLocation, that would be perfect! Thanks

@lmossman I fixed the two issues but still have a little problem with the relative path. Will try to fix it asap to be able to release a new alpha with it

@anymaniax I tried this out and it seems to have fixed most of the issues I was seeing. However, when I tried this out in the actual project I am using orval for, I still ran into a case where a typescript type did not properly get generated for a definition in the JSON file.
I have updated my example here to demonstrate this issue. Notice that if you run npm run orval on that repo's current master, the Petstore.ts file that it generates does not contain a type definition for JsonSchema or SimpleRetriever.
I think this may be an issue with allOf in the JSON schema - having this field in an object seems to cause orval to not generate a type for it.

@lmossman can you try with<EMAIL_ADDRESS>

@anymaniax thanks for the quick response! This is looking really close, but I found one more issue: it seems that two duplicate typescript types with the same name are being generated in the case that there are two fields with almost the same name (only a _ prefix differentiates them).
I've updated my repo here with an example of this: the DeclarativeStream definition in my JSON schema has a schema_loader and a _schema_loader field each with the same anyOf value, and this causes orval to generate two identical  DeclarativeStreamSchemaLoader types, which is not allowed since it is a duplicate identifier.

Now it works for me with no problems, thx very much!

@anymaniax is it looking like the issue I described above is a straightforward fix? I think this is the last issue that is blocking me from using orval in our production app so I'm really looking forward it being resolved!

@lmossman  you can try with 6.11.0-alpha.10 should be fixed

@anymaniax that seems to have fixed it! Thank you for the quick response. I believe all of the issues called out in this thread have been resolved in the latest version, so this issue can be resolved

@lmossman cool don’t hesitate if you have other issues

FYI @anymaniax I discovered another problem, so I opened an issue here: https://github.com/anymaniax/orval/issues/726


remove skipping of tests for builds.apache.org as we no longer use it

even if groovy decides to use builds.apache.org again, these workarounds may not be necessary today

+1

I am +0 on this change. I think we want to get builds.apache.org working. It's just that no-one has had time to get it working.

I Paul I understand that was the goal, but it did not happen during the last two years.
When I added these workarounds one and a half year ago is was working most of the time, but it was unreliable enough to be useless.
If/when groovy use build.apache.org again almost everything (jdks, groovy codebase, vms/servers, operating systems) will have changed even more, so I doubt that the same workarounds are necessary.


Only cache version-cache.json and create a new cache key on each run

I have updated the workflow in the readme.  I have made changes to key and restore-keys in the step "Fetch old version info" in addition to path as suggested by @GingerGeek in #7.
If we do not supply a new key on each run the new hash will not be stored since github actions caches are immutable, I think.

We should probably delete old actions caches after a while but they are only ~245 bytes each.

I updated my initial PR replacing "github.run_id" with "hashFiles('policy.hujson')" in the hash key so we only get a new key when there is a change in the policy file.

I went back to using github.run_id in the cache key.  Using a hash of the policy file in the cache key does not work as intended if the policy file is restored to an earlier version.
GitHub will remove any cache entries that have not been accessed in over 7 days so using the cache may not be very helpful if the policy file is updated infrequently.

Thank you for this contribution!
I caught up with this issue today and prepared a PR that included this fix alongside another.


Reorganize with a focus on ability to serialize working state and update existing output file.

I'm arriving here for exactly the same reason as the OP in https://github.com/kemayo/leech/issues/63. But i'm also interested in this helping to eventually solve https://github.com/kemayo/leech/issues/55.
As you'll see, the changes are very invasive and perhaps somewhat opinionated. Most of the changes were in service of completing the feature, but at the same time I knew nothing about the epub format or any of this code going in, so certainly some of the changes were in service of improving my own understanding.
I'm posting it as a draft essentially to gauge your interest in merging before I continue putting effort into it. I've already sunk a decent amount of time into this, and if you (rightfully!) decided you weren't interested in general, I'd probably trim out all the features I dont plan to use and start maintaining my own fork 😬. On the other hand, if you were, but the size of changes were the problem, there might be a way to prep some stuff ahead of time in a series of smaller PRs.
I dont think the state of the code is mergeable as-is. This is basically immediately after getting to the point of being confident it can serve the purpose of performing partial updates. In particular, i think all non-"arbitrary" sites are probably broken.
If you decided you could imagine merging this, I would very much like to set up some basic happy-path testing with pytest. If you happened to have example full-html content for each site-kind that'd make it much easier to start getting more confidence that this doesnt break all the dedicated sites.
Most importantly:

All the classes important to collecting data (Site, Story, Chapter, Cover) are dataclasses with from_json classmethods on them.

Additionally i moved some of the runtime information used in Arbitrary into the class state
In combination this was what allowed me to serialize all of the runtime state to disk, so that collection could be resumed later on from the same point.

epub.py/Epub use xmltodict, which let me declaratively produce the xml files.

I think this makes it much easier to understand what the end-result of the files looks like.
Also, i figured this would help in the future to perhaps parse content from an existing epub and merge it with the epub being produced.
Even if you dont accept this changeset, i think it would be an improvment and might be useful for something like https://github.com/kemayo/leech/issues/57 and https://github.com/kemayo/leech/issues/55

Some things i have not yet done:

like i said above, i'd like to see if i can't get it to merge content with some source file more. For example, to avoid overwriting calibre metadata on a previously generated epub. If merged, i'd probably do this as a separate PR.

A not-necessarily ordered collection of comments about some details of the PR.

I converted all your instances of attrs to dataclasses. Not strictly necessary, per se, but dataclasses is already available in 3.7, and you seemed to largely not be using much attrs-specific behaviors.
Moved most the code I touched into a _leech package. This could have been leech, but i didn't necessarily want to move your leech.py, given how the tool is invoked today.

I left sites, mostly because i only touched most of sites incidentally. I'd certainly be happy to move this too
Somewhat unfortunately, my editor automatically runs black on save, so i blackened any code i touched. I'd rather perhaps blacken the whole repo in a PR ahead of this to reduce the diff a bit, than undoing it, if you didn't happen to mind 😬.

Section became Story, mostly because it seems like many of the variables pointing to Section instances were named story
All the references to templates and filenames and whatnot that seemed likely to be specific to epubs, moved into epub.py. This helped encapsulate a bunch of more dynamic runtime stuff into static decisions. like cover-specific handling in some of the output files.

I just added a commit which added a basic collection test for the arbitrary site kind. Not full coverage of changed behavior there, but it exemplifies what I could do, given basic truncated examples of other sites.
I'll definitely also put together some basic happy-path tests to verify the epub.py changes, because that's completely different. and/or at least 1 test at the level consumed by leech.py, as a sort-of e2e test.
Should be straightforward to jumpstart a basic github actions CI for said tests. Although again, this could happen in a follow up, if you were interested.


Typescript support

Would be great to see some definitions for this package on https://github.com/DefinitelyTyped/DefinitelyTyped/

Not just definitions, the whole project is not working with ts files.
works:
json-server --watch db.js
does not work:
json-server --watch db.ts

Not just definitions, this module is not working with TypeScript at all.
Works:
json-server --watch db.js
Does not work:
json-server --watch db.ts

I'm really wanting this too. It makes so much sense defining interfaces for all the API contracts you'd like to configure. Especially if the frontend will be Angular you can reuse the same interfaces. If we simply point json-server to the compiled typescript would it work? In which case how to setup an empty nodejs project with typescript

Just did it: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31107
npm install -D @types/json-server
yarn add -D @types/json-server
🙂

Is this working now?
json-server --watch db.ts

No, just that the programmatic use of json-server (https://github.com/typicode/json-server#module) is now properly typed, as OP asked.
What you want is doable with that programmatic use and ts-node (https://github.com/TypeStrong/ts-node).

That works, unfortunately without --watch but we can use nodemon for that.
Anyway I think the important part of using TypeScript is to have a ts-file instead of a json-file for the db so the responses are typed, but json-server simply parses the file provided by jsonServer.router() as json no matter what.

ts-node json-server.ts

Can you ellaborta how you got the export working? I am getting the error: 'unexpected token {' ont he import db line. I am developing on angular 7 and running
kill-port 3000 && concurrently --kill-others "nodemon --exec ts-node json-server.ts" "ng serve""

to fix the "unexpected token" error see: https://stackoverflow.com/a/51390319/4237304
nevertheless would be nice to have support for a db.ts ouf the box

I just submitted https://github.com/typicode/json-server/pull/994 to allow the CLI to use files with extensions other than .js to allow it to load the DB from a TypeScript file. The only thing you would need to do once this is merged and published is registering the ts-node loader directly in the node executable by doing:
NODE_OPTIONS="--require ts-node/register" json-server db.ts

hi, i had the same issue: i found this and its works:
nodemon --ext ts --watch src --exec './node_modules/.bin/ts-node' src/www.ts
see resource: https://github.com/jamg44/NodeTyped/blob/master/package.json#L10

I tried to make it even shorter:
yarn run ts-node `yarn bin`/json-server

You can still configure the json-server via CLI here but in many cases you just want to go with the defaults.

I tried to make it even shorter:
yarn run ts-node `yarn bin`/json-server

You can still configure the json-server via CLI here but in many cases you just want to go with the defaults.

Two years later I come here again with the exact same question and I thank my past self for writing the documentation :)
Anyhow too bad this project does not seem to be maintained anymore @typicode . Over 500 issues. Open PR for TypeScript integration... Maybe someone wants to make a fork?

Four years passed man!

Two years later I come here again with the exact same question and I thank my past self for writing the documentation :)
Anyhow too bad this project does not seem to be maintained anymore @typicode . Over 500 issues. Open PR for TypeScript integration... Maybe someone wants to make a fork?


Fix to_string.hpp include path in example code

[Current coverage][cc-pull] is 98.10%

Merging [#34][cc-pull] into [master][cc-base-branch] will not change coverage

@@             master        #34   diff @@
==========================================
  Files            72         72
  Lines          5073       5073
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           4977       4977
  Misses           96         96
  Partials          0          0

Powered by Codecov. Last updated by [999e2fa...4a4bf95][cc-compare]
[cc-base-branch]: https://codecov.io/gh/vinniefalco/Beast/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/vinniefalco/Beast/compare/999e2fa0318b5982736d3ea01a418770ea802671...4a4bf95bfefd8f7f5cde654cd394d14aabe4f6e9
[cc-pull]: https://codecov.io/gh/vinniefalco/Beast/pull/34?src=pr

Ahh, good catch! Thanks!

Part of #35 now


FFImageLoading.Transformations.CircleTransformation() error

I just grabbed 2.2.9 and in this line CircleTransformation() is not recognized
new FFImageLoading.Transformations.CircleTransformation(),

Did you install Transformations package? :)

Hi @ronpf,
As @AndreiMisiukevich said, please be sure if Transformations package is installed. Also uninstalling packages and installing once again solves a lot of nuget issues.

I will add from myself,  Follow next steps for cleaning project.

Remove all FFImage packages from project (You can remove thees ones from packages.config from all projects).
Remove them from packages folder (if they exist)
Remove all bin & obj folders from your project's directory
Add packages again
Clean (Just in case) and rebuild project

great, thanks. Things have been running fine lately.


Join slack discussion channel

it is stated in the Readme (https://github.com/helm/helm)

but I cannot join the slack cannel

What is the procedure that allows you to access this channel and have a live discussion?
Don’t have an @get-an-invite-at.slack.kubernetes.io email address?
Contact the workspace administrator at Kubernetes for an invitation.

BTW, I was going to ask a lame question :)
Where are now located charts that were previously published https://github.com/helm/charts (stable and incubator).
I was looking for a new place of that source code for helm, eg this one https://artifacthub.io/packages/helm/twuni/docker-registry and I guess I did not spot the place to click, I guess it is somewhere, but probably not that intuitive as former helm/charts/stable on github...

@sirkubax Re Helm Slack channels, they are part of the Kubernetes Slack workspace. When you go to Kubernetes Slack workspace, you should see "Create an account" in the top right-hand side as shoen

When you create an account you should be able to login to the workspace. You can then browse the Helm channels and add them.

Where are now located charts that were previously published https://github.com/helm/charts (stable and incubator).

Some details on depreaction of the repo: https://helm.sh/blog/charts-repo-deprecation/
If you search Artificat Hub fr a chart you will get link to where it is now hosted. You can also check the README of the charts in the old repo and they will have a link to the now hosted and supported version of the chart.

Could you point me to a place where the link to source code is presented for this chart:
https://artifacthub.io/packages/helm/twuni/docker-registry
I see a link to a sourcecode to Docker image definition https://github.com/docker/distribution-library-image and in the 'original' deprecated chart I do not see a link to the new chart version
https://github.com/helm/charts/tree/master/stable/docker-registry
I believe it is https://github.com/twuni/docker-registry.helm, bu this one has closer name
https://artifacthub.io/packages/helm/phntom/docker-registry
I believe I'm missing the note of the new chart placement in the archived chart https://github.com/helm/charts/tree/master/stable/docker-registry
and missing a link to the source code (https://github.com/twuni/docker-registry.helm) of the current chart on this page
https://artifacthub.io/packages/helm/twuni/docker-registry
there is a link to the author

but it does not even redirect you to the github page, and there is a link to the homepage

but also not the chart source code

@sirkubax Good catch on these, thanks.
This seems to be where the chart repo is: https://github.com/twuni/docker-registry.helm
For the other things, it would be worth raising issues as follows:

In https://github.com/helm/charts, about adding the link in the chart README to the new repo
In https://github.com/artifacthub/hub, to fix the links in the chart metadata

Hope this helps.

Closing this issue as answered. Please feel free to comment here and let us know if you have further questions. Thanks!

Go to http://slack.kubernetes.io/ and input your email, you will get the invitation link in your email inbox


editor.showTabs 'single' prevents drag and drop

When workbench.editor.showTabs is single, then I can't drag and drop a tab to split the screen.

VS Code Version: 1.85.0
OS Version: Windows 11 10.0.22621
Occurs with --disable-extensions

Steps to Reproduce:

Set  workbench.editor.showTabs to single
Open two tabs
Click on the name of the opened tab, try to drag it to the right or bottom

This is as designed. You don't see the tabs underneath in single tabs mode, so a drag and drop would create potentially unexpected behaviour. However, we have commands and the action item in the top right to split an editor into two or support drag and drop on the editors listed in the open editors view in the explorer.


Multiple Macs

https://ibb.co/4fb2M1H Here is a picture of what I am researching.
How do I fix the multiple MACs

I can't say for sure but this could be related to #341.
In short, it happened (before the related fix dating back to Cloudy.5 - v4.5.xxx) that if you had multiple 'similar' devices on LAN, and these were 'exchanging' their IP addresses without HA/meross_lan being updated of the change, that meross_lan wouldn't be able to detect the 'mismatch' and so was starting to communicate with a device which was different from the originally configured.
This led to serious misconfiguration, one of the effects (one of the less problematic though) was the device appearing as having multiple MACS. This was fixed so that it shouldnt happen anymore after the fix, but the 'dirty configuration' polluted the HA core device registry and that's a bit unfixable in code (it would really be too dangerous to try automatically fix a possibly random situation).
The only option left is to manually edit the core.device_registry file into the .storage folder in HA config dir. It should be pretty easy to manually edit and fix it, with the only issue that this file might be huge (more or less) and so a bit 'hard to deal with'.
You should find a way to search for the correct device entry in there and then remove the wrong mac address mapping. save. restart HA
As usual, a temporary backup of the file before any modification could save your life should your edit go wrong.
The other way would be to remove the configuration of the device (from meross_lan) and then re-configure it.


Richer Upset Info

Include match number, what alliance was the underdog, and what percent chance they had of winning

No point in including which was the underdog, because whoever won was the underdog
Percentage chances are interesting


Extended Euclidean Algorithm in python

ISSUE- #249
Description
Added implementation of Extended Euclidean Algorithm to find GCD in python.
Checklist

[X] I've checked the issue list BEFORE deciding what to submit
[X] I've read the contribution guidelines
[X] I've edited the README.md link to my code

Don't forget to visit our website!
Feel free to add this badge after your submission is accepted!

Hi! Could you fix the conflict with the README.md file before I can merge this?

I don't know whats wrong with the readme.md file. When I make changes to it shows "Can't merge automatically".

Next time when it happends rebase it and drop unwanted commit statements . All you have to do it add the file ,update the README.md and then push . Issue PR . Good day . I will tc of the readme from my side

I don't know whats wrong with the readme.md file. When I make changes to it shows "Can't merge automatically".

The problem was that Your forked repo wasnt even with our repo . You can learn how to keep a forked repo even  from here

@anushkrishnav Tysm. I got it now.


chore(ci): update github actions

why
Previous CI configuration combined unit test and e2e test.

it's not a great practice since these two kind tests are not related.
Another reason is that we need setup third-party services for e2e test but not for unit test.

what

separate unit test and e2e test into different github actions
setup mysql for e2e test
update github actions scope/name

LGTM