Authenticating with gcloud auth login on GCE does not seem possible

The docs for the Google Cloud Exporter in opentelemetry-collector-contrib suggest that I get credentials through the command gcloud auth application-default login. When I run gcloud auth application-default login on a GCE VM, I get the following JSON shape:
{
  "client_id": "redacted",
  "client_secret": "redacted",
  "quota_project_id": "my-project-id",
  "refresh_token": "redacted",
  "type": "authorized_user"
}

This causes the exporter to fail with the following error:
Error: failed to build pipelines: failed to create "googlecloud" exporter, in pipeline "metrics/*": no project found with application default credentials

This is because the creds found by google.FindDefaultCredentials don't have a field ProjectID. https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/16f0ea8ce52bbbe71d4cbac84e5317c83d7324b6/exporter/metric/cloudmonitoring.go#L38-L47
I am unsure if this is a GCE specific problem. If it isn't, then the documentation should be revisited. However, it is very possible that this is a GCE specific problem and perhaps a note can be added to the documentation if anything.

My last comment was a lot of rambling. I opened https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/621 to update our docs with better recommendations for authenticating based on environment. tl;dr we shouldn't be telling people to use gcloud auth application-default login except for personal testing. If this looks good I'll add the same change to the upstream docs too.
Longer term, we will need to look more at our auth story (specifically our dependency on project id) and make sure it functionally aligns with the client libraries. For now though, I think this is WAI, just poorly documented.


Spin multi version

Something has happened in the last few commits because after a re-pull it broke.


Doesn't work in IE 9 when there is a row with a colspan

I have a table with multiple tbody sections. The first row of each section is used as a header row so it spans the entire table. It looks like floatThead doesn't know what to do when the header is visible. As I was writing up this issue I thought of a workaround that seems to get the job done:

Hide header rows
apply floatThead
show header rows

I have a Fiddle that can be used to reproduce the problem.

I think you missed the point the getSizingRow method. it needs to return a row where no colspans exist. it can be a row that is hidden from the user. currently your code returns section 1	, it also looks like its copied straight out of the docs, so the selector doesnt apply to your table.

Opps, I've fixed the selector in getSizingRow in the Fiddle now, but the problem remains. I think I got the cause wrong. I think it might be the rowspan and colspan in the THEAD that is causing the problem.

your sizingRow function is still wrong. it should return td or th elements. I fixed it, and it seems to now work for me in IE9:
http://jsfiddle.net/6jnnmkea/4/
Let me know if that works for you, or if something else is busted


Seed security prices by default

Expected Behavior

Add new algorithm setting, enabled by default, for security seed. If enabled after a security is added we should seed an initial historical price to them

Actual Behavior

Security currently do not have an initial price set

Potential Solution

After universe selection, for all security additions changes, we can run them through a history request to see their initial price.
See related GetLastKnownPrices, currently supports a single asset, we want to run history requests in parallel -> universe selection of 500 assets can't seed sequentially

Reproducing the Problem

N/A
System Information

N/A
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

[x] I have provided detailed steps to reproduce the issue

@Martin-Molinero
I think this is a great idea and it would benefit most users.
I just want to add a suggestion and I don't want to open a new ticket because it fits so well here.
Could we extend the security seeder to also take into account the open interest for futures and options?

See related https://github.com/QuantConnect/Lean/issues/4736


Implement associated image replacement for DICOM images

#213 will add functionality to delete DICOM associated images based on a given set of rules. Additional redaction techniques for images, such as replacement with a black rectangle, might also be useful.

Applying "wontfix" label for now. Parity with SVS is not essential. SVS files need certain associated images to be present in order to be considered valid Aperio files for Aperio software. no such constraint exists for DICOM.


API for fetching accumulated usage of resource instances for a given …

API for fetching accumulated usage of resource instances for a given time and time window.
Issue 43

Thanks for this contribution. I'm going to review the changes in your first commit (8d24727) but could you please rebase it on the latest version of master? Your second commit (01b383e) looks a little scary as it looks like a merge of master into your dev branch, containing all kinds of changes unrelated to the API you're contributing here.

Looks like this pull requests conflicts with the master branch.


Update api.md

Update docs api endpoint.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


⚠ Bofrost.lu has degraded performance

In 709b80b, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1917 ms

Resolved: Bofrost.lu performance has improved in 21fbcf5 after 33 minutes.


Warrior Traverse Cut

Can you add Traverse Cut to "class window" to show how many stack you have and for how long?

I don't know if it's possible to add it (it may cause the window to become too messy). I'll see if I can do something next two weeks anyway.


why low test WER on CHiME, training on librispeech Acoustic Model

Librispeech provides fairly large amounts of speech (960hour) which is recorded from various recording environment. So I expect training acoustic model on this corpus will also works for speech in another domain, such as CHiME-3.
For acoustic model, deepspeech model is trained with librispeech corpus.
For language model, 4-gram (from http://www.openslr.org/11/) is used.
It achieve 7.6% WER on test-clean, 24.8% WER on test-other.
However, this model is not working to recognize CHiME-3 data.
Clean evaluation dataset got WER 64.2%, Cafe-noise evaluation dataset got 83.7% WER.
What could be the possible reason for degradation?

@gmkim90 Our experiment also shows that the model trained from LibriSpeech performs bad on CHiME data. Maybe this is because the LibriSpeech data is too clean and ideal compared to the CHiME data, resulting the trained model lacking of the capacity to recognize the latter, which is recorded in the noisy public environment.

I agree with your opinion for CHiME noisy data.
However, when I test on CHiME-3 clean dataset, which is WSJ0, it achieve 64.2% WER.


[bug] Error when destroying a node

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Error appears when destroying a node from a cluster:

Failed to Destroy The Node
can't access property "metadata", a[h] is undefined

I've currently got this with 2 different nodes.
Expected Behavior
The node is removed from the cluster
Steps To Reproduce

Select a cluster
Select node in the cluster
Click Destroy

What browsers are you seeing the problem on?
No response
Anything else?
No response

Can you please provide some more information on the issue? is it a control plane or worker node? how many nodes does the cluster have?

This was a cluster with 3 control nodes and 5 workers. I was trying to delete a worker.
I was unable to move forwards with this so I deleted the cluster.

Any chance that the machines had duplicate node names?

This should be fixed by now, please feel to re-open if the issue persists.


Window Management and Moving Windows to Other Monitors

Hey Team,
I didn't see any packages for window management in Karabiner... is there any way to move active windows to a second monitor?
Thanks,
Justin

If you can move active window from shell script or other scripts, you can call it from Karabiner.
https://pqrs.org/osx/karabiner/xml.html.en#vkopenurldef


Allow info headers to be compressable on sidebar

Currently, info-description-headings-in-navbar allows drawing a custom sidebar with h1 and h2 headings for navigation.
However, it can quickly become a bit untidy if the info sections contain a lot of headings.
Alternatively - we can use H3 so that specific headings dont show up on sidebar, but then for such headings, we cannot get a direct link (route) to the object.
For instance, if we build a FAQ in info section - it becomes a bit difficult to either keep sidebar in readable format (not too large) and also still have direct link to specific FAQ query.
Thus, the feature request to allow a compress/expand for the h1 titles on the sidebar.

Seconded. This is especially annoying when using the search bar. When the general documentation section in the sidebar is too long, searching has no visible effect because the search results are only visible after scrolling down.
Our situation can be seen here: https://www.weclapp.com/api/ (potentially with a custom JS workaround collapsing the entire overview section)

I have not seen activity on this project or on temporarily linked discord for a while, unfortunately there aren't alternate approvers for open source developers this contribute too.
 Would be great if @mrin9 can maybe accept donations and add active contributors - as the project still has one of the better interfaces around


Could I place exclude in .nycrc instead of package.json?

Currently, setting exclude in .nycrc takes no effect but setting it in package.json did.
My nyc version is: 8.3.1

Is this still an issue?
I probed it in a really small test case and couldn't verify the issue...
The project is here: https://github.com/rapzo/test-nyc
There are two tags: with-exclude and without-exclude and checking, for example, the html coverage there's the result of having debug.js with missing coverage (for the first case) and coverage hitting 100% when excluding the aforementioned file.
Am i missing something here?

After I upgrade to version 8.4.0, the issue seems......to remain.
I'm using babel-plugin-istanbul for ES6+ support. Here are my related configs:
.babelrc:
{
  "presets": ["es2015", "stage-3", "react"],
  "env": {
    "test": {
      "plugins": [
        "istanbul"
        ]
    }
  }
}

.nycrc
{
  "exclude": [
    "src/test/**/*.spec.js"
  ],
  "reporter": [
    "text",
    "html"
  ],
  "require": [
    "babel-register"
  ],
  "sourceMap": false,
  "instrument": false
}

And I test codes in this way:
NODE_ENV=test nyc mocha ./src/test/**/*.spec.js --recursive --reporter nyan

Thanks for that info @BurningLutz it really cleared the issue here.
Although, from a quick look at the code it looks like an issue in babel-plugin-istanbuland not in nyc.
Here: https://github.com/istanbuljs/babel-plugin-istanbul/blob/master/src/index.js#L26
It looks like it only parses configuration from package.json.
Meanwhile i'll try to write a patch to support .nycrc configuration but we need @bcoe's insight on this cause it may be not an issue at all but a design decision.

@rapzo @BurningLutz an oversight not a design decision; I would happily accept a patch adding .nycrc support to babel-plugin-istanbul.

Nice!
As i see it, do you have any preference on the parsing order? 1st .nycrc or
package.json, or the other way around? How about if there are both? Which
takes precedence?
On Wed, Nov 16, 2016 at 4:25 PM, Benjamin E. Coe<EMAIL_ADDRESS>wrote:

@rapzo https://github.com/rapzo @BurningLutz
https://github.com/BurningLutz an oversight not a design decision; I
would happily accept a patch adding .nycrc support to
babel-plugin-istanbul.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istanbuljs/nyc/issues/419#issuecomment-260993244, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJBTLgH7rrG_KW1WScYmdrZGFQErzQiks5q-y54gaJpZM4Kaxr1
.

--
Rui Pedro Lima

@rapzo let's just make sure that nyc and babel-plugin-istanbul are consistent; nyc currently uses yargs' config/pkg-config functionality to do it's thing:
https://github.com/istanbuljs/nyc/blob/master/lib/config-util.js#L14
We should probably do the same; there's been some discussion on yargs to change the order of application; And there might be some changes over the coming months, so best that we lean on yargs in my opinion, and let that project determine the most logical order of operation.

Great! Thanks! Will do my best.
On Wed, Nov 16, 2016 at 5:23 PM, Benjamin E. Coe<EMAIL_ADDRESS>wrote:

@rapzo https://github.com/rapzo let's just make sure that nyc and
babel-plugin-istanbul are consistent; nyc currently uses yargs'
config/pkg-config functionality to do it's thing:
https://github.com/istanbuljs/nyc/blob/master/lib/config-util.js#L14
We should probably do the same; there's been some discussion on yargs to
change the order of application; And there might be some changes over the
coming months, so best that we lean on yargs in my opinion, and let that
project determine the most logical order of operation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istanbuljs/nyc/issues/419#issuecomment-261011431, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJBTAEX8iAIBvPScy2r9w4caT8I9-rzks5q-zwEgaJpZM4Kaxr1
.

--
Rui Pedro Lima

@BurningLutz @rapzo could you give this a try:
npm cache clear; npm i babel-plugin-istanbul@next
The bug should be fixed thanks to @alpersogukpinar's hard work.

Uuuuuh interesting!
Will try it out today!
On Tue, Feb 7, 2017 at 5:08 AM, Benjamin E. Coe<EMAIL_ADDRESS>wrote:

@BurningLutz https://github.com/BurningLutz @rapzo
https://github.com/rapzo could you give this a try:
npm cache clear; npm i babel-plugin-istanbul@next
The bug should be fixed thanks to @alpersogukpinar
https://github.com/alpersogukpinar's hard work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istanbuljs/nyc/issues/419#issuecomment-277903101, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAJBTAtCUUq-TGjiz5pTIzgpmg6EJfSfks5rZ_w8gaJpZM4Kaxr1
.

--
Rui Pedro Lima

@bcoe @rapzo
It seems to work now :D. Thx!

Since the related issue istanbuljs/babel-plugin-istanbul#62 has been solved recently, I'm closing this now.

@BurningLutz awesome 👍


[Bug]: tcrw doesn't work out of the box on NixOS

Contact Details
No response
Describe the bug
When i run this command
./tcrw solo

I get theses errors
[TCR] Downloading tcr_0.25.0_Linux_x86_64.tar.gz
[TCR] Downloading v0.25.0.tar.gz
mv: cannot stat '/Kata-Slow-Code/tcr/tcr_go/download/tcr-0.25.0/doc': No such file or directory
/Kata-Slow-Code/javascript/../tcr/tcr_go/tcr_go.sh: line 235: /Kata-Slow-Code/tcr/tcr_go/bin/tcr_Linux_x86_64: No such file or directory

To Reproduce
Steps to reproduce the behavior:

Install NixOS OR start a NixOS container : docker run --interactive --tty --rm nixos/nix:2.15.1
"Install" git for the current shell : nix-shell --packages git
Clone the repo : git clone https://github.com/philou/Kata-Slow-Code
Go to this repo : cd Kata-Slow-Code/
Go to one language subfolder : cd ./javascript/
Make tcrw executable : chmod +x tcrw
Execute tcrw : ./tcrw solo
Watch the following error

[TCR] Downloading tcr_0.25.0_Linux_x86_64.tar.gz
[TCR] Downloading v0.25.0.tar.gz
mv: cannot stat '/Kata-Slow-Code/tcr/tcr_go/download/tcr-0.25.0/doc': No such file or directory
/Kata-Slow-Code/javascript/../tcr/tcr_go/tcr_go.sh: line 235: /Kata-Slow-Code/tcr/tcr_go/bin/tcr_Linux_x86_64: No such file or directory

Expected behavior
I expected to have one of this :

a binary compiled with all needed dependencies (without dynamic libraries)
a README that list which dynamic libraries should be installed
flake.nix that packages the binary with Nix (and can handle the development environment needed)

Working Environment

OS: NixOS 22.11.20230520.7dc71ae (Raccoon) x86_64
Version: tcr version 0.25.0

Additional Context
NixOS is a Linux distribution made to be highly reproducible : everything is declarative, versionnable
Others Linux distributions install specific version of libraries globally on specific paths

Binaries normally do not work out of the box when you download them because they normally just assume that libraries can be found in hardcoded paths such as /lib. However this assumption is incorrect on NixOS systems due to the inner workings of nix - there is no default path, everything gets set to the corresponding version on compile time.
https://nixos.wiki/wiki/FAQ#I.27ve_downloaded_a_binary.2C_but_I_can.27t_run_it.2C_what_can_I_do.3F

As a workaround, i can use steam-run
NIXPKGS_ALLOW_UNFREE=1 nix-shell --packages steam-run
steam-run ./tcrw solo

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hello @pinage404
Thank you for reporting this issue. We never tried TCR with NixOS before, so it's a nice opportunity for us to extend our list of supported platforms!
I've prepared a fix that I was able to run successfully in a replit.com nixos shell, but before merging the changes I would like to confirm with you that everything is fixed from your point of view, if you don't mind spending a bit of time testing it of course :)
Here's how you can test it (this is an update from the steps you provided above. Main changes are in step 5 and 7)

Install NixOS OR start a NixOS container : docker run --interactive --tty --rm nixos/nix:2.15.1

"Install" git for the current shell : nix-shell --packages git

Clone the repo : git clone https://github.com/philou/Kata-Slow-Code

Go to this repo : cd Kata-Slow-Code/

Checkout the branch containing the fix: git checkout origin/bugfix/nixos

Go to one language subfolder : cd ./javascript/

Check that tcr can be started: ./tcrw info

Expected outcome:

[TCR] Downloading tcr_0.25.2_Linux_x86_64.tar.gz
[TCR] Downloading v0.25.2.tar.gz
[TCR] Loading configuration: /home/runner/nix-and-tcr/Kata-Slow-Code/javascript/.tcr/config.yml
[TCR] Loading toolchains configuration
[TCR] Loading languages configuration
- Version:  0.25.2
- OS Family:    linux
- Architecture: amd64
- Commit:   76029b6588d54dea053b0a7014fed53930aebec9
- Build Date:   2023-05-30T15:36:39Z
- Built By: goreleaser

Thank you again. Let me know if anything is unclear or missing.

Yeah ! It works
./tcrw info
[TCR] Downloading tcr_0.25.2_Linux_x86_64.tar.gz
[TCR] Downloading v0.25.2.tar.gz
[TCR] Loading configuration: /Kata-Slow-Code/javascript/.tcr/config.yml
[TCR] Loading toolchains configuration
[TCR] Loading languages configuration
- Version:      0.25.2
- OS Family:    linux
- Architecture: amd64
- Commit:       76029b6588d54dea053b0a7014fed53930aebec9
- Build Date:   2023-05-30T15:36:39Z
- Built By:     goreleaser

./tcrw solo
[TCR] Loading configuration: /Kata-Slow-Code/javascript/.tcr/config.yml
[TCR] Loading toolchains configuration
[TCR] Loading languages configuration
[TCR] Starting TCR version 0.25.2...
[TCR] Base directory is /Kata-Slow-Code/javascript
[TCR] Work directory is /Kata-Slow-Code/javascript
[TCR] Test-breaking changes will not be committed
[TCR] ─────────────────────────────────────────────────────────────────────────
[TCR] Running in solo mode
[TCR] ─────────────────────────────────────────────────────────────────────────
[TCR] Base Directory: /Kata-Slow-Code/javascript
[TCR] Work Directory: /Kata-Slow-Code/javascript
[TCR] Language=javascript, Toolchain=yarn
[TCR] Running on git branch "HEAD" with auto-push disabled
[TCR] ─────────────────────────────────────────────────────────────────────────
[TCR] Starting with Driver role. Press ? for options
[TCR] Working locally on branch HEAD
[TCR] Going to sleep until something interesting happens
- watching /Kata-Slow-Code/javascript/src
- watching /Kata-Slow-Code/javascript/test

Thanks for the fast answer


strict liquidity components

@TvrtkoM the changes made to PoolSettings and PoolTable are critical for the market create page so please be carefull when merging them 🙏


Fix broken code sample

Fixes #1898

Hi @andrewlock, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;


Release: feature/powerPlatform

Release: feature/powerPlatform

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: aniruddha-k:white_check_mark: agnelpraveen:x: AluriAluri seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 643

Questions ?
Please refer to the Backport tool documentation


Link to docs on JSON.stringify.

@tunniclm Can you confirm that this is technically accurate?

@crandmck LGTM

Thanks @demoneaux


When a player joins, I want to see his name appearing and the number of free slots to decrease by one.

commit a2517ff


Remove duplicate code from other repos once contentFiles packages work in MSBuild

To unblock our upgrade to VS 2017, we had to copy *.cs code from this repo into the following to compensate for 'contentFiles' not working:

[x] aspnet/FileSystem - https://github.com/aspnet/FileSystem/pull/256
[x] aspnet/DotNetTools - https://github.com/aspnet/DotNetTools/pull/256
[x] aspnet/Scaffolding - https://github.com/aspnet/Scaffolding/pull/387
[x] aspnet/Razor https://github.com/aspnet/Razor/pull/943
[x] aspnet/Security - https://github.com/aspnet/Security/pull/1097

Delete once https://github.com/NuGet/Home/issues/3683 is resolved.

Done.


Query on Reproducing Code Reviewer "Review Comment Generation Task" Result

Hello! I am trying to reproduce the BLEU Score number that you mentioned in your CodeReviewer paper. The fine-tuning script you provided for the "review comment generation" downstream task, mentions the train steps to be 60,000. When applying the fine-tuned model to your own test dataset, I found the BLEU score to be 5.16, while the paper mentions it to be 5.32.

I used the exact same shell scripts that have been uploaded in this GitHub repository for CodeReviewer. My question is, what is the exact train steps count or train step checkpoint that you used to produce the score (5.32) mentioned in the paper? What might be the possible reasons for this mismatch?

Since the training process is not a definite process, the mismatch of 0.16 is acceptable. You can try to evaluate other checkpoints and might get one with a closer BLEU score.

Thanks!


API Key grants are not removed from Redis

If an API Key is modified and some of its grants removed, this will not be reflected in Redis, because we use HMSET to update the Redis keys (HMSET set the specified fields, any other fields present are left untouched).
We should remove (HDEL) fields not present in the new grants (we could do this by either looking an the record changes or at the Redis hash value.

I think this could be a fix for this: it sets the removed api grants to false:
diff --git a/app/models/carto/api_key.rb b/app/models/carto/api_key.rb
index 3b0566358c..02be25a153 100644
--- a/app/models/carto/api_key.rb
+++ b/app/models/carto/api_key.rb
@@ -503,9 +503,19 @@ module Carto
       @user_db_connection ||= user.in_database
     end

+    def removed_granted_apis
+      if changes[:grants]
+        old_apis, new_apis = changes[:grants].map { |g| g.find { |v| v[:type] == 'apis' }[:apis] }
+        old_apis - new_apis
+      else
+        []
+      end
+    end
+
     def redis_hash_as_array
       hash = ['user', user.username, 'type', type, 'database_role', db_role, 'database_password', db_password]
       granted_apis.each { |api| hash += ["grants_#{api}", true] }
+      removed_granted_apis.each { |api| hash += ["grants_#{api}", false] }
       hash
     end


Redis cluster with recent Laravel and phpredis throws various errors with TLS connection.

Hi there,
I'm reporting a bug and a fix in Redis cluster configuration handling, given recent php Redis no longer expects requirepass as it's deprecated, but expects the auth with user and password in the 6th parameter of RedisCluster as well as context with array of stream keyed array member for Client and CA certificates files location variable, that is in order to establish successful TLS connection with REDIS cluster nodes having tls-auth-clients set to yes in cluster nodes configs.

Laravel Version: 9.2
PHP Version: 8.1.3
Database Driver & Version: Redis, phpredis 6.0.0-dev.

Description:
I can't get REDIS cluster to work, when I configure Laravel to use phpredis 6.0.0-dev cluster in database.php with TLS scheme and client certificate authentication enabled, it throws " Connection lost at PhpRedisConnector.php:192 " as well as "AUTH failed while reconnecting at PhpRedisConnector.php:189 " after " Couldn't map cluster keyspace using any provided seed " and with some debugging it returns this error
(ErrorException(code: 0): RedisCluster::__construct(): SSL operation failed with code 1. OpenSSL Error messages:
error:0A00045C:SSL routines::tlsv13 alert certificate required

and in Redis logs returns:-
Error accepting a client connection: error:0A0000C7:SSL routines::peer did not return a certificate
Steps To Reproduce:
-1 Configure Laravel to use redis cluster with phpredis 6.0.0-dev and TLS scheme with client certificates auth enabled and open Laravel public directory in browser or run php artisan cache:clear.
Additional Information
This is how I fixed it
Modify createRedisClusterInstance in laravel/framework/src/Illuminate/Redis/Connectors/PhpRedisConnector.php:190 with following:-

        if (version_compare(phpversion('redis'), '4.3.0', '>=') && version_compare(phpversion('redis'), '6.0.0-dev', '<')) {
            $parameters[] = $options['password'] ?? null;
        }

        if (version_compare(phpversion('redis'), '5.3.2', '>=') && !is_null($context = Arr::get($options, 'context'))) {
            $parameters['auth'] = $context['auth'];
            $parameters['context'] = $context['stream'];
        }

Good luck.
Zakaria.

Changing the API to work with phpredis 6.0.0-dev is risky, it may change during the development.
Does it work with PhpRedis 5.3.7?

I haven't tested phpredis 5.3.7. I think it will return the same results using phpredis 6.0.0 that is similar to dev, i.e. an invitable bug that has to be fixed since password meant to work with the deprecated requirepass and flattening of options in parameters array removes auth keys i.e. password and username which is optional yet if had any including itself which is required as well as context and stream in order for at least phpredis 6.0.0 to pick the authentication certificate and pass it to redis successfully otherwise SSL failure errors will be thrown, Please correct me if my findings are incorrect.
Zakaria.

Can you reproduce this with a 2-3 line non-Laravel script?
If this a bug in PhpRedis we need to report it.

Can you reproduce this with a 2-3 line non-Laravel script?
If this a bug in PhpRedis we need to report it.

No its not phpredis extension and it works fine but its Laravel API integration and its incompatible with phpredis 6.0.0.
I am certain in incoming releases the issue will appear to more users therefore addressing it now, should be a good idea, its easy to install the recent phpredis extension locally and test by yourself. Configure the redis cluster nodes with auth client enabled, and pass cafile, local pk and cert file and you will see the errors in logs file leading to internal server error.
Also, make sure to set redis driver for sessions and cache in env.

I can't reproduce this without a code sample.


Normalize dictionary values

Fix scales on Universe Machine
Add notice of scaling to copy on each catalog page.
Add choice of native units v normalized units on download as well?

Sent current dictionary to rachel for review.


after br restore, there's no version in show hosts

steps:

one host with 3 metad, 3 storaged and 3 graphd.
backup
restore
query show hosts graph

VerifyClientVersionProcessor would write key when metaclient runs verifyVersion()
a little confused


Feature/subscription checking

What?
Added ability of subscription checking. #16
Why?
If a user is in subscribed mode(managed from the backend) he is able to watch a performer's video, else he will see the modal screen with directions to get the subscription.
How?
added method subscriptionInfo for understanding if a user is subscribed or not. While
this method will be improved on the backend side,  changing subscription mode can manage manually in the settings menu of the app.
How to test
in the settings section of the nav menu, we can change the subscribed mode of the user account(from subscribed to non-subscribed and vice-versa). we can see the performer's video if we are in subscribed mode and modal screen with some instructions to get subscribing if we are in non-subscribed mode.

This works well on Android! One thought: When navigating to 'Account & Settings', the default focus is on 'Sign Out'. I think it should default to the top item - 'Subscription'. Unfortunately unable to test on tvOS, due to menu issues.


After each mount, run the equivalent of multipath -r

Or actually exec out and run it.

Will not fix - see #103 (Equinix Metal Block Storage from Datera is EOL).


Powershell comander

Powershell commands are not working why?
some powershell commands not working cmd commands operators working

you mean remote shell？it only support cmd now
---Original---
From: @.>
Date: Wed, Aug 4, 2021 20:19 PM
To: @.>;
Cc: @.***>;
Subject: [qwqdanchun/DcRat] Powershell comander (#45)
Powershell commands are not working why?
some powershell commands not working cmd commands operators working
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

What advantage does the certificate give me?

to authentication
---Original---
From: @.>
Date: Thu, Aug 5, 2021 07:25 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [qwqdanchun/DcRat] Powershell comander (#45)
What advantage does the certificate give me?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

can we use command line as administrator,
in the background

yes
---Original---
From: @.>
Date: Thu, Aug 5, 2021 18:00 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [qwqdanchun/DcRat] Powershell comander (#45)
can we use command line as administrator,
in the background
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.


Database Testing –To test the inventory DB, and to convince the executives in the company to continue investing in technology, there should be a way to simulate the inventory DB being updated through customer/buyer events (products being removed and/or quantities being decreased). [See the files named customer_orders_teamX.csv]

This issue has been resolved in sprint 3.


Running extensions editor is not dimmed

Also not a webview I think:

Merging into https://github.com/microsoft/vscode/issues/236576
/duplicate


Remove ":" from "Add subscription to dashboard:" button

Hi! I want to make my first contribution to an open-source. Can I take this up?


Remove version: FileVoyager.FileVoyager version <IP_ADDRESS>

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://www.filevoyager.com/wp-content/uploads/FileVoyager_Setup_<IP_ADDRESS>_NoVLC.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 899)


3.1.2 quote

Hi,
I had an error stating that BCU cannot communicate with the BIOS when getting UUID.
The "error" was on line 422. I deleted the single quote and left only double quotes.
$output=&BCU_EXE /GetValue:"$Name" | Out-String
With this correction it works now fine.
Let me know if u want more infos and thanks for your Work

Thanks for the effor @krevard, but actually that are back ticks to prevent PowerShell from trying to escape the parameter (see this question on SO).
They are there because some BIOS settings are not correctly escaped without them. I can't remember which ones that were, but without the back ticks it didn't worked. The problem with the script not recognizing the device should be fixed with the next release, it will also then test SERIAL NUMBER (see #16).
The script directly in this repo already has this fix, but for a full release it might take until this weekend.

Hi,
Thanks for your answer. For now I tested only an HP 840 G3.
I tested the command manually and the quote were needed (wihout them I have the same error manually or by your script)
BiosConfigUtility64.exe /getValue:"Universally Unique Identifier (UUID)"
I will test on other models as soon as the script work for this one.
My goal is to put your script in SCCM 2012.
Thanks.

@krevard: I just released v3.2.4. In this version the script will try UUID first and if this comes up empty, I use the value SERIAL NUMBER for testing. Works on the two or three devices that show the UUID defect so I hope it will also work for you (fingers crossed ;-).
Please let me know if this works for you.

Hi,
It works a lot better now :-) thx
I have others "issues" as I m testing deeper. But I think I will open  other issues if u want.
The problem is th HP TPM updater cannot run in Winpe as stated in https://support.hp.com/lv-en/document/c05381064. When I use it true your script the following error is raised:
HPTPMFWUpdate Return Code = 262
The other thing is that I have a winpe 64 bit image and the Intel Me firmware update is a 32 application. Winpe does not have the wow64....
So I will have some Work to make it work with my SCCM task sequence.
Thanks for your help

Good to hear, and regarding the TPM update and WinPE:

The utility can only be run in Windows 7, Windows 8.x, or Windows 10. It does not support Windows PE.

So the error message is "OK", since the tool is run on an unsupported platform. Or I have totally misunderstood you that you wanted it to run in WinPE.

Yes it s ok to have an error message since it s not supported by HP in Winpe.
I will have to run it after the OS is installed. So I think I will have to split your script to run some parts in Winpe and some after the OS is installed.
The point is that your script "cannot work" as is in sccm or MDT in a staging phase. This due to HP application limitations. I wanted to let you know that.

Thanks, now I think I understood what the problem was. I will add the following sentence to the System Requirements:

Due to restrictions in several HP tools, it can NOT be run in Windows Preinstallation Environment (WinPE)

Does this make sense to you?
Also, which parts of it would you still want to run in PE/staging phase and why? This is just out of my curiosity.

Yes it makes sense.
The intel console tool doesn't work in winpe 64 (but should work in Winpe 32)
And the tpm update is not supported by HP in winpe. But as we see it can work :-)
So in Winpe (64) I'll run the config and update BIOS.
After the apply OS (SCCM Task sequence) I will try to update the TPM.
For the Intel AMT Firmware i already have a mechanism through SCCM applications that I add to my task sequence.
Thanks for your support.

@krevard There were no updates on this for a long time and it seems to be working for you. Can we close this issue?

@krevard Closing this issue now, please feel to reopen it if you think this is incorrect.


Quiz game

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #2439

Mark the task you have completed ✅

[ x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x ] I have performed a self-review of my own code or work.
[ x] I have commented my code, particularly in hard-to-understand areas.
[ x] My changes generates no new warnings.
[ x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x ] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x ] I have added README.md in my folder
[] I have added working video of the game in README.md (optional)
[ x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @sabeenaviklar ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

okay @kunjgit . I have made the required changes.

Kindly review it and merge the pull request  @kunjgit @gurjeetsinghvirdee

Thank you  @sabeenaviklar , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


Issues with LSP code actions + null-ls

Hello! Thanks for the great plugin – it's great to have fzf + Lua with sensible out-of-the-box functionality and easy configuration.
I'm the author of null-ls.nvim, which (among other things) allows injecting code actions from within Neovim. To correctly generate actions, null-ls relies on checking the filetype of the current buffer at the time the request is sent, but due to how fzf-lua is structured, the request is sent from within an fzf buffer, so the check fails. (For reference, everything works as expected with Telescope and lspfuzzy).
This isn't an issue with actual language servers, but both lspfuzzy and Telescope support null-ls code actions, so I wonder if it's possible to support them here, too. One option is to use buf_request_sync to get code actions before opening the picker, which is what Telescope does. Another advantage of this approach is that we'd know whether code actions are available before opening fzf, which would avoid the current flickering effect when calling :FzfLua lsp_code_actions when no code actions are available. (Using buf_request_sync for other LSP requests would solve this issue elsewhere, too.)
Let me know what you think and if there's anything I can do to help.

Hi and ty for letting me know.
Going with the LSP async functions was a design choice, I have no control over the LSP’s and they don’t always respond immediately (especially on larger requests such as workspace symbols), that can hang the UI and is the main reason I went with async everywhere.
That said, changing code action only to buf_request_sync shouldn’t be a big deal since the replies are always small, I’ll make the change later today.
For the record Telescope works differently, it runs only blocking LSP requests which isn’t optimal IMO, lspfuzzy is different as it replaces the default handlers which another option I opted against as I like to give the users an option to use the default actions should they choose (send to quick list, etc).

I added the option to enable blocking LSP calls (i.e. use buf_reqest_sync) in all LSP providers, you can enable that globally by setting async_or_timeout option during setup() (the below sets the timeout to 3 seconds):
require'fzf-lua'.setup {
lsp = {
    async_or_timeout  = 3000,       -- set to timeout|false for blocking calls
  }
}

Or use the same option to set it individually each call (or keybind mapping):
:lua require('fzf-lua').lsp_definitions({ async_or_timeout = 5000 })

Alternatively you can just send sync = true, async = false or async_or_timeout = false to use the default timeout = 5000:
:lua require('fzf-lua').lsp_code_actions({ async = false })

If this solves your problem feel free to close the issue.

Works perfectly, thank you! I really appreciate having the option to make all LSP requests synchronous.

Works perfectly, thank you! I really appreciate having the option to make all LSP requests synchronous.

Very happy this worked out, cheers :)


CIV-5784 Refactor Search service classes into one

Before creating a pull request make sure that:

[x] commit messages are meaningful and follow good commit message guidelines
[x] README and other documentation has been updated / added (if needed)
[x] tests have been updated / new tests has been added (if needed)
[x] Screenshot attached for the Evidence of manual testing
[x] Functional, Smoke and API tests have been run locally
[x] Full gradle build and run tests with coverage have been completed (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-5784
Change description
Combine the following search service classes into one
AwaitingResponseStatusSearchService
DirectionOrderSearchService
RequestForInformationrSearchService
WrittenRepresentationSearchService
OrderMadeSearchService
Testing branch and instruction
CIV-5784
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Test Evidence.docx

Test Evidence.docx


GLXOSD will freeze game if I press a Shortcut key on my Roccat Kova[+]

Yeah, sounds pretty far fetched but that is literally what happens.
Example/Steps to reproduce:
Run Dead Island Definitive Edition running with GLXOSD while having the Roccat Tools for Linux installed. Set a shortcut key to the mouse then attempt to use it in-game.
I have the right-back thumb button on the Kova[+] set as a shortcut to the F key. If I push it or any of the other thumb button shortcuts, the game will freeze and I'll have to kill it.
The freeze doesn't happen and everything works as expected if I'm not using GLXOSD.
I'm using Ubuntu MATE 16.04.1, GLXOSD was installed from the PPA, the Roccat Tools were also installed from their own PPA. Everything is up-to-date at the time of writing.
CPU: AMD FX8370E 4.2GHz
RAM: 16GB
GPU: Gigabyte GeForce GTX 1080 G1
Driver: Proprietary 367.36.02

A bit of extra info:
Roccat Tools use the roccateventhandler as the input handler for shortcut keys. Maybe blacklisting that in GLXOSD's input listening bit would help?

Unfortunately, since I don't have any Roccat equipment, it will be hard for me to fix this bug as I won't be able to test the fix. Could you please provide the output of xev when pressing these buttons?

Here you go, I included all of the offending ones:
`KeyPress event, serial 39, synthetic NO, window 0x4400001,
root 0x1e7, subw 0x4400002, time 35639562, (55,38), root:(93,684),
state 0x10, keycode 26 (keysym 0x65, e), same_screen YES,
XLookupString gives 1 bytes: (65) "e"
XmbLookupString gives 1 bytes: (65) "e"
XFilterEvent returns: False
KeyRelease event, serial 39, synthetic NO, window 0x4400001,
root 0x1e7, subw 0x4400002, time 35639655, (55,38), root:(93,684),
state 0x10, keycode 26 (keysym 0x65, e), same_screen YES,
XLookupString gives 1 bytes: (65) "e"
XFilterEvent returns: False
KeyPress event, serial 39, synthetic NO, window 0x4400001,
root 0x1e7, subw 0x4400002, time 35640150, (55,38), root:(93,684),
state 0x10, keycode 41 (keysym 0x66, f), same_screen YES,
XLookupString gives 1 bytes: (66) "f"
XmbLookupString gives 1 bytes: (66) "f"
XFilterEvent returns: False
KeyRelease event, serial 39, synthetic NO, window 0x4400001,
root 0x1e7, subw 0x4400002, time 35640264, (55,38), root:(93,684),
state 0x10, keycode 41 (keysym 0x66, f), same_screen YES,
XLookupString gives 1 bytes: (66) "f"
XFilterEvent returns: False
KeyPress event, serial 39, synthetic NO, window 0x4400001,
root 0x1e7, subw 0x4400002, time 35641109, (55,38), root:(93,684),
state 0x10, keycode 27 (keysym 0x72, r), same_screen YES,
XLookupString gives 1 bytes: (72) "r"
XmbLookupString gives 1 bytes: (72) "r"
XFilterEvent returns: False
KeyRelease event, serial 39, synthetic NO, window 0x4400001,
root 0x1e7, subw 0x4400002, time 35641310, (55,38), root:(93,684),
state 0x10, keycode 27 (keysym 0x72, r), same_screen YES,
XLookupString gives 1 bytes: (72) "r"
XFilterEvent returns: False
KeyPress event, serial 39, synthetic NO, window 0x4400001,
root 0x1e7, subw 0x4400002, time 35642015, (55,38), root:(93,684),
state 0x10, keycode 24 (keysym 0x71, q), same_screen YES,
XLookupString gives 1 bytes: (71) "q"
XmbLookupString gives 1 bytes: (71) "q"
XFilterEvent returns: False
KeyRelease event, serial 39, synthetic NO, window 0x4400001,
root 0x1e7, subw 0x4400002, time 35642196, (55,38), root:(93,684),
state 0x10, keycode 24 (keysym 0x71, q), same_screen YES,
XLookupString gives 1 bytes: (71) "q"
XFilterEvent returns: False
`


[pyarrow strings] string[pyarrow] should not be used as one of MultiIndex dtypes

Describe the issue:
Follow-up for https://github.com/dask/dask/pull/10000.
These tests failed with pyarrow strings and were xfailed, but we still need a fix:
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_dropna_with_agg[disk-True] - AssertionError: MultiIndex level [0] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_dropna_with_agg[disk-False] - AssertionError: MultiIndex level [0] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_dropna_with_agg[tasks-True] - AssertionError: MultiIndex level [0] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_dropna_with_agg[tasks-False] - AssertionError: MultiIndex level [0] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_sort_argument[disk-True-count-by4] - AssertionError: MultiIndex level [1] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_sort_argument[disk-False-count-by4] - AssertionError: MultiIndex level [1] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_sort_argument[tasks-True-count-by4] - AssertionError: MultiIndex level [1] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_sort_argument[tasks-False-count-by4] - AssertionError: MultiIndex level [1] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_slice_getitem[disk-3-by0] - AssertionError: MultiIndex level [0] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_slice_getitem[tasks-3-by0] - AssertionError: MultiIndex level [0] are different
FAILED dask/dataframe/tests/test_rolling.py::test_groupby_rolling - AssertionError: MultiIndex level [0] are different

It looks like when we're grouping on multiple columns in Dask, the resulting MultiIndex inherits the string[pyarrow] dtype from its parent columns. We shouldn't use this dtype in MultiIndex yet.
Environment:

Dask version:
Python version:
Operating System:
Install method (conda, pip, source):

Already fixed:
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_multiprocessing[disk] - AssertionError: MultiIndex level [0] are different
FAILED dask/dataframe/tests/test_groupby.py::test_groupby_multiprocessing[tasks] - AssertionError: MultiIndex level [0] are different

There are two different ways we could fix this:

Not usestring[pyarrow] dtype in MultiIndex yet.
Consistently use string[pyarrow] dtype in MultiIndex.

Right now there's an inconsistency: we don't convert MultiIndex in Frame constructor, so initially MultiIndex with have object in dtypes. But when we're grouping on string[pyarrow] columns, the resulting MultiIndex will have string[pyarrow] dtypes.
Question is, which way do we want to go? I'm leaning towards the 2nd.

Yeah, I think we will ultimately want option (2). I initially punted on MultiIndex support for dataframe.convert_string, but always intended to circle back and make sure we convert text dypes in MultiIndex appropriately.

Closed via https://github.com/dask/dask/pull/10040.


Added ZoomMeetingsEnabled to xml-config-file.md

Closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/6648.

Added WebExMeetingsEnabled based on the following article:
https://docs.microsoft.com/microsoftteams/rooms/third-party-join#use-the-skypesettingsxml-configuration-file
@dstrome @sohailta, could you kindly help with "Leave meetings automatically if everyone else has left"? I couldn't find information about it in the XML.
Thanks!

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@dstrome PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


x/crypto: terminal using syscall.TCGETS (wrong for ppc64le)

Please answer these questions before submitting your issue. Thanks!

This surfaced via logrus with https://github.com/sirupsen/logrus/pull/604
I hit this when revendoring logrus into moby/moby. I don't have a reproducer but it's a known issue that syscall.TCGETS and syscall.TCSETS are incorrect for ppc64le. I've been slowly trying to move projects over to use x/sys/.
I have a hacky test fix here: https://github.com/moby/moby/pull/34332. Specifically, the windows bits were tricky (for me) to test because I don't have easy access to Windows.
When I have more time I can upstream the go bits unless someone else can get to it first.

At crypto's master I see:
$ git grep TCGETS
ssh/terminal/util_linux.go:const ioctlReadTermios = 0x5401  // syscall.TCGETS
ssh/terminal/util_solaris.go:   val, err := unix.IoctlGetTermios(fd, unix.TCGETS)
ssh/terminal/util_solaris.go:   oldTermiosPtr, err := unix.IoctlGetTermios(fd, unix.TCGETS)
ssh/terminal/util_solaris.go:   oldTermiosPtr, err := unix.IoctlGetTermios(fd, unix.TCGETS)

It looks like util_linux.go uses a hard-coded value. I guess that's wrong on ppc64le?
$ git grep -E '\bTCGETS\b'
zerrors_linux_386.go:   TCGETS                               = 0x5401
zerrors_linux_amd64.go: TCGETS                               = 0x5401
zerrors_linux_arm.go:   TCGETS                               = 0x5401
zerrors_linux_arm64.go: TCGETS                               = 0x5401
zerrors_linux_mips.go:  TCGETS                               = 0x540d
zerrors_linux_mips64.go:        TCGETS                               = 0x540d
zerrors_linux_mips64le.go:      TCGETS                               = 0x540d
zerrors_linux_mipsle.go:        TCGETS                               = 0x540d
zerrors_linux_ppc64.go: TCGETS                               = 0x402c7413
zerrors_linux_ppc64le.go:       TCGETS                               = 0x402c7413
zerrors_linux_s390x.go: TCGETS                               = 0x5401
zerrors_linux_sparc64.go:       TCGETS                           = 0x40245408
zerrors_solaris_amd64.go:       TCGETS                        = 0x540d

Oh, yup.
That's easy. CL on its way.
/cc @tklauser

Should be fixed by https://golang.org/cl/51690 (commit 558b6879de74bc843225cde5686419267ff707ca) already.

@tklauser, hah. Whoops.
And now I see Gerrit said for mine:

Marking change merged without cherry-picking to branch, as the resulting commit would be empty.

I guess I hadn't synced either when I sent my change. Whoops.


Add test script for BGV_country_deb_lookup example

#18

@rosielickorish I think you just need to sign your commit for this to be able to be merged :) Did you setup the PGP stuff?

@faberga Any idea why the signing doesn't seem to have worked here of if we missed a step?

@rosielickorish did you use commit -S ?
If so, did you get any error message ?

User error, I'd not signed the commit using git commit -s.  New PR rasied #20 with the exactly the same code but with signed commits. Closing this PR.


Resolve how to account for ICE, DHS, Fed prisons, Mariana

The prison, ICE, DHS, similar data was a one-time update from BNO, CSSE, and other data sources.  The updates were small and represent less than 0.1% of the total reported cases.  This won't be implemented.


Issue with Kitty in fzf highlighted line

Info

Operating System: macOS
Shell: Zsh
Terminal: Kitty
nvim --version: 0.7.0
fzf --version: 0.27.3

Description
I'm having this issue in my Kitty terminal (not in Alacritty or iTerm). There is a cursor border in between the icon and the file name (i.e., whenever there is a space in the highlighted line). I tried figuring this out in my kitty config but didn't find a culprit. Perhaps someone can shed some light on why this is showing.
.
Thanks in advance!

It might be either the icon padding (kitty supports double width icons) or your font’s support for the nbsp character, can you try adding either of the below to your setup function and lmk which solves it?

from the README:

  -- uncomment if your terminal/font does not support unicode character
  -- 'EN SPACE' (U+2002), the below sets it to 'NBSP' (U+00A0) instead
  nbsp = '\xc2\xa0',

  -- double-width icon rendering
  file_icon_padding = ' ',

Thanks for such quick reply.... nbsp = '\xc2\xa0 did the trick 🙏🏻. I didn't see this in the README, sorry about that. file_icon_padding = ' ' helps in rendering the icons in Kitty a bit better, but does not solve the issue. I really like Kitty but its issues with rendering some fonts makes me go back to Alacritty or iTerm (although those have other issues as well).
Thanks again!

Thanks for such quick reply.... nbsp = '\xc2\xa0 did the trick 🙏🏻. I didn't see this in the README, sorry about that. file_icon_padding = ' ' helps in rendering the icons in Kitty a bit better, but does not solve the issue. I really like Kitty but its issues with rendering some fonts makes me go back to Alacritty or iTerm (although those have other issues as well).
Thanks again!

The icons come from nvim-web-devicons, if you still wish to use kitty you can always override the problematic icons in devicon’s setup function, for example:
require("nvim-web-devicons").setup({
  override = {
    sol = {
      icon = "♦",
      color = "#a074c4",
      name = "Sol"
    }
  };
})


RDBES: RS_SamplingSchemeType update of codes

Please see attached spreadsheet for the 3 code updates.
RS_SamplingSchemeType updates.xlsx

This have been requested in issue #102, so ignore it.


Getting count of related_ids

I'm trying to retrieve the count of related ids within a document. The ids are stored like this:
expedition_ids : [1,2,3]
I'm using a raw query off the relationship in my Expedition model:
public function subjectsCountRelation ()
{
        return $this->belongsToMany('Subject')
	        ->selectRaw('count(expedition_ids) as count(*)')
	        ->groupBy('expedition_ids');
}

public function getSubjectsCountAttribute ()
{
        return $this->subjectsCountRelation->first() ? $this->subjectsCountRelation->first()->count : 0;
}

It builds a query like this but returns nothing:
subjects.aggregate([{"$match":{"expedition_ids":{"$in":["1","2","3"]}}},{"$group":{"_id":{"expedition_ids":"$expedition_ids"},"expedition_ids":{"$last":"$expedition_ids"},"count(expedition_ids) as count(*)":{"$last":"$count(expedition_ids) as count(*)"}}}])

Due to the database seeding, I know I have 3 Expeditions with 100 Subjects in each. So I know they exist. Obviously the query is not right. So what would be the correct way of writing the query?

Essentially you are trying to get multiple row aggregate.  Eloquent doesn't seem to have an eloquent way to do.  This StackOverflow http://stackoverflow.com/questions/16764346/getting-daily-aggregates-sum-sorted-by-day-in-laravel answer uses the techniques I would suggest, i.e. select(DB:raw(...))and lists().
In your case you'll need to do something to the effect of:
<?php
public function subjectsCountRelation ()
{
    $query = $this->belongsToMany('Subject')->groupBy('expedition_ids');
    $query->getQuery()->aggregate = [ 'function' => 'count', 'columns' => [ 'id' ] ];
    return $query->get();
}

Essentially this is what the Illuminate\Database\Query\Builder::aggregate() does just skips the return $results[0]; step.


connection-failure not being retried

Title: connection-failure not being retried
Description:
When retrying on connection failure all requests having a body bigger that the connection buffer limit will not being retried.
Give the configuration bellow all requests bigger than 32768 bytes will not be retried. If not overridden per route it will come from the listener config per_connection_buffer_limit_bytes and default to 1MiB
The following happens:

the router receive the body and proxy it to the upstream requests
the buffer limit get reached at the router level
the router give up on retry but keep on forwarding to the upstream requests
the buffer of the upstream connection will get full and notify to stop readying on the downstream connection.

If the upstream requests fail the requests will not be retried.
Proposed solution:
The router can a callback for when the upstream connection get a connection via the addUpstreamCallbacks.
If the router buffer get full before any upstream connection got establish keep on buffering an stop on reading on the downstream (onDecoderFilterAboveWriteBufferHighWatermark). This allows to keep on retrying.
Once it get a new connection enable read from downstream and drop retry, shadow, and buffering.
For all other retry the behaviour is unchanged
Example:
config:
static_resources:
  listeners:
  - name: test_connect_failure
    address:
      socket_address:
        protocol: TCP
        address: <IP_ADDRESS>
        port_value: 8100
    per_connection_buffer_limit_bytes: 32768
    filter_chains:
    - filters:
      - name: envoy.filters.network.http_connection_manager
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
          codec_type: AUTO
          stat_prefix: web1
          route_config:
            virtual_hosts:
            - name: backend
              domains:
              - "*"
              routes:
              - match:
                  prefix: "/"
                route:
                  cluster: local_service_fail
                  timeout: 0s
                  retry_policy:
                    retry_on: "connect-failure"
                    num_retries: 3
                    retry_back_off:
                      base_interval: 0.050s
          http_filters:
          - name: envoy.filters.http.router
            typed_config:
              "@type": type.googleapis.com/envoy.extensions.filters.http.router.v3.Router
  clusters:
  - name: local_service_fail
    connect_timeout: 1s
    type: STRICT_DNS
    lb_policy: ROUND_ROBIN
    upstream_connection_options:
      tcp_keepalive:
        keepalive_time: 300
    common_lb_config:
      healthy_panic_threshold:
        value: 40
    load_assignment:
      cluster_name: local_service
      endpoints:
      - lb_endpoints:
        - endpoint:
            address:
              socket_address:
                address: <IP_ADDRESS>
                # port doesn't match anything
                port_value: 8085

with Envoy docker image: "envoyproxy/envoy:v1.29.0":
only relevant logs:
[2024-02-13 09:25:46.619][21][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"0"] current connecting state: false
[2024-02-13 09:25:46.619][21][debug][router] [source/common/router/router.cc:514] [Tags: "ConnectionId":"0","StreamId":"742379432996652670"] cluster 'local_service_fail' match for URL '/'
[2024-02-13 09:25:46.619][21][debug][router] [source/common/router/router.cc:731] [Tags: "ConnectionId":"0","StreamId":"742379432996652670"] router decoding headers:
':authority', 'localhost:8100'
':path', '/error'
':method', 'POST'
':scheme', 'http'
'user-agent', 'Go-http-client/1.1'
'content-length', '92768'
'accept-encoding', 'gzip'
'x-forwarded-proto', 'http'
'x-request-id', '00db4f6a-b6cb-4fe3-b4d4-34bad1e002f2'

[2024-02-13 09:25:46.619][21][debug][connection] [./source/common/network/connection_impl.h:98] [Tags: "ConnectionId":"1"] current connecting state: true
[2024-02-13 09:25:46.619][21][debug][connection] [source/common/network/connection_impl.cc:1009] [Tags: "ConnectionId":"1"] connecting to <IP_ADDRESS>:8085
[2024-02-13 09:25:46.619][21][debug][connection] [source/common/network/connection_impl.cc:1028] [Tags: "ConnectionId":"1"] connection in progress
[2024-02-13 09:25:46.619][21][trace][connection] [source/common/network/connection_impl.cc:654] [Tags: "ConnectionId":"0"] read ready. dispatch_buffered_data=0
[2024-02-13 09:25:46.619][21][trace][connection] [source/common/network/raw_buffer_socket.cc:25] [Tags: "ConnectionId":"0"] read returns: 32768
[2024-02-13 09:25:46.619][21][debug][router] [source/common/router/router.cc:856] The request payload has at least 65412 bytes data which exceeds buffer limit 32768. Give up on the retry/shadow.
[2024-02-13 09:25:46.619][21][debug][http] [source/common/http/filter_manager.cc:541] [Tags: "ConnectionId":"0","StreamId":"742379432996652670"] request data too large watermark exceeded
[2024-02-13 09:25:46.619][21][debug][http] [source/common/http/conn_manager_impl.cc:1922] [Tags: "ConnectionId":"0","StreamId":"742379432996652670"] Read-disabling downstream stream due to filter callbacks.
[2024-02-13 09:25:46.619][21][trace][connection] [source/common/network/connection_impl.cc:401] [Tags: "ConnectionId":"0"] readDisable: disable=true disable_count=0 state=0 buffer_length=0
[2024-02-13 09:25:46.619][21][debug][connection] [source/common/network/connection_impl.cc:757] [Tags: "ConnectionId":"1"] delayed connect error: 111
[2024-02-13 09:25:46.619][21][debug][connection] [source/common/network/connection_impl.cc:278] [Tags: "ConnectionId":"1"] closing socket: 0
[2024-02-13 09:25:46.619][21][trace][connection] [source/common/network/connection_impl.cc:469] [Tags: "ConnectionId":"1"] raising connection event 0
[2024-02-13 09:25:46.619][21][debug][router] [source/common/router/router.cc:1331] [Tags: "ConnectionId":"0","StreamId":"742379432996652670"] upstream reset: reset reason: remote connection failure, transport failure reason: delayed connect error: 111
[2024-02-13 09:25:46.619][21][debug][http] [source/common/http/conn_manager_impl.cc:1912] [Tags: "ConnectionId":"0","StreamId":"742379432996652670"] Read-enabling downstream stream due to filter callbacks.
[2024-02-13 09:25:46.619][21][trace][connection] [source/common/network/connection_impl.cc:401] [Tags: "ConnectionId":"0"] readDisable: disable=false disable_count=1 state=0 buffer_length=0
[2024-02-13 09:25:46.619][21][debug][http] [source/common/http/filter_manager.cc:1065] [Tags: "ConnectionId":"0","StreamId":"742379432996652670"] Sending local reply with details upstream_reset_before_response_started{remote_connection_failure,delayed_connect_error:_111}
[2024-02-13 09:25:46.619][21][debug][http] [source/common/http/conn_manager_impl.cc:1869] [Tags: "ConnectionId":"0","StreamId":"742379432996652670"] encoding headers via codec (end_stream=false):
':status', '503'
'content-length', '152'
'content-type', 'text/plain'
'date', 'Tue, 13 Feb 2024 09:25:46 GMT'
'server', 'envoy'
'connection', 'close'

I have a draft PR that I tested with a build from a different forks

I opened the PR for review: https://github.com/envoyproxy/envoy/pull/32359

@alyssawilk @yanavlasov


Feature request: text/css magic bytes detection for net/http

This may be a non-starter as CSS may not have enough useful "magic bytes", but in net/http we can only detect CSS files based on extension and not the file's contents.
In my (unusual) case, I have the files stores as hex hashes with no extensions and am relying on the magic byte detection.
Maybe there's a way to do this, so I thought I'd open this up and get it out there.
This is applicable to Go 1.12 and I imagine earlier.

As far as I am aware, there is no way to do this because css is just a text file.
In any case, for MIME sniffing, we follow the https://mimesniff.spec.whatwg.org/ spec. So if there is at all a way, it has to be published there first. I would request you to file an issue at https://github.com/whatwg/mimesniff/ if you want something like this to be investigated.
I will go ahead and close this since there is nothing for us to do here. If the mimesniff spec is updated, then we can go ahead and add whatever new logic is required.

Gotcha, thank you! That sounds good.


Component gets mounted twice

Description
I have a class based react component. When I call setState inside componentDidMount I'm getting this message:
Warning: Can only update a mounted or mounting component. This usually means you called setState, replaceState, or forceUpdate on an unmounted component. This is a no-op.

The function that I'm trying to execute inside componentDidMount is a combination of setState, setInterval and setTimeout. All of it I need to gradually increase a certain number.
The actual component is rendered separately inside storybook. The warning shows up after I switch between this component and any other one.
There is a similar issue in react-hot-loader repo, but the solution involves changing Babel config. With CRNA I wasn't be able to solve it.
Environment
Please run these commands in the project folder and fill in their results:

npm ls react-native-scripts<EMAIL_ADDRESS>npm ls react-native<EMAIL_ADDRESS>npm ls expo<EMAIL_ADDRESS>node -v: v8.1.3
npm -v: 5.4.1
yarn --version: 1.1.0
watchman version: "4.7.0"

Also specify:

Operating system: macOS Sierra

hello! this is best suited for stackoverflow. it is not related to CRNA itself. also, i recommend posting code to reproduce it :)


Vertical Scope Line not shown if zoom level is less than zero

If window.zoomLevel is set to any value less than 0 in User or Workspace settings, the vertical scope line is not rendered. Happens regardless of programming language.
Working with "window.zoomLevel": 0

Broken with "window.zoomLevel": -1

Strange it's working for me:

What is your monitor resolution? dpi etc?

Currently on a 15 inch macbook pro at 2880 x 1800.
I should clarify I am only seeing this for the vertical scope lines Column 0.

Saw the same thing on MacBook Air. Only for Column 0 and only Zoom Level -1. But I noticed resizing my sidebar made it re-appear?


Users/nmalkapuram/memtier results aggregation

Aggregate metrics for memtier client for both redis and memcached server process.

Also please rename the title


Cannot find module 'react/jsx-runtime' when using "module": "nodenext"

Bug Report
The experimental "module": "nodenext" ESM support does not work with "jsx": "react-jsx". Causing the following error:
Cannot find module 'react/jsx-runtime' or its corresponding type declarations.

🔎 Search Terms
esm,module,nodenext,jsx,react/jsx-runtime
🕗 Version & Regression Information

This only occurs in nightly builds.
I was unable to test this on prior versions because nodenext is only supported in the nightly versions.

⏯ Playground Link
Playground link with relevant code
💻 Code
Any JSX code would cause the error, this is what I used:
export default function Hello() {
    return
Hello World
;
}

🙁 Actual behavior
"jsx": "react-jsx" does not work with experimental ESM support ("module": "node-next").
🙂 Expected behavior
Expectation was for react-jsx to work going forward with ESM, but it cannot find react/jsx-runtime because it does not have the .js extension and/or React@17 does not have "exports": { "./jsx-runtime": "./jsx-runtime.js" } or similar in it's package.json. It looks like React@18 will add the aforementioned exports field, so I am wondering if either .js would be added when using node-next or if React@18 is a blocker for TS ESM support?

We went back and forth with the react team on if we should emit the .js  or not when we originally added the implicit imports, so I don't think we'll be changing that behavior, since it matches what they landed on for the official babel transform. So it seems like you'll just have to wait for/use react 18, since it seems like it's a pretty showstopping bug in react 17's experimental esm support.

Fair enough. I'll close this out as wontfix then

Until React 18 is out (not very long now!) - or until you can upgrade - a workaround to find and replace inside a built file to add the ESM fully-specified file path (with extension):
sed -i -e 's/jsx-runtime";/jsx-runtime.js";/g' ./build/index.js

@weswigham - However, the decision (to not support the js extension) has downsides for people who just want to transpile into individual files (without bundlers).
Real world use case - there's a project to which I cannot add an import map because it's a browser extension with limited permissions. There's now no way (other than something like sed) to load the UI framework, because tsc will not emit the extension.
Keeping the JS extension will increasingly look better as more people adopt ESM. More importantly, it seems more natural.


[exporters] File statistics exporter

Simple exporter to gather simple metrics about files.

Neat, one metric naming suggestion, file_glob_match_number becomes file_glob_matches.

Please fix the DCO with git commit -s --amend

Please fix the DCO with git commit -s --amend

Done

Neat, one metric naming suggestion, file_glob_match_number becomes file_glob_matches.

Is there any rule of thumb for gauges as there is _total for counters ?

Should I still hope for integration ?
Note: Debian package exists https://packages.debian.org/source/sid/prometheus-exporter-exporter

Thanks, I think this just got lost in time, merging it now.

Is there any rule of thumb for gauges as there is _total for counters (mandatory in OpenMetrics IIRC) ?

There's no explicit suffix convention for gauges, so instead of _number, one generally just uses the plural of whatever is being tallied / measured, and that's it.


Add artsy to examples documentation

Issue: N/A
What I did
Add artsy to examples documentation

How to test
if you must:
cd docs
yarn install
yarn dev
open http://localhost:8000/examples/

Perfect


chore: update models

Description of changes
Update models in preparation for release 0.29.0.
Along with other published service revisions, the GameSpark service has been removed from the SDK.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/test


Normalize percent values everywhere

Normalize all %, replace "percent-multiplicative" in modulations with regular multiplicative.
It simplifies by reducing the number of special cases in MM.
It helps a coming MM work which needs multiplicative source depths mods.

Affected opcodes are checked as working, and so are defaults.
(note: ampeg_start seems not working in aria)


fix websocket issues

if websocket proxy or a network device between it and host-api or python-agent is hung, then those two services hang and never try to reconnect.
Need to make these services send a ping message over the websocket connection and if a pong is not received, exit so that they can restart

Appears fixed in https://github.com/rancher/rancher/releases/tag/v1.1.1 per release notes.


BUG - Wandb: Sanitize callable.

What does this PR do?

This PR set to None any function
Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

[ ] Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @tchaton! Thanks for opening this PR.

In the file pytorch_lightning/loggers/base.py:

Line 172:42: E241 multiple spaces after ':'
Line 182:12: E271 multiple spaces after keyword
Line 186:27: E222 multiple spaces after operator
Line 190:17: E722 do not use bare 'except'

In the file tests/loggers/test_wandb.py:

Line 115:1: E302 expected 2 blank lines, found 1
Line 137:27: E711 comparison to None should be 'if cond is None:'
Line 139:40: E711 comparison to None should be 'if cond is None:'

Do see the Hitchhiker's guide to code style


Fix typo in README.md

The README.md file show the following code:
public items = [
      { name: 'John', otherProperty: 'Foo' },
      { name: 'Joe', otherProperty: 'Bar' }
};

instead of:
public items = [
      { name: 'John', otherProperty: 'Foo' },
      { name: 'Joe', otherProperty: 'Bar' }
];

This is repeated 3times.
Please replace }; with ]; on:

line 43
line 119
line 230

Fixed.  Thanks!


Correcting duration_s explanation and samples

duration_s reports out milliseconds instead of ticks

@aliuy : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@JasonWHowell: I'm sorry - only the author of this article, @SnehaGunda, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Sort file listing?

Would expect it in GitHub Sort Content.
But have also checked GitHub Files Filter, no joy.
Currently I see:

Hi @gingerbeardman!
I didn't include the sorting in the GitHub sort content userscript because it adds the sort arrows as a background image and the file view doesn't have a header that can be targeted. I found this userscript a while back that adds clickable arrows to allow sorting, so I didn't think it would be necessary for me to repeat the work. It's not really "pretty" though 😉.
I guess it would be a good idea to include it in the sort content script... I'll put it on my to-do list.

@Mottie thanks for the link, sadly that still keeps folders and files separate 😭
Although easy enough to change that script once it's installed. Cheers!
Would still use your solution if you ever do one. 👍

It was easier to add then I thought 😸

@Mottie beauty! many thanks

Hehe, I think it actually looks kinda ugly, but what can ya do?

you adding it was beautiful, it looks... passable 😄

strangely, is only appears if i get to a page and reload it?
if i get to a page through browsing it doesn't appear?
https://transfer.sh/KKCTo/quirk.mov

Yeah, it's very fussy... the files within the table are added after the page loads, so sometimes it acts that way. I have the same issue with the file filter userscript. If you look at the bottom of the code, you'll see this block:
		// init after a short delay to allow rendering of file list
		setTimeout(() => {
			addRepoFileThead();
		}, 200);

Try increasing the 200 ms a little bit and see if that helps. I'll keep searching for a better solution.


Cannot close gracefully standard input stream in Tooling API

Gradle Tooling API doesn't close and doesn't give possibility to close a input stream which is provided into Gradle as standard input for execution org.gradle.tooling.LongRunningOperation#setStandardInput. It happens because Gradle starts an asynchornus reading in background executor and doesn't wait for it after BuildLauncher.run. Also, DisconnectableInputStream isn't closes the stream after reading.
On IDEA side we create DiscardingInputStream which tries closing the input stream without exception if DisconnectableInputStream is reading data from this stream.
Without our workaround we see an exception on every Gradle execution from IDEA. We haven't possibility to catch or ignore it.
Exception in thread "DisconnectableInputStream source reader" org.gradle.api.UncheckedIOException: java.nio.channels.AsynchronousCloseException
	at org.gradle.internal.UncheckedException.throwAsUncheckedException(UncheckedException.java:62)
	at org.gradle.internal.UncheckedException.throwAsUncheckedException(UncheckedException.java:41)
	at org.gradle.util.internal.DisconnectableInputStream$1.run(DisconnectableInputStream.java:127)
	at java.base/java.lang.Thread.run(Thread.java:833)
Caused by: java.nio.channels.AsynchronousCloseException
	at java.base/java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202)
	at java.base/sun.nio.ch.SourceChannelImpl.endRead(SourceChannelImpl.java:263)
	at java.base/sun.nio.ch.SourceChannelImpl.read(SourceChannelImpl.java:285)
	at java.base/sun.nio.ch.ChannelInputStream.read(ChannelInputStream.java:59)
	at java.base/sun.nio.ch.ChannelInputStream.read(ChannelInputStream.java:107)
	at java.base/sun.nio.ch.ChannelInputStream.read(ChannelInputStream.java:101)
	at java.base/java.io.BufferedInputStream.read1(BufferedInputStream.java:282)
	at java.base/java.io.BufferedInputStream.read(BufferedInputStream.java:343)
	at org.gradle.util.internal.DisconnectableInputStream$1.run(DisconnectableInputStream.java:98)
	... 1 more

This is something we wanted to fix for a long time, although we couldn't allocate any resources to it yet. You already implemented a reasonable workaround. Are there any additional reasons for us to prioritise the fix?


Refactor server sandbox

Make sandbox struct and it methods public, and add accessor methods for the struct fields

There are lint issues in this one.

@mheon PTAL

Code looks fine to me. This is necessary so we can use Sandboxes in the libkpod API.

@runcom PTAL

@sboeuf PTAL (we want to make sure that the refactor is fine for Clear Containers).

LGTM

@mrunalp the PR sounds good to me. I have just applied it on top of master to test with Clear Containers. I don't have any regression regarding the tests that were already passing.
LGTM


Time::Span#*, Time::Span#/ and Float

Trying to calculate an estimate of remaining time for a task based on elapsed time and percentage done, using the following code:
done = 0.75 # 75% of work done
elapsed = Time::Span.new(0,1,0)
total = elapsed / done

I see the following error:
Error in line 3: instantiating 'Time::Span#/(Float64)'

in /scr/hallasan/crystal-0.24.0-2/src/time/span.cr:303: no overload matches 'Int64#tdiv' with type Float64
Overloads are:
 - Int#tdiv(other : Int)

    seconds = to_i.tdiv(number)
                   ^~~~

Alternatively:
done = 0.75 # 75% of work done
elapsed = Time::Span.new(0,1,0)
total = elapsed * (1.0/done)

results in
Error in line 3: instantiating 'Time::Span#*(Float64)'

in /scr/hallasan/crystal-0.24.0-2/src/time/span.cr:296: no argument named 'seconds'
Matches are:
 - Time::Span.new(days : Int, hours : Int, minutes : Int, seconds : Int, nanoseconds : Int = 0)
 - Time::Span.new(hours : Int, minutes : Int, seconds : Int)
 - Time::Span.new(*, seconds : Int, nanoseconds : Int)
 - Time::Span.new(*, nanoseconds : Int) (trying this one)

    Span.new(
         ^~~

So, neither Time::Span#/ nor Time::Span#* appear to accept floats. However, the API documentation gives their types as #*(number : Number) and #/(number : Number), and 0.75.is_a? Number # => true.
Am I missing something or is this a bug?
$ crystal -v
Crystal 0.23.0+313 [ea4187c57] (2017-10-27)

LLVM: 3.9.1
Default target: x86_64-unknown-linux-gnu

@nome you are using crystal compiler version 0.23.0+313 with crystal-0.24.0-2 stdlib.
Anyway I don't think this is an issue here.
Both Time::Span#/ and Time::Span#* are bugged.
Time::Span#/ accepts a type Number but tries to use Int#tdiv which only accepts Int not Number and certainly not Float64.
In Time::Span#* on line https://github.com/crystal-lang/crystal/blob/master/src/time/span.cr#L297
it does Int64 * Float64 which results in Float64, hence Time::Span.new fails because there is no named argument called seconds with type Float64.

@nome As a workaround you can use the total_seconds of the elapsed timespan to calculate and then create a new Time::Span from the total with #seconds method.
done = 0.75 # 75% of work done
elapsed = Time::Span.new(0,1,0)
total = elapsed.total_seconds / done
pp total.seconds # => 00:01:20

/cc @asterite

@petoem Thanks, the workaround does help.
(incidentally, I've been using compiler and stdlib from the 0.24.0 pre-release tarball, so I disavow responsibility for any version mismatches ;-))


need better instructions for Linux install

is it possible to get a ppa for Ubuntu based systems?

@anthonyettinger What's wrong with the .deb installer? 😜

I do not see one. Where is it documented?

@anthonyettinger https://hyper.is/#installation

A ppa would allow me to get updates though. installing manually with .deb is not ideal.

If it's a PPA, then perhaps this is a dupe of https://github.com/zeit/hyper/issues/1115 ?

Can it be easier by Snaps? Cross-linux system installation.

Yes. We were working on creating a snap but we didn't get around to. There's not much demand and supporting a snap would be extra effort for little usability, but if someone knows how, feel free to PR the snap build scripts and we can work together on getting it out there 🎉

OK. I'm not serious about that.
I hope one day I can install Hyper via command line easily. PPA or Snaps are fine. 😄
Love Hyper anyway. 😘

If no one else is taking this on, i'm going to start playing with it to see if i can get it running as a snap, please leave this open.

@philpalmieri that would be amazing, tell me if there's anything we can do to help you 🙏

I stayed up a bit last night and made a simple Node Snap - https://snapcraft.io/insultme - its actually pretty straight forward, and there are build pipline tools out of the box - ill spend some more time on it tonight and see if i can get a demo running in a dev branch.

Yes , it is possible to get a ppa for Ubuntu Based Systems.

If this isn't resolved. I would like to work on it. Just tell me, if someone else is working on it..

I worked on it for a bit, but got sidetracked with work - I had it compiling to a snap - but having electron issues - go for it! - I won't be able to come back to it for a bit (might try flatpak soon though)


Sign CLA on first issue interaction?

Is it possible to configure cla-assistant to prompt a user to sign the CLA when they first open a new issue or first comment on an existing one?
(Background: we're increasingly using repos for IETF work, where issue discussion replaces email discussion, and it would be great if we had an active indication that a participant had acknowledged the IETF Note Well.)

yes and no :)
No - this is a pretty unique use case and CLA assistant doesn't support it our of the box.
Yes - CLA assistant is an open source project, you can fork the source code, modify it accordingly and spin up your own instance. Code wise this should not be a big deal. You just need to add an additional webhook event, which triggers CLA assistant on new issue or issue comment and check the signature of the issue author or comment author instead of PR committer. All this information is accessible via GitHub API, you just need to adjust the CLA assistant's logic accordingly.