Add “Open Trace” option to File menu

Adding an “Open Trace” option in the File menu keeps this operation intuitive (by imitating how any file is opened).

When a new trace is opened, the IDE navigates automatically to the trace viewer tab

Position in menu
Suggestion: “Open Trace” could be in a separate menu section to distinguish it from the other standard IDE open operations:

Alternative: “Open Trace” could also be further down to avoid breaking up the more standard IDE operations. This would create a bit more discontinuity in the menu list since all the “Open” and the “Save” operations would not be grouped:

If I'm not mistaken, a VsCode extension won't be able to contribute to the main menu [1], while a Theia extensions would allow it. I think it's to keep the main menu to a small set of commands relevant to IDEs. The commands are available through CTRL+SHIFT+P and typing the command name.
If we add it now as part of the Theia extension, then when switching to VsCode extension the "Open Trace" main menu will be removed. If users would want to keep it, than Theia extension would need to be build and added there.
I wonder if we don't add it in to the main menu and have available through:

context sensitive menu in file explorer
Open button in trace explorer
CTR+SHIFT+P + "Open Trace"

Any thoughts?
[1] https://code.visualstudio.com/api/references/contribution-points#contributes.menus.

To clarify, would adding the file menu code to a VS Code extension break the plugin for VS Code? Or would VS Code just throw an internal exception and ignore that section of the code without breaking?

@bhufmann @muddana-satish At the moment, I'm comfortable with not adding the "Open Trace" option to the file menu. It's true that it's an atypical operation for most users.
I also agree with the three alternatives suggested for opening traces (Right-click menu in file explorer, open button in trace explorer, CTRL+SHIFT+P + "Open Trace")

To clarify, would adding the file menu code to a VS Code extension break the plugin for VS Code? Or would VS Code just throw an internal exception and ignore that section of the code without breaking?

There is no API to add commands to the file menu when using VsCode as far as I know.

I also agree with the three alternatives suggested for opening traces (Right-click menu in file explorer, open button in trace explorer, CTRL+SHIFT+P + "Open Trace")

I just remembered why I even wanted an "Open Trace" option in the File menu: It's the obvious UX friendly way to open more traces if you already have one open. (Issue description updated)

The "Open Trace" button #160 covers the case where no traces are open.
Currently, there is no intuitive way to open traces if one is already open so I'm going to create a new issue to discuss this.
I argue that the alternatives (Right-click in the file explorer, CTRL+SHIFT+P + "Open Trace") are convenient "pro speedrunning strats", but definitely wouldn't be the user's first reflex.

Since using the File menu really would be the user's first reflex for opening additional traces, should we save this feature to be added to a more tailored for Theia version down the line? We could change the milestone on this issue.


Loosen the logger type in TensorBoardLogger

Loosen the logger type in TensorBoardLogger from TBLogger to AbstractLogger, so we can pass a customized logger type to send the logs to an HTTP API or any other place instead of a file.

TensorBoardLogger.increment_step!, which expects a TBLogger

@KDr2 Maybe introduce a fallback for increment_step!, then throw an error when not overloaded for concrete logger types?

TensorBoardLogger.increment_step!(::AbstractLogger) =
  throw(ErrorException("Please implement `TensorBoardLogger.increment_step!` for your logger type."))

Like this? I think it would be better if we put it in package TensorBoardLogger?


Expand-on-hover event not calling toggle callback function

As requested by @Voles in the discussion of PR #851, I have submitted a new PR with my proposed changes.

@Agshlee thank you!

@Agshlee v2.22.3 has been released! See https://github.com/angular-ui-tree/angular-ui-tree/blob/master/CHANGELOG.md


feat: Remove storage proof computation in block proposer

TBD @abdelhamidbakhta

I think it's already disabled by default!
When calling new_block_at, given PR::ENABLED, it will call api.record_proof() and then later in block_builder.build(), if it was recorded, it will be extracted.
Given the impl for ProposerFactory::new, we use the DisableProofRecording impl. of PR which has ENABLED set to false. With that, I don't see how the storage proof is every recorded!

I think it's already disabled by default!
When calling new_block_at, given PR::ENABLED, it will call api.record_proof() and then later in block_builder.build(), if it was recorded, it will be extracted.
Given the impl for ProposerFactory::new, we use the DisableProofRecording impl. of PR which has ENABLED set to false. With that, I don't see how the storage proof is every recorded!

Thank you, closing the issue then


Timestring is not being properly set for English on Refreshing the tab

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Details
https://github.com/Expensify/App/issues/4218#issuecomment-892122092
Action Performed:

Go to newDot
Open any chat
Refresh the page
timestring will update from Spanish to English even when the Language is set to English

Expected Result:
It should show the timestring in the language that is set.
Actual Result:
https://user-images.githubusercontent.com/28243942/128154124-6e5dea4f-3653-4c62-b773-12f344ee61f0.mp4
Workaround:
Visual Issue.
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @lschurr (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal
Explaination

This is a regression which is most likely caused by this  https://github.com/Expensify/App/commit/72800fc2b5ef004d246084ee80e5a3c2c9a8c5b4
Earlier we were getting preferredLocale inside props when we used withLocalize but after the above commit preferredLocale became undefined
And then locale was passed inside props for child comps. instead of preferredLocale after this https://github.com/Expensify/App/commit/69fd992846facea6aabcf7a15552f0cafd3f57b3
This is causing the moment.locale to take undefined as an argument here which was defined earlier to these commits
https://github.com/Expensify/App/blob/f77283722983908fe69befe261a2449b9a2cec19/src/pages/home/report/ParticipantLocalTime.js#L44

Solution

We just need to rename locale to preferredLocale on this line
https://github.com/Expensify/App/blob/f77283722983908fe69befe261a2449b9a2cec19/src/components/withLocalize.js#L59

@parasharrajat It's the same PR that caused https://github.com/Expensify/App/issues/4352. The issue it solved is #4268.

Yeah, that's the way to fix this regression another PR should be made by the original author. Don't you think so?

In this case we update "locale: this.props.preferredLocale"
to "preferredLocale: this.props.preferredLocale"
in "App/src/components/withLocalize.js"

Yeah, that's why to fix this regression another PR should be made by the original author. Don't you think so?

There're many instances when regressions are fixed as Separate issues when found out later after the PR is merged.
But I don't think that I'm eligible to answer that question. Someone will surely clarify later.

Could you please mention/tag the respective persons who found the original issue?

I've already provided context in the ticket itself.

Details
#4218 (comment)

Is this a duplicate of this one then? https://github.com/Expensify/App/issues/4218

@lschurr I see that Changes here https://github.com/Expensify/App/pull/4366 caused this issue.

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Tagging Eng for another set of eyes.

@parasharrajat is correct in saying this should be fixed by the original author. We always wait 7 days to pay our contributors so that we can find regressions like this one. The PR we've been linking to is actually another regression fix from this original one, which was only merged 5 days ago.
Thus I think @kidroca should make this change (it's a tiny one-liner change but that's our process).

@aman-atg
Thanks for the info, I'll submit another PR
I've missed that previously preferredLocale was along the ...props spread
I've only passed locale to trigger re-render when it changes, I had no idea it was actually used in the child components...

@kidroca
No problem mate!

This issue has not been updated in over 15 days. @Luke9389 eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!


Fix route middleware stacks

See https://github.com/slimphp/Slim/issues/1622
Removed the array_unshift from RouteGroup->add(), since Route->add() don't use it. Consistency on middleware arrays.

Does this work for you? Can you add a unit test for this change?

Yes, works fine. I'll try do add some tests 'cause I'm not that good on phpunit stuffs...

Added tests

Thanks!


 They are starting to get annoying; putting them on every airline possible. You are already forcing us to add them in to Multilivery server, and now your flooding them here. Stop, really

Stop with these cartoon liveries. They are starting to get annoying; putting them on every airline possible. You are already forcing us to add them in to Multilivery server, and now your flooding them here. Stop, really
STFU I DONT CARE!


not Work saveAs in windows

`
   await FileSaver.instance.saveAs(
      name: DateTime.now().toString().replaceAll(" ",  "_"),
      ext: ".json",
      mimeType: MimeType.json,
      bytes: Uint8List.fromList(utf8.encode(jsonEncode(jsonStrings))),

    )

`
This code works correctly for Android
But for the Windows and web version, the file is not saved and does not give any error

I'm facing this issue, anyone found a solution??

It is mentioned in the README that "you can call saveAs() only available for android and iOS & macOS at the moment". There is a simple workaround, but ideally this would be addressed inside the plugin itself.
final filePath = await FileSaver.instance.saveAs(
  name: fileName,
  bytes: Uint8List(),
  ext: ".$extension",
  mimeType: mimeType,
);
if (filePath == null) {
  // cancelled prompt
  return;
}
// TODO FileSaver.instance.saveAs() as of 0.2.13 on Windows
// only prompts the user for the desired file location, but does not write
// the file passed in.
if (Platform.isWindows) {
  final file = File(filePath);
  await file.writeAsBytes(fileModel.data);
}

If the maintainers need some help with implementing this, I have some time to address this issue.


Feature hot clip

adds function to control dvr directly
adds right button handlers to pages
reworks playback sdcard scan
marks clip as "hot" on right button

Picking up discussion from #96 ...

I am no C expert, and unfamiliar with the code base, but what happens? is hdz_123 renamed to hot_hdz_123 or just hot_123? If the former, what happens if you tag the same file twice? Does it become hot_hot_hdz_123?

let's discuss this in the PR

Furthermore - with this feature being implemented, I would say that #97 becomes a little more complicated - I think we should have a "Delete all recordings except hot recordings" option.

i don't see really see how it nessacitates that, but such a function can be considered.

I would not say that it nessacitates it, but if you have a bunch of hot recordings on your SD card, and it becomes full, currently there is no way to free up space whilst preserving the hot clips (Without removing the SD card, putting it in another device)

Also, wrt #98 , this current implementation maybe precludes that? What's the plan here? If that is to be implemented, would the "Mark as hot" option become an entry in the context menu?

Why would it preclude that? really that PR offers a basis for further extension. Previously the right button could only be used while on the video screen. Yes, the mark as hot can be moved to the context menu if that menu were to be implement.

Yeah, preclude is maybe a poor choice of words there - all I meant was that if the right button was now used to mark hot, it could not be used to open the context menu - as you say, it can be made an option.

Also, just to add - I feel that maybe #98 should be considered before merging this in and making a new release, as this PR as it stands would require an update to the manual (ie, the feature is non-discoverable? I don't see any evidence of something which informs the user that this option exists, although admittedly I have not tested it yet, just had a quick glance through the code)
Even if this is the only option present in the context menu for now, it may be worth implementing the context menu so that the manual could be updated with the fact that the context menu exists and not require multiple re-releases of the manual.
At least, of course, the functionality to open a context menu whilst in the menu system - the request in #98 for opening a context menu whilst in the camera feed is maybe a little more involved and could be pushed to a future release or maybe not even implemented at all.

Also, just to add - I feel that maybe #98 should be considered before making a new release, as this PR as it stands would require an update to the manual (ie, the feature is non-discoverable? I don't see any evidence of something which informs the user that this option exists, although admittedly I have not tested it yet, just had a quick glance through the code) Even if this is the only option present in the context menu for now, it may be worth implementing the context menu so that the manual could be updated with the fact that the context menu exists and not require multiple re-releases of the manual. At least, of course, the functionality to open a context menu whilst in the menu system - the request in #98 for opening a context menu whilst in the camera feed is maybe a little more involved and could be pushed to a future release or maybe not even implemented at all.

I am sorry, but what exactly do you expect me to do here?
Hold back this PR until somebody comes around and implements a context menu on top of it?
The context menu is not trivial (on either screen) and will require a refactor of the whole input system. doing that in one swoop is gonna be error prone and by the time its ready this PR will be outdated to a point where you can basically redo it.
Merge the PR and tell divimath that they can not create a new release until somebody comes around and implements the context menu?
To me it feels like just not having this feature in the manual is way more acceptable than any other option, seeing that this is an additional feature and does not remove any functionality, i barely see any harm.
I do agree that manual will need updating eventually (elrs, ht and the like are not included either) but stopping the whole release machinery because of it seems woefully overkill to me.
For the time being we can simply add a text explaining the feature to the page.

Apologies, I was not aware that implementing a context menu (Certainly in the menu) would be that big of a job. Makes much more sense to just merge it in for now and worry about that later then.

I just tried the latest build and it appears to have a bug.
The first time you tag a clip, it renames it hot_hdz_001 just fine, but the 2nd time you tag a clip, the existing hot_hdz_001 disappears, and the new one replaces it

@bkleiner I just tried the latest build and it appears to have a bug. The first time you tag a clip, it renames it hot_hdz_001 just fine, but the 2nd time you tag a clip, the existing hot_hdz_001 disappears, and the new one replaces it

yepp, you are right, i was trying to be smart and made a last minute off-by-one error.
pushed a potential fix, cant test myself right now tho.

yep, seemed to work.
Interestingly tho, I had hot file 1 already present, scrolled right to next clip, tagged it, it was correctly named hot 2, but it got put at the end of the list. I scrolled back to start, tagged the next clip, and it renamed it and kept it at the beginning. Did the same a 2nd time, and again good.
I just rebooted the goggles afterwards tho (To check if the clip that got put at the end got put back to the start), and now I cannot get into the playback menu. I can get into other menus just fine

But still the oddness with hot clip 2 at the end.
ie ther order of the list in the goggles is hot_1, hot_3, hot_4, hot_5, , hot_2

humm, the code does not do any ordering itself, it relies on the kernel to return the dir entries in order.
i gonna have to check on the details here and implement ordering on our end if all else fails.

The ordering is an artefact of the way that mv works internally, by using link/unlink.
If you want the list ordered, which I think we do, then we might be better off using scandir rather than opendir.

The ordering is an artefact of the way that mv works internally, by using link/unlink. If you want the list ordered, which I think we do, then we might be better off using scandir rather than opendir.

lovely! pushed a version using scandir.

Confirmed as fixed.
Although there is now another slight issue - if I tag, for example, the 5th clip, it renames it correctly, and the "currently selected" red border stays where it is (Highlighting the 5th clip in the list), but when you then scroll to the right, the highlight moves back to the first clip in the list.
So basically, when you mark a clip as hot, the "currently selected" box needs to be changed to the clip that was after the clip that you just tagged.
Not a huge issue though, it's usable. I am flying tomorrow, so I will get to actually fly this build and see how it goes.

I flew this build today, and very bad things happened :(
I ended up losing a quad (My own fault, flew it with a known dodgy XT30 connector, a known defective lost model alarm, and beta goggle firmware) - during the flight I got massive interference and went down, got a battery disconnection and the defective lost model alarm did not go off - so no fault with the video feed I would say, but the DVR is all messed up, so I was not sure where the quad was (Certainly in the field - looking back now I think I maybe know where it is)
This happened on the very last flight of the day - here is a screenshot of how my DVR folder looked:

Some notes:

The folder was empty at the start of the day - so all weirdness seen in this folder is from usage today, with this build.
The DVR was ALWAYS set to TS, so there should be no MP4s in there
hdz_013.mp4 is unviewable and no tools I try can find any video inside it.
The final flight of the day actually appears to be hot_hdz_007.mp4 although it is heavily corrupted. VLC can view it, but there is really weird stuff going on in the file - two images from two different points in time on the same frame. I have uploaded it here. Out of interest, the point I lost video is 6:15 - thank GOD for the record audio function, I can hear myself say that I have lost video, and can see breakup in the video at that point, so I have a fairly high confidence that this video is that last flight where I lost my quad.
I never marked hot_hdz_007.mp4 clip as hot - from the moment I lost video to the end of the day I was looking for the quad or trying to review DVR (But looking at the wrong file, cos hdz_011.ts is the last viewable file) so I am 99% sure that I would not have marked that video as hot.
There are garbled filename files / folders in there, which does not look good.
There's an hdz_009.jpg, but no corresponding .mp4 or .ts
In a bunch of the files (including the hot_hdz_007.mp4` I uploaded, the DVR keeps recording when I enter the menu. You see a zoomed in, cropped, often glitchy view of the menus, and the audio keeps recording too. In fact, in one of them, I entered the DVR menu and played back a file - you can see me reviewing the DVR - in this case the video is of me reviewing the DVR, and the audio is from when I am watching it in the DVR (ie you can hear me commentating about what I can see in the DVR)
On coming back home and troubleshooting, I have noticed that the manual record seems to be somewhat broken. I used a fresh SD card and set the goggles to MP4 recording and manual (One of the recovery apps I was trying wanted a sample of a known good file) and I could start using the record button, but pressing the record button again did not stop. This then corrupted the MP4, so I could not use it as a known good file. Tools I have used before to fix truncated MP4s were unable to fix them.

So yeah, whole loads of bork going on here.
Now I am not 100% sure if all of this is to do with the new code - this is only the 2nd time I have flown the goggles, and I did not review the DVR from the first time, but certainly some of the issues seem to be related to hot clips.

Reviewing the "good" DVR of the day, further observations:

hot_hdz_002.ts starts mid-way through a flight. It's clear that hdz_005.ts is the moments before file hot 2 - from the audio recording you can hear me mid-sentence at the end of  hdz_005.ts and the sentence continues in hot_hdz_002.ts. File 5 is 725MB in length - it shouldn't be stopping there and starting a new file surely?  I am guessing that when I finished that flight, I marked hdz_005.ts as hot and it created hot_hdz_002.ts, but not all of the recording made it into that file?

i'm sorry you had a bad experience, but i don't know how much of that is related to the subject of this PR.
The recording itself takes place in a completely separate process, so i don't think anything relating to that was caused by the changes here.
Starting and stopping of the record in that separate process is however modified by this PR, so we gonna have to take a closer look there.
Garbled file names i have a hard time seeing being caused by anything relating to either process. Maybe your filesystem got corrupted somehow?

I just saw something in a video which maybe yields a clue... I just saw a DVR of me going into the playback menu and marking that "last flight" as hot. ie the DVR is still recording a clip while I mark that very same clip as hot.
Surely it moving a file while it is in use would be potentially very bad?

Surely it moving a file while it is in use would be potentially very bad?

no optimal for sure, but linux should handle this gracefully for the most part. it will hold on the the inode, so as long as the recording has the file open it should continue to "just work". (...otherwise the recording would stop dead there.)

It keeps recording after you unplug
It's then possible to go into the playback menu while it is still recording

yes, i think that's the problem we are looking at here: the record does not get terminated when it is supposed to.

Another observation is that the OSD persists in the goggles once you unplug. Maybe somehow this is keeping it recording? Or could it be that the audio is still recording that's keeping it "alive"?

Another observation is that the OSD persists in the goggles once you unplug. Maybe somehow this is keeping it recording? Or could it be that the audio is still recording that's keeping it "alive"?

no. osd data being displayed or not does not relate to the connected state.
i have pushed a potential fix, the recording would simply not get stopped properly, because there were some missing break statements. additionally i have tried to improve thread safety, has the function would release the mutex before recording actually stopped.

Just a quick UX suggestion about the naming of hot clips.
Right now since the RTC isn't powered, only the DVR filenames approximately gives an idea of the files you recorded.
Hence I surmise it's really important to keep the files in the order there were recorded.
To that end you cannot name the hot files in a way that interfere with that count order.
Instead of doing:
(the 'real' order in which the files were recorded irl are in parenthesis)
hdz_001.ts (1)
hdz_003.ts (3)
hdz_005.ts (5)
hot_hdz_001.ts (2)
hot_hdz_002.ts (4)

you could just add _hot at the end of the usual filename, like:
hdz_001.ts (1)
hdz_002_hot.ts (2)
hdz_003.ts (3)
hdz_002_hot.ts (4)
hdz_005.ts (5)

This way you still get the only clue about when a dvr was recorded, which is the order of the files between themselves.
Bonus: Also, while we are modifying how the DVR file are named, perhaps it could you useful to use 4 numbers instead of 3, like in the VRX. Since you can use very big sd card, you could theoretically go past 1000 recordings.

It depends on how the DVR names files - as long as we could avoid a scenraio like this, then I think this sounds like a reasonable idea:

Do a pack, DVR is hdz_005
Mark hot, file becomes hdz_005_hot
Power down goggles
Power up and fly next pack
DVR creates another hdz_005

Again, we simply do not know how the record app generates it names, so i went for a variant that makes collisions very unlikely.

The firmware workes good for me without any problems. Simple and straight forward to use

Had another day's flying - all the problems seem gone with this latest build.
And as an added bonus, we found my lost quad :)
Thanks @bkleiner for a great feature!

Actually, would it be possible to mark a clip hot without having to go into the menu,
If you are on the camera view page, and you have no current connection, it would be nice to be able to hit record, and it marks the last clip (highest number) as hot. Ideally it should show some prompt like "Marked hdz_009 as hot"

Actually, would it be possible to mark a clip hot without having to go into the menu, If you are on the camera view page, and you have no current connection, it would be nice to be able to hit record, and it marks the last clip (highest number) as hot. Ideally it should show some prompt like "Marked hdz_009 as hot"

lets see that we can this merged as it currently stands ;) plenty of changes as is. further expansion is always an option.


All the entities became not available after 2 hours from installation

Hi,
on my HA the integration work properly only for a couple of hours, then all the entities of my Daikin Altherma became "not available". I have to disinstall the integration from HA and add it again from HACS. How can I fix this problem?

Do you see any errors in log file?

I just restore the integration and now is working. Unfortunately I didn't
save the log so I don't remember the error that was reported in the log. As
soon as the integration stop working I will copy the log and I revert to
you.
Thanks in advance for your support
Il giorno mer 21 set 2022 alle ore 16:05 Tadas Danielius <
@.***> ha scritto:

Do you see any errors in log file?
—
Reply to this email directly, view it on GitHub
https://github.com/tadasdanielius/daikin_altherma/issues/39#issuecomment-1253762266,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZDGTSCGK7Q76LE2UJSQLDDV7MI2PANCNFSM6AAAAAAQR6444Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

No errors in log file. Almost all the entities became unavailable after a
couple of hours, as per attached pictures.
[image: image.png]
In detail, if I click on an entity appear the following
[image: image.png]
Just now I tried to reload the integration from the menù and
everything start working again.
Il giorno mer 21 set 2022 alle ore 16:05 Tadas Danielius <
@.***> ha scritto:

Do you see any errors in log file?
—
Reply to this email directly, view it on GitHub
https://github.com/tadasdanielius/daikin_altherma/issues/39#issuecomment-1253762266,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZDGTSCGK7Q76LE2UJSQLDDV7MI2PANCNFSM6AAAAAAQR6444Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Somehow, pictures got lost and does not appear here.
Do you run any other instance of HA or any other software which might "talk" to your device directly? At Least in my case LAN device allows only one connection, so if another software is connected then it could cause problems and entities become unavailable.

No. The entities became unavailable in the meanwhile I was driving from
work to home therefore I couldn't run any app or instance. The pictures
simply showed that around 17:30 (italy local time) every the entities
became unavailable with the only exception of the entity of the outgoing
water temperature
Il giorno gio 22 set 2022 alle ore 09:07 Tadas Danielius <
@.***> ha scritto:

Somehow, pictures got lost and does not appear here.
Do you run any other instance of HA or any other software which might
"talk" to your device directly? At Least in my case LAN device allows only
one connection, so if another software is connected then it could cause
problems and entities become unavailable.
—
Reply to this email directly, view it on GitHub
https://github.com/tadasdanielius/daikin_altherma/issues/39#issuecomment-1254616399,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZDGTSDPKSNWYKLHHFCRU53V7QARVANCNFSM6AAAAAAQR6444Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Difficult to say without any logs but I would guess it might be because of those two reasons:

Network issues between home assistant and daikin device
Another process (like another instance of home assistant/other integration or any of process connecting to the device) is blocking the connection to the device.

Entities becomes unavailable if integration is unable to connect to the device. Does the entities become available later or you need to restart integration/home assistant to get it working again?

I checked the log. No error. To have the entities working again I have to reload the integration. I don’t have any automation that includes any entities of the heat pump. Adolfo MancanelliIl giorno 24 set 2022, alle ore 14:09, Tadas Danielius @.***> ha scritto:
Difficult to say without any logs but I would guess it might be because of those two reasons:
Network issues between home assistant and daikin device
Another process (like another instance of home assistant/other integration or any of process connecting to the device) is blocking the connection to the device.
Entities becomes unavailable if integration is unable to connect to the device. Does the entities become available later or you need to restart integration/home assistant to get it working again?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Is is possible that your device gets different IP address after some period of time?

Yes but not every two hours (normally after a modem restart). There is un
update, after disinstallations, reloads, etc during these days: now it
seems that the entities remain always available but the values  they show
say there is not updating. Sorry for my english, what I mean is that, for
example, the outdoor temperature value is available but show always the
same figure (night and day). To have the current real figure I have to
reload the integration. After that I see the right figures. I have to do
this every time.
Il giorno gio 29 set 2022 alle ore 08:49 Tadas Danielius <
@.***> ha scritto:

Is is possible that your device gets different IP address after some
period of time?
—
Reply to this email directly, view it on GitHub
https://github.com/tadasdanielius/daikin_altherma/issues/39#issuecomment-1261842391,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZDGTSHREL5GMMLYQKPGJ63WAU3YNANCNFSM6AAAAAAQR6444Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

Today even if i reload the integration, it doesn't work.
Here the registry log:
2022-10-08 09:28:15.464 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration daikin_altherma which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant
2022-10-08 09:28:24.249 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Daikin HVAC controller (211800239) for daikin_altherma
File "/config/custom_components/daikin_altherma/init.py", line 68, in async_setup_entry
File "/config/custom_components/daikin_altherma/init.py", line 33, in setup_api_instance
2022-10-08 11:49:16.278 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Daikin HVAC controller (211800239) for daikin_altherma
File "/config/custom_components/daikin_altherma/init.py", line 68, in async_setup_entry
File "/config/custom_components/daikin_altherma/init.py", line 33, in setup_api_instance
2022-10-08 11:49:30.998 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Daikin HVAC controller (211800239) for daikin_altherma
File "/config/custom_components/daikin_altherma/init.py", line 68, in async_setup_entry
File "/config/custom_components/daikin_altherma/init.py", line 33, in setup_api_instance
2022-10-08 11:50:15.862 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Daikin HVAC controller (211800239) for daikin_altherma
File "/config/custom_components/daikin_altherma/init.py", line 68, in async_setup_entry
File "/config/custom_components/daikin_altherma/init.py", line 33, in setup_api_instance
2022-10-09 11:47:04.182 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Daikin HVAC controller (211800239) for daikin_altherma
File "/config/custom_components/daikin_altherma/init.py", line 68, in async_setup_entry
File "/config/custom_components/daikin_altherma/init.py", line 33, in setup_api_instance
2022-10-09 14:33:08.470 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry Daikin HVAC controller (211800239) for daikin_altherma
File "/config/custom_components/daikin_altherma/init.py", line 68, in async_setup_entry
File "/config/custom_components/daikin_altherma/init.py", line 33, in setup_api_instance

this is clearly related to IP change. I would suggest to set altherma device IP to static.

Ok, thanks a lot
Il giorno mar 11 ott 2022 alle ore 08:42 Tadas Danielius <
@.***> ha scritto:

this is clearly related to IP change. I would suggest to set altherma
device IP to static.
—
Reply to this email directly, view it on GitHub
https://github.com/tadasdanielius/daikin_altherma/issues/39#issuecomment-1274159201,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZDGTSA6QP5MADOZW4U5W6LWCUD3RANCNFSM6AAAAAAQR6444Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

I noted that if I reload the integration in HA, all the entities start
working again. This morning I have done in this way since as usual all the
entities was unavailable
Il giorno gio 22 set 2022 alle ore 09:07 Tadas Danielius <
@.***> ha scritto:

Somehow, pictures got lost and does not appear here.
Do you run any other instance of HA or any other software which might
"talk" to your device directly? At Least in my case LAN device allows only
one connection, so if another software is connected then it could cause
problems and entities become unavailable.
—
Reply to this email directly, view it on GitHub
https://github.com/tadasdanielius/daikin_altherma/issues/39#issuecomment-1254616399,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZDGTSDPKSNWYKLHHFCRU53V7QARVANCNFSM6AAAAAAQR6444Y
.
You are receiving this because you authored the thread.Message ID:
@.***>

I have similar problems since the heating season started.. I often have to restart the LAN Controller.
Dieser Fehler wurde von einer benutzerdefinierten Integration verursacht

Logger: custom_components.daikin_altherma
Source: custom_components/daikin_altherma/__init__.py:190
Integration: Daikin Altherma HVAC (documentation, issues)
First occurred: 19:51:55 (1 occurrences)
Last logged: 19:51:55

Failed to the get the data from the device [<IP_ADDRESS>] ()
Traceback (most recent call last):
  File "/config/custom_components/daikin_altherma/__init__.py", line 190, in async_update
    self._status = await self.device.get_current_state()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/controllers.py", line 400, in get_current_state
    unit_status = await unit.get_current_state()
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/controllers.py", line 133, in get_current_state
    states = await self.read_states()
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/controllers.py", line 79, in read_states
    results[state] = await self.read_state(state)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/controllers.py", line 73, in read_state
    resp = await self.read(query_type='UnitStatus', prop=status)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/controllers.py", line 49, in read
    result = await self._connection.request(destination)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/comm.py", line 39, in request
    result = await self._request(dest, payload, wait_for_response, assert_response_fn)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/comm.py", line 55, in _request
    response_str = await self._client.receive_str(timeout=self._timeout)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client_ws.py", line 273, in receive_str
    msg = await self.receive(timeout)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client_ws.py", line 229, in receive
    msg = await self._reader.read()
          ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/streams.py", line 657, in read
    return await super().read()
           ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/streams.py", line 616, in read
    await self._waiter
asyncio.exceptions.CancelledError

Reloading the Integration often didn't resolve the problem.
Logger: homeassistant.config_entries
Source: config_entries.py:402
First occurred: 22:45:13 (1 occurrences)
Last logged: 22:45:13

Error setting up entry Daikin HVAC controller (194300157) for daikin_altherma
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/aiohttp/connector.py", line 980, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)  # type: ignore[return-value]  # noqa
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 1085, in create_connection
    raise exceptions[0]
  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 1069, in create_connection
    sock = await self._connect_sock(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 973, in _connect_sock
    await self.sock_connect(sock, address)
  File "/usr/local/lib/python3.11/asyncio/selector_events.py", line 628, in sock_connect
    return await fut
           ^^^^^^^^^
  File "/usr/local/lib/python3.11/asyncio/selector_events.py", line 668, in _sock_connect_cb
    raise OSError(err, f'Connect call failed {address}')
OSError: [Errno 113] Connect call failed ('<IP_ADDRESS>', 80)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 402, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/daikin_altherma/__init__.py", line 68, in async_setup_entry
    hass.data[DOMAIN][entry.entry_id] = api = await setup_api_instance(
                                              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/config/custom_components/daikin_altherma/__init__.py", line 33, in setup_api_instance
    await device.discover_units()
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/controllers.py", line 458, in discover_units
    resp_obj = await self._connection.request(dest)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/comm.py", line 39, in request
    result = await self._request(dest, payload, wait_for_response, assert_response_fn)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/comm.py", line 45, in _request
    await self.connect()
  File "/usr/local/lib/python3.11/site-packages/pyaltherma/comm.py", line 30, in connect
    self._client = await self._session.ws_connect(self.ws_address)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client.py", line 779, in _ws_connect
    resp = await self.request(
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client.py", line 536, in _request
    conn = await self._connector.connect(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/connector.py", line 540, in connect
    proto = await self._create_connection(req, traces, timeout)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/connector.py", line 901, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/connector.py", line 1209, in _create_direct_connection
    raise last_exc
  File "/usr/local/lib/python3.11/site-packages/aiohttp/connector.py", line 1178, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/connector.py", line 988, in _wrap_create_connection
    raise client_error(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host <IP_ADDRESS>:80 ssl:default [Connect call failed ('<IP_ADDRESS>', 80)]

Device: Altherma 3 Geo with LAN Controller BRP069A61, Homeassistent 2023.11.3

update: My problem was solved after I configured a static IP on the LAN controller.

update: My problem was solved after I configured a static IP on the LAN controller.

Second problem was a faulty network-patch-cable. x)


Enable build for py35

Currently the CF doesn't build for python 3.5. That would be great to have py35 builds.
Maybe it could be done adding min_py_ver: '35' on https://github.com/conda-forge/pymapd-feedstock/blob/master/conda-forge.yml

The min technically is 2.7, until we stop supporting it. We're planning on removing 2.7 support soon, but it may persist for a few more releases.

I asked that on CF gitter channel and I receive this answer: py35 is no longer supported by conda-forge


bug: @-file is case sensitive

Version
0.16.0
Describe the bug
@-file results are missing some of the same results that VS Code would show for the same query, due to case sensitivity:

Expected behavior
The search returns the same results as VS Code
Additional context
No response

this is limited by the VS Code API we depend on. This should be resolved once bfg and other context that support fuzzy search are available to use: https://github.com/sourcegraph/cody/issues/1840#issuecomment-1820985414

It looks like there is a workaround we could do: https://github.com/microsoft/vscode/issues/10633#issuecomment-680928105
According to Cody:

Write a typescript function that for each letter converts it into a regex glob that is case insensitive. e.g. ""VeryLongFilePathThatGoesOnAndOnAndOn" becomes "{V,v}{E,e}{R,r}{Y,y}{L,l}{O,o}{N,n}{G,g}{F,f}{I,i}{L,l}{E,e}{P,p}{A,a}{T,t}{H,h}{T,t}{H,h}{A,a}{T,t}{G,g}{O,o}{E,e}{S,s}{O,o}{N,n}{A,a}{N,n}{D,d}{O,o}{N,n}{A,a}{N,n}{D,d}{O,o}{N,n}"

Here is a function that converts a string to a case insensitive regex glob:
function stringToRegexGlob(str: string): string {
  return str.split('').map(char => `{${char.toUpperCase()},${char.toLowerCase()}}`).join('')
}

To test:
const input = "VeryLongFilePathThatGoesOnAndOnAndOn";
const output = stringToRegexGlob(input);

console.log(output);
// "{V,v}{E,e}{R,r}{Y,y}{L,l}{O,o}{N,n}{G,g}{F,f}{I,i}{L,l}{E,e}{P,p}{A,a}{T,t}{H,h}{T,t}{H,h}{A,a}{T,t}{G,g}{O,o}{E,e}{S,s}{O,o}{N,n}{A,a}{N,n}{D,d}{O,o}{N,n}{A,a}{N,n}{D,d}{O,o}{N,n}"

@toolmantim lmao this actually works, nice find 🤣
Previously the @ command wouldn't be able to find `readme" as its usually README but this workaround is neat.
I wonder how this affects context retrieval though, I don't know if this glob affects other search mechanisms

I have a PR in the works to fix this

Nice found Tim ❤ :galaxybrain:

gogogogo polish!!


What if I set enable=false in evalscope/registry/config/cfg_single.yaml?

Like reviews_gen or rating_gen? What would happen?

The prediction stage will be skipped if enable=false for specific model like chatglm3-6b, in the same way that could be happened in review and rating stages.
The desc of stages:
answers_gen: predictions and output answers
reviews_gen: to call the judge model like gpt-4 to get review results
rating_gen: to compute ELO score

Due to a lack of activity for an extended period, we will be closing this issue. If you have any questions, please feel free to reopen it. If EvalScope has been helpful to you, we would appreciate a STAR as a form of support. Thank you!


DID Exchange in ACA-Py 0.7.4 with explicit invitations and without auto-accept broken

While working with @mepeltier on testing out a few different scenarios on ACA-Py 0.7.4, we (re)discovered that the connection state after receiving a did exchange request was not being saved, making it impossible to accept the request. This was fixed in main (and included in 1.0.0-rc0) by #1881. At the time I reviewed that PR, I did not realize how big of an issue the PR was fixing. Looking at it again now, I think it warrants a patch release.
Main has seen some changes lately that likely wouldn't fit in a patch release. With that in mind, I think cherry-picking and producing a release on a separate branch is appropriate. I'd be happy to put in the effort to prepare a branch with this state.
Should we do this? Are there other fixes that should be included in a 0.7.5 patch release?
@swcurran @ianco @andrewwhitehead

Also probably worth making sure we hit this scenario in the integration tests.

I'll review PRs merged since 0.7.4 and report back whether there are any I think should also be included in a 0.7.5 patch release.

Also probably worth making sure we hit this scenario in the integration tests.

The integration tests run with most of the "auto" flags on, whereas AATH runs with most of the "auto" flags off

The mobile team at Indicio is interested in seeing #1940 included in a patch.

@ianco -- I tend to call #1913 a breaking change, so would prefer to leave it for 1.0.0. What is the rationale for putting it into 0.7.5?

@ianco -- I tend to call #1913 a breaking change, so would prefer to leave it for 1.0.0. What is the rationale for putting it into 0.7.5?

Northern Block has specifically asked for a release with this fix

Could we do that as a 1.0.0-rc1 for that?  I'm happy to do that.

Could we do that as a 1.0.0-rc1 for that? I'm happy to do that.

For sure I think that would be fine.

@swcurran Are you going to publish the docker image for the same?

Yes.  Completing the 0.7.5 release is still a in progress -- there is at least one more PR to go.  Would it help you for me to produce a 1.0.0-rc1, or do you need the 0.7.5-rc0/0.7.5 image?
Sorry for the delay.

Thank you @swcurran I would go for 0.7.5 image.

Tag and image 0.7.5-rc0 exists and seems to be fine. @Durai46 and @dbluhm -- can you confirm we are good to go with "0.7.5" final?  I think it is an easy one, but just wanted to get this finished.
We've run AATH tests and things are working with one odd, but likely unrelated bit of weirdness.  If you want the details I can provide, but it's convoluted! :-(
Once I get a thumbs up I'll do a final PR for the 0.7.5 release and we'll count it done.

I haven't had a chance to give it the full battery of tests we like to run (basically just plugging into our plugins/projects and running integration tests) but I have run a few and it's looking good so far. Critically, the original problem I opened this issue for I have tested and found working in 0.7.5-rc0.

OK -- Glad to hear the main issue is addressed. I'm doing a bit more and we'll make a call that it is done Real Soon Now. Please let me know if you do more and the results are good/bad.
Thanks!

FYI -- the "weirdness" with AATH has been solved.  Weird answer, but now working... :-)

With 0.7.5 released, closing this issue :slightly_smiling_face:


Changing the control layout

I was wondering if you could please change the control layout? It would make more sense if you could change Y as C left and X as C right and use the touch screen for C up and C down.

I don't want to change the control layout at this point; it might cause confusion. If I get around to it, I'd rather make the controls configurable by the user. I need to figure out the best way to do this, though.


I am trying to install python version 2.7, It doesn't work.

I am getting this error, on ubuntu trusty 14.04
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Function Call, validate_re(): "2.7" does not match ["system", "pypy", "3", "3.3"] at /etc/puppet/modules/python/manifests/init.pp:76:5 on node app01.*********-1.compute.internal
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

My code is
class site::profiles::app_base {
  class { 'python' :
    version    => '2.7',
    pip        => true,
    dev        => true,
    virtualenv => true,
    gunicorn   => true,
  }

}

https://github.com/stankevich/puppet-python/blob/master/manifests/params.pp#L15
This is the relevant code

Hi @shishirsharma
Please send a pull request so we can support your setup. Thank you!


Fail if both armeria-spring-boot2-starter and armeria-spring-boot2-webflux-starter used

Motivation:

Related #3056

Modifications:

Add NonReactiveWebApplicationCondition in ArmeriaAutoConfiguration
Write ArmeriaAutoConfiguration separately in boot1-autoconfigure, boot2-autoconfigure
Add test property(spring.main.web-application-type=none) in boot2-autoconfigure
Add test dependency to boot2-autoconfigure, boot2-webflux-autoconfigure and boot2-tomcat9

Result:

Close #3056

dependencies
auto-detect
auto-configure

boot2-autoconfigure
none
ArmeriaAutoConfiguration

boot2-webflux-autoconfigure
reactive
ArmeriaReactiveWebServerFactoryAutoConfiguration

boot2-autoconfigure + tomcat9
servlet
ArmeriaAutoConfiguration

boot2-autoconfigure + boot2-webflux-autoconfigure
reactive
ArmeriaReactiveWebServerFactoryAutoConfiguration

boot2-autoconfigure + boot2-webflux-autoconfigure+ tomcat9
servlet
ArmeriaAutoConfiguration

@heowc I'm somewhat confused about the following behavior:

boot2-autoconfigure + boot2-webflux-autoconfigure => Reactive
boot2-autoconfigure + boot2-webflux-autoconfigure + tomcat9 => Servlet

What's the rational for this? What would be the least surprising behavior for the cases above as a String Boot user?

Spring Boot automatically sets the application type when the application is launched. (You can see this in the following article.)

So, since Armeria is not servlet, its type is none.
boot2-autoconfigure has no web-mvc dependency, so its type is none.
boot2-webflux-autoconfigure has webflux dependency, so its type is reactive.

Question: The title of this pull request is 'Fail if both armeria-spring-boot2-starter and armeria-spring-boot2-webflux-starter used', but does this pull request make Spring Boot fail to start up in such as case? If not, how about updating the title?

Question: The title of this pull request is 'Fail if both armeria-spring-boot2-starter and armeria-spring-boot2-webflux-starter used', but does this pull request make Spring Boot fail to start up in such as case? If not, how about updating the title?

What do you think of changing 'Fix Spring Boot fail to start up'?

If I understood correctly, Spring Boot does not fail to start even without this pull request. It just launches two servers. Correct? If so, how about Do not launch two servers if both ... and ... are in the class path ?


PSM-393 Upgrade org.apache.maven.plugins:maven-source-plugin 3.1.0 -> 3.2.1

This PR contains the following updates:

Package
Update
Change

org.apache.maven.plugins:maven-source-plugin
minor
3.1.0 -> 3.2.1

Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

Suggested commit message:
PSM-393 Upgrade maven-source-plugin 3.1.0 -> 3.2.1

See https://github.com/apache/maven-source-plugin/compare/maven-source-plugin-3.1.0...maven-source-plugin-3.2.1


Bot not responding after updating secret value in azure AD (Microsoft entra)

I have a question
Bot not responding after updating secret value in azure AD (Microsoft entra). Even though secret is proper it is giving invalid client secret error in deployed environment. In Local it is working fine with same creadentails.

Closing in favor of issue #5376.


Accept pull requests

I would love to contribute to this project - but it doesn't look like you are accepting pull requests, is there a reason?

Hey glen,
I was really busy. I have just accepted all of them.
Best Regards

Thanks!

More to come - please accept

I've accepted all pull requests.
Thanks

Can we close this :) Thanks @glen-mac for cleaning the code up - much easier to use without every link being logged.

Thanks!


MIDI cc controls not working

When using the latest code, sending midi cc messages to control effect parameters doesn't seem to work correctly. On an older build it does work (I think before the custom display values were added, around Feb 2024). It seems to detect the message, because the screen flickers but immediately goes to "0.0". Is there a way to use midi controls with the updated value and preset handling? Thanks!

Which effect? All of them?
I wonder if the screen logic is taking priority
I don't have any midi stuff to really test unfortunately, I could try to rig something up in the near future though

I changed most of the effect midi mapping to match my midi controller, so there's something going on besides it being set to -1. I haven't tried switching the effects over midi, I'm guessing that's a program change midi message rather than CC? Still learning about midi myself but I can take a look at the code to try to understand the logic for it.

I have a feeling this got broken when the underlying values used to store parameters changed from 8bit uints to 32bit bytes that could represent more data types.  The midi cc commands were taking advantage of the fact that the underlying data structure was the same range as the allowable midi values.  I bet it just needs to cal the appropriate setter functions for the data type instead of assuming the underlying is a uint and setting the RAW bytes.

@bkshepherd it also looks like the logic for each data type is different than the old code when updating the UI. Before, unknown/raw/float values were all grouped into one "if" statement, but now the float data type is separated out and only sets as float, instead of setting as raw. So the parameters I'm changing that are set as "FloatMagnitude" type, it never gets to the logic to update the raw value, it only tries to update the float value. But since it's midi it's only receiving an int value. I'll try setting a parameter as a "Raw" data type and see if midi works for it then.

@bkshepherd is it possible to convert the uint8 received by midi into a uint32 before sending to the set raw function? Or was there a particular setter function in the code you are referring to that I should use.

@GuitarML Yeah, I think this is the root of the problem.  You can't just convert the midi uint8 to uint32 and set the parameter and hope it works because there are many parameter types now.  In the handle midi function you'd probably need to special case the default behavior for the actual parameter type.  For instance.  if the param is a bool.  use the midi 0..127 for False and 128..255 as True. For Parameters that are 0..1 magnitude map the midi 0..255 to 0.0 to 1.0 range with discrete increments.  For the binned value convert the midi 0..255 to minValue->maxValue.   I think I had also thought about adding a callback to specific effect_Modules to allow them to override default midi conversion mappings to get this logic out of the main guitar_pedal.cpp, but I clearly never got around to doing this.

@GuitarML Yeah, I think this is the root of the problem. You can't just convert the midi uint8 to uint32 and set the parameter and hope it works because there are many parameter types now. In the handle midi function you'd probably need to special case the default behavior for the actual parameter type. For instance. if the param is a bool. use the midi 0..127 for False and 128..255 as True. For Parameters that are 0..1 magnitude map the midi 0..255 to 0.0 to 1.0 range with discrete increments. For the binned value convert the midi 0..255 to minValue->maxValue. I think I had also thought about adding a callback to specific effect_Modules to allow them to override default midi conversion mappings to get this logic out of the main guitar_pedal.cpp, but I clearly never got around to doing this.

I believe that callback is there in the base effect module, unused by any effect

Yes! MidiCCValueNotification.  I guess that should always be called from guitar_pedal.cpp instead of just being the fall back, and then base_effect_module could have a default implementation as I mentioned above.

I think I get it, thanks! When you say 0 to 255 you mean 0 to 127 right? Isn't 127 the max midi value or am I confused.

Yes, you are correct 0..127 is the midi range.
haha I get it, the struggle is real bending over.  Also, for those 1590b pedals without the screen midi is really the only way to switch effects etc.

I'm also having trouble using the encoder to change binned item types, it's stuck on the first item when I turn the encoder (you can test on the Modulated Tremolo wave types). Noting it here because it seems like it might be a similar problem to the midi issue.

This is a separate issue with the Binned item types.  It got broken when someone changed the underlying storage type for parameters to be 32bit from 8bit, some of the conversion functions didn't get updated.  I opened a separate issue to fix this #44 .

This should all be fixed now


Input file support , Fixes alexhallam/tv#49

still default reader is stdin, if provided it can read from file without catting , with -i , input-file flag.

@atakurt. Thanks for this PR, but I like #81 as a way to pass the file without the -i option.


Laravel 5.3

After moving on to Laravel 5.3 I couldn't get Auth:: to work :(
After checking out the code it was ALWAYS passing email as the logon attribute in $credentials. I double checked
My login controller:
protected $username = 'username'; // <-- This is wrong for 5.3

I figured out that now it need to be:
public function username()
{
    return 'username';
}

And now it works again.

Fixed, thanks!


Watches always fail to start once when agent restarts

Describe the bug
I don't know if this is a bug, but when force restarting an Antrea Agent on a Node (by deleting the previous Pod), I always see these logs on restart:
W0805 00:49:26.646142       1 client.go:102] Didn't get CA certificate from ConfigMap. May not be able to verify server cert
I0805 00:49:26.646293       1 client.go:107] No antrea kubeconfig file was specified. Falling back to in-cluster config
I0805 00:49:26.646382       1 client.go:127] Updating Antrea client with the new CA bundle
I0805 00:49:26.647914       1 log_file.go:134] Starting log file monitoring. Maximum log file number is 4
I0805 00:49:26.648187       1 server.go:538] Starting CNI server
I0805 00:49:26.648344       1 server.go:548] CNI server is listening ...
I0805 00:49:26.649045       1 agent.go:46] Starting Antrea Agent Monitor
I0805 00:49:26.649507       1 configmap_cafile_content.go:202] Starting antrea-ca::kube-system::antrea-ca::ca.crt
I0805 00:49:26.649523       1 client.go:81] t.go:202] Starting antrea-ca::kube-system::antrea-ca::ca.crt
I0805 00:49:26.649530       1 shared_informer.go:223] Waiting for caches to sync for antrea-ca::kube-system::antrea-ca::ca.crt
I0805 00:49:26.649535       1 configmap_cafile_content.go:209]  Waiting for caches to sync for antrea-ca::kube-system::antrea-ca::ca.crt
I0805 00:49:26.651516       1 node_route_controller.go:263] Starting AntreaAgentNodeRouteController
I0805 00:49:26.651529       1 node_route_controller.go:266] Waiting for caches to sync for AntreaAgentNodeRouteController
I0805 00:49:26.651721       1 networkpolicy_controller.go:309] Waiting for all watchers to complete full sync
I0805 00:49:26.651834       1 networkpolicy_controller.go:468] Starting watch for NetworkPolicy
I0805 00:49:26.652799       1 networkpolicy_controller.go:468] Starting watch for AppliedToGroup
I0805 00:49:26.653091       1 networkpolicy_controller.go:468] Starting watch for AddressGroup
W0805 00:49:26.658270       1 networkpolicy_controller.go:471] Failed to start watch for AddressGroup: Get https://<IP_ADDRESS>:443/apis/networking.antrea.tanzu.vmware.com/v1beta1/addressgroups?fieldSelector=nodeName%3Dk8s-node-master&watch=true: x509: certificate signed by unknown authority
W0805 00:49:26.660306       1 networkpolicy_controller.go:471] Failed to start watch for AppliedToGroup: Get https://<IP_ADDRESS>:443/apis/networking.antrea.tanzu.vmware.com/v1beta1/appliedtogroups?fieldSelector=nodeName%3Dk8s-node-master&watch=true: x509: certificate signed by unknown authority
W0805 00:49:26.660862       1 networkpolicy_controller.go:471] Failed to start watch for NetworkPolicy: Get https://<IP_ADDRESS>:443/apis/networking.antrea.tanzu.vmware.com/v1beta1/networkpolicies?fieldSelector=nodeName%3Dk8s-node-master&watch=true: x509: certificate signed by unknown authority
I0805 00:49:26.750596       1 shared_informer.go:230] Caches are synced for antrea-ca::kube-system::antrea-ca::ca.crt
I0805 00:49:26.750622       1 configmap_cafile_content.go:209]  Caches are synced for antrea-ca::kube-system::antrea-ca::ca.crt
I0805 00:49:26.750943       1 client.go:107] No antrea kubeconfig file was specified. Falling back to in-cluster config
I0805 00:49:26.751165       1 client.go:127] Updating Antrea client with the new CA bundle

Notice the warnings.
The call to this function is failing:
https://github.com/vmware-tanzu/antrea/blob/5be570b203cde54f42eaeb8f52a4353f846ff214/pkg/agent/client.go#L72-L76
I believe this is because the apiserver code uses the ConfigMap lister before the cache has synced (not 100% sure): https://github.com/kubernetes/apiserver/blob/7b7ecfc9c50835ea75f5dfe2abd93036cf9628cf/pkg/server/dynamiccertificates/configmap_cafile_content.go#L141-L146
We could ignore the error in RunOnce, like is done here: https://github.com/kubernetes/apiserver/blob/7b7ecfc9c50835ea75f5dfe2abd93036cf9628cf/pkg/server/dynamiccertificates/configmap_cafile_content.go#L189-L195
But the watches would still fail. @tnqn do you have an idea on how we can avoid these warnings?
To Reproduce
Deploy Antrea on a cluster. Delete an Antrea Agent Pod on a Node. Wait for the Agent to restart and look at the logs.
Expected
No warning since the antrea-ca ConfigMap already exists.
Actual behavior
Warnings about failure to retrieve certificate, and consequently warnings about failure to start the watches.
Versions:
Antrea v0.9.0-dev

@antoninbas thanks for filing it, I think your analysis makes sense. ConfigMapCAController.RunOnce() seems useless as the cache is not synced for sure when it's called.
I think we could add a wait to networkPolicyController.Run to avoid the warnings.

Had a quick PR to fix it: #1042


Add github actions

Would be nice to have github actions just for the sake of it

I am not sure what that is sorry.

The actions tab here. It compiles the code automatically with every commit, making it easier to create new versions on curseforge/modrinth/whatever mod platform.

Don't bother with it, just compile it yourself.

Continuing conversation in the PR


Gradient and document.location.origin in Firefox

document.location.origin fails with 'undefined' and a broken URL is created
Can you please add this line to the addGradientFill  function:
   var url_origin = ( typeof document.location.origin == 'undefined' )?
        document.location.protocol+'//'+document.location.host :
        document.location.origin;

before:
$(o, {
fill: "url('" + url_origin + document.location.pathname + "#" + id + "')",
opacity: 1,
"fill-opacity": 1
});
to fix this problem?

Guy thank for solve this error  =)
I dont know if we have the same version of firefox, but in my firefox document.location.origin show as string 'null'
so this is code for my firefox version:
var url_origin = (document.location.origin == 'null') ?
document.location.protocol+'//'+document.location.host : document.location.origin;

@Dodotree try the fix from https://github.com/DmitryBaranovskiy/raphael/pull/1030


es6 build doesn't work

I'm submitting a ...  (check one with "x")
[x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

Trying to run build.dev  for es6 only build, followed instructions for #1348 added "moduleResolution":"node" to src/tsconfig.json
{
"compilerOptions": {
"target": "es6",
"module": "es6",
"moduleResolution": "node",
"declaration": false,
"removeComments": true,
"noLib": false,
"lib": ["es2016", "dom"],
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"sourceMap": true,
"pretty": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"noImplicitAny": true,
"noImplicitReturns": true,
"noImplicitUseStrict": false,
"noFallthroughCasesInSwitch": true,
"typeRoots": [
"../../node_modules/@types",
"../../node_modules"
],
"types": [
"node",
"jasmine",
"protractor",
"systemjs"
]
},
"exclude": [
"node_modules",
"dist",
"src"
],
"compileOnSave": false
}
build throw following error
TypeError: Cannot read property 'status' of null
at eval (lodash.templateSources[16]:9:15)
at DestroyableTransform._transform (C:\Users\mb0241\workspace\angular2\plant-at-risk\node_modules\gulp-template\index.js:21:40)
at DestroyableTransform.Transform._read (C:\Users\mb0241\workspace\angular2\plant-at-risk\node_modules\readable-stream\lib_stream_transform.js:159:10)
at DestroyableTransform.Transform._write (C:\Users\mb0241\workspace\angular2\plant-at-risk\node_modules\readable-stream\lib_stream_transform.js:147:83)
at doWrite (C:\Users\mb0241\workspace\angular2\plant-at-risk\node_modules\readable-stream\lib_stream_writable.js:347:64)
at writeOrBuffer (C:\Users\mb0241\workspace\angular2\plant-at-risk\node_modules\readable-stream\lib_stream_writable.js:336:5)
at DestroyableTransform.Writable.write (C:\Users\mb0241\workspace\angular2\plant-at-risk\node_modules\readable-stream\lib_stream_writable.js:274:11)
at DestroyableTransform.ondata (C:\Users\mb0241\workspace\angular2\plant-at-risk\node_modules\readable-stream\lib_stream_readable.js:546:20)
at emitOne (events.js:96:13)
at DestroyableTransform.emit (events.js:188:7)
Expected behavior

expecting es6 build
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

We only need es6 builds have no requirement for backwards compatibility
Please tell us about your environment:

Windows 7, VS Code 1.8 node 6.93, npm 3.8.6
Angular Seed Version:eb58638

Node: node --version = 6.93

Hey @mgbee8 thanks for giving the project a try. Build target ES6 is not officially supported by the seed project.
Probably sometime in the next a couple of weeks I'll implement this in order to perform bundling with rollup.
Let me know if you have progress with this, otherwise you can put your experiment on a hold until this task pops from my priority queue.
Good luck!

@mgbee8  @mgechev
Any news on this? I am also trying my luck on the moment.


[Snyk] Security upgrade tap from 11.1.5 to 15.0.0

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):

package.json
package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Prototype Pollution SNYK-JS-MINIMIST-559764
  137

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Prototype Pollution

:tada: Snyk checks have passed. No issues have been found so far.
:white_check_mark: security/snyk check is complete. No issues have been found. (View Details)
:white_check_mark: license/snyk check is complete. No issues have been found. (View Details)


Vec 341 config file support

The installer places the asvec.yml file in /etc/aerospike like other aerospike products.
There exists 2 new flags:

--config-file
--cluster-name (selects which context to use in the config file)

@hev adding you to review the default config that is installed
Can't be merged until https://github.com/aerospike/tools-common-go/pull/37 us merged and go.mod is updated

Codecov Report
Attention: Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.01%. Comparing base (49fd412) to head (d009f1f).

Files with missing lines
Patch %
Lines

cmd/root.go
84.61%
3 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   83.81%   84.01%   +0.19%
==========================================
  Files          41       41
  Lines        2775     2772       -3
==========================================
+ Hits         2326     2329       +3
+ Misses        348      344       -4
+ Partials      101       99       -2

Flag
Coverage Δ

84.01% <84.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[Feature Request] - Adding images (maybe other file types too) directly in Multi Tool

Can we have option to add images and maybe other file types too directly in Multi Tool UI itself, so user will be able to upload mix of pdf, image and other files and it will be converted to pdf on the fly before converting to final single pdf.

Duplicate of https://github.com/Frooodle/Stirling-PDF/issues/278
Do plan to support in future


Treats external packages as internal

Given the MWE at [1], when I run ufmt format, I expect the package provider to be above consumer as provider comes from an external package. However, it's just sorted alphabetically.
[1] https://github.com/chbndrhnns/mwe-ufmt-external

I suspect this has to do with your working dir and how you're running "ufmt format."  Especially if you have two projects in the same repo.
The first-party detection can pick at most one name, and I suspect it's picking zero.  See the implementation at https://github.com/facebookexperimental/usort/blob/main/usort/config.py#L113
See https://usort.readthedocs.io/en/stable/guide.html#tool-usort-known for how you can explicitly list first-party names (and disable first_party_detection if it behaves inconsistently for you).

You are right about behaviour; with this config it works fine:
[tool.usort.known]
first_party = ["consumer"]

And it works out of the box when sorting in the actual production package ("consumer").
Would it be an option to extend the auto-detection by leaving the "tests" or "test" package and see if its parent (the project name) is duplicated in the root directory? This way, sorting would also work in some more cases in the tests package without additional configuration.
Example:
"consumer" is the name of the project directory AND the name of a directory what you call "first_party".
consumer/
├── README.rst
├── consumer
│   ├── __init__.py
│   └── other.py
├── poetry.lock
├── pyproject.toml
└── tests
    ├── __init__.py
    └── test_consumer.py

Would it be an option to extend the auto-detection by leaving the "tests" or "test" package and see if its parent (the project name) is duplicated in the root directory?

Do I understand correctly that you're saying:
$ git clone https://github.com/example/foo
$ ufmt foo/tests # behavior change when foo/foo exists

I'm not immediately in favor, more because of it being magic than it being computationally difficult.  There are two core values that this doesn't go along with:

That formatting should be "universal" -- it should produce the same result on any OS, for any working dir, and for a git export vs live git checkout (thus only paths from the pyproject.toml down can matter).
That features should be easy to explain in docs, and their configuration should focus on user intent.

People can provide another arg to git clone so we can't rely on the dirname matching the original repo name.  There are also examples like

python-zstandard that has zstandard
poetry-core that has src/poetry/core

It's too bad package_dir and packages didn't become a part of PEP 621, as that would have provided a standards-based universal way to infer the main project name even for subdirs like tests.
What we do in usort (and many other projects that @jreese has been involved in) is put the tests under the main package.  I don't know if this works for your two-projects-in-the-same-repo case, but that (or tool.usort.known.first-party) would be my suggestions for getting this to work for you.

I understood that there is no universal standard which would my suggested behaviour work for most cases. So I am fine with configuring the first-party option to make it work.
Currently, I am using isort + black which seems to work without additional configuration wrt the package names. But maybe isort implements some magic here. I haven't checked the implementation yet.

Relevant isort code is

https://github.com/PyCQA/isort/blob/main/isort/settings.py#L458 (src_path appears to be the src/ type prefix, relative to where it found the config)
https://github.com/PyCQA/isort/blob/main/isort/place.py#L72

I don't follow what happens with the namespace section, but the rest is pretty much what I expect.
Ours is much simpler with the known escape hatch to be explicit about it.  See https://github.com/facebookexperimental/usort/blob/main/usort/config.py#L113


Glance json feed

@spra85 @MichaelButkovic @benghaziboy
New ingest feed for Glance
Based on https://s3.amazonaws.com/onionwebtech/sample-glance-onion.json

LGTM👍

Coverage increased (+0.2%) to 86.42% when pulling 5300d25ca3bd0532b09cacebd1d5f62fccc60968 on glance-json-feed into 71b078b6f6a9318de1d1035d5a77fcc35bb75d71 on master.

👍

Coverage increased (+0.2%) to 86.42% when pulling f4ac9044734074f91ae8ef2835138d11d60bc209 on glance-json-feed into 71b078b6f6a9318de1d1035d5a77fcc35bb75d71 on master.


Right-Click context menu

Feature Request
Problem description
For some menu's it makes sense to be able to use the native right click. For instance we use the Menu component to provide a navigation tabbar. It would make sense to be able to use right click -> open in new tab for this.

There are no plans to implement this as it can be easily reached by existing components: https://codesandbox.io/s/jvq3845nov

Right-click trigger on the Popup element would be nice, as a way to implement context menus.


linux_chromiumos_3_14: delete

A follow-up to 6a9e765e2741d94713d628a88b048c32762371f0 which deletes linux 3.14 due to it being unmaintained. Makes sense to drop 3.14 based chromiumos as well.

But maybe it's still maintained?

The chromeos-3.14 branch had its most recent change on Sep 17, so most likely it is.


how to using in ionic2?

@lidymonteirowm Great question. I haven't had a chance to look into this yet.


The database messed up after the wrong subgraph deploy

Describe the bug
Wrong subgraph deployments messed up some database tables. As a result, the messaging layer has not been working properly.
To Reproduce
Steps to reproduce the behavior:

Go to discord channel
Redeployed subgraph after finding the issue
A couple of tables haven't been properly synced. Go to datadog

Additional context
Add any other context about the problem here.

It was subgraph issue. after redeploying, it has been fixed. closing...


[FEATURES REQUEST] Can we use Thumbnail for Cover

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
Thumbnail Cover in Video can be great feature for user who want to find large collection of Music Videos like me in device, Using thumbnail can be used As Cover in Video file formats in mkv.
When user download any music video from YouTube and also has Thumbnail, user can easily to find Thumbnail Cover on the Video file.
User can decide it whether include it or exclude it.
Without use of Thumbnail can be hard to find Music Videos what user was looking for?
Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
Nil

--embed-thumbnail

-embed-thumbnail

How do I use this code? Can you provide a step by step.

yt-dlp --embed-thumbnail "URL"

replace URL with the actual url


[stable/oauth2-proxy] ADD http scheme to values, and template deployment and service

What this PR does / why we need it:
Adds option for using https from the oauth2-proxy pod
Which issue this PR fixes

fixes #17586

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

ping @Miouge1 @desaintmartin

We've just realized that --http-address=<IP_ADDRESS>:4180 is specified on the deployment as "commandline arguments" https://github.com/helm/charts/blob/master/stable/oauth2-proxy/templates/deployment.yaml#L41
So for tls/https you need to add a config that specifies http-address: "" and https-address: "<IP_ADDRESS>:4180" - note the https.


please create a new release

The current release 0.8.0 is 9 months old, and I would like to also update the MownStr dependency in the hdt library, which requires the newest state of Sophia.
Is it possible to publish a new release, e.g. 0.8.1, with the current state on crates.io?

Agreed, the fix to mownstr 0.3 warrants a new version

fair enough...
However, given the number of (breaking) changes that occurred since 0.8.0, I would rather call this new release 0.9.0 -- and push the pending changes on the 0.9 milestone to 0.10.
Would that work for you?

Works for me

Works for me too!

sorry for the delay, but I was not too far from completing the other issues of the 0.9 milestone, so I thought it was better to do them all. 0.9 is now released, which depends on mownstr 0.3 and is hopefully UB-free!


build-softlayer-centos6-x64-1 Out Of Space

https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-linux-x64-openj9/535/console
https://ci.adoptopenjdk.net/computer/build-softlayer-centos6-x64-1/
/home/jenkins/workspace/build-scripts/jobs/jdk11u/jdk11u-linux-x64-openj9/workspace/build/src/build/linux-x86_64-normal-server-release/vm/compiler/../compiler/env/J9CompilerEnv.cpp:65:4: fatal error: error closing /tmp/ccLE2w3N.s: No space left on device
    }
    ^
compilation terminated.

Current space usage - I've cleared out the PR tester directory for now so there's about 20Gb free on the machine at present
3.4G    build-scripts/jobs/jdk11u/jdk11u-linux-x64-corretto
5.1G    build-scripts/jobs/jdk11u/jdk11u-linux-x64-hotspot
4.6G    build-scripts/jobs/jdk11u/jdk11u-linux-x64-openj9
6.0G    build-scripts/jobs/jdk11u/jdk11u-linux-x64-openj9-linuxXL
4.0G    build-scripts/jobs/jdk14u/jdk14u-linux-x64-hotspot
5.2G    build-scripts/jobs/jdk14u/jdk14u-linux-x64-openj9
5.2G    build-scripts/jobs/jdk14u/jdk14u-linux-x64-openj9-linuxXL
2.4G    build-scripts/jobs/jdk8u/jdk8u-linux-x64-corretto
2.5G    build-scripts/jobs/jdk8u/jdk8u-linux-x64-hotspot-jfr
6.4G    build-scripts/jobs/jdk8u/jdk8u-linux-x64-openj9
5.7G    build-scripts/jobs/jdk8u/jdk8u-linux-x64-openj9-linuxXL
6.0G    build-scripts/jobs/jdk/jdk-linux-x64-hotspot

h


"/pex import sql" time out

PermissionsEx version: v1.23.1
Spigot version: fa7cbf9-00eba53
Using PermissionsEx with a SQL server and everything's working. Needed to manually edit the permissions (lots of changes to make).
I switched my backend to "file" so I can import the permissions from my SQL database and edit them manually. Restarted the server so the changed would take affect. Verified the backend properly changed to "file".
When I try to run "/pex import sql", the server times out.
Here's the error: http://pastebin.com/raw.php?i=hXcG5sSU

It doesn't time out -- just wait longer and the import will go through. That is just a warning printed
Large databases can take large fractions of an hour to convert to SQL.

I can't wait longer, though, since the server times out and stops.

There's an option in spigot to disable the timeouts.


R build fails on OSX Mavericks Machine

I've built MXNet on an OSX Mavericks machine without problems (all the Python examples run fine). However, I can't build the R package with R CMD INSTALL R-package. Running this gives the following error:
In file included from executor.cc:9:
././base.h:12:10: fatal error: 'dmlc/base.h' file not found
#include <dmlc/base.h>
         ^
1 error generated.
make: *** [executor.o] Error 1
ERROR: compilation failed for package ‘mxnet’

Also, I'm using R 3.2.2.

Please make sure you have initialized the git submodule and pulled dmlc-core

It is my fault. I forgot to update the building instruction.
@sbodenstein Please use make rpkg to generate mxnet_0.5.tar.gz, then R CMD INSTALL mxnet_0.5.tar.gz.

Great! It works now.


stepByStep should either automatically disable foreign keys or documentation should be slightly changed

Hey there, I hope you're having a lovely day!
The docs on migration from https://drift.simonbinder.eu/docs/advanced-features/migrations/ say the following:

always re-enable foreign keys before using the database by enabling them in beforeOpen.
disable foreign-keys before migrations

However, the generated stepByStep function doesn't include this, and the documentation providing an example of step-by-step migrations doesn't mention foreign keys at all:
    onUpgrade: stepByStep(
      from1To2: (m, schema) async {
        // we added the dueDate property in the change from version 1 to
        // version 2
        await m.addColumn(schema.todos, schema.todos.dueDate);
      },
      from2To3: (m, schema) async {
        // we added the priority property in the change from version 1 or 2
        // to version 3
        await m.addColumn(schema.todos, schema.todos.priority);
      },
    ),

I think either stepByStep should call PRAGMA foreign_keys = OFF (if that's ok to do?), or some info on foreign keys needs to be added to the step-by-step section of migration docs since I feel like it'd currently be easy to get confused or ignore this (which is probably bad?).
Thank you!

In the next drift version, we'll have a method to customize the stepByStep function by integrating it into a larger onUpgrade method. I've documented that in<PHONE_NUMBER>a602907cf125a87da43d9dee42fea9, also mentioning how it can be used to implement the tips you're referencing.
I'm not sure if stepBySteps should do that by default. It's probably useful, but we can't reliably know whether we're in a debug mode from a pure-Dart package I think. So we can't implement all the tips.


Fix README.md

It'll probably be user in another package.

Coverage remained the same at 66.327% when pulling bdc7c2f3041dadc8e3552adfb288926af41381b9 on rodrigomonteirof:rf-fix-readme into 062ff4817e9328d0a98bdcf6e3d13fd0d4e53e27 on wallstreetcn:master.


Upgrade calico-vxlan CNI plugin addon to v3.19.1

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Upgrade calico-vxlan CNI plugin addond to v3.19.1

/retest


When importing SDF deck, "Deck Img" isn't saved after server reboot.

Great module, thanks for sharing!
I came across a bug while setting things up.
When importing a SDF deck, and assigning a "Deck Img" from the "Import SDF" dialog, everything works as you'd expect during the current session of the VTT server. Dragging the deck onto the background it'll show the correct (the selected) deck image. All the cards show up as they should and appear to work as intended.
The bug comes up when you restart the server / campaign.
After a restart the selected card deck image no longer appears when you drag the deck onto the VTT background.
Instead it is replaced by the default image of a colored line representation of a card deck.
Checking the imported deck images in the campaigns folders "Deck" folder. The deck image was imported along with the cards into the folder.
It is simply not showing up anymore when you drag the deck onto the VTT background, as it did before restarting the server.
Tried this with a few decks in several campaigns, the same erroneous behavior happened in all cases.

What method are you using to import the decks? Checking because just tried several times in my game and it is maintaining the top of deck img. Want to make sure it isn't a particular method.

Yep, mine have dropped off now too. They are maintained through "Return to Setup" and even going between worlds, but as soon as you close out the application and come back it has no card top.
Devs: I believe it is probably something of you're only looking at the yaml? And the Card Top isn't part of that?


Error building Paradoxia Client.

pls help me, I can not build"
paradoxia >> build
[+] Host : <IP_ADDRESS>
[+] Port : 443
[+] Installation Name (.exe) : ParadoxiaClient.exe
[+] Installation Folder name : ParadoxiaClient
[+] Output file name (.exe) : file.exe
[?] Would you like to build with Icon? (Y/n) : y
[+] Icon Path (.ico) : /home/joker2020/Downloads/images.ico
[X] Error building Paradoxia Client.

This is caused by multiple defination error during build, I'm working on a fix for it. Thanks for reporting!

Following as I am suffering the same issue.

Reclone the latest or git pull. I have pushed a potential fix for this bug. Trying to test it now.

I just tested and it seems to be working now.
Requesting @phanthuthao to Confirm and close this.
Thanks guys.

@quantumcore - Just a sec and I will test my setup

Thanks so much for getting this resolved! Hopefully the poster will confirm as well.

Thanks so much

Thanks so much.
Vào Th 5, 12 thg 11, 2020 vào lúc 15:11 WreckITRalph <
<EMAIL_ADDRESS>đã viết:

Thanks so much for getting this resolved! Hopefully the poster will
confirm as well.
[image: image]
https://user-images.githubusercontent.com/12686164/98996913-a4805180-2501-11eb-912d-bc4a2087bb19.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/quantumcored/paradoxiaRAT/issues/7#issuecomment-726344477,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPKCFBHS23IO6VJFG7KZT3SPRFQDANCNFSM4TSYH6FQ
.


[#151004135] Create paas submit app

What
We want to allow potential tenants to signup and existing tenants to contact support via forms on our product page.
This paas-submit app renders HTML forms that can be embeded using iframes into the product page and writes the results into Deskpro on submit.
More info in the README and by viewing the index page of the running app.
Notes

It's a ruby/sinatra app as it may be handed to a more front-endy developer in the future.
The form itself is pretty simple right now, a future story is responsible for ensuring the fields are relevent.

How to review
You can deploy to your dev environment by modifying the manifest.yml to include the required DESKPRO_* environment variables or run locally using:
DESKPRO_TEAM_ID=1 DESKPRO_API_KEY=REDACTED DESKPRO_ENDPOINT=REDACTED make dev`

The index page of the app will show the HTML snippets required for embedding.
The /support form should create tickets in deskpro assigned to the correct team
The /register form should create tickets in deskpro assigned to the correct team
Ensure basic form styling and validation works
You should be able to clearly see how you might extend the forms with more fields
The embed snippets on the / page should work as expected
Successful submissions should generate real-time events in google analytics. (I created an account to test on the / page ... you could signup for a GA account and switch out the code to test it out).

Who can review
Not @chrisfarms nor @henrytk

I like what you've built!
I tried to embed the iframes in a separate website and got an error in Chrome's developer console: Refused to display 'http://localhost:9292/register' in a frame because it set 'X-Frame-Options' to 'sameorigin'.
Sinatra has built-in protection against XSS, part of which involves returning the X-Frame-Options: SAMEORIGIN header to prevent embedding it in iframes on other websites.
I found a StackOverflow post that suggests how to disable this. I think it's fine for now to disable this protection entirely, but in time we may want to whitelist the frontend apps using this.

🙌  disabled the "protection" ... a whitelist in future would be good idea.

@chrisfarms It doesn't look like your change took effect. I got things to work by changing config.ru to do:
require './app'
class App
    configure do
        set :server, :puma
        set :protection, :except => :frame_options
    end
end
run App

I think it might be cleaner to take the application out of App than to do that.

Okay found the issue, I was confused by the loading order of sinatra base vs the app itself 😖
...should be sorted now and added test.

Fabulous 👍

Out of interest, what was the problem with loading order? Is it that App extends Sinatra::Base in a separate import to that in config.ru, or similar?


Add some right padding in the last navbar link (contact)

Bug Report
Issue Summary
There should be some padding left in the navbar.
A summary of the issue.
Expected Behavior

I expected some more right padding in the right in contact item in navbar.
Observed Behavior

I observed that ...
Steps to Reproduce

Compile and run file with python3 abc.py
Goto ...

Screenshots (if any)

I want to work on this issue.

I wanna work on it.

i want to work on this

@kundanb go ahead. Sorry @Priyansh-09 @BLACK-PEARLL, @kundanb commented first.


ADD-Dummy-EAP-action

@jannisvisser @gulfaraz - seems like the CI checks while running npm test are failing due to missing SECRETS(MC_API), this is failing in master as well.
Please suggest the workaround to fix this.

@SwatiTh I believe we ran into this previously already as well. You need to add the same secrets as here (https://github.com/rodekruis/IBF-system/settings/secrets/actions) also in your own fork.
Or even simpler: stop using your own fork, and simply push to branches on the upstream repository.


Download cRAP

Adds the following functions (with appropriate tests and examples):

download_crap() wrapper function to download different types of contaminants databases. For now the only type available is type = "ccp" which will call the download_ccp_crap() function. Easily extendable in the future.
download_ccp_crap(), an internal function that will download an up-to-date version of the CCP cRAP database from the latest UniProt release
check_uniprot_release() just returns the latest UniProt release as a character e.g. "2021_01". I use this function when naming files I've downloaded
sub_crap() just adds cRAP numbers to a character vector e.g. turns sp|XXX|YYY into sp|cRAP001|XXX|YYY

Adds the following vignette:

crap.Rmd = brief discussion of contaminant databases, then shows how to use download_crap() and also how to use Biostrings to add your own sequences of interest to a cRAP FASTA file.

This PR now adds the following functions:

make_crap_fasta() which takes a character vector of UniProt accessions and a file path. It queries UniProt for the sequences and saves them into a fasta at the specified file path (with appropriate cRAP00X numbers if specified).
append_crap_fasta() which takes 2 file paths: one of the fasta to add, and another of the existing cRAP fasta to append to. It adds the sequences in the first fasta to the end of the second (with appropriate cRAP00X numbers if specified).
get_ccp_crap() which does not take any inputs and outputs a character vector of CCP cRAP UniProt sequences.
download_ccp_crap() wrapper function, input is a file path and the function downloads some sequences and saves it to the specified file path. Wraps get_ccp_crap(), make_crap_fasta(), and append_crap_fasta() in that order.

check_uniprot_release() just returns the latest UniProt release as a character e.g. "2021_01". I use this function when naming files I've downloaded

sub_crap() just adds cRAP numbers to a character vector e.g. turns sp|XXX|YYY into sp|cRAP001|XXX|YYY

Adds the following vignette:

crap.Rmd = brief discussion of contaminant databases, then shows how to use download_ccp_crap(), make_crap_fasta(), and append_crap_fasta().

Brilliant. If I may continue my suggestions, make_crap_fasta) can be used to generate a fasta for any set of accessions, right? Would this be better called make_fasta(), with argument is_crap replacing add_crap to specify that the entry names should be renamed to reflect their crappy nature. Ditto append_crap_fasta().
This would make it easy to add future functions to identify accessions for e.g all human swissProt, from which a fasta file could be generated using make_fasta(), which may also later need an argument to reformat fasta entries to make them the expect format for e.g PD fasta parsing.

Yes is_crap makes sense to me!
I don't quite understand your second point though.

 But with is_crap=F, they are applicable to any set of uniprot accessions. By making that explicit in the function names and argument, it's clearer that they can also be used if one wants to make a bespoke reference fasta e.g all human SwissProt proteins + transgenes etc

Ah I see what you mean.
I'll need to make it explicit in the make_fasta() docs that it can only be used for so many accessions at once time. To quote UniProt:

Very large mapping requests (>50,000 identifiers) are likely to fail. Please do verify that your list does not contain any duplicates, and try to split it into smaller chunks (<20,000) in case of problems.

Probably it would be good to write a function called download_proteome(id = "UP000000xxx", isoforms = FALSE, swissprot_only = TRUE) which would use a different httr query to download UniProt's already put together FASTA files which exist for many (but not all) species. I have a script that could be adapted for this.

Ah, yes, good points. Should definitely download reference fastas where they are available, as you suggest.
For now, I think it's fine just to rename functions & arguments so the above can be merged.

Alright I think this is it.
This PR now adds the following functions:

make_fasta() which takes a character vector of UniProt accessions and a file path. It queries UniProt for the sequences and saves them into a fasta at the specified file path (with appropriate cRAP00X numbers if is_crap = TRUE).
append_fasta() which takes 2 file paths: file1 = the fasta to append and file2 = the fasta to append to. It adds the sequences in the file1 (with appropriate cRAP00X numbers if is_crap = TRUE) to the end of file2 .
get_ccp_crap() which does not take any inputs and outputs a character vector of CCP cRAP UniProt sequences.
download_ccp_crap() wrapper function, input is a file path and the function downloads some sequences and saves it to the specified file path. Wraps get_ccp_crap(), make_fasta(), and append_fasta() in that order.

check_uniprot_release() just returns the latest UniProt release as a character e.g. "2021_01". I use this function when naming files I've downloaded

sub_crap() just adds cRAP numbers to a character vector e.g. turns sp|XXX|YYY into sp|cRAP001|XXX|YYY

Adds the following vignette:

crap.Rmd = brief discussion of contaminant databases, then shows how to use download_ccp_crap(), make_fasta(), and append_fasta().

Great. Nothing more from me :sweat_smile: