Fix duplicates in HTTP domains

if we have domains like {foo, foo.local}, the order we build matters. If
foo is first, we will build the foo virtual host, then the foo.local.
But if foo.local is first, we build a single virtual host with both
domains, and then a second one with empty domain.
This is broken for three reasons

Empty domain list is rejected by envoy
The behavior is nondeterministic. Should have stable Service ordering
You may explicitly want the non-expanded versions

name                               old time/op        new time/op        delta
RouteGeneration/gateways-6               44.3ms ± 1%        44.7ms ± 1%   ~     (p=0.667 n=2+2)
RouteGeneration/gateways-shared-6         177ms ± 4%         179ms ± 4%   ~     (p=0.667 n=2+2)
RouteGeneration/empty-6                   760µs ± 1%        1357µs ± 0%   ~     (p=0.333 n=2+2)
RouteGeneration/tls-6                     768µs ± 2%        1379µs ± 1%   ~     (p=0.333 n=2+2)
RouteGeneration/telemetry-6               791µs ± 1%        1426µs ± 0%   ~     (p=0.333 n=2+2)
RouteGeneration/virtualservice-6         1.70ms ± 1%        1.73ms ± 2%   ~     (p=0.667 n=2+2)

benchmark shows pretty major increase, but for these cases the numbers in microseconds so its pretty much negligible?

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

unit-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/hold
think there is a bug

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

unit-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

unit-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

unit-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

unit-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-telemetry-k8s-tests_istio

analyze-tests_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-telemetry-k8s-tests_istio

analyze-tests_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test analyze-tests_istio

unit-tests_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-telemetry-k8s-tests_istio

analyze-tests_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test analyze-tests_istio

unit-tests_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test unit-tests_istio

release-test_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test gencheck_istio

integ-distroless-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-distroless-k8s-tests_istio

integ-ipv6-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
db265a7361b0e25906c4476b2dbff73198b8b5db
link
/test integ-telemetry-k8s-tests_istio

analyze-tests_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test analyze-tests_istio

unit-tests_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test unit-tests_istio

release-test_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test release-test_istio

lint_istio
3cb26028d4d9bf2a5fd156e855cd5942404f9fb3
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Just one doubt: why donot we merge the virtualhosts of test.local:80 and test.80, they both has the same fields except the domains

Maybe we can, but it will be tricky since I don't think we have readily accessible info to know they can be collapsed. Its possibly theoretically but would be tricky

Maybe I can try to address it later.


[downloader/dash] Abort if the first segment fails

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

What is the purpose of your pull request?

[x] Bug fix
[ ] New extractor
[ ] New feature

Description of your pull request and other information
Unlike HLS, where each segment can be played directly, DASH segments need to be concatenated to generate a valid MP4 file. Especially, the first segment contains MP4 headers. So the downloaded file won't be recognized without the first segment.
Closes #10497

LGTM.

Thanks pushed to master.


Theme - Radio Buttons

Radio buttons are using the primary color theme whereas the mdc docs say they should use the secondary color theme

Can u verify if this was changed in the latest release?

How can I check?

there is a changelog for mdc-web

actually this should be purely on css... and we dont change anything in css... makes it strange


rene: Blacklist fairsearches.com

rene requests the blacklist of the website fairsearches.com. See the Metasmoke search here

Codecov Report

Merging #615 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #615   +/-   ##
=======================================
  Coverage   61.16%   61.16%
=======================================
  Files           5        5
  Lines        1043     1043
=======================================
  Hits          638      638
  Misses        405      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f704ee7...56e5c27. Read the comment docs.

Not seeing previous record of this in metasmoke, what prompted it?

@Undo1 prompted by a spam post not caught by Smokey, which Jon reported in SOCVR: http://chat.stackoverflow.com/transcript/message/36267500#36267500

That's the sole occurrence on SO, and we haven't seen it again in half a month. Closing.


MacOS runtime error (Unable to load shared library 'OpenCvSharpExtern' or one of its dependencies)

Summary of your issue
Hi
I tried use OpenCVSharp in my MacOS F# project. I added OpenCvSharp4.runtime.osx.10-15-x64  in my solution

Environment
MacOS 10.15.4, Visual Studio for Mac 8.5.6 (build 11)
Example code:

open OpenCvSharp

open System

[<EntryPoint>]
let main argv =
    let src = new Mat("cat.jpg", ImreadModes.Grayscale); // <<----- Exception is here
    // Mat src = Cv2.ImRead("lenna.png", ImreadModes.Grayscale);
    let dst = new Mat();

    let in1 = InputArray.Create(src)
    let in2 = OutputArray.Create(dst)

    Cv2.Canny(in1, in2, 50., 200.);
    use w1 = new Window("src image", src)
    use w2 = new Window("dst image", dst)

    Cv2.WaitKey() |> ignore

    0 // return an integer exit code

Output:

"Unable to load shared library 'OpenCvSharpExtern' or one of its dependencies. In order to help diagnose loading problems, consider setting the DYLD_PRINT_LIBRARIES environment variable: dlopen(libOpenCvSharpExtern, 1): image not found"

What did you intend to be?

Please check the dependencies of libOpenCvSharpExtern.dylib in runtime/osx-x64/native.
https://github.com/shimat/opencvsharp/blob/master/.github/workflows/macos10.yml#L21
https://github.com/shimat/opencvsharp/blob/master/.github/workflows/macos10.yml#L56

hi
i tried

brew install wget pkg-config mono-libgdiplus gtk+ ffmpeg glog yasm harfbuzz jpeg libpng libtiff openexr openjpeg metis openblas opencore-amr protobuf tbb webp
and then

otool -L libOpenCvSharpExtern.dylib
it says
"/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/objdump: error: 'libOpenCvSharpExtern.dylib': No such file or directory"
seems libOpenCvSharpExtern.dylib does't exists. how can i install it?
thanks

The OpenCvSharp4.runtime.osx.10-15-x64 NuGet package should place libOpenCvSharpExtern.dylib in the same directory as your executable file (.exe) or <exe directory>/runtimes/osx-x64/native/ . Does it exist?
https://github.com/shimat/opencvsharp/blob/master/nuget/OpenCvSharp4.runtime.osx.10.15-x64.nuspec#L27

Unfortunatelly no
I'm trying to use OpenCvSharp in my DLL module. The following images show you structure of my project and files inside DLL module. My DLL module called OpenCVView

Thank you

According to the image, there is a runtimes directory in OpenCvView/bin/Debug/netcoreapp3.1. Is there a libOpenCvSharpExtern in it? (runtimes/osx-x64/native/libOpenCvSharpExtern.dylib)
If so, please try copying OpenCvView/bin/Debug/netcoreapp3.1/runtimes/osx-x64/native/libOpenCvSharpExtern.dylib to OpenCvView/bin/Debug/netcoreapp3.1/libOpenCvSharpExtern.dylib .
Also, make sure that your application is running on x64, not x86.

Yes, i found libOpenCvSharpExtern.dylib and copied to folder with my dll module
It helped. Thank you very much!

I'm also on MacOs with exactly the same symptoms described here, but I've been stuck on this error for a while.

For those struggling with this on MacOS, I managed to get this working by including the libOpenCvSharpExtern.dylib into the Mac project head as a BundleResource. This ensure that it is placed in the Resources folder of the final app bundle within the bin folder, making it accessible for the Mac app to load.
The libOpenCvSharpExtern.dylib can be found within the runtimes folder of the OpenCvSharp4.runtime.osx folder within your projects packages folder.

Add dylib to project and set as BundleResource

Open apps package contents

Verify dylib is within Resources

@vlozhnikov @shimat Could we re-open this one? I'm having the same issue and am not able to resolve it.
My Environment:
MacOS Big Sur 11.6, Visual Studio Code v1.63.2, Visual Studio for Mac 2022 Preview v17.0 Build 5186
I've tried the following:

Installed OpenCV via Brew
Per @vlozhnikov's post I ran the following: brew install wget pkg-config mono-libgdiplus gtk+ ffmpeg glog yasm harfbuzz jpeg libpng libtiff openexr openjpeg metis openblas opencore-amr protobuf tbb webp
Per @shimat's comment, I copied the libOpenCvSharpExtern.dylib library to the root of the project
Per @matthewrdev I've set that file to Content so it's copied to the output during a build.
Here is my current output folder during a debug session:

However, still getting the error:

Any other thoughts?

These are the only options I have for marking the file as Content.

@atkinsonbg Since I posted this comment I've refined my approach a bit further.
First thing I've changed is to create a custom build targets to copy the dylib into the MonoBundle directory (where all macOS assemblies live).

Change the build action of the libOpenCvSharpExtern.dylib to None.

Create a new file in the root of the macOS project named libOpenCvSharpExtern.targets with a build action of None. Paste the following content into the file:
<!-- All msbuild target logic needs to be inside a project tag -->
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

	<!-- These targets will fire after mmp creates your bundle but before code signing -->
	<PropertyGroup>
	    <CreateAppBundleDependsOn>$(CreateAppBundleDependsOn);BundleOpenCVAssets</CreateAppBundleDependsOn>
	</PropertyGroup>

	<!-- Since this has inputs/outputs, it will fire only when the inputs are changed or the output does not exist -->
	<Target Name="BundleOpenCVAssets" Inputs="libOpenCvSharpExtern.dylib" Outputs="$(AppBundleDir)/Contents/MonoBundle/libOpenCvSharpExtern.dylib">
		<Message Text="Copying 'libOpenCvSharpExtern.dylib' and 'OpenCvSharp.dll.config' into '$(AppBundleDir)/Contents/MonoBundle/...'" />
	    <Copy SourceFiles="libOpenCvSharpExtern.dylib" DestinationFiles="$(AppBundleDir)/Contents/MonoBundle/libOpenCvSharpExtern.dylib" />
	    <Copy SourceFiles="OpenCvSharp.dll.config" DestinationFiles="$(AppBundleDir)/Contents/MonoBundle/OpenCvSharp.dll.config" />
	</Target>
</Project>

Open the macOS project file and add the following line beneath the Xamarin.Mac.CSharp.targets import:
<Import Project="libOpenCvSharpExtern.targets" />

If the following doesn't work, you'll need to track down which dependencies as missing using the macOS otool -L against the libOpenCvSharpExtern.dylib:
otool -L libOpenCvSharpExtern.dylib

Typically we (myself and a freelancer who works with me) have found that OpenCV doesn't work when:

ffmpeg is not installed. This can often be fixed by installing ffmpeg via home brew.
ffmpeg is installed but is not in the expected path. We've seen this happen on Apple Silicon machines as home brew seems to place ffmpeg in different locations on the different architectures.

At the moment I don't have a full solution for fixing either issue, however, I have written the following helper class that can check which OpenCV dependencies weren't found:
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Diagnostics.Contracts;
using System.IO;
using System.Linq;
using System.Reflection;
using System.Runtime.InteropServices;
using System.Text;

[assembly: DefaultDllImportSearchPaths(DllImportSearchPath.LegacyBehavior)]

namespace Ansight.Studio.Mac.Services
{
   public class OpenCvDependencyChecker : IApplicationLifecycleHandler
   {
       readonly Logging.ILogger log = Logging.Logger.Create();

       const string openCvLibaryName = "libOpenCvSharpExtern.dylib";

       public void Shutdown()
       {
       }

       public void Startup()
       {
           log?.Info("Verifying OpenCV dependencies");

           CheckFFMpegInstallation();

           log?.Info("OpenCV version is: " + OpenCvInterop.GetVersionString());
       }

       private void CheckFFMpegInstallation()
       {
           var assembly = Assembly.GetExecutingAssembly().Location;

           var assemblyFolder = Path.GetDirectoryName(assembly);
           var openCvLibaryFilePath = Path.Combine(assemblyFolder, openCvLibaryName);

           if (File.Exists(openCvLibaryFilePath))
           {
               var startInfo = new ProcessStartInfo()
               {
                   FileName = "otool",
                   Arguments = $"-L {openCvLibaryFilePath}",
                   UseShellExecute = false,
                   CreateNoWindow = true,
                   RedirectStandardOutput = true,
                   RedirectStandardError = true,
                   RedirectStandardInput = true,
                   UserName = Environment.UserName
               };
               var builder = new StringBuilder();
               using (var process = Process.Start(startInfo))
               {
                   process.WaitForExit();
                   builder.Append(process.StandardOutput.ReadToEnd());
               }

               var content = builder.ToString() ?? string.Empty;

               List<string> missingDependencies = new List<string>();

               if (!string.IsNullOrEmpty(content))
               {
                   var dependencies = content.Split('\n', '\r');

                   foreach (var line in dependencies.TakeLast(dependencies.Length - 1))
                   {
                       var filePath = line.Split('(').FirstOrDefault().Trim();

                       var fileName = Path.GetFileName(filePath);

                       if (fileName == openCvLibaryName)
                       {
                           continue;
                       }

                       if (!File.Exists(filePath))
                       {
                           missingDependencies.Add(line.Trim());
                       }
                       else
                       {
                           log?.Debug("The OpenCV dependency exists: " + filePath);
                       }
                   }
               }

               if (missingDependencies.Any())
               {
                   log?.Warning("Unable to locate 1 or more OpenCV dependencies.");
                   log?.Warning(string.Join('\n', missingDependencies));
               }
               else
               {
                   log?.Info("All dependencies are resolved for OpenCV.");
               }
           }
       }
   }

   public enum ExceptionStatus
   {
#pragma warning disable 1591
       NotOccurred = 0,
       Occurred = 1
   }

   static class OpenCvInterop
   {
       public const string DllExtern = "OpenCvSharpExtern";

       [Pure, DllImport(DllExtern, CallingConvention = CallingConvention.Cdecl, BestFitMapping = false, ThrowOnUnmappableChar = true, ExactSpelling = true)]
       public static unsafe extern ExceptionStatus core_getVersionString(byte* buf, int maxLength);

       /// <summary>
       /// Returns library version string.
       /// For example "3.4.1-dev".
       /// </summary>
       /// <returns></returns>
       public static string GetVersionString()
       {
           const int bufferSize = 128;

           unsafe
           {
               byte* buffer = stackalloc byte[bufferSize];
               core_getVersionString(buffer, bufferSize);
               var result = System.Runtime.InteropServices.Marshal.PtrToStringAnsi((IntPtr)buffer);
               return result;
           }
       }
   }
}

You'll need to adapt the above code for your own needs but it should get you started.


Set random number seed before test

Fixes #7201
Sets the random number seed before running any tests that set debugColorizeTiles so that a random color won't accidentally be white.
http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/clear-framebuffer-test/Specs/SpecRunner.html?spec=Renderer%2FFramebuffer

Thanks for the pull request @lilleyse!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:


Skewt_3

closes #271
Original NCL plot:https://www.ncl.ucar.edu/Applications/Images/skewt_3_2_lg.png
Python:

Just a note on the projection: from what I can tell, MetPy hasn't introduced functionality to add labels to the moist and dry adiabats or the mixing ratio, which is why they aren't labeled. I have a stackoverflow question open currently to see if anyone has found a way to add them, but when looking at the MetPy GitHub for this issue, it appears they haven't added the function yet (or there may be a work around that wasn't fully documented). Either way, the PR is ready for review as it currently is, but I wanted to document why there are no labels for the lines


Roll engine to 1ed25ca7b7e3e3e8047df050bba4174074c9b336

Changes since last engine roll:
1ed25ca7b Roll dart to f981f097602ca434ce0a36b1f704723cad105fb6 (#5390)
2b1f3dbe2 Roll src/third_party/skia e2343a1..6b6c47c (2 commits) (#5392)
32f49e41e Roll src/third_party/skia d433ee7..e2343a1 (1 commits) (#5391)
ecedff3a5 Roll src/third_party/skia 6857df7..d433ee7 (3 commits) (#5389)
080fbcb17 Build the embedder dylib and its unittests on Windows. (#5388)
37f456cac Fix file flags for directories and backslashes on Windows. (#5387)
b537231b7 Fix build issues for the embedder on Windows. (#5386)
8ebc81f4d Revert "Dart SDK roll for 2018-05-25" (#5384)
8caa7612f Create a shell with no GPU configurations unless explicitly specified by the platform. (#5383)
41620c9c0 Use common GrGLDefines instead of guessing platform specific headers. (#5381)
e07251b12 Roll src/third_party/skia 26c0e4c..6857df7 (6 commits) (#5380)
b067d79ce Copy embedder header to the out directory. (#5379)
193d873ca Revert "Added application callback" (#5377)
67f82eede Dart SDK roll for 2018-05-25 (#5376)
0e1966cd5 Reduce log spam: failing to find an instructions buffer isn't an error for ordinary core snapshots. (#5370)
a1a54ad1f Added application callback (#5369)
933d40610 Roll src/third_party/skia 71e83e8..26c0e4c (4 commits) (#5374)
e962e54c3 Roll src/third_party/skia c571504..71e83e8 (1 commits) (#5373)
2834f7e88 Roll src/third_party/skia 89cd4bc..c571504 (1 commits) (#5372)
03484cee1 Roll src/third_party/skia 20027ce..89cd4bc (2 commits) (#5371)
bbbd93028 Removed sync_async flag from engine which was causing snapshot errors. (#5367)
e25c70c64 Explicitly package vm and isolate snapshots on desktop and embedder targets. (#5368)

Red rope looks like flakes, so ok to merge on red.

It certainly looked like a flake, but is failing consistently now.
Not sure whether it's possible to ssh into the mac5 agent to troubleshoot remotely.

found instructions, retrying the test on mac5

It is still failing for me but with different error:
Building flutter tool...
.../flutter: line 158: 65444 Killed: 9               ( upgrade_flutter ) 3< "$PROG_NAME"
ERROR: Command ".../flutter config --no-analytics" failed with exit code 137.

It still looks unrelated to any commits - I'd ask @cbracken when we're all back on Tuesday.

I found an issue reported as a segmentation fault when running flutter test with breakpoints that seems to go away if I roll back to before this changeset. Details are here:
https://github.com/flutter/flutter/issues/17989
It only happens when there are breakpoints and the breakpoints don't get hit (I presume it's crashing as the breakpoint is hit). I don't know if this might be a big deal?


Trying to connect with the wrong atKeys results in a lot of errors

Is your feature request related to a problem? Please describe.
When an atSign has been "reset" and new keys are cut by a client, old clients break as they are using the wrong keys. This is particulary acute with atclients that send notifications first (at_talk as an example).
Describe the solution you'd like
atclient should delete entire local datastore if it detects that the public key on the server is not the same as the public key in its local datastore
Describe alternatives you've considered
No response
Additional context
No response

I will work with @purnimavenkatasubbu and @srieteja on this

The "reset" option is currently disabled in the staging and production dashboards.In order to debug the bug, We need the reset atsign option

You can test locally : tomorrow afternoon I will commit some scripts I use for testing which you can use to test reset scenarios
in the meanwhile - we should enable reset in staging - @athandle @naresh0689 can you do that please? (But it must remain disabled in prod for now)

Hi @purnimavenkatasubbu - see https://github.com/atsign-foundation/at_server/pull/1231 for some scripts I use to run things locally

@athandle @naresh0689 Can you re-enable reset in staging please? (But it must remain disabled in prod for now)

Hi @purnimavenkatasubbu - see atsign-foundation/at_server#1231 for some scripts I use to run things locally

Sure. I'll check

@athandle @naresh0689 Can you re-enable reset in staging please? (But it must remain disabled in prod for now)

I have a build to deploy after that I will move. If any thing urgent @gkc  then I gave reset in admin, I can give demo to you

Hi @purnimavenkatasubbu - see atsign-foundation/at_server#1231 for some scripts I use to run things locally

Sure. I'll check

I see that this scripts are for macOS. Mine is Linux

@purnimavenkatasubbu Indeed. However, they are bash scripts, with nothing OS-specific in them, so they should work on Linux

Logs after testing locally.
ErrorLogs.txt

@VJag and I are brainstorming an approach for this. Moving to the next sprint for implementation

Had to put the implementation on hold due to some unplanned work. Carrying this over to the next sprint.

My intial approach:
Introduce two methods to atClient:

isRemoteReset(): If the public key present in the LocalSecondary and the one on the RemoteSecondary are different the method throws an exception indicating that a reset has occurred.

resetLocalStorage(): This method will be the after-action for isRemoteReset(). If the remote is reset, the client-consumer(agent who has control of the client instance e.g. an app) should catch the exception and take user consent for local secondary purge. If the user consents for LocalStorage purge the directories of hive, commitLog and any other local data needs to be removed. The method resetLocalStorage() is responsible for this data removal.

When initializing an atClient instance, check if the remote has been reset. Purge LocalSecondary storage if a reset has occurred. This would be preferably in the AtClientManager.setCurrentAtsign() as this is currently used to instantiate an AtClient for an atsign.

The implementation of solution for this is https://github.com/atsign-foundation/at_client_sdk/tree/reset_local_secondary.
Currently testing this and discussing the validity of the approach with @VJag

Is this still being actively worked on?

I have an implementation ready in https://github.com/atsign-foundation/at_client_sdk/pull/1033. We need to discuss this in an arch call preferably. Will bring it up in the next arch call.

I was able to complete the fix and testing in PR68. The PR is being reviewed and this ticket will be closed once the PR has been merged.

Tested the fix in the PR by the following steps

Activated and authenticated an atSign through the onboarding_cli
Call  atClient?.deleteLocalSecondaryStorageWithConsent(
userConsentToDeleteLocalStorage: true);
Reset the AtSign from the dashboard
call atClient?.isSecondaryReset()

isResetSecondary should return true as the atSign has been reset, but here it returns null.


unreadable output

Hey, hope you're doing well!
More of an issue report I want to get some feedback here to be able to help a bit with the fix whenever possible as I think you are already aware of this behavior (as I can see in #17 roadmap for 0.6.1-1 release) so I'm wondering how this could be addressed because as far as I can see in the source code this would require a refactor in how is the output code being produced in the erde/compiler.lua file.

Are you already working on this? If so, how could I see the current progress to contribute?
Do you have any ideas on how to address this?

Cheers!

Thanks for the interest! The point in the roadmap is probably much more minor than you think, as I mostly plan to just name temporary variables to indicate their purpose and make minor tweaks to reduce the number of newlines introduced, but for the most part the raw output will still be quite illegible.
Currently, most of the compiled code is split into separate lines because Lua doesn't report column numbers in its error messages, so when mapping errors back to their original line numbers we need to guarantee that the mapping is not ambiguous.  The current implementation is somewhat naive in that it splits lines wherever an error could occur, but the benefit is that the compiler is very 'fire and forget', which keeps the code simple.
I have toyed with the idea of trying to be smarter with when newlines are introduced, depending on the provided Erde code (since we can still guarantee some non-ambiguous reverse mapping, but it will change depending on the code we are compiling). However, I have not pursued this idea greatly since I'm worried that it will introduce a lot of complexity into the codebase for little benefit (this would be quite a large change to the current compiler).
What I have recently started doing with some of my other projects is that I compile them with erde compile, and then run the compiled output through StyLua, since I don't care much about sourcemaps when distributing the compiled code. This seems to work very nicely and is maybe along the lines of something you are looking for? I think Erde trying too hard to make the output readable may be overlapping work best left to someone else, but I also understand that this possibly requires introducing another tool.

It would be nice to either have the output not look like it's being sucked into a black hole or to pass it into a formatter automatically


remove jquery from product.js

Following on from discussion in #138 and PR #122 #139  we should work to remove jquery from product.js

🤚 I'm currently working on this. Thanks for making an issue on it!


No query filtering support for EMR

Hello,
There is currently no support for adding query filter options on EMR. We are finding that on AWS accounts with many EMR clusters, we are going over our rate limits because there is no way to filter out all of the clusters we don't need in the query.
I have coded a solution and am writing the tests now. I will link my pull request to this issue once I am finished.

sounds good, i just reviewed our emr support and it seems a bit lacking. i'd like to support the query options you mention (days as relative date specification, and created-before, created-after), and additionally inspecting the configuration of the cluster, and the ability to delete. This is mostly fyi on future roadmap items on emr.

Currently, we only have a need for the "ClusterStates" filter, so that is the one I am applying at the moment. I will also be implementing the delete function in another pull request/issue.

Pull Request for this improvement is at https://github.com/capitalone/cloud-custodian/pull/487


metadata.finalizers: Invalid value: name part must be no more than 63 characters

Describe the bug
When I create a Knative eventing broker using a configmap with name ob-46b35be1-0165-441b-9158-a7ec08ad7a97 and namespace ob-1608dc1f-4139-49c5-ae22-afe73ed807d7 the Broker fails with
 reason: >-
        failed to add finalizer to ConfigMap
        ob-1608dc1f-4139-49c5-ae22-afe73ed807d7/ob-46b35be1-0165-441b-9158-a7ec08ad7a97:
        ConfigMap "ob-46b35be1-0165-441b-9158-a7ec08ad7a97" is invalid:
        metadata.finalizers: Invalid value:
        "kafka.brokers.eventing.knative.dev/ob-1608dc1f-4139-49c5-ae22-afe73ed807d7-ob-46b35be1-0165-441b-9158-a7ec08ad7a97":
        name part must be no more than 63 characters

Expected behavior
I think sometimes it is reasonable to use a uuid for a name and a namespace, so I would expect this to work. I think the prefix kafka.brokers.eventing.knative.dev is slightly longer than needed.
To Reproduce
kind: ConfigMap
apiVersion: v1
metadata:
  name: ob-468c0030-c45e-4ded-8c79-08cb1e455085
  namespace: ob-1608dc1f-4139-49c5-ae22-afe73ed807d7
data:
  auth.secret.ref.name: ob-468c0030-c45e-4ded-8c79-08cb1e455085
  bootstrap.servers: REDACTED
  default.topic.partitions: '10'
  default.topic.replication.factor: '3'
---
apiVersion: eventing.knative.dev/v1
kind: Broker
metadata:
  annotations:
    eventing.knative.dev/broker.class: Kafka
  name: ob-468c0030-c45e-4ded-8c79-08cb1e455085
  namespace: ob-1608dc1f-4139-49c5-ae22-afe73ed807d7
spec:
  config:
    apiVersion: v1
    kind: ConfigMap
    name: ob-468c0030-c45e-4ded-8c79-08cb1e455085
    namespace: ob-1608dc1f-4139-49c5-ae22-afe73ed807d7

Knative release version
release-1.1
Additional context
Add any other context about the problem here such as proposed priority

I think the prefix kafka.brokers.eventing.knative.dev is slightly longer than needed.
Not really sure that's the case. But that's not really the issue.

The issue is that we add a finalizer, calculated out of the actual name of the broker and the namespace.
Looking at your strings:

ob-1608dc1f-4139-49c5-ae22-afe73ed807d7
ob-46b35be1-0165-441b-9158-a7ec08ad7a97

They are already each 39 chars long.
I think the real issue is, we need to find a way that we do not end-up with way too long finalizer names, and perhaps change the algo for that a bit :sweat_smile:

/assign


Prometheus: change existing metrics from gauges to counters

It turns out that Counter's interface supports only Inc() and Add(). There is no Set() like in Gauge.
https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#Counter
The problem is that in the prometheus encode phase of the pipeline, we have only the final value of the counter and not its incremental delta. There is an option to read the current value of the counter and calculate the delta but reading the value is discouraged.

Prometheus metric types are optimized for fast updates, not for fast reads

https://github.com/prometheus/client_golang/issues/486#issuecomment-433345239
I see 2 options:

Adding a delta field in the extract phase and pass it to the add function of Prometheus counter.

Using CounterFunc to bind the prometheus counter with our custom counter as done here:
https://stackoverflow.com/a/57963829/2749989

@eranra @KalmanMeth WDYT?

It turns out that Counter's interface supports only Inc() and Add(). There is no Set() like in Gauge.

ברור

@ronensc I vote for (1) this does require more changes in the code but I feel that this is more "correct"

@ronensc with regards to your comment " restarts of the process is handled the same way by promethes (in both options the counter will start from 0 and the server will glue the inconsistency in promQL). "   --- I am more concerned with restart of the flowlogs2metrics process ... this should not reset the counter to zero, right ???

I think we should go with (2) using CounterFunc.
Option (1) feels wrong to me as it requires us to maintain the same state in 2 places (extract and prom_encode).
It also requires adding a new field to communicate the raw value (or values) that will be used exclusively by the prometheus encoder (the other encoders don't need it).
Also, we'll need to have some sync mechanism (producer/consumer) between the extractor and the prom encoder.
Option (2) would save us from all this complexity and hassle. AFAIU, restarts of the process is handled the same way by promethes (in both options the counter will start from 0 and the server will glue the inconsistency in promQL).

@ronensc with regards to your comment " restarts of the process is handled the same way by promethes (in both options the counter will start from 0 and the server will glue the inconsistency in promQL). " --- I am more concerned with restart of the flowlogs2metrics process ... this should not reset the counter to zero, right ???

I was talking about restarts of the fl2m process. In such cases, the counter will start from zero. But I don't see why is this a problem.
Reference from https://www.robustperception.io/how-does-a-prometheus-counter-work
A common question is what happens when the process restarts and the counter is reset to 0? rate() will automatically handle this. Any time a counter appears to decrease it'll be treated as though there was a reset to 0 right after the first data point.

@ronensc since each of those options will require just couple of lines in the code ... ... do you agree to create two PR's ... experiencing with the two options? we have end-to-end local deployment so it will be easy to see how those work.
One thing that I envision in the future is the code here: https://github.com/netobserv/flowlogs2metrics/blob/00c6bf911c9c9b89607f1a173a81536b4efba4cd/pkg/pipeline/extract/extract_aggregate.go#L31 will need to be enhanced and be more async, and thus I really do not know which solution is better for us (1) or (2) ...

Looking again at option (2), it's not trivial as I initially thought.
The management of the relevant state for the Counters is internally in the extractor (the aggregates field)
https://github.com/netobserv/flowlogs2metrics/blob/00c6bf911c9c9b89607f1a173a81536b4efba4cd/pkg/pipeline/extract/extract_aggregate.go#L27
The encoder is not exposed to this field. So we can't use exactly the following approach:
https://stackoverflow.com/a/57963829/2749989
The interface between the Extractor and the Encoder is that in each call to Encode(), the encoder receives a new map with the update-to-date value of the couter.
Theoretically we can hold a data structure in the prom-encoder to keep the latest values for each counter (it'll be updated in each call to Encode()) and bind the CounterFunc to that data structure.
But this introduces the same problem of option (1) of maintaining the same state in muliple places.
Maybe we should consider to change the interface between the extractor and the encoder? Maybe move the encoder as part of the extractor?


Try tracking fiber alternates during unmount

This PR:

Updates our RDT stub logic to try tracking a map of fiber => alternate during the unmount sequence, before React has a chance to null those out during deletion processing

I just confirmed that this (along with local RDT routine fixes I need to PR) successfully fixes the node ID mismatch issues we're seeing!


Frontend 139 carrousel testimonial public view home

Added carousel and testimonial feature to Home page
Utilized React Material UI Carousel library
Library source: React Material UI Carousel
Fixed CSS styles in CardLinkSection and Footer components

Ticket number: 139

unable to view your branch since it's on your own fork.

never mind I got it.

looks good. approved


Error in units

If i wanted to create for example a unit ohm/ampere it doesn't work
qty("0","ohm/ampere")
I have an error
Panicked with: "invalid unit: ohm"
But if i want to do them separately it works
qty("0","ohm")
qty("0","ampere")

Currently, this is intended behavior. Using / is reserved for the shorthand notation, and the full notation requires the word per instead.
So the two options are
qty("0", "ohm per ampere")
// or
qty("0", "O/A")

Now, whether that's sensible is another question. If you were confused by this, you're probably not the only one. I will consider changing this, and I'm open to pull requests.


ThisKeyword is not a type, only ThisType is

Replaces #15686
Ensures that we're always using ThisType for this in a type position, not ThisKeyword.

The reason we have a ThisType vs. just using ThisKeyword has to do with transformations and lexical this capturing. Without distinguishing between the two, computeTransformFlagsForNode can't distinguish between a lexical this and a this in a type position.


Create Plan for the testing Framework

Take away Trend Micros approach for the tests

In scicore under /scicore/soft/apps are all the applications and different versions precompiled. Will ask admins about pulling all the data.

see Testing_Framework.md


[SPARK-16291][SQL] CheckAnalysis should capture nested aggregate functions that reference no input attributes

What changes were proposed in this pull request?
MAX(COUNT(*)) is invalid since aggregate expression can't be nested within another aggregate expression. This case should be captured at analysis phase, but somehow sneaks off to runtime.
The reason is that when checking aggregate expressions in CheckAnalysis, a checking branch treats all expressions that reference no input attributes as valid ones. However, MAX(COUNT(*)) is translated into MAX(COUNT(1)) at analysis phase and also references no input attribute.
This PR fixes this issue by removing the aforementioned branch.
How was this patch tested?
New test case added in AnalysisErrorSuite.

Test build #61456 has started for PR 13968 at commit 18e7485.

cc @yhuai @cloud-fan @clockfly

Test build #61457 has started for PR 13968 at commit 9a1f711.

Test build #61456 has finished for PR 13968 at commit 18e7485.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61456/
Test PASSed.

LGTM

merging to master/2.0

Test build #61457 has finished for PR 13968 at commit 9a1f711.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61457/
Test PASSed.


Plumb a lock source to resolve error messages.

The Lockfile class already has a source field that callers of
LockedResolve.resolve will be able to pass in.

Thanks! It'd be great to update 435-448 too, those two errors.

It would not. That data does not come from any lockfile; so it's be noise. That data comes from Pex CLI flags.


[Feature Quest]: CommonJS build

In some cases, vite is running in commonjs and developers are not authorised to change it. eg. Same CodeSandbox container. This can cause an error to be reported:
Error [ERR_REQUIRE_ESM]: require() of ES Module /project/sandbox/node_modules/unocss-preset-daisy/index.js from /project/sandbox/vite.config.ts not supported.

unocss-preset-daisy should provided a CommonJS build and specify the values of import and require  in packages.json#exports like this.

When this first got popular, I released a dual package version, but later went back to ESM only as I don't see why projects can't use ESM when they are new enough to deploy UnoCSS. It's like rejecting const foo = 'bar' while using Array.prototype.at.
As for your case, I doubt CodeSandbox, being a fairly popular service, doesn't support ESM. It's more like a config mistake. Could you provide a reproducible link?

When this first got popular, I released a dual package version, but later went back to ESM only as I don't see why projects can't use ESM when they are new enough to deploy UnoCSS. It's like rejecting const foo = 'bar' while using Array.prototype.at.
As for your case, I doubt CodeSandbox, being a fairly popular service, doesn't support ESM. It's more like a config mistake. Could you provide a reproducible link?

Repro:

vite-react-ts-temaplte: https://codesandbox.io/p/sandbox/q4fmnk?file=%2Fvite.config.ts%3A5%2C48&utm_medium=sandpack
vite-react-template: https://codesandbox.io/p/sandbox/6f3gwy?file=%2Fvite.config.js%3A16%2C1&utm_medium=sandpack

Note that changing vite.config.js or vite.config.js to vite.config.mjs seems to work, but in reality it will only work within CodeSandbox website itself, not if you use sandpack.

you can use import 'daisyui/dist/full.css'; in main.ts

you can use import 'daisyui/dist/full.css'; in main.ts

Yes I can do that. But the reason for using this plugin is that I want the packaged files to be as small as possible, otherwise why would I use vite?


ensure celery works in production

What type of PR is this? (check all applicable)

[ ] Refactor
[ ] Feature
[ ] Bug Fix
[ ] Optimization

Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.
Added tests?

[ ] yes
[ ] no, because they aren't needed
[ ] no, because I need help

Added to documentation?

[ ] readme
[ ] no documentation needed

[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

What's still pending,

Creating a table in dynamodb (global) which checks how many people's cards are still pending to be created.
During signup there should be a way to ensure that all upload of last day has been completed. Creation of cards should only be possible post that. Also, have a different queue to manage uploads. Explore AWS lambda for the same. Right now it is assumed that in 30 seconds all the history will be uploaded while often it is much less time than that, which results in no cards.
Allow functional templates for different types of cards (graph of specific domain over days), [domain -> visits], the rabbithole graph on a specific topic, cards that are repeated over and again


Implement a Listing abstraction

Checklist:

[X] Code contains relevant tests for the problem you are solving
[X] Ensure all new and existing tests pass
[X] Update any relevant READMEs and docs

Description:
This PR implements a "Listing" object that can be used as a stable interface exposed by origin-js to the DApps for accessing listing data.
For context, I realized I needed something like this to be able to roll out the new listing schema and after talking with @tyleryasaka and @micahalcorn it turned out it was something they were already thinking would be good to have in place.
Notes:

The new core listing schema is used to store data in IPFS.
The concept of "schema adapters" allows to load listing stored using old schemas. This makes it possible to support backward compatibility. There is no support for forward compatibility - it seems reasonable that a DApp developer would have to upgrade her origin-js version in order to interact with listings created with a new version of the schema.
The code that reads and writes listing data to IPFS is encapsulated in a ListingIpfsStore class. This should make it easy to swap a different type of storage if needed in the future (ex: filecoin ?)
The Listing object directly inherits from a variety of properties that are read from the blockchain (ex: offers, events, status, etc...). These properties are likely to change in future versions so ideally they should get abstracted. To keep the scope of this PR manageable, let's have discussions and handle this as a separate PR.

There is a number of changes that will be required on the DApp side to use this new Listing interface, including:

Some renames to use the fields 'title', 'category', 'subCategory'
Updates for using the Money object for price, commission and securityDeposit

I like it.
Schema looks nice.
I guess throwing is the right way to go for validation errors, since those would really be a programatic error, rather than a user error at this level.

@nick As FYI since he wrote a lot of the marketplace code.


f-string contents aren't formatted

Formatted expressions in f-strings are regular Python code. They should be formatted as such.
Example done by MagicPython (opening f" highlighted by me):

Oh wow I had no idea python had string interpolation! Thanks for the heads up.

Max, can I catch you anywhere on IM so we can talk about this for a minute? I'd like to help with this.

I'm @llanga on Twitter for example.


Add codecov badge

Codecov Report

Merging #98 (c69a0cf) into main (99d2e73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   92.72%   92.72%
=======================================
  Files          30       30
  Lines        4149     4149
=======================================
  Hits         3847     3847
  Misses        302      302

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Feature/responsive esp

[x] Make ESP page Responsive
[x] Make Model page Responsive
[x] Make Scenario page Responsive
[x] Create filters dropdown component
[x] Make table scrollable

Extra:
Fix prop-type warning

Fixed collapse destination and changed responsive table. Let me know if works for you


"must invoke its pause() method"

https://mediasession.spec.whatwg.org/#indefinitely-pause

must invoke its pause() method

We should not invoke public methods from prose as they can be overridden by script. Please instead invoke the algorithm pause() invokes directly. This might involve filing a bug on the relevant specification to give that algorithm a name.

This also applies to the play() method.

https://html.spec.whatwg.org/#internal-pause-steps kind of works, but there's nothing for play().

In the conformance section we say the following:

When a method or an attribute is said to call another method or attribute, the user agent must invoke its internal API for that attribute or method so that e.g. the author can’t change the behavior by overriding attributes or methods with custom properties or functions in JavaScript.

Does this not cover your concern? I agree it would be good to give internal algorithms names. I will file a bug for this.

That kind of wording is a hack imo. We shouldn't rely on it long term.

Closing this issue since we are moving audio focus out to a separate API.

This issue was moved to WICG/audio-focus#23


📎 Implement json.parser.allowTrailingCommas

Description
As reported in #83, some config files support trailing comma.
json.parser.allowTrailingCommas: true enables trailing commas in json and jsonc files, making the following example valid:
{
  "prop1": [
    1,
    2,
  ],
  "prop2": 0,
}

Similar to json.parser.allowComments, json.parser.allowTrailingCommas: true should be enabled by default when parsing files such as tsconfig.json, VSCode config files, and others?

I'm working


error when url is in a separate content source

the autospinstaller script generates an error if an URL has been moved from the default SharePoint content source to a custom content source.

fixed with #8c3492c


Add host request fence when manycore endpoint credits run out

Thanks Leonard! Does this pass in cosim?

yes, the library cosim regression passed.

@tommydcjung, can you take a look at this as well?


[Feature request] Share link view/edit

When I share link with people outside Nextcloud, they can only download the file. It would be great to allow them to see and edit file with ONLYOFFICE. Something like this https://nextcloud.com/blog/nextcloud-introduces-anonymous-editing-with-collabora-online/
//edit - sorry for duplicate

https://github.com/ONLYOFFICE/onlyoffice-owncloud/issues/20#issuecomment-287050633


No map at the beginning

Description:
No map at the beginning
Build:
<IP_ADDRESS>
Type:
IMPORTANT
Steps to reproduce:
._.
Frequency:
always

Present on recent Design scene


PascalCase matches one word

The help says Currently, this augend does NOT recognize identifiers that consist of only one word.,  but PascalCase matches to the word starts with capital letter like 'Word' and 'WORD'.
This is a minimum setting to reproduce ↓
lua << EOF
local augend = require("dial.augend")
require("dial.config").augends:register_group{
  default = {
    augend.case.new{
      types = {"camelCase", "PascalCase"},
    },
  },
}
EOF

In this GIF, dial.nvim thinks that 'EOF' is PascalCase ↓

Thanks for the report. You are right, it is inconvenient.
However, I am not sure how to solve this problem, because it is not obvious how to handle a sequence of uppercase letters in PascalCase.
For example, if I want to change the word "LicenseMIT" from PascalCase to snake_case, how should that be handled? What about the case of "ParseCLanguage"?

Using Regex Lookahead, a sequence of capital letters can be considered a single word.
Here is an example in JavaScript:
const regex = /[A-Z]([A-Z](?![a-z]))+|[A-Z][a-z]*/g

'LicenseMIT'.match(regex)
// -> ['License', 'MIT']

'ParseCLanguage'.match(regex)
// -> ['Parse', 'C', 'Language']

'JSONToYAMLConverter'.match(regex)
// -> ['JSON', 'To', 'YAML', 'Converter']

In this case, however, there are some probrems.

The capital parts cannot be restore once convert to snake_case: LicenseMIT -> license_mit -> LicenseMit
The sequence of capital-only-word cannot be detect: JSONYAMLConverter -> jsonyaml_converter

It is a difficult problem and it may good to ignore the word that has a sequence of capital letters.
I reported this issue because the behavior was different from the help.

Yes, as you say, the current implementation is compatibility oriented.
However, the word detection algorithm could use a little more improvement. It may be possible to sacrifice compatibility for greater convenience.

@monaqa A "potential" solution/workaround could be to implement something similar to ActiveSupport::Inflections#acronym and then keep the current algorithm as it is 🤔


Follow up with SpaceX

visualization site (hourly aggregates)
interconnection report & details about NSW paper
details about how NDT works
send info on using BQ
signup, sample queries, external tools, etc.

incorrectly added to this repo


JS Script Async

Is it better to put script before end of body tag? Because some mobile devices seem to have some problems with this script.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d56ecb14-9e66-5313-a381-d2824ec3d1e2
Version Independent ID: ff056ac8-ae76-be10-6895-757333a28e05
Content: Azure Application Insights for JavaScript web apps
Content Source: articles/azure-monitor/app/javascript.md
Service: application-insights
GitHub Login: @mrbullwinkle
Microsoft Alias: mbullwin

I had to remove AI script completely because page doesn't end loading if AI script is present on some iOS devices.

@serkanyazicioglu Thank you for your question. We will investigate this issue and get back to you at the earliest.

@serkanyazicioglu Can you please share if you are seeing any error by placing the script before the closing  tag ?

@serkanyazicioglu As per current documentation  the recommendation is to put the [script] (https://docs.microsoft.com/en-us/azure/azure-monitor/app/javascript#add-the-sdk-script-to-your-app-or-web-pages) code immediately before the closing  tag.
If you are seeing this issue happening consistently , we would like to work with you directly. Please send us an email to<EMAIL_ADDRESS>with your Subscription, Application insights instance, error details and a link to this thread so we can verify and direct the request accordingly. We'll continue to investigate this with you directly and will update the thread with any findings that may help others.
If you have any questions regarding the documentation, please tag me in your reply and we will be happy yo continue the conversation.

@serkanyazicioglu Just to tag onto the response to this one. There are other approved methods of initializing the JavaScript SDK depending on your implementation. You can read about them here: https://github.com/Microsoft/ApplicationInsights-JS#initializing-application-insights-js-sdk-script.
If you can describe your issue in a way that our engineering team could repro with the SDK you can also open an issue against the JavaScript repo here: https://github.com/Microsoft/ApplicationInsights-JS/issues.


crane-gps-watch: init at 20160308

Motivation for this change
New pkg -  small piece of software for creating .gpx files from various GPS watches.
Things done

[X] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Added myself as maintainer in the package and in lib/maintainers.nix.

Added a few more notes. When they have been addressed, please rebase and squash the commits into one.

Please squash into a single commit.

I changed the version number. There is a python2 script, which requires vte with python support and pygtk.
From e4b07527ab892ce5d362cc2798bdab941c57f2a9 Mon Sep 17 00:00:00 2001
From: Edd Baxter<EMAIL_ADDRESS>Date: Sun, 21 Aug 2016 01:39:03 +0100
Subject: [PATCH] crane-gps-watch: init at 2016-03-08
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Jörg Thalheim<EMAIL_ADDRESS>---
 lib/maintainers.nix                                |  1 +
 pkgs/applications/misc/crane-gps-watch/default.nix | 20 ++++++++++++++++++++
 pkgs/top-level/all-packages.nix                    |  2 ++
 3 files changed, 23 insertions(+)
 create mode 100644 pkgs/applications/misc/crane-gps-watch/default.nix

diff --git a/lib/maintainers.nix b/lib/maintainers.nix
index 08d6c8a..a2790c2 100644
--- a/lib/maintainers.nix
+++ b/lib/maintainers.nix
@@ -12,6 +12,7 @@
   abbradar = "Nikolay Amiantov<EMAIL_ADDRESS>   aboseley = "Adam Boseley<EMAIL_ADDRESS>   abuibrahim = "Ruslan Babayev<EMAIL_ADDRESS>+  AcouBass = "Edd Baxter<EMAIL_ADDRESS>   acowley = "Anthony Cowley<EMAIL_ADDRESS>   adev = "Adrien Devresse<EMAIL_ADDRESS>   Adjective-Object = "Maxwell Huang-Hobbs<EMAIL_ADDRESS>diff --git a/pkgs/applications/misc/crane-gps-watch/default.nix b/pkgs/applications/misc/crane-gps-watch/default.nix
new file mode 100644
index 0000000..d637478
--- /dev/null
+++ b/pkgs/applications/misc/crane-gps-watch/default.nix
@@ -0,0 +1,20 @@
+{ stdenv, fetchFromGitHub }:
+
+stdenv.mkDerivation rec {
+  name = "crane-gps-watch-${version}";
+  version = "2016-03-08";
+  src = fetchFromGitHub {
+    owner = "mru00";
+    repo = "crane_gps_watch";
+    rev = "221f99dc2925a07658f7b6e01789ced1a18cc08c";
+    sha256 = "0ji50yg85a114pdvw8k5jgfxq312frlxq67bazfaws9mkhnkpi9v";
+  };
+
+  meta = with stdenv.lib; {
+    inherit (src.meta) homepage;
+    description = "Crane GPS Watch client";
+    license = stdenv.lib.licenses.gpl3;
+    maintainers = [ maintainers.AcouBass ];
+    platforms = platforms.linux;
+  };
+}
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 5132a67..92ffc3c 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -748,6 +748,8 @@ in

   cpulimit = callPackage ../tools/misc/cpulimit { };

+  crane-gps-watch = callPackage ../applications/misc/crane-gps-watch { };
+
   contacts = callPackage ../tools/misc/contacts { };

   coturn = callPackage ../servers/coturn { };
--
2.10.0

@AcouBass ping?

@AcouBass ping?

Closing as abandoned.


Create a sensitivity and significance test as a part of the analysis pipeline.

The idea is that for each AR1 moving window analysis we run a sensitivity and significance test on that residual time series.
The output should be something like figures 10 and 11 in this paper.
They quote an R package that does the tests. The code might not translate directly to our analysis but we can use it as an inspiration for writing our own functions. Specially these two functions.

Sensitivity: https://github.com/earlywarningtoolbox/earlywarnings-R/blob/master/earlywarnings/R/sensitivity_ews.R
Null hypothesis (surrogate samples): https://github.com/earlywarningtoolbox/earlywarnings-R/blob/master/earlywarnings/R/surrogates_ews.R

Yesterday I spent a few hours playing with the earlywarnings-R package. As I mentioned, it runs almost out of the box from the time series files that we save after processing and it does the default AR1 rolling window analysis, plus the sensitivity and null hypothesis analysis.
One thing we are considering is to plug the package to rveg, so with that in mind here are some comments of my experience with the package.
Pros:

After some quick comparisons, the code seems to reproduce the results we obtain in our analysis (good cross-check of our analysis too).
Code is already written and has everything we need for the statistical analysis and more
Plots are quite nice.
The code is simple, well documented and I think easy to extend.
Seems to be in CRAN (although I didn't manage to find it, but didin't try to hard).

Cons:

Is in R.
Although is in CRAN I don't think we can blindly trust it (as we would do with a library from sckitlearn), is at least 6 years old and doesn't seem to be supported. We would need to adopt the code and adapt it.
The code could be better, is not very modular and some of the functions just repeat the same thing again and again.
We won't be able to do the smoothing on the sub-image level, but on the average time series. I don't think it changes things much thought.
We loose some of the work we already done in the analysis side.

If we were to use the code:

I think we would have to extend the code to fix some minor issues that bother me.
We could fork it and add it to rveg (giving the proper acknowledgments, but consider that they do not have a licence and i'm not sure what would that mean for submitting our code to JOSS). Of we can fork it and develop it in another repo.
Will have 3 pipelines: download, time-series analysis, resilience analysis, all file-based.

If we were to translate the code to python:

Re need to refactor the analysis code a bit, in any scenario is important to be able to do the smoothing and rolling window in the same place to do the sensitivity and null hypothesis test.
Improve our figures, I think we should use the earlywarnings-R style.
Add extra indicators, we are currently only using AR1 and variance but there are more.

Im lightly inclined into translating it into python, however I think this will be almost double the work and between Nick duties in DECOVID, me starting a new project and Sam leaving in a few weeks I don't think we have too much time to spare.

Hi @crangelsmith, thanks for giving your thoughts! While I agree it would be nice to have everything under the same roof, I agree that at this stage perhaps we need to prioritise doing the analysis rather than building the most awesome analysis tool.
What are the things we would need to extend/fix in the earlywarnings package if we went down the forking route? Do you have an idea of roughly how much time this would take vs rewriting in Python? (Bearing in mind a bit less experience in R vs Python (for myself at least)). I think if we don't implement the package in Python, we should be sure we are actually getting the benefits of this: i.e. not spend too much time forking/fixing the R package.

Thanks @samvanstroud  for your thoughts, answering your questions, I see two levels of work:

Minimal:

Connect the package to the pipeline, whether this is calling it from CRAN, or copying it ourselves in our repo or forking it in another repo and the calling it into our repo.
Write a script that runs the functions on the time series that get produced on the analysis script.
Improve the plots axis (right now the x axis is the time series index position and not the date).

Less minimal (I can't come up with a better word hehe).

We could work the repo and refactor the code to make it better, improving the plots and the modularity of the code. We could even at the end make a PR to the original repo, which would be a nice contribution to an open source project.

I think the minimal will take from few hours up to a couple of days, the other one can take as much as we want.

Now, I just found this package, which does the resilience analysis, but not the sensitivity analysis. https://github.com/ThomasMBury/ewstools
(this package looks better maintained, and I think the author was in CW20).

My first reaction would be to support translating it into python - it seems this is a gap that we could fill with a package that would be genuinely useful for other people, and we're in a really good position to do this...  Plus for sure translating and cross-checking the code is a great way to make sure we really understand it.
However, I also agree that we need to spend some time on doing the analysis.
I don't have a strong opinion - personally mild inclination that we should translate it to python, but whatever we choose I think we should be ready to change our minds if the R code is too annoying, or if the Python code is taking ages to write...

My opinion is also not super strong opinion so sounds like the consensus is to re-implement in Python :)

Ok, so I think what we have to do in the python implementation is:

Refactor the analysis code to have separate modules for the time series analysis processing (building the time series, resampling them, remove seasonal cycle) and the resilience analysis (smoothing, residuals,AR1, etc).
For the general resilience analysis we can use the ewstools package, which does all the analysis as the R code and includes a number of indicators.
From the ewstools general resilience analysis main function build the the sensitivity and null hypothesis implementation.
Improve the plot of the resilience metrics, in the use the earlywarnings-R style.


Adjust Travisfile to install required jmespath dependency per operator-sdk #2023.

Please see https://github.com/operator-framework/operator-sdk/issues/2023 for more details.

Merging this one since it is the same change which was reviewed and applied for more than one maintainer here.


Warning: Unable to fetch all az cli versions

Warning: Unable to fetch all az cli versions, please report it as an issue on https://github.com/Azure/CLI/issues. Output: ***
"name": "azure-cli",
"tags": [
"0.10.0",
"0.10.1",
"0.10.10",
"0.10.11",
"0.10.12",
"0.10.13",
"0.10.14",
"0.10.2",
"0.10.3",
"0.10.4",
"0.10.5",
"0.10.6",
"0.10.7",
"0.10.8",
"0.9.10",
"0.9.13",
"0.9.14",
"0.9.15",
"0.9.16",
"0.9.17",
"0.9.18",
"0.9.19",
"0.9.2",
"0.9.20",
"0.9.4",
"0.9.5",
"0.9.6",
"0.9.7",
"0.9.8",
"0.9.9",
"2.0.24",
"2.0.26",
"2.0.27",
"2.0.28",
"2.0.29",
"2.0.31",
"2.0.32",
"2.0.34",
"2.0.37",
"2.0.38",
"2.0.41",
"2.0.42",
"2.0.43",
"2.0.44",
"2.0.45",
"2.0.46",
"2.0.47",
"2.0.49",
"2.0.50",
"2.0.51",
"2.0.52",
"2.0.53",
"2.0.54",
"2.0.55",
"2.0.56",
"2.0.57",
"2.0.58",
"2.0.59",
"2.0.60",
"2.0.61",
"2.0.62",
"2.0

Hi @vn0siris, this is a duplicate issue of #153, which has been fixed in #154. You can point to master branch as a temporary workaround. I will inform you once the new version is released.


Remove dead code

Seems this code is tested but unused. Assuming no magic is going on, it is better to remove it.

I agree. Creating a feature branch for this one


When you format an SD Card, the text is "Formating" instead of "Formatting".

Obviously not high priority, but probably something to fix.
To replicate, just put in an SD Card with a format other that exfat and go format it under Recording Options

has already been fixed, https://github.com/hd-zero/hdzero-goggle/commit/c0a3191ec17942dad6f3e9737499d9c0dbb94b89 should rollout with the next update.

 Alright, good to know it's fixed.


Adding language definition argument

I have seen that the auto-detection of languages does not work very well for some of the more obscure languages.
This PR adds a language argument so that the input language can be set directly at the command line.

When will this PR be merged into main ? It is quite useful. Thanks in advance.


When I use a VPN to connect to the database on my computer, DBeaver cannot connect to the database. Can you tell me why?

When I use a VPN to connect to the database on my computer, DBeaver cannot connect to the database. Can you tell me why?

hey，i need help :)

there is no update on issue more than a month.
Ticket closed.
If issue still reproducible for you - feel free to reopen the ticket

Hi! I can't seem to connect to our office database using dbeaver in mac. I am using a IPsec vpn to access our database in windows in dbeaver as well. But in mac environment I cant. Please help

i have the same problem in mac environment! the err is connection time out every time

嗨@EasyProgramming，
很抱歉收到您的回复。
您可以重置出现的日志或错误吗？
https://github.com/dbeaver/dbeaver/wiki/日志文件

hi,the problem desc:
Communications link failure
The last packet sent successfully to the server was 0 milliseconds ago. The driver has not received any packets from the server.
connect timed out
connect timed out
i can use our vpn client to connect my company's ip,but Dbeaver can't


dropdown lists?

where is the code to add dropdowns populated from database?
this is shown in screenshot but not mentioned in tutorial!?!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03221075-5dfa-d1b6-0552-3fe88abe1d03
Version Independent ID: b8c7d824-35ca-68fb-e3be-839ae886657c
Content: Part 4, work with a database
Content Source: aspnetcore/tutorials/razor-pages/sql.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

It's there, keep going


SQL And Drupal Skip admin set up (saying that Drupal already installed)

I filled out the Database name, Database username, password, and port number within the Drupal set up. I selected continue, then the page loads for a long time. Next, I was leaded to another page saying, Drupal already installed. Next, I clicked on View your existing site, displaying the log in for the admin. Drupal literally skipped the admin set up, resulting in not allowing me to log in as admin.  Anyone is familiar with this error? Is this even an error, or the norm for Drupal (since I seen other users experiencing this errors, but no answers)?

@riky93 This does not see to be a PHP SQL Server Driver issue. Seems like a Drupal Setup issue. May be @david-garcia-garcia or someone from the https://github.com/drupal/drupal can help?

Thanks @meet-bhagdev, however Drupal said the following when looking at the error
Error
The website encountered an unexpected error. Please try again later.
Drupal\Core\Config\UnmetDependenciesException: Configuration objects (automated_cron.settings,
This error seems to be the one preventing me to the admin set up page. David Garcia (2016) discussed that anything breaking the batch API will lead to the error. I am trying to find  out how I can prevent any breakage so I can access the admin set up page. So far no progress.

UPDATE!!
I managed to install drupal. What happened was I decided to use Chrome. I add the information within the Drupal installation set up page. It loaded for a long time. Then it lead me back to the installation set up page again. I included the information. I then click save and continue. It lead me to a page saying Drupal is installed already. Then it automatically loaded to a page saying, Drupal installing displaying a installation bar. Then it finished installing leading to an error page. I refreshed, and it loaded to the admin page. I included the site name, Username, and password. I click save and continue. It loaded me to another error page (Saying Error: Call to a member function setRecipients() on null in standard_form_install_configure_submit() (line 25 of core\profiles\standard\standard.profile).).
So I removed the install.php link in the url, and lead me to the log in page, allowing me to log in. Was this done proper, or was I suppose to toy with the error?
Thanks,

@riky93 You should try to seek help on forums and "Stack Overflow"- Like sites. Issue queues for projects (including those on Drupal.org) are usually for reporting properly investigated issues in a way that is helpful for the project maintainers, contributing patches or helping out with the project.
As per your report, it looks like the issue might not be at all related to the database driver (but it could...).

@riky93 Seems like this is not a driver issue. Closing it for now, feel free to re-open it if you think otherwise.


Cassandra: Use a more intelligent snitch

Currently we're using SimpleSnitch, which assigns all cassandra nodes to rack1 in datacenter1. Cassandra uses the rack and datacenter information to spread replicas more evenly across them for fault tolerance, so it would be beneficial to teach it about the underlying infrastructure.
/kind feature

Some options for this:

Use GossipingPropertyFileSnitch, which takes a config file named cassandra-rackdc.properties which we could generate at startup using information from the kubernetes api
Use Ec2Snitch or GoogleCloudSnitch if we're deployed to either of those clouds. These talk directly to the cloud APIs, however, which we may want to avoid.
Write a custom snitch that talks to the kubernetes API, similar to how the KubernetesSeedProvider works.

/area cassandra

I added a poc of using GossipingPropertyFileSnitch in #247

Fixed via https://github.com/jetstack/navigator/pull/255


[Feature Request] Account management for personal devices (Sign in & sign out) supported in MSAL

https://identitydivision.visualstudio.com/Engineering/_workitems/edit/823216

Propose to not fix


Reaction picker display improvements

Remove overly thin font-width on counter
Add hover effect on reaction picker
Change colors on arc-green to green to match the theme

Some parts of this extracted from https://github.com/go-gitea/gitea/pull/12448.

🚀


Change progress bar value from component instance

Reproduction
Steps to reproduce:

Create progress bar dynamically through ComponentFactoryResolver
Try to change value of progress bar instance

Expected Behavior
Changing value and progress bar mode through component instance
Actual Behavior
Value not changing (without any errors). When changing mode of progress bar through component instance also not working. Looks like it is just takes only first defined property values.
Environment

Angular: 9.0.0
CDK/Material: 9.0.0-rc.10
Browser(s): Chrome 80
Operating System (e.g. Windows, macOS, Ubuntu): Windows

It sounds like you're not triggering change detection so it can't pick up the change, but it's hard to tell without seeing the code.

@crisbeto
Hi, i've tried to calling change detection but without any result.
Is there available stackblitz template with latest Angular Material packages ? Didn't found it at issue creating moment 😞

If you go to any of the examples in the docs site, you can click the "Edit" icon which will create a Stackblitz from the example.

Oh, got it, thank you so much.
Will create example shortly

Here we go:
ViewChild case (reference to component #bar): https://stackblitz.com/edit/angular-xu8tmk?file=src%2Fapp%2Fprogress-bar-determinate-example.ts
ng-container case: https://stackblitz.com/edit/angular-xu8tmk-rqfimd?file=src%2Fapp%2Fprogress-bar-determinate-example.ts

@crisbeto
Hi, still assigned needs clarification label on this issue.
Do i need to provide more info ?

I think I'm seeing exactly the same thing here, I've been building a new Angular 9 app and have just 3 hours trying to get the progress bar to work!  I gave up trying t get ViewChild to work so resorted to binding the [value] but still no progress bar!!

@ChelloApps
Yes that's totally unexpected behavior. But devs still keep "needs clarification"...