Twig Extension ?

So I was wondering.. what the best way to retrieve information from a redis store would be if all I wanted was some text or a count.  So I created a twig extension.
namespace AppBundle\Twig\Extension;

use Predis\ClientInterface;

class RedisExtension extends \Twig_Extension
{
    private $predis;

    public function __construct(ClientInterface $predis)
    {
        $this->predis = $predis;
    }

    /**
     *
     * {@inheritdoc}
     *
     */
    public function getFilters()
    {
        return array(
                'redis' => new \Twig_Filter_Method($this, 'predis')
        );
    }

    /**
     * Fetch data at $key in Redis
     *
     * @param string $key
     * @param string $default
     *
     * @return mixed
     */
    public function predis($key, $command, $default = "")
    {
        $res = strval($this->predis->{$command}($key));
        if (empty($res)) {
            return $default;
        }
        return $res;
    }

    /**
     * Returns the name of the extension.
     *
     * @return string The extension name
     */
    public function getName()
    {
        return 'predis_extension';
    }
}

Just wondering if this is either good or bad.  Any thoughts ?

Oh. Im using it as such
{{ ('user:'~app.user.id~':'~'totals:matches')|redis('scard') }}

or
{{ 'some:redis:key'|redis('get') }}

:-1: IMHO redis should be part of the business logic and not be mixed with the view

Thanks for sharing your code. I agree with Ma27.

It would be nice to have a bit of a better discussion with more individuals. I disagree with the others for two reasons. The simplicity of it is unparalleled. It uses redis as a view layer cache.
It also uses the twig extension in a way it was designed in that it transforms a "key" to a "value". Similar to say the translation extension.
Of course I will continue to use it like this lol.. because its just too easy and works beautifully. But it would be nice to have a wider discussion is all im saying.
Cheers

well being honestly I absolutly disagree with the concept of such
extensions. There are proper use cases for extensions, but the must not be
"abused" for mixing business logic and view stuff.
The reason by templating engines like mustache or twig exist is that it was
necessary to separate business logic from the view. Twig does IMHO too much
in the view (such as regexes or other weird magic).
Well, Redis can be used as a cache, but actually it is a memory-based
database. If we start supporting databases in twig, what will come next? A
doctrine-twig-extension for DQL?
Such tasks must be done in the controller as it has been made for that.
2015-12-20 11:32 GMT+01:00 Jayes<EMAIL_ADDRESS>
It would be nice to have a bit of a better discussion with more
individuals. I disagree with the others for two reasons. The simplicity of
it is unparalleled. It uses redis as a view layer cache.
It also uses the twig extension in a way it was designed in that it
transforms a "key" to a "value". Similar to say the translation extension.
Of course I will continue to use it like this lol.. because its just too
easy and works beautifully. But it would be nice to have a wider discussion
is all im saying.
Cheers
—
Reply to this email directly or view it on GitHub
https://github.com/snc/SncRedisBundle/issues/224#issuecomment-166107427.

Again to play devils advocate. You do realize that's exactly how LAZY loading Doctrine objects works ?
If you have some object say User that has a relation to some object say Profile where Profile is a LAZY loaded relation.  In Twig performing something like {{ app.user.profile.description }} would (if the object has not already been loaded) make execute a query to the db to fetch back the required data.
I don't agree with redis being strictly Business logic.  When its really Data logic.
 Obviously as part of some business requirement, data may be requried from a Redis store. That doesn't mean Redis is meant strictly for Business logic.

well, the reason behind doctrine is to provide a mapper which is able to map data from any database (there exist a few NoSQL implementations, too) on your business model including relations to other models.
WHen having some really complex relations, eager loading is a really bad decision, so lazy initialization of associations is pretty good.
But there's one big difference: having twig extensions for SQL (e.g. from Doctrine DBAL) or your redis extension are business logic (well, data logic is IMHO even worse to keep it in templates). The ORM is simply an implementation detail.
While you put business/data logic in your template creating a redis extension, you simply put a model in your template when using doctrine ORM.
What happens when initializing associations is just an implementation detail.
Therefore you just have a model in your template and no such data logic. If you would do all your redis stuff in an abstracted way, it would be IMHO fine


Seems like current react native icons is breaking

Issue Description
It seems that react native icons is facing an issue: https://github.com/oblador/react-native-vector-icons/issues/910

We need to upgrade the dependency on react native icons
node, npm, react-native, react and native-base version, expo version if used, xcode version
Native base 2.8.1
Node 10.3.1
RN 0.57
Expected behaviour
Be able to build the project
Actual behaviour
Fails because of this dependency
Steps to reproduce
Just build a fresh project with the lates nativebase
Is the bug present in both iOS and Android or in any one of them?
Android
Any other additional info which would help us debug the issue quicker.
Not really, just see RNvector icons link

same here

@YangSeung-min a current solutions is to just install the react-native-vector-icons independently, get the 6.1.0 version.
Then go into your lock file,
Search for react-native-vector-icon
Delete the older version if there.
Find native base entrance with the vector-icon dependency
Update the native base dependecny version to the one installed, in this case 6.1.0
Save the lockfile
Remove JUST nodemodules
and install again.

In the master-branch, the new vector-icon version is still added.
Hope @akhil-geekyants will create a 2.8.2 release very soon & fast to get this changes in 2.8.2


Remove timeout for loading jsapi

As discussed in #364

Note that public/_js/test.js is autogenerated/overwritten after running npm run build. Could you update gulpfile.js as described here please?
Then, once https://github.com/bestiejs/benchmark.js/pull/188 is merged, this PR can be merged too, and this change can be deployed. 👍

Yes sorry, I slowly start to understand how jsperf is build :)
I changed the PR.

Thank you so much for looking into this and fixing this long-standing issue 👍 You’re a hero!

Okay, so here’s what needs to happen before this can be merged:

https://github.com/bestiejs/benchmark.js/pull/188 is merged
Benchmark.js tags a new release that contains the abovementioned changes
Our package.json updates the devDependency to point to this new release. See https://github.com/jsperf/jsperf.com/blob/master/CONTRIBUTING.md#adding-new-dependencies

Would you be up for tackling item 3 (as part of this PR) when the time comes?

Of course.

Ok I updated benchmark and regenerated the shrinkwrap by doing:
rm -rf node_modules/ npm-shrinkwrap.json
npm i
npm shrinkwrap

One last thing before we merge this: could you run npm run build and commit the changes?

Done


Invert if

This is essentially a refactoring, so we are classifying it as a Hidden diagnostic.
Condition to raise diagnostic: more than one statement inside if block.
Scenario 1: return void
Additional condition to raise diagnostic: no code after if statement.
This:
void Foo()
{
    if (condition)
    {
        //some code
    }
}

Becomes:
void Foo()
{
    if (!condition)
        return;
    //some code
}

Scenario 2: return something
Additional condition to raise diagnostic: only a return statement after if statement and a return at the end of the if block (or in every branch).
This:
int Foo()
{
    if (condition)
    {
        //some code
        return 2;
    }
    return 1;
}

Becomes:
int Foo()
{
    if (!condition)
        return 1;
    //some code
    return 2;
}

This code should also raise a diagnostic:
int Foo()
{
    if (condition)
    {
        //some code
        if (anotherCondition)
            return 2;
        else
            return 3;
    }
    return 1;
}

Category: Refactoring
Severity: Hidden
Diagnostic id: CC0087

@elemarjr can you post an example of exactly what you mean? Would be in case of an if...else?

essentially, what it means to invert a if would be something like this @giggio
//not inverted
public string Method(Object obj)
{
if(obj != null)
{
return obj.ToString();
}
}
public string SecondMethod(Object obj)
{
if(obj == null) return null;
return obj.ToString();
}

that would, indeed, be a good code refactoring @ElemarJR
The big impact of this refactoring is that it avoids the need of the nested if structure @giggio

@Kavignon I have updated the description, see if you agree.
@ElemarJR @carloscds I need some of you to validate it.
I liked this one, I don't have an issue assigned to me at this moment, I would like to work on this one.

I agree with your update !
I'm still working on #88.
But i'd like to take that one on as soon as I'm done with it !

@code-cracker/owners I need you to validate this issue. It seems Ready to me.

@giggio For me it´s ok.

Ok, it is Ready. @Kavignon finish you item first, then you can get this one. :)

I'm working on it. Finishing up with writing tests.

Clarifying: You mean a simple statement-inversion function or a way to reduce nesting? What I've done so far is a simple statement-inversion function.

@Kavignon Just an inversion. See the tests on the description, they should pass. Reducing nesting comes for free. :)

There're two scenarios. One of them is simply invert a full if statement (if ... else). The other one is to reduce nesting which in my opinion differs from the first one. Do you agree?
The simple scenario I already covered.

I mentioned @Kavignon incorrectly. Sorry about that. @gandarez is working on it.

@gandarez I don't agree. The diference is that the second one returns. The first one doesnt.

@giggio Ok i'll make effort to make it as described.

I'm still working on it. A little bit belated because I'm stuck at a point.

Ok, if you need help let us know, we can help you.

@gandarez How is this coming?


fix: update vulnerable version of nanoid to 3.2.0

Overview

Ran tests and ran in local app

[x] briefly describe the changes in this PR
[ ] write tests for all new functionality
[ ] run npm run docs and commit changes to API.md
[ ] update CHANGELOG.md with changes under master heading before merging

Are we using  package-lock.json at all?

What are the breaking changes in nanoid v3?

Are we using package-lock.json at all?

Going to make a separate PR after this to use package-lock.json. Was mostly using yarn before this but figure most of the other maplibre packages use NPM and we should follow suit here.

Nice. In GL JS we use nvm use 16. Ideally we do the same here.

What are the breaking changes in nanoid v3?

Actually realized after looking into it more we removed the code that used nanoid when we forked from mapbox-gl-geocoder so it is no longer needed :)

You are right, and there are more in the devDependencies:
➜  maplibre-gl-geocoder git:(main) npx depcheck
Unused dependencies
* nanoid
Unused devDependencies
* brfs
* browserify
* budo
* documentation
* envify
* eslint
* husky
* smokestack
* tap-color
* tap-status
* uglify-js

If you migrate package-lock.json to v2, please also update the contributors guidelines and tell people to use nvm use 16.

You are right, and there are more in the devDependencies:
➜  maplibre-gl-geocoder git:(main) npx depcheck
Unused dependencies
* nanoid
Unused devDependencies
* brfs
* browserify
* budo
* documentation
* envify
* eslint
* husky
* smokestack
* tap-color
* tap-status
* uglify-js

Yep! was planning to get to those also in a separate PR since I wanted to take more time to verify they aren't needed


v4 resubscribe not working

https://github.com/redis/node-redis/issues/1764
fix not working, it is not fixing the problem
I've taken code from the master branch and tested with the same script.
Environment:
same as in original issue

Hi @Redjik, first of all, thanks for testing my fix! :)
I tested my changes using your example script, without my changes it didn't work (as expected) - but with the changes it looks like it works for me.. wanna debug it together?

sure, how can I help?

@Redjik I've sent u an email


Deformable convolution visualization

Hi,
Thanks for your simple implementation ! I wonder if we can visualize the learned sampling location just like the author of the paper have shown in their paper ? Something like this:

I think it has something related to your learned offset and modulation mask but I am not sure how to visualize them as the paper.

@phongnhhn92
Ah, it's a good point to show the effect of DCN. I just thought about how to implement this visualization algorithm.

Hi,
Yes, I do I found this method improve my model and I wanna know why. I don't know if we can do it since we are using the pytorch function.

@phongnhhn92
I think we can visualize its offsets. Are you in a hurry? I will try to implement this function within one month.

Hi,
I would love to see it within 2 weeks. I have a deadline to catch here :(

@phongnhhn92
Oh my god, okay, I will try it...
But you shouldn't believe in me.  HAHA

Hehe, I am trying it on my own as well. But it's good to double check with you because I am not even sure if I am gonna do it right haha.

@phongnhhn92
Hi, phong
What have you been up to?

Hi @developer0hye ,
Thanks for the code ! Can u also upload the example_model_state_dict.pth and the testing image 61.png so I can try to run your code ?

@phongnhhn92
Check main branch.
I upload the code for offset visualization. Actually, I am not sure that I implemented the code correctly. I need your review.

Hi @developer0hye , I think your implementation is correct. Thank you so much for providing this code. I am gonna close this issue now.


Narendra Modi - Text Speeches Analysis

ML-Crate Repository (Proposing new issue)
:red_circle: Project Title : Narendra Modi - Text Speeches Analysis
:red_circle: Aim : This project is to analyze the speeches of Narendra Modi.
:red_circle: Dataset : https://www.kaggle.com/adiamaan/modi-speeches
:red_circle: Approach : Try to use 3-4 algorithms to implement the models and compare all the algorithms to find out the best fitted algorithm for the model by checking the accuracy scores. Also do not forget to do a exploratory data analysis before creating any model.
Hello, ML-Crate contributors, this issue is only for the contribution purposes and allocated only to the participants of SWOC 2.0 Open Source Program and JWOC '22 Open Source Program.

📍 Follow the Guidelines to Contribute in the Project :

You need to create a separate folder named as the Project Title.
Inside that folder, there will be four main components.

Images - To store the required images.
Dataset - To store the dataset or, information/source about the dataset.
Model - To store the machine learning model you've created using the dataset.
requirements.txt - This file will contain the required packages/libraries to run the project in other machines.

Inside the Model folder, the README.md file must be filled up properly, with proper visualizations and conclusions.

:red_circle::yellow_circle: Points to Note :

The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'SWOC' and 'JWOC' contributors of 'ML-Crate' project.

:white_check_mark: To be Mentioned while taking the issue :

Full name :
GitHub Profile Link :
Participant ID :
Approach for this Project :
What is your participant role?

[ ] SWOC 2.0 Participant.
[ ] JWOC 2022 Participant.
[ ] Contributor

Happy Contributing 🚀
All the best. Enjoy your open source journey ahead. 😎

I want to work on this issue under JWOC

Follow the issue guidelines and mention all the required details properly before taking the issue @Adi9235

Full name : Aditya Tomar
Github Profile Link : https://github.com/Adi9235
Approach for this Project : To create ML models after data analysis and proper visualization
What is your participant role?

[x]  JWOC 2022 Participant

Issue assigned to you @Adi9235

What's the update here @Adi9235

I am working on it @abhisheks008 it is the first time so it is taking me time to complete.

Yeah it's ok. Thank you for responding and the update. @Adi9235

What's the update here @Adi9235

I m working on it

Name-Divyansh Singh
Git Hub-https://github.com/divyansh-2707
Approach for this Project - To create ML models after data analysis and proper visualization
Participant Role-SSOC'24

Name : Harsh Raj
GitHub Profile : https://github.com/HarshRaj29004
Approach for this Project :

I will do data cleaning removing or merging columns to apply EDA on it.
Then will perform EDA on dataset, like analyzing the most frequently used words and phrases in the speeches,  determine the overall sentiment of each speech, etc.
This all will be visually represented.

What is your participant role? SSOC'24 participant

Use different plots and analysis methods for analysing the dataset.
Assigned @HarshRaj29004


update packer task UI. porting from master.

@bishal-pdMSFT,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


[BUG]

Describe the bug
When data is not found to capture, gives an error even though u have valid credential for whatever site ypu debugging.
Error
https://imgur.com/joJnslr.png
Screenshots
https://imgur.com/joJnslr.png
https://imgur.com/wJNEOpq.png
Version

Version [e.g. 1.0.1]

Example
Data to capture   {""I love OB"} but like BB more...
LS  {""    RS "}  Capture > I love OB
If  I love OB not found error is generated.

the example you provided is working correctly, and there is no error

that error happens only when you have a problem on your params
for example:
String = "abcdefghijklmnopqrstuvwxyz"
Case 1:  LS = "abcde"  | LR = "efghij"  >>>> on this case, you are going to get the error
Case 2: LS = "abcde"  | LR = "fghij"  >>>> return null, no error

so just fix your LS n LR params !

Would you guys like it better if a blank value was inserted when the parse fails or are you fine with the ERROR status?

Would you guys like it better if a blank value was inserted when the parse fails or are you fine with the ERROR status?

An empty string would be
thanks

the example you provided is working correctly, and there is no error

that error happens only when you have a problem on your params
for example:
String = "abcdefghijklmnopqrstuvwxyz"
Case 1: LS = "abcde" | LR = "efghij" >>>> on this case, you are going to get the error
Case 2: LS = "abcde" | LR = "fghij" >>>> return null, no error

so just fix your LS n LR params !

You getting error not success when no data is present

I'm pretty sure I solved this with https://github.com/openbullet/openbullet/commit/2650c65fc210a42ccb4ad7c959f89b82ee912142


SPARK-5112. Expose SizeEstimator as a developer api

"The best way to size the amount of memory consumption your dataset will require is to create an RDD, put it into cache, and look at the SparkContext logs on your driver program. The logs will tell you how much memory each partition is consuming, which you can aggregate to get the total size of the RDD."
-the Tuning Spark page
This is a pain. It would be much nicer to expose simply functionality for understanding the memory footprint of a Java object.

Test build #25109 has started for   PR 3913 at commit 29fa503.

This patch merges cleanly.

That doc is very outdated - you can actually just look in the UI after caching some data, you don't need to visit the logs.

Test build #25109 has finished for   PR 3913 at commit 29fa503.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25109/
Test PASSed.

Ooh OK I'll update the doc.  That's still a little cumbersome though for someone who just wants to see how much space an object takes up.  Most of the recommendations on that page are at the micro level - tuning the memory taken up by a single object.  It would be useful to have a way to determine this amount directly.
E.g. if I have plan to have an RDD of some case class I might want to see how much space each instance takes up.  Then I can experiment quickly with things like flatter structures or removing fields and see if they improve the footprint.
Another thing is that users trying to tune applications commonly need to figure out whether they should broadcast side-data or figure out a way to load it as an RDD and join.  It would be helpful to be able to have a single function call that's easy to use from the shell to find out the size of the data you're about to broadcast.

Just not sure how overall useful it would be. For RDD data, it might be slightly misleading here because of things like serialization in-memory. For broadcast objects in the shell, it would only work in the scala shell though because of the way that serialization works in Python.
I'm also not totally sure overall how accurate our memory estimation is and it may get less so if we add smarter caching for SchemaRDD's. Anyways, what would be helpful, could you walk through an example with a case class or something and show how accurate it is? That would be useful to better understand.
One thing we could do that would be more isolated is have a function in SparkContext called estimateSizeOf(object: Any), so that at least we don't expose the class location and names as API's.

Should this just turn into a doc update PR then?

Adding an estimateSizeOf method to SparkContext sounds reasonable to me.
I agree that there's not a great way to expose something like this for Python. But I don't think the zaniness of Python-JVM interaction means that we shouldn't expose useful functionality to pure-JVM apps.

For RDD data, it might be slightly misleading here because of things like serialization in-memory.

I think this is the kind of thing we can just document.  Adding a separate estimateSerializedSizeOf method would be helpful as well.

I'm also not totally sure overall how accurate our memory estimation is and it may get less so if we add smarter caching for SchemaRDD's.

I've found it to be very accurate in my experiments.  We rely on its accuracy for shuffle memory management and POJO caching, so to the extent that it's inaccurate we've got bigger problems.

Test build #27305 has started for   PR 3913 at commit 62bac82.

This patch merges cleanly.

The size estimator should be pretty accurate for measuring the size of small Java objects. You could add a note that we do some approximation for large arrays (we sample some elements of the array and then extrapolate).

Test build #27305 has finished for   PR 3913 at commit 62bac82.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27305/
Test PASSed.

I'd like to resolve this one way or the other. My hesitation is mostly about tacking on another method to SparkContext, developer API or no. Would it really be a better way to estimate actual RDD size, since that depends on other stuff (even the JVM, whether data is serialized, etc.)

I think this is a good change.  Yes, you could cache an RDD and see its size, but think about what a pain that actually is if you wanted to do it programmatically.  You'd need to register a spark listener, wait to get the appropriate events and look at the sizes.
If it was easy to do this programmatically via an RDD, then I'd say this change isn't necessary.  Eg., if you could do something like
val (_, meta) = sc.parallelize(oneObject).cache().count()
meta.getPartitionSizes

Then we wouldn't need to expose this.  But that's an even bigger api change, and one that I would be far more nervous about (the code above is definitely not a viable alternative, lots of reasons it doesn't make sense).

Again, one of the main uses is estimating the size of variables you're considering broadcasting.  Another is experimenting with different representations - e.g. how much more efficient is declaring a custom class than just using a hash map?  In these situations, putting the data into and RDD to estimate the size would be an inconvenience.

Test build #30423 has started for   PR 3913 at commit 4aba898.

OK, I think my remaining comment is just: why route through SparkContext? can this method be exposed where it is? It doesn't seem like it has to be tied to the context.

@pwendell thought this would be preferable:

One thing we could do that would be more isolated is have a function in SparkContext called estimateSizeOf(object: Any), so that at least we don't expose the class location and names as API'

The reason I proposed to put in SparkContext is to avoid committing to the current namespace/package of that object and just expose a narrower utility function off of SparkContext. Overall our estimation code is likely to evolve in the future.
In terms of exposing or not, I'm okay to expose it given the reasons here. But can we give some warning to set expectations for the user? This estimation can be really inaccurate because of sampling and heuristics used internally. This is especially true if you have, say, a hashmap that has skewed keys - it will only sample a small percentage of all the keyspace and could miss hot keys.
So I'd just say it's an estimate of the in-memory size and uses sampling internally for complex objects. I think this is also the gist of @shivaram's suggestion.

Test build #30423 has finished for   PR 3913 at commit 4aba898.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30423/
Test PASSed.

OK how about just moving it up a level out of util, if that's generally not public, and making SizeEstimator public but a developer API? You have to commit to the method living somewhere and I think that's no more complex than routing it through the context API.

Sure, sounds fine to me. We can have a static method for it.

Build triggered.

Build started.

Test build #31334 has started for   PR 3913 at commit 8adde39.

Test build #31334 has finished for   PR 3913 at commit 8adde39.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.
This patch removes the following dependencies:

spark-unsafe_2.10-1.4.0-SNAPSHOT.jar

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31334/
Test PASSed.

Looking good though this needs a rebase now.

Pending an update LGTM

Merged build triggered.

Merged build started.

Test build #31476 has started for   PR 3913 at commit 35c974c.

Test build #31476 has finished for   PR 3913 at commit 35c974c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31476/
Test PASSed.

Hey @sryza and @srowen, sorry to vacillate here, but after looking at this more I really do think it would be better to just make this a static method on SparkContext. The reason is the following:

For users, it's much nicer to just call SparkContext.estimateSize() since in may cases they've already imported SparkContext. Having them import some other class for this one static function seems a little strange.
For developers, we now have this whole class exposed and a lot more room to accidentally expose new functionally if this class is later changed. There is a single static function buried deep in the middle of the class description that is public.

Basically I don't see a big motivation for having a separate class for this, and it forces us to make some longer term commitment to that class name, having static utility classes in the top level namespace, etc.

Hm, my gut is that it's stranger to put this in the context when it has nothing to do with the context. It's all private except for the one method. Lots of accidents can happen but, y'know, that's an argument anywhere.
Something has to commit to at least one name somewhere, yes. What about a single object at this level that exposes a single public method, that calls into the existing class where it is? I suppose that minimizes the amount that is surfaced and keeps the implementation alongside other package-private stuff, at the cost of a little redundancy and extra declaration.
Now it really is down to where to place a single method, and I'd still argue a little for not tacking it on the context as an uber utility class. This is a developer API so convenience for the end user isn't a big deal.

I'm good with the new idea you proposed. We keep util.SizeEstimator as is, but we have a public class in the root namespace SizeEstimator that just has a single method that calls into the internal one. We can always merge them together later if we want too, but IMO it's worth keeping the larger implementation totally private.

@sryza do you want to try to update this and get it in for 1.4? might still technically be time

Merged build triggered.

Merged build started.

Test build #31806 has started for   PR 3913 at commit 8d9e082.

Updated with the suggested approach.  Let me know what you think.

Test build #31806 has finished for   PR 3913 at commit 8d9e082.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31806/
Test FAILed.

Merged build finished. Test FAILed.

LGTM. I think the test failure was unrelated; let's see.

Jenkins retest this please.

Merged build triggered.

Merged build started.

Test build #31864 has started for   PR 3913 at commit 8d9e082.

Test build #31864 has finished for   PR 3913 at commit 8d9e082.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31864/
Test PASSed.

Actually I strongly oppose putting this in the top level package. We will end up with a lot of random util objects or top level classes at the top.
One way to do this is to have a public util package, and move everything in util into internalutil if we want to hide utils.

@rxin yeah I hear you. It's not too late to move this. I struggle a bit with where to put this then. So you mean move util to util.internal or something, and move public utilities into util? makes sense to me.
There are probably a few other things that could move down out of org.apache.spark that are not already public. Like the HTTP server stuff for example?
And I have thought and heard a few times that it might be nice to break up Utils into a few logical units.
It would be a big invasive change to the code; that's the only thing. I can take a swing at it if anyone voices support for that kind of thing?

I think it's a good idea to do that. For now why don't we move SizeEstimator back into util, rename the current util.SizeEstimator util.SizeEstimator0?
For 1.5 we can move stuff around into utils or utils.internal (seems long ... maybe we can find better names too).

I think @pwendell 's sentiment was that util shouldn't have public classes/objects -- what do you think Patrick? as an interim measure?

But we already have a bunch of stuff in util that's public ...
https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.util.package

I'm okay to nest it under util, per Reynold's suggesting.
On Wed, May 6, 2015 at 7:33 AM, Reynold Xin<EMAIL_ADDRESS>wrote:

But we already have a bunch of stuff in util that's public ...
https://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.util.package
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/3913#issuecomment-99342566.

@sryza do you mind doing the honors as an part 2 for this issue?

@pwendell @rxin if we're putting it in the same package, I don't really understand why we don't just have a single class SizeEstimator with a single public method estimate?  We're worried in the future that someone might make other attributes of SizeEstimator public?  I don't see why we wouldn't trust ourselves to properly restrict access when a change proposing that comes around.  Or, in SizeEstimator / SizeEstimator0 world, it wouldn't be just as easy to add something public to SizeEstimator.

I'm fine putting them in the same class too, provided that everything else is marked as private (I think it is already, isn't it?)

Is that ok with you as well @pwendell ?

Okay - I officially give in and will not comment further on this thread :P
On Tue, May 12, 2015 at 10:12 PM, Sandy Ryza<EMAIL_ADDRESS>wrote:

Is that ok with you as well @pwendell https://github.com/pwendell ?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/3913#issuecomment-101515251.


Auth context cache

The authentication context cache of the connection pool was not being updated upon successful fedauth authentication in the netcore code. This was resulting in poor connection speed for subsequent connections which used AAD auth since they could not take advantage of the cached token. This code looks to have been missed when AAD authentication was ported from netfx to netcore.
This was found during investigation of #408
The new test should detect if subsequent connections are not using the cache. Hopefully connection times are consistent enough that this does not produce intermittent failures.

It might be worth using private reflection to reach into the internals and find the cache to verify that it has been populated rather than relying on a timing artefact that could be flaky. I know private reflection is generally bad but as the owners you're allowed to assume your own internal details in this case I'd say.

It might be worth using private reflection to reach into the internals and find the cache to verify that it has been populated rather than relying on a timing artefact that could be flaky. I know private reflection is generally bad but as the owners you're allowed to assume your own internal details in this case I'd say.

@Wraith2
I expect _dbConnectionPool.AuthenticationContexts.Count > 0 in SqlInternalConnectionTds after the first connection. I spent some time trying to wind my way through to view that via Reflection, but it was not apparent to me how to get to it. I'll have to revisit it later if I find the time. (If you have some time to spare, you're probably quicker than I am. :grin:)


Chrome Legacy Window

Is there a way to log all visited Websites? I am only getting approx 2/10, the rest is displayed as "Chrome Legacy Window".

Nothing I can do about it, it is related to pyhook.


Group Pull up/Push down operation refactorings when they are associated with the same method

Fixed in #81


m3-quickstart vars_build.sh fails

Hi. I am trying to build vars on my M1 Mac. I have successfully gone through these steps:
Get setup
git clone git@github.com:mbari-media-management/m3-quickstart.git
cd m3-quickstart
Start the web server, database, and VARS services
The first time it's run it takes a while. Be patient.
bin/docker_start.sh
Builds some custom VARS apps under temp/apps
You need GITHUB_TOKEN and GITHUB_USERNAME environment variables set.
see https://github.com/mbari-org/maven#gradle
export GITHUB_TOKEN=
export GITHUB_USERNAME=
However, at this step
bin/vars_build.sh
I get a fatal error
(base) duane@ICEFISH m3-quickstart % bin/vars_build.sh
--- BUILDING VARS Knowledgebase Application
Base Directory:      /Users/duane/m3-quickstart/bin
HOST:                http://<IP_ADDRESS>
ANNOSAURUS REST URL: http://<IP_ADDRESS>:8082/anno/v1
KB JDBC URL:         jdbc:postgresql://<IP_ADDRESS>:5432/M3_VARS?sslmode=disable&stringType=unspecified
Deleting existing repo at /Users/duane/m3-quickstart/temp/repos/vars-kb
Building vars-kb in /Users/duane/m3-quickstart/temp/repos/vars-kb
Cloning into 'vars-kb'...
remote: Enumerating objects: 2438, done.
remote: Counting objects: 100% (226/226), done.
remote: Compressing objects: 100% (146/146), done.
remote: Total 2438 (delta 88), reused 172 (delta 54), pack-reused 2212
Receiving objects: 100% (2438/2438), 3.58 MiB | 9.89 MiB/s, done.
Resolving deltas: 100% (1186/1186), done.
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details

Configure project :
Found module name 'org.mbari.kb.core'
Jdeps Gradle plugin 0.12.0. Consider becoming a patron at https://www.patreon.com/aalmiray
Found module name 'org.mbari.kb.jpa'
Found module name 'org.mbari.kb.shared'
Found module name 'org.mbari.kb.ui'

FAILURE: Build failed with an exception.

Where:
Build file '/Users/duane/m3-quickstart/temp/repos/vars-kb/org.mbari.kb.core/build.gradle'

What went wrong:
Could not compile build file '/Users/duane/m3-quickstart/temp/repos/vars-kb/org.mbari.kb.core/build.gradle'.

startup failed:
General error during conversion: Unsupported class file major version 63

What should I do now?

@duane-edgington Thanks for the heads up. It looks like I've compiled one of the dependencies using Java 19 by accident. (I'll have to sort out which one and make a change). In the meantime, you could try building using Java 19 instead. However, gradle is really snotty about Java versions. So your mileage may vary, I'll try to sort out the misbehaving dependency later today.

Oh, I misspoke. You may be trying to build with Java 19 and gradle is complaining. I can upgrade the gradlew version in the VARS kb. Give me a few minutes.

@duane-edgington Give it another try.

Thanks Brian. I have Java 19 installed from OpenJDK. Or do I need the official Oracle commercially licensed JDK 19?? Or should I be running a different version of Java??
Duane
From: "Brian Schlining" @.>
To: "mbari-media-management/vars-annotation" @.>
Cc: "Duane Edgington" @.>, "Mention" @.>
Sent: Tuesday, February 14, 2023 2:04:21 PM
Subject: Re: [mbari-media-management/vars-annotation] m3-quickstart vars_build.sh fails (Issue #149)
[ https://github.com/duane-edgington ]
[ https://github.com/duane-edgington | [POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.] ]
[ https://github.com/duane-edgington | @duane-edgington ] Thanks for the heads up. It looks like I've compiled one of the dependencies using Java 19 by accident. (I'll have to sort out which one and make a change). In the meantime, you could try building using Java 19 instead. However, gradle is really snotty about Java versions. So your mileage may vary, I'll try to sort out the misbehaving dependency later today.
—
Reply to this email directly, [ https://github.com/mbari-media-management/vars-annotation/issues/149#issuecomment-1430435666 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AC5RY7AUDV46SCTZL2PRZV3WXP6OLANCNFSM6AAAAAAU4COLCE | unsubscribe ] .
You are receiving this because you were mentioned. Message ID: @.***>

Trying now. It is progressing…
It throws a lot of EL Severe messages at
Task :org.mbari.kb.jpa:performJPAWeaving
throws warnings at
Task :createDelegatingModules
And ends with
BUILD SUCCESSFUL in 1m 6s
10 actionable tasks: 10 executed
So you can probably close the ticket…
thanks
Duane
From: "Brian Schlining" @.>
To: "mbari-media-management" @.>
Cc: "Duane Edgington" @.>, "Mention" @.>
Sent: Tuesday, February 14, 2023 2:26:37 PM
Subject: Re: [mbari-media-management/vars-annotation] m3-quickstart vars_build.sh fails (Issue #149)
[ https://github.com/duane-edgington ]
[ https://github.com/duane-edgington | [POSSIBLE IMPERSONATION: This message is using the name of an MBARI account holder and has originated from outside of the organization. Please review the content and sender information carefully.] ]
[ https://github.com/duane-edgington | @duane-edgington ] Give it another try.
—
Reply to this email directly, [ https://github.com/mbari-media-management/vars-annotation/issues/149#issuecomment-1430462658 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AC5RY7DRLAZ6Y3AZX7Y5RYLWXQBB3ANCNFSM6AAAAAAU4COLCE | unsubscribe ] .
You are receiving this because you were mentioned. Message ID: @.***>

@hohonuuli Can we close this?

@hohonuuli Can we close this?


Going to download app metadata from iTunesConnect FATAL

INFO [2015-03-08 13:25:37.78]: Going to download app metadata from iTunesConnect
FATAL [2015-03-08 13:25:37.79]: Could not download metadata from iTunes Connect. Do you have special characters in your password (Like ' or ")?
FATAL [2015-03-08 13:25:37.79]: Error occured with the setup program! Reverting changes now!
anyone can help me?

Does your password contain any special characters? There is an issue for that: https://github.com/KrauseFx/fastlane/issues/39
If not, is there any other error message shown? Is the xcode path set correctly?

my password is very simple
Going to download app metadata from iTunesConnect
FATAL [2015-03-09 17:22:40.79]: Could not download metadata from iTunes Connect. Do you have special characters in your password (Like ' or ")?
FATAL [2015-03-09 17:22:40.79]: Error occured with the setup program! Reverting changes now!
INFO [2015-03-09 17:22:40.79]: Deleting the 'fastlane' folder
/Library/Ruby/Gems/2.0.0/gems/deliver-0.7.13/lib/deliver/app_metadata.rb:302:in read': No such file or directory - /tmp/975018225.itmsp//metadata.xml (Errno::ENOENT) 	from /Library/Ruby/Gems/2.0.0/gems/deliver-0.7.13/lib/deliver/app_metadata.rb:302:in parse_package'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.7.13/lib/deliver/app_metadata.rb:66:in initialize' 	from /Library/Ruby/Gems/2.0.0/gems/deliver-0.7.13/lib/deliver/app.rb:113:in new'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.7.13/lib/deliver/app.rb:113:in metadata' 	from /Library/Ruby/Gems/2.0.0/gems/deliver-0.7.13/lib/deliver/deliverfile/deliverfile_creator.rb:59:in create_based_on_identifier'
from /Library/Ruby/Gems/2.0.0/gems/deliver-0.7.13/lib/deliver/deliverfile/deliverfile_creator.rb:31:in create' 	from /Library/Ruby/Gems/2.0.0/gems/fastlane-0.1.16/lib/fastlane/setup.rb:80:in ask_to_enable_other_tools'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-0.1.16/lib/fastlane/setup.rb:18:in run' 	from /Library/Ruby/Gems/2.0.0/gems/fastlane-0.1.16/bin/fastlane:45:in block (2 levels) in run'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.0/lib/commander/command.rb:179:in call' 	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.0/lib/commander/command.rb:179:in call'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.0/lib/commander/command.rb:154:in run' 	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.0/lib/commander/runner.rb:421:in run_active_command'
from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.0/lib/commander/runner.rb:81:in run!' 	from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.0/lib/commander/delegates.rb:15:in run!'
from /Library/Ruby/Gems/2.0.0/gems/fastlane-0.1.16/bin/fastlane:60:in run' 	from /Library/Ruby/Gems/2.0.0/gems/fastlane-0.1.16/bin/fastlane:64:in <top (required)>'
from /usr/bin/fastlane:23:in load' 	from /usr/bin/fastlane:23:in '
kjxdeMacBook-Pro:yyb kjx$

Could you run deliver init instead of fastlane init and post the complete output?

yes ,i can run "deliver init"

Can you post the complete output?

Hello,
I think it is because your apple Id contains special characters.

This should be fixed with the latest version :+1:


Fix bidirectional test

Bidirectional test needs several groups to run write and read workloads in parallel. The code included in this PR opens and closes a new uperf group per workload.


I noticed that the pre-trained model you mentioned is not provided in the code. Could you please share it?

Thanks for your interest to our work. I have attached the pretrained model file.

No description provided.

Hello, have you reproduced it? I have some questions.


improvements to the BUG_TRIAGE guide

\cc @indirect What we were discussing earlier
This PR consists of several changes like:

Update references to guides (troubleshooting.md & issues.md specifically)
Adding references to existing guides (pull_request.md)
General cleanup, adding clarity etc

Awesome. Thanks, @colby-swandale! :)
@bundlerbot r+

@feministy ack, sorry for merging this before you had a chance to look at it. PR approval muscle memory. 😬 if you have suggestions, I would be super happy to hear them!


All contexts (AIS) fixed period subscription loses updates

If you subscribe to all contexts and some data with fixed period you only get the latest updates for the period, not latest for all contexts.

FIxed in #230 .


Do Kotlin/JS tests run?

Which version of Kotest are you using
5.7.2
Running the following script:
$ git clone git@github.com:kotest/kotest-examples-javascript.git
[...]
$ cd kotest-examples-javascript
$ ./gradlew check --rerun-tasks --info
[...]
> Task :jsBrowserTest
Caching disabled for task ':jsBrowserTest' because:
  Caching has not been enabled for the task
Task ':jsBrowserTest' is not up-to-date because:
  Executed with '--rerun-tasks'.
Starting process 'command '[...]''. Working directory: /tmp/kotest-examples-javascript/build/js/packages/kotest-examples-javascript-test Command: [...]/.gradle/nodejs/node-v18.12.1-linux-x64/bin/node --require /tmp/kotest-examples-javascript/build/js/node_modules/source-map-support/register.js /tmp/kotest-examples-javascript/build/js/node_modules/mocha/bin/mocha.js /tmp/kotest-examples-javascript/build/js/packages/kotest-examples-javascript-test/kotlin/kotest-examples-javascript-test.js --require /tmp/kotest-examples-javascript/build/js/packages_imported/kotlin-test-js-runner/0.0.1/kotlin-test-nodejs-empty-runner.js
Successfully started process 'command '/home/ivan/.gradle/nodejs/node-v18.12.1-linux-x64/bin/node''
Starting process 'command '/home/ivan/.gradle/nodejs/node-v18.12.1-linux-x64/bin/node''. Working directory: /tmp/kotest-examples-javascript/build/js/packages/kotest-examples-javascript-test Command: /[...]/.gradle/nodejs/node-v18.12.1-linux-x64/bin/node --require /tmp/kotest-examples-javascript/build/js/node_modules/source-map-support/register.js /tmp/kotest-examples-javascript/build/js/node_modules/mocha/bin/mocha.js /tmp/kotest-examples-javascript/build/js/packages/kotest-examples-javascript-test/kotlin/kotest-examples-javascript-test.js --reporter kotlin-test-js-runner/mocha-kotlin-reporter.js --require /tmp/kotest-examples-javascript/build/js/packages_imported/kotlin-test-js-runner/0.0.1/kotlin-test-nodejs-runner.js --timeout 2s
Successfully started process 'command '/[...]/.gradle/nodejs/node-v18.12.1-linux-x64/bin/node''
Finished generating test XML results (0.0 secs) into: /tmp/kotest-examples-javascript/build/test-results/jsBrowserTest
Generating HTML test report...
Finished generating test html results (0.0 secs) into: /tmp/kotest-examples-javascript/build/reports/tests/jsBrowserTest
Resolve mutations for :jsTest (Thread[Execution worker Thread 3,5,main]) started.
:jsTest (Thread[Execution worker Thread 3,5,main]) started.
[...]

The generated test report is empty.
By editing DogTest.kt and adding an error("failed") call in the test, and rerunning the Gradle command, the report is still empty, and there is no obvious sign that a test has failed (the Gradle command finishes successfully).
I would have expected that:

If a test fails, the Gradle execution ends with an error (like for the JVM platform)
Successful and failed tests to appear in the generated test report

The cause is a missing Kotest plugin declaration: alias(libs.plugins.kotest.multiplatform) needs to be added to the plugins block in build.gradle.kts.


Background Image

In the file index.php the background image is loaded from the web: $backgroundImage = 'https://source.unsplash.com/1600x900/?nature';
How can I include here own pictures on my webspace instead of the url?
Do I need my own license for https://source.unsplash.com/1600x900/?nature'?

Just replace that link with a path to your own image and you're all set!


Update README.md

Reasons for making this change:
To explain principle of modularity

Good idea! Hope that will reduce the number of "wrong" pull requests...
I'm just not sure, if the GitHub team is willing to publicly recommend gitignore.io, because AFAIK it is not officially related to them. Lets wait for a statement of a team member...


add message intent

apparentally this pr add messages intent, read edited files for more info.
(also i didnt lint yet, be carefool)

actually we should remove mypy

actually didn't see it. sorry.


Adding default Close Side Bar Keybinding

Adding a Close Side Bar Keybinding for closing the Side Bar, would be very helpful. It's possbile, to open the Side Bars by shortcuts, but not to close by default.
In my opinion, following options is very helpful:
CommandID: workbench.action.closeSidebar
Default Keybinding: "Ctrl + w"
Default "When": "sideBarFocus && sideBarVisible"

You can create your own keybinding:
  {
    "key": "ctrl+w",
    "command": "workbench.action.closeSidebar",
    "when": "sideBarFocus && sideBarVisible"
  },

Is there some reason this isn't what you want?

There should actually be a toggle sidebar command available by default:
{
  "key": "cmd+b",
  "command": "workbench.action.toggleSidebarVisibility"
}


Improve performance of pretrained DGA model

The provided notebook has a logic flaw which results in time consuming unnecessary operations
I improved the code so that running it on thousand domains takes seconds not minutes: link

@ksharad-splunk is taking a look at testing your proposed fix! Thank you @dglauche! nice hanging out at .conf

The code has been tested and merged! Thank you @dglauche!


[R24.08] SD Factory - Release Checks

[!IMPORTANT]
Follow the guidance on how to use the templates.

Release Info
Please provide information on what you want to be included in the Eclipse Tractus-X release.
If you are not owner of this issue, please provide the information as comment to the issue.
Make sure to assign this issue to expert(s) for their approval, as soon as you have finished preparation. Multiple assignees allowed; they will un-assign themselves once review completed.
Version to be included in Eclipse Tractus-X release:
AppVersion - 2.1.13
Helmchart version - 2.1.21
Leading product repository: repository link
General Checks

[ ] Tractus-X Release Guidelines(TRGs) fulfilled
https://github.com/eclipse-tractusx/.github/blob/main/.github/ISSUE_TEMPLATE/qg-checklist.md

Make sure to open and fill in a separate documentation issue in your product repository using the Quality Gate Checklist issue template

[!NOTE]
Note: most criteria for documentation and security are now covered in TRGs

Test Results

[ ] E2E Integration Test passed
[ ] User Journey approved

Helpful Links

Eclipse Tractus-X openAPI specs on SwaggerHub

Please note that there was the following update to the issue template (see https://github.com/eclipse-tractusx/sig-release/pull/750#issuecomment-2219591340 for additional information), please take that into account for R24.08

Make sure to open and fill in a separate documentation issue in your product repository using the Quality Gate Checklist issue template

Hi,
as discussed in today's open meeting and referring to today's email, please remove the check topics for Interoperability, Data Sovereignty and Threat Modeling in your description

QG Review 24-July

Version listed ✓
TRG Check needs to be done
User Journey needs to be approved
E2E test is pending

Hello @ther3sa,
SD Factory is a component which  is used for Onboarding Organization in Portal.
Since SD Factory is only a step with which the User does not interact, a user journey approval is not needed.
As E2E, SD Factory does not have a separate test. As long as the onboarding of the companies is working, SD Factory is tested and working.
Because of this, the only open point I see for SD Factory for Release Check are the TRG Checks.
Thank You.

okay thank you for your update :)

Planned E2E Tests for release 24.08 on Catena-X INT environment have been performed successfully. Thank You!

@ciprianherciu How are you getting on with your TRGs? :)

@almadigabor could you give me an update on how far you are with the TRGs? :)

Checks are done from my side and approve the QG with the following versions:
Helm Chart Version: 2.1.21
App Version: 2.1.13

Checks are done from my side and approve the QG with the following versions:
Helm Chart Version: 2.1.21 App Version: 2.1.13

Thank you :)

Congrats:

Quality Gate fully approved with all necessary pre-requisites fulfilled!

Thanks for all your efforts :)


Fixed @return types, allowing for better type hinting when the Column class is extended

Minor update. Some return types were hardcoded to the default Column class. This caused type hinting to break when a different class, i.e. MyColumn with some additional fluent methods, extended the Column class. Corrected by updating return types to static.
(Using version 3 on purpose for compatibility with OctoberCMS.)

Released on v3.13.1, thanks!


Add MQTT Notifier

Added MQTT Notifier and Unit Tests.
The notifier takes an IP address or hostname, port number and MQTT topic at minimum and supports optional username/password authentication. Retain and QoS parameters can also be passed as config variables.
When called, the notifier will push a message to the provided topic.
The message will be formatted as:
{"type": event.type.name, "prio": event.priority.name, "msg": event.message}
with type as:

USER
KEEPALIVE
DAILY_STATS

and priority as:

LOW
NORMAL
HIGH

I am currently working on a generic HTTP stats reporter, which sends statistics to a HTTP endpoint in regular intervals (e.g. every 5 mins).
It uses the same stat_accumulators as the daily_stats reporter, only in a structured format.
I suspect this would be helpful in your Home Assistant use case.
Maybe we can combine it?
The event could look something like this:
{
  'timestamp':<PHONE_NUMBER>,
  'found_proofs_total': 0,
  'search_time_average': 0.32,
  'search_time_over_5s_count': 0,
  'search_time_over_15s_count': 0,
  'current_plot_count': 440,
  'eligible_plots_average': 1.17,
  'signage_point_count': 25,
  'skipped_signage_point_count': 0
}

@pieterhelsen we need to cleanup the commits on that branch. I think you've used merging of dev instead of rebasing, while I'm using rebasing and that probably is why everything is shown duplicate here. I recommend cherry-picking the relevant commits onto a new branch and using rebase on dev in the future.


Implement JpqlSerializer for JpqlNotInSubquery

Backgrounds

In Kotlin JDSL 3.0.0, the Query objects no longer know how to draw themselves as SQL String.
The Query object is drawn in JPQL String by JpqlSerializer.

Requirements

Please implement  JpqlSerializer that draws JpqlNotInSubquery as a SQL String.
Please implement a unit test for the implemented class.

Contribution

Please check if there is an assignee in this issue. And if it don't have an assignee, please change the assignee to yourself.
Please check the commit convention through the commitlint.config.js file. The commit  convention also described in the PR template.
When you use intellij, please set the code style through the .editorconfig file.
Please create the PR for develop/3.0.0 as the base branch.
If you have any questions, please leave comment in Kotlin-JDSL Discord Channel in LINE Open Source

#380 과 함께 작업하면 좋을 것 같아요! assignee 요청드립니다 :)

This issue is closed by #418


Added 'ckeditor.refresh' listener

This is useful for apps that move the ckeditor directive around in the DOM. ckeditor breaks if you do this, so it is necessary to destroy and recreate the editor. This allows users to broadcast the 'ckeditor.refresh' event after moving the ckeditor to refresh the editor.

Sorry, need to resubmit this under a different branch.


bump to golang 1.9.4

new round of security fixes in golang

build failed...  run: attempted fallback to API v1 but not supported

official golang docker image has not been pushed yet.

coreosbot run e2e


Updating the hyperparameter search space

Given the recent experiments with the cocktails, I think the hyperparameter search space needs this update in the case when the architecture is not restricted. And this is a general update and not only related to the cocktails.
https://arxiv.org/abs/2006.13799
Matches the search space from the paper above and adds log sampled weight decay values.

Thank you for this PR. We'll need these changes when we want to compare this to the paper version. I don't think the weight decay is on a log scale, other than that these changes look good

@ravinkohli I would say that common practice has it that you sample on the log scale for the l2 regularization term too as it is here: https://ml.informatik.uni-freiburg.de/papers/16-AUTOML-AutoNet.pdf
So, I would suggest keeping this addition that changes from the paper.

Closing the pull request since I added it in the cocktails branch and we can later merge it into development.


musicBert SMALL base MODEL error

when i run: $ bash train_mask.sh lmd_full small with provided small model,
fairseq gets error:
-- Process 3 terminated with the following error:
Traceback (most recent call last):
File "/usr/local/anaconda3/envs/pyg/lib/python3.6/site-packages/torch/multiprocessing/spawn.py", line 19, in _wrap
fn(i, *args)
File "/mmu_ssd/chenjunmin/apps/fairseq-0.10.0/fairseq/distributed_utils.py", line 270, in distributed_main
main(args, **kwargs)
File "/mmu_ssd/chenjunmin/apps/fairseq-0.10.0/fairseq_cli/train.py", line 114, in main
disable_iterator_cache=task.has_sharded_data("train"),
File "/mmu_ssd/chenjunmin/apps/fairseq-0.10.0/fairseq/checkpoint_utils.py", line 193, in load_checkpoint
reset_meters=reset_meters,
File "/mmu_ssd/chenjunmin/apps/fairseq-0.10.0/fairseq/trainer.py", line 279, in load_checkpoint
state = checkpoint_utils.load_checkpoint_to_cpu(filename)
File "/mmu_ssd/chenjunmin/apps/fairseq-0.10.0/fairseq/checkpoint_utils.py", line 232, in load_checkpoint_to_cpu
state = _upgrade_state_dict(state)
File "/mmu_ssd/chenjunmin/apps/fairseq-0.10.0/fairseq/checkpoint_utils.py", line 436, in _upgrade_state_dict
registry.set_defaults(state["args"], tasks.TASK_REGISTRY[state["args"].task])
AttributeError: 'NoneType' object has no attribute 'task'

Currently, you can use a newer version of fairseq that will work on provided checkpoints.
git clone https://github.com/pytorch/fairseq
cd fairseq
git checkout 336942734c85791a90baa373c212d27e7c722662   # provided checkpoints are trained with this version
pip install --editable ./

Hi, I tried 'bash train_nsp.sh next checkpoints/checkpoint_last_musicbert_base.pt ' and there occurs an error:
Traceback (most recent call last):
File "/usr/local/anaconda3/envs/tf2.2_ljw/bin/fairseq-train", line 33, in
sys.exit(load_entry_point('fairseq==1.0.0a0', 'console_scripts', 'fairseq-train')())
File "/usr/local/anaconda3/envs/tf2.2_ljw/lib/python3.6/site-packages/fairseq-1.0.0a0-py3.6-linux-x86_64.egg/fairseq_cli/train.py", line 541, in cli_main
parser = options.get_training_parser()
File "/usr/local/anaconda3/envs/tf2.2_ljw/lib/python3.6/site-packages/fairseq-1.0.0a0-py3.6-linux-x86_64.egg/fairseq/options.py", line 38, in get_training_parser
parser = get_parser("Trainer", default_task)
File "/usr/local/anaconda3/envs/tf2.2_ljw/lib/python3.6/site-packages/fairseq-1.0.0a0-py3.6-linux-x86_64.egg/fairseq/options.py", line 234, in get_parser
utils.import_user_module(usr_args)
File "/usr/local/anaconda3/envs/tf2.2_ljw/lib/python3.6/site-packages/fairseq-1.0.0a0-py3.6-linux-x86_64.egg/fairseq/utils.py", line 491, in import_user_module
importlib.import_module(module_name)
File "/usr/local/anaconda3/envs/tf2.2_ljw/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 994, in _gcd_import
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/team5/l00519917/musicbert/musicbert/init.py", line 15, in
from fairseq.models.roberta import TransformerSentenceEncoder, RobertaEncoder, RobertaModel
ImportError: cannot import name 'TransformerSentenceEncoder'
I followed the above suggestion to install a newer version of  fairseq 1.0.0a0.  It seems that  TransformerSentenceEncoder is not in the model. Please help, thanks a lot.

Did you install the exact version?
git+https://github.com/pytorch/fairseq@336942734c85791a90baa373c212d27e7c722662#egg=fairseq

Hi, I can't directly use git clone. Cloud you please tell me which exactly version is this: https://github.com/pytorch/fairseq@336942734c85791a90baa373c212d27e7c722662#egg=fairseq?
Is it fairseq v0.10.0?

It doesn't correspond to a released version, so you have to install it from git repo.

Thanks a lot, problem sloved.


Web-native TFChain Wallet Client using Rust/WASM

Estimated time: <=2 weeks
A basic (light client, using an http(s) connection to an explorer of choice, our official ones by default) wallet, that allows the user to check their balance, generate addresses, manage and usage multi sig wallets (with auto-detection of these, as well as generation and labelling of them).
As a result we already have a lot of library Rivine and TFChain code ready in Rust, that can be used to write a full client if desired, as well as an entire generic blockchain library (or libraries) that can be used to build a Rivine Blockchain quickly.
On top of that it will give us an immediate benefit as it would be the first tfchain client supporting multi-sig, that is also useable by actual end users and not just people that know JSX or CLI. Given it will be a web client, it should also be possible to be used by mobile users given they have a modern enough phone.

Required Work:

Rust Code required to write: primitive types, transactions, crypto (signatures + hashes), glue between frontend and library (client business logic);
Frontend Code (interface of the client);

These 2 parts of the project can be done in parallel by 2 different people, making a deadline of <= 2 weeks very realistic.

➤ Glen De Cauwsemaecker commented:
Alternatives:

Write a Web Client using Go/WASM: this is not going to be pretty, WASM support in Go is still limited, and from experiments by our team with it it is clear that it will be a pain in the ass to develop a web client using it;
Write it in Typescript (or another web tech), requires as much work as doing it in Rust, with the drawback that we don't have another use case in mind for the library code that would be written for it;
Don't do this and and wait for the current TFChain Mobile Wallet to give support: from experience with the mobile app team this might take a month or more;
Don't do this and wait for the 3Bot Jimber Wallet: this is still in the early development stages, and is not expected in the next month, so we would have to wait even longer;

If we don't do anything, it is currently impossible for a regular end user to use multi signature wallets with tfchain, as I think it is unfair to expect from a non-technical person to use a CLI client, or a JSX client. As beautiful, easy to use and well documented JSX might be in the future, currently it is not suited for the end users as even our programmers are still having a challenge with it.

➤ Glen De Cauwsemaecker commented:
There are already plenty of articles that give inspiration (e.g. https://medium.com/@saschagrunert/a-web-application-completely-in-rust-6f6bdb6c4471), together with my production experience in Rust (is already 2 years ago though, so will need to refresh some knowledge on-the-go), it seems like a very do-able story. Useful and fun, a great combination.


Invalid Datetime Format when trying to update user profile.

Laravel Version: 5.3.*
Voyager Version: 0.10.8
PHP Version: 7.0.4
Database Driver & Version: MySQL v 5.7.11

Description:
Trying to update User Profile then can not save to DB with Invalid Date Time Format.

Remove created_at field from edit visibility on Users bread http://localhost:8000/admin/database/bread/3/edit

Duplicate of #521

Closed due duplicate.


PLNSRVCE-658: add k8s resource quota as an option (kcp env)

still defaults to openshift for now (for the apicurio e2e test)
long term should pivot to defaulting to k8s for kcp once/if we have kcp based CI
I did add the systemconfig field vs. just picking the quota type based on kcp detection in main.go to allow for the possibility of defining quota on the workspace/compute clusters vs. at the kcp mgmt level.

/test jvm-build-service-in-repo-apicurio-e2e

/test jvm-build-service-in-repo-apicurio-e2e

/retest

/test jvm-build-service-in-repo-apicurio-e2e

/test jvm-build-service-in-repo-apicurio-e2e

apicurio is green
    types.go:25: time: 2022-10-06 14:47:13.876749616 +0000 UTC m=+2811.383816261: dependencybuild created count: 117 complete count: 89, failed count: 26, contaminated count: 1 building count 1
    types.go:25: time: 2022-10-06 14:47:14.795353894 +0000 UTC m=+2812.302420539: all prs are done out of 519 items
    types.go:25: time: 2022-10-06 14:47:14.795395354 +0000 UTC m=+2812.302461999: dependencybuild created count: 117 complete count: 89, failed count: 27, contaminated count: 1 building count 0
    types.go:25: time: 2022-10-06 14:47:15.984979213 +0000 UTC m=+2813.492045858: all prs are done out of 519 items
    types.go:25: time: 2022-10-06 14:47:15.985009243 +0000 UTC m=+2813.492075888: dependencybuild FINAL created count: 117 complete count: 89, failed count: 27, contaminated count: 1

And plenty of throttling events over in https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/redhat-appstudio_jvm-build-service/289/pull-ci-redhat-appstudio-jvm-build-service-main-jvm-build-service-in-repo-apicurio-e2e/1578011898966708224/artifacts/jvm-build-service-in-repo-apicurio-e2e/gather-extra/artifacts/events.json
I'm merging given @stuartwdouglas 's prior approval
Eventually, when we have KCP based CI, and https://github.com/openshift-pipelines/pipeline-service-workspace-controller is setting pod count quota in that env, we can change the default throttling to use k8s quota, and most likely we do not have to create openshift cluster quota in the periodic e2e.


Does tooltip work if data-tip is set by a request that can take some time?

So.. all the tooltips work if I use it on html direct like <button data-tip="test" />
But If I use a component <Help tooltip="test" /> seems not working, why?
I import react-tooltip on my App.js.
Also App.js got the: <ReactTooltip place="bottom" effect="solid" />
My component Help (that one that not work tooltip) is the following:
const tooltip = this.props.tooltip || "Tooltip";
<div className="Help" data-tip={tooltip}> {children} </Help>

But the Help component is inside a request on other pages and It can take some seconds to spawn. Why is not working? The others tooltips works fine.
Thanks.
EDIT: I tested ReactToolTip.rebuild but doesn't work either.
EDIT2: I use StoryBook to make the documention and the component Help works nice with the tooltip there. Why doesn't work on my other pages? :/

I fixed it by adding the Import from ReactTooltip on each page and using the Rebuild option after the request complete.
                    ReactTooltip.rebuild();


⚠ SceneTime has degraded performance

In 0c82394, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1824 ms

Resolved: SceneTime performance has improved in 71f5949 after 6 minutes.


Querying on multiple index

Hi,
Is it possible to query multiple index (for instance : index A and index B) ?
Regards,
Tchaly

ElasticPlateMessage::search()->index('myIndex1,myIndex2')->get();
Works


Autoresize graph in a div with changing width/height

HI.
I add a line chart directive with no width/height in a div which can be extend.
When i extend the div, nothing change on the graph, but when I Open/Close/Move the FF console view, the graph resize auto on the new Div max size.
An issue tell about the viewBox which have to be manipulate. my svg viewbox is "0 0 undefined undefined".

Just in case sb had the pb, put  this somewhere :
window.dispatchEvent(new Event('resize'));

This is having issues on Firefox current stable.
Desc: Svg resizes well after height/width changes, but inner elements are keeping their size. This happens only after few re-sizings.


Wagner Lab Use Case - Poor Brain Mask

We are using fMRIPrep to preprocess fMRI data from a sample of older adults. For a number of subjects the EPI brain mask is inaccurate, and the accuracy of the mask often varies considerably from run to run. Any advice for how to improve the accuracy and reliability of this step would be very much appreciated!
What version of fMRIPrep are you using?
We are using fmriprep v20.2.1, run via Singularity on Sherlock, and used the following command:
/usr/local/miniconda/bin/fmriprep /oak/stanford/groups/awagner/AM/FMRIPREP/trimmed_data /oak/stanford/groups/awagner/AM/FMRIPREP/trimmed_data/derivatives/fmriprep-20.2.1 participant --participant-label 125
-w /work/ -vv --omp-nthreads 8 --nthreads 12 --mem_mb 30000 --skip_bids_validation --fs-license-file /home/users/atrelle/freesurfer.txt --skull-strip-t1w force --dummy-scans 5 --fd-spike-threshold 0.9 --dvars-spike-threshold 3.0 --output-spaces MNI152NLin2009cAsym:res-2 anat fsnative fsaverage5
The subjects are BIDS valid, run without error, and are using previously computed FreeSurfer outputs.
Reports can be found at /oak/stanford/groups/awagner/AM/FMRIPREP/trimmed_data/derivatives/fmriprep-20.2.1/fmriprep/${subject}/
See examples of outputs for some impacted subjects (sub-020, sub-030, sub-125) below:

Hi,
Isn't the mask calculated from the T1w image and projected back to the bold space? Maybe there is an issue with the bold-to-T1w registration? Perhaps using the option --bold2t1w-init headermay help? or other like --bold2t1w-dof or check the distorsion correction step?

Just to bring some closure to the issue:
The problematic subjects tended to have large negative values - clipping the images to remove these negative values seemed to fix the co-registration and masking errors. This clipping (for both extremely negative/positive values) is something planned for the next upcoming release.


[9.x] Add contract for notification channels

As we call send method on notification channel (NotificationSender.php), maybe we could use contracts to implement it every notification channel.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


ci: Add concurrency groups to e2e tests

Adding a concurrency group to the e2e tests so that if a new commit is pushed before the previous action run is completed, the workflow will cancel the old run. This saves time and resources.

Just a nitpick - recommend adding more disciplined triggers like the below. Besides that, the concurrency stop-condition makes sense and looks good!
on:
  push:
    branches: [main]
  pull_request:
    branches: [main]
    types: [opened, edited, synchronize]

The default trigger types for a pull request are already opened, synchronized, and reopened. edited is when the description of the PR is updated and I don't think we need a new workflow to trigger when that happens.
As for the branches, I think it makes sense to still run the workflows if a PR is made to the non-default branch. Right now our branch protection rules don't require those checks to pass, but I think it's still good informational context to keep available.


Add Swift Package Manager support

Addresses https://github.com/AssistoLab/DropDown/issues/247
Because SPM is multi-platform and UIKit is iOS-specific, I had to add #if os(iOS) blocks in each file that imported UIKit.

@ iwb-kevin-hirsch reviews this!


Support for RON

The TOML support is awesome! It would be cool if this project also supported RON. I've used it on several projects for configuration. It supports comments like TOML but is also good for nested data like JSON .

Hi, yeah - RON support would be nice, thanks for the suggestion 🙂


requirements.txt is incorrect... no way you require that many packages

Looks like you generated requirements.txt using pip list or pip freeze.
I don't believe your app requires all the packages!
You should run you app in a virtualenv and determine the absolute minimum number
of packages your app really needs.
Start with only the ones that you know you need, such as django, python-decouple,
and django-allauth.
repeat until project runs:
   delete current virtual environment
   create a new virtualenv
   install packages using pip -r requirements.txt
   run your project
   run your E2E test to force it to execute a lot of the code
   If it fails, look at what package is missing and add it to requirements.txt

Much better now.  Are "wheel" and "selenium" really needed for running the app?


Update KEP-349 to reflect actual state of the WaitForPodsReady API

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Updates KEP-349 to reflect actual state of the WaitForPodsReady API
Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/assign @mimowo


Empty page (status code: 404)

Hi,
I tried following your instructions and set up on the new Amazon Linux instance.
After my new EC2 started, when I navigate to :8080 , I got a blank page with status code as 404.

Actually I figured it out.
In my case,
sed -i '375a\
and
sed -i '444a\
inserted the additional config in wrong place (off by one line).
This caused the web.xml malformed.
After correcting the web.xml, it is working correctly now.


Templating infowindows modal

@saleiva what do you think?

Last update after talk with @saleiva

:green_heart:

:+1:


Refactor Navigator

Let's be honest, the current one is absolutely mediocre.

Hi Zanid,

Navigator widget needs to be remade into a proper one,

When you say made into a proper one – I would be interested to know what features you think the navigator should have and what are its shortcomings of the current one?

Hello!
Limitations:

The way it calculates the bbox is sometimes wrong. It tries to calculate the full view box (pan/movements + original canvas size), but that's not needed and can just be a headache to maintain. The library doesn't have "papers", so nothing is fixed size, which means while the user scrolls the navigator just gets distorted, which doesn't really help the user I believe.
Panning changes the size of the current view and the nodes, which lets you believe zooming happens when it doesn't.
There are a couple of bugs with the implementation that shows nodes in a different place and even exceptions for things not properly handled.

Better implementation:

The full view box = the boundary of all the nodes + a margin. This fixes everything in place while only the current view changes with the user's actions.
Add the possibility to draw multiple shapes, not just squares. We'll probably take the shape from the node's shape.

Of course I'm open to discussion!


Conform Rational to Strideable

This would enable the creation of a CountableClosedRange<MetricalDuration> down the road.

See: Strideable.
Just required is: advanced(by:) and distance(to:), along with the associated type Stride.


Support adding signers dissociated from the vault creation flow

Support adding of signers separately which is exclusive of the vault creation flow and persist these signers to use them at the time of vault creation.

Just remember that after or during the vault creation, even if a device was already added in the app, the user should still register the vault/ verify it on the device (the HWW) itself.

Verified this issue on keeper app v 1.1.9(288)


Fetch

Modified the fetch file for task 2f of Week 3. Uses fetch to get an array of string from the data servlet and feed it into the random quote webpage.
I created a new DataServlet.java file to do this, unsure if this was the right way to go about it.

This PR contains changes from the first PR too which makes it difficult and longer to review.
To resolve this you can either:

Wait until the first PR is merged in master. OR
Change the base branch of the Pull Request to "discover-website" so we can start reviewing it, change it back to master once "discover-website" has been merged.
https://github.blog/2016-08-15-change-the-base-branch-of-a-pull-request/


error building for android with the latest adapter

Hello, I am getting this error building my project using the latest version of the adapter:

I am not getting any error using the previous version of the adapter. Any suggestion? Thanks.

Hi,
Thanks for reporting this. Could you please try using the attached jar instead, and let me know how it went? Just make sure to change the file extension from "txt" to "jar".
applovin-adapter-new.txt

Hey,
Thanks for responding very quickly, I am going to try this now and get back to you asap.

@gilmincbergapplovin whoa, this is perfect, no more error when building the project, and I can also confirm that the ads served properly as well, great job!

@gilmincbergapplovin sorry, one more thing, so I am trying to mediate AppLovin for interstitial ads as well, but I can't see AppLovin in the list of network sources for interstitial ads:

AppLovin only appear for Rewarded Video unity type, is this expected?

Hi,
I am glad to hear that the issue was solved. Thanks for the update.
Regarding interstitials: Our network is not part of the default networks for interstitial integration. You would need to integrate it as a custom event, as described in our docs here:
https://www.applovin.com/integration#adMobIntegration

Ah, got it, I missed that part, thanks again.


add print/printf for debugging

wip
depends on #19

Code looks good to me, just needs a format to pass the ci lint and then I'll approve it

done!


Upon changing the filter the incorrect state is displayed expanded

Describe the bug
If state (let's say at position 3 ) is expanded by user and after that a filter is added > Incorrect state is displayed as expanded
To Reproduce
Steps to reproduce the behavior:

Go to Dashboard
Click on any state to expand let's say the state on 3rd Position
Change the order by applying filter ( let's say by recovered )
Notice that the order of states have changed now but the expanded state is still the 3rd State instead of the state which was expanded by the User.

Expected behavior
State which was expanded by the user should be displayed as expanded after any filter
Smartphone (please complete the following information):

Device: [OnePlus 7t]
OS: [Android 10]
Browser [I used Chrome]

Nice catch! Though it seems a bit more complicated than the state at the same index being expanded.

Can I work on this?

#245 PR Raised


Legacy project-level certificate page displays as a table -> this page should not have a box around it

on v2.6.0-rc9:
Repro Steps:

enable legacy flag
deploy a downstream cluster
once the downstream cluster is active, go to the cluster and navigate to legacy -> project -> secrets
view the secrets vs. certificate pages

expected result:
There should be no bounding box around the elements in the certificates page.

on 2.6-head (a6e7905):

the extra box is no longer visible on this page (or any other legacy pages that were checked)


[IA-2930][IA-2701][DO NOT MERGE] Implement R file syncing and proper RStudio analysis preview/launch flow

Testing this PR depends on manually updating leo conf file to point to a newer welder hash than exists in dev, and hotswapping it to your fiab (see linked PR for necessary code change). This means this PR cannot be merged until this is.
This PR ensures storageLinks is called on RStudio application launch, which results in any .Rmd files in the users bucket in the notebooks/ folder being localized for editing. Any files saved in the RStudio editor will then be delocalized back to the bucket.
Today, the only way to create and interact with .Rmd files is the RStudio editor. With the analysis tab, we will also support Rmd preview and launching from the preview page, where we also interface with localization. This PR updates this, and touches up the buttons to reflect that RStudio does not launch the editor with a particular file in mind, where as Jupyter does. See screenshots below.
RStudio Preview:

RStudio with files localized:

When I created a new RStudio runtime, a pop-up with a LAUNCH button came up. When I clicked on that button, I got the error below.

The same error occurred when I clicked on Launch RStudio on the modal below:

The error may be due to the 502 I see on the browser console:

When I launch RStudio using the modal below

I see the following on the console

When I created a new RStudio runtime, a pop-up with a LAUNCH button came up. When I clicked on that button, I got the error below.

The same error occurred when I clicked on Launch RStudio on the modal below:

The error may be due to the 502 I see on the browser console:

After dismissing the error pop-ups, I can see the RStudio session. Note that it has an error in red on the bottom:

Yeah, sorry localize won't work without the updated welder was in the weeds a bit too long while writing PR desc, I updated it with details.

When I launch RStudio using the modal below

I see the following on the console

Hmm.. seems this was introduced a few PRs ago, and this https://github.com/DataBiosphere/terra-ui/pull/2624/files#diff-44105412b7d7ce49a5ee9ac6b7202ea01d275dbd1054339f21abebdf163349e5R23 fixes it, but I'm a little confused as to what changed along the way as that tab never had to pass that prop (code is 2 years old) and the issue doesn't seem to exist in dev

When clicking on an RStudio analysis as shown below

I see an accessibility warning appear on the console as shown below

@jdcanas Thank you for addressing my comments. Just three more nits: 1, 2, 3

I did some testing:

Pointed local UI to dev Leo
Created RStudio runtime
Created Rmd file in RStudio
The file appeared in my workspace!

I then made some changes to the Rmd file in RStudio and verified it was reflected in the workspace (and I could preview it).
I did notice 1 oddity with delete and rename operations. If I delete an Rmd file in the workspace, it disappears… but if I wait a few seconds it reappears again. I think this is because the file is still on my persistent disk, and the running welder process re-syncs all Rmd files. Should delete in the UI also destroy the storage link / file on the PD?
Also I think we should test this scenario:

User A creates a runtime, creates a Rmd file, stops their runtime.
User B creates a runtime, makes some changes to the Rmd file, stops their runtime.
User A starts their runtime again, and overwrites User B's edits with a stale version of the Rmd file.
I'm not sure how welder behaves here, but it's important as it could lead to lost work. I can try and test this out..

A couple things:

Links or buttons that already contain descriptive text shouldn't have additional aria labels. Only those whose only children are icons need them. Adding unnecessary labels adds a potential source of inconsistency.
We avoid backtick-delimited template strings when they don't contain any interpolation or newlines. There are quite a few of these in this PR, could you convert them to normal strings?
Adding aria labels to components that aren't mapped directly to a DOM node, like PreviewHeader, is a no-op, as the prop isn't used, so we shouldn't do that.

Not sure what you are calling attention to here. There are no Links/Buttons with a description field. Do you mean ones with tooltip? Ones with text as a child? Some examples would be helpful. Also, is it really a big deal to have an extra descriptive field on components? A big enough deal to hold up this already-gated-20-days-in-review-PR?
Done. Seems like this should be something enforced by a linter if we care enough to block PRs for it, and if an industry-standard linter cannot enforce, it I'm of the opinion it is a bit too pedantic to block PRs for.
This component was in the (unclear) stacktrace around accessibility labels. Removed.

By "contain descriptive text", I mean that an element has useful descriptive text within its children.
By inspecting the page using ANDI, we can see that, in cases where there's both an aria label and text content, the aria label is read instead of the text content. Thus, for people with screen readers, they won't be able to access the text in a link at all. Unless the aria label is significantly more descriptive than the inner text (in which case we should probably change the inner text), we would prefer that they hear what we wrote.
The intention behind enforcing single quotes is consistency, especially with an eye for new developers in the codebase. If they see backticks, that should be a signal for them that the string includes interpolation. We have a number of things that the linter doesn't enforce, but we find useful for readability. For example, we don't enforce line lengths through a linter rule because we've encountered occasional instances where it's more readable to exceed a given length, but most of the time we try to break at ~120.


Add includeOriginalMessageValue option needed for ssb-backlinks

I was comparing the forks used in both ssb-private and ssb-backlinks. ssb-private works with vanilla now, but ssb-backlinks need this patch.
This is another thing that was in the fork that I don't think is need anymore:
  // HACK: allow manual selection of indexes
  if (opts.index) {
    index = indexes.find(x => x.key === opts.index)
  }

An option you can pass to force the query to use a specific index. While this might be fine on its own, the original problem was: https://github.com/ssbc/patchwork/issues/556. And we now have explain so I would rather we find out why the index selection didn't work and if we can fix it to use the correct index. There might be changes since that actually makes it pick the right index now.
This should close #6

On second thought the message value is very specific to ssb, maybe includeOriginalMessage would be better?

I would call the option something like "unmappedValues". given that we already have options "keys" and "values" this option should be plural, and and "include" is implied. I think "unmapped" is clearer than "original". original could mean all sorts of things, but we already have a "map" function that this... Oh looking at the code I realize that that function is called "links" and there is no other documentation of it...
In situations like this, if I misremember what a parameter name was, I figure that what I thought it was is evidently the more obvious name, and so it should be changed to "map" what do you think? I could settle for unlinkedValues but I have a pet peve about reallyLongCamelCaseNames

I like the unlinkedValues name. Updated PR.

awesome, merged into 6.1.0


ignore camelcase at specific variable

hello,
I just wanted to ask whether it is possible to ignore camel case at some specific variables that must be written without camel case?

This is a better question for the jshint team, this project simply combines jshint and gulp.


Sign In To Sync setting appears on every launch

Hi Anytime I launch VSCODE i get this message " sign in to sync settings " but i already did that login with my Github account already about three years ago until version 1.82 i get that message anytime i launch VSCODE Please Fix it it keeps bugging me down please, and also  IS STILL KEEPS SHOWING AFTER I UPDATED TO VERSION 1.84.2 PLEASE FIX IT Thanks.

@TylerLeonhardt Can you please check with the user that it is not auth related?

Hi @sandy081 please Is There Any Update On This Issue?

Can you follow these steps so that we can get more information on what's going on?

Open the Command Palette
Run the Developer: Set Log Level... command
To the right of Trace, click the double check mark button. ✔ ✔ (enables trace logging as the default)
Wait for the issue to happen...
Open the Output pane (ctrl+shift+u I think on Windows)
drop in this issue he contents of the following:

Microsoft Authentication Output channel
Log (Settings Sync) Output channel
Log (Main) Output channel

Open the Command Palette
Run the Developer: Set Log Level... command
To the right of Info, click the double check mark button. ✔ ✔ (to set the default back to info)

@TylerLeonhardt  please can you elaborate more on this i don't understand please. if you could add pictures to show the steps

@James-Caesar updated the steps.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

@James-Caesar updated the steps.

2024-01-03 14:02:24.310 [info] Using settings sync service https://vscode-sync.trafficmanager.net/
2024-01-03 14:02:24.311 [info] Auto Sync is enabled.
2024-01-03 14:02:24.311 [info] Auto Sync: Suspended until auth token is available.
2024-01-03 14:02:45.420 [info] Deleting non existing profile from backup /C:/Users/CAESA/AppData/Roaming/Code/User/sync/extensions
2024-01-03 14:02:46.964 [info] Deleting non existing profile from backup /C:/Users/CAESA/AppData/Roaming/Code/User/sync/globalState
2024-01-03 14:02:48.512 [info] Deleting non existing profile from backup /C:/Users/CAESA/AppData/Roaming/Code/User/sync/keybindings
2024-01-03 14:02:48.875 [info] Deleting non existing profile from backup /C:/Users/CAESA/AppData/Roaming/Code/User/sync/profiles
2024-01-03 14:02:49.515 [info] Deleting non existing profile from backup /C:/Users/CAESA/AppData/Roaming/Code/User/sync/settings
2024-01-03 14:02:50.072 [info] Deleting non existing profile from backup /C:/Users/CAESA/AppData/Roaming/Code/User/sync/snippets
2024-01-03 14:02:50.427 [info] Deleting non existing profile from backup /C:/Users/CAESA/AppData/Roaming/Code/User/sync/tasks
2024-01-03 14:04:17.402 [info] Auto Sync: Triggered by Interval
2024-01-03 14:04:17.407 [info] Sync started.
2024-01-03 14:04:21.176 [info] Settings: Last sync resource does not exist locally.
2024-01-03 14:04:24.578 [info] Settings: No changes found during synchronizing settings.
2024-01-03 14:04:24.760 [info] Keybindings: Last sync resource does not exist locally.
2024-01-03 14:04:26.178 [info] Keybindings: No changes found during synchronizing keybindings.
2024-01-03 14:04:26.316 [info] Snippets: Last sync resource does not exist locally.
2024-01-03 14:04:28.052 [info] Snippets: No changes found during synchronizing snippets.
2024-01-03 14:04:28.063 [info] Tasks: Last sync resource does not exist locally.
2024-01-03 14:04:29.707 [info] Tasks: No changes found during synchronizing tasks.
2024-01-03 14:04:29.811 [info] GlobalState: Last sync resource does not exist locally.
2024-01-03 14:04:31.205 [info] GlobalState: No changes found during synchronizing ui state.
2024-01-03 14:04:31.319 [info] Extensions: Last sync resource does not exist locally.
2024-01-03 14:04:36.959 [info] Extensions: No changes found during synchronizing extensions.
2024-01-03 14:04:37.060 [info] Profiles: Last sync resource does not exist locally.
2024-01-03 14:04:37.815 [info] Profiles: No changes found during synchronizing profiles.
2024-01-03 14:04:37.893 [info] Sync done. Took 20491ms
2024-01-03 14:05:48.626 [info] Auto Sync: Triggered by Activity
2024-01-03 14:05:48.628 [info] Sync started.
2024-01-03 14:05:52.998 [info] Settings: No changes found during synchronizing settings.
2024-01-03 14:05:54.138 [info] Keybindings: No changes found during synchronizing keybindings.
2024-01-03 14:05:55.609 [info] Snippets: No changes found during synchronizing snippets.
2024-01-03 14:05:56.354 [info] Tasks: No changes found during synchronizing tasks.
2024-01-03 14:05:57.673 [info] GlobalState: No changes found during synchronizing ui state.
2024-01-03 14:06:28.176 [info] Extensions: No changes found during synchronizing extensions.
2024-01-03 14:06:28.185 [info] Profiles: No changes found during synchronizing profiles.
2024-01-03 14:06:28.189 [info] Sync done. Took 39522ms
2024-01-03 14:07:44.839 [info] Auto Sync: Triggered by Activity
2024-01-03 14:07:44.844 [info] Sync started.
2024-01-03 14:07:45.492 [info] Settings: No changes found during synchronizing settings.
2024-01-03 14:07:45.525 [info] Keybindings: No changes found during synchronizing keybindings.
2024-01-03 14:07:45.553 [info] Snippets: No changes found during synchronizing snippets.
2024-01-03 14:07:45.576 [info] Tasks: No changes found during synchronizing tasks.
2024-01-03 14:07:45.606 [info] GlobalState: No changes found during synchronizing ui state.
2024-01-03 14:07:47.793 [info] Extensions: No changes found during synchronizing extensions.
2024-01-03 14:07:47.809 [info] Profiles: No changes found during synchronizing profiles.
2024-01-03 14:07:47.812 [info] Sync done. Took 2972ms
2024-01-03 14:07:58.446 [info] Auto Sync: Triggered by Activity
2024-01-03 14:07:58.448 [info] Sync started.
2024-01-03 14:08:00.371 [info] Settings: No changes found during synchronizing settings.
2024-01-03 14:08:00.398 [info] Keybindings: No changes found during synchronizing keybindings.
2024-01-03 14:08:00.555 [info] Snippets: No changes found during synchronizing snippets.
2024-01-03 14:08:00.579 [info] Tasks: No changes found during synchronizing tasks.
2024-01-03 14:08:00.666 [info] GlobalState: No changes found during synchronizing ui state.
2024-01-03 14:08:03.435 [info] Extensions: No changes found during synchronizing extensions.
2024-01-03 14:08:03.449 [info] Profiles: No changes found during synchronizing profiles.
2024-01-03 14:08:03.460 [info] Sync done. Took 5015ms
2024-01-03 14:12:58.472 [info] Auto Sync: Triggered by Activity
2024-01-03 14:12:58.474 [info] Sync started.
2024-01-03 14:12:59.837 [info] Settings: No changes found during synchronizing settings.
2024-01-03 14:12:59.863 [info] Keybindings: No changes found during synchronizing keybindings.
2024-01-03 14:12:59.891 [info] Snippets: No changes found during synchronizing snippets.
2024-01-03 14:12:59.921 [info] Tasks: No changes found during synchronizing tasks.
2024-01-03 14:12:59.968 [info] GlobalState: No changes found during synchronizing ui state.
2024-01-03 14:13:02.953 [info] Extensions: No changes found during synchronizing extensions.
2024-01-03 14:13:02.955 [info] Profiles: No changes found during synchronizing profiles.
2024-01-03 14:13:02.960 [info] Sync done. Took 4339ms
2024-01-03 14:13:11.061 [info] Auto Sync: Triggered by Activity
2024-01-03 14:13:11.068 [info] Sync started.
2024-01-03 14:13:11.786 [info] Settings: No changes found during synchronizing settings.
2024-01-03 14:13:11.985 [info] Keybindings: No changes found during synchronizing keybindings.
2024-01-03 14:13:12.028 [info] Snippets: No changes found during synchronizing snippets.
2024-01-03 14:13:12.056 [info] Tasks: No changes found during synchronizing tasks.
2024-01-03 14:13:12.173 [info] GlobalState: No changes found during synchronizing ui state.
2024-01-03 14:13:14.368 [info] Extensions: No changes found during synchronizing extensions.
2024-01-03 14:13:14.382 [info] Profiles: No changes found during synchronizing profiles.
2024-01-03 14:13:14.396 [info] Sync done. Took 3335ms
2024-01-03 14:13:24.316 [info] Auto Sync: Triggered by Activity
2024-01-03 14:13:24.319 [info] Sync started.
2024-01-03 14:13:24.769 [info] Settings: No changes found during synchronizing settings.
2024-01-03 14:13:24.799 [info] Keybindings: No changes found during synchronizing keybindings.
2024-01-03 14:13:24.826 [info] Snippets: No changes found during synchronizing snippets.
2024-01-03 14:13:24.847 [info] Tasks: No changes found during synchronizing tasks.
2024-01-03 14:13:24.875 [info] GlobalState: No changes found during synchronizing ui state.
2024-01-03 14:13:27.613 [info] Extensions: No changes found during synchronizing extensions.
2024-01-03 14:13:27.625 [info] Profiles: No changes found during synchronizing profiles.
2024-01-03 14:13:27.636 [info] Sync done. Took 3326ms
2024-01-03 14:13:45.381 [info] Auto Sync: Triggered by Activity
2024-01-03 14:13:45.382 [info] Sync started.
2024-01-03 14:13:45.841 [info] Settings: No changes found during synchronizing settings.
2024-01-03 14:13:45.898 [info] Keybindings: No changes found during synchronizing keybindings.
2024-01-03 14:13:45.946 [info] Snippets: No changes found during synchronizing snippets.
2024-01-03 14:13:46.032 [info] Tasks: No changes found during synchronizing tasks.
2024-01-03 14:13:46.121 [info] GlobalState: No changes found during synchronizing ui state.
2024-01-03 14:13:47.845 [info] Extensions: No changes found during synchronizing extensions.
2024-01-03 14:13:47.847 [info] Profiles: No changes found during synchronizing profiles.
2024-01-03 14:13:47.858 [info] Sync done. Took 2476ms

@TylerLeonhardt  check it out please

Hi @James-Caesar sorry for the delay here,


client: cleanup old java.security.ciphers tomcat config

This removes old tomcat specific java.security.ciphers file that no
longer overrides and disables JAVA TLS algorithms. The preferred way
is to configure the global java.security file in
$JRE_HOME/lib/security/java.security.
Fixes #3140
Doc PR https://github.com/apache/cloudstack-documentation/pull/26/files
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[x] Cleanup (Code refactoring and cleanup, that may add test cases)

A better fix will be on its way soon, closing this for now.