Fix dockerfile yum clean all

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
d40380405b2e21c2307b73f33292576a052b0eb6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes_istio


Update README.md

What changes does this PR do?
Update Readme.md
Adding name

@aparna2071 @Panquesito7  @E-fais @vielmetti
see now I have made changes

@aparna2071 all changes are made review it.


crono failes with self signed certificates

In my setup everything working fine except crono run fails.
portus-crono       | I, [2016-04-22T15:42:00.474747 #59]  INFO -- : Perform CatalogJob
portus-crono       |   Registry Load (0.2ms)  SELECT  `registries`.* FROM `registries`  ORDER BY `registries`.`id` ASC LIMIT 1000
portus-crono       | Exception: SSL_connect returned=1 errno=0 state=unknown state: certificate verify failed
portus-crono       | I, [2016-04-22T15:42:00.504563 #59]  INFO -- : Finished CatalogJob in 0.03 seconds
portus-crono       |   Crono::CronoJob Load (0.3ms)  SELECT  `crono_jobs`.* FROM `crono_jobs` WHERE `crono_jobs`.`id` = 1 LIMIT 1
portus-crono       | I, [2016-04-22T15:52:00.475009 #59]  INFO -- : Perform CatalogJob
........

details of my setup:
both registry server and portus web run behind nginx proxy ssl terminated with self signed certificates. Docker client and login and push & pull images. The registry webhook working perfectly on http. But the crono job fails with above exception.
How to use self signed certificates with crono?
There is also one more issue while setting up the registry on portus first run. Since the registry is on  FQDN dockerhub.xyz.com and on secure https it is not taking while adding for first time (may be its failing due to self signed certificate issue). To registry I've to give insecure docker linking name to get it working and than editing it to change it to FQDN.

It was an self signed certificate issue. Once the certificate added to the /usr/local/share/ca-certificates and updated the ca certificates the error gone.

Closing this then :) Bear in mind that next time you could probably ask this on our Google group :wink:


Name changes for org transfer

Change namespaces and build output to match new organization.  Fixes #101

THIS SOFTWARE IS CONTRIBUTED SUBJECT TO THE TERMS OF THE FINOS CORPORATE CONTRIBUTOR LICENSE AGREEMENT.
  THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (82f4224) 76.56% compared to head (f9a9a8b) 76.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   76.56%   76.56%
=======================================
  Files          53       53
  Lines         431      431
  Branches       44       44
=======================================
  Hits          330      330
  Misses         82       82
  Partials       19       19

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LGTM

Thanks @psmulovics and @mattjamieson


Changing app background color requires deprecated attribute background

Steps to reproduce

Run the example code

Expected results
Setting the surface attribute of the color scheme to Colors.white makes the whole app have a white background.
Actual results
Only the app bar turns white. To make the whole app have a white background, background has to be set as well. However, that has been deprecated and the proposed migration path is to use surface instead.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(
          seedColor: Colors.deepPurple,
          surface: Colors.white,
        ),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

Screenshots or Video
No response
Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.22.1, on Arch Linux 6.9.1-arch1-2, locale en_US.UTF-8)
    • Flutter version 3.22.1 on channel stable at /home/felipe/snap/flutter/common/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (6 days ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /home/felipe/Android/Sdk/
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /home/felipe/Applications/android-studio/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = chromium

[✓] Linux toolchain - develop for Linux desktop
    • clang version 10.0.0-4ubuntu1
    • cmake version 3.16.3
    • ninja version 1.10.0
    • pkg-config version 0.29.1

[✓] Android Studio (version 2022.2)
    • Android Studio at /home/felipe/Applications/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] Connected device (3 available)
    • Pixel 8 (mobile) • 3A101FDJH00722 • android-arm64  • Android 14 (API 34)
    • Linux (desktop)  • linux          • linux-x64      • Arch Linux 6.9.1-arch1-2
    • Chrome (web)     • chrome         • web-javascript • Chromium 125.0.6422.112 Arch Linux

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@Mr-Pepe
Does passing backgroundColor in Scaffold help in your case ?

@darshankawar  Thank you for the response.
I use GoRouter with nested navigation as explained in https://github.com/flutter/packages/blob/main/packages/go_router/example/lib/shell_route.dart, which requires nested scaffolds due to https://github.com/flutter/flutter/issues/122972. To get the white background everywhere, I would have to

Set surface in ThemeData,
Set backgroundColor of the root scaffold's bottom navigation bar, and
Set backgroundColor for each nested scaffold.

That doesn't seem very ergonomic.

Thanks for the feedback. Can you provide us the code sample involving go_router which shows current behavior ?

Looking through the code, it looks like the ColorScheme indeed defaults to surface if background isn't set, as a middle way until background is completely removed.
The problem seems to be that it always uses the one defined here so background is never not set:
const ColorScheme _colorSchemeDarkM3 = ColorScheme(
    ...
    background: Color(0xFF141218),
    ...
);

I am not exactly sure if that is the problem, but it is the color I see as the background color even when trying to set the surface color.
Setting the backgroundColor directly on the scaffold does work, or setting the scaffoldBackgroundColor on the ThemeData works, but that doesn't change that the current info about changing background to surface doesn't work as intended.

Here is a somewhat minimal example that illustrates the problem. It's a stripped-down version of the official example at:  https://github.com/flutter/packages/blob/main/packages/go_router/example/lib/shell_route.dart. Add GoRouter with flutter pub add go_router. Then run the below code sample as main.dart.
There is one ShellRoute that contains a scaffold with a bottom navigation bar. The router inserts different routes as the body of this root scaffold. The routes have to be scaffolds themselves to prevent the page transition issue raised in https://github.com/flutter/flutter/issues/122972. The bottom navigation bar and each nested scaffold now need to have their background color set explicitly. The color of the nested scaffolds' app bar is retrieved from the theme's surface color.
This means it's necessary to keep the background color in sync across many different places in the code base. Previously, setting the background color in the theme was enough.
Code sample
import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';

final GlobalKey<NavigatorState> _rootNavigatorKey =
    GlobalKey<NavigatorState>(debugLabel: 'root');
final GlobalKey<NavigatorState> _shellNavigatorKey =
    GlobalKey<NavigatorState>(debugLabel: 'shell');

void main() {
  runApp(ShellRouteExampleApp());
}

class ShellRouteExampleApp extends StatelessWidget {
  ShellRouteExampleApp({super.key});

  final GoRouter _router = GoRouter(
    navigatorKey: _rootNavigatorKey,
    initialLocation: '/a',
    debugLogDiagnostics: true,
    routes: <RouteBase>[
      ShellRoute(
        navigatorKey: _shellNavigatorKey,
        builder: (BuildContext context, GoRouterState state, Widget child) {
          return ScaffoldWithNavBar(child: child);
        },
        routes: <RouteBase>[
          GoRoute(
            path: '/a',
            builder: (BuildContext context, GoRouterState state) {
              return const ScreenA();
            },
            routes: <RouteBase>[
              GoRoute(
                path: 'details',
                builder: (BuildContext context, GoRouterState state) {
                  return const DetailsScreen(label: 'A');
                },
              ),
            ],
          ),
          GoRoute(
            path: '/b',
            builder: (BuildContext context, GoRouterState state) {
              return const ScreenA();
            },
            routes: <RouteBase>[
              GoRoute(
                path: 'details',
                builder: (BuildContext context, GoRouterState state) {
                  return const DetailsScreen(label: 'B');
                },
              ),
            ],
          ),
        ],
      ),
    ],
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(
          seedColor: Colors.deepPurple,
          surface: Colors.green,
        ),
      ),
      routerConfig: _router,
    );
  }
}

class ScaffoldWithNavBar extends StatelessWidget {
  const ScaffoldWithNavBar({
    required this.child,
    super.key,
  });

  final Widget child;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: child,
      bottomNavigationBar: BottomNavigationBar(
        backgroundColor: Colors.red,
        items: const <BottomNavigationBarItem>[
          BottomNavigationBarItem(
            icon: Icon(Icons.home),
            label: 'A Screen',
          ),
          BottomNavigationBarItem(
            icon: Icon(Icons.business),
            label: 'B Screen',
          ),
        ],
        currentIndex: _calculateSelectedIndex(context),
        onTap: (int idx) => _onItemTapped(idx, context),
      ),
    );
  }

  static int _calculateSelectedIndex(BuildContext context) {
    final String location = GoRouterState.of(context).uri.path;
    if (location.startsWith('/a')) {
      return 0;
    }
    if (location.startsWith('/b')) {
      return 1;
    }
    return 0;
  }

  void _onItemTapped(int index, BuildContext context) {
    switch (index) {
      case 0:
        GoRouter.of(context).go('/a');
      case 1:
        GoRouter.of(context).go('/b');
    }
  }
}

class ScreenA extends StatelessWidget {
  const ScreenA({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.yellow,
      appBar: AppBar(),
      body: Center(
        child: Column(
          mainAxisSize: MainAxisSize.min,
          children: <Widget>[
            const Text('Screen A'),
            TextButton(
              onPressed: () {
                GoRouter.of(context).go('/a/details');
              },
              child: const Text('View A details'),
            ),
          ],
        ),
      ),
    );
  }
}

class DetailsScreen extends StatelessWidget {
  const DetailsScreen({
    required this.label,
    super.key,
  });

  final String label;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      backgroundColor: Colors.blue,
      appBar: AppBar(
        title: const Text('Details Screen'),
      ),
      body: Center(
        child: Text(
          'Details for $label',
          style: Theme.of(context).textTheme.headlineMedium,
        ),
      ),
    );
  }
}

Thanks for the update. Can you check if your case is similar to https://github.com/flutter/flutter/issues/131994 ?

That issue seems to be unrelated and I also can't reproduce that issue anymore (I left a comment there).
@darshankawar Could you maybe explain what the expected behavior is here? How were ColorScheme.background, ColorScheme.surface, ThemeData.scaffoldBackgroundColor, Scaffold.backgroundColor, and BottomNavigationBar.backgroundColor supposed to work together? And how does that change with the deprecation of ColorScheme.background? Should changing it to ColorScheme.surface preserve all behavior? In that case, the current behavior is clearly a bug.

Thanks for the feedback. Please check this PR that seems to have made the said changes and see if any of the toned base surface colors helps further in your case or not.

Sorry, I find this conversation a bit confusing. I can definitely make my app look the way I want it to look. I created this issue to report that migrating from ColorScheme.background to ColorScheme.surface (as proposed by background's deprecation message) also requires explicitly changing all scaffold background colors. Scaffolds do not pick up ColorScheme.surface. I don't know if this was broken intentionally or if this is a bug. Maybe @QuncCccccc knows more about this?

Thanks for the update. I do see the reported behavior upon trying to use background for which it says below:

And with surface, only the appbar color changes.
Code sample: https://github.com/flutter/flutter/issues/149158#issue-2320317811

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.22.1, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.22.1 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision a14f74ff3a (12 days ago), 2024-05-22 11:08:21 -0500
    • Engine revision 55eae6864b
    • Dart version 3.4.1
    • DevTools version 2.34.3
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.23.0-13.0.pre.69, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.23.0-13.0.pre.69 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 124aacbaef (2 days ago), 2024-05-31 22:32:25 -0400
    • Engine revision d81edf635a
    • Dart version 3.5.0 (build 3.5.0-214.0.dev)
    • DevTools version 2.36.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

I also agree that just replacing background property with surface will break many apps that rely on it to define the scaffold background. The solution is simple though - define ThemeData.scaffoldBackgroundColor instead. But this should have been somehow documented better.


add quota management

Codecov Report

Merging #171 (74546bb) into master (f0994db) will increase coverage by 0.34%.
The diff coverage is 88.15%.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   67.10%   67.44%   +0.34%
==========================================
  Files          75       75
  Lines        4909     4983      +74
==========================================
+ Hits         3294     3361      +67
- Misses       1217     1221       +4
- Partials      398      401       +3

Impacted Files
Coverage Δ

common/message.go
78.57% <ø> (ø)

plugin/database/db.go
47.36% <0.00%> (-1.29%)
:arrow_down:

api/quota.go
83.67% <82.60%> (-16.33%)
:arrow_down:

api/namespace.go
100.00% <100.00%> (ø)

api/node.go
74.02% <100.00%> (+1.45%)
:arrow_up:

plugin/default/license/license.go
100.00% <100.00%> (ø)

server/mis_server.go
67.30% <100.00%> (+3.47%)
:arrow_up:

service/license.go
93.33% <100.00%> (+2.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0994db...74546bb. Read the comment docs.


[CI] python installation in windows with retry

What does this pull request do?
Fixes some issues with the workers when the python installation fails and even takes 12 minutes to fail.
[2020-09-02T12:13:33.561Z] By installing you accept licenses for the packages.
[2020-09-02T12:25:40.617Z] python3 not installed. An error occurred during installation:

:green_heart: Build Succeeded

Expand to view the summary

Build stats

Build Cause: [Pull request #915 opened]

Start Time: 2020-09-02T13:11:29.843+0000

Duration: 25 min 48 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
10927

Skipped
8506

Total
19433

LGTM, although I'm a bit confused by the original error message, it doesn't look like something a retry would solve

I'm guessing the chocolatey package will recover itself if running twice with some sleep.
The idea is:

install python

If it takes over 3 minutes then kill the installation and try again up to 3 times.

I just added --force in case the previous installation got stalled.
I cannot warranty this will fix the issue but I'd like to give a go and see if it helps


dotnet support

Notes:

Focal deps
Install steps

Should be ready for review!
I wasn't able to run the tests. Not sure if I'm missing something:

> ./bin/test --podman 02afc28662016d9075dd9397d5d38b24fb07cf0ae1bb3a35f676582124910704
============================= can run python tools ============================
Initialized empty Git repository in /tmp/tmpn9kxm1mh/.git/
An unexpected error has occurred: PermissionError: [Errno 13] Permission denied: '/pc/.lock'

Traceback (most recent call last):                                                                                File "/venv/lib/python3.8/site-packages/pre_commit/error_handler.py", line 65, in error_handler                       yield
  File "/venv/lib/python3.8/site-packages/pre_commit/main.py", line 342, in main
    store = Store()                                                                                File "/venv/lib/python3.8/site-packages/pre_commit/store.py", line 61, in __init__
    with self.exclusive_lock():
  File "/usr/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)
  File "/venv/lib/python3.8/site-packages/pre_commit/store.py", line 89, in exclusive_lock
    with file_lock.lock(os.path.join(self.directory, '.lock'), blocked_cb):                                           File "/usr/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)                                                                                File "/venv/lib/python3.8/site-packages/pre_commit/file_lock.py", line 74, in lock
    with open(path, 'a+') as f:                                                                                PermissionError: [Errno 13] Permission denied: '/pc/.lock'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/venv/lib/python3.8/site-packages/pre_commit/__main__.py", line 5, in <module>
    exit(main())
  File "/venv/lib/python3.8/site-packages/pre_commit/main.py", line 397, in main
    raise AssertionError(
  File "/usr/lib/python3.8/contextlib.py", line 131, in __exit__
    self.gen.throw(type, value, traceback)
  File "/venv/lib/python3.8/site-packages/pre_commit/error_handler.py", line 73, in error_handler
    _log_and_exit(msg, ret_code, e, traceback.format_exc())
  File "/venv/lib/python3.8/site-packages/pre_commit/error_handler.py", line 24, in _log_and_exit
    storedir = Store().directory
  File "/venv/lib/python3.8/site-packages/pre_commit/store.py", line 61, in __init__
    with self.exclusive_lock():
  File "/usr/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)
  File "/venv/lib/python3.8/site-packages/pre_commit/store.py", line 89, in exclusive_lock
    with file_lock.lock(os.path.join(self.directory, '.lock'), blocked_cb):
  File "/usr/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)
  File "/venv/lib/python3.8/site-packages/pre_commit/file_lock.py", line 74, in lock
    with open(path, 'a+') as f:
PermissionError: [Errno 13] Permission denied: '/pc/.lock'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/venv/lib/python3.8/site-packages/pre_commit/__main__.py", line 5, in <module>
    exit(main())
  File "/venv/lib/python3.8/site-packages/pre_commit/main.py", line 397, in main
    raise AssertionError(
  File "/usr/lib/python3.8/contextlib.py", line 131, in __exit__
    self.gen.throw(type, value, traceback)
  File "/venv/lib/python3.8/site-packages/pre_commit/error_handler.py", line 73, in error_handler
    _log_and_exit(msg, ret_code, e, traceback.format_exc())
  File "/venv/lib/python3.8/site-packages/pre_commit/error_handler.py", line 24, in _log_and_exit
    storedir = Store().directory
  File "/venv/lib/python3.8/site-packages/pre_commit/store.py", line 61, in __init__
    with self.exclusive_lock():
  File "/usr/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)
  File "/venv/lib/python3.8/site-packages/pre_commit/store.py", line 89, in exclusive_lock
    with file_lock.lock(os.path.join(self.directory, '.lock'), blocked_cb):
  File "/usr/lib/python3.8/contextlib.py", line 113, in __enter__
    return next(self.gen)
  File "/venv/lib/python3.8/site-packages/pre_commit/file_lock.py", line 74, in lock
    with open(path, 'a+') as f:
PermissionError: [Errno 13] Permission denied: '/pc/.lock'
Traceback (most recent call last):
  File "./bin/test", line 378, in <module>
    exit(main())
  File "./bin/test", line 356, in main
    test_can_run_python_tools(minimal_tag, pc, podman=args.podman)
  File "./bin/test", line 40, in test_can_run_python_tools
    subprocess.check_call((
  File "/usr/lib64/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '('docker', 'run', '--rm', '--user', '1000:1000', '--userns=keep-id', '--volume', '/tmp/tmpn9kxm1mh:/git:ro', '--volume', '/tmp/tmppidpzviw:/pc:rw', '--workdir', '/git', '02afc28662016d9075dd9397d5d38b24fb07cf0ae1bb3a35f676582124910704', 'python3', '-mpre_commit', 'install-hooks')' returned non-zero exit status 1.

weird, my guess is the podman error is due to user id namespaces (I know they work different on ubuntu vs rhel-likes).  as for the current error it looks like we need to change where ~/.dotnet goes -- is there an environment variable for that?

I've just pushed what I hope is the final fix - just needed a few more ENV variables. Also managed to get the tests running locally by using the :z option for the volumes.


Layout issues

As you can see, I tried using this in my project and i got the above, The top bar is all cluttered, The check boxes are invisible and the text does not autosize to accommodate.
So then i tried the example to see what i was doing wrong and it looks exactly the same. What am i doing or not doing that is causing this?

Hey. I'm also seeing this same behavior :(

@lawmaestro Yeah, our team made a fork for our own use try this link https://github.com/xelven/QULQuestionnaire-iOS


[GWT] gwt compile failed

Issue details
I cloned the master depository because I needed to check on what was the problem with the freetypeFontGenerator and gwt. But before doing anything I wanted to test my clone on gwt so I launch a gwtCompile  on gdx-tests-gwt but it failed.
I took the liberty to change the gwt version to 2.8.0 since I spotted that in the gdx-test-gwt build.gradle it was still referencing 2.6.0. But the bug remain
Version of LibGDX and/or relevant dependencies
Libgdx 1.9.6-Snapshot
Gwt 2.8.0
Stacktrace
:tests:gdx-tests-gwt:compileGwt FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':tests:gdx-tests-gwt:compileGwt'.

Process 'command 'C:\Program Files\Java\jdk1.8.0_73\bin\java.exe'' finished with non-zero exit value 1

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
Please select the affected platforms

[ ] Android
[ ] iOS (robovm)
[ ] iOS (MOE)
[X] HTML/GWT
[ ] Windows
[ ] Linux
[ ] MacOS

Use superdev to run the gwt tasks.

Also, freetype is simply not going to work with GWT so I wouldn't spend much time on investigating why it doesn't work.

ok well thanks for the hint about freetype.
Anyway, the superdev don't even work. I think it can be a missing module inheritance regarding the errors I get ?
Compiling module com.badlogic.gdx.tests.gwt.GdxTestsGwt
Finding entry point classes
[ERROR] Errors in 'file:/D:/Sources/libgdx/gdx/src/com/badlogic/gdx/Net.java'
[ERROR] Line 80: No source code is available for type java.io.InputStream; did you forget to inherit a required module?
[ERROR] Errors in 'file:/D:/Sources/libgdx/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/GwtNet.java'
[ERROR] Line 70: No source code is available for type java.io.InputStream; did you forget to inherit a required module?
[ERROR] Errors in 'file:/D:/Sources/libgdx/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/preloader/Preloader.java'
[ERROR] Line 200: No source code is available for type java.io.InputStream; did you forget to inherit a required module?
[ERROR] Line 203: No source code is available for type java.io.ByteArrayInputStream; did you forget to inherit a required module?
[ERROR] Errors in 'file:/D:/Sources/libgdx/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/emu/com/badlogic/gdx/files/FileHandle.java'
[ERROR] Line 78: No source code is available for type java.io.InputStream; did you forget to inherit a required module?
[ERROR] Errors in 'file:/D:/Sources/libgdx/gdx/src/com/badlogic/gdx/net/Socket.java'
[ERROR] Line 41: No source code is available for type java.io.InputStream; did you forget to inherit a required module?
[ERROR] Errors in 'file:/D:/Sources/libgdx/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/preloader/Blob.java'
[ERROR] Line 38: No source code is available for type java.io.InputStream; did you forget to inherit a required module?
[ERROR] Errors in 'file:/D:/Sources/libgdx/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/emu/java/io/BufferedInputStream.java'
[ERROR] Line 19: No source code is available for type java.io.FilterInputStream; did you forget to inherit a required module?
[ERROR] Line 20: No source code is available for type java.io.InputStream; did you forget to inherit a required module?
[ERROR] Errors in 'file:/D:/Sources/libgdx/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/emu/java/io/Reader.java'
[ERROR] Line 33: No source code is available for type java.io.Closeable; did you forget to inherit a required module?
[ERROR] Errors in 'file:/D:/Sources/libgdx/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/emu/java/io/Writer.java'
[ERROR] Line 30: No source code is available for type java.io.Closeable; did you forget to inherit a required module?
[ERROR] Line 30: No source code is available for type java.io.Flushable; did you forget to inherit a required module?
[ERROR] Unable to find type 'com.badlogic.gdx.tests.gwt.client.GwtTestStarter'
[ERROR] Hint: Previous compiler errors may have made this type unavailable
[ERROR] Hint: Check the inheritance chain from your module; it may not be inheriting a required module or a module may not be adding its source path entries properly
:tests:gdx-tests-gwt:draftCompileGwt FAILED
FAILURE: Build failed with an exception.

Yup, few updates weren't pushed. Should be good now, thanks for the issue report.

thanks a lot indeed that change allow me to run the superdev mode.
Nevertheless, in order to compile with gwtcompile  and superdev mode on, I had to remove the current line from gdx-tests-gwt build.gradle : "enableClosureCompiler = true;"
I saw on the internet that closer compiler is no longer supported with gwt 2.8.0.
Also, I removed from the tests the following class : NonContinuousRenderingTest.java
It had errors with :
`button1.addListener(new ChangeListener(){
public void changed (ChangeEvent event, Actor actor) {
new Thread(new Runnable(){
public void run () {
try {
Thread.sleep(2000);
} catch (InterruptedException ignored){}
nextColor();
Gdx.app.postRunnable(new Runnable(){
public void run () {
Gdx.app.log(str1, "Posted runnable to Gdx.app");
}
});
}}).start();
		}});`

and other that look like this thread call. I hope it will help you find out that bugs this test.


Have an project

Hi sir i just complete an javascript project enhanced with jquerry
Title: Ignotes / Quotes generator
i wish the people or the follower on you also needs to know about it if you give permission i will give the source code of it by contributing to your project
website referal link: https://ignotesgenerator.netlify.app/

shall i contribute this project here?


A potpourri of small tweaks

Make printers constexpr
Add standard-like function file_size
Rewrite uuid as byte sequence
Make chunk more flexible

@tobim, you've reviewed a good amount of these changes already in #727. This PR factors the generic aspects that won't go into the integration branch.


Potential Bug: The update of cid_map doesn't check confict cid.

The update of cid_map uses insert() method which will update value if the map had the key before. The code below doesn't check the return value:
https://github.com/rust-vmm/vhost-device/blob/2fa80555d242f5aaa1d188cf79f982263c8bfd51/crates/vsock/src/vhu_vsock_thread.rs#L114C41-L114C41
It would happened if somebody writes a config which gives the same cid for different VMs on accident. It would be nice to have a conflict cid check in config parser.

@zjhuang1008 thanks for opening the issue!
I think we should fail to create the vsock thread if the cid is already in the map.
@techiepriyansh do you have time to take a look?
Maybe we should also add a test to cover this scenarion.

@zjhuang1008 good catch!
I'll send a fix.


Move numeric? to Object

It will be more convenient. Let's discuss.

You must have a real-world scenario in mind for this move--the development situation that prompted you to open the ticket. Why don't you start there?

"123".numeric? => true
123.numeric? => NoMethodError


Feature Request - Swapping all weapons between two characters.

I would like to be able to swap all weapons between 2 characters.  This would make changing characters extremely simple.  I usually use the same weapons with just a few changes depending on the situation.  If I am doing daily stuff and get done with one character, I just need to swap weapons with my next character.
Another feature that would be a similar idea would be loading weapons from a loadout to a character and automatically moving the current weapons for that character to the other characters.  This would give you exactly the weapons you want.
Both of these methods would allow a person to have exactly the weapons they want and nothing extra.

This is already possible with the loadouts? I've put all the weapons I use in a loadout for any character and can switch on the fly :)

I am talking about switching all the weapons so that the 2nd character has the same exact weapons that the 1st character has.  You currently can't do that.  You may be able to do something that is close but not completely.  You will still have stray weapons left over on the character you are switching to.  Even if you only have 1 primary/special/heavy on the character you switch to, you will still have those 3 weapons left in those characters, unless you are switching 10 weapons over from that category, then I think it will move the 1 weapon somewhere else.

I second this request, but not just for weapons. It would be nice to have a one-button-press to move all of the materials and consumables between characters too.

Oh this would be so very awesome. You find a great set of working weapons for a given Nightfall, then you want to use the same set as you cycle through your characters. Switching them from alt to alt manually is a pain. I'd love for an option to move all weapons from one character to another, plain and simple.
Secondarily, it would be great if there was an easy method to create a loadout from all the currently equipped weapons for a given character. That could satisfy the need here, but I'd rather not create/delete a loadout everytime I want to swap all weapons.

Some good ideas here.  Just need the bandwidth.
On Wed, May 27, 2015 at 10:55 AM Brad Choate<EMAIL_ADDRESS>wrote:

Oh this would be so very awesome. You find a great set of working weapons
for a given Nightfall, then you want to use the same set as you cycle
through your characters. Switching them from alt to alt manually is a pain.
I'd love for an option to move all weapons from one character to another,
plain and simple.
Secondarily, it would be great if there was an easy method to create a
loadout from all the currently equipped weapons for a given character. That
could satisfy the need here, but I'd rather not create/delete a loadout
everytime I want to swap all weapons.
—
Reply to this email directly or view it on GitHub
https://github.com/kyleshay/DIM/issues/91#issuecomment-105972240.

i'm tempted to close this. nowadays this would be a bit more simple to implement with how we handle bulk transfers (like 'items to level up', etc.)
but, is this sort of thing still necessary? if i'm doing the raid on 3x characters, it's easy enough just move over my spindle, hung jury, and ToM...

It would be nice if there was an easy UI that would just swap characters (armor/weapons/ship/sparrow/emblem/shader).  Loadouts don't help because the gear matches the scenario and you're just character swapping to repeat.
Essentially what we're doing is making two temporary loadouts, swapping items, and deleting the loadouts.  Simple aside from the UI issue.

The only reason it wouldn't be as necessary any more is that nobody does NFs any more.  But that could change in the future.  I still think being able to easily switch all weapons with a couple clicks  is a great feature.  Especially since it can be done quicker now.

Just add a swap character load out and two links to the characters. Move
the equipped items.

Not sure what you mean.

I disagree that no one does nightfalls anymore. And a specific loadout that works for a specific set of modifiers is also relevant and would be useful for the weekly challenge of elders.

You can easily create a load out form one character's equipped items and
apply it elsewhere. No need for a dedicated feature.
On Monday, May 30, 2016, Brad Choate<EMAIL_ADDRESS>wrote:

I disagree that no one does nightfalls anymore. And a specific loadout
that works for a specific set of modifiers is also relevant and would be
useful for the weekly challenge of elders.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DestinyItemManager/DIM/issues/91#issuecomment-222530684,
or mute the thread
https://github.com/notifications/unsubscribe/AATHeIJfPlL4RrvkV1O1NVE-Vb7i7a8qks5qGxy-gaJpZM4EU9il
.

Everyone always seems to miss the point.  The whole point of this feature is to be able to get the exact weapons you want and NO more with a simple click.  I was doing Iron Banner this week and I could switch items but I could not do it that easy.  To do something similar, you have to get all weapons off the other 2 characters except what is eqipped.  Make a loadout for those 3 weapons for each character.  Then, before moving weapons from that character, equip those 3 weapons with that loadout before moving the main loadout to the other character.  Then the character that has all the weapons, move that character's 3 weapon loadout to the vault.  That works but it is a bit of a pain.
I was equipping at least 7 primary weapons during IB and with 1 Armsday choice, I needed to move excess weapons out.  Having the ability to just switch weapons exactly between 2 characters would still be usefull.

Once we have https://github.com/DestinyItemManager/DIM/issues/224
You'll be able to create an account global (can equip on any character) loadout for your favorite weapons and have empty slots.
Should be as simple as "create loadout" -> "click 3 weapons" -> "set blank slots option to true" -> "set to apply to any class"
Then when you have that loadout, you'll be able to equip it on any character and have those free spaces.


error: no combination of peers can be derived which satisfy the endorsement policy

EndorseError: 9 FAILED_PRECONDITION: no combination of peers can be derived which satisfy the endorsement policy
when running application-gateway-typescript on test-network.
I am following the instructing of https://hyperledger-fabric.readthedocs.io/en/release-2.5/write_first_app.html on fabric 2.5.3
but facing problem when running npm start

It looks like the chaincode was not deployed successfully prior to the client application being run.


Toolbox installation problem

Hi, I am trying to install PETPVC on my Mac, running OS X 10.10.5. I have installed ITK successfully, while also having turned on the Module_ITKReview during the build. However, I get the following error:
[  3%] Building CXX object test/CMakeFiles/pvc_compareImages.dir/CompareImages.cxx.o
make[2]: *** No rule to make target /Applications/ITK_install/Build/lib/libitkdouble-conversion-4.13.a', needed by test/pvc_compareImages'.  Stop.
make[1]: *** [test/CMakeFiles/pvc_compareImages.dir/all] Error 2
make: *** [all] Error 2
I know that this indicates some missing file during the ITK build, but I am not sure if I was supposed to enable any more modules? I enabled the ITK default modules and the ITKReview module during the configuration step.
I am using XCode 2.7.11 for compiling. Any help will be appreciated. Thanks in advance.

Hi,
First thing I would do is to build ITK with BUILD_TESTING=On. Then issue make test in your ITK build directory and confirm that ITK is fine. If that is successful, then try running make VERBOSE=true in your PETPVC build directory and see if there is any more information.

Hi,
It turned out that I had to install double-conversion on Mac OSX. I dowloaded it from http://macappstore.org/double-conversion/ and then rebuilt ITK and it seemed to work perfectly for me! Thanks for the help.

Nandita


Time for a new release

Would be nice to have a 0.5.0 release with migration to swiftlang/swift-syntax, since it causes warnings with other libs (tca) 🌚

Thanks for the reminder! Done 👍


Create templates for Acknowledgment letters

Dependencies
External teams' guidance and approvals
DOD

[x]  GDX to advise on design guidelines
[x] Checked for Legislative guidelines in accordance with FOIPPA
[x] Letter templates
[x] Email templates

Removed Review Process as separate task as this will take a while and require back and forth
In ticket #168

@m-prodan @arielleandrews
Here is the first draft of the re-design of the acknowledgment letter/email. Core difference is letter has header and footer with contact info, email has signature with contact info. And I have added titles for content to be easier to find. I designed these as examples, so anything in orange is what would be auto-populated based off of what is selected.
Email: https://teams.microsoft.com/l/file/A3D540CF-108A-488D-9A76-8625B9E721E1?tenantId=6fdb5200-3d0d-4a8a-b036-d3685e359adc&fileType=docx&objectUrl=https%3A%2F%2Fbcgov.sharepoint.com%2Fteams%2F03521%2FShared Documents%2FGeneral%2FUser Research%2FTemplates%2FNEW Email Templates%2FProposed - Acknowledgment<EMAIL_ADDRESS>Letter: https://teams.microsoft.com/l/file/F240EE45-10DB-4041-A5EC-F5F321FA5175?tenantId=6fdb5200-3d0d-4a8a-b036-d3685e359adc&fileType=docx&objectUrl=https%3A%2F%2Fbcgov.sharepoint.com%2Fteams%2F03521%2FShared Documents%2FGeneral%2FUser Research%2FTemplates%2FNEW Letter Examples%2FProposed - Acknowledgment<EMAIL_ADDRESS>Here is the start of the excel with the different options and the text for each, included what was originally provided and what I have changes: https://teams.microsoft.com/l/file/327608AA-011C-44C9-AF85-B325C3325F31?tenantId=6fdb5200-3d0d-4a8a-b036-d3685e359adc&fileType=xlsx&objectUrl=https%3A%2F%2Fbcgov.sharepoint.com%2Fteams%2F03521%2FShared Documents%2FGeneral%2FUser<EMAIL_ADDRESS>

And same here @JHarrietha-AOT, I think these are very user friendly. I have added some comments and suggested edits in Teams. @m-prodan would you like to review before moving this to closed?

@arielleandrews Thanks for all the great feedback I made changes, just had one question based of the sentence you added at the start.
@m-prodan Would you like to review before we move over the the review task ticket? Otherwise either of you can close the ticket when it feels ready to do so, all links are also in the review ticket

@arielleandrews Saw your comment that makes sense. I will add to my list for prototype updates

Closing with this comment, review process has been pulled out into #168, completing the multiple levels of review in a sprint was not achievable in a sprint so we split up the creation and research into this ticket and the review in #168


[feat] [AI] excalidraw to text, (better) text to excalidraw

hi
i really love excalidraw but i see the AI features are really lagging behind
i'm a paid member since day one, happy to pay more like $20/month is the UX is right
atm AI features' UX is really poor, i don't use at all
sometimes i ask chatgpt to generate mermaid, does not work well
how

why not let AI generate JSON instead of mermaid? context limits are huge nowadays

add a side chat, use similar UX than cursor.sh, eg. when selecting something there is a small tooltip to edit things with a prompt or add to chat, chat has access to the canvas context + (optional: you can add other canvas with "@" in your workspace as context in the chat)

again i'd pay $20/month for the right UX, thanks!

also for excalidraw to text you can just split the canvas into chunk of images and feed to gpt0, that's what i did manually and it works really well

Hi! Yes, we will be doing improvements around AI things, and taking your suggestions into account!
Btw, I DMed you on twitter in case you want to discuss more.
Otherwise, I'm closing this as this isn't immediately actionable within the context of this repo.


run check for hostapd installed

hostapd is required but not always installed on every system.
run dependency check for it or install with script please.

Hi @TRusselo, thanks for your feedback.
hostapd is already installed during set up. Can you confirm that you've run the install_prereq.sh script?

Hi,
I had the same issue.
I ran install_prereq.sh twice, but had to install hostapd manually.
lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 22.04.1 LTS
Release:	22.04
Codename:	jammy


Create 1562_python_lambda.py

IMPORTANT: Please do not create a Pull Request without an issue.
All Submissions:

[ ] I have read the CONTRIBUTING document.
[x] My code is written in Python3 and is ending with .py
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] I have checked that my submission does pass the test on LeetCode.com
[ ] Does your filename follow the naming Conventions?
[ ] Have you linked your PR to an Issue?

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Not assigned to the linked issue - please consider Contributing Guidelines


Redact Messages in Room After X number of Hours/Days

Need a functionality to Redact Messages in Room After X number of Hours/Days as a setting at the room and 1-1 chat.
Settings:
Delete after

Read by All
X Hours immaterial of read status
Y Days immaterial of read status

Redact doesn't delete message. And redacted messages will be available in each server in the room. You can always get and read any redacted message from the database. Therefore automatic redacts doesn't make sense.

https://github.com/vector-im/riot-web/issues/2497


fix(openai): missing span when stream response is used as context manager

OpenAI responses can be used as a context manager. For example, see here in LangChain. When that happens, the __enter__ method on the wrapped stream object is called and the stream object is returned, escaping our wrapper. Subsequent iteration of the stream is un-noticed by our span, and the span is missing because it's never exported. This PR overrides the __enter__ method so the wrapped object does not escape.

@RogerHYang I'm not sure I understand the issue from the PR title. Can you add a code snippet of the usage pattern?

@mikeldking I added more info in the description

@mikeldking I added more info in the description

Very clear, thank you


Unable to import library ("AttributeError: type object 'VBoxEventType' has no attribute 'progress_event'")

ENVIRONMENT

Operating System: Windows 10 2004 build 19041.572
Python version: Python 3.8.6, installed from python.org
VirtualBox version: Version 6.1.16 r140961 (Qt5.6.2)
VirtualBox SDK version: Unknown, latest from website (vboxapisetup.py --version returns 1.0)
Location where VirtualBox SDK is installed: C:\Users(username)\AppData\Local\Programs\Python\Python38<!--- Path to the Python you used to run vboxapisetup.py -->
virtualbox-python / pyvbox version: Built from latest source from GitHub at time of reporting issue (2.1.0?)
[x] Happens in latest master branch? Yes

SUMMARY

I'm no longer able to import the library following yesterday's update (2.1.0). Attempting to import the library, either in a program or in the Python interpreter on the command line, causes an error and the program terminates. (The interpreter does not terminate, but the library is not imported, and cannot be used.)
I have tried reinstalling VirtualBox both from source and from pip - no change. I have also tried reinstalling the VirtualBox API - again, no change.
STEPS TO REPRODUCE

Start the Python interpreter. (Run python3 in your terminal of choice)
Type import virtualbox and press enter.
The error should occur.

EXPECTED RESULTS

The library is imported, and I am able to use VirtualBox-related functionality in my code.
ACTUAL RESULTS

An error occurs, and the library is not imported.
C:\Users\(username)\Downloads\virtualbox-python-master>python
Python 3.8.6 (tags/v3.8.6:db45529, Sep 23 2020, 15:52:53) [MSC v.1927 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import virtualbox
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\(username)\Downloads\virtualbox-python-master\virtualbox\__init__.py", line 26, in <module>
    from virtualbox.library_ext import library
  File "C:\Users\(username)\Downloads\virtualbox-python-master\virtualbox\library_ext\__init__.py", line 11, in <module>
    from virtualbox import library
  File "C:\Users\(username)\Downloads\virtualbox-python-master\virtualbox\library.py", line 36642, in <module>
    class IProgressEvent(IEvent):
  File "C:\Users\(username)\Downloads\virtualbox-python-master\virtualbox\library.py", line 36649, in IProgressEvent
    id = VBoxEventType.progress_event
AttributeError: type object 'VBoxEventType' has no attribute 'progress_event'
>>>

Rolling back to 2.0.0 (pip uninstall virtualbox followed by pip install -Iv virtualbox=2.0.0) does not resolve this issue, for some reason.

Confirming that this is an issue specifically with the code generator, I'll get to it today.

Fixed in 2.1.1


Clean more caches

Clean up cache for:

precipitation
edmfx_nh_pressure
subsidence
EDMFCoriolis
forcing_type
non_orographic_gravity_wave
orographic_gravity_wave
hyperdiffiusion
radiation
limiters

Add surface_setup to AtmosModel and removes dt from simulation
A quick test seem to indicate that this PR reduces compile time by 5-10 % (or more in some cases)

To be merged after #2281

I take back the compile-time benefits. They are not uniform, and there's a regression for some EDMF cases (not all).
I am investigating this.

@dennisYatunin may want to take a look at the changes to radiation cache.

@dennisYatunin may want to take a look at the changes to radiation cache.

We agreed to remove one level of nesting to the RRTMPGI cache and rename radiation_mode to radiation_model in a future PR.

I thought I identified and reverted the issue for the slowdown, but that's not the case.
While on my computer, the PR leads to consistent performance/latency improvements, this is not the case on the cluster. Quite the opposite, this PR introduces some noticeable regressions.
I would like to still merge this (and the other, #2296) PR. They clean up and improve the cache, and they are a lot of work to maintain because pretty much every change touches the cache, leading to conflicts that are time consuming to solve.
Debugging this issue is particularly annoying because seemingly there's no correlation between my changed and the outcome (+ I need to run stuff on the cluster to clearly see the effects). I suspect that some of the newly introduce (and non identified) problems will be automatically solved by the mutable spaces.
What do you think?
@szy21 , @charleskawczynski , @dennisYatunin

How much regression did you get on the cluster? If it's not too bad (e.g. ci can still finish in a reasonable time), then I think it's ok to merge it in.

You can compare
https://buildkite.com/clima/climaatmos-ci/builds/14418#_  (which would be the "final" PR)
With master:
https://buildkite.com/clima/climaatmos-ci/builds/14401#_
Some jobs take 10 more minutes:
https://buildkite.com/clima/climaatmos-ci/builds/14418#018b6e11-f634-4293-b119-d2b0d8b59bac
vs
https://buildkite.com/clima/climaatmos-ci/builds/14401#018b6d70-d498-49e9-a8cf-8a3eab19e45c
I think that this is all in compiling solve_atmos!. If you look at everything else (including SYPD), the new PR is better.

hmm, indeed a lot of jobs are slower. @charleskawczynski What do you think?

Maybe we can start by merging this PR, and wait until we have the mutable spaces to merge #2296 ?
This current PR does introduce some additional costs, but nowhere near as much as #2296.
(And I do think that most of the additional will go away with the mutable spaces)

My 2 cents is: break this PR down. Two advantages are: 1) it's much easier to review smaller PRs, and reviews tend to be more thorough (I can't admit that I would review this PR carefully). and 2) we'll actually learn what is causing the regression, rather than sweeping under the rug.

Each commit is self sufficient, working, and implement just one change. You can go through them one by one.  I tried having small PRs with #2273, #2270, #2281, but it took days to get these very small changes merged, with a lot of time on my side spent rebasing every time main changed.
This PR implements one single logical change in multiple commits.
PR #2296 consists of only 2 commits (on top of all these ones). I know that the slow down is in those two, but even with that, I cannot fix it.

Would we be able to know which commit causes the regression?

but it took days to get these very small changes merged

I think that time is dominated by time to review. (e.g., https://github.com/CliMA/ClimaAtmos.jl/pull/2283 is pretty small and still waiting on review).

Would we be able to know which commit causes the regression?

Yes, I'll find it.

but it took days to get these very small changes merged

I think that time is dominated by time to review. (e.g., #2283 is pretty small and still waiting on review).

I cannot turn this PR into several concurrent PRs because they all change the cache.jl file (at least), leading to conflict that I'd have to solve for each of them every time one gets merged. So, to avoid internal conflicts, I'd have to submit multiple serial PRs. In that case, I'd have to solve for the conflict that arise from all the other PRs that get merged (the cache is used everywhere in the code, so the probability of conflicts is very high). I am not saying that it cannot be done,
it just feels slow and inefficient when I know I have all these changes ready.
#2259 is an example of fast turnaround time: 12 minutes from commit to review, but almost 3 hours from commit to merge.
However, I absolutely agree with your comment about ease of review. For that, I'd ask you to look at each commit as if it was a different PR. I take a lot of care to constantly rebase the code to have good and atomic commits.
(I am not reviewing #2283 because I don't understand its implications so I cannot make meaningful comments)

This buildkite is fast: https://buildkite.com/clima/climaatmos-ci/builds/14450
Leaving only one commit as culprit: d8ff6796
I am checking that that's indeed the case.

Yes, in this PR https://github.com/CliMA/ClimaAtmos.jl/commit/d8ff67968dd2cfedb81950df30e1b23c3fba50e0 leads to an increase in compile time.
I reverted that change.

It seems the compile time is back to normal on the cluster now. Feel free to merge it once others' comments are addressed.

In https://github.com/CliMA/ClimaAtmos.jl/pull/2244/commits I add one additional commit  to this PR to complete the refactor of the cache by moving all the precomputed quantities in p.precomputed. Overall compile time is nearly identical to the master branch (https://buildkite.com/clima/climaatmos-ci/builds/14519). I would like to merge that and close the chapter of "cache refactoring".
@szy21 do you want to have a look at that commit too? If it the change is okay, I will move it over to this PR and merge it.

The commit looks good to me, thanks! I need to think a bit more about what should be in core and what should be in precomputed, but we don't need to wait for that to merge this PR.

bors r+

bors r+


Updates etcd version to install etcdctl.

What this PR does / why we need it:
We have upgraded the etcd version to v3.4.34 https://github.com/gardener/etcd-wrapper/pull/30 in etcd-wrapper.
This PR will updates the etcd version to v3.4.34 to install etcdctl of version v3.4.34.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

Updates the etcd version to `v3.4.34` to install etcdctl of version `v3.4.34`.

/lgtm


fix: make HeightOneSpectrum.adicCompletion an abbrev

IsDedekindDomain.HeightOneSpectrum.adicCompletion is currently a def and this causes a bunch of rws to fail in Lean 4; erw is needed. In developing the API further I ran into more irritating erw issues; changing it to an abbrev seems to solve them (we can get rid of several porting notes too).

Remark: this change exposed a bug in the typeclass inference system. See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/erw.20and.20IsDedekindDomain.2EHeightOneSpectrum.2EadicCompletion/near/439391094 for more details.

!bench

Almost sure this is harmless, but let's wait for the benching result. Thanks!
bors d+

bors merge


326 Rename COULD to MAY

Closes #326

Codecov Report

Merging #331 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #331   +/-   ##
=======================================
  Coverage   87.93%   87.93%
=======================================
  Files          38       38
  Lines         373      373
  Branches       24       24
=======================================
  Hits          328      328
  Misses         39       39
  Partials        6        6

Flag
Coverage Δ

#webui
87.93% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4369064...325f289. Read the comment docs.

@fmueller , thanks, I was thinking about compatibility topic, but didn't found an elegant solution. Will probably keep COULD as an extra parameter.
How about web-ui changes btw, is COULD also somehow hard-coded there? Maybe we can ask some feedback from @rbarilani .

@netme At the moment we are not using COULD. but yep we use the rule type to change the color of the label... see https://github.com/zalando-incubator/zally/blob/master/web-ui/src/client/app/components/rules.jsx

Thanks @rbarilani for a quick answer. Any preference on style I need to use for MAY rule? Anyway, the only MAY rule is currently disabled on the backend configuration level, we'll not see any immediate impact.

@fmueller, also added an integration test to simulate how old CLI will behave.

👍


vulkaninfo: Report old drivers being dropped by the loader

In today's SI meeting, we agreed on a change to loader behavior that will cause the loader to drop very old drivers when newer ones are present. The loader will log a message when ignoring old drivers so that applications can see what is happening. We we need to make sure that vulkaninfo is capable of reporting this warning.
At the very least, vulkaninfo will need to pass on this warning message so that someone who runs it can see the message. It may also be useful provide some sort of hint that this can be fixed by updating drivers. I'll post a link to the loader PR that intrudces this behavior once I open it (which should happen shortly).

Currently vulkaninfo uses debug_report and should return any loader messages that go through that channel.
We will need to test this to make sure the messages get through but for now no changes need to be made as far as I can tell.

@lenny-lunarg That is actually pretty weird behavior. Is this documented in oaderAndLayerInterface.md?

Closing the issue as vulkaninfo uses the debug report callback in vkCreateInstance, which is where this error should be reported.

@lenny-lunarg That is actually pretty weird behavior. Is this documented in LoaderAndLayerInterface.md?

I don't think it is. But the document is long and easy to miss minor details like that.


Cannot create site due to bad basic template.

Description of bug
When creating a new site using either the basic or default website templates I get an error
Steps to reproduce
List the precise steps to reproduce the bug:

Go to 'Sites'
Click on 'add new site'
Select 'basic website' and fill out the rest of the information
Submit
Get the following error: Error The element 'settings' has invalid child element 'sitemapcachedays'.

Current behavior
Site creation fails
Expected behavior
A new site should be created
Screenshots
If applicable, provide screenshots to help explain the bug.
Error information
Add New Site
BACK TO SITES
Title*
333333
Description
Site Template
Default Website - English (United States)
Site Type:
DomainDirectory
Directory
Portals/[PortalID]
Site URL
dnn.jkmcomm.com/333333
Assign Current User as AdministratorOn
CancelCreate Site
Error
The element 'settings' has invalid child element 'sitemapcachedays'. List of possible elements expected: 'dataconsenttermslastchange, paymentprocessor, currency, dataconsentuserdeleteaction, enableautosave, timezoneoffset, expirydate, backgroundfile, allowuseruiculture, timetoautosave, dataconsentactive, dataconsentdelaymeasurement, enablebrowserlanguage, dataconsentdelay, dataconsentconsentredirect, hostfee, cookiemorelink, siteloghistory'.
Additional context
Workaround: I removed the 'sitemapcachedays' element and all worked after that.
Affected version

[ ] 10.00.00 alpha build
[ ] 09.08.01 release candidate
[x ] 09.08.00 latest supported release

Affected browser

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 11
[ ] Microsoft Edge (Classic)
[ ] Microsoft Edge Chromium

Looks like these settings were added to Default Website.template and the blank version just a few weeks ago.
https://github.com/dnnsoftware/Dnn.Platform/commit/fe6a41b8fca9f030b51eeebd0d1854448fd7737f

Looks like these settings were added to Default Website.template and the blank version just a few weeks ago.
https://github.com/dnnsoftware/Dnn.Platform/commit/fe6a41b8fca9f030b51eeebd0d1854448fd7737f

This is probably not the problem but there is a typo here:
https://github.com/dnnsoftware/Dnn.Platform/pull/4342/files#diff-462d58b1c37afef9ea62d407b7ef517be5fbdc00d7966418ed61cd6590291486R3069
SitemmpIncludeHidden instead of Sitemap IncludeHidden
Just to keep in mind at the same time...

This is probably not the problem but there is a typo here:
https://github.com/dnnsoftware/Dnn.Platform/pull/4342/files#diff-462d58b1c37afef9ea62d407b7ef517be5fbdc00d7966418ed61cd6590291486R3069
SitemmpIncludeHidden instead of Sitemap IncludeHidden
Just to keep in mind at the same time...

To anyone else who runs across this, it was resolved in a later release and there are workaround instructions posted by Daniel Valadas here: https://github.com/dnnsoftware/Dnn.Platform/issues/4403


Commit the UMD build to the repo

This is more of a personal preference... but I'd love to see the UMD build accessible via http://rawgit.com/ for easy in-browser testing.
The alternative is to use wzrd.in (https://wzrd.in/standalone/expect@latest) but I find that that site is a little less reliable than rawgit.
Example: http://rawgit.com/rstacruz/nprogress/master/test/index.html

I'd rather not commit auto-generated files to git if we can help it, at least not to the master branch. Maybe we could create a special branch that contains the pre-built files, perhaps using something like publish-latest...

:+1: for publish-latest

Maybe publish this cool project to jsdelivr so people wanting to use <script> will be happy

I just submitted a PR to cdnjs https://github.com/cdnjs/cdnjs/pull/5946. It should be available within 30 hours.


Dependency update

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.71%. Comparing base (d694aec) to head (0b389c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3861   +/-   ##
=======================================
  Coverage   65.71%   65.71%
=======================================
  Files         515      515
  Lines        9999     9999
  Branches     2357     2357
=======================================
  Hits         6571     6571
  Misses       3180     3180
  Partials      248      248

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upgrade babel to version 7

Resurrecting an old PR, #602, from @pedroabreu.
This is a straight upgrade maintaining the old behaviour.

Still relevant.


restore container tests

@jhheider k so for future reference we are pulling in libatomic with the other libs we get apt to install, so we also have an implicit dep on that.

@jhheider k so for future reference we are pulling in libatomic with the other libs we get apt to install, so we also have an implicit dep on that.

Is there good reason not to provide it ourselves? Or should it go in queue.

We should I agree, though I think we have to figure out how to provide the other apt packages we're installing (via LLVM presumably) first.
Chances are that’s easy to do, it's just LLVM takes hours to compile so the debug cycles suck.


Add support for budgets

Currently ClusterQueue supports usage limits at a specific point in time. A common use case is for batch admins to set up budgets, meaning usage limits over periods of time; for example, x cores over over a period of one month.

/remove-lifecycle rotten

/lifecycle frozen


Support returning Result<(), TransparentEnum> from Rust async functions.

This PR adds support for returning Result<(), TransparentEnum> from Rust async functions.
Here's an example of using this:
//Rust
#[swift_bridge::bridge]
mod ffi {
    enum SomeEnum {
       //...
    }
    extern "Rust" {
        async fn some_function() -> Result<(), SomeEnum>;
    }
}

//Swift
do {
    let value = try await some_function()
    //...
} catch let error as SomeEnum {
    //...
} catch {
    //...
}

Note that This PR doesn't support returning Result<Transparent, ()> from Rust async functions. However, I guess that nobody would use returning Result<Transparent, ()> from Rust async functions.

If this is merged, I guess that we can support #168.

However, I guess that nobody would use returning Result<TransparentEnum, ()> from Rust async functions.

Yeah I totally agree.
It's unlikely that someone will run into this signature and if they do they can open an issue and use #[swift_bridge(return_with = ...)] to convert it into an Option<TransparentEnum> in the meantime.

If this is merged, I guess that we can implement https://github.com/chinedufn/swift-bridge/issues/168.

Yeah!! They we can finally address this and make it a Result<Option<TransparentStruct>, reqwest::Error>> or something like that https://github.com/chinedufn/swift-bridge/blob/72c2fa5f2214e0845d9b3fa29b56ffbf94a97c68/examples/async-functions/src/lib.rs#L15-L17


Add sbt/setup-sbt to install sbt + default to zulu@8

Fixes https://github.com/sbt/sbt-github-actions/issues/185
Problem

Recent runner images no longer have sbt runner scripts installed.
setup-java doesn't have temurin 8 for ARM macOS

Solution

This adds sbt/setup-sbt step to install sbt runner script.
This also defaults to Zulu 8.

@eed3si9n Should I release this?

https://github.com/sbt/sbt-github-actions/releases/tag/v0.24.0


Open-appsec does not work without network connectivity in standalone mode

Hi,
I'm using nginx proxy manager integrated with open appsec and I notice that when the agent is started without networks, the agent doesn't work (it doesn't block any attacks).
When the network is available, open appsec works normally. This should not be normal behavior in standalone mode, which should work in a very closed environment.
I've observed that the agent container tries to reach inext-agents.cloud.ngen.checkpoint.com, even in standalone mode (which is considered a hybrid mode in the launch script).
Do you think this is related? And if so, is it possible to fix this so that nothing is sent to the Internet in standalone mode? In a very closed corporate environment, it's sometimes essential that tools don't send anything over the network for security reasons.

Hi @bkun31,
The agent reaches out to our fog, you can read more here.
As to working without internet connections, this should technically work but hasn't been thoroughly tested, could you please reach out to us at<EMAIL_ADDRESS>with more details about your deployment? We'll be happy to help!
Best,
open-appsec team


Support Gerrit Verify Status REST endpoints

The gerrit-verify-status plugin provides additional Gerrit REST
endpoints. This adds support for those endpoints[1].
This resolves issue #59
[1] https://gerrit.googlesource.com/plugins/verify-status/+/master/src/main/resources/Documentation/rest-api-changes.md

Coverage decreased (-0.9%) to 92.111% when pulling 9c2ef65165bfc331a378a8d1cb1bef45f6fd9556 on zaro0508:resolve-issue-#59 into 57567cbc23d9e4ef9e9d23351d1d9c0ad5e11f9a on uwolfer:master.

Thanks for your PR and sorry for my late feedback.
I have not merged it yet since I'm not sure how we should handle code which depends on Gerrit plugins. It might be confusing for users of this plugin when they see this API, but cannot use it with every server.
I'll put this change on hold for the moment.


Fix loading of custom font

WHY are these changes introduced?
Fixes #2591
WHAT is this pull request doing?
This PR patches custom font URLs so they load correctly from our local during dev.
How to test your changes?

Serve a theme with custom fonts$ pnpm shopify theme dev --path ~/my-cool-theme

The fonts should load properly in Firefox and other browsers.

https://github.com/Shopify/cli/assets/5134470/cc93eb50-1ab9-4269-9ec3-bb638f985d99
cc @karreiro
Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes
[ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

thank you @karreiro (:

👋 Hi @montalvomiguelo,
Thank you for your patience. We've noticed additional details about our CI workflow that require further changes to accommodate 3P contributors. For now, I'm mirroring your PR to unblock the CI and ship it.
https://github.com/Shopify/cli/pull/2679

Just to confirm that this fix does not work. The issue remains on 3.48.6.
To reproduce the issue:

Output (for instance in the "theme.liquid") file a font:

<style>
  {{ settings.heading_font | font_face: font_display: 'fallback' }}
</style>

Use the font in the CSS.
In localhost mode, loading the font return a 403 error.

Thanks :)

Thanks @bakura10! This is being fixed in https://github.com/Shopify/cli/pull/2711 (:


Twitter Peak Detector is not Receiving Events

The peak detector for twitter is not importing any events from the filters I’ve made.  Graphs show up but are all empty.

I believe this was a configuration error on my end, did not set 'generate' in the stream agent to 'counts'.  Had it set to events.


docs: Docs for CSS components using ion-ios7* icons

Type: docs
Platform: all
http://ionicframework.com/docs/components/#item-icons (and more I would guess) makes reference to <i class="icon ion-ios7-telephone-outline"></i> - should have the 7 removed as this will not work with RC3 so would confuse new users

This issue was moved to driftyco/ionic-site#262

Thanks for the heads up :+1:
Will fix this on the site side of things.


Show warning when dir(s) exist in an op collection that aren't valid ops

Only really ran into this when I ran opctl ls inside a collection of ops that were on the "stable" version while I was running the "beta" channel. I was briefly confused that I saw a subset of the ops I was expecting to see, and then I realized that it must be due to running in beta.
Suggested initial/naive implementation:

Look at the sudirectories of .opspec
Decide which of these translate to valid ops
Show a warning (think compiler warnings) showing which directories didn't yield valid ops

the concept of "collection" has been replaced w/ pkg resolution conventions & in the latest version of the beta, the cli usage docs include a note about ls only listing opspec 0.1.3 pkgs. Closing this as resolved considering those developments.
$ opctl

Usage: opctl [OPTIONS] COMMAND [arg...]

Open source cross platform opspec node

Options:
  -v, --version            Show the version and exit
  --nc, --no-color=false   Disable output coloring

Commands:
  events        Stream events
  ls            List packages (only v0.1.3 opspec packages will be listed)
  node          Manage nodes
  op            Manage ops
  pkg           Manage packages
  run           Start and wait on an op
  self-update   Update opctl

Run 'opctl COMMAND --help' for more information on a command.


Show copied to clipboard when clicking on the copy group link button

Is your feature request related to a problem? Please describe.
I got terribly mistaken on clicking on the Share Link button with 'Add attachment' lol.
Describe the solution you'd like
Just a small toast notification of Copied to clipboard would work.
Describe alternatives you've considered
A hint text atleast to be shown on hovering the link button.
Additional context
Would love to work on this issue ❤ Let me know how does it sound!
To the moon comrades🚀

To replicate:
Go to https://dogehouse.tv/scheduled-rooms
See this

Click on the copy link button

I am interested to fix this issue. Please let me know if this is something that need to be gone from design phase. If yes I want to know the next steps.

@junedkhatri31 was going to say the same thing. I also want to work on this issue.

@ajmnz please advise

@ajmnz please advise

We will just show a check for a couple of seconds after the thing is copied


Add BFXPipeline

Solves #88
Currently still missing the migration script

E                   RuntimeError: lamindb v0.40.3 needs lnschema_core==0.33.6, you have 0.33.7


Luke: Dataset Management

Added a field to dataset resources for datastore_name

Merging - provisional as before but better.


Client: Make breadcrumb revision

A lot of breadcrumbs are missing or are strange.

Breadcrumbs removed as they do not have additional value.


Adding a line about Lem definition of EVM

Shamelessly I'm adding my own links, but this should be useful if one wants to build a proven-correct compiler to EVM.

Wow, nice effort on that project! Definitely appears to be a useful resource, merging.


Split graph node into separate widgets

This task is automatically imported from the old Task Issue Board and it was originally created by Paweł Grabarz.
Original issue is here.

Part of https://www.pivotaltracker.com/story/show/183970089
Currently graph node is constructed using single text view. This solution is not compatible with widgets integration, which will each require their own separate layout and shapes.

Remove common text view from graph node. Replace it with individual widgets.
Appropriate widgets should be selected based on AST description provided by the engine. To remain backward compatible, a simple fallback widget should be used for non-recognized widget types.
In edit mode, the individual widgets should be navigable as if they were a single line of text. Details of this interaction needs to be discussed and decided as part of this task.

Comments:
@pawelgrabarz - we need to clarify if this is needed for release. Can you organize a discussion with @wdanilo so we can decide if needed for release?

Please explain in more detail what is needed post that meeting. (James Dunkerley - Feb 3, 2023)

This will be a possible prior to https://github.com/enso-org/enso/issues/5631. This task is not necessary for existing dropdown widgets to function, but it will allow more complete dropdown widget design to be implemented.
The most complex part of this task is:

In edit mode, the individual widgets should be navigable as if they were a single line of text.

We might want to split that into separate task, and for now rely on node edit mode reverting back to being displayed as a simple line of code. Individual widget types will manage editing of their content appropriately to each case, e.g. dropdown modifying the value on selection, or boolean editor switching between true/false on click. That interaction doesn't involve entering the node edit mode at all.

- [ ] Add minimal hierarchical widget definition - an enum variant with child widgets.
- [ ] handle edit mode with a single long editable text, hiding widgets. In edit mode, interactions other than manually editing text are not available.
    - If node is externally updated during edit, that update must be accepted when edit node is cancelled (on esc).
- [ ] build widget tree from span tree, with root widget that handles displaying more widgets
    - The node will contain Root widget, that handles top-level mouse interaction and contains other widgets.
    - Do not handle coloring of text nodes based on types. New designs will not use them anyway.
    - This task will introduce two new widget types: hierarchy widget that contains other widgets, and a text widget.
    - In case it makes the task easier, the existing widget layout might be modified, as long as the functionality is preserved.
    - Widgets will be treated as ports, which can be replaced as a whole during connection. The same logic applies to nested widgets.
- [ ] Implement dropdown widget style according to design.
- [ ] Display vector builder widget as part of node widget hierarchy.


Can't hide statusbar

Plugin makes issues with hiding statusbar. I had to set my app's settings (fullscreen settings) manually on my phone to :"show front camera" otherwise when I hide statusbar in MainActivity.kt I see black bar on the top of my screen and on side if I change rotation.

Which plugin are we talking about here?

Lol, sorry I made issue under specific plugin, but this issue landed in general tauri repository ..
Yeah I was sure that barcodescanner plugin does it, at least I have that problem on OnePlus11, but I installed my app on Huawei P40 and blackbar was gone. Also I manually changed Fullscreen settings on OnePlus11 to "always show feont camera" or smth.. from default so now it's fine. Still it doesn't fix my issue I dont want users to have that black bar there..
I was playing with MainActivity.kt to fix it on OnePlus but without results. It's strange bcs I dont have any other app installed on my phone with that blackbar...


Remove dependency on @adobe/oclif-base-index-command

added a few more tests too

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines         170    174    +4
  Branches       25     25
=====================================
+ Hits          170    174    +4

Impacted Files
Coverage Δ

src/commands/console/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b7fe55...0156828. Read the comment docs.

Also, this adds a new feature: aio console (no subcommand) will essentially call aio console:ls


Prisma Website has a not working link to slack

Bug description
Many software and github libraries have slack or discord channels to disccus and help each other. I don't find something similar for prisma.
Prisma Website has a not working link to slack
How to reproduce
Go to https://www.prisma.io/
In the footer, we find a link to slack : https://slack.prisma.io/
The link is broken !
Expected behavior
Such as a mature open source solution should have a communcation channel for its community !
Prisma information

Environment & setup
Go to https://www.prisma.io/
In the footer, we find a link to slack : https://slack.prisma.io/
The link is broken !
Prisma Version
Go to https://www.prisma.io/
In the footer, we find a link to slack : https://slack.prisma.io/
The link is broken !

Just visited this fine, both from your pasted link and from clicking the slack logo at the bottom of the site. Closing this - Please reopen If you're still experiencing an issue.


Allows trailing whitespace before closing > in inline/block html

Previously the regexp expected the closing first tag to contain zero
whitespace between the last property and the closing angle bracket.
As a result, the code foo would render incorrectly
as
foo</a>
\n
This change applies to unescaped inline and block elements.
Fixes #104

Hello, i'm not sure what the protocol is for this.
I ran into this bug from a strangely formed embed code i got from gyfcat, but i suspect others could run into it too.
the test_safe_links test is currently failing in master, but the test that this adds passes.
Let me know if you have any questions!

@nsfmc a test case failed.

Hi @lepture, I believe that test case is failing in master as well. If there is a branch I can fork off of that is building successfully I'm happy to rebase my pull request off that one. I'm afraid I don't understand well enough the changes needed to fix the link sanitization issues :(


ambient: do not embedd types in WDS

Part of https://github.com/istio/istio/issues/54482

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0bca535e59d72c2fdff6f4767ba5bfb4ef254190
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0bca535e59d72c2fdff6f4767ba5bfb4ef254190
link
true
/test lint

integ-ambient_istio
0bca535e59d72c2fdff6f4767ba5bfb4ef254190
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Add Python 3 support

With these changes, the script can be run both in Python 2 and Python 3.
Also, there is now full Unicode support, so no more crashes on (or ignoring of) non-ASCII filenames.
Tested in Python 2.7.13 and 3.6.1

Sorry for the delay, nice work! Thanks for contributing!


How does the view fill the center and fill the screen?

I'm afraid I don't know exactly what you mean. Can you elaborate on your question a bit more? What do you want to achieve?

Due to lack of feedback, reproduction is not possible.


Deis router picks up non-Deis traffic

tl;dr: Every Nth request of Type: LoadBalancer requests get sent to Deis router even if it is unrelated to Deis.
Environment

Deis Workflow 2.16
Google Container Engine
Kubernetes 1.6.7

Steps to reproduce

Install Deis Workflow
Install the sample app:

$ git clone git@github.com:vpetersson/flask-example.git
$ cd flask-example
$ kubectl create -f k8s/namespace.yml
$ kubectl create -f k8s/deployment.yml
$ kubectl create -f k8s/svc.yml

Verify the deployment:

$ kubectl get pods --namespace=flask-example
NAME                       READY     STATUS    RESTARTS   AGE
backend-1391627243-6hmgl   1/1       Running   0          37s
backend-1391627243-bxhh0   1/1       Running   0          37s

Get the external IP:

$ kubectl get svc --namespace=flask-example
NAME      CLUSTER-IP      EXTERNAL-IP      PORT(S)        AGE
backend   10.x.x.x   x.y.z.x   80:30570/TCP   1m

Issue a few curl requests to the external IP:

$ curl x.y.z.x
Hello World
$ curl x.y.z.x
Hello World
$ curl x.y.z.x

<title>404 Not Found</title>

404 Not Found

nginx/1.13.0

$ curl x.y.z.x
Hello World
$ curl x.y.z.x
Hello World
$ curl x.y.z.x
Hello World
$ curl x.y.z.x
Hello World
$ curl x.y.z.x
Hello World
$ curl x.y.z.x
Hello World
$ curl x.y.z.x

<title>404 Not Found</title>

404 Not Found

nginx/1.13.0

As you can see in the above, every Nth request gets a 404. Digging closer into this, we can find said 404's in the Deis router despite the service having nothing to do with Deis:
$ kubectl logs deis-router-3574011047-7z6mr --namespace=deis | grep 404
[...]
[2017-07-20T09:41:02+00:00] - router-default-vhost - 93.x.x.x - - - 404 - "GET / HTTP/1.1" - 324 - "-" - "curl/7.51.0" - "_" - - - 104.x.x.x - - - 0.000
[2017-07-20T09:41:18+00:00] - router-default-vhost - 93.x.x.x - - - 404 - "GET / HTTP/1.1" - 324 - "-" - "curl/7.51.0" - "_" - - - 104.x.x.x - - - 0.000

Interestingly however is that if we delete the deis router pod and let the deployment recreate the router, the 404s go away.

ping @krancour thoughts?

I can't promise I'll get to the bottom of this very quickly, but let's start here...
Can you confirm the external IP for the router is shown to be different than that of your flask app? (e.g. not "x.y.z.x")

@krancour Yeah it's a tricky one for sure. It took me about two days to figure out that the traffic was actually routed to Deis.
In terms of your question - yup the external IP for the deis-router is different from the flask app.

Also, just as an FYI - I did test this on two different clusters on GCE and was able to reproduce it on both.

Ok... so my first two thoughts:

This could a problem in GCP's networking. Personally, I find GCP networking difficult to understand in comparison to other clouds, and I'm not very eager to dig into it... but difficult though I may find it, I think it's also unlikely that it could be malfunctioning to this extent.

If we start with the premise that no. 1 isn't likely, the problem is in k8s-- or more likely still, the problem is specific to configuration / resources in your cluster. Let's explore this further first...

Next time you're able to observe this happening, could you please do a kubectl describe on the flask app's service? Among other things, it should show you the endpoints that are in service. These would be private IPs in the cluster's overlay network. i.e. These are the IPs of individual pods. I'd be interested in knowing if you can correlate one of the in-service endpoint IPs to the IP of a running router pod.
Let's start there. If there is indeed a router pod taking some of the traffic for that service, then we can turn our attention to figuring out how that pod got selected by the service.

@krancour sure thing:
$ kubectl describe svc backend --namespace=flask-example
Name:                   backend
Namespace:              flask-example
Labels:                 <none>
Annotations:            <none>
Selector:               app=backend
Type:                   LoadBalancer
IP:                     <IP_ADDRESS>
Port:                   http    80/TCP
NodePort:               http    32110/TCP
Endpoints:              <IP_ADDRESS>:5000,<IP_ADDRESS>:5000
Session Affinity:       None
Events:
  FirstSeen     LastSeen        Count   From                    SubObjectPath   Type            Reason                  Message
  ---------     --------        -----   ----                    -------------   --------        ------                  -------
  37s           37s             1       service-controller                      Normal          CreatingLoadBalancer    Creating load balancer

@vpetersson can you get the IP(s) of the router pod(s) as well? Need to compare those to the <IP_ADDRESS> and <IP_ADDRESS> seen above.

$ kubectl describe svc deis-router --namespace=deis                                               ✭
Name:                   deis-router
Namespace:              deis
Labels:                 heritage=deis
Annotations:            service.beta.kubernetes.io/aws-load-balancer-connection-idle-timeout=1200
Selector:               app=deis-router
Type:                   LoadBalancer
IP:                     <IP_ADDRESS>
LoadBalancer Ingress:   104.154.x.y
Port:                   http    80/TCP
NodePort:               http    32071/TCP
Endpoints:              <IP_ADDRESS>:8080
Port:                   https   443/TCP
NodePort:               https   30023/TCP
Endpoints:              <IP_ADDRESS>:6443
Port:                   builder 2222/TCP
NodePort:               builder 32116/TCP
Endpoints:              <IP_ADDRESS>:2222
Port:                   healthz 9090/TCP
NodePort:               healthz 31894/TCP
Endpoints:              <IP_ADDRESS>:9090
Session Affinity:       None
Events:                 <none>

No mention of those IPs as far as I can tell, @krancour.

 (I'm guessing this isn't a production cluster and that you can afford to try that. The easiest would be to just scale the router's deployment set down to 0 replicas.) I'm curious whether the periodic 404s will persist (i.e. it's not actually the router serving the 404s), go away entirely, or be replaced with some other issue like a 502 bad gateway or 503 unavailable.

If I scale down the router deployment to 0, the issue goes away and I don't get any 404s.

@vpetersson this issue is perplexing, but let me see if you agree with me on this-- this isn't a router issue. Something between your agent (e.g. curl) and the router (e.g. a GCP load balancer) would appear to be mis-directing traffic to the router. That mis-direction is hardly within the router's control.

Hi @krancour,
It's perplexing indeed. To be honest, I'm not exactly sure where the error stems from. As far as I can tell, it could either be a bug in GCP LB, k8s internals or in the router configuration. I'm not enough of an expert in k8s to tell.
From what I can tell, however, is that the GCP LB configuration seems to be fine, and so does the k8s configuration. Also, the only way I've been able to reproduce this is with a Deis router. That, of course, doesn't prove that the bug isn't in any of the former two.

@vpetersson the router proxies traffic to apps. If the router receives requests it should not have, something else directed that traffic to the router. I can't see a scenario where the router itself could be responsible for this happening.
If this isn't a production cluster and you can afford to experiment, consider writing a trivial program that listens on port 8080 and responds with some recognizable response. Build that into a Docker image and (in-place) kubectl edit the router's deployment. Change the image to that custom one and remove the readiness and liveness probes. (Don't change any other details of the deployment.) You should then be able to observe (I think) that whatever is mis-directing traffic to the router is still going to be misdirecting traffic to this bespoke router replacement.
My goal here is just to exonerate the router.

@vpetersson have you developed any new insight into how this is happening? For now, I am closing this, because I am certain this issue lies outside the router.