some CupertinoIcons is missing are flutter/lib/src/cupertino/icons.dart

such as 0xf375 icon, can't find in flutter/lib/src/cupertino/icons.dart.
i hava updated my pubspec.yaml,
  cupertino_icons:
    git:
      url: "https://github.com/flutter/cupertino_icons"

i can use it in this way, Icon(IconData(0xf375, fontFamily: 'CupertinoIcons', fontPackage: 'cupertino_icons').

CC @willlarche

Hi! Is that unicode hex mapped to an icon in documentation? Can you give me the link if so?

https://raw.githubusercontent.com/flutter/cupertino_icons/master/map.png

Issue still exist on
[✓] Flutter (Channel dev, v1.16.2, on Mac OS X 10.15.4 19E266, locale en-GB)
    • Flutter version 1.16.2 at /Users/taha/Code/flutter_dev
    • Framework revision 58cad787d8 (4 days ago), 2020-03-23 08:33:41 -0700
    • Engine revision 2d42c74a34
    • Dart version 2.8.0 (build 2.8.0-dev.16.0 ba8baa46b4)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/taha/Code/sdk
    • Android NDK location not configured (optional; useful for native profiling
      support)
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4, Build version 11E146
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 44.0.2
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.43.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.8.1

[✓] Connected device (4 available)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.4
    • macOS         • macOS                     • darwin-x64     • Mac OS X
      10.15.4 19E266
    • Chrome        • chrome                    • web-javascript • Google Chrome
      80.0.3987.149
    • Web Server    • web-server                • web-javascript • Flutter Tools

• No issues found!

Merging into #16102


Write CLI in ES6

This takes advantage of a technique I've been using for transpiling tools with CLIs. The bin file just requires './cli' relative to the main file and the actually meat of the CLI goes in the lib/ folder.

@bendrucker Thanks for the PR — like the idea of moving the cli to src!


Add a question to determine if the beta user is a legal professional.

Description
As a user, I would like the system to ask me whether I am a legal professional or not.
Scope of Work

[ ] Create UI element that allows the user to input whether or not they are a legal professional
[ ] Add an API endpoint for recording the user response

Acceptance Criteria

The user opens up the beta application. User is then shown a dialog that allows them to designate  whether or not they are a legal professional.

Pinging @naregeff for sign off

Functionality demonstrated.
Whenever possible, 1) update string to "Oh, and one last thing, do you happen to be a legal professional (lawyer, lawyer-to-be, judge, clerk, etc.)?" and 2) align the yes/no buttons to the left.


Dynamic Variants

Hello guys,
Firstly, I just want to know if this project is still in developing or not, because I'm sooooo in love with Stitches. Looking it haven't got any commits for the last 5 months is so sad :(
If this's still in progress, I hope that we can have dynamic variants or component scope utils. For details, we can pass a dynamic values to variants as a function argument like we did with utils.
hope to see your comeback.

Hey @nmhieu1896 👋
We don't plan on adding dynamic variants as part of the library as most of the cases for dynamic variants can be achieved with normal variants and custom css properties.
I've made a demo here and the a bit of a discussion about it is available on discord

if i wouldlike create progressbar  and i passed progress how can i do this without dinamic variant?

As an option
const ProgressBar = styled('div', {
  width: '100%',
  transform: 'scaleX(var(--progress-bar-status, 0))',
})

const App = ({ progress }) => {
  return <ProgressBar style={{ --progress-bar-status: progress / 100 } as SomethingToSurpressReactStyleBeingUnhappy) />;
}


Multiple $csp rules do not work

See the test here:
http://csp-tests.surge.sh/Filters/csp-rules/test-csp-rules.html
Steps to reproduce

Add these rules to the user filter:||example.org$csp=img-src https:
||example.org$csp=img-src example.org

Open example.org

Expected result
Two CSP headers in the response
Actual result:
Just one

core/pull-requests/1429


Bugfix: Don’t prefill name and mobile number after abandoned registration

If you've completed the first step of registration (adding name, password and mobile number) but didn't complete the 2FA, and then you later go back and attempt to start again using the invite link, it probably makes sense not to prefill the form with your name and mobile number from last time...
See https://trello.com/c/dm7gIfWt/449-account-details-pre-filled-after-abandoning-account-registration

@frankieroberto I'm getting this error after clicking on login button


Integration Test for Istio custom GRPC count metrics

Please provide a description of this PR:
Part of #44144

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@whitneygriffith: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test release-notes

unit-tests-arm64_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test unit-tests-arm64

lint_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test release-notes

unit-tests-arm64_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test unit-tests-arm64

lint_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test lint

gencheck_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test all

@whitneygriffith: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test unit-tests-arm64

lint_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test lint

gencheck_istio
1c24b41f190037b57bb4929f64809bb58fdda911
link
true
/test gencheck

release-notes_istio
d390422ac1ab84d25d75ec859ed987fc261d6a21
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@whitneygriffith: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
d390422ac1ab84d25d75ec859ed987fc261d6a21
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-notes
@whitneygriffith  can you also add one for Telemetry API?

In response to a cherrypick label: new pull request created: #44287

In response to a cherrypick label: new pull request created: #44288

/test release-notes
@whitneygriffith can you also add one for Telemetry API?

Sure!


Use arm64 build agents to build arm64/armhf builds

We now have arm64 build agent pools. We could leverage them to run the followings jobs:

Windows arm64
Linux arm64
Linux armhf
Alpine arm64

It seems we use this already for the CLI. Maybe @connor4312 can give us more insights on how easy this was to achieve. Also, @connor4312, did you try getting Windows ARM64 agents?

It was harder before, but it looks like since arm64 SKUs are now in GA, it's pretty easy to do: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-hosted-azure-devops-pools/onboarding-arm64

did you try getting Windows ARM64 agents?

I didn't run into the need for this, since msbuild was able to cross-compile to arm64 windows without issues.


[Enhancement] Embedded message

I wonder if u can make the join and leave or other messages sent by the bot become embedded like this

This enhancement will not be considered because embedded messages are not beautiful and unnecessary for MCDC using Webhook. Also, it will bring a lot of work building embedded messages and making the switch between normal and embed.


Support for spark 3

Any plans to support spark 3?

Sure!
Main issue is a proper integration env for tests. I will look into it and try to publish a snapshot version.


chore(deps): upgrade jenkins-x/jx3-pipeline-catalog to version 3.2.322

from: https://github.com/jenkins-x/jx

/retest


Update README.md

Had to dig into additional docs to realize it was :sequel OR :activerecord

@ckk-scratch Thanks for pointing out an unclear part of the documentation. I prefer to use or instead of ||, so I'll push that patch instead.


Colegio Refous

Colegio Refous

@yvivas First stage of verification passed, official domain is colegiorefous.edu.co as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@yvivas Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Training accuracy does not change while training entire resnet18 from scratch

I was using c2q_transfer_learning_ants_bees.ipynb this notebook and I let all the layers of resnet18 to train from scratch on the ants_bees dataset. And I did not change anything else on the code but now while training the model, the accuracy does not improve more than 55%.
Can you guys suggest what might be causing this?
Code I changed:
model_hybrid = torchvision.models.resnet18(pretrained=False)

for param in model_hybrid.parameters():
    param.requires_grad = True

if quantum:
    model_hybrid.fc = Quantumnet()

elif classical_model == '512_2':
    model_hybrid.fc = nn.Linear(512, 2)

elif classical_model == '512_nq_2':
    model_hybrid.fc = nn.Sequential(nn.Linear(512, n_qubits), torch.nn.ReLU(), nn.Linear(n_qubits, 2))

elif classical_model == '551_512_2':
    model_hybrid.fc = nn.Sequential(nn.Linear(512, 512), torch.nn.ReLU(), nn.Linear(512, 2))

# Use CUDA or CPU according to the "device" object.
model_hybrid = model_hybrid.to(device)

Training Log:
Training started:
/usr/local/lib/python3.10/dist-packages/torch/optim/lr_scheduler.py:139: UserWarning: Detected call of `lr_scheduler.step()` before `optimizer.step()`. In PyTorch 1.1.0 and later, you should call them in the opposite order: `optimizer.step()` before `lr_scheduler.step()`.  Failure to do this will result in PyTorch skipping the first value of the learning rate schedule. See more details at https://pytorch.org/docs/stable/optim.html#how-to-adjust-learning-rate
  warnings.warn("Detected call of `lr_scheduler.step()` before `optimizer.step()`. "
Phase: train Epoch: 1/30 Loss: 0.7062 Acc: 0.4877
Phase: val   Epoch: 1/30 Loss: 0.7001 Acc: 0.4575
Phase: train Epoch: 2/30 Loss: 0.6950 Acc: 0.5041
Phase: val   Epoch: 2/30 Loss: 0.6983 Acc: 0.4575
Phase: train Epoch: 3/30 Loss: 0.6939 Acc: 0.5041
Phase: val   Epoch: 3/30 Loss: 0.6965 Acc: 0.4575
Phase: train Epoch: 4/30 Loss: 0.6945 Acc: 0.5041
Phase: val   Epoch: 4/30 Loss: 0.6950 Acc: 0.4575
Phase: train Epoch: 5/30 Loss: 0.6935 Acc: 0.5041
Phase: val   Epoch: 5/30 Loss: 0.6951 Acc: 0.4575
Phase: train Epoch: 6/30 Loss: 0.6935 Acc: 0.5041
Phase: val   Epoch: 6/30 Loss: 0.6947 Acc: 0.4575
Phase: train Epoch: 7/30 Loss: 0.6934 Acc: 0.5041

Hi @sleepingcat4,
There are many reasons why this could be happening.
The quantum model may not be expressive enough to do the training from scratch, there may be issues with your optimizer, you may need to modify the model architecture or it may be something else entirely.
A while ago it was pointed out that both the classical and quantum implementations of transfer learning had some issues (see here) so this may or may not be related to that.
This is a question where the answer will require you to do some research and try out different options to see if there's a solution.
I hope this motivates you to look deeper into the problem and let us know if you find the answer!

thanks for your response. I suspected the same. I am aware of the limitations of transfer-learning in Classical Deep Learning but its interesting know about Quantum faces the same problem. I just wanted to ask, If I want to modify the Quantum Network, what is the best approach in modifying the network?
Should I add more VQC/Classical DL equivalent to CNN layers or you suggest something different? I will also look into more research papers as well.

Hi @sleepingcat4 ,
Adding more layers in QNNs doesn't necessarily help the way it does in classical CNNs. You can try this but I doubt the solution lies here. Something you can try (although I don't specifically know how you would do it) is changing the cost function. You can take inspiration from our demo on local cost functions. This is really just a guess so please make sure to believe the papers you read more than my guess 😄 .

@CatalinaAlbornoz I think I have identified the problem. The way the tutorial was written, it oversimplified a lot of concepts in QCNN.
I read a few papers, don't really have a gold standard in terms of What QCNN should be, but researchers who received either 90/100% accuracy, exploited Hilbert Space and used MERA method to train the Quantum Network from scratch.
Otherwise took each pixel values and converted into angles via arctan() function.
And thanks for the Barren Platues technique. I used it, previously but completely forgot about that.
I would love to hear your thoughts on this : )


Fix fetchInterval for sample calendar

fixes #3138 just in case #3137 doesnt get worked on until the next release

inc fetchInterval for sample calender
add fetchInterval config per calendar

Codecov Report

Merging #3139 (e9ead22) into develop (675e4d4) will increase coverage by 0.10%.
The diff coverage is 78.57%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop    #3139      +/-   ##
===========================================
+ Coverage    25.55%   25.65%   +0.10%
===========================================
  Files           53       53
  Lines        11479    11482       +3
===========================================
+ Hits          2933     2946      +13
+ Misses        8546     8536      -10

Impacted Files
Coverage Δ

modules/default/calendar/calendar.js
0.00% <0.00%> (ø)

modules/default/updatenotification/git_helper.js
84.50% <100.00%> (+1.17%)
:arrow_up:

... and 1 file with indirect coverage changes


Speed up unit tests

Unit tests are quite long to run right now. The idea is to speed up them by running them in parallel.
Switching to Circle CI would be also a good move.

v2 is published 🎉


bump the luigi version to 3.4.0

Fix for https://github.com/broadinstitute/seqr-loading-pipelines/pull/625#issuecomment-1822477463.

FYI we also need to bump in the root of the repo, which I'm handling! Thank you for finding though!

Thanks for pointing it out.


Revert "Validate content type removal"

@bratseth or @geirst please merge if this is the culprit :)
Reverts vespa-engine/vespa#5715

👍


[core] Adopt pnpm catalogs for React deps

Adopts pnpm catalogs for React dependencies to have an easier way to share the same version between different packages.
This will also make it easier to fix the react-next CI pipeline by having a centralized place to upgrade React packages versions. The useReactVersion.js script is very outdated and the react-next pipeline has been broken for a long time.

Q: we have some packages under test/bundling/fixtures that define their own React version. Do we want these to use the centralized React version, too?

One drawback I could think of us that it's now harder for tooling to statically analyze the versions in package.json. Was the pnpm update -r method not working for react?

Was the pnpm update -r method not working for react?

It should work for react, react-dom, react-is, etc. Bur for the React 19 type packages, afaik there's no way to run pnpm update and point those packages to<EMAIL_ADDRESS>Do you know if there's a way to achieve it?
With catalogs, we also get this functionality for free: https://github.com/mui/material-ui/blob/master/scripts/useReactVersion.mjs#L23-L27
But I agree catalogs can come with some downsides e.g. doesn't support pnpm update just yet (https://pnpm.io/catalogs#caveats). On the other side, the group of React dependencies is probably special and static automatic updates are probably not that important.

This is what a script should do to change React packages versions: https://github.com/mui/material-ui/pull/43456/commits/984878b6a34b71b9c9ad6ca647567820fabb7805
The idea would be to keep in pnpm-workspace.yaml all of the different catalog versions (react19, react17, etc.) so a script would only require to replace the catalog: block with the desired version.

The idea would be to keep in pnpm-workspace.yaml all of the different catalog versions (react19, react17, etc.) so a script would only require to replace the catalog: block with the desired version block.

Alternatively: keep multiple pnpm-workspace.yaml files and rename the one we want to use 🤔

Alternatively: keep multiple pnpm-workspace.yaml files and rename the one we want to use 🤔

That's a great idea. The only downside I can think of is parts of the file getting out of sync (e.g. the packages list)

afaik there's no way to run pnpm update and point those packages (e.g. @types/react) to<EMAIL_ADDRESS>
This should work:
pnpm update -r @types/react<EMAIL_ADDRESS>
I'm a bit wary using catalogs as it doesn't feel like a cemented feature in package managers, it doesn't seem like even pnpm has fully adopted support for it. If a classic solution works just as well, I think I'd prefer it over creating potential tech debt. And in any case, once pnpm adds support for catalogs in their update command, I believe our solution would look very similar. (e.g. pnpm update-catalog -r @types/react<EMAIL_ADDRESS>

This should work:
pnpm update -r @types/react<EMAIL_ADDRESS>

TIL! Thanks!
I totally agree with your points. I'll close this experiment


tvos support

tvOS is pretty new and as far as I figured out some feature are not available (yet), but do you plan to add support for it next releases even for cocoapods auto install?

Let me look if I can add a target for that quickly.

Yep, the unique thing is that I'm pretty aware of some functions available in iOS are disabled/removed in tvOS - https://developer.apple.com/library/prerelease/tvos/releasenotes/General/tvOS90APIDiffs/

@matteocrippa I do not have the new Apple TV yet. But this new target does build. It only supports taking the central role though, as that is all that is allowed by tvOS.

It won't work with Cocoapods. I'll have to split it into subspecs, which probably makes sense anyhow, as you'll most likely often only want to be either a peripheral or a central on one device.

@rasmusth i'll give a try next week back work with the atv dev kit, 'll keep you posted!

@matteocrippa !

@rasmusth i was out of office in those last few days, hopefully tomorrow i'll be back in the office

Any update? Awesome library, would love to use it with tvOS! :)

@rjgdesign Please check out the development branch and test if it works with the tvOS target. I don't have an Apple TV.

Fixed.


Get response json on add character in cell

Hi,
I want updated json on add character in cell, currently i am getting only first character of cell in update json, For getting whole updated json i have to change or focus on another cell. So, It is possible to get updated json on change of any single character in cell.
Here i attach screen shot of tables with enter data "at" and in json only get single character "a" .

Please help me to resolve this.

Once the input is complete, the data changes

Hello Myliang,
Thank you for reply.
Once input is complete i have to click other cell then it consider data change. But i want without click any other cell, currently selected cell value should update in json.
Please help me to achieve this.

Hello Myliang,
I am waiting for your replay. Please help me to solve this.

fixed

Hello Myliang,
I am waiting for your replay. Please help me to solve this.

have fixied

Hi Myliang,
Thank you for update.


Unify our various places where resources are being saved

To enable full support of virtual document saving (starting with https://github.com/Microsoft/vscode/issues/10547):

[ ] make our dirty indicators outside the editor fit for this
[ ] support auto save (or not?)
[ ] support hot exit
[ ] support save participants
[ ] support to set the encoding for saving
[ ] support undo properly (undo enough to get back to saved state)
[ ] support to search through resources (today we only search file & untitled)
[ ] revisit our hardcoded assumptions in places like actions that only think file & untitled resources are editable
[ ] debt: make the confirmation dialog reusable
[ ] debt: reuse more code between file saving and resource saving

/cc @jrieken @egamma this is the issue I captured on enabling resources to be writeable. It seems that we are picking this up again in September, so should I reserve time for it?

Well, at least the assumption for file and untitled need to be revisited. I have come a long way with my changes in #34229 so most might be just debt

What puzzles me is that the text model contains a lot of save-dupe code while I would have assumed that such things belong into the service

Yeah, a lot of that code is from time where we had no services ;)

@jrieken so it seems your changes basically enable to use ITextFileEditorModel with resources that are not file:// scheme. Maybe we should just rename our ResourceInput/Model to ReadonlyResourceInput/Model and the file related classes to EditableResourceInput/Model at some point. If so, it seems that there is work left to:

revisit our various toResource calls and assumptions
make sure we are not using URI.file unless the client is really about dealing only with files


React and Javascript support

Now that I've spent some time with Gradio, it's clear that it's too inflexible to support the kinds of features that are needed. In addition my hope is that Agency is a foundation for custom applications, and Gradio unfortunately doesn't fit that use case well enough.
So I'll be dusting off the older React app implementation, and updating it to enable work on multimedia and other features.
As part of this, I'll be developing a proper JS client that will become the communication basis for the front end. The JS client will likely mirror the API in python, and allow communication across the two languages.

I've decided that these features will be addressed in a new independent project dedicated to creating a new UI for experimentation and development. See the discussion here for more details.
If you'd like to sign up to be emailed when a prototype is ready, please click here.


Added roadmap to learn generative AI

Related Issues or bug
Fixes: #384 Feature request: Add Python Libraries and Tools to learn Generative AI
Proposed Changes
I have made following changes listed below

created GENERATIVE_AI_ROADMAP.md file

Overview of Generative AI
Roadmap to learn Generative AI
python libraries to learn Generative AI
LLM models and its examples
Retrieval augumented generation (RAG)
embedding models
Vector databases
Graph databases
AI agents
PDF scrapping tools and services.

Changes in README.md file to get refer GENERATIVE_AI_ROADMAP.md file

Screenshots

Orginal

Updated

@vishnumur777 good you can also do it for DL

@vishnumur777 good you can also do it for DL

Mam, can I do a detailed Roadmap for Computer Vision and NLP and also one like  Learning LLM with title "All about LLMs"
Please assign me if it's possible
@UppuluriKalyani


Additional fixes around versioning.

Additional fixes around getting/setting version dropdown content.

@dkamburov I guess you will test the change from Maya? We have documented a brief explanation on how to test typedoc-theme changes, I guess you will find it helpful:

npm run build of ig-typedoc-theme changes to build the package in the dist folder
"npm pack" to create a package (ig-typedoc-theme-1.0.0.tgz)
"cp ig-typedoc-theme-1.0.0.tgz ~"
Go to igniteui-angular project and execute "npm install ~/ig-typedoc-theme-1.0.0.tgz"
Build typedoc with any of the existing commands, lets use for example - npm run build:typedoc:en:production
Go to ..\igniteui-angular\dist\igniteui-angular\docs\typescript and run the html

Note: OR, you can use npm link but this sometimes gives problems


Merge main to tokenizer branch

Will call out the merge locations.

@dotnet/razor-compiler for review

Will call out the merge locations.

You could tokenize them.


commit-mono: 1.136 -> 1.138

Description of changes
Diff: https://github.com/eigilnikolajsen/commit-mono/compare/1.136...1.138
Changelogs:
https://github.com/eigilnikolajsen/commit-mono/releases/tag/1.137
https://github.com/eigilnikolajsen/commit-mono/releases/tag/1.138
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@yoav-lavi A reminder to please review this commit? Looking forward to using the latest Commit Mono from nixpkgs!


Travis: Use dpkg asio instead of downloading it

ASIO was downloaded and install instead of relying on Debian package.
This leaded to slower build and useless Travis worker bandwidth.
Use the white-listed libasio-dev apt package.

This pull request is now managed with CodeReviewHub. Refresh.

The white-listed libasio-dev apt package is not compatible with C++.


Refs #13724 -- Corrected QuerySet signature in docs.

Just came across this docs mismatch, here the update if needed

@Rusox89 Thanks!


Linux .desktop file

Thanks for your awesome library!
I suggest to use desktopFileName from QGuiApplication instead of setting it manually in via setAttribute. It will allow to call QGuiApplication::setDesktopFileName("myapp.desktop") in main.cpp only once for all classes.

Thats a good idea - I did not know of this property until now!

Great! I can send a pull request for it if you busy now.

That would be awesome! Simply remove SetupKey::LinuxDesktopFile enum value and change the code to use the GUI applications value, I will tag this as a new major version. Also, do not forget to update the README.


fix: update building scripts and BIP21 scheme

:tada: This PR is included in version 5.0.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix(assets): move images back to static folder

Deploy preview for pf-next ready!
Built with commit 336de8923eef82b798617ad341edcc1eecb341ef
https://deploy-preview-331--pf-next.netlify.com


Build fails for JRuby (travis-ci)

Actually, JRuby does allow for builing native C extensions. My blastxml parser does it. Maybe because it uses nokogiri.

Potential solution is related to https://github.com/twilio/twilio-ruby/pull/375, i.e. it's the libxml gem that is preventing the JRuby build at this point.

How much effort would it be to migrate to nokogiri? We use the streaming API, in my understanding - parser.rb.

I  just started to look at this and experiment with it on a new branch, and was about to open a ticket asking this exact question.  It appears to be the recommended approach now versus compatability.
It's not just a matter of dropping in replacement classes, some of the paramater signatures are different, but at the same time pertinent code is pretty nicely isolated.  If I make significant progress I'll share a branch on my fork.


[useDialogs] Allow customizing dialogs.prompt, dialogs.alert and dialogs.confirm

Summary
The dialogs.open function accepts a React component and supports customization. A user requested the same support for dialogs.prompt
User request: https://discord.com/channels/1131323012554174485/1248515176626524200/1302895534054314035
Examples
No response
Motivation
No response
Search keywords: dialogs

We could add slots to the DialogProvider for each of the system dialogs, and then export each of the system dialogs themselves so they can be customized. That way users can create their own system dialogs and set them as default.


adguardhome: 0.104.3 -> 0.105.2

Motivation for this change
Upgrading adguardhome to the latest available version.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 118709 at 386fc750 run on x86_64-linux 1

1 package built successfully:

adguardhome

2 suggestions:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/adguardhome/default.nix:12:3:
   |
12 |   installPhase = ''
   |   ^

warning: unclear-gpl
gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.
Near pkgs/servers/adguardhome/default.nix:21:5:
   |
21 |     license = licenses.gpl3;
   |     ^


Add helm unittesting scaffolds

related to https://github.com/rstudio/helm/pull/593
Our helm charts are missing tests that can assert that the rendered helm chart templates produce the correct output based on the inputs. This PR sets up unittest scaffolds for all product chart owners to start adding these types of tests
We use the helm unittest plugin for writing tests. Tests live in the charts/*/test directory for each helm chart.

Need to bump the chart version
✖ rstudio-connect => (version: "0.7.12", path: "charts/rstudio-connect") > chart version not ok. Needs a version bump!

Perhaps if the tests directory is added to .helmignore per https://github.com/helm-unittest/helm-unittest?tab=readme-ov-file#get-started then we won't have to bump the chart version when adding tests (which feels like a bad thing)?

Perhaps if the tests directory is added to .helmignore

Looks like changing the .helmignore means we have to bump the version initially, which I guess makes sense because it could impact packaging. I'm going to bump Connect's version here and I'll leave it to other chart owners to decide when they want to make this change in their charts to add tests.

Perhaps if the tests directory is added to .helmignore

Looks like changing the .helmignore means we have to bump the version initially, which I guess makes sense because it could impact packaging. I'm going to bump Connect's version here and I'll leave it to other chart owners to decide when they want to make this change in their charts to add tests.

Yeah, makes sense that the addition of .helmignore requires a version bump. I wonder if a change to .helmignore would require and additional bump, my guess is yes. But that changes to anything it is ignoring would not.

Looks like changing the .helmignore means we have to bump the version initially, which I guess makes sense because it could impact packaging. I'm going to bump Connect's version here and I'll leave it to other chart owners to decide when they want to make this change in their charts to add tests.

I don't see the downside in adding .helmignore for each chart now, to make it simpler for everyone else to get started in the future.
Yes, it's a version bump right now which is slightly annoying.  But it makes everything easier for those coming after you, they won't need to know to put the .helmignore file in place.  They can just get busy writing tests!

Looks like changing the .helmignore means we have to bump the version initially, which I guess makes sense because it could impact packaging. I'm going to bump Connect's version here and I'll leave it to other chart owners to decide when they want to make this change in their charts to add tests.

I don't see the downside in adding .helmignore for each chart now, to make it simpler for everyone else to get started in the future.
Yes, it's a version bump right now which is slightly annoying. But it makes everything easier for those coming after you, they won't need to know to put the .helmignore file in place. They can just get busy writing tests!

Works for me!


k8s_watcher.go:273: watch of *k8s.CiliumNetworkPolicy ended with: too old resource version

This roughly happens every 300 seconds. It doesn't affect the watcher.
So far it's happening with k8s 1.8

Any idea what the underlying etcd event is that trigger this?

@tgraf it's not our code, it's from the kubernetes watcher
It's difficult to replicate because I've the exact same code for cilium CRD and a dummy CRD. On the dummy CRD this never happens. I'm still debugging this.

I'm also seeing this error in my installation which is running k8s 1.7.2
time="2017-11-17T01:34:33Z" level=warning msg="unable to update CNP, retrying..." ciliumNetworkPolicyName=secure-empire-kafka error="Operation cannot be fulfilled on ciliumnetworkpolicies.cilium.io \"secure-empire-kafka\": the object has been modified; please apply your changes to the latest version and try again" k8sNamespace=default subsys=k8s

This can't be fixed. The error message is being written directly into os.stderr
os.Stderr.Write([]byte("ERROR: logging before flag.Parse: "))
os.Stderr.Write(data)


Dead link doesn't let me to continue

Challenge Make Dead Links using the Hash Symbol has an issue.
User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
So, in order to complete this challenge I have to set the a element to dead link using Hash symbol, I did it but I can't continue.
 It works fine for me. Have you tried refreshing the page and/or resetting the code again?

It didn't worked refreshing nor reseting, I just left it for a while and when I get back it worked. Thank you

Closing this as it seems to be resolved. Feel free to reopen if the issue persists.

Am not able to submit and move on to next challenge?

thanks resolved

having the same issue :(


Pink station

About the PR
Added many items for the Financial Supervisor and Blue Shield
Why / Balance
Upcoming jobs
Technical details
Media
Credits all by: Vixen
Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
Changelog

add: Added some clothes for the upcoming Financial Supervisor.
add: Added some clothes and hardsuit option for the Blue Shield.

Wrong repo, I'm assuming.

yes....

so sorry..

Don't apologize, you're good, it happens. Just letting you know since sometimes people miss it.


Wallet recovery from json file & wallet words does not recover my mining address

Hard drive died, wallet recovery from json file & wallet words does not recover my wallet address I had used for mining.
Is this what you call successful backup & recovery?
Is this normal?
Please help!

You can check all your addresses in settings > wallet > more opts > wallet addresses

Thanks. Probably you should show old addresses so noobs won't freak out. Thank you for your help.

@Miner01-PC
I can recover your wallet from any file type. I an expert in this regard. if you want need help send me email<EMAIL_ADDRESS>


Time Series with SAP HANA APL Forecast (Forecast SQL)

Tutorial URL: https://developers.sap.com/tutorials/hxe-aa-forecast-sql-04.html
Step :Run the algorithm with “No Extra Predictors”
I have this error in my console :
Statement 'truncate table apl_cashflow_indicators'
successfully executed in 66 ms 834 µs  (server processing time: 7 ms 434 µs) - Rows Affected: 0
java.sql.SQLWarning: wrong number or types of parameters in call: Column mismatch happened at "SAP_PA_APL"."sap.pa.apl.base::FORECAST": Declared type "NCLOB"  of attribute "VALUE" not same as assigned type "NVARCHAR(5000)"
Could not execute 'call sap_pa_apl."sap.pa.apl.base::FORECAST" ( apl_cashflow_function_header , ...' in 1.812 seconds .
SAP DBTech JDBC: [362]: invalid schema name: "SAP_PA_APL"."sap.pa.apl.base::FORECAST": line 20 col 3 (at pos 878): "SAP_PA_APL"."sap.pa.apl.base.internal::GET_PROCNAME_2": line 50 col 6 (at pos 2233): [362] (range 3) invalid schema name exception: invalid schema name: "SAP_PA_APL"."sap.pa.apl.base.internal::GENERATE_TYPE": line 37 col 5 (at pos 1493): APL_CACHE: line 1 col 13 (at pos 12)
Duration of 5 statements: 2.082 seconds

Sorry for the delay, is this still an issue.  If so I will try and recreate on my side.


Hot Module Replacement with MuiThemeProvider always errors

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Possibly related:
https://github.com/mui-org/material-ui/issues/8353
https://github.com/mui-org/material-ui/issues/8878
Expected Behavior
Whenever I change a value in my const styles = theme => ({..}) in Drawer (or anything else in the application), material-ui withStyles should not throw an error.
Current Behavior
Anytime I change a value in my styles definition (or anything for that matter), after a hot module replacement, the following error occurs. The UI still updates as expected, but the errors start stacking up.
Uncaught TypeError: Cannot read property 'refs' of undefined
    at ProxyComponent.detach (withStyles.js:339)
    at ProxyComponent.detach (createPrototypeProxy.js:44)
    at ProxyComponent.<anonymous> (withStyles.js:251)
    at commitCallbacks (react-dom.development.js:6155)
    at commitLifeCycles (react-dom.development.js:8812)
    at commitAllLifeCycles (react-dom.development.js:9967)
    at HTMLUnknownElement.callCallback (react-dom.development.js:540)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:579)
    at invokeGuardedCallback (react-dom.development.js:436)
    at commitRoot (react-dom.development.js:10071)

react-dom.development.js:9769 The above error occurred in the <withStyles(ResponsiveDrawer)> component:
    in withStyles(ResponsiveDrawer) (created by App)
    in MuiThemeProvider (created by MuiThemeProviderWrapper)
    in MuiThemeProviderWrapper (created by App)
    in App
    in Router (created by ConnectedRouter)
    in ConnectedRouter
    in Provider
    in AppContainer

Cannot read property 'refs' of undefined
    at ProxyComponent.detach (withStyles.js:339)
    at ProxyComponent.detach (createPrototypeProxy.js:44)
    at ProxyComponent.<anonymous> (withStyles.js:251)
    at commitCallbacks (react-dom.development.js:6155)
    at commitLifeCycles (react-dom.development.js:8812)
    at commitAllLifeCycles (react-dom.development.js:9967)
    at HTMLUnknownElement.callCallback (react-dom.development.js:540)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:579)
    at invokeGuardedCallback (react-dom.development.js:436)
    at commitRoot (react-dom.development.js:10071)

Steps to Reproduce (for bugs)
Unfortunately this is a HMR issue, and I can't workup a codesandbox.io example. Here is my relevant setup (maybe I am doing something wrong?)
Steps

Build / Run
Modify any part of app under the hot.module.accept (styles, content, etc...)
Error occurs but UI updates OK (the UI still updates fine - but the error is still thrown)

App.js
import React from 'react';
import ReactDOM from 'react-dom';
import { MuiThemeProvider, createMuiTheme } from 'material-ui/styles';
import purple from 'material-ui/colors/purple';
import blue from 'material-ui/colors/blue';
import green from 'material-ui/colors/green';
import red from 'material-ui/colors/red';

import Drawer from '../Drawer';
import DevTools from '../DevTools';

const theme = createMuiTheme({
  palette: {
    primary: green, // Purple and green play nicely together.
    secondary: {
      ...green,
      A400: '#00e677',
    },
    error: red,
  },
  overrides: {
    MuiDrawer: {
      docked: {
        flex: '0 0 auto',
        height: '100%'
      }
    }
  }
});

class App extends React.Component {
  render() {
    return (
        <MuiThemeProvider theme={theme}>
          <Drawer />
        </MuiThemeProvider>
    );
  }
}
export default App;

Drawer.js
import React from 'react';
import PropTypes from 'prop-types';
import { withStyles } from 'material-ui/styles';
import Drawer from 'material-ui/Drawer';
import AppBar from 'material-ui/AppBar';
import Toolbar from 'material-ui/Toolbar';
import List from 'material-ui/List';
import Typography from 'material-ui/Typography';
import IconButton from 'material-ui/IconButton';
import Hidden from 'material-ui/Hidden';
import Divider from 'material-ui/Divider';
import MenuIcon from 'material-ui-icons/Menu';
import Grid from 'material-ui/Grid';
import Paper from 'material-ui/Paper';
import { mailFolderListItems, otherMailFolderListItems } from './tileData';

const drawerWidth = 240;

const styles = theme => ({
  root: {
    width: '100%',
    marginTop: 4,
    zIndex: 1,
    height: '100%',
    overflow: 'hidden',
  },
  appFrame: {
    position: 'relative',
    display: 'flex',
    width: '100%',
    height: '100%',
  },
  appBar: {
    position: 'absolute',
    marginLeft: drawerWidth,
    [theme.breakpoints.up('md')]: {
      width: `calc(100% - ${drawerWidth}px)`,
    },
  },
  navIconHide: {
    [theme.breakpoints.up('md')]: {
      display: 'none',
    },
  },
  drawerHeader: theme.mixins.toolbar,
  drawerPaper: {
    width: 250,
    height: '100%',
    [theme.breakpoints.up('md')]: {
      width: drawerWidth,
      position: 'relative',
      height: '100%',
    },
  },
  content: {
    backgroundColor: theme.palette.background.default,
    width: '100%',
    padding: theme.spacing.unit * 3,
    height: 'calc(100% - 56px)',
    marginTop: 56,
    [theme.breakpoints.up('sm')]: {
      height: 'calc(100% - 64px)',
      marginTop: 64,
    },
  },
  gridRoot: {
    flexGrow: 1
  },
  gridPaper: {
    padding: theme.spacing.unit * 2,
    height: '100%'
  },
  docked: {
    height: '100%'
  }
});

class ResponsiveDrawer extends React.Component {
  state = {
    mobileOpen: false,
  };

  handleDrawerToggle = () => {
    this.setState({ mobileOpen: !this.state.mobileOpen });
  };

  render() {
    const { classes, theme } = this.props;

    const drawer = (

        <Divider />
        <List>{mailFolderListItems}</List>
        <Divider />
        <List>{otherMailFolderListItems}</List>

    );

    return (

          <AppBar className={classes.appBar}>
            <Toolbar>
              <IconButton
                color="contrast"
                aria-label="open drawer"
                onClick={this.handleDrawerToggle}
                className={classes.navIconHide}
              >
                <MenuIcon />
              </IconButton>
              <Typography type="title" color="inherit" noWrap>
                Responsive drawer
              </Typography>
            </Toolbar>
          </AppBar>

          <Hidden mdUp>
            <Drawer
              type="temporary"
              anchor={theme.direction === 'rtl' ? 'right' : 'left'}
              open={this.state.mobileOpen}
              classes={{
                paper: classes.drawerPaper,
              }}
              onRequestClose={this.handleDrawerToggle}
              ModalProps={{
                keepMounted: true, // Better open performance on mobile.
              }}
            >
              {drawer}
            </Drawer>
          </Hidden>
          <Hidden mdDown implementation="css">
            <Drawer
              type="permanent"
              open
              classes={{
                docked: classes.docked,
                paper: classes.drawerPaper,
              }}
            >
              {drawer}
            </Drawer>
          </Hidden>

              <Grid container className={classes.gridRoot}>
                <Grid item xs={12}>
                  <Grid container alignItems='stretch'>
                    <Grid item key={1}>
                      <Paper className={classes.gridPaper}>
                        {'Content 1'}
                      </Paper>
                    </Grid>
                    <Grid item key={2}>
                      <Paper className={classes.gridPaper}>
                        {'Content 2'}
                      </Paper>
                    </Grid>
                    <Grid item key={3}>
                      <Paper className={classes.gridPaper}>
                        {'Content 3'}
                      </Paper>
                    </Grid>
                  </Grid>

                </Grid>
              </Grid>

    );
  }
}

ResponsiveDrawer.propTypes = {
  classes: PropTypes.object.isRequired,
  theme: PropTypes.object.isRequired,
};

export default withStyles(styles, { withTheme: true })(ResponsiveDrawer);

Context
If I remove MuiThemeProvider from App.js, all works as expected with the default theme.
Doing some debugging, it looks like this line, at some point returns undefined / null:
var sheetManagerTheme = sheetManager.get(theme)
https://github.com/mui-org/material-ui/blob/023fee9092571e98814e64221015c6b669353fbe/src/styles/withStyles.js#L267
in the detach method.
Your Environment

Tech
Version

Material-UI
^1.0.0-beta.21

React
16.0.0

browser
Chrome latest

@jackjwilliams Could you set up a reproduction repository so we can dig into it?

I'll go ahead and close this, at some point I made a bunch of changes and this started working fine with HMR.

I am experiencing exactly this same issue.

@jackwilliams Mind sharing what changes may have fixed this?

@jackjwilliams Mind sharing what changes might have fixed this?

@chaddjohnson, I wish I knew :/. I reorganized a bunch of stuff and after a few days I happened to notice the error went away.
Sorry!

I will say that at some point I realized that asp.net core 2's HMR was conflicting with my HotModuleReplacementPlugin, so I removed it from my webpack config. I'm not sure if that's what it was, it was just a realization that I came to (that the two plugins are mutually exclusive, not complimentary).

I changed
export default withStyles(styles, {withTheme: true})(Navigation);

to
export default withTheme()(withStyles(styles)(Navigation));

in my component wrapped inside <MuiThemeProvider>, and now I just get a warning.

Using react hot loader v4 (possibly 3), I think this can be solved by moving the MuiThemeProvider one level up. eg
  render(     <MuiThemeProvider theme={theme}>       <App />     </MuiThemeProvider>, document.getElementById('app'))
Then having  be the hot reload root component.

So do I.. now the error log is gone 🙏🏼

I changed

export default withStyles(styles, {withTheme: true})(Navigation);
to
export default withTheme()(withStyles(styles)(Navigation));
in my component wrapped by , and now I just get a warning.

@ilhambrata I was able to get around the problem using
export default withStyles(styles, {withTheme: true})(OrdersPage);
and moving <MuiThemeProvider> up one level outside app.js into index.js. Here is my index.js file:
'use strict';

import React from 'react';
import ReactDOM from 'react-dom';
import {AppContainer} from 'react-hot-loader';
import {Provider} from 'react-redux';
import {MuiThemeProvider} from 'material-ui/styles';
import theme from './theme';
import store from './store';
import App from './app';

const render = (Component) => {
    ReactDOM.render(
        <MuiThemeProvider theme={theme}>
            <Provider store={store}>
                <AppContainer>
                    <Component />
                </AppContainer>
            </Provider>
        </MuiThemeProvider>,
        document.getElementById('root')
    );
};

function bootstrap() {
    // Render the app now that the token is fetched.
    render(App);

    // Initialize hot module reloading.
    if (module.hot) {
        module.hot.accept('./app', () => {
            render(require('./app').default);
        });
    }
}

// Make it so.
bootstrap();

and my app.js file:
'use strict';

import React from 'react';
import {CookiesProvider} from 'react-cookie';
import AppRouter from './components/appRouter';
import Notification from './components/notification';

const App = () => (
    <CookiesProvider>
        <AppRouter />
    </CookiesProvider>
);

export default App;

First of all thanks for the great hints.
I also applied the transition from withStyles(styles)(<my component>) to withTheme()(withStyles(styles)(<my component>)), and it solved my problem completely. Also no warning.
I'm using MuiThemeProvider in my index.js and I did the above change for all "first level" components used there. Further components don't need this, I can change them and the hot-reload works as fine as it did before the issue.

Is there a solution for this if your MuiThemeProvider is wrapped in AppContainer?
I've got an npm package doing Webpack rendering, and I'm simply passing my themed app into the render function which wraps it in AppContainer.
I also tried doing withTheme()(withStyles(styles)(<Component>)) around the first component with styles down the chain and that didn't fix the issue at all for some reason.


Fix Travis CI badge.

It turned out lowercase letters do not work for travois URLs.

Merged, thanks!


redo the PR workflow

validate all packages found (only validating changed files is confusing)
remove the need to do a deep clone
remove the need to get PR labels

'foobar is using a prerlease version and is not yet ready for publishing'
'foobar is using a release version and is ready for publishing'


How to train the model with confidence layer

Hi Marek,
Thanks for your excellent work.
I notice that you add a confidence layer in the FaceAlignment script, but it seems that there isn't a confidence layer in the FaceAlignmentTraining script. How do you manage the landmark loss and the confidence loss?  How can I train the model with the confidence layer?
Thanks.

Hi,
The training code for that layer has not been published so far. The additional layer is trained after the rest of the network has been pre-trained using the FaceAlignmentTraining script. Only the weights of this new layer are modified, while the rest of the weights remain frozen.
We trained the confidence layer using the WIDER dataset. To do so, we extracted a number of image patches containing faces and patches that do not contain faces from the dataset (each face image in the dataset is annotated).
Does that explain a bit? If you have more questions let me know, I will try to answer you quicker next time.
Marek

Hi Marek,
Thanks for your kindly reply. I understand how you train the additional layer. But I still try to find a way to train them together. Do you have any suggestion? Is it a good way to give a weight between landmark loss and the confidence loss and add them up?
Thanks.

Hi,
So just to make sure we understand each other: while we trained the additional layer separately, you would like to train it together with the rest of the network, is that correct?
You would definitely need some sort o a weight between the two errors. Moreover, since the datasets used to train the confidence layer and landmark loss are different (one has landmark annotations, the other doesn't), you would also need your loss function to be able to handle that fact.
Marek

Hi Marek,
It seems a little harder to train the network together with the additional layer than train them separately. Thanks for your suggestion.

Hi Marek,
How can I get the data to train confidence layer ? when I downloaded the WIDER dataset, how can I prepare the training data and labels?
Thanks.

Hi,
The WIDER dataset is available here: http://mmlab.ie.cuhk.edu.hk/projects/WIDERFace/
As explained above the additional layer was trained separately, after all the previous layers were trained on the 300-W dataset. In order to train it we extracted a large number of image patches from the WIDER dataset. The task of the confidence layer was to determine whether a given patch contains a face or not.
Best regards,
Marek

hi，Marek
I want you give me more details about additional layer .
1 what is type the additional layer ?for example ,full connect layer or others.
2 How many layers the additional layer contains? just one or more than one.
3 where should i insert the additional layer in the network,if i train two stages landmark model
Thanks.

Hi,
You can see the definition of the additional layer in line 117 in this file.
It is only a single fully connected layer attached to the penultimate layer of the first stage.
Marek


[Safari] Audio is muted when playback rate is above 2.0

Have you read the FAQ and checked for duplicate open issues?
Yes

did a search for key words: <playbackRate, rate, tempo, trickPlay

If the problem is related to FairPlay, have you read the tutorial?

Yes read the tutorial. Issue is on Safari
What version of Shaka Player are you using?

^4.10.2
Can you reproduce the issue with our latest release version?
The latest version available is 4.10.13 for my company. Tried with that and was able to reproduce the issue
Can you reproduce the issue with the latest code from main?
Yes
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
No I cannot reproduce on demo app
What browser and OS are you using?
Safari - Version 17.6 (196<IP_ADDRESS>.5)
Mac - Sonoma - 14.6.1 (23G93
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?

N/A
What configuration are you using?  What is the output of player.getConfiguration()?

Basically just said - this.player.trickPlay(2.3)
What did you expect to happen?
Playback at 2.3x speed
What actually happened?
The stream goes on but no audio is emitted

I have tried and I cannot reproduce it.

@eshaang2000 @avelad it seems trickplay does not work as intended in src= mode when playback rate is greater than 2. In MSE mode it is fine.

@eshaang2000 @avelad it seems trickplay does not work as intended in src= mode when playback rate is greater than 2. In MSE mode it is fine.

So it's a limitation of Safari and we can't do anything about it, right?

From MDN:

The audio is muted when the fast forward or slow motion is outside a useful range (for example, Gecko mutes the sound outside the range 0.25 to 4.0).

@eshaang2000 @avelad it seems trickplay does not work as intended in src= mode when playback rate is greater than 2. In MSE mode it is fine.

So it's a limitation of Safari and we can't do anything about it, right?

From my testing, I believe so. Interestingly, it seems like this is only a limitation for  elements - I was able to get a  element working with playbackRate > 2. The native HLS player setting on Shaka on Safari doesn't seem to make any difference either (see https://github.com/shaka-project/shaka-player/issues/3346).


Add .to_bytes() to PublicKey, SharedSecret

Added so that x25519_dalek::PublicKey has the same as_bytes/to_bytes fns as ed25519_dalek::PublicKey
Also added .to_bytes() to SharedSecret for consistency.

The CI failure looks like an issue with trying to get assets for the Rust beta build, not failing tests. 🤔

error: could not download file from 'https://static.rust-lang.org/dist/channel-rust-beta.toml.sha256' to '/home/travis/.rustup/tmp/o4an6qqt3qa04cun_file'
info: caused by: failed to make network request
info: caused by: https://static.rust-lang.org/dist/channel-rust-beta.toml.sha256: timed out
The command "curl -sSf https://sh.rustup.rs | sh -s -- --default-toolchain=$TRAVIS_RUST_VERSION -y" failed and exited with 1 during .


WAN throughput

Compared to the Unifi Controller Stats, the WAN throughput differs from Unifi Poller.
WAN Rx shows me 199Mb/s but these are only 90MB/s on my USG3
Why is that? Can anybody help me?

You haven't provided enough information for someone else to accurately deduce why you're having a problem. Can you elaborate and provide screenshots?

Sure, I will try! 😊
I have a gbit network. As you can see in the following screenshot:
Unifi Poller Stats:

WAN RX reaches 199 MB/s
WAN TX 7 MB/s

Compared to UCK stats:

WAN download ca. 80 Mb/s
WAN Upload ca. 30 Mb/s

Please let me know if I can provide more details!

There are gaps in your metric data. Instead of showing you the average of ~100, it's bouncing between 0 and 200 on every other poll. Increase your influxdb interval from 30s to 60s; this will likely smooth out the data and fix the display.

That definitely helped to smooth it out:

But the numbers are still wrong. It must not have been more than 125 MB/s which is the limit for my 1Gbit WAN.
Also, in comparison to measured speed by USG (and battle.net) is a huge gap - the correct download speed should have been around 90 Mb/s, which is not shown in grafana/influx.

From here, it gets more complicated. You need to inspect the data UniFi is giving you from the API and determine if it's accurate. Poller doesn't manipulate the numbers, it just takes them from UniFi and writes them to InfluxDB. This command will produce raw JSON from the controller:
unifi-poller -j d

If you're running in docker you can do it like this:
docker run -it golift/unifi-poller -j d

You will need to provide the config variables that provide access to the controller, or pass -c /path/to/up.conf so it can authenticate to the controller. Run this a few times every minute and inspect the byte differences. You'll have to divide by time to figure out the rate (again, gets complicated).

I am running it from docker and could get the json data. Easiest thing for me is to look at  tx-data because I am backing up my Synology regularly so there is a constant upload stream.
I could find the tx_bytes even though it is pretty messy copying and pasting those date from CLI. For now I just did it for these two:
"tx_bytes":<PHONE_NUMBER>
"rx_bytes":<PHONE_NUMBER>4
Could you give an example what you mean by "You'll have to divide by time to figure out the rate ..."?

Ok, extracted data for about five minutes, tried to hit every 60s:
According to the upload speed shown in the UCK it must be around 20-25 MB/s.

This is from the standard Unifi-Poller: USG Dashboard:

Looks like you're back to 30s. Your controller is not updating the data every 30 seconds, so you need to keep that increased to 60s or so.

Sure, I took the default USG dashboard. But even if I change it to 60s, the numbers are wrong.

UP_INFLUXDB_INTERVAL << yup!

Please re-open this issue if you have additional problems or questions I can help with. Thanks and good luck!


Microsoft Security Advisory CVE-2018-0787: ASP.NET Core Elevation Of Privilege Vulnerability

Microsoft Security Advisory CVE-2018-0787: ASP.NET Core Elevation Of Privilege Vulnerability
Executive summary
Microsoft is releasing this security advisory to provide information about a vulnerability in ASP.NET Core versions 1.0, 1.1 and 2.0. This advisory also provides guidance on what developers can do to update their applications to remove this vulnerability.
Microsoft is aware of a security vulnerability in all public versions of ASP.NET Core where an elevation of privilege vulnerability exists when a ASP.NET Core web application fails to validate web requests correctly.
Announcement
The announcement for this issue can be found at https://github.com/aspnet/Announcements/issues/295
Mitigation factors
Sites are not vulnerable to this elevation of privilege when:

The site is hosted behind a proxy, such as Internet Information Services (IIS), NGINX, or Apache, where:

The proxy validates the host header, and
The proxy is configured to listen on fully qualified domain names or
The proxy is configured with a wildcard subdomain where the root domain is fully controlled by the site owner.

For example, if IIS is configured to respond to requests for contoso.com or *.contoso.com hosts, the application is protected.
If IIS is configured to respond to any request from any host, the application is vulnerable.
Kestrel does not have the capability to validate host headers and is vulnerable if not placed behind a proxy that performs the host header validation.
Apps hosted in Azure Web Apps are not susceptible to this vulnerability.
Affected software
Any ASP.NET Core hosted application which is directly exposed to the internet, or hosted behind a proxy which does not validate or restict host headers to known good values.
The vulnerability also affects any ASP.NET Core 2.0 project if it uses the following package versions, which must also be updated, in addition to addressing your proxy configuration :

Package name
Vulnerable versions
Secure versions

Microsoft.AspNetCore.HttpOverrides
2.0.0, 2.0.1
2.0.2 and later

Microsoft.AspNetCore.Server.Kestrel.Core
2.0.0, 2.0.1
2.0.2 and later

No patches are available for ASP.NET Core 1.0.x or ASP.NET Core 1.1.x. Microsoft requires that you place your 1.x ASP.NET Core application behind a proxy.
You must address the configuration of your proxy to protect your application. If you're not running ASP.NET Core 1.x behind a proxy, you must either place a proxy in front of your application or upgrade to ASP.NET Core 2.0.
and add the host validating middleware provided at https://github.com/aspnet/BasicMiddleware/blob/release/2.0/samples/HostFilteringSample/.
Advisory FAQ
How do I know if I am affected?
Review the server and proxy configuration instructions below to see if your system is configured correctly, and adjust the configuration if necessary.
How do I fix the issue?
You must address the configuration of your server or proxy to protect your application to limit requests to known hosts.
If you're not running Kestrel 1.x behind a proxy, you must either place a proxy in front of your application or upgrade to ASP.NET Core 2.0 and follow the 2.0 instructions below.
ASP.NET Core 2.0.x applications must update your code to fully protect your application.
 Server and Proxy configuration
You must examine your externally facing server or proxy configuration and ensure it requires host headers with fully qualified domain names, or known sub-domains if you are using sub-domain wild cards.
ASP.NET Core applications behind IIS
To configure IIS to only respond to know hosts:

Open IIS Manager.
Expand the Sites node for the machine you want to configure.
Select the site by clicking on the site.
In the Actions list on the right-hand side of IIS Manager, click Bindings.
Edit any bindings that do not have a host name to specify one. Do not use a * wildcard unless it's against a domain under your control. For example, *.contoso.com is safe, *.com is not.

ASP.NET Core applications running publicly on Kestrel
Kestrel does not have the capability to validate host headers. It must either be placed behind a proxy that performs the host header validation or the validation must be performed within the application by adding  host filtering middleware provided at https://github.com/aspnet/BasicMiddleware/blob/release/2.0/samples/HostFilteringSample/. You must also update your dependencies to fully protect your application.
ASP.NET Core applications running on HTTP.SYS
To configure URL prefixes and ports, you can use the UseUrls extension method, the urls command-line argument, the ASPNETCORE_URLS environment variable, or the UrlPrefixes property on HttpSysOptions. The following code example uses UrlPrefixes.
public static IWebHost BuildWebHost(string[] args) =>
    WebHost.CreateDefaultBuilder(args)
        .UseStartup<Startup>()
        .UseHttpSys(options =>
        {
            // The following options are set to default values.
            options.Authentication.Schemes = AuthenticationSchemes.None;
            options.Authentication.AllowAnonymous = true;
            options.MaxConnections = null;
            options.MaxRequestBodySize = 30000000;
            options.UrlPrefixes.Add("http://localhost:5000");
        })
        .Build();

ASP.NET Core applications behind NGINX
To configure NGINX as a reverse proxy to forward requests to your ASP.NET Core app, replace the contents /etc/nginx/sites-available/default with the following:
server {
    listen        80;
    server_name   example.com *.example.com;
    location / {
        proxy_pass         http://localhost:5000;
        proxy_http_version 1.1;
        proxy_set_header   Upgrade $http_upgrade;
        proxy_set_header   Connection keep-alive;
        proxy_set_header   Host $host;
        proxy_cache_bypass $http_upgrade;
    }
}

Note that with NGINX, when there is no match for server_name, NGINX will pick the default server. If no default server has been defined, the first server in the conf file is the default server. Best practice is to add a specific default server which returns a status code of 444 in the conf file. An example default server configuration would be as follows:
server {
    listen   80 default_server;
    # listen [::]:80 default_server deferred;
    return   444;
}

With the preceding configuration file and default server, NGINX accepts public traffic on port 80 with host header example.com or *.example.com. Requests not matching these hosts won't get forwarded to Kestrel. NGINX forwards the matching requests to Kestrel at http://localhost:5000. See How nginx processes a request for more information.
Once the NGINX configuration is established, run sudo nginx -t to verify the syntax of the configuration files. If the configuration file test is successful, force NGINX to pick up the changes by running sudo nginx -s reload.
ASP.NET Core applications behind Apache
Configuration files for Apache are located within the /etc/httpd/conf.d/ directory. Any file with the *.conf* extension:

Is processed in alphabetical order, and
The module configuration files in /etc/httpd/conf.modules.d/ are processed. The module configuration files in /etc/httpd/conf.modules.d/ contain any configuration files necessary to load modules.

<VirtualHost *:80>
    ProxyPreserveHost On
    ProxyPass / http://<IP_ADDRESS>:5000/
    ProxyPassReverse / http://<IP_ADDRESS>:5000/
    ServerName www.example.com
    ServerAlias *.example.com
</VirtualHost>

The VirtualHost block can appear multiple times, in one or more files on a server. In the preceding configuration file, Apache accepts public traffic on port 80. The domain www.example.com is being served, and the *.example.com alias resolves to the same website. See Name-based virtual host support for more information. Requests are proxied at the root to port 5000 of the server at <IP_ADDRESS>. For bi-directional communication, ProxyPass and ProxyPassReverse are required.
Save the file and test the configuration. If everything passes, the response is Syntax [OK].
sudo service httpd configtest

Restart Apache:
sudo systemctl restart httpd
sudo systemctl enable httpd

 ASP.NET Core 2.0 application code updates

If you're targeting .NET Core 2.x and the Microsoft.AspNetCore.All "metapackage":

Update its version number to 2.0.6 or later.
Updating will pull in the fixed packages listed above.

If you're targeting .NET Framework, update the packages listed above to their safe version or later.
If your application is using Kestrel without a proxy or the HttpOverrides functionality (UseForwardedHeaders with ForwardedHost) you must also add the host filtering middleware provided at https://github.com/aspnet/BasicMiddleware/tree/release/2.0/samples/HostFilteringSample/.

.NET Core and ASP.NET Core have two types of dependencies: direct and transitive. You must follow the update instructions below to address both types of dependency.
Direct dependencies
Direct dependencies are dependencies where you specifically add a package to your project. For example, if you add the Microsoft.AspNetCore.Mvc package to your project then you have taken a direct dependency on Microsoft.AspNetCore.Mvc.
Direct dependencies are discoverable by examining your csproj file.
Transitive dependencies
Transitive dependencies occur when you add a package to your project that in turn relies on another package. For example, if you add the Microsoft.AspNetCore.Mvc package to your project it depends on the Microsoft.AspNetCore.Mvc.Core package (among others). Your project has a direct dependency on Microsoft.AspNetCore.Mvc and a transitive dependency on the Microsoft.AspNetCore.Mvc.Core package.
Transitive dependencies are reviewable:

In the Visual Studio Solution Explorer window, which supports searching.
By examining the project.assets.json file contained in the obj directory of your project.

The project.assets.json files are the authoritative list of all packages used by your project, containing both direct and transitive dependencies.
Fixing direct dependencies – Projects targeting .NET Core
Open projectname.csproj in your editor. If you're using Visual Studio, right-click the project and choose Edit projectname.csproj from the content menu, where projectname is the name of your project. Look for PackageReference elements. The following shows an example project file:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.5" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

The preceding example has a reference to the vulnerable metapackage, as seen by the single PackageReference element. The name of the package is in the Include attribute. The package version number is in the Version attribute. The example shows a single direct dependency on Microsoft.AspNetCore.All version 2.0.5.
To update the version to the secure package, change the version number to a secure package version. In this example, update Microsoft.AspNetCore.All to 2.0.6 or later. Save the csproj file. The example csproj now looks as follows:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.6" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

If you're using Visual Studio and save your updated csproj file, Visual Studio will restore the new package version. You can see the restore results by opening the Output window (Ctrl+Alt+O) and changing the Show output from drop-down list to Package Manager.
If you're not using Visual Studio, open a command line and change to your project directory. Execute the dotnet restore command to restore the updated dependencies.
Fixing direct dependencies – Projects targeting .NET Framework
Open projectname.csproj in your editor. If you're using Visual Studio, right-click the project and choose Edit projectname.csproj from the content menu, where projectname is the name of your project. Look for PackageReference nodes. The following shows an example project file:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.HttpOverrides" Version="2.0.1" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

The example has a reference to a single package, as seen by the PackageReference element. The name of the package is in the Include attribute. The package version number is in the Version attribute. The example shows a direct dependency on one of the vulnerable packages from the table above, Microsoft.AspNetCore.HttpOverrides version 2.0.1.
To update to the secure package, change the version number to the updated package version. In the example, this would be updating Microsoft.AspNetCore.HttpOverrides to 2.0.2 and later. Save the csproj file. The updated and secure csproj look as follows:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.HttpOverrides" Version="2.0.2" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

If you're using Visual Studio and save your updated csproj file, Visual Studio will restore the new package version. You can see the restore results by opening the Output window (Ctrl+Alt+O) and changing the Show output from drop-down list to Package Manager.
If you're not using Visual Studio, open a command line and change to your project directory. Execute the dotnet restore command to restore the new dependency version.
After updating your direct dependencies
Recompile your application.
If after recompilation you see a Dependency conflict warning, you must update your other direct dependencies to a compatible version.
For example if your project refers directly to Microsoft.AspNetCore.Mvc.Cors with a version number of 2.0.0, when you update your Microsoft.AspNetCore.Mvc package to 2.0.1, compilation will throw:
NU1012      Dependency conflict. Microsoft.AspNetCore.Mvc 2.0.1 expected Microsoft.AspNetCore.Mvc.Cors >= 2.0.1 but received 2.0.0
To fix this, edit the version for the expected package to be the version expected by updating your project.json in the same way that you used to update the vulnerable package versions.
After you've addressed all of your direct dependencies, you must review your transitive dependencies.
Reviewing transitive dependencies
There are two ways to view transitive dependencies. You can either use Visual Studio’s Solution Explorer, or you can review the project.assets.json file.
Using Visual Studio Solution Explorer
To use Solution Explorer, open the project in Visual Studio 2017, and then press Ctrl+; to activate the search in Solution Explorer. Search for each of the vulnerable package names above and make a note of the version numbers of any results you find.
For example, searching for Microsoft.AspNetCore.Mvc.Core in an example project that contains a package that takes a dependency on Microsoft.AspNetCore.Mvc shows the following results in Visual Studio 2017:

The search results appear as a tree. In these results, you can see a reference to Microsoft.AspNetCore.Mvc.Core version 1.1.2 is discovered.
Under the Dependencies node is a NuGet node. Under the NuGet node is the list of packages you have directly taken a dependency on and their versions. In this example, the application takes a direct dependency on Microsoft.AspNetCore.Mvc. Microsoft.AspNetCore.Mvc in turn has leaf nodes that list its dependencies and their versions. In the example, the Microsoft.AspNetCore.Mvc package takes a dependency on a version of Microsoft.AspNetCore.Mvc.ApiExplorer, that in turn takes a dependency on a vulnerable version of Microsoft.AspNetCore.Mvc.Core.
Manually reviewing project.assets.json (VS2017)
Open the project.assets.json file from your project’s obj directory in your editor. We suggest you use an editor that understands JSON and allows you to collapse and expand nodes to review this file. Visual Studio and Visual Studio Code provide JSON friendly editing.
Search the project.assets.json file for each of the vulnerable packages, using the format packagename/ for each of the package names from the preceding table. If you find the assembly name in your search:

Examine the line on which they are found, the version number is after the /.
Compare to the vulnerable versions table above.

For example, a search result that shows Microsoft.AspNetCore.Mvc.Cors/1.1.0 is a reference to v1.1.0 of Microsoft.AspNetCore.Mvc.Cors.   If your project.assets.json file includes references to any of the vulnerable packages shown above, then you need to fix the transitive dependencies.
Overriding transitive dependencies
If you have not found any reference to any vulnerable packages this means:

None of your direct dependencies depend on any vulnerable packages, or
You have already fixed the problem by updating the direct dependencies.

If your transitive dependency review found references to any of the vulnerable packages you must add a direct dependency to the updated package to your csproj file to override the transitive dependency.
Open projectname.csproj in your editor. If you're using Visual Studio, right-click the project and choose Edit projectname.csproj from the content menu, where projectname is the name of your project. Look for PackageReference nodes, for example:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="ThirdParty.NotUpdatedYet" Version="2.0.0" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

For each of the vulnerable packages your search returned, you must add a direct dependency to the updated version by adding it to the csproj file.
You do this by adding a new line to the dependencies section, referring the fixed version.
For example, if your search showed a transitive reference to the vulnerable Microsoft.AspNetCore.HttpOverrides version 2.0.0 you would add a reference to the fixed version, that is, 2.0.2 or later.
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.HttpOverride" Version="2.0.2" />
    <PackageReference Include="ThirdParty.NotUpdatedYet" Version="2.0.0" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

After you have added the direct dependency reference, save your csproj file.
If you're using Visual Studio, save your updated csproj file and Visual Studio will restore the new package versions.
You can see the restore results by opening the Output window (Ctrl+Alt+O) and changing the Show output from drop-down list to Package Manager.
If you're not using Visual Studio, open a command line and change to your project directory. Execute the dotnet restore command to restore the new dependencies.
Rebuilding your application
Rebuild your application. Test and deploy.
Other Information
Reporting Security Issues
If you have found a potential security issue in .NET Core, please email details to<EMAIL_ADDRESS>Reports may qualify for the .NET Core Bug Bounty. Details of the .NET Core Bug Bounty including terms and conditions are at https://aka.ms/corebounty.
Support
You can ask questions about this issue on GitHub in the .NET Core or ASP.NET Core organizations. These are located at https://github.com/dotnet/ and https://github.com/aspnet/. The Announcements repo for each product (https://github.com/dotnet/Announcements and https://github.com/aspnet/Announcements) will contain this bulletin as an issue and will include a link to a discussion issue. You can ask questions in the discussion issue.
Disclaimer
The information provided in this advisory is provided "as is" without warranty of any kind. Microsoft disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. In no event shall Microsoft Corporation or its suppliers be liable for any damages whatsoever including direct, indirect, incidental, consequential, loss of business profits or special damages, even if Microsoft Corporation or its suppliers have been advised of the possibility of such damages. Some states do not allow the exclusion or limitation of liability for consequential or incidental damages so the foregoing limitation may not apply.
Acknowledgements
Mikhail Shcherbakov
External Links
CVE-2018-0787
Revisions
V1.1 (Mar 15, 2018): NGINX configuration instructions updated, thanks to @buglloc
V1.0 (Mar 13, 2018): Advisory published.
Version 1.1
Last Updated 2018-03-15

Are there any more details on what "fails to validate web requests correctly" means and/or a PoC for this?

No. We don’t publish more details or PoCs. The finder might and we don’t want to take that away from them, nor should you need them to decide to update. EoP should be enough.

I updated to Microsoft.AspNetCore.All, 2.0.6 but when deploying the app to IIS with the 2.0.6 Hosting Bundle installed the app fails with:
Error:
  An assembly specified in the application dependencies manifest (MyApp.deps.json) was not found:
    package: 'Microsoft.AspNetCore.Antiforgery', version: '2.0.2'
    path: 'lib/netstandard2.0/Microsoft.AspNetCore.Antiforgery.dll'

  This assembly was expected to be in the local runtime store as the application was published using the following target manifest files:
    aspnetcore-store-2.0.6.xml

It seems the bundle doesn't contain the updated packages? Do I need to switch to self-contained deploy?

In the example, the Microsoft.AspNetCore.Mvc package takes a dependency on a version of Microsoft.AspNetCore.Mvc.ApiExplorer, that in turn takes a dependency on a vulnerable version of Microsoft.AspNetCore.Mvc.Core

How do you know Microsoft.AspNetCore.Mvc.Core is vulnerable here? I don't see it listed as one of the vulnerable packages at the top of the announcement.

@mshindal that's a generic example to show how transitive dependencies work, not specific to the vulnerable packages here.

There is mention of IIS, nginx, and Apache. Would it be correct to say that apps behind HAProxy would be protected as well?

@akoeplinger there are some known issues with the bundle installer we are addressing. See https://github.com/aspnet/IISIntegration/issues/658#issuecomment-372751438

@Tratcher ok, I thought that specific issue was addressed already since I was able to install the Hosting Bundle and it had the usual ~90MB size. It just doesn't include the updated packages.

Your VS tooling "support" for transitive NuGet references is POOR -- and now very dangerous!

Transitive dependencies are reviewable:
- In the Visual Studio Solution Explorer window, which supports searching.
- By examining the project.assets.json file contained in the obj directory of your project.

Ever looked at a project like OrchardCore? There ist not "the project.assets.json" -- there are 131 of them in the range of 12KB .. 650KB.
That the NuGet update won't handle $(MicrosoftAspNetCoreServerKestrelCorePackageVersion) automatically in a smart way is additional hurdle for the person who has to maintain that file.

I updated to Microsoft.AspNetCore.All, 2.0.6 but when deploying the app to IIS with the 2.0.6 Hosting Bundle installed the app fails with:

@akoeplinger I'll take a look.

@akoeplinger can you try installing the ASP.NET Runtime Core Package Store installer? https://github.com/dotnet/core/blob/master/release-notes/download-archives/2.0.6-download.md#aspnet-runtime-core-package-store. It appears the Windows Server Hosting bundle does not contain the 2.0.6 package store.

Hi all,
As has been noted in this thread, there is a problem with the ASP.NET Core 2.0.6 Windows Server Hosting Bundle. The problem is that it installs an older version of the ASP.NET Core Runtime Store. We are working on a fix for this and expect to have the fixed build out later today. We will post an update here and the link when it is ready.
Current action item: Please don't install the current incorrect ASP.NET Core 2.0.6 Windows Server Hosting Bundle
When we post the update, we will include instructions on how to install the newer build and verify that your machine is correctly configured.
Our apologies for this mistake. We are working to ensure this doesn't happen again.
Thanks,
Eilon

Apps hosted in Azure Web Apps are not susceptible to this vulnerability.

Or those hosted on AWS and behind a load balancer, as they rewrite the Hosts header. Probably the same for GCP load balancers as well, etc, etc.
More general explanation, rather than corporate branding, would have been better here to help those of us (who really like dotnet core but aren't wedded to Azure) to understand the priority of remediating this vulnerability. (And for those that still want to make the fix, that their hostname will be the dns entry for the load balancer and not their equivalent of example.com 🤦♂)
Otherwise, the remediation instructions were very thorough and easy to follow, thanks 👍

To configure NGINX as a reverse proxy to forward requests to your ASP.NET Core app, replace the contents /etc/nginx/sites-available/default with the following:
server {
listen        80;
server_name   example.com *.example.com;
location / {
proxy_pass         http://localhost:5000;
proxy_http_version 1.1;
proxy_set_header   Upgrade $http_upgrade;
proxy_set_header   Connection keep-alive;
proxy_set_header   Host $http_host;
proxy_cache_bypass $http_upgrade;
}
}

I think this nginx configuration are still vulnerable:

simple test config:

server {
    listen       80 default_server;
    server_name  _;
    return 200 "default";
}

server {
    listen        80;
    server_name   example.com *.example.com;
    location / {
        return 200 "'$host' (host) VS '$http_host' (http_host)";
    }
}

test it:

$ nc localhost 80
GET http://example.com/ HTTP/1.0
Host: evil.com

HTTP/1.1 200 OK
Server: nginx/1.12.2
Date: Thu, 15 Mar 2018 07:22:58 GMT
Content-Type: application/octet-stream
Content-Length: 46
Connection: close

'example.com' (host) VS 'evil.com' (http_host)

Please change $http_host to $host variable.

Hi,
Is it possible to configure HttpSys to support wildcard subdomain? i.e.
options.UrlPrefixes.Add("https://*.consoso.com:443");
How about Asp Net Core applications hosted in SF behind ApplicationGateway proxy? Are they susceptible to this vulnerability.

Yes HttpSys has the same support for wildcard subdomains as IIS, it requires Win10/2016.

Most hosters use shared IPs and reverse proxies that require FQDNs and should be protected. If your site has a dedicated public IP then you are more likely to be affected.
We'll confirm SF & AG.

@blowdart , @Eilon - Please have a look at https://github.com/aspnet/Home/issues/2954#issuecomment-373284921

@pranavkm - please validate https://github.com/aspnet/Home/issues/2954#issuecomment-373284921

Is there a new hosting bundle installer link yet?
I thought we were going to use https://aka.ms/dotnetcore-2-windowshosting as a semi-permanent (2.x anyway) link; but at least for the time being, that's still pulling down DotNetCore.2.0.5-WindowsHosting.exe. https://github.com/aspnet/Docs/issues/5688

My previous comment was inaccurate, so deleted. Here is some more info for those wanting to fix the issue and running on AWS. This is AWS specific, so it's slightly off topic perhaps, but hopefully will help someone else!
For anyone running on AWS behind a load balancer (classic or v2), there are some issues to setting up the filtering, whether using NGINX etc. or using the Kestrel middleware.

For proxied requests, the "example.com;*example.com" approach should work, however you'll need to keep this in mind, in the case you receive any HTTP/1.0 traffic (or need to allow for this possibility). For the network load balancer v2, this may not apply.

For HTTP/1.0 requests from clients that do not have a host header, the load balancer generates a host header for the HTTP/1.1 requests sent on the back-end connections. For Application Load Balancer, the host header contains the DNS name of the load balancer. For Classic Load Balancer, the host header contains the IP address of the load balancer node.
documentation

For ELB health checks (classic or v2), the Host header will be set to the IP address of the load balancer node. If you want the health check to hit your application (rather than be responded to by your proxy directly), i.e. be a meaningful application health check, then you have a problem, as you need to add to your host filtering the IP range from which the ELB may send the health check request. There's a 5 year old thread about how this is a problem on AWS.
thread

Workarounds listed in the above thread can be improved by querying the CIDR block for the VPC in which your target group / servers are deployed, as the Host value on health checks (the load balancer node IP) will be within the VPC's CIDR block.
I'm working on modifying the suggested Kestrel middleware to also handle IP range whitelisting, will link when it's done.

@akotranza there's some CIDR IP range logic in HttpOverrides you can borrow: https://github.com/aspnet/BasicMiddleware/blob/8b58a9a0917315cef4aac6d0ffb44144d9df9bf1/src/Microsoft.AspNetCore.HttpOverrides/ForwardedHeadersOptions.cs#L68
https://github.com/aspnet/BasicMiddleware/blob/8b58a9a0917315cef4aac6d0ffb44144d9df9bf1/src/Microsoft.AspNetCore.HttpOverrides/IPNetwork.cs

@blowdart using $host is the right thing to do. Thanks for the detailed instructions @buglloc

@Rick-Anderson Update needed for config docs for NGINX

@buglloc Issue updated both here and in announcements, thank you.

@blowdart thanks!

From @preetikr in https://github.com/dotnet/core/issues/1341#issuecomment-373508095:

Thanks, for your patience on this.  The issue with the DotNetCore 2.0.6 Hosting bundle is now resolved and you can download the updated file from here. Please note as part of the refresh we have changed the file name from DotNetCore.2.0.6-WindowsHosting.exe to DotNetCore.2.0.6-1-WindowsHosting.exe.

@Eilon The link here to "Server Hosting Installer" is broken: https://www.microsoft.com/net/download/dotnet-core/runtime-2.0.6
Also, I understand the link is in the Windows section, but it might be a little better if the link text match the docs (at least match better than it does now).
Suggestions:

Windows Server Hosting Installer
Windows Server Hosting Bundle
Windows Server Hosting Bundle Installer

In the docs, we call it the ".NET Core Windows Server Hosting bundle."
... and on a broader note: This installer (and the hosting bundle) aren't really 100% "Windows Server," per se. This install works on Windows desktop. I wonder if down the road you might consider renaming it to just "Windows Hosting bundle," "Windows Hosting Installer," or anything really that removes the word "server" from the name.
I'd also like to mention the confusion that devs have about this installer. I recommend an info popup. See: https://github.com/aspnet/Docs/issues/5505

@guardrex thanks for pointing this out.
@leecow / @preetikr - can you take a look at the broken download link on https://www.microsoft.com/net/download/dotnet-core/runtime-2.0.6 that points to https://download.microsoft.com/download/8/D/A/8DA04DA7-565B-4372-BBCE-D44C7809A467/DotNetCore.2.0.6-WindowsHosting.exe (not found)?

@rowanmiller - releases.json has the correct, updated, filename. Can you see why the Server Hosting Installer link on https://www.microsoft.com/net/download/dotnet-core/runtime-2.0.6 is resolving to DotNetCore.2.0.6-WindowsHosting.exe rather than DotNetCore.2.0.6-1-WindowsHosting.exe?

Merged the latest version of the release metadata file into the website, and the download is working now. We keep a separate copy of the file for various reasons.

Thanks @rowanmiller and @leecow , the link seems to work for me now!

@akotranza I wanted to hear your thoughts about ALBs specifically.
If one is forwarding requests with a  subdomain "subdomain.example.com", all other requests fall into a target that is not pointed to any applications and there is no other method to access the application except through the ALB at the specified subdomain is the Kestrel middleware still needed?

@JustinPullen Judging by how that AWS says they've implemented host-based routing for their ALBs

rules that route incoming traffic based on the domain name specified in the Host header

and assuming your application instances are in a private subnet and incoming traffic is locked down to that from the ALB, I would lean towards the host filtering middleware being redundant.
Thanks for asking this, now I'm thinking that a quicker mitigation for our services that use path-based routing might be to use a combo of host- and path-based 😄

asp.net core app works fine locally, but displays the following when trying to publish to Azure:
...\obj\project.assets.json' doesn't have a target for '.NETCoreApp,Version=v2.0'. Ensure that restore has run and that you have included 'netcoreapp2.0' in the TargetFrameworks for your project.	RellafitWeb2		0
project.assets.json includes
"frameworks": {
  "netcoreapp2.0": {
    "dependencies": {
      "Microsoft.AspNetCore.All": {
        "target": "Package",
        "version": "[2.0.6, )"
      },

what am I missing here?

@Tratcher thanks for the references. I've added IPv4 CIDR format to allowed hosts in the mitigation's referenced middleware sample in one of my codebases with success. The relevant cs file seems to be missing from the BasicMiddleware repo in dev and newer release branches, so I threw it in a gist for now https://gist.github.com/akotranza/8d6539ac378087ac703dde3ec6b74308

It's a package now in 2.1 https://github.com/aspnet/BasicMiddleware/blob/dev/src/Microsoft.AspNetCore.HostFiltering/HostFilteringMiddleware.cs
I don't think we'd build in advanced IP filtering at this point, it seems uncommon to build public urls with them. I could understand if you were using them in your load balancer, but I'd expect it to be combine with something like x-forwarded-host for the public value.

I'd expect it to be combine with something like x-forwarded-host for the public value.

That would certainly make sense!
Fwiw, I've not yet seen the behavior described in the AWS forum threads I referenced. For our applications, load balancer health checks seem to consistently use the IP of the instance, which is easily handled by the existing middleware. But I haven't tested extensively, so it was worth the few hours of digging around to detect and handle that edge case if it occurs.

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


collect markers?

Hi,
First, great work on this plugin. We were using an older xml format and this has made things way nicer.
I am looking for a way to add markers of each node into the report. Right now I have implemented this like so:
def pytest_sessionfinish(session):
    """
    A hook called after running all tests and collecting results.
    """
    # Bail out early if we aren't generating the json report.
    if not session.config.getoption('json_report'):
        return
    # get the json report and add a dict of {marker_name: [node, ...]}
    report = session.config._json_report.report
    out = collections.defaultdict(list)
    for item in session.items:
        for marker in item.iter_markers():
            out[marker.name].append(item.nodeid)
    report['markers'] = dict(out)

but there is probably a better way. For me, it is important to collect markers for all tests, even the skipped ones. Would adding something about markers to the default output be worthwhile?

Ah, never mind. I see the markers are contained in the keywords of the test items. That is probably good enough.

Unless I had overlooked it back then, historically a node's markers were only provided as strings within the list of keywords.
Now that they are available as separate structures and easily iterable, there is a strong case for providing an explicit markers key in the JSON report. So thanks for pointing that out!