Add new api-version 2024-02-01-preview to main

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/azp run

Please tell me why the typespec validation is failing
npx tsv .\specification\azurestackhci\AzureStackHCI.StackHCIVM.Management\
Running TypeSpecValidation on folder:  C:/azure-rest-api-specs/specification/azurestackhci/AzureStackHCI.StackHCIVM.Management

Executing rule: FolderStructure
folder: C:/azure-rest-api-specs/specification/azurestackhci/AzureStackHCI.StackHCIVM.Management
config files: ["C:/azure-rest-api-specs/specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml"]

Executing rule: NpmPrefix
run command:npm prefix
Expected npm prefix: C:/azure-rest-api-specs
Actual npm prefix: C:/azure-rest-api-specs

Executing rule: EmitAutorest
mainTspExists: true
emit: ["@azure-tools/typespec-autorest"]

Executing rule: FlavorAzure

Executing rule: LinterRuleset
azure-resource-provider-folder: "resource-manager"
files: ["main.tsp"]
linter.extends: ["@azure-tools/typespec-azure-resource-manager/all","@azure-tools/typespec-azure-rulesets/resource-manager"]

Executing rule: Compile
run command:npm exec --no -- tsp compile . --warn-as-error
TypeSpec compiler v0.56.0

Compilation completed successfully.

Running git diff on folder C:/azure-rest-api-specs/specification/azurestackhci
Rule Compile failed
{"not_added":[],"conflicted":[],"created":[],"deleted":[],"modified":["specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml","specification/azurestackhci/Operations.Management/tspconfig.yaml"],"renamed":[],"files":[{"path":"specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml","index":" ","working_dir":"M"},{"path":"specification/azurestackhci/Operations.Management/tspconfig.yaml","index":" ","working_dir":"M"}],"staged":[],"ahead":0,"behind":0,"current":"main","tracking":"origin/main","detached":false}diff --git a/specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml b/specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml
index 59fbbdd98f..30955a51e4 100644
--- a/specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml
+++ b/specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml
@@ -10,3 +10,4 @@ options:
 linter:
   extends:
     - "@azure-tools/typespec-azure-resource-manager/all"
+    - "@azure-tools/typespec-azure-rulesets/resource-manager"
diff --git a/specification/azurestackhci/Operations.Management/tspconfig.yaml b/specification/azurestackhci/Operations.Management/tspconfig.yaml
index 59791f3aae..d2c78b83a9 100644
--- a/specification/azurestackhci/Operations.Management/tspconfig.yaml
+++ b/specification/azurestackhci/Operations.Management/tspconfig.yaml
@@ -10,3 +10,4 @@ options:
 linter:
   extends:
     - "@azure-tools/typespec-azure-resource-manager/all"
+    - "@azure-tools/typespec-azure-rulesets/resource-manager"

Files have been changed after `tsp compile`. Run `tsp compile` and ensure all files are included in your change.

@shraddhasun Regarding the TypeSpec validation failures, you can take a look at the lines right above the red error line. https://dev.azure.com/azure-sdk/public/_build/results?buildId=3827382&view=logs&j=011e1ec8-6569-5e69-4f06-baf193d1351e&t=0f4aa080-c997-58ca-481c-4930865ae0f8&l=376
Rule LinterRuleset failed
tspconfig.yaml must define the following property:

linter:
  extends:
    - "@azure-tools/typespec-azure-rulesets/resource-manager"

/azp run

Is there a base commit that I can compare to? The file specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/preview/2024-02-01-preview/stackhcivm.json shows up as a brand new file. Is everything in the file new to this PR?

Is there a base commit that I can compare to? The file specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/preview/2024-02-01-preview/stackhcivm.json shows up as a brand new file. Is everything in the file new to this PR?

Its our first api-version in typespec. That file has been generated by typespec. Previously, we had different files for each resource.
So, its hard to show the difff here.
This api-version has already been added to RPSaaSMaster
https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/azurestackhci/resource-manager/Microsoft.AzureStackHCI/StackHCIVM/preview/2024-02-01-preview/stackhcivm.json

The changes in this PR are the exact same as the RPSaaSMaster PR.


License ?

Hello, under what license is this project released under ? I would like to study it to learn from it. Thank you.

MIT license, do whatever you want with it :)


Rounding issue on tokens (TX rendering)

The current notification

should not have the qADA 0.00.
Check the original TX: https://cexplorer.io/tx/4e00fca28aaa0c5a3907290ee5f94d4c265f0f5e950585b3627d64018b5633df
Eternl shows it as following

Another example:

TX https://cexplorer.io/tx/6ad2da8864edf66da2090de526a9c8851c41331c319896ba6d65c7a2278ecba6


Fresh install migrate fails on Laravel 5.8

Expected Behavior
Initial migration or fresh migration succeeds without errors.
Current Behavior
Initial or fresh migration fails due to an error creating a foreign key. Same behaviour as described in prior bug report https://github.com/osiset/laravel-shopify/issues/419
Failure Information
Failure is due to Laravel 5.8 changing the user_id column type to bigIncrements. Version check implemented as fix for https://github.com/osiset/laravel-shopify/issues/419 incorrectly excludes Laravel 5.8 from the updated column type.
Steps to Reproduce
Migrate on a fresh install of Laravel 5.8.*.

Package Version: v11.3
Laravel Version: v5.8
PHP Version: v7.2

Raised PR https://github.com/osiset/laravel-shopify/pull/449 to address this issue.

Done, thanks, will be in tonights release.


Add GH workflow for fornightly release on every 1&3 Friday at 09:30 hrs

.... is this PR status as WIP Don't merge or we are ready to merge it? @rootfs / @husky-parul ?

I forgot to remove the labels. Since it was approved I merged it. Did you have any comments? I can incorporate them in another PR. LMK. Thanks

is this pr works for rpm and SBOM? I am interested with the question.

is this pr works for rpm and SBOM? I am interested with the question.
@SamYuan1990 The PR will create the following release artifacts

kepler-rpm
sbom file
Source code as zip and
Source code as tar.gz
pushes two images in the quay with tags latest and <release-version>

The naming convention for release version is as follows:
fornightly-$(date +'%Y-%m-%d')

Please note we are not creating release branches for fortnightly. Only release and tags

is this pr works for rpm and SBOM? I am interested with the question.
@SamYuan1990 The PR will create the following release artifacts

kepler-rpm
sbom file
Source code as zip and
Source code as tar.gz
pushes two images in the quay with tags latest and <release-version>

The naming convention for release version is as follows:
fornightly-$(date +'%Y-%m-%d')

Please note we are not creating release branches for fortnightly. Only release and tags

could you please share me a link to check those files?
https://github.com/sustainable-computing-io/kepler/releases ?

is this pr works for rpm and SBOM? I am interested with the question.
@SamYuan1990 The PR will create the following release artifacts

kepler-rpm
sbom file
Source code as zip and
Source code as tar.gz
pushes two images in the quay with tags latest and <release-version>

The naming convention for release version is as follows:
fornightly-$(date +'%Y-%m-%d')

Please note we are not creating release branches for fortnightly. Only release and tags

could you please share me a link to check those files? https://github.com/sustainable-computing-io/kepler/releases ?

This workflow was never run so no resources have been created by the workflow yet but it would be similar to this
https://github.com/sustainable-computing-io/kepler/releases/tag/v0.5.1

is this pr works for rpm and SBOM? I am interested with the question.
@SamYuan1990 The PR will create the following release artifacts

kepler-rpm
sbom file
Source code as zip and
Source code as tar.gz
pushes two images in the quay with tags latest and <release-version>

The naming convention for release version is as follows:
fornightly-$(date +'%Y-%m-%d')

Please note we are not creating release branches for fortnightly. Only release and tags

could you please share me a link to check those files? https://github.com/sustainable-computing-io/kepler/releases ?

This workflow was never run so no resources have been created by the workflow yet but it would be similar to this https://github.com/sustainable-computing-io/kepler/releases/tag/v0.5.1

yea... that's where I wanna to confirm and figure out.

for container image, as we can re tag latest and push, hence this PR as fornightly works.
for release page. we could not over write  https://github.com/sustainable-computing-io/kepler/releases/tag/v0.5.1
further I assume for the 1st time running, it will create a new release page with name as latest?
for the 2nd time and next running, it will re create the page or just update it?

@husky-parul , or if the release page is just timestamp, then I would like to hold this PR by revert. as I am not sure what's our version/release management? cc: @rootfs
I suppose that related one or many of OpenSSF questions as release management.

@rootfs to be clear using pre-release for fornightly implies that we will keep refreshing the pre-release page on github and quay image for fornightly build? Also does it mean that fornightly will not create latest image tag for quay.io ?

@husky-parul yes. Let's have more discussions in the meeting tomorrow.


Query: fix streamSeriesSet defer in for loop

Defer in for loop will lead too many timer in heap.
here is the pprof log:
[*]* ./go tool pprof  *:19192/debug/pprof/heap
Fetching profile over HTTP from http://*:19192/debug/pprof/heap
Saved profile in *pprof.thanos.alloc_objects.alloc_space.inuse_objects.inuse_space.011.pb.gz
File: thanos
Type: inuse_space
Time: Nov 3, 2021 at 2:41pm (CST)
Entering interactive mode (type "help" for commands, "o" for options)
(pprof) top10
Showing nodes accounting for 153.80MB, 84.79% of 181.38MB total
Dropped 76 nodes (cum <= 0.91MB)
Showing top 10 nodes out of 111
      flat  flat%   sum%        cum   cum%
   50.52MB 27.85% 27.85%    54.52MB 30.06%  github.com/thanos-io/thanos/pkg/store/storepb.(*Series).Unmarshal
   36.01MB 19.86% 47.71%    36.01MB 19.86%  google.golang.org/grpc.(*parser).recvMsg
   17.72MB  9.77% 57.48%    17.72MB  9.77%  time.goFunc
   11.38MB  6.28% 63.75%    11.38MB  6.28%  time.startTimer
    8.51MB  4.69% 68.45%     8.51MB  4.69%  google.golang.org/grpc/internal/transport.newBufWriter
    6.83MB  3.77% 72.21%    23.48MB 12.95%  github.com/prometheus/prometheus/promql.(*evaluator).rangeEval
    6.50MB  3.58% 75.79%     6.50MB  3.58%  github.com/thanos-io/thanos/pkg/query.newChunkSeries (inline)
    6.01MB  3.31% 79.11%     6.01MB  3.31%  bytes.makeSlice
    5.16MB  2.84% 81.95%     5.16MB  2.84%  bufio.NewReaderSize
    5.16MB  2.84% 84.79%     5.16MB  2.84%  github.com/thanos-io/thanos/pkg/query.(*seriesServer).Send
(pprof) traces time.startTimer
File: thanos
Type: inuse_space
Time: Nov 3, 2021 at 2:41pm (CST)
-----------+-------------------------------------------------------
     bytes:  2.84MB
   11.38MB   time.startTimer
             time.AfterFunc
             context.WithDeadline
             context.WithTimeout
             github.com/thanos-io/thanos/pkg/store.frameCtx
             github.com/thanos-io/thanos/pkg/store.startStreamSeriesSet.func1
-----------+-------------------------------------------------------
     bytes:  2.27MB
         0   time.startTimer
             time.AfterFunc
             context.WithDeadline
             context.WithTimeout
             github.com/thanos-io/thanos/pkg/store.frameCtx
             github.com/thanos-io/thanos/pkg/store.startStreamSeriesSet.func1

Signed-off-by: Jimmiehan<EMAIL_ADDRESS>

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes

Make it as function. so the timer will be released in every loop.
Verification

Unit test.
Deploy and pprof again, the time.startTimer has disappeared.

What about the benchmarks? What improvement do they show? 🤔

the defer only exec on function return, if we put the defer cancel in for loop, then the timer created by context only released on function return, which lead too many timer. so the common best practise is use a func in for loop.
ref: https://golang.org/ref/spec#Defer_statements https://stackoverflow.com/questions/45617758/defer-in-the-loop-what-will-be-better
ok, let me add a benchmark.🤔

Hi @GiedriusS , I  make a benchmark. Do i need to add it to proxy_test.go? 😄
// BenchmarkFrameCtxDeferLoop benchmark defer in for loop (#4830).
// go test -bench FrameCtxDefer -run FrameCtxDefer -v
func BenchmarkFrameCtxDeferLoop(b *testing.B) {
	b.ReportAllocs()
	b.RunParallel(func(pb *testing.PB) {
		for pb.Next() {
			for j := 0; j < 1000; j++ {
				_, cancel := frameCtx(time.Second * 5)
				defer cancel()
			}
		}
	})
}

// BenchmarkFrameCtxDeferFunc benchmark defer func in for loop (#4830).
func BenchmarkFrameCtxDeferFunc(b *testing.B) {
	b.ReportAllocs()
	b.RunParallel(func(pb *testing.PB) {
		for pb.Next() {
			for j := 0; j < 1000; j++ {
				func() {
					_, cancel := frameCtx(time.Second * 5)
					defer cancel()
				}()
			}
		}
	})
}

$ go test -bench FrameCtxDefer -run FrameCtxDefer -v
goos: darwin
goarch: amd64
pkg: github.com/thanos-io/thanos/pkg/store
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkFrameCtxDeferLoop
BenchmarkFrameCtxDeferLoop-12               4972            246576 ns/op          332064 B/op       4998 allocs/op
BenchmarkFrameCtxDeferFunc
BenchmarkFrameCtxDeferFunc-12              12950             87979 ns/op          208000 B/op       4000 allocs/op
PASS
ok      github.com/thanos-io/thanos/pkg/store   4.783s

Thank you! BenchmarkProxySeries shows the following improvements:
name                                                                                old time/op    new time/op    delta
ProxySeries/1000000SeriesWith1Samples/4_client_with_1_samples,_250000_series_each-16        1.05s ± 5%     1.00s ± 6%   -4.46%  (p=0.005 n=10+10)
ProxySeries/1000000SeriesWith1Samples/single_client_with_1_samples,_1000000_series-16       1.09s ± 5%     0.94s ± 2%  -14.33%  (p=0.000 n=10+9)
ProxySeries/100000SeriesWith100Samples/4_client_with_25_samples,_25000_series_each-16       106ms ± 3%     100ms ± 7%   -6.18%  (p=0.000 n=10+10)
ProxySeries/100000SeriesWith100Samples/single_client_with_100_samples,_100000_series-16     107ms ± 5%      94ms ± 3%  -12.68%  (p=0.000 n=9+9)
ProxySeries/1SeriesWith10000000Samples/4_client_with_2500000_samples,_1_series_each-16     40.8µs ± 3%    40.4µs ± 4%     ~     (p=0.278 n=10+9)
ProxySeries/1SeriesWith10000000Samples/single_client_with_10000000_samples,_1_series-16    24.4µs ± 5%    23.7µs ± 2%     ~     (p=0.133 n=10+7)

name                                                                                old alloc/op   new alloc/op   delta
ProxySeries/1000000SeriesWith1Samples/4_client_with_1_samples,_250000_series_each-16        213MB ± 0%     189MB ± 0%  -11.14%  (p=0.000 n=9+9)
ProxySeries/1000000SeriesWith1Samples/single_client_with_1_samples,_1000000_series-16       269MB ± 0%     189MB ± 0%  -29.72%  (p=0.000 n=10+9)
ProxySeries/100000SeriesWith100Samples/4_client_with_25_samples,_25000_series_each-16      19.9MB ± 1%    19.1MB ± 0%   -4.10%  (p=0.000 n=8+10)
ProxySeries/100000SeriesWith100Samples/single_client_with_100_samples,_100000_series-16    22.5MB ± 2%    19.1MB ± 0%  -15.44%  (p=0.000 n=10+10)
ProxySeries/1SeriesWith10000000Samples/4_client_with_2500000_samples,_1_series_each-16     10.8kB ± 0%    10.8kB ± 0%     ~     (all equal)
ProxySeries/1SeriesWith10000000Samples/single_client_with_10000000_samples,_1_series-16    5.02kB ± 0%    5.02kB ± 0%     ~     (all equal)

name                                                                                old allocs/op  new allocs/op  delta
ProxySeries/1000000SeriesWith1Samples/4_client_with_1_samples,_250000_series_each-16        5.30M ± 0%     5.00M ± 0%   -5.60%  (p=0.000 n=9+9)
ProxySeries/1000000SeriesWith1Samples/single_client_with_1_samples,_1000000_series-16       6.00M ± 0%     5.00M ± 0%  -16.67%  (p=0.000 n=10+9)
ProxySeries/100000SeriesWith100Samples/4_client_with_25_samples,_25000_series_each-16        510k ± 0%      500k ± 0%   -2.00%  (p=0.000 n=8+10)
ProxySeries/100000SeriesWith100Samples/single_client_with_100_samples,_100000_series-16      544k ± 1%      500k ± 0%   -8.00%  (p=0.000 n=10+10)
ProxySeries/1SeriesWith10000000Samples/4_client_with_2500000_samples,_1_series_each-16        177 ± 0%       177 ± 0%     ~     (all equal)
ProxySeries/1SeriesWith10000000Samples/single_client_with_10000000_samples,_1_series-16       106 ± 0%       106 ± 0%     ~     (all equal)


⚠ Spryr has degraded performance

In 0f389bc, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5874 ms

Resolved: Spryr performance has improved in 5a022c5 after 7 minutes.


sorairolake/lzip-go repo no longer exists

This is more of an FYI than a bug, as I see this repo is used for the lzip implementation.
It appears that https://github.com/sorairolake/lzip-go no longer exists. Apparently, it's preventing people who don't have a cached version of the code from building projects.
Cross-posted from https://github.com/trufflesecurity/trufflehog/issues/3227

Weird.
The Go module proxy still has it cached. I have a copy of the latest on my machine as well.
Is there another lzma lib that works? I tried github.com/ulikunitz/xz/lzma real quick but the tests fail because there isn't a prefix starting with "LZMA" which the spec requires. So I dunno if it's something else, or :shrug:

I went ahead and published my copy of it and this project now refers to it.
(I do not intend to maintain it though.)

FWIW that repo is restored. So you can probably switch back to it.


Run through the code base and create tickets for any TODO items

There are some TODOs listed in the code base that don't have corresponding tickets in the issues. Run through and create a ticket for them here. Pick up any you would like to complete.

Hi, I am new in the open-source,
can you please tell exactly what needs to be done.
My understanding of issue :
Make github hook to check code after each commit to master,
search for # Todo , in code base and and open a github ticket for that issue.

@hemantjadon I am seeing this super late, which I am sorry for. But yes. You understand exactly.

Seems this ticket is still open. @designfrontier  is there anything done for this already? If not I'm happy to contribute for this.

Hi @designfrontier, can I give this one a go? :)

Sure thing. Post any tickets you open in a comment here!

On Jun 27, 2017, at 3:35 PM, Chadapohn Chaosrikul<EMAIL_ADDRESS>wrote:
Hi @designfrontier, can I give this one a go? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

All todos are gone


:/

Cant open file, how can i fix this?

Any context?
how do you expect anyone to help you without giving any screenshots, output, errors?


issue #313

@Amisha-here Please use the PR template, I can't understand what your PR is willing to do?
Also resolve the merge conflicts


{CI} Update [Microsoft Internal / Service Team] Feature Request template

If user creates a feature request with the template([Microsoft Internal / Service Team] Feature Request), automatically add the label feature-request.
Modify Swagger PR link to Swagger PR link / SDK link.
Add If you cannot provide, please fill in N/A. to description.

CI


Please add statement indicating Microsoft.Sql Service Endpoint is not applicable to non-primary regions of API Management

In the forced tunnelling section, it states we can solve forced tunneling for Azure SQL using the Azure SQL service endpoint. At this time, this is true if the API Management service has a single location. However, if API Management has multiple locations, the Microsoft.Sql service endpoint will not apply to cross regional Azure SQL traffic. This means Azure SQL traffic from the non-main region would still go through the forced tunnel, even with the Microsoft.Sql service endpoint. This is documented in the Service Endpoints documentation: Virtual Network Service Endpoints Overview:

For Azure SQL Database, virtual networks must be in the same region as the Azure service resource.

As it is stated in the following document: How to deploy an Azure API Management service instance to multiple Azure regions:

Only the gateway component of API Management is deployed to all regions.

This means that the Azure SQL dependency is not deployed to the non-primary regions, which may cause a slight conflict with the statement in the forced tunneling section.
Please message me or reply to the incident if more information if needed. I can setup a repro to show this scenario.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbd2c349-f9a7-d43e-ab97-675b9fe3e809
Version Independent ID: 997f977d-978c-541f-cc03-d47412998c73
Content: VNet configuration settings
Content Source: articles/api-management/virtual-network-reference.md
Service: api-management
GitHub Login: @dlepow
Microsoft Alias: danlep

@milope - Thanks for raising this issue. I can adjust the doc to point out that the SQL service endpoint is only needed in the primary region, in the case of a multi-region deployment (is that the correct way to put it?). Can you also please look at the other service endpoints listed there and let me know if there are additional exceptions like this? Thank you!

@dlepow  So far and at this time, it seems Azure SQL and AAD when combined with ADLS Gen1 are the only resources with call outs. ADLS Gen 1 doesn't apply to API Management, which would only leave Azure SQL from the API Management perspective. I can setup a repro, but past experiences with customers have led us to observe this behavior only with Azure SQL.

Thanks for the info - I'll update the doc
#assign @dlepow

I updated the doc, so I'll close this issue. Thanks for pointing it out.
#please-close


Call moveToScreen right before showFullScreen for Wayland

Call moveToScreen right before showFullScreen for Wayland 196

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


murmur don't include the license file

Not available LICENSE file in source directory structure
Please. Added license and copyright notice.
the fedora pakaging guideline is very strictly precise about this problem
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text
thanks
regards

Sorry for the noise

license file should be http://www.apache.org/licenses/LICENSE-2.0.txt

Added license file.


Computed property that also relies on another computed property?

Is it possible to have a computed property that relies on a regular state property and also another computed property? It seems like I'm able to access it just fine, but it's the previous value.
Here's a minimal reproducible example:
https://codesandbox.io/s/zustand-computed-chained-6fg57x?file=/src/index.ts
I suppose it opens up a can of worms for order of operations and weird cyclic/non-linear things (if we were to think of variable dependencies as a graph). But, for example, Vue computed enables you to do this type of computed "chaining". I'm not sure how it handles the messiness though.
Is there a way you recommend to handle this type of situation with your middleware?

That's interesting! In this case I would extract out your computed values into local variables inside the computed function before putting it back together. It is possible to listen for which variables are read from the passed-in State object via Proxy, and is may be possible to unravel the state graph and resolve cases of recursive dependency (maybe by using the previous value instead of requiring new computation), but that seems somewhat messy and fraught with assumptions.
An alternative I'm considering is passing multiple "computed" functions. If you have state A, B, C, and A is
{ value: number }, B is { squared: number }, and C is { cubed: number }, you could have two functions that calculate A -> B and A&B -> C. In this small example, that may not read as nicely, or be necessary, but I can see complex state trees that may benefit from use of separate computed function (in case one is expensive and not always needed to be run).
I'll think on this, on honeymoon at the moment though 😁

At the moment, the simplest thing is to store any values that are part of the "computed" portion as variables within the function, and not rely on references all the way through. You may also want to split your state definitions into "State" and "ComputedState" as some of the examples show. This way, within the compute function, values like state.doubled should not exist on type State, but will exist coming out of the store.
This is the best way to do it for a function that's called every time. I could see building a dependency tree as a further way to deal with multiple relationships (some with more expense computations) but that isn't an immediate term thing.


Updating network rules restrictions on storage account resource block

Describe your changes
Add network rules dynamic block within storage account resource
remove azurerm_storage_account_network_rules resource block
update examples with default deny rules
Issue number
#41
Checklist before requesting a review

[ ] The pr title can be used to describe what this pr did in CHANGELOG.md file
[ ] I have executed pre-commit on my machine
[ ] I have passed pr-check on my machine

Thanks for your cooperation!

this makes sense - as discussed with @chinthakaru I feel the nested option should be the default, given this will be a common pattern faced when using typical Azure Policy baselines.
i think it makes sense to keep the other optional available (as the non-default option) - I'm aware of at least one scenario where this is required to avoid a circular dependency - with machine learning workspaces, you end up passing in an existing storage account, and then need to use the separate network rules block to secure it.  These are niche cases though, in my experience.


Remote cluster log stream failed error

Failed to get stream logs pods

The target cluster log stream failed when we wanted to see it on Velaux instead of the pod existing on the target cluster; however we are able to see local cluster application pod.
To Reproduce

velad install
join target cluster
deploy a simple application to target cluster
check pod logs on velaux

Api server
Api server log example:
W0109 14:32:11.615721       1 handler.go:288] failed to get stream logs pods "test-app-5bf8977896-rnbgc" not found

Expected behavior

Screenshots
Target cluster pod log example

Local cluster pod log example

KubeVela Version
1.6.4
Cluster information
Target cluster 1.20.7

https://github.com/kubevela/kubevela/issues/5264 duplicated


Deduped packages in npm tree after running npm install

I am seeing a lot of packages which are duplicates after I run npm install.
Screenshot:

Attaching a the npm list output in a json file.
npmlist.json.zip

DedupePlugin isn't available in webpack2. How are we going to handle this?

@reznord is there any problem with it tough? Those are all dev dependencies and bundle doesn't contain duplicated dependencies.

Not a problem, but contributors generally think that there is something
wrong (talking about people who don't know about this)
On Tue, Jun 27, 2017, 11:56 PM Rafał Kostrzewski<EMAIL_ADDRESS>wrote:

@reznord https://github.com/reznord is there any problem with it tough?
Those are all dev dependencies and bundle doesn't contain duplicated
dependencies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/developit/preact-cli/issues/138#issuecomment-311444044,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADQdwFOeIPlTPffTDUrS9McoQAkErWehks5sIUk6gaJpZM4OE72e
.

--
Regards,
Anup https://anup07.wordpress.com/

npm skips duplicates so those aren't actually on-disk, just symlinks.  I'd love to explore bundling in dependencies though, just to speed up installations.

Isn't this a node/npm issue right? Why do we have to take care of it?

It's an npm issue yeah.  In the latest preact-cli we now give preference to $CWD/node_modules, which should address any preact-cli issue arising from this.

In the latest preact-cli we now give preference to $CWD/node_modules, which should address any preact-cli issue arising from this

Cool !! Thanks for the clarification.


Rails 5 API: undefined method `helper_method'

Attempting use action_access in a Rails 5 app that is using using rails api I receive the following:
NoMethodError: undefined method `helper_method' for ActionController::API:Class
  /Users/griley/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/action_access-0.1.1/lib/action_access/controller_additions.rb:51:in `included'

This is the same issue that the devise gem encountered.

Looks like they solved it by simply wrapping the call with a responds_to? method

following up on this thread. I'm currently experience the same isdue in combination with the audited gem. I've found a similar issue with them but am currently kind a stuck.
Would be great if you can take a look at it.
the Issue I found is this one: https://github.com/activescaffold/active_scaffold/commit/70a11454ee6e74290fd92b075e92dc7d8fac6c3b
and this is stack trace
/home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/action_access-0.1.1/lib/action_access/controller_additions.rb:51:in `included': undefined method `helper_method' for ActionController::API:Class (NoMethodError)
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/action_access-0.1.1/lib/action_access/railtie.rb:8:in `include'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/action_access-0.1.1/lib/action_access/railtie.rb:8:in `block (2 levels) in <class:Railtie>'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/lazy_load_hooks.rb:43:in `instance_eval'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/lazy_load_hooks.rb:43:in `execute_hook'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/lazy_load_hooks.rb:33:in `block in on_load'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/lazy_load_hooks.rb:32:in `each'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/lazy_load_hooks.rb:32:in `on_load'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/action_access-0.1.1/lib/action_access/railtie.rb:7:in `block in <class:Railtie>'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/initializable.rb:30:in `instance_exec'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/initializable.rb:30:in `run'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/initializable.rb:55:in `block in run_initializers'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:228:in `block in tsort_each'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:431:in `each_strongly_connected_component_from'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:349:in `block in each_strongly_connected_component'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:347:in `each'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:347:in `call'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:347:in `each_strongly_connected_component'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:226:in `tsort_each'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/2.4.0/tsort.rb:205:in `tsort_each'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/initializable.rb:54:in `run_initializers'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/application.rb:352:in `initialize!'
	from /recertify/config/environment.rb:5:in `<top (required)>'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:293:in `require'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:293:in `block in require'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:259:in `load_dependency'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/activesupport-5.0.2/lib/active_support/dependencies.rb:293:in `require'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/application.rb:328:in `require_environment!'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/commands/commands_tasks.rb:157:in `require_application_and_environment!'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/commands/commands_tasks.rb:143:in `generate_or_destroy'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/commands/commands_tasks.rb:60:in `generate'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/commands/commands_tasks.rb:49:in `run_command!'
	from /home/vagrant/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/railties-5.0.2/lib/rails/commands.rb:18:in `<top (required)>'
	from bin/rails:9:in `require'
	from bin/rails:9:in `<main>'

I've found out that if I comment out this line: https://github.com/collectiveidea/audited/blob/master/lib/audited/sweeper.rb#L47 it works like a charm. I'll file a Issue for audited as well.


[DOCFIX] Update vagrant docs, vb and vagrant settings

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4317/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/4326/
Test PASSed.


Integrating Fluent2 HUD into main.

Platforms Impacted

[x] iOS
[ ] macOS

Description of changes
This change integrates the new Fluent2 Heads Up Display into the main branch.
The new version is implemented in SwiftUI and therefore is compatible for use in SwiftUI only environments.
Modifiers that de SwiftUI HUD depends on are also being added (AnimationCompletionModifier and PresentationModifier)
For context, the PRs that merged this code into the fluent2-tokens (formerly vnext-tokens) branch are referenced below:

#951
#952
#960

Verification

Tests exercising Demo App scenarios.
Validation on consuming codebase currently underway (devmain).

Light Mode
Dark Mode

Pull request checklist
This PR has considered:

[x] Light and Dark appearances
[x] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[x] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[x] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

Blocking merge until we can figure out versioning.

This is not an API breaking change, so it shouldn't be tied to issues in versioning.

Blocking merge until we can figure out versioning.

This is not an API breaking change, so it shouldn't be tied to issues in versioning.

We will be release the HUD in the same release as other controls that will break the public API.
This will be released in the next minor version update (0.6.0) currently.


Lazy loading

Add lazy loading on messages, for better performance

I added a similar feature, where it loads 20 messages and then keeps reloading until the first message
also I have commented the code so that it is easy to understand :)


Add support for extra_hosts

I add a feature allowed by docker-py to map hostname with an IP in container (/etc/hosts). I use this feature to add custom hosts inside my containers and I think it's a good point to add this to Maestro.

Awesome, thanks!


Error after set up

Steps to reproduce

Clicked on deploy to Azure.
Filled the required fields.
Launched the website.

Expected behavior

The website should run as in the screenshot in the documentation.

Actual behavior

I got " An error has occurred... Object reference not set to an instance of an object."

##Notes

The authentication process and permissions grant steps were executed correctly.
The link that is giving the error is: https://xxxxx.azurewebsites.net/Home/Error?message=Object reference not set to an instance of an object.

Any solution, as facing the same issue.


Codecov 3.3.3

fixes https://github.com/codecov/codecov-bitrise/issues/36
fixes https://github.com/codecov/codecov-bitrise/issues/24
What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.

[x] I will not move an already shared step version's tag to another commit
[x] I read the Step Development Guideline
[x] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[x] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[x] I read and accept the Abandoned Step policy

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@ofalvai, if you get a minute!

@ofalvai if you get a chance today, would be great to get this in

or @tothszabi, @lpusok  for that matter


fix cppcheck error

In C++, wchar_t is a distinct fundamental type

as it's a fundamental type but not a class, here should use malloc/free but not new/delete.

From everything I can find, the suggestion is to use "new" in C++ every time over malloc(). Do you have something that says otherwise?

$ cppcheck . -q
[src/demo/win-main.cpp:94]: (error) Mismatching allocation and deallocation: text

I found it, the right way to fix cppcheck error is:
delete[] text;

http://stackoverflow.com/questions/184537/in-what-cases-do-i-use-malloc-vs-new

Committed the delete []text; way instead as you can see above, thanks for reporting this.


Update requirements

This cl:
1- removes faiss-gpu from requirements [tested by following the installing instructions in README, as well as installing the newly released package]
2- Changes the pyproject.toml to refer to the requirements.txt
3- Releases a new patch

@sahel-sh, only comment as discussed in #66 , maybe we experiment with replacing fschat with fschat[model_worker]>=0.2.35 and removing accelerate? I do think that we can let fschat decide what accelerate they want (if they want it).

@sahel-sh, only comment as discussed in #66 , maybe we experiment with replacing fschat with fschat[model_worker]>=0.2.35 and removing accelerate? I do think that we can let fschat decide what accelerate they want (if they want it).

done


Refresh Viruses and Malware

remove MALWAREBYTES since antivirus programs can pose a massive privacy and security risk as the guide points out, recommend only installing apps from App Store or that are notarized since apple already scans for malware before you even download it
remove ostarius since the dev says on the download page that it's mitigated in the OS since Sierra

Looking at Gatekeeper and XProtect, I think these two sections should be merged together since XProtect is itself AV software and Gatekeeper stops non-notarized apps from running. I disagree with the advice to disable Gatekeeper because you can easily bypass it without fully disabling it if you want to run non notarized apps.

I wonder why objective see tools are listed.
In another threat you wrote good arguments against using their tools.

I haven't finished yet haha just going through to see what I think about them. I don't think their tools are inherently bad I just want to go one by one and see if it's 1. outdated 2. duplicating already existing OS functionality or 3. a significant privacy/security risk. It seems that knockknock sends your running applications to virus total which I think is a big enough privacy concern that it probably shouldn't be listed.

remove MALWAREBYTES since antivirus programs can pose a massive privacy and security risk as the guide points out, recommend only installing apps from App Store or that are notarized since apple already scans for malware before you even download it

Installing apps from App Store requires an Apple ID, right? So that cannot be the exclusive source for new programs.  Malware-Bytes did not require any additional permissions last time I used it (though it has been a while) and just did a passive scan for known malware artifacts. I don't know how useful it still is with XProtect and other mitigations in place, however. A third party endorsement would go a long way here, otherwise we can remove it.

* remove ostiarius since the dev says on the download page that it's mitigated in the OS since Sierra

* remove knockknock since it sends your running applications to virus total, posing a privacy risk

macOS collects the same information if not more https://lapcatsoftware.com/articles/catalina-executables.html
I don't find this privacy concern alarming. Anyway, virustotal domains can simply be blocked if the upload isn't desired. Whether knockknock is still fit for its purpose is a different question, however. Is anyone a daily driver?

* remove fear mongering about Patrick Wardle, whether he used to work for the NSA doesn't matter imo. Also his software is open source so I'm not really sure what the issue poster was talking about

Not all of his software is (or at least was at the time of writing) open source. The warning should really be against closed source programs running with privileges; I agree his career is not relevant.

Looking at Gatekeeper and XProtect, I think these two sections should be merged together since XProtect is itself AV software and Gatekeeper stops non-notarized apps from running. I disagree with the advice to disable Gatekeeper because you can easily bypass it without fully disabling it if you want to run non notarized apps.

Agreed, and it's not clear why one would want or need to disable Gatekeeper anymore. Feel free to go to work on this section.

Installing apps from App Store requires an Apple ID, right? So that cannot be the exclusive source for new programs

Right, that's why I specified Notarized programs also. Maybe it should be more clear.


[regression] v3.22.3 destroys the linegraph scaling, compared to v3.22.2

Bug report
Codepen
https://codesandbox.io/s/vue-basic-example-forked-tt4ci?file=/src/components/Chart.component.vue
We're using vue-apexcharts and just updated the patch version from 3.22.2 to 3.22.3 and saw that it made our linegraphs unusable.
In codesandbox, change the version between 3.22.3 and 3.22.2 to see the issue. Example photos below
Explanation

What is the behavior you expect?

For the scale in apexcharts linegraph to work like it did in v3.22.2

What is happening instead?

 So that's why I'm guessing it's the scaling that's off.

What error message are you getting?

None

3.22.3

3.22.2

I've got the same issue.

Temporary fix is to remove min and max  definitions from y-axis options.

Fixed it, a new version will be released very soon.

I have the same problem, let's wait the fixing release 👀

Released v3.23.0 which should fix this.

Still not working I believe...

@Redirts Checked in the original Codesandbox of this issue by updating to the latest version and it works fine.
Can you provide another Codesandbox demo?

@Redirts Checked in the original Codesandbox of this issue by updating to the latest version and it works fine.
Can you provide another Codesandbox demo?

Sorry, for some reason I cannot reproduce it anymore. My bad. Thanks


Dami/implement neighbor root polling

make use of default root

Codecov Report

Merging #194 (62f524b) into main (8485e62) will increase coverage by 0.33%.
The diff coverage is 96.38%.

:exclamation: Current head 62f524b differs from pull request most recent head deee74c. Consider uploading reports for the commit deee74c to get more accurate results

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   62.46%   62.80%   +0.33%
==========================================
  Files         102      104       +2
  Lines        7295     7406     +111
==========================================
+ Hits         4557     4651      +94
- Misses       2738     2755      +17

Impacted Files
Coverage Δ

node/src/chain_spec.rs
0.00% <ø> (ø)

pallets/anchor-handler/src/mock_bridge.rs
56.09% <ø> (ø)

...allets/anchor-handler/src/mock_signature_bridge.rs
61.70% <ø> (ø)

pallets/linkable-tree/src/mock.rs
71.42% <ø> (ø)

pallets/mixer/src/mock.rs
88.88% <ø> (ø)

pallets/mt/src/mock.rs
88.88% <ø> (ø)

pallets/vanchor/src/mock.rs
65.21% <ø> (ø)

pallets/xanchor/src/mock/parachain.rs
0.00% <ø> (ø)

standalone/node/src/chain_spec.rs
0.00% <ø> (ø)

standalone/runtime/src/lib.rs
0.00% <ø> (ø)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8485e62...deee74c. Read the comment docs.


explorer: cache extracted features

Update explorer to cache extracted features for multiple runs. This is especially useful when making multiple successive runs while testing a new rule.

has this been addressed in #1251?


type-directed compilation

A big refactoring as a first step to properly handle module parameters.
The most important change is the following: the compilation of terms if now completely type-directed. That is, we no longer rely on ArgInfo of Elims to know whether they have to be preserved, but rather their Dom Type only.
What this means, concretely:

Explicit usable erasable arguments (Say, (a : Set)) are dropped.
Implicit usable non-erasable arguments (Say, {x : Nat}) are made explicit.
(This means we now officially support tactic arguments that are made explicit on the Haskell side.)

As a treat, we now properly erase types of sort Prop.
Closes #217.

TODO list before opening the PR:

[x] Add back special class functions.
[x] Fix compilation of co-patterns.
[x] Fix compilation of patterns on projection-like functions.
[x] Add back compilation of inline functions.
[x] Ensure unfolding is back.
[x] Drop module parameters again.

All the tests pass again, finally.
Before reviewing this PR, there's still one caveat to fix: currently every test has the flag --no-projection-like set, because projection-like are annoying to manipulate.
The following things are likely to break once I remove the flag:

[ ] Compilation of functions, as projection-like only store patterns that come after the record argument.
[ ] Compilation of Defs, because some defs will be compiled in compileProj.
[ ] compileSpined?

Rebased on #277.

Implicit arguments with instance functions are still a compiler error, is this expected? i.e.
test : {x : Nat} → Nat
test {x} = x
{-# COMPILE AGDA2HS test #-}

will work but
instance
  test : {x : Nat} → Nat
  test {x} = x
{-# COMPILE AGDA2HS test #-}

will give
An internal error has occurred. Please report this as a bug.
Location of the error: __IMPOSSIBLE__, called at src/Agda2Hs/Compile/ClassInstance.hs:103:20 in main:Agda2Hs.Compile.ClassInstance

Hmm, to be fair the compilation of class instances is the part I'm the least happy with currently (the current implementation and what I did to make it typed).
Though I fail to see when a compiled instance with hidden relevant arguments turning relevant would ever make sense. I will add a check that for instances specifically, no relevant arguments are ever hidden as I think this would do the trick. Thanks for the example!
If you ever encounter an example where this would be useful behavior, hit me up!

@omelkonian: I fixed the compilation of projection-like functions and addressed all of your comments!
You will see that one test still requires the --no-projection-like flag as compiling projection-like (or projections) directly applied to constructors in a typed setting kinda goes against bidirectional tc. Quoting @jespercockx:

a projection-like function applied to a constructor violates bidirectionality so you cannot (easily) do a type-aware traversal of it

If you remove the flag, the code will still compile to correct Haskell, but the projection-like function unbind will get reduced. Not incorrect, but just not what the user wrote.
If someone is really motivated, perhaps using projView could allow you to preserve the projection-like function application, but I think you'd still have to trigger inference at some point, which I don't want to do.

One thing that slightly worries me is that I would expect this refactoring to reduce code size, but it in fact increases it substantially (c.f. +800/-500). Factoring out new tests and utilities we did not need before, it seems the main culprit is Compile.Term; do you think the final polished version might be able to reduce LOC down a bit?

Hm, going into this implementation I had the same assumption, but quickly realized some more work was unavoidable (e.g Defs and projections cannot really be treated uniformly anymore).
All in all, I don't think too much code is added, there is also a lot of whitespace introduced because I like my code to breathe.
Hopefully things should be more easily maintainable too :)

@jakobn-ai: came across this experimenting with adding runtime checks for e.g. erased preconditions. A deciding version of a precondition would ideally be written as instance so it can be found in instance search: [...]

But the instance itself shouldn't be compiled to agda2hs right? Or using some custom logic (that you'd have to implement yourself).
I decided against adding the check I mentioned above, since the class compilation routine already doesn't enforce that, say, we don't pattern-match on parameters of instances, and they are silently dropped til we reach a (class) projection (See here).
So something should be done alright, just not in this PR!

If you remove the flag, the code will still compile to correct Haskell, but the projection-like function unbind will get reduced. Not incorrect, but just not what the user wrote.

Could you also add these unit tests, i.e. the ones without the flag where the generated code is further away from what the user wrote?
Then, a subsequent PR that improves on that (e.g. using projView) could improve those tests.

Done! (See test/ProjLike.agda)


ZHA Error when Clicking on "Add Devices" in ZHA GUI in 0.95.4 - "TypeError: permit() got an unexpected keyword argument 'node'"

Home Assistant release with the issue: 0.95.4

Last working Home Assistant release (if known): not known
Operating environment (Virtual Environment):

Component/platform: ZHA

Description of problem:
When clicking on Configuration > ZHA> Add devices it never completes.  I get the error below in the home-assistant.log:
2019-07-12 17:04:45 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection.139630308033592] Error handling message: Unknown error
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/websocket_api/decorators.py", line 17, in _handle_async_response
    await func(hass, connection, msg)
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/zha/api.py", line 111, in websocket_permit_devices
    node=ieee)
TypeError: permit() got an unexpected keyword argument 'node'

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
zha:
  usb_path: /dev/ttyUSB1
  database_path: /home/homeassistant/.homeassistant/zigbee.db

Traceback (if applicable):

Additional information:

I can't reproduce this. Try clearing your browser cache to ensure your frontend is up to date.

Clearing the browser cache didn't work.  Thanks anyways.

I’m at a loss... you’re running 95.4 with no customization to ZHA right?

I started with 0.84.0 then upgraded to 0.95.4.  I had the Yoda-X version of bellows installed.

I can't reproduce it as well.

I started with 0.84.0 then upgraded to 0.95.4. I had the Yoda-X version of bellows installed.

That could be the problem. run pip3 uninstall -y bellows and pip3 uninstall -y bellows-homeassistant and restart HA

Oy, yeah, gotta make sure the remnants of the other libs are gone

First, thanks to both of you for even answering on a Sunday.  I executed both commands in the VirtualEnv, removed then added back my Zha: statement and now I get this:
2019-07-14 17:05:10 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry /dev/ttyUSB1 for zha
Traceback (most recent call last):
File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/config_entries.py", line 153, in async_setup
hass, self)
File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/zha/init.py", line 75, in async_setup_entry
establish_device_mappings()
File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/zha/core/registries.py", line 134, in establish_device_mappings
zha.DeviceType.ON_OFF_BALLAST: SWITCH,
File "/usr/lib/python3.6/enum.py", line 326, in getattr
raise AttributeError(name) from None
AttributeError: ON_OFF_BALLAST
I can reach all of my devices, so I have no problems removing all the remnants of Zha and starting from scratch and re-pairing.  If you want to suggest how to do that, that would be fine.

Just try using pip to force install the libs listed here: https://github.com/home-assistant/home-assistant/blob/bcf85a0df195cdc28a60954f2e853beb81da49be/homeassistant/components/zha/manifest.json#L6
You should need quirks, Zigpy and bellows from that list. So stop HA, force install them and restart

Again, thank you both.  Removing the dependencies and allowing the integrations to add back recognized my old devices from my db and allowed me to add a new device.  You guys rock!


Ingesting Datasets with region outside US does not generate metadata

Describe the bug
When dealing with BigQuery datasets located in regions outside of "region-us," the metadata generation process during ingestion is not functioning properly.
To Reproduce
Steps to reproduce the behavior:

Create a BigQuery dataset in a non-US region, such as "EU," and assign a description to it.
Perform ingestion of the Google Cloud Platform (GCP) Project containing the dataset into Datahub.
Observe that the dataset metadata is missing in Datahub.

Expected behavior
Datahub should successfully ingest the metadata of BigQuery datasets located in regions outside of the United States ("US").
Additional context
The root cause of this issue can be attributed to this specific line, which defaults to using "region-us". Please refer to the BigQuery documentation for more details on the expected scope and syntax.

Slack discussion: https://datahubspace.slack.com/archives/CUMUWQU66/p1685535611884369?thread_ts=1684936507.117099&cid=CUMUWQU66
Current workaround: you can pass in the default location to the BigQuery source by adding this to your source config:
    extra_client_options:
      location: "EU"


Update ~4.0 branch / tag to use SilverStripe 3.6

Currently the default installed version is SS 3.5

This is currently set to ~3.5@stable which will resolve to the latest stable version <4.0. So, it should be retrieving the latest 3.7.X stable release (or 3.6.X at the time of this issue being opened). @silbinarywolf, can you please confirm your expectations here?

@nglasl I honestly can't remember. I'm guessing either:

It ended up pulling down SS 3.5 for some reason
or
I just wanted our base to be more accurate as to what SS version we have installed.

@silbinarywolf considering this should already be working and that it's technically a moving target (3.6 was the latest, now 3.7 is the latest), are you okay for this one to be closed? If you're keen to update it, I'm more than happy for you to make the change :)

@nglasl I see no reason to be pedantic about this. If it angers me in the future, I'll just do a PR rather than raise an issue!
Closing!


python310Packages.google-auth-oauthlib: 0.5.2 -> 0.7.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This PR broke tensorboard, pytorch, tensorflow, and dozens of other packages. Could you please follow up with fixes for those packages or revert this PR?

All of those failed to build when testing this because spacy failed to build with some issues in the tests so I didn't look further into it.


Adding test cases for klum project

The file name is not correct, so the tests are not being executed  with go tests ./...


feat: add case function (#447)

Which issue does this PR close?
Closes #447
What changes are included in this PR?
Besides exposing the case function, this PR also adds the PyCaseBuilder class (to parallel Rust's CaseBuilder)
Are there any user-facing changes?
Yes, but the documentation should be generated automatically

Looks like there is one failing CI check

Yes, @mesejo there is a check-style test failing if you don't mind fixing. If not I can make the commit to resolve

Thanks to both of you @alamb and @jdye64 for the review 🙏. The check-style test should be fixed now!

Thanks again @mesejo


python3Packages.pydoods: init at 1.0.2

Motivation for this change
Python wrapper for the DOODS service
https://github.com/snowzach/pydoods
This is a Home Assistant dependency.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 139479 run on x86_64-linux 1

2 packages built:

python38Packages.pydoods
python39Packages.pydoods

Result of nixpkgs-review pr 139479 at a8892f08 run on aarch64-linux 1

2 packages built successfully:

python38Packages.pydoods
python39Packages.pydoods


Choose Local files images

Hi any one suggest solution for the below issue. when i am using this plugin i can only accessing files from icloud, googleDrive. if there is any way to access the files and images from phone memory.

It would be great to be able to access local image files from Photos, if possible.

To access photos you have to use the camera plugin, this plugin only allows to pick files from content providers and photos app isn't a content provider


primary service don't have selector to include pods

What happened?
No pods in primary service

Did you expect to see something different?
the master pod should be in there
The replica service has selector:
https://github.com/timescale/helm-charts/blob/main/charts/timescaledb-single/templates/svc-timescaledb-replica.yaml#L24
but primary services don't have that cause that, is that intentional?
How to reproduce it (as minimally and precisely as possible):
just following the guide with load balancer turned off
Environment
GKE

Which helm chart and what version are you using?
0.14.4

What is in your values.yaml ?

Kubernetes version information:
kubectl version

Kubernetes cluster kind:
insert how you created your cluster: kops, bootkube, etc.

Anything else we need to know?:

Duplicate of #394 ?

got it thank you


Fullscreen window on second monitor is as wide as both my monitors.

At least this is what glfwGetWindowSize() reports when my program is run.
OS is Ubuntu. Hardware is not the issue, as I've tested this on my older computer (also Ubuntu) as well, ending up with the same result.
I've intentionally reduces the 2nd monitor's resolution to 1280 by 1024 (main being 1080p) in order to pinpoint the issue, and when I run, glfwGetWindowSize() returns a window size of 3200 (1920 + 1280) by 1080.
If it helps, the window size works perfectly when using GLFW 3.0.4.
Thank you for all your efforts.

What window manager are you using?

Compiz, as it seems.

I'm not sure if this is of any use, either, but explicitly passing 1920 and 1080 to glfwSetWindowSize() voids the same result as specified above.

Please post the properties of the window. See xprop(1).

Here's what xprop gave me, before I made an upgrade, which I will talk about in a second:
_NET_WM_ICON_GEOMETRY(CARDINAL) = 1925, 442, 54, 54
WM_STATE(WM_STATE):
		window state: Normal
		icon window: 0x0
_NET_WM_FULLSCREEN_MONITORS(CARDINAL) = 1, 1, 1, 1
_NET_WM_DESKTOP(CARDINAL) = 0
_NET_WM_STATE(ATOM) = _NET_WM_STATE_FULLSCREEN
_NET_WM_NAME(UTF8_STRING) = "Simple example"
WM_LOCALE_NAME(STRING) = "en_CA.UTF-8"
WM_CLIENT_MACHINE(STRING) = "Lenovo-Y50-70"
WM_ICON_NAME(STRING) = "Simple example"
WM_NAME(STRING) = "Simple example"
_NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 0, 0
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_STICK, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
XdndAware(ATOM) = BITMAP
WM_CLASS(STRING) = "Simple example", "Simple example"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
		program specified location: 1920, 0
WM_HINTS(WM_HINTS):
		Initial state is Normal State.
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, _NET_WM_PING
daniel@Lenovo-Y50-70:~$ xprop
_NET_WM_ICON_GEOMETRY(CARDINAL) = 1925, 442, 54, 54
WM_STATE(WM_STATE):
		window state: Normal
		icon window: 0x0
_NET_WM_FULLSCREEN_MONITORS(CARDINAL) = 1, 1, 1, 1
_NET_WM_DESKTOP(CARDINAL) = 0
_NET_WM_STATE(ATOM) = _NET_WM_STATE_FULLSCREEN
_NET_WM_NAME(UTF8_STRING) = "Simple example"
WM_LOCALE_NAME(STRING) = "en_CA.UTF-8"
WM_CLIENT_MACHINE(STRING) = "Lenovo-Y50-70"
WM_ICON_NAME(STRING) = "Simple example"
WM_NAME(STRING) = "Simple example"
_NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 0, 0
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_STICK, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
XdndAware(ATOM) = BITMAP
WM_CLASS(STRING) = "Simple example", "Simple example"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
		program specified location: 1920, 0
WM_HINTS(WM_HINTS):
		Initial state is Normal State.
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, _NET_WM_PING

Now to the upgrade (that I was finally able to narrow down after 2 months). I had to update compiz and some related packages, and the window size works perfectly

Here's what xprop gave me, before I made an upgrade, which I will talk about in a second:
_NET_WM_ICON_GEOMETRY(CARDINAL) = 1925, 442, 54, 54
WM_STATE(WM_STATE):
		window state: Normal
		icon window: 0x0
_NET_WM_FULLSCREEN_MONITORS(CARDINAL) = 1, 1, 1, 1
_NET_WM_DESKTOP(CARDINAL) = 0
_NET_WM_STATE(ATOM) = _NET_WM_STATE_FULLSCREEN
_NET_WM_NAME(UTF8_STRING) = "Simple example"
WM_LOCALE_NAME(STRING) = "en_CA.UTF-8"
WM_CLIENT_MACHINE(STRING) = "Lenovo-Y50-70"
WM_ICON_NAME(STRING) = "Simple example"
WM_NAME(STRING) = "Simple example"
_NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 0, 0
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_STICK, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
XdndAware(ATOM) = BITMAP
WM_CLASS(STRING) = "Simple example", "Simple example"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
		program specified location: 1920, 0
WM_HINTS(WM_HINTS):
		Initial state is Normal State.
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, _NET_WM_PING
daniel@Lenovo-Y50-70:~$ xprop
_NET_WM_ICON_GEOMETRY(CARDINAL) = 1925, 442, 54, 54
WM_STATE(WM_STATE):
		window state: Normal
		icon window: 0x0
_NET_WM_FULLSCREEN_MONITORS(CARDINAL) = 1, 1, 1, 1
_NET_WM_DESKTOP(CARDINAL) = 0
_NET_WM_STATE(ATOM) = _NET_WM_STATE_FULLSCREEN
_NET_WM_NAME(UTF8_STRING) = "Simple example"
WM_LOCALE_NAME(STRING) = "en_CA.UTF-8"
WM_CLIENT_MACHINE(STRING) = "Lenovo-Y50-70"
WM_ICON_NAME(STRING) = "Simple example"
WM_NAME(STRING) = "Simple example"
_NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 0, 0
_NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_STICK, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW
XdndAware(ATOM) = BITMAP
WM_CLASS(STRING) = "Simple example", "Simple example"
WM_NORMAL_HINTS(WM_SIZE_HINTS):
		program specified location: 1920, 0
WM_HINTS(WM_HINTS):
		Initial state is Normal State.
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, _NET_WM_PING

Now to the upgrade (that I was finally able to narrow down after 2 months). I had to update compiz and some related packages, and the glfwGetWindowSize() returns the intended result.
Here they are, if it helps:
Old packages:
  Version: 1:<IP_ADDRESS>+14.04.20140714-0ubuntu1
  - compiz
  - compiz-core
  - compiz-gnome
  - compiz-plugins-default
  - libdecoration0

  Version: 1:<IP_ADDRESS>+14.04.20150122-0ubuntu1
  - libcompizconfig0

New Packages:
  Version: 1:<IP_ADDRESS>+14.04.20150122-0ubuntu1
  - compiz
  - compiz-core
  - compiz-gnome
  - compiz-plugins-default
  - libcompizconfig0
  - libdecoration0

Ah, so it works now?

It does now. Just not with the old versions of the packages I listed above. Compiz and Xinerama must have had some form of conflicting code, but this was patched in the new version(s) of the package(s).

All right. Thank you for the follow-up.


Bump production to 0.86.0

Release #229 to production, set the threshold for production.
Checked alarms in staging. The S3 one is marked as insufficient data, maybe we can treat missing data as "not breaching" and change the period afterwards, this metric is not published often it seems.

Yeah going to change period for this one. Closing and will reopen.

Reworks period in https://github.com/cds-snc/notification-terraform/pull/232


[DRAFT] docs: update getting started with alias

Fixes #N/A
Description
Updates the getting started guide to use an alias rather than individual AMI pins.
How was this change tested?
Manually going through the getting started guide.
Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 79.264%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
91.67%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.01%

Covered Lines:
5921

Relevant Lines:
7470

💛  - Coveralls

Don't we need to make this updates to v1.0 and preview?

/remove lifecycle-stale

/remove-lifecycle stale


Develop

Change how the drawing works. It's now using the mouse

Overall the changes look good. I think it would be good to make it so a player spawns not in paint mode. I also think paint mode should have a set range and some indicator for the player to know if they can paint on the wall.

oh yeah my bad missed that. I just wanted to remove the old painting stuff. For the logic we decided we can paint from anywhere.


Unable to submit to AppStore

Hi,
It seems that we can not submit iOS App with twitter-kit-unity to AppStore.
Following error will be displayed and fail.

ERROR ITMS-90535: "Unexpected CFBundleExecutable Key. The bundle at 'Payload/twitterKit.app/TwitterShareExtensionUIResources.bundle' does not contain a bundle executable. If this bundle intentionally does not contain an executable, consider removing the CFBundleExecutable key from its Info.plist and using a CFBundlePackageType of BNDL. If this bundle is part of a third-party framework, consider contacting the developer of the framework for an update to address this issue."

STEPS TO REPRODUCE:

Create new project in Unity
Import twitter-kit-unity 3.1.1 and set API keys
Build project in Unity
Open exported xcode project
Archive
Open Organizer window
Press “Upload to App Store” button and advance the process
“ERROR ITMS-90535” displayed and fail to submit to App Store

WORKAROUND:
Remove “Excecutable File” key from Assets/Plugins/iOS/TwitterShareExtensionUIResources.bundle/Info.plist
In the meantime, we can successfully submit to AppStore with the above workaround, but I'm not sure if this is the correct way to fix it.
Please confirm.
ENVIRONMENT:
Unity 2017.1.0f3
Xcode 8.3.3
twitter-kit-unity 3.1.1
Thank you for being patient with my Google-Translated-English.

We are aware of the issue and are working to get the problem resolved. See: https://twittercommunity.com/t/unable-to-upload-ios-build-to-itunes-connect/87866/6

Thank you for the information.
I am looking forward to being fixed.

This has been fixed, please upgrade to v3.2.0.


Allow user to specify public/private keys from file during systems create/update

Is your feature request related to a problem? Please describe.
The current workflow for creating or updating a system with SSH/SFTP authentication requires one to serialize and store their public and private SSH keys and embed them in a JSON file. This is pretty annoying and might lead to leakage of a user's keys if that JSON file got committed to a git repo.
Describe the solution you'd like
Add arguments to systems create and systems update to specify private key for login and storage. Possibly, there could be a CLI config for default SSH key that could be read from.
The precedence order would be:

Value provided on the CLI
Value provided in the JSON file
Value provided via the CLI config

YES


Loggedin Username

Hi,
Currently, username for logged in users are displayed as their emails example<EMAIL_ADDRESS>All other comments are displayed by their usernames like "John Doe".
Upon logging out, the logged in user will be displayed as "Matthew Carter" for example. I did not modify any template from this package.
This is not user-friendly currently because logged-in users might think they're being shown as their emails. They would only find out this is not so unless they log out.
May I know a quick fix to this?

+1

You can change which username is displayed by configuring generateUsername, so it's up to you what to display for logged in users https://github.com/ARKHAM-Enterprises/meteor-comments-ui#published-data.


Hover fix

not show the last , and ; now
update systemverilog keywords
modify coding style

#17 split PR to 3 PRs (2/3)

Ok.


Qingwei/fix nan on purchase

Coverage decreased (-0.03%) to 28.695% when pulling ed23cdf5caf14e7f63ff6797ec5a2c50de2eeac3 on qingweibinary:qingwei/fix_nan_on_purchase into 49338e12bef322871acfa795ffc8c4ac7f9dfcc4 on binary-com:master.

Coverage decreased (-0.02%) to 28.704% when pulling 807b8c3e118ae4a3fbfb8321f51e5860b57d49ed on qingweibinary:qingwei/fix_nan_on_purchase into 49338e12bef322871acfa795ffc8c4ac7f9dfcc4 on binary-com:master.

Fixed as comments

Coverage decreased (-0.05%) to 28.675% when pulling f8f2432aa829b7d22747cf438b85c504bcf9c88c on qingweibinary:qingwei/fix_nan_on_purchase into 49338e12bef322871acfa795ffc8c4ac7f9dfcc4 on binary-com:master.


Panic "Unable to resolve scalar field 'A'": @@unique does not work with non-scalar fields

You used to be able to put non scalar fields into @@unique with up to 2.0.0-preview017.2. Then an update to how we internally read and handle @@unique unfortunately broke that functionality, and limited it to scalar fields.
The error message you get looks something like this:
Schema parsing
thread 'main' panicked at 'Unable to resolve scalar field 'A'', src/libcore/option.rs:1185:5
stack backtrace:
   0: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
   1: core::fmt::write
   ...

This is an unwanted regression and we are working on fixing this.
Unfortunately it seems to be a part of a bigger thing, so is not a quick fix but will be resolved as part of a bigger change.
This problem can also appear in context of Introspection, when the schema you are introspecting has as UNIQUE on a Foreign Key field: https://github.com/prisma/prisma2/issues/1377

This is now fixed.


[Bug]: Switching between neovim and wezterm panes when using wezterm ssh client does not work

Similar Issues

[X] Before filing, I have searched for similar issues.

Neovim Version
NVIM v0.9.5
Build type: RelWithDebInfo
LuaJIT 2.1.1692716794

Multiplexer Integration
Wezterm
Multiplexer Version
wezterm 20240203-110809-5046fc22
Steps to Reproduce

Setup keybinds as per README in wezterm and neovim
Run wezterm ssh <your-host>
Open nvim
Create a new pane
Attempt to navigate back to nvim pane

It works!

Attempt to navigate out of neovim to the initial pane.

It doesn't work

Expected Behavior
You should be able to navigate out of neovim split in a wezterm ssh <host> session.
Actual Behavior
You can only navigate to an neovim split, not out of it.
Minimal Configuration to Reproduce
local root = vim.fn.fnamemodify('./.repro', ':p')

-- set stdpaths to use .repro
for _, name in ipairs({ 'config', 'data', 'state', 'cache' }) do
  vim.env[('XDG_%s_HOME'):format(name:upper())] = root .. '/' .. name
end

-- bootstrap lazy
local lazypath = root .. '/plugins/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    'git',
    'clone',
    '--filter=blob:none',
    '--single-branch',
    'https://github.com/folke/lazy.nvim.git',
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  -- do not remove the colorscheme! it makes testing nicer
  'folke/tokyonight.nvim',
  'mrjones2014/smart-splits.nvim',
  -- add any other pugins here
}

require('lazy').setup(plugins, {
  root = root .. '/plugins',
})

require('smart-splits').setup({
  -- add any options here
})

)
-- moving between splits
vim.keymap.set('n', '<C-h>', require('smart-splits').move_cursor_left)
vim.keymap.set('n', '<C-j>', require('smart-splits').move_cursor_down)
vim.keymap.set('n', '<C-k>', require('smart-splits').move_cursor_up)
vim.keymap.set('n', '<C-l>', require('smart-splits').move_cursor_right)

-- add anything else here
vim.opt.termguicolors = true
-- do not remove the colorscheme! it makes testing nicer
vim.cmd([[colorscheme tokyonight]])

Additional Details and/or Screenshots
I've been digging around a bit on this one, and from what i can gather it is only an issue when using wezterms built in ssh client, e.g if if i run ssh <host> switching between panes works.
I've set up the shell-integrations as per the instructions in the wezterm docs: https://github.com/wez/wezterm/blob/main/assets/shell-integration/wezterm.sh and can confirm that the IS_NVIM user var is being set correctly and is accessible from outside the remote host.
I can't see anything interesting in :SmartSplitsLog
It seems that the call to wezterm_exec({ 'get-pane-direction', direction }) here https://github.com/mrjones2014/smart-splits.nvim/blob/78f0c74ea1d5aa1725ab63b25761886245622904/lua/smart-splits/mux/wezterm.lua#L97C1-L97C43 doesn't return anything.
Running the command in bash on the remote host gives the following error:
ERROR  wezterm > --pane-id was not specified and $WEZTERM_PANE~~
                        is not set in the environment, and I couldn't
                         determine which pane was currently focused; terminating

Edit: though that might be because i didn't specify it when running the command

related: https://github.com/mrjones2014/smart-splits.nvim/pull/105 https://github.com/mrjones2014/smart-splits.nvim/issues/103

Hm, the issue is because of $WEZTERM_PANE not being set in the SSH session, but I'm not sure how to work around it.

Hmm ok. Sounds like more of a wezterm issue then

It seems to work when connecting to the persistent ssh domain instead of the ad-hoc one. e.g wezterm connect <domain>

In the case where it doesn't work, if you run wezterm cli list --format json does it show the correct pane as active? If so we can work around it by using that to get the active pane ID instead of relying on $WEZTERM_PANE and then passing --pane-id

In the case where it doesn't work, if you run wezterm cli list --format json does it show the correct pane as active? If so we can work around it by using that to get the active pane ID instead of relying on $WEZTERM_PANE and then passing --pane-id

It just returns an empty list :/
But I'm unsure how that connection would work anyway, how should the wezterm cli running on the remote machine know things about the local wezterm gui.
My guess is when connecting using the persistent ssh domain it uses the socket somehow.

Interesting. I have the same issue except without an ssh session.
I don't know if it's related that I have set login shell config.default_prog = { "/usr/bin/fish", "-l" }

Interesting. I have the same issue but even without an ssh connection. Just wezterm and Neovim

I'm in the same situation as you, and so far I've come to the conclusion that neovim doesn't receive key events, but inside neovim you can see that shortcuts have been bound via :verbose map .
But when I use vim.notify to throw an exception in the smart-splits source code, the shortcut is again available using the.
function M.get()
  if
    config.multiplexer_integration == nil
    or config.multiplexer_integration == false
    or #tostring(config.multiplexer_integration or '') == 0
  then
    return nil
  end

  local ok, mux = pcall(require, string.format('smart-splits.mux.%s', config.multiplexer_integration))
  print(ok)  # no error
  print(vim.inspect(mux))  # no error
  vim.notify(ok)  # error
  if not ok then
    log.error(mux)
  end
  return ok and mux or nil
end

Interesting. Could you open a separate issue for that?

Interesting. Could you open a separate issue for that?

#212

is because of $WEZTERM_PANE not being set in the SSH session

Pretty sure it's all related to this. Still investigating.

See also: https://github.com/wez/wezterm/discussions/5378#discussioncomment-9377194
It should be something like AcceptEnv WEZTERM_PANE on the server, and maybe some client config. However I've been unable to get a working SSH config.

So I can reproduce this with normal ssh but I actually cannot reproduce using wezterm ssh


feat: add OIDC_ALLOW_ALL_USERS , allow all users to access, even those not in the allowed groups.

In this PR:

Add OIDC_ALLOW_ALL_USERS to allow all users to access.
Motivation: Assuming there is a self-hosted gitlab in the organization, all users in gitlab should have authorized to access MLFlow. Save the trouble of manually adding them to the group one by one

Added a script to initialize the development environment.(clear authorized user data)

Add strtobool function, avoiding dependencies on distutils

Avoid warnings: Usage of '~' in imports is deprecated.

Fix bugs: If there is no groups field in the id token and userinfo, HTTP 500 will be caused

If you find it inconvenient to review, I can close this PR and split it into other PRs (I think the code changes will be clearer this way).

dear @NeroBlackstone,
could you please split this into separate PRs?
regarding the GitLab integration case, could you check if it can be implemented as an independent plugin (similar to how group retrieval works for MS Entra ID)?

Close PR for split it into other PRs


Fish name visualization binds to first item for all fish with ssas tabular

This is a 3rd party visual. I am guessing you are talking about the Aquarium visual. This is its repository https://github.com/enlightendesigns/PowerBI-visuals. You should raise your issue here.


JS specific pentelemetry/instrumentation

node --require @opentelemetry/auto-instrumentations-node/register index.js
Unable to initialize instrumentation for lambda. Cannot identify lambda handler or task root. { taskRoot: undefined, handlerDef: undefined }
@opentelemetry/instrumentation-grpc Module @grpc/grpc-js has been loaded before @opentelemetry/instrumentation-grpc so it might not work, please initialize it before requiring @grpc/grpc-js
OTEL_TRACES_EXPORTER is empty. Using default otlp exporter.
OpenTelemetry automatic instrumentation started successfully

node --require @opentelemetry/auto-instrumentations-node/register index.js Unable to initialize instrumentation for lambda. Cannot identify lambda handler or task root. { taskRoot: undefined, handlerDef: undefined }

This is #1774

@opentelemetry/instrumentation-grpc Module @grpc/grpc-js has been loaded before @opentelemetry/instrumentation-grpc so it might not work, please initialize it before requiring @grpc/grpc-js

This is https://github.com/open-telemetry/opentelemetry-js/issues/4151, I'm working on this. PR to follow soon.

OTEL_TRACES_EXPORTER is empty. Using default otlp exporter.

You can set the exporter specifically using the OTEL_TRACES_EXPORTER environment variable, then this log will go away. (I highly recommend this, it's better to be explicit with this config, it fits the definition of its log level - code may continue to work, but it's unconfigured and may cause problems for your specific setup).

OpenTelemetry automatic instrumentation started successfully

This is an info log. I think this is fine.
If the logging is too verbose, you can also set the OTEL_LOG_LEVEL env var to WARN or ERROR.
Since we already have issues for this I'm closing this as a duplicate, feel free to comment if you disagree - happy to re-open the issue then.


Updated envoy_reader with smarter fetching and fetching properties based on jsonpaths

And other updates:

URL's are registered in a mapping, with some additional settings, like how often to fetch the url and if installer token is required
The JWT token has a field for identifying the type of the token (owner or installer). This is now implemented in determining if we can fetch a url endpoint.
Attributes can be referenced with jsonpath logic or be defined by @envoy_property wrappers. This way it is easier to add new measurements and also easier to differentiate between EnvoyStandard and Metered and Metered with CT.
Because of the jsonpath logic, we can also use the non-None properties to get a list of endpoints we should update. Which urls are required are evaluated once, when one full getData call has completed.

I also included test data, so we can more easily test the EnvoyData parser, without waiting for output of the envoy, so it is easier to test the jsonpath values.

I have been running this version for some days now, works great (for me at least 😄 )
The way this is set up makes more sense to me, as the counter values can be defined separately for separate scenario's of a envoy. Also, all values are now placed in a EnvoyData class (e.g. EnvoyMetered or EnvoyStandard), while all fetching and token logic is stored in the EnvoyReader class.
This envoy_reader.py is fully backward compatible with the current way data is updated in __init__.async_update_data.
Also adding more sensors should be easier in the future, as we only have to define the sensor for HA, and then define the jsonpath in the dataclass; as the __getattr__ methods in the EnvoyReader and EnvoyData class will resolve the value configured in the attribute holding the jsonpath.

(i just noticed that the escalation to installation account does not work properly yet, working on it)

Wow, this is a huge improvement in code! 😃 Also love having the json fixtures included. We might want to use them to do unit testing later.
Also love the caching system. But the cache time per endpoint seems a bit arbitrary to me? At least for my Envoy most of the endpoints only update every 5 minutes. Why to choice to not cache some endpoints and others for 20 seconds?
Thanks for all your contributions. I will also set you as code owner in the manifest and add you as collaborator to the repo, if you like. 🙂

@mnederlof This change does throw quite a lot of warnings into my Home Assistant logs:
Logger: custom_components.enphase_envoy.envoy_reader
Source: custom_components/enphase_envoy/envoy_reader.py:1223
Integration: Enphase Envoy (Installer) ([documentation](https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/), [issues](https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/issues))
First occurred: 15:47:49 (84 occurrences)
Last logged: 15:50:52

Attribute daily_consumption_l2 unknown
Attribute lifetime_consumption_l2 unknown
Attribute consumption_l3 unknown
Attribute daily_consumption_l3 unknown
Attribute lifetime_consumption_l3 unknown

Logger: custom_components.enphase_envoy.envoy_reader
Source: custom_components/enphase_envoy/envoy_reader.py:617
Integration: Enphase Envoy (Installer) ([documentation](https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/), [issues](https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/issues))
First occurred: 15:47:49 (16 occurrences)
Last logged: 15:50:52

Attribute consumption unknown
Attribute daily_consumption unknown
Attribute lifetime_consumption unknown
Attribute voltage unknown

Maybe the detect_model comes up with EnvoyMetered, instead of EnvoyStandard. Could you post some json fixtures from you EnvoyStandard, then maybe i can find some other things to differentiate on

And we should make that _LOGGER.warning in __getattr__ in EnvoyReader do _LOGGER.debug maybe 😇

Wow, this is a huge improvement in code! 😃 Also love having the json fixtures included. We might want to use them to do unit testing later.
Also love the caching system. But the cache time per endpoint seems a bit arbitrary to me? At least for my Envoy most of the endpoints only update every 5 minutes. Why to choice to not cache some endpoints and others for 20 seconds?
Thanks for all your contributions. I will also set you as code owner in the manifest and add you as collaborator to the repo, if you like. 🙂

Well, yes, the inverters only update every 5 minutes, but they do not do this synchronously (so with a lot of inverters, it could yield a different output every X seconds. Since users can set the poll_interval now via configurable options, it would make sense to do this arbitrary value of 20 seconds
But, yes, i did choose that arbitrary value there.
Also, when using a CT, you could do polling a lot, which should reflect the realtime usage of that seconds (when not using the /stream/meter endpoint), so this 20 seconds should alleviate the pressure on the envoy a bit.
We could make that cache setting be configurable too though 😄

@mnederlof This change does throw quite a lot of warnings into my Home Assistant logs:
Logger: custom_components.enphase_envoy.envoy_reader
Source: custom_components/enphase_envoy/envoy_reader.py:1223
Integration: Enphase Envoy (Installer) ([documentation](https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/), [issues](https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/issues))
First occurred: 15:47:49 (84 occurrences)
Last logged: 15:50:52

Attribute daily_consumption_l2 unknown
Attribute lifetime_consumption_l2 unknown
Attribute consumption_l3 unknown
Attribute daily_consumption_l3 unknown
Attribute lifetime_consumption_l3 unknown

Logger: custom_components.enphase_envoy.envoy_reader
Source: custom_components/enphase_envoy/envoy_reader.py:617
Integration: Enphase Envoy (Installer) ([documentation](https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/), [issues](https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/issues))
First occurred: 15:47:49 (16 occurrences)
Last logged: 15:50:52

Attribute consumption unknown
Attribute daily_consumption unknown
Attribute lifetime_consumption unknown
Attribute voltage unknown

see https://github.com/vincentwolsink/home_assistant_enphase_envoy_installer/pull/43