Fail to pick image using image_picker plugin On Android 10

I am using the image_picker plugin in my app from last 5 months
there has been no code change since then but recently when I upgraded to flutter stable v1.9.1
I started getting this error whenever I tried to use the feature
When I click on button to pick image via gallery / camera
event is launched but it doesn't return any file with it
and there is no entry in log either
but when I try once more the button no longer works and errors are registered in the log
I tried  FLUTTER CLEAN and changing the channel too but that too didnt help
** log **
> I/Timeline(12347): Timeline: Activity_launch_request time:323704530 intent:Intent { act=android.content.pm.action.REQUEST_PERMISSIONS pkg=com.google.android.packageinstaller (has extras) }
I/Timeline(12347): Timeline: Activity_launch_request time:323706693 intent:Intent { act=android.intent.action.GET_CONTENT typ=image/* }
E/flutter (12347): [ERROR:flutter/lib/ui/ui_dart_state.cc(148)] Unhandled Exception: PlatformException(already_active, Image picker is already active, null)
E/flutter (12347): #0      StandardMethodCodec.decodeEnvelope
package:flutter/…/services/message_codecs.dart:569
E/flutter (12347): #1      MethodChannel.invokeMethod
package:flutter/…/services/platform_channel.dart:316
E/flutter (12347): <asynchronous suspension>
E/flutter (12347): #2      ImagePicker.pickImage
package:image_picker/image_picker.dart:59
E/flutter (12347): <asynchronous suspension>
E/flutter (12347): #3      _CreateQuoteState._getImage
package:Writco/…/CreatePost/create_quote.dart:746
E/flutter (12347): <asynchronous suspension>
E/flutter (12347): #4      _CreateQuoteState._imagePickDialog.<anonymous closure>.<anonymous closure>
package:Writco/…/CreatePost/create_quote.dart:604
E/flutter (12347): #5      _InkResponseState._handleTap
package:flutter/…/material/ink_well.dart:654
E/flutter (12347): #6      _InkResponseState.build.<anonymous closure>
package:flutter/…/material/ink_well.dart:729
E/flutter (12347): #7      GestureRecognizer.invokeCallback
package:flutter/…/gestures/recognizer.dart:182
E/flutter (12347): #8      TapGestureRecognizer._checkUp
package:flutter/…/gestures/tap.dart:365
E/flutter (12347): #9      TapGestureRecognizer.handlePrimaryPointer
package:flutter/…/gestures/tap.dart:275
E/flutter (12347): #10     PrimaryPointerGestureRecognizer.handleEvent
package:flutter/…/gestures/recognizer.dart:455
E/flutter (12347): #11     PointerRouter._dispatch
package:flutter/…/gestures/pointer_router.dart:75
E/flutter (12347): #12     PointerRouter.route
package:flutter/…/gestures/pointer_router.dart:102
E/flutter (12347): #13     GestureBinding.handleEvent
package:flutter/…/gestures/binding.dart:218
E/flutter (12347): #14     GestureBinding.dispatchEvent
package:flutter/…/gestures/binding.dart:198
E/flutter (12347): #15     GestureBinding._handlePointerEvent
package:flutter/…/gestures/binding.dart:156
E/flutter (12347): #16     GestureBinding._flushPointerEventQueue
package:flutter/…/gestures/binding.dart:102
E/flutter (12347): #17     GestureBinding._handlePointerDataPacket
package:flutter/…/gestures/binding.dart:86
E/flutter (12347): #18     _rootRunUnary  (dart:async/zone.dart:1136:13)
E/flutter (12347): #19     _CustomZone.runUnary  (dart:async/zone.dart:1029:19)
E/flutter (12347): #20     _CustomZone.runUnaryGuarded  (dart:async/zone.dart:931:7)
E/flutter (12347): #21     _invoke1  (dart:ui/hooks.dart:263:10)
E/flutter (12347): #22     _dispatchPointerDataPacket  (dart:ui/hooks.dart:172:5)

flutter doctor
> Doctor summary (to see all details, run flutter doctor -v):
> [√] Flutter (Channel stable, v1.9.1+hotfix.2, on Microsoft Windows [Version 10.0.17763.678], locale en-US)
> [√] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
> [√] Android Studio (version 3.4)
> [√] VS Code (version 1.38.0)
> [√] Connected device (1 available)
>
> • No issues found!

I have a similar problem.  Image picker stopped returning images after upgrading to 1.9.
It works in debug mode, but not in release mode.  Here's a simple test you can run that we used to duplicate the problem.  We're running this on a Pixel 3A with Android 10.
import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Image Picker',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: Test(),
    );
  }
}

class Test extends StatefulWidget {
  Test({Key key}) : super(key: key);

  @override
  _TestState createState() => _TestState();
}

class _TestState extends State<Test> {

  List<String> _images = new List<String>();

  @override
  Widget build(BuildContext context) {

    return Scaffold(
      body: GridView.builder(
        itemCount: _images.length,
        gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
          crossAxisCount: 3,
        ),
        itemBuilder: (BuildContext context, int index) {

          return Container(
            padding: const EdgeInsets.all(2),
            child: Image.asset(_images[index], fit: BoxFit.cover)
          );
        },
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {
          ImagePicker.pickImage(source: ImageSource.gallery).then((image) {
            if (image != null) {
              setState(() {
                _images.add(image.path);
              });
            }
          });
        },
      ),
    );
  }
}

issue got solved
issue was caused because of flutter_upi library

but the point here to note is there were no related error messages being generated while either building the app or while runtime

I solved this issue by just removing the code/functionality step by step which I added in backwards manner.
you can close this issue but I think the text highlighted can play part which needs to be solved.

Closing as asked, the issue is referenced to the similar one.

@VickySalunkhe Please provide  a small self-contained app that demonstrates the problem. You can include small examples inline if they're enclosed by backticks, or just provide a public link to a github "gist" - https://gist.github.com/.

hi @BondarenkoStas  is your app working with android 10, while using image_picker plugin

Any Update?

So for me, turns out that i had another event listener on the button i was trying to use to trigger the image_picker, took of the listener and it worked for me

@egorikem
for many people this worked
try adding requestLegacyExternalStorage="true" under <Application> tag in Manifest file
well that didn't help me resolve the image_picker issue to pick image on Android 10 devices.
What I did is downgraded targetSdkVersion and compileSdkVersion to 28 from 29 I the gradle file
and that worked for me.
Meanwhile please Flutter team have a look at this issue as due to growing Android 10 devices count this issue is getting big day by day.

the same issue

same issue with image_picker on Android 10:
Bug Report
on Android 10 camera does not open and i got this exception:

W/System.err( 7172): java.io.IOException: No such file or directory
W/System.err( 7172): at java.io.UnixFileSystem.createFileExclusively0(Native Method)
W/System.err( 7172): at java.io.UnixFileSystem.createFileExclusively(UnixFileSystem.java:317)
W/System.err( 7172): at java.io.File.createTempFile(File.java:2018)
W/System.err( 7172): at com.sangcomz.fishbun.util.CameraUtil.createImageFile(CameraUtil.java:64)
W/System.err( 7172): at com.sangcomz.fishbun.util.CameraUtil.takePicture(CameraUtil.java:31)
W/System.err( 7172): at com.sangcomz.fishbun.ui.album.AlbumController.takePicture(AlbumController.java:151)
W/System.err( 7172): at com.sangcomz.fishbun.ui.album.AlbumActivity$1.onClick(AlbumActivity.java:105)
W/System.err( 7172): at android.view.View.performClick(View.java:7125)
W/System.err( 7172): at android.view.View.performClickInternal(View.java:7102)
W/System.err( 7172): at android.view.View.access$3500(View.java:801)
W/System.err( 7172): at android.view.View$PerformClick.run(View.java:27336)
W/System.err( 7172): at android.os.Handler.handleCallback(Handler.java:883)
W/System.err( 7172): at android.os.Handler.dispatchMessage(Handler.java:100)
W/System.err( 7172): at android.os.Looper.loop(Looper.java:214)
W/System.err( 7172): at android.app.ActivityThread.main(ActivityThread.java:7356)
W/System.err( 7172): at java.lang.reflect.Method.invoke(Native Method)
W/System.err( 7172): at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
W/System.err( 7172): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

same issue
image_picker: 0.6.6+1

I thinks this issue is mainly because of the compiledsdkversion, as the image_picker compiledsdkversion is 28. For android 10 it should require the compiledsdkversion 29

To sum up:

changing the version number from 28 to 29 does not correct the problem. even upgrade to 30...
the problem occurs in flutter version 1.19 and above

On the stable channel we have flutter versions 1.17.5 which unfortunately does not work with some libraries.
Example:
Because cached_network_image 2.3.0-rc requires Flutter SDK version >=1.19.0-2.0.pre <2.0.0 and no versions of cached_network_image match >2.3.0-rc <3.0.0, cached_network_image ^2.3.0-rc is forbidden.
So, because fanroom depends on cached_network_image ^2.3.0-rc, version solving failed.
Any ideas?

To sum up:

changing the version number from 28 to 29 does not correct the problem. even upgrade to 30...
the problem occurs in flutter version 1.19 and above

On the stable channel we have flutter versions 1.17.5 which unfortunately does not work with some libraries.
Example:
Because cached_network_image 2.3.0-rc requires Flutter SDK version >=1.19.0-2.0.pre <2.0.0 and no versions of cached_network_image match >2.3.0-rc <3.0.0, cached_network_image ^2.3.0-rc is forbidden.
So, because fanroom depends on cached_network_image ^2.3.0-rc, version solving failed.
Any ideas?

Did you try to upgrade android project to plugin api v2?

@just-kip Tried, the same

My better suggestion is to use your own channel to pick the image from native instead of using the third-party libraries, because sometimes you may get the plugin issues which will not be resolved and need to be waited until the plugin gets updated. Recently i faced the Permissions issue in flutter where i'm using permission_handler and the image_picker, the permission_handler i have used for microphone access, where as the image_picker will have their own permission checker. So when we include both the libraries in the project only one library will work because of the Override method of OnRequest and OnActivity.
The image_picker works for android 10 only in debug mode.
If anybody want i can provide the code for picking the image using own channel

I am having the same issue.
Is there a fix for this?

Im also facing the same issue. if any one having workaround for this issue?

Any fixes ? The image_picker works for android 10 only in debug mode ?

@a-elhaddad Correct, works on debug mode

yes I experienced the same thing in Image_picker only works for android 10 in debug mode?

@Sohi2795 Can you please guide me how to pick the image from camera using platform channel?

@DharmeshBasapati First create a channel
MethodChannel _channel = const MethodChannel('channel_name');
Next Invoke the channel to call the function in native side(android/ios)
var image = await _channel.invokeMethod('camera');
configure the flutter engine in native, next you need to check for channel name('camera'). If matches then check for permissions(Note :  Don't use multiple permission libraries, because of the conflits)
. Every time you need to send the result after invoking the channel, otherwise it will throws error.
private fun checkPermissionCamera() {
if (ActivityCompat.checkSelfPermission(context, Manifest.permission.CAMERA) != PackageManager.PERMISSION_GRANTED
&& ActivityCompat.checkSelfPermission(context, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED
&& ActivityCompat.checkSelfPermission(context, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
ActivityCompat.requestPermissions(activity, arrayOf(Manifest.permission.CAMERA,
Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE), MY_PERMISSIONS_REQUESTS_CAMERA)
} else if (ActivityCompat.checkSelfPermission(context, Manifest.permission.CAMERA) != PackageManager.PERMISSION_GRANTED) {
ActivityCompat.requestPermissions(activity, arrayOf(Manifest.permission.CAMERA), MY_PERMISSIONS_REQUESTS_CAMERA)
} else if (ActivityCompat.checkSelfPermission(context, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED
&& ActivityCompat.checkSelfPermission(context, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
        ActivityCompat.requestPermissions(activity, arrayOf(
                Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE), MY_PERMISSIONS_REQUESTS_CAMERA)

    } else{
        captureImage()
    }
}

private fun captureImage() {
val intent = Intent(MediaStore.ACTION_IMAGE_CAPTURE)
val file: File = CameraUtils.getOutputMediaFile(MEDIA_TYPE_IMAGE)
if (file != null) {
imageStoragePath = file.getAbsolutePath()
}
val fileUri: Uri = CameraUtils.getOutputMediaFileUri(applicationContext, file)
intent.putExtra(MediaStore.EXTRA_OUTPUT, fileUri)
    // start the image capture Intent
    startActivityForResult(intent, CAMERA_CAPTURE_IMAGE_REQUEST_CODE)
}

In onActivityResult return result
CameraUtils.refreshGallery(getApplicationContext(), imageStoragePath)
if(check(imageStoragePath)){
pendingHintResult?.success(imageStoragePath)
}else{
pendingHintResult?.success("denied")
}

@DharmeshBasapati First create a channel
MethodChannel _channel = const MethodChannel('channel_name');
Next Invoke the channel to call the function in native side(android/ios)
var image = await _channel.invokeMethod('camera');
configure the flutter engine in native, next you need to check for channel name('camera'). If matches then check for permissions(Note : Don't use multiple permission libraries, because of the conflits)
. Every time you need to send the result after invoking the channel, otherwise it will throws error.
    private fun checkPermissionCamera() {
            if (ActivityCompat.checkSelfPermission(context, Manifest.permission.CAMERA) != PackageManager.PERMISSION_GRANTED
                    && ActivityCompat.checkSelfPermission(context, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED
                    && ActivityCompat.checkSelfPermission(context, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {
                ActivityCompat.requestPermissions(activity, arrayOf(Manifest.permission.CAMERA,
                        Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE), MY_PERMISSIONS_REQUESTS_CAMERA)
            } else if (ActivityCompat.checkSelfPermission(context, Manifest.permission.CAMERA) != PackageManager.PERMISSION_GRANTED) {
                ActivityCompat.requestPermissions(activity, arrayOf(Manifest.permission.CAMERA), MY_PERMISSIONS_REQUESTS_CAMERA)
            } else if (ActivityCompat.checkSelfPermission(context, Manifest.permission.WRITE_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED
                    && ActivityCompat.checkSelfPermission(context, Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) {

                ActivityCompat.requestPermissions(activity, arrayOf(
                        Manifest.permission.WRITE_EXTERNAL_STORAGE, Manifest.permission.READ_EXTERNAL_STORAGE), MY_PERMISSIONS_REQUESTS_CAMERA)

            } else{
                captureImage()
            }
        }

  private fun captureImage() {
          val intent = Intent(MediaStore.ACTION_IMAGE_CAPTURE)
          val file: File = CameraUtils.getOutputMediaFile(MEDIA_TYPE_IMAGE)
          if (file != null) {
              imageStoragePath = file.getAbsolutePath()
          }
          val fileUri: Uri = CameraUtils.getOutputMediaFileUri(applicationContext, file)
          intent.putExtra(MediaStore.EXTRA_OUTPUT, fileUri)

          // start the image capture Intent
          startActivityForResult(intent, CAMERA_CAPTURE_IMAGE_REQUEST_CODE)
      }

      In onActivityResult return result
      CameraUtils.refreshGallery(getApplicationContext(), imageStoragePath)
                          if(check(imageStoragePath)){
                              pendingHintResult?.success(imageStoragePath)
                          }else{
                              pendingHintResult?.success("denied")
                          }

Thanks for the detailed code. I will try to implement it and let you know.

@Sohi2795 could you provide the code for custom image picker?

@Sohi2795 could you provide the code for custom image picker?

@karambitmonger find the example https://github.com/Sohi2795/flutter_image_picker

Is there any fix? I am facing this issue.

Is there any fix? I am facing this issue.

What i did was to change the build Gradle  to 3.5.0 in AndroidManifest.xml and the classpath and it worked for me.
I guess imagepicker haven't updated the package to the latest Android Gradle version.

Hello Everyone,
I verified this issue going by the title (Fail to pick image using image_picker plugin On Android 10 ) on latest stable (1.22.6) using Samsung S10 device and official image_picker plugin repo. I was able to pick image from gallery as well as different options from drawer in debug and in release mode.
https://user-images.githubusercontent.com/67046386/107506100-9e167a00-6bc3-11eb-8a14-a9bba8e4fbc5.mp4

flutter doctor -v

[✓] Flutter (Channel stable, 1.22.6, on Mac OS X 10.15.4 19E2269 darwin-x64, locale
    en-IN)
    • Flutter version 1.22.6 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 9b2d32b605 (3 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.53.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.18.1

[✓] Connected device (1 available)
    • SM G975F (mobile) • RZ8M802WY0X • android-arm64 • Android 10 (API 29)

! Doctor found issues in 1 category.

I am going ahead and closing this as not producible and probably fixed in latest plugin version, since it has gone through many bug fixes and features since this issue was filed.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs, and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.

for me this error still exist - using
• Flutter version 1.22.6 at /Users/michaelspeed/flutter     • Framework revision 9b2d32b605 (4 weeks ago), 2021-01-22 14:36:39 -0800     • Engine revision 2f0af37152     • Dart version 2.10.5


release v0.1.5

https://github.com/golang/tools/compare/v0.1.4...v0.1.5

fixed https://github.com/kamilsk/go-tools/releases/tag/v0.1.5


Obtaining image ID after a build

Currently, there's no real way (other than tagging or parsing server output manually) to get what the final image ID of a successful build is. This is quite annoying, and it should be possible to have a field in types.ImageBuildResponse -- we'd just need to append to the end of the build output a JSON object describing the final ImageID. Or we'll have to implement build IDs.

Not near my computer to verify which flag but we recently added a -s flag, I think, which will return just the build/image id
-Doug
Sent from my iPad

On Jan 17, 2016, at 2:57 AM, Aleksa Sarai<EMAIL_ADDRESS>wrote:
Currently, there's no real way (other than tagging or parsing server output manually) to get what the final image ID of a successful build is. This is quite annoying, and it should be possible to have a field in types.ImageBuildResponse -- we'd just need to append to the end of the build output a JSON object describing the final ImageID. Or we'll have to implement build IDs.
—
Reply to this email directly or view it on GitHub.

I take that back , I forgot that we "fixed" -q instead of added -s.  Using -q will JUST return the image ID upon success, nothing to parse.

@duglin Cheers. I didn't know that.


Create fkit.hr.txt

pls add fkit.hr, this program would help me a lot with studying

@Vpetric fkit.hr.txt I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!


Filter out invalid indices in nearest neighbor search results

Codecov Report

Merging #322 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   95.64%   95.71%   +0.06%
==========================================
  Files          61       61
  Lines        3539     3595      +56
==========================================
+ Hits         3385     3441      +56
  Misses        154      154

Impacted Files
Coverage Δ

packages/Search/test/tstLinearBVH.cpp
99.23% <ø> (-0.01%)
:arrow_down:

...c/details/DTK_DetailsDistributedSearchTreeImpl.hpp
98.86% <100%> (ø)
:arrow_up:

packages/Search/src/details/DTK_DetailsUtils.hpp
100% <100%> (ø)
:arrow_up:

packages/Search/test/tstDetailsUtils.cpp
100% <100%> (ø)
:arrow_up:

packages/Search/src/DTK_LinearBVH_decl.hpp
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef8e0e7...4f2b1ad. Read the comment docs.


helm: no operator hostPorts when hostNetwork is disabled

Fixes: fbe159f52ba6b3742db723f6350b45ef9a1659d6 ("helm: possibility to disable hostNetwork for operator")
My previous PR implementing configurable host network for operator missed hostPort parameter in prometheus port definition. Operator worked fine without this but cluster nodes we quickly depleted as, with this setting, just one operator pod per node is allowed. This PR omits hostPort parameter when host network is disabled.

/test


update jopa container

Description
This PR adds two Dockerfiles to build the jopa container in two steps.
In the first step, the container is built using Dockerfile.jopa-gnu-ompi-base. This file is mainly based on the old Dockerfile.jopa-gnu-ompi-dev with all jedi-stack libraries removed.
In the second step, jedi-stack@feature/jopa-container, shumlib, faux, and trans will be built in the second layer on top of the base container.
Issue(s) addressed

fixes https://github.com/JCSDA-internal/ops-um-jedi/issues/132
fixes https://github.com/JCSDA-internal/docker/issues/54

Acceptance Criteria (Definition of Done)
Users be able to build the base and ci containers using the Dockerfiles
The new container is uploaded to AWS ECR (with limited access) and is used in CodeBuild now.
Dependencies
None
Impact
None

CMake needs an update to 3.18, so I need to recreate the container: https://github.com/orgs/JCSDA-internal/teams/jedi-core/discussions/14
Please let me know if I need to change the Shumlib branch as well.

@mer-a-o Thanks. Recommend that you get shumlib from https://github.com/metomi/shumlib. The repo mirrors the stable releases from MOSRS, (with site-specific make/*.mk removed). You can download the latest stable release 2021.10.1 from this link https://github.com/metomi/shumlib/archive/refs/tags/2021.10.1.tar.gz - no credentials required. Hopefully, this will help simplify your build recipe.

I created a new container with cmake 3.19 and Shumlib stable release 2021.10.1. Dockerfiles in this branch are updated as well. CI is now using this new container.

@ss421 Are you ok with these changes or is there more work needed from your perspective?

@ss421 Are you ok with these changes or is there more work needed from your perspective?

Yes I am. Thanks for making the update @mer-a-o.

@ss421 Are you ok with these changes or is there more work needed from your perspective?

Yes I am. Thanks for making the update @mer-a-o.

Thanks for confirming!


[ADD ME TO THE ORGANIZATION]

Name: Kelvin Parmar
Location: Rajkot, Gujrat
Interest: DevOps , Web Development
Discord username(optional):- Kelvin parmar #3581
Why do you want to join?

I want to join because I want to give back to community which I have learnt and also learn with people and make connections with them also.

You can also join our Discord community here
Feel free to check out other cool repositories of the DevsInTech Community here.

@kelvinparmar Thanks for your interest. Invitations have been sent to you. Kindly accept it and make your membership public.


guayadeque: init at 0.4.7

Description of changes
resolves https://github.com/NixOS/nixpkgs/issues/236809
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@Zahrun Please test

Thank you @Aleksanaa for the packaging!
I can’t seem to play audio files though
07:14:27 AM IST: Error saving the configuration file '/home/aroun/.guayadeque/guayadeque.conf'
07:14:33 AM IST: Loading '/home/aroun/Music/Demo/1-01 Fantasia super Komm heiliger Geist, BWV 651.mp3'
07:14:33 AM IST: Error: The configured audio output sink is not valid.

Cool

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 237007

aarch64-linux

:white_check_mark: 1 package built:

guayadeque

Can't play any music, seems some dependencies missing. https://github.com/thothix/guayadeque/blob/master/INSTALL.md#arch-linux


model_serializer in "wrap" mode called twice when model_dump called with serialize_as_any=True

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
When using model_serializer decorator in wrap mode for a custom serializer, model_dump with serialize_as_any=True will run/wrap the handler twice with my custom model serializer for some reason.
In my example, I'm just adding a suffix to the dict keys to demonstrate the bug, and you can see the suffix is added twice, so the custom serializer wraps the handler twice.
Note: I am not using any subclass in my example, to show that it always happens with serialize_as_any=True, regardless of the field types used.
Example Code
from pydantic import BaseModel, model_serializer

class InnerModel(BaseModel):
    an_inner_field: int

class MyModel(BaseModel):
    a_field: InnerModel

    @model_serializer(mode="wrap")
    def a_model_serializer(self, handler, info):
        return {k + "_wrapped": v for k, v in handler(self).items()}

instance = MyModel(a_field=InnerModel(an_inner_field=1))
print(instance.model_dump(serialize_as_any=True))
# we get:
# {'a_field_wrapped_wrapped': {'an_inner_field': 1}}

Python, Pydantic & OS Version
pydantic version: 2.8.2
        pydantic-core version: 2.20.1
          pydantic-core build: profile=release pgo=false
                 install path: /home/me/micromamba/envs/my_env/lib/python3.11/site-packages/pydantic
               python version: 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:36:13) [GCC 12.3.0]
                     platform: Linux-4.15.0-175-generic-x86_64-with-glibc2.27
             related packages: mypy-1.10.1 typing_extensions-4.12.2
                       commit: unknown

@davidpapazian,
Thanks for the report. Definitely looks like a bug.


randomAlphanumeric(30) returns a string of 31 chars

Hi Zen,
Was using this package today and strangely the randomAlphanumeric(30) is returning 31 chars.
Eg: eYuerqcSz8WPWG3kUOP1kUyVPR9jnBJ
Can you double check what might be happening?
Thanks for this lib 👍

Hi @tiagoicp, thanks for pointing this out.
There was a bug in text module, fixed in 0.2.1


Preparations to switch to APK package manager

Hi all, some fellow developers and me worked for some time now on making APK the new package manager for OpenWrt, replacing the unmaintained OPKG fork we've been using for the longest time.
APK is actively developed and used in multiple other distributions, e.g. Alpine Linux 🎉
While there is till some work ahead, I'd like to prepare everyone who maintains a package to verify that the PKG_VERSION follows Semantic Versioning. APK uses a deterministic algorithm to compare versions and does not like random strings, except a valid hash prefixed with a ~.
If in doubt, please use the Docker container below to verify the used version is valid:
docker run --rm -it docker.io/aparcar/apk-version-check <VERSION> [<VERSION> ...]

It will print whatever version is not valid, if you get a zero exit code, you're fine.
Please feel free to reach out for assistance and have a look at the core migration of versions.

Below packages that would cause trouble. Please bear in mind that PKG_RELEASE is soonish prefixed with an r and may only contain a number.
Naughty list:

[ ] luci-app-adblock-fast            1.1.1-5
[ ] luci-app-advanced-reboot         1.0.1-9
[ ] luci-app-dockerman               v0.5.13-20240317
[ ] luci-app-https-dns-proxy         2023-11-19-1
[ ] luci-app-pbr                     1.1.1-7
[ ] luci-proto-nebula                1.6.1-1

@aparcar I can pre-emptively add r to the revisions, I just wanted to confirm that it will not break opkg upgrade logic. For example, would opkg consider 1.1.1-r6 higher version than 1.1.1-5?

would opkg consider 1.1.1-r6 higher version than 1.1.1-5? Same question for 2023.11.19-r2 and 2023-11-19-1.

Easiest is to bump the main version to 1.1.2 at the same time
(not sure about the date comparison with a changed separator)

@aparcar I can pre-emptively add r to the revisions, I just wanted to confirm that it will not break opkg upgrade logic. For example, would opkg consider 1.1.1-r6 higher version than 1.1.1-5? Same question for 2023.11.19-r2 and 2023-11-19-1.

Does opkg even do that? I'm under the impression that it does not compare versions.
See parse_version and compare
You could do away with 1.1.1-r6 altogether and just let git handle semantic versioning (at least for the time being), or use dates instead. For devs, the tip of the master branch is latest, for users, if it is updated, it will show as update available.

@aparcar
@feckert: date format here makes most sense. We won't be updating lua apps (this app is lua) any more so this change should be OK. Alt: update at source? https://github.com/lisaac/luci-app-dockerman

[ ] luci-app-dockerman               v0.5.13-20240317

docker run --rm -it docker.io/aparcar/apk-version-check  [ ...]

BTW:
sudo docker run --rm -it docker.io/aparcar/apk-version-check 1.1.1-5
Unable to find image 'aparcar/apk-version-check:latest' locally
latest: Pulling from aparcar/apk-version-check
bca4290a9639: Pull complete
1ae19ff60baf: Pull complete
75e05e2c02ea: Pull complete
28c83907721f: Pull complete
Digest: sha256:e113fde83c649c3dc7cfed9b7e6c2068b94aad61f950cf9f0bfd93d9bcf69c86
Status: Downloaded newer image for aparcar/apk-version-check:latest
WARNING: The requested image's platform (linux/arm64/v8) does not match the detected host platform (linux/amd64/v2) and no specific platform was requested
exec /usr/bin/apk: exec format error

@stangri I added a multi arch container here ghcr.io/aparcar/apk-valid-version

For example, would opkg consider 1.1.1-r6 higher version than 1.1.1-5? Same question for 2023.11.19-r2 and 2023-11-19-1.

root@OpenWrt:~# opkg compare-versions 1.1.1-r6 '>' 1.1.1-5 && echo true || echo false
true
root@OpenWrt:~# opkg compare-versions 2023.11.19-r2 '>' 2023-11-19-1 && echo true || echo false
true
root@OpenWrt:~# opkg compare-versions 1 '>' r1 && echo true || echo false
false
root@OpenWrt:~# opkg compare-versions r1 '>' 1 && echo true || echo false
true
root@OpenWrt:~#

Thank you @aparcar @hnyman @jow-!
PRs with fixes:

luci-app-adblock-fast: https://github.com/openwrt/luci/pull/7009
luci-app-advanced-reboot: https://github.com/openwrt/luci/pull/7010
luci-app-https-dns-proxy: https://github.com/openwrt/luci/pull/7013
luci-app-pbr: https://github.com/openwrt/luci/pull/7011
luci-proto-nebula: https://github.com/openwrt/luci/pull/7012

@feckert - how is dockerman update coming along?

Status of dockerman will this be ready on 24.x

@stangri latest luci-app-advanced-reboot fails to build with CONFIG_USE_APK=y
ERROR: info field 'version' has invalid value: package version is invalid

@aparcar
I started looking into trying to convert luci-app-opkg to a crude initial luci-app-apk, but stumbled rather quickly into trouble. The apk package info is formatted so differently than opkg, that the LuCI app requires major javascript work to even get it to read the available packages list and install new packages.
One challenge will be that our apk seems to produce rather small amount of information for available packages with "apk list -a" (and for installed ones with "apk list -I")
In style of
root@router6000:~# apk list -a
adblock-4.2.2-r3 all {feeds/packages/net/adblock} (GPL-3.0-or-later) [installed]
apk-openssl-3.0.0_pre20240806-r1 aarch64_cortex-a53 {feeds/base/system/apk} (GPL-2.0-only) [installed]
arptables-nft-1.8.8-r2 aarch64_cortex-a53 {feeds/base/network/utils/iptables} (GPL-2.0)
...
wifi-scripts-1.0-r1 all {feeds/base/network/config/wifi-scripts} (GPL-2.0) [installed]
wireguard-tools-1.0.20210914-r3 aarch64_cortex-a53 {feeds/base/network/utils/wireguard-tools} (GPL-2.0) [installed]
wireless-regdb-2024.07.04-r1 all {feeds/base/firmware/wireless-regdb} (ISC) [installed]
wpad-openssl-2024.03.09~695277a5-r3 aarch64_cortex-a53 {feeds/base/network/services/hostapd} (BSD-3-Clause) [installed]
xdp-filter-1.4.2-r1 aarch64_cortex-a53 {feeds/base/network/utils/xdp-tools} (GPL-2.0-only)
xdp-loader-1.4.2-r1 aarch64_cortex-a53 {feeds/base/network/utils/xdp-tools} (GPL-2.0-only)

Trouble starts already with package name and version being shown in combined form. I have not yet figured a way to have those listed separately by apk list. We might need to assume some regexp like ^([\w-]+)-(\d[\w\.\-~]*) (.[\w\-]*) (.*) (\(.*\))( \[installed\])*$ to parse the attributes from the single line into fields. Big change compared to opkg where each field was on its own row with a label.
Ps. Is there any support for OpenWrt specific definitions like essential, hold, etc.?  "apk info -a" for an individual package shows more details, but so far I have not seen any OpenWrt specific attributes.

I haven't seen any news about it but do we know if 24.x will default to using APK? In that case we still need to fix luci-app-dockerman's version string, it's quite a popular app as well, shows up time to time on the form.

I haven't seen any news about it but do we know if 24.x will default to using APK? In that case we still need to fix luci-app-dockerman's version string, it's quite a popular app as well, shows up time to time on the form.

This seems to be unmaintained for more than a year.

So how about <IP_ADDRESS>40317? That seems like it would work, but the current installs may not recognise this 'version' jump, and might require a forced reinstall. Acceptable compromise I think.

The /etc/config/luci file is broken, it should contain a set of theme entries that are added when a luci-theme-* package is installed.
root@OpenWrt:~# cat /etc/config/luci
config core main
        option lang auto
        option mediaurlbase /luci-static/bootstrap
        option resourcebase /luci-static/resources
        option ubuspath /ubus/

config extern flash_keep
        option uci              "/etc/config/"
        option dropbear "/etc/dropbear/"
        option openvpn  "/etc/openvpn/"
        option passwd   "/etc/passwd"
        option opkg             "/etc/opkg.conf"
        option firewall "/etc/firewall.user"
        option uploads  "/lib/uci/upload/"

config internal languages

config internal sauth
        option sessionpath "/tmp/luci-sessions"
        option sessiontime 3600

config internal ccache
        option enable 1

config internal themes

config internal apply
        option rollback 90
        option holdoff 4
        option timeout 5
        option display 1.5

Maybe there's a different reason, but I'm guessing apk sets the $PKG_UPGRADE to 1 and/or the entire uci-defaults script fails.
@AzimsTech if you can verify that the theme apk binaries contain the uci-defaults scripts that would be a good start.

@stangri I get it now. I just need to reboot for the configuration to apply. I was not aware on how it works at first. I'm sorry for the false alarm. 🙏

Just wanted to report that on a recent snapshot the apk for statistics has some missing icons.  See attached.

statistics has some missing icons

Nothing to do with apk. That is about mis-detected temperature sensors.
Just define correctly the sensors in your system that actually do provide temperature info.

I can pick just one zone and those images are still not valid.

The icons get created if there is old/incompatible RRD files.
You may have to remove the old RRD database files, if they do not match the current sensors or do not provide data.
But again, not related to apk. Just about LuCI statistics being rather simplistic.


File allocation error ?

Steps to Reproduce
(1) The cfile is :
#include <stdio.h>
#include <fcntl.h>
#include <unistd.h>
#include <sys/stat.h>

int main() {
    const char* file_name = "Data/hello.txt";
    int open_style= O_CREAT | O_RDWR;
    int fd = get_fd(file_name, open_style);
    fd_allocateLuGpoE0tKi(fd, file_name);
    snapshot(fd);
    return 0;
}

int fd_allocateLuGpoE0tKi (int fd, const char* file_name){
    off_t start_value = 19;
    off_t len_value = 39;
    return fd_allocate(fd, file_name, start_value, len_value);
}

int get_fd(const char* file_name, int open_style){
    // Open a file for reading
    int fd = open(file_name, open_style);
    if (fd == -1) {
        perror("Failed to open the file");
        return 1;
    }

    return fd;
}

int fd_allocate (int fd, const char* filename, off_t start_value, off_t len_value){
    if (posix_fallocate(fd, start_value, len_value) != 0) {
        perror("Error allocating file space");
        close(fd);
        return 1;
    }

    printf("File '%s' created and allocated with %lld bytes of space.\n", filename, (long long)len_value);
    return fd;
}

int snapshot(int myfd){
    printf("Enter snapshot\n");

    struct stat file_info;
    if (fstat(myfd, &file_info) == -1) {
        perror("Error getting file attributes");
        close(myfd);
        return 1;
    }

    printf("File Size: %lld bytes \n", (long long)file_info.st_size);
    printf("File Permissions: %o \n", file_info.st_mode & ~S_IFMT);
    printf("File Owner UID: %d \n", file_info.st_uid);
    printf("File Group GID: %d \n", file_info.st_gid);

    off_t cur_offset = lseek(myfd, 0, SEEK_CUR);
    if (cur_offset == -1) {
        perror("Error getting current offset");
    }
    printf("Current offset: %lld \n", (long long)cur_offset);

    if (close(myfd) == -1) {
        perror("Error closing file");
        return 1;
    }

    printf("Leave snapshot\n");
}

(2)compile the c file into wasm: ./wasi-sdk-16.0/bin/clang --target=wasm32-unkown-wasi --sysroot=./wasi-sdk-16.0/share/wasi-sysroot test1.c -o test1.wasm
(3)exeute open.wasm
wasmtime run  --dir=./Data test1.wasm
The permission of Data/hello.txt is 0600 or 0700, user1 create the Data/hello.txt file before and user1 execute the Wasm file.
Expected Results
Other runtime print:
File 'Data/hello.txt' created and allocated with 39 bytes of space.
Enter snapshot
File Size: 58 bytes
File Permissions: 0
File Owner UID: 0
File Group GID: 0
Current offset: 0
Leave snapshot

And the file size is change into 58.
And using gcc test1.c -o test1 and ./test1 to execute also get this result.
Actual Results
wasmtime prints:
Error allocating file space: Success
Enter snapshot
Error getting file attributes: Bad file descriptor

And file size remains 30.
Versions and Environment
wasmtime 13.0.0
Operating system: Ubuntu 20.04
Architecture: x86_64

Thanks for the report! The reason this is happening is that fd_allocate is no longer supported. That's being removed from WASI and Wasmtime has preemptively adapted to the latest version of WASI. Other runtimes haven't caught up yet I suspect.

Thanks for your reply. How can I view the changes in WASI compared to before? Is there any documentation? Thank you!

You can follow the https://github.com/WebAssembly/WASI repository, but I don't believe changes are exhaustively mentioned yet. Such processes evolve over time and aren't present immediately.

Thanks !


When will XSQL support Spark 3.x ?

When will XSQL support Spark 3.x ?

It's known that Spark 3.x provide an interface called CatalogPlugin. We have done the same things as XSQL based on CatalogPlugin in another private project. You can learn something from this blog: https://mp.weixin.qq.com/s/mZpvFRwO2xb5j7c5_ZARTQ.

So there is no plan to make XSQL support Spark 3.x, because you fully embrace CatalogPlugin and DatasourceV2 within your private project right now ?

Sorry, but you can think so.

OK, thanks


proposal: testing/slogtest: move to log/slog/slogtest

I never saw this package mentioned in the slog proposal or elsewhere. Hopefully this isn't too late.
Test helpers should be with/near their packages, not put underneath the testing package. This makes these helpers more discoverable and easier to understand.
Assuming the idea of a new package for just this one function is still open to debate, instead of the above, I propose this package be merged into log/slog. A single function doesn't merit its own package, in my opinion. Test helpers belong with the code they're helping out with.

Just found iotest and fstest. This seems unlike to be accepted, so closing.


Feature: Add a daily "what weird day is it" announcement

At midnight or so the bot would say what celebratory day it is.
e.g for today it would say something like
Today is National Lima Bean Respect Day

https://www.timeanddate.com/holidays/fun/
good list I found

Is someone working on this?

Nice one @ldgrp


remove hypershift CRDs

Signed-off-by: Roke Jung<EMAIL_ADDRESS>Remove hypershift CRDs so that these are not installed by MCE. These CRDs will be installed by the hypershift managed cluster addon.

/lgtm


HDFS-16004.startLogSegment and journal in BackupNode lack Permission …

I have some doubt when i configurate secure HDFS.  I know we have Service Level Authorization  for protocols like NamenodeProtocol,DatanodeProtocol and so on.
But i do not find such Authorization   for JournalProtocol after reading the code in HDFSPolicyProvider.  And if we have, how can i configurate such Authorization?
Besides  even NamenodeProtocol has Service Level Authorization, its methods still have Permission check. Take startCheckpoint in NameNodeRpcServer who implemented NamenodeProtocol  for example:
public NamenodeCommand startCheckpoint(NamenodeRegistration registration)
throws IOException {
String operationName = "startCheckpoint";
checkNNStartup();
namesystem.checkSuperuserPrivilege(operationName);
......
I found that the methods in  BackupNodeRpcServer who implemented JournalProtocol  lack of such  Permission check. See below:
public void startLogSegment(JournalInfo journalInfo, long epoch,
    long txid) throws IOException {
  namesystem.checkOperation(OperationCategory.JOURNAL);
  verifyJournalRequest(journalInfo);
  getBNImage().namenodeStartedLogSegment(txid);
}

@Override
public void journal(JournalInfo journalInfo, long epoch, long firstTxId,
    int numTxns, byte[] records) throws IOException {
  namesystem.checkOperation(OperationCategory.JOURNAL);
  verifyJournalRequest(journalInfo);
  getBNImage().journal(firstTxId, numTxns, records);
}

Do we need add Permission check for them?
Please point out my mistakes if i am wrong or miss something.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 38s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  1s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  2s

trunk passed

+1 :green_heart:
shadedclient
16m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 11s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 11s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 52s

the patch passed

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  7s

the patch passed

+1 :green_heart:
shadedclient
16m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
239m 55s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

326m 50s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.TestMultipleNNPortQOP

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.server.namenode.snapshot.TestNestedSnapshots

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2966/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2966

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 7df22da5b480 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 17a8bee6b558d7fdbef03307279d92f0e0df7fa5

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2966/1/testReport/

Max. process+thread count
3012 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2966/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 34s

trunk passed

+1 :green_heart:
compile
1m 20s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 24s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  4s

trunk passed

+1 :green_heart:
shadedclient
16m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 54s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m  6s

the patch passed

+1 :green_heart:
shadedclient
15m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
230m 22s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

317m 38s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.TestSecureNNWithQJM

hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2966/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2966

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 210fdd43a96b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 219aabeb13577db1dcd5d8ea796f9fa6bcbc0165

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2966/4/testReport/

Max. process+thread count
2985 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2966/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Archive lists link to about page at the very last page

I just noticed this. When inside the archive page, the very last page is the link to about page with
0001 as number for date.

Archive page shouldn't list the about page.
About page type shouldn't require a date value.

Screenshot from archive page:

Thank you for the issue! It will be fixed soon:)

Thank you for the issue! It's fixed 😋

Just checked! Thank you.


Add user search

Description
Please include a summary of the changes along with any relevant motivation and context,
or link to an issue where this is explained.

Fixes #

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (please discuss with the team first; Syft is 1.0 software and we won't accept breaking changes without going to 2.0)
[ ] Documentation (updates the documentation)
[ ] Chore (improve the developer experience, fix a test flake, etc, without changing the visible behavior of Syft)
[ ] Performance (make Syft run faster or use less memory, without changing visible behavior much)

Checklist:

[ ] I have added unit tests that cover changed behavior
[ ] I have tested my code in common scenarios and confirmed there are no regressions
[ ] I have added comments to my code, particularly in hard-to-understand sections

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#4  👈 (View in Graphite)
#3
#2
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

just trying out graphite...


⚠ Bofrost.lu has degraded performance

In dac292a, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 801 ms

Resolved: Bofrost.lu performance has improved in e32585b.


Add object kind to messages

This pull request adds the object kind of the source of the notification to the message.
The format is <kind>/<name>.<namespaces>
Fixes #120
Signed-off-by: Somtochi Onyekwere<EMAIL_ADDRESS>

Can we mimic the current implementation of the git notifications? In those providers the kind is already included and we lowercase all of the text.
 kustomization/apps-dev — reconciliation succeeded

Can we mimic the current implementation of the git notifications? In those providers the kind is already included and we lowercase all of the text.
 kustomization/apps-dev — reconciliation succeeded

Should we mimic the current implementation of the git notifications? In those providers the kind is already included and we lowercase all of the text.
 kustomization/apps-dev — reconciliation succeeded

@stefanprodan What do you think? We should definitely maintain a consistent format

Should we mimic the current implementation of the git notifications? In those providers the kind is already included and we lowercase all of the text.
 kustomization/apps-dev — reconciliation succeeded

@stefanprodan What do you think? We should definitely maintain a consistent format

Yes the kind should be lowercase, this is also consistent with kustomize-controller apply logs.

Yes the kind should be lowercase, this is also consistent with kustomize-controller apply logs.


Fix modal index position and set some width to make modal responsive …

Fix modal index position and set some width to make modal responsive to mid screen

Here the update

@all-contributors please add @Yaya12085 for bug


Automator: update<EMAIL_ADDRESS>dependency in<EMAIL_ADDRESS>

Generated by Automator - 2023-07-11T22:17:09+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio_release-1.16
2de7389bbe6f134835290e005b187cc9084c1d1a
link
true
/test integ-security-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Add Library::Config (#8)

Add Library::Config
Implement several Config setup options

I was trying to initialize spla::Library in different ways for testing purposes. But I kept getting Segmentation fault. After some investigation, I figured that it was caused by infinite recursion in spla::Unref. But it is not caused by my changes, because I have recreated this error in your branch.
Maybe we will create another issue to fix it?

I was trying to initialize spla::Library in different ways for testing purposes. But I kept getting Segmentation fault. After some investigation, I figured that it was caused by infinite recursion in spla::Unref. But it is not caused by my changes, because I have recreated this error in your branch.
Maybe we will create another issue to fix it?

To recreate just initialize spla::Library in one of the tests.

@Glebanister Have you merged latest main into your current branch? I think, this issue is fixed here commit

@Glebanister Have you merged latest main into your current branch? I think, this issue is fixed here commit

Oh, I forgot to fetch, sorry(
Now it works!


Add type annotations to default config steps

The README did not mention that TypeScript annotations were needed to get the database object to be accepted by sequelize, leading to a broken build state if one were to follow the instructions word by word.
I have updated the SQLite instructions too, as I have yet to find any regressions when using a local SQLite database as opposed to the "required" Postgres database.

Hello and thanks for making the PR,
Most of the command log/error log commands will be broken. Although core functionality might be alright.

Should I run prettier on my end, or are you doing it?

Yes, you can run ‘npm run lint` and commit the following changes.

Alright, that should be it!


Sparse grid data type

This isn't ready to merge.
In the unreleased version of Indigo, QuadTree's have been totally overhauled, in that they are now actual quad trees. https://github.com/PurpleKingdomGames/indigo/pull/666
What does that mean? It means they can accept data associated with Vertices as before, but also any of the other spatial types like a BoundingBox. Clearly a bounding box could exist in more than one quad at a time, and this has had a major impact on the design and behaviour of the QuadTree implementation. It's much better!
However, this means though that the TerminalEmulator in the RLSK, which was backed by QuadTree's, no longer works because it was using them as a sort of cheeky sparse data structure - which QuadTree's certainly are - but now you cannot meaningfully do things like replacing values since that's just not how the QuadTree implementation works, or what it's for.
So what I've done here is build a new data type called SparseGrid, which has a very similar interface to the Terminals, and is designed for storing and manipulating... sparse grids!
The TerminalEmulator is now backed by this new type.
The TerminalEmulator was always slower than the RogueTerminalEmulator - the latter's whole purpose in life is the be the speedy scary mutable version of it's safe, simple, immutable sibling. That said, a noddy performance comparison is pretty promising:

The main thing I'm left considering is whether I should move SparseGrid into Indigo itself. It's generally useful. The only snag is that I'd need to also move the Bresenham line algo too - but maybe that's ok if they both live in the extras package?

I've gone ahead and moved the Bresenham line algorithm and the SparseGrid impl to Indigo, so this work can't be merged just yet.


Jsonnet, buildpacks and kustomize support in werf

https://jsonnet.org
https://buildpacks.io
https://github.com/kubernetes-sigs/kustomize

Is there any update on the https://buildpacks.io/ support? Searched for https://github.com/werf/werf/issues?q=buildpacks and came from https://github.com/buildpacks/community/issues/99 to https://github.com/werf/werf/issues/1618, but there the https://buildah.io/ integration seems to be tracked only.

Hi! Support of buildpacks is not in the near plans as for now.
Buildpacks provide a good way to get reproducible images in your workflow. werf by itself also provides a way to get reproducible images along any step in your workflow, but in a different way, supporting more traditional imperative images declaration. We cannot now surely say that buildpacks will provide better building capabilities than werf currently provides (given that werf has another features, such as incremental images rebuilds, guarantee of images immutability in the distributed builders environment, etc.). So adding buildpacks into werf for now is an open question, which needs more arguments and reasons. We need these because supporting both buildpacks and current way to build images seems redundant and expensive.
The first argument could be: it saves time to write and maintain CI/CD configuration, by automatically generating suitable images. But it works only if buildpacks ecosystem contains suitable instructions.


Ruofan develop

Current coverage is 31.86% (diff: 23.75%)

Merging #218 into master will decrease coverage by 4.51%

@@             master       #218   diff @@
==========================================
  Files           259        321     +62
  Lines         14026      18195   +4169
  Methods           0          0
  Messages          0          0
  Branches       2347       3102    +755
==========================================
+ Hits           5102       5797    +695
- Misses         8210      11576   +3366
- Partials        714        822    +108

Powered by Codecov. Last update 3c5ee6f...e0f4ee5

@greatruofan Why are you trying to merge this into argus master branch??

@greatruofan I'm closing this, as we aren't merging from warden to argus.

Sorry, it is my mistake, I chose the wrong branch to compare when I submit
this pull request
On Mon, Oct 17, 2016 at 7:15 AM, Tom Valine<EMAIL_ADDRESS>wrote:

@greatruofan https://github.com/greatruofan I'm closing this, as we
aren't merging from warden to argus.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SalesforceEng/Argus/pull/218#issuecomment-254219673,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHigMuM2coANb94rBe6vWxYwtnAsRjdZks5q04MEgaJpZM4KXivg
.


Documentation fix | Secure boot import

Pub key is [public_key.der](https://github.com/ublue-os/akmods/raw/main/certs/public_key.der), but documentation says to sudo mokutil --import secure_boot.der

@castrojo It is correct in bluefin-docs, but wrong in https://github.com/ublue-os/bluefin/blob/4adf597525dca0533729b2eba100ea860301481e/README.md?plain=1#L56


Fix pyproject.toml formatter

Description
Currently linting step in the CI fails as in https://github.com/serverless/console/actions/runs/4240504929/jobs/7369594955#step:8:53
The problem is that new versions of pyproject-fmt is normalizing the package names and rewrites "serverless_sdk" as "serverless-sdk" and returns an error code:
 [project]
-name = "serverless_sdk"
+name = "serverless-sdk"

I've did a quick search to see if there's a better linter for pyproject.toml files but couldn't find one. Removing this linter step is another possible resolution. I've also removed the dependency for pyproject-fmt from the package as it's only required for the CI step, which installs the specific version of the package.
This fix is in https://github.com/serverless/console/pull/464 as well, I'll update that PR once we agree on a resolution.
Testing done
I've tried pyproject-fmt==0.4.1 and this version accepts underscores as in serverless_sdk.

I've found this https://peps.python.org/pep-0621/#table-name regarding the use of [project] where "name" should follow the pattern described in https://packaging.python.org/en/latest/specifications/core-metadata/#name
https://github.com/tox-dev/pyproject-fmt/issues/55 is related to the issue we have with pyproject-fmt, I don't understand why the tool is normalizing the project name and rewriting it as described in https://packaging.python.org/en/latest/specifications/name-normalization/ Because as I understand, the name metadata can use underscores as per the pattern linked above.
An example of a project using underscores: https://github.com/awslabs/aws-lambda-powertools-python/blob/develop/pyproject.toml (this one is using poetry, instead of setuptools which is what we have right now).
Sentry is using name with hyphens https://github.com/getsentry/sentry-python/blob/master/setup.py#L23
That being said, pep8 https://peps.python.org/pep-0008/#package-and-module-names mentions

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability. Python packages should also have short, all-lowercase names, although the use of underscores is discouraged.

I'm learning as we speak :) I think it makes sense to change the names in the metadata to use hyphens instead of underscores.

@selcukcihan great feedback! I also like shifting towards hyphens, as we use that in Node.js, so package names will be more alligned

@selcukcihan sorry I've just realized this change is not complete.
We need to rename all references in repository, there are also some in CI and .gitignore

I've renamed references in the CI, but those were related to the release tag name and name of the CI flow.
I think we should not rename our packages, I haven't found a single example where they use dashes instead of underscores.
For example: https://github.com/aws/aws-xray-sdk-python recommends installing package with pip install aws-xray-sdk but then you import it as in from aws_xray_sdk.core import xray_recorder. All the major packages I've checked like sentry, powertools etc. all use underscores in the package names instead of dashes. Now this is not to be confused with how we name the project and how it's published on PyPI.


Support offiline and connection with MongoAtlas

Helllo, I was searching and I found you.
1º  The lib includes offiline support?
2° The lib includes support to connection with MongoAtlas Cloud? Or others clouds services
Thank you.

This lib is only used for local/offline usage. there is no connection with external databases.


Bootstrap 3 Datetimepicker in pqGrid

Please send me a jsfiddle for latest version of bootstrap 3 Datetimepicker inside the pqGrid. It has resolving so many issues in my module. But I can't able give bootstrap 3 inside of the pqGrid. Please send me fiddle for this.

I don't have to time to track down issues relating to random third party plugins. Please don't open new issues that are duplicates of your currently open issues.


Add XDP support

Details TBD.

How about supporting tc-bpf together?

Do you mean tracing each individual BPF program? If yes, we are planning to do it for Cilium in the nearest future.

Do you mean tracing each individual BPF program?

Yes.
Recently, I discussed with @jschwinger233 that pwru traces XDP and tc-bpf. I was writing some code at that time.
But, currently, I'm busy fixing a kernel-bpf bug.🤔

Martynas, this is the guy @Asphaltt who managed to trace bpf tailcalls using kernel module, as I mentioned this Tuesday. :grin:

Got it, small world :smile:

Yeah, small world 😀
I'm afraid I can not help this issue for some time. I'm planning to do tailcalls tracing things after fixing the kernel-bpf bug.

Hi @brb ,
I'm glad to tell you that I just finished the POC of tracing TC bpf programs.
But, it's based on PR #266  and the latest go-ebpf library.
Recently, I'm fixing a tailcall issue of kernel-bpf whose progress is really slow. Then, I'm on this support now.

Hi @Asphaltt , thanks for the update!

I just finished the POC of tracing TC bpf programs

Great. I am curious what approach did you take (is it the same as Gray's one)?

is it the same as Gray's one

No. I trace TC bpf programs by listing then filtering all bpf progs.
Would you like to upgrade go-ebpf to latest version?

Would you like to upgrade go-ebpf to latest version?

Sure https://github.com/cilium/pwru/pull/269

Hi, is somebody actively working on this issue? If not, I volunteer to help, as I'm interested on this feature as well.
But I may need some assistance on the approach. I have tried to do a similar kind of filtered tracing on XDP programs using fentry/fexit on some personal projects before with no success. The verifier kept rejecting my program for invalid memory access when I tried to access packet data.

@mscastanho Hi, not sure whether @Asphaltt is working on it?

Hi, @brb, I will work on it when my PRs get merged. It'll be nice to work on it without other on-going PRs.

It'll be nice to work on it without other on-going PRs.

Sure, I just wanted to clarify whether @mscastanho can take this issue :sweat_smile:


Can't access props inside onPress

Hey,
unfortunately, I'm stuck on a problem. I can't access the react properties (this.props) for any reason.
Example:
class TestScreen extends Component {
    render() {
        return (
            <GoogleSigninButton
                style={{ width: '100%', height: 60 }}
                size={GoogleSigninButton.Size.Wide}
                onPress={() => this.navigation.navigate('Dashboard')}
                disabled={this.state.loadingGoogleSignIn}
            />
        );
    }
}

On my example, this.navigation is undefined.
All versions are up to date.

I think you want to use this.propsnavigation.navigate('Dashboard') :)

I think you want to use this.props.navigation.navigate('Dashboard') :)

Sry, bad copy & paste. I already use this.props...

let thisVar = this;
works for me

Dawn, I have forgotten to pass the props to my child component...
Thanks for your help :)


Issues migrating integration from Cocoapods to Swift Package

When attempting to migrate from Cocoapods to Swift Package using 4.1.0
I have several issues where import ChattoAdditions is no longer working. Simply updating that import to import Chatto is causing other issues.
Please update your readme.md with clear directions on how to integrate using SPM and how to transition from using ChattoAdditions.

@brandtdaniels I found a solution here - https://forums.swift.org/t/unable-to-import-multiple-targets-from-external-dependency/39030
It works like this:
dependencies: [
    .product(name: "Chatto", package: "Chatto"),
    .product(name: "ChattoAdditions", package: "Chatto"),
]

您好，邮件收到


[1.9] Improve UX for Package Install Beta opt-in

Backport of https://github.com/dcos/dcos-ui/pull/2201 to 1.9.

Checklist

[ ] Did you add a JIRA issue in a commit message or as part of the branch name?
[ ] Did you add new unit tests?
[ ] Did you add new integration tests?
[ ] If this is a regression, did you write a test to catch this in the future?

Testing only this PR fails with the screenshot below (without #2201)

@weblancaster - I suggest checking out release/1.9 branch of plugins, running npm i and then running npm start again.

retest this please

@MatApple Thanks. I was able to run normally but I noticed a big decrease in performance/UI particularly related to the changes made.
before

Thanks for the testing @weblancaster. I don't think those performance issues are related to these changes. If you test beta-dse on release/1.9 branch and then on this branch, you'll find they both perform equally bad.
Please validate again using the same package on release/1.9 branch to keep all other variables equal. I'd also suggest testing the opening/closing of the modal at least 3 times to negate outlier test results.

Hey @orlandohohmeier, code looks good to me is there any particular reason for the hold merge?

@nLight It's basically a back-port of #2201 and we shouldn't merge this one 'til we've addressed all the comments.

We discussed the hold merge offline and decided to move forward with this PR even though the master fix is still on hold.


docs: Update docs to clarify create_role and lambda_role usage

Description

Adds clarification to the README and variables.tf about create_role and lambda_role.
Motivation and Context

The lack of this information in the docs made troubleshooting this module take some time.
Breaking Changes

None.
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

[ ] I have executed pre-commit run -a on my pull request

Such an addition to the explanation is not necessary because if we change the logic of the module (rarely we do it) we need to remember to update the description of the variable. Instead, we should provide good feature coverage with examples.


update the review slider section and add carousel features

Pull Request Description:
Summary: This PR focuses on updating the review slider section to match the provided Figma design and fixing some issues in the Top Seller section.
Changes Made:
Review Slider Section:
Updated the HTML and CSS to match the Figma design.
Added a new slider.js file to implement the carousel functionality, allowing users to slide through different sets of review cards.
Integrated responsive design for mobile and tablet views, ensuring the slider works seamlessly on different screen sizes.
Responsiveness:
Added media queries to ensure proper layout and responsiveness for mobile and tablet devices.
Adjusted the slider to display an appropriate number of cards per view based on screen width.
Top Seller Section:
Fixed layout issues that were affecting the design and alignment.
Resolved minor CSS bugs to ensure consistency across different devices.

@Alexandrbig1 please add the label as Hactoberfest


File tree does not update automatically when there are changes in files

My actions before raising this issue

[ ] Read/searched the docs
[ ] Searched past issues

While using Connected file storage, the file tree does not update automatically whenever there are changes in the files (i.e adding a new file). We have to refresh the page to see the updated list. For better user UX, it would be great to have this list update automatically.
Expected Behaviour

Current Behaviour

Possible Solution

Use a filewatcher like Watchdog to watch for file changes.
Create an endpoint to serve a Websocket that will notify the client of file changes.
Update UI to make an additional request to connect to the websocket and update the UI.

Operating System and version (e.g. Linux, Windows, MacOS):
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
Logs from `cvat` container

Next steps
You may join our Gitter channel for community support.

@savan77 , it is a nice feature request. Let me know if you can help with the issue.

Sure @nmanovic , we are working on the proposed approach.

@savan77 , I will close the feature request. Nobody else complained about the behaviors. Probably the easiest approach is to have a button 'refresh'. But let's wait more complains from community about that.


How to Improve the Running Speed?

Hi! Thank you for your contribution. Currently, I am experimenting with multiple sets of parameter combinations, but they amount to over a million sets. Is it possible to expedite the code execution using parallel processing or multi-threading? Thank you.

dear sky19941015,
Sorry for the slow response. It is certainly possible to speed up the simulations using parallel processing. However, this cannot be done in the Jupyter notebook because of some technical difficulties with mp and jupyter. I have an updated version of this notebook ready with an example of how to do multiprocessing. I will try to upload it to github in the coming days.
Allard


Duplicated Hover Info With Vetur

Describe the bug
When both VueDX and Vetur are installed, TS hover hints are displayed twice.
To Reproduce
Steps to reproduce the behavior:

Install both extensions
Hover on some TS content in Vue SFC
TS hover hints are displayed twice.

Expected behavior
Only one should be displayed. Not sure which extension should display it.
Screenshots/Recording

Info (please complete the following information):

OS: macOS 11.1
IDE: VSCode
TypeScript Version: 4.1.3
Vue Version: 3.0.5
VueDX Version: 0.6.0
Vetur Version: 0.31.3

Additional Context
I'm currently working inside a monorepo. Not sure it matters or not.

Both vetur and vuedx are providing hover info. There's ongoing work to include TS plugin in vetur, for the time being you have to disable one of the extension if you don't want duplicate hover info.

Both vetur and vuedx are providing hover info. There's ongoing work to include TS plugin in vetur, for the time being you have to disable one of the extension if you don't want duplicate hover info.

Is there a way to disable Vetur's code checking while retaining syntax highlighting for single-file components? If I disable the entire Vetur extension, this also removes syntax highlighting features.

Is there a way to disable Vetur's code checking while retaining syntax highlighting for single-file components? If I disable the entire Vetur extension, this also removes syntax highlighting features.

You can use this extension for syntax highlighting.

You can use this extension for syntax highlighting.


i dont know how to do it

i've got 7 phones capable of running this but i dont understand how to do it, if somebody can give me like a step to step guide or something that would be really helpful

click the releases tab to download the JAR, put it on your phones of choice and run it. then you will need to get your discord token (search on your favorite search engine) and type it in discord-j2me

alright thanks

do i transfer via usb or directly install it?

you need to obtain the token with the "dev tools" tool that comes by default in your browser with chrome

install via bluetooth or download via the browser....it's not difficult

im gonna try putting it from my pc to my s7 edge to my nokia n8

this might actually just be a cable issue

YESSS IT WORKED WITH BLUETOOTH LETS GOO

now how do i get the token with dev tools

bruh it doesnt wanna load the website anymore

do i have to use that website or can i just use discord itself

https://letmegooglethat.com/?q=how+to+get+discord+token+pc
bro it's not that hard to google it yourself. try everything until it works eventually


WIP: named windows

factored window and implemented default window
in terms of the new class
implemented window position and state saving per-host
implemented settings panel to configure additional windows
implemented changes to the file menu to make these available in right clicks, but not in commands
this PR will be updated as I work, in case you want to look at anything

This is working now, so we might as well review in case you absolutely hate it and then I can quit :)

Ok I think that's all the simplifications I can think of.  If you want, I can rebase everything into one commit.


[rcore][desktop_GLFW][X11] ToggleBorderlessWindowed() can't restore decorations

the issue :
ToggleBorderlessWindowed() can't restore window decorations when toggling back to windowed mode on my LinuxMint + MATE desktop.
After many testing and digging, for yet unknown reason, it appears that this bug only occurs when ToggleBorderlessWindowed() set the position of the borderless window at { 0 , 0 } with a width and height exactly equal to the video mode width and height. (see code implementation below)
If one of these parameters is increased or decreased by just one pixel, it works.
I tried disabling many other settings, like GL_FLOATING etc, and found no direct correlation.
It is possible that this issue actually be caused by GLFW or X11.
However, the GLFW documentation suggest that current Raylib implementation of ToggleBorderlessWindowed() might be invalid, andmake me think that the issue could be solved on Raylib side if the implementation was changed. (see below)
Current ToggleBorderlessWindowed() implementation :
https://github.com/raysan5/raylib/blob/74680748b9abe05ceda5d412b61ff99addf72807/src/platforms/rcore_desktop_glfw.c#L191-L263
GLFW_FLOATING not intended for fullscreen implementation?
The current implementation of ToggleBorderlessWindowed() makes use of GLFW_FLOATING to implement this "borderless fullscreen window".
However, according to the official GLFW documentation, it should not be used for this purpose :
https://www.glfw.org/docs/latest/window_guide.html#window_hints_wnd

GLFW_FLOATING specifies whether the windowed mode window will be floating above other regular windows, also called topmost or always-on-top. This is intended primarily for debugging purposes and cannot be used to implement proper full screen windows. Possible values are GLFW_TRUE and GLFW_FALSE. This hint is ignored for full screen windows.

This could suggest that despite the bug is not directly related to GLFW_FLOATING, the current implementation of ToggleBorderlessWindowed() is an invalid way of achieving its purpose, and that an alternative implementation should be preferred.
But i don't know yet, which one yet.

Similar X11 issue previously mentionned in Raylib code :
https://github.com/raysan5/raylib/blob/74680748b9abe05ceda5d412b61ff99addf72807/src/platforms/rcore_desktop_glfw.c#L1392-L1400

According to @paulmelis here https://github.com/raysan5/raylib/issues/4147#issuecomment-2219636084
The behavior is slightly different depending on where the desktop menu bar is located.
My current tests confirm that when the menu bar is at the top, the position of the borderless window is put just under the menu without covering it despite ToggleBorderlessWindowed() asked it to be at { 0 , 0 }
The previous description is when the menu bar is located at the bottom.

This sounds a lot like https://discourse.glfw.org/t/turning-on-off-window-decorations-while-in-full-screen-wont-work-properly/1780.
But that was years ago and was fixed in https://github.com/glfw/glfw/commit/4afa227a056681d2628894b0893527bf69496a41on the 3.4 branch. However, the function _glfwPlatformSetWindowMonitor() to which the patch was applied, no longer appears in the final src/x11_window.c as included in GLFW 3.4. The code seems to have moved to _glfwSetWindowMonitorX11(), and is included in raylib/src/external/glfw/src/x11_window.c.

Ugh, https://github.com/glfw/glfw/issues/1741, seems to suggest there might also be a window manager influence.

Menu bar position
Borderless Window position (1st toggle)
Window restoration (2nd toggle)
comment

bottom
{ 0 , 0 }
decoration not restored
toggling a 3rd time and more does not move the borderless window to { 0 ,0 } again

top
{ 0 , menuHeight }
decoration restored
other toggles work like expected

left
{ menuWidth , 0 }
decoration restored
other toggles work like expected

right
{ 0 , 0 }
decoration NOT restored
toggling a 3rd time and more does not move the borderless window to { 0 ,0 } again

Can you confirm ?
(i'm going to read your links now)

Can you confirm ?

I can only test with the menu bar at the top (not going to risk screwing up my work-setup here). But I suspect (and tested some values) that will all Y-positions != 0 the window decoration gets properly restored. It's the Y=0 case that has issues.

@paulmelis :
If you can recompile Raylib, you might want to test that version :
// Toggle borderless windowed mode
void ToggleBorderlessWindowed(void)
{
    // Leave fullscreen before attempting to set borderless windowed mode and get screen position from it
    bool wasOnFullscreen = false;
    if (CORE.Window.fullscreen)
    {
        CORE.Window.previousPosition = CORE.Window.position;
        ToggleFullscreen();
        wasOnFullscreen = true;
    }

    const int monitor = GetCurrentMonitor();
    int monitorCount;
    GLFWmonitor **monitors = glfwGetMonitors(&monitorCount);

    if ((monitor >= 0) && (monitor < monitorCount))
    {
        const GLFWvidmode *mode = glfwGetVideoMode(monitors[monitor]);

        if (mode)
        {
            if (!IsWindowState(FLAG_BORDERLESS_WINDOWED_MODE))
            {
                // Store screen position and size
                // NOTE: If it was on fullscreen, screen position was already stored, so skip setting it here
                if (!wasOnFullscreen) glfwGetWindowPos(platform.handle, &CORE.Window.previousPosition.x, &CORE.Window.previousPosition.y);
                CORE.Window.previousScreen = CORE.Window.screen;

                // Get monitor position and size
                int monitorPosX = 0;
                int monitorPosY = 0;
                glfwGetMonitorPos(monitors[monitor], &monitorPosX, &monitorPosY);

                glfwSetWindowMonitor(platform.handle, monitors[monitor], monitorPosX, monitorPosY, mode->width, mode->height, mode->refreshRate);

                // Refocus window
                glfwFocusWindow(platform.handle);

                CORE.Window.flags |= FLAG_BORDERLESS_WINDOWED_MODE;
            }
            else
            {
                // Return previous screen size and position
                int prevPosX = CORE.Window.previousPosition.x ;
                int prevPosY = CORE.Window.previousPosition.y ;
                int prevWidth = CORE.Window.previousScreen.width ;
                int prevHeight = CORE.Window.previousScreen.height ;
                glfwSetWindowMonitor(platform.handle, NULL, prevPosX , prevPosY, prevWidth, prevHeight, mode->refreshRate);

                // Refocus window
                glfwFocusWindow(platform.handle);

                CORE.Window.flags &= ~FLAG_BORDERLESS_WINDOWED_MODE;
            }
        }
        else TRACELOG(LOG_WARNING, "GLFW: Failed to find video mode for selected monitor");
    }
    else TRACELOG(LOG_WARNING, "GLFW: Failed to find selected monitor");
}

I was already trying it, saw the update in #4147 :) Here it makes ToggleBorderlessWindowed() work fine as well, not even needing the set-position call.

Do you have FLAG_WINDOW_HIGHDPI enabled ?

Do you have FLAG_WINDOW_HIGHDPI enabled ?

No

Edit: it does still return the incorrect (previous) screen resolution

As long as this flag is off, I dont notice anything wrong with other flags.
Could you be more specific ?
Here is the test code i'm using :
#include "raylib.h"

void update();
void draw();

int main( int argc , char **argv )
{
//	SetWindowState( FLAG_MSAA_4X_HINT );

//	SetConfigFlags(FLAG_WINDOW_HIGHDPI); // <======= ???

	InitWindow( 640 , 512 , "Test" );

//	ClearWindowState( FLAG_VSYNC_HINT );

	SetTargetFPS( 60 );

//	SetWindowState( FLAG_WINDOW_RESIZABLE );

	while( ! WindowShouldClose() )
	{
		update();

		BeginDrawing();
		{
			ClearBackground( RAYWHITE );
			draw();
		}
		EndDrawing();
	}

	CloseWindow();
}

void update()
{
	if ( IsKeyPressed( KEY_F ) )
	{
//		ToggleFullscreen();
	}
	else
	if ( IsKeyPressed( KEY_B ) )
	{
		ToggleBorderlessWindowed();
	}
}

void draw()
{
	int sw = GetScreenWidth();
	int sh = GetScreenHeight();

	int rw = GetRenderWidth();
	int rh = GetRenderHeight();

	Vector2 dpi = GetWindowScaleDPI();

	int monitor = GetCurrentMonitor();

	int mw = GetMonitorWidth( monitor );
	int mh = GetMonitorHeight( monitor );

	Rectangle screenRect = { 0.0 , 0.0 , sw , sh };
	Rectangle renderRect = { 0.0 , 0.0 , rw , rh };

	// Draw the border of the screen :
	DrawRectangleLinesEx( screenRect , 4.0f , RED );
	DrawRectangleLinesEx( screenRect , 4.0f , GREEN );

	// Draw the text NOT in the center :

	DrawText( TextFormat( "Screen : %d x %d" , sw , sh ) , 10 , 10 , 30 , BROWN );
	DrawText( TextFormat( "Render : %d x %d" , rw , rh ) , 10 , 40 , 30 , DARKGREEN );
	DrawText( TextFormat( "Monitor[%d] : %d x %d" , monitor , mw , mh ) , 10 , 70 , 30 , DARKBLUE );
	DrawText( TextFormat( "DPI : %f x %f" , dpi.x , dpi.y ) , 10 , 100 , 30 , BLACK );

	DrawText( TextFormat( "infoRect : %f x %f" , screenRect.width , screenRect.height ) , 10 , 140 , 30 , RED ); // <===
	DrawText( TextFormat( "infoRect : %f x %f" , renderRect.width , renderRect.height ) , 10 , 170 , 30 , GREEN ); // <===
}

As long as this flag is off, I dont notice anything wrong, even with other flags on or off.
Could you be more specific ?

Ah, it might be that the values for GetScreenWidth() and GetScreenHeight() are invalid outside of the BeginDrawing() ... EndDrawing() block. If I read them immediately after ToggleBorderlessWindowed() they are incorrect. E.g.
    if ( IsKeyPressed( KEY_B ) )
    {
        ToggleBorderlessWindowed();
        printf("Toggled, screen now %d x %d\n", GetScreenWidth(), GetScreenHeight());
    }

The values returns by these funcs are updated when WindowSizeCallback() is called by GLFW sometimes later.
We could set them directly into the ToggleBorderlessWindowed() function without further delay though :
// Toggle borderless windowed mode
void ToggleBorderlessWindowed(void)
{
    // Leave fullscreen before attempting to set borderless windowed mode and get screen position from it
    bool wasOnFullscreen = false;
    if (CORE.Window.fullscreen)
    {
        CORE.Window.previousPosition = CORE.Window.position;
        ToggleFullscreen();
        wasOnFullscreen = true;
    }

    const int monitor = GetCurrentMonitor();
    int monitorCount;
    GLFWmonitor **monitors = glfwGetMonitors(&monitorCount);

    if ((monitor >= 0) && (monitor < monitorCount))
    {
        const GLFWvidmode *mode = glfwGetVideoMode(monitors[monitor]);

        if (mode)
        {
            if (!IsWindowState(FLAG_BORDERLESS_WINDOWED_MODE))
            {
                // Store screen position and size
                // NOTE: If it was on fullscreen, screen position was already stored, so skip setting it here
                if (!wasOnFullscreen) glfwGetWindowPos(platform.handle, &CORE.Window.previousPosition.x, &CORE.Window.previousPosition.y);
                CORE.Window.previousScreen = CORE.Window.screen;

                // Get monitor position and size

                glfwSetWindowMonitor(platform.handle, monitors[monitor], 0, 0, mode->width, mode->height, mode->refreshRate);

                // Let's not wait for GLFW to call WindowSizeCallback to update these values :
                CORE.Window.screen.width = mode->width ;
                CORE.Window.screen.height = mode->height ;

                // Refocus window
                glfwFocusWindow(platform.handle);

                CORE.Window.flags |= FLAG_BORDERLESS_WINDOWED_MODE;
            }
            else
            {
                // Return previous screen size and position
                int prevPosX = CORE.Window.previousPosition.x ;
                int prevPosY = CORE.Window.previousPosition.y ;
                int prevWidth = CORE.Window.previousScreen.width ;
                int prevHeight = CORE.Window.previousScreen.height ;
                glfwSetWindowMonitor(platform.handle, NULL, prevPosX , prevPosY, prevWidth, prevHeight, GLFW_DONT_CARE);

                // Let's not wait for GLFW to call WindowSizeCallback to update these values :
                CORE.Window.screen.width = prevWidth ;
                CORE.Window.screen.height = prevHeight ;

                // Refocus window
                glfwFocusWindow(platform.handle);

                CORE.Window.flags &= ~FLAG_BORDERLESS_WINDOWED_MODE;
            }
        }
        else TRACELOG(LOG_WARNING, "GLFW: Failed to find video mode for selected monitor");
    }
    else TRACELOG(LOG_WARNING, "GLFW: Failed to find selected monitor");
}

@paulmelis : could you please test the new version of this PR #4151 ?
(it should work with FLAG_WINDOW_HIGHDPI enabled.)

@paulmelis : could you please test the new version of this PR #4151 ?

Still works for me (not using FLAG_WINDOW_HIGHDPI, btw)


Create home page

Currently when going to https://track-expenses-app-frontend.netlify.app/ we can see empty page.
To improve experience we would like to display simple home page.
Requirements
Mobile

Display attached graphic
Under the graphic display heading "Welcome to Track Expenses App"
Under the heading display text "The best way to control your money"

Desktop

On the left display attached graphic
On the right heading and text under heading (same texts as on mobile)
Display it centered vertically, image should take almost whole left side of the page, and texts right side

Przypisane do Bartka.


Windows App 7.4.252 - black box appears on screen

From user:
"when I use Toggle Desktop, a small black rectangle shows up on the right side of my screen - can't get rid of it unless i reboot"
running Windows 10 home on an intel i7, not running multiple/dual monitors
HP Spectre running an i7 with 16 gb ram and a 512 gb ssd.

conversations/19175425723

Might be a minitimer window that's black. Dark or transparent windows can be caused by outdated graphics drivers or faulty graphics drivers.

@IndrekV user has said their graphics driver isn't outdated. computer specs are

HP specter with a fifth generation I seven processor and 16 gig of RAM.

any other ideas?


Remove redundant non-capturing group  special constructs

I'm failing to see why there should be ?: construct in the platform matching regexes.
it had to be some copypaste error in past. If I'm wrong, then I'm looking forward for info. Thanx!

Ping please. This is trivial.

It is expected that the contributor will launch Grinder to verify the changes. See https://github.com/adoptium/aqa-tests/blob/master/Contributing.md

Oh sorry. Sure!

Oh sorry. Sure!

https://ci.adoptium.net/view/Test_grinder/job/Grinder/9865/
Checking on CryptoTests. I will try to elaborate if Ic an somehow run the jck.

ok. all platforms passed.

gosh. Ty!


Add "show hidden files" flag to list function

And change LIST command to LIST -al if flag is true. Or there are any other ways?

I'd accept a PR for that.