Enhancement request: Different settings per language

First of all, thanks for this great extension! 💯
Could it be possible to get settings per language? For example for C#, Javascript, etc.
In our current project C# uses 4 spaces indentation and JS files use 2 spaces indentation, so I wouldn't need to change it every time I change the task I'm working with.
Not a huge issue, but I'd welcome this kind of enhancement 👍

This is a very good idea! I'll try to get this done as soon as possible :)


image weaveworks/scope-ui-build not found on fresh docker host

reproduce:

build once
remove all docker images
build again

$ make
mkdir -p client/build
docker run --rm -ti -v /Users/david/weave/src/github.com/weaveworks/scope/client/app:/home/weave/app \
		-v /Users/david/weave/src/github.com/weaveworks/scope/client/build:/home/weave/build \
		weaveworks/scope-ui-build npm run build
Unable to find image 'weaveworks/scope-ui-build:latest' locally
Pulling repository docker.io/weaveworks/scope-ui-build
docker: Error: image weaveworks/scope-ui-build not found.
See 'docker run --help'.
make: *** [client/build/app.js] Error 125

Looks like the .uptodate files suggest that there should be an image. Maybe add a guard against missing images?

This is by design; in the Makefile we can't work out if an image exists, so we use the .uptodate files.


proposal: math: integer square root

Add a function like math.Isqrt(n int) int.
Currently I implement this by
sort.Search(n, func(x int) bool { return x * x + 2 * x + 1 > n })

but maybe this feature could be added to the standard library like math.Ilogb

our bar for what might be added to math was clarified here https://github.com/golang/go/issues/58146#issuecomment-1497871784
c math.h doesn't have this.


chore: improve readme

Implements this task.

could you please do a little out of scope thingy? the RELAYER_NEUTRON_CHAIN_CHAIN_PREFIX is not used at all and really looks redundant since it's actually a neutron's relayer. we set the prefix here: https://github.com/neutron-org/neutron-query-relayer/blob/main/internal/app/app.go#L55

could you please do a little out of scope thingy? the RELAYER_NEUTRON_CHAIN_CHAIN_PREFIX is not used at all and really looks redundant since it's actually a neutron's relayer. we set the prefix here: https://github.com/neutron-org/neutron-query-relayer/blob/main/internal/app/app.go#L55

this one is also never used: RELAYER_NEUTRON_CHAIN_ACCOUNT_PREFIX

also please fix these misprints:

target chain provider output format -> neutron chain provider output format;
target chain connetcion ID -> target chain connection ID.


Revert context

Although having a request ID available throughout the codebase is very
valuable, the impact of requiring a Context as an argument to every
function in the codepath of an API request, is too significant and was
not properly understood at the time of the review.
Furthermore, mixing API-layer code with non-API-layer code makes the
latter usable only by API-layer code (one that has a notion of Context).
PS: the following files had simple conflicts but make sure you review them properly:

api/server/container.go
builder/internals.go
daemon/container_unix.go
daemon/create.go

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "revert-context" git@github.com:tiborvass/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Ping @docker/core-maintainers @stevvooe

"go" doesn't really offer much of an alternative  - like thread local data might.  So is this basically saying that we don't want to do things like have a requestID on events so that people can correlate them? For example, to see that a series of container/image actions are all related to the same build cmd.

@duglin no this is not saying we don't want that. What it's saying is that the change brings more problems than it solves, and we did a bad job at reviewing.
We still want the ability to log request IDs and correlate things, but we need to agree how to do that. That means agreeing we want to use Context, and if we do, agreeing which package, and where to call it from.
There are other weird alternatives too like Goroutine Local Storage. Unless a lot of people agree it's better to carry around Context literally everywhere (down to the execdrivers), just because we want to log from everywhere, I think it's wiser to revert and think of a better solution.

LGTM

Something's wrong with the commits referenced in the commit messages and some context is still in the code. Will reopen.

Actually this is all good; seeing the face of people who merged confused me.
Also the context package is used only in the api/server/ folder where it is used to get API version and Request ID, which I think is fine and less controversial. An improvement could be to not have our own context package but overall the code within that folder is better with context than without. See #15953 for more.

If we're not planning on using the context for anything (aside from the version string) then we should just remove it all and handle the version string the way we used to.
But, before we move quickly to revert it I'd like to understand our next steps or replacement proposal. I think hastily removing is just as bad as hastily adding it in the first place.
To get the ball rolling, @tiborvass can you suggest an alternative solution that we should consider?

We want to maintain the context in the HTTPAPIFunc signature because it makes the api more compatible with other components, like Swarm.

As alternative solution I can propose some stuff like eventPrefix, which will allow you to combine different events together, at least it won't spoil code so much. Anyway I think we have some time to decide, because actually I didn't see many requests for such feature. And code looks extremely bad with ctx changes(I'm talking about spoiling all codebase with ctx argument, not about using context overall) now and that is destructive for opensource projects like docker, which relies on contributors so much.

@LK4D4 would that allow us to correlate it from the http request? It would be nice to be able to know which exact http request was related to which events.

@duglin Could you explain your use-cases then apart from build-sequence? Because "would nice to know" doesn't sound for me like real use-case for feature.

btw +1 on design of this PR

@LK4D4 for auditing/tracing/debugging purposes - to be able to trace actions taken on a container/image to incoming http requests, which are also tied to users. Likewise, to be able to know which actions were taken by the system itself instead of as a result of an http request.

@duglin In current implementation RequestID is just random string generated inside docker, so auditing and users out of question for now.
However I think this could be solved by refactoring daemon methods so it'll be possible to spawn all events in top-calls of API(which makes sense - separation of events subsystem from daemon). It's not easy task, but current implementation is unacceptable. I personally not going to tolerate such massive code spoiling for such feature(it isn't nearly critical one, sorry). Other maintainers can disagree with me.

Not sure why you think the current stuff doesn't work because of the random ID. The ID itself doesn't matter as long as its unique, random or not

LGTM

LGTM

LGTM


Integrate firebase performance monitoring plugin

It only needs the dependencies to be declared. Rest is done automagically by the sdk.
Firebase Console > Quality > Performance

Did figure out why crashes weren't being reported?

Yeah, I had a lead in that direction. That reminds me to ask you a question. Was crashlytics (or fabric) ever integrated into ground?

Did figure out why crashes weren't being reported?

Yeah, I had a lead in that direction. That reminds me to ask you a question. Was crashlytics (or fabric) ever integrated into ground?

They never were, no. Sorry I missed this comment. Please let me know if you're stuck and we can try to debug together!

That can be done separately. IMO this is ready to be merged!


Issue/#126

Codecov Report

Merging #134 (0af72c5) into develop (4de490a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           40        40
  Lines         1071      1073    +2
=========================================
+ Hits          1071      1073    +2

Impacted Files
Coverage Δ

pfhedge/instruments/primary/heston.py
100.00% <ø> (ø)

pfhedge/stochastic/cir.py
100.00% <ø> (ø)

pfhedge/stochastic/heston.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de490a...0af72c5. Read the comment docs.


Aggregation Prediction uses select column from the ground truth

The below code snippet looks like using the column position for select in evaluation as well as training.
https://github.com/xiaojunxu/SQLNet/blob/5dfb96edc6f1131c3f640f31bcef3520ea0f922c/sqlnet/utils.py#L204
https://github.com/xiaojunxu/SQLNet/blob/5dfb96edc6f1131c3f640f31bcef3520ea0f922c/sqlnet/model/sqlnet.py#L131
https://github.com/xiaojunxu/SQLNet/blob/5dfb96edc6f1131c3f640f31bcef3520ea0f922c/sqlnet/model/modules/aggregator_predict.py#L41
Don't you think the model should predict the column for select instead of the column given as ground truth before aggregation prediction?
In fact, the select column will not be given in prediction time when applying this to real worlds.
You made selection prediction, so the output could be fed with the aggregation prediction.
In result, the evaluation number might be wrong while comparing with the original paper, seq2sql.

@deepcoord
Thanks for the code snippet.
I have a question though:
If I'm not mistaken, with your fix, sel_score is computed twice:

a first time by your piece of code before predicting the aggregator
a second time by the original code after predicting the aggregator

Wouldn't it be simpler to just reverse the order in which sel_score and agg_score are computed in the forward method in sqlnet.py ? By doing so, we could compute sel_score only one time and add a shorter snippet of code  just before predicting the aggregator :
     if gt_sel is None:             sel_score_np = sel_score.data.cpu().numpy()             gt_sel = [np.asscalar(np.argmax(sel_score_np[b])) for b in range(B)]
Am I missing something?

Thanks for recognizing the issue! Yes, this will lead to a wrong break-down result on aggregator but will not affect the overall acc_qm or acc_ex. I will fix the bug soon.


Users being created multiple times

Avoid same email to apply multiple times for the same role, it happened with rima Diab who applied three times as mentee having an existing user

solved by @SolMon9099


Remove optional / essential radio buttons

Trello - https://trello.com/c/P1mSis5e/97-hide-optional-vs-essential-question-when-editing-step
Content designers say it wasn't being used consistently and it was confusing users
Pr to remove from Content Schemas
https://github.com/alphagov/govuk-content-schemas/pull/927

@AgaDufrat Good spot, hadn't realised this was a thing! Thanks :)

Do we need to do anything in the frontend app (collections) to deal with this change?

@brucebolt I've removed that line from step_nav_presenter.rb. I couldn't find any mention of optional or indeed SBS's in content store, what am I missing? Thanks!

It will be in govuk-content-schemas.  I think it's these lines, but that'll need checking: https://github.com/alphagov/govuk-content-schemas/blob/master/dist/formats/step_by_step_nav/publisher_v2/schema.json#L242-L243

@brucebolt Nice one, thanks :) Have raised a PR to remove it there too
https://github.com/alphagov/govuk-content-schemas/pull/927

@brucebolt Done!


dev-latest (nightly) not working

I've got some QSV decoder problems with the current stable build and saw a note on https://github.com/HandBrake/HandBrake/issues/2792#issuecomment-619171379 about using the nightly to maybe fix some of these issues. I changed my docker-compose to use dev-latest, but when I started it, I got a warning about my config being newer than the one it was trying to load. It looks like it's using an old version (not even the current stable).

dev-latest is showing a year old on docker hub and that's why you're seeing that.

Yes you are right, an image based on a HandBrake nightly build has not been done recently...

Yes you are right, an image based on a HandBrake nightly build has not been done recently...

Ah ok, I assumed it was automated.

Nightly builds are now working.


3dsmax: Publishing Deadline jobs from RedShift

Changelog Description
RFix the bug of being uable to publish deadline jobs from Redshift

add save scene before rendering to ensure the scene is saved after the modification.
use the filename from the render setting instead of the current filename for the published name in deadline submission

Additional info
Please delete the old instance and create the new one for the test.

3dsMax doesn't support OCIO config yet so the related parameter is hardcorded.
Max in Redshift does support OCIO and currently hardcoded the data seen from RS in the collector.
4.rt.Redshift_Renderer().SeparateAovFiles seems to be broken as it doesn't bind to the render setting when executing the code. So currently please make sure you dont check Separate AOV Files.

Testing notes:

Launch 3dsmax via Openpype
Use Redshift as Renderer
Create Render Instance
Publish Render
It should only includes MaxRenderMain.exr and Cryptomatte.exr along with metadata in the related output folder

I have updated the code and changelog.

Here is a default RS settings for output:

And alternate (separate AOV files)

Here is a default RS settings for output:

And alternate (separate AOV files)

This one is recommended to be turned off as I find out the exposed parameter does not really link to the render setting. When I tried to set up the parameter with simple functions, it doesn't ask the render setting to check the  separate aov files even I refresh the code. Same when I check the   separate aov files and I tried to get parameter from separate aov files, it will always return to False. We perhaps need to submit ticket to Redshift helpdesk to see if they can help with it.  Or, we need to think alternatively, we can add options for enabled aov. If we click the separate aov files in render settings, we need to enable the "enabled aovs" to have the maps.
https://github.com/ynput/OpenPype/assets/64118225/8cc63a22-8e83-4909-a3c1-0ea9abf5e88a

I understand that that checkbox Separate files for AOVs should be Off but it doesnt work....thats why tried both variants.
The end results are same - getting error message.
If its a max shortcomming, maybe there could be option on OP render isntance so user could decide if Multilayer or not...


Problem tag

Make a option that To hide tag list of a problem like codeforces

Hii Ahasanul, Thanks for pointing it out, we already have this in our list and will be patched soon. https://github.com/rudradesai200/CFViewer/issues/6


some weird changes to attempt to stabilize tests

Will merge this to have the JLD2 update, still no clue what is going on though


Bug - JRunner UI crashes

Describe the bug
UI crashes when trying to create XeBuild with selected drives patches and "other patches".
If skipping drive patches and other patches build works as expected.
To Reproduce
Steps to reproduce the behaviour:

Load source file (nand.bin)
Select kernel 17559, Glitch2, RGH3 25mhz
Go to tab "Patches" and select "Both XL", "UsbdSec" and "Key fix"
UI takes a second then force closes

Expected behaviour
A build is done?
Screenshots

System (please complete the following information):

OS: Windows
Version: 11 Pro

Additional context
Error.log;

System.IO.IOException: Det går inte att skapa en fil som redan finns.
vid System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
vid System.IO.__Error.WinIOError()
vid System.IO.File.InternalMove(String sourceFileName, String destFileName, Boolean checkHost)
vid JRunner.Classes.xebuild.copyXLBoth()
vid JRunner.Classes.xebuild.createxebuild(Boolean custom)
vid JRunner.Panels.XeBuildPanel.createxebuild_v2(Boolean custom, PrivateN nand, Boolean fullDataClean)
vid JRunner.MainForm.b__186_0()
vid System.Threading.ThreadHelper.ThreadStart_Context(Object state)
vid System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
vid System.Threading.ThreadHelper.ThreadStart()

This error it sounds like Windows Defender sandboxing. Please add exception to the app. As such I cannot reproduce it.
I will see if I can handle that gracefully and warn the user.
Kind Regards,
Josh

This error it sounds like Windows Defender sandboxing. Please add exception to the app. As such I cannot reproduce it.
I will see if I can handle that gracefully and warn the user.
Kind Regards, Josh

Hi,
Sorry but Defender is not activated and no other antivirus is installed.
System.IO.IOException: Det går inte att skapa en fil som redan finns.
translation
System.IO.IOException: Can not create a file that already exists.
This error shows even with a clean uppacked Jrunner.

@Octal450

Reproduced.
Working on a fix.
Kind Regards,
Josh

It occurs if a build fails and then you try to rebuild. Files are left in an invalid state.

This should be fixed in dev/next.
Anyone encountering can use restore files option to fix it on release.
-J


afk plugin doesn't work

I noticed that when i set myself AFK with the /afk command, i immediately get my AFK state unset.
I looked at the code and it turns out that this is a general problem with all SimpleCommandPlugin subclasses that use the on_chat_sent callback.
What happens is that in PluginManager.do we iterate over the list of plugins (which is in arbitrary order due to the fact that it is stored in a dictionary). In my case, CommandPlugin.on_chat_sent callback gets called, which triggers AFKCommand.afk, which sets my user AFK.
Unfortunately, then AFKCommand.on_chat_sent callback gets called after that for the same /afk chat message, and unsets my AFK state.
I ended up with the following fix, although it seems pretty hacky:
diff --git a/starrypy/plugin_manager.py b/starrypy/plugin_manager.py
index 1a102dd..2f4c78a 100644
--- a/starrypy/plugin_manager.py
+++ b/starrypy/plugin_manager.py
@@ -201,7 +201,13 @@ class PluginManager(object):
         return_values = []
         if protocol is None:
             return True
-        for plugin in self.plugins.itervalues():
+
+        # Ensure CommandPlugin is always called last, so that it doesn't
+        # interfere with SimpleCommandPlugin subclasses
+        def key(item):
+            return 1 if item.name == 'command_plugin' else 0
+
+        for plugin in sorted(self.plugins.itervalues(), key=key):
             try:
                 if not plugin.active:
                     continue

If no one has a better solution, I'll submit a pull request.
One concern i have with this is that this code is on the critical path, so constantly sorting the list of plugins could have a performance impact (although not one i've noticed). An alternative would be store the plugins in a list instead of a dictionary, and pre-sort the list.

Using itervalues (which is generator) with sorted (that need all elements) is pointless. It will be much better to put sorted plugins into OrderedDict when loading plugins. Then ensure that order is correct on activating/deactivating plugins.
Please before you do any thing review this PR: https://github.com/StarryPy/StarryPy/pull/148

You're right, OrderedDict (or simply a list, i don't see a anything that requires it to be a dictionary) would be better. I alluded to that in my last comment, but didn't want to make any major changes without input.
I'll take a look at #148.


How to convert spreadsheets to your JSON format?

Hi and thanks for uploading your code repo.
How can someone preprocess their spreadsheet and generate a JSON for it according to your format?
https://github.com/microsoft/TUTA_table_understanding/blob/main/data/pretrain/spreadsheet/spreadsheet-sample.json

For spreadsheet tables, table detection is needed. You can train a table detection model using https://github.com/microsoft/TableSense. You can also watch this repo and we will publish the code in the near future.

Hi, and thanks for sharing this work!
Is this spreadsheets data available somewhere? If not, could you upload a few files (original) and processed (JSON)? This would help understanding how to produce the JSON. (I have also checked the spreadsheet-sampe.json, but some additional samples would help).
Thanks


Add code to print build_stdout after build is finished

Description
Build_stdout of all ABIs is always updated whenever built. And the ABI in which the device is not connected or failed to perform the unit test does not include "Gtest Success". Therefore, build_stdout is printed only when "Gtest Success" is included.
Result

If multiple devices are connected at the same time, they are all printed.

If there is no connected device, nothing will be printed.

Great job!!!👍👍

I accidentally closed the PR!!!!!!!!!!

@kuro11pow2 Great! :)
how about printing
"The build was successful, not verified by unit tests. For unit testing, connect a virtual device or Android device to adb."
if there is no connected emulator or android device,
it will be better build experience :)

@kuro11pow2 printing result is awesome!! your cmake.run.test.script is nice 👍

It's a useful function! Thank you for your efforts! 👍


Trigger without html

Is it possible to use this without relying on a selector that is listening to an html event?
The thing that I am clicking resides within a canvas element, so it is not addressable by the typical html id. Instead, I have an ajax call that I want to trigger the slideout with like so:
success: function (response) {
    Slideout({'panel': document.getElementById('panel')});

But I am getting the error Uncaught TypeError: Cannot set property '_startOffsetX' of undefined

This thread covers the subject well:
https://stackoverflow.com/questions/9880279/how-do-i-add-a-simple-onclick-event-handler-to-a-canvas-element


Re-land 'Adding physicalDepth to MediaQueryData & TestWindow'

Description
Re-landing changes from #37718 that were reverted.
Related Issues
Fixes #33854, again. :)
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[x] No, this is not a breaking change.

Do not merge right now. Blocked on roll, should land today or tomorrow.

This is safe to land now.


Filtered Result

How can i get filtered result from filter?

Hi ,
If you see the example on README.md , filter returns an array of responses satisfying your query and thats your filtered result.

Sorry if i did not specify it clearly. What i mean is, for example
let member of members | filter:search to let member of (filtered = (members | filter:search))
I wanted to get the filtered and use it somewhere else. Thanks :)

@Kisekii you can use *ngIf to store the intermediate value in another variable, check this commit
The relevant part:
    <ng-container *ngIf="(items | filter:firstName) as filtered" >
        <pre>{{ filtered | json }}</pre>
    </ng-container>


Media message download error

  public byte[] download(AttachmentProvider provider, Store store) {         return getDownloadUrls(provider, store).stream()                 .map(url -> download(provider, url))                 .flatMap(Optional::stream)                 .findFirst()                 .orElseThrow(                         () -> new IllegalStateException("Cannot download encrypted media: no suitable host found"));     }
Media message download error

 public byte[] download(AttachmentProvider provider, Store store) { return getDownloadUrls(provider, store).stream() .map(url -> download(provider, url)) .flatMap(Optional::stream) .findFirst() .orElseThrow( () -> new IllegalStateException("Cannot download encrypted media: no suitable host found")); }
Media message download error

What type of media are you trying to decide?

Pictures and documents are wrong
At 2022-09-03 05:58:07, "Alessandro Autiero" @.***> wrote:
public byte[] download(AttachmentProvider provider, Store store) { return getDownloadUrls(provider, store).stream() .map(url -> download(provider, url)) .flatMap(Optional::stream) .findFirst() .orElseThrow( () -> new IllegalStateException("Cannot download encrypted media: no suitable host found")); }
Media message download error
What type of media are you trying to decode?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Pictures and documents are wrong At 2022-09-03 05:58:07, "Alessandro Autiero" @.> wrote: public byte[] download(AttachmentProvider provider, Store store) { return getDownloadUrls(provider, store).stream() .map(url -> download(provider, url)) .flatMap(Optional::stream) .findFirst() .orElseThrow( () -> new IllegalStateException("Cannot download encrypted media: no suitable host found")); } Media message download error What type of media are you trying to decode? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>

After looking into it, it looks like Whatsapp returns a 404 status error. I'm not sure what do to be honest

I've concluded that it's because Whatsapp sends a 404 status for older messages, I don't know how to fix it to be honest. I can see that the web app actually loads it somehow. I'll look into it

Managed to fix it by implementing media reuploads, I'll see if it works well but the fix is already committed just not in any release


Make create, edit community/collection/item dialogs theme-able.

Description
See the title.  This is an elaboration of local work that was needed to create a custom new-item dialog in our local theme (instead of hacking the stock dialog).
Instructions for Reviewers
List of changes in this PR:

Create themed wrappers for the dialog components.
Use them in the menu resolver, in place of the un-themed components.

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR doesn't introduce circular dependencies
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

This is draft because I'm running Node v18 but the specified Webpack and eslint-plugin-jsdoc require an earlier version.

I have a knack for starting out to learn with a problem that seems simple but turns out to be difficult or unusual.  Thanks for a thorough critique.


Fonts in Logs unreadable

Fantastic software to find after having setup homebridge manually for a couple of years. Works like a dream, except the log window shows either black on black, or probably nothing at all. Using Brave browser on Mac. Looks OK in Safari, Firefox, Chrome, so it may only be a problem in Brave, but I still wanted to report it.

Hi @charona,
I think it's brave browser blocking something that is stopping this from working. You need to change the site settings to allow device recognition.

Brilliant, I took down the shield for that local site - did the trick. Thanks oznu! Amazing piece of software.

Thanks @charona!


fix: add more caching status tests

Description
Some unit tests for caching status.
Testing Instructions
The tests all pass
Closes TURBO-2501

#7574  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Zertsov and the rest of your teammates on  Graphite


Switching language breaks site

If I open the about page and switch to german in the header of the post, I get 404 errors when clicking on virtually anything in the menu (e.g. Install, Support etc.).

I found the cause and solution of the problem. The issue is caused by the menu links in de: > menu: > main: in the config.yml file. For pages that don't have a translated version (DE), it will be sufficient to change them. To give a brief example:
Old:
- identifier: Support
                   name: "Support"
                   url: /support/

Correct:
- identifier: Support
                   name: "Support"
                   url: "../support/"

@tmolitor-stud-tu , do you want me to fix this issue with a commit?


Update "Finding ways to contribute to open source on GitHub"

What article on docs.github.com is affected?
"Finding ways to contribute to open source on GitHub"
What part(s) of the article would you like to see updated?

[ ] Remove this section, which isn’t helpful for the new user audience: https://docs.github.com/en/github/getting-started-with-github/finding-ways-to-contribute-to-open-source-on-github#open-source-projects-with-mirrors-on-github
[ ] Add any context to the rest of the article that you think would be helpful

Additional information
This issue is for a special project and is not currently available for contributors to work on.

I would like to work on this issue

Great, thank you @ShreyaPrasad1209! Let us know if you have any questions as you work on your PR.

I as well
On Wed, May 12, 2021, 12:29 PM Shreya Prasad @.***>
wrote:

I would like to work on this issue
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/github/docs/issues/4857#issuecomment-839960523, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AS2IDBZNSTLF7YEKOD4YMDDTNK3HNANCNFSM4Z4A5DPA
.

@emilyistoofunky you can close this issue as my PR has been merged!✨


debugging with webstorm?

How do we debug with webstorm?
for example, one of things we need to do is configure
devtool: "source-map"1

which we don't have access to in ng-cli
did anyone configure debugging with webstorm with ng-cli?
Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/ng2Boilerplate
Regards,
Sean

I followed this guide and made it working without problem

do you mind sharing your config?
in other words, what are supposed to map? the dist dir? or src dir? see attached image
tx for replying

Sean

you need to map location of you sources, like this:

tx ya tried it with no luck
webpack:////msweb/testNgCli (that's the root folder of my project)
did you need to enable source map somewhere?
I do have it enabled in tsconfig
{
  "compilerOptions": {
    "declaration": false,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": ["es6", "dom"],
    "mapRoot": "./",
    "module": "es6",
    "moduleResolution": "node",
    "outDir": "../dist/out-tsc",
    "sourceMap": true,
    "target": "es5",
    "typeRoots": [
      "../node_modules/@types"
    ]
  }
}

but do we need to enable it somewhete for webpack?

i didn't change anything else in config
in fact, my .tsconfig looks exactly like yours

mm ok tx :/

ok got it working tx to your image, needed to map both root and /src
TX!!!!
Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/ng2Boilerplate
Regards,
Sean


Update README: PLUGIN_PATH from string to array

to remove the warning for deprecated string type to array.

Thanks!


Email report of multiple OCLC identifiers to each library

The emails specific to the library should be sent to the corresponding AIRFLOW_VAR_OCLC_EMAIL_{LIB}.

covered here https://app.zenhub.com/workspaces/folio-at-stanford-628d6cab8c42a90248e5eb79/issues/gh/sul-dlss/libsys-airflow/1080


Added login check for validated users

-Added login validation to check if the user's account has been validated

#174


automatic .jar building

Have the .jar of nerve built automatically using the CI and pushed to repsy.
Example: https://github.com/PGMDev/PGM/tree/master/.github/workflows

Fixed with https://github.com/bolt-rip/nerve/commit/9ce959803dc563e314e158c1387f40700ae8c8dd


Create example for multi-language and parameterized rules

Extracted from https://github.com/langium/langium/pull/346#pullrequestreview-851320480
I think this would be a good time to add a fourth example showing both the multi-language and parameterized rules features. It would be good to see these in a live example. The example languages could be two aspects of a system with a commonly used part of the syntax.
Rough idea: one language for a static view and another language for a dynamic view of a system, both sharing a common expression language.

A multi-language example was added with #676.

Note that we have an example for parameterized rules in our own grammar language:
https://github.com/langium/langium/blob/58037d69220bc0c5e11a0de5d258cbaaa8f292c0/packages/langium/src/grammar/langium-grammar.langium#L54-L55


Updating the missing link

Link is missing on mkdocs dependencies. This should fix that.
Linked issue(s): KOL-4262
What change does this PR introduce and why? added the missing link
Please check if the PR fulfills these requirements

[x] Include reference to internal ticket and/or GitHub issue "Fixes #NNNN" (if applicable)
[ ] Relevant tests for the changes have been added
[x] Relevant docs have been added / updated

seems like we already addressed it in https://github.com/kolenaIO/kolena/pull/364
could we close this pr? @mkaramlou


[New Component Proposal]: Create Navbar Component

🧩 New Component Name
Navbar Component
📝 Component Description
Navbar Component
This issue proposes the creation of a new Navbar Component for our qUIck React repository. The navbar component will serve as a fundamental element for navigation within our application, providing easy access to various sections and features.
Component Requirements:
The Navbar Component should include the following features and functionality:

Navigation Links: The navbar should contain links to essential sections of our application, such as Home, About Us, Services, Contact, etc. These links should be easily customizable.

Responsive Design: The Navbar should be responsive and adapt to various screen sizes and devices.

Styling: It should be designed with a clean and visually appealing layout, with options for customization to match our application's theme.

State Handling: The Navbar should indicate the active page or section, helping users identify their current location within the application.

Accessibility: Ensure that the Navbar is accessible to all users, including those who rely on assistive technologies.

Integration: The component should be easy to integrate into our existing React application.

Additional Information:

Please consider using React and any relevant libraries or frameworks for building this component.
It's essential to maintain consistency with our application's design language and UI/UX guidelines.
Feel free to discuss and propose any additional features or improvements related to the Navbar Component.

🎯 Motivation
Navbar Component Motivation
We're introducing the Navbar Component in our qUIck React library to:

Enhance User Navigation: Simplify access to app sections.
Maintain Branding: Ensure design consistency.
Adapt to Devices: Make it responsive.
Prioritize Accessibility: Ensure inclusivity.
Boost Developer Productivity: Easy integration.

Benefits for the library:

Usability: Makes the library more versatile.
Competitiveness: Sets us apart with a feature-rich solution.
Attracts Developers: Developer-friendly integration.
Engages the Community: For continuous improvement.

In conclusion, the Navbar Component addresses critical needs, improves our apps, and strengthens our library's appeal to the development community.
I agree to and respect the Code of Conduct

[X] I will follow CONTRIBUTING GUIDELINES

I'd like to work on this

assigned!! @nnisarggada

hey, can you assign me this issue?

Could you assign me to this issue ?

hey, can you assign me this issue?

yeah sure. @shambhaveesrivastava12


add a summary extension

Is your feature request related to a problem? Please describe.
I'm always frustrated when I don't have time to read lengthy articles or documents online, which makes it difficult to stay updated with important information. This is also a challenge for people with visual impairments or reading difficulties who need accessible ways to consume content. Having to manually read through long texts or use separate applications for text summarization disrupts my workflow.
Describe the solution you'd like
I would like a browser extension that can extract text from any webpage, send it to ChatGPT for summarization, and then return and display the summary. This extension should:
Extract the main text content from webpages.
Send the extracted text to a backend service that uses the OpenAI API to generate a summary.
Display the summary in a user-friendly interface within the extension.
Allow customization of summary length and other relevant parameters.
Describe alternatives you've considered
Using built-in screen readers, but they do not provide summarization and can be cumbersome to use for long texts.
Copying and pasting text into separate summarization applications, which is time-consuming and interrupts the browsing experience.
Manually reading and summarizing the text, which is inefficient and not feasible for lengthy documents.

@Sulagna-Dutta-Roy  please assign this issue to me under gssoc24

@Sulagna-Dutta-Roy assign this to me i want to work on it.

I am working on it , I will update soon

@rashiranjan22 can we both work on it ?

No pull request received since long time. Closing this


formaction, formmethod, formtarget and formenctype ignored on button without type attribute

This works as expected:
<button type="submit" form="fsp-form" formaction="account/csv" formmethod="GET">CSV</button>

but if you omit the [type=submit], then the formaction and the formmethod are ignored. DOES NOT WORK:
<button form="fsp-form" formaction="account/csv" formmethod="GET">CSV</button>

See src/main/java/com/gargoylesoftware/htmlunit/html/HtmlForm.java:226, type contains the empty string there.

fixed; will make a new snapshot available soon (pls check on twitter)

Many thanks.


[MB-15544] Import pricing data

Jira ticket
Summary
We imported pricing data from HSA to replace the fake pricing data we've been using.
The pricing data is sensitive so we've taken a lot of measures to avoid exposing it.
You will need to ask to get access to the pricing spreadsheet or the secure migration and sign an NDA.
We will only be deploying the real data to the ATO environments (staging, prod), and other environments will continue to use the old fake pricing data.
In those environments, we will be setting the start date for Base Year 1 of the new contract earlier than the official start date to allow us to test these rates. To account for this, we also shifted the end dates of contract years for the TRUSS_TEST contract so that they wouldn't overlap in these environments.
We were able to use the existing tools for importing the pricing spreadsheet (cmd/ghc-pricing-parser) and creating migrations (scripts/pricing-import), with very few hiccups.
One issue: when we were initially creating the pricers we assumed that none of the rates could be zero. The spreadsheet given to us by the prime DID price a lot of things as zero. So we changed our validations to allow for importing zero rates.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test

Access the
Login as a

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Database
Any new migrations/schema changes:

[ ] Follows our guidelines for Zero-Downtime Deploys.
[ ] Have been communicated to #g-database.
[ ] Secure migrations have been tested following the instructions in our docs.

Screenshots

Messages

:book:
:link: MB-15544

  Generated by :no_entry_sign: dangerJS against 6fc5c0e7cc2b84547d07a279eb4dce709a3d4a9c

I wanted to say I also tried a linehaul price with a zero rate and didn't run into any issues FWIW at least in having the service item priced (I didn't fully check EDI or anything).

@reggieriser Verified the production migration didn't vary from the staging version.


Update AutoRest C# version

Update AutoRest C# version to 3.0.0-beta.20221212.5

API change check
API changes are not detected in this pull request.

@ArcturusZhang @m-nash This PR appears to have broken a number of pipelines where code checks are now failing. See https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2055480&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=a880e989-7d1a-5c96-a41f-d540b383cc43 and https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2056240&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=a880e989-7d1a-5c96-a41f-d540b383cc43&l=129 as a couple of examples.
Can you please tell me why the generatecode step wasn't ran for all the libraries in the repo as part of this code gen update? That is what generally happens and helps ensure we don't break things.
@m-nash we might need to figure out something that blocks the update of this code gen version unless all the libraries have been regenerated.


Cms

CmsEdititor component is based on the example for rich text styling in the draft.js docs.
https://github.com/facebook/draft-js/tree/master/examples/rich

I am merging this seperately because it's not really part of the boilerplate.  Let me play around with it and see if it fits into the project.  I am also planning to setup a repo for the community project, so it may be better to merge it into that project.


no longer works with newest keras

Get ImportError: cannot import name _obtain_input_shape with keras 2.2.2 as opposed to 2.2.0

Hmm I gotta fix that. Is it called something else ?

I think you fixed this on contrib. It's keras_application instead of keras.application or something

did meant to close this

Fixed via https://github.com/titu1994/DenseNet/commit/70185f37273a361cedf563f90aba8b5e5c039dcc

Yes. I have 2.2.2 installed locally and I was able to run the inference script properly v

Great


Build files are now no longer minified

What's changed:

Build files that are pointed to as main are no longer minified, as it does not play nice with data-lasso being included in webpack build process.
webpack.config.js a bit more verbose, so now there is more flexibility in what flavor of build one can run.
npm run build will now build two versions of data lasso. One non-minified, for use as an npm module, and another one minified, for use without npm (such as github pages hosted Data Lasso).

Testing

npm run build will now build two files
npm start should still work and have all source maps working

@kmck @heylookltsme
I will bump version to 2.0.1 after this and publish an update.

👍


Show full screen option on videos

@tleraj actually this doesn't seem to be enough on desktop and we need to enable fs at the iframe level. I found this - https://stackoverflow.com/questions/52766216/cannot-make-the-iframe-fullscreen but it feels like overkill. Maybe we should use another component than CardMedia? What do you think?

@avalmas-programize looks like the changes in #604 are breaking the linter. Could you have a quick look?


Clojure escaped semicolon confused with comment

(Original issue 387 created by None on 2009-01-31T15:07:51+00:00)
Pygments renders code after a ; as a comment in clojure, which is generally true.  But you can also escape the ; like this: \;  , which is the character literal for semicolon, and should not produce a comment.
Reported by ericn

(Original issue was assigned to thatch)
(Original issue 387 last updated on 2009-02-14T12:30:42+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2009-02-14T12:30:42+00:00)
And merged.

(Original comment by thatch on 2009-02-06T18:12:21+00:00)
Thanks for clarifying. Fixed in [8a5cfccc9fe0] with test.

(Original comment by gbrandl on 2009-02-06T16:37:50+00:00)
[relaying comments from OP who has trouble logging in]
For an explanation of the character escaping:
http://clojure.org/reader
Under the literals section.
On line 76 of this file (part of the main distribution):
http://code.google.com/p/clojure/source/browse/trunk/src/clj/clojure/main.clj
you will see the semicolon being escaped to indicate a character
literal, not a comment.
I couldn't find anything that said specifically that \; has precedence
over ; for making comments.  But it works in the compiler.  It is
similar to C where a double slash in a string literal does not start a
comment.

(Original comment by thatch on 2009-02-05T07:18:18+00:00)
I couldn't immediately find docs that show this.  Could you point me toward them, or toward a real-world example that uses the escaped semicolon?

(Original comment by None on 2009-01-31T15:10:38+00:00)
Here is a command to generate the problem
~/pygments/pygmentize -l clojure -f html
[\. \; \. \. \p]
^D
[\\. \\; \\. \\. \\p]


Bug: Additional break line when initializing or copy/pasting in the editor with break lines

When I initialize the Lexical editor from an DOM like

, passing through generateNodesFromDOM and inserting the generated nodes to the editor, it imports it with an additional break line like

. This makes the editor have more break lines than expected. It is also curious that both  count as one character if I delete them and count the characters.
@zeitstein mentioned in a discord chat that when trying to pass a single

 without break lines, it also imports it with an additional break line like

. They also mention that that this PR can be related -> https://github.com/facebook/lexical/pull/3581 (thanks for rising this up in the discord chat, here is the full thread: https://discord.com/channels/953974421008293909/1060331843578249376)
I also managed to reproduce it when copying some text with break lines from the Notes Application from my Mac.
Lexical version: 0.7.6
Steps To Reproduce

Write something like this (with some break lines) in a Note in the Mac Notes Application:

First line

Fifth line

Copy the five lines (or the block of text you have written) and paste it in the lexical playground editor
You can find that there are more than 5 lines in this particular case.

Here is an example of the InitialState plugin to initialize the editor from a preview HTML string (not sure why is duplicating the text in the codesandbox, in my code only runs once): https://codesandbox.io/s/break-line-example-w1ic2x?file=/src/plugins/InitialState.js
The current behavior
When copying or initializing some text with break lines, it duplicates them, making the text different from the expected one.
The expected behavior
When copying or initializing some text with break lines, the number of break lines is exactly the same as the one inserted in the editor.

I'm facing the same issue.

I'm facing the same issue. I've noticed $generateNodesFromDOM is adding an extra
 tag for each "empty" paragraph. If you put any character, eg. period or even empty space - the problem does not exist

Facing the same issue, exactly as @chalecki .

Facing the same issue!

I think it was introduced in #590 in commit f38d4d52f24abc26d59c73989fc92c36fab19f8d .
Commenting on this line https://github.com/facebook/lexical/blob/main/packages/lexical/src/LexicalReconciler.ts#L324 does the trick I think but I lack knowledge on the overall flow so would be best to hear from @trueadm more on this behavior

maybe this can helps u
const removeLineBreaks = (inputHtml: string): string => {
  let copy = inputHtml
  copy = copy.replaceAll('
', '')
  return copy
}

const onChange = (_: EditorState, editorInstance: LexicalEditor) => {
  editorInstance.update(() => {
    const generatedHtml = $generateHtmlFromNodes(editorInstance, null)
    let resultHtmlString = wrapTables(generatedHtml)
    resultHtmlString = removeLineBreaks(generatedHtml)
    setHtml(resultHtmlString)
  })
}

@almazkaliyev the point is not to remove every
 from the generated HTML, I want to keep the exact number of break lines from a copy/paste and when initialising the editor with some previous HTML saved from the database.

@thegreatercurve  do we have any updates for the fix for this issue ?

@thegreatercurve any updates? 😄

Having the same issue. An empty text field has the

</p by default

Rich text field
$generateHtmlFromNodes result

@oleksandr-danylchenko and @ferugi - I am experiencing both of your observations reproducibly as well.
@thegreatercurve - Let me know if anything we can do to help (ie test cases, repo steps, etc.)

I am experiencing a similar issue and would greatly appreciate any updates regarding the progress that has been made in resolving it. Thank you for your assistance.

This is my function to initialize the editor state from HTML. Since the lexical's renderer adds additional  tags, this function does the opposite – decreases the number of  tags by 1 in the parsed DOM and then parses DOM to nodes and inserts them into the editor.
const parser = new DOMParser();
const dom = parser.parseFromString(initialHtml, 'text/html');

const elementsWithBr = dom.querySelectorAll('*:not(br) > br');
for (let i = 0; i < elementsWithBr.length; i += 1) {
  const brElement = elementsWithBr[i];
  const parentElement = brElement.parentNode;
  const lastBr = parentElement?.querySelectorAll('br:last-child')[0];
  if (lastBr === brElement) {
    parentElement?.removeChild(brElement);
  }
}

const nodes = $generateNodesFromDOM(editor, dom);

$getRoot().select();
$insertNodes(nodes);

HI ,
I am facing this issue still in version 0.12.0

Hello, same issue in version 0.13.1

Same issue in version 0.13.1

Hello, I'm having the same issue but found a workaround, if you clear the editor before the insertion, the line break is removed.
$getRoot().clear();
$getRoot().select();
$insertNodes(nodes);

bless your soul;
cuz u set mine on fire

Hello, I'm having the same issue but found a workaround, if you clear the editor before the insertion, the line break is removed.
$getRoot().clear();
$getRoot().select();
$insertNodes(nodes);

Listen to this man and if you don't want the focus state after clear add. Please fix this Meta..
$setSelection(null);

how is this bug still exist after 2 years?

Because the temporary fix to clear the editor (root) before selection works well, thanks @dpr10


KeyError: 'sources'

Hi!
I'm regularly seeing the following error, when trying to run dbt-osmosis. I'm not quite sure, but I think this happens, when I change the folder structure of my models, after I already generated yaml files. When I run dbt-osmosis again, I will see the error from time to time:
Traceback (most recent call last):
  File "/home/projects/.envs/dbt_env/bin/dbt-osmosis", line 8, in <module>
    sys.exit(cli())
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/dbt_osmosis/main.py", line 80, in wrapper
    return func(*args, **kwargs)
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/dbt_osmosis/main.py", line 216, in refactor
    if runner.commit_project_restructure_to_disk():
  File "/home/projects/.envs/dbt_env/lib/python3.10/site-packages/dbt_osmosis/core/osmosis.py", line 681, in commit_project_restructure_to_disk
    if structure.output["sources"]:
KeyError: 'sources'

@awoehrl Hey! I also faced with this error - it happens usually when dbt-osmosis faces with duplicated model.
Your dbt-osmosis configuration sets a specific folder/files structure. When you generate YAML files, it places them according to your configuration path in your dbt_project.yml. If you change folder structure and run osmosis again - it will probably output in such an error - when trying to create a doc that already exists, but in a different location.
When you change the file structure of you models, remember to:

check if your current dbt-osmosis configuration need to be changed according to it
delete or move previously created YAML files to the configured location (because osmosis will not delete or move anything, it can only create new files or write to them)

To resolve this error try to look into the model file at which exception appeared and check if there are any duplicated YAML model exists already for it.


Parse error on pattern expression with a quoted symbol in it

System configuration
I've tried different combinations of ruby/prism versions, picked the most recent for an example
$ ruby --version
ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux]

$ ruby -r prism -e 'p Prism::VERSION'
"0.24.0"

Steps to reproduce
here's a simplified example
code = <<~RUBY
response = { status: 'ok', '3ds_status': 'redirect', url: 'url' }

case response
in { status: 'ok', '3ds_status': 'redirect', url: url }
  redirect_to url
in { status: 'ok' }
  status :ok
end
RUBY

Current behavior
prism is unable to parse quoted symbol in pattern matching expression
require 'prism'
Prism.parse(code).errors
# => [#<Prism::ParseError @message="expected a label after the `,` in the hash pattern" @location=#<Prism::Location @start_offset=99 @length=0 start_line=4> @level=:fatal>]

Expected behavior
prism has to parse this expression correctly, the same code works with current parser with no problems
require 'parser/current'
Parser::CurrentRuby.parse(code) # no errors

I just accidentally found a workaround. If a quoted symbol is placed first, everything seems to work just fine
Change this:
in { status: 'ok', '3ds_status': 'redirect', url: url }

To this:
in { '3ds_status': 'redirect', status: 'ok', url: url }

It won't work with two such symbols though:
in { '3ds_status': 'redirect', '4ds_status': 'collect', status: 'ok', url: url }

I plan to get to this this week btw. Out of curiosity, why are you using quotes at all?

Oh I see it has numbers.


[ir] Init Structure

Relates to https://github.com/envoyproxy/gateway/issues/32
Signed-off-by: Arko Dasgupta<EMAIL_ADDRESS>

Codecov Report

Merging #115 (93d11d3) into main (b2d95ac) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #115   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            5         5
=========================================
  Hits             5         5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eaa208...93d11d3. Read the comment docs.


typo, awesome-watch-os and awesome-rails-gem added

Hi,
I have added awesome-watch-os and awesome-rails-gem added.
Also, I fixed some typo and some style by following the awesome's contribution guideline.
Let me know if there is any problems :)

Thanks a lot!


A question about the definition of Expected Calibration Error in Appendix D.2

I think the definition of 'conf' only considers the confidence of a positive case.
Consider a sample with a true label of 0 and a predicted probability of 0.1. This should represent the model's confidence in class 0, rather than a lack of confidence in class 1. According to the formula in your paper, the calibration error for this sample would be CE = acc - conf = 1 - 0.1 = 0.9. However, if I swap class labels 0 and 1, making the true label 1 and the predicted probability 0.9, the calibration error becomes CE = acc - conf = 1 - 0.9 = 0.1. This is contradictory.
However, the 'binary_calibration_error function' in the 'torchmetrics.functional.classification' library in the code addresses this issue, ensuring that swapping sample labels does not affect the output results. Therefore, the code should be correct.

Hi,
That's a good point. Upon double-checking, the description on page 3 is correct, as it targets the multi-class case. But we did make a mistake in Equation 17. We'll correct this in a future version of the paper.

Hi,
That's a good point. For binary classification, the calibration error is not symmetric for classes 0 and 1. You can refer to this tutorial for details.

Hi,
That's a good point. For binary classification, the calibration error calculation is not symmetric for classes 0 and 1. You can refer to this tutorial for details.

Based on my testing, the results obtained from the 'binary_calibration_error' function in the 'torchmetrics.functional.classification' library are symmetric for classes 0 and 1, whereas the results from the code proposed in that tutorial are asymmetric. And someone in the comments of that tutorial pointed out the same issue.
As for the experimental details, the test data I used was

pred_1=[0.1, 0.2, 0.8], label_1=[0, 0, 1]
pred_2=1-pred_1=[0.9, 0.8, 0.2], label_2=1-label_1=[1, 1, 0]
The results given by 'binary_calibration_error' are 0.166 and 0.166. And the results given by that tutorial are 0.633 and 0.366.
I guess that in the 'binary_calibration_error' function, all confidences are mapped to the interval [0.5, 1]. For example, when pred = 0.1, the confidence would be 1 - 0.1 = 0.9.

After reviewing the implementations, you're correct. Equation 17 does not align with the code implementation. The accuracy calculation can be corrected as:
$$\text{acc}=\frac{1}{|B_s|}\sum_{n\in B_s} y_n$$
I apologize for the oversight and resulting confusion. I appreciate your attention to detail in bringing this to light.

After reviewing the implementations, you're correct. Equation 17 does not align with the code implementation. The accuracy calculation can be corrected as:
acc=1|Bs|∑n∈Bsyn
I apologize for the oversight and resulting confusion. I appreciate your attention to detail in bringing this to light.

Thanks for your update


additional logging to track down the missing downloads issue

I'll merge this, but a few questions:

Did you already apply this locally when restarting CGSpace tonight?
After testing, do we have to revert this? (I don't know how much extra logging this does, I don't want to cause disk space issues)
Shall I also merge it in 4_x-dev?

In normal operations it should not be triggered so disk space will not be an issue. I will have to rebuild the server for the change to take effect. It may be beneficial to first put it on dev before propagating to production.

Ok, so when do you want to test this? I thought you did something regarding logging on CGSpace when you restarted it last night.
I agree we should start on development.

Merged into 4_x-dev and therefore 4_x-prod. The problem ended up being caused by DS-2355, and a fix is being deployed.


Responsiveness to the Website

i like to work on it

i would like to work on it....
give my best in providing responsiveness to this canva project

Similar issue is already assigned refer #46


jedis 3.0 roadmap ?

@xiaolongyuan not defined yet. Change set is not yet closed and it's probable that we release 2.7.3 and 2.8 before that happens.


Store API responses in application for the calls that we expect a lot of use

At the moment we are not caching any calls. However, Twitter recommends following (here):

Store API responses in your application or on your site if you expect a lot of use.

I believe Tweepy has a caching method for both in memory and file system. Some calls like GetFollowers and GetFollowings can cache to avoid hitting rate limits

What do you think @smmtaheri ? Which one would be better in memory or file system?

@salehparsa We now should store the responses from Twitter in a simple file. Better not to add other packages like Redis/Memcache by now. Better to cache the JSON file (if we are using so) under /tmp

Yeap! That's exactly what I look after mate @narbehaj . I believe Tweepy also provides caching method at least AFAIK! Of course not a good time to move to Redis/Memcache tho but caching the call into File System would be a good idea.


Feature: escape hatch for Step Function Tasks

Functionless should offer an escape hatch for StepFunction Tasks so that users can drop down to a lower level to write tasks that functionless does not yet support.
One way this could work is by exposing a $AWS.Sfn.Task({...}) API. This would treat a Task like any other integration but allow Resource and Parameters to be specified.
Example:
$AWS.Sfn.Task({
  Resource: "arn:aws:states:::apigateway:invoke",
  Parameters: {
    ApiEndpoint: "example.execute-api.us-east-1.amazonaws.com",
    Method: "GET",
    Headers: {
      key: ["value1", "value2"],
    },
    Stage: "prod",
    Path: "bills",
    QueryParameters: {
      billId: ["123456"],
    },
    RequestBody: {},
    AuthType: "NO_AUTH",
  },
});

This makes a lot of sense. Going to add it to our Copy with the assumption that we'll add it!

Any thoughts on how the user gets access to task token?
{
   "StartAt":"Send message to SNS",
   "States":{
      "Send message to SNS":{
         "Type":"Task",
         "Resource":"arn:aws:states:::sns:publish.waitForTaskToken",
         "Parameters":{
            "TopicArn":"arn:aws:sns:us-east-1:123456789012:myTopic",
            "Message":{
               "Input.$":"$",
               "TaskToken.$":"$$.Task.Token"
            }
         },
         "End":true
      }
   }
}

I was thinking
$SFN.taskToken()
$SFN.task({
   Resource: "arn:aws:states:::sns:publish.waitForTaskToken",
   TopicArn: topic.topicArn,
   Message:{
       Input: myData,
       TaskToken: $SFN.taskToken()
   }
})


Update README.md

Create GitHub readme documentation

Codecov Report
Patch and project coverage have no change.

Comparison is base (65d7c07) 74.82% compared to head (692d2c3) 74.82%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   74.82%   74.82%
=======================================
  Files          11       11
  Lines         441      441
=======================================
  Hits          330      330
  Misses        111      111

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Attempting to make unicodedata2 optional

This edit moves unicodedata2 to an optional install, and adds a try/except block to use the unicodedata built into python if unicodedata2 can't be imported. It also cleans up a double import.

seems like a solid change — thanks for putting that together!


Missing status code in cvxopt STATUS_MAP

Missing status code for "LP relaxation is dual infeasible" from CVXOPT: https://github.com/cvxopt/cvxopt/blob/master/src/C/glpk.c#L462

Thanks!


Update newrelic to 4.1.0

:tada: This PR is included in version 2.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Adding content of Day 11

Select the Day of Content
Day 11
What information is missing?
Pointer and Reference

assign me please


Not possible to configure ingress class

Not possible to configure ingress class with annotations, code will delete this annotation. I don't know reason, but it's not flexible. For example GKE with https support enabled will  try to use https lb, but sometime better use TCP LB with internal ingress.
https://github.com/bitpoke/wordpress-operator/blob/39f32a00478aef67b2286fcbf1788597d137ebc8/pkg/controller/wordpress/internal/sync/ingress.go#L103
Also ingress pathType hardcoded too.  I'd like to have ability to configure it self.

Not sure if it helps your case, but you can set it as a flag to the operator.
    spec:
      containers:
      - name: wordpress-operator
        image: bitpoke/wordpress-operator:v.0.12.1
        imagePullPolicy: Always
        args:
          - --ingress-class
          - nginx


Enable the Ethereum rate limiter

Refs: https://github.com/keep-network/keep-ecdsa/issues/524
Here we add the possibility of enabling the Ethereum rate limiter introduced by keep-network/keep-common#46

We need to update:
https://github.com/keep-network/keep-core/blob/2d3a9e0b70e80ac84a28addcb6ea24f2d5ce670b/solidity/scripts/lcl-client-config.js#L56
Otherwise, we'll end up with floating point values for RequestsPerSecondLimit and ConcurrencyLimit.

What are the recommended settings for RequestsPerSecondLimit and ConcurrencyLimi assuming I am running it against e.g. Infura? I am testing locally with 3 clients, each one holding about 22 group members, and configured with:
RequestsPerSecondLimit = 1
ConcurrencyLimit = 50

What I am observing is:

relay request TX mined at block 1147 @ 14:39:10
first "restoring signature from" log appeared around block 1190 @ 14:41:50
last "restoring signature from"  log (on the same client 👆 ) appeared at 14:42:06
relay request mined at block 1217 @ 14:43:41

What are the recommended settings for RequestsPerSecondLimit and ConcurrencyLimi assuming I am running it against e.g. Infura? I am testing locally with 3 clients, each one holding about 22 group members, and configured with:
RequestsPerSecondLimit = 1
ConcurrencyLimit = 50

What I am observing is:
* relay request TX mined at block 1147 @ 14:39:10

* first "restoring signature from" log appeared around block 1190 @ 14:41:50

* last "restoring signature from"  log (on the same client 👆 ) appeared at 14:42:06

* relay request mined at block 1217 @ 14:43:41

Please take a look at https://github.com/keep-network/keep-core/pull/2014.

What are the recommended settings for RequestsPerSecondLimit and ConcurrencyLimi assuming I am running it against e.g. Infura? I am testing locally with 3 clients, each one holding about 22 group members, and configured with:
RequestsPerSecondLimit = 1
ConcurrencyLimit = 50

What I am observing is:
* relay request TX mined at block 1147 @ 14:39:10

* first "restoring signature from" log appeared around block 1190 @ 14:41:50

* last "restoring signature from"  log (on the same client 👆 ) appeared at 14:42:06

* relay request mined at block 1217 @ 14:43:41

We logged all calls the client is doing to Ethereum and it all makes sense and works as designed. Having 20 members on one client means that we are subscribing to relay entry submitted event 20 times and with 1 request per second limit, we have a delay of 20 seconds. Given that 1 request per second is not something anyone will use on prod and we shouldn't have 20 members on one client, it all works fine and we are not going to do anything about it now.
However, having the rate limiter lets us easily detect problematic spots - we found and already fixed one: https://github.com/keep-network/keep-core/pull/2014. We are going to look through all the calls client is doing separately and see if we can do some cuts, e.g subscribe one time and not for every member.

Tested with
RequestsPerSecondLimit = 10
ConcurrencyLimit = 10

as well as with
RequestsPerSecondLimit = 1
ConcurrencyLimit = 50

Works as advertised.


feat(iam_group): adding IAM Group

This PR is included in version 1.0.0 :tada:

This PR is included in version 1.0.0 :tada:


Create a Social Post About Your Goose Experience! 🦢

Create a Social Post About Your Goose Experience! 🦢
Goose is your on-machine developer agent, automating engineering tasks seamlessly within your IDE or terminal. Guided by you, it can intelligently assess your project's needs, generate code modifications, and implement changes on its own.
Learn more about Goose in our documentation.
Once your content is merged, it will be featured on our Community Content site!
Example use cases
https://github.com/user-attachments/assets/0217fc29-3b0b-4ab5-8a60-2dc53eb2b293
https://github.com/user-attachments/assets/5497112f-7ebb-4e73-9611-191be6d1934f
🚀 Goal
Create an engaging social media post (Twitter/X thread, LinkedIn post, etc.) sharing your experience with Goose, a quick win, or a cool feature you discovered.
🤝 How You Can Contribute
Share things like:

A quick tip about using Goose
A before/after of how Goose helped you
A specific feature you found useful
A mini tutorial or walkthrough
Your favorite Goose command
A surprising way you used Goose

🔑 Tasks and Acceptance Criteria

[ ] Create a social media post about your Goose experience
[ ] Host your content on your preferred social platform
[ ] Add your content to the content/content.json file
[ ] Create a pull request with your changes

Your contribution in content.json must include:
{
    "type": "social",
    "thumbnail": "./img/your-thumbnail.png",
    "title": "Your Content Title",
    "link": "https://linktoyourcontent.com",
    "contributor": "Your Name"
}

🌟 Resources

Goose Documentation
Goose repo

Full episodes on Goose to understand more

Getting Started

Comment ".take" on this issue to get assigned
Fork the repository and create a new branch
Create your content
Submit a PR with your content.json addition
Wait for review and address any feedback

Questions?
If you have any questions or need clarification, please comment on this issue!
Happy sharing! 🦢
Would you like me to create the issues for shorts and videos as well?

.take


Update Mustache to v2.2.1

This PR updates Mustache to version v2.2.1 from v0.7.
Mostly everything Brackets uses Mustache for works as it used to except for Mustache.compile which has been completely removed for over 2 years. This PR also provides a simple polyfill for it for not to break extensions that might still be using it.

I'm all for use up-to-date libraries, but is there any reason beyond that to update Mustache?
Did you look if there is any extension use Mustache.compile?
Maybe using something like https://github.com/dangoor/BracketsExtensionGrabber.

@ficristo No much other reason than it's a low hanging fruit (that I had already done when doing #12006) that could provide some performance benefits, especially for ExtensionManager if the parsing is faster (which it should be).

I had a look at updating Mustache some months ago as well, but when I did it, I faced some display issues in the Extension Manager.
So we should definitely look out for regressions.
I may get to have a look soon (at least I hope so).

I've now had a look at this PR, and noticed the issue I had before is still present - in the Extension Manager dialog, extension author's names are no longer shown.
(If you need help in resolving the merge conflicts, please say so, I have a working branch local)

My latest changes are up at MarcelGerber:update-mustache (see https://github.com/adobe/brackets/compare/8093791728cbff6f7734fbad41882481c82087f9...MarcelGerber:update-mustache for a changeset against current master).
I've also filed the issue with Mustache: https://github.com/janl/mustache.js/issues/566
And, to complete, I've looked for extensions that use Mustache.compile and found these:

brackets-cuwire
brackets-wallpaper
genuitec.team-extensions (for some reason, they have a copy of ExtensionManagerView?)
shreder uses Mustache.compilePartial, for which we don't have a polyfill!

Blarg, screwed rebasing this PR with your changes. @MarcelGerber feel free to open a new PR with your branch. Really great work finding the issues as always, I'll check if there's a simple way to polyfill the the compilePartial method.


Max_error in Interpolate Plugin

Dear my friend,
I found result difference in FPN output which leads to total MMDETECTION model convert result difference.  The  MAP  lower 4%
So I test the Interpolate Converter with  "python3 -m torch2trt_dynamic.test --name=interpolate"  command
(1) when I change the test code  in  interpolate_custom.py   as  :
@add_module_test(torch.float32, torch.device('cuda'), [(1, 256, 13, 19)])
def test_interpolate_size_4d_nearest():
return InterpolateTest( (25,37), mode='nearest')
the max error  is  0
(2) when I change the test code  in  interpolate_custom.py   as  :
@add_module_test(torch.float32, torch.device('cuda'), [(1, 256, 25, 37)])
def test_interpolate_size_4d_nearest():
return InterpolateTest( (50,74), mode='nearest')
the max error  is   tensor(6.6876, device='cuda:0')
Pls kindly help to fix this convert error

Hi
Thanks for the bug report.
The interpolate layer is implemented by IResizeLayer in TRT. I did found there are some different between pytorch and TRT in NEAREST mode. There is one pixel offset on some scales.
I have create a thread on nvidia forums, hope they can answer this question.
And, could you tell me what model are you using? The MAP loss should be less than 1% on most model on coco dataset(even with the interpolate problem).  Let me see if I can do something.

I converted the  faster_rcnn model  (faster_rcnn_r50_fpn_1x_coco_20200130-047c8118.pth)     from
https://github.com/open-mmlab/mmdetection/tree/master/configs/faster_rcnn
Interpolate plugin is used in FPN neck of the model
Acoording  to my  test,  if the score of bbox in mmdetection 0.9812,  the  score in tensorrt is 0.9808,   very small difference.
If the score of mmdetection is 0.72,  which just a little higher than the threshold 0.7， the score in tensorrt would change to 0.62.  Then it leads to the drop of MAP performance


feat: add params to symbols table

You can store them as a blob using termtobinary and then after querying them do binary to term

Fix the tests and then I'll review


Testing main on windows leads to some depency errors...

Hi folks, recently I needed to deploy Qhub on a windows machine and I easily succeeded using the v0.3.13. But I wanted to test if main was also an option there but noticed that we recently included some module functions that are not covered on windows... such as subprocess.Popen  and os.setsids:
see for reference
https://github.com/Quansight/qhub/blob/29f398af3542143751d52252b8a2204cd9c1e5cf/qhub/utils.py#L84
Is there a quick way we can work around that?
Also, for windows, we have a bug presented here
https://github.com/Quansight/qhub/blob/29f398af3542143751d52252b8a2204cd9c1e5cf/qhub/provider/terraform.py#L34
which is, there is no key in the above dictionary that matches the available version for AMD64 present on Hashicorp domain... which leads to an incomplete download. Also, for windows the binary ends with .exe wich need to be included here as well:
https://github.com/Quansight/qhub/blob/29f398af3542143751d52252b8a2204cd9c1e5cf/qhub/provider/terraform.py#L42
Or the file will not be recognized by the system.

Why are we trying to make QHub compatible with windows? Seems like it would be hard to maintain compatibility long term?

@viniciusdc was doing deployments for a client from a windows machine. This is solvable since there are only a few areas where this needs to be fixed. Help would be appreciated! We are putting this as low priority.


Review "white space" issue

Dependent on tables being fixed, accesibility stuff, etc.  Then needs review by users. One feedback "I dislike layout and page style (colour, print) and find difficult to read. (I have dyslexia.) Found it easier when shrunk page to small print."

I consider that the page where one inputs one's search parameters is far too spread out. It would be far easier to use if it was condensed so that there was not so much space between the various sections.

I don't like the new search at all, because the old one had all the parameters on a single screen, but the new one doesn't so it takes longer and is fiddlier to create or revise a search.

My first reaction to the new site was not positive because unlike in FreeCen1, I now have to scroll down to initiate a search instead of having all elements of the search screen available together.

Clumsy to use - I much prefer the old Freecen website which was simple to use on one page without having to keep clicking to the next box.


Make sure that CSS output doesn't contain escaped quotes.

Hi,
this is probably not the best way to handle this error, but I figured I might let you know about it anyway. It's easy to replicate: just create a Typography control and try and associate the "Monospace" value to it. The following is what's being output:
h1{font-family:"Monaco,"Lucida Sans Typewriter","Lucida Typewriter","Courier New",Courier,monospace";
As you can see, double quotes are escaped, which leads to broken styles on frontend. Since escaped quotes aren't useful in CSS, I thought that maybe we could get rid of entities altogether, when getting a field's value.
Thoughts?

Thank you Thank you for reporting this!
Using html_entity_decode for all font-families could be seen by some as a security risk, so instead I used str_replace only for font-families and not for all properties (after all, that's the only place where this happens...
Fixed on https://github.com/aristath/kirki/commit/c6aaee50f0b7153e62be826d944de2255e56ca8c
Thanks for reporting this! great catch!

That'll do it! Thanks to you for fixing this so quickly, keep it up!


Feature Request: Setting to remove paths from tab title

Description of the new feature/enhancement
Problem:
Tab titles are quite long including the full path of cmd.exe or powershell.exe which leaves little horizontal space for numerous tabs.
Other solutions:
Friendly name by overriding the title is already tracked by another issue, however, it loses the name of current running application.
Proposed feature:
Preserve the running executable and provide an option to trim the full paths to only the .exe names in tab title.  For example, cmd.exe, powershell.exe would display in tabs instead of the full path.
Proposed technical implementation details (optional)
Add a setting to let users filter display tab title string by removing full paths and only showing the exe filename.

This is something that's going to be addressed by #1320.
You can also just have your shell program change the title for you. Most decent shells provide a way to do this via the prompt (bash and powershell both work like this). In cmd.exe, title foo will set the tab title to foo.


[flutter_conductor] verify binaries signed test can fail to check out a ref

For example: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac beta verify_binaries_codesigned/361/overview
Exception on command "checkout master": Command "git checkout master" failed in directory "/opt/s/w/ir/x/w/flutter_conductor_checkouts/framework" to Checking out initialRef master. Git exited with error code 1.
stderr from git:
15:38:49.276694 exec-cmd.c:139          trace: resolved executable path from Darwin stack: /opt/s/w/ir/cipd_bin_packages/bin/git
15:38:49.277143 exec-cmd.c:238          trace: resolved executable dir: /opt/s/w/ir/cipd_bin_packages/bin
15:38:49.277813 git.c:455               trace: built-in: git checkout master
error: pathspec 'master' did not match any file(s) known to git

#0      Git._reportFailureAndExit (package:conductor_core/src/git.dart:77:5)
#1      Git.run (package:conductor_core/src/git.dart:43:7)
<asynchronous suspension>
#2      Repository.lazilyInitialize (package:conductor_core/src/repository.dart:184:7)
<asynchronous suspension>
#3      Repository.checkoutDirectory (package:conductor_core/src/repository.dart:132:5)
<asynchronous suspension>
#4      CodesignCommand.run (package:conductor_core/src/codesign.dart:116:28)
<asynchronous suspension>
#5      CommandRunner.runCommand (package:args/command_runner.dart:209:13)
<asynchronous suspension>
#6      main (file:///opt/s/w/ir/x/w/flutter%20sdk/dev/conductor/core/bin/cli.dart:78:5)
<asynchronous suspension>

I think the issue is that the given ref (here master) does not exist on the upstream (which is hte main framework repo LUCI clones).

/cc @XilaiZhang

For example:
LUCI Build: https://ci.chromium.org/p/flutter/builders/prod/Mac stable verify_binaries_codesigned/105?
Stderr: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8803040626938017825/+/u/Verify_binaries_codesigned/verify_binaries_codesigned/test_stderr

Bumping to P2 based on https://github.com/flutter/flutter/issues/111772.

Bumping to P2 based on #111772.

right, this is tracked in https://github.com/flutter/flutter/pull/111934


nixos/technitium-dns-server: init module

Description of changes
This PR initializes a module for the Technitium DNS Server.

Package has been added with https://github.com/NixOS/nixpkgs/pull/293326
Info on Technitium DNS Server: https://technitium.com/dns/
GitHub repo: https://github.com/TechnitiumSoftware/DnsServer

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Thank you very much for your review and the kind words!
I was surprised, that there was no package for Technitium -- best DNS server out there. ;-)

It would be good to write a nixos test for the module and add it to passthru.tests for the package.

Tbh, I currently don't know how to do that. I'd prefer to add tests in a future iteration once I have more time to look into tests.

Unfortunately, one of the check is failing now. I assume that it's not an error on my end?
Binary cache nixpkgs-ci doesn't exist or it's private and you need a token: Start by visiting https://app.cachix.org/ and create a personal/cache auth token.

  To configure the token:

  a) Via environment variable:

  $ export CACHIX_AUTH_TOKEN=<token...>

  b) Via configuration file:

  $ cachix authtoken <token...>::error::Action failed with error: Error: The process '/home/runner/.nix-profile/bin/cachix' failed with exit code 1

I just re-ran the job, let's see.

Would it be possible to add a test? For example a trivial test starting the service and checking if the port is open?

I added the tests, let me know if it's good for you.

I added the tests, let me know if it's good for you.

Thank you very much!
That looks good to me!

@ofborg build technitium-dns-server

@ofborg build technitium-dns-server

@ofborg build technitium-dns-server

Sorry to bother you again. Anything I can do on my side for this PR?

Thanks! :-)


Add docs to UCF101 and HMDB51 datasets

Also add the transform argument to the datasets.
cc @bjuncek

Codecov Report

Merging #1184 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #1184     +/-   ##
=========================================
- Coverage   65.87%   65.77%   -0.1%
=========================================
  Files          79       79
  Lines        5849     5859     +10
  Branches      890      894      +4
=========================================
+ Hits         3853     3854      +1
- Misses       1726     1736     +10
+ Partials      270      269      -1

Impacted Files
Coverage Δ

torchvision/datasets/ucf101.py
25% <0%> (-3.21%)
:arrow_down:

torchvision/datasets/hmdb51.py
27.65% <0%> (-3.3%)
:arrow_down:

torchvision/transforms/functional.py
71.38% <0%> (+0.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4d17f...a918b0e. Read the comment docs.


[LCS][nit] factorize length parser

Motivation
I just saw that we were duplicating these lines of code in the deserializer.
Test Plan
unit tests

@bors-libra r=huitseeker

:pushpin: Commit 7ac0419 has been approved by huitseeker

:hourglass: Testing commit 7ac0419245317c0fc624a666e5df8b0fd2fe6f51 with merge<PHONE_NUMBER>454f38a99f8b912aee43fd245c6fc7...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: huitseeker
Pushing<PHONE_NUMBER>454f38a99f8b912aee43fd245c6fc7 to master...