[Crash] OutOfMemoryError crashes

Expected Behavior
No OutOfMemory crashes
Current Behavior
We see a crazy number of crashes affecting a few users on Crashlytics (version 1.12.2):

This issue has 30,698 crash events affecting 7 users

Fatal Exception: java.lang.OutOfMemoryError: Failed to allocate a 218125360 byte allocation with 25165824 free bytes and 118MB until OOM, target footprint 169589056, growth limit 268435456
       at java.util.Properties.loadConvert(Properties.java:546)
       at java.util.Properties.load0(Properties.java:390)
       at java.util.Properties.load(Properties.java:337)
       at com.amplitude.id.utilities.PropertiesFile.load(PropertiesFile.kt:22)
       at com.amplitude.id.FileIdentityStorage.<init>(FileIdentityStorage.kt:23)
       at com.amplitude.id.FileIdentityStorageProvider.getIdentityStorage(FileIdentityStorage.kt:71)
       at com.amplitude.core.Amplitude$build$built$1.invokeSuspend(Amplitude.kt:105)
       at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
       at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
       at java.lang.Thread.run(Thread.java:1012)

Possible Solution
No idea
Steps to Reproduce
No idea
Environment

We started seeing this today as well. one user with over 1000 crashes in 4 days. The app crashes every two minutes for that user. From where the crash happens, could the issue be that the file storing properties somehow gets too big and then the SDK fails initialising every time because it tries to load the entire file into memory?

I believe the users are getting into a “crash loop”

A lot of identifies are captured
SDK tried to load into memory
OOM error is thrown
App crashes
Repeat

The linked fix will catch the error, prevent a crash, and clear the "overloaded" file.
We will look more into the root cause and see if we can add better handling in a future PR.


feat: progress bar for next batch

Add a new progress bar with inline label telling how much time until the next scheduled batch is pushed.
Type of change
Please delete options that are not relevant.

[x] New feature
[ ] Bug fix
[ ] Optimization
[ ] Refactor

Testing

Bring up a devnet and its explorer.
Go to the batches page.
At the beginning, it should say something like "10 minutes" (default for dev) with empty (gray) progress bar.
After you send a batch, and then stop sending, you should see the progress bar advanding (green) and the count decreasing, about once a minute.
When the count reaches 0, it should stay at 0, and the bar should be fully green.
When you start sending batches again, it should reset to 10.

You may also play with different timeouts by setting the env var MAX_BATCH_WAIT_MINUTES to different numbers of minutes.
Checklist

[ ] “Hotfix” to testnet, everything else to staging
[ ] Linked to Github Issue
[ ] This change depends on code or research by an external entity

[ ] Acknowledgements were updated to give credit

[ ] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

[ ] Has a known issue

Link to the open issue addressing it

[ ] If your PR changes the Operator compatibility (Ex: Upgrade prover versions)

[ ] This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
[ ] This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@Oppen here is a suggestion to avoid clip-path and use tailwind:
  def render(assigns) do
    ~H"""

          <%= @label %>

    """
  end

Other than those comments, the update logic worked fantastic.

@Oppen here is a suggestion to avoid clip-path, use tailwind and smooth transitions that should do it:
  def render(assigns) do
    ~H"""

          <%= @label %>

    """
  end

I can try this, but I don't quite grasp what it does. Also, note the duplicate label is intentional because it remains centered and depending on which half of the bar you see it it needs different styling.

Tried in order:

Replacing clip-path with width: breaks the bar hard.
Your last version with Tailwind: looks much better but contrast on the left side of the bar is a little low:

I applied the suggestions, tuning just a little bit the colors to improve contrast. Removed all extra CSS.


Android: fix JavaCameraView implementation

Fixed deadlock if camera is started and stopped immediately
Invalid pattern usage of Object.wait(). Refer to "spurious wakeup": http://docs.oracle.com/javase/8/docs/api/java/lang/Object.html#wait
Fixed buffer usage:
a) fix eliminates processing of zero NV12 (green in RGB) first frame
b) latest ready frame is delivered for processing (not previous)

@asmorkalov, can you please review it?

:+1:


expunger: add record analyzer

This PR adds the abstractions needed for running an analysis on client's records and a few checks. More checks would be added soon.

@NickSchimek updated the PR based on the discussion we had. The new changes are mainly modifying the Charge object directly with the type eligibility analysis result. Also fixed a few issues in existing objects.

Thanks for the PR @a-ilango. I see there are a lot of functions that need to be implemented, and we should probably make testing a priority as we're implementing. The requirements for the UI is to know if a charge can be expunged regardless of date rules so that it can be grouped into lists of charges that are eligible now, charges that are eligible in the future, and charges that are simply not eligible. Am I missing anything @hmarcks ? The main thing is to determine if a charge is eligible, all other features are nice to haves, and can be implemented later. Do you think it would be better to allow the frontend to analyze the time eligibility portion of the analysis? Then this analyzer can focus on analyzing a single charge?

I see there are a lot of functions that need to be implemented, and we should probably make testing a priority as we're implementing

Yes, having a thoroughly tested analyzer would be good to have.

Do you think it would be better to allow the frontend to analyze the time eligibility portion of the analysis?

It would be good to have all the analysis in one place. So I'd prefer it being here unless there's a strong reason to move it to front-end.

For each record, we want to show:
Time-eligibility - tricky because it has to consider all the records to know whether an individual record is eligible.
Type-eligibility - only has to consider it's own record.
Combined eligibility - if the record is ultimately eligible based on Time + Type.
Here's is a mockup with more details about the UI data, let me know if you have any questions or ideas (it's not final, but I think it's getting pretty solid):

@NickSchimek I've updated the PR based on your comments and re-organized the tests a bit. Please take a look. Thanks!


Drawing Image in XAML file

In wpf I was able to create Image.soure as a drawinImage, which is not available in WinUI. I like to draw path with a brush in XAML.
for example

I wish I should be able to create Image in only XAML file.

This feedback is more appropriate for the WinUI repo. Transferring.


Add a sample tfvars file

Since this module abstracts away Equinix Metal, adding a sample tfvars file with the various values required to use this module i.e. auth_token would help new users of the module to get this working.
It seems like there's a degree of assumed knowledge that would prevent a user from consuming the module.
Adding auth_token = "" to a tfvars file also doesn't help:
terraform plan -var-file=main.tfvars
╷
│ Warning: Value for undeclared variable
│
│ The root module does not declare a variable named "auth_token" but a value was found in file "main.tfvars". If you meant to use this value, add a "variable" block to the configuration.
│
│ To silence these warnings, use TF_VAR_... environment variables to provide certain "global" settings to all configurations in your organization. To reduce the verbosity of these warnings, use the -compact-warnings option.
╵
╷
│ Error: Missing required argument
│
│ The argument "auth_token" is required, but was not set.

An auth_token is required when configuring the Equinix Metal provider and shouldn't be part of this module but instead in a root module using this module.
An example is now available to illustrate this and also has a sample tfvars file
See commit 1f7567a5c5931e9d78a3e21b25fa866522e0bd3f


Dev

Coverage decreased (-1.4%) to 87.476% when pulling 5424e394ae42d10bbe567c59ef5a1f30108c2f14 on dev into 6bf6909aa166bf1e35c685314ccd89e599ce80ea on master.


Add the concept of scope.

ref: #545
And disallow remote reads and reads of directories above the working directory by default.

Thank you @k2tzumi !
ref: https://x.com/katzchum/status/1719324320017854602?s=20


Fix the imageRegistryUser param usage in the release pipeline

Changes
Fix the imageRegistryUser param usage in the release pipeline
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[x] pre-commit Passed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
NONE

/kind misc

/test pull-tekton-pipeline-beta-integration-tests

/test pull-tekton-pipeline-go-coverage-df

/test pull-tekton-pipeline-beta-integration-tests

/test pull-tekton-pipeline-go-coverage-df

/retest-required

/retest-required


Add ShellCheck runner to README

@pclalv just a week ago I've talked with a former colleague about how great it would be to have a ShellCheck Pronto runner 😄.
Thanks! 🙇


cmd/go: should 'go mod init' suggest (or run) 'go mod tidy'?

(This issue is a follow-on to #40728, based on a discussion with @dr2chase.)
Now that we're defaulting to -mod=readonly, users who create a module from existing source code will generally need to run go mod tidy before they can actually build the packages in the module.

Should go mod init check for source files and suggest that command?
Should go mod init go ahead and tidy the module itself? (We don't know whether the user intends to prune out some nested modules before tidying, but nested modules should be rare anyway.)

CC @jayconrod @matloob

We could instead tie this to go build -- if go build sees no go.mod, and fails to find packages, it could suggest running go mod init and then go mod tidy.  If it sees go.mod, and it is in the just-ran-go-init state, and fails to find packages, it could suggest running go mod tidy.

@dr2chase, as of CL 258298, go build will suggest running go get to obtain the missing package, although I suppose in theory we could further distinguish whether the importer is in the main module and suggest go mod tidy instead in that case.

Hmm, but that's a good point: we should not suggest go get or go mod tidy if we are not working within a module.

I think go mod init should suggest go mod tidy if the directory is not empty and we aren't importing a configuration file from a vendoring tool. If the directory is empty, the user is creating a new project, and go mod tidy won't do anything yet. If we're importing a configuration file, go mod tidy might make sense, but we'll probably want different wording for the message.
I don't think go mod init should run go mod tidy automatically. It's almost always the next step, but I think if we keep those two commands discrete, users will be better able to understand their purposes. Users will learn that go mod tidy is the command that fixes dependencies. I'd be worried about people forgetting go mod tidy, then deleting go.mod and running go mod init again to fix dependencies.

Something I noticed yesterday: when go mod init imports a vendoring configuration file (like Gopkg.lock), it translates the requirements pretty directly without fetching go.mod files or upgrading things for consistency with MVS. This conflicts with the new -mod=readonly default: you tend to start out with an inconsistent go.mod file, and you can't do anything until you run go mod tidy.
I still think go mod tidy should be an extra step, but go mod init should at least ensure an imported go.mod is consistent.

Resolving this issue. It still seems better to me for go mod tidy to be a separate step. Please comment if you feel otherwise.
As of 1.16beta1, go mod init will suggest running go mod tidy if there are .go files in the current directory and no vendor configuration file is imported.

Resolving this issue. It still seems better to me for go mod tidy to be a separate step. Please comment if you feel otherwise.
As of 1.16beta1, go mod init will suggest running go mod tidy if there are .go files in the current directory and no vendor configuration file is imported.


HMAC validation failed

I got this issue "HMAC validation failed". When i removed this server.use(verifyRequest()); It is working fine but i need this verfyRequest . So please help me to solve this issue.Thanks

Could you provide a bit more context as to your setup; and a more detailed log of the error message too. Thanks!

@sunnyrvtech Just wanted to follow up and see if you're still having this issue and if you wanted to provide more details?
I also wanted to make sure you take a look at the shopify-koa-auth docs:
https://github.com/Shopify/quilt/tree/master/packages/koa-shopify-auth

Hi @katiedavis
Yes i am still getting this issue . I have checked the same code in my linux system and here it is working fine . The issue i am getting in the window7 pc.

Also getting one more issue after click on choose product from resource picker component.
"Network error: Unexpected token U in JSON at position 0"
graphql query return 403 response.  I think the header is not sent with request thats why it return 403 response.
In this package ,there are lots of issue . I have already mentioned about build production issue . But this issue is removed from the list .Not sure why ?
Is there any demo that works well without any issues ?

facing same issue while deploying my app on heroku, any update on this one ?

For more information on deploying your app to heroku, please consider using the Shopify-App-CLI
There's detailed information on deploying here


Ensure we don't overwrite already imported issues

Add some mechanism to ensure we don't change the contents of already imported GitHub issues unless the user specifies a --force option.

Use last updated date from each platform to determine which version of the data is newer.


Parser does't support binary strings

Serialized objects can containt null bytes. From php.net:

Object's private members have the class name prepended to the member name; protected members
have a '*' prepended to the member name. These prepended values have null bytes on either side.

That quote is about protected member names in the serialization of an object. That is supported; see https://github.com/bd808/php-unserialize-js/blob/master/phpUnserialize.js#L164-L206
Serialized strings could also contain embedded nulls and the parser should deal with that fine as well because PHP string serialization is done by sending a length and the data: https://github.com/bd808/php-unserialize-js/blob/master/phpUnserialize.js#L79-L98
Do  you have an example of valid PHP serialized data that is failing to parse for you?

@bd808 Thanks for the response!


Coloring the Sheet background rather than replacing it with a flat color

Heya! I was wondering if you had considered coloring the Sheet background, rather than just straight up replace it with a flat color. Did some trial-and-error earlier with multiply-based blending and got some pretty good results in combination with a DrawRoomBackground() hook:

const MOD_API: ModSDKModAPI;

MOD_API.hookFunction("DrawRoomBackground", 0, ([URL, ...args], next) => {
    next([URL, ...args]);
    if (URL.includes("Sheet.jpg")) {
        MainCanvas.globalCompositeOperation = "multiply";
        const color = "lightblue"
        DrawRect(0, 0, 2000, 1000, color);
        MainCanvas.globalCompositeOperation = "source-over";
    }
});

Oh, well wow. I wanted to do this from the start, when mod was an idea, but unfortunately I was too lazy back then to figure out for to do that properly. So as a result I just replaced it with flat color. Now I want to implement it^^
Will add option to choose between flat color and colored sheet. (At first I didn't even understand what you did want from me. Sleep is important~)
Thank you!

Also, I suppose that's how icons can be colorized? Because now it does.. well, bad things.. needed to cache colorized icons to make FPS more stable...

Also, I suppose that's how icons can be colorized?

Could be? Haven't looked at the implementation here, though I'm wondering if this would not be overkill since with normal BC buttons you can directly specify the background color anyway, no?

Yep, you're right, you can specify bg color, but some icons have white filling or outline, white color in general. So here I was getting icons that needed to be colorized, was colorizing them (every frame at first), then caching and using colorized ones.


How to load all tags

Is there a way to query for all tags that have been set up in ActiveCampaign?

https://SUBDOMAIN.api-us1.com/api/3/tags&api_key=API_KEY


[Bug] how to fix rocm platform bugs?

At present, my workmate and I use AMD GPU to support the SYCL platform on tvm, and want to do related evaluations on opencl, rocm, and sycl on AMD GPU. At present, I have made the sycl platform on tvm, but there are still problems with the rocm platform, Can you provide help to solve this problem together?
Expected behavior
I tried to execute mnist-model by tvm in rocm platform(rocm 5.2). The result of execution is error.
Actual behavior
The result of rocm platform not equal result of opencl platform
Environment
Operating System:Ubuntu 20.04
TVM version : https://github.com/apache/tvm/commit/7f1856d34f03113dc3a7733c010be43446161944
platform: rocm 5.2
Steps to reproduce
There is the my test example.

onnx_rocm.py
from pyexpat import model
import onnx
#from tvm.driver import tvmc
import numpy as np
import tvm
import tvm.relay as relay
from tvm.contrib import graph_executor
import tvm.testing
import numpy as np

dtype="float32"
common_prefix_str = "onnx-model/vision/classification/"
tol_paras = [1e-7,1e-6,1e-5,1e-4,1e-3,1e-2]
input_name = "Input3"
input_size = (1,1,28,28)
output_size = (1,10)

import logging
logging.basicConfig(level=logging.ERROR)

import warnings
warnings.filterwarnings('ignore')

def build(target:str,mod:tvm.IRModule, params:dict, input_name:str, input_data:np.ndarray, input:tuple, output: tuple) -> np.ndarray:
    tgt = tvm.target.Target(target=target, host="llvm")
    with tvm.transform.PassContext(opt_level=3):
        lib = relay.build(mod, target=target, params=params)
    dev = tvm.device(str(target), 0)
    module = graph_executor.GraphModule(lib["default"](dev))
    module.set_input(input_name, input_data)
    module.run()
    output_shape = output
    tvm_output = module.get_output(0, tvm.nd.empty(output_shape)).numpy()
    return tvm_output

def main():
    np.random.seed(0)
    I_np = np.random.uniform(size = input_size).astype(dtype)
    print(I_np[0][0][0][:10])
    onnx_model = onnx.load("onnx-model/vision/classification/mnist/model/mnist-7.onnx")
    mod,params = relay.frontend.from_onnx(onnx_model,{"Input3":I_np.shape})
    rocm_output = build("rocm",mod = mod,params = params,input_name = input_name,input_data = I_np, input = I_np.shape, output = output_size)
    opencl_output = build("opencl",mod = mod,params = params,input_name = input_name,input_data = I_np, input = I_np.shape, output = output_size)
    print(rocm_output[0][:10])
    print(opencl_output[0][:10])

main()

The result of output is as follow.

Thereis the execution result of my own implementation using sycl target.

Triage
sycl

needs-triage

Don't create a new issue when you already have https://github.com/apache/tvm/issues/13768
We didn't change any rocm code recently and I'm sure we had a working rocm backend before. So I have no idea what broke our backend.

Don't create a new issue when you already have #13768
We didn't change any rocm code recently and I'm sure we had a working rocm backend before. So I have no idea what broke our backend.

OK，Can you tell me the tvm version of the rocm backend that used to be available and rocm version that is working

I don't remember, but we didn't touch any rocm stuff. So I think recent rocm introduced some incompatibility with TVM. I'd try rocm 4 or even 3.

OK, Thank you. I try rocm 4.

cc @mvermeulen , is rocm 5 known to work with TVM?

cc @mvermeulen , is rocm 5 known to work with TVM?

Can you clarify which version of rocm has been verified under tvm? @masahi  @mvermeulen

@masahi and @wangzy0327 I have built ROCm with TVM periodically, last time was a few months ago with ROCm 5.2.3.  When doing that, I ran through basic unit tests but haven't done full verification.

Could you help me resolve the problem as above example?

@wangzy0327 - it will take a little before I have time - and then I'll try first to update to ROCm 5.4 for my testing.  However, a few things that can be tried in the interim:

The version of ROCm+TVM I verified with 5.2.3, I had posted to dockerhub (https://hub.docker.com/r/mevermeulen/rocm-tvm/tags) - so curious if you also see it there.
Does the issue happen with both target "rocm" and target "rocm -libs=miopen"?  Depending on the answer to this, might provide interesting difference.


Polkadot Awesomes NFT side -> "Profile" image doesn't appear

Is there an existing issue?

[X] I have searched the existing issues

What happened?

Please reproduce in steps
See the image what I uploaded. Thanks!
Expected Behavior
See the image what I uploaded. Thanks!
What browsers are you seeing the problem on?
Desktop Chrome
At which address did you encounter bug?
No response
Are you logged in?
None
Which wallet you are using?
No response
At which chain did you encounter bug?
No response
Screenshots
See the image what I uploaded. Thanks!
Wallet Address & Transaction hash
No response
Relevant log output
No response
Payment link for reward
https://canary.kodadot.xyz/dot/transfer/?target=<My_Polkadot_Address_check_https://github.com/kodadot/nft-gallery/blob/main/REWARDS.md#creating-your-dot-address>
Code of Conduct

[X] I agree to follow this project's Code of Conduct

same as #9194


SBT Logging too verbose despite logging not required.

I'm using the latest SNAPSHOT, and i can't avoid this logger from showing every line that SBT generates as DEBUG, even though my logLevel is set to INFO and I'm explicitly calling sbt with --info
Example messages produced:
[Step 1/1]
Initial source changes:
removed:Set()

added: Set(/data/....)

modified: Set()

Removed products: Set()

External API changes: API Changes: Set()

Modified binary dependencies: Set()

Initial directly invalidated sources: Set(/data...)

Sources indirectly invalidated by:

product: Set()

binary dep: Set()

external source: Set()

SBT is 0.13.6
Build.scala
logLevel := Level.Info

Logging is correctly outputted when using the "Auto" SBT mode, but then i don't get Test registration. Using the custom plugin registers the succesful tests, but then i get flooded with logging messages, which makes the console almost unusable and slows the build.

A multiproject is generating nearly 70 MBs in just compilation and simple tests.
Any updates?

Working on this. We've found that with latest version of SBT our runner is not working at all (due to some changes they made in sbt itself). I think we will have a new version shortly with some improvement in field of its verboseness as well.  Sorry for the inconvenience.

Thanks for the update.
Let me know as soon as you have any new version coming.
Thanks

I'm still having issues using a Custom location for SBT (to be able to configure plugins and repos), and using the SBT-TeamCity-Logger (version 0.1.0, not snapshot) addSbtPlugin("org.jetbrains.teamcity.plugins" % "sbt-teamcity-logger" % "0.1.0") Scala compiler (8s)[10:55:24][info] Set current project to SSE (in build file:/data/elt/local0/home/eltdev/TeamCity/buildAgent3/work/fe6c08143bb88c96/)[10:55:24][info] Applying State transformations jetbrains.buildServer.sbtlogger.SbtTeamCityLogger from /data/elt/local0/home/eltdev/TeamCity/buildAgent3/temp/agentTmp/agent-sbt/tc_plugin/sbt-teamcity-logger.jar[10:55:24]java.lang.ClassNotFoundException: jetbrains.buildServer.sbtlogger.SbtTeamCityLogger$[10:55:24]	 at java.net.URLClassLoader$1.run(URLClassLoader.java:372)[10:55:24]	 at java.net.URLClassLoader$1.run(URLClassLoader.java:361)[10:55:24]	 at java.security.AccessController.doPrivileged(Native Method)[10:55:24]	 at java.net.URLClassLoader.findClass(URLClassLoader.java:360)[10:55:24]	 at java.lang.ClassLoader.loadClass(ClassLoader.java:424)

Sorry for the inconvenience. I will try to figure and and the fix the problem as soon as possible.

any updates on this?
Thanks

The issue in YouTrack is now closed, but this bug is still very much open. Any updates?

https://youtrack.jetbrains.com/issue/TW-40415

thanks so much. It finally works! Went from 15-30mb logs to 2-5MBs. See YouTrack item above for resolution.

Thanks for your patience!
On Mon, Mar 23, 2015 at 3:55 PM, Fernando Racca<EMAIL_ADDRESS>wrote:

thanks so much. It finally works! Went from 15-30mb logs to 2-5MBs. See
YouTrack item above for resolution.
—
Reply to this email directly or view it on GitHub
https://github.com/JetBrains/sbt-tc-logger/issues/4#issuecomment-85036041
.


Parenthesized destructured assignments should fail to parse

The following code parses okay with the latest Esprima, but should throw an error:
({Object = 0, String = 0}) = {};

The destructured lefthand sides cannot be surrounded by parentheses. (See https://github.com/ternjs/acorn/pull/258#issuecomment-143948423 for more.)

Is the same as #1164?

Looks like it.

Oops, sorry about that.


python312Packages.topojson: init at 1.9; rdp,python312Package.simplification: init

Description of changes

From #328819 pr, but was removed from the commits (optional)
Might still be nice to have it
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 329928

x86_64-linux

:white_check_mark: 9 packages built:

python311Packages.simplification
python311Packages.simplification.dist
python311Packages.topojson
python311Packages.topojson.dist
python312Packages.simplification
python312Packages.simplification.dist
python312Packages.topojson
python312Packages.topojson.dist
rdp


FireBlocks Integration

Problem description
Currently, we are integrating one of the Key Management Tool such as Hashicorp, but in future, we would also require other tools to provide end users an option to select their required key management tool.
Requirements
We need to integrate FireBlocks , a Key management tool to manage the Keys and secure Guardian. To get complete info on Fireblocks, please look at https://www.fireblocks.com/
Definition of done
Integration of Fireblocks in Guardian
Documentation to be updated in detailed
Acceptance criteria
100% working of above functionality

This ticket is connected to #1606


Updated conf/eagle_2.config

Updated conf/eagle_2.config
Added error strategies for assemblies in conf/modules.config
Changed syntax in subworkflows/local/assembly_qc.nf
Changed channel name in workflows/seqqc.nf

Adding error strategies to assembly processes


Uncaught TypeError: Cannot read property 'getBuffer' of undefined

[Enter steps to reproduce below:]
Not quite sure, I think I closed a buffer.
Atom Version: 0.200.0
System: Mac OS X 10.10.3
Thrown From: atom-ternjs package, v0.6.0
Stack Trace
Uncaught TypeError: Cannot read property 'getBuffer' of undefined
At /Users/timou/.atom/packages/atom-ternjs/lib/linter.coffee:20

TypeError: Cannot read property 'getBuffer' of undefined
  at LinterTern.lintFile (/Users/timou/.atom/packages/atom-ternjs/lib/linter.coffee:20:20)
  at /Users/timou/.atom/packages/linter/lib/linter-view.coffee:163:18
  at Array.forEach (native)
  at /Users/timou/.atom/packages/linter/lib/linter-view.coffee:162:18
  at FSReqWrap.oncomplete (fs.js:77:15)

Commands
     -1:41.2.0 emmet:insert-formatted-line-break-only (atom-text-editor.editor)
     -1:41.2.0 editor:newline (atom-text-editor.editor)
  3x -0:18.2.0 core:undo (atom-text-editor.editor.is-focused)
     -0:09.1.0 core:save (atom-text-editor.editor.is-focused)
  2x -0:09.0 core:close (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "followSymlinks": true,
    "disabledPackages": [
      "grunt-runner",
      "tabular",
      "redmine",
      "preview-tabs",
      "vim-mode",
      "linter-js-standard"
    ],
    "projectHome": "/Users/timou/Code"
  }
}

Installed Packages
# User
atom-beautify, v0.27.2
atom-color-highlight, v3.0.9
atom-handlebars, v0.5.0
atom-jasmine, v0.5.0
atom-ternjs, v0.6.0
autocomplete-emojis, v2.2.2
bezier-curve-editor, v0.6.6
build, v0.33.0
color-picker, v1.7.0
docs-snippets, v0.8.0
editor-stats, v0.17.0
editorconfig, v1.0.0
emmet, v2.3.9
file-icons, v1.5.5
git-log, v0.3.0
git-tab-status, v1.9.2
hex, v0.6.2
language-actionscript3, v0.2.0
language-apache, v1.3.0
language-flex, v0.2.0
language-haml, v0.20.0
language-jade, v0.4.0
language-rspec, v0.3.0
language-slim, v0.4.0
linter, v0.12.4
linter-jshint, v0.1.4
linter-php, v0.0.12
minimap, v4.9.0
pain-split, v1.4.0
pretty-json, v0.3.3
project-manager, v1.15.5
project-palette-finder, v2.4.17
punchclock, v0.5.0
regex-railroad-diagram, v0.7.4

# Dev
No dev packages

:+1:


Error: Cannot find module 'jsonwebtoken'

Hello all.
I'm facing this very weird problem.
When I install jsonwebtoken on windows, I can easily require() and use it.
But when I install it on ubuntu (using --save, not globally), I always face this error:
Error: Cannot find module 'jsonwebtoken'
On Ubuntu, size of jsonwebtoken folder in node_modules is 90KB and 120KB on windows.
All I need to do is to copy this folder from windows to linux and it works.
Can any1 help?
Thanks.

More details:
package.json files are different on Ubuntu and Windows.
Please have a look:
package-ubuntu.json.txt
package-windows.json.txt

Can you provide the output of npm --version and node --version on Linux. It seems you may be using an old version of npm, and perhaps node.

Thanks for responding so quickly. Here goes:
Linux:
node v0.10.25
npm 1.3.10
Windows:
node v6.11.5
npm 3.10.10

Node version 0.10.25 and npm version 1.3.10 are very old and aren't supported anymore. This project requires at least Node 4. Take a look at nvm as a way to install a newer version of Node/npm on your Linux system.

Ouch sorry.
Thanks for your help.

No problem! Good luck. :)


fix: Add nathanwiebe2 for Nathan Wiebe metadata

Not sure if the ms.author is right, but I left it

:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/libraries/chemistry/concepts/hartree-fock.md
:warning:Warning

Details

articles/libraries/chemistry/concepts/quantum-dynamics.md
:warning:Warning

Details

articles/libraries/chemistry/concepts/quantum-models.md
:warning:Warning

Details

articles/libraries/chemistry/concepts/algorithms.md
:white_check_mark:Succeeded

articles/libraries/chemistry/concepts/jordan-wigner.md
:white_check_mark:Succeeded

articles/libraries/chemistry/concepts/second-quantization.md
:white_check_mark:Succeeded

articles/libraries/chemistry/concepts/symmetries-molecular.md
:white_check_mark:Succeeded

articles/libraries/chemistry/concepts/hartree-fock.md

[Warning] 1 invalid cross reference(s) "Broombridge schema".

articles/libraries/chemistry/concepts/quantum-dynamics.md

[Warning] 1 invalid cross reference(s) "conceptual docs".

articles/libraries/chemistry/concepts/quantum-models.md

[Warning] 1 invalid cross reference(s) "Quantum Dynamics".

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


pgvector: ensure vector is sent in binary representation

PostgreSQL supports two methods of passing data from client to server: text and binary. While for many data types the difference may not be noticeable, we can see significant performance impact when converting a vector from binary => text => binary representation. See previous explanation here[1].
While the pgvector loading code accounts for this, the query code did not. This is due to the use of a list[float] type, which the pgvector-python adapter currently doesn't support. However, this adapter does support direct binary transfer if the data is represent as a Numpy array[2]. Testing shows that moving to a direct binary representation does have a significant impact on query results - my tests are showing a 3x impact --  and provides a more accurate representation for how this workload would execute.
[1] https://github.com/erikbern/ann-benchmarks/pull/488
[2] https://github.com/pgvector/pgvector-python?tab=readme-ov-file#psycopg-3

/assign @xuanyang-cn

Updating with some additional testing: the speedup tends to impact queries that have higher throughput, e.g. for HNSW, lower values of hnsw.ef_search. This is due to the high throughput rate and reducing the overhead of converting from binary/text/binary. At higher values of hnsw.ef_search, the impact is less noticeable as more time is spent on the index lookups.

@XuanYang-cn Does this require additional changes? Thanks!

@jkatz Nice! Thank you for bringing this to our attention. We may need to recheck whether this has the same impact on other clients as well.

significant performance impact when converting a vector from binary => text => binary representation.


OpenCV with Qt backend, how can we test it?

Hello Ruslan and others,
Some time ago I contributed changes to OpenCV to enable to Qt backend which is used to create GUI in OpenCV (and really useful for testing and developing with OpenCV).
Now I need to use OpenCV's GUI module and things don't link anymore with the latest hunter version as of today.
I understand there is a problem compiling Qt on Travis, is there any other way we can have tests that depend on Qt running? It is just mildly annoying that I wanted to jump straight into development, but have to fight with the build system once again.
As I side note, I am aware of the gtk backend for OpenCV. Being desperate, I did try to add gtk to hunter locally, but libtiff4 used by hunter does not have the pkgconfig files, so one of the dependencies of gtk (can't remember which), does not find it at  ./configure time. Also, the gtk backend for OpenCV is poor compared to Qt's, so this would not be an ideal solution.
Without the GUI backend I have to keep writing images to disk and examining them after the program runs, which makes development with OpenCV very slow. If anyone can think of a way we could solve this problem in a scalable way, I will happily implement it.

I understand there is a problem compiling Qt on Travis

We are hitting timeouts on Travis because it takes a lot of time to compile Qt components. I'm uploading binaries from my local machine. Available toolchains can be found in pkg.qt branch:

https://github.com/ingenue/hunter/branches/all?utf8=✓&query=pkg.qt

Does that mean that if have another branch in ingenue, it should be enough to test it? Something like pkg.opencv-qt?

Something like pkg.opencv-qt?

It's better to add new entry to the testing matrix in pkg.opencv.

Cool, that can be done, what I don't know how to do is to enable CMAKE_ARGS
to Opencv with WITH_QT=YES through polly command line.
I only know how to do it creating a custom config.cmake for hunter and I
would need a branch for that.
What did you have in mind when you suggested to add it to the test matrix?
On Nov 13, 2017 13:59, "Ruslan Baratov"<EMAIL_ADDRESS>wrote:

Something like pkg.opencv-qt?
It's better to add new entry to the testing matrix in pkg.opencv.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ruslo/hunter/issues/1193#issuecomment-343964693, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFRiHxmd5ylk0cOtYLzYx-VEFwWTKGA5ks5s2GdmgaJpZM4Qb2DY
.

What did you have in mind when you suggested to add it to the test matrix?

Create example OpenCV-with-Qt and add local config with WITH_QT=YES. See OpenCV-extra example:

https://github.com/ruslo/hunter/blob/2a00835c620870fe8b6a6a2cfdd6af6008fb06c9/examples/OpenCV-extra/CMakeLists.txt#L5
https://github.com/ruslo/hunter/blob/2a00835c620870fe8b6a6a2cfdd6af6008fb06c9/examples/OpenCV-extra/config.cmake#L1-L9

Understood, thanks

nanogui (glfw based) might be a nice lightweight hunter package for this type of work (without the 2 hour QT builds).

Closing inactive discussion.


Assign organisation member to issue

Gogs version (or commit ref): <IP_ADDRESS>8
Operating system: Ubuntu 14.04 LTS Server
Database:

[ ] PostgreSQL
[x] MySQL
[ ] SQLite

Description
I cannot assign an organisation member to an issue within a repository which belongs to the organisation. The only user listed when trying to assign him is me. I couldn't reproduce it on try.gogs.io. Should I upgrade?
Edit:
The repo has been transfered from my account to the organisation before. I haven't tried that yet on try.gogs.io...

Additionally organisation members can't see repos which have been moved to the organisation.

Please upgrade and test again.

Well I'm on 9.13 and waiting for the next version. I'm not in a hurry :)

If you can't reproduce on demo site, I'm going to close this...

Well I couldn't reproduce this on the demo site. I'll try to fix it manually in the database.


[Enhancement] Possibility to delete comments

Hi! We often write larger texts with many revisions and iterations. By the time, especially when many people are involved, it get's chaotic with all the comments on the side, because we can't delete comments, even if they're fixed. Maybe the person can do, but also not after quitting the season so in any case they stay there forever... So especially the "main author" can't keep track on the comments and hasn't the possiblity to "moderate" the pad/the text. Would be cool to implement the option. Thanks in advance!

meanwhile a workaround could be to make your pad read-only, copy the text and start with a new pad. The link to the new pad could be added to the old one.


Refactor dwio test utils to accommodate integer logical types

Types such as Date, Decimals, etc. are wrappers over integer types.
This change makes it easy to add tests for these types.

This change reverts most of the changes made here https://github.com/facebookincubator/velox/pull/2714/files
and simplifies adding other integer logical types.

@Yuhta are the internal failures related?


Add Hello World description to Sphinx docs

@aregm There were no activity in the past three week. What is the current status of this task? Shall we abandon this request?
See more details in the linked PR:

#636


get started and services button made little larger

Description
As being important for people to click to make it approachable made just a little larger

Hey @harshita-2003 , can u pls required screenshots!

They were little smaller earlier but since they should be more approachable gave them a font size


tf.contrib.seq2seq attention_wrapper.py memory_sequence_length can not set None

tf version '1.1.0-rc2'
The problem is in attention_wrapper.py  77
memory_sequence_length = ops.convert_to_tensor(
memory_sequence_length, name="memory_sequence_length")
Don't check if memory_sequence_length is None

@ebrevdo

I believe this has been fixed in TF 1.2rc2 (here).


GraphDiff support for EntityFramework Core?

How long it will take to support EF Core 1.0?
Thanks

I think EF Core lacks of some metadata I need to merge the graph, but I will take a look and come back with an answer.
Thanks for your interest.

Try this one https://github.com/leonardoporro/EntityFrameworkCore.Detached.

@leonardoporro Thanks for your amazing work, which probably reclaimed lot of hours of reseach.
However ,the approach of GraphDff is completely different....
Indeed, it updates only what we want to update during the call of dbContext.UpdateGraph(...).
In your project, navigation properties are automatically loaded and updated during the save... It's not possible to load the graph at the demand (with several REST call client side by example) and then only merge loaded data by the client.
Do you think a such request could be implemented and handled atomatically in your project?

Duplicate of https://github.com/zzzprojects/GraphDiff/issues/149 (also no answer)

@Adriien-M Sorry for the late response. I've been working on a new version, that uses DTOs instead of the same entity.
So if you have an entity with 2 props and 3 navigations but you only want to load/update 1 prop and 1 navigation, it will be possible by creating a plain class with those properties.
Sadly, I had too much work at the office and didn't find enough time to work on it. But it will probably be ready on the first days of January.

Hello @MNF ,
On my part, I took the ownership of this library a month ago.
I'm currently recruiting a developer that will mostly assigned to open source project and will make some request like this one.
There is currently no date for this request, but I hope it will be in early 2018.
Best Regards,
Jonathan

Help us to support this library: Donate

any update about Core 2 ???

Hello @bdairy ,
We have investigated a lot this library recently. We are still learning it before spending some time to try to revamp it.
As said in the previous answer, we hope to be able to do it in early 2018.
There is no fixed date yet.
Best Regards,
Jonathan

Help us to support this library: Donate

I rewrote this library: Reconciler
I did that rather than contribute to this one as I don't fully understand the sources of GraphDiff and also I'm still uncertain about the difference between owned and associated - see Reconciler's readme where I compare semantics.
Anyway my rewrite works on EF6 and EFCore. The test coverage is still a bit thin, but the most important ones are there.

Thank @jtheisen ,
We have started to look at this library recently to re-wrote it for our new library: Entity Framework Classic. We hope to make a version for EF Core as well.
We will certainly look at your repository since the code looks a lot more light.
I recommend you to add a license file to your repository: https://github.com/zzzprojects/GraphDiff/blob/master/LICENSE to let people know about it.
Best Regards,
Jonathan

A port of EF6 to .NET Core is awesome! Thanks for that!
Added the licence.

Hi,
It has been a year that i have started to user GraphDiff, and i loved it.
I would like to use it in .net core, but cant right now :(
How long it will take to support EF Core ?
Thanks

I have the same question! Would loooovee to see Graphdiff for EF Core! Cheers

I would love to use EF core 5

Is it still no support for .Net Core?

Consider to use https://github.com/WahidBitar/EF-Core-Simple-Graph-Update.
It works well for me.


Blank screen after running

Blank screen after running
After "flutter run" the screen remains blank in android emulator running on a Mac
To reproduce
Navigate to example

cd example
flutter run

Logs
🛑 flutter run
Using hardware rendering with device Android SDK built for x86. If you get graphics artifacts, consider enabling software rendering
with "--enable-software-rendering".
Launching lib/main.dart on Android SDK built for x86 in debug mode...
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done                        16.9s
✓ Built build/app/outputs/apk/debug/app-debug.apk.
D/EGL_emulation( 5446): eglMakeCurrent: 0xae4545a0: ver 3 0 (tinfo 0xaa0e0660)
Syncing files to device Android SDK built for x86...             1,103ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).
An Observatory debugger and profiler on Android SDK built for x86 is available at: http://<IP_ADDRESS>:54597/EDMDMBW_8Os=/
I/WebViewFactory( 5446): Loading com.android.webview version 44.0.2403.119 (code 246011910)
D/        ( 5446): HostConnection::get() New Host Connection established 0xae44f180, tid 5457
D/        ( 5446): HostConnection::get() New Host Connection established 0xb2afe100, tid 5473
W/System  ( 5446): ClassLoader referenced unknown path: /system/app/webview/lib/x86
I/LibraryLoader( 5446): Time to load native libraries: 22 ms (timestamps 8412-8434)
I/LibraryLoader( 5446): Expected native library version number "",actual native library version number ""
V/WebViewChromiumFactoryProvider( 5446): Binding Chromium to main looper Looper (main, tid 1) {d2cfb07}
I/LibraryLoader( 5446): Expected native library version number "",actual native library version number ""
I/chromium( 5446): [INFO:library_loader_hooks.cc(120)] Chromium logging enabled: level = 0, default verbosity = 0
I/BrowserStartupController( 5446): Initializing chromium process, singleProcess=true
W/art     ( 5446): Attempt to remove non-JNI local reference, dumping thread
E/SysUtils( 5446): ApplicationContext is null in ApplicationStatus
W/chromium( 5446): [WARNING:resource_bundle.cc(285)] locale_file_path.empty()
E/libEGL  ( 5446): validate_display:255 error 3008 (EGL_BAD_DISPLAY)
E/libEGL  ( 5446): validate_display:255 error 3008 (EGL_BAD_DISPLAY)
D/EGL_emulation( 5446): eglCreateContext: 0xb409a860: maj 3 min 0 rcv 3
D/EGL_emulation( 5446): eglMakeCurrent: 0xb409a860: ver 3 0 (tinfo 0xa9fff110)
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x00008cdf
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x00008824
E/DataReductionProxySettingListener( 5446): No DRP key due to exception:java.lang.ClassNotFoundException: com.android.webview.chromium.Drp
W/AudioManagerAndroid( 5446): Requires BLUETOOTH permission
W/art     ( 5446): Attempt to remove non-JNI local reference, dumping thread
I/art     ( 5446): Background sticky concurrent mark sweep GC freed 11396(770KB) AllocSpace objects, 3(60KB) LOS objects, 68% free, 1180KB/3MB, paused 9.054ms total 77.452ms
W/AwContents( 5446): onDetachedFromWindow called when already detached. Ignoring
W/chromium( 5446): [WARNING:data_reduction_proxy_config.cc(423)] SPDY proxy OFF at startup
I/flutter ( 5446): >>>>>>>>>>>>>>>>> ModelViewer initializing...
D/EGL_emulation( 5446): eglMakeCurrent: 0xa9ffc420: ver 3 0 (tinfo 0xaa0e03c0)
D/        ( 5446): HostConnection::get() New Host Connection established 0x9ee5ef00, tid 5500
D/EGL_emulation( 5446): eglCreateContext: 0x992ec020: maj 3 min 0 rcv 3
D/EGL_emulation( 5446): eglMakeCurrent: 0x992ec020: ver 3 0 (tinfo 0x9ccf6090)
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x00008cdf
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x00008824
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x00008073
D/EGL_emulation( 5446): eglCreateContext: 0x992ebc00: maj 3 min 0 rcv 3
D/EGL_emulation( 5446): eglMakeCurrent: 0x992ebc00: ver 3 0 (tinfo 0x9ccf6090)
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x00008cdf
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x00008824
W/BindingManager( 5446): Cannot call determinedVisibility() - never saw a connection for the pid: 5446
D/EGL_emulation( 5446): eglMakeCurrent: 0x992ec020: ver 3 0 (tinfo 0x9ccf6090)
D/EGL_emulation( 5446): eglMakeCurrent: 0x992ebc00: ver 3 0 (tinfo 0x9ccf6090)
I/chromium( 5446): [INFO:CONSOLE(126)] "Uncaught SyntaxError: Unexpected token )", source:  (126)
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon( 5446): glUtilsParamSize: unknow param 0x00008073
D/EGL_emulation( 5446): eglMakeCurrent: 0xa9ffc420: ver 3 0 (tinfo 0xaa0e03c0)

Screenshots

The screen also remains blank on an Android emulator running on Windows and on physical Android devices.

The screen remains blank also in an Android emulator on Windows and physical Android devices. (Tested with Samsung s8, Samsung S20, Pixel 2XL, and Pixel 3)

The blank screen would tend to indicate a too-old Chrome version (see https://github.com/google/model-viewer/issues/1109#issuecomment-630911013), but on the other hand your long list of devices you tested with would counter-indicate that.
@bpedazur Could you check what the newest Chrome version is on a device (or emulator) that has this issue?

A closer examination of your log output indicates that your emulator is running a 2015-era release of Chrome or Chromium:
I/WebViewFactory( 5446): Loading com.android.webview version 44.0.2403.119 (code 246011910)

I'm afraid that such an old browser will definitely not work for the <model-viewer> web component this widget is based on. See https://github.com/google/model-viewer/issues/1109.
I'm closing this for now, pending more information about the physical devices you had trouble with. I'd suggest to re-try with the latest 0.8.0 release, which has many enhancements and bug fixes.

@sheky9 A closer examination of your log output indicates that your emulator is running a 2015-era release of Chrome or Chromium:
I/WebViewFactory( 5446): Loading com.android.webview version 44.0.2403.119 (code 246011910)

I'm afraid that such an old browser will definitely not work for the <model-viewer> web component this widget is based on. See https://github.com/google/model-viewer/issues/1109.
@bpedazur I'd suggest to re-try with the latest 0.8.0 release, which has many enhancements and bug fixes.
I'm closing this for now, pending more information about the physical devices you had trouble with.

I faced this problem in an emulator too. In my case I was already running Android 11.
What fixed it was setting the opengl version in the emulator to Opengl ES 3.0


Build(deps-dev): Bump @typescript-eslint/eslint-plugin from 5.31.0 to 5.32.0 (#3817)

Pull request opened by the merge tool on behalf of #3817

Merged in 808a2eaaa4bda4994fc675c1eef732f3c2ab1b4d


[$1000] Request - IOU is flooded with "Delete" comments

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Pre-Condition: User has Open Sent Requests

Open www.staging.new.expensify.com
Sign into a valid account
Go to the chat with open Requests
Click on the Preview
Click on "Delete"

Expected Result:
User expects the amount to be deleted and the amount updated in the preview
Actual Result:
Users chat if flooded with "Delete" comments, and if the user does this for a bunch of amounts, the actual preview is tossed all the way to the top and the user is forced to scroll upwards to see the amount left.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0146877ac1f9b7b507
Upwork Job ID:<PHONE_NUMBER>578885632
Last Price Increase: 2023-05-12

Contributor details
Your Expensify account email: [robin<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~012ec968f7113a1b63/

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~012ec968f7113a1b63/

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~012ec968f7113a1b63/

Not overdue, waiting for proposals and proposal reviews

Thanks @qispark, for the proposals. Your proposal works well and I test it with open two accounts.
@iwiznia We can go with @qispark proposal.
🎀 👀 🎀 C+ reviewed!

It looks like there is a regression (since 1.3.13-2) - the total preview is no longer shown. Instead, it's showing a preview for each individual request.
Should we still proceed with a PR, or wait until this is resolved in the latest build?
@mollfpr @iwiznia

@mountiny @luacmartins Could you guys help confirm if the above image for deleted IOU not updating and showing the IOU preview?

Sorry, why is it not valid anymore?

@iwiznia The OP expects the IOU to be updated and remains in the bottom position after a request for money is deleted, and as confirmed https://github.com/Expensify/App/issues/18642#issuecomment-1548005288 that we're not updating the IOU preview amount anymore.

ah ok


ARROW-6637: [C++] Further streamline default build, add ARROW_CSV CMake option

Default for ARROW_COMPUTE/DATASET/FILESYSTEM/JSON set to OFF
Add ARROW_CSV option, set to OFF by default (I could be swayed about this, but I think it is good to not create the perception that users are forced to build a module they don't need)
Disable unit tests that don't build if ARROW_COMPUTE=OFF

The minimal Docker build now outputs
https://gist.github.com/wesm/ff70f46f5bc256d6b1d7b979aab8e5d0
The minimal build time on my 8-core laptop is reduced from 72 seconds to 25 seconds. Here is the log for the default build (with jemalloc turned off) without this patch
https://gist.github.com/wesm/fb5300a1989420158b0148e1c49ab6d6
Note that the default for ARROW_JEMALLOC is left to ON. I agree based on other discussion that having it off by default might cause developers doing performance testing to draw the wrong conclusions due to worse performance from the system allocator.
TODO

[ ] Check conda
[ ] Check Homebrew
[ ] Check wheels
[ ] Check Linux packages

@ursabot crossbow submit -g wheel

@kszucs The Ursabot builds are going to fail here I think

@kszucs it's weird that the manylinux1 builds are building LLVM from source, is something wrong with the cached Docker image?

@ursabot crossbow submit -g wheel -g linux -g conda -g homebrew

@ursabot crossbow submit -g wheel -g linux -g conda

This is ready for review / merge once the package builds are all working. I'll work on a follow up patch to improve optional module / dependency management, something like -DARROW_BUILD_MODULES=csv,dataset,json,parquet

I'm aware of a few more places you'll want to turn these flags back ON or otherwise update docs:

https://github.com/apache/arrow/blob/master/dev/tasks/homebrew-formulae/apache-arrow.rb#L26
https://github.com/apache/arrow/blob/master/dev/tasks/homebrew-formulae/autobrew/apache-arrow.rb#L42
https://github.com/apache/arrow/blob/master/ci/PKGBUILD#L79
https://github.com/apache/arrow/blob/master/docs/source/developers/cpp.rst

@nealrichardson I'll take a look, but not that ARROW_PYTHON=ON implies COMPUTE, CSV, DATASET, FILESYSTEM, HDFS, JSON are all on, so it's not necessary to put these everywhere

ARROW_PYTHON is on for homebrew-cpp but not for the other places I noted, and in any case that sounds like something that deserves documentation.

Yes, will do.

@ursabot crossbow submit -g wheel -g linux -g conda

@pitrou @kszucs this is failing for the same reason that the manylinux nightlies are failing, due to the cached Docker image not properly downloading.
I checked the manylinux builds locally and all looking good there.
This is ready to merge

@ursabot crossbow submit macos-r-autobrew

I'll wait until tomorrow for the apache dockerhub access, if we get access then I'm going to push the manylinux images, otherwise I'm going to fall back to the previous docker org for the manylinux images.

I don't think the DockerHub issue should block this patch

I've merged https://github.com/apache/arrow/pull/5966 and rebased this on master.

@ursabot crossbow submit -g wheel

@kou I've disabled the responsible schedulers

Thanks!


[BugFix] Fix delete predicate in cross cluster replication for shared-data mode

Why I'm doing:
Delete predicate in shared-data mode is not the same with in shared-nothing mode.
What I'm doing:
Fix delete predicate in cross cluster replication for shared-data mode
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

Backport 3.2: https://github.com/StarRocks/starrocks/pull/42113
Backport 3.1: https://github.com/StarRocks/starrocks/pull/42129


Do you plan to have any docker support soon ?

I can provide a dockerfile and some run command for volume mapping if you like :)

I have not thought about adding it to be honest. Might consider if there is a use case for it.

Well my thought on this is : Docker is getting more and more love, and kong also support docker, their image is available right there https://hub.docker.com/r/mashape/kong/
So for some infrastructure based only on docker servers, it's really interesting to have everything setup with something as simple as :
$ docker pull CyExy/kongfig
followed by
$ docker run -v api_definition.yml:/srv/app/api_definition.yml CyExy/kongfig kongfig --path /srv/app/api_definition.yml --host [current-server-ip:port]
I run kongfig via docker through a private repository on dockerhub, but working with an official repo which is getting updated automatically would be awesome.

https://github.com/mybuilder/kongfig/pull/28
I did that, should help stuff get started :)

@JnMik PR is the correct way to make up to date Docker images. I needed one, however, just for the latest version. Based on @JnMik work (and others on Docker Hub) here's a simple Dockerfile to get started with.
FROM node:5-slim
ENV VERSION=1.3.0
WORKDIR /srv/app
RUN npm install -g kongfig@$VERSION

Build the image.
docker build -t my/kongfig:1.3.0 .

I use PowerShell and I can manage configurations with the following commands. This assumes you have a Kong container (named 'kong') running.
docker run --rm --link kong:kong my/kongfig kongfig dump --host kong:8001 > kongfig.yml
docker run --rm --link kong:kong -v $PWD/:/srv/app multrees/kongfig kongfig apply --host kong:8001 --path /srv/app/kongfig.yml

Note that the dump created a UTF-16LE encoded file which I needed to save as UTF-8 before I could apply it.


Update layout components for legacy theming

Issue Description
To help make the transition to terra-ui, we'll be providing a legacy theme. With this effort, there are some style adjustments needed to implement a theme similar to the design of the legacy layout.
Issue Type

[ ] New Feature
[x] Enhancement
[ ] Bug
[ ] Other

Expected Behavior
Theming styles are added to enable theming similar to legacy layout.

Resolved in #163


Editor dialects throwing errors on demo.gethue.com

Describe the bug:

On demo.gethue.com, only Pheonix dialect is available for querying.
Rest other dialects ( e.g. MySql, Hive etc.) are showing error and cannot load databases

Mysql

Hive

Steps to reproduce it?

Open demo.gethue.com
Try quering different dialects

Hue version or source? (e.g. open source 4.5, CDH 5.16, CDP 1.0...). System info (e.g. OS, Browser...).

Latest master

Hive, MySql looks good, maybe you tried during the daily reboot of the demo DBs?

I think that might be the case. Closing this issue.


Semantic labels incorrect when spawning objects with custom factory

I created a custom actor factory blueprint that inherits from CarlaActorFactoryBluePrint and follows a similar structure to the prop factory with the exception that instead of spawning a static mesh actor in my factory blueprint I spawn an actor using the "Spawn Actor from Class" node and use my own blueprint "PowerPylons" class to create an actor. This "PowerPylons" blueprint creates a couple of static mesh instances (defined as "movable"), which look like electrical poles with the power lines automatically connected (this why I need to use it as BP).
After spawning this actor using the Python API from the client side, the rgb image looks correct but the label of the new meshes in the semantic segmentation image is not correct . During debugging I discovered that the tagger in Tagger.cpp (assigning the semantic labels) is not even called after spawning my actors.
What do I need to do to make tagger work for my actors ?
P.S. I verified that using the same "PowerPylons" blueprint to build the static meshes in a level and then packaging it produces the correct segmentation label in the simulation.

I managed to discover that TagActor does get called when spawning my actors. The problem is that in the blueprint that creates them the static mesh instances are children of a Spline component (without any mesh) so Actor.GetComponents(StaticMeshComponents) does not return them. If anyone can please tell me how to get the children static mesh components that would be cool.
Thanks

So both of the following commands produce empty arrays:
Actor.GetComponents();
Actor.GetComponents();
That means I don't have any components in this actor. And yet, I can see them in the scene.
Weird....

I thought that the reason for this was that I created the mesh instances in the construction graph, but that wasn't it. I constructed the meshes by calling a function in the PowerPylons BP from the Spawn Actor function in the factory without using the construction graph but the result was the same.
A possible clue: I see that actor.get_transform() in Python gives all zero values after spawning it.


Makes error messages more clear when device rename fails

Addresses #228.  Error message when attempting to rename nonexistent device will now print "Device ___ not found."   If any other error occurs, the server's response will properly be printed out

Coverage decreased (-0.5%) to 18.687% when pulling 55cc13c92baf22f5d67d158335c06f25b95ab7b5 on derekmpeterson:rename_errors into b64252a42eae7b89b222011554a58777d29e8b08 on spark:master.

Coverage decreased (-0.009%) to 19.19% when pulling 60aee84293d9325623a9a731cc0a13bf100c9461 on derekmpeterson:rename_errors into 34364d9220c4275fd42c81d7b66a09b35af2d263 on spark:master.


Running multiple instances by supervisor

I'm running this script by the supervisor in the background. What will happen if I increase numprocs to something greater than 1? Will I have an enhance in my speed?
For example the following config:
[program:mtproxy]
command=python3.7 /opt/mtprotoproxy/mtprotoproxy.py
numprocs=10
process_name=%(program_name)s_%(process_num)02d

Yes, it will

Yes, it will

I didn't understand your answer. Can you describe your answer more? Why it will have a better speed?

Every process uses a single cpu core. If you have two cores you will get double performance if you run the script twice. If your server has 10 cores, it is better to run the proxy 10 times.
It is valid if you have really lot of users (~5 000) and the proxy process is cpu-bounded. If you have a few users, there will be no difference.

@alexbers
can't you make it multithreading?

the multi-threading is slow, the current approach is the fastest way to multiplex the proxy server on several cores since the multiplexing is done in the linux kernel.
It is better to use many small proxy-servers instead of big because the big one is very easy to block by traffic patterns. Also it if it advertised somewhere it will likely be blocked.


Loss function

This is an excellent work. I have reviewed the paper and code, and in Tetra-NeRF, only the pixel color loss function is used. I would like to ask, if a depth loss function is added to Tetra-NeRF, would the performance improve?   I would greatly appreciate it if you could reply to me.

Thank you! The depth loss would make a lot of sense to me and it could improve the performance. It could also be used to perform pruning on the tetrahedral mesh to improve rendering speed.

Thank you for your reply. How can I modify the code to incorporate depth loss supervision? I'm not very familiar with the tetra-nerf code.


Refactoring Status

Here's the status of the refactoring nonsense. I still want to get it done this weekend although that seems really overoptimistic at this point.

[x] Move navigator to new system.
[x] Move shop to new system.
[x] Move health to new system, add underlying support for it.
[x] Fix hurt sounds.
[x] Fix the big shop upgrades.
[x] Move tracers to a separate module.
[x] Move comms to new system, add hook for moving between ships.
[x] Fix artifacts.
[x] Fix health better.
[x] Improve death screen.
[x] Fix ship rendering, engine effects.
[x] Improve collisions.
[x] Tear out anything else that looks out of place in the main files, move to modules.
[x] Hide viewmodel when driving.
[x] Move fixer to second category.
[ ] Get the new map from Dan when he gets it working.


MINIFICPP-2082 Move RocksDB stats to RepositoryMetrics

Instead of printing the RocksDB specific metrics to the log file every 30 seconds, they are moved to the RepositoryMetrics. This way they can be published to any metric collector and should be able to print them to the log file as well periodically after MINIFICPP-2076 is merged.
Depends on MINIFICPP-2022
https://issues.apache.org/jira/browse/MINIFICPP-2082

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file?
[ ] If applicable, have you updated the NOTICE file?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

If I rebase this on top of the current main branch, then this test fails:
-------------------------------------------------------------------------------
Verify multiple metric nodes in logs
-------------------------------------------------------------------------------
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/unit/LogMetricsPublisherTests.cpp:77
...............................................................................

/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/unit/LogMetricsPublisherTests.cpp:77: FAILED:
due to a fatal error condition:
  SIGSEGV - Segmentation violation signal

Additional metrics were added for the rocksdb repositories in MINIFICPP-2022 which needs repositories to be initialized, which was missing in this PR. Fixed in 09d602981be237b3d562a6e2344d046378049fec


Add 'disabled' option the same as standard streamlit components

This adds the disabled kwarg to the component which will disable the buttons and set appropriate style when it is set to true.
Let me know if there are any issues with the PR @victoryhb

Hi Thanks for the commit! A couple of quick comments:

Let's not use any type hints in the code to keep the style consistent
Please add a description about the option in ReadMe.
I have no problem using a new formatter like Black, but if we do so please ensure all Python files follows this formatting.

Hi @victoryhb

No problem.
Have updated the doc string and README.md
Thanks, the two .py files have been run through black with the line-length slightly increased from the default to 99, all other settings are default.

Looks good. Thanks!

After further testing, the new code doesn’t appear to work with multiple menus on the same page? Will need to be further tested. Reverting for now.

Hey @victoryhb
Could you provide a screenshot and which browser you are using? I can fix that up.
On my end here with the default styling on your component it looks like this:

I used the same CSS properties that streamlit uses for its disabled option:
"cursor": "not-allowed"
"color": "rgba(250, 250, 250, 0.4)",
"border-color": "rgba(250, 250, 250, 0.2)",

I understand that your component supports custom styling though, so it might conflict with other styling a user applies - e.g. if they have a dark background it may be hard to see the text, if I change to a CSS filter instead of a fixed colour would you be open to testing and accepting another PR?

The disabled menus from the example code appear as above on my machine.
It's important for the option's appearance to adapt to different color themes. If you can fix this problem and show that it works across different themes I would accept it again. Thanks!


Having issue trying to resolve responsejs in vendor ts file/webpack

common.js:54 Uncaught TypeError: Cannot read property 'create' of undefined
at common.js:54
at Object. (common.js:497)
at Object. (common.js:497)
at webpack_require (bootstrap fb3897cf189a38522ec4:711)
at fn (bootstrap fb3897cf189a38522ec4:116)
at Object. (vendor.bundle.js:14240)
at webpack_require (bootstrap fb3897cf189a38522ec4:711)
at fn (bootstrap fb3897cf189a38522ec4:116)
at Object.defineProperty.value (vendor.bundle.js:14143)
at webpack_require (bootstrap fb3897cf189a38522ec4:711)

Can you please help me with this?

As in the meantime versions have been updated, do you still encounter this issue?


Spells with duration "Instantaneous" do not show up in Action tab

FVTT 0.7.9
DND5E 1.2.4
dnd5eCharacterActions 2.0.0
Character sheet: both native DND5E and Tidy5e 0.4.16
When a spell with a Duration of "Instantaneous" is on the character sheet, it does not show up on the Action tab as expected.  Example settings for Misty Step attached.  (Changing Duration to "1 Minute" causes the spell to render on the Action tab.)

Ah, here is another exception to the assumptions I made about "useful in combat". The current logic is something like:

Does it do damage (or healing)?
Does it have an activation time of 1 reaction?
If the setting is set, does it have a duration of 1 minute?

Otherwise we don't care about it.
Misty Step definitely is a combat spell and definitely doesn't fit any of those criteria. Going to have to think about that one.
Are there any spells which have an activation time of 1 Bonus Action but do not do damage that are not useful in combat?
Misty Step is useful, Expeditious Retreat is useful, Compelled Duel is useful... I think this rule can be safely implemented.
Thanks for the report!

Interestingly, this will also solve for Hex and Hunter's Mark! Excellent!


add initial delay seconds

This felt like the easiest possible solution to add a delay to the health check?  It's not the best answer though :/

Whats the reasoning behind this? If its just for dev we should keep it in the dev config only

oh, this is the open source chart, so this needs to go here before we can inject at the environment level.

so there will be a second pr that sets to a much higher value for dev, but in the tgg-helm repo.


Cannot load magrittr from a nonexistent .staging directory

From my local:
> run("ex1")
Loading required package: objectdiff

Attaching package: ‘objectdiff’

The following objects are masked from ‘package:base’:

    as.environment, assign, environment, environment<-, get, ls,
    parent.env, parent.env<-, rm

Loading model: models/dev/example1
Beginning 1. import stage...
  Running 1. Import from R...
Error in diff(old_object, new_object) :
  cannot open file '/Users/peterhurford/.R/lockbox/.staging/magrittr/R/magrittr.rdb': No such file or directory

Restart R and try again
On Monday, November 16, 2015, Peter Hurford<EMAIL_ADDRESS>wrote:

From my local:

run("ex1")Loading required package: objectdiff
Attaching package: ‘objectdiff’
The following objects are masked from ‘package:base’:

as.environment, assign, environment, environment<-, get, ls,
parent.env, parent.env<-, rm

Loading model: models/dev/example1Beginning 1. import stage...
Running 1. Import from R...Error in diff(old_object, new_object) :
cannot open file '/Users/peterhurford/.R/lockbox/.staging/magrittr/R/magrittr.rdb': No such file or directory
—
Reply to this email directly or view it on GitHub
https://github.com/syberia/example.sy/issues/1.

--
-Robert Krzyzanowski

Problem persists after restart

Thanks! I'll look into this
On Monday, November 16, 2015, Peter Hurford<EMAIL_ADDRESS>wrote:

Problem persists after restart
—
Reply to this email directly or view it on GitHub
https://github.com/syberia/example.sy/issues/1#issuecomment-157108947.

--
-Robert Krzyzanowski

This is no longer an issue for me. :+1:

I got this again when trying on a new computer, but it disappeared after restarting R.  This seems like something we should at minimum warn people about, if not figure out a fix.

@peterhurford Closing this.

@robertzk It will come up again if it's important. 👍


Clarify utilities & globals name

Utilities and functions/variables should not conflict with other programs/libs

I can speak about the names and types on C side.
IMO a lang prefix would be enough. So:

lang_en_gb + lang_en_gb_plural_rule

Closing:

utility name seems ok
variables can be discussed in C spec and template review.


Add support for Breadcrumbs

Has anyone added support for breadcrumbs? Would it make sense to use fluxor to update them? Or what would be the best strategy to update breadcrumbs in case where we have for instance:

/bloggers/:bloggerId/blogs/:blogId

Where do you think would be the most appropriate place to implement the breadcrumb navigation in this scenario?


Create application that handles dev account creation

Resolves #422
How to test this PR out:

Clone / checkout the create-user branch
Run npm install in the terminal
Start mongodb
Run the creation script with the command node /api/CreateUserScript.js. You can try variations with this like running the server/frontend and also running this script at the same time.

Looks good so far, few things:

Add a fullfillment message e.g. Success! Your account has been created.
Make sure the tool exits after the account is created instead of having it hang like this:

Add a script to our package.json in our topmost directory so we can run this tool like:

npm run create-user

should be done by now

Uh oh merge conflict!!!

We need to validate the input with email regex, here are some links:

rejecting a pre save

Add it here

email regex
Add default values to some inputs, e.g.

? Please enter a password (default: "sce"):

We need to validate the input with email regex, here are some links:

rejecting a pre save

Add it here

email regex
Add default values to some inputs, e.g.

? Please enter a password (default: "sce"):

done


Remove test scope and change Logger level to INFO.

Remove test scope for slf4j-log4j12 artifact
Change Logger level to INFO
Fix #1270

ok to test

[merge]


multiple json objects in input?

Hi,
thanks for gron, looks really useful!
I tried feeding in multiple json objects but noticed only the first one is reported:
$ echo -e '{"foo": "bar"}\n{"baz": "meh"}' | ./gron
json = {};
json.foo = "bar";

Is this something that can or will be supported?
thanks!

Hi @filippog! Thank you! :)
It certainly can be supported, and I think it would be a good idea.
Do you think it would be OK to enable the feature with a command line option rather than trying to auto-detect multiple objects in the input?

If autodetection is expensive and/or unreliable to convert to/from gron then yeah a command line option would do. Otherwise I was expecting gron to just work when fed multiple objects, case in point for me is reading from an access log where every entry is a json object, separated by \n

I've currently the same problem, in this case using it with jq:
Minimal example:
λ cat ~/gron_tmp
{
"data" : [
  {"a": "1"},
  {"a": "2"}
  ]
}

λ cat ~/gron_tmp |jq '.data[]'
{
  "a": "1"
}
{
  "a": "2"
}

λ cat ~/gron_tmp |jq '.data[]' |gron
json = {};
json.a = "1";

Hey, sorry this hasn't had the attention it needs... Kids keep you pretty busy!
I've been giving some thought about the approach needed for this, and there's probably only two sane options:

Require that the input be one JSON blob per line so it's easy to split on \n
Do a pre-parse step to detect multiple JSON objects in the input

Option 1 is by far the easiest to implement, but it doesn't work for @jan-schulz-k24's example where each JSON blob spans multiple lines.
Option 2 is far more permissive, but it requires a rune-by-rune inspection of the input text (you can't just, say, regex for }[^,]*{ because that sequence could appear in a string value)
The problem with option 2 is that it's pretty expensive to do, especially when the input is very large. This is made slightly better by only enabling multi-object input when a command line flag is specified.
On balance I think that gron working in more situations is more important than performance, so option 2 is probably best.

jq -c leaves one object per line. So IMO

it would be ok if gron could work with json-line/ndjson out of the box and without sacrisfying speed, and
only switches to the expensive "multiple lines per json object and multiple objects" parsing if a command line is given

@jan-schulz-k24 @filippog firstly: thank you for your patience!
I've added basic support for multi-object input in b9faf397
At the moment it only supports one object per line; I'm not 100% convinced this is the best solution but it's certainly the easiest to implement.
You can use the feature with the -s/--stream flag:
tom@work:~▶ cat stream.json
{"one": 1, "two": 2, "three": [1, 2, 3]}
{"one": 1, "two": 2, "three": [1, 2, 3]}
tom@work:~▶ gron --stream stream.json
json = [];
json[0] = {};
json[0].one = 1;
json[0].three = [];
json[0].three[0] = 1;
json[0].three[1] = 2;
json[0].three[2] = 3;
json[0].two = 2;
json[1] = {};
json[1].one = 1;
json[1].three = [];
json[1].three[0] = 1;
json[1].three[1] = 2;
json[1].three[2] = 3;
json[1].two = 2;

Internally it reads the input line by line, so it will start to provide output as soon as a line is available to read. So in the below example the output appears in three chunks with two second intervals between them.
tom@work:~▶ cat delay.sh
#!/bin/bash
echo '{"one": 1, "two": 2}'
sleep 2
echo '{"three": 3, "four": 4}'
sleep 2
echo '{"five": 5, "six": 6}'
tom@work:~▶ ./delay.sh | gron -s
json = [];
json[0] = {};
json[0].one = 1;
json[0].two = 2;
json[1] = {};
json[1].four = 4;
json[1].three = 3;
json[2] = {};
json[2].five = 5;
json[2].six = 6;

This should make it possible to work with steaming HTTP APIs - most of which seem to provide one object per line.
I haven't tagged a release yet, and I'm going to leave this issue open for a while longer because I'd like to think more about supporting objects that span many lines.
Let me know your thoughts / if you have any problems.
Thanks again for your patience at this particularly busy time in my life! :laughing:

Thanks @tomnomnom for working on this! I did a quick test with the dataset I have and works great with --stream !

I've got JSON output with multiple objects but they're not one-per-line - gron currently only handles the first of these objects.  I do have a hacky/sketchy patch for stream mode which handles this case but obviously don't want to step on any toes if there's another solution in the works?


NeptuneDeprecationWarning for neptune.init in NeptuneLogger

Bug description
The PyTorch lightning class pytorch_lightning.loggers.NeptuneLogger is a wrapper for the neptune-client logger. In this class, neptune.init is used. This function is deprecated and support for it will end in neptune-client==1.0.0. neptune.init_run should be used instead. This would remove the deprecation warning allows the NeptuneLogger to keep working with future neptune-client versions.
How to reproduce the bug
Initialise the `pytorch_lightning.loggers.NeptuneLogger` with a recent version of `neptune-client` installed. A NeptuneDeprecationWarning will be shown.

Error messages and logs
NeptuneDeprecationWarning: `init` is deprecated, use `init_run` instead. We'll end support of it in `neptune-client==1.0.0`.

Environment

#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 1.10):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info
No response

@wouterzwerink It looks like we missed this. Thanks for bringing it up. Would you be interested in contributing this change, by opening PR with the changed API call? 😃


Integrate coveralls to get test coverage

We need to get an idea on the percentage of code covered by our unit tests, and its evolution on time so that we can track the improvements. Coveralls provides integration with Travis, so we can use this.

Currently I'm trying to use stack hpc coveralls, which does not build:
--  While building package stack-hpc-coveralls-<IP_ADDRESS> using:

      /home/travis/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_<IP_ADDRESS>_ghc-8.0.2 --builddir=.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS> build --ghc-options " -ddump-hi -ddump-to-file"

    Process exited with code: ExitFailure 1

    Logs have been written to: /home/travis/build/TorXakis/TorXakis/.stack-work/logs/stack-hpc-coveralls-<IP_ADDRESS>.log

    Configuring stack-hpc-coveralls-<IP_ADDRESS>...

    Building stack-hpc-coveralls-<IP_ADDRESS>...

    Preprocessing library stack-hpc-coveralls-<IP_ADDRESS>...

    [1 of 6] Compiling SHC.Types        ( src/SHC/Types.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/SHC/Types.o )

    [2 of 6] Compiling SHC.Utils        ( src/SHC/Utils.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/SHC/Utils.o )

    [3 of 6] Compiling SHC.Stack        ( src/SHC/Stack.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/SHC/Stack.o )

    [4 of 6] Compiling SHC.Lix          ( src/SHC/Lix.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/SHC/Lix.o )

    [5 of 6] Compiling SHC.Coverage     ( src/SHC/Coverage.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/SHC/Coverage.o )

    [6 of 6] Compiling SHC.Api          ( src/SHC/Api.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/SHC/Api.o )

    /tmp/stack9121/stack-hpc-coveralls-<IP_ADDRESS>/src/SHC/Api.hs:48:36: error:

        Variable not in scope:

          checkStatus

            :: ASetter Options b a0 (Maybe (t2 -> t1 -> t0 -> Maybe a1))

We need to either fix the stack-hpc-coveralls package, or try plain hpc-coveralls.

Plain hpc-coveralls won't work either:
hpc-coveralls --coverage-mode=StrictlyFullLines --exclude-dir=sys/behave/test test behave-test

Couldn't find the hpc data directory

Couldn't find the directory dist/

Dumping dist/ directory content:

hpc-coveralls: dist/: getDirectoryContents:openDirStream: does not exist (No such file or directory)

No luck with codecov either:
--  While building package codecov-haskell-0.5.0 using:

      /home/travis/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_<IP_ADDRESS>_ghc-8.0.2 --builddir=.stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS> build --ghc-options " -ddump-hi -ddump-to-file"

    Process exited with code: ExitFailure 1

    Logs have been written to: /home/travis/build/TorXakis/TorXakis/.stack-work/logs/codecov-haskell-0.5.0.log

    Configuring codecov-haskell-0.5.0...

    Building codecov-haskell-0.5.0...

    Preprocessing library codecov-haskell-0.5.0...

    [1 of 9] Compiling Trace.Hpc.Codecov.Util ( src/Trace/Hpc/Codecov/Util.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Trace/Hpc/Codecov/Util.o )

    [2 of 9] Compiling Trace.Hpc.Codecov.Types ( src/Trace/Hpc/Codecov/Types.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Trace/Hpc/Codecov/Types.o )

    [3 of 9] Compiling Trace.Hpc.Codecov.Lix ( src/Trace/Hpc/Codecov/Lix.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Trace/Hpc/Codecov/Lix.o )

    [4 of 9] Compiling Trace.Hpc.Codecov.Curl ( src/Trace/Hpc/Codecov/Curl.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Trace/Hpc/Codecov/Curl.o )

    /tmp/stack9178/codecov-haskell-0.5.0/src/Trace/Hpc/Codecov/Curl.hs:52:56: error:

        • Variable not in scope:

            (<>) :: RetryPolicyM m1 -> RetryPolicyM m0 -> RetryPolicyM m

        • Perhaps you meant one of these:

            ‘<$>’ (imported from Control.Applicative),

            ‘*>’ (imported from Control.Applicative),

            ‘<$’ (imported from Control.Applicative)

    /tmp/stack9178/codecov-haskell-0.5.0/src/Trace/Hpc/Codecov/Curl.hs:55:20: error:

        • Couldn't match type ‘IO (Maybe a)’

                         with ‘RetryStatus -> IO (Maybe a)’

          Expected type: IO (Maybe a) -> IO (Maybe a)

            Actual type: (RetryStatus -> IO (Maybe a)) -> IO (Maybe a)

        • In the expression: retrying expRetryPolicy isNothingM

          In an equation for ‘performWithRetry’:

              performWithRetry

                = retrying expRetryPolicy isNothingM

                where

                    isNothingM _ = return . isNothing

        • Relevant bindings include

            performWithRetry :: IO (Maybe a) -> IO (Maybe a)

              (bound at src/Trace/Hpc/Codecov/Curl.hs:55:1)

And apparently we need to run stack with the --stack-yaml stack_linux.yaml flag:
codecov-haskell --tix-dir=$(stack path --local-hpc-root)/behave/ --mix-dir=$(stack path --dist-dir)/hpc/ behave-test

No compiler found, expected minor version match with ghc-8.0.2 (x86_64-integersimple) (based on resolver setting in /home/travis/build/TorXakis/TorXakis/stack.yaml).

To install the correct GHC into /home/travis/.stack/programs/x86_64-linux/, try running "stack setup" or use the "--install-ghc" flag.

No compiler found, expected minor version match with ghc-8.0.2 (x86_64-integersimple) (based on resolver setting in /home/travis/build/TorXakis/TorXakis/stack.yaml).

To install the correct GHC into /home/travis/.stack/programs/x86_64-linux/, try running "stack setup" or use the "--install-ghc" flag.

codecov-haskell: command not found

We tried this with a sample project and stack-hpc-coveralls <IP_ADDRESS> but we hit the problem that it doesn't support multi-project (https://github.com/rubik/stack-hpc-coveralls/issues/13)
$ shc combined all
shc: can not find project1-<IP_ADDRESS>-E2z62tZALLo4yNw20HlUkg/Data.String.Strip in .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/hpc
CallStack (from HasCallStack):
  error, called at libraries/hpc/Trace/Hpc/Mix.hs:122:15 in hpc-<IP_ADDRESS>:Trace.Hpc.Mix

Build result: https://travis-ci.org/keremispirli/testCoveralls/builds/260567558
Repo: https://github.com/keremispirli/testCoveralls


Sometimes 'originalEvent' is undefined

I noticed a scrolling bug with Samsung's Chrome Galaxy Tab  4.4. tap.js generated a 'tap' event when scrolling a page. This PR seems to fix that.

Wow! Thank you, @jonifreeman!


Added 'resize' operation to BoundedQueue

Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>Which problem is this PR solving?

This PR is a prerequisite for #943

Short description of the changes

This adds a new Resize(int) method to the BoundedQueue

how is it supposed to be used? who would call the Resize()? Isn't it possible to just pre-determine the queue size upfront?

how is it supposed to be used? who would call the Resize()?

A change to the span processor will make it keep track of the number of spans and the total bytes it has seen during the process lifetime. Once enough spans have been recorded, the span processor starts to calculate what's the ideal queue size based on the average number of spans and available memory. It can then decide to trigger a Resize() operation.
I have a local branch that does the above, but I thought it would be cleaner to separate those two features into separate PRs.

Isn't it possible to just pre-determine the queue size upfront?

When we know what's the expected average span size, yes. But I've not heard of any cases where people know in advance what's the average span size, making the queue size hard to calculate.

I just added a benchmark to the tests, to make ensure that I'm not bringing performance problems to the queue. Here are the results comparing master with this PR, which shows no performance degradation for current users of the queue (unless I'm making something really wrong with the benchmark):
$ git branch --show-current
master

$ go test -benchmem -run=^$ ./pkg/queue -bench "^(BenchmarkBoundedQueue)$"
goos: linux
goarch: amd64
pkg: github.com/jaegertracing/jaeger/pkg/queue
BenchmarkBoundedQueue-8   	19407266	        52.2 ns/op	       8 B/op	       1 allocs/op
PASS
ok  	github.com/jaegertracing/jaeger/pkg/queue	1.081s

$ git branch --show-current
Resize-bounded-queue

$ go test -benchmem -run=^$ ./pkg/queue -bench "^(BenchmarkBoundedQueue)$"
goos: linux
goarch: amd64
pkg: github.com/jaegertracing/jaeger/pkg/queue
BenchmarkBoundedQueue-8   	20110519	        51.4 ns/op	       8 B/op	       1 allocs/op
PASS
ok  	github.com/jaegertracing/jaeger/pkg/queue	1.099s

I am skeptical about relying on the average span size, because the actual size differences can be very large, 2-3 orders of magnitude, e.g a basic span vs. span with a stack trace vs. span with request payload added to the logs. I think if we want to go by memory size, we should go by the actual size of spans in the queue. The proto/domain model already implements Size() method iirc, which could be used as an approximation of the actual memory size, and we would need to re-implement the queue using an explicit buffer rather than a bound channel (might be worth looking around for an existing implementation).

the actual size differences can be very large, 2-3 orders of magnitude, e.g a basic span vs. span with a stack trace vs. span with request payload added to the logs

You are right, but in reality, this wouldn't be a big problem. The queue sizes will typically be big enough to make outliers non-relevant. In my working branch for #943, spans generated by tracegen have an average of 1.5KiB, which means a queue size of about 700k items at 1GiB. And even if spans start being bigger all of a sudden, the periodic background process will readjust the queue size as long as the difference is bigger than a few % points. Note that the "memory" aspect is an approximation: there shouldn't be a crash if we end up using more memory for a short period of time. And most of the times, the queue should be empty anyway ;-)
I would give this simple approach a try first and see how it works in the real world.

@yurishkuro any feedback on this one?

I wonder if it's possible to avoid the mutex by approaching this differently. Go routines are cheap to start, so rather than copying the messages into another queue, we could start another set of workers reading from a new channel, close the original channel and let those old workers drain it naturally and exit.

That could work, let me give it a try.

PR updated, to use a new channel for the resized queue.

@yurishkuro would you please re-review?

Thanks!


Fixing SWIFT_COMPILE_FLAGS ${SWIFT_RUNTIME_SWIFT_COMPILE_FLAGS}  -parse-stdlib.

This stdlib/public/Darwin/simd/CMakeLists.txt file has SWIFT_COMPILE_FLAGS specified on two separate lines which looks and probably is wrong.

@swift-ci please smoke test and merge


Add headers before response content is set

Hi again,
I'm adding paging to my Rest API based on bullet and I'd like to add some headers (X-Total-Count and Link).
Judging by the first lines of function header in response.php adding headers is impossible if the response has no content. Is there a reason why ?
For now I'm storing the content of my two headers in my $app ($app["X-Total-Count"] and $app["Link"]) and I add the headers in my response handler. It does not feel right even if it works without too much work. See below
Do you see a better solution ?
Thanks in advance.

Solved, see AppTest::testSupportCustomHeaders(). Commit b4b1dd7 make Response::content() fluent, and makes it easy to build and return a response in a single expression.


build: Add Slither config

What does this pull request do? Explain your changes. (required)

Adds Slither (Solidity static analyzer) config.
Specific updates (required)

How did you test each of these updates (required)

N/A
Does this pull request close any open issues?

N/A
Checklist:

[x] README and other documentation updated
[x] All tests using yarn test pass

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
281

Relevant Lines:
281

💛  - Coveralls


Make ModelExperimental handle classification

This PR adds support for classification models in ModelExperimental. This was accomplished without needing to create an equivalent of ClassificationModel. Instead, a ClassificationModelDrawCommand is created to handle the special classification commands.

Sandcastle for testing (updated for ModelExperimental -> Model). The tileset is clipped with a clipping plane so you can see the terrain underneath.
I also found #10160 while looking through issues related to classification, and I confirmed that the sandcastle (updated for ModelExperimental -> Model) doesn't crash with the changes in this PR.
Summary:

Added ClassificationModelDrawCommand. This is modeled after the commands in Vector3DTilePrimitive.
Added classificationType to ModelExperimental.
Model3DTileContent now passes the classification option to ModelExperimental.
Updated specs for various pipeline stages to accommodate the attribute / shader differences when rendering classification models.
Updated ModelExperimental specs for setting / changing classificationType.
Updated Model3DTileContent with the render specs from Batched3DModel3DTileContentClassificationSpec.

Thanks for the pull request @j9liu!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.

@ptrgags updated with the ModelExperimental -> Model changes!

Just for good measure, I tried swapping out the model in your Sandcastle example with other models. When I try it with the Microcosm example, I get a shader compilation error:
Sandcastle
RuntimeError: Fragment shader failed to compile.  Compile log: ERROR: 0:51: 'v_texCoord_0' : undeclared identifier
ERROR: 0:51: 'texture2D' : no matching overloaded function found
ERROR: 0:51: 'r' :  field selection requires structure or vector on left hand side
ERROR: 0:59: 'texCoord_0' :  no such field in structure
ERROR: 0:59: 'texture2D' : no matching overloaded function found
ERROR: 0:59: 'r' :  field selection requires structure or vector on left hand side

is this expected? I also tried BoxTextured and that worked fine

@ptrgags I pushed a fix -- I didn't realize that FeatureIdPipelineStage used texcoords, and those weren't being processed in GeometryPipelineStage for classification models.

I can confirm that the fix does fix things for Microcosm!
Updated Sandcastle

@ptrgags updated!

@ptrgags added the @experimental tags back in!

Looks good, thanks @j9liu!