Fix topic editing of messages that threw a backend error.

To reproduce:
Intercept messages by adding something like
    if messages:
        if messages[0]['message'].content == 'fail me':
            raise

to zerver.lib.actions.do_send_messages.
Send a few messages, and then send a message with content 'fail me'. Edit the message, change the topic, and hit save. The topic in the recipient row will change instead of the topic of just the message changing, which is a bug. The error is likely somewhere inside the call to echo.edit_locally(message, new_content, topic_changed ? new_topic : undefined); from message_edit.save.

@zulipbot claim

At one point I was able to reproduce the problem and track where the bug may have been. But, then I was unable to save edited drafts. I think there were some changes to Zulip that opens a print screen when trying to save an edited draft of a failed message. I have had to put this on hold due to time.

Thanks for the report @hollywoodno! No worries about putting it on hold; let us know when you are back :). And interesting observation with the drafts; there could well be bugs in this pathway for that system as well.

@zulipbot abandon

I tried to reproduce this issue, but I could not edit the message at all.

@zulipbot claim

@zulipbot abandon

hey @rishig i am trying to understand the issue but there are many other error that start popping like due to id's like 127.01 query selector did not get them without escaping period(.) is it fixed somewhere so i can focus on main issue that is changing topic of message instead of recipient row.
or i need to fix them too.

@zulipbot claim

@zulipbot abandon

@YashRE42 can you check if you fixed this in your recent message-editing PR?

@zulipbot  claim

I can't reproduce the original error because the failed message is not editable, however, closing the edit box is buggy because the close button doesn't work.

@zulipbot claim

@zulipbot claim

@zulipbot claim

@popochou0311 I see you were the last person to pick up this issue. I'm having trouble recreating this bug, did you have any success?

Can any guidance be provided on how the bug can be recreated so that I can help?

It is possible that this bug is no longer reproducible. @rodrickcalvin did you follow the instructions in the issue, and if so, what did you see?

Please assign me this issue I want to solve this issue

@sahil839 Do you know if this issue can be closed?

There is no way currently to directly edit a failed message. Maybe we showed edit icon previously when this issue was opened.

OK, closing as resolved.


Create Projects

Creation of Projects model and basic controllers

created on commit: https://github.com/MartinGHaas/TypeTaskPro-Backend/commit/f31c3b86ab4140f2d0b4af62a4eb1d0d3067b66e

update commit: https://github.com/MartinGHaas/TypeTaskPro-Backend/commit/ab495d29e5e16975d0254312bf60b8fe0e8f0700


Separate configuration of the plugin

Separate global configuration variables from the main ovirt.js script to specialized configuration file

new constants.js file added
See commit https://github.com/mareklibra/cockpit-ovirt/commit/d952df1813c5545bacdc8a208f956ac6d1fb6629


Add LiveUpdater and LiveUpdateHandler interface

What this PR does
This PR adds the LiveUpdater which is used for registering types implementing the LiveUpdateHandler interface.
Types implementing LiveUpdateHandler are used to manage a subset of live-updatable fields in the VMSpec, they just have to specify which fields they manage and a liveUpdateHandler implementation to react to changes to those fields.
This will help clean up the current implementation of the vmRolloutStrategy feature and should make it easier to introduce new live-updatable fields.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

@jean-edouard @xpivarc if you want to start taking a look at the approach and have some early feedback that'd be great.

@acardace I like the idea!
it will be god to see also which parts of the code are replaced by this new package, but I understand that this still in draft

@acardace how do you plan to update the VirtualMachineRestartRequired condition if there are multiple reasons why it should be updated. E.g update cpu AND memory. Would you run all the handlers and concatenate the reasons?

I don't plan to, only 1 handler will be run at a time. This is actually a bug in the current implementation (the design stated this should not be done IIRC).

/close


dbt-meshify split creates a funk-ily formatted dbt_project.yml file

Describe the bug

This is nit-picky, but have gotten feedback that it's important to prevent as many manual "fixes" as possible.
When I run the dbt-meshify split command and a new subproject is generated, the dbt_project.yml file that is creates has a weird format. It would be nice if we used the same dbt_project.yml format you get when you run a dbt init to create a new project.
Steps to reproduce

run dbt-meshify split command

Expected results

a dbt_project.yml file is created with the typical dbt yml format (same as when you run dbt-init)

Actual results

a dbt_project.yml file is created with an odd format

Screenshots and log output

System information
Which database are you using dbt with?

[ ] postgres
[ ] redshift
[ ] bigquery
[ ] snowflake
[ ] other (specify: ____________)

The output of dbt debug:
<output goes here>

The output of dbt --version:
<output goes here>

Additional context

Are you interested in contributing the fix?

Another thing I found odd here, was that only the folders that we're copying over are create.
In my case, there was no empty folder for tests, seeds, macros, etc. that I'd expect when running a dbt init.

I'd also potentially expect for my .gitignore file to be copied over and an empty / template README to be created

oh yeah it's funky as hell 😄  I don't know how much leeway the yml library we're using is going to give us to format the project yml the way we're used to seeing. Very open to suggestions
I'm going to split your folder and other project files suggestion into a separate issue!

Is there any reason to not just do a dbt init in the new project before pulling stuff over? Is that a better place to start from for a new project? Or is empty easier?

Elize also requested copying over the sqlfluff config file

Completed in #206


Changing name of tools and workflows

Feature Request
Desired behaviour
Implement a way for users to change the name of a workflow or tool in a similar way to display names for Organizations/collections described by #2119. This would also relate to aliases #1395, but would be the main name that appears in a workflow/tool landing page, as well as the name that appears in the search query. The main issue would be making this feature apply backwards to currently registered tools and workflows without losing existing history and metadata.
Specifics:

This name should also be unique and assigned on a first come first served basis.
User should be able to specify this display name during workflow/tool registration, but would be able edit field afterwards using the user interface.
This name should be separate from the UUID and url, changing the display name should not alter UUID or url.

┆Issue is synchronized with this Jira Story
┆Issue Number: DOCK-518

Should probably clarify that we have a couple of things that we're using like IDs floating around:

Database ID e.g. 100L
Path ID e.g. quay.io/pancancer/pcawg-dkfz-workflow:develop (not really a UUID, but it is universally unique)
Alias (arbitrary string, up to the user)

This proposal would add a display name which should not affect the above, but may be shown instead in various user facing GUI elements.


Boost human followed by MODs in search prioritization

Trying to find beta catenin in human, nearly impossible; e.g.
http://amigo2-test.stanford.edu/amigo/search/bioentity?q=CTNNB1
Ideally human would be first followed by MODs. This could be a configuration, or alternatively scoring each gene by number of experimental annotations would be a nice generic way to do it. This would be an easy field for @hdietze to add when loading.

To be fair one reason this is hard to find is due to this: #240

What this would boil down to would be two new fields, say: search_bin_priority_one and search_bin_priority_two. Human genes would populate the first one, MODs get the second, everybody else gets none.
The search would then be boosted on those two fields, say: search_bin_priority_one^4.0 search_bin_priority_two^2.0.

This is essentially the same as #102.
Tangentially related to berkeleybop/bbop-js#16.

Really, a refinement of the changes there. Will continue over there.


mpi(hwloc): spin-lock receiver threads and pin to a core

eventually we could consider using more advanced features with hwloc
closes #385 (superseeds)

-----------------------------------------------------------------------------------------------------------------
local/S       local/L       remote/S      remote/L      commit
-----------------------------------------------------------------------------------------------------------------
0.294         8.855         0.020         8.665         mpi
0.024 (0.08)  4.411 (0.50)  0.001 (0.05)  1.107 (0.13)  d9810b0d5dec2ff36ee9fdbda015137bb145364d # main
0.031 (0.11)  4.528 (0.51)  0.001 (0.05)  1.329 (0.15)  26568f78c368256eae5aa3cb74c94bc737bbd85a # mpi-struct
0.027 (0.09)  4.530 (0.51)  0.001 (0.05)  1.046 (0.12)  8eb27e0985b9d87834d822676a104b74faafb9a1 # ptp-struct
0.078 (0.27)  5.220 (0.59)  0.001 (0.05)  1.184 (0.14)  0b0f1b117ea03c2e8e0641ab56a9c8e4e97954a7 # spinlock
0.028 (0.10)  4.470 (0.50)  0.001 (0.05)  1.124 (0.13)  7b17b30706166ee777d8c05379ef37ca74029eb3 # ptp-no-order
-----------------------------------------------------------------------------------------------------------------
0.028 (0.10)  4.498 (0.51)  0.002 (0.10)  1.664 (0.19)  c3dbe3ba090e58d9488f9b3da0562265725a2e0d # new-main
0.038 (0.13)  4.839 (0.55)  0.002 (0.10)  1.771 (0.20)  63beeaffe0fbb7728628f616529d465f16614ccc # mpi-affinity
--------------------------------------------------------------------------------------------------------- (Mar 27)
0.162 (0.55)  5.443 (0.61)  0.000 (0.00)  0.183 (0.02)  e42395ac5c0fbad3c68cefaf93d8356163e9d4a9 # good
--------------------------------------------------------------------------------------------------------- (April 4)
0.030 (0.10)  4.513 (0.51)  0.005 (0.25)  0.747 (0.09)  a7d01b60d0df85a0e87a826f30f94068c8ab247d # mpi-st
--------------------------------------------------------------------------------------------------------- (April 5)
0.026 (0.09)  4.463 (0.50)  0.004 (0.20)  0.757 (0.09)  3e34a053140050907d8a8b77b6c22b691933b7ee # main-before-sock-opt
0.028 (0.10)  4.478 (0.51)  0.005 (0.25)  3.655 (0.42)  75b58f98fe6788f159ff6cd008251b6b4cdcdc65 # sock-opt
0.029 (0.10)  4.357 (0.49)  0.005 (0.25)  0.752 (0.09)  1d6731ba791073b8886d65dd93d3845e6806305a # mpi-affinity

hey @lgarithm this does not look right to me. could you make sure that spin locks are enabled at build time?
you should be able to see it in the cmake logs. it may require re-running inv dev.cmake with the --clean flag.

does this need a special build flag? I re-run with everything cleaned, but it's still the same:
-----------------------------------------------------------------------------------------------------------------
local/S       local/L       remote/S      remote/L      commit
-----------------------------------------------------------------------------------------------------------------
0.294         8.855         0.020         8.665         mpi
0.028 (0.10)  4.320 (0.49)  0.004 (0.20)  0.758 (0.09)  1da6eb8a8c7342b39423c658764407c6172cc04d # mpi-affinity

@lgarithm can you paste the build log here? particularly at the very beginning of the CMake command you should see:
-- The C compiler identification is Clang 17.0.6
-- The CXX compiler identification is Clang 17.0.6
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/clang-17 - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/clang++-17 - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Faabric not optimised for specific CPU
-- Faabric: Activated spin-locks // <============== THIS LINE
-- Found Git: /usr/bin/git (found version "2.34.1")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE


Sections with sub arguments (spaces) in one annotation.

for example: @Section(route = "main subcommand")

#71

#70


Chrome crashes are treated as success in 1.1.9

We run protractor-retry on sharded specs in sequence with the following configuration:
  capabilities: {
    'browserName': 'chrome',
    'shardTestFiles': true, // with shard, we can retry individual specs
    'maxInstances': 1,
    ...
  }

It appears that if Chrome crashes on one of the specs (see example in #25), protractor-retry treats that as success and marks all tests as passed. This is a regression since it worked fine in v1.1.8 and is broken now.

Possible cause: https://github.com/yahoo/protractor-retry/pull/29/files#r185912791

How can I see the return code? Is it logged somewhere?

it s available in when you run your Cmd in debug mode, ie
DEBUG=* yourprotractorcmd

Thanks, I'll check how can I set this up in our CI environment.
Unfortunately, this env goes through some major upgrade now, so next week is the earliest...

I haven't seen Chrome crashes for long time, and I don't know how to force-crash it.
Going to close the issue for now.


can only join an iterable

When VPC tag is only half tagged we get and STNO bug. Expected tags: "Propagate-to"" and "Associate-with". Customers that provided only the "Associate-with" will face issues, since there will be no Approvals records shown in StnoWebApp, but StnoStatus tags say that Approval is required.
Workaround: Change tgw tags ApprovalRequired=No to disable Approvals.
Symptom:
Approvals stop working.for the VPC.
Erro Log:
CloudWatch > Log groups > STNO-Hub-Failures
https://eu-central-1.console.aws.amazon.com/cloudwatch/home?region=eu-central-1#logsV2:log-groups/log-group/STNO-Hub-Failures/log-events/20c....
"error-info": {
"Error": "TypeError",
"Cause": "{"errorMessage":"can only join an iterable","errorType":"TypeError","requestId":"8e3d....d7","stackTrace":["  File \"/var/task/state_machine/index.py\", line 196, in lambda_handler\n    return sns(event, function_name)\n","  File \"/var/task/state_machine/index.py\", line 147, in sns\n    response = sns.notify()\n","  File \"/var/task/state_machine/state_machine_handler.py\", line 2437, in notify\n    self._send_email()\n","  File \"/var/task/state_machine/state_machine_handler.py\", line 2502, in _send_email\n    \", \".join(self.event.get(\"Propagate-to\")).title(),\n"]}"
},
"Comment": "can only join an iterable"

Thank you for raising the issue. The solution requires both Propagate-to and Associate-with tags on the vpc. For better resolution of the issue can you confirm following:
Steps to replicate the issue (please add missing steps):

Deploy the solution
Add only Associate-with:<route-table-name> tag on the VPC
Notice can only join an iterable error in CW log group STNO-Hub-Failures

Expected behavior:
Please provide details on the expected behavior after the fix

The tenant was using Terraform and not awscf.
Sorry to inform that I dont have more info nor am I able to apply a fix.
Just thought I could share this issue to the project.

Closing due to inactivity. Please reopen the issue with more details if it still impacts you.


tests: kernel: timer_api fails with hard fault in CONFIG_TICKLESS_KERNEL

Describe the bug
run the tests/kernel/timer/timer_api with the prj_tickless.conf on the nucleo_wb55rg
This board and soc device have PM with their own ./soc/arm/st_stm32/stm32wb/power.c
To Reproduce
Steps to reproduce the behavior:
set prj.conf with
CONFIG_ZTEST=y
CONFIG_PM=y
CONFIG_TICKLESS_KERNEL=y
CONFIG_MP_NUM_CPUS=1
CONFIG_TEST_RANDOM_GENERATOR=y

CONFIG_TEST_USERSPACE=y

west build -p auto -b nucleo_wb55rg tests/kernel/timer/timer_api/
or
./scripts/twister  -p nucleo_wb55rg  -T tests/kernel/timer/timer_api

Impact
Running test suite timer_api
===================================================================
START - test_time_conversions
 PASS - test_time_conversions in 0.113 seconds
===================================================================
START - test_timer_duration_period
ASSERTION FAIL [!arch_is_in_isr()] @ WEST_TOPDIR/zephyr/kernel/sched.c:841

E: ***** HARD FAULT *****
E:   Fault escalation (see below)
E: r0/a1:  0x00000004  r1/a2:  0x00000349  r2/a3:  0x00000040
E: r3/a4:  0x0000003f r12/ip:  0xa0000000 r14/lr:  0x08007637
E:  xpsr:  0x4100003f
E: Faulting instruction address (r15/pc): 0x0800d676
E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
E: Fault during interrupt handling

E: Current thread: 0x200004b0 (idle 00)
E: Halting system

Environment (please complete the following information):*
master : SHA1 = 7397e3e5b59d3c941ee241bc0c9ecf12ce1ce158
Additional context
Also failing test :  tests/kernel/tickless/tickless_concept/
Running test suite tickless_concept
===================================================================
START - test_tickless_sysclock
ASSERTION FAIL [!arch_is_in_isr()] @ WEST_TOPDIR/zephyr/kernel/sched.c:841
...

There is a PR  #33222, where the commit bfc11b57160c1673954885d6a76ebaddae589350 "power: Send exit notification after post_ops callback" is causing the kernel crash.

I propose to unlock the scheduler NOT in the pm_system_resume() itself but in the pm_system_suspend(), just after the pm_system_resume(); function call, as follows:
	pm_log_debug_info(z_power_state.state);
	pm_system_resume();
	k_sched_unlock();

	return z_power_state.state;
}

The tests/subsys/power/power_mgmt_soc also fails on nucleo_wb55 and nucleo_l552 boards

closing as the PR  #33666 is now merged


Update push-api.json

@Fyrd I think there might be a bug in your Travis script. It doesn't like either of these items in my PR. I can't find anything wrong with either of them. I'f you see something I don't, I'll be happy to fix it.
"and_chr":{
"49":"a #1",
"50":"y"
},
"and_chr":{
"50":"y"
},

Updated this one manually.


Cannot find module awscloudformation

Describe the bug
When I run:
 $ amplify push && amplify codegen

I get:
| Category | Resource name   | Operation | Provider plugin   |
| -------- | --------------- | --------- | ----------------- |
| Api      | wwmtg           | Update    | awscloudformation |
| Auth     | cognito08d97016 | No Change | awscloudformation |
? Are you sure you want to continue? true

Cannot find module 'awscloudformation'
✖ Downloading schema failed
missing path

I'm a little confused because this was working fine yesterday and I haven't really changed anything. So I'm not sure what change could have suddenly caused this.
To Reproduce
Steps to reproduce the behavior:

Run $ amplify push && amplify codegen

Expected behavior
I'd expect my changes to be reflected and pushed to AWS. Rather than an error.
Desktop (please complete the following information):

OS: OSX Mojave
Browser: Chrome
Version: 0.1.28

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@EwanValentine You seem to be suing a very old version of the CLI (0.1.28), and we currently are on 1.5.0). Could you please use the latest version of the CLI and see if you're still seeing this behavior?


Add data needed for the collections screen

What 🕵 🔍

What does the pull request solve?
It adds data needed for the collections screen
What exactly was added or modified?
It adds the onLongPress callback in the AppGhostButton
It adds the background color for the collections screen card

How to test 🥼 🔬

A brief description of the steps required for proper testing

Screenshots 📸 📱

Before
After

References 📝 🔗

source name

Codecov Report

Merging #48 (4ab84e9) into main (98b6dfa) will decrease coverage by 0.07%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   57.82%   57.74%   -0.08%
==========================================
  Files          48       48
  Lines        1667     1671       +4
==========================================
+ Hits          964      965       +1
- Misses        703      706       +3

Impacted Files
Coverage Δ

lib/src/linden/xcolors.dart
37.03% <0.00%> (-0.85%)
:arrow_down:

lib/src/widget/button/app_ghost_button.dart
65.00% <100.00%> (+0.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98b6dfa...4ab84e9. Read the comment docs.


Craft 5 Betaa 11

Describe the bug
Just tested  on last Beta  .. it does not show in matrix..

Steps to reproduce

Create  Matrix fields

Craft CMS version
Craft 5 beta 11
Plugin version
3.0.0-beta.1
Multi-site?
No response
Additional context
No response

Aware of this, and still working on how to best tackle the new behaviour of Matrix fields and nested blocks.

Updated for the next release. To get this early, run composer require verbb/smith:"dev-craft-5 as 3.0.0-beta.1".

Fixed in 3.0.0-beta.2

Updated for the next release. To get this early, run composer require verbb/smith:"dev-craft-5 as 3.0.0-beta.2".

thx  works now :)

Confirmed, was having same issue, the update works to fix it.

just info.  it works OK on main site..
But on second site..    it say copied..
But when you click Paste..    not working

Copying and pasting between sites on a multi-site install is working for me?

By second site, you mean a completely different install?

nop..   same install. .just second site to second site..

Oh, I see what you mean. Fixed for the next release. To get this early, run composer require verbb/smith:"dev-craft-5 as 3.0.0-beta.2".

works ok now :) thx

Hey, any chance to add support to matrix Card view.

@alex-brukhty I'll look into it, but it's radically different in its implementation.

On last craft and smith  version.  updazted last day..
All  works ok on  main site..  but not on other sites..
If i copy from main A site  to B site that works..
But if i copy from B site to B site does not work.
It says copied. but on paste nothing happens.

Should be fixed for the next release. To get this early, run composer require verbb/smith:"dev-craft-5 as 3.0.0".

Fixed in 3.1.0


Support for MacOS

Hi, can you support scanning on MacOS?

I have not consider for mac support in the past. I will have a look and see if I can add mac as well though this might take some time for development and testing. mean time I will keep this issue open.

Any word on this?

Hi @MasterNeuromancer,
Due to lack of resource, I couldn't get time to look into it. Will update same.

Thanks for that!


Populate MedicationHistory Table on Alarm

When each alarm is sounded, populate the MedicationHistory table using the AlarmNotification class

@talhaghaffar01 please test the code. Use the master branch.


Function calls are not supported

Copied from @craigeddy #11
When I use this version, I'm getting a compile error on ng serve:
ERROR in Error encountered resolving symbol values statically. Calling function 'IntercomModule', function calls are not supported. Consider replacing the function or lambda with a reference to an exported function, resolving symb ol AppModule in C:/Users/eddycr/Source/Repos/registration/src/app/app.module.ts, resolving symbol AppModule in C:/U sers/eddycr/Source/Repos/registration/src/app/app.module.ts
the code:
import { BrowserModule } from '@angular/platform-browser';
import { NgModule } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { IntercomModule } from 'ng-intercom';
import { AppComponent } from './app.component';
import { RegisterModel } from './app.registermodel';
import { RegistrationComponent } from 'app/registration/registration.component';

@NgModule({
  declarations: [
    AppComponent,
    RegistrationComponent
  ],
  imports: [
    BrowserModule,
    FormsModule,
    IntercomModule.forRoot({ app_id: 'sq739kpn'})
  ],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule { }

I also have a repo with my whole project if you want to take a look. I'm probably doing/forgetting something noob-ish. craigeddy/IntercomProtype (angular2-intercom-alpha branch)

@craigeddy just published v1.0.0-alpha.7, and it seems to be working in my test project. Thanks for all your help testing! Know you're helping all of the other NgIntercom users to get an amazing dev experience!

Cool. I'll give it a try sometime later this week. Thanks!


Reason to add xmldom to Dependecy

Are there any reason to add xmldom to dependecy ?
I tried to remove the xmldom and ran the consumer tests locally, and it turns out it PASS the tests.
If there are some reason to use xmldom, you should replace it to  https://github.com/xmldom/xmldom because jindw/xmldom#259
GH-908

Closed via #939 thanks to @jeremia49


Dashboard incorrect number of hosts

Describe the bug
Dashboard displays the wrong number of hosts
Nginx Proxy Manager Version
2.10.3
To Reproduce
Create hosts as user X
Create user Y
Login as user Y
Expected behavior
Same number of hosts displayed for both accounts on the dashboard
Exactly this bug: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/1679
But I managed to replicate it.

I confirm with 2.10.4: Items created with different users are not counted on the dashboard page, bit are manageable from the specfic pages.

I successfully recreated this issue by creating Proxy Hosts with a different user. I believe the count is only for proxy hosts (in my case) created by the current user. If I create a new host with my current user the count increases.
If you follow the chain:

https://github.com/NginxProxyManager/nginx-proxy-manager/blob/e08a4d44901081ea0e8b33d0f865d4fc4a0a1806/frontend/js/app/dashboard/main.js#L54C25-L54C37
https://github.com/NginxProxyManager/nginx-proxy-manager/blob/e08a4d44901081ea0e8b33d0f865d4fc4a0a1806/frontend/js/app/api.js#L724
https://github.com/NginxProxyManager/nginx-proxy-manager/blob/e08a4d44901081ea0e8b33d0f865d4fc4a0a1806/backend/routes/api/reports.js#L21
https://github.com/NginxProxyManager/nginx-proxy-manager/blob/e08a4d44901081ea0e8b33d0f865d4fc4a0a1806/backend/internal/proxy-host.js#L454

It looks like the visibility flag is not sent from the frontend call. The backend query is looking for
if (visibility !== 'all') {
	query.andWhere('owner_user_id', user_id);
}

So it is limiting the count to only the active user.

you can change this line:
if (visibility !== 'all') {
query.andWhere('owner_user_id', user_id);
}
to:
if (visibility && visibility !== 'all') {
query.andWhere('owner_user_id', user_id);
}
inject it with a volume mapping via docker compose like this for testing:
volumes:

./proxy-host.js:/app/internal/proxy-host.js:ro


Is possible to generate a deterministic contract id with the same arguments?

I tried to make every arguments to const value, however, each time i compiled it, the contract id changes. And after take tracing the code, found the contract id is generate from lib commit_verify's function commitment_id. The function shows that the id is generate from a sha256 of a 32 bytes variable TAG, while i found that TAGs variables are defined as const, so, why the contract id would become different with the same arguments and the same codes? Or is there an way to generate a deterministic contract id with the same codes/arguments?

No, it is not possible. Each contract is unique - at least as long as it contains a timestamp (which includes milliseconds).

I figure it out that RGB20 contract id is based on fungible field which is a Confined<BTreeMap<u16, Confined<HashMap<BuilderSeal<Seal>, RevealedValue, RandomState>, 1, U8>, Global>, ZERO, U8> type, and there's RandomState in it, thus, there's no way to make generate a deterministic contract id. And if the RandomState is removed or deterministic, then the blind seal would be meaningless, am I right?

No, RandomState is the Rust thing, which has nothing to do with RGB or indeterminism. It is used by the BTreeMap as an allocator.
However, inside RevealedValue there is an automatically generated blinding factor, and you are right, that makes the contract id different each time. And there is no way to remove it. However, this is not the only reason: even if it is removed, you will have different contract ids due to different timestamps.
Why do you need a deterministic contract generation?

Why do you need a deterministic contract generation?

Cause in my point of view, contract id should be the same if and only if the contract contents is the same. I mean, it's just a hash of the contract content.
Actually, i tried to set Timestamp to a constant, and for the RevealedValue, yeah, there's a blind factor which is a secp256k1_zkp::SecretKey, and i do set this argument to a constant with a fixed timestamp. The contract id still changes. Am i missing something?

If you are using current master/beta v0.11 there is also a thing called AssetTag which is there for Liquid compatibility.
Anyway, can you share your code so I can check how exactly you are doing that?

If you are using current master/beta v0.11 there is also a thing called AssetTag which is there for Liquid compatibility.

I'm still on version 0.10.2, not using AssetTag attribute.

Anyway, can you share your code so I can check how exactly you are doing that?
Okay, just want to get a fixed contract id with constant arguments. Here is my codes:

    let name = "USDT";
    let decimal = Precision::CentiMicro; // Decimal: 8
    let desc = "USD Tether Token";
    let spec = DivisibleAssetSpec::with("RGB20", name, decimal, Some(desc)).unwrap();
    let terms = RicardianContract::default();
    let contract_data = ContractData { terms, media: None };
    // let created = Timestamp::now();
    let ts =<PHONE_NUMBER>;
    let strict_value = StrictVal::from(ts);
    let created = Timestamp::from_strict_val_unchecked(&strict_value);
    let txid = "0018dc9fff99382ac228a6cbcbdddb0989329d85d95c1e354b74a488da324516";
    let vout_index = 1;
    let beneficiary = Outpoint::new(Txid::from_hex(txid).unwrap(), vout_index);

    const ISSUE: u64 = 1_000_000_000;

    let contract = ContractBuilder::with(rgb20(), nia_schema(), nia_rgb20())
        .expect("schema fails to implement RGB20 interface")
        .set_chain(Chain::Testnet3)
        .add_global_state("spec", spec)
        .expect("invalid nominal")
        .add_global_state("created", created)
        .expect("invalid creation date")
        .add_global_state("issuedSupply", Amount::from(ISSUE))
        .expect("invalid issued supply")
        .add_global_state("data", contract_data)
        .expect("invalid contract text")
        .add_fungible_state("assetOwner", beneficiary, ISSUE)
        .expect("invalid asset amount")

        .issue_contract()
        .expect("contract doesn't fit schema requirements");

    let contract_id = contract.contract_id();
    println!("{contract_id}");

Also, i've replaced let state = Reveledalue::new(value, &mut thread_rng()); in  rgb-std-0.10.9/src/interface/builder.rs line 445 to:
                let sk_str = "01010101010101010001020304050607ffff0000ffff00006363636363636363";
                let sk = secp256k1_zkp::SecretKey::from_str(sk_str).unwrap();
                let state = RevealedValue::with(value, sk);

However, got an error with  "use of undeclared crate or module secp256k1_zkp", but in the cargo.toml file, i do declare secp256k1_zkp with secp256k1-zkp = { version = "0.9.2", features = ["rand", "rand-std", "global-context",] }, that's very wired.

@oneforalone I agree with your arguments and have added a convenient API for deterministic contract generation into the v0.11 roadmap

The simplest case is that we can verify a contract if we know construction arguments of the contract.

With v0.11 I tried to address ability to deterministically generate contract and state transitions (important for Lightning, coinjoins, atomic swap protocols etc). Let's use this issue as a tracking for the matter.
To generate contract or a state transition in a deterministic way, one has to do the following:

Provide custom asset tags - this is needed only during contract issuing and not for state transitions/transfers. Use ContractBuilder::set_asset_tag API to provide this information.
Provide explicit blinding information for single-use seal definitions when using OperationBuilder::add_*_state. This can be done by creating a beneficiary using BlindSeal::with_blinding (for genesis and blind-utxos) or BlindSeal::with_blinded_vout (for address-based payments).
Provide explicit blinding information for fungible state (used in Pedersen commitments). This can be done by calling ContractBuilder::add_owned_state_raw (or the same-named method for TransitionBuilder)
Instead of using Runtime::pay or Runtime::construct_psbt methods from rgb-runtime crate use Runtime::pay_deterministic/construct_psbt_deterministic, providing closures generating blinding factors for both pedersen commitments and seal definitions in a deterministic way (this part is WIP, right now we have a low-level APIs from Inventory::compose_deterministic which still has to be exposed at Runtime level)
Provide entropy value for multi-protocol commitments during the anchor creation. It should be also done using the same APIs from pt.4, but this is pending (we have low-level Psbt::dbc_set_entropy, but it is not yet exposed via PSBT construction API at the runtime level)

@dr-orlovsky what's missing to complete this? I see this isn't listed in the rgb 0.11 board (https://github.com/orgs/RGB-WG/projects/17), do you still plan to do it in a 0.11 release? I think this is useful to have, to do some tests

I think tests are missing: I am not 100% sure we have all required APIs in place, but hard to point at specific one which can be missed

I can give a look at this and let you know if something's missing or if everything's in place

I've checked this using v0.11.0-beta5 and it seems the possibility to add global state in a deterministic way is missing, therefore I've opened a PR for this https://github.com/RGB-WG/rgb-std/pull/190.
I think we can close this as soon that PR gets merged.
I've added a test (https://github.com/RGB-WG/rgb-schemata/pull/41) so that with beta 6 we can be sure this still works.


Prisma Client triggers or lifecycle events

Problem
Prisma Client lacks observable lifecycle events or database triggers. Popular alternatives to prisma (and even databases themselves) have these as mature and well documented features.
For example, Hasura and Sequelize. Having triggers / events is important because it opens up huge possibilities with the prisma-nexus plugin. The goal would be to leverage the code reduction and API consistency that nexus allows without having to tap into a custom mutation for seemingly every case but the most absolutely simplified. Not to mention data validation.
Solution
Prisma Client should have a way to define functions before and after crud operations. Here is an example that I thought of which would be pretty common. The Sequelize link I posted above also has plenty of examples and concepts, basically an instruction guide on what to include.
prisma = new PrismaClient();
prisma.setTriggers(prisma => ({
  beforeOrderCreate: async (args: OrderCreateArgs): Promise<OrderCreateArgs> => {
  const grandTotal = calcGrandTotal(args.data.lineItems.create);
  // Error can be thrown here
  await processPayment(grandTotal, args.data.user.connect.id);
  return {
    ...args,
    {
      data: {
        ...args.data,
        grandTotal
      }
    }
  })
  afterOrderCreate: async (order: Order): Promise<void> => {
    const user = await prisma.order.findOne({ where: { id: order.id } }).user();
    if (user.acceptsEmail) {
       await sendEmailToCustomer(order.id, order.grandTotal, user.name);
    }
  },
  afterOrderUpdate: async (newOrder: Order, oldOrder: Order): Promise<void> => {
    if (newOrder.grandTotal !== oldOrder.grandTotal) {
      await prisma.creditNote.create({
        data: {
          amount: newOrder.grandTotal - oldOrder.grandTotal,
          order: { connect: { id: newOrder.id }
        }
      }
    }
  }
}))

Alternatives

Additional context

Thanks a lot for raising this issue. This is definitely something we've thought about before (e.g. here https://github.com/prisma/specs/issues/444).

I see ok. I was thinking that there are a handful of common cases for the "before" functions (auth, validation, derived fields). But really, prisma doesn't need to consider those uses. Simply having a synchronous (and possibly async) before and after would open a window to implement those things. If you could prisma.setTriggers in the context creation function (Apollo Server), then you would have full access to the request context (auth info) and dataSources (for REST calls) inside your prisma triggers. This means anything is possible inside the triggers, and you can (dare I say should?) reduce your application to nothing more than protected, auto-generated crud operations (nexus) and business logic inside event triggers to enhance the auto-generated. So you write code where you need to, and only where you need to.

I'm also looking for this feature. I need to process the data on the backend side in some sort of queue, where I'd like to watch for status changes of entities and perform some operations.
I could technically do it just after I perform updates, but the goal of my architecture is to make processing fully independent from CRUD implementation

Any Progress? It's Important.

@chareice I think you can use a Prisma middleware for this now: https://www.prisma.io/docs/reference/tools-and-interfaces/prisma-client/middleware

This is covered by middlewares. If your use-case might not be supported, please create a separate issue.

This is covered by middlewares. If your use-case might not be supported, please create a separate issue.


Code suggestion for setState still not working in Flutter 3.0.2

I tried Flutter 3.0.2 after receiving an announcement that the code completion problem has been resolved in Flutter 3.0.2.
initState and dispose did code completion properly.
(initState / dispose in Flutter 3.0.2)

Unfortunately, however, code completion for setState does not seem to work yet.
(setState in Flutter 3.0.2 => no suggestion)

(setState in Flutter 2.10.5 => work properly)

Since setState is a very commonly used and important method, it would be helpful if it could be resolved as soon as possible.
Thanks.

@scheglov @stevemessick

https://dart-review.googlesource.com/c/sdk/+/247933

dependencies:
  flutter:
    sdk: flutter

  # The following adds the Cupertino Icons font to your application.
  # Use with the CupertinoIcons class for iOS style icons.
  cupertino_icons: ^1.0.2
  freezed_annotation: ^2.0.3

dev_dependencies:
  flutter_test:
    sdk: flutter

  # The "flutter_lints" package below contains a set of recommended lints to
  # encourage good coding practices. The lint set provided by the package is
  # activated in the `analysis_options.yaml` file located at the root of your
  # package. See that file for information about deactivating specific lint
  # rules and activating additional ones.
  flutter_lints: ^2.0.0
  build_runner: ^2.1.11
  freezed: ^2.0.3+1
  json_serializable: ^6.2.

with above dependencies, material.dart auto completion does not work also.

@cocoa-rum please open separate issue. It is fine if you reference it here, but for tracking and discussing it is much easier for us to keep separate root problems separately.

+1

It seems that Flutter 3.0.3, which was just released, has not solved it.

We are waiting for https://github.com/dart-lang/sdk/issues/49239

Same problem.

https://github.com/flutter/flutter/issues/106724
i'm still face this issue in Android Studio i use dart 2.17.3 version

still not working in Flutter 3.0.4

Worked in Flutter 3.0.5! Thanks!

Can we close this issue?

Yes


Update SimpleMap Component Example in README.md

I may be missing something, but from what I could tell, the SimpleMap code example listed in the README file is not actually valid code... I was unable to get it working without bind() errors. It also heavily uses the 'this' keyword and .bind() despite being defined as a pure (stateless) functional component, which is uncommon and a little confusing (especially if someone were to define it using an arrow function without understanding how it differs).
I updated it to be more like the sample SimpleMap linked here:
https://github.com/tomchentw/react-google-maps_examples_simple-map/blob/493c95b5830a36434d648b9d7f779f231d2c79a5/src/scripts/SimpleMap.js
For now, I replaced the {...props} spread in GoogleMapLoader with {...props.containerElementProps}, as the click handlers are now being passed in as props too. I'm not sure if this is the best approach though...
If you don't like this solution (where everything needed is passed in as a prop), maybe the example should use an ES6 class instead of a pure function?
EDIT: I think I may have overlooked something and that's why I was having issues with the .bind() calls. Sorry for that. However, I do think getting rid of 'this' and 'bind()' would be ideal when using a functional component as an example. Also, we could go one step further and use destructuring assignment in the SimpleMap parameters to get rid of the props references.

Thanks! The changes are great!


Repeated rows of pixels (stretched fonts, not native resolution)

The following fonts are bad, they have repeated rows

JF-Dot-Ayu20
JF-Dot-Izumi16
JF-Dot-jiskan16s
...

At this point I would say they all have the chance of being bad 😢
Repro

loading the .fnt files into tophat web editor
load the font into a Playdate app/game

Screenshots

Ah yeah this is a little tricky... it may have to do with this line, or may be something to do with the otf2bdf utility. Basically, these fonts are provided based on the pixel line height, but otf2bdf accepts the input font size in points. The conversion is supposed to be pt = px * 0.75, but there must be some ambiguity or inaccuracy with either the conversion or the ttf metadata. I can take another look
I don't think all the fonts are bad, as I've spot checked some specimens at other sizes and they seem correct. But it may be ones of certain heights. Either way I can dig in to the obviously broken ones and see if there's some way to tweak it to make them correct. Thanks for checking

Given that some are tainted my confidence is low that they are not all tainted (for example look at the second image where only the "s" is bad in that screenshot) and it would be tricky to eyeball all characters of all fonts, so it needs to be fixed at a logic/code/process level.

Regardless, I will have to re run them all anyway due to #1. So I will try to figure out the right sizing formula before processing them all again

I have made some progress on this... tl;dr, I made a fork of otf2bdf and modified it to let me pass in point sizes in double format, and reversed the point size formula to get the right precision input. But now there's a bug in that patched otf2bdf affecting the bounding box, so glyphs aren't properly aligning to the baseline. I'll mess around a little more with it next chance I get

Should be fixed as of 8d01fc4


not responsive with the tablet

I have the calendar carousel with 420 but not responsive with the tablet you can check here: https://ibb.co/LtCsmRy

I need this for the heigth change and i need footer to calendar and this change in heigth https://ibb.co/71CmMHG


Create Qheap.cpp

Solution of issue #125 in C++

@adityabisoi I have made relevant changes in my PR, please check.

Links to README


custom downstream RKE won't fully register from behind http proxy

Rancher Server Setup

Rancher version: 2.6.3 (original report for Rancher 2.6.2, but upgraded Rancher since)
Installation option (Docker install/Helm Chart): Helm Chart, RKE1

Information about the Cluster

Kubernetes version: v1.21.7 on docker://20.10.9-ce on SUSE Linux Enterprise Server 15 SP2
Cluster Type (Local/Downstream): Downstream RKE1 via RMS (custom install)

Describe the bug
I'm having trouble bringing up a custom RKE cluster deployed via Rancher. This seems to be related to the downstream needing an HTTPS_PROXY to reach the Rancher Management Server, happens since upgrading RMS to 2.6.2 and affects "share-mnt" containers on all nodes:

configuring five nodes with SLES 15 SP2 (JeOS image in Openstack Cluster)
configuring custom RKE1 cluster in RMS, adding HTTP_PROXY, HTTPS_PROXY, NO_PROXY env vars
running the registration command on the five nodes (3x etc and controlplane, 2x worker). The RMS-generated registration command does already list the HTTP_PROXY, HTTPS_PROXY and NO_PROXY env vars, so the configuration of the downstream cluster in RMS should be ok.
stage one of node setup runs fine AFAICT - the cluster gets up at Kubernetes level, kubectl works nicely
RMS shows the cluster and 5 machines as "active", but "Explore" button remains gray
"docker ps" on all five nodes shows the share_mnt container getting started again and again, with the log entries

INFO: Environment: CATTLE_ADDRESS=<IP_ADDRESS> CATTLE_AGENT_CONNECT=true CATTLE_INTERNAL_ADDRESS= CATTLE_NODE_NAME=kube05 CATTLE_SERVER=https://rancher.cloud.customer.com CATTLE_TOKEN=REDACTED CATTLE_WRITE_CERT_ONLY=true
INFO: Using resolv.conf: search customer.com cloud.customer.com nameserver <IP_ADDRESS> nameserver <IP_ADDRESS> nameserver <IP_ADDRESS>
ERROR: https://rancher.cloud.customer.com/ping is not accessible (Failed to connect to rancher.cloud.customer.com port 443: Connection timed out)

tcpdump on the nodes show traffic to RMS 443 port directly (which should not happen, but rather go via external Squid proxy set in HTTPS_PROXY).
In other words, it looks like the share_mnt container is started by rancher-agent without passing the required env vars for proxy access.
To Reproduce
Install downstream cluster with HTTP_PROXY etc env vars. Reproducible for me 100%
Result
share_mnt container continuesly timing out and restarting
Expected Result
node registration should complete

reproducible with Rancher 2.6.3 (upgraded via Helm from 2.6.2)

We can confirm this issue - also happening in our environment.

After a complete reinstall of the Rancher server v2.6.3-patch1 (not only the downstream clusters), I cannot reproduce the behavior.
Until then, I had been testing with my Rancher server that was upgraded from 2.5.7 onward, and which has suffered a number of "cannot delete downstream cluster" incidents (fixed by manually deleting "finalizers"). Maybe something got screwed up in Ranchers data base.
@FrediWeber: Do you mind if I close this issue, since I can no longer reproduce?

please ignore my last comment.
I had a large number of problems with latest installs, which were gone once I reinstalled Rancher as mentioned above. I now have a situation where after the installation of downstream clusters (which need an HTTP proxy to reach the Rancher server), they are manageable from Rancher (shown as "active", "explore" button in web UI is active and functional).
Nevertheless, on the worker nodes, I see that the share-mnt container is constantly restarting, with the original error in the logs:
ERROR: https://rancher.cloud.customer.com/ping is not accessible (Failed to connect to rancher.cloud.hh.nde.ag port 443: Connection timed out)
Since the Rancher server "rancher.cloud.customer.com" is only accessible via HTTP proxy, it seems obvious that the share-mnt container still is missing the HTTP_PROXY and NO_PROXY variables, which should have been inherited from the initial Rancher container.
Once I reconfigure networking so that the node can reach the Rancher server without proxy, share_mnt completes.


NoClassDefFoundError: org/apache/spark/internal/Logging$class

Here are the versions I'm using:
Spark: 3.0.1
Scala: 2.12.10
OS: Ubuntu 18.04 TLS
I'm trying SQL Server connection from PySpark script and running it using command: spark-submit
I have build then MSSQL connector using this repo https://github.com/microsoft/sql-spark-connector and changed the required versions inside build.sbt. But now, I'm facing below issue:
py4j.protocol.Py4JJavaError: An error occurred while calling o33.load.
: java.lang.NoClassDefFoundError: org/apache/spark/internal/Logging$class
	at com.microsoft.sqlserver.jdbc.spark.DefaultSource.<init>(DefaultSource.scala:32)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at java.lang.Class.newInstance(Class.java:442)
	at org.apache.spark.sql.execution.datasources.DataSource$.lookupDataSourceV2(DataSource.scala:734)
	at org.apache.spark.sql.DataFrameReader.load(DataFrameReader.scala:248)
	at org.apache.spark.sql.DataFrameReader.load(DataFrameReader.scala:221)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at py4j.reflection.MethodInvoker.invoke(MethodInvoker.java:244)
	at py4j.reflection.ReflectionEngine.invoke(ReflectionEngine.java:357)
	at py4j.Gateway.invoke(Gateway.java:282)
	at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
	at py4j.commands.CallCommand.execute(CallCommand.java:79)
	at py4j.GatewayConnection.run(GatewayConnection.java:238)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: org.apache.spark.internal.Logging$class
	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
	... 20 more

Here is my build.sbt file:
organization := "com.microsoft.sqlserver.jdbc.spark"
version := "1.0.0"
scalaVersion := "2.12.10"
val sparkVersion = "3.0.1"
javacOptions ++= Seq("-source", "1.8", "-target", "1.8", "-Xlint")
libraryDependencies ++= Seq(
  "org.apache.spark" %% "spark-sql" % sparkVersion % "provided",
  // Spark Testing Utilities
  "org.apache.spark" %% "spark-core" % sparkVersion % "test" classifier
      "tests",
  "org.apache.spark" %% "spark-sql" % sparkVersion% "test" classifier
      "tests",
  "org.apache.spark" %% "spark-catalyst" % sparkVersion % "test" classifier
      "tests",
  "org.scalatest" %% "scalatest" % "3.0.8" % "test",
  "com.novocode" % "junit-interface" % "0.11" % "test",
  //SQLServer JDBC jars
  "com.microsoft.sqlserver" % "mssql-jdbc" % "8.2.2.jre8"
)
scalacOptions := Seq("-unchecked", "-deprecation", "evicted")
// Exclude scala-library from this fat jar. The scala library is already there in spark package.
assemblyOption in assembly := (assemblyOption in assembly).value.copy(includeScala = false)

Please help.

Any updates on this? The MSSQL connector created by following the build steps doesn't work with latest Scala and Spark versions. Anyone facing same issue?

Please use the preview version of the connector (Maven coordinate com.microsoft.azure:spark-mssql-connector_2.12_3.0:1.0.0-alpha) to use with Spark 3.x

@arvindshmicrosoft I have already tried that, still getting same issue.

Unfortunately, it looks like you are hitting the same fundamental set of issues as described in #97. A community contribution is here: #100 - you might be able to adapt that till there is a formal update from the team here regarding Spark 3.1.1 support.
BTW, switching to DBR 7.x would be another option if you are willing to work with Spark 3.0.1.
cc: @shivsood @luxu1-ms @DaniBunny

Thank you. I will try it.

Is there a timeline for when the team will support 3.1? It's been out for a few months now. Code bases that depend on the Delta Lake improvements in Azure Databricks 8.x would be much easier to maintain without forking off the main code, merging in the fix and redeploying internally!

@luxu1-ms @DaniBunny as FYI on Spark 3.1 support request. Also looks like spark 3.0.1 has the same issue. Have we tested on spark 3.0.1 ?


Fixes #27 remove type form package.json file to run build in angular …

…6 production mode

Hi @lmeunierRakuten , the types property is essential to export the typescript definitions as you can see here: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html.
We should find another buy to make it work with the production build of angular 6.

Why/how does types break Angular 6 in production mode?

Because your declaration is not correct.
In Issues #27 @nimaen explain that.
with your declaration it is impossible to do this type of import
import { getApi, Predicates } from 'prismic-javascript';
or
import ResolvedApi from 'prismic-javascript/d.ts/ResolvedApi';
I try
`
import * as Prismic from 'prismic-javascript';
Prismic.getApi
Prismic.Predicates
`
But not work to.

To use your code I am forced to use the option "allowSyntheticDefaultImports", I did not want to use it because it involves modifying the default configuration of an angular build. It will be necessary for me to explain that prismic does not export ES2015 and suddenly we are forced to use this option.
I'm afraid that our future client does not understand and we are asking for another solution. That would be a shame.

I agree that it is somewhat unfortunate that prismic-javascript exports its API underneath one default export:
export default {
  getApi,
  Predicates,
  // ...
}

... rather than as named exports:
export {
  getApi,
  Predicates,
  // ...
}

This also breaks tree-shaking.


Merge georgeee/refactor-graphql-file to develop (empty change)

0-change PR that fixes got histpory in a way to allow merge of #13956
Checklist:

[x] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[x] Modified the current draft of release notes with details on what is completed or incomplete within this project
[x] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[x] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[x] All tests pass (CI will check this if you didn't)
[x] Serialized types are in stable-versioned modules
[x] Does this close issues? None

!ci-build-me


in_app_purchase plugin not updating purchaseUpdatedStream

I am using hte in_app_purchase plugin and am having an issue where the InAppPurchaseConnection.instance.purchaseUpdatedStream is not firing. I am using the app in the alpha channel with test purchases (https://developer.android.com/google/play/billing/billing_testing) and it is correctly going through the google play billing process and sending me emails and everything, but it isn't calling the purchaseUpdatedStream listener. I have printed out stuff to ensure it is setting up the listener so it appears it isn't firing.
I haven't found anything to indicate it shouldnt fire for situations where you are using test billing. Do we expect it to fire in that scenario?
Here is my in app purchase service code:
`
import 'dart:async';
import 'package:in_app_purchase/in_app_purchase.dart';
class InAppPurchaseService {
static const String subscriptionId =
'subscription';
Future<Map<String, ProductDetails>> _loadProductDetailsFuture;
StreamSubscription<List> _subscription;
InAppPurchaseService() {
_initialize();
}
void _initialize() async {
final bool available = await InAppPurchaseConnection.instance.isAvailable();
if (!available) {
// The store cannot be reached or accessed. Update the UI accordingly.
print('not available');
}
print('adding listener');
final Stream<List<PurchaseDetails>> purchaseUpdates =
    InAppPurchaseConnection.instance.purchaseUpdatedStream;
_subscription = purchaseUpdates.listen(_handlePurchaseUpdates);

}
void _handlePurchaseUpdates(List details) {
print('handling purchase updates');
print(details.map((detail) => detail.productID).toList());
print(details);
}
void loadSubscriptionProductDetails() {
_loadProductDetailsFuture = _loadSubscriptionProductDetailsAsync();
}
Future<Map<String, ProductDetails>>
_loadSubscriptionProductDetailsAsync() async {
print(await InAppPurchaseConnection.instance.isAvailable());
ProductDetailsResponse response =
await InAppPurchaseConnection.instance.queryProductDetails([
subscriptionId,
].toSet());
if (response.notFoundIDs.isNotEmpty) {
print('Ids not found');
} else {
print(response.productDetails.map((details) => details.id).toList());
}
return Map.fromIterable(
response.productDetails,
key: (details) => details.id,
value: (details) => details,
);
}
Future purchaseSubscription(String subscriptionId) async {
if (_loadProductDetailsFuture == null) {
loadSubscriptionProductDetails();
}
ProductDetails productDetails =
(await _loadProductDetailsFuture)[subscriptionId];
if (productDetails == null) {
print('Product details not found');
}
PurchaseParam purchaseParam = PurchaseParam(productDetails: productDetails);
InAppPurchaseConnection.instance
    .buyNonConsumable(purchaseParam: purchaseParam);

}
}
`
Any idea why the above listener wouldnt file in this situation when I call purchaseSubscription and it seems to succeed in the app?

Reverting to in_app_purchase: 0.1.1+1 seems the only way to go at the moment.
Make sure to delete the pubspeck.lock and also the newer version of the package from the pub-host if you want to do this.

is this a known issue? Is there another issue for tracking it?

embarrassingly for myself after a cursory search I found https://github.com/flutter/flutter/issues/34040 which seems to reference this issue. will Try 0.1.1+1 and will search more before posting next time.

is this a known issue? Is there another issue for tracking it?

Is not in the priority list to be fixed from what I can see. How can we escalate this?

This issue has been fixed with https://github.com/flutter/plugins/pull/1775
I am closing the issue now. if any related issues are found, please feel empowered to open another one with details.


Has anyone used this on a Macbook Pro running bootcamp?

Just looking at this and wondering if it runs on windows 7, on a macbook pro (using bootcamp)?
Thanks,

I think it's just a matter of the BT4 dongle support, apart from that it is just Windows 7 running on a Intel machine.


chore: fix Browsers failing tests

Side note: The tests in this PR are passing, but the ones in the main branch do not: https://github.com/puppeteer/puppeteer/actions/runs/4337725668/jobs/7573920069


esp_claim: Claim Verify Failed (MEGH-913)

[x] I have read the documentation esp-rainmaker  Programming Guide and the issue is not addressed there.
[x] I have searched the issue tracker for a similar issue and not found a similar issue.

Environment

Core : ESP32-S2-Saola_v1.0
app version : iOS & Android Version 1.0.3
esp-idf version : v4.2-dev-1303-gcd4fa46f5 & v4.2-dev-1660-g7d7521367
esp-rainmaker version :
Operating System: linux
Power Supply: USB

Problem Description
I can successfully configure the router information using Android and Apple phones, but the calibration is not completed,
The error message is as follows: Claim_Verify_Failed.log
I (102282) wifi:connected with it_zzc, aid = 132, channel 1, BW20, bssid = 38:94:ed:f1:10:70
I (102282) wifi:security type: 3, phy: bgn, rssi: -25
I (102292) wifi:pm start, type: 1

I (102312) wifi:AP's beacon interval = 102400 us, DTIM period = 3
I (103172) app_wifi: Connected with IP Address:<IP_ADDRESS>
I (103172) esp_netif_handlers: sta ip: <IP_ADDRESS>, mask: <IP_ADDRESS>, gw: <IP_ADDRESS>
I (103172) wifi_prov_mgr: STA Got IP
I (103172) app_wifi: Provisioning successful
I (103182) esp_claim: Starting the Self Claim Process. This may take time.
W (106422) protocomm_httpd: Closing session as socket 57 was closed
I (106432) wifi:station: f4:06:16:d6:1d:13 leave, AID = 1, bss_flags is 134259, bss:0x3ffe09f8
I (106432) wifi:new:<1,0>, old:<1,1>, ap:<1,1>, sta:<1,0>, prof:1
I (106432) wifi:mode : sta (7c:df:a1:00:3f:86)
I (106452) wifi_prov_mgr: Provisioning stopped
E (110122) esp_claim: Invalid response for https://esp-claiming.rainmaker.espressif.com/claim/verify
E (110122) esp_claim: Status = 400, Data = {"status":"failure","description":"Invalid challenge response"}
E (110132) esp_claim: Claim Verify Failed.
E (110142) esp_rmaker_core: esp_rmaker_self_claim_perform() returned -1. Aborting

I used ./rainmaker.py claim/dev/ttyUSB0 to write claim_data problem has been fixed


Add notification support

Closes #23
Being tested in https://github.com/pixiebrix/pixiebrix-extension/pull/1460

I initially though about implementing retry: false to be more specific (it's not super clear what a notification is), but for our purposes we need this to do 3 things, so I've implemented it as a notification for now:

no retry
ignores all errors
immediate return

At some point I'll adjust it to:

[x] not return a Promise (so we're not forced to use void myNotificationMethod())
[x] fix the types to always return void: quite verbose but required (the types for isNotification: true are just wrong now)

Seems to work! Will add to https://github.com/pixiebrix/pixiebrix-extension/pull/1460


1 | TwoSum| C++

Fix indentation of code -
Fix a problem with the indentation of the code -
Type of Issue -
Please add/delete options that are not relevant.

[ ] Adding New Code
[x] Improving Code
[ ] Improving Documentation
[ ] Bug Fix

Programming Language
Please add/delete options that are not relevant.

[ ] Python
[x] C++
[ ] Java
[ ] SQL

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

please assign me

please assign it to me.

please assign it to me . I am new to hacktoberfest and want to learn  and do more in it.

@MatheusNtg I don't think Indentation is such a major issue unless its python


Simplify construction of UiParts #184

Fixes #184
Currently there is quite a lot of boilerplate involved if a developer wants to implement a new UiPart:
    public static CommandBox load(Stage primaryStage, AnchorPane commandBoxPlaceholder, Logic logic) {
        CommandBox commandBox = UiPartLoader.loadUiPart(primaryStage, commandBoxPlaceholder, new CommandBox());
        commandBox.configure(logic);
        commandBox.addToPlaceholder();
        return commandBox;
    }

    public void configure(Logic logic) {
        this.logic = logic;
        registerAsAnEventHandler(this);
    }

    private void addToPlaceholder() {
        SplitPane.setResizableWithParent(placeHolderPane, false);
        placeHolderPane.getChildren().add(commandTextField);
        FxViewUtil.applyAnchorBoundaryParameters(commandPane, 0.0, 0.0, 0.0, 0.0);
        FxViewUtil.applyAnchorBoundaryParameters(commandTextField, 0.0, 0.0, 0.0, 0.0);
    }

    @Override
    public void setNode(Node node) {
        commandPane = (AnchorPane) node;
    }

    @Override
    public String getFxmlPath() {
        return FXML;
    }

    @Override
    public void setPlaceholder(AnchorPane pane) {
        this.placeHolderPane = pane;
}

In short, the developer needs to override:

setNode()
setFxmlPath()
potentially setPlaceholder()

and think of what is the sane thing to do for each of these methods. Additionally, to make the API pleasant to use, the developer also needs to implement a static load() method (and in that method, we need to decide which of the three overloaded UiPartLoader::loadUiPart() methods we should call)
The reason why is because the current implementation (though UiPartLoader) puts the responsibility on creating new controller instances on the FXMLLoader, but the FXMLLoader does not allow us to pass arguments to the constructed controller. This leads to a lot of boilerplate code just to work around this limitation.
With the changes in this PR, we construct the controller first and then pass it to the FXMLLoader, we can move the FXML loading directly into the UiPart constructor and reduce the above code to just:
    public CommandBox(AnchorPane placeHolderPane, Logic logic) {
        super(FXML);
        this.placeHolderPane = placeHolderPane;
        this.logic = logic;
        registerAsAnEventHandler(this);
        addToPlaceholder();
    }

    private void addToPlaceholder() {
        SplitPane.setResizableWithParent(placeHolderPane, false);
        placeHolderPane.getChildren().add(commandTextField);
        FxViewUtil.applyAnchorBoundaryParameters(commandTextField, 0.0, 0.0, 0.0, 0.0);
    }

which is much shorter.

v1
@pyokagan submitted v1 for review.

[v1 1/10] UiPart: implement FXML loading constructor
[v1 2/10] BrowserPanel: migrate to use FXML loading constructor
[v1 3/10] PersonListPanel: migrate to use FXML loading constructor
[v1 4/10] PersonCard: migrate to use FXML loading constructor
[v1 5/10] ResultDisplay: migrate to use FXML loading constructor
[v1 6/10] StatusBarFooter: migrate to use FXML loading constructor
[v1 7/10] CommandBox: migrate to use FXML loading constructor
[v1 8/10] HelpWindow: migrate to use FXML loading constructor
[v1 9/10] MainWindow: migrate to use FXML loading constructor
[v1 10/10] UiPart: remove deprecated construction methods

(:books: Archive)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/237/1/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

Looks like GitHub stopped calling mentionbot web hook. Let me close and reopen to see if that helps.

@damithc Oh whoops, I just remembered the diagrams also need to be updated as well :-P Will send an updated version.

@yl-coder any feedback?

v2
@pyokagan submitted v2 for review.

[v2 1/11] UiPart: implement FXML loading constructor
[v2 2/11] BrowserPanel: migrate to use FXML loading constructor
[v2 3/11] PersonListPanel: migrate to use FXML loading constructor
[v2 4/11] PersonCard: migrate to use FXML loading constructor
[v2 5/11] ResultDisplay: migrate to use FXML loading constructor
[v2 6/11] StatusBarFooter: migrate to use FXML loading constructor
[v2 7/11] CommandBox: migrate to use FXML loading constructor
[v2 8/11] HelpWindow: migrate to use FXML loading constructor
[v2 9/11] MainWindow: migrate to use FXML loading constructor
[v2 10/11] UiPart: remove deprecated construction methods
[v2 11/11] DeveloperGuide: update Ui component info

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v1 and v2)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/237/2/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

Changes since v1:

Made UiPart abstract again.

Updated the developer guide

UiPart test now checks that @FXML annotations work.

Will look at this by tomorrow.

v3
@pyokagan submitted v3 for review.

[v3 1/11] UiPart: implement FXML loading constructor
[v3 2/11] BrowserPanel: migrate to use FXML loading constructor
[v3 3/11] PersonListPanel: migrate to use FXML loading constructor
[v3 4/11] PersonCard: migrate to use FXML loading constructor
[v3 5/11] ResultDisplay: migrate to use FXML loading constructor
[v3 6/11] StatusBarFooter: migrate to use FXML loading constructor
[v3 7/11] CommandBox: migrate to use FXML loading constructor
[v3 8/11] HelpWindow: migrate to use FXML loading constructor
[v3 9/11] MainWindow: migrate to use FXML loading constructor
[v3 10/11] UiPart: remove deprecated construction methods
[v3 11/11] DeveloperGuide: update Ui component info

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/237/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

@yl-coder Sorry, please ignore the message from @CanIHasReview . Was just testing.

Nothing else other than the comments above

@yl-coder you can use GitHub's new 'request change' feature when requesting changes.

v3
@pyokagan submitted v3 for review.

[v3 1/13] UiPart: implement FXML loading constructor
[v3 2/13] BrowserPanel: migrate to use FXML loading constructor
[v3 3/13] PersonListPanel: migrate to use FXML loading constructor
[v3 4/13] PersonCard: migrate to use FXML loading constructor
[v3 5/13] ResultDisplay: migrate to use FXML loading constructor
[v3 6/13] StatusBarFooter: migrate to use FXML loading constructor
[v3 7/13] CommandBox: migrate to use FXML loading constructor
[v3 8/13] HelpWindow: migrate to use FXML loading constructor
[v3 9/13] MainWindow: migrate to use FXML loading constructor
[v3 10/13] UiPart: remove deprecated construction methods
[v3 11/13] DeveloperGuide: update Ui component info
[v3 12/13] StatusBarFooter: rename addMainPane() to addToPlaceholder()
[v3 13/13] PersonListPanel: use FxViewUtil.applyAnchorBoundaryParameters()

(:books: Archive) (:chart_with_upwards_trend: Interdiff between v2 and v3)

Checkout this PR version locally
git fetch https://github.com/se-edu/addressbook-level4.git refs/pr/237/3/head:BRANCHNAME

where BRANCHNAME is the name of the local branch you want to fetch this PR to.

Changes from v2..v3:

[v3 12/13] and [v3 13/13] are new commits.

 The PR has changed since your last review (v1).


DOC: MAKE GSSOC BANNER DYNAMIC 💡

What's wrong with the existing documentation

The GSSOC Banner of this repository is in black so that the logo is not properly visible in Github Dark mode, actually over 85% users using Github in dark mode only.
We want to resolve this issue as soon as possible.

Add ScreenShots

CURRENT STATE IN DARK THEME
DESIRED STATE IN DARK THEME

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

Hey there @avinashkranjan  👋🏻
Please make sure to assign this issue to me asap to make the work done!
Thank you.

Go Ahead

@avinashkranjan a person has created a PR for this issue which i was assigned by you without your permisson.
Kindly close his PR and merge my PR to fix this issue.
Thank you for your attention!

The issue is not fixed by your PR. The light mode is not working.
 I have used the new format syntax for that.

Bro, the light mode is finely working then how can i show the screenshot ?
First of all as a fellow contributor please make sure to follow ethics while contributing.
How can you open a PR without informing the Project Admin or the one who created this ?
Doing these types of stuffs is strictly against contributing guidelines.
Hope you understood, let the Project Admin @avinashkranjan  handle this problem.

First, I don't know how are you saying it's working fine when it's clearly not.

Secondly, it was my mistake that I overlooked your commitment and started to work on it. I realised it after making the PR.
After which, I didn't even mentioned once to merge my PR after that.

How can you see the image if the page still not properly loaded yet 🤦♂

Here's how it looks, just view it from view file from this PR.

I have already told you that you are not permitted to open a PR for which not assigned to you yet, You doesn't follow contributing guidelines here.
Please close that, that's all i can say.
Otherwise it will be closed by Project Admin.

You are using old syntax for image insertion, which is why it's just never loads or takes much time.
https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to
The mistake is not with my network but with your code itself. And not just arguing over guidelines maybe you should have fixed it when I mentioned it earlier.
Also, maintainers know the guidelines you are trying to specify in every message. The guidelines are meant to be for the betterment of the project and the PA will do same.


[chore] Better default config path for linux

This changes the default config directiory set at installation time to ~/.config/BetterDiscord for Linux users, which is about 100% more likely to be writable by the user.
It also makes use of path.join now, which is the recommended way to safely construct a path.

you should use XDG_CONFIG_HOME before using $HOME/.config.  So if XDG_CONFIG_HOME isn't set use $HOME/.config.

Sorry for just closing these but since I haven't had the time to develop; I haven't checked these pull requests either and they're now outdated :c
Feel free to reopen with necessary changes and I'll take a look at it now that I have time.


added entries for youte and tweetexploR

@boyd-nguyen thanks for requesting the review. I should be able to get this done by Thursday 19/01/23, is that OK or do you need it sooner?

@Quiet27 No problem at all! It's not urgent, I just thought I'd add the entries in case I forget

Thanks @Quiet27 Alice for reviewing this and for your suggested change!


gnomeExtensions: improve update script

Description of changes

Fix some typos
Script can be called from any location, collisions.json and  extensions.json will be created next to it
Get metadata.json from nix store, so it only has to be downloaded once

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This extension (https://extensions.gnome.org/extension/1460/vitals) version 53 has no metadata.json. If you download it throught the web page it has one...
Webpage link: https://extensions.gnome.org/extension-data/VitalsCoreCoding.com.v53.shell-extension_v1BI2FB.zip
Generated link: https://extensions.gnome.org/extension-data/VitalsCoreCoding.com.v53.shell-extension.zip
INFO:root:Processing<EMAIL_ADDRESS><EMAIL_ADDRESS>Downloading v53
Traceback (most recent call last):
  File "/home/rhoriguchi/Git/nixpkgs/pkgs/desktops/gnome/extensions/update-extensions.py", line 268, in <module>
    processed_extension = process_extension(raw_extension)
  File "/home/rhoriguchi/Git/nixpkgs/pkgs/desktops/gnome/extensions/update-extensions.py", line 193, in process_extension
    shell_version_map: Dict[ShellVersion, Dict[str, str]] = generate_extension_versions(shell_version_map, uuid)  # type: ignore
  File "/home/rhoriguchi/Git/nixpkgs/pkgs/desktops/gnome/extensions/update-extensions.py", line 111, in generate_extension_versions
    fetch_extension_data(uuid, str(extension_version))
  File "/home/rhoriguchi/Git/nixpkgs/pkgs/desktops/gnome/extensions/update-extensions.py", line 70, in fetch_extension_data
    with open(os.path.join(path, "metadata.json"), "r") as out:
FileNotFoundError: [Errno 2] No such file or directory: '/nix/store/g9naba5wqzj19alkizj7ah01hmx43y2n-VitalsCoreCoding.com.v53.shell-extension.zip/metadata.json'

How should that edge case be handled? @jtojnar @piegamesde

The extension night-theme-switch is outdated now, can it move to auto-update?

As far as I could find out, this should be a one-off and exceptional mistake. So either patching that one link or semi-gracefully failing with some angry log messages would be fine for me. Upstream told me to open an issue if this ever happens again.

Would be nicer to have single improvement per commit but woman_shrugging

Thx for the inputs. I've split the changes into multiple commits.


Interactive runner and the corresponding tests

Added Beam Python Interactive Runner, including

The runner itself /sdks/python/apache_beam/runners/interactive/*
The corresponding unittest
A Jupyter notebook demo

Design doc: s.apache.org/interactive-beam
YouTube demo: https://youtu.be/c5CjA1e3Cqw
R: @robertwb
CC: @ananvay
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Spark

Go

---
---
---
---
---

Java

Python

---

---
---
---

run test

run test

run test

run .. run test

retest this please

retest this please

Thanks, Pablo! I was exactly trying to figure out how to run test locally.

@charlesccychen

.

Run Python PreCommit

Would you like me to squash the commits into one? @charlesccychen

Run Python PostCommit

Thanks @qinyeli! I will merge after tests pass.


Fixes Nuke-Beta2 Crash bug.

Prevents rastercut from being considered by the group expecting code.
Adds first for rastercut, so it's considered in ordering for distances in new mode.

Apologies for the raster bug!!

Do you want to wait for beta3 until I diagnose the other (non-crashing) bug?

This should be fairly good enough. I think I got the non-crashing bug. Or rather made it work.

@Sophist-UK was there something else you wanted addressed before pushing out Beta3?

Beta3 is urgent because of my bad.
The two changes I want to make are not crashing things so less urgent and I cannot get to them until later. They will need to wait until Beta4 I think.
The bug in #767 still exists and will take some tracking down.
And the performance improvements can also wait.

Ah. Okay. I'm fine with additional betas. There's still a good amount of life in the 0.7.x line for features since I'm a bit better at merging in 0.8.0 than I was in 0.6.x 0.7.x divide. So features like ConsoleOp are easier to filter up to the higher levels of code. Just checking mostly against crashing and burning and slightly missed the mark on that one. All's well though.

@tatarize Thanks for fixing this though.


Custom NodeEnvironment not share modules with test

🐛 Bug Report

To Reproduce
Steps to reproduce the behavior:

Custom NodeEnvironment

// MyEnvironment.ts
import NodeEnvironment from "jest-environment-node";
import setup from "./setup";

export = class MyNodeEnvironment extends NodeEnvironment {
    constructor(config, context) {
        // @ts-ignore
        super(config, context);
    }

    async setup() {
        const testConfig = global["testConfig"];
        await setup(testConfig);
        this.global["testConfig"] = testConfig;
        await super.setup();
    }

    async teardown() {
        await super.teardown();
    }
};

// setup.ts
export default async (testConfig) => {
    CacheConnecter.cache = await createCache(testConfig.cache.uri) // not undefined
};

In test file, get connected cache instance in CacheConnecter, but it is undefined.  CacheConnecter in the setup.ts and in my test file is not the same.

    // test.ts file
const cache = CacheConnecter.cache; // undefined

Expected behavior
I think module and context should be shared between setup and test file.
Link to repl or repo (highly encouraged)

envinfo
System:
    OS: Linux 5.11 Ubuntu 21.04 (Hirsute Hippo)
    CPU: (8) x64 Intel(R) Core(TM) i7-4810MQ CPU @ 2.80GHz
  Binaries:
    Node: 14.17.1 - ~/.nvm/versions/default/bin/node
    Yarn: 3.0.1 - /usr/bin/yarn
    npm: 6.14.15 - ~/.nvm/versions/default/bin/npm
  npmPackages:
    jest: ^27.0.6 => 27.0.6

Hi @zyf0330,
It should be possible to assign globals for your test environment in the setup method. There is an example in the docs under testEnvironment that might be worth looking at.
If you can't get it to work, and you believe it's a bug, please link to a GitHub repository with a minimal reproduction and describe accurately how we can reproduce/verify the bug.
These resources might also be useful if you have questions or would like help:

The Jest help page
Our #testing channel in Reactiflux
The jestjs tag on StackOverflow

Actually, this situation is caused because module cache is reset. I know require.cache is reset between test files, but I am not sure if module cache should be reset between one test file and its Test Environment. So maybe you can explain about this point. I will post a example repo link to show this.
Of course, I can use setupFilesAfterEnv to do the same async preparation logics by beforeAll which won't reset module cache. (setupFiles can just run sync logic).


Add PowerToys Run Plugins

https://github.com/hlaueriksson/awesome-powertoys-run-plugins
PowerToys Run is a quick launcher for Windows. It is open-source and modular for additional plugins.
Unfortunately, the plugin manager in PowerToys Run does not offer support for finding or downloading community plugins.
So, I created an awesome list to fill that gap.
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request

[x] Don't open a Draft / WIP pull request while you work on the guidelines. A pull request should be 100% ready and should adhere to all the guidelines when you open it. Instead use #2242 for incubation visibility.
[x] Don't waste my time. Do a good job, adhere to all the guidelines, and be responsive.
[x] You have to review at least 2 other open pull requests.
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.

https://github.com/sindresorhus/awesome/pull/2984
https://github.com/sindresorhus/awesome/pull/2966#issuecomment-1965366898
https://github.com/sindresorhus/awesome/pull/2958#issuecomment-1965376005

[x] You have read and understood the instructions for creating a list.
[x] This pull request has a title in the format Add Name of List. It should not contain the word Awesome.

✅ Add Swift
✅ Add Software Architecture
❌ Update readme.md
❌ Add Awesome Swift
❌ Add swift
❌ add Swift
❌ Adding Swift
❌ Added Swift

[x] Your entry here should include a short description of the project/theme of the list. It should not describe the list itself. The first character should be uppercase and the description should end in a dot. It should be an objective description and not a tagline or marketing blurb. It should not contain the name of the list.

✅ - [iOS](…) - Mobile operating system for Apple phones and tablets.
✅ - [Framer](…) - Prototyping interactive UI designs.
❌ - [iOS](…) - Resources and tools for iOS development.
❌ - [Framer](…)
❌ - [Framer](…) - prototyping interactive UI designs

[x] Your entry should be added at the bottom of the appropriate category.
[x] The title of your entry should be title-cased and the URL to your list should end in #readme.

Example: - [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.

[x] No blockchain-related lists.
[x] The suggested Awesome list complies with the below requirements.

Requirements for your Awesome list

[x] Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
[x] Run awesome-lint on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.
[x] The default branch should be named main, not master.
[x] Includes a succinct description of the project/theme at the top of the readme. (Example)

✅ Mobile operating system for Apple phones and tablets.
✅ Prototyping interactive UI designs.
❌ Resources and tools for iOS development.
❌ Awesome Framer packages and tools.

[x] It's the result of hard work and the best I could possibly produce.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
[x] The repo name of your list should be in lowercase slug format: awesome-name-of-list.

✅ awesome-swift
✅ awesome-web-typography
❌ awesome-Swift
❌ AwesomeWebTypography

[x] The heading title of your list should be in title case format: # Awesome Name of List.

✅ # Awesome Swift
✅ # Awesome Web Typography
❌ # awesome-swift
❌ # AwesomeSwift

[x] Non-generated Markdown file in a GitHub repo.
[x] The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
[x] Not a duplicate. Please search for existing submissions.
[x] Only has awesome items. Awesome lists are curations of the best, not everything.
[x] Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file.
[x] Includes a project logo/illustration whenever possible.

Either centered, fullwidth, or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to a maximum of half the width of the original image.
Don't include both a title saying Awesome X and a logo with Awesome X. You can put the header image in a # (Markdown header) or <h1>.

[x] Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
[x] Includes the Awesome badge.

Should be placed on the right side of the readme heading.

Can be placed centered if the list has a centered graphics header.

Should link back to this list.

[x] Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of nested lists, preferably none.
Must not feature Contributing or Footnotes sections.

[x] Has an appropriate license.

We strongly recommend the CC0 license, but any Creative Commons license will work.

Tip: You can quickly add it to your repo by going to this URL: https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0 (replace <user> and <repo> accordingly).

A code license like MIT, BSD, Apache, GPL, etc, is not acceptable. Neither are WTFPL and Unlicense.
Place a file named license or LICENSE in the repo root with the license text.
Do not add the license name, text, or a Licence section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.
To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn.

[x] Has contribution guidelines.

The file should be named contributing.md. The casing is up to you.
It can optionally be linked from the readme in a dedicated section titled Contributing, positioned at the top or bottom of the main content.
The section should not appear in the Table of Contents.

[x] All non-important but necessary content (like extra copyright notices, hyperlinks to sources, pointers to expansive content, etc) should be grouped in a Footnotes section at the bottom of the readme. The section should not be present in the Table of Contents.
[x] Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

[x] Does not use hard-wrapping.
[x] Does not include a CI (e.g. GitHub Actions) badge.You can still use a CI for linting, but the badge has no value in the readme.
[x] Does not include an Inspired by awesome-foo or Inspired by the Awesome project kinda link at the top of the readme. The Awesome badge is enough.

Go to the top and read it again.

unicorn

Hi...
How does this work...?

Hi @solomoad

How does this work...?

Install Microsoft PowerToys
Find community plugins that you like
Install them to %LocalAppData%\Microsoft\PowerToys\PowerToys Run\Plugins
Open PowerToys Run with alt + space
Execute the plugins with their action keywords

Tweet: https://x.com/awesome__re/status/1848777696224096535


move lib out of example

I think we can move things to the top level.
@arthurpaulino does this require some plumbing on the lurk-rs side? If so I think we can merge here and then PR there with that work + updating the git submodule

Yeah, it will require some changes.
I can already see that some files listed in test_lurk_lib wouldn't be found after this change.
Also, did you check if all the load meta commands on those files will still work? Because that would be a self-contained breakage in the lib itself


UserManager.signinPopup closes with code, but returns an error instead

I have a small django server with django-oauth-toolkit, and I've been trying to get this library working (among react-oidc-context, but it's not too relevant right now because I can reproduce the same issues using UserManager directly)
Here's a minimal code sample that showcases the behavior I'm getting.
  const userManager = new UserManager({
      authority: "http://localhost:8000/o/",
      client_id: "EXAMPLE_CLIENT_ID", // This is just obfuscated, the actual client ID of the OAuth application is here
      redirect_uri: "http://localhost:8000/jsoCallback",
  })

console.dir(await userManager.signinPopup())

This seems to initiate the OAuth flow properly and a popup with the login appears, but after logging in and authorizing the scopes, I can see the popup window URL change briefly to the redirect URL with the access token, then it closes.
I'd expect the User instance to be logged, but instead I get an error that the popup was closed by the user (https://github.com/authts/oidc-client-ts/blob/d1c9354bf5289a878c262090ea5f7f31de697fb7/src/navigators/PopupWindow.ts#L41). I'm not sure if I'm doing anything wrong. The only think that I can think of is that the provided redirect_uri is not related to the current window href, which I could understand being an issue if I were using signinRedirect, but with the popup this shouldn't be an issue.

When using popup mode, you should redirect to an html page containing the following:

When using popup mode, you should redirect to an html page containing the following:

Wow, that was fast!
Thanks for the input. Actually I realized that the reason the oauth popup was closing is because there was a script in the redirect URL html page closing the window...
I've removed that and added the window.postMessage script, and now it doesn't close automatically, but unfortunately nothing else happens either, so I assume that there's something wrong with the message. I'll try to dig a bit on the code on how the client handles the message, is there any other place with documentation about the popup mode? I couldn't find a lot by myself unfortunately.
Also, for reference, here's the HTML page that I'm redirecting to.
<!DOCTYPE html>

        <meta charset="utf-8">
        <title>Successfully logged in</title>

Your app should load the oidc-client-ts which itself should load a popup.
Inside the popup, you should be presented with your IDP login page.
Then once logged-in, your IDP should redirect you to your redirect_page (still inside the popup).
Once on the redirect_page the script should post the current url to the parent window (ie. your app).
The lib is listening to this post (here), so it will receive the url, extract the info and close the popup.
Everything should be fast enough so you don't even see the redirect_page displayed in the popup (and as such you don't need a title or anything else than the script)


Gettext (.po file) support

When trying to read .po-based language files, I run into a SyntaxError: Unexpected string based on this call (in an else-closure):
https://github.com/pixari/vue-i18n-extract/blob/1ed4c301636c73cd0cc32e94109bc7e02d7880e6/src/create-report/language-files.ts#L33
It looks like there is no support for Gettext / .po fles has been implemented. Could this be achieved by using a loader like @openculinary/i18next-gettext-loader?  Would love to see this file format supported.
To reproduce:

create a Vue project using gettext
install this CLI tool
run npx vue-i18n-extract --languageFiles (json|yaml|yml|po) --vueFiles (your|file|matcher) (essentially adding po files into the Glob pattern)

We're open to a PR that adds .po support, but it's outside the scope for the contributors of the project right now! Sorry!