App crashing without any logs, repack 3.2.0

Environment
System info
System:
    OS: macOS 13.3.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 34.69 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.20.0 - /opt/homebrew/opt/node@16/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.19.4 - /opt/homebrew/opt/node@16/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK: Not Found
  IDEs:
    Android Studio: Dolphin 2021.3.1 Dolphin 2021.3.1
    Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.18 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: 0.71.8 => 0.71.8
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Description
I'm trying to follow the SuperApp/MiniApp approach using Module Federation, I follow all the steps from the Docs , but the application closes suddenly.
I created an API for serving the remote url and the bundle is served via CDN.
Reproducible Demo
The App architecture basically consists of two apps, being one the host and the other the mini app.
Mini App
The mini app contains its own navigation and is exposed as below:
plugins: [
      new Repack.plugins.ModuleFederationPlugin({
        name: 'rePackMiniApp',
        exposes: {
          './miniApp': './src/navigation/MainNavigation',
        },
        shared: {
          react: {
            singleton: true,
            eager: STANDALONE,
            requiredVersion: '18.2.0',
          },
          'react-native': {
            singleton: true,
            eager: STANDALONE,
            requiredVersion: '0.71.8',
          },
          '@react-navigation/native': {
            singleton: true,
            eager: STANDALONE,
            requiredVersion: '6.1.6',
          },
          '@react-navigation/native-stack': {
            singleton: true,
            eager: STANDALONE,
            requiredVersion: '6.9.2',
          },
          'react-native-safe-area-context': {
            singleton: true,
            eager: STANDALONE,
            requiredVersion: '4.5.3',
          },
          'react-native-screens': {
            singleton: true,
            eager: STANDALONE,
            requiredVersion: '3.20.0',
          },
        },
      }),

It was bundled using webpack cli, and then all the code got from build/generated/android was uploaded to a S3 and served via CDN through a link like: https://base-url/mini-app-bundle/rePackMiniApp.container.bundle.
A bundle server was created to serve this url to the main container:
const express = require('express');

const rePackMiniApp = require('./data/mini-app.json');

const app = express();
const port = 3000;

app.use('/', (req, res, next) => {
    console.log(req.url);
    next();
});

app.get('/repackminiapp', (req, res) => {
  const platform = req.query.platform;
  const appVersion = req.query.appVersion;

  res.send(rePackMiniApp[platform][appVersion]);
});

app.listen(port, () => {
  console.log(`Bundle server listening on port ${port}`);
});

// mini-app.json
{
  "ios": {
    "0.0.1": {
      "rePackMiniApp": "https://base-url/mini-app-bundle/[name][ext]"
    }
  },
  "android": {
    "0.0.1": {
      "rePackMiniApp": "https://base-url/mini-app-bundle/[name][ext]"
    }
  }
}

Host App
The ScriptManager is configured like:
ScriptManager.shared.addResolver(async (scriptId, caller) => {
  const containersResponse = await fetch(
    'http://localhost:3000/repackminiapp?platform=android&appVersion=0.0.1',
  );

  const containers = await containersResponse.json();

  const resolveURL = Federated.createURLResolver({
    containers,
  });

  if (scriptId === 'rePackMiniApp') {
    const url = resolveURL(scriptId, caller);
    console.log(url);
    if (url) {
      return {
        url,
        query: {
          platform: Platform.OS,
        },
      };
    }
  }

  if (__DEV__) {
    return {
      url: Script.getDevServerURL(scriptId),
      cache: false,
    };
  }

  if (localChunks.includes(scriptId)) {
    return {
      url: Script.getFileSystemURL(scriptId),
    };
  }
});

AppRegistry.registerComponent(appName, () => App);

Webpack config

plugins: [
      new Repack.plugins.ModuleFederationPlugin({
        name: 'rePackSuperApp',
        shared: {
          react: {
            singleton: true,
            eager: true,
            requiredVersion: '18.2.0',
          },
          'react-native': {
            singleton: true,
            eager: true,
            requiredVersion: '0.71.8',
          },
          '@react-navigation/native': {
            singleton: true,
            eager: true,
            requiredVersion: '6.1.6',
          },
          '@react-navigation/native-stack': {
            singleton: true,
            eager: true,
            requiredVersion: '6.9.2',
          },
          'react-native-safe-area-context': {
            singleton: true,
            eager: true,
            requiredVersion: '4.5.3',
          },
          'react-native-screens': {
            singleton: true,
            eager: true,
            requiredVersion: '3.20.0',
          },
        },
      }),
      new Repack.RepackPlugin({
        context,
        mode,
        platform,
        devServer,
        output: {
          bundleFilename,
          sourceMapFilename,
          assetsPath,
        },
        extraChunks: [
          {
            include: appConfig.localChunks,
            type: 'local',
          },
          {
            exclude: appConfig.localChunks,
            type: 'remote',
            outputPath: path.join('build/output', platform, 'remote'),
          },
        ],
      }),
    ],

And it is imported using React.Lazy + Federated.importModule.
const MiniAppNavigator = React.lazy(() =>
  Federated.importModule('rePackMiniApp', './miniApp'),
);

App running
https://github.com/callstack/repack/assets/133077851/37eabca2-bf68-4448-88e8-447975c6afaf
Console

Am I missing something?

Hi @breno-rdv,
Could you please provide an reproduction repository with the stuff you've provided so that we can investigate this issue?
Please also check and provide adb logcat logs with errors related to the your app.

Hi, sure!
Below is the project exported as zip from Github.
re.pack_spike-main.zip

@jbroma you can find the code in this repo here

Any progress on this issue? I reviewed everything and could not find any problem related to code.

Hi @breno-rdv,
Can you please tell me steps to reproduce this error? I was able to run the app locally in development without any issues using the following steps:
SuperApp:
yarn start-mx-android
yarn android

MiniApp:
adb reverse tcp:9001 tcp:9001
yarn react-native webpack-start --port 9001

The only change I needed to do to get it to work in local environment was this:
Before:
// rePackSuperApp/src/bootstrap.ts
ScriptManager.shared.addResolver(async (scriptId, caller) => {
  const containersResponse = await fetch(
    'http://localhost:3000/repackminiapp?platform=android&appVersion=0.0.1',
  );

  const containers = await containersResponse.json();

  const resolveURL = Federated.createURLResolver({
    containers,
  });
  // ...

After:
// rePackSuperApp/src/bootstrap.ts
ScriptManager.shared.addResolver(async (scriptId, caller) => {
  const resolveURL = Federated.createURLResolver({
    containers: {
      rePackMiniApp: 'http://<IP_ADDRESS>:9001/[name][ext]',
    },
  });
  // ...

@jbroma worked perfectly! We are gonna stick with Re.pack for our SuperApp/MiniApp approach.
Thank you so much!


MPR view missing slices after recent updates - V3

Describe the Bug
Enabling MPR view on certain studies causes either white images to be displayed in the 3 viewports or what appears to be missing slices.
This seems to only be happening on these cornerstone versions
    "@cornerstonejs/core": "^0.25.0",
    "@cornerstonejs/tools": "^0.34.2",

I'll open a PR with the bumped versions and link it to this issue.

:warning: Reports we cannot reproduce are at risk of being marked stale and
closed. The more information you can provide, the more likely we are to look
into and address your issue.

@sedghi I've sent you the anonymized zip on slack

Can you try in the latest build?

Thanks @sedghi


Environment constant getter functions do not compile for arrays

The constant getter functions added in 09c4c67 such as const int* get_CYCLE_LENGTH() from the keratinocyte example do not compile.
As these are fixed size arrays, (i.e. int h_env_CYCLE_LENGTH[5])  this is not simple, and merely changing the prototype to const int** get_CYCLE_LENGTH() is not sufficient.

It is possible to access the h_env_CYCLE_LENGTH array directly from within functions.c, without the use of a getter function ( i.e. h_env_CYCLE_LENGTH[0]).
For now, I will disable the getter function for array environmental variables to allow the keratinocytes example to compile.

const int* get_CYCLE_LENGTH() should be const int* get_CYCLE_LENGTH(unsigned int index)
Also, why does this return a pointer for non arrays anyway not a literal?


VG-5667 - update events to pass doc id and user

Codecov Report

Merging #115 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   79.77%   79.76%   -0.02%
==========================================
  Files         117      117
  Lines        7689     7694       +5
  Branches     1158     1158
==========================================
+ Hits         6134     6137       +3
- Misses       1555     1557       +2

Impacted Files
Coverage Δ

app/src/details/details-actions.js
65.21% <ø> (ø)
:arrow_up:

app/src/search/search-controller.js
80.41% <ø> (ø)
:arrow_up:

app/src/results/table-row.js
90% <ø> (ø)
:arrow_up:

app/src/results/card.js
84.15% <ø> (ø)
:arrow_up:

app/src/search/search-map-controller.js
71.97% <ø> (ø)
:arrow_up:

app/src/search/search-service.js
67.47% <ø> (ø)
:arrow_up:

app/src/results/action-manager.js
72.09% <0%> (-0.85%)
:arrow_down:

app/src/details/details.js
80% <100%> (+0.05%)
:arrow_up:

app/src/app-config.js
73.58% <75%> (-0.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca32c2...cfde8a9. Read the comment docs.


understanding how to use chromasync

The documentation seems to be missing. Perhaps you can enlighten me a little.
Inside the chromasync folder where it is installed, are two folders named packages and scripts. I understand the scripts are lua. What is the packages folder for? Do I need a script AND a package for any given thing I want to do? And how are the lua scripts activated? I installed chromasync. But the only interface is in the taskbar. I looked at the volume_main.lua script but am a little befuddled. Is there a tut for dummies?

Scripts is mainly for debugging and development, any Lua scripts that are put in there will run when Chroma Sync starts. Packages on the other hand are for deployment, they hold all the files that are needed to install that mod, and then Lua scripts for it. I hope that help clear it up ;)

Oh and also there isn't any documentation yet, hopefully there will be some up soon

As a new chroma owner i looked into making some of my games more interactive on the keyboard on the same level as CS:GO was showed on the website.
Am i understanding it right that ChromaSync needs to be hardcoded to "every" game we wan't to make our scripts for?
I can't seem to find any info about how ChromaSync castches ingame events and parses them.

@beringtom You will need some way of retrieving the in-game data, and for games that already exist it will require use of an official API or a mod API.
In the case of CSGO, it uses an official API. As for Minecraft, it uses a mod API provided by Minecraft Forge.

Anyone have any idea how to just generally detect keys being pushed?
(Or how DebugLua works for that matter? I've been outputting text by just error(str) and reading the logs)

@njbmartin Any chance of y'all open sourcing the Chroma Sync application? Assuming it is starting API services to handle the state requests and then mapping the states to the methods defined in the Lua configurations. Where can I find documentation on the Lua namespaces, i.e. clr.Corale.Colore, Keyboard? I'm assuming that is bundled with the ChromaSync exe. Also, can you provide a map of CSGO state events -> CSGO_Example methods?

Corale is a external library, please use google in the future http://lmgtfy.com/?q=Corale.colore

Thankyou for answering one of his multiple questions.
Do we have any form of -actual- documentation, such as how the events work and what not?

Actually easier to just use Corale and make your own program..

But I LIKE Lua.

You can do much more with C#. Sure, ChromaSync a nice app but it is only using API's, so then you can't do anything more than creating scripts (Because it's not open).

Yeah but I've no clue how to use C#, other than in the context of unity. I should look into it.

Thanks for the clarification. Can you elaborate on how the Lua scripts are
processed and how the dependency injection is working to resolve references
to external packages like Colore?
On Friday, October 7, 2016, Nico<EMAIL_ADDRESS>wrote:

Hey guys. To clear things up, while @Pet0203 https://github.com/Pet0203's
suggestion of reading the Colore docs will help you understand the
interaction a lot better, the Colore API is only partially supported
through the Lua wrapper.
The Lua scripts are a lot more powerful than @Pet0203
https://github.com/Pet0203 suggests. While you have the ability to
write "isolated" custom scripts, you can chuck almost any json object at
Chroma Sync's local server and write scripts to consume the information.
You essentially POST to http://localhost:13000 from anywhere (even your
browser). For the script to consume the data, you need to register it:
RegisterForEvents("Counter-Strike: Global Offensive",
CSGO_Example.handleData) That's essentially how the CSGO and Minecraft
packages work.
I'd also like to mention that Chroma Sync was created by myself and is
still experimental at the moment, hence the lack of documentation. I've
also been quite busy for the last few months so I'm just getting back to
this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/UltraboxEntertainment/chromasync-sdk/issues/2#issuecomment-252183338,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC3qs-YfUZdj8F0wIZXY_jk_fcOWweQ9ks5qxgQSgaJpZM4G9waD
.


Jump to Gradle wrapper 4.10.1

Turns out the Android plugin 3.3.2 refuses to work otherwise.

The previous pull was a bit premature. I guess we'd need to add a couple tests and gate on them


No longer updating crops

Sometime in the last 12 hours Accountant stopped updating crop information. I noticed when it claimed plants were withering that were not, and after watering them nothing changed. I have restarted the game and ensured that everything is up to date. I tried deleting all the crop entries in Accountant and now they're just not getting added back. Submersible, Retainer, and Map timers are all still working.

Checked the xldev logs, and there is one warning of unknown interest but also some errors from Accountant:
09:04:15.467 | WRN [XivCommon] [XIVCommon] Could not find signature for Examine. This functionality will be disabled.
09:06:36.332 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:06:40.153 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:07:43.800 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:07:44.814 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:07:45.787 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:07:47.347 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:07:48.361 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:09:49.021 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:09:55.471 | ERR [Accountant] Housing Zone 0 should not be able to have crops.
09:10:03.178 | ERR [Accountant] Housing Zone 0 should not be able to have crops.

Dalamud issue.


Replace Jaeger exporter with OTLP

Summary of Changes

Replace Jaeger exporter with OTLP
Bump up versions of prometheus-cpp and opentelemetry

Closes #185
Motivation
The Jaeger exporter is being deprecated  in July 2023.
Implementation
Changing exporters turned out to be a fairly drop-in replacement. Versions for both of the dependencies needed to be bumped up but there were no API changes.
The tracing documentation for Jaeger also needed updating.
Notes
Rebuild the container to get these changes.
There's also an error message printed when the OTLP exporter can't connect to a collector. This is expected if you're not running something. While the message could be suppressed by disabling logging in opentelemetry, I think it's useful to have around. It can also be removed by excluding tracing from the server compilation.

Build failed!

Build successful!

Build successful!


Update StockBugFixModules

New releases.

Removes the asset_match since now only a single zip file is published in the release.
Strip leading v from version cause I like neatness.
Updates ksp_version to 1.1.2. (Unfortunately, no .version file).
Updates resources.homepage to new forum URL
Removes ModuleManager as a dependency since it's no longer needed.
Updates the install stanza to account for new directory structure.
Removes StockBugFixPlus.netkan since it no longer exists separately.

Looks like StockBugFixPlus became the new StockBugFixModules, closing this for now.


fix(system-setup-on-your-host): modify confusing descriptions

Signed-off-by: Cynthia Liu<EMAIL_ADDRESS>related discussion 3014.
It's very confusing, the origin tutorial left out the map directory information, we may miss such confusing things.

Hello @kenji-miyake
Can you help review this small change?
Thank you very much.


HDFS-15253 Default checkpoint transfer speed, 50mb per second

NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  3s

trunk passed

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
1m  9s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 53s

trunk passed

+1 :green_heart:
mvnsite
1m 17s

trunk passed

+1 :green_heart:
shadedclient
18m  5s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
3m 10s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  8s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  8s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
compile
1m  4s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
1m  4s

the patch passed

+1 :green_heart:
checkstyle
0m 48s

the patch passed

+1 :green_heart:
mvnsite
1m  8s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
16m  0s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m 17s

the patch passed

_ Other Tests _

-1 :x:
unit
110m 10s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

200m 21s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.TestFileChecksum

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2366/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2366

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 26ed9484402b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1cfe5916e20

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2366/1/testReport/

Max. process+thread count
3060 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2366/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

+1 LGTM, test case failures are unrelated to the patch. Will merge it shortly.
Thanks @karthikhw for the contribution.
Thanks @mukul1987 for the reviews.


Change field name "organism" to "synthetic"

The MiAIRR item "Organism-based or synthetic" currently maps to the Formats WG field name organism. This creates ambiguity with the field name species_name. Furthermore the BioSample correlate to species_name is organism.
Proposed solution:
Rename organism to synthetic. Define it as boolean.
Rename species_name to organism.

Discussed in today's call. Changes accepted, commit f8a85e72.


Default Profile when starting VSCode

It would be nice to have a default profile every time VSCode is opened. Currently, the last profile used it opened. This would be useful if someone has a lot of extensions (such as language support for many languages) but only needs limited functionalities such as GitLens and Git Tree, loading everything will be too slow and heavy on resources

Disable all extensions by default

And include only the necessary extensions


build: update packages

Description of changes
Updated @graphql-codegen and @graphql-tools plugins which were throwing deprecation warning when the package was installed. Updated some other build/test packages as well

Issue #, if available

Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] Breaking changes to existing customers are released behind a feature flag or major version update
[ ] Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #325 (bd0ea4f) into master (cb476b0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   84.72%   84.72%
=======================================
  Files         142      142
  Lines        6532     6532
  Branches     1677     1677
=======================================
  Hits         5534     5534
  Misses        907      907
  Partials       91       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb476b0...bd0ea4f. Read the comment docs.


vsts-npm-auth: Unable to authenticate when probing

Hi,
I am on Windows.
I am attempting to use vsts-npm-auth to handle authentication against an Azure feed.
.npmrc in my users profile
registry=https://registry.npmjs.com
The .npmrc file in my project (next to package.json)
registry=http://linktoregistry.com/npm/registry
always-auth=true
package-lock=false

When I run
vsts-npm-auth -config .npmrc -v detailed, I receive the following.
vsts-npm-auth v<IP_ADDRESS>
-----------------------
Parameters:
  AuthenticationProviders=wia,federated
  Config=.npmrc
  Help=False
  NonInteractive=False
  TargetConfig=
  ExpirationMinutes=129600
  ReadOnly=False
  Force=False
  Verbosity=Detailed
INI (resolved): registry=https://registry.npmjs.com
INI (resolved): registry=http://linktoregistry.com/npm/registry
INI (resolved): always-auth=true
INI (resolved): package-lock=false
Probing
http://linktoregistry.com/npm/registry
Probe response code: 401 Unauthorized
Credential type: Unknown.
Has valid credentials: False.

The authentication works just fine when I add the token to my user .npmrc manually, however, I do not want our users to do something like that every 90 days or so, either via a gulp task or an npm task when our developers are working on things locally.
Additionally, if I have the token in my user .npmrc, and add the -f flag to force re-authentication, I get the same probe response code and credential type.
EDIT: If this is in the wrong place, please let me know and I will move it.

Hi, this isn't really the right place for it, but there isn't a much better place, so I'll try to help here.
Are you trying to use this to authenticate to an on-premises install of TFS? vsts-npm-auth only works with the hosted version of Azure DevOps.
The probe makes an unauthenticated request to the registry, and then looks for the 'X-VSS-AuthorizationEndpoint' header in the response. Credential type: Unknown suggests that the response isn't returning that header, and as such is not a hosted Azure DevOps npm registry.

@jotaylo I have a sneaking suspicion that it's an on-premises install of TFS instead of a hosted version. Are there any other ways that I can verify?
Something I noticed is that there when I click the connect to feed, it doesn't recommend vsts-npm-auth as a tool.

If it's a hosted version the uri will be either https://[org].visualstudio.com or https://dev.azure.com/[org]
(and yes, vsts-npm-auth only shows in connect-to-feed in the hosted version).
The connect-to-feed UI generates a 90 day token, but users can use the security dialog to generate a token that is valid for up to a year: see Create a token that lasts longer than 90 days

Hmm... Okay, I am pretty comfortable saying that TFS is on premise. The URL follows this pattern https://{server}:8080/tfs/.
I guess I'll have to investigate using the tokens or some other method.

Yep, that's on premise. I'm sorry about that, unfortunately there are technical differences between how auth works between hosted and on-prem, and we're only able to get vsts-npm-auth working for the hosted instance at this time.


Bug: Button should also work in light mode.

Describe the bug

Steps to reproduce
Turn on light mode and navigate to https://github.com/Anush008
Affected services
pizzaface
Platforms
No response
Browsers
No response
Environment
No response
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

https://github.com/open-sauced/browser-extensions/pull/20#issuecomment-1515742432

Discussed about this here: https://github.com/open-sauced/browser-extensions/pull/20#issuecomment-1515742432.


Add parent labels

Given a label structure like:

list

abc
def

If you wanted to search all of the emails in both list-abc and
list-def, you'd need to search label:list-abc OR label:list-def.
This is because Gmail label nesting is actually flat, not really
hierarchical.
This change updates the labeling such that parent labels are added as
well, so searching label:list would give all emails in both abc and
def lists.

Bad news -- I'm running this and somewhere along the ts upgrade path something changed with the utils.ts file. I believe the fix is to wrap those functions in a class.
https://github.com/google/clasp/blob/master/docs/typescript.md#modules-exports-and-imports
You'll probably want to roll make a new commit that un-does this.

Addressed the issue in #59 . Note that since it's an issue in the Clasp build, you probably wouldn't notice it unless you look at your script executions or unprocessed folder in GMail.


Investigate other syntax options

1. here doc
This might be the most popular due to adoption by shells and the friends (perl, ruby, etc).
There are two parts of the here doc syntax, first, the leading symbol, normally it's <<, some languages have <<- and/or <<~ for tab/indentation process.
The big problem of these symbols is  tag << blahblah,  tag <<- blahblah,  tag <<~ blahblah already are valid syntax in JS. Maybe this is why PHP use <<< instead of <<.
The second part is ident as a delimiter, many support 'ident' for non-interpolation version. C++, D drop << symbol, but still use customized ident as delimeter.
Note, it seems no language support customized interpolation delimiter by here doc style syntax.
My feeling is, it's hard to use here doc style in JS.
2. Swift / Rust style
They use surrounding # s. If we adopt this style, the syntax will look like
let x = #` string can contain ` or #.`#

If follow Swift interpolation design, #` ${foo} `# would be no interpolation effect. To have the effect, use same number of # -- #` $#{foo} `#. It also could be used to enable escaping case by case: ###` \n <-- raw, \###n <-- line break here `###
I feel swift-like design is very concise and attractive. It could be the good option of JS.
The only drawback is it can't satisfy goal 5:

Current usages of template literals should be easily migrate to the new syntax. Importantly, if a template literal does not need to present ${ characters, it should not be forced to change interpolation syntax.

3. Markdown fenced code block style
I think most programmers already know that format. Though there are challanges:
Surprisingly, three backticks already valid syntax in JS. So it will be breaking change of language even no one really use three backticks in current codes.
I guess there is still chance to use this syntax but need many extra works. So an easier way is to add prefix @ or #.

How about a variant on the swift style where interpolations (and escapes) require same number of $ (and \) as # to work?
Example:
let x = #` this string can contain interpolations ${a} and \n escapes as ususal`#
let y = ##` but this string requires $${a} for interpolations and \\n or escapes`##

@zaygraveyard It seems much more cleaner than the current one.

@zaygraveyard @mon-jai  Of coz it's an option.
But there are a few points to consider:

The correspondence between the number of # symbols and the number of $ \ symbols requires additional cognitive effort.

In a long text, there are three different special symbols to identify (for example, $$$, \\\, and ###). In contrast, Swift's approach uses only one special symbol.

When the number of # symbols needs to be changed in a long text, the cost of identification transforms into the cost of searching and replacing. Without dedicated IDE support, this cost can also be three times higher compared to the Swift approach.

No simple way to disable all escaping and interpolation so you can just write any number of \ or $ without worry of triggering escaping and interpolation accidently. In Swift, you only worry about any number of #. Moreover, the probability of simple repeated characters occurring is much higher than the probability of special characters combined with repeated characters occurring.

@hax That make senses. Can I conclude it this way?

Original proposal(@``string``)
#2 proposal(#`string`#)
@zaygraveyard's proposal(#`string`#)

Special character sequences
$, ``
$#, \#
$, \ ,#

Insert escaped characters
Unsupported
\#n
\n

@hax Fair points and I do agree, but I would like to point out that they also apply to the original proposal (except for \ since escaping is not supported AFAICT).
@mon-jai Your "base case" is equivalent to `My name is ${name}`, correct?

The base case is similar to #96;My name is ${name}#96;, but with indentation removed if the string has multiple lines.

I love the initial Swift-inspired idea:

It also looks like Rust – which many JavaScript programmers are familiar with.
It scales seamlessly from zero hashes to one or more hashes.
It’s always possible to prevent delimiters, escaping and substitutions from getting in the way. But needing more than one hash should be exceedingly rare.

`Can't use backticks \n ${someVar}`
#`Can use `backticks` \#n $#{someVar}`#
##`Can use #`backticks with 1 hash`# \##n $##{someVar}`##
###`Can use ##`backticks with 2 hashes`## \###n $###{someVar}`###

Another possible syntax and prior art example:
LUA has [[ multiline string ]] and [===[ multiline string ]===], with any number of =, just same on both ends.
To adapt in JS the opening would have to be prefixed with @ or something to distinguish from array literal, @[===[ multiline string ]===].
Has the advantage that opening and closing patterns are easier to distinguish from each other.
We could also go for any number of brackets instead of =, @[[[[ multiline string ]]]] but that adds issues when you want literal ] right at the end of your string.
Same goes for the current proposal tho, what if you want the string to end with `?
It is solved by allowing or requiring whitespace before the closing pattern (like requiring it to be on its own line), but that in turn makes it necessary to "eat" its preceding whitespace, complicating things further when you want to end with whitespace or line break, as well as making it take more lines which IMO may look bad.
(tangential to this issue, but I feel the default syntax shouldn't "dedent" or strip or otherwise alter the white space you typed, leave that to custom tags for those who need it)
P.S. LUA also does that for block comments:
--[=[ see how this --[[ nested comment ]] did not close the outer comment ]=]
@//[=[ js could too @//[[ but probably as a separate proposal ]]]=]

@anonghuser
Theoretically speaking, JS does not need to add @ at the beginning, because the combination [= is currently not a valid syntax.
As I understand it, the characteristic of the Lua style is the use of paired opening and closing symbols [ and ]. However, I am not sure if this has unique advantages. For instance, theoretically speaking, even with the Swift style, it is still possible to allow the outer pattern to be shorter than the nested pattern—because the continued # symbol is almost impossible to form meaningful syntax, so the parser can choose to look one more character to decide if it is the closing delimiter.
Regarding the issue of trailing whitespace, it is indeed a matter worth considering. However, my current experience is that the most important scenario for this proposal is large chunks of text, and for large chunks of text, trailing whitespace at the end of each line is an issue in itself (for example, most editors may automatically remove trailing whitespace). Even if we restrict the syntax to ensure trailing whitespace in the string, it cannot solve the problem of trailing whitespace at the end of each line in the real world, at most it only solves the problem of the last line.

even with the Swift style, it is still possible to allow the outer pattern to be shorter than the nested pattern—because the continued # symbol is almost impossible to form meaningful syntax, so the parser can choose to look one more character to decide if it is the closing delimiter.

@hax i like this, but it would probably need to be made clear explicitly if you do pick this syntax for the proposal, i.e. tag#`a`##`b`# is a single tagged literal, and not equivalent to (tag#`a`#)#`b`# or tag #`a`# #`b`# (which are equivalent to each other)


Added function Get-NavContainerServerConfiguration.

Added function Get-NavContainerServerConfiguration, this function will retrieve the server configuration of the server in the container and return it as an PowerShell object.
The idea was based on the Get-NAVServerConfiguration2 from Waldo but was tweaked so we can access the settings like this: Configuration.DatabaseInstance, Configuration.DatabaseName etc.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: richardrobberse sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

I like the idea.
A few things:

help is missing for parameters.
no need to have a serverinstance parameter - it will always be NAV inside a container
pipelining isn't used anywhere else, I would like to add that to all in one go - and not start off with one function and then break something if I decide to do things differently
code doesn't look like the other functions in this module (begin, end, resultobjectarray). Now that might be because we should change all the other functions, but I would like to keep things the same and then refactor in one go.

I have taken the function from this PR and added to the next version of navcontainerhelper


Uncomplete Theme?

Hello,
first of all thank you for making this theme.

The main window (Summary Tab) as well as the code syntax do not seem to change as expected?

Hi, did you add the related color schemes to the Packages folder? You can download the color schemes in either the Sublime Text/Packages or Sublime Merge/Packages to get the Theme fully working on Sublime Merge

This is Sublime Merge with fully working Monokai Plus (Octagon) theme set on the preferences.

I just double checked.
First I tried the linked rep containing the sublime-color-schemes. While using those all I could see was an entirely black window.
Then I cloned the sublime-theme rep again and put them in the package folder like before. Same issue.

Also this is my preferences file:

It works fine on my side. This is the Spectrum Color Scheme on Sublime Text and the Theme on Sublime Merge.

Clone both git repositories this time on the Sublime Merge Packages folder. They should be separate folders. One with the Color Schemes and the other with the Themes.

I just did that

and edited the Preferences.sublime-settings :

It's the same syntax I used to configure sublime text, except there I used the original Monokai Pro Theme.
Now I get proper syntax highlighting inside the code blocks but still have the basic dark theme from sublime in the background.

Maybe thats because of this:
"extends": "Merge.sublime-theme", ?

Okay let me be more clear. Step by step:

Open a new tab in Sublime Merge. Clone the theme repository in Sublime Merge/Packages.

Open another tab in Sublime Merge. Clone the color scheme repository in Sublime Text/Packages or in Sublime Merge Packages.

Do not change or remove the files from the cloned repositories. They must be there for the theme to work.

Edit the Sublime Merge settings. The only thing you need to do is change the theme name. There is no need to add the color scheme in the SM settings.

If you follow these instructions, the theme should work.

Thanks for the step by step guide.
Maybe I should be more clear as well:
If I try another filter, say Octagon it looks as expected

But if I use spectrum it looks like this:

Now the background in the summary window is not part of the spectrum theme which leads me to believe that there is some property missing in the theme or it is set to the wrong color.

That's really weird. All of them work for me. Here is a clip showing each Monokai theme variant.
https://user-images.githubusercontent.com/22452474/145126669-36403e4d-b492-4d86-8d43-2a464c89b6cf.mp4
Possible solutions:

Close and reopen Sublime Merge
Make sure you have all the the Color Schemes/Themes files
Add this line to your SM settings: "theme": "Monokai Plus (Spectrum).sublime-theme"

At this point all I can say is thank you for your support but I really do not think that the problem is on my end, since the other themes work and this isn't the first theme I have used.
Additionally I've already re-cloned the rep multiple times and have done several other steps.


Feature/update management server

What type of PR is this?

Uncomment only one  /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:
/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature
What this PR does / Why we need it:
This PR extends the management server to also support filtering address types for game servers the same way the agent is doing

I am currently working on signing the cla, but its gonna take a while since I am doing it on the behalf of the company

Finally got the CLA is signed, could I get eyes on this again? 🙏

/gcbrun

Thank you for your PR, and congrats on your first contribution! 🎉


Configu Hacktoberfest 2023

Configu is thrilled to be part of Hacktoberfest 2023 ❤

Hello contributors 👋👋👋
As enthusiastic supporters of the open-source ecosystem, we encourage developers to contribute to open-source projects, especially during the open-source celebration month, Hacktoberfest!
To help you get started, we have curated a list of issues suitable for open-source contributors.
By contributing, you also stand a chance to win exclusive Hacktoberfest swag.
Prizes 🏆
Code and Non-Code (documentation, examples, etc.) Issues:

Contributors making one valid pull request will receive Configu Socks.
Contributors making two or more valid pull requests will secure a Configu LIMITED-EDITION Hacktoberfest T-shirt.

Support 🆘
Encountered a roadblock? We've got your back. Join our Discord server, and our team will assist you.
Rules 📜

This activity pertains to all issues in configu/configu and configu/docs.
Only the person assigned by Configu's Team will be considered a valid contributor.
Feel free to open new issues. However, they must be approved by a Configu Team member to be considered valid.
Contributions made from October 1, 2023, to October 31, 2023, in any time zone, are valid.
Participants can receive only one swag item. Stacking of SWAG is not permitted.
SWAG quantities are limited.
Swag will be shipped between 30-180 days post-Hacktoberfest, i.e., after November 1, 2023.
Inactivity for 3 days may result in re-assignment to another community member.
Not all contributions will be merged. Contributions should adhere to our contribution guidelines to be considered for merging. However, we will give the PR hacktoberfest-accepted label to count it as a contribution.

Let's have a meaningful Hacktoberfest!

no issues are coming under the hacktoberfest tag

Hacktoberfest 2023 - Claim Your Prizes and Recognition! 🎉
Thank you to every contributor who participated in Hacktoberfest 2023 with Configu! Your efforts have greatly enriched our community and project. 🌟
To ensure you receive the well-deserved recognition and rewards, we need some details from you. We'll verify your contributions against our open-source repository and confirm your details through email verification.
🔗 Please fill out this form: Get Hacktoberfest swag form.
In addition to the prizes, we're excited to celebrate your contributions on our social media platforms. If you're interested in being featured, please provide the necessary details in the form.
Prizes Recap 🏆:
One Valid Pull Request: Configu Socks 🧦
Two or More Valid Pull Requests: Configu LIMITED-EDITION Hacktoberfest T-Shirt 👕

Your participation has been invaluable, and we can't wait to send out your rewards. Let's continue to build and grow together!

Hacktoberfest 2023 - Claim Your Prizes and Recognition! 🎉
Thank you to every contributor who participated in Hacktoberfest 2023 with Configu! Your efforts have greatly enriched our community and project. 🌟
To ensure you receive the well-deserved recognition and rewards, we need some details from you. We'll verify your contributions against our open-source repository and confirm your details through email verification.
🔗 Please fill out this form: Get Hacktoberfest swag form.
In addition to the prizes, we're excited to celebrate your contributions on our social media platforms. If you're interested in being featured, please provide the necessary details in the form.
Prizes Recap 🏆:
One Valid Pull Request: Configu Socks 🧦 Two or More Valid Pull Requests: Configu LIMITED-EDITION Hacktoberfest T-Shirt 👕

Your participation has been invaluable, and we can't wait to send out your rewards. Let's continue to build and grow together!

Hey @pelegpor, I see the form is not accepting responses now - "Submissions for this form are now closed".
Can you help with this?

Hacktoberfest 2023 - Claim Your Prizes and Recognition! 🎉
Thank you to every contributor who participated in Hacktoberfest 2023 with Configu! Your efforts have greatly enriched our community and project. 🌟
To ensure you receive the well-deserved recognition and rewards, we need some details from you. We'll verify your contributions against our open-source repository and confirm your details through email verification.
🔗 Please fill out this form: Get Hacktoberfest swag form.
In addition to the prizes, we're excited to celebrate your contributions on our social media platforms. If you're interested in being featured, please provide the necessary details in the form.
Prizes Recap 🏆:
One Valid Pull Request: Configu Socks 🧦 Two or More Valid Pull Requests: Configu LIMITED-EDITION Hacktoberfest T-Shirt 👕

Your participation has been invaluable, and we can't wait to send out your rewards. Let's continue to build and grow together!

Hey @pelegpor, I see the form is not accepting responses now - "Submissions for this form are now closed". Can you help with this?

@ArpitPandey29 Thank you for bringing this to our attention! We've resolved the issue, and the form is now open for responses again. Your vigilance is greatly appreciated!

Thank you to each and every one of you for a delightful Hacktoberfest 2023! Your contributions have helped introduce long-awaited, exciting features and have propelled Configu a huge step forward. A special thanks to everyone involved. We hope you liked the swag and had as much fun contributing as we had hosting. Until next time, happy coding!


fix: commented code is also considered in validation tests

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #15134

Description
As per the discussion on the issue this PR closes, the regular expressions were supposed to be used. However, the regex approach seems unreliable as no regex is capable of adapting itself to user's linting habits. So I've included external module called strip-comments that takes care of removing javascript comments. The stripped code is then sent to the validation.

@adityaparab Thanks for the PR but we cannot strip out comments as some challenges require checking on code in comments.
Happy Coding


NO REVIEW REQUESTED Geode 6637

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

FYI you can make a draft PR if you don't want others to review it.

I wanted it to run all the checks though…it didn’t seem to kick them off when I did a draft?

On Jun 28, 2019, at 11:16 AM, Aaron Lindsey<EMAIL_ADDRESS>wrote:
FYI you can make a draft PR if you don't want others to review it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/apache/geode/pull/3757?email_source=notifications&email_token=AAH7Y3E5WGXBURLGSV2NVK3P4YTMZA5CNFSM4H4GHC3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2LQPQ#issuecomment-506771518, or mute the thread https://github.com/notifications/unsubscribe-auth/AAH7Y3BTGED6C4TPRI3RSADP4YTMZANCNFSM4H4GHC3A.

I wanted it to run all the checks though…it didn’t seem to kick them off when I did a draft?

Draft PRs are supposed to kick off the checks. Sometimes you have to make an empty commit to trigger the checks. This can happen even for regular PRs.


Consider filling message attribute of <failure> element in junit report

An existing sonar rust plugin does not accept junit reports without message attribute filled. So until bug is fixed on sonar rust side, maybe it is possible to fill message attribute on nextest side. Possibly related PR with related work https://github.com/nextest-rs/nextest/pull/313.

Sounds reasonable. Would you like to contribute a PR to achieve that?

Thanks a lot you've taken a look at the issue. I've already dived into https://github.com/nextest-rs/nextest/blob/main/nextest-runner/src/reporter/aggregator.rs and it seems to me that proper extraction of message and backtrace (if present) separately is not currently implement and will require quite a bit of rework how test output is parsed. I might be wrong with estimation that this is non-trivial change. If you feel ready to implement it I'm not against, but in other case it's probably better to discuss in advance what kind of change is required to implement filling message.

I think we can just use the first line of the description returned here as the message: https://github.com/nextest-rs/nextest/blob/b3f8e565d6f9f06df15267432251ace40a717a60/nextest-runner/src/reporter/aggregator.rs#L273-L276
If it isn't present, something generic like "test failed" would be okay.

Going to mark this as "help wanted" and low-urgency since it looks like sonar has been fixed.


EASI-3236: skip_tests feature for manual deployment

EASI-3236
Changes and Description

Introduce skip_tests option for manual deployment

How to test this change

PR Author Review Checklist

[ ] Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
[ ] Added or updated tests for backend resolvers or other functions as needed.
[ ] Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
[ ] Updated the Postman Collection if necessary.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
Always make comments, even if it's minor, or if you don't understand why something was done.

Manual deployment has been successful skipping tests and not skipping tests.


Callable instances don't complete in the argument list

(from https://github.com/dart-lang/sdk/issues/43919#issuecomment-813027803)
Related to this I tried to get around this lack of autocomplete by instead using callable classes, which helps somewhat if you are OK with users having to type '.call' to get autocompletion for your api:
class CallableCreate{
  int call(int a){
    return a + 10;
  }
}
CallableCreate create = CallableCreate();

int create2({required int a}) => a + 1;

// Using .call makes nice autocompletion
var x = create.call(10);

// There is no help at all however when I directly call the class :(
var y = create(10);

However if you do not start typing .call on the callable class but instead start to directly call it, you get no autocompletion help. If this is also an oversight I am happy to open a new issue for it if you would like? Or perhaps it fits nicely into this issue already.

https://dart-review.googlesource.com/c/sdk/+/242283

Hello, the fix https://dart-review.googlesource.com/c/sdk/+/242283 seems to be in review since more than a year

With https://github.com/dart-lang/sdk/issues/43919 fixed, we do get suggestions for named arguments.

However we don't get anything for positional parameters, e.g. when we explicitly invoke .call() we get .call(a) inserted.
It looks that there were concerns about additional suggestion that implicitly invoked a callable object.
So, an alternative could be to have a suggestion with positional arguments, if the target is an invocable object.
But not if it is normal method - remove it, and re-complete.
@bwilkerson will this be acceptable? My impression that invoking callable objects is rare, and we probably don't get much hit for MRR. OTOH, if it is rare, maybe it is not worth implementing.

So, an alternative could be to have a suggestion with positional arguments, if the target is an invocable object.
But not if it is normal method - remove it, and re-complete.
will this be acceptable?

I'm not sure I understand the proposal, so I can't answer that question.

My impression that invoking callable objects is rare ...

That's my impression too.

... and we probably don't get much hit for MRR.

If we're currently not producing any suggestions in those locations, then the MRR can only stay the same or get better.

OTOH, if it is rare, maybe it is not worth implementing.

I wouldn't say that, but I do think that we should give lower priority to tasks that will have a lower net benefit across all users than we do for tasks that will have a higher net benefit.

We do have suggestions, see

I propose adding a, b to the top, with linked navigation just like completing a method foo would insert foo(a, b). Here we already have foo(), so insert only argument stubs. Only when the argument list is still empty.

I'm not sure how I feel about it, honestly.
I do think there might be some value in giving users a template to fill out for an invocation (though signature help is arguably better), and maybe wanting to add the template after typing the parens is a common enough use case to make it valuable. I wonder, though, whether it might be better to propose the invocation template when completing foo.
I also have to wonder how we're going to measure the value of such a completion. It seems unlikely that we're going to find too many places where the argument list consists of a list of variable names where each variable name matches the parameter name of the method, so this is rarely going to match the actual text after the code is complete.
What do you see as the value proposition for this?

We will not able to measure this.
Not without actively observing users.
Proposing the invocation template as in this CL?
I don't see much value here anyway, it is rare case.

Proposing the invocation template as in this CL?

Yes, though I don't disagree with my earlier concerns and would want both the performance and the MMR impact to be measured.

I did some measurements, count the number of FunctionExpressionInvocation when the node.function.staticType is InterfaceType.
analyzer:
[countFunctionExpressionInvocation: 18]
[countMethodInvocation: 117098]
[countInstanceCreationExpression: 9454]

flutter:
[countFunctionExpressionInvocation: 0]
[countMethodInvocation: 390090]
[countInstanceCreationExpression: 225429]

So, it looks to me that the situation described by this issue almost does not exist.
So, fixing it will not add any value.
So, I propose closing it as WillNotFix.

The evidence you provided suggests that this isn't a style used very often by the Dart and Flutter teams, but (a) we have no evidence that those teams are representative of our larger user base and (b) we have evidence that this bug is impacting at least one user. While it's reasonable to question the priority of this issue, I don't believe that it's reasonable to say that we won't fix this bug.

You previously indicated that we need to measure MMR impact, what code base do you propose using for this?
I want also say that I find it hard to argue with "we have no evidence that XYZ are representative". Do you have an idea of a possible evidence for a set of code bases that will let us say that we will consider them representative?

If I can add up about the measurement, I would argue that people not using it might be related to this issue.
I cannot speak for others, but I personally don't use this feature BECAUSE the autocomplete does not work and, like a lot of developers, I am lazy. I am also thinking about people working with me and don't want to use a feature that might make their work less easy (I agree the word is a bit strong).
Statistics are useful but context is very important.

I think being lazy is a perfect reason :-)
I tried to use callable classes myself on couple occasions, but it did not stick. If I need to pass a function, I can use a method tear-off. If something accepts an interface, invoke one of its methods. It feels that by doing myClass() we omit a useful signal - the name of the operation, the name of the method.
I also buy the argument that it is not used because it is inconvenient only to some extent - there are people who use unsophisticated editors, or less lazy. And if it were useful, we would see more uses.
That said, I agree with @bwilkerson that the analyzer and flutter alone are not representative. And if there are open source projects that are good in some sense: continue to have updates, successfully evolve, large enough; I'd like to include them into the set to measure metrics.

OK, apparently my involvement is not useful here.
I will let someone else drive this.


[#93] make on_conn_error and on_error hooks unique

The functions htp_hook_error_() is only called for request-ish errors
while htp_hook_connection_error_() is only called for connection-ish
errors.
This mainly applies to the following functions:
htp__connection_readcb_ :
if EVHTP_RES_DATA_TOO_LONG is the connection request return value,
both hook_error_() and hook_connection_error() are called.
if there is a parser error, hook_connection_error_() is called
with the error type of EVHTP_RES_PARSER_ERROR
evbuffer_drain is now called before the connection request status
switch/case statement, and EVHTP_RES_PAUSE is now a case (moved)
htp__connection_eventcb_
!!!!! PLEASE MAKE NOTE OF THIS CHANGE !!!!!
this function now calls htp__hook_connection_error_() but no
longer calls htp__hook_request_error_() to match the naming
scheme.
prior to this, both request_error and connection_error was called
within this function.

Just did a test of the connection timeouts and found a segfault.
set error handlers like so:
static void connection_error_callback(evhtp_connection_t *conn, evhtp_error_flags type, void *arg)
{
    log("unhandled connection error of type: 0x%02x", type);
}

static void request_error_callback(evhtp_request_t *req, evhtp_error_flags type, void *arg)
{
    log("unhandled request error of type: 0x%02x", type);
}

evhtp_res pre_accept_callback(evhtp_connection_t *conn, void *arg)
{
    evhtp_connection_set_hook(conn, evhtp_hook_on_conn_error, (void*) &connection_error_callback,  NULL);
    evhtp_connection_set_hook(conn, evhtp_hook_on_error,      (void*) &request_error_callback,     NULL);
    return EVHTP_RES_OK;
}

int server_init()
{
    struct timeval connection_timeout;
    connection_timeout.tv_sec = 1;
    connection_timeout.tv_usec = 0;
    evhtp_set_timeouts(server->evhtp, &connection_timeout, &connection_timeout);
    ...
}

I then connected to the server with nc and no http request:
$ nc localhost 8080

Server Output
$ ./evhtp_to
connection_error_callback:159   unhandled connection error of type: 0x41
Segmentation fault: 11

Debugging with lldb
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x10)
    frame #0: 0x000000010003f276 evhtp_to `htp__hook_request_error_(req=0x0000000000000000, err='A') at evhtp.c:776
   773 	static inline void
   774 	htp__hook_request_error_(struct evhtp_request * req, evhtp_error_flags err)
   775 	{
-> 776 	    if (HOOK_AVAIL(req, on_error)) {
   777 	        (req->rh_err)(req, err, req->rh_err_arg);
   778 	    }
   779 	}
Target 0: (evhtp_to) stopped.
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x10)
  * frame #0: 0x000000010003f276 evhtp_to `htp__hook_request_error_(req=0x0000000000000000, err='A') at evhtp.c:776
    frame #1: 0x000000010003db19 evhtp_to `htp__connection_eventcb_(bev=0x00000001006004a0, events=65, arg=0x00000001006001e0) at evhtp.c:2569
    frame #2: 0x00000001003d011a libevent_core-2.1.6.dylib`bufferevent_run_deferred_callbacks_locked + 266
    frame #3: 0x00000001003dd0c1 libevent_core-2.1.6.dylib`event_process_active_single_queue + 1009
    frame #4: 0x00000001003d91af libevent_core-2.1.6.dylib`event_base_loop + 1119
    frame #5: 0x00000001000035d1 evhtp_to`main(argc=1, argv=0x00007fff5fbff9f0) at main.c:39
    frame #6: 0x00007fffbdd6c235 libdyld.dylib`start + 1
(lldb) up 1
frame #1: 0x000000010003db19 evhtp_to`htp__connection_eventcb_(bev=0x00000001006004a0, events=65, arg=0x00000001006001e0) at evhtp.c:2569
   2566	    HTP_FLAG_OFF(c, EVHTP_CONN_FLAG_CONNECTED);
   2567
   2568	    htp__hook_connection_error_(c, events);
-> 2569	    htp__hook_request_error_(c->request, events);
   2570
   2571	    if (c->flags & EVHTP_CONN_FLAG_PAUSED)
   2572	    {
(lldb)

I'm thinking about removing the request error callback, as it was not being used before, and it's even confusing me, as request can free connection, and vice versa.
So I think it would be prudent to have an event callback, and a generic error callback. You know, like it was before, but without having the option for a request error callback.

Basically it would be nice to be able to differentiate between timeouts, parsing errors, client disconnects, etc so they can be logged. If that's achievable with one error callback go for it.

Basically it would be nice to be able to differentiate between timeouts, parsing
errors, client disconnects, etc so they can be logged. If that's achievable with one error callback go for it.

I'm on it. Thanks for the feedback!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Read and write structs

~This series of commits moves all database read and write operations into DBReader and DBWriter instance methods (see ser.rs).~
Move all database struct reads and writes into ser.rs. Replace existing read and write functions with read32, read64, write32 and write64, all of which take an endianness parameter, and a Read or Write implementation.

I understood that LFS / large file size, introduced 8 byte offsets for certain fields (please confirm). If this is the case, the converting a u32 into a u64 introduces padding after the value if the encoding is LE, but before the value if the encoding is BE.
I take the point about Format, but it seemed better than FileSize, as filesize means something else already. Please suggest an alternative ... OffsetWidth, OffsetType?

I understood that LFS / large file size, introduced 8 byte offsets for certain fields (please confirm). If this is the case, then converting a u32 into a u64 introduces padding after the value if the encoding is LE, but before the value if the encoding is BE.

If a C struct presents
    u32 foo;
    u64 bar;

Then the C compiler inserts padding before the u64, to ensure that the u64 is naturally aligned.  This is not related to BE or LE.  This is a C ABI detail.

I take the point about Format, but it seemed better than FileSize, as filesize means something else already. Please suggest an alternative ... OffsetWidth, OffsetType?

The POSIX/Unix extensions for O_LARGEFILE and 64-bit offsets are known as LFS.  https://en.wikipedia.org/wiki/Large-file_support   LFS is the normal nomenclature in the filesystem / database realm.

Further info: https://www.geeksforgeeks.org/structure-member-alignment-padding-and-data-packing/

I'm happy with the direction of the changes; just cannot remove the hard-won padding and fixme-comment along the way.
Will review these updated commits by the end of the weekend.

Thanks @jgarzik.
It's not really clear what that fixme is referring to. Is it the next_block and avail_next_block header fields? If it's as simple as making them u32 for 32bit aligned, we can fix it in this PR.
There was a discrepancy in bucket.rs (read/write), so there's at least one other bug fixed :+1:

High level comments on the problem:

endianness is easy to pass into read/write functions
LFS has impact at the struct level:  conditional on each struct, an LFS field (32bit -> 64bit conditionally) might need struct padding.  Case A:  a struct is well thought out, and fields changing 32bit->64bit do not require padding.  Case B: a struct is poorly thought out, and fields changing 32->64 bit do require padding.  Padding is thus not a detail that can be "pushed down" to the write_offset() level of helper function.

Still on my plate to review this weekend.  Just adding some thoughts.

We only need to pad when trying to write an 64bit (or a nested struct) on a non-64bit (or non-aligned) boundary. It's deterministic. I removed the read and write offset functions to keep the struct layout logic local to serialization. Meaning it's easy to count the bytes written and more easily see where padding should go. There's only explicit padding at the individual struct serializing sites..
The only alternative I can think of is to use  repr(C)  structs. However, this would require 2 layouts per struct, one for 32bit, one for 64. And 4 functions to fill each of those structs, one per endian per read/write. Additionally, it would require unsafe code to convert those structs to/from &[u8] in order to read/write them. I'm sure this could all be achieved with macros, but prefer to keep things simple.

What do you think about something closer to your first version, with the addition of .read_padding() and .write_padding() functions?
These condense down to no-ops when LFS alignment is not needed, while still pushing all conditionals down into the helpers, as with your 1st version.
WDYT?

I think it's better this way. It's explicit and easier to reason. I thought about automatically aligning in the DBReader, DBWriter but since embedded structs need to be aligned, we can't tell the difference between a u32 member, or the u32 that is the first member of a struct.
The holy grail I guess is a proc macro, so we can decorate the struct and have the macro create the serialization functions, but I think that's beyond the scope of this brief.
What I was really intending was to simplify those nested if is_le, if is_lfs  and to add a level of type safety. To be fair, the existing w32, w64, and woff_t were pretty close already, except they worked on vec[] rather than impl Write :)

@drystone In the interest of making progress, merged this PR, with the following thoughts:

Did you test with a local gdbm database?   Read support should work before + after your change, if no regressions.
I recommend having, at least, 1 32-bit and 1 64-bit GDBM database locally for testing and verification
Header seems likely to need some struct offset double-checking, LFS vs !LFS
My gut instinct is that we'll want to move all match-alignment statements into helper functions.  But that's no big deal, and can be done later.

Thanks @jgarzik!

Did you test with a local gdbm database? 64-bit LE Read support should work before + after your change, if no regressions.

That functionality is already in the testsuite.

I recommend having, at least, 1 32-bit and 1 64-bit GDBM database locally for testing and verification
Header seems likely to need some struct offset double-checking, LFS vs !LFS

Yes, and there's no provision for testing 32bit. That needs addressing.

My gut instinct is that we'll want to move all match-alignment statements into helper functions. But that's no big deal, and can be done later.

Agreed. We can look at this again.


[BUG] V1.1.1 System.Reactive not found import errors

when I tried to use the latest release (V1.1.1.) I get System.Reactive not found errors.

Steps to reproduce:

Create a new empty unity project
Import the Socket IO package through git URL add in the package manager.
System.Reactive not found errors pop up after import.

Tested on:
Unity 2021.3.3 LTS
Unity 2021.2.5

I've got this to work by importing in a compiled System.Reactive.dll (attached zip).
Alternatively, you can compile the source from nuget.

i updated the git source and added System.Reactive.dll,
all needed libs now under the folder SocketIOUnity/libs/*


Tests for filter feature

#15 #39

Codecov Report
Base: 63.75% // Head: 66.28% // Increases project coverage by +2.53% :tada:

Coverage data is based on head (4323360) compared to base (ea6d1f3).
Patch coverage: 91.52% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage     63.75%   66.28%   +2.53%
- Complexity      483      525      +42
============================================
  Files            86       86
  Lines          1647     1661      +14
  Branches        178      183       +5
============================================
+ Hits           1050     1101      +51
+ Misses          539      508      -31
+ Partials         58       52       -6

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...va/seedu/address/logic/commands/FilterCommand.java
91.66% <83.33%> (+14.39%)
:arrow_up:

...edu/address/logic/commands/FilterClearCommand.java
89.28% <84.61%> (+46.42%)
:arrow_up:

...address/logic/commands/FilterCommandPredicate.java
80.95% <85.71%> (+25.39%)
:arrow_up:

...eedu/address/logic/parser/FilterCommandParser.java
91.89% <94.44%> (+16.89%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
94.00% <100.00%> (+6.00%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
90.12% <100.00%> (+4.93%)
:arrow_up:

...ss/model/person/NameContainsKeywordsPredicate.java
100.00% <100.00%> (ø)

...address/model/person/TagMatchesQueryPredicate.java
100.00% <100.00%> (+100.00%)
:arrow_up:

... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Software Numerical Integration Routine

We need to be able to report total air volume to the GUI computer. Sensors produce volumetric flow rate data. Thus, we need a software integrator to take the volumetric flow and integrate it w.r.t. time to get total volume.

TODO(@jkff) Link this to the GUI issues about displaying TV.

@jlebar saw some comments from you on slack implying we already had TV calculation implemented? Does this effectively close this issue?

No.  It's not checked in, and what I have in my tree doesn't work well
enough for Alpha.
On Sat, May 2, 2020, 6:57 PM Martin Shetty<EMAIL_ADDRESS>wrote:

@jlebar https://github.com/jlebar saw some comments from you on slack
implying we already had TV calculation implemented? Does this effectively
close this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/RespiraWorks/VentilatorSoftware/issues/169#issuecomment-623041698,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABEZBY2R76LEMBSC66I243RPTFRXANCNFSM4MRAV4DQ
.

This issue blocks #10 and #229

Forward-duping to #229.


(bug) DEPLOY_ID is not working as expected

Deploy ID is obtained using - $(( ($(date +%s) + 500) % 1000000 )) currently.
Deploy ID should be always incrementing
Based on the logic - it doesn't. It'd simply get outdated and go back in time after every 1000000 ms (16 minutes)

@bbbneo333 1000000 is in second and not ms so it should reset in 11.5 days
last deployment failed I reported on 18th july then on 29th july.


Adding AttrToMarker function to remove duplicated code [attr-to-marker-dev]

As I was about to add this functionality to yet another code it occurred to me that I should write a function to do this...

PR
Author
Editor
Reviewers
Assignment
Approval
Merge

#1364
@mlstowell
@tzanio
@cjvogl + @psocratis
03/19/20
⌛due 04/02/20
⌛due 04/09/20

Looks like Travis stalled on a few tests... @tzanio or @v-dobrev, can you restart (or indicate how I would restart them)?

The Mac test on Travis have been really slow... I restarted them

@cjvogl, there are three sample runs in maxwell.cpp which use the -dbcs flag.  I suppose we could compare results between this branch and master.  I didn't actually do this for maxwell but I did verify volta and tesla.

Merged in next for testing...


V2022.03.xx (next major release)

if anyone are involved in this just simply toggling subscribe off this off thanks

ik, just want to write a doc
which idk how to do...


merge release 1.10.3

mostly just validating my test/coverage improvements with Travis + Appveyor

cc #415, #419. wanted to get coverage back up and running (#403) and make sure there weren't more terrifying gaps before releasing.
Fix from 2bb0163 seems to be the primary gap in getExports.js, so should be good to deploy once these all pass.

Changes Unknown when pulling f314e5c422847039e988d623c1264efdc01c52b0 on release into ** on master**.

published to next tag on npm


[bug] run yarn install in vue, then run yarn dev, Will report an error: Could not resolve "react"

Link to minimal reproducible example
https://docs.walletconnect.com/2.0/web3modal/v3/vue/about
Summary
run yarn install in vue, then run yarn dev, Will report an error: Could not resolve "react"
List of related npm package versions
yarn install

yarn dev

Hi, if you're using yarn could you try adding this to the package.json file?
"optionalDependencies": {
    "react": ">=17",
    "react-dom": ">=17"
  },

After adding optionalDependencies in package.json, it can run normally.
	"optionalDependencies": {
		"react": ">=17",
		"react-dom": ">=17",
		"typescript": ">=5.0.4"
	}

After adding optionalDependencies in package.json, it can run normally.
	"optionalDependencies": {
		"react": ">=17",
		"react-dom": ">=17",
		"typescript": ">=5.0.4"
	}

Are you use vue2 ?

we don't recommend using optionalDependencies anymore, and this should be fixed without any workaround needed in the latest version.


documentation: document and run through site setup process

RENCI folks have seen this and provided no feedback :) we will assume this is fine


Switching dock and/or display causes fancy zones to reset

Microsoft PowerToys version
0.66.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones, FancyZones Editor
Steps to reproduce

Use a custom layout
Un-dock laptop
Dock laptop

✔ Expected Behavior
That the custom layout would still be used
❌ Actual Behavior
It's reset to installation defaults I believe. So, the priority layout.
Other Software
It happens with any application, but I can mention that this was also the behavior of previous versions.

/dup https://github.com/microsoft/PowerToys/issues/16370


Django 2.1

Tests fail with
  File "/home/abuild/rpmbuild/BUILD/django-compat-1.0.15/compat/tests/urls.py", line 5, in <module>
    url(r'^accounts/logout/$', views.logout, name='logout'),
AttributeError: module 'django.contrib.auth.views' has no attribute 'logout'

Fairly simple to fix https://stackoverflow.com/questions/47065438/attributeerror-module-django-contrib-auth-views-has-no-attribute

Also running the tests on Django 2.2 results in
[  217s] ERRORS:
[  217s] ?: (admin.E404) 'django.contrib.messages.context_processors.messages' must be enabled in DjangoTemplates (TEMPLATES) in order to use the admin application.
[  217s] ?: (admin.E406) 'django.contrib.messages' must be in INSTALLED_APPS in order to use the admin application.
[  217s] ?: (admin.E407) 'django.contrib.sessions' must be in INSTALLED_APPS in order to use the admin application.
[  217s] ?: (admin.E408) 'django.contrib.auth.middleware.AuthenticationMiddleware' must be in MIDDLEWARE in order to use the admin application.
[  217s] ?: (admin.E409) 'django.contrib.messages.middleware.MessageMiddleware' must be in MIDDLEWARE in order to use the admin application.

fwiw, https://github.com/pakal/django-compat-patcher/issues/2 was fixed, so it is probably possible to use that patcher to fix this codebase to make it work with Django 2 ;-)


Testing: avoid hard-coding random seeds

Hard-coding common random seeds in a test suite is poor practice, because we end up testing the same inputs over and over (particularly in parametrized tests). JAX's test runners have self.rng() for this purpose; we should use this everywhere.
Making this change revealed a few tests that are very fragile – some I was able to fix by adjusting test tolerances, but some are irredeemable, and so I went back to a fixed random seed with an explicit TODO to address the issue (mostly as an indicator of existing problems in case someone finds functions behaving unexpectedly & digs into the code).

Pulling-in pre-review for more test coverage.


remove PureDeepRenderMixin

Closes #105. Relates to #102.
Also: let me know if you want me to remove the other commit with changes to build.sh. Snuck in there because I couldn't run the build script tasks without it.

Thanks for this.


Refragmenting table

This PR introduces a table refragmentation functionality, which allows to avoid doing an import of the same table just for a new fragment size.
It is relatively cheaper to refragment a table (as opposed to re-inserting it), since we don't have to modify the physical layout/location of the data in memory. The price we pay for refragmenting is recalculating the metadata (basically fragment's offset, row_count + small materialized aggregates per fragment) in order to change the logical view of the table.
Addresses #572 .

It is not enough to simply refragment a table inside the storage. Assigning the new fragment size means you change data assigned to already used chunk IDs. This means all data cached in buffer managers becomes irrelevant but you would still use it in the following queries.
There is other data that is referenced by chunk ID and can be cached, e. g. chunk stats.
So, refragmenting needs additional cleanups but it's not clear how to do it all atomically.
Did you consider creating a new table as a result of refragmentation? Same price, no conflicts.

@ienkovich Do we update anything above the storage layer when we append to a table and the last fragment wasn't full and now it starts to span arrow's chunks boundaries (and so we update its metadata)?  https://github.com/intel-ai/hdk/blob/ad924b50a2e909a98efba9a6363f9b5415742bf6/omniscidb/ArrowStorage/ArrowStorage.cpp#L876

@ienkovich Do we update anything above the storage layer when we append to a table and the last fragment wasn't full and now it starts to span arrow's chunks boundaries (and so we update its metadata)?

Appended data was originally supported in buffer managers. The size of the chunk grows and buffer managers ask a storage for new data. If you reduce the size of a chunk then they would simply use the old data.

It would be nice to have a googletest / c++ test for this - also I am wondering what happens if you enable lazy dictionary materialization then re-fragment. Could we add something to ArrowStorageTest.cpp?


A Scan has a failure.. Please approve to proceed

Approval required for following Workflow to proceed.

WorkflowName
Workflow#
BranchName
TriggerEvent
LastCommitUser

build-test
78
refs/heads/main
push
Yog4Prog

Issue Details
Found an Issue while performing SCA Scan
:point_right: You are required to Approve (or) Reject the issue
Approve or Reject by commenting in the below section with any of the following keywords
:green_book:  Approved Keys: approved approve lgtm goahead proceed yes
:closed_book: Reject Keys: denied deny reject rejected no abort cancel exit
:point_right: Note: If left uncommented the issue will be closed after the timeout period and the workflow will be marked unsuccessful.

Approval waiting period elapsed. Approval request is automatically closed and workflow status is marked to Failed.


蓝牙后台的一个问题

我阅读了 iOS 的后台模式
和 蓝牙后台模式。但是依旧有以下的问题。
我们现在有一款蓝牙设备的App，应用可以在后台进行蓝牙操作连接。 我们用状态保存和恢复功能来保持App在后台扫描设备。一般情况下都是正常的。直到用户在后台关闭蓝牙。这个时候后台时间十秒内没有连接上设备。App处于挂起状态，这个时候如果其他App向系统申请内存消耗的时候，系统会把App终止。在这种情况下蓝牙再次关闭开启无法激活App并进行正常的操作。
这貌似和 Bluetooth background 描述不一致，当应用在后台被终止时，就凉了。
Performing Long-Term Actions in the Background
Some apps may need to use the Core Bluetooth framework to perform long-term actions in the background. As an example, imagine you are developing a home security app for an iOS device that communicates with a door lock (equipped with Bluetooth low energy technology). The app and the lock interact to automatically lock the door when the user leaves home and unlock the door when the user returns—all while the app is in the background. When the user leaves home, the iOS device may eventually become out of range of the lock, causing the connection to the lock to be lost. At this point, the app can simply call the connectPeripheral:options: method of the CBCentralManager class, and because connection requests do not time out, the iOS device will reconnect when the user returns home.

Now imagine that the user is away from home for a few days.  For apps like these, it is critical to be able to continue using Core Bluetooth to perform long-term actions, such as monitoring active and pending connections.

系统回收能够理解，关键在于蓝牙重新开启或者连接没有重新激活应用。并且在被系统回收时也收不到Memory Warning 和 Terminat 的消息。这样如果用来实现Apple 文档中 家居开关锁的话是有问题的，程序可能已经在后台被Kill，但用户却无法知道。

毕竟苹果也是为了省电, 要是真的靠蓝牙能实现无限制的后台, 那隐患也不小. 都做成流氓软件了

Bluetooth Background 文档中描述的
https://developer.apple.com/library/content/documentation/NetworkingInternetWeb/Conceptual/CoreBluetooth_concepts/CoreBluetoothBackgroundProcessingForIOSApps/PerformingTasksWhileYourAppIsInTheBackground.html#//apple_ref/doc/uid/TP40013257-CH7-SW1
如果蓝牙不能唤醒App，那么IOT App就没有太大的意义了，每次必须要通过前台唤醒操作的话。

你发这玩应做蓝牙开发的基本都看过

嗯， 但还是感谢回答问题


How to Dispose TorrentManager

I did unregister Torrent Manager
but don't release TorrentManager in memory
how to dispose?

A torrent manager doesn't have anything to dispose. Once it's stopped/unregistered, it should go away.


Roll engine 7f753f8f528a..3493dcfbaec5 (1 commits)

https://github.com/flutter/engine/compare/7f753f8f528a...3493dcfbaec5
git log 7f753f8f528a1c92cc4f23957694623ad45104eb..3493dcfbaec516effcde49e3fae68a33427045da --no-merges --oneline
3493dcfba Rename tightWidth to longestLine (flutter/engine#8706)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4667888349741056

Commit queue failed; closing this roll.


Tags in non-emote chat?

I can't find a way to have tags actually show up in chat. Even custom ones assigned to particular player names, which show up just fine in the nameplates (apparently with the computed ones, which is very nice!), won't show up in chat. The exception is when one of the tagged players is involved in a vanilla emote, as either the target or the performer. Custom emotes and normal messages have no option to display tags.
Is there any plan for allowing tags to be added in custom emotes, the result of <t>, <f>, etc placeholders, and/or normal chat messages?

Update: the target bar(s) also don't show tags - target, focus target, target-of-target. Any plans for those too/either?

Interestingly, the placeholders seem to be working now when they weren't earlier, so... ignore that part, I guess. The rest still stands though.

Would like to add tags to other bits of UI where player names appear, will look into that!
Custom tags should always show in chat, role/job tags will only show when the player is in your immediate vicinity. Do let me know if that isn't working correctly.

I haven't played since the patch yet (the queues are still murderously long...) but when I made the report, what I was doing was this:

All players get a computed tag with their class/job abbreviation and role iron, in their nameplate, after their name (works perfectly)
Specific players also get a static text tag, on nameplate and in chat, replacing their name (works perfectly in nameplates, as the result of a <t>/<f>/etc placeholder, and when the performer of a vanilla emote - does not work on custom (/em) emotes or on normal chat speech)
As mentioned, no effect on target bar, focus target bar, etc in the game UI

To reproduce, get a friend, set a custom static tag for them, assign it to replace their name in chat, and have them do a vanilla emote, a custom emote, and a normal speech message. Unless I did something wrong with my config, only the first one should show their tag in place of their name.
If you've since updated the plugin then this may be out of date, but like I said, I haven't played since the patch yet.

I followed your steps and was able to see the tag correctly each time.
Try grabbing the latest version if you haven't already and then follow these steps:

Disable the plugin.
Back up and delete the config file %APPDATA%/XIVLauncher/pluginConfigs/PlayerTags.json.
Re-enable the plugin.
Add a new custom tag.
Set it to replace name in chat.
Assign it to someone.
Have them perform a "/say test", "/em test", "/dance".
Observe the tag shown in chat each time.

If it persists, please send your config here for me to look at.

Finally got a chance to test it, and I can confirm that FC chat at least doesn't work. I'm hesitant to post my config because some of the tags are private but I can back it up and then strip the sensitive tags out and post that.

Update: I just realised, could the Simple Tweaks feature to recolour names in chat be affecting this? I don't know how either is implemented, but if they both edit the same thing...

It's possible. It might play nicer depending on your plugin load order. I just had a test with the Simple Tweaks option you're referring to and observed a similar problem but not the same as you described:

When Player Tags has priority (is loaded first), the changes in both plugins display more or less as expected. The custom tag becomes the name, and simple tweaks colors the custom tag.
When Simple Tweaks has priority, the tags display next to the name instead of replacing it.

Both cases here:

You can force Player Tags to have priority by disabling and re-enabling Simple Tweaks, and vice versa.
If you have anything else modifying your chat then that could be a culprit too.


Position Bubble label on top left corner when hovering

When hovering a non sleeted bubble, the hover text label should show to the top left, (currently it his hidden under the cursor. Makes it's appearance identical in fontsize and position, to the selected label that will stick, if I click the bubble,

Similar to Gapminder World (top left of bubble when hovering india):


Add models

Add models related to

news
urgentfm

see branch models-jasper

Please make sure root/wrapper/meta objects are called Wrapper (for consistency).


New feature of hash value

Hi @lavinjj,
I add a feature to angularjs-gravatardirective, you can add hashed email string directly as an attribute or email. Would you like to hv a try and consider merge them? Thanks.
https://github.com/goodseller/angularjs-gravatardirective/

@lavinjj  I have updated with tests. Please have a look. https://github.com/goodseller/angularjs-gravatardirective
Do I need to add a pull request also?

Yes, please send a pull request and I'll integrate it.


Metadata standards for "labels"

Many of the systems we use support different kinds of metadata. To build up better tooling and improve workflows we should develop some metadata standards that allow us to map between the systems:

WandB
Argo/k8s
fv3net-artifacts/GCS
Logging/big-query

Name
Name
URL encoding date/project/step/tag
labels

Tags
Labels: key/value with limitations (searcheable)

jsonPayload

Groups
annotations (key/value unrestricted)

resource.labels

Config

Summary Metrics

Artifacts

I'm think for any artifact/workflow we will want to know the following

project

experiment

trial/run

dependencies
revision/commit
author
date created
user-facing configuration/yaml

We should develop some some standards for how to map these concepts onto our experiment management systems.

https://docs.google.com/document/d/1lXlFAVTQbQtURCAPRUp8yyrlyojPRldQHPH-o_d5iho/edit?usp=sharing


Documentation: Improve page about the HTTP endpoint/interface

About
Improve documentation page about the HTTP endpoint/interface.
Preview

https://crate--16733.org.readthedocs.build/en/16733/interfaces/http.html

Details

Group concerns about bulk operations (general vs. error handling) together, to improve context, as suggested by @amotl.

Elaborate better about two different kinds of errors that may happen when processing bulk operation requests, and about their behaviour, as suggested by @matriv.

References

https://github.com/crate/crate/issues/16617#issuecomment-2375305018
https://github.com/crate/crate/issues/16683#issuecomment-2376499787

Failure looks related:
======================================================================
ERROR: test_docs (unittest.loader._FailedTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/CrateDB/crate_on_pr/blackbox/test_docs.py", line 442, in load_tests
    docsuite(
  File "/usr/lib/python3.9/doctest.py", line 2508, in DocFileSuite
    suite.addTest(DocFileTest(path, **kw))
  File "/usr/lib/python3.9/doctest.py", line 2440, in DocFileTest
    test = parser.get_doctest(doc, globs, name, path, 0)
  File "/usr/lib/python3.9/doctest.py", line 675, in get_doctest
    return DocTest(self.get_examples(string, name), globs,
  File "/usr/lib/python3.9/doctest.py", line 689, in get_examples
    return [x for x in self.parse(string, name)
  File "/var/lib/jenkins/workspace/CrateDB/crate_on_pr/blackbox/.venv/lib/python3.9/site-packages/zc/customdoctests/__init__.py", line 51, in parse
    r =doctest.DocTestParser.parse(self, string, name)
  File "/usr/lib/python3.9/doctest.py", line 651, in parse
    self._parse_example(m, name, lineno)
  File "/usr/lib/python3.9/doctest.py", line 709, in _parse_example
    self._check_prompt_blank(source_lines, indent, name, lineno)
  File "/usr/lib/python3.9/doctest.py", line 793, in _check_prompt_blank
    raise ValueError('line %r of the docstring for %s '
ValueError: line 470 of the docstring for http.rst lacks blank after    : "    ... -X POST '<IP_ADDRESS>:4200/_sql' -d@- <<- EOF"

A few people already contributed to the improvements on this page. Thanks! Because a few others have also been interested about this, I am humbly asking them to have another look: If anything else comes to mind you would like to see mentioned here, or elaborated upon, a good chance is now to express your feelings and ideas.
/cc @karynzv, @hlcianfagna, @wierdvanderhaar, @zolbatar, @ckurze


[C#] Add ChannelCredentials.SecureSsl property for better codecompletion with ChannelCredentials

Adds ChannelCredentials.Secure. The same as using new SslCredentials().
I want to add this as grpc-dotnet only cares about new SslCredentials() and ChannelCredentials.Secure is much more discoverable via intellisense.
Grpc.Core users can use the new property if they wish. Doc comment mentions that SslCredentials should be used if they want to customize the credentials.
@jtattermusch

The tests are actually failing:
https://source.cloud.google.com/results/invocations/8d7f7447-97c0-48e4-90f3-10f324d2be56/targets/github%2Fgrpc%2Frun_tests%2Fcsharp_windows_dbg_native_default_coreclr%2Fcsharp.Grpc.Core.Tests.ChannelCredentialsTest/tests

The test failures are caused by
https://github.com/grpc/grpc/issues/26522


Specify explicit type parameters for middleware in test/greencat_test.dart

Currently the correct type parameters are inferred from the context.
However, an upcoming Dart 2.0 language change
(https://github.com/dart-lang/sdk/issues/32152) will break the
connection between callable classes and their corresponding function
types, which will prevent type inference from being able to infer
these type parameters anymore.
To prepare for the language change, we need to specify the type
parameters explicitly.

Thank you @stereotype441


Fix linting

Signed-off-by: Andy Goldstein<EMAIL_ADDRESS>

I noticed this ... how did it pass CI????

My only guess is that golint with go 1.16 didn't catch it (I think the PR was before I bumped to 1.17), but 1.17 does?