How to properly close a task module after submit to a bot?

We're experiencing issues related to when submit a task module to a bot.
We're using a React Tabs app. We open a task module using
teams.dialog.url.bot.open(   {     "title": "Edit Your Story",     "url": "our-react-url",     "completionBotId": "our-bot-id",     "size": {         "height": 700,         "width": 600     }   } );
Then, after we save relevant info in our back end, the bot returns
return {   task: {     value: "",     type: "message",   }, } as TaskModuleResponse
which works on iOS and Desktop but displays an extra empty pop-up on Android which is annoying.
How do we properly return a response that just closes a task module? We don't want to reply with an adaptive card or a continuation to another task module.
Thanks.

@jl0zano - Thanks for reporting your issue.
We will check this at our end and will get back to you.

@jl0zano -We have tried with the below code to close the task module-
Are you looking for the same?
 async handleTeamsTaskModuleSubmit(context, taskModuleRequest) {

        await context.sendActivity(MessageFactory.text('handleTeamsTaskModuleSubmit: ' + JSON.stringify(taskModuleRequest.data)));
        return null;
    }

https://github.com/MicrosoftDocs/msteams-docs/assets/93527375/9fe6353c-7dab-479d-b4d1-73887e90ec9e
if your issue is not resolve using above code, please share a short video or screenshots, so that we can investigate further from our end.
Reference sample-https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-task-module/nodejs

@sayali-MSFT Thanks for your response. Returning null worked! It would be ideal to have this in the documentation:
https://learn.microsoft.com/en-us/microsoftteams/platform/task-modules-and-cards/task-modules/task-modules-bots?tabs=nodejs#responds-to-the-tasksubmit-messages
When we were not returning anything the task modules were acting weird on iOS for some reason. Returning null worked.

@jl0zano - Glad to hear that your issue is resolved. We will update the document accordingly.
Could you please share your valuable feedback via Microsoft Teams Developer Feedback link.


Promise utility function (route errors up to UI)

Objective:
To create a centralized utility function that handles asynchronous operations in useEffect hooks across the codebase. This function will ensure consistent error handling and improve code maintainability by routing errors to the UI.
Identified Instances:
The following components and hooks in the codebase involve asynchronous operations within useEffect hooks:

src/pages/NotFound.tsx:

Usage: useEffect with await.
Action: Refactor to use the utility function for error handling.

src/hooks/useImageBackgroundColor.ts:

Usage: useEffect with .then() for fetching image info.
Action: Refactor to integrate with the utility function.

src/components/TickerDetail/TickerDetail.tsx:

Usage: useEffect with .then() for fetching ETF aggregate details.
Action: Modify to utilize the utility function.

src/components/TickerDetail/TickerDetail.TickerVectorTable.tsx:

Usage: useEffect with .then() and Promise.allSettled() for fetching ticker details.
Action: Adjust to incorporate the utility function.

src/hooks/useTickerDetail.ts:

Usage: useEffect with .then() for fetching ticker details.
Action: Refactor to use the utility function for error management.

src/components/TickerDetail/TickerDetail.ETFHolder.tsx:

Usage: useEffect with .then() for fetching ETF holding weight.
Action: Integrate with the utility function for consistent error handling.

Implementation Plan:

Create the Utility Function:

Develop a utility function that wraps asynchronous calls and handles any errors by routing them to the UI, e.g., using a notification system or logging.

Refactor the Codebase:

Replace the existing useEffect hooks in the identified components with the new utility function.
Ensure that all error handling is consistent and centralized.

Test and Validate:

After refactoring, thoroughly test the components to ensure that errors are correctly routed to the UI and that the functionality remains intact.

Example Utility Function:
// utility/promiseHandler.ts
const commonErrorHandler = (error: any): void => {
  console.error('An error occurred:', error);
  // You can also add additional logging or error reporting here
};

export const handlePromise = async <T>(promise: Promise<T>): Promise<T> => {
  try {
    return await promise;
  } catch (error) {
    commonErrorHandler(error);
    return Promise.reject(error);  // Re-throws the error to be handled upstream if necessary
  }
};

// Usage in a useEffect hook
useEffect(() => {
  const fetchData = async () => {
    try {
      const data = await handlePromise(fetchSomeData());
      // Handle the data if successful
    } catch (error) {
      // Additional error handling if needed, or leave it to propagate further
    }
  };

  fetchData();
}, []);

Moved to: https://linear.app/zenosmosis/issue/ZEN-11/promise-utility-function-route-errors-up-to-ui


Generating models fails - Type 'IContentItem' is not generic.ts

Brief bug description
I have generated the models and they looks as described in readme.
import { IContentItem, Elements } from '@kentico/kontent-delivery';

/**
 * Generated by '<EMAIL_ADDRESS>at 'Tue, 23 Nov 2021 17:18:24 GMT'
 */
export type Stat = IContentItem<{
  link_text: Elements.TextElement;
  metric: Elements.TextElement;
  link_url: Elements.TextElement;
  description: Elements.TextElement;
  note: Elements.TextElement;
}>;

But my compiler is complaining:
Type 'IContentItem' is not generic.ts(2315)
(alias) interface IContentItem
import IContentItem

Repro steps

Generate any model
Run TS compilation/lint

Expected behavior
No error should be raised.
Screenshots

@Simply007 As this is only generator, it does not provide IContentItem interface. Does your repo have Delivery JS SDK on version 11.0.0 installed?

@Simply007 As this is only generator, it does not provide IContentItem interface. Does your repo have Delivery JS SDK on version 11.0.0 installed?

My fault!
I have set the SDK version to v11, removed package-lock.json, and ran npm install. Unfortunately, I haven't saved the packege.json 🤦♂


fix(engine): Remove Codeowners when no OpenSource project

Remove Codeowners when no OpenSource license is selected.

#152


Updates the circle webhook to the new route

Checklist

[ ] Circle CI is passing (code compiles and passes tests).
[ ] There are no breaking changes to public API.
[ ] New test cases have been added where appropriate.
[ ] All new code has been commented with doc blocks ///.

@vapor-bot

@vapor-bot

@vapor-bot

@vapor-bot test performance

Hey @twof, you just merged a pull request, have a coin!
You now have 61 coins.


fhirflat

update types
fhirflat: initial adapter draft
plots: move palette out into module
docs: expand RAP abbrevation
add
add condition_proportion
Include taxonomy toml files in package
separate plot_unpacked
condition_upset() returns DataPlotInfo
Use toml instead of fhirflat.ini
add tests

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Update basic-select.md

Edited the Weather Observation Station 5 Query

Edited the Weather Observation Station 5 Query


terraform.tfvars.example is not correct, remove.

The kube_insecure_apiserver_address = <IP_ADDRESS> in terraform.tfvars.example is not correct, the step "Rename terraform.tfvars.example to terraform.tfvars" will cause installation error.

/approve


Updated react to v17 and other dependencies

Description

What was changed in this pull request?

Updated all dependencies

Why is it necessary?
Applications that use resglass are not able to update react to v17 while resglass depends on react v16

Fixes #___
Checklist

[ ] Set proper GitHub labels (e.g. v1.6+, ignore if you don't know)
[ ] Unit tests added or updated
[ ] Documentation added or updated
[ ] Example(s) added or updated
[ ] Update schema.json if there are changes to the viewconf JSON structure format
[ ] Screenshot for visual changes (e.g. new tracks or UI changes)
[ ] Updated CHANGELOG.md

I don't know yet what I missed and is an issue with webpack or with pixi update that now screen hangs being white, and there are no errors in console.. I saw warnings in browser that source map can't be found but even after I fixed that (this is not present in 4e6226e) nothing changed

I guess webpack config is not fully updated yet, react v17 and pixijs v6 work fine together

Ups, I didn't run tests

Ups, I didn't run tests

But on the main branch where there are no changes I can't run tests at all

karma.conf.js does exist..


Connected but sensors don't update

I'm connected to my remote instance, the binary sensor shows connected, but my sensors aren't updating. Is there any other way, besides the sensor, I can see why things aren't working? The remote assistant pointing the OTHER direction is working a treat, sensors ARE updating.
Is it perhaps not possible to have two remote assistants working bidirectionally?
Cheers

I have the same issue. I have opened an issue yesterday and the have closed it again, as thought it were working then. But today, last update was 8 hours ago. In the enabled log I see
020-11-14 12:36:33 DEBUG (MainThread) [custom_components.remote_homeassistant] received: {'id': 1, 'type': 'event', 'even
And Iti nos 19:00 O'clock. The sensors are showing different values on the remote haass. I do not know where to look for the solution.

I downgraded to 2.1, that seemed to help...but only briefly. Now not working again.  I'm about ready to give up and go back to passing messages via MQTT.

I am having this same issue. Is there anyway to force this?

Sadly I’ve seen no sign there’s any interest in fixing this massive bug

Is there any workarounds? I don't want to go back to mqtt as I am not sure how to report battery levels with that method.

I have not seen this issue myself, but it fixing it seems rather urgent and important. One thing that is not implemented is heartbeats (ping-ping), which at least would detect if the connection isn't working. It's to tell if it will "fix" the root cause, but perhaps it can help (by exercising the connection a bit). I can try to implement it later tonight, if I have some time.
For reference: https://developers.home-assistant.io/docs/api/websocket/#pings-and-pongs

thank you very much and very kind of you!

Same issue is happening in my setup. Upon restart of HA, the states of my remote device trackers are acquired properly, but they do not seem to be updated after that...

I have created a PR, #73, that adds support for the mentioned heartbeats. Hopefully this will detect if the connection doesn't work and re-connect. Please try it out and let me know if it works.

I have not downloaded a branch before so just want to make sure....I just copy the file in #73 and override the one I have in custom component, right?

nvm...brother showed me how to download the postlund:heartbeat repo. I just copied over the init.py file and overwrote the existing with you and restarted HA. I will report back on disconnect tomorrow. Thanks!

actually nevermind. uploaded/overwrote the full remote_homeassistant folder and restarted. no error so far.

I have created a PR, #73, that adds support for the mentioned heartbeats. Hopefully this will detect if the connection doesn't work and re-connect. Please try it out and let me know if it works.

So this morning I tested it and seems like it did lose connection still.
Main instance
Remote instance where the sensor is connected

PR #73 seems to work for me. The connection was lost at some point (judging from "heartbeat failed" log message), but my remote device trackers do get updates, so I assume the reconnection worked fine. Thanks for the fix!

PR #73 seems to work for me. The connection was lost at some point (judging from "heartbeat failed" log message), but my remote device trackers do get updates, so I assume the reconnection worked fine. Thanks for the fix!

I will continue the testing. I have the remote instance on a 6 hour restart schedule. I am not sure if that is messing up my testing. Will report back in 2 days. Thanks!

PR 73 not working for me. Still same problem. 😒

I was having the same issue after configuring using the UI. I solved my problem by subscribing the following events in the last step of the configuration:

state_changed
service_registered

I was having the same issue after configuring using the UI. I solved my problem by subscribing the following events in the last step of the configuration:

state_changed
service_registered

Brother, can you please elaborate for us mortals? :D This so far is working for me but if the remote instance is rebooted, the master instance shows that sensors as missing.

Mhmm, this might be my doing... In the YAML schema, those events are used as default value unless something is specified. That's not how it works when setting up from config flow (no events are subscribed to). So that becomes a problem.
@lukas-hetzenecker Based on the above, do you see any reason not to hardcode those events in as "default" (regardless of what's in the config) and just let the config just append to those?

I was having the same issue after configuring using the UI. I solved my problem by subscribing the following events in the last step of the configuration:

state_changed
service_registered

Brother, can you please elaborate for us mortals? :D This so far is working for me but if the remote instance is rebooted, the master instance shows that sensors as missing.

Sure.
You go to Integrations configuration:

And in the last step you add all the events:

These events are now subscribed to internally by the component, so no need to specify at all. Currently only on master, will hopefully make a release soon.


Ss423 add program

This pull request is now updated with the following:

Added tests for the creation and editing of programs
Rake working:setup use programs to create studies
has_many :through for looking for studies
Destroy removed from programs


Add a defmt project

Add a defmt project covering how to use defmt with espflash, esp-println and esp-backtrace.

Just noticed that I forgot to add the project in CI, will update it


Eslint.lintask is enable, but it doesn't work

Eslint does not check workspace files when they are closed.

Eslint works when the file is in the editor

I have the same error

Noticed this as well

You have to trigger the task using the run task command. The task is not run automatically since validating all files is quite expensive since ESLint has no incremental update strategy.

This makes the whole idea of errors/warnings statusbar item kinda pointless since it is not going to show correct number. TypeScript is the same in that regard.

Usually people combine the reconciling of the open files with the tasks. As said constantly running ESLint over the whole project is not feasible unless they add incremental support.
Regarding Typescript: it does support watch and incremental support and VS Code has support for this via task which always give you the errors for the whole project.


vscode-extensions.visualjj.visualjj: init at 0.11.8

Fix : https://github.com/NixOS/nixpkgs/issues/345246

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Needs unfree licence.

Missing license added. TY !


[Catalog UI] Download Button Generates Incorrect File with .html Extension and Embedded HTML Content

Description
When a user clicks on a catalog card and opens the modal, clicking on the Download button triggers the download of a file named design.yml.html. Moreover, the downloaded file is not a valid .yml file but a .html code file.
Expected Behavior
Upon clicking the Download button :

a .yml extension file must be downloaded
the downloaded file must contain valid yml content

Screenshots

Environment:

OS: Mac
Browser: Safari
Device: Desktop

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Thank you!


ValueError when rename_column on splitted dataset

Hi there,
I am loading .tsv file via load_dataset and subsequently split the rows into training and test set via the ReadInstruction API like so:
split = {
    'train': ReadInstruction('train', to=90, unit='%'),
    'test': ReadInstruction('train', from_=-10, unit='%')
}

dataset = load_dataset(
    path='csv',               # use 'text' loading script to load from local txt-files
    delimiter='\t',           # xxx
    data_files=text_files,    # list of paths to local text files
    split=split,              # xxx
)

dataset

Part of output:
DatasetDict({
    train: Dataset({
        features: ['sentence', 'sentiment'],
        num_rows: 900
    })
    test: Dataset({
        features: ['sentence', 'sentiment'],
        num_rows: 100
    })
})

Afterwards I'd like to rename the 'sentence' column to 'text' in order to be compatible with my modelin pipeline. If I run the following code I experience a ValueError however:
dataset['train'].rename_column('sentence', 'text')

/usr/local/lib/python3.7/dist-packages/datasets/splits.py in __init__(self, name)
    353         for split_name in split_names_from_instruction:
    354             if not re.match(_split_re, split_name):
--> 355                 raise ValueError(f"Split name should match '{_split_re}'' but got '{split_name}'.")
    356
    357     def __str__(self):

ValueError: Split name should match '^\w+(\.\w+)*$'' but got 'ReadInstruction('.

In particular, these behavior does not arise if I use the deprecated rename_column_ method. Any idea what causes the error? Would assume something in the way I defined the split.
Thanks in advance! :)

This has been fixed in #2043 , thanks @mariosasko
The fix is available on master and we'll do a new release soon :)
feel free to re-open if you still have issues


Direct message parse error

When I click on the Direct button the server tries to parse the messages JSon file but after some time I get the following error:
[1] SyntaxError: Unexpected end of JSON input
[1]     at JSON.parse (<anonymous>)
[1]     at C:\Users\Labtop\Documents\GitHub\instagram_backup_manager\server\api\routes\messages.js:12:23
[1]     at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:63:3)

What is causing this issue? Any help is appreciated.

When I click on the Direct button the server tries to parse the messages JSon file but after some time I get the following error:
[1] SyntaxError: Unexpected end of JSON input
[1]     at JSON.parse (<anonymous>)
[1]     at C:\Users\Labtop\Documents\GitHub\instagram_backup_manager\server\api\routes\messages.js:12:23
[1]     at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:63:3)

What is causing this issue? Any help is appreciated.

Please Make sure your messages.json file is not edited in someway , and are you able to read some messages or not at all? and please provide a little brief error log , so i can check in depth

When I click on the Direct button the server tries to parse the messages JSon file but after some time I get the following error:
[1] SyntaxError: Unexpected end of JSON input
[1]     at JSON.parse (<anonymous>)
[1]     at C:\Users\Labtop\Documents\GitHub\instagram_backup_manager\server\api\routes\messages.js:12:23
[1]     at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:63:3)

What is causing this issue? Any help is appreciated.

Please Make sure your messages.json file is not edited in someway , and are you able to read some messages or not at all? and please provide a little brief error log , so i can check in depth

Please Make sure your messages.json file is not edited in someway ,

I've not edited any part of the backup and the backup was download today morning itself.

and are you able to read some messages or not at all?

I'm not seeing anything on the browser tab. However, the cmd that runs in the background (when run.bat is clicked) loads my messages from the JSON and displays it until I get the error I shared above. And probably because of this I only see a Instagram logo on my browser tab and nothing else.

and please provide a little brief error log , so i can check in depth ,

How can I proved the log you need? I shared the error which I got on my cmd terminal.

Take the backup once again In case to make sure there is no error in it

Ok I'll try this too.
Cheers

Please Make sure your messages.json file is not edited in someway ,

I've not edited any part of the backup and the backup was download today morning itself.

and are you able to read some messages or not at all?

I'm not seeing anything on the browser tab. However, the cmd that runs in the background (when run.bat is clicked) loads my messages from the JSON and displays it until I get the error I shared above. And probably because of this I only see a Instagram logo on my browser tab and nothing else.

and please provide a little brief error log , so i can check in depth ,

How can I proved the log you need? I shared the error which I got on my cmd terminal.

Take the backup once again In case to make sure there is no error in it

Ok I'll try this too.
Cheers

Please Make sure your messages.json file is not edited in someway ,

I've not edited any part of the backup and the backup was download today morning itself.
Edit: The 'Profile' and 'Stories' tab seems to be working fine.

and are you able to read some messages or not at all?

I'm not seeing anything on the browser tab. However, the cmd that runs in the background (when run.bat is clicked) loads my messages from the JSON and displays it until I get the error I shared above. And probably because of this I only see a Instagram logo on my browser tab and nothing else.

and please provide a little brief error log , so i can check in depth ,

How can I proved the log you need? I shared the error which I got on my cmd terminal.

Take the backup once again In case to make sure there is no error in it

Ok I'll try this too.
Cheers

I'll Check it Once Again with the latest backup of my account, there may be possibility of  Instagram making changes to backup itself.  and do revert back if anything works on your end ,

Please Make sure your messages.json file is not edited in someway ,

I've not edited any part of the backup and the backup was download today morning itself.
Edit: The 'Profile' and 'Stories' tab seems to be working fine.

and are you able to read some messages or not at all?

I'm not seeing anything on the browser tab. However, the cmd that runs in the background (when run.bat is clicked) loads my messages from the JSON and displays it until I get the error I shared above. And probably because of this I only see a Instagram logo on my browser tab and nothing else.

and please provide a little brief error log , so i can check in depth ,

How can I proved the log you need? I shared the error which I got on my cmd terminal.

Take the backup once again In case to make sure there is no error in it

Ok I'll try this too.
Cheers

I'll Check it Once Again with the latest backup of my account, there may be possibility of  Instagram making changes to backup itself.  and do revert back if anything works on your end ,

@Deleora  I have looked into issue and it turns out to be true that Backups Dated in 2021 are not working for now ,
Instagram has adapted new backup format , so i'l try to add it to IGBM ASAP
I will try fix this asap and fix the issue , Stay Tuned will update here

@Deleora  I have looked into issue and it turns out to be true that Backups Dated in 2021 are not working for now ,
Instagram has adapted new backup format , so i'l try to add it to IGBM ASAP
I will try fix this asap and fix the issue , Stay Tuned will update here

@Deleora  Updated it now you can use it , Still any issue? Feel Free to Open One Again .
Hope You Like it This Time 😊

@Deleora  Updated it now you can use it , Still any issue? Feel Free to Open One Again .
Hope You Like it This Time 😊


Google Guava version is out of date and has a vulnerability in it.

The current version of Google Guava that is being used is out of date which has the following security vulnerability in it: CVE-2018-10237. It's currently using version 20 but is fixed in versions higher that 24.1.1.

Hey! Thanks for the info. We'll patch it ASAP.


Set accept-language header on request

Hi,
I am trying to send the language header in the request, but I do not identify where I should put it.
const options = {
wsdl_options: {
'auth': {
'user': USER_NAME,
'pass': USER_PASS,
'sendImmediately': false
},
'accept-language': 'es'
}
};
soap.createClient(ROOTE_WSDL, options, (err, client) => {...});

Hi @ednx, I think this should work:
const options = {
  wsdl_options: {
    auth: {
      user: USER_NAME,
      pass: USER_PASS,
      sendImmediately: false
    },
    wsdl_headers: {
      'accept-language': 'es'
    }
  }
};

However, if you are using callbacks, you are using the node-soap library directly, feel free to ask them for support on their gitter chat (https://gitter.im/vpulim/node-soap).
I'm gonna close this as it's not really an issue with this library.


Fixed #33305 -- Fixed autodetector crash for ForeignKey with hardcoded "to" attribute.

@bmispelon Thanks :+1:


Rebased Hannah's VALUES PR on the current master

Closing this temporary PR after I copied its current version to the original #880


Skip finalization for PoolThreadCache instances without small/normal caches

Motivation:
PoolThreadCache doesn't need to be finalized if it doesn't contain small/normal caches
Modifications:
Create a base class for PoolThreadCache that won't be registered for finalization
Result:
Less GC activity and reduced footprint for short/medium living threads

This is the first step in the direction to make Netty more "loom-friendly" too: now that we can generate non-finalizable lightweight instances, we could find a way to associate them to a virtual thread without using any thread local (that is NOT a good idea to use with short living millions of virtual threads :"( )

@chrisvest PTAL.

@chrisvest @franz1981 Ping, just in case you're not aware of the performance regression introduced by this commit.

@slandelle thanks a lot... @ejona86 I still don't get why this would cause such a problem

@normanmaurer given that this one was an "addition" but not required (for loom I will poet the allocator from Chris), we can revert and Investigate (without hurry). I don't want anyone to regress for something which is not a bug fix

@franz1981 Could the regression be type pollution? I don't see anything suspicious in this other than two types visiting code paths where there previously was only one.

Good point @chrisvest yep, it could be a funny (and scary, as usual :/ ) possibility...
If I can run their microbench, both the profiler and the agent can show that (@ejona86 too): https://github.com/franz1981/rhp-type-pollution-agent/blob/face-to-face/benchmarks/WHATIF.md

@franz1981 It's not necessarily related to instanceof. Type pollution can impede JIT optimizations, when a method is called with more than one concrete type in an argument.

Instead of splitting out PoolArenasCache, we could move the finalize() method to a new class that PoolThreadCache then may-or-may-not reference from an instance field.

@chrisvest you mean profile type pollution then, yep. But with concrete types (not interfaces) bi-morphism should still allow inlining and save megamorphism.
Without profiling data is difficult to say what's going on, but my educated guess is that pool thread cache is not used for small/normal types (due to some logic error where I have enabled it - I have added a small condition there
https://github.com/netty/netty/pull/13408/commits/5a7197fa607d2194d892a235dbb033e77ce7f522#diff-c24e989820523c812b36dea1eb81cbbde7822d060eac7bf136fa96be00956e3fR521
Which wasn't present before and it should be trivial to check if reverting just the condition fix it.
If the regression is in a jmh benchmark which cause hitting the condition (due to the jmh thread executor..?) That would explain why I didn't spotted in our perf rig.
And still I like your idea of an inner reference which can be finalized...so if you feel to do it, go for it +100
If we can have monomorphism is always a good idea

@franz1981 Apparently the extra condition check is not the culprit: https://github.com/grpc/grpc-java/issues/10401#issuecomment-1648781849
So the most convenient explanation is ruled out.


Intermittent issue with s3 replication plugin

Noticed that sometimes the messages from the SQS queue are not consumed by the JobWorker and stayed waiting for a few days. When a new item was added to s3, event got triggered and the message was added to the queue and no. of messages available got incremented and the waiting job count in the cloudwatch dashboard got incremented as well. However, it stayed in waiting state and never got transferred. Only after terminating the ec2 instance and a new instance got launched it resumed transferring the objects.
Apart from the s3 trigger, even the hourly job got affected as well due to this and it wasn't able poll the source and destination buckets completely.
This was the error in the log of job finder.
2021-05-24T12:51:47.982+05:30	2021/05/24 07:21:47 Start running Finder job
2021-05-24T12:51:48.336+05:30	2021/05/24 07:21:48 Get Parameter Value of china_keys from SSM
2021-05-24T12:51:48.782+05:30	2021/05/24 07:21:48 Queue DTHS3Stack-S3TransferQueue-7QIV4XZ7OKM1 has 0 not visible message(s) and 3 visable message(s)
2021-05-24T12:51:48.782+05:30	2021/05/24 07:21:48 Queue might not be empty or Unknown error... Please try again later
To Reproduce
The issue is intermittent, unable to reproduce.
Please complete the following information about the solution:

[ ] Version: v2.0.0
[ ] Region: [e.g. us-west-2]
[ ] Was the solution modified from the version published on this repository? No (only the cron job frequency was changed to daily from hourly)
[ ] If the answer to the previous question was yes, are the changes available on GitHub?
[ ] Have you checked your service quotas for the sevices this solution uses?
[ ] Were there any errors in the CloudWatch Logs? Yes, logs attached above.

Hi @sushantbhat ,
Could you check the EC2 JobWorker's log in CloudWatch Log groups when the SQS jobs ignored by the workers? The log groups' name is like 'xxxxxxWorkerLogGroupxxxxxxxx'
B, R

@YikaiHu Seems like 'xxxxxxWorkerLogGroupxxxxxxxx' wasn't logging anything. There are no log streams after May-03 until it was restarted a couple of days back. And even the logs before that are empty now not even the normal logging that says 'No messages, sleep...'.

@sushantbhat
For issue 1: "However, it stayed in waiting state and never got transferred."
Have you ever restarted the EC2 Workers before this issue occur?
It seems like the transfer cli in your EC2 Workers shut down for some reason. If this case occur, you have to terminate these  'dead' Workers, and Auto Scaling Groups will launch new Workers to consumption the jobs in SQS.
For issue 2: "This was the error in the log of job finder ....  Queue might not be empty or Unknown error... Please try again later"
This is a normal mechanism, and the Finder is designed to check whether SQS is empty before comparing.

No, I haven't restarted ec2 workers before. Only after this issue happened, ec2 worker was terminated, and like you mentioned it relaunched another instance that started working as expected.
However, wanted to know what could have caused JobWorker to fail, as we are planning to go production with this solution and anything that can be done to prevent this from occurring in the future.
And also is there any notification mechanism that can be enabled for such cases where JobWorker fails and messages are stuck in waiting state?

@sushantbhat
The most efficient method to find out the root cause of the issue is to check the EC2 system log in the EC2 console (Actions -> Monitor and troubleshoot -> Get system log) and check whether the JobWorker's CLI is running.
The reasons which can cause JobWorker to fail:

Customer restart the EC2 Worker instances.
Customer edit the EC2 user data may cause the instance cannot download the CLI successfully
In this version, we don't have notification mechanism for Worker failure.


Does not have mobile functionality

Can't use on mobile at all, extensions can't interact with mobile browsers.

Hi, I think this issue is solved 👍
You can use MathWallet on iOS/Android, it is compatible with the ArConnect API.
It is also easily possible to submit a dApp on the dApp Store.
That's pretty awesome.


RuntimeError: CUDA error: invalid configuration argument on jetson xavier nx

Hi,
Thank you for developing this amazing tool.
I am currently using a Jetson Xavier NX but we have some problems during the INT8 evaluation.
Full logs
# python3 eval.py --config=yolact_edge_config --trained_model=/share/yolact_edge_54_800000.pth  --score_threshold=0.3 --top_k=100  --image=/share/test.jpg
[12/20 13:32:31 yolact.eval]: Loading model...
[12/20 13:32:41 yolact.eval]: Model loaded.
[12/20 13:32:41 yolact.eval]: Converting to TensorRT...
Traceback (most recent call last):
  File "eval.py", line 1275, in <module>
    convert_to_tensorrt(net, cfg, args, transform=BaseTransform())
  File "/share/yolact_edge/yolact_edge/utils/tensorrt.py", line 106, in convert_to_tensorrt
    "moving_statistics": None
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/share/yolact_edge/yolact_edge/yolact.py", line 1621, in forward
    outs = self.backbone(x)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/share/yolact_edge/yolact_edge/backbone.py", line 121, in forward
    x = self.maxpool(x)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 889, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/pooling.py", line 164, in forward
    self.return_indices)
  File "/usr/local/lib/python3.6/dist-packages/torch/_jit_internal.py", line 365, in fn
    return if_false(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/torch/nn/functional.py", line 659, in _max_pool2d
    return torch.max_pool2d(input, kernel_size, stride, padding, dilation, ceil_mode)
RuntimeError: CUDA error: invalid configuration argument

Environment:

NVIDIA ® Jetson Xavier™ NX
nvidia-l4t-core 32.5.1
TensorRT : 7.1.3
CUDA version : 10.2

Sorry, I solved it myself.
https://github.com/haotian-liu/yolact_edge/issues/45#issuecomment-771430980
As you can see here, I reduced "torch2trt_max_calibration_images" to something like 5 and it works fine!


Unable to prepare a soap request which require Authheader

Please Help me setup below SOAP request xml which contains AuthHeader also.
        <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"
           xmlns:out="http://Demo.Manufacturing.Webservices/Outbound/">
                   <soapenv:Header>
                       <out:AuthHeader>
	                       <out:UserName>admin</out:UserName>
	                     <out:Password>7338b6c1702d</out:Password>
                          </out:AuthHeader>
                      </soapenv:Header>
                      <soapenv:Body>
                            <out:GetOrder>
         	                <out:bu>1</out:bu>
	                        <out:order>5582</out:order>
                          </out:GetOrder>
                     </soapenv:Body>
           </soapenv:Envelope>

Hey :wave:
I was faced with the same problem and here's how I managed to solve it:

    httpClient := &http.Client{
        Timeout: 5 * time.Second,
    }

    soap, err := gosoap.SoapClient("http://some/fancy/location.wsdl", httpClient)
    if err != nil {
        log.Fatalf("SoapClient error: %s", err)
    }

   //set your auth headers here
    soap.HeaderParams = gosoap.HeaderParams{
        "AuthHeader" : map[string]interface{}{
	    "Username" : "admin",
	    "Password" : "7338b6c1702d",
	},
    }

   //execute request
   // _, err = soap.Call("SomeAction", params)

This is in reference to #8 .
I hope its not too late, cheers

thanks


Add red highlight for inactive circuits

fix #69
For inactive circuits there must be something to call attention from the operator.
Added a red highlight for items that are marked as inactive circuit.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e084598). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage          ?   79.62%
=========================================
  Files             ?        7
  Lines             ?     1065
  Branches          ?        0
=========================================
  Hits              ?      848
  Misses            ?      217
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e084598...14ef95b. Read the comment docs.


Utilize Google Fonts v2 API with optimized variable fonts

And, provide fallback when var font support is not available
refs,

https://developers.google.com/fonts/docs/css2

Can you also add the fallback described here: https://developers.google.com/fonts/docs/css2#legacy_browser_support to the CSS files - I'm just a little concerned about making the theme exclusive to the most modern browsers. I mean, the support already looks decent, but with a simple fallback I figure it can't hurt to add it. Thoughts?

Concern is valid. Added fallback. @daveaglick
I plan to test this more with my blog in some devices after it gets merged.

Initial tests looked fine to me, so I'll merge it in and we'll iterate as needed. Thanks (and sorry for the delay)!

On second thought, I don't love the differences here now that I've viewed it a few times. There's a lack of emphasis on headers so everything kind of runs together.
Before:

After:

Any idea what's going on here @atiq-cs?

I'm also noticing the font faces look blander (I.e. the body font is no longer that nice serif). I'm going to revert this back out until we can figure out what's going on here.


Comments doesn't get highlighted inside of datasources blocks

I honestly forgot to add them to grammar of datasource. I will fix this as soon as I get some time.

fixed here: https://github.com/prisma/vim-prisma/pull/12 if you want to take a look :)


Unable to Pre-Assign Roles to Oauth-Authenticated Users

Proposal
Currently, in Perses, it is not possible to pre-assign roles to users that will be created in the future via Oauth authentication. This limitation arises from the following behaviors:
Overview
Users that do not yet exist cannot be included in RoleBinding.
When attempting to create a RoleBinding with percli apply that includes a user (e.g., alice) who does not yet exist, Perses returns an error.
{
  "kind": "GlobalRoleBinding",
  "metadata": {
    "name": "admin"
  },
  "spec": {
    "role": "admin",
    "subjects": [
      {
        "kind": "User",
        "name": "alice"
      }
    ]
  }
}

bad request: user subject name "alice" doesn't exist StatusCode: 400

Oauth users cannot be created in advance.
When attempting to create a user like the following, Perses also returns an error.
{
  "kind": "User",
  "metadata": {
    "name": "alice"
  },
  "spec": {
    "oauthProviders": [
      {
        "issuer": "http://localhost/openid",
        "email"<EMAIL_ADDRESS>
        "subject": "123456789"
      }
    ]
  }
}

bad request: password cannot be empty StatusCode: 400

Users with both nativeProvider and oauthProviders can be created.
Users specifying both nativeProvider and oauthProviders appear to be created successfully:
{
  "kind": "User",
  "metadata": {
    "name": "alice"
  },
  "spec": {
    "nativeProvider": {
        "password": "password"
    },
    "oauthProviders": [
      {
        "issuer": "http://localhost/openid",
        "email"<EMAIL_ADDRESS>
        "subject": "123456789"
      }
    ]
  }
}

However, Oauth login fails for users with both nativeProvider and oauthProviders.
Attempting to log in via Oauth for such users results in an Internal Server Error in the browser, and the following log is recorded in the console:
level=error msg="Failed to sync user in database." error="this user is already registered with the native provider"

Suggestions for Improvement

Allow users to be created without specifying a password.
Enable Oauth login for users with nativeProvider credentials.

Thank you for developing this fantastic product. Please let me know if additional information is required, or I can assist by opening a pull request.

Hello, let me answer you point by point
Users that do not yet exist cannot be included in RoleBinding.
=> yes, I think we should do something about that. As this is your primarily issue. We'll ease the rolebinding creation/update to allow not existing users. To be followed here https://github.com/perses/perses/issues/2270
Oauth users cannot be created in advance.
=> This is wanted. We don't really want to trust users for creating oauth users properly. The fields can be quite complex and undocumented.
Users with both nativeProvider and oauthProviders can be created.
=> This is a bug. I just created an issue about that https://github.com/perses/perses/issues/2429
However, Oauth login fails for users with both nativeProvider and oauthProviders.
=> Again on purpose, details on the issue created right above.

Closing the issue has to be reported in the two other issues mentioned.
Thanks @kamijin-fanta for sharing your experience!

Thank you for the incredibly quick resolution! This will make Perses much more user-friendly!


lib: Fix typo in Connection new_scid documentation

Small typo in Connection's new_scid documentation.

Merged. Thank you.


Viewer Does Not Work Against Git Tags

Description
If you specify a CWL URL with a Git Tag, the Common Workflow Language Viewer displays the error The workflow could not be retrieved from the Git repository using the details given.
Expected Behavior
Viewer should be able to visualize a CWL off of a tag, just as it does for branches.
Actual Behavior
It displays an error message.
Possible Fix
In GitService.java there is
branchOrCommitId = "refs/remotes/origin/" + branchOrCommitId;

According to https://stackoverflow.com/questions/33762575/load-content-from-tag-with-jgit, you need to set it to "refs/tags/my-tag" ) if it's a tag.
Steps to Reproduce

Go to https://view.commonwl.org/workflows
Input this value for the Url to workflow: https://github.com/briandoconnor/dockstore-workflow-md5sum/blob/1.3.0/md5sum.cwl
You get the error The workflow could not be retrieved from the Git repository using the details given

Context
I'm working on using images generated by the viewer and displaying them in dockstore.org; in trying different workflows, I stumbled across this one.

Thanks @coverbeck for your report! Can you make a quick PR to add the tag version as a fallback? I don't think any fancy (is this a tag or commit) logic is needed 🙂

@mr-c : https://github.com/common-workflow-language/cwlviewer/pull/192

Thanks @coverbeck , I don't have the expertise nor the permissions to review your PR

Added some tests to the PR.


Align the table header to the table when labels are used

Closes #49
The table header is now also indented
if the table is given labels.
Regenerated table output in tests.

Report
If no labels are added everything stays the same:

If labels are added the header indents correctly:

It doesn't matter how many elements are included:

All other labelled fields look the same:

We agreed it is not worth the extra logic to allow row labels of static tables to be hidden. The diff to the expected test files is to add these row labels.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (799b31b) 88.51% compared to head (42fbbb3) 88.55%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   88.51%   88.55%   +0.04%
==========================================
  Files          22       22
  Lines        1358     1363       +5
==========================================
+ Hits         1202     1207       +5
  Misses        156      156

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


React 18 + NodeJs + Menu / Alert / Tooltip don't show up in development mode

Description
Menu, Alert and Tooltip don't work with React 18 render functionality
CodeSandbox/Snack link

Steps to reproduce
When the render mode is set to React 18

const root = ReactDOM.createRoot(document.getElementById("root") as HTMLElement);

root.render(
    <Root />
  );

Instead of 17
ReactDOM.render(
  <React.StrictMode>
    <Root />
  </React.StrictMode>,
  document.getElementById("root")
);

Components like Menu, alert or tooltip don't show up in development mode (craco start).
NativeBase Version
3.4.25
Platform

[ ] Android
[X] CRA
[ ] Expo
[ ] iOS
[ ] Next

Other Platform
No response
Additional Information
No response

Hey @Snotax, thanks for reporting! We'll look into this.

@ruchik02  Any updates on this?


Add train script for multiple choice, question answering and text-classification task

This branch do:

Add train script and model_batchsize.txt for 3 task:  multiple choice, question answering and text-classification
Modify the readme in example/pytorch: guide how to run the train script

LGTM. Please note that we should leave the approval on the PR first before merging it :)


update bootstrap to 3.2.0

Hey. Here is update bootstrap in picker and demo example to version 3.2.0

could you rebase this PR ?

:+1:


guarantee that the process 'exits' on failure

I've not found a way to guarantee that the process 'exits' on failure.  Any walkback inducing error will launch the interactive debugger.  I've tried to intercept most prompts and errors such that Jenkins is told of the error, but definitely not all.  If nodialog.exe does not 'exit' then Jenkins waits forever for it to finish.  The only way to 'fix' this is to login to the desktop running the jenkins slave and answer whatever prompt is being displayed in the VA Smalltalk UI.

Another customer suggest doing something like this:
[
"All build process code here"

] on: ExAll	do:
	[:signal |
		(Notification handles: signal)
			ifTrue: [signal pass]
			ifFalse: [

				| errorDescription |
				errorDescription := exception description.
				self log: ('Unexpected Error: %1' bindWith: errorDescription).
				MinimalWalkbackDumper new dumpWalkbackDueTo: errorDescription.
				System exit: 9006 withObject: nil

			]
	]

Of course, you can adapt what you do with the error (logging, dumping walkback, whatever)


Remove version: Reqable.Reqable version 2.11.0

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

/azp run

URL: https://github.com/reqable/reqable-app/releases/download/2.11.0/reqable-app-windows-x86_64.exe
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 886)

For moderators or/and anyone else

[!Caution]
As a result of several personal problems I've had over the last few months + my final exams coming up very soon, I'm currently unable to look at my GitHub notifications every day and maintain my executions correctly.
If you detect a certain problem on a certain pul request:

Either you can close the pull request directly without mentioning me.
Or you can send me a message on X (Twitter): @Exorcism0666

Thank you for your understanding, and I'm sorry if some pull requests can't be approved due to the situation I'm in.

This account is automated by Github Actions and the source code was created by CoolPlayLin. If you have any questions about any pull request, don't hesitate to ping Exorcism0666.

[!warning]
With the new version of Komac, numerous Pull Requests may contain bugs or unwanted elements. If such issues arise, please tag russellbanks so that these bugs can be addressed in future updates.

[!important]
Please carefully review these Pull Request before merging. If it is a Pull Request for removing incorrect content and the URLs are issue, free upon manual checking, please close this Pull Request directly. (It is best to inform Exorcism0666 of the closure.)

良い一日をお過ごしください！

/azp run

https://github.com/microsoft/winget-pkgs/issues/142854


RHMAP-10140 update plugins to not crash on iOS 10

<plugin name="phonegap-plugin-barcodescanner" spec="~6.0.0" /> breaks the build on android platform 3.7.2, we should update to at least 4.1.1 first before we can use this version of the plugin

LGTM


feat(context): allow no parent

This allows incoming messages with no context to be traced.
The current behaviour is to drop the info by propagating a no-op span.

Pull Request Test Coverage Report for Build 99

7 of 7 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 32.37%

Totals

Change from base Build 98:
-0.07%

Covered Lines:
168

Relevant Lines:
519

💛  - Coveralls


Empty storeView errors prevents viewing state in devtools

Current behavior

I'm not sure if this is a bug or if I have something not configured correctly, but when I try to Load state in devtools I get errors saying that userGroupId can't be read from undefined(and similar errors). The errors are a result of the fact that storeView in the root state is empty. I pinned it down to currentStoreView() in core/lib/multistore.ts, where the const clientStoreView, at least in my case, always is an object; namely an empty Observable, which results in buildBaseStoreView() never being called.
Expected behavior

That I can inspect the state in devtools without errors.
Steps to reproduce the issue

Non-multistore project, open devtools -> vuex tab, try to Load state.
Repository

Can you handle fixing this bug by yourself?

[ X] YES, if this is not a symptom of other problems.
[ ] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ X] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Chrome 79.0.3945.88
OS: Ubuntu 18.04
Node: v12.14.0
Code Version: All relevant branches including master, release/v1.11 and hotfix/v1.11.2.

Additional information

Actually, I sort of mixed up related issues here. The original error I had was from getIsUserGroupedTaxActive() in core/modules/catalog/store/tax/getters.ts, which has nothing to do with currentStoreView(). getIsUserGroupedTaxActive() requires storeView to be populated in the state, so I guess that is the real issue here; why storeView is empty.

Hey, I'm trying to reproduce this error,but it works ok :thinking: :

yarn dev on hotfix/v1.11.2
on homepage open devtools and load state
Is this happen on all pages? Or maybe you changed default config?

@gibkigonzo that's weird. I just tried with a clean hotfix/v1.11.2, yarn installer(no changes), and get this error. We are also experiencing it on all our current vsf projects.

Ok, I figured it out. Apparently, I was running the beta channel of Vue devtools. I tried in another browser profile with stable Vue devtools and all was fine. So this probably isn't a VSF issue.


Slow first connection to DB

First project run is very slow because of DB

Probably this is an answer

@Lenkelheit mentioned, that we could do very simple request to DataBase on Application startup


fix: connectivity and error handling

check for reentry and race conditions
add custom errors to improve disconnection behavior and error reporting/diagnostics

🤖 Generated by Copilot at 536b717
Summary
🐛🚨📊

This pull request improves the error handling and logging of the network layer and related components. It introduces new custom error classes in @dxos/protocols and uses them to wrap and provide more context for signaling, connection, and transport errors. It also fixes some bugs and typos in the connection and teleport logic.

@dxos/protocols
More errors wrapped and raised
Winter of bugs ends

Walkthrough

Add new error classes to @dxos/protocols for more specific and consistent error handling across the network layer (link).

address some failure modes discovered when troubleshooting https://github.com/dxos/dxos/issues/4112


Generic-api-key has a lot of FN

I am using gitleaks as a tool to compare with a tool i am developing.
Describe the bug
Looking at the gitleaks implementation there is an if condition that checks if the rule only detects secrets with no numbers in it and if so it doesnt consider it as a secret, can i ask why is that?
It totally legit to use something like this password = testkey , and gitleaks does not detect it.
Expected behavior
I expect the if condition to be removed , if not i want to understand the reason.
cc @zricethezav

Hi @mustafanaa, I think you are referring to following condition:
https://github.com/gitleaks/gitleaks/blob/c5b15c9d74036ca0c32134280c3d941b41e4f2d9/detect/detect.go#L372-L376
As you can see in the comment section above this has been implemented to ensure that the secret does contain both: alphabetical chars as well as numbers.
https://github.com/gitleaks/gitleaks/blob/c5b15c9d74036ca0c32134280c3d941b41e4f2d9/detect/detect.go#L369-L370
I assume the reason for that is that API keys usualy have a characteristic pattern. For example, this could be: Base64 encoding, hexadecimal or something like a UUID. In general all of those contain both, alphabetic chars and numbers.
I hope that answers your question :-)


Rename Script

I might just be using it wrong, but the guide tells me to use "npx replace-in-file /monorepo-template/g notes **/. --verbose"
When I do, after changing the name I want. It just tells me "No files were changed"

I don't remember what it had previously said. But did it rename the files for you?

Having the same issue on OSX.
Single quotes around the arguments worked for me.
npx replace-in-file '/monorepo-template/g' 'notes' '**/*.*' --verbose

I guess we can close this now


Build a multi-arch Docker image (amd64 and arm64)

This changeset will build multi-arch Docker images for both amd64 and arm64 using Docker Buildx and Go's excellent built-in cross-platform capabilities. The GitHub CD pipeline is further parameterized to make it easier for forks to deploy to the GitHub Container Registry.

This looks great! Thanks for adding it!


Feat : Redesigning the join the community page

it is too large for desktop view it must be small

@RamakrushnaBiswal  hey if u can work on influncerlist ad brand assosciated page ...redesign it currently it looks very basic

@RamakrushnaBiswal

yes i can @RohitGupta1237

@RamakrushnaBiswal  ok so i will edit this issue and make it according to task ..but page should be responsive and integrated with backend like it is dont redo complete page make changes here only to avoid any functioanltiy change


'NoneType' object has no attribute 'game'

It's still around...
Deck 1: Stranglethorn Tiger, Haunted Creeper, Zombie Chow, Darkscale Healer, Silverback Patriarch, Novice Engineer, Shattered Sun Cleric, Stonesplinter Trogg, Imp Master, Gelbin Mekkatorque, Dragonling Mechanic, Water Elemental, River Crocolisk, War Golem, Frostwolf Warlord, Azure Drake, Dancing Swords, Cult Master, Puddlestomper, Frostwolf Warlord, Stormpike Commando, Silvermoon Guardian, Frostwolf Grunt, Kel'Thuzad, Flamecannon, Wisp, Murloc Raider, Chillwind Yeti, Defender of Argus, Razorfen Hunter
Deck 2: Mechwarper, Nerub'ar Weblord, Unstable Ghoul, Ice Lance, Injured Blademaster, Wee Spellstopper, Sorcerer's Apprentice, Mirror Image, Sen'jin Shieldmasta, Youthful Brewmaster, Core Hound, Archmage Antonidas, Explosive Sheep, Arcane Missiles, Hogger, Nerub'ar Weblord, Leper Gnome, Echo of Medivh, Raging Worgen, Pyroblast, Water Elemental, Unstable Ghoul, Maexxna, Old Murk-Eye, Lightwarden, Kezan Mystic, Spellbreaker, Imp Master, Blood Knight, Gnomish Inventor
Traceback (most recent call last):
  File "C:\Users\Ragowit\Documents\GitHub\mcts\hearthbreaker\uct.py", line 408, in GetMoves
    if card.can_use(self.game.current_player, self.game) and isinstance(card, MinionCard):
  File "C:\Users\Ragowit\Documents\GitHub\mcts\hearthbreaker\hearthbreaker\cards\base.py", line 226, in can_use
    return len(player.minions) < 7 and super().can_use(player, game)
  File "C:\Users\Ragowit\Documents\GitHub\mcts\hearthbreaker\hearthbreaker\cards\base.py", line 103, in can_use
    return player.mana >= self.mana_cost(player)
  File "C:\Users\Ragowit\Documents\GitHub\mcts\hearthbreaker\hearthbreaker\cards\base.py", line 121, in mana_cost
    for p in self.player.game.players
AttributeError: 'NoneType' object has no attribute 'game'

Fixed with b80df04cdcfddebaa7ea389714faab2c88ad6dc5.


Replace CSharpSyntaxTree.ParseText calls with Trivia or SyntaxFactory

@ujjwalchadha can you provide some context/detail here? do you plan on taking on a fix for this (as it's assigned to you)?


[403] Delete provider from user functionality added

Context

This trello ticket

Changes proposed in this pull request

Add functionality to remove providers from users

Guidance to review

Log onto support console, navigate to users, select a user, and click the big red button to remove the provider from that user

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

 Revoke user access to organisations feature


Query for competitions

FEATURE OVERVIEW
User Story
As an impact team member, I need to be able to query the database to know who has successfully signed up for organ donation and people who have fallen off the form.
Why This Matters
This will drive competitions.
(1) For signed up people, it'll be a competition to share their unique URL w/ more people.
(2) For people who have fallen off the form, it'll be some kind of encouragement/messaging to get them back to the form.

campaign signups will be something like

select u.uid, u.mail
from users u
inner join dosomething_signup s on s.uid = u.uid
where s.source like "user/%"
and n.nid = ____

unclear what this query will look like currently

@angaither Can I also add a request for the query for "people who have successfully completed the registration form" to this one or should I create a separate issue? Thanks!

@angaither I want to give the competitions team an update and wanted to know if you think the 3 queries above are doable. Recap:
(1) number of people signed up for campaign
(2) number of people who have completed the registration form
(3) number of people who have fallen off the form
Thanks!

@angaither I updated this issue to more clearly reflect what we want for voter. 1,2,3 are all the same -- #4 is a new one though that we were talking about and wasn't exactly sure where to add, but didn't want to lose it so added it here! Let me know, thanks!

closing for #6777


python3Packages.tvdb_api: needs requests-cache < 0.6

Motivation for this change
tvdb_api 3.1.0 doesn't work with our requests-cache so use an older version
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Thanks @dotlambda  - fixed.

Please add a line in pkgs/top-level/python-aliases.nix and choose a more appropriate commit message.

In principle, the removal of a python module warrants the addition of an alias but I doubt this was ever used as such so it seems rather pointless. Or am I missing something?

I would say it's just a thing we always do.


Broken for me because of

this: https://github.com/tinchoz49/DEPRECATING-cfs-upload-http/commit/89233c3910c73903e6bbda772ae388aed284b8c1

I just updated to your latest, and the problem still persists. I wish this worked, because I'm unable to
attach anything from my Chrome browser:


Add debug reference to "this" in ToggleCollection

Minor change: added debug reference to "this" in ToggleCollection.
This permit developer to click on the debug log in the console and Unity focus the component responsible for the warning.
I had this warning but couldn't know from where it was comming (I have multiples ToggleCollection in scene).

/azp run

Thanks for adding this! I think it's probably we'd benefit from adding this fairly widely throughout, so thanks for kicking off the change.

/azp run


Fix bug where constraint perp axes were ignored

Looks like we lost this in a refactor or something; the perpAxisA and perpAxisB fields in PhysicsConstraintParameters were unused, so constraints always used an arbitrary perp axis, instead of the user-provided one, which was making Physics6DoFConstraint hard to use.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.


Create tms-od.txt

@alex1701c I have to close the request without merging. Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


improve error msg for packed being incompatible

when running gemma2 with packed=True, i got the error below. It should be more comprehensive.
NotImplementedError: Block masks are not implemeted yet, use packed=False.

Also, if Gemma is not compatible with packed, we should fix it and/or remove the option from the config.

Hello @felipemello1,
The reason it does not work is quite complex. Block masks could work with gemma 2 without problem as there is nothing specific preventing them to work in theory. The problem comes from flex attention which I did not manage to implement for gemma 2, so gemma 2 is not using flex attention at the moment.
But the way torchtune automatically checks whether flex attention is available or not and the fact that datasets automatically create block masks specific to flex attention creates an incompatibility at the moment (this incompatibility does not exist if you have a version of torch which does not contain flex attention).
Here are a few directions I see to fix this problem:

make flex attention usage a parameter in each recipes and disable it for now for gemma 2: I feel like hiding to the users which attention implementation is going to be run is not ideal.
implement a working flex attention implementation but this would probably need to wait for pytorch to solve the issue

On a similar topic, did you successfully fine tuned gemma 2? I have been running the same (custom) pretraining script with both gemma 2 2B and llama3.2 3B which yields good generations with llama 3.2 and catastrophic ones with gemma 2...


REXControls.REXYGEN<IP_ADDRESS>1164bit version <IP_ADDRESS>11

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree company="REX Controls s.r.o."

Automatic Validation ended with:

This package installs normally in a Windows 11 VM, which might be due to the dependency being bundled with the newer OS.

This package installs normally in a Windows 11 VM, which might be due to the dependency being bundled with the newer OS.

Yes, it is true. I already found Windows 11 Feature Updates contain this Microsoft-Windows-EditionPack-Core-Package.ESD\amd64_netfx4-vcruntime140_clr_dll_31bf3856ad364e35_4.0.15912.0_none_746f6f2d2bca9bfc. So windows 11 use that thing from C:\Windows\servicing\LCU\Package_for_RollupFix~31bf3856ad364e35~amd64~~10.0.22621.1

Dear @BrandonWanHuanSheng ,
I did not understand if I should somehow include the library vcruntime140_1.dll in the installer or if it was a mistake on the test VM end? Our users normally install the REXYGEN on both Windows 10 and 11. Also, the installer was compatible with Windows 7.
Can you help me what should I do?

Automatic Validation ended with:

With the dependency preinstalled, the package installs and launches normally.

Hello @stephengillie ,
I added the dependency to the yaml file as you proposed, but unfortunately, the automatic build failed. Is there anything else I should do to move forward? I would appreciate any help.
Thank you in advanced

Hello @stephengillie , I added the dependency to the yaml file as you proposed, but unfortunately, the automatic build failed. Is there anything else I should do to move forward? I would appreciate any help. Thank you in advanced

Hi @ch3sn3k,
Unfortunately, new packages with dependencies are being held for dependency support. If it's okay with you, we'll keep this PR with the others requiring dependencies until we're ready for them to merge.

@stephengillie  Thank you for your help. I will prepare a new installer with all dependencies included and create a new PR.


equinox error when trying to run 'ML' example

Following the instructions in the order of the root readme.md file, i get an error when running the ML and combined models (although the fuzzy, bipartite, and markov all run fine):
Error in py_call_impl(callable, call_args$unnamed, call_args$named) :
  equinox._serialisation.TreePathError: Error at leaf with path (SequenceKey(idx=0), SequenceKey(idx=1), SequenceKey(idx=0), SequenceKey(idx=0), SequenceKey(idx=0), GetAttrKey(name='query_proj'), GetAttrKey(name='weight'))

Great package by the way.

Looking into this 👀
On Sat, Aug 24, 2024, 3:45 PM crahal @.***> wrote:

Following the instructions in the order of the root readme.md file, i get
an error when running the ML and combined models (although the fuzzy,
bipartite, and markov all run fine):
Error in py_call_impl(callable, call_args$unnamed, call_args$named) :
equinox._serialisation.TreePathError: Error at leaf with path (SequenceKey(idx=0), SequenceKey(idx=1), SequenceKey(idx=0), SequenceKey(idx=0), SequenceKey(idx=0), GetAttrKey(name='query_proj'), GetAttrKey(name='weight'))
Great package by the way.
—
Reply to this email directly, view it on GitHub
https://github.com/cjerzak/LinkOrgs-software/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZEOAHX4RBKAKBEZ7F2BZTZTDPDZAVCNFSM6AAAAABNB3D5FWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4DIOBTGMYDCMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

What operating system are you using? (Windows/Linux/OS-Apple?) That will
help give context!
On Sat, Aug 24, 2024, 3:54 PM Connor T. Jerzak @.***>
wrote:

Looking into this 👀
On Sat, Aug 24, 2024, 3:45 PM crahal @.***> wrote:

Following the instructions in the order of the root readme.md file, i get
an error when running the ML and combined models (although the fuzzy,
bipartite, and markov all run fine):
Error in py_call_impl(callable, call_args$unnamed, call_args$named) :
equinox._serialisation.TreePathError: Error at leaf with path (SequenceKey(idx=0), SequenceKey(idx=1), SequenceKey(idx=0), SequenceKey(idx=0), SequenceKey(idx=0), GetAttrKey(name='query_proj'), GetAttrKey(name='weight'))
Great package by the way.
—
Reply to this email directly, view it on GitHub
https://github.com/cjerzak/LinkOrgs-software/issues/5, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZEOAHX4RBKAKBEZ7F2BZTZTDPDZAVCNFSM6AAAAABNB3D5FWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4DIOBTGMYDCMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This is with windows, but let me quickly try it with ubuntu 24.04.

Sounds good; keep me posted. LinkOrgs hasn't been thoroughly tested on Windows yet (some of the dependencies likely require Linux/MacOS).


YAML Schema in schemastore is outdated

Creating function with v1.8.0 CLI creates a func.yaml with specVersion: 0.34.0 which doesn't seem to match what is currently served from the schemastore - I think that is serving the older 0.25.0 version

The latest-release branch has been updated to 1.8 (https://github.com/knative/func/tree/latest-release) and the schemastore has been updated: https://github.com/SchemaStore/schemastore/pull/2590. Note that VSCode should be using the latest-release branch so the referenced PR for schemastore is only a formality to add a named 1.8 schema.


update nlohmann_json to version 3.1.0

I just released JSON for Modern C++ 3.1.0, see https://github.com/nlohmann/json/releases/tag/v3.1.0. Could you please update the package nlohmann_json?
Please not the single header is not in src/json.hpp, but in single_include/nlohmann/json.hpp.

Testing: https://github.com/ruslo/hunter/pull/1337

Please not the single header is not in src/json.hpp, but in single_include/nlohmann/json.hpp.

Makes no change, till user's API is:
find_package(nlohmann_json CONFIG REQUIRED)
target_link_libraries(... PUBLIC nlohmann_json)

it doesn't matter where file is located and whether it's a single file header-only, multiple files header-only or "normal" headers + archive library.

Released: https://github.com/ruslo/hunter/releases/tag/v0.19.241


Fix typos.

There were the following issues with your Pull Request

Commit: 1ba6ff41f6819d3ca13f28002829de2e8c6bd4c8
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/serde-rs/serde

This message was auto-generated by https://gitcop.com

How embarrassing! Thanks!


Can the Volume Bar with Mute/unmute button be added to the overflow Menu ?

Have you read the Tutorials?
Yes
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v4.3.4
What browser and OS are you using?
On all Web browsers
I am looking to move the volume button to the overflow menu. Just trying to check if that's possible with config changes or does it require custom changes.

Right now it can't be done, the volume bar is not something we can easily put in the overflow menu. I will make the mute/unmute icon work overflow menu.


render animation w/o gui

Hi,
It seems my linux cannot install dearpygui, I'm wondering is it possible to render the animation without the GUI?

Hi,
could you please try turn off the gui to see whether it can animate? It should be able to save a video file even if no GUI is used.
Best

yes!! I figure out output the animation video by annotating the import line, thank you~


[GSSoC'23] Wishing Bot Model Ready

Description

Asking of the occasion which will occur or you want to greet to people
Then playing the song in the background related to that occasion
Creating different types of the emojis
Adding announcement of that occasion will makes it more attractive

Fixes #257
Replace issue_no with the issue number which is fixed in this PR
Have you read the Contributing Guidelines on Pull Requests?

[x] Yes

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I've edited the SCRIPTS.md and link to my code.
[x] I have created a helpful and easy to understand README.md
[x] My documentation follows Template for README.md
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@vanshitaverma @avinashkranjan please review this pull request for a successful contribution under GSSoC'23 program

@avinashkranjan Already done in different repo https://github.com/avinashkranjan/Amazing-Python-Scripts/pull/1777


Interpole Forge Model API with FRAPI

Can you please provide which APIs exactly should be bridged?

Forge's getModelData and getQuads does not default to Fabric emitBlockQuads and vice versa


crash with "All the Mods 7"

crash with "All the Mods 7"
It doesn't open the client at all

crash reports are required for crash issues.

It didn't provide any crash log, it is just that the launcher tried to open the game but to no avail.
I just can say that I was using the modpack mentioned above along with Rubidium (Sodium) & addons, Radium reforged (Lithium) and  Radon (Phosphor).

Without a crash log such an issue cannot be diagnosed.  You should probably just wait until the ATM7 pack updates to that version manually.

Cause: Radium reforged


HOSTEDCP-1273: Added support for OLM Disable default sources on HC creation

The pull request (PR) embeds the OperatorHubSpec field into the hostedcluster.Spec.Configuration API field. This allows us to disable/enable default sources in Management or Guest placement only during creation.
This functionality is also incorporated into the CLIs through a flag called olmDisableDefaultSources.
However, it's important to note that the OperatorHub capability to disable/enable individual default sources is not covered in this PR. As a result, that field will be disregarded in the CPO and HCCO reconciliation.
Signed-off-by: Juan Manuel Parrilla Madrid<EMAIL_ADDRESS>Which issue(s) this PR fixes:
Fixes #HOSTEDCP-1273

There is a bug with kube::codegen (https://github.com/kubernetes/code-generator/issues/165), to workaround it, just go to your $GOPATH/github.com/<user>/hypershift update the branch and run make clients. That should solve the issue. kudos to @csrwng++.

Yeah looks good.  tests haven't passed but:
/lgtm

/approve

/cherry-pick release-4.15

/cherry-pick release-4.14


Grom Hellscream priority order

cant fix that as far as i know, i think they are talking about the top left icons of heroes, not the actual control groups order

and that cannot be fixed in anyway i know

It's technically possible if we mess around with moving unit ownership around. Will think about it.

Sebas is right that it's quite hard to fix and it's probably not worth the complexity to do so. Closing. Can re-open if someone is keen to work on it.


Little mistakes in section exolve-relabel in README

In section exolve-relabel:

manage-storage-hover should be manage-storage.hover
manage-storage-close-hover should be manage-storage-close.hover

Thanks for catching!
Have fixed these with https://github.com/viresh-ratnakar/exolve/commit/6f81b9ae3d01928de80a2c11355854286c06a18b

Thanks for this awesome software!


Weather visualizer

The Pull Request adds  the  feature of weather visualization to the website . It let the viewers explore and vizualize the scene's  by changing  weather type and also cloud coverage or fog intensity.
The four different weather types are Sunny, Cloudy , Rainy and Foggy
https://user-images.githubusercontent.com/78009952/163719245-06c851c8-0c4a-4318-bda7-48a063b320a7.mp4
Fixes #21

@yashika51  please review this?


Feature request: Windows OS support

I would like to request a support for Windows operating system. Currently, rclone can be utilized using an executable file in Windows. Maybe the library can be configured to the location of the .exe file so it can be usable to Conda/Python in a Windows environment.

Haven tried, but it seems the code only assumes rclone.exe is on path.


HDFS-15739.Add missing Javadoc for a param in method chooseRandomWit…

Only add missing Javadoc for a param in method chooseRandomWithStorageType of AppSchedulingInfo.java.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 34s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 51s

trunk passed

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
1m 16s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 48s

trunk passed

+1 :green_heart:
mvnsite
1m 25s

trunk passed

+1 :green_heart:
shadedclient
18m  1s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 54s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 24s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
3m  3s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  1s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
checkstyle
0m 39s

the patch passed

+1 :green_heart:
mvnsite
1m 10s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 53s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
3m  2s

the patch passed

_ Other Tests _

-1 :x:
unit
97m 12s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

186m 57s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2565/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2565

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 3be14723aaa4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7a88f453667

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2565/1/testReport/

Max. process+thread count
4090 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2565/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

+1 LGTM. The failed UTs are unrelated with this issue.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 22s

trunk passed

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
1m 12s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 49s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
shadedclient
17m 57s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 56s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
3m  6s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m  4s

trunk passed

-0 :warning:
patch
3m 24s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 10s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
compile
1m  6s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
1m  6s

the patch passed

+1 :green_heart:
checkstyle
0m 39s

the patch passed

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 29s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
3m  3s

the patch passed

_ Other Tests _

-1 :x:
unit
97m 32s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

187m  9s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks

hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2565/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2565

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 59e2465b1501 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3d2193cd648

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2565/2/testReport/

Max. process+thread count
4467 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2565/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


[Backport] [2.x] Bump io.projectreactor.netty:reactor-netty from 1.1.3 to 1.1.4 in /plugins/repository-azure (#6550)

Backport of https://github.com/opensearch-project/OpenSearch/pull/6550 to 2.x

Codecov Report

Merging #6554 (e1d5d6e) into 2.x (39f25dc) will increase coverage by 0.07%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##                2.x    #6554      +/-   ##
============================================
+ Coverage     70.35%   70.43%   +0.07%
- Complexity    59263    59288      +25
============================================
  Files          4800     4800
  Lines        284603   284603
  Branches      41351    41351
============================================
+ Hits         200230   200456     +226
+ Misses        67653    67444     -209
+ Partials      16720    16703      -17

Impacted Files
Coverage Δ

.../java/org/opensearch/node/NodeClosedException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

.../admin/cluster/reroute/ClusterRerouteResponse.java
60.00% <0.00%> (-40.00%)
:arrow_down:

...luster/routing/allocation/RoutingExplanations.java
62.06% <0.00%> (-37.94%)
:arrow_down:

...arch/search/aggregations/pipeline/LinearModel.java
23.07% <0.00%> (-30.77%)
:arrow_down:

...search/aggregations/metrics/ParsedPercentiles.java
46.31% <0.00%> (-30.53%)
:arrow_down:

...cluster/routing/allocation/RerouteExplanation.java
70.00% <0.00%> (-30.00%)
:arrow_down:

...search/search/aggregations/pipeline/EwmaModel.java
24.44% <0.00%> (-28.89%)
:arrow_down:

...c/main/java/org/opensearch/geometry/MultiLine.java
80.00% <0.00%> (-20.00%)
:arrow_down:

...n/java/org/opensearch/test/rest/yaml/Features.java
60.00% <0.00%> (-20.00%)
:arrow_down:

...search/test/rest/yaml/section/TeardownSection.java
66.66% <0.00%> (-18.52%)
:arrow_down:

... and 456 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


bug: Fix install from source will lose version information

Signed-off-by: Jinjing.Zhou<EMAIL_ADDRESS>

Tested on my macos, now envd binary from source has a proper version


Documentation

Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

This change is

Fully resolves #102

I thought the issue templates needed to be in .github?

I'll move it back then.

Ah right! They're actually supported in the main directory. Looks a bit messy, and is different from other cookbooks.


Removed alert_header from "No alert rules defined" table row in WebUI

This is a minor UX change. The current "No Alert rules" table row has the alert_header class attached. This changes the cursor and some other stuff and makes sense with the populated table but less sense with the unpopulated table. So removing it in the latter case.
/cc @juliusv

:+1: Thanks!


Feature: Specify target output (e.g. web, electron-renderer)

Bug Report or Feature Request (mark with an x)
- [ ] bug report -> please search issues before submitting
- [x] feature request

Versions.

@angular/cli: 1.0.0
node: 7.8.0
os: darwin x64
@angular/animations: 4.0.1
@angular/common: 4.0.1
@angular/compiler: 4.0.1
@angular/core: 4.0.1
@angular/flex-layout: 2.0.0-rc.1
@angular/forms: 4.0.1
@angular/http: 4.0.1
@angular/material: 2.0.0-beta.2
@angular/platform-browser: 4.0.1
@angular/platform-browser-dynamic: 4.0.1
@angular/router: 4.0.1
@angular/cli: 1.0.0
@angular/compiler-cli: 4.0.1
Repro steps.

N/A
The log given by the failure.

N/A
Desired functionality.

In order to target electron-renderer, you currently have to run ng eject and modify the output webpack configuration to update the target.
I propose adding a similar setting to angular-cli.json to specify the intended target.
Mention any other details that might be useful.

Link to webpack target documentation.

This would make sense and hold true with the whole "One Framework Mobile & Desktop" goal of angular itself.
I've been keeping tabs on this project @ashkandaie in the mean time, after reading this issue i dont have much hope that electron will be a 1st class citizen with the CLI any time soon. #1774

Currently we don't support other targets, but it's something we're looking at for 2.x.

This is also an issue for anybody trying to use Universal and Angular-CLI

Is this related to this issue?
https://github.com/angular/angular-cli/issues/4227
I have having the issue above where it can't find fs, and the solutions on that post did not resolve it

Here is a very clever hack that is currently working as a postinstall script, which changes the webpack config build target to electron-renderer...
https://github.com/maximegris/angular-electron/blob/master/postinstall.js

@colinskow Very clever indeed, I've implemented it here as well!
https://github.com/Kaffiend/electron-angular-ngrx

There is also https://github.com/manfredsteyer/ngx-build-plus for another unofficial but recommended solution for customization of the underlying webpack configuration.
Closing as there are multiple solutions listed in this thread and this is not something that will be supported directly by the CLI.


Rollup node stops to invoke the kernel while still producing commitments

Case:

originate smart rollup — ok
launch rollup node — producing commitments ok, kernel is executed (seen in logs)
at some point kernel logs are not there yet + internal state is not updated
rollup keeps progressing though
panic hook enabled
no inbox messages (i.e. everythin should be deterministic)

Logs
Apr 12 09:12:29.160 - sc_rollup_injector:   Request pushed on 2023-04-12T09:12:29.160-00:00, treated in 3.580us, completed in 1.380us
Apr 12 09:12:29.160 - sc_rollup_injector: [tz1N96ka7u5cK: publish, add_messages, cement, refute] injection
Apr 12 09:12:29.160 - sc_rollup_node.batcher.worker:   Request pushed on 2023-04-12T09:12:29.159-00:00, treated in 4.670us, completed in 2.210us
Apr 12 09:12:29.160 - sc_rollup_node.batcher.worker: batch
Apr 12 09:12:29.124 - sc_rollup_injector:   2350975
Apr 12 09:12:29.124 - sc_rollup_injector: [tz1N96ka7u5cK: publish, add_messages, cement, refute] Confirmed Tezos level
Apr 12 09:12:29.124 - sc_rollup_injector: [tz1N96ka7u5cK: publish, add_messages, cement, refute] Reverting operations:
Apr 12 09:12:29.124 - sc_rollup_node.daemon: Finished processing 1 layer 1 heads for levels 2350977 to 2350977
Apr 12 09:12:29.124 - sc_rollup_node.daemon:   BLvcDXSQo9LmZz5RYPerXH65cfCG2J8xLbYb4em11yQxeCfYJhC at level 2350977
Apr 12 09:12:29.124 - sc_rollup_node.daemon: Finished processing layer 1 head
Apr 12 09:12:29.122 - sc_rollup_node.interpreter:<PHONE_NUMBER>00440 with 3 messages
Apr 12 09:12:29.122 - sc_rollup_node.interpreter:   srs12uWKvdFZKe4gHcWW4v5t4owzdznpvckrBS5Lso3tEPkCpoQJK5 at tick
Apr 12 09:12:29.122 - sc_rollup_node.interpreter: Transitioned PVM at inbox level 2350977 to
Apr 12 09:12:28.881 - sc_rollup_node.inbox:   BLvcDXSQo9LmZz5RYPerXH65cfCG2J8xLbYb4em11yQxeCfYJhC at level 2350977
Apr 12 09:12:28.881 - sc_rollup_node.inbox: Fetching 0 messages from block
Apr 12 09:12:28.881 - sc_rollup_node.daemon:   level 2350977
Apr 12 09:12:28.881 - sc_rollup_node.daemon: Processing new head BLvcDXSQo9LmZz5RYPerXH65cfCG2J8xLbYb4em11yQxeCfYJhC at
Apr 12 09:12:28.881 - sc_rollup_node.daemon:   level 2350977 to level 2350977
Apr 12 09:12:28.881 - sc_rollup_node.daemon: A new iteration of process_heads has been triggered: processing 1 heads from
Apr 12 09:12:28.741 - sc_rollup_node.layer_1:   BLvcDXSQo9LmZz5RYPerXH65cfCG2J8xLbYb4em11yQxeCfYJhC at level 2350977
Apr 12 09:12:28.741 - sc_rollup_node.layer_1: Layer 1 node has switched to head
Apr 12 09:12:17.349 - sc_rollup_injector:   Request pushed on 2023-04-12T09:12:17.348-00:00, treated in 5.990us, completed in 1.780us
Apr 12 09:12:17.349 - sc_rollup_injector: [tz1N96ka7u5cK: publish, add_messages, cement, refute] injection
Apr 12 09:12:17.349 - sc_rollup_node.batcher.worker:   Request pushed on 2023-04-12T09:12:17.348-00:00, treated in 5.490us, completed in 2.890us
Apr 12 09:12:17.349 - sc_rollup_node.batcher.worker: batch
Apr 12 09:12:17.297 - sc_rollup_injector:   2350975
Apr 12 09:12:17.297 - sc_rollup_injector: [tz1N96ka7u5cK: publish, add_messages, cement, refute] Confirmed Tezos level
Apr 12 09:12:17.297 - sc_rollup_injector: [tz1N96ka7u5cK: publish, add_messages, cement, refute] Reverting operations:
Apr 12 09:12:17.297 - sc_rollup_node.daemon: Finished processing 2 layer 1 heads for levels 2350976 to 2350977
Apr 12 09:12:17.297 - sc_rollup_node.daemon:   BKxWS7CjsQGDZfUoHCwGSjiZWzCKneM2uJbazFpb5fupx7qpYJH at level 2350977
Apr 12 09:12:17.297 - sc_rollup_node.daemon: Finished processing layer 1 head
Apr 12 09:12:17.296 - sc_rollup_node.daemon:   at level 2350975
Apr 12 09:12:17.296 - sc_rollup_node.daemon: Processing finalized head BLS3qpkefG9wRt9RFhio8EUerZ3tAGARG4QNtNiaVQFqZnVScRT
Apr 12 09:12:17.294 - sc_rollup_node.interpreter:<PHONE_NUMBER>00000 with 3 messages
Apr 12 09:12:17.294 - sc_rollup_node.interpreter:   srs11f3WiPjEiJSeF4nUjow7afeLaizCi1pH4QvyTswA7Yr871sYqb at tick
Apr 12 09:12:17.294 - sc_rollup_node.interpreter: Transitioned PVM at inbox level 2350977 to
Apr 12 09:12:17.292 - smart_rollup_node: "Kernel yields"
Apr 12 09:12:17.292 - smart_rollup_node: "Batch applied: lvl: 17392, ts:<PHONE_NUMBER>, hash: BLZ1CCCrci[...]"
Apr 12 09:12:17.291 - smart_rollup_node: "L1 predecessor block: BLTUwqG6SaHgmN7wKSwP8rPu7F8Ppj6Qa7R2b[...]"
Apr 12 09:12:17.291 - smart_rollup_node: "Kernel invoked, prev head: lvl: 17391, ts:<PHONE_NUMBER>, hash[...]"
Apr 12 09:12:17.269 - sc_rollup_node.inbox:   BKxWS7CjsQGDZfUoHCwGSjiZWzCKneM2uJbazFpb5fupx7qpYJH at level 2350977
Apr 12 09:12:17.269 - sc_rollup_node.inbox: Fetching 0 messages from block
Apr 12 09:12:17.266 - sc_rollup_node.daemon:   level 2350977
Apr 12 09:12:17.266 - sc_rollup_node.daemon: Processing new head BKxWS7CjsQGDZfUoHCwGSjiZWzCKneM2uJbazFpb5fupx7qpYJH at
Apr 12 09:12:17.266 - sc_rollup_node.daemon:   BLTUwqG6SaHgmN7wKSwP8rPu7F8Ppj6Qa7R2bfuFukrgm6DjNcy at level 2350976
Apr 12 09:12:17.266 - sc_rollup_node.daemon: Finished processing layer 1 head
Apr 12 09:12:17.266 - sc_rollup_node.interpreter:<PHONE_NUMBER>00000 with 3 messages
Apr 12 09:12:17.266 - sc_rollup_node.interpreter:   srs12nvw4pA3Ss9RuU2uopHKA6MYLDKAf3DGPPzaNDYY8w1h9YH6sq at tick
Apr 12 09:12:17.265 - sc_rollup_node.interpreter: Transitioned PVM at inbox level 2350976 to
Apr 12 09:12:17.265 - smart_rollup_node: "Kernel yields"
Apr 12 09:12:17.265 - smart_rollup_node: "Batch applied: lvl: 17391, ts:<PHONE_NUMBER>, hash: BLs8SNgmbb[...]"
Apr 12 09:12:17.264 - smart_rollup_node: "L1 predecessor block: BLS3qpkefG9wRt9RFhio8EUerZ3tAGARG4QNt[...]"
Apr 12 09:12:17.263 - smart_rollup_node: "Kernel invoked, prev head: lvl: 17390, ts:<PHONE_NUMBER>, hash[...]"
Apr 12 09:12:17.238 - sc_rollup_node.inbox:   BLTUwqG6SaHgmN7wKSwP8rPu7F8Ppj6Qa7R2bfuFukrgm6DjNcy at level 2350976
Apr 12 09:12:17.238 - sc_rollup_node.inbox: Fetching 0 messages from block
Apr 12 09:12:17.237 - sc_rollup_node.daemon:   level 2350976
Apr 12 09:12:17.237 - sc_rollup_node.daemon: Processing new head BLTUwqG6SaHgmN7wKSwP8rPu7F8Ppj6Qa7R2bfuFukrgm6DjNcy at
Apr 12 09:12:17.237 - sc_rollup_node.daemon:   level 2350976 to level 2350977
Apr 12 09:12:17.237 - sc_rollup_node.daemon: A new iteration of process_heads has been triggered: processing 2 heads from
Apr 12 09:12:17.125 - sc_rollup_node.layer_1:   BKxWS7CjsQGDZfUoHCwGSjiZWzCKneM2uJbazFpb5fupx7qpYJH at level 2350977
Apr 12 09:12:17.125 - sc_rollup_node.layer_1: Layer 1 node has switched to head

After restarting the operator (and clearing its context) the node was able to move forward slightly, but then stucked again.
Possibly related issue: https://gitlab.com/tezos/tezos/-/issues/5439

Resolved by #19